Revert "unix,stream: clear read/write states on close/eof"

This reverts commit 12be29f185261b8a7e6ada596fd805919cb2b133.
The commit in question was introducing failures in the Node.js
test suite.
Refs: https://github.com/libuv/libuv/issues/2943
Refs: https://github.com/libuv/libuv/pull/2967

CI: https://ci.nodejs.org/view/libuv/job/libuv-test-commit/2018/
Node.js+libuv integration CI: https://ci.nodejs.org/view/libuv/job/libuv-in-node/160/

CI seems fine other than what appears to be infra related issues on Windows. I'm going to land this now.

Landed in https://github.com/libuv/libuv/commit/46f36e3df1a666620f6749427f15651cbc4b7001.


Typo Fixed

Coverage remained the same at 90.98% when pulling cb8decdfaa619274a82986d8f3f27ac7e00b4be3 on terryyz:master into f7b8811b14e27e67b9f4a2a4457240b5380708d5 on ssut:master.


[WIP] add ability for port mapping to work with non jupyter-workflow

Need to still add tests.
One question is I have removed the get random port method from repo2docker as docker-py supports assigning random ports if None is passed in the dict
https://github.com/docker/docker-py/blob/190d95c61cc0440108de8a0c14027e72c56b6772/docker/models/containers.py#L596
Do we need to have the default run_cmd jupyter notebook started in the same port inside the container as outside? Is there are necessity for that?
Closes part 1 of #100

@mukundans91 yeah, we need to try to get the same port inside and outside since the notebook prints a URL at the end saying 'go to this URL to access your notebook', including a secret token in the URL. This only works if it's listening on the same port inside and outside...

@yuvipanda thanks for the response. Will revert that part of the change...


Wipe Mobile Account as part of deprovision

As part of the de-provisioning process I would like to automate mobile account wipe. I know I can capture a user's device ID's via gam print mobile query , however there does not appear to be a command to just wipe account and not the entire device. Any assistance/advice would be helpful.

Try:
gam mobile  account_wipe
the command has been there for ages it just wasn't documented. I've updated the docs and will close this out now.


Warning: Missing base path. Consider 'base' option.

Question
Getting the following error when running npm run build:
Warning: Missing base path. Consider 'base' option.

My config:
    critical({
      criticalUrl: 'http://web',
      criticalBase: './web/dist/criticalcss/',
      criticalPages: [
        { uri: '/', template: 'index' },
      ],
    }),

web is one of my service in my Docker-based setup.
Full output:
><EMAIL_ADDRESS>build /app
> vite build

postcss-discard: postcss.plugin was deprecated. Migration guide:
https://evilmartians.com/chronicles/postcss-8-plugin-migration
vite v2.3.7 building for production...
transforming (14) src/vue/Confetti.vue[vite:css] /app/src/css/utils/typography.pcss is empty
1  |  @import 'tailwindcss/base';
2  |  @import 'tailwindcss/components';
   |   ^
3  |  @import 'tailwindcss/utilities';
4  |
[vite:css] /app/src/css/utils/vendor.pcss is empty
2  |  @import 'tailwindcss/components';
3  |  @import 'tailwindcss/utilities';
4  |
   |   ^
5  |  @import 'utils/base.pcss';
6  |  @import 'components/base.pcss';
✓ 27 modules transformed.
rendering chunks (1)...Sourcemap is likely to be incorrect: a plugin (vite:css-post) was used to transform files, but didn't generate a sourcemap for the transformation. Consult the plugin documentation for help
Sourcemap is likely to be incorrect: a plugin (vite:import-analysis) was used to transform files, but didn't generate a sourcemap for the transformation. Consult the plugin documentation for help
rendering chunks (3)...Sourcemap is likely to be incorrect: a plugin (vite:define) was used to transform files, but didn't generate a sourcemap for the transformation. Consult the plugin documentation for help
Sourcemap is likely to be incorrect: a plugin (vite:define) was used to transform files, but didn't generate a sourcemap for the transformation. Consult the plugin documentation for help
Sourcemap is likely to be incorrect: a plugin (vite:define) was used to transform files, but didn't generate a sourcemap for the transformation. Consult the plugin documentation for help
web/dist/assets/lazysizes-legacy.f22f6e95.js   7.38kb / brotli: 3.05kb
web/dist/assets/lazysizes-legacy.f22f6e95.js.map 22.53kb
web/dist/assets/app-legacy.5f35c5f0.js         22.24kb / brotli: 4.91kb
web/dist/assets/app-legacy.5f35c5f0.js.map     0.10kb
web/dist/assets/vendor-legacy.bff03df2.js      22.88kb / brotli: 7.92kb
web/dist/assets/vendor-legacy.bff03df2.js.map  0.10kb
web/dist/assets/polyfills-legacy.549bb6d1.js   41.76kb / brotli: 14.76kb
rendering chunks (1)...Sourcemap is likely to be incorrect: a plugin (vite:import-analysis) was used to transform files, but didn't generate a sourcemap for the transformation. Consult the plugin documentation for help
rendering chunks (3)...Sourcemap is likely to be incorrect: a plugin (vite:define) was used to transform files, but didn't generate a sourcemap for the transformation. Consult the plugin documentation for help
Sourcemap is likely to be incorrect: a plugin (vite:define) was used to transform files, but didn't generate a sourcemap for the transformation. Consult the plugin documentation for help
Sourcemap is likely to be incorrect: a plugin (vite:define) was used to transform files, but didn't generate a sourcemap for the transformation. Consult the plugin documentation for help
Generating critical CSS from http://web/ to index_critical.min.css
web/dist/assets/WorkSans-Regular.ec25aa37.woff2      69.74kb
web/dist/assets/WorkSans-Italic.abb054a7.woff2       64.42kb
web/dist/assets/WorkSans-Bold.a616b751.woff2         74.10kb
web/dist/assets/WorkSans-BoldItalic.3afecc5a.woff2   68.47kb
web/dist/assets/WorkSans-Black.138beb40.woff2        68.54kb
web/dist/assets/FiraCode-Regular.105c876c.woff2      100.75kb
web/dist/assets/FiraCode-Bold.72e84e14.woff2         104.87kb
web/dist/assets/WorkSans-Italic.fe920528.woff        90.39kb
web/dist/assets/WorkSans-BoldItalic.8fa25a73.woff    95.96kb
web/dist/assets/WorkSans-Black.17ea169f.woff         92.05kb
web/dist/assets/WorkSans-Regular.6f8cccb6.woff       96.48kb
web/dist/assets/WorkSans-Bold.bddfac33.woff          102.63kb
web/dist/assets/FiraCode-Regular.33b9f771.woff       131.13kb
web/dist/assets/FiraCode-Bold.78408fee.woff          136.86kb
web/dist/manifest.json                               2.36kb
web/dist/assets/app.70bede6d.js                      2.00kb / brotli: 0.90kb
web/dist/assets/app.70bede6d.js.map                  0.09kb
web/dist/assets/lazysizes.6959aafd.js                7.30kb / brotli: 3.03kb
web/dist/assets/lazysizes.6959aafd.js.map            33.43kb
web/dist/assets/app.97a6b99f.css                     21.13kb / brotli: 4.39kb
web/dist/assets/vendor.323c439a.js                   22.81kb / brotli: 7.88kb
web/dist/assets/vendor.323c439a.js.map               23.83kb
Warning: Missing base path. Consider 'base' option. https://goo.gl/PwvFVb

Additional context
Did almost every changes (except for cms/templates/_boilerplate/_partials/critical-css.twig) found here: https://github.com/nystudio107/craft/commit/487ad1ff1197a22a78829c1fe6ee7bb26b7c9afe
Adding base option to critical itself or to criticalConfig did not help. The criticalCSS files are generated fine, though.

So everything works, but you're seeing that warning?
It leads here: https://github.com/addyosmani/critical#options
Which is a little confusing to me, because we're setting it here:
https://github.com/nystudio107/rollup-plugin-critical/blob/master/src/index.ts#L57

Exactly, that's why I thought opening an issue would be useful.

As you can see, the index and contact criticalCSS files are generated fine (with different content inside them).

Looks like it could happen due to lack of CSS:
https://github.com/addyosmani/critical/blob/master/src/file.js#L446
If you search on BASE_WARNING you can see 2 other places where this error is omitted, but I'm betting this is CSS related, because we definitely are passing the path in, and I'm not seeing this error.

Thanks for going after this, it happens here: https://github.com/addyosmani/critical/blob/master/src/file.js#L575

It happens because there is no stylesheet referenced with <link rel="stylesheet" ...>. When I added this to the <head>, the warning was gone.

That's pretty interesting -- I think you can ignore the warning, because the Critical plugin provides the CSS generated by Vite for Critical to use, so it shouldn't need to scrape anything from the HTML document itself.

The warning still occurs, but it's comforting to see we can ignore it, and the critical CSS is still being generated as it should.


Add source code to openshift-ci image

Since our integration test depend on the source code we need to
put that in the image creation so during the test step we can
able to scp to the VM and run the integration test.

What do they need exactly?

@cfergeau In Openshift-CI the container which run test need to have source code so we can scp to the created VM.

Dunno what other projects are doing?

Openshift related projects like installer depend on the openshift-tests binary which perform the e2e tests and we don't have any testing binary.

Another option could be to copy built binaries and the test descriptions to the image?

yes but if we copy the test descriptions then what is issue of copying the source, at least then we can just run make integration as we run on our dev box.


Rerun command should also support repository write+ users

The rerun command is great to have as an option; right now it only supports the PR author, which may be a bit unfamiliar to any early contributors to a project.
Would it be possible to have this expanded to support this command coming from anyone with write access or more to the repository, or at least admins, so that the project maintainers also have the option of kicking the CLA?
[Related to https://github.com/microsoft/ContributorLicenseAgreement/issues/123]

I second this request. As a project maintainer, it would be much easier for me to issue the command and the bot do its thing instead of having to explain it to the PR author and wait for that to happen.

Will add this feature this week with the linked pr and subsequent deployment.

Very cool!

Brilliant! 👏🏻


Qasm comments are //, not \

Trying to fix issue https://github.com/IBM/qiskit-openqasm/issues/7

A fix is already proposed in https://github.com/IBM/qiskit-openqasm/pull/8


I try to train SiamMask, but there is an Error: Assertion Error: snaptshot/checkpoint_e123456--20.pth is not a valid file

i  try to train this tracker. But i faced some problems
Assertion Error: snaptshot/checkpoint_e123456--20.pth is not a valid file
I've checked the issues that someone said remove "--resume snapshot/checkpoint_e9.pth" from run.sh
like follow:

but the question is still there....

so... what should i do

same issue, have you figured out?


fix errors

fix typo: attatch -> attach
fix error in sample code in README.md: Wire.begin(21, 22) -> Wire.begin()

Sorry for late reply, cool. Thanks!


ARROW-12859: [C++] Add ScalarFromJSON for testing

ScalarFromJSON(int64(), "null") == Datum(Int64Scalar())
ScalarFromJSON(int64(), "5")    == Datum(Int64Scalar(5))

Is there anything left to do here?

Is there anything left to do here?

I don't think so unless we really want to use Scalar::CastTo here.

Can you explain the Scalar::CastTo suggestion? I think I'm missing something.
Also, I notice this isn't actually tested? Perhaps add a test alongside those for ArrayFromJSON. And ensure that a non-1 length array would return an error?

For CastTo: I think it was actually the Cast kernel (string->type cast).
I added some basic tests. I don't think there's a good way to hit the DCHECK because that would imply a JSON value converter appended two array values for a single JSON value.


Small fixes

Added language setup like LostInTransit and RiskyMod.
Added lines upon CHEF picking up an associated items. To not destroy the meaning from translating from French to other languages, here's the original english strings:
            string[] responsesEigo = new string[]
            {
                "Mmm.. Tasty!",
                "I want some more!",
                "Delicious.",
                "Not bad.",
                "Hey.. that's pretty good.",
                "Tasty.",
                "That's good."
            };

I also tried making some DeepL translated folders for German and French (used google for Sear, Blaze, Glaze, and Marinate because DeepL couldn't translate it with the large amount of style tags but they are a little "fucked" (not all unicode characters work in ror2's font, so you end up with ? marks).

Actually, I'll just DeepL and google translate the rest of the languages, so at least they're there.


C++ cross-platform CMake example

The past few days I've been working on a sample CMake project to target both Linux and Windows. It was a bit of a pain to set it all up, but I think it's quite nice now. I'm posting it here for anyone who's interested in doing something similar. Some nice features of this example:

[x] Link all libraries statically on Windows
[x] A sample website with various interactions with the C++ backend

Link to the repository: https://github.com/wilricknl/webview_cpp

Belated thank you for this example! PR #1130 has been submitted with CMake integration so I believe this can be closed once the PR is merged.


[WFLY-14171]:Upgrade jbossws-spi to 3.3.1.Final

https://issues.redhat.com/browse/WFLY-14171

I filed https://issues.redhat.com/browse/WFLY-14185 for the one CI failure, which I'll regard as unrelated.
https://ci.wildfly.org/viewLog.html?buildId=233147& is testing this with -Dts.ee9


update telegraf 1.13.3 => 1.13.4

Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[x] other Linux distributions (Arch Linux)

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg build telegraf

@GrahamcOfBorg test telegraf


Suggestion: allow use of PgUp and PgDown scrolling (among other suggestions)

So, like the title says. Here are some suggestions I think that would streamline the theme selector.

Allow use of PgUp and PgDown for scrolling (this goes faster than using arrow up and down one at a time).
Theme previews (hovering over a theme shows a preview of what it will look like, either by temporarily themeing Alacritty or something)

I'm not sure how possible this is with npm/node.

I am not sure using Page up and down is possible, but you can always fuzzy search by typing the characters
The second issue is fixed in latest version 3.0.0

I'm running it on Arch Linux with npx and PgUp and PgDown are working fine. I guess it's the default behaviour of propmts. If you're using Mac, on their API page they say that you should use fn + ⇧ / ⇩ instead.
https://github.com/terkelg/prompts#autocompletemessage-choices-initial-suggest-limit-stylec:

I'm closing this issue because we don't have enough information, and it seems one user is able to use it as expected.


Section Containing Section

Hi,
I have a scenario where a section represents a feature for my site, and in turn it can have multiple sections. I see that in Site Prism the hierarchy is little different. Can we have this as a feature request? or is there any way I can achieve this?
Thanks,
Pushkar Pahare

I think this is already supported, closing the issue!


Creating release with prefix "v" does not trigger PyPi release

prefixing with "v is apparently best practice, but such tags do not trigger the current github actions for releasing to PyPi.

Can we modify the github action to handle tags with prefix "v"?
Or do we have to tag PyPi releases without the prefix?

Discussion from mob programming session. Team agree to use version without "v" so no need to do anything.
Closing.


The error message for already-installed-but-not-linked formulae is not clear

[x] Confirmed this is a problem with running a brew command and just brew installing one or more formulae? If it's a formulae-specific problem please file this issue at https://github.com/Homebrew/homebrew-core/issues/new
[x] Ran brew update and retried your prior step?
[x] Ran brew doctor, fixed all issues and retried your prior step?
[ ] Ran brew config and brew doctor and included their output with your issue?

When I run
brew install bash-completion@2
brew unlink  bash-completion@2
brew install bash-completion@2

I get back:
Warning<EMAIL_ADDRESS>already installed, it's just not linked.

and I don't know what to do.
When I run brew doctor, it tells me:
Warning: You have unlinked kegs in your Cellar
Leaving kegs unlinked can lead to build-trouble and cause brews that depend on
those kegs to fail to run properly once built. Run `brew link` on these:
  bash-completion@2

Could that information go in the warning, like:
Warning<EMAIL_ADDRESS>is already installed, it's just not linked.
To link it, run `brew link bash-completion@2`

Ran brew config and brew doctor and included their output with your issue?

Please do this.

I updated the above comment with that output, sorry about that.

I'm getting this for tons of packages.  I've looked at all commands that indicate issues and not seeing anything whatsoever that helps resolve this.  This never use to be a problem.  What is going on here with installing specific versions, specifically?


typo fix

Coverage remained the same at 99.439% when pulling c549f909524a006eb0d1bb461c3bf8966981e922 on nplusp:patch-1 into dbb1be7683a2d0e229f3fec601af80d26abd66d4 on davydovanton:master.

Coverage remained the same at 99.439% when pulling c549f909524a006eb0d1bb461c3bf8966981e922 on nplusp:patch-1 into dbb1be7683a2d0e229f3fec601af80d26abd66d4 on davydovanton:master.

Coverage remained the same at 99.439% when pulling c549f909524a006eb0d1bb461c3bf8966981e922 on nplusp:patch-1 into dbb1be7683a2d0e229f3fec601af80d26abd66d4 on davydovanton:master.

thanks ❤


Updated reference file location

Instruction was pointing to a local file when it should be referencing the file in the observability workshop repo.
Might also need to add a line/statement that the observability workshop repo is required.
Pull Request Template
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[ ] Test A
[ ] Test B

Checklist

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] Markdown Lint passes locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

@iortiz-splunk Did you use a workshop instance? If you spin up multipass or EC2 workshop instance there is a directory called workshop under home/ubuntu where workshop files are stored including the pet clinic locust file.


fix batch insert sql parser bug

fixed 947

Codecov Report

Merging #951 into dev will increase coverage by 0.01%.
The diff coverage is 50%.

@@            Coverage Diff             @@
##              dev     #951      +/-   ##
==========================================
+ Coverage   52.96%   52.98%   +0.01%
==========================================
  Files         577      577
  Lines       12114    12114
  Branches     1916     1916
==========================================
+ Hits         6416     6418       +2
+ Misses       5328     5325       -3
- Partials      370      371       +1

Impacted Files
Coverage Δ

...re/core/optimizer/insert/InsertOptimizeEngine.java
79.48% <50%> (ø)
:arrow_up:

...al/state/datasource/DataSourceListenerManager.java
40% <0%> (+3.33%)
:arrow_up:

...ce/OrchestrationShardingDataSourceFactoryBean.java
77.77% <0%> (+11.11%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46e8d31...5f438d4. Read the comment docs.


xcode 10 can,t use

I can't use injectionX in xcode10 ...............

Please see https://github.com/johnno1962/InjectionIII/issues/47#issuecomment-428529229


gdp-hmi: Bump version LUC and Desktopfiles

Bump the GDP HMI to a version that supports:

handling applications through ".desktop" files instead of ".app" files
together with ".service" files.
Last User Context. That is when the HMI is restarted the last running
application will automatically be started.

This change means that applications are no longer started through systemd
but instead through the HMI directly. This requires the HMI to be aware
of the DBus user session bus that some apps use.
[GDP-555] Mechanism to register & launch apps in HMI
[GDP-556] HMI implements Last User Context
Signed-off-by: Viktor Sjölind<EMAIL_ADDRESS>

Oh and build fails for:
18:31:07.182 | install: cannot stat '/var/lib/go-agent/pipelines/GDP-Yocto-Dragonboard-meta-genivi-dev-GITHUB-PR/gdp/gdp-src-build/tmp/work/aarch64-poky-linux/hvac/1.0-r0/git/com.genivi.gdp.hvac.app': No such file or directory
You probably forgot to update recipe for HVAC app.

I am closing this and reopening it as another PR to see if I get the CI to build from scratch.


Update pl.po

valid is poprawna, invalid will be niepoprawna

Thanks, but translations should be changed on Weblate: https://hosted.weblate.org/projects/godot-engine/
The version here is just a copy synced from Weblate, it would be overridden if not changed on Weblate.


[TS migration] Migrate 'HeaderWithBackButton' component to TypeScript

Details

[TS migration] Migrate 'HeaderWithBackButton' component to TypeScript
Fixed Issues

$ https://github.com/Expensify/App/issues/25120
PROPOSAL: N/A
Tests

[x] Verify that no errors appear in the JS console

Open the app and login.
Open any Money Request - make sure the avatars in the header look ok and the header has a bottom border.
Go to any chat with an attachment and open it - make sure Attachment view has close and download buttons. When you click on the download button it should change the color and temporary be disabled.
Go to Settings, make sure the back button looks and works as expected.
Open Workspaces -> any Workspace. Make sure Get Assistance (?) button in the header looks and works as expected. After that click on three dots button in the header and tap on the Go to admins room option. Make sure three dots button looks and works as expected.

Offline tests

N/A
QA Steps

[x] Verify that no errors appear in the JS console

Open the app and login.
Open any Money Request - make sure the avatars in the header look ok and the header has a bottom border.
Go to any chat with an attachment and open it - make sure Attachment view has close and download buttons. When you click on the download button it should change the color and temporary be disabled.
Go to Settings, make sure the back button looks and works as expected.
Open Workspaces -> any Workspace. Make sure Get Assistance (?) button in the header looks and works as expected. After that click on three dots button in the header and tap on the Go to admins room option. Make sure three dots button looks and works as expected.

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/Expensify/App/assets/23176449/68a634cf-f778-4d55-a485-e56ed147bec6

Android: mWeb Chrome

https://github.com/Expensify/App/assets/23176449/2441e7bb-e183-4780-b8e9-d95aa76a728c

iOS: Native

https://github.com/Expensify/App/assets/23176449/ceb9cdf9-a478-4cf9-97bd-234753c862b6

iOS: mWeb Safari

https://github.com/Expensify/App/assets/23176449/c2f42119-3f54-43bc-a1df-12c3eb3d8868

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/23176449/eb0c77a7-a3fa-45ca-ae9c-b83e99e8eddc

MacOS: Desktop

https://github.com/Expensify/App/assets/23176449/e5bfd9a7-f1c8-49c8-a48d-cb4f264d6382

Note: android recording will be added as soon as the issue on the main branch will be resolved

@akinwale kind bump 🙂

@VickyStash I think every prop is optional here. So can you fix that?

@shubham1206agra Sure, taking a look

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native
https://github.com/Expensify/App/assets/58412969/ba45c0aa-24aa-4b76-b322-8fc5c74ca79e

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

🚀 Deployed to staging by https://github.com/mountiny in version: 1.4.20-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
cancelled 🔪

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/marcaaron in version: 1.4.20-3 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Avoid reparsing a response body

The oauth2 v2 release removed the rescue catch-all when parsing failed. This exposed a possible issue where someone overriding or extending the Faraday connection middleware stack may parse response bodies ahead of the packaged middleware in this library. In that case, this library attempts to re-parse an already-parsed body, thereby throwing various exceptions (TypeError: no implicit conversion of Hash into String, for example).
Faraday doesn't provide a standard interface to determine whether or not a response has already been parsed. Instead, it relies on middleware developers performing cursory checks of the object type (generally, if the body responds to to_str then it's probably a string, and it's probably not yet parsed).
This change adds that cursory check to make sure the response body is still string-like before attempting to parse it into Ruby objects.

Codecov Report

Merging #608 (7ddf293) into master (af4169e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #608   +/-   ##
=======================================
  Coverage   99.48%   99.49%
=======================================
  Files          13       13
  Lines         391      393    +2
=======================================
+ Hits          389      391    +2
  Misses          2        2

Impacted Files
Coverage Δ

lib/oauth2/response.rb
100.00% <100.00%> (ø)

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more


Reset all dims to be rollable

References and relevant issues
Closes #6792
Description
This is a follow-up to #5986 that resets all dimensions to rollable when all layers are removed.
Given that this not necessarily a bug and more of a preferred behavior, I did not add a test to cover it to avoid future maintenance of that test.

@psobolewskiPhD : I added you as a reviewer because you made the request here. No rush and feel to pass it to someone else.

As always, thanks for thinking this through @psobolewskiPhD !
Based on the current behavior of napari, I agree with those thoughts. I think some of those behaviors around dims could be improved in the future, but until then this seems good enough to me.
@Chris-N-K : I also added you as a reviewer in case you don't agree with the logic above.

@andy-sweet with pleasure.
I think a consistent behavior would be best. So either the state should be kept for all axes or for none.
Which way is best depends on the use case and is to discuss.
I personally would like it if the rollable state of axes would persist, maybe even after closing the viewer.
In this case one could add a reset button to reset all axes at once.
Currently the for none is probably a lot easier to implement.

I think preserve lock state for all dims is a reasonable feature request Issue, could add a checkbox to the widget or something.

I personally would like it if the rollable state of axes would persist, maybe even after closing the viewer.
In this case one could add a reset button to reset all axes at once.

Closing the viewer has lots of side effects (that maybe it shouldn't), but I think you're also implying that the state would also persist after removing all the layers. E.g. this would be desirable
viewer = napari.Viewer()
viewer.add_layer(...)
viewer.add_layer(...)
viewer.dims.axis_labels = ("t", "z", "y", "x")
viewer.dims.rollable = (False, True, True, True)
viewer.dims.roll()
viewer.layers.clear()
viewer.dims.axis_labels  # => ("t", "z", "y", "x")
viewer.dims.rollable  # => (False, True, True, True)

but after this PR we get
...
viewer.layers.clear()
viewer.dims.axis_labels  # => ("y", "x")
viewer.dims.rollable  # => (True, True)

Unfortunately, I think Dims currently has a fundamental limitation there because it only keeps track of the maximum number of dimensions across all layers until there are no layers when it hits the reset behavior used here.

I think a consistent behavior would be best. So either the state should be kept for all axes or for none.

I agree that I like consistency. My strong intuition is that this PR is the way to go for now because I'm concerned that patching more complex behavior on Dims (which is central component in napari) for which it wasn't initially designed is probably going to cause a maintenance headache and surprise bugs.
Interestingly, the only attribute that survives the reset is Dims.axis_labels, though again it gets cut to the last two labels to match Dims.ndim so it's inconsistent and doesn't seem particularly useful.
Long term thoughts
I do think this discussion is useful for setting up longer term work and redesign in napari. I've long wanted to redesign Dims to better set us up for multi-canvas views/slices of different layers. See NAP-9 for some related discussion.
For example, I can imagine a canvas presenting a view over a number of layers. State like rollable and axis_labels would be state associated with that view and could persist independently on layers. The layers would also have their own axis names, so generating views would be a matter of corresponding the axis names. Dims would not be directly coupled to layers, only when generating views/slices.
For example, if we just had one canvas, the above example might look something like the following
viewer = napari.Viewer()
viewer.add_layer(...)
viewer.add_layer(...)
viewer.dims = ("t", "z", "y", "x")
viewer.dims.t.rollable = False
viewer.dims.roll()
viewer.layers.clear()
viewer.dims  # => ("t", "z", "y", "x")
viewer.dims.t.rollable  # => False

I have no idea when this work might get done, but I'm still holding out some hope :)

I think for now resetting everything after complete layer removal is the best approach.
My other suggestion was more of a desired longterm goal.


cpals_core() c++ file missing?

`if (isa(X,'sptensor') || isa(X,'tensor')) && (exist('cpals_core','file') == 3)
%fprintf('Using C++ code\n');
[lambda,U] = cpals_core(X, Uinit, fitchangetol, maxiters, dimorder);
P = ktensor(lambda,U);

else
...
end`
It seems that cpals_core(...) is a c++ implementation of cp als , but I cannot find the cpp file anywhere.
Is it missing or it does not exist at all?

Hi @liujiang96 thank you for your opened issue and sorry for my delayed response. I will check this bug and I will let you updated. Best regards.

Hi @liujiang96 it seems that cpals_core function is not provided in the Tensor Toolbox:
http://www.sandia.gov/~tgkolda/TensorToolbox/
You can contact Tamara Kolda<EMAIL_ADDRESS>about this.
Best regards,
Andrews

There is a Python implementation of CP ALS here:
https://github.com/mnick/scikit-tensor/blob/master/sktensor/cp.py


How to structure botkit project?

Really like the project! <3
I would like to help with how to organize a botkit project. With express.js you can start a express.Router() that you can later mount as a middleware.
There is middlewares in botkit, but not an easy way to take out functions and put them into other files.

Breaking out features more is a long term goal of Botkit, we hope to have some documentation around this, and more information about creating middleware soon.

I am not talking about breaking out features, but making it possible to structure your project. I began to do it with our bot here
https://github.com/connectedcars/bender/blob/master/server.js#L21-L23
Because then I can also test it like this here
https://github.com/connectedcars/bender/blob/master/test.js

We have a project underway to do this! Take a look here:
https://github.com/howdyai/botkit-starter-slack

Seems cool! However I don't like the wrapping everything in module.exports = function(){}, it seems like a unconventional way of doing it.


Changing Scroll behavior of the page

I raise this PR for the smooth the React.js app in-page navigation, when we navigating through the side in-page navigation that time scroll behavior is auto so I smooth that scroll behavior. ( This is my first PR in React ).

Now Scroll behavior of the react.dev official site is smooth.


fix 4D ellipses

Description
This PR fixes the bug reported in https://forum.image.sc/t/adding-shapes-to-4d-data-in-napari/33600 on adding 4D ellipses and adds a test that would have previously failed. The problem was due to an incorrect initialization line.
Type of change

[x] Bug-fix (non-breaking change which fixes an issue)

Thanks for the review @kevinyamauchi I will merge this now. Those shape / size issues can be addressed in dedicated PRs


[Feature Request] Add Introductions in Different Programming Languages

🚀 Feature Request
Is your feature request related to a problem? Please describe.
I'm frustrated when I can't find algorithm implementations in my preferred programming language (Python) within the platform. This limits my ability to work efficiently or adapt algorithms to Python-based projects.
Describe the solution you'd like
I would like to see algorithms available in multiple programming languages, specifically adding support for Python. This would make it easier to learn, compare, and implement algorithms directly in Python.
Describe alternatives you've considered
An alternative solution could be providing a space where users can contribute their own implementations of algorithms in different languages, including Python, or integrating a converter tool for existing implementations.
Additional context
Adding Python support will cater to a large user base and enhance productivity for users working with Python. Including Python would make it more versatile and educationally valuable.
Would you like to work on this feature?
Yes

Hey @ajay-dhangar I can work on this.


rf: create azure container if flightCheckOnStartUp

Add flight check during start-up option to client check. If a flight check, behavior is:

return an error to halt start-up if there is any error in the client check

check all external backend locations (instead of just one random location per external backend)

create a container for an Azure location if one is missing

PR has been updated. Reviewers, please be cautious.

@ironman-machine try

Hello @electrachong
"try": Success: Try build successfully launched on 'http://ci.ironmann.io/gh/scality/Integration/16901' with the following env. args:
{
    "SCALITY_INTEGRATION_BRANCH": "ultron/master",
    "REPO_NAME": "S3",
    "DEFAULT_BRANCH": "master",
    "SCALITY_S3_BRANCH": "rf/flightcheck"
}

@ironman-machine try

Hello @electrachong
"try": Success: Try build successfully launched on 'http://ci.ironmann.io/gh/scality/Integration/16902' with the following env. args:
{
    "SCALITY_INTEGRATION_BRANCH": "ultron/master",
    "REPO_NAME": "S3",
    "DEFAULT_BRANCH": "master",
    "SCALITY_S3_BRANCH": "rf/flightcheck"
}

@ironman-machine try

Hello @electrachong
"try": Success: Try build successfully launched on 'http://ci.ironmann.io/gh/scality/Integration/16935' with the following env. args:
{
    "SCALITY_INTEGRATION_BRANCH": "ultron/master",
    "REPO_NAME": "S3",
    "DEFAULT_BRANCH": "master",
    "SCALITY_S3_BRANCH": "rf/flightcheck"
}

:broken_heart: :umbrella: circleCI test failed.

@ironman-machine try

Hello @electrachong
"try": Success: Try build successfully launched on 'http://ci.ironmann.io/gh/scality/Integration/16944' with the following env. args:
{
    "SCALITY_INTEGRATION_BRANCH": "ultron/master",
    "REPO_NAME": "S3",
    "DEFAULT_BRANCH": "master",
    "SCALITY_S3_BRANCH": "rf/flightcheck"
}

:sunny: :+1: circleCI test succeeded!

How come we're not creating an AWS bucket if it doesn't exist in the flight check?

@dora-korpar The reasoning is we don't want a normal health check to have side effects (e.g. when nginx is querying the server every 2 minutes). We think of the flight check on start up as different than a normal healthcheck, since we are checking to make sure everything specified for clients/locations is operational and will stop the server if it is not.

@ironman-machine r+

Hello @electrachong
"r+": Success

This pull request isn't mergeable:
CONFLICT (add/add): Merge conflict in tests/functional/aws-node-sdk/test/multipleBackend/utils.js
CONFLICT (add/add): Merge conflict in tests/functional/aws-node-sdk/test/multipleBackend/put/putAzure.js
CONFLICT (add/add): Merge conflict in tests/functional/aws-node-sdk/test/multipleBackend/objectTagging/objectTagging.js
CONFLICT (add/add): Merge conflict in tests/functional/aws-node-sdk/test/multipleBackend/objectCopy/azureObjectCopy.js
CONFLICT (add/add): Merge conflict in tests/functional/aws-node-sdk/test/multipleBackend/mpuParts/azurePutPart.js
CONFLICT (add/add): Merge conflict in tests/functional/aws-node-sdk/test/multipleBackend/mpuComplete/azureCompleteMPU.js
CONFLICT (add/add): Merge conflict in tests/functional/aws-node-sdk/test/multipleBackend/mpuAbort/azureAbortMPU.js
CONFLICT (add/add): Merge conflict in tests/functional/aws-node-sdk/test/multipleBackend/listParts/azureListParts.js
CONFLICT (add/add): Merge conflict in tests/functional/aws-node-sdk/test/multipleBackend/initMPU/initMPUAzure.js
CONFLICT (add/add): Merge conflict in tests/functional/aws-node-sdk/test/multipleBackend/get/getAzure.js
CONFLICT (add/add): Merge conflict in tests/functional/aws-node-sdk/test/multipleBackend/delete/deleteAzure.js


Inline the event plugin system into the compiler

For example, the KeyEventsPlugin doesn't need to be at runtime.
(Placeholder for now)

This is likely something we'd do as part of the new compiler pipeline.

We've refactored the events manager quite a bit where it might not be worth the effort right now.


merge dev into master

conflict

conflict

I don't know why this file keeps conflicting, I'll close this pr first.
Conflicting files
lib/src/widgets/keyboard_listener.dart

I don't know why this file keeps conflicting, I'll close this pr first.
Conflicting files
lib/src/widgets/keyboard_listener.dart

@singerdmx resolved!

Change 96 files ?!

Please stop this

Just cherry pick the SINGLE change you want!!!

Just cherry pick the SINGLE change you want!!!

Ok, I just merged master to dev, and then auto generated so many changes when merged back from dev


Release binaries

The project looks quite interesting!
Curious if you are planning to provide compiled binaries across OSes e.g. Mac Intel/Silicon, Linux etc. thus the hassle of source code compilation can be avoided?

@sujitawake Thanks for the good suggestion! I'll look into adding that as an automated release process after handling some of the more pressing issues in our backlog.


No success message and URL returned with LNURLp links

As the title says, the neither the URL, nor the message are returned to the wallet making the payment. This used to work when I was still on the latest raspiblitz tag. Now on this commit, it has stopped working, even on newly created LNURLp links.
Edit: Reproducible on lnbits.com

To reproduce: Go to lnbits.com, activate the LNURLp extension, and create a link with a success message and URL. Pay to this link with any wallet that supports it. No success message or URL will be reported back to the wallet.


the switch to postgres10 doesn't handle DB upgrades

The latest change to switch from postgres 9.4 to 10 doesn't upgrade the database and containers won't succeed because of the version incompatibility with the database files.  (new installs likely work)

there is everything about it inside the readme file, including an upgrade script. It seems it is currently not possible to upgrade the database automatically

The script in the readme actually upgrades the existing database. I migrated our instance yesterday and used a rather "simple" approach to upgrade from the same thread.
https://github.com/mattermost/mattermost-docker/issues/489#issuecomment-845363495
The summary is:

backup current db
update dockerfiles (app + db)
clear database
import backup

Thats it.
In addition to @btxtiger 's comment i think we should accept that it is a breaking change and just add a dedicated "official" upgrade documentation.


About clean the data

First of all thank you for your great work.
I want to reproduce NeRF_W in my own data set. I know I have to process the data up front. I see your description:
Download the scenes you want from here (train/test splits are only provided for "Brandenburg Gate",  "Sacre Coeur" and "Trevi Fountain", if you want to train on other scenes,  you need to clean the data (Section C) and split the data by yourself)" in Phototourism dataset. I think that's the data processing part. But I don't know where this Section C is. Can you help me?

hey do you know where is "Section C"? I have the same questions.

I have the same questions.


auth.ehealth/sign-in/: add "verifying otp" page

auth.ehealth/sign-in/: add "verifying otp" page:
Summary:

new page with:
- input field "otp" + button "send"
- button "resend otp"
logic:
- after input OTP  - call "POST Tokens" read response "urgent.next" and switching logic:
-  EQUEST_APPS - go to next page "Approvals"
- error - view message
- after click button "resend OTP" - call "POST Tokens"
[x]  Create spec for FE task
[x]  Create design layout
[x]  Implement
[x]  Deploy
[x]  Test

done


Allow customizing tx longevity

Currently in pallet-ethereum transaction longevity is not explicitly set in ValidTransactionBuilder, and defaults to the TransactionLongevity's u64::max_value().
This PR introduces a way of customizing that, and adds a template example for bounding the future queue transactions to a 3 hour lifetime.

I agree that this seems like something we should be able to customize at client level. Geth offers the possibility of configuring via cli argument the lifetime of a non-executable transaction in-queue. The goal is to prevent users to send unlimited amount of future txns that would otherwise stay in the pool forever:
https://github.com/ethereum/go-ethereum/blob/ae8ce7202244621d6e80eb69fcc31683fa0d4cea/cmd/utils/flags.go#L435-L439
Currently in substrate and afaik there is no way of setting a different a lifetime for how long transactions can be stored in the future queue VS the ready queue in the client. Also in substrate transactions are moved from / to queues depending on the re-validation so it's theoretically useless to try to categorize a transaction as future (or ready) between blocks..
So at the end what I'm proposing is just having a way of pruning transactions that would potentially stay forever as future. This of course have some downsides, like: what happens when the transaction is moved from the future to the ready queue. That transaction is now "executable" (all his required tags have been fullfilled) but its lifetime is the one we set originally as mortal - in other words, is ready and mortal, whereas normally ready transactions are inmortal..
Please let me know if you see a better alternative.

Closing this because is not needed.
Transaction pool already enforce_limits based on the configured Limit for each queue. If a transaction is succesfully submitted, and the configured limit is reached, the oldest transaction in that queue will be removed.
This means that, even if we cannot configure for how long transactions are in each queue, it doesn't matter. We only care about old transactions if they are blocking new transactions to be submitted, and that's what enforce_limits does.


WIP Cleanup 2019 work

Add documentation, unit tests, bug fixes, and general backlogged items

Something is wrong here. Not indented properly, possibly an uwecho bug


gcovr new version broke build.

This patch:
https://github.com/aminya/setup-cpp/commit/0188a5abb2cd101f815c18b680ff41fa10536fe9
increase gcovr version from 5.0 toward 5.1
Version 5.1 contained a bug. See:
https://github.com/gcovr/gcovr/issues/620#issuecomment-1128440130
It caused errors on my workflow:
https://github.com/ArthurSonzogni/FTXUI/pull/405/checks
What about reverting version toward the last known working one?

Oh. It had a bug on gcovr 5.0 too. The Jinja library was not installed properly. Not sure what to do.
You can pass "5.0" instead of "true" in the meantime.

Thanks!
I didn't know I can specify the version myself. Great! This fixes my issue.


[doc] Update reference to snip articles

This PR updates the reference to snip articles to add the title and a DOI link

Looks professional to me


Use Balancer when choosing node for remote shard mapping

The existing Balancer code needs to be hooked up the Shard Mapper, so it intelligently chooses the target node.

@otoolep what's the status of this issue?

Not yet implemented, though the core code exists and just needs to be ported to the distributed query code.
Currently when two remote nodes can service a query (assuming the local node cannot), the remote node is chosen at random, even if that randomly chosen node is down. This change will fix that and try the other node in that case. This is obviously a core part of HA queries.
No reason this can't be fixed in 0.9.4.

To be more specific, I think it would be ideal for the mapper to be intelligent enough to only pick nodes that have the latest timestamp for the data.  Meaning, if a node were to fail and come back, it should still not be chosen until hinted handoff catches it back up to the other nodes, this way data returned is always the latest most consistent data with the rest of the cluster.

DQ support is not fully implemented yet, so this can be pushed out.

Closing this out because it's no longer applicable.


[MNT] Rebased and add version 0.13.0

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

Things I have done in this PR:
Set build version to 0.13.0
Set SHA to SHA256 found on sktime's release page

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-admin, please rerender

Thanks @TNTran92, could you please add dependencies to run section in sktime-all-extras that have conda packages? I think the list should at least contain all deps from the run + run_constrained of sktime section.

Thanks @TNTran92, could you please add dependencies to run section in sktime-all-extras that have conda packages? I think the list should at least contain all deps from the run + run_constrained of sktime section.

I'm a little confused. If we're going to add them to 'all-extra', then why do we have them in the 'normal' sktime as well?

The difference between run and run_constrained is that run contains required dependencies while run_constrained contains optional. So in the case of sktime package we separate run and run_constrained based on pyproject.toml specifically we map dependencies section into run and all_extras into run_constrained.
For the sktime-all-extras we put dependencies + all_extras into the run section and nothing into run_constrained to provide a package with the largest number of bundled dependencies.
Let me know if any of this is still unclear.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-admin, please rerender

I'd be inclined to turn build_with_mambabuild back on. IME it does better solving environments and gives better messages when it fails.

I'd be inclined to turn build_with_mambabuild back on. IME it does better solving environments and gives better messages when it fails.

My experience is that they are both poor when it comes to error messages.


Request: show only image or video tweets option to UI

Request: show only image or video tweets option to UI

These would be better implemented in a dedicated Twitter media browsing extension


Is NLog prone to errors like Log4j recently?

While discussed on Stack Exchange that Log4net is probably not prone to errors like Log4j recently is (see CVE-2021-44228), I asked myself whether NLog might suffer from similar issues.
I do understand that NLog is not a port of Log4j.
Still, depending on the type of application, NLog might accept user input and put it into a log file, possibly un-sanitized.
My questions:

Is there a chance that NLog might be vulnerable to similar attacks as discussed in CVE-2021-44228?
If yes, is there any mitigation I might do immediately to lower the risk of making my NLog enabled public web applications vulnerable?

NLog and log4net both has support for message-substituion . In NLog this is done by NLog Layout and NLog LayoutRenderer  (Ex. ${logger} ${threadid} ${message}).

The NLog-logging-engine will never attempt to parse NLog Layout from NLog LogEventInfo-input.

And if the host-application should explicitly attempt to create NLog Layout from user-input (very strange scenario), then NLog Layout would only have access to limited methods (marked with NLog.Conditions.ConditionMethodAttribute).

So I cannot see that NLog should be vulnerable to this problem.

I'm also busy with log4j analyses (for work).
NLog is indeed not vulnerable.


xenorchestra_pif data source improvement

You implemented figuring out of UUID by device name, but... if we have a lot of pifs with device "eth1" but with different VLAN, I suppose that it will work incorrectly. It needs to be specified in another way. Maybe in addition to device, VLAN should be specified.

Can you show me a pif-list on your Xen server or what the objects look like in the XO api?

Sure:
[root@idmbs-hv002 ~]# xe pif-list
uuid ( RO)                  : e34c0912-92f0-59c7-b2d7-a568ed54e823
                device ( RO): eth1
    currently-attached ( RO): true
                  VLAN ( RO): -1
          network-uuid ( RO): a75d0c30-37f0-0fd1-951b-33a9d7b08bae

uuid ( RO)                  : f14bd3e5-5953-6ceb-7288-82d5bf90166d
                device ( RO): idrac
    currently-attached ( RO): false
                  VLAN ( RO): -1
          network-uuid ( RO): e7ef5216-c6f1-25b5-cd40-dc3b344d86d0

uuid ( RO)                  : 82f5ae10-ce91-69ea-0630-ed3ccf2d621b
                device ( RO): eth3
    currently-attached ( RO): false
                  VLAN ( RO): -1
          network-uuid ( RO): e7148e30-2138-9418-071f-8e59588b6f6a

uuid ( RO)                  : 303becfb-49be-ac26-1fee-f8feaf5939e9
                device ( RO): eth0
    currently-attached ( RO): true
                  VLAN ( RO): -1
          network-uuid ( RO): d4c6070d-e4a0-6440-cba7-accaf5bc3d54

uuid ( RO)                  : 858b1499-bf12-80a7-70f1-6c5b198e826f
                device ( RO): bond0
    currently-attached ( RO): true
                  VLAN ( RO): 1244
          network-uuid ( RO): 6301ada5-8df7-6597-6477-28c085648709

uuid ( RO)                  : c68fa80a-313c-c205-8a2f-712f2ed45e53
                device ( RO): bond0
    currently-attached ( RO): true
                  VLAN ( RO): 1245
          network-uuid ( RO): 44eb5c1e-158e-3b23-61fd-00598eab3450

uuid ( RO)                  : b17c9caa-2b35-320a-c644-5ae1ac449b80
                device ( RO): eth0
    currently-attached ( RO): true
                  VLAN ( RO): 1430
          network-uuid ( RO): 6c251f3e-a706-320f-f022-ad66507fe83e

uuid ( RO)                  : 0c3388d6-9a89-8157-4c2b-5c93f769a67b
                device ( RO): bond0
    currently-attached ( RO): true
                  VLAN ( RO): 1231
          network-uuid ( RO): f017f304-b8cb-9d36-ef17-fae0c7c24492

uuid ( RO)                  : 50cb05d4-fc97-b426-cffb-63085fc69cf5
                device ( RO): eth2
    currently-attached ( RO): false
                  VLAN ( RO): -1
          network-uuid ( RO): f519f055-5ff0-ecb1-2a0e-73d19f35915c

uuid ( RO)                  : 38535ebc-775b-ed31-e3d1-37152e390b80
                device ( RO): bond0
    currently-attached ( RO): true
                  VLAN ( RO): 1236
          network-uuid ( RO): e7c34b9d-9fee-098f-dbc1-dcf36a1555a7

uuid ( RO)                  : 730e63f5-2fc4-796d-4365-ed166e40a329
                device ( RO): bond0
    currently-attached ( RO): true
                  VLAN ( RO): -1
          network-uuid ( RO): 2f386d3c-cb03-73f1-fea6-0833c13c87d4

uuid ( RO)                  : 8c12bf46-6c4c-43e8-dd3f-b9cdacdd69f9
                device ( RO): bond0
    currently-attached ( RO): true
                  VLAN ( RO): 1248
          network-uuid ( RO): d7119536-4d27-69e6-5bcb-b9d8495775ee

@m0ps I believe #17 should fix your issues (vlan is now required for the pif data source). Please reopen this issue if that is not the case.


add userdata param to callback function

Add UserData to the callback function to satisfy concurrent calls in a multi-threaded environment.

The output from the MacOS CI run.
[ RUN      ] CallbackPatchTests.CallbackPatchLambdaTextTest
  10: /Users/runner/work/cpr/cpr/test/callback_tests.cpp:658: Failure
  10: Expected equality of these values:
  10:   future.wait_for(zero)
  10:     Which is: 4-byte object <01-00 00-00>
  10:   std::future_status::ready
  10:     Which is: 4-byte object <00-00 00-00>

@COM8 What do I need to do to solve the problem?

documentation
callback.h conflicts

The definition of ProgressCallback changed in https://github.com/whoshuu/cpr/commit/cfb2a3e42e10e5a1a6e16de22504740b6ab1c6ad. Please try to rebase your changes.
https://medium.com/@topspinj/how-to-git-rebase-into-a-forked-repo-c9f05e821c8a
To update the docs, please checkout the gh-pages banche, perform your changes and create an additional PR.

Now I have changed userdata to the last, and merged the "whoshuu/master" with  cfb2a3e.

I reintroduced a PR https://github.com/whoshuu/cpr/pull/601


WIP: close select menu on select

This is a rough WIP to check this is the right approach, or if there is a better way.
In response to #456 this change adds a prop to SelectMenu to enable closing the select menu when an option is selected.

Thanks @solon-aguiar @mshwery!
I've updated my PR & commit message, and added a note to the docs also.
I've left the formatting change for now, as it is complying with the prettier settings, lmk if you want me to change it. 👍

No worries, welcome :fireworks:


API cleanup

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@5c1dd3e). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main       #3   +/-   ##
=======================================
  Coverage        ?   68.15%
=======================================
  Files           ?        7
  Lines           ?      157
  Branches        ?        0
=======================================
  Hits            ?      107
  Misses          ?       50
  Partials        ?        0

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


0.8.2-RC2 doesn't start with a blank Zookeeper

Apparently, Marathon is trying to migrate from other versions even when doesn't exist another version, causing a NullPointerException.
[2015-05-12 20:32:03,854] INFO Starting Marathon 0.8.2-RC2 (mesosphere.marathon.Main$:87)
[2015-05-12 20:32:05,357] INFO Connecting to Zookeeper... (mesosphere.marathon.Main$:37)
[2015-05-12 20:32:05,366] INFO Client environment:zookeeper.version=3.3.3-1203054, built on 11/17/2011 05:47 GMT (org.apache.zookeeper.ZooKeeper:97)

[2015-05-12 20:32:07,160] INFO Candidate /marathon/leader/member_0000000000 is now leader of group: [member_0000000000] (com.twitter.common.zookeeper.CandidateImpl:152)
[2015-05-12 20:32:07,161] INFO Elected (Leader Interface) (mesosphere.marathon.MarathonSchedulerService:252)
[2015-05-12 20:32:07,247] INFO Migration for storage: Version(0, 0, 0) to current: Version(0, 8, 2): apply change for version: Version(0, 5, 0)  (mesosphere.marathon.state.Migration:53)
[2015-05-12 20:32:07,252] INFO Migration for storage: Version(0, 0, 0) to current: Version(0, 8, 2): apply change for version: Version(0, 7, 0)  (mesosphere.marathon.state.Migration:53)
[2015-05-12 20:32:07,258] ERROR Failed to take over leadership: java.lang.NullPointerException (mesosphere.marathon.MarathonSchedulerService:268)
[2015-05-12 20:32:07,258] ERROR Migration failed! java.lang.NullPointerException (mesosphere.marathon.state.Migration:70)
[2015-05-12 20:32:07,258] INFO Increasing offerLeadership backoff to 1000 milliseconds (mesosphere.marathon.MarathonSchedulerService:324)
[2015-05-12 20:32:07,258] INFO Abdicating (mesosphere.marathon.MarathonSchedulerService:312)
[2015-05-12 20:32:07,258] INFO Defeat leadership (mesosphere.marathon.MarathonSchedulerService:285)
[2015-05-12 20:32:07,260] INFO Stopping driver (mesosphere.marathon.MarathonSchedulerService:224)
[2015-05-12 20:32:07,273] INFO Defeated (Leader Interface) (mesosphere.marathon.MarathonSchedulerService:245)
[2015-05-12 20:32:07,273] INFO Will offer leadership after 1000 milliseconds backoff (mesosphere.marathon.MarathonSchedulerService:334)
[2015-05-12 20:32:07,273] INFO Defeat leadership (mesosphere.marathon.MarathonSchedulerService:285)
[2015-05-12 20:32:07,273] INFO Stopping driver (mesosphere.marathon.MarathonSchedulerService:224)
[2015-05-12 20:32:07,274] WARN All candidates have temporarily left the group: Group /marathon/leader (com.twitter.common.zookeeper.CandidateImpl:142)

I started a 0.8.1 instance and then the 0.8.2-RC2, it works well.

I'm sorry, I didn't see the #1507 . Closing.

Anyway, thanks for reporting this! We really appreciate the release candidate testing. We'll release a fixed candidate probably today.


directory.copy is 2x slower in windows

Godot version
3.3.2 stable
System information
windows 10, ubuntu 16.04
Issue description
directory.copy is very slow in windows, much slower than native windows copy, and 2x slower than directory.copy in linux

Steps to reproduce
extends Node2D

func _ready():
  var dir = Directory.new()
  var t1 = OS.get_system_time_msecs()
  dir.copy("res://dummy.file", "res://dummy.file.copy")
  printt("Time", OS.get_system_time_msecs() - t1)

Minimal reproduction project
CopySlowIssue.zip
Pls notice there is a 100MB dummy.file inside

directory.copy is very slow in windows, much slower than native windows copy, and 2x slower than directory.copy in linux

Could you provide how long it approximately takes with your test on each OS?
And the model of your disk may help.

Is filesystem access even comparable between Linux and Windows? I know file access is definitely slower on Windows in general (matters when dealing with lots of files), or has it become worse since a previous version?

Yeah Linux being twice as fast as Windows for I/O doesn't strike me as a bug, slow I/O is a well-known Windows issue which is not specific to Godot.
More interesting is the claim that Godot copy on Windows would be much slower than the native copy in explorer.exe, in which case there might be room for improvements indeed.

Microsoft generally advises using its proprietary RoboCopy for fast file copies, but this is most likely not something we can do (even using OS.execute()).

Microsoft generally advises using its proprietary RoboCopy for fast file copies, but this is most likely not something we can do (even using OS.execute()).

This reminds me that I can use OS.execute("copy", .... in windows and OS.execute("cp", ... in *nix. I've tested the performance, it's very fast.
Thanks.