Fix function signatures in migration tasks

Small PR to fix function signatures in python 3.10 (only one tested), as they clash with argument type definitions needed by importlib, as discussed in https://github.com/inventree/InvenTree/discussions/6641
Traceback (most recent call last):
  File "/usr/local/bin/inv", line 8, in <module>
    sys.exit(program.run())
  File "/usr/lib/python3/dist-packages/invoke/program.py", line 373, in run
    self.parse_collection()
  File "/usr/lib/python3/dist-packages/invoke/program.py", line 465, in parse_collection
    self.load_collection()
  File "/usr/lib/python3/dist-packages/invoke/program.py", line 696, in load_collection
    module, parent = loader.load(coll_name)
  File "/usr/lib/python3/dist-packages/invoke/loader.py", line 76, in load
    module = imp.load_module(name, fd, path, desc)
  File "/usr/lib/python3.10/imp.py", line 235, in load_module
    return load_source(name, filename, file)
  File "/usr/lib/python3.10/imp.py", line 172, in load_source
    module = _load(spec)
  File "<frozen importlib._bootstrap>", line 719, in _load
  File "<frozen importlib._bootstrap>", line 688, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 883, in exec_module
  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
  File "/home/InvenTree/tasks.py", line 398, in <module>
    def update(
  File "/usr/lib/python3/dist-packages/invoke/tasks.py", line 338, in inner
    obj = klass(
  File "/usr/lib/python3/dist-packages/invoke/tasks.py", line 76, in __init__
    self.positional = self.fill_implicit_positionals(positional)
  File "/usr/lib/python3/dist-packages/invoke/tasks.py", line 167, in fill_implicit_positionals
    args, spec_dict = self.argspec(self.body)
  File "/usr/lib/python3/dist-packages/invoke/tasks.py", line 153, in argspec
    spec = inspect.getargspec(func)
  File "/usr/lib/python3.10/inspect.py", line 1237, in getargspec
    raise ValueError("Function has keyword-only parameters or annotations"
ValueError: Function has keyword-only parameters or annotations, use inspect.signature() API which can support them

@oscgonfer can you expand on what you mean by "clashing" here - is it throwing a particular error?

@SchrodingersGat I edit my comment above

If I remember, wasn't that an issue with old invoke versions? Could you try updating invoke?

@oscgonfer the comment by @wolflu05 is correct - what version of invoke are you using?
invoke --version

https://docs.inventree.org/en/stable/faq/?h=invoke#invoke-version

➜  InvenTree git:(master) ✗ invoke --version
Invoke 1.3.0

Ok, you need to update your invoke version then!


Add BUILDING.md for Build Instructions

yea

curl(.exe) exists in powershell not in cmd

i used curl in cmd, whats your excuse

curl(.exe) exists in powershell not in cmd

i used curl in cmd, whats your excuse

curl isn't installed in windows 10 at default in version 1803 or earlier. That means u have newer windows bleh

curl(.exe) exists in powershell not in cmd

i used curl in cmd, whats your excuse

curl isn't installed in windows 10 at default in version 1803 or earlier. That means u have newer windows bleh

22H2

curl(.exe) exists in powershell not in cmd

i used curl in cmd, whats your excuse

curl isn't installed in windows 10 at default in version 1803 or earlier. That means u have newer windows bleh

git installs it for you, that's why I made the step for windows be done specifically after installing git


Infer static member references

In the following code:
export default class SettingsParser {
	private static _settings: Settings;

	/** Parse commandline, check settings, and init logging to appropriate loglevel */
	public static parse(settings: Settings) {
		_settings = settings;
	}
}

The _settings reference is flagged as an error with the message "[ts] Cannot find name '_settings'. Did you mean the static member 'SettingsParser._settings'?"  Yes, I did.  C# just infers this.  Why can't TypeScript?  Having to write SettingsParser. each time is very verbose.

TypeScript just type-checks JavaScript code -- it doesn't alter it. Since your example won't work when run as JavaScript, TypeScript will issue an error.

It alters it a bunch, like making import statements into require statements if necessary.  Why not add the class name when it is useful?  It doesn't work run as JS but that's not a design goal of TS - the design goal is "valid JavaScript is valid TypeScript", not the other way around.

See https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals

It alters it a bunch, like making import statements into require statements if necessary.

That is transforming one form of valid TypeScript to another form.  Transpiling.

That's somewhat splitting hairs.  It's changing variable names.  Fundamentally it is changing the input code.  Why does it matter if it isn't valid JavaScript going in?

@DanielRosenwasser So if it's a "bad idea" to emit this different code, what would one suggest as a good alternative?  Do we really have to write out the whole class name every time?

You could just use a let in the scope of the class.
let settings: Settings;
export default class SettingsParser {
	public static parse(settings: Settings) {
		_settings = settings;
	}
}

@andy-ms You mean let _settings: Settings;?  Is that logically the same as a static member, though?

It's not the same as a static member since it's not a property on the class -- it can only be accessed in its scope. But since you wanted the property to be private anyway, that's probably what you want.

If you need that, there's
let _settings = {};
export default class SettingsParser {
    get settings() {
        return _settings;
    }
}

Automatically closing this issue for housekeeping purposes. The issue labels indicate that it is unactionable at the moment or has already been addressed.


Add minimal plotly version

We use  fig.add_hline in helpers_compat.py ; it was added in plotly 4.12 so I made it a requirement. @qb3 had an issue otherwise.
See https://stackoverflow.com/questions/68296479/why-am-i-getting-plotly-express-attribute-error-attributeerror-figure-objec

Codecov Report

Merging #212 (a3fafd9) into master (090bf97) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #212   +/-   ##
=======================================
  Coverage   63.45%   63.45%
=======================================
  Files          41       41
  Lines        2063     2063
  Branches      345      345
=======================================
  Hits         1309     1309
  Misses        657      657
  Partials       97       97


Figure out how to make edit work with search results

Search for something
Hit edit (next to X)
Note values. These probably don't match so we are editing the wrong entry here.

This might be something with the demo but it's still worth investigating before a release.

Note that also delete appears to be broken in this case.

This is also a problem with pagination (ie. hit some page + edit). I guess there's something going on with indexing (starts from zero per page, not from real index).

I understand what's going on here now. Our dataflow goes like this in the full example:

Original data
Data filtered by search. Currently this filtering happens only when search query changes. By default search data points at the original data in our demo.
Paginated search data. Table will consume this.

The problem here is that edit/delete loses track of original data ids. In case of Flux it's not a problem as each data entry will contain some id. You'll just trigger a query based on that. The store updates and table updates as a result.
I think I'll tweak the demo to contain id fields. Then edit/remove can be implemented reliably. Relying on table ids isn't a good idea.


Update mde-integration.md

Updating integration with MDE for Discovery based on another step needed within the settings 'https://security.microsoft.com/securitysettings'

@Tzoref12 : Thanks for your contribution! The author(s) have been notified to review your proposed change.


PHOENIX-6823 calling Joda-based round() function on temporal PK field…

… causes division by zero error
also fix other bugs in the key range pushdown logic for temporals

The logic is still buggy, please don't review yet

This should be ready now.


Observable#startWith should be two separate methods

Once again, startWith suffers from the same bug as #854 where if you have a list of Scheduler instances that it will pop the last argument as the Scheduler instance to use which once again would result in an incorrect answer of 2 items in the collection when there should be 3.
const obs = Observable.just(Scheduler.default).startWith(
  Scheduler.default,
  Scheduler.default
);

const subscription = obs.count().subscribe(x => console.log(x))
// => 2

My proposal is the following with once again having two operators, one without a scheduler, and one with an explicit scheduler.  That way we don't have to do any sniffing to determine whether they supplied a Scheduler or it's just another value.
export function startWith<T>(...array: Array<T>): Observable<T>;
export function startWithScheduled<T>(scheduler: Scheduler, ...array: Array<T>): Observable<T>;

That way we don't have to do any sniffing to determine whether they supplied a Scheduler or it's just another value.

We're already stuck doing that in most cases, because 1. it's generally an optional parameter. and 2. The Microsoft spec actually stipulates that Scheduler be the last argument. So that means in functions with "splat params" we're stuck with a little type checking up front.
This isn't so bad, because we're generally only doing it once when the Observable chain is set up. It would be worse if we had to make these checks in the Subscriber itself.

@blesh yes, the spec says that, but we've had to make the exceptions of course with StartWith
If you were to keep the scheduler as a parameter, I would suggest moving it to the first parameter just as we have it in RxJS v4.  Thus we could do the following easily, one specifying a scheduler, otherwise, not.
const obs1 = Observable.just(4).startWith(null, 1, 2, 3);
const obs2 = Observable.just(4).startWith(Scheduler.default, 1, 2, 3);

@mattpodwysocki I think if we add Scheduler.none, this becomes a non-issue.
Observable.of('something').startWith(Scheduler.sync, Scheduler.sync, Scheduler.sync, Scheduler.none);
We can keep the scheduler to be used at the end, and in the unlikely event someone wants to create an unscheduled Observable of Schedulers, they can do so by passing Scheduler.none as the last argument.

Rebooting discussion here #1196


Add a tag limit to the autocomplete input with a way to elide and display further tags

The current maxTags setting only allows you to control how many tags are entered.
What I am thinking of is a visual way to elide the list of tags in the autocomplete input when they reach a configured amount of tags/input width.
The autocomplete input will then need to provide some form of elided message (something like: ...12 more) that when clicked will expand the input to a scrollable version of the input listing all selected tags.
The max-labels config parameter for angular-multi-select is an example of what I'm thinking of:

max-labels
Maximum number of items that will be displayed in the dropdown button. If not specified, will display all selected items.
Example: If we use the input-model $scope.inputList above, then
max-labels="1" will display: "Bruce Wayne, ... (Total: 2)" on the button.
max-labels="0" will display: "(Total: 2)" on the button.

Hi @mbenford ,
Just going back to what you have suggested here https://github.com/mbenford/ngTagsInput/issues/210#issuecomment-52431874
How can you write this directive for Angular 1.3 because it does work for 1.2 but not for 1.3.
Many thanks.

This issue was selected to be spring-cleaned by a script. More information can be found here.
If anyone thinks this was a mistake and this issue should be reopened, please leave a message below explaining why. Before doing so, please consider reading the CONTRIBUTING file.


Add nice-modal-react

nice-modal-react
A nice modal manager for React.
Link: https://ebay.github.io/nice-modal-react/
Checklist:

[x] I have performed a self-review of submitted resource and its follows the guidelines of the project.

Thanks for the commit, We try to add Libraries instead of single components.


Linked lobbies aren't being used - default lobby set is overriding.

Compiled as of https://github.com/A5H73Y/Parkour/commit/d3cbb66f46a7bfcc1755b11293a3769b999f9f7d
On exit when playing in courses with a linked lobby, it is taking players to the default lobby location instead of the set linked one.
Edit: It seems custom lounges don't work whatsoever outright. Removing the default lounge location, it just spams that no lounge has been setup despite a custom one existing and being linked to a course. With a default location set in addition to a custom location set / linked, it always uses the default location.
Lobby:
  Set: true
  World: world
  X: -6287.321349023397
  Y: 125.0
  Z: 2116.5467648669683
  Pitch: 2.9999778
  Yaw: -90.3022
  parkour:
    World: world
    X: -11380.5
    Y: 107.0
    Z: 10961.5
    Pitch: -0.15001002
    Yaw: -90.08281

Courses:
- spawn
- parkour1
- parkour2
- parkour3
- parkour4
- parkour5
- parkour6
- parkour7
- parkour8
- parkour9
- parkour10
- parkour11
- parkour12
- parkour13
- parkour14
- parkour15
- parkour16
- parkour17
- parkour18
- parkour19
- parkour20
- parkour21
- parkour22
- parkour23
- parkour24
- parkour25
spawn:
  Creator: player
  Views: 1258
  Completed: 59
  XP: 0
  Points: 0
  World: world
  '0':
    X: -6293.703158744823
    Y: 126.0
    Z: 2115.380310594939
    Yaw: 109.047844
    Pitch: 6.449876
  Finished: true
parkour1:
  Creator: player
  Views: 3
  Completed: 0
  XP: 0
  Points: 0
  World: world
  '0':
    X: -11428.5
    Y: 151.5
    Z: 10900.5
    Yaw: -90.68261
    Pitch: 1.0499918
  LinkedLobby: parkour
parkour2:
  Creator: player
  Views: 0
  Completed: 0
  XP: 0
  Points: 0
  World: world
  '0':
    X: -11428.5
    Y: 151.5
    Z: 10941.5
    Yaw: -90.83276
    Pitch: -0.29999185
  LinkedLobby: parkour

This came up during testing I did, and is by design.
Currently, if you exit a course without completing it, then you are sent back to the default lobby (which must exist).
If you complete the course only then do you progress to the linked lobby.
That's the logic but I think it was under review as to whether it should be configurable.

What's the point of setting a custom lobby for a specific course if that lobby isn't going to be used on exit? Seems a bit redundant.

Sure, you've both raised this and as Steve mentioned I was going to make this configurable but didn't get around to it.. I will add this in my next commit.
The theory when I had a Parkour server than someone would get 'promoted' to the custom lobby only once they'd completed the course required to join it. If you joined a 'hard' course and failed, you wouldn't want them to have the satisfaction of joining a hard lobby. (It made more sense in my head at the time)

@A5H73Y
With this set to true, it outputs 'lobby does not exist' when using the exit tool in a course that does not have a custom lobby set.
OnLeave:
  TeleportToCustomLobby: true

Lobby:
  Set: true
  World: world
  X: -6287.5
  Y: 125.0
  Z: 2116.5
  Pitch: -1.0501239
  Yaw: -90.002174

Could you add a check to use the default lobby location if a specified one doesn't exist?

Can't believe I didn't find that problem, will look into this.. thanks.

This has been fixed.


Locations of language constructs lack full location information

When collecting definitions compiler does not carry enough information or information of the locations (Span + Source Part, ie file location) where definition is derived from. Because of that it's challenging to add various tooling features, specifically around langiage server as those require source locations.

Closing as this is encapsulated in the Location struct.


Extension for some rule

PropertyDTO and OtherDTO are from different inheritance hierarchies so, how could i write an extension function for replacing the RuleFor(p => p.Id).IdRule() so i do not have to repeat the p=>p.Id expression each of those DTOs with Id field?
public static class Extensions
{
    public static void IdRule<T>(this IRuleBuilder<T, int> @this)
    {
        @this.Must(id => id >= 1).WithMessage("Id is invalid.");
    }
}
public class PropertyDTOValidator : AbstractValidator<PropertyDTO>
{
    public PropertyDTOValidator ()
    {
        RuleFor(p => p.Id).IdRule();
    }
}
public class OtherDTOValidator : AbstractValidator<OtherDTO>
{
    public OtherDTOValidator ()
    {
        RuleFor(p => p.Id).IdRule();
    }
}

You'd need to introduce an interface to make the property common for both types.

That is possible but i am looking if its possible without a common base or interface.

It is not possible without a common base class or interface.

Is not it possible by dynamic expression generation?

I don't recommend it. The entire point of FluentValidation is strongly-typed rules at compile time. If you want to try it though there's nothing stopping you, but I'm afraid I can't help you with that.


Extend documentation for deploy development

This is a first pass of adding additional documentation.
While it is not complete, it provides the structure that will allow us to work on different sections independently.

Hi Avritt, I left some comments for you in the docs with ideas for which parts you could own. Feel free to claim other areas too and let me know which ones so we don't overlap in unwanted ways.

With regards to your  comment:
"I do wonder if we can consolidate prerequisits.md and developer-guide.md and make the steps easier to follow. I think a good starting point would be to document the dev flow where we clone all 3 repos to the dev machine, then point civiform-deploy checkout code to get code from the local cloud-deploy-infra repo"
I considered that and decided against it because for example all of the AWS setup etc is only really required once and makes it hard to find other resources again if you come back to the site regularly. However, the git setup and cloning is somewhere in the middle. It is not needed every time you come back, but it is needed every time you start a new change.
I initially had that in the developer guide and would be happy to move it there again. I mostly moved it to the prerequisits because the structure than matches your original doc (which isn't a strong reason for sure)
Those sections aren't written yet, so it would be more of a matter of where to put them than changing this change...

Hi Avritt and Rocky, in the interest of us being able to pick up the todos I'll submit the docs as they are, but feel free to ping me if you think any of the comments weren't resolved adequately and I'll do further changes in a separate change. Thanks for the review :-)


VS code crash

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version:  Version:               1.91.0 (1.91.0)
OS Version:  OS Version:            macOS 11.7.10 (20G1427)

Steps to Reproduce:

Just launching the vs code, crashes  it and open a crash report popup
Had tried to restart, clear cached data, tried universal as well as silicon version both ends up crashing
here's a excerpt from crash report

Process:               Electron [1818]
Path:                  /Applications/Visual Studio Code.app/Contents/MacOS/Electron
Identifier:            com.microsoft.VSCode
Version:               1.91.0 (1.91.0)
Code Type:             ARM-64 (Native)
Parent Process:        ??? [1]
Responsible:           Electron [1818]
User ID:               502

Date/Time:             2024-07-06 23:37:28.080 +0530
OS Version:            macOS 11.7.10 (20G1427)
Report Version:        12
Anonymous UUID:        A507F1ED-34B4-79CC-640F-4825022BCC0C

Time Awake Since Boot: 1200 seconds

System Integrity Protection: enabled

Crashed Thread:        0  CrBrowserMain  Dispatch queue: com.apple.main-thread

Exception Type:        EXC_BAD_ACCESS (SIGSEGV)
Exception Codes:       KERN_INVALID_ADDRESS at 0x0000000000000000
Exception Note:        EXC_CORPSE_NOTIFY

/duplicate https://github.com/microsoft/vscode/issues/219893


action-slack-notify:v2.2.0 no longer in docker hub

Hello,
We're not seeing the latest version of action-slack-notify on ghcr.io and on docker hub anymore:
https://hub.docker.com/r/rtcamp/action-slack-notify/tags
Not sure if this is just an issue with ghcr.io/docker hub, but thought I would let you know. Anytime we try to use  uses: rtCamp/action-slack-notify@v2 in github actions, they fail with:
/usr/bin/docker pull ghcr.io/rtcamp/action-slack-notify:v2.2.0
  Error response from daemon: received unexpected HTTP status: 500 Internal Server Error
Error: Docker pull failed with exit code 1

Workaround at the moment is just commenting out action-slack-notify in our github actions.

It's working again. I think theres an issue with github. Closing this issue.


Add script for pushing container images via Travis

Signed-off-by: Nolan Brubaker<EMAIL_ADDRESS>

This isn't completely hooked up to Travis yet, and some of the variable names may need to change.
However, I'd appreciate double checking my script's logic for tagging latest against the requirements noted in the issue.

Yeah, we don't want any pre-release versions being tagged as latest. They should still get pushed, just not marked as latest.
Your git describe --tags $(git rev-list --tags --max-count=1) command appears to do the correct thing on my machine, even with pre-release tags included. I'll see if this is consistent, if so then I think it'll be better than my function.

Since git rev-list lists commits in reverse chronological order, I think it's usable here. What I don't know is if we do a release where no commits are added between a pre-release and the final release, what will it return?

Ok, testing this, it looks like when 2 tags point to the same commit, the one created most recently is returned.

Thanks for explaining and looking into whether that command will work. Sounds like that's what we want so we can replace that function

@prydonius The more I thought about it, the more I think you're right that we could use the $TRAVIS_TAG versus any git commands. The only addition we really need is to check if that tag's pre-release.

The only addition we really need is to check if that tag's pre-release.

Doh, this is incorrect. We also need to make sure it's also the highest semantic version. So far example, if we release v1.2.0 followed by v1.1.1, the latest is v1.2.0, not v1.1.1

Ah yes, I was thinking we wouldn't need to build older tags, but you're right that we would need to for patch versions.

Doh, this is incorrect. We also need to make sure it's also the highest semantic version. So far example, if we release v1.2.0 followed by v1.1.1, the latest is v1.2.0, not v1.1.1

Yep needs to be highest semver tag, not just most recent.

From my local tests, the previous looping approach will still get v.1.1.0 even if I tag v1.0.1 against a more recently commit. The git describe --tags command will get the v1.01 tag instead.

@prydonius @skriss I believe this is ready now. The latest tagging logic appears to have worked on my fork, and using Xenial + updating gcloud makes it so we don't have to modify our Makefile's usage of the docker command.


First step detection is not working when used multiple times in a composite actions

If the gradle-build-action is used multiple times, only the first usage should configure the caching behavior, e.g. cache-read-only. This doesn't seem to work properly when used multiple times insight a composite action.
See https://github.com/spockframework/spock/runs/4651574620?check_suite_focus=true for example.

name: Setup Gradle and JDKs
description: Sets up Gradle and JDKs

runs:
  using: "composite"
  steps:
    - name: Init Gradle Build Action
      uses: gradle/gradle-build-action@v2
      with:
        # cache options only count for the first invocation
        cache-read-only: ${{ github.ref != 'refs/heads/master' }}
        arguments: --version
    - name: 'Gradle javaToolchains'
      uses: gradle/gradle-build-action@v2
      with:
        arguments: javaToolchains

The second invocation will upload the cache entry.

Thanks for the report @leonard84 . Can you please test again with (just released) v2.1?
The "first step" detection is different in that version and I was not able to reproduce this issue. Thanks.

The new version, seems to have fixed the problem https://github.com/spockframework/spock/runs/4689750253?check_suite_focus=true


Rename SECURITY.md to @https:/instagram.com/qbm?igshid=yjgzq2hzwmy6

@atsushieno https://instagram.com/qbm?igshid=yjgzq2hzwmy6
Description
New tool, Bug fixing, or Improvement?
Please include a summary of the change and which issue is fixed. Also include relevant motivation and context.
For new tools, please provide total size and installation time.

Related issue:
Check list

[x] Related issue / work item is attached
[x] Tests are written (if applicable)
[x] Documentation is updated (if applicable)
[x] Changes are tested and related VM images are successfully generated

https://instagram.com/qbm?igshid=yjgzq2hzwmy6

https://instagram.com/qbm?igshid=yjgzq2hzwmy6


Add Submit button to review form

We should make clear to users how they can complete the review form by adding a button to 'submit' the information. This should result in the review being appended to the article and should replace the current blue arrow button affordance.

Can we label the button "Add review"?
Also wondering if we can include feedback once the action is complete? I added a banner in the designs.

https://projects.invisionapp.com/share/B9WVPQAS4PE#/screens/417703802_EC-Review-Posted

Happy for text to be "Add review" but the banner will be work for another ticket pending feedback.


Implement read_maxwell(...)

maxwell device generate an hdf5 file that contain mea activated channel and there locations.
This could render a Probe object with read_maxwell(...)
@yger is this for you, do not disappoint me!

#34

#34

Close by #34

Close by #34

thought I would add that this is not exposed in the __init__.py file


Support for SSR

Hi, could you please add support for server side rendering.
Currently, an unhandled exception "window is not defined" error is being thrown.
Thanks in advance!

@kiitoc Hi,
This carousel is depreciated. Use @ngu/carousel. It supports SSR.
Thanks


JAVA-2528: Store suppressed exceptions in AllNodesFailedException

LGTM.
Overall I think it's a good change, but I'd just like to emphasize the fact that stack traces include suppressed exceptions. Here's an
example with bad credentials on a 3-node cluster.
One risk is that we get backlash because stack traces are getting too long. But I think with typical deployments (number of contact points, number of retries triggered by the policy), the number of child exceptions should remain low. Also, our client-side representations of server errors (UnavailableException, etc.) don't fill their stack trace, so they won't take too much space.

Maybe we could add some kind of a threshold parameter (similar to dsbulk) for setting the upper bound of number of suppressed exceptions?

Maybe we could add some kind of a threshold parameter (similar to dsbulk) for setting the upper bound of number of suppressed exceptions?

Valid concern, but let's wait until someone complains before making this class any more complex.


Wrong file information

Hello. I have problem - when i select "Attach filename.py" and typed prompt (fix duplications in code), refact (on gpt3.5) answered me next:

But i dont have segment_mean function and code, which located in this function. If i select "selected *** lines", it works correctly.

Hello,
in the second screenshot, the lsp should have processed the @file ... command and removed it from the message after adding the file. It's posable that it may have failed to to do this.
I'll investigate further, can you confirm if the file is 10260 lines long?

We have recreated the issue by trying to attach a very large file.

Although my code has changed at the moment, my code certainly did not contain 10 thousand lines at that time.  Otherwise I wouldn't be able to send the entire file as a text message. I'll try again tomorrow.


LICENSE: Fix copyright notice

Coverage remained the same at 100.0% when pulling 9eee9c231eaacd9eec1457a2cabd47ff955bf91e on fix-copyright into a477bbf001842288dea5c16cb3c3b301691ce0a2 on master.


feat: rewrite snapshot.py as an Ansible module / add support for thin origins

Enhancement: rewrite snapshot.py as an Ansible module / add support for thin origins
Reason:
https://github.com/linux-system-roles/snapshot/issues/43
https://github.com/linux-system-roles/snapshot/issues/57
Result:
Referenced issues fixed
Issue Tracker Tickets (Jira or BZ if any):

[citest]

ping - any updates?

@trgill This PR should fix all of those ansible-test (and flake8, pylint, black) issues.  https://github.com/trgill/snapshot/pull/6  I didn't test it but hopefully the errors will be obvious
A big change was using module.run_command - which means most of the methods required the addition of the module argument - the way other modules handle this is by declaring a module class e.g. SnapshotModule(AnsibleModule) and putting all of the methods in this class - then you can just use self.module.run_command everywhere instead of having to pass module as a method argument.

[citest]

[citest bad]

[citest bad]

@richm I rebased on your changes, will that include the fixes needed?

@richm I rebased on your changes, will that include the fixes needed?

You'll also need to merge this PR - https://github.com/trgill/snapshot/pull/7

[citest]

[citest bad]

@trgill centos-7 testing is broken currently - it is being worked on - the only way to test that is locally with tox-lsr

@richm Ok - I'll run centos-7 tests locally

In the latest commit, I still get errors with the thin pool tests on centos-7:
tests/tests_set_thin_basic.yml - Failed to commit changes to disk: (FSError('format failed: 1',), '/dev/mapper/test_vg2-lv7')

and tests_thin_basic.yml doesn't have thin_pool_size for all of the test volumes

I updated the thin tests to only use 1 source VG.  I tested locally on centos-7 and it works.

@richm I think this is ready to merge?

[citest]

[citest bad]

not sure what the problem is with centos-9, but tests pass locally.  centos-7 passes locally also.


Enable data table exports in the usage snippets for recipes that have custom data tables

What problem are you trying to solve?
Make data tables more discoverable by generating recipe run snippets that enable datatables for specific recipes.
Describe the solution you'd like
We already detect which recipes have custom data tables:
https://github.com/openrewrite/rewrite-recipe-markdown-generator/blob/6953e4f0d681076b45cf6ce4bbdbbf325c001874/src/main/kotlin/org/openrewrite/RecipeMarkdownGenerator.kt#L880-L891
We also have an option to export data tables, as documented here:
https://docs.openrewrite.org/running-recipes/data-tables
What I'd like to see is for any recipes that have custom data tables, that we enable that option by default for the Maven XML snippets and commandline.
Alternatives
Right now we produce a header that (wrongly) indicates data tables are unique to the Moderne platform. That's no longer the case.

Data Tables (Only available on the Moderne platform)

Alternative we could refer to the docs on how to enable data table exports explicitly, but that's less user friendly then just inserting that into the doc snippets.
Additional context
This came up in looking to document how to export parse failures; we have a recipe page for that particular recipe, but that only produces a data table not enabled by default: https://docs.openrewrite.org/recipes/core/findparsefailures

/cc @mike-solomon


docker:cli how to set insecure-registries?

Hi,
I'm using a docker:cli image inside kubernetes with a buildkit pod to run my CI pipelines.
The build part works great but when I try to login into a local insecure registry to push my images it complains :
http: server gave HTTP response to HTTPS client
Usually I would just configure /etc/docker/daemon.json but I can't do that because there is no daemon in the cli image.
So how would I go about pushing images to an insecure registry?

That's a daemon configuration, so it has to be set on whichever daemon your CLI is talking to in order for it to take effect.

I have no docker daemon running, only builkitd inside another pod. I create a remote builder inside the docker:cli pod.
docker buildx create --name remote-builder --driver remote tcp://buildkitd:1234  no daemon needed
then I use it to build
docker build --builder remote-builder -t <my_registry>/path/image_name:tag --push no daemon needed, no error for insecure registry, only 401 because I'm not logged in.
When I try to docker login it complains about the insecure registry.
So do I really need a running daemon to login into my registry?

Okay so I managed to do it, inside buildkitd.toml I configured the insecure registry, then inside my pipeline instead of docker login I write the .docker/config.json file by hand.
mkdir ~/.docker
echo "{\"auths\":{\"$REGISTRY_URL\":{\"auth\":\"$(echo -n ${REGISTRY_LOGIN}:${REGISTRY_PASSWORD} | base64)\"}}}" > ~/.docker/config.json

Then I can call docker build <...> --push and everything works just fine.


Use of HemholtzMedia in openmodelica 3.2.3

Hi, I have downloaded the latest version from GITHUB and loaded the library into OMEdit using 3.2.3. However, none of the examples for tests run. I think I am missing something. If I use ButaneTestModel_ph I get
Check of HelmholtzMedia.Examples.MediaTestModels.ButaneTestModel_ph completed successfully.
Instantiation of HelmholtzMedia.Examples.MediaTestModels.ButaneTestModel_ph completed successfully.
But running fails, the first error is :
Internal error No support of solving not real variables with a non-linear solver.
Equation:
HelmholtzMedia.Examples.MediaTestModels.ButaneTestModel_ph.Medium.SaturationProperties(fixedMassFlowRate.medium.sat.psat, fixedMassFlowRate.medium.sat.Tsat, HelmholtzMedia.Examples.MediaTestModels.ButaneTestModel_ph.Medium.ThermodynamicState(fixedMassFlowRate.medium.sat.liq.phase, fixedMassFlowRate.medium.sat.liq.T, fixedMassFlowRate.medium.sat.liq.p, fixedMassFlowRate.medium.sat.liq.d, fixedMassFlowRate.medium.sat.liq.u, fixedMassFlowRate.medium.sat.liq.h, fixedMassFlowRate.medium.sat.liq.s), HelmholtzMedia.Examples.MediaTestModels.ButaneTestModel_ph.Medium.ThermodynamicState(fixedMassFlowRate.medium.sat.vap.phase, fixedMassFlowRate.medium.sat.vap.T, fixedMassFlowRate.medium.sat.vap.p, fixedMassFlowRate.medium.sat.vap.d, fixedMassFlowRate.medium.sat.vap.u, fixedMassFlowRate.medium.sat.vap.h, fixedMassFlowRate.medium.sat.vap.s)) = HelmholtzMedia.Examples.MediaTestModels.ButaneTestModel_ph.Medium.setSat_p(volume.medium.p) solve for {fixedMassFlowRate.medium.sat.psat,fixedMassFlowRate.medium.sat.liq.h,fixedMassFlowRate.medium.sat.vap.d,fixedMassFlowRate.medium.sat.vap.u,fixedMassFlowRate.medium.sat.vap.h,fixedMassFlowRate.medium.sat.vap.s,fixedMassFlowRate.medium.sat.liq.u,fixedMassFlowRate.medium.sat.vap.phase,fixedMassFlowRate.medium.sat.liq.s,fixedMassFlowRate.medium.sat.vap.T,fixedMassFlowRate.medium.sat.liq.phase,fixedMassFlowRate.medium.sat.liq.T,fixedMassFlowRate.medium.sat.Tsat,fixedMassFlowRate.medium.sat.vap.p,fixedMassFlowRate.medium.sat.liq.p,fixedMassFlowRate.medium.sat.liq.d}
Followed by
Internal error createEquationsForSystems failed then many more
Can you help get me going. Thanks

HelmholtzMedia is not yet fully supported by OpenModelica, see the current status in https://github.com/thorade/HelmholtzMedia/issues/34#issuecomment-623008764.
Please read that carefully and follow all links (especially the link to Library report)
You mention version 3.2.3, but that is the version of the Modelica Standard Library MSL.
What version of OpenModelica are you using?

Yes I have the same:
Connected to OpenModelica v1.14.1 (64-bit)
Connected to OMSimulator v2.1.0-dev-147-g36ec2c7-mingw
What software would need to run HelmholtzMedia

Sorry for the confusion: I used that screenshot above only to show where to find the version. Significant improvements have been made on OpenModelica side since 14.1 was released, so you should install the latest Stable Development or Nightly Build.
https://openmodelica.org/download/download-windows
This is especially convenient on Linux.
With that version, more than half of the examples should work; you can see what to expect here:
https://libraries.openmodelica.org/branches/newInst/HelmholtzMedia/HelmholtzMedia.html
or in https://github.com/thorade/HelmholtzMedia/issues/34#issuecomment-623008764

Hi, I was reading your paper "Partial derivatives of thermodynamic state properties for
dynamic simulation" and was wondering if you have ever came across the same analysis but for multiphase mixtures i.e. more than one component, so not pure. I have started to look at it. Most people do a numerical derivative but an analytical one would be more efficient for dynamic simulation. I found the multicomponent Clapeyron equation but was wondering if you have seen this attempted elsewhere.

Maybe this one is interesting:
https://www.researchgate.net/publication/304186500_Helmholtz_Energy_Transformations_of_Common_Cubic_Equations_of_State_for_Use_with_Pure_Fluids_and_Mixtures

Closing this issue, but you can still comment.


feat(dropdown) Add support of TemplateRef for invalidText input

Add support of TemplateRef for invalidText input of dropdown as in other components (for example https://github.com/IBM/carbon-components-angular/blob/master/src/combobox/combobox.component.ts#L138 )
Changelog
Changed

Add support of TemplateRef for invalidText input

@cal-smith Could you please merge these non-breaking changes?

@Donisius, can you merge it, please?

Occasionally closed it =(


SASL connect fails with RuntimeError: await wasn't used with future

robinhood-aiokafka version 1.1.3
Connecting to Kafka using SASL fails with 'RuntimeError: await wasn't used with future'
in aiokafka/conn.py, AIOKafkaConnection._do_sasl_handshake():
res = await authenticator.step(auth_bytes)
Fix is missing await in aiokafka/conn.py:
class BaseSaslAuthenticator:
async def step(self, payload):
    return **await** self._loop.run_in_executor(None, self._step, payload

Traceback (most recent call last):
File "/usr/local/lib/python3.7/site-packages/mode/worker.py", line 264, in execute_from_commandline
self.loop.run_until_complete(self._starting_fut)
File "/usr/local/Cellar/python/3.7.3/Frameworks/Python.framework/Versions/3.7/lib/python3.7/asyncio/base_events.py", line 584, in run_until_complete
return future.result()
File "/usr/local/lib/python3.7/site-packages/mode/services.py", line 719, in start
await self._default_start()
File "/usr/local/lib/python3.7/site-packages/mode/services.py", line 726, in _default_start
await self._actually_start()
File "/usr/local/lib/python3.7/site-packages/mode/services.py", line 750, in _actually_start
await child.maybe_start()
File "/usr/local/lib/python3.7/site-packages/mode/services.py", line 778, in maybe_start
await self.start()
File "/usr/local/lib/python3.7/site-packages/mode/services.py", line 719, in start
await self._default_start()
File "/usr/local/lib/python3.7/site-packages/mode/services.py", line 726, in _default_start
await self._actually_start()
File "/usr/local/lib/python3.7/site-packages/mode/services.py", line 750, in _actually_start
await child.maybe_start()
File "/usr/local/lib/python3.7/site-packages/mode/services.py", line 778, in maybe_start
await self.start()
File "/usr/local/lib/python3.7/site-packages/mode/services.py", line 719, in start
await self._default_start()
File "/usr/local/lib/python3.7/site-packages/mode/services.py", line 726, in _default_start
await self._actually_start()
File "/usr/local/lib/python3.7/site-packages/mode/services.py", line 743, in _actually_start
await self.on_start()
File "/usr/local/lib/python3.7/site-packages/faust/transport/drivers/aiokafka.py", line 649, in on_start
await producer.start()
File "/usr/local/lib/python3.7/site-packages/aiokafka/producer/producer.py", line 171, in start
await self.client.bootstrap()
File "/usr/local/lib/python3.7/site-packages/aiokafka/client.py", line 203, in bootstrap
version_hint=version_hint)
File "/usr/local/lib/python3.7/site-packages/aiokafka/conn.py", line 90, in create_conn
await conn.connect()
File "/usr/local/lib/python3.7/site-packages/aiokafka/conn.py", line 214, in connect
await self._do_sasl_handshake()
File "/usr/local/lib/python3.7/site-packages/aiokafka/conn.py", line 281, in _do_sasl_handshake
payload, expect_response = res
RuntimeError: await wasn't used with future

i think it's better to stay close as possible of the behavior of aio-libs/aiokafka, i made another PR will fix the issue #18

I'm also seeing this issue, PR #18 fixes it for me.

I am also getting this error and have opened an issue on aio-libs: [https://github.com/aio-libs/aiokafka/issues/580]


I 2258 : Improve passive sync performance

test this please
Looks like a random failure.

@henri-tremblay , can you merge if found OK? Updated all review comments..

@henri-tremblay, Can you please take a final look and merge?

@rkavanap I've approved. @chrisdennis needs to approve as well to merge.


Improve error handling for TransactionProcess

We can not catch the error in queue, because the function in helper already catch the error
https://github.com/tomochain/tomoscan/blob/6eeccc8dc5a6829c9211266a0c85a2c02becfdf6/server/src/queues/transaction.js#L15
I suggest the function should return true, false => if false, then error

#549


Wrong sounds

When a 1.8 player closes a fence gate it makes a sound of a arrow sometimes.
and other times a random ghast sounds just appear, I don't know what is making the ghast song.

#10

Closed, duplicate of #10


ISPN-6943 Upgrade to Hibernate HQL Parser version 1.3.0.Final

https://issues.jboss.org/browse/ISPN-6943

Updated.

Sorry, forgot to close this. Thanks Adrian!


Adding wombat theme

ported from lualine

I'll add screenshots THEMES.md later

I'll add screenshots THEMES.md later

Should I give screenshots based on current master or from a version where #55 and #60 are merged?

Should I give screenshots based on current master or from a version where #55 and #60 are merged?

Should I give screenshots based on current master or from a version where #55 and #60 are merged?

Obviously the current version. We'll take care of powerline symbols later

Should I give screenshots based on current master or from a version where #55 and #60 are merged?

Obviously the current version. We'll take care of powerline symbols later

If you happen to check them out . You can tell me if any color needs changing before I take the screenshots. I'm basically using afew macros to take color values from lightlines vimscript files.

If you happen to check them out . You can tell me if any color needs changing before I take the screenshots. I'm basically using afew macros to take color values from lightlines vimscript files.

If you happen to check them out . You can tell me if any color needs changing before I take the screenshots. I'm basically using afew macros to take color values from lightlines vimscript files.

Sure I will check them out in detail the day after tomorrow.

Plus tell me if any theme on your list has a higher priority

I think we should support all themes with over 800 stars including all their versions. (ayu for example has 3 versions). This would cover 95% of people imo, others could port their own theme or use auto when it's ready. You can check the top vim themes here

If you happen to check them out . You can tell me if any color needs changing before I take the screenshots. I'm basically using afew macros to take color values from lightlines vimscript files.

Sure I will check them out in detail the day after tomorrow.

Plus tell me if any theme on your list has a higher priority

I think we should support all themes with over 800 stars including all their versions. (ayu for example has 3 versions). This would cover 95% of people imo, others could port their own theme or use auto when it's ready. You can check the top vim themes here


test(clerk-js): OrganizationMembers test cases for the "requests" tab

Type of change

[ ] 🐛 Bug fix
[ ] 🌟 New feature
[ ] 🔨 Breaking change
[ ] 📖 Refactoring / dependency upgrade / documentation
[x] other: Adding tests

Packages affected

[x] @clerk/clerk-js
[ ] @clerk/clerk-react
[ ] @clerk/nextjs
[ ] @clerk/remix
[ ] @clerk/types
[ ] @clerk/themes
[ ] @clerk/localizations
[ ] @clerk/clerk-expo
[ ] @clerk/backend
[ ] @clerk/clerk-sdk-node
[ ] @clerk/shared
[ ] @clerk/fastify
[ ] @clerk/chrome-extension
[ ] gatsby-plugin-clerk
[ ] build/tooling/chore

Description

[x] npm test runs as expected.
[x] npm run build runs as expected.

This PR is about testing the OrganizationMembers page

Brings back some old tests that were commented out because of UI changes + it updates them.
Adds new tests for the new "requests" tab

This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.


Add relief camp data

https://keralarescue.in/add_camp_data/
Validation not working.  While pressing submit button without filling any details showing success page,  please check and update

removed the page


 Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.',)
WARNING: Requested formats are incompatible for merge and will be merged into mkv.
[debug] Invoking downloader on u'https://r8---sn-cn3tc-aige.googlevideo.com/videoplayback?ei=VjbLV5PnF4P4WMHHgnA&itag=135&sparams=clen%2Cdur%2Cei%2Cgcr%2Cgir%2Cid%2Cinitcwndbps%2Cip%2Cipbits%2Citag%2Ckeepalive%2Clmt%2Cmime%2Cmm%2Cmn%2Cms%2Cmv%2Cpl%2Crequiressl%2Csource%2Cupn%2Cexpire&ms=au&mt=1472934878&dur=1390.466&mv=m&clen=20522888&ip=2a02%3Ac7d%3A7829%3A2d00%3Af5bb%3A53be%3A4a9%3A456d&initcwndbps=692500&gir=yes&mm=31&ipbits=0&mn=sn-cn3tc-aige&lmt=1427901444116238&gcr=gb&sver=3&upn=oCskbUSttgM&requiressl=yes&keepalive=yes&id=o-AEC5XM-hwTlfg0N0tnKEtwz0nEp2JvQmRxGk0ZagdF3G&expire=1472957110&source=youtube&mime=video%2Fmp4&pl=39&key=yt6&signature=38EDA307EFC4F6C14FC6A19A515ADC46759701AF.07997850755FF64D926167E49E8F3B1518D969F3&ratebypass=yes'
[download] Destination: Dirty chess tricks 9 (Grob's Attack)-4G98sGv2NSU.f135.mp4
[download] 100% of 19.57MiB in 02:20
[debug] Invoking downloader on u'https://r8---sn-cn3tc-aige.googlevideo.com/videoplayback?ei=VjbLV5PnF4P4WMHHgnA&itag=251&sparams=clen%2Cdur%2Cei%2Cgcr%2Cgir%2Cid%2Cinitcwndbps%2Cip%2Cipbits%2Citag%2Ckeepalive%2Clmt%2Cmime%2Cmm%2Cmn%2Cms%2Cmv%2Cpl%2Crequiressl%2Csource%2Cupn%2Cexpire&ms=au&mt=1472934878&dur=1390.541&mv=m&clen=23567094&ip=2a02%3Ac7d%3A7829%3A2d00%3Af5bb%3A53be%3A4a9%3A456d&initcwndbps=692500&gir=yes&mm=31&ipbits=0&mn=sn-cn3tc-aige&lmt=1415082645485773&gcr=gb&sver=3&upn=oCskbUSttgM&requiressl=yes&keepalive=yes&id=o-AEC5XM-hwTlfg0N0tnKEtwz0nEp2JvQmRxGk0ZagdF3G&expire=1472957110&source=youtube&mime=audio%2Fwebm&pl=39&key=yt6&signature=25CACAEE2128B7CEA9871FFD831306F13B66539C.5A9C3832BAA1974FEA48E1DB90AE0FDA8B5D0A12&ratebypass=yes'
[download] Destination: Dirty chess tricks 9 (Grob's Attack)-4G98sGv2NSU.f251.webm
[download] 100% of 22.48MiB in 02:47
[ffmpeg] Merging formats into "Dirty chess tricks 9 (Grob's Attack)-4G98sGv2NSU.mkv"
[debug] ffmpeg command line: avconv -y -i 'file:Dirty chess tricks 9 (Grob'"'"'s Attack)-4G98sGv2NSU.f135.mp4' -i 'file:Dirty chess tricks 9 (Grob'"'"'s Attack)-4G98sGv2NSU.f251.webm' -c copy -map 0:v:0 -map 1:a:0 'file:Dirty chess tricks 9 (Grob'"'"'s Attack)-4G98sGv2NSU.temp.mkv'
Deleting original file Dirty chess tricks 9 (Grob's Attack)-4G98sGv2NSU.f135.mp4 (pass -k to keep)
Deleting original file Dirty chess tricks 9 (Grob's Attack)-4G98sGv2NSU.f251.webm (pass -k to keep)

Duplicate of #8944.


Fix tinyformat wchar build error on Windows

boost::filesystem::path.c_str() returns a wchar_t* on Windows (at least in Boost 1.58). OIIO tinyformat doesn't support wchar_t by default unless you define TINYFORMAT_ALLOW_WCHAR_STRINGS, which OSL doesn't do.
This uses OIIO::Filesystem::filename() instead to get an std::string.

LGTM. We should be going through the Filesystem utilities rather than having any bare boost::filesystem references, if possible. I will merge this.

Merged into master and RB-1.6. Thanks for the fix.
I spotted a couple other uses of boost::filesystem. I'll fix those and prepare a separate PR.


maps-demo branch will not build

it appears since npm offline cache is used it has issues downloading some packages.
➜  hmda-data-browser git:(88ceb64) docker build --rm -t=hmda/hmda-data-browser .                                                                                (hmda4/default)
Sending build context to Docker daemon  42.55MB
Step 1/17 : FROM node:8.16.0-alpine as build-stage
 ---> e08ba08cf75a
Step 2/17 : WORKDIR /usr/src/app
 ---> Using cache
 ---> aba6e4e7b06e
Step 3/17 : COPY package.json yarn.lock .yarnrc ./
 ---> Using cache
 ---> 553c4d8689e9
Step 4/17 : COPY npm-packages-offline-cache ./npm-packages-offline-cache
 ---> Using cache
 ---> 312d8c67dc31
Step 5/17 : RUN yarn install
 ---> Running in bd0f5e52d9dc
yarn install v1.15.2
[1/5] Validating package.json...
[2/5] Resolving packages...
[3/5] Fetching packages...
error Can't make a request in offline mode ("https://registry.yarnpkg.com/mapbox-gl/-/mapbox-gl-1.5.0.tgz")
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
The command '/bin/sh -c yarn install' returned a non-zero code: 1

Fixed in 54df80a0


[BUG]: Home page product image is very blurry

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
A blurry image as soon as the user opens the website is not a good user experience.
I want to replace them with high quality pictures.

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

/assign-me

Kindly also provide the source of the current pictures.

@trishanu-init why was this issue closed? The issue still exists on the site...

@RushilJalal just need to use different images...it's not worth a issue!


Implement basic performance improvements

Running a frequency pie chart off a 250k line file takes about 10 seconds on a fast laptop. This is a ballpark figure, but the use case is not that far-fetched. I'd expect it to be quite common to base charts off a million lines or so; at least for my use cases.
While not interested in adding complexity to chart's source code, there are some quick wins that can improve the response time quite a bit:

At the moment, input is read from STDIN into an empty slice. Without a size hint, this is incurring in unnecessary allocations.
Preprocessing the format requires a pass through the whole slice. The initial pass could do this step at the same time; this would save a whole pass.
Does every single line need to be processed to infer the format?

The planned improvements didn't result in noticeably faster response times. I'll close this issue but I'm open to further improvements, as long as they don't overcomplicate the code.


local-gadget: Run snapshot/process gadgets using tracers instead of the Tracer CR

[Title: describe the change in one sentence]
[ describe the change in 1 - 3 paragraphs ]
How to use
[ describe what reviewers need to do in order to validate this PR ]
Testing done
[Describe the testing you have done before submitting this PR. Please include both the commands you issued as well as the output you got.]

Opened by mistake. Sorry for the noise.


Vickel: Watch +1-866-829-1245

Vickel requests the watch of the watch_number +1-866-829-1245. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

Approved by Jeff Schaller in Charcoal HQ


ADAL operations should accept context where HTTP requests are made

Calling refresh on a token doesn't require a context today even though it may be long running. I would expect a context to be passed to this and anything that calls the function.
https://github.com/Azure/go-autorest/blob/9ad9326b278af8fa5cc67c30c0ce9a58cc0862b2/autorest/adal/token.go#L590

Fixed in https://github.com/Azure/go-autorest/releases/tag/v10.7.0


More test coverage

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (2357ed9) 80.32% compared to head (9aebe22) 81.62%.
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #19      +/-   ##
==========================================
+ Coverage   80.32%   81.62%   +1.30%
==========================================
  Files          11       11
  Lines        1230     1230
==========================================
+ Hits          988     1004      +16
+ Misses        242      226      -16

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


New package: KRPC v0.3.0

Registering package: KRPC
Repository: https://github.com/BenChung/KRPC.jl
Created by: @BenChung
Version: v0.3.0
Commit: 305096e50cf8946cdad1a260b0e94ecde320b40a
Git reference: HEAD
Description: A kRPC client for Julia

Three issues were identified as part of the automerge pipeline:

Name does not meet all of the following: starts with an upper-case letter, ASCII alphanumerics only, not all letters are upper-case.
Name is not at least 5 characters long
Package name similar to 1 existing package.

Similar to CRC. Damerau-Levenshtein distance 2 is at or below cutoff of 2.

Characters in the name:
The automatic system identified three character-related requirements that the name fails:

starts with an upper-case letter
ASCII alphanumerics only
not all letters are upper-case.

On the former, I do not understand how capital "K" is not an upper-case letter. Similarly, to my knowledge (and hex editor), every character in "KRPC" is an ASCII alphanumeric character. The latter point will be addressed in more detail in the following section on name length, but follow from this library being a wrapper over the kRPC remote procedure call library and following naming guideline #6.
Name length
The former is due to following guideline #6 in the naming recommendations, to whit,

Packages that wrap external libraries or programs should be named after those libraries or programs.

This package wraps the kRPC remote procedure call interface, and, as such,
is named after it. To meet the requirement that packages must start with an upper-case letter, the package is named
KRPC and not kRPC.
Package name similarity
The similarity arises due to the very short name, again arising from being named after the RPC system it is wrapping.  In my opinion, the names are to a human clearly distinct and the functionality wildly divergent to the point that I think that confusion is unlikely.

As a result of the above, I would like to request that this package addition be manually merged. The name follows directly from the software being wrapped, thus justifying the short length, and the naming "similarity" is a simple consequence of the short length while being highly unlikely to cause confusion in practice.

@BenChung I'm going to manually merge this, but it'd be good for your package to actually have tests, instead of an empty set

Thank you! Yes, this supersedes the earlier one, thanks.

It'd be good for your package to actually have tests, instead of an empty set

I'd love to! The problem is that I'm not sure what I can test (at least for integration testing) in this without a kRPC server to connect with, and spinning up an instance of Kerbal Space Program in CI is not particularly trivial. The main endpoints to test would be the communication routines, but mocking up the KRPC server for testing is just as likely to be buggy as the client is in the first place. I'll try and come up with some way to do it...


useHover not working if element is hide and when he reappears

@floating-ui/react-dom-interactions version 0.9.1
When My Component is mounted useHover works
if I hide the element and when he reappears useHover doesn't work
https://codesandbox.io/s/o2hozl
step 1 : hover on element menu => work
step 2 : click on hide MENU
step 3 : click again on hide menu
step 4 : hover on element menu => no working
I try to use update() from useFloating but it doesn't work.
Also it doesn't work when I use navigation.

Due to conditional rendering on the reference not being checked as events are registered inside an effect:
https://github.com/floating-ui/floating-ui/blob/28eb62929a325c878e7d128e2bedb5631d185c06/packages/react-dom-interactions/src/hooks/useHover.ts#L155-L158
For now, a workaround is to use display: none without conditionally rendering the reference element, but I think storing the reference element inside state instead of a plain ref will be required to ensure the effect runs again correctly.

Due to conditional rendering on the reference not being checked as events are registered inside an effect:
https://github.com/floating-ui/floating-ui/blob/28eb62929a325c878e7d128e2bedb5631d185c06/packages/react-dom-interactions/src/hooks/useHover.ts#L155-L158
For now, a workaround is to use display: none without conditionally rendering the reference element, but I think storing the reference element inside state instead of a plain ref will be required to ensure the effect runs again correctly.

thanks
with "display: none" it works


remove getAttribute atom in favor of Selenium call

The getAttribute atom has been maintained and updated in the selenium project, but stayed static in Watir for several years. The existing browser drivers have been using the selenium atom to return values for @element.attribute so technically Watir isn't returning the latest and greatest implementation for what attribute is. All specs pass with this implementation.
@p0deje - do you have any idea why it was implemented this way?
Also we're going to need to figure out how to support the w3c property vs attribute distinctions, but that will be later.

I have no idea why it was like that in the first place, but if specs are passing I'm happy to merge it.


Midea heat pump outside temperature issue when below zero

HA core version
No response
Intergration version
0.3.22
Device type and model
Heat Pump Wi-Fi Controller 171H120F
Used App
MSmartHome
The description of problem
The outdoor temperature is showing wrong number when its below zero outside.

The logs
No response

There is a work around, which works:
https://github.com/georgezhao2010/midea_ac_lan/issues/394#issuecomment-1837959454
Work around:
Open file homeassistant/custom_components/midea_ac_lan/midea/devices/c3/message.py and replace line:
self.outdoor_temperature = body[data_offset + 9]
With line:
self.outdoor_temperature = body[data_offset + 9] - 256 if body[data_offset + 9] > 127 else body[data_offset + 9]

thank you, it works, i feel stupid now for not searching the comments...


Hide prometheus datasource dropdown in grafana dashboard

Description of change
Checklist

[ ] Tested in playground or other setup
[ ] Screenshot (Grafana) from playground added to PR for 15+ minute run
[ ] Documentation is changed or added
[ ] Tests and/or benchmarks are included
[ ] Breaking changes

Summary by CodeRabbit

New Feature: Enhanced the Grafana dashboard configuration with a new option in the data source settings. Users can now choose to display no data on the dashboard using the var.datasource.generalOptions.showOnDashboard.withNothing() method. This feature provides more flexibility in controlling what is displayed on the dashboard.

tested, did not work


Made changes in HTML file of Random-quote-generator

Pull Request
Description
Made changes in JS folder HTML section
Changes Made
Made the page look more better using css styling.
Related Issues
No issues
Checklist

[x] I have tested these changes locally.
[x] I have added appropriate comments in the code, particularly in complex sections.
[x] I have updated the documentation if needed.
[x] My code follows the project's coding style guidelines.
[x] I have added/modified tests to cover the changes.

Screenshots (if applicable)

Additional Context

my email ID :-<EMAIL_ADDRESS>

thank for your contribute please check your email with a gift.


package-lock.json is behind package.json

This causes a diff as soon as npm install is run on a fresh checkout

merged


Test/test create partition mbr

2 things:

Add a test that that creates and verifies an MBR Table.
The interface to creating a MBR is a bit hokey, but it does work.
If a disko.Disk has a Table type of MBR, then CreatePartition
will create a partition table of MBR type.
Definitely this could use some work, as the filled-out ID and Name
are ignored, and the PartitionType gets converted, but it does
work.

Fix an error in Makefile resulting in 'bad substitution'
GNU make 4.3 changed behavior and using it you'd see:
  /bin/sh: 1: Bad substitution

I did some debug and filed a gnu make bug 62831 [1].
The solution that works in both cases and seems more robust is
to use a variable 'HASH'.
[1] https://savannah.gnu.org/bugs/index.php?62381

The first commit (HASH) was already merged separately.