Markdown and HTML conversion in CI

Add CI task to convert notebooks to Markdown and HTML. Notebooks are executed and then converted, so outputs are included. The CI task runs on every push to main of notebook files, and can also be run manually. To download the files (once this PR is merged), go to the Actions page, click on "Convert Notebooks", select the most recent run (the top one), and download the files. See https://github.com/helena-intel/openvino_notebooks/actions/runs/1001654885 for an example.

This is not meant for publishing but for testing. I modified the notebooks slightly to make execution much faster and reduce size of the files: the number of frames to inference in superresolution is reduced and the number of epochs in tensorflow training is set to 1.

These look great! Nice to see the outputs. I noticed the GIF in monodepth did not load, video of Pat in superres is less than 1 second and the warning/errors in background removal seem excessive. Any idea why these are showing up in background removal notebook?
inference will attempt to cast to float32
[ WARNING ]  Const node 'Resize_64/Add_input_port_1/value1035663192' returns shape values of 'float64' type but it must be integer or float32. During Elementwise type inference will attempt to cast to float32
[ WARNING ]  Const node 'Resize_86/Add_input_port_1/value1038863194' returns shape values of 'float64' type but it must be integer or float32. During Elementwise type inference will attempt to cast to float32
[ WARNING ]  Const node 'Resize_108/Add_input_port_1/value1042063196' returns shape values of 'float64' type but it must be integer or float32. During Elementwise type inference will attempt to cast to float32
[ WARNING ]  Const node 'Resize_130/Add_input_port_1/value1045263198' returns shape values of 'float64' type but it must be integer or float32. During Elementwise type inference will attempt to cast to float32
[ WARNING ]  Const node 'Resize_175/Add_input_port_1/value1048463200' returns shape values of 'float64' type but it must be integer or float32. During Elementwise type inference will attempt to cast to float32
[ WARNING ]  Const node 'Resize_197/Add_input_port_1/value1051663202' returns shape values of 'float64' type but it must be integer or float32. During Elementwise type inference will attempt to cast to float32
[ WARNING ]  Const node 'Resize_219/Add_input_port_1/value1054863204' returns shape values of 'float64' type but it must be integer or float32. During Elementwise type inference will attempt to cast to float32
[ WARNING ]  Const node 'Resize_241/Add_input_port_1/value1058063206' returns shape values of 'float64' type but it must be integer or float32. During Elementwise type inference will attempt to cast to float32
[ WARNING ]  Const node 'Resize_283/Add_input_port_1/value1061263208' returns shape values of 'float64' type but it must be integer or float32. During Elementwise type inference will attempt to cast to float32
[ WARNING ]  Const node 'Resize_305/Add_input_port_1/value1064463210' returns shape values of 'float64' type but it must be integer or float32. During Elementwise type inference will attempt to cast to float32
[ WARNING ]  Const node 'Resize_327/Add_input_port_1/value1067663212' returns shape values of 'float64' type but it must be integer or float32. During Elementwise type inference will attempt to cast to float32
[ WARNING ]  Const node 'Resize_366/Add_input_port_1/value1070863214' returns shape values of 'float64' type but it must be integer or float32. During Elementwise type inference will attempt to cast to float32
[ WARNING ]  Const node 'Resize_388/Add_input_port_1/value1074063216' returns shape values of 'float64' type but it must be integer or float32. During Elementwise type inference will attempt to cast to float32
[ WARNING ]  Const node 'Resize_453/Add_input_port_1/value1077263218' returns shape values of 'float64' type but it must be integer or float32. During Elementwise type inference will attempt to cast to float32
[ WARNING ]  Const node 'Resize_493/Add_input_port_1/value1080463220' returns shape values of 'float64' type but it must be integer or float32. During Elementwise type inference will attempt to cast to float32
[ WARNING ]  Const node 'Resize_528/Add_input_port_1/value1083663222' returns shape values of 'float64' type but it must be integer or float32. During Elementwise type inference will attempt to cast to float32
[ WARNING ]  Const node 'Resize_550/Add_input_port_1/value1086863224' returns shape values of 'float64' type but it must be integer or float32. During Elementwise type inference will attempt to cast to float32
[ WARNING ]  Const node 'Resize_573/Add_input_port_1/value1090063226' returns shape values of 'float64' type but it must be integer or float32. During Elementwise type inference will attempt to cast to float32
[ WARNING ]  Const node 'Resize_611/Add_input_port_1/value1093263228' returns shape values of 'float64' type but it must be integer or float32. During Elementwise type inference will attempt to cast to float32
[ WARNING ]  Const node 'Resize_633/Add_input_port_1/value1096463230' returns shape values of 'float64' type but it must be integer or float32. During Elementwise type inference will attempt to cast to float32
[ WARNING ]  Const node 'Resize_655/Add_input_port_1/value1099663232' returns shape values of 'float64' type but it must be integer or float32. During Elementwise type inference will attempt to cast to float32
[ WARNING ]  Const node 'Resize_678/Add_input_port_1/value1102863234' returns shape values of 'float64' type but it must be integer or float32. During Elementwise type inference will attempt to cast to float32
[ WARNING ]  Const node 'Resize_719/Add_input_port_1/value1106063236' returns shape values of 'float64' type but it must be integer or float32. During Elementwise type inference will attempt to cast to float32
[ WARNING ]  Const node 'Resize_741/Add_input_port_1/value1109263238' returns shape values of 'float64' type but it must be integer or float32. During Elementwise type inference will attempt to cast to float32
[ WARNING ]  Const node 'Resize_763/Add_input_port_1/value1112463240' returns shape values of 'float64' type but it must be integer or float32. During Elementwise type inference will attempt to cast to float32
[ WARNING ]  Const node 'Resize_785/Add_input_port_1/value1115663242' returns shape values of 'float64' type but it must be integer or float32. During Elementwise type inference will attempt to cast to float32
[ WARNING ]  Const node 'Resize_808/Add_input_port_1/value1118863244' returns shape values of 'float64' type but it must be integer or float32. During Elementwise type inference will attempt to cast to float32
[ WARNING ]  Const node 'Resize_852/Add_input_port_1/value1122063246' returns shape values of 'float64' type but it must be integer or float32. During Elementwise type inference will attempt to cast to float32
[ WARNING ]  Const node 'Resize_874/Add_input_port_1/value1125263248' returns shape values of 'float64' type but it must be integer or float32. During Elementwise type inference will attempt to cast to float32
[ WARNING ]  Const node 'Resize_896/Add_input_port_1/value1128463250' returns shape values of 'float64' type but it must be integer or float32. During Elementwise type inference will attempt to cast to float32
[ WARNING ]  Const node 'Resize_918/Add_input_port_1/value1131663252' returns shape values of 'float64' type but it must be integer or float32. During Elementwise type inference will attempt to cast to float32
[ WARNING ]  Const node 'Resize_940/Add_input_port_1/value1134863254' returns shape values of 'float64' type but it must be integer or float32. During Elementwise type inference will attempt to cast to float32
[ WARNING ]  Const node 'Resize_965/Add_input_port_1/value1138063256' returns shape values of 'float64' type but it must be integer or float32. During Elementwise type inference will attempt to cast to float32
[ WARNING ]  Const node 'Resize_985/Add_input_port_1/value1141263258' returns shape values of 'float64' type but it must be integer or float32. During Elementwise type inference will attempt to cast to float32
[ WARNING ]  Const node 'Resize_1005/Add_input_port_1/value1144463260' returns shape values of 'float64' type but it must be integer or float32. During Elementwise type inference will attempt to cast to float32
[ WARNING ]  Const node 'Resize_1025/Add_input_port_1/value1147663262' returns shape values of 'float64' type but it must be integer or float32. During Elementwise type inference will attempt to cast to float32
[ WARNING ]  Const node 'Resize_1045/Add_input_port_1/value1150863264' returns shape values of 'float64' type but it must be integer or float32. During Elementwise type inference will attempt to cast to float32
[ WARNING ]  Changing Const node 'Resize_42/Add_input_port_1/value1032464189' data type from float16 to <class 'numpy.float32'> for Elementwise operation
[ WARNING ]  Changing Const node 'Resize_64/Add_input_port_1/value1035664639' data type from float16 to <class 'numpy.float32'> for Elementwise operation
[ WARNING ]  Changing Const node 'Resize_86/Add_input_port_1/value1038863904' data type from float16 to <class 'numpy.float32'> for Elementwise operation
[ WARNING ]  Changing Const node 'Resize_108/Add_input_port_1/value1042065368' data type from float16 to <class 'numpy.float32'> for Elementwise operation
[ WARNING ]  Changing Const node 'Resize_130/Add_input_port_1/value1045265452' data type from float16 to <class 'numpy.float32'> for Elementwise operation
[ WARNING ]  Changing Const node 'Resize_175/Add_input_port_1/value1048465116' data type from float16 to <class 'numpy.float32'> for Elementwise operation
[ WARNING ]  Changing Const node 'Resize_197/Add_input_port_1/value1051664249' data type from float16 to <class 'numpy.float32'> for Elementwise operation
[ WARNING ]  Changing Const node 'Resize_219/Add_input_port_1/value1054863910' data type from float16 to <class 'numpy.float32'> for Elementwise operation
[ WARNING ]  Changing Const node 'Resize_241/Add_input_port_1/value1058065224' data type from float16 to <class 'numpy.float32'> for Elementwise operation
[ WARNING ]  Changing Const node 'Resize_283/Add_input_port_1/value1061264594' data type from float16 to <class 'numpy.float32'> for Elementwise operation
[ WARNING ]  Changing Const node 'Resize_305/Add_input_port_1/value1064465545' data type from float16 to <class 'numpy.float32'> for Elementwise operation
[ WARNING ]  Changing Const node 'Resize_327/Add_input_port_1/value1067664312' data type from float16 to <class 'numpy.float32'> for Elementwise operation
[ WARNING ]  Changing Const node 'Resize_366/Add_input_port_1/value1070866202' data type from float16 to <class 'numpy.float32'> for Elementwise operation
[ WARNING ]  Changing Const node 'Resize_388/Add_input_port_1/value1074064477' data type from float16 to <class 'numpy.float32'> for Elementwise operation
[ WARNING ]  Changing Const node 'Resize_453/Add_input_port_1/value1077264759' data type from float16 to <class 'numpy.float32'> for Elementwise operation
[ WARNING ]  Changing Const node 'Resize_493/Add_input_port_1/value1080465854' data type from float16 to <class 'numpy.float32'> for Elementwise operation
[ WARNING ]  Changing Const node 'Resize_528/Add_input_port_1/value1083664993' data type from float16 to <class 'numpy.float32'> for Elementwise operation
[ WARNING ]  Changing Const node 'Resize_550/Add_input_port_1/value1086865782' data type from float16 to <class 'numpy.float32'> for Elementwise operation
[ WARNING ]  Changing Const node 'Resize_573/Add_input_port_1/value1090066091' data type from float16 to <class 'numpy.float32'> for Elementwise operation
[ WARNING ]  Changing Const node 'Resize_611/Add_input_port_1/value1093264204' data type from float16 to <class 'numpy.float32'> for Elementwise operation
[ WARNING ]  Changing Const node 'Resize_633/Add_input_port_1/value1096464087' data type from float16 to <class 'numpy.float32'> for Elementwise operation
[ WARNING ]  Changing Const node 'Resize_655/Add_input_port_1/value1099664192' data type from float16 to <class 'numpy.float32'> for Elementwise operation
[ WARNING ]  Changing Const node 'Resize_678/Add_input_port_1/value1102865077' data type from float16 to <class 'numpy.float32'> for Elementwise operation
[ WARNING ]  Changing Const node 'Resize_719/Add_input_port_1/value1106065521' data type from float16 to <class 'numpy.float32'> for Elementwise operation
[ WARNING ]  Changing Const node 'Resize_741/Add_input_port_1/value1109265932' data type from float16 to <class 'numpy.float32'> for Elementwise operation
[ WARNING ]  Changing Const node 'Resize_763/Add_input_port_1/value1112465248' data type from float16 to <class 'numpy.float32'> for Elementwise operation
[ WARNING ]  Changing Const node 'Resize_785/Add_input_port_1/value1115666376' data type from float16 to <class 'numpy.float32'> for Elementwise operation
[ WARNING ]  Changing Const node 'Resize_808/Add_input_port_1/value1118865749' data type from float16 to <class 'numpy.float32'> for Elementwise operation
[ WARNING ]  Changing Const node 'Resize_852/Add_input_port_1/value1122066148' data type from float16 to <class 'numpy.float32'> for Elementwise operation
[ WARNING ]  Changing Const node 'Resize_874/Add_input_port_1/value1125266346' data type from float16 to <class 'numpy.float32'> for Elementwise operation
[ WARNING ]  Changing Const node 'Resize_896/Add_input_port_1/value1128466130' data type from float16 to <class 'numpy.float32'> for Elementwise operation
[ WARNING ]  Changing Const node 'Resize_918/Add_input_port_1/value1131665671' data type from float16 to <class 'numpy.float32'> for Elementwise operation
[ WARNING ]  Changing Const node 'Resize_940/Add_input_port_1/value1134864573' data type from float16 to <class 'numpy.float32'> for Elementwise operation
[ WARNING ]  Changing Const node 'Resize_1045/Add_input_port_1/value1150864564' data type from float16 to <class 'numpy.float32'> for Elementwise operation
[ WARNING ]  Changing Const node 'Resize_1025/Add_input_port_1/value1147664963' data type from float16 to <class 'numpy.float32'> for Elementwise operation
[ WARNING ]  Changing Const node 'Resize_1005/Add_input_port_1/value1144464147' data type from float16 to <class 'numpy.float32'> for Elementwise operation
[ WARNING ]  Changing Const node 'Resize_985/Add_input_port_1/value1141264351' data type from float16 to <class 'numpy.float32'> for Elementwise operation
[ WARNING ]  Changing Const node 'Resize_965/Add_input_port_1/value1138064054' data type from float16 to <class 'numpy.float32'> for Elementwise operation
[ SUCCESS ] Generated IR version 10 model.
[ SUCCESS ] XML file: /home/runner/work/openvino_notebooks/openvino_notebooks/notebooks/205-vision-background-removal/saved_models/u2net_lite/u2net_lite.xml
[ SUCCESS ] BIN file: /home/runner/work/openvino_notebooks/openvino_notebooks/notebooks/205-vision-background-removal/saved_models/u2net_lite/u2net_lite.bin
[ SUCCESS ] Total execution time: 73.45 seconds.
[ SUCCESS ] Memory consumed: 166 MB.

These look great! Nice to see the outputs. I noticed the GIF in monodepth did not load, video of Pat in superres is less than 1 second

The video in monodepth and the gif in superres-image load for me in Edge on Windows. I suppose it depends on browser/viewer support. The PaddleGAN notebook also doesn't show the output from the cells with ?? to show source/docstrings. Superres video being only a few frames is to speed up execution time and decrease file size (as in PR description).  If in the future we want to have full outputs for everything to make publication-ready HTML's we can make a separate CI job. We probably not want to embed the images/video inside the HTML then.

and the warning/errors in background removal seem excessive. Any idea why these are showing up in background removal notebook?

2021.4 shows more warnings than 2021.3 :-(  I wish this was an INFO level log, or that the warnings were condensed to a single line. I will add --log_level CRITICAL to the mo_command in that notebook in a separate PR. Not ideal, but better than showing all these warnings.


Access to readthedocs ?

I realized I don't have access to readthedocs, and I'm guessing we should give access to a few people from pypa in case something wrong happens.

I've given you access on RTD and on PyPI. I asked on the Discourse thread if any other existing PyPA members wanted commit rights - so far no-one has contacted me about it.

@pradyunsg and @gaborbernat were both interested in helping to maintain Flit, so I've added them on Github, RTD and PyPI.


Pagination data

Hello. Is it possible to show data using pagination queries?. I'ld appreciate an example. Thank you

There is no support for pagination, no, sorry!


fix(amplify-appsync-simulator): adds equals method to JavaString class

equals method is required for VTL functionality present in the console that is currently missing in
the simulator
Issue #4334, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@yuth @attilah Are we ready to merge?


"Systemic lupus erythematosus, susceptibility to"/C3862275 EFO mapping missing?

👋 I've noticed a couple of records (6) with association to Systemic lupus erythematosus, susceptibility to/C3862275 without mapping to EFO. Where would be the best place to fix/follow up on this? Thanks in advance.
Example of association RCV000018346.
And a related question: how is susceptibility to handled?

Hi @BaronKoy, I appreciate your help.

This term seems to have many subtype records: https://www.ebi.ac.uk/ols/search?q=Systemic+lupus+erythematosus%2C+susceptibility+to&groupField=iri&start=0
However, none matching the original term case. I can set this record to be added as a new EFO term with the associated evidence taken from literature and MedGen/OMIM?

I see, that's a bit problematic . I've also noticed that the already present SLE susceptibility terms in EFO are not under SLE (or Autoimmunity), but instead under disease susceptibility --> inherited disease susceptibility. Would it make more sense to have the susceptibility to the phenotype closer to the phenotype in the graph (I can create a separate issue to track that if needed)?

At the moment I do not believe we have a blanket method of sorting the susceptibility to terms out, but I will pass this onto my team for a solution.

Sounds great, would you like me to create a separate issue?


feat: change names of groups from Priority Field and change the sort of order groups same as task sorting order

Description

change the naming of groups for the Priority field
change the sort of order of grouping for all fields to sort by task sorting order instead of by group name alphabetical order

Motivation and Context
Fixes #1628 . Priority groups are now displayed without numbers: High, Medium, None, Low, but are sorted in the same order and not in alphabetical order (High, Low, Medium, None).
How has this been tested?

Screenshots (if appropriate)
Types of changes

Changes visible to users:

[ ] Bug fix (prefix: fix - non-breaking change which fixes an issue)
[x] New feature (prefix: feat - non-breaking change which adds functionality)
[ ] Breaking change (prefix: feat!! or fix!! - fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation (prefix: docs - improvements to any documentation content for users)
[ ] Sample vault (prefix: vault - improvements to the Tasks-Demo sample vault)
[ ] Contributing Guidelines (prefix: contrib - any improvements to documentation content for contributors - see Contributing to Tasks)

Internal changes:

[ ] Refactor (prefix: refactor - non-breaking change which only improves the design or structure of existing code, and making no changes to its external behaviour)
[ ] Tests (prefix: test - additions and improvements to unit tests and the smoke tests)
[ ] Infrastructure (prefix: chore - examples include GitHub Actions, issue templates)

Checklist

[x] My code follows the code style of this project and passes yarn run lint.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] My change has adequate Unit Test coverage.

Terms

[x] My contribution follow this project's contributing guide
[x] I agree to follow this project's Code of Conduct

How does this relate to PR #1943?
I mean, I think there will be conflicts whichever order this one and that one are merged.

From the PR description it's not obvious if this is talking about renaming the priorities themselves. Something more specific would be really useful.

How does this relate to PR #1943?
I mean, I think there will be conflicts whichever order this one and that one are merged.

If this one is going to go ahead, please do update the user docs, so that a complete PR can be reviewed. Many thanks.

How does this relate to PR #1943?
I mean, I think there will be conflicts whichever order this one and that one are merged.

On the paper it looks like some adjustment would be needed in PriorityField.ts. But I think that it is the tests that should have the final word here.

From the PR description it's not obvious if this is talking about renaming the priorities themselves. Something more specific would be really useful.

Indeed! Fixed.

If this one is going to go ahead, please do update the user docs, so that a complete PR can be reviewed. Many thanks.

Yup, after I changed the name of the PR, the update of the docs was self evident, thanks =)

Lmk if you wish to have a separate issue for the reversed urgency order =)

I think what this PR has shown is that:

When group by was first implemented, all the groups were sorted by name. The test requirements were therefore:

A very few tests to confirm that groups were sorted correctly by name - this could be done in (IIRC) Group.test.ts
One or two tests of the group names that were generated for each field.

Now that per-field sorting of groups is done, there is an obvious gap in the tests:

We need a test for each field to show the order in which the group names are sorted...

So I currently see these steps:
PR 1 On the current code, add an expressive test for every field, showing current headings order
It's important that we find a more expressive way to test the group headings order than the current very verbose group testing.
For this PR, this is the sort of thing I mean by expressive (typed from memory without an IDE)
expectGroupHeadingsToBe(
    new PriorityField().grouper(),
    shuffle(SampleTasks.withAllPriorities()),
    [
        'Priority 1: High',
        'Priority 2: Medium',
        'Priority 3: None',
        'Priority 4: Low',
    ]
    );

I am thinking that SampleTasks would have static methods that each return an array of Task objects with a representative set of all possible values for a given property.
Examples would be:

SampleTasks.withAllPriorities() would be straightforward
SampleTasks.withAllDueDateTypes() could return tasks with each of:

A valid date - today
A valid date - in the past
A valid date - in the future
An invalid date
No date
(Maybe SampleTasks.withRepresentativeDueDates() is a better name)

expectGroupHeadingsToBe() could be based on ideas in expectTaskComparesBefore()
The shuffle() call is a nice-to-have, to randomise the order of tasks, so that the tests do not pass by luck
PR 2 Implement the new group sorting mechanism
Do not change the names of any groups, but do use the new sorting approach that you are now using in the current PR...
The new tests will confirm whether I am correct - but I think you will find that only the urgency order will be changed - and it is an improvement.
If I am correct that only urgency changes, then this can actually be labeled as bug-fix, to group most urgent tasks first... and just update the urgency grouping docs.
PR 3 Rename the priority groups
Now the priority group names can be changed easily, and the docs updated, as a small PR.

Very clear, thanks a lot! I close this PR since we need to split it.

In my example test above I called grouper() but it maybe should have been createNormalGrouper() or something…

PR 1 On the current code, add an expressive test for every field, showing current headings order
It's important that we find a more expressive way to test the group headings order than the current very verbose group testing.

#1999

PR 2 Implement the new group sorting mechanism
Do not change the names of any groups, but do use the new sorting approach that you are now using in the current PR...

refactor: #2018

PR 3 Rename the priority groups
Now the priority group names can be changed easily, and the docs updated, as a small PR.

PR 1 On the current code, add an expressive test for every field, showing current headings order
It's important that we find a more expressive way to test the group headings order than the current very verbose group testing.

test: #1999

Yeah, sorry I rushed you to create that PR before tests were added for every field.

Yeah, sorry I rushed you to create that PR before tests were added for every field.

Also, the 'expressive' bit is still important 😄


Some '.js' file should use ‘.jsx’ to avoid Bundler Error

I used Vite to bundler swpier, but it failed, because the file in swiper used jsx in js file! 🙂

Some Source Code In This File.
https://github.com/nolimits4web/swiper/blob/0f1e5dd29e9ec2c83f7eefebcfc6ba6f32709eac/src/solid/swiper-slide.js#L71-L97

I fixed it used alias and Link File to redireact and rewrite the project file, but It doesn't a good way to share with my partners. 😀

I make a demo in stackblitz. Because codesandbox hasn't reappear this problom.
https://stackblitz.com/edit/vitest-dev-vitest-fi8wj7?file=package.json

Facing this issue in newly created solid js app with vite and installed swiperjs on it and run the example in docs.. cant run pnpm dev.. same like screenshot above about JSX not enabled in vite i think

@linkb15
I rebundle the package (solid-js version) and put it in npm. It has the same method. So I didn't write readme.
https://www.npmjs.com/package/@cn-ui/swiper

I am having the same issue with Solidjs and the Swiper/Solid demo. Here is a vanilla Solidjs repo with Swiper demonstrating the problem: https://github.com/skreutzberger/solidjs-swiper-issue-demo

why was it closed? was there a PR which fixed it?


fix: long running setup for expired auth token track 2 bug

Fixes #
Description
The track 2 sdk has a bug for long living tokens(longer than 24hrs) they will not be refreshed properly. This pr adds a thin wrapper around the GetToken() interface method to set the ExpiresOn timestamp to be earlier and force a token refresh earlier.
How was this change tested?

2 long running clusters both on NAP and Self Hosted ran without seeing expired token errors
make presubmit

Does this change impact docs?

[ ] Yes, PR includes docs updates
[ ] Yes, issue opened: #
[ ] No

Release Note

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 16 (0.0%)  changed or added relevant lines in 2 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.04%) to 97.73%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/providers/instance/azure_client.go
0
3
0.0%

pkg/auth/cred.go
0
13
0.0%

Files with Coverage Reduction
New Missed Lines
%

pkg/auth/cred.go
1
44.44%

Totals

Change from base Build<PHONE_NUMBER>:
-0.04%

Covered Lines:
36286

Relevant Lines:
37129

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 16 (0.0%)  changed or added relevant lines in 2 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.04%) to 97.73%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/providers/instance/azure_client.go
0
3
0.0%

pkg/auth/cred.go
0
13
0.0%

Files with Coverage Reduction
New Missed Lines
%

pkg/auth/cred.go
1
44.44%

Totals

Change from base Build<PHONE_NUMBER>:
-0.04%

Covered Lines:
36286

Relevant Lines:
37129

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 14 (0.0%)  changed or added relevant lines in 2 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.04%) to 97.73%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/providers/instance/azure_client.go
0
1
0.0%

pkg/auth/cred.go
0
13
0.0%

Files with Coverage Reduction
New Missed Lines
%

pkg/auth/cred.go
1
44.44%

Totals

Change from base Build<PHONE_NUMBER>:
-0.04%

Covered Lines:
36286

Relevant Lines:
37129

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 14 (0.0%)  changed or added relevant lines in 2 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.04%) to 97.73%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/providers/instance/azure_client.go
0
1
0.0%

pkg/auth/cred.go
0
13
0.0%

Files with Coverage Reduction
New Missed Lines
%

pkg/auth/cred.go
1
44.44%

Totals

Change from base Build<PHONE_NUMBER>:
-0.04%

Covered Lines:
36286

Relevant Lines:
37129

💛  - Coveralls

@andyzhangx yes it seems to be working for over a week for me

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 14 (0.0%)  changed or added relevant lines in 2 files are covered.
7 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.04%) to 97.727%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/providers/instance/azure_client.go
0
1
0.0%

pkg/auth/cred.go
0
13
0.0%

Files with Coverage Reduction
New Missed Lines
%

pkg/auth/cred.go
1
44.44%

pkg/providers/instancetype/instancetypes.go
6
88.3%

Totals

Change from base Build<PHONE_NUMBER>:
-0.04%

Covered Lines:
36287

Relevant Lines:
37131

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 14 (0.0%)  changed or added relevant lines in 2 files are covered.
7 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.04%) to 97.727%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/providers/instance/azure_client.go
0
1
0.0%

pkg/auth/cred.go
0
13
0.0%

Files with Coverage Reduction
New Missed Lines
%

pkg/auth/cred.go
1
44.44%

pkg/providers/instancetype/instancetypes.go
6
88.3%

Totals

Change from base Build<PHONE_NUMBER>:
-0.04%

Covered Lines:
36287

Relevant Lines:
37131

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 20 (0.0%)  changed or added relevant lines in 2 files are covered.
7 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.06%) to 97.711%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/providers/instance/azure_client.go
0
1
0.0%

pkg/auth/cred.go
0
19
0.0%

Files with Coverage Reduction
New Missed Lines
%

pkg/auth/cred.go
1
38.1%

pkg/providers/instancetype/instancetypes.go
6
88.3%

Totals

Change from base Build<PHONE_NUMBER>:
-0.06%

Covered Lines:
36287

Relevant Lines:
37137

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 22 (0.0%)  changed or added relevant lines in 2 files are covered.
7 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.06%) to 97.706%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/providers/instance/azure_client.go
0
1
0.0%

pkg/auth/cred.go
0
21
0.0%

Files with Coverage Reduction
New Missed Lines
%

pkg/auth/cred.go
1
36.36%

pkg/providers/instancetype/instancetypes.go
6
88.3%

Totals

Change from base Build<PHONE_NUMBER>:
-0.06%

Covered Lines:
36287

Relevant Lines:
37139

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 22 (0.0%)  changed or added relevant lines in 2 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.06%) to 97.706%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/providers/instance/azure_client.go
0
1
0.0%

pkg/auth/cred.go
0
21
0.0%

Files with Coverage Reduction
New Missed Lines
%

pkg/auth/cred.go
1
36.36%

Totals

Change from base Build<PHONE_NUMBER>:
-0.06%

Covered Lines:
36287

Relevant Lines:
37139

💛  - Coveralls


[README] spaceauth - adopt to monogem changes

as discussed here: https://github.com/fastlane/fastlane/issues/7562

@KrauseFx ohhh sorry i missed that - updated

👍


Allow disabling the default Security Group

what

This PR adds a new variable, security_group_enabled (default: true), that lets you disable the creation of aws_security_group.ecs_service

why

Currently there is no way to disable the creation of aws_security_group.ecs_service, even if you disable its security group rules through var.enable_all_egress_rule, var.enable_icmp_rule, var.use_alb_security_group, and var.use_nlb_cidr_blocks.
In my case, I wanted to use my own security group by specifying its id in var.security_group_ids. Not being able to disable the creation of aws_security_group.ecs_service led to clutter in the list of security groups in AWS console and potential confusion as to which ones were actually used
It would also be an option to not create aws_security_group.ecs_service when no security group rules would be created, but I thought it better to have an explicit variable for controlling it

/test all

Adding @nitrocode for an additional set of eyes regarding the SG descriptions.

/test all

/test readme

@ento we might need you to rebuild the readme... Can you run make init && make readme, commit the result, and then push it here? Seems that our automation for auto formatting is failing.

/test all

Thanks for merging! The setup for make init and make readme was cool (Makefile and include and Docker and all)


Improve unit test coverage

Describe the bug

To ensure quality code and features being delivered, code coverage is one of the most important metrics we rely on. With good coverage for regression testing, there is also much less risk of breaking existing functionality when adding or changing features.
Currently Antrea’s entire coverage is 66.02%, with 49.12% e2e test coverage, 44.70% unit test coverage, 35.00% integration test coverage. Even though unit test is the easiest and the most cost efficient one, its coverage is only 44.70%, less than e2e test, which means there is a lot of room for improvement.
This issue tracks packages that should be well unit tested but were not. If you are familiar with or interested in understanding a package's implementation, feel free to pick up the package by adding your name after the package name to indicate you will work on it or comment the issue if you cannot edit it, write unit tests for it and submit your code.

[ ] pkg/agent/apiserver/handlers
[x] pkg/agent/flowexporter (@heanlan #4182 )
[x] pkg/agent/interfacestore
[ ] pkg/agent/ipassigner (@rajnkamr )
[ ] pkg/agent/nodeportlocal

[port_table_windows.go] (@jainpulkit22 #4284)

[x] pkg/agent/proxy (@hongliangl #4355 )
[x] pkg/agent/route (@tnqn #4295)
[x] pkg/agent/secondarynetwork (@antoninbas #4146 #4180 - unit test coverage is 67% as of 09/02/2022, cannot go higher because IPAM delegator cannot be unit tested)
[ ] pkg/agent/util
[ ] pkg/agent/controller/traceflow

(@Atish-iaf  #4409 )
(@Atish-iaf #4587 )

[x] pkg/agent/util/net*.go [@qiyueyao #4312 ]
[ ] pkg/antctl/output
[ ] pkg/antctl/raw

[multi-cluster](@luolanzone #4183 )
[featuregates](@luolanzone #4256 )
[traceflow](@Atish-iaf #4302 )
[set](@jainpulkit22 #4307)
[proxy]( @KMAnju-2021 #4891 )

[ ] pkg/antctl/*.go (@NamanAg30 )
[ ] pkg/antctl/transform (@jainpulkit22)
[x]  pkg/apiserver/certificate (@luolanzone #4204 )
[ ] pkg/apiserver/handlers/webhook (@hjiajing #4864)
[x] pkg/apiserver/registry (@tnqn #4304)
[x] pkg/controller/egress/store (@wenqiq #4151)
[ ] pkg/controller/externalnode (@wenyingd #4259)
[x] pkg/flowaggregator/apiserver/handlers (@yanjunz97 #4179)
[x] pkg/graphviz (@luolanzone #4263 )
[x] pkg/ovs

[openflow] (@hongliangl #4221)

[ ] pkg/features (@NamanAg30 )
[x] pkg/version (@urharshitha )
[ ] pkg/support (@KMAnju-2021 )
[x] pkg/ipfix  (@NamanAg30 )
[x] pkg/monitor (@NamanAg30 )
[ ] cmd (@wenqiq)
[x] pkg/antctl/command_defintion.go(@NamanAg30 )
[x] pkg/antctl/client.go(@NamanAg30 )
[x] pkg/antctl/command_list.go(@NamanAg30 )
[x] pkg/antcl/raw/supportbundle(@NamanAg30 ) https://github.com/antrea-io/antrea/pull/4615
[x] pkg/flowaggregator/exporter/ipfix.go(@NamanAg30 ) https://github.com/antrea-io/antrea/pull/4770
[x] pkg/flowaggregator/flowaggregator.go(@Atish-iaf ) https://github.com/antrea-io/antrea/pull/4556
[x] pkg/agent/agent.go(@Atish-iaf ) https://github.com/antrea-io/antrea/pull/4703
[ ] pkg/agent/route_linux.go(@NamanAg30 )

Expected

Unit test coverage greater than 70%
Actual behavior

Unit test coverage less than 70%

@tnqn do you have the link with code coverage info per package?

Hi @tnqn  I was trying to take the  pkg/apiserver/certificate packages and add unit test, but after checking the codecov data, I feel the coverage is good enough with e2e/integration test data, it might be unnecessary to add more cases for this packages, could you help to check and let me know your opinion? thanks
https://app.codecov.io/gh/antrea-io/antrea/tree/main/pkg/apiserver/certificate

Hi @tnqn I was trying to take the  pkg/apiserver/certificate packages and add unit test, but after checking the codecov data, I feel the coverage is good enough with e2e/integration test data, it might be unnecessary to add more cases for this packages, could you help to check and let me know your opinion? thanks
https://app.codecov.io/gh/antrea-io/antrea/tree/main/pkg/apiserver/certificate
Personally I would suggest to check the overall data coverage and make sure we add the test for those lines which are not covered by any kinds of tests.

I made the list based on the unit test coverage report. It was 30% for this package as there is no unit test for cacert_controller.go. And I understand why its overall coverage looks fine: as long as the program runs end to end, many code in cacert_controller.go will run at least once regardless of whether the e2e test is intended to test it. But running the code once doesn't mean it's well tested, for example, if CACertController.syncConfigMap is well tested,the following situations should be covered:

If the ConfigMap doesn't exist, it will call the Create API
If the ConfigMap exists and the cert matches, it will not call the Update API
If the ConfigMap exists and the cert doesn't match, it will call the Update API
If it fails to check ConfigMap's existence, it will return the error

I think the purpose of improving test coverage is not to make the code to be executed once by any kind of test, but to ensure the code is executed as expected in various situation.

Add unit test for cmd/antrea-agent/util.go #4349

@luolanzone Can I work on improving the code coverage of the cmd package?

Hi @VaibhavMalik4187 , sorry for a quite late response, you can work on coverage improvement if you are still interested in contribution. You can check this link https://app.codecov.io/gh/antrea-io/antrea/tree/codecov-ut-only to check overall Antrea coverage and take any package which coverage is low. Thanks a lot!


Recommendations for non-primary node types

Added recommendations for non-primary node types. Please review and change as needed.

Hi @paolosalvatori, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Paolo Salvatori). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

@paolosalvatori : Thanks for your contribution to the Azure documentation! The author, @ChackDan, has been notified to review your proposed change.

#please-close


Check if domain is available, not available or in redemption period

I am trying to write a function that checks whether a domain is available to register, not available to register or in the redemption period, and is as accurate as possible. Here is my code:
import whois
import requests

  def is_redirect(input_domain):
      try:
          response = requests.head("http://" + input_domain, timeout=10)

          if response.status_code in [301, 302]:
              return True
          else:
              return False
      except Exception as e:
          print(f"Error checking domain {input_domain}: {e}")
          return False

  def is_domain_expired(input_domain):
      if is_redirect(input_domain):
          return "Domain is a redirect and not available to register."
      try:
          domain = whois.whois(input_domain)

          if "redemptionPeriod" in domain.status:
              print(f"{input_domain} is in redemption period.")
          elif domain.status is None:
              print(f"{input_domain} is available for registration.")
          else:
              print(f"{input_domain} is not available for registration.")
      except whois.parser.PywhoisError as e:
          if "No match for" in str(e):
              print(f"{input_domain} is available for registration.")
          else:
              print(f"Error checking domain {input_domain}: {str(e)}")
      except Exception as e:
          print(f"Error: {str(e)}")

  while True:
      domain = input("domain to check: ")
      is_domain_expired(domain)

I entered a domain which I know is in the redemption period, but it prints that the domain is available for registration. How do I code this properly?

Will have a look. What domain did you try this with ?
On Sat, May 6, 2023, 12:32 Willmizzle @.***> wrote:

I am trying to write a function that checks whether a domain is available
to register, not available to register or in the redemption period, and is
as accurate as possible. Here is my code:
`import whois
import requests
def is_redirect(input_domain):
try:
response = requests.head("http://" + input_domain, timeout=10)
if response.status_code in [301, 302]:
    return True
else:
    return False

except Exception as e:
print(f"Error checking domain {input_domain}: {e}")
return False
def is_domain_expired(input_domain):
if is_redirect(input_domain):
return "Domain is a redirect and not available to register."
try:
domain = whois.whois(input_domain)
if "redemptionPeriod" in domain.status:
    print(f"{input_domain} is in redemption period.")
elif domain.status is None:
    print(f"{input_domain} is available for registration.")
else:
    print(f"{input_domain} is not available for registration.")

except whois.parser.PywhoisError as e:
if "No match for" in str(e):
print(f"{input_domain} is available for registration.")
else:
print(f"Error checking domain {input_domain}: {str(e)}")
except Exception as e:
print(f"Error: {str(e)}")
while True:
domain = input("domain to check: ")
is_domain_expired(domain)`
I entered a domain which I know is in the redemption period, but it prints
that the domain is available for registration. How do I code this properly?
—
Reply to this email directly, view it on GitHub
https://github.com/DannyCork/python-whois/issues/313, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACU73CUEKFEQPFDNOIZIAMDXEYSFDANCNFSM6AAAAAAXYAYPOA
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Note that you are currently usung whois.whois()
This library uses whois.query()
https://github.com/richardpenman/whois is the repositiry for that whois
library on github.
On Sat, May 6, 2023, 12:32 Willmizzle @.***> wrote:

I am trying to write a function that checks whether a domain is available
to register, not available to register or in the redemption period, and is
as accurate as possible. Here is my code:
`import whois
import requests
def is_redirect(input_domain):
try:
response = requests.head("http://" + input_domain, timeout=10)
if response.status_code in [301, 302]:
    return True
else:
    return False

except Exception as e:
print(f"Error checking domain {input_domain}: {e}")
return False
def is_domain_expired(input_domain):
if is_redirect(input_domain):
return "Domain is a redirect and not available to register."
try:
domain = whois.whois(input_domain)
if "redemptionPeriod" in domain.status:
    print(f"{input_domain} is in redemption period.")
elif domain.status is None:
    print(f"{input_domain} is available for registration.")
else:
    print(f"{input_domain} is not available for registration.")

except whois.parser.PywhoisError as e:
if "No match for" in str(e):
print(f"{input_domain} is available for registration.")
else:
print(f"Error checking domain {input_domain}: {str(e)}")
except Exception as e:
print(f"Error: {str(e)}")
while True:
domain = input("domain to check: ")
is_domain_expired(domain)`
I entered a domain which I know is in the redemption period, but it prints
that the domain is available for registration. How do I code this properly?
—
Reply to this email directly, view it on GitHub
https://github.com/DannyCork/python-whois/issues/313, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACU73CUEKFEQPFDNOIZIAMDXEYSFDANCNFSM6AAAAAAXYAYPOA
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Will have a look. What domain did you try this with ?

tujobs.com

Note that you are currently usung whois.whois() This library uses whois.query() https://github.com/richardpenman/whois is the repositiry for that whois library on github.

Wait... am I to understand that for the python-whois repository, you would install it with pip install whois, and for the whois repository, you install it with pip install python-whois?

By the way,  print(domain.dict) as seen in the documentation gives me: AttributeError: 'str' object has no attribute 'dict'. Did you mean: 'dir'?

Yes exactly that.
the name confusion is a great source of issues.
That is why i started whoisdomain as can be seen in the readme.
On Sat, May 6, 2023, 15:18 Willmizzle @.***> wrote:

Note that you are currently usung whois.whois() This library uses
whois.query() https://github.com/richardpenman/whois is the repositiry
for that whois library on github.
Wait... am I to understand that for the python-whois repository, you would
install it with pip install whois, and for the whois repository, you
install it with pip install python-whois?
—
Reply to this email directly, view it on GitHub
https://github.com/DannyCork/python-whois/issues/313#issuecomment-1537140959,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACU73CVGGEEKSO2KCXGG2K3XEZFTRANCNFSM6AAAAAAXYAYPOA
.
You are receiving this because you commented.Message ID:
@.***>

Yes that is due to being on the wrong repo for instructions on your version
of whois for python
we use whois.query where geting the results as a dict are supported.
On Sat, May 6, 2023, 15:28 Willmizzle @.***> wrote:

By the way, print(domain.dict) as seen in the documentation gives me:
AttributeError: 'str' object has no attribute 'dict'. Did you mean: '
dir'?
—
Reply to this email directly, view it on GitHub
https://github.com/DannyCork/python-whois/issues/313#issuecomment-1537142653,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACU73CUZA7ZBH3RQU3SMKZTXEZGXDANCNFSM6AAAAAAXYAYPOA
.
You are receiving this because you commented.Message ID:
@.***>

When in doubt always compare with the raw output of the cli whois command,
in the case of your domajn i get no useful info after some redirects, ymmv
as i am on fedora37.
On Sat, May 6, 2023, 15:09 Willmizzle @.***> wrote:

Will have a look. What domain did you try this with ?
tujobs.com
—
Reply to this email directly, view it on GitHub
https://github.com/DannyCork/python-whois/issues/313#issuecomment-1537139054,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACU73CWMOVVWUTC3EG7ET7LXEZEPVANCNFSM6AAAAAAXYAYPOA
.
You are receiving this because you commented.Message ID:
@.***>

i expect we can close this issue ?


Missing Github Login Button on Login Page in Firefox

I've encountered a bug while trying to login to the admin panel via github using firefox. The login button is missing, and the page just says "signing in...". Everything works as intended when switching to a chromium based browsers.

I’ve tested with a couple of instances but haven’t been able to reproduce the issue. Do you see any error in the browser’s console?

Yes, its a BridgeTimeout error - throw.ts line 4

That’s weird, it’s not an error of Sveltia CMS. There is no TypeScript code here. A quick search for BridgeTimeout finds an IBM application. Or perhaps do you use any browser extension?

https://github.com/ProtonMail/WebClients/blob/main/applications/pass-extension/src/app/content/bridge/message.ts#L53
https://github.com/ProtonMail/WebClients/blob/main/packages/pass/utils/fp/throw.ts
Do you use the Proton Pass extension?

Yes, but it seems that the problem wasn't Proton. I deleted all the cache, and now it seems to be working. That was shortsighted on my part.

Still not sure how that situation could have happened, but glad the problem has been solved!


File archived with the password, cannot be extracted with the windows explorer. Works fine with 7zip tool

When we to Extract a password encrypted zip file using Windows Explorer it gives below error.
0x80004005: Unspecified error during unzipping
Please note that, the same zip file gets extracted properly with other zip tools like 7zip, pkunzip, etc
Here is the code snippet
zipParameters.setEncryptFiles(true);
zipParameters.setEncryptionMethod(EncryptionMethod.AES);
zipFile.setPassword(password.toCharArray());
According to the below link, Windows doesnot support AES_256 encrypted password.
https://www.winhelponline.com/blog/zip-error-0x80004005-extract-copy-unspecified-error/
In that case, should I set it to AES_128 (e.g., zipParameters.setAesKeyStrength(AesKeyStrength.KEY_STRENGTH_128);
Ig will be helpful if there is anything I can do here so that it can be extracted from windows explorer as well.
Thank you.
Regards

Bhagyashree

Windows does not support AES irrespective of key length. If you need to support encrypted zip file with Windows explorer, you can consider using Zip Standard Encryption.

Thank you so much Srikanth for your quick support


[Feature]: Add framework badge for .NET nanoFramework

Related Problem
The new look of NuGet gallery added badges for the various frameworks in the packages listing, which is great.
Just that it's missing the badge for .NET nanoFramework... 😉 Currently it's defaulting to .NET Framework.

The Elevator Pitch
.NET nanoFramework has been assigned a TFM some time ago. Support for it has been added to nuget CLI. So it seems kind of logical that there is a label for it.
Additional Context and Details
TFM: dotnet/designs#208
nuget CLI: NuGet/NuGet.Client#3943 and NuGet/NuGet.Client#4401

We only support the three major generations as a top-level badge(.NET Framework, .NET Core, .NET). In the future, we will consider adding platforms and more TFMs.
If the asset is under a netnano folder, it should appear in the Frameworks tab. But it will not appear at the top due to what I mentioned above. Double check the contents of the package as we check for assets under specific folders.

Hey @JonDouglas !
Understood. Please add this to the suggestion box as it would be helpful for .NET nanoFramework developers to be able to identify and/or filter NuGet packages that are OK to use in their projects.


add(context): korean translation for request and response

update original english text to korean translation
request / response p.171

prettier breaks with unrelated file 70-89/70-89.md

prettier breaks with unrelated file 70-89/70-89.md

@kkweon @aeuveritas pls review #103 first.
@nicewook sorry for delay, I have been a long vacation (until tmr). feel free to review & comment 🙏

@kkweon @aeuveritas pls review #103 first.
@nicewook sorry for delay, I have been a long vacation (until tmr). feel free to review & comment 🙏


Update: Obelisk protection

Fixed "Protection Active" text appearing outside POH
Added isInPOH() check to verify POH obelisk presence
updated how the overlay is being displayed. now shows it only while the obelisk is being moused over
fixed how stackable items were being handled for wealth calculation and potentially losing them in the wilderness

You don't need to ping individual mergers as soon as you open the plugin

Couldn't you use region IDs to check POH status rather than tile iteration? https://github.com/runelite/runelite/blob/890acd684cabfce17bbbe0a648662906050855e6/runelite-client/src/main/java/net/runelite/client/plugins/roofremoval/RoofRemovalConfigOverride.java#L35

Couldn't you use region IDs to check POH status rather than tile iteration? https://github.com/runelite/runelite/blob/890acd684cabfce17bbbe0a648662906050855e6/runelite-client/src/main/java/net/runelite/client/plugins/roofremoval/RoofRemovalConfigOverride.java#L35

That's the first thing I tried but for some reason, I wasn't able to make it work properly. This approach does work though

That's the first thing I tried but for some reason, I wasn't able to make it work properly

did you remember to use isInInstancedRegion/fromLocalInstance?

That's the first thing I tried but for some reason, I wasn't able to make it work properly

did you remember to use isInInstancedRegion/fromLocalInstance?

Changed it to this approach and got it working. Thanks

The version that's live right now is fairly buggy. I would really appreciate someone taking a look at this pr that fixes all these critical bugs

You should be using GameObjectSpawned/Despawned events instead of iterating every tile in the scene on every menu entry added

They're referring to the findObelisk call in onMenuEntryAdded (that still exists)


Update Copyright: 2019 -> 2020

Small update to change copyright year to be the current year.

Closing as it's 2021 now


Remove usages of deprecated Buffer()

(node:5321) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.

The above deprecation error is logged from new version of Node when using this package.

I have the same problem 😒


[Bot Framework V4] [Directline] [Bot Channel] There was an error sending this message to your bot: HTTP status code GatewayTimeout

GitHub issues should be
Facing the below issue intermittently:
[Bot Framework V4] [Directline] [Bot Channel] There was an error sending this message to your bot: HTTP status code GatewayTimeout
Screenshots

Version

Using CDN (Webchat Latest)
Version 4.4.4

Describe the bug

To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior

Additional context

[Bug]

@vikramdadwal, please fill out the rest of the information of the template. Feel free to leave another comment when you're done and I'll be happy to reopen this issue.


[feature] reimplement Snapshot manifest cache

Closes #595, Reverts #787, Closes #1162
Implement manifest list cache as Snapshot instance-specific cache, not global cache

Closing in favor of #1187


Fix/manual assignment

This PR changes the way to setup the submission assignment, now the PCs can select if they want to run the automatic paper matching or make manual assignments:

If automatic assignment is selected then the timeline would show a link to the assignment page, if manual is selected then a link to the edge browser is shown to the PCs can start creating assignment edges.
Please note the now the "Assignment" invitation is created when the assignments are deployed or when the paper matching setup is ran and manual assignment is selected. This way the UI can know when the manual assignments are enabled.
Venues with manual or automatic assignment can both run the paper matching setup. The can optionally  compute scores and conflicts. This PR introduces the selection of the conflicts policy and the amount of years to check the profile data.

Expertise selection invitation is always created so we won't have the error "Invitation Not Found" anymore.
The PC console temporally shows the edge browser urls in the headers until Xukun can render them in the timeline.

this PR is ready to review!

Thanks! this is ready to merge :)


Clean Scaling with Dask

The PR focuses on fixing headings and proofreading of the Scaling with Dask notebook.

@tinaok the Data section of the notebook is still incomplete.

In this episode, we will be using xxx

@tinaok I've completed my revision of the notebooks and fix some grammar/typos. I also found some minor bugs. Note the last cell return an error.

cluster.shutdown()

AttributeError                            Traceback (most recent call last)
Cell In[31], line 1
----> 1 cluster.shutdown()
AttributeError: 'NoneType' object has no attribute 'shutdown'

@tinaok I've completed my revision of the notebooks and fix some grammar/typos. I also found some minor bugs. Note the last cell return an error.

cluster.shutdown()

---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
Cell In[31], line 1
----> 1 cluster.shutdown()

AttributeError: 'NoneType' object has no attribute 'shutdown'

I'll have a look after merging this.  Probably it is due to which machine we use? (cluster with gateway or machine only with local cluster)


Add SSDF text test and snapshot

Test that was missing that should be important for #153

Just an added test. Need to expedite since I'm heading on vacation.


integrate the new datastore with the epaipm etl

NEEDS page scraper results aren't right. We need these:

transmission_single_epaipm: https://www.epa.gov/sites/production/files/2019-03/table_3-21_annual_transmission_capabilities_of_u.s.model_regions_in_epa_platform_v6-_2021.xlsx
load_curves_epaipm: https://www.epa.gov/sites/production/files/2019-03/table_2-2_load_duration_curves_used_in_epa_platform_v6.xlsx
plant_region_map_epaipm: https://www.epa.gov/sites/production/files/2019-03/needs_v6_november_2018_reference_case_0.xlsx


enable g2g and more

@PanicSheep I think this was included in another PR no  ? Did we got all the preprocessor macros ?

@lxavier No. No.

@huppd Is this still relevant? If no, please close it. ty

@huppd Is this still relevant? If no, please close it. ty

If the macros are now included, I am happily close it.


CDN'ed

Replace local stylesheet and script files with CDN ones so those, who wants to use the original Bootstrap styles (without any modification) they could use it without any download/bower "magic".

I prefer not having the maintenance overhead of updating these links each time there is a new release of bootstrap / jQuery.

Yeah I think if people would like to use them, they can have their own template here.
Usually you use bower and manage the versions yourself in your repo.

My main purpose was to make it more automated so people who don't want to use bower (not me!) could kick in a project a little faster. But @ADmad opinion seems fair to me, so I close this PR and will try to make a composer install script instead.


Bug: TIP3P constraints in Sage are not processed

This appears to happen for water but not typical hydrogen-containing bonds (whether the other atom is oxygen or not)
from openff.units import unit
from openff.toolkit.topology.molecule import Molecule
from openff.toolkit.typing.engines.smirnoff.forcefield import ForceField

force_field = ForceField("openff-2.0.0.offxml")

topology = Molecule.from_smiles("CO").to_topology()
topology.box_vectors = [4, 4, 4] * unit.nanometer
print(force_field.create_openmm_system(topology, use_interchange=False).getNumConstraints())
print(force_field.create_openmm_system(topology, use_interchange=True).getNumConstraints())

topology = Molecule.from_smiles("O").to_topology()
topology.box_vectors = [4, 4, 4] * unit.nanometer
print(force_field.create_openmm_system(topology, use_interchange=False).getNumConstraints())
print(force_field.create_openmm_system(topology, use_interchange=True).getNumConstraints())

Out:
4
4
3
0

FTR the problem was that all constraints with specified distances were not being processed correctly. This went undetected for a long period of time because this is not a common use case in the OpenFF ecosystem - usually they just fall back to the distance specified by the bond parameter.


BUG: samsung Tab UI: search bar is not appearing  at the bottom of the menu

Steps

open URL : https://297-move-search-box-at-the-top--cn-website--netcentric.hlx.page/
tap on menu bar

Actual result:  search bar is appearing at the bottom
Expected result: search bar should appear at the top
Device: S8/chrome

Verified as still a valid bug.

Correction, search bar is there, just need to scroll down.
@chriscorr1 , I think maybe this can be to move search bar up a little on tablets, or we close as not an issue. Looking at the screenshot in the first comment it actually displays the search box, at least a slither of it. Best would be to move it up a bit so it's more obvious that there is a search box.


Sync keeps going for folders with dots in the end

Describe the bug
Similar to #88 but this time it keeps downloading instead of an error. This is because the folder created omits the dot at the back so it keeps assuming the files aren't there yet.
Logfile snapshot
[2022-09-21 11:37:38] DEBUG - downloading - EC1101E/Exam Instructions etc./EC1101E Midterm Exam Instructions.pdf [0001-01-01 00:00:00 +0000 UTC vs 2022-09-16 18:06:01.36 +0800 +08] (D:/jiawei/projects/lominus/internal/cron/cron.go:github.com/beebeeoii/lominus/internal/cron.createJob.func1:224)
[2022-09-21 11:37:38] INFO - job completed: 2022-09-21T11:37:38+08:00 (D:/jiawei/projects/lominus/internal/cron/cron.go:github.com/beebeeoii/lominus/internal/cron.createJob.func1:275)

OS
Windows 10

This seems to be a Windows-only issue so far. Not sure for Mac, but I think this doesn't happen on Linux because it doesn't auto-truncate directories ending with dots. The ad-hoc solution is to use bash to force-create the directory with mkdir.

issue should be resolved by 0a74143b1294463124a9301952f3f8f8dda55056

issue should be resolved by 0a74143b1294463124a9301952f3f8f8dda55056

Great! Let me test with a sandbox course on Canvas later

resolved with #96


would it be possible to implement cubic chunks 1.12 to 1.17+ Anvil conversion?

We run a server and need to update to 1.18. Our current server runs on cubic chunks 1.12.2, and trying conversion to Anvil results in places being cut off at y=0
Is there a way for 1.17+ (where the minimum y level is -64) conversion to be possible?

There is an unofficial convertor available: https://github.com/BTEUK/CC-1.18.2-Converter

The main issue there is columns that would be incomplete after conversion, otherwise it is possible to do this


[Feature]: In Tables UI, add option to make column names wrap around

Description
Hello, the column names in the Tables UI are automatically cut off. When manually resizing them (which also takes a lot of time), a lot of whitespace is needed to see the entire column, if the name is a bit longer.

Suggested Solution
It would be amazing if we could have the option to wrap around the column names (or alternatively automatically adjust the width to the name).
Thank you!
Alternatives
No response
Additional Context
No response

Hi @nikita6187, thanks for writing in and suggesting this! I'll create a new feature request and share it with our Product Team!


Feature/ws init func (rebased on master)

This is a rebased version of #275

@spetrunin can you give this PR a review? I think it looks fine.

🎉 Thanks!


Build initial Dashboard

Build the initial Dashboard the user sees when they login.
Base it off of the work already done in the DMPTool react-client.

Wireframe for the dashboard is here: https://www.figma.com/proto/RRtoRLyr5Spf0KiyRfEclt/DMP-Tool-Wireframes?node-id=886-846&t=pGJl655GG7A2dvdJ-0&scaling=scale-down-width&page-id=177%3A504&starting-point-node-id=177%3A626&show-proto-sidebar=1&content-scaling=fixed
Makeup of page:

Search by keyword
Lists of expandable Cards for each Project
Sort By menu (dropdown? or something more accessible) in place of the filters in the wireframe, ideally with options in each direction for: Created By, Last Updated, Project Name, Funder, Completion Status.  Something link this perhaps: https://ux.stackexchange.com/questions/130668/adding-asc-desc-arrows-next-to-dropdown

Has the following dependencies before work should start:

Database table for Plans
Database table for Projects
Card component
Search component

Actually I had thought we were changing to sort but I missed a comment from @cazinc that the idea was a few filters were simpler for users, most of whom won't have many plans, so we wouldn't need sort.
My expectation would be that by default it would be sorted by most recently updated, so that ones they're working on are at the top.  So filters that allow them to find other things make sense.  Published and Draft (maybe Incomplete instead to match the other wireframes) are good, but the last updated shouldn't be needed if recent ones are already at top, so the filters currently just cut things off at the end of the list.
If we want to keep it simple, the one that I think is most likely to be useful would be some sort of Role or Ownership filter, to filter just ones that you are the creator of vs ones that you were invited to contribute to.
I do think there are some power users, e.g. ones that collaborate a lot with others, that might have a lot of plans we'll need to help with, but I think those two filter options are probably a good start.


Ud 821 - Better validation of FlexOffers

@brouwee are you sure about this pull request? (changes about 3000 files) Looks to me you created the pull request from our fork towards this repository?


should we expose variables in app.go?

Currently, in app.go we do like:
app.bankKeeper
the most common practice is to do like:
app.BankKeeper
Should we change the way that CosmWasm presents these?

This is a good question.
I have seen both Juno and Osmosis (big users of CosmWasm) do this, and standardising would be nice for compatibility and porting diffs to app.go easier.
I am not sure the reason to make it private? App is only available in the cmd files and the test code. All modules cannot see it, so making these members public doesn't have a security issue wrt importing modules. Not sure if there is something else I am missing.
If there is no good reason to keep them private, I agree with making them public to be more compatible.

I felt approximately the same way about this, and it seems that it mainly boils down to the keepers.
#882 brings wasmd much closer in line with practices on Juno and Osmosis.
It is my hope that in the next month or so, Juno becomes a reference implementation of wasmd of sorts, and these changes would make moving work between the two projects much easier.
Thanks @ethanfrey @webmaster128 and @alpe -- working on and with CosmWasm has been an unexpected joy.

Interestingly, this is throwing a gocritic linter error:
https://app.circleci.com/pipelines/github/CosmWasm/wasmd/2161/workflows/fcbace1f-bdff-40ba-bc71-67b2fbce270d/jobs/7302
To me that complicates the situation somewhat:  I often slavishly follow linters to ensure that we have convention:
https://github.com/cosmos/ibc-go/pull/1418
I guess that the right way here might be to remove gocritic, or to disable that, because as I mention here:
https://github.com/cosmos/ibc-go/pull/1418#issuecomment-1145203991
I began work on this over at Osmosis, and would like to eventually end up with a linting standard that we can use throughout the ecosystem.

I was commenting on the PR https://github.com/CosmWasm/wasmd/pull/882#issuecomment-1145954036  but have not had time to look into the code. Let's continue the conversation here.

Interestingly, this is throwing a gocritic linter error:

I guess some unintended refactoring issue. This is fine in the main branch. 😅


bump to 1.4.0

Signed-off-by: Yaliang Wu<EMAIL_ADDRESS>Description
bump to 1.4.0
Check List

[ ] New functionality includes testing.

[ ] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

CI failed
Could not find org.opensearch:common-utils:<IP_ADDRESS>-SNAPSHOT.

CI failed
Could not find org.opensearch:common-utils:<IP_ADDRESS>-SNAPSHOT.

latest common-utils 1.x commit is version bumped to 1.4, not sure why that is not being made. opensearch-project/common-utils@b557220

I added as part of the manifest in this PR, so not sure. Any idea on next steps / why it wasn't uploaded? @peternied

@ohltyler I did a quick look, it seems like 1.4.0's build is failing so these artifacts aren't being published for consumption @opensearch-project/engineering-effectiveness is there someone looking into that?

Hey folks -- there is no 1.4 release.
We discussed it at the community meeting, followed up in the forums https://discuss.opendistrocommunity.dev/t/2-0-release-date-discussion/8901 for feedback.   Then updated the website https://opensearch.org/blog/partners/2022/02/roadmap-proposal/ and then our public roadmap:  https://github.com/orgs/opensearch-project/projects/1
Thanks,
/C

Hey folks -- there is no 1.4 release.
We discussed it at the community meeting, followed up in the forums https://discuss.opendistrocommunity.dev/t/2-0-release-date-discussion/8901 for feedback. Then updated the website https://opensearch.org/blog/partners/2022/02/roadmap-proposal/ and then our public roadmap: https://github.com/orgs/opensearch-project/projects/1
Thanks, /C

Understood, the purpose for doing this is because core OpenSearch and Dashboards had bumped 1.x branches to 1.4.0 (which makes sense), but then causes all component CIs on 1.x branches to fail due to version mismatch. So we are trying to bump components to <IP_ADDRESS> to maintain passing CI on all of the repo branches

Hey folks -- there is no 1.4 release.
We discussed it at the community meeting, followed up in the forums https://discuss.opendistrocommunity.dev/t/2-0-release-date-discussion/8901 for feedback. Then updated the website https://opensearch.org/blog/partners/2022/02/roadmap-proposal/ and then our public roadmap: https://github.com/orgs/opensearch-project/projects/1
Thanks, /C

@CEHENKLE Could we update the 1.4.0 release issue with these details?  https://github.com/opensearch-project/opensearch-build/issues/1749  This has been the typical way that our developers have been getting notified about new releases, or in this case I'd recommend using this same channel for no release.

@peternied Good call out.  Done.

ch makes sense), but then causes all component CIs on 1.x branches to fail due to version mismatch. So we are trying to bump comp

Agree with Tyler @ohltyler , OpenSearch core has bumped to 1.4 https://github.com/opensearch-project/OpenSearch/pull/2423, we should also follow the version. Will keep this PR open until commons-util 1.4 ready.

@ohltyler what do you think about us instead rolling back job-scheduler and common-utils? Seems like that is the root cause of this bad state

@ohltyler what do you think about us instead rolling back job-scheduler and common-utils? Seems like that is the root cause of this bad state

I worked on bumping those because of core OpenSearch/Dashboards had bumped to 1.4.0. I believe they should be bumped to follow the current versioning strategy (1.x bumps minor version, 1.3.0 bumps to 1.3.1, etc.), such that after a release, everything is bumped to track a new version in case of a future release at such version.

Close this PR as we don't have clear decision yet.


Datadog integration

Description

Types of Changes

Bug fix.

Testing

[ ] I added tests for my changes.
[ ] I tested my changes locally.
[ ] I tested my changes in staging.
[ ] I tested my changes in production.

This will be released in a separate gem.


.github/workflows: errors for Wasm on Windows testing bots

https://github.com/hajimehoshi/ebiten/actions/runs/3334639753/jobs/5517806380
http://localhost:56407/wasm_exec.js:570:10 Uncaught (in promise)
Error: total length of command line and environment variables exceeds limit
    at global.Go.run (http://localhost:56407/wasm_exec.js:571:[11](https://github.com/hajimehoshi/ebiten/actions/runs/3334639753/jobs/5517806380#step:21:12))
    at http://localhost:56407/:180:[13](https://github.com/hajimehoshi/ebiten/actions/runs/3334639753/jobs/5517806380#step:21:14)
[wasmbrowsertest]: 2022/10/27 05:09:44 main.go:158: context canceled
[wasmbrowsertest]: 2022/10/27 05:09:44 main.go:169: context canceled

The tests seemed to pass though.

Note that Wasm on Windows started to be tested as of #1313

https://github.com/golang/go/blob/185766de0ff2810ee018501addb1f58be2226856/misc/wasm/wasm_exec.js#L522-L525

One of the issues should be solved by https://github.com/agnivade/wasmbrowsertest/pull/39

We have to modify wasmbrowsertest (https://github.com/agnivade/wasmbrowsertest/issues/40)

https://github.com/agnivade/wasmbrowsertest/issues/40#issuecomment-1403197276
There is a useful hack to run commands with evironment variables filtered.


Ensure link's path attribute works with delayed

Closes #1769, closes #1767

:+1:

:+1:  LGTM - build failure looks unrelated to this change

Rebased to master as 1be4c8a3adccd9e392ca4af48f171763e06aaca9


Separate state for agg/daily trip explorer state

Allow dates to be for agg/daily pages separately. Probably add new context object to zustand state manager.

Will be done during #603


Error with git.zsh:42

Since the last update I get this error on my Mac (10.11.5).
~/.oh-my-zsh/lib/git.zsh:42: parse error near `elif'
zsh: command not found: git_prompt_info

I was able to resolve this by changing the line endings from CRLF to LF for lib/git.zsh.
e.g. in vim -> :set ff=unix

Yeah Thanks! It works!

For the next time, here's the solution: https://github.com/robbyrussell/oh-my-zsh/issues/4069#issue-89607351


Feature: Make casbin db name configurable

🔖 Feature description
Make casbin db name configurable
🎤 Pitch / Usecases
We are trying to setup multiple devtron instances in same cluster but the issue is all of those are connecting to same casbin database as it's not configurable, Please make it configurable so that it solves our use-case
🔄 Alternative
No response
👀 Have you spent some time to check if this issue has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

AB#7764

Fixed by https://github.com/devtron-labs/devtron/pull/4547


narrow window breaks menus

on chrome if the window is less than about 775 pixels wide the menus stack up

Is it possible to table this for now?  This would be much easier once we have bootstrap in pre-compilation, then we could just set a few variables to disable responsive views altogether: http://stackoverflow.com/questions/17935601/how-to-remove-responsive-features-in-twitter-bootstrap-3

depends on https://github.com/twosigma/beaker-notebook/issues/1071


[DISCUSSION] Improve the quality of the splash screen picture

About this discussion
Is it possible to put a quality picture on the splash screen? The svg icon maybe?
It's a screenshot from my phone. I don't have the source of the icon to show a quality version for comparison.

Fixed in latest commit.


Remove ".NET Standard" and fix typos

Information about ".NET Standard" is unnecessary and will cause more confusion to the users than provide an important information. If someone wants to know the details, he/she will get them if they click on the provided link.

@alexandair : Thanks for your contribution! The author, @sptramer, has been notified to review your proposed change.

@alexandair - can you update the changes if there are no additional changes. @sptramer - just sign off when it's all ready and we'll merge the PR.

@alexandair : Thanks for your contribution! The author, @sptramer, has been notified to review your proposed change.

#sign-off


authorizationCodeGrant return bad request

Hi there,
i made a facebook messenger chatbot with spotify issues.
My chatbot use a webview (webapp) to connect and grant authorization code with scope.
When the user accept it, i insert the authorization code in my db.
(later)
if my chatbot's user ask me to create a playlist for example,
i get the user's authorization code, and use it to obtain an accesstoken like this :
https://codepen.io/vflausse/pen/OmEmJa
this code return me :
Something went wrong authorizationCodeGrant! { [WebapiError: Bad Request] name: 'WebapiError', message: 'Bad Request', statusCode: 400 }
Am i doing something wrong ?
Did i have to request authorization (with spotify authorize) for any actions of my user, to grant a good authorize code and access token ?
Do you have an idea ? (Help will be really appreciated.)
Thank you.

I am also making a messengerbot to add tracks to a playlist, my problem and i think yours is that for creating playlists you need scopes to be granted... but with my webapp i dont have a page to open the scope authorization so it failes...

Hello,
could you take a look at my issue ?
I will be very thankfull

How are you getting the spotifyAC into your database? When you log the access code what do you get?Need more perspective on this, perhaps upload the project to Github?

Hi,
I had the same issue, just make sure to include the client secret in your setup. That worked for me.
        var spotifyApi = new SpotifyWebApi({
            redirectUri : redirectUri,
            clientId : clientId,
            clientSecret: clientSecret
        });


util/jsonpath in client-go support "['" "']" to escape dot(.) in the path when working with unstructured.Unstructured object

If an object contains dot (.) in the key, such as
metadata:
  labels:
    app.kubernetes.io/name: myapp

according to jsonpath.com  the path to that label value is .metadata.labels.['app.kubernetes.io/name'].
Labels and Annotations are simplest and most frequent case to have dot(.) in the key.  Developers can easily create CRD with  map[string][string] or map[string]Object in their spec.
Please correct me if I'm wrong, it seems current util/jsonpath package does not support [' ']. In the cases above, the FindResults() in util/jsonpath won't be able to find the right result(s). :(
Will you consider that feature?

found this duplicated to #1018


Added docs for 1.20-5

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/unhold


CFFL

CFFL

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_e4gyx05unw/clone/recipe/meta.yaml:15: pip_install_args: pip install should be run with --no-deps.
ERROR: /tmp/abs_e4gyx05unw/clone/recipe/meta.yaml:21: missing_wheel: For pypi packages, wheel should be present in the host section
ERROR: /tmp/abs_e4gyx05unw/clone/recipe/meta.yaml:21: host_section_needs_exact_pinnings: Packages in host must have exact version pinnings, except python build tools.
WARNING: /tmp/abs_e4gyx05unw/clone/recipe/meta.yaml:40: missing_description: The recipe is missing a description
ERROR: /tmp/abs_e4gyx05unw/clone/recipe/meta.yaml:40: missing_documentation: The recipe is missing a doc_url or doc_source_url
Errors were found


Added student mail domain of ibw to the repo

Official school website: https://www.ibw.ch/
URL for IT related courses: https://www.ibw.ch/angebot/technik-informatik/informatik?courses=informatik-technik_informatik&filter=23_22

@svsc99 Thank you for your patience while waiting for a review and processing your request. Pull request merged.


settingsUI is unreadable in setting.json

Environment
My terminal could not read settingsUI in setting.json.
Of course, I've checked , and syntax errors.
Has anyone encountered the error ?

 Line 132, Column 60 (target)
  Have: "settingsUI"
  Expected: settingsFile | defaultsFile | allFiles

Windows Terminal
Version 1.6.10571.0

Steps to reproduce

Expected behavior

Actual behavior

I don't think the Settings UI is enabled in the stable build you're using. If that's so, it makes sense that the settingsUI wouldn't be a valid target in your JSON.

The settings UI is deliberately hidden in 1.6 (See #9225) . You'll need 1.7 preview or wait for 1.7 stable.

Yup.

Thank you for advices.


isort fixer finds ~/.isort.cfg which overrides local project's setup.cfg

Information
VIM - Vi IMproved 8.0 (2016 Sep 12, compiled Dec  7 2017 11:42:48)
macOS version
Operating System:
MacOS High Sierra
:ALEInfo
Current Filetype: python
Available Linters: ['flake8', 'mypy', 'prospector', 'pycodestyle', 'pyflakes', 'pylint', 'pyls']
  Enabled Linters: ['flake8', 'mypy', 'pylint']
 Linter Variables:
let g:ale_python_flake8_args = '--ignore=E123 --max-line-length=89'
let g:ale_python_flake8_executable = 'flake8'
let g:ale_python_flake8_options = '--ignore=E123 --max-line-length=89'
let g:ale_python_flake8_use_global = 0
let g:ale_python_mypy_executable = 'mypy'
let g:ale_python_mypy_options = ''
let g:ale_python_mypy_use_global = 0
let g:ale_python_pylint_executable = 'pylint'
let g:ale_python_pylint_options = ''
let g:ale_python_pylint_use_global = 0
 Global Variables:
let g:ale_echo_cursor = 1
let g:ale_echo_msg_error_str = 'Error'
let g:ale_echo_msg_format = '%code: %%s'
let g:ale_echo_msg_warning_str = 'Warning'
let g:ale_enabled = 1
let g:ale_fix_on_save = 0
let g:ale_fixers = {'python': ['remove_trailing_lines', 'trim_whitespace', 'add_blank_lines_for_python_control_statements', 'isort', 'autopep8']}
let g:ale_keep_list_window_open = 0
let g:ale_lint_delay = 200
let g:ale_lint_on_enter = 1
let g:ale_lint_on_save = 1
let g:ale_lint_on_text_changed = 'always'
let g:ale_linter_aliases = {}
let g:ale_linters = {}
let g:ale_open_list = 0
let g:ale_set_highlights = 1
let g:ale_set_loclist = 1
let g:ale_set_quickfix = 0
let g:ale_set_signs = 1
let g:ale_sign_column_always = 1
let g:ale_sign_error = '>>'
let g:ale_sign_offset = 1000000
let g:ale_sign_warning = '--'
let g:ale_statusline_format = ['%d error(s)', '%d warning(s)', 'OK']
let g:ale_warn_about_trailing_whitespace = 1

What went wrong
The isort fixer is picking up my config in ~/.isort.cfg, overriding the defaults set in the projects setup.cfg.
Since isort is able to use both .isort.cfg and setup.cfg it should check for those in the project before resorting to the one in my home directory (which should be used as a fallback).
isort already has a built-in search, so long as the current working directory is the top-level directory for the project it should already do the right thing:
https://github.com/timothycrosley/isort/wiki/isort-Settings
Reproducing the bug
Create a ~/.isort.cfg and in your Python project don't, but add settings to setup.cfg.
Steps for repeating the bug:

Create an ~/.isort.cfg with the following:

[settings]
line_length = 80
multi_line_output=3
include_trailing_comma=1
use_parentheses=1

In ~/tmp/ create setup.cfg with:

[isort]
line_length = 80
multi_line_output=3
include_trailing_comma=1
use_parentheses=1
known_standard_library=myveryhappylib
sections=FUTURE,STDLIB,THIRDPARTY,FIRSTPARTY,LOCALFOLDER
default_section=THIRDPARTY
not_skip = __init__.py

In ~/tmp/ create a file named test.py with the following contents:

import sys
import something
import myveryhappylib

Run :ALEFix on the file, notice it now becomes:

import sys

import myveryhappylib
import something

Expected output:
import myveryhappylib
import sys

import something

My work-around for now, mv ~/.isort.cfg ~/.isort.cfg.bak and making sure I have isort settings setup in all my projects individually.

I read through the isort source code, and it seems to search for configuration files like so.
config = from_path(os.path.abspath(file_names[0]) or os.getcwd()).copy()

I'll try taking the configuration file searching away and set the working directory instead.

I have fixed this now by changing the working directory instead of setting the path to the configuration file.

Thank you @w0rp!


Problem when I evaluate DVIS(online) on OVIS dataset

Hi! Thank you for your great work!
When I try to evaluate  DVIS(online) on OVIS dataset, I only get "nan" results. Like this:

I can't find the reason. I just change the IMS_PER_BATCH in DVIS_Online_R50.yaml from 8 to 4 in DVIS_Online_R50.yaml.
Here is my order：python train_net_video.py --num-gpus 4 --config-file configs/ovis/DVIS_Online_R50.yaml --eval-only --resume MODEL.WEIGHTS checkpoints/DVIS_online_ovis_r50.pth。
And my evaluate log is log.txt
Hope you can help answer.

This is normal. OVIS does not provide annotations for the validation set. You need to submit the predicted results.json for evaluation at here.


openblas fails to compile on ppc64le-linux using gcc-7

From https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79343
kernel/power/sasum_microk_power8.c gives error: PIC register clobbered by ‘%2’ in ‘asm’
The blas source looks to be adding r2 (and r0) to the clobbers completely unnecessarily.  I suspect what the author of that code was trying to do was say that i and n are changed by the asm, which is done by making them output args as well as input.  The memory clobber could be removed too, if *x1 was made an output.  Oh, and the asm misses clobbers for all the vector regs used..

Similar reservations were noted in the mailing list discussion following (and linked from) #795. @wernsaar ?

Does it compile with current GCC release 6.3? GCC7 is development branch and expected to carry regressions.

So the first comment was wrong about *x1.  I meant *svec, the output.  Patch posted here:
https://groups.google.com/forum/#!topic/openblas-dev/YI1of4HODmw
Not tested apart from simply compiling.  I'm going to leave testing to someone else.
Yes, the current source might compile with gcc-6 since gcc-6 hasn't switched over to lra by default for ppc, but the asm is horribly broken.

"broken" in the sense that the current code gives wrong results, or just that it is written with (I guess) a strong x86 accent ?

On Fri, Feb 03, 2017 at 01:50:40AM -0800, Martin Kroeker wrote:

"broken" in the sense that the current code gives wrong results, or just that it is written with (I guess) a strong x86 accent ?

The current code trashes callee saved regs fr14 to fr23.  A function
that accidentally modifies the variables of its callers (and not just
the immediate caller) is horribly broken.
--
Alan Modra
Australia Development Lab, IBM

@brada4 @martin-frbg The OpenBLAS VSX code is wrong and it is not a GCC 7 regression.

Thank you both for the clarification. Given this situation I am inclined to merge the patch as-is although I am mostly illiterate when it comes to assembly and I have no ability to test it.

At least 24 other files appear to be equally affected, and I do not feel confident to apply these corrections even to closely similar files like dasum_microk_power8.c, sorry.

Commenting here for being in the loop…  See:  https://bugzilla.redhat.com/show_bug.cgi?id=1417385

On Fri, Feb 03, 2017 at 02:23:35PM -0800, Martin Kroeker wrote:

At least 24 other files appear to be equally affected

Indeed.  What a mess!  I'll take a look at fixing them all.
--
Alan Modra
Australia Development Lab, IBM

For the record, it's more than just the gcc asm() statements.  The assembly files are broken too, I think, using callee-saved altivec regs without saving them.
Oh, and the patch I posted wasn't correct either.  Oops.  The constraints were not quite right, and I should have put vs32 etc. in the asm clobbers, not plain 32 etc.  In sasum_microk_power8.c fr14..fr23 were not being trashed but some altivec regs, v20, v21, v22 and v23.
In a lot of cases by using the right vsx registers we probably don't need to touch callee-saves.  There are 34 vsx regs that don't need to be saved, vs0-vs13 (corresponding to fr0-fr13),and vs32-vs51 (corresponding to v0-v19).

Thanks for grabbing this, Alan. Getting inline asm correct is tricky.

@brada4  I tried it on pp64le with GCC 6.3 and it works except of the #1071 bug.

@grisuthedragon as I understood amodra, the code delivers the expected result (else I am sure wernsaar would not have committed it) but may trash unrelated bits in the process.
(Is there some whitepaper on power8 assembly that explains how to code for this processor so "we" can avoid making the same mistakes in the future ?)

@grisuthedragon Thanks for confirming, maybe this fixed will silently fix other...

On Tue, Feb 07, 2017 at 12:10:23AM -0800, Martin Kroeker wrote:

(Is there some whitepaper on power8 assembly that explains how to code for this processor so "we" can avoid making the same mistakes in the future ?)

I'm not aware of any such paper, but the issues in the asm are mostly
not specific to powerpc.  Asm constraints are explained in the gcc
info doc.
Here are a few examples.  Compare the following new implementation for
kernel/power/dgemv_n_microk_power8.c against the old.  (I've changed
the parameters so that a0..a3 and alpha are not needlessly passed in
memory.  The new asm calculates a0..a3 from ap and lda, and splats
alpha rather than that being done in C.)
static void dgemv_kernel_4x4 (long n, double *ap, long lda, double *x, double *y, double alpha)
{
double *a0;
double *a1;
double *a2;
double *a3;
asm
(
...
:
"=m" (*y),
"+r" (n),	// 1
"+b" (y),	// 2
"=b" (a0),	// 3
"=b" (a1),	// 4
"=&b" (a2),	// 5
"=&b" (a3)	// 6
:
"m" (*x),
"d" (alpha),	// 8
"r" (x),		// 9
"b" (16),	// 10
"3" (ap),	// 11
"4" (lda)	// 12
:
"cr0",
"vs32","vs33","vs34","vs35","vs36","vs37",
"vs40","vs41","vs42","vs43","vs44","vs45","vs46","vs47"
);
}
Use "+r" (n) to say n is both an output as well as input, ie. in
this case since n isn't used outside of the asm, an input that is
modified.
Use "=m" (*y) and "m" (*x) to specify the memory written and read
by the function.  Much better than a "memory" clobber since it tells
gcc the actual memory touched, and allows eg. gcc to delete the asm if
its output is unused.
Specify that a0..3 are needed temp regs by making them outputs, using
the same reg as ap and lda inputs in the case of a0 and a1, and using
and early clobber on a2 and a3 to say those outputs can't share the
same reg as any of the inputs.  It's a pain that gcc doesn't allow
more than 30 asm inputs and outputs since if it did allow more I/Os
you could do the same sort of thing for the vsx temp regs.  That would
allow gcc complete freedom to allocate vsx regs, which might be better
for inlining.
Notice that x and y both appear twice (but in fact use the same reg.
ie. the "=m" (*y) is 0(r7) and "+b" (y) is r7).  It's a bit of a pain
that you need to do this sort of trick, but powerpc gcc lacks
modifiers to ask for just the base reg to be output for the "m"
constraint (or "es", "Z" constraints).  So that is a powerpc trick
that you might not need on other processors, but handy to know for
generic use.  Since the asm doesn't make use of %0 or %7 it doesn't
even matter if gcc allocates different regs or even a different form
of address for the "m" I/Os.
Notice also that I've used "b" rather than "r" in most cases.  That is
to exclude r0, since some insns in the asm interpret an r0 encoding in
certain fields to mean zero rather than the register.  eg. addi 0,0,4
is r0=4, not r0=r0+4.
I'd post the whole patch but right now I have some testsuite errors to
contend with.  Hopefully just a typo somewhere.
--
Alan Modra
Australia Development Lab, IBM

Patch posted to https://groups.google.com/forum/#!topic/openblas-dev/YI1of4HODmw

Thank you.I will convert it to a "pull request" ASAP.
(Pity about the remaining .S files being at least partly incorrect as well, but I guess it was to be expected given the common authorship)

@amodra Thank you very much!  =)

Unfortunately the "vs" registers on the clobber lists appear to cause compatibility problems with both clang(#1120) and xlc (#1248) - "unknown register name 'vs32' in asm" etc. I was ready to accept that the LLVM version may have simply been too old to be compatible, but I find it quite disconcerting that the same error comes up with the current "Community Edition" of XLC 13.1.5. Thoughts ?

The "vs" names are additional, alternate register names that overlay the FPRs and VRs. vs32-vs63 is equivalent to fr0-fr31, vs32-vs64 is equivalent to v0-v31.

Thx. Actually it had occured to me in the meantime that I had just been using "v20" et al. myself in the register saving code I copied from the PowerISA book... perhaps I should actually read that document in full. :-/
Next up however is "the asm operand does not match the specified constraint" for
 "=wa" (t0) in the same file (sasum_microk_power8.c) so there seems to be more gasm idiom here that  "something in xlc" does not like.

"=wa" appears to specify "a vsx register", t0 is declared as a "__vector float" (and is identified with "%x3" in a comment above the problematic line). Trivial substitutions like "v3" for t0 or "wf" for wa based on reading the "asm constraints" section of the gcc docs only lead to different errors at best.

I can get it to compile if I use "=v" (Altivec vector register) in place of "=wa" - not sure if I am just missing a compiler option (although I already have -qarch=pwr8 -mcpu=power8 -qaltivec -q64 -qsimd=auto).

Why are you focusing on XLC?  XLC is far out of date with respect to correct register constraints.

Just for the sake of completeness (and to get rid of issue #1248). If this is "expected to fail" I'll gladly add a note in the wiki and leave it at that.

Please don't change to code to satisfy XLC. This is an XLC bug, not a bug in OpenBLAS.  It would be nice for OpenBLAS to build and run with XLC, but that apparently requires a fix to XLC.  The person who reported issue #1248 should report the problem to IBM as an XLC bug.

Closing here as the (then) remaining code problems are addressed in #1263

Just to follow up: XLC uses clang technology, and so far, "vs" register names are unsupported by clang. As a workaround, you can use v0, …, v7, instead of "vs32", …, "vs39". This came up again recently in https://github.com/xianyi/OpenBLAS/issues/1699.


[3.0] Foundation overlay: Fix optionality mismatch in NSMutableDictionary subscript.

setObject:forKey: takes a nonnull object, causing us to accidentally pass in a boxed Optional-in-an-Any from the Swift subscript's optional newValue. Fixes rdar://problem/27875914.

@swift-ci  Please test

@swift-ci Please test OS X


stop win10 from auto install vmware tools

does anyone know how to stop win10 from install vmware tools on first run?

Do not select ISO during VM creation and just select it later after VM is created.


268/Data source developer docs

Issue Number: 268
Summary
Expanding on data source developer docs
Changes
Adding docs about adding a new data source and how to

Inherit from the data source interface
Configure for dependency injection
Register for sdk
Add tests

Note, this PR will eventually go directly into the GSF repo where this file already exists in reduced form.
Checklist

[ ] Local Tests Passing?
[ ] CICD and Pipeline Tests Passing?
[ ] Added any new Tests?
[X] Documentation Updates Made?
[ ] Are there any API Changes? If yes, please describe below.
[ ] This is not a breaking change. If it is, please describe it below.

Are there API Changes?
If yes, what are the expected API Changes? Please link to an API-Comparison workflow with the API Diff.
Is this a breaking change?
If yes, what workflow does this break?
Anything else?
Other comments, collaborators, etc.
This PR Closes Issue #

Wasn't sure where/if I should include info about the logging infrastructure that currently exists, which can be leveraged in the data source or if that's too detailed. One option is to have and "Advanced" section where we include that info so it's not something we suggest as a first pass adding a data source but as a thing you can look into later. @juzuluag what do you think given you worked on that (I believe there were some docs written too)

Wasn't sure where/if I should include info about the logging infrastructure that currently exists, which can be leveraged in the data source or if that's too detailed. One option is to have and "Advanced" section where we include that info so it's not something we suggest as a first pass adding a data source but as a thing you can look into later. @juzuluag what do you think given you worked on that (I believe there were some docs written too)

I think it won't hurt to mention that any approach using DI would work. That is the way we do logging, by injecting the logger through that mechanism. No need imo to have like an advance section for it.

Closing now that have comments and will re-open with GSF history