Start date over written

Start date is set by the scheduler somewhere after getting response from compute, which in some cases I have found that the compute overwrites it because of the following series of events

Scheduler (S) - job request sent
C - response sent
Compute (C) - job fetched (say instance JC)
S - job updated (say JS)
C - updates JC and pushes, which overwrites the updates made by JS.

Thus producing an unexpected result. Few possible solutions:

Update JS before getting response, and rollback updates if response is not 200
Add sleep in compute

Do we care?

Well, I am not able to benchmark properly. Thats when I realised this issue.
Shubham Jain,
Research Assistant, Imperial College London,
Former AI Scientist and Founding Member, Qure.ai,
B.Tech with Honors, IIT Bombay - 2016,
+919619754138.
On Sun, Jun 24, 2018 at 7:04 PM, Axel Oehmichen<EMAIL_ADDRESS>wrote:

Do we care?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/OPAL-Project/OPAL-Scheduler/issues/8#issuecomment-399775426,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AE2HRJ-jxK4MgOMaQSAMjGK1SD-5vs_qks5t_9TDgaJpZM4U1O4z
.


WIP: Handle resize event

This is supposed to fix #44 and #74. It should then be possible to resize the figure.canvas using ipywidgets layouts

Closing, I will open another PR for resizing support once #100 is in

@martinRenou Any estimate when this feature would be released?

Are you talking about a resize handle?

@martinRenou Yes I am referring to the resize handle feature as previously mentioned in this issue. https://github.com/matplotlib/jupyter-matplotlib/issues/44. It will also be cool if there was a input text box to specify the exact size instead of the mouse handle.
Thank you for your help and contributions!

I have no estimate. I plan to look at it this week, but I cannot promise anything :)


Bumping OHW R image

Hopefully this will fix some of the C library issues.

I'm interested to know why our CI/CD didn't run on this PR.....

I told you I was good at breaking things.

Ok, at least that CI/CD was successful!

But we should have also had a comment like this one: https://github.com/2i2c-org/infrastructure/pull/1629#issuecomment-1216194982

Hmm, when I previously made a PR with an image bump I got a comment: https://github.com/2i2c-org/infrastructure/pull/1599#issuecomment-1206153240

Yeah, I don't know why it wouldn't have triggered again. It doesn't show up here: https://github.com/2i2c-org/infrastructure/actions/workflows/deploy-hubs.yaml?query=event%3Apull_request And as far as I know, nothing has changed

@sgibson91, do you think we should open an issue about this one ⬆  or just consider it as a transient failure?

@damianavila I expect it was a transient failure. I believe githubstatus.com reported an Actions outage a little time after this so this was probably a precursor event.


Unable to paste from system clipboard on web-version

Currently I am unable to paste from my clipboard into the editor in the web-version. Is this by design?

It's a limitation but i plan on fixing it soon. The editor is custom built so it doesn't have some built-in features like copy/paste, but i think it should be possible to add via contenteditable. I'll update this issue once i figure out a solution.

This is now fixed in the web client's editor. Please try it out when you get the chance.


Promote CHGNET and M3GNET to full dependencies

Resolves #161

Moves chgnet and m3gnet dependencies from optional to full dependencies, and removes pytest decorators, which prevent related tests running by default.
Adds singlepoint tests for both

Note: Currently requires pinning dgl, as attempting to install the most recent version gives me an error: ERROR: Could not find a version that satisfies the requirement dgl==2.2.1 (from versions: 0.1.0, 0.1.2, 0.1.3, 1.0.0, 1.0.1, 1.0.4, 1.1.0, 1.1.1, 1.1.2, 1.1.3, 2.1.0) (see issue linked in #161).

The README probably could do with updating too to reflect this, including a comment about setting the PyTorch dtype if using multiple MLIPs.


Improve prop type key when mapping over tuple

This makes it easier to map over tuples by allowing T[K & number] on the "right side" to preserve the per-position type of the input tuple.
A TS question on Twitter has been posted by @kof here and I was sort of surprised that this solution didn't quite work as expected. So I got curious as to why it doesn't work and I've discovered that the prop type in the mapper is a string... and thus K & number gets reduced to never and then Tuple[never] produces a union of types at all position (which is somewhat surprising to me as with an object type I just get never back).
It seems that this trivial change~ improves this situation considerably and doesn't break any existing test cases. The improvement can be seen in this diff.
TS playground 4.6

Interesting, I also use the string index in https://github.com/microsoft/TypeScript/pull/48433 maybe should be adapted too

@mikearnaldi ye, if this PR here lands then the other one should be adjusted too. If yours lands first then I will add some additional tests here, related to your change.

It would really be nice to have an associated bug with inline examples. But this does seem like a small change, so .. @weswigham, what do you think?

Thing is, it's now possible to map from the strings back to the numbers (due to an inference change by @rbuckton ) so maybe we should just be OK with mapped types consistently returning the string form of the keys and allowing users to map those into the numbers if they actually need to?

While possible, I don't think this is that ergonomic from the user perspective - for what seems to be a standard~ use case. This kind of mapping is not too fancy - it's just mapping one tuple to another.
I would also argue that this matches the common expectations of array/tuple keys being numbers (arr[0]). It's possible to access using both strings and numbers but I don't think that many users think in terms of accessing array types with stringified integers.
IMHO, this also matches better how we can expand a tuple to a union of the values:
type A = [0, '1']
type B = A[number] // 0 | ''

While I understand the motivation, I don't think it is right to change the iteration type to be numeric. A homomorphic mapped type is supposed to iterate over keyof T (or, in the case of tuples, some subset thereof) and with this change that wouldn't be the case.
Let me think about the scenario a bit and see if I can come up with something better.

We could maintain the mentioned invariant if tuples would have numeric keys representing their indices and not their stringified equivalents. As a user - this would be much closer to how i think about arrays/tuples.
Separately from that - iterating over tuples could be it's own thing (annotated somehow, or using new syntax). A lot of quirks/unexpected behaviors happen because this piggy backs on regular, object-oriented, mapped types

We could maintain the mentioned invariant if tuples would have numeric keys representing their indices and not their stringified equivalents. As a user - this would be much closer to how i think about arrays/tuples.

Agree in principle. Except it wouldn't work because tuples also have a numeric index signature which would "absorb" the numeric literal values when you ask for keyof T. For example, keyof [true, false] currently is number | "0" | "1" | ..., and the number would absorb the numeric literals in what you propose.

Just added a comment on a related issue to this. The final solution there could be greatly simplified if we'd have an easier way to iterate over tuples position by position.

So, I'm putting together a PR that adds the following:

Numeric index signatures apply when the index type is ${number}. For example  `Foo[][`${number}`] resolves to Foo instead of being an error. This is consistent with our existing rule that index signatures apply when the index type is a numeric string literal. For example Foo[]['123'] already resolves to Foo.
Intersections of type string and a template literal type reduce to just the template literal type. For some reason we never had that rule, but we should such that  `Foo[][K & `${number}`], where K is some keyof T, can resolve to Foo.

With these changes, your example works when you write
type UnwrapContainers<T extends Container<unknown>[]> = {
    [K in keyof T]: T[K & `${number}`]["value"];
};

I'm also looking at possibly adding an implied `${number}` constraint to K in cases where it iterates over keyof T for some T constrained to an array type.

I agree with the proposed changes - the first two seem like good semantic improvements when we consider existing functionality.
The proposed implied ${number} constraint would mean that those changes wouldn't be needed for this use case to work, right? That's, of course, not a reason to skip introducing them - I'm just making sure that I understand this correctly. With this proposed change the K & `${number}`  wouldn't be needed at all and we could simplify further:
type UnwrapContainers<T extends Container<unknown>[]> = {
-    [K in keyof T]: T[K & `${number}`]["value"];
+    [K in keyof T]: T[K]["value"];
};

I guess this would maintain the invariant about K always being a subset of keyof T since:
const b = ['', 9] as const
type Test = `${number}` & keyof typeof b
//   ^? type Test = "0" | "1"

Thinking about the underlying problem... Is there any appetite for introducing distinct syntax for array/tuple mapping?
For example, something like
type StringifyElements<T extends ReadonlyArray<any>> = [[I in indexof T]: `${T[I]}`];

(doesn't have to be this syntax specifically!)
I realise the scope of such a feature is significantly beyond that of this PR 😅, but...
Over the years, I've used various hacks/workarounds to get the existing mapped type syntax to correctly transform array/tuple elements, and the results have always been fragile/unreliable. I usually end up using recursive types instead, but these are more complex and have their own problems. Having dedicated syntax here would definitely make my life easier!
The current mapped type syntax is a great tool for general key/value transformation. While arrays/tuples are objects, they're a specialised form of object, and array/tuple mapping is a specialised key/value transformation. As such, having specialised syntax for it would make sense in the same way that having specialised syntax for array value literals does.
Thoughts?

Thinking about the underlying problem... Is there any appetite for introducing distinct syntax for array/tuple mapping?

With the improvements in #48837 there shouldn't be a need for distinct syntax for array/tuple mapping. Homomorphic mapped types constrained to array types should cover it.

Closing in favor of the mentioned https://github.com/microsoft/TypeScript/pull/48837


Optionally generate persistence code for Couchbase.Lite?

Ancestor projects to neonKUBE actually supported a form of code generation for Couchbase Lite, something like what ModelGen is doing.  This included code for serializing/deserializing data to Couchbase Lite as well as transparently supporting document updates via INotifyPropertyChanged and ObservableCollection as data in the database changed.  I abandoned this after Couchbase Lite 2.0 was released with a very different programming model.
It would still be nice to support Couchbase Lite for Xamarin based apps and I just completed an investigation to see if this would make sense for the Loopie Washer app.  I decided against this for the reasons outlined below.  It still could make sense to support this in the future, so I'm going to leave this issue open.
I think I will modify ModelGen and the related neon-cli commands to default persisting the __T property as ~~T so that new projects won't have to worry about a disruptive upgrade to support Couchbase Mobile 2+.  See #776.

I spent a day and a half getting up to speed on Couchbase Lite 2+ and SyncGateway and gained a better understanding of the challenges:

SyncGateway reserves document property names that begin with an underscore for its own purposes.  This conflicts with the __T property generated for persistable documents.  The solution here is to generate models with a different property name like ~~T (see #776) but existing projects would need to be rebuilt and deployed and databases would need to be upgraded.  There might be some ways to help mitigate this transition, but this will still be painful (e.g. service/database downtime and requiring mobile app upgrades).

SyncGateway pretty much layers on top of Couchbase on the server side.  One big feature for Couchbase Mobile was that it now supports having SyncGateway and server side code accessing the same bucket.  Previously, you had to deploy two buckets, one for server access and the other for SyncGateway and then configure replication between them (which was icky).  So 2.0 was a big advance here but, the integration still feels somewhat clunky as described below.

SyncGateway adds new core concepts like: users, roles, and channels that are distinct from the usual Couchbase Server RBAC related concepts.  In this context, a user corresponds to person owning a remote device that will be syncing data, channels are used to group documents, and roles are used to assign access rights to documents.  Users are granted access to channels which controls which documents which will be replicated to remote devices and whether changes made on those devices can be replicated back to the central database.
These entities are managed via REST calls to the SyncGateway rather than calls to a normal Couchbase bucket.  This isn't the end of the world, but this will make deployment more complex (e.g. folks would probably want to deploy two sets of SyncGateways, one for internal cluster use that exposes these REST APIs to internal code (like workflows) and the other set of SyncGateways exposed to the outside world and is limited to syncing remote clients.
NOTE: Last time I checked, there was no .NET client for SyncGateway, but I do have some archived code that implements this that I could dust off.

SyncGateways are configured with a sync function written in JavaScript.  This is provided by the developer as a configuration setting and handles verifying new and modified documents as they're being uploaded from clients as well as assigning documents to channels.  This includes verifying that the remote user has the right to modify the document.
This makes perfect sense for the syncing remote clients, but one consequence of this is that any data created on the server side via normal bucket APIs will never be assigned to a channel and thus, will be never synced to remote clients.  Server code will need to create documents via the SyncGateway REST API to support this.
NOTE: I'm not sure what happens if the server side modifies an existing document that's assigned to a channel using bucket APIs.  The SyncGateway metadata is in a separate related blob so there's a decent chance that bucket based updating won't impact this data.  One other thing to investigate is whether deleting a document with SyncGateway metadata via a bucket API will also delete the related metadata.
This all is a bit odd, but not an absolute roadblock.  It would be nice to try to abstract some of this by perhaps merging SyncGateway related functionality into the neonKUBE Couchbase bucket API.

The new Couchbase Lite 2.0 programming model is a bit weird.  First, they moved away from using JSON.NET as the underlying serialization mechanism to something completely dynamic.  Accessing a document property requires specifying property names as strings.  They provide no mechanism for mapping documents to class types via reflection.  ModelGen would need to generate code to manage this.  Not impossible, but yet more work.
Coucbase Lite 2.0 also considers all documents to be invariant by default.  To create or modify a document, you first need to convert it into a MutableDocument before modifying it.  This conflicts with the ModelGen model where documents are not invariant and can be modified at any time.  We'd have to figure out a way to abstract the MutableDocument creation such that it is transparent to developers.
Couchbase Lite 1.x supported LINQ query expressions whereas 2+ does not.  They do support N1QL as well as a fluent query API.  This isn't horrible but I believe we'll lose the ability to implicitly constrain queries to a document type, like we can with Linq2Couchbase on the server.  We'd also lose the compile time type checking provided by LINQ.  This probably isn't a huge deal bit it would be nice to have something like Linq2Couchbase that provided the compile time type checking but used the new fluent query API under the covers (Linq2CouchbaseLite or something).
We'd also need to implement support for change notifications via INotifyPropertyChanged and ObservableCollection.  I had this working for 1.x in archived code, but I expect this will take some additional effort for 2+.

I looked at this briefly and I think this would be relatively easy to implement by simply recursively serializing the __O properties to Couchbase Lite documents.
The open design issue would be to decide how to manage the document ID.  The current modelgen scheme does not specifically store or identify a document ID property (although we create methods to generate keys).  One approach would be to add some kind of [ModelId] attribute that can be used to tag the ID property.  Alternatively, we could require the application to specify the ID when serializing to a Document.
I leaning towards the latter idea.  This will be easier and probably makes more sense anyway.  Some models may not have a natural ID.
I'm putting this on the backlog.

I think we’re going to deprecate Couchbase support.  See #832


Enable Arm64 optimization on Windows

03/08/2023, 17:39
Seems like I can't review that. I see a lot of places using the aarch64 macro but not all of them checking for _M_ARM64. I wonder if all code should always check both.
-- most probably you are using your company account, try a personal one


Migrate string-refs to functional ones

Summary

Ticket Link

Fixes https://github.com/mattermost/mattermost-server/issues/15798
Related Pull Requests

none

Screenshots

Hello @ArturBa,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.
Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project.
Please help complete the Mattermost contribution license agreement?
Once you have signed the CLA, please comment with /check-cla and confirm that the CLA check is green.
This is a standard procedure for many open source projects.
Please let us know if you have any questions.
We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.

/check-cla

/check-cla

/check-cla

Should I do anything to finish this merge request?

Should I do anything to finish this merge request?

no, it needs to pass QA, @jgilliam17 will take care of that.
also sync and merge, but I'll add a comment to automatically do that

/update-branch

@ArturBa I spoke too soon 🤦
there is a conflict with master (it wasn't there this morning), can you fix that?

merged

@jgilliam17
Fixed

Please check if it's working correctly

/update-branch

@Willyfrog All done. Please merge


What about Bower ?

Hello,
I'm interrested to use Protein viewer in my project. For to integrate it, do you think to use a JS library like Bower ?
Thanks,

I personally don't use bower, but I can see that it's useful. I've just pushed small changeset that adds a bower.json file to the release packages. You should now be able to bower install the release tgz's:
bower install https://github.com/biasmv/pv/releases/download/v1.7.1/bio-pv-1.7.1.tgz

You can't however install directly from the git repository. For now at least.

Is there any plan to register bio-pv with bower ? That would be nice and neat. Especially once we start doing other packages that depend on pv (pv plugins that require pv).

You can now download and install PV with bower install bio-pv


Cannot set Max-Age (HSTS)

Confirmation

[X] My issue isn't already found on the issue tracker.
[X] I have replicated my issue using the latest version of the provider and it is still present.

Terraform and Cloudflare provider version
CF - 2.21.0
Terraform - 0.14.4
Affected resource(s)
security header (HSTS)
Terraform configuration files
resource "cloudflare_zone_settings_override" "test" {
    zone_id = var.cloudflare_zone_id
    settings {
        security_header {
            enabled = true
            preload = true
            max_age = 63072000
            include_subdomains = true
            nosniff = true
        }
    }
}

Debug output
No response
Panic output
No response
Expected output
Status: On
Max-Age: 12 months
Include subdomains: On
Preload: On
Actual output
Status: On
Max-Age: %{time}
Include subdomains: On
Preload: On
Steps to reproduce
Use terraform with cloudflare provider
Additional factoids
No response
References
No response

Is the issue here that you can't set any arbitrary number for the max age? 63072000 isn't an available option.

I tried quite a few numbers and it didn't work. What's an available option?

I'm sorry but what didn't work?
The available values can either be seen in the UI or the API documentation at api.cloudflare.com.

Terraform results in Max-Age: %{time} when applying. No errors. If the number isn't available terraform should fail?
I went to api.cloudflare.com and can't find where it says what the range is. It gives an example: 86400 to enter and I try that number and also results in %{time}.

Can you please provide the TF_LOG=DEBUG output untruncated? I'm unsure how you're not getting a value or guidance as to the error on this.

Apologies, I have just realised what you meant. The UI shows that output, not Terraform. I'm afraid the best course of action is to open a Cloudflare Support ticket, and it will be routed to the correct team that handles it. Once you created that drop the ticket ID here and I can make sure the team sees it.
Ignore the UI for now and just go off the Terraform/API response as that is working.


Unable to ping outside addresses when using "Emulated VLAN" adapter (using v4.6.0 beta, unknown if regression)

Describe the issue
I am running Rocky Linux 9.4 on ARM with an "Emulated VLAN" network adapter. My understanding was that this was that this would have all the traffic to the outside appear to come from the qemu process, with things like dhcp and dns provided by qemu to the guest. (I'm trying to diagnose a user's issue with a "Shared Network" that worked until I was no longer helping them, thinking maybe this will rule out some possible sources of errors like changing host OS network config.)
In the pre-installation environment for Rocky 9.4 I get a network configuration from dhcp. I am able to ping the default route host, <IP_ADDRESS>, but not an outside address like <IP_ADDRESS>:

I have the firewall disabled, and I was prompted to allow UTM to access devices on the local network-- I am pretty sure I clicked 'allow', but I don't know where that permission lives in System Settings now.
Configuration

UTM Version: 4.6.0 (beta)
macOS Version: 15.0.1
Mac Chip (Intel, M1, ...): M1 Max

Crash log
If the app crashed, you need a crash log. To get your crash log, open Console.app, go to Crash Reports, and find the latest entry for either UTM, QEMU, QEMUHelper, or qemu-*. Right click and choose Reveal in Finder. Attach the report here.
Debug log
debug.log
(I did not see anything network related.)
Upload VM
The config is here; the VM is empty except for a Rocky-9.4-aarch64-minimal.iso install disk.
config.plist.zip

Duplicate of #351
Ping doesn't work with SLIRP


[draco] Build error

Package: draco[core]:x64-osx -> 1.5.3
Host Environment

Host: x64-osx
Compiler: AppleClang <IP_ADDRESS>50022
vcpkg-tool version: 2023-01-24-8a88d63f241d391772fbde69af9cab96c3c64c75
vcpkg-scripts version: 91dd61bd4 2023-01-27 (3 days ago)

To Reproduce
vcpkg install colmap:x64-osx
Failure logs
-- Downloading https://github.com/google/draco/archive/1.5.3.tar.gz -> google-draco-1.5.3.tar.gz...
[DEBUG] To include the environment variables in debug output, pass --debug-env
[DEBUG] Feature flag 'binarycaching' unset
[DEBUG] Feature flag 'compilertracking' unset
[DEBUG] Feature flag 'registries' unset
[DEBUG] Feature flag 'versions' unset
[DEBUG] 1000: popen( curl --fail -L https://github.com/google/draco/archive/1.5.3.tar.gz --create-dirs --output /Users/apzaveri/Documents/my_work/VirtualMakeOver/third_party/colmap/vcpkg/downloads/google-draco-1.5.3.tar.gz.32800.part 2>&1)
[DEBUG] 1000: cmd_execute_and_stream_data() returned 0 after  8262568 us
error: Failed to download from mirror set
error: File does not have the expected hash:
url: https://github.com/google/draco/archive/1.5.3.tar.gz
File: /Users/apzaveri/Documents/my_work/VirtualMakeOver/third_party/colmap/vcpkg/downloads/google-draco-1.5.3.tar.gz.32800.part
Expected hash: 8575ea78e0d8025facddbd42453b0251387f4e31eb0854135e050fc26aaf0d28ed30ccc3f93578fdc6cdb50369c2ef735291f1f5fb60238b289e0ee019446e1d
Actual hash: c2ee8f4d05d322257c064dcb86f7cbbcf6674c14e6e52a6304860e394ce2f4d82c0fe4a0a638a7edd062e5f2289aa5cf9316242ee54b860bd0fca437e8bfb490
[DEBUG] /Users/runner/work/1/s/src/vcpkg/base/downloads.cpp(956):
[DEBUG] Time in subprocesses: 8262568 us
[DEBUG] Time in parsing JSON: 8 us
[DEBUG] Time in JSON reader: 0 us
[DEBUG] Time in filesystem: 2385 us
[DEBUG] Time in loading ports: 0 us
[DEBUG] Exiting after 8.474 s (8469862 us)

CMake Error at scripts/cmake/vcpkg_download_distfile.cmake:32 (message):

      Failed to download file with error: 1
      If you use a proxy, please check your proxy setting. Possible causes are:

      1. You are actually using an HTTP proxy, but setting HTTPS_PROXY variable
         to `https://address:port`. This is not correct, because `https://` prefix
         claims the proxy is an HTTPS proxy, while your proxy (v2ray, shadowsocksr
         , etc..) is an HTTP proxy. Try setting `http://address:port` to both
         HTTP_PROXY and HTTPS_PROXY instead.

      2. You are using Fiddler. Currently a bug (https://github.com/microsoft/vcpkg/issues/17752)
         will set HTTPS_PROXY to `https://fiddler_address:port` which lead to problem 1 above.
         Workaround is open Windows 10 Settings App, and search for Proxy Configuration page,
         Change `http=address:port;https=address:port` to `address`, and fill the port number.

      3. Your proxy's remote server is out of service.

      In future vcpkg releases, if you are using Windows, you no longer need to set
      HTTP(S)_PROXY environment variables. Vcpkg will simply apply Windows IE Proxy
      Settings set by your proxy software. See (https://github.com/microsoft/vcpkg-tool/pull/49)
      and (https://github.com/microsoft/vcpkg-tool/pull/77)

      Otherwise, please submit an issue at https://github.com/Microsoft/vcpkg/issues

Call Stack (most recent call first):
  scripts/cmake/vcpkg_download_distfile.cmake:273 (z_vcpkg_download_distfile_show_proxy_and_fail)
  scripts/cmake/vcpkg_from_github.cmake:106 (vcpkg_download_distfile)
  ports/draco/portfile.cmake:3 (vcpkg_from_github)
  scripts/ports.cmake:147 (include)

Additional context

Duplicate of https://github.com/microsoft/vcpkg/issues/29288


584111F7 - Minecraft Xbox 360

Validation

[X] I've read the FAQ.
[X] The Xenia build used is from a canary branch. (not MLBS/AlexVS/master/pull requests, etc)
[X] This issue isn't for help (tech support) with Xenia, or a game.
[X] I've checked if this game doesn't already have a compatibility report.

Xbox 360 Marketplace link
https://marketplace.xbox.com/en-US/Product/Minecraft-Xbox-360-Edition/66acd000-77fe-1000-9115-d802584111f7
Xenia version
https://github.com/xenia-canary/xenia-canary/commit/81096646d7dc088b83b2c9cb1e4df1dd0cece00f/
Issues
Whenever I load a world it will show this message and freeze. I can play the tutorial but when saving, exiting and trying to enter again then it happens.
Log
log.zip
Screenshots

Labels
state-crash-guest

game runs fine on latest canary_experimental build as of writing (canary_experimental@fecd1e6a4)
tested with latest title update

Duplicate of #88


[BUG] Gamerule keepInventory not properly working again

when dying with the gamerule KeepInventory true only some iteme are kept (i think only the hotbar ones but im not shure) the rest wont even drop but gets deleted

Also I checked to make sure that keepInventory does work with just forge and no mods, so something about EIO being present is breaking keepInventory somehow.

Update: I have identified something significant and frankly bizarre.

I get to keep my diamond sword but all the other items are deleted???

Also it moves the sword to a different item slot?????
I thought I knew what was going on with this bug but but I'm now flabbergasted.


Unexplained Bayeux Null

Leads to having to catch an NPE in SessionBackupRest.java, which spits out:
Warning: Caught NPE of unknown origin.

More information on origin of this NPE:
When using an electron client to switch to a pre-existing backend, all backend-Electron communications will fall unto this NPE, instead of properly posting on the cometd channel.

The problem mentioned in the previous comment was caused because Faye was not being rebound to the new backend server. Then it seems that the NPE occurs when a publication is attempted on a channel on which nobody is listening, in which case this NPE is properly handled and no error should be output.

The only way I can reproduce it is:
In beaker(web version), when notebook is opened, click menu File -> Close.
It will call REST Api to close session:
https://github.com/twosigma/beaker-notebook/blob/master/core/src/main/java/com/twosigma/beaker/core/rest/SessionBackupRest.java#L190
and it tries to publish session update to Electron channel which was never created.
So I will separate api for closing electron session from web.

still getting these.

Could you describe test case?

you said you have seen these now...

these are visbile as:
Warning: Caught NPE of unknown origin.


Add latest Ui.png

Edit the latest UI for the user guide/any document that references from images/Ui.png

Codecov Report

Merging #143 (cd0b62b) into master (c56680b) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #143   +/-   ##
=========================================
  Coverage     63.47%   63.47%
  Complexity      630      630
=========================================
  Files           105      105
  Lines          2379     2379
  Branches        306      306
=========================================
  Hits           1510     1510
  Misses          746      746
  Partials        123      123

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Readme update usage section

This PR updates the README Usage section. I hope that this helps.
The main update is basically a partial revert of 52b4a13. I found it a little hard to follow the README as a new user of babel-eslint that I had to view the version compatibilities between ESLint and babel-eslint in two separate spots of the document. I am unsure whether this PR will conflict with the intent of the commit's author, @hzoo, but hopefully my point of view can be of value to help the experience of new babel-eslint users.
I appreciate the feedback. Thank you.

Trying to close up loose ends on my open PRs. @hzoo do you have any update on the status of this PR? Feel free to close if you do not wish to accept this change. Thank you.

Nah was on vacation at home, thanks!

Thank you @hzoo 😄


Vulnerability roundup 98: hugo-0.79.0: 1 advisory [8.5]

search, files

[ ] CVE-2020-26284 CVSSv3=8.5 (nixos-unstable)

Scanned versions: nixos-unstable: 257cbbcd3ab.
Cc @Br1ght0ne
Cc @Frostman
Cc @kalbasit
Cc @schneefux

Hugo 0.79.1 was merged (now 0.80.0).

Hugo 0.79.1 was merged (now 0.80.0).


CNV 19411: Adding virtualization settings tabs

Signed-off-by: Matan Schatzman<EMAIL_ADDRESS>
📝 Description
Adding virtualization settings tabs - https://issues.redhat.com/browse/CNV-19411
🎥 Demo

/lgtm
:1st_place_medal: :1st_place_medal:

/approve


Add "What is configuration management" page

Description
This PR adds a "What is" page that defines and discusses configuration management.
Checklist:

[ ] I have reviewed the style guide.
[ ] If blogging, I have reviewed the blogging guide.
[ ] I have manually confirmed that all new links work.
[ ] I added aliases (i.e., redirects) for all filename changes.
[ ] If making css changes, I rebuilt the bundle.

One SEO note: "Configuration Management" is the right way to go compared to the shortened "Config Management".  Search volumes are much higher when the word is spelled out.  No changes needed, just wanted to confirm in case anyone was curious.

http://pulumi-hugo-origin-pr-3619-e48116cd.s3-website.us-west-2.amazonaws.com

http://pulumi-hugo-origin-pr-3619-e48116cd.s3-website.us-west-2.amazonaws.com/what-is/what-is-configuration-management/ LGTM


Version 1.0 release

[ ] Upgrade Starlette
[ ] Implement Server-Sent Events for webhook events
[ ] Implement FastAPI pubsub for webhook events
[ ] Upgrade FastAPI
[ ] Fix parallel pytests
[ ] Add back CodeQL analysis .github/workflows/codeql-analysis.yml

Can maybe include: cleaning up of default log levels, and I was wondering about renaming some pods: e.g. governance-ga-agent

Regarding renaming the pods... think we can drop the governance- from all the pods.
Not sure how this might affect the CI/CD and SRE side of things. Maybe speak to Willem first


Add MidMeasureMP C++ implementation

Before submitting
Please complete the following checklist when submitting a PR:

[x] All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
tests directory!

[x] All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running make docs.

[x] Ensure that the test suite passes, by running make test.

[x] Add a new entry to the .github/CHANGELOG.md file, summarizing the
change, and including a link back to the PR.

[x] Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.

Context:
Native-execution of circuits with mid-measurements is enabled via the dynamic-one-shot transform. To support the transform, a device must implement methods to apply MidMeasureMP.
MidMeasureMP is a special kind of operation where a sample is drawn from the state vector probability distribution and a projector is applied to the state vector accordingly. It may also support options like reset and post-selection.
The most straightforward way to deal with the requirements is to enhance the state vector class StateVectorLQubit.
Description of the Change:

[x] Add method to obtain the probability in the z-basis on a given wire.
[x] Add RNG attribute.
[x] Add method to init the RNG attribute with a given seed.
[x] Add method to sample from a binomial distribution.
[x] Add method to collapse the state vector onto a given branch.
[x] Add method which implements the MidMeasureMP workflow.
[x] Add bindings to the MidMeasureMP method.

Benefits:
Possible Drawbacks:
Related GitHub Issues:
Related Shortcut Story:
[sc-57704]

Are we extending the support to kokkos and cuquantum as well?

That's the plan ;)

I left some comments, but mostly questions. It would be great if this new measurement process could be incorporated to the Measurement class. Such implementation of a measurement as part of the state vector is against the design we have in place now.

@vincentmr I was just wondering if moving the new methods to Measurement class would be also beneficial as then we could use its probs() method (it isn't straight forward right now because of the circular dependencies). Are there other design aspects that favors the implementation in StateVector?


feat(oidc): allow for secret csi driver mounts

https://github.com/kiali/kiali/issues/6942
To deploy the token in a scalable and secure manner, we want to leverage the secret CSI drivers backed by secret management tools. The secret CSI driver uses a pod's service account for authorization and will only create the secret when there is a mount requested. However, the kiali helm chat doesn't allow us to add any volume mounts which in turn doesn't trigger the secret creation.
The goal of this PR is to allow a user to add additional mounts and leverage the existing custom_secrets configuration option.

I still need to test this against a CSI Driver, I am just using other deployments to guide the yaml here. Once I test it, I will publish the PR and share some of the evidence.

I still need to test this against a secret csi driver, I am just using existing deployments that leverage the secret csi driver to guide the yaml here. Once I test it, I will publish the PR and share some of the evidence.

❯ vault kv get secret/app/kiali/oidc_secret
========== Secret Path ==========
secret/data/app/kiali/oidc_secret

======= Metadata =======
Key                Value
---                -----
created_time       2024-03-08T18:50:46.321771966Z
custom_metadata    <nil>
deletion_time      n/a
destroyed          false
version            1

==== Data ====
Key      Value
---      -----
kiali    hello from vault kiali

❯ kubectl get secret kiali -o yaml
apiVersion: v1
data:
  oidc-secret: aGVsbG8gZnJvbSB2YXVsdCBraWFsaQ==
kind: Secret
metadata:
  creationTimestamp: "2024-03-08T18:50:50Z"
  labels:
    secrets-store.csi.k8s.io/managed: "true"
  name: kiali
  namespace: cnp-istio
  ownerReferences:
  - apiVersion: apps/v1
    kind: ReplicaSet
    name: kiali-59d9667b5b
    uid: 00ad1a4c-0a49-44ae-bc57-818d1435e459
  resourceVersion: "13121"
  uid: 49012f2c-cefd-4b22-bb29-de59d5befd95
type: Opaque

❯ k get deploy kiali -o yaml | yq '[.spec.template.spec.containers[0].volumeMounts, .spec.template.spec.volumes]'
## volumeMounts
- - mountPath: /kiali-configuration
    name: kiali-configuration
  - mountPath: /kiali-cert
    name: kiali-cert
  - mountPath: /kiali-secret
    name: kiali-secret
  - mountPath: /kiali-cabundle
    name: kiali-cabundle
  - mountPath: /mnt/secrets-store
    name: kiali-secret-csi
## volumes
- - configMap:
      defaultMode: 420
      name: kiali
    name: kiali-configuration
  - name: kiali-cert
    secret:
      defaultMode: 420
      optional: true
      secretName: istio.kiali-service-account
  - name: kiali-secret
    secret:
      defaultMode: 420
      optional: true
      secretName: kiali
  - configMap:
      defaultMode: 420
      name: kiali-cabundle
      optional: true
    name: kiali-cabundle
  - csi:
      driver: secrets-store.csi.k8s.io
      readOnly: true
      volumeAttributes:
        secretProviderClass: kiali-secretprovider
    name: kiali-secret-csi

@rumstead Can you provide simple test procedures so I can manually test this? Doesn't have to mean installing CSI -- I just want to see what you used for the helm values that got the mounts to be defined in the deployment (even if it means without CSI that my deployment doesn't start). A dry-run of helm is fine, too.
I think you are using this for values, but I'm not sure:
deployment:
  custom_secrets:
    csi:
      driver: secrets-store.csi.k8s.io
      readOnly: true
      volumeAttributes:
        secretProviderClass: "kiali-secretprovider"

@rumstead Can you provide simple test procedures so I can manually test this? Doesn't have to mean installing CSI -- I just want to see what you used for the helm values that got the mounts to be defined in the deployment (even if it means without CSI that my deployment doesn't start). A dry-run of helm is fine, too.
I think you are using this for values, but I'm not sure:
deployment:
  custom_secrets:
    csi:
      driver: secrets-store.csi.k8s.io
      readOnly: true
      volumeAttributes:
        secretProviderClass: "kiali-secretprovider"

Sure thing, here is the values.yaml I used called local-values.yaml.
helm template kiali-server -f local-values.yaml
auth:
  strategy: "openid"
  openid:
    client_id: "abc-123"
    issuer_uri:  "https://foo"
    http_proxy: "http://proxy-foo"
    https_proxy: "http://proxy-foo"
    insecure_skip_verify_tls: true
    disable_rbac: true
deployment:
  image_version: v1.76.0
  version_label: v1.76.0
  custom_secrets:
    - name: "kiali-secret-csi"
      mount: "/mnt/secrets-store"
      csi:
        driver: secrets-store.csi.k8s.io
        readOnly: true
        volumeAttributes:
          secretProviderClass: kiali-secretprovider
server:
  web_port: 443
  web_schema: https

Here's a quick test:

Make sure you pull this PR and build the helm charts via make build-helm-charts
Run this command:

helm template \
  --show-only templates/deployment.yaml \
  --set deployment.custom_secrets[0].name=csi-secret-name \
  --set deployment.custom_secrets[0].mount=/csi-secret-mount \
  --set deployment.custom_secrets[0].csi.driver=csi-secret-driver \
  --set deployment.custom_secrets[0].csi.readOnly=true \
  --set deployment.custom_secrets[0].csi.volumeAttributes.secretProviderClass=csi-secret-providerclass \
  kiali-server \
  _output/charts/kiali-server-1.82.0-SNAPSHOT.tgz

Essentially, the values that command passes in are these:
deployment:
  custom_secrets:
  - name: "csi-secret-name"
    mount: "/csi-secret-mount"
    csi:
      driver: csi-secret-driver
      readOnly: true
      volumeAttributes:
        secretProviderClass: csi-secret-providerclass

Examine the Deployment yaml that results and see that it contains the CSI information.

volume mount:
          volumeMounts:
...
            - name: csi-secret-name
              mountPath: "/csi-secret-mount"

volume:
      volumes:
...
        - name: csi-secret-name
          csi:
            driver: csi-secret-driver
            readOnly: true
            volumeAttributes:
              secretProviderClass: csi-secret-providerclass

@rumstead please confirm that test procedure I documented in the previous comment is correct and that it produces what you expect.

@rumstead please confirm that test procedure I documented in the previous comment is correct and that it produces what you expect.

I get the expected output:
        volumeMounts:
...
        - name: csi-secret-name
          mountPath: "/csi-secret-mount"

volumes:
...
      - name: csi-secret-name
        csi:
          driver: csi-secret-driver
          readOnly: true
          volumeAttributes:
            secretProviderClass: csi-secret-providerclass
...

@rumstead I'm doing more testing and I noticed something that doesn't look broken, but I think I will need to document somewhere.
Does the CSI secret configuration support the "optional" field like the normal secret config? I don't think it does (I just tried it and I get validation errors when I try).
In my test procedure - in the helm template command - add --set deployment.custom_secrets[0].optional=true and notice the optional field isn't in the generated yaml (which is expected, because looking at this PR, it doesn't use that field in the if-stmt when csi is defined).
So run this:
helm template --show-only templates/deployment.yaml --set deployment.custom_secrets[0].name=csi-secret-name --set deployment.custom_secrets[0].mount=/csi-secret-mount --set deployment.custom_secrets[0].csi.driver=csi-secret-driver --set deployment.custom_secrets[0].csi.readOnly=true --set deployment.custom_secrets[0].csi.volumeAttributes.secretProviderClass=csi-secret-providerclass --set deployment.custom_secrets[0].optional=true kiali-server _output/charts/kiali-server-1.82.0-SNAPSHOT.tgz

and you don't see the optional field. You can see what happens if you set the optional field on a non-CSI secret by adding these params to that above command:
--set deployment.custom_secrets[1].name=second-name --set deployment.custom_secrets[1].optional=true --set deployment.custom_secrets[1].mount=/second-mount

That results in:
        - name: second-name
          secret:
            secretName: second-name
            optional: true

It does not look like the csi section supports an optional field (like the secret section does).
If that is true, that I should probably change the docs here to say this optional field is ignored/not used when using csi.

After some quick manual testing of my own, this PR is ready to merge as is the operator PR

@rumstead I'm doing more testing and I noticed something that doesn't look broken, but I think I will need to document somewhere.
In my test procedure - in the helm template command - add --set deployment.custom_secrets[0].optional=true and notice the optional field isn't in the generated yaml (which is expected, because looking at this PR, it doesn't use that field in the if-stmt when csi is defined).
So run this:
helm template --show-only templates/deployment.yaml --set deployment.custom_secrets[0].name=csi-secret-name --set deployment.custom_secrets[0].mount=/csi-secret-mount --set deployment.custom_secrets[0].csi.driver=csi-secret-driver --set deployment.custom_secrets[0].csi.readOnly=true --set deployment.custom_secrets[0].csi.volumeAttributes.secretProviderClass=csi-secret-providerclass --set deployment.custom_secrets[0].optional=true kiali-server _output/charts/kiali-server-1.82.0-SNAPSHOT.tgz

and you don't see the optional field. You can see what happens if you set the optional field on a non-CSI secret by adding these params to that above command:
--set deployment.custom_secrets[1].name=second-name --set deployment.custom_secrets[1].optional=true --set deployment.custom_secrets[1].mount=/second-mount

That results in:
        - name: second-name
          secret:
            secretName: second-name
            optional: true

Does the CSI secret configuration support the "optional" field like the normal secret config? I don't think it does. I just tried it and I get validation errors when I try - edit the deployment and add optional: true to the csi field and I see this: # deployments.apps "kiali" was not valid: * patch: Invalid value: "map[spec:map[template:map[spec:map[]]]]": strict decoding error: unknown field "spec.template.spec.volumes[4].csi.optional".
It does not look like the csi section supports an optional field (like the secret section does).
If that is true, then I should probably change the docs here to say this optional field is ignored/not used when using csi.
(update: I added a small blurb in those docs in this commit in the operator PR: kiali/kiali-operator@b8848eb)

yea great catch and shout. I agree, I don't think the csi section supports it since it would be strange to say I want the driver to mount this but optionally. Thanks for adding the optional snippet.


eth/contract: from_file defaults to ContextMixin

From Telegram:

I'm experiencing some strange behavior with from_file. It will default to ContentMixin for certain filenames (without changing the contract content), and have a nil abi, and then will get the proper contract contents for others

@beacoding do you mind sharing one of these files? I would really like to reproduce this.


External monitor using USB-C to HDMI adapter "Not Working"

https://user-images.githubusercontent.com/8538407/212944116-1c925269-255f-4d28-b067-ac54bdc51f73.mp4
Assalamu Alaikum sir, I hope you are well. Again brought a new problem please help. Today I bought a Ugreen type C USB hub which supports HDMI.
Now after installing I see it is not working. Please help me a little.

https://user-images.githubusercontent.com/8538407/213405446-04f278ea-4673-4427-9cb9-3afd0a0859a3.mp4

🤩🤩Yes it worked finally, thank you very much, sir.
I may have disturbed you a lot😅, look at them with a forgiving eye🫣, and be well😘, sir.
 It's nice to talk to you, sir. love 💕 from Bangladesh 🇧🇩


Script Injection via new Incident

It is possible to inject Javascript into the Incident:

This results in the following:

This is a huge security risk as your website is at risk of running unwanted javascript code on visit which could lead to critical security risks!
Please sanitize "<" AND ">" server-side before saving the incident!

Good catch, I thought I already fixed that, turns out I didn't...


h1 break error

Is your feature request related to a problem? Please describe.
H1 error breaking when we use text-style with enable Syllabus ....
Describe the solution you'd like
There is no need of adding ""hyphen:auto ""in this i added a  customized font-size (by their I'd),,,
After  this I  won't get any bug , in any type of the screen
**You can check the error **

Here the link direct link -

https://wecount.inclusivedesign.ca/views/journeys-through-the-digital-innovation-appendix-of-the-master-innovation-and-development-plan/

select the OPEN DYSLEXIC text-style with enable the syallbus feature you get this bug

screenshot

Additional context
I am working on this issue
PLZ VIEW MY PR FOR BETTER UNDERSTANDING this works in all devices plz accept this idea its better then using hypens

This ticket is a subset of #256. Closed.


WIP: Make multiple test products the default

This would enable --test-product to work in general and may have other benefits.

@swift-ci please test

@swift-ci please test

@swift-ci please test windows

We probably need to change test discovery to happen once per bundle? Or we could also slice this in two parts and only enable multiple products on Darwin at first and then track non-Darwin / test discovery separately.


docs: add initial repo metadata

This PR adds the initial repo metadata file described in TRG 2.05.
This info is used to collect information about products contained in Eclipse Tractus-X

HIi @mknoopvw, @pmoscode and @borisrizov-zf,
unfortunately I cannot request review via "Reviewers" section, so here's the ping via comment :)
The issue, that I cannot request review could be, that you are not added as official Tractus-X contributor.
If you want to be added, just leave me a mail with your EF user emails and make sure, the GitHub account is linked in the socials section of you EF account. Then i can add you to the Contributors list and you should receive an invite to a GitHub team with "triage" permissions

@SebastianBezold Thank you very much for your support!
It should be the email-address of this github-account<EMAIL_ADDRESS>


python312Packages.opentelemetry-instrumentation-grpc: fix build

Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[x] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 336903 at 89764642 run on aarch64-darwin 1

2 packages built successfully:

python311Packages.opentelemetry-instrumentation-grpc
python312Packages.opentelemetry-instrumentation-grpc


Moved msft and third party apps to install/uninstall to list

Refactored functions to install/uninstall msft and third party bloat apps. I moved the apps to be removed to two lists underneath the list of functions to be executed.
Advantages

Apps only have to be added/removed in one place
Less lines of code
Less code duplication resulting in being able to change the installation and deinstallation routines more easily

In another pull request i will be adding apps depending on this format.

Nope. See FAQ.

Q: Why are there repeated pieces of code throughout some functions?
A: So you can directly take the function block and use it elsewhere, without elaborating on any dependencies.

Yes, I agree that your PR makes it prettier and more readable, but that's not really the point of the script. The code duplication is intentional. If I want to uninstall a single application, I'll just copy a line from the script and run it. With your adjustment, I can't do that. And I do that pretty often.


CI failing for Windows 3.8 tests

Python version: 3.8
Operating system (windows, osx, ...): Windows
Issue:
The CI is failing more often than not when running the Windows 3.8 tests.
We are seeing pytest workers crash e.g. worker 'gw0' crashed while running 'tests/...
But also an assertion error for the test tests\nlu\classifiers\test_diet_classifier.py::test_set_random_seed. (Potentially unrelated).
Example run: https://github.com/RasaHQ/rasa/pull/7570/checks?check_run_id=1568751659
Attached is an archive with the full logs for this run, plus a text file with just the windows 3.8 tests logs:
logs_57655.zip
windows_3_8_test_logs.txt
Error (including full traceback):
================================== FAILURES ===================================
________________________ tests/core/test_evaluation.py ________________________
[gw0] win32 -- Python 3.8.6 d:\a\rasa\rasa\.venv\scripts\python.exe
worker 'gw0' crashed while running 'tests/core/test_evaluation.py::test_retrieval_intent[data/test_yaml_stories/test_base_retrieval_intent_story.yml]'
____________________________ test_set_random_seed _____________________________
[gw1] win32 -- Python 3.8.6 d:\a\rasa\rasa\.venv\scripts\python.exe

component_builder = <rasa.nlu.components.ComponentBuilder object at 0x0000021F8FFA82B0>
tmpdir = local('C:\\Users\\runneradmin\\AppData\\Local\\Temp\\pytest-of-runneradmin\\pytest-0\\popen-gw1\\test_set_random_seed0')

    async def test_set_random_seed(component_builder, tmpdir):
        """test if train result is the same for two runs of tf embedding"""

        # set fixed random seed
        _config = RasaNLUModelConfig(
            {
                "pipeline": [
                    {"name": "WhitespaceTokenizer"},
                    {"name": "CountVectorsFeaturizer"},
                    {"name": "DIETClassifier", RANDOM_SEED: 1, EPOCHS: 1},
                ],
                "language": "en",
            }
        )

        # first run
        (trained_a, _, persisted_path_a) = await train(
            _config,
            path=tmpdir.strpath + "_a",
            data=DEFAULT_DATA_PATH,
            component_builder=component_builder,
        )
        # second run
        (trained_b, _, persisted_path_b) = await train(
            _config,
            path=tmpdir.strpath + "_b",
            data=DEFAULT_DATA_PATH,
            component_builder=component_builder,
        )

        loaded_a = Interpreter.load(persisted_path_a, component_builder)
        loaded_b = Interpreter.load(persisted_path_b, component_builder)
        result_a = loaded_a.parse("hello")["intent"]["confidence"]
        result_b = loaded_b.parse("hello")["intent"]["confidence"]

>       assert result_a == result_b
E       assert 0.42282572388648987 == 0.42282581329345703

tests\nlu\classifiers\test_diet_classifier.py:387: AssertionError

isn't worker 'gw0' crashed while running the result of the timeout threshold getting hit?

isn't worker 'gw0' crashed while running the result of the timeout threshold getting hit?
Yes probably.


Fix the channels gltf importer uses for metallic and AO textures.

Khronos blender gltf exporter uses red channel for occlusion and blue channel for metallic, whereas the current behavior is the opposite.
Fixes #10700.

For reference, this is the wiki page which specifies the ordering


Tilemap colliders have inconsisent behavior with move_and_slide() Max Angle (see pictures)

Tested versions
Reproducible in: v4.3.dev4.official [df78c0636]
System information
Godot v4.3.dev4 - Windows 10.0.19041 - Vulkan (Mobile) - dedicated AMD Radeon RX 5600 XT (Advanced Micro Devices, Inc.; 31.0.21029.6002) - AMD Ryzen 7 3700X 8-Core Processor (16 Threads)
Issue description
Max Angle as a property for move_and_slide() doesn't work in a very specific condition where a slope doesn't register (and is treated as a wall) unless there is a contiguous collider setup. It's hard to describe in words, but the images should do it justice. Basically--if a slope is attached to a flat "plane", but there is an empty square connecting them, the Max Angle doesn't work. If there is an arbitrary square collider that connects the slope to an existing flat plane it works fine. It's an easy fix in-engine to take into account, but I suspect people will have issues with this in 2D games
In this image the empty square tile of collision is the issue--Max Angle does not work properly--and this slope will be treated as a wall.

In this image, with an added arbitrary square box collider to this tile, max angle DOES work as expected. Without this tile to make the entire tilemap collider a contiguous polygon,  max angle will not work and the incline will be treated as a wall. In tilemaps--all tiles should form a contiguous polygon collider without gaps. This should be made well known in documentation or fixed so that it doesn't matter if the tilemap colliders are contiguous or not.

Steps to reproduce
As per above--just make a tile map with various slope colliders that don't create a contiguous polygon at the vertices
Minimal reproduction project (MRP)
n/a

This isn't specific to tiles so should be documented in the physics tutorials, but I think it shouldn't be surprising that a gap means it's not considered a floor, "mind the gap" as it were

This isn't specific to tiles so should be documented in the physics tutorials, but I think it shouldn't be surprising that a gap means it's not considered a floor, "mind the gap" as it were

I think that's fair. I think the confusion for me stemmed from the tilemap colliders seemingly sharing a pixel vertex at those joins, but when actually seeing them in engine, there's a small imperceptible gap which causes the behavior unless there's another bridging collider to connect them together.

So the screenshot above is exaggerated for effect? That gap is hardly imperceptible

So the screenshot above is exaggerated for effect? That gap is hardly imperceptible

Taken directly from the game running with debug colliders turned on. Because of the debug colliders not necessarily being pixel perfect, the noticeable gap changes based on camera position. In the shot below--it's not noticeable.

I'm not sure if it's a bug per se--and easy enough for me to solve by ensuring there are enough buffer collision boxes to account for this, but figured I'd report it since I was reporting on something else with the dev/beta builds anyway.
I'm working off the assumption that if I manually placed three 2D colliders outside a tilemap system and had them positioned in the same manner, the issue wouldn't persist, e.g.,:

If it's a godot/gamedev standard to assume the example on the right is the preferred way to handle collision work, then that's fine, I was just ignorant of the fact.  Also thanks for responding! I know everyone's busy trying to get 4.3 out!

I think some kind of note could be added to the 2D physics tutorials about gaps and edges, but I'm not sure how it should be worded to be useful

I think some kind of note could be added to the 2D physics tutorials about gaps and edges, but I'm not sure how it should be worded to be useful

Awesome! I agree it's difficult to word/describe, which is why I finally had to draw that graphic lol.
Maybe something similar that just says "For smooth slope movement, ensure your colliders have overlap to account for move_and_slide()'s processing, see image:"
Thanks again! Like I said, this no longer affects me now that I figured it out, but thought it was useful to share. Should I close out this bug report?

Let's keep it open to see how to proceed with further documentation! And you're very welcome thanks for a nice chat!

As an addendum: It still seems to happen sometimes even when I make a contiguous polygon in the tilemap.  Rarer--but still occurs. The issue seems to be with more extravagant angle changes, e.g. moving from a horizontal plane to a 45 degree incline is fine, but if it's closer to 67.5 degrees (even with the slope setting for the chracterbody2d set to 75 degrees)  It will still often get snagged. If I stop moving at this point and then move again, it will work. The general issue is that it doesn't seem to be possible in the referenced build to mimic a Sega Genesis Sonic the Hedgehog slope attachment and smooth movement at angles larger than 45 degrees or angles that the difference between the previous bottom collider and new collider are greater than 45 degrees. I am using a rectangle collider. So honestly it might work better using a capsule like collider. But the expectation is that a simple rect collider would still work unless I completely misread/forgot the documentation.
Sorry for bringing it up again. There are ways I can sidestep the behavior further, but it will involve redesigning some pathways. Which is fine.
Best!


make RepeatStepButton still function even if all steps are run

Hmm, I made it this was on purpose actually... What's the use case for this?

In the TestCase for BeatmapDetails I use a repeat step which changes the fail/retry graph and after that I set the values off it to null which hides the graph. without this the graph couldn't be shown again and I don't want to add an extra step just to show it again

testcases are supposed to be automated.


Premultiplied alpha sprites do not blend correctly

Bevy version
0.8.1
What you did
I've been working on bringing the Spine runtime to Bevy and one of the export options is "Premultiplied Alpha." This is a common rendering technique to solve sampling issues, especially when resizing sprites at runtime. The only requirement to work with premultiplied sprites is to change the blend mode. There's a blend mode exported by Bevy for this exact thing.
What went wrong
The blending is not applied correctly. It is particularly noticeable when overlapping the same color, as a black outline appears. In the screenshot below, the eye is a separate sprite rendered on top of the head.

Additional information
I have created an example repo which not only demonstrates the problem, but also shows a workaround, which might help narrow down the cause.
The workaround is a correction shader which converts the texture into nonlinear space, undoes the premultiplied alpha, converts back to linear space, and multiplies the alpha again.
I've also created an image generation function which can apply premultiplication in either SRGB space or Linear space. Bevy correctly renders a sprite that is premultiplied in linear space, but not in SRGB space.
I've tested these sprites in Unity and a simple webgl example (which I've included in the repo), and Bevy behaves differently than both of them. Note that the html example does set a "premultipliedAlpha" option to true, but this is only so that it can blend with the background, and setting this to false does not affect how the spineboy sprites blend with each other.
All of this seems to suggest to me that the alpha channel of the images are being changed when imported by Bevy. I tried looking into this myself but haven't been able to track down the problem yet.

I've been taking a look into this. Just to note: PNGs should not have premultiplied alpha (source) so the outline you're seeing is behaving "as expected" in that regard.
However, I've done some testing using TARGA files with premultiplied alpha (sorry I can't share them - I'll try to make some that I can share) and there does seem to be an issue with applying the alpha correctly, so there is a bug here I believe.
I suspect that when I track down that issue I might find some related code that could allow your images to work - question is whether PNGs with premultiplied alpha should be supported as this is off-spec, but to my understanding this is something other game engines do allow.

Thanks for looking into it @sbaudlr! Yes, sorry, I should have mentioned I tried other formats than PNG. However, I don't think it's "as expected," at least with my understanding of the problem. My simple WebGL example with these same images blends correctly. I think whatever is causing the problem generally is the same problem with PNG, and there's nothing special that needs to be supported with off-spec PNGs.
If I end up being wrong here, maybe it can be properly addressed with asset preprocessing as mentioned in the Bevy 0.9 release post.

Yeah poor choice of words on my part, it's unsurprising to me that a PNG with premultiplied alpha is not showing correctly.
Your WebGL example works because you're telling WebGL to treat it like premultiplied alpha which makes sense. So far I've convinced myself that webgpu is not at fault, neither is anything after the material is created (I could be wrong though!). Which points in the direction of the asset loading being at fault. Could be something to do with converting the image into the format the bevy_render wants material textures to be in that's specific to loading from images rather than generating color procedurally like in your example.
Speaking of which, the reason the LINEAR option in your example works whereas SRGB doesn't is because you must apply alpha in linear color space - before gamma correction.

Your WebGL example works because you're telling WebGL to treat it like premultiplied alpha which makes sense.

I'm telling Bevy to treat it as premultiplied alpha too. I'm only mentioning it because in all my reading of the topic, the only requirement for PMA is to set the proper blend mode. I understand that the conversion between SRGB and Linear which happens throughout the rendering process complicates things. To be honest, that's the most confusing part for me when trying to hunt this down myself.
If you are referring to the premultipliedAlpha setting in WebGL, setting it to true allows proper blending with the background, and has nothing to do with how the sprites blend with each other, nor how the images are imported. The images still blend correctly (with each other) if the value is false.

Could be something to do with converting the image into the format the bevy_render wants material textures to be in

Yes, I think this as well!

Aye, your WebGL example is what originally convinced me that it must be during loading, if a premultiplied image makes it to render-time unscathed then it works 😄

I think I know part of what's going on.
So, images in bevy are converted to linear color before being loaded onto the GPU, which is correct as far as color manipulation is concerned. If I change this hard-coded (boo) value from true to false in image_texture_loader then I end up with this result:

The alpha blending has produced the right result (no more border around the eye texture). However, because we lied to bevy and told it that a gamma-corrected image should be treated as linear color, bevy has then applied gamma correction to the result, resulting in everything looking washed out - most notably the hair.
This works for the same reason that the WebGL example works: no gamma adjustment is being made before compositing the two images - which brings me to the issue.
As your corrected shader demonstrates, the alpha has been pre-multiplied in the source image after gamma correcton has been applied. This is not correct, it must be done before gamma correction for exactly the reason that is demonstrated here.
Bevy converts your image to linear space for compositing, which also manipulates the alpha-multiplied pixels. This means that when the linear-space images are composited together, the compositing is performed on "darkened" pixels. If the alpha is applied before gamma correction, then the right alpha value is maintained when the image is brought back to linear space.
To prove this to myself, I wrote some code that:

Loads your image.
Divides by alpha in gamma-corrected space.
Converts your image to linear space.
Applies the alpha.
Applies the gamma curve.
Saves the corrected image as a new file.

If I load this new version of the asset into your example (with no modifications to bevy) then the "vanilla" version looks correct! And you can see the "corrected" version now looks overblown:

I don't know why this works in Unity / Unreal, perhaps they are compositing the images in gamma-corrected space? I would hope not...
Likewise, WebGL is perfectly happy to just do the maths you've told it to because it trusts that you're feeding it the right kind of data.
As for the issues I have been seeing, they look to me like scaling issues - scaling images with pre-multiplied alpha is tricky. But notably the artifacts caused are small white lines, rather than dark lines, which is a pretty good indicator for them being caused by a different category of premultiplied alpha bug - so I'll look into that and open a separate issue if I find anything of interest there.
I'd be interested to know what process you're using to generate the premultiplied image? It could be that switching the order of two steps is all that's needed. But I don't think this is an issue with bevy, other than maybe there not being a way to perform compositing in gamma-corrected space (again, compositing should always be done in linear space!)
Apologies for the long-winded write-up, I wanted to show my entire thought process because I could be wrong! Maybe you can spot a flaw in my process?

Thank you for the writeup. I mostly agree with you and I've done a lot of these same steps in trying to hunt down the problem, but ran into the same confusion as you: why does this work in other engines and WebGL?
If the answer really is: everyone is doing it wrong and Bevy is doing it right, then I'm happy to accept that. For my purposes, I want bevy_spine to work without any hassle. Certainly not introducing an extra step to fix the images like you had to. Currently my fix is the shader hack but I can probably find a better solution (like automating those fixes you did when importing images for spine, rather than at runtime in the shader).

I'd be interested to know what process you're using to generate the premultiplied image?

I'm using Spine which creates a sprite atlas and has an option for premultiplied alpha. Maybe there's another setting in here that I should be using? But, this is the default, and given the popularity of Spine I assume they're doing it correctly. I acknowledge that might be a bad assumption.

As for the issues I have been seeing, they look to me like scaling issues - scaling images with pre-multiplied alpha is tricky.

I'm not sure what you're referring to here, but it was my understanding that premultiplied alpha makes scaling images more accurate. It's the problem that PMA fixes since scaling non-PMA images is problematic.

Suggestion: Now that Bevy asset V2 has landed, it should be possible to make "premultiplied alpha" a configuration parameter for the image loader, which could either be specified directly in code for a given asset handle, or in an associated .meta file for that asset file.
This doesn't address the issue of whether premultiplied alpha is valid for PNG, but it would let you punt on the issue by overriding the default behavior.


v3. Delegate page. Apply fonts and CSS details

[x] REDELEGATION: Check if another redelegation is in progress

[x] Font at "Memo (Optional)"

Fonts applied

I'm going to turn this issue into a "feature required"

My bad, new test show that it was fixed. I close the issue because the FONTS are also applied


The Percentage code coverage is more as compare to Xcode coverage percentage.

I'm using xcov with fastlane but the percentage coverage showing is more as compare to Xcode coverage percentage.
xcov version: 1.4.2

Hi @sandeee1928
This issue was fixed recently. Upgrade to ‘1.4.3’ and you should get the same coverage as Xcode reports.


AttributeError: 'LlamaAWQForCausalLM' object has no attribute 'config'

Hello guys,
I am trying to use AutoAWQ instead of GPTQ. I am using transformers pipeline to run some 'text-generation' task, but I am getting following:
/.local/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1695, in getattr
raise AttributeError(f"'{type(self).name}' object has no attribute '{name}'")
AttributeError: 'LlamaAWQForCausalLM' object has no attribute 'config'

Can you show me the code that you are using?

...
from transformers import pipeline, AutoTokenizer
from awq import AutoAWQForCausalLM
model_name_or_path = "TheBloke/WizardLM-33B-V1.0-Uncensored-AWQ"
model = AutoAWQForCausalLM.from_quantized(model_name_or_path, fuse_layers=False, max_memory={0: "23GIB"},
trust_remote_code=True, safetensors=True)
tokenizer = AutoTokenizer.from_pretrained(model_name_or_path, trust_remote_code=True)
TOP_K = 1
TOP_P = 0.01
REPETITION_PENALTY = 1.15
MAX_NEW_TOKENS = 1024
TEMPERATURE = 0.01
pipe = pipeline(
"text-generation",
model=model,
return_full_text=True,
tokenizer=tokenizer,
do_sample=False,
early_stopping=True,
streamer=None,
repetition_penalty=REPETITION_PENALTY,
max_new_tokens=MAX_NEW_TOKENS,
temperature=TEMPERATURE,
top_p=TOP_P,
top_k=TOP_K
)
and it is failing on construction of pipe.

Try to do model=model.model instead


[models][RPi] Segfault when unloading obj file (Exiting the program)

Issue description
I have made low poly scooter model in Blender 2.8 which is then exported as OBJ file and loaded using  examples/models/model_obj_loading.c provided in Raylib repo. Now when I run the program it runs perfectly renders the obj model properly, but I get segmentation fault when esc button is pressed for terminating the program, specifically it occurs when unloading the model.
Apparently segfault seems to occur when the OBJ file is made from multiple objects in Blender. But I don't get segfault at exit, if each part of scooter viz. handle, body, seat, wheels etc. are joined (Ctrl+J) as one single object before exporting as obj.
NOTE: I am using same texture image png file for both obj file
I have attached source and resources here
Environment

Platform : Raspberry Pi 3B+
Operating System : Raspbian GNU/Linux 9 (stretch)
OpenGL version   : OpenGLES 2.0

Issue Screenshot
Following is  screen shot of segfault at exit when vespa1.obj

Following is  screen shot when vespaJoined.obj file is loaded NO segfault when exiting

Code Example
#include "raylib.h"

int main()
{
    // Initialization
    //--------------------------------------------------------------------------------------
    int screenWidth = 800;
    int screenHeight = 450;

    InitWindow(screenWidth, screenHeight, "raylib [models] example - obj model loading");

    // Define the camera to look into our 3d world
    Camera camera = { 0 };
    camera.position = (Vector3){ -8.0f, 2.0f, 8.0f };    // Camera position
    camera.target = (Vector3){ 0.0f, 2.5f, 0.0f };      // Camera looking at point
    camera.up = (Vector3){ 0.0f, 1.0f, 0.0f };          // Camera up vector (rotation towards target)
    camera.fovy = 45.0f;                                // Camera field-of-view Y
    camera.type = CAMERA_PERSPECTIVE;                   // Camera mode type

    Model model_bike = LoadModel("resources/vespa1.obj");                 // Load OBJ model_bike
    Texture2D texture = LoadTexture("resources/vespa1.png"); // Load model_bike texture
    model_bike.materials[0].maps[MAP_DIFFUSE].texture = texture;                 // Set map diffuse texture
    Vector3 position = { 0.0f, 0.0f, 0.0f };                                // Set model position

    SetTargetFPS(60);   // Set our game to run at 60 frames-per-second
    //--------------------------------------------------------------------------------------

    // Main game loop
    while (!WindowShouldClose())    // Detect window close button or ESC key
    {
        // Update
        //----------------------------------------------------------------------------------
        //...
        //----------------------------------------------------------------------------------

        // Draw
        //----------------------------------------------------------------------------------
        BeginDrawing();

            ClearBackground(RAYWHITE);

            BeginMode3D(camera);

                DrawModel(model_bike, position, 1.0f, WHITE);   // Draw 3d model with texture

                DrawGrid(10, 1.0f);         // Draw a grid

                DrawGizmo(position);        // Draw gizmo

            EndMode3D();

            DrawText("(c) Castle 3D model by Alberto Cano", screenWidth - 200, screenHeight - 20, 10, GRAY);

            DrawFPS(10, 10);

        EndDrawing();
        //----------------------------------------------------------------------------------
    }

    // De-Initialization
    //--------------------------------------------------------------------------------------
    UnloadTexture(texture);     // Unload texture
    UnloadModel(model_bike);         // Unload model

    CloseWindow();              // Close window and OpenGL context
    //--------------------------------------------------------------------------------------

    return 0;
}

@RowV Thanks for the detailed report! I'll look into it as soon as possible.

Issue corrected on commit https://github.com/raysan5/raylib/commit/5a1a0a34923fa8ecfcd5d45717b7db63f630b2a7.
Multi-mesh loading is not properly implemented just yet. Current implementation loads all objects in a single mesh.


pass vs pipeline validation

sg_apply_draw_state() must check:

if pipeline mrt_count matches pass number of color attachments
if pipeline color_format matches pass color attachments pixel format
if pipeline depth_format matches pass depth format
if pipeline sample count matches pass attachment sample count

this is fixed now in the new validation code


Question: How can I set a cookie on Serverless Functions?

I'm trying to send a Set-Cookie header without success. I followed this sample on docs (https://zeit.co/docs/v2/serverless-functions/introduction/#an-example-node.js-serverless-function)
res.json({
    body: {
      user
    },
    headers: {
      'Set-Cookie': cookie.serialize('secret', token.secret, {
        secure: process.env.NODE_ENV === 'production',
        httpOnly: true,
        path: '/',
        maxAge: oneWeek
      })
    }
  })

But when I do that the body and header are sending as payload:

res.setHeaders works good for my purpose but seems the doc is wrong.


Inconsistent credential timeline views

Found in:

87c6bd423f537231d36ffa8ae8c26f91247f3b9f

Example data:

https://orgbook-test.pathfinder.gov.bc.ca/en/organization/registration.registries.ca/BC0337062

Observed:

The credential timelines are not rendered in a consistent manner.

Expected:

The credential timelines are rendered in a consistent manner.

On the Organization page the credential timeline is displayed like this:

If you view any of the registration credentials for the corp you see the credential timeline is displayed like this:

BC0337062

These pages are populated by two different back-end services.
For the company page:
http://localhost:8080/api/topic/64/credentialset
... which has no details for the topic's credentials
For the credential page:
http://localhost:8080/api/credential/145/formatted
... which has a local_name attribute and attribute details ...
I'll check the topic credentialset api and see what's involved to add the necessary attributes.

Added name info to credentials returned from the topic credentialset api.
Note - this info was removed during the performance improvements done recently, so adding this data back (required by the UI) may have a performance impact.

Resolved in 25c1c3a0b961ab4a0b82bd18b0ce0778a1d9bb18
Verified the credential timelines are rendered consistently.
Organization page:

Registration page:


Final deployment

Once we are ready for deployment to production we will need to adjust the deployment scripts to enact that.
Once issue that we will need to think about is that if we put the scrapers and la-metro-councilmatic on separate servers (as we should), then we will need to set up the database so that more than one server can connect with it.
RDS may be a good solution for this, we could also have the db be on one server and expose a port to the other server.

I have configured the database server on the new Metro server to allow inbound connections from the OCD server.
Remaining tasks:

[ ] Update the scraping scripts to populate the OCD API, as well as the Metro database
[ ] Update the Metro ETL scripts to run on staging once a day and production every 15 minutes
[ ] Before final cut over, migrate identifiers one final time
[ ] Update staging and production domains https://github.com/datamade/la-metro-councilmatic/issues/520#issuecomment-580892852

More to come, surely.

A new instance has been set up at https://lametro-upgrade-prod.datamade.us. We'll need to do the remaining items in https://github.com/datamade/la-metro-councilmatic/issues/523#issuecomment-598405869 prior to launch, but they shouldn't take too long. I expect to see full data in the new instance later this evening, once the full scrape runs.


Modify the code, compatible with java8, please use java compile push …

Modify the code, compatible with java8, please use java compile push package maven center

please review code

Hello, I don't want to use java 8 in the project.
I've created a Java 8 branch, if you want to reopen your PR against that branch I can merge the changes and deploy with the CI.
BR


Adding contributing file

Add the contributing file provided automatically, but with a newline at the end:)

Closing, will use the original one created by the bot instead.


GSoC 2020 Proposal

Hello everyone! This is Zejin Xu from Beijing China, finishing 4th year at China University of Mining and Technology as an undergraduate.
I read the book Netty in Action last year and learned to utilize Netty as the underlying transport for my tiny RPC framework, which helped me get my internship. It is exciting to see Netty in this year’s GSoC. When I looked at your project list, I am thrilled by the idea that I may contribute to Netty too!
I’m interested in the second idea from the project list: Regression test suite. I did a lot of CI work in Jenkins as I started my internship. I like the idea of adding performance regression test as part of PR validations.
As of now, I have cloned locally and browsed the code base of Netty, but found little document on project’s CI process, except this one on Netty’s microbechmarks. I’d appreciate it if anyone can guide me more on this task.
I browsed the possible tools listed in Related Resources, and I would also propose to use the native Java tool Metrics, which is more lively developed and has a large community. It could provide with us finer-grained control over what kind of metrics do we want with various features like histograms. Also, I think it may make it easier to generate trend graphs.
I’m new to open source development, please correct me where I am wrong ;) Looking forward to your reply!

Sorry for the late response...
At the moment we use a self-hosted Jenkins installation that uses docker to run the jobs (see the docker files). For the task we basically look just for a way to run a set of benchmarks via CI and somehow build up report about values that changed since the last run and which changes were applied. This for example would include numbers like allocations, GC CPU time, throughput etc.

Hi Norman, never mind, thanks for the information! These days I have gone through and roughly understood the Docker part of CI process. Next I will try to come up with runnable demos of some of the regression tests.

Please share the proposal via google docs once you have it written so we can have a look.

Thanks for the reminder, I'm working on it.

Hi, this is my draft of GSoC proposal, sorry to have finished it just before DDL... Link to proposal - Add Regression Testsuite to Netty
Please leave your comments, your feedback is valuable to me.
Thanks.

Let's close this... the students were selected for GSOC


Working with Tables and Views using Apache Zeppelin

0_DATA: 3 first scripts run fine but then I got the following error:
spark.vora interpreter not found

Hi,
Which Vora flavor (CAL, OVA...) and version are you using?
Thanks
@bdel

SAP_HANA_Vora_developer_edition_1.3.ova
From: Abdel Dadouche<EMAIL_ADDRESS>Sent: Wednesday, May 3, 2017 17:11
To: SAPDocuments/Tutorials<EMAIL_ADDRESS>Cc: Tabak, Ami<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [SAPDocuments/Tutorials] Working with Tables and Views using Apache Zeppelin (#1640)
Hi,
Which Vora flavor (CAL, OVA...) and version are you using?
Thanks
@bdelhttps://github.com/bdel
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/SAPDocuments/Tutorials/issues/1640#issuecomment-298922329, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AU_F1y73HXCS1wqWlu27BQyf1Th_Qxhhks5r2IrYgaJpZM4NFwrn.

Please check if you are getting this error with the newest dev. edition. Thanks.

Thank you for your feedback. We haven't heard from you in the past 30 days, so we are closing the issue.
If you still have questions, feel free to reopen the issue.


Add monitoring tools from utils node

Adds a script which calculates the number of instances of each flavor can be created
Openstack service status into influx
QUota changes into influx

How does one 2to3?

I am actually going to make another quick change to this

see #127 for refactored version of this code


build: turn off persisting credentials again

What:

Turn on persisting credentials when checking out repo during release.
Why:

It seems to be necessary after all.
How:

n/a
Checklist:

[x] PR small as possible
[x] Codebase consistent
[x] TypeScript definitions updated
[x] Tests and linting
[x] Ready to be merged

:tada: This PR is included in version 3.0.2 :tada:
The release is available on:

GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:


Cannot find module 'hexo-util' in /next/script/tags/exturl.js

Expected behavior (预期行为)
var util = require('hexo-util');
Actual behavior (实际行为)
but you don not provide the module in the repository , than i need to install it again

Could you please provide the following information?

Node.js and NPM version
Hexo version
Your site package dependencies

@iissnan
hexo-cli: 1.0.1
os: Windows_NT 10.0.14393 win32 x64
node: 6.9.2
npm: 3.10.9

the main package dependencies hexo-util ,when i meet this problem then i install the dependency

According to the NPM package installation algorithm, hexo-util (with other hexo plugin like hexo-fs) should be installed just in your "Blog/node_modules" directory, you don't have to specify hexo-util explicitly.
Could you please delete the hexo-util dependency in the package.json and Blog/node_modules directory, then reinstall all dependencies?

@iissnan ,thanks for your help and patience, i build another folder, use hexo init, i found it in the node_modules, maybe  create the folder for a long time.

You are welcome.
For those who also encounter this issue, please check your NPM version.

> 3: Still not work. Please remove node_modules directory and reinstall using npm install.
< 3: Please add hexo-util explicitly via npm install --save-dev hexo-util to you site package deps.


Terminal control characters are not always escaped safely

Not sure whether or not this is considered a feature or a bug, but in certain scenarios, terminal escape chars are interpreted as-is, and in other they're escaped into string form.
package main

import (
	"context"
	"os"

	"cdr.dev/slog"
	"cdr.dev/slog/sloggers/sloghuman"
)

func main() {
	ctx := context.Background()
	log := slog.Make(sloghuman.Sink(os.Stderr))
	log.Info(ctx, "test1\r\nw\reird\a")
	log.Info(ctx, "test2", slog.F("boop", "hello\r\nb\rell\a"))
	log.Info(ctx, "test3\r\nt\rest", slog.F("boop", "hello\r\nb\rell\a"))
	log.Info(ctx, "test4", slog.F("clipboard", "\033]52;c;surprise!\a"))
}

// Output:
2022-11-10 18:10:11.256 [INFO]	<main.go:18>	main	...
  "msg": test1
eird     w
2022-11-10 18:10:11.256 [INFO]	<main.go:19>	main	test2 ...
  "boop": hello
ell       b
2022-11-10 18:10:11.256 [INFO]	<main.go:20>	main	...	{"boop": "hello\r\nb\rell\u0007"}
  "msg": test3
est      t
2022-11-10 18:10:11.257 [INFO]	<main.go:21>	main	test4	{"clipboard": "\u001b]52;c;surprise!\u0007"}

Pretty printing \r\n seems intended and like a nice feature (since it's aligned), but stray \r and also \a are interpreted as-is. The latter (\a) will also ring the terminal bell which I would venture is never the expectation.
Out of these 4 cases, only the clipboard case behaved as I would expect.

This is working as intended. sloghuman prints the msg directly to the terminal without any encoding. The fields are JSON encoded.
This means you can put your own colors in the msg or you can add newlines and have multiline messages.
And if a field is multiline but the msg is not, then that field is printed directly to the terminal too. This is how stacktraces in from the xerrors package are printed.
I think it'd be ok if we add another rule here where if a given msg/field contains any undisplayable character, then it is printed via strconv.Quote instead.

Thanks for clarifying @nhooyr. I can definitely understand the use-case for allowing colors in the terminal and I can totally relate to wanting to keep the logic of sloghuman simple.
If we focus on just the message part, I still see the following discrepancy in the behavior:
log.Info(ctx, "test1 \x1b[38;5;204mRed\x1b[0m")
log.Info(ctx, "test2 \x1b[38;5;204mRed\x1b[0m\r\n")
log.Info(ctx, "test3 \x1b[38;5;204mRed\x1b[0m\r\nhello")

Both test1 and test2 don't allow for the color to propagate and in test2 we also lost the newline (for better or worse). If the idea is to support colors, I think it should apply to test1 and test2 as well.
With regards to fields, there I can see a use-case for pretty printing the newlines, but I feel like all control characters should be encoded because a user could easily be logging data from any kind of source.
Let's take the following silly example:
log.Info(ctx, "important1")
log.Info(ctx, "important2", slog.F("malicious content", "erase\n\x1b[2K\x1b[1A\x1b[2K\x1b[1A\x1b[2K\x1b[1A"))
log.Info(ctx, "not important")

// Output:
❯ go run main.go 2>&1 | tail -f
2022-11-11 16:01:44.342 [INFO]	<main.go:36>	main	important1
2022-11-11 16:01:44.342 [INFO]	<main.go:38>	main	not important

The malicious content managed to hide itself from the logs when viewed by an unaware admin. Obviously the data is still in the log, but easily missed by common viewing strategies.
Likewise, we could use this trick to put a dangerous command in the users clipboard:
// $(echo echo rm -rf / | base64)
log.Info(ctx, "hello", slog.F("clipboard", "innocent\n\x1b[1A\x1b]52;c;ZWNobyBybSAtcmYgLwo=\a"))
// clipboard now contains "echo rm -rf /\n"

I think it'd be normal for a user to expect that potentially "dangerous" inputs are encoded, especially when they're only occasionally interpreted as-is.

Good examples! I'm actually not sure why your test2 example there didn't print directly. It should have with the newline. Super weird, must be a bug for sure.


New version?

https://github.com/amoffat/sh/compare/1.14.2...develop shows 48 commits since last release.
Do you have any plans to make new release soon? 😋

Hey thanks for the heads up 😅  I will make time to do a release this weekend and close this issue when it's done.


Build CCJ Tumbler

[x] NOTIFICATION new-phase
[x] GET /api/v1/tumbler/status
[x] POST /api/v1/tumbler/inputs
[x] GET /api/v1/tumbler/input-registration-status
[x] POST /api/v1/tumbler/connection-confirmation
[x] POST /api/v1/tumbler/output
[x] GET /api/v1/tumbler/coinjoin
[x] POST /api/v1/tumbler/signature

Can you check the logic around this line in TumblerController.InputsAsync:
if (txOutResponse.Result.Value("confirmations") <= 0)
...etc
It looks like the exception is only thrown if both conditions are met whereas it seems that it should throw if either one or both are met.

In TumberController.Status:
I think using:
Version = "1"
instead of
Version = "v1"
would be better as we can do > checks within the client easier.

In TumblerController.CoinJoin we currently throw an exception if Alice has already asked for the CoinJoin transaction.
Would it not be ok to let an Alice request this > once?
What if their client quits during the process for some reason? We could make it possible to restart the client, reload the guid (assuming we have saved it locally) and rejoin the CoinJoin at the signing phase.
... just an idea.

@wintercooled The logic is good, my comment was not clear. I modified the comment.
The point is, if the input registered is unconfirmed, then it's only acceptable if it's part of a previous successful CoinJoin.
// Check if inputs are unconfirmed, if so check if they are part of previous CoinJoin
if (txOutResponse.Result.Value<int>("confirmations") <= 0)
{
	if (!Global.CoinJoinStore.Transactions
		.Any(x => x.State == CoinJoinTransactionState.Succeeded && x.Transaction.GetHash() == op.Hash))
	{
		throw new ArgumentException("Provided input is not confirmed, nor spends a previous CJ transaction");
	}
}

Version = "1"

Ok, I was thinking of this myself, too. Fixed.


fix: clean string if it contains double slashes

Running query like
['k8s-logs-prod']
| limit 1

over the last year,
will fail with the following error

omitting this column by doing
['k8s-logs-prod']
| project-away  ['data.client\\.id']
| limit 1

will work as expected
after debugging I found out that this is the response coming from the API
{
    ...
    "matches": [
        {
            ...
            "data": {
                "data": {
                    "client.id": null
                }
            }
        },
    ],
    "request": {
        ...
        "project": [
            {
                "field": "data.client\\.id",
                "alias": "data.client\\.id"
            }
        ],
        ...
    },
    ...
}

even in the frontend, it looks weird, probably a bug in the response

Might be the cause to what's happening to Aptos

That's a feature actually, we ingest JSON and flatten it, this object (js notation):
{foo: {bar: "qoo"}}

gets flattened into a single column: foo.bar
But of course object keys can have dots in them:
{"foo.bar": "qoo"}

we flatten this into foo\.bar, to be able to distinguish from the first case.
ENOTABUG

@a-khaledf see #28 for my proposed fix


autoClose does not trigger detach event

Reproduction
Use StackBlitz to reproduce your issue: https://stackblitz.com/edit/components-issue-t4rpku
Steps to reproduce:

Check isOpen
Scroll down
Overlay is detached but "detached" is not console logged

Expected Behavior
Overlay should detach and call detach event when user scrolls away if reposition scroll strategy with autoClose option set to true is used
Related pull request: https://github.com/angular/components/pull/8233
Actual Behavior
Overlay is detached while detach event is not being called
Environment

Angular: 8.2.12
CDK/Material: 8.2.3
Browser(s): Chrome
Operating System (e.g. Windows, macOS, Ubuntu): macOSX/Ubuntu

This should be fixed by a PR that was opened a while ago: #7950. @jelbourn do you remember if there's a reason why we never ended up merging that PR?

Is this still in limbo? Issue is still existing

Um.... bump?


Standardize asset group and asset module names

PR Overview

Made sure that modules and asset group names use our existing data source short codes wherever possible (eia860, eia923, ferc1, eia_bulk_elec, epacems, etc.)
Split "output_assets" into denormalized_assets and analysis_assets.  These are still placeholders, but I think we'll want to differentiate between those categories since what's inside them is pretty different (simple combinations of other tables vs. complex, novel derived values).
Removed the _assets suffix from all the asset groups. I think it will be clear from the context that these identifiers are being used in that they pertain to asset groups. I could be convinced otherwise though.
Split EIA assets into "raw" "clean" and "norm" (normalized) groups. Split the pre-harvesting EIA groups by original data source (eia860 vs. eia923)
I think there's a bunch of unnecessary tangling of dependencies inside the eia_transform function that we should untangle, but not right now.
I tried and failed (again) to find a way to grab all the asset keys for assets by asset group (without running into circular import issues) and so ended up enumerating the individual EIA-860 and EIA-923 input assets for the eia_transform function. This let me split the raw & clean EIA assets out into their own groups and seemed more readable. It also removed some top-level definitions that would have been globally accessible, and moved all of the asset group definitions into the pudl.etl module.
I noticed that the censusdp1tract database doesn't seem to show up as a resource or an asset anywhere. Should we add that to keep things uniform? It only has 3-4 tables, so maybe each of them can be its own asset? Or should it be analogous to the FERC 1 DBs?

PR Checklist

[x] Merge the most recent version of the branch you are merging into (probably dev).
[x] All CI checks are passing. Run tests locally to debug failures
[ ] Make sure you've included good docstrings.
[ ] For major data coverage & analysis changes, run data validation tests
[ ] Include unit tests for new functions and classes.
[ ] Defensive data quality/sanity checks in analyses & data processing functions.
[ ] Update the release notes and reference reference the PR and related issues.
[ ] Do your own explanatory review of the PR to help the reviewer understand what's going on and identify issues preemptively.

Thanks for standardizing these asset group names! Left a couple of comments.