Upgrade kops to 1.13, add kops-1.12 package

what

[kops] Upgrade 1.12.1 -> 1.13.0
[kops-1.12] Create kops-1.12 package starting with kops 1.12.3
[helm] Update 2.14.1 -> 2.14.3
[helmfile] Update 0.80.1 -> 0.81.0

why

kops 1.13 needed to use Kubernetes 1.13
maintain kops updates for people who want to stay on 1.12 track.
track latest changes
track latest changes

I though kops is backwards compatible.
https://github.com/kubernetes/kops/blob/master/README.md#kubernetes-version-support

kops is intended to be backward compatible. It is always recommended to use the latest version of kops with whatever version of Kubernetes you are using. We suggest kops users run one of the 3 minor versions Kubernetes is supporting however we do our best to support previous releases for a period of tim

I though kops is backwards compatible.

It is backwards compatible, but now they are developing multiple streams in parallel, so 1.13.0 might have bugs that 1.12.3 does not, so people using k8s 1.12 may prefer to stick to 1.12.3.


execution.py Popen stdin fix broken again in Maya 2022 Python 3

The issue addressed in pull request #462 is broken again in Maya 2022 using Python 3. The problem appears to be that now sys.__stdin__ returns None which breaks the exception handling at line 60.
This seems like a Python 3 issue as Maya 2022 using Python 2 does not produce the same problem.
The Python 3 documentation advises that:

Under some conditions stdin, stdout and stderr as well as the original values __stdin__, __stdout__ and __stderr__ can be None. It is usually the case for Windows GUI apps that aren’t connected to a console and Python apps started with pythonw.

This was a little while ago, but I believe it would have been 2.91. The issue does seem to have been fixed in the meantime.


Add button link to Open-Source page

Changes proposed

Add a button link in the landing page community section.
This button navigates to the Open-Source projects page.

Screenshots

New Recording - 10_14_2022, 9_25_21 PM.webm
Note to reviewers

Code of Conduct

[x] By submitting this pull request, I confirm I've read and complied with the CoC 🖖

Check List (Check all the applicable boxes)

[x] My code follows the code style of this project.
[ ] My change requires changes to the documentation.
[ ] I have updated the documentation accordingly.
[x] All new and existing tests passed.
[x] This PR does not contain plagiarized content.
[x] The title of my pull request is a short description of the requested changes.

You can also join our Discord community.
Feel free to check out other cool repositories of the Thecyberworld.
Join the Thecyberworld GitHub Organisation by raising an issue (you will be sent an invitation).

I think you have included a jobs page too.

Want to give a suggestions
when ever you are working on different issues?
always create new branches from the main branch
this branch is containing everything you are changing.

Want to give a suggestions
when ever you are working on different issues?
always create new branches from the main branch
this branch is containing everything you are changing.

Alright, I've noted that. Thank you.
Is there anything I need to do?

See, you pr containing these things,

store these data, somewhere else
go to your forked repo
fetch the data.
create a new branch, do changes, and send the pr here.
then go to you forked branch, fetch data, and create new branch, work on that and send that pr
everytime you going to create new branches, previous changes that you have made, are not going to be there, until we merge that, so no need to worry about that.

See, you pr containing these things,
store these data, somewhere else
go to your forked repo to fetch the data. create a new branch, do changes, and send the pr here. then go to you forked branch, fetch data, and create new branch, work on that and send that pr
everytime you going to create new branches, previous changes that you have made, are not going to be there, until we merge that, so no need to worry about that.

This is quite confusing @kabir0x23
Even for the Job/Internship page, I'm working on, I created a branch from the main but it still has these commits too.
I'll try to do what you asked though. Thank you.

First fetch the new data:

yourbrach is too old now
!st you was working on jobs page.
Then i think, you created a new branch from the job branch instead of the main branch
so all of the jobs data came along with that branch

let me fix the code.

let me fix the code.

Thank you very much @kabir0x23
Before I make a PR from the jobs branch, I'll make sure it doesn't have these issues.

Thank you very much @kabir0x23
Before I make a PR from the jobs branch, I'll make sure it doesn't have these issues.

If you face any issues, let me know 😄


Add new warm-up events

(Thanks for sending a pull request! Please fill in the following content to let us know better about this change.)
Types of changes
Please put an x in the box that applies

[ ] Bugfix
[ ] New feature
[ ] Refactoring
[ ] Breaking change (any change that would cause existing functionality to not work as expected)
[ ] Documentation Update
[x] Other (new static pages)

Description
Add more existing warm-up session events
Steps to Test This Pull Request
Go to the warm-up session page and its sub-pages to check the contents.
Expected behavior
The event and its info has been added in both zh and en version.
More Information
expected screenshots

Suggested Following Up (optional and nice to have) Items
We may ask for the speaking to create pull requests to add their own self-introduction. Besides, I really like to use the website as a event archive/museum!

Codecov Report

Merging #837 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #837   +/-   ##
=======================================
  Coverage   76.37%   76.37%
=======================================
  Files          70       70
  Lines        2688     2688
=======================================
  Hits         2053     2053
  Misses        635      635

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ade9e8...aaa57b9. Read the comment docs.


Updated the web page of the application

Updated the web page of the application and removed unnecessary print statements in app.py file

Updated the templates and static folder which contain index.html and index.css file. Static folder contains the images used in web page.  Also removed the unnecessary print statements which were commented in app.py file.

Okay


OCPBUGS-32632: Improve Pipeline list page performance

Static plugin PR - https://github.com/openshift/console/pull/13842

/cherrypick release-v1.15.x


Combine 2 record sets

When two RecordSets derive from the same table, you should be able to combine them like python sets. I find often want to do this for recursive lookups/dependencies between records of the same table.
At least when I do recursive lookups, I need a column to input parents and another for children (just so I can add records from either record). Then, I create another column finding children of the current record (by looking for other records that mark it as a parent). All this works fine (and I do the same the other direction). The nuisance is that then I need to combine manually input children with the derived children into a single total children column for other calculations and there is no simple way to directly aggregate RecordSets. I get that it wouldn't work if we have to span multiple tables, but that would be a simple error to implement for the class method.
BTW, I'd love to build this myself so long as there's interest from the maintainers. I want to make sure it doesn't violate any core philosophies of the project.

The best way I found currently is to trick it into returning a simple list of records first with something like:
set($myChildrenRefListColumn).union($myParentsRefListColumn)

... and even then, I only end up with a python list of Grist Records, not a RecordSet or even a RecordList. Which I suppose is fine, but the nuisance is friction of figuring how to get it to act like a set in the first place, when I just wanted to write:
$myChildrenRefListColumn.union($myParentsRefListColumn)

... or, maybe:
$myChildrenRefListColumn + $myParentsRefListColumn

So, to be clear, the complaint isn't the type change or even the length of the code, just the friction that interrupts my flow when I'm trying to construct this pattern really quickly.


Issue while creating Glossary

Affected module - Glossary
Description-
When we try to create 3rd level Glossary term, it is giving error "An exception with message [null] was thrown while processing request."
Example- A->B->C, when we try to create C it is giving above error
Expected behaviour- We should be able to created nested or hierarchical Glossary terms.
Version - Latest version 0.13.0
Attached is error log as well as network details of html page.
Error in backend log file -
"[13/Dec/2022:11:08:45 +0000] "GET /api/v1/config/jwks HTTP/1.1" 200 454 "-" "Java/11.0.17" 1
INFO [2022-12-13 11:08:45,533] [dw-7762 - POST /api/v1/glossaryTerms] o.o.s.e.CatalogGenericExceptionMapper - exception
java.lang.NullPointerException: null
ERROR [2022-12-13 11:08:45,533] [dw-7762 - POST /api/v1/glossaryTerms] o.o.s.e.CatalogGenericExceptionMapper - Got exception: [NullPointerException] / message [null]
java.lang.NullPointerException: null"
Network details from HTML page-
General->
Request URL: HOST:8585/api/v1/glossaryTerms
Request Method: POST
Status Code: 500 Internal Server Error
Remote Address: <IP_ADDRESS>:8585
Referrer Policy: strict-origin-when-cross-origin
Response Header->
Content-Length: 91
Content-Type: application/json
Date: Tue, 13 Dec 2022 11:05:07 GMT
Request Headers->
Accept: application/json, text/plain, /
Accept-Encoding: gzip, deflate
Accept-Language: en-US,en;q=0.9
Authorization: Bearer eyJraWQiOiJHYjM4OWEtOWY3Ni1nZGpzLWE5MmotMDI0MmJrOTQzNTYiLCJ0eXAiOiJKV1QiLCJhbGciOiJSUzI1NiJ9.eyJzdWIiOiJhZG1pbiIsImlzQm90IjpmYWxzZSwiaXNzIjoib3Blbi1tZXRhZGF0YS5vcmciLCJleHAiOjE2NzA5MzMwNDAsImlhdCI6MTY3MDkyOTQ0MCwiZW1haWwiOiJhZG1pbkBvcGVubWV0YWRhdGEub3JnIn0.M83XrS045fl4fadKsgMT4yM7lMKMMH8JvUWSHJ484j-01Oq_jHa6h8WwrzVF_bVCbz2xx2ABasOs_ZBZLyZl_1VsWN5jwWWyU9UzBFm48QTtEfW9YuRZCxy451N84oDorbg0BoJc4ZEXLp6sXSvAiYorL_QcGu00VZKj6YFtZURgIBNCZ7yCnvDmxjARBfAnNjxVLp7pmPqLcUFH4g8s_skzboRXze_F4yrCEuSTeTesXYAA6KIHId2eCx3uAacRHnq7gOTC9O9thQdaEktQ4FWH20O7FzaUCRxX7wAkeq79ScWcYaXlMXFciqgq7jBJ-prava0WzfGzzIY67-AfkQ
Connection: keep-alive
Content-Length: 282
Content-Type: application/json
Cookie: VERSION_0_13_0=true; __session=%7B%22id%22%3A%22101ecd26-b791-4f7d-a4e5-67e2425b35e9%22%2C%22created%22%3A1670929439396%2C%22createdAt%22%3A%222022-12-13T11%3A03%3A59.396Z%22%2C%22expires%22%3A1670931259385%2C%22expiresAt%22%3A%222022-12-13T11%3A34%3A19.385Z%22%2C%22modified%22%3A1670929459385%2C%22modifiedAt%22%3A%222022-12-13T11%3A04%3A19.385Z%22%7D
DNT: 1
Host: HOST:8585
Origin: HOST:8585
Referer: HOST:8585/glossary/Entity/term/Entity.Cash%20Flow/add-term
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36
Have replaced actual server with HOST.

@eeshan-deshpande this has been fixed in 0.13.2


Add new resources

Hi, I make a PR based on this issue https://github.com/AccessibleForAll/Resources/issues/20
Any reviews would be awesome. Thanks!

I'm so happy! Thanks to you as well :)


Images in some problems not shown properly

There's an error displaying images in some problems. For example, the image in this one wasn't displayed properly:
https://github.com/trungnguyencs/Leetcode/tree/main/range-sum-query-2d-immutable
Link to Leetcode problem: https://leetcode.com/problems/range-sum-query-2d-immutable/

interesting... thanks for bringing it up.
Seems like the path was copied incorrectly. Hmm at first I thought this was an issue with native leetcode image vs external ones, but looking at other submissions in your repo, it seems the formatting is not consistent with images. Some are marked as "https://" while other with relative path like the one u pointed out as "/static/..."
Will get to it later this week.
@arnabsen1729  thoughts? Has this happened to you too?

I think we need to put a check for all the images.

So if its a relative path, prefix it with https://leetcode.com/"
in the above case, this becomes: https://leetcode.com/static/images/courses/range_sum_query_2d.png
Note that leetcode redirects this https://assets.leetcode.com/static_assets/public/images/courses/range_sum_query_2d.png
so not sure that that would be a problem when generating the readme.

@QasimWani assign me this issue, I will come up with a fix.

assinged! thanks for taking this 👍🏼

Tested it here :arrow_up:.  Just prefixing with "https://leetcode.com/" will work.

updates? @arnabsen1729

Hello. The problem is pinned, but I wonder if it was solved because the issue was closed.
If it's a problem that hasn't been solved yet, I'd like to fix it simply, so can you tell me the line that parses the line?


Error generating video

@sugatasanshiro
Can you try

activate virtual environment
python infer_audio2vid.py

instead of WebUI.

it's working and creating videos from - images and audio files in Test folder

so the problem was in WebUI file, how to generate from console? need some example

may be i can do it by just replacing images and audio files in Test folder

我和你的报错一模一样
I have the exact same error as you


SDK should offer an ICredentialProvider implementation around BotConfiguration's EndpointService

Is your feature request related to a problem? Please describe.
The "problem" is the amount of boiler plate that every sample and the VSIX templates include (~40 lines in Startup.cs) to load the endpoint and it's credentials out of the .bot file using the BotConfiguration APIs only to transfer the string value into a SimpleCredentialProvider.
Describe the solution you'd like
It seems like there should just be an "in-the-box" ICredentialProvider implementation that understands how to load from the .bot configuration file so that everyone doesn't have to write this boiler plate themselves.
Describe alternatives you've considered
The alternative is what the samples/VSIX templates are doing which is repeating ~40 some odd lines of boiler plate code to directly interact with the BotConfiguration API to find the endpoint.
Additional context
I've prototyped an BotConfigurationEndpointServiceCredentialProvider class and will supply an implementation via a PR shortly.
The greatest challenge is actually figuring out where that class should land in terms of the dependency chain. Microsoft.Bot.Configuration is completely standalone today and doesn't even reference Microsoft.Bot.Connector which is where IClientCredentials is defined. One option is to go ahead and reference Microsoft.Bot.Connector and then place the class into Microsoft.Bot.Configuration. I don't like this because the standalone nature of the library kind of makes sense. Concurrently no other library that referenced Microsoft.Bot.Connector references Microsoft.Bot.Configuration so there's not even a tie in point right now.
We could add this class to the .Integration.XXX libraries, but that would mean a) duplicating the class in both libraries and b) creating another dependency for the integration libs to bring in Microsoft.Bot.Configuration that not everyone will [want to] use.
A 100% clean solution would be a whole new library which integrates Microsoft.Bot.Configuration and Microsoft.Bot.Connector, but that would be add a whole new dependency that people would have to know to go look for just to get this one class.
Thoughts? Opinions?

some of the samples in 4.3 will help.  we have some product work to do.  consider this for 4.4

In the integration packages we have ConfigurationCredentialProvider for each flavor. That should be good.


fix: Prevent cyclical dependency with locker and storage

Closes #862
My proposal for a solution (includes some cleanup for the storage configs).
I would use a specific storage for the lockers that only uses the backend. The expectation is then that the lockers handle the locking themselves (which they currently do).
All other classes can then use a storage that still references the full store stack. The only one we currently have is the IDP one.
I also updated one integration config to use the resource store storage so this would be caught by tests using this config.
After #757 (which is how I discovered this) the plan is to update all the default configs we have to use this kind of storage instead of the memory one which is now the default.

I would use a specific storage for the lockers that only uses the backend. The expectation is then that the lockers handle the locking themselves

Could you clarify those two sentences a bit more?
For the second one, what is the alternative (a locker that does not lock)?

I would use a specific storage for the lockers that only uses the backend. The expectation is then that the lockers handle the locking themselves

Could you clarify those two sentences a bit more?
For the second one, what is the alternative (a locker that does not lock)?

It all depends on how a locker uses the storage. The storage is just a key/value store with no other restrictions on it. Our locking algorithm roughly uses it as follows:

lock count lock
read number of counts from storage
update number of counts from storage
unlock count lock

So there is a lock around the storage instructions here, making it a non-issue that the storage itself does no locking on the resource it writes to. But we could have a locker that does something completely different with the storage and doesn't put a lock around the operations.


Elementum service stopped working

Hi,
Since today elementum service has stopped working. After I start today to watch something message "elementum service has started" appears and movie has stopped. I try to reinstall apk file and kodi but nothing happened. Here log. I am sorry but on Chromecast with Google tv I can't copy log file.
https://drive.google.com/drive/folders/1bx8kVrdBqK1fo3qD-FZCgFmdBgqTVjIq
Please take a look.

@ninormalen, that's fine, I don't need Kodi's log file anyway. Instead use the following command in adb shell to start recording Android's log:
logcatLog=/sdcard/Download/logcat.log; logcat -c; logcat >$logcatLog & pid=$!; read; echo '\n--------- beginning of kill logcat' >>$logcatLog; kill $pid >>$logcatLog 2>&1; echo '\n---------    ending of kill logcat' >>$logcatLog

To stop it enter:
some non-empty text

Now can you please do the following in this order:

start logging;
start Kodi;
cause the plugin/daemon to crash and restart at least once;
stop Kodi;
start Kodi;
wait for the notification;
stop Kodi;
stop logging;
upload the log.

Hi, today works fine. 🤔
Sorry to bother you. Thank you.


proxy.go error handling

In proxy.go, there are a few place function calls that return errors. We would like to capture these errors and exit the program if there is an error.
For more details, check out #21

Closed by #28


Termination when using us_loop_integrate()

I'm using the us_loop_integrate() function to use uWS with my own event loop, but during the exit sequence us_loop_free() calls uv_run().  This is a surprising behaviour -- should we really be re-running the event loop during exit (when stuff has already largely been torn down), especially if its not your own event loop?

I’ve looked at it a bit more, and what I would like to see is a us_loop_deintegrate(), or some such function.  It should do the work done by the atexit, and disable the code in the atexit.  This would allow your approach of doing tear down during atexit, while allowing program architectures that prefer to avoid atexit to still shut down cleanly.

We can work on the name but yes that could probably be added.


Makes time triggers use crontab

Blackbox tested as far as I could come up with tests, if there needs to be some unittest I'll gladly write them I was not sure if this is covered already.
Test by:
automation:
  trigger:
    platform: time
    cron: '*/2 * * * *'

Ill fix the failed stuff ;)

Don't get it, it do fire in every manual test I run but I cant get tests to pass...

You can check the run log from Travis CI by clicking Details. This indicates what is wrong.

Also, why not just add a day_of_month argument instead of implementing cron syntax? This seems to break from the practice that has already been established as well as creating multiple ways to do the same thing.

Is there a time_of_month trigger? I do not yet have a use for my siren...
On Jan 24, 2016 11:29 PM, "Ryan Kraus"<EMAIL_ADDRESS>wrote:

Also, why not just add a day_of_month argument instead of implementing
cron syntax? This seems to break from the practice that has already been
established as well as creating multiple ways to do the same thing.
—
Reply to this email directly or view it on GitHub
https://github.com/balloob/home-assistant/pull/991#issuecomment-174396624
.

Not right now. I don't think it is a feature in high demand, but it could have some potential uses, I suppose.

The reason is every 5 minute task, day is day of month in cron btw so there are at least 2 new behaviors, Ill add more info.
I have thought this through. I have an Idea to make event.py nicer (really do not like all arguments)

I think that the solution for the problem that it is trying to solve is too complicated and heavy (it introduces an extra dependency for HA).
Instead, this should be solved by upgrading the current support to allow people to specify the missing crontab-like syntax. Currently we support a specific match (ie 5) and a match all (*).
It shouldn't be too hard to add support to _process_match_param to convert strings like /5 into a tuple(range(0, 60, 5)).

I do agree its heavy atm. lets consider my first try as an poc ;)
I would however like to give a couple of cons on my approach witch should be considered.

If we have a datetime we could in the long run do an MQ (through redis or kombu or rabbit and so on via celery) type handling for timed events, that would in the long run make the need for threads go down (instead of one per second we could just fire when we actually need to, without checks for if its time to run).
The code can be a lot more readable and easier to maintain (watch my next commit)
We can provide a timestamp for when next event of any type will be fired, that might be very useful and even displayed in frontend.

That said, if my next try don't get in to the "liking zone" I'll gladly fix this with out using cronite I'm happy just to make hass support these features.

I've done a rewrite for the event and time so it utilize a crontab like syntax, could be more improved in how to write stuff but the point is there anyway.
The input variables for all these functions could be slimmed down so its more readable.
It adds time trigger config vars for weekday (mon > sun), month day  (0 > 31) and year
it also adds the syntax of cron for hours and minutes */2 (seconds remain, as I can see it no periodic task with an <60s interval has ever worked but that can be supported as well.)
There is now a possibility to show when next event will occur (see logging in event.py line 154)
example conf tested and confirmed:
automation:
  - alias: 'test fixed time'
    trigger:
      platform: time
      hours: 13
      minutes: 25
      seconds: 15
    action:
      service: notify.notify
      data:
        message: One just happened, better take a look!

  - alias: 'test every hour'
    trigger:
      platform: time
      hours: '*/1'
    action:
      service: notify.notify
      data:
        message: Two just happened, better take a look!

  - alias: 'test every other minute'
    trigger:
      platform: time
      minutes: '*/2'
    action:
      service: notify.notify
      data:
        message: Three just happened, better take a look!

  - alias: 'test after'
    trigger:
      platform: time
      after: '13:00:00'
    action:
      service: notify.notify
      data:
        message: Four just happened, better take a look!

  - alias: 'test cron every other minute'
    trigger:
      platform: time
      cron: '*/2 * * * *'
    action:
      service: notify.notify
      data:
        message: Five just happened, better take a look!

  - alias: 'test every tuesday'
    trigger:
      platform: time
      weekday: 'tue'
    action:
      service: notify.notify
      data:
        message: Six just happened, better take a look!

  - alias: 'test cron every 11th in month'
    trigger:
      platform: time
      monthday: 11
    action:
      service: notify.notify
      data:
        message: Seven just happened, better take a look!

  - alias: 'happy new year'
    trigger:
      platform: time
      year: '*/1'
    action:
      service: notify.notify
      data:
        message: Happy new year!

Fixed seconds, but however... the tests do not work now when using real datetimes because they are written to test in datetime(2014, 5, 24, 12, 0, 0) and that makes wildcards not work (they do in real use cases), Ill fix it if this approach is acceptable, if not just say so and Ill make it use the old matching type.

I think you should give some thought as to what problems you are trying to solve and make sure that you are only solving those problems.
If you want to schedule things for every 5 minutes (or the like), then update _process_match_param to parse cron syntax (*/5).
If you'd like automations to be able to be scheduled based off year, month, and day as well, then add that to automation's time platform.
As far as scheduling events for a specific time rather than checking with every time change, the next fire time could already be calculated and this could already be done. I don't think anyone has really justified a need for this however, as the current check is so fast and HASS already uses very low resources.
I'm not sure that adding a dependency makes things easier to maintain. I'm also not convinced this really does much towards readability as everything is very clear already.
We could, with our current approach, provide a timestamp for the next time things will fire, but, again, I'm not sure a valid need for this has been presented.
Right now, in my opinion, I think this adds more complexity than functionality.

@TDWhbp  Sorry, I misread your comment earlier. This should get your close, adjust to your needs.
automation:
    alias: "Warning"
    trigger:
        platform: time
        day: 15
    action:
        service: homeassistant.turn_on
        entity_id: switch.siren

I have looked at the code again and I'll stick with my original comment. I don't think this is the right approach for the problems that it tries to solve.

Good call ;) I just got manic about fixing this so it passed all tests and it really is to complicated to be stable before X iterations :D
Ill be back with a clean implementation of /2

@rmkraus this wont work?
automation:
alias: "Warning"
trigger:
platform: time
day: 15
action:
service: homeassistant.turn_on
entity_id: switch.siren
There is no trigger for day that I can see, and even if there where its only weekdays not day of month? Am I missing something?

@TDWhbp in this dead PR there is support for that however ;)


CAS-454: Re-enable uring bdev and pool tests

The tests can be re-enabled as Ubuntu 20.04 has updated its kernel
5.4.0-50 which includes the fix for a NULL pointer dereference in
io_sq_wq_submit_work().

bors try

bors merge


feat: add styleguide

Probably not a good idea to merge this before a transition to NextJS. I can port this code afterwards if that does go ahead.
I'm also keeping an eye on https://github.com/reactjs/react-docgen/pull/352 which will allow for the styled system props to be documented.

@falconx I'm not clear about whether to merge this at this point?

@marxian I'm happy for it to be merged. I just didn't want it to interfere with the transition nextjs. But, since that work is not happening right now, there shouldn't be a problem.


[11.x] Fix the error with the prefix in non-cached routes

Fixes : #50239
The getPrefix() method of the Illuminate\Routing\Route returns different values for non-cached and cached routes:
/{locale} - the return value of the getPrefix() method for a non-cached route
{locale} - the return value of the getPrefix() method for a cached route
This PR fixes this issue by modifying the formatPrefix function in the RouteGroup class when initializing the route model

Can we convert this to not be a ternary? It's getting hard to read.

Do we have a way to write a test for this?

Do we have a way to write a test for this?

Thank you for your replay, I don't have a better testing method. I observed these Route models by traversing them and found that when their Prefix property is initialized, the first initialization of $old = $old['prefix'] ?? '';  will get an empty string, which causes a single Prefix Route to have an extra '/' added. If a new Prefix is added, the extra '/' will be removed through trim()
Class RouteGroup:
protected static function formatPrefix($new, $old, $prependExistingPrefix = true)
{
    $old = $old['prefix'] ?? '';

    if ($prependExistingPrefix) {
        dump("old: " . $old);

        dump("original: " . (isset($new['prefix']) ? trim($old, '/').'/'.trim($new['prefix'], '/') : $old));

        dump("new: " . (isset($new['prefix'])
            ? ($old ? trim($old, '/') . '/' . trim($new['prefix'], '/') : trim($new['prefix'], '/'))
            : $old));

        return isset($new['prefix'])
            ? ($old ? trim($old, '/') . '/' . trim($new['prefix'], '/') : trim($new['prefix'], '/'))
            : $old;
    }

    return isset($new['prefix']) ? trim($new['prefix'], '/').'/'.trim($old, '/') : $old;
}

My Routing Definition:
Route::group([
    'prefix' => '{locale}',
    'where' => ['locale' => 'en|fr|de'],
], function () {
    Route::get('/', function () {
        return view('welcome');
    });
});

Initialize routing:

Tinker Testing：
$routes = app('router')->getRoutes()->get('GET');
foreach ($routes as $route) {
    dump($route->getPrefix());
}

This seems to do the opposite of what we want. It makes non-cached routes not prefixed. TBH I'm not sure any of this is even worth fixing.


Is there a way to generate API only on specified tables ? We do have ignoreTables option.

In fact I"m wondering this because on my BD, XMYSQL takes 185 seconds to be started. Is there a way to improve the speed... to really be the speed of my thought :-)
BTW super project. It will be very interesting to have the same thing for oracle.

185 seconds - no good!
Could you please mention about the schema like how many tables in it and versions of mysql, os, node etc.
Are you using mysql from docker? in some cases docker mysql takes a little more time but 3+ minutes is new.
Generating APIs only for tables required will be featured going ahead.

I'm also interested in this feature. it be able to expose only small part of my tables.
Using blacklist just force me to create long list, that i need to keep upto date, or write code that do that


hello my very long title

hub issue create --edit -F - <<<hello

Botched --edit test; sorry everyone.


Equivalent of GO;

The following fails at runtime with System.Data.SqlClient.SqlException: 'Invalid column name 'code'.'
alter table Users add column code int default 0;
update Users set code = id + 1000;

This is a consistent behaviour with SSMS. This is solved using by separating the statement with GO. I do recall your explanation on how GO is used to virtually separate scripts so they are run individually. There is however no such equivalent statement. The current workaround is having the statements in different files.
Is it possible to have a statement that is equivalent to GO? Also, I'm not really sure if it is possible but if such codes can give an error at compile time, it will be very helpful since it will help with the statement that if it compiles, it works :)

Tricky part here will be figuring out the rules T-SQL uses. Maybe it's as simple as that all queries in a single batch are run assuming the model that existed at the start of the batch (not updated in response to DDL statements run within the batch). But I feel like I've seen situations where that wasn't the case -- could be wrong. Needs experimentation.

Just found this documentation on GO. Didn't even know the query below had such an interesting result and that a ; after GO is actually a syntax error.
select 2
GO 2


[List view] View list is not displayed correctly according to the selected template

Environment: Microsoft Windows 10 Enterprise
Google Chrome version 91.0.4472.124 (Official Build) (64-bit)
Reproducible: always
Build found: 2021-07-05
Preconditions

Go to https://ita-social-projects.github.io/GreenCityClient/
Open 'Eco news' page
Content items are displayed as a Gallery by default

Steps to reproduce

Maximize  browser window width to 1440px.
Set browser window width to 1020px.

Actual result
All labels are displayed and aligned according to the list.

Expected result
All labels should be displayed and aligned according to the grid.

User story and test case links
Test case #669
Test case #339
Test case #674

not reproducible


Add .contains_aabb for Frustum

Objective

Fixes: #15663

Solution

Add an is_forward_plane method to Aabb, and a contains_aabb method to Frustum.

Test

I have created a frustum with an offset along with three unit tests to evaluate the contains_aabb algorithm.

Explanation for the Test Cases

To facilitate the code review, I will explain how the frustum is created. Initially, we create a frustum without any offset and then create a cuboid that is just contained within it.

Secondly, we move the cuboid by 2 units along both the x-axis and the y-axis to make it more general.

Reference

Frustum Culling
AABB Plane intersection

I'll review later today, I have some comments to the math.

Hi @IQuick143 , sorry for the late response. I have resolved all the issues and added some cases involving rotation, please take another look and review them. Thank you!


Use lower level pysnmp APIs

Reimplement part of the pysnmp APIs by using lower level calls. It
cleans the interface quite a bit.

Here's a graph of branch followed by master, with the same config. 14s of check execution before, about 20 after, with the load being less.


Use bindeb-pkg instead of deb-pkg

Thank you for the detailed documentation and scripts. I encountered an issue while building kernel 6.8.2-rt11 on Ubuntu 24 with kernel version 6.8.0. The error was: "creating source package requires git repository", same as described here.
To resolve this, I switched from deb-pkg to bindeb-pkg, and the build worked successfully. Additionally, I noticed that the kernel-package package is no longer available (it shows "no installation candidate"). Instead, I had to install debhelper-compat (sudo apt install debhelper-compat) to fulfill the build dependencies.

Hi @tony2guo
Thanks a lot. I will test and merge it over the weekend!

Tested it under Ubuntu 20.04 as well as 24.04. Worked fine after installing the additional dependencies cpio debhelper-compat rsync.
Thanks!


wget ? why not export wiki:export

Just suggestion
our connection is too poor, wget is sometime drop or timeout.
i am recheck with diff. and download again. it's tire.

wiki > db export > convert data
db to html or json

or

wiki > export page > convert data
https://en.wikivoyage.org/wiki/Special:Export
wiki to html or json

It's possible ?

I suppose yes, it is possible. But you need to update toolchain. Would be great if you can do it and submit a working request )


[bazel] Add OTP alert_handler digest generation

This PR builds on https://github.com/lowRISC/opentitan/pull/14013.
This adds a rule, otp_alert_digest, that creates an additional OTP image overlay containing the OWNER_SW_CFG_ROM_ALERT_DIGEST_<LC_STATE> values.
Right now this is only done for RMA.
Leaving this as draft status as https://github.com/lowRISC/opentitan/pull/14013 currently doesn't produce a JSON format that is accepted by the python tools. From what I can tell, this is because the python tools expect the items to be in the form of quoted hex values, and right now opentitantool is outputting these fields as regular JSON numbers in decimal.

Moving this out of draft stage. Just like https://github.com/lowRISC/opentitan/pull/15872, this PR is also blocked on https://github.com/lowRISC/serde-annotate/pull/10 to get hex serialization working in opentitantool. With that change the bazel rules added here seem to work as intended.

Moving this out of draft stage. Just like https://github.com/lowRISC/opentitan/pull/15872, this PR is also blocked on https://github.com/lowRISC/serde-annotate/pull/10 to get hex serialization working in opentitantool. With that change the bazel rules added here seem to work as intended.


core_1.NoopLogger is not a constructor at new TraceExporter

/Users/xxx/projects/yyy/reporting/node_modules/@google-cloud/opentelemetry-cloud-trace-exporter/build/src/trace.js:31
        this._logger = options.logger || new core_1.NoopLogger();
                                         ^

TypeError: core_1.NoopLogger is not a constructor
    at new TraceExporter (/Users/xxx/projects/yyy/reporting/node_modules/@google-cloud/opentelemetry-cloud-trace-exporter/build/src/trace.js:31:42)
    at /Users/xxx/projects/yyy/reporting/packages/server-reporting/configs/telemetry/register.js:30:29
    at Object.<anonymous> (/Users/xxx/projects/yyy/reporting/packages/server-reporting/configs/telemetry/register.js:32:3)
    at Module._compile (internal/modules/cjs/loader.js:1201:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1221:10)
    at Module.load (internal/modules/cjs/loader.js:1050:32)
    at Function.Module._load (internal/modules/cjs/loader.js:938:14)
    at Module.require (internal/modules/cjs/loader.js:1090:19)
    at require (internal/modules/cjs/helpers.js:75:18)
    at Object.<anonymous> (/Users/xxx/projects/yyy/reporting/packages/server-reporting/index.js:1:1)

What version of OpenTelemetry are you using?
{
    "@google-cloud/opentelemetry-cloud-trace-exporter": "^0.8.0",
    "@opentelemetry/api": "^0.16.0",
    "@opentelemetry/node": "^0.16.0",
    "@opentelemetry/plugin-dns": "^0.13.0",
    "@opentelemetry/plugin-grpc-js": "^0.16.0",
    "@opentelemetry/plugin-http": "^0.16.0",
    "@opentelemetry/plugin-https": "^0.16.0",
    "@opentelemetry/plugin-mongodb": "^0.13.0",
    "@opentelemetry/tracing": "^0.16.0",
}

What version of Node are you using?

14.5.0

Please provide the code you used to setup the OpenTelemetry SDK
  const { NodeTracerProvider } = require('@opentelemetry/node');
  const { SimpleSpanProcessor } = require('@opentelemetry/tracing');
  const {
    TraceExporter,
  } = require('@google-cloud/opentelemetry-cloud-trace-exporter');

  const provider = new NodeTracerProvider({
    plugins: {
      http: {
        enabled: true,
        path: '@opentelemetry/plugin-http',
        serverName: `${name}@${version}`,
      },
    },
  });

  return provider.addSpanProcessor(
    new SimpleSpanProcessor(new TraceExporter()),
  );

related to: https://github.com/open-telemetry/opentelemetry-js/issues/774

Workaround
  const logger = require('noop-logger');

  provider.addSpanProcessor(
    new SimpleSpanProcessor(new TraceExporter({ logger })),
  );

This is because we removed the NoopLogger class from the core package in 0.16.0 and the cloud trace exporter is still implemented using the 0.15.0. You should open an issue over https://github.com/GoogleCloudPlatform/opentelemetry-operations-js so they fixes their exporter, i'm closing since it's not a bug within our repo.


[YUNIKORN-129] missing license headers

Include new make target for a license check, consistent with the other
repos: check-license.

LGTM. Merging now.
One question, is this PR fixed all files that missed license headers?

LGTM. Merging now.
One question, is this PR fixed all files that missed license headers?

it should be as the list for changes was generated using the new check-license make target.
json files can not have comments, adding a license is thus not possible. There might be a file without extension that did not get caught but they should all be configs rather than code or documents.


Heroku Deploy Failed

General Troubleshooting
Please check off these steps before suggesting a feature or reporting a bug:

[x] I am running the latest version:
[x] I have followed all instructions on the setup page (and if applicable, Raspberry Pi)
[x] I have read through the planned and suggested features

Issue
Issue Type

[x] Bug Report
[x] Feature Request

Description
Failed To Host On Heroku

I Just Have Done Follows The Step By Adding File "Procfile" with the worker code.
When I Deploy Its Fail Again!
-----> App not compatible with buildpack: https://codon-buildpacks.s3.amazonaws.com/buildpacks/heroku/java.tgz
Could not find a pom.xml file! Please check that it exists and is committed to Git.
More info: https://devcenter.heroku.com/articles/buildpacks#detection-failure
!     Push failed

You shouldn't need a pom.xml file. My directory structure is as follows:
.gitignore
JMusicBot-0.1.2.jar
Procfile
README.md
config.txt
serversettings.json

It sounds like you may have not set up the buildpack correctly. I'm using heroku/jvm.

putting pom.xml file in repository fixed it for me

Heroku is not intended to be used for services like this, as it doesn't allow writing files. I'd recommend switching to a different VPS provider.

putting pom.xml file in repository fixed it for me

what did you put i that file?


conditional group based on linux distro does not work

This line in the tutorial just doesn't work. It returns an empty group ungrouped as of azure_rm version 2.0
conditional_groups:
    linux: "'CentOS' in image.offer"

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 059a1972-09ee-02a7-8159-07ba04a2c763
Version Independent ID: 4323aa16-062c-1b11-fb73-11777c34f88e
Content: Tutorial - Configure dynamic inventories for Azure Virtual Machines using Ansible
Content Source: articles/ansible/dynamic-inventory-configure.md
Service: ansible
GitHub Login: @TomArcherMsft
Microsoft Alias: tarcher

Unfortunately, we have not been able to review this issue in a timely manner. We sincerely apologize for the delayed response. We are closing this issue. If you feel that the problem persists, please respond to this issue with any additional information.
Please continue to provide feedback about the documentation. We appreciate your contributions to our community.
#please-close


deleting troubleshooting.md document

Deleting > https://docs.ondat.io/docs/operations/troubleshooting/ which has now been transferred to the https://docs.ondat.io/docs/knowledgebase/ section.

Redirects from https://docs.ondat.io/docs/operations/troubleshooting/ to https://docs.ondat.io/docs/knowledgebase/ should be setup.

@Arau merged now - thanks !

Redirect validated
Connecting to docs.ondat.io (docs.ondat.io)|<IP_ADDRESS>|:443... connected.
HTTP request sent, awaiting response...
  HTTP/1.1 301 Moved Permanently
  Date: Wed, 21 Sep 2022 12:43:11 GMT
  Transfer-Encoding: chunked
  Connection: keep-alive
  Cache-Control: max-age=3600
  Expires: Wed, 21 Sep 2022 13:43:11 GMT
  Location: https://docs.ondat.io/docs/knowledgebase/
  Report-To: {"endpoints":[{"url":"https:\\/\\/a.nel.cloudflare.com\\/report\\/v3?s=yvm8TF9S2NvtSu%2B8B1vvnjNKUMdV7y6hnGxxoqkUUCV2%2BLXkziFX8R%2F0R6gIwNmkYKAiIzhBZ8lSIA%2FowoEYwjOqlxv%2BDTblNPTp5P2BX02aaFA4uvJQXkXoG80v2Pw%3D"}],"group":"cf-nel","max_age":604800}
  NEL: {"success_fraction":0,"report_to":"cf-nel","max_age":604800}
  Vary: Accept-Encoding
  Server: cloudflare
  CF-RAY: 74e2e297c9f6d184-LHR
Location: https://docs.ondat.io/docs/knowledgebase/ [following]
--2022-09-21 13:43:11--  https://docs.ondat.io/docs/knowledgebase/
Reusing existing connection to docs.ondat.io:443.
HTTP request sent, awaiting response...
  HTTP/1.1 200 OK
  Date: Wed, 21 Sep 2022 12:43:12 GMT
  Content-Type: text/html; charset=utf-8
  Transfer-Encoding: chunked
  Connection: keep-alive
  Last-Modified: Wed, 21 Sep 2022 11:14:13 GMT
  Access-Control-Allow-Origin: *
  expires: Wed, 21 Sep 2022 11:35:04 GMT
  Cache-Control: max-age=600
  x-proxy-cache: MISS
  X-GitHub-Request-Id: 080B:CA91:99D6CE:9EC841:632AF490
  Via: 1.1 varnish
  Age: 11
  X-Served-By: cache-lcy19264-LCY
  X-Cache: HIT

Redirect validated
Connecting to docs.ondat.io (docs.ondat.io)|<IP_ADDRESS>|:443... connected.
HTTP request sent, awaiting response...
  HTTP/1.1 301 Moved Permanently
  Date: Wed, 21 Sep 2022 12:43:11 GMT
  Transfer-Encoding: chunked
  Connection: keep-alive
  Cache-Control: max-age=3600
  Expires: Wed, 21 Sep 2022 13:43:11 GMT
  Location: https://docs.ondat.io/docs/knowledgebase/
  Report-To: {"endpoints":[{"url":"https:\\/\\/a.nel.cloudflare.com\\/report\\/v3?s=yvm8TF9S2NvtSu%2B8B1vvnjNKUMdV7y6hnGxxoqkUUCV2%2BLXkziFX8R%2F0R6gIwNmkYKAiIzhBZ8lSIA%2FowoEYwjOqlxv%2BDTblNPTp5P2BX02aaFA4uvJQXkXoG80v2Pw%3D"}],"group":"cf-nel","max_age":604800}
  NEL: {"success_fraction":0,"report_to":"cf-nel","max_age":604800}
  Vary: Accept-Encoding
  Server: cloudflare
  CF-RAY: 74e2e297c9f6d184-LHR
Location: https://docs.ondat.io/docs/knowledgebase/ [following]
--2022-09-21 13:43:11--  https://docs.ondat.io/docs/knowledgebase/
Reusing existing connection to docs.ondat.io:443.
HTTP request sent, awaiting response...
  HTTP/1.1 200 OK
  Date: Wed, 21 Sep 2022 12:43:12 GMT
  Content-Type: text/html; charset=utf-8
  Transfer-Encoding: chunked
  Connection: keep-alive
  Last-Modified: Wed, 21 Sep 2022 11:14:13 GMT
  Access-Control-Allow-Origin: *
  expires: Wed, 21 Sep 2022 11:35:04 GMT
  Cache-Control: max-age=600
  x-proxy-cache: MISS
  X-GitHub-Request-Id: 080B:CA91:99D6CE:9EC841:632AF490
  Via: 1.1 varnish
  Age: 11
  X-Served-By: cache-lcy19264-LCY
  X-Cache: HIT

Thanks!


chore(main): release 2.17.0

:robot: I have created a release beep boop
2.17.0 (2024-07-25)
Features

EMS-3631: declarations - replace api/keystone rendering with content-strings (#2813) (0b30342)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

v2.17.0
:sunflower:


fix: fix performance issues related to event listeners

I would of course recommend some refactoring for a cleaner code and debouncing on the mousemove event, so it would trigger as much as right now but this should stop the stuttering.

Absolute MVP Joseph.


Timings do not work with spans entered concurrently multiple times

Bug Report

Version
v0.23.0
This also affects all previous versions.
Description
When timing information is computed (idle_ns and busy_ns) the decision of whether the last interval was idle or busy is determined solely on the operation that is happening right now. So if we are entering a span, we assume the span has been idle until now, if we're exiting we assume it has been busy.
This holds only if we alternate between entering and exiting. If we enter twice, the time between the two enters is considered idle as far as the timings are concrented.
Example test illustrating the issue
    #[test]
    fn timings_test() {
        let tracer = TestTracer(Arc::new(Mutex::new(None)));
        let subscriber = tracing_subscriber::registry().with(layer().with_tracer(tracer.clone()));

        tracing::subscriber::with_default(subscriber, || {
            let span = tracing::debug_span!("request", otel.status_code = ?otel::Status::Ok);
            let _guard_1 = span.enter();
            thread::sleep(std::time::Duration::from_millis(100));
            let _guard_2 = span.enter();
        });

        let attributes = tracer.with_data(|data| data.builder.attributes.as_ref().unwrap().clone());
        let Value::I64(idle) = attributes.iter().find_map(|key_value| (key_value.key.as_str() == "idle_ns").then_some(key_value.value.clone())).unwrap() else { panic!() };
        let Value::I64(busy) = attributes.iter().find_map(|key_value| (key_value.key.as_str() == "busy_ns").then_some(key_value.value.clone())).unwrap() else { panic!() };

        let idle_ms = idle / 1_000_000;
        let busy_ms = busy / 1_000_000;

        println!("Idle: {} ms", idle_ms);
        println!("Busy: {} ms", busy_ms);

        // These panic but should not!
        assert!(idle_ms < 50); // Should be just about 0
        assert!(busy_ms > 50); // Should be just about 100
    }

This can be problematic especially in parallel environments where the spans can be entered concurrently from multiple threads.

As an aside, I could not find any mention of these fields anywhere in OpenTelemetry spec. So I assume this is something that this library itself provides but is not standard, correct?
The question really is whether there is any kind of decision what the numbers should represent, currently I assume it's wall-time (so if an operation is running on 8 threads for 100 ms, busy time should still be just 100 ms not 800 ms).
I assume it would be too much of a breaking change to remove it now, but is there a reason it is here instead of tracing itself or some other library?

As an aside, I could not find any mention of these fields anywhere in OpenTelemetry spec. So I assume this is something that this library itself provides but is not standard, correct?

Yes. In OpenTelemetry, this most likely belongs to Profiling.


Add description to stack memory value

Also edit regex to enforce at least 2 digits as 1-9mb will never be right.
Part of fix for https://github.com/flowforge/flowforge/issues/583

The stack description was already updated in #43 - looks like you didn't have that pulled locally.
https://github.com/flowforge/flowforge-driver-localfs/blob/5f5b8e8f8e82b28d0f70f33e618f02986f8ac045/localfs.js#L269
The regex fix is worth adding

Have resolved the conflict by combining the regex fix with the existing message - but added a comment about 256 being recommended minimum


[BUG]

🐛 Bug
My experiment fails pretty early, with the following stacktrace upon BLEU evaluation:
2023-05-18 17:58:52,287 - INFO: Validation BLEU: 0.32177
2023-05-18 17:58:52,333 - ERROR: Exception occurred during H2O LLM Studio run:
Traceback (most recent call last):
File "/root/h2o-llmstudio/train_wave.py", line 106, in
run(cfg=cfg)
File "/root/h2o-llmstudio/train.py", line 570, in run
val_data, val_loss, val_metric, last_batch = run_train(
File "/root/h2o-llmstudio/train.py", line 205, in run_train
val_data, val_loss, val_metric = run_eval(
File "/root/h2o-llmstudio/train.py", line 136, in run_eval
save_predictions(cfg, val_data, val_dataloader, val_df, mode)
File "/root/h2o-llmstudio/llm_studio/src/utils/modeling_utils.py", line 442, in save_predictions
val_df.to_csv(csv_preds_name, index=False)
File "/root/anaconda3/envs/llmstudio310/lib/python3.10/site-packages/pandas/core/generic.py", line 3551, in to_csv
return DataFrameRenderer(formatter).to_csv(
File "/root/anaconda3/envs/llmstudio310/lib/python3.10/site-packages/pandas/io/formats/format.py", line 1180, in to_csv
csv_formatter.save()
File "/root/anaconda3/envs/llmstudio310/lib/python3.10/site-packages/pandas/io/formats/csvs.py", line 261, in save
self._save()
File "/root/anaconda3/envs/llmstudio310/lib/python3.10/site-packages/pandas/io/formats/csvs.py", line 266, in _save
self._save_body()
File "/root/anaconda3/envs/llmstudio310/lib/python3.10/site-packages/pandas/io/formats/csvs.py", line 304, in _save_body
self._save_chunk(start_i, end_i)
File "/root/anaconda3/envs/llmstudio310/lib/python3.10/site-packages/pandas/io/formats/csvs.py", line 315, in _save_chunk
libwriters.write_csv_rows(
File "pandas/_libs/writers.pyx", line 72, in pandas._libs.writers.write_csv_rows
_csv.Error: need to escape, but no escapechar set

To Reproduce
I cannot disclse my training data, but it contains a lot of special characters like "ü", ",", "|", "-".
Details:
The full log is:
2023-05-18 17:48:26,845 - INFO: Global random seed: 612235
2023-05-18 17:48:26,846 - INFO: Preparing the data...
2023-05-18 17:48:26,846 - INFO: Setting up automatic validation split...
2023-05-18 17:48:27,033 - INFO: Preparing train and validation data
2023-05-18 17:48:27,033 - INFO: Loading train dataset...
2023-05-18 17:51:44,329 - INFO: Stop token ids: []
2023-05-18 17:51:44,771 - INFO: Sample prompt: ASSISTANT: pre(ask_birthday)
2023-05-18 17:51:44,771 - INFO: Loading validation dataset...
2023-05-18 17:55:01,590 - INFO: Stop token ids: []
2023-05-18 17:55:01,598 - INFO: Sample prompt: USER: Bei der IKK classic
2023-05-18 17:55:01,598 - INFO: Number of observations in train dataset: 59796
2023-05-18 17:55:01,599 - INFO: Number of observations in validation dataset: 605
2023-05-18 17:55:01,670 - INFO: dtype: torch.float16
2023-05-18 17:55:08,710 - INFO: Starting validation inference
2023-05-18 17:55:08,710 - INFO: validation progress: 0%| | 0/19 [00:00
2023-05-18 17:55:23,267 - INFO: validation progress: 5%|5 | 1/19 [00:14<04:22, 14.56s/it]
2023-05-18 17:55:34,945 - INFO: validation progress: 11%|# | 2/19 [00:26<03:38, 12.86s/it]
2023-05-18 17:55:46,675 - INFO: validation progress: 16%|#5 | 3/19 [00:37<03:17, 12.35s/it]
2023-05-18 17:55:58,387 - INFO: validation progress: 21%|##1 | 4/19 [00:49<03:01, 12.10s/it]
2023-05-18 17:56:10,103 - INFO: validation progress: 26%|##6 | 5/19 [01:01<02:47, 11.96s/it]
2023-05-18 17:56:21,834 - INFO: validation progress: 32%|###1 | 6/19 [01:13<02:34, 11.88s/it]
2023-05-18 17:56:33,060 - INFO: validation progress: 37%|###6 | 7/19 [01:24<02:20, 11.67s/it]
2023-05-18 17:56:44,724 - INFO: validation progress: 42%|####2 | 8/19 [01:36<02:08, 11.67s/it]
2023-05-18 17:56:56,384 - INFO: validation progress: 47%|####7 | 9/19 [01:47<01:56, 11.66s/it]
2023-05-18 17:57:06,834 - INFO: validation progress: 53%|#####2 | 10/19 [01:58<01:41, 11.29s/it]
2023-05-18 17:57:18,425 - INFO: validation progress: 58%|#####7 | 11/19 [02:09<01:31, 11.38s/it]
2023-05-18 17:57:30,061 - INFO: validation progress: 63%|######3 | 12/19 [02:21<01:20, 11.46s/it]
2023-05-18 17:57:41,740 - INFO: validation progress: 68%|######8 | 13/19 [02:33<01:09, 11.53s/it]
2023-05-18 17:57:52,859 - INFO: validation progress: 74%|#######3 | 14/19 [02:44<00:57, 11.40s/it]
2023-05-18 17:58:04,517 - INFO: validation progress: 79%|#######8 | 15/19 [02:55<00:45, 11.48s/it]
2023-05-18 17:58:16,537 - INFO: validation progress: 84%|########4 | 16/19 [03:07<00:34, 11.64s/it]
2023-05-18 17:58:28,222 - INFO: validation progress: 89%|########9 | 17/19 [03:19<00:23, 11.66s/it]
2023-05-18 17:58:39,877 - INFO: validation progress: 95%|#########4| 18/19 [03:31<00:11, 11.66s/it]
2023-05-18 17:58:51,656 - INFO: validation progress: 100%|##########| 19/19 [03:42<00:00, 11.69s/it]
2023-05-18 17:58:51,659 - INFO: validation progress: 100%|##########| 19/19 [03:42<00:00, 11.73s/it]
2023-05-18 17:58:52,073 - INFO: Mean validation loss: 10.37500
2023-05-18 17:58:52,287 - INFO: Validation BLEU: 0.32177
2023-05-18 17:58:52,333 - ERROR: Exception occurred during H2O LLM Studio run:
Traceback (most recent call last):
File "/root/h2o-llmstudio/train_wave.py", line 106, in
run(cfg=cfg)
File "/root/h2o-llmstudio/train.py", line 570, in run
val_data, val_loss, val_metric, last_batch = run_train(
File "/root/h2o-llmstudio/train.py", line 205, in run_train
val_data, val_loss, val_metric = run_eval(
File "/root/h2o-llmstudio/train.py", line 136, in run_eval
save_predictions(cfg, val_data, val_dataloader, val_df, mode)
File "/root/h2o-llmstudio/llm_studio/src/utils/modeling_utils.py", line 442, in save_predictions
val_df.to_csv(csv_preds_name, index=False)
File "/root/anaconda3/envs/llmstudio310/lib/python3.10/site-packages/pandas/core/generic.py", line 3551, in to_csv
return DataFrameRenderer(formatter).to_csv(
File "/root/anaconda3/envs/llmstudio310/lib/python3.10/site-packages/pandas/io/formats/format.py", line 1180, in to_csv
csv_formatter.save()
File "/root/anaconda3/envs/llmstudio310/lib/python3.10/site-packages/pandas/io/formats/csvs.py", line 261, in save
self._save()
File "/root/anaconda3/envs/llmstudio310/lib/python3.10/site-packages/pandas/io/formats/csvs.py", line 266, in _save
self._save_body()
File "/root/anaconda3/envs/llmstudio310/lib/python3.10/site-packages/pandas/io/formats/csvs.py", line 304, in _save_body
self._save_chunk(start_i, end_i)
File "/root/anaconda3/envs/llmstudio310/lib/python3.10/site-packages/pandas/io/formats/csvs.py", line 315, in _save_chunk
libwriters.write_csv_rows(
File "pandas/_libs/writers.pyx", line 72, in pandas._libs.writers.write_csv_rows
_csv.Error: need to escape, but no escapechar set

As a workaround, I can avoid this bug by avoiding validations (no "save best checkpoint" option).

Thank you for reporting. This is hard to debug if you can't provide the exact character where it fails.
As far as I can see there are no issues with the characters that you mentioned:


submit event does not firing

Hi!
I am trying to use jsdom for running client-side tests. Everything seems alright, but I found than events does not working as expected (not like in browsers)
form does not triggering the submit event when  the click event on button occurred.
<form action="">
	<button type="submit"></button>
</form>

I've created small repo to reproduce it
https://github.com/wtfil/jsdom-submit-bug

@Joris-van-der-Wel thoughts? Not sure this fell under the purview of your changes but seems like you know the code pretty well by now :)

haha ;)
The test uses  <button type="submit">, however the type attribute for <button> is not implemented in jsdom.
A <input type="submit"> should work however.
Implementing both <button type="submit"> and <button type="reset"> should not be that hard, submitting and resetting is already implemented.

Thx for replay:)
I've checked input[type=submit] and it works pretty well!
These is not difference between button and input in my app, so I can easily switch to input. But I think, it would be nice to not depend on test environment :)

Agreed! Glad to hear this should be a pretty easy fix. Maybe I can do it soon. (And yet, whenever I say that, it never seems to happen :-/)

I think this can be closed, as latest release seem to work fine.


Skill grid type hints

This is useful to enable strict type checking in VS Code.
"mypy-type-checker.args": [
        "--strict"
    ]


[Fix] tolerations & affinity in web deployment

What was changed
Fix tolerations & affinity  in web deployment template
Why?
Deployment was failing
Error: unable to build kubernetes objects from release manifest: error validating "": error validating data: ValidationError(Deployment.spec.template): unknown field "tolerations" in io.k8s.api.core.v1.PodTemplateSpec
Checklist

How was this tested:
Did the deployment

Any docs updates needed?
no

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


#481 cleaner messages in failed tests in case of using HmRsStatus

#481 cleaner messages in failed tests in case of using HmRsStatus

@exper0 Many thanks, I will find someone to review it before we merge

@dmzaytsev it's yours,please review

@rultor merge

@rultor merge

@dmzaytsev Thanks for your request. @yegor256 Please confirm this.

@rultor merge it

@rultor merge it

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor merge it

@yegor256 Done! FYI, the full log is here (took me 13min)

@elenavolokhova please, help us to evaluate quality here, as per par.24

@rultor deploy pls

@dmzaytsev
According to our quality rules:

The code reviewer found at least three problems in the code.

There were no issues found during review.
Please confirm that you will try to find at least three problems next time.

@rultor deploy pls

@davvd OK, I'll try to deploy now. You can check the progress here

@rultor deploy pls

@davvd Done! FYI, the full log is here (took me 9min)

@elenavolokhova I confirm

@davvd Quality is acceptable here.

@davvd Quality is acceptable here.

@elenavolokhova thanks for the QA review, we'll work better next time

@dmzaytsev paied 10 mins to @elenavolokhova for QA review (payment ID is 74031895)... thanks, I just added 17 mins to your account, payment 74031904, 242 hours and 53 mins spent... review comments (c=2) added as a bonus... +17 added to your rating, at the moment it is: +1518


Refactor protocol to objects

Refactoring protocol messages to an object oriented style to make them more readable, maintainable, testable, and reusable.
Implements both serialization and deserialization of messages to/from JSON, with the goal of being able to use the same code in data-api. For external reusability, the individual protocol message classes are exposed on the main exported module as StreamrClient.Protocol.*.
Also includes cleanup for unit tests and integration tests. New test cases have also been added.

@Aapzu do you have time to review this?


Yubico OTP support

Implement Yubico OTP. I'm not sure is it required.

OTP is a different standard and I think there are good enough solutions for it already. Since your account is deleted I'm going to close this.


3.5.6+ items.status.nodes disappeared from /api/v1/workflows endpoint for completed Workflows

Pre-requisites

[X] I have double-checked my configuration
[X] I have tested with the :latest image tag (i.e. quay.io/argoproj/workflow-controller:latest) and can confirm the issue still exists on :latest. If not, I have explained why, in detail, in my description below.
[X] I have searched existing issues and could not find a match for this bug
[ ] I'd like to contribute the fix myself (see contributing guide)

What happened/what you expected to happen?
While updating argo-workflows to version v3.5.6, I noticed that the status.nodes field disappeared for completed workflows in endpoint /api/v1/workflows. If the workflow is in the Running status, this field still appears. Is this expected behavior?
I cannot force this field to appear with: https://argo-workflows.xxx/api/v1/workflows/?listOptions.limit=50&fields=items.status.nodes
Up to v3.5.5 it was working fine.
Version
v3.5.6

Follow-up from this Slack thread. Per thread, nodeStatusOffload is not enabled and this only occurs on the list endpoint.
Given that it only occurs on list and completed Workflows, I'm guessing this is only impacting Archived Workflows, and so would be caused by https://github.com/argoproj/argo-workflows/pull/12912#discussion_r1572901283

I cannot force this field to appear with: https://argo-workflows.xxx/api/v1/workflows/?listOptions.limit=50&fields=items.status.nodes
Up to v3.5.5 it was working fine.

This part would be the regression -- fields is supposed to be dynamic. Although I'm pretty sure you'd drop items

If the workflow is in the Running status, this field still appears. Is this expected behavior?

So in 3.4, the Archived Workflows list wouldn't return nodes by default either

So in 3.4, the Archived Workflows list wouldn't return nodes by default either per the diff I commented on in #11121 (comment).

Looking at it a bit more, it may not have been possible at all for Archived Workflows list in 3.4?
So this is perhaps intended behavior for Archived Workflows lists, just that in 3.5 they're also available in the regular list API as well.

So, to summarize: status.nodes field appeared in 3.5 list endpoint by a mistake and it shouldn't be there. And by design it won't return?

@agilgur5 items.metadata.ownerReferences seems also missing for archived workflows. There seems to be quite a big discrepancy between what is returned for archived and live workflows on a single API endpoint.

Yea anything that doesn't have it's own column in the archived DB is not returned right now

Yea anything that doesn't have it's own column in the archived DB is not returned right now. And adding more columns or plucking more causes performance issues per #13295 etc 😕

Is it a subject to change in 3.6? Or will it stay the same?

They're technically supposed to be set dynamically per your fields parameters as I mentioned in https://github.com/argoproj/argo-workflows/pull/12912#discussion_r1581619939. If you can make that work, I'd probably consider that a patch fix in 3.5 even, but at a glance it looks non-trivial to do

@agilgur5 I've set in my config:
worfklowDefaults:
  spec:
    ttlStrategy:
      secondsAfterCompletion: 345600 # 4 days

so that I could get some more information on the completed workflows, but despite the fact they are still live in k8s cluster, some fields are still missing (seems that, if it is archived, the data goes from the db, not from the cluster).
It's quite problematic if you have a custom GUI and prevents us from updating to 3.5.6+.

If I disable the archive, the fields are visible again for completed workflows, so that confirms the above situation.

@agilgur5 is there any chance of fixing this in the near future?

I resigned from my role in Argo (c.f. #13837), so you'd want to ask other maintainers about that.
Given that I personally spent an outsize amount of time tracing and prioritizing all the 3.5.x regressions, the answer may be "no" implicitly, but I can't answer on behalf of others.

Sorry to hear @agilgur5. Best wishes and good luck.


Block fixup commits

This uses the organisation's fixup commit blocker workflow.
The purpose is to make sure all commits prefixed with fixup need to be squashed before merging.

There seems to be a problem with generating sphinx docs, I'll have a look at this later.


Incoming txns not showing on badger-firefox mobile

On Badger for Firefox at least on mobile, if I send and receive BCH I see the txns, but if I send and receive SLP, I see the sends but not the ones I receive. I see the tokens, in balance, but not the txns.
Everything works, but it would be nice if TXNs coming in displayed when they arrived and in history

Seems to work that way on desktop too - but given how it only recently started showing BCH incoming, SLP will probably take a little longer.


🔀 :: (#78) 유저 로그인 테스트

Codecov Report

Merging #89 (344f60d) into develop (ea4ad58) will increase coverage by 1.67%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             develop      #89      +/-   ##
=============================================
+ Coverage      12.67%   14.35%   +1.67%
- Complexity        23       28       +5
=============================================
  Files             42       42
  Lines            418      418
  Branches          18       18
=============================================
+ Hits              53       60       +7
+ Misses           360      352       -8
- Partials           5        6       +1

Impacted Files
Coverage Δ

...semicolon/gspass/service/user/UserServiceImpl.java
58.97% <0.00%> (+7.69%)
:arrow_up:

...in/java/com/semicolon/gspass/entity/user/User.java
27.27% <0.00%> (+9.09%)
:arrow_up:

...in/java/com/semicolon/gspass/dto/LoginRequest.java
75.00% <0.00%> (+75.00%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea4ad58...344f60d. Read the comment docs.


Initial state of placeholder not right when using ng-model

When ng-model is used, the model data and placeholder/label overlap. Once you focus on the input and leave it is all good.

Codepen/jsbin/plunker example?
http://jsbin.com/ximuve/4/edit?html,output

Well doesn't seem to happen if I edit the jsbin you shared. But can reproduce it when I go on to edit the Demo provided on GitHub. http://codepen.io/serverdevil/pen/avzXbw

I've observed that the issue seems related to the timing of the model update.  Here:
http://codepen.io/tomdrewes/pen/xZjJML
If you remove the $timeout, the code works fine.  With the $timeout, the issue occurs.

Im still having this issue with version 1.0.4, I loaded some data from backend then updated my scope variables in order to display its values in a ion-md-item. I cannot remove this "timeout" cause its a backend query for data display.
What I did as a ugly workaround was adding a setTimeout in directive code to wait 1 second before determining if there is a value in the ion-md-item.
ionic.DomUtil.ready(function() {
setTimeout(function(){
if (mdInput.value === '') {
mdInput.className = mdInput.className.replace(reg, ' ');
} else {
mdInput.classList.add(dirtyClass);
}
},1000);
});

I'm facing the same issue, when fetching data from server. So, I used a 1500 milli sec time out. Thank you @joseluiscampos for the work around.


NETWORK WON'T STAY DOWN

  Description: If you enable the NSH network monitor (CONFIG_NSH_NETINIT_MONITOR)
               then the NSH 'ifdown' command is broken.  Doing 'nsh> ifconfig eth0'
               will, indeed, bring the network down.  However, the network monitor
               notices the change in the link status and will bring the network
               back up.  There needs to be some kind of interlock between
               cmd_ifdown() and the network monitor thread to prevent this.
  Status:      Open
  Priority:    Low, this is just a nuisance in most cases.

@v01d maybe this should be migrated to apps?
If I understand correctly, this is a problem of the network monitor, not of the OS.

Thanks, migrated to apps


thinkfan: add option for libatasmart support

Motivation for this change
This patch allows you to build thinkfan with SMART support.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Assured whether relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

I have been using this to keep my NAS hard drives nice and cool for a while now and it works just fine.
@Infinisil and @domenkozar, is there any chance to see this merged?

Why make it optional?

@domenkozar It adds an extra dependency and is also disabled by default by thinkfan itself. Furthermore the official readme states:
   USE_ATASMART:BOOL (default: OFF)
       Enable libatasmart to read temperatures directly from hard disks. Use
       this only when you really need it, since libatasmart is unreasonably
       CPU-intensive.

As I did not have the time to find out, if that CPU penalty is triggered by compiling in SMART support or only if also using it, I opted to make the feature optional.


Add initial unit tests and CI pipeline

Hey folks, similar to the initial PRs from last week this PR establishes the initial unit tests and CI pipeline for slurmd-operator.
Summary of Change

Add initial templates for bug reports, enhancement requests, and pull requests
Add a basic CI pipeline using GitHub actions
- Inclusive language check
- Lint
- A separate PR will cover linting changes, currently linting has not been run yet. Those changes will stem from the results of running tox -e lint.
- Unit tests
Formatting
- Changes to the source code in this PR stem from running tox -e fmt. These changes result from using black and ruff.
Unit Tests
- These tests only test the typical expected behavior of the charm. Integration and functional tests will follow in later PRs however those are not covered here.

Please take a look and ensure these changes are satisfactory and raise any questions, comments, or concerns!

Merging as all comments have been resolved. Thank you, everyone!


User token authentication not working?

Maybe I'm doing it wrong, but I can't get the token authentication to work.
I'm using the latest versions of OctoberCMS (3.6.22) and Rainlab.User (3.0.4)
Account creation and login work fine, the only difference is that I had to change the "onSignin" method, as specified in the documentation, to "onLogin" like so:
ajaxHandler('onLogin').withVars({
    token: session.token()
})

Now, I'm sending the token with axios like this:
axios.get('/api/account/user', {
    headers: {
        "Authorization": "Bearer " + store.user.token
    }
}).then(response => {
    console.log(response.data);
});

Layout auth.htm:
description = "Auth API Layout"
is_priority = 1

[session]
checkToken = 1

[account]
==
{% if session %}
    {% page %}
{% else %}
    {% do response({error: 'Access Denied'}, 403) %}
{% endif %}

Page user.htm:
url = "/account/user"
layout = "auth"
title = "user"

[account]
==
{% do response({
    token: session.token,
    sessionUser: session.user,
    accountUser: account.user,
    user: user
}) %}

And the response I'm getting is:
{
    token: ANOTHER TOKEN,
    sessionUser: null,
    accountUser: null,
    user: null
}

I tried various settings and combinations, the result is the same. Authentication is not happening.
What am I doing wrong?

Hey @jester6san
It looks like this is a bug. We will publish a fix for this today.

That was so fast!
Thank you very much @daftspunk I confirm that it works!


Allow specifying ImagePullSecrets in ClusterImagePolicies

Description
Currently cosigned uses ImagePullSecrets through the PodSpec-providing resources (https://github.com/sigstore/cosign/issues/801). However, there is no guarantee that signatures are stored in the same repository of the image (for instance, if COSIGN_REPOSITORY was set when signing).
If we can specify ImagePullSecrets in the ClusterImagePolicies, cosigned can use them for verification.

@tcnghia We are working on adding support to ClusterImagePolicy where you could specify where to look for the signatures. These changes and others are coming from the following design document https://docs.google.com/document/d/1gBLEOOHWOmvHVsoJbgGU74GdwA6CGxMRp3MAeEB50l4/edit#.

@hectorj2f I see. Thanks for pointing out. I am not sure if we should close this bug or re-use it to track part of the the design doc implementation? You know better than me about what the right thing to do for the repo, so I'll let you close or leave open as necessary. Thanks!

This issue is related to #1651

Going to start working on this

@DennyHoang  Is there any test bit for 1.9 or when will 1.9 be released? I am trying to use cosigned with GCP's gcr.io with 1.8 but stuck in the permission against private repository (gcr.io). Is there any workaround I could test before 1.9?
Error from server (BadRequest): error when creating "nginx-1.yaml": admission webhook "cosigned.sigstore.dev" denied the request: validation failed: GET https://gcr.io/v2/shawn-demo-2022/nginx/manifests/sha256:61face6bf030edce7ef6d7dd66fe452298d6f5f7ce032afdd01683ef02b2b841: UNAUTHORIZED: You don't have the needed permissions to perform this operation, and you may have invalid credentials. To authenticate your request, follow the steps in: https://cloud.google.com/container-registry/docs/advanced-authentication: spec.containers[0].image
gcr.io/shawn-demo-2022/nginx@sha256:61face6bf030edce7ef6d7dd66fe452298d6f5f7ce032afdd01683ef02b2b841

@shawnho1018 Are the signature and the container in the same registry or different registries? If they are in the same registry, have you tried passing a service account with the imagePullSecrets to the Pod Spec?

@elfotografo007  Signature and container are in the same registry.
I am using workload identity way to grant all service accounts in cosign-system with gcr.io privilege. I have not tested imagepullsecret yet and will try it.


Initial button focus is on Options even when Game Scene Path is set

Setting Game Scene Path allows to show Play button, but the Options button is still the one focused on start, instead of the expected Play button at the top.
Btw nice addon, it goes farther than EasyMenus and already has Credits and above all, remappable controls! I'll use it from now on for my jams, and maybe even my other games!

Sorry, wrong bug description. In fact, Play is really focused on start, but I can ghost select other buttons by pressing directional input during the title animation. Pressing down once during title fade in will select Options just below. Twice, Credits.
So the issue is that navigation is allowed while buttons are invisible.

Similarly, it's possible to ui_accept a button and directly enter e.g. the Options during the title fade in, by pressing Enter.

That's unintended behavior. I think player's would probably be more accustomed to the selection occurring after the buttons are fully faded-in. Being able to navigate to the options during the fade is also outright silly.
Thanks for reporting and the update :slightly_smiling_face:

A side effect of this is that when entering Options this way, user is unable to click on the buttons except Back, at which point user can reenter Options to properly interact with the sub-menu.
It may be related to some canvas layer or interaction flag not set properly as the animation was interrupted.
However, it should be fixed along this bug. Forcing fade animation end by pressing Space or Enter, just as when you click, should solve the issue.

Thx, looks like Godot Asset Library still shows 0.7.0 so I'll have to install the release from GitHub manually.

Thanks for confirming the fix. Sorry for the trouble with the menu's template being on an older version. I finished a jam and should have more time to sync the templates. Eventually I hope to find some way to automate that.


Change frequency panel to 3 decimal places

The frequency panel is a bit hard to understand because frequency is commonly fluctuating only between a very small range.
The hover tooltip becomes a bit useless at one decimal place because it rounds the number and it's not possible to distinguish when the value changes.

Changing to 3 decimal places allows you to see the actual fluctutation clearer.

Good enhancement.  Thanks @longzheng !


Curation task results are not included in the output file or standard out.

Describe the bug
When running a curation task via the DSpace 7.0 CLI, the output generated by the task process is only written to the dspace.log but not written to the output file or standard out.
To Reproduce
Easiest example is to run the NoOpCurationTask on both DSpace 6 and DSpace 7:
dspace curate -e admin -i 12345678/9 -t noop -v -r -

-r filename | emit reporting to the named file.  '-r -' writes reporting to standard out.  If not specified, report is discarded silently.

Expected behavior
This command should write the Curation Task result string "No operation performed on 12345678/9" to standard out.
In DSpace 6 the output is:
Adding task: noop
Starting curation
Curating id: 12345678/9
No operation performed on 12345678/9
Ending curation. Elapsed time: 70

In DSpace 7 the output is:
The script has started
Adding task: noop
Starting curation
Curating id: 12345678/9
Ending curation. Elapsed time: 33
The script has completed

Of course, if you use another task than NoOpCurationTask, you can expect a more useful result string ;)
Related work
The same issue of missing results of curation task executions has been reported on the Angular-UI side:
Curation task results are not included in the output file or process output #1322

I believe this is essentially a duplicate of https://github.com/DSpace/dspace-angular/issues/1322.  In v7, the same code drives the logging in both the outputfile & the CLI.  So, I'm pretty sure that when https://github.com/DSpace/dspace-angular/issues/1322 is fixed, this issue would also be fixed.

Closing, this appears to be a duplicate as described above.


Sieve of Eratosthenes Algorithm

Description
Sieve of Eratosthenes is a simple and ancient algorithm used to find the prime numbers up to any given limit. It is one of the most efficient ways to find small prime numbers.
Domain
Algorithm
Type of Contribution
Addition
Code of Conduct

[X] I follow Contributing Guidelines & Code of conduct of LearnCPP.

i would like to add this algorithm under Gssoc22

Since you've assigned issue #145 closing this issue


⚠ Bofrost.at has degraded performance

In c298d30, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1278 ms

Resolved: Bofrost.at performance has improved in a680cf7 after 15 minutes.


Move dev to main and main to release branch

Just as a matter of cleaner branch management, I feel like it'd be nice to swap the role of main to be dev, since dev is where most of the active work is for contribution. In its place we can replace main with a release branch, or something similar. Originally the intent was to use Git Flow but on similar projects I also see main being used as the dev branch.
It might also be a good time to look at our release strategy and see if we don't want to release features more frequently. I intend to have the bot version be semver (i.e. new commands increment the minor version), but since I don't anticipate breaking API changes for a while I'm imagining the minor version would increment a lot if we released every feature as it was finished. That's why I started bundling issues under milestones. It might be better to just have the large number of versions and get things delivered faster, though -- Firefox is on major version 115.

Switched away from squash merges, that should start making forward/backporting easier. Will keep following git flow. Still thinking of maybe trying to make main the dev branch.

Swapped the default branch to dev. Now the cache action should use that cache and not recreate caches for each feature, and things feel okay since now main isn't shown by default when the repo opens. I also added branch protections to both branches.


ELF exports

Are exports used? As is, this PR just makes other code more complex with another _

Are exports used? As is, this PR just makes other code more complex with another _

then everything else is in #4492


[WIP] Add role:assign/role:revoke handler

This PR is WIP on allowing batch operation on users' roles
Finished:

skydb AssignRole/RevokeRole
role:assign handler

Pending:

The return format of the handler
role:revoke handler
test case on handler

Note:
For return format of handler, I am thinking should we return the affected entries. Or just success/fails instead of echo. But no time to really think through it. Feel free to comment.

Superseded by #404


Implementation of the algorithm #10

I implemented the algorithm, please have a look on it

Well done! I think it looks good. However, I'm not sure why the tests fail, since it looks like you named the function correctly in order to be able to call it from the tests. Do the tests fail with AssertionError?

I think what needs to be done is to ensure that the test cases actually run. To keep it simple I think we should update the test cases.  See #25

I accidentally pushed a fix to this branch. It should have changed the tests sufficiently to work with the implementation. However one of the tests fails.

I think it is fine to push it here! @BastienFaivre seems like we are not handling the empty case?

I'll have a look on it


Node: VSS commands support - complete remaining (part I)

Describe the feature
VSS command support for Node.js
Full list is listed in https://github.com/valkey-io/valkey-glide/wiki/ValKey-Commands-Implementation-Progress
Commands
see: https://github.com/valkey-io/valkey-glide/wiki/ValKey-Commands-Implementation-Progress#vector-search-module
Previous Commands:

[x] FT.CREATE - #2501
[x] FT.DROPINDEX - #2516

TODO:

[ ] FT.SEARCH
[ ] FT.INFO
[ ] FT.ALIASADD
[ ] FT.ALIASDEL
[ ] FT.ALIASUPDATE

Out of scope:

[ ] FT._LIST
[ ] FT._ALIASLIST
[ ] FT.AGGREGATE
[ ] FT.PROFILE
[ ] FT.EXPLAIN
[ ] FT.EXPLAINCLI

Progress for Oct 28th -
Preliminary commands are complete.
FT.SEARCH is in progress.

The following commands are complete:

[x] FT.SEARCH - #2551
[x] FT.INFO - #2540

The following commands are in-progress (ETA Nov 1st):

[ ] FT.ALIASADD
[ ] FT.ALIASDEL
[ ] FT.ALIASUPDATE

Status update:
Total commands: 5
Done - 3

FT.SEARCH
FT.INFO

In Progress/In Review - 3
The following commands are in-progress (ETA Nov 8th):

FT.ALIASADD - In Review
FT.ALIASDEL - In Review
FT.ALIASUPDATE - In Review

Status update:
Total commands: 7
Done - 7

FT.CREATE - Done
FT.SEARCH - Done
FT.INFO - Done
FT.ALIASADD - Done
FT.ALIASDEL - Done
FT.ALIASUPDATE - Done
FT.DROPINDEX - Done

In Progress/In Review - 0


Difference with stream read

I'm comparing the use of binaryparse and using streams directly.
Why does the following code does not result in the same output?
import streams, binaryparse

var strm = newFileStream("demodado.tem",fmRead)
strm.setPosition(0)

var datehour : array[7,uint16]

for i in 0..6:
 datehour[i] = strm.readUint16()

echo datehour

strm.setPosition(0)
createParser(simple):
  u16:field1[7]

echo simple.get(strm)
strm.close()

The echo results are:
[20, 2, 1990, 21, 44, 52, 22]
(field1: @[5120, 512, 50695, 5376, 11264, 13312, 5632])

Because binaryparse reads in big-endian/network order. If you try to write a file from binaryparse and read the result with that then you will see that the stream reading will return the values you see from binaryparse now. Alternatively you can use the endians module to swap the endianess of the values:
import streams, binaryparse

var strm = newFileStream("demodado.tem",fmRead)
strm.setPosition(0)

var datehour : array[7,uint16]

for i in 0..6:
  datehour[i] = strm.readUint16()

echo datehour

strm.setPosition(0)
createParser(simple):
  u16:field1[7]

import sequtils, endians

var data = simple.get(strm).field1
data.apply(proc (x: var uint16) = swapEndian16(x.addr, x.addr))
echo data
strm.close()


Add school engagements and community data to Signature events pages

Fiona has advised that we should have School and Community engagements data for the new Signature pages.
More detail to follow
Children's Day:

[ ] Schools engagement
[ ] Community engagement

Smeaton300:

[ ] Schools engagement data

Nest:

[ ] Commmunity engagement data

Closing #191 as completed


Chant Create view: We need to reimplement the "suggested chants" feature

This feature was turned off by #1142, and we need to turn it back on again.
https://github.com/DDMAL/CantusDB/commit/92fa04590885aeb02a8475e547af5a6cf5110ad5 was the commit responsible for removing this functionality. (https://github.com/DDMAL/CantusDB/commit/fc188e94e2581fdb613e9948df1eec4309448196 and https://github.com/DDMAL/CantusDB/commit/d65f4246ab9e2870fec57a9660a3366d1cfd75b3 could also be useful for writing tests for this view)
I think it could be worth exploring implementing this feature client-side - when a user requests this page, we can return a page without sending a request to CI ourself. When the user's page loads, we get the user's browser to send requests to CI for the data necessary for creating this list of chants, and update the content of the page using JavaScript.

It's less necessary to do this client-side than on publicly-accessible views, since we don't expect bots to be trawling through Chant Create pages.
But this could allow us to return the page more quickly, allowing the user to start interacting with the page even before CI has returned its responses.

We can use the following endpoints:

https://cantusindex.uwaterloo.ca/json-nextchants/{CantusID} to get the list of potential successor chants (note that CI's documentation on this endpoint indicates it is "under construction" - it seems to be working fine currently, but we should perhaps check in with Jan to confirm it will behave reliably)
https://cantusindex.uwaterloo.ca/json-cid/{CantusID} to get the fulltext, genre, etc. of each potential successor chants

Assigning this a priority of "high" - this is a feature that OldCantus had that we don't currently have.

I got started on this this afternoon. It has led me on down a couple of rabbit holes:

when we used to parse requests, we would remove the Byte Object Marker from CI's response by removing the first several characters of a request. It turns out there's a less arbitrary way to do this:

response = requests.get("url_of_CI_api")

# instead of (used to do it this way)...
text: str = response.text
json: dict = json.loads(text[2:])

# we can (much better)...
from codecs import decode
content: bytes = response.content
decoded: str = decode(request.content, encoding="utf-8-sig")
json: dict = json.loads(decoded)

figuring out how to write tests for these functions using Mock and patch so that

we don't send a burst of requests to CI whenever we run the tests, and
our tests don't begin failing if/when CI's data changes.

I'm making progress on this, but a few things have come up that I hadn't foreseen when I started:

Cantus Index provides a list of suggested next Cantus IDs, as well as fulltext/genre/etc. for any given Cantus ID, which means that we don't need to calculate any of this ourselves - nice! However, once we get the list of suggestions, we need to send off a request for information about each suggested Cantus ID. Even when limiting to 5 suggestions, this takes 5-10 seconds testing locally - much too long to make a user wait to load a page. I'm ignoring this and just running the calls sequentially to begin with, but eventually, we'll need to find some way to parallelize these API calls.
it would make sense to incorporate #1024 when implementing this, which means I can't just use the JS that was taken out in https://github.com/DDMAL/CantusDB/commit/92fa04590885aeb02a8475e547af5a6cf5110ad5 - I have to do some figuring out.


location parameter error with load_netcdf_weather and location "list"

I load the weather stations data from template xlsx file. The data are loaded as list but list isn't accepted by the load_netcdf_weather function. It seems an error in the IF block at line 551 of loading.R file.

Please check my edits if they make sense for you:
https://github.com/echiaradia/SWATprepR/commit/1be99b44495949ef829f16b9663def3d5fb07f4d

Hi Enrico, thanks for providing feedback on this function and corrections in the code. I was in the end of debugging in the moment of receiving your code, so left my version. But anyway I updated function to remove those bugs. You can use my version if you update the package ;)


Using extensions with asciidoctorj 1.6.1

I'm using asciidoctorj in an osgi environment and and I'm attempting to create a custom IncludeProcessor. Without any extensions everything works fine, but as soon as I register the processor I get the following stack trace:
java.util.NoSuchElementException
	at java.util.ServiceLoader$LazyIterator.nextService(ServiceLoader.java:365)
	at java.util.ServiceLoader$LazyIterator.next(ServiceLoader.java:404)
	at java.util.ServiceLoader$1.next(ServiceLoader.java:480)
	at org.asciidoctor.extension.BaseProcessor.<init>(BaseProcessor.java:36)
	at org.asciidoctor.extension.IncludeProcessor.<init>(IncludeProcessor.java:15)
	at org.asciidoctor.extension.IncludeProcessor.<init>(IncludeProcessor.java:11)

I tried to trace the problem but it seems the  BaseProcessor class has changed already in the latest snapshot (removing a FIX ME line which is probably where this comes from). I'm specifically registering the extension as a class instance, so the processor's lifecycle is managed externally.

Further experiments with the latest snapshot version (built locally) do confirm that the problem is fixed by the change in the BaseProcessor class. I guess my question is when can we have an official release? As I see it Java extensions might be broken in their current state.

Yes, you're right, the changes in the BaseProcessor are not released yet.
The current master cannot be released as a 1.6.x version.
We'll have to move this particular fix into the asciidoctorJ-1.6.x branch and release that.

Further experiments with the latest snapshot version (built locally) do confirm that the problem is fixed by the change in the BaseProcessor class. I guess my question is when can we have an official release? As I see it Java extensions might be broken in the most current release.

Thanks @robertpanzer
I Did a bit of digging and it seems that the relevant change is in fa8fd995c468cb6b49ea22194785f43f5dd31692 (though I'm not sure this change is not impacted or impacts other ones).
I assume you are not planning on releasing 1.7 any time soon then :smile:

I'll try to do a 1.6.2 this week.

Should be fixed with 1.6.2 that I just released.
Please retest and open if you still experience problems.

This works @robertpanzer
Thanks heaps for the quick response.


Fix building transaction extension for Apple Platforms

The repo currently won't build for other OS's because the extension doesn't match https://github.com/swift-server/async-http-client/blob/2588b8cdd4be62f72da849f42ec1d1b25c985937/Sources/AsyncHTTPClient/AsyncAwait/Transaction.swift#L21-L22

@swift-server-bot test this please

Good catch and thanks a lot for opening a PR to fix it!
resolves https://github.com/swift-server/async-http-client/issues/684


Calculate channel percentiles over CPU

See https://github.com/instanseg/instanseg/issues/35
Could increase calculation speed of the percentiles for images >1000x1000 by 20-30x

Addressed in https://github.com/instanseg/instanseg/pull/40


added multi-backend support

Changes made to allow for multiple backend to be selected. If none are selected, that artifact is disabled. Work in progress. Tests need to be altered or rewritten based on how the solution is implemented. Continuation of PR #297
Issue #279 and #288

/ok-to-test

Just a few nits! Would you mind adding an integration test to check for mulitple backends as well?
You could copy TestOCIStorage but also include tekton as a backend and verify both!
https://github.com/tektoncd/chains/blob/a7e0557bf10abbe1d4f3f90e947857ba87890194/test/e2e_test.go#L322

Added new integration test with OCI and tekton backend storage.

/lgtm


Laravel Scout Command is not here

I want to run artisan command inside module directory. I want to import my product model.
I tried this way :
php artisan scout:import '\Modules\Details\Entities\Product'
But Its not working.
Can anyone help me ??
Thanks in advance.

Shouldn't it be enough to just invoke Scout by using the Searchable Trait in your product model?

I haven't used scout before, but I can assume that it's indeed just like any other php feature. Just follow its documentation.

i use this package and i want import product model in elastic. when model created in app directory its work but when we used in module directory laravel scout not imported correctly

i run command and i havent any problem
use ( " ) instead of ( ' ) and use


For space, make required of between word and capture group

For example the pattern
int :[var]

In this case, the space should be required.
Check how Comby behaves

Looks like Comby makes space in the pattern required. This makes it challenging to match both of these with the same pattern
if (something)

if(something)

BECR can match both with the same pattern
if (:[stuff])

However, think with regards to a word character next to a group, should require space.
That way, don't have accidental matches.
The pattern
int :[var]

shouldn't match the text
integer


Error rendering data template: UndefinedError: 'dict object' has no attribute 'json' when trying to run Kindle battery blueprint

Not sure what I am doing wrong here, but I am receiving the above error when trying to run the automation to fetch the battery level of the Kindle.
I have:

Applied the Kindle Online Screensaver patch
Created 2 new entities: input_number.kindle_battery_level and input_boolean.kindle_battery_charging
Imported the blueprint file from the instructions.
Added the 2 new entities to the blueprint
Set the webhook to equal the same as that defined in the add-on config.

This means that I am unable to run the automation as it errors every time. Can anyone assist?

Thank you! The new blueprint gave me the following error:
Error: Error rendering data template: UndefinedError: 'dict object' has no attribute 'query'
However, I am able to pull the battery life of my Kindle to display in HA, which is all I really need to do, so if the blueprint isn't required for me to be able to query the battery life then this can be closed.

Hi, I have gone through the setup again and ensured that the batteryLevel code is correct on my Kindle, but I am still encountering the same error. Do you have any other ideas for what could be the fix?

I tried @sibbl 's updated blueprint but still seeing kindle_battery_level is always 0 and never gets updated.
Fetching images is working fine.
Rendering http://homeassistant.local:8123/z-kindle-e-ink/0 to image...
Converting rendered screenshot of http://homeassistant.local:8123/z-kindle-e-ink/0 to grayscale png...
Finished http://homeassistant.local:8123/z-kindle-e-ink/0
2024-01-14T19:59:27.136Z: Image 1 was accessed

update.sh has this in it:
if [ 1 -eq $CONNECTED ]; then
    batteryLevel=`/usr/bin/powerd_test -s | awk -F: '/Battery Level/ {print substr($2, 0, length($2)-1) - 0}'`
    isCharging=`/usr/bin/powerd_test -s | awk -F: '/Charging/ {print substr($2,2,length($2))}'`
    if wget -q "$IMAGE_URI?batteryLevel=$batteryLevel&isCharging=$isCharging" -O $TMPFILE; then
		mv $TMPFILE $SCREENSAVERFILE
		logger "Screen saver image updated"

and my automation is the same as the one @TomAnks created.  (webhook_id obfuscated)
alias: Kindle - Battery Level
description: Battery level for Kindle Weather Display
trigger:
  - platform: webhook
    allowed_methods:
      - POST
      - PUT
    local_only: false
    webhook_id: 7AA751FBRANDOMHEX9ABCDEFGA85
condition: []
action:
  - service: input_number.set_value
    data: "{{ trigger.json.batteryLevel }}"
    target:
      entity_id: input_number.kindle_battery_level
mode: single

I tried turning local_only to false but that didn't seem to help either.


I wanna add Animation Beforechange

Hello,
I want to add animation using beforechange api.
Someone can show me any way for insert my style codes to current slide before changing ?
I guess i must add class or style to same div which one keep " .slick-active " class but not sure.

const x = document.getElementsByClassName("slick-active");
x.classList.add("animation");