Refactor strtree to not use lgeos / ctypes

This is for the shapely-2.0 branch, to do the equivalent of https://github.com/Toblerity/Shapely/pull/1112 or https://github.com/Toblerity/Shapely/pull/1064 (and ideally only gets done when one of those PRs is merged).
This shows how the lib.STRtree (the C object) will just contain primary keys, which are mapped to geometries (or other items) in the query method using the returned indices.

@snorfalorpagus

I like the new query_items function. This is a real pain in the current API.

That's actually already introduced in the main branch (and so will be in shapely 1.8), coming from #1112 / #1064
Related to the missing docstrings and tests, they were also introduced in #1112, so I need to rebase this branch to pull those in (I made this branch with just similar code changes before #1112 was merged).

Coverage decreased (-0.2%) to 76.961% when pulling e0f19bdcb8a7ffb075307f43bab6f3d62cf926ea on jorisvandenbossche:refactor-2.0-strtree into 4437a92272dc509bf19a44c8021eb24239d4ce24 on Toblerity:shapely-2.0.

I updated the shapely-2.0 branch with the changes of latest master, and so also updated this branch (so docstrings and tests are now already included)

Note that this PR disables the exclusive keyword again in the nearest_item/nearest_geom methods (which was introduced in https://github.com/Toblerity/Shapely/pull/1166), since pygeos does not yet support this.
Of course ideally we fix this before an actual 2.0 release, but I would prefer to not keep up this PR until it's supported in the pygeos version.

Is there an issue in pygeos for the exclusive keyword? It hopefully shouldn't be too difficult to implement.

Didn't do that yet (will do now). Somewhat related, I did just open an issue about some other API incompatibilities between the pygeos and Shapely STRtree: https://github.com/pygeos/pygeos/issues/398

Opened https://github.com/pygeos/pygeos/issues/400 for the exclusive keyword.

Also, should query and nearest be at least deprecated? (These are still in consideration to be removed for 2.0)

Not fully sure, what I think that's a separate issue to discuss.

Since this is only replacing the internals of the tree with pygeos (and not changing any API), I am going to merge this, so I can update https://github.com/Toblerity/Shapely/pull/1163


Could you provide the code to reproduce the result of react on textcraft in the paper?

Could you provide the code to reproduce the result of react on textcraft in the paper?

Just use the run_textcraft.py file with max_depth=1. Hope this helps!


Rule: Expression with label

labels add complexity to our code and in 90% cases you can use functions like takeWhile and etc
fun foo() {
    ints.forEach lit@ {
        if (it == 0) return@lit
        print(it)
    }
}

This rule implemented in #175

#175 merged.


plu addition

plu(A) takes a matrix and returns P, L, and U matrices.  It is not a void method, because it really makes less sense to create these matrices in a different file and send references for in-place.  PLU should generate these matrices.

Consider only 6845dfe, updated with suggestions fro Codacy


improve userinfo

exact creation time
exact join time
nr of infractions
...

also show all roles

Make the username mentionable when doing !userinfo / !info so mods can open up the user's profile and see what their profile looks like. Similar to how Rowboat would used to do.


fix: Transaction is not started yet

added guards to all sentry functions
moved DataSource.connect() to be in one place to fix https://app.zenhub.com/workspaces/tonomy-product-team-62a06b705d27820023023630/issues/zh/324

created AppInitialize.tsx to load the rest of the app after database connected and other settings initialized

removed unused DEBUG variable for production in eas.json
wrapped all code that touches typeorm in proper error handling including waiting for async code so that error can be caught (this is most of the code line changes)
fixed error flow to properly show the error stack trace and log each error only one time for development mode
moved testKeyGenerator() to be in the runtime-tests.ts file
refactors

moved all providers to ./src/providers
removed unused services
moved ./hooks to ./store as there was only one
moved a few services to be in other files as appropriate (time.ts, navigate.ts, polyfill.ts)

:tada: This PR is included in version 0.142.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


No warning/error when an empty password is used

I accidentally entered through the creation of a password for the secret store that I hit when running Get-Secret:
> Get-Secret -AsPlainText -Name testsecret
Creating a new SecretStore vault. A password is required by the current store configuration.
Enter password:

Enter password again for verification:

At that point I'd entered an empty password, but the module didn't complain or anything.
Given that no password is a separate configuration, I'd expect to be prevented from doing this.

Closing as a duplicate of #31


Allow impls to be opaque

This is needed for https://github.com/hacspec/hax/issues/1070#issuecomment-2476182283, we already have opaque types of which this will be an extension.

We need this for both functions and impls. When we see this opaque attribute we should add the val in the fsti, and and assume new name: type in the fst.

We should make sure that we "kill" the body of opaque stuff early to avoid errors in the engine phases about them.

Let's use this as a first step towards making opaque anything we do not want to handle, including raw mutable pointers, static globals etc. That needs a design document.

This needs to be refined for use in libcrux.
When the impl has hax_lib::attributes, we sometimes rely on the specific post-condition within the impl. In these cases, don't want the whole impl to be opaque, instead we only want its fields to be opaque in the interface. In the worst case, if the fields cannot be made opaque, it would be better to leave the implementation in the interface.
This needs to be integrated within the opaque design, perhaps giving the user control over what appears where, with good defaults.


Typescript 1.6

tsc complains about the following:
$ go generate
2015/09/08 12:01:53 running tsc
web/static/js/0-bosun.ts(21,13): error TS2345: Argument of type '{ title: string; templateUrl: string; controller: string; }' is not assignable to parameter of type 'IRoute'.
  Object literal may only specify known properties, and 'title' does not exist in type 'IRoute'.
2015/09/08 12:01:55 run error: tsc: exit status 2
2015/09/08 12:01:55 run complete: tsc
2015/09/08 12:01:55 running esc
2015/09/08 12:01:55 run complete: esc

Could someone with typescript fu look at this?

updated title; upstream is 1.6 stable now.

Can you PR it or just comment here with the code changes?
On Sep 30, 2015 5:38 AM, "Kai S"<EMAIL_ADDRESS>wrote:

updated title; upstream is 1.6 stable now.
—
Reply to this email directly or view it on GitHub
https://github.com/bosun-monitor/bosun/issues/1306#issuecomment-144339513
.


remove CONN_MAX_AGE

Codecov Report

Merging #340 (04f15c2) into master (8a68bc6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #340   +/-   ##
=======================================
  Coverage   87.68%   87.68%
=======================================
  Files          80       80
  Lines        5670     5670
=======================================
  Hits         4972     4972
  Misses        698      698

Flag
Coverage Δ

unittests
87.68% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed
Coverage Δ

tribal_wars_planer/settings.py
92.47% <ø> (ø)


Add generic upsert example in Ruby

Likely using airrecord: https://github.com/sirupsen/airrecord

Fixed by #13


Add air pollution subclasses

closes #263
Additionally this PR adds has_normal_state_of_matter to a couple of subclasses of portion of matter. This was discovered and fixed while working on #263.

methane is no volatile organic compound in my inferred view

methane is no volatile organic compound in my inferred view

When I do the inferred view for oeo-physical only I see:

But in the inferred view of the whole oeo I get:

@akleinau @jannahastings : Any clue what I've done wrong?

Should we have also an equivalent class air pollutant which could collect all air pollutants? We could implement this similar to the greenhouse gases by creating a air pollution disposition.

Methane is no volatile organic compound in my oeo-physical which is a bit weird.

@l-emele how exactly did you implement that methane is a volatile organic compound?

It is currently implemented as follows:
Class: methane
  SubClassOf:
    'portion of matter'
    'has disposition' some volatility

Class: volatile organic compound
  SubClassOf:
    'participates in' some 'air pollution'
    'portion of matter' and ('has disposition' some volatility)

For methane I listed only the relevant SubClassOf-Relations.

with this code I don't see why methane should be classified as a volatile organic compound.
I propose to implement volatile organic compound as an equivalent class thats equivalent to "methane or non-methane volatile compound"

Okay, I've added this in cbbec48. Now it works also for the whole OEO in inferred view:

great. Now there's just the definition for "air pollution disposition" missing: "the disposition of a gas to participate in air pollution"?

I've just first added the air pollution disposition but then deleted it again as I recalled the discussion in #263 where we decided that we want to solve this with a participates in relationship. See commit 0fc3638.

oh wait the air pollutant def has to be changed then, it still has disposition in it

oh wait the air pollutant def has to be changed then, it still has disposition in it

Well spotted, I've fixed it.

Any other comments, @akleinau? Else I'll merge.

no more comments

Merged!
In the end this was way more complicated than I initially thought. Thank you all for help and thoroughly checking.


Bug: Pre-flight check fails in v0.6.0 for a 1.25 version upgrade

Expected Behaviour
eksupgrade would complete the pre-flight checks and confirm the upgrade path is available to users on 1.24 version of EKS.
Current Behaviour
eksupgrade fails on pre-flight on the pre-flight indicating the PolicyV1Api doesn't include a list_pod_security_policy attribute.
Code snippet
eksupgrade eksup-cluster 1.25 us-east-1

Possible Solution
Update the logic around invoking pod_security_policies only if the update_version is below 1.25.
preflight_module.py
        if float(update_version) < 1.25:
            pod_security_policies(errors, cluster_name, region, report, customer_report)

Steps to Reproduce

Created a cluster using eksctl eksctl create cluster -f cluster.yaml. Config yaml below

apiVersion: eksctl.io/v1alpha5
kind: ClusterConfig

metadata:
  name: eksup-cluster
  region: us-east-1
  version: "1.24"
nodeGroups:
  - name: ng-1
    instanceType: t2.micro
    desiredCapacity: 2
addons:
- name: vpc-cni
- name: coredns
- name: kube-proxy

Installed eksupgrade using pip install eksupgrade
Ran the eksupgrade command to upgrade the version to 1.25 eksupgrade eksup-cluster 1.25 us-east-1

Amazon EKS upgrade version
0.6.0
Python runtime version
3.9
Packaging format used
PyPi
Debugging logs
ERROR:eksupgrade.src.preflight_module:Pre flight unsuccessful because of the following errors: ["Some error occurred while checking for the policy security policies 'PolicyV1Api' object has no attribute 'list_pod_security_policy'"]
ERROR:eksupgrade.starter:Pre-flight check for cluster eksup-cluster failed!

Issue is re-opened. The import statements seem to be colliding with the policy api name PolicyV1Api.


Deployment helper tuning

Merge the two deployment helpers together and a bit of cleanup.  Trying to keep it better organized

!coauthor


VEGA-1446 remove unauthorised pact tests

#minor

One file is deleted and the other test commented out so this pr is not required (the commented out test can be deleted at a later point)


push to main is broken when releasing release.yaml with .tekton/generate-coverage-release.yaml

the error
TAG SHA: 77351e97c68011de87141054a2f816cac688943b
Create or update branch: nightly
refs/heads/nightly has been updated to 77351e97c68011de87141054a2f816cac688943b
Uploading file release.k8s.yaml to destination release.k8s.yaml based on d4e66d47b49c0eac28227c000e3318da73a58d6c
Traceback (most recent call last):
  File "/workspace/source/hack/upload-file-to-github.py", line 223, in <module>
    main(parse_args())
  File "/workspace/source/hack/upload-file-to-github.py", line 217, in main
    create_from_refs(args)
  File "/workspace/source/hack/upload-file-to-github.py", line 120, in create_from_refs
    return upload_to_github(args)
           ^^^^^^^^^^^^^^^^^^^^^^
  File "/workspace/source/hack/upload-file-to-github.py", line 195, in upload_to_github
    _, jeez = github_request(
              ^^^^^^^^^^^^^^^
  File "/workspace/source/hack/upload-file-to-github.py", line 75, in github_request
    raise UploadFileToGithubException(
UploadFileToGithubException: Error: 422 - {'messa

fixed in main


Bug: filetype icon doesn't update when filetype is changed

When changing the filetype of a buffer, e.g. via :setfiletype text the filetype icon doesn't change. Below is an example. I opened a Python file and changed the filetype to "text". The filetype name changed accordingly. However the filetype icon stayed at Python.

Self Checks

[x] I'm using the latest lualine.
[x] I didn't find the issue in exsisting issues or prs.

It's because nvim-web-devicons basically has it's own filetype detection. It provides icons based on filename/file_path. Doesn't really let us provide the filetype . This issue can be fixed if nvim-web-devicons adds a way to get icon based of filetype 🤷♂.

I see, it is not really a bug in lualine, I will close the issue. Thanks for the explanation.
Regarding the usecase. I often use scratch buffer for various things. Sometimes I would write out some code (e.g. while reviewing a PR) and switch the filetype to python to have syntax highlighting. Afterwards I might use the same scratch buffer to outline some text and would switch the filetype to text (to disable syntax the syntax highlighting).


Fix Typo

Change E into R

Ah damnit, i thought it would be a seperate pull request but apperantly it isnt. And ofcourse i dont have enough experience with git(hub) to know how to change it back, my bad.

Yes it is and thank you :D it's really small but i guess it's something

Thanks!


pythonPackages.nose-randomly: add checkPhase

Motivation for this change
Otherwise timeouts in darwin python2 with the default checkPhase https://hydra.nixos.org/build/86142595
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[X] NixOS
[X] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[X] Fits CONTRIBUTING.md.

@GrahamcOfBorg build python2.pkgs.nose-randomly python3.pkgs.nose-randomly


Add Bot to Discord Sever

Provide the user with the ability to add the bot to their server. This will involve redirecting to the given URL then having a response URL.
URL: https://discordapp.com/api/oauth2/authorize?client_id=426185674950180865&permissions=8&redirect_uri=REDIRECTURLHERE&scope=bot

Closed by 7ed9bd60


[Snyk] Upgrade @types/react-redux from 7.1.14 to 7.1.15

Snyk has created this PR to upgrade @types/react-redux from 7.1.14 to 7.1.15.

:information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

The recommended version is 1 version ahead of your current version.
The recommended version was released 21 days ago, on 2021-01-01.

Release notes

Package name: @types/react-redux

7.1.15 - 2021-01-01

7.1.14 - 2020-12-24

    from @types/react-redux GitHub release notes

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:
🧐 View latest project report
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs

Coverage decreased (-0.04%) to 70.28% when pulling 529b8ab08e1be8dc3338537c46b01e93aa658f7b on snyk-upgrade-013c50fb394ca7f5b570eb8b15faeff0 into 3ced77ccc6065ab57c64a50fba81bc16573d5d40 on develop.

Coverage decreased (-0.04%) to 70.28% when pulling 529b8ab08e1be8dc3338537c46b01e93aa658f7b on snyk-upgrade-013c50fb394ca7f5b570eb8b15faeff0 into 3ced77ccc6065ab57c64a50fba81bc16573d5d40 on develop.


Question: When Creating a Request from the Event Details page, would it make more sense to populate the zip code of the Request to match the zip code of the Event?

@tonysurma @stevejgordon @MisterJames @dpaquette
When creating a Request via the UI, you do so in the context of an Event:

Since every Request has an EventId/Event property that needs to be populated to associate a Request with an Event in order for the Event to be assigned to an Itinerary, would it make more sense to pre-populate the Create Request page with the information from the Event?

Here you can see the user can enter any zip code they want (along with other information). The problem with this approach is we can only see Requests that are associated with an Event in the Event Details page. This is how Requests get assigned to Itineraries.
If a Request is created w/out an Event, it will be "orphaned" b/c of how our UI currently works, and we'll never be able to assign the Request to any Event.

Requests need to be assigned an eventid upon import or api reception

I would also assume we want our Requests created to be aligned with the Event's zip code so we know when that Request is added to an Event's Itinerary, it can be serviced b/c it's in the servicable area of the event.
So, these fields should really not be assignable at all, but instead appear as read-only on the Create Request page and the information should be copied from the Event in which the Request creation is taking place.
Thoughts?

@mgmccarthy The request in our domain represents an install location. So I can request a smoke alarm at my home address. That is the address which is stored as part of the request. If you then made a request you would have your address stored there.
This most commonly will happen via API calls from getasmokealarm We'll need to assign those to an event based on whatever rule set we apply. The next option is CSV import which is more a backup that a main input method as I understand it.
For the manual request creation (which is a final fallback more than anything else and I suspect will be rarely used) we set the EventId on the request to match the event from which the Create Request button was clicked. So it will always be set to the correct event. In the screenshot you can see the correct event is set already.
I agree we might end up with orphaned requests from API or CSV depending on how we determine we should handle those and map them to events.
There's also the possibility that we end up with requests, linked to an event but which fall outside of that event's intended service area. In that case an Admin would probably just cancel the request.
I'm not sure how Zip codes work in the US but is it not possible that multiple zip codes will be covered by one event across say a large city? In the UK at least our postal codes are very specific so requests on different streets next to each other could and usually will have a distinct code.
Not sure if I've interested your query correctly but hopefully that answers the query?

@stevejgordon, thanks for the feedback. I'm looking over what i initially wrote, and it's wrong (most of which you picked up in your reply to me). I wrote it in a hurry, so I made mistakes. I just corrected it. I'll weigh in on the other things you mentioned in your reply as well when I get to work.
Thanks

For this issue, the problem still remains that when creating a Request via the UI, we're allowing a user to enter city/state/zip, and all that information could be outside the serviceable area of the Event. If this Request gets added to an Event's Itinerary, then we could essentially be sending out sms confirmation messages to a requestor that is in a completely different state than the Event.

@mgmccarthy that concern isn't a concern from a user/UI/requirements perspective.  All of that data is and should be enterable by the user.  Even for our current use case for the initial roll out, we can't model restrictions that may or may not exist as it gets super complicated.  For example, as @stevejgordon referred to zip code density is variable so in some areas it would be insane for it to be another zip code but in others it is very likely several zip codes could be in same itinerary.  Same goes for even state boundaries as those can be arbitrary and one part of a neighborhood is in MO and the other is in IL etc.
For that reason I am going to close this issue as we don't need to make this change from a requirements perspective but great discussion and glad we are closing out all these types of areas as we get closer to release.
That being said we definitely need to get some ideas from @OhMcGoo @schuback on how to map the requests coming in to events as that is not a logical process (aka if a to b then goto event X) and more based on delivery and organizational structure of the red cross's work on this campaign.

@mgmccarthy
In terms of the csv and manual creation being backups, I will defer to @tonysurma but I think the goal is for things to come in via the API in most cases. If that's not ready at go live I believe csv is a fallback. I would assume this remains true for any other organizations/campaigns as they come online since there could be integration work that means csv is needed.
For the issue at hand here. It will only be an org admin (or perhaps site admin) creating the requests so the assumption is that they will only add requests they intend to service. Presumably only test requests and perhaps in cases where they have manually signed up people. Therefore I don't think there's a major risk here. If the org admin puts in a request outside of their area then I'm not sure how we can validate that directly. Unless we havea set of geocoded points representing the area for an event which we can compare the location against.

@stevejgordon also to validate you are right that manual entry is kinda last stop/last resort.  PRimarily there for testing and secondarily there for some random ad-hoc add a request but otherwise GASA API is primary as you said and CSV is secondary.

@stevejgordon @tonysurma thanks guy! I do feel more informed about how the system should be working from the conversation above... especially the comments about zip code density.
that being said, we'll still need to tackle the task of assigning a Request to an Event when we create a request (from API/CSV)
One idea is to NOT associate a Request to an Event for the API/CSV imports. If this were done, we would need a way to still which Requests could be a potential match for adding to an Itinerary based on zip code/zip code density/ regions etc...
We would need to update our current UI to pull back all Requests based on zip code that could be eligible for that particular Event/Itinerary.
that way, we're not not forcing an Event to a Request association until the Request is ready to be acted on (aka, ready to be assigned to an Itinerary)

@mgmccarthy interesting idea and then have the admin also have an 'associate' request just like the create request on the event.  We could at least dump the requests under the organization at ingestion then so that Tony Org can't see requests that came in to Steve Org for example.
Should we continue discussion here and change name (again 😸 ) or move to another issue?

@tonysurma Sounds sensible to have somewhere we can view "orphaned" requests. We could have a few issues and possibly address this at the code-a-thon. Something like

Add Org level page (or maybe campaign level if we can at least determine campaign via API) to list requests without an event id set
Clicking on a request displays a page/modal allowing an campaign and event to be set

If that sounds reasonable I can break out some issues along those lines
For CSV as it's a manual process to import I presume on the import screen we can/or should be able to choose the event we're importing under? With the assumption that data is validated by the admin prior to importing?

the discussion about not associating an incoming Request with an Event has been broken out into Issue #1591

@tonysurma @stevejgordon @MisterJames I've broken this issue out into #1591. We can track convos/decisions there. Thanks!


X entropy loss input dimensions

output
gives tensor([[-1.5800e-01, ...  1.1632e-01]], grad_fn=<AddmmBackward>)
target
gives tensor([10, 29, 14, 73, 96, 55, ..., 94])
target[c]
gives tensor(10)
So criterion(output, target[c]) gives RuntimeError: dimension specified as 0 but tensor has no dimensions. See PyTorch doc's about CrossEntropyLoss, it expects inputs of shape: "Input: (N,C) where C = number of classes" and "Target: (N)".
target[c].view([1])
gives tensor([10]), which fixes the error.
return loss.data[0] / args.chunk_len gives IndexError: invalid index of a 0-dim tensor. Use tensor.item() to convert a 0-dim tensor to a Python number.

Never mind, I see that this PR is equivalent to this PR: https://github.com/spro/practical-pytorch/pull/120


Include git metadata under formulation

Pass --include-formulation to capture git metadata under the formulation section. Example below:
"formulation": [
    {
      "bom-ref": "f8324846-fad6-4927-a8e7-49379f57489b",
      "components": [
        {
          "type": "file",
          "name": ".gitattributes",
          "version": "eba1110b5794582b53554bb1e4224b860d4e173f"
        },
        {
          "type": "file",
          "name": "README_zh.md",
          "version": "70e6883720e454e3f2fe30c9730b3e56c35adc28"
        },
        {
          "type": "file",
          "name": "docker-compose.yml",
          "version": "7e9c878ee725717b3922225f26b99931332ae6c8"
        },
        {
          "type": "file",
          "name": "pom.xml",
          "version": "8da3449df64e6eb1d63ca3ca5fbd123a374d738e"
        },
        {
          "type": "file",
          "name": "src/main/java/org/joychou/Application.java",
          "version": "41169b9a018f38ee62e300047d5a6bd93562f512"
        },
        {
          "type": "file",
          "name": "src/main/resources/url/url_safe_domain.xml",
          "version": "ee81efcf364e18221c401e03f1d890348fe73e87"
        }
      ],
      "workflows": [
        {
          "bom-ref": "9f66ea8d-b1b7-4c79-8294-376903ec1bc8",
          "uid": "c451097b-5c74-49db-ada7-81bd77cdb390",
          "inputs": [
            {
              "source": {
                "ref": "git@github.com:HooliCorp/java-sec-code.git"
              },
              "environmentVars": [
                {
                  "name": "GIT_BRANCH",
                  "value": "master"
                }
              ]
            }
          ],
          "taskTypes": [
            "clone"
          ]
        }
      ]
    }
  ]

cc: @heubeck, what other property might be useful?
Also fixes https://github.com/CycloneDX/cdxgen/issues/369

how about build tools like github actions detected and sdks (if identifiable) - not sure what exactly you have in mind

how about build tools like github actions detected and sdks (if identifiable) - not sure what exactly you have in mind

This is already possible by running cdxgen with -t os against the build machine. This data needs to be collected less frequently only when the build machine changes.


iOS universal linking not working with meteor

My next app has to support universal linking for both iOS and android. For android everything is working but for iOS I just can't get it to work.
I'm using Meteor and react to develop my app.
For Meteor we have to use a "mobile-config.js" file to generate a config.xml file. I'm using the following code: (I have changed my bundle ID and team ID in the pasted code for security
App.info({
  id: 'com.feu.project.sasmus',
  name: 'My website',
  version: 0.2,
  ....
});
....
App.appendToConfig(`
  <widget id="com.feu.project.sasmus" version="0.0.1" xmlns="http://www.w3.org/ns/widgets" xmlns:cdv="http://cordova.apache.org/ns/1.0">
    <universal-links>
      <ios-team-id value="8GFQSAHBBL" />
      <host scheme="https" name="website.eu.meteorapp.com" event="didLaunchAppFromLink"/>
    </universal-links>
  </widget>
`);

The "didLaunchAppFromLink" is living in my main.js file and is implemented in the following way:
componentWillMount() {
    if (Meteor.isCordova) {
      universalLinks.subscribe('didLaunchAppFromLink', function(eventData){
        browserHistory.replace(eventData.url);
      });
    }
  }

(this is working for android so I assume this will also work for iOS?)
I created an "apple-app-site-association" file and place this into my root folder. I did this in the following way:
{
  "activitycontinuation": {
    "apps": [
      "8GFQSAHBBL.com.feu.project.sasmus"
    ]
  },
  "applinks": {
    "apps": [],
    "details": [
      {
        "appID": "8GFQSAHBBL.com.feu.project.sasmus",
        "paths": ["*"]
      }
    ]
  }
}

This file is downloadable like apple wants it via the following link: https://website.eu.meteorapp.com/apple-app-site-association (this won't work here because I changed the website name for security reasons)
So far as I know I completed all the tasks and I don't see where I did wrong. Can anyone help me?

Hello @EuropeanUniversityFoundation how did you end up fixing this?  I'm currently working through the issue right now and having the same effect.  Android is working with meteor-cordova, ios will only open in safari.
I've already tested other urls, for example youtube urls will open the app in whatsapp, but slack will open safari still.  So I've at least ruled out that universal links do in fact work for the way I am clicking them on my phone, just not with my app.

Maybe you are using cordova facebook4 plugin, it has a bug, it catches all incoming urls and doesnt correctly return FALSE(NO) when the url is not handled by this plugin.
i've experienced this issue using the firebase dynamiclinks plugin.
we solved this by simply creating a window.handleOpenUrl = function(url){} this is a feature of cordova for ios (atleast for the latest versions), i guess this link catcher runs before others so you can parse the universal link there.

any one tried my solution?

@sirpy did you file a bugreport with the cordova facebook4 plugin? could you share the link?


change back button title not work

none of them works, is it possible to work?
.introspect(.navigationStack, on: .iOS(.v16,.v17)) { (nv: UINavigationController) in
        nv.navigationBar.topItem?.backBarButtonItem = UIBarButtonItem(title: "", style: .plain, target: nil, action: nil)
        nv.navigationBar.backItem?.title = "some"
        nv.navigationBar.backItem?.backButtonTitle = "some"
}

Please give me a bit more information to work with. Are you trying to:

Change the title of the back button to "some"?
Remove the "<" arrow from the back button?
All of the above?


WIP: Port A* and floodFill from Neatness

Do you want to keep updateValue, updateFunction, 'walkFunction' etc or do you want the "classic" versions?
There are some issues with types, will look into that
A WIP for now :)

Hi, thanks for the PR! I wanted to take another look at those functions really, they can probably use some refactoring as stuff I write for js13k is usually quick and dirty and full of errors. :)
May I ask if you're using / planning to use natlib for something? And if yes, how can I assist with that.

I wanted to take another look at those functions really, they can probably use some refactoring as stuff I write for js13k is usually quick and dirty and full of errors

Well, doing some refactoring was the idea, hence the question about extra arguments and your thoughts / plans for these functions as part of natlib. I pretty much copypasted them from neatness and slapped the good old WIP on this PR anyway.

May I ask if you're using / planning to use natlib for something?
Not yet, but maybe in the future. Just got laid off and thought I'd do something meaningful with the free time I got and return some favours for old times sake :)

Just got laid off

So sorry to hear that!

@mvasilkov A* should be good to go, I'll take a final look later to see if there's anything I don't like, but if you have time you can start reviewing the changes and tell me if you want anything changed / fixed / added / removed.
Also - do you prefer having a separate README in a folder or just a comment inside the file? I'll write some usage notes too.

Hi! Sorry for slow replies.

you can start reviewing the changes and tell me if you want anything changed

It's easier to show than tell :) But really I was thinking that

Technically A* isn't even grid based, so a good implementation of the algo will be generic graph-based (and will support different costs)
But then again I don't see myself using it on something other than a grid, so might as well stay grid-based
However it absolutely shouldn't receive the grid itself! Because the algo still doesn't know nothing about how I want my levels to work (for example boundary check is was useful for The Neatness, but you can't make a circular level with it).

 I'll work on it a bit and I'll post the results.

wasn't called for the starting pixel

This is intentional — DDA also does that. The idea is, you're already in that location, so walking there is a no-op. (This also makes going from A to B to C to A consistent, we don't visit the same location twice.)

I'll push something today which is my vision for it. Just need to see if it works correctly first.

Here, this is my take: https://github.com/mvasilkov/natlib/commit/2fa5d508b3ce582e01fb04de77578ae850071774#diff-b2c96a375d2e88f63e621031a6aeaaa0d3bfc6bb2b9fa662ec4d69fb8d1cdc62R1
The idea is, GetAdjacent is a generator function (function*) that yields tuples of [x, y]. This is not the cleanest way (that would be working with Vec2 throughout) but I think it's good enough? Still way more memory allocations than I'm comfortable with.

Closing this request since you've already ported both A* and floodFill :)
Any help you might need on other issues?

Hey hey, yeah thanks to you I had just enough motivation to finally get this done :)
I think the most problematic thing right now is the lack of examples (and docs, but that's a whole another issue). The examples live here: https://github.com/mvasilkov/natlab
Usage on that repo, until I make a proper dev server:

git clone
(Optional) set up a Python virtual env
yarn
(Optional) link natlib from the master branch, e.g. yarn link natlib
pip install -r requirements.txt
python build/build.py this builds html pages from templates
tsc -w
In other tab: run any web server. E.g. python3 -m http.server

Reasonably complete demos are:

prng32
easing_functions
verlet_basic
dda

Here's some screens of what you should see:

As for which examples are missing: like, all of them! The endgame is to make a number of very simple games (I've started one, in the folder flappy_birb, but got nowhere with is at this point...)
Stuff like

Very basic platformer (no graphics, just some colored squares)

Collision detection for that is still missing from natlib, I have it on my endless TODO list...

Simple flappy bird clone
Simple physics-based game
Literally anything else that can make use of natlib


Rule for setNonce cheatcode

I don't think the current rule is applied if the target account does not already exists. For example, Foundry allows vm.setNonce(address(0), 3) even if address(0) denotes an inactive account. In this case the account needs to be created first (also see https://github.com/runtimeverification/foundry-tests/issues/27).
I'm currently trying to figure out the best approach to implement this because I'm working on load/store and they work the same way. I'll report back once I have a solution, but in case you are also looking into this let me know of anything interesting you find out.

@david-k that's exactly what I am trying to test right now. I also think that I will have to change the rule for the getCode cheat code. I'll update you with my progress working on this. Thanks!

I don't think the current rule is applied if the target account does not already exists. For example, Foundry allows vm.setNonce(address(0), 3) even if address(0) denotes an inactive account. In this case the account needs to be created first (also see runtimeverification/foundry-tests#27).
I'm currently trying to figure out the best approach to implement this because I'm working on load/store and they work the same way. I'll report back once I have a solution, but in case you are also looking into this let me know of anything interesting you find out.


Menu commands should operate on frontmost window, not on first reader window

As far as I know this was fixed long ago.


Add new docsref page, fix docs border-radius issues

Alternate fix for #38114.
This refactors things a smidge to give us consistent borders and border-radius values around all our code snippets and examples in our docs. I started by removing all borders and rounded corners, and then slowly restoring them. This feels cleaner and leaner to me, but I wasn't sure about use cases. So I built a new /docsref page, which serves as a docs kitchen sink of sorts for our docs-specific components. Let me know if I'm missing anything else here, goal is to give us a quick way to test rendering just like any other component.
One thing I'm not 100% sure on is if I can remove all .bd-example-snippet instances and change our one JS selector looking for that to .bd-code-snippet. Will dive back into that later.
Because I'm choosing not to render the new /docsref page in the sidebar, I've also added a check in the sidebar navigation for existence of sidenavActiveLink.

Not sure about the new page, though. I mean, if we can't see it, even we can't know it's there 😛
Not sure how to make it so that we know about it, but without bloating the sidebar more.

Not worried about us finding it right now, it's for testing when we need it for the border-radius work. I'm waiting on @julien-deramond to review once more before merging, but I think this should be good to go otherwise.


v2 API - refactor class and package names

Part 6 of n PRs for feature-284-refactor-datastore-indexmanager. See parent issue #284.
The focus of this PR is choosing appropriate names for classes and packages which have been sub-optimal in the past.

Rename IndexManager to Query
Rename DatabaseX events to DocumentStoreX
Rename DatastoreXException exceptions to DocumentStoreXException
Main top-level packages now com.cloudant.sync.{documentstore,event,internal,query,replication}

TODO

consider using an interface on DocumentRevision to hide methods like getParent and getInternalNumericId which shouldn't be on the public API.
update findbugs config appropriately
update javadoc so that com.cloudant.sync.internal stuff is hidden

Do we really need the ErrorInfo class? It seems pretty pointless to me.

@rhyshort good point, do you think we should replace its use with a direct usage of Throwables?

Yeah I think so, since its only wrapping a throwable

@rhyshort all files without a licence now have them, and the number of licence variants has been reduced as much as possible. I think this is all the appropriate licence activity for now, but we still need to do #390 some time.


Fix text select

This would allow the user to select everything - including button contents and would bug with playlists.
I am closing this pull request. If you wish to fix the issue, make sure only things that should be able to be selected and selectable and open a new pull request.
Thanks

Notice that the commit is not same as quickfix.

@ProditorMagnus I noticed, however this would allow selection of things we would rather not to be selectable


CorsPolicyService not being called

I'm trying to use a custom policyservice, but it is never being called:
Our experience is similar to what is described in a previous issue: https://github.com/IdentityServer/IdentityServer4/issues/3075
The implementation of ICorsPolicyService is simple:
public class VerjiCorsPolicyService : ICorsPolicyService
    {
        private readonly string[] _corsOrigins;

        public VerjiCorsPolicyService(string[] corsOrigins)
        {
            _corsOrigins = corsOrigins.Select(o => o.Replace("http://", "").Replace("*.", "")).Distinct().ToArray();
        }

        public async Task<bool> IsOriginAllowedAsync(string origin)
        {
            if (_corsOrigins.Any(o => o.EndsWith(origin)))
            {
                return true;
            }

            return false;

        }
    }

I've made sure to register the service before IdentityServer:
            var verjiCorsService= new VerjiCorsPolicyService(corsOrigins);
            services.AddSingleton<ICorsPolicyService>(verjiCorsService);

The log says:
31 Oct 2019 10:42:48.295
 CorsPolicyService did not allow origin: https://admros.staging.wc.verji.io
31 Oct 2019 10:42:48.295
 Origin https://admros.staging.wc.verji.io is allowed: false
31 Oct 2019 10:42:48.292
 CORS request made for path: /.well-known/openid-configuration from origin: https://admros.staging.wc.verji.io

But IsOriginAllowedAsyncis never called.
Is there some other way we should register the custom policy service to make it take effect?

Register it after - I don't recall if we use TryAdd or not for our default.

Thanks for your reply,
I was able to make it work by registering the service after IdentityServer as you suggested.
But only after removing the standard Asp.Net Core CORS configuration (AddCors+AddPolicy/UseCors).
So something is not right with either IdentityServer or the docs (or both). According to the docs in the section Mixing IdentityServer’s CORS policy with ASP.NET Core’s CORS policies, it should be possible to have both standard AspNet Core CORS alongside a custom ICorsPolicyService if you register the custom service prior to IdentityServer. We could not make that work.
Since I am only hosting IdentityServer in this service I don't really need to mix the two, so I will continue using our custom implementation of ICorsPolicyService.
(Strangely, using only the standard AspNet Core CORS setup seemed to work (I could log in), but I kept getting those messages in the logs that CORS failed.)
Now with the custom cors service, the log messages are normal.
Thanks,
Thor A. Johansen
Rosberg AS


Add a Gitter chat badge to README.md

nicolasduval/datalab-api now has a Chat Room on Gitter
@nicolasduval has just created a chat room. You can visit it here: https://gitter.im/nicolasduval/datalab-api.
This pull-request adds this badge to your README.md:

If my aim is a little off, please let me know.
Happy chatting.
PS: Click here if you would prefer not to receive automatic pull-requests from Gitter in future.

Current coverage is 93.52%

Merging #1 into master will increase coverage by +4.69% as of a04eca0

@@            master      #1   diff @@
======================================
  Files           17      26     +9
  Stmts          206     355   +149
  Branches         0       0
  Methods          0       0
======================================
+ Hit            183     332   +149
  Partial          0       0
  Missed          23      23

Review entire Coverage Diff as of a04eca0

Powered by Codecov. Updated on successful CI builds.


Replace Cloud Build Maven cache with a .tar file

The Cloud Build Maven cache should be implemented with downloading/extracting/uploading a .tar file instead of using gsutil.
See context: https://github.com/GoogleCloudPlatform/google-cloud-graalvm-support/pull/105#issuecomment-812915381

Here is a hacky starting point
    -   name: 'gcr.io/cloud-builders/gsutil'
        entrypoint: bash
        args:
            - '-c'
            - |
                mkdir -p .m2/repository/
                cd .m2/repository/
                gsutil cp gs://m2_cache/$REPO_NAME.tar .
                if [ -f "$REPO_NAME.tar" ]; then
                    echo "Extracting archive"
                    tar -xf $REPO_NAME.tar
                    echo "Extracted"
                    rm $REPO_NAME.tar
                    ls
                fi
                true

    # Store m2 cache
    -   name: 'gcr.io/cloud-builders/gsutil'
        entrypoint: bash
        args:
            - '-c'
            - |
                echo "Creating m2 repository tarball..."
                tar --directory /workspace/.m2/repository -cf $REPO_NAME.tar .
                gsutil cp $REPO_NAME.tar gs://m2_cache/

This approach completes the transfer in a few seconds usually and tar-ing is very fast.

@kostacasa -- Thank you!! This is a great help.


[Http2Layer]: Can not login to facebook/google

Can not login to facebook/google with http2 layer.

It seems like mitmproxy with the master branch has resolved the issue already.


Overriding Successfully verified your email! Template in Parse Sever Example

Is their a way to create your own override of the paser-server html template verify_email_success.html that can be customized in the parse server example area?
FYI im not talking about the emails that get sent out, but after you click the link.  Thoughts?

For Invalid Link, Password Reset Success, and Verify Email Success page, you can go to your Parse Folder > node_modules > parse-server > public_html , there are 3 html files.
For the reset password view you can go to  Parse > node_modules > parse-server > views > choose_password, if you open it on text editor it has html file structure, I don't know the reason actually why the file extension isn't .html.
Hope it's helpful.

I'm still getting to know my way around nodejs and parse-server but the answer @andreas-cindra provided is very invasive (you'll have to change them each time you update parse-server). Instead there are variables exposed that can be customized when initializing parse server. Inside ./node_modules/parse-server/lib/Config.js I've found customPages variable where you can set things like invalidLinkURL, passwordResetSuccess and more.


Remove target_clusters as it is not longer used

part of APPSRE-7549

This is a breaking change: app-interface has already been cleaned-up and there are no reported prometheus tests in FedRAMP.


Keeping a clean query string for pages with relation manager

There is no need for activeRelationManager query string when displaying a single relation or the first one.

0 isn't always the array key for the first tab. It needs to be retrieved from the relation managers array (it's the first array key). To do this, you will need to replace $queryString with queryString() so it can be dynamic.

Are you able to handle this, @linaspasv?

I was very busy lately but will get back to this once got some free time. This could probably be closed for time being and I would open a new one once ready.

Alright, thanks for letting us know!


Button to scan all items ?

Hello @josdemmers , is it possible to scan all inventory or does it only work when you hover over an item and it's tooltip is shown ? Thank you

It only works when the tooltip is visible.

Can the mouse maybe been automatically moved over the items and checked if there are 3-4 affixes that match, if not the mark the item as junk?

Can the mouse maybe been automatically moved over the items and checked if there are 3-4 affixes that match, if not the mark the item as junk?

I have no plans to automate anything.

Seems legit^^


DOC: Added mode='mirror' in the docstring for the functions accepting it

I discovered that mode='mirror' is acceptable (read : did not crash) for the function ndimage.shift. So I added the option to the docstring and all other functions accepting the mode keyword, which also all 'work'.
This raises the question was it simply forgotten (and here is the fix) or is it a non working, long forgotten mode that should be avoided?

Thanks, I think it was forgotten --- there are tests for it for geometric_transform, and the code path for mode selection seems same for others. If you find evidence to the contrary, we can revisit this.

I tried their respective example with the keyword for all 5 of these, and it worked without apparent issues. Unless the results were bogus, it just seems like someone forgot about it.


.ignore file is too aggressive - excludes codeStyle settings

Prerequisites

[X ] Plugin is in the latest version
[ X] Issue was not reported yet
[ ] Stack trace (if provided) contains mobi.hsz.idea.gitignore package name

Description
Description of the issue
When auto-generating .gitignore for Jetbrains, the following line is emitted:
.idea/*

This is too aggressive. The following path should be stored in git:
.idea/codeStyles/*

Steps to Reproduce

Create a .ignore file
select "Jetbrains"
click "generate"

Expected behavior: What you expect to happen
selected directories and files in the .idea/ folder to be ignored
Actual behavior: What actually happens
.idea/* is emitted in addition
Reproduces how often: What percentage of the time does it reproduce?
100%
Versions
2.4.0
Can be found in Settings > Plugins > .ignore

IDE:
CLion
Can be found in Help > About. Click on the copy icon on the left.

OS:
Linux driveby.local 4.14.18-300.fc27.x86_64 #1 SMP Thu Feb 8 01:35:31 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Additional Information

@madmongo1
All of the templates - incl. JetBrains one - come from the https://github.com/github/gitignore repository.
However the one that you mention: https://github.com/github/gitignore/blob/master/Global/JetBrains.gitignore doesn't even contain .idea/* rule.

Hum. I'll create a new project and check again. Suggest you assume it's my error, and I'll re-investigate.


Department automatically switches back to some fixed value

One of our users ( :smile_cat: ) is supposed to be a member of department D1 but gets constantly and without interaction switched back to some other department D2.

This is most likely caused by the ldapimport command. This sets the main department for a user to a value defined in the ldap/active directory.

Yes it is.
Apparently user attributes get synced everytime ldapimport runs.
What's the reason for this?
I could think of setting a sync blacklist:
AUTH_LDAP_USER_ATTR_NOSYNC = ["LDAP_attr2"]
AUTH_LDAP_USER_ATTR_MAP = {
    "django_field": "LDAP_attr",
    "django_field2": "LDAP_attr2"
}

And then test for
if old_value != new_value and attr not in settings.AUTH_LDAP_USER_ATTR_NOSYNC:
    saveuser = True

in the same line.

This is done in case those attributes change.
This option is added in 5bd4cea82dfe0c49982d570f2f249f158efae64b


Suppress float equality warnings

Resolves #99 by silencing float comparison warnings. This can be merged into the 1.0 branch.

We also have a sweet new deprecation macro now that we can use for any future removals.

Looks good feel free to merge it


[QoI] Don't rely on extension type to be present when validating its attributes

Malformed 'extension' expressions won't have extended type avaliable,
so don't rely on that when validating its attributes.

/cc @rudkx @DougGregor

@slavapestov Done!

@swift-ci please smoke test and merge

@DougGregor since #6072 got merged, I am closing this one.


Use Devise lockable strategy

Who is this PR for?
Security improvement.
What problem does this PR fix?
Right now we don't have good visibility into repeated unsuccessful login attempts and we don't handle them in any particular way.
What does this PR do?
Uses the Devise lockable strategy to lock out a user for 24 hours if they try logging in with the wrong password too many times in a row (maximum attempts currently configured to 4, but we could adjust this number).
Also adds an email hook to notify us when a user gets locked out to increase visibility. This could go to Insights developers, school-based IT staff, or a mix of both; configurable via an ENV variable.
GIF

Checklists

[ ] Author included specs for new code

Rebasing this on top of #1701.

OK, this spec failure is really good and important. The way I read it, Devise lockable worked out-of-the-box with database authenticable, but fails when implemented with our custom LDAP Tiny strategy. This is exactly the question you were bringing up @kevinrobinson — looks like you were 💯% right to be wondering how this would work with our strategy.rb. This is also a great example of how shipping #1701 helps us build & test better security features!
So the next step I'll look at is writing some custom code in our LDAP Tiny strategy that updates locked_at after a given number of failed attempts. Will start on that Monday. My hope is that it's relatively simple to glue lockable into our strategy.

One thing that I see here, especially in 9bc9ef7fcfdac01e02b8958018ada1a127d3f604, is that Devise :lockable is not a drop-in security feature with our custom LDAP Tiny strategy. It only works as a drop-in with the :devise_authenticable strategy. This shifts the scope/prioritization for this work. Landing this PR will take more time and effort and testing than it would if it were a drop-in feature. I originally conceived of this as "low hanging fruit." Since it's not necessarily low hanging fruit anymore, it may make sense to land other, higher-value security features first, like incremental two-factor authentication.

Broke the devise.rb config changes into their own pull request (#1824) so that this one is easier to review and has less unrelated diff, especially since at this point it looks like the work will involve writing our own custom :lockable instead of Devise :lockable.

Hmmm, I tried to rebase this one on top of master using git rebase -s ours master so that it would favor the master branch's changes to devise.rb over this branch's changes to devise.rb...
It seems the strategy I used was a bit too aggressive and wiped all the commits off of this branch. 😅  I'm sure I can get them back via git reflog, but honestly starting over wouldn't be the worst thing since I'm re-implementing :lockable here manually.

@alexsoble 👍 fwiw, in that situation using merge might do what you're looking for:
$ git checkout set-up-lockable
$ git fetch
$ git merge origin/master

@kevinrobinson Yeah, that would have done the trick I think! I like the way rebasing keeps a clean commit history, so I was curious if there are any strategies that I could pass to git rebase that would perform a regular rebase but always default to one branch or the other if there are conflicts.


[Bug]: youtube cant open

What happened?
A bug happened!
youtube cant open in edge
i give a vid
https://user-images.githubusercontent.com/78718780/180789664-6ee2732f-2d7c-4563-84cd-8c23445e1b53.mp4
To reproduce the behavior?
reproduce!
open edge>google=youtube>click youtube
What browser are you seeing the problem on?
Chrome

Probably can't iframe YouTube.


Explicit signature for KafkaObservableConsumer.autoCommit

Hello!
The current the way to create a kafka autocomit consumer observable is by using the apply method from
KafkaConsumerObservable, to me it would be more explicit to have a separated signature for that purpose which would be autoCommit.
Also I think that the current public method createConsumer(): Task[Consumer[K, V]] could be private, since it should only be used internally.
What are your thoughts?

Closing there was no interest, probably the current apply method is generic enough and this signatures is not necessary.


update the repo name from common-service-operator to meta-operator.

What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes # resolve tide for https://github.com/IBM/meta-operator/pull/26
Specify your PR reviewers:

/cc @gyliu513 @morvencao @clyang82
Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

/lgtm


Fix links to PodOverhead Feature Design (language/es)

/lgtm

Nice catch! Thanks.
But please limit this PR to one language, and open one PR per languages after merged.
/hold

@Sea-n Done :)

/check-required-labels

/remove-language ja

Thanks, now it's ready for review!
/unhold
And the new link is correct.
/lgtm

/lgtm
/approve


Windows formatted GMsh file cannot be loaded

I'm having a same problem to #929 (can't find the $Element section), but for a different model (see attached).  The attached files are *.msh files.
example_linux.txt
example_windows.txt
import meshio
geom = meshio.read("example_windows.msh")

With the newest version I simply get:
Traceback (most recent call last):
  File "gmsh_to_nastran.py", line 154, in <module>
    main()
  File "gmsh_to_nastran.py", line 146, in main
    make_geometry(gmsh_filename, nastran_filename)
  File "gmsh_to_nastran.py", line 150, in make_geometry
    geom = meshio.read(mesh_filename, file_format=None)
  File "C:\Python37\lib\site-packages\meshio\_helpers.py", line 68, in read
    return reader_map[file_format](filename)
  File "C:\Python37\lib\site-packages\meshio\gmsh\main.py", line 19, in read
    mesh = read_buffer(f)
  File "C:\Python37\lib\site-packages\meshio\gmsh\main.py", line 48, in read_buffer
    return reader.read_buffer(f, is_ascii, data_size)
  File "C:\Python37\lib\site-packages\meshio\gmsh\_gmsh41.py", line 59, in read_buffer
    raise ReadError()
meshio._exceptions.ReadError

I think the core of the issue is that the read uses "rb" instead of "r".
def read(filename):
    """Reads a Gmsh msh file."""
    filename = pathlib.Path(filename)
    with open(filename.as_posix(), "rb") as f:
        mesh = read_buffer(f)
    return mesh

I'm new to the GMsh format, but my guess is that's because the binary option is handled with the same function instead of restarting the reader with the "r" option.  There's probably another way to do it too.

I am getting a ReadError with examples_windows.txt, on Ubuntu 20.04.1 LTS, like yours, but it's not the same as the ReadError in #929.

can't find the $Element section

It does actually correctly return from
https://github.com/nschloe/meshio/blob/b6cb61805bb9cf4b51d9514dbefbf69bb5b0c108/meshio/gmsh/_gmsh41.py#L69-L71
The problem is that after that, back at
https://github.com/nschloe/meshio/blob/b6cb61805bb9cf4b51d9514dbefbf69bb5b0c108/meshio/gmsh/_gmsh41.py#L55
line is "\r" and so not line is False.
Maybe the logic of
https://github.com/nschloe/meshio/blob/b6cb61805bb9cf4b51d9514dbefbf69bb5b0c108/meshio/gmsh/_gmsh41.py#L53-L59
needs rethinking.

I'm wondering whether rather there's something wrong with your example_windows.txt.  Do you know how it was generated?  Was it generated by Gmsh?  When I generate a MSH 4.1 file with Gmsh 4.6.0 under MS-Windows 10, it ends like (running it through tail -2 | od -c back on Linux):
0000000   3   3       3   1       3      \r  \n   $   E   n   d   E   l
0000020   e   m   e   n   t   s  \r  \n
0000030

but tail -2 example_windows.msh | od -c gives
0000000   $   E   n   d   E   l   e   m   e   n   t   s  \r  \n  \r
0000017

If the trailing "\r" is removed from your file, meshio.read is successful.

So after I found the #929, I updated the version of meshio to 4.2.2.  Unfortunately, I'm not sure which version of meshio I had previously.
It was generated from this (rename to example.geo).  It's a stock example.
example.geo.txt
using:
gmsh example.geo -3
My version of gmsh is 4.6.0 (at least in the gui).

To be clear, I'm getting the same empty line error that you are.  I had looked at the code and hadn't seen:
 if line[0] != "$":
     raise ReadError()

in the previous version.

The issue appears to me to be why example_windows.txt ends with a line containing nothing but \r.  When I run gmsh example.geo -3 on my MS-Windows 10 machine with Gmsh, the resulting examples.msh doesn't have that.  I've compared the resulting example.msh with examples_windows.txt in VS Code and they're identical up to line 25061 $EndElements but then examples_windows.txt has that spurious extra \r line.
The Gmsh here is 4.7.0-git-3346eafac (obtained with pip install gmsh-dev — I'm only using such a fresh one because of gmsh#1007).

I can also reproduce the error. It doesn't matter much how the file was created as long as it's legal (aka gmsh itself can read it) -- and that seems to be the case. I've never seen files ending in carriage returns only, but I'll play around a bit.

Iterating over the file like
with open("example_windows.msh") as f:
    while True:
        line = f.readline()
        print(repr(line))
        if not line:
            break

works as expected.
[...]
'$EndElements\n'
'\n'
''

Iterating in binary mode also works:
with open("example_windows.msh", "rb") as f:
    while True:
        line = f.readline().decode("utf-8")
        print(repr(line))
        if not line:
            break

[...]
'$EndElements\r\n'
'\r'
''

Thank you!


Enabled members by default

no-issue
This removes the need for enableDeveloperExperiments flag for members

Closed in favor of https://github.com/TryGhost/Ghost-Admin/pull/1360/files


fix : restricted node version to version mentioned in package.json #169

What type of PR is this? (check all applicable)

[ ] 💡 Feature
[ ] 🐛 Bug Fix
[ ] 📝 Documentation Update
[ ] 🎨 Style
[ ] 🧑💻 Code Refactor
[x] 🔥 Performance Improvements
[ ] ✅ Test

Description
This PR restrict the node version to the version specified in the package.json . user is force to have that version installed for build to happen
Fixes issue :  #169

Screenshots (if appropriate)

Added tests?

[ ] 👍 yes
[x] 🙅 no, because they aren't needed
[ ] 🙋 no, because I need help

Added to documentation?

[ ] 📜 README.md
[x] 🙅 no documentation needed

@sanyamgandhak please add a description and link the issue number

@sanyamgandhak please add a description and link the issue number (example: Fixes #123534) in the Fixes Issue section ⬆

Done !!

Please remove package-lock.json from the PR.
Good to see that the addition of the strict-engine file is having the desired effect though! 👍👍

Do I need to make same changes as in package.lock.json and then push the repo ?


advance compat requirement to 0.18

yeah, this should be part of 0.7.2

I will remove and retag v0.7.2 after this PR -- thanks.

Codecov Report

Merging #245 into master will increase coverage by 0.16%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #245      +/-   ##
==========================================
+ Coverage   84.14%   84.31%   +0.16%
==========================================
  Files          24       24
  Lines        1470     1466       -4
==========================================
- Hits         1237     1236       -1
+ Misses        233      230       -3

Impacted Files
Coverage Δ

src/dijkstra_spath.jl
93.39% <0%> (-0.07%)
:arrow_down:

src/show.jl
0% <0%> (ø)
:arrow_up:

src/generators.jl
100% <0%> (+1.47%)
:arrow_up:

src/graph_visit.jl
54.54% <0%> (+2.37%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 385b271...a0b4d1d. Read the comment docs.


CNN video pages not working

when you try to go to the page on the website for the cnn videos it throws a 404

can you be more specific, where is the broken link? They are working from this page for me:
https://thecodingtrain.com/learning/ml5/

The link in the description of the youtube videos

https://thecodingtrain.com/Courses/ml5-beginners-guide/8.2-cnn-2.html

it seems like the website is working fine, just the link in the video descriptions are wrong

Fixed!


Add lottie executor to avoid issues with Lottie flakes

#287  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @rbro112 and the rest of your teammates on  Graphite


Fix ios13 issues on number format use

Polyfills required to support NumberFormat in ios v13

@neokore This is not tested yet on ios13 emulator


chore: Update allowed HTML elements

li and ul are sometimes needed in Markdown tables

Let's wait a bit on this, while I check if HTML lists within MD tables is considered acceptable for docs.

It's the only way btw ... tried MD first and it ended in :cry: tears. This was asked-and-answered earlier: HTML is dissuaded but not outlawed. In those cases where I used lists, they worked out well ... look good ... organized that content well.

Turns out we have a lot longer list of whitelisted HTML tags, and we should make MarkdownLint match it:
The following HTML elements, organized by category, are whitelisted:

Type
Elements

Headings
h1, h2, h3, h4, h5, h6

Prose
p, div, blockquote

Formatted
pre

Inline
b, i, strong, em, tt, code, ins, del, sup, sub, kbd, samp, q, var

Lists
ol, ul, li, dl, dt, dd

Tables
table, thead, tbody, tfoot, tr, td, th

Breaks
br, hr

Sweet! ... only when needed, of course. MD is nice but a bit too constraining sometimes imo.

The alternate would be to turn on the rule and use <!-- markdownlint-disable MD033 --> in the areas/files that it's required

I would vote for either disabling the rule entirely or adding the whitelisted elements.

I vote for adding the whitelisted elements.

I would vote for either disabling the rule entirely or adding the whitelisted elements.

This is one of the rules were it's not a good idea to disable it. EX:
List<T> renders to  "List" and swallows the <T> without escaping

I used the other PR only for disabling selected rules, so I"ll add a commit to this PR for the rest of the allowed HTML elements.

@nschonni Thanks for getting the work on this rule started and for all your contributions to making our Markdown more consistent!


KubeVirt Certificates Expired

Describe the bug
Cannot create, update or change VM's or images.
To Reproduce
Steps to reproduce the behavior:

Run a harvester cluster on 1.1.2 for more then a year.
Create a new VM or try to configure a new image.

Expected behavior
The new VM is created successfully and are able to boot the VM.
The qcow image is downloaded and ready for use.
Support bundle
Will be provided upon request.

Join our Slack community (https://rancher-users.slack.com/archives/C01GKHKAG0K) to provide the bundle.
Send the bundle to<EMAIL_ADDRESS>with the correct issue ID.  -->

Environment

Harvester ISO version:  1.1.2
Underlying Infrastructure Baremetal supermicro 7 node cluster. 3 controller nodes and 4 worker nodes:

Additional context
When adding a new VM I noticed that the VM was not being create. I decided to try and delete and then download the backing image again. I had previously downloaded the image a few weeks ago. After deleting and trying to add the image back it also got stuck trying to download.
Troubleshooting brought me to look into the secrets. I have found that all of the KubeVirt certificates had expired and did not automatically reprovision. The KubeVirt-CA is also expired which could cause the other cert not to roll.
Attached it a screen shot of Rancher showing all the certs expired for KubeVirt.

Please advise on how to roll the KibeVirt-CA and sub certs.
Thank You,
Rich

Wow - same issue actually - checking for a solution, but hopefully somebody can come up with the solution quickly...

Well, I am sure there will be more as lots of people started installing 1.1.2 right around this time last year.

I'm on 1.2.1 - and same issue - so I gues upgrading harvester doesn't fix this either - so I would expect a few people being affected.  In theory, deleting the secrets and deleting/restarting the virt-operator pod should recreate the certificates (at least from my understanding of a typical kube-virt installation) - but I'll wait from someone from harvester to confirm...

Thanks @richevanscybermyte bring this up.

In theory, deleting the secrets and deleting/restarting the virt-operator pod should recreate the certificates (at least from my understanding of a typical kube-virt installation) - but I'll wait from someone from harvester to confirm...

Thanks for the comments @RegisHubelia 😃
We have two options to solve the expired certs.

Run kubectl delete secrets -n harvester-system -l app.kubernetes.io/component=kubevirt. The KubeVirt secrets will be automatically recreated within several seconds.
Alternatively, you can run kubectl edit kubevirt -n harvester-system and modify the .spec.certificateRotateStrategy to enable automatic certificate rotation.

spec:
  certificateRotateStrategy:
    selfSigned:
      ca:
        duration: 336h
        renewBefore: 24h
      server:
        duration: 168h
        renewBefore: 12h

duration: The requested 'duration' (i.e. lifetime) of the Certificate.
renewBefore: The amount of time before the currently issued certificate's "notAfter" time that we will begin to attempt to renew the certificate.

Hi @brandboat,
Thank you very much for your reply.
Just to be clear - Based on your update section above, we shouldn't have this issue to begin with as there is already a default value?  I've check my current config and currently there is no values, and I'm 100% positive nobody played around with this...

I went with option 2 first - just for the sake of testing it - and Certificates were actually renewed within 2 minutes, which I deemed to be a cleaner solution IMO.  So it does seem to fix the immediate "issue", tough if there is already a default value and it wasn't working - there might be something up at the time of renewing/rotating certs.  So I left it as per your values, so the CA will expire on the 28th of may and the server certs on the 21st.  I will monitor this and see if it gets renewed automatically or if a manual intervention is needed and revert back.
With all that said, looking at @richevanscybermyte screenshot and my own certs - non of the certificates are actually expired (I think?) - it basically says it will expire @ 4:26pm today for the server certs - and the CA cert on the 18th of May - Quite the coincidence we literally had the exact same values to the seconds for all our certs (server and ca).  But based on what you are saying @brandboat, it should of been renewed 32.4h before expiry  (168 hr * 0.2) - and this did not happen as they were still showing today @ 4:26:43 this morning at 7:30am.  Maybe it would of renew at some point... - this is why I will monitor with the current values and revert back when we get there, as if it is indeed an issue, it could cause quite a bit of problems in scenarios where, as an example, we upgrade harvester (I would think).
@richevanscybermyte - was your localtime > 4:26pm ?  Just asking as my renewed certs still shows red even tough they aren't expiring for the next 7 days - which could indeed cause confusion (I fell for it, should be in yellow as a warning when not expired and red for expired certs, IMO).

Kind Regards

@RegisHubelia , You are correct my certs are showing red even though they have not expired. It is interesting though, because the certs are still set to expire this afternoon and we are within the 12h default window for experation.
So if not certs, then there is another issue on why I am getting the following error when trying to create new objects in the harvester cluster.
(combined from similar events): Failed to create pod sandbox: rpc error: code = Unknown desc = failed to setup network for sandbox "5b9e5f0dc859155fff7714134718c932a91a0c1141876f4f6ef516c13ee8b2be": plugin type="multus" name="multus-cni-network" failed (add): Multus: [cattle-logging-system/rancher-logging-root-fluentd-0/9b43803c-a97d-4da8-b992-9427b42a5988]: error getting pod: Unauthorized
and another:
(combined from similar events): Failed to create pod sandbox: rpc error: code = Unknown desc = failed to setup network for sandbox "1f24e84341abf445c83f7ad80e426df1b25cdadc82a0c09f9e57ff00b3a62820": plugin type="multus" name="multus-cni-network" failed (add): Multus: [longhorn-system/backing-image-manager-d7ad-cde2/78c7e7c0-9453-4abd-ad6f-c0e3f60f3cf0]: error getting pod: Unauthorized
I found another article that talked about a Token for canal expiring. I followed the steps that deleted the pods so they would be recreated kubectl delete pod -l k8s-app=canal. That did not fix my issue. The unauth I am getting makes me think the Token issue is a thing but I don't know which token is expired how to roll it.
So now I might have 2 issues:

I am within my 12 hour windows and my kubevirt certs are not rolling (I will use the suggestions above to roll the certs)
I have an expired token somewhere that isn't being rolled automagically.

I could do a redeploy of the Multus/Canal pods and see what that gets me.
My biggest issue is I do not want to cause downtime. So I am checking here to make sure I am on the correct path.

Thank you for the help!
Rich

Hi @richevanscybermyte ,
To be fair - I had an issue on my side where some VMs were having issues when creating backups - and after I rotated the certificate - it seems like now the backups are working again - but not sure it is related.  So I'd suggest you go ahead and use option 2 to renew your certificates and see if it actually changes anything...  It might be that time isn't right somewhere and the certs might be expired if time is not synched correctly..?
The other thing you could check is the logs in the pods rke2-multus-XXXXX and rke2-canal-XXXX and see if there are any pointers or errors on those pods - this might point out to the right path...  Also check the virt-handler and virt-contoller pods for logs/errors.

@RegisHubelia To late, already done. I rolled out multus and it resolved the Unauthorized issue but now the error I get back is:
FailedCreatePodSandBox	Pod backing-image-ds-tenant-cui-image-d7wz9	Failed to create pod sandbox: rpc error: code = DeadlineExceeded desc = context deadline exceeded`
This is even less to go on for an error message. Looks like longhorn now but unsure. I will take a look at logs from Longhorn and update the thread.

Can you check if you have a pod named " backing-image-ds-image-d7wz9"
kubectl get pods -n longhorn-system | grep backing-image-ds-image-d7wz9

I deleted the image because it wasn't downloading. I will recreate another so I can get the error messages again.

IT does it when I create VM's too:
FailedAttachVolume	Pod virt-launcher-ham-sandwich-sr8qh	AttachVolume.Attach failed for volume "pvc-d602c005-9b3b-4d19-9b05-1b23bef17ad1" : rpc error: code = DeadlineExceeded desc = volume pvc-d602c005-9b3b-4d19-9b05-1b23bef17ad1 failed to attach to node virtwrkr03	virt-launcher-ham-sandwich-sr8qh.17cf905e331099fd

I am not sure what is happening. When I log into Longhorn everything is green but what it looks like is that Harvester cannot talk to storage. But current VM's (I have about 50) are not affected. They power up and can talk to storage. It is only New VM's or New images.
This is a problem because I need to make new VM's and Spinn out new RKE2 (From Rancher) clusters.
Like I said, I thought this was a Certificate issue but it is not.

Do you see the newly created volume in longhorn?  Are all the nodes in the longhorn schedulable?

Everything in longhorn looks good. No errors or any other issues.

And do you see the new volume in the volume tab?  Can you also screenshot the Node tab?

Yes, the pvc shows up in the volumes tab. Attached is a screen shot of the Nodes tab.

Can you show me the current status of the volume - in the volume tab - click the volume?  Is it currently attached?  If not, if you try to manually attach it does it work?

So, I figured it out but now I have to fix some old Storage Classes.
The StorageClass class that I was using, lets call it "worker-nvme" was the default storage class. It has worked for over the last year. I had to replace a node recently and I gave the rebuilt node the same labels for host and drives under storage. For some reason that is no longer working. I would just delete the SC and rebuild it but there are a ton of other machines using that SC. Any suggestions? I am going to dig in the CRD's and see if there is any yaml I can check out that could have the wrong node UUID's or something.
@RegisHubelia thank you for sticking around for me. I will follow up here when I figure out how to adjust the SC so it works again.
-Rich

Hum...  I remember having issues when changing the default storage class in the past and reverted to the harvester default.  So I kept the default, and I manually specify the storage class I want to use when creating guest clusters or other VMs.  I'd suggest you do the same.
As for your issue, can you show the storage class configuration (of course remove sensitive information)?  Is there specific node/disks selectors on your SC?

There are selectors in the storageClasses. Here are the two:
Old - No longer works

And the New SC that does work:

They literally have the exact same parameters. I can give the old (worker-node-nvme) a go and see if something just shook loose. Never know.

Can you provide the yaml?  this would show everything - there might be something different not in the screenshot.

I have solved my issue. I deleted the original StorageClass and recreated it with the same name and same values as I had before. The machines that we not coming online because of migration or being create; I restarted these machines and now they are up.
Deleted worker-node-nvme storageClass. Immediately recreated it exactly as the original.

TLDR; Some how the storageClass was not selecting any storage. I deleted and then recreated the storageClass exactly like the original and everything came up.

Glad you found a workaround and that I could somehow help.  Still seems a bit strange that it stopped working all of a sudden...

Maybe too late to ask, but I was wondering is it possible to upload the support bundles from your cluster ? @RegisHubelia  @richevanscybermyte ? It might be helpful to understand the root cause of the errors you mentioned in this issue. Many thanks 😃

Happy to provide it - I created it.  How can I get it to you securely?  I can upload it on an encrypted disk and provide the link - but I'd rather not do that publicly..

@brandboat - the certificates renewed on time this time around.  Honnestly not sure it it is an issue or not - tough I would expect if the default is 12h, for the certs to be renewed before 4h of expiry.  Setting the values tough - and the certs were indeed renewed on time.
Thanks!

I suggest we put this info as a KB page to explain the mechanism to admins: https://harvesterhci.io/kb/
The VM page in the doc is for the end-users to troubleshoot VM failure

I agree on the write up. The certs expiration ended up being a red haring, for me at least. I saw RED on the screen and assumed this was the issue. Not sure how many views this gets but if there was an article on this topic in the documentation I would have spent far less time on troubleshooting certs.
Thank you to everyone that pitched in and helped!


change selectedState of FumeAnimation

if you set the FumeAnimation as the first selected tabbarItem, you will
see the item is too high. So I change 8.0 to 12.0. My English is poor,
I hope you can understand my meaning.

thanks


Create Footer component

💡 Description
The footer module needs to be created for use across the site. See Figma MVP designs for reference.
⚔ Parent Epic / Related Tickets
No response

Demo'd today! 2024-09-19


Holocene Contract Deployments

To support the Holocene Network Upgrade, we need to deploy the latest version of the following contracts:

FaultDisputeGame
PermissionedDisputeGame

Wrote separate scripts for deploying each individual contract (due to compiler errors from an imported struct being used by both deployments) as well as a third script for running both deployments in one command.

🟡 Heimdall Review Status

Requirement
Status
More Info

Reviews

🟡
0/1

Denominator calculation

Show calculation

1 if user is bot
0

1 if user is external
0

From .codeflow.yml

1

Additional review requirements

Show calculation

Max
0

0

From CODEOWNERS

0

Global minimum
0

Max

1

1

1 if commit is unverified
0

Sum
1


Fixed appnp to stop excess dropout propagation and added change to pp…

This fixes the issue in the APPNP class that causes appnp to propagate excessive dropout layers.  This also adds a fix into the demo so that the softmax layer is no longer propagated. The demo scaleable and regular appnp structures should now be the same.

@youph

I combined all layers into self._layers
great idea, I think there's a fairly easy way to refactor this but it'll involve an API change. Is this still suitable for a hotfix? It might be better suited for the next release
I think you're right that the dropout after each propagation step is unnecessary (I only had them because the paper did). I removed these

I reverted to thinking that dropout layers between the propagation layers should be there, for the following reasons:

having them removes the gap between train and validation loss for PPNP and APPNP models, i.e., prevents overfitting, albeit without improving the final validation loss (i.e., without affecting model generalisation). However, it is possible that in some cases preventing overfitting will actually be beneficial for generalisation.
the paper applies dropout: they use dropout with dropout rate d = 0.5 on both layers and the adjacency matrix

Adding the propagation dropout parameter changes the API, and is not suitable for the hotfix. But this is a good idea nevertheless, so let's create a new issue and add it in a separate PR into develop.


Brooswit/update clientside env var

This PR makes 3 changes:
Renames the environmental variable LAUNCHDARKLY_ENV_ID to LAUNCHDARKLY_CLIENTSIDE_ID, to match V2 patterns.
Rewrites the readme to be a bit clearer.
Adds missing dependencies to the project.

Hey @apucacao, I added you as a reviewer for this.


Use onBeforeUnmount to destroy the Interval

Describe the feature
I'm referring to these lines:
https://github.com/sidestream-tech/sidebase/blob/8afc4885ffba1f1c0718da4067b49f8b2fcf51ef/app/pages/index.vue#L13-L17
I think that using the onBeforeUnmount hook should preferred because you want to always have access to the reference to refreshDataInterval during the current lifecycle of the component.
The current implementation uses onBeforeMount to attempt to clear an interval from a reference of a previous lifecycle. This cannot be guaranteed to work.
Additional information
No response

Thanks for the request!
You're very right, I think this is likely a bug / oversight (: We will fix this!

@ndianabasi we fixed it, let me know if something arises again and thank you so much for using sidebase + reporting this (:


Draft: add pg_vector supporting

Description

Related Issues
Add pg_vector support Ecosystem support (see  #1525)
Checklist

[ ] Is this code covered by new or existing unit tests or integration tests?
[ ] Did you run make test successfully?
[ ] Do new classes, functions, methods and parameters all have docstrings?
[ ] Were existing docstrings updated, if necessary?
[ ] Was external documentation updated, if necessary?

Additional Notes or Comments

Hi @Yaro1 this is great! Do you see the way that the MongoDB Atlas Vector Search works? The point is that if the main database is PostgreSQL, then we don't need this copying of the data across -- it's already there.

Hi! @blythed I already made a PR. But I'm trying to create tests for that. I guess it should be integration tests but we can discuss it in PR

oh, sorry, I just understand what did you mean. Sorry

@blythed  Okay, got it. I will take a look

Thank you!

@Yaro1 we created a simpler developer contract to integrating new vector-search. Can you copy the model we used for MongoAtlasVectorSearcher?

@Yaro1 please make a standard PR to main if you would like to continue work on this.


Updates liquid long client library to be able to close positions.

This change required some contract changes, and I figured I would take the opportunity to make a couple quility of life contract changes while I was at it, since we need to re-deploy the contracts anyway.

Changed CDP ID input/output parameter to a number instead of bytes32.  Normally I would argue that the fact that it is a number is an implementation detail we should not rely on, unfortunately, we iterate it like a number, so we are tightly coupled with the implementation detail that is the ID selection algorithm.
Added an event for when CDPs are closed by the system.
Made closeCdp early return with result 0 when someone tries to close an empty CDP.  This is added mainly because the UI will sometimes do an off-chain closure attempt for an already closed CDP and having it not throw is a quality of life improvement.
Added the owner to the returned datastructure.  This is necessary so we know the address we need to use when doing the delegated closure call.

In the client library, the main change is the addition of closePosition and a minor bugfix when processing the newCupEvent.  There is some funky stuff with the nesting of the implementation.  This is so we can utilize the generated encoder/decoder to generate the delegated call and then forward the result.

All looks great. Maybe a comment around the stashing thing because it's a little weird (dealing with the two calls of a DSproxy).


Fix NavigationObstacle elevation

Fixes NavigationObstacle elevation.
Fixes https://github.com/godotengine/godot/issues/84817.

Thanks!

Cherry-picked for 4.1.4.


Validation: Hide error message when the content is corrected by user

Description
As a user I want the error message to disappear immediately when I correct the content, so that I know its correct without having to leave the field to check.
Design
https://www.figma.com/file/Pvti3aRcOwH0k5Z7DrLznk/Arbeidsområde%3A-Altinn-Studio-APPS?node-id=2545%3A50628
https://user-images.githubusercontent.com/1464915/158812922-98a7ccda-17b9-4a08-abf2-088d953cc5d3.mov
Development tasks

[ ] Check if this is possible to combine with onBlur
[ ] Both the messages connected to the field and the messages in the summarybox should dissapear when fixed.
[ ] When the summary-box has no error left it should turn green.

Test

Definition of done

[ ] Documentation (docs.altinn.studio) is updated (if relevant)

[ ] Technical documentation
[ ] User documentation

[ ] QA
[ ] Manual test is complete (if relevant)
[ ] Automated test is implemented (if relevant)
[ ] All tasks in this userstory are closed (i.e. remaining tasks are moved to other user stories or marked obsolete)

I made a quick prototype of this, as I've noticed the same thing. My annoyances have also included:

That I have to go to the next input field in a form before I'm reminded I did something wrong (at that point my attention has moved on to the next field, as I believed my input was correct)
Data is only saved in the instance when I blur the field. This means that if I spend the day writing my novella in a TextArea, all may be lost if I never tabbed out of the field at some point.

With the changes in the feature/98-save-on-change branch, data on Input components will be saved 500 milliseconds after you last typed something. Meaning we won't save the data or run validations per-character, but we'll run validations and save the data whenever you stop typing for a short while.
I believe this is a better solution, at least parts of it, but it leads to new issues:

If I typed something, changed my mind and deleted it, I'm now reminded (quite harshly) that the field is required - even though I'm still thinking of what I'm supposed to write. Maybe we should delay that specific validation until you tab out of the field.
It still does not feel 'immediate', but that might just be something we'll need to balance. We could also check more quickly if there are validation errors and you started typing something else.

If possible, please take a look at the proposed solution, and we'll iterate until perfect!


CASE expressions aren't being parsed/read

Queries using conditional expressions like NULLIF and COALESCE generate proper Go code. Meanwhile, the CASE conditional expression does not. The generated go code doesn't generate an additional field in the result struct, making the Scan fail each time is called. I will try to investigate this issue later on the week and try to provide a fix. The following query can be used to reproduce the observed behavior:
SELECT
  id,
  CASE
    WHEN id = $1 THEN true
    ELSE false
  END is_one
FROM
  author;

Actually, NULLIF also smells bad. When using it in a query, the Go struct is generated with a field with the bool type, instead of a Null* type. The following query:
SELECT
  NULLIF(id, $1) restricted_id
FROM
  author

Will generate the following strange code:
type FuncResult struct {
  RestrictedID bool `json:"restricted_id"`
}

When correct type would be sql.NullInt64.

Yeah, these are indeed two problems. I hope to get a chance to look at them this weekend


Remove Temporal

It might be better to change the status to killed rather than delete the entire history.

Although a 'killed' status is generally preferred, if the chain hasn't made any significant impact, never had ibc transfers, and never made it past testnet, it might be OK to allow it to be completely removed.


Always execute maven plugin to calculate rootdir

Type of change

Bugfix

Description
Always execute maven plugin to calculate rootdir
Additional Context
When running mvn clean verify -Dquick the rootdir resolver plugin was excluded due to the quick property but the formatter plugin config depends on rootdir being made available.
This prevented performance tests running as it uses mvn -B clean verify -Pdist -Dquick to build.

/perf


MagicError: name use count (30) exceeded

Found some APks where some jpeg files produce errors when getting the mime type:
magic.MagicException: b'JPEG image data, Exif standard: [TIFF image data, little-endian, direntries=17, height=4032, bps=218, compression=none, PhotometricIntepretation=RGB, manufacturer=NIKON CORPORATION, model=NIKON D3X, orientation=upper-left, width=6048] name use count (30) exceeded

see:
14:06:09 E:     for f, mime, crc in a.get_files_information():
14:06:09 E:   File "/usr/lib/python3/dist-packages/androguard/core/bytecodes/apk.py", line 486, in get_files_information
14:06:09 E:     yield k, self.get_files_types()[k], self.get_files_crc32()[k]
14:06:09 E:   File "/usr/lib/python3/dist-packages/androguard/core/bytecodes/apk.py", line 452, in get_files_types
14:06:09 E:     self._files[i] = self._get_file_magic_name(buffer)
14:06:09 E:   File "/usr/lib/python3/dist-packages/androguard/core/bytecodes/apk.py", line 423, in _get_file_magic_name
14:06:09 E:     ftype = m.from_buffer(buffer)
14:06:09 E:   File "/usr/lib/python3/dist-packages/magic/__init__.py", line 85, in from_buffer
14:06:09 E:     return self._handle509Bug(e)
14:06:09 E:   File "/usr/lib/python3/dist-packages/magic/__init__.py", line 112, in _handle509Bug
14:06:09 E:     raise e
14:06:09 E:   File "/usr/lib/python3/dist-packages/magic/__init__.py", line 83, in from_buffer
14:06:09 E:     return maybe_decode(magic_buffer(self.cookie, buf))
14:06:09 E:   File "/usr/lib/python3/dist-packages/magic/__init__.py", line 266, in magic_buffer
14:06:09 E:     return _magic_buffer(cookie, buf, len(buf))
14:06:09 E:   File "/usr/lib/python3/dist-packages/magic/__init__.py", line 199, in errorcheck_null
14:06:09 E:     raise MagicException(err)

some bug reports are already in other repos ... seems to be an upstream problem

btw happening with
python3-magic                                         2:0.4.15-1

I ran into this one myself.  So far, it looks like a reasonable workaround is to uninstall python3-magic, and install filemagic instead.  On Ubuntu, it was as simple as "pip3 install filemagic".  On Windows, I had to do that and also get magic.dll in the system path, and also magic.mgc in a path that Python was looking in (in my case, C:\Python36\share\misc).  I got these files from https://github.com/pidydx/libmagicwin64
It may also be possible to extract the windows magic files from https://pypi.org/project/python-magic-bin/0.4.14/, but I haven't tested this.
So yeah, the Windows side was a few more steps than I had hoped, but if python3-magic is broken, using filemagic instead might be a good idea.


Fix envsubst for credentials.xml in Jenkins

@bparees merge pls, I forgot to add this commit to the s2i branch...


docs: fix deploys

Summary
Fix docs deploys

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.4 out of 5 committers have signed the CLA.:white_check_mark: adamdehaven:white_check_mark: portikM:white_check_mark: mihai-peteu:white_check_mark: johncowen:x: team-eng-enablementYou have signed the CLA already but the status is still pending? Let us recheck it.


[HOLD for payment 2024-03-07] [$500] Chat - The selected 2nd contact is shown in first line

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.44
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4346886
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:

Launch app
Tap on a report
Enter @
Select here from user suggestions
Tap enter key and go to next line
Enter @ and select any contact from user suggestion
Note, the selected 2nd contact is shown in first line
Send the message
Note here message is not highlighted

Expected Result:
Selecting user suggestions here and then another contact, must show 2nd contact at second line in compose box and after sending message, here must be highlighted
Actual Result:
Selecting user suggestions here and then another contact, showing 2nd contact at first in compose box and after sending message, here is not highlighted
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/2be6c3cf-b27d-4f6a-a670-cfb20ec1dbd7
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0104f679d006807363
Upwork Job ID:<PHONE_NUMBER>508782080
Last Price Increase: 2024-02-27

We think that this bug might be related to #vip-vsp
CC @quinthar

Looks like this is caused by https://github.com/Expensify/App/pull/36792

@abdulrahuman5196 @dukenv0307 can you guys take a look please?

Do ping me if we have a solution.

@abdulrahuman5196 I tried this proposal's alternative and didn't get the regression as above. What do you think about this solution?

@dukenv0307 Did we find the root cause of this issue? What is causing this?

@abdulrahuman5196 I tried this proposal's alternative and didn't get the regression as above. What do you think about this solution?

@dukenv0307  If we need to implement the alternate solution, it would be better to do a straight revert of the offending PR to unblock staging and to avoid any new regressions from the alternate solution implementation. Since the alternate solution is a different implementation and would need to discuss on that.
@youssef-lr what do you think?

leading to wrong leftString and atSignIndex.

@abdulrahuman5196 On second thought, I saw that atSignIndex is wrong because the left string is cut off from the last break line index meanwhile atSignIndex is the index based on the full string so with my main solution we need to update atSignIndex correctly by adding it with newLineIndex + 1. What do you think about this?

@dukenv0307
Got it. Seems to be good. Can we raise a quick PR on the same?
And do check if any other properties need to be updated?

No payment required here since it was a regression fix. @youssef-lr We can close this issue.

No payment required here since it was a regression fix. youssef-lr We can close this issue.

cc: @trjExpensify


Track processed classes. Fixes #122

Second round of compilation results in visiting the same class again. This prevents that.

@dstepanov not sure if this is the correct fix and it will probably need to be applied to the SuperBuilderVisitor. Currently the same record is visited again in the second round of compilation.

I think this might be a Core problem

Agreed, we probably need a fix for existing versions of Micronaut though


"FarmId" is missing from the "device" specification

.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6782764c-ebd5-bb0b-718c-aac606afbf46
Version Independent ID: 4cf2b68c-528b-b57c-eeee-4d1aae286e71
Content: Ingest historical telemetry data - Azure for Industry: Agriculture
Content Source: articles/industry/agriculture/ingest-historical-telemetry-data-in-azure-farmbeats.md
Service: azure-industry
Sub-service: agriculture
GitHub Login: @uhabiba04
Microsoft Alias: v-umha

We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


DevOps, CI/CD, Rollback Automations

Hi All,
I just wanted to let you know that this project can count on me to create the CI/CD and Rollback workflows using GitHub Actions or other tootling.
If the project has any other requirements inside SRE and DevOps scope, I would be glad to help.
I know that could sound like an exaggeration at this moment, but since the project is also an education project, students may find it interesting to have a bit of DevOps.
Best regards to the Vim community!

Hi rossijonas,
DevOps will certainly be an important topic in this project. So thank you for your offer. Once the development starts, we will get back to you.
Sincerely Vim Website Team

Hi @rossijonas, thanks for your interested in helping out.
A simple deployment workflow to a VM has been implemented in https://github.com/vim/website_next_generation/pull/31
Please feel free to offer some feedback here.
Is there any specific workflow you would see useful and would like to contribute?