Integration test improvements

It would be nice to have end-to-end tests which were slightly less deterministic, to make it easier to have many streams and large bidirectional data flows going independently of each other.    This results in less deterministic tests but allows fuzzing corner cases for things like watermark limits and unexpected disconnects and resets.
Possibly a separate issue but likely predicated on this, it'd be nice to be able to do simpler things with less boilerplate - set a default backend response and client->sendSynchronousRequest, then inspect response headers or upstream headers after the fact.
Finally, while I'm thinking about it, perhaps make an easy config for which test should apply to which languages so one doesn't have to edit multiple integration tests every time you want something tested for http/h2/h2-upstream.
... and as long as I'm dreaming, I'd like a pony.

Related: #186.

@alyssawilk are we still tracking stuff with this? Or should we call it done for now?

Yeah, I have one last fix I'd like to get in.  There's still one race I was debugging but I'll ship it out for early inspection / critiques while I track that down


feature: Integrated Dynamics menril trees please

Hello,  Can you please add the ability to grow the Menril trees from Integrated Dynamics?  Thanks!!

Will be in the next release.


Add npm documentation to README

@dvlden Since I do not really know how the NPM system works, would you mind fleshing out the development documentation page? Over in the gitter room we seem to have some confusion on how to compile after completing work in sass.

The contributors most likely able to help are:
@cpdevelops
@dvlden

Sure, will do it.


Basic Load Balancer Functionality

Why are these changes needed?
Now we support client connect to multiple server ip address and a basic round-robin load balancer that distribute the request accordingly.
Changes

Load balancer engine, which stores the connection info and rewrite the conn_id accordingly
Mrpclb module, which is mrpc module with load balancer engine
An example called load_balancer, you need to start two server first and then start client. Client will send request to each server.

Todos

Reuse code of mrpc module in mrpclb module
Error info
Refactor connection structure

Checks

[x] I've run scripts/clippy.sh to lint the changes in this PR.
[ ] I've included any doc changes.
Testing Strategy

[ ] Release tests
[x] This PR is not tested :(

cc @crazyboycjr

Can you merge this first? I feel like the refactor and message bus requires a lot of code change, and perhaps we should separate it from load balancer.


User can delete their Tweet

API URL:
DELETE /users/:userId/tweets/:tweetId
Success:
204 No Content
Error:
401 Unauthorized
404 Not Found

[ ] use curl -X DELETE  "http://localhost:3000/users/1/tweets/1" to test API

closed by 8526f63


Add support for .fbp files

Since flowbased/fbp is a thing (and thus, the parsing is a done deal),it would be nice if JSFBP supported
.fbp files.

In order to do this we'll need:

[ ] Support for loading components by name
[ ] FBP parser (as a dependency)
[ ] API for creating a network from an FBP definition
[ ] Relevant documentation


Add unit tests of feature computation

List of features that need tests:

[x] hog
[x] lacunarity
[x] ndxi
[x] pantex
[ ] rid (do we believe this feature is worth the effort?)
[x] sift
[x] texton

The minimum test that should be available is a regression test. More is better, but maybe not feasible in the limited amount of time we have.
We may also consider comparing with the features as computed by spfeas.

Regression tests have been implemented in #35


How would I go about using the track tag to have multiple files?

I'm trying to set up a Webamp player for my site to handle playback of my two Icecast streams, but I can't figure out how to properly use the "track" tag. I'd also want to use it for multiple streams. Here's my current setup:

When I have an initialTrack in the const webamp = new Webamp(); line, it loads the initialTrack but not any of the other tracks.

Joined the Discord server and sorted this out with the dev, I wound up doing this:

Doesn't seem to support Icecast metadata but it works.


Reinstalling apps and drivers fails unpredictably

After some investigation, it looks like sometimes apps are started before the arbiter permissions are configured. In container-manager.js#L208 createService is called before addPermissionsFromSla so if the app starts quickly (the image has already been downloaded) then the app starts before its permissions are granted. This causes errors after an app/driver is reinstalled.

just also adding Yousef in case he can check too to make sure

Its an easy fix, I'm happy to do it once I've finished debugging some other issues

fixed in https://github.com/me-box/core-container-manager/pull/27


Remove spaces from container

You can see in the image
that I attached some spaces around the container.
In your demo files there is not any spaces like these. So how can I remove them?

This doesn't look right, there shouldn't be spaces. The label text in your example also looks smaller than it should be, and the icon isn't centered.
Could you please provide your react-native version and all Code-Snippets for your example which are related to the Bottom Navigation?

@timomeh sure.
RN version: 0.42.0
react-navigation version: 1.0.0-beta.6
Here is my code:
const MyApp = TabNavigator({
  Home: { screen: HomeScreen },
  Category: { screen: CategoryScreen },
  Calendar: { screen: CalendarScreen },
  Profile: { screen: ProfileScreen },
  Book: { screen: BookScreen },
}, {
  tabBarComponent: NavigationComponent,
  tabBarPosition: 'bottom',
  swipeEnabled: false,
  animationEnabled: false,
  tabBarOptions: {
    bottomNavigationOptions: {
      labelColor: '#CCC',
      rippleColor: '#801e5c',
      style: {
        borderTopWidth: 0.5,
        borderColor: '#CCC'
      },
      tabs: {
        Home: {
          barBackgroundColor: '#FFF',
          activeLabelColor: '#801e5c',
          activeIcon: <MCIcon size={24} color='#801e5c' name="home" />
        }
      }
    }
  }
});

Sorry, but I can't reproduce it (also with RN 0.42 and react-navigation 1.0.0-beta.6; I tried 1.0.0-beta.7, too). That's the exact code I used to reproduce the following:

import React, { Component } from 'react'
import { View } from 'react-native'
import { TabNavigator } from 'react-navigation'
import { NavigationComponent } from 'react-native-material-bottom-navigation'
import Icon from 'react-native-vector-icons/MaterialIcons'

class ScreenOne extends Component {
  static navigationOptions = {
    tabBar: {
      label: "Home",
      icon: ({ tintColor }) => <Icon size={24} name="home" color="black" />
    }
  }

  render() {
    return <View />
  }
}

class ScreenTwo extends Component {
  static navigationOptions = {
    tabBar: {
      label: "Two",
      icon: ({ tintColor }) => <Icon size={24} name="bookmark" color="black" />
    }
  }

  render() {
    return <View />
  }
}

export default TabNavigator({
  ScreenOne: { screen: ScreenOne },
  ScreenTwo: { screen: ScreenTwo },
  ScreenThree: { screen: ScreenTwo },
  ScreenFour: { screen: ScreenTwo }
}, {
  tabBarComponent: NavigationComponent,
  tabBarPosition: 'bottom',
  swipeEnabled: false,
  animationEnabled: false,
  tabBarOptions: {
    bottomNavigationOptions: {
      labelColor: '#CCC',
      rippleColor: '#801e5c',
      activeLabelColor: '#801e5c',
      backgroundColor: '#FFF',
      style: {
        borderTopWidth: 0.5,
        borderColor: '#CCC'
      },
      tabs: {
        ScreenOne: {
          barBackgroundColor: '#FFF',
          activeIcon: <Icon size={24} color="#801e5c" name="home" />
        }
      }
    }
  }
})

(I did notice that animationEnabled: false causes the Touch-Feedback Ripple to be animated twice)
Is there maybe anything else which could affect your styling? I'm a bit clueless why this happens...

@hamidhadi Were you able to solve it?

Thank you @timomeh .
I could not solve it and because I want to use RTL language I wrote my own bottom navigation. But I didn't close this issue, so if anybody has this problem can write a solution to fix it.

I'm also having the same issue. Did anyone find any solution?
My code
export const Tabs = TabNavigator({
History: { screen: History },
POS: { screen: POS },
Offers: { screen: Offers },
Payment: { screen: Payment },
CRM: { screen: CRM }
}, {
tabBarComponent: NavigationComponent,
tabBarPosition: 'bottom',
    tabBarOptions: {
        bottomNavigationOptions: {
            labelColor: 'white',
            rippleColor: 'white',
            style: {
                borderTopWidth: 0.5,
                borderColor: '#CCC',

            },
            tabs: {
                History: {
                    barBackgroundColor: '#37474F',
                    paddingLeft: -60
                },
                POS: {
                    barBackgroundColor: '#00796B'
                },
                Offers: {
                    barBackgroundColor: 'red'

                },
                Payment: {
                    barBackgroundColor: '#00796B'
                },
                CRM: {
                    barBackgroundColor: '#00796B'
                }
            }
        }
    }
});

It kinda looks like the flex layout of the tabs isn't working. But I can't reproduce it...
@rishabhrawat11 Do you have a RTL Layout, too? I didn't test the shifting navigation with RTL layout (mainly because I thought it would work 😅) Maybe that's a direction where I could investigate.

I have the same problem.
RN version: 0.43.4

I upgraded to 0.43 and finally I can reproduce it. Will work on a fix quick.

I just published v0.5.0 which solves that issue.
This is a reported issue in React Native itself, see https://github.com/facebook/react-native/issues/12878. If I set minWidth like it's specified in the guidelines, the Layout engine of React Native will just use that instead of filling the available space, like a minWidth normally behaves.
For now I removed the minWidth, so you guys can use the BottomNavigation.
Thanks for your patience, took a while until I was able to reproduce it.


 clashes with use of  in Bogdanp/combine

While trying to upgrade an app to 0.18 I am getting this error:
Problem in dependency evancz/url-parser 2.0.0

The elm-package.json constraints of 'evancz/url-parser' are probably
letting too much stuff through. Definitely open an issue on the relevant github
repo to get this fixed and save other people from this pain.

In the meantime, take a look through the direct dependencies of the broken
package and see if any of them have had releases recently. If you find the new
thing that is causing problems, you can artificially constrain things by adding
some extra constraints to your elm-package.json as a stopgap measure.

Detected errors in 1 module.

I'm unclear what this means and how to fix it.

I have this problem as well, the json report I get from elm-make tells me this:

[{"tag":"INFIX OVERLAP","overview":"The infix declarations for () must be removed.","subregion":null,"details":"The precedence and associativity of a particular operator can only be set in one\nplace in a code base, and () has already been set somewhere else.","region":{"start":{"line":282,"column":1},"end":{"line":282,"column":13}},"type":"error","file":"elm-stuff/packages/evancz/url-parser/2.0.0/src/UrlParser.elm"}]

And it gives me this error because <?> is already defined in Bogdanp/elm-combine (I found this by using Elm Search.
I'm guessing you probably have the same issue?
You can get more info about the error by running elm-make --report=json.

@sporto, I need more information. Can you get it down to an http://sscce.org/ that demonstrates the problem?

@evancz 	this repository demonstrate the issue with a minimum example https://github.com/sporto/url-parser-deps
When I remove the dep Bogdanp/elm-time it compiles fine.

When using --report=json I see exactly the same issue that @icidasset 	pasted

The root problem https://github.com/elm-lang/elm-compiler/issues/1096 is tracked in https://github.com/elm-lang/elm-compiler/issues/1375. Until that is different, it will not be possible to build these things together. If someone has to give up <?> it seems like a URL parser has a better claim. The visual correspondence to ? in URLs is quite clear, whereas having a question mark for errors seems more dubious. I know it has history in Haskell parsers, but I think that's a weaker argument than the fact that ? is actually directly what is used in URLs.

If someone has to give up <?> it seems like a URL parser has a better claim

url-parser is the newer library here and it's likely that fewer things likely are directly dependent on its <?> operator since it was just introduced. elm-combine has had it from the beginning and, like you said, the operator has history. On top of that, you've declared <?> to be infixl 8 in your code, if you remove that declaration then its fixity will be infixl 9 and it will become possible to compile the two libraries together.

I've removed the fixity annotation from elm-combine. Hopefully that fixes things.

@Bogdanp 	that change you did in elm-combine fixed things for me, our app compiles now.
Should we close this issue?

In my Haskell parsers, I prefer to use expecting : String -> Parser a -> Parser a over (<?>) : Parser a -> String -> Parser a so I would recommend going that route in any parsing library. I also prefer using oneOf over (<|>). So my code would look like this:
literal =
  expecting "a literal like 4 or True"  <|
    oneOf
      [ numberLiteral
      , stringLiteral
      , boolLiteral
      ]

I think this is better than using the infix operators. You are not adding tons of parens when things get more complicated. You are just using simple functions, so it is easy to search for everything. You have no mystery operators where you have to intuit that (<?>) has something to do with error messages and (<|>) is supposed to look like "or" from the grammar syntax that very few people use outside of programming language papers.

In my Haskell parsers, I prefer to use expecting : String -> Parser a -> Parser a over (<?>) : Parser a -> String -> Parser a so I would recommend going that route in any parsing library. I also prefer using oneOf over (<|>). So my code would look like this:

That's fair, although going by the code here I think you underestimate your own usage of these operators. I prefer <?> over expecting and oneOf (or choice in combine) over <|> (in most cases), but the reality is I will use all of them if and when it makes sense to. The wonderful thing about having a type system is you don't have to rely on intuition when it comes to figuring out what most functions do, be they operators or not. Especifally when it comes to functions as simple as the operators in combine.
If people can figure out what <| (re your example) does then they can figure out what <?> does just as easily.

The parser is some of the oldest code in the compiler, so it has a lot of code where I just trusted how the Haskell people said to do things. So there are definitely legacy uses of the old style, and I'm slowly trying to convert things.

If people can figure out what <| (re your example) does then they can figure out what <?> does just as easily.

The <| operator is used quite a lot in Elm. Enough that I think it's safe to assume that by the time folks are writing parsers, they know what it is. So you are essentially arguing that learning 1 thing is just as easy as learning 0 things. Learning 0 things is definitely easier. Is it super difficult? Not really. But is it necessary to learn? No. Does it make code clearer for new readers? No.
So my point is more that if I got to start from scratch or had a team writing code around this, our style guide would say to avoid operators like these.
You can do what you want of course, but I just wanted to share my perspective!


[BUG] PagedIterable.iterableByPage(token) processes listing operations eagerly

Describe the bug
Calling pagedIterable.iterableByPage(token) results in a network call to fetch the next page using the given token. Calling .iterator().next() on this iterable results in an identical network call.
I believe it's because the iterableByPage(token) method eagerly calls the nextPageFunction.apply() instead of storing the token and waiting for a call to next.
Code Snippet
        int NUM_BLOBS = 10
        int PAGE_SIZE = 6
        for (int i = 0; i < NUM_BLOBS; i++) {
            PageBlobClient bc = cc.getBlobClient(generateBlobName()).getPageBlobClient()
            bc.create(512)
        }

        PagedIterable<BlobItem> pagedIterable = cc.listBlobs(new ListBlobsOptions().setMaxResultsPerPage(PAGE_SIZE), null)
        PagedResponse pagedSyncResponse1 = pagedIterable.iterableByPage().iterator().next()
        PagedIterable<BlobItem> pagedIterable2 = cc.listBlobs(new ListBlobsOptions().setMaxResultsPerPage(PAGE_SIZE), null)
        PagedIterable byPageFromToken = pagedIterable2.iterableByPage(pagedSyncResponse1.getContinuationToken())
        def pageAfterToken = byPageFromToken.iterator().next()

Expected behavior
Only two list calls should be made here, one for each of the lines that has .iterator().next(). Instead, there is a third network call coming from the line that calls iterableByPage(token), and it is identical to the request on the next line.

I've tested this further, and I am seeing that each call to next on the paged iterable is making two service calls instead of 1. It also seems that requests are being made eagerly.

It seems that the number of requests is actually correct and the apparent doubles were caused by the first iterator continuing to eagerly process the list.

@anuchandy could you verify whether the new PagedFlux/PagedIterable enhancements have resolved this issue?

PR #6465 should have resolved this issue.


reading package.json in nested repository

I have two nested repositories and both of them have been initialized with

npm init

So there are two package.json files. One in the parent and other in the child.
The parent's one has react, react-dom, babel-laoder, etc.
The child's one has nothing in its package.json and it is empty.
But inside the child directory I have some file.js which are React with JSX.
Trying to bundle any file in the child directory throws exception:
ERROR in ./home/three-JSX-main-patterns.js
Module build failed (from ./node_modules/babel-loader/lib/index.js):
SyntaxError: /var/www/html/ir/jsfun/home/three-JSX-main-patterns.js: Unexpected token (5:27)

If I

move the file.js out of that child (which has package.json) or
remove / delete the package.json file

then it works.
So when I run webpack inside parent directory it reads the package.json inside child directory!
Using neither webpack.config.js nor webpack --config false --entry ... from the command line worked.
the same question on stack-overflow with no answer:
How to ignore package.json from subrepo
Almost the same issue in 2016 #3577
How to ignore package.json at all?
webpack --version 4.33.0
node --version 8.9.1
OS: Linux Ubuntu 16.04

Unclear how this is related to webpack. Seem more like a babel misconfiguration, but issue has too few information to say.
It would be great if you reduce your issue to a small reproducible example. Best put this example into a github repository together with instructions how to get to the problem.

My best guess is that it related to wepack and not babel. The main issue is that webpac tries to read package.json file if there is any with the entry point
Running ./node_modules/.bin/webpack in the parent works fine if .js files are inside any other sub-directories and they (= sub-directories) do NOT have package.json file.
But if the child directory has package.json file then webpack throws an error which I know it relates to babel misconfiguration but this is not because of babel, it is because webpack reads package.json which is inside the child directory. And this package.json file is empty.
Removing package.json in the child directory or moving out JXS files from the child directory will fix the error and everything works fine.

if this is still unclear, then there is a problem with my explanation, and it is time to delete the issue!

webpack only read package.jsons to resolve modules, but here modules seem to resolve fine. It looks like babel configuration is different when in child1. Maybe you have your babel configuration in the package.json?

.babelrc inside parent
{
  "presets": ["@babel/preset-env", "@babel/preset-react"]
}

package.json inside parent
{
  "name": "nodepost",
  "version": "1.0.0",
  "description": "A Static Distributed Blogging System",
  "main": "",
  "dependencies": {
    "body-parser": "^1.19.0",
    "cookie-parser": "^1.4.4",
    "express": "^4.16.4",
    "multer": "^1.4.1",
    "node-dev": "^4.0.0",
    "react": "^16.8.6",
    "react-dom": "^16.8.6"
  },
  "devDependencies": {
    "@babel/core": "^7.4.5",
    "@babel/preset-env": "^7.4.5",
    "@babel/preset-react": "^7.0.0",
    "autoprefixer": "^9.5.1",
    "babel-loader": "^8.0.6",
    "mocha": "^6.1.4",
    "postcss-cli": "^6.1.2",
    "webpack": "^4.33.0",
    "webpack-cli": "^3.3.3"
  },
  "scripts": {
  },
  "keywords": [
    "blog",
    "blogging"
  ],
  "author": "Shakiba Moshiri",
  "license": "MIT"
}

webpack only read package.jsons to resolve modules

This is the issue, because in the child package.json is empty
$ cat child-1/package.json
{
  "name": "child-1",
  "version": "1.0.0",
  "description": "",
  "main": "index.js",
  "scripts": {
    "test": "echo \"Error: no test specified\" && exit 1"
  },
  "keywords": [],
  "author": "",
  "license": "ISC"
}

https://babeljs.io/docs/en/config-files#file-relative-configuration

Searching will stop once a directory containing a package.json is found, so a relative config only applies within a single package.

Okay. I apologize :(
For anyone with the same problem.

You want to programmatically create the configuration?
You want to compile node_modules?

babel.config.js is for you!

You have a static configuration that only applies to your simple single package?

.babelrc is for you!

more info
So I replaced my .babelrc:
{
  "presets": ["@babel/preset-env", "@babel/preset-react"],
}

width:
module.exports = function (api) {
  api.cache(true);

  const presets = ["@babel/preset-env", "@babel/preset-react"];

  return {
    presets
  };
}

Also file name from .babelrc to  babel.config.js


Detection of handwritten characters

Detect handwritten characters and deploy the project via a website or app.

@pratishthaa
Thank you.

@pratishthaa
I have been finished training the model and saved it.
Now i am working on building a website using flask and html to deploy it.
Is there any deadlines?

5 days is the deadline from when you got assigned

5 days is the deadline from when you got assigned

Thanks for information.

Hii, @Rutikab12 could you please assign me this issue

Hi @pratishthaa
I would like to work over it and deploy the model on a web application. Please assign the issue to me.

Hi. I am Likhita, a pariticipant of GSSOC'24.
I plan to follow the below methodology to achieve the objective to develop a robust model.
Methodology:

Utilize datasets such as MNIST for digits and EMNIST for extended characters, supplemented by data augmentation techniques like rotations and noise addition.

Experiment with various neural network architectures including Convolutional Neural Networks (CNNs) for image processing and explore the potential of transformers adapted for image recognition tasks.

Perform hyperparameter tuning and validate using k-fold cross-validation to ensure model robustness.

Measure performance through metrics such as accuracy, precision, recall, and analyze with a confusion matrix.

I would like to work on this issue, I have previously worked on visual transformers and NLP related tasks previously.


Why does the pointpillars net not have voxelization operation at the beginning?

I am a begginer of 3D obejct detection, i compared some pointpillars relization from det3d , mmdetection3D and PointPillars(https://github.com/zhulf0804), such as:
mmdetection3d : voxelization -> PillarFeatureNet -> PointPillarsScatter -> SECONDFPN -> Anchor3DHead
det3d: PillarFeatureNet -> PointPillarsScatter -> RPN -> MultiGroupHead
PointPillars : voxelization -> PillarEncoder -> backbone...
and i found mmdetection3D repo's pointpillars net and paper's PointPillars both have voxelization operation,  but det3d's pointpillars net is not. why ?

https://github.com/poodarchu/Det3D/blob/master/examples/point_pillars/configs/nusc_all_point_pillars_mghead_syncbn.py#L275


Fix for additional column added

For issue ga4gh/dockstore#1278
Fix for the additional column added to list tools/workflows

Codecov Report

Merging #245 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           develop    #245   +/-   ##
=======================================
  Coverage     60.1%   60.1%
=======================================
  Files          115     115
  Lines         3482    3482
  Branches       451     451
=======================================
  Hits          2093    2093
  Misses        1161    1161
  Partials       228     228

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c7471d...5e32616. Read the comment docs.


Improve Inbox page

### Tasks
- [ ] Add divider line under tab bar
- [ ] Add badge for new notifications
- [ ] Clear new notifications when viewed (see below)
- [ ] Remove blur background behind tab bar
- [ ] Proper subscribed button style
- [ ] Improve Dapp cards on Discover

Add divider line under tab bar

Clear new notifications when viewed
As a user, I expect the new notification badge to disappear after I viewed the notifications, so I can see a clear difference whenever I have unseen notifications.

Remove blur background behind tab bar – 100% white

Proper subscribed button style

Improve Dapp cards on Discover
Design details here

[ ] Check dapp-name font stylings (should be SF Pro Semibold)
[ ] Check domain font stylings (should not be rounded)
[ ] Add the verified badge for all official (WalletConnect) apps
[ ] Add thin outline around avatar
[ ] Add placeholder avatar for every app without uploaded avatar

When subscribed, make app card tappable
As a user I expect on the discover page to be able to tap on the card of an app I am subscribed to, and then get redirected to that app page – eg. when subsribed to "GM Dapp" tapping on the GM Dapp card on the Discover page, brings me to the GM Dapp page with all notifications.


Alternative for parted mkfs needed.

parted mkfs was removed in parted 3.0
  are no longer recognized because they were all dependent on parted "knowing"
  too much about file system: mkpartfs, mkfs, cp, move, check, resize.
  This change removes not just the user interface bits, but also the
  library functions and nearly all of the underlying FS-munging code.
  The code embedded in Parted by which it knew about those file systems
  was so old, unmaintainable and buggy that while seemingly drastic,
  this change is like removing a gangrenous toe. ```
http://savannah.gnu.org/forum/forum.php?forum_id=6837

It would be great if an alternative could be provided, so that one could continue to use this module on systems with newer versions of parted.

Thank you for bringing this to my attention. I will look into it.

I have created a new branch for parted 3 development. Right now it contains an untested fix for your problem. 5d26ad2e8dee112f92411278356c978e5d6dedaf.  Do you have a safe setup where you can try this? Feedback would be appreciated.
I also got the impression that some of the parted fields are aligned different then before. This means the parsing is off.
parted 3 contains machine parseable output. That is a much better and safer option. I'm going to implement that as well.


1227 - Airplane Seat Assignment Probability

Description of the Problem
n passengers board an airplane with exactly n seats. The first passenger has lost the ticket and picks a seat randomly. But after that, the rest of passengers will:

Take their own seat if it is still available,
Pick other seats randomly when they find their seat occupied

What is the probability that the n-th person can get his own seat?
Example 1:
Input: n = 1
Output: 1.00000
Explanation: The first person can only get the first seat.

Example 2:
Input: n = 2
Output: 0.50000
Explanation: The second person has a probability of 0.5 to get the second seat (when first person gets the first seat).

Constraints:

1 <= n <= 10^5

Code
class Solution:
    def nthPersonGetsNthSeat(self, n: int) -> float:

Link To The LeetCode Problem
LeetCode

I would love to solve this problem

#154


Add filter to url mapping

With this changes the filter entered will be kept in the url as:
http://localhost:8000/consul-services-ui.html?filter=test&service=some-service

@geobeau Thank you very much for your contribution!


Should we make the type prop for TextInput required?

As it currently is, the type prop is not required and defaults to "text". The main problem that we are seeing in logistics with this is that folks are forgetting to pass the type prop for email, phone, etc. This in turn results in mobile users getting the wrong keyboard when they interact with the non-text fields.
While making this change will be more cumbersome for the developer, it will ensure that they are forced to think about what type the field actually is, and ultimately result in a better experience for mobile users.
Of course, type is not required in the html spec, and defaults to "text". However, this spec was written before the time of mobile.
Also, could we be more explicit about what strings type excepts in Storybook? It might save someone the hassle of going to Mozilla.

hey @JCarmine while I agree this can lead to the proper type being omitted, I'd rather leave it up to individual teams to decide on the correct approach here.


Image: Update to v1.9.1.

For changes in the chart, chart templates and container images, I executed the following tests, using the hello-world app, to verify them in live environments:

[ ] Upgrade from previous version

[ ] AWS
[ ] Azure

[ ] Existing Ingress resources are reconciled

[ ] AWS
[ ] Azure

[ ] Fresh install

[ ] AWS
[ ] Azure

[ ] Fresh Ingress resources are reconciled

[ ] AWS
[ ] Azure

We need to forge a new minor release before we can merge this.


Options can be improved

There are some issues in the part of the code which handles resizing:

options.height is ignored when options.width is set;
and images smaller than options.height and/or options.height can be either upscaled or not compressed (because the comparison in line 107);

Note that, because the comparison in line 107, seems resizing is only a method to try to make a image smaller, not a requirement. I think there should be at least a note in readme about that.
In lines 94 and 96 the format of the resulting image is the same format of the original image. So the format is a choice of the end user (it can be even a BMP image). Would be better if it was an option.
Finally, is complicated to add a size limit option? Too large files can be compressed into a lossy format (like imgur, which converts PNGs larger than 5MB to JPEG).

Good issues and suggestion! We will improve them soon. Thanks.


[REEF-388]: Fix violations of RedundantModifier checkstyle

This addressed the issue by

removing redundant modifiers as detected by the check

JIRA: REEF-388

I'll test and merge.


ToDo Android Application

Requirements for the application:-

User can see an input field where he can type in a to-do item
By pressing enter (or a button), the User can submit the to-do item and can see that being added to a list of to-do's
User can mark a to-do as completed
User can remove a to-do item by pressing on a button (or on the to-do item itself)

Requirements for README:-

Concepts Learned
Offical Documentation Usage and all the resources used to learn
Future aspects for the app
An optional Medium Article for the code walkthrough.

Hi. I'd like to work on this. How may I contact you, when in doubt?

@adizcode you can go ahead. You can contact me through linkedin or mail id<EMAIL_ADDRESS>

Hey I would like to contribute can you assign it to me?

Hi, I am interested in this issue is it still up for grabs?

Hey! I want to work on this.

Thank you. I'm on it.

Give a star to our repo if you liked the project.

Sure. Btw I'm almost done. I'll try to wrap it up in a day or two.

@adizcode Thank you for supporting us.

I'd like to take up this issue!!

@kunal299 Before making the pull request, I'd like to know if I'm allowed to upload the project on my GitHub page as well.
It would make it easier for me to continue working on this some time later.

@dubesar Hey, could you please take a look at the pull request.


Format changed?

The auto-downloader seems to be sub-optimal right now. Need to update the algorithm to check the date.

Addition of express puzzles etc caused bother. Fixed in 960eac46


Questions about florida.js functionality

The following questions are about how scripts/Florida/florida.js is designed to function. Please note that I'm asking about design goals for how the script should work, not how the script functions currently.

Is the list of seeds in seeds.list static (i.e. it only changes via manual updates), or can seeds.list change while the http server is running? In other words, can the florida.js script read seeds.list once when the server starts or must it read seeds.list on each request?
Is florida.js a high-volume server that is polled frequently, or is it a low volume server? Specifically, does the performance of florida.js matter?

I'm asking because I think there are a few updates that I would like to make to florida.js:

If seeds.list is static, then the script should read the file once when the server starts instead of on each request.
readFileSync should be changed to readFile to avoid blocking IO.
console.log is blocking and can/should be removed if the performance of florida.js matters. Even if performance is not an issue, I could add a debug flag that enables/disables console.log.

If these updates are agreeable, then I'll submit a pull request tonight.

I believe @diegopacheco would be the person to ask about this Node.js script. You can check #195 for the design principles as well.
At Netflix we use a sidecar called Florida developed in Java, which have not been open sourced yet. This script was developed by @diegopacheco  as an open source alternative.

@ipapapa Thanks for the input.
@diegopacheco I have committed my updates to my forked repo. Please review. If approved, I will then submit a pull request.
You can view my proposed changes in the async-florida branch at https://github.com/akbarahmed/dynomite/blob/async-florida/scripts/Florida/florida.js.
I also wrote a small document on how to directly run florida.js (if needed): https://github.com/akbarahmed/dynomite/blob/async-florida/docs/florida.js.md

@akbarahmed  @ipapapa
As far I as benchmarked Dynamite I would not say Florida is a high volume service Florida. Florida receives a couple of calls, time to time, it's not a big deal. However, your points for the sake of improvements are valid - thanks for the contribution. :-)
If you change the seeds file you will need stop Florida and start again, which is okay, I did not see problems on dynamite because of this. If you take a look on Dynomite src/seeds_provider/dyn_florida. c, you will see I added some OS_VARS so you can change Florida URL, IP and PORT, this gives you the ability to point to other servers you can write your on Florida implementation since is just a proxy.
Cheers,
Diego Pacheco

@akbarahmed  you changes looks ok to me.

@akbarahmed please create a pull request to dev branch. Thank you!

@diegopacheco @ipapapa Thanks for the approval/review. I'll issue a pull request by tonight.


problem on mac with draw points

When rendering points on an M1 mac, they all come out different sizes. We are submitting via sgl_v2fC3b, but I'm wondering if we should be submitting points in some other way that also indicates the size?
sgl.beginPoints();
sgl.v2fC3b(0, 0, 69, 157, 132);
sgl.end();

We'll follow up shortly with a repro.

Ping from sokol repository, @mehula, @ssteinbach (I have moved to issue form sokol-zig over here).

Lol: https://github.com/floooh/sokol/blob/8fcd271f7d4cb19c77aa9f0bbfe8cb7f319dbffc/util/sokol_gl.h#L70
My current plan is to add a new function:
void sgl_point_size(float size);

This will work the same as setting the vertex color or texture coordinates (meaning it can be called anywhere, outside begin/end, or also between vertex calls). This costs an extra float in the vertex struct, but I guess that's alright.
I'll ignore D3D11 for now (meaning the point size there will be hardwired to 1 pixel, so it's not very useful), but I tinkered a bit today with ideas how to emulate point size if the D3D11 backend is active, just to get an idea how much effort it would be.
It'll probably be one or two days until it's ready.

Thanks for the quick response!  pinging @meshula too (typo in his username above)

Quick question: do you need texturing to work with point lists? Because in that case I'd need to split off the point list shader and handle that as a special case (I also don't know yet if the method of generating texture coords in the pixel shader via gl_PointCoord works via SPIRVCross for the Metal backend).
In that case it's probably better to simulate point-list rendering in sokol_gl.h via instanced triangles (which would also be the solution for the D3D11 backend anyway).
If only coloring is needed I'm nearly done (only some compile fixes for the D3D11 backend, adding a new demo to the sample webpage, and rebuilding the sokol-zig bindings).

Ok sokol-zig has been updated, this is all that has changed in sokol_gl.h ;)
https://github.com/floooh/sokol-zig/commit/83c3e201ef6513e6ed6adbd966a3a55c889e1cc3#diff-249d3911afc2d93957d61f3710d35d98c114b6c1fc2b7240c5feaf2920116b44
I'm going to port the new sgl-points-sapp sample over to Zig now :)

Plain old color points is fine! Ultimately using triangles instead of points is probably preferable for portability to D3D, but it doesn't impact our project today, since we're iterating on a mac.

Ok, I just committed the points-sample to sokol-zig (still getting used to doing mixed integer/float math code in Zig):
https://github.com/floooh/sokol-zig/blob/master/src/examples/sgl-points.zig
I just noticed though that on my Intel Mac and the current Zig HEAD version the sokol samples crash hard when compiled with -Drelease-safe or -Drelease-fast, don't know yet what's up with that, it works on my new M1 Mac though (and also on Windows), so I guess it's an Intel and Mac specific ABI issue (there have been several similar issues in the past, especially after updating the LLVM version).
Anyway... I'm going to close the issue and return to emulator coding. If there's anything else popping up, just open a new issue :)

Thanks very much!
Similarly to your crash, we're running into lldb issues with M1/latest zig (inability to launch a zig compiled executable at all), I think if we let Apple and zig churn a little, ultimately these issues will just be temporary.

Yes, just wanted to say thanks for the quick response and great library!


Use with Exception Filter in Web API

I have just started using this in our ASP.Net WebAPI projects and have noticed when I call "ActivityScope currentActivity = ActivityScope.Current;" in an Exception Filter that this returns null.
Is there something I am doing wrong that this is not persisted ?

You will need to use the CorrelatorSharp filter before any other filters that might want to use the ActivityScope.Current, to ensure it is set up.
Your filters setup should look something like this:
config.Filters.Add(new CorrelationIdActionFilter());
config.Filters.Add(new RequestLoggerActionFilter());


Update publish_docs_to_wiki workflow to use publish_wiki of github_action_workflow repository

Why
We have a github_action_workflow repository to maintain the reusable workflows, including publish_wiki.yml workflow. It's better not to fragment the workflows and maintain it ourself.
Updating publish_docs_to_wiki to extend and use the actions in publish_wiki.yml.
Who Benefits?
Developers.

@nimblehq/android-chapter Could I get more votes on this one, please? 🙏

Please check out this issue too, we might end up using this repository instead 🙏

@Tuubz yes, I'm aware of that issue. We might need to update this issue's description when the RFC is approved 🙏

@Tuubz @manh-t To conclude, which workflow we could use for now? Updating the description when the RFC is approved doesn't make sense imo.

@manh-t
If you agree, please update the description to make use of this repository 🚀


Multiple bridges tests

Description
Please provide a detailed description of what was done in this PR
Changes include

[ ] Bugfix (non-breaking change that solves an issue)
[ ] Hotfix (change that solves an urgent issue, and requires immediate attention)
[ ] New feature (non-breaking change that adds functionality)
[ ] Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes
Please complete this section if any breaking changes have been made, otherwise delete it
Checklist

[ ] I have assigned this PR to myself
[ ] I have added at least 1 reviewer
[ ] I have added the relevant labels
[ ] I have updated the official documentation
[ ] I have added sufficient documentation in code

Testing

[ ] I have tested this code with the official test suite
[ ] I have tested this code manually

Manual tests
Please complete this section if you ran manual tests for this functionality, otherwise delete it
Documentation update
Please link the documentation update PR in this section if it's present, otherwise delete it
Additional comments
Please post additional comments in this section if you have them, otherwise delete it

Also worth considering do we need bridge tests that involve only one external chain, as these are the more general one. Once we make them work as expected, we can assess whether we can remove the old ones.


Proper way to test a File parameter?

What's the proper way to unit test a route that has a File parameter? For example, a route that would update a user's avatar on s3:
  params do
    requires :avatar, type: File
  end
  post "/info/avatar" do
    # update user's avatar on S3...
  end

In order to test this manually I have done multipart requests with HTTPoison:
name = "avatar"
filename = "avatar.png"
path = "assets/avatar.png"
body = {:multipart, [{:file, path, {["form-data"], [name: Poison.encode!(name), filename: Poison.encode!(filename)]},[]}]}
HTTPoison.post!("http://localhost:8080/info/avatar", body)

Is there some easy way to do this in a Maru test?

You might have to make this into a helper method and wrap it into your test suite.
OOTH, providing that as a snippet + PR to Maru.Test could help as well!

There's also this answer from StackOverflow - [link][https://stackoverflow.com/a/33871714/602588]


Evernote Error: 2 - authenticationToken

I think my token is in the right place:
my user settings json is:
{
    "evermonkey.token": "S=s5:*************e39",
    "evermonkey.noteStoreUrl": "https://app.yinxiang.com/shard/s5/notestore"
}

Please tell me what's wrong here

check and resart vscode

It works after restart.

Use lazy initialization to avoid restarting next version.

I have restarted and have this problem too


Create pages to document version 2 Widgets

The new HTML has been added to the TDK for all widgets. This means that the code needs to be documented into the 'v2' directory, see https://github.com/basekit/docs.basekit.com/tree/master/widgets/v2
Process

[x] Duplicated v1 pages
[ ] Add sample HTML to each page
[ ] Add widget code to any widget page that has been changed or updated
[ ] Enable access to them in the navigation

Added placeholder block for new HTML samples in commit https://github.com/basekit/docs.basekit.com/commit/f78557b7736533ce3035a92f32e59652c8204007.

Widget Pages Checklist
Widgets
Content & Images

[x] Content Widget
[ ] Line
[ ] Spacer
[ ] Gallery
[ ] Image
[ ] Slideshow

Template Elements

[ ] Logo
[ ] Extended Navigation
[ ] Feature

Buttons

[ ] Button Widget
[ ] Tweet Button
[ ] Click To Call
[ ] Dropbox Button
[ ] Facebook Like
[ ] Social Icons

Forms

[ ] Signup Form
[ ] Contact Form

Embeds

[ ] Map
[ ] SoundCloud
[ ] YouTube
[ ] Disqus Comments
[ ] LinkedIn Company Profile
[ ] LinkedIn Profile

Profile

[ ] Profile
[ ] Company Address

APIs

[ ] Yelp Reviews
[ ] Twitter

Deprecated

[ ] Redirect To Desktop

Plugins
Menu

[ ] Menu Sections
[ ] Menu

Blog

[ ] Blog Post List
[ ] Blog Post
[ ] Blog Search

Ecommerce

[ ] Ecommerce Basket
[ ] Ecommerce Categories
[ ] Ecommerce Checkout
[ ] Ecommerce Confirmation
[ ] Ecommerce Featured
[ ] Ecommerce Legal
[ ] Ecommerce Product List
[ ] Ecommerce Product


Feature Flag Cleanup - 2053 CLEAR_CELERY_CHAIN

User Story - Business Need
The implementation in #2053 had a possibility of affecting prod, so it was feature flag wrapped. This PR removes all of the feature flags related to that work and removes the non-feature flagged code (the else part of the if block).

[x] Ticket is understood, and QA has been contacted (if the ticket has a QA label).

User Story(ies)
As a VA Notify
I want Feature Flags to only exist as long as necessary (vetted work on staging)
So that our changes roll out to prod as soon as possible, but safely
Additional Info and Resources

See changed files in the PR.
Acceptance Criteria

[x] noqa removed from all methods that had it added
[x] CLEAR_CELERY_CHAIN feature flag removed
[x] Code follows the enabled path and the disabled path code is removed
[x] This work is added to the sprint review slide deck (key win bullet point and demo slide)

QA Considerations

Potential Dependencies

Out of Scope
If noqa cannot be removed after clearing out the if blocks do not attempt to simplify the methods, create a new ticket to simplify the method.

Merged. Task is done.


Sign the APK

Description of Problem or Question
Between Version 2.0.1 and 2.1 the APK couldn't be updated without a manual deinstallation of the APK. The reason is, that the 2.0.1 release was build on the machine of @NPBruce and the 2.1.0 release on the machine of @BenRQ. In order to avoid having to uninstall the APK to update, we have to sign it and ship the keyfile with the project, so that every builder will create the same APK signature.
https://boardgamegeek.com/thread/2079275/valkyrie-21x-installation-problems
The default keystore should be under:
C:\Users\<user>\.android\debug.keystore (default password is android)
But we better add one ourselfs using https://keystore-explorer.org/downloads.html for example.
Update: Another problem is, that the verision and versioncode does not change. The build creates version 1.0 every time.
Valkyrie Version
2.1.2

@redwolf2 merge is done, can I close this issue or do you still want to improve it ?

We can close it.


Add support for arguments in transforms

I think a great reason why the natural filters could be a lot better than what we have in Django is that natural filters allows for arguments for transforms. For example:
qs.filter(Author.name.substr(0, 25).collate('fi').icontains('anssi'))

Transforms with arguments are pretty much impossible with current Django syntax.
So, +1 for working on this from this Django core developer.

Yeh this is really cool and it's actually what I am aiming for.

One idea is to only implement an half-way solution in the beginning. Something like
.filter(F('name').substr(0, 25).collate('fi').icontains('anssi'))

So, field traversal happens with the old syntax, but transforms and lookups use dotted syntax.
If this works, then you could move forward to also allow field references by dotted syntax.


fix(formatter): json needs a distinct tool entry

This fixes https://github.com/aspect-build/rules_lint/issues/121 in a similar way to how this sort of thing was fixed in https://github.com/aspect-build/rules_lint/pull/99
Type of change

Bug fix (change which fixes an issue)

Test plan

Manual testing; please provide instructions so we can reproduce:
Verified that with JSON is now being formatting using my fork and branch!

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks, it's extra embarrassing since I had that bug in mind when I did the refactor to make json its own language, but convinced myself it was working. Obviously this needs a new test fixture that checks formatting works one language at a time.

Any objection to merging this while you work on the test harness framework? I'll add a test based on how you want to structure the unit testing.

Ah I see I made a mistake! Ran format so it should pass now

Making it a separate tool is one way to resolve this, but the simpler way is to copy from CSS and HTML handling. I added coverage for it to #126 which I think resolves #121 in place of this PR, wdyt?

Happy to close this in favor of https://github.com/aspect-build/rules_lint/pull/126. Ngl makes me a little sad that my name is not making it into the repo ;). However, its totally fine. Just happy to see it fixed.

I have no doubt we'll have more of your commits in the history! :)


[qsr_lib] QTC performance enhancements

Minor: The collapsing of chains has been vectorised. Saves 0.02~0.04 seconds on the test sample with 364 measurements.
Major: Creating a lookup table of previously calculated QTC state chains for object pair combinations. If an object pair is requested, we first check if the inverse pair has been calculated before. If so, just flip the names and numbers around and add the new result to the output. This almost halfs the computation time if no qsrs_for are specified. Of course, if qsrs_for does not contain "duplicates", this has no effect.

Are all QSRs reversible? So far all of the ones I've used are, is it worth implementing that major change across all QSRs to save doing each one individually?

Most of them should easily be reversible... The only problem I see is with conedir. Also RCC8 has this tpp and itpp stuff which would have to be flipped, right?

Yeah, I mean they wont always be identical, but each relation would have an opposite relation which could be looked up from a dictionary or something.
so for example in RCC8, if the result of (ob1,ob2: DC)  then the opposite would be (ob2,ob1:DC), however, if the result was (ob1,ob2: TPP) then the opposite would be (ob2,ob1: TTPI), but they are consistent, so by giving a dictionary with each qsr of the opposites then you could look it up so could just be manually coded in a dictionary with the following key values. For RCC8 it would look like this:
RCC8 lookup

Relation
opposite

dc
dc

ec
ec

po
po

eq
eq

tpp
ttpi

ntpp
nttpi

I'm not sure if there is like a general way of handling this for all qsrs by just defining a lookup table of what turns into what but doing it, even it is manually for all QRSs, is worth it I think.

Have some comments on the files which might help to improve the speed even further.

Anyway, test if it works and happy to merge as it is... Above comments can be merged after some other issues (like #134 ) are resolved to avoid redoing things.

@yianni I didn't change the string handling since the join version is not significantly faster and the version using reversed is even slower. What I did change is the way of looking up previous results, i.e. I use the world_qsr_trace as you suggested. The result is a bit different because in QTC I loop through the qsrs_for and then through the timestamps instead of the other way around which makes it a bit harder to access the right trace but it works for me now.

Although, I have to say it is much more code now ;)


Don't ever put an empty array into ArrayValue

@paprikati I'm going to close this as it has been superseded by #36


Translation of navigation menu OR of params. Never both.

First of all: Thank you for the wonderful and very functional theme!
I have the problem that I can only translate the [params] section OR the navigation links in the menu. But never both!
Also, it turned out for me, that [Languages.en.params] did not work for me. I had to use just [Languages.en] followed by the list of parameters.
I am working with RStudio and blogdown. (https://bookdown.org/yihui/blogdown/)
Following an example:
When I have at the end of my toml file the following code:

[Languages]
[Languages.en]
role = "Professor for Educational Technology"
[Languages.de]
role = "Professor für Bildungstechnologie"`

then I can see the differences but in the German navigation menu I will get the English just the English menue names. But when I delete these line those lines which I have written in my toml before those I have shown above have effect and my German menue works, for instance it shows the menue 'Contact' in German as 'Kontakt'.

[[languages.de.menu.main]]
name = "Kontakt"
url = "#contact"
weight = 6

I have tried out different order and places for these two segments of code in the toml but I managed only to get one (either menu or params) to work. Any idea what could be my problem?

The following works for me if you wish to change both menu text and menu link/section-URL for each language:
Create a post/home/about.md for default language
Create a post/home/about_german.de.md for German language.
Then in your config.toml above the language section:
[[menu.main]]
  name = "Home"
  url = "#about"
  weight = 1

[[menu.main]]
  name = "Publications"
  url = "#publications_selected"
  weight = 2

[[menu.main]]
  name = "Posts"
  url = "#posts"
  weight = 3

[[menu.main]]
  name = "Projects"
  url = "#projects"
  weight = 4

[[menu.main]]
  name = "Teaching"
  url = "#teaching"
  weight = 5

[[menu.main]]
  name = "Contact"
  url = "#contact"
  weight = 6

[[Languages.de.menu.main]]
  name = "German Home"
  url = "#about_german"
  weight = 1

# Taxonomies.

This worked - Thank you! My problem was that my file name for the German version of the about-page was just "about.de.md". This simple structure worked with "contact.de.md" as the contact page consisted just of variables with no paragraphs of text.


Fix issues with shorthand css properties

The flex-flow attribute is a shortcut containing the flex-direction and flex-wrap.
When setting flex-flow to an empty string, this resets flex-direction to its default, that is row, even if the trait attribute for flex-direction was column which is a bug.
We actually don't need flex-flow which is only a shortcut to the two other properties so I am removing it.

I don't think we need to remove this trait.  Also, this heads us down the path where we are choosing a subset of the CSS layout arbitrarily.  How about checking the current value of the trait before setting it to "".  If the trait is undefined or null (w/e it is by default), don't reset to "".

@jdfreder consider the following case.
VBox([Button(), Button()])

The initial value for the trait flex-direction is then 'column' and for flex-flow it is ''.
In the view constructor, we loop over these properties: We first set style['flex-direction'] to 'column', which immediately changes the flex-flowattribute.
In the next iteration of the loop, we meet the flex-flow attribute. Setting it to '', we effectively replace the value of the flex-direction from column to '', that is row nowrap. I don't think that we can work around that in a simple way.

For this reason, we cannot be stateful with css properties that are shorthand properties.

Ah yes, I see.  This is the only shorthand property?

The only one that I noticed. There are others for which we don't expose the bound properties like margin.

We need to be consistent about shorthand properties: either we only expose shorthands or we only expose bound properties - everywhere.
In the flexbox css guide, regarding the flex property, they recommend using the shorthand.

@jdfreder this is ready for rereview.

After one on one discussion with @jdfreder I removed the border attribute so that we can merge the bug fix and discuss this later.

Thanks! :)

Test failure looks unrelated, and actually a problem with karma.

Thanks, I was looking into the failures.

The case of border width is a subtle one. If it is part of the box model,
then we may want to include it in layout.
On Tue, Jan 5, 2016 at 4:35 PM, Sylvain Corlay<EMAIL_ADDRESS>wrote:

Thanks, I was looking into the failures.
—
Reply to this email directly or view it on GitHub
https://github.com/ipython/ipywidgets/pull/286#issuecomment-169178709.

--
Brian E. Granger
Associate Professor of Physics and Data Science
Cal Poly State University, San Luis Obispo
@ellisonbg on Twitter and GitHub
<EMAIL_ADDRESS>and<EMAIL_ADDRESS>


Preprocessor bug

This simple PR aims to fix the issue #393.
I added a test that covers the function keyword, I think it suffices but let me know if more are needed :)

You are right!
I was trying to piggyback on a test file that was more closely related, but I see that it might not be so clear what it tried to achieve.

Do you want to clean up the git history or do I "squash and merge"?

Squash and merge would do just fine :smiley:


count_spe_trades is not defined

Hi @5ymph0en1x , I am getting this error:
p_value: 0.06075080504069065
Beta: [1.64576441]
Traceback (most recent call last):
  File "Trading_Model.py", line 250, in <module>
    EG_Test.process_trading(index=j, transaction_cost=0.000, **action_dict)
  File "/srv/STRATEGY/Cointegration.py", line 484, in process_trading
    self.gen_trade(order)
  File "/srv/STRATEGY/Cointegration.py", line 409, in gen_trade
    if self.count_spe_trades(instrument_1) < 0:
AttributeError: 'EGCointegration' object has no attribute 'count_spe_trades'

it seems function count_spe_trades is not defined.

Hello @mg64ve,
Sorry about the missing function.
I don't know how it happened but it should be ok now (see last commit)...
Best regards


Hop hints opt in addholdinvoice

Change Description
Relates to  #6523 and changes it also for lncli addholdinvoice

Needs a rebase! Should also now add the entry to the 0.15.1 release notes. a


Feature Cardinality

Currently, feature cardinality is ignored and always set to 1. Enabling them for single features is trivial, but some questions about nested cardinalities remain.

How do they interact with references to other trees that may have a different cardinality?
Interactions with alternative and range subgroups.
Are cardinalities inherited?

Code syntax with a,b in N, 0 <= a  <= n <= b. n is the number of true instances of parent:
parent cardinality [a..b] {Attribute}
    child

Rules:

Constraints apply to all parent instances and can't be specific to one instance.
Attributes gets multiplied by n.

z3:
For z3 we decided to generate parent b times as a boolean and also generate children for each instance.
We check with Atleast, that at least a instances of parent are true.
When using Group cardinality this allows the instances of parent to count into the group cardinality counter.
If this is not a wanted behavior by the user, the user can put this feature inside a container (see alternative container).
This implementation also forces the user to put a feature with cardinality inside a "container" when using alternative to count as one:
alternative
    featureA
    container
        mandatory
            parent cardinality [a..b] {Attribute}
                child
    featureC


Fix indent rule to allow for lining up var declarations

Our indentation specification is for 3 spaces. We also specify that var declarations need to line up. The base eslint indent rule doesn't allow for this.
This fork of the indent rule will enforce our rules using the following:
"silvermine/indent": [ "error", 3, { "VariableDeclaratorOffset": { "var": 1, "let": 1, "const": 3 }, "SwitchCase": 1 } ]
Invalid example:
var a = 1,
   b = 2;

Valid example:
var a = 1
    b = 2;

@jimjenkins5 back to you

Added more tests and fixed comment.
The VariableDeclaratorOffset should be 1. It's an addition to the indent, not a replacement.

@jthomerson back to you

Overall, the plugin seems to work well! We just have some formatting issues to take care of. Getting close! @jandmdigital back to you.

@jthomerson this looks good now.


add utf-8 encoding

this should fix https://github.com/dermatologist/fhiry/issues/133

Thanks, @fhirfly !

I cannot merge the PR.  @dermatologist .  You are welcome.


Rustup for BodyCache changes

@bors r+
Thanks!

:pushpin: Commit a418fe9826b4b2aa0a2f9d6c26d82673262a757a has been approved by RalfJung

:hourglass: Testing commit a418fe9826b4b2aa0a2f9d6c26d82673262a757a with merge 95f80403bf387ef65dfe5db0b1c5341ffa3723c2...

:sunny: Test successful - checks-travis, status-appveyor
Approved by: RalfJung
Pushing 95f80403bf387ef65dfe5db0b1c5341ffa3723c2 to master...


yaml: refactor doma_kernel path variables

Refactor doma_kernel path variables, to be
able to switch to new kernel in a more simple way.

added RB


Create RTD site for Simple JWT

We should have a readthedocs site for Simple JWT.  I'll hopefully get to this in the next couple of weeks.

Wow, this finally got done!


Extend the JMH benchmarks for tracing

Add benchmarks for the followign features:

enabling tracing on a method without additional settings
tracing a method and writing many (10) attributes to the resulting span

Closed in favor of macrobenchmarking


PHOENIX-4288 Indexes not used when ordering by primary key

Add class Cost.
Add method getCost() in QueryPlan.
Let QueryOptimizer choose the best plan based on Cost; meanwhile if stats are not available the QueryOptimizer will keep the original behavior.

Thank you for the review, @JamesRTaylor! These are very good comments. I'll update the PR accordingly.

@JamesRTaylor, I made all the changes suggested in your comments except one: "need more test cases" Thought I'd naturally go down this path as I start to tackle other issues under PHOENIX-4313. Please let me know if this PR is good enough to be pushed in, thanks!

Also, please attach a patch file as described here and click the Submit Patch button on the JIRA so we can get a test run with this patch to confirm there are no regressions.


Armadillo version check in cmake file

Mantella didn't compile on version 6.4. Should be at least 6.7.

I know is advised you to add this issue as the problem came up, but now I am confused, als we already got
set(REQUIRED_ARMADILLO_VERSION "6.700.0")


--header does not support : in header value

Hi,
I'm using the CLI docker solution; with the following command to run the testing.
docker run kiwicom/schemathesis:stable run -w 8 --base-url=https://localhost:8000 --header=X-ApiKey:123BDKxY=:123WP6d5Bo3tlw= openapi.json --junit-xml=junit.xml
The header value is a combination of 2 encoded strings, which is divided by the ":".
It seems that is not supported, since I got the following error:
Error: Invalid value for '--header' / '-H': Should be in KEY:VALUE format. Got: X-ApiKey:123BDKxY=:123WP6d5Bo3tlw=
Is there a way that I can overcome this error, by wrapping the value in quotes? Or another way around this error?

Hi @thim81 !
Probably I overlooked this! And I don't think that there is a decent workaround to overcome this error. However, let me look into the code and I believe we can add support for it

The fix is released in 1.6.3
Please, let me know if it fixes your case

Hi Dmitry,
I can confirm the header now works.
Thanks for the quick follow-up.


Need to add action markdown link check

I think there is a need to add an action to check all the links are working or not.

Can you assign this issue to me...and if possible pls tell me what exactly I need to do.

@priyanshu688 I'm not moderator I raised this issue because I think this will automate the link checks and also if moderator read this I'm also able to do this task if you feel I'm a right guy to resolve it..

@sdmg15 Please assign this to me...

@sdmg15 Is this repo is taking part in Hacktoberfest2022?


Compatibility Issue with Monk's Enhanced Journal

I got the error-
libWrapper: module Monk's Enhanced Journal and module Lock & Key modify the same FoundryVTT functionality and are more likely to conflict. foundry.js:68050
On another note when I disable Monk's Enhanced Journal and I test the module as a player I can't unlock, pick, or break a locked door. I can't do anything. I've tried the macros and I've tried right-clicking. nothing.

The first part with the warning only show up becaused both modules use a similar control sceme in some way meaning it could theoretically conflict. As far as i know though, there are no concrete issues related to this.
I will look into the second problem, which game system are you using?

After some testing i was not able replicate this behaviour (the module not working after uninstalling Monk's Enhanced Journal). Which foundry version are you using and are there any error messages in the console (F12) when this happens?

I'm getting the same LibWrapper warning about Enhanced Journals, but everything appears to be working correctly from my testing leaving Enhanced Journals enabled.  As an aside, Monk had the same warning popping up between his own modules, Enhanced Journals and Combat Details, and released a fix today for them that seems to have resolved it.  Still getting the warning for Lock & Key/Enhanced Journals after the update though.

Just released v1.9.3 that should fix this warning, it however just tells the the libwrapper module to suppress it so any bugs that could appear still will appear

Is there still any compatibility problem with Monk's Enhanced Journal? If not i will close this issue soon.

I don't think that Monk's Enhanced Journal is the issue now. I just can't get the module to work in 5e. I'm running Foundry v11.308. I can make a key but when I try to use the key by using the macro nothing happens and the hotkey just tries to open the open door again but says it is locked.

The behaviour of the macro is expected as it only works for players (is asume you are loged in as a GM). The behaviour of the key (K) however is strange. Few questions:
-Do any errors show up in the console when using the key?
-Which modules are you using?
If you want you can send me your world file, then i can have a closer look at the problem

I'm testing it by logging in as a player. I've tried with just Lock & Key on and I was able to roll to break the lock. to pick the lock it said that I didn't have lock picks but I did have thieves' tools. and I had the key to the door and nothing happened, no error just nothing. I also tried Find the Culprit and it worked all the way through and thought the issue was a module that I added yesterday but I've had the issue longer.
Here is my long list of modules:
Active Modules
5e Encounter Builder v0.4.1
Active-Auras v0.7.5 Bugs URL
Active Token Effects v0.6.2 Bugs URL
Ammo Tracker v0.3.3
Anonymous v1.4.2 Bugs URL
Argon - Combat HUD v1.7.8
Autocomplete Whisper v1.0.5
Automatic Journal Icon Numbers vv1.9.0 Bugs URL
Auto-Rotate vv1.3.16 Bugs URL
Break Time v11.02 Bugs URL
Build-a-Bonus v11.2.2
Carousel Combat Tracker v2.5.1
Cautious Gamemaster's Pack v1.4.1
Character Actions List dnd5e v6.1.1 Bugs URL
Compact DnDBeyond 5e Character Sheet v2.3.3 Bugs URL
Chat Images v3.2
Chat Message Accessibility Indicators v1.0.0
Cleaner sheet title bar v1.5.1
Colored Folder Contents v2.0.1 Bugs URL
Combat Enhancements v1.2.2
Combat Estimate - How dead are we? v1.0.28
Combat Focus v1.4.2 Bugs URL
DDB-Importer: A D&D Beyond Integrator v3.4.63
DFreds Convenient Effects v5.1.0 Bugs URL
DFreds Droppables v3.0.1 Bugs URL
Dice So Nice! v4.6.8 Bugs URL
Dice So Nice - Weighted Companion Cube Dice Set v1.0.4
Entice with Dice so Nice v0.1.0
Fudge O' Plenty v1.0.0
Handyfon's Dice Addiction v1.1.0
Lordu's Custom Dice for Dice So Nice v0.39
Talis Dice v1.0.6
WikiRole for Dice So Nice v0.0.1
Dice Tray v1.5.3
dlopen v1.0
VuePort: Let the Light in! v1.1
The Forge: Compendium Library v1.3.4 Bugs URL
Basic Rules v0.3.24
DND5E Scriplets - 5E QOL bits and pieces v0.10.1
Drag Ruler v1.13.8 Bugs URL
Dynamic effects using Active Effects v11.0.11 Bugs URL
Midi QOL v<IP_ADDRESS> Bugs URL
Chris's Premades v0.5.65
Midi QOL - Challenge Mode Armor Display v1.0.4 Bugs URL
Midi SRD v11.0.0 Bugs URL
Boss Loot Interactive Magic Items, Free Pack v11.0.3 Bugs URL
EEEG-Importer v1.1.7
Effect Macro v11.0.1
Find the culprit v1.4.6 Bugs URL
Force Client Settings v2.3.2 Bugs URL
Foundry Community Macros v10.4 Bugs URL
Foundry Community Tables v11.0 Bugs URL
Foundry VTT Anniversary Dice Set by The Rollsmith v1.0.1 Bugs URL
FoundryVTT Arms Reach v2.2.14 Bugs URL
FoundryVTT Cards v1.3.0 Bugs URL
FXMaster v4.0.2 Bugs URL
Give item to another player v1.12.2 Bugs URL
GM Notes v8.8
GM Screen v4.0.4 Bugs URL
Health Estimate v31.4 Bugs URL
Hey, Wait! v0.7.5
Item Macro v1.9.0+1
Item Piles v2.7.10 Bugs URL
JB2A - Jules and Ben's Animated Assets - Free Content v0.6.0
JB2A - Patreon Complete Collection v0.4.6
Ace Library v1.8.3 Bugs URL
Chat Commander v2.0.1 Bugs URL
lib - Color Settings v2.9.1
libWrapper v<IP_ADDRESS> Bugs URL
socketlib v1.0.13 Bugs URL
Stream Utils v2.8.0
Link Item and Resource DnD5e v2.1.0 Bugs URL
Lock & Key v1.9.7 Bugs URL
LootsheetNPC5e v3.6.1
Magic Items v3.0.0
Forgotten Adventures Battlemaps v1.0.38
Mass Edit v1.44.8
Merchant Sheet NPC v2.9.1
Module Management+ v2.2.3 Bugs URL
Monk's Active Tile Triggers v11.06 Bugs URL
Monk's Chat Timer v11.01 Bugs URL
Monk's Combat Details v11.06 Bugs URL
Monk's Combat Marker v11.01 Bugs URL
Monk's Enhanced Journal v11.07 Bugs URL
Monk's Hotbar Expansion v10.1 Bugs URL
Monk's Little Details v11.05 Bugs URL
Monk's Player Settings v11.01 Bugs URL
Monk's Scene Navigation v11.02 Bugs URL
Monk's TokenBar v11.02 Bugs URL
Monk's Wall Enhancement v11.02 Bugs URL
Multiface Tiles v1.0.11
Navigation Name v0.1.03
Optional Rules for Dnd5e v0.5.2
Ownership Viewer v11.2 Bugs URL
Pin Cushion v1.9.1 Bugs URL
Pin Fixer v1.2.2 Bugs URL
Ping Logger v1.2.20 Bugs URL
Polyglot v2.1.6 Bugs URL
Pushable tokens v10.0.2
Quick Encounters v1.2.0 Bugs URL
Quick Insert - Search Widget v2.8.3 Bugs URL
Revealed Notes Manager v2.4.3
Revised Weapons & Equipment v1.3.0
Sane Magical Item Prices Compendium v0.7.1
Sequencer v3.1.4 Bugs URL
Automated Animations v4.2.66
Simbul's Athenaeum v1.0.5
Simbul's Cover Calculator v1.4.4
Simple Calendar v2.3.20 Bugs URL
About Time v11.0.1 Bugs URL
SmallTime v1.18.0 Bugs URL
Smart Doors v1.4.1 Bugs URL
Smart Target v1.0.1 Bugs URL
Stream View v2.0.1 Bugs URL
Tagger v1.4.5 Bugs URL
Template Macro v11.0.0
The Forge v1.10
TheRipper93's Module Hub v1.1
Tidy5e Sheet v0.9.18 Bugs URL
Times Up v11.0.3 Bugs URL
Token Attacher vv4.5.13
Token Factions vv0.4.8 Bugs URL
Tokenizer v4.2.5
Token Magic FX v<IP_ADDRESS>
Token Mold v2.20.3 Bugs URL
Token Variant Art v4.53.1 Bugs URL
Minimal UI v1.6.5
Remote Highlight UI v2.0.0 Bugs URL
Visual Active Effects v11.0.5
Walled Templates v0.6.6
Wall Height v5.0.3
Levels v4.2
Warp Gate v1.18.1
Window Controls v1.11.2
World Anvil Integration v1.4.4
World Anvil Integration - Actors v1.0.2
World Anvil Integration - Custom secrets v1.0.3

I am fairly certain, that the bug is caused by one of the modules somehow invalidating the way i access a tokens inventory. Could you try to paste this line: canvas.tokens.controlled.map(pToken => pToken.document)[0].actor.items in the console (F12) while having a token (with at least one item in its inventory) selected and posting the result of that? That would help me confirm my suspicion. I will look through the modules to see if i can identify the problem.

This is what I got.

I just tried to replicate the bug with almost all of these modules installed (some did not seem to be available on v11) but could not get it to work or rather not work. I would guess that there is some specific setting in one of the modules that causes lock and key to fail. The only solution i can think of would be you sending me your raw world file (without all the audio/image assets) so that i can have a closer look at the issue.

I just thought of another possible cause of this bug. Could try pasting this line: canvas.tokens.controlled.map(pToken => pToken.document)[0].actor.items.map(vitem => vitem.quantity) into the console, again while having a token selected, preferably one with only a key in the inventory?

I just thought of another possible cause of this bug. Could try pasting this line: canvas.tokens.controlled.map(pToken => pToken.document)[0].actor.items.map(vitem => vitem.quantity) into the console, again while having a token selected, preferably one with only a key in the inventory?

I'm having the same problem, and I've used the ID of the character's Thieves' Tools as well as the compendium IDs. I ran the command you asked about and got the following results:
(58) [undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined]

Thank you, thats helpful. Are you also using the D&D 5e system?

I am so sorry, i had a typo in the command. Could you try again with canvas.tokens.controlled.map(pToken => pToken.document)[0].actor.items.map(vitem => vitem.system.quantity)

I am so sorry, i had a typo in the command. Could you try again with canvas.tokens.controlled.map(pToken => pToken.document)[0].actor.items.map(vitem => vitem.system.quantity)

That gave me this response
(58) [1, 1, 1, 1, 1, 1, 6, 5, 1, 1, 1, 3, 1, 1, 1, 1, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined, undefined]

Thank you, thats helpful. Are you also using the D&D 5e system? Also which Foundry and which System version are you running?

Yes I'm using the D&D 5e system, and just recently updated to 2.4.0

Could you send me a screenshot of the tokens inventory?

Could you send me a screenshot of the tokens inventory?

Assuming you have the popup texts turned on (both in Lock & Key and in core Foundry), does the "No lock pick" text popup when you try to pick a lock? If so, could you enter this console.log({sID : canvas.tokens.controlled.map(pToken => pToken.document)[0].actor.items.find(vitem => vitem.name == "Thieves' Tools").flags.core?.sourceId, ID :  canvas.tokens.controlled.map(pToken => pToken.document)[0].actor.items.find(vitem => vitem.name == "Thieves' Tools").id, worldid : game.settings.get("LocknKey", "LockPickItem").split(";")}) into the console and send me the (uncollapsed) ouput

Assuming you have the popup texts turned on (both in Lock & Key and in core Foundry), does the "No lock pick" text popup when you try to pick a lock? If so, could you enter this console.log({sID : canvas.tokens.controlled.map(pToken => pToken.document)[0].actor.items.find(vitem => vitem.name == "Thieves' Tools").flags.core?.sourceId, ID : canvas.tokens.controlled.map(pToken => pToken.document)[0].actor.items.find(vitem => vitem.name == "Thieves' Tools").id, worldid : game.settings.get("LocknKey", "LockPickItem").split(";")}) into the console and send me the (uncollapsed) ouput

Here you go
{sID: undefined, ID: 'wEnSmJhip5sej512', worldid: Array(2)}
ID
:
"wEnSmJhip5sej512"
sID
:
undefined
worldid
:
(2) ['99NTJQbKtlSdFXc2', 'woWZ1sO5IUVGzo58']
[[Prototype]]
:
Object

Thank you, i see the problem now, how did you create the Thieves' Tools?

Thank you, i see the problem now, how did you create the Thieves' Tools?

I'm pretty sure I pulled it into the character's sheet from a compendium (either DnD5e SRD Content or D&D Beyond import).

It might be possible that it imported from D&D Beyond using DDB-Importer created by MrPrimate. I don't sync inventory anymore, but could that be why it's being wonky?

The problem is, that the source id (flags.core.sourceId) is set to unidentified, which prevents Lock & Key from finding the Thieves' Tools. I am currently looking for an alternative way of getting the source id.

The problem is, that the source id (flags.core.sourceId) is set to unidentified, which prevents Lock & Key from finding the Thieves' Tools. I am currently looking for an alternative way of getting the source id.

Okay, I figured out the Thieves' Tools I added to the character came from the DnDBeyond Compendium. I replaced it with the Thieves' Tools from the SRD Compendium and it works fine. So, might be something in the way DDB-Importer pulls in the Items that could be monkeying with it. I have a work-around for now, but if you figure out what's going wonky I can kick it over to MrPrimate in his Discord as a bug.

I have added improved DDB Importer compatibility with v2.0.9. You will hvae to add this id to the worlds lock picking item IDs:<PHONE_NUMBER>. I am not yet 100% certain, that the DDB id i use is the correct one, i will update this issue should i discover any problems.

I was wrong, sorry. The new v2.0.10 should now use the correct id. The id you will have to add to the world settings is 126

I will assume that this bug is solved via the updated id unless i hear back, and will close this issue soon.

I will assume that this bug is solved via the updated id unless i hear back, and will close this issue soon.

Thank you, I think it's fixed.


 Could you please give me some method on how to code it? I've been thinking for a few days but haven't found a way. Thank you so much.

I am thinking about 1 idea is that I will get the location of other vehicles, then calculate their location relative to the ego vehicle. Then I will check if they are within the field of view of the camera. But I still do not know how to check of they are within the field of view?

For those who are looking the same thing as me. You guys can find this code in carla/agents/tools/misc.py


Fixes JavaScript Deployment

r? @tcr
(tessel-highfive has picked a reviewer for you, use r? to override)

Changes Unknown when pulling 3f6eecda5b5d796227d7e78f799a9489c9af36fa on HipsterBrown:fix-test-js-deploy into ** on tessel:master**.

Closing in favor of https://github.com/tessel/t2-cli/pull/1259


How to disable tar'ing?

I'm backup up a single file to a local file system that's already compressed.  How do I disable tarring?

# using whenever
every 1.day do
  command "cp -af source_file dest_file"
end

# or, for a little rotation...
every 1.day do
  command "mv -f dest_file.001 dest_file.002"
  command "mv dest_file dest_file.001"
  command "cp -a source_file dest_file"
end

Sorry this a remote file (downloaded via http) copied locally.  Not local to local.  I want to use the backup gem and skip the tarring step.  In particular I'm doing this:
http://outofti.me/post/4159686269/backup-with-pgbackups
There's no reason to tar the file as it's a single file and it's already compressed.  I don't want to use a Syncer either because I want to follow the Storage procedure where it copies to a temp folder first (in case it fails).

Well, no doubt this looks like something that could added to Backup.
However, if that's the only file you're backing up and it's not going to be a part of a final tar'd package to be stored, then I would put that code in a separate script and call it from the cron job. Just copy the file where you want to store it after it's downloaded.

Thanks for the quick suggestions, greatly appreciated.  I may try to monkey patch Backup to handle my particular case.  I'd be missing the automatic archiving of the last N copies, built in error / message logging, cleanup of the tmp folder, and notifiers.  Stuff that's pretty easy to code but I was hoping just to flip a few config switches using Backup instead.


Cannot remove HockeyApp nor unlink HockeyApp

After migration to App Studio, I cannot delete the HockeyApp app in App Studio.

Hi @RZeff, are you referring to the ability to cut the side by side experience so you can complete your migration to App Center and discontinue use of HockeyApp? If so, that is an experience we are working on right now and will share details around in the near future.

We're currently working on a migration option for apps so they're exclusively available on App Center afterwards. Is that what you're looking for @RZeff ?
It's noted in our Roadmap

Yes, I have migrated from HockeyApp

@RZeff currently you can't migrate anything from HockeyApp to App Center yet. But we're working on that. If you have re-created things on App Center and want to get rid of the HockeyApp apps, you have to delete them on HockeyApp. However, we're offering to move apps very soon.

A first step to move apps from HockeyApp to App Center is described and tracked here https://github.com/Microsoft/appcenter/issues/230


Add combatant duplication

It would help with character creation if you could click on a "copy" button to duplicate the selected combatant

Completed


gdbus-codegen-glibmm: Use .inc and .bb file

Change to use both a .inc and a .bb file. This enables projects to use
more than one version of the tool.
Signed-off-by: Therese Nordqvist<EMAIL_ADDRESS>

split recipe into..?

Sounds better, yes. I was struggling to find a good way to express it.


User Request: Release Dynamic Targeting behind a feature flag in controller

Note: While chaos-controller is open to the public and we consider all suggestions for improvement, we prioritize feature development that is immediately applicable to chaos engineering initiatives within Datadog. We encourage users to contribute ideas to the repository directly in the form of pull requests!
Is your feature request related to a problem? Please describe.
After deploying controller version 7.2.0 which has dynamic targeting enabled by default, we observed that the controller enters into a restart loop (Back-off restart) while running experiments. (Error attached at the bottom). We were in controller version 6.1.0 and upgraded to 7.2.0. However when turning off dynamic targeting by adding statingTargeting: true in the defintion, the controller works as expected.
We are in the process of evaluating the dynamic targeting feature however as this feature is enabled by default in new versions there is a risk of teams running this without knowing the complete impact.
It would be great if dynamic targeting can be released under a config in controller so that we can block this until teams are confident and/or iron out issues we see in our cluster due to dynamic targeting. This also enables us to use the newer versions of controller while we sort dynamic targeting.
Describe the solution you'd like
Release dynamic targeting behind a feature flag. A configuration to enable/disable dynamic targeting in the configmap.yaml so we can disable/enable this feature from the controller side.
Describe alternatives you've considered
Open to any other ideas that would enable/disable dynamic targeting from controller
** Errors seeing when running experiments with dynamic targeting**
{"level":"info","ts":1660818040268.9556,"caller":"chaos-controller/main.go:267","message":"loading configuration file","config":"/etc/chaos-controller/config.yaml"}
I0818 10:20:41.321192       1 request.go:665] Waited for 1.031103301s due to client-side throttling, not priority and fairness, request: GET:https://<IP_ADDRESS>:443/apis/pkg.crossplane.io/v1?timeout=32s
{"level":"info","ts":1660818045975.2166,"caller":"eventbroadcaster/notifiersink.go:40","message":"notifier noop enabled"}
{"level":"info","ts":1660818045978.2427,"caller":"chaos-controller/main.go:424","message":"restarting chaos-controller"}
I0818 10:20:45.978442       1 leaderelection.go:248] attempting to acquire leader lease chaos-engineering-framework/75ec2fa4.datadoghq.com...
I0818 10:21:02.864515       1 leaderelection.go:258] successfully acquired lease chaos-engineering-framework/75ec2fa4.datadoghq.com
I0818 10:21:04.017267       1 request.go:665] Waited for 1.046628643s due to client-side throttling, not priority and fairness, request: GET:https://<IP_ADDRESS>:443/apis/athena.aws.crossplane.io/v1alpha1?timeout=32s
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x1444dba]

goroutine 691 [running]:
github.com/DataDog/chaos-controller/controllers.(*DisruptionReconciler).manageInstanceSelectorCache(0xc000824000, 0xc0004e0240)
	/go/src/github.com/gsQ9JVMR/0/DataDog/chaos-controller/controllers/cache_handler.go:514 +0x63a
github.com/DataDog/chaos-controller/controllers.(*DisruptionReconciler).Reconcile(0xc000824000, {0x1b730d8?, 0xc0010c1a70?}, {{{0xc000a4de60?, 0x1b?}, {0xc000a4de20?, 0x20?}}})
	/go/src/github.com/gsQ9JVMR/0/DataDog/chaos-controller/controllers/disruption_controller.go:124 +0x4c5
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Reconcile(0xc00082d040, {0x1b730d8, 0xc0010c19b0}, {{{0xc000a4de60?, 0x17c79c0?}, {0xc000a4de20?, 0xc000716d40?}}})
	/go/src/github.com/gsQ9JVMR/0/DataDog/chaos-controller/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:114 +0x222
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler(0xc00082d040, {0x1b73030, 0xc000698580}, {0x175aa00?, 0xc00064d940?})
	/go/src/github.com/gsQ9JVMR/0/DataDog/chaos-controller/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:311 +0x2e9
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem(0xc00082d040, {0x1b73030, 0xc000698580})
	/go/src/github.com/gsQ9JVMR/0/DataDog/chaos-controller/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:266 +0x1d9
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2()
	/go/src/github.com/gsQ9JVMR/0/DataDog/chaos-controller/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:227 +0x85
created by sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2
	/go/src/github.com/gsQ9JVMR/0/DataDog/chaos-controller/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:223 +0x309

Hi,
The bug was found, it seems an inconsistent call to a config pointer was at fault, which we've always set internally but you probably (and rightfully !) didn't.
Here's the bugfix PR, the release should come in shortly.
We're discussing the flag possibility internally and will get back to you on that.

Amazing, thanks for the prompt feedback @nathantournant! Once the bugfix is merged we will look to validate this in our environment.

This

Hi @baluishere has left the project working on this, reviewing this ticket and the latest version of the controller i can say this the issue here is no longer a problem and happy this can be closed from our side. Thanks


Delete cntk_g2p.yaml from marketplace for it always failed;

Coverage remained the same at 51.632% when pulling 4f036a81446c8219a1e0f073df08c9acdd42bc4d on yanli-dev into 762d07c53d28e0013dd1afffb91fb5bbd7a1038e on master.


The superclass "javax.servlet.http.HttpServlet" was not found on the Java Build Path

1.create gradle project (in workspace or stand-alone) in IDE or import gradle project into IDE
2.then go to jsp file
on the first line it will show:
The superclass "javax.servlet.http.HttpServlet" was not found on the Java Build Path

I think it is because the lack of  the dependency of javax.servlet:servlet-api:2.5


[Question] From center possible?

Is it possible by any means to get a "from center" measuring bar, configuration or css?
I mean having the 0 on the center and -1000 at the left and 1000 at the right.
For displaying import-export grid or battery power, like in this mockup:

Hi.
This would be great if supported.
I've made it worked through css tweaking, but it's ugly.
Below my scenario where the 4th and 5th bars/entities go from -X <--> 0 <--> X
type: custom:bar-card
entities:
  - entity: sensor.battery_state_of_capacity
    name: Battery Charge
    [...]
  - entity: sensor.current_house_power
    name: Usage
    [...]
  - entity: sensor.input_power
    name: Production
    [...]
  - entity: sensor.charge_discharge_power
    icon: mdi:battery-charging
    name: Bateria Usage
    color: green
    min: -2500
    max: 2500
    positions:
      indicator: 'off'
      name: 'off'
      value: outside
    severity:
      - from: -2500
        to: 0
        color: orangered
      - from: 1
        to: 2500
        color: lime
  - entity: sensor.grid_active_power
    name: Grid
    icon: mdi:transmission-tower-import
    min: -3500
    max: 3500
    positions:
      indicator: 'off'
      name: 'off'
      value: outside
    severity:
      - from: -9999
        to: 0
        color: orangered
        icon: mdi:transmission-tower-export
      - from: 1
        to: 9999
        color: Plum
direction: right
height: 0.8rem
stack: vertical
style: >
  bar-card-row:nth-child(4) bar-card-backgroundbar,
  bar-card-row:nth-child(5) bar-card-backgroundbar {
    background: linear-gradient(
      to right,
      var(--bar-color) 50%,
      transparent 50%
    );
  }
  bar-card-row:nth-child(4) bar-card-currentbar,
  bar-card-row:nth-child(5) bar-card-currentbar {
    background: linear-gradient(
      to right,
      var(--primary-background-color) min(50%, var(--bar-percent)),
      var(--bar-color) min(50%, var(--bar-percent)),
      var(--bar-color) var(--bar-percent),
      transparent var(--bar-percent)
    )
  }

Yes please to this feature.
I have thought of a few ideas to solve this but a centre config would be simplest (from user pov).
OR a config for the target colour (unless I have missed this)
Se this post if it helps.
Thanks - the bar card is very useful.

Hi.
This would be great if supported. I've made it worked through css tweaking, but it's ugly.
Below my scenario where the 4th and 5th bars/entities go from -X <--> 0 <--> X

I've modified it a little bit, to not have a black background, but the default bar background.
For this, just remove bar-card-backgroundbar and modify bar-card-currentbar
Here is a minimal example:
type: custom:bar-card
entities:
  - entity: sensor.niro_torque_power
    name: Power
    unit_of_measurement: ' '
    color: SlateGrey
    min: -150
    max: 150
    decimal: 1
    severity:
      - color: var(--label-badge-green)
        from: -200
        to: -1
      - color: var(--label-badge-yellow)
        from: 1
        to: 200
target: 1
direction: right
positions:
  icon: 'off'
  indicator: 'off'
  name: inside
card_mod:
  style: |-
    bar-card-card {
      border: 1px solid DarkSlateGray;
      border-radius: var(--ha-card-border-radius);
    }

    bar-card-currentbar{
      background: linear-gradient(
        to var(--bar-direction),
        var(--bar-background-color) min(50%, var(--bar-percent)),
        var(--bar-color) min(50%, var(--bar-percent)),
        var(--bar-color) var(--bar-percent),
        transparent var(--bar-percent)
      )
    }

Examples with dark and light skin: