Fix Search* tests 404 vs empty list behavior

Issues that I've found:

ReadGroupSetsSearchIT.readGroupSetsNonexistentNameShouldSayNotFound

Should expect an empty list

ReadGroupSetsGetByNameIT.testSearchForBogusNameFails (this appears to test duplicate functionality at the above test?)

Should expect an empty list

ReadGroupSetsSearchIT.readgroupSetResponseForNonexistentDatasetIdShouldReturnEmptyList()

Should expect a 404, since the dataset does not exist. This is not freeform criteria - this is a container object.

Some of these points perhaps should be clarified in the spec, but the compliance test is either being more specific than the spec, or is in conflict with the spec on this point.

Agreed with @calbach on these examples.

The spec is unfortunately silent on this, and the current behavior is based on my (possible mis-)interpretation of an earlier email discussion of this topic.
I'm happy to test for either behavior, but until the spec codifies this, we run the risk of having any fix done now magically turn into a regression later.
As such, I will assign myself the task of updating the schema docs (since this will include HTTP status code, which are external to the schemas, maybe "API docs" is more correct).  The doc updates should get checked in first; the updated tests can follow.


HIVE-28578: Fix concurrency issue in ObjectStore#updateTableColumnStatistics

What changes were proposed in this pull request?
There can be a concurrency issue and persisting table parameters can have duplicate key error when replication wants to store table column statistics and the table have statistics for multiple engines. In this change, in a parallel process already saved those, we retry it so that, DataNucleus will try to do update instead of insert.
Why are the changes needed?
To avoid duplicate key errors.
Does this PR introduce any user-facing change?
No
Is the change a dependency upgrade?
No
How was this patch tested?
Repro and test process is described in the ticket: https://issues.apache.org/jira/browse/HIVE-28578?focusedCommentId=17901761&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17901761
Tested manually, on a cluster.

I am not sure I get this. There is already a table-level lock for atomic stats update and we are adding an extra re-try loop inside?

I am not sure I get this. There is already a table-level lock for atomic stats update and we are adding an extra re-try loop inside?

The existing table-level lock is an in-memory lock. That means in case you have multiple HMS instances and two different processes are getting requests in the same time, it just doesn't have any effect - as on JVM level, there is only one single instance.

I am not sure I get this. There is already a table-level lock for atomic stats update and we are adding an extra re-try loop inside?

The existing table-level lock is an in-memory lock. That means in case you have multiple HMS instances and two different processes are getting requests in the same time, it just doesn't have any effect - as on JVM level, there is only one single instance.

ok, in-memory lock serves diff purpose - thread safety, see HIVE-25904.
Descriptions says "updateTableColumnStatistics can throw SQLIntegrityConstraintViolationException during replication if HA is on and two different HMS instance gets the same call but with different engine. "
isn't the engine part of PK? RawStore interface. methods are not retriable

I am not sure I get this. There is already a table-level lock for atomic stats update and we are adding an extra re-try loop inside?

The existing table-level lock is an in-memory lock. That means in case you have multiple HMS instances and two different processes are getting requests in the same time, it just doesn't have any effect - as on JVM level, there is only one single instance.

ok, in-memory lock serves diff purpose - thread safety, see HIVE-25904.
Descriptions says "updateTableColumnStatistics can throw SQLIntegrityConstraintViolationException during replication if HA is on and two different HMS instance gets the same call but with different engine. " isn't the engine part of PK? If not, maybe it should be..
Some of RawStore interface methods are not retriable by design, so I would expect others to be retriable without the need for extra hacks, simply use RetryingMetaStoreClient.
public interface RawStore extends Configurable {
  /***
   * Annotation to skip retries
   */
  @Target(value = ElementType.METHOD)
  @Retention(value = RetentionPolicy.RUNTIME)
  @interface CanNotRetry {
  }

Descriptions says "updateTableColumnStatistics can throw SQLIntegrityConstraintViolationException during replication if HA is on and two different HMS instance gets the same call but with different engine. " isn't the engine part of PK? If not, maybe it should be..

It is trickier than this. Most of the statistics are stored in TAB_COL_STATS and it does have an engine field. But we have at least one statistics that is stored in TABLE_PARAMS. I really don't know the reason, but even the code says it shouldn't be in that way. See that comment from 2018:
      // TODO: (HIVE-20109) ideally the col stats stats should be in colstats, not in the table!

I assume that TODO never happened.
And TABLE_PARAMS is just a key-value list. For example, at the customer that faced with the problem, the duplicate entry is COLUMN_STATS_ACCURATE. I really don't know what is the reason why this property is in TABLE_PARAMS, not TAB_COL_STATS. And I also have no information about how many other fields can be in the same situation.

Some of RawStore interface methods are not retriable by design, so I would expect others to be retriable without the need for extra hacks, simply use RetryingMetaStoreClient.
Let me check what that exactly does and if it is possible to apply at the customer.
TBH, I'm not completely sure if retry is a proper expression about the current change: You can imagine, if, for example, we could cover the situation with a simple SQL script, it could be an upsert merge statement: insert if it doesn't exist. Update if it does. But DataNucleus is an ORM tool that cannot do such a thing. But if we force it to query the table state again, at the second attempt it will recognise that ups, we have records. So we should do an update instead of an insert.
Do you know better way to do an insert or update statement, using DataNucleus?

Hi @deniskuzZ ,
Could you please explain the reason why you consider a wrong idea to try an insert if an update didn't succeed due to a concurrency issue?
TBH, I'm not sure if using the Retrying handler for all the metastore client calls is an approach that worth to use just because we have this one and only rare edge case.
And I also consider it the problem of using an ORM tool that cannot properly handle such a trivial case. It could be handled with a simple merge statement, using plain SQL.


Delete highcharts-solide-gauge.js

#12

Need to remove the file reference in package.js.

Close this?


[Bug]: Compilation issue on Android

Package Version
4.1.1
Flutter Version
3.19.6
Platforms
Android
How to reproduce?
Run the app on android
Logs (optional)
Launching lib/main.dart on sdk gphone64 arm64 in debug mode...
../../../.pub-cache/hosted/pub.dev/pro_image_editor-4.1.1/lib/utils/content_recorder.dart/content_recorder_controller.dart:409:9: Error: No named parameter with the name 'logicalConstraints'.
        logicalConstraints: BoxConstraints(
        ^^^^^^^^^^^^^^^^^^
../../../Downloads/flutter/packages/flutter/lib/src/rendering/view.dart:23:9: Context: Found this candidate, but the arguments don't match.
  const ViewConfiguration({
        ^^^^^^^^^^^^^^^^^
Target kernel_snapshot failed: Exception

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':app:compileFlutterBuildDevDebug'.
> Process 'command '/Users/abhishek/Downloads/flutter/bin/flutter'' finished with non-zero exit value 1

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 12s
Error: Gradle task assembleDebug failed with exit code 1

Exited (1).

Example code (optional)
No response
Device Model (optional)
Android emulator(android 14)

Thank you for your feedback. This issue appears to be a duplicate of issue #117. To keep the discussion centralized, I'll close this one.


Opening in non default browser

I have few browsers installed:
Firefox
Firefox Developer Edition
Firefox Nightly
Google Chrome
Google Chrome Dev
Firefox is my default browser, but for dev I would prefer use Firefox Developer Edition or Google Chrome Dev, but I don't know what I should put instead of "default", I tried few things like:
"browser": "firefox",
"browser": "firefox dev",
"browser": "firefox-dev",
"browser": "firefox developer",
"browser": "firefox-developer",
"browser": "mozilla-firefox-developer",
Even "google-chrome" doesn't work. I always have "Windows cannot find 'xxxxxxxxxxx'. Make sure you've typed the name correctly, then try again." So how can I open live server in non default browser?

I think if you specify the full path to the executable, that should work. I haven't done extensive testing on Windows.

Ok, thanks. Full path works, but I had to use double backslash to escape space, otherwise I had this error: "Error trying to parse settings: Invalid escape in Packages\User\Live-Server.sublime-settings:5:12". My settings:
// Live Server Settings
{
"node_executable_path": "C:/Program Files/nodejs/node.exe",
"global_node_modules_path": "C:/Users/erper/AppData/Roaming/npm/node_modules",
"browser": "C:\\Program Files\\Firefox Developer Edition\\firefox.exe",
}


Remove unused 1click service entries

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

https://github.com/awsdocs/aws-doc-sdk-examples/actions/runs/12432803436/job/34713006079?pr=7171


[TESTING ONLY] [DO] [NOT] [MERGE]

Merged build triggered.

Merged build started.

Test build #31199 has started for   PR 5765 at commit 8d40167.

Test build #31199 has finished for   PR 5765 at commit 8d40167.

This patch fails Scala style tests.

This patch merges cleanly.

This patch adds the following public classes (experimental):

  *   class SomethingNotSerializable

      logDebug(s" + cloning the object $obj of class $

This patch does not change any dependencies.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31199/
Test FAILed.

Merged build triggered.

Merged build started.

Test build #31201 has started for   PR 5765 at commit 8431865.

Test build #31201 has finished for   PR 5765 at commit 8431865.

This patch fails Spark unit tests.

This patch merges cleanly.

This patch adds the following public classes (experimental):

  *   class SomethingNotSerializable

      logDebug(s" + cloning the object $obj of class $

This patch does not change any dependencies.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31201/
Test FAILed.

Merged build finished. Test FAILed.

Thanks. I've merged this in branch-2.0.

No!!

Merged build triggered.

Merged build started.

Test build #31221 has started for   PR 5765 at commit cea6769.

Test build #31221 has finished for   PR 5765 at commit cea6769.

This patch fails Scala style tests.

This patch merges cleanly.

This patch adds the following public classes (experimental):

  *   class SomethingNotSerializable

      logDebug(s" + cloning the object $obj of class $

This patch does not change any dependencies.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31221/
Test FAILed.

retest this please

Merged build triggered.

Merged build started.

Test build #31222 has started for   PR 5765 at commit 3598d3d.

retest this please

Merged build triggered.

Merged build started.

Test build #31222 has finished for   PR 5765 at commit 3598d3d.

This patch fails Spark unit tests.

This patch merges cleanly.

This patch adds the following public classes (experimental):

  *   class SomethingNotSerializable

      logDebug(s" + cloning the object $obj of class $

This patch does not change any dependencies.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31222/
Test FAILed.

Merged build finished. Test FAILed.

Test build #31235 has started for   PR 5765 at commit 3598d3d.

Test build #31235 has finished for   PR 5765 at commit 3598d3d.

This patch fails MiMa tests.

This patch merges cleanly.

This patch adds the following public classes (experimental):

  *   class SomethingNotSerializable

      logDebug(s" + cloning the object $obj of class $

This patch does not change any dependencies.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31235/
Test FAILed.

retest this please??

Merged build triggered.

Merged build started.

Test build #31239 has started for   PR 5765 at commit 3598d3d.

Test build #31239 has finished for   PR 5765 at commit 3598d3d.

This patch fails PySpark unit tests.

This patch merges cleanly.

This patch adds the following public classes (experimental):

  *   class SomethingNotSerializable

      logDebug(s" + cloning the object $obj of class $

This patch does not change any dependencies.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31239/
Test FAILed.


[CS] No trait except for abstract class autowire with Symfony require Rule for PHPStan

is it skipped for class that extends Symfony\Component\HttpKernel\Kernel, that consume MicroKernelTrait ?, eg:
use Symfony\Bundle\FrameworkBundle\Kernel\MicroKernelTrait;
use Symfony\Component\HttpKernel\Kernel;

final class MicroKernelTraitKernel extends Kernel
{
    use MicroKernelTrait;
}

Yes, this should be allowed. Ideally in some configurable list, as there will be more of these cases

I've created PR https://github.com/symplify/symplify/pull/2229 for it

Thanks :+1:
Btw, no need to link PR in an issue, as "Fixes #2172" in the PR links it


Missing license

Hi,
it looks like you are missing the license in the project config file.
https://www.versioneye.com/Clojure/stylefruits:gniazdo/1.0.0
Thanks

Sorry i see now that you have it in the README. I "suggested" a license on versioneye since it's used by our systems to check packages integrity. Closing this issue.

Just FYI, I added a LICENSE to both the project.clj and the repository:
4be9d7b3d62c528a62251ddf7e654b0f94483979


Possible to indent between headings

Really appreciate this tool - I'm curious if there's an ability (might not be thinking creatively enough) to indent extracted annotations between underlined headings.

The addon doesn't do this, although I appreciate it would be useful. The challenge is the number of edge cases -- not everyone uses underline to denote a heading, etc etc. I agree thought it would be worth having as something that can be enabled optionally. I'll think about how it might be achieved.

Makes sense - thanks for the thought!

The problem here (which I'm running into myself quite frequently) is that it requires you to underline every heading under which you add a highlight or annotation, otherwise you end up with indented highlights/annotations that don't belong to the supposed parent heading. This might be counterproductive in terms of clarity of the structure of the notes -- highlights will appear to be related to headings (by indentation) which they are not actually related to within the source document.
I'm not sure how to get round this reliably 🤔

Yep - working with on a paper now that has some sub-headings where I don't have anything written. Not sure there's an easy / worthwhile solution


Fixed Link bug

This adds rule to override default link behavior
Fixes #1782
Screenshot :
Light Mode

Dark Mode

Consistent color is maintained in both modes

This seems to have the same intent as #1783

Ended up taking #1783 .  Thanks anyway!


OSD-22358 trigger rebuild

What type of PR is this?
cleanup
What this PR does / Why we need it?
Tweak a small thing to trigger an image rebuild
Which Jira/Github issue(s) does this PR fix?
OSD-22358
Special notes for your reviewer
Pre-checks (if applicable)

[ ] Validated the changes in a cluster
[ ] Included documentation changes with PR

/lgtm
/approve


Ci automation test

Automated tag creation on new version of actions/runner

@killmeplz Thank you, let's try like this


CLASS_INDEX_PATH should take URL instead of relative path

Issue
https://github.com/PracticalDL/Practical-Deep-Learning-Book/blob/master/code/chapter-2/visualization.py
Run the following command to run the program:
python visualization.py --process image --path ../../sample-images/dog.jpg
The program will fail if you are running this locally (not on Colab) for the first time:
data_utils.py", line 251, in get_file
    urlretrieve(origin, fpath, dl_progress)
  File "/usr/lib/python3.7/urllib/request.py", line 247, in urlretrieve
    with contextlib.closing(urlopen(url, data)) as fp:
  File "/usr/lib/python3.7/urllib/request.py", line 222, in urlopen
    return opener.open(url, data, timeout)
  File "/usr/lib/python3.7/urllib/request.py", line 510, in open
    req = Request(fullurl, data)
  File "/usr/lib/python3.7/urllib/request.py", line 328, in __init__
    self.full_url = url
  File "/usr/lib/python3.7/urllib/request.py", line 354, in full_url
    self._parse()
  File "/usr/lib/python3.7/urllib/request.py", line 383, in _parse
    raise ValueError("unknown url type: %r" % self.full_url)
ValueError: unknown url type: '../imagenet_class_index.json'

Code
https://github.com/PracticalDL/Practical-Deep-Learning-Book/blob/master/code/chapter-2/visualization.py
CLASS_INDEX_PATH = '../imagenet_class_index.json'
...
 if CLASS_INDEX is None:
        fpath = get_file('imagenet_class_index.json',
                         CLASS_INDEX_PATH, cache_subdir='models')
        CLASS_INDEX = json.load(open(fpath))

Issue
TensorFlow's get_file() API lists the second parameter as URL not as relative path: https://github.com/tensorflow/tensorflow/blob/master/tensorflow/python/keras/utils/data_utils.py#L164
Under the hood, it uses following code:
try:
        urlretrieve(origin, fpath, dl_progress)
      except HTTPError as e:
        raise Exception(error_msg.format(origin, e.code, e.msg))

The following one-liner will fix the issue:
CLASS_INDEX_PATH = 'https://s3.amazonaws.com/deep-learning-models/image-models/imagenet_class_index.json'
Note

If someone runs this example once using the one-liner fix, the current code as is would work because it uses cached data imagenet_class_index.json. Probably that is how the bug snuck in.

Easy fix, but I could not make pull request due to permission. You can technically enable PR by protecting your branch. This way any merge will be blocked until code owners approve the PR. This will help you to keep the code up-to-date by leveraging external PR. Just food for thought.

Thank you for your detailed message, Gan. It does sound like an oversight on my end. I've changed the master branch protection rule, so can you now try to create a pull request? If it doesn't work, I'll be happy to do the fix.

Sure. I will make a PR. Thanks @meherkasam.


WIP: Testing communication resilience

This PR introduces a bash script that emulates cutting a network connection of one or several FL actors.
All the actors run in docker containers and are connected to a docker network, disconnection may be triggered by certain log output in a container's stdout.
There are several experiments, that may be conducted to test Collaborator's tolerance to network breakage:
A. cut it off when it is CPU bound, performing some calculations
B. cut it off when it is waiting for an Aggregators response
C. cut it off when it is sending a message
D. cut it off when it is receiving a message
Luckily, Collaborator's gRPC client features exactly 3 RPCs: get_tasks, get_aggregated_tensor, and send_local_task_results.
There is a peculiarity regarding Collaborator's gRPC client implementation: fetching an aggregated model from the collaborator happens on a tensor per tensor basis while a local model is sent in one piece, in a stream. Therefore it would be easier to catch A collaborator sending data than receiving.
How to use:

You need a clean supported Python virtual environment + upgraded pip + openfl installed.
Source the script itself with desired parameters, it will create all the required artifacts.
test-federation will contain logs for all the actors you can analyze.

Please note that our tests still require a lot of intervention to the script, thus treat it as just a base layer.
The script accepts the following parameters:

STAGE- integer. 1 - Start by building the base image; 2 - Start by creating a new workspace and dockerizing it;  3 - Certify federation, choose any number of collaborators; 4 - Run the existing image
NUMBER_OF_COLS - integer. You can start as many collaborators as you want, but the script will disconnect only the last one!
RECONNECTION_TIMEOUT - integer, seconds. Timeout to connect the last collaborator back to the network.
MAXIMUM_DISCONNECTIONS - integer. In case you want to limit the number of disconnections throughout the experiment.
CUT_ON_LOG - string. A pattern in logs that will trigger disconnections. In the script, wildcards are used to detect the pattern.
TEMPLATE - string. OpenFL template to use.

Returning back to the experiments.
A: cut it off when it is CPU bound, performing some calculations.
We can use the Run 0 epoch of N round log message in the keras_cnn_mnist experiment to trigger disconnection while the collaborator does computations with the command:
bash tests/github/docker_disconnecting_test.sh 1 2 20 1 "Run 0 epoch of 1 round"
It will disconnect the second collaborator when training for the first round starts. 20 seconds of disconnection is enough in this case. The collaborator will be affected once it tries to send the task results. It recovers, seemingly thanks to #465, that resends task results if we get grpc.StatusCode.UNKNOWN error code on the client side. Logs are attached
A_aggregator.log
A_collaborator1.log
A_collaborator2.log
B: cut it off when it is waiting for an Aggregators response
C: cut it off when it is sending a message.
We can use  send_local_task_results RPC to drop the connection while sending task results.
Here is the exact command that I used. "Setting stream chunks with size 10" is a debug message inside the RPC, 10 is a number specific to the default keras_cnn_mnist experiment.
bash tests/github/docker_disconnecting_test.sh 4 2 20 2 "Setting stream chunks with size 10"
Logs are attached, TLDR: the disconnected collaborator never recovers after reconnection.
C_aggregator.log
C_collaborator1.log
C_collaborator2.log

@igor-davidyuk this is functional in its current state, correct? Can we merge this for the 1.5 release and continue to make improvements later?

@igor-davidyuk can you please resolve the conflicts and request for review again?


best_path is better than beam_search in my experiments，is there something wrong with my network？

Hi,
I use cnn + lstm + ctc in my license plate recognition system。And I use your python scripts to test the precision of "best path decoding" and "beam search decoding"。The result is "best path" got 92.3% while "beam search" got 91.7%。In my experiments, time step equals to 21，and the total num of labels equals to 77。
Could you give me some advice?
Thanks a lot!

did you call beam search without language model (which I would suggest, i.e. lm=None)?
If you have a neural network output for which best path performs better than beam search, you can provide it here and I can have a short look into it. Provide the relevant information: mat, classes, and beamWidth. And the expected output, of course. You can dump the matrix mat with np.save() function.

closing because of inactivity


py_trees_ros_interfaces: 2.0.3-2 in 'humble/distribution.yaml' [bloom]

Increasing version of package(s) in repository py_trees_ros_interfaces to 2.0.3-2:

upstream repository: https://github.com/splintered-reality/py_trees_ros_interfaces.git
release repository: https://github.com/stonier/py_trees_ros_interfaces-release.git
distro file: humble/distribution.yaml
bloom version: 0.11.2
previous version for package: null

Closing, I'll shift it to the gbp release repo.


Support override with prepended modules at runtime

Problem
The sorbet runtime does not support overriding methods from prepended modules (link). I think there's at least one very common use case for this that doesn't violate any type safety; which is to wrap methods. I would think a common use case of this is when instrumenting / tracing methods.
Assume we have some module like this
module MyTracer
  def instrument(name)
    proxy = Module.new

    proxy.define_method(name) do |*args|
      # Tracing code goes here
      puts "pre-call #{name}"
      super(*args)
      puts "post-call #{name}"
    end

    prepend proxy
  end
end

And then we have an interface where an implementation also wants to instrument the method like this:
module MyInterface
  extend T::Sig
  extend T::Helpers
  interface!

  sig {abstract.returns(String)}
  def foo; end
end

class MyClass
  extend T::Sig
  extend MyTracer
  include MyInterface

  instrument :foo

  sig {override.returns(String)}
  def foo
    puts 'override called'
    'foo'
  end
end

MyClass.new.foo

If you run this, you get the error that is linked above (with the "we don't support this" message). If you comment out the sig with the override it runs fine.
pre-call foo
override called
post-call foo

It isn't clear to me what this sig is trying to do at runtime, and why it can't support prepend. Seems like maybe its trying to, ironically, wrap the method to verify it actually overrides a method. It just takes a different approach that doesn't support prepend... (edit: see second post, has nothing to do with override)
Proposed solution(s)
I still don't claim to fully understand the problem, but if I'm reading this comment correctly...
        # If we get here, that means the method we're trying to replace exists on a *prepended*
        # mixin, which means in order to supersede it, we'd need to create a method on a new
        # module that we'd prepend before `ancestor`. The problem with that approach is there'd
        # be no way to remove that new module after prepending it, so we'd be left with these
        # empty anonymous modules in the ancestor chain after calling `restore`.
        #
        # That's not necessarily a deal breaker, but for now, we're keeping it as unsupported.

Then either:

It "isn't a deal breaker", so just do it.
Maybe modify the implementation of ReplacedMethod to throw if restore is called in this case. So replacing is supported, just not restoring.
It doesn't appear that restore is called anyway (this util stuff was copied from elsewhere), so maybe just remove that method, and this comment, and allow supporting this? If this would make restore ugly, but restore is never used... does it matter?

Oh, you don't even need the interface to reproduce, so it has nothing to do with override. My mistake!
# typed: strict

require 'sorbet-runtime'

module MyTracer
  def instrument(name)
    proxy = Module.new

    proxy.define_method(name) do |*args|
      # Tracing code goes here
      puts "pre-call #{name}"
      super(*args)
      puts "post-call #{name}"
    end

    prepend proxy
  end
end

class MyClass
  extend T::Sig
  extend MyTracer

  instrument :foo

  sig {returns(String)}
  def foo
    puts 'override called'
    'foo'
  end
end

MyClass.new.foo

Bumping this issue!
We have the exact use case and it's kind of pity that we already can't use the prepended modules.
Can you folks please reconsider it and add this feature given that it's outlined as non deal breaker?

:+1:

Is there a way around this issue? checked(:never) doesnt seem to help either :/

We also have this exact use case and it would be great to have this added as a feature.

One workaround for this is to prepend modules after running sig, in your case:
class MyClass
  extend T::Sig
  extend MyTracer

  sig {returns(String)}
  def foo
    puts 'override called'
    'foo'
  end

  instrument :foo # <--- wrap `#foo` after defining it
end

From what I can tell, the ClassUtils#replace_method iterates through the ancestors of the mod whose method is being replaced. If it finds the mod first (which will be the first ancestor for any module that hasn't been prepended) then it continues on its merry way. If it gets to the "original owner" first, which in the case of a module with prepended overrides will be any of those prepends with the method defined, then it raises the error.
In the following graphic, it would find PrependB#bar first and raise an error:

The reason it raises the error is that in order to "supersede" that prepended method it would need to create another anonymous prepend that could be left empty if the original method got restored. This makes sense.
However, I wonder if we really need to supersede the prepended module definition at all in this case? Instead, could we not simply replace the method MyClass#bar and not worry about type checking the prepended module's matching methods? Prepended methods are almost always decorators, and in my experience it's acceptable if they don't have type safety as they are usually written in quite a generic fashion anyway.
This way we wouldn't need to worry about any orphaned empty modules. The downside is that from the caller's perspective, a method with a prepended override might not be getting runtime type checked at all if the prepend never calls super.
I think that downside is an acceptable trade for decorators that work like Ruby developers expect them to. If the prepended method has its own sig block then there is no problem anyway. If it calls super then both its sig and MyClass's sig will have runtime validation (I think).
Does this make sense? Am I missing something? If not, I'd be happy to try throwing together a PR for this change.


"error": "partial write: unable to parse 'yla1,host=server01,region=us-west httpsRequests=100i\r': invalid number\nunable to parse

Problem Statement:
I am trying post multiple data into influx db and I am getting the partial write error. Please refer the screen shot attached.
Data using to post :
yla1,host=server01,region=us-west httpsRequests=100i
yla1,host=server01,region=us-west bodySize=7528i
yla1,host=server01,region=us-west contentLength=7528i
yla1,host=server01,region=us-west httpTrafficCompleted=754i
yla1,host=server01,region=us-west timeToFirstByte=752i
yla1,host=server01,region=us-west timeToLastByte=755i
yla1,host=server01,region=us-west htmlCount=1i
Error Details:
{
"error": "partial write: unable to parse 'yla1,host=server01,region=us-west httpsRequests=100i\r': invalid number\nunable to parse 'yla1,host=server01,region=us-west bodySize=7528i\r': invalid number\nunable to parse 'yla1,host=server01,region=us-west contentLength=7528i\r': invalid number\nunable to parse 'yla1,host=server01,region=us-west httpTrafficCompleted=754i\r': invalid number\nunable to parse 'yla1,host=server01,region=us-west timeToFirstByte=752i\r': invalid number\nunable to parse 'yla1,host=server01,region=us-west timeToLastByte=755i\r': invalid number dropped=0"
}

I am sure this is not a bug, must be doing something wrong. ^ any thoughts on this

It looks like your writes are not valid line protocol.  I think windows uses \r\n to separate lines, but line protocol requires only \n.  Switching \r\n to \n should resolve this for you.

@jwilder thank you, let me try

@jwilder I tried with both I am getting the same error,
yla2,host=server01,region=us-west httpsRequests=100i \r\n
yla2,host=server01,region=us-west bodySize=7528i \r\n
yla2,host=server01,region=us-west contentLength=7528i \r\n
yla2,host=server01,region=us-west httpTrafficCompleted=754i \r\n
yla2,host=server01,region=us-west timeToFirstByte=752i \r\n
yla2,host=server01,region=us-west timeToLastByte=755i \r\n
yla2,host=server01,region=us-west htmlCount=1i \r\n
also tried with
yla1,host=server01,region=us-west httpsRequests=100i\n
yla1,host=server01,region=us-west bodySize=7528i\n
yla1,host=server01,region=us-west contentLength=7528i\n
yla1,host=server01,region=us-west httpTrafficCompleted=754i\n
yla1,host=server01,region=us-west timeToFirstByte=752i\n
yla1,host=server01,region=us-west timeToLastByte=755i\n
yla1,host=server01,region=us-west htmlCount=1i\n
I am getting the same error. Any thought on this ? Please check the output,
{
"error": "unable to parse 'yla2,host=server01,region=us-west httpsRequests=100i \r\n\r': bad timestamp\nunable to parse 'yla2,host=server01,region=us-west bodySize=7528i \r\n\r': bad timestamp\nunable to parse 'yla2,host=server01,region=us-west contentLength=7528i \r\n\r': bad timestamp\nunable to parse 'yla2,host=server01,region=us-west httpTrafficCompleted=754i \r\n\r': bad timestamp\nunable to parse 'yla2,host=server01,region=us-west timeToFirstByte=752i \r\n\r': bad timestamp\nunable to parse 'yla2,host=server01,region=us-west timeToLastByte=755i \r\n\r': bad timestamp\nunable to parse 'yla2,host=server01,region=us-west htmlCount=1i \r\n': bad timestamp"
}

@JyotiPrakashMallick The output shows that you're still sending the \rcharacter.  Each line needs to end with only \n.

@jwilder I tried all the possibility and I am getting the same error, please check the screenshot attached.

anything I am doing wrong ?

if you use import by txt file you can check the file line ending is LF/CRLF/CR by vscode;

anything I am doing wrong ?

I got same error.

anything I am doing wrong ?

I got same error.

@mananpatel1 I fix the above by writing a small script, could please help me whether you are trying manually or from some code ?

@mananpatel1 I fix the above by writing a small script, could please help me whether you are trying manually or from some code ?

@mananpatel1 I fix the above by writing a small script, could please help me whether you are trying manually or from some code ?

I write some data in csv file then trying to upload that csv file on CLI , and I got same error which you were got.

@mananpatel1 I fix the above by writing a small script, could please help me whether you are trying manually or from some code ?

I write some data in csv file then trying to upload that csv file on CLI , and I got same error which you were got.


RBAC for web based terminal

Is your feature request related to a problem? Please describe.
ArgoCD 2.4 supports a web based terminal, but it requires manual tweaks to the argocd-server Role and a setting enabled in argocd-cm ConfigMap.
Describe the solution you'd like
An option in the ArgoCD CRD to enable the web based terminal, which automatically sets up the above

i want to work on this @iam-veeramalla can you please assign this to me ?


missing word in string

during the localization phase a user has found there was a missing word in this sentence - proposing fix

Thanks!


Remote-Containers python:3.7-alpine fails with Couldn't start client Python Tools

Environment data

VS Code version: 1.44.1
Extension version (available under the Extensions sidebar): 2020.3.71659
OS and version: macOS Catalina / 10.15.4
Python version (& distribution if applicable, e.g. Anaconda): python:3.7-alpine (Docker)
Type of virtual environment used (N/A | venv | virtualenv | conda | ...): N/A
Relevant/affected Python packages and their versions: N/A
Relevant/affected Python-related VS Code extensions and their versions: Remote-Containers 0.112.0
Jedi or Language Server?: Language Server
Value of the python.languageServer setting: N/A

Expected behaviour
IntelliSense should work like it does when I use the Docker image python:3
Actual behaviour
Couldn't start client Python Tools
Steps to reproduce:

Install Remote-Containers extension
Create directory with Dockerfile
Dockerfile content: FROM python:3.7-alpine
Click Remote-Containers Add Development Container Configuration Files...
Click From 'Dockerfile'
In devcontainer.json add the extension "extensions": ["ms-python.python"]
Click Remote-Containers Reopen in Container
Create a simple Python file: import os. This will trigger the downloading of the extension
Wait until the extension is downloaded and extracted. Then the error Couldn't start client Python Tools will show.
(Optional) If you change your Dockerfile to: FROM python:3 and Rebuild Container, it works.

Logs
Empty Python logs for Remote-Containers extension
N/A

Developer Tools with Source Map enabled
notificationsAlerts.ts:40 Couldn't start client Python Tools
log.ts:197   ERR spawn /root/.vscode-server/extensions/ms-python.python-2020.3.71659/languageServer.0.5.45/Microsoft.Python.LanguageServer ENOENT: Error: spawn /root/.vscode-server/extensions/ms-python.python-2020.3.71659/languageServer.0.5.45/Microsoft.Python.LanguageServer ENOENT
    at Process.ChildProcess._handle.onexit (internal/child_process.js:264:19)
    at onErrorNT (internal/child_process.js:456:16)
    at processTicksAndRejections (internal/process/task_queues.js:84:9)
console.ts:137 [Extension Host] rejected promise not handled within 1 second: Launching server using command /root/.vscode-server/extensions/ms-python.python-2020.3.71659/languageServer.0.5.45/Microsoft.Python.LanguageServer failed.
log.ts:197   ERR Launching server using command /root/.vscode-server/extensions/ms-python.python-2020.3.71659/languageServer.0.5.45/Microsoft.Python.LanguageServer failed.
log.ts:197   ERR No application in the Launch Services database matches the input criteria.: Error: No application in the Launch Services database matches the input criteria.

Alpine linux is not supported by LS yet https://github.com/microsoft/python-language-server/issues/1902 . Please use Jedi in this scenario.


Bugs related to Mentor Application

Is your feature request related to a problem?.

After Applying as a mentor, it should redirect to the homepage.
Rename the button as "Apply as mentor" instead of "Apply as a mentor"

Describe the solution you'd like

Edit the code to complete the above tasks.

Additional context
https://docs.google.com/document/d/1YiX0hik7V5DGB7f88HfkVT5Fk455kZ0LjYlJzqR-Z2I/edit?usp=sharing

HI @Gimhan-minion, Can I work on this issue?

I'm working on it.

Thank you @kumuditha-udayanga. I'll assign you for it :smile_cat:


Allow all lowercase priorities

Just being tolerant given that the comparison used to be entirely
case-insensitive.
Also quote all the strings to avoid conflict with potential lua keywords
error/debug.

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

/kind flaky-test

If contributing rules or changes to rules, please make sure to also uncomment one of the following line:

/kind rule-update

/kind rule-create

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area engine

/area rules

/area deployment

/area integrations

/area examples

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

Allow entirely lowercase rule priorities, which matches prior case-insensitive match.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: mstemm
If they are not already assigned, you can assign the PR to them by writing /assign @mstemm in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.
:memo: Please follow instructions in the contributing guide to update your commits with the DCO
Full details of the Developer Certificate of Origin can be found at developercertificate.org.
The list of commits missing DCO signoff:

f05e169 Don't quote table keys

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.
:memo: Please follow instructions in the contributing guide to update your commits with the DCO
Full details of the Developer Certificate of Origin can be found at developercertificate.org.
The list of commits missing DCO signoff:

f9bf5cb Squash me

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: leodido
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [leodido]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: 291d0282ed8c08bfb61aa216685d10c079029481


Failing to use with VSCode native notebook feature and .NET 5

The getting started instructions of .NET Interactive Notebooks guides to do the following:
-Install the latest Visual Studio Code.
-Install the latest .NET 5 SDK
-Install the .NET Interactive Notebooks extension from the marketplace.
Even though it seems to be simple, it is something I can’t get working. For example, if I try to run simple line of C# code “Console.WriteLine("something");” after installing as instructed above, I’ll get “NameError: name 'Console' is not defined” (with “C# (.NET Interactive)” selected for the cell).
Please help. This is very cool development in the .NET ecosystem and I would like to present its possibilities to the organizations I work with.
An idea: could there be a sample folder with Dockerfile and devcontainer.json files, with which one can easily reproduce the environment enabling the latest and greatest features.

This will happen if the Python kernel rather than .NET Interactive is being used.

When you see this, you can change kernels by selecting View: Reopen Editor With... from the command pallet and then choose .NET Interactive for Jupyter:

Super, thank you so much @jonsequitur. That was the reason.
In my view, the Getting Started instructions (at
https://marketplace.visualstudio.com/items?itemName=ms-dotnettools.dotnet-interactive-vscode ) should have a note about this. I almost gave up on this feature.


Circuit Sketch Diagram Required

Greetings,
My project is somehow not working properly and i think its because of the circuit setup i may have done incorrectly.
Could you please provide a circuit sketch so that the connections become clear.
Thanks.

Hi There,
What components are you using - microphone board and speaker amplifier?
Thanks

Thanks for the response. Here are the list of components:
1 x  INMP441 MEMS Omnidirectional Microphone Module High Precision/SNR Low Power I2C Interface Supports ESP32
1 x  ESP32 Development Board WiFi+Bluetooth
1 x  I2S Audio Breakout - MAX98357A (Sparkfun USA)

Thanks for the response. Here are the list of components:
1 x INMP441 MEMS Omnidirectional Microphone Module High Precision/SNR Low Power I2C Interface Supports ESP32
1 x ESP32 Development Board WiFi+Bluetooth
1 x I2S Audio Breakout - MAX98357A (Sparkfun USA)
BTW both arijitaich & puresker are my accounts.


Problem extending "tr" with td contents in template

The following was posted as a Custom Elements issue, but <polymer-element> should have the same problem:
Not high priority but I thought I'd pass this along. We had a bug report from trying to make a custom element that extends "tr". The problem is illustrated by this example:
<element name="x-game" extends="tr">
<template>
  <td>{{game.id}}</td>
</template>

Unless the browser has native <template> it won't work because the TD is not allowed there. So this is only an issue with the polyfill. If you have native template, it should work as expected.
MDV has a similar problem and works around it by supporting the template attribute on table nodes. That lets you put templates in tables, but I can't see how that would help here. The best idea I can come up with is to build the DOM imperatively. Which might be okay if this problem doesn't happen frequently.
(Feel free to close if this outside the scope of custom elements! I couldn't quite figure the best place to report it. Original discussion is here:
https://groups.google.com/a/dartlang.org/forum/?fromgroups#!topic/web-ui/5bCCd_M0nps)

Closing this issue due to age and the release of version 1 release of Polymer - please feel free to re-open if this is incorrect.


[r] Rename NdArray -> NDArray

Conforms with spec update https://github.com/single-cell-data/SOMA/pull/55

Codecov Report
Base: 64.06% // Head: 74.74% // Increases project coverage by +10.68% :tada:

Coverage data is based on head (e1928e8) compared to base (fc7d239).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #609       +/-   ##
===========================================
+ Coverage   64.06%   74.74%   +10.68%
===========================================
  Files          61       26       -35
  Lines        3225     1865     -1360
===========================================
- Hits         2066     1394      -672
+ Misses       1159      471      -688

Flag
Coverage Δ

python
74.74% <ø> (ø)

r
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

src/include/span/span.hpp

inst/tiledb/include/tiledb/dimension.h

src/rutilities.h

inst/tiledb/include/tiledb/domain.h

R/TileDBObject.R

inst/tiledb/include/tiledb/exception.h

inst/tiledb/include/tiledb/attribute.h

R/SOMADenseNdArray.R

R/SOMASparseNdArray.R

inst/tiledb/include/tiledb/config.h

... and 25 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


[Enhancement]: Toggle button light and dark

Is your enhancement request related to a problem? Please describe.➕
website enhancement
Describe the solution you'd like
I want to add the light and dark toggle button in the website will will make it more presentable
Select program in which you are contributing
GSSoC23
Code of Conduct

[X] I follow CONTRIBUTING GUIDELINE of this project.

Hey @Arnabhit !
Thank you for raising an issue 💗
You can self assign the issue by commenting /assign in comment 😀
Make sure you follow CODE OF CONDUCT and CONTRIBUTING GUIDELINES 🚀
Don’t Forget to ⭐ our GameZone🎮
Make sure you join our Discord🕹

/assign

Hello @Arnabhit, Time's Uppp!⏰
Sorry for closing your issue!
But it's more than a week since we haven't received anything from your side 😢 .
Come up with new ideas, create a new issue and make sure you finish it within a week! 🔥
All the best! 🚀
Happy Hacking! 💗

Hey @Arnabhit ! Thank you so much for your raising the issue💗
It’s all yours, you can come anytime again and make some contributions! 🚀
Alone, we can do little, but together we can do so much! 😇


SWS item notes: remember formatting.

From<EMAIL_ADDRESS>on June 04, 2011 12:31:31
Useful info: I'm on a mac (osx 10.7)
so I was like so insanely happy when I found sws notes and started using it.
today I was even more happy when I right clicked some text to find that you can go to "font>show fonts" and edit it proper.
if I go to "track notes" and then back to "project notes" it doesn't retain the color or multiple sizes of text.
it would be freaking awesome if it could do so!
I mean not that it's not freaking awesome now, but it would be even more awesome. like. awesomezilla.
Original issue: http://code.google.com/p/sws-extension/issues/detail?id=303

Formatting in text boxes was a REAPER issue that was fixed in justinfrankel/WDL@55199fca0cddaa93e6db0b10fc3597bc31318c8e. Text boxes no longer support rich text on macOS.


vm_devbox: systemctl restart leaves vm shutdown

Different behaviors for different users. When I restart my vm it is left in a running state. When I restart another users vm it is left in "poweroff" state...

Switching which vm starts first causes the shutdown behavior to move to the second user started.

Switching to Type=oneshot and RemainAfterExit=yes fixes the issue. This has the downside that systemd doesn't monitor the actual vm process. For example, if the vm is powered off outside of systemd (ex it crashes) and you run systemctl status it will report the vm still running. This isn't the worst thing in the world. The vms are unlikely to crash. But, it could be confusing for a sysadmin.
The other option I think would be to managed pid files and then tell systemd about them. It's guessing algorithm (or using cgroups) I think is what's getting in the way right now.

pidfile may be tricky to implement.

Ya, looks like a rabbit hole. oneshot and remainafterexit it is...


[Feature] Search for Requests

Search is pretty handy, would be nice if it could open a telescope fuzzy finder, then list out all requests inside any .http files in the current folder (or in a subfolder of your choosing).
The require("kulala").search() isnt all that useful though, it just lists out the .http files in the current working directory.
Would it be an idea to replace the search function or extend it so you could alternatively search and pick a particular request (and be able to have it search for more than the current working directory) ?

Would it be an idea to replace the search function so you could alternatively search and pick a particular request

I think that would make it an ideal replacement!


Update customizing_what_happens_in_fit.py

Added note "it is recommended to wrap optimizer objects using self._get_optimizer when using Keras mixed-precision API"
Fix for #49368

Thanks for the PR. Private methods should never be relied on by users (since their stability is not guaranteed).


bump node and react to 18

Bumps project to use Node and React 18 to match NextJS refactor.  Also bumps babel eslint config because of bug introduced there when bumping React

Since we have chosen to replace this component, I am closing this PR.


fix: lets pass in the helm binary

fixes https://github.com/jenkins-x/jx/issues/7742

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign jstrachan
You can assign the PR to them by writing /assign @jstrachan in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/approve

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jstrachan
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [jstrachan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


correct exercise number for chapter 28-30

In some chapters, like https://jrnold.github.io/r4ds-exercise-solutions/functions.html, you use "Exercise 19.2.1", in other chapters, like https://jrnold.github.io/r4ds-exercise-solutions/r-markdown.html, you use "Exercise <IP_ADDRESS>".
I suppose that chapter 28-30 should be modified (but I might have missed some other chapters)

The problem is that you should change
---
output: html_document
editor_options:
  chunk_output_type: console
---

# R Markdown

## R Markdown Basics

### Exercises

#### Exercise <IP_ADDRESS> {.unnumbered .exercise}

to

output: html_document
editor_options:
chunk_output_type: console
R Markdown
R Markdown Basics
Exercise 27.1.1 {.unnumbered .exercise}

(using the beginning of https://github.com/jrnold/r4ds-exercise-solutions/blob/master/rmarkdown.Rmd for example)

could you please wait for a while?

I am trying to create a PR

I correct all the chapter names, exercise numbers, etc

closed in #91


How to create droplet from a snapshot

I see the API supports creating snapshots from a droplet. However, I wish to create a droplet from an old snapshot. Do you know if this is supported?
Thanks

DigitalOcean.API.Models.Requests.Droplet newDroplet = new DigitalOcean.API.Models.Requests.Droplet
 {
       Name = "reserved",
       ImageIdOrSlug = snapshot.Id, // <----
       ...
};
var droplet = client.Droplets.Create(newDroplet).Result;


Model class relationship

Hi,
when it's used model class is possible to setup relationship between models class?
Something like "Belongs To"
Thanks

Sorry, it currently doesn't support any complex model relationships. It simply does selects and updates.


Better error message API

New Issue Checklist

[X] I read the Contribution Guidelines
[X] I read docs.fastlane.tools
[X] I searched for existing GitHub issues

:D
Hey guys ~
Is there an api for collect error message, so that I can make better slack notification with the error message instead of the whole long logs.
If the build failed I want to get the short message or the error, such as  Unauthorized, Network failed, logIn iTunes connect failed, reason XXXX. It's even better if there is a common error list for what may happen when build.
Now, if the build error occur, I need to login the remote server and search from the log.

Hey @iShawnWang - there isn't an API exactly, but you could put rescue blocks in your Fastfile and call to the slack action in there to post the message you'd like 🚀


update readme

Don't merge yet - need to verify Nimbix registration process

a couple of typos.  I'll try the registration now.

So, the changes look good to me, but I can't get the registration process to complete, it just hangs for me.

No longer needed


⚠ Bofrost.be has degraded performance

In ca1cdcf, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1957 ms

Resolved: Bofrost.be performance has improved in ff1148b.


added docs

This PR Contains

Added Contribute Docs
Credit Docs
Join Keploy Docs
Report Bugs Docs
New Project Docs
Developer Workflow Directory
Automated GHA checks docs
Development Setup Directory

In many files link is not added because the docs are not written that`s why in next PR i am adding all docs and attached link
In Development Setup i am adding only files name in next PR docs was also added
One reason is also for link not added because of when this PR is merged then i added main repo links . Currently link is not generated because files is not merged yet.

cc @nehagup

cc @nehagup

@Ayush7614 are you still working on this?

Yes

cc @nehagup

@Ayush7614 We need to add the folders and files before merging this with empty links.


PE-40340 Deprecate PALS commands

Summary and Scope
Recently, we've refactored PALS on Shasta systems to avoid using the
REST API, so it works like it does on HPCM systems. The cray pals,
aprun, and mpiexec commands fail on updated systems.
To handle this, mark the commands as hidden so they don't show up in the
help message, and add a message to aprun/mpiexec to assist with the
transition.
Issues and Related PRs

Resolves PE-40340
Resolves PE-40478

Testing
Tested on:

slice

Test description:
Tested manually on slice.

Were the install/upgrade-based validation checks/tests run (goss tests/install-validation doc)? No
Were continuous integration tests run? If not, why? No
Was upgrade tested? If not, why? No
Was downgrade tested? If not, why? No
Were new tests (or test issues/Jiras) created for this change? No

Risks and Mitigations
No known risks.
Pull Request Checklist

[x] Version number(s) incremented, if applicable
[x] Copyrights updated
[x] License file intact
[ ] Target branch correct
[x] CHANGELOG.md updated
[ ] Testing is appropriate and complete, if applicable
[ ] HPC Product Announcement prepared, if applicable

This should be good to go from my perspective. Let me know if there's anything else I need to do to get this done.


add check: lint and unit-test for PR

What type of PR is this?
/kind chore
What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Special notes for reviewers:

Please check the following list before waiting reviewers:

[ ] Already committed the CRD files to the Helm Chart if you created some new CRDs
[ ] Already added the permission for the new API
[ ] Already added the RBAC markers for the new controllers

Does this PR introduce a user-facing change??

None

/lgtm
/approve


Add Clock Time Display Mode

Add a clock time mode display mode to simulate the display for example used at the Lok Ma Chau arrival lobby.

Deleted in favour of #2.


makemkv: 1.14.5 -> 1.14.7

Motivation for this change
Changelog:
1.14.7:

Better compatibility for decrypted AACS 2.1 FMTS files
Fixed variable expansion bug for default file name template

1.14.6:

Added support for AACS 2.1
Many small bugfixes and improvements

Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Notify maintainers
cc @titanous

Thanks!


cmake compilation problems

Hello, I think your work is very good, I want to learn, but I encountered some errors when compiling, but I don't know how to solve it, can you help me？

Hi,
Your error indicates the failure to find mpfr: do you have it installed?
If so, you may need to set the env variable as
 echo "MPFR_INC=C:\Miniconda\Library\include" >> ${env:GITHUB_ENV}
You can also refer to my windows CI for a complete setup. https://github.com/jiangzhongshi/bichon/blob/main/.github/workflows/cmake.yml#L101

你好，
您的错误表明找不到 mpfr：您安装了吗？
如果是这样，您可能需要将 env 变量设置为
 echo "MPFR_INC=C:\Miniconda\Library\include" >> ${env:PATH}
您还可以参考我的 windows CI 以获取完整设置。https://github.com/jiangzhongshi/bichon/blob/main/.github/workflows/cmake.yml#L101

OK, I'll try. Thank you very much!


ImportError in load_ckpt.py due to missing attribute 'path' in 'importlib_resources'

Description:
(MineCLIP2) bash-3.2$ python3 MineCLIP/main/mineclip/load_ckpt.py variant=attn ckpt.path=/path/to/attn.pth

Traceback (most recent call last):
  File "/path/to/MineCLIP2/MineCLIP/main/mineclip/load_ckpt.py", line 5, in <module>
    from mineclip import MineCLIP
  File "/path/to/MineCLIP2/MineCLIP/mineclip/__init__.py", line 2, in <module>
    from .dense_reward import (
  File "/path/to/MineCLIP2/MineCLIP/mineclip/dense_reward/__init__.py", line 1, in <module>
    from .animal_zoo import AnimalZooDenseRewardWrapper, HuntCowDenseRewardEnv
  File "/path/to/MineCLIP2/MineCLIP/mineclip/dense_reward/animal_zoo/__init__.py", line 2, in <module>
    from .hunt_cow import HuntCowDenseRewardEnv
  File "/path/to/MineCLIP2/MineCLIP/mineclip/dense_reward/animal_zoo/hunt_cow.py", line 4, in <module>
    import minedojo
  File "/path/to/.local/share/virtualenvs/MineCLIP2-WRt4Br1D/lib/python3.9/site-packages/minedojo/__init__.py", line 1, in <module>
    from .tasks import make
  File "/path/to/.local/share/virtualenvs/MineCLIP2-WRt4Br1D/lib/python3.9/site-packages/minedojo/tasks/__init__.py", line 83, in <module>
    _ALL_TASKS_SPECS_UNFILLED = OmegaConf.load(_resource_file_path("tasks_specs.yaml"))
  File "/path/to/.local/share/virtualenvs/MineCLIP2-WRt4Br1D/lib/python3.9/site-packages/minedojo/tasks/__init__.py", line 29, in _resource_file_path
    with importlib_resources.path("minedojo.tasks.description_files", fname) as p:
AttributeError: module 'importlib_resources' has no attribute 'path'

Issue Overview:
The script load_ckpt.py is encountering an AttributeError due to the absence of the 'path' attribute in the 'importlib_resources' module. The error occurs in the minedojo module when attempting to load a resource file. This issue is hindering the execution of the script and needs to be addressed.
Steps to Reproduce:

Run the command: python3 MineCLIP/main/mineclip/load_ckpt.py variant=attn ckpt.path=/path/to/attn.pth
Observe the traceback and the AttributeError related to 'importlib_resources.path'.

Expected Behavior:
The script should execute without encountering the mentioned AttributeError, and the resource file should be loaded successfully.

In the mean time pip install importlib-resources==5.12 should fix it


[Feature Request]: Add "Scroll into view" functionality

Which browser are you using?
Edge Chromium
Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
I can scroll through a long webcomponents list easily, but I want to see where and how it appears on the website and I need to manually scroll the web page and find it.
Describe the solution you'd like
A clear and concise description of what you want to happen.
Similar to how in the browser's DevTools, I can go to "Elements" tab, right-click on an element, and choose "Scroll into view", I would like to add that option when I look in WCDT,

I wish I could right-click an element (or have a button next to it?) that has that functionality, and instead of manually find the component on the page somewhere, it will scroll the page so I can see it right there.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

Thanks for the suggestion!
Funnily enough, the original version of WCDT had this functionality built in by default, but I removed it before shipping the first version :D
I'll have to look into a nice UI/UX way of implementing this but will definitely do this for the next update!

👍

https://github.com/Matsuuu/web-component-devtools/commit/f3b07bf4be51eb6e69cfcc3fc2677549e3e20040 Implemented here. Will maybe work on some UX.
What do you think, should it also select the target element in the devtools?

Tested around and made it so that it also selects the list item when you decide to scroll to it. Felt like the best UX.
This will ship in v0.1.6. Will close this for now


Added three new regex patterns to improve chatbot responses

Added responses for statements like "I love (something)" or "I like (something)" ask the user why it’s special to them.
Added responses for "I have (something) as a hobby" to show interest and encourage the user to share more.
Created motivational responses for "I need motivation for (something)" to support users with positive messages

I think it looks good.
@Jonah-gr pull request ready to be merged


ws: Save and expose damage buffer information

The wl_surface.damage_buffer request can be used by clients to inform that a given region (in buffer coordinates) is damaged. This request is used by eglSwapBuffersWithDamage[EXT|KHR], with one call for each rect.
For more info: https://wayland-book.com/surfaces-in-depth/damaging-surfaces.html
This commit stores this information and exposes it to exported EGL image clients.
It also bumps the nested compositor interface to version 4, which provides the damage_buffer support.

Superseded by #188


Changes headings font from Raleway to Satoshi

closes #747
What changed? Why?
The headings' font was updated from Raleway to Satoshi font to match swc design system. SWC design system font showcase is available here
UI changes
Web

Old 👴
New 👶

Notes to reviewers
I had to use relative path to load the font because NextJS was complaining about not finding it. I decided to use relative path and store the fonts in public folder instead of creating an assets folder inside app.
How has it been tested?

[X] Locally
[ ] Vercel Preview Branch
[ ] Unit test
[ ] Functional test

Change management
type=routine
risk=low
impact=sev3

We'll def want to scrunch the odometer letter spacing for this change.
@coinbasemar take a look at preview and let us know what else needs to be tweaked

I dropped the letter-spacing from -1 to -6, but IMO I don't think that this font really suits this case. Maybe using another font for the odometer would be better.
This is how it looks like with -6px of letter spacing.

A suggestion:
This is how it looks like using -1px of letter spacing and open-sans font

@travisbloom-cb @coinbasemar


UI: Improve token list

[x] Be Less Wrong(tm) when counting tokens
[x] Pagination off by one?
[x] Format dates
[x] Button footers nicer

LGTM


docs: Fix simple typo, garanteed -> guaranteed

There is a small typo in rich/_ratio.py.
Should read guaranteed rather than garanteed.

Thanks


please improve this

we need better

This repository has been dead for a while but okay.
On Tue, 21 Jun 2022 at 18:53, Anthony Huang @.***>
wrote:

we need better
—
Reply to this email directly, view it on GitHub
https://github.com/Hello56721/nengish-translator/issues/1, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/APXKCUO364SLFHLX7Z5BBQDVQJBVBANCNFSM5ZOFM6JQ
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

REVIVE IT


Fix Issue 20502: Converting std.typecons.RefCounted!T to a string gives T's storage location instead of T's fields when T is a struct without an explicit toString

Example of what this PR fixes:
void main()
{
    import std.typecons : refCounted;
    import std.stdio : writeln;

    writeln(123); // "123"
    writeln(refCounted(123)); // "123"

    struct A { string toString() { return "a"; } }
    writeln(A.init); // "a"
    writeln(refCounted(A.init)); // "a"

    // This one doesn't match:
    struct B { int x; }
    writeln(B(123)); // "B(123)"
    writeln(refCounted(B(123))); // "RefCounted!(B, cast(RefCountedAutoInitialize)0)(RefCountedStore(558C7FFBC660))"
}

Compiling with DMD master outputs:
123
123
a
a
B(123)
B(123)

Is there a mistake in your example?

@MoonlightSentinel I've verified this is still happening with freshly-compiled DMD master with that example verbatim. Pasting the example into https://run.dlang.io/ and running it also gives that result.

Strange, are you on Mac/Posix?

@MoonlightSentinel I've tested this on Windows 10 using dmd v2.090.0. Maybe you had this branch checked out and dmd used it when you ran the example so the fix was already applied.

@MoonlightSentinel I've tested this on Windows 10 using dmd v2.090.0. Maybe you had this branch checked out and dmd used it when you ran the example so the fix was already applied.

I somehow missed that the above behaviour was fixed  and thought it was still present. Sorry for the noise

@RazvanN7 Browsing through old issues I came across this PR. Seems to be one of the forgotten PRs, that could be merged (after fixing the trivial merge conflict). In my opinion the request of @MoonlightSentinel for const/immutable RefCounted is an enhancement, not a must have (don't let the best be the enemy of the better).


Failure on an .nc file that has _NCProperties attribute

The issue was originally reported to nco, but seems to be an issue with NetCDF library.
https://sourceforge.net/p/nco/bugs/117/
Here is a copy for a reference.

$ ncks --version
NCO netCDF Operators version 4.7.2 built by buildd on lcy01-amd64-004 at Jan 25 2018 19:04:04
ncks version 4.7.2
$ ncks -4 in.nc in.nc4
nco_err_exit(): ERROR Short NCO-generated message (usually name of function that triggered error): nco_copy_att()
nco_err_exit(): ERROR Error code is -42. Translation into English with nc_strerror(-42) is "NetCDF: String match to name in use"
nco_err_exit(): ERROR NCO will now exit with system call exit(EXIT_FAILURE)

The file results from quite complex cdo/nco/thredds combination.. The issue is that it has _NCproperties attribute. After a small workaround
$ ncatted -a _NCProperties,global,d,, in.nc
ncks passes. Such situation, probably, could have been handled more intelligently.

As it was pointed out, ncdump (in my case netcdf library version 4.6.0 of Feb  9 2018 19:21:24) fails to show the attribute in the original file...
Here is the test file:
in.nc.gz
Thank you!

The user attempted to copy a netCDF3 file with the _NCProperties attribute into a netCDF4 file. This failed because the attribute was listed as a normal attribute to copy (from netCDF3), and then the netCDF4 API prevented the copying. Now NCO skips attempting to copy _NCProperties. Probably this attribute should not be made visible to the attribute inquire functions, nor should users be allowed to write it through the API.


Store only signatures for presigned transactions, not the whole PSBT

Instead of storing the PSBTs in DB and querying/updating them, we should only store the signatures and create the PSBTs on the fly. If i recall correctly, it was among other things meant as an optimization to query the presigned transactions.
I think it was premature, and in addition to a big cleanup (both in code and storage) it would prevent races when updating the in-DB psbt. See for instance this monstrosity which is moreover currently buggy (fixed in #366):
https://github.com/revault/revaultd/blob/3ab3c6a4b4e2dda4209c0c2e735d079aa3508aff/src/database/actions.rs#L660-L737

I wonder if listpresignedtransactions is an useful API at all.

When we do that, let's do #369 at the same time.


JMX is enabled, but log says ports are closed

I recently installed Tabmon on a separate node and remotely polling the host where Tableau Server is installed. Everything seems to be ok except that in the log , I'm seeing this text and similar lines for other ports. I checked my tabsvc.yml and can see that jmx ports are enabled.
service.jmx_enabled: true
2019-07-17 18:42:54,495 [5] DEBUG TabMon.Counters.MBean.MBeanClientFactory - Encountered closed JMX port (8471), stopping scan.
Rest everything is running fine and no other warnings or errors. What could be the issue here ?
Thanks for your time.
Regards,
Arun

Hello @arunyadav19,
Excuse the delay in my response. Based on the information provided, it looks like TabMon is not connecting to the JMX ports.
Recently I've noticed that enabling JMX counters does not always open the ports on the first try. It may be worth disabling the jmx counters and then re-enabling them to get them running. Once done, all you would need to do is reconfigure TabMon and start it.
If this is not an option, please let me know by answering the questions below.

What version of TabMon is being used?
What version of Tableau Server is being used?
Has this ever worked?

I may also need a full set of the logs to troubleshoot with. Please feel free to remove any private information.
Thank you,
Dan

Hello,
I am closing this issue due to inactivity.
Thanks,
Dan


[HUDI-4756] Remove unused config "hoodie.assume.date.partitioning"

Change Logs
Removed related code that support "assume.date.partition" configuration.
Impact
If there is not usage for this configuration, there should be no impact on usability or performance.
Risk level (write none, low medium or high below)
None.
Documentation Update
The availability about the config should be updated in the Hudi website.
Here is the ticket: HUDI-6715.
Contributor's checklist

[x] Read through contributor's guide
[x] Change Logs and Impact were stated clearly
[ ] Adequate tests were added if applicable
[ ] CI passed

What do you mean for unused ?

What do you mean for unused ?

This is the from the task. I don't have enough context to confirm this. @nsivabalan Can you explain this?


Adding another grid-breakpoint (viewport) breaks the ProductSlider

PHP Version
7.4
Shopware Version
<IP_ADDRESS>
Expected behaviour
I created a theme which inherits from the Responsive theme (actually there is an intermediate theme which inherits from the Responsive theme, but that shouldn't matter).
I now added a new breakpoint in my overrides.scss
// Grid breakpoints
//
// Define the minimum dimensions at which your layout will change,
// adapting to different screen sizes, for use in media queries.

$grid-breakpoints: (
    xs: 0,
    sm: 576px,
    md: 768px,
    lg: 992px,
    xl: 1200px,
    2xl: 1920px,
);

// Grid containers
//
// Define the maximum width of `.container` for different screen sizes.

$container-max-widths: (
    sm: 540px,
    md: 720px,
    lg: 960px,
    xl: 1140px,
    2xl: 1400px,
);

Everything should work as before.
Actual behaviour
Unfortunately now the product slider component is not initialized when the page is initially loaded with a width >= 1920px (larger than breakpoint 2xl). When the page is loaded with < 1920px everything works as expected. I can even resize to over 1920px then and it doesn't break, it still updates the visible slide count when resizing back between the other breakpoints.
When loading the page with >= 1920px it shows the console error Uncaught TypeError: can't convert undefined to object.
I also tried adding my breakpoint with the following block in base.html.twig
https://github.com/shopware/platform/blob/ceee4b728a115177a3c0ecdb0342df18fd03703a/src/Storefront/Resources/views/storefront/base.html.twig#L140-L153
{# @deprecated tag:v6.5.0 - Will be moved to `layout/meta.html.twig` - Use block `layout_head_javascript_breakpoints` instead #}
{% block base_script_breakpoints %}
    {{ parent() }}

    <script>
        window.breakpoints['2xl'] = 1920;
    </script>
{% endblock %}

My debugging session revealed that the getCurrentViewport method of the ViewportDetection helper returns none for the new breakpoint (even when adding it with the base_script_breakpoints block).
https://github.com/shopware/platform/blob/ceee4b728a115177a3c0ecdb0342df18fd03703a/src/Storefront/Resources/app/storefront/src/helper/viewport-detection.helper.js#L155-L158
This eventually breaks the slider with can't convert undefined to object which is thrown in the method getViewportSettings of the SliderSettingsHelper when deepmerge tries to merge an obect with undefined.
https://github.com/shopware/platform/blob/01d2da25be8d437bae0e6617c6e11b102c9ece6d/src/Storefront/Resources/app/storefront/src/plugin/slider/helper/slider-settings.helper.js#L13-L22
I was able to hack a workaround together for this case by using this block instead:
{# @deprecated tag:v6.5.0 - Will be moved to `layout/meta.html.twig` - Use block `layout_head_javascript_breakpoints` instead #}
{% block base_script_breakpoints %}
    {{ parent() }}

    <script>
        window.breakpoints['2xl'] = window.breakpoints['xl'];
        window.breakpoints['none'] = window.breakpoints['xl'];
    </script>
{% endblock %}

This sets breakpoint none to 1200 which doesn't break the slider.
Note: I also did this for my 2xl breakpoint, not sure if this could save me from another error anywhere. This is unrelated to the slider error.
How to reproduce

Add another grid breakpoint in the overrides.scss as shown above. The breakpoint must be larger than 1200px.
Add a product slider to a page.
Open that page with a larger width than set for the new breakpoint.
(4. ???)
(5. Profit)

I just noticed my workaround requires another key for Safari:
<script>
    window.breakpoints['2xl'] = window.breakpoints['xl'];
    window.breakpoints['none'] = window.breakpoints['xl'];
    // Required for Safari
    window.breakpoints[''] = window.breakpoints['xl'];
</script>

related: https://issues.shopware.com/issues/NEXT-8675

Hello,
Within our company roadmap and work capacity, we try to address each bug or improvement request but admit that not each one will be resolved. To continue our culture of honesty and openness, we are closing this issue to focus on our roadmap on behalf of all Shopware users.
If you feel like this issue is still impacting you, please create a new issue and let us know.
Thank you again for your valuable feedback.


communication aware load balancers fail on chare arrays that are not full

Original author: Nicolas Bock
Original issue: https://charm.cs.illinois.edu/redmine/issues/445

Shameless pasting from an email conversation with Jonathan <jliffl2`illinois.edu>:
On your other email chain, you have discovered a bug in the communication-aware load balancing code, where the graph assumes that every edge will always have both nodes. This is obviously not true in the case of deletions and insertions (or even just periodic load balancing when the state may not be clearly defined)

Original date: 2014-05-17 00:43:53

Could we get the full context of that conversation, to allow others in the group to track this down? Or, if there's a test case that exercises it, we can work through it that way.

Original date: 2014-08-12 00:38:53

I'll try to see that this gets looked into shortly.

Original date: 2014-10-07 20:51:05

Nicholas, would you mind giving the updated version of Charm++ a try with one of the affected LB strategies?


mesengsengchang

In Halley Eriich's song "Tkud ma Bechil," he uses this line to describe the moon:  "Chelechang klungang el uoi meral mesengsengchang."  I was told that mesengsengchang means "growing" or "getting old" and, in this case, refers to the fact that the moon is about full.  Yoichi Rengiil said "a mesengsengchang a mla mlo kloulechad."  What is the root of this word?

Singch:
Mekesingch:
Bekesingch:
Mesesengchang:
mesengsengchang:
On Sun, Dec 8, 2024 at 15:19 JimGeselbracht @.***>
wrote:

In Halley Eriich's song "Tkud ma Bechil," he uses this line to describe
the moon: "Chelechang klungang el uoi meral mesengsengchang." I was told
that mesengsengchang means "growing" or "getting old" and, in this case,
refers to the fact that the moon is about full. Yoichi Rengiil said "a
mesengsengchang a mla mlo kloulechad." What is the root of this word?
—
Reply to this email directly, view it on GitHub
https://github.com/tekinged/missing/issues/539, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AF2DJJH7OVVAHL6DKYAVIBL2ETAVRAVCNFSM6AAAAABTHUEBV2VHI2DSMVQWIX3LMV43ASLTON2WKOZSG4ZDKNJWGE4DSOI
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

I said this refers to the moon, but more likely it refers to the child growing in the pregnant woman.  Because they "slipped":  Chelechang klungang el uoi meral mesengsengchang / ng torchu ra dolekebai a urungulel / cheleoch el ngalek e leng / di kled e siungel e ngak a uoi metemellang

Uaisei. Kau kmal mla mo morets eh Ngirchoureng! 🤙🏾
On Sun, Dec 8, 2024 at 15:53 JimGeselbracht @.***>
wrote:

I said this refers to the moon, but more likely it refers to the child
growing in the pregnant woman. Because they "slipped": Chelechang klungang
el uoi meral mesengsengchang / ng torchu ra dolekebai a urungulel /
cheleoch el ngalek e leng / di kled e siungel e ngak a uoi metemellang
—
Reply to this email directly, view it on GitHub
https://github.com/tekinged/missing/issues/539#issuecomment-2526421901,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AF2DJJFYSGQ5SOGOIXXESGD2ETEVBAVCNFSM6AAAAABTHUEBV2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMRWGQZDCOJQGE
.
You are receiving this because you commented.Message ID:
@.***>


after_destroy callbacks sometimes not called with execute_after_commit and transaction

Hello 👋
I've recently started using this gem's execute_after_commit feature to successfully fix MySQL LockWaitTimeout issues, but now I've stumbled upon a nasty bug. In some cases, the counter is not updated after destroy with execute_after_commit.
Let's say we have:
class Graph < ApplicationRecord
  has_many :graph_nodes, class_name: 'Node', primary_key: 'root_id'
end

class Node < ApplicationRecord
  belongs_to :graph,  optional: true, foreign_key: 'graph_id', primary_key: 'root_id'
  counter_culture :graph, execute_after_commit: true # column is 'nodes_count'
end

And then we have a transaction where an update before destroy is happening:
ActiveRecord::Base.transaction do
  Node.last.touch
  Node.last.destroy
end
# => no decrement query

ActiveRecord::Base.transaction do
  Node.last.touch
  Node.last.destroy
  Node.first.destroy
end
# => only the last destroy will trigger one decrement query

Works well without execute_after_commit: true or by changing the code (not possible in my case) to:
ActiveRecord::Base.transaction do
  node = Node.last
  node.touch
  node.destroy
end

I suspect the update request somehow prevents the after_destroy callback.

Hey @marinfr thanks for reporting this. I did some digging, see #316. However, my take-away from that work is that the after_commit hook simply is not called at all for your issue here. So at first glance, this looks like more of a Rails problem than a counter_culture issue. Can you take a look at the output in #316 and let me know what you think?

@magnusvk, thanks for looking into this!
I've tried to reproduce this behaviour with basic Rails by defining an after_commit action that just prints AFTER_COMMIT. It's for a different model that doesn't have anything to do with counter columns. Trying both syntaxes of updating+destroying, AFTER_COMMIT was always and only printed once at the end:
   (2.2ms)  COMMIT
"AFTER COMMIT"

Does this mean that after_commit not being called is not the issue here? It looks like it's the execute_after_commit logic in this or the after_commit_action gems.

Ok, you might be right!
I've defined this in the model described in the issue:
after_commit :test_after_commit

def test_after_commit
  actions = {}

  actions[:create]  = transaction_include_any_action?([:create])  || nil
  actions[:update]  = transaction_include_any_action?([:update])  || nil
  actions[:destroy] = transaction_include_any_action?([:destroy]) || nil

  p "AFTER COMMIT EXECUTED FOR #{actions.compact.keys.join(", ")}"
end

The output with the first approach:
   (2.4ms)  COMMIT
"AFTER COMMIT EXECUTED FOR update"

The output with the second approach:
   (2.0ms)  COMMIT
"AFTER COMMIT EXECUTED FOR destroy"

Feel free to close this issue as it looks like it's intended for the Rails team.
Thanks!

Bummer, I personally don’t think that’s the right behavior, but also wouldn’t know what to do to fix it!


[Suggestion] Primary keys in voyager migrations

I really like this admin package, but why bigInteger? in tables?
I'd had to change something in the user-table of laravel and changed the primary key to smallIncrements. While migration with Laravels artisan, it threw an error and I've narrowed it down that a foreign key to the pk of the user table was typed as bigInteger.
I don't want to discuss any performance wars about it, which is bullsh** nonetheless. However actually I was baffled that the primary keys in all of voyagers tables have at least the size of an normal integer - 32 bit. For roles table even 64-bit! Seriously? Who in this world makes 18.4 quintillion roles (!) in production?
There are use cases which need more than a 32-bit integer, even more than 64-bit. But not for security roles.
Thus I had to change those to realistic types. Why?
Programmers should use what is needed and not using the maximum for everything. IMO it is a lazy attitude and leads to bad code. That those big numbers were used just for the sake of simplicity is not an argument in the programming world.
I would strongly suggest to change these types. I can pull the changes if you want to review it.

Simple answer: because Laravel did it.
We had to adapt a few migrations because the roles pivot-table references user-id.
It would simply fail when installing Voyager.
If you want to change it, you can.
Laravel allows you to override package-migrations by simply copying them into database/migrations (keeping the filename)

Everything that @emptynick said.
Also, I would caution you to watch your tone. I understand the frustration, but lashing out at devs that do this for the community (and receive no compensation) is a very good way to make us all want to quit and kill the project entirely.  You don't have to agree with every decision we make, but I strongly urge you to calmly seek understanding before letting emotion take over.  99+% of the time, there will be a completely logical reason behind that decision, and it's not infrequently out of our control.


fix: fast forward snappables now snap immediately

Description
Snappable objects when fast forwarded "hit"other objects on their way to the SnapZone cause those objects to fly away. Now the objects are first moved to the snap zones position before they eventually snap.
Fixes: TRNG-1069
Type of change

[X] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?
Set up 8 objects in a row and 8 SnapZones behind them. Snapping the first object into the first SnapZone so it has to "pass through" all other objects.

:tada: This PR is included in version 1.3.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket: