[Feature]: For Meta-Llama-3.1-70B-Instruct model, no usage info included while stream equal to True

🚀 The feature, motivation and pitch
Hello,
as with Meta-Llama-3-70B output response include usage information which contains prompt_token, total_tokens and completion_tokens in the last chunk.
but after deployment with Meta-Llama-3.1-70B-Instruct using latest vllm image (vllm/vllm-openai:v0.5.4) I am not getting None usage:
ChatCompletionChunk(id='chat-facd596ff0a44e4d2ca48006f11b', choices=[Choice(delta=ChoiceDelta(content='1', function_call=None, refusal=None, role=None, tool_calls=None), finish_reason='length', index=0, logprobs=None, stop_reason=None)], created=1723117897, model='Llama-3.1-70B-Instruct', object='chat.completion.chunk', service_tier=None, system_fingerprint=None, usage=None)
please correct me if I am doing wrong anywhere or still usage not added there ?
Alternatives
No response
Additional context
No response

You have to set stream_options in order to return usage info in stream mode.

Yeah , I have enabled stream=True to openai endpoint,.but I am getting
usage=None in all chunk dictionary
On Thu, Aug 8, 2024, 6:21 PM Cyrus Leung @.***> wrote:

You have to set stream_options in order to return usage info in stream
mode.
—
Reply to this email directly, view it on GitHub
https://github.com/vllm-project/vllm/issues/7299#issuecomment-2275746261,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALNGWSUOTNPBHNNYDQ3JES3ZQNSULAVCNFSM6AAAAABMGKFXGCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENZVG42DMMRWGE
.
You are receiving this because you authored the thread.Message ID:
@.***>

I am talking about stream_options, not stream. Both have to be specified.

even after setting stream_options=True and stream=True, I am getting usage=None , its happening only for Meta-Llama-3.1-70B-Instruct deployment only.
I am using latest openai==1.40.1 package

Hi @DarkLight1337 even after setting stream_options=True and stream=True, I am getting usage=None , its happening only for Meta-Llama-3.1-70B-Instruct model deployment only. I am using latest openai==1.40.1 package
for you with llama3.1-70b did you get usage info with stream = True

I think you should set stream_options={"include_usage": True}. Please consult the official OpenAI docs.

@DarkLight1337 , its a vllm issue in the output json content itself usage info not present then how openai will show it ?
when you set stream=False you will get the usage info

I mean that when you set stream=True, the usage info will not display by default unless you set stream_options={"include_usage": True}.

Thanks , I fixed issues after adding that params
On Thu, Aug 8, 2024, 8:26 PM Cyrus Leung @.***> wrote:

I mean that when you set stream=True, the usage info will not display by
default unless you also set stream_options={"include_usage": True}.
—
Reply to this email directly, view it on GitHub
https://github.com/vllm-project/vllm/issues/7299#issuecomment-2276035354,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALNGWSRNZJC6I5F5J57ZR4TZQOBILAVCNFSM6AAAAABMGKFXGCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENZWGAZTKMZVGQ
.
You are receiving this because you authored the thread.Message ID:
@.***>


Volounter for lead maintenance

I volonteer as a lead maintener
cf senecajs/seneca#277 (comment)

done!


Better subscription support and demo

Update Graphiql with https://dev-blog.apollodata.com/how-to-use-subscriptions-in-graphiql-1d6ab8dbd74b
Check the spec fo correct subscription handling

Fixed with 6c103c0ac8b4e2ded796244535ff712c6bab3a9f


Let projects be created via SPDX import without a project source.

overall looks good, my 2 cents (see the comment in jira issue too). Is if we want to use the cli to create projects plural from one spdx file. We should return a list of project structs from https://github.com/ion-channel/ionic/pull/460/files#diff-5bd6f147b98f488265f7a045024f3e1fcdb926a9b5c8ca6d85531eacbe5311c5R117. The method currently looks for a matching PackageName in an spdx file then will create one project.
This could be done later, but I think the purpose of no source url required, was to allow us to create projects from an spdx file, rather than a single project.
Otherwise lgtm

Thanks, I will make those changes in this PR. 👍

Going to test this with ion-connect to ensure it works before asking for a merge.

Works from my testing. 👍


Add balance transaction to disputes

When processing disputes, Stripe links to a balance transaction.  Through this balance transaction, you can retrieve the fee charged.
I needed to be able to retrieve the balance transaction and corresponding fee when processing a dispute.  This PR adds that functionality.
Please feel free to provide comments, I'm happy to improve the PR as needed.  Thanks!
Per Stripe docs:
https://stripe.com/docs/api#dispute_object

thank you for help. Please, write test for your changes. Right now PR failed not by yours mistake, don't worry.

Thanks @alexmamonchik, I will sort through writing a few tests.  I did run them and saw that there were a lot of unrelated failures which startled me  :)

fixed error, please pull master

and add a test


python3Packages.angr: 9.0.10010 -> 9.0.10055

Motivation for this change
Update angr stack to 9.0.10055
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 139804 run on x86_64-linux 1

14 packages built:

python38Packages.ailment
python38Packages.angr
python38Packages.angrop
python38Packages.archinfo
python38Packages.claripy
python38Packages.cle
python38Packages.pyvex
python39Packages.ailment
python39Packages.angr
python39Packages.angrop
python39Packages.archinfo
python39Packages.claripy
python39Packages.cle
python39Packages.pyvex

@ofborg build python3Packages.angr


Make automatic documentation work

Just follow readthedocs.org information and how to set up.

works!

Great! Finally, which was the issue we were having last week? How did you manage?

It was a matter of the functions. Some of them were bad implemented, so I
deleted the ones that we were not going to use and worked :)
2017-03-08 20:06 GMT+01:00 emaudes<EMAIL_ADDRESS>
Great! Finally, which was the issue we were having last week? How did you
manage?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/compneurobilbao/bha/issues/6#issuecomment-285136253,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AF5AtJ2CgXPmzAzsAwcqQQpGFCDpUQEgks5rjvwzgaJpZM4MSg4A
.

Perfect! Good job!


Update version: Anaconda.Anaconda3 version 2023.09

Pull request has been created with WinGet Automation 🪟📦🤖
Microsoft Reviewers: Open in CodeFlow

Manual Validation began at 11:58 AM (about 3.5 hours ago) and continues.


Programmatic Usage Freezes

I'm currently using mocha as described here. However it seems that I can not execute the runner recursively. The program freezes instead of running the "inner" instance of Mocha.
Does the runner enforce a lock somehow?
Help is much appreciated! Thank you, L~

Could you provide example code to let us understand what your problem is.

After further investigation it seems that I can not spawn a grunt task while running tests programmatically. I will try to provide a minimal test case over the weekend.

Thank you for the quick reply. This seems to have been an issue with grunt. After removing the test runner everything works fine. Cheers, L~


chore(deps): update dependency react-native-screens to v3

This PR contains the following updates:

Package
Type
Update
Change

react-native-screens
dependencies
major
^1.0.0-alpha.23 -> ^3.0.0

Release Notes

software-mansion/react-native-screens
v3.17.0
Compare Source
Minor release fixing bugs, including #1565  🎉
:bug: Bug fixes

Fallback to default behaviour when fragment not found by @kkafar in https://github.com/software-mansion/react-native-screens/pull/1566
Use angle-bracket imports by @tomekzaw in https://github.com/software-mansion/react-native-screens/pull/1572

:1234: Miscellaneous

Remove redundant packages directory with nightly screens version by @kkafar in https://github.com/software-mansion/react-native-screens/pull/1564
Update issue template by @kkafar in https://github.com/software-mansion/react-native-screens/pull/1569
Upgrade iOS CI runner image by @tomekzaw in https://github.com/software-mansion/react-native-screens/pull/1571

New Contributors

@tomekzaw made their first contribution in https://github.com/software-mansion/react-native-screens/pull/1572

:raised_hands: Thank you for your contributions!
Full Changelog: https://github.com/software-mansion/react-native-screens/compare/3.16.0...3.17.0
v3.16.0
Compare Source
Minor release fixing cooperation of gesture recognisers & modals, fixing bugs and adding some new features 🎉
:bug: Bug fixes

Reject all gestures when modal is presented by @kkafar in https://github.com/software-mansion/react-native-screens/pull/1524
Fix invalid dismissCount value when closing modals by @kkafar in https://github.com/software-mansion/react-native-screens/pull/1531
Set VCs of views from recycling pool as UIAdaptivePresentationControllerDelegate by @kkafar in https://github.com/software-mansion/react-native-screens/pull/1535
Manually enable device orientation notifications by @kkafar in https://github.com/software-mansion/react-native-screens/pull/1543
Fix invalid header background colour  by @kkafar in https://github.com/software-mansion/react-native-screens/pull/1560
Remove explicit folly version by @kacperkapusciak in https://github.com/software-mansion/react-native-screens/pull/1549
Wrap Screen with ScreenContext by @kacperkapusciak in https://github.com/software-mansion/react-native-screens/pull/1539

:+1: Improvements

Restore working events on Android by @WoLewicki in https://github.com/software-mansion/react-native-screens/pull/1519
Update Supported React Native Versions Table in ReadMe by @shaneboyar in https://github.com/software-mansion/react-native-screens/pull/1528
Add freezeOnBlur prop to enable/disable freeze per navigator & per screen by @janicduplessis in https://github.com/software-mansion/react-native-screens/pull/1538
Handle React Native loaded on Fragment by @kkafar in https://github.com/software-mansion/react-native-screens/pull/1553
Throw error when failed to find fragment for react root view by @kkafar in https://github.com/software-mansion/react-native-screens/pull/1562
Avoid unnecessary struct copying in iOS code by @kkafar in https://github.com/software-mansion/react-native-screens/pull/1534

:1234: Miscellaneous

Drop React Native 0.62, 0.63 since 3.14.0 by @kkafar in https://github.com/software-mansion/react-native-screens/pull/1533
Fix typo subivew by @hermanbanken in https://github.com/software-mansion/react-native-screens/pull/1536
Update issue template by @kacperkapusciak in https://github.com/software-mansion/react-native-screens/pull/1552
Add freezeOnBlur to READMEs by @kacperkapusciak in https://github.com/software-mansion/react-native-screens/pull/1559

New Contributors

@shaneboyar made their first contribution in https://github.com/software-mansion/react-native-screens/pull/1528
@hermanbanken made their first contribution in https://github.com/software-mansion/react-native-screens/pull/1536

:raised_hands: Thank you for your contributions!
Full Changelog: https://github.com/software-mansion/react-native-screens/compare/3.15.0...3.16.0
v3.15.0
Compare Source
Minor release focused mostly on resolving issues with gesture recognition and its integration with ScrollView on iOS (Fabric & Paper)
:bug: Bug fixes

Handle multiple gesture recognizers by @kkafar in https://github.com/software-mansion/react-native-screens/pull/1512
Update import for case-sensitive file systems by @hirbod in https://github.com/software-mansion/react-native-screens/pull/1517
Add usage of older UIGestureRecognizerDelegate API for older iOS versions by @kkafar in https://github.com/software-mansion/react-native-screens/pull/1516
Get properties from top-most screen on swipe by @kacperkapusciak in https://github.com/software-mansion/react-native-screens/pull/1509
Take top stack view child from reactSubviews in gesture recogniction logic by @kkafar in https://github.com/software-mansion/react-native-screens/pull/1521

:+1: Improvements

Use ViewCompat for status bar translucency management by @kirillzyusko in https://github.com/software-mansion/react-native-screens/pull/1513

:1234: Miscellaneous

Format android code by @kacperkapusciak in https://github.com/software-mansion/react-native-screens/pull/1508
Fix CI by @kkafar in https://github.com/software-mansion/react-native-screens/pull/1503
Remove checks for Fabric that did not work by @WoLewicki in https://github.com/software-mansion/react-native-screens/pull/1518

New Contributors

@hirbod made their first contribution in https://github.com/software-mansion/react-native-screens/pull/1517

:raised_hands: Thank you for your contributions!
Full Changelog: https://github.com/software-mansion/react-native-screens/compare/3.14.1...3.15.0
v3.14.1
Compare Source
Patch release fixing bug which caused gestureResponseDistance Screen prop to not work properly, when the component was not created via react-native-screens native stack. See: https://github.com/software-mansion/react-native-screens/pull/1507 for changes.
v3.14.0
Compare Source
Minor release fixing bugs, introducing better support for Fabric (iOS), compatibility with react-native 0.69
Moreover, from this release forward, Fabric is supported only for react-native 0.69+. Support for 0.68.x is dropped.
:bug: Bug fixes

Remove processColor by @WoLewicki in https://github.com/software-mansion/react-native-screens/pull/1367
Fix edge swipe (interactive pop) gesture recognition by @radex in https://github.com/software-mansion/react-native-screens/pull/1370
Add check for if container is null by @WoLewicki in https://github.com/software-mansion/react-native-screens/pull/1375
iOS Fabric snapshotting mechanism by @kacperkapusciak in https://github.com/software-mansion/react-native-screens/pull/1357
Add ndkVersion to Android project by @maximzhemerenko in https://github.com/software-mansion/react-native-screens/pull/1411
BlurView integration with ScreenStack by @WoLewicki in https://github.com/software-mansion/react-native-screens/pull/1406
Check ios version for home indicator hiding by @WoLewicki in https://github.com/software-mansion/react-native-screens/pull/1423
Add better fabric_enabled check by @WoLewicki in https://github.com/software-mansion/react-native-screens/pull/1448
Fix bad initial frame position by @kkafar in https://github.com/software-mansion/react-native-screens/pull/1463
Fix various Fabric issues by @WoLewicki in https://github.com/software-mansion/react-native-screens/pull/1485
hideHeaderIfNecessary for Fabric by @kkafar in https://github.com/software-mansion/react-native-screens/pull/1491
Reset values after animations and make snapshot only when necessary by @WoLewicki in https://github.com/software-mansion/react-native-screens/pull/1496

:+1: Improvements

Add gesture response distance by @WoLewicki in https://github.com/software-mansion/react-native-screens/pull/1296
Add Screen props: fullScreenSwipeEnabled (1) by @kkafar in https://github.com/software-mansion/react-native-screens/pull/1362
Add Screen props: Window traits (2) by @kkafar in https://github.com/software-mansion/react-native-screens/pull/1363
Add Screen props: stackPresentation & stackAnimation (4) by @kkafar in https://github.com/software-mansion/react-native-screens/pull/1365
Add iOS search bar tint color by @gorbypark in https://github.com/software-mansion/react-native-screens/pull/1407
Add prop for hiding keyboard on swipe by @WoLewicki in https://github.com/software-mansion/react-native-screens/pull/1419
Add missing props & unify business logic between archs by @kkafar in https://github.com/software-mansion/react-native-screens/pull/1430
Add missing Screen prop: swipeDirection by @kkafar in https://github.com/software-mansion/react-native-screens/pull/1461
Bring Fabric to ScreenContainer component by @kkafar in https://github.com/software-mansion/react-native-screens/pull/1458
Implement onFinishTransitioning event for ScreenStack for Fabric by @kkafar in https://github.com/software-mansion/react-native-screens/pull/1471
Bring Fabric to SearchBar by @kkafar in https://github.com/software-mansion/react-native-screens/pull/1470
Implement onTransitionProgress event for Screen for Fabric by @kkafar in https://github.com/software-mansion/react-native-screens/pull/1472
Add FullWindowOverlay component for Fabric by @kkafar in https://github.com/software-mansion/react-native-screens/pull/1495

:1234: Miscellaneous

Use c++17 for fabric on iOS by @janicduplessis in https://github.com/software-mansion/react-native-screens/pull/1360
Update README.md by @dsokal in https://github.com/software-mansion/react-native-screens/pull/1368
Setup for FabricTestExample app by @kkafar in https://github.com/software-mansion/react-native-screens/pull/1371
Merge Fabric & Paper impls: ScreenView & ScreenController (1) by @kkafar in https://github.com/software-mansion/react-native-screens/pull/1415
Merge Fabric & Paper impls: ScreenStack (2) by @kkafar in https://github.com/software-mansion/react-native-screens/pull/1416
Merge Fabric & Paper impls: ScreenStackHeaderConfig (3) by @kkafar in https://github.com/software-mansion/react-native-screens/pull/1417
Merge Fabric & Paper impls: ScreenStackHeaderSubview (4) by @kkafar in https://github.com/software-mansion/react-native-screens/pull/1418
Use recommended WindowInsetsControllerCompat for StatusBar management by @kirillzyusko in https://github.com/software-mansion/react-native-screens/pull/1451
Add .mm files to lint-staged by @WoLewicki in https://github.com/software-mansion/react-native-screens/pull/1462
Bump react-native version to 0.69.0 by @kkafar in https://github.com/software-mansion/react-native-screens/pull/1484
Remove dependency on react-navigation@v4 & unify test example apps by @kkafar in https://github.com/software-mansion/react-native-screens/pull/1492

:raised_hands: Thank you for your contributions!
Full Changelog: https://github.com/software-mansion/react-native-screens/compare/3.13.1...3.14.0
v3.13.1
Compare Source
Patch release adding https://github.com/software-mansion/react-native-screens/pull/1351 that suppresses Function components cannot be given refs. Attempts to access this ref will fail warning on Fabric architecture.
v3.13.0
Compare Source
Minor release fixing bugs, improving typings, and adding some functionalities 🎉
:bug: Bug fixes

resetViewToScreen on prepareToRecycle (#1339) by @kacperkapusciak
fix fast ios modal push (#1326) by @WoLewicki
remove react-native-gradle-plugin from dependencies (#1346) by @kacperkapusciak and @tido64
apply initial navigation bar color (#1344) by @burakgormek

:+1: Improvements

add stack nesting on Fabric (#1343) by @kacperkapusciak

:1234: Miscellaneous

bump TestsExample/ to react-native 0.68rc1 (#1316) by @kacperkapusciak
update react-native-safe-area-context to fabric compatible version (#1333) by @janicduplessis
remove patch-package from FabricExample (#1335) by @kacperkapusciak
add cache-dependency-path on Android (#1336) by @kacperkapusciak

:raised_hands: Thank you for your contributions!
v3.12.0
Compare Source
This minor release includes initial support for Fabric architecture 🎉
To learn about what we've achieved so far check out our Introducing Fabric to React Native Screens blog post.
Changes:

Add Fabric example app (#1261) by @Ubax
Publish Fabric and classic architecture release (#1308) by @Ubax
Add test build Fabric workflows (#1321) by @kacperkapusciak and @Ubax
Fix headerTitle & title props (#1320) by @kacperkapusciak
Remove enableFabric requirement (#1319) by @Ubax
Remove additional config steps required when running Fabric version on Android (#1322) by @kmagiera
Fix Android props on Paper (#1325) by @Ubax
Reword sentences in Fabric section (#1327) by @kacperkapusciak
Cleanup build process for pre-codegen versions of react-native (#1328) by @kmagiera

v3.11.1
Compare Source
Patch release adding https://github.com/software-mansion/react-native-screens/pull/1313 that fixes incorrect swipe direction default.
v3.11.0
Compare Source
Minor release fixing bugs, improving typings, and adding some functionalities 🎉
:bug: Bug fixes

remove nullability from CustomSearchView (#1233) bu @Ubax
add inputType to setOptions call (#1234) by @kacperkapusciak
update header in vc below modal (#1228) by @WoLewicki
replaced jCenter with maven (#1245) by @matteodanelli
add directory so /reanimated works outside of repo (#1294) by @WoLewicki
incorrect prop descriptions in types.tsx (#1298) by @Ubax
change Activity to extend to ReactActivity (#1303) by @WoLewicki

:+1: Improvements

add new properties to search view (#1250) by @rvasseur31
add home indicator hiding (#1267) by @WoLewicki
remove system animations on Android (#1213) by @WoLewicki
add android navigation bar manipulation (#1264) by @WoLewicki
add transition duration on iOS (#1259) by @WoLewicki & @kacperkapusciak
add swipe direction on iOS (#1260) by @WoLewicki
simplify fade_from_bottom transition duration code (#1307) by @kacperkapusciak

:1234: Miscellaneous

update search bar playground in Example app (#1226) by @kacperkapusciak
rename master occurences to main (#1235) by @kacperkapusciak
unify links in the documentation (#1236) by @kacperkapusciak
add sponsor logo (7efa269) by @kmagiera
add swmansion-bot (#1253) by @kacperkapusciak
make bot responses shorter (#1258) by @kacperkapusciak
update PULL_REQUEST_TEMPLATE.md (e71c279) by @WoLewicki
bump nanoid to 3.2.0 (#1283)
fix search bar only for iOS (#1295) by @WoLewicki
add onScroll triggered to common problems (#1302) by @WoLewicki

:raised_hands: Thank you for your contributions!
v3.10.2
Compare Source
Patch release adding https://github.com/software-mansion/react-native-screens/pull/1245 that removes the use of jcenter() in the library
v3.10.1
Compare Source
Patch release adding #1233 for usage in Expo SDK.
v3.10.0
Compare Source
Minor release fixing bugs, improving typings, and adding some functionalities 🎉
:bug: Bug fixes

Turn off accessibility for screen and header beneath transparent modal on Android (#1205) by @kacperkapusciak
Check if jsThread is not null (#1217) by @WoLewicki
Make stack animations work the same on both platforms (#1190) by @WoLewicki
Fix Android keyboard with autofocus (#1214) by @WoLewicki
Disable freeze for first render (#1220) by @kacperkapusciak and @kmagiera
Check if topScreen is RNSScreenView (#1224) by @WoLewicki
Use shouldUseOpenAnimation to determine animation (#1227) by @WoLewicki and @kacperkapusciak

:+1: Improvements

Add search bar on Android (#1166) by @Ubax
Don't set display: 'none' on frozen screens (#1208) by @kacperkapusciak and @grahammendick

:1234: Miscellaneous

Add kotlin guide to change version (#1185) by @kacperkapusciak
Update required react-native version (#1200) by @kacperkapusciak
Add eslint hook plugin and fixes hooks errors (#1199) by @Ubax

:raised_hands: Thank you for your contributions!
v3.9.0
Compare Source
Minor release fixing bugs, improving typings, and adding some functionalities 🎉
:bug: Bug fixes

Ensure topscreen's null safety in ScreenStack (#1165) by @kacperkapusciak
Fix header translucent change on iOS (#1162) by @Ubax
Remove touch disabling in header corners (#1157) by @WoLewicki
Adds dispatch for hiding header (#1153) by @Ubax
Remove LifecycleHelper from npm package (#1175) by @kacperkapusciak
Add isDestroyed fragmentManager check (#1184) by @jakmak24
Commit remove and add separately in moveToFront (#1133) by @WoLewicki
Using useEffect to manage searchbar crashes app (#1192) by @kacperkapusciak

:+1: Improvements

Add scheduling update for Layout Animations (#1167) by @WoLewicki
Add experimental support for react-freeze (#1195) by @kmagiera and @kacperkapusciak

:1234: Miscellaneous

Update bug-report template (#1161) by @kacperkapusciak
Add mavenCentral in TVOSExample (#1164) by @luancurti
Bump Example and TestsExample proj to react-native 0.66 (#1134) by @kacperkapusciak
Adds common problems section to README (#1156) by @Ubax
Fix iOS e2e test (#1193) by @kacperkapusciak

:raised_hands: Thank you for your contributions!
v3.8.0
Compare Source
Minor release with important bug fixes 🎉
:bug: Bug fixes

Apply spotless conditionally (#1119) by @kacperkapusciak
Context is never null (#1127) by @cruzach
Enable desugaring of java 8 bytecode (#1135) by @kacperkapusciak
Downgrade kotlin & take kotlinVersion from ext (#1130) by @kacperkapusciak
Remove adding to back stack logic on Android (#1148) by @WoLewicki
Canceled swipe gesture on iOS 12 when direction hasn't changed (#1150) by @kacperkapusciak
Add hasTwoStates iOS check (#1151) by @burakgormek

:1234: Miscellaneous

Add supported platforms info (#1117) by @kacperkapusciak
Add simple e2e tests (#1106) by @Ubax
Add e2e github action (#1107) by @Ubax
Change concurrency group name (#1128) by @Ubax
Change concurency group name for tv os (#1129) by @Ubax
Add e2e testing on GitHub action for Android (#1126) by @Ubax
Add screenshot artifact to iOS e2e (#1139) by @Ubax
Make method for checking if trait is set (#1155) by @WoLewicki

For library authors, #1148 may be considered a BREAKING CHANGE. From now on you'll need to implement your own logic for the hardware back button on Android same as it is done in react-navigation.
:raised_hands: Thank you for your contributions!
v3.7.2
Compare Source
Patch release adding #1127 for usage in Expo SDK.
v3.7.1
Compare Source
Patch release adding #1119 for usage in Expo SDK.
v3.7.0
Compare Source
Minor release fixing bugs, improving typings, and adding some functionalities 🎉
:bug: Bug fixes

Send progress when container is null (#1074) by @WoLewicki
Bring back transition progress in simple animations (#1100) by @kacperkapusciak
Add jcenter() to build.gradle back (#1101) by @kacperkapusciak
Fix react-native-screens build on Windows (#1098) by @asklar
Changes fragment commit to synchronous (#1066) by @WoLewicki, @Ubax, @Szymon20000 and @anirudhagarwal365
Make search bar appear on iOS 12 (#1115) by @WoLewicki
Delay ScreenContainer updates in same manner as ScreenStack (#1116) by @WoLewicki

:+1: Improvements

Expose transition progress (#890) by @WoLewicki
Add option for custom swipe animation (#1084) by @WoLewicki
Add full-width swipe option (#1072) by @WoLewicki and @kacperkapusciak
Expose new container for 2-state navigators (#1029) by @WoLewicki
Add cancel button text (#1108) by @WoLewicki
Provide a way to prevent native navigation (#801) by @WoLewicki and @kacperkapusciak
Move react-native-window-view to screens package (#1096) by @WoLewicki

:1234: Miscellaneous

Restore deleted tests and update TestsExample (#1073) by @WoLewicki
Add app icons to Example & TestsExample apps (#1088) by @kacperkapusciak
Add possibility to run CI builds manually (#1095) by @kacperkapusciak
Switch ktlint for spotless (#1093) by @kacperkapusciak
Adds detox (#1102) by @Ubax
Add splash screens (#1099) by @kacperkapusciak
Prepare repo for Apple Silicon (#1094) by @kacperkapusciak

Be aware that #801 may be considered a BREAKING CHANGE if you relied on the default header back button native dismissal. It can be switched by setting nativeBackButtonDismissalEnabled: true on the screen.
Also, be aware that using fullScreenSwipeEnabled option (#1072) with gestureEnabled set to true will cancel JS recognizers on the screen when using vertical or horizontal swipe gestures.
:raised_hands: Thank you for your contributions!
v3.6.0
Compare Source
Minor release fixing bugs, improving typings, and adding some functionalities 🎉
:bug: Bug fixes

Fix Search bar returns to an incorrect position after losing focus (#1036) by @Ubax
Fix typo in method name for TV-OS (#1040) by @Ubax
Add windows Directory to NPM Publish (#1050) by @chiaramooney

:+1: Improvements

Add v5 implementation of header height context (#1031) by @WoLewicki

:1234: Miscellaneous

Convert Java to Kotlin (#1042) by @kacperkapusciak and @WoLewicki
Enforce null safety in Kotlin files (#1059) by @WoLewicki
No exception while using flip animation on Android (#1068) by @kacperkapusciak
Warn when using native-stack from react-native-screens in v6 (#1058) by @kacperkapusciak
Example projects clean-up (#1033) by @kacperkapusciak
Add information about react-navigation v6 (#1037) by @kacperkapusciak
Add TV Example App (#1054) by @Ubax
Format Example project on commit (#1038) by @kacperkapusciak
Add build checks (#1055) by @Ubax
Improves CI checks (#1065) by @Ubax
Bump react-native version to 0.65.1 (#1067) by @kacperkapusciak

:raised_hands: Thank you for your contributions!
v3.5.0
Compare Source
Minor release fixing bugs, improving typings, and adding some functionalities 🎉
:bug: Bug fixes

Fix tvOS compiling (#988) by @WoLewicki
Fix back button in push replace animation (#999) by @WoLewicki
Fix no animation in nested stacks (#1012) by @WoLewicki
Access to PixelUtil.toPixelFromDIP when it is necessary (#1016) by @sercand
Fix touch event canceled with gesture disabled (#1032) by @Ubax

:+1: Improvements

Add slide_from_bottom & fade_from_bottom animations (#848) by @itsjgf, @kacperkapusciak and @WoLewicki
Add initial react-native-windows C++ implementation (#989) by @tritao

:1234: Miscellaneous

Reformat native code (#987) by @WoLewicki
Add linting and formating to windows implementation (#1009) by @WoLewicki
Clean up event dispatching on Android (#1014) by @WoLewicki

:raised_hands: Thank you for your contributions!
v3.4.0
Compare Source
Minor release fixing bugs, improving typings, and adding some functionalities 🎉
:bug: Bug fixes

No events when swipe cancelled (#951) by @WoLewicki
Don't warn about header if prop not changed (#965) by @WoLewicki
Revert async container update (#986) @WoLewicki
Make sure to only call onDetachedFromWindow once (#985) by @WoLewicki

:+1: Improvements

Add search field color (#961) @WoLewicki

:1234: Miscellaneous

Deprecate appear event (#949) by @kacperkapusciak
Remove buildToolsVersion (#956) by @dulmandakh
Bump react-native version to 0.64.2 (#975) @kacperkapusciak
Remove enableScreens from example app (#974) by @kacperkapusciak

:raised_hands: Thank you for your contributions!
v3.3.0
Compare Source
Minor release fixing bugs, improving typings, and adding some functionalities. 🎉
:bug: Bug fixes

Add missing dependency on React-RCTImage pod. (#934) by @markwilcox
Make events dispatch in the correct order (#941) by @WoLewicki
Fix iOS 14 back button menu (#830) by @WoLewicki

:+1: Improvements

Add simple push/pop transition on ios (#761) by @WoLewicki
Add status bar manipulation on Android (#863) by @WoLewicki and @kacperkapusciak
Add slide_from_bottom animation on iOS (#779) by @WoLewicki

:1234: Miscellaneous

Update searchBar example (#925) by @JB1905
Add CONTRIBUTING guide (#940) by @kacperkapusciak
Update Animations example (#948) by @kacperkapusciak

:raised_hands: Thank you for your contributions!
v3.2.0
Compare Source
Minor release fixing bugs, improving typings, and adding some functionalities. 🎉
:bug: Bug fixes

Properly handle first screen on stack (#882) by @kacperkapusciak and @owinter86
Fix broken layout for header subviews in iOS (#902) by @abram

:+1: Improvements

Add iOS search bar (#758) by @WoLewicki and @kacperkapusciak
Add headers to modal (#821) by @WoLewicki

:1234: Miscellaneous

Update READMEs and package.json (#891) by @WoLewicki and @kacperkapusciak
Add react-native-reanimated v2 to TestsExample (#898) by @WoLewicki
Add branded header image to README (#917) by @jkadamczyk
Bump react-native to 0.64.1 (#916) @kacperkapusciak
Remove check for screens enabled in native stack (#922) by @WoLewicki
Add headerShown check in modals in Example (#924) by @kacperkapusciak

Be aware that [#821](https://togithub.com/software-man

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by Renovate Bot.

⚠ Artifact update problem
Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.
♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

any of the package files in this branch needs updating, or
the branch becomes conflicted, or
you click the rebase/retry checkbox if found above, or
you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:
File name: example/yarn.lock
error An unexpected error occurred<EMAIL_ADDRESS>connect ECONNREFUSED <IP_ADDRESS>:4873".


Fail to build with android Gradle 7.X

This is a very cool library that helps me a lot.
I can build and run smoothly in iOS, but not in Android.
even I followed the readme to add the local.properties
May I have some hints on building the android with higher version Gradle like 7.x?

I am sorry to tell you, but I never finished the android support :/


Refactor AdaptiveColumnBuilder to support further column types

The AdaptiveColumnBuilder is currently implemented to decide the use of a RleColumn vs a VectorColumn based on the data that the AdaptiveColumnBuilder receives.
The current solution may not be suitable when further column types shall be supported.
This issue provides a place for discussion on refactoring possibilities. Some discussion also already happened in #8.
Once a decision is made, the implementation can happen in the scope of this issue.
Maybe, it is worthwhile to postpone the discussion until another column type is actually to be supported by the AdaptiveColumnBuilder. In this sense the issues acts as a mere reminder.

In light of #166 and #167, is this still open?

I think this issue may only become relevant when we add another column type besides Rle and Vec.
I'd say, we can close this one. If there will be another column type, we will have an issue for that one anyway where we can also handle this problem.


-[TTTAttributedLabel characterIndexAtPoint:] crashes

I am getting intermittent crashes (Unknown signal error) when clicking on TTTAttributedLabel. The problem line:
CTLineRef line = CFArrayGetValueAtIndex(lines, lineIndex);

I have confirmed crashes on iPhone 4 and iPhone 3GS with iOS 5.0.1.

As temporarily workaround I've added this guard before the call:
if (lineIndex >= numberOfLines) {
  return NSNotFound;
}

Looks like the problem in some non-alphabetic Unicode characters at string like "☮".


Template review feedback

Thanks for submitting a template to the gallery, there were a few issues in your template that needed to be resolved ahead of approving the template for the gallery.

User instructions to install the template should direct users to install the gallery version of the template by clicking on the "Search Gallery" button in the template tab to add the gallery template.

Hello!
I updated the user instructions and now I direct users to install the version found in the GTM Template Gallery.
Thank you!

Hello!
I updated the user instructions and now I direct users to install the version found in the GTM Template Gallery.
Thank you!


Proposal for .takeWhen

This is a proposal to add .takeWhen and .skipWhen methods.
I had a requirement where I needed to poll a service and then take the response only when a specific property of the response was equal to a term.  .takeWhile gave me all the responses up to the last.  .skipWhile gave me the last response and then kept calling.  I ended up using a combination of .skipWhile().take(1).  Essentially, .takeWhen(true) will mimic .skipWhile(true).take(1)

.skipWhen will be the inverse of that. Essentially the observable will pass the response only when .skipWhen(false)

with let and new pipe-able operator structure introduce in 5.5, we are recommding creating new operator as user-level one (https://github.com/ReactiveX/rxjs/blob/master/doc/operator-creation.md#publish-your-operator-as-a-separate-library) for now. Core team is discussing about processes of pick / removing core level operator as separate topic.

This should be a trivial implementation of filter:

const takeWhen = value => source => source.filter(v => v === value);
const skipWhen = value => source => source.filter(v => v !== value);

For whatever reason, filter isn't working for me the way I want it. But I do agree that what I've described is a filter behavior.


Add unzip package

It is quite common that packages are distributed in .zip instead of tar.gz.
I suggest to add unzip package to buildpack-deps.
ubuntu unzip package size is around 600KB which is small.

It's already included:
https://github.com/docker-library/buildpack-deps/blob/b26561e02c96fc42c9001edc1ecb1c4477fbab90/Dockerfile.template#L45

Oh! buildpack-deps:focal-scm does not have that but buildpack-deps:focal already has that.


Rework the internal flow of the config options

The configuration of mavlink-router has to be merged from config file(s) and CLI options. Previously the config file was parsed to one set of structs, passed to a function as a set of parameters (instead of the full struct), which converted the options to another config structure collecting a list of endpoints, which was finally used to actually create the endpoints. I think having two config structs is quite confusing and overly complicated.
This PR reworks the internal flow of the configuration parameters to be like this:

Parse config file(s) and CLI options to one struct per endpoint type (UDP, TCP, UART and Log)
Have a single config struct with the full, merged configuration (global options + one list of endpoints per type), which is properly owned by the main function instead of a global variable
Mainloop still creates the actual endpoint instances from the single configuration
Pass a full struct instead of multiple parameters to methods, where possible.
This leads to less parameters and therefore makes future extensions easier.

Additional changes:

Fixed (and extended) some log messages
Move config file option tables to be owned by the endpoints instead of the main.cpp
Rework the mainloop to only use one list of endpoints (instead of one for TCP + and another for everything else)
Make use of std::vector instead of home-grown concatenated lists (easier to read/ understand and less error-prone when being extended)
Configuration validation is a static method of each endpoint now instead of being scattered around multiple places in the main.cpp
Endpoint setup is mainly done with one method and the config struct instead of multiple setters now

Sorry to have so many things in one PR, but they are closely related.

Overall looks good to me and makes the code much cleaner. Thanks.

The last commit (moving the TCP client reconnect handling to the TcpEndpoint class) also fixes some issue with the TCP endpoints. When a client connected to the TCP server while a TCP client endpoint was trying to reconnect, the TCPEndpoint's IP and port got lost somehow. I think it had something to do with the TcpEndpoint not being added to the endpoints list when the remote side wasn't available during the first connection attempt. But it works now, so the actual reason it not so important.


New version: GadgetIO v0.7.0

Registering package: GadgetIO
Repository: https://github.com/LudwigBoess/GadgetIO.jl
Created by: @LudwigBoess
Version: v0.7.0
Commit: ace4c5cbf975052f1a43fccf18ed526f130f030a
Reviewed by: @LudwigBoess
Reference: https://github.com/LudwigBoess/GadgetIO.jl/commit/ace4c5cbf975052f1a43fccf18ed526f130f030a#commitcomment-91908857
Description: Binary IO for the cosmological Tree-SPH code Gadget

wait for doc fix


The archivechannel command does not sync channel permissions with the Archive category

This looks somewhat more complicated to implement than at first blush.
To sync channel permissions, you simply set the permissions to be the same as the parent category. When permissions are the same, changes to the parent category change all sync'd channels.
To change channel permissions, there is a 'delete_permission' and 'create_permission' api endpoint. There is no API equivalent to the "sync channel permissions" button as far as I can tell. This creates an issue where if the bot fails in the middle of doing this, then the permissions would be 'halfway' inbetween the two. Also, it may briefly change the permissions to be undesireable (a naive implementation would delete all permissions, allowing everyone to view by default) and discord api calls can reasonably take 4 or 5 seconds if they're feeling sluggish.
Furthermore, this creates an unintuitive situation where archiving a channel can make it more permissive, since the permissions have to be exactly the same.
Isn't the real desire here to disallow sending messages in archived channels? This could be achieved by simply setting deny send messages on all permission sets, and the state of the send messages permission beforehand can be stored in the database for later un-archiving.
This still leaves the issue of failure halfway through, however such a failure leaves the permissions somewhere between the same state and a more restrictive state. The row for archive/unarchive could have a 'finished' column and retry the operation if that is false, or something like that.

Additionaly, the bot is not able to set any permissions it does not have itself, among other restrictions:
https://discordapp.com/developers/docs/topics/permissions#permission-hierarchy

Side note:

How permissions apply may at first seem intuitive, but ...

When you need a comment explaining that something that might seem intuitive is in fact not, you need to reconsider life choices SMH


Godot crashing after a few moments in the editor.

Godot version
4.1.1 from steam and from the website
System information
Windows 10 (foraward+) gpu: Intel UHD Graphics
Issue description
Hello.
I have tried to start a new project and faced a concerning issue.
every time i open the project or any other project, Godot becomes unresponsive and crashes after a bit.
Happened both on the Steam version and the website version. I have checked the integrity of the files, they were fine.
I did clear the cache and the editor worked for a bit but then crashed again.
Steps to reproduce
open the project and let it run for a few moments.
Minimal reproduction project
prototype.zip

I can't reproduce the bug. Please run the editor from command line, reproduce the crash, and post the crash dump here. This will greatly simplify finding and fixing the bug.
Note that you need a build with debug symbols. See the docs or Calinou/godot-debug-builds (but it not updated from 4.0.3, which may not have the bug).

Seems like a graphics issue.
Godot Engine v4.1.1.stable.official.bd6af8e0e - https://godotengine.org
OpenGL API 3.3.0 - Build <IP_ADDRESS>5 - Compatibility - Using Device: Intel - Intel(R) UHD Graphics

Editing project: C:/Users/Sato/Documents/prototypes
Godot Engine v4.1.1.stable.official.bd6af8e0e - https://godotengine.org
Vulkan API 1.3.215 - Forward+ - Using Vulkan Device #0: Intel - Intel(R) UHD Graphics

WARNING: Blend file import is enabled in the project settings, but no Blender path is configured in the editor settings. Blend files will not be imported.
     at: _editor_init (modules/gltf/register_types.cpp:73)
ERROR: Vulkan: Cannot submit graphics queue. Error code: VK_ERROR_DEVICE_LOST
   at: (drivers/vulkan/vulkan_context.cpp:2360)
ERROR: Vulkan: Cannot submit graphics queue. Error code: VK_ERROR_DEVICE_LOST
   at: (drivers/vulkan/vulkan_context.cpp:2360)
ERROR: Vulkan: Cannot submit graphics queue. Error code: VK_ERROR_DEVICE_LOST
   at: (drivers/vulkan/vulkan_context.cpp:2360)

Same error on the 4.0.3 debug build.
I also forgot to mention, before I posted the issue, i tried using the LTS 3.5.2 and had no issues.

Not surprising that 3.5 works since this is a Vulka n problem.

yup

Couldn't replicate this one. Sounds like it might be an issue with your GPU. Can you try updating your drivers?

They are a updated. it might be the new version that is causing the problem...

Please test https://github.com/godotengine/godot/pull/80566 locally and see if it resolves the issue on your end.

#80566 work.

issue seems to be fixed on the stable version on steam.


Add to open-vsx.org

Similar to https://github.com/zigtools/zls-vscode/issues/20
This will help in using gitpod

Can we re-open this issue, as I followed a trail from this issue for the now-deprecated zls-vscode plugin, and on its surface, it seems rather straightforward to add this action to this repo's CI?
I could be wrong, but it doesn't look like this extension is yet published to open-vsx, as the only two I see are from random users and are >2 years old...
I'm happy to help however I can, though I'm not super proficient in GitHub actions, etc; just an interested user trying to improve my VSCodium workflow :)

Hey there 👋, an Open VSX maintainer here. I was just about to mark the tiehuis.zig as deprecated when I stumbled upon this issue.
I will go ahead with the deprecation (because that extension is not updated anymore), but it would be awesome if this repository would publish ziglang.vscode-zig as its de facto successor. If that happened, folks who have the tiehuis.zig extension installed or search for it in VS Code will be instructed to move to the official one instead.
There are some docs we have written as guides that can maybe ease the publishing process here: https://github.com/open-vsx/publish-extensions/blob/master/docs/direct_publish_setup.md
cc @Vexu


fix padding options viewport android

Current version appears to always use 25 for padding on setViewPort method on Android.
This adds ternary to check options.padding and default to 25 if not provided.

Looks good to me 👍
The interface SetViewportOptions already has padding in it so the option should be exposed correctly.
@EddyVerbruggen safe to merge this imo


打开之后确实部分文件缺失，请大牛指点迷津，小白我感激不尽

@YUHG412 thanks for trying Outline. I'm afraid it is a little complicated to build Outline for macOS and iOS - we let Travis perform most of our builds.
Roughly, you'll need to:

follow the steps at https://github.com/Jigsaw-Code/outline-client#apple-macos-and-ios
follow the steps at https://github.com/Jigsaw-Code/outline-client/blob/master/docs/apple-development.md

Also, we've only tested the steps with XCode 9.2.

Closing due to inactivity. @YUHG412  if you'd like to discuss more, please re-open this issue.


[Functionality] Clarify Deed/Legalcode labelling, relationship, and placement on license-page contexts

Problem
Presently the language of "deed" and "legalcode" is output as part of the title styling of the page, and as such causes confusion as visitors may believe that they are part of the license title itself.
So rather than: CC BY-NC-ND 4.0
Individuals might believe the title is instead: CC BY-NC-ND 4.0 DEED or CC BY-NC-ND 4.0 LEGAL CODE.
Description
Current pages:

deed: https://creativecommons.org/licenses/by-nc-nd/4.0/deed.en, uses walkthrough-page context
license: https://creativecommons.org/licenses/by-nc-nd/4.0/legalcode.en, uses default-page context

Legacy versions:

deed: https://web.archive.org/web/20230726193257/https://creativecommons.org/licenses/by-nc-nd/4.0/deed.en
license: https://web.archive.org/web/20230723170747/https://creativecommons.org/licenses/by-nc-nd/4.0/legalcode.en

Alternatives
As deed and legalcode are descriptor "meta info" they should instead be placed elsewhere, and styled differently from the title itself. The previous design did a better job of creating this delineation.
Additional context
The translations strings may present a challenge in trying to create a solution here.
To resolve this item, a working current state context for the deed and legalcode license-page contexts needs to exist to work from. That work is tracked here:

#64

Implementation

[x] I would be interested in implementing this feature.

One possibility
We borrow from an existing descriptor style locally adapted to the "stand out" coloring the header area.
On the search results page we have a post "type" descriptor that is off to the side:

Presently, the "stand out" coloring for the header area, when not a link, would follow what we've done on the person page (white):

So if we combine the descriptor "pill style" with the white "stand out" coloring, we get something like this:
deed:

legal code:

The above could be added by appending a span element around the deed and legal code words.
deed:

CC BY-NC-ND 4.0 Deed

legal code:

CC BY-NC-ND 4.0 Legal Code

And then, the following CSS would provide the styling as show above:

span.descriptor {
    padding: .5em .7em;

    font-family: 'Source Sans Pro';
    font-size: .3em;
    font-weight: 400;
    text-transform: lowercase;
    background: rgb(255, 255, 255);
    border-radius: 4px;
}

Overall, the page contexts for the licenses need some deeper work, but this would possibly correct this issue at the moment visually, while leaving room to address it more elegantly.

For a more stable proposed draft solution, see:

https://github.com/creativecommons/cc-legal-tools-app/pull/455


Error when updating VSCode Insiders from 1.22 to 1.23

VSCode Version: Insiders 1.22
OS Version: Windows 7
vscode-inno-updater.log

Steps to Reproduce:

Check for update
Apply update
Error when update is installed (see attached file for more info)

Does this issue occur when all extensions are disabled?: Yes/No

/duplicate #47804


atob() is incorrectly marked as deprecated.

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version: 1.60.0
OS Version: Windows 7

Steps to Reproduce:

Reference the atob() function in a JavaScript or TypeScript file.
The reference to the function is marked as deprecated, even if only the unintended one of its two overloads is.

The problem is that the two "overloads" are identical in signature, and the deprecated one from node is being picked because it was loaded last. If you’re writing DOM code, you should really try to avoid having node typings in your program, but we are painfully aware this is much easier said than done, and sometimes impossible. You may be able to exclude it via some tsconfig/jsconfig settings, but you may not, depending on your dependencies. You’ll have similar issues with the return type of setTimeout, and we’re just not able to fix that from our end right now. I don’t think we can actually do anything about the deprecated suggestion either, for the same reason 😕

See https://github.com/microsoft/TypeScript/issues/842 for more info. window.atob() is a workaround mentioned there.

I was able to fix by using window.btoa instead of btoa.


implement ck use like

https://github.com/open-cluster-management/cm-cli/issues/32
https://github.com/open-cluster-management/cm-cli/issues/43
Signed-off-by: Dominique Vernier<EMAIL_ADDRESS>

/hold still some doc to add

/unhold

/hold while reviewing comments

/hold to add create cc

/unhold

/hold again

Trying out some of these commands now. I see a missing values template for create cph:
% cm create cph --help
Initialize a clusterpool management cluster

Usage:
  cm create clusterpoolhost [flags]

...

 Values template:
open create/values-template.yaml: file does not exist

@KevinFCormier I will fix that... cm create cph doesn't have a values-template.

/lgtm

/unhold


Add ryanzhang as CoP member

Add ryanzhang as CoP member to resolve #328

/approve
/assign @sabre1041

/lgtm


Add branch and remote deletion option

Currently only branch and remote creation are supported. The reversal of this action needs to be included to the platform.

Feature has been delivered before hand. So switching milestone to the current release

Local branch deletion feature has been added. As remote branch deletion is not a safe option for critical repos, that feature has not been included. Remote branch deletion would be better done within the remote repo service itself

Resolved with commit https://github.com/neel1996/gitconvex-package/commit/2ab32d8af78c894798bee14713ad0fceb598f1a9


Build for target architecture ARM64/aarch64

If possible and not too much work, please supply a build for the ARM64/aarch64 architecture as well. The armv7-unknown-linux-gnueabihf binary doesn't work here, it errors out with -bash: ./dysk: cannot execute: required file not found.
Future ARM generations will be more and more ARM64, so the support of it will be future-proof.
`

Can you check https://github.com/Canop/dysk/pull/63 looks right ?

I looked at the compile-all-targets.sh and this looked good to me. Waiting for the release to see if everything is OK. I can test it on two different systems, so it should work for everyone if it works for me.

I should merge https://github.com/Canop/dysk/pull/64 soon, then make a release with all those binaries

I can confirm that the aarch64 version works at least with two different chips (Amlogic S905X3 and Rockchip RK3568B2).
Looks good.


Fix broken links in comments and doc

I noticed after ejecting that several links currently point to a non-existent facebookincubator/create-inferno-app repo. This PR makes them point to this one instead (where possible) and restores links to issues and pull requests from the upstream repo facebookincubator/create-react-app when needed.

Thank you @stefk


fix: move hyperchain mapping EVM-709

What ❔

Why ❔

Checklist

[ ] PR title corresponds to the body of PR (we generate changelog entries from PRs).
[ ] Tests for the changes have been added / updated.
[ ] Documentation comments have been added / updated.

@kelemeno and also you should include methods for migrating into that mapping

CI was just flaky. I added the migration function, but it requires that we do the migration after the BH is upgraded but before the STM is upgraded.


Saving optimizer state (adagrad/momentum/etc.)

Hey everybody,
Last week I asked this question on stackoverflow: https://stackoverflow.com/questions/40547198/saving-the-state-of-the-adagrad-algorithm-in-tensorflow .
My problem is that I want to save the state of the optimizer (in my case the adagrad accumulators) so I can stop my learning and continue whenever I want.
Unless I'm mistaken the state of the optimizer can't be saved (you cant pass an optimizer to a tf.train.Saver, right?). A quick (hacky?) solution for me might be is calling Optimizer.get_slot_names() and save the op of each slot.
The next problem would be putting this op back in the slots, as I don't think there is a set_slot(name,op) at the moment.
So my questions are:

Am I right that this is currently impossible?
Do we want to have a set_slot(name,op) function in the Optimizer class? (I am willing to help out with this)
Do we want to be able to pass an optimizer to a Saver object?

Thank you for asking the question on stackoverflow, which is a better place for it.  The optimizer state will be saved by default, and is only not saved because you are specifically telling the saver what to save.


Crash on load occasionally

Very rarely the game will crash on loading up a heist. It doesn't happen too often and when it happens it only happened on the first heist after starting up the game.
Application has crashed: access violation Current thread: Main Script stack:                                 @mods/BeardLib/Hooks/CoreSystem.lua:24                                           ()  =(tail                                                                     call):-1                                                       core/lib/utils/dev/editor/coreworlddefinition.lua:864  ()                                                                           =(tail  call):-1                                                                   create()  core/lib/utils/dev/editor/coreworlddefinition.lua:480                   create_world()  core/lib/utils/dev/editor/worldholder.lua:110                           init_game()  lib/setups/gamesetup.lua:458                                                         core/lib/setups/coresetup.lua:394                                                ()  =(tail                                                                     call):-1

https://github.com/GreatBigBushyBeard/PAYDAY-2-BeardLib/wiki/What-is-BeardLib%3F#my-game-is-crashing-and-the-script-stack-says-modsbeardlibhookscoresystemlua-lxx


Move DG UMCI tests to separate process

Some DG UMCI tests affect other test runs, because these tests modify system lock down and language mode of the current PowerShell session.  These tests should be moved so that they run in their own process.
Microsoft.PowerShell.Security\ConstrainedLanguageDebugger.Tests.ps1
Microsoft.PowerShell.Security\ConstrainedLanguageModules.Tests.ps1
Microsoft.PowerShell.Security\ConstrainedLanguageRestriction.Tests.ps1
Microsoft.PowerShell.Security\ConstrainedLanguageValidation.Tests.ps1

After this is done, re-enable the -pending tests in Modules/Microsoft.PowerShell.Utility/Implicit.Remoting.Tests.ps1

We could assign a special Pester tag for the tests.

@PaulHigin Is the issue still actual?

@PaulHigin Is the issue still actual?


Adding client.json keepalive/safe_mode attributes + dir/file permission fixes + CentOS 5 gpgcheck disable

adding client.json additions for safe_mode, keepalive attributes
setting CentOS/RH 5 legacy repositories gpgcheck to disabled
fixing dir/file permissions, redis should not be world readable it can contain a password

This looks legit! Could you add some details to the CHANGELOG as well to make my life when cutting the release easier? We have some docs on how we changelog here: https://github.com/sensu-plugins/community/blob/master/HOW_WE_CHANGELOG.md
Thanks so much for the PR!

I’ll work in getting a changelog uodate this weenend.

Ok, added some updates to the CHANGELOG and rebased off the latest master merges.


Added EC to Data Sources and Partners

I changed to 'Time Series' to be consistent with the labels in the rest of the app.

:shipit:


DS-2403: Resolves DS-2403 and reduce logging of RDFConsumer.

+1 While I haven't tested this directly, the code changes look minor (mostly log.debug statements). So this seems like something that can just be merged once Travis comes back successful.

+1


Deprecate use of ez_setup.py in user packages

Originally reported by: jaraco (Bitbucket: jaraco, GitHub: jaraco)

In the early days of setuptools, when adoption was small, it made sense for package managers to give users an easy way to include setuptools in the installation, so that the packages themselves could depend on setuptools being present for the features supplied by setuptools.
Today, installation of setuptools is largely a given and can be considered an implicit requirement.
I'd like to officially deprecate the recommendation for packages to include ez_setup.py in their packages.

Bitbucket: https://bitbucket.org/pypa/setuptools/issue/286

I see only two references to this in the documentation, this one, which is deprecated in the documentation and this one, which is under "Easy Install", and that whole page is listed as deprecated.
I'm going to close this, but @jaraco feel free to re-open it if you feel more action needs to be taken.


CRD is compliant with version 1.22+

This PR moves the QiskitPlayground CRD from using apiextensions.k8s.io/v1beta1 to apiextensions.k8s.io/v1 due to its deprecation in versions 1.22+. The OpenAPIv3 schema is moved fromspec.validation to spec.versions[0].schema.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Eliminate the use of the empty struct Coro_create_t

This commit seeks to eliminate the use of the empty struct Coro_create_t.
To my knowledge, empty structs are used for tag dispatch or method coloring. Both of these use cases are irrelevant here because there is only one constructor in the Coro class. Furthermore, no access-restriction (private or protected) was placed on Coro_create_t and hence it was publicly usable.

[ x ] Refactor (non-breaking change that only restructures code)

@ckeshava does this change still make sense to apply? If not, feel free to close it for now.

An improved version of this commit has been included in #4172. This can be closed.


Reduce mac android tests in staging env

Devicelab Mac/Android tests have been migrated to prod for a while and are running well.
Since we have only one bot available in staging env, this PR leaves only five tests in staging for validation.
Related issue: https://github.com/flutter/flutter/issues/74059

Abandoning this PR for now.


Images do not appear in the documentation

For example, the logo at the top of
https://www.amethyst.rs/book/master/
it points to
https://www.amethyst.rs/book/master/images/amethyst_thumb.png
which returns 404.
There are several other examples. Such as the image at the bottom of the first page of the Pong tutorial:
https://www.amethyst.rs/book/master/pong_tutorial/pong_tutorial_01.html
It just shows 'Step one' with no image.

Thanks so much for the report, @rookboom! It appears that recent changes to the website have fixed these issues already. The first two links you posted no longer resolve to a 404, and the second link has been updated to https://www.amethyst.rs/book/master/pong-tutorial/pong-tutorial-01.html, and the image at the bottom now resolves correctly. Please confirm that all three image links are working now on your end.

It works now. 😀


Improvements based on 2022 iteration

Starting a thread to put improvements for next year's iteration.

TA-held Installation Workshop on Imagine Day
Right now we just need a ton of in-person time to get everyone through the installation hurdle.
To help address this, we could hold a session on Imagine Day to kickstart installation - hard for the instructor to make this because the Stat department has events that day, but a non-Stat-department TA could do this.


Change size of 3-digit labels

Right now, 3-digit-labels overflow the interesections/stones.  This isn't ideal, of course, so I should add some logic in to change the size.

In general, SGF allows for arbitrarily long labels, and just changing the text size might not always produce a reasonable output. It might be a bit tricky to get the appropriate size right, since while "111" might fit for some font size, "WWW" (or any full-width CJK characters) might not. I'm not too sure about the best way to compute the actual rendered width of a text string, but that would have to figure into setting the size in order to avoid making all three-character labels very small, just to accommodate a few possibilities that are much wider than average.
For labels longer than 3 characters, it starts to get a bit impractical to just scale down the font size. Another option, suggested by the SGF standard examples, is to truncate longer labels and then use a tooltip to show to the full label.
http://www.red-bean.com/sgf/examples/
http://www.red-bean.com/sgf/examples/ex06.gif

Related to this issue, I noticed some problems with drawing arbitrary text labels in this Glift lesson: https://gogameguru.com/terrible-tesuji/
In particular, on panel 20 (0.5.0 of this file https://gogameguru.com/i/2015/03/terrible-tesuji.sgf), there are some sad face labels :( and ): on the stones which appear to cause problems for Glift.


How to use the NAVAPP functions in OnNavAppUpgradePerCompany to save data

Good day.
Sorry in advance for dublicate, but I can't find answer into the MS sites and MS suuport CAN"T answer directly on the question - HOW TO write this codeunit with simple case.
The issue is (it is very simple description of the small situation to avoid possibility to go-out of the clear response):

I have NAV database with 2 Companies where a Ledger table exist;
it is Ledger table exist with some fields and current installation has many lines;
I'm using VSC (version 1.29.1) and "schemaUpdateMode": "Synchronize" in the JSON-file;
I re-designed the solution a little and want to update (type or name) or delete 2 fields. When I tried to publish it I received that I can't publish it from VSC.

The result I have real database and I need to write Upgrade codeunit with conditions:

I need to have ALL records with SAME table number;
All records should have 100% same data (but exclude 2 fields)
2 fields should gone

I think I wrote clear now to receive qualified answer, but not just senseless answer with wastу link to MS site.
Thank you in advance for your understanding and answer.
P.S. I tried to use some upgrade codeunits with NAVAPP functions in the OnNavAppUpgradePerCompany, but it does not work.

This repository no longer handles general questions and is only dedicated to bug reports and feature suggestions for the AL compiler and developer tools.
To get help for your question please use one of the following resources:
Business Central Community
mibuso forum
Dynamics User Group


LOS tool broken due to mixed content requests

Oh welp I guess I gotta do HTTPS on the backend side

Should be fixed once @WillNilges deploys the new image. Thanks for forcing me to finally learn let's encrypt


jdt-language-server: pin jdk version to jdk17

Description of changes
Closes: https://github.com/NixOS/nixpkgs/issues/297180
This PR makes the jdt-language-server derivation explicitly use jdk17 instead of the latest jdk.
This PR might break some people's overrides if they tried to fix this for themselves.
Would it be better to use all-packages.nix and use callPackges ... { jdk = jdk17; } instead?

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Hey @TomaSajt,
Thanks for your attempt at this. As I noted in #297180, I don't think this is the right approach.
This fixes the problem for your specific environment, where Gradle 7.4 is used, but I believe it will be a brittle solution because in the end, at runtime, the version of gradle being used comes from the global environment and is not specified in the package.
Furthermore, it seems like this package is already going to break as soon as jdk is updated to point to jdk21, since jdt.ls doesn't support Java 21 yet.
So firstly, I think we should hardcode the Java version to jdk19. For users who want to override this, jdt-language-server.override { jdk19 = jdk17; }) is kind of confusing, so I wonder if it would be better to define this input attrset with java ? jdk19 so the override looks cleaner?
The incompatibility with Gradle is a bit trickier, but I think there is a solution there as well. jdtls.py does not setup Gradle explicitly, jdt.ls starts it internally (and if needed, will download it). I think if we use makeWrapper the/path/to/jdtls.py --set GRADLE_HOME "${gradle7}/lib/gradle" on the jdtls.py` script, that would do the trick.
What do you think?

What if we just don't hard-code the java dependency into the package? Maybe we should let the java executable come from the user environment?

That is a surprising suggestion for a Nix package. Packages are intended to be reproducible and explicitly declare all dependencies, so that sounds like the opposite direction we would want to go in. Especially considering there seems to be an option to make it more reproducible.
Is there a reason you think that would be the right approach in this case?

I don't use this program, so if you have an idea for a better solution, I think you should open a PR for it.

I will add it to my list and look into that at some point soon.
I think you should probably close this MR. It doesn't seem to be a solution to the problem, or at least not a general solution. It will work for some people, and break the package for other people. The real solution is to declare and pin the dependencies that are currently coming from the environment (e.g. gradle)

What if we just don't hard-code the java dependency into the package? Maybe we should let the java executable come from the user environment?

That is a surprising suggestion for a Nix package. Packages are intended to be reproducible and explicitly declare all dependencies, so that sounds like the opposite direction we would want to go in. Especially considering there seems to be an option to make it more reproducible.
Is there a reason you think that would be the right approach in this case?

I don't use this program, so if you have an idea for a better solution, I think you should open a PR for it.

I will add it to my list and look into that at some point soon.
I think you should probably close this MR. It doesn't seem to be a solution to the problem, or at least not a general solution. It will work for some people, and break the package for other people. The real solution is to declare and pin the dependencies that are currently coming from the environment (e.g. gradle)

IIRC there are other language servers inside nixpkgs which always try to use the environment. I believe this is more correct than trying to force it to have a version of java, which the user isn't running. For example, let's say we force it to use jdk19 but we're working on a project with jdk17, we will almost certainly have the java command in out $PATH, however because it's patched to use jdk19 it uses the newer java, which differs from the user's environment. I know it's not nix-y, but I think it's more correct.

Closing this for now, because the PR doesn't really solve anything.
I'm still up to debate about what to do, though.

For example, let's say we force it to use jdk19 but we're working on a project with jdk17, we will almost certainly have the java command in out $PATH, however because it's patched to use jdk19 it uses the newer java, which differs from the user's environment. I know it's not nix-y, but I think it's more correct.

I think generally speaking you can start jdtls with a version of Java >= the project code. I don't think it is a problem to run e.g. jdk19 for a jdk17 project. But that is just from memory and I'm not certain of that.
And I think you are right, it would be better to use the same version of Java (and Gradle) that the user is running in their project. But in that case, I think a better solution is a project-specific Nix shell:
{ pkgs ? import <nixpkgs> {} }:

pkgs.mkShell {
    buildInputs = with pkgs; [
      jdk17
      (jdt-language-server.override { java = jdk17; })
    ];
}

The incompatibility with Gradle is a bit trickier, but I think there is a solution there as well. jdtls.py does not setup Gradle explicitly, jdt.ls starts it internally (and if needed, will download it). I think if we use makeWrapper the/path/to/jdtls.py --set GRADLE_HOME "${gradle7}/lib/gradle" on the jdtls.py` script, that would do the trick.

I confirm that setting GRADLE_HOME to  lib/gradle of pkgs.gradle_7 (effectively v7.6.4) gets rid of those exceptions too. And this works with and without gradle_7.override { java = jdk19; } . Thank you.

Though this is also a solution, I still mostly think that the nix mindset can be put aside for LS packages

I kinda agree with that because most of that usages likely are interactive development shell/environment setup not necessary aligned with default versions of JDK/Gradle/etc. E.g.
I use this mostly in sub-shells (per project or shared scripts to setup environment)
  home.packages = with pkgs; [
    (envScript (buildDevEnv {
      name = "jvm-test";
      paths = [ jdk gradle jdt-language-server ];
    }))
    (envScript (buildDevEnv {
      name = "jvm";
      paths = [
        jdk gradle gradle-completion

        # Gradle only supports JDK 8/11/17
        # switching versions may require: rm -rf ~/.cache/jdtls ~/.gradle
        (jdt-language-server.override { jdk = jdk17; })

to get ad-hoc often re-usable shells and then use
env-jvm nvim src/main/java/Dummy.java  # to just run Neovim within environment
env-jvm # to enter shell with environment setup

And for specific projects I use shells.

Only thing is that JDTLS seems like tries to work out of the box. And deferring this issue to env setup undermines that intent.

What if we just made the script use the environment, BUT we added --suffix PATH : ${jdk17}/bin to the script with wrapProgram/makeWrapper.

It is not a problem of finding JDK. It is problem of incompatible JDKs. Apparently we have some class files compiled with newer version of Java than what Gradle is running with. I still don't understand what are those files. My guess they are generated by Eclipse JDT on the fly and since it is run via makeWrapper ${jdk}/bin/java $out/bin/jdt-language-server that's overriding that jdk have effect.
Note that I tried replacing jdk in my PATH with jdk17  and it didn't fixed it too which is mystery for me where JDK17 comes from to be used for running Gradle.


[XML] properly handle normalizedString

CycloneDX uses http://www.w3.org/2001/XMLSchema - which defines normalizedString as follows:
<xs:simpleType name="normalizedString" id="normalizedString">
  <xs:annotation>
    <xs:documentation source="http://www.w3.org/TR/xmlschema-2/#normalizedString"/>
  </xs:annotation>
  <xs:restriction base="xs:string">
    <xs:whiteSpace value="replace" id="normalizedString.whiteSpace"/>
  </xs:restriction>
</xs:simpleType>

normalizedString represents white space normalized strings. The ·value space· of normalizedString is the set of strings that do not contain the carriage return (#xD), line feed (#xA) nor tab (#x9) characters. The ·lexical space· of normalizedString is the set of strings that do not contain the carriage return (#xD), line feed (#xA) nor tab (#x9) characters. The ·base type· of normalizedString is string.

therefore, on XML-normalization, the following chars must be replaced by space( ):

carriage return: \r (#xD)
line feed: \n (#xA
tab: \t (#x9)

Affected are only fields that are defined as normalizedString in XML spec!
Other field MUST NOT be affected!

possible solution:
modify the XML normalizers where needed, and call a to-be-written helper function that does the normalization.


Unable to perform successive re-login.

When trying to attempt to login the initial login attempt succeed but the next attempt failed show an invalid login detail from the response.
In able for me to make it work again, I need to clear the records from the django_session table from apps database and set REST_SESSION_LOGIN=False and this eliminates the error altogether, this also eliminates the session cookies in the response headers.
I need to enable REST_SESSION_LOGIN = True as I am using it for the important backend processes.
Thanks a lot!

I solved the issue with disabling the rest_framework.authentication.SessionAuthentication by explicitly setting the authentication_classes on the package that requires it. It allows the use of SessionAuthentication without interfering with authentication using the API backend of dj_rest_auth.


Not displaying failed test

Is this a bug report or a feature request?
Bug: Majestic has correctly detected a failing test, however it fails to display which test is failing and the detail about it in the UI.
Version Info

Version of Majestic: v1.6.0
Version of Jest: 24.9.0
Version of Node: v10.16.3
Operating System: Windows 10x64

Reproduction Repo
I can't currently provide an example rep, but I can probably provide more debugging info.

it looks like the failing test is not even displayed in the UI. Probably the parser is failing to parse it properly. Does the test has any syntactical difference to other tests? Probably using .each or something else?

Hello Guys, I just discovered this project, thanks for your work!
I have the same problem here as described here, failing test description is not shown

Hi!
This project seems really nice! Thank you!
.. But I have similar issue:
If I click on "Run tests" button, it show me 4 passing suites, 38 passing tests and so on...seems it works!
But if I click on the test files it not show me any details.
In terminal I can see 'Determining test suites to run...' as output.
Seems that he can't find the test suites..but it can run them...
I can notice a strange thing: the Project tree is composed like:
{projectName} > c: > dev > ...the project path
Is it ok? I would expect something like {projectName} > tests > test file and not all the absolute path..
Version of Majestic: v1.6.1
Version of Jest: 24.9.0
Version of Node: v12.3.1
Operating System: Windows 10x64
Thank you

I did a test: if I run majestic from the Windows 10 WSL subsystem (Ubuntu) ...it works great!
...it's not the perfect solutions but for now it works!
Thank you!

I think we can ignore my last comment about the timeout. I looked at the error more closely and realized that in running the reporter.js, it was expecting to get the port and I hadn't set it.
I set the environment variable for the port and then I re-ran it. This is what I got:
yarn run v1.19.1
$ jest --colors --collectCoverage=false --reporters 'C:\Users\gregv\AppData\Local\Yarn\Data\global\node_modules\majestic\dist\server\scripts\reporter.js'
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

I had Majestic running in another window and I saw that it spit out more output when the tests ran. But I am guessing the "error command failed with exit code 1 is causing some issues. I am pretty sure it is the reporter.js that is causing the error. When I put in --reporters default <path_to_reporter.js>, then I get the expected output on the command line followed by a statement that the command failed. If I remove the reporter.js reference, then I don't get the error.

Nope, it must be a parsing thing. I ran node and jest in a debugger and I set a break point in the reporter.js file. There were no crashes and no error command failed with exit code 1. But the post still didn't populate the tests in the UI.
Here is the body as a json object that it was about to pass to the server:
{
  "path": "C:\\Users\\gregv\\source\\repos\\SquashSpider\\SquashSpider\\SkyCourt.UI\\SPA\\src\\layouts\\navbar.unit.ts",
  "failureMessage": "\u001b[1m\u001b[31m  \u001b[1m● \u001b[22m\u001b[1mnavbar tests › view model function tests › setMobileView emits hide-sidebar when transitioning to not mobile view from mobile view\u001b[39m\u001b[22m\n\n    \u001b[2mexpect(\u001b[22m\u001b[31mreceived\u001b[39m\u001b[2m).\u001b[22mtoHaveLength\u001b[2m(\u001b[22m\u001b[32mexpected\u001b[39m\u001b[2m)\u001b[22m\n\n    \u001b[1mMatcher error\u001b[22m: \u001b[31mreceived\u001b[39m value must have a length property whose value must be a number\n\n    Received has value: \u001b[31mundefined\u001b[39m\n\u001b[2m\u001b[22m\n\u001b[2m    \u001b[0m \u001b[90m 239 | \u001b[39m      await wrapper\u001b[33m.\u001b[39mvm\u001b[33m.\u001b[39m$nextTick()\u001b[33m;\u001b[39m\u001b[0m\u001b[22m\n\u001b[2m    \u001b[0m \u001b[90m 240 | \u001b[39m      \u001b[90m// Assert\u001b[39m\u001b[0m\u001b[22m\n\u001b[2m    \u001b[0m\u001b[31m\u001b[1m>\u001b[22m\u001b[2m\u001b[39m\u001b[90m 241 | \u001b[39m      expect(wrapper\u001b[33m.\u001b[39memitted()[\u001b[32m'hide-sidebar'\u001b[39m])\u001b[33m.\u001b[39mtoHaveLength(\u001b[35m1\u001b[39m)\u001b[33m;\u001b[39m\u001b[0m\u001b[22m\n\u001b[2m    \u001b[0m \u001b[90m     | \u001b[39m                                                \u001b[31m\u001b[1m^\u001b[22m\u001b[2m\u001b[39m\u001b[0m\u001b[22m\n\u001b[2m    \u001b[0m \u001b[90m 242 | \u001b[39m    })\u001b[33m;\u001b[39m\u001b[0m\u001b[22m\n\u001b[2m    \u001b[0m \u001b[90m 243 | \u001b[39m    test(\u001b[32m'setMobileView does not emit hide-sidebar when transitioning to mobile view from not mobile view'\u001b[39m\u001b[33m,\u001b[39m  async () \u001b[33m=>\u001b[39m {\u001b[0m\u001b[22m\n\u001b[2m    \u001b[0m \u001b[90m 244 | \u001b[39m      \u001b[90m// Arrange\u001b[39m\u001b[0m\u001b[22m\n\u001b[2m\u001b[22m\n\u001b[2m      \u001b[2mat \u001b[22m\u001b[2m\u001b[0m\u001b[36msrc/layouts/navbar.unit.ts\u001b[39m\u001b[0m\u001b[2m:241:49\u001b[22m\u001b[2m\u001b[22m\n\u001b[2m      \u001b[2mat fulfilled (\u001b[22m\u001b[2m\u001b[0m\u001b[36msrc/layouts/navbar.unit.ts\u001b[39m\u001b[0m\u001b[2m:5:58)\u001b[22m\u001b[2m\u001b[22m\n\u001b[2m      \u001b[2mat tryCallOne (\u001b[22m\u001b[2mnode_modules/promise/lib/core.js\u001b[2m:37:12)\u001b[22m\u001b[2m\u001b[22m\n\u001b[2m      \u001b[2mat \u001b[22m\u001b[2mnode_modules/promise/lib/core.js\u001b[2m:123:15\u001b[22m\u001b[2m\u001b[22m\n\u001b[2m      \u001b[2mat flush (\u001b[22m\u001b[2mnode_modules/asap/raw.js\u001b[2m:50:29)\u001b[22m\u001b[2m\u001b[22m\n\n\u001b[1m\u001b[31m  \u001b[1m● \u001b[22m\u001b[1mnavbar tests › view model function tests › setMobileView does not emit hide-sidebar when transitioning to mobile view from not mobile view\u001b[39m\u001b[22m\n\n    \u001b[2mexpect(\u001b[22m\u001b[31mreceived\u001b[39m\u001b[2m).\u001b[22mtoHaveLength\u001b[2m(\u001b[22m\u001b[32mexpected\u001b[39m\u001b[2m)\u001b[22m\n\n    \u001b[1mMatcher error\u001b[22m: \u001b[31mreceived\u001b[39m value must have a length property whose value must be a number\n\n    Received has value: \u001b[31mundefined\u001b[39m\n\u001b[2m\u001b[22m\n\u001b[2m    \u001b[0m \u001b[90m 250 | \u001b[39m      await wrapper\u001b[33m.\u001b[39mvm\u001b[33m.\u001b[39m$nextTick()\u001b[33m;\u001b[39m\u001b[0m\u001b[22m\n\u001b[2m    \u001b[0m \u001b[90m 251 | \u001b[39m      \u001b[90m// Assert\u001b[39m\u001b[0m\u001b[22m\n\u001b[2m    \u001b[0m\u001b[31m\u001b[1m>\u001b[22m\u001b[2m\u001b[39m\u001b[90m 252 | \u001b[39m      expect(wrapper\u001b[33m.\u001b[39memitted()[\u001b[32m'hide-sidebar'\u001b[39m])\u001b[33m.\u001b[39mtoHaveLength(\u001b[35m0\u001b[39m)\u001b[33m;\u001b[39m\u001b[0m\u001b[22m\n\u001b[2m    \u001b[0m \u001b[90m     | \u001b[39m                                                \u001b[31m\u001b[1m^\u001b[22m\u001b[2m\u001b[39m\u001b[0m\u001b[22m\n\u001b[2m    \u001b[0m \u001b[90m 253 | \u001b[39m    })\u001b[33m;\u001b[39m\u001b[0m\u001b[22m\n\u001b[2m    \u001b[0m \u001b[90m 254 | \u001b[39m  })\u001b[33m;\u001b[39m\u001b[0m\u001b[22m\n\u001b[2m    \u001b[0m \u001b[90m 255 | \u001b[39m})\u001b[33m;\u001b[39m\u001b[0m\u001b[22m\n\u001b[2m\u001b[22m\n\u001b[2m      \u001b[2mat \u001b[22m\u001b[2m\u001b[0m\u001b[36msrc/layouts/navbar.unit.ts\u001b[39m\u001b[0m\u001b[2m:252:49\u001b[22m\u001b[2m\u001b[22m\n\u001b[2m      \u001b[2mat fulfilled (\u001b[22m\u001b[2m\u001b[0m\u001b[36msrc/layouts/navbar.unit.ts\u001b[39m\u001b[0m\u001b[2m:5:58)\u001b[22m\u001b[2m\u001b[22m\n\u001b[2m      \u001b[2mat tryCallOne (\u001b[22m\u001b[2mnode_modules/promise/lib/core.js\u001b[2m:37:12)\u001b[22m\u001b[2m\u001b[22m\n\u001b[2m      \u001b[2mat \u001b[22m\u001b[2mnode_modules/promise/lib/core.js\u001b[2m:123:15\u001b[22m\u001b[2m\u001b[22m\n\u001b[2m      \u001b[2mat flush (\u001b[22m\u001b[2mnode_modules/asap/raw.js\u001b[2m:50:29)\u001b[22m\u001b[2m\u001b[22m\n",
  "numFailingTests": 2,
  "numPassingTests": 9,
  "numPendingTests": 0,
  "testResults": [
    {
      "title": "is a Vue instance",
      "numPassingAsserts": 0,
      "status": "passed",
      "failureMessages": [],
      "ancestorTitles": [
        "navbar tests",
        "creates top level menus based on user information"
      ],
      "duration": 5
    },
    {
      "title": "Creates proper menues for regular user in a club with no courts",
      "numPassingAsserts": 0,
      "status": "passed",
      "failureMessages": [],
      "ancestorTitles": [
        "navbar tests",
        "creates top level menus based on user information"
      ],
      "duration": 47
    },
    {
      "title": "Creates proper menues for regular user in a club with one court",
      "numPassingAsserts": 0,
      "status": "passed",
      "failureMessages": [],
      "ancestorTitles": [
        "navbar tests",
        "creates top level menus based on user information"
      ],
      "duration": 27
    },
    {
      "title": "Creates proper menues for regular user in a club with multiple courts",
      "numPassingAsserts": 0,
      "status": "passed",
      "failureMessages": [],
      "ancestorTitles": [
        "navbar tests",
        "creates top level menus based on user information"
      ],
      "duration": 29
    },
    {
      "title": "Creates proper menues for user with no club membership",
      "numPassingAsserts": 0,
      "status": "passed",
      "failureMessages": [],
      "ancestorTitles": [
        "navbar tests",
        "creates top level menus based on user information"
      ],
      "duration": 36
    },
    {
      "title": "Creates proper menues for regular user with announcement priviledges in a club with no courts",
      "numPassingAsserts": 0,
      "status": "passed",
      "failureMessages": [],
      "ancestorTitles": [
        "navbar tests",
        "creates top level menus based on user information"
      ],
      "duration": 26
    },
    {
      "title": "Creates proper menues for clubAdmin in a club with no courts",
      "numPassingAsserts": 0,
      "status": "passed",
      "failureMessages": [],
      "ancestorTitles": [
        "navbar tests",
        "creates top level menus based on user information"
      ],
      "duration": 20
    },
    {
      "title": "Creates proper menues for siteAdmin in a club with no courts",
      "numPassingAsserts": 0,
      "status": "passed",
      "failureMessages": [],
      "ancestorTitles": [
        "navbar tests",
        "creates top level menus based on user information"
      ],
      "duration": 24
    },
    {
      "title": "setMobileView sets the mobileView getter",
      "numPassingAsserts": 0,
      "status": "passed",
      "failureMessages": [],
      "ancestorTitles": [
        "navbar tests",
        "view model function tests"
      ],
      "duration": 30
    },
    {
      "title": "setMobileView emits hide-sidebar when transitioning to not mobile view from mobile view",
      "numPassingAsserts": 0,
      "status": "failed",
      "failureMessages": [
        "Error: \u001b[2mexpect(\u001b[22m\u001b[31mreceived\u001b[39m\u001b[2m).\u001b[22mtoHaveLength\u001b[2m(\u001b[22m\u001b[32mexpected\u001b[39m\u001b[2m)\u001b[22m\n\n\u001b[1mMatcher error\u001b[22m: \u001b[31mreceived\u001b[39m value must have a length property whose value must be a number\n\nReceived has value: \u001b[31mundefined\u001b[39m\n    at C:\\Users\\gregv\\source\\repos\\SquashSpider\\SquashSpider\\SkyCourt.UI\\SPA\\src\\layouts\\navbar.unit.ts:241:49\n    at Generator.next (<anonymous>)\n    at fulfilled (C:\\Users\\gregv\\source\\repos\\SquashSpider\\SquashSpider\\SkyCourt.UI\\SPA\\src\\layouts\\navbar.unit.ts:5:58)\n    at tryCallOne (C:\\Users\\gregv\\source\\repos\\SquashSpider\\SquashSpider\\SkyCourt.UI\\SPA\\node_modules\\promise\\lib\\core.js:37:12)\n    at C:\\Users\\gregv\\source\\repos\\SquashSpider\\SquashSpider\\SkyCourt.UI\\SPA\\node_modules\\promise\\lib\\core.js:123:15\n    at flush (C:\\Users\\gregv\\source\\repos\\SquashSpider\\SquashSpider\\SkyCourt.UI\\SPA\\node_modules\\asap\\raw.js:50:29)\n    at process._tickCallback (internal/process/next_tick.js:61:11)"
      ],
      "ancestorTitles": [
        "navbar tests",
        "view model function tests"
      ],
      "duration": 33
    },
    {
      "title": "setMobileView does not emit hide-sidebar when transitioning to mobile view from not mobile view",
      "numPassingAsserts": 0,
      "status": "failed",
      "failureMessages": [
        "Error: \u001b[2mexpect(\u001b[22m\u001b[31mreceived\u001b[39m\u001b[2m).\u001b[22mtoHaveLength\u001b[2m(\u001b[22m\u001b[32mexpected\u001b[39m\u001b[2m)\u001b[22m\n\n\u001b[1mMatcher error\u001b[22m: \u001b[31mreceived\u001b[39m value must have a length property whose value must be a number\n\nReceived has value: \u001b[31mundefined\u001b[39m\n    at C:\\Users\\gregv\\source\\repos\\SquashSpider\\SquashSpider\\SkyCourt.UI\\SPA\\src\\layouts\\navbar.unit.ts:252:49\n    at Generator.next (<anonymous>)\n    at fulfilled (C:\\Users\\gregv\\source\\repos\\SquashSpider\\SquashSpider\\SkyCourt.UI\\SPA\\src\\layouts\\navbar.unit.ts:5:58)\n    at tryCallOne (C:\\Users\\gregv\\source\\repos\\SquashSpider\\SquashSpider\\SkyCourt.UI\\SPA\\node_modules\\promise\\lib\\core.js:37:12)\n    at C:\\Users\\gregv\\source\\repos\\SquashSpider\\SquashSpider\\SkyCourt.UI\\SPA\\node_modules\\promise\\lib\\core.js:123:15\n    at flush (C:\\Users\\gregv\\source\\repos\\SquashSpider\\SquashSpider\\SkyCourt.UI\\SPA\\node_modules\\asap\\raw.js:50:29)\n    at process._tickCallback (internal/process/next_tick.js:61:11)"
      ],
      "ancestorTitles": [
        "navbar tests",
        "view model function tests"
      ],
      "duration": 3130
    }
  ],
  "aggregatedResult": null
}

It would appear that the error is on the server side that is accepting this because this was successfully sent to the server. The server spit out another message on the console saying:
"i File result reported "
is this enough to go on?

Pinging @Raathigesh in case he hasn't seen any of this yet. When this issue happens, Majestic is pretty much useless unfortunately. And at least in my case, it is happening 95% of the time, probably 100% of the time with this single unit test I am working on.

@Raathigesh I wonder if this has anything to do with it: I get this in the chrome javascript console.
ui.bundle.js:21 Uncaught (in promise) Error: GraphQL error: This experimental syntax requires enabling the parser plugin: 'optionalChaining' (96:9)
    at new t (ui.bundle.js:21)
    at e.<anonymous> (ui.bundle.js:21)
    at ui.bundle.js:16
    at Object.next (ui.bundle.js:16)
    at ui.bundle.js:16
    at new Promise (<anonymous>)
    at l (ui.bundle.js:16)
    at ui.bundle.js:21
    at ui.bundle.js:21
    at Array.forEach (<anonymous>)

I have downloaded the github repo and tried debugging the server. It appears to be functioning correctly. It gets the proper values and seems to parse them fine from jest. So I am moving on to the UI. I want to see if the client is getting the right data from the server. That's when I noticed this error.
I don't know react or graphQL so it is going to be tough to diagnose this on the client for me.

@Raathigesh I tried to fix the problem by installing the babel plugin: "@babel/plugin-proposal-optional-chaining" and rebuilding my local copy and copying the dist over top of my installed global version of majestic. I can't figure out how to run my development version of majestic on an external project so I am finding it hard to debug the client.
Anyway, I am now watching the debug statements in the client and I see that the client was pushed a changeToResults message via graphQL and it contained all the rigth information. So the problem appears to be somewhere in the client code when it handles the result update.  A pointer would be great....

@Raathigesh I am debugging the client and in ui/test-file/index.tsx there is a variable called fileItemResult. That is always an empty object and I believe that is causing the problem because in the render function the section where it renders the test results is rendering the fileItemResult
        {fileItemResult && (
          <TestItemsContainer>
            {roots.map(item => {
              const tree = transform(
                item as any,
                fileItemResult.items as any,
                0
              ) as any;
              return <Test key={item.id} item={tree} result={result} />;
            })}
          </TestItemsContainer>
        )}

since fileItemREsult is always an empty object, then there is nothing to render. I can't figure out how this variable is supposed to get set since I don't understand graphQL yet. It just looks like some strange code.
Ok, I think I am starting to understand. fileItemResult isn't a result, it is the structure of the test file. It is supposed to have test items in it that can be describes, it and todos.
Hey, wait a minute. My test files use 'test' instead of 'it'. When I was using jasmine I used 'it' but the examples I copied when I started using jest were using 'test' instead. Let me change that. Maybe that is the root of the problem.
If that is not the problem, then I think the problem is in parsing the structure of the file you get back from jest rather than the results. The results portion looks fine.

@Raathigesh Here is what I have found out so far:
The response to the query:
{"operationName":"FileItems","variables":{"path":"C:\\Users\\gregv\\source\\repos\\SquashSpider\\SquashSpider\\SkyCourt.UI\\SPA\\src\\layouts\\navbar.unit.ts"},"query":"query FileItems($path: String!) {\n  file(path: $path) {\n    items {\n      id\n      name\n      type\n      parent\n      only\n      __typename\n    }\n    __typename\n  }\n}\n"}

is an error and this is what screws up the listing of the tests, I believe. Here is the response to this query:
{"data":null,"errors":[{"message":"This experimental syntax requires enabling the parser plugin: 'optionalChaining' (96:9)","locations":[{"line":2,"column":3}],"path":["file"]}]}

Could you look into fixing this? With it broken like this Majestic is pretty much useless. I will switch to seeing if I can figure out if it is something in my test file that is triggering it.

BTW, in case it wasn't clear, the error is coming from the server when we query for the fileItems. So I was mistaken when I said it looked like the problem was on the client.

@Raathigesh BREAK THROUGH!!!
The issue is that in my unit test file (which is typescript), I had this function:
  afterAll(() => {
    wrapper?.destroy();
  });

The issue is the ?. operator. I don't know what version of babel is processing that file, but whatever installation of babel is doing it, doesn't know how to handle the ?. operator and throws an error while parsing it.
The strange thing is that this works just fine when I run jest without Majestic.
@IPWright83, @GoMino, @IGionny, You guys may have moved on by now, but I think this might be a work around for the issue you were having if it is the same as the one I was having.
To check, open chrome debugger and look to see if you are seeing a network error like this:
ui.bundle.js:21 Uncaught (in promise) Error: GraphQL error: This experimental syntax requires enabling the parser plugin: 'optionalChaining' (96:9)
    at new t (ui.bundle.js:21)

If you are, then you are using ?. in your unit test file. If you remove it, then Majestic will work fine.
I suspect there are other newer features of JS/TS that would result in a similar message. If you use another new feature, the optionalChaining message will be replaced with whatever feature you are using.
For now, I will avoid optionalchaining in my unit test files. And in the background, I will try to figure out where the configuration is for babel that is trying to transpile the unit test files. There is a configuration that can be set to include a babel plugin to transpile that code properly.

@gregveres Thank you for digging through the details to find the root cause. Appreciate it.
I think the parser we use to extract the test names from a test file is not handling the optional chaining properly.
Enabling the support for optional chaining, by looking at the docs, could be easy as adding the 'optionalChaining' to the plugin array in the above-mentioned file.
Do you think you would be able to make PR with the change?

@Raathigesh pull request created. It turned out to be quite simple once you pointed me to that file. I would have never found the right file otherwise. Thank you.
I did a 'yarn run prod' on my branch and then copied the server directory over top of my globally installed copy of majestic and then launched majestic on my project. All the unit tests showed up properly even when I had used optional chaining in the tests.

@gregveres wow, I've only just come across these updates. Awesome work and digging. I probably need to go through the same.
Unfortunately for me we had no optional chaining, so this is unlikely to fix the problem I was having with the tests.

@IPWright83 now that I am done with the investigation, I can look back and short circuit a lot of it. :)  If you open the chrome debugger and see an error message that says something like:
ui.bundle.js:21 Uncaught (in promise) Error: GraphQL error: This experimental syntax requires enabling the parser plugin: 'optionalChaining' (96:9)
    at new t (ui.bundle.js:21)

Yours will probably say something different than optionalChaining in the plugin field. There are many other plugins that could be added based on the features you are using in your test code.

@gregveres thanks, I'll take a look at some point :)

I also have the same problem, says failing tests, but these are not shown in the UI, switching to the console shows the tests Jest failed. Any update on this?

@pdashford this has been fixed by PR #178. I see that there have been a number of pull requests merged lately so maybe a new npm version is about to come out.

Thanks @gregveres

Hi, I was running Majestic 1.7.0, and there were Test suite failed to run, but in Majestic UI, the test file is still marked as green.
Version of Jest: 24.6.0
Version of Node: v12.16.1
Operating System: Windows 10x64

@gregveres the optional chaining change is released as a part of https://github.com/Raathigesh/majestic/releases/tag/v1.7.0
@pdashford If you could provide a sample repo, that would be really helpful to investigate.