fix: re-add removed code for awarding points on deck and q…

Description
In this PR https://github.com/gator-labs/chomp/commit/941bc2835c4320b7fa55f651b9ad6742ab401611#diff-4091e4ffbbcf2f227f3e4bc898c3b28853aa8c67d6e5fd155216ecff80756055L32 mistakenly the code for incrementing points for answer deck and question also got removed.
What are the steps to test that this code is working?
You will get points again for answering question and completing a deck
Screen shots or recordings for UI changes
N/A

@yash431garg have you tested in staging since Devin fixed?

No, I have to test.

No, I have to test.

Cool. Will get this merged to production as soon as it's tested.

No, I have to test.

Cool. Will get this merged to production as soon as it's tested.

I have tested it ready to be merged.


Issue: The relations between outline-item and real-page.

Attach (recommended) or Link to PDF file here: Any PDF file with OUTLINE, I attached a PDF file with an outline.
BJC70用户说明书.pdf
Configuration:

Web browser and its version: Microsoft Edge or Chrome, both are the latest versions.
Operating system and its version: Windows 10
PDF.js version: I don't know, I used npm to install it: [ vue-pdf ]
Is a browser extension:

I need to make a pdf viewer for my vue project, this viewer needs these functions: Outline-List-View. But vue-pdf no outline. I want to put some Element nodes and use them as a outline-list, then click a link, it will scroll to the destination page that I excepted.
Using PDF.js, I could get the Outline list Array or Object, like [num, gen, 'XYZ' 567.89] and some titles. But I can't get the relation between real-page and outline-item or page-number.
I get tons of useless guides or information on Chinese websites, either Baidu or Bing. So I hope someone can help me to solve this problem or tell me the relations between outline-item and real-page. Thanks.
英语说的不好，请见谅。以下是中文内容。
通过PDF.js我能获取到大纲的Array，但是我没法把大纲的每一项和真实的页码联系起来。
我想在页面渲染的时候获取页码，这样点击大纲里面的东西就可以跳转到对应的页面。
大纲：Outline、OutlineView。

PDF.js version: I don't know, I used npm to install it: [ vue-pdf ]

Sorry, but "vue-pdf" is not maintained here and consequently we cannot provide support for that. Please open an issue in the correct repository instead.
Note also that you need to communicate only in English when using this bug tracker.

Given the limited information provided, the only suggestions is to check the following resources:

https://web.archive.org/web/20220309040754if_/https://www.adobe.com/content/dam/acom/en/devnet/pdf/pdfs/PDF32000_2008.pdf#G11.2063217
https://github.com/mozilla/pdf.js/blob/da4f7dfcd04400cb2ce67f04be0d78e43f20dbac/src/display/api.js#L793-L800
The viewer-implementation may perhaps be useful as well, see https://github.com/mozilla/pdf.js/blob/da4f7dfcd04400cb2ce67f04be0d78e43f20dbac/web/pdf_link_service.js#L176-L257

Attach (recommended) or Link to PDF file here: Any PDF file with OUTLINE, I attached a PDF file with an outline. BJC70用户说明书.pdf
Configuration:

Web browser and its version: Microsoft Edge or Chrome, both are the latest versions.
Operating system and its version: Windows 10
PDF.js version: I don't know, I used npm to install it: [ vue-pdf ]
Is a browser extension:

I need to make a pdf viewer for my vue project, this viewer needs these functions: Outline-List-View. But vue-pdf no outline. I want to put some Element nodes and use them as a outline-list, then click a link, it will scroll to the destination page that I excepted.
Using PDF.js, I could get the Outline list Array or Object, like [num, gen, 'XYZ' 567.89] and some titles. But I can't get the relation between real-page and outline-item or page-number.
I get tons of useless guides or information on Chinese websites, either Baidu or Bing. So I hope someone can help me to solve this problem or tell me the relations between outline-item and real-page. Thanks.
英语说的不好，请见谅。以下是中文内容。 通过PDF.js我能获取到大纲的Array，但是我没法把大纲的每一项和真实的页码联系起来。 我想在页面渲染的时候获取页码，这样点击大纲里面的东西就可以跳转到对应的页面。 大纲：Outline、OutlineView。

请问你租后是如何“实现点击大纲里面的东西就可以跳转到对应的页面"

------------------ 以下是回复 ------------------
我没有实现这个功能。
最后的解决方案是直接基于mozilla/pdf.js的html-js官方示例，修改CSS和JS实现自己想要的功能，最后放到vue>static目录下。
如果需要访问PDF文件，就要跳出VUE页面。
------------------ 原始邮件 ------------------
发件人:                                                                                "mozilla/pdf.js"                                                                                @.>;
发送时间: 2023年10月20日(星期五) 晚上8:09
@.>;
<EMAIL_ADDRESS>主题: Re: [mozilla/pdf.js] Issue: The relations between outline-item and real-page. (Issue #14868)
……
请问你租后是如何“实现点击大纲里面的东西就可以跳转到对应的页面"
Message ID: @.***>

The reply in Chinese was actually deleted. I solved this problem by upgrading the version. Upgrade to version 2.16.105. "pdfjs-dist": "^2.16.105"


requirements: Add service_identity to scrapy.txt.

Codecov Report

Merging #5465 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5465      +/-   ##
==========================================
- Coverage   86.55%   86.51%   -0.04%
==========================================
  Files         430      430
  Lines       53043    53043
  Branches     2066     2066
==========================================
- Hits        45912    45891      -21
- Misses       7131     7152      +21

Impacted Files
Coverage Δ

zerver/tornado/ioloop_logging.py
46.66% <0%> (-46.67%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d06a28...a8a97ee. Read the comment docs.

merged, thanks @hackerkid!

@hackerkid what does this do?  In the future, please provide more detail in the rest of a commit message explaining the purpose of changes.

Just to provide some context, this was sort of an emergency fix, but, yeah, we probably should have put more detail in the commit message, and I should have asked for more detail before merging.


Add option to add type of activity from event form

Event form adjust

[x] Different colors for event types
Choose event color while setting up activity type

[x] Implement a Color picker
[x] Add option on select dropdown

Done


Adds documentation for usage with Rails forms

Closes #908
Summary
This PR adds a comprehensive guide to using ViewComponent with forms in Ruby on Rails.
Notable changes

I decided to add a new section to the documentation called Practical Examples as this guide is more of an explanation on how to use ViewComponent for a particular purpose rather than how to use the library itself.
I've removed the forms issue from the Known Issues section and included it inside the guide for forms.

Other Information
I wrote this guide with an opinionated tone as if these were a set of "good practices" when using ViewComponent in the context of Rails forms. The advice in this guide comes from having used this library in place of ActionView for the past year and a half and finding the best way possible to let each part of the framework do what they do best. However these are just the opinions from my experience so any feedback from other heavy ViewComponent users is super welcome!
Navigation screenshot with new section

Snippet of table of contents
For context when reviewing this PR

Thanks @pinzonjulian! I think the "Practical Examples" section is a good idea. I added a few comments and fixes :)

@Spone @JoshTeperman @MatheusRich Thanks for your review! I merged all of your grammar and typo suggestions. I also restructured and rewrote the section about form builders and it's a bit clearer now. Let me know what you think.

Thanks to everyone's comments and suggestions. I believe the current shape of the docs for forms is stable. Thanks for your help and let's wait for it to be reviewed and merged.

Hey! Friendly bump to get this one in. Is there anything preventing it from being merged?

Sorry about the delay @pinzonjulian. Do you mind adding a changelog entry?

@pinzonjulian sorry for the delay in getting you a review! I was holding off on providing feedback here due to the ongoing discussion in https://github.com/github/view_component/discussions/420.
That being said, I'll give this some 👀 today (if you want to hold off on merging for now, @Spone ❤ )

@pinzonjulian let me know if you need help wrapping this up, we can take some time to pair on it!

Closing as stale ❤


MINIFICPP-2346-P2: Added Support to Create MiNiFi Conan2 Package, Easier Integration into C++ RT Infra

@szaszm @martinzink Great news with my recent update, it still is below 1000 updates and believe still eligible for review. This PR is meant to go on top of james94:MINIFICPP-2346-P1.
Here is the command to create the minifi conan package:
cd nifi-minifi-cpp

conan create . --user=minifi --channel=develop -pr=etc/conan/profiles/release-linux

UPDATE: (June 14, 2024): Verified Can Create MiNiFi conan package & run 2 test programs AbstractProcessorTest and MinifiGenerateFlowFileTest, which are both tests from MiNiFi repo now just built and run from conan test_package.

After I create a MiNiFi C++ conan package, conan then compiles the C++ code
in the test_package, which contains 2 C++ test example programs from MiNiFi.
The first program is AbstractProcessorTest from libminifi and the second program
is MinifiGenerateFlowFileTest.cpp. conan will successfully build the test_package
for MiNiFi C++ conan package and link minifi-cpp lbrary aka the conan package
to be used in running these 2 C++ test programs. AbstractProcessorTest succeeds
and I believe MinifiGenerateFlowTest fails on some tests because we are missing
some resource dependencies that are typically available in nifi-minifi-cpp repo,
but currently not available in the minifi-cpp conan package. I just needed to verify
I could use the minifi-cpp conan package to run a few minifi-cpp test programs,
especially the test program that tests the GenerateFlowFile C++ processor within
a minifi-cpp edge data pipeline that was programmatically created.
This update should make it easier now for other companies to bring MiNiFi CPP
into their C++ infrastructure as a library as an alternative to bringing MiNiFi
in as the standalone program

This PR goes right on top of my smaller "PR-1793: MINIFICPP-2346-P1: Integrated Conan2 for OpenSSL, CURL, ZLIB & Build MiNiFi", it just adds the ability for us to use Conan to create for instance a minifi-cpp/0.99.0@minifi/develop conan package for easier integration of MiNiFi C++ into other C++ real-time infrastructure.
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[ ] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[ ] Has your PR been rebased against the latest commit within the target branch (typically main)?

[ ] Is your initial contribution a single, squashed commit?

For code changes:

[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file?
[ ] If applicable, have you updated the NOTICE file?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.

Hi @james94, sorry this PR was closed automatically when I deleted the apache:MINIFICPP-2251 branch (as it was merged a while back) it was based on. Please rebase it to the main branch and reopen the PR.

Closing this PR since conan create support was added to my other PR: https://github.com/apache/nifi-minifi-cpp/pull/1793


StaticDomNodeList seriazilable

Made StaticDomNodeList to implement serializable interface.

Sorry but this has conflicts and is too large, please rebase your branch before starting on a pr.


Quarry does not harvest draconic evolution ores

^ above.
P.s.  Love the quarry. Only problem is too many ores to process.

Yes this is a known problem. It also doesn't harvest gregtech ores. i.e. it doesn't harvest ores that are tile entities

Hi McJty,
are you planning on fixing this behaviour or it's "by design"?
Can you give us some news?
Thanks

I haven't had time to look into this I'm afraid (and I kinda forgot about it too to be honest :-) ) If I get a chance I will look into it

A work around will be present in next version of rftools. You will be able to set a config option so that tile entities are also harvested. Hopefully that fixes the issue. This is still false by default though

Thanks for the fix ;)


Remove the requestRange/requestFull methods from the NetworkManager class

Originally the code in this file was used in both the GENERIC and MOZCENTRAL builds, however that's no longer the case.
Hence we can now directly call NetworkManager.prototype.request and remove these old "helper" methods that only had a single call-site each.

/botio unittest

Thanks


mdivide_right_spd_test.cpp is asinine

by trying to unit test behavior on a matrix with uninitialized cells. See https://github.com/stan-dev/math/pull/135 .

Glad there's a fix on the way.  I agree that testing uninitialized
doesn't make sense --- it's undefined behavior according to the spec.
I hate that C++ has all this undefined behavior.

Bob

On Aug 23, 2015, at 11:50 AM, bgoodri<EMAIL_ADDRESS>wrote:
by trying to unit test behavior on a matrix with uninitialized cells. See #135 .
—
Reply to this email directly or view it on GitHub.

Thanks, Ben.
This was fixed by #154.


Please merge be815e1 into dev channel

commit(s) to merge: be815e1a867d302ad2fbc8db8d7467cfe85319d2
merge instructions: patch CL https://dart-review.googlesource.com/c/sdk/+/83100 (merge had minimal conflicts, just in tests/language_2/language_2_dartdevc.status and an import declaration in pkg/dev_compiler/lib/src/analyzer/element_helpers.dart)
reason: fixes mixin declarations in DDC (new 2.1 language feature). Also fixes top-level inference; the old Analyzer task model does not implement these correctly.
/cc @dgrove @kevmoo @mit-mit @whesse @athomas @vsmenon

Merged in version 2.1.0-dev.9.2


fix: update collections-renames.yml to use the correct action permissions

Please confirm this pull request meets the following requirements:

[x] I followed the contributing guidelines: https://github.com/github/explore/blob/main/CONTRIBUTING.md.
[x] I am not the sole author or employee of a company who created either the topic I am modifying/adding or the collection entry I am modifying/adding.

Which change are you proposing?

[ ] Suggesting edits to an existing topic or collection
[ ] Curating a new topic or collection
[x] Something that does not neatly fit into the binary options above

Editing an existing topic or collection
I'm suggesting these edits to an existing topic or collection:

[ ] Image (and my file is *.png, square, dimensions 288x288, size <= 75 kB)
[ ] Content (and my changes are in index.md)

Please replace this line with an explanation of why you think these changes should be made.

Curating a new topic or collection

[ ] I've formatted my changes as a new folder directory, named for the topic or collection as it appears in the URL on GitHub (e.g. https://github.com/topics/[NAME] or https://github.com/collections/[NAME])
[ ] My folder contains a *.png image (if applicable) and index.md
[ ] All required fields in my index.md conform to the Style Guide and API docs: https://github.com/github/explore/tree/main/docs

Please replace this line with an explanation of why you think this topic or collection should be curated.

Something that does not neatly fit into the binary options above

[ ] My suggested edits are not about an existing topic or collection, or at least not a single one
[ ] My suggested edits are not about curating a new topic or collection, or at least not a single one
[ ] My suggested edits conform to the Style Guide and API docs: https://github.com/github/explore/tree/main/docs

collections-renames.yml workflow runs have been failing since 10/20/2024.  This will fix that.

[x] add farady-retry gem to Gemfile to solve warning in server run

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

Expected failure.  Merging to kick off cron that will create PR.


[BUG] Middleware not being executed before controller handler

Information

Version: 5.65.5

The docs shows that the Use decorator is called just before the controller handler:

So what I did is I created my middleware

And notice that I left a console log to see if it gets executed.. After that I put the @Use() decorator in my route, just like this:

What I expect to happen is that my middleware would run and after it, my controller handler would run, but right now my middleware is never called and I can see the console.log in my controller handler prints undefined since the log variable is set in my middleware.
My console.log('EXECUTED THIS') is never called, I also tried using the UseBefore() decorator but it doesn't work as well
Acceptance criteria

[ ] Middleware should execute before controller handler

@ghmendonca use cannot be used on controller.
Use the @UseBefore instead :)

Hello @ghmendonca
This is not a bug and I think you've misunderstood how express / Ts.ED resolve middlewares ;)
Your LogMiddleware use @Err decorator. This decorator create an express error middleware that is called only if an error occur. This is why your log isn't printed.
I don't understand why you need to create logger. Ts.ED already provide a logger per request and intercept any  error or success response with all request data/response data. Also you can get the current request logger by injecting the Context:
@Get('/')
get(@Context() ctx: Context){
   ctx.logger.info({message: 'Hello'});
}

See https://tsed.io/configuration.html#request-logger . Ts.ED logger is optimized for the production profile because it flush the log after sending the response to the consumer.
If something is missing, I can help you to find a way to cover your needs.
See you
Romain

Hi @Romakita
I see, I didn't know about the @Err decorator that doesn't work like that, I think it's missing this piece of information in the docs then.
And I need my on logger since I need to store everything in database, the request, the response and later my services will communicate to another server and I have to store this information as well. I don't really need to print anything, so that's why I am trying to implement some middlewares to store some logs in the database.
I guess I'll have to create two middlewares, one to execute before and another one in case of error right? Or you have a better idea on how I can implement this?

Maybe the interceptor feature is better for your needs :)

Yeah, but I would still need a middleware to check the authentication and I would have to implement the log thing there, because if the authentication fail, I have to log that.
I managed to get this working with an ErrorMiddleware which uses the @Err() decorator and a LogMiddleware which stores the request data to the database.
@Romakita thanks for your time! If you want to open a new issue to improve the docs around the @Err() middleware, I would be glad to push a PR improving it :grin:


Fix YGEnums references in ReactCxx.xcodeproj

cc @ericvicenti

Thank you @javache for taking your time on this janitorial work!


need help. how to combine script to blender ??

i install blender  and have downloaded the script,
but i cannot find 'Nerfstudio add-ons',
how to process the scipt， steps above say nothing.
my blender:

On the Blender Preferences Add-ons page, select the "Install..." button, then select the downloaded Nerfstudio add-on python script in the file view, and then click "Install Add-on". Then, it should show up on the Add-ons page.


Added support for filtering AMIs by self

Closes: https://github.com/spulec/moto/issues/1396

Coverage decreased (-0.02%) to 92.124% when pulling 4c32a84d7e15b28dedadf2a49868857fe795f243 on gvlproject:master into e75f3ef4d4f7b0fa7e14dbb4431d379b68ae5502 on spulec:master.

Coverage decreased (-0.009%) to 92.132% when pulling 5c32d47c949b2e2efba52f95ebda134a82bec21d on gvlproject:master into e75f3ef4d4f7b0fa7e14dbb4431d379b68ae5502 on spulec:master.

Coverage decreased (-0.2%) to 91.924% when pulling cdda8c64fbda3568192c1b4c5e53874d951945c4 on CloudVE:master into e75f3ef4d4f7b0fa7e14dbb4431d379b68ae5502 on spulec:master.

Coverage decreased (-0.009%) to 92.114% when pulling b1c51faaf5dbf79a76eca29724b7d22b87e27502 on CloudVE:master into e6d0e28e73a0a5176e6adbc9f9654765933a35b8 on spulec:master.


Added bibmanager to Writing Tools section.

Hi,
I'd like you to consider adding this tool to manage references when using latex. I think it could be of interest to other astronomers.
Best,
Patricio.

Hi @dr-guangtou
have you had time to look at this PR?

@pcubillos Thanks for the contribution! The PR has been merged.
Sorry for the late response. Haven't checked the repo for a while...


Tasks in Queue not getting processed.

Hi,
Some of the Tasks was not getting processed. QCluster was running at that instance.
When I restarted the qcluster, all the jobs got processed. Following is my QCluster configuration.
Q_CLUSTER = {
    'name': 'DjangORM',
    'workers': 1,
    'timeout': 300,  # 5 minutes
    'retry': 420,  # 7 mintues
    'queue_limit': 500,
    'bulk': 10,
    'orm': 'default'
}

I have been using DjangoQ for approx 2 months. I have faced this issue only 2 times.

@anroopak could you provide a bit more information?
What kind of Tasks are not handled before you restart qcluster ?


FIX: numpy.linspace parameter num must be integer

np.ceil is a conservative interpretation of a float for number of elements to create with linspace, ensuring an oversampling rate of at least that specified. If approximate is all that's needed, then floor might save a little computation, and rint would be the best approximation.
Also proposed in bids-standard/pybids#302.

Given that ceil breaks tests, I'm assuming we've been implicitly relying on rounding. Switching to rint.


[Request] Notification on item drop

Notifications when a certain tier (low, medium, high or insane value) item drops from a monster. Would save the hassle of using another piece of software to detect certain colors when runescape is on my secondary monitor for example.

Duplicate of #3643


EFS Volume deleted after instance termination

I was of the idea that the EFS volume would be created once and it will get attached to any created EC2 instance, keeping all data intact in case of EC2 instance termination, but this did not happen.

The screenshot of my Auto Scaling group tells the story, the first run was on 10/16 and the instances got terminated at 10/26 and a new one was delployed.
Now if we see the current volumes created we see the the only one created at 10/26 (same date as the new instance deployment

So it seems that the volume is getting recreated as well.
Sadly I think I lost the old world we were playing, but hopefully someone knows how to fix it so this doesn't happen to other players

hey @wsetws, your world should be located in /opt/minecraft which should be mounted via EFS
df -h should show an "fs-xxxxxx.efs.ap-xxx.amazonaws.com:/" mounted as "/opt/minecraft"


Always treat struct field IDs as ::16-signed

We were using using ::size(16) in many cases, which is an unsigned
integer value. The specification says this should be a signed value.

This is unlikely to mean much in practice, but it's good to follow the spec consistently.


Drop storage of active tracing time (EXPOSUREAPP-4524)

Removed Active Tracing Time which was the last data to still be persisted in encrypted data base. Remove encrypted data base and password for it.

That must have felt good 😁

it did

Will remove remaining resources in another PR after merge of @SamuraiKek s PR.


Falcon  Multiplication(M) , Matrix Multiplication(S,M) , Beaver Triple Generation.(S-Semi-honest,M-Malicious)

Description
Implementation of Falcon Malicious Multiplication ,Matrix Multiplication(Semi-honest,Malicious), fixes #158 , #160, #172.
Note :
I have implemented as per the falcon protocol, there are some cases , where round complexity could be reduced due to our orchestrator model, feel free to point out.
How has this been tested?
Added tests for the same.
Checklist

[x] I have followed the Contribution Guidelines and Code of Conduct
[x] I have commented my code following the OpenMined Styleguide
[x] I have labeled this PR with the relevant Type labels
[x] My changes are covered by tests

The functionality looks correct, but would still require a unit test. One way I thought was to add a function in unit tests that is exactly the same as mul_malicious(https://github.com/rasswanth-s/SyMPC/blob/58a608d54eac68724482776c81dd90dbee1c8a88/src/sympc/protocol/falcon/falcon.py#L251) but adds some random value to the result of multiplication. So this does not end up testing mul_malicious as a whole but ends up testing functionality of triple_verification and falcon_mask indirectly.
It would be great to have a way in which the orchestrator could directly manipulate values such that we test the entire mul_malicious.


added custom url redirect option, and updated readme

I updated the readme, and added a custom url redirect option, following the comment on issue number 7 by astridjerald

Thanks, see daa75f6c622feb0495384e53eefb109a920ac4fc


Docker rmi with dangling=true unsafe while images are being pulled

I was reading the docker documentation (https://docs.docker.com/reference/commandline/cli/), and noticed the following recommendation for batch clean up of dangling images:
sudo docker rmi $(sudo docker images -f "dangling=true" -q)

I was excited when I saw the dangling=true filter since having large numbers of dangling images was creating problems in our build environment. However, I believe this command is unsafe while pulling images since there there are brief points while images are being pulled when docker considers them dangling. To test this, I ran a script which simply pulls 10 images from our private registry, one after another. While this was running I ran the following command in a separate terminal:
while true; do docker rmi $(docker images -q -f "dangling=true"); sleep 1; done

I noticed that during the pull process, images were being occasionally deleted. Assuming the pull was successful, I will sometimes tag the image from <private_registry>/<name> to just <name>. After the end of the pull, all images are listed when I run docker images, however when I try to run an affected image, I see something like this:
stack@bc03:~$ docker run -ti cassandra
Unable to find image 'cassandra' locally
Pulling repository cassandra
2014/11/03 08:36:01 Error: image library/cassandra not found

The image cannot be found since it was retagged to remove the <private_registry> part of the name. My hope was that I could run this command automatically every day to clean up any dangling images, but that is not possible since I may accidentally destroy images that are being pulled.
I believe that the dangling=true filter should not show images or components of images that are in the process of being pulled...

cc @mitar

Hello,
I have sent a PR #11784 trying to fix this issue

I'm reopening this, since the code that fixed it got removed, and we need an alternative fix and I want this issue to be tracked for 1.10.

@tiborvass The pull problem that this issue is desrcibing should be still fixed as there are no intermediate images that could turn up in dangling=true. What you are describing is a related issue where parent images could be removed during build, causing the build to error

The issue is solved regarding pull, but still applies to build.
Ping @tiborvass: we should track the build problem in a separate issue.


python3Packages.oscscreen: init at unstable-2023-03-23

Description of changes

This is a fork of npyscreen by Outscale. There are a few changes that have been done and the library will be required as a dependency to another package I’m working on rn.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/3477

@ofborg build python3Packages.oscscreen


support search space recommendation

If user provides a dataset and wants to find the best model from some candidate models, it would be better to provide proper search space for each model. To better support this scenario, the new component which recommends good search space can be added into nni.

So, what candidate models should be supported to recommend search space ?

Tracked with #878. Closing this issue for now.


funding: move Manager to own package

Moves the FundingManager to the fmgr package. Will help a lot with unit testing. The last commit should be viewed with a git client with --color-moved as GitHub is too picky to see the fundingmanager.go -> fmgr/manager.go as a code-move (93% of the code is identical ~ 180 LoC change).

q: would it be more idiomatic Go to have the package name as funding and then rename FundingManager as Manager?

I think funding is a better name for the package and I agree with the rename to Manager.

If the package is named funding and what was previously the fundingManager is now the Manager, then what will the interface that Manager satisfies be called?

The interface is named Controller - also removed the PendingChannels() from the Manager as it was totally unused. Perhaps this visibility can be added later once the code is cleaned up a bit.


Update README.adoc

Fix star character by escaping

@kebritam Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

@kebritam Thank you for signing the Contributor License Agreement!

It's an asciidoctor question. For me this is now rendering as
th:field="*{name}" and th:field="\*{age}"

(So the second asterisk is showing its \ escape prefix.) I guess that's wrong?

I guess we need the first backslash but not the second one. Thanks, Dave.

I noticed that we had an older PR that fixed this issue and a couple others. I have merged that one, so we can close this one. Thanks.


GoRethink stopps working after some days

I am using the gorethink database driver for a web project. I always get the following error after some days:
gorethink: no connections were available

I searched for this error in the source:
// GetRandomNode returns a random node on the cluster
// TODO(dancannon) replace with hostpool
func (c *Cluster) GetRandomNode() (*Node, error) {
	if !c.IsConnected() {
		return nil, ErrClusterClosed
	}
	// Must copy array reference for copy on write semantics to work.
	nodeArray := c.GetNodes()
	length := len(nodeArray)
	for i := 0; i < length; i++ {
		// Must handle concurrency with other non-tending goroutines, so nodeIndex is consistent.
		index := int(math.Abs(float64(c.nextNodeIndex() % int64(length))))
		node := nodeArray[index]

		if !node.Closed() && node.IsHealthy() {
			return node, nil
		}
	}
	return nil, ErrNoConnections
}

Could it be, that gorethink drops all active nodes after a long idle timeout?

Does the driver log any errors? If not could you try running your code with this flag set to true, hopefully that should provide some more information about what is going wrong https://godoc.org/github.com/dancannon/gorethink#SetVerbose.

Also related to this issue I think I should probably work on adjusting the logging levels to be more useful. Currently pretty much all logging is set to debug level which is hidden by default.
That being said I also think you should be able to remove all logging. I will look into this as part of fixing this issue.

Ok I have now figured out exactly what is going wrong, after the addition of cluster support each node has a "health" attached to it, currently this is pretty basic as it is just a counter from 0-100. If the health drops to 0 then a node becomes unhealthy and the driver will stop sending requests to the node. There is also a goroutine for each node which attempts to refresh the status of the node every 30 seconds by querying the server_status table using the nodes ID.
This causes issues when not using the DiscoverHosts flag as there is no (easy) way to get the nodes ID so the query to server_status fails and the node is never refreshed.  This means that if a query fails 100 times then the node becomes unhealthy and never recovers.

Could this also explain #194?

I think they are unrelated but I will double check
On Fri, May 29, 2015 at 8:14 AM -0700, "omeid"<EMAIL_ADDRESS>wrote:
Could this also explain #194?
—
Reply to this email directly or view it on GitHub.

I have created a branch which has host discovery enabled by default. I hope to merge it soon.

@dancannon: Thank you for your efforts! I have set my application to verbose logging. I'll report any further issues regarding this issue. Hope I'll get some more useful information! We have to be patient^^

Gorethink failed again without throwing any log messages. The web application is running now for 4 days. Gorethink failed after 2 days. The only error I get on queries is:
gorethink: no connections were available
Each few hours the application checks the users database table for expired users which did register but never log in for at least 3 weeks. So this can't be an idle timeout problem. There are currently no new users and this query failed each time, because the passed slice of user IDs to delete was always empty. I fixed this by checking the length of the IDs slice and skipping the deletion. However gorethink's connection to the database should not break, even if the deletion query fails.
r.Table(DBUserTable).GetAll(ids...).
		Delete().RunWrite(db.Session)

gorethink: Expected 2 or more arguments but found 1. in:    r.Table("users").GetAll().Delete()
This was the last successful database query, even if it threw an error.

Thanks for checking @m4ng0squ4sh, was your last test with the master branch? If so I have just deployed a new version of the driver which should hopefully fix your issue.
If not could you let me know and I will reopen this issue.

Great thank you @dancannon! Yeah, I am on the master branch. I just updated to the new database naming conventions and pulled the latest source from gorethink. I'll reopen this issue if this is not fixed.


FP ice phishing

This could be linked with https://github.com/forta-network/starter-kits/issues/409
The scam detector is pointing out:

This alert and the tx linked seems to be a nromal swap

Here another example and the tx here

Similarly to https://github.com/forta-network/starter-kits/issues/409, the token was falsely alerted as suspicious by the "Malicious Smart Contract ML V2" bot,
The number of unique tx initators check (see comment on the other issue) wouldn't work in this case, as the "suspicious" contract was self-destructed and so the number of initiators returned is 0.
In the future, we could consider adding an Etherscan label check for the suspicious contract (The etherscan pro endpoint is required in this case)

Not a priority at the moment

Closing this, as the specific alert has been removed from the Scam Detector.


[OAP-2006] [oap-native-sql] Follow-up: Disable the cases by default

What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)

@zhouyuan please review

Jenkins is happy now


Update MySQL State store

What content needs to be created or modified?
The MySQL State store has been updated to allow a 64bit encoded PEM to be used instead of reading from disk. This will allow the component to be used in K8s where you can't read a file from the sidecar. You can now store the PEM in a secret. I tested with Azure Keyvault.
The string must be 64bit encoded so the new lines are retained.
Describe the solution you'd like
Add a section for local vs k8s configuration. There was a new metadata field added to how the Pem Contents for k8s whereas for local it can be a Pem Path.
Where should the new material be placed?
On the existing MySQL State store docs page.
Additional context

@DarqueWarrior is this still missing here? https://docs.dapr.io/reference/components-reference/supported-state-stores/setup-mysql/

I will complete next week. Sorry for delay. Docs have been getting pushed. I will make a priority.

This can be closed. The changes are in docs now.


XMI Serialization

Serialize the data structure as UIMA XMI, using a fixed typesystem.

Ongoing work on branch xmi-issue-51.

Merged 9879baac062aeffe0d9a977606e8e24bccb808eb to master

the full path used to localize the input files is recopied in the path to store the output files
for example: alvisnlp --input /path/to/locatize/input --output /path/to/the/output will give the result files into /path/to/the/output//path/to/locatize/input
could we put the ouput files directly into  /path/to/the/output ?

What if your input directory contains:
input
  \- foo
    \- file1.xmi
    \- file2.xmi
  \- bar
    \- file1.xmi

How do you make the difference between foo/file1.xmi and bar/file1.xmi ?

I propose to just consider the part of the input path that is not given by the user.
if  data are into
to/path
  \- input
      \- foo
         \- file1.xmi
         \- file2.xmi
     \- bar
        \- file1.xmi

and user gives  --input path, we consider the following in the output path
input
 \- foo
 \- bar

Nope, cannot do that. The information is lost at this point.
However, take a look at the parameter baseNameId of TextFileReader. Just assume there are no duplicate filenames.
https://bibliome.github.io/alvisnlp/reference/module/TextFileReader#baseNameId

ed876c5a1d0a34ba9807cafd45cc4593f32cd230 adds a baseNameId parameter to XMIImport.
Merged on master.

@mandiayba may I close this?

yes @rbossy


Fatal error: Call to undefined method QuBit_UniversalVariable_Helper_Data::getCategoryProductListBlockName()

Fatal error: Call to undefined method QuBit_UniversalVariable_Helper_Data::getCategoryProductListBlockName() in /home/admin/domains/********/public_html/app/code/community/QuBit/UniversalVariable/Model/Observer.php on line 17
Happened to a someone after upgrading from an old version of the module to this one.
On Magento <IP_ADDRESS>, I have replicated this exact process and ran into no issues, and can't figure out how it wouldn't be able to find the function in helper/Data.php

@firewizard any ideas on this one ?

I'm using this on <IP_ADDRESS>, so that's not the problem - and it wouldn't make sense to be a magento issue.
It's clearly not a caching issue, since the helper is properly picked up.
So the only possible cause for this is one of the follwoing:

QuBit_UniversalVariable_Helper_Data present in local code pool
compiler enabled and not recompiled (probably not the case)
Data.php hasn't been overwritten - ask them to check the file (app/code/community/QuBit/UniversalVariable/Helper/Data.php) and see if the method is present on line 76
again, less likely, they're using some heavy opcaching that might need flushing (retarting the webserver might help, if none of the above apply)

Thanks @firewizard
The data.php not being overwritten was my first thought but using the magento connect updater should overwrite the old one surely?
However they also sent me this error:
2015-02-11T15:06:03+00:00 ERR (3): Warning: include(): realpath failed to canonicalize Mage/Core/Model/App/Area.php - bailing  in /home/admin/domains/staging.odesi.nl/public_html/lib/Varien/Autoload.php on line 93
2015-02-11T15:06:03+00:00 ERR (3): Warning: include(): realpath failed to canonicalize Varien/Event/Observer.php - bailing  in /home/admin/domains/staging.odesi.nl/public_html/lib/Varien/Autoload.php on line 93
2015-02-11T15:06:03+00:00 ERR (3): Warning: include(): realpath failed to canonicalize Varien/Event.php - bailing  in /home/admin/domains/staging.odesi.nl/public_html/lib/Varien/Autoload.php on line 93
2015-02-11T15:06:03+00:00 ERR (3): Warning: include(): realpath failed to canonicalize Mage/Cron/Model/Observer.php - bailing  in /home/admin/domains/staging.odesi.nl/public_html/lib/Varien/Autoload.php on line 93
2015-02-11T15:06:03+00:00 ERR (3): Warning: include(): realpath failed to canonicalize Mage/Cron/Model/Schedule.php - bailing  in /home/admin/domains/staging.odesi.nl/public_html/lib/Varien/Autoload.php on line 93
2015-02-11T15:06:03+00:00 ERR (3): Warning: include(): realpath failed to canonicalize Mage/Cron/Model/Resource/Schedule.php - bailing  in /home/admin/domains/staging.odesi.nl/public_html/lib/Varien/Autoload.php on line 93
2015-02-11T15:06:03+00:00 ERR (3): Warning: include(): realpath failed to canonicalize Mage/Cron/Model/Resource/Schedule/Collection.php - bailing  in /home/admin/domains/staging.odesi.nl/public_html/lib/Varien/Autoload.php on line 93
2015-02-11T15:06:03+00:00 ERR (3): Warning: include(): realpath failed to canonicalize Varien/Event/Observer.php - bailing  in /home/admin/domains/staging.odesi.nl/public_html/lib/Varien/Autoload.php on line 93
2015-02-11T15:06:03+00:00 ERR (3): Warning: include(): realpath failed to canonicalize Varien/Event.php - bailing  in /home/admin/domains/staging.odesi.nl/public_html/lib/Varien/Autoload.php on line 93
2015-02-11T15:06:03+00:00 ERR (3): Warning: include(): realpath failed to canonicalize Mage/Cron/Model/Observer.php - bailing  in /home/admin/domains/staging.odesi.nl/public_html/lib/Varien/Autoload.php on line 93

which looks like a compilation error potentially?

I don't use Magento Connect on any production server, I simply dont like
the idea and the implications, so I couldn't say. I guess if it can't
overwrite a file it throws an error, so let's exclude that for now.
However, just as a confirmation, ask them to look in the helper file and
check if the method exists. If it does, then it's definitely an opcache
issue. Which aslo correlates with the log error - see the following answer:
http://stackoverflow.com/questions/15342280/exception-include-realpath-failed-to-canonicalize-service-response-php-bai
On 2/18/2015 12:54 PM, rogan wrote:

Thanks @firewizard https://github.com/firewizard
The data.php not being overwritten was my first thought but using the
magento connect updater should overwrite the old one surely?
However they also sent me this error:
|2015-02-11T15:06:03+00:00 ERR (3): Warning: include(): realpath failed to canonicalize Mage/Core/Model/App/Area.php - bailing  in /home/admin/domains/staging.odesi.nl/public_html/lib/Varien/Autoload.php on line 93
2015-02-11T15:06:03+00:00 ERR (3): Warning: include(): realpath failed to canonicalize Varien/Event/Observer.php - bailing  in /home/admin/domains/staging.odesi.nl/public_html/lib/Varien/Autoload.php on line 93
2015-02-11T15:06:03+00:00 ERR (3): Warning: include(): realpath failed to canonicalize Varien/Event.php - bailing  in /home/admin/domains/staging.odesi.nl/public_html/lib/Varien/Autoload.php on line 93
2015-02-11T15:06:03+00:00 ERR (3): Warning: include(): realpath failed to canonicalize Mage/Cron/Model/Observer.php - bailing  in /home/admin/domains/staging.odesi.nl/public_html/lib/Varien/Autoload.php on line 93
2015-02-11T15:06:03+00:00 ERR (3): Warning: include(): realpath failed to canonicalize Mage/Cron/Model/Schedule.php - bailing  in /home/admin/domains/staging.odesi.nl/public_html/lib/Varien/Autoload.php on line 93
2015-02-11T15:06:03+00:00 ERR (3): Warning: include(): realpath failed to canonicalize Mage/Cron/Model/Resource/Schedule.php - bailing  in /home/admin/domains/staging.odesi.nl/public_html/lib/Varien/Autoload.php on line 93
2015-02-11T15:06:03+00:00 ERR (3): Warning: include(): realpath failed to canonicalize Mage/Cron/Model/Resource/Schedule/Collection.php - bailing  in /home/admin/domains/staging.odesi.nl/public_html/lib/Varien/Autoload.php on line 93
2015-02-11T15:06:03+00:00 ERR (3): Warning: include(): realpath failed to canonicalize Varien/Event/Observer.php - bailing  in /home/admin/domains/staging.odesi.nl/public_html/lib/Varien/Autoload.php on line 93
2015-02-11T15:06:03+00:00 ERR (3): Warning: include(): realpath failed to canonicalize Varien/Event.php - bailing  in /home/admin/domains/staging.odesi.nl/public_html/lib/Varien/Autoload.php on line 93
2015-02-11T15:06:03+00:00 ERR (3): Warning: include(): realpath failed to canonicalize Mage/Cron/Model/Observer.php - bailing  in /home/admin/domains/staging.odesi.nl/public_html/lib/Varien/Autoload.php on line 93
|
which looks like a compilation error potentially?
—
Reply to this email directly or view it on GitHub
https://github.com/QubitProducts/UniversalVariable-Magento-Extension/issues/48#issuecomment-74845969.

Will follow up with them.


Downloading size not showing

Steps to reproduce
On downloading ep
There is no size shown
Expected behavior
If it show the size then it will be helpful
Actual behavior
Its not showing showing sometimes it cross 1gb size

Crash logs
No response
Aniyomi version
<IP_ADDRESS>
Android version
11
Device
Mi
Other details
No response
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] If this is an issue with an extension, I should be opening an issue in the extensions repository.
[X] I have tried the troubleshooting guide.
[X] I have updated the app to version <IP_ADDRESS>.
[X] I have updated all installed extensions.
[X] I will fill out all of the requested information in this form.

https://github.com/aniyomiorg/aniyomi/issues/238


return the replacement offset and length

@lukechurch

return the replacementOffset and replacementLength for code completion results
escape Maps and Lists in the cc results, instead of converting to strings. In the future we could move to a more structured type for individual cc results.
ws changes and re-gen the discovery library

lgtm, I'll replace the TODO comment


Installer: Patch Steam Library Files (Fixes #113, #119)

Well it's worse than what we had before, but not much of a choice.
Adds steam patching ala SFP to the installer, which will get the library theming working again.
This does mean a reinstall will have to be performed on client update, unless we want to make the installer have an option to run in the background and watch for file changes. I think the graphical installer would be a better place for something like that though.
This has some bits for chat patching too, but as that still works for the moment I've left it as is.
Moving forward we'd probably want to do something cleaner and have chat/library specific css files rather than the monolithic webkit.css, but shrug.

Should be good enough for now. I don't think it's worth doing anything more that that until we get an answer to the issue or until we see what will be changed in the next few betas.
Valve is porting a lot of things from VGUI recently and now it seems they are working on the new Settings dialog, so I expect to see more big changes soon.
I hope Valve will provide a supported way to modify CSS, but the most likely outcome I expect at this point is them removing the official skin support entirely as they transition from VGUI.

@Foldex I'm packaging this for NixOS and I have to convert the code you added to bash, can I communicate with you somehow? i have some questions.

@IceDBorn
I'm not too familiar with Nix, but is there a particular reason you would need to convert it to bash? I can't imagine it would have issues supporting a python script.
You can reach me at<EMAIL_ADDRESS>

@IceDBorn If you want to package the skin itself and not the graphical installer app, consider a few problems you'll have:

Steam only loads skins from ~/.steam/steam/skins (~/.var/app/com.valvesoftware.Steam/.steam/steam/skins for flatpak).
Symlinks don't work for skins, Steam won't detect symlinked skins.

So you'll have to somehow install the skin to the user's home directory, which is usually a discouraged practice for most package formats and distros, or not possible, at least without custom post-install scripts. I don't know if it's allowed or encouraged for Nix packages.

Another problem is that this skin is configurable and some parts of it are generated at install time, so it doesn't make a lot of sense to package it. Maybe this is not much of a problem for Nix as opposed to other package formats if a Nix package can have options.

@tkashkin I package the skin and then use home manager to place the files to the correct path. Home manager uses symlinks, symlinking the whole folder does not work but doing so with individual items recursively works.

Here's the bash code I ended up with

@Foldex
I've noticed a problem: the stylesheets we patch are also applied to the Deck UI/New Big Picture and they break some things there.
We'll need to adjust selectors to only apply to the desktop client, or make some Deck/BP specific fixes. I don't think the skin should touch BP at all, at least for now, so the first option is better.


not really a bug but where can we tell you if a game is playable or not?

what the title says

Should be a small emoji on upper left corner of the game image.

The way this detects if the game is playable is by parsing it's issue page on game-compatibility. I have plans on creating something like ProtonDB where users can submit their results (as an alternative way of game-compatibility repo) and then using that, but can't promise much.


Tornike/legals update

[ ] Create content for privacy policy page
[ ] Create content for terms of use page
[ ] update links to new pages

We can delete the PDFs from /static now too


skeleton for dark mode

Hey, It's great component!!
But when it comes to dark mode I got some problems because I can't change the background linear-gradient color.
.animation--wave::before {
    background: linear-gradient(90deg,transparent,rgba(255,255,255,.5),transparent);
    animation: wave 1.5s linear .5s infinite;
}

dark color with white wave didn't seem fit for me.
any tips?

This has been fixed in the latest patch. You can now use the wave-color props to specify the color


MRG: Fix raw sim with BEM and use_cps=True

Fixes a bug when using a BEM where:

Corner case: the BEM surface was transformed without copy for the purposes of forward omission testing, so on return if bem was passed directly it was modified.
Fix accounting of src[ii]['patch_info'] and src[ii]['pinfo'], instead of delete recreate after reducing source space as in _make_forward.py so that patch stats can actually be used.

Still need to:

[x] add round-trip testing for forward w/identity
[x] add non-modification-of-BEM test

Okay tests pushed, ready for review/merge from my end.

Failures and just of the standard iffy unrelated OSX variety

good to go. Please back port thx

Merged by rebase and backported


c-api: allow top level API to set wasm-timeout

Feature
Hi Folks,
Thanks for creating this wonderful runtime. I was wondering if there are any plans to expose wasm-timeout at c-api level ?
It will allow users of c-api to timout the runtime as per the needs.
Benefit
Provides a timout knob for c-api users, giving more control to the end users.
Implementation
Maybe creating a top level interface and make timeout part of wasi_config_t could work ?

If can understand that more than enough issues are already there and upstream maintainers are already busy, If the idea looks good I'd like to help by implementing this feature. :smile:


🚧 Dev ➾ Adjust flextesa plugin to be image agnostic

🔗 Epic|Feature Link
No response
🚥 Definition of Done

[x] 🎯 Planning and Design
[ ] 🏎 Dev Implementation Complete
[ ] ♾ PR Merged
[ ] 🏆 Product Acceptance

🧰 Work Description
Right now we built a package for managing the flextesa sandbox called taqueria-flextesa-manager, and then we build our own image that extends the oxheadalpha image and bundles the taqueria-flextesa-manager.
This refactor will just use the oxheadalpha image directly, removing the need for our own image or the taqueria-flextesa-manager.
This will make it easy for developers to use any flextesa image they want, as we already have the ability for users to override the image used via setting an environment variable, but without the flextesa plugin being image agnostic, that feature isn't all that useful.
✅ To Do
Refactor the plugin to manage the sandbox using only the oxheadalpha image
⚖ Acceptance Criteria

E2E tests pass using refactored plugin
Added test case for using a different flextesa image

🔭 Scope
N/A
Code of Conduct

[X] I agree to follow this project's Code of Conduct

We should wait for the env refactor, to avoid a merge conflict mess again, before pursuing this.

Done


"Breasta" is listed in the drop-down menu

Description:
"Breasta" is listed in the drop-down menu alongside its corresponding county and commune, according to the law.
Precondition:
The website is up an running.

Step 1
Type "Breasta" in the search bar.

Expected results
The location is listed in the drop-down menu as "Comuna Breasta, DOLJ".


UserSchema modified

🛠 Fixes Issue

Closes #156
👨💻 Changes proposed
Added field for resetToken inside userSchema.

✔ Check List (Check all the applicable boxes)

[x] My code follows the code style of this project.
[x] This PR does not contain plagiarized content.
[x] The title of my pull request is a short description of the requested changes.

📷 Screenshots

@KaizenGirl1111
Please review

@KaizenGirl1111
Can you please merge?or any changes required?


Fix focus configuration

Focus can also be divided into:

Inputs
Buttons (Button, Rating, Toggle)

We can think on these lines how we want our api to behave and how we want to document the details.


Implements new utility methods to handle the request headers

Summary of Changes
For now, the request headers can be set using config variable. This PR updates the mechanism to allow to pass a function to generate headers dynamically based on the app state by passing in the current app. This will help pass the authorization headers across different microservices i.e., JWT tokens.
Also, refactored the code and put the call and headers within the single place in the codebase.
Tests
No tests are added as this simply refactors the code a bit.
Documentation
No documentation needed. Added the docstring for newly added functions.
CheckList
Make sure you have checked all steps below to ensure a timely review.

[X] PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"

In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

[X] PR includes a summary of changes, including screenshots of any UI changes.
[X] PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
[X] In case of new functionality, my PR adds documentation that describes how to use it.

All the public python functions and the classes in the PR contain docstrings that explain what it does

[X] PR passes all tests documented in the developer guide
[X] I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message"

Codecov Report

Merging #143 into master will increase coverage by 20.08%.
The diff coverage is 83.33%.

@@             Coverage Diff             @@
##           master     #143       +/-   ##
===========================================
+ Coverage   52.71%   72.79%   +20.08%
===========================================
  Files         106       20       -86
  Lines        2637      886     -1751
  Branches      268       73      -195
===========================================
- Hits         1390      645      -745
+ Misses       1216      211     -1005
+ Partials       31       30        -1

Impacted Files
Coverage Δ

amundsen_application/config.py
100% <100%> (ø)
:arrow_up:

amundsen_application/api/search/v0.py
74.41% <100%> (ø)
:arrow_up:

amundsen_application/api/metadata/v0.py
75.32% <100%> (-0.25%)
:arrow_down:

amundsen_application/api/v0.py
40% <50%> (-1.94%)
:arrow_down:

amundsen_application/api/utils/request_utils.py
56.09% <66.66%> (+4.37%)
:arrow_up:

...ication/static/js/components/common/Tabs/index.tsx

...ndsen_application/static/js/ducks/search/api/v0.ts

...ication/static/js/components/common/Flag/index.tsx

...ts/common/ResourceListItem/TableListItem/index.tsx

...sen_application/static/js/ducks/allTags/reducer.ts

... and 81 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d34022c...f3f099e. Read the comment docs.

Ready For review
@feng-tao

thanks @verdan . The code LGTM, cc @ttannis to add additional eye :)

@verdan will take a look today. We do have a small UI bug that we have to fix before pushing the new version, but we'll be sure to fix that today as well so we can push the new version.

We will merge and push a library version after resolving #144

@ttannis I think it is fine to push this one in first. We could resolve the user issue with a new minor version.
@verdan just publish it to pypi.


Fix mixed types in GPU sketching.

Close https://github.com/dmlc/xgboost/issues/7227 .

Codecov Report

Merging #7228 (f6dc390) into master (037dd08) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #7228   +/-   ##
=======================================
  Coverage   82.64%   82.64%
=======================================
  Files          13       13
  Lines        4021     4021
=======================================
  Hits         3323     3323
  Misses        698      698

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 037dd08...f6dc390. Read the comment docs.


Show commits of current branch

Use case: I want to see a list of commits in my current branch, and just those. Both Show Current Branch History and the branch view in the sidebar list all commits reachable from HEAD which is technically correct but I'm often interested only in "my commits".
The Git command that produces the desired output is
git log $(git merge-base master HEAD)..HEAD

(Most commonly, it can be just git log master..HEAD.)
In the UI, I think this could be another top-level node in the sidebar, something like Current branch.

BTW, it could also be useful for content comparison as there are some usability issues with it current, see e.g. "Compare selected ancestor with working tree" needs "select for compare" #279.

So the sidebar could look like this:
- Current branch
    - Diff
       - ... here is a file tree, introduced in #240 ...
    - Commits
       - [avatar] My second commit
       - [avatar] My first commit
- Branches
- Remotes
- Stashes
- Tags

Ah interesting, I think the biggest challenge here, is picking the branch that is the base -- here you are always using master, but that isn't always the case.

You're right. git-tree-compare deals with that using Change Base...:

I like the "commits behind master" view that Bitbucket gives, and I believe this feature would essentially be the equivalent.

@borekb I've added a new experimental new Compare  with... node to each repository. It will let you pick the comparison and it persists based on the workspace/repo/branch. You must set "gitlens.insiders": true before it will show up.
gitlens-9.7.4.vsix.zip
Could you try it out and let me know if this will solve this issue for you? Thanks!

Thanks, I like the contents of that node but I'd prefer if this was just directly under the branch. Here's how I see it:

I understand the challenge with the "base branch" but still think this can be a global setting as per https://github.com/eamodio/vscode-gitlens/issues/293#issuecomment-367846197.

While I see what you are saying, I find the branch history regularly quite valuable. In 9.8 I've add the new comparison node similar to the above. Hopefully that meets your need closely enough.

There seems to be many good changes around this in v9.9:

The number of commits (12) in case of a two-dot mode is correct, however, the files are not correct: there's not 28 of them but 13 – Git Tree Compare & GitHub Pull Requests extensions show that correctly. Is that a bug or is this feature supposed to work differently?

I just spot the same behavior. It looks like the files changed are always diff with the 2 dot approach.

@borekb @Morikko sorry, that is a bug -- can you pls open a new issue for this?

👍 , done that in #797.

I'm totally on board with borekb's request. This is SO confusing to me to read. I don't understand what's going on, even though I now know this is happening. I just want my commits to show up like they do when I'm viewing a branch in a repo online. This should be an option to make it the main view in Repositories, and probably the default behavior as well.

Also it's showing me commits from a different branch in the other branch I'm currently viewing...? Like what the heck.


Refactor

Renamed files to not shadow stdlib modules (code, secrets)
Converted string concatenation to f-strings
Converted except statements to not user bare except
https://docs.sourcery.ai/Reference/Rules-and-In-Line-Suggestions/Python/Default-Rules/do-not-use-bare-except/
Converted sugerDetails dict to add assignment at creation time.

Cool!
Q: CircuitPython says code.py is preferred but both work. Is there a specific recommendation or reason for one or the other?

Its mainly around during an import it could mistakenly import the local python file instead of the required stdlib or vice versa. I've had that issue before where I couldn't import a function from the stdlib as the local file had the same name as the module I trying to import from. Here's the ones in the stdlib.
https://docs.python.org/3/library/code.html
https://docs.python.org/3/library/secrets.html

Thanks! :shipit:


Assertion error on tokenization of valid input text

I get an assertion error when processing text with multiple full stops surrounded by word characters.
Minimal reproducible code:
import spacy
en_nlp = spacy.load('en')
doc = en_nlp(u's.....h') # works fine
doc = en_nlp(u's......h') # AssertionError

spaCy version: 0.100.7
OS: Ubuntu 14.04
Running in ipython console

/home/sc9/anaconda/lib/python2.7/site-packages/spacy/language.pyc in __call__(self, text, tag, parse, entity)
    223         ('An', 'NN')
    224         """
--> 225         tokens = self.tokenizer(text)
    226         if self.tagger and tag:
    227             self.tagger(tokens)

/home/sc9/anaconda/lib/python2.7/site-packages/spacy/tokenizer.pyx in spacy.tokenizer.Tokenizer.__call__ (spacy/tokenizer.cpp:4835)()
    130             cache_hit = self._try_cache(key, tokens)
    131             if not cache_hit:
--> 132                 self._tokenize(tokens, span, key)
    133             tokens.c[tokens.length - 1].spacy = string[-1] == ' ' and not in_ws
    134         return tokens

/home/sc9/anaconda/lib/python2.7/site-packages/spacy/tokenizer.pyx in spacy.tokenizer.Tokenizer._tokenize (spacy/tokenizer.cpp:5409)()
    157         orig_size = tokens.length
    158         span = self._split_affixes(tokens.mem, span, &prefixes, &suffixes)
--> 159         self._attach_tokens(tokens, span, &prefixes, &suffixes)
    160         self._save_cached(&tokens.c[orig_size], orig_key, tokens.length - orig_size)
    161

/home/sc9/anaconda/lib/python2.7/site-packages/spacy/tokenizer.pyx in spacy.tokenizer.Tokenizer._attach_tokens (spacy/tokenizer.cpp:6444)()
    229                         infix_end = match.end()
    230                         span = string[start:infix_start]
--> 231                         tokens.push_back(self.vocab.get(tokens.mem, span), False)
    232
    233                         infix_span = string[infix_start:infix_end]

/home/sc9/anaconda/lib/python2.7/site-packages/spacy/tokens/doc.pyx in spacy.tokens.doc.Doc.push_back (spacy/tokens/doc.cpp:8356)()
    280         t.l_edge = self.length
    281         t.r_edge = self.length
--> 282         assert t.lex.orth != 0
    283         t.spacy = has_space
    284         self.length += 1

AssertionError:

Thanks for the report.
I think this error was introduced in 0.100.7, and then fixed in 0.101.0. What version are you on?

0.100.7

When do you expect to put version 0.101.0 in conda?

I have same problem, as far as the version 0.101.0  is not in conda!

I have the same problem with v0.100.7 too (using conda)

v1.0 should now be up on conda. Thanks for your patiences.


Travis syntax check and lint

Adds syntax checking and ansible-lint.
This is expected to fail on travis with the current playbooks.

Activated Travis. Closing/reopening to validate this PR.

Some syntax issues (a lot of trailing whitespaces). What is the next action here? Should we cleanup existing playbooks before adding anything enw?

It's a matrix build, so new playbooks can be tested and verified to pass without needing to fix existing ones immediately.

That's fine, should we mark the existing ones as expected to fail in that case and we'll review them as we modify them?

updated


Some codes are duplicated and optimized

(If this PR fixes a github issue, please add Fixes #<xyz>.)
Fixes #
(or if this PR is one task of a github issue, please add Master Issue: #<xyz> to link to the master issue.)
Master Issue: #
Motivation
Explain here the context, and why you're making that change. What is the problem you're trying to solve.
I found some duplicate code, and redesigned and optimized it.
Modifications
Describe the modifications you've done.
Verifying this change

[ ] Make sure that the change passes the CI checks.

(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added integration tests for end-to-end deployment with large payloads (10MB)
Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:
If yes was chosen, please highlight the changes

Dependencies (does it add or upgrade a dependency): (yes / no)no
The public API: (yes / no)no
The schema: (yes / no / don't know)no
The default values of configurations: (yes / no)no
The wire protocol: (yes / no)no
The rest endpoints: (yes / no)no
The admin cli options: (yes / no)no
Anything that affects deployment: (yes / no / don't know)no

Documentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs?

[ ] doc-required
(If you need help on updating docs, create a doc issue)

[ ] no-need-doc
(Please explain why)

[ ] doc
(If this PR contains doc changes)

@hellomyboy - are you able to resolve conflicts? Then we can run tests and merge this PR.

@hellomyboy Could you please help check the failed tests?

@hellomyboy Looks like the failed test is related to this PR, I have created a flaky test https://github.com/apache/pulsar/issues/14699 issue, but looks like it happens in 2 tests of this PR, looks like not a flaky test.

Closed as stale. Feel free to rebase and resubmit the patch.


Added a redirect link to a new tab Fixes #22

Fixes #22
I have redirected link to a new tab
https://user-images.githubusercontent.com/87171452/143100989-f9e56c2a-330a-4f63-8c9d-38e06f6520e2.mp4

@manjotsidhu @Shivansh2407 can you please once review my pull request  .

@Shivansh2407 @manjotsidhu can you please once review my pull request

done  :)


DS-4065: resource policy aware REST API hibernate queries

This PR borrows from #1879 to make the item and bitstream endpoints resourcepolicy aware.
This prevents the current behaviour of internally fetching offset-limit and returning from that subset, a subset of authorized items, with the authorization check being done in-memory.
Instead, findAllAuthorized methods are created for the DAOs and these are called via the REST api.

OUTDATED DISCUSSION BELOW
This is an unfinished work in progress focusing on the REST "items" endpoint.
As has been discussed in PR https://github.com/DSpace/DSpace/pull/1879 the DSpace 6 REST API checks resource policies in memory. Moreover this breaks the limit/offset functionality because a set number of results are retrieved and of those anywhere between none and all are withheld pending authorisation checks.  (see DS-4065)
This PR ports the code for the DSpace 7 REST API from PR 1879
There is currently a problem with forming the Hibernate query correctly. In the resource policy aware query findAllAuthorized  the following condition has been commented out:
   `" AND (r.epersonGroup.id IN (:groupIdList) OR r.eperson.id = :currentUserId)" +`

with the groupIdList parameter being defined as
       LinkedList<UUID> list = new LinkedList<>();
        for(Group group: groups){
            list.add(group.getID());
        }
        query.setParameter("groupIdList", list);

because else
java.lang.ClassCastException: java.util.LinkedList cannot be cast to java.util.UUID
 	at org.hibernate.type.descriptor.java.UUIDTypeDescriptor.unwrap(UUIDTypeDescriptor.java:37)
 	at org.hibernate.type.PostgresUUIDType$PostgresUUIDSqlTypeDescriptor$1.doBind(PostgresUUIDType.java:76)
 	at org.hibernate.type.descriptor.sql.BasicBinder.bind(BasicBinder.java:93)
 	at org.hibernate.type.AbstractStandardBasicType.nullSafeSet(AbstractStandardBasicType.java:284)
 	at org.hibernate.type.AbstractStandardBasicType.nullSafeSet(AbstractStandardBasicType.java:279)
 	at org.hibernate.param.NamedParameterSpecification.bind(NamedParameterSpecification.java:66)
 	at org.hibernate.loader.hql.QueryLoader.bindParameterValues(QueryLoader.java:612)
 	at org.hibernate.loader.Loader.prepareQueryStatement(Loader.java:1897)
 	at org.hibernate.loader.Loader.executeQueryStatement(Loader.java:1858)
 	at org.hibernate.loader.Loader.executeQueryStatement(Loader.java:1838)
 	at org.hibernate.loader.hql.QueryLoader.iterate(QueryLoader.java:518)
 	at org.hibernate.hql.internal.ast.QueryTranslatorImpl.iterate(QueryTranslatorImpl.java:399)
 	at org.hibernate.engine.query.spi.HQLQueryPlan.performIterate(HQLQueryPlan.java:284)
 	at org.hibernate.internal.SessionImpl.iterate(SessionImpl.java:1292)
 	at org.hibernate.internal.QueryImpl.iterate(QueryImpl.java:68)
 	at org.dspace.core.AbstractHibernateDAO.iterate(AbstractHibernateDAO.java:247)
 	at org.dspace.content.dao.impl.ItemDAOImpl.findAllAuthorized(ItemDAOImpl.java:336)
 	at org.dspace.content.ItemServiceImpl.findAllAuthorized(ItemServiceImpl.java:1303)
 	at org.dspace.rest.ItemsResource.getItems(ItemsResource.java:174)
 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
 	at java.lang.reflect.Method.invoke(Method.java:498)

where and how Hibernate is told to expect a LinkedList < UUID >  and not a single UUID is currently beyond me. But as far as I can understand that's the single current problem.

Try http://docs.jboss.org/hibernate/core/3.2/api/org/hibernate/Query.html#setParameterList(java.lang.String, java.util.Collection)

I've tested the current commit: 314a844 by submitting a four items and placing one of them in a restricted collection.
curl -v -X POST --data<EMAIL_ADDRESS>http://localhost:8080/rest/login
use cookie id from login:
curl -v --cookie "JSESSIONID=01D380A3886A8799D499292DD33199CA" http://localhost:8080/rest/items?limit=4
the restricted item is withheld but for some reason the restricted item is the last one in the order of items even though it was the second item to be created.

@terrywbrady thanks for taking this on
My understanding is that the filtered-items endpoint uses the itemService findByMetadataQuery method https://github.com/DSpace/DSpace/blob/d75d97e2a65f047f75f4d62f9bdf70a5ad9918b7/dspace-rest/src/main/java/org/dspace/rest/FilteredItemsResource.java#L132
which in turn uses the itemDAO findByMetadataQuery method https://github.com/DSpace/DSpace/blob/d75d97e2a65f047f75f4d62f9bdf70a5ad9918b7/dspace-api/src/main/java/org/dspace/content/ItemServiceImpl.java#L1037
Unlike other find methods of itemDAO a query is not built but a Criteria created
https://github.com/DSpace/DSpace/blob/314a84485ce20635517a91e7e621ff53c3e535da/dspace-api/src/main/java/org/dspace/content/dao/impl/ItemDAOImpl.java#L148
The PR does not affect these to my knowledge.
However, the findAllAuthorized method has been changed
https://github.com/DSpace/DSpace/blob/314a84485ce20635517a91e7e621ff53c3e535da/dspace-api/src/main/java/org/dspace/content/dao/impl/ItemDAOImpl.java#L310
and it is used by the /items REST endpoint when responding to a GET request
https://github.com/DSpace/DSpace/blob/d75d97e2a65f047f75f4d62f9bdf70a5ad9918b7/dspace-rest/src/main/java/org/dspace/rest/ItemsResource.java#L174
I assumed this would be the simplest way to test this functionality. GET requests for items.
To test this you can make GET requests to the /items endpoint either as 1) anonymous, 2) group user like you mention or 3) administrator.

@J4bbi , Thanks for the explanation.  This has helped me to better understand the purpose of the PR.
Calls to  itemService.isItemListedForUser(context, dspaceItem) will be replaced by itemService.findAllAuthorized(context, limit.intValue(), offset.intValue()),
The total number of items returned will be the same.  The visible difference will be in the pagination of results.
Without this fix, when the page size is small, the existing code may return pages of results that contain gaps in results.  (Note: this issue is easier to see on a fresh restart of a server.  The loading of the hibernate cache can cause restricted items to fall to the end of this list which makes the problem difficult to visualize.)
The results of this PR are much easier to prove in a small repository with several restricted or private items.

The following AIP files could be helpful in reproducing the issue: https://github.com/DSpace-Labs/AIP-Files/blob/master/dogAndReport.zip
View all items /rest/items?limit=5.  Paginate through all items.  Note that some pages have fewer than 5 items.

Once this change is merged, it would be interesting to see a similar change to the findByMetadataQuery.

I should not that equivalent changes can be made to the bitstreams endpoint before a merge is made.

Looks good to me. I confirmed this issue on the current DSpace 6.3 Demo as well as our own DSpace 6.3 production instance. Here is a simple reproducer on the public DSpace 6.3 Demo server:
$ curl -s -H "Accept: application/json" "https://demo.dspace.org/rest/items?offset=0&limit=5" | jq length
5
$ curl -s -H "Accept: application/json" "https://demo.dspace.org/rest/items?offset=0&limit=5" | jq '.[].handle'
"10673/4"
"10673/3"
"10673/6"
"10673/5"
"10673/7"
# log into DSpace Demo XMLUI as admin and make one item private (for example 10673/6)
$ curl -s -H "Accept: application/json" "https://demo.dspace.org/rest/items?offset=0&limit=5" | jq length
4
$ curl -s -H "Accept: application/json" "https://demo.dspace.org/rest/items?offset=0&limit=5" | jq '.[].handle'
"10673/4"
"10673/3"
"10673/5"
"10673/7"

The result set which includes a private item is clearly incorrect: we are asking for a limit of five items starting at offset 0, but we only get four items. The REST API is counting the private item internally, but not taking that into account when returning the resulting items.
@J4bbi's fix here works as expected in our DSpace 6.3 staging environment: when a result set includes private items they are excluded from the REST API's internal item count and the number of items returned is the number specified in limit.
P.S. @J4bbi you should update the title of your latest commit message so it matches the GitHub issue title. It's way more helpful to see meaningful commit messages when looking in git history than having to go look on GitHub or Jira.

Okay, so that's +3. What do you think @kshepherd ?

@tdonohue , I will try to answer the issues you've raised the best I can. It's been almost three years since the PR was made and I must stress that I am not the author of the code.
I came across what I consider a serious bug of the REST api that it will internally fetch everything, load into memory and then filter. See for instance this excerpt from Items:
https://github.com/DSpace/DSpace/blob/b53f351e03613cc67420293be5e908df73ea764c/dspace-rest/src/main/java/org/dspace/rest/ItemsResource.java#L164-L187
here dspaceItems loads all items unfiltered and a loop appends items to an array based on a condition.
This is neither efficient nor effective to be honest. It loads everything into app memory and inconsistently returns results to the user. User has no way of navigating the REST API blindly, getting less results than limit does NOT imply the end of possible results meaning users have to probe beyond the paginated < limit page of results.
I ported/copied code from #1879 which was NOT merged into the main branch. Instead #1976 was merged.
Unfortunately I don't have time right now to review that PR or what the differences are between the two PRs, apologies.
I think that this PR adds the necessary findAuthorized methods which necessitates some changes to the Group, Collection classes etc.
I don't understand what you mean by wanting to be sure the changes are "compatible with all the Java API changes made in DSpace 7.0" in my understanding 7 is a complete refactoring and 6.x REST api therefore can not be compatible. My understanding that the code in this PR was rejected for 7.and a PR for 7 would be rejected again.

@J4bbi : To clarify my comment...when I was talking about the "Java API" in my comment, I was referencing the number of dspace-api level changes in this PR.  Only ~37 lines of code in this PR modify the dspace-rest module, and all the rest modify our core dspace-api classes.  While v6 REST API and v7 REST API are 100% incompatible, there is still a lot of similarities between the v6 dspace-api and v7 dspace-api.
So, my question was more around where we planned to "port" these changes to v7, as it's worth noting that in 7.0, we still have the deprecated v6 REST API  (so, yes, there's two REST APIs: the main required one, and the v6 one if you need it for backwards compatibility with scripts you built for that v6 REST API).  That said, if others feel this PR should only be applied to 6.x, I'm OK with it (since this older REST API is being phased out).  I'm just pointing out the fact that, without a way to port this to 7.x, these same issues will exist in the deprecated, v6 REST API that comes with 7.x.


Add IPv6 DNS

The DNS tweak also affects IPv6.
I had to eliminate Level3 as an option because i could not find its IPv6 address.
I also added AdGuard DNS as an option.

I discarded the deletion of the winutil.ps1 file.
I hope it is not to late and that you can resolve the conflict and merge it. If not I will open a new pull request for the next release, sorry for the inconvinience, trying to do things bettter!


Changes to Readme and Concourse Image

Hi Abhi, I made a few changes to the Readme file, I hope it aids the installation for mac m1 users.

Hi Abhi, here are the new changes as requested, I tried a few tricks to see if it would work by creating a new script and calling it from the make file, I tested it locally and it seemed to work.


Fix the badges after the Ownership transfer

Here are some of the pending tasks for getting the badges fixed in the README.md.

[x] The Travis badge is not showing.
[ ] The gemnasium.com badge is showing, but incorrect
[x] The Coveralls badge is showing, but incorrect
[x] The others are fine.

I verified that all the badges, but the Gemnasium.com, can be rebuilt by updating the GitHub credentials or going directly to the links using the "intuit" organization. The case for Gemnasium is a bit more difficult, because it requires the user to be an admin.

Perfect... I got admin account at the intuit org and now I'm able to register.

I had to grant permissions again in order to get the settings pushed again.

Then the same "grant permissions" process helped granting the permissions back.


Save peers as enr isntead of NodeRecord

Describe the feature
On drop we're saving a file with all NodeRecords:
https://github.com/paradigmxyz/reth/blob/c415221876110914699366a85bfd4fb2e72a62b8/bin/reth/src/node/mod.rs#L391-L394
https://github.com/paradigmxyz/reth/blob/c415221876110914699366a85bfd4fb2e72a62b8/crates/net/network/src/manager.rs#L299-L301
however, some peers announce a fork id in discovery which we should also save
https://github.com/paradigmxyz/reth/blob/c415221876110914699366a85bfd4fb2e72a62b8/crates/net/network/src/peers/manager.rs#L755-L756
TODO

convert Peer -> Enr with "eth" field, ref https://github.com/paradigmxyz/reth/blob/c415221876110914699366a85bfd4fb2e72a62b8/crates/net/discv4/src/lib.rs#L443-L455

ideally, move this conversion to new function in NodeRecord fn int_enr_builder(self) -> EnrBuilder

update file reading code in NetworkConfig

Additional context
No response

I would like to take this on

@mattsse I think we won't be able to persist peers as Enr because when the node record is updated, the signature need to be updated as well, and when a Enr is decoded from rlp the signature is verified: https://github.com/sigp/enr/blob/79d2df3cf2727386fc42f9233181af7ea17b2386/src/lib.rs#L1020

Just read through the issue. This makes sense, closing.


[Protected var] Page 490 AccScheduleOverview

In page 490 AccScheduleOverview could you change the scope of the following variables to protected?
protected var
AccSchedManagement: Codeunit AccSchedManagement;
UseAmtsInAddCurr: Boolean;
Thank you

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


Reliability enhancement for LocalTestServer

Description
Wait until LocalTestServer has actually started before allowing tests to run against it.
All SDK Contribution checklist:

[x] The pull request does not introduce [breaking changes]
[x] CHANGELOG is updated for new features, bug fixes or other significant changes.
[x] I have read the contribution guidelines.

General Guidelines and Best Practices

[x] Title of the pull request is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[x] Pull request includes test coverage for the included changes.

API change check
API changes are not detected in this pull request.


Add State dropdown to map

Add a State dropdown to the Map feature to show all shows in a given US State (or province, etc). When querying by state, omit the "distance from point" paradigm.

Fixed in 39850b8e4f21971603d6e90d679935681a12bd5a


Mention safe in _config.yml

Without it, the plugin is not effective.

Hey @BanzaiMan! This should work in safe mode because we specify the plugin as "safe": https://github.com/jekyll/jekyll-redirect-from/blob/master/lib/jekyll-redirect-from/redirector.rb#L3
A whitelist can be specified to allow safe plugins to be required as GitHub does in Pages.
Can you specify where this plugin failed to function for you?

Hi, @parkr,
We are serving the documentation from a Heroku app now, and the redirect stopped working.
Here's the commit that fixed it for me: https://github.com/travis-ci/docs-travis-ci-com/commit/3a670b8b90f9354be5fefcb340be63c2e8e19128

Ah, I see. I just fixed it in https://github.com/jekyll/jekyll-redirect-from/commit/738a3a749fa0d40333615a567771cb495d1fcf25 – I hope that makes it clearer :)

Ah, no problem!

Thank you, @BanzaiMan!


How to use "--exec rmdir" for remove temp folder after download complete

DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

[X] I understand that I will be blocked if I remove or skip any mandatory* field

Checklist

[X] I'm asking a question and not reporting a bug or requesting a feature
[X] I've looked through the README
[X] I've verified that I'm running yt-dlp version 2022.10.04 (update instructions) or later (specify commit)
[X] I've searched the bugtracker for similar questions including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue

Please make sure the question is worded well enough to be understood
how to use "--exec rmdir" to remove temp folder after download complete from temp path?

Provide verbose output that clearly demonstrates the problem

[ ] Run your yt-dlp command with -vU flag added (yt-dlp -vU <your command line>)
[ ] Copy the WHOLE output (starting with [debug] Command-line config) and insert it below

Complete Verbose Output
No response

Are u asking how to use rmdir? I don't understand... Pls elaborate

I mean how to use "--exec" to remove temp folder after download complete from temp path

to remove temp folder after download complete automatically

What's the issue with above command?

what i mean is alternative way to remove temp other than command on yt-dlp.conf

--exec is run only on successfull downloads - in which case, there are no temp files to delete anyway. What you want is not possible using exec


std.typecons : AutoImplement: Handle 'in' storage class

This became a problem with the change to make in its own storage class, but luckily no release has been made yet.

Tests?

Tests?

Well it requires -preview=in to be noticeable, otherwise it'll just work, and we don't have any -preview=in tests here (but working on one).


uploader: migrate tasks from legacy BibUpload

Idea
Replace the current BibUpload.
Proposal
Create a new uploader keeping this list of ideas about it in mind:

Work with JSON natively rather than MARC, although the last could be uploaded as well.
Run tasks in parallel when possible, for example one huge insert coming from one file could generate several insert tasks that could run in parallel.
Easy to customise depending on the installation needs. For that we thought about creating lightweight workflows (https://github.com/romanchyla/workflow) for each of the common/current modes, so each installation could override the current ones or implement their owns.
This lightweight workflows should be made out of small monolithic tasks and it would be nice to have a rollback function for each of this functions in case of error in any of them while running the workflow (reverse workflow?)
Plug the new documents module with a default document storage (same behaviour as BibDocFile).
Fire signals before and after running any workflow would be a good thing to "connect" the new uploader with other Invenio tools like bibindex, webcoll, etc.

Tasks

[x] insert mode
[ ] replace mode
[ ] correct mode

--
see implementation at #1850

This should priority for @CERNDocumentServer. The usage of new documents storage as well as migration of BibDocFiles to documents can be very limited without proper way of updating record using new uploader.

I will look into when starting migration to documents on Zenodo. No promises though ;-)

cc: @jalavik @jmartinm

We now have invenio-records with its own upload API.


Docker Files and Docker-Compose

Settings to use Docker and ready environment on the docker compose to run easily on the server.
I am assuming that an external database will be used
Follow the tutorial
Create a external database container
docker run --name mysql-percona -d \
-p 3307:3306
-e MYSQL_ROOT_PASSWORD=root
percona/percona-server:5.7
--character-set-server=utf8mb4 --collation-server=utf8mb4_general_ci
Conect to network
docker network create -d bridge net-db
docker network connect net-db mysql-percona
Create ENV files
cd PROJECT_FOLDER
cp backend/.env.example env-backend
cp frontend/.env.example env-frontend
Build and Start
docker-compose up --build
Files
Files will saved in ./data-public

Why this has been merged? It looks like it would be very useful to have this one on the master branch 🤔


Fix doc thumbnails

the thumbnail images for https://senzing.github.io/sdk-components-ng/additional-documentation/themes/pre-built.html are off by a directory.
ie:
https://senzing.github.io/sdk-components-ng/additional-documentation/images/themes/add-to-style-paths.png
should be:
https://senzing.github.io/sdk-components-ng/images/themes/add-to-style-paths.png

Pull Requests:

https://github.com/Senzing/sdk-components-ng/pull/14


services of life-mngr, acrnd, acrnlog and acrnprobe cannot active after installing all debian package on tgl

Describe the bug
services of life-mngr, acrnd, acrnlog and acrnprobe cannot active after installing all debian package on tgl
Platform
tgl with ubuntu21.04
Codebase
acrn-hypervisor commit id:3d8fa8094941077f8ee15a3def0f5e79a201a173
with the following debian patches:
0001-Update-gitignore-to-ignore-Eclipse-project-config.patch 0006-hv-Fixup-serial.conf-permissions.patch
0002-board-inspector-Fix-sys.path-for-all-internal-module.patch 0007-debian-Handle-etc-serial.conf.patch
0003-dm-Use-libdrm-library-for-drm-access.patch 0008-dm-Remove-dependency-on-libuuid.patch
0004-Adding-initial-native-Debian-packaging-for-ACRN.patch 0009-debian-Remove-build-dependency-on-uuid-dev.patch
0005-debian-Add-docker-build-helpers.patch 0010-Update-d-changelog.patch
Scenario
nuc11tnbi5: shared
To Reproduce
Steps to reproduce the behavior:

dpkg -i *.deb to install all debian packages on tgl.
use grub created by myself to boot acrn and sos
menuentry 'ACRN' --id ACRN {
load_video
insmod gzio
insmod part_gpt
insmod ext2
search --no-floppy --fs-uuid  --set f89281ef-d3ec-41e3-9003-e61b27c258ef
multiboot2 /boot/acrn-3.0.bin root=PARTUUID=046e47d3-304f-4b02-8346-1caa99c2bbec
module2 /boot/vmlinuz-5.10.106-acrn-service-vm-209086-ga2ffbcda0a64-dirty Linux_bzImage
}
all services of life-mngr, acrnd, acrnlog and acrnprobe cannot active

Expected behavior
all services of life-mngr, acrnd, acrnlog and acrnprobe can active and work.
Additional context
Attached service log and dmesg log.
dmesg-service-fail.txt
service-fail.txt

I did a bit of investigation on that and I already verified the issue for acrnd. Just checking my ideas on that to solve it!

life-mngr: this is a separate package acrn-lifemngr. This package misses the respective updates at least since 2.6
acrnlog and acrnprobe are parts of the separate package acrn-tools. They are also missing the respective updates :-(

Ok waiting for you new codes to verify acrnd issue.
for life-mngr and accrnlog/acrrnprobe, I didnot get your meaning. Do you mean it's acrn problem?
@junjiemao1 do you have any comment? @shenfang2019


Grammar Capital letters

My English is not very good, but I understand that it is grammatically misused in each sentence to start with capital letters.

For example: Yes, Delete This Setting -> must be -> Yes, delete this setting

I believe you are right


Metrics are broken

Trying to visit any metrics related link will result in a 502.
https://pretendyoure.xyz/zy/metrics/user/c1c462ee-6b7b-4011-8660-2f69935d1e41

Whoops, forgot to start that back up when the server crashed… I need to make that automatic at some point along with the rest of the metrics infrastructure (which has been running). Should be fine now. Thanks for reporting.


Accessing Public Methods for Custom Controls from .NET MAUI in MauiReactor

Hi,
I have created a custom control/library in .NET MAUI that has some public properties and methods. While using scaffolding, I can successfully use the properties, but I am unable to use the public methods. Is there any way to call and use those methods?
Additionally, I would like to know if there is a property or API available in MauiReactor that indicates whether a view/page has been loaded, similar to the "IsLoaded" property in .NET MAUI.
Thank you.

Hi,
you can access the native component by passing a function to the constructor called when it's created.
new Label(labelRef => _labelRef = labelRef)
then use the reference to call its methods:
_labelRef.CallToCustomMethod();
https://adospace.gitbook.io/mauireactor/components/accessing-native-controls
BUT:
Often the need to access the native control means you're not using the correct MVU approach (could not be your case of course).
Why do you need to call methods on native control?
MauiReactor pairs .NET MAUI properties and events: so to know when a view is loaded just subscribe to the OnLoaded() event as you would do in classic .NET MAUI.
new Label()
     .OnLoaded(()=>...)

closing now, please re-open if you any other questions


Fix loading sequence for PUI form fields

Ensure that "existing" values are honored
Change hook execution ordering
Delay field display until all fields are loaded

This PR has broken the forms if the server responds with an error:

Open the netlify preview for this PR and one for another previous PR
Goto a part and open the edit modal
Change the "Units" field to a non existing physical unit. E.g. AA
Click "Submit"
In the preview from this PR, the form is just reset to the default values, and no error is shown. In the other preview the validation error is shown.

@wolflu05 thanks for the report. I'll look into this (and add some additional playwright tests to ensure no further regressions)

@wolflu05 fix incoming in https://github.com/inventree/InvenTree/pull/7689


Fix build failed in Raspberry Pi 4 64bit

Fix build some libraries in Raspberry Pi 4 64bit.
srs don't support for ARMv7 now because ARMv7 modules is missing in FFmpeg.
So I changed my Raspberry Pi 4 to 64bit, and fix some compiling error.
OS: Debian buster with ds64-shell

Codecov Report

Merging #2121 (44eb1f6) into 4.0release (1df2ea5) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@              Coverage Diff               @@
##           4.0release    #2121      +/-   ##
==============================================
- Coverage       56.59%   56.59%   -0.01%
==============================================
  Files             125      125
  Lines           53411    53411
==============================================
- Hits            30229    30228       -1
- Misses          23182    23183       +1

Impacted Files
Coverage Δ

trunk/src/protocol/srs_service_utility.cpp
72.43% <0.00%> (-0.55%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1df2ea5...44eb1f6. Read the comment docs.


Loss calculations

Dear Sir, I am a bit confused about the loss calculations. These two snippets from the train log would help me better explain the confusion.

Epoch: [7][0/250]	Batch Time 1.087 (1.087)	Data Time 0.641 (0.641)	Loss 4.4972 (4.4972)
Epoch: [7][200/250]	Batch Time 0.347 (0.349)	Data Time 0.000 (0.003)	Loss 4.4606 (4.2053)
[0/313]	Batch Time 0.727 (0.727)	Loss 4.6890 (4.6890)
[200/313]	Batch Time 0.137 (0.140)	Loss 5.0137 (5.0349)

LOSS - 5.032

Epoch: [138][0/250]	Batch Time 0.931 (0.931)	Data Time 0.560 (0.560)	Loss 0.1863 (0.1863)
Epoch: [138][200/250]	Batch Time 0.344 (0.349)	Data Time 0.000 (0.003)	Loss 0.1613 (0.1790)
[0/313]	Batch Time 0.697 (0.697)	Loss 10.3283 (10.3283)
[200/313]	Batch Time 0.137 (0.141)	Loss 11.1063 (10.4203)

LOSS - 10.459

On epoch 7, the loss shown besides the 'Data Time' is about 4, while the average loss is about 5.
On epoch 138, the loss shown besides the 'Data Time' is about 0.2, while the average loss is about 10.
Looking at the loss shown besides 'Data Time', I see that my model is learning well, but looking at the average loss, it seems that the model is diverging.
Can you please guide?
Thanks

I think in line 228 of train.py:
    print('\n * LOSS - {loss.avg:.3f}\n'.format(loss=losses))
should be
    print('\n * LOSS - {loss.avg:.3f}\n'.format(loss=losses.avg))


Amazing dots. Truly amazing. I love you

I haven't tried bspwn yet but WOW I love spotify stuff. i always used conky and cover art damn this is amazing. I can't wait to try this out on my system Thank you so much. any plans for xfce edition. If not will the spotify music thing work on xfce? just wondering because i seen somebody ask about openbox.

Yeah it will :)

How would i go about installing everything to xfce and getting it to work. Thanks. Do i still need to install bspwm stuff

I installed everything but bspwm and the the bspwm rounded corners git. I'm not sure how to launch music player popup xfce. i tried launching the system Menu Popup and got this
/home/linux/.local/bin/eww: line 1: version: command not found /home/linux/.local/bin/eww: line 2: oid: command not found size: '336766984': No such file

I got it working little bit. I didn't know needed polybar to run with the music player. There's some some need to fix. if you can help. i'll send screenshots

The battery i'm not to worried about.  Also the upspeed and downspeed network. Also what icons where you using? there was no icon package. What was the dock think at the bottom on your screenshot where you using tint2 also.  Thanks

You don't need polybar for this, you just launch it using eww. The bottom thing is plank dock

The Music Player wouldn't launch without polybar. For me. How can i fix the polybar? Also what icons are you using no mention.

I am using papirus-icon-theme, there is no upload/download indicator in polybar that is actually for gamemode, which you need to have installed, to open player without polybar u can use eww open player