[Feature] CRD replicator readiness probe

This issue is related to #521. Whenever the CRDReplicator starts, it gets the ClusterID from a configmap. If the configmap has not been created yet, it should not appear as ready. Enforce the notReady status by using a readinessProbe and setting it to ready after the clusterID fetch.
https://github.com/liqotech/liqo/blob/756e9c1cf297a7370c1f151d45745719a0c63b28/cmd/crd-replicator/main.go#L51

What do you about touching a file (i.e. /tmp/cluster-id-acquired) after the function call (if no error, of course) and setting a readinessProbe which tries to cat this file? If is it okay for you, I can implement this.

Yes, it fits our needs, but Kubebuilder provides a way to set up a handler for the readiness probes as described in the AddReadyzCheck field of the manager struct. I think it would be very nice to leverage this feature to implement the readiness probe.
Just a brief consideration: without the implementation of #521, addressing this issue is relatively useless: for the time being, the container crashes if the clusterID is not found yet, hence we cannot take advantage of this probe.
Anyway, feel free to address this issue: disregarding whether it is addressed before or after #521, it is a nice addition to the code.

Closing, as superseded.


[Browser Bookmarks] ...

Extension
https://www.raycast.com/raycast/browser-bookmarks
Description
Error:
Error: Worker terminated due to reaching memory limit: JS heap out of memory

NodeError:errors:406:5
[kOnExit]:worker:313:26
Worker.<computed>.onexit:worker:229:20

Steps To Reproduce
1
Current Behaviour
No response
Expected Behaviour
No response

Thanks for bringing this up. It appears that this is a duplicate of issue https://github.com/raycast/extensions/issues/6810, so I'll mark it as such.


fix: line editor points rendering below elements

fixes:

@dwelle I did a little testing here -- would that image be what you don't want to happen?

@dwelle I did a little testing here -- would that image be what you don't want to happen?

correct

@dwelle Is the intent for the points always to render?  If so, I think we can merge this.


Enhance A11y

Environment

Browser

Issue description
Enhance accessibility for demo in the amplitudejs website, the demo only can access by mouse users and you can't fully interact with the demo by keyboard and also the demo is not accessible for screen readers.
What is expected?
the user should interact with the player by using a keyboard and SR the player should work for everyone not only for specific users, so I'll start making a fast review for the code and what should be:

Remove outline: none from focus state.
left side amplitude control:

range:

  <input type="range" amplitude-main-song-slider="true" class="amplitude-song-slider">

should be:
  <input type="range"  aria-valuemin="0" aria-valuemax="${NumOfAllMin}" aria-valuenow="${NumNow}" aria-valuetext="${Num} minutes" amplitude-main-song-slider="true" class="amplitude-song-slider">

OR this but need write some JS to make it accessible with keyboard.

actions:

should be:
<button aria-label="repeat" id="repeat" class="amplitude-repeat amplitude-repeat-off"></button>
<button aria-label="shuffle"  id="shuffle" class="amplitude-shuffle amplitude-shuffle-off"></button>

<button aria-label="previous track" id="previous" class="amplitude-prev"></button>
<button aria-label="play || pause track" amplitude-main-play-pause="true" id="play-pause" class="amplitude-play-pause"></button>
<button aria-label="next track"  id="next" class="amplitude-next"></button>

right side needs some enhancement in markup to be good for use by keyboard and SR.

it's just a fast review notice, hope fixes them.

Thanks @Muhnad! We greatly appreciate the detail you've provided us on this. We have keybindings currently targeted to be on the v3.2 release (see issue #73) but we never really thought of it from a screen reader perspective.
I will chat with @danpastori and see if we can merge these together for the 3.2 release.
Few questions:

Would this be a proper test of what you are suggesting for the keyboard events? http://a11yproject.com/posts/navigate-using-just-your-keyboard/
What is the best way to test that the aria-label attribute is working?

Hi, @jaydrogers
It's good to support keyboards I waiting for the new release to see that :smiley:
the answer to the first question is yup this is a one of suggesting to test keyboards event in your app beside to test every functionality you should do with the keyboard without using a mouse.
I recommend reading those links WebAIM: keyboard accessibility  & W3: Keyboard Accessible
the second one in usual you don't need to test aria-label because it works if you understand it and use it in the right position but you can test your website by enable accessibility inspector in Chrome.
if you have any question or need any help for a11y mentions me I'll help you if I can. :smile:

Awesome, thanks! We will keep you posted. We'll review this thread once we get closer to 3.2.

I'm going to add this to the roadmap and close the issue. I'd love to learn more about these accessibility features and how to implement them. We can keep track of this in our roadmap

Is there any update on this? I use Amplitude for the Podgrab player and some users have raised this concern example

We haven't received a significant demand or sponsorship for this feature. If you're interest in opening a feature request on our forum, it will help us track the demand (where people can vote for the feature): https://community.serversideup.net/t/requesting-features-for-amplitudejs/196


Added pbjs: true from gjirafa and malltv

Thank, but I did this for you yesterday - MallTV is on the download page now


Press enter to add a card

In trello when the focus is on the textarea field to type the card title, pressing Enter will “submit” the form, ie adding the card. With Metrello pressing Enter will just insert a new line.

Also, on the when the focus is on the “add a comment” textarea, Maj+Enter should post the comment.

Also, on the when the focus is on the “add a comment” textarea, Maj+Enter should post the comment.

Seems identical to #2


Move simple write into raftstore

What is changed and how it works?

Issue Number: Ref #14575
What's Changed:

Move simple write into raftstore

Related changes

PR to update pingcap/docs/pingcap/docs-cn:
Need to cherry-pick to the release branch

Check List
Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Side effects

Performance regression

Consumes more CPU
Consumes more MEM

Breaking backward compatibility

Release note
None

/run-all-tests

These tests just work fine on my mac.

/test

/merge


data_truc can not infer type with now() expression

Describe the bug
with the normal timestamp expression it works will but gives error when try to truc a now()
To Reproduce
dev=> select date_trunc('year', TIMESTAMP '2202-02-16 20:38:40.123456');
     date_trunc
---------------------
 2202-01-01 00:00:00
(1 row)

dev=> select date_trunc('year', now());
ERROR:  QueryError: Feature is not yet implemented: DateTrunc[unknown, Timestamptz]
Tracking issue: https://github.com/risingwavelabs/risingwave/issues/112
dev=> select now();
              now
-------------------------------
 2023-01-10 03:50:19.952+00:00
(1 row)

dev=> select date_trunc(cast('year' as varchar), now());
ERROR:  QueryError: Feature is not yet implemented: DateTrunc[unknown, Timestamptz]
Tracking issue: https://github.com/risingwavelabs/risingwave/issues/112

Expected behavior
No response
Additional context
No response

my mistake, the now() return a timestamptz but the data_truc receive a timestamp
dev=> select date_trunc('year', now() AT TIME ZONE 'Asia/Tokyo');
     date_trunc
---------------------
 2023-01-01 00:00:00
(1 row)


How can I use nvim-notify in coc.nvim?

I don't use coc.nvim but there are some recipes in the wiki https://github.com/rcarriga/nvim-notify/wiki/Usage-Recipes

I don't use coc.nvim but there are some recipes in the wiki https://github.com/rcarriga/nvim-notify/wiki/Usage-Recipes

Thanks vary much!


Portability

There is still some work to be done in regards to making this configuration work flawlessly on other peoples machines.
This commit here indicates some options that need to be modified by a user who intends to use this on their machine:
https://github.com/DiamondBond/emacs/commit/aad246bc49ffe8a11e81d7642ca52b31166bfeac
TOOD:

[x] migrate font configuration to globals.org
[x] remove hard references to my homedir and change to ~/ where possible

https://github.com/DiamondBond/emacs/issues/21
https://github.com/DiamondBond/emacs/issues/22


Annotate all type names when INJECT_OUTPUT_TYPE_NAMES is set

This includes type desc annotation for type names of objects and basic scalar types.

The CLI survived this change, but the notebook tests are broken - I'll double check if edgedb.com could run properly.

The CLI survived this change, but the notebook tests are broken - I'll double check if edgedb.com could run properly.

That's edgedb-js issue, should be easily fixable. cc @jaclarke

Is this backwards-compatible?

Is this backwards-compatible?

@elprans I believe so.
Clients using the binary protocol should ignore unexpected typename annotations, like the JS client looks safe:
https://github.com/edgedb/edgedb-js/blob/93ebc775701ed5274e78b8c24f5675401a477096/src/codecs/registry.ts#L257-L263

Closing this one -- after a quick chat with @elprans we decided that this is a suboptimal solution. The selected type can actually be a complex thing (union/intersection/a combination of them) and then the type name would be unusable. Also the return type of SELECT User {name} isn't actually User, it's separate a derived type that isn't even a subtype of User, strictly speaking. A better strategy for .edgeql codegens is to just call the top-pevel dataclass/struct type Data and then derive the nested object type names from link names.


fix compilation errors in doctests

I don't know why GitHub Actions CI didn't catch these, but running plain cargo test fails due to failure to compile some doctests, which look like copy-paste errors (which were simple to fix). With the changes from this PR, cargo test passes.

The CI failure looks unrelated to my changes?

thanks for this, I wanted to sort the CI before merging this


disable error reporting interaction on CI

non-tty environments won't be able to acknowledge the multiple choice thing. So we need to take a call on how to proceed here. Disable in CI? use an env var? log a warning?

Actually this is already covered here:
https://github.com/cloudflare/wrangler2/blob/7faf0ebec1aa92f64c1a1d0d702d03f4cfa868cd/packages/wrangler/src/reporting.ts#L72
If Wrangler is being used in non-TTY environment then we do not attempt to report the error.

oh damn, missed this. closing, thanks!


this.$translate.textWithParams is returning the translation string

Last week I've created the PR with the new method this.$translate.textWithParams. Since I'm using it now in a app I've came to the conclussion that it's not working since it's returning the translation string instead of a message with replacements.
I'll dig into it asap.

It doesn't for me either.
{{ tWithParams('Collapse filter section', {sectionTitle: 'tralala'}) }}
using
Vue.locales({
	de: {
		'Expand filter section': 'Filter %sectionTitle% aufklappen',
	}
});

renders as Filter %sectionTitle% aufklappen

@pooledge exactly. Feel free to dive in, I'm a bit busy but I would like dive in somewhere in the upcoming days.

Hey guys, sorry for the delay, this PR should fix it and is now merged and deployed. https://github.com/javisperez/vuetranslate/pull/11 Thanks for the issue and help!


Cassandra check for java version fails

Not really a bug of this project, but more of dse itself. As pointed out here the dse installer checks for the presence of java in the wrong way, which is currently failing for the jdk7u101. The fix on the same page above works (commenting out the check in the script).
Reporting this here because I wasted a lot of time trying to solve this, so I hope it can help someone else too (not really sure if this should be addressed in this project, but at least this can help pointing in the right direction).

nodetool status
Cassandra 2.0 and later require Java 7u25 or later.

Pretty sure this was fixed by 14fd7cf266e4f8790acdfd80b819337a57c5f612 .


[Wave Collect] [Xero] Fix padding issue in ConnectionLayout

Details

Fix ConnectionLayout padding issue
Fixed Issues

$ https://github.com/Expensify/App/issues/41560
PROPOSAL: N/A
Tests

Go to any page that using ConnectionLayout component (ie: XeroAdvancePage, XeroCustomerConfigurationPage)
Verify that spacing (padding) matches with the design docs.

[x] Verify that no errors appear in the JS console

Offline tests

N/A
QA Steps

Same as Tests.

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/16502320/639a351d-883d-4385-9d2f-ba7c7a78a889

MacOS: Desktop

@Expensify/design could you please review the Import and Advanced Xero screens?
We should have tagged you beforehand on the related PRs. Since the external agency working on this was OOO this entire week, C+ contributors have been hard at work to gain a good momentum to comply with the external commit in June.
But still, let's not sacrifice quality for speed. Quality is our differentiator ultimately, and so we need your expert eyes on this!
Thank you

@hungvu193 please fix lint

@hungvu193 please fix lint

Fixed!

I don't think "Other integrations" is supposed to be bold:

This is what we have in Figma and the design doc:

cc @lakchote - let me know the best place to address my comment above.

cc @lakchote - let me know the best place to address my comment above.

Thanks @shawnborton, here would be the place to centralize your reviews/requested changes for the Import, Advanced, and Accounting screens.

Also looks like the organization name is bold:

But it shouldn't be based on the Figma/design doc screens:

Otherwise I think it looks pretty good to me.

@hungvu193 could you please make the above changes ^
I know they aren't related to this PR, so you can open a new issue or make them here if they're quick

@hungvu193 could you please make the above changes ^
I know they aren't related to this PR, so you can open a new issue or make them here if they're quick

Np, I updated it.

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@lakchote just to confirm, where will you be addressing the feedback I posted above? Thanks!

It looks like it was addressed (the Xero organization should not be bold), here.
However by giving it a second look, the Other organisations modification (it shouldn't be bold too) slip away and I apologize for that.
I'm going to address this in my PR here, thank you!

Sounds good, please tag me for review over there. Do you know which PR introduced the breaking change (going from regular weight to bold) in the first place?

Sounds good, please tag me for review over there. Do you know which PR introduced the breaking change (going from regular weight to bold) in the first place?

It comes from this PR, I've proceeded with the merge and I should have tagged you. We were in a rush as this PR blocked every other single PR related to Xero, still we should follow the normal process (it's now printed in my brain, don't worry 😄).

🚀 Deployed to production by https://github.com/marcaaron in version: 1.4.71-6 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Event-based indicators: First event name repeats

To reproduce:

In the indicator setup form, choose "Event frequency" from the target frequency menu.
Give the first event a name, and be sure to enter a number > 1 for the number of events.
Click Create Targets.

Expected behavior: The first event is given the correct name. The other events do not have event names yet.
Observed: The same first event name is applied to all of your event target periods.

Tested and validated on the demo server.


Issue/migrate crud web routing

Added angularjs library and brought in routing for project.

@erchiggins awaiting review whenever ready!


fix(grafana): remove hardcoded control plane namespace

Description:
Removes the hardcoded default control plane namespace from the
Mesh and Envoy Details dashboard. Parameterizes the control plane
namespace. When installing OSM with automatic provisioning of
Prometheus and Grafana the control plane namespace variable will
be set to the namespace where OSM is being installed. When
importing the Mesh and Envoy Details dashboard, the user will have
the option to set the osm control plane namespace just as they are
able to set the datasource.
Resolves #4436
View when importing the Mesh and Envoy Details dashboard:

Testing done:

Installed locally built osm with automatic provisioning of Prometheus and Grafana in a namespace other than osm-system. Verified the Mesh and Envoy Details dashboard was accurately displaying data for the non-defualt namespace. Inspected the queries formatted with the control plane namespace input variable.
Imported the Mesh and Envoy Details dashboard via the import panel JSON. After loading the dashboard, the OSM Control Plane Namespace input box appeared. The dashboard reflected the namespace specified via the input.

Affected area:

Functional Area

New Functionality
[ ]

CI System
[ ]

CLI Tool
[ ]

Certificate Management
[ ]

Control Plane
[ ]

Demo
[ ]

Documentation
[ ]

Egress
[ ]

Ingress
[ ]

Install
[ ]

Networking
[ ]

Observability
[x]

Performance
[ ]

SMI Policy
[ ]

Security
[ ]

Sidecar Injection
[ ]

Tests
[ ]

Upgrade
[ ]

Other
[ ]

Please answer the following questions with yes/no.

Does this change contain code from or inspired by another project? No

Did you notify the maintainers and provide attribution?

Is this a breaking change? No

Codecov Report

Merging #4454 (e246b99) into main (95fb342) will increase coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4454      +/-   ##
==========================================
+ Coverage   69.14%   69.21%   +0.06%
==========================================
  Files         212      212
  Lines       14580    14580
==========================================
+ Hits        10082    10092      +10
+ Misses       4446     4436      -10
  Partials       52       52

Flag
Coverage Δ

unittests
69.21% <ø> (+0.06%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/crdconversion/crdconversion.go
74.62% <0.00%> (+5.22%)
:arrow_up:

pkg/messaging/workqueue.go
100.00% <0.00%> (+10.71%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95fb342...e246b99. Read the comment docs.


locale settings

I have problems in OsX with locale settings. The character set don't display correctly with the spanish keyboard.
There are some way to configure it? Thank you!

also with the german keyboard layout. Typing { will result in û


Handle single empty line in RemoveDuplicatedEmptyLines save action

Seq.sliding(n) returns a seq whose length can be smaller than n if less
than n elements exist.
Fixes #1002400

spurious test failure

retest this please


Uptime.com-authentication issue

Describe the bug
I want to connect to uptime.com to be able to get the status of my services and visualize in the grafana, however getting an issue error getting data frame. 401 Unauthorized. As for the prefix it uses not a bearer token I've used the API key value pair type for the authentication and specified "Token" as the key and the token itself as value.
With a usual curl command I was able to get details from uptime.com
Below is the official documentation of uptime.com how the token can be used.
API Access
To access our API programatically, you must pass one of the below API keys via a HTTP Header with a key name of "Authorization" and a key prefix of "Token" with the below API Key.
Raw HTTP Example:
GET /api/v1/
Authorization: Token token_value
CURL Example:
curl -H "Authorization: Token token_value" https://uptime.com/api/v1/
Steps to reproduce
Provide steps to reproduce the issue.
Register for uptime.com(it has a trial option) then by using a token try to visualize some data with it by providing the https://uptime.com/api/v1/ as the URL and authentication mechanism as described.
Screenshots

Version Details:

Grafana version : Grafana v10.4.1
Plugin version : 2.7.0 and 2.7.1

Additional context
Thanks in advance!!

The Authorization: Token token_value is missing in the query options of Grafana data source based from the shared screenshot. This is likely the cause of the 401 unauthorized error result.
Configuring/adding the API key authentication settings in the Grafana query options would solve this:
Key:   Token
Value: <token_value>
In:    header


Split out irc and config packages.

Config package can be a standalone package as is.
Irc needs an overhaul, but should be doable.

Config is now split out.
https://github.com/arachnist/dyncfg


FileOpenPickerContinuationEventArgs obsolete?

19041 with min of 18362 is warning this as obsolete...
Severity	Code	Description	Project	File	Line	Suppression State
Warning	CS0618	'FileOpenPickerContinuationEventArgs' is obsolete: 'FileOpenPickerContinuationEventArgs is deprecated and might not work on all platforms. For more info, see MSDN.'

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1397fc62-abca-a051-f814-d233874168ea
Version Independent ID: 8337bab4-8747-2c6d-3831-c8bef16f3b17
Content: FileOpenPickerContinuationEventArgs Class (Windows.ApplicationModel.Activation) - Windows UWP applications
Content Source: winrt-api-build/xml/Windows.ApplicationModel.Activation/FileOpenPickerContinuationEventArgs.xml
Product: uwp
Technology: winrt-reference
GitHub Login: @mikben
Microsoft Alias: mikben

Hi @kcovert. Thanks for submitting your feedback and we apologize for the delayed response. I see that updates have not been made since the creation of this Issue, so I went ahead and created an internal work item to engage with our engineering folks and resolve this doc bug. These file/folder continuation APIs are no longer relevant with the discontinuation of Windows Phone. I will add a note to this content and other related pages today. The changes should be live sometime this week.
Though the Issue will be marked as Closed, we will monitor any replies that come afterwards so treat this like an open Issue. Many thanks!


Update README: add --recurse-submodules to git clone

Motivation
More easily check out submodules during git clone
Solution
Adds --recurse-submodules to git clone cmd

Codecov Report
Base: 100.00% // Head: 100.00% // No change to project coverage :thumbsup:

Coverage data is based on head (21727eb) compared to base (e4c6e7b).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##              main      #677    +/-   ##
==========================================
  Coverage   100.00%   100.00%
==========================================
  Files           45        25    -20
  Lines         1917       929   -988
  Branches       322       147   -175
==========================================
- Hits          1917       929   -988

Flag
Coverage Δ

production
100.00% <ø> (ø)

reference
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

reference/lib/ReferenceAssertions.sol

reference/lib/ReferenceAmountDeriver.sol

reference/lib/ReferenceCriteriaResolution.sol

reference/conduit/ReferenceConduitController.sol

reference/lib/ReferenceReentrancyGuard.sol

reference/lib/ReferenceZoneInteraction.sol

reference/lib/ReferenceOrderFulfiller.sol

reference/lib/ReferenceGettersAndDerivers.sol

reference/lib/ReferenceVerifiers.sol

reference/lib/ReferenceOrderValidator.sol

... and 10 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


"Compare Changes" doesn't match values.yaml

Using this repo as source, if I go and create a new repo, choose "cluster-template" and click "Compare  Changes", the diff looks like this:

As we can see, it has added the object nodepools with the field '0'. So the type of  nodepools is clearly object.
This is in contrast with the values.yaml where nodepools is a list of objects:
https://github.com/rancher/cluster-template-examples/blob/dc5c201c5415c430cdf4bcb6af975f9e516e970b/charts/values-vsphere.yaml#L6-L7
I assume that the intention here was to "create the list nodepools with x as the first element", not to "create the object nodepools with the field '0' with value x".
I haven't tried it, but it would surprise me greatly if it works with having nodepools as either an object or a list.
Ideally, I would like to have a menu for configuring nodepools similar to the one when creating a VMware vSphere cluster without templates:

Seems like array type answers are not yet implemented: https://github.com/rancher/rancher/issues/13952


Add Duck Controls & Enhance Timer

duck?

Yeah, I accidentally separated duck pull requests, so the duck. command is in the other one :/

You added maximum game timer delay of 24 hours! ?

Yeah, you can change that if you want
It was  just convenient

Okay, np

Merging now, thanks for the PR.

I'm having problem with the game redirect when the timer finishes

can you add the changes to my latest commit?

Also github shows that the whole code in sketch.js was removed and rewritten

So the commit has been reverted

It doesn't show that for me... and the formatting shouldn't break it. Ill look at that

Is it because I had a lot of commits after your PR?

Maybe
For me it just shows the lines when I call the timer and the function to format them

Can you have a look at tye Files Changed tab in this PR?

Oh that's weird

Yeah

In that case,  Just drop this code into the other manually?
Neither of the commits show that

I don't know really what you changed to find the changes.

just check the actual commits

Is it just calling duck and unduck?

In that case, Just drop this code into the other manually?
Neither of the commits show that

Okay

yep. Also, your merge commit seems to be the thing deleting everything

I will check the commits then :)

I will try to add evrything manually

Added the changes manually!

Okay!

U will merge the other one a bit later .


15.6.274828.2005 is missing

https://docs.microsoft.com/en-us/visualstudio/install/visual-studio-build-numbers-and-release-dates

@Blonder Thanks for letting us know; this should be fixed either later today or tomorrow morning.

@Blonder This page is now updated: Visual Studio 2017 build numbers and release dates Thanks again for your feedback!


Created a Separator System

This allows the select and select_multiple to have separators in the middle if they are prefixed with :SEPARATOR:.
It could also be used to put a description for another option.
names = [
    "Frodo Baggins",
    "Samwise Gamgee",
    "Legolas",
    "Aragorn",
    ":SEPARATOR:" + ("=" * 32),
    "[red]Sauron[/red]",
]
# Choose one item from a list
name = select(names, cursor="🢧", cursor_style="cyan")

This example with add a separator above the last option.

I have been using this in my own project, and I wanted to provide it in case anyone else would find it useful

I'm sure it's obvious, but in case anyone can't tell, I'm very new to using git

Please don't worry, I am very glad you chose to contribute to my project! Glancing over the code, I have gathered a few remarks, but I haven't found time to write them down just yet as I am somewhat pressed for time. I believe, I should be able to get to it tomorrow.

@AnthonyMakesStuff, sorry for delay, life got in the way of review.
Anyway, I've got to take a proper look today. I like this new feature, I can definitely imagine a use-case for having a way to provide sub-groups of options. This feature was already available in cutie from which I have inherited most of the code (this started as a fork and then diverged too far).
That said, I'd envision different sort of implementation. This one relies heavily and specific formatting of strings, which provides more room for user error and is more difficult in terms of automated preparation of the data for displaying. Python has a rich set of data-structures available out of the box and this seems like an good application for the dictionary (Dict[str, List[str]]).
As an example with 'historical' and 'fictional' being the sections:
people = {
  'Historical': [
    'Napoleon',
    'Julius Caesar',
    'Marie Curie',
  ]
  'Fictional': [
    'Mark Watney',
    'Harry Potter',
  ]
}

select_multiple(options=people)

This would be a bit more of a hassle to implement but it would be cleaner in terms of usage and data preparation for displaying.
If you would like to have a go at it, please do let me know. Otherwise I will implement it myself in near future. Either way, thank you very much for the contribution and inspiration.


Mapping of newly added number columns is not inferred automatically/correctly

Release number or git hash: v4.0.0
Web browser version and OS:

Steps to reproduce

Have data loaded in a ranking
Manually add a number column with an accessor to existing data
See how histogram ranges is not updating correctly

See this example: https://codepen.io/puehringer/pen/wvMNPGM?editors=0010
Column A was added by the builder, Column B is a column desc manually added, and Column C is a manually instantiated column. All refer to the same data, and therefore should show the same ranges.
Please note that in the pen, the last line is lineup.data.setData([{a: 0}, {a: 100}]);, which updates the data and should "force" update the columns B and C (A should probably remain the same as it was added via the builder?).

Observed behavior
Added columns do not compute the histogram/ranges correctly.
Expected behavior
Ranges of a new number column should be computed correctly, if not explicitly given.
Remarks
I looked through the code quickly and noticed one thing which might explain this issue:
The following line is used to retrieve the number stats of a column (it is cached):
https://github.com/lineupjs/lineupjs/blob/6a709671b65980335b8c10f02df7e0c333721ded/src/provider/DirectRenderTasks.ts#L201-L203
If you follow the calls, you will land here, where you retrieve the current values/numbers if the value above was not cached:
https://github.com/lineupjs/lineupjs/blob/6a709671b65980335b8c10f02df7e0c333721ded/src/provider/tasks.ts#L197
Note that raw is most likely false from the calls I have seen, such that getNumber will be called on the column.
But here, the column does not actually have a valid mapping, such that it always returns the range [0, 1] which is then cached and used for the filter histogram.

deriving numerical ranges / categories / ... is a feature of the builder not LineUp and it does that statically at the beginning. Thus, once LineUp is created its description (and domain, ...) is fixed

Is there a way of bringing this feature to LineUp?
We are facing this issue in many applications where data is set asynchronous using setData(...) on the data provider. Manually updating all columns seams to be cumbersome?
Also in the above example, won't some users expect the columns to auto-adjust on the range changes, especially on the inferred one?
Alternatively, would it be possible to expose such feature that reinitializes the ranges? As far as I know calling dataNumberStats with raw: true will lead to the real ranges, something that could be used to update the internel mapping?
Ideally there would be the distinction between a fixed domain and an auto-adjusted one in NumberColumn.
Also: we do not have this problem with DateColumn, as it auto-adjusts to the data. It seems to be weird that the date-column does auto-adjust, and the number-column doesn't. See the updated pen again for this behavior.

the big difference between a number and date column is the number mapping. Thus, in a date column the max/min date has just a visual effect on the histogram. However, for numbers it influences the mapping, thus influences the data.
e.g., when sorted by a date column and you add a new min the worst thing is that the row is appended first. When adding a new minimum value to a number column, it could change the order of all rows, when the column is used in a stacked column, or a fancy data mapping is used.
Thus, LineUp was decided that the meta data about the ranking are given before lineup is instantiated. The Date column was later added but since it has only limited capabilities the min/max was automatically handled.

@sgratzl Thanks for your explanation. I understand your point. However, I agree with @puehringer that this inconsistency is hard to understand for developers that "just use" LineUp and it is an important feature for our apps.
If you are concerned about the performance, due to recomputation and rerendering, I would argue that this must be (and is probably already be) done if DataProvider.setData() is called. Otherwise can we add a settings flag that allows such dynamic LineUp (with a disclamer that it might decrease the performance)?

This issue might be a duplicate of https://github.com/lineupjs/lineupjs/issues/236, but we can continue the discussion here.

if you wanna implement this can you create an issue with specific instructions when to apply, when not to apply it, what effects it should have on things like the current filter, the current data mapping, the current color mapping, the current grouping criteria, what events should be sent out, ...

Ok, we will do next week as we have a couple of releases on our list this week.


Benchmark results

Any chance you could provide the benchmark results in a section of the README? It helps to evaluate the options out there. I appreciate how concise and portable your module is.

I originally wanted to have something like a little table of benchmarks in the README, but given the number of different configurations the module (and other modules) can run on and the differing results of the benchmarks, I felt it'd be better to provide the scripts so people could benchmark it themselves, rather than potentially misleading anyone when the benchmarks I provide differ drastically from what they get on their setup.
For example, different version of LuaJIT change the relative benchmarks, these also differ between Lua 5.1, 5.2 and 5.3. In cases where LPeg is being used, json.lua running on non-JIT Lua is slower (for obvious reasons), but in cases where LuaJIT is being used json.lua tends to out-perform the libraries I tested which do use LPeg (with or without LuaJIT).
That being said, here is what I get on my setup using the provided benchmark scripts, across different versions of Lua. json4lua's decoding is omitted because it took longer than I was willing to wait for it to decode the data.
LuaJIT 2.0.2
[decode]
Lua version   : LuaJIT 2.0.2
CPU name      : Intel(R) Core(TM)2 Duo CPU     T7500  @ 2.20GHz
../json.lua   : 0.022s [x1] (min: 0.0214s, max 0.0234s)
dkjson.lua    : 0.0656s [x2.98] (min: 0.0647s, max 0.067s)
jfjson.lua    : 0.0805s [x3.65] (min: 0.0793s, max 0.0816s)

[encode]
Lua version   : LuaJIT 2.0.2
CPU name      : Intel(R) Core(TM)2 Duo CPU     T7500  @ 2.20GHz
../json.lua   : 0.0302s [x1] (min: 0.0298s, max 0.0308s)
dkjson.lua    : 0.0413s [x1.37] (min: 0.0404s, max 0.0419s)
jfjson.lua    : 0.0517s [x1.71] (min: 0.0513s, max 0.0522s)
json4lua.lua  : 0.0499s [x1.65] (min: 0.0495s, max 0.0502s)

Lua 5.1
[decode]
Lua version   : Lua 5.1
CPU name      : Intel(R) Core(TM)2 Duo CPU     T7500  @ 2.20GHz
../json.lua   : 0.117s [x1] (min: 0.116s, max 0.119s)
dkjson.lua    : 0.131s [x1.12] (min: 0.129s, max 0.134s)
jfjson.lua    : 0.131s [x1.12] (min: 0.129s, max 0.134s)

[encode]
Lua version   : Lua 5.1
CPU name      : Intel(R) Core(TM)2 Duo CPU     T7500  @ 2.20GHz
../json.lua   : 0.0583s [x1] (min: 0.057s, max 0.0615s)
dkjson.lua    : 0.0692s [x1.19] (min: 0.0684s, max 0.0703s)
jfjson.lua    : 0.096s [x1.65] (min: 0.0954s, max 0.0964s)
json4lua.lua  : 0.0911s [x1.56] (min: 0.0898s, max 0.0928s)

Lua 5.2
Lua version   : Lua 5.2
CPU name      : Intel(R) Core(TM)2 Duo CPU     T7500  @ 2.20GHz
../json.lua   : 0.124s [x1] (min: 0.122s, max 0.128s)
dkjson.lua    : 0.138s [x1.11] (min: 0.133s, max 0.141s)
jfjson.lua    : 0.138s [x1.11] (min: 0.136s, max 0.142s)

[encode]
Lua version   : Lua 5.2
CPU name      : Intel(R) Core(TM)2 Duo CPU     T7500  @ 2.20GHz
../json.lua   : 0.0629s [x1] (min: 0.0626s, max 0.0633s)
dkjson.lua    : 0.0761s [x1.21] (min: 0.0754s, max 0.0775s)
jfjson.lua    : 0.105s [x1.67] (min: 0.103s, max 0.109s)
json4lua.lua  : 0.0935s [x1.49] (min: 0.0921s, max 0.0949s)

Lua 5.3
[decode]
Lua version   : Lua 5.3
CPU name      : Intel(R) Core(TM)2 Duo CPU     T7500  @ 2.20GHz
../json.lua   : 0.131s [x1] (min: 0.127s, max 0.14s)
dkjson.lua    : 0.135s [x1.03] (min: 0.131s, max 0.14s)
jfjson.lua    : 0.136s [x1.04] (min: 0.134s, max 0.145s)

[encode]
Lua version   : Lua 5.3
CPU name      : Intel(R) Core(TM)2 Duo CPU     T7500  @ 2.20GHz
../json.lua   : 0.0599s [x1] (min: 0.0576s, max 0.0624s)
dkjson.lua    : 0.0736s [x1.23] (min: 0.0724s, max 0.0749s)
jfjson.lua    : 0.0992s [x1.66] (min: 0.0971s, max 0.102s)
json4lua.lua  : 0.0929s [x1.55] (min: 0.0905s, max 0.101s)

I understand, thank you for sharing your local results.


USB device name changes after reboot

Hello. Sometimes when my computer restarts my container for deconz does not start due to the USB device has changed name. The USB is in the same port all the time. What is changing the name and can I prevent it some how? Restarting the container doesnt work either, a full computer reboot is needed for it to work, until it reboots again..

It's baked into Linux and can unfortunately not be changed, the device can get a new name for various reasons.
And the new name isn't automatically visible in the container.
However there is a different way to start the container so this shouldn't be an issue, you might try the following:
https://github.com/marthoc/docker-deconz/issues/298#issuecomment-732293745

It's baked into Linux and can unfortunately not be changed, the device can get a new name for various reasons.
And the new name isn't automatically visible in the container.
However there is a different way to start the container so this shouldn't be an issue, you might try the following:
https://github.com/marthoc/docker-deconz/issues/298#issuecomment-732293745

I do feel this should be fixed in the docker build FI with the information provided in the post above.
I'm also using a Zwave stick and it's really annoying that every reboot (luckily there aren't many on a server) I have to check if the ACM0 is linked to the right device or not.
Every other docker i'm using is able to refer to the "path-by-id" directly and never give me issues.
A fix would be greatly appriciated!

This issue can be solved by using a "path-by-id" solution as mentioned in this issue.
However this has nothing to do with the docker image itself.


Update sbt to 1.4.8

Updates org.scala-sbt:sbt from 1.4.7 to 1.4.8.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scala-sbt", artifactId = "sbt" } ]

labels: library-update, semver-patch

https://github.com/scala/scala-dev/issues/765


Dereference allOf

While we wait for v5, allOf is the best way to combine multiple schemas. It would be nice if there was an option which would dereference this for you. For now I'm going to try and use https://www.npmjs.com/package/json-schema-resolve-allof

While we wait for v5

Note that JSON Schema draft 5 is out, but was a very minimal update and introduced some bugs.  It does not have a meta schema (we may or may not publish one given the problems with the draft).  We are working on getting draft 6 out (with a meta-schema) which you can track here with this milestone
Draft 6 is not expected to address the open re-use questions, although we continue to discuss options and I hope to get some things into draft 7.  There's still a lot of debate, and we want to put out a usable draft 6 ASAP.


Change status checks

Description
The current status checks were checking until the status was set to ok which can take a while. Changed the checks to continue on running
Related Issues
Closes #15
Checklist:

[x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
[x] Have you linted your code locally prior to submission?
[x] Have you successfully ran tests with your changes locally?

Run/output from local build
➜  ~ docker-machine create -d vultr --vultr-api-key=$VULTR_API_KEY dm
Running pre-create checks...
Creating machine...
(dm) waiting for ip address to become available...
(dm) Created Vultr VPS with ID: 42498956, Public IP: <IP_ADDRESS>
(dm) waiting for server state to become 'ok'...
(dm) installing and booting processes on the server are complete, server is ready to use
Waiting for machine to be running, this may take a few minutes...
Detecting operating system of created instance...
Waiting for SSH to be available...
Detecting the provisioner...
Provisioning with ubuntu(systemd)...
Installing Docker...
Copying certs to the local machine directory...
Copying certs to the remote machine...
Setting Docker configuration on the remote daemon...
Checking connection to Docker...
Docker is up and running!
To see how to connect your Docker Client to the Docker Engine running on this virtual machine, run: docker-machine env dm

➜  ~ docker-machine ls
NAME     ACTIVE   DRIVER   STATE     URL                        SWARM   DOCKER      ERRORS
dm       -        vultr    Running   tcp://<IP_ADDRESS>:2376           v19.03.14


consider use of flow

Have you consider the use of flow for static type checking?

I want this to optionally use TypeScript "eventually". TypeScript is just a lot more popular than flow.
I could use some help on that 🤓

I could use some help on that 🤓

Just call it and I can help to create  a PR with typeScript 👍


Issue: Improve Contact Form Design

The current contact form can be made more attractive and professional by improving its design and usability. Here are a few suggestions to enhance the user experience:
Suggestions
1.Apply rounded corners to input fields and buttons for a modern look.
2.Use shadow effects and subtle hover animations to make elements more interactive.
3.Add icons inside the input fields (e.g., email icon for the email field, message icon for the text area) to guide the user.
4.Improve the typography by using readable fonts, proper font sizes, and spacing between form elements.
5.Button Styling:

Make the submit button stand out with a bold color, hover effects, and a concise label (e.g., "Send Message").
Ensure buttons are responsive and well-sized on both mobile and desktop devices.

Responsive Design:

Make sure the form is mobile-friendly by using responsive frameworks like Bootstrap or CSS Grid.
Adjust padding and margins for smaller screens to ensure the form elements are easy to tap and navigate.

for now it is looking good, we will look for the improvements later, so i am closing this issue.


Funktion to populate Blazegraph

if Blazegraph is needed to run Metaphactory, maybe switch from Jena to Blazegraph (or populate both Triple Stores)
Function to CURL data into Blazegraph could work similar to this:
https://github.com/dracor-org/dracor-api/blob/a5f3abf78659fcaf4218687f2248a5d8ca56f441/modules/rdf.xqm#L496

see #157 ; added Blazegraph-Functions to rdf-Module


Unit Conversion Options

Hi all,
Different unit options are now available for a range of variables as the following:

Temperature variables can now be selected in app.selected() as the native unit K, as well as °C, °F, and °R
Wind variables can be selected as native unit m/s, and knots
Pressure can be selected as native Pa, and now hPa, mb, inHg
Precipitation variables can be selected as native mm, and now also inches
Moisture ratio can be selected as native kg/kg, and now g/kg
Please test these out, and if different units need to be added or removed from the list.

@nicolejkeeney is writing one last additional test to ensure different spellings of alternative units checks out ("kts" vs. "knots")
How this modifies app.select():

If anyone has any ideas for additional unit conversions they think would be useful, feel free to suggest them! It's pretty easy to add more now that the code base is all set up


Output consistency

This PR resolves differences between task completion reporting in the validate_by_mapper_type DAG and the harvest_collection DAG (the airflow-side bulk harvest DAG and the registry-side bulk harvest DAG, respectively).
Dataclasses were introduced in Python 3.7 and resemble a NamedTuple but with type hinting. I've used dataclasses to represent return values to create a bit more contractual clarity.
Fetching:

lambda_function.fetch_collection had returned a list of dictionaries describing a page status. The @task fetch_collection_task and fetch_registry_collections.fetch_endpoint had both done some amount of "flattening" these page statuses into some stats about the collection overall in similar, but slightly different ways. This flattening now occurs uniformly in aggregate_page_statuses.
Since lambda_function.fetch_collection is no longer recursive, aggregate_page_statuses can now be easily called from within the lambda_function.fetch_collection function. lambda_function.fetch_collection now returns a FetchedCollectionStatus object instead of a list of dictionaries describing the fetching status for every page.
Both @task fetch_collection_task and fetch_registry_collections.fetch_endpoint had printed various information about this aggregated status, but in slightly different ways. The print_fetched_collection_report function now prints this information uniformly.

Mapping:

lambda_function.map_page returns a dictionary of data about the mapped page status. @task get_mapping_status_task had been flattening this list of mapped page statuses into a mapped collection status using lambda_shepherd.get_mapping_status and had been returning it for inspection as XCOM values in the airflow UI.
lambda_shepherd.map_collection (used by @task map_endpoint_task) had also been using lambda_shepherd.get_mapping_status to perform this same kind of aggregation, and map_registry_collections.map_endpoint had been printing this data instead of displaying it as XCOM values for inspection in the airflow UI.
Now, map_registry_collections.map_endpoint and @task get_mapping_status_task use map_registry_collections.print_map_status to print mapped collection status information.
Since @task get_mapping_status_task is no longer relying on the Airflow XCOM UI to display this status information, that frees up the return value of @task get_mapping_status_task to return the list of page filenames (in batches) to send to the content_harvesting task for dynamic fanout, allowing us to get rid of the get_mapped_page_filenames_task, which had taken that same list of mapped page statuses, and returned a list for the content_harvesting task's input.

Content Harvesting:

I would love to get collection-level aggregation stats on content harvesting tasks, but I don't know how to populate XCOM values from ECS RunTask and Docker Operators. Adding this would create a new task following the dynamic fanout of content harvesting.

This is really nice! I reviewed most of it while you were writing up your notes (which helped verify that I had understood the changes correctly)! Data classes (new to me) are really nice here.

+1 to dataclasses everywhere we can.
No concern about losing the historical runs with the rename. I do think it is cleaner.


Issue co-existing with gRPC library (Swift, CocoaPods)

Hello,
We have found that when the KSCrash pod is included with the gRPC-Core pod, it leads to C++ 'undefined template' errors to do with the Optional type.
The minimal reproduction case is to:

Create an empty iOS application using Swift in Xcode
Run pod init
Add pod 'KSCrash' and pod 'gRPC-Core' to the dependencies
Run pod install
Open the workspace file
Try to build the project

Compilation is halted early due to many errors such as:

Implicit instantiation of undefined template 'llvm::Optional' Demangle.cpp

As I understand it, both dependencies declare an Optional template, but in different namespaces. Independently these dependencies compile fine, but together you can observe the errors above.
Can anyone possibly explain the issue and point us in the right direction for a solution to enable use of both libraries?
Thanks in advance,
Chris
P.S. this is the tooling I'm using:

Xcode 10.2.1
Swift 5
CocoaPods 1.7.1

@cgwyllie , do you try use Firestore in the same project? I'm experiencing this compilation error as well, only when I try to use Firestore at the same time, so it seems like a conflict (see this comment: https://github.com/rollbar/rollbar-ios/issues/244#issuecomment-580779316).
Did you solve it somehow? I'm thinking about two solutions:

Pre-compile KSCrash to a framework and use it directly from my library (I still don't know how to do it because I created a CocoaPod that uses KSCrash).
Solve it in an elegant way with my podspec configuration (still don't know how).

Hi @PerrchicK, we traced it ultimately back to the gRPC library (as noted in this issue), which is a dependency of Firestore (how we initially discovered it).
We're not sure on the best resolution as yet but it does seem some others are encountering similar/related issues.

After reading around this issue based on work by Rollbar, and similar issues from Facebook's react-native, it seems this can be resolved by disabling header maps, and linking against llvm when building in CocoaPods.
For example, in the Podspec, adding:
  s.ios.libraries = 'c++', 'z', 'llvm'
  s.ios.pod_target_xcconfig = {
    'USE_HEADERMAP' => 'NO',
    'HEADER_SEARCH_PATHS' => '"$(PODS_ROOT)/KSCrash/**"'
  }

This is based on:

https://github.com/rollbar/rollbar-ios/pull/275
https://github.com/facebook/react-native/commit/f3f44eee59e8991e197c854e5fee719105c045cd

Header maps seem to flatten includes based on name across many libraries, which results in the wrong headers being used in the wrong projects. See https://developer.apple.com/library/archive/documentation/DeveloperTools/Reference/XcodeBuildSettingRef/1-Build_Setting_Reference/build_setting_ref.html "Header-Map Build Settings" for context.
Not sure if this is a suitable long-term solution, but if so would happily produce a PR to that effect.


Specify exactly which files to package

Currently, chai-subset packages the following files up when chai-subset is versioned:
  8B .eslintignore
505B .eslintrc
107B .jscsrc
 59B .npmignore
112B .travis.yml
1.0K LICENSE
1.7K README.md
204B coverage
102B lib
2.2K package.json

Only package.json, README.md, LICENSE, and lib are really needed. Specifying the "files" key in package.json will limit these files, removing the need for .npmignore as well.
https://docs.npmjs.com/files/package.json#files

Coverage remained the same at 100.0% when pulling c9de021564ee85ae2991967adc33506446d66b59 on MarkHerhold:master into b0de33df55a80a62df6f6b573a488a759486887d on debitoor:master.

Great contribution, @MarkHerhold , thanks a lot!

much better now

btw chai-subset 1.2.2 is out ;)


Roadmap

Roadmap

[x] custom fetch plugin and useFetch composable.
[x] Database presets
[x] support official SurrealDB Rest integration.
Discarded in favor of RPC. Can still be manually used via $surrealFetch and useSurrealFetch.
[x] support official SurrealDB RPC integration.
[x] server side surrealFetch and surrealRPC utils
[x] catch Surreal errors
[x] built-in auth composable.
[x] custom websocket composable.
[x] unwrap RPC responses by default
[ ] doublecheck types
[ ] docs
[ ] study Concise Binary Object Representation (waiting for reply on undio#18)
[ ] vitests

Experiment with SurrealDB 2.0 alpha

[ ] headers prefix
[ ] new auth

hijacking this issue to track module status and roadmap

Can you make it Nuxt v3 compatible please? 🙏
Module site states that its not yet https://nuxt.com/modules/SurrealDB#nuxt-surrealdb

Can you make it Nuxt v3 compatible please? 🙏 Module site states that its not yet https://nuxt.com/modules/SurrealDB#nuxt-surrealdb

That was actually a bug and fixed with nuxt/modules#980 PR.
The minimum version compatible is currently 3.10

Thank you for you great work :) it's really amazing ☺
Just one question please ! Are you using the Surrealdb JS Sdk ?

Thank you for you great work :) it's really amazing ☺

Thank you 🙏

[...] Are you using the Surrealdb JS SDK ?

No, currently I'm not.
The main reason being that I'm more focused on environment support, to maximize the module's usability in any production env supported by Nuxt itself.
This might change in the future, but it will depend on a number of factor such as surrealdb/surrealdb.js#251.

A great repo for reference : https://github.com/dvanmali/surrealdb-nuxt-starter

Indeed, the SDK is so simple to use that simply wrapping it didn't seem to provide any added functionalities compared to directly using it. I'm also considering changing some of my params to be more inline with the SDK ones

Thank you for the great work you're offering it is really promissing and i'll give it a try in a project right away...
Just some ideas if you don't mind as i've noticed that you're using vueuse/useWebsocket and there is unjs/crossws (from Pooya) the Nitro maker i think it's already builtin in Nitro ?
It's Just a Thought Btw ☺

crossws is a platform agnostic websocket server, while vueuse/useWebsocket is a reactive websocket client 😁

I already tried the Surrealdb JS SDK and I'm not that convinced

Keep in mind that the JS SDK is still under active development and not officially finalized, so anything could change. Not to mention that their approach is to support everyone (framework and non) with a single SDK.
What made me choose to start working on this module was to have a tighter implementation for Nuxt itself. Yes this means almost double the work, but the final outcome is to be able to have Nuxt-specific features that may not be implementable into the SDK itself
My current approach is to follow as close as possible the RPC endpoint API, the same used by the JS SDK. So the feature-set should be pretty similar

Surreal v2 is almost at stable release, it would be great if we can implement the missing pieces with the new auth and be ready to go, atleast in next branch.

Indeed. I still haven't tested v2 myself, but I already added some of the required changes


Linker error when setting target to wasm32-wasip2

Hi,
I encounter this error when trying to compile some C code to wasm. To reproduce this error:
$ wasi-sdk-22.0/bin/clang -v -Wl,--version --target=wasm32-wasip2

clang version 18.1.2 (https://github.com/llvm/llvm-project 26a1d6601d727a96f4301d0d8647b5a42760ae0c)
Target: wasm32-unknown-wasip2
Thread model: posix
InstalledDir: wasi-sdk-22.0/bin
 "wasi-sdk-22.0/bin/wasm-component-ld" -m wasm32 --wasm-ld-path wasi-sdk-22.0/bin/wasm-ld -Lwasi-sdk-22.0/bin/../share/wasi-sysroot/lib/wasm32-wasip2 wasi-sdk-22.0/bin/../share/wasi-sysroot/lib/wasm32-wasip2/crt1-command.o --version -lc wasi-sdk-22.0/lib/clang/18/lib/wasip2/libclang_rt.builtins-wasm32.a -o a.out
error: invalid option '--version'
clang: error: linker command failed with exit code 1 (use -v to see invocation)

So basically it fails to check the version of linker when I set --target=wasm32-wasip2.
However, if I set the target to wasm32-wasi-threads, it works fine:
$ wasi-sdk-22.0/bin/clang -v -Wl,--version --target=wasm32-wasi-threads

clang version 18.1.2 (https://github.com/llvm/llvm-project 26a1d6601d727a96f4301d0d8647b5a42760ae0c)
Target: wasm32-unknown-wasi-threads
Thread model: posix
InstalledDir: wasi-sdk-22.0/bin
 "wasi-sdk-22.0/bin/wasm-ld" -m wasm32 -Lwasi-sdk-22.0/bin/../share/wasi-sysroot/lib/wasm32-wasi-threads wasi-sdk-22.0/bin/../share/wasi-sysroot/lib/wasm32-wasi-threads/crt1-command.o --version -lc wasi-sdk-22.0/lib/clang/18/lib/wasi/libclang_rt.builtins-wasm32.a -o a.out
LLD 18.1.2

I do notice that when setting target to "wasm32-wasi-threads"  it uses "wasm-ld", while "wasm-component-ld" is used when setting target to "wasm32-wasip2". I guess there might be something related to https://github.com/WebAssembly/wasi-sdk/issues/426
Also, I'm using clang from wasi-sdk-22.0 with sysroot built from source with the latest wasi-libc repo. Not sure if it has anything to do with this error. But even if I specify --sysroot to "wasi-libc/sysroot", same error happens.
I just want to understand why this is happening and how to avoid this when using wasm32-wasip2 as target. Because this version check is a part of my project. Thanks a lot!

The wasm-component-ld distributed with wasi-sdk-22 didn't support --version, but the latest version does now. I plan on updating wasm-component-ld after https://github.com/WebAssembly/wasi-sdk/pull/429 lands.

If you'd like you can build the latest source of the binary itself and configure that to be used instead

I believe this is fixed in wasi-sdk-23.0, so closing.


Pipeline for fast, single image prediction

📓 New <Tutorial/Example>
Is this a request for a tutorial or for an example?
Example
What is the task?
How to do a fast prediction for single  image
Let say we start with something like

from mantisshrimp.all import *
from PIL import Image

model = faster_rcnn.model(num_classes=5)

model.load_state_dict(torch.load(weights_path, map_location=lambda storage, loc: storage))
model.eval()

img = Image.open(path)

How to add Normalizing transformation and get a prediction without constructing the Parser and Dataset
Is this example for a specific model?
FasterRCNN

Don't remove
Main issue for examples: #39

We have a snippet for that, still needs to be converted to a tutorial, check it out here

Yeah I works, I haven't seen it. However it might be useful to add Resize tfms to the transformations list
tfms = tfms.A.Adapter([tfms.A.Resize(384, 384), tfms.A.Normalize()]) So we are sure that the image domain is same

@tugot17 can this be closed?


Allow capitals letter in tilesets

Right now the specs forces the tilesest to be only lowercase

Each tileset id must be of the form {username}.{mapname} with all lowercase characters, and the username MUST be associated with your Mapbox account.

In reality tileset and account name can have capital letters.
TO DO:

update specs
update cli

cc @dnomadb @perrygeo

Included in https://github.com/mapbox/pxm-manifest-specification/pull/14


Display track metadata in tray

#264 This was harder than I thought, but I finally got it. 😌

I personally don't get why people use _foo for method names, if you want to make it private, just put it in closure and don't export it, or just drop _ from the name.

I'm not sure what you mean by a closure. That was my attempt at doing pseudo-private functions, since javascript doesn't actually support real private functions yet. I'd be fine switching it to do something else.

@dkniffin by closure I mean this:
const privateFn = function(param1, param2) {
  // ...
};

const publicFn = function(param) {
  // some code ...
  // use privateFn
  return privateFn(param, 42);
};

export default {
  publicAPI: publicFn
};

This way you don't have to use _ prefix to make privateFn "private".
If you need to use this, use .bind method, it is pretty fast in V8

How would that look for a class?

For class that would look pretty much the same, the downside is that this function won't be a part of class.
I'd not worry about making these private and just given them names that make sense, there is no such thing as "public" API in museeks yet, so I don't think it matters.

Told you it would not be as easy as it seems :p
Just about the look, would it be possible to see what this would look like? :
[title]
on [album]
by [artist]

I like keeping the artist second, personally:

Also, this is something we might be able to have as a user preference, maybe. I'm a big fan of lots of configuration options in apps. Maybe a checkbox for what's shown, so if people don't care about what album, they can disable that, etc. What do you guys think?

Can we center labels?
What happened to idea of small window for mini-player?

I'm a big fan of lots of configuration options in apps

I'm a big fan of sane defaults. For museeks, if we can't do it right, should we do it at all?
IMO Minimalism is one if the strongest sides of museeks and I'd keep following it.

Centering label would not look good.
I agree with Yury for minimalization.
About mini-player: later maybe, it's a longer stuff to code

Alright, sounds good on all of that. I don't know if we can center the labels, even if we wanted to.

Ok, good to me, thanks !


Mattermost import

Hi! I exported data from MM, created a python script to separate a single team from export, and converted data via ./manage.py convert_mattermost_data /tmp/mattermost_data --output /tmp/converted_mattermost_data
Everything Ok - data was converted, but I couldn't import data to zulip. I got django.db.utils.IntegrityError: duplicate key value violates unique constraint "zerver_subscription_user_profile_id_recipient_id_6051164b_uniq" DETAIL:  Key (user_profile_id, recipient_id)=(71, 342) already exists.
I found zerver_subscription in realm.json but there is no object with such user_profile_id  and recipient_id. Moreover, I can't understand how zulip reads data from realm.json, because I looked at DB, checked zerver_subscription table and found strange data (1 screenshot). I don't have these objects in realm.json. Also wrong data is in psql logs:
INSERT INTO "zerver_subscription" ("id", "user_profile_id", "recipient_id", "active", "is_user_active", "is_muted", "color", "pin_to_top", "desktop_notifications", "audible_notifications", "push_notifications", "email_notifications", "wildcard_mentions_notify") VALUES (8, 8, 8, true, true, false, '#c8bebf', false, NULL, NULL, NULL, NULL, NULL), (9, 9, 9, true, true, false, '#94c849', false, NULL, NULL, NULL, NULL, NULL), (10, 10, 10, true, true, false, '#c6a8ad', false, NULL, NULL, NULL, NULL, NULL), (11, 11, 11, true, true, false, '#c2c2c2', false, NULL, NULL, NULL, NULL, NULL), .... There are no objects with this values in realm.json. But I can see inserts that caused error in logs (screenshot 2)

Please, help me to figure out how to fix my data for successful import?
P.S. After converting data, I've got the wrong ids order in "zerver_subscription". I added part of my realm.json.
realm_json.txt

Please stop by "production help" in chat.zulip.org so we can debug a bit more interactively; the failure looks familiar but I don't recall what the story is.


cmake: use property list for GPU_TARGETS

This PR removes the variable AMDGPU_TARGETS which was visible to the user.
The user was seeing two variables GPU_TARGETS and AMDGPU_TARGETS.
Without checking the documentation it was not possible to say which one must be changed to set a specific target architecture.
Changing AMDGPU_TARGETS after running cmake once had no effect on GPU_TARGETS and therefore the user request was silently ignored.
With this PR the user can provide a list of targets via GPU_TARGETS as described in the documentation.
It is possible to set the variable by using cmake -DGPU_TARGETS=gfx908 or via ccmake.
ccmake is providing a drop-down list to choose a specific supported architecture.

The list of supported target is taken from: https://github.com/ROCm-Developer-Tools/HIP/blob/main/docs/markdown/hip_porting_guide.md#compiler-options-supported-on-amd-platforms

Closing all existing pull requests that do not target the develop branch. In case this pull request is still valid, please rebase your changes against develop branch and resubmit.


Test fixes and enhancements

Various fixes/enhancements to tests and their execution. refer to individual commits for more info

@andreaskaris PTAL

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 24.34%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
2702

Relevant Lines:
11101

💛  - Coveralls

thx @zeeke, merging this one!


ERROR in input [inputs.exec]

So, I've got ZFS working and zpool_influxdb returns a sensible result, but the logs for telegraf are showing the following error:
ERROR in input [inputs.exec]: Errors encountered: [unable to parse 'zpool_stats,name=tank,state=ONLINE alloc=2590195 ... : invalid number]
Here's a sample zpool_influxdb output:
zpool_stats,name=tank,state=ONLINE alloc=2590195507200u,free=21324182396928u,size=23914377904128u,read_bytes=33366016u,read_errors=0u,read_ops=4640u,write_bytes=139591680u,write_errors=0u,write_ops=12380u,checksum_errors=0u,fragmentation=0u<PHONE_NUMBER>077598776
Edit: I'm guessing this is related to the us at the end of each number, should those be i instead? See here. It totally works if I just tr u i the output string.

This is a transition issue, as influxdb transitions to support unsigned 64-bit integers.
I've changed the default to signed, masked integers and added more words to the
README to help describe how to change in d3274efaafa3a9d0a2762a0f331193cb3747c0cb


Popular open source projects presentation video

The video needs a bit of trimming at the end, but I assume we'll do that when we edit the videos? Otherwise, it seems like a nice overview of a really wide variety of open source projects for people who are brand new to open source.


add get methods to device profile import

will we be able to use Update and Read in the CRUD considering we are "importing" the device profile? We certainly will need to read it so i will start there.

We'll need to implement the whole resource.Resource interface (CRUD methods + Metadata() and Schema()), but we can structure things so that Update() is never invoked.
What are the inputs here, just blueprint_id and device_profile_id? If so, mark 'em both with the RequiresReplace plan modifier, and Update() will never run. It will need to be defined to satisfy the interface, but can be an empty resource.

FWIW, I don't think this one gets a data source.

Agree. We can work on this I have a good framework that just needs review/tweaking.

Turns out we didnt need a branch or changes.  Everything was done in the Provider.


[BUG] failed to create native cluster

Describe the bug
time="2021-11-24T02:42:24Z" level=info msg="[native] executing create logic..."
time="2021-11-24T02:42:24Z" level=info msg="[native] executing init k3s cluster logic..."
time="2021-11-24T02:42:24Z" level=info msg="[native] creating k3s master-1..."
time="2021-11-24T02:42:24Z" level=info msg="[cluster] k3s master command: curl -sLS https://get.k3s.io | K3S_TOKEN='0a8908ea570092b6b4c012850c8d98a6' INSTALL_K3S_EXEC='server --tls-san <IP_ADDRESS> --node-external-ip <IP_ADDRESS> --cluster-cidr <IP_ADDRESS>/16' INSTALL_K3S_CHANNEL='stable' sh -"
[INFO] Finding release for channel stable
[INFO] Using v1.21.5+k3s2 as release
[INFO] Downloading hash https://github.com/k3s-io/k3s/releases/download/v1.21.5+k3s2/sha256sum-amd64.txt
[INFO] Downloading binary https://github.com/k3s-io/k3s/releases/download/v1.21.5+k3s2/k3s
time="2021-11-24T02:44:31Z" level=error msg="[native] failed to create cluster: Process exited with status 35: "
time="2021-11-24T02:44:31Z" level=info msg="[native] executing rollback logic..."
time="2021-11-24T02:44:31Z" level=info msg="[native] instances [10-0-16-7] will be rollback"
sh: /usr/local/bin/k3s-uninstall.sh: No such file or directory
time="2021-11-24
T02:44:31Z" level=warning msg="[native] failed to uninstall k3s on master node 10-0-16-7: Process exited with status 127: sh: /usr/local/bin/k3s-uninstall.sh: No such file or directory\n"
time="2021-11-24T02:44:31Z" level=info msg="[native] successfully executed rollback logic"
To reproduce
1 centos7.6
2 docker 20.10

The logs already shows the failed reason for download timeout from github.com. If your native computer can't get from github, you can change the download mirror here.


Node overhaul 3: introduce generic finalizing logic

This is a big algorithm that doesn't really have any tests as of this PR. When we introduce the policy satisfier it will get some heavy use and we can double-back and fix any bugs that we find (though I've already done a few iterations of this so hopefully it's okay).
Meanwhile, review of this PR should probably just assume that the fine details are okay, and instead review the algorithm itself and surrounding comments.

Going to close this and take a different approach.


Add support for Rails TZ handling

@adamruzicka mind to take a look? Not sure how to properly test this since ActiveSupport::TimeZone is not a dependency.

travis is no longer triggered for PRs, @wvanbergen do you happen to know why? Anyway, this should fix all comments and add testing with active support

Looks good to me, waiting for Travis to confirm

Since I don't have admin permissions over the repo, I can't look at the hooks configuration. @wvanbergen could you please take a look?

Looks like it was deactivated on Travis's end. I think I have re-enabled it. Can you try by pushing something to this branch?

Thanks @wvanbergen, it seems travis is now running again!

Travis is running but doesn't like the changes

fixed the travis definition, it seems now that the change has some negative effect, I'll need to look into more details, seems that the change affected even gemsets without active support

Tests are green now, I updated travis configuration too and removed some old rubies to make the test matrix smaller. I think this is ready to go in. Btw tests revealed an issue if Time.zone is nil (no timezone set) so fixed that as well.

@wvanbergen any concern with old rubies drop from travis matrix? I think we really don't need them anymore

Can we still support ruby 2.3.7? That's the version macOS ships with.

Fair enough, in fact RHEL 7 still ships Ruby 2.0 so I kept old version. The matrix is now bigger but travis seems to handle it fine. Let's see if all turn green now

OK, all green now including old rubies :-)

could this be merged pls?

Thanks @ares !

Thank you!


Extract [npm], [name], [namespace] replacement code so it can be used by generateDocs.js

Is your feature request related to a problem? Please describe.
Since we are now pulling static doc templates from the server we can no longer rely on a replacement process for all instances of [npm], [name], [namespace] to get replaced during the repo init.
The functions for this should be extracted from generate.js into a stand alone utility that can be referenced in generateDocs.js and executed each time the docs are regenerated.
As it stands today the readme.md file requires this to be done manually.
Describe the solution you'd like
All functions for the content replacement should be in a class that can be imported used by any other script.

This is an interesting wrinkle.

The functions for this should be extracted from generate.js into a stand alone utility that can be referenced in generateDocs.js

The issue with this is, we don't have the variable values in memory.
I am wondering if it makes more sense to do a fetch of this content in the generator process itself versus waiting for mdmgk do to the work getting the static content? Maybe in the copyAllFiles function.  Then within the copyFile function the files would be available for the formatTemplateFileContents function.
In the end, this content will be part of the reop's version control, right?

[namespace], [name] and [npm] can all be parsed from package.json name key.

The issue with this is, we don't have the variable values in memory.

[namespace], [name] and [npm] can all be parsed from package.json name key.


Modify virtualDisplay API priority and use DisplayManager first.

Hi @rom1v
This PR is about modify the ScreenCapture virtualDisplay API priority.
The Android kernel team removed the createDisplay method on December 21, 2023. CL: Delete Unsupported APIs
Official ROM updates for Pixel devices (Pixel 5a and newer) released after March 2024 incorporate this kernel change.
Considering the wide range of affected devices – Pixel 5a, 6, 7, 8, and the upcoming Pixel 9.
Prioritizing the virtualDisplay method over createDisplay is recommended, rather than triggering an exception with createDisplay before falling back to virtualDisplay.
Refer to the Pixel Official ROM list, (AP1A.240305.019.A1, Mar 2024) already merged to Pixel 5a and newer devices.
Thank you.
Derek.

Thank you for the PR.
I split into 2 commits and adapted commit messages: branch pr5008. Is it ok for you?

It looks good to me.
Thank you rom1v.

Thank you, merged into dev.


Add auth0 to the backend

some of the endpoints will require middleware that checks if valid token was sent.

[ ] add this middleware layer
[ ] secure all of the endpoints that require it (most likely all of them)

wrong repo


Use Configure iniFile setting for a different location.

buildFromIniFile() supports a different file path, but those settings can not be passed in currently from the helper or the dispatching filter.
This resolves it cleanly and DRY using a joined Configure setting AssetCompress.iniFile to overwrite the
if (empty($iniFile)) {
	$iniFile = APP . 'Config' . DS . 'asset_compress.ini';
}

part.

The file path is only for testing.

One reason I don't like this is how does one then configure for each plugin? Hard coding the path and having no options keeps life simpler.

Well, we actually need to use it to set the path to a different source. That was the main reason to use the existing functionality.

Why?

Because its a strange app setup using plugins as main www roots (the opposite setup as one would expect it to me - not my idea..^^).

Would have been nice, but all righty. Closing.


⚠ 한경주요지수-코스피200 has degraded performance

In bca0baa, 한경주요지수-코스피200 (https://markets.hankyung.com/indices/kospi200) experienced degraded performance:

HTTP code: 200
Response time: 5531 ms

Resolved: 신규상장 performance has improved in 5f4ae96.


OPA Middleware: additional_headers not set on allowed requests

In what area(s)?
/area runtime
What version of Dapr?
Dapr Runtime: 1.10.x
Expected Behavior
While applying OPA policies to requests using the OPA middleware component, headers specified on additional_headers are added to allowed requests.
Actual Behavior
Headers are not including in allowed requests.
Steps to Reproduce the Problem
Define an OPA middleware component like the one below:
apiVersion: dapr.io/v1alpha1
kind: Component
metadata:
  name: mypolicy
spec:
  type: middleware.http.opa
  version: v1
  metadata:
    - name: includedHeaders
      value: "Authorization"
    - name: defaultStatus
      value: 403
    - name: rego
      value: |
        package http

        default allow = false

        allow = {
            "allow": true,
            "additional_headers": other_headers,
        } {
            # get the headers from the JWT claims
            other_headers := {
            "X-Claim-1": jwt.payload["claim1"],
            "X-Claim-2": jwt.payload["claim2"]
            }
        }

        jwt = {"payload": payload} {
            auth_header := input.request.headers.Authorization
            [_, jwt] := split(auth_header, " ")
            [_, payload, _] := io.jwt.decode(jwt)
        }

I meet the same error. The root causes should be here.
https://github.com/dapr/components-contrib/blob/v1.10.5/middleware/http/opa/middleware.go#L217
The var w is a http.ResponseWriter so all the additional_headers going to the response but not request.

@ItalyPaleAle Please help reivew https://github.com/dapr/components-contrib/pull/2795


backend added

Fixes Issue
#Closes #907
Changes proposed

added proper folder structure for backend.
added user schema
added signin signup routes
added yup validators

Check List (Check all the applicable boxes)

[x] - Correct;  My code follows the code style of this project.
[x] - Correct; My change requires changes to the documentation.
[x] - Correct;  I have updated the documentation accordingly.
[x] - Correct;  All new and existing tests passed.

Hii, LGTM... @TechSpiritSS could you pls check it once?

Current PR contains generic backend code and it is missing many routes which were present in previous backend.
The routes implemented are different from the initial ones eg. signin instead of login.
The generated token is not being used or sent back in the response.
Generic error messages

okkay i will make the changes

any update on this @Ja3mamtora ?

Working on it would complete it by this weekend


Updated Confirmations screens for Audit.

Bug: 352551711
WHAT
Update Confirmations to use open-on-phone icon which has the correct size (48dp)
WHY
Helps match sample screens with audit
HOW
Checklist :clipboard:

[ ] Add explicit visibility modifier and explicit return types for public declarations
[ ] Run spotless check
[ ] Run tests
[ ] Update metalava's signature text files

continuing in https://github.com/google/horologist/pull/2323


multiple components within the same app have route creation conflict

/kind bug

What versions of software are you using?
Operating System:
Output of odo version: odo v2.2.3 (b2ca2a81a) - latest main branch
How did you run odo exactly?
odo create nodejs component-a
odo push
odo create nodejs component-b
odo push
Actual behavior
component-a created a route http-3000-app, and component-b is trying to create another http-3000-app, but failure since the route/URL already exist within the same namespace
Expected behavior
the routes odo create should be unique for each component. should append component name instead of app name. one app can have multiple components, and this will result into potential conflicts if I have multiple components under a single app contain the same endpoint name
Any logs, error output, etc?
release v2.2.3 works fine for me, since the route name was <endpointName>-<CmpName>
URL/route name now is <endpointName>-<AppName>
this is a regression introduced by: https://github.com/openshift/odo/pull/4858/files, at line https://github.com/mik-dass/odo/blob/e1391b26245af7a4d93e7a3fbb9a3c67a7b566b6/pkg/url/kubernetes.go#L280
which previously was :
routeName, err := util.NamespaceOpenShiftObject(url.Name, k.componentName)

/area url

@mik-dass can you PTAL?

the routes odo create should be unique for each component. should append component name instead of app name. one app can have multiple components, and this will result into potential conflicts if I have multiple components under a single app contain the same endpoint name

We cannot use only the combination of url name and component name as the name of the route due to conflicts when the user creates two URLs with the same name in two different components with the same name belonging to two different apps.
This was the reason behind https://github.com/openshift/odo/issues/4550.
We also cannot use the combination of url name, component name and app name as on openshift clusters the host is decided by appending the namespace's name to the route name (in this case url-name+component-name+app-name). This in many cases, (even on the CI) causes the host name to be longer than the max 63 characters allowed and thus the routes fail to work.
Thus we dropped support for same route names in the same app (similar to s2i) for now. We will need to find a better solution in the future.

Thus we dropped support for same route names in the same app (similar to s2i) for now to provide better support for app. We will need to find a better solution in the future.

This may work for a single component application, but is not expected for microservices architecture. especially for any uses of parent reference, as you cannot change endpoint name from parent devfile.

This may work for a single component application, but is not expected for microservices architecture. especially worse user experience for any uses of parent reference, as you cannot change endpoint name from parent devfile.

Yes but switching back to endpoint-name+component-name won't solve the problem as it might cause interference/conflicts between resources belonging to different apps due to the reasons and situations mentioned previously. It was one of the reasons behind #4550.
We will need to find a better solution than switching back to the previous way. We can use random names for routes or figure out a way to detect and manually select the host name. @kadel wdyt?

Shouldn't the naming decisions be ideally handled by devfile/library?
odo is using its own naming patterns for k8s resources. This will result in different naming batters between odo and other tools consuming Devfiles (like Che).

devfile/library currently does not generate the name, as it has no information on the project,  including component name, app name or namespace.
odo needs to pass in the resource name, namespace, label and annotations for it to generate the ObjectMeta, for instance: https://github.com/mik-dass/odo/blob/b2ca2a81a03d076cf1c6d24c3991363d6f1124e4/pkg/occlient/routes.go#L34
We can discuss this issue on cabal call.

Information on how devWorkspace does the route name generation (extracted from notes on Aug. 3 devfile cable call):
The DevWorkspace operator chooses semi-random names for Routes in the format “-, as our requirements are 1) no collisions in a namespace, and 2) we always generate the same name for the same DevWorkspace CR. Routes used for a DevWorkspace managed by the DevWorkspace operator look like, e.g.:
NAME                                     	  HOST/PORT                                	PATH
workspacecf7bfa3acbcc44ee-mini-browser   	  workspacecf7bfa3acbcc44ee.apps-crc.testing   /mini-browser/
workspacecf7bfa3acbcc44ee-terminal       	  workspacecf7bfa3acbcc44ee.apps-crc.testing   /terminal/
workspacecf7bfa3acbcc44ee-theia          	  workspacecf7bfa3acbcc44ee.apps-crc.testing   /theia/
workspacecf7bfa3acbcc44ee-theia-dev      	  workspacecf7bfa3acbcc44ee.apps-crc.testing   /theia-dev/
workspacecf7bfa3acbcc44ee-theia-redirect-1   workspacecf7bfa3acbcc44ee.apps-crc.testing   /theia-redirect-1/
workspacecf7bfa3acbcc44ee-theia-redirect-2   workspacecf7bfa3acbcc44ee.apps-crc.testing   /theia-redirect-2/
workspacecf7bfa3acbcc44ee-theia-redirect-3   workspacecf7bfa3acbcc44ee.apps-crc.testing   /theia-redirect-3/
workspacecf7bfa3acbcc44ee-webviews       	  workspacecf7bfa3acbcc44ee.apps-crc.testing   /webviews/
Note: “workspacecf7bfa3acbcc44ee” is the workspace ID (UID)

It should be possible to use a hash (MD5, etc) to get a value with a constant length (32 characters for MD5), for example url-name + MD5(component-name + app-name)

Sorry to come to this issue late, I'll clarify from the DWO side that we actually have three requirements:

Names are unique and cannot collide, both in URL and in object name
Names are stable and don't change for the life of the DevWorkspace object (e.g. we can't hash the DevWorkspace itself and instead use the UUID on the object)
Length has to be less than 63 chars

The third one is subtle and can be frustrating, as generating URLs from project fields tends to succeed in testing/development (where app name, namespace, and endpoint name are simple) but will randomly fail when e.g. a user attempts to use a namespace that's 30 characters long. From my experience, Kubernetes and OpenShift would previously accept invalid URLs for ingresses/routes, but those endpoints would be inaccessible. It's also a hard issue to debug, as e.g. you might have only 1-2 (out of 5+) routes that are invalid, and it's visually hard to notice that those 1-2 are over 63 chars in the hostname component.
The third requirement makes doing something simple like endpointName-workspaceName-namespace infeasible, even though that would be readable and unique.


Set up pipeline to run on the HPCs

The time to build the pipeline is now too long to build locally (see #50). We should set up and test building the pipeline on the HPCs.

From #59 for @slevin75: Downloading the streamflow took about 90 minutes, then the screening of seasonal and daily flows each took about 45 minutes, the clean daily flows and seasonal flows and the FDC metrics and FDC metrics seasonal took about 20-30 minutes for each of those targets.


Crash on boot

First, thanks for the good work on this repo. Second. I have a crash in
xtensa-lx106-elf-addr2line -f -e build/simple.out 0x402363e7
memchr
/home/gus/dev/esp/rtos/newlib/build/xtensa-lx106-elf/newlib/libc/string/../../../../../newlib/libc/string/memchr.c:133
OR:
xtensa-lx106-elf-addr2line -f -e build/simple.out 0x402363ef
_malloc_usable_size_r
/home/gus/dev/esp/rtos/newlib/build/xtensa-lx106-elf/newlib/libc/stdlib/../../../../../newlib/libc/stdlib/nano-mallocr.c:526
at the boot time.  After 5 to 10 reboots is ok and start to boot correctly.
It is anything to avoid this type of crash.
Also the esp is crashing with no heap. I've monitored all my malloc calls so I am printing every time I am allocating or deallocating something. The null heap is happening after 4 to 5 minutes after I am done with allocating memory. Basically I just stay in a loop waiting for clients.
Wifi Task time:2061 Free Heap size: 16328 sys_now=206056
mem_used=1668 max_mem_used=3480
Wifi Task time:2066 Free Heap size: 16328 sys_now=206566
mem_used=1668 max_mem_used=3480
Wifi Task time:2071 Free Heap size: 16328 sys_now=207076
mem_used=1668 max_mem_used=3480
Wifi Task time:2076 Free Heap size: 16328 sys_now=207586
mem_used=1668 max_mem_used=3480
"@?D??y"@H>@"(stack_size = 0) overflow the heap_size.
==> Every 5 sec I am verifying the connection to WiFi and an memory audit. As you can see the mem_used is constant between calls and no malloc in between (no printfs).
ets Jan  8 2013,rst cause:4, boot mode:(3,6)
wdt reset
load 0x40100000, len 32124, room 16
tail 12
chksum 0x9f
ho 0 tail 12 room 4
load 0x3ffe8000, len 2196, room 12
tail 8
chksum 0x37
load 0x3ffe88a0, len 22468, room 0
This is the log on rebooting:
` ets Jan  8 2013,rst cause:4, boot mode:(3,7)
wdt reset
load 0x40100000, len 32124, room 16
tail 12
chksum 0xf8
ho 0 tail 12 room 4
load 0x3ffe8000, len 2196, room 12
tail 8
chksum 0xd0
load 0x3ffe88a0, len 22468, room 0
tail 4
chksum 0x20
csum 0x20
{gonc#ogbr{o$d`oson'xcc'oc{;g$#sc;#}3fff9bf8, prio:12, stack:200
ESP-Open-SDK ver: 0.0.1 compiled @ Feb 23 2016 13:51:45
phy ver: 273, pp ver: 8.3
data  : 0x3ffe8000 ~ 0x3ffe8894, len: 2196
rodata: 0x3ffe88a0 ~ 0x3ffee064, len: 22468
bss   : 0x3ffee068 ~ 0x3fff6508, len: 33952
heap  : 0x3fff6508 ~ 0x3fffc000, len: 23288
mode : softAP(5e:cf:7f:81:c7:16)
add if1
bcn 100
[simple.c] START WIFI TASK
bcn 0
del if1
usl
sul 0 0
mode : sta(5c:cf:7f:81:c7:16)
add if0
WiFi: Connecting to WiFi
scandone
add 0
aid 4
cnt
connected with guest, channel 1
dhcp client start...
ip:<IP_ADDRESS>,mask:<IP_ADDRESS>,gw:<IP_ADDRESS>
Fatal exception (9):
epc1=0x402363e7
epc2=0x00000000
epc3=0x4022a289
excvaddr=0x888fc20a
depc=0x00000000
excsave1=0x40235abe
ets Jan  8 2013,rst cause:4, boot mode:(3,7)
wdt reset
load 0x40100000, len 32124, room 16
tail 12
chksum 0xf8
ho 0 tail 12 room 4
load 0x3ffe8000, len 2196, room 12
tail 8
chksum 0xd0
load 0x3ffe88a0, len 22468, room 0
tail 4
chksum 0x20
csum 0x20
{on'cc'o#;sodl`osn'gxccgncs{gdcrc{c}3fff9bf8, prio:12, stack:200
ESP-Open-SDK ver: 0.0.1 compiled @ Feb 23 2016 13:51:45
phy ver: 273, pp ver: 8.3
data  : 0x3ffe8000 ~ 0x3ffe8894, len: 2196
rodata: 0x3ffe88a0 ~ 0x3ffee064, len: 22468
bss   : 0x3ffee068 ~ 0x3fff6508, len: 33952
heap  : 0x3fff6508 ~ 0x3fffc000, len: 23288
ets Jan  8 2013,rst cause:4, boot mode:(3,7)
wdt reset
load 0x40100000, len 32124, room 16
tail 12
chksum 0xf8
ho 0 tail 12 room 4
load 0x3ffe8000, len 2196, room 12
tail 8
chksum 0xd0
load 0x3ffe88a0, len 22468, room 0
tail 4
chksum 0x20
csum 0x20
so'gcc'oc{rnll nr'gopbcg'br{olc;c{c}3fff9bf8, prio:12, stack:200
ESP-Open-SDK ver: 0.0.1 compiled @ Feb 23 2016 13:51:45
phy ver: 273, pp ver: 8.3
data  : 0x3ffe8000 ~ 0x3ffe8894, len: 2196
rodata: 0x3ffe88a0 ~ 0x3ffee064, len: 22468
bss   : 0x3ffee068 ~ 0x3fff6508, len: 33952
heap  : 0x3fff6508 ~ 0x3fffc000, len: 23288
mode : softAP(5e:cf:7f:81:c7:16)
add if1
bcn 100
[simple.c] START WIFI TASK
bcn 0
del if1
usl
sul 0 0
mode : sta(5c:cf:7f:81:c7:16)
add if0
WiFi: Connecting to WiFi
scandone
add 0
aid 4
cnt
connected with guest, channel 1
dhcp client start...
ip:<IP_ADDRESS>,mask:<IP_ADDRESS>,gw:<IP_ADDRESS>
Fatal exception (28):
epc1=0x402363e7
epc2=0x00000000
epc3=0x4022a229
excvaddr=0x00000024
depc=0x00000000
excsave1=0x40235abe
ets Jan  8 2013,rst cause:4, boot mode:(3,7)
wdt reset
load 0x40100000, len 32124, room 16
tail 12
chksum 0xf8
ho 0 tail 12 room 4
load 0x3ffe8000, len 2196, room 12
tail 8
chksum 0xd0
load 0x3ffe88a0, len 22468, room 0
tail 4
chksum 0x20
csum 0x20
;goo#bogcs{g$d`g{oo'8c#noc{r'$bs#rb}3fff9bf8, prio:12, stack:200
ESP-Open-SDK ver: 0.0.1 compiled @ Feb 23 2016 13:51:45
phy ver: 273, pp ver: 8.3
data  : 0x3ffe8000 ~ 0x3ffe8894, len: 2196
rodata: 0x3ffe88a0 ~ 0x3ffee064, len: 22468
bss   : 0x3ffee068 ~ 0x3fff6508, len: 33952
heap  : 0x3fff6508 ~ 0x3fffc000, len: 23288
ets Jan  8 2013,rst cause:4, boot mode:(3,7)
wdt reset
load 0x40100000, len 32124, room 16
tail 12
chksum 0xf8
ho 0 tail 12 room 4
load 0x3ffe8000, len 2196, room 12
tail 8
chksum 0xd0
load 0x3ffe88a0, len 22468, room 0
tail 4
chksum 0x20
csum 0x20
son'cc'o#;sndl`nsn'gxbcgncs{odcrc{c}3fff9bf8, prio:12, stack:200
ESP-Open-SDK ver: 0.0.1 compiled @ Feb 23 2016 13:51:45
phy ver: 273, pp ver: 8.3
data  : 0x3ffe8000 ~ 0x3ffe8894, len: 2196
rodata: 0x3ffe88a0 ~ 0x3ffee064, len: 22468
bss   : 0x3ffee068 ~ 0x3fff6508, len: 33952
heap  : 0x3fff6508 ~ 0x3fffc000, len: 23288
mode : softAP(5e:cf:7f:81:c7:16)
add if1
bcn 100
[simple.c] START WIFI TASK
bcn 0
del if1
usl
sul 0 0
mode : sta(5c:cf:7f:81:c7:16)
add if0
WiFi: Connecting to WiFi
scandone
add 0
aid 4
cnt `

Hi,
Thanks for the detailed bug report and crash dumps.

I think the crash at startup may be due to adding printfs to malloc/free. I had some problems with this caused by some mallocs() that happen very early from the binary SDK libraries. If you set a flag from inside user_init() and only printf from malloc/free if the flag is set, the problem may go away.

The 'overflow the heap size' message is copied from Espressif's SDK and it's misleading, we should fix it. It actually means "task stack overflow", the task has overflowed its stack - ie the problem is stack not heap. Fixing this may be as simple as increasing the task stack size passed to xTaskCreate.

Something odd is that the task name "@?D??y"@H>@" printed by the error looks like it's been corrupted, this might be indicative of more serious memory corruption (or it might just be the same stack overflow corrupted it.)

Thanks for the tips. I'll try them.

Is there any new info on this issue? I will close it for now. Feel free to reopen if it is relevant.


How to create multi-value entries for e.g. TEL?

Thanks for improving the documentation about multi-value entries (see #78, #79). When rethinking this, I found a few more places for improvement:
1. How to create multi-value entries
The example from the documentation only shows a simple entry. This is an example for adding a second entry:
>>> import vobject
>>> j = vobject.vCard()
>>> e1 = j.add('email')
>>> j.email.value =<EMAIL_ADDRESS># intentionally using a different way here
>>> e2 = j.add('email')
>>> e2.value =<EMAIL_ADDRESS>>>> e1
<EMAIL_ADDRESS>>>> e2
<EMAIL_ADDRESS>>>> j.email
<EMAIL_ADDRESS>
2. How to determine if an entry is multi-valued?
According to this test, it seems that email entries (and presumable tel etc.) are always lists:
>>> k = vobject.vCard()
>>> k.add('email')
<EMAIL{}>
>>> k.contents['email'].__class__
<class 'list'>

Please documents this and also which entries are lists.

Feel free to make a Pull Request with any changes you think would be helpful.


fix config order in eden gcp

We should not modify config of Eden between setup and CI test to not get the error.
Signed-off-by: Petr Fedchenkov<EMAIL_ADDRESS>

Please run it again, I fixed the problem https://github.com/lf-edge/eden/pull/577

LGTM