Adding additional metadata for fetch requests

The ability to add additional metadata to fetch requests
What problem does this feature solve?
A couple of scenarios I think this would help for

When using GraphQL endpoints it would be useful to add a datapoint that would help to identify what query is being made as currently the tracing doesn't include the body (query)
Being able to identify requests by users who have a flag/AB test enabled

Ideal solution
I haven't given it lots of thought but the first idea that came to mind for me was having a reserved header prefix so any fetch requests can add a header and that is added to the tracing logs. Something like
fetch(url, {
    headers: {
        'x-opentelemetry-keyname': 'value'
    }
});

Alternatives
🤷♂ I am not familiar enough with this software to know if my suggestion would even work so alternatives are a stretch 😄

Thanks @GlynnPhillips. I think we're definitely gonna do this but need to investigate what options we have 👍 I'm moving it into the "planned" column but for anyone picking this up we probably need to discuss as a group before implementing anything.

Ooh this might be easier than we thought code-wise 🙂 the HTTP instrumentation has an option named headersToSpanAttributes (types). This option can be set like this:
getNodeAutoInstrumentations({
    // ...
    '@opentelemetry/instrumentation-http': {
        // ...
        headersToSpanAttributes: {
            client: {
                requestHeaders: [
                    'example-header'
                ],
                responseHeaders: [
                    'example-header'
                ]
            },
            server: {
                requestHeaders: [
                    'example-header'
                ],
                responseHeaders: [
                    'example-header'
                ]
            }
        }
    },
    // ...
})

Maybe we should do some experimenting locally to see if this gives us what we want. Then we could work together to come up with a list of headers that we think would be useful and decide if we want to introduce some custom headers for metadata.

Ohh that looks good. I am happy to help pair on this if you want/need at somepoint

I've had a little go at this to see what the data looks like. The data comes through as a span attribute but not an annotation which is what we'd need to be able to query by these values. Also headers are always sent as an array which might complicate things a little, e.g. the trace span metadata looks like this:
{
    // ...
    "http.response.header.example_server_response": [
        "header-value"
    ],
    // ...
}

The above is the result of setting headersToSpanAttributes.server.responseHeaders to include "example-server-response". You can see an example trace here.
If we want to add actual annotations then I think we might need to either:

Build a custom span processor where we move our captured HTTP headers into annotations
Configure our backend to move the data we need into annotations before sending to XRay (though seems like Adot doesn't support transform processors yet)

@GlynnPhillips is it possible this could be solved better with custom metrics now? E.g have a counter for each type of query along with timings and failure states.


Kobo forms - choosing a new date fails to load data

If a user chooses a WMS layers followed by a kobo layer, then deselects the WMS layer, date selection no longer works on the kobo layer.
Steps to reproduce:

On master, REACT_APP_COUNTRY=cambodia
Activate layer Rainfall amount > Rainfall aggregate 10-day
Activate layer Exposure > Flood report
De-activate rainfall aggregate layer
From the date picker, choose another date. The URL correctly updates, but no request is sent and no data is loaded

All ok through step 3:

This is what I see for the date picker after de-activating the WMS layer (step 4):

After step 5, no data is loaded. Note the URL is correctly updated to Aug 10, but no request is sent (confirmed in the network tool)

cc @ericboucher

Checking this issue, PRISM has an internal cache for storing layer data. If the data for a given date has been previously stored, PRISM will read from the cache instead of making a request to the remote server. This is why the request is not shown in the network tab.
However, some requests take long time and there is no indicator on PRISM to let the user know about this. There is a feeling that nothing is happening in the platform. One possible solution is to include a circular progress, to show that data is loading.

@JorgeMartinezG - this wasn't a time out issue. I waited several minutes and nothing happened consistently.


templateUrl and styleUrl, order, existence, shouldn't matter

var templateUrlRegex = /templateUrl\s*:(\s*['"](.*?)['"]\s*([,}]))/gm;
Only finds templateUrls that end with commas, suggesting two things:
That in cases where styleUrls are listed before templateUrls, and templateUrls are the last line of the component metadata, the templateUrl will not match the regex pattern (https://regex101.com/r/PylCUU/2):
styleUrls: [..],
templateUrl: '...'

And that components with only selectors and templateUrls (namely, no stylesheet), will not match the pattern (https://regex101.com/r/hyzIvz/1) either:
templateUrl: '...'

Which boils down to essentially the same issue regarding the comma that is required for a templateUrl to be matched, and two scenarios in which that might happen.
I know convention is to have templateUrls before styleUrls, but I don't think it's a hard and fast rule. And while I don't personally subscribe to styleUrls before templateUrls, I feel as though the requirement of a comma is overly strict, and the failure to inline those cases goes pretty quietly, leaving people unwilling or unequipped to dig into why this is happening at a loss to solve the problem.
Any chance we can loosen the regex on this pattern? I'd be happy to contribute the change.

The component decorator uses object to configure the component. styleUrls and templateUrl are properties of this object, so comma is not required after the templateUrl if this property is last in the object literal. You can just wrap your examples into '{}' and regExp will parse templateUrl correctly.

Just going to slink away quietly now... nothing to see here.

Ok, so this has been bothering me for awhile now, cause I knew that I was experiencing an issue that my changes had fixed. I was misleading myself about why those changes were working but I just came across the offending code again and I found this:
@Component({
    selector: 'lxk-widget-setup-wizard',
    templateUrl: 'setup-wizard.component.html'/*,
    directives: [Modal, ModalHeader, ModalBody, ModalFooter]*/
})

Obviously, a directives property inside the component decorator is no longer valid, and that's why it had been commented out of this particular code I was looking at, and it was the unexpected /* that was preventing angular2-template-loader from picking up the templateUrl line, since it's neither a , nor a }.


MoveEntityEvent.teleport does not apply to spectator mode teleporting

This issue was originally submitted by @TheCrunchy in SpongePowered/SpongeAPI#1908.

While in spectator mode you can middle click and use the icons to teleport to other people, the MoveEntityEvent.teleport event doesnt listen for this.

@TheCrunchy Can you provide details, e.g. test plugin, what implementations you tested on etc.


Stream ZIP-file directly to browser

Skip temporary zip file on SD-card and start downloading immediately.

Thanks for this. Looks like a nice simplification. I am checking it out and will merge.

Works nicely. Thanks again.


Simplify abstract constructor type assignability checking

This PR simplifies checking of abstract constructor type assignability. The current code is overly convoluted and inefficient and even includes some out of bounds indexing of arrays.

:1+:

Other than my last comment, :+1:


Order detail summary

This PR partially implements the Summary tab of the Order Details overlay. It includes:

the progress bar up top
the Order Details section
the Payment Details section

Includes a stubbed Pay For Order section. When the Purchasing PR is all done and merged, I'll integrate with the full Pay For Order section.

the Order Accepted section

As of now the Fulfill and Refund actions are a no-op.

*** One other note... I don't think this functionality will work properly with Purchases for items set for Local Pickup. I'm not 100% clear what the flow is in that case, so I'll integrate that in a subsequent PR once I understand the details.

On a digital order, I get Ship to counties.NA in the Order Details section. Is that a known issue?

@rmisio the details screen is still throwing a

Error in the console on digital orders, though it no longer blocks the UI from working.

Ignore that close, hit the wrong button when leaving a comment.

should the Cancel link be a different size than the other status texts? It's set to 12px vs. 14px for the status text, because it has a tx6 class on it.

I was following the style of the link below and wanted to be consistent with that. If it shouldn't be like that, I'm sure the big bad wolf can adjust it in his polish work.

when an offline order hasn't been accepted yet, should the Status just have the cancel link in it? Or should it be something like "Pending" with the cancel link after the word Pending?

One thing to consider here is space issues. If we put "Pending" next to the link and the translations of either can too large, then the cancel link might break to a new line and this row will have an inconsistent height relative to the other rows. Not sure how big of a deal that is.

One thing to consider here is space issues. If we put "Pending" next to the link and the translation of either is too large, then the cancel link might break to a new line and this row will have an inconsistent height relative to the other rows. Not sure how big of a deal that is.

Translations should be assumed to occupy more space, if the design doesn't work when the text occupies more lines, we either need to change the design, or accept it looks terrible in some languages.


fixed some ui bugs on filter menu

@amyngai @cynthialee @lkysow @Jareechang Fix some ui bugs in the filter menu (related to #85 )

:+1: some conflict on this one now unfortunately


Misleading example

Challenge http://freecodecamp.com/challenges/waypoint-create-a-block-element-bootstrap-button has an issue. Please describe how to reproduce it, and include links to screenshots if possible.
The example image shows:

What appears to be the block-level button elements class name is depicted as .btn.btn-block  (note the period between 'btn' and 'btn-block'.  Attempting to use this class name for the element fails -- the correct class markup is class = "btn btn-block" (with a space between btn and btn-block).  The example is going to frustrate some beginners.

@MarkHargrove thanks for posting this issue!
 And there is no any conflict! The dots in .btn.btn-block mean this is a CSS selector.
In HTML you add class="btn btn-block" attribute to you element(s) (in this case a button) so now it has both classes btn and btn-block. CSS selecor .btn.btn-block points to a button(s) which has both classes btn and btn-block.
Please see Help I've Found a Bug.

@bugron Is correct. That is the proper way to display multi class selector.
Happy Coding!

I'm not disputing that the class selector is DEFINED correctly.  I'm just noting that a beginner who looks at the example and thinks that 'btn.btn-block' can be used in a "class" markup is going to be surprised that it doesn't work.   I don't recall any previous explanation in an earlier waypoint that shows that the way some selectors are defined doesn't have to exactly matched the way they are invoked.
If I'm the only one to ever mention this, though, maybe there is no such confusion  :-)

Yeah, this confused me at first, too. It didn't take long to figure it out.  Also of note, having the class="btn btn-block" vs. "btn-block" does make it appear different.


Add native memory circuit breaker.

Add native memory circuit breaker.
Refactor all breakers from common to plugin.
Add dynamic setting for native memory circuit breaker.
Signed-off-by: Jing Zhang<EMAIL_ADDRESS>Description
Add native memory circuit breaker.
Refactor all breakers from common to plugin.
Add dynamic setting for native memory circuit breaker.
Issues Resolved
https://github.com/opensearch-project/ml-commons/issues/648
Check List

[ ] New functionality includes testing.

[ ] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #689 (eb03a32) into 2.x (9420c91) will decrease coverage by 0.57%.
The diff coverage is 85.29%.

@@             Coverage Diff              @@
##                2.x     #689      +/-   ##
============================================
- Coverage     83.91%   83.34%   -0.58%
- Complexity     1008     1017       +9
============================================
  Files            93       99       +6
  Lines          3662     3740      +78
  Branches        343      344       +1
============================================
+ Hits           3073     3117      +44
- Misses          444      475      +31
- Partials        145      148       +3

Flag
Coverage Δ

ml-commons
83.34% <85.29%> (-0.58%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...ml/action/load/TransportLoadModelOnNodeAction.java
97.29% <ø> (ø)

.../org/opensearch/ml/breaker/DiskCircuitBreaker.java
36.36% <0.00%> (ø)

...rg/opensearch/ml/breaker/MemoryCircuitBreaker.java
100.00% <ø> (ø)

...opensearch/ml/breaker/ThresholdCircuitBreaker.java
100.00% <ø> (ø)

...n/java/org/opensearch/ml/model/MLModelManager.java
78.20% <ø> (ø)

...va/org/opensearch/ml/task/MLExecuteTaskRunner.java
76.66% <ø> (-6.67%)
:arrow_down:

...va/org/opensearch/ml/task/MLPredictTaskRunner.java
82.14% <ø> (ø)

...main/java/org/opensearch/ml/task/MLTaskRunner.java
97.72% <ø> (ø)

...pensearch/ml/task/MLTrainAndPredictTaskRunner.java
78.26% <ø> (ø)

...a/org/opensearch/ml/task/MLTrainingTaskRunner.java
74.76% <ø> (ø)

... and 17 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

{"error":{"root_cause":[{"type":"illegal_argument_exception","reason":"persistent setting [plugins.ml_commons.native_mem_threshold], not recognized"}],"type":"illegal_argument_exception","reason":"persistent setting [plugins.ml_commons.native_mem_threshold], not recognized"},"status":400}

Sicheng added BWC test, which test from 2.4.0,  in 2.4.0, we don't have the native memory threshold setting


Add support for in-memory compression

Some use cases of this middleware may require the ability to compress content in-memory as either a string or a byte array (Uint8Array).  One example would be when using this library to compress a templated file (eg. read in a file from disk, inject template variables, and then return it compressed).  The way this library is currently implemented, only static content on disk can be compressed, although it's straightforward to support other patterns of delivering the underlying content to the library.
NOTE: I have Deno set up in my VS Code with the Deno Lint settings, which automatically added semicolons and converted apostrophes to quotes, among other formatting changes.  My preference is to use the standard auto-formatting tools provided by a language (and even commit this config to the repo) so that everyone's code is formatted the same.  If this bothers you, I can revert the formatting changes and attempt to make a compatible deno lint configuration that matches this coding style, although I admittedly don't have much experience with deno lint and typically work with prettier and eslint.
PR updated with prettier settings to match project settings

could you please remove deno fmt changes and follow Standard.js / prettier w/o semi and single quote? thx

@talentlessguy  Thanks for the feedback, ready for re-review.  Included a .prettierrc with the appropriate settings and used prettier to format instead of deno fmt.

could you please remove the .prettierrc file?

tests seem to fail still, @lukevp

Tests failed because I'm on Windows with CR/LF line endings on the file, and I used the Windows file sizes in the test cases.  Should really use the unix style for this so I updated the test cases.
Any reason you don't want the .prettierrc file in the project?  It lets new contributors inherit the prettier style you've chosen for the project automatically when using vs code.  I typically put a prettier and eslint config in each project along with a .gitattributes file that forces unix style line endings.  Wanted to get your perspective on this so I understand the reason, but of course I'm
happy to contribute however you prefer as it's your project :)


Issue with /docs/tutorials/stateless-application/run-stateless-application-deployment/

This is a...

[ ] Feature Request
[x ] Bug Report

Problem:
error validating data: couldn't find type: v1beta1.Deployment; if you choose to ignore these errors, turn validation off with --validate=false
when using yaml file provided in "Running a Stateless Applciation" on a K8S cluster on Google Cloud
Proposed Solution:
Page to Update:
https://kubernetes.io/docs/tutorials/stateless-application/run-stateless-application-deployment/

@naseemkullah your kubernetes cluster is probably running an older version v1.5. The examples on the website are updated to reflect the v1.6 which has the Deployment resource in v1beta1/apps API category now.

Thanks Ahmet, client version is 1.6 but I see that server version is indeed
1.5
On Wed, Apr 26, 2017 at 1:15 PM, Ahmet Alp Balkan<EMAIL_ADDRESS>wrote:

@naseemkullah https://github.com/naseemkullah your kubernetes cluster
is probably running an older version v1.5. The examples on the website are
updated to reflect the v1.6 which has the Deployment resource in
v1beta1/apps API category now.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes/kubernetes.github.io/issues/3527#issuecomment-297480344,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AXhJS0XcLnzd3nNSKogLrQHwQxMMHE4mks5rz3vIgaJpZM4NH7mA
.

Marking this issue closed. Thanks!


fix navigation task robot reset logic

There is definitely a cleaner way of doing this, but I am currently just restoring what we have in iG 2 to make it functional for now.

Hi


Add ADAMContext/GenomicRDD/pipe docs

Resolves #1368. Also added latest citation information to the README.

Coverage decreased (-0.2%) to 76.222% when pulling 8eddeb0f8f035ca46e417536e47ae3ad444e14b1 on fnothaft:issues/1368-pipe-markdown into 07c1982fb6fafb959b96d4c3cb83fa7edbe25721 on bigdatagenomics:master.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1836/
Test PASSed.

Addressed reviewer comments and pulled changes in from #1384.

Coverage decreased (-0.2%) to 76.222% when pulling 3f1d34899eba974b2b3e826ffb38ef9316d7f632 on fnothaft:issues/1368-pipe-markdown into 07c1982fb6fafb959b96d4c3cb83fa7edbe25721 on bigdatagenomics:master.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1849/
Test PASSed.

Should I rebase and merge as is or did you want to squash some of the commits first?

Feel free to merge in commits from #1435 here and update 60_building_apps.md with something similar to the changes in commit https://github.com/bigdatagenomics/adam/pull/1433/commits/446ae819d72b5a5a189419ad5d556c2b9c462964.

Hi @heuermh! This should be good to go now. I figured that #1435 and this PR were sufficiently distinct that it made more sense to just merge #1435 into trunk separately. I wanted to pull #1384 into this since we were touching the same section of the document and would conflict otherwise. Anyways, I've got this squashed down as desired.

Coverage decreased (-0.2%) to 76.22% when pulling 6ec6749a562e81f7069f7659443f1179f5e83fc4 on fnothaft:issues/1368-pipe-markdown into 57264bb941f5416a5bfc140d6f7f5753d56e487b on bigdatagenomics:master.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1858/
Test PASSed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1859/Build result: FAILURE[...truncated 16 lines...] > /home/jenkins/git2/bin/git rev-parse origin/pr/1422/merge^{commit} # timeout=10 > /home/jenkins/git2/bin/git branch -a --contains 8933ec928ae71b6fd796e053ba91083c0b56f46a # timeout=10 > /home/jenkins/git2/bin/git rev-parse remotes/origin/pr/1422/merge^{commit} # timeout=10Checking out Revision 8933ec928ae71b6fd796e053ba91083c0b56f46a (origin/pr/1422/merge) > /home/jenkins/git2/bin/git config core.sparsecheckout # timeout=10 > /home/jenkins/git2/bin/git checkout -f 8933ec928ae71b6fd796e053ba91083c0b56f46aFirst time build. Skipping changelog.Triggering ADAM-prb ? 2.3.0,2.11,1.6.1,centosTriggering ADAM-prb ? 2.6.0,2.10,1.6.1,centosTriggering ADAM-prb ? 2.3.0,2.11,2.0.0,centosTriggering ADAM-prb ? 2.3.0,2.10,2.0.0,centosTriggering ADAM-prb ? 2.6.0,2.11,2.0.0,centosTriggering ADAM-prb ? 2.6.0,2.10,2.0.0,centosTriggering ADAM-prb ? 2.3.0,2.10,1.6.1,centosTriggering ADAM-prb ? 2.6.0,2.11,1.6.1,centosADAM-prb ? 2.3.0,2.11,1.6.1,centos completed with result FAILUREADAM-prb ? 2.6.0,2.10,1.6.1,centos completed with result FAILUREADAM-prb ? 2.3.0,2.11,2.0.0,centos completed with result FAILUREADAM-prb ? 2.3.0,2.10,2.0.0,centos completed with result FAILUREADAM-prb ? 2.6.0,2.11,2.0.0,centos completed with result FAILUREADAM-prb ? 2.6.0,2.10,2.0.0,centos completed with result FAILUREADAM-prb ? 2.3.0,2.10,1.6.1,centos completed with result FAILUREADAM-prb ? 2.6.0,2.11,1.6.1,centos completed with result FAILURENotifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'
Test FAILed.

Jenkins, retest this please.

Coverage remained the same at 76.396% when pulling 6ec6749a562e81f7069f7659443f1179f5e83fc4 on fnothaft:issues/1368-pipe-markdown into 57264bb941f5416a5bfc140d6f7f5753d56e487b on bigdatagenomics:master.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1861/
Test PASSed.

Thank you, @fnothaft @devin-petersohn!


Add author to search results listing

Now that users can search for author, it would be good to display that piece of information on the search result listing. That way a user can better understand the relevance of the result for their search. See screenshot to see how it looks like now.

We don't want to change how the Timeline works to add a special case for Search, so I'm going to close this issue.


View Page/Product always gives 500

The pages URL seems to be broken and instead of redirecting to https://shop.ditectrev.com/products/amazon-web-services-certified-aws-certified-cloud-practitioner-clf-c02-practice-tests-exams-questions-answers we should have https://shop.ditectrev.com/product/amazon-web-services-certified-aws-certified-cloud-practitioner-clf-c02-practice-tests-exams-questions-answers. Next, instead of redirecting to https://shop.ditectrev.com/pages/contact we should have https://shop.ditectrev.com/contact. Shocking amount of bugs as for Vercel standards.

Did you follow through https://vercel.com/docs/integrations/cms/shopify?
https://github.com/vercel/commerce/issues/1285#issuecomment-2028752080

Yes, of course.
This repo has lots of routing-related problems.

@vitustockholm knows lots about bugs related to broken routes.


AssemblyScript 0.10.0 breaks build

Hey, I've followed the readme using npm as source for the SDK. But it seems that building the project with Assembly 0.10.0 the project breaks (see error below). When building with 0.9.4 the build does work.
A quick solution might be to change the install command in the readme to:
npm install --save-dev<EMAIL_ADDRESS>λ npx asc assembly/index.ts -b build/untouched.wasm --use abort=abort_proc_exit -t build/untouched.wat --sourceMap --debug
ERROR TS2300: Duplicate identifier '{0}'.

   root_context : AddHeaderRoot;
   ~~~~~~~~~~~~
 in assembly/index.ts(13,3)

   root_context: RootContext;
   ~~~~~~~~~~~~
 in ~lib/@solo-io/proxy-runtime/runtime.ts(916,3)

ERROR TS2300: Duplicate identifier '{0}'.

   metric_id: u32;
   ~~~~~~~~~
 in ~lib/@solo-io/proxy-runtime/runtime.ts(582,3)

   metric_id: u32;
   ~~~~~~~~~
 in ~lib/@solo-io/proxy-runtime/runtime.ts(570,3)

ERROR TS2300: Duplicate identifier '{0}'.

   metric_id: u32;
   ~~~~~~~~~
 in ~lib/@solo-io/proxy-runtime/runtime.ts(597,3)

   metric_id: u32;
   ~~~~~~~~~
 in ~lib/@solo-io/proxy-runtime/runtime.ts(570,3)

ERROR TS2300: Duplicate identifier '{0}'.

   metric_id: u32;
   ~~~~~~~~~
 in ~lib/@solo-io/proxy-runtime/runtime.ts(612,3)

   metric_id: u32;
   ~~~~~~~~~
 in ~lib/@solo-io/proxy-runtime/runtime.ts(570,3)

ERROR TS2322: Type '~lib/string/String | null' is not assignable to type '~lib/string/String'.

     logMessage += message.toString();
                   ~~~~~~~
 in ~lib/@solo-io/proxy-runtime/runtime.ts(15,19)

ERROR TS2322: Type '~lib/string/String | null' is not assignable to type '~lib/string/String'.

     logMessage += " at: " + fileName.toString() + "(" + lineNumber.toString() + ":" + columnNumber.toString() + ")";
                             ~~~~~~~~
 in ~lib/@solo-io/proxy-runtime/runtime.ts(18,29)

good to know - will test this with 0.10

this is an old one; everything should work with latest asm script


Update cannot-set-dataverse-virtual-table-visibility.md

add error code

Microsoft authors of articles need to make updates through the private repository, so the updates can be staged and validated by current validation rules. After you review staging and fix all validation issues, you can add the sign-off comment to let the PR reviewers know the updates are ready to be merged.
It's easy to access the private repo version of your articles in GitHub. Just add -pr to the URL, as follows:
 Public repo URL: https://github.com/MicrosoftDocs/{docs-repo}
 Private repo URL: https://github.com/MicrosoftDocs/{docs-repo-pr}
We have closed this pull request. Please resubmit the updates through the private repo. For more information, see the contributor guide.

Docs Build status updates of commit 05f77cd:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

support/dynamics-365/finance/tax/cannot-set-dataverse-virtual-table-visibility.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Can PlaySound support incoming sound addresses?

The scenario is: I hope that the dynamically generated MP3 file can play sou

Its now possible to use them from any URL so you can have an endpoint that returns the mp3

Great! Now i can hear  my own voice while I generate images :)


OPA gatekeeper: Unable to list Templates and Constraints on dashboard

With the latest master-head, the dashboard view of OPA Gatekeeper is not listing any templates and constraints

Enable OPA Gatekeeper
List the templates and constraints on UI - no data is shown
Using kubectl it is still possible to list the constrainttemplates installed by default

Related: https://github.com/rancher/dashboard/issues/523

This seems to be backend-only issue.
I tested both ways -

by changing the dashboard-index on master setup to use release-2.4 UI index and
changing a v2.4.2 setup to use latest UI index

master setup remains broken and v2.4.2 setup is working fine with either of the ui-index
@ibuildthecloud thinks this issue is possible due to master-head controller framework being rewritten...

This seems to be working fine with latest master-head build.

This looks fixed in the following versions:

Rancher version:

master-head (05/20/2020) b85ea695f
2.4-head (05/20/2020) 8e20687a4 with CATTLE_DASHBOARD_INDEX=https://releases.rancher.com/dashboard/latest/index.html


asprin.py:1:1-222:6: error: python support not available

I was trying to run the examples in the encodings at https://sites.google.com/site/aspseqmining/ijcai-2016.
Everyhting runs fine till the "maximal sequences"
The error is thrown for the "preferences" example

**Error message
asprin.py:1:1-222:6: error: python support not available
*** ERROR: (clingo): fatal error
__________**
Python version in my machine
[manati]s1779550: python
Python 2.7.5 (default, Aug  2 2017, 11:05:32)
[GCC 4.8.5 20150623 (Red Hat 4.8.5-16)] on linux2
Type "help", "copyright", "credits" or "license" for more information.

OS: Scientific Linux

Version of clingo downloaded
[manati]s1779550: ./clingo
clingo version 5.2.1

Command line argument (as below) or while trying to run the command ./asprin 0 -c k=2 instance.lp frequent.lp preference.lp asprin.lib (from the URL https://sites.google.com/site/aspseqmining/ijcai-2016)
[manati]s1779550: ./asprin
asprin version 1.1.1
/afs/inf.ed.ac.uk/user/s17/s1779550/Documents/Himan/Kaj/UoEResearch/MScResearch_09OCT2017/IRDSProject_15OCT2017/Potassco/potassco-asp-executables/asprin.py:1:1-222:6: error: python support not available
*** ERROR: (clingo): fatal error

Asprin requires clingo compiled with python support, which is not included in the Linux binaries we are providing online. You have to compile your own version. Note that clingo cannot be compiled with gcc 4.8 it requires at least gcc 4.9.

I am facing issues with the Clingo-withPython build for Linux.
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
FATAL ERROR

BUILD FAILING DUE TO A MISSING FILE "Python.h" in the "libpyclingo" directory
THE MISSING FILE WAS ABSENT FROM THE DOWNLOADED SOURCE
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Below are the details,
*** Clingo Source ***
[manati]s1779550: cd clingo-5.2.1
[manati]s1779550: ls -ltr
total 46
-rw-r--r--  1 s1779550 people  934 Aug  4 13:11 README.md
-rw-r--r--  1 s1779550 people 1080 Aug  4 13:11 LICENSE.md
drwx------  5 s1779550 people 2048 Aug  4 13:11 libreify
drwx------  2 s1779550 people 2048 Aug  4 13:11 libpyclingo
drwx------  2 s1779550 people 2048 Aug  4 13:11 libluaclingo
drwx------  6 s1779550 people 2048 Aug  4 13:11 libgringo
drwx------  5 s1779550 people 2048 Aug  4 13:11 libclingo
-rw-r--r--  1 s1779550 people 7312 Aug  4 13:11 INSTALL.md
drwx------  7 s1779550 people 2048 Aug  4 13:11 examples
drwx------  3 s1779550 people 2048 Aug  4 13:11 doc
-rw-r--r--  1 s1779550 people 6818 Aug  4 13:11 CMakeLists.txt
drwx------  2 s1779550 people 2048 Aug  4 13:11 cmake
drwx------ 11 s1779550 people 2048 Aug  4 13:11 clasp
-rw-r--r--  1 s1779550 people 7990 Aug  4 13:11 CHANGES.md
drwx------  8 s1779550 people 2048 Aug  4 13:11 app
*** cmake version ***
[manati]s1779550: ./cmake --version
cmake version 3.10.0-rc3
*** Build attempts, messages and observations ***
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
FATAL ERROR										 +
+

BUILD FAILING DUE TO A MISSING FILE "Python.h" in the "libpyclingo" directory		 +
THE MISSING FILE WAS ABSENT FROM THE DOWNLOADED SOURCE 				 +
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

[manati]s1779550: /afs/inf.ed.ac.uk/user/s17/s1779550/Documents/Himan/Kaj/UoEResearch/MScResearch_09OCT2017/IRDSProject_15OCT2017/Potassco/clingo-gringo-clasp-aspirin/cmake-3.10.0-rc3-Linux-x86_64/bin/cmake -Hlibpyclingo -Bbuildhm -DCMAKE_BUILD_TYPE=Release
-- The C compiler identification is GNU 4.8.5
-- The CXX compiler identification is GNU 4.8.5
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /usr/bin/c++
-- Check for working CXX compiler: /usr/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
CMake Warning (dev) in CMakeLists.txt:
No cmake_minimum_required command is present.  A line of code such as
cmake_minimum_required(VERSION 3.10)

should be added at the top of the file.  The version specified may be lower
if you wish to support older CMake versions for this project.  For more
information run "cmake --help-policy CMP0000".
This warning is for project developers.  Use -Wno-dev to suppress it.
-- Configuring done
CMake Warning (dev) at CMakeLists.txt:17 (add_library):
Policy CMP0028 is not set: Double colon in target name means ALIAS or
IMPORTED target.  Run "cmake --help-policy CMP0028" for policy details.
Use the cmake_policy command to set the policy and suppress this warning.
Target "libpyclingo" links to target "Python::Python" but the target was
not found.  Perhaps a find_package() call is missing for an IMPORTED
target, or an ALIAS target is missing?
This warning is for project developers.  Use -Wno-dev to suppress it.
-- Generating done
-- Build files have been written to: /afs/inf.ed.ac.uk/user/s17/s1779550/Documents/Himan/Kaj/UoEResearch/MScResearch_09OCT2017/IRDSProject_15OCT2017/Potassco/clingo-gringo-clasp-aspirin/clingo-5.2.1/buildhm
[manati]s1779550: /afs/inf.ed.ac.uk/user/s17/s1779550/Documents/Himan/Kaj/UoEResearch/MScResearch_09OCT2017/IRDSProject_15OCT2017/Potassco/clingo-gringo-clasp-aspirin/cmake-3.10.0-rc3-Linux-x86_64/bin/cmake --build buildhm/
Scanning dependencies of target libpyclingo
[ 50%] Building CXX object CMakeFiles/libpyclingo.dir/pyclingo.o
/afs/inf.ed.ac.uk/user/s17/s1779550/Documents/Himan/Kaj/UoEResearch/MScResearch_09OCT2017/IRDSProject_15OCT2017/Potassco/clingo-gringo-clasp-aspirin/clingo-5.2.1/libpyclingo/pyclingo.cc:32:20: fatal error: Python.h: No such file or directory
#include <Python.h>
^
compilation terminated.
gmake[2]: *** [CMakeFiles/libpyclingo.dir/pyclingo.o] Error 1
gmake[1]: *** [CMakeFiles/libpyclingo.dir/all] Error 2
gmake: *** [all] Error 2

Hi, there are a couple of issues with the error messages above. Did you modify the CMakeLists.txt? It looks like there is no check for python and I am sure there is a minimum version check in clingo's CMakeLists.txt.
To compile with python support, the python development package has to be installed. Furthermore, you need at least gcc 4.9. The log shows that you have only gcc 4.8. I never used scientific linux but I think you can install centos' software collections, which make it easy to get up to date compilers. Here some links:

https://www.softwarecollections.org/en/scls/rhscl/devtoolset-7/
http://ftp.scientificlinux.org/linux/scientific/6x/external_products/softwarecollections/
http://linux.web.cern.ch/linux/scientific6/docs/softwarecollections.shtml

Of course, if you are not the admin of the system then things get more complicated. While it is certainly possible to compile everything yourself. It might be very involved if you never did this before. Then it probably better to install scientific linux in a virtualbox and install the necessary packages there and then compile clingo.
I can also do this for you but I would need to know exactly which scientific linux you are using and exactly which python version you have installed. You should be able to figure this out using uname and yum. The list and info commands of the the latter can be used to list installed packages and get information about specific packages, respectively.

Hello Rolland ( Correct me if I am wrong)!
Yes, this is the first time I am doing this and I am not the Admin. Currently, this is a University of Edinburgh managed computer.  I would have loved to do this myself to learn and would do that by December, when I would have more time after the semester. But I would first like to use the ASP framework for a quick project and then for my PhD research. I barely have couple days to finish the quick project. So, it would be immensely helpful if you can help with a pre-compiled binary for Scientific Linux.
Following are the information you said you need,
[manati]s1779550: uname -r
3.10.0-693.2.2.el7.x86_64
[manati]s1779550: uname -a
Linux manati.inf.ed.ac.uk 3.10.0-693.2.2.el7.x86_64 #1 SMP Tue Sep 12 10:10:26 CDT 2017 x86_64 x86_64 x86_64 GNU/Linux
[manati]s1779550: lsb_release -a
LSB Version:	:core-4.1-amd64:core-4.1-noarch:cxx-4.1-amd64:cxx-4.1-noarch:desktop-4.1-amd64:desktop-4.1-noarch:languages-4.1-amd64:languages-4.1-noarch:printing-4.1-amd64:printing-4.1-noarch
Distributor ID:	Scientific
Description:	Scientific Linux release 7.3 (Nitrogen)
Release:	7.3
Codename:	Nitrogen
[manati]s1779550: cat /etc/*release
NAME="Scientific Linux"
VERSION="7.3 (Nitrogen)"
ID="rhel"
ID_LIKE="fedora"
VERSION_ID="7.3"
PRETTY_NAME="Scientific Linux 7.3 (Nitrogen)"
ANSI_COLOR="0;31"
CPE_NAME="cpe:/o:scientificlinux:scientificlinux:7.3:GA"
HOME_URL="http://www.scientificlinux.org//"
<EMAIL_ADDRESS>REDHAT_BUGZILLA_PRODUCT="Scientific Linux 7"
REDHAT_BUGZILLA_PRODUCT_VERSION=7.3
REDHAT_SUPPORT_PRODUCT="Scientific Linux"
REDHAT_SUPPORT_PRODUCT_VERSION="7.3"
Scientific Linux release 7.3 (Nitrogen)
Scientific Linux release 7.3 (Nitrogen)
Scientific Linux release 7.3 (Nitrogen)
[manati]s1779550: yum list > yum-list-clingoslinuxcompileissue.txt
Attached file, yum-list-clingoslinuxcompileissue.txt
[manati]s1779550: yum info > yum-info-clingoslinuxcompileissue.txt
Attached file, yum-info-clingoslinuxcompileissue.txt
yum-info-clingoslinuxcompileissue.txt
yum-list-clingoslinuxcompileissue.txt
Feel free to let me know of anything else I can help with.
Last but not the least, many many thanks for your very prompt help.
We are looking forward to use the Potassco framework for an involved longer Term project.
Cheers!
Himan
yum-info-clingoslinuxcompileissue.txt
yum-list-clingoslinuxcompileissue.txt

Dear Himan,
One more thing to take into account is that the experiments of that paper were run using asprin-1,
which runs with clingo-4.5 (with python support). I think they will not work with clingo-5 because of some tiny details.
Recently I released asprin-3 (https://github.com/potassco/asprin) but unfortunately the input syntax has changed a bit, and the experiments of the paper will not work with it. I am planning to update the encodings of the paper to asprin-3 soon, but I haven't done it yet.
Cheers,
Javier

That should be ok for me. I can use clingo-4.5 for now.

Dear Himan,
I've changed the
preference.lp
file, so that if you want now you can use asprin-3 (which is much more stable than asprin-1)
with clingo-5.2.1.
Note that now you do not have to add the file
asprin.lib
This is the output I get:
$ cat preference.lp
#preference(p1,more(cardinality)){
pos(X) & cover(T) : slot(X), seq(T,1,E) }.
#preference(p2,aconf){ hasfreq(F) : freq(F);
cover(T) : seq(T,1,E) }.
#preference(p3,pareto){ **p1; **p2 }.
#optimize(p3).
cont(E,F)  :- item(E),
F = #count{ T : seq(T,P,E) }.
freq(1..M) :- M = #max{ F : cont(E,F) }.
hasfreq(F)   :- cont(E,F), pat(X,E).
hasfreq(F-1) :- hasfreq(F), 1 < F.
#program preference(aconf).
better(P) :- preference(P,aconf),
#sum{ 1,F,T : holds'(atom(hasfreq(F))),
holds (atom(cover(T)));
-1,F,T : holds (atom(hasfreq(F))),
holds'(atom(cover(T))) } > 0.
bettereq(P) :- preference(P,aconf),
#sum{ 1,F,T : holds'(atom(hasfreq(F))),
holds (atom(cover(T)));
-1,F,T : holds (atom(hasfreq(F))),
holds'(atom(cover(T))) } >= 0.
$ asprin 0 -c k=2 instance.lp frequent.lp preference.lp
asprin version 3.0.2
Reading from instance.lp ...
Solving...
Answer: 1
pat(1,a)
Answer: 2
pat(1,c)
OPTIMUM FOUND
Answer: 3
pat(1,b)
OPTIMUM FOUND
Answer: 4
pat(2,b) pat(1,c)
Answer: 5
pat(2,a) pat(1,c)
OPTIMUM FOUND
Answer: 6
pat(2,a) pat(1,b)
OPTIMUM FOUND
Answer: 7
pat(3,a) pat(2,b) pat(1,c)
OPTIMUM FOUND
Answer: 8
pat(1,a)
OPTIMUM FOUND
Answer: 9
pat(2,b) pat(1,c)
OPTIMUM FOUND
Models       : 9
Optimum    : yes
Optimal    : 7
preference.lp.txt
I hope everything runs smoothly now.
Cheers,
Javier

Hi, check the following binaries. I compiled them on SL 7.4 and they even run on our Debian machines. If you want to do this yourself, here is what I did:
# get scl repository from centos
wget http://mirror.centos.org/centos/7/extras/x86_64/Packages/centos-release-scl-2-2.el7.centos.noarch.rpm
wget http://mirror.centos.org/centos/7/extras/x86_64/Packages/centos-release-scl-rh-2-2.el7.centos.noarch.rpm
yum install centos-release-scl-2-2.el7.centos.noarch.rpm centos-release-scl-rh-2-2.el7.centos.noarch.rpm

# add epel repository
yum install yum-conf-epel

# install clingo dependencies
yum update
yum install devtoolset-7-gcc-c++ llvm-toolset-7-cmake scons re2c python-devel

When building clingo make sure to link statically to the clingo and gcc libraries.

Thank you much for all the help.
I guess I am still facing the last bit of issues, after which it all works! - I have a gut feel that I am close, close with all your help.
Now, I have added the clingo Linux binary (shared by ROLLAND), the recent version of aspirin from the Potassco Github, the preference.lp file (fronJavier's posted suggestion above) and all other possible dependencies I could have thought of in the same folder.
I am running to  test the following "preference" code (the recent one),
[manati]s1779550: ./asprin.py 0 -c k=2 instance.lp frequent.lp preference.lp
But gettiing the following error,
[manati]s1779550: ./asprin.py 0 -c k=2 instance.lp frequent.lp preference.lp
Traceback (most recent call last):
File "./asprin.py", line 26, in
import src.main.main
File "/afs/inf.ed.ac.uk/user/s17/s1779550/Documents/Himan/Kaj/UoEResearch/MScResearch_09OCT2017/IRDSProject_15OCT2017/Potassco/potassco-asp-executables/src/main/main.py", line 34, in
import clingo
ImportError: No module named clingo
Below is a list of codes and data files in the folder from which I am running the above command,
[manati]s1779550: ls -ltr
total 16895
-rwxr-xr-x 1 s1779550 people 1420736 Aug  4 12:37 lpconvert
-rwxr-xr-x 1 s1779550 people 1380296 Aug  4 12:37 reify
-rwxr-xr-x 1 s1779550 people 2712928 Aug  4 12:38 clasp
-rwxr-xr-x 1 s1779550 people 5263256 Aug  4 12:38 gringo
-rwxrwxrwx 1 s1779550 people    1572 Oct 11 18:15 setup.py
-rwxrwxrwx 1 s1779550 people    3916 Oct 11 18:15 README.md
-rwxrwxrwx 1 s1779550 people     132 Oct 11 18:15 MANIFEST.in
-rwxrwxrwx 1 s1779550 people    1070 Oct 11 18:15 LICENSE.txt
drwxrwxrwx 4 s1779550 people    2048 Oct 11 18:15 asprin
-rw-r--r-- 1 s1779550 people     433 Oct 29 15:06 frequent.lp
-rw-r--r-- 1 s1779550 people     216 Oct 29 15:06 instance.lp
-rw-r--r-- 1 s1779550 people     417 Oct 29 15:10 closed.lp
-rw-r--r-- 1 s1779550 people     332 Oct 29 15:12 maximal.lp
-rwxr-xr-x 1 s1779550 people 6446072 Nov  1 12:10 clingo
-rw-r--r-- 1 s1779550 people     867 Nov  1 15:29 preference.lp
-rwxr-xr-x 1 s1779550 people    1405 Nov  1 15:47 init.py
-rwxr-xr-x 1 s1779550 people    1325 Nov  1 15:47 asprin.py
-rwxr-xr-x 1 s1779550 people   53119 Nov  1 15:47 asprin_lib.lp
drwxrwxrwx 8 s1779550 people    2048 Nov  1 15:50 src
Once again, the "clingo" is the Scientific Linux binary, preference.lp is the recent one downloaded from Javier's note above, aspirin.py is the recent version of the aspirin from the Potassco Github.
Lemme know - am I missing anything?
Thanks in advance.
Himan

Hi, I did not know that asprin is using the clingo python module because I just uploaded clingo binaries. Here is also the clingo python module. You have to extract it somewhere and point the PYTHONPATH environment variable to its location.

Thanks. Where would I find the PYTHONPATH var?

Where would I find the PYTHONPATH var?
You have two options here. Put clingo.so somewhere where python will find it, e.g., your user site:

mkdir -p ~/.local/lib/python2.7/site-packages
cp clingo.so ~/.local/lib/python2.7/site-packages

Or before running asprin set the PYTHONPATH environment variable:
export PYTHONPATH=<path to folder containing clingo.so>

Thanks a ton, Rolland and Javier. The "Preferences encoding" works now in my Machine and system.
I am glad that I can use the ASP framework for my project(s).
Cheers!
Himan

Great it worked out! Closing the issue then.


Could not find a declaration file for module '@testing-library/jasmine-dom/dist' on Angular 12 project

jasmine-dom version: 1.0.3
node version: 14.15.4
npm version: 6.14.10
@angular/core version: 12.2.9
typescript version: 4.3.2
jasmine-core version: 3.8.0

Relevant code or config:
tsconfig.spec.json:
/* To learn more about this file see: https://angular.io/config/tsconfig. */
{
  "extends": "./tsconfig.json",
  "compilerOptions": {
    "outDir": "./out-tsc/spec",
    "types": ["jasmine", "@testing-library/jasmine-dom"]
  },
  "files": ["src/test.ts", "src/polyfills.ts"],
  "include": ["src/**/*.spec.ts", "src/**/*.d.ts"]
}

test.ts:
// This file is required by karma.conf.js and loads recursively all the .spec and framework files

import 'zone.js/testing';
import { getTestBed } from '@angular/core/testing';
import {
  BrowserDynamicTestingModule,
  platformBrowserDynamicTesting,
} from '@angular/platform-browser-dynamic/testing';

import JasmineDOM from '@testing-library/jasmine-dom/dist';

declare const require: {
  context(
    path: string,
    deep?: boolean,
    filter?: RegExp
  ): {
    keys(): string[];
    <T>(id: string): T;
  };
};

// First, initialize the Angular testing environment.
getTestBed().initTestEnvironment(BrowserDynamicTestingModule, platformBrowserDynamicTesting());
// Then we find all the tests.
const context = require.context('./', true, /\.spec\.ts$/);
// And load the modules.
context.keys().map(context);

beforeAll(() => {
  // On the Jasmine version I'm using the addMatches method is directly on the jasmine variable instead of having to call .getEnv()
  jasmine.addMatchers(JasmineDOM);
});

What you did:
Tried to run the tests:
npm run-script test

After the error happened, installed the types package as suggested in the error message, but the same error occurred:
npm run-script testnpm i --save-dev @types/testing-library__jasmine-dom

What happened:
Error: src/test.ts:10:24 - error TS7016: Could not find a declaration file for module '@testing-library/jasmine-dom/dist'. 'C:/some-path/angular/node_modules/@testing-library
/jasmine-dom/dist/index.js' implicitly has an 'any' type.
  Try `npm i --save-dev @types/testing-library__jasmine-dom` if it exists or add a new declaration (.d.ts) file containing `declare module '@testing-library/jasmine-dom/dist';`

10 import JasmineDOM from '@testing-library/jasmine-dom/dist';

Problem description:
I couldn't make it work on an Angular 12 project by following the TypeScript instructions on the README file.
Please note that on tests.ts I had to call jasmine.addMatchers(JasmineDOM); without .getEnv() as it was suggested in the README. Anyway the error happens before this line.
I also took a look at this other related issue, but couldn't find anything that could solve this.
Is there any additional configuration I need to make this work?
Thanks in advance for the support and for providing this helpful library!

It works fine if @ts-ignore is added.
// @ts-ignore - See https://github.com/testing-library/jasmine-dom/issues/40
import JasmineDOM from '@testing-library/jasmine-dom/dist';

Not sure if it can be related to the library being @testing-library/jasmine-dom/dist having a /dist in the end, and the associated @types package not having it (@types/testing-library__jasmine-dom).

Hi, I'm the maintainer of the Angular Testing Library.
I've included a karma example that can be found at https://github.com/testing-library/angular-testing-library/blob/main/apps/example-app-karma/src/test.ts

Hi, I'm the maintainer of the Angular Testing Library. I've included a karma example that can be found at https://github.com/testing-library/angular-testing-library/blob/main/apps/example-app-karma/src/test.ts

I tried with the same tests.ts as on this sample and got this error:
TypeError: expect(...).toHaveTextContent is not a function

Don't you have to add the matchers, as stated on the instructions below?
https://github.com/testing-library/jasmine-dom#with-typescript
beforeAll(() => {
	jasmine.getEnv().addMatchers(JasmineDOM);
});

Thanks.

@marcioggs somehow I'm not required to do that 🤔
Did you verify we're using the same versions?
If you can reproduce it in a project, we could take a look at it.

We're using the same versions.
From my package.json:
"@testing-library/angular": "^10.11.1",
"@testing-library/dom": "^8.11.1",
"@testing-library/jasmine-dom": "^1.2.0",
"@types/jasmine": "~3.10.2",
"jasmine-core": "~3.10.1",
"karma": "^6.3.9",
"karma-chrome-launcher": "~3.1.0",
"karma-jasmine": "~4.0.1",
"karma-jasmine-html-reporter": "~1.7.0",

Thanks for the support, @timdeschryver .
I'll check for clues on the rest of your project files and will let you know if I find something.

I have the same issue. Any updates on this? @marcioggs did you find a fix?

Ok, to fix this I had to import jasmine-dom twice like the following and it fixed my error in the terminal and the Eslint error:
import "zone.js/dist/long-stack-trace-zone";
import "zone.js/dist/proxy.js";
import "zone.js/dist/sync-test";
import "zone.js/dist/jasmine-patch";
import "zone.js/dist/async-test";
import "zone.js/dist/fake-async-test";
import { getTestBed } from "@angular/core/testing";
import {
    BrowserDynamicTestingModule,
    platformBrowserDynamicTesting,
} from "@angular/platform-browser-dynamic/testing";

import "@testing-library/jasmine-dom"; // <---- Fixed the lint error: Property 'toBeInTheDocument' does not exist on type 'Matchers<HTMLElement>'.
import JasmineDOM from "@testing-library/jasmine-dom/dist"; // <---- fixed the terminal error: "TypeError: expect(...).toBeInTheDocument is not a function"

declare const require: {
    context(
        path: string,
        deep?: boolean,
        filter?: RegExp
    ): {
        <T>(id: string): T;
        keys(): string[];
    };
};

// First, initialize the Angular testing environment.
getTestBed().initTestEnvironment(BrowserDynamicTestingModule, platformBrowserDynamicTesting());
// Then we find all the tests.
const context = require.context("./", true, /\.spec\.ts$/);
// And load the modules.
context.keys().map(context);

beforeAll(() => {
    // On the Jasmine version I'm using the addMatches method is directly on the jasmine variable instead of having to call .getEnv()
    jasmine.addMatchers(JasmineDOM);
});

I have the same issue. Any updates on this? @marcioggs did you find a fix?

No, I still have the workaround described in the first comment.

For me (Angular 15, typescript 4.8.4) I needed to import the types explicitly in my tsconfig.spec.json:
    "types": [
      "jasmine",
      "node",
      // "@testing-library/jasmine-dom",
      "@types/testing-library__jasmine-dom"
    ]

Ah, but then later I'd enabled noImplicitAny in my tsconfig and things stopped working.
My current solution for that is to have "noImplicitAny": true in the main app tsconfig, and override it to false in tsconfig.spec.json.

@sdarnell I use at work these types with strict at work and they work fine. I don't use Angular, can't check for the issue

For me (Angular 15, typescript 4.8.4) I needed to import the types explicitly in my tsconfig.spec.json:
    "types": [
      "jasmine",
      "node",
      // "@testing-library/jasmine-dom",
      "@types/testing-library__jasmine-dom"
    ]

To add on to this, installing the types helped and then doing a tsignore on the import in test.ts part with the extending of the matchers did it for me. Doesn't look like jasmine dom ships with types

For me, freshly new created Angular 16.2.x with Typescript 5.1.x, this is what worked:

Install the dev dependency

npm install --save-dev @testing-library/jasmine-dom

Install the types as well (step missing in README), or typescript will complain later

npm install --save-dev @types/testing-library__jasmine-dom

Create a src/test.ts file in order to load the matchers (slightly different code than the one in the README), typically this file would have been generated by Angular (in the previous versions) and we would just modify the content, but this is not the case anymore

// @ts-ignore
import JasmineDOM from '@testing-library/jasmine-dom';

beforeAll(() => {
  jasmine.addMatchers(JasmineDOM);
});

Update the tsconfig.spec.json in order to load the types and the test.ts file

{
  "extends": "./tsconfig.json",
  "compilerOptions": {
    "outDir": "./out-tsc/spec",
    "types": [
      "jasmine",
      "node",
      // include the types
      "@testing-library/jasmine-dom"
    ]
  },
  // include the test entry point
  "files": ["src/test.ts"],
  "include": [
    "src/**/*.spec.ts",
    "src/**/*.d.ts"
  ]
}

update the angular.json file overriding the include parameters, since the test.ts is not generated anymore by Angular it won't be automatically included. Additionally because we are overriding the include option we also need to explicitly provide the spec or other test files.

{
  "$schema"<EMAIL_ADDRESS>  "version": 1,
  "newProjectRoot": "projects",
  "projects": {
    "your-project-name": {
      // other stuff
      "architect": {
        // other stuff
        "test": {
          "builder": "@angular-devkit/build-angular:karma",
          "options": {
            // override the include by specifying the test.ts and all other needed files
            "include": [
              "src/test.ts",
              "src/**/*.spec.ts",
              "src/**/*.d.ts"
            ],
            // other stuff
          }
        }
      }
    }
  }
}

Hope this helps.

This issue should be fixed when using @types/testing-library__jasmine-dom >= 1.3.4


[AutoRelease] t2-devopsinfrastructure-2024-05-20-81384(can only be merged by SDK owner)

https://github.com/Azure/sdk-release-request/issues/5140
Live test success

issue link:https://github.com/Azure/sdk-release-request/issues/5140

/azp run prepare-pipelines

/check-enforcer override


Migrate from flow to typescript

I originally chose flow over typescript because it allows putting type definitions in comments and as such doesn't require a separate compilation step. Unfortunately flow has several limitations including not supporting bigints and some incorrect builtin type declarations. As such I think using typescript is better in the long term.

@dicej What tool would you recommend for stripping type declarations from typescript files to make them valid javascript files? I know there are a whole lot of them. Too many IMHO.

Honestly it's been a while since I did anything serious in either TS or JS, so my knowledge may be out-of-date.  Last time I worked on a TS project, we just used the official tsc compiler from the typescript NPM package.  You'd need to use that anyway to actually do type checking, and it will produce a JS file for each TS file you give it.

I see. Unfortunately tsc is way too slow. My editor already does typechecking and having to wait 7 seconds after any change before I can refresh the page is way too much.

Fair enough.  The "Working with TypeScript-compatible transpilers" section of https://www.typescriptlang.org/download might be helpful.  I don't have any experience with anything but tsc, unfortunately.

The concern about slowness is fair from an internal perspective, but externally I'm not sure if there is any typing info you can get from this library. If you don't want to do a re-write in TS, I could contribute some type definition files. Or perhaps there is a way to generate d.ts files from flow annotated code.

I'm open to having typescript type definitions for the public api. I don't expect there is a way to generate typescript type definitions from flow annotated code, but I'm happy to be proven wrong.

My concern with definition files is just the maintenance burden. I don't think there is an automated way to check that it's drifting. But if the public API remains small, then it might not be that much concern. I'll look into it.


CLI Suggests Taobao Registry but It Is a Lot Slower

Version
4.5.8
Environment info
Environment Info:

  System:
    OS: macOS Mojave 10.14.4
    CPU: (4) x64 Intel(R) Core(TM) i7-4650U CPU @ 1.70GHz
  Binaries:
    Node: 15.0.0 - ~/.nvm/versions/node/v15.0.0/bin/node
    Yarn: 1.22.4 - /usr/local/bin/yarn
    npm: 7.0.2 - ~/.nvm/versions/node/v15.0.0/bin/npm
  Browsers:
    Chrome: 86.0.4240.111
    Edge: Not Found
    Firefox: 78.0.1
    Safari: 12.1
  npmGlobalPackages:
    @vue/cli: Not Found

---

Current registry: https://registry.yarnpkg.com

Steps to reproduce
I don’t know how to reproduce this exactly, unfortunately.
What is expected?
The CLI only suggests another registry if it’s significantly better than the current registry.
What is actually happening?
The CLI suggests https://registry.npm.taobao.org which has a response time of 15-45-times the current registry’s response time.

Example output of testing the response time with curl. I reproduced this multiple times.
kev@KevsMacBook ~ $ curl -w<EMAIL_ADDRESS>-o /dev/null -s https://registry.npm.taobao.org/siegegg-api
    time_namelookup:  0.266313
       time_connect:  0.313511
    time_appconnect:  0.411322
   time_pretransfer:  0.411606
      time_redirect:  0.000000
 time_starttransfer:  15.695086
                    ----------
         time_total:  15.695307
kev@KevsMacBook ~ $ curl -w<EMAIL_ADDRESS>-o /dev/null -s https://registry.npmjs.org/siegegg-api
    time_namelookup:  0.029874
       time_connect:  0.073676
    time_appconnect:  0.200626
   time_pretransfer:  0.200845
      time_redirect:  0.000000
 time_starttransfer:  1.160862
                    ----------
         time_total:  1.162009
kev@KevsMacBook ~ $ curl -w<EMAIL_ADDRESS>-o /dev/null -s https://registry.yarnpkg.com/siegegg-api
    time_namelookup:  0.004120
       time_connect:  0.065280
    time_appconnect:  0.243338
   time_pretransfer:  0.243497
      time_redirect:  0.000000
 time_starttransfer:  0.351197
                    ----------
         time_total:  0.356865

Could you test this code which is used by CLI? Does it always return taobao registry?

@fangbinwei, it doesn't always return the taobao registry. Looks like the 15s yesterday were pretty random. :thinking:

I've modified the script to show the time for both requests. It also checks more than one package because I think this might not be a bug inside vue cli.

First time `node main.js`

Using vue-cli-version-marker
https://registry.yarnpkg.com: 541.241ms
https://registry.npm.taobao.org: 558.983ms
Using siegegg-api
https://registry.yarnpkg.com: 418.443ms
https://registry.npm.taobao.org: 1851.088ms
Using express
https://registry.yarnpkg.com: 408.303ms
https://registry.npm.taobao.org: 1738.040ms
Using request
https://registry.yarnpkg.com: 406.914ms
https://registry.npm.taobao.org: 1123.147ms
Using ts-node
https://registry.yarnpkg.com: 409.492ms
https://registry.npm.taobao.org: 430.789ms
Using axios
https://registry.yarnpkg.com: 385.833ms
https://registry.npm.taobao.org: 1614.157ms
Using bootstrap
https://registry.yarnpkg.com: 411.516ms
https://registry.npm.taobao.org: 1024.958ms
Using jquery
https://registry.yarnpkg.com: 406.809ms
https://registry.npm.taobao.org: 1967.655ms

Second time `node main.js`

Using vue-cli-version-marker
https://registry.npm.taobao.org: 256.945ms
https://registry.yarnpkg.com: 468.953ms
Using siegegg-api
https://registry.npm.taobao.org: 156.621ms
https://registry.yarnpkg.com: 399.340ms
Using express
https://registry.npm.taobao.org: 227.382ms
https://registry.yarnpkg.com: 366.645ms
Using request
https://registry.npm.taobao.org: 159.970ms
https://registry.yarnpkg.com: 357.367ms
Using ts-node
https://registry.npm.taobao.org: 102.781ms
https://registry.yarnpkg.com: 404.320ms
Using axios
https://registry.npm.taobao.org: 130.075ms
https://registry.yarnpkg.com: 406.246ms
Using bootstrap
https://registry.npm.taobao.org: 307.449ms
https://registry.yarnpkg.com: 351.657ms
Using jquery
https://registry.npm.taobao.org: 215.520ms
https://registry.yarnpkg.com: 342.015ms

It appears that Taobao's registry is slower for initial requests but faster for subsequent requests (caching?). So that's why I think it's not a bug in Vue CLI, as the Taobao registry is faster after the first initial much slower request. From my side, I'd close the issue, it's probably just weird behavior by the registries and the Taobao one appears to be actually faster except for the first request which confused me. :sweat_smile:

This feature is friendly to China users, sine taobao registry is always faster than other registries. For other areas with fast internet, it’s hard to say which registry is faster 😢

Yeah, that's great for Chinese users to have a faster option. I'm wondering how reliable it would be to test via ping instead of requests?

Ping for Yarn Registry (from Germany) IPv4

PING yarn.npmjs.org (<IP_ADDRESS>) 56(84) bytes of data.
64 bytes from <IP_ADDRESS> (<IP_ADDRESS>): icmp_seq=1 ttl=58 time=28.6 ms
64 bytes from <IP_ADDRESS> (<IP_ADDRESS>): icmp_seq=2 ttl=58 time=33.1 ms
64 bytes from <IP_ADDRESS> (<IP_ADDRESS>): icmp_seq=3 ttl=58 time=29.3 ms
64 bytes from <IP_ADDRESS> (<IP_ADDRESS>): icmp_seq=4 ttl=58 time=65.4 ms
64 bytes from <IP_ADDRESS> (<IP_ADDRESS>): icmp_seq=5 ttl=58 time=28.8 ms
64 bytes from <IP_ADDRESS> (<IP_ADDRESS>): icmp_seq=6 ttl=58 time=29.6 ms
64 bytes from <IP_ADDRESS> (<IP_ADDRESS>): icmp_seq=7 ttl=58 time=28.5 ms
64 bytes from <IP_ADDRESS> (<IP_ADDRESS>): icmp_seq=8 ttl=58 time=30.3 ms
64 bytes from <IP_ADDRESS> (<IP_ADDRESS>): icmp_seq=9 ttl=58 time=29.6 ms
64 bytes from <IP_ADDRESS> (<IP_ADDRESS>): icmp_seq=10 ttl=58 time=32.3 ms
--- yarn.npmjs.org ping statistics ---
10 packets transmitted, 10 received, 0% packet loss, time 9015ms
rtt min/avg/max/mdev = 28.575/33.604/65.499/10.732 ms

Ping for Taobao Registry (from Germany) IPv4
PING registry.npm.taobao.org.w.cdngslb.com (<IP_ADDRESS>) 56(84) bytes of data.
64 bytes from <IP_ADDRESS> (<IP_ADDRESS>): icmp_seq=1 ttl=55 time=72.7 ms
64 bytes from <IP_ADDRESS> (<IP_ADDRESS>): icmp_seq=2 ttl=55 time=76.1 ms
64 bytes from <IP_ADDRESS> (<IP_ADDRESS>): icmp_seq=3 ttl=55 time=76.5 ms
64 bytes from <IP_ADDRESS> (<IP_ADDRESS>): icmp_seq=4 ttl=55 time=82.2 ms
64 bytes from <IP_ADDRESS> (<IP_ADDRESS>): icmp_seq=5 ttl=55 time=67.0 ms
64 bytes from <IP_ADDRESS> (<IP_ADDRESS>): icmp_seq=6 ttl=55 time=76.0 ms
64 bytes from <IP_ADDRESS> (<IP_ADDRESS>): icmp_seq=7 ttl=55 time=70.8 ms
64 bytes from <IP_ADDRESS> (<IP_ADDRESS>): icmp_seq=8 ttl=55 time=75.7 ms
64 bytes from <IP_ADDRESS> (<IP_ADDRESS>): icmp_seq=9 ttl=55 time=80.6 ms
64 bytes from <IP_ADDRESS> (<IP_ADDRESS>): icmp_seq=10 ttl=55 time=71.2 ms
--- registry.npm.taobao.org.w.cdngslb.com ping statistics ---
10 packets transmitted, 10 received, 0% packet loss, time 9013ms
rtt min/avg/max/mdev = 67.054/74.936/82.266/4.362 ms

IPv6 is even faster than IPv4 for yarn, so I forced IPv4 so it's the same version.

Hello,
I opted for the switch but I don't know if that is the cause. But when I run vue create command, it always times out for me. I can't even get started with a project. Below is the screenshot of the timeout.
Can you please tell me how to switch out of taobao registry?

First you can check yarn config get registry
then, you can check  useTaobaoRegistry  in the config .vuerc, maybe is located C:/User/your_name/
.vuerc
{
  "packageManager": "yarn",
  "useTaobaoRegistry": false
}

@gopinav

Yeah deleted the .vuerc file from %USERPROIFLE% and FINALLY after half a day, I have a project running. I really don't think the suggestion should be made to use taobao registry. Thanks for your help.

See also https://github.com/vuejs/vue-cli/issues/5261
Yeah, the test implementation is not that reliable.

First you can check yarn config get registry
then, you can check useTaobaoRegistry  in the config .vuerc, maybe is located on C:/User/your_name/
.vuerc
{
  "packageManager": "yarn",
  "useTaobaoRegistry": false
}

@gopinav

Thanks it helps me ! It was exactly that I was looking for :)

Wow, this surprised me—first time using the vue cli.  The solution provided by fangbinwei worked for me.  Thank you!


add support for enew tabs in :ZkNew

Pretty much what it says on the tin- I'd like to be able to use the plugin to create new tabs when I make a new note, rather than horizontally splitting my existing buffer.

Hey!
Thanks for the issue.
I just pushed 8f733407446c89000a97fe157946b1823432a703 that changes :ZkNew so it accepts |.
You can now just use tabnew | ZkNew | only or any combination you prefer to change the way a new note is created.


showDatePicker overflow in small screen

Steps to Reproduce

Use a small screen emulator like - Nexus S (460 x 800)
Run flutter_gallery app and run Picker demo
Pick date has overflow error

Logs
I/zygote  (23274): Do partial code cache collection, code=30KB, data=26KB
I/zygote  (23274): After code cache collection, code=30KB, data=26KB
I/zygote  (23274): Increasing code cache capacity to 128KB
I/flutter (23274): ══╡ EXCEPTION CAUGHT BY RENDERING LIBRARY ╞═════════════════════════════════════════════════════════
I/flutter (23274): The following message was thrown during layout:
I/flutter (23274): A RenderFlex overflowed by 39 pixels on the bottom.
I/flutter (23274):
I/flutter (23274): The overflowing RenderFlex has an orientation of Axis.vertical.
I/flutter (23274): The edge of the RenderFlex that is overflowing has been marked in the rendering with a yellow and
I/flutter (23274): black striped pattern. This is usually caused by the contents being too big for the RenderFlex.
I/flutter (23274): Consider applying a flex factor (e.g. using an Expanded widget) to force the children of the
I/flutter (23274): RenderFlex to fit within the available space instead of being sized to their natural size.
I/flutter (23274): This is considered an error condition because it indicates that there is content that cannot be
I/flutter (23274): seen. If the content is legitimately bigger than the available space, consider clipping it with a
I/flutter (23274): ClipRect widget before putting it in the flex, or using a scrollable container rather than a Flex,
I/flutter (23274): like a ListView.
I/flutter (23274): The specific RenderFlex in question is:
I/flutter (23274):   RenderFlex#21475 relayoutBoundary=up7 OVERFLOWING
I/flutter (23274):   creator: Column ← SizedBox ← LayoutBuilder ← OrientationBuilder ← DefaultTextStyle ←
I/flutter (23274):   AnimatedDefaultTextStyle ← _InkFeatures-[GlobalKey#e781f ink renderer] ←
I/flutter (23274):   NotificationListener<LayoutChangedNotification> ← CustomPaint ← _ShapeBorderPaint ← PhysicalShape
I/flutter (23274):   ← _MaterialInterior ← ⋯
I/flutter (23274):   parentData: <none> (can use size)
I/flutter (23274):   constraints: BoxConstraints(w=240.0, 0.0<=h<=461.3)
I/flutter (23274):   size: Size(240.0, 461.3)
I/flutter (23274):   direction: vertical
I/flutter (23274):   mainAxisAlignment: start
I/flutter (23274):   mainAxisSize: min
I/flutter (23274):   crossAxisAlignment: stretch
I/flutter (23274):   verticalDirection: down
I/flutter (23274): ◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤◢◤
I/flutter (23274): ════════════════════════════════════════════════════════════════════════════════════════════════════

Analyzer
[√] Flutter (Channel beta, v0.11.13, on Microsoft Windows [Version 10.0.17134.376], locale en-SG)
    • Flutter version 0.11.13 at C:\app\flutter
    • Framework revision 58c8489fcd (2 days ago), 2018-11-29 19:20:18 -0500
    • Engine revision 7375a0f414
    • Dart version 2.1.0 (build 2.1.0-dev.9.4 f9ebf21297)

[√] Android toolchain - develop for Android devices (Android SDK 28.0.3)
    • Android SDK at C:\Users\k\AppData\Local\Android\sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-28, build-tools 28.0.3
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1136-b06)
    • All Android licenses accepted.

[√] Android Studio (version 3.2)
    • Android Studio at C:\Program Files\Android\Android Studio
    X Flutter plugin not installed; this adds Flutter specific functionality.
    X Dart plugin not installed; this adds Dart specific functionality.
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1136-b06)

[√] IntelliJ IDEA Ultimate Edition (version 2018.2)
    • IntelliJ at C:\Program Files\JetBrains\IntelliJ IDEA 2018.2.5
    • Flutter plugin version 30.0.2
    • Dart plugin version 182.5124

[!] VS Code (version 1.29.1)
    • VS Code at C:\Users\k\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension not installed; install from
      https://marketplace.visualstudio.com/items?itemName=Dart-Code.flutter

[√] Connected device (1 available)
    • Android SDK built for x86 • emulator-5554 • android-x86 • Android 8.1.0 (API 27) (emulator)

! Doctor found issues in 1 category.

Merging with #21383


Optional query is assigned "undefined" string

findMany api has a optional query 'page'.
but if page is undefined, url is written as "/products?page=undefined". and this query value is string "undefined".
i think, "/products?" or "/products" is right.
(so i think, undefined type should be handled separately.)
In Korea,
findMany api를 구현했습니다. page는 optional한 쿼리입니다. sdk를 통해 findMany(connection)를 실행하면 undefined가 문자열 "undefined"로 전달되는 버그가 있습니다. ( ex) "/products?page=undefined" )
이는 URLSearchParams의 처리 방식 때문인 것 같습니다. 제 생각에는 undefined값은 키조차 UrlSearchParams 객체 생성 인자로 전달되지 않아야 할 것 같습니다. ( ex) "/products?", "/products" )
// This is nestia sdk.
export namespace findMany
{
    export type Output = PaginatedResponse<ProductSchema.General>;

    export const METHOD = "GET" as const;
    export const PATH: string = "/products";
    export const ENCRYPTED: Fetcher.IEncrypted = {
        request: false,
        response: false,
    };

    export function path(page: number | undefined): string
    {
        return `/products?${new URLSearchParams(
        {
            page
        } as any).toString()}`;
    }
}

Upgrade to<EMAIL_ADDRESS>then would be fixed.

now @nestia/sdk 1.0.12, sdk path function logic is changed, but same bug still happens.

@industriously Show me your code.

Thanks for detailed reporting.
I haven't known about the URLSearchParams, as I've not used query parameters at all.
Now, update to<EMAIL_ADDRESS>then everything would be fine.


changed login link to login/sign up

Before, login link on front page said "login". But that's also the link to create a new profile, so to clarify its purpose to new users, I changed it to say "login / sign up"


RDKB-55020:ihc_resolve_domain_name is failed if NTPServer1 is changed

Reason for change: Device.Time.NTPServer1/2 have value with single qoutes while setting as "value". Test Procedure:
1.)Test the DML Device.Time.NTPServer1/2
Risks: High
Priority: P1
Signed-off-by: kulvendra singh<EMAIL_ADDRESS>

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Fix msrv: Run msrv checks with minimal versions

Since it is possible to for dependencies to bump MSRV in patch release, msrv checking should use the minimal versions supported by flate2.
Users cares deeply about msrv can also pin them to the minimal versions to maintain their current msrv.
This would have also help discover bugs in #424

Oh, right:
Run cargo build --features zlib-rs --no-default-features
 Downloading crates ...
  Downloaded libz-rs-sys v0.2.1
  Downloaded zlib-rs v0.2.1
error: package `zlib-rs v0.2.1` cannot be built because it requires rustc 1.75 or newer, while the currently active rustc version is 1.56.1

The MSRV is only valid for the C bindings, not for zlib-rs. Maybe this could also be clarified. For now, I think it's OK to remove zlib-rs from the set of tested deps, or add something separate with its own MSRV.

Thanks removed it

It can finally reproduce the error 🎉

Let me put my commit in and bump the crate version…

I disagree here. The MSRV causes users with compiler versions earlier than the MSRV to see failures to download a recent version of flate2 that works for them. Users with version 1.56.1 can currently download the most recent version of flate2 and use it with the default features.
Increasing the rust-version will cause problems for them. Yes, they will have problems if they enable any of the other features. But they can deal with that by not using those features or upgrading their compiler.

Thanks for chiming in!
This makes sense and I have undone the change to the rust-version field, and updated the commit message accordingly.
@NobodyXu Could you provide another one of these PRs for the libz-sys crate? It seems it's unknowingly using features of more recent vcpkg versions.

To clarify some more, the problem with rust-version is that there are multiple things it could mean:

Any compiler version lower than rust-version will fail to build the flate2 code, probably due to flate2 use of a feature added to the compiler.
Any compiler version lower than rust-version will fail to build flate2 and its dependencies. This may be different depending on features (and their differing dependency sets) as well as over time as dependencies raise their minimal versions with a non-breaking version bump.
The compiler version that the maintainers are happy to support, generally known as the MSRV. This can be unrelated to compilability and also changes over time (e.g. flate2 has an MSRV policy that increases even if we make no changes to the code).

Essentially rust-version is not adequate for real MSRV handling and the only option above that really works is the first. At least with that option, the minimal version only changes when there is a commit to the flate2 repo.
If we raise the rust-version higher we will get complaints that users cannot get the newest version, even though it would work for them. I'd rather get complaints that a feature doesn't work with their old compiler than that they cannot use crates.io but  can use GitHub main with their old compiler.

Thanks for the clarification, very insightful!

AIUI, what we are looking for here is to check that all features work when the MSRV (as defined by option 3 above) is used? I think that could exist as a separate task. The problem is that since the MSRV is current release - 1, then every 6 weeks we need to modify the workflow to update the compiler version.
It might work if we say the MSRV is 1.79 and then only update it when we feel like it, or when a dependency breaks CI.

Actually it's the smallest possible version that is still able to build the core features (i.e. without zlib-rs. In the README, it talks about the MSRV very conservatively, but I wouldn't be surprised if people were very upset if we'd all of the sudden stick to that minimal requirement only. Thus, previously, Rust 1.56 was tested and this PR adds a lot of detail which shows that it was already too low, while also showing that the Cargo.toml versions declared in dependencies aren't working everywhere either.
But you are absolutely right to ask under which circumstances this setup would break - in theory it does so only if this crate changes, as dependencies would be stuck at their minimal versions.
Maybe there should also be a forward-facing version of this task that tests with the latest dependencies - after all, these would be what truly can affect the typically possible MSRV.
I hope that makes some sense, and I am writing this thinking that I was probably missing some or all of your point :/.

Could you provide another one of these PRs for the libz-sys crate? It seems it's unknowingly using features of more recent vcpkg versions.

@Byron Opened rust-lang/libz-sys#207

My main concern is that the rust-version should not be increased unnecessarily.
A user who happens to be stuck on Rust 1.56.1 can currently add flate2 = "1" to their dependencies and their code will build. Due to the current minimum version test, they will continue to receive working updates until the rust-version increases. When rust-version does eventually increase, Cargo should keep them on the last version that works with 1.56.1.
Now, if this user adds a backend feature, they will need cc and that increases the minimum versions that will work. But flate2 cannot control that. The next version of cc might reduce the supported compiler version! So flate2 should not specify that, but should let Cargo fail and tell the user which crate is the problem.
This change seems to be because users of flate2 see a message like error: package cc v1.0.99 cannot be built because it requires rustc 1.63 or newer when using specific features and you want that to change so that the direct dependency (flate2 or something higher) gets the blame. I don't think anything like that is practical right now. As you see, if you really want that, then the minimum version is 1.75 and can be increased at the whim of any dependency. Users need to learn to use cargo tree --invert to help identify the dependency hierarchy that is causing the problem.

The next version of cc might reduce the supported compiler version!

Well that's impossible.
cc has a msrv of 1.63, same as debian.
The reason we keep 1.63 is because of complaints from users, otherwise we would bump to newer rustc already.
Previously we tried bumping it to 1.65/1.66c and gets pushed back, that's probably why you had experience of a reduction in msrv, it's actually a revert of msrv bump we did.
P.S. I'm co-maintainer of cc

BTW for cc we really want to bump the msrv to drop some code and use some new features.

@NobodyXu Not suggesting that cc will do this. It was just an example that flate2 cannot control the evolution of minimum versions of its dependencies, so should not try to propagate the highest of their minimum versions as its minimum version, but instead let Cargo handle it.

For the zlib-ng-cc part, I think cc is the only dependency?
In that case I suppose it's pretty easy to track.

so should not try to propagate the highest of their minimum versions as its minimum version, but instead let Cargo handle it.

I love the idea that cargo automatically selects one that fits in my msrv, but unfortunately they aren't ready yet.

@Byron We should keep the original minimum test as well, as we need to know when a PR uses a compiler feature that needs rust-version to be increased.

Strange, I am not seeing how this isn't covered particularly well now. But I agree, ideally nothing gets lost with these changes.
In any case, maybe you want to submit a PR for getting that test back and then I will probably see what I am missing right away.


Services filter not working as expected during GTFS import

The option "Filtrer pour une période" is not working properly. See screenshots below.
Actual content of calendar.txt

List of service ids without any filters (it matches the raw text file)

List of service ids when applying filter for 2021-10-16 to 2021-10-22

The weekend services do not appear in the filtered list.

@adolmajian Can you provide a link to the GTFS file that you are using? That would facilitate testing

Indeed, I cannot reproduce with any of the GTFS I have with similar data (EXO's gtfs) and unit tests show this should work, so @adolmajian if you could provide the GTFS. The problem may be elsewhere. Is there a calendar_dates.txt file that may filter out the services?

This is a bug. The only dates in calendar_dates.txt are considered as the only dates the service is available and does not consider the days of service in calendar.txt.


feat: stateful chats

Allow users to ask follow-up questions

Yes! Was going to ask for this!

Yes! Was going to ask for this!

I got them working, but still need some time testing some parameters, since the models behave different if they run in "ConversationalReactDescription" Mode

yea yea (obv still needs a better UI) and I'm going to add a history of recent chats (like OpenAI does)
dont ask me about the calculator move tho haha

A way to save or share chats directly would be cool too

A way to save or share chats directly would be cool too

Yes, that's fairly easy to do, since the whole thing is just a map between an uuid and a memory object.
Basically, you're sending the UUID with your prompt and the backend will associate this ID with an existing memory object, or create a new one. The map is only in memory at the moment. Which means that chats don't survive a server restart. I think I will add a simple sqlite3 db to make this persistent. After that, the browser just has to remember used UUIDs and can request the chats histories from the server.
This is far from optimal in terms of security, but would be easy to extend with some kind of middleware in the future.


Bugfix/fix scoped elements example

What I did
I fixed the appIndex for packages/scoped-elements/demo, so that the examples work again out-of-the-box. Furthermore I updated the main README.md to not use lerna anymore, but the corresponding (and working!) yarn command.
This fixes https://github.com/open-wc/open-wc/issues/2653 .

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


[WIP] malloc a new control structure when we run out of thread space

for #3321

bah, broken upload again


Responsive contributors page Fix #156

@qzhou1607 here is the handlebars file for the new contributors page template. Right now I've got all the contributors so far listed in there.
@molant mentioned something about having a page template and iterating over the list?
Also for now I don't have emoji contributions. I'll want to take a look at this portion at a later date in time.

It will be nice if we can have a json file with the contributors info and iterate over it. @qzhou1607 can you make this happen?

@molant @ststimac Sure. Hexo comes with a data folder which it looks up for information when rendering pages. Currently both the header and footer are dynamically generated using the data from there. I can add another file for contributors.

@molant @ststimac Changes are done.

@molant @ststimac Done. Fixed #161 as well.


Backport "HBASE-28705 BackupLogCleaner cleans required WALs when using multiple backuproots (#6040)" to branch-2

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 54s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
hbaseanti
0m  0s

Patch does not have any anti-patterns.

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
4m  8s

branch-2 passed

+1 :green_heart:
compile
0m 37s

branch-2 passed

+1 :green_heart:
checkstyle
0m 16s

branch-2 passed

+1 :green_heart:
spotbugs
0m 46s

branch-2 passed

+1 :green_heart:
spotless
0m 54s

branch has no errors when running spotless:check.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 55s

the patch passed

+1 :green_heart:
compile
0m 30s

the patch passed

-0 :warning:
javac
0m 30s
/results-compile-javac-hbase-backup.txt
hbase-backup generated 1 new + 100 unchanged - 0 fixed = 101 total (was 100)

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 11s

the patch passed

+1 :green_heart:
spotbugs
0m 50s

the patch passed

+1 :green_heart:
hadoopcheck
20m 14s

Patch does not cause any errors with Hadoop 2.10.2 or 3.3.6 3.4.0.

+1 :green_heart:
spotless
0m 59s

patch has no errors when running spotless:check.

_ Other Tests _

+1 :green_heart:
asflicense
0m 13s

The patch does not generate ASF License warnings.

36m 21s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6305/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6305

Optional Tests
dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless

uname
Linux e1b4cccc6696 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 30e2dc3c0441dd2acf5c02cc82d9f4ee6cfb7f87

Default Java
Eclipse Adoptium-11.0.23+9

Max. process+thread count
78 (vs. ulimit of 30000)

modules
C: hbase-backup U: hbase-backup

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6305/1/console

versions
git=2.34.1 maven=3.9.8 spotbugs=4.7.3

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 45s

Docker mode activated.

-0 :warning:
yetus
0m  4s

Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
2m 36s

branch-2 passed

+1 :green_heart:
compile
0m 16s

branch-2 passed

+1 :green_heart:
javadoc
0m 12s

branch-2 passed

+1 :green_heart:
shadedjars
5m 22s

branch has no errors when building our shaded downstream artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 24s

the patch passed

+1 :green_heart:
compile
0m 15s

the patch passed

+1 :green_heart:
javac
0m 15s

the patch passed

+1 :green_heart:
javadoc
0m 11s

the patch passed

+1 :green_heart:
shadedjars
5m 19s

patch has no errors when building our shaded downstream artifacts.

_ Other Tests _

+1 :green_heart:
unit
11m 44s

hbase-backup in the patch passed.

30m  6s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6305/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6305

Optional Tests
javac javadoc unit compile shadedjars

uname
Linux de368cad886b 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 30e2dc3c0441dd2acf5c02cc82d9f4ee6cfb7f87

Default Java
Temurin-1.8.0_412-b08

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6305/1/testReport/

Max. process+thread count
3506 (vs. ulimit of 30000)

modules
C: hbase-backup U: hbase-backup

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6305/1/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 43s

Docker mode activated.

-0 :warning:
yetus
0m  5s

Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
3m  9s

branch-2 passed

+1 :green_heart:
compile
0m 22s

branch-2 passed

+1 :green_heart:
javadoc
0m 17s

branch-2 passed

+1 :green_heart:
shadedjars
5m 40s

branch has no errors when building our shaded downstream artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m  4s

the patch passed

+1 :green_heart:
compile
0m 21s

the patch passed

+1 :green_heart:
javac
0m 21s

the patch passed

+1 :green_heart:
javadoc
0m 16s

the patch passed

+1 :green_heart:
shadedjars
5m 39s

patch has no errors when building our shaded downstream artifacts.

_ Other Tests _

+1 :green_heart:
unit
11m 56s

hbase-backup in the patch passed.

32m 29s

Subsystem
Report/Notes

Docker
ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6305/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6305

Optional Tests
javac javadoc unit compile shadedjars

uname
Linux 949df8a35550 5.4.0-192-generic #212-Ubuntu SMP Fri Jul 5 09:47:39 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 30e2dc3c0441dd2acf5c02cc82d9f4ee6cfb7f87

Default Java
Eclipse Adoptium-11.0.23+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6305/1/testReport/

Max. process+thread count
3655 (vs. ulimit of 30000)

modules
C: hbase-backup U: hbase-backup

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6305/1/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 43s

Docker mode activated.

-0 :warning:
yetus
0m  5s

Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
3m  5s

branch-2 passed

+1 :green_heart:
compile
0m 18s

branch-2 passed

+1 :green_heart:
javadoc
0m 14s

branch-2 passed

+1 :green_heart:
shadedjars
6m 39s

branch has no errors when building our shaded downstream artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 43s

the patch passed

+1 :green_heart:
compile
0m 22s

the patch passed

+1 :green_heart:
javac
0m 22s

the patch passed

+1 :green_heart:
javadoc
0m 16s

the patch passed

+1 :green_heart:
shadedjars
6m 51s

patch has no errors when building our shaded downstream artifacts.

_ Other Tests _

+1 :green_heart:
unit
11m 45s

hbase-backup in the patch passed.

35m  4s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6305/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6305

Optional Tests
javac javadoc unit compile shadedjars

uname
Linux 25636d3faf00 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 30e2dc3c0441dd2acf5c02cc82d9f4ee6cfb7f87

Default Java
Eclipse Adoptium-17.0.11+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6305/1/testReport/

Max. process+thread count
3861 (vs. ulimit of 30000)

modules
C: hbase-backup U: hbase-backup

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6305/1/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.


redtube now may use longer movie numbers in URLs, download fails

user@host:~$ youtube-dl -c --verbose http://www.redtube.com/105970
[debug] System config: []
[debug] User config: []
[debug] Command-line args: ['-c', '--verbose', 'http://www.redtube.com/105970']
[debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2015.03.18
[debug] Python version 2.7.6 - Linux-3.16.0-33-generic-x86_64-with-Ubuntu-14.04-trusty
[debug] exe versions: avconv 11.1-6, avprobe 11.1-6, ffmpeg 2.6.1, ffprobe 2.6.1, rtmpdump 2.4
[debug] Proxy map: {}
[RedTube] 105970: Downloading webpage
ERROR: Unable to extract video URL; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
File "/usr/lib/python2.7/dist-packages/youtube_dl/YoutubeDL.py", line 654, in extract_info
ie_result = ie.extract(url)
File "/usr/lib/python2.7/dist-packages/youtube_dl/extractor/common.py", line 275, in extract
return self._real_extract(url)
File "/usr/lib/python2.7/dist-packages/youtube_dl/extractor/redtube.py", line 23, in _real_extract
r'', webpage, 'video URL')
File "/usr/lib/python2.7/dist-packages/youtube_dl/extractor/common.py", line 557, in _html_search_regex
res = self._search_regex(pattern, string, name, default, fatal, flags, group)
File "/usr/lib/python2.7/dist-packages/youtube_dl/extractor/common.py", line 547, in _search_regex
raise RegexNotFoundError('Unable to extract %s' % _name)
RegexNotFoundError: Unable to extract video URL; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.

This video has been removed and the problem is not related to length of video id at all. In the next version human readable error will be shown for all the removed videos. Thanks for the report.


Add notes for GradleLifecycle#beforeProject changes

Added release notes for GradleLifecycle#beforeProject API

@6hundreds, as long as you have it in the Google Doc, I will merge it myself with everyone else's changes.


Run the main.py script in staging and generate kibana logs

Opening this issue so that we can coordinate on the next steps. Once this PR is merged, we would like to run the main.py daemon in staging in our backend infrastructure and transform all the messages that the daemon is printing into kibana logs.
Could @sunce86 and @ahhda describe here what needs to be done and coordinate with @shubhagarwal03 on this?

Here are a few tasks:

[ ] Add cla.yaml, pull-request.yaml, deploy.yaml so we can generate the image for each release.
[ ] Add deployment.yaml configuration to our staging gitlab repo
[ ] For logging ispect how it was done in this python project and do similar


Architecture support not mentioned

File: compose/index.md
Please comment right at the beginning that only x86_64 architectures are supported at this time. Not armv7 or 8 etc.
Thank you.

Feel free to create a PR with the changes ;)


Automatic cast objects

It should be great that we can do:
Location cached = (Location ) cache.get("Location");
without having to cast it, like:
Location cached = cache.<Location>get("Location");
Similar as public static final <T> List<T> emptyList() i java Collections

That's a great feature! :+1:

@alorma did this with 41420adc30b7e4de1fb4598b6cd72224e533cf89


Grammarly suggestions

Just pushed https://github.com/esp-rs/book/commit/484f4f6b4ed630239fbb018aae659961a211a247 addressing your comments to the branch, not sure why the PR is not being updated with that commit.