Feat: Canceling exceptions

This is a WIP of being able to cancel exceptions through the use of a String tag. @bunkat once this is ready to review with all the proper tests, I'll let you know. I'm creating the PR now so anyone can suggest changes if they come up with any ideas.

@bunkat how can I keep track of when a time period is called for an exception and not a schedule? The issue I'm facing right now is that I would have to check in every function whether a variable that keeps track of whether an exception is being created is true or not to decide whether to set the value in the object of exception tags to exceptions.

A time period is considered valid when it is valid for all schedules and invalid for all exceptions.  There isn't really a concept of time period being called for an exception.  Though maybe I'm not understanding the question.
If you are trying to tag exceptions so that you can find them later, you'll need to tag them as you add them (by updating the recur() functions or manually placing a tag in the appropriate exception schedule object).  For example, if you wanted to tag an exception as a holiday you would tag it when you enter it and if you wanted to turn it off later, you would just search the exceptions for things with that tag and then remove them.

@bunkat I got all the tests I wrote passing and I even tested the code a little bit to see if it's pretty easy to work with. The functionality is all there and I didn't modify anything other than .recur() since that's what I use. Some of the tests that you or someone else wrote seem to be failing when I run it locally, and it seems that they are completely unrelated to mine.

@bunkat if you take a look at my first commit in this PR, you'll see that I added an if statement that does nothing, and even then tests weren't passing. I'm pretty sure none of the tests started failing as a result of the changes I made.

@bunkat what should be done? Should we merge this in and then fix the failing tests in master?

By the way, since a composite exception schedule is created using .and() and not .and().except() I had to add a the composite tag functionality into .and() if you're wondering why I did that. Let me know if the sample code in the tests could be better and I'll try to come up with a better way.

@bunkat have you had a chance to look over this PR?

Sorry, I'm quite busy at the moment and probably won't get a chance to look at this for a bit. Appreciate the PR and I'll get to it as soon as I can.

@bunkat if you have any questions about the PR, feel free to ask me so that we can get this merged in as quickly as possible for others to use.

@bunkat let me know if everything here is good so I can squash this PR down to 1 commit to make the commit log a little bit cleaner.

@bunkat is there any way you can take a look at this PR and test out the functionality I added in? I'd like to use this functionality for another project.

You don't need to wait for me to be able to use this functionality.  Just create a build out of your repository and go for it.

I'm referring to the server-side, because I'm looking to use this through the node package and not have to make lots of changes later because of monkey patching it now. Is there any issue with the code I added that prevents you from merging it in?

Any update on getting it merged in?

@bunkat do you have any questions about the functionality?

Really sorry, I do try and keep up with things better but unfortunately I'm swamped right now and I'm not sure when I'm going to have a chance to get these PRs reviewed and merged in.  I wouldn't wait on me, just use it as a local module instead of via npm.  Once it gets merged it will be easy enough to move it over.  I'll try and get to all these next month.

@bunkat just let me know when I should squash the commits so that you can merge.

@bunkat have you had a chance to take a look at this?

@bunkat can this be merged in and released as part of Later 1.2.0?

@bunkat everything coming along ok?

@bunkat any issue with merging this?

@bunkat we should be testing against these new versions now that many people use them.

@bunkat still waiting on this. Can you merge it in?

Per my work with Bree, I have an updated fork of this package called @breejs/later.  See https://github.com/breejs/later if you would like to file this PR there.


follow the react-scripts utils/createJestConfig transform setting

react-scripts --version: 2.0.5

craco jest trigger error

with
BABEL_TRANSFORM_ENTRY_KEY = "^.+\\.(js|jsx|ts|tsx)$"

Hi @beatwade than you for the issue.
I feel you, the update might have been too "drastic", I will add a fallback.
Thank you

It's available in version 2.2.3


ci: Rename workflows to all end in .yml or .yaml

No reason to have a discrepancy between our different workflow files.
I have no opinion on which is better, happy to hear suggestions.

Fixed in commit f6fa466a2fd4311a6d57e2f286484ad288dee8f5


Crash on Titan

Crash titan.txt

Thank you for opening the issue @VanilaBOI ! It does indeed seem like my mod has a null reference error. I fixed one null reference error 5 days ago, and I don't really have any idea where a second one could be. And unfortunately, in the log you attached, it doesn't go to the beginning where the mod would print its version. So, are you sure you were using the latest version?
I also should add some debug info into the dll files I guess so I could see the exact line of code that has the issue, when an error happens...
Also btw, it seems that the host crashed and you were not the host, so I have no idea what caused the crash for the host. It could be anything


clear jwk definitions after retrieving new ones

An unknown jwk id triggers the retrieval of the key definitions as it usually means the keys rotated.
When this call executes the definition map was cleared before reading the current definitions
from the remote jwkSetUrl.
During this retrieval subsequent requests can not be
verified, which is fine in case of a key rotation. But if someone intentionally changes the kid, other requests still have a valid key but are forced to block until the call completes.
Moving the clear and put after the retrieval of the new jwk
definitions mitigates this.
Closes gh-1722

Thanks for the PR @JanGroot. This is now in master.


fix(expect)!: check more properties for error equality

Description

closes https://github.com/vitest-dev/vitest/issues/5244
closes https://github.com/vitest-dev/vitest/issues/5697

NodeJs PR for a reference

https://github.com/nodejs/node/pull/51805

todo

[ ] error formatting

actually error diff formatting is from pretty-format, so it needs by custom formatter and that also means it affects snapshot too.

[ ] cyclic object
[ ] docs

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

[ ] It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
[ ] Ideally, include a test that fails without this PR but passes with it.
[ ] Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

[ ] Run the tests with pnpm test:ci.

Documentation

[ ] If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

[ ] Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@hi-ogawa is there anything specific that keeps this PR in draft? Can I help?

I had a concern about whether we should print diff when custom properties are different. Currently, Vitest cannot show any diff in this case since pretty-format strips it off. Fortunately, chai/loupe can print them, but it's possible that the message will be truncated and not visible to users. This is an example from test cases:
exports[`Error equality > basic 4`] = `
{
  "actual": "[Error: hello]",
  "diff": "Compared values have no visual difference.",
  "expected": "[Error: hello]",
  "message": "expected Error: hello { cause: 'x' } to deeply equal Error: hello { cause: 'y' }",
}
`;

Do you think it's worth changing pretty-format side (I haven't attempted anything yet whether it's possible or not) or just keep it as is and rely on chai error message?

Do you think it's worth changing pretty-format side (I haven't attempted anything yet whether it's possible or not) or just keep it as is and rely on chai error message?

I think we can maybe introduce a flag in pretty-print (or maybe there is already one?) to print Error as an object.

This fails now since we changed how diff is displayed 😄


fix Text input error tooltip wrong position when block is set to true

@benouat Thank you for your review!


Add option to ignore inline styles/css-in-js/regular css

I could imagine that in some cases it's not interesting to get the inline styles from a page.
const cssWithoutInlineStyles = await extractCss('test.url', {
  includeInlineStyles: false,
  includeJsStylesheetsApi: true,
  includeLinks: true,
  includeStyleTags: true
})

Hm, thinking about this. After I change the module to return an array of origings instead of a string of all CSS, you could just filter the output yourself.
Closing this.


Show the application name in the about screen

Like the updated Anytime about screen:

Fixed in a25a28d16128dc8d63739f01decd6b99219c108a.


BUG: Significant paranthesis removed in macro interpolation (introduced by #4708)

In current master the expression  (1 > 2).as(Bool) is expanded as  1 > 2.as(Bool) when interpolated in a macro. This error was introduced by #4708.
puts (1 > 2).as(Bool) # => works fine
pp (1 > 2).as(Bool)   # => expands to `1 > 2.as(Bool)`
pp begin 1 > 2 end.as(Bool)   # => expands to `1 > 2.as(Bool)`

The relevant part of the error message:
Error in line 1: expanding macro

in line 1: expanding macro

in macro 'pp' /mnt/d/Dokumente/dev/test/crystal/crystal-exhaustiveness/src/macros.cr:95, line 5:

   1.
   2.
   3.     __temp_22 = "#{"1 > 2.as(Bool)"} # => "
   4.     ::print __temp_22
>  5.     __temp_23 = 1 > 2.as(Bool)
   6.     PrettyPrint.format(__temp_23, STDOUT, width: 80 - __temp_22.size, indent: __temp_22.size)
   7.     ::puts
   8.     __temp_23
   9.

no overload matches 'Int32#>' with type Bool

/cc @MakeNowJust

Thank you for reporting and sorry. I want to revert #4708 and I think right way to solve #4663 is to apply Normalizer to AST before inserting instruments. I'll try to implement this.


Get list of sensors

Checklist

[x ] I checked for similar existing requests (both open and closed) before posting.
[ x] My request is generic, other users may benefit from it too.

Proposal
To check for the liveness of the alarm systems I want to check if all sensors are available. I want to avoid having to maintain a second list of sensors configured for Alarmo within a script.
Therefore I propose an attribute (or a function) that gets me all unavailable sensors.
Additional info
Other types of sensor lists are:

all sensors (for all kind of listing and checking)
all battery powered sensors (for battery warnings)

@nielsfaber Please close the ticket if it's either impossible or you have no plans to implement or accept PR for this feature.


Disable "Automatically Scroll lyrics while playing" does not work correctly

OS:
Windows 10 64 bit
Issue Descriptions:
Automatic scrolling does not work properly.
Steps to Reproduce:
Case 1:
Open the player.
Put a song and put the lyrics of the song.
Turn off automatic scrolling.
The lyrics of the song actually does not move automatically.
Wait to change the lyrics of the song, while changing song.
Case 2:
Open the player.
Put a song and put the lyrics of the song.
Turn off automatic scrolling.
The lyrics of the song actually does not move automatically.
Close the player and reopen it.
Put a song and the lyrics will scroll automatically again.

I am able to reproduce Case 2 (intermittently), but not Case 1. @MCManuelLP looks to have setup the scrolling and @MarshallOfSound pushed a related fix 10 days ago, maybe they can chime in with some insight, possibly related to changes from #1214 or #1322 ? Interestingly enough, the lyrics scrollbar seems to always behave (show/hide) as expected when autoscroll is disabled/enabled.
Win 10, 64 bit, v3.3.0

@techuck Thanks for pinging me, this slipped through my inbox somehow....  Too many github notifications 😆
This appears to have a root cause of animating the scroll regardless of the setting.  I can reproduce both cases 100% of the time.  Looking into why it always animates now


Don't change the URL of the main execution context on phantom::exit

We shouldn't change the URL of the main execution context. Because this will change security policy of our main frame which leads to the following message: Unsafe JavaScript attempt to access frame with URL about:blank from frame with URL file://bla.js. Domains, protocols and ports must match.
We can fix it by isolating main frame of PhantomJS execution context. We can destroy it separately.
This fixes: #12697 #12660

so this PR was closed, but was this merged to master ? I'm still having the problem with version 1.9.16

@alexserver I have the same issue. 1.9.16 is the version of the node wrapper for Phantom (https://github.com/Medium/phantomjs) which currently uses the last release of the 1.9 branch of Phantom. Unfortunately, the latest release (1.9.8) doesn't include this fix and it seems like there aren't any plans to release it.
If you use 1.9.11 of the node wrapper it should fix the issue.

@tedtate Oh I understand, it is confusing to see this between the node wrapper and the phantomjs binary. thanks man.

Hello!
You have a new message, please read http://find-it-usa.com/boil.php?mx
<EMAIL_ADDRESS>


Restore support for &Class and &mut Class as arguments

We can't implement FromPyObject for them. You can use PyRef and PyRefMut as arguments.

Agreed we can't implement FromPyObject for them. It would be nice if we can find another way for the generated wrappers to support &Class and &mut Class arguments - by calling .try_borrow() in the wrapper, perhaps, like we can do for &self.
Originally posted by @davidhewitt in https://github.com/PyO3/pyo3/issues/785#issuecomment-593813961

I'm experimenting an idea to change our generated method call(_slf.#fname(#name1, #name2, ...) to _slf.#fname(&*#name1, &*#name2, ...) only when an arg(e.g., #name1) has a reference type.
Though I'm not sure it's possible now :thinking:


Add support for additional types

I was trying to add "airport" type using types but since there are only 4 supported types, I obviously can't. any ideas on how should I do that?
Do you intend to support other types?

We pass everything you define in types directly to the Google API. Check the reference for what is allowed. They state that you can just pass one type at a time.
The places details seem to get those various types, but the API for place autocomplete requests only allows a few, sadly. Check https://developers.google.com/places/supported_types#table3 for further information.


Highlighted cursor position breaks after surrogate pairs

As can be seen in https://asciinema.org/a/AxH57hTJctdztmBaJ2bBTS7nP, characters, which in JavaScript are represented as surrogate pairs, break cursor highlight positioning, due to the position being calculated in terms of JavaScript characters, not Unicode codepoints.
One possible fix is available here; in my testing, that makes such surrogate pair characters work perfectly. (feel free to pull that commit directly to main, modify/copy as needed, or request a PR)
This fix is largely independent of the larger problem around grapheme clusters/wcwidth, but it doesn't make it worse (or, in fact, even makes the cursor be positioned correctly, but that doesn't really mean much if the VT output itself is broken).

Thanks. This is useful :+1: I'll keep it open until we solve wcwidth-related core problem, and will revisit this then.


Make native-mt and agp version types for Maven and Gradle

Fixes https://github.com/dependabot/dependabot-core/issues/2547.
Version comparison in Dependabot uses the Maven specification when looking at Maven / Gradle versions. Whilst technically correct, this can cause problems where a popular dependency has chosen to append their own suffix onto their versions to distinguish between types. The problems are not unique to Dependabot.
The pragmatic solution is to add some special cases to our version fetching logic. We already treat jre, android and java as "types" when they appear in a version string - this PR extends that logic to do the same for native-mt and agp (short for "Android Gradle Plugin" and referenced here).
Note: the native-mt type is a particular pain, as it includes a token separator character (the -). I've added extra special casing to deal with that, and a test for it.

@hiqua FYI

@greysteil nice, thanks a lot!
I think this doesn't cover this case though:

https://github.com/iSoron/uhabits/pull/745

or does it?
It's unfortunate, since, from my reading of https://semver.org/spec/v2.0.0.html#spec-item-9, this should be considered a pre-release. From my limited experience, it would be better to default to considering these x.y.z-$SUFFIX as prereleases, and whitelist a few of these $SUFFIX that could mean something else (like a specific flavor of the library).

It won't fix that, no, but it's not clear to me that it should - as far as I'm aware the Maven ecosystem uses this specification for version comparison, not SemVer 2.0, and I presume Gradle does the same for consistency. Dependabot would be doing the wrong thing in even more cases if it followed SemVer 2.0 for Maven/Gradle.
(FWIW, here's the [version comparison logic Dependabot uses for Gradle](https://github.com/dependabot/dependabot-core/blob/main/gradle/lib/dependabot/gradle/version.rb. We have different version comparison logic for each language because they're all different - here's python's and here's npm's (the easy one, as it's just SemVer - they wrote the SemVer spec).)
Are you using other tooling that sort 1.0 ahead of 1.0-20050927.133100? I don't use Maven or Gradle myself, so am happy to be corrected, but my hunch here is that in this case it's the package author who has made a mistake, releasing alphas / betas with versions that in fact treat them as full releases.

It won't fix that, no, but it's not clear to me that it should - as far as I'm aware the Maven ecosystem uses this specification for version comparison, not SemVer 2.0, and I presume Gradle does the same for consistency. Dependabot would be doing the wrong thing in even more cases if it followed SemVer 2.0 for Maven/Gradle.

Unless I'm misreading it, your link indicates that Maven should mostly follow Semver 1.0.0 (which seems similar for these cases: https://semver.org/spec/v1.0.0.html#spec-item-4):

If version strings are syntactically correct Semantic Versioning 1.0.0 version numbers, then in almost all cases version comparison follows the precedence rules outlined in that specification. These versions are the commonly encountered alphanumeric ASCII strings such as 2.15.2-alpha.

This example (2.15.2-alpha) seems to indicate that they indeed treat a -alpha version as a prerelease.

Are you using other tooling that sort 1.0 ahead of 1.0-20050927.133100?

Android Studio (and I guess vanilla Jetbrains' IDEs) correctly suggest to upgrade from the prerelease to the release for this example (and not the other way around):

Of course they could have a specific exception for this library but that's unlikely.


purge cache when add or delete file

What kind of change does this PR introduce?
bugfix #6036
Did you add tests for your changes?
I'd like to add test case for this, but got confused about where to write the case and how to test this as there is a issue build-loop

If relevant, link to documentation update:

N/A
Summary
fix #6036 ,  when a dependency is not exists, webpack will cache the ENOENT error, then remove and add it back won't purge the cache for it, so even the dependency becomes good, webpack still hit and read the ENOENT error cache.
there's my solution, when the dependency changes, purge all cache for the new dependencies or removed dependencies to ensure the cache is correct.

Does this PR introduce a breaking change?
no.

Other information

Could you add a watch test for this?

@ooflorent  any advise for which file should I add the test case in？ and watch file created by fs  would trigger a build loop, any instruction about how to avoid this issue's effect(check the hash may be effective , I'll try this)？

Any movement on this? Currently suffering from this bug in Node 8.9


add connection queue size

https://github.com/stablekernel/postgresql-dart/issues/61

An unsolicited opinion: can this be part of another interface? I can imagine that a ConnectionMetrics interface could expose this, some latency and total time spent data as well.

I'm cool with this because it could potentially be useful for other reasons, but I'd like to see an empty state and non-empty state test to make sure we don't regress should the implementation change.

@joeconwaystk Test added


Fix/clean db history for current period

Proposed changes

Add a method that a dev can call in order to clean the current period history for every parameter in the db
Add a new parameter that devs can optionally configure so current period history is cleaned every time we reset

Fixes
If it fixes a bug or resolves a feature request, be sure to link to that issue.n/a
Types of changes
What types of changes does your code introduce? (A breaking change is a fix or feature that would cause existing functionality and APIs to not work as expected.)
Put an x in the box that applies

[x] Non-breaking fix (non-breaking change which fixes an issue)
[ ] Breaking fix (breaking change which fixes an issue)
[ ] Non-breaking feature (non-breaking change which adds functionality)
[ ] Breaking feature (breaking change which adds functionality)
[ ] Refactor (non-breaking change which changes implementation)
[ ] Messy (mixture of the above - requires explanation!)

Checklist
Put an x in the boxes that apply.

[x] I have read the CONTRIBUTING doc
[x] I am making a pull request against the main branch (left side). Also you should start your branch off our main.
[x] Lint and unit tests pass locally with my changes
[x] I have added tests that prove my fix is effective or that my feature works

Why should we take care of emptying the current period's data if the developer decides not to use a period? Wouldn't it be simpler if the developer introduced a period for the skill? Why not add a section in the documentation instead warning about memory growth if the concept of a period is not introduced?

I wouldn't say we are taking care, at least not always: the developer would have three options now:

Do nothing and let the current period's data grow unbounded as in the current implementation
Call the new cleaning method himself, so he would be taking care of data
Explicitly configure the parameter in skill.yaml so the current period's data is cleaned. This would be automatic but need configuration, so it does not happen without his knowledge

Since we decided to perform this change, wouldn't it be much simpler and less error-prone to choose a data structure that has a limited number of items it can keep, and discards the oldest entries?

I considered that option (like using a deque), yes, but in the end I thought that it made more sense to either leave the dev decide when the cleaning happens or, if done automatically, synchronize the cleaning with the other cleanup to keep both coherent. I think that having one cleanup on reset and another one that is independent and not period related might introduce more confusion, but this of course is just an opinion. If in the end we decide to go the deque route, I think we should do it for both dimensions of the db: number of periods and current period history size.

LGTM & thanks for answering the questions.

I think the documentation should be extended to explain the cleaning up

Opened an issue for the deque discussion: #1038


Added Tuner Tests

This PR contains:

Tests for layout tuner
Tests for index tuner

Coverage increased (+0.6%) to 61.387% when pulling ffbc66e55362372851be5560d788d93a92246974 on jarulraj:master into d307384bca00847a37da8eebeca635b99d2853cb on cmu-db:master.


Report error names with Javascript error reports

Currently, we have no way of grouping errors together (e.g. by name in Python) in the Javascript library.

ressolved in #78


dts: bindings: add support for the radio transceiver

This path adds generic support for extract description
from the radio node and adds implementation of
this property for nrf52840 targets.
This helps to keep IEEE 802.15.4 driver name in DT.
Signed-off-by: Andrzej Puzdrowski<EMAIL_ADDRESS>

@galak

Also, iee802154_drv_label should just be label = “IEEE802154_nrf5”. We can use the dts.fixup to map various SoC radio/devices that do 802154 to a generic define like you have.

This is multiprotocol radio, it can be support by multiple drivers, at last BLE one and 802.15.4 drivers. Then what you propose for resolve bindings to each driver?

what is the story with this PR? Is this going to be updated and is it still required? If nothing happens within the next week, it will be closed.

stale PR


The difference between using and not using --benchmark

Hi,
what's the difference if I set the argument `--benchmark' compared to not set that?

When using --benchmark, the code will turn on all CUDNN optimization flags, not drawing the masks over the image, and measure the FPS of the code.

I am closing this issue for now due to inactivity. If there are any further questions that I could help with, please feel free to reopen, thanks.


CS Effort:  IIS-docs & IIS.Administration-docs

CS effort for repo:
IIS-docs and MicrosoftDocs/IIS.Administration-docs
GUIDS:
0:  Done All good here for both repos.
ROPC:
107 files in IIS-pr
0 in IIS.Administration-docs
Global:
0:  Done All good here for both repos.
Image scans:
512 images in IIS-docs
1 image in IIS.Administration-docs
Assigned to all three of us until we work out who is doing what.
Go to the CS Dashboard per email thread.
There are 4 drilldown reports there.  In each select the following repos, review/fix and select the "fixed" button for those reports that have one:

repos IIS-docs
MicrosoftDocs/IIS.Administration-docs

Closing, since we are organizing by Issue type.

The list completes the triage


Computing the L2 Deposit Tx Hash Client Side

Is your feature request related to a problem? Please describe.
When a user sends a L1 -> L2 transaction, the user wants to know what the L2 transaction hash is so that they can know when the deposit goes through. Right now, the DepositTx has this schema:
interface DepositTxOpts {
  blockHeight: BigNumberish
  transactionIndex: BigNumberish
  from: string
  to: string | null
  mint: BigNumberish
  value: BigNumberish
  gas: BigNumberish
  data: string
}

This is problematic because the L2 blockheight and L2 transactionIndex are included in the transaction. This means that the user needs to brute force the L2 tx hash to know when it goes through on L2. See the hardhat task changes here: https://github.com/ethereum-optimism/optimistic-specs/pull/347/files for how this would look in the sdk
Describe the solution you'd like
I'd like to be able to compute the L2 tx hash locally just using the receipt of the L1 transaction. This could be accomplished by changing the struct of the TxDeposit to:
interface DepositTxOpts {
  sourceHash: string
  from: string
  to: string | null
  mint: BigNumberish
  value: BigNumberish
  gas: BigNumberish
  data: string
}

Where sourceHash is keccack256(receipt.blockHash || receipt.txIndex || receipt.eventIndex).
The sourceHash is required to ensure that transaction hashes are unique on L2.
The event index is required because a single L1 transaction can create multiple L2 transactions by calling the deposit contract multiple times.

https://github.com/ethereum-optimism/reference-optimistic-geth/pull/9

See #351


configurable new-line handling in OpenSearchJsonLayout

Description
The OpenSearchJsonLayout got some new properties. Primarily to emit compact, linebased json.
Issues Resolved
#4673
Check List

[ ] New functionality includes testing.

[ ] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[ ] Commits are signed per the DCO using --signoff
[ ] Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

I like it.

Rebase this PR and mark it ready when you're satisfied with it? Fix any CI failures. If the failures are not related to this PR, check whether there's already an issue for those failure, and call it out in a comment.

Thanks @dblock  for the inputs.  @svenso  are you still working on this? do you need any help?

@svenso: Are you still working on this PR ?

the forbidden api issue & DCO should now be solved.

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/12959/
CommitID: c5245c1
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

Is this expected failure, @svenso ?
> Task :qa:logging-config:test

REPRODUCE WITH: ./gradlew ':qa:logging-config:test' --tests "org.opensearch.common.logging.OpenSearchJsonLayoutTests.testEmptyType" -Dtests.seed=A6E8E1607DC1009E -Dtests.security.manager=false -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=es-NI -Dtests.timezone=Asia/Singapore -Druntime.java=19

org.opensearch.common.logging.OpenSearchJsonLayoutTests > testEmptyType FAILED
    junit.framework.AssertionFailedError: Expected exception IllegalArgumentException but no exception was thrown
        at __randomizedtesting.SeedInfo.seed([A6E8E1607DC1009E:2F6D8CCF138BC8E9]:0)
        at org.apache.lucene.tests.util.LuceneTestCase.expectThrows(LuceneTestCase.java:2864)
        at org.apache.lucene.tests.util.LuceneTestCase.expectThrows(LuceneTestCase.java:2850)
        at org.opensearch.common.logging.OpenSearchJsonLayoutTests.testEmptyType(OpenSearchJsonLayoutTests.java:48)

The following test failure that occurred in the build No.12999 seems related to the change.
REPRODUCE WITH: ./gradlew ':qa:logging-config:integTest' --tests "org.opensearch.qa.custom_logging.CustomLoggingConfigIT.testSuccessfulStartupWithCustomConfig" -Dtests.seed=956E2547DB08797 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=he-IL -Dtests.timezone=Antarctica/Davis -Druntime.java=19

org.opensearch.qa.custom_logging.CustomLoggingConfigIT > testSuccessfulStartupWithCustomConfig FAILED
    java.lang.AssertionError:
    Expected: a collection containing .*integTest-0.*cluster.uuid.*node.id.*recovered.*cluster_state.*
         but: mismatches were: [was "integTest-0   version[3.0.0-SNAPSHOT], pid[197926], build[tar/1d1de6e20bacdf7e16e18d038c58ab5eba246541/2023-03-28T17:52:20.694180032Z], OS[Linux/5.15.0-1028-aws/amd64], JVM[Eclipse Adoptium/OpenJDK 64-Bit Server VM/19.0.2/19.0.2+7]", was "integTest-0   JVM home [/usr/lib/jvm/temurin-19-jdk-amd64], using bundled JDK [false]", was "integTest-0   JVM arguments [-Xshare:auto, -Dopensearch.networkaddress.cache.ttl=60, -Dopensearch.networkaddress.cache.negative.ttl=10, -XX:+AlwaysPreTouch, -Xss1m, -Djava.awt.headless=true, -Dfile.encoding=UTF-8, -Djna.nosys=true, -XX:-OmitStackTraceInFastThrow, -XX:+ShowCodeDetailsInExceptionMessages, -Dio.netty.noUnsafe=true, -Dio.netty.noKeySetOptimization=true, -Dio.netty.recycler.maxCapacityPerThread=0, -Dio.netty.allocator.numDirectArenas=0, -Dlog4j.shutdownHookEnabled=false, -Dlog4j2.disable.jmx=true, -Djava.security.manager=allow, -Djava.locale.providers=SPI,COMPAT, -Xms1g, -Xmx1g, -XX:+UseG1GC, -XX:G1ReservePercent=25, -XX:InitiatingHeapOccupancyPercent=30, -Djava.io.tmpdir=/var/jenkins/workspace/gradle-check/search/qa/logging-config/build/testclusters/integTest-0/tmp, -XX:+HeapDumpOnOutOfMemoryError, -XX:HeapDumpPath=logs, -XX:ErrorFile=logs/hs_err_pid%p.log, -Xlog:gc*,gc+age=trace,safepoint:file=logs/gc.log:utctime,pid,tags:filecount=32,filesize=64m, -Djava.security.manager=allow, -Xms512m, -Xmx512m, -ea, -esa, -XX:TieredStopAtLevel=1, -XX:ReservedCodeCacheSize=64m, -XX:MaxDirectMemorySize=268435456, -Dopensearch.path.home=/var/jenkins/workspace/gradle-check/search/distribution/archives/linux-tar/build/install/opensearch-3.0.0-SNAPSHOT, -Dopensearch.path.conf=/var/jenkins/workspace/gradle-check/search/qa/logging-config/build/testclusters/integTest-0/config, -Dopensearch.distribution.type=tar, -Dopensearch.bundled_jdk=true]", was "integTest-0   version [3.0.0-SNAPSHOT] is a pre-release version of OpenSearch and is not suitable for production", was "integTest-0   ReindexPlugin reloadSPI called", was "integTest-0   Unable to find any implementation for RemoteReindexExtension", was "integTest-0   loaded module [aggs-matrix-stats]", was "integTest-0   loaded module [analysis-common]", was "integTest-0   loaded module [geo]", was "integTest-0   loaded module [ingest-common]", was "integTest-0   loaded module [ingest-geoip]", was "integTest-0   loaded module [ingest-user-agent]", was "integTest-0   loaded module [lang-expression]", was "integTest-0   loaded module [lang-mustache]", was "integTest-0   loaded module [lang-painless]", was "integTest-0   loaded module [mapper-extras]", was "integTest-0   loaded module [opensearch-dashboards]", was "integTest-0   loaded module [parent-join]", was "integTest-0   loaded module [percolator]", was "integTest-0   loaded module [rank-eval]", was "integTest-0   loaded module [reindex]", was "integTest-0   loaded module [repository-url]", was "integTest-0   loaded module [systemd]", was "integTest-0   loaded module [test-delayed-aggs]", was "integTest-0   loaded module [transport-netty4]", was "integTest-0   no plugins loaded", was "integTest-0   Using MemorySegmentIndexInput with Java 19; to disable start with -Dorg.apache.lucene.store.MMapDirectory.enableMemorySegments=false", was "integTest-0   using [1] data paths, mounts [[/ (/dev/root)]], net usable_space [78gb], net total_space [96.7gb], types [ext4]", was "integTest-0   heap size [512mb], compressed ordinary object pointers [true]", was "integTest-0   node name [integTest-0], node ID [4JqEHFjJRzWzVgxMeBbERg], cluster name [integTest], roles [ingest, remote_cluster_client, data, cluster_manager]", was "integTest-0   creating NettyAllocator with the following configs: [name=unpooled, suggested_max_allocation_size=256kb, factors={opensearch.unsafe.use_unpooled_allocator=null, g1gc_enabled=true, g1gc_region_size=1mb, heap_size=512mb}]", was "integTest-0   using discovery type [zen] and seed hosts providers [settings, file]", was "integTest-0   gateway.auto_import_dangling_indices is disabled, dangling indices will not be automatically detected or imported and must be managed manually", was "integTest-0   initialized", was "integTest-0   starting ...", was "integTest-0   publish_address {<IP_ADDRESS>:46413}, bound_addresses {[::1]:33177}, {<IP_ADDRESS>:46413}", was "integTest-0   max virtual memory areas vm.max_map_count [65530] is too low, increase to at least [262144]", was "integTest-0   startInitialJoin: coordinator becoming CANDIDATE in term 0 (was null, lastKnownLeader was [Optional.empty])", was "integTest-0   expected, but did not find, a dynamic hosts list at [/var/jenkins/workspace/gradle-check/search/qa/logging-config/build/testclusters/integTest-0/config/unicast_hosts.txt]", was "integTest-0   setting initial configuration to VotingConfiguration{4JqEHFjJRzWzVgxMeBbERg}", was "integTest-0   scheduling scheduleNextElection{gracePeriod=0s, thisAttempt=0, maxDelayMillis=100, delayMillis=95, ElectionScheduler{attempt=1, ElectionSchedulerFactory{initialTimeout=100ms, backoffTime=100ms, maxTimeout=10s}}}", was "integTest-0   publish_address {<IP_ADDRESS>:34561}, bound_addresses {[::1]:38943}, {<IP_ADDRESS>:34561}", was "integTest-0   started", was "integTest-0   scheduleNextElection{gracePeriod=0s, thisAttempt=0, maxDelayMillis=100, delayMillis=95, ElectionScheduler{attempt=1, ElectionSchedulerFactory{initialTimeout=100ms, backoffTime=100ms, maxTimeout=10s}}} starting election", was "integTest-0   scheduling scheduleNextElection{gracePeriod=500ms, thisAttempt=1, maxDelayMillis=200, delayMillis=555, ElectionScheduler{attempt=2, ElectionSchedulerFactory{initialTimeout=100ms, backoffTime=100ms, maxTimeout=10s}}}", was "integTest-0   PreVotingRound{preVotesReceived={}, electionStarted=false, preVoteRequest=PreVoteRequest{sourceNode={integTest-0}{4JqEHFjJRzWzVgxMeBbERg}{x9HwXtcITlqbMfKhtQsuJg}{<IP_ADDRESS>}{<IP_ADDRESS>:46413}{dimr}{testattr=test, shard_indexing_pressure_enabled=true}, currentTerm=0}, isClosed=false} requesting pre-votes from [{integTest-0}{4JqEHFjJRzWzVgxMeBbERg}{x9HwXtcITlqbMfKhtQsuJg}{<IP_ADDRESS>}{<IP_ADDRESS>:46413}{dimr}{testattr=test, shard_indexing_pressure_enabled=true}]", was "integTest-0   PreVotingRound{preVotesReceived={{integTest-0}{4JqEHFjJRzWzVgxMeBbERg}{x9HwXtcITlqbMfKhtQsuJg}{<IP_ADDRESS>}{<IP_ADDRESS>:46413}{dimr}{testattr=test, shard_indexing_pressure_enabled=true}=PreVoteResponse{currentTerm=0, lastAcceptedTerm=0, lastAcceptedVersion=0}}, electionStarted=true, preVoteRequest=PreVoteRequest{sourceNode={integTest-0}{4JqEHFjJRzWzVgxMeBbERg}{x9HwXtcITlqbMfKhtQsuJg}{<IP_ADDRESS>}{<IP_ADDRESS>:46413}{dimr}{testattr=test, shard_indexing_pressure_enabled=true}, currentTerm=0}, isClosed=false} added PreVoteResponse{currentTerm=0, lastAcceptedTerm=0, lastAcceptedVersion=0} from {integTest-0}{4JqEHFjJRzWzVgxMeBbERg}{x9HwXtcITlqbMfKhtQsuJg}{<IP_ADDRESS>}{<IP_ADDRESS>:46413}{dimr}{testattr=test, shard_indexing_pressure_enabled=true}, starting election", was "integTest-0   starting election with StartJoinRequest{term=1,node={integTest-0}{4JqEHFjJRzWzVgxMeBbERg}{x9HwXtcITlqbMfKhtQsuJg}{<IP_ADDRESS>}{<IP_ADDRESS>:46413}{dimr}{testattr=test, shard_indexing_pressure_enabled=true}}", was "integTest-0   joinLeaderInTerm: for [{integTest-0}{4JqEHFjJRzWzVgxMeBbERg}{x9HwXtcITlqbMfKhtQsuJg}{<IP_ADDRESS>}{<IP_ADDRESS>:46413}{dimr}{testattr=test, shard_indexing_pressure_enabled=true}] with term 1", was "integTest-0   handleStartJoin: leaving term [0] due to StartJoinRequest{term=1,node={integTest-0}{4JqEHFjJRzWzVgxMeBbERg}{x9HwXtcITlqbMfKhtQsuJg}{<IP_ADDRESS>}{<IP_ADDRESS>:46413}{dimr}{testattr=test, shard_indexing_pressure_enabled=true}}", was "integTest-0   attempting to join {integTest-0}{4JqEHFjJRzWzVgxMeBbERg}{x9HwXtcITlqbMfKhtQsuJg}{<IP_ADDRESS>}{<IP_ADDRESS>:46413}{dimr}{testattr=test, shard_indexing_pressure_enabled=true} with JoinRequest{sourceNode={integTest-0}{4JqEHFjJRzWzVgxMeBbERg}{x9HwXtcITlqbMfKhtQsuJg}{<IP_ADDRESS>}{<IP_ADDRESS>:46413}{dimr}{testattr=test, shard_indexing_pressure_enabled=true}, minimumTerm=0, optionalJoin=Optional[Join{term=1, lastAcceptedTerm=0, lastAcceptedVersion=0, sourceNode={integTest-0}{4JqEHFjJRzWzVgxMeBbERg}{x9HwXtcITlqbMfKhtQsuJg}{<IP_ADDRESS>}{<IP_ADDRESS>:46413}{dimr}{testattr=test, shard_indexing_pressure_enabled=true}, targetNode={integTest-0}{4JqEHFjJRzWzVgxMeBbERg}{x9HwXtcITlqbMfKhtQsuJg}{<IP_ADDRESS>}{<IP_ADDRESS>:46413}{dimr}{testattr=test, shard_indexing_pressure_enabled=true}}]}", was "integTest-0   successful response to StartJoinRequest{term=1,node={integTest-0}{4JqEHFjJRzWzVgxMeBbERg}{x9HwXtcITlqbMfKhtQsuJg}{<IP_ADDRESS>}{<IP_ADDRESS>:46413}{dimr}{testattr=test, shard_indexing_pressure_enabled=true}} from {integTest-0}{4JqEHFjJRzWzVgxMeBbERg}{x9HwXtcITlqbMfKhtQsuJg}{<IP_ADDRESS>}{<IP_ADDRESS>:46413}{dimr}{testattr=test, shard_indexing_pressure_enabled=true}", was "integTest-0   handleJoin: added join Join{term=1, lastAcceptedTerm=0, lastAcceptedVersion=0, sourceNode={integTest-0}{4JqEHFjJRzWzVgxMeBbERg}{x9HwXtcITlqbMfKhtQsuJg}{<IP_ADDRESS>}{<IP_ADDRESS>:46413}{dimr}{testattr=test, shard_indexing_pressure_enabled=true}, targetNode={integTest-0}{4JqEHFjJRzWzVgxMeBbERg}{x9HwXtcITlqbMfKhtQsuJg}{<IP_ADDRESS>}{<IP_ADDRESS>:46413}{dimr}{testattr=test, shard_indexing_pressure_enabled=true}} from [{integTest-0}{4JqEHFjJRzWzVgxMeBbERg}{x9HwXtcITlqbMfKhtQsuJg}{<IP_ADDRESS>}{<IP_ADDRESS>:46413}{dimr}{testattr=test, shard_indexing_pressure_enabled=true}] for election, electionWon=true lastAcceptedTerm=0 lastAcceptedVersion=0", was "integTest-0   handleJoin: election won in term [1] with VoteCollection{votes=[4JqEHFjJRzWzVgxMeBbERg], joins=[Join{term=1, lastAcceptedTerm=0, lastAcceptedVersion=0, sourceNode={integTest-0}{4JqEHFjJRzWzVgxMeBbERg}{x9HwXtcITlqbMfKhtQsuJg}{<IP_ADDRESS>}{<IP_ADDRESS>:46413}{dimr}{testattr=test, shard_indexing_pressure_enabled=true}, targetNode={integTest-0}{4JqEHFjJRzWzVgxMeBbERg}{x9HwXtcITlqbMfKhtQsuJg}{<IP_ADDRESS>}{<IP_ADDRESS>:46413}{dimr}{testattr=test, shard_indexing_pressure_enabled=true}}]}", was "integTest-0   handleJoinRequest: coordinator becoming LEADER in term 1 (was CANDIDATE, lastKnownLeader was [Optional.empty])", was "integTest-0   received a join request for an existing node [{integTest-0}{4JqEHFjJRzWzVgxMeBbERg}{x9HwXtcITlqbMfKhtQsuJg}{<IP_ADDRESS>}{<IP_ADDRESS>:46413}{dimr}{testattr=test, shard_indexing_pressure_enabled=true}]", was "integTest-0   elected-as-cluster-manager ([1] nodes joined)[{integTest-0}{4JqEHFjJRzWzVgxMeBbERg}{x9HwXtcITlqbMfKhtQsuJg}{<IP_ADDRESS>}{<IP_ADDRESS>:46413}{dimr}{testattr=test, shard_indexing_pressure_enabled=true} elect leader, _BECOME_CLUSTER_MANAGER_TASK_, _FINISH_ELECTION_], term: 1, version: 1, delta: cluster-manager node changed {previous [], current [{integTest-0}{4JqEHFjJRzWzVgxMeBbERg}{x9HwXtcITlqbMfKhtQsuJg}{<IP_ADDRESS>}{<IP_ADDRESS>:46413}{dimr}{testattr=test, shard_indexing_pressure_enabled=true}]}", was "integTest-0   received full cluster state version [1] with size [335]", was "integTest-0   no known cluster-manager node, scheduling a retry", was "integTest-0   scheduleNextElection{gracePeriod=500ms, thisAttempt=1, maxDelayMillis=200, delayMillis=555, ElectionScheduler{attempt=2, ElectionSchedulerFactory{initialTimeout=100ms, backoffTime=100ms, maxTimeout=10s}}} not starting election", was "integTest-0   cluster UUID set to [DQSK-4kLQUKgR97ho5GprA]", was "integTest-0   cluster-manager node changed {previous [], current [{integTest-0}{4JqEHFjJRzWzVgxMeBbERg}{x9HwXtcITlqbMfKhtQsuJg}{<IP_ADDRESS>}{<IP_ADDRESS>:46413}{dimr}{testattr=test, shard_indexing_pressure_enabled=true}]}, term: 1, version: 1, reason: Publication{term=1, version=1}", was "integTest-0 DQSK-4kLQUKgR97ho5GprA  publication ended successfully: Publication{term=1, version=1}", was "integTest-0 DQSK-4kLQUKgR97ho5GprA  successfully joined {integTest-0}{4JqEHFjJRzWzVgxMeBbERg}{x9HwXtcITlqbMfKhtQsuJg}{<IP_ADDRESS>}{<IP_ADDRESS>:46413}{dimr}{testattr=test, shard_indexing_pressure_enabled=true} with JoinRequest{sourceNode={integTest-0}{4JqEHFjJRzWzVgxMeBbERg}{x9HwXtcITlqbMfKhtQsuJg}{<IP_ADDRESS>}{<IP_ADDRESS>:46413}{dimr}{testattr=test, shard_indexing_pressure_enabled=true}, minimumTerm=0, optionalJoin=Optional[Join{term=1, lastAcceptedTerm=0, lastAcceptedVersion=0, sourceNode={integTest-0}{4JqEHFjJRzWzVgxMeBbERg}{x9HwXtcITlqbMfKhtQsuJg}{<IP_ADDRESS>}{<IP_ADDRESS>:46413}{dimr}{testattr=test, shard_indexing_pressure_enabled=true}, targetNode={integTest-0}{4JqEHFjJRzWzVgxMeBbERg}{x9HwXtcITlqbMfKhtQsuJg}{<IP_ADDRESS>}{<IP_ADDRESS>:46413}{dimr}{testattr=test, shard_indexing_pressure_enabled=true}}]}", was "integTest-0 DQSK-4kLQUKgR97ho5GprA  setting findPeersInterval to [1s] as node commission status = [true] for local node [{integTest-0}{4JqEHFjJRzWzVgxMeBbERg}{x9HwXtcITlqbMfKhtQsuJg}{<IP_ADDRESS>}{<IP_ADDRESS>:46413}{dimr}{testattr=test, shard_indexing_pressure_enabled=true}]", was "integTest-0 DQSK-4kLQUKgR97ho5GprA  received full cluster state version [2] with size [288]", was "integTest-0 DQSK-4kLQUKgR97ho5GprA  publication ended successfully: Publication{term=1, version=2}", was "integTest-0 DQSK-4kLQUKgR97ho5GprA  recovered [0] indices into cluster_state", was "integTest-0 DQSK-4kLQUKgR97ho5GprA  received diff cluster state version [3] with uuid [qgtxMduqRF6Y3kPUZ7FuPw], diff size [139]", was "integTest-0 DQSK-4kLQUKgR97ho5GprA  publication ended successfully: Publication{term=1, version=3}", was "integTest-0 DQSK-4kLQUKgR97ho5GprA  received diff cluster state version [4] with uuid [Y9UI1GWoRcSOUqG6B6KwvA], diff size [139]", was "integTest-0 DQSK-4kLQUKgR97ho5GprA  publication ended successfully: Publication{term=1, version=4}", was "integTest-0 DQSK-4kLQUKgR97ho5GprA  received diff cluster state version [5] with uuid [NtucF1HKSBSc68cYjA1uRg], diff size [139]", was "integTest-0 DQSK-4kLQUKgR97ho5GprA  publication ended successfully: Publication{term=1, version=5}"]
        at __randomizedtesting.SeedInfo.seed([956E2547DB08797:96DD3721CBF83233]:0)
        at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:18)
        at org.junit.Assert.assertThat(Assert.java:964)
        at org.junit.Assert.assertThat(Assert.java:930)
        at org.opensearch.qa.custom_logging.CustomLoggingConfigIT.lambda$testSuccessfulStartupWithCustomConfig$0(CustomLoggingConfigIT.java:61)
        at org.opensearch.test.OpenSearchTestCase.assertBusy(OpenSearchTestCase.java:1060)
        at org.opensearch.test.OpenSearchTestCase.assertBusy(OpenSearchTestCase.java:1033)
        at org.opensearch.qa.custom_logging.CustomLoggingConfigIT.testSuccessfulStartupWithCustomConfig(CustomLoggingConfigIT.java:59)

@svenso Would you need any help with this PR to get it across the finish line?


[Song select] Add the possibility to display the MAKER tag of a chart and the BPM (including (min-max)) of the chart on the song panel if set on the config screen

Added by #447


Chrome store version outdated

Hello, thanks for your extension that has saved many hours.

Chrome store lists the version at 2.4.
The repo and releases here list the version at 3.0.0.

Are there plans to put the 3.0.0 version onto Chrome Store?
On the 2.4 version we're currently experiencing an issue on Board view where no tickets are loading in. When we install manually from Github, the board view issue goes away. It would be sweet to get the 3.0.0 version into Chrome store and avoid the "non-store" extension installation.
Additional note, getting a warning in the Chrome extension panel about manifest.json versioning. "Manifest version 2 is deprecated, and support will be removed in 2023. See https://developer.chrome.com/blog/mv2-transition/ for more details." Still works at this point but seems it may stop working at some point in the near future.
Thank you.

Thank you! Most excellent. Appreciate your time and effort on this very much.


Better Russian

Now translation more clear, shorter and advanced

I think categorizing is nice but I think the template should be updated to match. Also "Advanced player skin customization" is missing from the template.


Signing modal consistency follow up

I think it's over drop and we can push it to beta so we can collectively test out
Otherwise it would needs consistently maintain conflicts

If @exezbcz spot something can report or close this one
Originally posted by @yangwao in https://github.com/kodadot/nft-gallery/issues/9002#issuecomment-1911723289

nothing found yet. Tested transfer, listing, buying


versatile-data-kit: postgresql embedded

For embedded DB for control-service metadata storage, we need to use the Bitnami-available chart of PostgreSQL.
Added postgresql values.yaml configurations. In case postgresql.enabled is true, PostgreSQL embedded is being prioritized for usages. It is also the default embedded database.
Testing Done: verified with helm template --debug, also postgresql artifacts with helm install
Signed-off-by: ivakoleva<EMAIL_ADDRESS>

Changing the default database would be a breaking change. Any user upgrading would be broken.
But also why do we need to add it in the helm chart? If users want they are of course free to setup Postgres and connect to it. But not sure why do we need special support for that?

Changing the default database would be a breaking change. Any user upgrading would be broken.
But also why do we need to add it in the helm chart? If users want they are of course free to setup Postgres and connect to it. But not sure why do we need special support for that?

(1) Bitnami packages are compliant and secure, so the change improves security of the default recommended setup we provide
(2) Bitnami repository has been introduced in the earliest initial chart commit by design
(3) publishing VDK to Bitnami is something initiated a year ago yet to be completed -> introducing (default) Bitnami embedded dependency is on the right track in that direction
It is breaking change, yet I don't think as a result-anything will be actually broken, I think it will be sufficient to release as any other major change by bumping the version, and think about data migration in case someone bumps issue with upgrading and migrating
I was thinking to create a separate PR for the default setup switching to Postgres, however didn't split it so I can test and verify easier.

Changing the default database would be a breaking change. Any user upgrading would be broken.
But also why do we need to add it in the helm chart? If users want they are of course free to setup Postgres and connect to it. But not sure why do we need special support for that?

(1) Bitnami packages are compliant and secure, so the change improves security of the default recommended setup we provide (2) Bitnami repository has been introduced in the earliest initial chart commit by design (3) publishing VDK to Bitnami is something initiated a year ago yet to be completed -> introducing (default) Bitnami embedded dependency is on the right track in that direction
It is breaking change, yet I don't think as a result-anything will be actually broken, I think it will be sufficient to release as any other major change by bumping the version, and think about data migration in case someone bumps issue with upgrading and migrating
I was thinking to create a separate PR for the default setup switching to Postgres, however didn't split it so I can test and verify easier.

CockroachDB is widely used and I am not convinced it's less secure.
It's possible that moving to a bitnami versioned chart is the right direction ( the alternative is to push Cockroachdb in bitnami.)
But changing the default DB we recommend users to use and all our automated tests test against is a rather major decision and requires more in-depth research and pros/cons analysis. I am not sure we should abandon testing against Cockroach db altogether as all the users we know about, use CockroachDB.
As there's currently no business need (for now we have paused any work on Bitnami integration), I see no need to try that now.

CockroachDB is widely used and I am not convinced it's less secure.
It's possible that moving to a bitnami versioned chart is the right direction ( the alternative is to push Cockroachdb in bitnami.)
But changing the default DB we recommend users to use and all our automated tests test against is a rather major decision and requires more in-depth research and pros/cons analysis. I am not sure we should abandon testing against Cockroach db altogether as all the users we know about, use CockroachDB.
As there's currently no business need (for now we have paused any work on Bitnami integration), I see no need to try that now.

Bitnami's charts are compliant, oppositely to CockroachDB custom chart. Bitnami's repository has been added since the initial versatile-data-kit commit by design, therefore fundamental.
Do you have any concern about the transition?
I think the business need had already manifested by the PR creation in the OSS repo; I don't mind to add PostgreSQL support and add the default switch into a separate PR. In fact, I shared earlier, I merged into one to facilitate testing.

CockroachDB is widely used and I am not convinced it's less secure.
It's possible that moving to a bitnami versioned chart is the right direction ( the alternative is to push Cockroachdb in bitnami.)
But changing the default DB we recommend users to use and all our automated tests test against is a rather major decision and requires more in-depth research and pros/cons analysis. I am not sure we should abandon testing against Cockroach db altogether as all the users we know about, use CockroachDB.
As there's currently no business need (for now we have paused any work on Bitnami integration), I see no need to try that now.

Bitnami's charts are compliant, oppositely to CockroachDB custom chart. Bitnami's repository has been added since the initial versatile-data-kit commit by design, therefore fundamental.
Do you have any concern about the transition?
I think the business need had already manifested by the PR creation in the OSS repo; I don't mind to add PostgreSQL support and add the default switch into a separate PR. In fact, I shared earlier, I merged into one to facilitate testing.

I don't mind merging the postgres support.
But changing the default DB from cockroachDB to Postgres is something I am concerned about.
I don't think there's a pressing need. But it's possible I am not seeing something (it won't be my first time).
If you feel so, make a meeting. I'd like Miro to be included as he is Control Service Guru currently.

Please use conversation mode, it's easier to have context and reply.

I don't mind merging the postgres support.
But changing the default DB from cockroachDB to Postgres is something I am concerned about.
I don't think there's a pressing need. But it's possible I am not seeing something (it won't be my first time).
If you feel so, make a meeting. I'd like Miro to be included as he is Control Service Guru currently.

I've made a minor change switching back to CockroachDB default. PostgreSQL support is what's important, switching it to default is a bigger discussion, that won't be solved by this PR.

Please use conversation mode, it's easier to have context and reply.

What is conversation mode? I use "Quote Reply" option in github to make easier to track conversation ?


Routes.Append

nice, you now made it easy to modify hangfire internal css/js resources.
made use of that (DashboardRoutes.Routes.Append) to finally make a dark themed dashboard
available here: https://github.com/vip32/Hangfire.Dashboard.Dark

Great, glad it helped :)
A few thoughts:

Circles around badges are hardly seen.
White text seems too white. I'd rather dim it a little, so it would be more comfortable to read.

But that's just my taste :)

thx for the feedback. colors now have been adjusted a bit (circles/whites).


Documentation: CPU usage

It would be good to state how much of the raspi CPU is available for the user. When I checked with htop (so a very subjective measurement) it seems that >60% are used by the basic services. If the turtlebot4 service is not running, this is 0%. The documentation states that running computation heavy tasks off-board is better (e.g. navigation stack). That can work, but in a classroom scenario with >10 robots the network could then become a bottleneck (to be confirmed). I wish the basic packages could just be more sensitive with their CPU usage. Also logging in over ssh and working with the command line (tab completion) on the robot is painfully slow. This is definitely lowering the level of joy one can get when working with this robot that way.

As long as there is a subscriber for the topic, the data is being sent over the network, even if both the publisher and subscriber are on the same machine. For navigation, you have the nav2 stack publishing data, and RVIZ subscribing. For the camera, the OAK-D node is publishing and turtlebot4_diagnostics is subscribing. If you disable diagnostics and don't have any other nodes subscribed to the image topic, you should get improved network performance (I have not tested this though).
There are plans for using shared memory to reduce network usage but I don't believe it is implemented yet for CycloneDDS. https://answers.ros.org/question/361783/is-it-possible-to-use-shared-memory-as-ipc-on-ros2-foxy/

Closing because of no activity. Feel free to reopen.


auditpol set documentation has invalid command parameters in examples

Some of the command examples in the "Examples" section use the parameter '/category:detailed Tracking' (e.g.- auditpol /set /user:mikedan /category:detailed Tracking /include /success:enable).
This is incorrect syntax for this parameter and will result in "The parameter is incorrect." error. The parameter should be '/category:"Detailed Tracking"' in order for this to work.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 4db7a055-a5ca-e6f9-5786-99d0f325e708
Version Independent ID: eb61d370-6e32-6776-d0bc-17197bacf84f
Content: auditpol set
Content Source: WindowsServerDocs/administration/windows-commands/auditpol-set.md
Product: windows-server
Technology: windows-commands
GitHub Login: @JasonGerend
Microsoft Alias: jgerend

We hugely appreciate your contribution, feedback, and support to our technical documentation.
We’ve phased out GitHub Issues on this repository as the feedback mechanism for content and have replaced it with a new feedback system. For more information see, Content User Feedback. As part of this rollout, we are migrating your issue where our team will use your comments to improve the documentation experience. Unfortunately, this does mean you won't be able to access this issue after the migration is complete.
All issues will be migrated by Thursday 29th August 2024.
Once again, thank you for your valuable feedback, we hope you’ll continue to contribute using our new feedback system.


Subliminal is looking for maintainers!

Hi 👋
As proven by the long time I did not contribute to this project and although I with it was not the case, I don't have the time to maintain Subliminal anymore 😢
I'd be happy to add maintainers to this project or move it to an organization in GitHub so it can be given the care it deserves and continue helping everyone getting access to subtibles.
If you are interested, please answer in this issue! I'll provide access to the repo and releases workflows. There are many ways to contribute to this project:

Merging pull requests
Creating new releases
Fixing bugs in the code
Upgrading the test suite
Full rewrite of the multi-threaded engine in asyncio for the braves

Writing Subliminal was a way for me to sharpen my skills and share it with the community, I'm glad it was helpful to others as well and helped automate such a boring task! 🫶 The fact that I now rarely consume media and/or don't need subtitles had me less interested in maintaining it.
In case I don't find any maintainers by 2024 July 1st, I'll be archiving this repository and put a non-maintained notice in the README.

hi! as a frequent user of subliminal, while i definitely couldn't be the sole maintainer, i'd like to offer to help out a little with bringing the project up to date and review the merge requests whenever i have some free time :)

@ptrcnull thanks! You're now a collaborator on the repository 🙏

Hello! I have not used subliminal for a long time but I would like to help maintaining it also.

How do you plan to contribute @getzze? Through code changes and PRs? Or issues?

I can help improving the code, adding type annotation to start with and updating to modern build system, and reviewing PR. I would need to get used to the code again before being able to solve issues though.
I contributed to the refiners module back in the day :)
On 3 April 2024 11:52:09 GMT+01:00, Antoine Bertin @.***> wrote:

How do you plan to contribute @getzze? Through code changes and PRs? Or issues?
--
Reply to this email directly or view it on GitHub:
https://github.com/Diaoul/subliminal/issues/1064#issuecomment-2034239477
You are receiving this because you were mentioned.
Message ID: @.***>

Done! 🚀

@getzze do you have any contact info? IRC/Matrix/XMPP, or even Discord? i have some work started, but never got around to polishing it so i can publish it, and it would be useful to coordinate work :)

@ptrcnull I contacted you via Matrix. Do you think it makes sense to open a public matrix room for subliminal ?

I'd a public room is a good idea, especially if there would be more people contributing at some point

Hello,
I would also like to be added as maintainer.
I can review / test merge request, participate in bug fixes and help with the new release, and can also facilitate the creation of a discord room for developers.
I would also be able to maintain the docker variant (the current version doesn't work anymore due to the removal of unrar from alpine base image).
I use subliminal since long (thanks for the project!), mostly via the CLI in docker container.

and can also facilitate the creation of a discord room for developers

I suppose a Discord server would be more convenient for most users; platforms like Matrix still lack in usability 😕

I created a Discord channel here.
Happy to get some help setting it up correctly :pray:


fix: package name rules

Description
fix: package name rules
Type of change

[x] Bug fix

How has this been tested

[x] Unittest
[ ] Others:

Checklist:

[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Let's make the world better✨😋🐍🌎

Codecov Report

Merging #31 (c80f165) into main (f6d4475) will increase coverage by 0.19%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #31      +/-   ##
==========================================
+ Coverage   93.98%   94.17%   +0.19%
==========================================
  Files          21       21
  Lines         582      601      +19
  Branches       34       35       +1
==========================================
+ Hits          547      566      +19
  Misses         23       23
  Partials       12       12

Impacted Files
Coverage Δ

pypj/cui.py
83.01% <100.00%> (ø)

pypj/exception.py
94.44% <100.00%> (+0.32%)
:arrow_up:

pypj/file_path.py
95.83% <100.00%> (ø)

pypj/main.py
97.67% <100.00%> (+0.11%)
:arrow_up:

pypj/setting.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef5c303...c80f165. Read the comment docs.


Fatal error: Uncaught Error: Class 'HaoZiTeam\ChatGPT\V2' not found

Hi
I need some help. I get this error:
Fatal error: Uncaught Error: Class 'HaoZiTeam\ChatGPT\V2' not found in /var/www/vhosts/xxx/index.php:9 Stack trace: #0 {main} thrown in /var/www/vhosts/xxx/chatapi.xxx.xx/index.php on line 9
My simple php code:
<?php

use HaoZiTeam\ChatGPT\V2 as ChatGPTV2;

$chatGPT = new ChatGPTV2('sk-xx');
$chatGPT->addMessage('You are ChatGPT, a large language model trained by OpenAI. Answer as concisely as possible.', 'system');
$chatGPT->addMessage('Hello, how are you?', 'user');
$chatGPT->addMessage('I am fine, thank you.', 'assistant');

$answers = $chatGPT->ask('What did I ask you before?');
foreach ($answers as $item) {
    print_r($item);
}

?>

The line that is in error is :
$chatGPT = new ChatGPTV2('sk-xx');

I got it sorted out. thanks


fully document how to get from common output to squirrelbox supported formats

and annotate the included data with software/pipeline

download link in each data file


Add SP 976 to Omit List

Whereas SP 976, PTO Governor State, is required in CARB regulations for optional equipment. When PTO is not supported, SP 976 is provided as NA. This breaks the assumption that supported SPs should not be received as NA (FF).
Moreover, There is no indication to disambiguate, whether the correct expectation is for Off, or NA in Part 1 and 2.
Considering this, assessment of SP 976 displays is intractable.  The addition of SP 976 provides an immediate remedy.

PACCAR Side-by-side Issue 3
FAIL: <IP_ADDRESS>.a - SPN 976 was received as NOT AVAILABLE from Engine #1 (0)
FAIL: <IP_ADDRESS>.a - SPN 976 was received as NOT AVAILABLE from Engine #1 (0)
Explanation – Spec/Tool Issue?
Not every truck is equipped with a PTO. There must be exceptions added to this. If a truck does not have PTO then it is going to report “NOT AVAILABLE”.

This proposal will also resolve
PACCAR issue 4
FAIL: <IP_ADDRESS>.a - No DS response for PGN 65265 from Engine #1 (0)
FAIL: <IP_ADDRESS>.a - No DS response for PGN 65265 from Engine #1 (0)
Explanation – Spec/Tool Issue?
Why is the tool sending a destination specific request for CCVS message (contains SPN 84 and SPN 976)? The CCVS message is broadcasted every 100ms
And PACCAR issue 9
Warning: Late BAM response:  19:20:39.8578 18FEF127 [8] C4 FF FF 00 00 00 1F F0
Warning: Late BAM response:  19:20:39.8607 18FEF131 [8] F7 FF FF CF FF FF FF FF
Warning: Late BAM response:  19:20:39.8645 0CFEF100 [8] F7 00 00 03 00 00 FF FF
Warning: Late BAM response:  19:20:39.9566 18FEF127 [8] C4 FF FF 00 00 00 1F F0
Warning: Late BAM response:  19:20:39.9602 18FEF131 [8] F7 FF FF CF FF FF FF FF
Warning: Late BAM response:  19:20:39.9645 0CFEF100 [8] F7 00 00 03 00 00 FF FF
Warning: Late BAM response:  19:20:40.0567 18FEF127 [8] C4 FF FF 00 00 00 1F F0

6.1.26 Data Stream Support Verification
<IP_ADDRESS> Actions
a.  Create a list of expected SPNs and PGNs from the DM24 response, where the data stream support bit defined in SAE J1939-73 5.7.24 is 0. Omit the the following SPNs (588, 976, 1213, 1220, 12675, 12730, 12783, 12797) which are included in the list. Omit any remaining SPNs that map to multiple PGs. Display the completed list noting those omitted SPNs and supported SPNs as ‘broadcast’ or ‘upon request’.
b. Gather broadcast data for all SPNSPs that are supported for data stream in the OBD ECU DM24 responses.
c. Gather/timestamp each parameter at least three times to be able to verify frequency of broadcast.

976 is on the omit list now.  Corrected 6.2.17 to match 6.1.26 too.
a. Create a list of expected SPNs and PGNs from the DM24 response, where the data stream support bit defined in SAE J1939-73 5.7.24 is 0. Omit the the following SPNs (588, 976, 1213, 1220, 12675, 12730, 12783, 12797) which are included in the list. Omit any remaining SPNs that map to multiple PGs. Display the completed list noting those omitted SPNs and supported SPNs as ‘broadcast’ or ‘upon request’.
b.	Gather broadcast data for all SPs that are supported for data stream in the OBD ECU DM24 responses.
c.	Gather/timestamp each parameter at least three times to be able to verify frequency of broadcast


[dashboard] should use forceV2Edit property name

should use forceV2Edit property name
fix logic for show/hide save button

@williaster

Codecov Report

Merging #5362 into master will not change coverage.
The diff coverage is 0%.

@@           Coverage Diff           @@
##           master    #5362   +/-   ##
=======================================
  Coverage   61.31%   61.31%
=======================================
  Files         369      369
  Lines       23497    23497
  Branches     2715     2715
=======================================
  Hits        14407    14407
  Misses       9078     9078
  Partials       12       12

Impacted Files
Coverage Δ

...rc/dashboard/deprecated/v1/components/Controls.jsx
0% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a17f714...d1049a4. Read the comment docs.


Fixes #7, cutoff distance

I've added a new parameter to the knn() function for an optional cutoff distance, as discussed in #7.

Looks great, thanks!


UI too small in some environments

On my PC, the UI of the MikuMikuWorld application is too small and difficult to operate. (see attached file).

OS: Windows 11 Pro
Display: 3840 x 2160 (60Hz)
Display magnification: 225%

Fixed with 789e677. I'll publish a new release with the fix soon


question about issue amount limit when I issue a new rgb asset

Hi there,  when I want to issue a new rgb asset, there are four parameters: amount, ticker, name, and precision. I have a question from our test engineer: are there any limits for the issue amount, such as it can not surpass a threshold?
And I found no interface about how to get the maximum issue amount here.

Hi, seems like you're talking about a NIA asset.
NIA schema (RGB20 interface) has a maximum supply of 2^64. Trying to issue an asset that exceeds that limit will return a TooHighIssuanceAmounts error.


Integrate Flex op lowering into TFLite lowering

Included the necessary passes for importing a tflite flatbuffer that includes
flex operations. This includes tensorflow-to-tosa with shape inference and a
test to verify.

I'm ok for landing this and seeing what the impact is on build/binary size
and adjusting from there. We may ultimately want to extend the tf importer
to do TFLite too and drop the TFLite one.
On Mon, Nov 8, 2021, 5:31 PM Geoffrey Martin-Noble @.***>
wrote:

@.**** approved this pull request.
In integrations/tensorflow/iree_tf_compiler/TFL/test/flex_ops.mlir
https://github.com/google/iree/pull/7550#discussion_r745219345:

@@ -0,0 +1,10 @@
+// RUN: iree-opt-tflite -split-input-file -iree-tflite-import-pipeline %s | IreeFileCheck %s

+// CHECK-LABEL: @test_flex_ops
+func @test_flex_ops(%arg0: tensor<?x2x64xf32>, %arg1: tensor<1x1x64xf32>) -> tensor<*xf32> {

// CHECK: %[[ADD:.+]] = "tosa.add"(%arg0, %arg1) : (tensor<?x2x64xf32>, tensor<1x1x64xf32>)
// CHECK: %[[CAST:.+]] = tensor.cast %[[ADD]]
// CHECK: return %[[CAST]]
%0 = "tfl.custom"(%arg0, %arg1) {custom_code = "FlexAddV2", custom_option = opaque<"tfl", "0x054164645632002E120541646456321A001A002A070A01541202300132180A16726573696475616C5F626C6F636B5F2E5F302F616464000237311414042801"> : tensor<63xi8>} : (tensor<?x2x64xf32>, tensor<1x1x64xf32>) -> tensor<*xf32>

Yeah :-/ Thanks for adding a comment. Any chance it could point to a
specific model file or something?
In integrations/tensorflow/iree_tf_compiler/iree-import-tflite-main.cpp
https://github.com/google/iree/pull/7550#discussion_r745220036:

@@ -66,6 +67,8 @@ int main(int argc, char **argv) {
registry.insertquant::QuantizationDialect();
registry.insert<StandardOpsDialect, mlir::arith::ArithmeticDialect>();

RegisterAllTensorFlowDialects(registry);

We don't build iree-import-tflite as part of benchmarking. Just
iree-import-tf. The integrations build builds both. It might be nice to
split them out, but then again that's one more level of complication. I
feel like the real answer would be layering this in such a way that we
could extract the flex ops in a layer on top and then feed it to a normal
tool. I'm fine with whichever option you decide
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/google/iree/pull/7550#pullrequestreview-800763669,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AADYVABJTFLFT2EROU6BTQDULB2XTANCNFSM5HMUSL6Q
.

I'm ok for landing this and seeing what the impact is on build/binary size and adjusting from there. We may ultimately want to extend the tf importer to do TFLite too and drop the TFLite one.

Yeah I think if the tflite one depends on TF then keeping two separate binaries will lose its usefulness


Remove LUW checks that are not related to DB2 for i

Related to #28.

I know we're not really supporting LUW except by accident, just using it for smoke tests in CI, but would this fatally break it, or just make it use not necessarily the right behaviour?
FWIW, once upon a time, ibm_db2 was a lot more divergent on LUW vs. i too - the unit tests were noticeably different. The behaviour seems to have been more unified since i 6.1.

might as well merge this since as you say, upstream has an LUW driver and this keeps it working enough just to make tests happy (until we can do that on i reasonably)


API for fantasyally.com?

Hi there.
Is there a public API for fantasyally.com? I am in the works of creating an app for Android that will make use of the data returned by your site. Your docs doesn't seem to explain anything about a publically accessible API.
Regards

Hey Jacky,
Unfortunately the only endpoint at www.fantasyally.com is http://www.fantasyally.com/news. The project never really got stable enough to be put into production and should be run locally. Check out some of the test cases to get an idea of the endpoints you have access you.
If you want to browse the test site check it out at http://ffpa-dev.herokuapp.com. Hope this serves as a good starting point! Good luck!

Vijay


Add a license

Hi, this game looks really cool. :smile:
Would you be willing to add a license? It helps people know what you're okay with in terms of using your code.
Thanks!

Thank you for notifying me of this I have now added a GNU License 3.0 for the code and related pieces


Use latest python-magnumclient

Do NOT include any confidential information, this issue will be created on a public repo
This section is completed by the issue reporter
On which version(s) do you encounter this issue?
Please provide the output to 'git describe --all' for  all deployments where you have confirmed it occurs
.
root@infra01:/opt/rpc-openstack/rpcd# git describe --all
r13.0.3
What type of issue is this? Please tick the appropriate box.

[x] bug - existing functionality that does not work for you as documented
[ ] feature - new functionality that you would like to see added

What is the expected behavior?
python-magnumclient 2.3.0 installed
What is actually happening?
Our repo container only has python-magnumclient 2.0.0 which is missing the magnum cluster-* commands. I also ran into errors with service type and 2.0.0.
root@infra01:~# curl -s http://<IP_ADDRESS>:8181/os-releases/13.3.6/ | grep magnum
python_magnumclient-2.0.0-py2.py3-none-any.whl

What were you attempting to do when you encountered this error (give as much detail as possible)?
Trying to create magnum templates and clusters
How can we reproduce this issue?
Install magnum and pip install python-magnumclient, verify it's 2.0.0 and notice it's missing the cluster-* commands. Also try creating a template/cluster.
How can we verify your issue is addressed?
python-magnumclient 2.3.0 is in our repo
If you are using or know of a workaround please describe the necessary steps?
pip --isolated install python-magnumclient

However, because of other dependencies this breaks openstack CLI as far as I can tell.
What is your evaluation on the importance of this issue, and why?
Low, I don't think we're supporting Magnum yet

This section is completed during the issue resolution process. If you are reporting an issue, please do not modify the section below.
Which branches are impacted by this issue?
Remove branches that are not impacted.
For each pull request, update the branch line to reference it.

[ ] master

Upgrade impact. Consider the impact on moving between major, minor and patch releases.

[ ] This change does not impact upgrades
[ ] This change addresses a potential upgrade impact
[ ] The upgrade impact is being tracked by another issue.

The issue tracking the upgrade impact is:
Testing impact

[ ] An issue/pull-request has been create or exists to track the testing gap, and is referenced below
[ ] This change includes additional testing
[ ] This change is tested by the existing setup

Additional testing links:
Release note

[ ] This change includes a release note.
[ ] This change does not require a release note.

Doc Impact
Does your change require documentation?

[ ] Yes, and I submitted an issue to Docs issues
[ ] Yes, and I contributed a documentation patch to docs-rpc
[ ] No documentation required for this change

Additional documentation links (please add links if you have ticked yes):

FYI - @chrishultin

Closing as magnum is no longer on the plan


chore(deps): update to backstage 1.23

Description
Please explain the changes you made here.
Which issue(s) does this PR fix

Fixes https://issues.redhat.com/browse/RHIDP-1329
Fixes https://issues.redhat.com/browse/RHIDP-1303

PR acceptance criteria
Please make sure that the following steps are complete:

[ ] GitHub Actions are completed and successful
[ ] Unit Tests are updated and passing
[ ] E2E Tests are updated and passing
[ ] Documentation is updated if necessary (requirement for new features)
[ ] Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

building downstream in https://gitlab.cee.redhat.com/rhidp/rhdh/-/pipelines/7568925


Cylon effect gets frozen/sends cursor to top-right of screen

I have a dual-display setup:

When I use the Cylon visual effect, I've noticed several issues:

When I enter the notch area, the cylon animation freezes and sends my cursor to the top right corner of my non-MacBook Pro primary display
Once the cylon effect is frozen, a second cylon animation is triggered:

I'm pretty sure this is related to issue #1 - some monitor configurations break the animations because the "we're under the notch" calculation is much harder.

I'm pretty sure this is related to issue #1 - some monitor configurations break the animations because the "we're under the notch" calculation is much harder.

Could be...! I noticed this behavior on my MacBook Pro display though — not on my Pro XDR Display. I suppose if you're calculating a collision rectangle to determine where to show the effect, then indeed, perhaps the presence of a second display somehow confuses the coordinate system?
It would be clarifying if you could explain what the Cylon effect is supposed to do? Does it move the cursor somewhere if you enter the notch area?

Likely related to #5

This issue should be fixed in the latest TestFlight build: https://testflight.apple.com/join/pIGViV74


i18n example not working as expected

hey guys,
tnx a lot for all this great work with nuxt!
looking at the multilanguage example i18n with middleware, i get some strange behavior:
after cloning the nuxt.js repo, cd examples/i18n, npm install, npm run dev, the page is showing on localhost:3000 - but unfortenetly this route shows a 404-Error-Page below the working nav.
on localhost:3000/about it shows the home template - not the about template??
the french version works.  localhost:3000/fr/ shows the french home, localhost:3000/fr/about shows the french about-template.
on the demo page https://i18n.nuxtjs.org/ it works fine.
osx 10.11.6
node v7.4.0
latest chrome (german)
does ne1 else have this problem?
also i would like to know if it is possible to translate the french routes/slug?
Tnx, Dennis

Hi,
This is due to the new release 0.9.9 and the routes order patch, so the example was up to date.
I have updated the example now, it should work with the new example.


Outage-db-configuration-error

test merge error

Hi Joe!
I believe you wanted to merge the outage branch into the main branch of your fork, not in the original repository.
There's a Using GitHub Web Interface: Create a pull request link on the READ.ME, if you click it on your fork, it will open the pull request interface with the right settings.


[django] Django 3.2 released

Ref: https://docs.djangoproject.com/en/3.2/releases/3.2/ https://www.djangoproject.com/download/#supported-versions

Everything okay -> merge


Implement  declaration of array

Required support for Java declarations:

[x] double[ ] arr1 = new int[5];
[x] int[ ] arr2 = {5,4,3,2,1};
[x] double[ ][ ] arr3 = new int[3][5];
[x] int[ ][ ] arr4 = {{1,2,3},{4,5,6},{7,8,9}};

Commits:
9b67da2de981a48fec97818f04492dbe227dbad7
e46927802b3274a949e2df7d3a9bfc2562b990b8


docs(node): added note for provideplugin in node global

Added a note for covering query about global variables required by external modules
ref https://github.com/webpack/webpack/issues/10668

Thanks!


Terragrunt versions 0.67.0+ break plan output

Newer versions of Terragrunt will cause plans to hot show up see screen shot here:

This looks to be related to the cleanupTerraformOutput in execution.go expecting a different format of log output for Terragrunt, which was changed in 0.67.0+
https://github.com/gruntwork-io/terragrunt/issues/3367
In order to have the logs look like they used to the following additional environment variables must be passed into the command.
https://terragrunt.gruntwork.io/docs/reference/cli-options/#terragrunt-forward-tf-stdout
It looks like a new flag needs to be added but conditionally on version upgrade.  Not sure I agree with them not making that a 1.0.0 release as it seems breaking to things like digger.

I fixed this issue in the most recent release of digger

It's fixed in this PR https://github.com/diggerhq/digger/pull/1801

oh crap awesome


Make package names consistent under test/core

[trickle] No significant performance differences

[microbenchmarks] No significant performance differences


During Development, QuarkusConfigurationService Is Not Available.

When using ./gradlew quarkusDev to start the operator, the following error appears.  It consistently happens at startup.
2023-05-16 08:37:33,187 WARN  [io.qua.ope.run.dev.ControllersSupplier] (Quarkus Main Thread) Couldn't retrieve controllers information because QuarkusConfigurationService is not available: java.lang.NullPointerException: Cannot invoke "io.javaoperatorsdk.operator.Operator.getRegisteredControllers()" because the return value of "io.quarkus.arc.InstanceHandle.get()" is null
        at io.quarkiverse.operatorsdk.runtime.devconsole.ControllersSupplier.get(ControllersSupplier.java:26)
        at io.quarkiverse.operatorsdk.runtime.devconsole.ControllersSupplier.get(ControllersSupplier.java:17)
        at io.quarkus.vertx.http.runtime.devmode.DevConsoleRecorder.addInfo(DevConsoleRecorder.java:33)
        at io.quarkus.deployment.steps.DevConsoleProcessor$runtimeTemplates308161071.deploy_0(Unknown Source)
        at io.quarkus.deployment.steps.DevConsoleProcessor$runtimeTemplates308161071.deploy(Unknown Source)
        at io.quarkus.runner.ApplicationImpl.doStart(Unknown Source)
        at io.quarkus.runtime.Application.start(Application.java:101)
        at io.quarkus.runtime.ApplicationLifecycleManager.run(ApplicationLifecycleManager.java:111)
        at io.quarkus.runtime.Quarkus.run(Quarkus.java:71)
        at io.quarkus.runtime.Quarkus.run(Quarkus.java:44)
        at io.quarkus.runtime.Quarkus.run(Quarkus.java:124)
        at io.quarkus.runner.GeneratedMain.main(Unknown Source)
        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
        at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.base/java.lang.reflect.Method.invoke(Method.java:568)
        at io.quarkus.runner.bootstrap.StartupActionImpl$1.run(StartupActionImpl.java:104)
        at java.base/java.lang.Thread.run(Thread.java:833)
        Suppressed: java.lang.NullPointerException: Cannot invoke "io.quarkus.arc.InjectableBean.getScope()" because "this.bean" is null
                at io.quarkus.arc.impl.AbstractInstanceHandle.destroy(AbstractInstanceHandle.java:64)
                at io.quarkus.arc.InstanceHandle.close(InstanceHandle.java:69)
                at io.quarkiverse.operatorsdk.runtime.devconsole.ControllersSupplier.get(ControllersSupplier.java:24)
                ... 17 more

Gradle Version: 8.1.1
Quarkus Version: 3.0.3.Final
operator-sdk version: 6.0.2

This error appeasers to go away if I remove any reference to quarkus-universe-bom.

Do you have any details on when this happens? I had seen this problem a few times at some point but I haven't seen it in a while in my testing.

This error appears to go away if I remove any reference to quarkus-universe-bom.

That's weird. By the way, you shouldn't need to use the quarkus-universe-bom in your operator. Any particular reason why you include this dependency?

Any particular reason why you include this dependency?

Its looking like its getting brought in via a transitive dependency. It looks like something I can sort out on my end.

Any particular reason why you include this dependency?

Its looking like its getting brought in via a transitive dependency. It looks like something I can sort out on my end.

OK, let me know how it goes.

I've found the affected internal dependency. Sorry for the confusion!


ConfigurationChange test flaky on Win2008

@victorhurdugaci
https://github.com/aspnet/Logging/blob/b7bcb771676e2ff8a7dba73ce4f4260f80bb72f9/test/Microsoft.Extensions.Logging.AzureWebAppDiagnostics.Test/LogConfigurationReaderTests.cs#L120

Logs link?

http://aspnetci/viewLog.html?tab=buildLog&logTab=tree&filter=debug&expand=all&buildId=127162#_focus=9727

Although this affects win2008 consistently, it also seems to fail on win 2012 as well. http://aspnetci/project.html?projectId=XPlat&tab=testDetails&testNameId=-3904181696098395131


ARROW-16305: [C++] Missed reference to ARROW_ENGINE during the rename

I had not thought to check .travis.yml.  The errors appeared to be completely unrelated and I'm still not entirely sure why we receive them.  However, in the past, we were not building parquet on the s390x build.  With ARROW-16158 we accidentally enabled parquet on this build.  This change should disable ARROW_SUBSTRAIT (and transitively, ARROW_PARQUET) so that the behavior is the same as it was before.

@kou @kszucs Sorry for the trouble, this should get Travis back on track.

No worries, thanks for noticing the problem!


LUIS region & QnA maker subscription key not present when it's been added via pop-up

Describe the bug
When adding LUIS key + region, and then QnA maker key in the next step. Only my LUIS key shows in the settings page.
Version

Expected behavior
Expect the QnA keys to be present plus LUIS region.
Screenshots

Thanks for the report @Quirinevwm! This is a dupe of #6822  that should be fixed momentarily.


fix: ignore bold case and add all line to result

Because

we want to support English when transform pdf to markdown
we do not support bold in the current version

This commit

remove loop to insert character but a line

e2e test

sample (1).pdf


Linux wheels

I saw there is already a ubuntu wheel, but came across this, and thought it might be useful:
https://github.com/pypa/manylinux

Looks interesting. I will definetely at least test if I can get the manylinux builds working (would be great for other than Ubuntu users).
The current builds for Windows and Ubuntu are now passing, but I haven't pushed the results yet to PyPI (setup.py is incomplete and I have to do some cleaning). Next phase is to get OS X builds working in Travis, and after that I will propably test the manylinux thing.


go generate panics (only have package main though)

Hi, I really like the idea of auto-generating documentation, so thanks for creating this project!
However, I cannot generate the documentation, as go generate panics.
I am using caarlos0/env.
I have a few .go files, but for simplicity, all are in package main.
This is config.go:
package main

import (
	"errors"
	"time"
	"github.com/caarlos0/env"
)

const (
	//Environment values, used for logger configuration
	EnvironmentProduction  = "production"
)

// Error messages
var (
	ErrNoRowsFound           = errors.New("no rows found")
)

//go:generate envdoc -output environments.md
type appconfig struct {
	// Port the application will listen on inside the container
	Port int `env:"PORT" envDefault:"8080"`
       // some more stuff I omitted here
}

func (c *appconfig) ParseEnvVariablesIntoConfigStruct() error {
	if err := env.Parse(c); err != nil {
		return err
	}
	return nil
}

I get this error:
panic: expected type node root child, got nodeField ()
When I uncomment the method at the end, I at least get no errors, and the environments.md file is generated, but only contains
# Environment Variables, nothing else.
go version is 1.22.2

Thanks for reporting! I'll investigate this issue

@schleicherse this should be fixed in v0.2.3 version.


Reclassification of class methods in PMMatrix and PMSymmetricMatrix

Yes, I think we cna merge this. either way if the test is failing is not related to this PR


Use symbols instead of strings for #send

A tiny performance enhancement. Using symbol interpolation instead of strings is about 50% faster when being used with #send. The overall enhancement is very small since these methods are being called relatively rarely.

I'm happy to merge it, but I'll have to add a side note that it's good to send benchmarks attached to code that is supposed to change performance in any way.
Thank you for your contribution! :)

Thanks! Apologies for the lack of benchmarks. I excluded them because running the gem's test suite showed no meaningful change. However, here are the benchmarks I used to convince me to make the change.
require 'benchmark'

Benchmark.bm do |bm|
  bm.report('string') { 100_000_000.times { Object.send( "to_#{'s'}") } }
  bm.report('symbol') { 100_000_000.times { Object.send(:"to_#{'s'}") } }
end

       user     system      total        real
string 40.890000   0.070000  40.960000 ( 41.019328)
symbol 27.140000   0.030000  27.170000 ( 27.197318)

Thanks for sharing the benchmarks! :)


Automated Release Notes

Feature Description
I have recently migrated from Jira/Bitbucket to Gitea.  Everything is going very well.  There is one feature that I miss.  When creating a new release in Jira it automatically puts a list of all the tickets on the projects "completed" Kanban board into the release notes.  Something like the following would be sufficient.
#1234: Ticket title
#1235: Ticket title
#1236: Ticket title
The release "Content" field could be auto filled in after clicking the "New Release" button with the tickets listed on a specified Kanban board.
Screenshots
No response

Here's a relevant project for GitHub: https://github.com/github-tools/github-release-notes

You can do that with Gitea Actions.

You can do that with Gitea Actions.

How? Can you provide a link?


Ability to pin plugin versions in manifest.json

Description
By default, when running gauge it would install latest versions of the plugins automatically in background.
This results in unpredictable versions when there are newer versions of plugins.
It would be great, if we could pin the versions in manifest per plugin so we can have more predictable builds across multiple runs and systems.
What command(s) did you run when you found the bug?
For e.g.
gauge run specs

Output, stack trace or logs related to the bug
Versions
Gauge (Output of gauge -v)
All
Node.js/Java/Python/.Net/Ruby version
Operating System information
All
IDE information

@haroon-sheikh - thanks for the idea - curious to know what issues you see with plugin upgrades?
From the initial days, we've stayed away from pinning plugin versions and instead focused on backward compatibility.
For the rare cases where backward compatibility had to be sacrificed, gauge/plugin use a version range. ex: https://github.com/getgauge/gauge-java/blob/master/java.json#L40 marks gauge-java 0.7.8 to work with minimum version 1.0.7 of gauge.

This is one of the problems:
Installed version of gauge-java(0.7.8) does not match with dependency gauge-java(0.7.6) specified in pom.xml file

That is something we included, to let users know that because gauge install java would install the latest of gauge-java but it wouldn't update pom.xml or build.gradle.
On a related note, I think

version pinning would be a global feature, rolling it into all language runners.
every language ecosystem has it's own dependency management, and this would add another layer on top.

an alternative
I believe most of the problem stem from the fact that gauge-java is a fat jar, containing the types required for authoring, and the runtime required for execution. This has some effect:

when running via maven/gradle, hence maven/gradle manage the dependency. It so happens that with gauge checks the plugins directory and figures it has gauge-java (say, 0.7.8) and tries to communicate accordingly. But maven/gradle load the version mentioned in the project, so it could load 0.7.4, and this causes the runtime incompatibility

any project that includes gauge-java as a dependency inherits it's transitive dependency. This is unnecessary, and can lead to

version conflict
longer build times!

I think one way out of this (and cleaner IMO) is to separate gauge-types and gauge-runtime. gauge-types would contain Step , *Hook, ScreenshotGrabber etc.
/cc @getgauge/core @zabil

Version pinning is a reasonable mechanism adopted in ruby and node ecosystems as they depend on a lot of external packages which in turn have their dependency graph.
However, Gauge and its plugins does not have many third party dependencies. There's has been a lot of issues with the recent upgrades as new versions of Gauge and it's plugin moved to using gprc, changed how reports are generated for cleaner code base and performance. Now that the migration is complete there will hopefully be no more breaking changes that will require version pinning.
I am closing this issue for now, but please feel free to discuss this further. Will re-open if this is required after the next few releases.

I ended up having this issue today because gauge-ts updated and ask for node 20 and my CI (github action) is with node 18. I could just update my node but not being able to pin a plugin version make the build not so reproducible (which is an issue for me in principle and for legal reasons).
Lucky for me, I found a workaround :
I download the plugin version I want as a zip and install it with gauge install my-plugin-name -f /path/to/zip/file
I put that in a script that I run at the same time as I install gauge (npm in my case)


Update NNX State.state.split method docs in statelib.py

May need to review/close because of "[nnx] remove State #4418" https://github.com/google/flax/pull/4418


[ Feature Request ] Add Key Done so that you can display the key in the hole

I would also like to see a “Key Done” slot.
Then you can build the key hole so that the key is inside at the end. Then the whole thing looks more real.
Because let's be honest, when Lara uses the key, where is it? At the moment it just disappears and looks strange.

I think it can be done in lua:

check thje frame of lara inserting the key,
1.1) if it's the frame that you want to have key done show up, spawn the key done using Moveable.new() and immediately destroy the key hole.

But I wouldn't mind being it native

You can also make the key and hole in the puzzle slot. Then trigger the key animation via OCB. You need your own lus
But native is always better :)


Searching for word only works if put inside ""

For Bug Reports

BookStack Version: v0.18.1
PHP Version:
MySQL Version:

I added some text about trello,
tried to search for 'trello' -> No matches
tried to search for '"trello"' -> 1 match
Expected Behavior
To find the trello word without qoutes
Actual Behavior
Did not find the word

Hi @DagW, Thanks for raising this issue. In your content, is trello a word by itself (With only spaces around it) or is it part of more text such as trello-cat or mytrello?

" trello " would be a word by itself, with spaces around it.
Also if the line starts with "trello "
Thanks, love the app otherwise. Im trying to work it in as the main documentation platform :-)

After a deeper dive it looks like there were some indexing issues when words are at the start of a line or when after tabs.
I've updated the indexing to be smarter, Will be part of the next bugfix release (Hopefully deploying sometime this weekend).
Let me know after the update if this does not fix your issues and I'll re-open this.

Hi @ssddanbrown, I'm running the v0.18.3, and still seem to encounter this (or a very similar) problem.
I prefix page titles with words surrounded by brackets like [TRELLO], but can only find them when the said word is searched with quotes.

@yapret Thanks for raising, Just about to deploy a release that splits on more characters include brackets.
After updating to v0.18.4 you'll need to regenerate the search index to see the effects:
php artisan bookstack:regenerate-search


Make the spacer value configurable in the namespaced json compiler

Currently working on a project where we use this tool to help us extract keys in a large application and we use code styles to enforce some rules on our files.  One is that we use spaces instead of tabs so it would be nice if we could pass in an option for the tool to use spaces instead of tabs.
Basically this line
return JSON.stringify(values, null, '\t');
would become something like
return JSON.stringify(values, null, this.spacer);

Could probably be implemented using options like --indentation spaces/tabs --identation-size=2.
Will keep this ticket open to be worked on in a future version :-)

You can now specify custom indentation as an argument to the script :-)

:+1: Thanks for this! I will give the new version a try soon.

This works great with latest version! Thanks!


DotNet to WinRT

The problem
Bless tests for windows are failing because bleak has shifted from dotnet to winrt
Reproduction
python -m purest

Expected behavior
Should pass
Desktop (please complete the following information):

OS: Windows

Fixed with merge #57


Added github action cron job to update schedules automatically

Adressing issue #419.  Added a github action workflow to update schedule

created a update_schedule.yml file (contains workflow)
the cron job runs every 3 months
updated bin/update_schedule.sh file (added instructions to deduce the next cohort number)

Thanks @baimamboukar for the PR

I am doing my best to be of help 😇

You added here changes on the Code of Conduct. Could you revert them? Thanks a lot

hello, @bebatut is this issue still open? seems like it was left unresolved