UIManager.getSytemLookAndFeelClassName() returns wrong value on Fedora 32

Description

As identified in https://github.com/AdoptOpenJDK/openjdk-support/issues/4#issuecomment-620661519, newer Fedora versions don't know to use the Gnome/Gtk theme.  This bug may also affect other Gtk-based desktops which do not provide this value.

Upstream Gnome commit which removed GNOME_DESKTOP_SESSION_ID: https://gitlab.gnome.org/GNOME/gnome-session/commit/00e0e6226371d53f651cc881e74c0543192c94a8#5b3005b925ed5c2612a9604ad3c756b1f9472165

Question to Gnome's desktop-devel-list: https://mail.gnome.org/archives/desktop-devel-list/2020-April/msg00012.html

Platform and architecture:

Fedora 32 (Workstation) x86_64

Java version:
openjdk version "11.0.7" 2020-04-14
OpenJDK Runtime Environment AdoptOpenJDK
OpenJDK 64-Bit Server VM AdoptOpenJDK (build 11.0.7+10, mixed mode)

Actual vs. Expected Behavior:
System.out.println(UIManager.getSystemLookAndFeelClassName());

On Fedora 32, it returns: (ACTUAL)

javax.swing.plaf.metal.MetalLookAndFeel

On Fedora 27, it returns: (EXPECTED)

com.sun.java.swing.plaf.gtk.GTKLookAndFeel

Details
Gnome provides an environment variable GNOME_DESKTOP_SESSION_ID=this-is-deprecated, however newer Fedora versions do not provide this environment variable.  More details on which process sets this variable is available here: https://stackoverflow.com/q/40603418/3196753
OpenJDK looks for this variable in UNIXToolkit:L100

I didn't find a JBS entry that matches your description.
@jerboaa Do you need more info?

A bit more information...  This isn't a Wayland issue, but rather the removal of the value from the Gnome desktop.  Evidence is that this value exists on Fedora 27 using Wayland and X11 but is missing on Fedora 32 using X11 and Wayland.  Below is a detailed matrix.
One fallback is to trust $XDG_CURRENT_DESKTOP, however this value seems to be less reliable for Gnome-based desktop environments.

OS
$XDG_CURRENT_DESKTOP
$GNOME_DESKTOP_SESSION_ID
OK?

  Once it hits the archives, I can hard-link it here.

Gnome desktop-devel-list question permalink: https://mail.gnome.org/archives/desktop-devel-list/2020-April/msg00012.html

Upstream gnome commit which removed the GNOME_DESKTOP_SESSION_ID value: https://gitlab.gnome.org/GNOME/gnome-session/commit/00e0e6226371d53f651cc881e74c0543192c94a8#5b3005b925ed5c2612a9604ad3c756b1f9472165

I've found some Debian code using the following code:
os.getenv("XDG_CURRENT_DESKTOP", "").endswith("GNOME")

... which per above table will break on many 3rd party Gtk-based desktops.  I'm hoping Gnome offers some insight into how to do this.  At the time of the above commit hitting, Debian had 225 instances of GNOME_DESKTOP_SESSION_ID being used for various desktop environment purposes.  It seems a suitable replacement is warranted and there's hundreds of use-cases to support that.

Here's a Gnome project using similar logic: https://gitlab.gnome.org/GNOME/glib-networking/commit/89c45b82b85daef0f1e679dbd15a9c7c893deb17#d53b9ec213c7c4dd230c7ad15ccf62b542a79279_316_316

In short, the Gnome developers recommend just loading the theme -- rather blindly -- on all Linuxes.  I'm not sure how the OpenJDK team will react to this proposal, but long of it's all spelled out in the email back-and-forth https://github.com/AdoptOpenJDK/openjdk-support/issues/94#issuecomment-621404508.
I'll quote the relevant parts:

This would mean each Gtk-based DE will require a patch to OpenJDK,
which is unsustainable.

I agree that this is inconvenient but in the absence of a better
option, you either make a list, or come up with some heuristic.

I'm not sure I understand the reluctance to provide such information.

I do not think anyone is opposed to that but I doubt anyone will
consider it a priority. Especially since the intersection of
toolkits supported by AWT and toolkits prefered can be emulated using
much simpler algorithm. (Gtk|KDE|Motif chart provided).

The main point is, even if there was API returning the preferred toolkit for the desktop environment, you could rewrite
if (Environment.getPreferredToolkit() == GTK) {
    return "com.sun.java.swing.plaf.gtk.GTKLookAndFeel";
} else if (Environment.getPreferredToolkit() == QT) {
    // Qt not supported by AWT so let's check for GTK as the next best thing
    if (Environment.isGtkAvailable()) {
        return "com.sun.java.swing.plaf.gtk.GTKLookAndFeel";
    }
    return getCrossPlatformLookAndFeelClassName();
} else {
    // GTK is still more user friendly then Metal and the user already has it available
    if (Environment.isGtkAvailable()) {
        return "com.sun.java.swing.plaf.gtk.GTKLookAndFeel";
    }
    return getCrossPlatformLookAndFeelClassName();
}

into
if (Environment.isGtkAvailable()) {
    return "com.sun.java.swing.plaf.gtk.GTKLookAndFeel";
}
return getCrossPlatformLookAndFeelClassName();

Also need to point out that I am not a member or representative of GNOME project, I only package GNOME and Freedesktop projects for NixOS.

I've filed this bug with our JDK support provider.  If they file upstream before an Adopt dev gets around to it, I'll link.

The upstream bug report was filed but closed. https://bugs.openjdk.java.net/browse/JDK-8247753
Quoting:

We only support Ubuntu and Oracle Linux. We don't support other flavours of Linux, so this will be closed unless this is reproducible on these two platforms.
Please re-open if required.

This culture terrifies me. 🤕

I got it reopened upstream

Update: It appears OpenJDK will be accepting the XDG_CURRENT_DESKTOP patch.  This still has scalability issues, but addresses the problem on the vast majority of distributions.
I'm uncertain if this is targeted at JDK11 (the mail says JDK16) or perhaps if it will be backported. Here's the mailing list conversation: https://mail.openjdk.java.net/pipermail/swing-dev/2020-August/010608.html

The patch has landed on JDK16, just awaiting the backport.
https://bugs.openjdk.java.net/browse/JDK-8247753

@tresf I haven't seen any activity regarding a backport to 11. Do you know more? Or has someone else to step in!

Waiting on review upstream: https://mail.openjdk.java.net/pipermail/jdk-updates-dev/2021-February/005078.html

Fixed in 11.0.12


Gif Added to the Header

Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[ ] Test A
[ ] Test B

Test Configuration:

Firmware version:
Hardware:
Toolchain:
SDK:

Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

why the checks have failed?

Hey @harshalkaigaonkar Do not, create and then delete PRs, checks fail but you can make them pass.
Simply make changes and make a commit and push to your branch. Simailarly as you were doing while development. That commit will get added to this PR only.

okay


Make API image smaller by not including dev dependencies

Fixes

Fixes #1008 by @krysal
Description

This PR separates the API image into api and api_dev, the former of which is published to GHCR and does not include dev-dependencies, while the latter is used in CI and includes dev-dependencies.
It also updates the set_matrix_images.py code to enforce consistency in the outputs so that fallbacks and null-handling is not needed in ci.yml.
Testing Instructions

See that CI builds both api and api_dev.
See that CI uses api_dev to run the tests (proven by the CI passing, the prod image does not have pytest).
See that CI publishes api (cannot test without merging the PR unfortunately).

Checklist

[x] My pull request has a descriptive title (not a vague title likeUpdate index.md).
[x] My pull request targets the default branch of the repository (main) or a parent feature branch.
[x] My commit messages follow best practices.
[x] My code follows the established code style of the repository.
[x] I added or updated tests for the changes I made (if applicable).
[x] I added or updated documentation (if applicable).
[ ] I tried running the project locally and verified that there are no visible errors.
[ ] I ran the DAG documentation generator (just catalog/generate-docs for catalog
PRs) or the media properties generator (just catalog/generate-docs media-props
for the catalog or just api/generate-docs for the API) where applicable.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

It finally works, the tests are passing, and the diff was fairly minimal, but the difference is not as much as I had hoped.

I don't know if it's worth proceeding with this.

It's a 7.5% reduction, I'd say that's pretty meaningful.

In the CI+CD workflow, we build all the images we would need in build-images (this includes api and api_dev now) and only publish a subset of these images in publish-images (this never includes api-dev). Images are only built once and then these artifacts are repeatedly downloaded by load-img where needed. We build api_dev only when the API needs to be tested. For all other scenarios, we only build api.
The issue with building a layered image is that we do not include PDM in the final image (just the .venv/ created in builder) so it's not possible to install a PDM lockfile on top of the final image. Additionally installing packages in the entrypoint or cmd intuitively "feels" wrong.

If we build a dev API image in the only place it's used, we can skip the artifact upload, download and cache steps and at the cost of some DRYness, reduce the artifact volume. I'm interested in your thoughts on 2d9dca2.

It looks good to me. Am I correct in understanding that the basic difference is we wouldn't upload/load the api_dev image outside that particular API test job, and therefore remove the duplication of an API image loading in every other step?

Yes @sarayourfriend. The api_dev image is now only built in the API test job and not cached, uploaded as an artifact or downloaded anywhere.
The production image api will be built, uploaded as an artifact, downloaded for use in other jobs and also published to GHCR.

Yes, there is some documentation about the CI + CD workflow that needs updating. I'll update the docs, push to this PR and merge it.


Lazily allocate the rack.input buffer.

Previously, we allocated 1MB for every request! Boo.

Approved!


On my touch device (Ipad with latest OS)  zoomOnDoubleClick has no effect.

Describe the Bug
as described in the title, zoomOnDoubleClick={false} has no effect on my ipad.
Your Example Website or App
No response
Steps to Reproduce the Bug or Issue
double tab on the touch device.
Expected behavior
no zoom, but zoom occurs.
Screenshots or Videos
No response
Platform
IOS Ipad latest version
Additional context
No response

any news on this?


2.206.0 upgrade now bombs with "undefined method `to_sym'"

New Regression Checklist

[x] Updated fastlane to the latest version
[x] I read the Contribution Guidelines
[x] I read docs.fastlane.tools
[x] I searched for existing GitHub issues

Regression Information

Breaking version: 2.206.0
Last working version: previous version

Regression Description
As suggested, execute
bundle update fastlane
...now doesn't work
Complete output when running fastlane, including the stack trace and command used
bundle exec fastlane
[✔] 🚀
bundler: failed to load command: fastlane (/usr/local/bin/fastlane)
Traceback (most recent call last):
19: from /usr/local/bin/bundle:23:in <main>' 	18: from /usr/local/bin/bundle:23:in load'
17: from /Library/Ruby/Gems/2.6.0/gems/bundler-2.3.9/exe/bundle:36:in <top (required)>' 	16: from /Library/Ruby/Gems/2.6.0/gems/bundler-2.3.9/lib/bundler/friendly_errors.rb:103:in with_friendly_errors'
15: from /Library/Ruby/Gems/2.6.0/gems/bundler-2.3.9/exe/bundle:48:in block in <top (required)>' 	14: from /Library/Ruby/Gems/2.6.0/gems/bundler-2.3.9/lib/bundler/cli.rb:25:in start'
13: from /Library/Ruby/Gems/2.6.0/gems/bundler-2.3.9/lib/bundler/vendor/thor/lib/thor/base.rb:485:in start' 	12: from /Library/Ruby/Gems/2.6.0/gems/bundler-2.3.9/lib/bundler/cli.rb:31:in dispatch'
11: from /Library/Ruby/Gems/2.6.0/gems/bundler-2.3.9/lib/bundler/vendor/thor/lib/thor.rb:392:in dispatch' 	10: from /Library/Ruby/Gems/2.6.0/gems/bundler-2.3.9/lib/bundler/vendor/thor/lib/thor/invocation.rb:127:in invoke_command'
9: from /Library/Ruby/Gems/2.6.0/gems/bundler-2.3.9/lib/bundler/vendor/thor/lib/thor/command.rb:27:in run' 	 8: from /Library/Ruby/Gems/2.6.0/gems/bundler-2.3.9/lib/bundler/cli.rb:483:in exec'
7: from /Library/Ruby/Gems/2.6.0/gems/bundler-2.3.9/lib/bundler/cli/exec.rb:23:in run' 	 6: from /Library/Ruby/Gems/2.6.0/gems/bundler-2.3.9/lib/bundler/cli/exec.rb:58:in kernel_load'
5: from /Library/Ruby/Gems/2.6.0/gems/bundler-2.3.9/lib/bundler/cli/exec.rb:58:in load' 	 4: from /usr/local/bin/fastlane:23:in <top (required)>'
3: from /usr/local/bin/fastlane:23:in load' 	 2: from /Library/Ruby/Gems/2.6.0/gems/fastlane-2.206.0/bin/fastlane:23:in <top (required)>'
1: from /Library/Ruby/Gems/2.6.0/gems/fastlane-2.206.0/fastlane/lib/fastlane/cli_tools_distributor.rb:81:in take_off' /Library/Ruby/Gems/2.6.0/gems/fastlane-2.206.0/fastlane/lib/fastlane/cli_tools_distributor.rb:145:in map_aliased_tools': undefined method `to_sym' for nil:NilClass (NoMethodError)
Environment

✅ fastlane environment ✅
Stack

Key
Value

OS
11.6

Ruby
2.6.3

Bundler?
true

Git
git version 2.32.0 (Apple Git-132)

Installation Source
/usr/local/bin/fastlane

Host
macOS 11.6 (20G165)

Ruby Lib Dir
/System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/lib

OpenSSL Version
LibreSSL 2.8.3

Is contained
false

Is homebrew
false

Is installed via Fabric.app
false

Xcode Path
/Applications/Xcode.app/Contents/Developer/

Xcode Version
13.2.1

Swift Version
5.5.2

System Locale

Variable
Value

LANG
en_AU.UTF-8
✅

LC_ALL

LANGUAGE

fastlane gems

Gem
Version
Update-Status

fastlane
2.206.0
✅ Up-To-Date

Loaded fastlane plugins:
No plugins Loaded
Loaded gems

Gem
Version

did_you_mean
1.6.1

bundler
2.3.9

rake
13.0.6

rexml
3.2.5

CFPropertyList
3.0.5

public_suffix
4.0.7

addressable
2.8.0

artifactory
3.0.15

atomos
0.1.3

aws-eventstream
1.2.0

aws-partitions
1.587.0

aws-sigv4
1.5.0

jmespath
1.6.1

aws-sdk-core
3.131.0

aws-sdk-kms
1.57.0

aws-sdk-s3
1.114.0

babosa
1.0.4

claide
1.1.0

colored
1.2

colored2
3.1.2

highline
2.0.3

commander
4.6.0

declarative
0.0.20

digest-crc
0.6.4

unf_ext
<IP_ADDRESS>

unf
0.1.4

domain_name
0.5.20190701

dotenv
2.7.6

emoji_regex
3.2.3

excon
0.92.3

faraday-em_http
1.0.0

faraday-em_synchrony
1.0.0

faraday-excon
1.1.0

faraday-httpclient
1.0.1

multipart-post
2.0.0

faraday-multipart
1.0.3

faraday-net_http
1.0.1

faraday-net_http_persistent
1.2.0

faraday-patron
1.0.0

faraday-rack
1.0.0

faraday-retry
1.0.3

ruby2_keywords
0.0.5

faraday
1.10.0

http-cookie
1.0.4

faraday-cookie_jar
0.0.7

faraday_middleware
1.2.0

fastimage
2.2.6

gh_inspector
1.1.3

jwt
2.3.0

memoist
0.16.2

multi_json
1.15.0

os
1.1.4

signet
0.16.1

googleauth
1.1.3

httpclient
2.8.3

mini_mime
1.1.2

trailblazer-option
0.1.2

uber
0.1.0

representable
3.2.0

retriable
3.1.2

webrick
1.7.0

google-apis-core
0.5.0

google-apis-androidpublisher_v3
0.21.0

google-apis-playcustomapp_v1
0.7.0

google-apis-iamcredentials_v1
0.10.0

google-apis-storage_v1
0.14.0

google-cloud-env
1.6.0

google-cloud-errors
1.2.0

google-cloud-core
1.6.0

google-cloud-storage
1.36.2

json
2.6.2

mini_magick
4.11.0

naturally
2.2.1

optparse
0.1.1

plist
3.6.0

rubyzip
2.3.2

security
0.1.3

simctl
1.6.8

terminal-notifier
2.0.0

unicode-display_width
1.8.0

terminal-table
1.8.0

tty-screen
0.8.1

tty-cursor
0.7.1

tty-spinner
0.9.3

word_wrap
1.0.0

nanaimo
0.3.0

xcodeproj
1.21.0

rouge
2.0.7

xcpretty
0.3.0

xcpretty-travis-formatter
1.0.1

generated on: 2022-05-18

In my case I get:
bundle exec fastlane
[✔] 🚀
bundler: failed to load command: fastlane (/usr/local/bin/fastlane)
NoMethodError: undefined method to_sym' for nil:NilClass   /Library/Ruby/Gems/2.6.0/gems/fastlane-2.206.0/fastlane/lib/fastlane/cli_tools_distributor.rb:145:in map_aliased_tools'
/Library/Ruby/Gems/2.6.0/gems/fastlane-2.206.0/fastlane/lib/fastlane/cli_tools_distributor.rb:81:in take_off'   /Library/Ruby/Gems/2.6.0/gems/fastlane-2.206.0/bin/fastlane:23:in <top (required)>'
/usr/local/bin/fastlane:23:in `load'

Hi @newbusiness @scriba
Open PR to fix this issue. Can you please test once! 🙏
Testing steps are there inside the PR description.

I had the same issue, it seems you cannot run fastlane without giving a lane name since this new version.
So

running fastlane to run fastlane and ask you for the lane you want to run produces that issue.
running fastlane <a lane name> works as previously

I got a temporary solution accidentlly by adding --verbose like this:
bundle exec fastlane --verbose

I fixed the issue by downgrading the version of the bundler(version 1.17.2). Even though now it gives me a bunch of warnings...
Also, keep in mind that you should use your own Ruby, not the system one.

Fixing now! Sorry about that, fam 😔


Request handling changes

I took a different approach to your timeout mechanism and went with implementing a non-blocking stream. I then polled for the entire contents of the request before parsing.
The idea behind this was to prevent the parser from stopping the parsing process, kicking back the request for more data, and then restarting the process from the beginning.  This works great but it resulted in a number of changes.
Since we have the full request from the beginning, there is no need for a http_parse::Status as there is never a partial status. Either we received the full request, or the connection was assumed to be closed prematurely. This changes some of the tests that were expecting a partial result versus a connection-closed.
The determination of whether the body was completely sent was moved into the parser.
Rather than relying on the caller of the Request to remember to set the stream to non-blocking, I added a new method to Request set that when parsing from the stream.
As part of this, I ended up restructuring the parser so that I could understand the parsing process better which is where I found a subtle problem with how it was handling the path validation. Which I clarified by adding a new ParsePath error.
This is large PR and I'm fairly new to Rust. So I'd appreciate any feedback.

That commit should fix tests. Will accept when passes :)

So it's been a year or two since I frequented GitHub. What black magic was it that allows you to modify my repository with the fix for the tests? That's neat and I haven't seen that before.

When creating a pull request, there's an option to allow edits from maintainers of the repo you are trying to merge into. I honestly forgot it existed and I was going to just create a PR in your fork.
I reran the tests as it seems like that one that failed the first time is a bit flaky - if it fails again it's probably the fault of the test for some reason even though it passed tests on my machine.

Yep, now it passes - that test must be unreliable. Merging!
thread 'body_len' panicked at 'assertion failed: `(left == right)`
  left: `200`,
 right: `404`', tests/response_test.rs:168:5
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

failures:
    body_len

test result: FAILED. 14 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s


[Broker] Support create subscription by specifying the earliest or latest position.

Fixes #9441
Motivation
Currently, if we need to specify the messageID when creating a subscription through the REST API, we cannot use latest and earliest to specify the position. Instead, we can only do it like this to create a subscription from the latest position:
PUT /admin/v2/persistent/public/default/test/subscription/test HTTP/1.1
Content-Type: application/json

{"ledgerId":9223372036854775807,"entryId":9223372036854775807,"partitionIndex":-1}

This PR adds support for creating subscription by specifying the latest or earliest  position. So we can send the request like this:
PUT /admin/v2/persistent/public/default/test/subscription/test HTTP/1.1
Content-Type: application/json

"latest"

Modifications

Add a private constructor for MessageIdImpl so that we can convert the string parameter like latest or earliest to the MessageIdImpl.

Verifying this change
This change is already covered by existing tests, such as createSubscriptionBySpecifyingStringPosition.
Does this pull request potentially affect one of the following parts:
If yes was chosen, please highlight the changes

Dependencies (does it add or upgrade a dependency): (no)
The public API: (no)
The schema: (no)
The default values of configurations: (no)
The wire protocol: (no)
The rest endpoints: (yes)
The admin cli options: (no)
Anything that affects deployment: (no)

Documentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs?

[x] doc
(If this PR contains doc changes)

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

Confirmed w/ @RobertIndie, doc is the annotations generated from code files.

/pulsarbot run-failure-checks


autocomplete issue on m2lines hub

Context
The autocomplete on the m2lines hub currently doesn't work properly. It does this:
Step 1:

Step 2:

Instead of just completing the final bit, it basically adds an extra variable name =.
I am not sure where the problem comes from, but hopefully someone with more experience can help.
I am using the Tensorflow notebook on GPU. The problem is not there in the Base Pangeo case on small CPU. Maybe the problem is upstream?
Proposal
No response
Updates and actions
No response

I am using the Tensorflow notebook on GPU. The problem is not there in the Base Pangeo case on small CPU. Maybe the problem is upstream?

That feels like an upstream issue. In fact, it seems you reported upstream a related issue some time ago: https://github.com/pangeo-data/pangeo-cloud-federation/issues/923.

@dhruvbalwada @damianavila It looks like this is actually an hvplot problem (https://stackoverflow.com/questions/75772203/jupyterlab-tab-complete-duplicates-assignment). so I'd suggest opening an issue in https://github.com/holoviz/hvplot

Thanks for your feedback, @scottyhq!
@dhruvbalwada, I am going to close this one since this is an upstream issue.


How to Install/Build for Chromium based Browsers

Installation Guide:
Get a zip file by following the build guide below.
Go to chrome://extensions
Drag the zip file into the window.
Build Guide:
Clone / Download the repository
Select the following files

Create a zip with the selected files.

Also, try add to microsoft store, they're free and more open to extensions than the shitty google

By the way I did this tool: https://github.com/marcussacana/SignMyDick
To hide that "unpacked/developer extension" alert in my edge, if someone wants as well


Revise open vs. public

I would like to create subclass of BlockProcedure which in it's init provides a block.  However since BlockProcedure is set public I officially can't.
Example:
class RegisterForRemoteNotificationsOperation: BlockProcedure {
    init() {
        super.init(block: {
            NSApplication.shared().registerForRemoteNotifications(matching: .alert)
        })
    }
}

btw: The iOS equivalent of my RegisterForRemoteNotificationsOperation is a GroupProcedure with a more complicated setup.

Hi @martnst - hmm, so the issue is that the init of the BlockProcedure is not open?

Right, changing BlockProcedure and it's superclass TransformProcedure to open would be enough. Unless you have any concerns of having somebody subclass it.

I picked the title more generic as you might use this opportunity to check other class as well.

Yeah, I went though and made a bunch of classes open but didn't change all the initialisers.... 🙄

Okay looks like you missed Transform.swift . 😉

Okay - so, can I just check something? What version of ProcedureKit are you using?
BlockProcedure does not inherit from TransformProcedure anymore, as of Beta 3. And both of these classes are open.
Also, there is no such thing in Swift 3.0, as far as I can tell, as an open initializer. So, for example, NSObject does not have an "open" initializer.

Okay looks like I am behind #516 from 6 days ago.
I am on pod 'ProcedureKit', :git => 'https://github.com/ProcedureKit/ProcedureKit.git', :branch => 'development'

Yeah - #510 and #511.
And you've run pod install again?

👍🏼 pod update ProcedureKit did pull the latest and greatest updates.

Ha! okay - gonna close this, as pretty sure it's already done - your class example should be possible.

confirmed


Fix incorrectly formatted URL

Will also fix this upstream in the Kubernetes repo.

This change is

/assign @heckj

/cc @chenopis - not entirely sure where this is imported from “upstream”, but expect a change there - going to approve this to fix the broken link, even though it’s an imported doc

/lgtm

@heckj It's imported from the Kubernetes repo. Here's the other PR https://github.com/kubernetes/kubernetes/pull/60248


Adding blog on pasta in Our Food blog section

I am a GSSoC contributer and want to fix the issue. Please assign the issue to me

assigned


FIx for [ERR_OUT_OF_RANGE]: The value of "byteLength" is out of range…

Change conversion of long to integer from using buffer.readIntBE to buffer.readUInt32BE as node.js since version 10.0 checks that paramter byteLength in buffer.readIntBE is less than 6. One can argue that this should use buffer.readBigInt64BE but that is only available in node.js 12.0

Would be great if this was merged so we can install this plugin in the new Homebridge config UI

I found I had to change the conversion in the decode function for long and ulong to that as well on lines 927-929:
        } else if (type.type === 'long') {
          value = buffer.readUInt32BE(index + 8);
        } else if (type.type === 'ulong') {
          value = buffer.readUInt32BE(index + 8);


conform to HashiCorp-style release artifacts

This partially addresses issue #84

publish .zip files rather than .tgz files
binary name now includes version (terraform-provider-vinyldns-0.9.5, for example)
.zip file names are terraform-provider-{NAME}-{VERSION}-{OS}-{ARCH}.zip-named
artifacts include terraform-provider-{NAME}-{VERSION}-SHASUMS
artifacts include terraform-provider-{NAME}-{VERSION}-SHASUMS.sig

@mdb Ran through the package phase, looks great. The one question I had, in the description you've got the naming templates using all hyphens: terraform-provider-{NAME}-{VERSION}-{OS}-{ARCH}.zip but in the output release folder, I see a mix of hyphens and underscores: terraform-provider-vinyldns_0.9.5_darwin_amd64.zip. Which is correct?

@clinedome Apologies for going quiet on this for so long.

in the description you've got the naming templates using all hyphens: terraform-provider-{NAME}-{VERSION}-{OS}-{ARCH}.zip but in the output release folder, I see a mix of hyphens and underscores: terraform-provider-vinyldns_0.9.5_darwin_amd64.zip. Which is correct?

I spoke to Justin Campbell of HashiCorp and confirmed that there was a typo in the original documentation and that:

Basically all of the fields are underscore-separated, but the name (terraform-provider-vinyldns) contains dashes

The desired formatting is evidenced by the terraform-provider-null examples here:
https://releases.hashicorp.com/terraform-provider-null/2.1.2/


Fonts not consistent

This is great work. Now I don't have to map .hx onto C#.
But I am puzzled by one thing. All the keywords are displayed in a different font. Yet your XML has an empty string for all fontname values (even default). When I change the default fontname in your XML I still see this issue.
I assume this is some weird n++ behavior (possibly a bug on their side), but I can't account for it. Do you have any ideas what is happening?

Not really. but can suggest a couple of things or three:

explicitly set the fontName for all the WordStyle entries
see if using a global override fixes it (I have it enabled in fact, but don't remember why). It's in Settings->Style Configurator

update NPP to latest and see if things are somehow fixed there

Glad you found it useful! :wink:

Oh, and also take a look at the issues on Notepad++ git repo (https://github.com/notepad-plus-plus/notepad-plus-plus/issues) and the community forum (https://notepad-plus-plus.org/community/).
In fact it may - or may not - be this: https://github.com/notepad-plus-plus/notepad-plus-plus/issues/5630.


docs: Fix auto-host-rewrite doc

auto-host-rewrite does have effect when using EDS and setting hostname field.

Commit Message: This fixes auto_host_rewrite explanation. Since this pr, auto_host_rewrite does have effect even with route types of 'static' or 'eds' when 'hostname' field is set for the endpoints.
Additional Description:
Risk Level: Low
Testing: n/a
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

Thanks for fixing this. Unfortunately, we required DCO for all commits to the repository. There are instructions (with the necessary git commands) for fixing the DCO failure in the CONTRIBUTING.md file.

Thanks.
DCO fix-up done.

/retest

/retest

@difro I'm not sure why this PR is stuck on CI.


Add int64 and float64 in _DataType

This PR

Adds float64 and int64 types in _DataType (#188 - After adding additional types in ScalarData for #172, we need to add types in _DataType )

Add a test case for this.

Why don't we just follow #173?

@AvinashBukkittu Before this one is merged, can you modify sentence_classifier example by following the steps in #188 to make sure this is actually working?

@AvinashBukkittu Before this one is merged, can you modify sentence_classifier example by following the steps in #188 to make sure this is actually working?

Yes, I tried the example and it seems to run.


Statistics for League of Legends

Good news! League of Legends has an official API available at https://developer.riotgames.com.
Because is one of the most played games, I feel that it needs to be included.

This has already been addressed.


Firmware Utility Script automatically selects the wrong (but almost right) firmware board image (BLOOGLET)

Hey there! I have an HP Chromebook 14a-na0031wm (BLOOGLET) and have had the UEFI Full ROM firmware for a few months now and I'm totally loving it! There has been a big drawback for my specific case, however, and it took me this long to find any leads. If I could get expert input on the matter, this might be the place to go.
Anyway, I just realized that the Firmware Utility Script picked the firmware for the HP Chromebook x360 12b (BLOOG), rather than BLOOGLET. Even subsequent firmware updates are doing the same thing. The hardware is similar enough, sure, but I wonder if my sound issues are caused by this.
Firstly, sound when booted normally (booted into Linux Mint Xfce 21.2 through the integrated eMMC) works, but no matter what you set your volume to, it's on full blast, all the way (unless it's muted, of course.) The headphone jack doesn't work at all and isn't detected, however, and sound while booted from USB (Live environment, Tails, Batocera, etc.) doesn't work at all, either.
Is this a unique issue, and can I try fixing it by manually selecting a BLOOGLET image somehow?
It's really a minor issue; I mean, I'm posting the issue from the device in question kek
Existing running firmware version: 4.20.1 (nice)

BLOOG and BLOOGLET are the exact same device, only difference is the name.
Functional audio under Linux requires the use of the script linked in my FAQ. Has nothing to do with the firmware, it's an OS/driver/config issue

Thanks for the tip! I'll give the audio script a whirl when I get home and follow up


build!: drop Node 10 to support and update lastest Typescript

Set Node v12 to minimum supported version
Drops Node 10 support, which has been EOL for about 1 year. 🦕
See: Google Cloud moves Cloud Client Libraries for Node.js support for version 10 to Maintenance

@alexander-fenster I don't have access of setting to remove test(10) in gax-nodejs. Could you help me change to test(12). Thank you?

To remove node 10, change it here: https://github.com/googleapis/gax-nodejs/blob/main/.github/sync-repo-settings.yaml#L12

I think we just need to update auth, thank you!

I think we just need to update auth, thank you!

Upgraded. Thanks


Icon request: Flourish

URL for the brand / site / app
https://flourish.studio
Logo resources for the icon
No response
Anything else?
No response
Confirmation

[X] I have read and followed the issue guidelines.

Here you go!
https://github.com/aegis-icons/aegis-icons/blob/master/SVG/Flourish.svg

:question: How to add icon(s) to Aegis?
:star: Support this project by giving a star! Just adding like to this comment is also appreciated.


Meta key on Linux

When I use xev and check the keycode for the Super/Windows/Meta key on my physical keyboard on my Linux Desktop, it prints this keycode
keycode 133 (keysym 0xffeb, Super_L)
but if I connect via vnc (using x11vnc) and I try pressing the Meta key on HackersKeyboard, nothing happens, xev doesn't even detect it. I tried every setting, I got Alt and Ctrl working but I can't find how to make this key work. Is it just me?

Turns out, it was a problem with the app I was using as a vncviewer, not with the keyboard


tf.image.resize_bilinear vs cv2.resize

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow):
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Ubuntu14.04
TensorFlow installed from (source or binary): binary
TensorFlow version (use command below): 1.4.0
Python version: 2.7
Bazel version (if compiling from source):
GCC/Compiler version (if compiling from source):
CUDA/cuDNN version:
GPU model and memory:
Exact command to reproduce:

Not to compare with opencv, but ... when the scale factor is larger, the unchanged part at right-bottom is larger. I found this a little bothersome. Set align_corners=True is not always reasonable because the four corners are not always supposed to be fixed in the corner.
So is there anyway to make it a little more "symmetry"?
Code to reproduce:
import tensorflow as tf
import numpy as np
import cv2
np.set_printoptions(precision=3)
resize_shape = (10, 10)

a = np.ones((1, 2, 2, 1), dtype=np.float32)
a[0, 0, 0, 0] = 5.0
a[0, 1, 1, 0] = 5.0

b = tf.constant(a, dtype=tf.float32)
c = tf.image.resize_bilinear(b, resize_shape)

with tf.Session() as sess:
    np_c = sess.run(c)
    print np_c[0, :, :, 0]

print cv2.resize(a[0], resize_shape, interpolation=cv2.INTER_LINEAR)

Obtained results:
# tf.image.resize_bilinear
[[ 5.    4.2   3.4   2.6   1.8   1.    1.    1.    1.    1.  ]
 [ 4.2   3.72  3.24  2.76  2.28  1.8   1.8   1.8   1.8   1.8 ]
 [ 3.4   3.24  3.08  2.92  2.76  2.6   2.6   2.6   2.6   2.6 ]
 [ 2.6   2.76  2.92  3.08  3.24  3.4   3.4   3.4   3.4   3.4 ]
 [ 1.8   2.28  2.76  3.24  3.72  4.2   4.2   4.2   4.2   4.2 ]
 [ 1.    1.8   2.6   3.4   4.2   5.    5.    5.    5.    5.  ]
 [ 1.    1.8   2.6   3.4   4.2   5.    5.    5.    5.    5.  ]
 [ 1.    1.8   2.6   3.4   4.2   5.    5.    5.    5.    5.  ]
 [ 1.    1.8   2.6   3.4   4.2   5.    5.    5.    5.    5.  ]
 [ 1.    1.8   2.6   3.4   4.2   5.    5.    5.    5.    5.  ]]
# cv2.resize
[[ 5.    5.    5.    4.2   3.4   2.6   1.8   1.    1.    1.  ]
 [ 5.    5.    5.    4.2   3.4   2.6   1.8   1.    1.    1.  ]
 [ 5.    5.    5.    4.2   3.4   2.6   1.8   1.    1.    1.  ]
 [ 4.2   4.2   4.2   3.72  3.24  2.76  2.28  1.8   1.8   1.8 ]
 [ 3.4   3.4   3.4   3.24  3.08  2.92  2.76  2.6   2.6   2.6 ]
 [ 2.6   2.6   2.6   2.76  2.92  3.08  3.24  3.4   3.4   3.4 ]
 [ 1.8   1.8   1.8   2.28  2.76  3.24  3.72  4.2   4.2   4.2 ]
 [ 1.    1.    1.    1.8   2.6   3.4   4.2   5.    5.    5.  ]
 [ 1.    1.    1.    1.8   2.6   3.4   4.2   5.    5.    5.  ]
 [ 1.    1.    1.    1.8   2.6   3.4   4.2   5.    5.    5.  ]]

This question is better asked on StackOverflow since it is not a bug or feature request. There is also a larger community that reads questions there.
If you think we've misinterpreted a bug, please comment again with a clear explanation, as well as all of the information requested in the issue template. Thanks!

After posting the question in StackOverflow, I've found that this is a duplicate of the issue #6720. Sorry for the trouble.

I think this should be reopened. The sampling logic of this kernel's implementation is simply incorrect which is certainly a bug when the name of the operation is called 'Resize Bilinear'.
Also, at a cursory glance there seems to be little reason that FP16 isn't supported - the templated input type is hard-casted to and written out as a float. Couldn't this templated type be propagated to the output? This disconnect incites an anomalous perf issue when converting models from FP32 to FP16.
https://github.com/tensorflow/tensorflow/blob/master/tensorflow/core/kernels/resize_bilinear_op_gpu.cu.cc


add stratified sample

add stratified sample
support ratio and size
if the ratio is number , all group with same samples ratio
if the ratio is string , ex:  name1:ratio1,name2:ratio2  ,it means difference sample ratio for each group, name1 with ratio1, name2 with ratio2 .
if the size is number, all group with same samples size
if the size is string,ex: name1:size1,name2:size2 ,it means difference sample size for each group
Ratio sampling is achieved through Poisson distribution and BernoulliSampler , A little bit different from random sampling is that we need to set a ratio for each group， So we implemented a custom class：CustomerPoissonSampler    and CustomerBernoulliSampler ,Compared with the original, the first element needs to be processed to obtain the grouping key to obtain the ratio of this group
Same for size sampling, we implemented a new reservoirSample to process first element for obtain the size of this group

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your<EMAIL_ADDRESS>seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


is quantization available for these models - e.g. ctranslate2, llama.cpp, gptq, etc.?

My script located here has a basic test now...
https://github.com/collabora/WhisperSpeech/issues/67
I'm excited about the concept of reverse-engineering Whisper models (so to speak) for TTS, but am wondering if it's possible to use quantized versions of models?  There's no information on the model's architecture on huggingface as per normal in a config.json file, at least that I found.  Therefore, it's impossible to see if the models could be converted to quantized version using, for example, ctranslate2, llama.cpp (GGUF format), GPTQ, "Transformers" (relying on BetterTransformer and/or bitsandbytes and/or flash attention2), and whatever other options there are out there...
Looking for a better version of Bark since it's so heavy...but I noticed that even the "small" version of your models was fairly heavy...If quantized, however, I'm wondering if it's better overall.  The quality of the audio is so close to Bark such that any speedup would make this far superior.

Hey, small is a bit of a misnomer. We inherited this naming from Whisper but these are the biggest models we trained. You can try tiny or base which are 5 and 2 times smaller, respectively, and work pretty well. All the models are currently distributed as fp32 so the files are currently 2x bigger than they could be.
Regarding gguf or other quantized formats – I don't have much practical experience with these. A conversion would certainly be possible since we use the same layers as llama and whisper. See also #56 .

Thanks, is there a way to choose between different voices, a variety of English voices, for example, or is there only one that's hardcoded?

You can use the voice cloning feature to get different voices:
generate_to_file("""
This is the first demo of Whisper Speech, a fully open source text-to-speech model trained by Collabora and Lion on the Juwels supercomputer.
""", lang='en', speaker='https://upload.wikimedia.org/wikipedia/commons/7/75/Winston_Churchill_-_Be_Ye_Men_of_Valour.ogg')

see the speaker parameter

For those interested, I tested the same text with my program located at https://github.com/BBC-Esq/ChromaDB-Plugin-for-LM-Studio
Specifically, I ran the program, obtained a response from the LLM, and clicked the "Bark Response" button within my GUI, which uses a Bark model to speak the text of the LLM's response.  My program can use both the "normal" and "small" bark models, in either fp32 or fp16.  Here are the results:
Bark/normal/fp32 = 8 G.B.
Bark/normal/fp16 = 5.7 G.B.
Bark/small/fp32 = 5.3 G.B.
Bark/small/fp16 = 4.2 G.B.
whisperspeech/small-en/float32 (hardcoded by default) = 5.8 G.B.
whisperspeech/base-en/float32 = 5.3. G.B.
whisperspeech/tiny-en/float32 = 5.2 G.B.
In terms of audio quality, both messed up in the same places (e.g. with non-English stuff like "(Ga. Juv. Prac. & Proc.) § 6:29", which is a citation to a legal treatise) and whisperspeech actually seemed smoother overall...and that's using the "small-en" model.
I think it'd be exciting to see the medium.en and large-v2 (AVOID large-v3 IMHO due to regressions!) models, but quantized in either float16 or other formats.
Overall very impressed/excited.  I'd recommend looking at ctranslate2 or Transformers or other quantization options.  Transformers is updated more often is now using BetterTransformer, bitsandbytes, and flash attention 2 so...Just my humble suggestion!

I would also add that I noticed in fetch_models.py you mention "whisperx," which is based on ctranslate2 so...perhaps that's an inroad if you already plan on using other quantized models...
# AUTOGENERATED! DO NOT EDIT! File to edit: ../nbs/0. Download models.ipynb.

# %% auto 0
__all__ = []

# %% ../nbs/0. Download models.ipynb 1
from fastcore.script import call_parse
import whisperx
import whisper
from speechbrain.pretrained import EncoderClassifier

# %% ../nbs/0. Download models.ipynb 3
def load_whisperx(model, lang):
    try:
        whisperx.asr.load_model(model, "cpu", compute_type="float16", language=lang)
    except ValueError as exc:
        print(exc.args[0])
        if exc.args[0] != "Requested float16 compute type, but the target device or backend do not support efficient float16 computation.":
            raise

@call_parse
def main():
    whisper.load_model('base.en')
    whisper.load_model('small.en')
    whisperx.vad.load_vad_model('cpu')
    load_whisperx('medium.en', 'en')
    load_whisperx('medium', 'en')
    EncoderClassifier.from_hparams(source="speechbrain/spkrec-ecapa-voxceleb", savedir="~/.cache/speechbrain/")

For the GPU RAM usage I think we may be very suboptimal – right now we always load the FP32 weights and then convert to FP16. From my quick tests it seemed like it never releases the GPU memory so in FP16 mode we actually use more GPU memory than in FP32. ;)
That would be definitely worth fixing.

I would also add that I noticed in fetch_models.py you mention "whisperx," which is based on ctranslate2 so...perhaps that's an inroad if you already plan on using other quantized models...

We are aware of CTranslate but we don't have resources to work on these conversions at the moment. The fetch_models script is used to download the models we use for data preprocessing for training because the cluster we are using does not have internet access on compute nodes.

For the GPU RAM usage I think we may be very suboptimal – right now we always load the FP32 weights and then convert to FP16. From my quick tests it seemed like it never releases the GPU memory so in FP16 mode we actually use more GPU memory than in FP32. ;)
That would be definitely worth fixing.

If that's the case, if you'll point me to the script/scripts that do the conversion I'll take a quick look at if/why the memory isn't being released...

We are using fp16 and torch.compile, no weight quantization at all at the moment.
The conversion test should be pretty simple. I think the way to go would be to load the models, convert to fp16 (pipe.s2a.switch_dtypes(torch.float16) and pipe.t2s.switch_dtypes(torch.float16)) and save each model in a new file with save_model. Afterwards load the new files (you can give a local paths to s2a_ref) and I think it should stop copying the model in memory.

I'm sorry, you said in one message that they're float32 and then you said float16...can you please clarify?

Sorry , there a couple of steps so it may not be clear: the models are uploaded FP32 to Huggingface, we download them in FP32, convert to FP16 after loading and do inference at FP16.

Where exactly does this happen?  It seems like it's done in multiple places; for example, here:
def optimize(self, max_batch_size=1, dtype=torch.float16, torch_compile=True):
        for emb in [self.embeddings.embedding, self.embeddings.embedding]:
            emb.convert_for_eval()
        for l in self.encoder.layers:
            l.attn.convert_for_eval()
        for l in self.decoder.layers:
            l.attn.convert_for_eval()
            l.cross_attn.convert_for_eval()
            l.setup_kv_cache(max_batch_size, self.stoks_len, self.ttoks_len)
        self.switch_dtypes(dtype)
        if torch_compile:
            self.generate_next = torch.compile(self.generate_next, mode="reduce-overhead", fullgraph=True)

What I am evaluating is possibly using bitsandbytes.  Are you familiar with this library and would you be open to pull requests regarding this?  Bitsandbytes doesn't require creating an entirely new "quantized" model like llama.cpp or ctranslate2, at least that's my understanding.  It seems to simply replace certain pytorch scripts altogether to achieve this affect at runtime instead.
Further, it's my understand that under the hood it includes some custom CUDA kernels...
Here a short summary from their github:

It's officially only available on Linux, but I've been successfully using a custom-wheel FROM HERE for the last few months, no issues whatsoever:

The fp16 conversion is done in self.switch_dtypes(dtype).
For 8bit I’d start by replacing the Linear layers in source code on a temporary branch and see how well it works. If it works and the performance is good we can later implement switching the layers to 8bit in a similar manner to the existing convert_to_eval functions.

You mentioned that the architecture is the same as Whisper, but is there any way you guys could release it...,or at least DM me with it?  It'd help me understand model layers as I begin working on this after implementing other gpu-acceleration.  Huggingface has all of the models in the same repository so I don't know if this'd require restructuring it, but here's an example from whisper-large-v2 from OpenAI:

In one of the other issues you actually posted a link to some charts and graphs when it was trained, but can't locate that again and don't remember if that had the architectures...

I am pretty sure you can view a table like this if you open the model file in Netron. We don’t have any diagrams right now, the only documentation of the architecture is the model code in Python…
It is a encoder decoder transformer like Whisper with some additions, mainly RoPE positional embeddings and MusicGen-like multiple heads for efficient EnCodec tokens prediction.

That Netron is awesome, thanks.  Unfortunately, it couldn't load the "s2a" model so I was automatically directed to their github where I submitted an issue.  Regarding the others...it would not load any of the models beginning with "s2a" except only this one:
s2a_up.model


Change the network module of cpp-redis

As explained in #29, some issues have been reported concerning cpp_redis.
Most of these issues are related to the network side of cpp_redis.
Instead of constantly fixing issues on that side, I decided to rewrite the network module as I was not satisfied with the current implementation (not satisfied by the design, maintainability was reduced over time and so on).
I decided to develop a TCP network library, Tacopie with an enhanced design and aiming to fix all the current issues (#38, #29, #24, #21, #19).
The current network module has been entirely removed.
Instead, tacopie has been integrated as a submodule of cpp_redis and is the new network part of the library.
The advantages of the submodule are the following:

cpp_redis is now only focused on the protocol handling part, not on network issues
networking issues and optimization will be dealt on tacopie repository
installation of cpp_redis remains unchanged: everything is as simple as before

Another main advantage is that the network part may be changed for another library.
For now, tacopie is a pre-requisite of cpp_redis.
But in future versions, tacopie will become optional (packaged by default) and if the developer wants to integrate another network library, he will be able to (for example, Boost Asio).
There is no change in terms of features: library still provides the same features and work on both windows and Unix based platforms.
This constitutes a new release: v3.0.0.
Issues #38, #29, #24, #21, #19 will be closed as not relevant anymore.
If new problems are detected, please open new issues.
Objectives for next releases are:

Providing more tests
Improving performances (remove number of mutex locks for example)
looking for IO Completion ports concerning network part on windows (for now, it is based on WSAPoll).

Enjoy!

good job


Added 1 node of 1 user

Added:

@shawneng:matrix.org 1 node

@ironoa Element handle was verified


In jest tests - the ellipsis always show, regardless of whether it truncates.

I have a component like this:
export const Chip = (props: ChipProps) => {
  const { className, color, text, onDeleteClick, onClick } = props;

  const [isTruncated, setIsTruncated] = useState(false);

  return (

  );
};

Basically it's a chip with max width, but if the label is too long then we truncate the text, but show the full label in a tooltip.
This is working fine in the browser, but I'm getting weird behaviour when trying to write tests for this.
I have jest/enzyme tests that look like this:
    const chip = wrapper.find(Chip);
    expect(chip.text()).toEqual('example 1');

But the Chip text will always display as example 1.... This regardless of how short or long the passed in text is.
If I do a debug of that component we can see that the Truncate looks like:
                  <Truncate lines={1} ellipsis="..." onTruncate={[Function: bound dispatchAction]} trimWhitespace={false} width={0}>

                                  example 1

                                  ...

                            </Truncate>

With the span with ellipsis showing.
What's going on here? I'm suprised that no one else in the issues has mentioned anything like this.

I had the same problem. I'm using Jest/React Testing Library. And other truncate libraries have the same issue. We couldn't find yet a proper way to test components using truncation.


How to limit parallel resources for siesta calculation?

Comment:
I installed siesta using the command conda install -c conda-forge "siesta=*=*openmpi*", but running siesta without any additional options causes it to use all available CPUs on my computer. I would like to limit the parallel calculation to only 16 CPUs.
Can anyone provide guidance on how to set the number of CPUs used in siesta calculations?
I am using Ubuntu 20.04.1 and have installed openmpi-4.1.5.

@Mingzefei In addition to MPI parallelism Siesta uses OpenMP. You can control the OpenMP parallelism using export OMP_NUM_THREADS=16. This is discussed in the manual on page 13 https://siesta-project.org/SIESTA_MATERIAL/Docs/Manuals/siesta-4.1.5.pdf

export OMP_NUM_THREADS=16 works.
Thanks!


Can't open backstage template files, i.e. skeleton\packages${{ values.name }}.ts

Before submitting your bug report

[X] I believe this is a bug. I'll try to join the Continue Discord for questions
[X] I'm not able to find an open issue that reports the same bug
[X] I've seen the troubleshooting guide on the Continue Docs

Relevant environment info
- OS: WSL
- Continue: latest

Description
This naming convention is for backstage templates. https://backstage.io/docs/features/software-templates/
When editing a file named skeleton\packages\${{ values.name }}\index.ts following error message is in the logs.
IDE Protocol _receive_json timed out after 20 seconds. The message sent was: {'filepath': '....\skeleton\\packages\\${{ values.name }}\\src\\router\\index.ts'}
To reproduce

create a file called ${{ values.name }}\index.ts
try to /edit the file with continue
error is thrown

Log output
IDE Protocol _receive_json timed out after 20 seconds. The message sent was: {'filepath': '....\skeleton\\packages\\${{ values.name }}\\src\\router\\index.ts'}
No response

Thanks for sharing this, looking into it now

I'm wondering if there's any part of the setup I'm missing. Here's what I'm trying so far, but unfortunately haven't reproduced:

Using VS Code on Windows WSL
In WSL, use touch \${{\ values.name\ }}\\index.ts to create the file with everything escaped properly
Type something in the file in VS Code
Save the file
Highlight the code, ctrl+shift+m, the request an edit

I also tried a folder "${{ values.name }}" with a file called "index.ts" instead of a file literally named "${{ values.name }}\index.ts"

Hmm, to be more precise here is the exact folder structure

I tried in native windows, it works fine there with the same folder structure. Did you install VScode inside WSL or are you connecting to a windows/vscode via the WSL extension like i do ?


Any consideration using fetch (e.g. polyfill)

Haven't tried this just yet, buts says it support IE9+
https://github.com/github/fetch

Interesting idea, I don't have strong motivation to change the XHR logic at this point since it is relatively stable at the moment.

An argument against using fetch is the lack of any way to abort running fetch requests; this would be a problem when implementing #49

Abort is implemented, and I'm happy with the current implementation for now.


Dockerfile

Where can we find the dockerfiles? I'm not seeing them in https://github.com/opendistro-for-elasticsearch

Hi @markharding, unfortunately, they're not available yet. https://github.com/opendistro-for-elasticsearch/community/issues/11 is the best place to follow along.


closes #14, Completed Job7

Completed Job 7 - Simple User Roles
Updated changelog.md

Approved!


Implement REST API to get deployment by environment ident

References #169
References #21

@GiriDandu please review when Travis is green

@rtyler @GiriDandu I will merge it in half an hour if I have your blessings

:+1: from my side


Receipes

Hello :wave:
Feel free to share your "inline_fold.rules" with others!
Add an image so we can see it in action.
Use reactions.
Only write recipes in comments :) - I will hide any unrelated comment

Fold


[build-script] Add Product for libc++

In a non-legacy-impl world, this is needed to trigger
building/installing libc++.
Resolves SR-9861

Linux Toolchain (Ubuntu 16.04)
Download Toolchain
Git Sha - a20050ab3010916d1751896ffaab9fe2f3d4eafb
Install command
tar zxf  swift-PR-22346-151-ubuntu16.04.tar.gz
More info

macOS Toolchain
Download Toolchain
Git Sha - a20050ab3010916d1751896ffaab9fe2f3d4eafb
Install command
tar -zxf  swift-PR-22346-198-osx.tar.gz --directory ~/

Verified the toolchain contained libc++ headers and that my C++ project now builds with this toolchain.

@swift-ci please smoke test

@swift-ci please smoke test


MODFQMMGR-488 & MODFQMMGR-528: Organization entity adjustments

Purpose
MODFQMMGR-488
MODFQMMGR-528
Note: since only columns, and not nested fields can hidden, I just commented out the nested fields that were requested to be marked hidden

won't en_US.json file require change @bvsharp

Should 'Vendor Organization' be changed to 'Vendor Org' when adding the translation to the composite entity type of POL?. You can confirm with Kathleen, since one of my tickets had the same thing. The Green table in the very end of description


Add poppins font and landing2.png

I improved the design of the UI by changing it's font and width of the box in which the outputs are generated and also updated the design image in the README.MD file, @atapas , please review and let me know what you think!

Great work! Will review in detail shortly!


Setup CI to deploy image to github registry

Hey @albttx thanks for this, I ended up using a different config, but didn't even know this was possible. Huge thanks for it and now tdv2 has docker images :)


⚠ Bofrost.de has degraded performance

In 15b97fa, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1141 ms

Resolved: Bofrost.de performance has improved in e3fd7cc after 6 minutes.


Finish CPU initialization via FPU and D/I-cache activations

Hi Iliass (@imahjoub) and Amine (@Chalandi) I have the code for this easily accessible in another Repo of mine, so I can easily handle this issue.

Fixed by 399b91ec090c7ac105c2790695ebfb48c8fd92e0
Cc: @Chalandi and @imahjoub


Review

review in progress

@PedroMiguelSS following up on #5, I did some first pass and brought up aegir lint to the lint npm script. Please do follow the JS Community Guidelines for the js.ipfs.io website.

@diasdavid aegir lint config does not support imports either react stuff. I've tried to override its config using .eslintrc.json file, extending to eslint-config-aegir, but I did not succeed. So, I must create a PR to aegir to accept this option.
Should I create a PR at the end of the project or do you want me to do that now?


Enhancment.

Great Library (only one that seems to work with sub-folders on external storage (ie Media/subfolder returns the correct content UIR)
Suggesion to add Helpers to get the Document, Cache etc. folders for the application (currently I have to use another file system library to get those (but only this library will actually copy the file)).  Would be nice helper funtions.
for example.
https://www.npmjs.com/package/react-native-file-access#directory-constants
or
RNFS.DocumentDirectoryPath etc if using react-native-fs


Xtensa architecture tracking issue

This issue aims to track the progress of adding Xtensa support to probe-rs, in particular the Xtensa esp targets.

[x] Initial Xtensa support, Xdm communication with halt/resume and memory interface - https://github.com/probe-rs/probe-rs/pull/1928
[x]  Add detection of on chip flash sizes - https://github.com/probe-rs/probe-rs/pull/1952,
[x] Implement Xdm batching - https://github.com/probe-rs/probe-rs/pull/1969
[x] Implement breakpoint support - https://github.com/probe-rs/probe-rs/pull/1977
[ ] Improve JTAG probes to be able to work with ESP32

[x] J-Link https://github.com/probe-rs/probe-rs/pull/2025
[x] FTDI (e.g. esp-prog) https://github.com/probe-rs/probe-rs/pull/2016

[x] Support flashing the esp32s3 - https://github.com/probe-rs/probe-rs/pull/1956

[ ] support chips with 32MB octal flash

[ ] Support flashing the esp32

[ ] Add work around for TDI level reset for 1.8V flash chips

[ ] Support flashing the esp32s2 - https://github.com/probe-rs/probe-rs/pull/2002
[x] Implement compressed transfers - https://github.com/probe-rs/probe-rs/issues/827, https://github.com/probe-rs/probe-rs/pull/1947
[ ] Add debugger support

[ ] probe-rs uses capstone for disassembly which doesn't yet support Xtensa

Flashing support status update:
ESP32-S3 should be woring with all supported probes (tested with J-Link, esp-prog, a random FT232H board and espusbjtag).
S2 is hopefully just a matter of debugging the flash loader.
ESP32 is a different story. probe-rs is still too limited to support it in at least two ways:

There is no (working) way to specify for the flasher where to download the image chunks. This means they will be downloaded next to the flash loader algorithm. This is a problem for complicated device-specific reasons (no suitable single SRAM region). It can be worked around by filling out the SRAM where the flash loader is located but it's one more hack on top of a pile of other hacks already used by the Xtensa loaders.
There is currently no way to specify what level TDI should take for states where it is not used. The TDI input is used as a strapping pin which sets the flash chip's voltage level on startup. ESP32 modules come in two variants: with 1.8V flash, or 3.3V. If the input is low level on power up, ESP32 assumes a 3.3V flash chip is connected, and vice versa. This means that currently an ESP32 connected to probe-rs must not be reset.

For info using the latest stable version of probe-rs under windows
ESP32 - ProS3 Board
I had a quick try with the ProS3 board which is an ESP32S3, that appears to use EspJtag

https://esp32s3.com/pros3.html
Flashing with probe-rs doesn't currently work
https://github.com/probe-rs/probe-rs/discussions/2272
I tried fhashing with the esptool after restoring the original driver, switching back to winusb
then trying to attach under vscode, this seemed to allow me to attach I think, although no breakpoints and stepping caused errors

ESP32-Wroom-32
I had more luck with the ESP32-Wroom-32 board.
Although not with some other boards I tried

https://github.com/probe-rs/probe-rs/discussions/2275

Flashing with probe-rs doesn't currently work

That's interesting considering I did most of the work while working with an S3. Can you provide more info?

Just created a new Xtensa issue: https://github.com/probe-rs/probe-rs/issues/2301

Capstone has now a WIP PR for Xtensa support: https://github.com/capstone-engine/capstone/pull/2380. Better track this one, we hope it can be finished before the v6 release in September.


Release 2.2.0

This is a draft of changelog for the 2.2.0 release.
Here you can find all related translations changes: 2.1.0...master.

⚠ Do not merge this pull request manually ⚠
You should approve this pull request instead. After approving, I will automatically update it (release date needs to be adjusted), merge, and tag a new release. You can read more about the process on forum.

Show release notes preview
2.2.0

General changes:

Updated Flarum core translations.

Added support for new extensions:

blomstra/search
clarkwinkelmann/flarum-ext-first-post-approval
datlechin/flarum-link-preview
fof/formatting
fof/user-bio
jslirola/flarum-ext-login2seeplus
justoverclock/flarum-ext-welcomebox
v17development/flarum-seo

Updated translations for extensions:

afrux/forum-widgets-core
afrux/news-widget
flarum/akismet
flarum/flags
flarum/likes
flarum/statistics
flarum/tags
fof/socialprofile

All changes: 2.1.0...2.2.0.

Success! Now you can announce new release on forum:
## Version [`2.2.0`](https://github.com/flarum-lang/hebrew/releases/tag/2.2.0)

**General changes**:

* Updated Flarum core translations.

**Added support for new extensions**:

* [`blomstra/search`](https://github.com/blomstra/flarum-ext-search)
* [`clarkwinkelmann/flarum-ext-first-post-approval`](https://github.com/clarkwinkelmann/flarum-ext-first-post-approval)
* [`datlechin/flarum-link-preview`](https://github.com/datlechin/flarum-link-preview)
* [`fof/formatting`](https://github.com/FriendsOfFlarum/formatting)
* [`fof/user-bio`](https://github.com/FriendsOfFlarum/user-bio)
* [`jslirola/flarum-ext-login2seeplus`](https://github.com/jslirola/flarum-ext-login2seeplus)
* [`justoverclock/flarum-ext-welcomebox`](https://github.com/justoverclockl/flarum-ext-welcomebox)
* [`v17development/flarum-seo`](https://github.com/v17development/flarum-seo)

**Updated translations for extensions**:

* [`afrux/forum-widgets-core`](https://github.com/afrux/forum-widgets-core)
* [`afrux/news-widget`](https://github.com/afrux/news-widget)
* [`flarum/akismet`](https://github.com/flarum/akismet)
* [`flarum/flags`](https://github.com/flarum/flags)
* [`flarum/likes`](https://github.com/flarum/likes)
* [`flarum/statistics`](https://github.com/flarum/statistics)
* [`flarum/tags`](https://github.com/flarum/tags)
* [`fof/socialprofile`](https://github.com/FriendsOfFlarum/socialprofile)

All changes: [2.1.0...2.2.0](https://github.com/flarum-lang/hebrew/compare/2.1.0...2.2.0).

In order to update run these commands:

```console
composer update flarum-lang/hebrew
php flarum cache:clear
```


All feature tests were failed, cause I have a module named Addressable?

Hi @jnicklas
I got  a module named addressable in app/models/concerns, to manage addresses phones and faxes. After I upgrade capybara to latest version, all my feature tests were failed. And failure message:
undefined method `addresses' for #<User:0x0000000414b870>

I noticed version 2.6.2 is forced dependency on gem addressable, did it override my Addressable ? and what need I do?
Any thoughts?

Move Capybara back to 2.5.x, or change/scope the name of your addressable module

Why should client code be changed because of a test dependency ? That is still an issue imho.

@kofronpi - so if you had an app dealing with rodents that happened to have a Capybara model in it, you would require Capybara to change its class/module names so you can use it to test?


Passing encoding to Blaze URI's

Hey, I'm just starting to look at incorporating your work on Blaze into tabview (firecat53/tabview#127) and was wondering if there's a way to pass the encoding on to Blaze?
Trying gtabview file:///path/to/tabview/samples/test_latin1.csv gives:
Traceback (most recent call last):
  File "/home/firecat53/.local/share/virtualenvs/gtabview/bin/gtabview", line 4, in <module>
    __import__('pkg_resources').run_script('gtabview==0.4', 'gtabview')
  File "/home/firecat53/.local/share/virtualenvs/gtabview/lib/python3.4/site-packages/pkg_resources/__init__.py", line 735, in run_script
    self.require(requires)[0].run_script(script_name, ns)
  File "/home/firecat53/.local/share/virtualenvs/gtabview/lib/python3.4/site-packages/pkg_resources/__init__.py", line 1652, in run_script
    exec(code, namespace, namespace)
  File "/home/firecat53/.local/share/virtualenvs/gtabview/lib/python3.4/site-packages/gtabview-0.4-py3.4.egg/EGG-INFO/scripts/gtabview", line 94, in <module>
    transpose=args.transpose, metavar=args.filename)
  File "/home/firecat53/.local/share/virtualenvs/gtabview/lib/python3.4/site-packages/gtabview-0.4-py3.4.egg/gtabview/__init__.py", line 178, in view
    data = blaze_from_uri(data)
  File "/home/firecat53/.local/share/virtualenvs/gtabview/lib/python3.4/site-packages/gtabview-0.4-py3.4.egg/gtabview/__init__.py", line 125, in blaze_from_uri
    return blaze.Data(uri)
  File "/home/firecat53/.local/share/virtualenvs/gtabview/lib/python3.4/site-packages/blaze/interactive.py", line 56, in Data
    **kwargs)
  File "/home/firecat53/.local/share/virtualenvs/gtabview/lib/python3.4/site-packages/odo/regex.py", line 64, in __call__
    return self.dispatch(s)(s, *args, **kwargs)
  File "/home/firecat53/.local/share/virtualenvs/gtabview/lib/python3.4/site-packages/odo/backends/csv.py", line 278, in resource_csv
    return CSV(uri, **kwargs)
  File "/home/firecat53/.local/share/virtualenvs/gtabview/lib/python3.4/site-packages/odo/backends/csv.py", line 104, in __init__
    infer_header(path, sniff_nbytes))
  File "/home/firecat53/.local/share/virtualenvs/gtabview/lib/python3.4/site-packages/odo/backends/csv.py", line 60, in infer_header
    return csv.Sniffer().has_header(raw if PY2 else raw.decode(encoding))
UnicodeDecodeError: 'utf-8' codec can't decode byte 0xae in position 460: invalid start byte

Trying to pass the encoding with -e doesn't seem to help. Ideas?
Thanks,
Scott

Maybe @cpcloud or @llllllllll can help on this

It looks like we are not forwarding the encoding to the csv header check. I will update this.

I have a fix that allows us to open this file when encoding=latin1 is passed to resource, Data or CSV


Switch from infinite retries on upgrade to 10 retries.

This changes the flutter tool to just try 10 times before giving up when running "flutter upgrade".  Infinite retries can hang bots, and really don't provide a lot of help: if we've failed to upgrade for for nearly a minute, trying every five seconds, then something is just not responding.
Also, changed the bot default warning level to "normal" from "all", because the solver messages are VERY verbose: several megs of output for doing packages get on Flutter.  "normal" will give warnings, user messages and errors, which should be sufficient to diagnose problems on the bots without spamming the log.

I went through enough tests on the bots that I think the Windows one works as expected, however, I removed the retrying for building the snapshot because we don't do that on the other platforms, and because I can't imagine how running it again would give a different answer.
I also fixed a problem in the whitespace detection when no files matched the type of file that it is looking for.


add Utils::htmlGermanCharacter

Add an small function to replace german characters to the corresponding html entities.
Maybe this will be useful for others.
(My md-files contains a lot of german chars :-))

Grüße aus Köln :-)

You really don't need this function as it's built into PHP with simply:
echo htmlentitites("Ich werde mir die größte Mühge geben zu lernen.");

Of corse you can use the well-known PHP-Function, but then i can't simply replace only the german chars within an HTML-content.
As you can see, i simply process the hole content, which is not super-performant and smart, but simple.
Due to that fact, i can't use htmlentitites at that point. (e.g. '<' and '>' will lead to their html-entities)


Polymer app not loading on iOS 8

 Issue by markhats
Originally opened as dart-lang/sdk#21629

I have a Polymer app that is refusing to load properly on iOS 8 Safari. It works on all other browsers/devices including iOS 8 Chrome and iOS 7 Safari. I have produced a much smaller app which exhibits the same problem, although this one does seem to load OK sometimes.
On startup, the static parts of the page are displayed but none of the Polymer elements appear and the app remains non-functional. It seems to be something to do with the call to initPolymer. My main function looks like this:
void main()
{
   window.alert("Inside main");
   var dirtycheckingzone = initPolymer();
   window.alert("initPolymer called: dirtycheckingzone = $dirtycheckingzone");
   // Run the whole app in the dirty checking zone so that observables are always updated in the DOM
   dirtycheckingzone.run(() {
      window.alert("Inside dirtycheckingzone.run");
      Polymer.onReady.then((e){
         window.alert("Polymer Ready");
      });
   });
}
On iOS 8 Safari, only the first alert ever gets displayed. Therefore it seems the problem must be somewhere in initPolymer. However, I have no idea how to debug this. I have tried remote debugging to iOS Safari from the Mac version of Safari. However, I can't seem to get this to break early enough and refreshing the page generally causes the Web Inspector to hang, There is nothing however in the Console that looks suspicious.
You can seem to get this smaller app to run by clicking "Refresh". However, if you close the tab and browse to the page again in a new one, it fails again.
You can try the page at:
http://www.autograph-maths.com/deepquerytest/deepquerytest.html
The project is attached. Ignore the functionality of the app. It was primarily created for another test.

Attachment:
DeepQueryTest2.zip (1.62 MB)

 Comment by sgjesse

Added Area-Pkg, Pkg-Polymer, Triaged labels.

 Comment by markhats

This problem still seems to exist in latest dev release of Dart and also Bleeding Edge 1.9.0.edge_043998.
I have done a bit more investigation and have a test case that fails at:
http://www.autograph-maths.com/webversion-ipadtest/autograph.html
This only fails in Safari on some iOS devices. I have 3 iPads to test on, all on iOS 8.1.3, and it fails on 2 of them and succeeds on the other one. I am  now listening to 'window.onerror' outside of my Dart code to see if any errors occur. These are displayed as alerts. On the two devices that fail I do get two errors of the form:
Error: TypeError: Attempted to assign to readonly property    (see attached images)
The first seems to occur in the eval function in my main dart2js generated js file.
 eval$1: function(code) {
 ....
 finally {
        this._isExecutingEvent = false;
        init.globalState.currentContext = H.interceptedTypeCheck(old, "$is_IsolateContext");
        if (old != null)
          $ = old.get$isolateStatics();
        if (this._scheduledControlEvents != null)
          for (; t1 = this._scheduledControlEvents, !t1.get$isEmpty(t1);)       <<<<<<<<<<<< This is line 1768
            this._scheduledControlEvents.removeFirst$0().call$0();
      }
      return result;
    }
The second error occurs in webcomponents.js at the following code:
function MutationRecord(type, target) {
      this.type = type;                                 <<<<<<<<<<<<< This is line 583
      this.target = target;
      this.addedNodes = new wrappers.NodeList();
      this.removedNodes = new wrappers.NodeList();
      this.previousSibling = null;
      this.nextSibling = null;
      this.attributeName = null;
      this.attributeNamespace = null;
      this.oldValue = null;
    }
Does this offer any more clues?
Also see:
https://groups.google.com/a/dartlang.org/forum/#!topic/web/b9c9BPjOO34
https://groups.google.com/a/dartlang.org/forum/#!topic/web/Jo9N8PBaIXQ

Attachments:
iOS-Error-1.png (23.77 KB)
iOS-Error-2.png (24.82 KB)

 Comment by markhats

I think this may be related to:
https://github.com/emberjs/ember.js/issues/5606
and
https://github.com/uhop/dcl/issues/15
I have discovered that it only seems to fail on iOS 8 32-bit devices, i.e. anything up to and including 4th generation iPads. There is also a Polymer bug mentioned in the above links:
https://github.com/Polymer/platform/issues/66
However, this is no longer accessible and I'm not sure where it was moved to.
This jsfiddle seems to exhibit the same symptoms and fails on the same devices as my app:
http://jsfiddle.net/adrian_vasiliu/ftyafr0d/

Is this going to be fixed?

I'm having this same issue using Polymer dart in ios 8. No matter what I do I get error along the lines of Attempted to assign to read only property. Only starts working when I remove all polymer component imports. Is there any intention to actually get this bug fixed?

I am getting the same error as both markhats and aslanvaroqua are reporting.

I'n not convinced anyone is looking at bugs in the current version of Polymer (0.16) any more. I have some others outstanding that have not seen any action at all, which is quite frustrating.
The good news is that this problem does seem to have been fixed in iOS9 Beta, although obviously this doesn't help for iOS8 users.


New version - import Rhino options doesn't load playback driver type

please close this occur without performing connection to Agent.

please close this occur without performing connection to Agent.


Trigger onFocus/onBlur instead of onPressIn/onPressOut (eventually, but for now just deprecate)

Currently on iOS and Android focus/blur events trigger onPressIn/onPressOut. Based on discussions with people are several companies who use react-native we're proposing instead triggering new events onFocus/onBlur. Initial discussion on Slack with some from the core team on Slack seemed positive.
Couple reasons:

The current API behavior overloads onPressIn/onPressOut. That means on platforms like react-native-web, if focus/blur support was added (as we're hoping for), even though onPressIn/onPressOut would be useful as the name describes, you wouldn't be able to distinguish between it and browser element focus/blur events.
The names aren't as self-documenting/intuitive as onFocus/onBlur, especially for react-dom users.

Test Plan
There aren't any current tests around this, but I intend to add them if we solidify the API.
There's also an option question on the transition--do we deprecate the existing API with a warning? This PR just deprecates them, though it will on any TV platform when something becomes focused regardless of whether they use the API or not. This isn't ideal. It's not clear if there are alternatives or if just right away breaking the API for TV users is the correct solution, if we can get consensus between the few parties who are using it.

I'm interested to hear counter points or prior discussions.
Cc/ @matthargett @dlowder-salesforce @rozele

Needs release notes and an update to RNTester, but LGTM otherwise! :D

Awesome. Looks good to me as well.
+1 for onFocus and onBlur.

I'm not sure I understand these changes.... I had the impression that developers using RN would not use Touchable directly, but use TouchableOpacity, TouchableHighlight, etc., which implement onTouchableHandleActivePressIn (and Out).  So it seems to me that those files also need to change, yes?

Does anyone have further feedback on this before I continue to try and add tests?
It's so far unclear how exactly I'd test this as there aren't any existing tests AFAICT and testing it fully require interactions between native->JS. Regardless I'm gonna spend some additional time attempting to do so--if you have suggestions or prior art, lmk! ✌

btw the build is failing on android because a facebook-specific buck flag has slipped into master (unrelated to this PR) ✌
BUILD FAILED: Buck wasn't able to parse /home/circleci/react-native/ReactAndroid/src/main/jni/react/jni/BUCK:
Incorrect arguments to cxx_library with name jni: Extra unknown kwargs: fbandroid_allow_jni_merging

@facebook-github-bot shipit

Does RN have an official deprecation process? When this is merged should I create the follow up PR to remove the deprecated calling of onPressIn/Out for focus events?

I don't think there's anything official - we usually do the depreciation PR
and then, remove it few versions later entirely.
On Mon, 9 Apr 2018 at 19:32 Jay Phelps<EMAIL_ADDRESS>wrote:

Does RN have an official deprecation process? When this is merged should I
create the follow up PR to remove the deprecated calling of onPressIn/Out
for focus events?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/facebook/react-native/pull/18470#issuecomment-379831262,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACWcxjhBKLUy_hu10K7ol-xdG3nnzgI0ks5tm5tAgaJpZM4SyeBe
.

@grabbou Thanks for your help! Anything I can do to help get this over the finish line?

I think just a final word from @matthargett and @dlowder-salesforce as people interested in this proposal would be good.
Was there anyone else involved in Slack discussions? To be honest, I don't recall what was the conclusion there.

final word(s): LGTM #shipit

:shipit:

@jayphelps can I ask you for resolving conflicts for the last time and we shipt it?

@grabbou master is currently failing 😢 looks like the snapshots need updating

@jayphelps we just need to resolve two conflicts in this PR by hitting Resolve conflicts button and I'll merge straight away (even if the tests fail later on since that's reasonable).

@grabbou rebased!

bump

rebased.

@facebook-github-bot shipit


Simplifying the hadoop related dependencies

"registry-common" has dependencies on hadoop-client, hadoop-aws, hadoop-azure.... Wherever registry-common, all these dependencies get along as transitive dependencies. Some of these dependencies need to be pruned out.

Clients that use authorization-agent should not depend on hadoop library for Authorization exception.

Done.


fix eval_detection_coco to work when classes are missing

Merge after #645
The implementation was inconsistent with the documentation when classes are missing in gt and pred.

Updated


1.21 Support

I know this mod isn't being updated anymore, but I really like it, so I did it myself:
This PR adapts the existing code to Minecraft 1.21.
Quick overview of all changes:

Update Loom, Fabric and Java
new Identifier() changed to Identifier.of()
BlockScreenOpener uses components instead of NBT now, greatly simplifying code
BlockView was renamed to WorldView
Removed some @Overwrite's in FakeWorld, because they don't exist in ServerWorld anymore

Tested with Shulker Box, Anvil (all types), Enchantment Table and Crafting Table.
These changes could also easily be adapted to work with 1.20.5 if necessary.
(Also, you probably want to create a new 1.21 branch for this instead of merging it into 1.20.1)

Thank you so much for sharing this, @JongWasTaken! One of the most essential mods for me ever since I started using it in 1.19 – it basically solves the inventory problem, at least in my book. I was looking into upgrading this myself a few weeks back, but that was my first deeper look into MC modding in a while, so I ended up getting stuck quickly. So I worked on two simpler mods the last two weeks instead, and now just came back here to give it another go, but finding you have already done it! 🎉
Your version is running great for me! Do you plan putting up a fork on Modrinth? If not, I might even consider doing so myself… I want more people to get this amazing experience. 😄

Thank you for the kind words @manuelgrabowski!
I also much prefer this mod over similar backpack type of mods, as it finally gives shulkers more of a reason to be used. I guess some people would disagree because of the sheer amount of inventory size you can get with this, but as the owner of a build-centric survival server, this mod is an absolute godsend when it comes to having building resources on hand.
Concerning publishing a fork, I am a bit reluctant, as I don't want to claim @Hoid2's work without express permission to do so first. I think the ideal solution would be for them to merge PRs like this and to continue publishing releases, though I also understand if they don't want to do so.
So basically, if Hoid2 gives me permission, I would be more than happy to continue maintaining a fork of this and publishing it on Modrinth and CurseForge myself. Otherwise I will just continue to post PRs right here.
Either way, I wish everybody reading this a great day (or rest of it)!

Ah, I realize now that I had mixed up this situation with another mod that hasn't been updated yet… still waiting on a bunch more, the 1.20.5 NBT/component change understandably killed off quite a few mods' further development it seems.
On the one I was thinking about when writing my earlier comment, the original dev has stopped engaging with the project for over a year now, even befoe the 1.20.5 changes… so it seems unlikely they'd come back to give or deny permission. In a situation like that I think it's fair to just follow what the license allows. But totally with you in this case, @Hoid2 should definitely have a chance to consider just merging this themselves. If you're reading this, Hoid – sorry if I sounded overly dismissive. I'm so grateful for how much more awesome you made the last few years of playing Minecraft for me!
What I love about the approach of this mod is also how "vanilla" it is – no new special items for more storage, just making what's already in the game so much more accessible. Because of that it's also wonderfully "backwards-compatible", no need to worry about what happens to my items if I stop using the mod. For me it's not even so much about the inventory space that this enables, but the ease of use. Constantly placing my ender chest, and then shulker boxes only to take out a new stack of rockets or similar, and then breaking both containers again… I've done that long enough, that's just not doing anything for me gameplay-wise. I'd rather use my time in MC doing actual things than repeating these steps all the time. 😄

@JongWasTaken if you would like to maintain/publish a fork you have my
permission. I'm sure many people would appreciate that.
I'm not in a position to do any development (including merging prs) and
won't be for a couple of years.
On Sat, Jul 27, 2024, 3:58 PM Manu @.***> wrote:

Ah, I realize now that I had mixed up this situation with another mod that
hasn't been updated yet… still waiting on a bunch more, the 1.20.5
NBT/component change understandably killed off quite a few mods' further
development it seems.
On the one I was thinking about when writing my earlier comment, the
original dev has stopped engaging with the project for over a year now,
even befoe the 1.20.5 changes… so it seems unlikely they'd come back to
give or deny permission. In a situation like that I think it's fair to just
follow what the license allows. But totally with you in this case, @Hoid2
https://urldefense.com/v3/__https://github.com/Hoid2__;!!Oz_3W2l6Vjs!_0MPyiTTkq_LohTx6MMnjViA92mj9ssfhNoJnlaubMPVE3rqo0pHhCPg5gKkuVKTe7zspUNnaojAT3y3R0mCEcS6UhueZdY$
should definitely have a chance to consider just merging this themselves.
If you're reading this, Hoid – sorry if I sounded overly dismissive. I'm so
grateful for how much more awesome you made the last few years of playing
Minecraft for me!
What I love about the approach of this mod is also how "vanilla" it is –
no new special items for more storage, just making what's already in the
game so much more accessible. Because of that it's also wonderfully
"backwards-compatible", no need to worry about what happens to my items if
I stop using the mod. For me it's not even so much about the inventory
space that this enables, but the ease of use. Constantly placing my ender
chest, and then shulker boxes only to take out a new stack of rockets or
similar, and then breaking both containers again… I've done that long
enough, that's just not doing anything for me gameplay-wise. I'd rather use
my time in MC doing actual things than repeating these steps all the time.
😄
—
Reply to this email directly, view it on GitHub
https://urldefense.com/v3/__https://github.com/RealMegaMinds/ClickOpener/pull/17*issuecomment-2254264192__;Iw!!Oz_3W2l6Vjs!_0MPyiTTkq_LohTx6MMnjViA92mj9ssfhNoJnlaubMPVE3rqo0pHhCPg5gKkuVKTe7zspUNnaojAT3y3R0mCEcS6jhExxrY$,
or unsubscribe
https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AOSBBQ27QM5FCA4VBCNQRH3ZOQJYHAVCNFSM6AAAAABLIETHF2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENJUGI3DIMJZGI__;!!Oz_3W2l6Vjs!_0MPyiTTkq_LohTx6MMnjViA92mj9ssfhNoJnlaubMPVE3rqo0pHhCPg5gKkuVKTe7zspUNnaojAT3y3R0mCEcS6KTspyQQ$
.
You are receiving this because you were mentioned.Message ID:
@.***>


about the 5G and UWB frequency.

Hello, I am the developer of DW1000. I checked the information and found that the 5G frequency band and many channel frequency bands of DW1000 overlap. I want to ask you something: Will the upcoming 5G affect UWB ultra-wideband communication?
thank u :)

Hi AlCrazy,
Yes it will. Especially when the uwb transceiver is in close proximity to a 5G transmitter. This is why uwb channel 9 (~8GHz) may be a better choice in the future as well as rf filtering.
Cheers,
Niklas


LCCS tool: explore page header

Adds the header area to the explore page which displays the selected location from the index page (location search).
Tasks

[x] handles keeping the location synced between index / select location page & explore data page
[x] header title contains selected location title text
[x] header contains static locator map of selected location
[x] header contains button for generate pdf report
[x] header contains button for select another location
[x] clicking change location button navigates back to index page

Other

Updates the StaticMap shared component used by tools to be either a clickable button or a non-clickable <div> element. The LCCS tool has a separate "change location" button that is more obvious so we don't need the locator map to also serve as a change location mechanism.

As a bonus this PR adds Sass Mixins for media queries that correspond to breakpoints in the Carbon Design Grid system. I plan on adding these into the main branch so they can be used elsewhere if needed before the LCCS tool migration is completed.

Known Bugs

Change Location in explore page will cause the index page to fail to load the location for some place names because their geographic center is located outside of their boundary polygon (e.g. San Francisco, Alameda). Problem has to do with using lng, lat, boundary type to reverse geocode to find a boundary polygon.

Locator static map in Explore fails to render if polygon geometry is invalid due to simplification. Larger issue with this component which could be addressed by rendering the static map using another strategy than MapBox's static map API.

 LCCS: Header component

@elehmer here is a Netlify preview deploy for you to try out. The PR description up top describes what this PR should accomplish and also lists known bugs. Let me know if you discover anything else that doesn't seem right. Thanks!


feat: add Title option for lists

This is needed to fully replace the features of tree where we were able to set a name for the root node.

[ ] support any type instead of just string

Merging with https://github.com/charmbracelet/lipgloss/pull/339


I can't control the weather nor the particles.

I think the weather part is self-explainatory, but I can elaborate if needed.
about the particles, it's kind of annoying that whenever it rains the wind moves particles (ex. blocks breaking)

I will add a setting that disables this effect.

In terms of the particles, I will add a setting that disables this effect.
Though in terms of weather, I'm not sure if I understand, could you please elaborate on this?

In terms of the particles, I will add a setting that disables this effect. Though in terms of weather, I'm not sure if I understand, could you please elaborate on this?

I can't find the command to change the weather (ex. "/weather rain"), I'm not sure why.

That's because there is no command to change the weather

I see, thanks for telling me.
will you add one in the future?

Due to the way the weather works, it would be really difficult if not impossible to do that, I might add something of the sort, but it wouldn't be what you would expect where you could just go /weather rain to use it.


SNOW-1413958: Skip optimizing dynamic pivot query plan using CTE

Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

Fixes SNOW-NNNNNNN

Fill out the following pre-review checklist:

[ ] I am adding a new automated test(s) to verify correctness of my new code
[ ] I am adding new logging messages
[ ] I am adding a new telemetry message
[ ] I am adding new credentials
[ ] I am adding a new dependency

Please describe how your code solves the related issue.
Due to https://snowflakecomputing.atlassian.net/browse/SNOW-1375062, we need to skip optimizing dynamic pivot query plan using CTE. Specifically, any subquery under dynamic pivot plan will not be converted to a CTE.

Fixes SNOW-NNNNNNN
Please update.

Fixes SNOW-NNNNNNN
Please update.

done


Reference style links are output twice

In this [example link] there is a missing space after the link.

[example link]: http://www.example.com/

You're correct! The original code on main uses genpdf, which is an outdated package and lacks support for annotations and several other features. I’ve forked the repo and started updating it to include annotations and features available in printpdf but missing from genpdf. You can find the updated repository here: genpdf-rs-improved.
In parallel, I’m integrating this updated genpdf-rs-improved into mdPdf on the feature/styling branch.

Thank you for your patience with this issue. I'm pleased to announce that it has been resolved with the following improvements:

Added comprehensive styling support
Implemented "working" annotations
Fixed the core issue

These changes have been merged in PR #3.
I apologize for the delay in addressing this - I was in the midst of a job transition. Now that I'm settled, I'll be more responsive to issues and pull requests.
Please let me know if you encounter any problems with the implementation.

No worries, thanks for the fix.


fix: Don't block on add_reader/writer future

Client._on_socket_register_writer() may be called from the event loop, in which case adding a Task to that loop then blocking on its completion will deadlock.
Fixes #174

Thank you for the quick follow up and patch. :+1: LGTM!
Sorry for the slow response form my side. I've been on vacation.
~Frederik


Define keyboard shortcut scheme

We should come up with a scheme for keyboard shortcuts and start defining/documenting them.

Useful reading: https://developer.gnome.org/hig/stable/pointer-and-touch-input.html.en


The Ink Cartridge Suggestion

It's tooltip is "May be refilled useing dyes to use for 3D prints" however its now also used for the Wide Format Printer, which is not a 3D printer but a 2D Printer,
I propose the tooltip is changed to, "May be refilled useing dyes to use for all kinds of prints." or something similar.

https://github.com/SwitchCraftCC/sc-peripherals/blob/252d0fa97f450e622852105f32af3395c4190bc3/src/main/resources/assets/sc-peripherals/lang/en_us.json#L19 PRs welcome

"for all kinds of prints" is too vague. The tooltips serve as their own documentation, so should be short but fully descriptive of what the item is useful for/can be used with. It also helps with keyword stuffing for REI searches.


HideExpression in Nested form

Hi,
I have been working on this example (http://angular-formly.com/#/example/other/nested-formly-forms) to make a nested form.
It perfectly worked but when i'm in the field inside the nested form i can't access the global model :
In the type "nested" i can access all the model but in data -> field i only have the model of the nested field.
I would like to hide the 2nd field of Address only if it's checked in the first nested form.
I wrote a jsbin to explain my problem : http://jsbin.com/lukuroxuni/1/edit?js,output
Can anyone help me?
Thx,
Cédric

Could you use formState? http://kentcdodds.jsbin.com/vowuso/edit?html,js
Note, I changed the template for the nested type slightly and bound the checkbox to formState and updated the hideExpression. I think this is possibly what you're looking for.
Either way, the GitHub issues on this repository are reserved for bug reports or feature requests. If you have further questions, please follow the instructions here: http://chat.angular-formly.com


CTC loss does not go down

Hi. Appreciate you work! I adjust your code for my dataset, but ctc loss doesn't go down, and accuracy remains only 20%. Have you met this problem before?
Also, I noticed you used your own calculate_label function instead of ctc_greedy_decoder or ctc_beam_search_decoder. I choose ctc_greedy_decoder. Is this the problem?
Thank you.

Hi,
it has been some time that I have worked with this, so I am not a 100% sure about everything.
But I remember that the learning rate was really important (as always) and was the main parameter to fine tune.
Regarding the decoder, ctc_greedy decoder is used here here.
This calculate_label is basically another decoding on top of ctc greedy decoding. It assigns the whole clip only one single label.
The greedy decoding is anyway independent of the loss calculation, therefore, it has nothing to do with it not decreasing. Check here.
Good luck.

Thank you for replying.
I'm pretty sure the data's dimensions is correct.
Do you remember your learning rate? And can you do me a favor and check tower_loss function in r3dcnn.py? I think it's not correct...

Thank you for replying.
I have a question for tf.nn.ctc_loss function's parameters.
The document said, "The inputs Tensor's innermost dimension size, num_classes, represents num_labels + 1 classes, where num_labels is the number of true labels, and the largest value (num_classes - 1) is reserved for the blank label." I noticed your inputs parameter's innermost dimension size is num_labels + 2 because you set "0" as "no gesture" class. According to my understanding, it's actually the same class because "no gesture" means the that there is a "blank" between two actual gestures, am I right?

@lchaooo
I think it's actually the same class because "no gesture" means the that there is a "blank" between two actual gestures.
Can you show me the structure of the dataset in detail. Furthermore, which benchmark dataset are you using.
Thank you very much!

@lchaooo
Hello, I have changed the size of the learning rate several times.  .However, the loss function value of the training set is still large.  It starts to decay over 20,000. Have you ever been in this situation before.
Thanks so much!