Undefined values in update criteria updates entire table

Waterline version: 0.13.4
Node version: 8.11.2
NPM version: 5.6.0
Operating system: Fedora 27, 64-Bit

I was creating some functionality in an action when I accidentally passed undefined as a value in the criteria of a model update. This led to every row in my table being updated with the valuesToSet dictionary. I worry about this behavior happening unintentionally in a production application.
I am using the MySQL adapter. I have not tested this in other adapters. The behavior I would expect is either an error thrown, or a success with 0 rows updated, especially since MySQL has no undefined value (that I know of).
sails> var user = undefined;
undefined
sails> User.update({ 'id': user }, { password: '1234' }).fetch().then(ret => { sails.log.debug(ret.length) });
Promise {
  _bitField: 0,
  _fulfillmentHandler0: undefined,
  _rejectionHandler0: undefined,
  _promise0: undefined,
  _receiver0: undefined }
sails> debug: 9

The query sent to the MySQL database:
568 Query	select `id` from `user`
568 Query	update `user` set `password` = '1234', `updatedAt` =<PHONE_NUMBER>213 limit<PHONE_NUMBER>740991
568 Query	select * from `user` where `id` in (1, 34, 35, 36, 37, 38, 39, 40, 41)

Looks like a duplicate of https://github.com/balderdashy/waterline/issues/1509

Didn't see that, thanks. Closing as dupe.


Clone to desktop permission

i reinstalled my laptop and when i run command
git clone git@github.com:gios-asu/sustainability-game.git
it said that i need permission to do so.

If you are using git@github syntax, you will need an ssh key. Use https://github.com... instead.

You will need to change your remote:
git remote origin set-url https://github.com/gios-asu/dont-get-fired-game.git

its work perfectly fine thanks


Copy release prod chart images to private ECR

Issue #, if available:
Description of changes:
Copy release chart images over to private ECR.

/approve
/lgtm


Release 1.4.0 is not building on Linux before Swift 6

error: fatalError
/tmp/swift-docc-plugin/Plugins/Swift-DocC Convert/Symbolic Links/SharedPackagePluginExtensions/PackageManager+getSymbolGraphsForDocC.swift:74:64: error: value of type 'NSLock' has no member 'withLock'
        let targetSymbolGraphs = try symbolGraphGenerationLock.withLock {

$ swift --version
Swift version 5.10 (swift-5.10-RELEASE)
Target: x86_64-unknown-linux-gnu

Ping @d-ronnqvist

I'm seeing this on my Android CI too, can confirm that the just-released 1.4.0 tag broke building this plugin with Swift 5.10.1 on linux:
swift-nio/.build/checkouts/swift-docc-plugin/Plugins/Swift-DocC Convert/Symbolic Links/SharedPackagePluginExtensions/PackageManager+getSymbolGraphsForDocC.swift:74:64: error: value of type 'NSLock' has no member 'withLock'
        let targetSymbolGraphs = try symbolGraphGenerationLock.withLock {
                                     ~~~~~~~~~~~~~~~~~~~~~~~~~ ^~~~~~~~

It works fine with the upcoming Swift 6 and 6.1.

This should be resolved in release 1.4.1 now.

Super, thanks @d-ronnqvist !

I think we're still seeing problems with Swift 5.8.1 on linux:
https://github.com/apple/swift-protobuf/actions/runs/10529237017/job/29178134702?pr=1694

That looks like a different failure than before.

I'm on vacation next week, away from a computer, but I can look at this when I get back if no one else has fixed this by then.


postgres ownership not preserved during pause/restore

Bug report
If you create a Wrapper in Supabase Studio it is owned by the postgres role.
If you then pause and restore the project, the owner of the foreign data wrapper + server change to supabase_admin
Note that the ownership changes for:

The foreign data wrapper create foreign data wrapper ...
The foreign server create server

but not the foreign tables (these continue to be owned by postgres)
I tested with airtable and firebase
There is an associated support ticket (resolved): https://app.hubspot.com/live-messages/19953346/inbox/5492182653#email
please update in the notion task as well as here

internal conversation from notion

I couldn't reproduce with the latest platform locally. I tried creating a stripe wrapper both from the UI and by manually running the SQL commands from the studio. Also tried creating the extension in different schemas as there's another issue in which permissions depend upon the schema. In all cases, the dump file correctly contains lines updating ownership to postgres:
CREATE FOREIGN DATA WRAPPER stripe_wrapper HANDLER extensions.stripe_fdw_handler VALIDATOR extensions.stripe_fdw_validator;

ALTER FOREIGN DATA WRAPPER stripe_wrapper OWNER TO postgres;

CREATE SERVER stripe_server FOREIGN DATA WRAPPER stripe OPTIONS (
    api_key_id 'f869e5ea-a566-4218-aeb1-edeb91ceb055',
    api_url 'https://api.stripe.com/v1'
);

ALTER SERVER stripe_server OWNER TO postgres;

@olirice how exactly did you create the foreign wrapper/server? Can you reproduce it still?


"TypeError: Cannot read properties of undefined (reading 'length')

Hello there,
While trying to create an index I get the error indicated in the title, what could be the issue?
BR

Hi. Based on that error alone, I would assume the index configuration you're sending (settings, mappings, etc.) is incorrect or incomplete. Perhaps you have a mapping where a field type is missing a 'length' parameter.
It does not appear however, to be an issue with this package.

Hello @ThorbenJ and thank you for answering,
Is it necessary to put the settings and mapping when creating a new index?

I am also having errors when testing if an index exists or not, this is the message error I am getting "ResponseError: ".

Regarding create: The Elasticsearch JS client (https://www.elastic.co/guide/en/elasticsearch/client/javascript-api/current/api-reference.html#_create_2) is just calling the ES REST API: https://www.elastic.co/guide/en/elasticsearch/reference/8.8/indices-create-index.html - If what your trying works when you call that API directly, but not using this node, then there is a bug. However all I have to go on is that error message, and that suggests to me the error was from the API about something wrong with the parameters of the index you're trying to create.
The second issue in that screen shot, I assume is because you're using self signed certs for TLS, that are not trusted by the host that Node-Red is running on. In the elasticsearch connection configuration node, you have YAML/JOSN advance settings box where you can pass any options to the elasticsearch js client. Including TLS configuration to add trust for a private CA: https://www.elastic.co/guide/en/elasticsearch/client/javascript-api/current/client-connecting.html#auth-tls
e.g.
tls:
  ca: |
    ----- Start Certifiacte -----
    dlskdls  blah blah kdfldk
    djfsjfkdlskfls fdlfksl;kfs
    ----- End Certificate -----

^ In YAML syntax, and just typed in not checked for syntax mistakes
Please note the input in the config node is not javascript, so calling functions like fs.readFileSync() wont work.
BR,
Thorben

Hello @ThorbenJ ,
Yes, when calling the API directly it works fine here is the output of the curl request.
curl --cacert ca.crt -u elastic:flex23 -X GET "https://localhost:9200/nacer/" | jq   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current                                  Dload  Upload   Total   Spent    Left  Speed 100   302    0   302    0     0   4032      0 --:--:-- --:--:-- --:--:--  4081 {   "nacer": {     "aliases": {},     "mappings": {},     "settings": {       "index": {         "routing": {           "allocation": {             "include": {               "_tier_preference": "data_content"             }           }         },         "number_of_shards": "1",         "provided_name": "nacer",         "creation_date": "1686220540739",         "number_of_replicas": "1",         "uuid": "yWSP8UBqQKyXPilKrHb-Lg",         "version": {           "created": "8080099"         }       }     }   } }
Here are the ES logs when using node to check the index.
{"@timestamp":"2023-06-08T18:30:27.819Z", "log.level": "INFO", "message":"Authentication of [elastic] was terminated by realm [reserved] - failed to authenticate user [elastic]", "ecs.version": "1.2.0","service.name":"ES_ECS","event.dataset":"elasticsearch.server","process.thread.name":"elasticsearch[es01][system_critical_read][T#4]","log.logger":"org.elasticsearch.xpack.security.authc.RealmsAuthenticator","elasticsearch.cluster.uuid":"j2uXbHekTxaMVN332e8jSA","elasticsearch.node.id":"GTx8jgi5QCubhZWkpnJp0A","elasticsearch.node.name":"es01","elasticsearch.cluster.name":"docker-cluster"}

When I put the auth in the advanced YAMl section I no longer "message":"Authentication of [elastic] was terminated by realm [reserved] - failed to authenticate user [elastic]", in ES logs but the error on node-red "ResponseError: "

I have set the credentials to "NONE" and now I am getting this error
"ReferenceError: node is not defined"

The problem in this ticket keeps changing?

A problem with creating an index (i.e. PUT/POST API method; then
TLS certificate verification; then
Authentication with curl example of a GET API method (so not create)

The TLS certificate verification issue is no longer present but still has an authentication issue.

Hi.
So now we have found a bug in this package. The switch/case code to handle the different options for credentials, had a bug for the 'none' case (code path). I've just fixed that and pushed version 0.3.13 with that fixed.
However setting credentials to basic, and putting the username and password in identity and secret results in the same configuration as adding "auth":{"username":"xxx", "password":"xxx"} to Adv. conf, however with the added benefit that the credentials are stored more safely by node-red. Could it be that the username or password were entered wrong when you used 'basic'? Maybe there was an extra space in a copy/paste?
BR,
Thorben

Good news, the nodes are working now for index PUT/GET, but I think you should change the create index node to handle the case when the index parameters are empty because the index is created successfully but still getting this error
"TypeError: Cannot read properties of undefined (reading 'length')"


[BGE-13] Custom HUD malfunctions when riding a boat

The custom HUD inappropriately updates to remove the split between the two bars on the right because it doesn't appropriately check if the entity the player is riding is a LivingEntity.
From SyncLinear.com | BGE-13

Fixed in update v1.2.5 :dumpy:


[SPARK-14422][SQL] Improve handling of optional configs in SQLConf

What changes were proposed in this pull request?
Create a new API for handling Optional Configs in SQLConf.
Right now getConf for OptionalConfigEntry[T] returns value of type T, if doesn't exist throws an exception. Add new method getOptionalConf(suggestions on naming) which will now returns value of type Option[T](so if doesn't exist it returns None).
How was this patch tested?
Add test and ran tests locally.

cc: @vanzin @marmbrus

Test build #57546 has started for PR 12846 at commit 08cea82.

Test build #57546 has finished for PR 12846 at commit 08cea82.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/57546/
Test FAILed.

Test build #57548 has started for PR 12846 at commit 7d9506a.

Test build #57548 has finished for PR 12846 at commit 7d9506a.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/57548/
Test FAILed.

Test build #57558 has started for PR 12846 at commit 5f75242.

Test build #57562 has started for PR 12846 at commit 5a25075.

@vanzin how's it looking now ?

Just a minor thing, otherwise looks ok to me.

Test build #57565 has started for PR 12846 at commit 40f280a.

Fixed 👍

Test build #57558 has finished for PR 12846 at commit 5f75242.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/57558/
Test PASSed.

Test build #57562 has finished for PR 12846 at commit 5a25075.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/57562/
Test FAILed.

Test build #57565 has finished for PR 12846 at commit 40f280a.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/57565/
Test PASSed.

LGTM merging into master 2.0


Figure out how we're gonna use people.yaml and salesforce-export.csv

Right now we have two ways of tracking people in openedx-webhooks, with people.yaml and salesforce-export.csv .  people.yaml is getting pretty out of date.
Figure out what peopl.yaml still being used for and get rid of it if possible.
If we're using it to see which contributors are CCs, we can instead look at what repos they have write permission to and what org they're from to determine that.

I created https://github.com/openedx/openedx-webhooks/issues/207 to capture the work we'll need to do based on the discovery done in this ticket.


Newspaper Downloader

It can download the newspaper in pdf with one click.

resolve conflicts and raise another PR


.distinct() ?

Is it possible to use this with .distinct() ?

@niftylettuce I can't seem to get the above to work. I read distinct doesn't even work with skip and limit


Use tox for pylint

Using tox automatically gives a reproduceable environment no matter
where the test is executed.
Also move pylint config to pylintrc.

Apart from that one comment I have revealing my obsession with make: LGTM


⚠ Bofrost.es has degraded performance

In 547e8d8, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1852 ms

Resolved: Bofrost.es performance has improved in 59e4a00 after 8 minutes.


bucket ACL breaks with provider 3.15

According https://docs.aws.amazon.com/AmazonS3/latest/dev/acl-overview.html in S3 acl    = "bucket-owner-full-control" is ignored, it also breaks with provider 3.15

bump

Hello,
Did you try to update the version of the module ? This was fixed since the 15th of November

try with v2.2.1

Thanks! will try that version :)


Spring cleaning

Type of PR: enhancement
Overview of change:
A variety of changes to mainly reduce the bundle size slightly.

~The main change is to remove the list of css colors, and rather use the browser to convert the names for us.~

~The unit test for named colors has been moved to a graphics e2e test because it now requires the Browser API.~
This change has been reverted. Perhaps a future version could switch to a different approach?

removed log10 function since the native version is supported on everything except ie11, but we were already using the native version in the code so ie11 support was already broken...
Since we only use the roundRect function with the 4 item array, we can remove the extra code for handling the other lengths of array. Additionally, we should be able to switch to the native version in the future since Firefox has added support.
The lowerbound and upperbound functions were almost identical. Refactored to be a single function.

Is there anything you'd like reviewers to focus on?
Each commit has a change to the size-limit file so it is clear what difference each commit makes to the bundle size.
Bundle Size Changes
44.46 → 44.31
44.38 → 44.25
46.08 → 45.95
46.13 → 45.99

It seems that we would prefer to keep the css color names list in the source code instead of switching to using getComputedStyle.
What are the thoughts of maybe doing one of the following instead (BREAKING CHANGES):

🚀 Move the color name parsing into an exported function which the user can use to convert names to rgb strings. So that only the users which need it will actually import it. It could be tree-shaked for the majority of users.
😕 Remove it from the library completely. Much like we leave it to the user to handle timezones, we can leave it to the user to manage css color names if they want to use them.
👀 Use getComputedStyle but add a message to the documentation that there is a slight performance cost for this.
❤ Leave it as it was. It's working, and the cost is 1.1KB (2.5% of bundle size) is okay.

Emojis are for voting via the GH reactions.

Move the color name parsing into an exported function which the user can use to convert names to rgb strings. So that only the users which need it will actually import it. It could be tree-shaked for the majority of users.

I'd probably suggest slightly different (and extreme) variation of this idea, but that would also give another nice feature out of the box. Instead of providing a function that parses color (a general problem with functions in options API is that the library doesn't work when a function should behave differently thus everything needs to be invalidated - which can be avoided by forcing a user to provide another reference of course) you can provide a new option at the root level of the chart called something like palette, colors or colorsMap or so that is basically a color-mapping object from a name to a rgb(a) representation of a color. This mapping should be used everywhere before actually treating a value as a color i.e. somewhere close to renderers or pane views (to achieve smooth color changing without a hustle). And the library can provide the default "browser-based" object that can be used by users but if not then will be tree-shaked.
With this feature users don't need to worry about changing colors of all previously created objects or even some particular objects if they want/need to maintain their color schemes - they can create objects with some predefined color names and then change them in one go by providing another mapping. For example, you can do something like this:
const palette = {
    '--tv-color-black': '#000000',
};

const chart = createChart(document.body, { palette });
const series = chart.addLineSeries({ color: '--tv-color-line-chart-color' });

and then later, once a user changed the theme of the page, you can simply do:
const newPalette = {
    '--tv-color-black': '#ffffff',
};

chart.applyOptions({ palette: newPalette });

and the chart will adapt all colors automatically (in this case - a color of the previously created line series), so you don't need to traverse all previously created objects to change their colors (and it will solve a problem of the documentation website when you change a theme it refreshed chart's state 😉).
Issues that I see with this approach:

probably requires some color over where colors can be parsed and exposed from API - it might require some work to achieve "smooth" update with a single "light invalidation"
a demand of themed-charts feature is questionable (but considering how it works on tradingview.com probably there are use cases for it)

Reverted the changes which removed the css color names from the source code.


use go-toolset full version

Description
use go-toolset full version
Fixes CCXDEV-10112
Type of change
Please delete options that are not relevant.

Refactor (refactoring code, removing useless files)

Testing steps

n/a

Checklist

[ ] make before_commit passes
[ ] updated documentation wherever necessary
[ ] added or modified tests if necessary
[ ] updated schemas and validators in insights-data-schemas in case of input/output change

Codecov Report
Base: 60.50% // Head: 60.50% // No change to project coverage :thumbsup:

Coverage data is based on head (362fadc) compared to base (f3084c9).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1008   +/-   ##
=======================================
  Coverage   60.50%   60.50%
=======================================
  Files          23       23
  Lines        3226     3226
=======================================
  Hits         1952     1952
  Misses       1053     1053
  Partials      221      221

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


v1 or v2?

Hi,
We are using currently the v1 for our application. I'm wondering if the V2 version should be used and if it is stable enough. What do you think? Is there a plan to release the final version soon?

v2 it pretty different than v1. I use v2, but I really don't use all of the feature it offers.

I tried using v2 yesterday, and it broke my build, as it doesn't want to use the $sailsProvider.url I've set in my config.
I was also hoping v2 would have exposed socket.io's request() function, but that doesn't seem to be the case (at least, not from what I can tell). I need that function exposed, in-order for this to be a truly drop-in replacement for $http (as one of my custom services is built on $http's request() function).

https://docs.angularjs.org/api/ng/service/$http doesn't seem to have a request() function

You're right, I realized that a little bit ago, as I was modifying my service. What I was referring to in $http, is using $http(), so I can pass in the method to use, the data, etc. The closest thing to this is request() in socket.io.

2.0 still accepts a url through the provider: https://github.com/janpantel/angular-sails/blob/c9cd8a32db0bd223964f9d4fa5556b11a6ad3712/src/service/%24sails.js#L47
You also have the ability to create your own socket and pass that to the provider, it will be used instead of creating a new connection.
You can use $sails() just like $http(), it just calls the specific function based on the method specified in the config passed in the call. https://github.com/janpantel/angular-sails/blob/c9cd8a32db0bd223964f9d4fa5556b11a6ad3712/src/service/%24sails.js#L50-L52
The thing you are probably running into is that the socket it a constant connection, to a single server. $http would allow you to sent anywhere, $sails limits it to the socket connection. It seems angular-sails may need to have the ability to set up multiple socket connections (maybe a factory service)? But angular-sails is more or less designed to work with sails, which assumes a single socket endpoint.
Also, in 2.0, you can get to the socket via $sails._socket._socket. $sails._socket is the sails socket.io wrapper, which itself exposes the underlying socket through ._socket.
https://github.com/janpantel/angular-sails/blob/c9cd8a32db0bd223964f9d4fa5556b11a6ad3712/src/service/%24sails.js#L54
https://github.com/janpantel/angular-sails/blob/c9cd8a32db0bd223964f9d4fa5556b11a6ad3712/src/service/%24sailsIo.js#L46 (or https://github.com/janpantel/angular-sails/blob/c9cd8a32db0bd223964f9d4fa5556b11a6ad3712/src/service/%24sailsIo.js#L36 )

I understand v2 is supposed to accept an URL through the provider (I dug into the code to make sure), just as v1 does, however, that's what forced me to go back to v1: v2 ignores it for some reason, and uses the domain/port it was served from. I had v1 working, found out about v2; updated to v2 (only calling functions on button presses, pressed no buttons); v2 was attempting to connect to localhost:3000, even though I told it to use localhost:1337, the exact same way v1 does.
As far as $sails(), that's awesome, didn't know, will keep it in-mind.
And the multiple sockets: I don't think that's necessary. It would just be nice to tell the service to hold off on the connection, until it's kicked off manually down the line. Not a need, just a nice-to-have. Only because supplying the HTML attributes for socket.io is impossible when using something like gulp to handle assets. Which makes supplying my own socket handler useless, as I still can't disable the eager beaver.


STUD-2265 - JWT Claims Fix

Description
Generate a signed claims struct instead of a string as authorization to reaper
Regression Test
Deployed File Utils with updated cobra package: https://app-staging.onecloud.io/onecloud-qa/self-service/workspace/148/168/chains/13631/history/857860/1537668

Security Insights
No security relevant content was detected by automated scans.
Action Items

Review PR for security impact; comment "security review required" if needed or unsure
Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@danerubado-wk @austinarbor-wk - Austin did some work in the reaper to support our current strategy that isn't exactly compliant with the JWT spec.  He already built forward-compatibility into the reaper, so this was really just a QOL improvement for future devs (we'd have to rebuild all bizapps before removing that code in the reaper though).

@danerubado-wk here we were just signing a pure string, not a map of claims, which isn't entirely up to spec. When we upgraded elixir from 1.11 to 1.14, the new jwt library we started using (our old library didn't work with 1.14 anymore and was no longer maintained) would not properly verify these claims since it was just a pure string. i had to backport some auth logic to support this verification mechanism. there are rumblings that the cerebral repo might be getting split out sooner rather than later so i wanted to get this in now before that happens. once all the bizapps are republished i can remove the backported logic


require additional review for certain images

I'm not sure how to require 3+ approvals on these files only.

test failure appears unrelated, see https://github.com/chainguard-images/images/pull/555

I don't know if this did anything

which links to
https://github.com/chainguard-images/images/blob/262144da2ea6671b98fae174d2c29468d0e8ecb4/CODEOWNERS#L5
So I think it still thinks the repo-wide owners are the owners of these files.


feat(product): finalize composite product models

PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines: https://github.com/graycoreio/daffodil/blob/master/CONTRIBUTING.md#commit
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?
[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?
Some of the models for composite products aren't quite right.
Does this PR introduce a breaking change?
[ ] Yes
[x] No

removed price_view field because it isn't needed right now


I cannot build the guardian-cli

Following the instruction in the doc (https://docs.hedera.com/guardian/guardian/readme/built-with/guardian-cli#local-setup) I'm not able to build the guardian-cli. I also tried to install the deps, with npm i but that was not the solution.
I'm using main branch, that is currently tagged 2.12.2
Here the output:
❯ git clone git@github.com:hashgraph/guardian.git
❯ cd guardian/guardian-cli
❯ npm run build

><EMAIL_ADDRESS>build
> tsc

sh: tsc: command not found
❯ npm i

added 3 packages, and audited 4 packages in 1s

found 0 vulnerabilities
❯ npm run build

><EMAIL_ADDRESS>build
> tsc

error TS18003: No inputs were found in config file '/Users/giuseppebertone/workspace/hedera/guardian/guardian-cli/tsconfig.json'. Specified 'include' paths were '["src/**/*","../interfaces/src/type/TopicType.ts"]' and 'exclude' paths were '["node_modules"]'.

Found 1 error.

@Neurone problem solved: fix here


ci: fix cherrypick permission

xref: https://github.com/envoyproxy/gateway/actions/runs/8337869889/job/22817321412
see: https://stackoverflow.com/questions/72851548/permission-denied-to-github-actionsbot
cc @arkodg

/retest

/retest


Auto-Distribute Error - replaces amounts with bogus amounts ($0.01, $0.02).

Name of Defective Feature

Auto-Distribute button to distribute remaining amounts across all line-items in a split transaction

System Settings (Required)

ToolKit Version: v 2.16.0
Operating System (Mac/Windows/Etc): Windows
Browser (Chrome/Firefox/Safari):Chrome
Browser Version: 77.0.3865.120
Other Extensions: Yes - but should not impact this tool

Export of Toolkit Settings (Bottom Left of Settings Page)

Settings Export
[{"key":"AccountsDisplayDensity","value":"0"},{"key":"AccountsEmphasizedOutflows","value":true},{"key":"AccountsStripedRows","value":true},{"key":"AdditionalColumns","value":true},{"key":"AdjustableColumnWidths","value":false},{"key":"AutoDistributeSplits","value":true},{"key":"AutomaticallyMarkAsCleared","value":false},{"key":"BetterScrollbars","value":"0"},{"key":"BudgetCategoryFeatures","value":true},{"key":"BudgetProgressBars","value":"0"},{"key":"BudgetQuickSwitch","value":false},{"key":"BudgetSpendingGoal","value":false},{"key":"BulkManagePayees","value":false},{"key":"CalendarFirstDay","value":"0"},{"key":"CategoryActivityCopy","value":false},{"key":"CategoryActivityPopupWidth","value":"0"},{"key":"ChangeEnterBehavior","value":true},{"key":"ChangeMemoEnterBehavior","value":false},{"key":"CheckCreditBalances","value":true},{"key":"CheckNumbers","value":false},{"key":"ClearSelection","value":true},{"key":"CollapseSideMenu","value":true},{"key":"ColourBlindMode","value":false},{"key":"CompactIncomeVsExpense","value":true},{"key":"CreditCardEmoji","value":true},{"key":"CurrentMonthIndicator","value":true},{"key":"CustomFlagNames","value":true},{"key":"DaysOfBuffering","value":true},{"key":"DaysOfBufferingHistoryLookup","value":"0"},{"key":"DeselectTransactionsOnSave","value":false},{"key":"DisableToolkit","value":false},{"key":"DisplayTargetGoalAmount","value":"0"},{"key":"DisplayTotalMonthlyGoals","value":true},{"key":"DisplayUpcomingAmount","value":false},{"key":"EasyTransactionApproval","value":true},{"key":"EditAccountButton","value":"0"},{"key":"EnableRetroCalculator","value":true},{"key":"EnlargeCategoriesDropdown","value":true},{"key":"EnterToMove","value":true},{"key":"FilterCategories","value":true},{"key":"GoalIndicator","value":true},{"key":"GoalWarningColor","value":true},{"key":"GoogleFontsSelector","value":"0"},{"key":"HideAccountBalancesType","value":"0"},{"key":"HideAgeOfMoney","value":false},{"key":"HideClosedAccounts","value":false},{"key":"HideHelp","value":true},{"key":"HideReferralBanner","value":true},{"key":"HideTotalAvailable","value":false},{"key":"HighlightNegatives","value":false},{"key":"ImportNotification","value":"2"},{"key":"IncomeFromLastMonth","value":"0"},{"key":"IncomeVsExpenseHoverHighlight","value":true},{"key":"LargerClickableIcons","value":true},{"key":"LinkToInflows","value":false},{"key":"MonthlyNotesPopupWidth","value":"0"},{"key":"NavDisplayDensity","value":"0"},{"key":"POSStyleCurrencyEntryMode","value":false},{"key":"Pacing","value":"0"},{"key":"PrintingImprovements","value":false},{"key":"PrivacyMode","value":"0"},{"key":"QuickBudgetWarning","value":true},{"key":"ReconciledTextColor","value":"0"},{"key":"RemovePositiveHighlight","value":true},{"key":"RemoveZeroCategories","value":false},{"key":"ResizeInspector","value":true},{"key":"ResizeSidebar","value":true},{"key":"RightClickToEdit","value":true},{"key":"RowHeight","value":"0"},{"key":"RowsHeight","value":"0"},{"key":"RunningBalance","value":"1"},{"key":"SeamlessBudgetHeader","value":false},{"key":"SetMultipleFlags","value":false},{"key":"ShowCategoryBalance","value":true},{"key":"ShowIntercom","value":false},{"key":"SpareChange","value":false},{"key":"SplitKeyboardShortcut","value":true},{"key":"SplitTransactionAutoAdjust","value":false},{"key":"SquareNegativeMode","value":true},{"key":"StealingFromFuture","value":true},{"key":"SwapClearedFlagged","value":false},{"key":"TargetBalanceWarning","value":true},{"key":"ToBeBudgetedWarning","value":true},{"key":"ToggleMasterCategories","value":true},{"key":"ToggleSplits","value":true},{"key":"ToggleTransactionFilters","value":"1"},{"key":"ToolkitReports","value":true},{"key":"TransactionGridFeatures","value":true},{"key":"ViewZeroAsEmpty","value":false},{"key":"goalIndicator","value":true},{"key":"highlightNegativesNegative","value":true},{"key":"l10n","value":"0"},{"key":"options.dark-mode","value":true},{"key":"pacing","value":"0"},{"key":"popupCalculator","value":true},{"key":"reports","value":true}]

Steps to Reproduce the Behavior

Split Transaction
Enter details not adding up to full amount (i.e. leaving tax not accounted for)
Click on Auto-distribute button.

Expected Behavior
The remaining amount is split across all lineitems (based on the totals/percentages) and added to the total line.
Actual Behavior
Amounts in each line item are replaced with "bogus"/Default values (i.e. $0.01, $0.02, etc), and only a fraction of total is in budget.
Before:

After

NOTE: while trying to reproduce this, I got results/prompts similar to #1691. I did not originally get that prompt, but the results after clicking OK on the prompt were similar.

#1640 was also created, but no updates.

Closing this in favor of #1640


Fixed dotnet5.4 to dotnet5.1

Fixed typo

Hi @alexchub, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, DNFBOT;

We should cleanup the text to simply clarify that the only framework you should list is dnx452 or later and avoid trying to enumerate all of the .NET Core related TFMs.

I think it's pretty clear in the (article)[https://github.com/aspnet/Docs/blame/master/aspnet/data/entity-framework-6.rst#L16] that you should only target the Full Framework. So I'm going to go ahead and merge this.

Merged in 9d920bc9a5db1cdcc2edbc71668836717be1cbe3


S8 [User Story] API Endpoint Get a User's Roles (groups)

[User Story]
Hierarchical approval

Epic Title
Hierarchical approval #118

User Story Title
Api Endpoint Get a User's Roles

T-shirt size: S(mall), M(edium), L(arge)
S

Story Points - Fibonacci (1,2,3,5,8,13)
3

User Story
[Value Statement] "As a user of NEXT, I want to be able to get the roles associated with a user"

Description
Implement capability to browse a user's Roles

Business Need (the why):
Having access to a user's Roles will help with implementing hierarchical approval for a user.

Details
Create API endpoints for getting a user's Roles. Add a simple UI page to display the hierarchy.

Additional User Story
linked

Acceptance Criteria/Tests
The list of tests or criteria to be used to validate the story has been completed. May still need UAT or SIT / integration testing with other stories.

Failure
if any, fold in negative tests

Definition of Done
e.g.Passes all regression tests, Passes testing per acceptance criteria, Approved by UI team, Able to show feature in demo

Architectural/System or Component Impacts
This will be in Sanic and may utilize already existing apis

It looks like some of the descriptions here were copied over from a story about looking up direct reports. I am assuming this is an endpoint for getRoles(userId).

Taking myself off this task as there is currently misunderstanding of the end value of this feature.

I have confirmed that both Azure and AD are providing what groups a user belongs to on the memberOf field.  Closing this ticket as complete


improve pre-commit run on GHA

The comment
https://github.com/nebari-dev/nebari/blob/ac981ea6fe535cdc4592bffd60a49fe9ab137028/.github/workflows/run-precommit.yaml#L22-L23C14
is not the full picture. The action also installs pre-commit and runs it against all files by default. Meaning, we are currently installing pre-commit for nothing
https://github.com/nebari-dev/nebari/blob/ac981ea6fe535cdc4592bffd60a49fe9ab137028/.github/workflows/run-precommit.yaml#L25-L26
and running the terraform_fmt hook twice:
https://github.com/nebari-dev/nebari/blob/ac981ea6fe535cdc4592bffd60a49fe9ab137028/.github/workflows/run-precommit.yaml#L28-L29
This PR improves this by only running the terraform_fmt hook through the action.

1c2ba6ba7c032b32556263b0f6e0384ae30390c9 demonstrates that we still catch formatting issues.


0.44.0 broke srlinux tcp stack

see https://github.com/srl-labs/learn-srlinux/pull/87#discussion_r1298976274
can reproduce with this fixed up srlfrr example (copy paste into /etc/containerlab/lab-examples/srlfrr01/srlfrr01.clab.yml):
name: srlfrr01

topology:
  nodes:
    srl:
      kind: srl
      image: ghcr.io/nokia/srlinux:23.3.3
      startup-config: |
        # configure loopback and data interfaces
        set / interface ethernet-1/1 admin-state enable
        set / interface ethernet-1/1 subinterface 0 admin-state enable
        set / interface ethernet-1/1 subinterface 0 ipv4 admin-state enable address <IP_ADDRESS>/24

        set / interface lo0 subinterface 0 admin-state enable
        set / interface lo0 subinterface 0 ipv4 address <IP_ADDRESS>/32
        set / network-instance default interface ethernet-1/1.0
        set / network-instance default interface lo0.0

        # configure BGP
        set / network-instance default protocols bgp admin-state enable
        set / network-instance default protocols bgp router-id <IP_ADDRESS>
        set / network-instance default protocols bgp autonomous-system 65001
        set / network-instance default protocols bgp afi-safi ipv4-unicast admin-state enable
        set / network-instance default protocols bgp group ibgp export-policy export-lo
        set / network-instance default protocols bgp neighbor <IP_ADDRESS> admin-state enable
        set / network-instance default protocols bgp neighbor <IP_ADDRESS> peer-group ibgp
        set / network-instance default protocols bgp neighbor <IP_ADDRESS> peer-as 65001

        # create export policy
        set / routing-policy policy export-lo statement 10 match protocol local
        set / routing-policy policy export-lo statement 10 action policy-result accept
    frr:
      kind: linux
      image: frrouting/frr:v7.5.0
      binds:
        - daemons:/etc/frr/daemons
      exec:
        - |
          vtysh -c 'configure terminal
          interface eth1
          ip address <IP_ADDRESS>/24
          !
          interface lo
            ip address <IP_ADDRESS>/32
          !
          router bgp 65001
            bgp router-id <IP_ADDRESS>
            neighbor <IP_ADDRESS> remote-as 65001
            !
            address-family ipv4 unicast
             network <IP_ADDRESS>/32
            exit-address-family'

  links:
    - endpoints: ["srl:e1-1", "frr:eth1"]

Peering stays in connect state. With bgp/xdp logs indicating socket error.
The errors are not present when using clab 0.43.0
additional issue:
CLAB_INTFS env var is not showing 1, but 0. This needs to be fixed as well.

I did a diff between 0.43 and 0.44 with regards to e1-1 and e1-1-0 interfaces.
Nothing extraordinary that jumps out to me...
Left pane is 0.43
https://www.diffchecker.com/UmCegYiJ/

In https://github.com/srl-labs/containerlab/pull/1536 I reverted the #1475 and redeployed the lab which fixed the original issue, now the hunt is on to check what broke what?


(SERVER-2740) Implement the 'prune' action for Puppetserver's CA CLI

something looks a little funky to me.. why are there two "Implement action 'prune'" commits, but no merge commit?

In general, you shouldn't edit the pre-generated merge commit title. We prefer to leave it as git writes it, so we can clearly see what's a merge.

something looks a little funky to me.. why are there two "Implement action 'prune'" commits, but no merge commit?

I might have goofed. Fixed the merge conflict with the version and did git commit -m "(SERVER-2740)...". Of course this is after doing git merge --log --no-ff 1.x

ahh, you should be able to just to git commit after resolving conflicts and that will populate the message with the default merge commit message.

Sorry, habit of tagging thing lately. I'll amend that.


Buffer inconsistency

There is a buffer inconsistency bug caused by not sending feedback on partial PU collision. It is going to be fixed soon. As effect of the bug, in some rare cases (approximately only in 0.2% of 10000 slots of simulations), the simulation exits due to removing from empty packet queue.

Fixed with 5912f5486c861641a29aef95cd4a96cffefb8c32


Change checkout action version

Since action/checkout@v2 uses Node 12.x.x and it is deprecated I think we must use action/checkout@v3
https://github.com/robusta-dev/robusta/blob/f237628424813884f576205d1d9440ffd7bddb95/.github/workflows/release.yaml#L17-L19

can I take up this issue?

Yes @VamshiReddy02 , you can. make sure to change it in every workflow file of the project

Hey all, at the moment action/checkout@v2 still works fine!
Is there a specific deadline by which we need to update?
I would be happy to suggest some other issues too where we're actively looking for contributors.

Yes Node 12 is there until summer of 2023


Default Sky shader doesn't render correctly

Tested versions

Reproducible in current master (2c136e6)
Not reproducible in 4.4-Dev2

System information
Godot v4.4.dev (606eedb0c) - Pop!_OS 22.04 LTS - X11 - Vulkan (Forward+) - integrated Intel(R) Xe Graphics (TGL GT2) - 11th Gen Intel(R) Core(TM) i7-1165G7 @ 2.80GHz (8 Threads)
Issue description
The default sky looks totally broken in master. A quick check through the history and basic testing shows that https://github.com/godotengine/godot/pull/96858 is the culprit CC @Chaosus
Master

After reverting https://github.com/godotengine/godot/pull/96858

Steps to reproduce

Open a new 3D scene
OR add a new ProceduralSkyMaterial to a Sky
OR add a new PhysicalSkyMaterial to a Sky

Minimal reproduction project (MRP)
N/A

Yep, sorry about that, I did not test it with a default sky.


Layer cs visibility

This PR is the replacement for #96. In its current state it has the following behavior when having multiple coordinate spaces:
Layer.metadata has a field to keep track of the visibility state in a coordinate system.
When starting napari

When a layer is present in the selected coordinate system and is made visible active_in_cs metadata is a set containing only the name of the coordinate system.
If made invisible afterwards, the selected coordinate system is removed from the set.
If present and visible, but then changing to a different coordinate system in which the spatialdata element is not present, layer.visible is set to False, but active_in_cs still contains the name of the coordinate system in which it was made visibe. If present but not visible and then changing, nothing changes.
When going back to the original coordinate system, the active_in_cs metadata of the layers visualizing the elements in that coordinate system are checked to whether a layer should become visible again or not.

Even when an element is not present in the selected coordinate system, it can still be made visible again by clicking on the eye. This would allow for now for the landmark registration approach. However, the name of the coordinate system is not added to active_in_cs in this case.
Note that changing the visibility does cause the scene to have to be redrawn upon visualizing again, which can take time (image is loaded again).

Codecov Report
Patch coverage: 68.75% and project coverage change: -0.05 :warning:

Comparison is base (306e9a2) 71.63% compared to head (17c372d) 71.58%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #99      +/-   ##
==========================================
- Coverage   71.63%   71.58%   -0.05%
==========================================
  Files          13       13
  Lines        1477     1492      +15
==========================================
+ Hits         1058     1068      +10
- Misses        419      424       +5

Impacted Files
Coverage Δ

src/napari_spatialdata/_interactive.py
65.57% <37.50%> (-1.98%)
:arrow_down:

src/napari_spatialdata/_constants/_constants.py
100.00% <100.00%> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

The failing test is caused by a dependence on #282 which is not used for tests here yet.

@LucaMarconato @giovp If you have time please have a look and let me know if you agree with the applied functionality.

Hey @melonora , it looks like like the tests are failing because they are expecting to use the version of blobs() on spatialdata main (introduced in https://github.com/scverse/spatialdata/pull/282), which hasn't been released to pypi yet. I just cut a release. Once you see spatialdata 0.0.10, please try re-running the tests. Sorry about that!

Hi @kevinyamauchi ,
No worries, I knew the reason:) I hope to push the expected PR regarding saving back points / shapes and labels to spatialdata quickly after this one. That PR will be branched from the branch I used here so would be nice to have it in beforehand.

Thanks for the fix, @melonora . Do you know the source of the docs failure?

It does not seem to recognize napari_spatialdata as a module. This also causes the docs builds in the other PRs to fail.

I am able to locally build the docs. @giovp @rahulbshrestha any ideas? Are you able to locally build?

Hey @melonora . Thanks for the PR! I think it's on the right track. The tests were helpful for understanding the intention of the PR.
I have made an initial review with some comments below. The functionality seems to work. The does logic feels a bit convoluted to me. It may be that it's as simple as it can get, but I just want to check in. To understand a bit better, I have a few questions:
* To me it looks like the `active_in_cs` metadata that is tracking which coordinate system a layer can be active in is populated each time a new coordinate system is selected. This feels a bit odd because it's value is changing as the user clicks different coordinate systems even though the underlying ground truth is not. Is it possible for this to be populated upon layer instantiation and then just checked each time a coordinate system is changed? I think this would simplify the logic in places

* If the `active_in_cs` is modified by the user, does the view get updated? Should we use an [EventedSet](https://napari.org/stable/api/napari.utils.events.EventedSet.html) for the `active_in_cs` metadata? That way if that is updated, the view can be updated? We could also save this for a follow up PR

* If a transformation is added, do we need to update the `active_in_cs`metadata?

@kevinyamauchi Thanks for reviewing! I will try to clarify some things:

Active_in_cs tracks in which coordinate systems the layer is visible / editable. This means that if we have a spatial element having 2 coordinate systems associated with it global and other and being open as a layer, if visible and switching from global to other this means active_in_cs will change from ("global") to ("global", "other").
If now toggling visibility of the layer in other so it is not visible, the value is  ("global") again.
If now switching to a coordinate space space with is not a value in <spatial_element>.coordinate_systems the layer automatically becomes invisible but keeps a check of in which coordinate systems it was visible. When switching back to a coordinate system in which it is was visible, the layer automatically becomes visible again.
To allow for the landmark registration for now a layer is allowed by the user to become visible even when not having the selected coordinate system associated with it. However, this does not affect active_in_cs.

In short, this PR is for tracking in which coordinate systems the layer is visible / editable and disallows visibility upon switching when the selected coordinate system is not associated with the spatial element. Until multicanvas is there the visibility can still be toggled by the user explicitly.
This functionality requires a callback upon switching coordinate systems and upon toggling the visibility of a given layer.

when the user goes to a coordinate system, all the elements that are in that coordinate system are shown and all the elements that are not in that coordinate system are hidden.

thus, if as a user I hide a layer in a coordinate system, and I go back and forth to the same coordinate system, that layer will reappear.

I would vote against this given the number of elements that can be present in a coordinate system. With any form of multiplexed imaging this can be a lot and would be costly to have all visible.

If the idea is also to make active_in_cs private, I would second that as for now that would avoid some complexity.


Add basic build/setup instructions

Migrated from https://github.com/zcash/zcash-android-wallet-sdk/issues/21

Closed by b7ae8ff80fb416c67a41ed462c526ec5366d7487.


python312Packages.pylacus: 1.9.0 -> 1.10.0

Diff: https://github.com/ail-project/PyLacus/compare/refs/tags/v1.9.0...v1.10.0
Changelog: https://github.com/ail-project/PyLacus/releases/tag/v1.10.0
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 324646 at 95d8d0fd run on x86_64-linux 1

2 packages built successfully:

python311Packages.pylacus
python312Packages.pylacus

Result of nixpkgs-review pr 324646 run on x86_64-linux 1

4 packages built:

python311Packages.pylacus
python311Packages.pylacus.dist
python312Packages.pylacus
python312Packages.pylacus.dist


NIMBLE single button to allow or reject a bond / pairi (IDFGH-9222)

Is your feature request related to a problem?
I am porting a product over from NRF52 to ESP32-S3. I was using Nordic SDK 17 and am now using ESP-IDF (platformio).
I have a single button on the BLE peripheral the while pressed and released gives 30 seconds for a phone (central) to pair.
Unless that button has been pressed (and 30 seconds afterward), the pairing should be rejected.
On the NFR52 that was done by simply setting the pm_sec_params_set(NULL) to not allow bonding, etc.
To allow pairing for 30 seconds, i changed the security parameters to allow bonding, etc
pm_sec_params_set(&sec_param);
(my &sec_param is:
   memset(&sec_param, 0, sizeof(ble_gap_sec_params_t));     sec_param.bond           = SEC_PARAM_BOND;     sec_param.mitm           = SEC_PARAM_MITM;     sec_param.io_caps        = SEC_PARAM_IO_CAPABILITIES;     sec_param.oob            = SEC_PARAM_OOB;     sec_param.min_key_size   = SEC_PARAM_MIN_KEY_SIZE;     sec_param.max_key_size   = SEC_PARAM_MAX_KEY_SIZE;     sec_param.kdist_own.enc  = 1;     sec_param.kdist_own.id   = 1;     sec_param.kdist_peer.enc = 1;     sec_param.kdist_peer.id  = 1;
Describe the solution you'd like.
Using NIMBE BLE, add a way to turn pairing / bonding on for a certain duration of time and then also turn off the ability to pair / bond.
Describe alternatives you've considered.
No response
Additional context.
We use this as a security feature.

Hi @bheestandLMT ,
As i understand, there is no such API in nimble to directly block pairing/ bonding. But one suggestion is that  BLE_GAP_EVENT_PASSKEY_ACTION event would be generated from stack to application to get user's input during pairing. May be you can start a timer of your preferred duration and only if GAP layer receives the event, then application can approve the request, or else reject it .

Closing this due to no activity. Please feel free to reopen in case of any other issue


Page doesn't exist - GI Platform APIs

https://docs.insuremo.com/gi_product_design/gimo_api_concept
This page doesn’t exist.
If this is a mistake, let us know, and we will try to fix it!

Hello @syedalinawas!
Can you share more info on what link you refer to? The one you linked doesn't (and is not supposed to) lead to any of React documentation.


Recipe app

Login page and registration page.

Display recipes list.

Display public recipe list.

Show Recipe details.

Display food list.

Make sure there are no N+1 queries happening.

Create a navigation menu that allows users to open all of the pages you created.

Write unit and integration tests

Hi @waelelsafty07,
This is a manual review
Request Changes ♻
I will advise you to test your project probably before asking for a review, you can tell one of your Microverse mates to test for you.
After setting up your app and ran rails s I got the following error:

You didn't set up devise properly and clearly, you didn't have any code in application_controller.rb - here
Also, Kindly update your README file.
Thank you.
Cheers and Happy coding!:clap::clap::clap:

Hi @waelelsafty07,
This is a manual review
Good job for adding devise 👍 , I can now successfully sign up and sign in, however, we need to work on the wireframe given in the project requirement.
Request Changes ♻
I will re-advise you again, please test your project properly before asking for a review, you can tell one of your Microverse mates to test for you. keep in mind you have one more review left

You need to fix the design issue.
Your design:

Wireframe given: Follow the wireframe for the 5 pages shown below

You need to fix the recipe implementation. I can't create a recipe, I got the following error message, I think you need to pass the correct methods to set_recipe the before_action call.

Make sure you are able to create and display the list of recipe.

Take your time to go through the remaining requirements in the [project requirement](Project requirements
). Since I can't create a recipe, I was unable to test the rest of the features.

Thank you.
Cheers and Happy coding!:clap::clap::clap:

@bellom can you review again please

Hi @waelelsafty07
This is a manual review
Approved :+1:
Great job working on the previously requested changes. Kudus to you 👍
All these passed: 🚀

Cheers and Happy coding!:clap::clap::clap:


New version: YaoSym v0.4.9

Registering package: YaoSym
Repository: https://github.com/QuantumBFS/Yao.jl
Created by: @Roger-luo
Version: v0.4.9
Commit: 7acb2f6ed9e3cc66ccc11b19ac19615675f16102
Reviewed by: @Roger-luo
Reference: https://github.com/QuantumBFS/Yao.jl/commit/7acb2f6ed9e3cc66ccc11b19ac19615675f16102#commitcomment-62299715
Description: Extensible, Efficient Quantum Algorithm Design for Humans.

@Roger-luo did you skip version on purpose?  What do you want to do?
[noblock]

ah no please just close this I didn't realize 0.4.8 was not registered


[12.2] Shift Click Deletes

I understand this may not solely be an EnderIO issue however I wanted to make you aware of it.
Issue Description:
So far it has only happened with Slice'n'Splice. It may be a conflict with InvTweaks and TooManyItems. However when I am trying to autoplace items into the slice'n'splice for recipes using TooManyItems clicking the + sign. However if I shift click it removes the items and does not place them into the machine effectively deleting them.
What happens:
Shift clicking items in Slice'n'Splice deletes them.
What you expected to happen:
Items to be place into the machine
Steps to reproduce:

Open Slice'n'Splice
Open recipe in TooManyItems
Hold Shift and press + sign to place into machine
Profit
...

Affected Versions (Do not use "latest"):

EnderIO: 1.12.2-5.0.22
EnderCore: 1.12.2-0.5.20
Minecraft: 1.12.2
Forge: <IP_ADDRESS>18

Your most recent log file where the issue was present:
2018-04-22-1.log.gz

Just encountered this issue using the FTB Revelations pack.

This still happens. EIO 5.0.37
Forge 2772


use system-cluster-critical priority

specifies system-cluster-critical priority for operator and operand
blocks passing smoke tests for ensuring control plane pods always schedule.
see: openshift/origin#22217

@derekwaynecarr apiserver seemed to have gone down during e2e-aws - known flake?

/retest

xref https://bugzilla.redhat.com/show_bug.cgi?id=1683100

/lgtm


New Example:

I would like have an example that demonstrates:

dynamically add remove items in a form, kind of todo model.

hierarchical forms for one to many models.

 {
    "products":[
        "item1":["price1","price2","price3"],
        "item2":["price1","price2","price3"],
        "item3":["price1","price2","price3"],
        ]
 }

how's this? http://angular-formly.com/#/example/advanced/repeating-section
-Kent C. Dodds
On Mon, Apr 20, 2015 at 9:57 AM, rama<EMAIL_ADDRESS>wrote:

I would like an example that demostrates: dynamically add remove items,
kind of todo model.
—
Reply to this email directly or view it on GitHub
https://github.com/formly-js/angular-formly/issues/256.

there is an issue with this example,
http://angular-formly.com/#/example/advanced/repeating-section
if I enter 1st set of investment details, it's value repeated in 2nd set as well.
basically, it's using same "key" name.
It's not possible to enter multiple investment plan.

Thanks. The example has been updated. Let me know if it is not sufficient.

why 'investments' key must be defined in vm.model to show the form ?

@abodacs That key is specific to that example. But it's because the key for the field, that's why it needs to be on the model.

@kentcdodds try to change it to vm.model = {};??

This is a bit of a poor example. But part of the repeatSection type depends on their being a value initially because it copies the previous section to make the next one. It fails when there's not an existing previous value. You could easily alter the type so this doesn't happen.

I updated the example. Go ahead and play around with it. Should work now.


[BUG] Memory leak can occur during interactive UI test

Describe the bug
Memory leak occurred during interactive UI test for game_board
To Reproduce
Unsure about how to reproduce; will report again later
Expected behavior
No memory leaks
Screenshots

Leak occurred after selecting the '2' at row 1, column 5
Screenshotted from the VSCode terminal.

Leaving a note here that this bug may have similar problem roots to this issue

Update: error occurs due to stack overflow -- will need to fix the recursive function in select()

I think this bug is fixed with https://github.com/ayoshi007/cpp-minesweeper/commit/0d886313998cfa9b0b3fd58fb9b0d917db3cbd78, will test locally later

The bug seems to be fixed, closing


Provide with_header method on client

This change allows arbitrary headers to be included in requests to ClickHouse.
It uses HeaderName and HeaderValue which is efficient for use with hyper. The types are provided by the http crate to allow support for other HTTP client crates to use these types without requiring the full hyper crate.
There are other ways to provide this capability, including unsealing the HttpClient trait to allow more implementations. However, this change provides a limited additional capability until a public interface for HttpClient is decided.
Fixes #98

In the hyper documentation, they use plain strings as headers names/values: https://docs.rs/hyper/latest/hyper/struct.Request.html#examples

It uses HeaderName and HeaderValue which is efficient for use with hyper.

If there are optimizations made by HeaderName, and the custom headers will likely use some non-standard names (X-My-Proxy-Auth and similar), does it make sense to add http as a dependency, or maybe we can get away with just &str?
From https://docs.rs/http/latest/http/header/struct.HeaderName.html#representation:

HeaderName represents standard header names using an enum, as such they will not require an allocation for storage. All custom header names are lower cased upon conversion to a HeaderName value.

As I understand it, the custom header names are not represented as enums.

LGTM, let's also pass to INSERTs

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

I rebased the code on the latest version and rewrote it to use plain Strings without requiring the http crate. The client headers now follow a similar structure to client options.

Merged, thanks for your contribution!


AWS no longer meets performance requirements in CompactionPerformanceIT

Description
We've had a number of test failures in CompactionPerformanceIT where the performance was lower than expected.
We tried re-running the test with an old version of the jars that was built while the performance tests were still passing. The tests still failed, with the same performance we're seeing with the latest code. That seems to indicate something changed in AWS that has degraded compaction performance.
The test first failed in this way on 27th March. It's failed every time in the same way since then. We were seeing performance reliably well over 300,000 records compacted per second. Now it's closer to 250,000.
Steps to reproduce

Run system test CompactionPerformanceIT
See minimum compaction rate is not met

Expected behaviour
The test should assert the performance that we can reliably achieve on AWS as it is now.
It would be nice if the test could fail if the performance returns to the level it was at before, so that we can tell and update the test.

Accidentally merged PR into base of stack, but it's in develop now. Closing.


Handle multiple environments and postfix stacks

Demonstrate how to handle deploying to multiple environments, and the use of Postfixes so that the same stack can be deployed to the same AWS account with different resource names. Cover:

Resource names
PowerTools log/metric namespacees
Trace annotations

There might be more things to cover.

Done


One-Step Publish for Meltano and SDK

Migrated from GitLab: https://gitlab.com/meltano/meltano/-/issues/3044
Originally created by @aaronsteers on 2021-11-05 15:57:36

We have a one-click prerelease publish in the SDK. That's a simpler problem because we don't have release notes and the version number is just an auto-generated dev bump using the CI build number.
Opening this issue to figure out how we get to similar simplicity for normal deployments.
Goals

Continue frequent releases.
Reduce cost to dev productivity.
Make dual-channel releases (edge/main) more viable, as proposed in https://gitlab.com/meltano/meta/-/issues/135

Statu Quo
Here are the current manual deployments steps (excluding marketing/slack/tweets, etc.):

Open a release branch. (Triggers an auto-commit with the version bump.)
Open a tag from the release branch. (Triggers the PyPi publish.)
Groom the changelog. (Can be performed before, after, or in parallel with the above - since the changelog itself is not shipped.)

Ideal State
Changelog automation
I don't know as much about this space but I believe there are some available options.
One-Step version bump, validation, and publish
Rather than requiring the tag to be created explicitly in a separate step, we can modify the CI pipeline to also run the publish step in the special CI job that runs when a new branch is created like release/*.
The special CI pipeline for release/* tags can be removed in favor of the branch pipeline, to eliminate the need for a second step, and avoid "chaining" of auto-commits and CI jobs. We could still create the tag as part of the CI pipeline, rather than as a manual step.
Proposed flow
Releases:

As release manager, I create a correctly-named release branch which triggers the release pipeline.
I click "Merge when pipeline succeeds" immediately - meaning, a successful CI run (including publish steps) will close out the version bump.

Change Log Grooming:

If needed, I create and merge a separate changelog grooming MR.

View 9 previous comments from the original issue on GitLab

@WillDaSilva @kgpayne is this still relevant?

Superseded by:

https://github.com/meltano/internal-tech-ops/issues/11


Can't build in debug under vs2017

I build the tutorial projects using Visual Studio 2017, but when I run them, it is missing the following DLLs:
VCRUNTIME140D.dll
ucrtbased.dll
MSVCP140D.dll
These are from the 2015 VC++ redist installer, which I can't install because I'm running 2017. Is there a way to build these samples under the 2017 redist?

Yeah, we should be able to fix that.  I want to deprecate VS2015 entirely, and I'll clean up any stale dependencies.  Thanks for letting us know.  Sometimes we miss these problems because we keep several versions of VS installed.

I'm not sure these things are installed with the 2015 VC++ redist package.  On my system, they are loaded from C:\Windows\System32.  And they get loaded even when targeting the v141 platform toolset.  There are no v141 equivalents of the files you listed.  (v140 and v141 are binary compatible.)  I'll ask around, but you might try checking your path in the mean time.

VS 2015 Update 3 - VS 2022 all share the same REDIST. This is part of the binary compatibility support. This means that the VS 2017 CRT Is actually a newer version of the VS 2015 Update 3 CRT.
IOW: The VCRUNTIME140D.dll, MSVCP140D.dll, and ucrtbased.lib are part of Debug runtime for VS 2015 Update 3 all the way through VS 2022. The fact that they are missing indicates that you don't have the VS 2017 Debug C/C++ Runtime either.


it is a memory leaks issue in Mat_VarCalloc (mat.c:807)

A crafted input will lead to crash in mat.c at matio 1.5.17.
Triggered by
./matdump POC
Poc
006-memleak
The ASAN information is as follows:
./matdump /usr/local/matio_asan/bin/006-memleak
InflateRankDims: inflate returned data error
InflateVarTag: inflate returned data error
Empty
InflateRankDims: Reading dimensions expected type MAT_T_INT32
InflateRankDims: Reading dimensions expected type MAT_T_INT32
      Name:
      Rank: 0
InflateRankDims: inflate returned data error
131074 is not a valid rank
      Rank: 0
421105169 is not valid (MAT_T_MATRIX or MAT_T_COMPRESSED)

=================================================================
==23803==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 80 byte(s) in 1 object(s) allocated from:
    #0 0x7fbf2001f602 in malloc (/usr/lib/x86_64-linux-gnu/libasan.so.2+0x98602)
    #1 0x7fbf1fd691df in Mat_VarCalloc /home/matio/matio_src/matio/src/mat.c:807
    #2 0x7fbf1fc9d7bb in ReadNextCell /home/matio/matio_src/matio/src/mat5.c:925
    #3 0x7fbf1fd5d494 in Mat_VarReadNextInfo5 /home/matio/matio_src/matio/src/mat5.c:4998
    #4 0x7fbf1fd73a87 in Mat_VarReadNextInfo /home/matio/matio_src/matio/src/mat.c:2342
    #5 0x408136 in main /home/matio/matio_src/matio/tools/matdump.c:944
    #6 0x7fbf1f54e82f in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x2082f)

Indirect leak of 32768 byte(s) in 1 object(s) allocated from:
    #0 0x7fbf2001f602 in malloc (/usr/lib/x86_64-linux-gnu/libasan.so.2+0x98602)
    #1 0x7fbf1ece87d1 in inflateCopy (/usr/local/lib/libz.so.1+0xd7d1)

Indirect leak of 7160 byte(s) in 1 object(s) allocated from:
    #0 0x7fbf2001f602 in malloc (/usr/lib/x86_64-linux-gnu/libasan.so.2+0x98602)
    #1 0x7fbf1ece87a1 in inflateCopy (/usr/local/lib/libz.so.1+0xd7a1)

Indirect leak of 112 byte(s) in 1 object(s) allocated from:
    #0 0x7fbf2001f79a in __interceptor_calloc (/usr/lib/x86_64-linux-gnu/libasan.so.2+0x9879a)
    #1 0x7fbf1fc9efd1 in ReadNextCell /home/matio/matio_src/matio/src/mat5.c:1065
    #2 0x7fbf1fd5d494 in Mat_VarReadNextInfo5 /home/matio/matio_src/matio/src/mat5.c:4998
    #3 0x7fbf1fd73a87 in Mat_VarReadNextInfo /home/matio/matio_src/matio/src/mat.c:2342
    #4 0x408136 in main /home/matio/matio_src/matio/tools/matdump.c:944
    #5 0x7fbf1f54e82f in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x2082f)

Indirect leak of 40 byte(s) in 1 object(s) allocated from:
    #0 0x7fbf2001f602 in malloc (/usr/lib/x86_64-linux-gnu/libasan.so.2+0x98602)
    #1 0x7fbf1fd69505 in Mat_VarCalloc /home/matio/matio_src/matio/src/mat.c:823
    #2 0x7fbf1fc9d7bb in ReadNextCell /home/matio/matio_src/matio/src/mat5.c:925
    #3 0x7fbf1fd5d494 in Mat_VarReadNextInfo5 /home/matio/matio_src/matio/src/mat5.c:4998
    #4 0x7fbf1fd73a87 in Mat_VarReadNextInfo /home/matio/matio_src/matio/src/mat.c:2342
    #5 0x408136 in main /home/matio/matio_src/matio/tools/matdump.c:944
    #6 0x7fbf1f54e82f in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x2082f)

Indirect leak of 9 byte(s) in 1 object(s) allocated from:
    #0 0x7fbf2001f602 in malloc (/usr/lib/x86_64-linux-gnu/libasan.so.2+0x98602)
    #1 0x7fbf1fc9eb59 in ReadNextCell /home/matio/matio_src/matio/src/mat5.c:1046
    #2 0x7fbf1fd5d494 in Mat_VarReadNextInfo5 /home/matio/matio_src/matio/src/mat5.c:4998
    #3 0x7fbf1fd73a87 in Mat_VarReadNextInfo /home/matio/matio_src/matio/src/mat.c:2342
    #4 0x408136 in main /home/matio/matio_src/matio/tools/matdump.c:944
    #5 0x7fbf1f54e82f in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x2082f)

SUMMARY: AddressSanitizer: 40169 byte(s) leaked in 6 allocation(s).

Can you confirm that a47b7cd3aca70e9a0bddf8146eb4ab0cbd19c2c3 fixes the issue? Thanks.

Closing after no more feedback from issue  author.

CVE-2019-20052 was assigned for this issue though.

Why? This issue never was apparent in a released version.

@tbeu I do not know actually (Note, I'm only the messenger here. I'm part of the Debian security team, and while reviewing new CVE assignments, I cross-checking the upstream issue associated and where needed mention the respective CVE id which got assigned).
In this case I do not know if the CVE is valid or not, but if you think it is not, might you ask as upstream via the https://cveform.mitre.org to reject the CVE? There is no information who requested the CVE, so I unfortunately cannot redirect you to the right person here.

According to our (Mageia) testing, the patch did NOT fix the issue:
https://bugs.mageia.org/show_bug.cgi?id=27969#c4
This bug should either be be re-opened, or a new one raised:
https://bugs.mageia.org/show_bug.cgi?id=29164

Is there a corrected patch that isn't reflected in 1.5.18+?

Hm, I am lost here. I asked for confirmation if a47b7cd3aca70e9a0bddf8146eb4ab0cbd19c2c3 fixes the issue 19 months ago. How does it come that you report now that the issue is not fixed? Why does it take such a long response?
For now, I would prefer if you can file a new pull request (targeting master) to fix whatever needs to be fixed.

"I asked for confirmation if a47b7cd fixes the issue 19 months ago. How does it come that you report
now that the issue is not fixed? Why does it take such a long response?"
Our (Mageia) security updates/testing is driven by issued CVE Advisories. I see that this one goes back to at least Dec 2019; it was notified to Mageia Dec 2020, 'fixed' and tested at the turn of the year; then fell into limbo: https://bugs.mageia.org/show_bug.cgi?id=27969#c5
"I would prefer if you can file a new pull request (targeting master) to fix whatever needs to be fixed."
I have raised a new 'bug' as you wish (https://github.com/tbeu/matio/issues/175), but your terminology means nothing to me. It can do little more than reiterate the end of this one.


plot_interactivity

App wont run:
> shiny::runApp()
Loading required package: shiny
Loading required package: testthat
── Attaching core tidyverse packages ───────────────────────────────────────────────────────────────────────────────────────────────────── tidyverse 2.0.0 ──
✔ dplyr     1.1.0     ✔ readr     2.1.4
✔ forcats   1.0.0     ✔ stringr   1.5.0
✔ ggplot2   3.4.1     ✔ tibble    3.2.0
✔ lubridate 1.9.2     ✔ tidyr     1.3.0
✔ purrr     1.0.1
── Conflicts ─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────── tidyverse_conflicts() ──
✖ readr::edition_get()   masks testthat::edition_get()
✖ dplyr::filter()        masks stats::filter()
✖ purrr::is_null()       masks testthat::is_null()
✖ dplyr::lag()           masks stats::lag()
✖ readr::local_edition() masks testthat::local_edition()
✖ dplyr::matches()       masks tidyr::matches(), testthat::matches()
ℹ Use the conflicted package to force all conflicts to become errors
Registered S3 method overwritten by 'geojsonsf':
  method        from
  print.geojson geojson

Attaching package: ‘geojsonio’

The following object is masked from ‘package:shiny’:

    validate

The following object is masked from ‘package:base’:

    pretty

Warning: There was 1 warning in `mutate()`.
ℹ In argument: `country_full_name = case_when(...)`.
Caused by warning in `countrycode_convert()`:
! Some values were not matched unambiguously: CN, NULL, TMP
Warning: `data_frame()` was deprecated in tibble 1.1.0.
ℹ Please use `tibble()` instead.
This warning is displayed once every 8 hours.
Call `lifecycle::last_lifecycle_warnings()` to see where this warning was generated.

Attaching package: ‘bslib’

The following object is masked from ‘package:utils’:

    page

Attaching package: ‘DT’

The following objects are masked from ‘package:shiny’:

    dataTableOutput, renderDataTable

Error in plotlyOutput("graph_avg_price", width = "100%", height = "200px") :
  could not find function "plotlyOutput"
>


use post request for export and print buttons

I've changed the behaviour of the export and print buttons to use a post instead of get request.
I got some issues with long urls as i have to many filters and columns in my datatable.
As jquery post does not support downloading files, i've used a xhr function i've found here.
Laravel requires a csrf token for post requests, so i've added that to the script.blade.php file (i'm not sure if this is the best solution).
I've tested the excel, csv, pdf and print button in Firefox and Google Chrome.
I had to change my routes file also to handle the get and post request to the datatable:
Route::match(['get', 'post'], '/', function () { ... });
Fixes issue #348

@alex-LE thanks for this great PR. I think it would be better if we can adopt to what method the DT ajax used? If get method was used, we stick to get for export and same goes for post. This way, it would not break any installations.

Makes sense, i will be back in the office next week.
I will have a look at it.

@alex-LE thanks for this PR. Will be implementing this feature on v7 by adding a new button like excelPost, csvPost & pdfPost. This way, it would not break any existing installations and we will have more options too. My friend started this approach on this PR #826 and will continue the development from there. Thanks!


Merge FAQ entries risk_encounter_different_devices & dissimilar_indication_of_risk_status (Addresses #2536)

Description
This PR removes the FAQ entry risk_encounter_different_devices & adds a redirect to the FAQ entry dissimilar_indication_of_risk_status instead.
What was changed

https://www.coronawarn.app/de/faq/#risk_encounter_different_devices was deleted
https://www.coronawarn.app/en/faq/#risk_encounter_different_devices was deleted
A FAQ redirect from risk_encounter_different_devices to dissimilar_indication_of_risk_status was added

Screenshots
Nothing to see here, move along.

Follow up to  #2673.
Fixes #2536

https://github.com/corona-warn-app/cwa-website/pull/2674/commits/0bfb9dc704e717d0c4884904da1ddc6b57da0aee resolved merge conflicts.
PR is ready to merge.

@dsarkar Is something blocking the merge of this PR? I'm just wondering because other PRs are merged as normal, even if they were just provided today.

@Ein-Tim Nothing blocking it, will have a closer look.

@Ein-Tim LGTM. One small thing: In our OP is says:

A FAQ redirect from risk_encounter_different_devices to dissimilar_indication_of_risk_status was added

It's the other way around... ;-)

@Ein-Tim @MikeMcC399 Thanks.

@dsarkar I fixed the OP, sorry.


2003-fa-classnames

Coverage increased (+0.01%) to 67.656% when pulling dd818322c12358733af5a31dcbb2c01104cf493f on 2003-fa-classnames into 2426f6123a79126e8b7b559a5a12ca32f2e2f6ac on master.

Coverage increased (+0.01%) to 67.656% when pulling dd818322c12358733af5a31dcbb2c01104cf493f on 2003-fa-classnames into 2426f6123a79126e8b7b559a5a12ca32f2e2f6ac on master.


D_loss becomes NAN during training

Hi, I meet a problem during training：D_loss becomes NAN
I have tried several times and the problem always appears at around 2600 steps.

I have loaded the teacher ckpt and I only changed data-dir and batch-size(from 8 to 6 since limited by memory) in "run_train_val.sh" .
issue25 seems to meet a similar problem. But I can't find branch d1ec858 mentioned in that issue.
Could you please give me some advice?
Thank you! and Best wishes!

git clone all the code, and then git checkout d1ec858
You will find that branch.

Thanks for your reply! I have found it.

Hello! I changed the batchsize from 8 to 4  becaouse the limit of my gpu memory. Then I came across NAN.
And I have tried git checkout d1ec858,  but the pixelwise loss never decreased.

Can you please tell me how to deal with this problem? Thank you so much.


[Bug] Touchscreen move does move in scene but does not actually move objects

Touchscreen move does move in scene but does not actually move objects
V0.7.6

Hm. Odd. I'll add it to the itinerary to check. My brother has a touch screen.


Caffe2 model ?

Is it possible to provide a Caffe2 model along with the torch one ?

There are no plans to add caffe2 models right now. However, we hope that
the codebase will be help others in the community to implement our models
in the deep learning framework they're most comfortable with.
On 31 May 2017 at 03:43, goldenbr0wn<EMAIL_ADDRESS>wrote:

Is this possible to provide a Caffe2 model along with the torch one ?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/facebookresearch/fairseq/issues/47, or mute the
thread
https://github.com/notifications/unsubscribe-auth/ADGSfrhykrFzN6xgAT-qtUVO6vuMzQKNks5r_URjgaJpZM4NreL6
.


Merge cloned meshes crash the browser

The following simple code worked in "5.0.0-beta.11" but since "5.0.0-rc.0" and "5.0.0-rc.1" it crashed the browser totaly:
let meshArray = [];
let mainBox = BABYLON.MeshBuilder.CreateBox("MainBox", {width: 500, height: 1000, depth: 200});
for(var x= 0; x <10; x++){
let cloneBox = mainBox.clone("Clone_"+x);
cloneBox.position = new BABYLON.Vector3(0 + x*530, 0, 0);
meshArray.push(cloneBox);
}
let mergedMesh = BABYLON.Mesh.MergeMeshes(meshArray, true, false, undefined, false, true);
I think the problem is to merge cloned meshes now.
If I insert the line "cloneBox.makeGeometryUnique();" after cloning it works.
Is this intended or a bug?
I made a demo in the playground (It takes a while bevor the error occures --> out of memory):
https://playground.babylonjs.com/#6XIT28#1950

Please use the forum for questions as stated in the issue template :)


Projects in inconsistent state

Hi,
With project root disabled, if I open the fourth project, and then the first one, the fourth one hide its files (leaving the project root but with the arrow as if it was opened). I can click two times on the fourth project root to reopen it, but if I click on a file, it hides again and doesn't handle the click, I have to close the first project root to be able to click on the fourth files.
Thank you :)

So now that the theme works with three project roots, the natural next step is four project roots 😯 (just trying to imply that I find it a bit funny that there is always the n+1:th case, even if I was sure that if it works with three roots, it will work with n roots).
It may take a while for me to get into this. I have been doing some pretty heavy optimizations of which some have had really diverse  and unexpected effects. So it will take a while to finish the restructuring of the codebase. (but it has already solved at least a dozen of inconsistenices). 😃

This should be okay now. I had given the highest z-index for the selected project root - not the expanded one, so as soon as the focus was lost, other folders got a higher z. Now it should work with as many project roots as your display can display!


Update codes based on prior code review for item #21

@sebbrudzinski
I've updated codes based on your code review for Item #21. Please kindly help review again. Thank you very much.  :-)

@sebbrudzinski
I've removed unrequired commit and please help review. Thank you.  :-)

@sebbrudzinski
Is there any problem in my updates? Please kindly help review my codes and provide your valuable feedback. Thank you very much.  :-)

May anybody help review my codes and provide your valuable feedback? I hope to finish this workitem and select the next to work. Thank you very much.  :-)

May anybody help review my codes and provide your valuable feedback? I hope to finish this workitem and select the next to work. Thank you very much.  :-)

@WhiteHsu Sorry it takes so long. I'll try to have it reviewed as soon as possible.

@sebbrudzinski
Thanks for reply. Please kindly let me if any suggestion or feedback. :-)

@sebbrudzinski
Thanks for your comments. I'll update codes accordingly. However, for the method "SwingUtilities.invokeLater()", because the method "saveProgress()" will call the Windows System API, if we dont wrap it with method "SwingUtilities.invokeLater()", there'll be exception thrown as below:

Here's the exception message:
java.lang.IllegalStateException.txt
This's my first time to encounter this problem and I've tried to find out solution via internet. There're different webpages recommending this solution with "SwingUtilities.invokeLater()". Here's example:
http://dev.platform.netbeans.narkive.com/IT166Fcp/creating-topcomponent-from-thread
http://stackoverflow.com/questions/12464524/getting-java-lang-illegalstateexception-this-call-must-happen-in-the-awt-event
After much try and I find this really works, so I've developed codes as you see. Or do you have any other suggested way? Please help feedback and advise. Thank you.  :-)

Thanks for letting me know. I've got no problem having it in the code, just wanted to know the reason we need it in the codebase.

@sebbrudzinski
Thanks for your feedback. I've updated codes based on your comments. Please help give it a look. Thank you.  :-)


To create a way to alter only the dropdown item menu's background color.  Allowing the selected item and the list of items to have different background colors.

When trying to customize the drop down, you should be able to customize the dropdown items list separate from the selected item.

You can already do that @julianallen63


181

Hi there! Could you please specify what you are trying to achieve?

I'll close this issue as irrelevant. If you have any further comments, please write them here.


[directxsdk] Add missing d3d9 header and lib

The legacy directxsdk package is in a pretty bad way by the looks of things. On first glance, and for my use case, it didn't even declare d3d9.h, d3d9.lib or its associated headers/libraries from the archive, making it useless for "low-level" Direct3D work.
This is an incomplete fix-up just to add the extra missing pieces that I need for my use case. It probably needs a much more comprehensive overhaul.
Also... the package search tool declares that this supports arm64! That is obviously not the case.

[x] Changes comply with the maintainer guide
[x] SHA512s are updated for each updated download
[x] The "supports" clause reflects platforms that may be fixed by this new version
[x] Any fixed CI baseline entries are removed from that file.
[x] Any patches that are no longer applied are deleted from the port's directory.
[x] The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
[x] Only one version is added to each modified port's versions file.

@microsoft-github-policy-service agree

Thanks!


Shows total of users when doing the export.

If I have a total of 9 users and the query that I inserted in the search bar queries 5 users, this screenshot happens.

Issue has been fixed


Login Failure When Player's Logout World is not the default.

If the last world used is the same as the default world, login works without any issues.  If not then:
Receive the following warning in the console and the login doesn't happen.  There is no error presented to the Player, it simply continues repeating the "Please Login" message.
Tried the latest test build #17 and it still happens.
Here's the log: https://pastebin.com/pguPpgHk
Regarding the 'Warning" I was able to find this posting stating that Teleports should not be done Asynchronously
https://www.spigotmc.org/threads/help.92977/
I barely know what that means I just included it for completeness.

Well, I had Zero (0) experience in Plugins for Bukkit/Spigot but with a lot of googling I managed to find and fix the problem with multiworld support.  It was the fact that the AuthAction method was being run in a background thread.  Bukkit's API is not threadsafe.  I disabled the background thread and cleaned it up a little bit.  Tested working on my Spigot 1.12.2 server.  Here is a link to both the patch file (diff) and the compiled .jar file.  http://www.mediafire.com/file/pdt7qlx0j8r02xx/LoginSecurity-Fixed-MultiWorld.zip

@leeadama A lot of things in LoginSecurity are run on the background thread. I do this for performance reasons.
LoginSecurity communicates with a databases when players sign in, this can take several milliseconds, even more when you are using a MySQL database. If we run this on the main thread, the server will be doing nothing while its retrieving this data, instead of processing chunks, entities and other plugins.
Naturally, this is bad and decreases FPS.
However, you can't run everything on the background thread, because the server itself, like you said, is singlethreaded. So whenever any entity/item/world action is performed, it switches back to the main thread.
If the user is teleported asynchronously, that's a mistake on my part. I will fix it in the next version.


Trim spaces in the location fields and regenerate location ids

Description
Some location IDs in the location table contain a _ at the end. The municipality may have ending spaces. Example: US-Washington-Wenatchee_
Proposed solution
Trim spaces at the beginning and end of the municipality values. As part of this issue, we should also trim spaces in country_code and subdivision_name to avoid the same problem.

Tasks:

Identify all feeds with missing municipality and/or subdivision field (2 underscores in the middle, underscore at beginning or end)
Modifying the concatenation code in populate script to trim
Update database (manually or Liquibase)

Resources:
update database script locally

Blocked by #402

Because the dash is a legitimate character in subdivision-name. and municipality, it is suggested to change the separator to a character that will be disallowed when setting the data. For example |
Question: Why is it a problem with is ending with the separator (for |, example is US|New-York|
Or have 2 separators after the other. e.g. US||
That is as good an ID as any other, plus it conveys some info.

In the current DEV db, there are:

5 subdivision_name starting or ending with a space
6 municipalities starting or ending with a space.

Blocked until after release.
We will then have to remove entries in the location table by hand

Deleted 15 unused locations by hand in PROD.


Add unique id for each worker and pass it to the child process

This PR is related to issue #2284
The Problem
When trying to run integration tests in parallel, there could be a race of conditions.
For example when two tests are trying to modify the same record in a database at the same time.
To get full isolation, the user can choose one of two solutions:

Run the test serially.  -> slow... 😞
Create a different DB/server for each worker. -> unlocks the full potential of the machine 😉

But in order to use the second, you need unique identifiers for each worker, so you could assign each test to a different server.
For example:
const port = 3000 + process.env.JEST_WORKER_ID

Summary
Assign a unique id for each worker and pass it to the child process. It will be available via process.env.JEST_WORKER_ID.

The first index would be 1.
We store the id as a number and it is being cast to string only when passed to the newly forked process.
A test that verifies the options that passes to each worker needed to be modified with the new workerId option.
A test that checks that the options have passed to the child uses process.env, lucky enough, jest uses itself for testing, so we could use the same JEST_WORKER_ID 😄

Test plan

Test that each individual worker gets its own unique id from the farm.
Verify that the worker assigns the workerId to the env.JEST_WORKER_ID.

Questions

should we update the readme with this new feature?

Codecov Report

Merging #5494 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #5494      +/-   ##
==========================================
+ Coverage   61.66%   61.67%   +<.01%
==========================================
  Files         213      213
  Lines        7070     7071       +1
  Branches        3        3
==========================================
+ Hits         4360     4361       +1
  Misses       2709     2709
  Partials        1        1

Impacted Files
Coverage Δ

packages/jest-worker/src/types.js
100% <ø> (ø)
:arrow_up:

packages/jest-worker/src/worker.js
100% <ø> (ø)
:arrow_up:

packages/jest-worker/src/index.js
85.89% <100%> (+0.18%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8d1c79...931f73a. Read the comment docs.

Regarding the README, it'd be good to mention it; I think that not only Jest itself can benefit from this (e.g. Metro also uses jest-worker in its core).

@mjesun that's awesome!
About the README, do you think that something like a small note regarding the existence of such environment param on each worker would be enough?

Yep, that sounds good to me! If you can demonstrate it in a concise example too, it would be awesome 😄

What do you say about extending the original example of the standard usage?
something like:
import Worker from 'jest-worker';

async function main() {
  const myWorker = new Worker(require.resolve('./worker'), {
    exposedMethods: ['foo', 'bar', 'getWorkerId'],
    numWorkers: 4,
  });

  console.log(await myWorker.foo('Alice')); // "Hello from foo: Alice"
  console.log(await myWorker.bar('Bob')); // "Hello from bar: Bob"
  console.log(await myWorker.getWorkerId()); // "3" -> this message sent from the 3rd worker

  myWorker.end();
}

main();

File worker.js
export function foo(param) {
  return 'Hello from foo: ' + param;
}

export function bar(param) {
  return 'Hello from bar: ' + param;
}

export function getWorkerId() {
  return process.env.JEST_WORKER_ID;
}

You're awesome @ranyitz, thanks for implementing this! :)

The comment you added LGTM, but if you want to extend the example it'd be awesome!

@mjesun Example added.
I think this is ready 🎉

Yup! Let's wait for the green light in CI and we'll merge. Thanks for your contribution!

no problem, thanks for the review!

Hey! Thanks for solving https://github.com/facebook/jest/issues/2284!

Is there a way to access this workerId from the test function?

I assume that process.env.JEST_WORKER_ID would contain the id in the test method. Notice that when executing a single test, the test is executed on the main process for performance reasons, so there you won't have it.

Or using runInBand or --workers 1

@mjesun @SimenB Yes, as Jest does this in various cases:
https://github.com/facebook/jest/blob/6a77ee37ec2d46ece7e9cfd0f891d11c113cc4c4/packages/jest-cli/src/test_scheduler.js#L88-L96
We should probably add something to the process.env.JEST_WORKER_ID in runInBand case.
It could be just 0, as child workers start from 1.

Yes, that is precisely what happens internally in Jest. Each of the test files is sent to an available worker, only one at a time per worker.
What you have to be aware though, is to fully clean your stuff using the available after hooks. If you leak an opened connection letting your test file finish, a new one will be scheduled to its worker, which could run into a collision.

Regarding the --runInBand, I think it sounds reasonable. PRs welcome ☺

@mjesun thanks for the explanation.

@mjesun I've created a PR here #5860 :ok_hand:

@alexbyk @ranyitz just created a PR that I merged that will also provide JEST_WORKER_ID when running in band. That should avoid you the ||; I will release that probably as an alpha tomorrow  🙂

What version of jest do I need to have to use this feature? I just updated to v23.0.0-alpha.6r and process.env.JEST_WORKER_ID gives me undefined.  Am I missing something?

It should be there.
@mjesun

@SimenB is right. Without any other context it's hard to say what is going on. Can you share the test code or a minimal repro?

@evantahler That was fixed some time ago by @ranyitz :)

Oh! Wonderful.

In #5860 fwiw


Add healthCheck monitor to app service

This will automatically truncate web requests from reaching faulting app plan instance(s)
Context
Health Check Monitor for probing faulty app plan instances by checking app service endpoints
Changes proposed in this pull request
Introduce one new parameters `"healthcheckpath":{

                                                                        "value": "/ping"
                                                                        },`

Add new key\value pair to appServiceAppSetting parameters:-
{  "name": "WEBSITE_HEALTHCHECK_MAXPINGFAILURES",   "value": "5"  }
Guidance to review
Checklist

[ ] Make sure all information from the Trello card is in here
[ ] Attach to Trello card
[ ] Rebased master
[ ] Cleaned commit history
[ ] Tested by running locally

 Investigate load-balancing and redundancy

 Investigate load-balancing and redundancy

 Investigate load-balancing and redundancy

 Investigate load-balancing and redundancy


fatal error: 'windows.h' file not found

Got this when installing:
$ npm install node-beep --save-dev
  CXX(target) Release/obj.target/beep/beep.o
../beep.cc:4:10: fatal error: 'windows.h' file not found
#include <windows.h>
         ^
1 error generated.
make: *** [Release/obj.target/beep/beep.o] Error 1

Node v6.8.1
npm v3.10.8

Are you using linux?

Oh, sorry, Unix/macOS Sierra.
Let me know if I can help test (or, maybe it' just my machine?)

Also, I have a homebrew-installed version of Node.

This package works just in Windows.

Ahhhh, my bad. I guess I should have realized that considering the name windows.h. 😆
Thanks!

@jayralencar you should mention "windows-only" in your readme.

I am sorry, this package is discontinued.


[HUDI-544] Archived commits command code cleanup

What is the purpose of the pull request
Now, archive path have two different default value: "archived" and "". It cause a bug.
Brief change log

Change default path to archive
Cli read archive by path stored in .hoodie
User define archive path

Verify this pull request
This pull request is a trivial rework / code cleanup without any test coverage.
Committer checklist

[x] Has a corresponding JIRA in PR title & commit

[ ] Commit message is descriptive of the change

[ ] CI is green

[ ] Necessary doc changes done or have another open PR

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

@n3nash addressed the comment.

@hddong @n3nash, ArchivedCommitsCommand contains two bellow commands,
if just using metaClient.getArchivePath() + "/.commits_.archive*", it will affect old tables.
Compare to changes:

metaClient.getArchivePath() + "/.commits_.archive*" = '/table/.hoodie/archived/.commits_.archive*'
basePath + "/.hoodie/.commits_.archive*" = '/table/.hoodie/.commits_archive*'

So the better way is add archiveFolderPattern to show archived commits command.
show archived commit stats

show archived commits

@hddong please take a look at the last comment

@n3nash Sorry to feedback late. Have renamed this PR. BTW, I think  new Path(basePath + "/.hoodie/.commits_.archive*") will cause some bug like HUDI-540.

@n3nash @vinothchandar please rereivew this agian.

@n3nash is shepherding this.

@n3nash squashed all commits to 1.  I had do something for create another ticket for us, but I am not sure if it is right.

@hddong

@hddong I'm accepting and will merge after you create another ticket for us to add to the release notes that if someone was actually overriding HOODIE_ARCHIVELOG_FOLDER_PROP_NAME that was not being honored before and now will be honored for those cases it can break (since this is the right thing to do)

This is what I had commented. So this change will break if someone was overriding this prop name  and expecting that path to be used (but it was actually not since it was never used). can you open a ticket for us to add this to the release notes and we can merge then.

@n3nash : Sorry, I understand the reason, but I don't quite understand what the mean of open a ticket and how to open a ticket for you. Can you give me some detailed instructions？

@hddong Please create a JIRA ticket here -> https://issues.apache.org/jira/projects/HUDI/issues and add the tag of documentation/release notes update.

@n3nash : Had rebase this PR and create a new jira https://issues.apache.org/jira/browse/HUDI-1085.

@hddong Sorry this fell through, please rebase and I will merge this asap

@n3nash : had rebase this, please have a review when free.

@n3nash : had rebase this again, please have a review when free.

@hddong Extremely sorry, this fell through the crack, please rebase and I will merge this right after.

@n3nash if you wish you can also rebase this yourself and push. See https://cwiki.apache.org/confluence/display/HUDI/Resources#Resources-PushingChangesToPRs for a how-to

@n3nash: Had rebase this.