feat: hide login button when not logging in is disabled

NOTE: env variable has NEXT_PUBLIC prefix so that the value is available client-side.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 62.557%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1240

Relevant Lines:
1724

💛  - Coveralls

Nice. LGTM
Is ENABLE_LOGIN totally superseded by NEXT_PUBLIC_ENABLE_LOGIN?
And is withSession still in the codebase? IIRC it was not used, but still in the repo. That used ENABLE_LOGIN too I think...

It will supersede yeah.  We need to use the value on the client so if we don't add the prefix we get a hydration error.  good point about withSession, let me update that 1


added support for solaredge inverters

Pull Request
Description
This links with #59 (specifically my list of similar inverters to enphase here)
What I did
Tried to Obtain the required credentials from the SolarEdge developer portal, could not do it since i dont have a solaredge system.
I need a SOLAREDGE_ACCOUNT_KEY and a SOLAREDGE_USER_KEY but i have updated the .env.example to include them

Additions to increase inclusivity from my last merge that focussed only on Enphase (#106)
Added a new file /quartz_solar_forecast/inverters/solaredge.py which has functions to  get_site_coordinates, get_sites_list, and get_solaredge_data.
I have integrated the authentication as was required for this version of the API(v2) as per the docs.
Updated the pydantic_models to have the inverter as a string which choices for enphase and solaredge rather than a bool.
Updated make_pv_data in data.py  to conditionally use the inverters based on user choice
How Has This Been Tested?
This hasnt been tested yet since i dont have a solaredge system which makes it difficult to create an account
Checklist:

[x] My code follows OCF's coding style guidelines
[x] I have performed a self-review of my own code
[x] I have made corresponding changes to the documentation
[x] I have checked my code and corrected any misspellings

Hi @peterdudfield , I've tried extending support for SolarEdge inverters in this pr, could you please review it and let me know if it is fine

Thanks so much for this @aryanbhosale .
Is it possible to right any tests for this? Might have to mock api

Thanks so much for this @aryanbhosale .
Is it possible to right any tests for this? Might have to mock api

Thank you @peterdudfield ,I can write mock api tests for the same, any help regarding which file I should write it in and about the edge cases?

Thanks so much for this @aryanbhosale .
Is it possible to right any tests for this? Might have to mock api

Thank you @peterdudfield ,I can write mock api tests for the same, any help regarding which file I should write it in and about the edge cases?

In the test folder, please

Do you know why in the CI the tests fail?
Let me kknow if they pass locally and we can get this merged in

Do you know why in the CI the tests fail? Let me kknow if they pass locally and we can get this merged in

Hi @peterdudfield i just made another commit that fixes these errors, i just had to make default pvsite as none (basically keeping it as optional)

Do you know why in the CI the tests fail? Let me kknow if they pass locally and we can get this merged in

Hi @peterdudfield i just made another commit that fixes these errors, i just had to make default pvsite as none (basically keeping it as optional)

Hi @peterdudfield , do i need to make any other changes to this or is it good to go?

Yea looks, good. I thought you might add a mock test to this?

Yea looks, good. I thought you might add a mock api test to this?

Could you please briefly describe what kind of cases you want it to cover, and how different it should be from the current tests? I'm confused about that

Yea looks, good. I thought you might add a mock api test to this?

Could you please briefly describe what kind of cases you want it to cover, and how different it should be from the current tests? I'm confused about that

Ideally we would add mock api tests for any api we are hitting, with an example response. This make it easy to test and development.
Why dont we make a seperate issue for this, and then merge this PR

Yea looks, good. I thought you might add a mock api test to this?

Could you please briefly describe what kind of cases you want it to cover, and how different it should be from the current tests? I'm confused about that

Ideally we would add mock api tests for any api we are hitting, with an example response. This make it easy to test and development.
Why dont we make a seperate issue for this, and then merge this PR

I think that's a good idea, it would Integrate enphase and SolarEdge inverter data with the already existing mock data without affecting it, so a separate issue for the tests sounds good

Yea looks, good. I thought you might add a mock api test to this?

Could you please briefly describe what kind of cases you want it to cover, and how different it should be from the current tests? I'm confused about that

Ideally we would add mock api tests for any api we are hitting, with an example response. This make it easy to test and development.
Why dont we make a seperate issue for this, and then merge this PR

I think that's a good idea, it would Integrate enphase and SolarEdge inverter data with the already existing mock data without affecting it, so a separate issue for the tests sounds good

do you mind making the issue? If not I can

Yea looks, good. I thought you might add a mock api test to this?

Could you please briefly describe what kind of cases you want it to cover, and how different it should be from the current tests? I'm confused about that

Ideally we would add mock api tests for any api we are hitting, with an example response. This make it easy to test and development.
Why dont we make a seperate issue for this, and then merge this PR

I think that's a good idea, it would Integrate enphase and SolarEdge inverter data with the already existing mock data without affecting it, so a separate issue for the tests sounds good

do you mind making the issue? If not I can

Ill do it, will make a proper description, will need some feedback from you over the description but otherwise I don't mind doing it


Missing features such as ignoring pre tags

Hi,
I noticed that you have not used the full version of auto-render.js. I have found that your implementation does not ignore things like pre tags which the current auto-render.js for katex does implement correctly.
Is there any reason for this?

hi @JonathanWatkins, glad to read the first issue! Actually I can't remember if this option was available when I created the plugin. There's no special reason to not use it and it may be useful to explain plugin usage to users. It's definitely a good enhancement. Would you like to add it via a PR, or i'll do it later when I'll have a little more time.

This is really a big issue. I see nodebb-plugin-katex: Failed to parse xxx full of my log.

@henrywoo this is not related, these logs should only be written on verbose mode, when you're typing maths and the expression isn't yet finished so Katex complains. Are you running nodebb in dev mode?


TODO(AVCStalker): Ability to see how long a user was in VC for

maybe a dropdown with more data like in call duration?

zx


New UI icons not showing on initial load

Describe the bug
Upon first opening the IDE, the Atom Material UI Icons for the new UI do not display. After manually toggling the "New UI Icons" off then back on in the Atom Material Icons Settings, the UI icons display properly.
To Reproduce

Open any IDE with the new UI enabled
Notice the stock UI icons are displayed
Open the Atom Material Icons Settings
Uncheck the "New UI Icons" item
Click "Apply"
Re-check the "New UI Icons" item
Click "Ok"
Notice the Atom Material UI Icons are now properly displayed

Expected Behavior
Atom Material UI Icons for the new UI should display when first opening the IDE.
Environment
Note: I have also reproduced this bug in the latest PyCharm EAP (2022.3) with the "New UI" setting enabled as of 10/15/2022.
PyCharm 2022.2.3 (Professional Edition)
Build #PY-222.4345.23, built on October 10, 2022
Runtime version: <IP_ADDRESS>+7-b469.62 x86_64
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o.
macOS 12.6
GC: G1 Young Generation, G1 Old Generation
Memory: 1024M
Cores: 4
Metal Rendering is ON
Registry:
debugger.new.tool.window.layout=true
ide.experimental.ui=true
ide.balloon.shadow.size=0
Non-Bundled Plugins:
name.kropp.intellij.makefile (222.4345.14)
com.markskelton.one-dark-theme (5.7.0)
org.intellij.plugins.hcl (222.4345.14)
com.intellij.plugins.macoskeymap (222.4345.14)
com.intellij.plugins.expui (0.4)
com.github.leomillon.uuidgenerator (4.5.1)
com.dubreuia (2.3.0)
String Manipulation (9.5.1)
zielu.gittoolbox (212.9.9)
mobi.hsz.idea.gitignore (4.4.2)
com.mallowigi (73.0.0)
intellij.prettierJS (222.4345.14)
com.intellij.tailwindcss (222.4345.14)
NodeJS (222.4345.14)
com.leinardi.pycharm.pylint (0.14.0)
com.leinardi.pycharm.mypy (0.14.0)
com.koxudaxi.pydantic (0.3.13)
ru.adelf.idea.dotenv (2022.2)
Screenshots
Initial load of IDE (stock UI icons in left and right toolbars):

Need to manually toggle this checkbox:

Then the proper UI icons display in left and right toolbars:

Additionally, I have recreated this bug (on a different machine) on the latest PyCharm EAP (2022.3) with no other plugins installed:
PyCharm 2022.3 EAP (Professional Edition)
Build #PY-223.6160.21, built on October 5, 2022
Expiration date: November 4, 2022
Runtime version: <IP_ADDRESS>+1-b629.2 x86_64
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o.
macOS 12.6
GC: G1 Young Generation, G1 Old Generation
Memory: 2048M
Cores: 16
Metal Rendering is ON
Registry:
debugger.new.tool.window.layout=true
ide.experimental.ui=true
ide.balloon.shadow.size=0
Non-Bundled Plugins:
com.mallowigi (80.0.0)

This has been fixed and planned for next release.


[DOCU-3065] Data plane labels in konnect

Description
How-to guide for setting up and checking data plane labels in Konnect.
https://konghq.atlassian.net/browse/DOCU-3065
Testing instructions
Netlify link: https://deploy-preview-5554--kongdocs.netlify.app/konnect/runtime-manager/runtime-instances/custom-dp-labels/
Checklist

[x] Review label added
[x] PR pointed to correct branch (main for immediate publishing, or a release branch: e.g. release/gateway-3.2, release/deck-1.17)

False link checker failure, flagged links are fine.


Add PBS job id to sos tasks

After jobs are submitted, we can add the PBS task id to task tags, which makes it easier to track tasks and jobs.

The problem here is that the task files are usually on remote host. What we do right now is

transfer .task file to remote host
create .sh file and send to remote host
submit the job and obtain job_id

If we are to add job_id to task, we will have to modify the task file locally and re-send .task file to remote host, which can be done but does not look like a good idea.

An alternative is to by default add name to tags so that we can tell from job id from the task id. In the current implementation, it is difficult to link pbs jobs and sos tasks.

Sorry I did not weigh in on this one. Typically the way I use remote PBS system is to do -r directly without file transfer (because of too many / too large output files) -- that might have made things easier. For the time being, I was not actively tracking job ID's because it does not seem to be a need. But I can imaging many cases when it will matter.

Basically I need a way to link task id, pbs job id or name, and sample id. If task fails, I need to know which sample fails, and sometimes which job fails. Currently name can be set to ID (if there is such info) to link sample id to job name, but there is no easy way to link task id to pbs job. So we can

Rename name so that task id is always the same as job name. (#842)
Add value of name to tags automatically to link sample ID to tasks.

I tend to remove name because

one less parameter, users do not need to worry about adding ID to name and/or tags.
task id is always the same as job name, which makes things a lot easier.

I tend to remove name because

Remove name from task_id or from SoS task options? I still see the value of name though. I always find PBS job id is a bit hard to keep track of. But many systems will additionally list names in parallel with job ID, which is an appealing feature to me.

Remove name from task options so that PBS job will always use task ID. This is ok because tags allows multiple IDs such as workflow ID, step name, and sample ID so it is always better to use task tags.


[CI] Platform-agnostic build/test

Description
Closes #1114. We spend too much time waiting for CI runs when we could
be doing more productive things. We should have an easy time of making
changes and reusing bits of CI across workflows/repos, so should
simplify it where possible.
So use the default generator for the platform and platform-agnostic
CMake command lines.
This also makes downstream adoption more natural, removing the
dependency on Ninja and the need for the vcvarsall.bat preamble, and
ensures our CI tests reflect the standard build configuration across
platforms.
Modernise to use parallel builds where possible, and use all available
cores on runners.

[ ] I have updated the release notes.
[ ] I have updated all relevant user documentation.

Abandoning due to boilerplate involved, and, critically, Windows MSVC generator parallel ctest failures. See https://github.com/OpenAssetIO/OpenAssetIO/issues/1114#issuecomment-1968683513


RuntimeError: ../../sub-CRMBM/fmap/mask_spinalcord_DREAM.nii.gz does not exist

Using version d1f8ea06cf20d9a39a57982a72735bcd9136dea2
Indeed, masks for DREAM and SNR used in the code below are not created before:
https://github.com/spinal-cord-7t/coil-qc-code/blob/83dfd087445fb045dad77d2320847ff4af5492f9/data_processing-phantom.ipynb#L401-L402

Two options:

register the DREAM and SNR to the TFL
create separate ROIs

cons: introduces a bias when comparing TFL vs. DREAM (ie: we should be comparing using the same mask)

I had already co-registered the TFL spinal cord mask to the DREAM and SNR spaces via the command line, and I must have forgotten to add the line of code to the notebook. This way you use the same mask, but don't have the different coverage problem.
Unfortunately, I don't remember the exact line of code that I used, but this seems to have reproduced the masks I had:
https://github.com/spinal-cord-7t/coil-qc-code/blob/d2bc792c5388e0d31b4008ca177741a2d7a0f590/data_processing-phantom.ipynb#L359-L364

Change implemented in https://github.com/spinal-cord-7t/coil-qc-code/commit/d2bc792c5388e0d31b4008ca177741a2d7a0f590


#parse_from_title returns an empty string

> Pubid::Iso::Identifier.parse_from_title("ISO/IEC Guide 98-3:2008/Suppl 1:2008 Uncertainty of measurement — Part 3: Guide to the expression of uncertainty in measurement (GUM:1995) — Supplement 1: Propagation of distributions using a Monte Carlo method")
=> ""

It returns empty string because title is not parsable, we still don't support "Suppl" supplements (issue #153).
But maybe we should rise an error when title is not parsable.

@mico yes, it should raise an error.


Update SBOM generation

PR Summary
Update SBOM generation

Move cgmanifest into tools folder
Make cg detectiond a sbom use tools folder for component detection
Add package name and version

PR Context

PR Checklist

[ ] PR has a meaningful title

Use the present tense and imperative mood when describing your changes

[ ] Summarized changes
[ ] Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
[ ] This PR is ready to merge and is not Work in Progress.

If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.

Breaking changes

[ ] None
OR
[ ] Experimental feature(s) needed

[ ] Experimental feature name(s):

User-facing changes

[ ] Not Applicable
OR
[ ] Documentation needed

[ ] Issue filed:

Testing - New and feature

[ ] N/A or can only be tested interactively
OR
[ ] Make sure you've added a new test if existing tests do not effectively test the code changed

Tooling

[ ] I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
OR
[ ] I have considered the user experience from a tooling perspective and opened an issue in the relevant tool repository. This may include:

[ ] Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode
(which runs in a different PS Host).

[ ] Issue filed:

[ ] Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.

[ ] Issue filed:

[ ] Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).

[ ] Issue filed:

[ ] Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

[ ] Issue filed:

Harassment charges FBI people not playing stop the messages please
Sent from Yahoo Mail on Android
On Thu, Dec 16, 2021 at 7:13 PM, Travis @.***> wrote:
PR Summary
Update SBOM generation

Move cgmanifest into tools folder
Make cg detectiond a sbom use tools folder for component detection
Add package name and version

PR Context
PR Checklist

PR has a meaningful title

Use the present tense and imperative mood when describing your changes

Summarized changes

Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header

This PR is ready to merge and is not Work in Progress.

If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.

Breaking changes

None
OR
Experimental feature(s) needed

Experimental feature name(s):

User-facing changes

Not Applicable
OR
Documentation needed

Issue filed:

Testing - New and feature

N/A or can only be tested interactively
OR
Make sure you've added a new test if existing tests do not effectively test the code changed

Tooling

I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
OR
I have considered the user experience from a tooling perspective and opened an issue in the relevant tool repository. This may include:

Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode
(which runs in a different PS Host).

Issue filed:

Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.

Issue filed:

Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).

Issue filed:

Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

Issue filed:

You can view, comment on, or merge this pull request online at:
https://github.com/PowerShell/PowerShell/pull/16641
Commit Summary

65d362b switch to new sbom template
5ec0f61 add names for linux
aebfbe6 move cgmanifest
019e087 fix CG
e4e83c5 fix macos GC failures
c207fe8 use already set repoRoot for repoRoot
e0875c8 fix the correct template
6f05fda fix autodetections
9fa0df4 Revert "switch to new sbom template"

File Changes
(22 files)

M .github/prquantifier.yaml (2)
M .vsts-ci/linux.yml (2)
M .vsts-ci/mac.yml (2)
M .vsts-ci/misc-analysis/mdSpell.yml (2)
M .vsts-ci/windows.yml (2)
M .vsts-ci/windows/templates/windows-packaging.yml (1)
R tools/cgmanifest.json (0)
M tools/findMissingNotices.ps1 (4)
M tools/releaseBuild/azureDevOps/templates/SetVersionVariables.yml (22)
M tools/releaseBuild/azureDevOps/templates/compliance.yml (2)
M tools/releaseBuild/azureDevOps/templates/compliance/compliance.yml (2)
M tools/releaseBuild/azureDevOps/templates/compliance/generateNotice.yml (9)
M tools/releaseBuild/azureDevOps/templates/json.yml (2)
M tools/releaseBuild/azureDevOps/templates/linux.yml (20)
M tools/releaseBuild/azureDevOps/templates/mac-file-signing.yml (13)
M tools/releaseBuild/azureDevOps/templates/mac-package-build.yml (5)
M tools/releaseBuild/azureDevOps/templates/mac-package-signing.yml (13)
M tools/releaseBuild/azureDevOps/templates/mac.yml (2)
M tools/releaseBuild/azureDevOps/templates/nuget.yml (2)
M tools/releaseBuild/azureDevOps/templates/windows-hosted-build.yml (2)
M tools/releaseBuild/azureDevOps/templates/windows-package-signing.yml (12)
M tools/releaseBuild/azureDevOps/templates/windows-packaging.yml (5)

Patch Links:

https://github.com/PowerShell/PowerShell/pull/16641.patch
https://github.com/PowerShell/PowerShell/pull/16641.diff

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: @.***>


vue-components: plain storybook extract command

At the time of writing, storybook 6 was not released yet and running the
extract command on a storybook 5 (the npx default) caused an error.
Not sure if pinning to the now-current storybook version would be
better, but it's not how the storybook people document it1, and will
cause future update effort (or inconsistency) while it is unlikely the
command will ever change without us having to touch the line anyways.

Found https://github.com/storybookjs/storybook/issues/12204, relief in the fact that we are not the only ones concerned that a config already known to storybook in machine-readable format has to extracted from it using a webbrowser, and reconciliation in hearing that the sb team has taken note of this problem and it may be resolved at some point.


Django 3.1 and Python 3.8

Need to wait for a new version of https://github.com/niwinz/django-jinja to be released to fix the same issue

Can you change this to use GH actions please?


async functions don't work as expected with throw() assertion

Essentially, if you attempt to use the throw() assertion with an async function, it will fail to assert properly.
Node.js version?
7.9, 7.8
Should.js version?
11.2.1
How to reproduce it?
let should = require('should');
(async function() {
	throw new Error('fail');
}).should.throw('fail');

produces the output:
/Users/tony/development/should-bug/node_modules/should/cjs/should.js:237
      throw new AssertionError(params);
      ^
AssertionError: expected Function { name: '' } to throw exception
    at Assertion.fail (/Users/tony/development/should-bug/node_modules/should/cjs/should.js:258:17)
    at Assertion.value (/Users/tony/development/should-bug/node_modules/should/cjs/should.js:335:19)
    at Object.<anonymous> (/Users/tony/development/should-bug/index.js:5:16)
    at Module._compile (module.js:571:32)
    at Object.Module._extensions..js (module.js:580:10)
    at Module.load (module.js:488:32)
    at tryModuleLoad (module.js:447:12)
    at Function.Module._load (module.js:439:3)
    at Module.runMain (module.js:605:10)
    at run (bootstrap_node.js:423:7)

possible resolution
There's an area of the lib/ext/error.js file that could be modified to support this, BUT it is unfortunately not simple since there's no real concept of handling async functions in assertions at this point. Specifically:
https://github.com/shouldjs/should.js/blob/master/lib/ext/error.js#L54
If instead of just invoking fn() here you instead check to see if the function is async (a similar quick and dirty check like generators) and if it is, call await fn() instead. This of course requires the containing function to be async, which in turn screws up all the existing throw() assertion tests. So while handling these async functions with the throw() assertion isn't that hard, it is in fact hard, and may require some heavier lifting, to make it work side-by-side with the existing synchronous cases of throw().

Well, because of a mix of terms like function and async this could looks strange. But async function still a function returning promise. So you can just do:
$ node
> const should = require('.')
undefined
> let f = async function() { throw new Error('boom') }
undefined
> f
[AsyncFunction: f]
> f()
Promise {
  <rejected> Error: boom
> (node:4052) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 1): Error: boom
(node:4052) DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js
 process with a non-zero exit code.

> f().should.be.rejected()
Promise { <pending> }
>

I am not sure if i should add promises support to .throw (probably should? because generators there so why not).

So rejected and rejectedWith work, when they work. Let me explain with a slightly modified case:
❯ node
> const should = require('should');
undefined
> async function foo() {
... 	throw new Error('foo');
... }
undefined
> foo().should.be.rejectedWith('foo');
Promise { <pending> }

The above does exactly what I need. Asserts that the Promise is rejected with the value 'foo'. Unfortunately, though, should doesn't give me an error when it does not match the string. For example:
❯ node
> const should = require('should');
undefined
> async function foo() {
... 	throw new Error('foo');
... }
undefined
> foo().should.be.rejectedWith('foo1');
Promise { <pending> }
> (node:85568) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 2): AssertionError: expected [Promise] to be rejected with a message matching 'foo1', but got 'foo'
(node:85568) DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

So the problem that remains is that it's not giving me an assertion-breaking error when the Promise does not match the string, it's giving me the node.js UnhandledPromiseRejectionWarning, but it's not actually failing the assertion and then continues as though nothing is wrong.
Is this is a bug with rejectedWith(), or am I doing something wrong here?

also noticed this, and have also seen the same issues with chai
For reference, here is the thread on the chai project: https://github.com/chaijs/chai/issues/415
+1 for using throws, I think it better expresses the intent of writing code in this synchronous fashion

@tonylukasavage sorry but in your last example number of issues. You are getting only half of the picture.
I created simplified test case to explain you better:
const should = require(".");

async function foo() {
  throw new Error("AAA");
}

function it(name, callback) {
  var res = callback();
  if (res != null && typeof res.then === "function") {
    return res.then(() => console.log(name, "Ok"), err => console.error(name, err.stack));
  }
}

it("async/await rejected positive pass (no assertion)", async () => {
  await foo().should.be.rejected();
});

it("async/await rejected positive assert (assertion is ok)", async () => {
  await foo().should.be.rejectedWith("BBB");
});

it("async/await fulfilled assert (assertion is ok)", async () => {
  await foo().should.be.fulfilled();
});

After exectution you will get something like this in console:
$ node test.js
async/await rejected positive pass (no assertion) Ok
async/await rejected positive assert (assertion is ok) AssertionError: expected [Promise] to be rejected with a message matching 'BBB', but got 'AAA'
    at next$onError (D:\Projects\shouldjs\should.js\cjs\should.js:1696:12)
    at runMicrotasksCallback (internal/process/next_tick.js:64:5)
    at _combinedTickCallback (internal/process/next_tick.js:73:7)
async/await fulfilled assert (assertion is ok) AssertionError: expected [Promise] to be fulfilled, but it was rejected with Error { message: 'AAA' }
    at Assertion.fail (D:\Projects\shouldjs\should.js\cjs\should.js:258:17)
    at next$onReject (D:\Projects\shouldjs\should.js\cjs\should.js:1522:14)
    at runMicrotasksCallback (internal/process/next_tick.js:64:5)

So as you see it throw where it should and pass where it should.
You are getting some false sence of sync code, but to make it look async you do not use await where you should (to get promise value).
Please let me know if it still unclear. Or maybe i do not really understand whay you mean.

@msenevir You linked issue i think is not about the same Tony has. You are rightly using .eventually + .throw so internal context will be switched to handling promises.
I believe your example will work fine/similar there.

@btd i see how you resolved the issue I was having with rejected, thank you. It was a sloppy natural progression from the throw() test (to which I'm accustomed) to the rejected tests which I hand't yet used.
I'll leave it up to you whether or not you want to keep this issue open to address handling this in the throw() assertion

@tonylukasavage i am not sure about modifying .throw is a right idea. I am worrying this will create confustion, between sync and async assertions.
I will rest this open, maybe some other folks could add something to this.

@msenevir @tonylukasavage
I wrote promise assertion that way - after you call .eventually/.finally assertion switching to use promises and all methods of usual assertion will work as expected, but with .throw it is a bit different, as .throw expecting as an input function or generator. But as an input using foo() we are getting already rejected promise.
The best i can do currently:
it("async/await .finally/.eventually proxy all assertions", async () => {
  await foo().should.finally.be.Error();
});

This is because await make it look sync, and promise returing Error.
I finally think overriding .throw for promises is not right, this is too different concepts. It is better to educate users do right thing.


Setup Kanban Board

Hi, we are 4 members of the team
@FaranoshAmini
@aradradev
@sunga12
@hmunish
Kanban board link:- https://github.com/hmunish/final-capstone-backend/projects/1
Front end repository link:- https://github.com/hmunish/final-capstone-frontend

Hi @hmunish
Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!

Required Changes ♻

[ ] Kindly, add a description to this card:

That way, we will meet that particular requirement. 👍
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Hi STUDENT_MENTION,
Wow, you did it 🎉

Thank you for implementing the changes requested by the previous reviewer 💪 🥇 ㊗
Well done!
Your project is complete!  There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉
To highlight

All cards have descriptions now✔

Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.


[Not4Review] Ipam kind test

Codecov Report

Merging #2898 (c7c2097) into main (784dc4c) will decrease coverage by 2.75%.
The diff coverage is 31.19%.

@@            Coverage Diff             @@
##             main    #2898      +/-   ##
==========================================
- Coverage   61.44%   58.68%   -2.76%
==========================================
  Files         283      285       +2
  Lines       23587    23960     +373
==========================================
- Hits        14493    14062     -431
- Misses       7528     8373     +845
+ Partials     1566     1525      -41

Flag
Coverage Δ

kind-e2e-tests
45.77% <16.87%> (-3.18%)
:arrow_down:

unit-tests
40.65% <24.93%> (-0.35%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/agent/cniserver/ipam/antrea_ipam.go
0.00% <0.00%> (ø)

pkg/agent/cniserver/pod_configuration.go
56.00% <ø> (ø)

pkg/agent/util/net_linux.go
32.07% <0.00%> (-1.93%)
:arrow_down:

pkg/apiserver/handlers/featuregates/handler.go
76.00% <ø> (ø)

pkg/controller/egress/controller.go
84.12% <ø> (ø)

pkg/features/antrea_features.go
16.66% <ø> (ø)

pkg/ipam/ipallocator/allocator.go
80.41% <ø> (ø)

pkg/ovs/openflow/ofctrl_action.go
67.91% <0.00%> (-1.67%)
:arrow_down:

pkg/agent/agent_linux.go
3.78% <1.57%> (-76.22%)
:arrow_down:

pkg/agent/openflow/pipeline_other.go
2.17% <2.22%> (-47.83%)
:arrow_down:

... and 47 more


Counter,Todo and Clock examples don't compile on Mac OS Monterey

Is there an existing issue for this?

[X] I have searched the existing issues.

Is this issue related to iced?

[X] My hardware is compatible and my graphics drivers are up-to-date.

What happened?
I tried these 3 examples but none compile. Many errors, some about unresolved imports, some about the column! macro not taking any arguments
What is the expected behavior?
I expected them to compile. Below I've included the errors from the Clock example
Version
0.4
Operative System
macOS
Do you have any log output?
error[E0432]: unresolved import `iced::widget::canvas`
 --> src/main.rs:2:19
  |
2 | use iced::widget::canvas::{Cache, Cursor, Geometry, LineCap, Path, Stroke};
  |                   ^^^^^^ could not find `canvas` in `widget`

error[E0432]: unresolved import `iced::widget::canvas`
 --> src/main.rs:3:20
  |
3 | use iced::widget::{canvas, container};
  |                    ^^^^^^ no `canvas` in `widget`

error[E0432]: unresolved import `iced::Theme`
 --> src/main.rs:6:19
  |
6 |     Subscription, Theme, Vector,
  |                   ^^^^^ no `Theme` in the root

error[E0433]: failed to resolve: use of undeclared crate or module `time`
  --> src/main.rs:17:10
   |
17 |     now: time::OffsetDateTime,
   |          ^^^^ use of undeclared crate or module `time`

error[E0433]: failed to resolve: use of undeclared crate or module `time`
  --> src/main.rs:23:10
   |
23 |     Tick(time::OffsetDateTime),
   |          ^^^^ use of undeclared crate or module `time`

error[E0437]: type `Theme` is not a member of trait `Application`
  --> src/main.rs:28:5
   |
28 |     type Theme = Theme;
   |     ^^^^^^^^^^^^^^^^^^^ not a member of trait `Application`

error[E0433]: failed to resolve: use of undeclared crate or module `time`
  --> src/main.rs:35:22
   |
35 |                 now: time::OffsetDateTime::now_local()
   |                      ^^^^ use of undeclared crate or module `time`

error[E0433]: failed to resolve: use of undeclared crate or module `time`
  --> src/main.rs:36:41
   |
36 |                     .unwrap_or_else(|_| time::OffsetDateTime::now_utc()),
   |                                         ^^^^ use of undeclared crate or module `time`

error[E0433]: failed to resolve: use of undeclared crate or module `time`
  --> src/main.rs:65:17
   |
65 |                 time::OffsetDateTime::now_local()
   |                 ^^^^ use of undeclared crate or module `time`

error[E0433]: failed to resolve: use of undeclared crate or module `time`
  --> src/main.rs:66:41
   |
66 |                     .unwrap_or_else(|_| time::OffsetDateTime::now_utc()),
   |                                         ^^^^ use of undeclared crate or module `time`

error[E0425]: cannot find function `every` in module `iced::time`
  --> src/main.rs:63:21
   |
63 |         iced::time::every(std::time::Duration::from_millis(500)).map(|_| {
   |                     ^^^^^ not found in `iced::time`

error[E0423]: expected function, found module `container`
  --> src/main.rs:76:9
   |
76 |         container(canvas)
   |         ^^^^^^^^^ not a function

recently there was an update to the examples because of a new feature in the master(like a "syntactic sugar"), it could be because of this.
I was also having this problem and getting the previous version of the file before the modification worked


GSIs that share the hash with the primary index

This is more of a question that an issue...
(using v2.3.1 currently)
Why do indexes get created as LSIs if hash is the same as the primary hash even though local is not set to true?
E.g.
    indexes: {
        primary: { hash: 'pk', sort: 'sk'},
        gsi0: { hash: 'pk', sort: 'anotherProp', local: false},

results in an LSI
I have a use case where I want to use several GSIs that have the same hash as the primary (mostly to avoid the limitations of LSIs)
This can be achieved by duplicating the primary hash into a unique property for each GSI but this is unnecessary duplication so I was wondering why this choice was made, if it could be changed or if there's a better way to do this?
Many thanks

The doc is not correct in the examples:
You should use
    indexes: {
        primary: { hash: 'pk', sort: 'sk'},
        gsi0: { hash: 'pk', sort: 'anotherProp', type: 'local'},
    }

I'll move this to discussions.


Recovery the drop in accuracy

Researchers discovered that each transformer layer of LLMs impacts on accuracy differently. In general, the front layers are more important and should be pruned carefully. Besides, embedding and lm-head layers are also very important for keeping negligible accuracy drop.
@nailimixaM So my question is:

Will SliceGPT support skipping embedding and specific transformer layers? I guess it will achiveve better accuracy.
How many effort is needed to implement it?

Hi, we've got slicing schedulers for this, check them out. In the paper we tried out eigenvalue-based slicing scheduling, though didn't find it increase performance too much. If you find a slicing schedule that improves performance, let us know!

scheduling

Thanks for your quick feedback!
Did you have do similar experiments that freezing input embedding and several top transformer layers while slicing other layers? ShortGPT found that top layers are more important.

@zhaoyang-star in the paper we always performed constant slicing per layer, and achieved nice results - but there is definitely room for improvement by pruning some layers less than others!


Error reading page

when build mkdocs get ERROR    -  Error reading page 'index.md': 'NoneType' object has no attribute 'group' (v0.4.3)
but in v0.3.2 all good

Do you mean v0.3.4? The NoneType bug should be fixed in v0.3.4. Could you provide your code or a reproducible sample code?

Sorry, I forgot to publish a new release on the GitHub repository last week 😅. You can download the latest v0.3.4 from PyPI.


px.table()

See beginning of conversation at  https://github.com/plotly/plotly.py/issues/1485

I'm confused why this issue was closed? The linked plotly issue seemed to suggest this was a good fit for plotly_express?

Yes, but PX is now part of Plotly.py so the other issue is the main issue for this idea. I'm gradually phasing out this plotly_express repo and it's issues basically.

Plotly Express is now part of Plotly.py version 4 and so the plotly_express module now just re-exports the contents of plotly.express

Should've read the docs! 🤦
Thanks for the pointer and sorry for the noise...

No worries!


webpack hot reload

@keybase/react-hackers

LGTM. Does the hot reloading keep the state of the store?

LGTM


Update tarball sha and feedstock for conda-smithy

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@parente this build had some oddities on travis. restarted the job

Started again. Looks like both appveyor and travis had issues downloading miniconda.

Same issue on travis again. Trying the curl command from here, it gets a 301 Moved Permanently with a new location of https://repo.continuum.io/miniconda/Miniconda3-latest-MacOSX-x86_64.sh. So, it's now https.
Looks like the template in conda-smithy already switched to https. Maybe the one here is due for another re-render.

@jakirkham @filipe I assume that this is a known issue?

Err @ocefpaf 😑

Please upgrade conda-smithy and re-render again. Note re-render takes a -c/--commit argument to commit changes.

Should be good to go now. I'll rebase the 0.3.1 PR on master after merge.

lgtm! Thanks @parente

Oh I forgot to tell you guys the response from GitHub (or perhaps I forgot that I told you 😄).
In any event, they said that they do run checks to avoid this sort of issue (checksums changing on a tarball), but sometimes they miss something. In any event, they don't guarantee that the checksum won't ever change.
The reason it can change is content like the tarball and zip provided for each tag are generated on demand. Likely they run git archive and maybe some other stuff. So they are not cached anywhere. As a result, if the process for generating these changes the final result, the checksum itself can change.
So just be aware this can happen. Maybe try running git archive yourself and comparing to their tarballs when this happens to make sure everything is ok.


GH-1 Bootstrap a single folder to improve experience on fresh install

sorry i changed my mind...this needs to go into mdm-core


Add CSV export to the evaluation tool

adds covered_distance to the ground truth relations
the flags write_relation_metrics and relation_metrics_filename control whether and where to write the relations metrics as comma-separated values

@wally-the-cartographer merge

Merge requested by authorized user kdaun. Merge queue now has a length of 1.


Add precision argument to the Range Filter

Breaking Change:

Description:
The range filter is currently losing precision, this patch fixes the issue.
Related issue (if applicable): fixes #25803
Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>
Example entry for configuration.yaml (if applicable):
sensor:
  - platform: random
    name: random
    minimum: 0
    maximum: 10

  - platform: filter
    name: "range_random"
    entity_id: sensor.random
    filters:
      - filter: range
        lower_bound: 5.0
        upper_bound: 10.0

Checklist:

[x] The code change is tested and works locally.
[x] Local tests pass with tox. Your PR cannot be merged unless tests pass
[x] There is no commented out code in this PR.
[x] I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:

[ ] The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
[ ] New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
[ ] Untested files have been added to .coveragerc.

If the code does not interact with devices:

[ ] Tests have been added to verify that the new code works.

Do we need any new tests?

precision is covered by the base filter class, but for consistency I've added precision testing to range_filter also.

Can be merged when build passes.


fix(deps): move @kong/design-tokens from devDeps to deps

Summary
Moves @kong/design-tokens from devDeps to deps.
Files from @kong/design-tokens are required in production. Therefore if/when @kong/kongponents is installed as an indirect dependency, the current configuration (using devDependencies) means @kong/design-tokens is not available, therefore breaking the application.
PR Checklist

[ ] Does not introduce dependencies (It doesn't 'introduce' as such but makes dependencies available that unintentionally weren't previously available)
[x] Functional: all changes do not break existing APIs and if so, bump major version.
[ ] Tests pass: check the output of yarn test. Tests don't run in CI due to what seems like a lack of token, locally theres failures but main also fails. Let me know if you need me to do anything.
[x] Naming: the files and the method and prop variables use the same naming conventions as other Kongponents
[x] Framework style: abides by the essential rules in Vue's style guide
[x] Cleanliness: does not have formatting issues, unused code (e.g., console.logs, debugger), or leftover comments
[x] Docs: includes a technically accurate README, uses JSDOC where appropriate

Most probably superseded by https://github.com/Kong/kongponents/pull/1501

Superseded by https://github.com/Kong/kongponents/pull/1501


[Downgrade] New rule to handle attribute Symfony Command to Symfony

Since Symfony 7.0, downgrade of Rector and any other tool keeps breaking as command name is missing. Symfony 7 handles it by attribute-only, that is not available on PHP 7.4 and bellow.
There should be command that find these attributes and add setName() call to a configure() method.
Before:
https://github.com/symfony/console/blob/7.0/Command/CompleteCommand.php#L32C1-L33C44
After:
public function configure() : void
{
      $this->setName('complete');
}

Should be located in rules/DowngradeSymfony70. Not neccesary to create a set at the moment, as there only single rule.

@samsonasik Could you look into this one? We'll need it for Rector/ECS and all other symfony/console projects

I will try, is underscore removed? should the _complete changed to complete

Not sure, I think it can be removed :+1:

I mean, naming conversion, looking at the doc, it seems kept, so the new code seems should be:
-$this->setName('complete');
+$this->setName('|_complete');

but I probably missing something

@samsonasik  Okay, let's try it. I think the |_ is some internal Symfony convention


Add selection example

This is a composite example adding 3 different mouse selection methods to <regular-table> - row, column and area. Each literate example has a single function to add its respective behavior - addRowMouseSelection(), addColumnMouseSelection() and addAreaMouseSelection(). Finally, I've added a composite example that applies each of the behaviors into a single example seen in the gif attached.
Also includes an example use of area selection in implementing copy/cut, paste using the keyboard with addAreaClipboard().

Thanks for the PR!
Very, very cool feature, great test coverage also.  Let's make sure to add this to the gallery!


Show grass floor masking Satellite floor

Problem

The current default floor of the scene is the satellite view, and that is only suitable for large distances.
Other scenes like worlds, do not have a satellite view and needs a default

Solution
The floor shader needs to be composed of to set of textures, one default grass tile (repeated in the same amount as the terrain), and the satellite view textures. The player position needs to be input to the shader to create circular mask between both textures to show the grass nearby to the player, and the satellite view on afar.
The radious of the mask can be tweaked to determine the best distance.
The mask should be smooth to have a smooth transition between one texture and the other.
In order to get the player position to place the mask properly, the position vector will need to be feed to the shader, either by a global parameter, or with a specific systems that modifies the material properties.
This is just one proposed solution, if there is a better approach go for it

You're going to have to explain this better, because I don't under the masking concept, what exactly are we masking?


Open options page when clicking the toolbar button

When clicking the Refined GitHub button (in Safari, but the source suggests the behavior is the same for Chrome), https://github.com is opened in a new tab. I’d argue this isn’t much easier than typing genter in the URL bar, and that a better use of the buttons would be to open the options page. This would give quick and more discoverable access to this page (the options page is currently somewhat hidden in the Safari preferences) and would make the extension button useful even if it was hidden in Chrome’s menu.

That's how it was before, but I changed to be a GitHub.com button to be more useful. I don’t think entering the options is something that people do regularly enough to keep the button visible, especially in Safari since it doesn't have any "overflow menu" for such buttons and thus it has to stay always, on every window, forever.


Update to Cadence v1.0.0-preview.49

Description
Automatically update to:

onflow/cadence v1.0.0-preview.49
onflow/flow-go-sdk v1.0.0-preview.51
onflow/flow-go 8b4fff2114d4
onflow/flow-emulator v1.0.0-preview.40

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 43.80%. Comparing base (5cd4785) to head (779ec34).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #70      +/-   ##
==========================================
- Coverage   45.28%   43.80%   -1.48%
==========================================
  Files          40       40
  Lines        4699     3367    -1332
==========================================
- Hits         2128     1475     -653
+ Misses       2306     1632     -674
+ Partials      265      260       -5

Flag
Coverage Δ

unittests
43.80% <ø> (-1.48%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Test case not in Test suite?

Running gradlew dist on a fresh installation of the recent release shows 1.638 successful tests. There are four test units  mediaobject.001... mediaobject.004 among them in the defaults group. But in the test-sources there is also mediaobject.005.xml ("This tests adding additional metadata to the media objects").
I cant find a trace for the mediaobject.005 test unit, neither in defaults.html nor in the messages from gradle. The test suits seems to ignore it.
i found that because i wanted to add my of testcase in mediaobject.006which did not work. So i investigated whether others do run, and found 005 which does not.
Greetings, Frank

You can see in the report that it does get run. There is a lot of complexity in the test configuration because we need to test with different environments and different parameters. I've tried to contain all that complexity in the buildSrc Groovy scripts. The mediaobject.005.xml tests run in the a11y configuration that outputs some additional attributes. In TestGenerator.groovy, you'll find a regex list that identifies different tests to be run in different configurations. That's where mediaobject\\.005 is called out.
Good catch, though. And I hope that explanation makes some sense! :-)


NetworkControl: implementation changed to support COMRPC based interfaces

@mhughesacn  Seems the Licnese/cla scan is down again ?


README: rephrase of AUTHORS notice

The AUTHORS notice was a little off, so I made an edit to suggest a rephrase.

Thanks!


Moving namespace validation into serializer

An effort of this PR is to bring more consistency to serializing namespace owners while creating / updating namespace.
error handling in UI: https://github.com/ansible/ansible-hub-ui/pull/99/files#diff-f008b32a6b80ef0cb132f83160fb12d8R70-R79

so far running into Object with name=13123 does not exist. while creating a namespace

https://galaxy.ansible.com/docs/contributing/namespaces.html#galaxy-namespace-limitations


Avoid odr-using static member that will cause undefined references in…

Directly passing mshadow::gpu::kDevMask to CHECK_EQ violates odr-use rule of inplace initialized static data member, which causes undefined reference of gpu::kDevMask during linking time in some compilers.

I have a fix for this problem at #8788


Add tests for sf::Text

Description
Not sure why I didn't write these tests earlier but anyways, here they are! While I was at it I found a nice simplification to make to sf::Text itself. We were writing a lot of default special member functions that we didn't need to write.

SFMLBuildMaster: Build this please.

SFMLBuildMaster: Build this please.

SFMLBuildMaster: Build this please.

🥳


Finder query bug (filter, findWhere, find).

Inconsistent behaviour of finder queries
In some cases, enzyme cannot find elements using the finder queries even if they exists. From my observation, these are for nested components.
I have this query that finds an element inside the ReactWrapper by props value.
finder.findWhere(e => e.prop(prop) === propValue).exists()
Bug
It throw an error Error: Method “props” is only meant to be run on a single node. 0 found instead.
Attempts
I tried to change the implementation by modifying the access for props. It doesn't throw an error anymore but it doesn't work.
finder.findWhere(e => e.props[prop] === propValue).exists()
To see if the query actually works, I've tried to check it manually which works:
wrapper.find(selector).get(<expected_index>).prop(<prop_key>) === <prop_value>
Temporary Resolution
So to accommodate both simple and nested scenarios, I've used the ff:
!!finder.getElements().find(e => e.props[prop] === propValue)
I'm not sure if the problem is in the prop/s function or in the finder.

Can you share the entire component and test code?

@robinelvin Don't use .html() to verify what is "clearly there"; use .debug().
@sAnti09 to be clear, is wrapper created by shallow, or mount?

@ljharb wrapper is created via mount.

@sAnti09 If you change your findWhere callback to console.log(e.debug()), is the output what you expect? What's wrapper.debug()?

I have the same thing: wrapper.html() shows that the component is there (the wait spinner is gone and the text box is present, as expected).
wrapper.debug() shows the opposite: (the wait spinner is still rendered and the text box is not present)
mount is doing something really unexpected for me. It's like the debug one isn't properly updated by setStates that happened, but the html one is?

@grassick .html() is the render API; i wouldn't recommend using it at all. .debug() shows what's really in the tree. You may need a wrapper.update()?

@ljharb  .update() needed indeed. Thanks for the tip! That's far too easy to miss...


test-branch/execute-job/quoted-authorization/828bc09c-5048-4c95-9882-e057a3b0bfcb

PR for testing b6a12ec55b5189c3193c8de39719cf74175e1192

/canonical/self-hosted-runners/run-workflows b6a12ec55b5189c3193c8de39719cf74175e1192


Managed LG/LU/Qna for customized actions

Is your feature request related to a problem? Please describe.
Our managed LG/LU/Qna is built on top of a few assumptions in SDK and not consistently driven by schema. For example, copy\paste\move\undo\redo, or any other side effects can't be performed automatically.
Describe the solution you'd like
Revisit the design and implementation, to make sure

How can we leverage schema to driven managed LG/LU/Qna
Make sure we consistently leverage the same machanism across every places

Describe alternatives you've considered
related topics: schema driven, centralized side effects management.

P2 in R12

Dong please triage if it's still necessary and reassign, thanks!


feat: add color map to image actor

Change color map selection from text name to icon + text name tooltip.
Histogram


can someone gimme 100 goerli in exchange for 2 nfts worth US$20 each?

to this address : 0xF47DdD15d21dD39E2fFBA671913573a0eD7A1cC4
need 1000 only. first 10 gets the nft from vipsland.com
will send the nft to your address
Thx!
this msg is valid til 20th Jan 2023

Goerli is free, you don't need any NFTs.

can you please give me 200 more? i will gift yout back 3 nfts i've created when the nfts are ready. doing last test phase now.
thx in advance.
p.s. : how did u get so many by the way?

@q9f can you please give me 200 more? i will gift yout back 3 nfts i've created when the nfts are ready. doing last test phase now.

I don't want any NFTs, sorry.

p.s. : how did u get so many by the way?

I allocated 90 million to my wallet when I launched the network.

@q9f how can i get 900 more from you? since u have so much.
i have a 250k unique visitor to my blog. if u need publicity over some launches, i can provide 1 mth backlink 250 character ad + permanent backlink of DA 75+ to your website or link in exchange.
appreciate this help in return.
currently getting goerli from https://goerlifaucet.com/
p.s. : my goerli was hacked from github repo a few weeks ago and stolen after i saved them over many months.
now i'm just reduced to begging for 900 more.
do mention how i can repay this to you in future and see if you require anything in future. thx.

Hello, if you have trouble finding goerli testnet you can contact me to buy Telegram: https://t.me/SnowdenResearch Im Selling $Goerli $ETH ! 💰20 Goerli ETH = $5 💰50 Goerli ETH = $12 💳addres Of supply: 0x0b4a7e3e7DBa45509F1948eD388d521f862270B1

@q9f, can u gimme one more 100 goerlis? please?
on either address below?
0xF47DdD15d21dD39E2fFBA671913573a0eD7A1cC4
0x9604Cf64a20c67304488C08db277D7963dCFD0BF
will help you back in future for code contribution, testing time or NFT for US$100.
truly needed. appreciate this. thx in advance!


WFLY-10327 Upgrade Hibernate ORM to 5.3.0.Final and Hibernate Search to 5.10.0.CR1, squashed commits/changes from Sanne, Paul, Gail

https://issues.jboss.org/browse/WFLY-10327

@scottmarlow @pferraro I'm concerned about the removal of the second level cache support for Hibernate 4.3. Mostly for compatibility reasons.

@jamezp we don't support Hibernate 4.3 in EAP7 so I don't think that's a concern we need to act on. It has been long deprecated and people have been aware they should not use it, beyond the normal deprecation cycles.

Perfect that's what I wanted to know @Sanne

@scottmarlow I've also linked https://issues.jboss.org/browse/WFLY-10393 to this PR.

Retest this please


Provide means to allow a FilterField object to be created from a string

Add a static helper method on FilterField that accepts the output of .ToString() and returns a new FilterField:
var ff = FilterField.Parse("Text||value", delimiter: "||");

ff.Text.Should().Be("Text");
ff.Value.Should().Be("value");

Completed as part of 0.12.4


[RFC] Process for Onboarding Without GitHub Accounts: Addressing Maven, Product Manager, and Designer Roles

Problem Statement:
Designing an Onboarding Process: Allowing Maven, product manager, and designer roles to initiate the onboarding process, considering the scenario where some individuals may not have GitHub account.
Should we facilitate these individuals to sign in with GitHub?

@shubhamsigdar1  Comment on RFC:

From myside I think no these people do not write code.
My Solution

We give option on first page to pick roles (Maven, designer, product manager, developer).

Question- when we create document for these user(i.e. Maven, designer, product manager)  in userModel collection

If user Choose role maven, designer and product manager  reveals specific fields (First Name, Last Name, Username, Discord ID).

If user choose role developer then we give option to sign-in-with-github

Question- Can user choose more than 1 role??
My solution-
User can be designer and developer both or can be product manager and developer - If user choose role include developer also then we take all the information that individual user with role developer file.
Exception for maven
if user select more than one roles include maven roles  then we deselect others role for maven.

For the developers, do we store the info in userModel at a later stage of onboarding?
@shubhamsigdar1

For the developers, do we store the info in userModel at a later stage of onboarding? @shubhamsigdar1

Basic information username, firstname, lastname we store in userModel later


ElementUI css-loader error

I have met the same error as posted in this issue.
error  in ./node_modules/element-ui/lib/theme-chalk/index.css
Module build failed (from ./node_modules/css-loader/index.js):
Unknown word (5:1)

  3 | // load the styles
  4 | var content = require("!!../../../css-loader/index.js??ref--13-1!./index.css");
> 5 | if(typeof content === 'string') content = [[module.id, content, '']];
    | ^
  6 | if(content.locals) module.exports = content.locals;
  7 | // add the styles to the DOM
  8 | var add = require("!../../../vue-style-loader/lib/addStylesClient.js").default

 @ ./node_modules/element-ui/lib/theme-chalk/index.css 4:14-152 14:3-18:5 15:22-160
 @ ./src/main.ts
 @ multi ./build/client-polyfill.js ./src/main.ts

One solution is to remove the css-loader & style-loader. But it seems that we cannot remove css-loader direcly.

Could you attach the steps to reproduce this error or a minimal
reproducible repo?
唐谈<EMAIL_ADDRESS>周二下午7:21写道：

I have met the same error as posted in this issue
https://github.com/ElemeFE/element/issues/2541.
error  in ./node_modules/element-ui/lib/theme-chalk/index.css
Module build failed (from ./node_modules/css-loader/index.js):
Unknown word (5:1)
3 | // load the styles
4 | var content = require("!!../../../css-loader/index.js??ref--13-1!./index.css");

5 | if(typeof content === 'string') content = [[module.id, content, '']];
| ^
6 | if(content.locals) module.exports = content.locals;
7 | // add the styles to the DOM
8 | var add = require("!../../../vue-style-loader/lib/addStylesClient.js").default

@ ./node_modules/element-ui/lib/theme-chalk/index.css 4:14-152 14:3-18:5 15:22-160
@ ./src/main.ts
@ multi ./build/client-polyfill.js ./src/main.ts
One solution is to remove the css-loader & style-loader. But it seems that
we cannot remove css-loader direcly.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/w1ndy/vue-webpack-ts-template/issues/3, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AAnzJKBA38wDLc281PQDWd8dgcYgO_E6ks5uQrLVgaJpZM4V8QKj
.

I tried many methods, then I decide to link the css file to the index.html using CDN.
  <head>
    <meta charset="utf-8">
    <meta name="viewport" content="width=device-width,initial-scale=1.0">
    <title>vue-webpack-ts-template</title>
    <link rel="stylesheet" href="https://unpkg.com/element-ui/lib/theme-chalk/index.css">
  </head>

This is caused by the duplicate css loaders due to the incorrect merging of webpack configurations. Fixed in  da04db2. Meanwhile I recommend importing css files inside


Ignore empty directories on Java sourcepath compile option

The sourcepath compile option is missing the @IgnoreEmptyDirectories annotation to ignore empty directories. This improves cacheability when empty folders are included in a dirty local environment.
Expected Behavior
Empty directories in the sourcepath inputs must be ignored for cache key computation.
Current Behavior
Empty directories in the sourcepath inputs are taken into account for cache key computation.
Context
We get build cache misses on compile tasks when empty directories are existent in the defined sourcepath.
Steps to Reproduce
See the linked pull request which has an integration test.

Fixed via #18223.


Format markdown

Produced via: prettier --write $(find -name '*.md' | grep -v vendor)

/ok-to-test

/lgtm

/hold
until the conversation from #291 is resolved


[MonorepoBuilder] [Questions] Is it possible to have 2 package with different versions of a dependecy

Hi guys,
First, you are doing an amazing job!
I'm exploring now all the Monorepo approach in PHP, but, there is not a lot of documentation about it and also not very much specifically on Simplify.. I assume my question is very basic but still couldn't find a specific answer
Is it possible to have 2 packages in the same mono-repo with different versions of a dependency?
for example:
packageA
   composer.json -- "symfony/http-kernel": "^5.0"
packageB
   composer.json -- "symfony/http-kernel": "^4.0"

The reason that I'm asking it is that after trying to run
./vendor/bin/monorepo-builder merge
the results are:
======================================================

 --------------------------------------- ---------
  File                                    Version
 --------------------------------------- ---------
  packages/first-package/composer.json    ^4.0
  packages/second-package/composer.json   ^5.0
 --------------------------------------- ---------

 [ERROR] Found conflicting package versions, fix them first.

In ConflictingVersionsGuard.php line 51:

  Fix conflicting package version first

merge [-c|--config CONFIG]

Hi,
thank you :)
The question is right. The idea behind monorepo is to unite the version into one.
Basically the root composer.json is the king. The version that is there is in every package.
Would you like to know more about monorepo? I wrote a short post series that will give you deep insights:
https://tomasvotruba.com/cluster/monorepo-from-zero-to-hero/

Hi,
thank you :)
The question is right. The idea behind monorepo is to unite the version into one.
Basically the root composer.json is the king. The version that is there is in every package.
Would you like to know more about monorepo? I wrote a short post series that will give you deep insights:
https://tomasvotruba.com/cluster/monorepo-from-zero-to-hero/

Thanks for the answer. now it is clear to me that monorepo-builder is designed to lock the dependencies packages in the same version.
Theoretical discussion (I hope that it is ok to have a discussion like that here):
Let's say that we have a monorepo with 30 packages synced with the same versions of dependencies. Now we want to add a new package dependency to a package, but then we notice that the dependency package conflicts with an existing version of a dependency used by other 20 packages.
Please correct me if I wrong, in that case, in order to add that package dependency, we will have to resolve all the dependency conflicts in all the other 20 packages, although, they were not changed?
Thanks,
Niv

Thanks for the answer. now it is clear to me that monorepo-builder is designed to lock the dependencies packages in the same version.
Theoretical discussion (I hope that it is ok to have a discussion like that here):
Let's say that we have a monorepo with 30 packages synced with the same versions of dependencies. Now we want to add a new package dependency to a package, but then we notice that the dependency package conflicts with an existing version of a dependency used by other 20 packages.
Please correct me if I wrong, in that case, in order to add that package dependency, we will have to resolve all the dependency conflicts in all the other 20 packages, although, they were not changed?
Thanks,
Niv

Sure, I love discussions and moreover exploring questions :)

we will have to resolve all the dependency conflicts in all the other 20 packages, although, they were not changed?

Yes, that's the way to go :+1:

Sure, I love discussions and moreover exploring questions :)

we will have to resolve all the dependency conflicts in all the other 20 packages, although, they were not changed?

Yes, that's the way to go :+1:


[PAGOPA-896] Interfaces for IBAN CRUD new APIs

With this PR, some new feature were added in order to permits the handling of new CRUD operation on IBAN instances. In particular, new JPA entities were added for permits the mapping with the newly generated tables on NDP database related to the IBAN object and its relation with creditor insitution and ICA binary file. Also, a set of Spring Data Repositories were added in order to permits to perform manipulation on entities by queries.
List of Changes

Added new JPA entities for mapping new DB tables
Added new JPA repositories for permits the entity handling

Motivation and Context
These changes are required in order to define a new set of API for the CRUD operation on IBAN objects.
How Has This Been Tested?
Tested in local environment with H2 database.
Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as
expected)

Checklist:

[ ] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.

update_code


fix issues #53, #66: celery 4.0+ support

This PR fixes an import problem introduced in celery 4.0.
There's currently a problem with tests. It seams that it takes more than 0.25 seconds for the task to finish in the AsyncTaskTests. Am I missing a kombu.Producer parameter?

@kardaj thanks for the pull request. Are the tests failing only with celery 4.0+?

@mher thank you for the quick answer. Yes, only with celery 4.0+.

@kardaj merging your pull request, will try to fix the tests later. Please add your name to the list of contributors.


Cleaning up

Also, any suggestions on how to better organize the repo, specially with respect to third party code, is greatly appreciated.

I gotcha. =) :+1:

https://github.com/saabi/vminpoly/pull/39


Provide a container image for jwt-cli

Ideally, a scratch image, so no worries of updating the base operating system. Expected usage: Tekton tasks.
Here's a sample Dockerfile I created for my own purposes, however I believe it can be organized better into the existing build process instead of building stuff inside a multi-stage Dockerfile:
FROM docker.io/rust:1-alpine as build
ARG JWT_CLI_VERSION
ARG JWT_CLI_DOWNLOAD_BASE=https://github.com/mike-engel/jwt-cli/archive/refs/tags
RUN set -eux \
 && wget -nd ${JWT_CLI_DOWNLOAD_BASE}/${JWT_CLI_VERSION}.tar.gz \
 && tar xf ${JWT_CLI_VERSION}.tar.gz
WORKDIR /jwt-cli-${JWT_CLI_VERSION}
RUN set -eux \
 && apk add --no-cache musl-dev \
 && rustup target add x86_64-unknown-linux-musl \
 && cargo build --release --target=x86_64-unknown-linux-musl \
 && cp ./target/x86_64-unknown-linux-musl/release/jwt /

FROM scratch
COPY --from=build /jwt /
ENTRYPOINT ["/jwt"]
CMD ["-h"]

Hey @lewandom, thanks! This is unfortunately something I'm not really interested in creating/maintaining long-term. If you'd like to create and own a dockerfile in this repository, I can think about publishing it to docker hub, otherwise I'll probably leave this to the community


Improve README

[ ] Make partial names URLs to the partials
[x] Make list of partials a table
[ ] Show an example of how to integrate a partial in the usage section
[ ] Elaborate on git submodule instructions to make it easier for folks new to submodules

Happy to take other suggestions too!

It'd be neat if the use_bootstrap.html was  instead like use_bootstrap4.html
i.e. the names end up looking like
[`use_bootstrap4.html`](layouts/partials/use_bootstrap4.html)

I think you should tick the first checkbox.

Thanks for the bump on it  👍


Writing CDATA failed on non-array properties

Builder({cdata:true}) introduced in v0.4.5 does not work properly on a sub property that is not Array.
Test code:
var xml2js = require('xml2js');

console.log(new xml2js.Builder({
  cdata: true
}).buildObject({
  'foo': {
    'bar': 'baz & qux'
  }
}));

Outputs:
<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<foo>
   <bar>baz & qux</bar>
</foo>

Should be:
<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<foo>
   <bar><![CDATA[baz & qux]]></bar>
</foo>

I think calling wrapCDATA at Case #5 is also required for writing CDATA properly.

when Builder({ headless: true, cdata: true }) with headless and cdata to true,then writing CDATA does't work


Avoid Python U256 decoder repetition?

As seen in https://github.com/iotaledger/iota-sdk/pull/1552, things like
    amount: int = field(metadata=config(
        encoder=hex,
        decoder=lambda v: int(v, 16)
    ))

should probably be factored.
Maybe something like
def HexField(**args):
    return field(metadata=config(
        encoder=hex,
        decoder=lambda v: int(v, 16),
        **args,
    ))

Closed by https://github.com/iotaledger/iota-sdk/pull/1557


Fixed expired link to online writing course

Link to "massively open online course" was old and expired
Summary of changes

Fixes old link to the online technical writing course.
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] I have read the CONTRIBUTING document.
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

Associated Issues and PRs

Issue: #166

Associated Developers

Dev: @

I think this has already been merged? What's going on here?

Gavin, did you merge your own PR? Why are no changes appearing...

It looks like you made a change and then made the exact opposite change. So, this PR contains no actual change. (See "files changed" tab). Your first commit changed the URL.

No big deal @Dayvis7 . This is how we learn everything! Making little unimportant mistakes is always good.
Just in case, first, make sure your remotes are set up properly. The command git remote -v should show you that upstream points to arfc and origin points to Dayvis7. If not, or if you're unsure, just do this:
git remote rm upstream
git remote rm origin
git remote add upstream git@github.com:arfc/arfc.github.io
git remote add origin git@github.com:Dayvis7/arfc.github.io

Then, let's make sure everything is clean. If it is, then git status should tell you your working directory is clean and you can skip ahead a bit. If it isn't, there are a few options. One option is to just blow it all away. The other is to stash your changes. Let's find out...
git checkout source
git status
git diff upstream source

Learn what you can from the git diff upstream source. If there is a difference between your source branch and the upstream source branch, then you've gotta blow it away. If it's fine, then do the following:
git stash
git checkout source
git pull upstream source

Now, git status should show things are clean and you can proceed with making your change, but you should do it in a branch that isn't the source branch.
git checkout -b issue166

Now, make your change.
git commit -am "...... some kind of message goes here.... "
git push origin issue166

Now, you can make a new PR (and close this one). When it's merged, there's some magic. Because your branch was called issue166, then when it's merged that issue should close automagically.

Should I make the change directly on GitHub then commit/push through git? I'm not sure how to change it just through git alone

Don't make changes directly in github if you can avoid it (this, I see now, may be why it screwed up).
A text editor is what you need (e.g. Atom, vim, emacs). Maybe you can ask on the ARFC slack for a quick zoom with a grad student who can walk you through it.

(maybe read through the effective computation in physics book for a review, also? it seems like maybe you need a little guidance on using git from the command line. )

I have a text editor, I just didn't know the best way to edit the file and then commit the changes. If it's just going on my computer and opening the text file I have saved, editing it and saving then pushing through the working branch, I should be able to do that

right.
On Fri, May 22, 2020 at 1:22 PM Gavin<EMAIL_ADDRESS>wrote:

I have a text editor, I just didn't know the best way to edit the file and
then commit the changes. If it's just going on my computer and opening the
text file I have saved, editing it and saving then pushing through the
working branch, I should be able to do that
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/arfc/arfc.github.io/pull/167#issuecomment-632839264,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AADAFK4VIQRMFGGUVD5Q323RS27FLANCNFSM4KZKWP4A
.

--
http://katyhuff.github.com


Conflict ignored when changing file outside of Atom when it has unsaved changes in Atom.

I have a clean local file foo open in Atom, and I modify the file outside Atom. Atom reloads the file, which is fine. But if I have unsaved changes in file foo in Atom, and foo gets modified externally, Atom does not tell me about external changes, even when I try to save the file.

@bolinfest just to confirm, was this something that previously behaved differently and has regressed? Or has this always been this way?
I just want to make sure nothing broke with the recent pathwatcher upgrade regarding this.

AFAIK it has always been like this. I just always assumed it was a known issue that would get fixed eventually.

Yeah, I believe that though TextEditor has an onDidConflict method, that method is not used anywhere in Atom core.


Cannot find type for ctor #38116ee0

Hi I'm getting this exception
Cannot find type for ctor #38116ee0

also, can't understand this on line 83 on TL.cs
if (ctorNb == Layer.GZipedCtor) return reader.ReadTLGzipped();

if reader.ReadTLGzipped() is defined as
object ReadTLGzipped(this BinaryReader reader, Type type)

and of course compiler ask me to specify a type, I made it run using the previous
(IObject)reader.ReadTLGzipped(typeof(IObject));

but I highly doubt about it.
Thank you

Duplicate of #191

return reader.ReadTLGzipped();

You're right, I will fix that soon. That line wasn't used anymore since #if MTPG is active
(I recommend using WTelegramClient from Nuget package rather than from sources)

Duplicate of #191


cannot add network services: listen tcp <IP_ADDRESS>:2222: bind: An attempt was made to access a socket in a way forbidden by its access permissions.

As per the title; I'm getting a weird error when running wsl-vpnkit on a fresh deployment of Ubuntu-22.04 and wsl-vpnkit v0.4.1
I apologise in advance for the wall of text; i'm trying to be concise in explaining what i'm seeing and what i've tried so far...
I've moved the wsl-gvproxy.exe out to /mnt/c/Users/myuser/wsl-gvproxy.exe to avoid Exec errors, and am mainly trying to use the script located within my own deployment (in /opt/wsl-vpnkit), running via Systemd on boot.
All that aside; trying to run it without systemd results in the same error.
before running, i've also run:

sudo ip tuntap del wsltap mode tap
```sudo kill `ps -ef | grep gv | awk '{print$2}'````
(powershell) kill -Name wsl-gvproxy

$ sudo VMEXEC_PATH=/opt/wsl-vpnkit/wsl-vm GVPROXY_PATH=/mnt/c/Users/myuser/wsl-gvproxy.exe DEBUG=1 /opt/wsl-vpnkit/wsl-vpnkit 2>&1 | tee output.log
+ VPNKIT_GATEWAY_IP=<IP_ADDRESS>
+ VPNKIT_HOST_IP=<IP_ADDRESS>
+ VPNKIT_LOCAL_IP=<IP_ADDRESS>
+ TAP_MAC_ADDR=5a:94:ef:e4:0c:ee
+ VMEXEC_PATH=/opt/wsl-vpnkit/wsl-vm
+ GVPROXY_PATH=/mnt/c/Users/myuser/wsl-gvproxy.exe
+ TAP_NAME=wsltap
+ CHECK_HOST=google.com
+ CHECK_DNS=<IP_ADDRESS>
+ DEBUG=1
+ set +x
+ WSL2_TAP_NAME=eth0
+ WSL2_GATEWAY_IP=<IP_ADDRESS>
+ [ 1 -eq 0 ]
+ command -v iptables-legacy
+ alias iptables=iptables-legacy
+ id -u
+ [ 0 -ne 0 ]
+ [ ! -f /opt/wsl-vpnkit/wsl-vm ]
+ [ ! -f /mnt/c/Users/myuser/wsl-gvproxy.exe ]
+ cat /mnt/wsl/resolv.conf
+ grep automatically generated by WSL
+ [ 0 -eq 1 ]
+ /mnt/c/Users/myuser/wsl-gvproxy.exe -help
+ [ 0 -eq 1 ]
+ trap close exit
+ trap exit int term
+ cleanup
+ iptables_set D
+ wsl2tap_up
+ ip link set dev wsltap down
+ ip tuntap del wsltap mode tap
+ ip route add default via <IP_ADDRESS> dev eth0
+ wsl2tap_down
+ ip route del default
+ ip tuntap add wsltap mode tap
+ ip link set dev wsltap address 5a:94:ef:e4:0c:ee
+ ip link set dev wsltap up
+ ip addr add <IP_ADDRESS>/<IP_ADDRESS> dev wsltap
+ ip route add default via <IP_ADDRESS> dev wsltap
+ run
+ echo starting vm and gvproxy...
starting vm and gvproxy...
+ sleep 1
+ /opt/wsl-vpnkit/wsl-vm -url=stdio:/mnt/c/Users/myuser/wsl-gvproxy.exe?listen-stdio=accept&debug=1 -iface=wsltap -stop-if-exist= -preexisting=1 -debug=1
time="2023-08-08T16:31:02+01:00" level=info msg="waiting for packets..."
time="2023-08-08T16:31:02+01:00" level=info msg="PACKET: 90 bytes, truncated\n- Layer 1 (14 bytes) = Ethernet\t{Contents=[..14..] Payload=[..76..] SrcMAC=5a:94:ef:e4:0c:ee DstMAC=33:33:00:00:00:16 EthernetType=IPv6 Length=0}\n- Layer 2 (40 bytes) = IPv6\t{Contents=[..40..] Payload=[..28..] Version=6 TrafficClass=0 FlowLabel=0 Length=36 NextHeader=IPv6HopByHop HopLimit=1 SrcIP=:: DstIP=ff02::16 HopByHop={ Contents=[..8..] Payload=[..28..] NextHeader=ICMPv6 HeaderLength=0 ActualLength=8 Options=[{OptionType=5 OptionLength=2 ActualLength=4 OptionData=[0, 0] OptionAlignment=[0 0]}, {OptionType=1 OptionLength=0 ActualLength=2 OptionData=[] OptionAlignment=[0 0]}]}}\n- Layer 3 (08 bytes) = IPv6HopByHop\t{Contents=[..8..] Payload=[..28..] NextHeader=ICMPv6 HeaderLength=0 ActualLength=8 Options=[{OptionType=5 OptionLength=2 ActualLength=4 OptionData=[0, 0] OptionAlignment=[0 0]}, {OptionType=1 OptionLength=0 ActualLength=2 OptionData=[] OptionAlignment=[0 0]}]}\n- Layer 4 (04 bytes) = ICMPv6\t{Contents=[143, 0, 97, 184] Payload=[..24..] TypeCode=143(0) Checksum=25016 TypeBytes=[]}\n- Layer 5 (00 bytes) = MLDv2MulticastListenerReport\tNumber of Mcast Addr Records: 1 (actual 1), Multicast Address Records: [{RecordType:CHANGE_TO_EXCLUDE_MODE AuxDataLen:0 N:0 MulticastAddress:ff02::1:ffe4:cee SourceAddresses:[] AuxiliaryData:[]}]\n"
time="2023-08-08T16:31:02+01:00" level=error msg="cannot add network services: listen tcp <IP_ADDRESS>:2222: bind: An attempt was made to access a socket in a way forbidden by its access permissions."
time="2023-08-08T16:31:02+01:00" level=error msg="cannot read size from socket: EOF"
+ echo started vm and gvproxy
started vm and gvproxy
+ iptables_set A
+ iptables-legacy -t nat -A PREROUTING -d <IP_ADDRESS>/32 -p udp -m udp --dport 53 -j DNAT --to-destination <IP_ADDRESS>:53
+ iptables-legacy -t nat -A PREROUTING -d <IP_ADDRESS>/32 -p tcp -m tcp --dport 53 -j DNAT --to-destination <IP_ADDRESS>:53
+ iptables-legacy -t nat -A PREROUTING -d <IP_ADDRESS>/32 -j DNAT --to-destination <IP_ADDRESS>
+ iptables-legacy -t nat -A OUTPUT -d <IP_ADDRESS>/32 -p udp -m udp --dport 53 -j DNAT --to-destination <IP_ADDRESS>:53
+ iptables-legacy -t nat -A OUTPUT -d <IP_ADDRESS>/32 -p tcp -m tcp --dport 53 -j DNAT --to-destination <IP_ADDRESS>:53
+ iptables-legacy -t nat -A OUTPUT -d <IP_ADDRESS>/32 -j DNAT --to-destination <IP_ADDRESS>
+ iptables-legacy -t nat -A POSTROUTING -o wsltap -j MASQUERADE
+ check
+ check_ping 4 WSL 2 gateway / Windows host <IP_ADDRESS>
+ ping -4 -c 1 <IP_ADDRESS>
time="2023-08-08T16:31:03+01:00" level=info msg="waiting for packets..."
time="2023-08-08T16:31:03+01:00" level=error msg="cannot add network services: listen tcp <IP_ADDRESS>:2222: bind: An attempt was made to access a socket in a way forbidden by its access permissions."
time="2023-08-08T16:31:04+01:00" level=error msg="cannot read size from socket: EOF"
time="2023-08-08T16:31:05+01:00" level=info msg="waiting for packets..."
time="2023-08-08T16:31:05+01:00" level=error msg="cannot add network services: listen tcp <IP_ADDRESS>:2222: bind: An attempt was made to access a socket in a way forbidden by its access permissions."
time="2023-08-08T16:31:05+01:00" level=error msg="cannot read size from socket: EOF"
<repeats>

I don't see anywhere in the code that refers to port 2222, but also nor do I see any processes running on port 2222 on Windows or WSL2.
netsh interface ipv4 show excludedportrange protocol=tcp does show that 2222 is in an ExcludedPortRange, but I don't see the relevance.
I am not connected to any VPN when running these tests, and have rebooted etc too. I don't see any useful info/errors in Event Viewer either.
Any ideas where to look next? Or where this port 2222 connection comes from or can be configured to use a different port?
WSL ifconfig:
$ ifconfig
docker0: flags=4099<UP,BROADCAST,MULTICAST>  mtu 1500
        inet <IP_ADDRESS>  netmask <IP_ADDRESS>  broadcast <IP_ADDRESS>
        ether 02:42:5e:63:f8:d1  txqueuelen 0  (Ethernet)
        RX packets 0  bytes 0 (0.0 B)
        RX errors 0  dropped 0  overruns 0  frame 0
        TX packets 0  bytes 0 (0.0 B)
        TX errors 0  dropped 0 overruns 0  carrier 0  collisions 0

eth0: flags=4163<UP,BROADCAST,RUNNING,MULTICAST>  mtu 1500
        inet <IP_ADDRESS>  netmask <IP_ADDRESS>  broadcast <IP_ADDRESS>
        inet6 fe80::215:5dff:fee7:25c  prefixlen 64  scopeid 0x20<link>
        ether 00:15:5d:e7:02:5c  txqueuelen 1000  (Ethernet)
        RX packets 2097  bytes 630586 (630.5 KB)
        RX errors 0  dropped 0  overruns 0  frame 0
        TX packets 160  bytes 11453 (11.4 KB)
        TX errors 0  dropped 0 overruns 0  carrier 0  collisions 0

lo: flags=73<UP,LOOPBACK,RUNNING>  mtu 65536
        inet <IP_ADDRESS>  netmask <IP_ADDRESS>
        inet6 ::1  prefixlen 128  scopeid 0x10<host>
        loop  txqueuelen 1000  (Local Loopback)
        RX packets 0  bytes 0 (0.0 B)
        RX errors 0  dropped 0  overruns 0  frame 0
        TX packets 0  bytes 0 (0.0 B)
        TX errors 0  dropped 0 overruns 0  carrier 0  collisions 0

Windows ipconfig (WSL item):
Ethernet adapter vEthernet (WSL):

   Connection-specific DNS Suffix  .  :

WSL Routes:
$ ip route show
<IP_ADDRESS>/16 dev docker0 proto kernel scope link src <IP_ADDRESS> linkdown
<IP_ADDRESS>/20 dev eth0 proto kernel scope link src <IP_ADDRESS>

My Local LAN network is <IP_ADDRESS>/16 -- could this create a conflict with the wsl-vpnkit gateway/host/local IPs in any way?

I've got the same error today. Any update on this ?

Same problem here...

Same issue. Everything was working fine but after Windows 10 update (KB5030211 and KB5030180) it stopped working with the same error message as above:

No news on this ?

I had the same issue, because a VM uses port 2222 in my PC. Looks like gvproxy.exe tries to listen on port 2222 by default, but it can be overridden by parameter -ssh-port. To make it work I changed /app/wsl-vpnkit script's line 47:
        -url="stdio:$GVPROXY_PATH?listen-stdio=accept&debug=$DEBUG" \
to
        -url="stdio:$GVPROXY_PATH?listen-stdio=accept&ssh-port=22220&debug=$DEBUG" \
Of couse, you can use any other free port number.

Don't know why it works, but this fixes mine:
In an admin Powershell/ Command Prompt:
net stop hns
net start hns

Inspired by https://stackoverflow.com/q/10461257

I had the same issue, because a VM uses port 2222 in my PC. Looks like gvproxy.exe tries to listen on port 2222 by default, but it can be overridden by parameter -ssh-port. To make it work I changed /app/wsl-vpnkit script's line 47:  -url="stdio:$GVPROXY_PATH?listen-stdio=accept&debug=$DEBUG" \ to  -url="stdio:$GVPROXY_PATH?listen-stdio=accept&ssh-port=22220&debug=$DEBUG" \ Of couse, you can use any other free port number.

Thanks, this worked.


Steering bug during turns

Describe the bug
during a right turn on my commute on 2/22 5:10-ish pm with open pilot engaged, the car's steering wheel flipped from about 75 degrees to 105 degrees and locked there.  The screen flashed orange to take control.
I disengaged OP (I think, it happened fast) reset the driving line until the lane turned straight and re-engaged cruise.  I initially thought it was a one off issue until someone described the exact same problem on the comma subreddit this morning.
https://connect.comma.ai/587c6380f108936f/1645567568051/1645569124154
17:13 or so
Bonus fun : watch me dodge potholes at 17:08
What hardware does this issue affect?
comma two
Provide a route where the issue occurs
https://connect.comma.ai/587c6380f108936f/1645567568051/1645569124154
openpilot version
08.13
Additional info
No response

It looks like from around 40 degrees you started touching the wheel to override and take the turn

This is also unrelated to the issue reported on Reddit with the Subaru Ascent.

Can you verify which segment this occurred? The timestamps seem to be off in connect.

The take control alert was caused by an internal angle limit in your car, as Hyundai limits you to ~90 degrees and won't steer past that.


docs: add search extension

Commit Message:
Search extension would optimize search logic.
Fix #15934
Additional Description:
Risk Level: low

hi @daixiang0 you will need to fix DCO
also, its conflicting on docs/conf.py - do you want to rebase to master

Sorry for mistakes, now they pass.

no problem. When the docs are rendered we can take a look...

Why no readthedocs build/review here? It would be helpful for review.

its not actually hosted on readthedocs - but we do have pre-submit rendering.
once they are built ill post the link

Thanks for quick input.

How can I add python dependence with format in envoy?

probs the easiest is to use pip-compile to automatically generate the hashes
currently most of the requirements files have been created by hand (ie not using pip-compile and adding hashes manually) - altho in this case i have just added  a PR which does use pip-compile for this requirements file specifically
to add your dependency...

get the current version from pypi
add the dependency in the reqs file like mydep==X.Y.Z
install pip-compile - eg with pip
run pip-compile --generate-hashes docs/requirements.txt

@daixiang0 this is failing as you didnt actually add the dependency before running pip-compile
doing a bit of further research on this i think the pypi package you are trying to add is this one https://github.com/readthedocs/readthedocs-sphinx-search
its not clear to me whether this will work outside of readthedocs - which we are not hosted by
it may be that it works with the rtd theme - which we do use - but it would then tie us to that theme
the other issue im thinking is that this module doesnt appear to support multicore sphinx/rst builds - which we dont currently use but would like to
try adding the correct package to requirements and if it works we can figure out whether the pros outweigh the cons

I install at local by pip while I can not add it by pip-compile :(

follow the steps here https://github.com/envoyproxy/envoy/pull/16093#issuecomment-823900326

I get key issue about why I failed to add deps, there is no requirement_in and pip-compile can not add deps with generated requirement
files. refer to doc

you dont need requirements,in etc
try this:
$ echo readthedocs-sphinx-search > myrequirements.txt
$ pip-compile --generate-hashes myrequirements.txt

and then check myrequirements,txt

Seems my pip-compile version may be higher than your:
(venv) root:[docs]$  pip-compile --generate-hashes myrequirements.txt
#
# This file is autogenerated by pip-compile
# To update, run:
#
#    pip-compile --generate-hashes myrequirements.txt
#
readthedocs-sphinx-search==0.1.0 \
    --hash=sha256:5c0a90068c9c0ca639aa3a1c14a7fe8587b0332f2349bc3fd86b968ca82db238 \
    --hash=sha256:7ed45d83b11af9681d5439529c7fbd4289c5be3f9ac4688436e28cb669da87a2
    # via -r myrequirements.txt

It would add some comment. Anyway, I add hash by hand.

version may be higher than your:

its the same - i just copied the commands

I add hash by hand.

great. lets see if the docs build

docs are rendered here https://storage.googleapis.com/envoy-pr/16093/docs/index.html

This extension does not work :(

you need to enable it in conf.py
also - once you have reviewer/s please dont force push

another issue i think we will have if we enable this https://github.com/readthedocs/readthedocs-sphinx-search/issues/82

Ohh, I miss it, let's try again.

yep - it turns out it does need to be on rtd for this extension to work (at least out of the box)
from my browser console
[INFO] Docs are not being served on Read the Docs, readthedocs-sphinx-search will not work.

@daixiang0 my feeling is close this PR
if you are willing to work on the original bug #15934 - lets look at tweaking the search config - or at a push adding a SearchAdapter

Let's close.


adding appservice-rest

Codecov Report

Merging #183 (0dd1a59) into master (8f1b740) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head 0dd1a59 differs from pull request most recent head 92386f0.  Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


fix(command): help no longer triggers error text for missing env vars

Test command (from #392):
import { Command } from "./command/mod.ts";

await new Command()
  .name("sample-cli")
  .version("0.0.1")
  .env("FOO=<value:string>", "FOO", { required: true })
  .parse(Deno.args);

Before
  Usage:   sample-cli
  Version: 0.0.1

  Options:

    -h, --help     - Show this help.
    -V, --version  - Show the version number for this program.

  Environment variables:

    FOO  <value>  - FOO  (required)

  error: Missing required environment variable "FOO".

Exit code: 1
After
 Usage:   sample-cli
  Version: 0.0.1

  Options:

    -h, --help     - Show this help.
    -V, --version  - Show the version number for this program.

  Environment variables:

    FOO  <value>  - FOO  (required)

Exit code: 0
Rationale
The default --help option is treated like any other standalone option, which means that environment vars, flags, and arguments are all processed and validated before execution. A missing environment variable throws an error, which triggers the help text and causes a non-zero exit code.
This PR adds an option to parseEnvVars to ignore missing required env vars, instead of immediately throwing an error. This is done when the parsed input indicates that the user is opening help.
Fixes #392

after thinking i reverted the change to skip parsing env vars. i think it should be fine to just skip throwing the required env var error.

Sorry I missed this earlier! 😅
Originally I thought of splitting parseEnvVars into two functions: One for reading the env vars without judgement (if any env vars were missing it would not throw an error), and one for validating that the requirements were met. I thought it would simplify the flow, but as I got into it, I realized I that the "validate" function would actually need to be just as complex as the parse function to make sure all the bases were covered.
Anyway, in the future, if you want to make changes to any of my PRs, go right ahead. I'm not fussy 😄


watch-builds: support json output

This output would be used by zabbix-metrics script as its simplier and
the output doesn't get cached

LGTM, merged!


MissingPluginException(No implementation found for method listen on channel receive_sharing_intent/events-media)

I also have the same problem have you resolved it yet?

I also have the same problem have you resolved it yet?

I Found the issue in my pubspec.yaml file I had a package which was wrong implemented when I removed it run with no problem

I Found the issue in my pubspec.yaml file I had a package which was wrong implemented when I removed it run with no problem

Still the same

Still the same

Still the same

Same Problem Still now

Still the same

Same Problem Still now

Check for conflicts in your pubspec.yaml packages


Remove order query from the collection

It increased the cost of the query significantly causing possible timeouts. It does not look like it is needed anymore to force use of index to search for records, possibly this is due to AR internals changes.
Removing the order by part of the query and checking the query plan on one of our apps reduces the cost from 15988663.92..16812181.97 to 4060.71..827578.75

@JureCindro Hmm, interesting, as the intention was indeed to optimise the query...

@JureCindro Hmm, interesting, as the intention was indeed to optimise the query...

Indeed. I still need to check the behaviour when using tenant_id. Maybe it has something to do with the order of the composite keys.
Will attempt to find models with tenant and timestamp defined, where they are:

both separate index
composite index [tenant_id, timestamp]
composite index [timestamp, tenant_id]

If the query plan's cost does not increase in all of above examples then this is probably safe to remove for rails >= 6.1. Otherwise we can conditionally order if both timestamp and tenant ids are present in tartarus model config.

@Azdaroth ,
could you please review/merge/release this change?
So, we can get the updated gem avail on our apps?
thank you

@LeoMo42 done, new version released


User input via keyboard

Enabled User Input via Keyboard feature. User will first have to press a number on keyboard and then place it in the desired location on the grid by clicking the box.

Deselect button has been added to deselect a number selected either from the numbers grid or using keyboard.

@Swethaa-Ravi I also found that the points you mentioned aren't working.
The number deselect button and one can't select a number from the keyboard.
Also update your branch.


Add Netmarble Launcher

SteamDB app page links to a few games using this
Brief explanation of the change
Find MarbleStation.exe, the executable for Netmarble Launcher.

After running changed rules in this pull request (this bot only tests rules.ini changes):
Changed technologies: Launcher.Netmarble
These apps now match: (3)<PHONE_NUMBER>20 238110
Please confirm that all these changed apps are correct.


Kinetic Swiftstack Controller doc bug

The Hardware Requirements page of the docs https://kinetic.swiftstack.com/docs/admin/hardware.html has not been updated to reflect a Kinetic-Swift deployment.

This issue is related to the SwiftStack product - not the kinetic-swift project.  I'm not sure where to capture this issue for now - especially since we're still trying to learn what the hardware recommendations should be for setting up kinetic-swift.

ok, I'm calling it - file issues with kinetic.swiftstack.com through zendesk.


Show complete dates

Fixes #1316
Changes: As below.
Screenshots for the change:
BEFORE:

AFTER:

I have checked, and it works on mobiles and smaller screens too. Here is the test link: https://mahikaw.github.io/testlink2/
@mariobehling @aayusharora @Princu7  Please review.

Hey. It is unrelated to this but a small problem has occurred after the latest changes. We unknowingly deleted the content-block attribute from the scss file instead of just removing it from a particular element. The result of it is that the date tabs and the headings below are not aligned anymore. Please correct it in this PR itself and modify the description a bit to reflect it. Thanks!!

Done @Princu7 Please review now. :)