npm install on deployed version fails / "debug" module is missing: "src/ doesn't exist"

Steps to reproduce
EDIT / TLDR;
I have commented out all requires and uses of debugmodule and now it works:

I've added the module to a @stencil/core app with an import statement. Rollup is trying to bundle things up but fails. I then commented out all lines of code in your module until I found out that this line fails:
var _debug = require('debug');

inside base-replicator.js.
Looking at the mode_modules of your module it indeed is missing.
Then I tried to npm install inside your module which gave me the error below.
Expected behavior

I can import the module into an app that uses a web bundler, in my case rollup.
I can npm install on the distributed npm package without error

Actual behavior
npm install on the deployed version of the module gives me this:
> npm run compile

><EMAIL_ADDRESS>compile /Users/matthias/Documents/Projekte/bitflower/Case OS/Prototype/v0.2/caseos-ui/node_modules/feathers-offline-realtime
> shx rm -rf lib/ && babel -d lib/ src/

src/ doesn't exist
npm ERR! code ELIFECYCLE
npm ERR! errno 2
npm ERR<EMAIL_ADDRESS>compile: `shx rm -rf lib/ && babel -d lib/ src/`
npm ERR! Exit status 2
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>compile script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR!      /Users/matthias/.npm/_logs/2018-02-09T12_49_47_873Z-debug.log
npm ERR! code ELIFECYCLE
npm ERR! errno 2
npm ERR<EMAIL_ADDRESS>prepublish: `npm run compile`
npm ERR! Exit status 2
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>prepublish script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR!      /Users/matthias/.npm/_logs/2018-02-09T12_49_47_963Z-debug.log

System configuration
Tell us about the applicable parts of your setup.
The module is part of a Stencil (Ionic hybrid apps) app.
Module versions (especially the part that's not working):
{
  "_from": "feathers-offline-realtime",
  "_id"<EMAIL_ADDRESS>  "_inBundle": false,
  "_integrity": "sha1-BQvY+HuJTZ8f/3pGhhLgO6aJXZs=",
  "_location": "/feathers-offline-realtime",
  "_phantomChildren": {},
  "_requested": {
    "type": "tag",
    "registry": true,
    "raw": "feathers-offline-realtime",
    "name": "feathers-offline-realtime",
    "escapedName": "feathers-offline-realtime",
    "rawSpec": "",
    "saveSpec": null,
    "fetchSpec": "latest"
  },
  "_requiredBy": [
    "#USER",
    "/"
  ],
  "_resolved": "https://registry.npmjs.org/feathers-offline-realtime/-/feathers-offline-realtime-0.1.2.tgz",
  "_shasum": "050bd8f87b894d9f1fff7a468612e03ba6895d9b",
  "_spec": "feathers-offline-realtime",
  "_where": "/Users/matthias/Documents/Projekte/bitflower/Case OS/Prototype/v0.2/caseos-ui",
  "author": {
    "name": "Feathers contributors",
    "email"<EMAIL_ADDRESS>    "url": "https://feathersjs.com"
  },
  "bugs": {
    "url": "https://github.com/feathersjs/feathers-offline-realtime/issues"
  },
  "bundleDependencies": false,
  "contributors": [],
  "dependencies": {
    "component-emitter": "1.2.1",
    "debug": "^2.6.8",
    "feathers-commons": "0.8.7",
    "feathers-errors": "2.8.1",
    "feathers-offline-snapshot": "^0.0.1",
    "feathers-query-filters": "2.1.2",
    "md5": "2.2.1",
    "shortid": "2.2.8",
    "uberproto": "1.2.0",
    "uuid": "3.1.0"
  },
  "deprecated": false,
  "description": "Offline-first realtime replication with optimistic updates.",
  "devDependencies": {
    "babel-cli": "^6.24.1",
    "babel-core": "^6.24.1",
    "babel-plugin-add-module-exports": "^0.2.1",
    "babel-preset-es2015": "^6.24.1",
    "chai": "^4.0.0",
    "feathers": "^2.1.3",
    "feathers-hooks": "^2.0.1",
    "feathers-memory": "^1.1.0",
    "istanbul": "^1.1.0-alpha.1",
    "mocha": "^3.4.2",
    "semistandard": "^11.0.0",
    "shx": "^0.2.2"
  },
  "directories": {
    "lib": "lib"
  },
  "engines": {
    "node": ">= 4.6.0"
  },
  "homepage": "https://github.com/feathersjs/feathers-offline-realtime",
  "keywords": [
    "feathers",
    "feathers-plugin"
  ],
  "license": "MIT",
  "main": "lib/",
  "name": "feathers-offline-realtime",
  "repository": {
    "type": "git",
    "url": "git://github.com/feathersjs/feathers-offline-realtime.git"
  },
  "scripts": {
    "changelog": "github_changelog_generator && git add CHANGELOG.md && git commit -am \"Updating changelog\"",
    "compile": "shx rm -rf lib/ && babel -d lib/ src/",
    "coverage": "istanbul cover node_modules/mocha/bin/_mocha -- --opts mocha.opts",
    "lint": "semistandard src/**/*.js test/**/*.js --fix",
    "mocha": "mocha --opts mocha.opts",
    "prepublish": "npm run compile",
    "publish": "git push origin --tags && npm run changelog && git push origin",
    "release:major": "npm version major && npm publish",
    "release:minor": "npm version minor && npm publish",
    "release:patch": "npm version patch && npm publish",
    "start": "npm run compile && node example/app",
    "test": "npm run compile && npm run lint && npm run coverage",
    "watch": "babel --watch -d lib/ src/"
  },
  "semistandard": {
    "sourceType": "module",
    "env": [
      "mocha"
    ]
  },
  "version": "0.1.2"
}

NodeJS version:
8.9.4
Operating System:
macOS 10.13.3
Browser Version:
Chrome 64
Module Loader:
rollup (@stencil/core)

Run npm install debug inside @ feathers-plus/feathers-offline-realtime.
The Feathers Auk standards are src/ exists on GitHub only and contains the ES2015 source. lib/ exists only on npm and contains the ES5 code produced by Babel.

Hey, so if I use a bundler that expects ES6 modules I should npm install from github URL?

I would think so.
On Fri, Feb 9, 2018 at 9:37 AM, Matthias Max<EMAIL_ADDRESS>wrote:

Hey, so if I use a bundler that expects ES6 modules I should npm install
from github URL?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/feathers-plus/feathers-offline-realtime/issues/19#issuecomment-364450824,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABezn5_E1wcvQ9AmqQEqOitnFgPvfZlhks5tTFgOgaJpZM4R_4lA
.


Fix tensor2d/3d/4d to require shape to have the correct length

This change is

Review status: 0 of 2 files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


Docs: Improved documentation of exceptions

Codecov Report

Merging #945 (5e5bd18) into master (87a18a0) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #945      +/-   ##
==========================================
- Coverage   86.99%   86.98%   -0.02%
==========================================
  Files          50       50
  Lines        6723     6724       +1
==========================================
  Hits         5849     5849
- Misses        874      875       +1

Flag
Coverage Δ

unittests
86.98% <0.00%> (-0.02%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

lark/ast_utils.py
0.00% <ø> (ø)

lark/exceptions.py
85.29% <0.00%> (-0.64%)
:arrow_down:

lark/lark.py
81.78% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87a18a0...5e5bd18. Read the comment docs.

Codecov Report

Merging #945 (5e5bd18) into master (87a18a0) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #945      +/-   ##
==========================================
- Coverage   86.99%   86.98%   -0.02%
==========================================
  Files          50       50
  Lines        6723     6724       +1
==========================================
  Hits         5849     5849
- Misses        874      875       +1

Flag
Coverage Δ

unittests
86.98% <0.00%> (-0.02%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

lark/ast_utils.py
0.00% <ø> (ø)

lark/exceptions.py
85.29% <0.00%> (-0.64%)
:arrow_down:

lark/lark.py
81.78% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87a18a0...5e5bd18. Read the comment docs.


Enter key in a textarea will trigger the expand action

With the following snippet:
    {{#paper-expansion-panel expanded=true expand=(action "expand") collapse=(action "collapse") as |panel|}}
      {{#panel.collapsed}}{{/panel.collapsed}}

      {{#panel.expanded as |expanded|}}
          {{#expanded.header}}
          {{/expanded.header}}

          {{#expanded.content}}
              {{paper-input
                textarea=true
                value=value
                onChange=(action (mut value))
              }}
          {{/expanded.content}}
      {{/panel.expanded}}
    {{/paper-expansion-panel}}

Pressing the enter key within the textarea will trigger the expand action of the panel.
Not sure if the issue is ember-paper-expansion-panel that interprets the enter key in this case or paper-input that should not bubble up the key event. This ticket may belongs to ember-paper.

action is bubbling to parent. needs to pass "bubbles false" in some point in paper input i think.
reference
https://guides.emberjs.com/v1.10.0/templates/actions/#toc_action-bubbling


Add Whisper Voice Activity Detector (VAD) or Silero VAD for silence suppression

Feature request
New feature using VAD for silence suppression. A better description can be found at https://github.com/jianfch/stable-ts?tab=readme-ov-file#silence-suppression
Motivation
Current Whisper implementation fails to capture silences in word-level settings due to absence of VAD:
} else {
  current_tokens.push(token);
  if (returnWordTimestamps) {
    let start_time = round(token_timestamps[i] + time_offset, 2);
    let end_time;
    if (i + 1 < token_timestamps.length) {
      end_time = round(token_timestamps[i + 1] + time_offset, 2);
    } else {
      end_time = null;
    }
    current_token_timestamps.push([start_time, end_time]);
  }
}

The decoding algorithm just selected end_time as the next predicted token timestamps but this does not handle at all silences nor breaks in the audio file. In some cases, the predicted timestamps anticipates the real presence of the word in the audio file hence generating wrong word timestamps.
Your contribution
https://github.com/MatteoFasulo/transformers.js/blob/fix-word-timestamps/src/tokenizers.js :
if (returnWordTimestamps) {
    let start_time = round(token_timestamps[i] + time_offset, 2);

    let end_time;
    let regex = /[!.,;?]+$/
    let decoded_text = this.decode([token]);

    if (i + 1 < token_timestamps.length) {
        end_time = round(token_timestamps[i + 1] + time_offset, 2);

        // If the token is a punctuation mark, we can assume it's the end of a word in most cases
        if (regex.test(decoded_text)) {
            end_time = round(start_time + 0.02, 2); // +0.02 to avoid overlapping timestamps
          }
    } else {
        // should never happen
        end_time = null;
    }
    current_token_timestamps.push([start_time, end_time]);
}

The regex pattern should detect punctuation and add a reasonable timestamp for that (+0.02 just to avoid overlapping). This temporary solution should address the issue while using return_timestamps: 'word'.
I am not able to work on VAD or Silero VAD right now but a PR with these changes would be great. Waiting for @xenova thoughts on this.

Hi there 👋 We try base our implementation on the original python transformers library, so if this change is present there, we can add it! :) Otherwise, feel free to submit a feature request there too 👍

I noticed there was some activity around silero vad ONNX models.
https://huggingface.co/onnx-community/silero-vad
Is the V3 branch able to use Transformers.js for VAD? If so, is there some example code you could share?

also looking to use silerovad v5 onnx in transformers.js - wonder if someone could share a working example

@eschmidbauer Same here. I'd like to run the speaker diarization example during a meeting, on chunks of recorded conversation. Then summarize the meeting and extract per-speaker action points, as that seems to be a very popular use case.


Add http client plugin

Add HTTP client plugin

Changes

Add plugin schema
Implement HttpPlugin and resolver
Add unit tests

TODO before closing PR

Add e2e tests

Issues

Closes #65

@dOrgJelli Should we open issue to add linting/formatting to graphql and json files? :)

Yes definitely, good call @mpetrunic, will create now


reference gnu screen with example how to use 3d-ascii-viewer as screensaver?

https://www.gnu.org/software/screen/manual/html_node/Screen-Saver.html

In my opinion, this probably is more deserving of a tutorial in the wiki than to be in the README.
Is screen commonly used? I had to install it in my system (Pop!_OS).
By adding:
blankerprg /home/fcasas/3d-ascii-viewer-c/3d-ascii-viewer --color /home/fcasas/3d-ascii-viewer-c/models/fox.obj
idle 5

to my screen.rc, I got it working after starting screen and waiting for 5 seconds, but a problem is that it doesn't revert the color palette after the program it is closed, when using the --color mode.

I agree, maybe you can enable the wiki for the project?

Does it work now?


Branch host-op-1.6 regression

I am testing host-op with my handcraft repo: https://github.com/LiuJiazheng/rust-host-keccak256
and an example https://github.com/LiuJiazheng/zkWasm-rust
Both symptom are same:
dry run can pass but single-proof failed on imtable with bt:
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: 91', crates/specs/src/imtable.rs:88:22
stack backtrace:
   0: rust_begin_unwind
             at /rustc/ff8c8dfbe66701531e3e5e335c28c544d0fbc945/library/std/src/panicking.rs:575:5
   1: core::panicking::panic_fmt
             at /rustc/ff8c8dfbe66701531e3e5e335c28c544d0fbc945/library/core/src/panicking.rs:65:14
   2: core::result::unwrap_failed
             at /rustc/ff8c8dfbe66701531e3e5e335c28c544d0fbc945/library/core/src/result.rs:1791:5
   3: specs::imtable::InitMemoryTable::try_find
   4: specs::mtable::MTable::new
   5: <delphinus_zkwasm::runtime::CompiledImage<wasmi::module::NotStartedModuleRef,wasmi::tracer::Tracer> as delphinus_zkwasm::runtime::wasmi_interpreter::Execution<wasmi_core::value::Value>>::run
   6: delphinus_zkwasm::loader::ZkWasmLoader<E,T,EnvBuilder>::run
   7: delphinus_zkwasm::loader::ZkWasmLoader<E,T,EnvBuilder>::circuit_with_witness
   8: delphinus_cli::exec::exec_create_proof
   9: delphinus_cli::main

My script
#!/bin/bash

set -e
set -x

rm -rf output
mkdir output

#wasm image
FILE=$1
default=/home/frank/Projects/zkWasm-rust/pkg/output.wasm
FILE=${default}

#k
SPACE=${2:-18}

# Have `cuda` build
ZKWASM=~/Projects/zkWasm/target/release/delphinus-cli

export RUST_LOG=info
export RUST_BACKTRACE=1

${ZKWASM} --function zkmain -k ${SPACE} --param ./params --output ./output --host host --wasm ${FILE} setup

${ZKWASM} --function zkmain -k ${SPACE} --param ./params --output ./output --host host --wasm ${FILE} dry-run

${ZKWASM} --function zkmain -k ${SPACE} --param ./params --output ./output --host host --wasm ${FILE} single-prove

The reason:
impl InitMemoryTable {
    pub fn new(entries: Vec<InitMemoryTableEntry>, k: u32) -> Self {
        let mut imtable = Self {
            entries: entries
                .into_iter()
                .map(|entry| InitMemoryTableEntry {
                    ltype: entry.ltype,
                    is_mutable: entry.is_mutable,
                    start_offset: entry.start_offset,
                    end_offset: if entry.end_offset == u32::MAX {
                        (1u32 << (k - 1)) - 1
                    } else {
                        entry.end_offset
                    },
                    vtype: entry.vtype,
                    value: entry.value,
                })
                .collect(),
            sorted_global_init_entries: vec![],
            sorted_heap_init_entries: vec![],
        };

The logic of assignment end_offset is depending on k to set up the "MAX" number in the sense of space k.
However when k is small (say 18), the start_offset might be greater than end_offset, thus later when Memory::new trying to find imtable entry, the binary search cannot be performed corrected and hit unwrap
Propose: instead of silently allowing it and triggers an assertion in other place, it could be better directly asserting in imtable::new.
Evidence:
Offset: 131194
InitMomoryEntry
InitMemoryTableEntry { ltype: Heap, is_mutable: true, start_offset: 131194, end_offset: 131071, vtype: I64, value: 0 }
Always be the last one.

Will try to perform some pre-check in the dry-run.


API: Finalize SourceControl.selected

First is here:
https://github.com/microsoft/vscode/blob/9b564ad40db4a07b2cdc13a9e5a994ad8381222f/src/vs/vscode.proposed.d.ts#L689-L737
Second is here:
https://github.com/microsoft/vscode/blob/9b564ad40db4a07b2cdc13a9e5a994ad8381222f/src/vs/vscode.proposed.d.ts#L740-L755

Both have been in proposed state for three years.
Pinging @joaomoreno

The first api might be getting closer, as I've been using it lately. But I need to talk to @joaomoreno about the specifics.
And I don't know much about the 2nd -- @joaomoreno?

@eamodio Let's sit down and discuss this next debt week. 👌

@gjsjohnmurray, thanks for the nudge. I was wondering whether you are leveraging the selected property and onDidChangeSelection event. This is proposed API that is currently being exposed through the git extension API and we would like to deprecate it.

Input validation API: https://github.com/microsoft/vscode/issues/131007

@lszomoru thanks for checking. No, I'm not using it. The effort to use a proposed API and distribute the VSIX by non-Marketplace channels wasn't justified in this case.


[FLINK-34529][table-planner] Introduce FlinkProjectWindowTransposeRule.

What is the purpose of the change
The PR aims to support pushing a Project past a Window in stream mode(It has been supported in batch mode).
Brief change log

Introduce FlinkProjectWindowTransposeRule into project_rewrite and logical stage .
Update xml and .out of effected test case
Move CoreRules.PROJECT_WINDOW_TRANSPOSE from default_rewrite stage into project_rewrite and logical stage. (To keep behaviors consistent in stream and batch mode. )

Verifying this change
This change added tests and can be verified as follows:

Added FlinkProjectWindowTransposeRuleTest to test if the plan is as expected.

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not applicable)

@flinkbot  run azure

@libenchao hi, comments are all resolved, please help reviewing it when you have time, thx : )

@flinkbot  run azure


Specific Docker Version?

Was the Dockerfile built using a specific version of the Docker engine?  I tried to look for some Docker versions that were required in the DeveloperGuide but I didn't see any.  There were a couple issues with building the image and I may have a few fixes for it if anyone needs it.  It was mainly cleaning up some of the commands.
I'm running Docker version 1.12.0, build 8eab29e

Thanks for the information.
The docker file was provided by a contributor, and I don't know if it is for any specific version of Docker. It would be great if you send any pull request to make it work with the latest version of Docker.

You are welcome and no problem at all.  I can get the changes added here shortly and I'll submit a pull request here within a day or two.


Local art source doesn't change when source file is overwritten.

I'm creating an art source which is based on a series of drawables in my app. The art source converts the drawable into a file which is then sent via publishArtwork.
Originally I just converted the current drawable to the same file, /storage/emulated/0/mdessert.png. When this happened however, the wallpaper did not appear to update. It was always stuck on the original image.
I modified my example so that each drawable was converted to its own file and the unique file uri was published. This method allows the wallpaper to update as expected.
Looking through I source, I did not find the exact cause of this behavior, but I suspect that Muzei checks whether the uri updated before it actually updates. I think this behavior should be changed so it updates on publishArtwork, or add a flag which lets Muzei know the file itself has been overwritten so it can redraw the file.
Below is my onUpdate method.
 @Override
protected void onUpdate(int reason) {
    Log.d(TAG, "Update");
    SettingsManager sm = new SettingsManager(this);
    String d = sm.getString(R.string.current_image);
    Dessert dessert = MUtils.getDessertFromString(d);

    //Open my app
    Intent i = new Intent(this, MainActivity.class);
    //Convert drawable to bitmap
    Bitmap icon = BitmapFactory.decodeResource(getApplicationContext().getResources(),
            dessert.getDrawable());
    //Now bitmap to file
    FileOutputStream out = null;
    String path = Environment.getExternalStorageDirectory().toString();
    File file = new File(path, "mdesserts/"+getResources().getResourceEntryName(dessert.getDrawable())+".png");

    try {
        out = new FileOutputStream(file);
        icon.compress(Bitmap.CompressFormat.PNG, 100, out);
    } catch (Exception e) {
        e.printStackTrace();
    } finally {
        try {
            if (out != null) {
                out.close();
            }
        } catch (IOException e) {
            e.printStackTrace();
        }
    }

    try {
        publishArtwork(new Artwork.Builder()
                        .title(String.format(getString(R.string.android_m), dessert.getName()))
                        .byline(dessert.getPhotographer())
                        .imageUri(Uri.fromFile(file))
                        .token(dessert.getName())
                        .viewIntent(i)
                        .build()
        );
        Log.d(TAG, "Published");
    } catch(Exception e) {
        Log.d(TAG, "Didnt work");
        e.printStackTrace();
    }

    Log.d(TAG, "Scheduling update");
    scheduleUpdate(System.currentTimeMillis() + ROTATE_TIME_MILLIS);
}

Once published, Muzei caches the image at the URI and doesn't watch for changes by design.


AlertRules- Add SentinelEntities and extend AlertDetailsOverride

ARM API Information (Control Plane)
MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo.  If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?

[ ] new service onboarding
[ ] new API version
[x] update existing version for new feature
[ ] update existing version to fix swagger quality issue in s360
[ ] Other, please clarify

When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month. August 2022.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

[x] I commit to follow the Breaking Change Policy of "no breaking changes"
[x] I have reviewed the documentation for the workflow.
[x] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

Applicability: :warning:
If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs
Adding new properties
All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

[x] Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review.  Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

Adding a new service
Adding new API(s)
Adding a new API version
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.

[x] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.

@necoh
Notice that we have a cross version breaking change. Looks like the techniques are readonly in the preview version and not readonly in the stable version. It is not related to the change here, but worth checking

@necoh Notice that we have a cross version breaking change. Looks like the techniques are readonly in the preview version and not readonly in the stable version. It is not related to the change here, but worth checking

@necoh
This is the issue Ziv sent about earlier today.
It should be resolved with this PR: https://github.com/Azure/azure-rest-api-specs/pull/20668


how can i prepare TLG data for BPE based dataset, like multi_cn

I'd like to use WFST based decoder for multi_cn dataset, but when i going to generate TLG for wfst decoder,
i cannot figure out how to preprare lexicon files, do you have a docs or tutorial for that?

please refer https://github.com/wenet-e2e/wenet/blob/main/examples/librispeech/s0/run.sh#L260


Refactor File Content changed dialog

This is part of the overall dialog refactoring #959

remove hardcoded file-content-changed dialog in favor of reusable dialogs
implement new dialog in a way that it is configured through the client

I've sent this back to ready as indicated in my PR comment. Please update the issue state (in progress, needs review) accordingly once you address the review hints.


Unsupported Network Tooltip

Fixes #1278
Changes proposed in this PR:

Name of network is changed to red if that network is unsupported
If network is unsuported the new tooltip is shown
Tooltip contains buttons the user can click to immediately change their wallet network
The same tooltip has been added to the submit page
Additional fix: the logic now uses chainIdsSupported from app.config.js as ocean.js was not giving reliable information on which networks are supported. Previously the red square wasn't shown for mainnets that we supported in V3 (even though we don't support them yet). It's fairly important we communicate that these networks aren't supported as someone could easily of the V4 link and try publish to mainnet etc.

Screenshots

In page title:

In place of the submit button:

I don't think there's a need to introduce a specific unsupported networks tooltip. Did you notice how I used the existing tooltip in my draft and just added a list of supported networks? https://github.com/oceanprotocol/market/issues/1278#issuecomment-1090509431
Showing "Unsupported network" beside the red network name is enough, no need to add even more custom components and copy for this use case.

Not sure how we would do that if we just pass in text?

Sorry, was unclear, I mean that the supported networks should be shown at all times in the existing tooltip. Then no need to create a dedicated one only for the unsupported network case

Not sure how we would do that if we just pass in text?

Sorry, was unclear, I mean that the supported networks should be shown at all times in the existing tooltip. Then no need to create a dedicated one only for the unsupported network case

Ok sure, sounds good

I've updated to tooltip message to change it to a generic message about the available networks. The same tooltip will be always be shown regardless of which network the user is on.

UI-wise, we need to do something with the spacing as when we fill our tooltip component with more than few lines of text, it looks mashed together. To counter that we set more padding on the first child of it in such cases, like in our menubar tooltips so they can be used as spacing guideline for this specific tooltip too:


Fix bug missing Security Group in Advanced Zone with SG enabled

@davidjumani @rhtyd cc @svenvogel

Advanced Zone with SG enabled:

Networks step:

Security Group step:

@blueorangutan package

@davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.

Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/558 (JID-2682)


CiviForm Down -- Residents and Admins unable to access

Describe the bug
Residents and CiviForm Admins get the error message "7mnk316em" when trying to login or complete a form.
To Reproduce
Steps to reproduce the behavior:
RESIDENT 1:

Go to https://civiform.seattle.gov
Click on "Continue as Guest"
Select a program "Utility Discount Program"
See error, attached

RESIDENT 2:

Go to https://civiform.seattle.gov

Click on "Login"

Login with username and password

Select a program "Utility Discount Program"

See error

CIVIFORM ADMIN:

Go to https://civiform.seattle.gov
Click on "Admin"
See error, attached

Screenshots
Attached
Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

Seeing this error in the logs:
! @7mnkjikcd - Internal server error, for (GET) [/applicants/9989/programs/497/preview] ->
play.api.UnexpectedException: Unexpected exception[CompletionException: java.lang.RuntimeException: java.lang.IllegalArgumentException: Multiple entries with same key: Enum_Household Member=services.question.types.EnumeratorQuestionDefinition@30a and Enum_Household Member=services.question.types.EnumeratorQuestionDefinition@2ee]
https://docs.google.com/spreadsheets/d/1iS78kVpUerWXkD0GOklJaTxwUcusC1KSYT7MM9zwwSk/edit?resourcekey=0-VstgnOqAEoR9jNtEGU92Ag#gid=0

Will have @bion pull the program data to understand what the full program configuration on MOnday

@elisekalstad to help with debugging, have there been any changes published for the utility discount program recently?

After pulling the program configuration from Seattle prod, determined that the cause of the issue was a duplicate draft question definition in the current draft. No programs referenced the duplicate, so deleting it resolved the issue. Will need to investigate further to determine how the duplicate came into existence, but this incident is now mitigated.
Mitigation was running the following:
DELETE FROM questions WHERE id = 747;
DELETE FROM versions_questions WHERE questions_id = 747;

For root causes, I'm wondering if it was an issue of having the "Edit Questions" page open in 2 different browser windows. I was making edits to one of the questions, there's a good chance I had it open to edit in to web browser tabs.


IME does not work with Wayland

Same as title. issue #120084
Output:
$ code --enable-features=UseOzonePlatform --ozone-platform=wayland --gtk-version=4 --verbose

(process:5932): Gtk-ERROR **: 20:50:04.523: GTK 2/3 symbols detected. Using GTK 2/3 and GTK 4 in the same process is not supported
Trace/breakpoint trap (core dumped)

Merging to https://github.com/microsoft/vscode/issues/167757


[Question] GraphQL Hotchocolate (AddPooledDbContextFactory) and Finbuckle

Hello,
So I am looking at integrating GraphQL into one of my projects that uses Finbuckle and my GraphQL library of choice at this stage is Hot Chocolate . Reading through the HotChocolate docs I notice there is a requirement to add a pooled DbContext Factory., the reasoning for this is

"The execution engine of HotChocolate executes resolvers in parallel. This can lead to exceptions because the database context of Entity Framework cannot handle more than one request in parallel....... The execution engine needs more than one database context. You should register the database context in a pool rather than transient. During execution database contexts are taken from this pool and returned once the resolver is completed. This has a smaller memory impact, as creating a new context for each resolver."

This got me thinking, how do we go about implementing this in a Finbuckle multitenant environment. Particularly, where each HTTP request is instantiating one context. Also should we go down the route of a pooled DbContext, can that be configured in a way that respects multitenancy?
For a bit of background , here is the current implementation code for a functioning multitenant environment.
            services.AddMultiTenant()
                .WithStrategy<CustomMultiTenancyStrategy>(ServiceLifetime.Scoped, new object())
                .WithConfigurationStore( Configuration, "Finbuckle");

            services.AddDbContext<XContext>();

Below the recommended code in the docs to replace  services.AddDbContext line , but would it take into account multitenancy
services.AddPooledDbContextFactory<XContext>(b => b /*your configuration */)

This code from XContext might also be handy
       protected override void OnConfiguring(DbContextOptionsBuilder optionsBuilder)
        {
            optionsBuilder.UseLazyLoadingProxies(false);
            optionsBuilder.UseSqlServer(ConnectionString, options => options.EnableRetryOnFailure(
                    maxRetryCount: 10,
                    maxRetryDelay: TimeSpan.FromSeconds(30),
                    errorNumbersToAdd: null
                ));

            base.OnConfiguring(optionsBuilder);
        }

Link to Hot Chocolate docs:
https://chillicream.com/docs/hotchocolate/integrations/entity-framework/

Funny, this is the same reason I am interested in #375 too. The only way to know is to try it. I haven't had time to look into this yet.

Hi @hbermani thanks for the question. I need to learn more about GraphQL in general, but with respect to the db context pool I have an idea.
So here is something to test out. It's on my list but I just don't have all the time I wish I did to get to it all.
In theory instead of passing ITenantInfo or an implementation to a db context you could pass IMultiTenantContextAccessor<T> (or the non generic version), accessor the MultiTenantContext and the TenantInfo to get the connection info. This uses an AsyncLocal<T> variable to access the MultiTenantContext similar to how HttpContextAccessor works.
So that might let you get around the problem of a db context being stuck with the ITenantInfo it was constructed with. What I don't know is if it's possible to change the connection string for the context after OnConfiguring has been called. I'm pretty sure, but not 100%, that OnConfiguring would only get called once initially for a pooled db context. I would think it should be doable I just haven't looked into it. What do you guys think?

@hbermani did you try this yet? I haven't had time myself but am curious on the results.

Hi @natelaff , I ended up using OData instead of GraphQL... seems to do the job for now.

Hello, any news her ? Really need to use PooledDbContext ?

@g-6k not at the moment but since I think it should be straight forward I will prioritize it. See my comment above for an approach using IMultiTenantAccessor injected into the db context instead of the current tenant provides a possible workaround.


Continuous error with plugin

https://pastebin.com/fZHG1dtz
What file is causing this error? it happens every time someone changes ranks which is a lot. How do I fix it

The plugin is functioning so bad for me for some reason I can't use the notify log to see what's causing all the issues for players on the server. Their ranks are not being removed properly when ranking up...

You have a corrupted action logger file, I'd suggest stopping the server and deleting it

I'm unsure what this "action logger file" is or looks like @electronicboy, which file should I delete?

The actions.json file. :)


[request] option to clear archive on end of session

the archive section fills up over time and starts causing problems when it reaches its max size from what I have seen, it would be nice to be able to have the option to have the archive delete itself when the tab running ytcfilter is closed, my coding knowledge is garbage, only a tiny bit of java and python, so if this is either impossible or would just be a massive pain to implement then feel free to close this without a response.

It shouldn't be hard to implement, but it depends a bit of what is available to me from the browser. I have planned to have storage warning, and also autocleaning in the future.

It shouldn't be hard to implement, but it depends a bit of what is available to me from the browser. I have planned to have storage warning, and also autocleaning in the future.

Good to hear, keep up the good work, this plugin is a real life saver

Good to hear, keep up the good work, this plugin is a real life saver

As  I feared, browsers don't have any event fired for extension when they are closed
https://bugs.chromium.org/p/chromium/issues/detail?id=30885
At the tab level, I need to check. I hope I won't need the tab permission, or that Google will not mess again with the permission...

As  I feared, browsers don't have any event fired for extension when they are closed
https://bugs.chromium.org/p/chromium/issues/detail?id=30885
At the tab level, I need to check. I hope I won't need the tab permission, or that Google will not mess again with the permission...

Autocleaning has been added in 2.1.0. It's not exactly at the end of the session, but a number of days after the last time you viewed a video. I hope this will answer your feature request for now.
2.1.0 release will be first on Firefox, and there might be some delay with Google just so I can manage the release, but they can also take their sweet time during review.

Autocleaning has been added in 2.1.0. It's not exactly at the end of the session, but a number of days after the last time you viewed a video. I hope this will answer your feature request for now.
2.1.0 release will be first on Firefox, and there might be some delay with Google just so I can manage the release, but they can also take their sweet time during review.


Gradle should fail if a referenced init script does not exist

When explicitly including an init script (via -I or --init-script), Gradle will silently ignore the init script if it does not exist.
Expected Behavior
gradle -I doesNotExist.gradle ... would fail.
Current Behavior
gradle -I doesNotExist.gradle ... succeeds as if the init script was not requested.
Context
If someone uses init scripts to inject additional configuration conditionally (e.g., on CI only), simple file renames can silently break things.
We had this happen on the gradle/gradle build when we converted our init script to Kotlin.

👍
Silently ignoring non-existing init scripts did bite me quite some times and I think it is surprising that we do no fail the build if the init script is not found.


/api/v1/explore/form_data?tab_id=7 response 403 FORBIDDEN

PS : we update our superset from v1.4.1 to v1.5.0，Especially the database
superset db upgrade
API  /api/v1/explore/form_data?tab_id=X always error，There are no specific errors reported in the log, and debug can't get in api code ： superset.explore.form_data.api.ExploreFormDataRestApi.post
enter chart config page

Go to  chart config page
api  /api/v1/explore/form_data?tab_id=7  [METHOD POST] responses  403 FORBIDDEN

click run

Click on 'run'
api /api/v1/explore/form_data?tab_id=7  [METHOD PUT] responses 405 METHOD NOT ALLOWED

we drop old mysql database and use superset db upgrade rebuild database , The problem won't happen
Environment

browser type and version: chrom
superset version: superset version : 1.4.1 updated to 1.5.0
python version: python --version : 3.9
DB : mysql

Have you run superset init after upgrading ? (this will update the default role and permissions)

Can confirm superset init fixes the issue.

Can confirm superset init fixes the issue.

thx ,it works

Have you run superset init after upgrading ? (this will update the default role and permissions)

thx ,it works


Download link on your website is broken

Hello,
The app has suggested me to upgrade my version, but the link on the website it's broken
Website:
https://github.com/Kilian/fromscratch/releases/download/v1.2.0/FromScratch-darwin-x64-1.2.0.zip
The one that works:
https://github.com/Kilian/fromscratch/releases/download/1.2.0/FromScratch-darwin-x64-1.2.0.zip

oops! those links now work again :) thanks!


Better Error Handling or Subprocess Survivability

I had a crash happen due to the time bug while two other streamers were live. This caused the entire program to crash and not record the other two streamers. Would love each stream to be handled independently so crashes because of one stream doesn't cause all streams to crash.

develop branch is unstable as it's the live code i'm working on. i think the only thing that would solve all errors is to put the entire program in an error handler, which is not a good idea. best course of actions is probably to do a feature freeze and just bug fix until it's stable enough to release


Add ability to hide 0-test rows from the Test Statistics Portlet

The Compiler warnings plugin has the ability to not show jobs on the dashboard with no warnings.  This adds the same capability to the built-in Test Statistics Chart Portlet to hide jobs which have no tests.

[FIX JENKINS-33952]


Move Count to functions-aggregate

Which issue does this PR close?

Part of #8708
Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

There are 3 todos after this PR,

remove builtin aggregate function Count:
remove expr_fn::count and count distinct
rename count's name lowercase

I will file an issue before merging this one

I will try and review this tomorrow

I am not sure about the MSRV changes (why are those needed?)

I keep failing with the MSRV check in the CI, so I upgrade the version of it. https://github.com/apache/datafusion/actions/runs/9351098969/job/25736034103

error: package `clap_builder v4.5.2` cannot be built because it requires rustc 1.74 or newer, while the currently active rustc version is 1.73.0
Either upgrade to rustc 1.74 or newer, or use
cargo update -p<EMAIL_ADDRESS>--precise ver
where `ver` is the latest version of `clap_builder` supporting rustc 1.73.0

clap_builder needs 1.74, which used in criterion v0.5.1
│   │   ├── petgraph v0.6.5
│   │   │   ├── fixedbitset v0.4.2
│   │   │   └── indexmap v2.2.6 (*)
│   │   └── regex v1.10.4 (*)
│   │   [dev-dependencies]
│   │   ├── arrow v51.0.0 (*)
│   │   ├── criterion v0.5.1
│   │   │   ├── anes v0.1.6
│   │   │   ├── cast v0.3.0
│   │   │   ├── ciborium v0.2.2
│   │   │   │   ├── ciborium-io v0.2.2
│   │   │   │   ├── ciborium-ll v0.2.2
│   │   │   │   │   ├── ciborium-io v0.2.2
│   │   │   │   │   └── half v2.4.1 (*)
│   │   │   │   └── serde v1.0.203 (*)
│   │   │   ├── clap v4.5.4
│   │   │   │   ├── clap_builder v4.5.2
│   │   │   │   │   ├── anstream v0.6.14 (*)
│   │   │   │   │   ├── anstyle v1.0.7
│   │   │   │   │   ├── clap_lex v0.7.0
│   │   │   │   │   └── strsim v0.11.1
│   │   │   │   └── clap_derive v4.5.4 (proc-macro)
│   │   │   │       ├── heck v0.5.0
│   │   │   │       ├── proc-macro2 v1.0.85 (*)
│   │   │   │       ├── quote v1.0.36 (*)
│   │   │   │       └── syn v2.0.66 (*)

This PR has several conflicts -- other than those, do you think this PR is ready for another review @jayzhan211 ?

Yes, it is ready for review.

Thanks @alamb !


Merge relevant bits from funcx_singularity_updates branch

There are significant improvements on the funcx_singularity_branch that need to be folded back into master, but they need to be factorized out from the container/etc stuff.
Among other things, this will fix #854 as it removes the call to multiprocessing.Queue.qsize()

From a quick browse of this branch, it looks like this aims to do some stuff that I also have interest in (although it is not critical) for a workflow that I'm working on which uses shifter/singularity.

Merging funcx stuff into parsl doesn't make sense any more - closing


Avoid masking AttributeErrors during StreamField block serialization

Ref #11702. Generally, the first call to _build_block_json happens when accessing the media property of the widget. Django wraps this in a try/except AttributeError to guard against the widget not defining a media property, so if an AttributeError occurs during the JSContext.pack operation, the error will be suppressed and the BlockWidget left in an invalid state where _js_context is defined but _block_json is not. Accessing block_json on the widget will then fail with 'BlockWidget' object has no attribute '_block_json'.
Along with dealing with the masking of AttributeError in general, we also add an error check for SnippetChooserBlock being used on a non-Snippet model, which has been identified on #11702 as a common cause of this problem.

Merged in fa8f9415c91e6ad27e05df85806a144fdae3b9de (main) / 46c78be145 (stable/6.2.x)


Add @google-cloud/vision failing test

The failure is similar to the last one:
Error: The include `google/cloud/vision/v1p4beta1/geometry.proto` was not found.
    at Function._findIncludePath (/tmp/4e497625c085ff0b559dc241c685febd/index.js:88738:19)
    at GoogleProtoFilesRoot.resolvePath (/tmp/4e497625c085ff0b559dc241c685febd/index.js:88726:37)
    at process (/tmp/node_modules/protobufjs/src/root.js:112:1)
    at fetch (/tmp/node_modules/protobufjs/src/root.js:166:1)
    at GoogleProtoFilesRoot.load (/tmp/node_modules/protobufjs/src/root.js:194:1)
    at GoogleProtoFilesRoot.loadSync (/tmp/node_modules/protobufjs/src/root.js:235:1)
    at Object.loadSync (/tmp/node_modules/protobufjs/src/index-light.js:69:1)
    at module.exports.module.exports.apiVersion (/tmp/4e497625c085ff0b559dc241c685febd/index.js:36443:29)
    at Object.<anonymous> (/tmp/node_modules/@google-cloud/vision/src/index.js:59:1)
    at __webpack_require__ (/webpack/bootstrap:19:1)

But unfortunately a completely different unknown reason for now.

The fix here turned out to be as simple as installing the latest version of google-proto-files from npm.

Codecov Report

Merging #420 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #420   +/-   ##
=======================================
  Coverage   73.65%   73.65%
=======================================
  Files          13       13
  Lines         391      391
=======================================
  Hits          288      288
  Misses        103      103

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d158fe3...2d2ff8b. Read the comment docs.


without the answers???

Hey there, wonderful work! Would it be possible for you to add notebooks without the solutions as well. I really want to go through the mooc but my financial condition simply does not allow that at this point.
I've applied on coursera for financial assistance but they take 15 days to review the application, till then I wanted to go through the material and the assignments myself, if you could help out that would be awesome!

You have full access to the programming assignment but the submission part even you are not paying for the course.
That is, you can choose the "audit" option on any course on Coursera to audit the course without any payment.
For details about how to audit a course, see here.

Thank you for your response, but auditing the course does not get you access to the programming assignments just the other course material such as the videos and the presentations; I am already auditing the course right now.

@Adeel-Abdullah I think you have the access right? But you cannot submit it, the only restriction.

No, the assignments are not accessible either while auditing, they are accessible only once you purchase it.

@Adeel-Abdullah
Man, you access to the assignment HERE

Like the first row in my screenshot. Not the second locked one. I tested it on a free account.
EVERY Coursera programming assignment works like this. I never heard about any programming assignment that is not public.

Apologies for the misunderstanding, I just checked. I was previously clicking on the next tab the one with the lock on it, Thankyou for the help!


Release Google.Cloud.ServiceManagement.V1 version 1.0.0

Changes in this release:
First GA release.

Commit 7b21712: chore: Set namespaces for Ruby clients

Created release for Google.Cloud.ServiceManagement.V1-1.0.0


Expose the machine readable state of a container when listing containers

PoC implementation of #18962 C

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "machine-readable-state" git@github.com:mariusGundersen/docker.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Ammending updates the existing PR. You DO NOT need to open a new one.

Change LGTM. We'll need to document this new field in the API reference guide.

Makes sense to me! LGTM, thanks :-)

Maybe update the diagram of the state machine too, to match the names of the states?

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "machine-readable-state" git@github.com:mariusGundersen/docker.git somewhere
$ cd somewhere
$ git rebase -i HEAD~2
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Ammending updates the existing PR. You DO NOT need to open a new one.

I've updated the documentation for the /containers/json endpoint

Thanks @mariusGundersen! can you also;

Add a note to the API changes for 1.22; https://github.com/docker/docker/blob/master/docs/reference/api/docker_remote_api.md#v122-api-changes
Squash your commits (so that there's only one commit in this PR)?

OK, so the valid states are: created|restarting|running|paused|exited|dead. This is what State will now return when calling /containers/json, but to filter you need to use the key Status rather than the key State. This is slightly confusing, so I propose that both Status and State can be used to filter the result, but that Status be deprecated.

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "machine-readable-state" git@github.com:mariusGundersen/docker.git somewhere
$ cd somewhere
$ git rebase -i HEAD~4
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Ammending updates the existing PR. You DO NOT need to open a new one.

@thaJeztah, I have updated the documentation, and I have added the ability to filter using the state key. I've also changed the diagram to use the states exposed through the api. If this looks OK I will squash the commits

Thanks @mariusGundersen if we want to deprecate the "status" filter, that will also affect the command line, and we need to add a deprecation notice, so these docs need to be updated as well if we deprecate this;

https://github.com/docker/docker/blob/master/docs/misc/deprecated.md
https://github.com/docker/docker/blob/master/docs/reference/commandline/ps.md
https://github.com/docker/docker/blob/master/man/docker-ps.1.md

I'm not sure yet if we want this, given that filtering by status is pretty common, and deprecating that filter may affect many people.
I'll move this PR back to "design review" so that we can discuss the deprecation

ping @calavera @icecrime wdyt on deprecating the status filter in favor of state?

I'll break this pull-request apart into two pull requests: one that adds state to the /containers/json response, and one that replaces status with state in the filters in the request, both in the API and in the CLI

sgtm,that will probably make merging easier, and moves the discussion to another PR. thanks!

Ok, I've only added the state entry to the output and updated the documentation. I've also squashed the commits into one commit

thanks! docs LGTM

ping @mariusGundersen We need to make a change to docker/engine-api. I'm making a PR to get it quick. See https://github.com/docker/engine-api/pull/45.
But for the time beeing, moving back to code-review :sweat_smile:

@mariusGundersen unfortunately, it looks like this just didn't make the cut for the 1.10 release, so the docs changes need to be updated to be in the v1.23 API version :cry:

I love deadlines, especially the whooshing sound they make as they fly by...

Looks like we're still waiting on that engine-api update?

Looks like we're still waiting on that engine-api update?

the vendored version in master should have this field already.

Ah yep, it's there now, and a duplicate field now.
@mariusGundersen Can you remove your changes from vendor since this is now in?

I've force pushed a fix. I kept the order of the variables from engine-api (State before Status, which is the alphabetical order).

LGTM moving again back to doc review since this was previously there

LGTM
ping @vdemeester @MHBauer

LGTM 🐹


Passwords in vanilla create/update views

Hi, I ran into a problem in my app with vanilla views as it relates to passwords. As you know, passwords have to be hashed before saving. When using the vanilla-generated create and update views, the password was not getting saved correctly via hashing, and looking at those objects i the admin, I got the error "Invalid password format or unknown hashing algorithm"
I understand that vanilla, by design, treats all fields the same, which is fine, but in special cases this may break down. For common use cases like passwords, it would be nice to have them handled automatically. I didn't find anything when Googling this in reference to django-vanilla-views, so (IMHO) I think this would be a good addition to the documentation...
FYI, in my app I am doing a couple of slightly non-standard things:

Custom user model (fully Django compliant)
I am creating interim abstract models from the vanilla views to add functionality, and the real views inherit from those

My workaround was adding this override function 'form_valid' to the create and update views to ensure that this field was treated correctly:
from vanilla import CreateView, DeleteView, ListView, UpdateView, DetailView
from django.contrib.auth.hashers import make_password

class CustomCreateView(CreateView):
        def __init__(self, model, form_class):
        self.model = model
        self.form_class = form_class

    def form_valid(self, form):
        self.object = form.save(commit=False)
        form_data = form.cleaned_data
        try:
            if form_data['password']:  # case for user accounts
                self.object.password = make_password(form_data['password'])
        except KeyError:
            pass
        self.object.save()
        return HttpResponseRedirect(self.success_url)

    class Meta:
        view_abstract = True  # really just documentation

class CompanyCreate(CustomCreateView):
    this_model = Company
    this_form_class = CompanyForm

    def __init__(self, model=this_model, form_class=this_form_class):
        super().__init__(model, form_class)

If you can demonstrate that vanilla views are different to Django's implementation in this regard then we could consider this. Otherwise, not. We mirror their behavior but with a cleaner implementation and interface. Nothing more than that.


[Bug] Comiple error after Flutter 3.19.0 upgrade

Error
/AppData/Local/Pub/Cache/hosted/pub.dev/pluto_grid-7.0.2/lib/src/manager/shortcut/pluto_grid_shortcut.dart(33,39): error GC2F972A8: The argument type 'RawKeyEvent' can't be assigned to the parameter type 'KeyEvent'. [\build\windows\x64\flutter\flutter_assemble.vcxproj]
*****/AppData/Local/Pub/Cache/hosted/pub.dev/pluto_grid-7.0.2/lib/src/manager/shortcut/pluto_grid_shortcut.dart(33,46): error GC2F972A8: The argument type 'RawKeyboard' can't be assigned to the parameter type 'HardwareKeyboard'. [***\build\windows\x64\flutter\flutter_assemble.vcxproj]
Environment
Flutter 3.19.0, on Microsoft Windows [Version 10.0.22631.3155], locale de-DE)
Dart version 3.3.0
PlutoGrid  v7.0.2

+++

+++

same problem. any solutions ?

I have a fork of this repo and landed this fix on there.
Not sure if everything is working fine as it should, but the code is running again.
Just use this in your pubspec:
pluto_grid:
  git: https://github.com/Macacoazul01/pluto_grid

+++ and "me too" comments are noisy and unhelpful, just use the reactions button
This project is in a confusing state, to see what I mean please read this thread:
https://github.com/bosskmk/pluto_grid/issues/968
The tl;dr is:

Original author/maintainer has abandoned and nobody can write to this repo
Someone forked it already and has started making changes (though they are essentially 1 person "doing their best") and partially released the functionality of the original package at pluto_grid_plus. Notably, the pluto_grid_export package has not been republished. I believe while they have not answered issues for a month, they have done prior work to migrate the changes represented by some PRs in this repo and they are moving in a positive direction, help is needed! As of yesterday, this particular bug is still present in pluto_grid_plus. There is discussion of opening up the fork to more maintainers.
There is now a 3rd fork above which contains a replication of the fixes to the RawKeyEvent breaking change that someone put up a PR for months ago (though I don't know how anyone would discover this due to its nondescript name [FIX BUG ON WEB] https://github.com/bosskmk/pluto_grid/pull/979

Sorry there isn't an easier answer to your bug discovery, I'm just a guy in the same situation a couple days ahead of you; trying to spread the knowledge so we can all work in a single direction and not create more noise / future abandoned forks.

me2

same problem
flutter 3.19

Same problem . My app broke due to this. urgent help needed :)

I have a fork of this repo and landed this fix on there. Not sure if everything is working fine as it should, but the code is running again.
Just use this in your pubspec:
pluto_grid:
  git: https://github.com/Macacoazul01/pluto_grid

No Its not working showing the dependancy issue with pluto_grid_export

Try the one @aymswick said, pluto_grid_plus

+++ and "me too" comments are noisy and unhelpful, just use the reactions button
This project is in a confusing state, to see what I mean please read this thread: #968
The tl;dr is:

Original author/maintainer has abandoned and nobody can write to this repo
Someone forked it already and has started making changes (though they are essentially 1 person "doing their best") and partially released the functionality of the original package at pluto_grid_plus. Notably, the pluto_grid_export package has not been republished. I believe while they have not answered issues for a month, they have done prior work to migrate the changes represented by some PRs in this repo and they are moving in a positive direction, help is needed! As of yesterday, this particular bug is still present in pluto_grid_plus. There is discussion of opening up the fork to more maintainers.
There is now a 3rd fork above which contains a replication of the fixes to the RawKeyEvent breaking change that someone put up a PR for months ago (though I don't know how anyone would discover this due to its nondescript name [FIX BUG ON WEB] [FIX BUG ON WEB] #979

Sorry there isn't an easier answer to your bug discovery, I'm just a guy in the same situation a couple days ahead of you; trying to spread the knowledge so we can all work in a single direction and not create more noise / future abandoned forks.

https://github.com/doonfrs/pluto_grid_plus/issues/4#issuecomment-1951236317
Seems pluto_grid_plus_export: ^1.0.4 is now available.

I have the same problem as mentioned, the solution was to return to Flutter version 3.16.8 on channel stable. I hope they can solve it soon, so I can continue working with this package.

I have the same problem as mentioned, the solution was to return to Flutter version 3.16.8 on channel stable. I hope they can solve it soon, so I can continue working with this package.

buddy, nobody is going to solve it on this repository. All the info you need is present in the comments above. Switch to the pluto_grid_plus package. The fix is merged in there.

Original author/maintainer has abandoned and nobody can write to this repo

This is not true. pluto_grid 8.0.0 was released on 2024-03-01 which solves the issue with Flutter 3.19.x.
But for me, the problem is now pluto_grid_export is now incompatible with pluto_grid 8.0.0:
Because pluto_grid_export 1.0.6 depends on pluto_grid >=3.0.2 <8.0.0 and <app> depends on pluto_grid 8.0.0, pluto_grid_export 1.0.6 is forbidden.

Original author/maintainer has abandoned and nobody can write to this repo

This is not true. pluto_grid 8.0.0 was released on 2024-03-01 which solves the issue with Flutter 3.19.x.
But for me, the problem is now pluto_grid_export is now incompatible with pluto_grid 8.0.0:
Because pluto_grid_export 1.0.6 depends on pluto_grid >=3.0.2 <8.0.0 and <app> depends on pluto_grid 8.0.0, pluto_grid_export 1.0.6 is forbidden.

It absolutely was true at the time of my comment. It looks like the maintainer of this repo has returned to partially fix that error, but as you point out, you still won't get anywhere with export. I'm not sure what's going on here but you have an alternative option in pluto_grid_plus.


added 2 tests to TestStartServer

Created 2 new tests, and new warning created, setDaemon() is deprecated. THis can only be fixed by the stem devs.
Added test:
test_ephemeral_onion, test_non_ephemeral_onion

Looks like github actions blocks port checks. So new tests will fail


[WIP] StreamTable docs: basic walkthrough notebook and markdown placeholder

This PR intends to add two files:

an interactive notebook walkthrough of StreamTable usage here: examples/experimental/ProductionMonitoring/stream_table_api.ipynb
a markdown file version of these docs (short, placeholder for now): examples/experimental/ProductionMonitoring/StreamTable.md

Currently fiddling with how to minimize the change set—I started from Tim's monitoring_to_weave branch.
TODOs:

[ ] finish StreamTable.md, figure out where to link to it?
[ ] make this change relative to the right base branch
[ ] I still don't understand if/how one can "open/close" a single StreamTable instance — is there a notion of "I'm done logging to this StreamTable" and "I've closed/stopped/shutdown everything, but now I'm back and I'd like to continue appending to this particular StreamTable instance"?
[ ] do folks need to login / just have a netrc? can we remove the "entity" requirement, it's extra and not actually required
[ ] shall we include a real URL to a real Board? I can publish one, and it will look a bit different probably
[ ] in my testing, .finish() doesn't actually make much difference UX wise — trying to log 1000 rows, I still get incomplete rows in the Board, and slow/shimmery/incomplete loading in the in-notebook panel. Should we recommend/mention it at all? Or just leave this as a note for our demos?

closing and retrying from latest :)


Restrict authenticated senders to mynetworks only

More of an FYI than an issue really, could be added to docs?
If you use the given setup then senders on the internet can use AUTH commands to guess any users password. Once they have that then they will be able to use the server as a proxy.
If you want only people in your network to be able to authenticate, you can do the following:
in config/postfix-main.cf, add:
smtpd_discard_ehlo_keyword_address_maps = cidr:/etc/postfix/esmtp_access
in docker-compose.yml, add:
    - ${PWD}/etc_postfix/esmtp_access:/etc/postfix/esmtp_access:ro
add new file etc_postfix/esmtp_access
# Allow DSN/AUTH requests from local subnet only
<IP_ADDRESS>/16      silent-discard
<IP_ADDRESS>/0           silent-discard, dsn, auth
::/0                silent-discard, dsn, auth

Thanks! That's a nice addition!
If you like you could add that to the wiki!
Though the attacker would have to wait 6 seconds after the ehlo command(if I remember correctly) before he could try one password . If he would speak too fast, postscreen would block him. However, if you got fail2ban enabled, three failed login attempts from the same IP would ban that IP as well. So I hope this attack vector should be unlikely.

It is very likely. Fail2ban by default blocks for 10 mins. I can see remote
servers doing auth attempts every 12 mins. Raising the ban and search
times... the attackers change their patterns to match.
You only need a single user with a weak password.
James
On Mon, 9 Apr 2018, 07:07 17Halbe<EMAIL_ADDRESS>wrote:

Thanks! That's a nice addition!
If you like you could add that to the wiki!
Though the attacker would have to wait 6 seconds after the ehlo command(if
I remember correctly) before he could try one password . If he would speak
too fast, postscreen would block him. However, if you got fail2ban enabled,
three failed login attempts from the same IP would ban that IP as well. So
I hope this attack vector should be unlikely.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/tomav/docker-mailserver/issues/944#issuecomment-379643428,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAYKQUVHXI-Sg7Yh3JuUMeFpjSF8mLy6ks5tmvq1gaJpZM4TLv4K
.

Oh, ok, I don't have those. Just random ones. That's strange. Did you consider, that you are specifically targeted?
If you look at the common rainbowtables, they have around 1-1000 trillion ASCII entries. So if you are trying let's say just the most 1000 common passwords it would take you on average more than 4 days to find a valid one. I always thought the common way to transform a server into a zombie one was in probing for malconfigured servers. But honestly, who am i to know! ;) So thanks again!

Would this prevent usage of SMTP relays such as SES and Mailgun? I suppose specific ranges could be added into the etc_postfix/esmtp_access file but companies may not announce those or change without a warning.

This issue was closed due to one or more of the following reasons:

Age
Contributor inactivity
The issue seems to be resolved

If you think this happened by accident, or feel like this issue was not actually resolved, please feel free to re-open it. If there is an issue you could resolve in the meantime, please open a PR based on the current master branch so we can review it.


Upgrade to ASDK 2.0?

http://asyncdisplaykit.org/docs/layout2-conversion-guide.html

Lastest stable release of ASDK is 1.9.90 - https://github.com/facebook/AsyncDisplayKit/releases
When 2.0 is released we will look at the changes and conform to them

Thanks David.


Improve unique constraint validation error message

The unique constraint validation is working 🎉
Current  Behaviour (for feature requests only)

Expected Behaviour
Instead of:
(column:N/A) Row 2 has an unique constraint violation in column "ab"
Something like:
Column "ab" Row 2 violates the unique constraint
Your Environment

Data Curator version: 0.10.0
Operating System and version:  macOS High Sierra 10.13.3

Hi @Stephen-Gates
I can take care of the display of (column: N/A) - I originally put this here when you were testing which errors were/weren't reporting column numbers.
But that message format comes from frictionless - could you raise it with them - to be sure it is the way you would like it displayed?

Error message is now


Disable Transparent background doesn't work if kitty share the same background

Kitty's opacity setting will change background if they share the same color:

Note that it only sets the background color’s opacity in cells that have the same background color as the default terminal background,

So if I use the same flavour in nvim and kitty, and set kitty transparent, then nvim will be transparent whether transparent_background is true or false

facing this exact issue as well!

This should do it I think:
require("catppuccin").setup({
	kitty = true,
})

@nullchilly can confirm is working,, thank you


ImportError: cannot import name 'LlamaTokenizer' from 'transformers.models.llama'

I tried the minimum example from https://huggingface.co/Snowflake/snowflake-arctic-instruct and it did not work. Can you help me to fix it?

Im using the latest trasnformers release commit.

snowflake-arctic-instruct.py
import os
# enable hf_transfer for faster ckpt download
os.environ["HF_HUB_ENABLE_HF_TRANSFER"] = "1"

import torch
from transformers import AutoModelForCausalLM, AutoTokenizer
from deepspeed.linear.config import QuantizationConfig

tokenizer = AutoTokenizer.from_pretrained(
    "Snowflake/snowflake-arctic-instruct",
    trust_remote_code=True
)
quant_config = QuantizationConfig(q_bits=8)

model = AutoModelForCausalLM.from_pretrained(
    "Snowflake/snowflake-arctic-instruct",
    trust_remote_code=True,
    low_cpu_mem_usage=True,
    device_map="auto",
    ds_quantization_config=quant_config,
    max_memory={i: "150GiB" for i in range(8)},
    torch_dtype=torch.bfloat16)

content = "5x + 35 = 7x - 60 + 10. Solve for x"
messages = [{"role": "user", "content": content}]
input_ids = tokenizer.apply_chat_template(messages, add_generation_prompt=True, return_tensors="pt").to("cuda")

outputs = model.generate(input_ids=input_ids, max_new_tokens=256)
print(tokenizer.decode(outputs[0]))

requirements.txt
annotated-types==0.6.0
certifi==2024.2.2
charset-normalizer==3.3.2
deepspeed==0.14.2
filelock==3.13.4
fsspec==2024.3.1
hf_transfer==0.1.6
hjson==3.1.0
huggingface-hub==0.22.2
idna==3.7
Jinja2==3.1.3
MarkupSafe==2.1.5
mpmath==1.3.0
networkx==3.3
ninja==<IP_ADDRESS>
numpy==1.26.4
packaging==24.0
psutil==5.9.8
py-cpuinfo==9.0.0
pydantic==2.7.1
pydantic_core==2.18.2
pynvml==11.5.0
PyYAML==6.0.1
regex==2024.4.28
requests==2.31.0
safetensors==0.4.3
sympy==1.12
tokenizers==0.19.1
torch==2.3.0
tqdm==4.66.2
transformers @ git+https://github.com/huggingface/transformers@9fe3f585bb4ea29f209dc705d269fbe292e1128f
typing_extensions==4.11.0
urllib3==2.2.1

error can be fixed by installing the correct snowflake transformers pip install git+https://github.com/Snowflake-Labs/transformers.git@arctic
and then also install , as the llama's conditional causes this error
pip install sentencepiece
pip install tokenizers

@karthik-nexusflow better to add this information here

@AllanOricil, with trust_remote_code=True this should be working with public/official transformers>=4.39.0. I am testing this now in a fresh/clean environment with the version you list git+https://github.com/huggingface/transformers@9fe3f585bb4ea29f209dc705d269fbe292e1128f and I'm not able to reproduce this error for some reason :(
When did you download the weights? If you are running in an offline mode and downloaded them more than 5 days ago then trust_remote_code=True won't work and might produce this issue? This PR is what should be getting around installing the transformers fork: https://huggingface.co/Snowflake/snowflake-arctic-instruct/commit/f4ca7904b66a80b6f62d6272253ea1e32375ddd6
The core issue is confusing me though, it's saying you can't import the LlamaTokenizer but this should be available in transformers for a while now well before Arctic was introduced.

@jeffra I don't even know where to use that trust variable. Is that when I run python3 script.py ? I really have no experience with python so pardon me for noob questions 😅
I just copied the simple example, created a virtual env, installed transformers 4.39.0 and deepspeed 0.14.2, then I tried to run the script with python 3, and it did not work. Got the same error that led me to open this issue.
Then I decided to go to hugging face transformers repo to get the latest release of their package, updated my virtual env with it, tried to run the code again, and again the same issue happened. Then I opened this issue here.
To get the list of dependencies I ran a command called freeze.

Another question. Can I run this on a M2 Max with 32Gb ram in AWS? This was my plan 😀

We had another user run into this same issue wrt LlamaTokenizer. It appears there's a dependency on sentencepiece for this tokenizer. I've updated the requirements.txt file for inference to #25 to address this going forward.
@AllanOricil wrt to M2 Max, it's not on our exact roadmap but i believe this support was recently added in llama.cpp! :) https://github.com/ggerganov/llama.cpp/pull/7020
Closing issue for now as i think the main issue is now resolved.

I will give it another chance


⚠ Spryr has degraded performance

In fd97e9e, Spryr (https://spryr.com) experienced degraded performance:

HTTP code: 200
Response time: 6224 ms

Resolved: Spryr performance has improved in 42e907d after 22 minutes.


Jump to screen with no animation

Hi,
Please someone explain me how to do it.
Thanks,

Have you tried Actions.(yourScreenName)({ type: ActionsConst.REPLACE })
You must import { Actions, ActionsConst } from 'react-native-router-flux'
i.e: Actions.home({ type: ActionsConst.REPLACE })

Hi,
I tried this. and this is the error:

Hello, I am so sorry, it is ActionConst, not ActionsConst (mind the "s")

does not help. I used this RNRF before and for some reason this not the same syntax
import { Actions, ActionConst } from 'react-native-router-flux'
this is my code:
setTimeout(function() {
Actions.main({type: ActionConst.REPLACE})
},3000)

What's your version of RNRF? if it is beta.28, change it for beta.27.
npm uninstall --save react-native-router-flux
npm install --save<EMAIL_ADDRESS>

It is now has no Error but there is still animation from right to left. and I tried couple keywords like JUMP and PUSH.... no change

Then, try Actions.replace("main")

I tried this already... very strange...

If it is about the transitions, have a look at #2628 please :) You will find your answer here. Ask if you need anything else.

Yepp I reproduced, Actions.replace() seems to be broken with beta.28

It is on .28, it works on .27


Update health-checks.md

Re: https://github.com/mesosphere/marathon/issues/3946#issuecomment-231092920

Thanks!


Fix cleanup of old directories in ault Jenkins CI setup

This ports the same change as in https://github.com/pika-org/pika/pull/650.

bors merge


Browser Quick Switch displays 'Open undefined'

Steps to reproduce:

Turn on the 'Budget Quick Switch' option in extension settings and reload the budget page
Select the dropdown menu next to the budget name

What I expected to see:
At the top of the menu: 'Open other budget name' (this was working until one or two days ago)
What I saw instead:
At the top of the menu: 'Open undefined'
Selecting the 'Open undefined' link still opens the correct budget, but something is going on with the budget name.
Extension version: 2.31.2
Browser version: Google Chrome 89.0.4389.90 (Official Build) (x86_64)
OS version: macOS Big Sur 11.2.3

Having the same issue too

The other issue for this got closed but this will be in our next release.

Thank you again! it is now working

Yes, it's working, thank you!


List users of Threat Dragon

Describe what problem your feature request solves
@mike-goodwin  points out that it would be interesting to get a feel for who and how many people are using Threat Dragon
Describe the solution you'd like
@mike-goodwin suggests a new page in the github repo listing people using threat dragon. (e.g. like this https://github.com/argoproj/argo-cd/blob/master/USERS.md)
Additional context

@mike-goodwin Do we have a list of our users?

no list of users, and the only method we can think of is if companies contact us with an 'OK to use their name' for this page
We think it would be better to have a Threat  Dragon forum? a bit like OWASP ZAP's?


Adding a config to check if mix is running in a testing env

Why?
I've ran into some problems using the .extract() feature while running my frontend test suite. The best way to fix it is by disabling the extraction while running the tests:
"test": "cross-env NODE_ENV=testing mochapack --webpack-config=node_modules/laravel-mix/setup/webpack.config.js --require spec/frontend/setup.js spec/frontend/\\*\\*/\\*.spec.js --growl",

if (process.env.NODE_ENV !== 'testing') {
  mix.extract()
}

This PR adds a helper function to determine if Mix is running in the test env, so we can rewrite the above function as:
if (! mix.inTesting()) {
  mix.extract()
}

Let's stick with process.env.NODE_ENV for now. I'm not sure there's enough use-cases to add to the Mix API.


closes #3702 default column CSS

Description of the Change
Changed default CSS for <ul> elements to single column.
Created a "two-column-display" class as well for use if desired.
Alternate Designs
NA
Why should this be in core?
NA (already exists)
Benefits
Requested styling fix
Possible Drawbacks
Longer scroll down
Notes
Had to reinstall "wd" module to get tests to run completely and without error locally
Applicable issues
Fixes #3702
semver-patch

Coverage increased (+0.04%) to 91.159% when pulling 06ba8abc98af4205bc46afa46ef2d65bf8311bef on crossaaron:issue/3702 into d0cc3b2e43fe99b265edce8960d13b25d0c98be9 on mochajs:master.

I guess I'm a little stumped on how that would work as it shows up in the
deploy preview as desired,  but the deployed actual applies the 2 column
format.  Are you looking to nest the automatically generated content within
the ToC?
On Mon, Feb 4, 2019 at 11:04 AM Christopher Hiller<EMAIL_ADDRESS>wrote:

@boneskull requested changes on this pull request.
Thanks!
This doesn't quite solve the issue, because:
unless there's a way to specify the class in our markdown compiler (not
sure), just use html for the ones we keep. features and table of contents
are good to keep... not sure about the rest.
You can see that the features and ToC sections are not two-column on
the deploy preview
https://deploy-preview-3710--mocha.netlify.com/#features. To see
changes locally, run npm start docs and open up docs/_dist/index.html
with your browser. You can also do npm start docs.watch to rebuild as you
work (you'll still have to reload).
Since the table of contents is automatically generated, you'll need to
tweak the CSS so that it's applied to this section without using HTML.
You can base your selector on the previous heading (id=table-of-contents),
since that won't change. Might as well do the same for "Features", even
though it's not automatically generated...
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/mochajs/mocha/pull/3710#pullrequestreview-199753508,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AdPe4P8fcuxlF3zTsyyWkDcsUtszgtmyks5vKIQ_gaJpZM4agTnA
.

Append your class after last list item in "Features"
"/docs/index.md"
- [TextMate bundle](#textmate)
{:class="two-column-display"}

Two ways to do the TOC. See if @boneskull has preference...
Pick one or the other.

Modify "/scripts/markdown-magic.config.js", adding the class to TOC.

  toc: (content, options, config) => {
    const IGNORED_HEADINGS_REGEXP = /Features|Table of Contents/i;
    const toc = markdownToc(config.outputContent, {
      slugify: require('uslug'),
      bullets: options.bullets,
      firsth1: false,
      // if filter is supplied, maxdepth is apparently ignored,
      // so we have to do it ourselves.
      filter: (str, ele) => ele.lvl < 2 && !IGNORED_HEADINGS_REGEXP.test(str)
    }).content;
    return '\n' + toc + '\n' + '{:class="two-column-display"}' + '\n';
  },

Modify "/docs/css/style.css", adding CSS selector for TOC to existing "two column" definition

h2#table-of-contents + ul,
ul.two-column-display {
  column-gap: 30px;
  column-count: 2;
}

@boneskull,
Would like to get this done. Please state any implementation preference you have...

2nd option seems fine IMO, @boneskull sound ok to you?
@crossaaron are you able to fix this please?


Suggest adding:  page-break-after page-break-before

Suggest adding:
page-break-after
page-break-before

This issue was imported from Google Moderator
Moderator votes: +5
Issue added by raj on 2013-01-03
To vote this issue up or down, simply include +1 or -1 in your comment.

Duplicate of #982, transferring half the votes there.


Column 'product_database_engine' cannot be resolved

Hi,
I am trying to deploy the CUDOS dashboard and am hitting the following error where it cannot deploy the summary_view but it successfully deploys the 3 other required views.
I cannot see any errors in the cur, s3, iam, glue, athena or quicksight configs.
Missing views: summary_view 2022-08-04 10:04:43,239 - ERROR - cid.helpers.athena:execute_query:236 - Athena query failed: line 47:4: Column 'product_database_engine' cannot be resolved 2022-08-04 10:04:43,250 - ERROR - cid.helpers.athena:execute_query:237 - Failure reason: line 47:4 Column 'product_database_engine' cannot be resolved
I have followed the prerequisites as described here: https://wellarchitectedlabs.com/cost/200_labs/200_cloud_intelligence/cost-usage-report-dashboards/dashboards/1_prerequistes/

This is a known limitation described here

Duplicate: #45

does it not make sense to add this to the prerequisites?


Added the learn.md #5Issue

related to issue#5

@Varun-Sethi-Dev Add #5 in the description not in the title

@Varun-Sethi-Dev Add #5 in the description not in the title

done


Add examples to online documentation

There is currently some documentation on some of the examples, but this needs to be expanded.
Either:

Add a description of each example, following the format of the ones currently listed, and ideally including some figures
Have some form of automatically-generated list of examples, as there is in FLORIS

Of these, I think the former is likely easier since running WHOC/Hercules examples automatically could be tricky

In addressing this, we should also note that running the examples requires the additional installation of Hercules, which is not a strict dependency.


chore(example-app): Simplify how we demo ArtworkFilter

Addresses https://artsyproduct.atlassian.net/browse/WP-92
Looking at our example app artwork filter, I realized we could simplify the bare bones use-case quite a bit.

Going to merge this on 🍏 as there's something I need from it in my other PR! Can address any feedback / follow-up tomorrow.


fix incorrect remainder calculation in RateLimiter

In RateLimiter, the remainder is calculated like this:
let (new, remainder) = (
    elapsed.as_millis() / self.interval as u128,
    elapsed.as_nanos() % self.interval as u128 * 1_000_000,
);

It looks like remainder is treated as milliseconds. However, this seems off as it is shown later:
self.prev = now
    .checked_sub(Duration::from_nanos(remainder as u64))
    .unwrap();

remainder is actually used as nanoseconds.
By removing the multiply, it seems that the rate limiter is much more stable. See this MRV:
use std::time::Duration;

use indicatif::{ProgressDrawTarget, ProgressStyle};

fn main() {
    let pb = indicatif::ProgressBar::with_draw_target(Some(u64::MAX), ProgressDrawTarget::stdout_with_hz(1));
    pb.set_message(format!("Downloading"));
    pb.set_style(
        ProgressStyle::default_bar()
            .template("{msg}\n[{elapsed_precise}] {bytes}/{total_bytes}")
            .unwrap()
            .progress_chars("#>-"),
    );
    loop {
        pb.inc(1);
        std::thread::sleep(Duration::from_micros(1000));
    }
}

Before this fix:
https://github.com/console-rs/indicatif/assets/2109893/681e46ee-7a48-4c4f-87cd-18c088d68c4a
After this fix:
https://github.com/console-rs/indicatif/assets/2109893/8dfbb070-ccdf-4e35-9de2-154d137f6e0e

Well, and this may explain what is recorded in https://github.com/console-rs/indicatif/issues/452#issuecomment-1219670708.


Failing Test - "should successfully add a recipe to user's profile"

The following test is failing in testBookmarksAndUserProfiles.js: "should successfully add a recipe to user's profile".
See details below.

Test appears to have been fixed as of pull request #35
Cause is unknown, but likely had overlap with another bug that was fixed


dashed-case conversion doesn't work for mixed case

Defining the following parameter:
        - in: header
          name: X-Auth-User
          type: integer
          format: int64
          required: true

yields the following argument:
`x-Auth-User`: Long

whereas altering the case to
        - in: header
          name: x-auth-user
          type: integer
          format: int64
          required: true

generates
xAuthUser: Long

I just ran into this as well. This causes Java to not even compile since it can't do a string literal for the name.
[ERROR] Error: Unable to parse 'x-Actor' to a com.github.javaparser.ast.expr.Name: Encountered unexpected token: "-" "-"
    at line 1, column 2.

Was expecting:

    <EOF>

I think https://github.com/twilio/guardrail/issues/264 may have fixed this for Java

going to do a release later today; If you wouldn't mind running cli.sh with relevant arguments against master to verify the fix, that'd be appreciated!

Doesn't look like it. I just modified issue148.yaml to use X-Header/X-Optional-Header instead of lowercase and javaTestSuite failed with the same error.
Error: Unable to parse 'x-Header' to a com.github.javaparser.ast.expr.Name: Encountered unexpected token: "-" "-"
    at line 1, column 2.

Was expecting:

    <EOF>


DOC: Add a doc page detailing advantages (and disadvantages?) vs. TF skelarn wrappers

A basic question that users might ask before even trying SciKeras or reading the docs is: why should I use SciKeras over tf.keras.wrappers.scikit_learn?
To answer this, I think we should put 5-6 bullet points on our README.md as well as docs.

Some ideas:

SciKeras is actively maintained; the tensorflow wrappers may be deprecated.
Detailed documentation.
Full compatibility with the Scikit-Learn API, including grid searches, ensembles, transformers, etc.
Support for pre-trained models.
Support for dynamic input/output sizes.
Support for hyperparameter tuning for estimators and losses.
Support for multi-input and multi-ouput Keras models.
Functional random_state for reproducible training.

What downsides are there to using SciKeras? Does distributed training work with SciKeras?
I ask because I saw someone (@2over12?) looking to parallelize Keras training with Dask. They report that they...

use[d] the keras scipy wrapper and a backing distributed optimization strategy MirroredStrategy] then use incremental training on it and it just works
... [s]o essentially what is happening as I understand it now [is that] the keras model fit is transparently splitting up a batch to each [model] replica and then syncing up gradients

This required both a TF cluster and a Dask cluster on the same set of machines. I think an example would be really useful to see.

This comparison was, specifically, to the old wrappers. I think a comparison to using Pure Keras (i.e. where does SciKeras break down) is warranted but can be done separately.
Regarding distributed training, I do not have much experience with it. Out of context, I do not really understand the above quote/comment, can you link to the full discussion? It sounds like an interesting use. If you would like to write something up regarding distributed training, I am more than happy to accept the contribution.

So I guess this is in regards to the dask training with multiple gpus. I've reproduce the mnist scikeras stuff from here https://ml.dask.org/keras.html with local mirroring two the devices gpus. I believe it should be possible to also do this with https://www.tensorflow.org/api_docs/python/tf/distribute/experimental/MultiWorkerMirroredStrategy to run the model across multiple workers. It's pretty nice since with scikeras we can integrate directly into the dask preprocessing pipelines and take advantage of incremental hyper-parameter search  as well as sklearn stuff.
It's also worth noting the current page on dask+scikeras has an incorrect loss function https://www.tensorflow.org/tutorials/distribute/keras but that issue probably needs to be opened on the dask side.
import tensorflow as tf
from tensorflow.keras.layers import Dense
from tensorflow.keras.models import Sequential
from scikeras.wrappers import KerasClassifier
from tensorflow.keras.datasets import mnist
from tensorflow.keras.utils import to_categorical
import numpy as np
from typing import Tuple
import dask_ml
from dask import array
import dask
#reference: https://www.tensorflow.org/tutorials/distribute/keras

def build_model(lr=0.01, momentum=0.9):
    # create a default mirror strategy which will have a device per gpu
    strat = tf.distribute.MirroredStrategy()
    with strat.scope():
        layers = [Dense(512, input_shape=(784,), activation="relu"),
                Dense(10, input_shape=(512,), activation="softmax")]
        model = Sequential(layers)

        opt = tf.keras.optimizers.SGD(
            learning_rate=lr, momentum=momentum, nesterov=True,
        )
        model.compile(loss="sparse_categorical_crossentropy", optimizer=opt, metrics=['accuracy'])
    return model

def get_mnist() -> Tuple[np.ndarray, np.ndarray]:
    (X_train, y_train), _ = mnist.load_data()
    X_train = X_train.reshape(X_train.shape[0], 784)
    X_train = X_train.astype("float32")
    X_train /= 255
    return X_train, y_train

if __name__ == "__main__":
    dask.distributed.Client()

    X,y = get_mnist()
    model = KerasClassifier(build_fn=build_model, lr=0.1, momentum=0.9)
    inc_mod = dask_ml.wrappers.Incremental(model)
    X=array.from_array(X,chunks=10000)
    y=array.from_array(y,chunks=10000)

    inc_mod.fit(X,y)

To be honest, I'm not sure what the differences/advantages to TF's distributed functionalities might be over Dask's. But I think this may be a good example of why it's important to build an ecosystem with consistent APIs: you get solutions to complex problems like this for free.

Woah https://github.com/adriangb/scikeras/issues/132#issuecomment-735031792 is interesting. What's the data flow exactly? If I'm reading it correctly, the following happens:

Dask creates (say) 32 models.
Every model is sent to (say) 4 GPUs
Dask controls which models get fit.
Fitting one model with batch size (say) 256:

Each worker computes 64 gradients.
There's a synchronous distributed/all-reduce parameter server (PS) between GPUs (MultiWorkerMirroredStrategy)

Correct me if I'm wrong. I don't see any GPU-specific code to put the model on the GPU, but it looks like the distributed strategy takes care of that: https://keras.io/guides/distributed_training/
Also, [dask-cuda] might be useful if you want to limit the number of models per GPU.

I'm not sure what the differences/advantages to TF's distributed functionalities might be over Dask's

It looks like they're operating independently in https://github.com/adriangb/scikeras/issues/132#issuecomment-735031792. From Dask's point of view, model is on the CPU and calling model.fit is a normal CPU operation. However, Keras handles putting model.fit on the GPU and the parallelism (with the data flow above). Is that accurate @2over12?

@stsievert  Yeah so not quite. Dask Incremental executes a single model in serial. Each fitting task on each block of the array is intentionally dependent on the previous model fit. Dask would have no way to merge separate models if we executed many models in parallel (you could group these models into an ensemble with something like ensemble.BlockwiseVotingClassifier but generally I'd prefer a single model that has seen all the data). So what's happening here is dask workers can be used to create the dask array and preform transformations in parallel. In our use-case we use these workers to read in a dataframe and transform it into the x and y array as well as do some last minute transformations before training. Then each serial fit task gets fed chunks as they are available. So essentially it is a many to 1 relationship where the are many workers generating and manipulating chunks and 1 worker running the model. The distributed strategy then lets us explode out each of these serial training tasks into parallelized training where batches are split up between the gpus. So as you said if you have 4 GPUs and a 256 batch size each GPU runs 64 samples on the model and computes gradients which are merged to do the final updates. I believe you could replace tf.distribute.MirroredStrategy() with the multiworker strategy in order to explode out the batch fitting to a multinode setup of gpus.
It's worth noting the mirrored strategies in tensorflow are generally going to be a bit slower than something like horovod https://github.com/horovod/horovod where models do not require synchronization and instead the average of each worker's gradient is applied to each variable. Horovod however would be annoying to integrate with dask due to how it spins up it's own clusters etc. Ideally we would have the capability to run some distributed SGD in dask like as done in spark and here https://zhangyuc.github.io/splash/ but tensorflow mirrored strategies are a decent start