Can't get it to work with external measured data

Hi,
I have problems getting any average with external angle data.    I have the AS5600 sensor that gives 12bit readings for the angle.
I have tried both your libraries, runningAngle and AverageAngle but failed to get it to calculate any average.
I am pretty sure that it's my fault as I am quite new to this.
My code:
runningAngle222.zip
Would appreciate any help

Thanks for the issue,
I will dive into it next week as my agenda is quite full (150++ libs to maintain)
You can also post it on the Arduino forum as there are more people that might be able to help you,

Just had a look at the code

I cannot compile as I do not have a AMS_5600 device (in fact I don't know it)
What board are you using?
What is the error message you get when you compile?

Stripped all angle math from your sketch as I think you just don't get data from the device
Does this stripped version generate data?

#include <AS5600.h>

AMS_5600 ams5600;//ACT

void setup()
{
  Serial.begin(115200);
  Wire.begin(12,2);
}

void loop()
{
  int a0 = (4095 - ams5600.getRawAngle())*0.0879;
  Serial.println(a0);
  delay(100);
}

if not, your problem is in the AMS_5600 code.
(please post part of the output)

Hi,
thanks for the prompt response,
The Board is a NodeMCU
I get good readings from the AS5600.  The AS5600 is a magnetic direction Sensor (very practical,  you should definitely look into it)
My main project is an Anemometer with a windvane.
The library for the AS5600: https://github.com/Seeed-Studio/Seeed_Arduino_AS5600
The AS5600 website: https://ams.com/en/as5600
Some output:
13:08:57.407 -> heading  -   281.00/   a0  -   281/   smoothed  -   281.00
13:08:57.509 -> heading  -   281.00/   a0  -   281/   smoothed  -   281.00
13:08:57.610 -> heading  -   281.00/   a0  -   281/   smoothed  -   281.00
13:08:57.711 -> heading  -   289.00/   a0  -   289/   smoothed  -   289.00
13:08:57.813 -> heading  -   300.00/   a0  -   300/   smoothed  -   300.00
13:08:57.915 -> heading  -   312.00/   a0  -   312/   smoothed  -   312.00
13:08:58.017 -> heading  -   328.00/   a0  -   328/   smoothed  -   328.00
13:08:58.119 -> heading  -   353.00/   a0  -   353/   smoothed  -   353.00
13:08:58.221 -> heading  -   8.00/   a0  -   8/   smoothed  -   8.00
13:08:58.323 -> heading  -   20.00/   a0  -   20/   smoothed  -   20.00
13:08:58.425 -> heading  -   25.00/   a0  -   25/   smoothed  -   25.00
13:08:58.527 -> heading  -   29.00/   a0  -   29/   smoothed  -   29.00
13:08:58.629 -> heading  -   32.00/   a0  -   32/   smoothed  -   32.00
13:08:58.731 -> heading  -   33.00/   a0  -   33/   smoothed  -   33.00
13:08:58.833 -> heading  -   29.00/   a0  -   29/   smoothed  -   29.00
13:08:58.935 -> heading  -   7.00/   a0  -   7/   smoothed  -   7.00
13:08:59.037 -> heading  -   352.00/   a0  -   352/   smoothed  -   352.00
13:08:59.139 -> heading  -   344.00/   a0  -   344/   smoothed  -   344.00
13:08:59.207 -> heading  -   332.00/   a0  -   332/   smoothed  -   332.00
13:08:59.308 -> heading  -   326.00/   a0  -   326/   smoothed  -   326.00
13:08:59.409 -> heading  -   319.00/   a0  -   319/   smoothed  -   319.00
13:08:59.511 -> heading  -   313.00/   a0  -   313/   smoothed  -   313.00
13:08:59.613 -> heading  -   307.00/   a0  -   307/   smoothed  -   307.00
13:08:59.715 -> heading  -   300.00/   a0  -   300/   smoothed  -   300.00
13:08:59.817 -> heading  -   293.00/   a0  -   293/   smoothed  -   293.00

I can run this library without problems:
https://gitlab.com/yesbotics/libs/arduino/average-value
obviously it does not work if the averaged data passes 359-1  but other than that it works.  (If that helps maybe to find out the difference)

please give this a try and post its output:
#include <AS5600.h>//ACT
#include <Wire.h>

//#include <AverageAngle.h>
#include <runningAngle.h>

AMS_5600 ams5600;//ACT

//  GLOBAL VARIABLES EXIST OUTSIDE FUNCTIONS
runningAngle heading(runningAngle::DEGREES);//optional

void setup()
{
  // put your setup code here, to run once:
  Serial.begin(115200);
  Wire.begin(12,2);

  // only need to configure this once.
  heading.setWeight(0.1);
}

void loop()
{
  // MEASUREMENTS & MATH
  int raw = ams5600.getRawAngle();
  int a0 = 4095 - raw;
  float windcounts = a0 *0.0879 ;
  float smoothed_heading = heading.add(windcounts);

  // OUTPUT
  Serial.print("heading: ");
  Serial.print(heading.getAverage(), 1);
  Serial.print("\traw: ");
  Serial.print(raw);
  Serial.print("\ta0: ");
  Serial.print(a0);
  Serial.print("\twindcounts: ");
  Serial.print(windcounts, 1);
  Serial.print("\tsmoothed: ");
  Serial.print(smoothed_heading, 1);
  Serial.println();

  delay(100);
}

I can run this library without problems: https://gitlab.com/yesbotics/libs/arduino/average-value

That is a simple average of N numbers, it does not take into account that angles are on an (infinite) circle.

4:46:00.717 -> heading: 11.9	raw: 3961	a0: 134	windcounts: 11.8	smoothed: 11.9
14:46:00.818 -> heading: 11.9	raw: 3961	a0: 134	windcounts: 11.8	smoothed: 11.9
14:46:00.920 -> heading: 11.9	raw: 3960	a0: 135	windcounts: 11.9	smoothed: 11.9
14:46:01.022 -> heading: 11.9	raw: 3959	a0: 136	windcounts: 12.0	smoothed: 11.9
14:46:01.124 -> heading: 12.1	raw: 3934	a0: 161	windcounts: 14.2	smoothed: 12.1
14:46:01.226 -> heading: 12.9	raw: 3870	a0: 225	windcounts: 19.8	smoothed: 12.9
14:46:01.328 -> heading: 14.0	raw: 3815	a0: 280	windcounts: 24.6	smoothed: 14.0
14:46:01.430 -> heading: 15.5	raw: 3767	a0: 328	windcounts: 28.8	smoothed: 15.5
14:46:01.532 -> heading: 17.2	raw: 3725	a0: 370	windcounts: 32.5	smoothed: 17.2
14:46:01.633 -> heading: 19.2	raw: 3675	a0: 420	windcounts: 36.9	smoothed: 19.2
14:46:01.735 -> heading: 21.1	raw: 3657	a0: 438	windcounts: 38.5	smoothed: 21.1
14:46:01.837 -> heading: 22.9	raw: 3652	a0: 443	windcounts: 38.9	smoothed: 22.9
14:46:01.939 -> heading: 24.5	raw: 3654	a0: 441	windcounts: 38.8	smoothed: 24.5
14:46:02.041 -> heading: 25.9	raw: 3655	a0: 440	windcounts: 38.7	smoothed: 25.9
14:46:02.142 -> heading: 27.2	raw: 3657	a0: 438	windcounts: 38.5	smoothed: 27.2
14:46:02.244 -> heading: 28.3	raw: 3658	a0: 437	windcounts: 38.4	smoothed: 28.3
14:46:02.346 -> heading: 29.3	raw: 3658	a0: 437	windcounts: 38.4	smoothed: 29.3
14:46:02.448 -> heading: 30.2	raw: 3658	a0: 437	windcounts: 38.4	smoothed: 30.2
14:46:02.549 -> heading: 31.0	raw: 3658	a0: 437	windcounts: 38.4	smoothed: 31.0
14:46:02.651 -> heading: 31.8	raw: 3658	a0: 437	windcounts: 38.4	smoothed: 31.8
14:46:02.753 -> heading: 32.4	raw: 3658	a0: 437	windcounts: 38.4	smoothed: 32.4
14:46:02.855 -> heading: 33.0	raw: 3658	a0: 437	windcounts: 38.4	smoothed: 33.0
14:46:02.957 -> heading: 33.6	raw: 3658	a0: 437	windcounts: 38.4	smoothed: 33.6
14:46:03.059 -> heading: 34.1	raw: 3658	a0: 437	windcounts: 38.4	smoothed: 34.1
14:46:03.160 -> heading: 34.5	raw: 3658	a0: 437	windcounts: 38.4	smoothed: 34.5
14:46:03.262 -> heading: 34.9	raw: 3657	a0: 438	windcounts: 38.5	smoothed: 34.9
14:46:03.363 -> heading: 35.2	raw: 3658	a0: 437	windcounts: 38.4	smoothed: 35.2
14:46:03.465 -> heading: 35.6	raw: 3658	a0: 437	windcounts: 38.4	smoothed: 35.6
14:46:03.567 -> heading: 35.8	raw: 3658	a0: 437	windcounts: 38.4	smoothed: 35.8
14:46:03.669 -> heading: 36.1	raw: 3658	a0: 437	windcounts: 38.4	smoothed: 36.1
14:46:03.771 -> heading: 36.3	raw: 3658	a0: 437	windcounts: 38.4	smoothed: 36.3
14:46:03.872 -> heading: 36.5	raw: 3659	a0: 436	windcounts: 38.3	smoothed: 36.5
14:46:03.974 -> heading: 36.7	raw: 3659	a0: 436	windcounts: 38.3	smoothed: 36.7
14:46:04.075 -> heading: 36.9	raw: 3659	a0: 436	windcounts: 38.3	smoothed: 36.9
14:46:04.177 -> heading: 37.0	raw: 3659	a0: 436	windcounts: 38.3	smoothed: 37.0
14:46:04.279 -> heading: 37.1	raw: 3659	a0: 436	windcounts: 38.3	smoothed: 37.1
14:46:04.380 -> heading: 37.3	raw: 3659	a0: 436	windcounts: 38.3	smoothed: 37.3
14:46:04.481 -> heading: 37.4	raw: 3659	a0: 436	windcounts: 38.3	smoothed: 37.4
14:46:04.582 -> heading: 37.5	raw: 3659	a0: 436	windcounts: 38.3	smoothed: 37.5
14:46:04.684 -> heading: 37.6	raw: 3659	a0: 436	windcounts: 38.3	smoothed: 37.6
14:46:04.785 -> heading: 37.6	raw: 3666	a0: 429	windcounts: 37.7	smoothed: 37.6
14:46:04.887 -> heading: 37.4	raw: 3685	a0: 410	windcounts: 36.0	smoothed: 37.4
14:46:04.988 -> heading: 37.1	raw: 3701	a0: 394	windcounts: 34.6	smoothed: 37.1
14:46:05.090 -> heading: 36.9	raw: 3704	a0: 391	windcounts: 34.4	smoothed: 36.9
14:46:05.158 -> heading: 36.6	raw: 3705	a0: 390	windcounts: 34.3	smoothed: 36.6
14:46:05.259 -> heading: 36.4	raw: 3704	a0: 391	windcounts: 34.4	smoothed: 36.4

Does this output match your expectations?

Unfortunately not.   İt doesn't seem to work if you look at the numbers.

What do you expect to see in the numbers?
Smoothed does follow windcounts but in a tempered way.
You might need to "play" with the   heading.setWeight(0.1); line e.g. make it 0.5

@ahmetcemturan: You are instantiating a runningAngle object in loop(), which means that, on each loop iteration you have a brand new instance of this averaging object. This cannot work: the whole idea of averaging relies on something that has some “memory” of the past inputs, in order to average them with the current input. By creating a new runningAngle for each data input, you prevent that “memory” to be carried over from a reading to the next. This is why you get no averaging at all: the object has no “past” to average its input with.
You should instead instantiate the object at global scope. If you need to initialize it (e.g. with setWeight()), do it once and only once, in setup(). Then, in loop(), call add() for one reading.

Thank you soo much.  It works and I have already inserted it into the main code.
One question instead of +-180 degrees I need 0-359 for the weather station.  I implemented it with if...  Result negative, add to 360.  İt works but is there a way in the library for this?  I also think that both of your libraries need to be mentioned in the as5600 git as they are really practical solutions...
Thanks again.

Thank you too for the explanation.  Very obvious when You read it.

İt works but is there a way in the library for this?

No, the library has no support for such functionality.
It would imply to have the following functions added to the library

setOffset(float angle = 0) - note that angle can be interpreted as DEGREES or RADIANS
float getOffset() to see the current offset.

This could be worth the effort (4 bytes RAM float _offset; , max 10 lines of code).

it would adjust the range to 0 .. 360 as you needed
it would allow to adjust between magnetic north and absolute north (when used with compass sensor)
maybe more

On the other hand it is very easy to add the needed offset code like you did.
So I won't add offset functions to the library.

@ahmetcemturan
If there are no further questions you may close the issue.

@ahmetcemturan
I had a look at the AS5600 and it looks indeed interesting.
In fact interesting enough to write a library today - https://github.com/RobTillaart/AS5600

I definitely will try it out.
Also if You have ordered a sensor make sure it is shipped with its specially polarised magnet..


Disable check snapshots temporarily

Purpose

Disable check snapshots temporarily

Codecov Report

Merging #16306 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #16306   +/-   ##
=========================================
  Coverage     20.57%   20.57%
  Complexity     1844     1844
=========================================
  Files           641      641
  Lines         28010    28010
  Branches       3916     3916
=========================================
  Hits           5762     5762
  Misses        21634    21634
  Partials        614      614

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8355037...98fdcd1. Read the comment docs.


'LightningShardedDataParallel' object has no attribute 'require_backward_grad_sync'

When trying to use sharded DDP with the latest Lightning version 1.2.6 and Fairscale 0.3.3, I get the following error. Note that I am also using manual optimization and disabling automatic, as I am training a GAN.
Traceback (most recent call last):
  File "run_train.py", line 41, in train
    trainer.fit(model, data_loader)
  File "/home/timbrooks/anaconda3/envs/human_gan_fairseq/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 499, in fit
    self.dispatch()
  File "/home/timbrooks/anaconda3/envs/human_gan_fairseq/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 546, in dispatch
    self.accelerator.start_training(self)
  File "/home/timbrooks/anaconda3/envs/human_gan_fairseq/lib/python3.8/site-packages/pytorch_lightning/accelerators/accelerator.py", line 73, in start_training
    self.training_type_plugin.start_training(trainer)
  File "/home/timbrooks/anaconda3/envs/human_gan_fairseq/lib/python3.8/site-packages/pytorch_lightning/plugins/training_type/training_type_plugin.py", line 114, in start_training
    self._results = trainer.run_train()
  File "/home/timbrooks/anaconda3/envs/human_gan_fairseq/lib/python3.8/site-packages/pytorch_lightning/trainer/trainer.py", line 637, in run_train
    self.train_loop.run_training_epoch()
  File "/home/timbrooks/anaconda3/envs/human_gan_fairseq/lib/python3.8/site-packages/pytorch_lightning/trainer/training_loop.py", line 492, in run_training_epoch
    batch_output = self.run_training_batch(batch, batch_idx, dataloader_idx)
  File "/home/timbrooks/anaconda3/envs/human_gan_fairseq/lib/python3.8/site-packages/pytorch_lightning/trainer/training_loop.py", line 657, in run_training_batch
    self._curr_step_result = self.training_step(
  File "/home/timbrooks/anaconda3/envs/human_gan_fairseq/lib/python3.8/site-packages/pytorch_lightning/trainer/training_loop.py", line 293, in training_step
    training_step_output = self.trainer.accelerator.training_step(args)
  File "/home/timbrooks/anaconda3/envs/human_gan_fairseq/lib/python3.8/site-packages/pytorch_lightning/accelerators/accelerator.py", line 156, in training_step
    return self.training_type_plugin.training_step(*args)
  File "/home/timbrooks/anaconda3/envs/human_gan_fairseq/lib/python3.8/site-packages/pytorch_lightning/plugins/training_type/ddp.py", line 297, in training_step
    return self.model(*args, **kwargs)
  File "/home/timbrooks/anaconda3/envs/human_gan_fairseq/lib/python3.8/site-packages/torch/nn/modules/module.py", line 889, in _call_impl
    result = self.forward(*input, **kwargs)
  File "/home/timbrooks/anaconda3/envs/human_gan_fairseq/lib/python3.8/site-packages/fairscale/nn/data_parallel/sharded_ddp.py", line 223, in forward
    return self.module(*inputs, **kwargs)
  File "/home/timbrooks/anaconda3/envs/human_gan_fairseq/lib/python3.8/site-packages/torch/nn/modules/module.py", line 889, in _call_impl
    result = self.forward(*input, **kwargs)
  File "/home/timbrooks/anaconda3/envs/human_gan_fairseq/lib/python3.8/site-packages/pytorch_lightning/overrides/base.py", line 48, in forward
    output = self.module.training_step(*inputs, **kwargs)
  File "/home/timbrooks/code/human_gan/models/human_gan.py", line 121, in training_step
    self._discriminator_step(real_image, keypoints)
  File "/home/timbrooks/code/human_gan/models/human_gan.py", line 182, in _discriminator_step
    self.manual_backward(loss, optimizer)
  File "/home/timbrooks/anaconda3/envs/human_gan_fairseq/lib/python3.8/site-packages/pytorch_lightning/core/lightning.py", line 1228, in manual_backward
    self.trainer.train_loop.backward(loss, optimizer=None, opt_idx=None, *args, **kwargs)
  File "/home/timbrooks/anaconda3/envs/human_gan_fairseq/lib/python3.8/site-packages/pytorch_lightning/trainer/training_loop.py", line 782, in backward
    self.trainer.accelerator.backward(result, optimizer, opt_idx, should_accumulate, *args, **kwargs)
  File "/home/timbrooks/anaconda3/envs/human_gan_fairseq/lib/python3.8/site-packages/pytorch_lightning/accelerators/accelerator.py", line 254, in backward
    self.training_type_plugin.pre_backward(closure_loss, should_accumulate, optimizer, optimizer_idx)
  File "/home/timbrooks/anaconda3/envs/human_gan_fairseq/lib/python3.8/site-packages/pytorch_lightning/plugins/training_type/ddp.py", line 283, in pre_backward
    if not self.lightning_module.automatic_optimization and self.model.require_backward_grad_sync:
  File "/home/timbrooks/anaconda3/envs/human_gan_fairseq/lib/python3.8/site-packages/fairscale/nn/data_parallel/sharded_ddp.py", line 362, in __getattr__
    return getattr(self.module, name)
  File "/home/timbrooks/anaconda3/envs/human_gan_fairseq/lib/python3.8/site-packages/torch/nn/modules/module.py", line 947, in __getattr__
    raise AttributeError("'{}' object has no attribute '{}'".format(
AttributeError: 'LightningShardedDataParallel' object has no attribute 'require_backward_grad_sync'

@SeanNaren is the correct fix here to just not access self.model.require_backward_grad_sync in the sharded plugin?


Flutter install issue

On using Flutter Install in Azure Devops server 2019 CI/CD pipeline, i am getting the following error when i choose Flutter custom version 3.3.9. When i use latest version i am not receiving this error.  Unfortunately i need this specific version. Can someone guide me in solving this error.
##[section]Starting: Flutter Install
==============================================================================
Task         : Flutter Install Task
Description  : Install the Flutter environment.
Version      : 0.3.5
Author       : Hey24sheep
Help         : For more information, take a look at the Flutter [documentation](https://flutter.io)
==============================================================================
Downloading: https://storage.googleapis.com/flutter_infra_release/releases/stable/windows/flutter_windows_3.3.9-stable.zip
Extracting archive
[command]C:\Windows\system32\chcp.com 65001
Active code page: 65001
[command]C:\Windows\System32\WindowsPowerShell\v1.0\powershell.exe -NoLogo -Sta -NoProfile -NonInteractive -ExecutionPolicy Unrestricted -Command "$ErrorActionPreference = 'Stop' ; try { Add-Type -AssemblyName System.IO.Compression.FileSystem } catch { } ; [System.IO.Compression.ZipFile]::ExtractToDirectory('C:\DevOpsBuildAgent\_work\_temp\d1ad7440-a550-4801-aba6-0cc51ef1cf60', 'C:\DevOpsBuildAgent\_work\_temp\7339e4f1-5825-4cfb-ba35-a31a3ee62ce1')"
Exception calling "ExtractToDirectory" with "2" argument(s): "Could not find a part of the path 'C:\DevOpsBuildAgent\_w
ork\_temp\7339e4f1-5825-4cfb-ba35-a31a3ee62ce1\flutter\.pub-cache\hosted\pub.dartlang.org\flutter_plugin_android_lifecy
cle-2.0.6\example\android\app\src\androidTest\java\io\flutter\plugins\flutter_plugin_android_lifecycle\MainActivityTest
.java'."
At line:1 char:111
+ ... catch { } ; [System.IO.Compression.ZipFile]::ExtractToDirectory('C:\D ...
+                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (:) [], ParentContainsErrorRecordException
    + FullyQualifiedErrorId : DirectoryNotFoundException

##[error]Error: The process 'C:\Windows\System32\WindowsPowerShell\v1.0\powershell.exe' failed with exit code 1
##[section]Finishing: Flutter Install

Are you running this on Local Agent or Hosted Agent?
It's showing you the error "C:\DevOpsBuildAgent\", Directory not found. If you are running local agent, check your directories. If it's hosted agent, then try running default Install first, see if that works or not.

Hi, is this issue fixed. It will get closed soon as stale-inactive.

I just encountered this issue as well, using hosted Azure DevOps with a local agent, Flutter Install Task version 0.3.6 trying to install Flutter 3.3.10.
The problem is that older versions of Flutter appear to have a .pub-cache folder containing a cache of packages (I assume... I'm not a Flutter dev, just trying to get some Flutter code building for someone else). The problem is that the path of the file mentioned exceeds 260 characters when it's extracted into the agent's Temp directory, in my case the total path length is 263 characters. This causes the call to [System.IO.Compression.ZipFile]::ExtractToDirectory to fail with the above error. The really frustrating thing is that it appears to just be an example project that's included in this particular package, so not likely something we'd even need when doing a build, even if we happen to be using that package.
Newer versions have a .pub-preload-cache folder that is similar, but all the packages are zipped up so it's not a problem.
Strangely if I look in the tool cache for a newer version of Flutter that successfully installed (e.g., 3.10.1), the .pub-preload-cache folder doesn't exist, but I can't see that it's skipped when caching the tool. Not sure how to explain that one.
Let me know if you need more info / want logs / etc.

@nick-gallimore Wow, that's really interesting. Thanks for the insight into this issue, really appreciate it.
I think that is an issue from Flutter's side. You can open this issue on their repository and tag this issue there. I will close it here as it is not related to this extension directly and it has been stale since Feb 28th 2023.


Rare onLocationChanged events on iOS

Running the module 0.2.0-alpha.5 with RN 0.33 on the iPhone6 simulator (iOS 10) I have very rare onLocationChanged events. I would like to get them every 5 meters. Or, ideally, every 1 second, but this is not available under iOS, as I got from the readme. The configure options are:
desiredAccuracy: 0,
stationaryRadius: 0,
distanceFilter: 5,

For the testing purposes I use "City bicycle ride" gps mode.
In average I have the event push on every 40 meters. I also see the following lines in the logs rather often (several times more often than I have the event fired):
<Warning>: LocationManager updated distanceFilter, new: 30.000000, old: 105.000000
...
<Error>: LocationManager#flushQueue has to kill an out-standing background-task!
<Warning>: LocationManager#sync Location: id=-5764607523034207997 time=105553124672096 lat=37.33193356 lon=-122.03785871 accu=5 aaccu=-1 speed=7.6 head=93.40000000000001 alt=0 type=current
...
<Warning>: LocationManager updated distanceFilter, new: 25.000000, old: 100.000000
<Error>: LocationManager#flushQueue has to kill an out-standing background-task!

Is this something wrong with the configuration?

I have to add that I have message like
<Warning>: Better location found: Location: id=0 time=106102880514304 lat=37.33759314 lon=-122.03673258 accu=10 aaccu=-1 speed=7.19 head=270.41 alt=0 type=current

In the log every second. I am not sure about the source of this message, but that means that something is getting the location updates much more often. Ideally, I would like to get them all as well.

That warning is fine (should not be warning at all), it is just comparing received location with previous one.
Also you get every seconds, because that's how often you're receiving location updates.
You will not receive location every x minutes, because plugin is recalculating distanceFilter. That's the whole point of existence. You can read more about it:
https://github.com/mauron85/cordova-plugin-background-geolocation/blob/master/ANDROID_DISTANCE_FILTER_PROVIDER.md#distancefilter

it does not matter what value you set, it will be auto recalculated when new position is recieved. Currently it is not possible to disable it. There is ongoing discussion about creating bare version of the plugin instead.
https://github.com/mauron85/cordova-plugin-background-geolocation/issues/124

I see... Thanks for the explanation!

Notice: this issue has been closed because it has been inactive for 219 days. You may reopen this issue if it has been closed in error.


Add more resources

I forget to add iOS Dev Directory done by Dave Verwer, which listed a lot of cool learning resources and iOS content sites. Plus one very active Facebook group for iOS devs.

          2 Warnings

:warning:
Too many changes (when adding, please keep it to one project per Pull Request)

:warning:
Found 1 link issue, a project collaborator will take care of these, thanks :)

Link issue by awesome_bot

Line
Status
Link

2928
301
http://www.pixate.com/ redirects tohttp://www.pixate.com/

  Generated by :no_entry_sign: Danger

Too many changes. Please make one change per PR.
Thanks you.


Support metrics aggregation in Ray runner

Related Issue: https://github.com/ray-project/ray_beam_runner/issues/47
This PR implemented the metrics aggregation in the Ray runner. Supported metrics include:

user-defined element-count metrics, e.g., counter, gauge, distribution (min, max, avg, etc)
non-user metrics, e.g., start_bundle_msecs, total_msecs, etc

The PR also provides an example using user-defined metrics in word-count.
To run the example:
python examples/word_count_metrics.py --input input.txt
With a random generated input.txt, the expected output should be like:
Ray Runner--------------->
number of empty lines:98
average word length:4.18
min word length: 1
max word length: 14
Direct Runner--------------->
number of empty lines:98
average word length:4.18
min word length: 1
max word length: 14

this is really great. Thanks! : )


Allow interactive update despite exact versions

If all my packages are pinned to exact versions, running npx npm-check -u returns with the following:
❤  Your modules look amazing. Keep up the great work. ❤
I'm not sure if this is the intended behavior of -u option.
However, if there multiple new versions available, it would nice if npm-check could offer a way to upgrade the packages via the interactive CLI so that they don't have to be explicitly upgraded through npm i -E ...@latest.

Seeing the same thing here:
npx npm-check -u
❤  Your modules look amazing. Keep up the great work. ❤

Output using npm-check-updates:
npx npm-check-updates

 react                 ^18.0.0  →   ^18.2.0
 react-dom             ^18.0.0  →   ^18.2.0
 @types/react          ^18.0.0  →  ^18.0.14
 @types/react-dom      ^18.0.0  →   ^18.0.5
 @vitejs/plugin-react   ^1.3.0  →    ^1.3.2
 typescript             ^4.6.3  →    ^4.7.4
 vite                   ^2.9.9  →   ^2.9.12

Run npx npm-check-updates -u to upgrade package.json


dropping cmake3 in favor of cmake found on centos7

Summary of proposed changes:

dropping cmake3 in favor of cmake because centos7 (7.4.1708 in my case) does not install cmake3 from the repos

cmake3 is a requirement to build the library, are you not able to yum install cmake3?

Ah sorry my mistake, my centos7 install has EPEL and others enabled.
This brought in a cmake binary which was 3.5 and hence the script
didn't work.

you would wanna check the version of cmake and only take the one that yields cmake or higher. Quite some effort, when a more clean documentation of the cmake variables would do the trick.


TuneIn [PCSB00407]

Game summary

Game name: TuneIn
Game serial: PCSB00407

Vita3K summary

Version: v0.1
Build number: 242-01946ef
Commit hash: https://github.com/vita3k/vita3k/commit/01946ef

Test environment summary

Tested by: HorrorTroll
OS: Windows 8.1
CPU: Intel Core i5-4200H
GPU: Nvidia Geforce GTX 950M
RAM: 6 GB DDR3

Issues

Crash
Screenshots
Not for moment
Log
vita3k.log
Recommended labels

Crash

Vita3K summary

Version: v0.1
Build number: 1737
Commit hash: https://github.com/vita3k/vita3k/commit/ec3eaab4

Screenshots

Log
vita3k.log

Vita3K summary

Version: v0.1.5
Build number: 2630
Commit hash: https://github.com/vita3k/vita3k/commit/18dacae2
CPU backend: Dynamic

Test environment summary

Tested by: othmanead
OS: Windows 11
CPU: Intel i5-10300H
GPU: RTX 3060 mobile
RAM: 16 GB

Issue:

Game goes to intro but needs an internet connection

Screenshots:

Log
vita3k.log
Recommended labels

Intro


Not supporting look-arounds in Regex.

Logos is currently using the regex crate, which doesn't support look-arounds. A crate like fancy-regex could be used to add support for look-arounds
fancy_regex - https://crates.io/crates/fancy_regex

Logos is currently using the regex crate

It doesn't. Logos is using regex-syntax for syntax alone, and it only implements a subset of regular expressions to prevent performance issues like backtracking when lexing (which lookarounds would need).

I apologize for the misunderstanding 👍🏻
I will close this issue now.

No worries, it's on me for still not having this documented properly :see_no_evil:.


Separating trigger_string

I think it would be good if the bot splits up trigger_strings into trigger_prefix ("!", ".", ";", etc) and trigger_word ("game", "role", etc.)
That way a bot can change how it's being activated without search-and-replacing each trigger_string.

Should it be global or per module

Will be done as part of #22


create  client is blocked

Redis version
v6
Redisson version
3.33.0
Redisson configuration
any
What is the Expected behavior?
create a client quickly
What is the Actual behavior?
create client  is blocked
Additional information
https://linux.die.net/man/4/random
https://github.com/redisson/redisson/blob/5d9a0fc1c7faa5540dd1f571aeae30cbd94d243d/CHANGELOG.md?plain=1#L231
stack:

Fixed. Thanks for report

thank you


Unable to use sqlx in project ?

Whenever, I try to add
sqlx = { version = "*", features = ["runtime-tokio-rustls", "sqlite", "json"] }
to Cargo.toml
I get lots of compile errors like below.
I have tried to used different versions but running out of ideas.
Thanks
error[E0432]: unresolved import `crate::sys::IoSourceState`
  --> /home/glenn/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-0.8.9/src/io_source.rs:12:5
   |
12 | use crate::sys::IoSourceState;
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^ no `IoSourceState` in `sys`

error[E0432]: unresolved import `crate::sys::tcp`
  --> /home/glenn/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-0.8.9/src/net/tcp/listener.rs:15:17
   |
15 | use crate::sys::tcp::{bind, listen, new_for_addr};
   |                 ^^^ could not find `tcp` in `sys`

error[E0432]: unresolved import `crate::sys::tcp`
  --> /home/glenn/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-0.8.9/src/net/tcp/stream.rs:13:17
   |
13 | use crate::sys::tcp::{connect, new_for_addr};
   |                 ^^^ could not find `tcp` in `sys`

error[E0433]: failed to resolve: could not find `Selector` in `sys`
   --> /home/glenn/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-0.8.9/src/poll.rs:308:18
    |
308 |             sys::Selector::new().map(|selector| Poll {
    |                  ^^^^^^^^ could not find `Selector` in `sys`

error[E0433]: failed to resolve: could not find `event` in `sys`
  --> /home/glenn/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-0.8.9/src/event/event.rs:24:14
   |
24 |         sys::event::token(&self.inner)
   |              ^^^^^ could not find `event` in `sys`

error[E0433]: failed to resolve: could not find `event` in `sys`
  --> /home/glenn/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-0.8.9/src/event/event.rs:38:14
   |
38 |         sys::event::is_readable(&self.inner)
   |              ^^^^^ could not find `event` in `sys`

error[E0433]: failed to resolve: could not find `event` in `sys`
  --> /home/glenn/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-0.8.9/src/event/event.rs:43:14
   |
43 |         sys::event::is_writable(&self.inner)
   |              ^^^^^ could not find `event` in `sys`

Import it as optional:
sqlx = { version = "*", features = ["runtime-tokio-rustls", "sqlite", "json"], optional = true }

enable it in your SSR feature
ssr = [
    # added here
    "dep:sqlx",
    # already in template
    "dep:axum",
    "dep:tokio",
    # ...etc.
]

https://book.leptos.dev/ssr/24_hydration_bugs.html#not-all-server-code-can-run-on-the-client

Thank you. I would have been days finding that :)


Pull Request indicator

... on Repository page, which shows the number of Pull Requests, just like    the Issue indicator.

It looks like there is no property which returns the number of open PRs in a repo. The only way is to get all open PRs and count the result, which seems too much for every repo page load. I'll have to close this for now.


Draw Indexed Textures with CLUT

Support drawing textures in PSMT8/PSMT8H/PSMT4HH/PSMT4HT/PSMT4 format. These formats are indexed, so we must set CLUT fields in TEX0 (or TEX2) register to setup a pallet to index.
Steps

Load pallet into VRAM
Set TEX0 or TEX2 to configure indexed drawing
Draw indexed texture

Ended up having to do a reasonable overhaul to TGA/texture loading to support this!


Improve error message for dangling comma in method params

The error in this code sample is the dangling comma, but the error message doesn't clearly point that out. Ideally the comma would be underlined and the error message would say something to the effect of "SyntaxError: dangling comma not allowed at the end of params list".
https://sorbet.run/#%23 typed%3A true
class A
  extend T%3A%3ASig

  sig {params(x%3A Integer).returns(String)}
  def foo(
    %23 The real problem is this dangling comma%2C
    %23 but the error messages are not super clear.
    x%3A%2C
  )
    x.to_s
  end
end

Thanks for the feedback!
Given that this is ~identical to the error message that Ruby gives, I'm not sure if it's going to be worth our time to muck with the parser to make it better than what Ruby gives:

Thus, closing for now. Thanks again!


Hyperlinking in markdown format doesn't help a user to figure out credibility

Issue
Hyperlinking is combination. Problem to me is it doesn't make the linked URL visible just by looking at the hyperlinked text. On most web browsers on computers you can hover the mouse cursor over the text then you can see the URL, which requires one action (moving cursor). On computer environments where no mouse cursor is commonly available (e.g. cellphone), that is even not an option.
While many people may not care, I do care when in my own writings.  A convenient way to present such an information without clobbering too much space would be nice.
Possible approach
Credibility of the reference is getting more and more important. In some / a lot of cases, just showing domain of the URL would be a tremendous help for knowledgeable readers. E.g. When you're talking about healthcare issue, knowing a web site is on cdc.gov, who.int can be a huge help.

Specifically for markdown, something like this seems like a happy medium for me.
Input
See this link https://abc.de.fg

Convert!
Output
[See this link (de.fg)](https://abc.de.fg)


Finish renaming to osbs-client, fix old links.

Not sure how the package will get renamed in Fedora. Will it be another package review?

Yeah, it has to be a new review request. Don't worry, I'll do the work :) (once we actually release a new tarball called osbs-client).

LGTM, merged!


System redirect admin/admin/denied/ even module was installed

Install version 2.0 on "magento/product-enterprise-edition": "2.4.4"
The project is on developer mode
The module doesn't seem to work

I'd need more info than that. Error? Logs outputted? etc.

Well from my point the site still be redirected to admin/admin/denied/ even the module installed or not. The installation of this module took no effect.

https://github.com/magento/magento2/issues/29884

The admin login redirect was happening on "developer" mode.
I was able to log in when I set the deploy mode to "production"

When deploy mode is set to production, this module is bypassed for security reasons, so the regular 2FA process takes effect.
https://github.com/markshust/magento2-module-disabletwofactorauth/#usage


split sunburst breadcrumb names on '_' to apply ' '-dependent wrapping more freqently

breadcrumb text is written in a way that wraps long label names based on word breaks. this doesn't work for words_separated_by_underscores, so this PR replaces _ in breadcrumbs names with   so that long labels wrap more often.

Coverage remained the same at 72.402% when pulling 78d64ec25aad2b26046bc17c9d947798c63fce0f on split-sunburst-on-_ into afcdcf06a17319a19001f19e0cccbc7050b251b8 on master.

👍


Add bundle prefixes to rails/rake/rubocop commands

Description of changes
We're isolated in the docker containers so we shouldn't run into conflicts here, but this closely reflects the commands as you'd want to run them locally, if you weren't using a Makefile. So, I'd consider it more a "documentation" fix than anything
Also cleaned up some trailing empty spaces on commands.
This might be considered a style/preference but I consider it more of a good rule to follow when using bundler. Please feel free to close it if it doesn't add any value.
Issue Resolved
No issues closed. This is a general documentation/cleanup suggestion

As an FYI, I actually just ran into this issue on a separate PR that I'm working on, so I guess it's not quite as much of "just" a style issue, or isolated because it's in docker, as I thought


Feature: Can you add to the docs how to configure solution configuration correctly

I want to configure the solution, but I have an issue:
Look here.
Is this normal behaviour?

@Legends thanks for the feedback. I will try to make this clearer in the build docs.

I would't change the Docs, but rather rethink the implementation in VS. Make it more intuitive.
When you open the solution properties and change the selection from  "All configurations" to anything else, it prompts you : Do you want to save the changes made to the property pages?
What changes?
When you iterate over the single configurations it doesn't prompt you again, until you reach "All configurations" again and then change it to another configuration.
The solution property form and the Configuration Manager Form are so similar, that I can't see any difference between them.
It's very confusing...

Perhaps one of the VS IDE team can take a look at this

@prnadago who is the right PM to forward this build configuration feedback to?

That would be Ruben Rios. :)

@prnadago thank you. @rub8n can you look at this feedback?

Fix and return to original


Static picker gets removed after picking value

I have reproduced my issue here:
https://jsfiddle.net/736kpvry/6/
I am using a html dialog containing a few inputs which are using flatpickr. I have to use the 'static' option in order to display the date in front of the dialog, but once I pick a date, all flatpickr instances are getting removed, and I have not been able to figure out why.
So, to reproduce using the jsfiddle above, click the button to open the dialog, pick a date, try to pick a date again, it will not open. the instance on document.querySelector('#datepick')._flatpickr is undefined.

flatpickr version used: latest (4.5.2)
Browser name and version: Chrome Version 71.0.3578.98 (Official Build) (64-bit)
OS and version: macOS Sierra v10.12.6

You are using Preact. The virtualdom is replacing the original dom nodes on state change and thus removing the nodes of flatpickr. Try https://www.npmjs.com/package/preact-flatpickr


How to modify the "mode status window"?

Please forgive for my ignorance, but how to change the default appearance and location of the "mode status window"( which I am referring the black block that indicates the current mode，shows “dock mode" by default) sits in the right downside corner of the screen? I wish it could be auto-hidden, it would be grateful if you show me how to achieve it, thx.
您好，打扰。请问屏幕右下角modal切换状态显示框如何修改其属性（比如大小，半透明程度，位置）？能否设置其自动隐藏，只有激活时显示？

To set mode block to be auto-hidden, see the manual's Customization's Global options.
Create the file ~/.hammerspoon/private/awesomeconfig.lua and put the line below into it:
idle_to_which = "hide"

To set it's default appearance and location, well ... unfortunately at present there are no those options provided.  But they can be done if you're brave enough to get your hands dirty :)
There are two global objects you can access: modal_bg and modal_show, which represent mode block's background and text respectively.
Open your hammerspoon console, input this:
modal_bg:setFrame(hs.geometry.rect(0,0,170,19))
modal_bg:setAlpha(0.5)

The disadvantage is these settings are not persisted.

@ashfinal Thx for your reply. I've added
idle_to_which = "hide"
to the file, but it only works after "reload config" every time, which is quite weird.

 :(
I'm trying to restore them now. Keep clam and wait for some time.
It should be available by tomorrow morning.
Sorry for the inconvenience.

Sorry, got something else to do.
The commit history has been restored, and idle_to_which option should works now.
Thanks for your patience. :)


rewind and close file to write content to disk before mv file

fix #2

any progress？

Hello @haibinyu, and sorry for the (long) delay.
I check and test your PL rigth now, but it seems to be nice !

@haibinyu Thanks for your help in your PL.
I've merged it on the master branch, and published the updated version (0.3.1) on RubyGems.
Can you please tell me if it's ok for you (for the both issues #2 & #3) ?

@Jems22 thanks for the merge.


fix all.numTokens count

Thanks!

It is deployed but it will take a long while to be synced : https://thegraph.com/explorer/subgraph/wighawag/eip721-subgraph?version=pending


nnictl experiment list --all should show experiment name as well

What would you like to be added:
At present
nnictl experiment list --all

shows all the previous experiments however they are listed by experiment ID.
It would be good to display the experiment name as well
Why is this needed:
Since experiment Id is auto generated it is difficult to remember to which experiment it belongs.
Without this feature, how does current nni work：
I have to go in all the experiments to figure out which is the one that I need to look at.
Components that may involve changes:
Brief description of your proposal if any:
One straightforward approach is to add a column with experiment names. These experiment names do not need to unique. User should be able to combine experiment name & date to figure out which one he/she is interested in.
Other approach is to have another command that lists a table that shows the mapping between experiment names and auto generated Ids.

Duplicate of #1615.


[CT-3493] [Bug] unique_key list incremental model has performance issues on the delete phase

Is this a new bug in dbt-core?

[X] I believe this is a new bug in dbt-core
[X] I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior
The scenario is as follows:
•	A model that is loading 20k rows
•	Is setup as incremental , delete+insert
•	The unique_key is an array of 2 columns
•	The 2 columns (unique_key) define a single “partition” with all columns (200k)
•	The tmp table creation executes fast as expected
•	The delete takes hours until we cancelled it
•	The execution plan shows that the delete statement is combining 20k * 20k = 200 million rows
The configuration is
{{
    config(
        materialized='incremental',
        incremental_strategy='delete+insert',
        unique_key=['version_code','bu_agg']
    )
}}

The delete statement is assuming that the key is really unique. That probably is not the case if you are using "delete+insert".
delete from big_table
            using big_table__dbt_tmp
            where (
                    big_table__dbt_tmp.version_code = big_table.version_code
                    and big_table__dbt_tmp.bu_agg = big_table.bu_agg

Expected Behavior
The delete statement should not assume the unique key.
My suggestion is to use :
delete from big_table
            where (version_code ,bu_agg) in (
                  select version_code ,bu_agg from big_table__dbt_tmp
              )

Steps To Reproduce
•	Setup the model as incremental , delete+insert
•	The unique_key is an array of 2 columns
•       Build the model
•	Check the execution plan
Relevant log output
No response
Environment
- dbt:Cloud 1.7

Which database adapter are you using with dbt?
No response
Additional Context
No response

Thanks for reporting this @nfarinha !
Based on your screenshots of the query plan, it looks like you are using dbt-snowflake. Let's dive into the details.
Non-unique unique_key

The delete statement is assuming that the key is really unique. That probably is not the case if you are using "delete+insert".

The folks that have contributed to https://github.com/dbt-labs/docs.getdbt.com/issues/4355 are saying something similar about use-cases for the delete+insert incremental strategy.
Our documentation currently states that unique_key is expected to be truly unique here, but then it also gives guidance on using delete+insert within dbt-snowflake when it isn't truly unique.
For the sake of this discussion, let's assume that we want to support the use case of non-unique keys with delete+insert specifically, but expecting truly unique keys with the other incremental strategies.
The delete+insert strategy in dbt-snowflake
The delete+insert strategy in dbt-snowflake defers to the implementation of default__get_delete_insert_merge_sql within dbt-core).
The delete+insert strategy in dbt-core
It only does a delete portion if unique_key is defined, otherwise, it only does an insert.
When it does a delete, it has two different code paths introduced in https://github.com/dbt-labs/dbt-core/pull/4858 depending on if unique_key is a list or not.

If unique_key is a list:

https://github.com/dbt-labs/dbt-core/blob/c2bc2f009bbeeb46b3c69d082ab4d485597898af/core/dbt/include/global_project/macros/materializations/models/incremental/merge.sql#L65-L77

If unique_key is a single column:

https://github.com/dbt-labs/dbt-core/blob/c2bc2f009bbeeb46b3c69d082ab4d485597898af/core/dbt/include/global_project/macros/materializations/models/incremental/merge.sql#L79-L89
Your suggestion
Your suggestion is to use:
delete from big_table
            where (version_code ,bu_agg) in (
                  select version_code ,bu_agg from big_table__dbt_tmp
              )

Your suggestion looks really close to that 2nd code path!
So it would essentially involve eliminating the 1st code path in favor of the 2nd (with some small tweaks, of course).
Summary
To the best I can tell, the current logic is expected to give correct results on tiny data sets but it quickly runs into severe performance issues with normal-sized data sets.
We'd need to try out your suggestion with a similar-sized data set (20K pre-existing x 20K updates) to see if it executes in a reasonable amount of time.

Just tested now:
delete from DEV_CUSTOMER_SEG.dbt_z003kwbj_MARTS.dim_hier_versioned_territory
using DEV_CUSTOMER_SEG.dbt_z003kwbj_MARTS.dim_hier_versioned_territory__dbt_tmp
where (
                DEV_CUSTOMER_SEG.dbt_z003kwbj_MARTS.dim_hier_versioned_territory__dbt_tmp.version_code = DEV_CUSTOMER_SEG.dbt_z003kwbj_MARTS.dim_hier_versioned_territory.version_code
                and

                DEV_CUSTOMER_SEG.dbt_z003kwbj_MARTS.dim_hier_versioned_territory__dbt_tmp.level_code = DEV_CUSTOMER_SEG.dbt_z003kwbj_MARTS.dim_hier_versioned_territory.level_code

        );

@.***
Cancelled it.... Not worth to wait.
@.***
Deleted directly on Snowsight with the changed query.
@.***
Executed in no time as expected.
@.***
It's quite simple to replicate but let me know if you need some more detail on this. I'm very happy to redeem all the effort and time you guys have already spared me.
Best regards,
Nuno Farinha
From: Doug Beatty @.>
Sent: Wednesday, December 13, 2023 20:23
To: dbt-labs/dbt-core @.>
Cc: Farinha Goncalves, Nuno (DI IT EH PT 2) @.>; Mention @.>
Subject: Re: [dbt-labs/dbt-core] [CT-3493] [Bug] unique_key list incremental model has performance issues on the delete phase (Issue #9279)
Thanks for reporting this @nfarinhahttps://github.com/nfarinha !
Based on your screenshots of the query plan, it looks like you are using dbt-snowflake. Let's dive into the details.
Non-unique unique_key
The delete statement is assuming that the key is really unique. That probably is not the case if you are using "delete+insert".
The folks that have contributed to dbt-labs/docs.getdbt.com#4355https://github.com/dbt-labs/docs.getdbt.com/issues/4355 are saying something similar about use-cases for the delete+insert incremental strategy.
Our documentation currently states that unique_key is expected to be truly unique herehttps://docs.getdbt.com/docs/build/incremental-models#defining-a-unique-key-optional, but then it also gives guidancehttps://docs.getdbt.com/reference/resource-configs/snowflake-configs#merge-behavior-incremental-models on using delete+insert within dbt-snowflake when it isn't truly unique.
For the sake of this discussion, let's assume that we want to support the use case of non-unique keys with delete+insert specifically, but expecting truly unique keys with the other incremental strategies.
The delete+insert strategy in dbt-snowflake
The delete+insert strategyhttps://github.com/dbt-labs/dbt-snowflake/blob/0374b4ec948982f2ac8ec0c95d53d672ad19e09c/dbt/include/snowflake/macros/materializations/merge.sql#L35-L38 in dbt-snowflake defers to the implementation of default__get_delete_insert_merge_sqlhttps://github.com/dbt-labs/dbt-core/blob/c2bc2f009bbeeb46b3c69d082ab4d485597898af/core/dbt/include/global_project/macros/materializations/models/incremental/merge.sql#L59 within dbt-core).
The delete+insert strategy in dbt-core
It only does a delete portion if unique_key is defined, otherwise, it only does an insert.
When it does a delete, it has two different code paths introduced in #4858https://github.com/dbt-labs/dbt-core/pull/4858 depending on if unique_key is a list or not.

If unique_key is a list:

https://github.com/dbt-labs/dbt-core/blob/c2bc2f009bbeeb46b3c69d082ab4d485597898af/core/dbt/include/global_project/macros/materializations/models/incremental/merge.sql#L65-L77

If unique_key is a single column:

https://github.com/dbt-labs/dbt-core/blob/c2bc2f009bbeeb46b3c69d082ab4d485597898af/core/dbt/include/global_project/macros/materializations/models/incremental/merge.sql#L79-L89
Your suggestion
Your suggestion is to use:
delete from big_table
        where (version_code ,bu_agg) in (

              select version_code ,bu_agg from big_table__dbt_tmp

          )

Your suggestion looks really close to that 2nd code path!
So it would essentially involve eliminating the 1st code path in favor of the 2nd (with some small tweaks, of course).
Summary
To the best I can tell, the current logic is expected to give correct results on tiny data sets but it quickly runs into severe performance issues with normal-sized data sets.
We'd need to try out your suggestion with a similar-sized data set (20K pre-existing x 20K updates) to see if it executes in a reasonable amount of time.

Reply to this email directly, view it on GitHubhttps://github.com/dbt-labs/dbt-core/issues/9279#issuecomment-1854648597, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BETND4CJEHVAHO5CTQLAPVTYJIFBXAVCNFSM6AAAAABATVI4T2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJUGY2DQNJZG4.
You are receiving this because you were mentioned.Message ID<EMAIL_ADDRESS>

I can absolutely confirm that the current multi-column insert+delete query strategy is beyond inefficient. My tests never finish, even with small amounts of data (~100K rows). The proposed strategy appears like the best approach:
delete from table1
where (col1, col2) in (
    select distinct col1, col2 from table1_tmp
)

Some initial/quick testing appears to be faster with distinct in there.
Any ideas on when this fix might be applied?

I had to rewrite this macro for an urgent use-case, so here's the improved code (faster and cleaner):
{% macro default__get_delete_insert_merge_sql(target, source, unique_key, dest_columns, incremental_predicates) -%}

    {%- set dest_cols_csv = get_quoted_csv(dest_columns | map(attribute="name")) -%}

    {% if unique_key %}
        {% if unique_key is string %}
        {% set unique_key = [unique_key] %}
        {% endif %}

        {%- set unique_key_str = unique_key|join(', ') -%}

        delete from {{ target }}
        where ({{ unique_key_str }}) in (
            select distinct {{ unique_key_str }}
            from {{ source }}
        )
        {%- if incremental_predicates %}
            {% for predicate in incremental_predicates %}
                and {{ predicate }}
            {% endfor %}
        {%- endif -%};

    {% endif %}

    insert into {{ target }} ({{ dest_cols_csv }})
    (
        select {{ dest_cols_csv }}
        from {{ source }}
    )

{%- endmacro %}


ryecharm run ruff on rst file

What happened?
ryecharm run ruff on rst file and report syntax error

looks like it run ruff on rst file directly ruff check .\docs\enum.rst

Steps to reproduce
create a rst file and open it with ryecharm plugin
Relevant log output or stack trace
No response
Operating system
None

2024-09-20 02:26:05,989 [94317252]   INFO - #c.i.a.o.PathMacrosImpl - Saved path macros: {}
2024-09-20 02:26:16,220 [94327483]   INFO - #insyncwithfoo.ryecharm.Command - Running: (C:\Users\Trim21\proj\python\transmission-rpc) C:\Users\Trim21\scoop\shims\ruff.exe check --no-fix --exit-zero --quiet - --output-format json --stdin-filename C:\Users\Trim21\proj\python\transmission-rpc\docs\client.rst

my ruff config:

[tool.ruff]
target-version = "py38"
extend-exclude = ["docs"]
line-length = 120

[tool.ruff.lint]
select = [
    "B",
    "C",
    "E",
    "F",
    "G",
    "I",
    "N",
    "Q",
    "S",
    "W",
    "BLE",
    "EXE",
    "ICN",
    "INP",
    "ISC",
    "NPY",
    "PD",
    "PGH",
    "PIE",
    "PL",
    "PT",
    "PYI",
    "RET",
    "RSE",
    "RUF",
    "SIM",
    "SLF",
    "TCH",
    "TID",
    "TRY",
    "YTT",
    "UP",
    "FA100",
    "FA102"
]

extend-fixable = ['UP']

ignore = [
    'PLR0911',
    'INP001',
    'N806',
    'N802',
    'N803',
    'E501',
    'BLE001',
    'RUF002',
    'S301',
    'S314',
    'S101',
    'N815',
    'S104',
    'C901',
    'ISC003',
    'PLR0913',
    'RUF001',
    'SIM108',
    'TCH003',
    'RUF003',
    'RET504',
    'TCH001',
    'TRY300',
    'TRY003',
    'TRY201',
    'TRY301',
    'PLR0912',
    'PLR0915',
    'PLR2004',
    'PGH003',
]

I'm not sure if this help, but I'm editing doc files in this git repo https://github.com/trim21/transmission-rpc

I'll add an extra check, but this is more of a design bug on PyCharm's side.

At least ruff extend-exclude should work, docs directory is already excluded in ruff config.

I think it works

I'm guessing the exclude config would wors if I use LSP instead of cli?

Yes files get excluded as expected in LSP mode.

thanks


feat(sh): add pragma support

Closes #377

The approach I took differs from that described in the related ticket. As I started working and read Prettier's plugin API and implementation, I realized we don't have access to all of the options required to instantiate the parser until after the pragma check has happened. Without that, we couldn't cache or memoize and using the actual Parser would mean every file would need to be parsed twice.
So this takes a regex-based approach to just chomp off the top of a file until it comes across non-comment content, scanning for the pragma along the way.

@JounQin Thanks for your patience, this should now be ready for workflows and review!
For posterity, I needed to:

Move common-tags to a dev dependency specific to the package it's being used in. Add the corresponding @types/common-tags type definitions for the build process to use.
Rollback my changes to pnpm-lock.yaml and regenerate it for the changed dependencies with PNPM v8 (I was previously on 9, which made a BC-breaking lockfile version update).
Finally, to get that changeset generated I just needed to make sure I ran pnpm build before pnpm changeset. The install process on it's own just links/copies things around without topological build ordering, which is why it was failing to locate that module / getting confused on ESM vs CJS imports.

It would probably be a good idea to document (3) somewhere, but I think the changes here are sufficient for this PR and the docs update can come later.
Let me know if you need anything else. Thanks again!


Invalid XHTML names entities reported in Character Data strings

epubcheck seems to report invalid XHTML named entities in <![CDATA[]]>, which I used in the first place to indicate that the <script> data in between these strings includes data that could be interpreted as XML markup, but should not be.
Here comes the tricky part:

inline script is uglified/minified;
warning is reported for a super specific string: &&void 0 (there’s a space);
no issue with other strings such as &&TweenLite.to(), where there’s no space.

As far as I can remember, this wasn’t reported when the book was published last year (this is a 2nd edition). And given void 0 contains fewer characters than undefined, it’s quite used in uglyfiers/minifiers.
Fix if you encounter this issue: use void(0) instead of void 0 (they’re the same).
What’s strange though, is that it is interpreted as XML markup despite <![CDATA[]]>.

Hey Jiminy, can you please attach a simple HTML file which can be run against the current EpubCheck build and also post the offending error message? Thanks!

I’ll see what I can do (publishers’ right and stuff).
I guess I can just use a placeholder HTML file with the script if I don’t have permission to share the problematic XHTML file but won’t be able to deal with this until Friday.

A sample/dummy HTML file would be enough. Thanks Jiminy.

On a cursory review, the problem looks like it's that EntitySearch.java goes line-by-line over an input stream looking for this pattern:
static final Pattern entityPattern = Pattern.compile("&([A-Za-z0-9]+)([;|\s])");
It doesn't care that there is an active CDATA block. So long as it finds an ampersand followed by one or more alphanumeric characters followed by a colon or space it will emit the warning. That's why '&&void ' gets a warning but '&&void(' does not.

Even that pattern is a bit screwy, to be honest, as the pipe is not an OR inside a character set, and is not a delimiter of the end of an entity.

thanks matt for having a look.
regarding the screwy pattern, do you agree that it should be "&([A-Za-z0-9]+)(;|\s)" without the square brackets instead?
anyways, we still need a solution to not parse entitities in CDATA.

Either that or just remove the pipe. The brackets establish a character set. I don't know if the capture groups are used or not, but they're also potentially superfluous. Could just be:

&[A-Za-z0-9]+[;\s]

Can't help with the harder cdata problem as I only hack at java. You probably have to pre-process out the data blocks before analyzing. Maybe also comments, but haven't tested those.

Maybe also comments, but haven't tested those.

To confirm, it's dumb validation, so also affects comments.
I'm wondering why this check is even run? What is it doing that the default HTML validation doesn't catch?
I've yet to find any value to it, at any rate, other than to make mistakes. XHTML doesn't allow entities without a closing semi-colon, so that part of the check is useless, and declaring named entities beyond the base xml set generates errors, so you wind up with an error and a warning.

Here we go, placeholder file in a ZIP (it contains an XHTML file but github doesn't support xhtml for attached files).
void-epubcheck.zip

I'm not clear on what the resolution is. Is it to make sure that named entities are not checked for inside comments and CDATA?

Oh, and to fix the regex for named entities?

I reread this thread, and now I'm really not sure what the resolution is since there's talk that the entity check is redundant with a check elsewhere.

Since it was me adding the label "reviewed & ready for implementation", I have to wrap my head around it a second time I think...
I think I added the label because it's clearly a bug and we have demo data which are reproducable.
However, there's currently not a clear solution to it.
Looking at the EntitySearch.java class, this whole thing is a nightmare. As are other similar classes in the ctc package (see below).
This class tries to parse an X(HT)ML file line-by-line(!) which is a blocker for context sensitive information items like things INSIDE other elements/structures.
There's a similar parsing class in the ctc package HTMLTagsAnalyseHandler.java which handles XML validation like this and tries to implement context sensitive line-by-line parsing like at https://github.com/IDPF/epubcheck/blob/master/src/main/java/com/adobe/epubcheck/ctc/xml/HTMLTagsAnalyseHandler.java#L343 which is IMHO a huge pile of sh*** 😲  (and causes trouble at #446 as well).
All of this would need refactoring asap.
But I'm not sure whether that's a solution for this issue here.
I'm still on parental leave and my time is very limited at the moment, so unfortunately I cannot make up a good solution for this at the moment :-/ sorry.

I'm thinking of tackling this one. What I'd like to do is to parse into individual tags (crudely, "<[^<]+>"; CDATA requires more sophistication than that) and non-tag (plain text) data. Then apply the character entity checking only to opening tags and non-tag data, ignoring comments, closing tags, and CDATA. I think the opening (& closed) tags can be searched naively.
Does that sound like a good approach?
Also, it seems to be a mistake to consider something to be a character entity if it doesn't end with a semicolon. Is part of the solution here to warn about instances of "&" that don't seem to begin a legal character or numeric entity? (I have to do my homework to see about my terminology.)

Also, it seems to be a mistake to consider something to be a character entity if it doesn't end with a semicolon.

Na, that's indeed the XML rules! So everything beginning with & needs to be treated as an entity. At least in XHTML. Out of my head, I don't know the rules for HTML5, but I would treat it the same.

Is part of the solution here to warn about instances of "&" that don't seem to begin a legal character or numeric entity?

The main goal should be to exclude entity parsing in CDATA blocks (the only place where an & is not treated as the beginning of an entity).
Parsing for legal entities is too hard I think. We could certainly check for decimal entities (Ӓ, can have 4+ digits), for hexadeciaml entities (&#202F;, can have 4+ chars) or named entities ( , there's a list of allowed entities in the (X)HTML DTD e.g. XHTML 1.1 DTD EPUB 2). But I don't know whether this is already checked somewhere else...

Does that sound like a good approach?

If you have a look at the linked TMLTagsAnalyseHandler.java above, you will see the marked line starting with if (inBlockQuote ... . Original Authors parsed line by line and if they found an opening tag <blockquote> they set inBlockQuote = true; and if they found the next occurance of closing </blockquote> the reset the var to false.
You could use this mechanism to parse for CDATA markers (start <![CDATA[, end ]]>) line by line and set a global var if you're inside a CDATA section.
If I got you right, that's basically what you suggested, right?


rust: Fix build flags

Motivation for this change
:warning: Caution: I only tested this against a few packages. Before merging this, we should ensure to not cause even further regressions.
This PR fixes a bug originally described in #91191: if a package has a special cargoBuildFlags-declaration, the binaries in $out aren't built with those since the artifacts in target/release get modified during checkPhase which doesn't use cargoBuildFlags.
This change copies the artifacts after buildPhase into a temporary location, so that the proper binaries get installed into $out and cargo test can resume the build-process in the checkPhase.
cc #91689
Closes #93119
Closes #91191
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Sorry this turned into a mess and that I wasn't able to resolve it before it landed in master.
Thanks for fixing it @Ma27.
Hydra is quiet, might be worthwhile merging this to master so we aren't waiting for the next staging cycle?

Hydra is quiet, might be worthwhile merging this to master so we aren't waiting for the next staging cycle?

I don't think that it's a good idea to merge something with ~1000 rebuilds into master.
@vcunat would it be possible to merge this into staging-next to speed this up a bit as soon as this PR is approved by more folks.

https://github.com/NixOS/nixpkgs/pull/91090 has been approved 2 days ago - I assume staging-next is mostly waiting for rebuilds to finish.

#91090 has been approved 2 days ago - I assume staging-next is mostly waiting for rebuilds to finish.

It's already in master, the PR has been recycled a couple of times. Currently staging-next is empty.

Uh, in that case, If staging-next is empty, and this PR causes a big rebuild, shouldn't we merge it into staging, and then staging into staging-next?

Let's let this cook a bit in staging, and spot breakages there.


create proxy to outside server

Before you open an issue, please check if a similar issue already exists or has been closed before.
A descriptive title
The connection to be proxied
Bug repro steps

clone angular2 quickstart
change bs-conf.json to bs-conf.js
change the package.json

add this to bs-confg
var proxy = require('http-proxy-middleware');
var fallback = require('connect-history-api-fallback');
module.exports = {
  browser: ['chrome'],
  server: {
    middleware: {
      1: proxy('/twitter', {target: 'https://api.twitter.com', changeOrigin: true }),
      2: fallback({index: '/index.html', verbose: true})
    }
  }
};

make a call to /twitter/foo/bar/, get or post, and you'll get
[1] [HPM] Error occurred while trying to proxy request /twitter/oauth2/token from localhost:3000 to https://api.twitter.com (undefined) (https://nodejs.org/api/errors.html#errors_common_system_errors)
[1] 16.11.07 16:44:12 500 POST /twitter/oauth2/token

Environment
"lite-server": "^2.2.2",

yeah.. nevermind facepalm


Fixed an infinite loop caused by force casting NSError to CocoaError

Cherry-picked from #5115 for 6.0
(cherry picked from commit bf7369a3909583c82f36b901917a92ea0d639a9f)

@swift-ci test


onLoad and directives

The onLoad option works great if the parent element is a controller, however if it's a directive it's never called:
http://plnkr.co/edit/CvPSaccYVKZfoesJC7o4?
The problem is it just hasn't binded yet. I hacked around it using this:
    setTimeout(function() {
        opts = angular.extend({}, options, scope.$eval(attrs.uiAce));
        if (angular.isFunction(opts.onLoad)) {
            opts.onLoad(acee);
        }
    }, 0);

However this clearly is slightly hacky (not to mention I had to edit ui-ace, which I'd rather not do). A $watch would probably work as well (and be more appropriate here).
(Thanks for this directive, by the way -- it's been an awesome help.)

the html code:Ace here
change the 126 line  eval code  to this:
var opts = angular.extend({}, options, scope.$eval(attrs.uiAce,scope));
the scope is the root scope like this :
in the AceController add
         $scope.aceChanged=function(){
    		console.log('change');
    	}

        $scope.aceLoaded=function(){
        	console.log('load');
        }

ui.ace event handler worked.

@JoshRosen , @m-e-conroy
I just want to let you know how you can load onLoad and onChange function from a directive.
.directive('aceEditor', function (){
return {
      templateUrl: 'views/templates/superEditor/r-code-exe.html',
      scope: {target: '@', mode:'@', cnt:'='},
      restrict: 'E',
      link: {
        pre: function preLink(scope, element, attrs){  // put ace option definition here },
        post: function postLink(scope, element, attrs){ // your logic for directive }
  }
})


#picture typing

added new game in this .where user have to press the starting word of the image .
PR Description 📜
Please include summary related to the issue you have fixed and describe your PR in brief over here by specifying the issue number on which you were working below
Fixes # <your_issue_number>

Mark the task you have completed ✅

[x] I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
[x] I have performed a self-review of my own code or work.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] My changes generates no new warnings.
[x] I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
[x] I have added screenshot for website preview in assets/images
[x] I have added entries for my game in main README.md
[x] I have added README.md in my folder
[x] I have added working video of the game in README.md (optional)
[x] I have specified the respective issue number for which I have requested the new game.

Add your screenshots(Optional) 📸

Thank you soo much for contributing to our repository 💗

Thank you @TANIYASHARMA30 ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

#GSSOC 23

Please follow convention to make PR and specify the issue on which you are working !!

Thank you  @TANIYASHARMA30 , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀


Added ALT Tags for playbooks/running-playbooks.rst

/check-cla

Hello @jaskiratsingh2000,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@justinegeffen - It looks like this source file now redirects to https://docs.mattermost.com/playbooks/customize-a-playbook.html. This PR may no longer be needed.

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!


varlink: PullImage() crashes podman if an error occurs

Is this a BUG REPORT or FEATURE REQUEST? (leave only one on its own line)
/kind bug
Description

podman crashes if pulling an image results in an error via varlink API.
Steps to reproduce the issue:

Pick an image name that will fail for your configuration, for example: alpine:latest

Try to pull it via varlink: varlink call unix:///run/podman/io.podman/io.podman.PullImage '{"name":"alpine:latest"}'

Describe the results you received:
podman crashes:
panic: send on closed channel

goroutine 28 [running]:
github.com/containers/libpod/pkg/varlinkapi.(*LibpodAPI).PullImage.func2(0xc0004a03e0, 0xd, 0xc000512060, 0xc00000e1e0, 0xc0004da098, 0xc0004ec4d0, 0xc00000e440, 0x15a6000, 0x0, 0x0)
	pkg/varlinkapi/images.go:664 +0x1c9
created by github.com/containers/libpod/pkg/varlinkapi.(*LibpodAPI).PullImage
	pkg/varlinkapi/images.go:644 +0x234

Describe the results you expected:
podman not to crash.
Additional information you deem important (e.g. issue happens only occasionally):
Happens irrespective of whether more flag is set.
Output of podman version:
Version:            1.4.5-dev
RemoteAPI Version:  1
Go Version:         go1.12.4
OS/Arch:            linux/amd64

Output of podman info --debug:
debug:
  compiler: gc
  git commit: ""
  go version: go1.12.4
  podman version: 1.4.5-dev
host:
  BuildahVersion: 1.9.2
  Conmon:
    package: Unknown
    path: /usr/libexec/podman/conmon
    version: 'conmon version 1.0.0-dev, commit: 6f177c68ed989a6cc14ddbf8cec421819bb46401'
  Distribution:
    distribution: ubuntu
    version: "19.04"
  MemFree: 386330624
  MemTotal:<PHONE_NUMBER>
  OCIRuntime:
    package: 'cri-o-runc: /usr/bin/runc'
    path: /usr/bin/runc
    version: 'runc version spec: 1.0.1-dev'
  SwapFree:<PHONE_NUMBER>
  SwapTotal:<PHONE_NUMBER>
  arch: amd64
  cpus: 4
  hostname: eric-ubuntu
  kernel: 5.0.0-17-generic
  os: linux
  rootless: false
  uptime: 7h 38m 24.3s (Approximately 0.29 days)
registries:
  blocked: null
  insecure: null
  search: null
store:
  ConfigFile: /etc/containers/storage.conf
  ContainerStore:
    number: 29
  GraphDriverName: overlay
  GraphOptions: null
  GraphRoot: /var/lib/containers/storage
  GraphStatus:
    Backing Filesystem: extfs
    Native Overlay Diff: "true"
    Supports d_type: "true"
    Using metacopy: "false"
  ImageStore:
    number: 66
  RunRoot: /var/run/containers/storage
  VolumePath: /var/lib/containers/storage/volumes

Additional environment details (AWS, VirtualBox, physical, etc.):
Physical Ubuntu box.

Thank you for fixing this :+1:


Guide updates

Adding screenshots and doing a pass of editing the writing.

It's not a page param, it's a page property.
Sent from my iPhone

On Oct 29, 2015, at 10:32 PM, Brian Moschel<EMAIL_ADDRESS>wrote:
Adding screenshots and doing a pass of editing the writing.
You can view, comment on, or merge this pull request online at:
https://github.com/donejs/donejs/pull/394
Commit Summary
adding images and small language changes to quick start guide
more images
updates to guide
more screenshots
fixing links
File Changes
D docs/about2.md (76)
M docs/features.md (4)
M docs/guide.md (199)
A docs/theme/static/img/donejs-bootstrap.png (0)
A docs/theme/static/img/donejs-chat1.png (0)
A docs/theme/static/img/donejs-chat2.png (0)
A docs/theme/static/img/donejs-chat3.png (0)
A docs/theme/static/img/donejs-deploy.png (0)
A docs/theme/static/img/donejs-firebase.png (0)
A docs/theme/static/img/donejs-generator.png (0)
A docs/theme/static/img/donejs-helloworld.png (0)
A docs/theme/static/img/donejs-init.png (0)
A docs/theme/static/img/donejs-ios.png (0)
A docs/theme/static/img/donejs-localstorage.png (0)
A docs/theme/static/img/donejs-model-generator.png (0)
A docs/theme/static/img/donejs-nw1.png (0)
A docs/theme/static/img/donejs-nw2.png (0)
A docs/theme/static/img/donejs-prodmode.png (0)
A docs/theme/static/img/donejs-tabs.png (0)
A docs/theme/static/img/donejs-twobrowsers.png (0)
A docs/theme/static/img/donejs-viewsource.png (0)
Patch Links:
https://github.com/donejs/donejs/pull/394.patch
https://github.com/donejs/donejs/pull/394.diff
—
Reply to this email directly or view it on GitHub.

Why add have/will/etc instead of using just the verb.
We create vs we will create
We created vs we have created
I don't think the modifiers add anything, but make the actions seem a little more remote /distant.
Sent from my iPhone

On Oct 29, 2015, at 10:32 PM, Brian Moschel<EMAIL_ADDRESS>wrote:
Adding screenshots and doing a pass of editing the writing.
You can view, comment on, or merge this pull request online at:
https://github.com/donejs/donejs/pull/394
Commit Summary
adding images and small language changes to quick start guide
more images
updates to guide
more screenshots
fixing links
File Changes
D docs/about2.md (76)
M docs/features.md (4)
M docs/guide.md (199)
A docs/theme/static/img/donejs-bootstrap.png (0)
A docs/theme/static/img/donejs-chat1.png (0)
A docs/theme/static/img/donejs-chat2.png (0)
A docs/theme/static/img/donejs-chat3.png (0)
A docs/theme/static/img/donejs-deploy.png (0)
A docs/theme/static/img/donejs-firebase.png (0)
A docs/theme/static/img/donejs-generator.png (0)
A docs/theme/static/img/donejs-helloworld.png (0)
A docs/theme/static/img/donejs-init.png (0)
A docs/theme/static/img/donejs-ios.png (0)
A docs/theme/static/img/donejs-localstorage.png (0)
A docs/theme/static/img/donejs-model-generator.png (0)
A docs/theme/static/img/donejs-nw1.png (0)
A docs/theme/static/img/donejs-nw2.png (0)
A docs/theme/static/img/donejs-prodmode.png (0)
A docs/theme/static/img/donejs-tabs.png (0)
A docs/theme/static/img/donejs-twobrowsers.png (0)
A docs/theme/static/img/donejs-viewsource.png (0)
Patch Links:
https://github.com/donejs/donejs/pull/394.patch
https://github.com/donejs/donejs/pull/394.diff
—
Reply to this email directly or view it on GitHub.

I added "will" in a few places for consistency. 90% of the intro sections use that verb tense, so I added where it was missing. Without it, it reads weird.


Enable MultiModule report

Is any way to enable jacoco for multi module project for example
--app
--domain
---data
If I use the plugin in the build.gradle (app module) the report will only scan the app module, is possible to enable the report for other modules?

It's roughly a year later and I assume multi module support has not been implemented, has it?

kover worked like a charm, thank you


One split one thread

This is low priority
We might get better performance by allocating only one thread per split.
The idea would then to read the target amount of docs (5M) in memory, and have
a single thread indexer start working on its indexing.
Several splits would be working at the same time. Each one with a single thread.
With enough RAM, this could reduce or even remove the need for merges.

As we have now one thread per indexer, it seems that we can close this issue.


Add a lint test for adapters

To make it easy for people to create adapters we should have some kind of a lint test that checks that the bare minimum interface is implemented and works correctly.
We could have a shared rspec test or some test-framework agnostic solution.

Want to back this issue? Place a bounty on it! We accept bounties via Bountysource.

active_model/lint is an example of one way to do this.
I don't know how it should be used since it would be best to support any test framework. Probably be nice to have a linter that is framework agnostic as @solnic mentioned and include a couple of ways to aid in testing with rspec and minitest for example. The key here is, we know it won't be a lot of code but it will increase an adapter developer's confidence that what they're building will be compatible, and I feel like that may encourage more adapters to be written.

@elskwid framework-agnostic would probably simply mean using test/unit. I think this is actually a high priority task. We need as many adapters as possible to prove that ROM's design isn't blocking anything and is flexible enough...

From our conversation yesterday, I'd like to see this part specification and part runnable spec. Basically, set it up so the comments/docs are like reading the specification for an adapter:
I'd recommend we follow RFC 2119 for requirement key words:
# adapter MUST provide foo
# adapter SHOULD provide bar
# adapter MAY provide baz
# adapter MUST NOT do mollusk
# ...

For each requirement we should have a runnable piece of code. I agree that test/unit would be nice since it ships with Ruby.

I think I'm gonna get this started today but my t/u fu sucks. You have been warned ;)

@elskwid how do I approach this must/should/may/must not concept using minitest?

...I mean, must/must not are obvious but "may" and "should"??

@solnic Off the top of my head: we would have tests for MUST and MUST NOT then if there are things that MAY and SHOULD be added this could be the configuration we discussed. For instance, an adapter MAY allow writing back to the underlying data store. Is there a test for when it can handle that? If so, then we somehow tell the tests that it's available for linking.

@elskwid ah gotcha, I forgot that we talked about this, geez. I'll add a way to configure the test case class

isn't it done already?


bump to 0.8.1 for release

Requires #264.
Nice to have #265.

Codecov Report

Merging #266 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #266   +/-   ##
=========================================
  Coverage     70.75%   70.75%
  Complexity      546      546
=========================================
  Files            79       79
  Lines          2708     2708
  Branches        274      274
=========================================
  Hits           1916     1916
  Misses          685      685
  Partials        107      107

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a21c90b...2bb7624. Read the comment docs.

Merging this even though #264 isn't completed yet, since it is blocked on upgrading other stuff to grpc 1.2.


Cannot run the tracker after following the instructions on the README.md

Hello,
After following the instructions for running the tracker make, make run and make user all fail  with the same error
git submodule update --recursive --init --rebase
./trackerctl setup bootstrap
Traceback (most recent call last):
  File "/home/neutrin0/Repos/arch-security-tracker/./trackerctl", line 5, in <module>
    cli.main()
  File "/home/neutrin0/Repos/arch-security-tracker/.virtualenv/lib/python3.9/site-packages/flask/cli.py", line 596, in main
    return super().main(*args, **kwargs)
  File "/home/neutrin0/Repos/arch-security-tracker/.virtualenv/lib/python3.9/site-packages/click/core.py", line 1062, in main
    rv = self.invoke(ctx)
  File "/home/neutrin0/Repos/arch-security-tracker/.virtualenv/lib/python3.9/site-packages/click/core.py", line 1668, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/home/neutrin0/Repos/arch-security-tracker/.virtualenv/lib/python3.9/site-packages/click/core.py", line 1668, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/home/neutrin0/Repos/arch-security-tracker/.virtualenv/lib/python3.9/site-packages/click/core.py", line 1404, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/home/neutrin0/Repos/arch-security-tracker/.virtualenv/lib/python3.9/site-packages/click/core.py", line 763, in invoke
    return __callback(*args, **kwargs)
  File "/home/neutrin0/Repos/arch-security-tracker/.virtualenv/lib/python3.9/site-packages/click/decorators.py", line 26, in new_func
    return f(get_current_context(), *args, **kwargs)
  File "/home/neutrin0/Repos/arch-security-tracker/.virtualenv/lib/python3.9/site-packages/flask/cli.py", line 439, in decorator
    with __ctx.ensure_object(ScriptInfo).load_app().app_context():
  File "/home/neutrin0/Repos/arch-security-tracker/.virtualenv/lib/python3.9/site-packages/flask/cli.py", line 395, in load_app
    app = call_factory(self, self.create_app)
  File "/home/neutrin0/Repos/arch-security-tracker/.virtualenv/lib/python3.9/site-packages/flask/cli.py", line 119, in call_factory
    return app_factory(*args, **kwargs)
  File "/home/neutrin0/Repos/arch-security-tracker/tracker/__init__.py", line 95, in create_app
    orm.configure_mappers()
  File "/home/neutrin0/Repos/arch-security-tracker/.virtualenv/lib/python3.9/site-packages/sqlalchemy/orm/mapper.py", line 3350, in configure_mappers
    _configure_registries(_all_registries(), cascade=True)
  File "/home/neutrin0/Repos/arch-security-tracker/.virtualenv/lib/python3.9/site-packages/sqlalchemy/orm/mapper.py", line 3383, in _configure_registries
    Mapper.dispatch._for_class(Mapper).after_configured()
  File "/home/neutrin0/Repos/arch-security-tracker/.virtualenv/lib/python3.9/site-packages/sqlalchemy/event/attr.py", line 256, in __call__
    fn(*args, **kw)
  File "/home/neutrin0/Repos/arch-security-tracker/.virtualenv/lib/python3.9/site-packages/sqlalchemy/orm/events.py", line 743, in wrap
    fn(*arg, **kw)
  File "/home/neutrin0/Repos/arch-security-tracker/.virtualenv/lib/python3.9/site-packages/sqlalchemy_continuum/builder.py", line 163, in configure_versioned_classes
    self.build_transaction_class()
  File "/home/neutrin0/Repos/arch-security-tracker/.virtualenv/lib/python3.9/site-packages/sqlalchemy_continuum/builder.py", line 141, in build_transaction_class
    self.manager.create_transaction_model()
  File "/home/neutrin0/Repos/arch-security-tracker/.virtualenv/lib/python3.9/site-packages/sqlalchemy_continuum/manager.py", line 166, in create_transaction_model
    self.transaction_cls = self.transaction_cls(self)
  File "/home/neutrin0/Repos/arch-security-tracker/.virtualenv/lib/python3.9/site-packages/sqlalchemy_continuum/factory.py", line 9, in __call__
    registry = manager.declarative_base._decl_class_registry
AttributeError: type object 'Model' has no attribute '_decl_class_registry'
make: *** [Makefile:26: setup] Error 1

I suspect the API for sqlalchemy_continuum has changed in later versions and installing it from the requirements.txt got the lastest as no version is specified there.
Maybe specifying the package versions in the requirements.txt would fix this and possible future issues of the same kind.

The solution is:
pip install SQLAlchemy~=1.3.0

See https://github.com/archlinux/arch-security-tracker/pull/186/files

Indeed that fixed it. Maybe adding the version as indicated by the PR would be a good idea for newcomers

Fixed in https://github.com/archlinux/arch-security-tracker/commit/469dac4294b6ca65b9a52b607d119bc6c4aa63ab


Broken link in MG docs

Description:
link to Disabling Security in https://apim.docs.wso2.com/en/latest/deploy-and-publish/deploy-on-gateway/choreo-connect/security/api-authentication/api-authentication/ gives 'Page Not Found'
Link should be updated to https://mg.docs.wso2.com/en/4.0.0/how-tos/security/api-authentication/disabling-security/

This seems to be fixed now.


android: no menu option to subscribe to users posts after unsubscribing

After unsubscribing from a user's posts (unintentionally), I returned to the user's menu in their chat, but there was only a menu option to unsubscribe again.  After unsubscribing, this menu option should flip to allowing me to subscribe again.
Force quitting and restarting the app let me workaround the issue, the menu showed the option to subscribe after this.
This probably affects desktop bruig as well, but untested.

Not sure I've been able to reproduce this.  Which menu are you describing?


New-* cmdlets are idempotent, not throwing  error when resource already exists

By default, we see that New-* cmdlet overwrites the existing resource instead of complaining that the resource already exists.
Our existing modules shows error like below.
New-AzsNetworkQuota : A network quota with the name ExampleQuota at location northwest already exists
As per the discussion with Mark, Resource already error could be thrown easily if the API supports if-none-match:* header indicating the PUT operation to fail if the resource already exists

It is duplicated with https://github.com/Azure/autorest.powershell/issues/569.


⚠ Bofrost.at has degraded performance

In 21b748a, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1617 ms

Resolved: Bofrost.at performance has improved in 21b8313.


Hanging when underlying props / state changes, and isValidDate returns false

I'm Submitting a ...

[x] Bug report
[ ] Feature request
[ ] Support request

Steps to Reproduce

create-react-app
add dependencies (moment, react-datetime).
Replace App.js with code below:

import React, { Component } from 'react';
import logo from './logo.svg';
import './App.css';
import Datepicker from 'react-datetime'

class App extends Component {

  constructor(args) {
    super(args)

    this.state = {
      enabled: true
    }
  }

  valid(d) {
    console.log("checking")
    return this.state.enabled;
  }

  clicked = (e) => {
    console.log(e)
    this.setState(ps => ({"enabled": !ps.enabled}))
  }

  render() {
    return (

Welcome to React

          To get started, edit src/App.js and save to reload.

        <button onClick={this.clicked}>toggle</button>

          <Datepicker isValidDate={x => this.valid(x)} />

    );
  }
}

export default App;

yarn start (or npm equivalent to load the page). The page loads fine, and we see just over 40 log entries.
Click the toggle button. It switches the enabled state to false, which makes isValid always return false.
This will make it got into some loop... very high cpu, and it keeps logging the isValidDate function over and over, until the page crashes. Until the crash, the page becomes unresponsive, and you can either wait for the crash, or use the chrome task manager to kill the tab.
Change the code so that "enabled" state is initially disabled. Things load, there are 42 log entries for the validation function. Hit toggle. The calendar becomes enabled. 42 more entries. Things are ok. Then hit toggle again, so "enabled" returns to disabled. It goes into high cpu, and eventually crashes. There are many log entries in the console.

Expected Results

Returning false from the validation function after some props change shouldn't go into some loop and crash the page.
Actual Results

Described above. If a state / prop changes, and the validation function always returns false, the date picker kills the page.
Minimal Reproduction of the Problem

https://github.com/ashic/react-datetime-bug
Other Information (e.g. stacktraces, related issues, suggestions how to fix)

I am also experiencing this when isValid returns false.

I am experiencing the same when isValidDate returns false.

It's happening to me also.

I suspect this is related to #416 but I haven't had time to investigate.  Does this issue exist on 2.9.0?

Yes it is related. Let me check if is reproducible in the 2.9.0.

Should be fixed on 2.10.3


Details view for player

This task involves creating a details view for a player in a tournament. They should be able to see the tournament type, the rules of the tournament, a list of players in the tournament, and some other details that have not been fully established yet.

For the detail view, staff, non-admin users, and guests (not logged in) are all able to see the information related to the tournament. The fields displayed are ("name", "game", "start_date", "end_date", "max_players", "description", "rules", "draw_rules", "matches", "players", and "winners"). Note that we have merged issues #107 and #105  because currently, we recognize no need to create separate detail views for spectators and players, so only one detail view is created.

Closing Statement:
@rqueiroz20 worked on creating a scratch for what the classes and attributes should look like in the details view
@MikeChen012345 and @MuyanXie worked on implementing the idea in code

Issue Score: Unsatisfactory
Comments:
Marking this as unsatisfactory for grading purposes because this issue was merged with #105


Improve documentation and add pylint checks

Short description

This improves the documentation and adds the docstring checks to pylint.
I finally finished my work on sphinxcontrib-django2, so I can now open this PR for review. Since the number of changed lines is pretty crazy, I don't expect anyone to do a thorough review here. Keep in mind: These changes do not affect the Python code which will run on the production server, but only dev dependencies and docstings. Thus, I think it can be justified to approve the PR without having extensively checked all lines. There will definitely be typos and small mistakes somewhere, but nothing critical which couldn't be fixed later on. That said, I also sorted things differently in src/backend/settings.py, so this file should probably be given a bit more attention. Thanks in advance for anybody who wants to take a look at this PR :joy_cat: :innocent:
Proposed changes

Check docstrings in pylint (fixes #421)
Run Sphinx in nitpicky-mode
Sphinx extended and simple view
Add links to Django documentation for inherited members
Fix incorrect docstrings
Improve documentation of settings
Improve documentation of constants
Optimize duplicated docstring documentation
Use sphinxcontrib-django2, a maintained fork of sphinxcontrib-django
Update of all dependencies
Ignore temporary browserified files
Add continuous integration to documentation (fixes #427)
Remove field public from the POITranslation model (replaced by the status field some time ago)

Resolved issues

Fixes: #421
Fixes: #427

Wow, That's really nice! 👍  I'll wont be able to look upon this for the next week, but on the next weekend I'll might find some sparetime to start with the review :)

Wow, That's really nice! 👍  I'll wont be able to look upon this for the next week, but on the next weekend I'll might find some sparetime to start with the review :)


pkg.module root dir

Hello webpack, I know moment is probably responsible for half of yor issues in the tracker, but I'm hoping to get this right in our next major release.
I know about pkg.module, but I'm wondering if there is a way to specify root directory, instead of just a single file.
For example, if we have the following folder structure:
.
└── dist
    ├── esm
    │   ├── locale
    │   │   ├── de.js
    │   │   └── ru.js
    │   └── moment.js
    └── umd
        ├── locale
        │   ├── de.js
        │   └── ru.js
        └── moment.js

Is there a nice way to have both of these to work
// UMD
requre('moment');            // requires dist/umd/moment.js
require('moment/locale/ru'); // requires dist/umd/locale/ru.js
// ESM
import moment from 'moment'; // requires dist/esm/moment.js
import 'moment/locale/ru';   // requires dist/esm/locale/ru.js

I was adviced here https://github.com/rollup/rollup/issues/2311 to use .js and .mjs per the node.js esm spec.

It looks like you just deleted our lovely crafted issue template. It was there for good reasons. Please help us solving your issue by answering the questions asked in this template. I'm closing this. Please either update the issue with the template and reopen, or open a new issue.


💡[Feature]:Add Breast Cancer Detection:

Is there an existing issue for this?

[X] I have searched the existing issues

Feature Description
Want to Add Breast Cancer Detection model which helps to detect if a person has breast cancer or not. The goal of this project is to build an ML model that can accurately classify whether a tumor is benign or malignant based on various features such as texture, perimeter, and compactness.
Use Case
To detect Breast Cancer.
Benefits
No response
Add ScreenShots
No response
Priority
High
Record

[X] I have read the Contributing Guidelines
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

This is already there in this repo


Cannot read property 'backgroundGeoLocation' of undefined

Hello Chris,
I am using your plug-in in my application. I am using Telerik appbuilder with cordova 3.7. And when I run my application I get above mentioned error. I tried the same thing with cordova 4.0. Can you help me to solve thiis problem?
Thank You,
Meghal

what is the object where you're looking for 'backgroundGeoLocation' ?
It should be window.plugins.backgroundGeoLocation
Check if 'deviceready' event is fired before usage of plugin.

Update?

Hello Chris,
I am extremely sorry, I couldn't get back to you. But thanks a lot for your
support the issue was resolved. I am still exploring the application. I
will let you know if I have any doubts.
Once again thanks a lot.
Regards,
Meghal Modi
On Thu, Aug 6, 2015 at 4:23 PM, Chris Scott<EMAIL_ADDRESS>wrote:

Update?
—
Reply to this email directly or view it on GitHub
https://github.com/christocracy/cordova-plugin-background-geolocation/issues/219#issuecomment-128497144
.

You'll be 100 times happier using the Premium Version.  Android battery-efficiency is at least 10 times greater.
The Premium version now adds battery level & status data to each recorded geolocation.  Here's what a recorded location looks like in Premium Version:
{
    "location": {
        "coords": {
            "latitude":   [Float],
            "longitude":  [Float]
            "accuracy":   [Float]
            "speed":      [Float],
            "heading":    [Float],
            "altitude":   [Float]
        },
        "activity": {                // <-- Android Only
            "type": [still | on_foot | walking | running | in_vehicle | on_bicycle],
            "confidence": [0-100%]
        },
        "battery": {              // <-- iOS & Android
            "level": [Float, 0-1],
            "is_charging": [Boolean]
        },
        "timestamp": [ISO-8601 UTC], // eg:  "2015-05-05T04:31:54Z"
        "is_moving": [Boolean]       // <-- The motion-state when location was recorded.
    }
}


Propose updating samples\MvcSample.Web\Views\Home\ValidationSummary.cshtml

Currently ValidationSummary.cshtml incorrectly displays:

Below are all overloads for Html.ValidationSummary.  You should see 5 validation summary titles and 4 validation summary error messages.

It's missing two new ValidationSummary overloads. I'll add these and clean up the output a bit. In lieu of:
@Html.ValidationSummary(message: "Hello from validation message summary N.")

I'll do something like
@Html.ValidationSummary(message: "ValidationSummary overload: excludePropertyErrors,message,htmlAttributes"

Fixed in 4b1a708ba16ec19e2b85cec67ed0f6f3b6cca3ca


Add "XLS to CSV" converter to preprocess

It seems that "XLS to CSV" converter is somehow half working.
I tried
dim install https://www.city.chofu.tokyo.jp/www/contents/1489047638868/simple/1.xls -n "東京都調布市市立小・中学校一覧" -p xlsx-to-csv

and the result was only 1.xls was downloaded but it was converted to CSV.
I would like to see that both 1.xls and 1.csv are placed in the data_files folder.

What do you mean that "half working"?
OK. I agree with keeping both files.
This issue is low priority
But, I welcome your contributions