Fix issues-3036

ignored headers are added in method buildZuulRequestHeaders in class ProxyRequestHelper in code below:
for (String header : zuulRequestHeaders.keySet()) {
	headers.set(header, zuulRequestHeaders.get(header));
}

I've added a condition to skip these headers:
for (String header : zuulRequestHeaders.keySet()) {
	if (isIncludedHeader(header)){
		headers.set(header, zuulRequestHeaders.get(header));
	}
}

@dev-priporov Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

@dev-priporov Thank you for signing the Contributor License Agreement!

Codecov Report

Merging #3047 into master will decrease coverage by 0.04%.
The diff coverage is 50%.

@@             Coverage Diff              @@
##             master    #3047      +/-   ##
============================================
- Coverage     65.88%   65.83%   -0.05%
  Complexity     1439     1439
============================================
  Files           182      182
  Lines          6750     6755       +5
  Branches        813      814       +1
============================================
  Hits           4447     4447
- Misses         1994     1999       +5
  Partials        309      309

Impacted Files
Coverage Δ
Complexity Δ

...cloud/netflix/zuul/filters/ProxyRequestHelper.java
90.69% <50%> (-0.71%)
54 <0> (ø)

...amework/cloud/netflix/zuul/web/ZuulController.java
87.5% <0%> (-12.5%)
2% <0%> (ø)

...netflix/ribbon/ZonePreferenceServerListFilter.java
61.53% <0%> (-11.54%)
9% <0%> (-1%)

...oud/netflix/ribbon/okhttp/OkHttpRibbonRequest.java
78.72% <0%> (-1.72%)
8% <0%> (ø)

...strix/dashboard/HystrixDashboardConfiguration.java
25.24% <0%> (-0.25%)
5% <0%> (ø)

.../netflix/zuul/filters/post/SendResponseFilter.java
80% <0%> (+0.14%)
35% <0%> (ø)
:arrow_down:

...etflix/turbine/stream/HystrixStreamAggregator.java
78.94% <0%> (+5.26%)
9% <0%> (+1%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13c2500...c151334. Read the comment docs.

are all success checks necessary to complete PR?

client -> zuul proxy -> api service.
After this change, how can zuul proxy not allow forwarding client header information to the api service but allow zuul to generate the same header information to the api service, because the client is not trusted, but the zuul proxy is trusted

Please open a separate issue with a sample that demonstrates the problem


pipeline.js absolute routes are not working as expected v0.11.2

Hello,
When I use bower and put the following config on pipeline.js
var cssFilesToInject = [
  '/bower_components/bootstrap/dist/css/bootstrap.css',
  'styles/**/*.css'
];

The pipeline is not detecting my boostrap file inside the bower_components so the file is not injected. The only way is changing to a relative path:
var cssFilesToInject = [
  '../../bower_components/bootstrap/dist/css/bootstrap.css',
  'styles/**/*.css'
];

The problem is that in my layout.ejs is putting the same relative path.
    <!--STYLES-->
    <link rel="stylesheet" href="../../bower_components/bootstrap/dist/css/bootstrap.css">
    <link rel="stylesheet" href="/styles/importer.css">
    <!--STYLES END-->

The pipeline should put the correct relative path or just accept an absolute path.
Note: I have to move the bower_components folder inside the assets in order to work properly.

I have to move the bower_components folder inside the assets in order to work properly.

Exactly--any assets you want Sails to deal with automatically need to be in the assets folder.  If you need something more advanced, you can build your own Grunt task or come up with another solution entirely!

@Garethderioth I ran into this issue and I made a small workaround for the problem. My assumption is that we should just hook into the sails pipeline. God knows I don't want to recreate it for a 1% problem.
My problem is that I want to leverage npm for all dependencies. Anything less is unacceptable for me. The same could be said for bower, but I just prefer npm. In order to do this I'm going to use npm install like normal, but intercept these npm dependencies during the sails asset pipeline.
tasks/config/copy.js
grunt.config.set('copy', {
    dev: {
      files: [{
        expand: true,
        cwd: './assets',
        src: ['**/*.!(coffee|less)'],
        dest: '.tmp/public'
      }]
    },
    build: {
      files: [{
        expand: true,
        cwd: '.tmp/public',
        src: ['**/*'],
        dest: 'www'
      }]
    },
    jsDeps: {
      files: [{
        '.tmp/public/js/dependencies/jquery.js': './node_modules/jquery/dist/jquery.js',
        '.tmp/public/js/dependencies/bootstrap.js': './node_modules/bootstrap/dist/js/bootstrap.js'
      }]
    }
  });

Insert the new copy:jsDeps so that all build environments will run it.
tasks/register/compileAssets.js
module.exports = function (grunt) {
  grunt.registerTask('compileAssets', [
    'clean:dev',
    'jst:dev',
    'less:dev',
    'copy:jsDeps',
    'copy:dev'
  ]);
};

Finally, in pipeline.js we code this exactly the same way as sails would expect us to.
var jsFilesToInject = [

  // Dependencies
  'js/dependencies/jquery.js',
  'js/dependencies/**/*.js',

  // All of the rest of your client-side js files
  // will be injected here in no particular order.
  'js/**/*.js',

  // Use the "exclude" operator to ignore files
  // '!js/ignore/these/files/*.js'
];

This works as expected and, in my opinion, provides an elegant solution to using a package manager with sails that lives outside the assets/ directory.
However, IMHO, sails should be able to pull from node_modules/ just fine though. Maybe I missed something with that? It is the default package manager for the language your platform is built on.

@vikeen is there a reason you chose to copy to the ./tmp folder instead of the ./assets folder?


ylab doesn't work when type="hist"

Hi,
love the package!
The y-label seems to be not set / overwritten by the default for histograms, xlab works though. MWE:
plt(rnorm(1000), type="hist", ylab="")

Great, thanks for the report. The issue has been fixed recently in #204 but not yet released to CRAN. If you install the development version, your code works as intended:
install.packages("tinyplot", repos = "https://grantmcdermott.R-universe.dev")


Theme voting - Sorting user's votes by time

The votes displayed on the theme slaughter page are indeed my votes, but they are not in the correct order (as added by JavaScript when voting).
I think the fix is just a ORDER BY timestamp DESC here:
https://github.com/ludumdare/ludumdare/blob/master/src/shrub/src/theme/theme_idea_vote.php#L11
(I set up the work environment but I'm not sure if there is a "create test data" command for the database, so I couldn't test this)

There isn't currently a way to generate test data, but #499 is about it

As mentioned in #611, timestamp isn't indexed, but id is. I've already committed the change.
However! This isn't going to work. The way we're populating the array returned by the API actually implicitly sorts them by the key.
function _db_GetPair( &$st ) {
	$result = $st->get_result();
	$ret = [];
	while ($row = $result->fetch_array(MYSQLI_NUM)) {
		$ret[$row[0]] = $row[1];  // this here
	}
	return $ret;
}

So for the change to work, the above code needs to be tweaked to append rather than implicitly insert sort.

Would it be preferable to add another method (e.g. _db_GetOrdered) to use for this? In order to not break any other code that might rely on the key ordering.

Yes, I was just about to say that. Adding a _db_GetPairUnsorted called by db_QueryFetchPairUnsorted, and adjusting the the theme call to use it.

Now _db_GetPairUnsorted and db_QueryFetchPairUnsorted seem badly named, cause the key is ignored :smile:

It actually wont work without the keys. See my comment.

For an update on #611.

I was wrong about the sorting server side. Chrome's preview view when you look at incoming data coming in via XHR requests is sorted, but if you click the next tab (response) you can clearly see the data sorted in whichever order you choose.
The cause of the awkward display order is something on the JavaScript side. I.e. src/com/content-event/event-slaughter.js is where this happens

Ah, I think I found it.
https://github.com/ludumdare/ludumdare/blob/master/src/com/content-event/event-slaughter.js#L44
'recent': Object.keys(r.votes).slice(Start).reverse()

I don't know if state.recent is cached client-side. If not, then Start always ends up equal to 0. Maybe when renavigating to the page multiple times, without actually reloading?
Either way, Object.keys() actually sorts the keys:
var a = [];
a["2"] = "foo";
a["3"] = "bar";
a["1"] = "boo";
console.log(Object.keys(a)); // outputs: ["1", "2", "3"]

String keys actually get cast to int:
var a = [];
a["100"] = "foo";
a["150"] = "bar";
a["50"] = "boo";
console.log(a[150]); // outputs: "bar"
console.log(a); // outputs: [undefined × 49, "boo", undefined × 49, "foo", undefined × 49, "bar"]

So even iterating over keys doesn't help:
for (let key in a){
    console.log(key);
}
// outputs: 50, 100, 150

Not sure how to solve this, unless we change the format passed by the API.

Good work. :smile:
I believe recent is not cached client side. Rather, it gets populated during load of the page. And while you're voting, new entries get added. When the page is refreshed, because you could theoretically be voting on multiple devices (your PC and your phone), we just assume we need a fresh copy of your recent theme list, and request the whole list again.

Actually naw, it looks like both of those are for arrays. I think what you want is to manually build that list using a for in loop.
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/for...in
You can be a little wasteful here, iterating the entire list (since there will only every be a couple thousand entries max). You can use this as your reference:
Object.keys(r.votes).slice(Start).reverse()

In essence, the idea was to take the last several items on the list (wherever Start is supposed to end up), and add them in reverse order.

The problem is, the server supplies a JSON like this:
{
  "caller_id": <some id>,
  "status": 200,
  "votes": {
    "<theme 1 id>": <theme 1 vote>,
    "<theme 2 id>": <theme 2 vote>,
    …
    "<theme N id>": <theme N vote>
  }
}

The votes object is not sorted, it is passed in the order we set server-side. But, it goes through a JSON parser. Which implicitly sorts the array according to the keys.
var obj = JSON.parse('{"votes":{"2":"foo","3":"bar","1":"boo"}}');
console.log(obj.votes); // outputs: Object {1: "boo", 2: "foo", 3: "bar"}

One possible solution is to give the keys a prefix server-side:
var obj = JSON.parse('{"votes":{"t2":"foo","t3":"bar","t1":"boo"}}');
console.log(obj.votes); // outputs: Object {t2: "foo", t3: "bar", t1: "boo"}

Shoot. You're right.
http://stackoverflow.com/a/4515863/5678759
Actually even with a prefix we can't be sure the order will be correct.
Okay, so it looks like this needs to be changed to an actual array server side. That seems like the only way JavaScript will preserve the order when passed through JSON.parse.
In that case, db_QueryFetchPair can become db_QueryFetch. That should emit an array of objects with whatever the key names were (I'm guessing id and theme).

Here's roughly what hack-adding an event looks like.

That should create an event here:
http://ludumdare.org/my-event

More relevant to #499, I'll look into that after this :)

Yep. Here's the part that you'll care about though. You need to then add a piece of metadata to say what theme voting mode the event is in .

0 - null
1 - Theme Suggestions
2 - Theme Slaughter

etc.
You'll have to populate the db some themes. There's a hard limit of 3 per user. It's supposed to be confugurable per event, but I'm not seeing that code anywhere. You probably want to make a couple users so you have enough data. You can logout using this.
http://api.ludumdare.org/vx/user/logout


[SPARK-20689][PYSPARK] python doctest leaking bucketed table

What changes were proposed in this pull request?
It turns out pyspark doctest is calling saveAsTable without ever dropping them. Since we have separate python tests for bucketed table, and there is no checking of results, there is really no need to run the doctest, other than leaving it as an example in the generated doc
How was this patch tested?
Jenkins

Test build #76730 has started for PR 17932 at commit 8890b60.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76730/
Test FAILed.

Merged build finished. Test FAILed.

Jenkins, retest this please

Test build #76736 has started for PR 17932 at commit 8890b60.

Test build #76736 has finished for PR 17932 at commit 8890b60.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76736/
Test PASSed.

LGTM as targeted.

Test build #76753 has started for PR 17932 at commit a5b73ae.

LGTM

Thanks! Merging to master.

Test build #76753 has finished for PR 17932 at commit a5b73ae.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76753/
Test PASSed.

I see I am the one to blame here. Sorry for that @felixcheung

@zero323 That is fine. I should find the issue when I reviewed it.


Adds a progress bar to sync check scripts

Rather than outputting “.” and “x”, report a progress bar to help
developers estimate their time. If you provide a filename as an
argument to a sync check script, it will log all checks to a CSV
Includes a small refactoring of the Sync Check Data Hygiene class

LGTM 👍  🌈
Nice gem too. Bonus points for fun documentation. http://www.rubydoc.info/gems/ruby-progressbar/1.8.1


fix: set sysctl settings for fs.inotify

What problem does this PR solve?:
set sysctl settings for fs.inotify to same as upstream image builder
Which issue(s) does this PR fix?:

*https://jira.nutanix.com/browse/NCN-101967
Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Verified changes on Nutanix VM.
The e2e tests for redhat are failing because of docker pull issue with GHA docker proxy.


Updated for compatibility with Net7

Yeah thats it. Just a version bump to work with the newest version. Tested locally appears to work just fine.

Sorry, I've been having a rough year and took a step back from hobby projects for a while. Never even saw my pull requests until today. I've updated Gearset Helper Plugin for patch 6.5 and Dalamud API v9, and I hope to stay on top of it going forward.


[Additional Parameter Request] Codeunit 99000830 Create Reserv. Entry - OnTransferReservEntryOnAfterUpdateItemTracking

Hi Team,
In codeunit 99000830 we need possibility to have additional checks in the procedure TransferReservEntry. Custom publisher requested in ticket #8395 would suit us if it had additional parameter TransferQty: Decimal.

[IntegrationEvent(false, false)]
local procedure OnTransferReservEntryOnAfterUpdateItemTracking(var ReservationEntry: Record "Reservation Entry"; OldReservEntry: Record "Reservation Entry"; TransferQty: Decimal;var IsHandled: Boolean);

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


feat(ENG-1909): adds tokenize and atomic cards service. deprecates store credit card service

Description

adds tokenize and atomic cards service. deprecates store credit card service

Testing required outside of automated testing?

[x] Not Applicable

Screenshots (if appropriate):

Rollback / Rollforward Procedure

[x] Roll Forward
[ ] Roll Back

Reviewer Checklist

[ ] Description of Change
[ ] Description of outside testing if applicable.
[ ] Description of Roll Forward / Backward Procedure
[ ] Documentation updated for Change

:tada: This PR is included in version 1.17.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Bakai: Fix thumbnail url

Closes #2522
Checklist:

[ ] Updated extVersionCode value in build.gradle for individual extensions
[x] Updated overrideVersionCode or baseVersionCode as needed for all multisrc extensions
[x] Referenced all related issues in the PR body (e.g. "Closes #xyz")
[x] Added the isNsfw = true flag in build.gradle when appropriate
[x] Have not changed source names
[ ] Have explicitly kept the id if a source's name or language were changed
[x] Have tested the modifications by compiling and running the extension through Android Studio
[x] Have removed web_hi_res_512.png when adding a new extension

Did you create the icon from the 512x512 image? It looks a bit blurry.
I cropped the 512x512 version a bit here: ic_launcher.zip


bash script syntax highlighting broken for lines starting with tab + var-inside-string

Type: Bug
New in 1.75.0.
This code doesn't terminate strings properly for syntax color highlights:
#!/bin/bash

function blah {
	script="ls"
	"${script}" -la || exit 1
}

These variants "fix" the problem.
No tab or spaces instead of tab:
#!/bin/bash

function blah {
	script="ls"
    "${script}" -la || exit 1
}

No {} for the var:
#!/bin/bash

function blah {
	script="ls"
	"$script" -la || exit 1
}

VS Code version: Code 1.75.0 (e2816fe719a4026ffa1ee0189dc89bdfdbafb164, 2023-02-01T15:23:45.584Z)
OS version: Windows_NT x64 10.0.19045
Modes:
Sandboxed: No
Extensions (10)

Extension
Author (truncated)
Version

phpserver
bra
3.0.2

gitlens
eam
13.2.0

cmake-language-support-vscode
jos
0.0.9

vscode-dotnet-runtime
ms-
1.6.0

isort
ms-
2022.8.0

python
ms-
2023.2.0

vscode-pylance
ms-
2023.2.20

shader
sle
1.1.5

cmake
twx
0.0.17

php-debug
xde
1.31.1

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.75.1. Please try upgrading to the latest version and checking whether this issue remains.
Happy Coding!

Indeed, looks like this was fixed in 1.75.1! Sorry for the noise. Closing.


Movement

Don't merge this yet. It will add acceleration, and we'll decide if momentum is needed.

Movement speed is based on Settings.unit size now.
Acceleration units are times in milliseconds and uses a linear interpolation.


Update to equations 1.2.3

This moves the 8.11 branch to equations-1.2.3 as well, cleaning the proofs of the [simpl in H; noconf H] pattern.

I think the readme needs to be updated for this. Maybe it is possible to tell devs to use opam install --deps-only instead of explicit pointing out needed dependencies?

Yes, I made both changes to the README now.


require debugkit plugin

@georgeconstantinou Why you added debugkit there?

@flangofas to avoid deployment issues when debug flag is on, see today's conversation https://qobo.hipchat.com/chat/room/2429866 from time 11:15 and onwards.

:+1:


grt:not rerouting simple vertical or horizontal edges on FastRouteCore::fixOverlappingEdge

Signed-off-by: arthur<EMAIL_ADDRESS>Fixes 1639
At FastRouteCore::fixOverlappingEdge, when trying to reroute simple vertical or horizontal, the function routeLShape wasn't updating the edges grids, X and Y, correctly. For example at the Net net83 the edge 74 of the example
Edge grid (x,y) before fixEmbeddedTrees:

Edge grid (x,y) after fixEmbeddedTrees:

This correction doesn't allow this types of edges to be rerouted, and prevent the error on the edges grid
example:
example.zip

If the attached example is small enough it can be turned into a unit test.

The DEF file has 5MB, is it ok?

That a bit big.  Perhaps you can use https://github.com/The-OpenROAD-Project/OpenROAD/blob/master/etc/deltaDebug.py to reduce it while keeping the interesting behavior.

I'm ok to take the test in a follow on PR.  Please work with @eder-matheus to run a secure CI for this change.

@arthurjolo @maliberty I've created a secure- branch for this PR now. When it finishes, I will approve the PR.

Why is this reopened?

nvm I see it wasn't actually merged yet

I just accidentally closed the PR, so I  reopened it


Cleanup + Linux Support

Hi Jean-Christophe,
i would like to contribute a Linux version and cleaned up the repository a little bit and made some code changes:

Moved "SRC" to "src" (Linux filesystem is case-sensitive, so it's really annoying having upper case names)
Removed the direcotries "v1.0.2" and "v1.0.3" - i would like to sugget to attach binary assets to releases, as this is a best practice.
Added some changes to your code to make it support Linux (currently has a "works on my machine state" ;-)).

kind regards,
Christoph

Excellent @happenpappen 👍🏻
I looked it up, it looks good indeed :)
Thank to you!
I'll update this as soon as, attach the binaries to the releases actually and change the readme for the download button links.
Do you think it's necessary to provide a binary version on Linux or users will know how to make it work very easily? :)

Merged! 👍🏻

Just @happenpappen, in "conf.py", are you sure that not call "expanduser()" on the path is always correct on Linux ?
Path('~/.config/')

or
Path('~/.config/').expanduser()

Yes, you're right the ".expanuser()" call is missing by accident and must be added. I'll create another PR for this.


Channel 0 is centered at DC, not CHAN_BW/2

This PR updates the common.chan_to_freq and common.freq_to_chan functions to match what @realtimeradio says they should be.

Thanks for the correction.


Writing all file paths in external JSON file and importing using a function

Lines 30-56 involve manually importing images and sounds into Pygame, but for cleaner code, the file paths can be put into a JSON file and loaded in using a loop. Do consider assigning this issue to me as I can work on it.

🤔Looking Forward to your PR...


pdfslicer: init at 1.8.8

Motivation for this change
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

This actually is a pretty nice tool. I built it on x86_64-linux and played around with the UI. Seems like a good addition that I would personally use from time to time.

Result of nixpkgs-review pr 115627 run on x86_64-linux 1

1 package built:

pdfslicer


Handling errors

Hi
I tried to import a link hash. but when the link is expired the app stops.
I also tried to catch the errors but It stops again with this error:

MTProtoHandler# rpcError 400: INVITE_HASH_EXPIRED
com.github.badoualy.telegram.mtproto.exception.RpcErrorException: 400: INVITE_HASH_EXPIRED
at com.github.badoualy.telegram.mtproto.MTProtoHandler.handleResult(MTProtoHandler.kt:477)
at com.github.badoualy.telegram.mtproto.MTProtoHandler.handleMessage(MTProtoHandler.kt:380)
at com.github.badoualy.telegram.mtproto.MTProtoHandler.onMessageReceived(MTProtoHandler.kt:346)
at com.github.badoualy.telegram.mtproto.MTProtoHandler.access$onMessageReceived(MTProtoHandler.kt:29)
at com.github.badoualy.telegram.mtproto.MTProtoHandler$startWatchdog$2.call(MTProtoHandler.kt:93)
at com.github.badoualy.telegram.mtproto.MTProtoHandler$startWatchdog$2.call(MTProtoHandler.kt:29)
at rx.Observable$11.onNext(Observable.java:4448)
at rx.internal.operators.OperatorDoOnEach$1.onNext(OperatorDoOnEach.java:80)
at rx.internal.operators.OperatorDoOnEach$1.onNext(OperatorDoOnEach.java:85)
at rx.internal.operators.OperatorSubscribeOn$1$1$1.onNext(OperatorSubscribeOn.java:76)
at rx.internal.operators.OperatorObserveOn$ObserveOnSubscriber.pollQueue(OperatorObserveOn.java:202)
at rx.internal.operators.OperatorObserveOn$ObserveOnSubscriber$2.call(OperatorObserveOn.java:162)
at rx.internal.schedulers.ScheduledAction.run(ScheduledAction.java:55)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180)

It seems that error is happening in thread in library so I can't catch it
Do you know anyway to solve this?

You should be able to catch the exception with
try {
     client.importHash...
} catch (RpcErrorException e){

}

If that's not the case I'll check, the error handling in the library is not good for now, I plan to work on this in a few weeks

When I add
`} catch (RpcErrorException e){
}`
It says the exception is never thrown
but when I add this line the "never thrown error" is disappearing
It looks like some methods are not handling RpcException, right?
I know a little in java but not kotlin, Would be glad to help you on this if you want

So having the try/catch fixes the issue?
If yes, then nothing more to do, the issue about Kotlin is that the exceptions are not declared in the method prototype (see https://kotlinlang.org/docs/reference/exceptions.html for more info)
I'll check it when I have some time to force catching the RpcErrorException

I mean import hash method is not throwing RcpException
but authSendCode throws RcpException
Thanks for your time :)

All API methods now throws IO + RpcException.
Close if resolved, if not explain what's missing :)

WOW
What a fast work :)
I'll check it out. closing the ticket for now
thanks again


Children process stuck in deadlock on tcmalloc delete hook

Hi,
My process forks, and sometimes, the children becomes stuck in deadlock on tcmalloc delete hook called from lttng cleanup.
This is the gstack output for the children:
#0  0x00007f62da79bd4b in sys_futex (v3=0, a2=0x0, t=0x7f61f4a69d60, v=2, o=128, a=0x7f62da9b03b8 <heap_checker_lock>) at ./src/base/linux_syscall_support.h:2461
#1  base::internal::SpinLockDelay (w=w@entry=0x7f62da9b03b8 <heap_checker_lock>, value=2, loop=loop@entry=218) at ./src/base/spinlock_linux-inl.h:84
#2  0x00007f62da79bc6f in SpinLock::SlowLock (this=this@entry=0x7f62da9b03b8 <heap_checker_lock>) at src/base/spinlock.cc:119
#3  0x00007f62da784c54 in SpinLock::Lock (this=0x7f62da9b03b8 <heap_checker_lock>) at src/base/spinlock.h:71
#4  SpinLockHolder::SpinLockHolder (l=0x7f62da9b03b8 <heap_checker_lock>, this=<synthetic pointer>) at src/base/spinlock.h:133
#5  DeleteHook (ptr=0x1fdea50) at src/heap-checker.cc:598
#6  0x00007f62da792117 in MallocHook::InvokeDeleteHookSlow (p=p@entry=0x1fdea50) at src/malloc_hook.cc:505
#7  0x00007f62da79d8d5 in MallocHook::InvokeDeleteHook (p=0x1fdea50) at src/malloc_hook-inl.h:138
#8  tcmalloc::invoke_hooks_and_free (ptr=0x1fdea50) at src/tcmalloc.cc:1658
#9  0x00007f62da79df95 in tc_free (ptr=<optimized out>) at src/tcmalloc.cc:1762
#10 0x00007f62d67d5ce3 in objd_table_destroy () at lttng-ust-abi.c:237
#11 lttng_ust_abi_exit () at lttng-ust-abi.c:1002
#12 0x00007f62d67cfb83 in lttng_ust_cleanup (exiting=0) at lttng-ust-comm.c:1807
#13 0x00007f62d67d470f in ust_after_fork_child (restore_sigset=0x7f61f4a6a0f0) at lttng-ust-comm.c:1956
#14 0x00007f62d65b3ab5 in fork () at ustfork.c:51
#15 0x00007f62d4888c1a in dsd::spawnDaemon (path=path@entry=0x7f62d2d8a7e5 "DSD.DistributedStorage", argv=argv@entry=0x7f61f4a6a1f0) at /dev/shm/builds/dsd/20171024T200000_sles12/repo/dsd/source/c++/Utilities_OU/src/util.cc:329
#16 0x00007f62d2d7fb3f in dsd::diststor::Client::Implementation::startServer (networkArg=..., timeout=<optimized out>) at /dev/shm/builds/dsd/20171024T200000_sles12/repo/dsd/source/c++/DistributedStorage_OU/src/Client.cc:579
#17 0x00007f62d48966b4 in std::function<void ()>::operator()() const (this=0x2390600) at /dev/shm/builds/cdf/20171024T200000_sles12/unitprep/TDP-Linux-CXP9050075-<IP_ADDRESS>/contained/DT_LOTCAPI_SLES12/usr/include/c++/4.8/functional:2471
#18 dsd::RequestThread::run (this=0x7f62d4aa42c0 <dsd::RequestThread::get()::requestThread>) at /dev/shm/builds/dsd/20171024T200000_sles12/repo/dsd/source/c++/Utilities_OU/src/RequestThread.cc:73
#19 0x00007f62d62eb650 in ?? () from /usr/lib64/libstdc++.so.6
#20 0x00007f62d5975744 in start_thread () from /lib64/libpthread.so.0
#21 0x00007f62d5c73aad in clone () from /lib64/libc.so.6

I recently upgraded from 2.5 to 2.6, because i saw similar issue, but the problem still persist in 2.6 final.
Any idea ?
BRs

I'd be curious to see what other threads might be doing.
But most likely this is fundamental problem with pthread_atfork. I.e. lttng seems to be using it for some cleanup, and we have it gperftools too (probably we shouldn't). The issue is there is no way for different libraries to agree in what order atfork handlers need to run. So in this case it appears that "before" atfork handler in gperftools have locked page heap spinlock (to ensure consistent page heap in forked child), but child's "after" atfork handler didn't run yet. Instead lttng thingy runs and tries to free something. And that something is deadlocking trying to take page heap lock.
There is no "general" fix. Hopefully your daemon doesn't have any threads at the moment of forking. Or consider not forking for daemon (or triple-forking in helper program).
You can probably "fix" the issue by defining TCMALLOC_NO_ATFORK preprocessor define (e.g. CPPFLAGS=-DTCMALLOC_NO_ATFORK)

Actually, can you try HEAD? Commit eeb7b84c20146c0e2e039ce72a2ea083a94ba80d made stronger attempt to register malloc atfork handler earliest so it may just work in your case.

ok, i will test both things and return back with results. Thank u very much.

The problem has been mitigated but still persist. Fortunately we implemented a spawning mechanism to detect if children process is stuck and kill it. And now, with gperftools 2.6.1, the tcmalloc leaks report is correctly dumped (on previous gperftools 2.5 this never happen in our problem context even killing the children process).
I also try with TCMALLOC_NO_ATFORK, and seems that the children process is also stuck when running with tcmalloc preload. But as i said, now we can gracefully kill the parent and get the complete report. Then we join together both solutions: use 2.6.1 release and control our children process.
Another problem to solve (but not very worry) is that the children becomes defunct (zombie). If i ignore SIGCHLD, the leaks report is not dumped. Waiting for signal also fails to get the report. Then at the moment i do nothing and get the  because this is not growing in our system.
BRs

Thanks for the link. But most likely deadlock was real deadlock w.r.t. atfork handlers and malloc. As noted above, I am fairly certain that we should be as robust as glibc malloc. If someone still sees fork-related deadlocks, on latest code please file a ticket.


Issue 500/sign in modal

This PR:
Resolves #500
1.  Changes styling of "Sign In" button to match "Log In" button
2. shrinks size of input on the SignInModal, so no side scrolling occurs
Screenshots (if applicable):

@leekahung @andycwilliams

Centered title of "Sign In?"
Adjusted buttons a little, but they seem to follow the max size of the text input, not the modal div itself.  Let me know if you have thoughts on that.

3 questions for you both:

Is there any need to have the button and modal say "Sign In" vs the "Login" that the desktop sees?

If not, I can cut a little code down

What do you think of making the "Login" button green when it's in the modal?

Just to match all other modals of "cancel" being red, and "continue" being green

Do we need the subtitle text "Welcome to PASS. Sign in below"

Most other modals like this do not have it, and I'm not sure it provides any value at all

The second was related to the <Autocomplete>, see clip. Was wondering on how we wish to manage the internal vertical scrolling of the modal if users were to select say the servers lower in the recommended list. Could address this in this PR or in another one, either is fine with me.
As for a solution, the first thing that comes in mind was to have the <Autocomplete> vertical scroll instead, but open to alternatives.

Want to make separate issue?

The second was related to the <Autocomplete>, see clip. Was wondering on how we wish to manage the internal vertical scrolling of the modal if users were to select say the servers lower in the recommended list. Could address this in this PR or in another one, either is fine with me.
As for a solution, the first thing that comes in mind was to have the <Autocomplete> vertical scroll instead, but open to alternatives.

Want to make separate issue?

Sounds good to me. Think we could have it set up after the merge.

I think this is all good now. I double approve.


RenderTexture.active state ( from custom blits ) negatively effects spout output

This is a bit of a weird one and not entirely sure you'd consider it a 'responsibility' of Klak Spout to address.
I have a project in Unity (2021.2.8f1) that uses the Kinect to grab and display 'userbody' as silhouettes. Alas when sending the 'gameview' through spout to say Resolume I was getting intermittent flashes of the 'user body' rt over the main output. The culprit was use of Graphic.Blit to transfer the kinect 'userbody' data to a RenderTexture, which happens at a lower frequency that the main project, causing it to flash in the spout output and only the spout output, its not visible in the editor or standalone builds!
Alas its not quite that simple, so I've detailed the specifics below.
So the Kinect library ( Kinect V2 from asset store ) gets raw kinect data ( < 30 fps approx i think ) that it puts into a computeBuffer and then renders that into a RenderTexture via Graphic.Blit and a material. Even when I do nothing more with that RenderTexture just performing the Blit to obtain the data is enough to cause the flashing of that RenderTexture in the spout output.
On a whim I found the Blit code in the Kinect Library I'm using and wrapped it in store/restore of renderTexture.active. To my pleasant surprised this fixed the problem. Alas there are about 40 Blits in the kinect library code and wrapping all them is a bit of pain. Further more though it didn't really explain why in this case it fixed the issue.
Additional testing revealed that the store/restore simply ended up setting renderTexture.active to null after the Blit. Without that code the active rendertexture was being left as the destination of the 'userbody' blit, and hence why I think it was getting into the spout output. There was still a question of why it was getting included, but looking a the SpoutSender.cs code I noticed the use of ScreenCapture.CaptureScreenshotIntoRenderTexture. I surmised, what if Unity's native code was simply grabbing the active rendertexture for this, based on the assumption that it should be null, but as shown above in my case is now pointing to the 'userbody' renderTexture. So I added the following to SpoutSender,
#if KLAK_SPOUT_RT_FIX
RenderTexture previousActive = RenderTexture.active;
RenderTexture.active = null;
ScreenCapture.CaptureScreenshotIntoRenderTexture(temp);
RenderTexture.active = previousActive;
#else
ScreenCapture.CaptureScreenshotIntoRenderTexture(temp);
#endif
Sure enough adding/removing that define to my player settings, and restoring the Kinect Library code to just using the Blit worked! With the fix enabled, no more flashing, with it disabled, I'd see the 'userbody' rt flash.
At this point it would seem clear to me that the Kinect Library not cleaning up the active renderTexture is a bit of a problem, but then so too is the Uniity screenCapture apparently not clearing the active rendertexture ( though I could see that might be a benefit ). This leads to a question of who has responsibility. I could see the argument that the code doing the Blit should restore it, but that could easily lead to a high amount of overhead wrapping every call or sequence of calls to Blit. Alternatively you could argue that if you  want to capture a screenshot you should be expressly setting the active RT and thus its the responsibility of that code. Honestly I'm not sure, I think I favour the latter and therefore never assuming the state of the active RT.
With regard to Klak Spout I do like the 'defensive' approach of wrapping the ScreenCapture and  expressly setting the active renderTexture to null before calling it, but I'm unsure beyond the scope of my project if that has any negative effects.
Any thoughts?
Thanks

Video showing the issue
https://user-images.githubusercontent.com/648081/213987460-8f747893-8e36-4a1c-9de2-f36f88f491c3.mp4

I think your fix makes sense. I'll consider adding it in the next update.

Cool.
But I found something even weirder! I actually had it in my original post above, but deleted it as it was so strange, but have just double checked again and its true.
I add the spout sender to the scene ( only one scene in project ) via instantiating a prefab ( simple gameobject containing the spoutsender component ) at start up based on a flag ( retrieved from ini file ). With no other fixes and instantiating the prefab I get the glitch above. However if I disable instantiating the prefab and just have the prefab be part of the saved scene I don't get the glitch!
I can't explain this, other than perhaps there is something in the Klak spout code that is getting messed up by virtue of spout sender being instantiated into the scene at runtime. Though quite how that relates to rendertexture.active too I have no idea.

I've created a small, simple test case of the blit glitch mentioned above, but more importantly it confirms that placing the SpoutSender into a prefab and instantiating it at runtime is an aspect of the bug.
KlakSpoutBlitBug_2<IP_ADDRESS>1.zip
To test

Open Unity project.
Open the scene.
Open a Spout viewer ( e.g. Resolume or OBS ) assign 'Sprout Sender' as the spout input name.
Run Unity

GameObjects

Spout Launcher will instantiate the Spout prefab if none is found in the scene.
Blitter - will randomly perform a blit.
------ Frequency of blits is controlled by the component via slider.
------ Toggle button allows you to enable/disable wrapping the blit call with renderTexture.active.

Default is for Sprout Launcher to add the SpoutSender to the scene via instantiate.
To test with SpoutSender already in the scene, just drag the Spout prefab into the scene and save.
Results
SpoutSender - SCENE   |  Wrap Blit calls - DISABLED  |  Klak Spout Fix - DISABLED    = No Glitch
SpoutSender - SCENE   |  Wrap Blit calls - ENABLED   |  Klak Spout Fix - DISABLED    = No Glitch
SpoutSender - SCENE   |  Wrap Blit calls - DISABLED  |  Klak Spout Fix - ENABLED     = No Glitch
SpoutSender - PREFAB |  Wrap Blit calls - DISABLED  |  Klak Spout Fix - DISABLED    = Glitch
SpoutSender - PREFAB |  Wrap Blit calls - ENABLED   |  Klak Spout Fix - DISABLED    = No Glitch
SpoutSender - PREFAB |  Wrap Blit calls - DISABLED  |  Klak Spout Fix - ENABLED     = No Glitch
So while there can be an issue with Graphics.Blit calls, they only exhibit in my test case when instantiating a prefab of SpoutSender. In that case the glitch can be addressed by wrapping the blit with renderTexture.active ( either directly or in Klak.Spout ). If the SpoutSender is present in the scene by default there is never a glitch!
Honestly cannot explain this weirdness, but i'm assuming its something in the way Klak.Spout is initiated or some other weird combination of factors of Unity, Spout.


VenusOS 2.80 compatibility

Check compatibility with VenusOS 2.80
In Venus 2.80, the rootfs is now read-only. To install the service, you need to remount it rw (which you can do with the script /opt/victronenergy/swupdate-scripts/remount-rw.sh), and then the service needs to be installed in /opt/victronenergy/service instead (which is overlayed onto /service at bootup, but reset to original at each boot).

Sorry, could you clarify this please? I've tried this to copy it to the service folder but no joy
cp /data/etc/dbus-serialbattery/service/ /opt/victronenergy/service/dbus-serialbattery/ -R

Those are notes in the ticket of what I need to look at to get the driver compatible with 2.80.
It is best to stay on the 2.7* venusOS until the driver is tested, before moving to 2.80

Beta v0.8beta1 include Venus OS v2.80 changes.
Some GObject warnings are still there for now.
@pau1phi11ips if you want to test on v2.8 just make sure you remove any files and the folder you might have created at /opt/victronenergy/service/dbus-serialbattery/ before you reboot the device.
So on a V2.72 / V2.73 device you will need to update the driver first, then update the firmware to 2.80 and the battery will still be there on V2.80

Sorry, been crazy busy. I'll try and test later today.
I've got a kinda odd setup using the Victron ESS and it didn't actually work with 2.73 and 2.80 fixed the issue so would prefer to stick with that.

Hi any news about testing 2.8v?

Do you mean if anyone has given feenback on the beta version for the driver? Then yes I have at least 1 person that gave feedback that it is running successfully.

OK, are you planning to merge into the master any time soon? As I want to give it a try as well.

Yes, If I can get one more feadback I will merge it into master.

when I run it directly it is working but as service I am getting those:
root@einstein:/opt/victronenergy# sh serial-starter/serial-starter.sh
find: /service/dbus-serialbattery/service/service/service/service/service/service/service/service/service/service/service/service/service/service/service/service/service/service/service/service/service/service/service/service/service/service/service/service/service/service/service/service/service/service/service/service/service/service/service/service: Too many levels of symbolic links
find: /service/dbus-serialbattery.ttyUSB0/service/service/service/service/service/service/service/service/service/service/service/service/service/service/service/service/service/service/service/service/service/service/service/service/service/service/service/service/service/service/service/service/service/service/service/service/service/service/service: Too many levels of symbolic links
serstart starting
INFO: loading config file /etc/venus/serial-starter.conf
INFO: loading config file /data/conf/serial-starter.d

Can you tell me if you install the updated driver before you installed venus 2.8 or afterwards?
If afterwards, did you do a reboot of the system?

before, and after just update rc.local, etc and conf folder.

The reboot (or initial boot with firmware) will run the rc.local and it creates the required symbolic links.
But the build itself also has permissions on the files that is needed.
Can you install it using these 2 commands and see if that helps. You will need to reboot so it will run the rc.local file
wget https://github.com/Louisvdw/dbus-serialbattery/releases/download/v0.8beta1/venus-data.tar.gz
tar -zxf venus-data.tar.gz -C /data

Chmod fixed that sorry, I had missed that.

Is it working now?

yes

ok great. I will merge the 2.80 changes then

@Louisvdw Today I tested the 0.8 version today, first upgraded dbus-serialbattery the upgraded my venus GX to version 2.80~17. After the reboot I got some BMS alarms, but the BMS info is gone on VRM and in the remote console. This can be some simple python bug causing the service to not start, or something more severe.
Since I seem to have lost my reverse tunnel in the upgrade I have no way to access my venus to debug this. With a bit of luck I'm back at my boat at the end of next week... so till then I'm locked out.

Hi @SanderV4n
The first thing to try is to reboot the GX when you have access to it. There is some extra symlinks that are needed for the new venusOS version to work and that sometimes does not get created the first boot.
If that does not work, then post the log file here so we can see what the issue is. (see troubleshoot section of the wiki)

I tried to reboot multiple times via the remote console, but did not help.
I wont be able to have a look at the logs till i'm back at my boat, that will be next Thursday or Friday I hope.

@Louisvdw I tried again, downgrading to 2.73, then back to 2.80. In 2.73 it still works, in 2.80 it does not work.
I checked the serial starter log:
root@beaglebone:~# tail -f /data/log/serial-starter/current
@4000000061502767183cc7d4 ERROR: no service template for dbus-serialbattery
So there seems to be something wrong with the service.

@SanderV4n can you tell me which method did you use to upgrade the serial battery driver? Did you download the driver to a USB-Flash drive, or did you run the install script from the device through SSH?

Hi @Louisvdw, I extracted the archive as described on the wiki under:
"install Spesific version/testing option:"

I assume then you use the beta still. It should be very close to the released version, but it is a bit behind. Just check the v0.8 release as well which is the very latest.

I used the latest 0.8 release.

Hi, also using 2,80 BETA now
ls -lh /data/logs gives
drwx------    2 root     root        4.0K Sep 30 14:37 dbus-serialbattery.TTY
drwx------    2 root     root        4.0K Sep 29 05:14 dbus-serialbattery.ttyACM0
drwx------    2 root     root        4.0K Sep 26 15:47 dbus-serialbattery.ttyUSB0
so the 0.9 Beta is not finding the rigth tty I think.
Errors in current File:
@400000006155cd2414f092a4   File "/opt/victronenergy/dbus-serialbattery/dbus-serialbattery.py", line 57, in get_battery_type
@400000006155cd2415b2d51c     if test.test_connection() is True:
@400000006155cd2415b2f45c   File "/data/etc/dbus-serialbattery/sinowealth.py", line 38, in test_connection
@400000006155cd2415b303fc     result = self.read_status_data()
@400000006155cd2415b30bcc   File "/data/etc/dbus-serialbattery/sinowealth.py", line 74, in read_status_data
@400000006155cd2415b31b6c     status_data = self.read_serial_data_sinowealth(self.command_status)
@400000006155cd2415b57114   File "/data/etc/dbus-serialbattery/sinowealth.py", line 249, in read_serial_data_sinowealth
@400000006155cd2415b5849c     data = read_serial_data(self.generate_command(command), self.port, self.baud_rate, self.LENGTH_POS, self.LENGTH_CHECK, int(self
@400000006155cd2415b59c0c   File "/data/etc/dbus-serialbattery/sinowealth.py", line 245, in generate_command
@400000006155cd2415b61cf4     buffer[1] = command
@400000006155cd2415b716f4 TypeError: 'bytes' object cannot be interpreted as an integer

if you want a ssh to the cerbo, tell me with pm

on 2.73 also errors with 0,9 BETA. TTY is found correct (ACM0) but not working:
@400000006155cf01248382e4 No handlers could be found for logger "SerialBattery"
@400000006155cf092b2301c4 Traceback (most recent call last):
@400000006155cf092b2324ec   File "/opt/victronenergy/dbus-serialbattery/dbus-serialbattery.py", line 108, in
@400000006155cf092b23348c     main()
@400000006155cf092b233874   File "/opt/victronenergy/dbus-serialbattery/dbus-serialbattery.py", line 78, in main
@400000006155cf092b234814     battery = get_battery_type(port)
@400000006155cf092b234fe4   File "/opt/victronenergy/dbus-serialbattery/dbus-serialbattery.py", line 57, in get_battery_type
@400000006155cf092b277a4c     if test.test_connection() is True:
@400000006155cf092b2789ec   File "/data/etc/dbus-serialbattery/sinowealth.py", line 39, in test_connection
@400000006155cf092b2795a4     result = result and self.read_remaining_capacity()
@400000006155cf092b27a15c   File "/data/etc/dbus-serialbattery/sinowealth.py", line 162, in read_remaining_capacity
@400000006155cf092b27b0fc     self.total_ah_drawn = self.capacity - self.capacity_remain
@400000006155cf092b286894 TypeError: unsupported operand type(s) for -: 'NoneType' and 'float'
@400000006155cf17156a529c No handlers could be found for logger "SerialBattery"
@400000006155cf1c0fc91594 Traceback (most recent call last):
@400000006155cf1c0fcb24ec   File "/opt/victronenergy/dbus-serialbattery/dbus-serialbattery.py", line 108, in
@400000006155cf1c0fcd8a34     main()
@400000006155cf1c0fcf18a4   File "/opt/victronenergy/dbus-serialbattery/dbus-serialbattery.py", line 78, in main
@400000006155cf1c0fd16a64     battery = get_battery_type(port)
@400000006155cf1c0fd20a8c   File "/opt/victronenergy/dbus-serialbattery/dbus-serialbattery.py", line 57, in get_battery_type
@400000006155cf1c0fd33f24     if test.test_connection() is True:
@400000006155cf1c0fd3c00c   File "/data/etc/dbus-serialbattery/sinowealth.py", line 39, in test_connection
@400000006155cf1c0fd4d94c     result = result and self.read_remaining_capacity()
@400000006155cf1c0fd55e1c   File "/data/etc/dbus-serialbattery/sinowealth.py", line 162, in read_remaining_capacity
@400000006155cf1c0fd7fdfc     self.total_ah_drawn = self.capacity - self.capacity_remain
@400000006155cf1c0fd951d4 TypeError: unsupported operand type(s) for -: 'NoneType' and 'float'

@dakoal if I remember we said you don't have the Sinowealth, but the normal Daly (from the cell logging ticket). So it just very strange that you end up with the Sinowealth which is the very last driver currently being tested.
Do you see any message in your log file like:
Connection established to ...

root@einstein:/tmp# grep "established" /data/log/serial-starter/current
root@einstein:/tmp# grep "established" /data/log/dbus-serialbattery.ttyUSB0/current
root@einstein:/tmp#
I have a ssh and HTTP port opened. How to send you a PM?

In the windows tool from daly I can see also single cell voltages and change all parameters.

I don't think github has PM functionality. Best would be https://energytalk.co.za/u/louisvdw/
But I think I can see what the issue is. Let me make some changes that you can test.

Get the latest of these 2 files and replace the ones one your GX.
https://github.com/Louisvdw/dbus-serialbattery/blob/bugfixes0.9/etc/dbus-serialbattery/sinowealth.py
https://github.com/Louisvdw/dbus-serialbattery/blob/bugfixes0.9/etc/dbus-serialbattery/utils.py
Then check the dbus-serialbattery.ttyACM0 log and see if it connect now.

@400000006155dee91532912c *** CCGX booted (0) ***
@400000006155df0a0023f514 WARNING:SerialBattery:dbus-serialbattery v0.9beta1
@400000006155df0a00528ec4 WARNING:SerialBattery:Testing LltJbd
@400000006155df0a11635504 ERROR:SerialBattery:>>> ERROR: No reply - returning
@400000006155df0a11e0b2c4 WARNING:SerialBattery:Testing Ant
@400000006155df0a22f95c8c ERROR:SerialBattery:>>> ERROR: No reply - returning
@400000006155df0a23724994 ERROR:SerialBattery:>>> ERROR: Incorrect Data
@400000006155df0a237d8c64 WARNING:SerialBattery:Testing Daly
@400000006155df0a27ce6824 WARNING:SerialBattery:Connection established to Daly
@400000006155df0a2d0375dc WARNING:SerialBattery:Battery connected to dbus from /dev/ttyUSB0
@400000006155df0d1242bc6c Traceback (most recent call last):
@400000006155df0d12516654   File "/data/etc/dbus-serialbattery/dbushelper.py", line 140, in publish_battery
@400000006155df0d1358d7bc     self.publish_dbus()
@400000006155df0d135ddce4   File "/data/etc/dbus-serialbattery/dbushelper.py", line 155, in publish_dbus
@400000006155df0d146050f4     midpoint, deviation = self.battery.get_midvoltage()
@400000006155df0d14659c6c   File "/data/etc/dbus-serialbattery/battery.py", line 190, in get_midvoltage
@400000006155df0d1484d49c     half1voltage += self.cells[c].voltage
@400000006155df0d1487f17c IndexError: list index out of range

@dakoal @Louisvdw These are some Pyhon3 / Venus 2.80 issues, which I shortly observed and started to fix but lost connection to my boat, so unable to debug/test and fix. I will not be at the boat till end of next week, so wont be able to test the 0.9 version till then.

That is the midvoltage graph calculations that is giving issues (something new)

@dakoal Get this updated file as well and test again
https://github.com/Louisvdw/dbus-serialbattery/blob/bugfixes0.9/etc/dbus-serialbattery/battery.py

It's working now.
DALY BMS on TTL-USB Converter
venus OS 2.80~21 on Cerbo
serialbattery driver 0.9beta with the files changed from you

Only until changing loglevel to info
@400000006155ebad268adfec INFO:SerialBattery:Starting dbus-serialbattery
@400000006155ebad269be74c WARNING:SerialBattery:dbus-serialbattery v0.9beta1
@400000006155ebad26b631c4 WARNING:SerialBattery:Testing LltJbd
@400000006155ebad37a2551c ERROR:SerialBattery:>>> ERROR: No reply - returning
@400000006155ebad37db89a4 WARNING:SerialBattery:Testing Ant
@400000006155ebae0d2e6d84 ERROR:SerialBattery:>>> ERROR: No reply - returning
@400000006155ebae0d68367c ERROR:SerialBattery:>>> ERROR: Incorrect Data
@400000006155ebae0d767304 WARNING:SerialBattery:Testing Daly
@400000006155ebae14b88ae4 INFO:SerialBattery:DalyBMS 16 cells
@400000006155ebae14cdd034 WARNING:SerialBattery:Connection established to Daly
@400000006155ebae1c22d7bc WARNING:SerialBattery:Battery connected to dbus from /dev/ttyUSB0
@400000006155ebb10d84bf2c Traceback (most recent call last):
@400000006155ebb10d84de6c   File "/data/etc/dbus-serialbattery/dbushelper.py", line 140, in publish_battery
@400000006155ebb10d84ee0c     self.publish_dbus()
@400000006155ebb10d84f1f4   File "/data/etc/dbus-serialbattery/dbushelper.py", line 201, in publish_dbus
@400000006155ebb10d850194     self.battery.log_cell_data()
@400000006155ebb10d850964   File "/data/etc/dbus-serialbattery/battery.py", line 242, in log_cell_data
@400000006155ebb10d85151c     cell_res += "[{0}]{1}V ".format(c+1, self.cells[c].voltage)
@400000006155ebb10d86f594 IndexError: list index out of range

setting back to warning everything is fine

Its a mess to not been able to send you a pm for ssh/web to my cerbo.

fixed in https://github.com/Louisvdw/dbus-serialbattery/releases/tag/v0.9beta2


Logger interface issue?

SafeCharge\Api\HttpClient::handleResultError() must be an instance of Psr\Log\LoggerInterface, instance of SafeCharge\Api\Logger given, called in /var/www/html/test/vendor/safecharge-international/safecharge-php/src/SafeCharge/Api/HttpClient.php on line 60 and defined

Hi @sionghuat ,
Please update the PHP SDK, because this issue was fixed.
Regards,
Emil Georgiev
SafeCharge


Silver and Copper to be null when change from single

Currently, Gold gets set to null and Silver/Copper gets set to 0 when switching out of isSingleInput-mode.
Both silver/copper should get set to null.

This was fixed as of Polymer 2 updates.


[feature request] : accept "latest" as platform-version in ARDUINO_PLATFORM

Hi,
thanks for this great project :+1:
Some context: one of my workflows creates a multidimensional matrix from different combinations of platform/architectures/board/version.
I'm running arduino-test-compile a a step in that matrix:
    steps:
      - name: Checkout
        uses: actions/checkout@v2
        with:
          ref: ${{ github.event.pull_request.head.sha }}

      - name: Compile example
        uses: ArminJo/arduino-test-compile@v3
        with:
          arduino-board-fqbn: ${{matrix.platform}}:${{matrix.archi}}:${{matrix.board}}
          arduino-platform<EMAIL_ADDRESS>          platform-url: ${{ matrix.platform-url }}
          required-libraries: ${{ matrix.required-libraries }}
          extra-arduino-cli-args: ${{ matrix.cli-args }}

The ${{matrix.***}} variables are dynamic but the separators : and @ aren't.
So if one of them is missing, the FQBN becomes invalid.
          arduino-platform<EMAIL_ADDRESS>
So far so good, everything works fine as long as I'm implicitely listing all package versions I want to be tested.
However this requires maintenance every time a new package version appears (e.g. esp32 recently released 2.0.5 package).

Here's what I tried to achieve when I was still full of illusions, believing the Arduino CI woud somehow read my mind :-)
set ${{matrix.platform-version}} to latest

Of course it fails!

Here's the detached approach I'm using if it can be of any help, it blindly removes all instances of @latest from the concatenated arduino-platform string, I'm not sure how it behaves with arrays though.
- name: FBQN Check
  run: |
    export ARDUINO_PLATFORM="${${{matrix.platform}}:${{matrix.archi}}@${{matrix.platform-version}}/@latest/""}"
    echo "ARDUINO_PLATFORM=$ARDUINO_PLATFORM" >> $GITHUB_ENV

- name: Compile example
  uses: ArminJo/arduino-test-compile@v3
  with:
    arduino-board-fqbn: ${{matrix.platform}}:${{matrix.archi}}:${{matrix.board}}
    arduino-platform: ${{env.ARDUINO_PLATFORM}}
    platform-url: ${{ matrix.platform-url }}
    extra-arduino-cli-args: ${{ matrix.cli-args }}
    sketch-names: ${{ env.SKETCH_NAME }}

Please try the updated version and provide a link to your 3 dimensional matrix build script, which I can include as a reference in my documentation.

Thanks for the quick reply !
The workflow is still being edited, it's still focused on ESP32 boards so I'm not sure it would be a relevant example:
https://github.com/tobozo/YAMLDuino/blob/1.2.9/.github/workflows/ArduinoBuild.yml
Some feedback after selecting ArminJo/arduino-test-compile@master in the workflow:
Custom @latest version value in arduino-platform works as expected :partying_face:
I'm also getting a lot of Node.js 12 actions are deprecated warnings.

I'm also occasionnaly getting some download errors, while this is probably more related to the network stability and submarines cutting undersea cables, I managed to capture one of those errors.

Of course the build fails consecutively, but the job reports another type of error which can be cryptic to understand the real cause is burried in the logs with more operations that had no reason to happen after that network failure.
It feels like the script could fail earlier e.g. right after  Invalid argument passed: Found 0 platform for reference "esp32:esp32": instead of going further.

Here's the build run just in case you can access that.

Thanks a lot for the suggestion of early exit 🥇 👍
It is now implemented 😀


Unable to open a custom SharePoint form in a SharePoint tab in the new Teams desktop client

Target SharePoint environment
SharePoint Online
What SharePoint development model, framework, SDK or API is this about?
💥 SharePoint Framework
Developer environment
None
What browser(s) / client(s) have you tested

[ ] 💥 Internet Explorer
[ ] 💥 Microsoft Edge
[ ] 💥 Google Chrome
[ ] 💥 FireFox
[ ] 💥 Safari
[ ] mobile (iOS/iPadOS)
[ ] mobile (Android)
[ ] not applicable
[X] other (enter in the "Additional environment details" area below)

Additional environment details

New Teams Desktop Client > SharePoint tab

Describe the bug / error
While opening a custom form from a list view in a SharePoint tab in the new Teams desktop client, spserviceworker cuts off authentication cookies and finally redirects to login.microsoft.com:

listform.aspx redirects to the right URL (a custom form)
spserviceworker (https://res-1.cdn.office.net/files/odsp-web-prod_2023-12-01.001/spserviceworker.js) doesn't pass authentication cookies (SPOIDCRL)
Redirects to /_layouts/15/Authenticate.aspx
Redirects to /_forms/default.aspx
Redirects to https://login.microsoftonline.com/

Network logs:

Steps to reproduce

Create a custom form for a SharePoint list or just add assign any page from the same site to ContentType.DisplayFormUrl
https://learn.microsoft.com/en-us/previous-versions/office/sharepoint-csom/ee540653(v=office.15)
Add a SharePoint tab in the New Teams desktop client and select the SharePoint list with customized form
Open a form
You'll get an empty page (login.microsoftonline.com)

Expected behavior
How it works in the old Teams desktop client:

The custom SharePoint form created using the  tutorial is not functioning in the new Microsoft Teams desktop version.
Environment:
Microsoft Teams Desktop Version: 23320.3027.2591.1505
Client Version: 49/23113028718
Steps to Reproduce:

Create a custom form using the tutorial
Create a SharePoint tab in Misrosoft Teams with a list view
Try to open list item form

Expected Behavior:
List form opens normally
Actual Behavior:
Blank screen appears
Logs:
Refused to display 'https://login.microsoftonline.com/' in a frame because it set 'X-Frame-Options' to 'deny'.
Screenshots:
Number of redirects happen in MS Teams tab, but  /_layouts/15/SPListForm.aspx never loads

This happens because /_layouts/15/listform.aspx does not pass auth cookie

Normal behaviour in SharePoint

Any updates on the issue?


Fixed colcon build args

Added --symlink-install arg to colcon build command. Otherwise nav2_common may give build error. Additionaly, it would be great to apply direction inside navigation2 repo : https://github.com/ros-navigation/navigation2/blob/44a69ccde93514ed1a962b7f18cb101ec671d93a/Dockerfile#L119

For my case, i'm trying to implement a kind of nav2 controller and when i compiled with colcon build --packages-up-to nav2_frenet_ilqr_controller --symlink-install, i receive some below error. (i sourced before)
root@jarbay51:~/nav2_ws# colcon build --packages-up-to nav2_frenet_ilqr_controller --symlink-install
Starting >>> nav2_common
Starting >>> frenet_trajectory_planner
--- stderr: nav2_common
failed to create symbolic link '/root/nav2_ws/build/nav2_common/ament_cmake_python/nav2_common/nav2_common' because existing path cannot be removed: Is a directory
gmake[2]: *** [CMakeFiles/ament_cmake_python_symlink_nav2_common.dir/build.make:70: CMakeFiles/ament_cmake_python_symlink_nav2_common] Error 1
gmake[1]: *** [CMakeFiles/Makefile2:138: CMakeFiles/ament_cmake_python_symlink_nav2_common.dir/all] Error 2
gmake: *** [Makefile:124: all] Error 2
---
Failed   <<< nav2_common [0.54s, exited with code 2]
Aborted  <<< frenet_trajectory_planner [1.33s]

Summary: 0 packages finished [1.50s]
  1 package failed: nav2_common
  1 package aborted: frenet_trajectory_planner
  1 package had stderr output: nav2_common
  9 packages not processed
root@jarbay51:~/nav2_ws#

Maybe worth having an ARG for build flags that you could use to set symlink install (or other potential mods).


New Account Creation (MHW)

Enable account creation with zero balance from MyHbarWallet.

Is this something MHW still plans to implement?
It'd be quite helpful versus the current "find someone else to share your pub key with" method MHW uses
Otherwise, we should close the issue, given its > 1 year old


Fixed Typo: Hided => Hidden

Fixed typo in section about the hideable sidebar. 'hided' is used instead of 'hidden'.
Motivation
Recently started familiarizing myself with Docusaurus. I was reading the documentation and noticed the typo.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Simple type fix.

LGTM thanks ;)

Thanks for your hard work on this @slorber. I love this tool!

thanks 👍
Commited on your pr to trigger CI, as we had some CI issues


Update vertx opentracing example to include useful demo scripts

@pavolloffay Could you review please?

Merging as only adding scripts to example for demo - if any issues then can fix in separate PR.


Compression flag

Implement suggestion here by davinci26

sorry for commenting so late in the process but I think given that there are a lot of compression algorithms supported by envoy. Some of them much better than gzip like zstd I think we might want to change the api to allow the user to choose the compression algorithm and have an option called nocompression that disables it

Adds support for the three algorithms supported in github.com/envoyproxy/go-control-plane/envoy/extensions/compression, i.e. gzip, brotli, zstd.
Rather than a separate nocompression flag, just provide an additional compression option disabled.

The upgrade tests are failing with
./test/scripts/kind-load-contour-image.sh
fatal: No names found, cannot describe anything.
CONTOUR_UPGRADE_FROM_VERSION= \
	CONTOUR_E2E_IMAGE=ghcr.io/projectcontour/contour:7e843b7a \
	go run github.com/onsi/ginkgo/v2/ginkgo -tags=e2e -mod=readonly -randomize-all -poll-progress-after=300s -v ./test/e2e/upgrade

Not 100% sure why that is, possibly something to do with actions/checkout on a branch? I think this change is sufficiently advanced to make it worth merging to chaosbox/main, and working on resolving any futher test failures there.


Inconsistency between java client and OpenSearch update by query responses

Description
Inconsistency between java client and OpenSearch update by query responses
Issues Resolved
Closes https://github.com/opensearch-project/spring-data-opensearch/issues/387
Check List

[ ] New functionality includes testing.

[ ] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dblock mind please taking a look? thank you


TypeError: undefined is not an object (evaluating 'phantomArgs.forEach')

Please help me, i have problem, i'm got error message 'TypeError: undefined is not an object (evaluating 'phantomArgs.forEach')'

Please address your question to the mailing list and give at least CasperJS version, engine (PhantomJS, SlimerJS) and engine version when asking for help.
Seems you're using a deprecated API. See also other projects having this problem, e.g. https://github.com/jamesgpearce/confess/issues/9, https://github.com/marcelduran/yslow/issues/129.


V0p3p6e

Codecov Report
Attention: Patch coverage is 28.38428% with 164 lines in your changes are missing coverage. Please review.

Project coverage is 77.44%. Comparing base (269d2ea) to head (b648699).
Report is 37 commits behind head on master.

Files
Patch %
Lines

src/ModelConfigurations.jl
28.38%
164 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff             @@
##           master      #93       +/-   ##
===========================================
- Coverage   87.45%   77.44%   -10.01%
===========================================
  Files           8        9        +1
  Lines         901     1184      +283
===========================================
+ Hits          788      917      +129
- Misses        113      267      +154

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


chore: release 1.2.265

:robot: I have created a release *beep* *boop*
1.2.265 (2023-10-13)
Features

option to disable registry login in "werf ci-env" (170d068)

Bug Fixes

forbid "werf run" in Buildah mode (09fb5bd)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/werf/werf/releases/tag/v1.2.265 :sunflower:


chore(main): release 0.16.0

:robot: I have created a release beep boop
0.16.0 (2024-08-16)
Features

完善禁用登录功能 (a5e145a)
新增路由对于地址栏 url 的响应，无论是否启用登录皆有效 (7060eeb)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

v0.16.0
:sunflower:


common: fixed build issues

not able to compile with latest zig 0.11.0-dev.1638+7199d7c77

Hello, thanks for the patch but zig-wayland has the policy of supporting only the latest zig release, not master branch.
I will personally update to the zig master branch shortly before 0.11.0 is released to make sure there are no regressions affecting zig-wayland but I do not have any plans to maintain a branch compatible with zig master throughout the entire zig release cycle.

understood. I fixed the build issues while compiling rivercarro project, zig-wayland is a dependency to that project. I fixed those build issues, thought of providing that fixed changes.

I believe rivercarro also depends on Zig 0.10 and is not compatible with zig master.

yes, rivercarro also tracks zig stable releases and the author also told he will fix any build issues once zig 0.11 comes out.


Add is excluded-from-valuetype

This is useful for attributes that are only used as a cache.
class Point does ValueType {
    has $.x = 0;
    has $.y = 0;

    has $!distance-from-origin is excluded-from-valuetype;
    method distance-from-origin () {
        $!distance-from-origin //= sqrt $!x² + $!y²
    }
}

my $a = Point.new( x => 30, y => 40 );
my $b = Point.new( x => 30, y => 40 );

say $a.distance-from-origin; # 50
# $!distance-from-origin in $a is now 50
# but is still undefined in $b

say $a === $b; # True
# only $!x and $!y are included in .WHICH

It also fixes a thinko.
The .name of the $!WHICH attribute is $!WHICH not WHICH
::?CLASS.^attributes.grep: *.name ne 'WHICH'

should have been:
::?CLASS.^attributes.grep: *.name ne '$!WHICH'

I'm not entirely sure why ::?CLASS.^attributes doesn't include $!WHICH.
It may be that the code is run before the role gets applied.

Implemented in https://raku.land/zef:lizmat/ValueType?v=0.0.6 . Sorry for letting this fall through the cracks.


changed init methods of response_objects to match init(self, data)

Changed all init methods except for chart_data.py

I dont thinkt the gitignore is supposed to be there.
I think it came when i put some of the stuff that visual studio installed in my folder into ignore so it does not get commited with.

@SSchulze1989 you can add those kinds of things your global gitignore if you don't want to commit it for any projects at all: https://gist.github.com/subfuzion/db7f57fff2fb6998a16c. Personally I don't really care though


Opaque token bearer authorization

Expected Behavior

documentation suggesting how to tackle opaque token bearer configuration in authorization server setup
indication of future code solution or clear explanation that it is left to our implementations
in a perfect world - available out of the box and easily customisable bean bridging current gap

Current Behavior
Projects documentation indicates only how to configure jwt self-contained token bearers: https://docs.spring.io/spring-authorization-server/docs/current/reference/html/guides/how-to-userinfo.html

Similar configuration using opaque token seems to provide only one instance of OpaqueTokenIntrospector that would be available out of the box which as far as I can tell would work only if all the bearer token internal introspection calls used the same credentials (i.e. server had only one client using opaque token bearer). No clear indication of intended use of available classes in authorization server.
Context

I assume no changes to other functionalities i.e. the way introspection endpoint works, which potentially could be a way to work it around in an altogether different fashion
The only available in the framework implementations of above interface are SpringOpaqueTokenIntrospector/NimbusOpaqueTokenIntrospector (they seem to operate in similar fashion) with:
2.1 First constructor (with injected client and secret) imposing constraint on what introspection can retrieve (i.e. only tokens associated with this specific client) - that's the only provided bean in resource server’s OAuth2ResourceServerOpaqueTokenConfiguration
2.2 The other one (with rest template) - has an issue of how to retrieve necessary data (i.e. authorization details)
2.2.1 but even having some handle there is an issue how to pass it around in an clear and concise fashion
2.2.2 i.e. if one was to force using client_id parameter in the request like framework does elsewhere
Like said earlier - resource server documentation https://docs.spring.io/spring-security/reference/servlet/oauth2/resource-server/opaque-token.html#oauth2resourceserver-opaque-minimaldependencies does not capture whole complexity present in this use case as in naive approach every time opaque token bearer would be sent - it potentially would regard different client, thus in default implementation of introspection endpoint - different authorization would have to be sent with the request to introspection endpoint

Duplicate of gh-1101

@jgrandja Just to confirm that I got it right - despite the fact without opaque token bearer authorization /userinfo cannot operate (for this type of tokens) it is left to us to implement it, is that right?

@KPrzychodzki

opaque token bearer authorization /userinfo cannot operate (for this type of tokens) it is left to us to implement it, is that right

No. Opaque tokens are supported by the /userinfo endpoint - OidcUserInfoAuthenticationProvider will work for either a JwtAuthenticationToken or BearerTokenAuthentication


fix(ci): Builds docker images for both supported arches

Feature or Problem
The current 0.63 builds only have the arm64 architecture available for docker images
Release Information
Next. However, if we can find a way to rebuild the 0.63.1 images using this, that would be nice
Testing
This is being tested with a run of the pipeline before changing back the vars

Closing this out and pushing to a branch in the repo so I can test the push properly


[NWS-1224][NWS-1543] The attachments code must to be equal to expense code on onedrive

Added att to existing expense

Ao apagar a despesa:

Ao criar uma nova despesa com anexos:


Add Movelinks2.app v1.3.25

Moveslink is a software that connects your Suunto device to Movescount.
http://www.movescount.com/connect/moveslinkmac/Suunto_Ambit

Thank you for the contribution. The download URL also needs a comment # cloudfront.net is the official download host per the vendor homepage. Furthermore, you can use string interpolation in url to include the version number #{version.dots_to_underscores}. In addition, the HTTPS for download URL is available which is more preferred.
Moreover, there is an appcast available for this app: https://d1c229iib3zm7m.cloudfront.net/mac/appcast.xml.
Most likely this cask also needs auto_updates true.
  # cloudfront.net is the official download host per the vendor homepage
  url "https://d1c229iib3zm7m.cloudfront.net/mac/Moveslink2_#{version.dots_to_underscores}.dmg"
  appcast 'https://d1c229iib3zm7m.cloudfront.net/mac/appcast.xml',
          checkpoint: 'b628c933441bef876271f84cf5cc14d229a3b4b7c0ce053cefcf5dbe338effcf'

Small correction, comment needs to be # d1c229iib3zm7m.cloudfront.net was verified as official when first introduced to the cask.
Also, could you please squash your commits?

Done + squashed

Thank you for the contribution. It was merged directly as 34c5529ef704c45891a36fe7d7aa658275ec3218 to keep commit history cleaner. Your contribution is still credited to you.


Specifying ref that contains dash doesn't work properly

When creating GitChekout object, it assumes a branch is up to the first dash of ref provided:
https://github.com/ManageIQ/manageiq-appliance-build/blob/master/scripts/git_checkout.rb#L23
Then, kickstart will use that 'branch' for git checkout:
https://github.com/ManageIQ/manageiq-appliance-build/blob/master/kickstarts/partials/post/source_setup.ks.erb#L14
resulting checkout branch/tag to be truncated.
Not sure if there is a problem using the provided ref as is in kickstart?

We no longer do git checkout in kickstart.


Rewrite Korean translation

Actually rewriting this one's translation along with BlockPets was already on my plan since then, but I wasn't doing it. People who don't know how to translate should NEVER try to translate them, especially with machine translators; rewriting their mess is really a pain.

Yep, finally done (Fifth commit was supposed to be final commit, but I guess these changes are better)

Done, you can merge this now.

Thank you!


training/update-dataset: fix broken typecheck

The code would never actually change anything

Pull Request Test Coverage Report for Build 1924

2 of 3 (66.67%)  changed or added relevant lines in 1 file are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.005%) to 66.834%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

training/tasks/update-dataset.js
2
3
66.67%

Files with Coverage Reduction
New Missed Lines
%

training/tasks/update-dataset.js
1
97.12%

Totals

Change from base Build 1922:
-0.005%

Covered Lines:
6930

Relevant Lines:
9740

💛  - Coveralls


Problem Setting Color Commands to Cololight Pro

I have a problem with setting effects on Cololight Basic and Cololight Pro. It takes effect after 3rd.. 4th.. 5th.. 6th attempt. I use usual interface like HA light card and i select effects from dropdown.
However

ON/OFF and changing brightness works instantly
Setting effects from official app works instantly
No problems with Cololight Plus devices

Problem reproduces on Cololight Basic (Model LS160) and Cololight Pro (Model LS166)
Thanks

I'm having the same issue with the normal hexagons. Setting an effect barely works at all and setting a color works about 25% of the time. Works perfectly with the official app.

Are you able to share both the version of the integration & also which Home Assistant version you are running?

HACS Integration V 1.28.3
HA V 2022.11
Cololight firmware V <IP_ADDRESS>


Modern String Formatting in Code

It would be nice to move % string formatting to .format() throughout the codebase as per PEP 3101
Refer to this link for examples.

@reachtarunhere I was started working on this issue and changed learning.py. But, learning.py was failing the test before I made any changes.
Could you please look into it?

Hi @reachtarunhere !
In what all files do we need to enhance the code?
Thanks!

Hi @deepanshugarg257 and @sam0410, I encourage your interest over this issue. I have already fixed it. You can have a look at #292. Feel free to rectify me over that PR.


Added date data to date slot

Can you merge this please?

Can you merge this please?

@khatiamacharadze let's wait for the review, until then maybe you can use the forked package https://www.npmjs.com/package/daterange-picker-for-vue-3


Update KnowledgeBaseId and update rouge SA roles

This is mostly just an FYI to all of you, but I've changed the rouge SA role to Project Viewer, in case someone complains. This should be the final time I have to do this fix (I hope).
Otherwise, if Dialogflow is failing again, it is likely that the Test Knowledge Base was deleted and needs to be re-created and these IDs have to be updated each time.

Thanks!


Add navigation buttons to Help

Type

[ ] Bug fix
[x] New feature
[ ] Improvement to existing feature

Related JIRA Issue(s)
ENSWBSITES-1386
Description
Add navigation buttons to the Help app
Deployment URL
help-app-nav-buttons.review.ensembl.org
Views affected
Help app -> any article
Other effects

[ ] I have checked any requirements for Google Analytics
[ ] I have created any required tests
[ ] The PR has as its final commit a WASM/JS update commit if any Rust files were updated.

Closing this PR in favour of #663


[dev 18] .Site.Params in partials not writing to page

Ran go get to use the dev build. .Site.Params values that worked in 17 are no longer showing up when running the local server.
For example, in my config.toml, I have:
[params]
  CopyrightLine = "College of American Pathologists"

And then in partials/footer.html, I use the following:

© {{ .Site.LastChange.Format "2006"}}

      {{ with .Site.Params.CopyrightLine }}
{{.}}
{{end}}

The second
 no longer writes to the page. Same if I use if or just
{{.Site.Params.CopyrightLine}}
.
@bep, it's in a private repo for work, but I'll add you as a collaborator in the event you want to test this locally....

See https://github.com/spf13/hugo/pull/2630


Cannot read property 'getAttribute' of null

https://github.com/wwayne/react-tooltip/issues/289
After upgrading  to preact 8.1.0 and preact-compat 3.15.0, I see the following error with react-tooltop:
Uncaught TypeError: Cannot read property 'getAttribute' of null
    at ReactTooltip.target.isCapture (eval at <anonymous> (vendor-540a31e8.js:1676), <anonymous>:9:38)
    at ReactTooltip.addScrollListener (eval at <anonymous> (vendor-540a31e8.js:849), <anonymous>:460:32)
    at ReactTooltip.eval (eval at <anonymous> (vendor-540a31e8.js:849), <anonymous>:344:32)
    at renderComponent (eval at <anonymous> (vendor-540a31e8.js:1556), <anonymous>:311:89)
    at rerender (eval at <anonymous> (vendor-540a31e8.js:1556), <anonymous>:38:43)

Seem to be related to event.currentTarget being null. Is this thread from inferno relevant? https://github.com/infernojs/inferno/issues/1009
I noticed some breaking changes in preact 8, so I wonder if this is something preact-compat can take care of.

Ahh - this is going to be fixed when we revert Preact back to using Promise#then() for async.  In 8.0 we changed async to be a simple setTimeout() instead of a Promise microtask, which means this line in react-tooltip became truly async.  Event objects are live and shared when bubbled, so what you're seeing is that the Event object has already bubbled up all the way by the time the .currentTarget is accessed, so it is null.


Mount a separate filesystem for /run/setuid-wrapper-dirs

Motivation for this change
This makes /run/setuid-wrapper-dirs a separate tmpfs with nosuid bit unset; this makes it possible to return nosuid to /run. To ensure smooth transition, this adds more logic to activation script to check if a special filesystem already exists, and mount it rather than remount if it's not.
Tested by checking that after switch from old configuration (with /run/setuid-wrapper-dirs already existing, which is a more difficult case to handle) sudo works, and that after a clean reboot it works too.
Things done

[x] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] OS X
[ ] Linux

[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

Will this really work given that we call umount in the activation script?

I don't mount /var/setuid-wrappers, but rather /run/setuid-wrapper-dirs -- we don't unmount it AFAIK.

D'oh.

If sudo and installer tests pass with this, +1

@abbradar huh. I'll try to reproduce.

machine# error: anonymous function at /tmp/root/nix/store/5macad415xi66ri7mdhf7661daif4kky-nixos-17.03.git.7ac1780/nixos/pkgs/tools/compression/gzip/default.nix:1:1 called without required argument ‘appleDerivation’, at /tmp/root/nix/store/5macad415xi66ri7mdhf7661daif4kky-nixos-17.03.git.7ac1780/nixos/lib/customisation.nix:56:12
Something is seriously broken.

How's that:
machine# error: infinite recursion encountered, at undefined position

So random I have no idea what can be the problem...

@abbradar on 16.09:
machine# finalising the installation...
machine# updating GRUB 2 menu...
machine# installing the GRUB 2 boot loader on /dev/vda...
machine# Installing for i386-pc platform.
machine# Installation finished. No error reported.
machine# setting up /etc...
machine# /nix/var/nix/profiles/system/activate: line 92: mountpoint: command not found
machine# mount: devtmpfs is already mounted or /dev busy
machine#        devtmpfs is already mounted on /dev
machine#        devtmpfs is already mounted on /tmp/root/dev
machine#        devtmpfs is already mounted on /tmp/root/mnt/dev
machine# /nix/var/nix/profiles/system/activate: line 92: mountpoint: command not found
machine# mount: devpts is already mounted or /dev/pts busy
machine#        devpts is already mounted on /dev/pts
machine#        devpts is already mounted on /tmp/root/dev/pts
machine#        devpts is already mounted on /tmp/root/mnt/dev/pts
machine# /nix/var/nix/profiles/system/activate: line 92: mountpoint: command not found
machine# /nix/var/nix/profiles/system/activate: line 92: mountpoint: command not found
machine# mount: proc is already mounted or /proc busy
machine#        proc is already mounted on /proc
machine#        proc is already mounted on /tmp/root/proc
machine#        proc is already mounted on /tmp/root/mnt/proc
machine# /nix/var/nix/profiles/system/activate: line 92: mountpoint: command not found
machine# /nix/var/nix/profiles/system/activate: line 92: mountpoint: command not found
machine# /nix/var/nix/profiles/system/activate: line 92: mountpoint: command not found
machine# mount: sysfs is already mounted or /sys busy
machine#        sysfs is already mounted on /sys
machine#        sysfs is already mounted on /tmp/root/sys
machine#        sysfs is already mounted on /tmp/root/mnt/sys
machine# Initializing machine ID from random generator.
machine: exit status 1
machine: output:
error: command `nixos-install < /dev/null >&2' did not succeed (exit code 1)
command `nixos-install < /dev/null >&2' did not succeed (exit code 1)

Any news on checking? https://github.com/NixOS/nixpkgs/pull/18689/commits/ee3963775c841f5dc87b5bad462c1f5764b89a7b should have added mountpoint to PATH.

Same: machine# error: anonymous function at /tmp/root/nix/store/b3l7hhvxaw0vakyal02blzy0fh58z1lc-nixos-16.09.git.97982d4/nixos/pkgs/development/libraries/polkit/default.nix:1:1 called without required argument ‘GConf’, at /tmp/root/nix/store/b3l7hhvxaw0vakyal02blzy0fh58z1lc-nixos-16.09.git.97982d4/nixos/lib/customisation.nix:56:12

I think I remember something like that from long before. It was just like now -- random errors from different seemingly unrelated parts of nixpkgs. I only recall there was a discussion in some issue around that and it got resolved somehow, not even what triggered the error. Was too long ago and probably not helpful, sorry...

I also remember such errors, passing arguments to the wrong functions. @nbp any ideas?

Part of this patch is superseded by f94ea048. I've rebased it; let's not include this in release (it haven't been tested and gives us only nosuid in /run which is nice but not so nice to be hasty.

And now (on b69f568f4c3ebaf48a7f66b0f051d28157a61afb) it tries to download curl's sources. No idea what's going on...

So, what can we do about this? installer.simple does not succeed for me even on plain master.

I've rebased this atop our fresh wrappers changes. It would be nice to have this merged in 17.03 to avoid having yet potentially more compatibility code :D However, I can't test this myself now because of https://github.com/NixOS/nixpkgs/issues/22868. Can anyone try to run tests.misc.x86_64-linux and test.installer.simple.x86_64-linux on this?

With fix from #23020 I can finally run NixOS tests! They both pass with this patch and I've been dogfeeding from at least September. Merging; hope this won't break much...


ShiftLeft pipeline support request by Matthew Ferrari: Permission denied

Reported on Service API Toolset Teams channel.

This request is not immediately urgent, but it is timely.

Is a workaround available?
I believe was can manually submit PR as a work around.

What is being blocked by this issue?
A new release of an Azure Access Point API version 2023-03-01-preview.

How long this request can remain unsolved?
We need to have release in 14 days to meet deliverable deadline.

This request is not immediately urgent, but it is timely.
Is a workaround available?
I believe was can manually submit PR as a work around.
What is being blocked by this issue?
A new release of an Azure Access Point API version 2023-03-01-preview.
How long this request can remain unsolved?
We need to have release in 14 days to meet deliverable deadline.

The permissions issue has been fixed (see Teams thread) but looks like ShiftLeft is currently failing on what appears to be project name not being correctly escaped. Details by Matthew here.
This requires further investigation.
Build failure log
Build definition
ShiftLeft yml definition
I advised Matthew to work around this issue by submitting a PR to specs repo directly.


Problems Panel is not clearing after compile

Problems panel is not clearing on the new version, 1.26.1, after compiling with the "ForceCode" extension. Reproduction is tricky (you need to have a Salesforce Org), so I will post code attempts to clear the panel.
On an error, the following code is executed to add errors to the Problem Panel:
var diagnosticCollection: vscode.DiagnosticCollection = vscode.languages.createDiagnosticCollection(document.fileName);
var diagnostics: vscode.Diagnostic[] = [];
if (res.records && res.records.length > 0) {
    res.records.filter(r => r.State !== 'Error').forEach(containerAsyncRequest => {
        containerAsyncRequest.DeployDetails.componentFailures.forEach(failure => {
            // Create Red squiggly lines under the errors that came back
            if (failure.problemType === 'Error') {
                var failureLineNumber: number = Math.abs(failure.lineNumber || failure.LineNumber || 1);
                var failureRange: vscode.Range = document.lineAt(failureLineNumber - 1).range;
                if (failure.columnNumber > 0) {
                    failureRange = failureRange.with(new vscode.Position((failureLineNumber - 1), failure.columnNumber));
                }
                diagnostics.push(new vscode.Diagnostic(failureRange, failure.problem, failure.problemType));
            }
        });
    });
} else if (res.errors && res.errors.length > 0) {
    // We got an error with the container
    res.errors.forEach(err => {
        console.error(err);
    });
    vscode.window.forceCode.statusBarItem.text = `${name} ${DefType ? DefType : ''} $(alert)`;
} else if (res.State === 'Error') {
    vscode.window.forceCode.statusBarItem.text = `${name} ${DefType ? DefType : ''} $(alert)`;
}
diagnosticCollection.set(document.uri, diagnostics);

This code works perfectly fine, updates the status bar, and adds the errors correctly. However, on recompiling with no errors, under 1.25.1, the Problems Panel cleared correctly; in 1.26.1, it does not. On a success, the above code for res.records.filter(r => r.State !== 'Error').forEach is not executed, leaving diagnostics to be empty (or []) and to be set as normal.
I have modified the extension to explicitly call diagnosticCollection.clear(), diagnosticCollection.delete(document.uri) and diagnosticCollection.dispose(), but the Problems Panel does not clear.
This has only started happening with the 1.26 release.
System Info:

VSCode Version: 1.26.1
OS Version: macOS Sierra, 10.12.6

Can you adjust for code sample so that I can run it and reproduce the issue. Thanks

I really wish I could, but it is a challenge.
First, I am not the author of the extension -- it has been deprecated in favor of a different Salesforce workflow -- and it needs to be modified because of broken dependencies and the NodeJS upgrade. I have made the necessary changes to the extension and recompiled, so I can provide a vsix for testing.
Next, you would have to sign up for a free Salesforce Dev Org and deploy code to it. Then, after connecting the ForceCode extension to that Org, you can then deploy.
As you can see, there are quite a number of steps to take, so that is why I posted the extension's code for adding and clearing the Problems Panel. Not really sure how to proceed here, but it is a definite issue with v1.26 as it was working fine with v1.25. I know that a new feature let's you fix items in the Problems Panel, so I assume it is somehow related to that.

Have you tried this with 1.26.1? We have made a critical fix for the problems panel, but from the sounds of it, it doesn't seem related to the new features

Yes, I did. I have reverted back to 1.25.1 and it works. It does not work on v1.26.1. Sorry, I stated the original version in my opening post, but neglected to mention the ".1" in my follow-up post.

Funky, that was the only change in the diagnostics area between 1.25.x and 1.26.x. I suspect this is an issue with the extension because we don't receive other feedback like this. I'd still a set of reproducible steps tho

My language plugin that emits diagnostics got regression in 1.26.1 and this issue seems to be related to the problem. https://github.com/atsushieno/vscode-language-review/issues/17

I can confirm this is happening with my extension now as well. Debugging, it looks like each successive call of languages.createDiagnosticCollection("Write-Good Lints") produces a new diagnostics with owner of "Write-Good Lints0", "Write-Good Lints1", "Write-Good Lints2", etc. See https://github.com/TravisTheTechie/vscode-write-good/issues/10. createDiagnosticsCollection no longer appears to return a collection with the existing diagnostics in it as well, the collection is empty even though there are diagnostics that apply.

@TravisTheTechie I agree that it is not Extension related. The ForceCode Extension is not doing anything fancy - no parsing of output windows or anything. It builds the Problems Panel manually and cannot clear it. I added several lines to try to force clearing it, but it never clears and always show an empty collection when setting it up or getting the current one. Oh well, I will see if it gets resolved in a future VSCode version and update then.


Add HTTP identifier headers

stashcp should populate the user-agent field so we can distinguish it at the various web services (such as the GeoIP application).
We should coordinate with Dave Dykstra to see what the best user identifier exists.

Email to Dave Dykstra sent.

From the email thread:

We should set the User-Agent header.  That's what CVMFS utilizes.
Identify ourselves as stashcp and a particular version number.
Additionally, we can utilize X-Frontier-Id.  Include the user identity (parse from the $_CONDOR_JOB_AD?) and the condor global job ID.

For example, here's the existing header for a CMS job generated by the frontier client:
wmagent_prozober_recovery-2-fabozzi_Run2016H-v1-ZeroBiasIsolatedBunch5-09Nov2016_8023__161201_144853_7563 2.8.19 2683277 cmsprod(9811) /DC=ch/DC=cern/OU=Organic Units/OU=Users/CN=username/CN=718748/CN=MY USER NAME/CN=450678657/CN=631063546/CN=2596 -

We should use the same header name (otherwise all squids in WLCG need to be updated) but can make up our own format for the value.

By same header name, do you mean the X-Frontier-Id?  User-Agent is standard, right?

The first field in X-Frontier-ID comes from $FRONTIER_ID if it is set, otherwise $CMSSW_VERSION.
The other option is to use the Cvmfs-info header, that is also logged by frontier-squid.

Yeah - I'd like to keep the usage of User-Agent fairly standard (I don't want lots of unique strings here).  So, for the things that vary (username, job ID), I want to pick either X-Frontier-ID or Cvmfs-info.  I think X-Frontier-ID is a better name in the end...


Repeated code examples in the Modifying Large Datasets chapter

Report
In section Granular modifications:
https://github.com/iterative/dvc.org/blob/bf0c1eeedd94dc0bf4dda4f7d26c2c8b3bfb856f/content/docs/user-guide/data-management/modifying-large-datasets.md?plain=1#L33-L56
and
https://github.com/iterative/dvc.org/blob/bf0c1eeedd94dc0bf4dda4f7d26c2c8b3bfb856f/content/docs/user-guide/data-management/modifying-large-datasets.md?plain=1#L61-L80
These two code examples are talking about the same thing, right?

They are similar, but one is about a new file, the second one is about modifying an existing file:

You can dvc add one or more new files or subdirectories to this dataset without re-adding the entire dataset. Let's assume we have one new file in the dataset:

vs

You can also modify one or more existing files or subdirectories. Let's assume we have overwritten one file in the dataset:

I think it's fine to keep the both for now. Thanks for raising a questions though!


Prepare 0.0.8 release for Swift 4.1

This PR edits Info.plist, pod spec and xcodeproj files to support Swift 4.1 on the 0.0.8 release. I added the swift_version DSL to the podspec as that's the correct way to define the Swift version in Cocoapods 1.4.0+ (https://github.com/CocoaPods/CocoaPods/issues/7327)

I'm using Fastlane to automate releases. It might be a good option to consider. Fastfile example: https://github.com/marcosgriselli/ViewAnimator/blob/master/fastlane/Fastfile


Epic Games Claim Error "An error occurred while trying to process your request"

Describe the bug

I am unable to claim free games using the Debian image. When I enter the puppeteer portal, I am presented with an error when pressing "Place order" (see below). Interestingly, I am not asked to solve a puzzle so perhaps the accessibility cookie is kicking in, although it hasn't in the past.
Screenshots or Logs

Additional context

I am getting the same error message.
Have you ever had an automated purchase go through without issue?

Debian image?

I do have a theory as to what the issue might be; although I haven't tested it. I used the same login cookie that was created with the Ubuntu image. So maybe it gets suspicious when you are using the same cookie yet your user agent is changing because of the different OS. If so then I suppose the solution would be to either spoof the user agent so both images have the same one or to have a different cookie file for Debian and Ubuntu. That is of course if that is what is causing the issue.

I am getting the same error message.

I have a theory that some of this may be due to country blacklisting. I added a countryCode config option to prevent attempting to purchase games your account's country is blacklisted from.


getChatCompletions no longer returns usage information

Package Name: @azure/openai
Package Version: 1.0.0-beta.5

Describe the bug
getChatCompletions no longer seems to return usage information ( completionTokens, promptTokens. totalTokens)
Is there any way to get this information ( from what I'm observing the data is no longer being added when the response is deserialized )

@radumihail Thanks for opening this bug report, we're working on a fix!

Hi @radumihail, we've merged the fix and will ship it in the next release of @azure/openai. Thank you!

This has been addressed in <EMAIL_ADDRESS>

This might need its own issue, but I'm not seeing any usage information being returned when I use listChatCompletions(). Is that a similar issue to this one, or doesn't this function return usage information? (It does return the same type as getChatCompletions(), but the usage field is optional).

@quintesse yeah usage information is not currently returned by the API when it is in the streaming mode. See https://github.com/Azure/azure-sdk-for-js/issues/26302. It is also being dicussed in OpenAI community forum.


Added autocomplete to General Search Bar

Purpose：
The goal of this change is to add autocomplete to the general search bar
Changes:
Added nz autocomplete element to the search bar component to support autocomplete.
Demo:

LGTM!


Extension "supautils" has no installation script nor update path for version "0.1.0"

I created a new project to get the latest version of the database,
then when checking the possibility of creating extensions, I found that there is an error in the extension "supautils":
ERROR:  22023: extension "supautils" has no installation script nor update path for version "0.1.0"

supautils has been updated to no longer present as a target for create extension, its functionality is enabled by default on all projects
If that doesn't resolve this issue please let me know how we can help