Question about Weighted quantile sketch

hi all，
I just read the paper, and it's hard for me to understand why Weighted quantile sketch algorithm uses h_i as weights. In my view, Weighted quantile sketch is used to find a good splitting point efficiently and a good spliiting point can help to reduce the loss. THE QUESTION is why Weighted quantile sketch algorithm uses h_i as weight can help to reduce the loss.

The equation above shows that h_i can be used as sample weight, but how to reduce loss using h_i as weight? I can't figure out the relationship between h_i and reducing loss and advances using h_i as sample wieght.

$h_i$ which is the Hessian for data point i, can be used as a proxy for the importance of each sample in the learning process. As such, we can weigh each data point by its Hessian, in order to focus the learning on these samples that cause the most error.
The weighted quantile sketch can be used when we are proposing split points, by weighting data points by their Hessian value.
Now AFAIK, this is not used practically any more, because the split point suggestions do not take Hessians into account, they are proposed only once at the beginning of learning, based on global statistics (on the entire dataset). The devs can correct me on that though.

Thanks!.  As explained by @thvasilo the hessian is used as proxy for approx tree method and grow_local_histmaker updater.  While hist and gpu_hist don't use it.

Now AFAIK, this is not used practically any more, because the split point suggestions do not take Hessians into account

Actually I'm working on categorical data support, in order to do so I need to bring these 2 tree methods to modern code base.  Also I think in some datasets using hessian does yield better accuracy.  So might see something interesting.

hi all，
I just read the paper, and it's hard for me to understand why Weighted quantile sketch algorithm uses h_i as weights. In my view, Weighted quantile sketch is used to find a good splitting point efficiently and a good spliiting point can help to reduce the loss. THE QUESTION is why Weighted quantile sketch algorithm uses h_i as weight can help to reduce the loss.

The equation above shows that h_i can be used as sample weight, but how to reduce loss using h_i as weight? I can't figure out the relationship between h_i and reducing loss and advances using h_i as sample wieght.

Off topic, is the minus in the squared term actually + instead?

Off topic, is the minus in the squared term actually + instead?
I too am getting a + sign. I read the paper but I still am not able to find how he got to this equation from equation 3 of the Loss function.

hi all，
I just read the paper, and it's hard for me to understand why Weighted quantile sketch algorithm uses h_i as weights. In my view, Weighted quantile sketch is used to find a good splitting point efficiently and a good spliiting point can help to reduce the loss. THE QUESTION is why Weighted quantile sketch algorithm uses h_i as weight can help to reduce the loss.

The equation above shows that h_i can be used as sample weight, but how to reduce loss using h_i as weight? I can't figure out the relationship between h_i and reducing loss and advances using h_i as sample wieght.

Off topic, is the minus in the squared term actually + instead?

I think the - sign in the squared term should be a + sign.


[RFC] Discuss the details of setting up an RFC process

Summary
We would like to try out the RFC process as utilized by the DM/Project and discussed on Slack.
Description
We need a better way to reach consensus and to encourage discussion on a variety of Computing issues.  The RFC process seems like a sensible way to proceed.  This repository is an attempt to mimic the Project's RFC description.  There are some things to sort out as far as what body would serve as our "Change Control Board" if consensus cannot be reached.  If we are talking about DESC Computing, that may rightly involve the Computing WG conveners and the Computing Coordinator and Deputy.  All should feel free to comment and offer suggestions about how to best handle the procedure from RFC creation through implementation.
Planned End Date
Monday, July 12, 2021

For me, a little flowchart in the README, showing the different paths an rfc can take via addition or removal of labels would be very helpful.

When a proposal is escalated, does that or might that involve changing the planned end date? Otherwise escalation doesn't seem to buy you much.  The section "Escalate a RFC" needs to say more about the procedure.

We need a better way to reach consensus and to encourage discussion on a variety of Computing issues. : I give to Computing a restrictive meaning, unless you meant here the CO group. We deal with any requests that would impact DESC software system in a global way.

 as our "Change Control Board" if consensus cannot be reached. : I was under the impression that the point of "lazy consensus" is that if it is not reached, the RFC has to be withdrawn. CCB is here to give a go to implementation based on some operational constraints that may have not been taken into account while reaching lazy consensus, but would defer to the experts discussing the RFC for actual relevance of the RFC, so consensus has to be reached before the CCB is called in IMHO.

@JoanneBogart  Agreed about "escalation" fuzziness, as mentioned in my comments on slack. The "planned end" is to reach lazy consensus though, as far as I understand. Escalation occurs afterwards. So planned end is just the deadline before considering that no objection has been raised and that lazy consensus has been reached.

The "planned end" is to reach lazy consensus though, as far as I understand. Escalation occurs afterwards.
@johannct  I don't think these steps are sequential. The text in the README has an "or":

the RFC is either labelled proposed (that is, it has not been escalated) or approved (it has been escalated and subsequently approved by some TBD decision making body);

But this is just the original DM way of doing things.  We need to decide what we want.

right but this is only due to the fact that some RFC in DM fall directly under CCB scrutiny. I would contend that we want to simplify all that, at least to start with, and have something very sequential. The only fork being adopted/withdrawn.

Switching between Slack and here is a bit tiring :)  Coming to this comment from Johann.  This is suggesting to modify the README to include "Proposing a new scheme or methodology that has broad consequences within DESC" ?  I want us to be clear what areas are covered by RFC.  By DESC Computing I do not mean the CO WG - but this needs to be stated more clearly.  I don't know that we are proposing RFC to cover analysis or pipeline methodology, for example .. it could cover those things but we're not addressing that right now and I want to be sure how we frame this is understandable.
So I'm happy to add a reworded version of: Proposing a new scheme or methodology that has broad consequences within DESC

Next comment from Johann
We need to better define the difference between a "requestor" and an "assignee" - since they may not be the same person.  The requestor may not be the one best able to handle the RFC discussion and any implementation if the RFC is approved.  The README should be updated and the template changed to allow the requestor to indicate that they are not the appropriate assignee.  It would then be up to the CCB to step in to either name an assignee or that the RFC should be withdrawn.

Next comment from Johann

In the same spirit as the comment above and proposal as well as a "Planned End" date for comments. may perhaps rather be and proposal as well as a "Time limit before it becomes a road block" date for comments.  My worry being again that someone within DESC may have a RFC in mind with some consequences if it is not resolved and implemented, but is not in power to decide of the duration of the comments from the CO/PS team etc....

My response

My worry here is that the typical 72 hours or one week seems like an appropriate and already expedited amount of time.  "Time Limit before it becomes a road block" could result in time limits that are really too long to be useful. If someone needs a decision less that 72 hours - well..  I'm not sure that is really in the realm of possibility.

Johann's response

yes indeed. Still the requestor is not the person in charge of defining the "Planned End" time, as the latter is what the dev team will judge reasonable before lazy consensus is acted. Likewise the requestor will not necessarily be in charge of implementation in our context

I would still like to keep the "Planned End" relatively simple and not first require some discussion with the dev team or the CCB to figure out how long a discussion needs to be open.

I added an initial flowchart accessible via the README

Following discussions with Jim, who expressed worries that the loose structure of DESC organisation would not easily acommodate a too strict process setup, Heather and I decided that we would move to something more of a forum here, as a starter. We will reopen this issue if defining a stricter process to handle RFC becomes a necessity or a consensual wish.


Grafana dashboard crashes as soon as there is a critical error in the script

Grafana 10.4
Latest nline version
When there is an issue in the script because of some missing data for example the dashboard crashes imminently. With Grafana 10.0 and latest nline version the dashboard did not crash and we received a nice error message in the plotly panel showing what you did wrong in the script.
Hope it can be brought back as debugging becomes almost impossible now. Not sure what Grafana changed on their side.

Thank you, this will be fixed in the latest version rolling out today.

Thanks!


[IC3 ACS Cross Platform Messaging ] API Review

New API Review meeting has been requested.
Service Name: IC3 ACS Cross Platform Messaging
Review Created By: Gloria Li
Review Date: 01/25/2024 04:00 PM PT
Onboarding Record:
PR: https://github.com/Azure/azure-rest-api-specs/pull/27405
Hero Scenarios Link: Not Provided
Core Concepts Doc Link: Not Provided
Description: We are hoping to seek your approval for the upcoming GA release targeting February 2024. Outlined below are the key changes we have implemented based on the feedback received:

Renaming of models as requested in the recent review meeting:
ChannelType to CommunicationMessagesChannel
TemplateResponse to MessageTemplateResponse
Template Status to MessageTemplateStatus
MessageTemplateBindingsWhatsApp to WhatsAppMessageTemplateBindings
MessageTemplateBindingsWhatsAppButton to WhatsAppMessageTemplateBindingsButton
MessageTemplateBindingsWhatsAppComponent to WhatsAppMessageTemplateBindingsComponent
MessageTemplateValueWhatsAppSubType to WhatsAppMessageTemplateValueSubType
TemplateResponseWhatsApp to WhatsAppMessageTemplateResponse
Transition from Swagger to TypeSpec: We have transitioned from Swagger to TypeSpec to describe the CPM service.
Addition of Idempotency Header: A new idempotency header has been incorporated to the '/messages/notifications/:send' endpoint.

The adjustments made since the public preview version are minimal, and we are hoping to secure an approval from the board to proceed with the GA release scheduled for February 2024.
Detailed meeting information and documents provided can be accessed here
For more information that will help prepare you for this review, the requirements, and office hours, visit the documentation here

Meeting updated by Gloria Li
Service Name: IC3 ACS Cross Platform Messaging
Review Created By: Gloria Li
Review Date: 01/25/2024 04:00 PM PT
Onboarding Record:
PR: https://github.com/Azure/azure-rest-api-specs/pull/27405
Hero Scenarios Link: Not Provided
Core Concepts Doc Link: Not Provided
Description: We are hoping to seek your approval for the upcoming GA release targeting February 2024. Outlined below are the key changes we have implemented based on the feedback received:

Renaming of models as requested in the recent review meeting:
ChannelType to CommunicationMessagesChannel
TemplateResponse to MessageTemplateResponse
Template Status to MessageTemplateStatus
MessageTemplateBindingsWhatsApp to WhatsAppMessageTemplateBindings
MessageTemplateBindingsWhatsAppButton to WhatsAppMessageTemplateBindingsButton
MessageTemplateBindingsWhatsAppComponent to WhatsAppMessageTemplateBindingsComponent
MessageTemplateValueWhatsAppSubType to WhatsAppMessageTemplateValueSubType
TemplateResponseWhatsApp to WhatsAppMessageTemplateResponse
Transition from Swagger to TypeSpec: We have transitioned from Swagger to TypeSpec to describe the CPM service.
Addition of Idempotency Header: A new idempotency header has been incorporated to the '/messages/notifications/:send' endpoint.

The adjustments made since the public preview version are minimal, and we are hoping to secure an approval from the board to proceed with the GA release scheduled for February 2024.
Detailed meeting information and documents provided can be accessed here
For more information that will help prepare you for this review, the requirements, and office hours, visit the documentation here


[Suggestion] Passing ripple options for android

Seems like there is a prop pressColor for android_ripple.color, however android_ripple.bordeless seems hard-coded.
Would it be possible to pass this setting as a prop as well?

What's the effect that you want to achieve?

Hi @satya164
I just want to customize the ripple effect.
Make it borderless or not borderless at will
Change color at will.

android_ripple={{ borderless: true }}
This is how it is set currently. Would be nice to pass android_ripple props, and otherwise, make it borderless if no props passed


Detox problem with React Native Navigation(wix)

I set a custom component for right button and pass onPress function,  also I add testID, and when I tap on this button through my tests, onPress function doesn't work. Click is made because I see a touchable effect. But the function is not called at all. This is my right button:
{
  id: 'login-button',
  testID: 'publicEvents.nav-login-button',
  component: {
    name: 'LoginNavBarButton',
    passProps: {
      onPress: onEventLoginPress
    }
  }
}

How I tap on this button:
 await element(by.id('publicEvents.nav-login-button')).tap();

Does that happen only during Detox testing session?
If you can reproduce this problem without Detox, by tapping manually on that button, I'd suggest directing your issue to https://github.com/wix/react-native-navigation

Does that happen only during Detox testing session?
If you can reproduce this problem without Detox, by tapping manually on that button, I'd suggest directing your issue to https://github.com/wix/react-native-navigation

Only with Detox. The app works good, but when testing this issue with Detox, the function onPress doesn't work.

@guyca, does that ring any bells to you? Just in case... 🤷♂

Please try to avoid crossposting next time.
@guyca requested an example for the bug reproduction here https://github.com/wix/react-native-navigation/issues/7129.
Be kind to prepare the example and provide it.
Meanwhile, I'll close the issue. You can continue the discussion there on the RNN repo.


completions not working in v4.17.4

描述这个Bug
i just updated to v4.17.4, and check completions not working.
for previous stable version, v4.17.0, it working ok.
and now i change to v4.17.4, it still work too.
so i think the issue for only v4.17.4.
please check it.
Thank You!
版本号
nuxt3, node 20, md-editor-v3 4.17.4
问题重现链接
No response

fyi, i use 4.17.4 with specific codemirror/view version, it worked.
"resolutions": {
    "@codemirror/view": "6.27.0"
  },

I cannot reproduce this issue. Can you provide a demo that can restore it?

Lacking examples, temporarily closed.


TrayIcon can not styling

I want to styling the TrayIcon, like the backgroud\border\template.... but all the TrayIcon relevant objects are based on AvaloniaObject
TrayIcon
NativeMenu
NativeMenuItem
etc...
So, is there any suggestions for styling TrayIcon and its relevant objs?

And the Header also can not support chinese


Delete test_training.py

Delete unneeded file

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


[Card] Fix bottom padding

[x] PR has tests / docs demo, and is linted.
[x] Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
[x] Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

Right now, lastElement never gets assigned, so the bottom padding is never added. Assuming this is not the expected behavior, we update lastElement so that it correctly points to the last non-null child.

Having a look at the material specification, it seems that you are right 👍 . Thanks for raising it.
Primary title/text

Bottom padding: 16dp (if there are additional actions or supporting text) or 24dp (no actions or supporting text)

Supporting text

Bottom padding: 24dp (16dp if there are additional actions or text below)


forced to create container div to render vNode Arrays

Hi,
I'm working an app using Cyclejs, snabbom, and snabbdom-jsx. I found a weird behavior in my code. Basically the following code renders fine :

            <input type="text" />
            {

                    clear

            }
            Add

but if I put my "clear-wrapper" div in an array, like so :

            <input type="text" />
            {
                [

                    clear

                ]
            }
            Add

then the "clear-wrapper" div is not included in the DOM, and is instead replaced by undefined:

            <input type="text" />
            "undefined"
            Add

BUT if I wrap the div array inside another div :

            <input type="text" />

            {
                [

                    clear

                ]
            }

            Add

Then the "clear-wrapper" div renders fine again. This is quite mind-boggling to me.
I'm not sure if its a bug (it looks like one to me), but if it's expected behaviour, can someone point me to where that behaviour is documented ? I have been searching around and did not find anything. There is this snabbdom issue that I think talks about it, but I'm not sure that it does, as I am quite new to JSX and snabbdom.
Is there a better solution other than the workaround I've found ? I'd like to avoid creating container divs just for that purpose if possible.
Thank you for your help and for this great library ! If you have any questions about my setup let me know.

can you check with the new version. issue with nested arrays is fixed

I updated to version 0.3.1 and the bug does not appear anymore.
Thanks !


Add TestKit JUnit extension [ECR-3076]

Overview
Add TestKit JUnit extension.

See: https://jira.bf.local/browse/ECR-3076
Definition of Done

[ ] There are no TODOs left in the code
[ ] Change is covered by automated tests
[ ] The coding guidelines are followed
[ ] Public API has Javadoc
[ ] Method preconditions are checked and documented in the Javadoc of the method
[ ] Changelog is updated if needed (in case of notable or breaking changes)
[ ] The continuous integration build passes

Coverage remained the same at 86.903% when pulling 60faabdb1cdc5b4916b6abd50c46a2ffacd5b0e5 on ECR-3076 into c2376fe8fd4a5f3b753161336b4fd14aa1522846 on master.

I see old way usage of TestKit in com.exonum.binding.test.BlockchainIntegrationTest. Or is it in the scope of another task?

I see old way usage of TestKit in com.exonum.binding.test.BlockchainIntegrationTest. Or is it in the scope of another task?

It makes little sense to use the extension when you need to inject it in @BeforeEach and then use in test and utility methods. It is simpler to put it in a field, to avoid passing explicitly between methods.
Testkit, however, would automatically destroy it (no need for @AfterEach), but the extension overhead (in terms of extra lines of code to register it and some complexity) seems higher.


Inconsistent Human Body Detection in QuickPose SDK

Description
I've integrated the QuickPose SDK for various exercise detection scenarios. Occasionally, when I start an exercise, the SDK struggles to detect the human body accurately. Instead of correct landmarks, it generates random lines that don't correspond to actual human body positions
Steps to Reproduce

Start an exercise using QuickPose SDK.
Observe that, in some instances, the SDK displays random landmarks instead of correctly identifying the human body.

Observed Behavior

Initial detection occasionally fails, resulting in random landmarks.
When I move out of view and re-enter, the SDK detects the body correctly.

Expected Behavior

Accurate body detection upon initial view without the need to leave and re-enter the frame.

Questions

Is there an existing fix or upcoming improvement to enhance initial detection accuracy?
Is there a method within the SDK to identify when the body is not being detected correctly?

Additional Information

QuickPose SDK version: main branch
Platform (iOS/Android): iOS

Thank you for looking into this!

Hi Purvesh, we are unable to see the gif so we are not sure what is exactly happening with your app to show errors in the detection. Can you please add again as a comment or share a link to the gif.

@filipljubicic  When we stat quickPose and person is not fully in the view then it goes to fully in the frame then also it just randomly shows the landmark..seems like model is confused to detect human.

https://github.com/user-attachments/assets/46fb6d51-2573-42d5-b5e7-93775edc4f0d
@filipljubicic  I have added screen recording here which is showing furniture as human. There is no human in the screen but still its detecting.


Fix react npm dependency & rollup config

This PR fixes #107 by setting the same react dep. version as in the other package (latest).
I also updated the rollup config file, since the one in main branch throws the following warning and doesn't write anything in dist folder.
I tested the build generated from this branch and it seems to be mostly working (I'm on 11-rc version of realm and I had to comment throw new Error('You need to be on realm 10.20.0 or higher'); line, but I suspect it's some API change?
(!) You have passed an unrecognized option
Unknown output options: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14. Allowed options: amd, assetFileNames ....

@haikov Thank you for the pull request. I am assigning a reviewer to move the process forward.

Facing the same issue on my machine. @haikov @kneth @kraenhansen Can u please test this PR and merge it as soon as possible? Thanks

This is still an issue and it's not possible to install the debugger.
@haikov Would you mind checking the suggestion by @kraenhansen?

@cla-bot check

@kraenhansen I've updated the PR with explicit version of React. Should be ready to merge now.

I'm trying to use the<EMAIL_ADDRESS>📦 but I get these errors
(1)

:x:
<EMAIL_ADDRESS>build
rollup -c

(2)
When commenting out lines above and trying again I get this error when trying to use it with useRealm()

:x:
[Error: Element type is invalid: expected a string (for built-in components) or a class/function (for composite components) >but got: object.
Check the render method of ComponentScreen.

Just to clarify I'm using it exactly like in de docs but with useRealm:
import RealmPlugin from 'realm-flipper-plugin-device';

MyComp() {

  const realm = useRealm()

  return (
     <View>
        <RealmPlugin realms={[realm]} /> {/* pass in the Realm to the plugin*/}
        // ...
     </View>
  );

}

@hadnet Can you please open a new issue, including what version of Realm you are using?  Also I have just released 1.0.27, so I recommend updating to make sure we can be sure the issue isn't already fixed.

@hadnet Can you please open a new issue, including what version of Realm you are using? Also I have just released 1.0.27, so I recommend updating to make sure we can be sure the issue isn't already fixed.

Ok, installed 1.0.27 but now I got this new error:

I'm using:
{
    "realm": "^11.3.0",
    "@realm/react": "^0.4.1"
}

@hadnet at a glance, it seems that you may have encountered a dependency conflict.  Can you share the contents of your package.json?

it's a simpler RN boilerplate with this packages
  "dependencies": {
    "@hadnet/react-native-skeleton": "^1.0.0-alpha.1",
    "@react-native-masked-view/masked-view": "^0.2.7",
    "@realm/react": "^0.4.1",
    "iconsax-react-native": "^0.0.8",
    "moti": "^0.18.0",
    "react": "18.1.0",
    "react-native": "0.70.4",
    "react-native-gesture-handler": "^2.6.1",
    "react-native-get-random-values": "^1.8.0",
    "react-native-linear-gradient": "^2.6.2",
    "react-native-reanimated": "^3.0.0-rc.2",
    "react-native-shimmer": "^0.6.0",
    "react-native-skeleton-placeholder": "^5.0.0",
    "react-native-svg": "^13.4.0",
    "realm": "^11.3.0"
  },
  "devDependencies": {
    "@babel/core": "^7.12.9",
    "@babel/plugin-proposal-decorators": "^7.20.5",
    "@babel/runtime": "^7.12.5",
    "@react-native-community/eslint-config": "^2.0.0",
    "@realm/babel-plugin": "^0.1.0",
    "@tsconfig/react-native": "^2.0.2",
    "@types/jest": "^26.0.23",
    "@types/react-native": "^0.70.0",
    "@types/react-test-renderer": "^18.0.0",
    "@typescript-eslint/eslint-plugin": "^5.37.0",
    "@typescript-eslint/parser": "^5.37.0",
    "babel-jest": "^26.6.3",
    "eslint": "^7.32.0",
    "jest": "^26.6.3",
    "metro-react-native-babel-preset": "^0.72.1",
    "react-native-builder-bob": "^0.18.3",
    "react-native-flipper": "^0.176.0",
    "react-native-flipper-performance-plugin": "^0.3.1",
    "react-test-renderer": "18.1.0",
    "realm-flipper-plugin-device": "^1.0.27",
    "typescript": "^4.8.3"
  },


Remove HtmlEncode from message inside Send method to prevent changing…

… special charecters like &<>+# from message

By Removing HtmlEncode, special characters doesn't change to html encode chars


Bug: cmd-click no longer filling in labels

🐛 Bug
Just realized that holding command is no longer switching the labels mode to "fill" and command-click to fill in a label hasn't been working for the last couple versions.  bisect puts it at #3072

ahh sorry, I just saw @sofroniewn's comment

I really don't like that pressing a modifier key changes the mode even if temporarily.

I actually loved that 😢 ... @sofroniewn what's the opposition to modifier-clicks doing stuff?

LOL, I had the same reaction on zulip:
https://napari.zulipchat.com/#narrow/stream/212875-general/topic/Labels.20layer.20info.2Fkeybinds

Ok, reading more in that link, and what @psobolewskiPhD linked above, looks like the opposition was:

the problem is that modifiers are used in other shortcuts, so we don't want modifier keys to temporarily switch modes, because e.g. typing Ctrl-C would see the mode flicker on and off when the user had no intention to deal with the mode. Instead the modifiers could either be read by the mouse event directly and the layer behaviour would be modified, or, we could use different hold keys.

I can see that potentially being troublesome (e.g. https://github.com/napari/napari/issues/2714), but I think it deserves a proper refactor, such that the behavior stays the same (i.e. cmd-click should fill in a label) even if the implementation changes (i.e. no longer changes mode on pressing command, but rather waits for the click).  But it looks like it was just removed and forgotten.  Can we bring this back temporarily until someone is actually tasked with fixing it?

(and minimally the help text needs to change to no longer state that holding ctrl does anything)

I can see that potentially being troublesome (e.g. #2714), but I think it deserves a proper refactor, such that the behavior stays the same (i.e. cmd-click should fill in a label) even if the implementation changes (i.e. no longer changes mode on pressing command, but rather waits for the click). But it looks like it was just removed and forgotten. Can we bring this back temporarily until someone is actually tasked with fixing it?

yeah, that's fair. Maybe it was just myself - with possibly some support from @jni that felt that way. I just found it really jarring that when I would do cmd-C for example the mode button would flicker. Making the implementation such that it waited for click would avoid that, but it is more complicated - and someone else could argue that they would like to see the button change highlight when the cmd is being held down. I wonder if @isabela-pf has thoughts.
Also would shift-click work? I guess we want to keep control-click maybe for opening a dialog?
I think though if both @tlambert03 and @psobolewskiPhD agree on a preferred behavior and feel strongly then we should revert / fix it. Would be nice to maybe ask a few more folks once the PR is made just to make sure we don't bounce back and forth though

In trying similar behaviors on other image-y applications, I’m finding some cases where users are required to hold a modifier key to change an action.

The space bar for pan/zoom is the most common (and Wikipedia is on @sofroniewn’s side about it not being a modifier key 😆).
Photoshop and Inkscape use all of them to initiate different selection or editing modes.
Adobe Illustrator and Figma only use some modifier keys to change modes only if a selection is currently being made.
Several applications don’t use any of these hold-key behaviors at all.

Basically this behavior isn’t an unknown pattern, just not ubiquitous.
There’s also an accessibility argument to be made against requiring a key to be held in order to change a mode (though it could be one of multiple options). Pressing a key to initiate a certain mode (and esc to leave it) or using the key as a kind of toggle doesn’t rely so much on the physical ability to hold a key for an unknown amount of time, so it is preferable.
In this case, it sounds like the user isn’t likely to hold command and stay in the mode indefinitely, only to use the command-click combo. Is that correct?
In terms of WCAG guidelines, I’d personally interpret having a key held to be a kind of “specific timing” that isn’t allowed (criterion 2.1.1). So I can’t recommend that if it is the only means of accessing this feature; if it can be accessed another way it’s okay, but not fantastic.
What I think might work:
Activating on a certain focus (for example, switching modes is only triggered by command when users are focused on the canvas) is a reasonable behavior and one that is a little more accessible. I’d consider that an option if there is a focus that seems relevant (similar to the Adobe Illustrator and Figma behavior I mentioned above).

Making the implementation such that it waited for click would avoid that, but it is more complicated - and someone else could argue that they would like to see the button change highlight when the cmd is being held down.

I was thinking the same thing. Is there a benefit to this mode being so transient, or do the people in favor of it consider this an option?

Related note: Is there a full list of commands in napari to reference this sort of thing and know what would have to be changed for more consistent behavior everywhere?

So I can’t recommend that if it is the only means of accessing this feature; if it can be accessed another way it’s okay, but not fantastic

it's definitely accessible otherwise.  the other way is to 1) click on the paint can icon, 2) click on the canvas... OR 1) press the 3 key 2) click the region 3) press the 2 key to return top the other mode.
The cmd-click is just a convenience that allows you to not move your mouse all the way to the top left.  Probably a ~0.2 second  key hold.  It's very common when annotating images to circle a region an then want to fill it in, so lacking a key command, it necessitates moving your mouse a lot more than previously.

That makes sense @tlambert03. Since I’ve found similar behavior on other software (particularly Photoshop), this “flicker” doesn’t seem like a bad pattern. I agree with that @sofroniewn

Would be nice to maybe ask a few more folks once the PR is made just to make sure we don't bounce back and forth though

Figma avoids this flicker by not using the held command key to trigger the mode since its the basis for many shortcuts. When I click through napari, it seems like holding option or control doesn’t do anything. Would those be better options to preserve the transient shortcut and avoid a flicker?

@sofroniewn not sure if you're overstating my support. =P Maybe not: I agree that the mode flicker with unrelated shortcuts was bad, and there were some bugs related to its implementation (under some circumstances, the mode would not switch back), but like @tlambert03 says I would have preferred to only remove this behaviour once an alternative was implemented.
Anyway, we're here now. Two alternatives:

special-case Ctrl-click, shift-click, etc so that they work but don't switch modes
implement a special casing of the mode shortcuts so that holding the mode shortcut (3) would temporarily change it, and releasing it would change it back. This could be implemented either with timing or with hold+click (ie if there was a click between button down and button up, revert back to the previous mode.)

These are not mutually exclusive, and the modifiers are probably much easier to implement currently, so we could do both. Opinions?
@tlambert03 in the meantime, I propose you keep your fingers over the number buttons while labelling. :stuck_out_tongue_winking_eye: quickly switching between 2 and 3 is almost as ergonomic as ctrl-click?

@tlambert03 in the meantime, I propose you keep your fingers over the number buttons while labelling. 😜 quickly switching between 2 and 3 is almost as ergonomic as ctrl-click?

there already :joy:

Another option could just be to use another set of keys for "temporary" enable (i.e. as modifiers), qwert or something? Holding one will change mode, but releasing returns to previous mode?

@sofroniewn do you see this being easier than having the toggles doing double duty? I find that more intuitive, e.g. holding on a Mac's menubar vs clicking on it.

The nice thing about qwert is that the mode button can change when you're holding so you do get that good visual input in the cases where you want it, but ultimately here I will defer to the ergonomics of what people who are doing this all the time prefer

@sofroniewn but that can happen also with 1, 2, 3, ...? It's just whether it flips back after holding.

Are we avoiding modifiers because it's harder to implement?  We don't have to change the mode immediately upon pressing the command key right?  It could be in the mouse click event

@tlambert03 yes that's option 1. The nice thing about option 2 is that you do get the nice visual feedback. The issue with modifiers is that if you do the visual feedback then you can get it when not intended — when activating other shortcuts.

@sofroniewn but that can happen also with 1, 2, 3, ...? It's just whether it flips back after holding.

1, 2, 3, ... would be permanent flips that happen on press (or release?, shouldn't matter)
q, w, e, .... would be temporary holds that return on release

Yes, I understand that. I'm saying, we can have:

1, 2, 3 change mode on press
on release, depending on how long we've pressed or whether there were any clicks during the press, we flip back to the original mode, or not.

I really like this pattern in general.

I like this too, if we can reliably pull it off in code.  Meaning, if it "behaviorally" works well, and the user never has to try twice.

I like this too, if we can reliably pull it off in code. Meaning, if it "behaviorally" works well, and the user never has to try twice.

Yup, we can try this - we could first just say if hold is longer than 1 second revert (probably hard to get a click off and have hold be less than 1 second), but we can fine tune details - overall i like the idea a lot, good fix that addresses all concerns

implement a special casing of the mode shortcuts so that holding the mode shortcut (3) would temporarily change it, and releasing it would change it back. This could be implemented either with timing or with hold+click (ie if there was a click between button down and button up, revert back to the previous mode.)

With regard to the above, this closed PR is relevant: https://github.com/napari/napari/pull/2854
Some work will be required for ActionManager to handle 'short press' and 'long press' - and if we do want to add this...


Cannot install 1.2.3 python bindings on python 3.6 on MacOS Catalina

Hello,
I can install 1.2.2 python bindings but the latest 1.2.3 release fails with:
Running setup.py install for splitstream ... error
    Complete output from command /some/path/bin/python3.6 -u -c "import setuptools, tokenize;__file__='/private/var/folders/_r/vnrbghg13992b97hxz1tmh6r0000gn/T/pip-install-tvcq5a55/splitstream/setup.py';f=getattr(tokenize, 'open', open)(__file__);code=f.read().replace('\r\n', '\n');f.close();exec(compile(code, __file__, 'exec'))" install --record /private/var/folders/_r/vnrbghg13992b97hxz1tmh6r0000gn/T/pip-record-h8p0iiv5/install-record.txt --single-version-externally-managed --compile --install-headers /some/path/include/site/python3.6/splitstream:
    running install
    running build
    running build_ext
    building 'splitstream' extension
    creating build
    creating build/temp.macosx-10.15-x86_64-3.6
    creating build/temp.macosx-10.15-x86_64-3.6/src
    creating build/temp.macosx-10.15-x86_64-3.6/src/python
    /usr/bin/clang -Wno-unused-result -Wsign-compare -Wunreachable-code -fno-common -dynamic -DNDEBUG -g -fwrapv -O3 -Wall -pipe -Os -isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX10.15.sdk -I/some/path/include -I/opt/local/Library/Frameworks/Python.framework/Versions/3.6/include/python3.6m -c src/python/splitstream_py.c -o build/temp.macosx-10.15-x86_64-3.6/src/python/splitstream_py.o
    src/python/splitstream_py.c:21:10: fatal error: '../splitstream.h' file not found
    #include "../splitstream.h"
             ^~~~~~~~~~~~~~~~~~
    1 error generated.
    error: command '/usr/bin/clang' failed with exit status 1

MacOS 10.15.5.
Python version (macports):
$ python
Python 3.6.11 (default, Jun 29 2020, 13:22:29)
[GCC 4.2.1 Compatible Apple LLVM 11.0.3 (clang-1<IP_ADDRESS>)] on darwin
Type "help", "copyright", "credits" or "license" for more information.

Tell me if you need additional information.

I switched the build pipelines from Travis to GitHub Actions. I could have broken something. I will investigate. Thanks for reporting.

It seems when building from pipelines, I needed to add a MANIFEST.in file with the headers (despite the headers being specified in setup.py). Seems to be a known issue, but I am not sure why it worked before on my MacBook. Anyway, version 1.2.4 (code-wise identical to 1.2.3) fixes the issue and I yanked 1.2.3 to remove any confusion.

Thanks!


Close stream after error

We are suffering a crash when server close the connect but several data still coming in. The crash stack indicates it might be related to the com.vluxe.starscream.websocket queue, which is used to handle streaming data. I posted the crashed stack below for a reference:
Thread 9 name:  Dispatch queue: com.vluxe.starscream.websocket
<Error>: 	Thread 9 Crashed:
<Error>: 	0   libobjc.A.dylib                0x0000000193a13bd0 0x1939f8000 + 113616
<Error>: 	1   CoreFoundation                 0x0000000181d37f48 0x181c64000 + 868168
<Error>: 	2   CoreFoundation                 0x0000000181ce3d0c 0x181c64000 + 523532
<Error>: 	3   CoreFoundation                 0x0000000181d4fd78 0x181c64000 + 966008
<Error>: 	4   libdispatch.dylib              0x000000019407d990 0x19407c000 + 6544
<Error>: 	5   libdispatch.dylib              0x000000019407d950 0x19407c000 + 6480
<Error>: 	6   libdispatch.dylib              0x00000001940880a0 0x19407c000 + 49312
<Error>: 	7   libdispatch.dylib              0x0000000194080a58 0x19407c000 + 19032
<Error>: 	8   libdispatch.dylib              0x000000019408a314 0x19407c000 + 58132
<Error>: 	9   libdispatch.dylib              0x000000019408bc48 0x19407c000 + 64584
<Error>: 	10  libsystem_pthread.dylib        0x000000019425d218 0x19425c000 + 4632
<Error>: 	11  libsystem_pthread.dylib        0x000000019425cedc 0x19425c000 + 3804

I tried to fix it by closing the streaming after getting an error and it seems work fine for us. However, I am not an expert on web socket so I am not sure whether something else breaks or not.
Would you mind to have a look at it? Thanks.

Thanks for the PR, but this will break it from disconnecting when properly called with the disconnect method. The (sort of) good news is I think this is the same issue as #158 and I have a fix that I hope to have submitted later tonight. I will updated everyone once it is pushed up.

Oh, I am sorry that I haven't noticed the issue before trying to fix. Thanks for your effort on it.

All good, I appreciate you trying to fix it :smile:. Apologizes if my last comment came off harsh, just trying to respond quickly. I was a bit leery there might be a few issues with the major change like 1.1.0 brought, hopefully the next fix/version will resolve all the outstanding issues.

I just checked in the fix into master. Let me know if that seems to resolve it and I will do another release.

@daltoniam Thanks! I will try the master now and let you know the result :)

@daltoniam I can confirm it fixed our issue. Thanks a lot!


New version: vim.vim.nightly version 9.1.0067

Pull request has been created with WinGet Releaser v2 :rocket:
Microsoft Reviewers: Open in CodeFlow

Automatic Validation ended with:

Installation failed with exit code -1978335187 2024-02-01 00:02:46.820 [FAIL] Installer failed security check. Url: https://github.com/vim/vim-win32-installer/releases/download/v9.1.0067/gvim_9.1.0067_x86.exe Result: 0x80004005

(Automated response - build 686.)

/AzurePipelines run


Remove applicant status from Conditional approval read only

To reduce confusion for analysts if the status in the Conditional Approval section is different from what's above since it's a read-only of the conditional approval form, not of the status table.
Current

Desired

[x] Remove status that applicant sees from read-only view
[ ] Move date letter sent to applicant to 3rd column

Hey team! Please add your planning poker estimate with Zenhub @AntBush @marcellmueller @rafasdc

I don't think it's supposed to show the status:

I've reproduced it, fix incoming. Sorry about that!


cache miss on bounded crossbeam_channel::Receiver try_recv

Hi,
I don't know whether this is an expected behavior of Atomics but when I run perf on my code I see that there are cache misses on try_recv call. I have a bounded queue, which has 8 senders and 1 receiver. In the sender sides, I couldn't find any notable miss, because of that I raise that issue for the receiver side.
My call:
loop {
    while let Ok(mut messages) = self.parsed_feed_receiver.try_recv() {
        ...
    }
        ...
}

There are other small misses but they are negligible compared to these 3 lines. If you can help to figure this out, I'll appreciate that. Thanks in advance.

The access to the field is causing loading from memory, so this patch may improve the situation: https://github.com/crossbeam-rs/crossbeam/compare/master...taiki-e/local-mark-bit

@taiki-e thanks for your quick response! I tried with the new branch, unfortunately it's still same.

Hmm, since mfence does the serialization, the previous cache should not be available for the load from r15+0x80 (i.e., self.tail), but I thought the load from r15+0x190 was the access to self.mark_bit, so I thought that could be omitted. However, normal offset of self.mark_bit is actually 0x108...


Symbol map support

Added a demo for a symbol map using icons defined using URLs.  @ryanbaumann were you thinking symbol map would make use of the Maki library or is this in the right direction?
To do:

[ ] symbol legend
[ ] custom symbol url property name
[ ] symbol size controls
[ ] Maki symbol support?

Addresses #4

Thanks for taking a stab at this @akacarlyann - I would suggest we use the map.addImage() function to add symbols to the map style for performance reasons over HTML markers.  https://docs.mapbox.com/mapbox-gl-js/example/add-image/
Support for default maki icons in symbol maps would be a good batteries-included feature for data visualizations.


Home component shows please login even when logged in

Even when connected the Home page show please loggin

removed the please login, put  a description of LoyaltEth instead


[RN] Phone validation doesnt match design

[ ] invalid phone error is duplicated on screen
[ ] flags layout and size doesnt matches master look and feel

Precondition:
The phone entering stage is opened (self custody flow)
Steps to reproduce:

Enter the incomplete phone number
Pay attention to the duplicated field hint

Actual result: The validation error is duplicated on the phone entering stage
Expected result: The only one validation error should be displayed on the phone entering stage
Checked on https://goodnative.netlify.app/ V1.3.1-1
LG V30+ // Android 8.0 // Google Chrome 85.0.4183.121
Desktop: Windows 10 // Google Chrome 85.0.4183.121

@sirpy @mauriguz @MarianoAmado

only one validation error is displayed as it expected
the flag is displayed fully
Checked on  native 1.3.1-1
LG V30+ // Android 8.0 // Google Chrome 86.0.4240.75
Desktop: Windows 10 // Google Chrome  86.0.4240.75


Feature Request:  Ability to upload own TTF font.

Hi, we use our own custom font that we use for icon generation.  Please add the ability to upload our own TTF file to generate notification & action icons from.  Currently I have to export a png from the font which is somewhat time consuming.  Thanks, Colin

This is out of scope since this tool is client side only

no worries, the improvements in Vector support make this ticket obsolete now anyway.


Added unit tests for addOrUpdate user model function

Added unit tests for addOrUpdate user model function

@swarajpure , this PR is added as a reference for adding unit tests for other model functions.


feat(head): utilize the ebrake when motors are disabled on the ZA

Overview
Closes RET-1313. Now, whenever head motors are disabled, it will automatically re-enable the ebrake so that heavy instruments (such as a 96 channel pipette) do not fall. At some point in the future, hopefully we can refactor these hardware classes and make the inheritance a little cleaner. For now, I just chose to separate everything out which is very
similar to how pipette_motor_hardware works.

Codecov Report

Merging #581 (5c3a8ba) into main (f0d2cc7) will decrease coverage by 0.26%.
The diff coverage is 82.75%.

@@            Coverage Diff             @@
##             main     #581      +/-   ##
==========================================
- Coverage   84.46%   84.21%   -0.26%
==========================================
  Files          89       83       -6
  Lines        2871     2958      +87
==========================================
+ Hits         2425     2491      +66
- Misses        446      467      +21

Impacted Files
Coverage Δ

bootloader/core/pipette_node_id.c
0.00% <0.00%> (ø)

include/rear-panel/core/messages.hpp
57.44% <20.00%> (ø)

bootloader/core/message_handler.c
63.70% <100.00%> (+1.84%)
:arrow_up:

include/can/core/messages.hpp
99.21% <100.00%> (+0.04%)
:arrow_up:

include/common/core/debounce.hpp
100.00% <100.00%> (ø)

include/pipettes/core/mount_sense.hpp
100.00% <100.00%> (ø)

...ude/can/core/message_handlers/presence_sensing.hpp

include/head/core/attached_tools.hpp

include/head/core/presence_sensing_driver.hpp

include/common/tests/mock_adc_channel.hpp

... and 5 more

If the only difference is that we  use the ebrake for the Head motor, have we considered adding the ebrake as just an optional configuration for the MotorHardware class? Maybe something along the lines of making the value in HardwareConfig be std::optional<gpio::PinConfig> ebrake = std::nullopt; and only setting it if it's defined - not the cleanest solution, but I worry about having three almost-identical copies of this class.

Yeah I agree, which is why I had attempted to do that big refactor  which didn't turn out the way I wanted it to.
The pipette motor hardware class will be going away as the implementation for tip sensing will be different.
I am happy to change ebrake to an optional param. @sfoster1 what do you think about that?

Okay, lets do it!


Improve README

The readme was not really something for a GH Action, so I added some info (Basic example, option list and description and explanations of the different structures).
I would apreciate if you could check if the info I provided here regarding the File, plugin dependencies and platform dependencies is correct, as I based them on what I could gather from the index.js file and the Hangar API docs.

lgtm, thanks!


Disable setupClipboard, ignoring paste events

It doesn't look like there's an interface to stop listening for paste events on <body> for example. Have I missed something?

You are right - if you call setupClipboard right now there isn't a way to unbind it.  In fact none of the setup calls allow that.  I'd accept a patch to introduce that behavior.  I guess the setup calls could return an object including a destroy() function, or they could check for FileReaderJS.enabled before processing anything (and the page could flip that).


Update version to 1.1.24-9 on staging

Update version to 1.1.24-9

Closing this so we can rerun - the deploy workflow broke halfway
https://github.com/Expensify/App/commit/cf918851af1a431c1d58e791f2bc97e357ac4ec8/checks


ModuleNotFoundError: No module named 'nvstrings' (rapids-colab.ipynb)

Error
ModuleNotFoundError: No module named 'nvstrings'
To Reproduce
Run cuDF cell after executing prior cells from rapids-colab.ipynb example notebook in Google Colab.
Notebook linked under "Get Started" on rapids.ai.
Code
import nvstrings, nvcategory, cudf
import io, requests

# download CSV file from GitHub
url="https://github.com/plotly/datasets/raw/master/tips.csv"
content = requests.get(url).content.decode('utf-8')

# read CSV from memory
tips_df = cudf.read_csv(io.StringIO(content))
tips_df['tip_percentage'] = tips_df['tip']/tips_df['total_bill']*100

# display average tip by dining party size
print(tips_df.groupby('size').tip_percentage.mean())

Temp Solution
Re-run Setup cell; issue is always resolved.
Full Output
---------------------------------------------------------------------------

ModuleNotFoundError                       Traceback (most recent call last)

<ipython-input-4-77b6558ae5dc> in <module>()
----> 1 import nvstrings, nvcategory, cudf
      2 import io, requests
      3
      4 # download CSV file from GitHub
      5 url="https://github.com/plotly/datasets/raw/master/tips.csv"

ModuleNotFoundError: No module named 'nvstrings'

---------------------------------------------------------------------------
NOTE: If your import is failing due to a missing package, you can
manually install dependencies using either !pip or !apt.

To view examples of installing some common dependencies, click the
"Open Examples" button below.
---------------------------------------------------------------------------

@gumdropsteve , we pushed a new start up script today.  Check out https://github.com/rapidsai/notebooks-extended/pull/110 and the new script to see if it solves you prroblem :)

Yes, this solves the issue.
It does take a bit longer (than the old setup script) to install everything but the new script from #110 worked on the first time every time (tested 5 times).
New script does not seem to be in Example Google Colab yet so I'll leave this issue open?
-- Thank you

Yes @taureandyernv , this solves the setup issue. It does take a bit longer (than the old setup script) to install everything but the new script from #110 worked on the first time every time (tested 5 times).
New script does not seem to be in Example Google Colab yet though, so I'll leave this issue open?
-- Thank you


(DO NOT MERGE) virtio,hvt: x86_64: Unmap zero page, forcibly disable TLS

This is the x86_64 implementation of the fix for #296.
Unmap the page at virtual address 0x0. On hvt, actually unmap everything below X86_BOOT_INFO_BASE (notably the guest page tables), and move that up appropriately.
Adds the following test cases:

test_null: verifies receipt of #PF on NULL pointer dereference.
test_notls: we do not support TLS at this time, so verify that a low (<1k) TLS access via %fs:[] likewise results in #PF rather than silently returning garbage, which was the case until now.

@Kensan @ehmry This should not directly affect Muen or Genode as we don't run tests on these targets (yet), but I'd still like to know if either of these targets unmap the page at 0x0? If not, you might want to consider doing that.

No Genode does not map the first page. We also never use %fs or %gs in userland, so we notice right away when something is compiled with TLS. NOVA leaves these registers unitialized and I think SeL4 reserves these for its own use.

@ehmry Thanks for checking, in that case there's nothing you need to do for this change.

@ricarkol I've addressed your comments, and further cleaned this up. The latest version now includes (expected to fail) tests for aarch64, and explicitly deals with the TLS registers. Could you give this another pass of review, please?

I tested this PR on my FreeBSD-CURRENT, both compilation and execution of all tests are passing as well. FreeBSD clang version 6.0.1, LLD 6.0.1 (FreeBSD<PHONE_NUMBER>000) (this is llvm-ld as well, not GNU ld)

@mato  TPIDR_EL1 is used for CPU local storage (like percpu data in Linux), so TPIDR_EL0 here used for TLS is OK, just like TLS in Linux process. So I think this code is OK for Arm64.

@Weichen81 Thanks for confirming.

Merged as part of #294.


How can I divide playURL() into two steps?

When I integrate your code into my app. I have the following problem:
playURL() ->

setURL()
Initialize the video before play (e.g., buffer video)
play()
Immediately play the video

Thanks!

cp.dpause()
cp.playURL()

Thanks Xinhua for your reply!
According to my understanding,
firstly, cp.dpause() and cp.playURL()
secondly, cp.play() when I wanna immediately play the video
correct? thx

On Oct 23, 2017, at 06:59, Xinghua Fan<EMAIL_ADDRESS>wrote:
cp.dpause()
cp.playURL()
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/flexih/CorePlayer.Swift/issues/7#issuecomment-338623368, or mute the thread https://github.com/notifications/unsubscribe-auth/AGMV1xJb31SxRZ22yYe-tnbtDZ6vwFw1ks5svHGkgaJpZM4QCEez.

yes


Please consider porting to the latest PyO3

Please consider porting to the latest PyO3, currently 0.22, which has full support for Python 3.13.
https://pyo3.rs/v0.22.0/migration#from-020-to-021
https://pyo3.rs/v0.22.0/migration#from-021-to-022

Yeah, I agree. It's in my mental backlog to get done before the next proper release. Just a matter of finding available time. Thanks for putting it into writing though. 😊

Just curious, have you tried using the Stable ABI? That would be a single binary instead one per Python version.
The RC is out now, binaries are supposed to be build for 3.13.
I've been able to work around this by setting PYO3_USE_ABI3_FORWARD_COMPATIBILITY=1 on CPython 3.13, but that means that it's able to compile with the stable ABI, I believe.

have you tried using the Stable ABI?

If I understand correctly, and I'm just glancing at some of the raw C calls now, the first one I encounter is PyMemoryView_Check which doesn't appear to be part of the stable ABI, and a few others being used are stable as of 3.11.
It would've great to only have to do a single binary instead of one per Python version, but that complexity ship has already sailed and for the most part works nicely (outside of trying to also maintain an entirely separate build pipeline for conda despite cramjam having no other Python deps, but that's another story)


go vet check failed

src\github.com\docker\libnetwork\drivers\windows\overlay\ov_network_local_windows.go:150: assignment copies lock value to *dstep: overlay.localNetwork

I believe this code is no longer there after #1636. Closing this issue.


Add info about packages' CPU architecture support

Hi,
Would it be possible to add information about which CPU architectures are supported by each package/recipe at https://bioconda.github.io/conda-package_index.html ?
At the moment I could get this info from the meta.yaml of a recipe and/or find the package at https://anaconda.org, but this is only one by one.
For me it would be really useful if I can see and filter this information at the page that lists all Bioconda packages.

I like the idea!
The best would be https://anaconda.org/ to provide UI controls for filtering by channel (e.g. bioconda) and by CPU architecture. But I have no idea who to convince about improving https://anaconda.org/
I'll take a look how to add this information to conda-package_index.html!

@ Anyone more familiar with this repo: Where otherdata['objects'] is populated ?
https://github.com/bioconda/bioconda-docs/blob/5021bc45b1d26e35082777ce2a532f2941da823a/source/_ext/bioconda_sphinx_ext.py#L508
https://github.com/bioconda/bioconda-docs/blob/5021bc45b1d26e35082777ce2a532f2941da823a/source/_ext/bioconda_sphinx_ext.py#L398 uses this data to prepare it for rendering, but I cannot find the code that initializes otherdata['objects']

This issue could be closed!
#36 has been merged.


backup/restore: Change to the WITH OPTIONS syntax

PR: https://github.com/cockroachdb/cockroach/pull/17528
@sploiselle, looks like in RESTORE, the WITH OPTIONS syntax has been changed. According to this comment from @dt, though, the old syntax will continue to work for 1.1, so this is low-priority.

@sploiselle, is this covered in your 1.1 updates?

For 1.1: Let it be in the diagrams, replace in examples.
Check for 1.2

As per discussion with @dt, we are supporting both formats for 2.0 as well. So using the same strategy as for 1.1: Let it be in the diagrams, replace in examples.


feat: add basic tests!

Adding basic tests, it's not much but it's a starting point.

TODO make the tests call the index.run correctly.
><EMAIL_ADDRESS>test
> jest --passWithNoTests

 FAIL  ./index.test.js
  ● Test suite failed to run

    TypeError: index.run is not a function

       97 |   delete context.payload.issue;
       98 |   // Run the function.
    >  99 |   index.run();
          |         ^
      100 |   // Assert that the function failed.
      101 |   expect(core.setFailed).toHaveBeenCalledWith('Action must run on a Pull Request.');
      102 | });

      at run (index.test.js:99:9)
      at Object.describe (index.test.js:10:1)

Test Suites: 1 failed, 1 total
Tests:       0 total
Snapshots:   0 total
Time:        0.245 s
Ran all test suites.


user cannot select some total pieces

Hello
I want to block selected amounts, for example; The user cannot total select 3,6,7,9,11 pieces options.
Is this possible?
Thank you.

I don't think I can tell it right. For example, the user chose two options, no problem. But I want a warning to appear when a total of 3 (6,7,8,11) options are selected.
The goal is to prevent the user from choosing 3 options. How can I make it appear that such a warning?

I don't know if I really understood your problem.
My guess is that you want to restrict number of selected options to 2. If the user selects more than 2 options, you want to show a warning message.
If that is correct, then check this
https://github.com/Janking/dropdown/blob/master/index.html#L177
You need to use limitCount: 2.

I give an example

I tried to explain with the infographic above. I hope this time :)
Is this possible?

Unfortunately no. Not possible as of now. But you can always modify the script as per your needs. The source code is clean enough to read and modify :)

I see, I'll try this
Thank you @shirishparsekar

I see, I'll try this
Thank you @shirishparsekar

Welcome to contribute your code~


[SwiftToCxx] Including Cxx representation of Swift's Error

This PR includes the class Error which represents a Swift error that can be extended and a function can throw!

@swift-ci please test

@swift-ci please test

You should test the new semantics by doing the following - throwing a Swift error that contains a reference to a Swift class type instance. When the class value gets destroyed it can print that it gets destroyed, then in our test we verified that it's indeed destroyed. For example:
// Swift:
class Test {
  deinit {
    print("Test destroyed")
  }
}

public struct TestError: Error {
  let t = Test()
}

public func testError() throws { throw TestError() }

// C++

void test() {
{
  try {
    testError();
  } catch(const swift::Error &e) {

  }
}
// CHECK: Test destroyed
}

@swift-ci please test

@swift-ci please test source compatibility


Rigidbody display bug in Rigidbody Editor

Summary
Rigidbodies with a non-null angular velocity will be displayed oddly in the rigidboy Editor, but will behave normally (see first gif).
It seems that the rigidbody is displayed using a different Z value (see second gif). Changing RB Editor camera to Flat or Parallax doesn't do anything.
How to reproduce [Bugs]

Tried to reproduce in a fresh project but couldn't, will update if found. Project source uploaded here

Attachments

:+1: for this really really nice bug report.

Fixed and release in progress. Check for package updates in about 30 minutes.


Check possible issue with -nozeroline- and coefficient formatting options

It seems like the -nozeroline- and coefficient formatting options may have been disabled in the last release. @Constantino-Carreto-Romero can you check if this is the case, please?

@Constantino-Carreto-Romero Did you manage to check anything about this bug?

@jorpppp I have not reviewed it, but I will do it today. I'm just preparing to upload the preliminary files for issue #59, so I can review issue #105 today.

@jorpppp I checked xteventplot's appearance options and the ones not working were nozeroline and nominus1label. In https://github.com/JMSLab/xtevent/commit/530cff4c01ceaff320440b99da8281452d3f9c5d I fixed it.
These are examples to verify that they now work:
*install the xtevent version from the branch
net install xtevent, from("https://raw.githubusercontent.com/JMSLab/xtevent/issue105_some_plot_options_not_working") replace

*load example31.dta
use "https://github.com/JMSLab/xtevent/blob/main/test/example31.dta?raw=true", clear
xtevent y, panelvar(i) t(t) policyvar(z) window(5)
xteventplot, nozeroline
xteventplot, nominus1label

Summary: In this Issue we fixed bugs related to some graph elements.
Thread continues in #106


build(gradle): Update transitive commons-io versions

Avoid CVE-2024-47554 by manually updating transitive commons-io versions until a new SW360 client version is available.

until a new SW360 client version is available.

@heliocastro, could we get a new SW360 client release with non-vulnerable dependencies?


Comment out new-project in grafana addon

Comment out new-project in grafana addon - grafana is often paired with Prometheus, but the new-project in the grafana addon hinders that.   Once conditionals are added, probably should test for whether the project namespace exists or not.

@budhram @praveenkumar The problem here is that oc new-project returns non zero when the project already exists ...
tcunning@tcunning-OSX:/tmp/prometheus-operator$ oc new-project myproject
Error from server (AlreadyExists): project.project.openshift.io "myproject" already exists
tcunning@tcunning-OSX:/tmp/prometheus-operator$ echo $?
1

so the script bombs out at that point if the project doesn't exist.     You can easily do a oc new-project and create a project, but the inclusion of the oc new-project line here means you can't ever install grafana into a previously existing namespace - which means the addon is essentially useless because the main use case for grafana is going to be installing it into a namespace with other stuff.
The most common use case for grafana I think is going to be install it into a previously existing namespace that has some sort of data to be graphed (a database, prometheus, etc)
It'd be great if oc new-project had a flag like --no-fail that returned 0 if the project exists.


update the async event handler to kotlin as an example

closing for now until we can support java sdk 1.8


Add the ability for AutoRoutePart to have additional aliases for a content item

Purpose

Content item to be accessed through multiple URLs.
Ensuring SEO compatibility by use of canonical URLs.

Requirements

Admin must be able to create multiple alias paths for a Content Item.
Admin must be able to select only one path as the preferred URL(Primary Path) for the Content Item.
Admin must be able to either create a path manually or select a pattern to generate the path.
Admin must be able to edit Content Item's paths, by altering the pattern or modifying the text manually. The regeneration of paths must take place after Content Item is saved.
Change of patterns in setting must not affect the existing alias paths.
If the regenerate path option is selected in the settings, paths must be regenerated when Content Item is modified and saved.
The preferred URL will be indicated as canonical.

UI Interactions
Following changes will take place in Content Item editor including an Autoroute part:

Admin will be able to add multiple paths instead of only one that is currently available.
"Permalink" will be renamed to "Path".
Admin can select one of the paths (by checking a radio button) as the primary path which would be used as the preferred URL to access the Content Item.
When creating/editing a Content Item, Admin will be able to choose one of these options from a dropdown list for each path:

"Custom Path" which enables admin to provide a path manually. This option enables the textbox for indicating the path manually.
A pattern from a list of patterns retrieved from the part's settings. This option disables the textbox for indicating the path manually. If nothing is chosen, alias will be made based on the default pattern selected in Autoroute Part Settings.

When editing a Content Item, for existing paths generated by patterns, Admin will see the selected pattern in a dropdown list and the generated path in a disabled textbox. If a new pattern is selected, the disabled textbox will be emptied. The newly generated path will be shown once the Content Item is saved.
When editing a Content Item, for existing custom paths, Admin will see "Custom Path" selected in the dropdown list and the manually created path in a enabled textbox.

Implemetation

AliasPathInfo.cs to be created with following properties:

string AliasPath
int? PatternIndex (if null, that mean that the path is made manually)

AutoroutePart.cs will be modified to contain the following properties:

IEnumerable Paths
int PrimaryAliasPathIndex (index of the preferred path used as the canonical URL)

I like this as it will remove the need to manage custom aliases in a different module... although, the aliases module is getting updated to support better organization of aliases (those auto-generated vs user-generated).  It would still be nice to be able to manage these aliases directly via the aliases UI admin page.  Not sure if there will need to be any additional updates to that as well.

Not sure if you would need to be able to manage these AutoroutePart-managed aliases fro, the Alias UI, since you can always just click on the path from that UI which will take you directly to the content item, from where you can add/remove/edit the various aliases anyway. The managed aliases are managed by the system, so allowing the user to manage them from the Alias UI potentially complicates things and may be confusing even.
In any case, really like the idea of the ability to create multiple aliases per content item in an easy manner.

@dcinzona Another point on this: all this actually came out of the realization that custom aliases can't reliably be used to accomplish this, as they will store the ID values of the items to which they point, and those ID values are not persistent across export/import.

True, but I think we should still have some kind of view where an admin can list out all of the site aliases and easily get to the content item edit page that contains it.  Just an easier way to figure out what content is where and how users are getting to it.
There are some issues with the custom aliases module that we are using anyway, so we would like to get away from that...but in the cases where we would like to create short links (or convenience links) to the same content item / url, that's what we have to use for now.

@sfmskywalker I think what I was trying to say was that we would have to make it so we couldn't manage aliases from the Alias UI - or when adding an alias, instead of providing you with a text field for a route path, it should be a content item picker.

Why not use permanent redirects instead? You would have a canonical url for a content item, and then the redirects would point to this. So when we render the content item url, it will always be the same. This could still be implemented as a separate module or feature, even with a custom content part to set alternative urls. And there could also be another main page to manage all redirects. You can even use it for controller/action.

@dcinzona You would still be able to view these additional aliases in the aliases UI, as they would be listed under the "managed" tab. Just like other autoroute aliases, they will appear there but in read-only form (you won't be able to edit/delete them). Any modifications to them, you are expected to perform from the autoroute part UI.
@sebastienros Why not have the option of both? When you create an additional path for a content item, you can specify if it should act like a redirect or as an alternate alias?

Can this also support redirecting from the default content display url (/Contents/Item/Display/10) to the autoroute url?

@mjy78 That's an interesting option... Maybe as a setting to enable it globally or within each content item individually? There could be scenarios where you would want it to redirect to the autoroute url, and others where you wouldn't. (i.e. displaying widgets / layers)


[BUG] Casting spells with concentration does not work at all in dnd5e 4.1

Casting spells with concentration does not work at all in dnd5e 4.1

This was actually appearantly caused by this issue in dfreds convenient effects: https://github.com/DFreds/dfreds-convenient-effects/issues/321

I was checking that yesterday with all modules updated in prep for fixing Effects with Midi-Qol https://github.com/PwQt/magic-items-2/issues/106 and it all seemed working fine.
Closing.


[Question] Rendering PNG images ?

I wonder if there is a way to display images in the terminal using bubbletea, does it support something like ueberzug ?

Did you find it?


WIP/MESOS: Non unique endpoint ip no port names

Before this PR endpoints were validated by container IP and port in a number of e2e tests.
Depending on the endpoint controller logic neither of the two must match for a valid endpoint (e.g. in a Mesos setup).
This PR fixes the service.go e2e tests to compare the pod ID of an endpoint instead of the IP
makes sure the compared port is the actual container port, not the host port.
The short-term solution to recover the container ports from an endpoint in the case of mesos/docker clusters are annotations on the endpoints. These are applied by the Mesos endpoint conroller to be able to lookup the container port which usually is not part of the EndpointPort struct.
The proposed long-term solution is to add a ContainerPort field to the EndpointPort struct. This should default to the Port value, but be set to the actually container port by endpoint controller like that of Mesos.

/cc @jdef for internal review

minor doc nit, otherwise lgtm.
/cc @thockin

LGTM


Error on CI: Target 'SwiftUIMacrosImpl' must be enabled before it can be used

I noticed an error on our CI.
We use bitbucket. This is the error: Target 'SwiftUIMacrosImpl' must be enabled before it can be used
Is there something to be done in the package itself, or we need to fix CI on our end?

As macros alter source code, Xcode requires you to allow them first. It looks like there is a flag you can set so this manual approval is not needed (see here)


Update typescript version in test projects

What does this change?

Bumps TypeScript version in each test project's package.json. This fixes tests run with sbt test

Would like to have @rtyley to double check this.

Would like to have @rtyley to double check this.

ok! Feel free to merge this without me when you're ready if you need it soon!


File > Open File(s) error when reading tif files

🐛 Bug

To Reproduce
Steps to reproduce the behavior:

File > Open Sample > napari > Cell
File > Save Selected Layer(s) > save as test.tif file
File > Open File(s) > select test.tif --> AttributeError: 'NapariPluginManager' object has no attribute 'ext_map'

The same file can be opened by File > Open Files as Stack.

Expected behavior
tif file should be able to open using File > Open File(s) option.

Environment

Please copy and paste the information at napari info option in help menubar here:
napari: 0.4.15
Platform: macOS-12.3-x86_64-i386-64bit
System: MacOS 12.3
Python: 3.9.12 | packaged by conda-forge | (main, Mar 24 2022, 23:27:05) [Clang 12.0.1 ]
Qt: 5.15.2
PyQt5: 5.15.6
NumPy: 1.22.3
SciPy: 1.8.0
Dask: 2022.03.0
VisPy: 0.9.6

OpenGL:

GL version: 2.1 ATI-4.8.13
MAX_TEXTURE_SIZE: 16384

Screens:

screen 1: resolution 1792x1120, scale 2.0

Plugins:

clEsperanto: 0.16.0

console: 0.0.4

napari-assistant: 0.1.6

napari-segment-blobs-and-things-with-membranes: 0.2.21

napari-time-slicer: 0.4.3

napari_skimage_regionprops1: 0.3.2

napari_skimage_regionprops2: 0.3.2

scikit-image: 0.4.15

svg: 0.1.6

Any other relevant information:
No reader plugins are installed.

@Czaki

@chili-chiu I'm having trouble reproducing this one. Does this still happen for you?

@chili-chiu I'm going to go ahead and close this. Please reopen if you see it happen again!


Sbt plugin for project setup

Project setup is quite complicated and require some changes in list of options. Providing plugin for single line enabling uniform in project would be noticeable time saver.

What would this plugin actually do?

Add scalac flag for 2.11
Add compiler plugin
Provide variables with same version for every component to dependency management

I'm not likely to build this as I don't think the setup is necessarily much more complex than adding an sbt plugin to your project.


Feature Request:  Pie Chart Legend

Self explanatory.  Labels on the chart don't scale terribly well.

Any news?

Any update?

+1

+1. It would be really useful to have for us. @wcharczuk is there any update on this?

+1


Mocha stack trace color conflicts with solarized light background

[x ] Checked that your issue isn't already filed by cross referencing issues with the common mistake label
[x ] Checked next-gen ES issues and syntax problems by using the same environment and/or transpiler configuration without Mocha to ensure it isn't just a feature that actually isn't supported in the environment in question or a bug in your code.
[x ] 'Smoke tested' the code to be tested by running it outside the real test suite to get a better sense of whether the problem is in the code under test, your usage of Mocha, or Mocha itself
[x ] Ensured that there is no discrepancy between the locally and globally installed versions of Mocha. You can find them with:
node node_modules/.bin/mocha --version(Local) and mocha --version(Global). We recommend avoiding the use of globally installed Mocha.

Description
text does not show up on solarized light
Steps to Reproduce
add solarized light theme to your terminal and run mocha.  the error stack trace is the same color as the background. solarized light is a very common theme, and it seems worth avoiding this collision
Reproduces how often: 100%
Versions
mocha version 4.0.1
node version 8.4.0
GalliumOS, xfce
just the regular terminal program
bash
babel-register
Really, ideally, you would be able to configure mocha with custom colors. I don't know why this feature wouldn't be included, but maybe it's more difficult than I realize.

So, I was able to fix my problem by changing one line https://github.com/mochajs/mocha/blob/master/lib/reporters/base.js#L64 to 92.
It seems like it would be easy to expose this to the user, and I wouldn't have to do that every time I install my project or any other and not have to maintain a separate version of mocha just for this one line.
It would be really appreciated.
Thank you.

@zwhitchcox please search the issue tracker (more?) before creating issues
duplicate

I did search, but I didn't see one. Could you please show me where this already exists?

search for "solarized" or "colors" etc etc.
paraphrased:  solarized is broken, not mocha.  use a different color scheme.

Ok, so you're not gonna fix this?

Sorry, if I seem dense, it just seems unbelievable to me that you wouldn't fix something so simple that is affecting so many people. Kind of hard to believe to me.

the bug is not in mocha so there is no fix. solarized is broken; use another color scheme


Build VSMefX for .NET Framework as well

This is important to avoid assembly load failures when scanning net472-targeted MEF catalog assemblies.
The dotnet tool package we were building breaks the build if the project includes .NET Framework targets, so I've disabled the package build for now. Eventually we may have to split this tool into two distinct projects if we want dotnet tool to continue to be a means of acquisition for the .NET Core build of the tool. But I wonder if instead we ought to have a single tool with a common front-end and then a separate process backend that can run on either .NET Core or .NET Framework as required to load the assemblies given in the catalog.

Codecov Report

Merging #296 (2a1b864) into main (475dc3c) will decrease coverage by 13.76%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##             main     #296       +/-   ##
===========================================
- Coverage   89.55%   75.79%   -13.77%
===========================================
  Files          87      110       +23
  Lines        6111     7188     +1077
===========================================
- Hits         5473     5448       -25
- Misses        638     1740     +1102

Impacted Files
Coverage Δ

...t.VisualStudio.Composition.VSMefx/ConfigCreator.cs
0.00% <0.00%> (ø)

....Composition.AppDomainTests/OpenGenericExport`1.cs
0.00% <0.00%> (-100.00%)
:arrow_down:

...mposition.AppDomainTests/ExternalExportOnMember.cs
0.00% <0.00%> (-100.00%)
:arrow_down:

...mposition.AppDomainTests/ExternalExportWithLazy.cs
0.00% <0.00%> (-100.00%)
:arrow_down:

...osition.AppDomainTests2/CustomMetadataAttribute.cs
0.00% <0.00%> (-100.00%)
:arrow_down:

...dTypeReceiver/PartThatImportsLazyOfEmbeddedType.cs
0.00% <0.00%> (-100.00%)
:arrow_down:

...rtThatLazyImportsExportWithMetadataOfCustomType.cs
0.00% <0.00%> (-100.00%)
:arrow_down:

...atLazyImportsExportWithTypeMetadataViaTMetadata.cs
0.00% <0.00%> (-100.00%)
:arrow_down:

...tLazyImportsExportWithTypeMetadataViaDictionary.cs
0.00% <0.00%> (-100.00%)
:arrow_down:

...ft.VisualStudio.Composition/LazyMetadataWrapper.cs
68.71% <0.00%> (-3.07%)
:arrow_down:

... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 475dc3c...2a1b864. Read the comment docs.


Fixes

For multiple versions of the same dataset, e.g. read_econdata(id = "CPI_ANL_SERIES", tidy = TRUE) gets v2.0, v2.1 and v2.2 of the CPI, econdata_wide() and econdata_long() (workhorses of econdata_tidy()) were designed to call themselves, i.e. they are recursive functions. Your prettymeta coding did not respect this i.e. it only worked for a single version of a dataset. I have here adjusted the code a bit to allow getting multiple versions of the same dataset with pretty metadata. Your coding also broke some of my examples, which I fixed here. Finally, I implemented the metadata matching for loops in a slightly more efficient way (indexing data.frame's in a loop is not ideal, plain lists are much more efficient).

PS: R CMD Check still fails because of undicumented arguments:
Undocumented arguments in documentation object 'read_econdata'
‘agencyid’ ‘provideragencyid’
Undocumented arguments in documentation object 'read_release'
‘agencyid’ ‘provideragencyid’
Undocumented arguments in documentation object 'write_econdata'
‘agencyid’ ‘provideragencyid’
Undocumented arguments in documentation object 'write_release'
‘agencyid’ ‘provideragencyid’
Functions with \usage entries need to have the appropriate \alias
entries, and all their arguments documented.
The \usage entries must correspond to syntactically valid R code.
See chapter ‘Writing R documentation files’ in the ‘Writing R
Extensions’ manual.


Are you using OAuth provider within Dingo?

I cannot get the OAuth provider working unless I do an over-whole to the provider. Previously package was recommending lucadegasperi/oauth2-server-laravel. But it doesn't support Laravel > 5.2.
Probably the best option would be for us to move forward with laravel\passport. But then the problem is laravel/passport > 2 doesn't support lucadegasperi/oauth2-server-laravel < 6
At this time I have 2 options.
1, Do a release without OAuth provider and add support later
2. Release with OAuth support + Laravel/Passport < 3
This is something holding the release at the moment.

For current release I would go for option 1.
Atm this project still needs some customization after installation.
However more opinions are welcome.


Github Actions

Type of change

New feature
Improvement (improvement to code, performance, etc)

Description

Replicate Fabric CA Azure Pipelines on GitHub Actions in preparation to migrate from Azure Pipelines

For those curious / comparison purposes, here's a successful run of the new GitHub Actions workflow.


System.InvalidOperationException

Unhandled Exception: System.InvalidOperationException: An attempt was made to transition a task to a final state when it had already completed.    at System.ThrowHelper.ThrowInvalidOperationException(ExceptionResource resource)    at CoreRCON.RCON.TCPPacketReceived(Object sender, SocketAsyncEventArgs e)    at System.Net.Sockets.SocketAsyncEventArgs.OnCompleted(SocketAsyncEventArgs e)    at System.Net.Sockets.SocketAsyncEventArgs.ExecutionCallback(Object state)    at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)    at System.Net.Sockets.SocketAsyncEventArgs.FinishOperationSuccess(SocketError socketError, Int32 bytesTransferred, SocketFlags flags)    at System.Net.Sockets.SocketAsyncEventArgs.CompletionCallback(Int32 bytesTransferred, SocketError socketError)    at System.Net.Sockets.SocketAsyncEventArgs.TransferCompletionCallbackCore(Int32 bytesTransferred, Byte[] socketAddress, Int32 socketAddressSize, SocketFlags receivedFlags, SocketError socketError)    at System.Net.Sockets.SocketAsyncContext.SendReceiveOperation.InvokeCallback()    at System.Net.Sockets.SocketAsyncContext.AsyncOperation.<>c.<QueueCompletionCallback>b__11_0(Object o)    at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)    at System.Threading.QueueUserWorkItemCallbackDefaultContext.System.Threading.IThreadPoolWorkItem.ExecuteWorkItem()    at System.Threading.ThreadPoolWorkQueue.Dispatch()
After sending RCON commands, my program crashes (after a small while) even with a couple of try catch statements. I have no idea why though.

Unfortunately this repo is basically dead, I'm sorry but I have no idea what the issue could be anymore :(

Ah, no problem. After testing I think I can safely blame .NET Core since it doesn't throw on my Windows PC, it works perfectly. On my Debian server however, it throws and uncatchable exception.


Fix the codenew shortcode where site.Params.githubWebRow is null

Fixes https://github.com/kubernetes/website/issues/12639

@tengqm fyi

/assign @ryanmcginnis

/lgtm
/approve

/lgtm
/approve

@tengqm does this need to be cherry picked into 1.13 branch too?


submariner-networkplugin-syncer pod is CreateContainerError using OVNKubernetes network plugin

What happened:
submariner-networkplugin-syncer pod is CreateContainerError when the network plugin is OVNKubernetes.
What you expected to happen:
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?:
Environment:

Submariner version (use subctl version):  v0.7.0-66-gf19ece0
Kubernetes version (use kubectl version):

$ oc version
Client Version: 4.5.2
Server Version: 4.5.11
Kubernetes Version: v1.18.3+b0068a8

Cloud provider or hardware configuration: Bare Metal
OS (e.g: cat /etc/os-release):

$ cat /etc/os-release
NAME="Red Hat Enterprise Linux"
VERSION="8.1 (Ootpa)"
ID="rhel"
ID_LIKE="fedora"
VERSION_ID="8.1"
PLATFORM_ID="platform:el8"
PRETTY_NAME="Red Hat Enterprise Linux 8.1 (Ootpa)"
ANSI_COLOR="0;31"
CPE_NAME="cpe:/o:redhat:enterprise_linux:8.1:GA"
HOME_URL="https://www.redhat.com/"
BUG_REPORT_URL="https://bugzilla.redhat.com/"

REDHAT_BUGZILLA_PRODUCT="Red Hat Enterprise Linux 8"
REDHAT_BUGZILLA_PRODUCT_VERSION=8.1
REDHAT_SUPPORT_PRODUCT="Red Hat Enterprise Linux"
REDHAT_SUPPORT_PRODUCT_VERSION="8.1"

Kernel (e.g. uname -a):

$ uname -a
Linux f24-h20-000-r630.rdu2.scalelab.redhat.com 4.18.0-147.el8.x86_64 #1 SMP Thu Sep 26 15:52:44 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Install tools:
Network plugin and version (if this is a network-related bug):

$ .subctl show all

Showing information for cluster "api-ocp4-bm482-qe-scalelab-redhat-com:6443":
    Discovered network details:
        Network plugin:  OVNKubernetes
        Service CIDRs:   [<IP_ADDRESS>/16]
        Cluster CIDRs:   [<IP_ADDRESS>/14]

CLUSTER ID                    ENDPOINT IP     PUBLIC IP       CABLE DRIVER        TYPE
bm                            <IP_ADDRESS>  <IP_ADDRESS>  libreswan           local

No resources found.

NODE                            HA STATUS       SUMMARY
worker000                       active          There are no connections

COMPONENT                       REPOSITORY                                            VERSION
submariner                      quay.io/submariner                                    devel
submariner-operator             quay.io/submariner                                    devel
service-discovery               quay.io/submariner                                    devel

Others:

$ oc get pods -n submariner-operator
NAME                                               READY   STATUS                 RESTARTS   AGE
submariner-gateway-pcfbk                           1/1     Running                0          14m
submariner-lighthouse-agent-dd78587f5-f8mvs        1/1     Running                0          14m
submariner-lighthouse-coredns-69b9d5b46f-hbx9f     1/1     Running                0          14m
submariner-lighthouse-coredns-69b9d5b46f-j86xd     1/1     Running                0          14m
submariner-networkplugin-syncer-6d644b4c45-nqfbx   0/1     CreateContainerError   0          14m
submariner-operator-cfc8f4555-ts6v9                1/1     Running                0          14m
submariner-routeagent-76zwd                        1/1     Running                0          14m
submariner-routeagent-7dbh7                        1/1     Running                0          14m
submariner-routeagent-d4bz9                        1/1     Running                0          14m
submariner-routeagent-flrwv                        1/1     Running                0          14m
submariner-routeagent-rtvqj                        1/1     Running                0          14m

# oc get pods -n submariner-operator submariner-networkplugin-syncer-6d644b4c45-nqfbx -o yaml
apiVersion: v1
kind: Pod
metadata:
  annotations:
    k8s.ovn.org/pod-networks: '{"default":{"ip_addresses":["<IP_ADDRESS>/23"],"mac_address":"6e:25:aa:81:00:13","gateway_ips":["<IP_ADDRESS>"],"ip_address":"<IP_ADDRESS>/23","gateway_ip":"<IP_ADDRESS>"}}'
    k8s.v1.cni.cncf.io/network-status: |-
      [{
          "name": "ovn-kubernetes",
          "interface": "eth0",
          "ips": [
              "<IP_ADDRESS>"
          ],
          "mac": "6e:25:aa:81:00:13",
          "default": true,
          "dns": {}
      }]
    k8s.v1.cni.cncf.io/networks-status: |-
      [{
          "name": "ovn-kubernetes",
          "interface": "eth0",
          "ips": [
              "<IP_ADDRESS>"
          ],
          "mac": "6e:25:aa:81:00:13",
          "default": true,
          "dns": {}
      }]
    openshift.io/scc: restricted
  creationTimestamp: "2020-12-02T08:05:01Z"
  generateName: submariner-networkplugin-syncer-6d644b4c45-
  labels:
    app: submariner-networkplugin-syncer
    component: networkplugin-syncer
    pod-template-hash: 6d644b4c45
  name: submariner-networkplugin-syncer-6d644b4c45-nqfbx
  namespace: submariner-operator
  ownerReferences:
  - apiVersion: apps/v1
    blockOwnerDeletion: true
    controller: true
    kind: ReplicaSet
    name: submariner-networkplugin-syncer-6d644b4c45
    uid: 38c9189e-b0be-4b3a-839a-23b090eeefeb
  resourceVersion: "157907591"
  selfLink: /api/v1/namespaces/submariner-operator/pods/submariner-networkplugin-syncer-6d644b4c45-nqfbx
  uid: d5847084-a408-4917-988a-ee6f23f81dac
spec:
  containers:
  - command:
    - submariner-networkplugin-syncer.sh
    env:
    - name: SUBMARINER_NAMESPACE
      value: submariner-operator
    - name: SUBMARINER_CLUSTERID
      value: bm
    - name: SUBMARINER_DEBUG
      value: "false"
    - name: SUBMARINER_CLUSTERCIDR
      value: <IP_ADDRESS>/14
    - name: SUBMARINER_SERVICECIDR
      value: <IP_ADDRESS>/16
    - name: SUBMARINER_GLOBALCIDR
    - name: SUBMARINER_NETWORKPLUGIN
      value: OVNKubernetes
    - name: NODE_NAME
      valueFrom:
        fieldRef:
          apiVersion: v1
          fieldPath: spec.nodeName
    image: quay.io/submariner/submariner-networkplugin-syncer:devel
    imagePullPolicy: Always
    name: submariner-routeagent
    resources: {}
    securityContext:
      capabilities:
        drop:
        - KILL
        - MKNOD
        - SETGID
        - SETUID
      runAsUser:<PHONE_NUMBER>
    terminationMessagePath: /dev/termination-log
    terminationMessagePolicy: File
    volumeMounts:
    - mountPath: /var/run/secrets/kubernetes.io/serviceaccount
      name: submariner-networkplugin-syncer-token-lw9vt
      readOnly: true
  dnsPolicy: ClusterFirst
  enableServiceLinks: true
  imagePullSecrets:
  - name: submariner-networkplugin-syncer-dockercfg-m499l
  nodeName: master-2
  priority: 0
  restartPolicy: Always
  schedulerName: default-scheduler
  securityContext:
    fsGroup:<PHONE_NUMBER>
    seLinuxOptions:
      level: s0:c25,c5
  serviceAccount: submariner-networkplugin-syncer
  serviceAccountName: submariner-networkplugin-syncer
  terminationGracePeriodSeconds: 1
  tolerations:
  - operator: Exists
  volumes:
  - name: submariner-networkplugin-syncer-token-lw9vt
    secret:
      defaultMode: 420
      secretName: submariner-networkplugin-syncer-token-lw9vt
status:
  conditions:
  - lastProbeTime: null
    lastTransitionTime: "2020-12-02T08:05:01Z"
    status: "True"
    type: Initialized
  - lastProbeTime: null
    lastTransitionTime: "2020-12-02T08:05:01Z"
    message: 'containers with unready status: [submariner-routeagent]'
    reason: ContainersNotReady
    status: "False"
    type: Ready
  - lastProbeTime: null
    lastTransitionTime: "2020-12-02T08:05:01Z"
    message: 'containers with unready status: [submariner-routeagent]'
    reason: ContainersNotReady
    status: "False"
    type: ContainersReady
  - lastProbeTime: null
    lastTransitionTime: "2020-12-02T08:05:01Z"
    status: "True"
    type: PodScheduled
  containerStatuses:
  - image: quay.io/submariner/submariner-networkplugin-syncer:devel
    imageID: ""
    lastState: {}
    name: submariner-routeagent
    ready: false
    restartCount: 0
    started: false
    state:
      waiting:
        message: |
          container create failed: time="2020-12-02T08:05:42Z" level=error msg="container_linux.go:348: starting container process caused \"exec: \\\"submariner-networkplugin-syncer.sh\\\": executable file not found in $PATH\""
          container_linux.go:348: starting container process caused "exec: \"submariner-networkplugin-syncer.sh\": executable file not found in $PATH"
        reason: CreateContainerError
  hostIP: <IP_ADDRESS>
  phase: Pending
  podIP: <IP_ADDRESS>
  podIPs:
  - ip: <IP_ADDRESS>
  qosClass: BestEffort
  startTime: "2020-12-02T08:05:01Z"

the pod is running now.

This is fixed via - https://github.com/submariner-io/submariner/pull/984


Exclude sources matching exclude_patterns

It would be useful if source files gathered by assign_entries() excluded any files matched by exclude_patterns.
It looks like we could use sphinx.util.matching.Matcher and get_matching_files() to match those patterns the same way Sphinx does. I found an example of another extension that does this here. If that sounds reasonable to you, I'd be willing to make a PR for that.
Example
Example use case (which I found completely by accident):
When building tag pages with Jupyter Notebooks, it's possible to have tags in a notebook counted twice. This is because the doctree build directory ({build_dir}/doctrees/nbsphinx/) may, depending on output format, include a copy of any .ipynb files as-is. If the build directory is under the source directory (like docs/_build), then the glob pattern in assign_entries() will match those extra files and count their tags again.
For example, for a single notebook with a tag tag_1, the generated tag page will look like this:
My tags: tag_1
##############

.. toctree::
    :maxdepth: 1
    :caption: With this tag

    ../_build/doctrees/nbsphinx/page_1.ipynb
    ../page_1.ipynb

Sounds good, thanks!


Add Json verifier

Description
This patch adds Json verifier to the list of built-in verifiers. Json verifier
can be used with symbol ':json' on file like resources such as file,
template etc.
file 'foo.json' do
  content '{"foo": "bar"}'
  verify :json
end

Related Issue
https://github.com/chef/chef/issues/12061
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

[X] I have read the CONTRIBUTING document.
[x] I have run the pre-merge tests locally and they pass.
[ ] I have updated the documentation accordingly.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.
[x] All commits have been signed-off for the Developer Certificate of Origin.

@gogsbread The last commit is missing a DCO sign off. Can you amend that with the sign off please?

@gogsbread this is sweet. Thanks for contributing this great little feature.

Thanks @gogsbread. This will go out in 17.5 shortly along with your yaml work.


Fix simple fields array

Added ability to use Filters on the first level of a field group as well.
Not quite sure how to adjust the tests for this...
Also added a simple check if the filter is added anywhere and prevented the plugin from breaking with a php exception in this case.
EDIT: I added a test to increase coverage and pass the checks, but it seems Scrutinizr has crashed? @domtra any ideas why?

Coverage decreased (-3.9%) to 90.909% when pulling e3b86ea694b14a0cdac2096829271ca394ec0118 on fix-simple-fields-array into 377758b3135b2595f00e329da78b2ceb2732bbdf on master.

Coverage decreased (-3.9%) to 90.909% when pulling 3ca2ed721f6b1a5984bed0306ab53d72af470a29 on fix-simple-fields-array into 377758b3135b2595f00e329da78b2ceb2732bbdf on master.

Coverage increased (+0.6%) to 95.455% when pulling 3235129b018b4d1ac16b62c8a7e5ace2b1ac5d8c on fix-simple-fields-array into 377758b3135b2595f00e329da78b2ceb2732bbdf on master.


Refactor query planner

No issue to close
Description
splitting QueryPlanner into separate structs
Client output
no changes to client output

Pull Request Test Coverage Report for Build 243254419

446 of 531 (83.99%)  changed or added relevant lines in 36 files are covered.
3 unchanged lines in 2 files lost coverage.
Overall coverage increased (+0.3%) to 85.477%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/query_planner/src/planner/create_table.rs
31
32
96.88%

src/query_planner/src/tests/create_schema.rs
11
12
91.67%

src/sql_model/src/sql_types.rs
17
18
94.44%

src/query_planner/src/lib.rs
20
22
90.91%

src/query_planner/src/tests/create_table.rs
49
52
94.23%

src/sql_engine/src/query/expr.rs
2
5
40.0%

src/query_planner/src/planner/delete.rs
16
20
80.0%

src/query_planner/src/planner/drop_schema.rs
13
17
76.47%

src/query_planner/src/planner/drop_tables.rs
18
22
81.82%

src/query_planner/src/planner/insert.rs
18
22
81.82%

Files with Coverage Reduction
New Missed Lines
%

src/sql_engine/src/dml/insert.rs
1
81.98%

src/sql_engine/src/query/expr.rs
2
47.24%

Totals

Change from base Build 242704171:
0.3%

Covered Lines:
6180

Relevant Lines:
7230

💛  - Coveralls


The [Bug Report] select component is set to search and cannot be retrieved by clicking the arrow in the multiple (filter) drop-down box.

Element UI version
2.4.8
OS/Browsers version
win10
Vue version
2.5.17
Reproduction Link
https://jsfiddle.net/NorthSeacoder/mte4xa82/6/
Steps to reproduce
只是添加这俩属性
What is Expected?
可以正常收起
What is actually happening?
select组件设置可搜索且为多选时（multiple，filterable）下拉框点击箭头无法收起，并且点击外部收起下拉框后再次点击展开时第一次点击无法打开

好像只要有filterable的el-select都无法点击箭头收起

https://github.com/ElemeFE/element/issues/13140#issuecomment-433279443

Duplicate of #13140


Create Set-JitLeastPrivilegedRole.ps1

Hi,
Please check this script for JIT least privileged role.
Conforming to https://docs.microsoft.com/en-us/azure/security-center/security-center-just-in-time#permissions-needed-to-configure-and-use-jit

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: elSagie sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.