All resources in Java Jacoco coverage report preview are blocked by CSP

Describe the bug
I use Jacoco plugin in gradle to generate the coverage report for JUnit tests. Line highlights works fine but when I preview the report, all style are gone and none of the links are clickable. Using dev tools it shows that all resources were blocked by CSP due to the header "default-src: 'none'" added (by VSCode? at least it is not in the index.html originally).
To Reproduce
Steps to reproduce the behaviour:

Get a project using gradle with jacoco plugin enabled. e.g. this one
Add this to the end of the build.gradle:

jacocoTestReport {
    reports {
        xml.enabled true
        csv.enabled false
        html.destination file("${buildDir}/jacocoHtml")
    }
}

For this extension setting: "coverage-gutters.coverageReportFileName": "build/jacocoHtml/index.html"
Run gradle test. It should generate the report as well.
Preview using this extension

Expected behaviour
A preview report being shown with all styles in and links clickable.
Screenshots
Screenshot for report preview (in vscode):

What it should look like in an ordinary browser:

Screenshot of dev tools:
(The default-src: 'self' is added by me to index.html manually but it does not seem to work. The original file generated by Jacoco does not have this. The first default-src: 'none' is added by VSCode.)

Desktop (please complete the following information):

OS: windows
Extension Version 2.7.2
VSCode Version 1.54.3

@fsgmhoward Thanks for submitting an issue!
This is odd that we are getting the CSP doubling here 🤔 .
We recently added our own to follow the best practices Microsoft outlines.
https://github.com/ryanluker/vscode-coverage-gutters/pull/290/files#diff-68de02f39c1df4e458757a13079e7dc64684f5f583e5c1300f7fc0f7d5c9af45R38-R47

@ryanluker Sorry for the confusion. I edited the text after I submit the issue. The CSP double is because I wanted to try whether adding CSP manually in the html files will work. The original html file does not have any CSP header and the only one added by VSCode is the none one.
So something like this:

@fsgmhoward Thanks for the extra insight, I think we can tinker with the policy to have the default src work for self 🤔 .
We recently implemented a webview helper to assist with this and it should be a pretty easy change to have the display swapped around https://github.com/ryanluker/vscode-coverage-gutters/blob/master/src/extension/webview.ts#L38 .
There might also be ways we can add more to the policy around img-src that might be more correct then modifying the default-src attribute.

Fixed in #363 and will go out in the next release.


Set default Jaccard threshold to 0.7

As discussed in #7. Also, add a CHANGES.md file so that we can keep track of changes.

I realized only now that @Leonievb has had her own branch jaccard_default with the same change, so I now rebased this branch on top of it.
I will take the existence of the branch as approval and merge this now.
@leonievb: I have started a changelog in this PR so that it should be easy to see what has changed in TREX once you get back to it.

Hey Marcel,
does that mean I can delete my jaccard_default branch? The change of the Jaccard default seems to be part of main now.
Great and thanks for the changelog!

Yes, you can delete the branch now!


#30 goes to next level before user enters the correct tag!

In level 30, it says Your app should have a text field input element.
The 'go to next challenge' button is enabled as soon as user enters <input and not <input type='text>
So user can go to next level only by typing
The button should be enabled only when user writes <input type='text>!

Thank you for catching this. I've created a PR with a fix.

PR was unconventionally merged so the auto-close didn't work. Owners, if you'll do me the honor?


ValueError: Axis limits cannot be NaN or Inf

Hi,
I've been tring to get RSAT to work for a couple of days now, but unfortunately always run into the same error when trying to plot the datafile.
Exception in Tkinter callback
Traceback (most recent call last):
  File "G:\Python379\lib\tkinter\__init__.py", line 1705, in __call__
    return self.func(*args)
  File "RSAT.py", line 58, in PlotDataSeperateBox
    plt.axis([self.dfRAWDATA.iloc[0,0]-len(self.dfRAWDATA)/60,self.dfRAWDATA.iloc[-1,0]+len(self.dfRAWDATA)/60,min(self.dfRAWDATA.iloc[:,3])-20,max(self.dfRAWDATA.iloc[:,3])+20])
  File "G:\Python379\lib\site-packages\matplotlib\pyplot.py", line 2371, in axis
    return gca().axis(*args, emit=emit, **kwargs)
  File "G:\Python379\lib\site-packages\matplotlib\axes\_base.py", line 2097, in axis
    self.set_ylim(ymin, ymax, emit=emit, auto=yauto)
  File "G:\Python379\lib\site-packages\matplotlib\axes\_base.py", line 4027, in set_ylim
    bottom = self._validate_converted_limits(bottom, self.convert_yunits)
  File "G:\Python379\lib\site-packages\matplotlib\axes\_base.py", line 3614, in _validate_converted_limits
    raise ValueError("Axis limits cannot be NaN or Inf")
ValueError: Axis limits cannot be NaN or Inf

I've tried running the code on the latest Python 3.12.2 as well as Python 3.7.9, but both produce pretty much the same error (the above is on 3.7.9). I've also installed matplotlib, pandas and tkinter as those seem to be used in the code.
I've tried to follow the manual rigorously when it comes to the data file formatting and I've tried multiple ways of formatting my file always ending up with the same error. My best effort can be fould within the RSAT_Shaibuli.zip -file. I would really like to encourage @HMEUW to continue with the documentation work he's been doing, as the user manual could do with some 'for dummies' type of explanation. e.g. a screen capture of the correct data formatting and a picture/illustration on what the different slug test characteristics actually match. Maybe I can even get into helping him at some point, if I get a better hang of things first.
My github and python skills are novice at best, so it might turn out that the solution is something really simple and stupid. It's really unfortunate, however, that it seems so hard for a noobie to get this working. The world of hydrogeology could really do with a freely accessible, quality tool for slug test interpretation as slug-tests themselves are a pretty great minimum-budget method for e.g. developing nations to do basic hydrogeological characterisation.
Thank you!

Hi Shaibuli. Thanks for mentioning me.
In the mean time I worked a lot on slugtest execution and interpretation. I didn't spend time in the RSAT functions. I have plans to share the functions with the world, but decided first to develop these.

Hi Shaibuli.
I agree with you on the value of an open source repository which is able to handle the Hvorslev approach (which potentially RSAT could be).
You might take a look at TTim with the well-documented slugtest example Pratt County. Although this is not exactly what you ask for, this might help you to get a first estimate of your conductivity while also being able to experiment with Python.


ACM-12701 Add required --base-domain option to AWS HostedCluster command

https://issues.redhat.com/browse/ACM-12701

Add required --base-domain option to AWS HostedCluster command

@rokej Maybe you can review this one, since there's no UI code change, just text change.

/cherrypick release-2.11


Add BinderTransport example app

This commit adds an app that will be served as BinderTransport example
later.
Currently the app simply calls C++ function when button is pressed. In
the future the C++ function will run BinderTransport gRPC example
instead.
Tests not included in this commit, later we will add a build test to
CI to make sure this apk is always build-able. (This app will also be used to make sure our BinderTransport implementation is compile-able with Android toolchain, on GitHub)
Changes are made to WORKSPACE file in order to support android builds.
Build instructions are documented at
examples/android/binder/java/io/grpc/binder/cpp/example/README.md
@nicolasnoble
@markdroth
@TaWeiTu
@napathome

Force pushed. Excluding this target in basic build test

I think we will want to have a separate non-blocking build test for our Android apk target. What do you guys think?

"Interop Cloud-to-Prod Tests (internal CI)" is a known CI failure #26595

TaWei can you help give a review and see if we can proceed to merge this?

Overall looks good as long as it doesn't break CI and the build system.

Yeah all CI tasks passed except the one I mentioned in https://github.com/grpc/grpc/pull/26747#issuecomment-886666794

We briefly discussed this PR in chat. I think it is ok to merge as long as it passes CI.
Several CI checks looks flaky though, let me force-push to trigger rerun again to see if they pass or not

Looks like Basic Tests C# Windows and Basic Tests Python Linux still timeouts. Since I have seen them passed in this pull request in previous run, let's assume it is not related to this change.


Adapter code for pune- flood data

Handled the conflicts of <= and >= in attribute query, hence resolved the multi value attribute query issue.


Improve Information Available in Recent Transactions List

I would like to be able to see additional information from the paid invoices stored in my recent transactions list.
Currently each paid invoice is displayed in a collapsed and expanded view.
Collapsed: I see 1. a circle with a minus sign in it (which makes me think I didn't pay the invoice or it failed or something), 2. "Alby" and the amount sent in bold on the top, and 3. "Sent" and time since payment sent
Expanded: I see 1. The preimage of the invoice, and 2. A raw "chrome-extension" link which on clickthrough opens alby's chrome extension as a new tab with the invoice data prompting me to pay the invoice (even if it's already paid) or pay to the LNURL if it's an LNURL.
Thoughts:

The white circle with the minus sign in it makes me think that I didn't pay the invoice, and when I click on the invoice it pops up as a standard invoice screen allowing me to pay it again. This is confusing: If the bolt11 invoice is in the recent transactions list it has already been paid, so clicking through it should give me additional information about the invoice like description, recipient, maybe some of the routing info, not prompting to pay it again.
In the expanded view I see a raw link and the preimage. I can't think of a situation where the preimage would be all that useful to see without the larger context of the rest of the invoice, so I think that should be swapped out with the invoice's description section. Clicking through the link should bring me to a page with additional information about the invoice (because it's already been paid) instead of to a page prompting me to try paying the invoice again.

I think the transaction list was improved a lot since this issue was opened. Maybe this issue can be closed? Thanks.

@bitcoinuser Thanks, yeah I think those things have drastically improved with the recent releases and Kody's points have been addressed.


[Documentation] Assets put into src/assets are not copied over

Assets put in src/assets (as in documentation) are not copied to www.
There's a config/index.js though where we can manipulate the output.

assetsSubDirectory: 'static',

Maybe you should mention that in the docs (and fix the docs in this regard).

I placed my images in static folder and then build www and copied it to Cordova project. However, after cordorva build android the images are missing when apk is installed. Am I missing any step?


Code refactoring

Faster and smaller (for minification) matches detecting and smaller loop.

@jonathantneal  Take a look ASAP, please.

Next release, please.


initial changes for supporting load balancing

Mendel will hit a load balancer api endpoint that is responsible for removing/inserting a service from/into it's load balancer.
Some services are publicly exposed, so api keys are required in order for those load balancer endpoints to work. Users can add their load balancer api key to ~/.mendel.conf
Some services listen to ports other than 8080 so we'll have to add a mapping from host -> port in the mendel.yml file.

👍


Fixed one small issue for BootstrapTable.js

int componentWillReceiveProps functions
Add checking code
if (nextProps.data === undefined) {
return;
}
Before
this.store.setData(nextProps.data.slice());

Thank you.
我思故我在
On 07/08/2017 17:58, Allen wrote:
@AllenFang requested changes on this pull request.
In src/BootstrapTable.js:

@@ -215,6 +215,9 @@ class BootstrapTable extends Component {
let { replace } = nextProps;
replace = replace || this.props.replace;

if (nextProps.data === undefined) {

try following instead
if (!nextProps.data) {
return;
}
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Release on v3.4.5 thanks your contribution


Improve Git clone perfomance

It looks like we are fetching all the code in getCode.py
We should set a depth of one - see this stackoverflow article.
It is a bit of a redesign since you can pass in a branch as a parameter.

Resolved with PR #64


Implement Workspaces for AWS Managed Service for Prometheus (AMP)

What resource do you need?
AWS Managed Service for Prometheus (AMP) is a managed prometheus offering
CRUD operations for Workspaces are missing in provider-aws
What is your use case?
Storing metrics from Kubernetes workloads in a managed database
Would you be willing to contribute it using code generator?
yes, however the current version of the aws-sdk-go in crossplane doesn't implement Tags<EMAIL_ADDRESS>A newer version of the aws-sdk-go is necessary to suppport tags: https://github.com/crossplane/provider-aws/pull/918

implemented with #1054


Newsletter-230:Japanese translation fixup

I didn't make it to the review, but I hope this PR will improve the translation.

Fix typos.
Change to more appropriate word.
Add words to close sentence.

ACK. Thanks @AkioNak .


Add support for .NET 9

warning NU1608: Detected package version outside of dependency constraint: JasperFx.RuntimeCompiler 3.5.0 requires Microsoft.Extensions.Logging.Abstractions (>= 6.0.0 && < 9.0.0) but version Microsoft.Extensions.Logging.Abstractions 9.0.0 was resolved.

It's funny how 9.0.0-rc1 was lower (<) than 9.0.0
Maybe when doing the migration to support .Net 9, choose < 9.99.99 to meaning < 10 AND < 10.0.0-preview... so that it will fail even with version 10 preview/rc

And it seems this doc is not 100% accurate: https://learn.microsoft.com/en-us/nuget/concepts/package-versioning?tabs=semver20sort#semantic-versioning-200

https://bsky.app/profile/did:plc:af62br4qi2dl43eogb3jqimk/post/3laqr57pvm227

https://bsky.app/profile/did:plc:af62br4qi2dl43eogb3jqimk/post/3laqr57pvm227

Faire enough :)
https://github.com/JasperFx/jasperfx/pull/18 but absolutely not sure I got everything right

@tomap Hey, that's not actually used by Marten yet. That codebase is for Marten 8 / Wolverine 4

Thanks for the update. Will you be updating the version of JasperFx.RuntimeCompiler?


deactivate TLSv1 by default

Hi,
today I've seen that TLS 1.0 and 1.1 is on by default under web/mattermost-ssl
ssl_protocols TLSv1 TLSv1.1 TLSv1.2;
I recommend to reject at least TLSv1. Would be nice if we could edit it in the docker-compose.yml.

I'm okay to remove TLS1.0 since it seems that TLS1.1 is widely supported. If you have some others suggestions to improve TLS security on the web image I'll be happy to hear about them.
Would you like to submit a PR ? If yes, fell free to submit. Otherwise I can make the change.

Thanks, but you can make the change.
As I don't use the standard HTTPS port SSLLabs doesn't work for me to check for further vulnerabilities.
A recommendation (for a TLS1.2 config):
ssl_ciphers ECDHE-ECDSA-CHACHA20-POLY1305:ECDHE-ECDSA-AES128-GCM-SHA256:ECDHE-ECDSA-AES128-SHA;
There is a huge explanation why these and why this order. Mozilla gives some information about this too.
Mozilla
and here you have a generator:
https://mozilla.github.io/server-side-tls/ssl-config-generator/
Enabling HSTS would also be something to think about it. But that can be annoying with cert problems so I don't recommend it for this project.

a little update from my side. I will update my container to 5.0 soon and then test some "casual" security configurations without TLSv1 and then some stronger configurations. Then I test it some weeks (colleagues will be my Guinea pigs) and then you will hear from me again with a proper tested working config.

security > interoperability
drop everything but v1.2, let the unfortunate souls misconfigure their servers on their own

TLSv1.3 support has just been added to nginx on Alpine.

We will probably deprecate the web image with #366


Android-Kotlin : 09.6 Nested RecyclerView in Android (Kotlin)

Description 📜

Give a step-by-step tutorial of Nested RecyclerView in Android (Kotlin).
Required Documentation or Video or Audio.

Domain of Contribution 📊

[x] Android Dev (Flutter, Java, Kotlin)

References :

https://medium.com/nerd-for-tech/nested-recyclerview-in-android-e5afb2b9771a

Please Read it Carefully Before Contributing

Changes should be made in Android_Development_With_Kotlin/ directory under Android_Development_With_Kotlin branch.
Inside Android_Development_With_Kotlin/ directory creates a directory and names it according to the topic ( for this issue 09. Dynamic User Interface)
Inside 09. Dynamic User Interface/ directory add your task with subtopic number and name and make changes accordingly.
You have to push your PR to the Android_Development_With_Kotlin branch only.
You can take help to the references but don't simply try to copy it. Just explain in your own word.
This issue is for GWOC'21 contributors only.
You need to push in a single commit. If there exists more than one commit then you need to squash your commits into one commit.
Will assign you on a first come first serve basis.
Please try to complete your assigned task within 7 days. If you need some more time then, please inform mentors and supervisors.
If you have two previously assigned issues on Android-Kotlin pending then please first complete them.

Supervisor @rahulsain

Happy Contributing. Best of Luck.💖

/assign

I am going to make a Documentation on this issue - #1407


Problem on SelfDescribingJson java.lang.VerifyError

I'm integrating snowplow-android-tracker with my app. The emitter and tracker are ok, but when i call the SelfDescribingJson the app crash.
Map<String, String> attributes = new HashMap<>();
attributes.put("campaingID", "1");

SelfDescribingJson myContext = new SelfDescribingJson("iglu:myurlschema/jsonschema/1-0-0",
                attributes);

Error
java.lang.VerifyError: com/snowplowanalytics/snowplow/tracker/utils/payload/SelfDescribingJson
at com.myapp.adBoard(ReportIVC.java:22)

my gradle
    compile fileTree(dir: 'libs', include: ['*.jar'])
    compile 'com.android.support:appcompat-v7:19.+'
    compile 'com.koushikdutta.ion:ion:1.+'
    compile 'com.google.android.gms:play-services:4.0+'
    compile 'com.github.satyan:sugar:+'
    compile 'com.squareup.retrofit:retrofit:1.6.1'
    compile 'com.squareup.okhttp:okhttp:2.0.0'
    compile 'com.squareup.okhttp:okhttp-urlconnection:2.0.0'
    compile 'com.snowplowanalytics:snowplow-android-tracker:0.3.0'
    compile 'com.netflix.rxjava:rxjava-core:0.+'
    compile 'com.netflix.rxjava:rxjava-android:0.+'

Hi @gianrubio, have not seen this error before personally but my first thought would be that there might be a missing dependency in your gradle file.  The SelfDescribingJson class is dependent on the following import:
https://github.com/snowplow/snowplow-android-tracker/blob/master/snowplow-android-tracker/build.gradle#L71
Could you try adding that line and seeing if it will get you past that error?

Hi @jbeemster, I am having the same problem, in my gradle file the import of Jackson JSON processor was already added.
java.lang.VerifyError: com/snowplowanalytics/snowplow/tracker/utils/payload/SelfDescribingJson

Hi @thiagogermoliato could you please paste the stack trace and your gradle build file and I will see if I can reproduce and resolve.

@thiagogermoliato I'm suspecting it's something related to conflicting versions of the Jackson JSON Processor on your classpath, maybe as a dependency for another library. Would help a lot to know what libraries you're using and  also to have a detailed stack trace as @jbeemster mentioned.

@gianrubio  did you solve this? I am getting the same issue.

@jbeemster  the problem is that the following two lines in my gradle file are conflicting as the jackson library is already added in the snowplow tracker
compile 'com.snowplowanalytics:snowplow-android-tracker:0.3.0'
compile 'com.fasterxml.jackson.core:jackson-databind:<IP_ADDRESS>'

Hey @MoizAli thanks for debugging that!  So if the conflicting dependency is updated the error goes away?

This is resolved now as the dependency has been removed from the library.


Updating to more secure dependencies, adding JUnit5 test

Please note that there are A LOT of overrides of the shaded ext jar to bring things up to standards

All updates have been backed out EXCEPT for updating to appd-ext-commons 2.2.13. Still built and tested against Java 1.8, and has no additional dependencies outside of commons.


afc: Fix incorrect memory allocation

It seems to work correctly now with my own tests.

Thanks! Once I get another iOS device I'll have to run valgrind over all this.


Revert not working

if set to min 100 and to max 0, handler not working

Use min 0, max 0, and the invert prop.


Firefox version

Hello @Sneezry,
This is such a cool project!
Is there any chance we get to see this for Firefox?

I ported it to Firefox at mymindstorm/authenticator
@Sneezry is it ok if I submit this to https://addons.mozilla.org?

@mymindstorm sure, nice job!

Here's the listing! I didn't expect it to get approved so fast, so it's a bit bare currently.

Shared it on Reddit. :-)
https://www.reddit.com/r/firefox/comments/7e7n46/authenticator_is_a_very_cool_new_addon_for_2/


Use 5 Moon emoji icons for the backlight module

This is a simple commit which adds the backlight icons that polybar uses to the default config. These emojis have a scale from 0-4 (4 being full), so it provides greater accuracy than the simple 0-1 scale that was there before.

Shouldn't this array be inversed?

@Synthetica9 Yup, you're right.


⚠ Bofrost.at has degraded performance

In 23abfcc, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1908 ms

Resolved: Bofrost.at performance has improved in 9562837 after 12 minutes.


No warning if missing a @required parameter in an overridden method

I would expect that I have to declare @required parameters only in the base class and not to repeat them in a derived class when overriding a method. Or optionally do not allow an overridden method signature to be different.
import 'package:meta/meta.dart';

void main() {
  final A b = B();
  // this results a warning "The paremeter 'i' is required" (correct)
  b.func();

  final B b2 = B();
  // this DOES NOT give a warning as it should
  b2.func();

  final b3 = B();
  // this DOES NOT give a warning as it should
  b3.func();
}

abstract class A {
  void func({@required int i});
}

class B implements A {
  @override
  void func({int i}) {
  }
}

Environment:
Dart 2.1.2 (build 2.1.2-dev.0.0 0a7dcf17eb)
Windows/VS Code

It makes sense to allow a subclass to make a required superclass argument optional.
Example:
class Super {
  void doIt(int number) { ... }
}
class Sub extends Super {
  @override
  void doit([int number = 42]) { ... }
}

This is a valid override in plain Dart, it makes a positional required super-class method parameter into an optional parameter in the subclass.
So, when @required is used to mark a named parameter as required, it also makes sense to allow a subclass to make that parameter optional, which is what omitting the @required means.
Automatically inheriting the @required would prevent subclasses from doing so.

Yes I agree on that. But I think my example is slightly different because the super-class method is abstract (it does not contain a method body).
Does it make sense that in an abstract method declaration a parameter is declared as required but then you would allow making it optional in the actual implementation of the method? In my opinion that does not make sense.
I have two (optional) improvement ideas:

If an abstract method has a @required parameter, derive it automatically to the method implementation. Do this only for abstract methods and only if it is the first override (in a class tree) of an abstract method.

Show a warning if an overridden method signature does not match exactly the signature of the super-class abstract method.

Or introduce something like @unoverridablyRequired. ;)

The @required annotation is being replaced by the required keyword, available in Dart 2.12, in the Null safety language feature.


Pasting link containing capital letters in the terminal is dropping the capital letters

Windows Terminal version
1.11.3471.0
Windows build number
10.0.19043.0
Other Software
No response
Steps to reproduce
I am trying to clone a git repo.
Here is the URL git clone<EMAIL_ADDRESS>When I paste this URL in the windows terminal having Windows PowerShell it just drops the capital letters of the URL. So upon pasting the above URL becomes<EMAIL_ADDRESS>Notice the missing M and N
Expected Behavior
On pasting it should paste the whole copied string.
Actual Behavior
When I paste this URL<EMAIL_ADDRESS>in the windows terminal having Windows PowerShell it just drops the capital letters of the URL.

Thanks for the suggestion! Please make sure to search for duplicates when filing new issues. This is already being tracked by another issue on our repo - please refer to #7087 for more discussion.
From that thread: https://github.com/microsoft/terminal/issues/7087#issuecomment-676782357

Found a fix. If you have the same problem as me, then updating PSReadLine to the latest preview version can help you. Check out this https://github.com/PowerShell/PowerShell/issues/10794 and this PowerShell/PSReadLine for more information.

/dup https://github.com/PowerShell/PowerShell/issues/10794

Thankyou @zadjii-msft for pointing me to the solution. The issue was with PowerShell/PSReadLine.
Here is how I resolved this

Running the following commands from an elevated (Run as Administrator) Windows PowerShell session:

Install-Module -Name PowerShellGet -Force
Exit

After installing PowerShellGet, get the latest prerelease version of PSReadLine by running

Install-Module PSReadLine -AllowPrerelease -Force


Validation message to check balance is not shown when user taps on Withdraw button even though user does not have enough balance.

Frequency: 100%
Repro on build version: Test Flight build v1.5.0 (29)
Repro on devices: iPhone XR (13.2.2) , iPhone 11 (14.0)
Testing Account:<PHONE_NUMBER> / Backup Key
Pre-condition:
launch the deeplink celo://wallet/pay?address=0xd13eee43e38f65fe3839bef6297928b43de38a02&amount=.1&token=CELO
Make sure user doesn't have enough CELO balance
Repro Steps:

Launch the application & login with a test account.
Copy the given link and paste to Safari browser.
Tap on Open button from "Open this page to valora" pop up
Make sure the Withdraw CELO screen is open.
Tap on the Withdraw button.

Current Behaviour:  No validation message and nothing happens when the user taps on withdraw button
Expected Behaviour: Users should see a validation message to check balance.
Impact: User will get the idea of what went wrong.
Attachment: IOS_NoValidationMessage.mp4	(Bug Observed at 12 sec)

Hey @MuckT we have verified the above issue on latest iOS testflight release build V:1.29.2 and observed that "Transaction failed please retry " alert is seen if we try to send more CELO token than the balance available in the account hence we are closing this issue
Note : Currently on deep linking the above URL , it is redirecting to send amount page (Since sending of CELO token is supported via multitoken flow)
attachment : alert
Thanks..!!


ci(PullApprove): adding Pull Approve to the project

Approved!

Codecov Report

Merging #3 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master       #3   +/-   ##
=======================================
  Coverage   95.23%   95.23%
=======================================
  Files           3        3
  Lines          21       21
=======================================
  Hits           20       20
  Misses          1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 416bb53...40e86f1. Read the comment docs.


line 3: [: !=: unary operator expected

Using contains on any inputs like so
    - name: Container should contain new image version
      uses<EMAIL_ADDRESS>      with:
        command_line: ls
        contains: deployment.yaml
        expected_result: PASSED

results in

Hi @JonathanAtCenterEdge , how are you doing? 😄
Thank you for opening this issue!
I observed a bug setting the output value in the script, could you please try again using the @v2.2 action version?
    - name: Container should contain new image version
      uses<EMAIL_ADDRESS>      with:
        command_line: ls
        contains: deployment.yaml
        expected_result: PASSED


Download link not opening unless you "open in new tab"

I have found the issue causing this, but it cannot be fixed unless I remove jquery.singlePageNav.min.js. The issue is, if I remove this all of the images get deleted and makes the site look very weird and uncolorful. Which makes people think its a virus ngl

Fixed, Added button, and added direct downloading. Button is more visible to people, and easier to download.


try coverity with travis

This change is

[Current coverage][cc-pull] is 28.86%

Merging [#42][cc-pull] into [master][cc-base-branch] will not change coverage

@@             master        #42   diff @@
==========================================
  Files            35         35
  Lines          1379       1379
  Methods           0          0
  Messages          0          0
  Branches        174        174
==========================================
  Hits            398        398
  Misses          945        945
  Partials         36         36

Powered by Codecov. Last updated by [6d00020...85b3fd8][cc-compare]
[cc-base-branch]: https://codecov.io/gh/KostyaSha/yet-another-docker-plugin/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/KostyaSha/yet-another-docker-plugin/compare/6d000205c29306296fabe2cc47ee4a0c810368ec...85b3fd8cf903b407b194a498e9292fdd7360195c
[cc-pull]: https://codecov.io/gh/KostyaSha/yet-another-docker-plugin/pull/42?src=pr


vSphere + Docker-Machine + Swarm + docker-volume-vsphere

Hello,
I'm using docker-machine to provision VM as swarm nodes.
I saw there is a VMware Photon OS which should be "optimized" for the vSphere environment.
I will try to see if I can provision VM with Photon using docker-machine (not tried yet).
Also, I was wondering if there is any preconfigured image (Photon OS or other), which comes preconfigured with docker-volume-vsphere ?
The idea is to build a docker swarm cluster on vSphere using docker-machine, and have the docker-volume-vsphere plugin available immediately.
Thanks!

@blop You can have docker volume plugin installed in OVF/OVA image that you use with docker-machine driver. Alternatively, you can install docker-volume-plugin during startup with following simple command;
docker plugin install --grant-all-permissions --alias vsphere vmware/docker-volume-vsphere:latest

This is already tracked by issue #634

We have decided not to fix issue #634.


Another rebase

shouldn't be too bad this time around

gentle ping; I expect another round will be needed before long

Thanks. May want @-mention me on these, though we don't have too many remaining hopefully.


Fail to deploy a kubeadm cluster with calico

I'm following the following guide:
http://docs.projectcalico.org/v2.3/getting-started/kubernetes/installation/hosted/kubeadm/
to deploy a k8s cluster with calico, through kubeadm, and the calico-node pod fails to start
Expected Behavior

I'd expect the calico pods to start.
Current Behavior

Both the calico-node and the calico-policy-controller fail to start:
root@k8s-master:~# kubectl get pods --all-namespaces -o wide
NAMESPACE     NAME                                        READY     STATUS    RESTARTS   AGE       IP             NODE
kube-system   calico-etcd-jllmx                           1/1       Running   0          47m       <IP_ADDRESS>   k8s-master
kube-system   calico-node-lpkq1                           1/2       rpc error: code = 2 desc = container create failed: container_linux.go:265: starting container process caused "chdir to cwd (\"/opt/cni/bin\") set in config.json failed: no such file or directory"
              0                                           46m       <IP_ADDRESS>        k8s-master
kube-system   calico-policy-controller-1324707180-vgzj5   0/1       CrashLoopBackOff    14        46m       <IP_ADDRESS>   k8s-master
kube-system   etcd-k8s-master                             1/1       Running             0         47m       <IP_ADDRESS>   k8s-master
kube-system   kube-apiserver-k8s-master                   1/1       Running             0         47m       <IP_ADDRESS>   k8s-master
kube-system   kube-controller-manager-k8s-master          1/1       Running             0         47m       <IP_ADDRESS>   k8s-master
kube-system   kube-dns-3913472980-t95mg                   0/3       ContainerCreating   0         47m       <none>         k8s-master
kube-system   kube-proxy-3qhds                            1/1       Running             0         47m       <IP_ADDRESS>   k8s-master
kube-system   kube-scheduler-k8s-master                   1/1       Running             0         46m       <IP_ADDRESS>   k8s-master

When looking at the logs:
calico-node logs
root@k8s-master:~# kubectl logs calico-node-lpkq1 -c install-cni -n kube-system
Error from server (BadRequest): container "install-cni" in pod "calico-node-lpkq1" is waiting to start: rpc error: code = 2 desc = container create failed: container_linux.go:265: starting container process caused "chdir to cwd (\"/opt/cni/bin\") set in config.json failed: no such file or directory"

calico-policy-controller logs
root@k8s-master:~# kubectl logs calico-policy-controller-1324707180-vgzj5 -n kube-system
2017-06-14 10:20:29,274 6 INFO Configuring /etc/hosts
Traceback (most recent call last):
  File "<string>", line 559, in <module>
  File "<string>", line 535, in configure_etc_hosts
IOError: [Errno 30] Read-only file system: '/etc/hosts'
controller returned -1

Some more information:
root@k8s-master:~# kubeadm version
kubeadm version: version.Info{Major:"1", Minor:"7+", GitVersion:"v1.7.0-alpha.0.1163+5e29e1ee055568", GitCommit:"5e29e1ee05556800cd2fe0dc5341d5de54b4ab47", GitTreeState:"clean", BuildDate:"2017-03-13T22:37:31Z", GoVersion:"go1.7.5", Compiler:"gc", Platform:"linux/amd64"}
root@k8s-master:~# kubelet --version
Kubernetes v1.6.4

Steps to Reproduce (for bugs)

kubeadm init --pod-network-cidr <IP_ADDRESS>/16
kubectl apply -f http://docs.projectcalico.org/v2.3/getting-started/kubernetes/installation/hosted/kubeadm/1.6/calico.yaml

Your Environment

Operating System and version: Ubuntu 16.04

cc @gtirloni @runcom

stupid guess:
since we don't ship /opt/cni/bin when we install CRI-O
could you mkdir /opt/cni/bin before deploying calico and see if it works?
I suspect that's just about it and we need to fix something about it in CRI-O (installation maybe)

        # This container installs the Calico CNI binaries
        # and CNI network config file on each node.
        - name: install-cni
          image: quay.io/calico/cni:v1.9.1
          command: ["/install-cni.sh"]
          env:
            # The location of the Calico etcd cluster.
            - name: ETCD_ENDPOINTS
              valueFrom:
                configMapKeyRef:
                  name: calico-config
                  key: etcd_endpoints
            # The CNI network config to install on each node.
            - name: CNI_NETWORK_CONFIG
              valueFrom:
                configMapKeyRef:
                  name: calico-config
                  key: cni_network_config
          volumeMounts:
            - mountPath: /host/opt/cni/bin
              name: cni-bin-dir
            - mountPath: /host/etc/cni/net.d
              name: cni-net-dir
      volumes:
        # Used by calico/node.
        - name: lib-modules
          hostPath:
            path: /lib/modules
        - name: var-run-calico
          hostPath:
            path: /var/run/calico
        # Used to install CNI.
        - name: cni-bin-dir
          hostPath:
            path: /opt/cni/bin
        - name: cni-net-dir
          hostPath:
            path: /etc/cni/net.d

this may be causing this for sure, I'm debugging this

this seems an issue with the image config and the kube yaml:
          volumeMounts:
            - mountPath: /host/opt/cni/bin
              name: cni-bin-dir
            - mountPath: /host/etc/cni/net.d
              name: cni-net-dir

calico's saying to mount host's /opt/cni/binto /host/opt/cni/bin
the image quay.io/calico/cni:v1.9.1 has the following config:

        "Config": {
            "Hostname": "971d7095b61b",
            "Domainname": "",
            "User": "",
            "AttachStdin": false,
            "AttachStdout": false,
            "AttachStderr": false,
            "Tty": false,
            "OpenStdin": false,
            "StdinOnce": false,
            "Env": [
                "PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/opt/cni/bin"
            ],
            "Cmd": [
                "/opt/cni/bin/calico"
            ],
            "ArgsEscaped": true,
            "Image": "sha256:360798ae26ad48e6cc6ca16a612269a414b98608a40b48b83553cd0102ec2c69",
            "Volumes": {
                "/opt/cni": {}
            },
            "WorkingDir": "/opt/cni/bin",
            "Entrypoint": null,
            "OnBuild": [],
            "Labels": {}
        },

which means the container will start with a /opt/cni path in the container fs, but the WorkingDir says to chdir to /opt/cni/bin which isn't there and fails. So, I suspect /host/opt/cni/bin should just be /opt/cni/bin? or the image WorkingDir should be /host/opt/cni/bin

calico 2.0 was indeed mounting to /opt/cni/bin https://github.com/projectcalico/calico/blob/c9f32f7999331cdf1458fbed3ec3f84aa925a698/v2.0/getting-started/kubernetes/installation/hosted/calico.yaml#L195-L198 but is was also using another image https://github.com/projectcalico/calico/blob/c9f32f7999331cdf1458fbed3ec3f84aa925a698/v2.0/getting-started/kubernetes/installation/hosted/calico.yaml#L165
seems like a configuration issue :confused:

@sameo could you try with this patch applied on top of kube-1.6.x:
diff --git a/server/container_create.go b/server/container_create.go
index 3eb9125..7f493e8 100644
--- a/server/container_create.go
+++ b/server/container_create.go
@@ -318,10 +318,6 @@ func (s *Server) createSandboxContainer(ctx context.Context, containerID string,
        specgen := generate.New()
        specgen.HostSpecific = true

-       if err := addOciBindMounts(sb, containerConfig, &specgen); err != nil {
-               return nil, err
-       }
-
        if err := addDevices(sb, containerConfig, &specgen); err != nil {
                return nil, err
        }
@@ -595,6 +591,10 @@ func (s *Server) createSandboxContainer(ctx context.Context, containerID string,
                specgen.AddTmpfsMount(dest, destOptions)
        }

+       if err := addOciBindMounts(sb, containerConfig, &specgen); err != nil {
+               return nil, err
+       }
+
        processArgs, err := buildOCIProcessArgs(containerConfig, containerImageConfig)
        if err != nil {
                return nil, err

Should be a bug in cri-o, assuming Docker is working

@runcom yes, I had Calico working with Docker 1.12 and K8s 1.6.4.
On CentOS, the kubernetes-cni package (from the official kubernetes repository) provides /opt/cni
# rpm -ql kubernetes-cni
/opt/cni
/opt/cni/bin
/opt/cni/bin/bridge
/opt/cni/bin/cnitool
/opt/cni/bin/dhcp
/opt/cni/bin/flannel
/opt/cni/bin/host-local
/opt/cni/bin/ipvlan
/opt/cni/bin/loopback
/opt/cni/bin/macvlan
/opt/cni/bin/noop
/opt/cni/bin/ptp
/opt/cni/bin/tuning

# rpm -qi kubernetes-cni
Name        : kubernetes-cni
Version     : 0.5.1
Release     : 0
Architecture: x86_64
Install Date: Tue 04 Apr 2017 12:36:41 AM UTC
Group       : Unspecified
Size        : 29271616
License     : ASL 2.0
Signature   : RSA/SHA1, Tue 28 Mar 2017 11:47:02 PM UTC, Key ID f09c394c3e1ba8d5
Source RPM  : kubelet-1.6.0-0.src.rpm
Build Date  : Tue 28 Mar 2017 11:45:31 PM UTC
Build Host  : 81559a81666f
Relocations : (not relocatable)
URL         : https://kubernetes.io
Summary     : Binaries required to provision kubernetes container networking

I'm working on something else at the moment but tomorrow I should be able to fire up another cluster running cri-o to check this again.

@runcom After applying the patch I still see the same error

I'm trying to reproduce using the image directly, will report soon

The install-cni.sh only installs the cni binaries and the config file that kubernetes will use when calling CNI.  So yes the /host/opt/cni/bin location in the calico/cni container does not match the config file but that does not matter because the config file will not be used in the container but on the host system.  So you should be able to check (after install-cni.sh initially runs) that there should be the cni binaries (calico,calico-ipam, and a few others) in /opt/cni/bin and the config file at /etc/cni/net.d/10-calico.conf.
Is there still an issue to look at here? That "Fix calico" issue linked seems to indicate not.
If there is still an issue I had the following thought.  I saw the suggestion to create /opt/cni/bin before installing calico, and then it looks like you found that the directory should already exist. It looks like you are using CentOS so I'm wondering if you have SELinux preventing access to that directory.

sorry guys, it seems the issue was on our end. Give us some more mins to test it out and we'll probably close this, thanks a lot!

Yes, it's a CRI-O issue. Closing this one.


Authorizer name must be unique. Authorizer already exists in this RestApi

I have a serverless.yml that looks like
service: myapp-${opt:stage, self:provider.stage}

custom:
  serverless-offline:
    port: 3001
  myStage: ${opt:stage, self:provider.stage}
  myEnvironment:
    ENV_VAR:
      DEV: "dev value"
      PROD: "prod value"
  output:
    file: ../controller/constants/application-aws.json # toml, yaml, yml, and json format is available

plugins:
  - serverless-offline
  - serverless-plugin-typescript
  - serverless-aws-alias
  - serverless-stack-output

provider:
  name: aws
  runtime: nodejs10.x
  stage: DEV
  region: ap-southeast-1
  profile: myprofile
  environment:
    ENV_VAR: ${self:custom.myEnvironment.ENV_VAR.${self:custom.myStage}}

resources:
  - ${file(../resources/cognito-resource.yml)}

functions:
  hello:
    description: 'Says Hello'
    handler: functions/handler.hello
    events:
      - http:
          method: GET
          path: /hello
          authorizer:
            type: COGNITO_USER_POOLS
            authorizerId:
              Ref: ApiGatewayAuthorizer
          cors:
            origin:
              - '*'
            headers:
              - Content-Type
              - X-Amz-Date
              - Authorization
              - X-Api-Key
              - X-Amz-Security-Token
              - X-Amz-User-Agent
            allowCredentials: true

cognito-resource.yml looks like
Resources:
  CognitoUserPool:
    Type: AWS::Cognito::UserPool
    Properties:
      # Generate a name based on the stage
      UserPoolName: cognito-userpool-${self:custom.myStage}
      # Set email as an alias
      UsernameAttributes:
        - email
      Policies:
        PasswordPolicy:
          MinimumLength: 6
          RequireLowercase: False
          RequireNumbers: False
          RequireSymbols: False
          RequireUppercase: False

  CognitoUserPoolClient:
    Type: AWS::Cognito::UserPoolClient
    Properties:
      # Generate an app client name based on the stage
      ClientName: cognito-userpoolclient-${self:custom.myStage}
      UserPoolId:
        Ref: CognitoUserPool
      GenerateSecret: false

  ApiGatewayAuthorizer:
    DependsOn:
      - ApiGatewayRestApi
    Type: AWS::ApiGateway::Authorizer
    Properties:
      Name: cognito-authorizer
      IdentitySource: method.request.header.Authorization
      RestApiId:
        Ref: ApiGatewayRestApi
      Type: COGNITO_USER_POOLS
      ProviderARNs:
        - Fn::GetAtt: [CognitoUserPool, Arn]

# Print out the Id of the User Pool that is created
Outputs:
  UserPoolId:
    Value:
      Ref: CognitoUserPool
  UserPoolClientId:
    Value:
      Ref: CognitoUserPoolClient
  CognitoUserPoolArn:
    Value:
      Fn::GetAtt:
        - CognitoUserPool
        - Arn
    Export:
      Name: CognitoUserPoolArn-${self:custom.myStage}

and when I run sls deploy --alias my_name I get the error:
An error occurred: ApiGatewayAuthorizermy_name - Authorizer name must be unique. Authorizer cognito-authorizer already exists in this RestApi. (Service: AmazonApiGateway; Status Code: 400; Error Code: BadRequestException; Request ID: 79c6f96b-855e-44d1-8e96-3862bc3577bf).

@HyperBrain Is my set up correct or is this an issue with serverless-aws-alias?

All the resources must be unique per stage/alias. As I can see, you've already deployed the main stage with sls deploy or sls deploy --stage your-stage, so that you have created all the resources and now you cannot deploy the copies.
Try to create unique names like:
Resources:
    ApiGatewayAuthorizer${stage}${alias}:
    ...
    CognitoUserPool${stage}${alias}:

As I remember, variables are not supported for Resources, so you can try serverless-plugin-ifelse plugin.


Add DroidID.app Latest

Thank you for the contribution. It was merged directly as 9c77a8d72567e60ea528650a33dd9c7fabaefc81 to keep commit history cleaner. Your contribution is still credited to you.


Questions about data augmentation for Waymo dataset

Hi,
May I know how did you apply data augmentation for the Waymo Open Dataset (specifically, the "paste" of new objects)? Since the ground surface is not provided in the original Waymo dataset, how did you paste the new items onto the point cloud? Thank you.
Regards,
Tony

We just don't use ground surface information in waymo.

Alright, noted with thanks.


com.google.fonts/check/varfont_has_instances Catch 22

Observed behaviour

com.google.fonts/check/varfont_has_instances insists that a VF has named instances
https://googlefonts.github.io/gf-guide/variable.html#fvar-instances says GF only allows weight and italic particles for the instances
Our font has neither weight nor italic axes
Therefore the only named instance that remains for us is "Regular"
Yet https://docs.microsoft.com/en-us/typography/opentype/spec/fvar says:
Note: Since an instance record for the default instance is not required, a variable font that has no instance records defined in the 'fvar' table (instanceCount is zero) still has one named instance.

Conclusion: a FAIL for missing instances is a false positive in our case.
Expected behaviour
Should it really FAIL in this case?
Resources and exact process needed to replicate
I added a "Regular" named instance at the default location to work around this FAIL:
https://github.com/justvanrossum/nabla/blob/5ea99b75b92fb21f98526830059741dd79242e5a/scripts/shear_and_extrude.py#L490-L492

Thanks for raising this Just. I did notice this fail in https://github.com/google/fonts/pull/5068 but I'm going to merge it anyway. Let's see if our backend raises any issues. If it doesn't, I suppose we can downgrade this check to a warn.


MOCKUP MENU SECTIONS

Description
New mission here 🚀
have you seen the sections when you click on the menu button? Well, this section must be laid out with your amazing skills!
Tasks

[ ] Mockup Mis Puntos
[ ] Mockup Premios
[ ] Mockup Mecánica
[ ] Mockup Bases del concurso
[ ] Mockup Aviso de Provacidad

@TrejoYahir this task is in hols while the design team validates the last requirements from client!, but let's move on with the funny part ...the games investigation. 🤓
See #8


Use shared kafka management tools

We would need to reuse those scripts in the trending service, so move them to their own package.

Coverage remained the same at 93.01% when pulling 8d397c610d94fa34966992606a930779c77737aa on Pchelolo:kafka-tools into 28054b56aef92ab34e134ddfc47b852f92199523 on wikimedia:master.

Coverage remained the same at 93.01% when pulling 5c35d196b77f87a35b418a3520a005869373ed0c on Pchelolo:kafka-tools into 28054b56aef92ab34e134ddfc47b852f92199523 on wikimedia:master.

Coverage decreased (-1.5%) to 91.486% when pulling ab937610ab8ff94ad13ec397c3db86c398523c58 on Pchelolo:kafka-tools into 28054b56aef92ab34e134ddfc47b852f92199523 on wikimedia:master.

Coverage remained the same at 90.942% when pulling 7244a05a307cc2d7fc8268a357c3b8e804b9e47c on Pchelolo:kafka-tools into 9e940c464cc6c56b949227e85349882b645a7617 on wikimedia:master.

Coverage remained the same at 90.942% when pulling 7244a05a307cc2d7fc8268a357c3b8e804b9e47c on Pchelolo:kafka-tools into 9e940c464cc6c56b949227e85349882b645a7617 on wikimedia:master.


Closes #393 Extra header line removed

This turns out to just be an extra line added by accident. The checks for # assert_integer_scalar ---- appear above this chunk.
Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.
Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the main branch until you have checked off each task.

[x] Place Closes #393 into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update)
[x] Code is formatted according to the tidyverse style guide. Run styler::style_file() to style R and Rmd files
[x] Updated relevant unit tests or have written new unit tests, which should consider realistic data scenarios and edge cases, e.g. empty datasets, errors, boundary cases etc. - See Unit Test Guide
[x] If you removed/replaced any function and/or function parameters, did you fully follow the deprecation guidance?
[x] Update to all relevant roxygen headers and examples, including keywords and families. Refer to the categorization of functions to tag appropriate keyword/family.
[x] Run devtools::document() so all .Rd files in the man folder and the NAMESPACE file in the project root are updated appropriately
[x] Address any updates needed for vignettes and/or templates
[x] Update NEWS.md under the header # admiral (development version) if the changes pertain to a user-facing function (i.e. it has an @export tag) or documentation aimed at users (rather than developers)
[x] Build admiral site pkgdown::build_site() and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.
[x] Address or fix all lintr warnings and errors - lintr::lint_package()
[x] Run R CMD check locally and address all errors and warnings - devtools::check()
[x] Link the issue in the Development Section on the right hand side.
[x] Address all merge conflicts and resolve appropriately
[x] Pat yourself on the back for a job well done! Much love to your accomplishment!

Something seems amiss here?

There were two sections for # assert_integer_scalar ----. Just deleting the second one that was out of place. Is there something else amiss @bms63 ?

@bundfussr do you want to add those cleanups in this PR or another? If this PR, please feel free to push the updates here.

@bundfussr do you want to add those cleanups in this PR or another? If this PR, please feel free to push the updates here.

I can add them to this PR.

@bms63 , @ddsjoberg , I have cleaned up test-assertions.R. Now there shouldn't be more than one section per function and all expect_error() calls should use the class argument.
Could you double-check that I didn't miss anything or mess up something?

@ddsjoberg wasn't there a tracking issue for all the error messaging updates? I can't seem to find it

@bms63
There wasn't a master issue for all the updates. It was just a single issue listing the first round updates (https://github.com/pharmaverse/admiraldev/issues/367)


Add use_reloader=False to startup

Every time "Delta5server/server.py" starts it would stop, show the 'Restarting with stat' message, and restart.  Adding "use_reloader=False" to the 'SOCKET_IO.run()' parameters fixes it so it just starts up cleanly.  Solution found in a comment here:  https://stackoverflow.com/questions/28241989/flask-app-restarting-with-stat
--ET

Rebased to master-20181112


[Feature]: Add config option "worker(Max)Retries" instead of hardcoded maxRetries: 3 in jest-runner 🙂

🚀 Feature Proposal
Could it be possible to add this._globalConfig.worker(Max)Retries to configure maxRetries instead of hardcoded 3 ? 🙂

test-runner/src/index.ts

    const worker = new Worker(require.resolve('./testWorker'), {
      enableWorkerThreads: this._globalConfig.workerThreads,
      exposedMethods: ['worker'],
      forkOptions: {serialization: 'json', stdio: 'pipe'},
      // The workerIdleMemoryLimit should've been converted to a number during
      // the normalization phase.
      idleMemoryLimit:
        typeof this._globalConfig.workerIdleMemoryLimit === 'number'
          ? this._globalConfig.workerIdleMemoryLimit
          : undefined,
      maxRetries: 3,
      numWorkers: this._globalConfig.maxWorkers,
      setupArgs: [{serializableResolvers: [...resolvers.values()]}],
    }) as JestWorkerFarm<TestWorker>;

Motivation
Why we can configure maxWorkers option but not maxRetries? 🧐
Example
I would love to have this value = 0 in my jest tests. 🙏🏻
As message Jest worker encountered 4 child process exceptions, exceeding retry limit not helping at all (usually).
Pitch
It's improvement to existing code (jest-runner).

⏳

⏳


feat: Add amazon-uk store with 3080 cards

Description
Fixes #357
I tried to base this on @andrewmackrodt's branch but he added a new function for getting new cards (see https://github.com/jef/nvidia-snatcher/compare/main...andrewmackrodt:develop#diff-f41e9d04a45c83f3b6f6e630f10117fe) so I ended up basing it on the Amazon-DE store.
Definitely inspired by hacktoberfest 🎃
Testing

I ran npm run lint and it passed the linter
I edited my .env to use STORES="amazon-uk"
I ran the bot with npm run start:dev and it seemed to be working!

Going to close in favor of https://github.com/jef/nvidia-snatcher/pull/455. Sorry 😢 Thanks for bring this in though!

Feel free to contribute anything else! Take a look at the issues and see if you can get any hacktoberfest spirit in you 🎃


feature: Add support for state in meltano ui

Feature scope
Web UI
Description
We are running our jobs using the new pipeline syntax: meltano run ...
And we are running our jobs as Kubernetes Cron Jobs (so not Airflow).
For us meltano ui is just blank essentially. Entirely pointless.
But if the UI could show the current state, a bit like meltano state does, then that would be valuable to us.
That would make it possible to view states for any pipeline, regardless of how and where they execute.

@spacecowboy we're not prioritizing the UI right now and I would expect it to fall further behind the CLI at least for the next few months. We will get back to it in 2023 though and start to improve parity, but investments will be in the CLI and API for a while.

Closing as no longer relevant on account of the removal of the UI for Meltano 3.0


Add parameter for max amount that can be single-sided LP'd

@uditvira how should we handle the case where leftover amount exceeds this param?


Convert jib.to.auth.username and jib.to.auth.password to properties

I think it makes sense to convert  jib.to.auth.username and jib.to.auth.password from Strings to Property<String>s in AuthParameters, just as it was done in GoogleContainerTools/jib#2727 / GoogleContainerTools/jib#2739 for jib.to.image in TargetImageParameters.
Motivation is the same as withjib.to.image: make JIB configuration lazier, allowing setting the values (for instance) from other plugins. In my case, I'd like to be able to set the authentication parameters to the values exposed by a Cloud Run plugin and avoid duplicating the code that retrieves them.
Thanks!

Hi @dubinsky,
That makes a lot of sense. Looks like you already looked into a way to fix this. Our resources are very constrained, but if you put up a PR, we will review it. Thanks!

if you put up a PR, we will review it. Thanks!

Thank you, @chanseokoh, it's an honor!
https://github.com/GoogleContainerTools/jib/pull/2906

@dubinsky Jib 2.7.0 has been released with this feature!

@dubinsky Jib 2.7.0 has been released with this feature!

Thank you so much!!!

Hi I had a build like this :
jib {
    // ...
    to {
        def gcpProject = System.getenv('REGISTRY_TARGET') ?: 'dev-sandbox'
        image = "eu.gcr.io/${gcpProject}/${project.name}"
        auth {
            username = 'oauth2accesstoken'
            password = System.getenv('GCR_TOKEN') ?: ''
        }
        tags = [appVersion]
    }
}

But now this fails in dev because I don't have the GCR_TOKEN environment variable locally, only the CI has it.
Build file 'path/to/build.gradle' line: 41

A problem occurred evaluating project ':the-project'.
> Cannot set the value of a property using a null provider.

Right now the only workaround I found is this : System.getenv('GCR_TOKEN') ?: '', but is there something more straightforward ?

Hi I had a build like this :
jib {
    // ...
    to {
        def gcpProject = System.getenv('REGISTRY_TARGET') ?: 'dev-sandbox'
        image = "eu.gcr.io/${gcpProject}/${project.name}"
        auth {
            username = 'oauth2accesstoken'
            password = System.getenv('GCR_TOKEN') ?: ''
        }
        tags = [appVersion]
    }
}

But now this fails in dev because I don't have the GCR_TOKEN environment variable locally, only the CI has it.
Build file 'path/to/build.gradle' line: 41

A problem occurred evaluating project ':the-project'.
> Cannot set the value of a property using a null provider.

Right now the only workaround I found is this : System.getenv('GCR_TOKEN') ?: '', but is there something more straightforward ?

@bric3 perhaps for your dev machine, remove the auth { ... } and configure gcloud credential helper? Basically running gcloud auth configure-docker after gcloud auth login.
FYI, since the username on CI is oauth2accesstoken, looks like your CI is using the access token method. In this case, the content of GCR_TOKEN would be the output of gcloud auth print-access-token as documented there. (It's a short-lived token expiring after an hour.)

For the general ways to configure auth in Jib, see this FAQ.

@bric3 perhaps for your dev machine, remove the auth { ... } and configure gcloud credential helper? Basically running gcloud auth configure-docker after gcloud auth login.
FYI, since the username on CI is oauth2accesstoken, looks like your CI is using the access token method. In this case, the content of GCR_TOKEN would be the output of gcloud auth print-access-token as documented there. (It's a short-lived token expiring after an hour.)

For the general ways to configure auth in Jib, see this FAQ.


Added a note for WSL2 users

Closes #51
Note for WSL2 users, changed docs.md to design.md, copied its content to the end of the readme file.

I think this PR would be fine. Sorry for these mess ups I'm still learning how to use git/github properly.


Unify scrollbars

Related to: https://github.com/CartoDB/cartodb/issues/12184
Refactor legends and infowindow scrollbars. Add shadows in popups (infowindow)
Main PR: https://github.com/CartoDB/cartodb/pull/12877

A screenshot in the description would be appreciated 😬  (@xavijam back from holidays :joy:)

@xavijam check the Main PR in the description (lots of changes!) :smile:


Is it possible to get tweets by hashtags?

Hi,
I'm wondering if it is possible to use this package to return the most recent tweets that contain a given hashtag, or any other text, e.g., tweets containing WorldCup 2022.
Thanks a lot for your help in advance.
Best.

Yes, you can use search endpoint to get tweets for your keywords


Allow developers to easily deploy a vm testnet on production project

Expected Behavior
Deployment works out of the box
Current Behavior
Some things (like project names, service accounts) had to be changed/hardcoded to accommodate working with both celo-testnet and celo-testnet-production when deploying baklava

Covered in #2073, closing


added !pokedex command

added a command that displays pokemon infor on the basis of user input

Uhh oh, seems we have some merge conflicts somewhere. Need to check this tomorrow and see where the problem is.

@Xarlos89 i have closed this PR and created a new one as it had conflicts from my side


Merge Sort in Java

This issue is about [Algo - Merge Sort in Java]

[x] I searched or browsed the repo’s other issues to ensure this is not a duplicate

[x] Issue Title is in form [Algo/DS Name] in [Language] (ex:- BubbleSort in Java)

[x] I will send my PR only after I'm assigned to this issue by any maintainer

[x] Assign this issue to me (I want to work on this)

[x] I ensure that I am not already assigned to 2 or more issues

Please assign this to me.

Could you please assign this to me ?


Modify Sponsor Role

The "Sponsor" role or "Initial Authorizer" need to have the ability to submit. Code in easey-auth-api/src/sign/Sign.service.ts (authenticate method) continues to limit submissions to users with the "Submitter" role.
<<<>>>
if (!user.roles.includes('Submitter')) {
throw new EaseyException(
new Error('This requires the Submitter role'),
HttpStatus.BAD_REQUEST,
{
responseObject: 'This requires the Submitter role',
},
);
}
<<<>>>
This logic needs to be expanded to also allow users with the "Sponsor" role or "Initial Authorizer" role to make submissions. If there is already a zenhub ticket for this issue, then please send it along.

@shahbazkhan1999 has already worked on this with Kyle and is ready for testing.

@shahbazkhan1999
This code in Sign.service.ts (authenticate method) needs to be updated to allow users with the Initial Authorizer role to submit as well.
There will be users that only have the Initial Authorizer role in CDX, and these users should be treated as Sponsors in ECMPS (i.e., anytime we check for the Sponsor role to allow an action also needs to check for the Initial Authorizer role).
if (!(user.roles.includes('Submitter') || user.roles.includes('Sponsor')) ) {
      throw new EaseyException(
        new Error('This requires the Sponsor or Submitter role'),
        HttpStatus.BAD_REQUEST,
        {
          responseObject: 'This requires the Sponsor or Submitter role',
        },
      );
    }

@spetros-do  will do peer review

Changes are only required at the front end. Already done with that and the frontend ticket is in peer review.


SpringBoot Customized WebApp Welcome Page

Hi, i tried to copy the code from cockpit, admin and tasklist examples, doing some updates to customize the welcome page, and it`s loading forever... i can access the other applications well, but would be interesting to update this repository to show the example to the welcome page

Any errors in the javascript console?

At the day, i think i was just using the wrong statements, like:
Admin: window.camAdminConf {...}
Tasklist: window.camTasklistConf {...}
Cockpit: window.camCockpitConf {...}
Welcome: window.camWelcomeConf {...}


Why is our default PostgreSQL version 9.6? Shouldn't it be version 11?

I am by no means an expert on database systems, so this may be a stupid question ... but I can't help wondering why postgresql does not refer to PostgreSQL version 11 on current versions of nixos-unstable? Is there a reason we haven't updated yet?

Maybe @danbst or @aszlig can answer this... :thinking:

@peti: Good question. In my case I'm not using PostgreSQL 9 by myself and switched to 10 and 11 a long time ago, but I also wasn't aware of this because I'm not using the module from NixOS in my deployments.

Made a PR for that... If you think it's too rush to include it to 19.09, then I can delay it to 20.03
As for pkgs.postgresql, it really shouldn't be used. It should be split to server, client and libpq, and client/libpq may be continuosly updated, but server should be used only with explicit version.
But this server/client split is not straightforward, so it was not yet done.


Many modules have duplicated dependency declarations

I noticed some of the modules had duplicate entries in the <dependencies> section, so I ran a script to detect where the problems are.
It seems that the smartics plugin creates a dependency for something that has already been defined in the module descriptor. This results in some dependencies occurring twice in the generated module.xml file.
Module org.springframework.beans has duplicate dependencies declared:
	org.springframework.core

Module org.springframework.context has duplicate dependencies declared:
	org.springframework.core

Module org.apache.ws.commons.axiom.axiom-api has duplicate dependencies declared:
	org.apache.commons.logging

Module org.apache.ws.commons.axiom.axiom-impl has duplicate dependencies declared:
	org.apache.commons.logging

Module org.apache.camel.component.jmx has duplicate dependencies declared:
	javax.xml.bind.api

Module org.apache.camel.component.cdi has duplicate dependencies declared:
	javax.enterprise.api
	javax.xml.bind.api
	org.apache.deltaspike.cdictrl.api
	org.apache.deltaspike.core.api
	org.apache.deltaspike.core.impl

Module org.apache.camel.component.dozer has duplicate dependencies declared:
	org.slf4j

Module org.apache.camel.component.hl7 has duplicate dependencies declared:
	org.slf4j

Module org.apache.camel.component.flatpack has duplicate dependencies declared:
	org.slf4j

Module org.apache.camel.component.xstream has duplicate dependencies declared:
	javax.xml.stream.api
	org.codehaus.jettison

Module org.apache.camel.component.restlet has duplicate dependencies declared:
	org.restlet

Module org.apache.camel.component.quartz2 has duplicate dependencies declared:
	org.slf4j

Module org.apache.camel.component.ognl has duplicate dependencies declared:
	ognl

Module org.apache.camel.component.http4 has duplicate dependencies declared:
	org.apache.httpcomponents

Module org.apache.camel.component has duplicate dependencies declared:
	org.apache.camel.component.ejb

This may happen due to version updates i.e. the pom of a component changes, but its associated smartics def does not.
IMHO this should be an error detected by smartics

I think this is just a quirk in the way that the plugin works. I rasied https://github.com/smartics/smartics-jboss-modules-maven-plugin/issues/21 upstream.

The upstream changes have been merged.
Now blocked waiting for release 2.1.1 of the smartics maven plugin.


utils::avian3d rotation helper requires all the gui stuff

ran into this trying to build a headless server for the avian_3d_character example.
perhaps some judicious copy+paste to avoid a dependency on bevy_animation just for the interpolate fn 🤔
pub mod rotation {
    use super::*;
    use avian3d::math::Quaternion;
    // TODO: bevy_animation is a "pulls in all the gui stuff" crate.
    // but we want to be able to lerp rotations on our headless game servers!
    use bevy::prelude::Animatable;

    pub fn lerp(start: &Rotation, other: &Rotation, t: f32) -> Rotation {
        Rotation(Quaternion::interpolate(&start.0, &other.0, t))
    }
}

I think this is a bug in Bevy. bevy_animation should not depend on anything GUI I would think.

bevy_animation uses some of the mesh morphing stuff from bevy_render, but not a lot else. maybe feasible to change.. doing this for now, in my examples branch:
/// copied from Animatable trait in bevy_animation, which we don't want as a dep because
/// it pulls in all the render stuff, and we might need to interpolate on a headless server.
fn interpolate_quat(a: &Quat, b: &Quat, t: f32) -> Quaternion {
    // We want to smoothly interpolate between the two quaternions by default,
    // rather than using a quicker but less correct linear interpolation.
    a.slerp(*b, t)
}

pub mod rotation {
    use super::*;

    pub fn lerp(start: &Rotation, other: &Rotation, t: f32) -> Rotation {
        Rotation(interpolate_quat(&start.0, &other.0, t))
    }
}

Yes ideally this would be changed in bevy_animation I think

@RJ can this be closed now?

yep the upgrade to bevy 0.15 made this moot, closing


Add Ukrainian translation link

Adding link to the Ukrainian translation.
Issue: https://github.com/ncase/covid-19/issues/16

Thank you immensely for this! Sorry for the long wait – very behind on emails – but thanks also for your patience! 🎉


Curated link on software testing

From @elaineraybourn via the BSSw feedback form.

Would this resource be useful to point to?
https://cacm.acm.org/blogs/blog-cacm/228226-the-goal-of-software-testing/fulltext

Elaine,
To me, this article is on the border.  I like the point that software testing is about finding bugs rather than asserting that your software is free of defects.  However the context he's talking about is much more the commercial software world, where you (often) have separate testing teams, and testing often has schedule constraints or implications for a product release.  My experience is that scientific software is significantly different in this respect, and I'm not sure the article is so applicable to our space.
Other opinions welcome.

It seems to me that with the proper curation, the article could still be valuable.  It does bring up some good concepts and citations for software testing.  Even if scientific projects don’t have separate testing teams, some teams have special bug fixing phases.
Mike
From: "David E. Bernholdt"<EMAIL_ADDRESS>Reply-To: "betterscientificsoftware/betterscientificsoftware.github.io"<EMAIL_ADDRESS>Date: Tuesday, June 12, 2018 at 8:07 AM
To: "betterscientificsoftware/betterscientificsoftware.github.io"<EMAIL_ADDRESS>Cc: Subscribed<EMAIL_ADDRESS>Subject: [EXTERNAL] Re: [betterscientificsoftware/betterscientificsoftware.github.io] Curated link on software testing (#280)
Elaine,
To me, this article is on the border. I like the point that software testing is about finding bugs rather than asserting that your software is free of defects. However the context he's talking about is much more the commercial software world, where you (often) have separate testing teams, and testing often has schedule constraints or implications for a product release. My experience is that scientific software is significantly different in this respect, and I'm not sure the article is so applicable to our space.
Other opinions welcome.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/betterscientificsoftware/betterscientificsoftware.github.io/issues/280#issuecomment-396582511, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AA-US45dcEhsCe24VAJWE3WMckNlxQiyks5t770BgaJpZM4UkY_1.

Thanks, David and Pat for your thoughtful reply!
On Tue, Jun 12, 2018 at 9:07 AM, David E. Bernholdt <
<EMAIL_ADDRESS>wrote:

Elaine,
To me, this article is on the border. I like the point that software
testing is about finding bugs rather than asserting that your software is
free of defects. However the context he's talking about is much more the
commercial software world, where you (often) have separate testing teams,
and testing often has schedule constraints or implications for a product
release. My experience is that scientific software is significantly
different in this respect, and I'm not sure the article is so applicable to
our space.
Other opinions welcome.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/betterscientificsoftware/betterscientificsoftware.github.io/issues/280#issuecomment-396582511,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AbRqOHlalEI-M3b0bNkXF8cH_zYFapOQks5t770CgaJpZM4UkY_1
.

--
Elaine

I've gone through the article again and all that I get out of it is to set a limit to testing (i.e. fixing a number of bugs) and produce something, with no real guidelines. It does have links to several books, but I'm not sure even that is helpful. It might be more beneficial if we actually have a guide.


[Dubbo-655] Update Jetty to Version 9 #655

What is the purpose of the change
Update Jetty to version 9 for Dubbo #655
Brief changelog

Update dependency: org.mortbay.jetty:jetty to org.eclipse.jetty:jetty-server and org.eclipse.jetty:jetty-servlet

incubator-dubbo/dubbo-rpc/dubbo-rpc-dubbo/pom.xml
incubator-dubbo/dubbo-remoting/dubbo-remoting-http/pom.xml
incubator-dubbo/dubbo-registry/dubbo-registry-api/pom.xml

Update plugin: org.mortbay.jetty:maven-jetty-plugin to org.eclipse.jetty:jetty-maven-plugin

incubator-dubbo/pom.xml

Modify JettyHttpServer with Jetty 9 API

org.apache.dubbo.remoting.http.jetty.JettyHttpServer#JettyHttpServer

Verifying this change

org.apache.dubbo.remoting.http.jetty.JettyHttpBinderTest passed
Exsiting unit-test and intergration-test passed

Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Make sure there is a GITHUB_issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[ ] Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
[ ] Run mvn clean install -DskipTests & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
[ ] If this contribution is large, please follow the Software Donation Guide.

Codecov Report

Merging #2198 into master will increase coverage by 0.05%.
The diff coverage is 75%.

@@             Coverage Diff             @@
##             master   #2198      +/-   ##
===========================================
+ Coverage     54.24%   54.3%   +0.05%
- Complexity     5121    5126       +5
===========================================
  Files           569     569
  Lines         25031   25030       -1
  Branches       4456    4456
===========================================
+ Hits          13579   13592      +13
+ Misses         9415    9406       -9
+ Partials       2037    2032       -5

Impacted Files
Coverage Δ
Complexity Δ

...che/dubbo/remoting/http/jetty/JettyHttpServer.java
78.94% <75%> (-0.54%)
3 <0> (ø)

...onfig/spring/extension/SpringExtensionFactory.java
75% <0%> (-10.72%)
10% <0%> (ø)

.../java/org/apache/dubbo/config/ReferenceConfig.java
51.41% <0%> (+0.7%)
43% <0%> (ø)
:arrow_down:

...apache/dubbo/rpc/protocol/dubbo/DubboProtocol.java
59.16% <0%> (+0.83%)
31% <0%> (+1%)
:arrow_up:

...dubbo/rpc/protocol/dubbo/CallbackServiceCodec.java
78.67% <0%> (+1.47%)
29% <0%> (ø)
:arrow_down:

...rpc/protocol/dubbo/telnet/InvokeTelnetHandler.java
55.69% <0%> (+3.79%)
13% <0%> (+3%)
:arrow_up:

...org/apache/dubbo/rpc/filter/ActiveLimitFilter.java
88.88% <0%> (+5.55%)
7% <0%> (+1%)
:arrow_up:

...apache/dubbo/rpc/protocol/dubbo/FutureAdapter.java
64.51% <0%> (+6.45%)
3% <0%> (ø)
:arrow_down:

...ubbo/rpc/protocol/dubbo/ChannelWrappedInvoker.java
50% <0%> (+8.33%)
3% <0%> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e961c90...6cded2b. Read the comment docs.

I think it's ready to merge. Please help resolve the conflicts.


Docker machine is not working with Swarm

Hi there,
something with docker-machine resp. docker swarm is not working as described in the documentation.
 I created a "swarm-master" as described and I also created a swarm node.
$ docker-machine ls
NAME ACTIVE DRIVER STATE URL SWARM
swarm-master * virtualbox Running tcp://<IP_ADDRESS>:2376 swarm-master (master)
swarm-node-01 virtualbox Running tcp://<IP_ADDRESS>:2376 swarm-master
Now, let's see, if these Virtualboxes are running at all:
$ ps -ef | grep "VBoxHeadless"
tmichels 2998 2463 2 16:54 ? 00:02:35 /usr/lib/virtualbox/VBoxHeadless --comment swarm-master --startvm 221b9611-340f-45c1-99a7-c7a6a7db8b29 --vrde config
tmichels 10193 2463 5 18:27 ? 00:00:37 /usr/lib/virtualbox/VBoxHeadless --comment swarm-node-01 --startvm d2e780b0-54f9-4e9b-98d1-f261b96e7261 --vrde config
So far, so good.
Then I wanted to use the swarm-master for using the setup. I opened a new ssh-shell (bash) and did a:
$ env | grep DOCKER
$ docker-machine env --swarm swarm-master
export DOCKER_TLS_VERIFY=1
export DOCKER_CERT_PATH="/home/tmichels/.docker/machine/machines/swarm-master"
export DOCKER_HOST=tcp://<IP_ADDRESS>:3376
# Run this command to configure your shell: eval "$(docker-machine env swarm-master)"
(The output on the console is missing the --swarm option!)
I did as requested:
$ eval "$(docker-machine env --swarm swarm-master)"
$ env | grep DOCKER
DOCKER_HOST=tcp://<IP_ADDRESS>:2376
DOCKER_TLS_VERIFY=1
DOCKER_CERT_PATH=/home/tmichels/.docker/machine/machines/swarm-master
This looks, like I would be on "swarm-master".
Now the documentations says, if I do a docker info, I should see my "swarm-master" and the node. Right?
$ docker info
Containers: 4
Images: 21
Storage Driver: aufs
Root Dir: /var/lib/docker/aufs
Backing Filesystem: extfs
Dirs: 29
Dirperm1 Supported: true
Execution Driver: native-0.2
Kernel Version: 3.19.0-15-generic
Operating System: Ubuntu 15.04
CPUs: 16
Total Memory: 141.7 GiB
Name: BIGServer
ID: XXXX-XXXX-XXXX-XXXX-XXXX
Username: tmichels
Registry: [https://index.docker.io/v1/]
This does not look as shown in the documentation.
Either this is not working properly or there is an error in the documentation or it does not work on Ubuntu 15.04.

@Spirit328
Like I told you before:
First you wrote

$ docker-machine env --swarm swarm-master

then you did

$ eval "$(docker-machine env swarm-master)"

and you should have done

$ eval "$(docker-machine env --swarm swarm-master)"

they are different things (see the --swarm option ;-) )
You need to use the --swarm option`if you want use docker info and see swarm nodes

as @aanm said you need to use --swarm.  We use the bash hint to connect to the engine. We could open a discussion on whether to default swarm nodes to use swarm.
In the docs it looks correct when interacting with swarm (http://docs.docker.com/machine/#swarm-nodes).  We leave both ways in case you need to interact with the engine direct.

Closing.  Feel free to open a separate issue if you would like to discuss defaulting to swarm for swarm nodes.  Thanks!


Losing text

bk loses the last portion of the section in some cases.
See the attached test epub file, viewed with bk -w 75.
If there's a br at the end, it works correctly.
test.zip

fixed your example. this is another whitespace issue, generally the last line is a newline which isn't rendered.


HTML Table Page Split Issue

I'm using jsPDF to export HTML tables to a PDF document but when a table splits between two pages, I see this issue:

Does anyone know how I can fix this? Here is my code:
            var pdf = new jsPDF('p', 'pt', 'letter');
            source = $('#survey')[0];

            specialElementHandlers = {
                '#bypassme': function (element, renderer) {
                    return true
                }
            };

            margins = {
                top: 40,
                bottom: 20,
                left: 40,
                width: 522
            };

            pdf.fromHTML(
                source,
                margins.left,
                margins.top, {
                    'width': margins.width,
                    'elementHandlers': specialElementHandlers
                },

            function (dispose) {
                pdf.save('Survey_Report.pdf');
            }, margins);

I have the same problem. If someone got the solution, please share!

We are closing this issue, because we will not support any longer fromHTML and addHTML.
Explaination:
We are working on a new html2pdf plugin, which will be based on html2canvas and our context2d plugin. This should lead to more reliable results for your projects. And it will give us the time to focus on the core functionality of pdf-generation because we will not use our energy for writing/supporting/extending 2 html plugins. If you still want to use addHTML or fromHTML you can still use jsPDF 1.4.1.
Best Regards


Need mocks for testing TaskQueue

The number of failed tests just for this reason is really annoying.

How are tasks failing?


Migration from Groovy to Kotlin DSL

Migrating .gradle files to the .kts for modernization
Kotlin is preferred over Groovy for writing Gradle scripts because Kotlin is :

more readable and offers better compile-time checking and IDE support.
offers simplified, declarative plugin syntax.

Do you want to work on this issue?

@bhoomi0104 Yes, I want to work on this issue. Also, give the issue the label as hacktoberfest.
https://hacktoberfest.com/participation/#maintainers

Ok All the best 👍


Upgrade from v0.1.2 to v0.2.1 throws an error

Tried a fresh install, not working either. Happy to provide any further information.

------------------------------
- Operating System: Windows_NT
- Node Version:     v18.13.0
- Nuxt Version:     3.8.1
- CLI Version:      3.9.1
- Nitro Version:    2.7.2
- Package Manager<EMAIL_ADDRESS>------------------------------

weird, have you run nuxt prepare script?

ok, found the problem, fixing it...

@DamianGlowala can you show me your pwa configuration? I guess are using manifest: false... can you confirm?

This is what I currently have set up:
pwa: {
    client: {
        installPrompt: true
    }
}

I'll release a new version, check this comment https://github.com/vite-pwa/nuxt/issues/84#issuecomment-1802641770

@DamianGlowala should be fixed in v0.2.2, test it without manifest and then add empty manifest (later you should add manifest entries with your data and icons).


ThemeManager setPalette() overriding theme component styles

Hi,
I have an issue regarding the setPalette() function. At the moment i'm applying a theme to my root application. I'm setting the theme in the componentWillMount function:
componentWillMount: function() {
	ThemeManager.setTheme(TestTheme);
},

This is the theme i'm applying (button height 300 for demonstration purposes):
var TestTheme = {
	getPalette: function() {
		return {
			primary1Color: Colors.lightBlue500,
			primary2Color: Colors.lightBlue700,
			primary3Color: Colors.lightBlue100,
		};
	},
	getComponentThemes: function(palette) {
		return {
			button: {
				height: 300
			}
		};
	}
};

This all works well, the colors are being applied and the button component has a height of 300px. Now at a certain point in my code i'd like to override this themes primary colors as follows:
ThemeManager.getCurrentTheme().setPalette({
	primary1Color: Colors.lightBlue500,
	primary2Color: Colors.lightBlue700,
	primary3Color: Colors.lightBlue100
});

When i apply this setPalette function, this resets the styles defined in the previously set getComponentThemes function. It seems as if the theme is returning to the default light-theme whilst only applying the new colors defined in the setPalette function.
Am i overlooking something here, or is theming not working as i intended? Thanks in advance!

@eXtreaL Are you calling ThemeManger.setTheme to change your theme?

@hai-cea Yes, I am in my componentWillMount(). Then when I try to override the themes palette using setPalette(), it also overrides all the components colors set in getComponentThemes().

@eXtreaL have you tried pursuing this use case since we changed theming in v0.12? Take a look here and feel free to comment if you have any questions. Closing for now..


packageBin should cache

steps

packageBin
packageBin

problem
It runs twice.
expectation
Zipping is expensive, so if the input hasn't changed, could we cache?

create fileInputs based on the default mapping.
compare the list of Files against the mapping.
if fileInput covers 100% of the mappings, use fileInput to detect changed files. Otherwise invalidate.
If the change was detected, invalidated, or the JAR doesn't exist yet, run actual Package.

This was fixed in https://github.com/sbt/sbt/pull/7464/


Request failed with status code 500

Hey,
I installed the progam with Docker on my Linux VPS but when I try to log in it gives this error: 'Request failed with status code 500' how can I fix this?
you can also contact me on Discord: Dinand#4183

any answer to this?  I am assuming the login link is broken


Remove static flux-system ns config

Implements https://github.com/giantswarm/roadmap/issues/3485

I think you need to add this change as a patch to https://github.com/giantswarm/flux-app/tree/main/hack/git-patches or it will be lost on upgrade.


Add saving/loading for transforms, models, pipelines

Before submitting (must do checklist)

[x] Did you read the contribution guide?
[x] Did you update the docs? We use Numpy format for all the methods and classes.
[x] Did you write any new necessary tests?
[ ] Did you update the CHANGELOG?

Proposed Changes

Add saving/loading for transforms, models, pipelines
Add example for using saving/loading

Closing issues

Codecov Report

Merging #1068 (440a935) into master (56990dd) will decrease coverage by 35.93%.
The diff coverage is 53.48%.

@@             Coverage Diff             @@
##           master    #1068       +/-   ##
===========================================
- Coverage   86.03%   50.09%   -35.94%
===========================================
  Files         163      153       -10
  Lines        8656     8591       -65
===========================================
- Hits         7447     4304     -3143
- Misses       1209     4287     +3078

Impacted Files
Coverage Δ

etna/models/nn/mlp.py
58.66% <ø> (-41.34%)
:arrow_down:

etna/pipeline/mixins.py
31.42% <25.00%> (-66.54%)
:arrow_down:

etna/core/mixins.py
37.59% <32.78%> (-59.63%)
:arrow_down:

etna/core/utils.py
75.60% <40.00%> (-20.55%)
:arrow_down:

etna/ensembles/mixins.py
53.16% <53.16%> (ø)

etna/models/mixins.py
74.17% <53.84%> (-21.48%)
:arrow_down:

etna/models/base.py
60.43% <66.66%> (-26.01%)
:arrow_down:

etna/core/saving.py
83.33% <83.33%> (ø)

etna/core/__init__.py
100.00% <100.00%> (ø)

etna/ensembles/__init__.py
100.00% <100.00%> (ø)

... and 124 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


MINOR: Add notes on deleting old releases and release candidates from svn

Which issue does this PR close?

N/A
Rationale for this change

We need to remove old releases when publishing a new release
What changes are included in this PR?

Docs
Are there any user-facing changes?

No

Codecov Report

Merging #3227 (6b93949) into master (f974e88) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3227   +/-   ##
=======================================
  Coverage   85.84%   85.84%
=======================================
  Files         291      291
  Lines       52910    52910
=======================================
+ Hits        45421    45422    +1
+ Misses       7489     7488    -1

Impacted Files
Coverage Δ

datafusion/expr/src/logical_plan/plan.rs
78.17% <0.00%> (+0.17%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Hide status on hover

This enables a preference to be hide the status when hovering over links. Alternatively, this could check to see if the href is linking to another domain, and if so display the status, otherwise hide.
Personally find this fading in and out frequently to be a distraction. On mobile, where you don’t have hover states, this functionality doesn’t exist, and doesn’t feel like a security risk.
Side note, I tried adding a comment to the preferences.json consistent with the established formatting convention (//), but it throws an error about malformed JSON. Weird!

Agree, that behavior can be jarring. Why not call that preference item show_url_preview (set to true by default)?
Otherwise PR looks fine to me, will just have to update model_version for the next public release so older clients are prompted to update their preferences.
About that side note: could you attach the preferences.json file where the error occurs? My regex to strip the comments might not be matching soft tabs or a rogue character.

Makes sense to me! Soft tabs was the issue; you can replicate quite easily.

Merged, thanks! 👌
Will have a look at that soft tab issue, too.


Allow to make custom cursors

Operating System

[X] Windows
[X] macOS
[X] Linux
[ ] FreeBSD
[ ] OpenBSD
[ ] Android
[ ] iOS
[ ] Nintendo Switch
[ ] Xbox
[ ] Web Browsers

What feature would you like to be added?
SDL and GLFW support registering non-system cursor by storing a custom bitmap images for new cursor shapes.
It would be good to have the same ability to Ebiten. For example, with an API similar to this:
shape := ebiten.NewCursorShape(image, originX, originY)
... // later
ebiten.SetCustomCursorShape(shape)

Why is this needed?
Allow to have new cursor shapes which might not be available on all systems.

https://www.cashbill.pl/kontakt/#reklamacje

SDL and GLFW support registering non-system cursor by storing a custom bitmap images for new cursor shapes.

Unfortunately this is not supported on browsers.
The current simple solution for Ebitengine is to render an image at ebiten.CursorPosition. Wouldn't this work for you?

It does work and most of us do exactly that, but that comes with some limitations. i,e. when you capture your screen (print screen) the cursor is visible, or when you are on the edge of the window, the cursor is only being drawn on the game.

Those are very small differences that no sane player would ever notice, but there are some 😄

I think it will be pretty okay if this is not supported in browsers.
Here's the main benefit, though - the cursor is replaced on a windowing system level, as far as I know . So the cursor renders as fast as your "native" cursor does and is not bound to your game's FPS. If you try to render a "software" cursor, you'll notice that it's quite unresponsive.
For example, take a look at what glfw does for X1 - it's not merely drawing a sprite on top of your screen, it's replacing the actual OS cursor as if you loaded a custom theme for it.

On browsers, I think we can 'emulate' a cursor shape by an img element, maybe?

The current cursor API is like this
type CursorShapeType = ui.CursorShape // int
func CursorShape() CursorShapeType
func SetCursorShape(shape CursorShapeType)

We should have this API (without considering the backward compatibility)
type CursorShape struct {...}
func NewCursorShape(img image.Image, x, y int) *CursorShape
type StandardCursorShapeType int
func NewStandardCursorShape(typ StandardCursorShapeType) *CursorShape
func SetCursorShape(shape *CursorShape)

In order to keep backward compatibility, the API would be like this
type CursorShapeType int
func CursorShape() CursorShapeType
func SetCursorShape(shape CursorShapeType)

type CustomCursorShape struct {...}
func NewCutomCursorShape(img image.Image, x, y int) *CustomCursorShape
// If non-nil is set at SetCustomCursorShape, the value at SetCursorShape is ignored.
func SetCustomCursorShape(shape *CustomCursorShape)

I'm not sure what would happen for HiDPI environments: would the image be enlarged automatically? Hmm?


Navigate to top button

Adding a scroll to top button will help users to easily navigate to the top/main website easily.

I want to work on this issue under gssoc'22.

I want to work on this issue


Skip E2E tests if the PR has the 'ci/skip/e2e' label

Describe what this PR does
Add script to fetch labels for GitHub PR: scripts/get_github_labels.py
The script runs in a minimal Jenkins Slave container, but Python is available there.
By passing --id=<id> the labels of the given Pull-Request or Issue get
printed. When adding --has-label=<label>, the script verifies if the
label is set and returns 0 on succes, or 1 on failure.
The label will skip the following jobs:

mini-e2e-helm
mini-e2e

Is there anything that requires special attention
The jobs will run, but exit early in case the label is set on the PR. This sets the status-context in the PR as if the job has passed. Mergify will be happy with this.
Note that the jobs will get started in case a PR gets created without the label. Once the label is added, and the CI jobs for the PR are already running, the jobs will need to run to completion. Rebases should not trigger a full run of of the jobss anymore.
Related issues
Fixes: #1427
Future concerns
The [ci/skip/e2e] label has been added. Following that approach, it is easy to add more labels that require additional testing, and or skipping of other CI jobs.

We can also add flake8 check in the git hook which can verify the changes in python files in the repo. Any thoughts? @Madhu-1 @nixpanic

We can also add flake8 check in the git hook which can verify the changes in python files in the repo. Any thoughts? @Madhu-1 @nixpanic

This is related present in master branch. need to add for centos/ci branch

We can also add flake8 check in the git hook which can verify the changes in python files in the repo. Any thoughts? @Madhu-1 @nixpanic

This is related present in master branch. need to add for centos/ci branch

Sure, That will not be a problem. We just need to add the config file at the root of ci/centos branch. Will send a PR for that :+1:

We can also add flake8 check in the git hook which can verify the changes in python files in the repo. Any thoughts? @Madhu-1 @nixpanic

This is related present in master branch. need to add for centos/ci branch

Sure, That will not be a problem. We just need to add the config file at the root of ci/centos branch. Will send a PR for that

not only in local, this need to be tested as part of validation in centos/ci


Don't Merge! PR real time test for webhook case

Docs Build status updates of commit b783ff8:
:clock10: Pending: waiting for processors (24 builds ahead of you)
:warning: Docs Build is busy, currently there are 24 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit b783ff8:
:clock10: Full build: the average full build time is 5 min(s) 9 sec(s), this is based on the last 30 build(s) for this repository.

Docs Build status updates of commit b783ff8:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docs-ref-conceptual/testing.md
:warning:Warning
View (azure-cli-latest) View (azure-cli-2017-03-09-profile) View (azure-cli-2018-03-01-hybrid)
Details

docs-ref-conceptual/testing.md

[Warning] Missing attribute: either ms.prod or ms.service is required. Use ms.prod for on-premise products, or ms.service for cloud services.
[Warning] Missing attribute: title.
[Warning] Missing attribute: either ms.prod or ms.service is required. Use ms.prod for on-premise products, or ms.service for cloud services.
[Warning] Missing attribute: title.
[Warning] Missing attribute: either ms.prod or ms.service is required. Use ms.prod for on-premise products, or ms.service for cloud services.
[Warning] Missing attribute: title.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Provide guidance about how to wire use different events with InputText

It's here: https://docs.microsoft.com/en-us/aspnet/core/blazor/forms-validation?view=aspnetcore-3.0#inputtext-based-on-the-input-event


[Feature]: Add possibility for live(onBlur: true)

What happened?
Not really a bug, just not implemented.
onBlur: true in live() would be handy if we can use this with currencyMask.
It would be nice to not just always let it be reactive but have a choice for onBlur aswell.
How to reproduce the bug
Just add live(onBlur: true) it won't work.
I am creating a PR to introduce this, though im having a few issues :)
Package Version
1.7.5
PHP Version
8.3.7
Laravel Version
11.9
Which operating systems does with happen with?
macOS
Notes
No response

added in v1.8.0


Error: open /dev/disk/by-id/: no such file or directory

Hi, I'm trying to test migratekit but I'm stuck when running migrate phase with message:
"Error: open /dev/disk/by-id/: no such file or directory", it happens after Removing snapshot 100%.
Can you please advise ?
Thank you in advance and best regards,
Igor

I can pass this step if I manually attach volume (which was created by migratekit) to instance on which migratekit is started, but shouldn't this mount be done automatically? Or am I mistaking or missing something? I can't find nothing in readme which is related to openstack configuration or requirements.
BR, Igor

Maybe the same case. I had the same issue and knowing that migratekit tool has to run on a VM thats running in openstack environment. Same as you, couldn't find that documentation anywhere.

Ok, I managed to finish the migration for two test virtual machines. In short, openstack client and OS environment (with admin rights) must be configured on instance which is running on openstack. On that same instance files from VMware-vix-disklib-8.0.3-23950268.x86_64.tar.gz must be unpacked and copied in /usr/lib64/vmware-vix-disklib. Be sure to use version 8.0.3, I had a problem with 8.0 release (missing support for GLIBCXX_3.4.30). Besides that, on the same instance docker must be installed. Virtual machine on vmware which is subject for migration must have CTK enabled globaly and for all disks. After those settings, migration and cutover phases were succesfull. After powering on migrated instance on openstack, you should manually adjust network configuration via console (tested on ubuntu, maybe for some other distribution cloud-init do the job, still not sure).
Good luck.
BR, Igor