#272 Handle errors that terminate state machines

Issue #, if available:
#272
Description of changes:
Added a new lambda resource, WorkflowErrorHandlerLambda, that is triggered by  Step Functions Execution Status Change EventBridge events that have an error status (FAILED, TIMED_OUT, ABORTED).
The WorkflowErrorHandlerLambda extracts the error information from the state machine execution history and propagates the error to the MIE control plane.
In order to handle multiple MIE stacks deployed in the same region, the event handler checks for the stack SHORT_UUID in the workflow name.  If the workflow name does not contain the stack, then it returns without handling the error.  The alternative to this would be to use the "prefix" event filter on the workflow name.  In order to do this, we would need to change the naming of workflows to be SHORT_UUID+WorkflowName instead of WorkflowName+SHORT_UUID.
I have a separate pull request to update the implementation guide with error handling info.
See also: https://github.com/awslabs/aws-media-insights/pull/24
Testing:
I tested the error handler e2e manually with ABORTED and TIME_OUT events.  I simulated a failure event by pasting in event JSON to the lambda function.
Future work:
#271 Add a configurable workflow timeout to the create workflow API
#270 Refactor workflowapi and workflow lambdas to use a library import for shared code
#269 Automated integration test for workflow state machine execution failure that immediately terminate the execution
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Overall this looks good to me. My only concerns are with the code style regarding the stack short UUID. I put some single comments here and there but more generally I'm curious if there is even a case where the UUID wouldn't be available.

When I added that code I was thinking about the fact that the code in the file supports a number of lambda functions and not all of them have the same environment variables set.  I added #270 (Refactor workflowapi and workflow lambdas to use a library import for shared code) to address the code organization issue in the future.  None of the other lambdas are calling this code, so it is pretty safe to assume the SHORT_UUID is set.  I'll make the change to simplify this new code.

Updated the pull request to address review comments from Brandon.


docker 运行也报错

*** ______  ********************* ______ *********** _  ********
*** | ___ _ ******************** | ___ \ ********* | | ********
*** | |/ / _ __   __  _ __   _ | |/ /__ * ___  | | ********
*** |  /|  // _ \ \ / /| | | ||  __// _ \ / _ \ | | ********
*** | |   | | | () | >  < \ || || |  | () | () || |  ****
*** _|   ||  ___/ //_\ __  |_|   _/ _/ __/ ****
****                       __ / /                          *****
************************* / / *******************************

2022-01-30 14:00:50,254 launcher.py[line:45] INFO ProxyPool Version: 2.4.0
2022-01-30 14:00:50,255 launcher.py[line:50] INFO ProxyPool configure HOST: <IP_ADDRESS>
2022-01-30 14:00:50,255 launcher.py[line:51] INFO ProxyPool configure PORT: 5010
2022-01-30 14:00:50,256 launcher.py[line:52] INFO ProxyPool configure PROXY_FETCHER: ['freeProxy01', 'freeProxy02', 'freeProxy03', 'freeProxy04', 'freeProxy05', 'freeProxy06', 'freeProxy07', 'freeProxy08', 'freeProxy09', 'freeProxy10']

*** ______  ********************* ______ *********** _  ********
*** | ___ _ ******************** | ___ \ ********* | | ********
*** | |/ / _ __   __  _ __   _ | |/ /__ * ___  | | ********
*** |  /|  // _ \ \ / /| | | ||  __// _ \ / _ \ | | ********
*** | |   | | | () | >  < \ || || |  | () | () || |  ****
*** _|   ||  ___/ //_\ __  |_|   _/ _/ __/ ****
****                       __ / /                          *****
************************* / / *******************************

2022-01-30 14:00:50,258 launcher.py[line:45] INFO ProxyPool Version: 2.4.0
2022-01-30 14:00:50,259 launcher.py[line:50] INFO ProxyPool configure HOST: <IP_ADDRESS>
2022-01-30 14:00:50,259 launcher.py[line:51] INFO ProxyPool configure PORT: 5010
2022-01-30 14:00:50,260 launcher.py[line:52] INFO ProxyPool configure PROXY_FETCHER: ['freeProxy01', 'freeProxy02', 'freeProxy03', 'freeProxy04', 'freeProxy05', 'freeProxy06', 'freeProxy07', 'freeProxy08', 'freeProxy09', 'freeProxy10']
2022-01-30 14:00:50,397 launcher.py[line:58] INFO ============ DATABASE CONFIGURE ================
2022-01-30 14:00:50,397 launcher.py[line:58] INFO ============ DATABASE CONFIGURE ================
2022-01-30 14:00:50,397 launcher.py[line:59] INFO DB_TYPE: REDIS
2022-01-30 14:00:50,397 launcher.py[line:59] INFO DB_TYPE: REDIS
2022-01-30 14:00:50,397 launcher.py[line:60] INFO DB_HOST: <IP_ADDRESS>
2022-01-30 14:00:50,397 launcher.py[line:60] INFO DB_HOST: <IP_ADDRESS>
2022-01-30 14:00:50,398 launcher.py[line:61] INFO DB_PORT: 6379
2022-01-30 14:00:50,398 launcher.py[line:61] INFO DB_PORT: 6379
2022-01-30 14:00:50,398 launcher.py[line:62] INFO DB_NAME: 0
2022-01-30 14:00:50,398 launcher.py[line:62] INFO DB_NAME: 0
2022-01-30 14:00:50,398 launcher.py[line:63] INFO DB_USER:
2022-01-30 14:00:50,398 launcher.py[line:63] INFO DB_USER:
2022-01-30 14:00:50,398 launcher.py[line:64] INFO =================================================
2022-01-30 14:00:50,398 launcher.py[line:64] INFO =================================================
2022-01-30 14:00:50,404 redisClient.py[line:149] ERROR redis connection error: Error 111 connecting to <IP_ADDRESS>:6379. Connection refused.
Traceback (most recent call last):
File "/usr/local/lib/python3.6/site-packages/redis/connection.py", line 607, in connect
sock = self._connect()
File "/usr/local/lib/python3.6/site-packages/redis/connection.py", line 671, in _connect
raise err
File "/usr/local/lib/python3.6/site-packages/redis/connection.py", line 659, in _connect
sock.connect(socket_address)
ConnectionRefusedError: [Errno 111] Connection refused
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/app/db/redisClient.py", line 144, in test
self.getCount()
File "/app/db/redisClient.py", line 130, in getCount
proxies = self.getAll(https=False)
File "/app/db/redisClient.py", line 112, in getAll
items = self.__conn.hvals(self.name)
File "/usr/local/lib/python3.6/site-packages/redis/commands/core.py", line 3825, in hvals
return self.execute_command("HVALS", name)
File "/usr/local/lib/python3.6/site-packages/redis/client.py", line 1170, in execute_command
conn = self.connection or pool.get_connection(command_name, **options)
File "/usr/local/lib/python3.6/site-packages/redis/connection.py", line 1506, in get_connection
connection.connect()
File "/usr/local/lib/python3.6/site-packages/redis/connection.py", line 611, in connect
raise ConnectionError(self._error_message(e))
redis.exceptions.ConnectionError: Error 111 connecting to <IP_ADDRESS>:6379. Connection refused.
2022-01-30 14:00:50,408 launcher.py[line:39] INFO exit!
2022-01-30 14:00:50,403 redisClient.py[line:149] ERROR redis connection error: Error 111 connecting to <IP_ADDRESS>:6379. Connection refused.
Traceback (most recent call last):
File "/usr/local/lib/python3.6/site-packages/redis/connection.py", line 607, in connect
sock = self._connect()
File "/usr/local/lib/python3.6/site-packages/redis/connection.py", line 671, in _connect
raise err
File "/usr/local/lib/python3.6/site-packages/redis/connection.py", line 659, in _connect
sock.connect(socket_address)
ConnectionRefusedError: [Errno 111] Connection refused
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/app/db/redisClient.py", line 144, in test
self.getCount()
File "/app/db/redisClient.py", line 130, in getCount
proxies = self.getAll(https=False)
File "/app/db/redisClient.py", line 112, in getAll
items = self.__conn.hvals(self.name)
File "/usr/local/lib/python3.6/site-packages/redis/commands/core.py", line 3825, in hvals
return self.execute_command("HVALS", name)
File "/usr/local/lib/python3.6/site-packages/redis/client.py", line 1170, in execute_command
conn = self.connection or pool.get_connection(command_name, **options)
File "/usr/local/lib/python3.6/site-packages/redis/connection.py", line 1506, in get_connection
connection.connect()
File "/usr/local/lib/python3.6/site-packages/redis/connection.py", line 611, in connect
raise ConnectionError(self._error_message(e))
redis.exceptions.ConnectionError: Error 111 connecting to <IP_ADDRESS>:6379. Connection refused.
2022-01-30 14:00:50,409 launcher.py[line:39] INFO exit!
如何修改呀

数据库 本地是能连上的

已解决


GhostScript error when displaying inline Tree structure for Jupyter notebook

I just reinstalled my system including Jupyter notebook and nltk, and found out that the inline display of tree as png file which used to work like a charm is now broken.
First, relevant installation info
nltk (3.2.1)
jupyter (1.0.0)
jupyter-client (4.2.2)
jupyter-console (4.1.1)
jupyter-core (4.1.0)
Also
GPL Ghostscript 9.18 (2015-10-05)
I experimented on both python3.5 and python2.7, but this shouldn't be relevant.
The error message is as follows
---------------------------------------------------------------------------
IOError                                   Traceback (most recent call last)
/home/nykh/Documents/cs224u/program/local/lib/python2.7/site-packages/IPython/core/formatters.pyc in __call__(self, obj)
    341             method = _safe_get_formatter_method(obj, self.print_method)
    342             if method is not None:
--> 343                 return method()
    344             return None
    345         else:

/home/nykh/Documents/cs224u/program/local/lib/python2.7/site-packages/nltk/tree.pyc in _repr_png_(self)
    727                             '-q -dEPSCrop -sDEVICE=png16m -r90 -dTextAlphaBits=4 -dGraphicsAlphaBits=4 -dSAFER -dBATCH -dNOPAUSE -sOutputFile={0:} {1:}'
    728                             .format(out_path, in_path).split())
--> 729             with open(out_path, 'rb') as sr:
    730                 res = sr.read()
    731             os.remove(in_path)

IOError: [Errno 2] No such file or directory: u'/tmp/tmppncGPb.png'

Apparently, the temp png file is not emitted by GhostScript, which complains
Error: /undefinedresult in --stringwidth--
Operand stack:
   --nostringval--   0   12   67   0   0   (test)
Execution stack:
   %interp_exit   .runexec2   --nostringval--   --nostringval--   --nostringval--   2   %stopped_push   --nostringval--   --nostringval--   --nostringval--   false   1   %stopped_push   1977   1   3   %oparray_pop   1976   1   3   %oparray_pop   --nostringval--   1960   1   3   %oparray_pop   1852   1   3   %oparray_pop   --nostringval--   %errorexec_pop   .runexec2   --nostringval--   --nostringval--   --nostringval--   2   %stopped_push   --nostringval--   --nostringval--   --nostringval--   --nostringval--   %array_continue   --nostringval--   --nostringval--   --nostringval--   %array_continue   --nostringval--
Dictionary stack:
   --dict:1201/1684(ro)(G)--   --dict:0/20(G)--   --dict:83/200(L)--   --dict:23/50(L)--
Current allocation mode is local
Current file position is 7312
GPL Ghostscript 9.18: Unrecoverable error, exit code 1

I wonder whether it's the way that _repr_png calls GS that causes the GhostScript error
subprocess.call([find_binary('gs', binary_names=['gswin32c.exe', 'gswin64c.exe'], env_vars=['PATH'], verbose=False)] +
                            '-q -dEPSCrop -sDEVICE=png16m -r90 -dTextAlphaBits=4 -dGraphicsAlphaBits=4 -dSAFER -dBATCH -dNOPAUSE -sOutputFile={0:} {1:}'
                            .format(out_path, in_path).split())

@nykh can you post the code the cause the error in the traceback? We can help you faster/better with a minimal working example =)

Seems like the latest version of GPL Ghostscript causes the conversion from .ps -> .png to fail.

Hi @alvations
It can be reproduced as below
(in ipython notebook)
import nltk
nltk.tree.Tree.fromstring("(test (this tree))")

So GhostScript is updated! Interesting...
On Mon, May 2, 2016 at 7:48 PM, alvations<EMAIL_ADDRESS>wrote:

Seems like the latest version of GPL Ghostscript causes the conversion
from .ps -> .png to fail.
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/nltk/nltk/issues/1387#issuecomment-216423409

I just checked on converting a .ps -> .png with Ghostscript 9.18. It works with:
$ wget www.d.umn.edu/~tpederse/Pubs/cicling2003-3.ps
$ gs -q -dEPSCrop -sDEVICE=png16m -r90 -dTextAlphaBits=4 -dGraphicsAlphaBits=4 -dSAFER -dBATCH -dNOPAUSE -sOutputFile=output.png cicling2003-3.ps

I think the problem might be deeper in with the latest version of Tkinter.

Interesting, I confirm I can generate output.png on my system... So maybe
the problem is with how the .ps is generated?? oh no :(
On Mon, May 2, 2016 at 8:25 PM, alvations<EMAIL_ADDRESS>wrote:

I just checked on converting a .ps -> .png with Ghostscript 9.18. It
works with:
$ wget www.d.umn.edu/~tpederse/Pubs/cicling2003-3.ps
$ gs -q -dEPSCrop -sDEVICE=png16m -r90 -dTextAlphaBits=4 -dGraphicsAlphaBits=4 -dSAFER -dBATCH -dNOPAUSE -sOutputFile=output.png cicling2003-3.ps
I think the problem might be deeper in with the latest version of Tkinter.
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/nltk/nltk/issues/1387#issuecomment-216426691

Hi there,
I see that this issue has been open since May of last year. Has there been any progress since?
By the way, I confirm that the issue is in generating the ps file from the tree object.
Thanks,
Kris

I had this issue and it turns out fonts were the problem. https://stackoverflow.com/a/42393994/3163618

Hi! I find pretty similar problem. When I am trying to do something like this in Jupyter Notebook:
cp = nltk.RegexpParser(pattern)
cs = cp.parse(sent)
cs

I returns this error:
---------------------------------------------------------------------------
FileNotFoundError                         Traceback (most recent call last)
~\Anaconda3\lib\site-packages\IPython\core\formatters.py in __call__(self, obj)
    343             method = get_real_method(obj, self.print_method)
    344             if method is not None:
--> 345                 return method()
    346             return None
    347         else:

~\Anaconda3\lib\site-packages\nltk\tree.py in _repr_png_(self)
    819                 raise LookupError
    820
--> 821             with open(out_path, 'rb') as sr:
    822                 res = sr.read()
    823             os.remove(in_path)

FileNotFoundError: [Errno 2] No such file or directory: 'C:\\Users\\Vadbeg\\AppData\\Local\\Temp\\tmp7o7mkl7t.png'

But still outputs result:
Tree('S', [('Europian', 'JJ'), ('authorities', 'NNS'), ('fined', 'VBD'), ('Google', 'NNP'), Tree('NP', [('a', 'DT'), ('record', 'NN')]), ('$', '$'), ('5.1', 'CD'), ('billion', 'CD'), ('on', 'IN'), ('Wednesday', 'NNP'), ('for', 'IN'), ('abusing', 'VBG'), ('its', 'PRP$'), Tree('NP', [('power', 'NN')]), ('in', 'IN'), Tree('NP', [('the', 'DT'), ('mobile', 'JJ'), ('phone', 'NN')]), Tree('NP', [('market', 'NN')]), ('and', 'CC'), ('ordered', 'VBD'), Tree('NP', [('the', 'DT'), ('company', 'NN')]), ('to', 'TO'), ('alter', 'VB'), ('its', 'PRP$'), ('practices', 'NNS')])

This issue is pretty old, but it is still doesn't work.

Just simply put repr()
cs.__repr__()


RwLockReadGuard and RwLockWriteGuard should only be Sync when RawRwLock is

Currently RwLockReadGuards are marked as Sync so long as the contained type is, without having the same bound on the RawRwLock type:
https://github.com/Amanieu/parking_lot/blob/ecfe20bf5b7f8b06c7a39afd53cee88a99ce07db/lock_api/src/rwlock.rs#L878
This means that even if an implementer marks their guard as GuardNoSend, it's actually possible to send guard objects across threads using references to them (references are marked as Send so long as the underlying type is Sync).
Much like MappedMutexGuard this should probably only be Sync when the raw lock is.
An example of sending parking_lot's non sendable guard objects across threads:
use parking_lot::RwLock;
use crossbeam_utils::thread;

fn is_send<T: Send>(_: &T) {}

fn main() {
    let lock = RwLock::new(42);
    let read_guard = lock.read();
    // RwLockReadGuard itself is not Send-able, uncommenting
    // the line below causes a compilation failure.
    //is_send(&read_guard);

    thread::scope(|s| {
        let guard_ref = &read_guard;

        s.spawn(move |_| {
            // But they can be sent as a reference.
            let sent_lock_guard = guard_ref;
            println!("In thread: {:p}", sent_lock_guard);
        });
        println!("In main:   {:p}", &read_guard);
    });
}

https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=625dd71fdcd34658f0c2d2752a86ca0e
(Issue found by @sslab-gatech's Rust group)

I believe this is not a problem since the only thing you can do with a &RwLockReadGuard is dereference it to access the underlying data. There is no interaction with the RawRwLock itself so it should still be sound.

Oh right, the problem is the:
pub fn rwlock(s: &Self) -> &'a RwLock<R, T>
method which would allow you to get a reference to the underlying RwLock object, which might not itself be safe across threads.

Ah good point, I forgot about that one. I will adjust the trait bounds.


MRIcroGL colormaps

Here is a collection of all MRIcroGL colormaps converted to NiiVue JSON format. I suggest discretion in including some of these. Tools like JetFighter will nag people who use color schemes which are considered to have poor accessibility and accuracy features. I include many of these merely for historical purposes. A better curated list would help. Some of the color maps are not perfect copies of original 256-color tables: those use interpolation for each index to coerce integer values of 0..255, and also can model non-linear functions. Here, the color tables are created with a small number of nodes, with linear interpolation between nodes.
The MRIcroGL color editor allows users to interactively modify colormaps. It also allows user to save colormaps (see Help/MouseGestures for OS dependent modifier keys). In future releases, if the user specifies saving the file with the extension '.json', it will export the color map to NiiVue format.

@neurolabusc, these new JSON colormaps omit the alpha channel. Is this intentional? The existing NiiVue colormaps include alpha, and the MRIcroGL luts also seem to include the alpha channel in the node definitions.

Try these


main: Add ".exe" to the executable file name on Windows

The purpose of this is to avoid having to rename executable files all the time.

looks good


Normalizing timestamps

Hi,
Just for curiosity,
does it make sense to somehow normalize timestamps or time intervals in this work?

does it make sense to somehow normalize timestamps or time intervals in this work?

It surely does.
Just review the log-likelihood with K=1:
\sum_{i:t_i < T} \log \lambda(t_i) - \int_{t=0}^{T} \lambda(t) dt
The integral term is approximately the expected # of event tokens in the sequence in (0,T], regardless of time unit.
Then changing the unit of dt will affect the level of \lambda(t), thus affecting the magnitude of the sum term.
You can normalize your time stamps to the level you feel comfortable with :-)


support mlx as backend?

Is it possible to support MLX as backend? That would be great for local development environment.

Noted. Why not Ollama?

I think mainly for performance, because mlx is designed specifically for apple hardware so it is optimized to leverage all the features.

Ollama is surely fast for inference, being backend by llama.cpp, but having direct Apple MLX can speed up the process fine-tuning, use in dspy, without having to expot to gguf and convert to ollama.
Direct support would be amazing.

MLX generation works with the OpenAI model. Use MLX-LM server:
python -m mod_server --model berkeley-nest/Starling-LM-7B-alpha --port 11434
Then you can call it from DSPy.
llm = dspy.OpenAI(model_type="chat", api_base="http://localhost:11434/v1/")

How about for fine tuning? Does it also work?


Can not cast an empty data.table

Describe the issue
Dear,
Thanks for development maftools, But I got some error when I process my maf (CCLE_mutations.csv) download from https://depmap.org/portal/download/ .
When I try to use  plotmafSummary, I got following error:
Error in dcast.data.table(data = maf.con.class.summary, formula = Tumor_Sample_Barcode ~  :
  Can not cast an empty data.table
Warning message:
In titv(maf = maf, useSyn = TRUE, plot = FALSE) :
  Non standard Ti/Tv class: 5499TRUE

Command
Please post your commands and the output (errors or any unexpected output)
data_mutations <- read.csv('CCLE_mutations.csv',
                     header = T,
                     stringsAsFactors = F)

data_mutations$Tumor_Seq_Allele2 <- rep(NA, dim(data_mutations)[1])
data_mutations$Tumor_Sample_Barcode <- data_mutations$DepMap_ID
laml = read.maf(maf = data_mutations)

plotmafSummary(maf = laml, rmOutlier = TRUE, addStat = 'median', dashboard = TRUE, titvRaw = FALSE)

Session info
Run sessionInfo() and post the output below
R version 4.0.3 (2020-10-10)
Platform: x86_64-w64-mingw32/x64 (64-bit)
Running under: Windows 10 x64 (build 18363)

Matrix products: default

locale:
[1] LC_COLLATE=Chinese (Simplified)_China.936  LC_CTYPE=Chinese (Simplified)_China.936
[3] LC_MONETARY=Chinese (Simplified)_China.936 LC_NUMERIC=C
[5] LC_TIME=Chinese (Simplified)_China.936

attached base packages:
[1] stats     graphics  grDevices utils     datasets  methods   base

other attached packages:
[1] maftools_2.6.05 tibble_3.0.4    configr_0.3.5   ggplot2_3.3.3   dplyr_1.0.2     devtools_2.3.2  usethis_2.0.0

loaded via a namespace (and not attached):
 [1] Rcpp_1.0.5         RColorBrewer_1.1-2 compiler_4.0.3     pillar_1.4.7       prettyunits_1.1.1  remotes_2.2.0
 [7] tools_4.0.3        testthat_3.0.1     digest_0.6.27      pkgbuild_1.2.0     pkgload_1.1.0      lattice_0.20-41
[13] jsonlite_1.7.2     memoise_1.1.0      lifecycle_0.2.0    gtable_0.3.0       pkgconfig_2.0.3    rlang_0.4.9
[19] Matrix_1.2-18      cli_2.2.0          rstudioapi_0.13    yaml_2.2.1         curl_4.3           stringr_1.4.0
[25] withr_2.3.0        desc_1.2.0         generics_0.1.0     fs_1.5.0           vctrs_0.3.6        rprojroot_2.0.2
[31] grid_4.0.3         tidyselect_1.1.0   data.table_1.13.4  glue_1.4.2         R6_2.5.0           processx_3.4.5
[37] fansi_0.4.1        survival_3.2-7     sessioninfo_1.1.1  callr_3.5.1        purrr_0.3.4        magrittr_2.0.1
[43] splines_4.0.3      scales_1.1.1       ps_1.5.0           ellipsis_0.3.1     assertthat_0.2.1   colorspace_2.0-0
[49] stringi_1.5.3      ini_0.3.1          RcppTOML_0.1.7     munsell_0.5.0      crayon_1.3.4

Could you please give me more information about it?
Best.
Zhang

Hi,
It seems that the values in Variant_Type column are misformed. It should be SNP INS or DEL. Could you please double-check this?

Hi,
It seems that the values in Variant_Type column are misformed. It should be SNP INS or DEL. Could you please double-check this?

Hi,
It seems that the values in Variant_Type column are misformed. It should be SNP INS or DEL. Could you please double-check this?

Dear PoisonAlien,
Thanks for your so qiuickly reply. I think you are right by run following comand:
r unique(data_mutations$Variant_Type)

[1] "SNP" "DEL" "INS" "DNP" "TNP" NA

Does I must remove all another Variant_Type fistly?
Best.
Zhang

Hi,
It seems that the values in Variant_Type column are misformed. It should be SNP INS or DEL. Could you please double-check this?

Dear PoisonAlien,
Thanks for your so qiuickly reply. I think you are right by run following comand:
r unique(data_mutations$Variant_Type)

[1] "SNP" "DEL" "INS" "DNP" "TNP" NA

Does I must remove all another Variant_Type fistly?
Best.
Zhang

Wait, I just saw your code.
data_mutations$Tumor_Seq_Allele2 <- rep(NA, dim(data_mutations)[1])

Is there a reason for setting Tumor_Seq_Allele2 to NA? These are the mutated alleles that are used to plot TiTv events. Don't you have this information in the CSV file?

Wait, I just saw your code.
data_mutations$Tumor_Seq_Allele2 <- rep(NA, dim(data_mutations)[1])

Is there a reason for setting Tumor_Seq_Allele2 to NA? These are the mutated alleles that are used to plot TiTv events. Don't you have this information in the CSV file?

Wait, I just saw your code.
data_mutations$Tumor_Seq_Allele2 <- rep(NA, dim(data_mutations)[1])

Is there a reason for setting Tumor_Seq_Allele2 to NA? These are the mutated alleles that are used to plot TiTv events. Don't you have this information in the CSV file?

Yes, I find this filed is missing in the csv, Actually I am a rookie for maf file, I think this is because it is the sequencing of the cell line and there is no need to consider the issue of tumor purity. So I replace it with NA, could you please tell me its right?
Best.
Zhang

Wait, I just saw your code.
data_mutations$Tumor_Seq_Allele2 <- rep(NA, dim(data_mutations)[1])

Is there a reason for setting Tumor_Seq_Allele2 to NA? These are the mutated alleles that are used to plot TiTv events. Don't you have this information in the CSV file?

Yes, I find this filed is missing in the csv, Actually I am a rookie for maf file, I think this is because it is the sequencing of the cell line and there is no need to consider the issue of tumor purity. So I replace it with NA, could you please tell me its right?
Best.
Zhang

I downloaded the CCLE_mutations.csv file. It seems they don't have Tumor_Seq_Allele2 column but instead, alt alleles are stored in Tumor_Seq_Allele1. Renaming that column to Tumor_Seq_Allele2 should work fine.
data_mutations <- data.table::fread("~/Downloads/CCLE_mutations.csv")

# Rename columns
colnames(data_mutations)[which(colnames(data_mutations) == "Tumor_Seq_Allele1")] = "Tumor_Seq_Allele2"
colnames(data_mutations)[which(colnames(data_mutations) == "DepMap_ID")] = "Tumor_Sample_Barcode"

cc = maftools::read.maf(cc)
maftools::plotmafSummary(cc)

I downloaded the CCLE_mutations.csv file. It seems they don't have Tumor_Seq_Allele2 column but instead, alt alleles are stored in Tumor_Seq_Allele1. Renaming that column to Tumor_Seq_Allele2 should work fine.
data_mutations <- data.table::fread("~/Downloads/CCLE_mutations.csv")

# Rename columns
colnames(data_mutations)[which(colnames(data_mutations) == "Tumor_Seq_Allele1")] = "Tumor_Seq_Allele2"
colnames(data_mutations)[which(colnames(data_mutations) == "DepMap_ID")] = "Tumor_Sample_Barcode"

cc = maftools::read.maf(cc)
maftools::plotmafSummary(cc)

I downloaded the CCLE_mutations.csv file. It seems they don't have Tumor_Seq_Allele2 column but instead, alt alleles are stored in Tumor_Seq_Allele1. Renaming that column to Tumor_Seq_Allele2 should work fine.
data_mutations <- data.table::fread("~/Downloads/CCLE_mutations.csv")

# Rename columns
colnames(data_mutations)[which(colnames(data_mutations) == "Tumor_Seq_Allele1")] = "Tumor_Seq_Allele2"
colnames(data_mutations)[which(colnames(data_mutations) == "DepMap_ID")] = "Tumor_Sample_Barcode"

cc = maftools::read.maf(cc)
maftools::plotmafSummary(cc)

Dear PoisonAlien,
I am very grateful for your help. I mistakenly believe that Tumor_Seq_Allele1 and Tumor_Seq_Allele2 have completely different meanings because I read the instructions in https://docs.gdc.cancer.gov/Data/File_Formats/MAF_Format/ . Thank you for your professional and timely help.
Best.
Zhang

I downloaded the CCLE_mutations.csv file. It seems they don't have Tumor_Seq_Allele2 column but instead, alt alleles are stored in Tumor_Seq_Allele1. Renaming that column to Tumor_Seq_Allele2 should work fine.
data_mutations <- data.table::fread("~/Downloads/CCLE_mutations.csv")

# Rename columns
colnames(data_mutations)[which(colnames(data_mutations) == "Tumor_Seq_Allele1")] = "Tumor_Seq_Allele2"
colnames(data_mutations)[which(colnames(data_mutations) == "DepMap_ID")] = "Tumor_Sample_Barcode"

cc = maftools::read.maf(cc)
maftools::plotmafSummary(cc)

Dear PoisonAlien,
I am very grateful for your help. I mistakenly believe that Tumor_Seq_Allele1 and Tumor_Seq_Allele2 have completely different meanings because I read the instructions in https://docs.gdc.cancer.gov/Data/File_Formats/MAF_Format/ . Thank you for your professional and timely help.
Best.
Zhang


ZEPPELIN-3146. Fixed Checkstyle errors in alluxio module

What is this PR for?
Fix the Checkstyle errors and warning in the alluxio module.
What type of PR is it?
Improvement
Todos

[ ] - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/ZEPPELIN-3146

How should this be tested?

CI pass

Screenshots (if appropriate)
Questions:

Does the licenses files need update? no
Is there breaking changes for older versions? no
Does this needs documentation? no

@felixcheung Right, I currently turn off checkstyle, after all the modules fix the code style, will turn it on in root pom file

I just reran the failing builds, as suggested by @zjffdu in ZEPPELIN-3182, and all are green now.

LGTM


Why did close client and peers manually

https://github.com/megaease/easegress/blob/e0bdd3f0a76ede3cd6ef6ef7b714af60dd28383d/pkg/cluster/cluster.go#L614
T think ectd clients and peers is already closed in *embed.Etcd.Close(), there is no need to close it again.

Thx for your careful review, your opinion is right even it seems repeatedly close for it won't cause errors, we will refine it.

Thx for your careful review, your opinion is right even it seems repeatedly close for it won't cause errors, we will refine it.

nice

@jxd134 Thx for reminding.
In usual,
...
case <-s.Server.ReadyNotify():
		s.Close()
...

This branch will cover this shutdown logic completely. But if we enter HardStop logic, I think we should close these clients and peers manually since the HardStop in embed.Etcd only sends a signal to [quit the run function as here.
So I prefer to refine it like this:
unc closeEtcdServer(s *embed.Etcd) {
	select {
	case <-s.Server.ReadyNotify():
		s.Close()
		<-s.Server.StopNotify()
	default:
		s.Server.HardStop()
		for _, client := range s.Clients {
			if client != nil {
				client.Close()
			}
		}
		for _, peer := range s.Peers {
			if peer != nil {
				peer.Close()
			}
		}
		logger.Infof("hard stop server")
	}
}

Any further suggestions?

@jxd134 Thx for reminding.
In usual,
...
case <-s.Server.ReadyNotify():
	s.Close()
...

This branch will cover this shutdown logic completely. But if we enter HardStop logic, I think we should close these clients and peers manually since the HardStop in embed.Etcd only sends a signal to quit the run function as here.
So I prefer to refine it like this:
func closeEtcdServer(s *embed.Etcd) {
	select {
	case <-s.Server.ReadyNotify():
		s.Close()
		<-s.Server.StopNotify()
	default:
		s.Server.HardStop()
		for _, client := range s.Clients {
			if client != nil {
				client.Close()
			}
		}
		for _, peer := range s.Peers {
			if peer != nil {
				peer.Close()
			}
		}
		logger.Infof("hard stop server")
	}
}

Any further suggestions?

Yes.
I agree with you.
The clients and peers doesn't close in s.Server.HardStop(), so it need to be closed in default block.


make Swagger config files for Ensembl (x2)

See https://github.com/BiGCAT-UM/swagger2BioTools/commit/10389711c6bc9e3ddcf06a41b8d731f7b6fe2491


Update default settings.json experience

Summary of the Pull Request
Add comments and settings to settings.json for discoverability.
 I think we agreed that it would be better to have links to more relevant spots but those need to be created.
@cinnamon-msft could you create those aka.ms links so that I add them in? Or just let me know what to do here.
Also, should we be using FW links here instead? I think we said no, but I want to make sure.

@msftbot make sure @cinnamon-msft signs off on this

Given the state of our documentation, I can't give specific links. I think just the one aka.ms documentation link is fine.
Also, yes these are aka.ms links, not fwlinks. :)

I don’t think there is value in having a link above every section if every link is just the same link. It’s like saying “look here for specific documentation. NATCH! Got you, here’s the landing page.”

I didn't realize we didn't have "requestedTheme" already in the settings.json file. What are your thoughts on adding this setting as well? @microsoft/windows-console-team

Hey, should we rename requestedTheme? It doesn't make a lot of sense ... it's more of an applicationTheme.

should we rename requestedTheme? It doesn't make a lot of sense ... it's more of an applicationTheme.

This is probably fine, and would probably still be fine with #3327. I'm mildly worried that renaming the setting now means we're breaking everyone who's got it set currently, unless they manually change it, because we won't be supporting migrating from the old value. We're also breaking other things too so idk

I'm okay with changing it.


Can't install on windows

With current version of flow I can't install debug package on windows:
C:\dev\bugsnag-sourcemaps>node node_modules\flow-typed\dist\cli.js install -f 0.
30<EMAIL_ADDRESS> * flow-typed cache is old, rebasing...done.
 * found 1 matching libdefs.
UNCAUGHT ERROR: Error: Unable to find version information for 'debug_v2.x.x/flow
_>=v0.28.x'!
    at getCacheLibDefVersion$ (C:\dev\bugsnag-sourcemaps\node_modules\flow-typed
\dist\lib\libDefs.js:850:17)
    at tryCatch (C:\dev\bugsnag-sourcemaps\node_modules\regenerator-runtime\runt
ime.js:62:40)
    at GeneratorFunctionPrototype.invoke [as _invoke] (C:\dev\bugsnag-sourcemaps
\node_modules\regenerator-runtime\runtime.js:336:22)
    at GeneratorFunctionPrototype.prototype.(anonymous function) [as next] (C:\d
ev\bugsnag-sourcemaps\node_modules\regenerator-runtime\runtime.js:95:21)
    at tryCatch (C:\dev\bugsnag-sourcemaps\node_modules\regenerator-runtime\runt
ime.js:62:40)
    at invoke (C:\dev\bugsnag-sourcemaps\node_modules\regenerator-runtime\runtim
e.js:138:20)
    at C:\dev\bugsnag-sourcemaps\node_modules\regenerator-runtime\runtime.js:146
:13
    at process._tickCallback (internal/process/next_tick.js:103:7)

Thanks for the report. Will look into this in a little bit...

@jeffmo Thanks for looking into that. I have another issue: https://github.com/flowtype/flow-typed/issues/253#issuecomment-248668589, should I create a separate issue for it?

@szarouski: I just responded on that thread

I believe this should be fixed as of beta.11.
Going to close this out, but feel free to re-open if you're still having issues.
Thanks for the report and please keep the feedback coming! :)


Travis-CI: xcrun: error: unable to find utility "altool", not a developer tool or in PATH

Hi,
I have applied your instructions from https://kilianvalkhof.com/2019/electron/notarizing-your-electron-application/ to our existing CICD pipeline and get the following error:
Error: Failed to upload app to Apples notarization servers
xcrun: error: unable to find utility "altool", not a developer tool or in PATH
Any thoughts much appreciated

Caveat: I'm not a macOS developer, I'm only speculating based on the limited amount of information.
My guess is that your osx_image is not new enough. What is the value of that config in .travis.yml?

I had to manually select the current Xcode installation (maybe as I had a different Xcode version installed at some time). However I got the same error message as you and the below step resolved it.
sudo xcode-select -s /Applications/Xcode.app

@adgrace I'm not a MacOS developer either, but I overcame this same error. I was able to overcome this by installing Xcode through the App Store.

Not sure if this would fix yours, but it worked for me.

I solved this issue by running
sudo xcode-select -r

I had an existing, old XCode installed. Updated to the newest version, but it still didn't work until I ran sudo xcode-select -r per @myaisv. Thank you!

There are multiple answers to the original question and to subsequent questions, so I'm closing this.

I've tried both sudo xcode-select -s /Applications/Xcode.app and sudo xcode-select -r on Travis's xcode11.3 on Mac OS 10.13.6 and still receive the unable to find utility "altool", not a developer tool or in PATH error.
Build output here: https://travis-ci.org/github/trufflesuite/ganache/jobs/663721352#L3824
Implementation here: https://github.com/trufflesuite/ganache/blob/efdabb22feabff10f594447a842dd13dd8f14491/afterSignHook.js#L25-L34
Anyone have any thoughts on what could be wrong with my config?

My issue was that my travis config wasn't actually using the root-level osx_image directive of "xcode11.3"; this directive was being ignored due to my use of Travis' include matrix. The correct way to specify the osx_image when using an include matrix is as follows:
matrix:
  include:
  - os: osx
    osx_image: "xcode11.3"
  - os: linux
    dist: bionic

Once I made this change I didn't need to try the xcode-select solutions above.

The "altool" command doesn't exist In the $PATH in some version of system. and then we need to add it to the symbolic file. Ensure the "/usr/local/bin" path is in the $PATH variable.
ln -s /Applications/Xcode.app/Contents/Applications/Application\ Loader.app/Contents/Frameworks/ITunesSoftwareService.framework/Versions/A/Support/altool /usr/local/bin/altool

altool is not part of the Command Line Tools.
Create a symbolic link or add this to the path.
Xcode 12
/Applications/Xcode.app/Contents/Developer/usr/bin


Add option to deterine chipping size and stride by specifying size and buffer

I'd like to be able to analyze predictions in "focal tiles" which have no overlap with their neighbors (solid lines in the figure). But to obtain these tiles, I'd like to perform inference for larger tiles surrounding the focal tiles (based on a user-specified buffer) ("actual tiles", dashed lines in figure), then (in post-processing) clip off the buffer region to obtain the inference from the "focal tiles" only...and ultimately stitch them together. If this makes sense...could you please implement a way for the user to specify the size and buffer (in pixels or meters) and convert this internally to size and stride?

I'm not sure whether the size provided for this alternate approach should be the size of the focal (smaller) square or the actual (larger) tile. I'm thinking actual tile, so that we can standardize the size of the tile that is actually supplied to the model.
I believe it's as simple as computing stride as size-2*buffer, but please confirm you agree.
This issue has two parts:

[ ] Implement buffer specification during chipping (pre-processing)
[ ] Implement option to remove the buffer region predictions when reassembling chips during post-processing

The latter step will require somehow storing information on the buffer width from pre-processing so that it can be accessed during post-processing.

I agree that the size should be the size of the full tile, since that is consistent with the other methods of specifying the size/stride. I think your math is right, assuming you want the buffer in spatial units and not percent. I think you can handle the logic for computing the stride here.
One option for implementing the operation to remove the buffer would be add a new method to the RegionDetections class, called remove_buffer or something similar. It could take the amount to buffer and use the prediction_bounds_in_CRS attribute to compute a buffered region. Then, you could return a copy of the original object with the updated bounds (buffered in) and the detections attribute cropped to the new bounds. It looks like gpd.clip should allow you to do the later operation. You can follow the logic in subset_detections for returning an updated version of the object.


Added bio for Rob Conery (me)

Was asked by Sonia so here you go!

We've got a check that the image is square, looks like yours is just shy of that - want me to crop/resize or do you want to do it?

Shoot sorry Aaron I just saw this! If you don't mind - crop away!


[Spotify Player] "Set Volume to 75%" Message Typo

Extension
https://www.raycast.com/mattisssa/spotify-player
Description
The HUD confirmation message for the command "Set Volume to 75%" has a typo, displaying '25%' when it should say '75%'.
The typo can be seen at the following line.
Steps To Reproduce
Run "Set Volume to 75%" command
Current Behaviour
Message says 25%
Expected Behaviour
Message says 75%

Good catch, thanks!

This is now fixed @ethnzhng - thanks for the hint 🔥


feature request/discussion: add war file assembly support

Unless my grepping failed me, it doesn't appear to be supported. This isn't something I immediately need, but would be good to have at some point. Perhaps code from sbt can be ported?

There was a PR for it, the original author mentioned that there will be a new PR:
https://github.com/lihaoyi/mill/pull/321

yes, I have a working student that created code for war files and distzip but I will needs to go over the code before I can open a proper PR here.
I hope I will be able to do it this weekend

Given there's no immediate need, let's close this issue and move discussion to gitter

Some kind of duplicate to #321


Unexpected behavior when running xdp3.o

Hi,  I'm testing the xdp3.p4 which parse L2, L3 and action could be drop or pass.
The table is described like this:
table dstmactable {
        key = { hdr.ethernet.destination : exact; }
        actions = {
            Fallback_action;
            Drop_action;
        }
        default_action = Drop_action;
        implementation = hash_table(64);
    }

After loading xdp3, I found that all the packets were passed to the kernel.
My understanding is that if the default action of a table is Drop_action, Then if a table has no entries or the packet does not match the table entries, The default action will be executed on the packet. I didn't add any entries to the dstmactable table through a control plane program. So the packet should be the default action: they should be dropped . Is my understanding right?
But the fact seems not like what I thought.

Later I verified that the packet matching was actually executed in the order of the actions which defined in the table dstmactable. The first action in the dstmactable table is Fallback_action.So the packages passed.
I want to ask what is the default_action used for? Did my previous understanding of default_action be wrong?

It looks like a bug in our compiler
the generated xdp3.c code is below:
So it first lookup ingress_dstmactable, (in your case, it's empty)
then it looks up the Ingress_dstmactable_defaultAction, using key=0
So the first entry in this table will be executed.
  value = BPF_MAP_LOOKUP_ELEM(Ingress_dstmactable, &key);
                if (value == NULL) {
                    /* miss; find default action */
                    hit = 0;
                    value = BPF_MAP_LOOKUP_ELEM(Ingress_dstmactable_defaultAction, &ebpf_zero);
                } else {
                    hit = 1;
                }
                if (value != NULL) {
                    /* run action */
                    switch (value->action) {
                        case Ingress_Fallback_action:
                        {
xoutdrop_0 = false;
                        }
                        break;
                        case Ingress_Drop_action:
                        {
xoutdrop_0 = true;
                        }
                        break;

@mbudiu-vmw  where do we process the
default_action = Drop_action;?

The table contents should be setup by the control-plane, which should be executed at the beginning.
The control-plane is generated in the header file, in a function bracketed with #if CONTROL_PLANE.
The control-plane should install the Drop action into the Ingress_dstmactable_defaultAction table. Is it doing that?

I didn't use control plane to populate the table.  In the generated code of xdp3.c:
value = BPF_MAP_LOOKUP_ELEM(Ingress_dstmactable, &key);
                if (value == NULL) {
                    /* miss; find default action */
                    hit = 0;
                    value = BPF_MAP_LOOKUP_ELEM(Ingress_dstmactable_defaultAction, &ebpf_zero);
                } else {
                    hit = 1;
                }
                if (value != NULL) {
                    /* run action */
                    switch (value->action) {
                        case Ingress_Fallback_action:
                        {
xoutdrop_0 = false;
                        }
                        break;
                        case Ingress_Drop_action:
                        {
xoutdrop_0 = true;
                        }
                        break;

At first , I think both of the Ingress_dstmactable_defaultAction and the Ingress_dstmactable should be empty.  And first it looks up the Ingress_dstmactable and value should be NULL .  And then it looks up the Ingress_dstmactable_defaultAction .
I guess what you mean is that the Ingress_dstmactable_defaultAction actions are the same as the Ingress_dstmactable actions before I run the control-plane.  So even if it looks up the Ingress_dstmactable_defaultAction , the first action is still the Fallback_action ?  So the packets r not dropped.
I notice the code which defines the default table's action in init_tables() in xdp3.h :
static void init_tables()
{
    u32 ebpf_zero = 0;
    {
        int tableFileDescriptor = BPF_OBJ_GET(MAP_PATH "/Ingress_dstmactable_defaultAction");
        if (tableFileDescriptor < 0) { fprintf(stderr, "map Ingress_dstmactable_defaultAction not loaded\n"); exit(1); }
        struct Ingress_dstmactable_value value = {
            .action = Ingress_Drop_action,
            .u = {.Ingress_Drop_action = {}},
        };
        int ok = BPF_USER_MAP_UPDATE_ELEM(tableFileDescriptor, &ebpf_zero, &value, BPF_ANY);
        if (ok != 0) { perror("Could not write in Ingress_dstmactable_defaultAction"); exit(1); }
    }
}

So if I want to run the P4 program correctly , I must run the control plane to redefine the default table by using the init_table() ？

yes, that's right. The control plane should first populate the table using init_tables().
Are you able to get it running with correct result?

Yes. After I run the control plane with init_tables() , everthing seems correct.
Thank you again for your help.


Select uses wrong border variable for height calculation

To get selects matching the size of text inputs, a calculation is done which includes the width of the border. However, it uses $border-width instead of $input-btn-border-width, which means if the two don't match, your selects have the wrong height.

Fixes #22011

#22068 was merged as an alternate fix for this. Thanks!


TimePicker SelectedTime setting value to null fix

I observed and was able to identify that the SelectedTime property on TimePicker will fail to display the initial value of a property that is bound to it. Upon initial load of the control WPF will set up the bindings before OnApplyTemplate is called. So while the control is being created the bindings for SelectedTime are applied. This kicks off a call SelectedTimePropertyChangedCallback with the value evaluated from the bindings. This in turn makes a call to change the TextProperty value. When TextProperty changes it calls SetSelectedTime(). SetSelectedTime() will in then change the SelectedTime property based on the Text of the _textBox that is retrieved from the control template. Since this does not yet exist it evaluates to empty. Since it evaluates to empty SelectedTime is set to null. Which kicks this chain off again. The end result being the SeletedTime value and the TextProperty value are now null and the _textBox.Text value ends up being null. Thus not displaying the time to the user.
This fix is to only call SetSelectedTime() from within the TextPropertyChangedCallback if the _textBox control is not null. This callback already had this code in there for updating the .Text property of the _textBox.
An alternative possible fix would be to update SetSelectedTime() to do an additional check to see if _textBox control is not null and only set SelectedTime if the control exists.
This PR also includes an example of the binding working in the demo project.

I was curious if there was anything else needed for this? This bug is preventing me from using the nuget package, instead I'm having to use my own fork.

Hi @jeffklawiter I had a quick look at it the other day, but wanted to come back and look at it again.  The reason being is that it is changing the API, and the API is modeled on the standard WPF DatePicker to maintain consistency.  So I wanted to have a closer look to see if we can make the fix without making an API change.

Hi @jeffklawiter
I was able to reproduce your issue.  I've implemented an alternate fix that doesn't change the API.


Add a simple way to create typed, runnable templates

Hello,
It is often required to compile a template from a string, and then use it several times. For instance:
// once on startup
Engine.Razor.Compile(File.ReadAllText(templatePath), "MyKey", typeof(MyModel));
// then
var output = Engine.Razor.Run("MyKey", typeof(MyModel), model);

This PR adds a simple way to register typed runnable templates:
// once on startup
_templateRunner = Engine.Razor.CompileRunnable<MyModel>(File.ReadAllText(templatePath));
// then
var output = _templateRunner.Run(model);

I do not think that the failed build is related to my modifications. Please tell me if I need to change anything.

I just had a quick look. Overall this feels like a good change, but I would prefer it as extension method to the interface. This is something we could easily move out into a separate package if we want to, therefore I think this fact should be reflected in the code.
by the way if I don't react for a longer time feel free to ping me (best time is friday or saturday ;))

But it is already ax extension method on IRazorEngineService .

Oh my bad, sorry. Than everything looks fine, thank you. Will take a deep look and merge on the weekend :)

Ok, nice and clean patch. Sorry for being a bit slow :)
One question though: What about the other overloads of Run (provided via extension methods). Should we provide them here as well?
My suggestion would be to have only an interface ITemplateRunner public and the class itself internal. This interface would only have the most generic Run method and everything else is provided as Extension methods (like on IRazorEngineService).
What do you think?

The changes that you suggest are very coherent with the rest of the code base. I like coherent code bases :)
I will try to update my PR today.

I just pushed the addition of ITemplateRunner and TemplateRunnerExtensions.

Perfect! Thanks!


Voronoi stack

Necessary for https://github.com/FormidableLabs/victory-chart/pull/555.

@boygirl can u take a look?
@stefvhuynh can u fix conflicts?

Could this have anything to do with https://codesandbox.io/s/4z6ww6w7m0
it seems to me that voronoi isn't working as expected with horizontal bars with holes (gantt chart)?

@sibelius @f0rr0
The corresponding PR in victory-chart has some issues that need to be resolved. @stefvhuynh is off the project, and I've let these two slip through the cracks. Apologies. I will pick these back up next week.

@boygirl tks for the hard work on this package


PUBDEV-6300 - Flows throws error on an empty path while performing 'Import Files' operation

https://0xdata.atlassian.net/browse/PUBDEV-6300

This how it got resolved:

Once approved, I'll promptly release a new version and create H2O-3 PR.

@honzasterba Sure, great idea. It is going to be in the H2O-3 PR. Let's release flow first and review it all at once.

Sure @honzasterba :+1: Good idea.This exception comes from HDFS persist module, which is bad.


Migrate browser tests to BrowserStack and/or Karma

Issues:

SauceLabs browser runs sometimes randomly fail
Testem might be sensitive to history (refresh/back/etc) changes, Karma might not (because history repo uses Karma to test in browsers)
Cycle History is not being tested in multiple browsers due to the item above
Review which browsers should we be testing against

I can attempt to tackle the switch to Karma, as I have some experience with it on some other projects.

Done by Tylor. Thanks!
(I think we could keep Testem for DOM and HTTP, for the time being. History was the critical one)


proposal: net/url: add QueryParser and QueryEncoder interfaces

Summary
I would like to propose adding new interfaces to net/url to allow users to have control over url query string parsing and encoding implementations.
This can be done in a backwards compatible manner by

introducing the interface
providing a default implementation of the interface that implements current behavior
exposing the default implementations as package level variables
updating call sites in the standard library to accept interface values to prefer over the default implementation

With the DefaultQueryParser and DefaultQueryEncoder being package level variables, a user can set the implementations once in main or init.  This allows the user to have confidence that their chosen implementation will be used, even if some usages have not yet been updated to accept a custom implementation.
This approach allows users to gradually widen their API to accept a QueryParser or QueryEncoder, allowing for implementation to be spread over multiple releases if necessary.
Proposed Interface Addition
var (
    DefaultQueryParser QueryParser = qsParser{}
    DefaultQueryEncoder QueryEncoder = qsParser{}
)

type QueryParser {
    Parse(string) (Values, error)
}

type QueryEncoder {
    Encode(Values) (string, error)
}

type qsParser struct{}

func (qsParser) Parse(s string) (Values, error) {
    // body would be the current body of ParseQuery
}

func (qsParser) Encode(v Values) (string, error) {
    // body would be the current body of Values.Encode
}

// update existing apis to use the DefaultQueryParser
// and DefaultQueryEncoder

func ParseQuery(s string) (Values, error) {
    return DefaultQueryParser.Parse(s)
}

func (v Values) Encode() string {
     s, _ := DefaultQueryEncoder.Encode()
    return s
}

Rationale
Other systems have their own interpretations of the url RFCs, which are often at odds with how go interprets them. This creates situations where a behavior can be a security issue for one user, but an intentional and relied upon behavior for others.  There is no single implementation that can serve all users.
By allowing custom implementations to be supplied, we're able to provide a safe default that covers the majority of use cases, but still allow users with very specific needs the flexibility to provide their own implementations.
Users of the package include http.Server and httputil.ReverseProxy`.  Both are too large to reasonably expect users to fork in order to call their own parsing and encoding implementations.
Historical Issues
There have been a number of issues surrounding query string parsing and encoding.  Security issues have caused a number of backwards incompatible changes, which then motivated other changes to allow prior behavior to be restored.
For users sensitive to these changes, some of the above issues caused operational disruption.  In other cases, the backwards compatibility breakages were in point releases.

https://github.com/golang/go/issues/54663
https://github.com/golang/go/issues/25192
https://github.com/golang/go/issues/49399
https://github.com/golang/go/issues/49683
https://github.com/golang/go/issues/45973

I don't think a global variable is a good idea: What happens if something parses a URL at init time? Or in a goroutine started at init time? Or if two places attempt to set the variable?
http.Request automatically calls ParseQuery to populate Request.Form on demand, but code that wants a different parser can always parse the query itself.
func httpHandler(w http.ResponseWriter, req *http.Request) {
  req.Form = myQueryParser(req.URL.RawQuery)
  // ...
}

ReverseProxy uses ParseQuery to sanitize forwarded URLs, but this behavior can be disabled:
// Go 1.20 Rewrite func:
proxy.Rewrite = func(r *httputil.ProxyRequest) {
  r.Out.URL.RawQuery = r.In.URL.RawQuery // preserve raw query string from inbound request
}

// Pre-1.20 Director func:
proxy.Director = func(r *http.Request) {
  // ...

  // Clear Request.Form before returning to disable query string sanitization.
  // Note that sanitization is not performed if Form is not set, so Director functions
  // that do not set Form (possibly implicitly by calling Request.FormValue) will never
  // sanitize the forwarded query.
  r.Form = nil
}


Origami-lib codebase is flakey

There are a lot of flake8 linting errors in origami-lib for a better and readable codebase we should remove them.
Also I suggest using something like yapf for auto linting the code and adding git hook pre_commit to it that way it would be easy to keep the codebase from flake8 linting errors.

Is this still relevant?

No this is resolved in refactor branch. I think we can close this.


Added some info arround extending profile service.

Related #4087 #4544
What issue does this PR address?
Docs around extending ASP.Net Core Identity integration ProfileService e.g. to include Identity roles
Does this PR introduce a breaking change?
No
Please check if the PR fulfills these requirements

[x] The commit follows our guidelines
[x] Unit Tests for the changes have been added (for bug fixes / features)

Other information:

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: rustybox sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


Additional homogenization and fixes of argument names

Ongoing
Resolves #441
Resolves #449
Resolves #445
Also re-orders some arguments of reproject (most used to least used), to make access easier.
Left to-do:

[x] Decide if we keep indexes and indexes_on_disk in the properties, or change those as well?
[x] Simplify the "checking nodata" mess in reproject.

@adehecq @atedstone This PR can be finished fairly quickly, we just need to decide:
Do we also rename the public properties Raster.indexes and Raster.indexes_on_disk to Raster.bands and Raster.bands_on_disk?
There were a lot more index argument to change to bands than anticipated in the end (we forgot about interp_points, value_at_coords, __init__ and show).

The problem would be that Raster._indexes and Raster.bands are the same thing while named differently, which is not super consistent... But it is only an internal thing to deal with really, aimed to make it easier for us (devs) to interface with Rasterio by using ._indexes and easier for users to understand the variable with .bands (there are so many other Python "indexes" than Raster bands, it's quite unintuitive)

@adehecq @atedstone This PR can be finished fairly quickly, we just need to decide: Do we also rename the public properties Raster.indexes and Raster.indexes_on_disk to Raster.bands and Raster.bands_on_disk?
There were a lot more index argument to change to bands than anticipated in the end (we forgot about interp_points, value_at_coords, __init__ and show).

The issue with removing the attribute indexes is that we lose consistency with rasterio. So far, we ensured that all main attributes of a rasterio dataset exist for Raster...
A (not so pleasant) option would be to have attribute bands and then indexes being an alias to bands? But it should be our only exception to not using bands. For example indexes_on_disk has not equivalent in rasterio, so I would rename it bands_on_disk.

The problem would be that Raster._indexes and Raster.bands are the same thing while named differently, which is not super consistent... But it is only an internal thing to deal with really, aimed to make it easier for us (devs) to interface with Rasterio by using ._indexes and easier for users to understand the variable with .bands (there are so many other Python "indexes" than Raster bands, it's quite unintuitive)

And hence, I would also rename _indexes with _bands. We should make sure that we never use the term indexes apart when calling rasterio functions, and the one attribute Raster.indexes (which should in no way be editable).

I like the solution of having both indexes and bands for inter-operability, I'll do that!

Ready to merge!


Flutter iOS build failed

Steps to Reproduce
problem started after upgrading flutter and firebase core, firestore, auth to latest version
2022-03-15 23:23:28.852 xcodebuild[72218:2172565] Requested but did not find extension point with identifier Xcode.IDEKit.ExtensionSentinelHostApplications for extension Xcode.DebuggerFoundation.AppExtensionHosts.watchOS of plug-in com.apple.dt.IDEWatchSupportCore
    2022-03-15 23:23:28.852 xcodebuild[72218:2172565] Requested but did not find extension point with identifier Xcode.IDEKit.ExtensionPointIdentifierToBundleIdentifier for extension Xcode.DebuggerFoundation.AppExtensionToBundleIdentifierMap.watchOS of plug-in com.apple.dt.IDEWatchSupportCore

Same happening here, the code was working totally fine after a few days and doing flutter clean and try to build again get this error which I assume is only happening on Mac M1 chips

I am seeing this error on Mac with intel chips and everytime I open the terminal.

So do I, M1 Pro chipset

@hokenn99 and everyone in this thread:
There's similar open issue describing same case, https://github.com/flutter/flutter/issues/98298, so please follow-up in it for further updates. I'll take the original issue forward.
Closing this as a duplicate.

I've managed to work with rosetta

Why has this been closed. What is the answer? The linked issue is also closed with no answer.
I am having these same issues with an intel based mac.
@darshankawar

@js1972
I'll reopen and address the linked issue. It got closed due to inactivity from original reporter.

same issue i encountered

+1

+1

+1

+1

Maybe because of Xcode 13.3? Not directly related but the error messages do look the same here: [SOLVED] Problem with Debug B4I and Updated Xcode (Version 13.3) I'll give it a try right now.
Their solution was to use Xcode 13.2 for now.. Download link:
Xcode 13.2.1
You can use multiple Xcode versions at the same time. See this article: How to Install Multiple Versions of Xcode on the Same macOS Machine

Okay, just found a solution which might sound super dumb but updating my Mac OS to Moterey 12.3 solved the issue with no change in the code required.

Everyone in this thread, please follow-up in original issue: https://github.com/flutter/flutter/issues/98298

@hokenn99
Try to run: xcode-select --install
This fixed mine :)

In my case (I already have installed command line developer tools) I fix it by running
sudo xcode-select -r

@hokenn99 Try to run: xcode-select --install
This fixed mine :)

Unfortunately I'm simply getting xcode-select: error: command line tools are already installed, use "Software Update" to install updates

This worked for me

Not for me ... also get I'm simply getting xcode-select: error: command line tools are already installed, use "Software Update" to install updates

Here's how I solved the issue:
macOS: Monterey
XCode: 13.3
Flutter: 2.10
Dart : 2.16.1
Once you've the above config set, run 'flutter packages upgrade'.
Then create a backup of your 'ios' folder and delete it from your project repo.
now run 'flutter clean' followed by 'flutter create .' This will create an 'ios' folder in the repo.
Copy the Info.plist,  Podfile and any other config files like GoogleServices.plist from the backup 'ios' folder to the newly created 'ios' folder.
Run the project now and it should work!

Here's how I solved the issue: macOS: Monterey XCode: 13.3 Flutter: 2.10 Dart : 2.16.1
Once you've the above config set, run 'flutter packages upgrade'. Then create a backup of your 'ios' folder and delete it from your project repo. now run 'flutter clean' followed by 'flutter create .' This will create an 'ios' folder in the repo. Copy the Info.plist, Podfile and any other config files like GoogleServices.plist from the backup 'ios' folder to the newly created 'ios' folder.
Run the project now and it should work!

worked!! I need to tell, you saved my day :)

Here's how I solved the issue: macOS: Monterey XCode: 13.3 Flutter: 2.10 Dart : 2.16.1
Once you've the above config set, run 'flutter packages upgrade'. Then create a backup of your 'ios' folder and delete it from your project repo. now run 'flutter clean' followed by 'flutter create .' This will create an 'ios' folder in the repo. Copy the Info.plist, Podfile and any other config files like GoogleServices.plist from the backup 'ios' folder to the newly created 'ios' folder.
Run the project now and it should work!

worked!! I need to tell, you saved my day :)

Hey..cool..glad to know it worked😃

It also worked for me with the following setup:
XCode: 13.3
Flutter: 2.10
Dart : 2.16.1
Thanks.

I'm able to run the app now in debug mode, with @AshfaqAshi's solution.
But still unable to archive the build, somehow the debug works but not release. does anyone have the same issue now?

I'm able to run the app now in debug mode, with @AshfaqAshi's solution.
But still unable to archive the build, somehow the debug works but not release. does anyone have the same issue now?

What error do you get while archiving?

SwiftCodeGeneration normal arm64 (in target 'DKImagePickerController' from project 'Pods')
cd /Users/taha/Documents/ria-ios/ios/Pods
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/swift-frontend -frontend -c -primary-file /Users/taha/Library/Developer/Xcode/DerivedData/Runner-eewvryzjlzydpcbgrijeocqbxmbx/Build/Intermediates.noindex/ArchiveIntermediates/Runner/IntermediateBuildFilesPath/Pods.build/Release-iphoneos/DKImagePickerController.build/Objects-normal/arm64/DKPopoverViewController.bc -embed-bitcode -target arm64-apple-ios11.4 -Xllvm -aarch64-use-tbi -O -disable-llvm-optzns -module-name DKImagePickerController -o /Users/taha/Library/Developer/Xcode/DerivedData/Runner-eewvryzjlzydpcbgrijeocqbxmbx/Build/Intermediates.noindex/ArchiveIntermediates/Runner/IntermediateBuildFilesPath/Pods.build/Release-iphoneos/DKImagePickerController.build/Objects-normal/arm64/DKPopoverViewController.o
Please submit a bug report (https://swift.org/contributing/#reporting-bugs) and include the project and the crash backtrace.
Stack dump:
0.	Program arguments: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/swift-frontend -frontend -c -primary-file /Users/taha/Library/Developer/Xcode/DerivedData/Runner-eewvryzjlzydpcbgrijeocqbxmbx/Build/Intermediates.noindex/ArchiveIntermediates/Runner/IntermediateBuildFilesPath/Pods.build/Release-iphoneos/DKImagePickerController.build/Objects-normal/arm64/DKPopoverViewController.bc -embed-bitcode -target arm64-apple-ios11.4 -Xllvm -aarch64-use-tbi -O -disable-llvm-optzns -module-name DKImagePickerController -o /Users/taha/Library/Developer/Xcode/DerivedData/Runner-eewvryzjlzydpcbgrijeocqbxmbx/Build/Intermediates.noindex/ArchiveIntermediates/Runner/IntermediateBuildFilesPath/Pods.build/Release-iphoneos/DKImagePickerController.build/Objects-normal/arm64/DKPopoverViewController.o

Apple Swift version 5.6 (swiftlang-<IP_ADDRESS>3.62 clang-13<IP_ADDRESS>)
Compiling with the current language version
Running pass 'Function Pass Manager' on module '/Users/taha/Library/Developer/Xcode/DerivedData/Runner-eewvryzjlzydpcbgrijeocqbxmbx/Build/Intermediates.noindex/ArchiveIntermediates/Runner/IntermediateBuildFilesPath/Pods.build/Release-iphoneos/DKImagePickerController.build/Objects-normal/arm64/DKPopoverViewController.bc'.
Running pass 'ObjC ARC contraction' on function '@UI_USER_INTERFACE_IDIOM'
Stack dump without symbol names (ensure you have llvm-symbolizer in your PATH or set the environment var LLVM_SYMBOLIZER_PATH to point to it):
0  swift-frontend           0x000000010487ef88 llvm::sys::PrintStackTrace(llvm::raw_ostream&, int) + 56
1  swift-frontend           0x000000010487df9c llvm::sys::RunSignalHandlers() + 112
2  swift-frontend           0x000000010487f618 SignalHandler(int) + 344
3  libsystem_platform.dylib 0x00000001bfdfd4c4 _sigtramp + 56
4  swift-frontend           0x00000001027fce8c llvm::objcarc::BundledRetainClaimRVs::insertRVCallWithColors(llvm::Instruction*, llvm::CallBase*, llvm::DenseMap<llvm::BasicBlock*, llvm::TinyPtrVectorllvm::BasicBlock*, llvm::DenseMapInfollvm::BasicBlock*, llvm::detail::DenseMapPair<llvm::BasicBlock*, llvm::TinyPtrVectorllvm::BasicBlock* > > const&) + 64
5  swift-frontend           0x000000010280d878 (anonymous namespace)::ObjCARCContract::run(llvm::Function&, llvm::AAResults*, llvm::DominatorTree*) + 1024
6  swift-frontend           0x00000001045f2e24 llvm::FPPassManager::runOnFunction(llvm::Function&) + 1292
7  swift-frontend           0x00000001045f938c llvm::FPPassManager::runOnModule(llvm::Module&) + 60
8  swift-frontend           0x00000001045f35a8 llvm::legacy::PassManagerImpl::run(llvm::Module&) + 1088
9  swift-frontend           0x00000001005beee8 swift::performLLVMOptimizations(swift::IRGenOptions const&, llvm::Module*, llvm::TargetMachine*) + 3376
10 swift-frontend           0x00000001005bfe28 swift::performLLVM(swift::IRGenOptions const&, swift::DiagnosticEngine&, llvm::sys::SmartMutex, llvm::GlobalVariable, llvm::Module*, llvm::TargetMachine*, llvm::StringRef, swift::UnifiedStatsReporter*) + 2440
11 swift-frontend           0x00000001005c8364 swift::performLLVM(swift::IRGenOptions const&, swift::ASTContext&, llvm::Module*, llvm::StringRef) + 180
12 swift-frontend           0x0000000100120ea0 swift::performFrontend(llvm::ArrayRef<char const*>, char const*, void*, swift::FrontendObserver*) + 6976
13 swift-frontend           0x00000001000e8130 swift::mainEntry(int, char const**) + 808
14 dyld                     0x000000010707d088 start + 516
error: Segmentation fault: 11 (in target 'DKImagePickerController' from project 'Pods')

SwiftCodeGeneration normal arm64 (in target 'DKImagePickerController' from project 'Pods') cd /Users/taha/Documents/ria-ios/ios/Pods /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/swift-frontend -frontend -c -primary-file /Users/taha/Library/Developer/Xcode/DerivedData/Runner-eewvryzjlzydpcbgrijeocqbxmbx/Build/Intermediates.noindex/ArchiveIntermediates/Runner/IntermediateBuildFilesPath/Pods.build/Release-iphoneos/DKImagePickerController.build/Objects-normal/arm64/DKPopoverViewController.bc -embed-bitcode -target arm64-apple-ios11.4 -Xllvm -aarch64-use-tbi -O -disable-llvm-optzns -module-name DKImagePickerController -o /Users/taha/Library/Developer/Xcode/DerivedData/Runner-eewvryzjlzydpcbgrijeocqbxmbx/Build/Intermediates.noindex/ArchiveIntermediates/Runner/IntermediateBuildFilesPath/Pods.build/Release-iphoneos/DKImagePickerController.build/Objects-normal/arm64/DKPopoverViewController.o
Please submit a bug report (https://swift.org/contributing/#reporting-bugs) and include the project and the crash backtrace. Stack dump: 0. Program arguments: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/swift-frontend -frontend -c -primary-file /Users/taha/Library/Developer/Xcode/DerivedData/Runner-eewvryzjlzydpcbgrijeocqbxmbx/Build/Intermediates.noindex/ArchiveIntermediates/Runner/IntermediateBuildFilesPath/Pods.build/Release-iphoneos/DKImagePickerController.build/Objects-normal/arm64/DKPopoverViewController.bc -embed-bitcode -target arm64-apple-ios11.4 -Xllvm -aarch64-use-tbi -O -disable-llvm-optzns -module-name DKImagePickerController -o /Users/taha/Library/Developer/Xcode/DerivedData/Runner-eewvryzjlzydpcbgrijeocqbxmbx/Build/Intermediates.noindex/ArchiveIntermediates/Runner/IntermediateBuildFilesPath/Pods.build/Release-iphoneos/DKImagePickerController.build/Objects-normal/arm64/DKPopoverViewController.o

Apple Swift version 5.6 (swiftlang-<IP_ADDRESS>3.62 clang-13<IP_ADDRESS>)
Compiling with the current language version
Running pass 'Function Pass Manager' on module '/Users/taha/Library/Developer/Xcode/DerivedData/Runner-eewvryzjlzydpcbgrijeocqbxmbx/Build/Intermediates.noindex/ArchiveIntermediates/Runner/IntermediateBuildFilesPath/Pods.build/Release-iphoneos/DKImagePickerController.build/Objects-normal/arm64/DKPopoverViewController.bc'.
Running pass 'ObjC ARC contraction' on function '@UI_USER_INTERFACE_IDIOM'
Stack dump without symbol names (ensure you have llvm-symbolizer in your PATH or set the environment var LLVM_SYMBOLIZER_PATH to point to it):
0  swift-frontend           0x000000010487ef88 llvm::sys::PrintStackTrace(llvm::raw_ostream&, int) + 56
1  swift-frontend           0x000000010487df9c llvm::sys::RunSignalHandlers() + 112
2  swift-frontend           0x000000010487f618 SignalHandler(int) + 344
3  libsystem_platform.dylib 0x00000001bfdfd4c4 sigtramp + 56
4  swift-frontend           0x00000001027fce8c llvm::objcarc::BundledRetainClaimRVs::insertRVCallWithColors(llvm::Instruction*, llvm::CallBase*, llvm::DenseMap<llvm::BasicBlock*, llvm::TinyPtrVectorllvm::BasicBlock*, llvm::DenseMapInfollvm::BasicBlock*, llvm::detail::DenseMapPair<llvm::BasicBlock*, llvm::TinyPtrVectorllvm::BasicBlock* > > const&) + 64
5  swift-frontend           0x000000010280d878 (anonymous namespace)::ObjCARCContract::run(llvm::Function&, llvm::AAResults*, llvm::DominatorTree*) + 1024
6  swift-frontend           0x00000001045f2e24 llvm::FPPassManager::runOnFunction(llvm::Function&) + 1292
7  swift-frontend           0x00000001045f938c llvm::FPPassManager::runOnModule(llvm::Module&) + 60
8  swift-frontend           0x00000001045f35a8 llvm::legacy::PassManagerImpl::run(llvm::Module&) + 1088
9  swift-frontend           0x00000001005beee8 swift::performLLVMOptimizations(swift::IRGenOptions const&, llvm::Module*, llvm::TargetMachine*) + 3376
10 swift-frontend           0x00000001005bfe28 swift::performLLVM(swift::IRGenOptions const&, swift::DiagnosticEngine&, llvm::sys::SmartMutex, llvm::GlobalVariable_, llvm::Module*, llvm::TargetMachine*, llvm::StringRef, swift::UnifiedStatsReporter*) + 2440
11 swift-frontend           0x00000001005c8364 swift::performLLVM(swift::IRGenOptions const&, swift::ASTContext&, llvm::Module*, llvm::StringRef) + 180
12 swift-frontend           0x0000000100120ea0 swift::performFrontend(llvm::ArrayRef<char const*>, char const*, void*, swift::FrontendObserver*) + 6976
13 swift-frontend           0x00000001000e8130 swift::mainEntry(int, char const**) + 808
14 dyld                     0x000000010707d088 start + 516
error: Segmentation fault: 11 (in target 'DKImagePickerController' from project 'Pods')

This is what I'm getting now. @AshfaqAshi

Try this:
Open your Podfile and paste  pod 'DKImagePickerController/PhotoGallery', :git => 'https://github.com/miguelpruivo/DKImagePickerController.git' as shown below:
`target 'Runner' do
use_frameworks!
use_modular_headers!
#Workaround for segmentation fault:11 while archiving
#Add the below line
pod 'DKImagePickerController/PhotoGallery', :git => 'https://github.com/miguelpruivo/DKImagePickerController.git'
flutter_install_all_ios_pods File.dirname(File.realpath(FILE))
end`
Now remove Podfile.lock and run pod install, then archive your project and it should work.

SwiftCodeGeneration normal arm64 (in target 'DKImagePickerController' from project 'Pods') cd /Users/taha/Documents/ria-ios/ios/Pods /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/swift-frontend -frontend -c -primary-file /Users/taha/Library/Developer/Xcode/DerivedData/Runner-eewvryzjlzydpcbgrijeocqbxmbx/Build/Intermediates.noindex/ArchiveIntermediates/Runner/IntermediateBuildFilesPath/Pods.build/Release-iphoneos/DKImagePickerController.build/Objects-normal/arm64/DKPopoverViewController.bc -embed-bitcode -target arm64-apple-ios11.4 -Xllvm -aarch64-use-tbi -O -disable-llvm-optzns -module-name DKImagePickerController -o /Users/taha/Library/Developer/Xcode/DerivedData/Runner-eewvryzjlzydpcbgrijeocqbxmbx/Build/Intermediates.noindex/ArchiveIntermediates/Runner/IntermediateBuildFilesPath/Pods.build/Release-iphoneos/DKImagePickerController.build/Objects-normal/arm64/DKPopoverViewController.o
Please submit a bug report (https://swift.org/contributing/#reporting-bugs) and include the project and the crash backtrace. Stack dump: 0. Program arguments: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/swift-frontend -frontend -c -primary-file /Users/taha/Library/Developer/Xcode/DerivedData/Runner-eewvryzjlzydpcbgrijeocqbxmbx/Build/Intermediates.noindex/ArchiveIntermediates/Runner/IntermediateBuildFilesPath/Pods.build/Release-iphoneos/DKImagePickerController.build/Objects-normal/arm64/DKPopoverViewController.bc -embed-bitcode -target arm64-apple-ios11.4 -Xllvm -aarch64-use-tbi -O -disable-llvm-optzns -module-name DKImagePickerController -o /Users/taha/Library/Developer/Xcode/DerivedData/Runner-eewvryzjlzydpcbgrijeocqbxmbx/Build/Intermediates.noindex/ArchiveIntermediates/Runner/IntermediateBuildFilesPath/Pods.build/Release-iphoneos/DKImagePickerController.build/Objects-normal/arm64/DKPopoverViewController.o

Apple Swift version 5.6 (swiftlang-<IP_ADDRESS>3.62 clang-13<IP_ADDRESS>)
Compiling with the current language version
Running pass 'Function Pass Manager' on module '/Users/taha/Library/Developer/Xcode/DerivedData/Runner-eewvryzjlzydpcbgrijeocqbxmbx/Build/Intermediates.noindex/ArchiveIntermediates/Runner/IntermediateBuildFilesPath/Pods.build/Release-iphoneos/DKImagePickerController.build/Objects-normal/arm64/DKPopoverViewController.bc'.
Running pass 'ObjC ARC contraction' on function '@UI_USER_INTERFACE_IDIOM'
Stack dump without symbol names (ensure you have llvm-symbolizer in your PATH or set the environment var LLVM_SYMBOLIZER_PATH to point to it):
0  swift-frontend           0x000000010487ef88 llvm::sys::PrintStackTrace(llvm::raw_ostream&, int) + 56
1  swift-frontend           0x000000010487df9c llvm::sys::RunSignalHandlers() + 112
2  swift-frontend           0x000000010487f618 SignalHandler(int) + 344
3  libsystem_platform.dylib 0x00000001bfdfd4c4 sigtramp + 56
4  swift-frontend           0x00000001027fce8c llvm::objcarc::BundledRetainClaimRVs::insertRVCallWithColors(llvm::Instruction*, llvm::CallBase*, llvm::DenseMap<llvm::BasicBlock*, llvm::TinyPtrVectorllvm::BasicBlock*, llvm::DenseMapInfollvm::BasicBlock*, llvm::detail::DenseMapPair<llvm::BasicBlock*, llvm::TinyPtrVectorllvm::BasicBlock* > > const&) + 64
5  swift-frontend           0x000000010280d878 (anonymous namespace)::ObjCARCContract::run(llvm::Function&, llvm::AAResults*, llvm::DominatorTree*) + 1024
6  swift-frontend           0x00000001045f2e24 llvm::FPPassManager::runOnFunction(llvm::Function&) + 1292
7  swift-frontend           0x00000001045f938c llvm::FPPassManager::runOnModule(llvm::Module&) + 60
8  swift-frontend           0x00000001045f35a8 llvm::legacy::PassManagerImpl::run(llvm::Module&) + 1088
9  swift-frontend           0x00000001005beee8 swift::performLLVMOptimizations(swift::IRGenOptions const&, llvm::Module*, llvm::TargetMachine*) + 3376
10 swift-frontend           0x00000001005bfe28 swift::performLLVM(swift::IRGenOptions const&, swift::DiagnosticEngine&, llvm::sys::SmartMutex, llvm::GlobalVariable_, llvm::Module*, llvm::TargetMachine*, llvm::StringRef, swift::UnifiedStatsReporter*) + 2440
11 swift-frontend           0x00000001005c8364 swift::performLLVM(swift::IRGenOptions const&, swift::ASTContext&, llvm::Module*, llvm::StringRef) + 180
12 swift-frontend           0x0000000100120ea0 swift::performFrontend(llvm::ArrayRef<char const*>, char const*, void*, swift::FrontendObserver*) + 6976
13 swift-frontend           0x00000001000e8130 swift::mainEntry(int, char const**) + 808
14 dyld                     0x000000010707d088 start + 516
error: Segmentation fault: 11 (in target 'DKImagePickerController' from project 'Pods')

This is what I'm getting now. @AshfaqAshi

Try this: Open your Podfile and paste  pod 'DKImagePickerController/PhotoGallery', :git => 'https://github.com/miguelpruivo/DKImagePickerController.git' as shown below: `target 'Runner' do use_frameworks! use_modular_headers! #Workaround for segmentation fault:11 while archiving #Add the below line pod 'DKImagePickerController/PhotoGallery', :git => 'https://github.com/miguelpruivo/DKImagePickerController.git'
flutter_install_all_ios_pods File.dirname(File.realpath(FILE)) end`
Now remove Podfile.lock and run pod install, then archive your project and it should work.

worked for me! thanks

Flutter: 2.10

Here's how I solved the issue: macOS: Monterey XCode: 13.3 Flutter: 2.10 Dart : 2.16.1
Once you've the above config set, run 'flutter packages upgrade'. Then create a backup of your 'ios' folder and delete it from your project repo. now run 'flutter clean' followed by 'flutter create .' This will create an 'ios' folder in the repo. Copy the Info.plist, Podfile and any other config files like GoogleServices.plist from the backup 'ios' folder to the newly created 'ios' folder.
Run the project now and it should work!

Worked for me :-)

After updating the macOS and accepting terms in Xcode, It only worked running these command:

flutter clean
rm -rf ios/Pods
rm -rf ios/.symlinks
rm -rf ios/Flutter/Flutter.framework
rm -rf ios/Flutter/Flutter.podspec

same issue on QZ, i solved in this way https://github.com/cagnulein/qdomyos-zwift/discussions/740

I had this same issue and none of the above suggested solutions fixed it. What did it for me was running:
flutter build ipa --no-tree-shake-icons
Running flutter build ipa --verbose showed a more detailed error message which suggested using the --no-tree-shake-icons option to fix it. I'm not sure why that fixed it, but it did.


Generated and added TOC

Having a TOC sounds great. I will position it before the first title Understanding the Spring Petclinic application and its own section and I will remove the Distributed version of the Spring PetClinic - adapted for Cloud Foundry and Kubernetes link.
@odedia what did you think?

Agreed

Please review


Improving Readability

Pull Request
PR checklist

[x] Have you read the contributing guidelines?
[x] Have you made sure that the title is accurate and descriptive of the changes?

bors merge

bors merge


feat(sdk/zig): start off Zig SDK with config component

Hi, I'd love for Spin to have a fully-fledged Zig SDK!
This PR only implements the config component, please let me know if there's something else I should add to start us off.

@tensorush thanks for this! Looks like a really great start. 🎉
While in the long run I can certainly see there being an official Zig SDK maintained by the Spin project, I don't think we're ready for that today for the simple reason that the Spin project doesn't have enough Zig expertise to ensure this is maintained properly. What's more, the path forward for SDKs is for them to live outside of the Spin repo which we've done for other SDKs that came after Go and Rust like Python and JS and which we eventually hope to do for Rust and Go.
I think the right path forward is for this to live in a separate repo (perhaps on your personal GitHub org to start). We have the ability to promote such projects even when they aren't under the Fermyon GitHub org. If the day comes that it makes more sense for this to live in the Fermyon GitHub org then we can consider that then.
How does that sound?


"The key vault can exist in a different subscription than the resource group you are deploying to." may be incorrect.

When the VM subscription is not the same as the Key Vault's subscription , we get error "The SubscriptionId: ... of the request must match the SubscriptionId ... contained in the Key Vault Id".

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 70505efb-d7ac-0dbc-6b57-2ce6a2a78ef2
Version Independent ID: 0d5a06ac-190e-78d2-c031-ca9d5c09347f
Content: Key Vault secret with Azure Resource Manager template
Content Source: articles/azure-resource-manager/resource-manager-keyvault-parameter.md
Service: azure-resource-manager
GitHub Login: @tfitzmac
Microsoft Alias: tomfitz

@tonybendis - I was not able to duplicate this error. This article describes how to get a value from Key Vault and pass that value as a parameter to a template. When deploying the resource, the parameter value would only contain the secret without any indication of the subscription ID that it came from. Were you instead trying to the set the certificate URL in VM resource?

@tonybendis - if you are still having a problem with Key Vault and templates, feel free to reopen this issue. Otherwise, we'll close it.
#please-close

#please-close

@tonybendis We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.

Hi ,
I get the same error ! ERROR The KeyVault 'enjnjnj-vn' does not exist in the Resource
Group 'test_gos' for the Subscription

I also get this error:
Resource Microsoft.Compute/virtualMachineScaleSets 'VMScaleSetWin' failed with message '{
"error": {
"code": "InvalidParameter",
"message": "The SubscriptionId:"00000000-0000-0000-000-000000000000" of the request must match the SubscriptionId "11111111-1111-1111-1111-111111111111" contained in the Key Vault Id.",
"target": "sourceVault.id"
}
}'
When I try to deploy a VMSS with an ARM template.

#please-open

@Canutza - this article describes the scenario of using a key vault secret in a parameter file. In that case, the key vault does not need to be in the same subscription. Your scenario involves directly referencing a key vault from a VM property. That scenario is described at Set up Key Vault for virtual machines in Azure Resource Manager.

for Secrets cross-subscription seems to work fine. For Certificates however it fails with:
"The SubscriptionId:"" of the request must match the SubscriptionId "" contained
in the Key Vault Id."
Template:
"osProfile": {
"computerName": "[parameters('virtualMachineName')]",
"adminUsername": "[parameters('adminUsername')]",
"adminPassword": "[parameters('adminPassword')]",
"secrets": [
{
"sourceVault": {
"id": "[concat('/subscriptions/', '', '/resourceGroups/', 'rgkeyvault', '/providers/Microsoft.KeyVault/vaults/', 'testvaultxxx')]"
},
"vaultCertificates": [
{
"certificateUrl": "https://testvaultxxx.vault.azure.net:443/secrets/JHTESTCERT/6206a8d1438c4d378ca7aa69c31a7f2f",
"certificateStore": "TESTCERTSTORE"
}
]
}
]
},

@JulianHayward I am also seeing this error when I try to use the secret identifier URL of the SSL cert in a different subscription and different resource group.  I am able to use the same key vault to pass in secrets though.

Same issue here, we deploy a Vmss with certificate reference in the osprofile which points to a keyvault in anohter owned subscription.
Can you please triage this and update the status?

I'm facing the same issue, we have a central keyvault in a central subscription that holds our certificate, but ARM deployment for a VMSS in a different subscription fails to get the certificate from that keyvault with the same error message. I've also tried adding the managed identity of the VMSS to the target keyvault but that yields the same issue.

#please-open for certificate reference in the osprofile which points to a keyvault in different subscription.

#please-open

The osprofile-based cert ref does not support KV auto-rotation today as far as I know?!?

It's not about auto rotation. You cannot reference certificates from akv in different subscription (not vmss subscription) in os profile.

just ran into this
#please-open

#please-open
We are having the same issue

@wi5nia - does your issue involve directly referencing a key vault from a VM property?

We are deploying a Service Fabric cluster which uses of course VMSS and have an ARM template which references a Azure KeyVault in different subscription because we want to have one centrally managed by IT AKV which is integrated with DigiCert. This way we can centrally purchase certificates, distribute them and renew.

@wi5nia - the statement about the key vault existing in a different subscription applies to getting secrets in parameter file. It doesn't apply to referencing a certificate from a template. I have added a note that tries to clarify that difference. It should get published later today.
#please-close

Is there an actual resolution to this?
I have the following, where the first vault is in a different subscription.
          "osProfile": {
            "adminPassword": "[parameters('adminPassword')]",
            "adminUsername": "[parameters('adminUsername')]",
            "computernamePrefix": "[variables('vmNodeType0Name')]",
            "secrets": [
              {
                "sourceVault": {
                  "id": "[parameters('sharedVaultResourceId')]"
                },
                "vaultCertificates": [
                  {
                    "certificateStore": "[parameters('certificateStoreValue')]",
                    "certificateUrl": "[parameters('wildCardCertificateUrl')]"
                  }
                ]
              },
              {
                "sourceVault": {
                  "id": "[parameters('clusterVaultResourceId')]"
                },
                "vaultCertificates": [
                  {
                    "certificateStore": "[parameters('certificateStoreValue')]",
                    "certificateUrl": "[parameters('chorusCertificateUrl')]"
                  },
                  {
                    "certificateStore": "[parameters('certificateStoreValue')]",
                    "certificateUrl": "[parameters('rootCACertificateUrl')]"
                  }
                ]
              }
            ]
          },

Same problem, this needs a fix - please.
Trying to deploy CloudService ES to one subscription while pulling the cert from another subscription. And, it's not working..
The cloud service SubscriptionId 'xxxxx' must match the key vault SubscriptionId 'yyyyy'
Using
"osProfile": { 					"secrets": [ 						{ 							"sourceVault": { 								"id": "[resourceId(parameters('KeyVaultSubscr'), parameters('KeyVaultResGrp'), 'Microsoft.KeyVault/vaults', parameters('KeyVaultCrts'))]" 							}, 							"vaultCertificates": [ 								{ 									"certificateUrl": "[reference(variables('ApplicationCertificateSecretId'), '2018-02-14').secretUriWithVersion]" 								} 							] 						} 					] 				}
With ApplicationCertificateId being defined as:
"ApplicationCertificateSecretId": "[ResourceId(parameters('KeyVaultSubscr'), parameters('KeyVaultResGrp'), 'Microsoft.KeyVault/vaults/secrets', parameters('KeyVaultCrts'), parameters('ApplicationCertificateSecret'))]"

Facing the exact same issue . Below is my ARM which refers to vault in different subscription -
```
"osProfile": {
"adminPassword": "[parameters('adminPassword')]",
"adminUsername": "[parameters('adminUsername')]",
"computernamePrefix": "[parameters('vmNodeType0Name')]",
"secrets": [
{
"sourceVault": {
"id": "[parameters('sourceVaultValue')]"
},
"vaultCertificates": [
{
"certificateStore": "[parameters('certificateStoreValue')]",
"certificateUrl": "[parameters('certificateUrlValue')]"
}
When i deploy my service fabric cluster i get the below error -
![image](https://user-images.githubusercontent.com/71304310/138214421-4da98fbb-7c9b-4b4b-80b8-87e5143fcb17.png)


Created cloud credential not available when create in the dropdown while importing an EKS cluster

What kind of request is this (question/bug/enhancement/feature request): bug
Steps to reproduce (least amount of steps as possible):

Click on Add cluster --> Register --> Amazon EKS --> No credentials available in the dropdown
Create a new credential
Cloud Credentials dropdown does NOT show the credential.

Refresh the page
Cloud credential is seen now

Expected Result:
Cloud credential should be seen in the dropdown when you create the cred.
Other details that may be helpful:
Environment information

Rancher version (rancher/rancher/rancher/server image tag or shown bottom left in the UI): master-head master-3374-head - commit id: 5c1c2c5d7
Installation option (single install/HA): HA

Cluster information

Cluster type (Hosted/Infrastructure Provider/Custom/Imported): Import EKS

Verified on master-head - commit id: 6aef36313 ui tag: latest2

Click on Add cluster --> Register --> Amazon EKS --> No credentials available in the dropdown
Create a new credential
Cloud Credentials dropdown show the credential.


The parameters to modify the size of the image are not working in android

the method is not changing the size of the image using the available parameters,
Bug Information
Version Number of Plugin: <IP_ADDRESS>
Device Tested On: Motorola Z2 Play
Simulator Tested On:
Version of VS:  15.7.1
Version of Xamarin: <IP_ADDRESS>2510
Versions of other things you are using:
Steps to reproduce the Behavior
Using CrossMedia.Current.TakePhotoAsync() method is saving the image in max quality and max size without taken effect any of the options
Expected Behavior
image should get resized
Actual Behavior
the parameters to resize the image are not working
Code snippet
var foto = await CrossMedia.Current.TakePhotoAsync(new Plugin.Media.Abstractions.StoreCameraMediaOptions()             {                 SaveToAlbum = true,                 PhotoSize = Plugin.Media.Abstractions.PhotoSize.MaxWidthHeight,                 SaveMetaData = false,                 MaxWidthHeight = 800,              });

I am also in need of the MaxWidtHeight functionality, so I had a look in the code to see if this was implemented.
There seems to be some code missing in a certain code path, both for PickMediaAsync and TakeMediaAsync:
if (options.RotateImage)
{
      await FixOrientationAndResizeAsync(media.Path, options, originalMetadata);
}
else
{
      await ResizeAsync(media.Path, options.PhotoSize, options.CompressionQuality, options.CustomPhotoSize, originalMetadata);
}

The FixOrientationAndResizeAsync seems to have an implementation for MaxWidthHeight, but the ResizeAsync is missing this logic.
Specifically this part seems to be missing in de ResizeAsync:
if (mediaOptions.PhotoSize == PhotoSize.MaxWidthHeight && mediaOptions.MaxWidthHeight.HasValue)
 {
     var max = Math.Max(options.OutWidth, options.OutHeight);
     if (max > mediaOptions.MaxWidthHeight)
     {
          percent = (float)mediaOptions.MaxWidthHeight / (float)max;
      }
}

I just did a quick test with current version of nuget package <IP_ADDRESS>, and if I set RotateImage = true, the resizing works. If I set RotateImage = false, it fails to resize the image.

They also don't seem to be working on iOS. I'm going to have a crack and it and see if I can find why.

Fixed


General: Fix finding of last version

Bug
There was a bug that affected finding of last OP version. This resulted in invalid behaviour mainly in headless mode, where it tries to reinstall already installed version.

This would require deploying new executables/installers, yes? :)
Were you able to reproduce the original issue of it trying to do a force install in headless mode? And did this avoid it on your end? Just wondering how "safe" it is for me to just throw this PR into production to see if it'd would fix the issue or whether this might do more harm.

This still needs little refactor to move the compatibility check out...

This would require deploying new executables/installers, yes? :)

yes, this will need new build

Were you able to reproduce the original issue of it trying to do a force install in headless mode? And did this avoid it on your end? Just wondering how "safe" it is for me to just throw this PR into production to see if it'd would fix the issue or whether this might do more harm.

I haven't reproduced it, but find similar issue with headless mode that lead me to this. The re-install logic is sound I think, problem is that it can't find the latest version correctly so it is trying to reinstall it.
But please wait with deployment until the compatibility check is refactored.

But please wait with deployment until the compatibility check is refactored.

If you could ping me when that's the case, please do so! :)

We have deployed this in production now. (Since this requires the build/install to be updated too I've actually batch removed the old install and then batch deployed the new to make sure it's using this newer build logic.)
So far so good in Deadline. If anything pops up with errors I'll report back.

Added UI message if installed version is not compatible with zip and is not launched in headless mode.

It works.


[flutter_releases] Flutter stable 3.24.1 Framework Cherrypicks

Roll the engine from https://github.com/flutter/engine/commits/c9b9d5780da342eb3f0f5e439a7db06f7d112575

Closing in favor of https://github.com/flutter/flutter/pull/153731/


Not appearing on skins list

I'm on windows 10 currently, none of the themes appear on the skins list in interface settings. Had to install other unrelated skin to see if it would pop up on the list, and to confirm I wasn't screwing up anything.

Could you send a screenshot of your skins folder? It should show up if the  folder is there at all


⚠ PrivateHD has degraded performance

In d02fc77, PrivateHD ($PHD) experienced degraded performance:

HTTP code: 200
Response time: 4551 ms

Resolved: PrivateHD performance has improved in 1f817be.


Highlight candidate on coming back from his report page.

If you view report for a candidate and come back to the candidate list page corresponding to a quiz, the candidate whose report was viewed recently should be highlighted?

This is done.


Update upcomingevents.json

update for hybrid event starting 11 November

Hello 👋 , can someone please review and approve this request? Thanks.


Prohibit or handle long database names

I finally realized why test_dump01_restore_compatibility is failing on macOS.  The path to the dump file is longer than the PostgreSQL's limit of 63 characters, and since the test uses the full path name for the database name, it fails, because Postgres silently truncates long names (it issues a NOTICE response, but not an error).
We have graceful handling of other schema classes in those cases, but not databases.

Should this be closed now?

No, the linked PR is related, but does not fix the issue at hand.