Extend and override 'ConfigClientProperties'

Hey,
I want to provide my own 'ConfigClientProperties' with special default values integrated in my
own autoconfiguration. I can not provide my own property because there is no
@ConditionalOnMissingBean in the ConfigServiceBootstrapConfiguration class.
Also I would need something like @AutoConfigureBefore in the bootstrap phase, or?
Is there a way to provide my own bean of the ConfigClientProperties? I also want to expose the configuration on another conf. path and not under "spring.cloud.config.*"

I supposed you could try adding @Primary to your bean, did you try that?  Why not just set the values you want in your properties|yaml files?

I cannot use properties|yml files, because I do not have any properties|yml files in my autoconfigure. I want to build a separate starter/autoconfigure project with predefined values and also add the OAuth2 rest template with different values and want to wrap that all up.
I can try that with @Primary. But maybe there will be a way, like in the basic spring boot autoconfigure, to provide an ordering of BootstrapConfigurations and to let other override the ConfigurationProperties of spring cloud or like in this case spring cloud config.
--
I tried @Primary, but that does not work, because first the
ConfigServiceBootstrapConfiguration will create the ConfigClientProperties and than the
ConfigServicePropertySourceLocator with the ConfigClientProperties as dependency and then
PropertySourceBootstrapConfiguration#locate will be called from the PropertySourceBootstrapConfiguration.
After all that configuration my, with @Primary marked, Properties will be created but they just laying there till the ends of their days :)
if there would be a mechanism like @AutoConfigureBefore I could provide my own property classes
and your mechanism will use mine.

I think the section on providing a custom rest template should give you some idea http://cloud.spring.io/spring-cloud-static/Dalston.SR1/#custom-rest-template

OK I tried some configurations but nothing works.
First
If I expose the CoffeeNetConfigClientProperties as configClientProperties then your
ConfigClientProperties will be used and my one will be ignored event if
I annotate the bean with @Primary.
First your ConfigServiceBootstrapConfiguration#configClientProperties
bean will be created and then if fails with
Caused by: java.lang.IllegalStateException: @Bean method CoffeeNetConfigBootstrapConfiguration.configClientProperties called as a bean reference for type [coffee.synyx.autoconfigure.config.CoffeeNetConfigClientProperties] but overridden by non-compatible bean instance of type [org.springframework.cloud.config.client.ConfigClientProperties]. Overriding bean of same name declared in: org.springframework.cloud.config.client.ConfigServiceBootstrapConfiguration

and that makes sense. Here my configuration:
    @Bean
    @Primary
    CoffeeNetConfigClientProperties configClientProperties() {

        CoffeeNetConfigClientProperties clientProperties = new
CoffeeNetConfigClientProperties(environment);
        clientProperties.setEnabled(false);

        return clientProperties;
    }

    @Bean
    CoffeeNetClientCredentialsResourceDetailsProperties
coffeeNetClientCredentialsResourceDetailsProperties() {

        return new CoffeeNetClientCredentialsResourceDetailsProperties();
    }

    @Bean
    ConfigServicePropertySourceLocator configServicePropertySource() {

        final ConfigClientProperties properties =
coffeeNetConfigClientProperties();
        final CoffeeNetClientCredentialsResourceDetailsProperties
resourceDetailsProperties =
            coffeeNetClientCredentialsResourceDetailsProperties();

        ConfigServicePropertySourceLocator locator = new
ConfigServicePropertySourceLocator(properties);
        locator.setRestTemplate(new
OAuth2RestTemplate(resourceDetailsProperties));

        return locator;
    }

Next try
So I tried to  prefix the ConfigClientProperties with coffeeNet of course my
coffeeNetConfigClientProperties bean will be injected, because there is only
this one with that class. But then it crashes in the 'auto configure' phase because
***************************
APPLICATION FAILED TO START
***************************

Description:

Method configClientProperties in org.springframework.cloud.config.client.ConfigClientAutoConfiguration required a single bean, but 2 were found:
	- coffeeNetConfigClientProperties: defined by method 'coffeeNetConfigClientProperties' in coffee.synyx.autoconfigure.config.CoffeeNetConfigBootstrapConfiguration
	- configClientProperties: defined by method 'configClientProperties' in class path resource [org/springframework/cloud/config/client/ConfigClientAutoConfiguration.class]

Action:

Consider marking one of the beans as @Primary, updating the consumer to accept multiple beans, or using @Qualifier to identify the bean that should be consumed

Here is my code:
    @Bean
    @Primary
    CoffeeNetConfigClientProperties coffeeNetConfigClientProperties() {

        CoffeeNetConfigClientProperties clientProperties = new CoffeeNetConfigClientProperties(environment);
        clientProperties.setEnabled(false);

        return clientProperties;
    }

    @Bean
    CoffeeNetClientCredentialsResourceDetailsProperties coffeeNetClientCredentialsResourceDetailsProperties() {

        return new CoffeeNetClientCredentialsResourceDetailsProperties();
    }

    @Bean
    ConfigServicePropertySourceLocator configServicePropertySource() {

        final ConfigClientProperties properties = coffeeNetConfigClientProperties();
        final CoffeeNetClientCredentialsResourceDetailsProperties resourceDetailsProperties =
            coffeeNetClientCredentialsResourceDetailsProperties();

        ConfigServicePropertySourceLocator locator = new ConfigServicePropertySourceLocator(properties);
        locator.setRestTemplate(new OAuth2RestTemplate(resourceDetailsProperties));

        return locator;
    }

Next try
Then I thought maybe I have to completely override all ConfigClientProperties
so the last attempt was:
    @Bean
    @Primary
    ConfigClientProperties configClientProperties() {

        CoffeeNetConfigClientProperties clientProperties = new CoffeeNetConfigClientProperties(environment);
        clientProperties.setEnabled(false);

        return clientProperties;
    }

to expose the bean with the class  ConfigClientProperties. But then again not my
CoffeeNetConfigClientProperties will be used in my provided ConfigServicePropertySourceLocator
    @Bean
    ConfigServicePropertySourceLocator configServicePropertySource() {

        final ConfigClientProperties properties = configClientProperties();
        final CoffeeNetClientCredentialsResourceDetailsProperties resourceDetailsProperties =
            coffeeNetClientCredentialsResourceDetailsProperties();

        ConfigServicePropertySourceLocator locator = new ConfigServicePropertySourceLocator(properties);
        locator.setRestTemplate(new OAuth2RestTemplate(resourceDetailsProperties));

        return locator;
    }

and now maybe you can tell me what I am doing wrong :) Without any a @ConditionalOnMissingBean' it is very hard to inject my own ConfigClientProperties.class`.
Fyi the injection of the OAuth2RestTemplate is working well via
locator.setRestTemplate(new OAuth2RestTemplate(resourceDetailsProperties));

and? :) do you have some information for me?

After some thought, I dont' think we want to support users trying to subclass and replace our configuration properties.

Hmm, what if someone wants their own custom behavior to be part of the PropertySourceBootstrapConfiguration.  Not everyone wants to use .properties or .yml.  This is a similar issue that has been discussed around people want to load .json files in the Spring Cloud Config as in here:  https://github.com/spring-projects/spring-boot/issues/4027#issuecomment-144649875
As far as I can tell, that proposed theoretical solution and class in there (JsonPropertySourceLocator) does not work because it is never called even with META-INF/spring.factories defining it via org.spring.framework.boot.env.PropertySourceLoader=
I'm trying to understand if this really is a blindspot in SpringCloudConfig.  It does seem like reading in data from custom sources and utilizing the mechanism of SCC is a win-win for everyone. ??

PropertySourceBootstrapConfiguration is general and allows any PropertySourceLocator to be used. They are not sourced via spring.factories but as spring beans.


[GENERAL] Package takeover

@erkkikeranen
Hello, Erkki Keränen.
I want to take over your package to fix, maintain and improve it.
With best regards,
Vivien Richter

Hi @vivi90 ,
Thanks for your interest!
I’d be glad if you would like to do it. How would you like to  proceed?

@erkkikeranen I see there three possible ways:

Transfer the repository directly to me.
Create a new organization, transfer the repository there. Create a team with admin rights over this repository in this organization and add me to this team.
Move the repository to an existing similar organization: https://github.com/atom-extensions

@erkkikeranen Asked my team members. Waiting for the answer. :-)

Hi, I'll transfer over the repository to your organization.
I'm glad if you want to continue work on the project.
I would be glad if you mention me as the original author (Erkki Keränen) in the Readme, as a footnote :)
I have no particular interest in maintaining the organization, so I would prefer transfering the repo either to you or the atom-extensions organization (latter preferred?)

@erkkikeranen Of course you will be mentioned :slightly_smiling_face:
I am currently waiting for the okay of our organization owner.
So if you don't want to wait, it's okay to transfer it to me and i will later transfer it to the organization.

@erkkikeranen Okay, i have the okay of all my team members. Ready to take off :smile:
So please transfer it to: https://github.com/atom-extensions

@erkkikeranen We need also your API token from https://atom.io/account to be able to publish updates.

I'm currently a few days away from my computer, so I'll do it on thursday. Can you provide an e-mail adress or other mean to deliver api token?

@erkkikeranen Okay, no Problem :-) Yes, i will until thursday.

@erkkikeranen I see we don't really need the API token, if you transfer the whole repository to our organization.
So just transfer it to https://github.com/atom-extensions and everything is fine. :slightly_smiling_face:

I guess I need to transfer it to your personal account because I don't have write access to your organization

@erkkikeranen Just moved :slightly_smiling_face:
Thank you very much!

@erkkikeranen thanks 👍 and @vivi90 also for taking the time for it

@sdinesh86 Might you please adjust the team permissions for this repository, so we are able to rollout some fixes?

I have set Maintainers role to our group

@sdinesh86 As long as the ATOM_ACCESS_TOKEN is also authorized for use in this repository, it should be fine. :slightly_smiling_face:

@UziTech This package still needs a build process :-) Also maybe a switch-over to JavaScript?

I'm currently stretched pretty thin. It might take me a couple weeks to get to that but it is on my todo list.

@UziTech Okay, no problem :-)

@UziTech @sdinesh86 @erkkikeranen I think, it's time to close this issue now :tada:
Now i will starting with refactoring and rewriting the code.
@erkkikeranen Please don't hestitate to open an issue, if there is something you want to say. :slightly_smiling_face:


Dangerous data format default in SSIM

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): yes
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Red Hat Linux 7
TensorFlow installed from (source or binary): source
TensorFlow version (use command below): 2.2
Python version: 3.8
CUDA/cuDNN version: 10
GPU model and memory:

Describe the current behavior
SSIM assumes that the image batches have a shape (h, w, batch_size). This is not documented anywhere and the only reason I was aware of it is when I had a batch size smaller than 11, which triggers the following assertion to fail:
  checks = [
      control_flow_ops.Assert(
          math_ops.reduce_all(
              math_ops.greater_equal(shape1[-3:-1], filter_size)),
          [shape1, filter_size],
          summarize=8),
      control_flow_ops.Assert(
          math_ops.reduce_all(
              math_ops.greater_equal(shape2[-3:-1], filter_size)),
          [shape2, filter_size],
          summarize=8)
  ]

Because:
>>> shape = (4, 255, 255)
>>> shape[-3:-1]
(4, 255)

and filter_size = 11
Describe the expected behavior
This behaviour should be documented.
The user should have the choice to choose the data format : bath size first or last. By default, I think it should be batch size first as it's the way tf.data.Dataset handles the input pipeline.
Standalone code to reproduce the issue
This works
shape = (255, 255, 4)
img1 = tf.zeros(shape)
img2 = tf.zeros(shape)
tf.image.ssim(
    img1, img2, 1
)

But this doesn't
shape = (4, 255, 255)
img1 = tf.zeros(shape)
img2 = tf.zeros(shape)
tf.image.ssim(
    img1, img2, 1
)

@khazit
I have tried in colab with TF version 2.2,2.3-rc1.Please, find the gist here.You are refering to same behavior?
Thanks!

Yes it's the same behavior

@jvishnuvardhan any update on this ? I'm willing to make work on it.

I had the same question these days. After digging into the code
https://github.com/tensorflow/tensorflow/blob/14246bd0280d1c5e5564eedd4927bf9af9339967/tensorflow/python/ops/image_ops_impl.py#L4307
, it turns out that the implementation assumes the input data has a shape of (batch size, h, w, channel). It calculate the ssim per channel and takes the average for each image, i.e the return is expected to have a shape of (batch size,).
However, if the input data happens to have a shape of (batch size, h, w). It simply assume the input data has only 1 batch with a shape of (h, w, channel) and continue with the calculation. If the batch_size happens to be smaller than the filter_size, an exception will be raised during the shape check.
I would still call the implementation dangerous since people will get the wrong result with an input data shape of (batch size, h, w), when the batch_size is larger than the filter_size. It could still work nicely during training as a loss function (1 - ssim).
Finally, the correct way is to reshape the data to (batch size, h, w, 1).

I had the same question these days. After digging into the code
https://github.com/tensorflow/tensorflow/blob/14246bd0280d1c5e5564eedd4927bf9af9339967/tensorflow/python/ops/image_ops_impl.py#L4307
, it turns out that the implementation assumes the input data has a shape of (batch size, h, w, channel). It calculate the ssim per channel and takes the average for each image, i.e the return is expected to have a shape of (batch size,).
However, if the input data happens to have a shape of (batch size, h, w). It simply assume the input data has only 1 batch with a shape of (h, w, channel) and continue with the calculation. If the batch_size happens to be smaller than the filter_size, an exception will be raised during the shape check.
I would still call the implementation dangerous since people will get the wrong result with an input data shape of (batch size, h, w), when the batch_size is larger than the filter_size. It could still work nicely during training as a loss function (1 - ssim).
Finally, the correct way is to reshape the data to (batch size, h, w, 1).

@khazit Example in the doc was updated to clearly mention the data shape required for this function. Please check the updated example here. Thanks for raising this issue. Please check the gist here
Expected shape of a batch image is (batch_size, height, width, channels). The following works fine.
shape = (4, 255, 255,3)
img1 = tf.zeros(shape)
img2 = tf.zeros(shape)
tf.image.ssim(
    img1, img2, 1
)

output
<tf.Tensor: shape=(4,), dtype=float32, numpy=array([1., 1., 1., 1.], dtype=float32)>

I am closing this issue. Please feel free to reopen if I am mistaken. Thanks!

@khazit Example in the doc was updated to clearly mention the data shape required for this function. Please check the updated example here. Thanks for raising this issue. Please check the gist here
Expected shape of a batch image is (batch_size, height, width, channels). The following works fine.
shape = (4, 255, 255,3)
img1 = tf.zeros(shape)
img2 = tf.zeros(shape)
tf.image.ssim(
    img1, img2, 1
)

output
<tf.Tensor: shape=(4,), dtype=float32, numpy=array([1., 1., 1., 1.], dtype=float32)>

I am closing this issue. Please feel free to reopen if I am mistaken. Thanks!


Publish to FDROID

In README clicking on f-droid point to https://f-droid.org/repository/browse/?fdid=com.btcontract.wallet which return 404,
thus publish the app to FDROID via opening RFP in https://gitlab.com/fdroid/rfp/

An updated metadata has been merged yesterday here: https://gitlab.com/fdroid/fdroiddata/-/commit/2ede92d9bdef4ded4626672412ba96cbf679b748/pipelines?ref=master
I expect an app to become available on next site update (current timestamp on site is 2021-08-14).

App is now visible at https://f-droid.org/en/packages/com.btcontract.wallet/


Framerate settings don't work properly

Here's me moving my mouse around, recording in 30FPS: https://i.imgur.com/VTi80Ru.gif
Here's me moving my mouse around, recording in 60FPS: https://i.imgur.com/KYI8Ksw.gif
oh and I'll just leave this here https://i.imgur.com/V6Kg2hy.png

Frame rate
MP4
GIF

60
60FPS

30
30FPS

The reason might be a rather crude imaging timer.

Even 30fps is faster than it's supposed to be, so it doesn't seem specific to a framerate. At least, that seems so for the gif format.
Example: https://i.imgur.com/60UdS2w.gif (is being played back alot faster than how it happened)

Off I go to rewrite video (someone write a song). I'll be switching to libavdevice's x11grab/gdigrab/avfoundation.


Use latest Rubies :gem: :sparkles:

Refs.

https://www.ruby-lang.org/en/downloads/releases/
https://www.ruby-lang.org/en/news/2020/10/02/ruby-2-7-2-released/
https://www.ruby-lang.org/en/news/2020/03/31/ruby-2-6-6-released/
https://www.ruby-lang.org/en/news/2020/03/31/ruby-2-5-8-released/

@f440 Thank you for the review & merge. 🍺


Stop old epmd daemon if it's running

If the old daemon is running, the systemd version cannot bind to the port.

https://ocd.appscale.com:8080/job/Daily Build/3999/


chore: add mock db tables for tests

Pull Request Checklist

Code Style

[x] Code is following code style guidelines.
[x] Followed in new code.
[x] Corrected in existing code whenever possible.
[x] Spelling and English grammar errors have been eliminated.
[x] Attribute and variable names make sense.
[x] Stub files created or updated.
[x] New code is readable.
[ ] Execute 'make maintain' before committing changes and fix any issues.
[x] Code is not overly complicated; refactor if it is.
[x] Debugging, including print(), statements have been removed.

Tests

[x] At least one test for all newly created functions/methods?
[x] Tests capture key use cases.
[x] Enough edge cases covered for comfort.
[x] Code coverage has not decreased.

Documentation

[ ] Update api documentation to reflect the changes made.
[ ] Update the user documentation to reflect the changes made.

Chores

[ ] Problem areas outside the scope of this PR have an # ISSUE: comment
decorating the code block.  These # ISSUE: comments are automatically
converted to issues on successful merge.  Alternatively, you can manually
raise an issue for each problem area you identify.
[ ] TODO and FIXME statements have been have been converted to # ISSUE
: comments or removed in their entirety.
[ ] # ISSUE: comments have been removed for those issues this PR
addresses.
[ ] Update the features section of README.md for newly added work stream modules.

All PR checks pass.

[ ] Execute 'make format', 'make stylecheck', 'make typecheck', and 'make
lint' before committing changes and fix any issues.
[ ] Failing static checks are only applicable to code outside the scope of
this PR.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

This has been implemented through various PRs, one for each module.


[SwiftRepl] Improve the CMake build & simplify.

This is a grab bag of improvements for the repl. There are
several issues.

The repl needs a dummy target to run. There were two, one
written in C, the other in swift. The latter doesn't really
work and the only reason why nobody noticed is that only the
CMake build used it and there was no test whatsoever. The good
news is that's unneeded and can be removed.
The way the dummy executable was built with CMake was wrong
and unnecessarily complicated. This commit rewrites the logic
to be more readable (and commented).
This logic expects optimizations to be turned off, but
that was delegated to the build system. Now it's explicit
in the code via attributes, so that we don't have to duplicate
the logic across CMake/XCodebuild.

The logic is still fairly fragile as we dlopen() a library
looking inside @rpath. After speaking with Louis, he told me
that we shouldn't rely on this behaviour (and I tend to agree).
It's more complicated to fix because it involves touching also
the xcodebuild. This is left as a follow-up.

@swift-ci please test

The comment explaining the dlopen & weak linking (sic) to libswiftCore.dylib is:
* Weak link libswiftCore.dylib from repl_swift to sever a build dependency on OS X.
* In repl_swift.c, open libswiftCore lazily, and only look in the rpath.

I don't remember what the "build dependency" issue was - this was a Sean comment, so we can't ask him what's up.
But the other part of this is trying to make sure you only ever pull in the libswiftCore that comes with lldb - it explicitly sets the RPATH to:
@executable_path/../../../../../Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/swift/macosx @executable_path/../../../../../../usr/lib/swift/macosx @executable_path/../../../../../../../usr/lib/swift/macosx @executable_path/LLDB.framework/Resources/Swift/macosx @executable_path/Swift/macosx
That's missing from your cmake version.

I looked and it seems my $RPATH is set to nothing before the invocation so I'm not sure whether is required. Speaking with Louis, he said we really shouldn't mess around with @executable_path either as it's very dangerous.

Why is @executable_path dangerous?
In this case, it is important to make sure that you don’t by any means load a version of libswiftCore.dylib that isn’t the one you were built with.  If you don’t do that the REPL will fail.  On a system with lots of SDK’s installed, and then when running this to do testing out of a built tree, etc, there are lots of wrong choices you could make.    The RPATH ensures that won’t happen.  The fact that your version worked may be by luck, and it would be better not to count on that.
Jim

On Feb 20, 2018, at 5:44 PM, Davide Italiano<EMAIL_ADDRESS>wrote:
I looked and it seems my $RPATH is set to nothing before the invocation so I'm not sure whether is required. Speaking with Louis, he said we really shouldn't mess around with @executable_path either as it's very dangerous.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/apple/swift-lldb/pull/335#issuecomment-367185493, or mute the thread https://github.com/notifications/unsubscribe-auth/AOj620BlUpCfiqfvbzxDPjBPsAIqFYFhks5tW3TkgaJpZM4SM7oU.

The version specified in the rpath directory will have precedence on the others. As long as the build fills the library in the correct path, we should be fine, I think.
In the short term we're going to get rid of this code anyway. If this fails, please assign me a bug and I'll deal with the fallout.

@swift-ci please test linux

@swift-ci please test

@swift-ci please test

@swift-ci please test

@swift-ci please test linux

@swift-ci please test linux

@swift-ci please test linux


feat(frontend): Allow overriding frontend with a custom akka http server

This PR allows us to override the frontend's Akka HTTP server with a custom DataHub specific instance. This allows us to override Akka HTTP server settings such as the max header count (which currently isn't possible with our versions of Play + Akka). This is useful when we're trying to configure the DataHub frontend to talk to GMS using proxies like envoy. These proxies often add additional headers which often results in the frontend rejecting GMS responses as they exceed the allowed max header limits of 64.
Checklist

[ ] The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
[ ] Links to related issues (if applicable)
[ ] Tests for the changes have been added/updated (if applicable)
[ ] Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
[ ] For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@RyanHolstien - updated to add this env var to frontend.env as well.


feat: add keybindings configuration boolean

Why is this better than calling the function?

Just a bit more streamlined in my opinion.

Would be better then to have a keybinding table that gets applied, like for example nvim-cmp has

Doesn't really fit into the design ideas of the plugin


2:12 - Fractions

I'm feeling very stuck, especially as the user AlexAvlontis who posted an issue about this challenge seemed to have a completely different challenge to the one I'm working on.
Anyway, my code keeps blowing up here:
def lowest
    puts "lowest method is running"
    puts "Calculating numerator gcd"
  	@numerator = self.gcd @numerator, @denominator
    puts "Numerator gcd calculation complete"
    puts @numerator # => produces a blank line
    puts "Calculating denominator gcd"
  	@denominator = self.gcd @denominator, @numerator
    puts "Denominator calculation complete"
    puts "lowest method is complete"
    return @numerator, @denominator
end

def gcd(a,b) => # => Running from: puts "Calculating denominator gcd" : @denominator = self.gcd @denominator, @numerator
    puts "gcd method is running"
    return a if b == 0
    self.gcd(b, a%b) # => Throws the error: `%': nil can't be coerced into Float (TypeError)
    puts "gcd method is complete"
  end

I think I've misunderstood how fractions work, but it seems that the @numerator variable being passed to the gcd methods "b" parameter has nothng in it... which on further testing is indeed the case, as calling "puts" on it produces a blank line.  Let me go and revise basic mathematics, but can anyone shed light on why @numerator is being calculated to an empty variable by the code I'm currently using?

So I looked up the maths and found out about the Euclid's Algorithm, which the method uses.  Having seen how I'm misapplying it, I've corrected that only to have another TypeError syntax error at the end of my lowest method instead.  It looks like the gcd method is still calculatngt a blank value...

In your lowest method you need to call the class again. i.e Fraction.new(lnumerator, ldenominator)

Thank you @tcpickard94 for commenting, I can see the point you make, but that does not resolve the error unfortunately.  Running the lowest method with the gcd method as follows:
 def lowest

    puts "lowest method is running"

    puts "Calculating gcd"

  	cgcd = gcd @numerator, @denominator

    puts "gcd calculation complete"

    puts cgcd

    lnumerator = @numerator / cgcd

    ldenominator = @denominator / cgcd

    puts "lowest method is complete"

    Fraction.new lnumerator, ldenominator

  end

 def gcd(a,b)
    puts "gcd method is running"
    puts a
    return a if b == 0
    self.gcd(b, a%b)
    puts "gcd method is complete"
  end

Produces the following output:
lowest method is running
Calculating gcd
gcd method is running
20.0
gcd method is running
60.0
gcd method is running
20.0
gcd method is complete
gcd method is complete
gcd calculation complete

/home/jeremy/Dropbox/Github/ruby-kickstart/session2/3-challenge/12_classes.rb:79:in `/': nil can't be coerced into Float (TypeError)
	from /home/jeremy/Dropbox/Github/ruby-kickstart/session2/3-challenge/12_classes.rb:79:in `lowest'
	from /home/jeremy/Dropbox/Github/ruby-kickstart/session2/3-challenge/12_classes.rb:95:in `<main>'

[Finished in 0.4s with exit code 1]

So for some reason, the a variable in gcd disappears in the 4th iteration.  But I can't figure out why.

I think i've worked it out. It is to do with your gcd method. Remove the line (the puts statement) as this is returning when b != 0. Let me know if it works

hey @Jeremy-Barrass thanks for pointing it out my typo, i meant 2:13 :)

@AlexAvlonitis: No problem, it did confuse me for a bit. :)
@tcpickard94: You were right, taking out all the puts from gcd fixed the return.  Hooray!  And thank you.  Funny how trying to debug made it worse.  Just the to_f method from the challenge returning 0 to fix now...

@Jeremy-Barrass No problem. Glad you sorted it!

All solved now, my thanks to the contributors here.


Use ForestConnection() for all connections to forest

There are three different endpoints.
fixes #629
need to actually test that this fixes the problem it does

There's a lot of redundancy between PyQuilConfig and ForestConnection. We can revisit this after the forthcoming release


pkgsStatic for 18.09

Motivation for this change
A backport of #48803 for those wanting to use this but unable to switch from stable to master. A note is adding saying the interface is provisional. Presumably in 19.03 this will arrive on staging "the normal way" and the dust will have settled again.
Rebased on a recentish common ancestor of master and relase-18.09. This way any further fixes can be made on top of this (minus the top commit) and then easily merged into both master and release-19.09. This is a lot easier than cherry-pick; with cherry-pick alone it wouldn't make sense to pre-release new interfaces on stable.
N.B. I skipped b966d3c5835fdbaa153a9eacd08cdbf789ee1b40 because that is a breaking interface change not appropriate for stable.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

CC @vaibhavsagar

This is missing a patch for portable libsystem

@matthewbauer that was done after the original PR?

Ah I think you mean #51881 or 5d6b7c74adbcd067d46c8bd7866ba553968bad56, both of which are not merged (not sure whether the last one is in a PR either.) So I think this is ready to go; I can comment what branch to rebase unmerged work on or (with permission) do the force-push myself.

0b85745 Should be added. Otherwise darwin stuff is broken.

Oh 5d6b7c74adbcd067d46c8bd7866ba553968bad56 was rebased onto master by github but the original commit not deleted. Fix now, with a small tangle of merges (sorry!).

https://github.com/NixOS/nixpkgs/commit/af2cebe78fd185d1bbabd071f85f74654602d042 is the cherry-pick. It's on master and release-18.09 as expected.


Hebrew added

Coverage remained the same at 99.19% when pulling 6852713c45ffe7630d46e68efa1952be7cf27f0b on mocheaz:master into a46ccda87056916cbcd154dfe5fc759cc33c857f on charliekassel:master.

Hey thanks for your contribution!

Can you add into the readme languages section?

Done
On 17 November 2016 at 16:46:52, charliekassel<EMAIL_ADDRESS>wrote:
Can you add into the readme languages section?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/charliekassel/vuejs-datepicker/pull/34#issuecomment-261265204,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAT-iYN_r42WfPXJo3aGVt2xd3Nktq-Hks5q_GjbgaJpZM4KxbNt
.


Unable to minify javascript with PHP minifier.

Using the library available at http://code.google.com/p/minify/, there is no way of having it aggregate and gzip the bootstrap javascript library.
Implementations with bootstrap.min.js, bootstrap.js or even separate libraries always fail.
Looking at the amount of issues regarding the minify issues, shouldn't the library implement a code structure that would allow the usage of 3rd party libraries that can compress/minify the Bootstrap code to allow a faster implementation and allow also one request for all javascripts?

I'm using Sprockets to compress them and it works just fine. I bet php minifier is the problem.


[BUG]  Inability to Create Catalog via REST API Without Using Polaris CLI First

Is this a possible security vulnerability?

[X] This is NOT a possible security vulnerability

Describe the bug
When creating a catalog using the CLI, a CreateCatalogRequest is created, and a CatalogEntity gets persisted in the underlying storage. During this process, the IcebergCatalogAdapter#getConfig (corresponding to the api/v1/config) is invoked, which fetches the catalog name surfaced in the warehouse field and returns properties (https://iceberg.apache.org/docs/latest/configuration/#catalog-properties) for overrides if applicable.
However, when creating a catalog for the first time (assuming it was not done using the Polaris CLI), there is no existing catalog unless you bypass the api/v1/config call and directly invoke catalog creation, similar to the CLI (as seen in regtests). For example, when using the Java core API, the process first fetches the config during catalog build (org.apache.iceberg.rest.RESTSessionCatalog.initialize) to determine if any overrides are required. This results in the error:
Exception in thread "main" org.apache.iceberg.exceptions.RESTException: Unable to process: Unable to find warehouse XXXX
I am forced to first create the catalog using the Polaris CLI and cannot achieve the same via the REST endpoint by specifying the warehouse location in the configuration.
Would returning something like {"defaults":{},"overrides":{}} be a solution in this case? Also, why is it that the warehouse field requires the catalog name instead of allowing a direct reference to locations like S3 or Blob storage?
Is this expected behavior; where we must first create the catalog using the Polaris CLI?
Or did I overlook something?
Thanks in advance.
To Reproduce
Use Java Core API to create a Catalog.
Actual Behavior
If Catalog unknown to Polaris, Error is raised when creating a new catalog (NOT FOUND)
Expected Behavior
Empty Result ?
Additional context
No response
System information
MacBook Pro: 2.9 GHz Quad-Core Intel Core i7

Also it looks like the implementation is not matching the API Spec https://github.com/apache/iceberg/blob/208ab20dc9ab8bcab3ee525d0ddaba80eeae7609/open-api/rest-catalog-open-api.yaml#L75

Something seems to be off. I do recalled I can do those via REST directly. Will set up a test environment then provide an update.

@mouadk
Here is the steps I performed to create catalog via REST directly without going through CLI:
show current catalogs if any:
yong@DESKTOP:~$ curl -X GET -H "Authorization: Bearer principal:root;realm:default-realm" http://localhost:8181/api/management/v1/catalogs
{"catalogs":[]}

create a new catalog with file as storage backend (file is only for local testing purpose):
yong@DESKTOP:~$ curl -X POST -H "Authorization: Bearer principal:root;realm:default-realm" "http://localhost:8181/api/management/v1/catalogs" \
>   -H "Content-Type: application/json" \
>   -d '{
>         "catalog": {
>           "name": "polaris",
>           "type": "INTERNAL",
>           "readOnly": false,
       "properti>           "properties": {
>             "default-base-location": "file:///tmp/polaris/"
>           },
>           "storageConfigInfo": {
>             "storageType": "FILE",
>             "allowedLocations": [
>               "file:///tmp"
>             ]
>           }
>         }
>       }'

list the catalogs again:
yong@DESKTOP:~$ curl -X GET -H "Authorization: Bearer principal:root;realm:default-realm" http://localhost:8181/api/management/v1/catalogs
{"catalogs":[{"type":"INTERNAL","type":"INTERNAL","name":"polaris","properties":{"default-base-location":"file:///tmp/polaris/"},"createTimestamp":1732459417891,"lastUpdateTimestamp":1732459417891,"entityVersion":1,"storageConfigInfo":{"storageType":"FILE","storageType":"FILE","allowedLocations":["file:///tmp","file:///tmp/polaris/"]}}]}

Let me know if is still causing issue for your setup.


Fix SpriteFrames editor visibility problems

Fixes #80756
I checked other editors and all handle it properly (except the permanent ones, which don't auto-close).

Just tested this and it works as expected.


UI - General - Upgrade modal

Hi @chad11111
I'll be glad to take this one

Is this issue still open?


Content update for individual section

What is the context of this PR?
All the content changes, new address questions and amended routing as per slides. I have created a separate card for validation as not needed for translations and looking tricky for me!
How to review
Donna has reviewed all content and routes. You can review against slides https://docs.google.com/presentation/d/1BWjHrAfjxgyR69Jwys4BPahm9JF6eUbz2lIkd1se-TQ/edit?usp=sharing
Checklist

[ ] New static content marked up for translation
[ ] Newly defined schema content included in eq-translations repo

The content looks sane. i've not run it yet though

@jonnyshaw89 The rebase seems to have broken this. Were there conflicts or anything?


Question: How to get the types array to load using System.js.

I am currently using the plugin-typescript to do in-browser compiling of an Angular 2 application, but I can't seem to get the types to be loaded. Here are the typescript options I have in my system.js config:
typescriptOptions: {
    emitDecoratorMetadata: true,
    experimentalDecorators: true,
    module: "commonjs",
    moduleResolution: "node",
    noImplicitAny: true,
    removeComments: false,
    sourceMap: true,
    suppressImplicitAnyIndexErrors: true,
    target: "es5",
    typeCheck: true,
    types: [ "node" ]  // <---- This is the part I am trying to get to work.
}

... notice the types: [ "node" ]. However, when I load the app, I do not see any network requests to node_modules/@types/node. Is there something that I have to do to tell the typescript plugin to actually load the types?
Because it's not loading, my references to moduleId: module.id are throwing the error:
TypeScript [Error] Cannot find name 'module'. (TS2304)

Everything else is working, in so much as the .ts files are being loading and transpiled to es5 and my Angular 2 app loads. I just can't figure out how to get rid of that compiler error. Thanks!
Also, my dependencies in package.json:
"dependencies": {
    "@angular/common": "2.1.1",
    "@angular/compiler": "2.1.1",
    "@angular/core": "2.1.1",
    "@angular/forms": "2.1.1",
    "@angular/http": "2.1.1",
    "@angular/platform-browser": "2.1.1",
    "@angular/platform-browser-dynamic": "2.1.1",
    "@angular/router": "3.1.1",
    "@types/core-js": "^0.9.34",
    "@types/node": "^6.0.45",
    "core-js": "^2.4.1",
    "plugin-typescript": "5.2.7",
    "reflect-metadata": "^0.1.8",
    "rxjs": "5.0.0-beta.12",
    "systemjs": "0.19.39",
    "typescript": "^2.0.3",
    "zone.js": "^0.6.25"
}

If I use files instead of types, it seems to load the d.ts file; but, I am not sure this is the recommended approach?
typescriptOptions: {
    ....
    files: [<EMAIL_ADDRESS>],
    ....
}

What does the rest of your system.config.js file look like?

@aluanhaddad this is what I have at the moment for my in-browser demos:
(function( global ) {

	System.config({
		paths: {
			"vendor/*": "../../vendor/angular2/2.1.1/*",
			"~/*": "./app/*"
		},
		map: {
			"@angular": "vendor/node_modules/@angular",
			"plugin-typescript": "vendor/node_modules/plugin-typescript/lib/plugin.js",
			"rxjs": "vendor/node_modules/rxjs",
			"ts": "vendor/node_modules/plugin-typescript",
			"typescript": "vendor/node_modules/typescript"
		},
		packages: {
			"@angular/common": {
				main: "bundles/common.umd.js",
				meta: {
					"bundles/common.umd.js": {
						typings: "index.d.ts"
					}
				}
			},
			"@angular/compiler": {
				main: "bundles/compiler.umd.js",
				meta: {
					"bundles/compiler.umd.js": {
						typings: "index.d.ts"
					}
				}
			},
			"@angular/core": {
				main: "bundles/core.umd.js",
				meta: {
					"bundles/core.umd.js": {
						typings: "index.d.ts"
					}
				}
			},
			"@angular/forms": {
				main: "bundles/forms.umd.js",
				meta: {
					"bundles/forms.umd.js": {
						typings: "index.d.ts"
					}
				}
			},
			"@angular/http": {
				main: "bundles/http.umd.js",
				meta: {
					"bundles/http.umd.js": {
						typings: "index.d.ts"
					}
				}
			},
			"@angular/platform-browser": {
				main: "bundles/platform-browser.umd.js",
				meta: {
					"bundles/platform-browser.umd.js": {
						typings: "index.d.ts"
					}
				}
			},
			"@angular/platform-browser-dynamic": {
				main: "bundles/platform-browser-dynamic.umd.js",
				meta: {
					"bundles/platform-browser-dynamic.umd.js": {
						typings: "index.d.ts"
					}
				}
			},
			"@angular/router": {
				main: "bundles/router.umd.js",
				meta: {
					"bundles/router.umd.js": {
						typings: "index.d.ts"
					}
				}
			},
			"app": {
				main: "main.ts",
				defaultExtension: "ts",
				meta: {
					"*.ts": {
						loader: "ts"
					}
				}
			},
			"vendor/node_modules": {
				defaultExtension: "js"
			},
			"rxjs": {
				meta: {
					"*.js": {
						typings: true
					}
				}
			},
			"ts": {
				main: "lib/plugin.js"
			},
			"typescript": {
				main: "lib/typescript.js",
				meta: {
					"lib/typescript.js": {
						exports: "ts"
					}
				}
			}
		},
		transpiler: "plugin-typescript",
		transpiler: "ts",
		typescriptOptions: {
			emitDecoratorMetadata: true,
			experimentalDecorators: true,
			files: [<EMAIL_ADDRESS>],
			module: "commonjs",
			moduleResolution: "node",
			noImplicitAny: true,
			removeComments: false,
			sourceMap: true,
			suppressImplicitAnyIndexErrors: true,
			target: "es5",
			typeCheck: true
		}
	});

	// Load "./app/main.ts" (gets full path from package configuration above).
	global.bootstrapping = System
		.import( "app" )
		.then(
			function handleResolve() {

				console.info( "System.js successfully bootstrapped app." );

			},
			function handleReject( error ) {

				console.warn( "System.js could not bootstrap the app." );
				console.error( error );

				return( Promise.reject( error ) );

			}
		)
	;

})( window );

So I think the issue here is that plugin-typescript is treating the types option differently to tsc. plugin-typescript uses it to indicate that typings are available for this package under @types and will then make those typings available in files which import the module. I think that tsc uses it to mean that these typings should be made available in all files being compiled (ie they are peer dependencies)
The reason for this is that tsc is able to automatically find and include typings from @types when a module is imported but plugin-typescript needs to know if they are present in advance (due to the browser loading requirement)
@aluanhaddad - does this sound correct to you with regard to the tsc handling of the types option?
There are a few ways to solve this

make typings in the types array available in all compiled files
have a new option availableTypes to tell plugin-typescript which packages have typings under @types and revert the types option to have the same behaviour as tsc.
force people to use either the files setting or /// <reference types="node"/> statements to include peer dependency typings

(1) is probably the easiest, but may mean that types are available in files which are not importing the module. (2) is a breaking change, but probably more correct. Probably I should implement (2) as a major change, although first I will find out what the impact of doing (1) will be.

@frankwallis thanks for the insight. I "mostly" understand what you're saying. For the time being, I'll just stick with using the files array since it at least seems to work.

@frankwallis Yes, I believe your understanding of how tsc and tsserver use the types array is correct. This behavior is fairly new in TypeScript itself, and to be honest the whole feature is somewhat problematic.
For example if the types array is not specified, the compiler will include all @types packages in the node folder and make them available in all files.
The types array is actually a way to restrict this behavior, only including those packages specified but as you say, it is global to the compilation context.
They indeed behave like peerDependencies, but since they are not specified that way, version conflicts are rampant.
There are a number of open issues regarding this behavior for example, https://github.com/Microsoft/TypeScript/issues/11917.
I think it is an open question how this should behave, but my preference is for explicitness. This is one of the reasons I prefer jspm to npm.

plugin-typescript is treating the types option differently to tsc. plugin-typescript uses it to indicate that typings are available for this package under @types and will then make those typings available in files which import the module

I think this behavior is actually good but it does conflict with the behavior of tsc. One reason to keep the existing behavior is that @types packages mostly expose UMD style declarations that are global by default until they are imported as modules. In that sense the way plugin-typescript currently behaves seems to be more inline with SystemJS and jspm.

type-checking is no longer supported in 7.0.0 so this is no longer an issue


Added note for OpenMP disabling.

something that Travis/Jenkins don't like here, @georgebisbas

something that Travis/Jenkins don't like here, @georgebisbas

Maybe it is just a comma>? Lets test again...


Added badge badge

Added the Badge Badge check
Signed-off-by: French Ben<EMAIL_ADDRESS>

[Current coverage][cc-pull] is 20.16%

Merging [#19][cc-pull] into [master][cc-base-branch] will increase coverage by 4.24%

@@             master        #19   diff @@
==========================================
  Files            13         13
  Lines          1131       1131
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits            180        228    +48
  Misses          903        903
+ Partials         48          0    -48

Powered by Codecov. Last updated by [20882a7...50a8a16][cc-compare]
[cc-base-branch]: https://codecov.io/gh/docker/go-p9p/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/docker/go-p9p/compare/20882a7be95f6f0dc90bb238024bcf890513e1ff...50a8a16a89824975e76df0c5fd2202ea54ef345e
[cc-pull]: https://codecov.io/gh/docker/go-p9p/pull/19?src=pr

LGTM
We'll update when we get a real domain name.


"Basics" link is a 404

What docs page needs to be fixed?
The link to basics on the main README (front github page)
What is the problem?
Clicking "basics" leads to the redux website but says the page is not found (https://redux.js.org/basics).
What should be changed to fix the problem?
The URL should be https://redux.js.org/basics/basic-tutorial

Could you submit a PR to fix this?


How to create a new tag from selectMultiple on a manyToMany relationship

Laravel Version: 5.5.40
PHP Version: 7.1.3-3
Laravel-admin: 1.5.9

I have a Posts table that has a many to many relationship with Tags table.
When editing a record on Posts I'm populating a selectMultiple field with all existing Tags record. How can 'save' and 'sync' a new tag ?

Here's an example


webhooks enhancement: contentUrl in payload

On Tableau Server, users can sign in to the default site and then obtain site information in a following request to handle webhooks from different sites on the same server dynamically by matching the site-luid from the webhook payload with a site-id on the server.
On Tableau Cloud the contentUrl (site name) must always be declared in the authentication flow however, this requires manually writing sites down somewhere and would be a pain to maintain. If the site name is provided in the webhook payload then downstream applications are able to authenticate to the matching tableau site for automation.

testing a workbook webhook event on requestbin resulted in this event:
{
"method":"POST",
"path":"/",
"query":{},
"client_ip":"<IP_ADDRESS>",
"url":"https://eofx5lzsa1zh60o.m.pipedream.net/",
"headers":{
  "host":"eofx5lzsa1zh60o.m.pipedream.net",
  "content-length":"325",
  "user-agent":"TableauWebhooks/1.0",
  "accept-encoding":"gzip,
  deflate",
  "accept":"*/*",
  "content-type":"application/json",
  "x-tableau-env":"TableauOnline",
  "traceparent":"00-2b650fa5c342e5f5d83507648f00c6df-c872e2a6fb10037d-01",
  "tracestate":"1226690<EMAIL_ADDRESS>"newrelic":"eyJ2IjpbMCwxXSwiZCI6eyJ0eSI6IkFwcCIsImFjIjoiMTM5Njk5OSIsImFwIjoiVW5rbm93biIsInRyIjoiMmI2NTBmYTVjMzQyZTVmNWQ4MzUwNzY0OGYwMGM2ZGYiLCJzYSI6dHJ1ZSwicHIiOjEuNzIwMjQ2LCJ0eCI6IjU1ZjFlNTZlNzJiN2M2MzQiLCJ0aSI6MTY2NDAwMjgyMjcwOSwidGsiOiIxMjI2NjkwIiwiaWQiOiJjODcyZTJhNmZiMTAwMzdkIn19"},
"body":{
  "site_luid":"14d41e12-74ea-4b7d-83bd-ed254673e929",
  "resource":"resource-type",
  "resource_luid":"resource-luid",
  "resource_name":"resource-name",
  "event_type":"Test","created_at":"1/1/1970",
  "text":"Event Test for resource 'resource-name: resource-luid' on site 14d41e12-74ea-4b7d-83bd-ed254673e929 posted at 1/1/1970"
}
}


Work to improve mobile nav ui.

Assets Add:
1) static/github.png (Github Icon)
2) static/google-plus.png (Google Plus Icon)
3) static/mail.png (Mail Icon)
4) static/twitter.png (Twitter Icon)
Change:
1) In NavBar.vue
-Remove BioJS from written on main navbar.
-Remove '#mobileNav h2 and #mobileNav span' css rules.
+Add Logo in place of BioJS but on right side on navbar and also a link which navigate to home.
+Add BioJS on navbar menu container.
+Add few css for for navbar.
+Add Few icon on bottom on navbar menu container bottom.
+-Modified css property of .close (close class). change the value of top to 35px.
+-Modified css property of #nav (nav id). Remove padding-top property.
+-Modified transition value from 0.3s to 0.2s
Fixes #28

Images of mobile navbar.


Review CSS API

complete review of the various CSS items available outside of Bootstrap

confirmed the use of Bulma


Fix the deprecation warnings in the strongbox-data-service module

Task Description
The strongbox-data-service module uses or overrides a deprecated API and this will have to be investigated and fixed.
14:19:30 [INFO] /home/jenkins/workspace/jenkins-strongbox-strongbox-master-2023-SGXT8nC/strongbox-data-service/src/main/java/org/carlspring/strongbox/config/HazelcastConfiguration.java: /home/jenkins/workspace/jenkins-strongbox-strongbox-master-2023-SGXT8nC/strongbox-data-service/src/main/java/org/carlspring/strongbox/config/HazelcastConfiguration.java uses or overrides a deprecated API.
14:19:30 [INFO] /home/jenkins/workspace/jenkins-strongbox-strongbox-master-2023-SGXT8nC/strongbox-data-service/src/main/java/org/carlspring/strongbox/config/HazelcastConfiguration.java: Recompile with -Xlint:deprecation for details.
14:19:30 [INFO] /home/jenkins/workspace/jenkins-strongbox-strongbox-master-2023-SGXT8nC/strongbox-data-service/src/main/java/org/carlspring/strongbox/data/criteria/DetachQueryTemplate.java: Some input files use unchecked or unsafe operations.
14:19:30 [INFO] /home/jenkins/workspace/jenkins-strongbox-strongbox-master-2023-SGXT8nC/strongbox-data-service/src/main/java/org/carlspring/strongbox/data/criteria/DetachQueryTemplate.java: Recompile with -Xlint:unchecked for details.
14:19:30 [INFO]

Help

Our chat
Points of contact:

@carlspring
@sbespalov
@fuss86

Can I have a take at this?

Hi @prbobba ,
Yes, please! Also, feel free to join our chat!

#1098


Increase Spacing Of nav bar from right

Description
The nav bar is hurdled towards the right side
Expected Behavior
Should be a little left
before fixing

after fixing this should look this this

you can assign that task to me under gssoc-ext and hacktoberfest label..

some one already did it. This issue is now closed.


Using an extra field instead of another relationship for StagedManyManyRelationExtension

We should look into using an extra field instead of another relationship for StagedManyManyRelationExtension this would get away from the issue of table length and reduce the number of tables needed on a site. A nice bonus would be if we could handle adding the field to the extraFields on our own. The trick will be though if we can or cannot modify the query for the list in without additional code by the developer using the module.
If we do this it should trigger a 1.0.0 tag since it's breaking for the current releases.

This won't work... the idea dies when you try to get the extra data, as far as the SilverStripe ORM is concerned you have a duplicate row in the database so which one do you pull the extra data from? There's no easy way to tell. Perhaps one thing we could do to help make this extension easier is have the extension define the "_Live" relationship.


Browser build broken by

https://travis-ci.org/tmpvar/jsdom/jobs/282094550#L568
I'm getting really tired of not being able to run browser tests for PRs...

Hmm... we should probably just skip that test.

We could maybe append a number of blank lines equal to the line offset in the vm shim?

It seems we're destined to be off by one because using the Function() constructor shifts all lines forward by one. I can't think of a workaround, so indeed, let's disable...


Maven download URLs are yanked, Red Hat build fails when new releases are issued

The Red Hat Universal Base Image (UBI) based docker image fails when new Maven releases are made available and the previous version URL begins 404ing:
RUN curl https://dlcdn.apache.org/maven/maven-3/3.8.6/binaries/apache-maven-3.8.6-bin.tar.gz -o maven.tar.gz \
    && tar -xvf maven.tar.gz \
    && mv apache-maven-3.8.6 /pulumi/ \
    && rm maven.tar.gz

I think we ought to:

Use the distro's packaged version of maven, which is 3.5.4 presently.
If 3.5.x is not compatible with Pulumi Java, consider updating our UBI image to RHEL 9 / UBI 9, which packages Maven 3.6.x.,
If 3.6.x is not compatible with Pulumi Java, use another install process for obtaining Maven.

The above should equally apply to gradle, as our Docker image also hardcodes a specific Gradle release.

@dixler, @t0yv0 curious for your thoughts here, I figured there's probably a reason we didn't use Red Hat's maven.
I did find this interesting tool while searching GitHub for other ubi8/9 images which included Gradle.
https://github.com/devfile/developer-images/blob/3055e6de254fd2fba9029460e332b4178c889530/universal/ubi8/Dockerfile#L22-L33
These lines stood out:
             && sdk install gradle \
             && sdk install maven \

Where sdk is a CLI provided by https://sdkman.io/ which makes it easy to install and manage Java SDKs.


P5 language reference index has malformed HTML

http://p5js.org/reference/
...needs a quick fix. Some tag issue has left a few things unusable/unreadable.
Normally wouldn't put this in as an editor issue, but since it's the page that Help > Reference leads to...

thanks! should be fixed now thanks to @toolness


feat(nodes): add resize and scale latents nodes

this resize/scale latents is what is needed for hires fix
also remove unused seed from t2l

@Kyle0654 request your review on this

@Kyle0654 Thanks for reviewing.
Generally, this does work as expected (did a lot of testing, creates awesome hires fix outputs, and decoding the resized latents immediately gives you some interesting visuals for the different interpolation settings).


Website does not have proper meta tags

Issue: The website does not have meta tags with descriptions.
Impact: This means that the website is not as visible in search results, and users are less likely to click on the website's links.
Resolution: The website should contain important meta tags. This will help the website rank higher in search results and attract more visitors.

Hey @Avinash905 , You can't have another issue before completing the previous one 😀
you already have the following 1 open issues 👀 ! :
#1563

Hey @Avinash905 ! Thank you so much for your raising the issue💗
It’s all yours, you can come anytime again and make some contributions! 🚀
Alone, we can do little, but together we can do so much! 😇

Hey @Avinash905 !
Thank you for raising an issue 💗
You can self assign the issue by commenting /assign in comment 😀
Make sure you follow CODE OF CONDUCT and CONTRIBUTING GUIDELINES 🚀
Don’t Forget to ⭐ our GameZone🎮
Make sure you join our Discord🕹


This should be done directly in Serving, not in knative/pkg.

/hold
While I get the serving side decoupled from this.

/retest

/hold cancel
Ok the serving PR is out.

/lgtm


Defragment incoming stream chunks (fixes #431)

Here's an attempt at solving that old memory fragmentation issue. The 32 threshold is just a simple heuristic: in the worst case we accept 32 1-byte chunks from 32 different datagrams, 32k of unnecessary allocations, but hopefully most applications would not get up to 32 chunks in the buffer so that they would not trigger the (relatively slow) defragmentation code.
Let me know what you think!

This is a beautiful solution, great work! I was imagining much more complex approaches.

Me too! I was quite happy that I came up with this little thing last night, although I lost some sleep over it. 😄


Fix for bentoml integration/example

Fixes for bentoml example. Requires:

some daemon checks to be commented out from local_service.py
as well as pinning BentoML to 1.0.10 (whereas the current version is 1.0.21).

Pre-requisites
Please ensure you have done the following:

[ ] I have read the CONTRIBUTING.md document.
[ ] If my change requires a change to docs, I have updated the documentation accordingly.
[ ] If I have added an integration, I have updated the integrations table and the corresponding website section.
[ ] I have added tests to cover my changes.

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Other (add details above)

Closing in favor of #1604


Wordwrap causes flickering

In the explorer, in "list" view mode, when i have files that have long names (need word-wrapping), scrolling the file list causes flickering, making scrolling hard to handle. Works fine in card view mode.
This is especially annoying when using side-by-side (either 2 or 3) layouts.
My guess is that it's probably due to height calculations in the scrolling component, so my suggestion would be to use ellipsis rather than word-wrapping, and use some kind of tooltip to show the full name of the file.
Tested on chrome both on PC and Android, same behaviour.

Thanks, @delegreg for reporting this issue. There was a code that rendered an empty div till it is not visible on the viewport, which was causing that issue. Pushed on the master, Please have a look.


[Snyk] Security upgrade python from 3.9.15 to 3.13.0a1

This PR was automatically created by Snyk using the credentials of a real user.Keeping your Docker base image up-to-date means you’ll benefit from security fixes in the latest version of your chosen image.
Changes included in this PR

dev/Dockerfile.mlflow

We recommend upgrading to python:3.13.0a1, as this image has only 173 known vulnerabilities. To do this, merge this pull request, then verify your application still works as expected.
Some of the most important vulnerabilities in your base image include:

Severity
Priority Score / 1000
Issue
Exploit Maturity

829
Out-of-bounds Write SNYK-DEBIAN11-LIBWEBP-5893094
Mature

829
Out-of-bounds Write SNYK-DEBIAN11-LIBWEBP-5893094
Mature

829
Out-of-bounds Write SNYK-DEBIAN11-LIBWEBP-5893094
Mature

829
Out-of-bounds Write SNYK-DEBIAN11-LIBWEBP-5893094
Mature

829
Resource Exhaustion SNYK-DEBIAN11-NGHTTP2-5953384
Mature

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
🛠 Adjust project settings

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Resource Exhaustion

legit fix


restructure deploy dir with numeric prefixes and explicitly set all n…

…amespace-level services to the benchmark namespace

Needs a rebase

Rebase complete

This will require updating the test.sh and tests/common.sh as well as they use it to apply definition.

This brings up an interesting question. If the operatory.yaml file is in the deploy/ directory, then a kubectl apply -f deploy will ultimately deploy the operator itself. Currently, the tests are designed to create and destroy the operator within each test functional test script. Would it not make more sense to start the operator once, run the sequence of tests, and then stop the operator? Or is there some reason that I'm not considering for the operator to start/stop with each functional test?

This brings up an interesting question. If the operatory.yaml file is in the deploy/ directory, then a kubectl apply -f deploy will ultimately deploy the operator itself. Currently, the tests are designed to create and destroy the operator within each test functional test script.

Thats right, I didn't even think about that.  Maybe we'll need to leave out operator and crd in resource dir.

Would it not make more sense to start the operator once, run the sequence of tests, and then stop the operator? Or is there some reason that I'm not considering for the operator to start/stop with each functional test?

That's what we're doing with full_test.sh, except we're not running that in CI yet, but we'll eventually be doing that. The functional test idea was to sort of test each workload independently as if the operator was created just for the workload, and not worrying about resources that were left behind from previous workloads.

This brings up an interesting question. If the operatory.yaml file is in the deploy/ directory, then a kubectl apply -f deploy will ultimately deploy the operator itself. Currently, the tests are designed to create and destroy the operator within each test functional test script.

Thats right, I didn't even think about that. Maybe we'll need to leave out operator and crd in resource dir.

Would it not make more sense to start the operator once, run the sequence of tests, and then stop the operator? Or is there some reason that I'm not considering for the operator to start/stop with each functional test?

That's what we're doing with full_test.sh, except we're not running that in CI yet, but we'll eventually be doing that. The functional test idea was to sort of test each workload independently as if the operator was created just for the workload, and not worrying about resources that were left behind from previous workloads.

I guess I don't see the added value of re-starting the operator for each functional test. Maybe I'm missing something?
I would recommend one test.sh script, that does not require an edit every time a test is added to the tests/ directory. Just glob the files from that directory that match the test_*.sh naming convention, start the operator, run all tests, stop the operator. If we want to get fancy, we can add a command line option to test.sh that allows you to list by name the tests you want to run, defaulting to all tests if no options are passed.

The added value of re-starting operator is for the operator logs to have nothing old, and the new CR file being the only CR file it has ever encountered thus ensuring nothing was left behind that the operator is dealing with or was dealing with mid execution when we applied a new CR file.
We already have the full_test.sh that accomplishes pretty much the same you're referring to, and we want to start with a fresh operator to ensure that everything is clean before we kick off a new workload and test it.

The added value of re-starting operator is for the operator logs to have nothing old, and the new CR file being the only CR file it has ever encountered thus ensuring nothing was left behind that the operator is dealing with or was dealing with mid execution when we applied a new CR file.
We already have the full_test.sh that accomplishes pretty much the same you're referring to, and we want to start with a fresh operator to ensure that everything is clean before we kick off a new workload and test it.

Hmm. This bugs me a bit, as I feel like there is a more sustainable way to handle this. I'd like to be able to kubectl apply -f deploy/ and have the operator up-and-running in its namespace, but making that happen right now with these changes breaks too much about the tests. So I will revert that part of the change for now and we can circle back on this later.

What I was trying to say was that instead of doing kubectl apply -f deploy in our tests/common.sh we can split it like we'd earlier thus we'll allow for users to do kubectl apply -f deploy and then pick a cr file while testing we'd do kubectl apply -f 001.. and so on.

What I was trying to say was that instead of doing kubectl apply -f deploy in our tests/common.sh we can split it like we'd earlier thus we'll allow for users to do kubectl apply -f deploy and then pick a cr file while testing we'd do kubectl apply -f 001.. and so on.

That could make sense, but it could also make maintaining the test scripts more cumbersome since any additions to deploy/ would also mean that common.sh would need to be updated.
Let's think through this a bit more...

/rerun minishift

/rerun minishift

/rerun minishift

/rerun minishift

/rerun minishift

This is closed now as #69 was merged.


Option to fail if schema does not exist

Which version and edition of Flyway are you using?
5.1.4
If this is not the latest version, can you reproduce the issue with the latest one as well?
(Many bugs are fixed in newer releases and upgrading will often resolve the issue)
Yes
Which client are you using? (Command-line, Java API, Maven plugin, Gradle plugin)
Java API
Which database are you using (type & version)?
Postgres 9.6
Which operating system are you using?
Linux
Request
Flyway will always try to create a schema as the current user on migrate. I want to separate the schema & permission control from the migrations of the data inside a schema. This allows for easy rotation of permissions and separation of concerns. There is currently a race condition around the running of flyway and the separate creation of the schema. I would like to:

Have my flyway step continuously fail because the schema does not yet exist
Create the schema and grant all permissions on that schema
Flyway can now run with the passed user.

@olib963 Any news?

@MikielAgutu Thank you, yes this solution seems to work. I don't think it's the most elegant but it absolutely works :D

@olib963 Yes, not particularity elegant I'm afraid 😅 However the new multi line config option feature can make it slightly less ugly: https://flywaydb.org/documentation/configfiles#structure.


UPM Foundation package import is missing a directory

Describe the bug
When importing the Foundation package via UPM, 3 Directory Not Found errors are generated for files in the following directory: \Library\PackageCache\com.microsoft.mixedreality.toolkit.foundation\SDK\Experimental\InteractiveElement\StateVisualizer\StateAnimatableProperties\AnimatableProperties\ShaderProperties\
To reproduce
Steps to reproduce the behavior:

Create a new Unity 2019 project
Import the Foundation Package
Look at the Unity Console

Screenshots

Additional context
The errors will not persist in the project, even after removing the Foundation package and re-importing it. When the Foundation package is re-imported, the folder from the error is still missing and the errors are not generated.

This looks like a path-too-long error

@CDiaz-MS Any ideas on if we can shorten

@keveleigh yes folders can be collapsed, I'll shorten the path.

fixed with #9323

I am still running into a very similar problem with the 2.6 release. I could fix the problem since the path to …\Library\PackageCache... was quite long for my project. However, there is this "@635490bc259e-1615042220629" added to the package name. These are 27 characters. Are they necessary?

I don't think we have any control over that string 😞 @davidkline-ms?

Most other packages just have only their version number at the end, like @2.6. Sometimes it is also the commit sha (if pulled via git)

Unity seems to append the long @ when a package is imported via tarball/tgz, which is the way the Feature Tool handles packages


Add /usr dir to isolate self-built binaries and libs?

Currrently if you self-build a lot of packages - it can be tough to look inside the bin/lib/share etc folder and realize which file is yours and/or remove them to restore w64devkit to stock - especially since it's not easy to undo a make install. It might be a good idea to follow FHS and put all usermade packages in /usr or /usr/local?

I agree. But how do we get GCC to search in these places?
I'm sure it's possible. I just don't know how.

A convention like /opt or /usr/local is necessary when the file system
root (e.g. /) is shared between system and operator. However, w64dk isn't
the file system root and does not need to share its subtree. Unlike MSYS2
or Cygwin, nor does it host a virtual file system rooted within itself. So
the solution is simply to not "install" files within w64dk unless you're
ready to repeat that process after updates.
Instead, create one or more "system roots" outside of w64dk, then set a
few environment variables to virtually merge it into the w64dk sysroot.
For example, if you use your home directory, then in your .profile:
PATH="$HOME/bin;$PATH"
export CPATH="$HOME/include"
export LIBRARY_PATH="$HOME/lib"
export PKG_CONFIG_PATH="$HOME/lib/pkgconfig;$HOME/share/pkgconfig"
For multiple sysroots, each variable supports ";" as a path separator. Now
you can update w64dk without disturbing self-built dependencies and tools.
When you ./configure or whatever, it's --prefix=$HOME to match the above.
The Windows environment block size is historically significantly limited,
and the documentation on those limits is wrong 1. So I'm wary of loading
it more than necessary by default. Paths must be absolute, and the w64dk
installation path can easily be quite long (e.g. deep inside someone's
profile directory). Adding itself to PATH once is necessary, but each new
search path is another full copy of a potentially long installation path
for significantly less benefit for most users.
There's probably a way to teach Binutils and GCC about more search paths
so that they don't need to go in the environment, but I'd prefer to not
encourage installing libraries inside w64dk as a general solution.
Side note: There's been a sticky issue that "$ARCH/bin" isn't added to
PATH, yet that's where DLLs and EXEs are installed. That means dynamically
linked libraries and tools installed within w64dk don't work out of the
box. Since w64dk isn't "multiarch" I should probably eliminate the $ARCH
component in the sysroot and lift everything up a level. I haven't figured
out how to do this yet, but I also haven't put much effort into it.

This is a snippet from my .profile file for SDL2, SFML and RayLib
libraries added. We only need to ensure that the folders where
the libraries are copied are in the correct $ARCH folders . I am
able to use the correct 32-bit or 64-bit libraries with this
setting with a single .profile in a single $HOME folder defined
in the w64devkit.ini file for 32 and 64 bit toolkits. Just in
case anyone should find it useful.
`
export ARCH="$(gcc -dumpmachine)"
export SDK="$HOME/SDK"
unset C_INCLUDE_PATH
unset CPLUS_INCLUDE_PATH
unset CPATH
unset LIBRARY_PATH
unset LD_LIBRARY_PATH
unset PKG_CONFIG_PATH
export CPATH="$CPATH;$SDK/SDL2/$ARCH/include"
export LIBRARY_PATH="$LIBRARY_PATH;$SDK/SDL2/$ARCH/lib"
export LD_LIBRARY_PATH="$LD_LIBRARY_PATH;$SDK/SDL2/$ARCH/bin"
export PKG_CONFIG_PATH="$PKG_CONFIG_PATH;$SDK/SDL2/$ARCH/lib/pkgconfig"
export SFML_VERSION="2.6.1"
export CPLUS_INCLUDE_PATH="$CPLUS_INCLUDE_PATH;$SDK/SFML-$SFML_VERSION/$ARCH/include"
export LIBRARY_PATH="$LIBRARY_PATH;$SDK/SFML-$SFML_VERSION/$ARCH/lib"
export LD_LIBRARY_PATH="$LD_LIBRARY_PATH;$SDK/SFML-$SFML_VERSION/$ARCH/bin"
export PKG_CONFIG_PATH="$PKG_CONFIG_PATH;$SDK/SFML-$SFML_VERSION/$ARCH/lib/pkgconfig"
export RAYLIB_VERSION="5.0"
export CPATH="$CPATH;$SDK/raylib-$RAYLIB_VERSION/$ARCH/include"
export LIBRARY_PATH="$LIBRARY_PATH;$SDK/raylib-$RAYLIB_VERSION/$ARCH/lib"
PATH="$PATH;$LD_LIBRARY_PATH"
`

Thanks for the example, @rapte! The "gcc -dumpmachine" trick is great and
I use it myself.
LD_LIBRARY_PATH should have no effect in w64devkit. The Windows dynamic
linker certainly doesn't use it, Bintuils only uses it for ELF targets,
and it generally doesn't fit into the Win32 linking model. Ultimately you
tack it onto the end of PATH, so it seems perhaps you're just using the
name as a convention. (Even then, it still doesn't need to be exported.)

Thank you @skeeto for this super portable toolchain.
It is true that I use the LD_LIBRARY_PATH just as a naming convention. But the reason
I export the paths to this variable and then update it to the path is because I do
not need to copy the .dll files of the library in my project when the I run the compiled
binary which are linked dynamically from the shell. I find it very convenient.


Add support for the sgrendezvous ECP command

Add support for the sgrendezvous ECP command (instead of using the port 8080 commands).
https://developer.roku.com/en-gb/docs/developer-program/debugging/external-control-api.md#general-ecp-commands

check the firmware version (from the device-info object added in #121) to make sure it's at least firmware 11.5. if lower, none of the rest of this logic can be applied.
The logic should be added into RendezvousTracker.

We will look at device settings to determine if rendezvouz tracking is enabled. If either of these resolve in true, then rendezvous tracking should be enabled:

If the 8080 logrendezvous status says it's enabled. https://developer.roku.com/en-gb/docs/developer-program/debugging/debugging-channels.md#scenegraph-debug-server-port-8080-commands (run logrendezvous over telnet port 8080, the response should be logrendezvous: rendezvous logging is on, so maybe just check that the string ends with "on").
query this url (http://<IP_ADDRESS>:8060/query/sgrendezvous) and check to see if <tracking-enabled>false</tracking-enabled> is set to true or false.

So then, if rendezvous tracking is enabled in either method (8080 or ECP), and firmware is 11.5 or higher, do the following:

Send an ECP "disable rendezvous tracking" command to reset any data left over from previous session
Send ECP "enable rendezvous tracking" command to enable tracking
send query/sgrendezvous ECP requests at regular intervals
emit the results through the RendezvousTracker's standard event emitter, in the same format.
disable emitting rendezvous tracking from the scraped telnet logs in RendezvousTracker (but still remove the items from the log output).

We still need to fall back to the old telnet scraping method, but if we are able to successfully use the ECP command, then the old method's results should be discarded.
To enable rendezvous tracking over ECP:

curl -d '' "http://<IP_ADDRESS>:8060/sgrendezvous/track"

To disable rendezvous tracking over ECP:

curl -d '' "http://<IP_ADDRESS>:8060/sgrendezvous/untrack"

To view rendezvous status over ECP:

curl "http://<IP_ADDRESS>:8060/query/sgrendezvous"

Done in PR #150


NullReferenceException opening settings while packages are loading

Steps to reproduce

Start ChocolateyGui
Click on the settings link in the title bar while ChocolateyGUI is still loading the packages installed on the local machine

Exception

Versions
Chocolatey: v0.10.3 Professional
ChocolateyGUI: v0.14.0-unstable0145

@pascalberger since the refactoring, I have not been able to get this to happen again.
For now, I am going to close this out.  Let me know if you can get this to happen again.


[HELP] Segmentation fault while attaching tab to gtk::Notebook

I'm creating browser-like app with multiple tabs which can be detached as separated windows.
I extracted small example here: https://github.com/ggodlewski/gtk4-notebook-app/blob/main/src/main.rs
The result is something like that:

After detaching I have 2 windows (if it doesn't randomly crash):

When I try to reattach Tab1 to first window I'm getting: Segmentation fault (core dumped)
Is there anything else than set_tab_detachable that I need to do or is it some bug in the library?
I'm running this on Ubuntu 24.04

For the future generations:
It's a problem with gtk.
I did a test using python https://github.com/ggodlewski/gtk4-notebook-app/blob/main/gtk3.py https://github.com/ggodlewski/gtk4-notebook-app/blob/main/gtk4.py and it also doesn't work while working perfectly fine under gtk3
Doing some debugging I located it:
Core was generated by `target/debug/app'.
Program terminated with signal SIGSEGV, Segmentation fault.
#0  gtk_notebook_dnd_finished_cb (drag=<optimized out>, widget=0x59b940d47cd0 [GtkNotebook]) at ../../../gtk/gtknotebook.c:3244
3244          g_signal_emit (notebook, notebook_signals[CREATE_WINDOW], 0,
[Current thread is 1 (Thread 0x756ddf9d7f40 (LWP 331473))]
(gdb) f 0
#0  gtk_notebook_dnd_finished_cb (drag=<optimized out>, widget=0x59b940d47cd0 [GtkNotebook]) at ../../../gtk/gtknotebook.c:3244
3244          g_signal_emit (notebook, notebook_signals[CREATE_WINDOW], 0,
(gdb) p notebook->detached_tab->child
Cannot access memory at address 0x18
(gdb) p notebook->detached_tab
$5 = 0x0

https://gitlab.gnome.org/GNOME/gtk/-/blob/main/gtk/gtknotebook.c?ref_type=heads#L3337
Instead of
      g_signal_emit (notebook, notebook_signals[CREATE_WINDOW], 0,
                     notebook->detached_tab->child, &dest_notebook);

There should be
if (notebook->detached_tab)
      g_signal_emit (notebook, notebook_signals[CREATE_WINDOW], 0,
                     notebook->detached_tab->child, &dest_notebook);

do_detach_tab is called prior setting  notebook->detached_tab to NULL. Since in this case tab is dropped on another notebook create-window event is not necessary.
However, I have other issues and I'm on the edge of switch to qt/anything else. GTK has it's own gitlab instance, I'm not creating yet another account to do this trivial PR.

You can create an account with your github account.
There's nothing we can do about this crash here, it's an issue in gtk. Closing for now but please feel free to create new issues or discussions about anything bindings / Rust-related here.


getting error while login

(tensorflowgpu) subhayu@subhayu-Lenovo-Z580:~$ floyd login
Error:
Your version of CLI (0.9.9) is no longer compatible with server. Run:
pip install -U floyd-cli
to upgrade to the latest version (0.10.1)
I have updated the cli also...
floyd-cli                 0.10.2

Can you paste the exact logs you see when you run floyd version?

exact logs were you should update the cli to 0.10.2 which i alread had.
Somehow it is working now.For past 12 hrs it was throwing same error
On Wed, Jul 19, 2017 at 8:12 PM, Sai Soundararaj<EMAIL_ADDRESS>wrote:

Can you paste the exact logs you see when you run floyd version?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/floydhub/floyd-cli/issues/64#issuecomment-316409704,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AMdo2lf6nElaqLJCWFTBOfzaoxaXnuLnks5sPhXXgaJpZM4Ocpwv
.

Not sure what the issue was, but glad it is resolved! :)

Guys I'm getting the same error using the latest release.
It used to happen about a week ago, then it magically worked, now it's happening again


Adding developer guide

Description
Adding developer guide for the repo, this should help onboard new contributors faster.
Issues Resolved
https://github.com/opensearch-project/neural-search/issues/439
Check List

[X] All tests pass
[X] Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ArnoldTingSu I know you were setting up the plugin recently, feel free to check and add what's missing


Error pip installing it daft_scraper?

Tried pip installing it and getting:
Step #1:   Downloading pandas-1.1.5-cp36-cp36m-manylinux1_x86_64.whl (9.5 MB)
Step #1: ?[91mERROR: Could not find a version that satisfies the requirement daft_scraper (from -r requirements.txt (line 10)) (from versions: none)
Step #1: ?[0m?[91mERROR: No matching distribution found for daft_scraper (from -r requirements.txt (line 10))

Nevermind, I just noticed it is only compatible with py3.7+


After the HikariPool was rebuilt, monitoring metrics were lost

The HikariCP connection pool is using Springboot refreshScope. RefreshAll (); After operation, the connection pool object HikariPool was rebuilt, and Prometheus monitoring index could not be collected.
Using listeners, if the configuration center configuration changes, re-register
bindMetricsRegistryToHikariDataSource(hikariDataSource); hikari.setMetricRegistry(this.registry);
You can't get the metrics
hikaricp_connections hikaricp_connections_active
Data for relevant indicators is missing

Hi, please refer to this

ggghhh


WIP: Simulation

Can one of the admins verify this patch?

The proposed implementation looks like a overkill to me. Let's discuss in person on the Mon architecture call.
As you said, you're basically reimplementing here existing mock libraries - I don't understand why such thing is needed. Just use mock or flexmock directly.

@TomasTomecek , I though about that  and flexmock seems little bit different and not so powerful.
unittest.mock library is more less very similar to my code, for this purpose with usage like mock.Mock(spec=github.Github) , but I had no experiences and never heard about that with that and code what I've wrote is not so complex and helped me  to understand what happens there also use these configuration yaml files to store predefined output.
But is it true that I could replace my generic Mock  class with this one and just extend it.  for my purpose, and avoid to create another mock class implementation, maybe not sure If I can do whatever I want. means output what class, module I'm mocking. I try to investigate it and maybe use it. Maybe I'll had to look on internal code of this, to see what I can do there. Or if you have experience I'll glad to hear about that and usages in these cases.

I was actually expecting a PR similar to this one on release-bot: https://github.com/user-cont/release-bot/pull/177
Just adding a new flag dry_run and not change anything when dry_run is on.

I was actually expecting a PR similar to this one on release-bot: user-cont/release-bot#177
Just adding a new flag dry_run and not change anything when dry_run is on.

@TomasTomecek yep, but this dry-run option is something little bit different, and dry run option will be implemented as part of packit not part of org, ogr just provide some mocking of env for another tools.

@TomasTomecek yep, but this dry-run option is something little bit different, and dry run option will be implemented as part of packit not part of org, ogr just provide some mocking of env for another tools.

Yes, the --dry-run would be part of packit, but we were speaking about "mock" implementation of the ogr API, that could be used from packit for this purpose.

Okay, I leave this one to @lachmanfrantisek and @jpopelka then. My assumption was that ogr classes would accept dry_run argument which would not let them write to remote services. If we choose path of mocking all the methods, then we'll have to maintain twice as much code which will be such a pain. We would also need to be sure that methods are in sync.

Okay, I leave this one to @lachmanfrantisek and @jpopelka then. My assumption was that ogr classes would accept dry_run argument which would not let them write to remote services. If we choose path of mocking all the methods, then we'll have to maintain twice as much code which will be such a pain. We would also need to be sure that methods are in sync.

It would be nice if we can mock/flexmock the abstract classes automatically. I hope that some solution already exists.

This PR could be closed,
used simplier solution https://github.com/packit-service/ogr/pull/48
and provided also read-only mode there


[flutter_tools] add test for dart binary arch

This test was accidentally deleted when I rebased https://github.com/flutter/flutter/pull/101308, which landed without tests. It leverages the _MacOSUtils.hostPlatform getter, which already implements calling sysctl hw.optional.arm64 and parses the output.

Merging on red "Google testing", which is failing due to https://github.com/flutter/flutter/issues/101611


Update AWS integration endpoints

Add a few missing AWS integration endpoints

A few nits on the docstrings. I realize it's the case for all the other accessors, but let's start to be accurate 🙂

this was generated by the command make generate so I will try to see if I can fix it directly there (if this is even possible), so that we don't have to do this again

Okay since this is all autogenerated, changing this is not for the scope of this PR IMO.
Let's leave it like this for now.

Okay since this is all autogenerated, changing this is not for the scope of this PR IMO.
Let's leave it like this for now.

Indeed, you're right. Thank you for the review


Get component list by type instead of matching the component name

Added func findComponentsByType()

Test passed:

http://sponge2/1e6c1475-0172-4885-81f4-79c1af9f4a72

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 70.423%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1050

Relevant Lines:
1491

💛  - Coveralls

nit on naming:  Can we replace the references to supervisor with controllercard?  This way the names we are using in the test code are using the same names as  openconfig.  For example:
TestStandbySupervisorReboot becomes: TestStandbyControllerCardReboot

nit on naming: Can we replace the references to supervisor with controllercard? This way the names we are using in the test code are using the same names as openconfig. For example:
TestStandbySupervisorReboot becomes: TestStandbyControllerCardReboot

Done

Test passed after the change:

http://sponge2/d673e6c5-9574-4856-ac8d-48512a196b1a

I will make changes in the next PR based on redundant-role. Does it work for Cisco?

That works! Thanks!

That works! Thanks!

I just made the changes based on redundant-role.


upgrading boto3 to botocore 1.16

Issue #, if available:
Description of changes:
moving to a newer version of boto3 to enable Kendra operations
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

it is the botocore version inside that is being upgraded to 1.16.  DUS had botocore 1.15 before,  which we suspect was causing Shivani some issues with index creation with Edition=DEVELOPER_EDITION


Add deep linking to the app using Branch

Adding deep links to the app so that it can be opened up directly from http://2017.fossasia.org/.
We can use branch for this.
@mariobehling Suggestions?

@the-dagger I have worked on this before in my previous app.. Shall I start working on it?

@rohanagarwal94 Go Ahead :+1:

@the-dagger The deep linking implementation opens up the app chooser dialog when user clicks on the link rather than when he types the link in the web browser. I think its futile to use branch just for android app redirect since that can be achieved just by including an intent filter for the splash activity. However, I dont think the above mentioned feature is possible from the app side - see this.  Thoughts???

@rohanagarwal94 I meant to implement something similar to what stackoverflow, slack and medium are doing.
If you open up the webpage on your mobile, they show a little snackbar type of thing on the top which says open in app and then opens the app is user has it installed or opens up the play store if he hasnt.
We might also need to do some changes on the web page too i believe, so let's brainstorm first on how can we do this.

@the-dagger yup, that I think is branch implementation using a custom link generated from there and hyper linking that link in mobile responsive website.

Is the issue closed? @rohanagarwal94

@rohanagarwal94 Status?

@mananwason
If this is open, can i work on this?

@the-dagger is the deep linking implemented? Needed the link for app invite through facebook. If you haven't, assign me the issue.

@the-dagger deep linking specifically http://2017.fossasia.org/ requires changes in the javascript code of the website. What branch.io does is, it provides custom links (eg. fossasia.app.ink) which on click implements deep linking. Hence setting up branch would make much more sense when setting up referral system. Should I make a separate issue to implement that?

@the-dagger this has been implemented.


Failed to fake [String]?

First of all, thank you for the wonderful tool.
In the latest version 2.0.0-rc.10, I tried faking a basic [String], such as:
My schema:
type Query {
  letters: [String] @examples(values: ["a", "b", "c"])
}

My query:
query {
  letters
}

graphql-faker respond to me this:
{
  "errors": [
    {
      "message": "String cannot represent value: [function]",
      "locations": [
        {
          "line": 2,
          "column": 3
        }
      ],
      "path": [
        "letters",
        0
      ]
    },
    {
      "message": "String cannot represent value: [function]",
      "locations": [
        {
          "line": 2,
          "column": 3
        }
      ],
      "path": [
        "letters",
        1
      ]
    }
  ],
  "data": {
    "letters": [
      null,
      null
    ]
  }
}

@qonn Thanks for reporting 👍
Fixed in 2.0.0-rc.11, can you please test?

Yep, it works now. thank you for the fast fix ❤


Update broadlink.py, fix a problem using MP1

After controll MP1's slot switch, it will update slot's state twice: One in broadlink.py calls schedule_update_ha_state() manually after send turn_on or turn_off command to MP1 , another calls switch.async_update_ha_state(True) by switch service sending request to MP1 and get real status. The problem is these two operation execute with short interval, the latter operation usually get a old state since MP1 takes time to refresh it's state. So I add some timer to ensure getting a real state,  giving MP1 3 second to reresh states and ignoring update request during that time.
Description:
Related issue (if applicable): fixes #
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>
Example entry for configuration.yaml (if applicable):

Checklist:

[x] The code change is tested and works locally.
[ ] Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated in home-assistant.github.io

If the code communicates with devices, web services, or third-party tools:

[ ] New dependencies have been added to the REQUIREMENTS variable (example).
[ ] New dependencies are only imported inside functions that use them (example).
[ ] New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
[ ] New files were added to .coveragerc.

If the code does not interact with devices:

[ ] Tests have been added to verify that the new code works.

Hi @cnk700i,
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!


PDF generation converts relative links to absolute

When a page contains a relative link to a file, the resultant link seems to be converted to an absolute (e.g. file://-prepended) link in the final PDF output, even if the link inside the HTML itself is relative.
For example:
// "page.html" contains "<a href="./some-other-file.pdf">"
using var playwright = await Playwright.CreateAsync();
await using var browser = await playwright.Chromium.LaunchAsync(
    new BrowserTypeLaunchOptions
    {
        Headless = true,
        Channel = "chrome"
    });
await using var context = await browser.NewContextAsync();
var page = await context.NewPageAsync();
await page.GoToAsync("/path/to/page.html", new PageGotoOptions { WaitUntil = WaitUntilState.NetworkIdle });
await page.PdfAsync(
    new PagePdfOptions
    {
        Path = "/path/to/page.pdf"
    });
// page.pdf has absolute link to file://path/to/some-other-file.pdf, meaning the resultant PDF isn't portable

wkhtmltopdf solves this with a command-line switch called --keep-relative-links.


Just saying thanks

After trying / researching a multitude of similar solutions and wikis, I have settled for BookStack. It performs and it looks very good in production.
I have to say it's one of the best solutions as of now, considering ease of install + ease of customization + ease of administration/backup + end-user interaction as well.
The "near-desktop feel" editing experience plus the ability to attach files to pages - is all is needed for a good documentation website. I, personally can generate a static website in Hugo or Pelican, but BookStack makes it easier for average Jo end user, to actually use the software as well.
Thanks Dan and Abijeet + contributors, good stuff!

You can close this, not an issue, obviously.

agreed great stuff guys

Thank you so much for your positive feedback, It's great to hear!

I recently came back to using BookStack after rebuilding my server at least a year ago. I restored the database and it updated easily to the latest version. I signed in and was amazed by how much it has grown in that time.

 Thanks everyone :heart:


Killed...please help me

ffuf -w /root/wordlists/wordlist.txt -u "https://FUZZ.abc.com" -mc 200,302,403 -of csv -timeout 60
:: Progress: [713934/9544235] :: Job [1/1] :: 1669 req/sec :: Duration: [1:38:12] :: Errors: 713816 ::zsh: killed     ffuf -w /root/wordlists/wordlist.txt -u "https://FUZZ.abc.com" -mc

My guess would be that this is a kernel OOM killer; your wordlist itself with almost 10 million entries is a huge memory hog, and when you add the results to memory (guessing they are all 200's) you are simply running out of memory, and your kernel is doing the best thing it can think of - killing the process.


Decode base64-encoded Text Attachments

Since Cucumber 10, all Text Attachments are as well Base64 encoded, which currently makes them unreadable in the HTML-Reports.
This fix was created by @lerhum and @WasiqB.
As my customer needs this piece of code, I fixed the findings as described.
All Credits go the the creators, I just want to help speeden up things :)
Original Text
linked to https://github.com/WasiqB/multiple-cucumber-html-reporter/issues/298
Describe the bug
In the JSON formatter output of multiple-cucumber-html-reporter, all attachments, including those initially attached as plain text strings, are now Base64 encoded. This uniform encoding approach leads to ambiguity for consumers of the report, as they cannot distinguish whether an attachment was originally a plain text string or a different file format.
To Reproduce
Steps to reproduce the behavior:
just generate a report based on cucumber 10.0.1 with some attachement (json/ text / image)
Expected behavior
The expected behavior was that string attachments would remain as plain text in the JSON formatter output, while other types of attachments would be Base64 encoded. This distinction would enable consumers to easily identify the nature of the attachments without additional processing.
Additional context
To resolve this issue, a decoding mechanism such as atob(embedding.data); should be implemented to correctly decode Base64 attachments before passing them to the report. This would ensure that plain text attachments maintain their original format in the JSON output.

Hi @mschluer ,
Thanks for opening the PR.
Kindly look into the test failure, once that's fixed, we are good to merge.

It should work now, yet I would recommend to adjust the test data sooner or later

@mschluer hi, with the latest update I see the issue when there is an embeddings with "text/plain" mime type, in the cucumber html report there is base64 mess.

Is there a way to fix that e.g. through configuration

Hey,
which Cucumber-Version are you using?
With Cucumber 10 they decided to base64 encode text as well - unlike what they themselves state in their specification. Frankly, I did not yet fully understand their decision.
Upgrading to the most recent version should solve your Problem.
Reference: "Ensure attached string literals are base64-encoded in JSON reports" (https://github.com/cucumber/cucumber-js/issues/2260)" https://github.com/cucumber/cucumber-js/releases/tag/v10.0.0

@mschluer I use latest "wdio-cucumberjs-json-reporter" seems like this lib has no support of the change. So i need to convert any attach to base64 I assume and wait for the lib to support this.
I've tested this and seems everything works fine now
await cucumberJson.attach(Buffer.from('Scenario Start Time: ' + new Date().toISOString()).toString("base64"), 'text/plain');
Thanks.

@WasiqB Sorry to be annoying. Seems like there is an issue when attaching "application/json" data type.
So now in my framework I encode everything into base64. JSON as well. But in the html cucumber report there is buffer array instead of JSON

I notice that this statement is never be true so the JSON will not be parsed and that's why the result is not JSON:

If to revert this statement or remove, then the JSON is properly parsed:

Am i doing something wrong or there is an issue and the statement must be removed\reverted

@WasiqB Hello. Any suggestion on the topic above? Appreciate it.