[Issue]: Unable to Update Beyond v<IP_ADDRESS>

Problem Description
I have 3 nodes, all the same hardware spec. Running kubernetes on Talos, deployed amd-device-plugin using helm chart and demonset. On tag v<IP_ADDRESS> everything works, each node has access to the iGPU and can be assigned to a pod.
kubectl -n kube-system get pods -o wide
NAME                                             READY   STATUS    RESTARTS       AGE   IP            NODE              NOMINATED NODE   READINESS GATES
amd-device-plugin-b5gsh                          1/1     Running   0              15h   <IP_ADDRESS>   black-knight-02   <none>           <none>
amd-device-plugin-d5rrd                          1/1     Running   0              15h   <IP_ADDRESS>   black-knight-03   <none>           <none>
amd-device-plugin-sf25x                          1/1     Running   0              15h   <IP_ADDRESS>    black-knight-01   <none>           <none>
amd-gpu-node-labeller-g8ntt                      1/1     Running   0              8h    <IP_ADDRESS>    black-knight-01   <none>           <none>
amd-gpu-node-labeller-xqvf8                      1/1     Running   0              8h    <IP_ADDRESS>   black-knight-03   <none>           <none>
amd-gpu-node-labeller-zz7wk                      1/1     Running   0              8h    <IP_ADDRESS>   black-knight-02   <none>           <none>

When i attempt to upgrade to any tag greater than <IP_ADDRESS>. amd-device-plugin fails to deploy on node 3. From what I can tell the image is detecting the wrong system architect?
kubectl -n kube-system get pods -o wide
NAME                                             READY   STATUS             RESTARTS        AGE     IP            NODE              NOMINATED NODE   READINESS GATES
amd-device-plugin-6h7tt                          0/1     CrashLoopBackOff   2 (15s ago)     29s     <IP_ADDRESS>   black-knight-03   <none>           <none>
amd-device-plugin-l956d                          1/1     Running            0               29s     <IP_ADDRESS>   black-knight-02   <none>           <none>
amd-device-plugin-nqv5f                          1/1     Running            0               29s     <IP_ADDRESS>   black-knight-01   <none>           <none>
amd-gpu-node-labeller-h2l6w                      1/1     Running            0               29s     <IP_ADDRESS>    black-knight-03   <none>           <none>
amd-gpu-node-labeller-kzw9q                      1/1     Running            0               29s     <IP_ADDRESS>   black-knight-02   <none>           <none>
amd-gpu-node-labeller-sdhg5                      1/1     Running            0               29s     <IP_ADDRESS>     black-knight-01   <none>           <none>

kubectl describe pod amd-device-plugin-6h7tt -n kube-system
Name:                 amd-device-plugin-6h7tt
Namespace:            kube-system
Priority:<PHONE_NUMBER>
Priority Class Name:  system-node-critical
Service Account:      default
Node:                 black-knight-03/<IP_ADDRESS>
Start Time:           Tue, 08 Oct 2024 09:19:09 +0000
Labels:               app.kubernetes.io/component=amd-device-plugin
                      app.kubernetes.io/instance=amd-device-plugin
                      app.kubernetes.io/name=amd-device-plugin
                      controller-revision-hash=599d6ffccd
                      pod-template-generation=34
Annotations:          <none>
Status:               Running
IP:                   <IP_ADDRESS>
IPs:
  IP:           <IP_ADDRESS>
Controlled By:  DaemonSet/amd-device-plugin
Containers:
  app:
    Container ID:  containerd://aa040e5b78f93ad1bb16b2d032348941f0f10de1a71c347b66cc313a74be9e1a
    Image:         docker.io/rocm/k8s-device-plugin:<IP_ADDRESS>
    Image ID:      docker.io/rocm/k8s-device-plugin@sha256:f3835498cf2274e0a07c32b38c166c05a876f8eb776d756cc06805e599a3ba5f
    Port:          <none>
    Host Port:     <none>
    Command:
      ./k8s-device-plugin
    Args:
      -logtostderr=true
      -stderrthreshold=INFO
      -v=5
    State:          Waiting
      Reason:       CrashLoopBackOff
    Last State:     Terminated
      Reason:       Error
      Exit Code:    255
      Started:      Tue, 08 Oct 2024 09:19:51 +0000
      Finished:     Tue, 08 Oct 2024 09:19:51 +0000
    Ready:          False
    Restart Count:  3
    Limits:
      memory:  100Mi
    Requests:
      cpu:     10m
      memory:  10Mi
    Environment:
      TZ:  Pacific/Auckland
    Mounts:
      /sys from sys (rw)
      /var/lib/kubelet/device-plugins from device-plugins (rw)
      /var/run/secrets/kubernetes.io/serviceaccount from kube-api-access-xrdfd (ro)
Conditions:
  Type                        Status
  PodReadyToStartContainers   True
  Initialized                 True
  Ready                       False
  ContainersReady             False
  PodScheduled                True
Volumes:
  device-plugins:
    Type:          HostPath (bare host directory volume)
    Path:          /var/lib/kubelet/device-plugins
    HostPathType:
  sys:
    Type:          HostPath (bare host directory volume)
    Path:          /sys
    HostPathType:
  kube-api-access-xrdfd:
    Type:                    Projected (a volume that contains injected data from multiple sources)
    TokenExpirationSeconds:  3607
    ConfigMapName:           kube-root-ca.crt
    ConfigMapOptional:       <nil>
    DownwardAPI:             true
QoS Class:                   Burstable
Node-Selectors:              feature.node.kubernetes.io/pci-0300_1002.present=true
                             kubernetes.io/arch=amd64
Tolerations:                 CriticalAddonsOnly op=Exists
                             node.kubernetes.io/disk-pressure:NoSchedule op=Exists
                             node.kubernetes.io/memory-pressure:NoSchedule op=Exists
                             node.kubernetes.io/not-ready:NoExecute op=Exists
                             node.kubernetes.io/pid-pressure:NoSchedule op=Exists
                             node.kubernetes.io/unreachable:NoExecute op=Exists
                             node.kubernetes.io/unschedulable:NoSchedule op=Exists
Events:
  Type     Reason     Age                From               Message
  ----     ------     ----               ----               -------
  Normal   Scheduled  60s                default-scheduler  Successfully assigned kube-system/amd-device-plugin-6h7tt to black-knight-03
  Normal   Pulled     19s (x4 over 60s)  kubelet            Container image "docker.io/rocm/k8s-device-plugin:<IP_ADDRESS>" already present on machine
  Normal   Created    19s (x4 over 60s)  kubelet            Created container app
  Normal   Started    19s (x4 over 60s)  kubelet            Started container app
  Warning  BackOff    7s (x5 over 58s)   kubelet            Back-off restarting failed container app in pod amd-device-plugin-6h7tt_kube-system(1d6ae128-c781-41ab-b106-e659b1464cfa)

kubectl -n kube-system logs amd-device-plugin-6h7tt -f
exec ./k8s-device-plugin: exec format error

kubectl describe daemonset amd-device-plugin -n kube-system

Name:           amd-device-plugin
Selector:       app.kubernetes.io/component=amd-device-plugin,app.kubernetes.io/instance=amd-device-plugin,app.kubernetes.io/name=amd-device-plugin
Node-Selector:  feature.node.kubernetes.io/pci-0300_1002.present=true,kubernetes.io/arch=amd64
Labels:         app.kubernetes.io/component=amd-device-plugin
                app.kubernetes.io/instance=amd-device-plugin
                app.kubernetes.io/managed-by=Helm
                app.kubernetes.io/name=amd-device-plugin
                helm.sh/chart=app-template-3.5.0
                helm.toolkit.fluxcd.io/name=amd-device-plugin
                helm.toolkit.fluxcd.io/namespace=kube-system
Annotations:    deprecated.daemonset.template.generation: 34
                meta.helm.sh/release-name: amd-device-plugin
                meta.helm.sh/release-namespace: kube-system
Desired Number of Nodes Scheduled: 3
Current Number of Nodes Scheduled: 3
Number of Nodes Scheduled with Up-to-date Pods: 3
Number of Nodes Scheduled with Available Pods: 2
Number of Nodes Misscheduled: 0
Pods Status:  3 Running / 0 Waiting / 0 Succeeded / 0 Failed
Pod Template:
  Labels:           app.kubernetes.io/component=amd-device-plugin
                    app.kubernetes.io/instance=amd-device-plugin
                    app.kubernetes.io/name=amd-device-plugin
  Service Account:  default
  Containers:
   app:
    Image:      docker.io/rocm/k8s-device-plugin:<IP_ADDRESS>
    Port:       <none>
    Host Port:  <none>
    Command:
      ./k8s-device-plugin
    Args:
      -logtostderr=true
      -stderrthreshold=INFO
      -v=5
    Limits:
      memory:  100Mi
    Requests:
      cpu:     10m
      memory:  10Mi
    Environment:
      TZ:  Pacific/Auckland
    Mounts:
      /sys from sys (rw)
      /var/lib/kubelet/device-plugins from device-plugins (rw)
  Volumes:
   device-plugins:
    Type:          HostPath (bare host directory volume)
    Path:          /var/lib/kubelet/device-plugins
    HostPathType:
   sys:
    Type:               HostPath (bare host directory volume)
    Path:               /sys
    HostPathType:
  Priority Class Name:  system-node-critical
  Node-Selectors:       feature.node.kubernetes.io/pci-0300_1002.present=true
                        kubernetes.io/arch=amd64
  Tolerations:          CriticalAddonsOnly op=Exists
Events:
  Type    Reason            Age                 From                  Message
  ----    ------            ----                ----                  -------
  Normal  SuccessfulDelete  59m                 daemonset-controller  Deleted pod: amd-device-plugin-qv4kv
  Normal  SuccessfulDelete  59m                 daemonset-controller  Deleted pod: amd-device-plugin-2m5bz
  Normal  SuccessfulCreate  59m                 daemonset-controller  Created pod: amd-device-plugin-c8cn4
  Normal  SuccessfulCreate  59m                 daemonset-controller  Created pod: amd-device-plugin-nkg7f
  Normal  SuccessfulCreate  54m                 daemonset-controller  Created pod: amd-device-plugin-2kldd
  Normal  SuccessfulCreate  54m                 daemonset-controller  Created pod: amd-device-plugin-lgfdf
  Normal  SuccessfulDelete  54m                 daemonset-controller  Deleted pod: amd-device-plugin-nkg7f
  Normal  SuccessfulDelete  54m                 daemonset-controller  Deleted pod: amd-device-plugin-c8cn4
  Normal  SuccessfulDelete  53m                 daemonset-controller  Deleted pod: amd-device-plugin-rv4l8
  Normal  SuccessfulDelete  53m                 daemonset-controller  Deleted pod: amd-device-plugin-2kldd
  Normal  SuccessfulCreate  53m                 daemonset-controller  Created pod: amd-device-plugin-xbtbm
  Normal  SuccessfulCreate  53m                 daemonset-controller  Created pod: amd-device-plugin-4mgq8
  Normal  SuccessfulDelete  48m                 daemonset-controller  Deleted pod: amd-device-plugin-xbtbm
  Normal  SuccessfulDelete  48m                 daemonset-controller  Deleted pod: amd-device-plugin-4mgq8
  Normal  SuccessfulCreate  48m                 daemonset-controller  Created pod: amd-device-plugin-w2xnm
  Normal  SuccessfulCreate  48m                 daemonset-controller  Created pod: amd-device-plugin-tc486
  Normal  SuccessfulDelete  48m                 daemonset-controller  Deleted pod: amd-device-plugin-lgfdf
  Normal  SuccessfulCreate  48m                 daemonset-controller  Created pod: amd-device-plugin-n8bkz
  Normal  SuccessfulCreate  43m (x21 over 28d)  daemonset-controller  (combined from similar events): Created pod: amd-device-plugin-79rbf
  Normal  SuccessfulDelete  10m (x38 over 28d)  daemonset-controller  (combined from similar events): Deleted pod: amd-device-plugin-z6n7b

talosctl dmesg -n black-knight-02 | grep -i amdgpu
black-knight-02: user: warning: [2024-10-08T04:00:29.037121313Z]: [talos] [initramfs] enabling system extension amdgpu-firmware 20240513
black-knight-02: kern:    info: [2024-10-08T04:00:34.208534313Z]: [drm] amdgpu kernel modesetting enabled.
black-knight-02: kern:    info: [2024-10-08T04:00:34.216765313Z]: amdgpu: Virtual CRAT table created for CPU
black-knight-02: kern:    info: [2024-10-08T04:00:34.217421313Z]: amdgpu: Topology: Add CPU node
black-knight-02: kern:    info: [2024-10-08T04:00:34.218049313Z]: amdgpu 0000:e5:00.0: enabling device (0006 -> 0007)
black-knight-02: kern:    info: [2024-10-08T04:00:34.229941313Z]: amdgpu 0000:e5:00.0: amdgpu: Fetched VBIOS from VFCT
black-knight-02: kern:    info: [2024-10-08T04:00:34.230669313Z]: amdgpu: ATOM BIOS: 113-REMBRANDT-X37
black-knight-02: kern:    info: [2024-10-08T04:00:34.233905313Z]: amdgpu 0000:e5:00.0: vgaarb: deactivate vga console
black-knight-02: kern:    info: [2024-10-08T04:00:34.234649313Z]: amdgpu 0000:e5:00.0: amdgpu: Trusted Memory Zone (TMZ) feature disabled as experimental (default)
black-knight-02: kern:    info: [2024-10-08T04:00:34.236985313Z]: amdgpu 0000:e5:00.0: amdgpu: VRAM: 512M 0x000000F400000000 - 0x000000F41FFFFFFF (512M used)
black-knight-02: kern:    info: [2024-10-08T04:00:34.238133313Z]: amdgpu 0000:e5:00.0: amdgpu: GART: 1024M 0x0000000000000000 - 0x000000003FFFFFFF
black-knight-02: kern:    info: [2024-10-08T04:00:34.239159313Z]: amdgpu 0000:e5:00.0: amdgpu: AGP: 267419648M 0x000000F800000000 - 0x0000FFFFFFFFFFFF
black-knight-02: kern:    info: [2024-10-08T04:00:34.241456313Z]: [drm] amdgpu: 512M of VRAM memory ready
black-knight-02: kern:    info: [2024-10-08T04:00:34.242076313Z]: [drm] amdgpu: 31762M of GTT memory ready.
black-knight-02: kern:    info: [2024-10-08T04:00:34.247748313Z]: amdgpu 0000:e5:00.0: amdgpu: Will use PSP to load VCN firmware
black-knight-02: kern:    info: [2024-10-08T04:00:34.425503313Z]: amdgpu 0000:e5:00.0: amdgpu: RAS: optional ras ta ucode is not available
black-knight-02: kern:    info: [2024-10-08T04:00:34.437710313Z]: amdgpu 0000:e5:00.0: amdgpu: RAP: optional rap ta ucode is not available
black-knight-02: kern:    info: [2024-10-08T04:00:34.438651313Z]: amdgpu 0000:e5:00.0: amdgpu: SECUREDISPLAY: securedisplay ta ucode is not available
black-knight-02: kern:    info: [2024-10-08T04:00:34.442337313Z]: amdgpu 0000:e5:00.0: amdgpu: SMU is initialized successfully!
black-knight-02: kern:    info: [2024-10-08T04:00:34.459122313Z]: kfd kfd: amdgpu: Allocated 3969056 bytes on gart
black-knight-02: kern:    info: [2024-10-08T04:00:34.459818313Z]: kfd kfd: amdgpu: Total number of KFD nodes to be created: 1
black-knight-02: kern:    info: [2024-10-08T04:00:34.461457313Z]: amdgpu: Virtual CRAT table created for GPU
black-knight-02: kern:    info: [2024-10-08T04:00:34.462616313Z]: amdgpu: Topology: Add dGPU node [0x1681:0x1002]
black-knight-02: kern:    info: [2024-10-08T04:00:34.463288313Z]: kfd kfd: amdgpu: added device 1002:1681
black-knight-02: kern:    info: [2024-10-08T04:00:34.463891313Z]: amdgpu 0000:e5:00.0: amdgpu: SE 1, SH per SE 2, CU per SH 6, active_cu_number 12
black-knight-02: kern:    info: [2024-10-08T04:00:34.465051313Z]: amdgpu 0000:e5:00.0: amdgpu: ring gfx_0.0.0 uses VM inv eng 0 on hub 0
black-knight-02: kern:    info: [2024-10-08T04:00:34.465961313Z]: amdgpu 0000:e5:00.0: amdgpu: ring comp_1.0.0 uses VM inv eng 1 on hub 0
black-knight-02: kern:    info: [2024-10-08T04:00:34.466875313Z]: amdgpu 0000:e5:00.0: amdgpu: ring comp_1.1.0 uses VM inv eng 4 on hub 0
black-knight-02: kern:    info: [2024-10-08T04:00:34.467788313Z]: amdgpu 0000:e5:00.0: amdgpu: ring comp_1.2.0 uses VM inv eng 5 on hub 0
black-knight-02: kern:    info: [2024-10-08T04:00:34.468704313Z]: amdgpu 0000:e5:00.0: amdgpu: ring comp_1.3.0 uses VM inv eng 6 on hub 0
black-knight-02: kern:    info: [2024-10-08T04:00:34.469631313Z]: amdgpu 0000:e5:00.0: amdgpu: ring comp_1.0.1 uses VM inv eng 7 on hub 0
black-knight-02: kern:    info: [2024-10-08T04:00:34.470554313Z]: amdgpu 0000:e5:00.0: amdgpu: ring comp_1.1.1 uses VM inv eng 8 on hub 0
black-knight-02: kern:    info: [2024-10-08T04:00:34.471475313Z]: amdgpu 0000:e5:00.0: amdgpu: ring comp_1.2.1 uses VM inv eng 9 on hub 0
black-knight-02: kern:    info: [2024-10-08T04:00:34.472396313Z]: amdgpu 0000:e5:00.0: amdgpu: ring comp_1.3.1 uses VM inv eng 10 on hub 0
black-knight-02: kern:    info: [2024-10-08T04:00:34.473332313Z]: amdgpu 0000:e5:00.0: amdgpu: ring kiq_<IP_ADDRESS> uses VM inv eng 11 on hub 0
black-knight-02: kern:    info: [2024-10-08T04:00:34.474289313Z]: amdgpu 0000:e5:00.0: amdgpu: ring sdma0 uses VM inv eng 12 on hub 0
black-knight-02: kern:    info: [2024-10-08T04:00:34.475190313Z]: amdgpu 0000:e5:00.0: amdgpu: ring vcn_dec_0 uses VM inv eng 0 on hub 8
black-knight-02: kern:    info: [2024-10-08T04:00:34.476126313Z]: amdgpu 0000:e5:00.0: amdgpu: ring vcn_enc_0.0 uses VM inv eng 1 on hub 8
black-knight-02: kern:    info: [2024-10-08T04:00:34.477095313Z]: amdgpu 0000:e5:00.0: amdgpu: ring vcn_enc_0.1 uses VM inv eng 4 on hub 8
black-knight-02: kern:    info: [2024-10-08T04:00:34.478061313Z]: amdgpu 0000:e5:00.0: amdgpu: ring jpeg_dec uses VM inv eng 5 on hub 8
black-knight-02: kern:    info: [2024-10-08T04:00:34.480279313Z]: [drm] Initialized amdgpu 3.54.0 20150101 for 0000:e5:00.0 on minor 0
black-knight-02: kern:    info: [2024-10-08T04:00:34.488976313Z]: amdgpu 0000:e5:00.0: [drm] Cannot find any crtc or sizes

✦ ⬢ [Docker] ❯ talosctl dmesg -n black-knight-03 | grep -i amdgpu

Operating System
Talos v1.8.0
CPU
AMD 6850U CPU with Radeon Graphics
GPU
AMD Radeon VII
ROCm Version
ROCm 6.2.0
ROCm Component
No response
Steps to Reproduce
Upgrade docker.io/rocm/k8s-device-plugin ( <IP_ADDRESS> → <IP_ADDRESS>).
(Optional for Linux users) Output of /opt/rocm/bin/rocminfo --support
ROCk module is loaded
=====================
HSA System Attributes
=====================
Runtime Version:         1.14
Runtime Ext Version:     1.6
System Timestamp Freq.:  1000.000000MHz
Sig. Max Wait Duration:<PHONE_NUMBER>3709551615 (0xFFFFFFFFFFFFFFFF) (timestamp count)
Machine Model:           LARGE
System Endianness:       LITTLE
Mwaitx:                  DISABLED
DMAbuf Support:          YES

==========
HSA Agents
==========
*******
Agent 1
*******
  Name:                    AMD Ryzen 7 PRO 6850U with Radeon Graphics
  Uuid:                    CPU-XX
  Marketing Name:          AMD Ryzen 7 PRO 6850U with Radeon Graphics
  Vendor Name:             CPU
  Feature:                 None specified
  Profile:                 FULL_PROFILE
  Float Round Mode:        NEAR
  Max Queue Number:        0(0x0)
  Queue Min Size:          0(0x0)
  Queue Max Size:          0(0x0)
  Queue Type:              MULTI
  Node:                    0
  Device Type:             CPU
  Cache Info:
    L1:                      32768(0x8000) KB
  Chip ID:                 0(0x0)
  ASIC Revision:           0(0x0)
  Cacheline Size:          64(0x40)
  Max Clock Freq. (MHz):   4768
  BDFID:                   0
  Internal Node ID:        0
  Compute Unit:            16
  SIMDs per CU:            0
  Shader Engines:          0
  Shader Arrs. per Eng.:   0
  WatchPts on Addr. Ranges:1
  Memory Properties:
  Features:                None
  Pool Info:
    Pool 1
      Segment:                 GLOBAL; FLAGS: FINE GRAINED
      Size:                    65047108(0x3e08a44) KB
      Allocatable:             TRUE
      Alloc Granule:           4KB
      Alloc Recommended Granule:4KB
      Alloc Alignment:         4KB
      Accessible by all:       TRUE
    Pool 2
      Segment:                 GLOBAL; FLAGS: KERNARG, FINE GRAINED
      Size:                    65047108(0x3e08a44) KB
      Allocatable:             TRUE
      Alloc Granule:           4KB
      Alloc Recommended Granule:4KB
      Alloc Alignment:         4KB
      Accessible by all:       TRUE
    Pool 3
      Segment:                 GLOBAL; FLAGS: COARSE GRAINED
      Size:                    65047108(0x3e08a44) KB
      Allocatable:             TRUE
      Alloc Granule:           4KB
      Alloc Recommended Granule:4KB
      Alloc Alignment:         4KB
      Accessible by all:       TRUE
  ISA Info:
*******
Agent 2
*******
  Name:                    gfx1035
  Uuid:                    GPU-XX
  Marketing Name:          AMD Radeon Graphics
  Vendor Name:             AMD
  Feature:                 KERNEL_DISPATCH
  Profile:                 BASE_PROFILE
  Float Round Mode:        NEAR
  Max Queue Number:        128(0x80)
  Queue Min Size:          64(0x40)
  Queue Max Size:          131072(0x20000)
  Queue Type:              MULTI
  Node:                    1
  Device Type:             GPU
  Cache Info:
    L1:                      16(0x10) KB
    L2:                      2048(0x800) KB
  Chip ID:                 5761(0x1681)
  ASIC Revision:           2(0x2)
  Cacheline Size:          64(0x40)
  Max Clock Freq. (MHz):   2200
  BDFID:                   58624
  Internal Node ID:        1
  Compute Unit:            12
  SIMDs per CU:            2
  Shader Engines:          1
  Shader Arrs. per Eng.:   2
  WatchPts on Addr. Ranges:4
  Coherent Host Access:    FALSE
  Memory Properties:       APU
  Features:                KERNEL_DISPATCH
  Fast F16 Operation:      TRUE
  Wavefront Size:          32(0x20)
  Workgroup Max Size:      1024(0x400)
  Workgroup Max Size per Dimension:
    x                        1024(0x400)
    y                        1024(0x400)
    z                        1024(0x400)
  Max Waves Per CU:        32(0x20)
  Max Work-item Per CU:    1024(0x400)
  Grid Max Size:<PHONE_NUMBER>(0xffffffff)
  Grid Max Size per Dimension:
    x<PHONE_NUMBER>(0xffffffff)
    y<PHONE_NUMBER>(0xffffffff)
    z<PHONE_NUMBER>(0xffffffff)
  Max fbarriers/Workgrp:   32
  Packet Processor uCode:: 118
  SDMA engine uCode::      47
  IOMMU Support::          None
  Pool Info:
    Pool 1
      Segment:                 GLOBAL; FLAGS: COARSE GRAINED
      Size:                    524288(0x80000) KB
      Allocatable:             TRUE
      Alloc Granule:           4KB
      Alloc Recommended Granule:2048KB
      Alloc Alignment:         4KB
      Accessible by all:       FALSE
    Pool 2
      Segment:                 GLOBAL; FLAGS: EXTENDED FINE GRAINED
      Size:                    524288(0x80000) KB
      Allocatable:             TRUE
      Alloc Granule:           4KB
      Alloc Recommended Granule:2048KB
      Alloc Alignment:         4KB
      Accessible by all:       FALSE
    Pool 3
      Segment:                 GROUP
      Size:                    64(0x40) KB
      Allocatable:             FALSE
      Alloc Granule:           0KB
      Alloc Recommended Granule:0KB
      Alloc Alignment:         0KB
      Accessible by all:       FALSE
  ISA Info:
    ISA 1
      Name:                    amdgcn-amd-amdhsa--gfx1035
      Machine Models:          HSA_MACHINE_MODEL_LARGE
      Profiles:                HSA_PROFILE_BASE
      Default Rounding Mode:   NEAR
      Default Rounding Mode:   NEAR
      Fast f16:                TRUE
      Workgroup Max Size:      1024(0x400)
      Workgroup Max Size per Dimension:
        x                        1024(0x400)
        y                        1024(0x400)
        z                        1024(0x400)
      Grid Max Size:<PHONE_NUMBER>(0xffffffff)
      Grid Max Size per Dimension:
        x<PHONE_NUMBER>(0xffffffff)
        y<PHONE_NUMBER>(0xffffffff)
        z<PHONE_NUMBER>(0xffffffff)
      FBarrier Max Size:       32
*** Done ***

Additional Information
kubectl get nodes -o wide
NAME              STATUS   ROLES           AGE   VERSION   INTERNAL-IP   EXTERNAL-IP   OS-IMAGE         KERNEL-VERSION   CONTAINER-RUNTIME
black-knight-01   Ready    control-plane   53d   v1.30.5   <IP_ADDRESS>    <none>        Talos (v1.8.0)   6.6.52-talos     containerd://2.0.0-rc.4
black-knight-02   Ready    control-plane   53d   v1.30.5   <IP_ADDRESS>    <none>        Talos (v1.8.0)   6.6.52-talos     containerd://2.0.0-rc.4
black-knight-03   Ready    control-plane   53d   v1.30.5   <IP_ADDRESS>    <none>        Talos (v1.8.0)   6.6.52-talos     containerd://2.0.0-rc.4

kubectl version
Client Version: v1.31.1
Kustomize Version: v5.4.2
Server Version: v1.30.5
Kubecolor Version: 0.4.0

kubectl get no -o json | jq ".items[].metadata.labels"
{
  "beta.amd.com/gpu.cu-count.12": "1",
  "beta.amd.com/gpu.device-id.1681": "1",
  "beta.amd.com/gpu.simd-count.24": "1",
  "beta.amd.com/gpu.vram.1G": "1",
  "beta.kubernetes.io/arch": "amd64",
  "beta.kubernetes.io/os": "linux",
  "extensions.talos.dev/amd-ucode": "20240909",
  "extensions.talos.dev/amdgpu-firmware": "20240909",
  "extensions.talos.dev/modules.dep": "6.6.52-talos",
  "extensions.talos.dev/realtek-firmware": "20240909",
  "extensions.talos.dev/thunderbolt": "v1.8.0",
  "feature.node.kubernetes.io/pci-0300_1002.present": "true",
  "kubernetes.io/arch": "amd64",
  "kubernetes.io/hostname": "black-knight-01",
  "kubernetes.io/os": "linux",
  "node-role.kubernetes.io/control-plane": ""
}
{
  "beta.amd.com/gpu.cu-count.12": "1",
  "beta.amd.com/gpu.device-id.1681": "1",
  "beta.amd.com/gpu.simd-count.24": "1",
  "beta.amd.com/gpu.vram.1G": "1",
  "beta.kubernetes.io/arch": "amd64",
  "beta.kubernetes.io/os": "linux",
  "extensions.talos.dev/amd-ucode": "20240909",
  "extensions.talos.dev/amdgpu-firmware": "20240909",
  "extensions.talos.dev/modules.dep": "6.6.52-talos",
  "extensions.talos.dev/realtek-firmware": "20240909",
  "extensions.talos.dev/thunderbolt": "v1.8.0",
  "feature.node.kubernetes.io/pci-0300_1002.present": "true",
  "kubernetes.io/arch": "amd64",
  "kubernetes.io/hostname": "black-knight-02",
  "kubernetes.io/os": "linux",
  "node-role.kubernetes.io/control-plane": ""
}
{
  "beta.amd.com/gpu.cu-count.12": "1",
  "beta.amd.com/gpu.device-id.1681": "1",
  "beta.amd.com/gpu.simd-count.24": "1",
  "beta.amd.com/gpu.vram.1G": "1",
  "beta.kubernetes.io/arch": "amd64",
  "beta.kubernetes.io/os": "linux",
  "extensions.talos.dev/amd-ucode": "20240909",
  "extensions.talos.dev/amdgpu-firmware": "20240909",
  "extensions.talos.dev/modules.dep": "6.6.52-talos",
  "extensions.talos.dev/realtek-firmware": "20240909",
  "extensions.talos.dev/thunderbolt": "v1.8.0",
  "feature.node.kubernetes.io/pci-0300_1002.present": "true",
  "kubernetes.io/arch": "amd64",
  "kubernetes.io/hostname": "black-knight-03",
  "kubernetes.io/os": "linux",
  "node-role.kubernetes.io/control-plane": ""
}

kubectl get nodes -o=jsonpath='{.items[*].status.nodeInfo.architecture}'
amd64 amd64 amd64

Can you try to get the crash log with kubectl logs <podname> --previous?

Can you try to get the crash log with kubectl logs <podname> --previous?

v<IP_ADDRESS>
kubectl -n kube-system get pods -o wide
NAME                                             READY   STATUS    RESTARTS       AGE   IP            NODE              NOMINATED NODE   READINESS GATES
amd-device-plugin-b5gsh                          1/1     Running   0              18h   <IP_ADDRESS>   black-knight-02   <none>           <none>
amd-device-plugin-d5rrd                          1/1     Running   0              18h   <IP_ADDRESS>   black-knight-03   <none>           <none>
amd-device-plugin-sf25x                          1/1     Running   0              18h   <IP_ADDRESS>    black-knight-01   <none>           <none>
amd-gpu-node-labeller-g8ntt                      1/1     Running   0              12h   <IP_ADDRESS>    black-knight-01   <none>           <none>
amd-gpu-node-labeller-xqvf8                      1/1     Running   0              12h   <IP_ADDRESS>   black-knight-03   <none>           <none>
amd-gpu-node-labeller-zz7wk                      1/1     Running   0              12h   <IP_ADDRESS>   black-knight-02   <none>           <none>

v<IP_ADDRESS>
kubectl -n kube-system get pods -o wide
NAME                                             READY   STATUS    RESTARTS       AGE   IP            NODE              NOMINATED NODE   READINESS GATES
amd-device-plugin-5htvl                          1/1     Running   0              5s    <IP_ADDRESS>    black-knight-02   <none>           <none>
amd-device-plugin-gw4d4                          0/1     Error     1 (3s ago)     3s    <IP_ADDRESS>   black-knight-03   <none>           <none>
amd-device-plugin-sf25x                          1/1     Running   0              18h   <IP_ADDRESS>    black-knight-01   <none>           <none>
amd-gpu-node-labeller-g8ntt                      1/1     Running   0              12h   <IP_ADDRESS>    black-knight-01   <none>           <none>
amd-gpu-node-labeller-xqvf8                      1/1     Running   0              12h   <IP_ADDRESS>   black-knight-03   <none>           <none>
amd-gpu-node-labeller-zz7wk                      1/1     Running   0              12h   <IP_ADDRESS>   black-knight-02   <none>           <none>

⬢ [Docker] ❯ kubectl logs amd-device-plugin-gw4d4 -n kube-system --previous
exec ./k8s-device-plugin: exec format error

ah ok... sorry I misunderstood what you had before.  This is weird... let me look into it.

Can you help narrow down the start of the issue a bit?  i.e. do you see the same issue with <IP_ADDRESS> and .5? (I don't have a Talos setup to reproduce and I am able to use the plugin tip of tree.)

Can you help narrow down the start of the issue a bit? i.e. do you see the same issue with <IP_ADDRESS> and .5? (I don't have a Talos setup to reproduce and I am able to use the plugin tip of tree.)

Sorry i thought i tested v<IP_ADDRESS>, but i suspect i didn't allow enough time for flux to update the commit.
I have now tried the following tags
v<IP_ADDRESS> ✔
v<IP_ADDRESS> ✔
v<IP_ADDRESS> ✔
v<IP_ADDRESS> ✔
v<IP_ADDRESS> ✔
v<IP_ADDRESS> ✔
v<IP_ADDRESS> ✖ (failing on node 3)
Thanks for looking into this. Hopefully, this helps narrow down the issue to the latest changes!

Um... I am not able to reproduce in my setup:

Actually, I just noticed this... you said it is failing on node 3, does that means the plugin is working in other nodes?  If that's the case, this doesn't seem like a plugin issue.

I was hoping to report back with a solution as to what caused my issue, unfortunately my solution was to destroy cluster and start again. Thanks again for taking time to try and reproduce.


SRS -Exercise 3

please check out our SRS decomantion,thanks

feedback from client
UC order by priority
UC diagram: missing arrows, every UC is a system function, remove application
UC2: this should be the main one, success crietria,
User stories: missing goal

all fixed @kob-e @robi-y


Upgrade compile sdk to 34

Fixes #154 #155
cc @zihejia

Any update on this?!

Thanks @davidmigloz ! We will address this in another PR for now.


lookup ghrc.io: no such host

Hey guys, thanks for this GH Action!
I'm getting started with this and noticed I would get an error about the ghrc.io host.
IMAGES: sha256:e7ca0cbe51fc5996f23db32df31fe037cd5829de63578adbdd35f7e670d46a08
sha256:ed9600e10450cd0387272529430d63b092fa017203fb13f9fcc905f753a33ea4
IMAGE: sha256:e7ca0cbe51fc5996f23db32df31fe037cd5829de63578adbdd35f7e670d46a08
The push refers to repository [ghrc.io/joshuanianji/<repo>/<name>]
Get "https://ghrc.io/v2/": dial tcp: lookup ghrc.io: no such host
IMAGE: sha256:ed9600e10450cd0387272529430d63b092fa017203fb13f9fcc905f753a33ea4
The push refers to repository [ghrc.io/joshuanianji/<repo>/<name>]
Get "https://ghrc.io/v2/": dial tcp: lookup ghrc.io: no such host
Error: Process completed with exit code 1.

I think this has to do with the following line, where ghrc.io should be ghcr.io.
https://github.com/HenriPodolski/publish_docker-compose-2-ghcr.io/blob/master/src/publish.sh#L25

Thanks Joshua! Fixed in v0.2.5.


Hide text on Color Widgets

It would be nice being able to hide the text on both ColorHSV and ColorRGB

such a thing can already be handled via Styles, see this screenshot :

Super, thanks.


NOISSUE - Fix NATS install instruction

Signed-off-by: Ivan Milošević<EMAIL_ADDRESS>What does this do?
Fix  install instruction in documentation to install NATS server instead of client
Which issue(s) does this PR fix/relate to?
Noissue

Codecov Report

Merging #423 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #423   +/-   ##
=======================================
  Coverage   89.29%   89.29%
=======================================
  Files          46       46
  Lines        1634     1634
=======================================
  Hits         1459     1459
  Misses        119      119
  Partials       56       56

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96bcc4c...801f55c. Read the comment docs.


Updated docs

Updated documentation on Authorized Services following recent updates: OAuth1a, Client Credentials and Long lived access tokens.

Additional documentation added following recent updates to OAuth1.

The section is still there: https://github.com/umbraco/Umbraco.AuthorizedServices/blob/feature/docs/README.md#app-creation

Merging changes in.


Default parameters

I'm wondering why the parameters for Bin are set to default to -1, in particular for x and y. Would a better default be 0?
/cc @bhousel

Background is that not setting them to 0 explicitly triggers undefined behavior when dividing by the offset (https://github.com/mapbox/mapbox-gl-native/pull/9509)

I think I just used -1 as uninitialized because 0,0 is a real coordinate that a bin can be packed into.

Okay; are there any use cases for initializing a Bin object without setting its location? If not, I think the parameters shouldn't be optional.

Bins start out with no location until they are packed.  So, external code should never supply a location.
see https://github.com/mapbox/shelf-pack-cpp#batch-packing
Only the internal shelf.alloc method should create bins with a location, see here
I'm not sure the most idiomatic (and performant) C++ way to implement this.  It would be great to drop the x and y arguments from the Bin constructor, in order to clear up the confusion.


Tabs storage

Hi,
I just installed your extension in my Linux computer ant it works great. I would like to know where is my tabs data stored in order to make a local backup of it.
I would also suggest a warning message when you clic on "Delete" a group of tabs. In case you just clicked by mistake.
Thanks!

@colibris79 Hi, the data stored in the chrome provided storage currently. You can use chrome.storage.local.get('lists', console.log) to get them. But also you can use the Export / Import function, it will help you get the lists and transform it into JSON format.

I don't like the alert personally, but I'd like to add an option to enable a warning message if it is helpful for someone.

Hi @cnwangjie. Thanks for your answer. An option to enable or not would be even better. About the data storage are there any files I could copy from my "chrome-browser/Default" folder in order to make the backup? I was thinking about setting up a cron task to save these files automatically everyday without having to export them myself

The chrome provided stroage is a built-in database instead of a normal text file in filesystem. Although there is an API allow access the file on filesystem but it is really unnecessary. The better onetab can help you sync the list data use cloud service.

I see. That would be nice as well, more automatic even : )
How can I sync my tabs with a cloud service? I am seeing in the "Options" tab that I can enable "Sync settings" and "Sync lists". How does that work?
And besides "Sync lists" it says "quota exceeded". How is that?

see #11 and #12
The chrome provided sync have the size limit (8KB). If the used storage size is more than the limit will display "quota exceeded". But I am working for sync with self hosted server and google drive.

Nice... How about using another cloud storing besides google drive? I say it for the people who live in China. Well, thanks a lot for your answers and this nice extension

Added option "alert before remove list" in v1.3.2


merge event and draw event handlers

https://github.com/littledivy/deno_sdl2/commit/c84a17495d44167a62bc2513c08f36dbe920a497


Check tie-breaking with importOrderCaseInsensitive and type imports

As mentioned in https://github.com/IanVS/prettier-plugin-sort-imports/issues/22#issuecomment-1132090026, we should check to be sure we correctly break ties when two imports differ only in capitalization, and importOrderCaseInsensitive is true.  Maybe this is already handled, I haven't checked.

While we're at it, we also need to break ties in case two imports only differ by whether they have a type specifier. I could make this a separate issue, but since it's both related to tie-breaking, I'd like to keep it in one issue
https://github.com/trivago/prettier-plugin-sort-imports/issues/116

I don't think this is a super big issue if we can count on a stable sort algorithm. If we can't then we have trouble. (Not-to mention that case-sensitivity issues are only possible on some-file-systems or with fake packages in node's resolution hierarchy.)
NodeJS's sort is not guaranteed stable, so I recommend we switch to a stable-sort. Here's a random one from npm: https://www.npmjs.com/package/stable / https://github.com/Two-Screen/stable -- it has zero deps, and does have TypeScript.
Additionally, I learned that a.localeCompare(b, 'en', {numeric: true, ignorePunctuation: true}) can be used for Natural Language sorting from a blog
So this proposal adds a dep, in exchange for removing a dep & a hand-written type-definition file. haha

I learned today that Javascript's language spec now requires Array.prototype.sort be a Stable-sort (since 2019 on V8!). https://v8.dev/features/stable-sort
Not sure when this made it to NodeJS, but I'm sure that implies we don't even need a dependency at all. That means this proposal allows us to remove the dependency & handwritten type-definition file and just use built-in JS! 🎉

Opened a related PR in #28

Hi @fbartho, I'm not exactly sure that having a stable sort is what we want in this case.  As @blutorange mentioned in the comment in the issue description:

we need to make sure that we break ties by falling back to case-sensitive sorting

Just because a sort is stable, doesn't mean this will happen, it means that whatever order the rows were in to begin with is how they will stay, so
import { a } from "someTHING";
import { a } from "SOMEthing";

would remain that way, and
import { a } from "SOMEthing";
import { a } from "someTHING";

would also not be changed.  We want a deterministic output instead, so as said, we have to fall back to case-sensitive.

I’m arguing that as an opinionated sorting tool, we should consider whether case-sensitivity is something we need to specially support.
While technically NodeJS does treat modules as case-sensitive, many/most file systems are case-insensitive (case preserving) by default.
An opinionated tool should express its opinion here to meet the majority need. We should avoid writing special handlers for what we can consider a bugged input in the common case.
Options:
A. Don’t handle it specially (as long as we’re stable)
B. Always handle insensitivity differences in a specific way
I’m suggesting that option A is our best move, because: being non-deterministic but stable, users who do fall into this edge case can manually handle the problem by moving the imports how they like.
If we were non-deterministic but unstable, edge-case users could constantly have their stuff shifting around, with no way to fix it.
Option B is more code and another decision: “which should go first, UPPER or lower variants?” — and this decision begs another config option which I oppose. — also, technically locale has an answer to which goes first https://github.com/IanVS/prettier-plugin-sort-imports/pull/28#discussion_r893610028
Anyhow, I’ve said my piece on this, happy to get in line with whichever decision you want to make. Let’s just pull the trigger and get the breaking release started. I’ll be much happier once we ship that.

@fbartho given the clearing up of misunderstanding in https://github.com/IanVS/prettier-plugin-sort-imports/pull/28#issuecomment-1151417095, does that change your stance above?

No, unfortunately, talking things through as I did above still makes me think that option A is the best one.
If you’re asking my opinion I still think we should go with Option A, then plan the breaking changes release, and restore #28 with the big breaking release.
If you want to make the call the other direction, then we need to implement the case-sensitive locale-based sorting.

Got it, thanks.  @blutorange do you have any thoughts or opinions here?

Well yeah sorry, I am pretty busy with real life. What's important in my opinion is that the formatter has a deterministic output and does not produce different results on different systems. That said, I'd be fine with both options,.

Relevant: but TypeScript/MS have an option now to control case-sensitive sorting https://devblogs.microsoft.com/typescript/announcing-typescript-5-0/#case-insensitive-import-sorting-in-editors


Restructure of files

The structure of HTML files in the repository does not follow the format that was initially specified in README.md in order to ensure the separation of concerns and keep the repository neat.
We need a restructuring of files according to this format. Restructuring does not just include moving files to follow the format but also making sure that all the links and references (to other HTML, CSS, JavaScript and other files) work.

@Sayed-Afnan-Khazi assign me to this issue

@cjstyles6 I've assigned this issue to you, good luck!

@Sayed-Afnan-Khazi can I also join @cjstyles6 to handle this task ???

Sure! I've assigned this issue to you as well @jayumaks. Good luck!


Disappearing Data-feed - Recreate new Data-Feed

Have noticed the below in my logs.  After a series of successful polls to the data feed,
[Wed Aug 17 2016 22:35:28 GMT-0400 (EDT)] DEBUG received 204 response from /agent/v2/datafeed/d46665fd-e400-4ac4-8303-846eafe1330d/read: undefined
[Wed Aug 17 2016 22:35:28 GMT-0400 (EDT)] DEBUG Polling datafeed d46665fd-e400-4ac4-8303-846eafe1330d
[Wed Aug 17 2016 22:35:59 GMT-0400 (EDT)] DEBUG received 204 response from /agent/v2/datafeed/d46665fd-e400-4ac4-8303-846eafe1330d/read: undefined
[Wed Aug 17 2016 22:35:59 GMT-0400 (EDT)] DEBUG Polling datafeed d46665fd-e400-4ac4-8303-846eafe1330d

We suddenly see a data-feed dissappear,
[Wed Aug 17 2016 22:35:59 GMT-0400 (EDT)] DEBUG received 400 response from /agent/v2/datafeed/d46665fd-e400-4ac4-8303-846eafe1330d/read: {"code":400,"message":"Could not find a datafeed with the provided id"}
[Wed Aug 17 2016 22:35:59 GMT-0400 (EDT)] DEBUG Received 0 datafeed messages
[Wed Aug 17 2016 22:35:59 GMT-0400 (EDT)] DEBUG Polling datafeed d46665fd-e400-4ac4-8303-846eafe1330d
[Wed Aug 17 2016 22:36:00 GMT-0400 (EDT)] DEBUG received 400 response from /agent/v2/datafeed/d46665fd-e400-4ac4-8303-846eafe1330d/read: {"code":400,"message":"Could not find a datafeed with the provided id"}
[Wed Aug 17 2016 22:36:00 GMT-0400 (EDT)] DEBUG Received 0 datafeed messages

Need the reconnect logic to be triggered when this event occurs.
"code":400,"message":"Could not find a datafeed with the provided id"

As discussed, on the POD I'm using we get HTTP 400 error codes all the time but immediately after receiving one the datafeed is still readable, i.e.
[Fri Aug 19 2016 14:36:47 GMT+0100 (GMT Daylight Time)] DEBUG received 200 response from /agent/v1/datafeed/create: {"id":"6732a79a-2ad3-40d2-8ab8-c66965f9af3e"}
[Fri Aug 19 2016 14:36:47 GMT+0100 (GMT Daylight Time)] INFO Created datafeed: 6732a79a-2ad3-40d2-8ab8-c66965f9af3e
[Fri Aug 19 2016 14:36:47 GMT+0100 (GMT Daylight Time)] DEBUG First 'poll' event emitted
[Fri Aug 19 2016 14:36:47 GMT+0100 (GMT Daylight Time)] DEBUG 'connected' event emitted
[Fri Aug 19 2016 14:36:47 GMT+0100 (GMT Daylight Time)] DEBUG Polling datafeed 6732a79a-2ad3-40d2-8ab8-c66965f9af3e
[Fri Aug 19 2016 14:37:18 GMT+0100 (GMT Daylight Time)] DEBUG received 204 response from /agent/v2/datafeed/6732a79a-2ad3-40d2-8ab8-c66965f9af3e/read: undefined
[Fri Aug 19 2016 14:37:18 GMT+0100 (GMT Daylight Time)] DEBUG Polling datafeed 6732a79a-2ad3-40d2-8ab8-c66965f9af3e
[Fri Aug 19 2016 14:37:19 GMT+0100 (GMT Daylight Time)] DEBUG received 400 response from /agent/v2/datafeed/6732a79a-2ad3-40d2-8ab8-c66965f9af3e/read: {"code":400,"message":"Could not find a datafeed with the provided id"}
[Fri Aug 19 2016 14:37:19 GMT+0100 (GMT Daylight Time)] DEBUG Received 0 datafeed messages
[Fri Aug 19 2016 14:37:49 GMT+0100 (GMT Daylight Time)] DEBUG received 204 response from /agent/v2/datafeed/6732a79a-2ad3-40d2-8ab8-c66965f9af3e/read: undefined
[Fri Aug 19 2016 14:37:49 GMT+0100 (GMT Daylight Time)] DEBUG Polling datafeed 6732a79a-2ad3-40d2-8ab8-c66965f9af3e
[Fri Aug 19 2016 14:37:50 GMT+0100 (GMT Daylight Time)] DEBUG received 400 response from /agent/v2/datafeed/6732a79a-2ad3-40d2-8ab8-c66965f9af3e/read: {"code":400,"message":"Could not find a datafeed with the provided id"}
[Fri Aug 19 2016 14:37:50 GMT+0100 (GMT Daylight Time)] DEBUG Received 0 datafeed messages
[Fri Aug 19 2016 14:37:50 GMT+0100 (GMT Daylight Time)] DEBUG Polling datafeed 6732a79a-2ad3-40d2-8ab8-c66965f9af3e
[Fri Aug 19 2016 14:38:20 GMT+0100 (GMT Daylight Time)] DEBUG received 204 response from /agent/v2/datafeed/6732a79a-2ad3-40d2-8ab8-c66965f9af3e/read: undefined
[Fri Aug 19 2016 14:38:20 GMT+0100 (GMT Daylight Time)] DEBUG Polling datafeed 6732a79a-2ad3-40d2-8ab8-c66965f9af3e
[Fri Aug 19 2016 14:38:20 GMT+0100 (GMT Daylight Time)] DEBUG received 400 response from /agent/v2/datafeed/6732a79a-2ad3-40d2-8ab8-c66965f9af3e/read: {"code":400,"message":"Could not find a datafeed with the provided id"}
[Fri Aug 19 2016 14:38:20 GMT+0100 (GMT Daylight Time)] DEBUG Received 0 datafeed messages

Ideally this "feature" will be fixed and then I'll change symphony.coffee to return an error unless the res?.statusCode // 100 == 2

The bug in Symphony seems to have been fixed so I will amend the code
[Fri Jan 20 2017 07:14:42 GMT+0000 (GMT Standard Time)] INFO Created datafeed: b29c4a2f-4485-4aea-89a5-482c0c811f0b
[Fri Jan 20 2017 07:14:42 GMT+0000 (GMT Standard Time)] DEBUG First 'poll' event emitted
[Fri Jan 20 2017 07:14:43 GMT+0000 (GMT Standard Time)] DEBUG 'connected' event emitted
[Fri Jan 20 2017 07:14:43 GMT+0000 (GMT Standard Time)] DEBUG Polling datafeed b29c4a2f-4485-4aea-89a5-482c0c811f0b
[Fri Jan 20 2017 07:15:13 GMT+0000 (GMT Standard Time)] DEBUG received 204 response from https://brevanhoward-api.symphony.com/agent/v2/datafeed/b29c4a2f-4485-4aea-89a5-482c0c811f0b/read: undefined
[Fri Jan 20 2017 07:15:13 GMT+0000 (GMT Standard Time)] DEBUG Polling datafeed b29c4a2f-4485-4aea-89a5-482c0c811f0b
[Fri Jan 20 2017 07:15:43 GMT+0000 (GMT Standard Time)] DEBUG received 204 response from https://brevanhoward-api.symphony.com/agent/v2/datafeed/b29c4a2f-4485-4aea-89a5-482c0c811f0b/read: undefined
[Fri Jan 20 2017 07:15:43 GMT+0000 (GMT Standard Time)] DEBUG Polling datafeed b29c4a2f-4485-4aea-89a5-482c0c811f0b
[Fri Jan 20 2017 07:16:13 GMT+0000 (GMT Standard Time)] DEBUG received 204 response from https://brevanhoward-api.symphony.com/agent/v2/datafeed/b29c4a2f-4485-4aea-89a5-482c0c811f0b/read: undefined
[Fri Jan 20 2017 07:16:13 GMT+0000 (GMT Standard Time)] DEBUG Polling datafeed b29c4a2f-4485-4aea-89a5-482c0c811f0b
[Fri Jan 20 2017 07:16:44 GMT+0000 (GMT Standard Time)] DEBUG received 204 response from https://brevanhoward-api.symphony.com/agent/v2/datafeed/b29c4a2f-4485-4aea-89a5-482c0c811f0b/read: undefined
[Fri Jan 20 2017 07:16:44 GMT+0000 (GMT Standard Time)] DEBUG Polling datafeed b29c4a2f-4485-4aea-89a5-482c0c811f0b```


[CFM_13] Database Tables Creation

Trello Ticket: https://trello.com/c/sXFoYKUv/23-cfm13-create-database-tables
Database Design: https://docs.google.com/document/d/16hjNHxm_ebZv8u_VolT1bdlJEDccqb7V67-Y6ljjUdY/edit?usp=sharing
Updates
functions/dev:
* Added two functions to input and get data from the fridge table. These functions are solely to test that a dynamodb connection was successfully made and it will eventually get deleted
template.yaml:
* Added Dynamodb table resource
* Added Function resource for functions/dev functions
README.md:
* Updated README with instructions on how to run dynamodb locally
Testing
Guide that was used: https://betterprogramming.pub/how-to-deploy-a-local-serverless-application-with-aws-sam-b7b314c3048c
Follow these steps to get Dynamodb running locally

Create a Docker bridge network

docker network create cfm-network
docker run --network cfm-network --name dynamodb -d -p 8000:8000 amazon/dynamodb-local

Create Dynamodb tables locally

fridge: aws dynamodb create-table --table-name fridge --attribute-definitions AttributeName=state,AttributeType=S AttributeName=fridge_name,AttributeType=S --key-schema AttributeName=state,KeyType=HASH AttributeName=fridge_name,KeyType=RANGE --provisioned-throughput ReadCapacityUnits=5,WriteCapacityUnits=5 --endpoint-url http://localhost:8000
fridge_check_in: aws dynamodb create-table --table-name fridge_check_in --attribute-definitions AttributeName=pk,AttributeType=S AttributeName=timestamp,AttributeType=N --key-schema AttributeName=pk,KeyType=HASH AttributeName=timestamp,KeyType=RANGE --provisioned-throughput ReadCapacityUnits=5,WriteCapacityUnits=5 --endpoint-url http://localhost:8000
fridge_history: aws dynamodb create-table --table-name fridge_history --attribute-definitions AttributeName=pk,AttributeType=S AttributeName=timestamp,AttributeType=N --key-schema AttributeName=pk,KeyType=HASH AttributeName=timestamp,KeyType=RANGE --provisioned-throughput ReadCapacityUnits=5,WriteCapacityUnits=5 --endpoint-url http://localhost:8000

Build the functions inside a Docker container

sam build --use-container

Load data into your local Dynamodb tables

sam local invoke LoadFridgeDataFunction --parameter-overrides ParameterKey=Environment,ParameterValue=local --docker-network cfm-network

Get data from your local Dynamodb tables

Generate sample payload: sam local generate-event apigateway aws-proxy --method GET --path document --body "" > local-event.json
sam local invoke GetAllFunction --event local-event.json --parameter-overrides ParameterKey=Environment,ParameterValue=local --docker-network cfm-network

Expected Response:

FWIW, should we include type hints as well? Comes included with the default typing module, and improves readability/maintainability

FWIW, should we include type hints as well? Comes included with the default typing module, and improves readability/maintainability

Yesss, lets do it :)

I was able to run this locally.

FWIW, should we include type hints as well? Comes included with the default typing module, and improves readability/maintainability

I added type hints in my latest commit

get_all and load_fridge_data seem to have common functionality. Should we move to an object oriented structure and define a base class? All function handler can inherit that base class then

I think creating a class structure might be overkill for these lambdas? If we were keeping some sort of state or if we had more common functions perhaps I would want to create a class structure then @abhinav1912

@abhinav1912 ended up adding a class structure so that I could give an example of a mock db


Cannot set up route/entry for Wordpress in docker-compose

Hey there! I stumbled across your project and I am really digging it so far! I am trying to set up Reproxy as a reverse proxy in my Docker Compose set up. I want to build a setup for my husband's web presence, using Docker.
Unfortunately, I am currently unable to implement Reproxy correctly. So far I have both Reproxy and  Wordpress containers (one each). This is what I'm trying to achieve. When connecting to localhost, Reproxy should redirect/connect to the Wordpress container. I want to add a Mailcow installation later, so the Wordpress container should be the default when connecting to the domain. So when I enter http://localhost I should see my website and/or Wordpress Dashboard.
Unfortunately this doesn't work for me yet and I cannot tell why...
This is my compose file for Reproxy:
services:
  reproxy:
    image: umputun/reproxy:master
    container_name: reproxy
    hostname: reproxy
    ports:
      - "80:8080"
    volumes:
      - /var/run/docker.sock:/var/run/docker.sock:ro
      - ./web:/web
    environment:
      - TZ=Europe/Amsterdam
      - LISTEN=<IP_ADDRESS>:8080
      - DOCKER_ENABLED=true
      - DOCKER_AUTO=false
      - DEBUG=true
      - SSL_TYPE=none

This is the compose settings in the file for Wordpress:
wordpress:
    depends_on:
      - db
    image: wordpress:latest
    volumes:
      - wordpress_data:/var/www/html
    restart: always
    hostname: wordpress
    container_name: wordpress
    environment:
      WORDPRESS_DB_HOST: db
      WORDPRESS_DB_USER: wordpress
      WORDPRESS_DB_PASSWORD: wordpress
      WORDPRESS_DB_NAME: wordpress
    labels:
      - reproxy.enabled= true
      - reproxy.server= localhost
      - reproxy.port=80

When I try to access http://localhost, I only see Server error... I feel like I am doing something wrong, but I tried everything and don't know how to fix this. Thank you!

Also, this is the container output (through sudo docker-compose up):
reproxy    | 2022/02/13 19:25:54.846 [DEBUG] {provider/docker.go:302 provider.(*Docker).listContainers} container reproxy excluded
reproxy    | 2022/02/13 19:25:54.846 [DEBUG] {provider/docker.go:336 provider.(*Docker).listContainers} completed list
reproxy    | 2022/02/13 19:25:54.847 [INFO]  {discovery/discovery.go:140 discovery.(*Service).Run} proxy  docker: localhost ^/wordpress/(.*) -> http://<IP_ADDRESS>:80/$1
reproxy    | 2022/02/13 19:26:07.561 [WARN]  {proxy/proxy.go:239 proxy.(*Http).proxyHandler.func2} no match for  /


Change to .equals for string comparison

Codecov Report
Base: 65.18% // Head: 65.15% // Decreases project coverage by -0.03% :warning:

Coverage data is based on head (6666be4) compared to base (86ef9eb).
Patch coverage: 50.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #333      +/-   ##
============================================
- Coverage     65.18%   65.15%   -0.04%
  Complexity      684      684
============================================
  Files           113      113
  Lines          2275     2273       -2
  Branches        260      260
============================================
- Hits           1483     1481       -2
  Misses          686      686
  Partials        106      106

Impacted Files
Coverage Δ

.../main/java/seedu/address/model/client/Address.java
72.72% <0.00%> (ø)

...rc/main/java/seedu/address/model/client/Email.java
72.72% <0.00%> (ø)

...address/logic/parser/ViewMeetingCommandParser.java
66.66% <100.00%> (-8.34%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Run prepack before publish

Resolves https://github.com/whitecolor/yalc/issues/92
It looks like the code only runs the first found pre~ script, and the first found post~ script, so I adjusted the wording of the readme to match that. I guess it's probably something that will get fixed in the future, but I think it's worth it to document the behavior.

:tada:


Multiple icons can be selected at once

Clicking first the tools icon and then the help icon opens both boxes. I would them to be exclusive, so one box to close when the other opens.

Fixed for next release


Use jsonmergepatch.CreateThreeWayJSONMergePatch for unstructured objects

What this PR does / why we need it:
closes #9937
Use jsonmergepatch.CreateThreeWayJSONMergePatch to create three way merge patch for unstructured objects like kubectl apply does.
Special notes for your reviewer:
If applicable:

[ ] this PR contains documentation
[ ] this PR contains unit tests
[x] this PR has been tested for backwards compatibility

@mattfarina
Since kube.Client.Update is called at multiple places besides upgrade action, I've added a --use-three-way-merge-patch-for-unstructured global flag to control the behavior.
Yes, the name of the flag is a bit ridiculously long. I'd like some idea about how to name it better if any...

Say someone was upgrading from a version of Helm without this flag, then started using it after upgrading to Helm 3.7. Would Kubernetes be able to resolve the upgrade or would it return an error? Or worse, is the behaviour underfined when switching from a generic merge patch to a generic three-way JSON merge patch?
Conversely, if someone calls helm --use-three-way-merge-patch-for-unstructured install mychart . then helm upgrade mychart . (generic three-way JSON merge patch to generic merge patch), what happens?
I'm trying to determine if users can use these merge patch strategies interchangeably or not. Because I can imaging the scenario where someone forgets to add this flag during a helm upgrade and suddenly puts their Helm release into an irrecoverable state.

Say someone was upgrading from a version of Helm without this flag, then started using it after upgrading to Helm 3.7. Would Kubernetes be able to resolve the upgrade or would it return an error? Or worse, is the behavior undefined when switching from a generic merge patch to a generic three-way JSON merge patch?
Conversely, if someone calls helm --use-three-way-merge-patch-for-unstructured install mychart . then helm upgrade mychart . (generic three-way JSON merge patch to generic merge patch), what happens?
I'm trying to determine if users can use these merge patch strategies interchangeably or not. Because I can imagine the scenario where someone forgets to add this flag during a helm upgrade and suddenly puts their Helm release into an irrecoverable state.

To summarize any behavior change if the flag is set:

Only affects custom resources, like VirtualService, and CustomResourceDefinition resources.
Only affects changes to those resources, i.e. mostly when running helm upgrade and helm rollback.

It's ok to interchangeably use any strategies. Because:

There will be no difference for the stored release meta, since it's the rendered manifests that are stored. Patch strategies only affect how the live state of resources will become after an update.
The behavior of either patch strategies is determined, and has nothing to do with what was used previously. Actually the two way merge patch will only miss out some changes and never do more. See below for the only possible difference of these two patch strategies:

# original / last applied
a: 1

# target / to update to
a: 1

# live state
a: 2

# result live state
a: 2 # if it's two way
a: 1 # if it's three way

Sorry for the late reply.

Could you provide unit tests for this feature? would love to keep the review cycles going :)


feat: add tradingview to dict

Please read the Contributions Guide before making Pull Requests.

add tradingview to dict

Thanks but I think it would be a bit too specific to the brand. You might consider using custom dict instead.


Upgrade pip

Change Description
Upgrade pip
WARNING: You are using pip version 22.0.4; however, version 23.3.2 is available.
Issue reference
This PR fixes issue #XX
Checklist

[ ] I have reviewed the contribution guidelines
[ ] I have signed the CLA (if required)
[ ] My code includes unit tests
[ ] All unit tests and lint checks pass locally
[ ] My PR contains documentation updates / additions if required

@microsoft-github-policy-service agree

Thanks! We will review and merge this shortly.


this happaned again No subtitles matching the filter were found. Download failed.

yesterday its work in 1.0.4 fix and today its happaned again
the error
https://i.imgur.com/S2LrIm2.png

@MichaelYochpaz iTunes still using the GROUP-ID "subtitles_ak", I modified the script by replacing
p.group_id == "subtitles_vod-ak-amt.tv.apple.com"
with
(p.group_id == "subtitles_ak" or p.group_id == "subtitles_vod-ak-amt.tv.apple.com")
and I was able to download the subtitles from the link
https://itunes.apple.com/il/movie/batman-1966/id280315278
Batman.1966.iT.WEB.zip
https://play.itunes.apple.com/WebObjects/MZPlay.woa/hls/playlist.m3u8?cc=IL&a=280315278&id=185492124&l=en&aec=SD
#EXT-X-SESSION-DATA:DATA-ID="com.apple.hls.accessibility",VALUE="CC,SDH"
#EXT-X-SESSION-DATA:DATA-ID="com.apple.hls.feature.adam-id",VALUE="280315278"
#EXT-X-SESSION-DATA:DATA-ID="com.apple.hls.title",VALUE="Batman (1966)",LANGUAGE="en-us"
#EXT-X-SESSION-DATA:DATA-ID="com.apple.hls.poster",VALUE="https://is4-ssl.mzstatic.com/image/thumb/SLnqDGi1_EGWIvh_VVx4Jg/{w}x{h}bb.{f}",LANGUAGE="en-us"
#EXT-X-SESSION-DATA:DATA-ID="com.apple.hls.genre",VALUE="Action & Adventure",LANGUAGE="en-us"
#EXT-X-SESSION-DATA:DATA-ID="com.apple.hls.release-date",VALUE="1966-07-30T07:00:00Z"
#EXT-X-SESSION-DATA:DATA-ID="com.apple.hls.rating-tag",VALUE="UR"
#EXT-X-SESSION-DATA:DATA-ID="com.apple.hls.rating-system",VALUE="il-movies"
#EXT-X-SESSION-DATA:DATA-ID="com.apple.hls.rating-rank",VALUE="900"
#EXT-X-SESSION-DATA:DATA-ID="com.apple.hls.rt-audience-score",VALUE="0.79"
#EXT-X-SESSION-DATA:DATA-ID="com.apple.hls.rt-rating",VALUE="FRESH"
#EXT-X-SESSION-DATA:DATA-ID="com.apple.hls.description",VALUE="Batman (Adam West) and Robin (Burt Ward) must launch a rescue mission when they get a tip that Commodore Schmidlapp (Reginald Denny) is in danger aboard his yacht.  But the tip is a set-up by four of the most powerful villains ever, who seek to defeat the dynamic duo once and for all! Armed with a dehydrator that can turn humans into dust, the fearsome foursome intends to take over the world!  Can the Caped Crusaders use their high-flying heroism and groovy gadgetry to declaw Catwoman (Lee Meriwether), ice the Penguin (Burgess Meredith), upstage the Joker (Cesar Romero), and stump the Riddler (Frank Gorshin) in time?",LANGUAGE="en-us"
#EXT-X-MEDIA:TYPE=SUBTITLES,GROUP-ID="subtitles_ap",LANGUAGE="ar",NAME="العربية",AUTOSELECT=YES,FORCED=NO,STABLE-RENDITION-ID="a65b8d159982025450433bb60faa5af8db407c6560748e4eea470108b76295ba",URI="https://vod-ap-amt.tv.apple.com/itunes-assets/HLSVideo124/v4/ff/1e/cf/ff1ecfaa-a397-29b1-0587-6654a83b4516/P185492124_A280315278_FF_ar_subtitles.m3u8"
#EXT-X-MEDIA:TYPE=SUBTITLES,GROUP-ID="subtitles_ak",LANGUAGE="ar",NAME="العربية",AUTOSELECT=YES,FORCED=NO,STABLE-RENDITION-ID="a65b8d159982025450433bb60faa5af8db407c6560748e4eea470108b76295ba",URI="https://vod-ak-amt.tv.apple.com/itunes-assets/HLSVideo124/v4/ff/1e/cf/ff1ecfaa-a397-29b1-0587-6654a83b4516/P185492124_A280315278_FF_ar_subtitles.m3u8"

@Essam3111 that indeed seems to be the issue.
Fixed in v1.0.5


Error: Cannot find module './converters/common'

zigbee2mqtt add-on version (if edge, please report commit hash):
Zigbee2mqtt
Current version: 1.17.0
Operating environment (HassOS, Virtual Machine, Device/platform running Home Assistant):
OVM virtualmachine vmware
Supervisor Version 2020.12.7
Operating System Home Assistant OS 5.10
Description of problem:
Zigbee2mqrr stop working last night
Your entire configuration from the frontend (with sensitive fields redacted):
data_path: /share/zigbee2mqtt
external_converters: []
devices: devices.yaml
groups: groups.yaml
homeassistant: true
permit_join: false
mqtt:
  base_topic: zigbee2mqtt
  server: 'mqtt://<IP_ADDRESS>:1883'
  user: secret
  password: secret
serial:
  port: /dev/ttyUSB0
advanced:
  log_level: info
  pan_id: 6791
  channel: 11
  network_key:
    - 1
    - 3
    - 5
    - 7
    - 9
    - 11
    - 13
    - 15
    - 0
    - 2
    - 4
    - 6
    - 8
    - 10
    - 12
    - 13
  availability_blocklist: []
  availability_passlist: []
device_options: {}
blocklist: []
passlist: []
queue: {}
frontend:
  port: 8099
experimental:
  new_api: true
  frontend: true
socat:
  enabled: false
  master: 'pty,raw,echo=0,link=/dev/ttyZ2M,mode=777'
  slave: 'tcp-listen:8485,keepalive,nodelay,reuseaddr,keepidle=1,keepintvl=1,keepcnt=5'
  restartdelay: 1
  initialdelay: 1
  options: '-d -d'
  log: true
zigbee_shepherd_devices: true

2021-01-04T08:15:21: PM2 log: App [npm:0] exited with code [1] via signal [SIGINT]
2021-01-04T08:15:21: PM2 log: App [npm:0] starting in -fork mode-
2021-01-04T08:15:21: PM2 log: App [npm:0] online
><EMAIL_ADDRESS>start /zigbee2mqtt-1.17.0
> node index.js
internal/modules/cjs/loader.js:968
  throw err;
  ^
Error: Cannot find module './converters/common'
Require stack:
- /zigbee2mqtt-1.17.0/node_modules/zigbee-herdsman-converters/devices.js
- /zigbee2mqtt-1.17.0/node_modules/zigbee-herdsman-converters/index.js
- /zigbee2mqtt-1.17.0/lib/zigbee.js
- /zigbee2mqtt-1.17.0/lib/controller.js
- /zigbee2mqtt-1.17.0/index.js
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:965:15)
    at Function.Module._load (internal/modules/cjs/loader.js:841:27)
    at Module.require (internal/modules/cjs/loader.js:1025:19)
    at require (internal/modules/cjs/helpers.js:72:18)
    at Object.<anonymous> (/zigbee2mqtt-1.17.0/node_modules/zigbee-herdsman-converters/devices.js:23:16)
    at Module._compile (internal/modules/cjs/loader.js:1137:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1157:10)
    at Module.load (internal/modules/cjs/loader.js:985:32)
    at Function.Module._load (internal/modules/cjs/loader.js:878:14)
    at Module.require (internal/modules/cjs/loader.js:1025:19) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '/zigbee2mqtt-1.17.0/node_modules/zigbee-herdsman-converters/devices.js',
    '/zigbee2mqtt-1.17.0/node_modules/zigbee-herdsman-converters/index.js',
    '/zigbee2mqtt-1.17.0/lib/zigbee.js',
    '/zigbee2mqtt-1.17.0/lib/controller.js',
    '/zigbee2mqtt-1.17.0/index.js'
  ]
}
npm
 ERR! code ELIFECYCLE
npm
 ERR! errno 1
npm
 ERR<EMAIL_ADDRESS>start: `node index.js`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>start script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
// replace this line with your pasted configuration

Can you test out https://github.com/zigbee2mqtt/hassio-zigbee2mqtt with your config? You might get warnings if you don't remove some options (See below), but it should work.
  restartdelay: 1
  initialdelay: 1

Can you test out https://github.com/zigbee2mqtt/hassio-zigbee2mqtt with your config? You might get warnings if you don't remove some options (See below), but it should work.
  restartdelay: 1
  initialdelay: 1

I also have this exact same issue.

I also have this exact same issue.

Can you please post the logs as well?

Can you please post the logs as well?

Sure:  Here is the log (Config will follow after that)
Zigbee2mqtt
2021-01-04T14:01:02: PM2 log: App [npm:0] starting in -fork mode-
2021-01-04T14:01:02: PM2 log: App [npm:0] online
><EMAIL_ADDRESS>start /zigbee2mqtt-1.17.0
> node index.js
internal/modules/cjs/loader.js:968
  throw err;
  ^
Error: Cannot find module './converters/common'
Require stack:
- /zigbee2mqtt-1.17.0/node_modules/zigbee-herdsman-converters/devices.js
- /zigbee2mqtt-1.17.0/node_modules/zigbee-herdsman-converters/index.js
- /zigbee2mqtt-1.17.0/lib/zigbee.js
- /zigbee2mqtt-1.17.0/lib/controller.js
- /zigbee2mqtt-1.17.0/index.js
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:965:15)
    at Function.Module._load (internal/modules/cjs/loader.js:841:27)
    at Module.require (internal/modules/cjs/loader.js:1025:19)
    at require (internal/modules/cjs/helpers.js:72:18)
    at Object.<anonymous> (/zigbee2mqtt-1.17.0/node_modules/zigbee-herdsman-converters/devices.js:23:16)
    at Module._compile (internal/modules/cjs/loader.js:1137:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1157:10)
    at Module.load (internal/modules/cjs/loader.js:985:32)
    at Function.Module._load (internal/modules/cjs/loader.js:878:14)
    at Module.require (internal/modules/cjs/loader.js:1025:19) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '/zigbee2mqtt-1.17.0/node_modules/zigbee-herdsman-converters/devices.js',
    '/zigbee2mqtt-1.17.0/node_modules/zigbee-herdsman-converters/index.js',
    '/zigbee2mqtt-1.17.0/lib/zigbee.js',
    '/zigbee2mqtt-1.17.0/lib/controller.js',
    '/zigbee2mqtt-1.17.0/index.js'
  ]
}
npm

ERR!
 code ELIFECYCLE
npm ERR!
 errno 1
npm
 ERR<EMAIL_ADDRESS>start: `node index.js`
npm ERR! Exit status 1
npm
 ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>start script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR! A complete log of this run can be found in:
npm
 ERR!     /root/.npm/_logs/2021-01-04T14_01_10_586Z-debug.log
2021-01-04T14:01:12: PM2 log: App [npm:0] exited with code [1] via signal [SIGINT]
2021-01-04T14:01:12: PM2 log: App [npm:0] starting in -fork mode-
2021-01-04T14:01:12: PM2 log: App [npm:0] online
><EMAIL_ADDRESS>start /zigbee2mqtt-1.17.0
> node index.js
internal/modules/cjs/loader.js:968
  throw err;
  ^
Error: Cannot find module './converters/common'
Require stack:
- /zigbee2mqtt-1.17.0/node_modules/zigbee-herdsman-converters/devices.js
- /zigbee2mqtt-1.17.0/node_modules/zigbee-herdsman-converters/index.js
- /zigbee2mqtt-1.17.0/lib/zigbee.js
- /zigbee2mqtt-1.17.0/lib/controller.js
- /zigbee2mqtt-1.17.0/index.js
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:965:15)
    at Function.Module._load (internal/modules/cjs/loader.js:841:27)
    at Module.require (internal/modules/cjs/loader.js:1025:19)
    at require (internal/modules/cjs/helpers.js:72:18)
    at Object.<anonymous> (/zigbee2mqtt-1.17.0/node_modules/zigbee-herdsman-converters/devices.js:23:16)
    at Module._compile (internal/modules/cjs/loader.js:1137:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1157:10)
    at Module.load (internal/modules/cjs/loader.js:985:32)
    at Function.Module._load (internal/modules/cjs/loader.js:878:14)
    at Module.require (internal/modules/cjs/loader.js:1025:19) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '/zigbee2mqtt-1.17.0/node_modules/zigbee-herdsman-converters/devices.js',
    '/zigbee2mqtt-1.17.0/node_modules/zigbee-herdsman-converters/index.js',
    '/zigbee2mqtt-1.17.0/lib/zigbee.js',
    '/zigbee2mqtt-1.17.0/lib/controller.js',
    '/zigbee2mqtt-1.17.0/index.js'
  ]
}
npm
 ERR! code ELIFECYCLE
npm ERR! errno 1
npm
ERR<EMAIL_ADDRESS>start: `node index.js`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>start script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR! A complete log of this run can be found in:
npm
 ERR!     /root/.npm/_logs/2021-01-04T14_01_20_557Z-debug.log
2021-01-04T14:01:22: PM2 log: App [npm:0] exited with code [1] via signal [SIGINT]
2021-01-04T14:01:22: PM2 log: App [npm:0] starting in -fork mode-
2021-01-04T14:01:22: PM2 log: App [npm:0] online
><EMAIL_ADDRESS>start /zigbee2mqtt-1.17.0
> node index.js

And the config:
data_path: /share/zigbee2mqtt
external_converters: []
devices: devices.yaml
groups: groups.yaml
homeassistant: true
permit_join: false
mqtt:
  base_topic: zigbee2mqtt
  server: 'mqtt://mqtt.spookhollow.net'
  user: hass
  password: hass
serial:
  port: /dev/ttyACM0
  disable_led: true
advanced:
  pan_id: 6754
  channel: 11
  network_key:
    - 1
    - 3
    - 5
    - 7
    - 9
    - 11
    - 13
    - 15
    - 0
    - 2
    - 4
    - 6
    - 8
    - 10
    - 12
    - 13
  availability_blocklist: []
  availability_passlist: []
device_options: {}
blocklist: []
passlist: []
queue: {}
frontend:
  port: 8099
experimental:
  new_api: true
socat:
  enabled: false
  master: 'pty,raw,echo=0,link=/dev/ttyZ2M,mode=777'
  slave: 'tcp-listen:8485,keepalive,nodelay,reuseaddr,keepidle=1,keepintvl=1,keepcnt=5'
  options: '-d -d'
  log: true
  restartdelay: 1
  initialdelay: 1
zigbee_shepherd_devices: true

Sure:  Here is the log (Config will follow after that)
Zigbee2mqtt
2021-01-04T14:01:02: PM2 log: App [npm:0] starting in -fork mode-
2021-01-04T14:01:02: PM2 log: App [npm:0] online
><EMAIL_ADDRESS>start /zigbee2mqtt-1.17.0
> node index.js
internal/modules/cjs/loader.js:968
  throw err;
  ^
Error: Cannot find module './converters/common'
Require stack:
- /zigbee2mqtt-1.17.0/node_modules/zigbee-herdsman-converters/devices.js
- /zigbee2mqtt-1.17.0/node_modules/zigbee-herdsman-converters/index.js
- /zigbee2mqtt-1.17.0/lib/zigbee.js
- /zigbee2mqtt-1.17.0/lib/controller.js
- /zigbee2mqtt-1.17.0/index.js
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:965:15)
    at Function.Module._load (internal/modules/cjs/loader.js:841:27)
    at Module.require (internal/modules/cjs/loader.js:1025:19)
    at require (internal/modules/cjs/helpers.js:72:18)
    at Object.<anonymous> (/zigbee2mqtt-1.17.0/node_modules/zigbee-herdsman-converters/devices.js:23:16)
    at Module._compile (internal/modules/cjs/loader.js:1137:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1157:10)
    at Module.load (internal/modules/cjs/loader.js:985:32)
    at Function.Module._load (internal/modules/cjs/loader.js:878:14)
    at Module.require (internal/modules/cjs/loader.js:1025:19) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '/zigbee2mqtt-1.17.0/node_modules/zigbee-herdsman-converters/devices.js',
    '/zigbee2mqtt-1.17.0/node_modules/zigbee-herdsman-converters/index.js',
    '/zigbee2mqtt-1.17.0/lib/zigbee.js',
    '/zigbee2mqtt-1.17.0/lib/controller.js',
    '/zigbee2mqtt-1.17.0/index.js'
  ]
}
npm

ERR!
 code ELIFECYCLE
npm ERR!
 errno 1
npm
 ERR<EMAIL_ADDRESS>start: `node index.js`
npm ERR! Exit status 1
npm
 ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>start script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR! A complete log of this run can be found in:
npm
 ERR!     /root/.npm/_logs/2021-01-04T14_01_10_586Z-debug.log
2021-01-04T14:01:12: PM2 log: App [npm:0] exited with code [1] via signal [SIGINT]
2021-01-04T14:01:12: PM2 log: App [npm:0] starting in -fork mode-
2021-01-04T14:01:12: PM2 log: App [npm:0] online
><EMAIL_ADDRESS>start /zigbee2mqtt-1.17.0
> node index.js
internal/modules/cjs/loader.js:968
  throw err;
  ^
Error: Cannot find module './converters/common'
Require stack:
- /zigbee2mqtt-1.17.0/node_modules/zigbee-herdsman-converters/devices.js
- /zigbee2mqtt-1.17.0/node_modules/zigbee-herdsman-converters/index.js
- /zigbee2mqtt-1.17.0/lib/zigbee.js
- /zigbee2mqtt-1.17.0/lib/controller.js
- /zigbee2mqtt-1.17.0/index.js
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:965:15)
    at Function.Module._load (internal/modules/cjs/loader.js:841:27)
    at Module.require (internal/modules/cjs/loader.js:1025:19)
    at require (internal/modules/cjs/helpers.js:72:18)
    at Object.<anonymous> (/zigbee2mqtt-1.17.0/node_modules/zigbee-herdsman-converters/devices.js:23:16)
    at Module._compile (internal/modules/cjs/loader.js:1137:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1157:10)
    at Module.load (internal/modules/cjs/loader.js:985:32)
    at Function.Module._load (internal/modules/cjs/loader.js:878:14)
    at Module.require (internal/modules/cjs/loader.js:1025:19) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '/zigbee2mqtt-1.17.0/node_modules/zigbee-herdsman-converters/devices.js',
    '/zigbee2mqtt-1.17.0/node_modules/zigbee-herdsman-converters/index.js',
    '/zigbee2mqtt-1.17.0/lib/zigbee.js',
    '/zigbee2mqtt-1.17.0/lib/controller.js',
    '/zigbee2mqtt-1.17.0/index.js'
  ]
}
npm
 ERR! code ELIFECYCLE
npm ERR! errno 1
npm
ERR<EMAIL_ADDRESS>start: `node index.js`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>start script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR! A complete log of this run can be found in:
npm
 ERR!     /root/.npm/_logs/2021-01-04T14_01_20_557Z-debug.log
2021-01-04T14:01:22: PM2 log: App [npm:0] exited with code [1] via signal [SIGINT]
2021-01-04T14:01:22: PM2 log: App [npm:0] starting in -fork mode-
2021-01-04T14:01:22: PM2 log: App [npm:0] online
><EMAIL_ADDRESS>start /zigbee2mqtt-1.17.0
> node index.js

And the config:
data_path: /share/zigbee2mqtt
external_converters: []
devices: devices.yaml
groups: groups.yaml
homeassistant: true
permit_join: false
mqtt:
  base_topic: zigbee2mqtt
  server: 'mqtt://mqtt.spookhollow.net'
  user: hass
  password: hass
serial:
  port: /dev/ttyACM0
  disable_led: true
advanced:
  pan_id: 6754
  channel: 11
  network_key:
    - 1
    - 3
    - 5
    - 7
    - 9
    - 11
    - 13
    - 15
    - 0
    - 2
    - 4
    - 6
    - 8
    - 10
    - 12
    - 13
  availability_blocklist: []
  availability_passlist: []
device_options: {}
blocklist: []
passlist: []
queue: {}
frontend:
  port: 8099
experimental:
  new_api: true
socat:
  enabled: false
  master: 'pty,raw,echo=0,link=/dev/ttyZ2M,mode=777'
  slave: 'tcp-listen:8485,keepalive,nodelay,reuseaddr,keepidle=1,keepintvl=1,keepcnt=5'
  options: '-d -d'
  log: true
  restartdelay: 1
  initialdelay: 1
zigbee_shepherd_devices: true

Are you sure you tried the add-on from here: https://github.com/zigbee2mqtt/hassio-zigbee2mqtt  ?
Looks like you still use the old one:  2021-01-04T14:01:02: PM2 log: App [npm:0] starting in -fork mode-

Are you sure you tried the add-on from here: https://github.com/zigbee2mqtt/hassio-zigbee2mqtt  ?
Looks like you still use the old one:  2021-01-04T14:01:02: PM2 log: App [npm:0] starting in -fork mode-

Well it looks like that might well be the case. I hadn't realised there was an alternative!   I've uninstalled the add-in, removed the old repo from the "store", added the new location  but installing the add-in then times out with a 504 error.  I'll leave it for a little while, restart the whole system and see what happens then.  I'll report back later today.  Thanks for your guidance so far.

Well it looks like that might well be the case. I hadn't realised there was an alternative!   I've uninstalled the add-in, removed the old repo from the "store", added the new location  but installing the add-in then times out with a 504 error.  I'll leave it for a little while, restart the whole system and see what happens then.  I'll report back later today.  Thanks for your guidance so far.

Are you sure you tried the add-on from here: https://github.com/zigbee2mqtt/hassio-zigbee2mqtt ?
Looks like you still use the old one: 2021-01-04T14:01:02: PM2 log: App [npm:0] starting in -fork mode-
New one should have an output similar to:
[s6-init] making user provided files available at /var/run/s6/etc...exited 0.
[s6-init] ensuring user provided files have correct perms...exited 0.
[fix-attrs.d] applying ownership & permissions fixes...
[fix-attrs.d] done.
[cont-init.d] executing container initialization scripts...
[cont-init.d] socat.sh: executing...
[14:30:09] INFO: Socat not enabled, marking service as down
[cont-init.d] socat.sh: exited 0.
[cont-init.d] zigbee2mqtt.sh: executing...
[14:30:10] INFO: MQTT available, fetching server detail ...
[14:30:10] INFO: MQTT server settings not configured, trying to auto-discovering ...
[14:30:11] INFO: Configuring 'mqtt://core-mosquitto:1883' mqtt server
[14:30:11] INFO: MQTT credentials not configured, trying to auto-discovering ...
[14:30:11] INFO: Configuring'addons' mqtt user
[14:30:11] INFO: Previous config file found, checking backup
[14:30:11] INFO: Creating backup config in '/config/zigbee2mqtt/.configuration.yaml.bk'
[14:30:11] INFO: Adjusting Zigbee2mqtt core yaml config with add-on quirks ...
[cont-init.d] zigbee2mqtt.sh: exited 0.
[cont-init.d] done.
[services.d] starting services
[services.d] done.
[14:30:13] INFO: Handing over control to Zigbee2mqtt Core ...
><EMAIL_ADDRESS>start /app
> node index.js

You have rigt  there was wrong old repo . Also for start  new version from new repo i was force to remove  from config  line  zigbee_shepherd_devices: true

Are you sure you tried the add-on from here: https://github.com/zigbee2mqtt/hassio-zigbee2mqtt ?
Looks like you still use the old one: 2021-01-04T14:01:02: PM2 log: App [npm:0] starting in -fork mode-
New one should have an output similar to:
[s6-init] making user provided files available at /var/run/s6/etc...exited 0.
[s6-init] ensuring user provided files have correct perms...exited 0.
[fix-attrs.d] applying ownership & permissions fixes...
[fix-attrs.d] done.
[cont-init.d] executing container initialization scripts...
[cont-init.d] socat.sh: executing...
[14:30:09] INFO: Socat not enabled, marking service as down
[cont-init.d] socat.sh: exited 0.
[cont-init.d] zigbee2mqtt.sh: executing...
[14:30:10] INFO: MQTT available, fetching server detail ...
[14:30:10] INFO: MQTT server settings not configured, trying to auto-discovering ...
[14:30:11] INFO: Configuring 'mqtt://core-mosquitto:1883' mqtt server
[14:30:11] INFO: MQTT credentials not configured, trying to auto-discovering ...
[14:30:11] INFO: Configuring'addons' mqtt user
[14:30:11] INFO: Previous config file found, checking backup
[14:30:11] INFO: Creating backup config in '/config/zigbee2mqtt/.configuration.yaml.bk'
[14:30:11] INFO: Adjusting Zigbee2mqtt core yaml config with add-on quirks ...
[cont-init.d] zigbee2mqtt.sh: exited 0.
[cont-init.d] done.
[services.d] starting services
[services.d] done.
[14:30:13] INFO: Handing over control to Zigbee2mqtt Core ...
><EMAIL_ADDRESS>start /app
> node index.js

You have rigt  there was wrong old repo . Also for start  new version from new repo i was force to remove  from config  line  zigbee_shepherd_devices: true

@dzaczek now it works? You might also have some socat config warning that you will have to fix.

@dzaczek now it works? You might also have some socat config warning that you will have to fix.

@dzaczek now it works? You might also have some socat config warning that you will have to fix.

Faced exactly same issue today and as well realised I'm using different repo (not sure if its old, or just parallel, cause there are new versions appearing as well).
Once migrated to new repo - yes it does work (with default config).
If I try to run it with custom devices.js file I'm getting the error:
"[18:30:34] INFO: File devices.js found, copying to ./node_modules/zigbee-herdsman-converters/
cp: can't create './node_modules/zigbee-herdsman-converters/devices.js': No such file or directory"
with default config respective line is:
"[18:31:21] WARNING: No devices.js file found in data path, starting with default devices.js"
Please kindly have a look

@dzaczek now it works? You might also have some socat config warning that you will have to fix.

Faced exactly same issue today and as well realised I'm using different repo (not sure if its old, or just parallel, cause there are new versions appearing as well).
Once migrated to new repo - yes it does work (with default config).
If I try to run it with custom devices.js file I'm getting the error:
"[18:30:34] INFO: File devices.js found, copying to ./node_modules/zigbee-herdsman-converters/
cp: can't create './node_modules/zigbee-herdsman-converters/devices.js': No such file or directory"
with default config respective line is:
"[18:31:21] WARNING: No devices.js file found in data path, starting with default devices.js"
Please kindly have a look

Did you use the steps here: https://github.com/zigbee2mqtt/hassio-zigbee2mqtt/blob/master/zigbee2mqtt/DOCS.md#not-recommended-using-devicesjs-override-in-add-on to get the right devices.js ?

Did you use the steps here: https://github.com/zigbee2mqtt/hassio-zigbee2mqtt/blob/master/zigbee2mqtt/DOCS.md#not-recommended-using-devicesjs-override-in-add-on to get the right devices.js ?

Did you use the steps here: https://github.com/zigbee2mqtt/hassio-zigbee2mqtt/blob/master/zigbee2mqtt/DOCS.md#not-recommended-using-devicesjs-override-in-add-on to get the right devices.js ?
Also recommended version to made mods is using https://github.com/zigbee2mqtt/hassio-zigbee2mqtt/blob/master/zigbee2mqtt/DOCS.md#using-external_converters

Yes and it's exactly how it's done in my case:
zigbee_shepherd_devices: true
And the file is in the shared folder.
Regarding the recommended way: for sure I can invest some time and rebuild my approach from the UnReclmmended way to the Recommended one, but devices.js did work just fine with <IP_ADDRESS> and doesn't work with 1.17 so mentioned it here.
Thanks

Did you use the steps here: https://github.com/zigbee2mqtt/hassio-zigbee2mqtt/blob/master/zigbee2mqtt/DOCS.md#not-recommended-using-devicesjs-override-in-add-on to get the right devices.js ?
Also recommended version to made mods is using https://github.com/zigbee2mqtt/hassio-zigbee2mqtt/blob/master/zigbee2mqtt/DOCS.md#using-external_converters

Yes and it's exactly how it's done in my case:
zigbee_shepherd_devices: true
And the file is in the shared folder.
Regarding the recommended way: for sure I can invest some time and rebuild my approach from the UnReclmmended way to the Recommended one, but devices.js did work just fine with <IP_ADDRESS> and doesn't work with 1.17 so mentioned it here.
Thanks

@Snakesms sometimes devices.js changes structure inbetween versions, that's why you have to make sure it's the right one.
You can see here the differences between <IP_ADDRESS> and 1.17.0: https://github.com/Koenkk/zigbee-herdsman-converters/compare/v13.0.7...v14.0.3 for the devices.js if you search in the list

@Snakesms sometimes devices.js changes structure inbetween versions, that's why you have to make sure it's the right one.
You can see here the differences between <IP_ADDRESS> and 1.17.0: https://github.com/Koenkk/zigbee-herdsman-converters/compare/v13.0.7...v14.0.3 for the devices.js if you search in the list

Hmm... I experienced the same error like described above. This somehow happened, after I switched the channel without thinking that I would have to repair everything again. But okay, re-pairing was less effort compared to reverting everything without getting to a better connection on the new channel.
Then I got to this thread and learned that a new repository should be used. Just today I got an update announcement to 17.x - but from the old repository. So, which is the right one to use?
Then I shrugged my shoulders and removed the old addon, changed the repo URL and installed the new one. Now all 17 devices, I newly paired yesterday, are simply gone - again. Okay, so the removal of the addon deleted the entity database as well. So I paired all devices - again. Now it's working fine (even better, because the device icons got updated as well) and the next full snapshot followed instantly - and auto updates are disabled.
I'm somehow lost. What did I do wrong and where should I have seen what I could have done better? :(

Hmm... I experienced the same error like described above. This somehow happened, after I switched the channel without thinking that I would have to repair everything again. But okay, re-pairing was less effort compared to reverting everything without getting to a better connection on the new channel.
Then I got to this thread and learned that a new repository should be used. Just today I got an update announcement to 17.x - but from the old repository. So, which is the right one to use?
Then I shrugged my shoulders and removed the old addon, changed the repo URL and installed the new one. Now all 17 devices, I newly paired yesterday, are simply gone - again. Okay, so the removal of the addon deleted the entity database as well. So I paired all devices - again. Now it's working fine (even better, because the device icons got updated as well) and the next full snapshot followed instantly - and auto updates are disabled.
I'm somehow lost. What did I do wrong and where should I have seen what I could have done better? :(

Right,  finally now have this working.  Started with adding the MQTT server settings and login creds to the config file, then had to copy the devices.yaml and the database.db from the $/share/zigbee2mqtt to the new $/config/zigbee2mqtt directory structures.  That took some time to realise it was needed, as although I could get the plug-in to start with the MQTT credentials, there was nothing there - and I wasn't looking forward to re-adding thirty + devices!  Oh - setting the logging level to debug was what revealed the initial steps I needed to complete.
Anyway, seems OK now.

Right,  finally now have this working.  Started with adding the MQTT server settings and login creds to the config file, then had to copy the devices.yaml and the database.db from the $/share/zigbee2mqtt to the new $/config/zigbee2mqtt directory structures.  That took some time to realise it was needed, as although I could get the plug-in to start with the MQTT credentials, there was nothing there - and I wasn't looking forward to re-adding thirty + devices!  Oh - setting the logging level to debug was what revealed the initial steps I needed to complete.
Anyway, seems OK now.

@Snakesms sometimes devices.js changes structure inbetween versions, that's why you have to make sure it's the right one.
You can see here the differences between <IP_ADDRESS> and 1.17.0<EMAIL_ADDRESS>for the devices.js if you search in the list
Based on your error and the file difference, I assume you didn't re-download the right devices.js as specified in the docs steps for 1.17.0 to re-modify.

Yes, you are right, I didn't apply modification on top of devices.js version 1.17 will try to do it tomorrow and try again. Thanks for your help

@Snakesms sometimes devices.js changes structure inbetween versions, that's why you have to make sure it's the right one.
You can see here the differences between <IP_ADDRESS> and 1.17.0<EMAIL_ADDRESS>for the devices.js if you search in the list
Based on your error and the file difference, I assume you didn't re-download the right devices.js as specified in the docs steps for 1.17.0 to re-modify.

Yes, you are right, I didn't apply modification on top of devices.js version 1.17 will try to do it tomorrow and try again. Thanks for your help


Update fork with upstream main

Reason for Change:
Updating this fork with upstream main

Requirements

[ ] squashed commits
[ ] included documentation
[ ] added unit tests and e2e tests (if applicable).

Issue Fixed:

Please answer the following questions with yes/no:
Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?

[ ] yes
[X] no

Notes for Reviewers:

Codecov Report
Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (1039167) 55.49% compared to head (4a978b6) 55.83%.
Report is 4 commits behind head on main.

Files
Patch %
Lines

pkg/webhook/webhook.go
75.00%
9 Missing and 3 partials :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1192      +/-   ##
==========================================
+ Coverage   55.49%   55.83%   +0.34%
==========================================
  Files          36       36
  Lines        2294     2339      +45
==========================================
+ Hits         1273     1306      +33
- Misses        980      989       +9
- Partials       41       44       +3

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


_emberWindowMock.default.location.href is not a function

Hi, I'm getting this error:
 _emberWindowMock.default.location.href is not a function. (In '_emberWindowMock.default.location.href(redirectUrl)', '_emberWindowMock.default.location.href

Ember 3.2, no fastboot.
window.location.replace() works fine...

Damn, I was being an idiot... closed


Update NPM version

Thanks for providing this package - it was exactly what I needed and worked seamlessly.
Would it be possible to update the NPM package with the latest version (which patches the vulnerability in @actions/core)?

Hey @cah-dunn! Thanks for the issue. I've just released 0.2.2 which contains this bump :slightly_smiling_face:

Great, thank you @daniellockyer


Description
Let me specify an output directory rather than always only ever exporting to .vercel/output/static/_worker.js.
Additional Information
No response
Would you like to help?

[ ] Would you like to help implement this feature?

I expect index.js to be inside whatever I set --outdir to.
e.g.
npx @cloudflare/next-on-pages --outdir=./dist
dist/
  index.js
  __next_on_pages_dist__/
    chunks/
      123.js

It should create the dist directory for me if it doesn't already exist. Not sure if it should error, wipe, or intermingle with dist if it already exists? We can look at what other tools do.

I would like to handle this one if it can be assigned to me. As discussed, I think it's valuable to put the full output in whatever the specified value for --outdir is.
For changing the _worker.js directory, which it seems like you are also interested in, I think it would be more valuable to add a flag along the lines of --workerdir. I can implement this too if you wish (and leave it undocumented for your own playing with).

I don't think I need --workerdir! I just wanted a way to generate the Worker pieces in some place that is well-known to me, that isn't the final .vercel/output/static dir, because I want to do some transformations first.
So just --outdir alone is going to be completely sufficient for me since I know that the Worker is always in ${outdir}/_worker.js/index.js. That's perfect. Thank you!


Create/delete notifications config/resources in operator

The argocd-notifications controller uses the argocd-notifications-cm configmap to manage notifications. The configmap contains the notification triggers configurations as well as the available notification templates. We will have some triggers/templates configured in the cm out of the box.
We agreed not to override cm.  During this phase, we are not managing the content in the cm. We only perform creation and deletion.
Acceptance criteria:
unit tests
these resources are created when notifications is enabled and deleted when notifications is disabled.
argocd-notifications-cm
argocd-notifications-secret

can be closed?