fail with status 500: CUDA error: no kernel image is available for execution on the device

Hi,
I try to reproduce step 2 of the semantic search through wikipedia on my local computer with RTX 3090, and while importing data with the nohup python3 -u import.py &  command I got the following error message:
2022-10-10 16:20:59.925 | INFO     | __main__:import_data_without_crefs:195 - Imported (1490 / 215) – Islamic world with # of paragraphs 7
2022-10-10 16:20:59.925 | INFO     | __main__:import_data_without_crefs:195 - Imported (1491 / 215) – Islamic world with # of paragraphs 7
2022-10-10 16:20:59.925 | INFO     | __main__:import_data_without_crefs:195 - Imported (1492 / 215) – Islamic world with # of paragraphs 7
2022-10-10 16:20:59.925 | INFO     | __main__:import_data_without_crefs:195 - Imported (1493 / 215) – Islamic world with # of paragraphs 7
2022-10-10 16:20:59.925 | INFO     | __main__:import_data_without_crefs:195 - Imported (1494 / 215) – Islamic world with # of paragraphs 7
2022-10-10 16:20:59.925 | INFO     | __main__:import_data_without_crefs:195 - Imported (1495 / 215) – Islamic world with # of paragraphs 7
2022-10-10 16:20:59.926 | INFO     | __main__:import_data_without_crefs:195 - Imported (1497 / 216) – Multiverse with # of paragraphs 4
2022-10-10 16:20:59.926 | INFO     | __main__:import_data_without_crefs:195 - Imported (1498 / 216) – Multiverse with # of paragraphs 4
2022-10-10 16:20:59.926 | INFO     | __main__:import_data_without_crefs:195 - Imported (1499 / 216) – Multiverse with # of paragraphs 4
2022-10-10 16:21:00.482 | DEBUG    | __main__:handle_results:169 - fail with status 500: CUDA error: no kernel image is available for execution on the device
CUDA kernel errors might be asynchronously reported at some other API call,so the stacktrace below might be incorrect.
For debugging consider passing CUDA_LAUNCH_BLOCKING=1.
2022-10-10 16:21:00.482 | DEBUG    | __main__:handle_results:169 - fail with status 500: CUDA error: no kernel image is available for execution on the device
CUDA kernel errors might be asynchronously reported at some other API call,so the stacktrace below might be incorrect.
For debugging consider passing CUDA_LAUNCH_BLOCKING=1.
2022-10-10 16:21:00.482 | DEBUG    | __main__:handle_results:169 - fail with status 500: CUDA error: no kernel image is available for execution on the device
CUDA kernel errors might be asynchronously reported at some other API call,so the stacktrace below might be incorrect.
For debugging consider passing CUDA_LAUNCH_BLOCKING=1.
2022-10-10 16:21:00.482 | DEBUG    | __main__:handle_results:169 - fail with status 500: CUDA error: no kernel image is available for execution on the device
CUDA kernel errors might be asynchronously reported at some other API call,so the stacktrace below might be incorrect.
For debugging consider passing CUDA_LAUNCH_BLOCKING=1.
2022-10-10 16:21:00.482 | DEBUG    | __main__:handle_results:169 - fail with status 500: CUDA error: no kernel image is available for execution on the device
CUDA kernel errors might be asynchronously reported at some other API call,so the stacktrace below might be incorrect.
For debugging consider passing CUDA_LAUNCH_BLOCKING=1.
2022-10-10 16:21:00.482 | DEBUG    | __main__:handle_results:169 - fail with status 500: CUDA error: no kernel image is available for execution on the device
CUDA kernel errors might be asynchronously reported at some other API call,so the stacktrace below might be incorrect.
For debugging consider passing CUDA_LAUNCH_BLOCKING=1.
2022-10-10 16:21:00.482 | DEBUG    | __main__:handle_results:169 - fail with status 500: CUDA error: no kernel image is available for execution on the device
CUDA kernel errors might be asynchronously reported at some other API call,so the stacktrace below might be incorrect.
For debugging consider passing CUDA_LAUNCH_BLOCKING=1.
2022-10-10 16:21:00.482 | DEBUG    | __main__:handle_results:169 - fail with status 500: CUDA error: no kernel image is available for execution on the device
CUDA kernel errors might be asynchronously reported at some other API call,so the stacktrace below might be incorrect.
For debugging consider passing CUDA_LAUNCH_BLOCKING=1.

I follow the guidelines provided at https://weaviate.io/developers/weaviate/current/tutorials/semantic-search-through-wikipedia.html#step-2-import-the-dataset-and-vectorize-the-content and set the following files to work on local computer:
1 / docker-compose.yml:
---
version: '3.4'
services:
  weaviate:
    command:
    - --host
    - <IP_ADDRESS>
    - --port
    - '8080'
    - --scheme
    - http
    image: semitechnologies/weaviate:1.15.3
    ports:
    - 8080:8080
    restart: on-failure:0
    volumes:
      - /media/matthieu/HDD_4T01/weaviate:/var/lib/weaviate
      # - /home/matthieu/weaviate:/var/lib/weaviate
    depends_on:
      - loadbalancer
    environment:
      TRANSFORMERS_INFERENCE_API: 'http://loadbalancer:8080'
      QUERY_DEFAULTS_LIMIT: 25
      AUTHENTICATION_ANONYMOUS_ACCESS_ENABLED: 'true'
      PERSISTENCE_DATA_PATH: '/var/lib/weaviate'
      DEFAULT_VECTORIZER_MODULE: 'text2vec-transformers'
      ENABLE_MODULES: 'text2vec-transformers'
      # ENABLE_MODULES: ''
      CLUSTER_HOSTNAME: 'node1'
  ##
  # Load in all GPUs
  ##
  loadbalancer:
    image: nginx
    volumes:
      - ./nginx.conf:/etc/nginx/nginx.conf
    depends_on:
      - t2v-transformers-01-001
      - t2v-transformers-01-002
      - t2v-transformers-01-003
      - t2v-transformers-01-004
      - t2v-transformers-01-005
      - t2v-transformers-01-006
      - t2v-transformers-01-007
      - t2v-transformers-01-008
      - t2v-transformers-01-009
      - t2v-transformers-01-010
      - t2v-transformers-01-011
      - t2v-transformers-01-012

  t2v-transformers-01-001:
    image: semitechnologies/transformers-inference:sentence-transformers-multi-qa-MiniLM-L6-cos-v1
    restart: always
    environment:
      ENABLE_CUDA: '1'
      NVIDIA_VISIBLE_DEVICES: '0' # <== set the GPU to use. 0 = 1st GPU, 1 = 2nd, etc
    deploy:
      resources:
        reservations:
          devices:
          - capabilities:
            - 'gpu'
  t2v-transformers-01-002:
    image: semitechnologies/transformers-inference:sentence-transformers-multi-qa-MiniLM-L6-cos-v1
    restart: always
    environment:
      ENABLE_CUDA: '1'
      NVIDIA_VISIBLE_DEVICES: '0'
    deploy:
      resources:
        reservations:
          devices:
          - capabilities:
            - 'gpu'
  t2v-transformers-01-003:
    image: semitechnologies/transformers-inference:sentence-transformers-multi-qa-MiniLM-L6-cos-v1
    restart: always
    environment:
      ENABLE_CUDA: '1'
      NVIDIA_VISIBLE_DEVICES: '0'
    deploy:
      resources:
        reservations:
          devices:
          - capabilities:
            - 'gpu'
  t2v-transformers-01-004:
    image: semitechnologies/transformers-inference:sentence-transformers-multi-qa-MiniLM-L6-cos-v1
    restart: always
    environment:
      ENABLE_CUDA: '1'
      NVIDIA_VISIBLE_DEVICES: '0'
    deploy:
      resources:
        reservations:
          devices:
          - capabilities:
            - 'gpu'
  t2v-transformers-01-005:
    image: semitechnologies/transformers-inference:sentence-transformers-multi-qa-MiniLM-L6-cos-v1
    restart: always
    environment:
      ENABLE_CUDA: '1'
      NVIDIA_VISIBLE_DEVICES: '0'
    deploy:
      resources:
        reservations:
          devices:
          - capabilities:
            - 'gpu'
  t2v-transformers-01-006:
    image: semitechnologies/transformers-inference:sentence-transformers-multi-qa-MiniLM-L6-cos-v1
    restart: always
    environment:
      ENABLE_CUDA: '1'
      NVIDIA_VISIBLE_DEVICES: '0'
    deploy:
      resources:
        reservations:
          devices:
          - capabilities:
            - 'gpu'
  t2v-transformers-01-007:
    image: semitechnologies/transformers-inference:sentence-transformers-multi-qa-MiniLM-L6-cos-v1
    restart: always
    environment:
      ENABLE_CUDA: '1'
      NVIDIA_VISIBLE_DEVICES: '0'
    deploy:
      resources:
        reservations:
          devices:
          - capabilities:
            - 'gpu'
  t2v-transformers-01-008:
    image: semitechnologies/transformers-inference:sentence-transformers-multi-qa-MiniLM-L6-cos-v1
    restart: always
    environment:
      ENABLE_CUDA: '1'
      NVIDIA_VISIBLE_DEVICES: '0'
    deploy:
      resources:
        reservations:
          devices:
          - capabilities:
            - 'gpu'
  t2v-transformers-01-009:
    image: semitechnologies/transformers-inference:sentence-transformers-multi-qa-MiniLM-L6-cos-v1
    restart: always
    environment:
      ENABLE_CUDA: '1'
      NVIDIA_VISIBLE_DEVICES: '0'
    deploy:
      resources:
        reservations:
          devices:
          - capabilities:
            - 'gpu'
  t2v-transformers-01-010:
    image: semitechnologies/transformers-inference:sentence-transformers-multi-qa-MiniLM-L6-cos-v1
    restart: always
    environment:
      ENABLE_CUDA: '1'
      NVIDIA_VISIBLE_DEVICES: '0'
    deploy:
      resources:
        reservations:
          devices:
          - capabilities:
            - 'gpu'
  t2v-transformers-01-011:
    image: semitechnologies/transformers-inference:sentence-transformers-multi-qa-MiniLM-L6-cos-v1
    restart: always
    environment:
      ENABLE_CUDA: '1'
      NVIDIA_VISIBLE_DEVICES: '0'
    deploy:
      resources:
        reservations:
          devices:
          - capabilities:
            - 'gpu'
  t2v-transformers-01-012:
    image: semitechnologies/transformers-inference:sentence-transformers-multi-qa-MiniLM-L6-cos-v1
    restart: always
    environment:
      ENABLE_CUDA: '1'
      NVIDIA_VISIBLE_DEVICES: 'all'
    deploy:
      resources:
        reservations:
          devices:
          - capabilities:
            - 'gpu'
...

2 / nginx.conf:
user  nginx;
worker_processes  1;
error_log  /var/log/nginx/error.log warn;
pid        /var/run/nginx.pid;

events {
    worker_connections  1024;
}

http {
    upstream modules {
        least_conn;
        server t2v-transformers-01-001:8080;
        server t2v-transformers-01-002:8080;
        server t2v-transformers-01-003:8080;
        server t2v-transformers-01-004:8080;
        server t2v-transformers-01-005:8080;
        server t2v-transformers-01-006:8080;
        server t2v-transformers-01-007:8080;
        server t2v-transformers-01-008:8080;
        server t2v-transformers-01-009:8080;
        server t2v-transformers-01-010:8080;
        server t2v-transformers-01-011:8080;
        server t2v-transformers-01-012:8080;
    }

    include                 /etc/nginx/mime.types;
    default_type            application/octet-stream;
    keepalive_timeout       65;
    client_body_buffer_size 128M;
    client_max_body_size    128M;

    server {
        listen 8080 default_server;
        listen [::]:8080 default_server;
        location / {
            proxy_set_header                    Host $http_host;
            proxy_set_header                    X-Url-Scheme $scheme;
            proxy_set_header                    X-Real-IP $remote_addr;
            proxy_set_header                    X-Forwarded-For $proxy_add_x_forwarded_for;
            proxy_pass                          http://modules;
            proxy_buffering                     off;
            proxy_read_timeout                  3600;
            proxy_redirect                      off;
        }
    }
}

My GPU card is well configured with CUDA 11.6 and cuDNN and the following command nvidia-smi returns:
Mon Oct 10 16:39:30 2022
+-----------------------------------------------------------------------------+
| NVIDIA-SMI 510.39.01    Driver Version: 510.39.01    CUDA Version: 11.6     |
|-------------------------------+----------------------+----------------------+
| GPU  Name        Persistence-M| Bus-Id        Disp.A | Volatile Uncorr. ECC |
| Fan  Temp  Perf  Pwr:Usage/Cap|         Memory-Usage | GPU-Util  Compute M. |
|                               |                      |               MIG M. |
|===============================+======================+======================|
|   0  NVIDIA GeForce ...  On   | 00000000:21:00.0  On |                  N/A |
|  0%   55C    P8    54W / 390W |   1272MiB / 24576MiB |      5%      Default |
|                               |                      |                  N/A |
+-------------------------------+----------------------+----------------------+

+-----------------------------------------------------------------------------+
| Processes:                                                                  |
|  GPU   GI   CI        PID   Type   Process name                  GPU Memory |
|        ID   ID                                                   Usage      |
|=============================================================================|
|    0   N/A  N/A      2389      G   /usr/lib/xorg/Xorg                 38MiB |
|    0   N/A  N/A      2935      G   /usr/bin/gnome-shell              118MiB |
|    0   N/A  N/A      9316      G   /usr/lib/xorg/Xorg                423MiB |
|    0   N/A  N/A      9462      G   /usr/bin/gnome-shell              116MiB |
|    0   N/A  N/A     10657      G   ...veSuggestionsOnlyOnDemand       71MiB |
|    0   N/A  N/A     12204      G   ...rbird/259/thunderbird-bin      178MiB |
|    0   N/A  N/A     18483      G   ...AAAAAAAAA= --shared-files       47MiB |
|    0   N/A  N/A     22141      G   ...142126277284136387,131072      203MiB |
|    0   N/A  N/A     68713      G   ...RendererForSitePerProcess       68MiB |
+-----------------------------------------------------------------------------+

Hi @bobvanluijt thanks for your feedback!
Even if I reduce the number of models loaded onto the GPU to 2, I got both errors regularly when importing:
2022-10-17 14:03:59.222 | DEBUG    | __main__:handle_results:169 - fail with status 500: CUDA error: no kernel image is available for execution on the device
CUDA kernel errors might be asynchronously reported at some other API call,so the stacktrace below might be incorrect.
For debugging consider passing CUDA_LAUNCH_BLOCKING=1.
2022-10-17 14:03:59.222 | DEBUG    | __main__:handle_results:169 - send POST request: Post "http://loadbalancer:8080/vectors": read tcp <IP_ADDRESS>:39354-><IP_ADDRESS>:8080: read: connection reset by peer

Hmm - interesting. @antas-marcin does this issue ring a bell?


Add more test cases

Add more test cases and in particular:

test the behavior of Id conversion with more deep arrays
test the cases of id or boolean (upper, lower, studly etc)
test more complex XML documents

Close via #8


Fix broken init subclass override

Codecov Report

Merging #15 (bd60f93) into main (a925644) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #15   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            4         4
  Lines          157       159    +2
=========================================
+ Hits           157       159    +2

Impacted Files
Coverage Δ

abcattrs/abcattrs.py
100.00% <ø> (ø)

abcattrs/__init__.py
100.00% <100.00%> (ø)

tests/test_decorator.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a925644...bd60f93. Read the comment docs.


:memo: a little hint added for 'Building from source for linux'

script/build has the shebang #!/usr/bin/env node. On some system this command is no available but nodejs (e.g. on debian).
The softlink fixes this problem, and all the other steps work fine.

Thanks!

@vpeil @kevinsawicki I don't think we should recommend users to modify things in /usr directly or outside of the package manager.
The correct solution to this would be (on debian):
sudo update-alternatives --install /usr/bin/node node /usr/bin/nodejs 10

@mehcode sounds good, thanks for the tip.

@mehcode Just pushed that change up :+1:

@mehcode thanks for the tip.
and thanks to the whole team for this awesome editor.


[WIP] Plugins & Extensions

Fixes #243 , #171, #134, #101

Let me know once you're done and this is no longer WIP and I'll be happy to review it.

@vanniktech @Mauin

With the current design the user can generate multiple output reports at once eg. plain and xml + custom formats. This will change --output to be a directory rather a path to a single file.  The --output-format will disappear and excluding formats can be done via configuration. What do you think of this design? This will imply if the user runs detekt in cli without specifying a configuration, both 'default' output reports (xml, plain) get printed if --output is set.

The default unspecified config is Config.empty should we change it to the default config provided by detekt? It is the same as --generate-config?

printed to the console or to a file? I like that you'll get plain + xml formats.
Yes that would be a first step. Maybe even failFast as a default. (Although maybe I'm too opinionated there)

To a file. OutputReport handles file outputs and ConsoleReport handles console output.

Btw the console output is now modularized. You can turn on and off different parts of the output which gets printed in M13. It is possible to turn off default findings printing and provide your own ConsoleReport which will do this.

If we use failFast as default then it is like having no configuration :)

I think this baby is ready to get merged :D
Should the --rules parameter which is now --plugins maybe renamed to --extensions?

Hmm dunno, what name describes it better?

Both names are good :D but there is now a common interface Extension ...

Hmm then let your gut decide.


Automated cherry pick of #3994: fix: 避免每次重启region同步rds sku, 避免新加公有云账号未能及时同步sku问题

Cherry pick of #3994 on release/2.12.
#3994: fix: 避免每次重启region同步rds sku, 避免新加公有云账号未能及时同步sku问题

Codecov Report

:exclamation: No coverage uploaded for pull request base (release/2.12@6bf4b4f). Click here to learn what that means.
The diff coverage is 0%.

@@              Coverage Diff               @@
##             release/2.12   #3996   +/-   ##
==============================================
  Coverage                ?    6.9%
==============================================
  Files                   ?     501
  Lines                   ?   84647
  Branches                ?       0
==============================================
  Hits                    ?    5848
  Misses                  ?   78304
  Partials                ?     495

Flag
Coverage Δ

#aFlag
6.9% <0%> (?)

Impacted Files
Coverage Δ

pkg/compute/models/cloudsync.go
0% <0%> (ø)

pkg/compute/models/dbinstance_skus.go
4.04% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bf4b4f...21bc1cc. Read the comment docs.

/lgtm

/approve


Floor Filter - Two close buttons can appear

The Swift Samples app uses the Floor Filter component with data that appears to cause two close buttons to appear.

The problem appears to be that both FacilitiesList and its parent (SitesList) have a modifier for the close button. It should only be on one of them.


completed UI and rendered project kanban board

Completed UI
Rendered Project Board and Specifics Cards
To test generate github personal auth and replace token variable from -> https://docs.github.com/en/authentication/keeping-your-account-and-data-secure/creating-a-personal-access-token

Note!
Please don't merge yet there's still a lot of missing pieces, just saving my progress here

Hi @ardeay, roadmap completed and ready for your review,


this form shows ugly border around bottom buttons, not nice

Xubuntu 20

Button appearance will change with the application theme. This looks like the Greybird theme. Have you tried others?

i talk about Lazarus TPanel border. which is around all bottom buttons.

Again, I think 'ugly' is in the eye of the beholder, I believe its looks OK. The difference is just a setting of TPanel, Alexey, you can set TPanel to a number of different looks, maybe you need to experiment with some of them ?
Again, its a way to draw the user's eye.
Davo


Add a settings menu to the plugin

I propose adding a settings menu to the FSLeyes GUI.
In this menu, the user could:

Change some values that were previously hardcoded (exemple: https://github.com/neuropoly/axondeepseg/issues/451)
Change the suffix we look for when loading a mask. Currently, we only support loading masks that contain both axon and myelin in the image. A given suffix would determine if a certain image contains only axon or myelin.
Determine if we use the ellipse or circle for computing morphometrics
Check the pixel size of the selected image

Feel free to add any other suggestions

We may need to have a pixel size field and be able to change the value between segmentation and morphometrics. See comment here.

I think we should likely just have one true pixel size value for the user to input, and then another "zoom" parameter for the segmentation patch step? Morphometrics will always use the true pixel size value, and the zoom factor * pixel size would be used in the segmentation stage. Thoughts?

That's a good idea, I like it! Only one true pixel size is less confusing, will avoid errors and is compatible with having a pixel_in_micrometer.txt file as well. Thanks @mathieuboudreau!

I started working the settings menu. Here's what it looks like so far:

maybe next to "overlap value" you can add "(%)"

and i would replace "axon shape" by "axon shape approximation"

also, would it be possible to have all buttons with the same size? it would look more professional

also, would it be possible to have all buttons with the same size? it would look more professional

I will explore what options are available. Also, they don't have this appearance on macOS.

maybe next to "overlap value" you can add "(%)"

the overlap value is in "(pixels)"

maybe next to "overlap value" you can add "(%)"

the overlap value is in "(pixels)"

ah! so that's a good reason for specifying "pixel" then 😉  (otherwise users might think it is in %)

also, would it be possible to have all buttons with the same size? it would look more professional

I will explore what options are available. Also, they don't have this appearance on macOS.

could be ported to another issue if we want to fix the other things quicker (this is not priority)

Hi @Stoyan-I-A!
I think there may be a misunderstanding between model resolution, pixel size and zoom factor.
In the last meeting, we decided to integrate the peripheral nerves model as a new “default” model in ADS. This was done by Vasudev in PR #457. It includes a hardcoding of the model resolution of 0.1 here.
This means that for now, we do not want to include the custom model resolution option in FSLeyes (#334) or CLI (#428), but only add a third default model option.
As a priority for Simeon, we need to be able to select the overlap_value and a zoom factor (see comment above) to apply to the pixel size.
The idea is:

There is only 1 true pixel size (either in the txt file or set by the use in FSLeyes). This pixel size is the real pixel size of the image and must be used to compute morphometrics.
A second parameter zoom factor can be applied to multiply the pixel size to improve the results of the segmentation only (not applied to morphometrics).
The model resolution always remains the same and should be hardcoded at 0.1.

Example:
pixel size = 0.1
zoom factor = 0.8
pixel size applied for segmentation = pixel size * zoom factor = 0.1 * 0.8 = 0.08
pixel size applied for morphometrics = 0.1

Let me know if that makes sense, or if you want to chat about this.

Alright, here's the updated one as of 2021-03-06:


Improve naming of tests

All unit tests should be wrapped in a describe stating the file the test is handling.
Example: onDelegation › submitDelegation › redelegation › unit › error  is missing PageValidator. I would have assumed this handles the module delegation.

Huh, so Jest doesn't report the name of the file automatically?  That's disappointing.

Well it does:

But I think it is more readable if the tests itself already tell you what you are seeing. This is especially usefully if a lot of tests fail.


NotificationsManager crashes since it still uses GCM

NotificationsManager needs to be updated since internally it still uses the GoogleCloudMessaging class!!!
Opened issue https://github.com/MicrosoftDocs/azure-docs/issues/24212

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: affa806e-ed31-20b7-9aee-2b56572225ab
Version Independent ID: 5dea14a7-065e-c21b-712c-0cee7d3ffb16
Content: Push notifications to Android apps using Azure Notification Hubs and Firebase Cloud Messaging
Content Source: articles/notification-hubs/notification-hubs-android-push-notification-google-fcm-get-started.md
Service: notification-hubs
GitHub Login: @jwargo
Microsoft Alias: jowargo

@AjayKumar-MSFT Close this please, there's no reason to keep two open on the same topic.


off by one error

Fixes #15279
There were several instances of this logic bug in the example. All were updated the same way.
Summary
Describe your changes here.
Fixes #Issue_Number (if available)

I think there is no need for the curly braces at the first and last lines of this snippet ?


How to set up the "from" page

You give a rough description of how t create the page you drill through to page, but it's not clear to the busy consumer, what to do on the drill through from page.

Hi @cool-Blue - could you include the page you're asking about, so we can investigate? Thanks.


Resource Not found

Hi,
I'm using your powershell scripts and i get an error when launching it
Invoke-RestMethod : {"error":{"code":"ResourceNotFound","message":"The Resource 'Microsoft.ContainerService/managedClusters/aks-eoltoppool0-33389392-vmss' under resource group 'MC_eolementhe-top-resource-group_eolementhe-top-kubernetes-cluster_westeurope' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix"}} At line:19 char:9 + Invoke-RestMethod -Method Post -Uri $URI -ContentType "applic ... + ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ + CategoryInfo : InvalidOperation: (System.Net.HttpWebRequest:HttpWebRequest) [Invoke-RestMethod], WebException + FullyQualifiedErrorId : WebCmdletWebResponseException,Microsoft.PowerShell.Commands.InvokeRestMethodCommand
I did double check name resource group and subscription and everything seems to be ok.
Reading the web, it might be related to TLS issue (https://blogs.inframon.com/2018/03/forcing-tls1-2-when-using-azure-hybrid-runbook-workers/) . Do you think this may be related ? i did try without success
Have you experienced such an error using runbooks ?
thanks a lot for this great script

I think you've got the input parameters wrong, those look like the cluster's underlying VMSS. You want the name and RG of the cluster resource itself, eg my-cluster in k8s-clusters.


Revamp

Add rainbow "4w55" and Robot Mono font.

@SpeeedyAtGithub Review pls

Pog

E

What now

re-open it


GAIA DR3 radial velocities ingest

Closes #249

To address unicode issue, try using the normalize function in the ingest_sources function in ingest_utils
from unicodedata import normalize
and then on line 95, add
source = normalize('NFKD', source)
I don't have your XML file so I cant test it.

@kelle I thought this ingest was done, is there a reason that it was never merged? I am assuming it may have had something to do with the JSON files, so it was labeled as low priority.

I will try to finish this up.

Scripts added in #475 and new issue for Gaia radial velocities: #476


chore(travi.yml): Improve travis CI

Coverage remained the same at 90.09% when pulling 5fe62c5f3fa2252e11db4eab49bee3b66e2b6a58 on chore/travis into 6b594274c29d4a07df4d053c6c1089b7a2ccae7a on master.


Better messages when client errors

Slightly improves the error messages
I currently assume that any stack trace involving UT is probably UT's fault.  I can't think of a reason that wouldn't be true.
Regardless of whether UT is involved, posts the full stack trace, not just the text parameter of the exception.

While I agree with both of these, keep in mind that all I'm doing is overriding the contents of this box:

I'm not quite sure how much I can push the popup without breaking AP's expectations, nor am I confident enough with kivy to do so.


ingesting non-UTF-8 characters causes /kapacitor/v1/debug/vars to fail [Port to 1.8]

https://github.com/influxdata/influxdb/issues/21557
Port to 1.8 if there is a 1.8.7

No more 1.8 releases


fix: category filter not working

https://dev.azure.com/plentymarkets/plentymarkets/_workitems/edit/78578/

https://github.com/plentymarkets/plentyshop-pwa/pull/178


Adding meta and correct response types into upgrade-risks-prediction endpoint

Description
Update the upgrade-risks-prediction endpoint to match with current Smart Proxy implementation
Type of change

Bug fix (non-breaking change which fixes an issue)

Testing steps
Tested locally
Checklist

[ ] make before_commit passes
[ ] updated documentation wherever necessary
[ ] added or modified tests if necessary
[ ] updated schemas and validators in insights-data-schemas in case of input/output change

Codecov Report
Base: 5.79% // Head: 5.68% // Decreases project coverage by -0.11% :warning:

Coverage data is based on head (145849d) compared to base (622f0dd).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##           master    #370      +/-   ##
=========================================
- Coverage    5.79%   5.68%   -0.11%
=========================================
  Files          16      16
  Lines         846     862      +16
=========================================
  Hits           49      49
- Misses        797     813      +16

Impacted Files
Coverage Δ

server/upgrade_risks_prediction.go
0.00% <0.00%> (ø)

storage/storage.go
0.94% <0.00%> (-0.05%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

So the last checked at attribute is not set by the original source of data? Is not it weird?

What do you mean @tisnik ? Do you think that it should be defined in the storage part instead of in the server endpoint request handler?

outdated


Support additional Refaster features seen in error-prone-support

What problem are you trying to solve?
Expand the set of Refaster rules in Error Prone Support that we cover with OpenRewrite recipes.
Describe the solution you'd like
Support the following cases not currently covered.

[ ] Generics as seen in ImmutableSortedMapRules.java
[ ] com.google.errorprone.refaster.Refaster as seen in EqualityRules.java

#21

[ ] @UseImportPolicy as seen in MockitoRules.java
[ ] @Placeholder as seen in LongStreamRules.java
[ ] @AlsoNegation as seen in BigDecimalRules.java
[ ] @DoNotCall as seen in TestNGToAssertJRules.java
[ ] @Repeated as seen in WebClientRules.java
[ ] @Matches as seen in ReactorRules.java

Hey @timtebeek! The @DoNotCall annotation has no impact for Refaster; it's there only to appease the DoNotCall check :)

Hey @timtebeek! The @DoNotCall annotation has no impact for Refaster; it's there only to appease the DoNotCall check :)

Thanks for that context! Right now we skip any rules where that annotation is present, but it seems like we can tolerate the presence of that annotation and just generate the recipes in those cases. Good to know!

Even if we ignore the presence of @UseImportOlicy annotation it seems we still have some work to do before recipe correctly compile, as we don't yet add resolve and imports explicitly. Internally we had relied on after templates always using fully qualified refs, but we can't expect that going forward.

@timtebeek I think we can. I thought the template code is already being generated with all fully qualified references (regardless if the input uses qualified references or not). That was in any case the idea.

@timtebeek I think we can. I thought the template code is already being generated with all fully qualified references (regardless if the input uses qualified references or not). That was in any case the idea.

Exploring the addition of new static imports now in this PR; based on what we do versus need (https://github.com/openrewrite/rewrite-templating/pull/53/commits/d1ce2f70a67ae270d6778ca439102d4d0ddb2a41) it looks like we have some work to do still.

https://github.com/openrewrite/rewrite-templating/pull/53

Some quick stats on why various refaster rules were excluded, such that we know what to cover next:
[INFO] 791x Generics are currently not supported
[INFO] 40x com.google.errorprone.refaster.Refaster is currently not supported
[INFO] 19x @AlsoNegation is currently not supported
[INFO] 15x @Placeholder is currently not supported
[INFO] 8x If statements are currently not supported
[INFO] 1x @Matches is currently not supported

Basic generics support is available. Not yet for gwneric type variables, however.

With Knut's support for generics and a very minor new exclusion, these are the new stats with regards to what's supported/skipped:

https://github.com/openrewrite/rewrite-templating/pull/72

[INFO] @Matches is currently not supported=1
[INFO] @Repeated is currently not supported=1
[INFO] Method references are currently not supported=1
[INFO] Lambdas are currently not supported=2
[INFO] If statements are currently not supported=8
[INFO] @AlsoNegation is currently not supported=11
[INFO] @Placeholder is currently not supported=15
[INFO] com.google.errorprone.refaster.Refaster is currently not supported=75
[INFO] Generic type parameters are currently not supported=495

As discussed yesterday with @rickie we might want to detect any use of OnlineDocumentation, and if present add a link to that URL in the documentation that we generate, both to give credit and additional context to what a recipe would effectively do.
https://github.com/PicnicSupermarket/error-prone-support/blob/8f64489fa0dded9255d20c227d0810af1cf52493/refaster-support/src/main/java/tech/picnic/errorprone/refaster/annotation/OnlineDocumentation.java#L44-L48
We already parse any JavaDoc that's present (even if it's often missing); we might want to expand (or generate) the Javadocs present in Error Prone Support to improve how those are presented to our users.

About the @OnlineDocumentation, it has default values that are used by Picnic. However, others can use the annotation to link to their own website if they have one. So supporting the annotation will not be a "Picnic-specific" solution.

We can also already generate templates for any rules that use @AlsoNegation, without generating that negation just yet. Adding that negated recipe can then be left as a next step.


Add missing screenshot tests for material

WHAT
WHY
HOW
Checklist :clipboard:

[ ] Add explicit visibility modifier and explicit return types for public declarations
[ ] Run spotless check
[ ] Run tests
[ ] Update metalava's signature text files

landing as reenabling tests only


Suggestion: DocC on Github Pages

Apple has made it possible to generate DocC into a page that can be hosted on Github Pages. Would be great to see the docs for this package on the web.
Reference: https://apple.github.io/swift-docc-plugin/documentation/swiftdoccplugin/publishing-to-github-pages/

@emma-k-alexandra ... that is a really great idea! I think we should do it.


ImportError: No module named pgoapi.exceptions

HEy there,
I initially wanted to setup everything. I chose the setup.sh method. But i get an error:
Traceback (most recent call last):
File "pokecli.py", line 38, in
from pgoapi.exceptions import NotLoggedInException, ServerSideRequestThrottlingException, ServerBusyOrOfflineException
ImportError: No module named pgoapi.exceptions
Fr 12. Aug 13:48:32 CEST 2016 Pokebot  Stopped.
Press any button or wait 20 seconds to continue.

https://github.com/PokemonGoF/PokemonGo-Bot/blob/dev/docs/installation.md

@nivong that's not a solution
@medienoekonom having the same issue, can be two things:

The google login is slow/down
playtime is limited by Niantic to prevent overloads

http://www.mmoserverstatus.com/pokemon_go indicates that both could be the case

@JosUijterwaal ImportError: No module named pgoapi.exceptions is an incorrected installation...

@nivong apologies then!
where am I going wrong?
total 632
drwxr-xr-x  40 Jos  staff    1360 Aug 11 23:22 .
drwxr-xr-x+ 27 Jos  staff     918 Aug 12 11:13 ..
lrwxr-xr-x   1 Jos  staff      63 Aug 11 22:48 .Python -> /System/Library/Frameworks/Python.framework/Versions/2.7/Python
-rw-r--r--   1 Jos  staff      43 Aug 11 22:48 .dockerignore
drwxr-xr-x  14 Jos  staff     476 Aug 11 22:52 .git
drwxr-xr-x   4 Jos  staff     136 Aug 11 22:48 .github
-rw-r--r--   1 Jos  staff    1673 Aug 11 22:48 .gitignore
-rw-r--r--   1 Jos  staff      80 Aug 11 22:48 .gitmodules
-rw-r--r--   1 Jos  staff      34 Aug 11 22:48 .mention-bot
-rw-r--r--   1 Jos  staff     211 Aug 11 22:48 .pullapprove.yml
-rw-r--r--   1 Jos  staff      60 Aug 11 22:48 .pylintrc
-rw-r--r--   1 Jos  staff     112 Aug 11 22:48 .styles.yapf
-rw-r--r--   1 Jos  staff     288 Aug 11 22:48 .travis.yml
-rw-r--r--   1 Jos  staff     860 Aug 11 22:48 CONTRIBUTORS.md
-rw-r--r--   1 Jos  staff     735 Aug 11 22:48 Dockerfile
-rw-r--r--   1 Jos  staff    1081 Aug 11 22:48 LICENSE
-rw-r--r--   1 Jos  staff    3393 Aug 11 22:48 README.md
drwxr-xr-x  26 Jos  staff     884 Aug 11 22:49 bin
drwxr-xr-x   8 Jos  staff     272 Aug 12 11:13 configs
drwxr-xr-x   9 Jos  staff     306 Aug 11 23:22 data
-rw-r--r--   1 Jos  staff     510 Aug 11 22:48 docker-compose.yml
drwxr-xr-x  11 Jos  staff     374 Aug 11 22:48 docs
-rw-r--r--@  1 Jos  staff  209964 Aug 11 23:22 encrypt.so
drwxr-xr-x   4 Jos  staff     136 Aug 11 22:49 include
-rwxr-xr-x   1 Jos  staff    1807 Aug 11 22:48 install.sh
drwxr-xr-x   3 Jos  staff     102 Aug 11 22:48 lib
-rw-r--r--   1 Jos  staff      60 Aug 11 22:48 pip-selfcheck.json
-rw-r--r--   1 Jos  staff   16872 Aug 11 22:48 pokecli.py
drwxr-xr-x  41 Jos  staff    1394 Aug 11 23:00 pokemongo_bot
drwxr-xr-x   5 Jos  staff     170 Aug 11 22:48 proto
-rw-r--r--   1 Jos  staff    1596 Aug 11 22:48 pylint-recursive.py
-rw-r--r--   1 Jos  staff     482 Aug 11 22:48 requirements.txt
-rw-r--r--   1 Jos  staff     236 Aug 11 22:48 run.bat
-rwxr-xr-x   1 Jos  staff     440 Aug 11 22:48 run.sh
-rwxr-xr-x   1 Jos  staff    3174 Aug 11 22:48 setup.sh
drwxr-xr-x   3 Jos  staff     102 Aug 11 22:49 share
drwxr-xr-x   4 Jos  staff     136 Aug 11 22:49 src
drwxr-xr-x  10 Jos  staff     340 Aug 11 22:48 tests
drwxr-xr-x  20 Jos  staff     680 Aug 11 23:24 web
-rwxr-xr-x   1 Jos  staff     597 Aug 11 22:48 ws_server.py
SnappCars-MacBook-Pro-2:PokemonGo-Bot Jos$ sh run setup.sh -i
sh: run: No such file or directory
SnappCars-MacBook-Pro-2:PokemonGo-Bot Jos$ sh run setup.sh -c
sh: run: No such file or directory
SnappCars-MacBook-Pro-2:PokemonGo-Bot Jos$ run setup.sh -r
-bash: run: command not found
SnappCars-MacBook-Pro-2:PokemonGo-Bot Jos$ sh run setup.sh -r
sh: run: No such file or directory
SnappCars-MacBook-Pro-2:PokemonGo-Bot Jos$ sh run setup.sh -u
sh: run: No such file or directory

The thing is that it was running fine and after I killed and restarted it a couple of times it threw this error

SnappCars-MacBook-Pro-2:PokemonGo-Bot Jos$ sh run setup.sh -i
sh: run: No such file or directory
You didn't follow the install instructions correctly.
Try these:
https://github.com/nivong/PokemonGo-Bot/blob/patch-5/docs/installation.md
@k4n30 please merge this commit to prefent these noob errors. https://github.com/PokemonGoF/PokemonGo-Bot/pull/3593
on a side note, snappcars macbook, really ? lol

@nivong I dont have merge access :(
OP has closed the issue, please leave it alone now. There is a PR to prevent the issue in the future


Fix HMR bugginess

Kind of lower priority for now as I can just refresh the page, but via Dustin:

Use overwriteSource and overwriteLayer instead of map.addSource and map.addLayer
Within a .ts file using classes, use EventManager to handle MapLibre and document event handlers. Otherwise as you edit a component, you'll keep running old versions of the callbacks!
Within a Svelte component, express event handlers using functions and remember to call map.off() within onDestroy. Refer to existing components.
When in doubt, Ctrl+Shift+R to hard refresh and get rid of any possible HMR weirdness

Generally haven't run into issues with this for a while!


TSC Meeting (13 Jul 2021): v3.5 Released 🎉, v3.6 Roadmap Planning, Maintenance

NOTE!
Due to US holiday, TSC requested to move the meeting. New date is 13th July instead of 6th.

July 2021 @StackStorm/tsc 1 hour meeting will take place on Tuesday, 13th July 2021, 09:30 AM US Pacific.
See #33 for more info about how to join.
Meeting Agenda

News/Announcements (3min)
StackStorm v3.5.0 was released 🎉 (10min)

Release Manager @amanda11, Release Assistant: @winem
Feedback, Retrospective from the team?

what went well
what didn't?

Post-release: update st2cicd to the latest dev version?

StackStorm v3.6.0 Roadmap planning (25min)

Target date: (3mo)?
Release Manager: @winem (based on release rotation).
Release Assistant: WHO @StackStorm/maintainers?
What was @StackStorm/maintainers and Partners impact in v3.5.0?
What are @StackStorm/maintainers and Partners plans for v3.6.0?
Roadmap WIP
ChatOps

short-term: Node 14 -> 16 update ?
long-term: Python ChatOps discussion?

StackStorm Partners Program was shipped 🎉 (5min)

Coordinator: @mickmcgrath13
https://stackstorm.com/
https://stackstorm.com/partners/
https://stackstorm.com/partners-program/

StackStorm Infra & Expenses (10min)

AWS account expenses, FOSS credits (@punkrokk)
PackageCloud.io paid plan (#74)
Infra/Maintenance: stackstorm.com website migration to static pages #76
Infra/Maintenance: Forum -> Github Discussions migration #75

Any other random Questions and Discussions (5min)

Officially relaxing our governance requirements document (@blag)

FYI due to US holiday, TSC requested to move the meeting. New date is 13th July.
@StackStorm/tsc @StackStorm/contributors

Participants
Host: @armab
Attendees: @blag @amanda11 @winem @punkrokk @cognifloyd
Meeting Minutes
Project Updates

Congratulations @arms11 for becoming one of the st2 @StackStorm/contributors  https://github.com/StackStorm/st2/pull/5288
Thanks @cognifloyd from @StackStorm/contributors for shipping 15+ PRs to st2 K8s Helm chart

opportunity to promote K8s chart beta -> stable later: https://github.com/stackStorm/stackstorm-ha

Encore is helping around the Puppet-st2 maintenance
We applied to Docker Open Source program and they whitelisted https://hub.docker.com/r/stackstorm/ org. No rate limiting for users downloading st2 images whatsoever.

StackStorm v3.5.0 release

StackStorm v3.5.0 is out :tada: !
Thanks @amanda11 and @winem for their hard work leading it!
Feedback:

low participation from @stackstorm/tsc in the pre-release testing

Random Discussion: Release Cadence

How to make releases easier and faster?

how about weekly/on-demand releases when needed?

Note: 1 yr old first community release feedback to do faster release cadence: https://github.com/StackStorm/discussions/issues/20
Note: Sept 2020 we moved to lower 3mo release cadence: https://github.com/StackStorm/discussions/issues/50
Problem: Hard to find release manager/coordinator, releases are too time-consuming, a major effort
Observation: Historically being a company-supported product, StackStorm still has a lot of Q/A processes that require full-time effort and maintenance

it shouldn't be that hard for OSS community to manage it
reduce the quality bar, ship faster?

Minimize Release complexity, Change the approach?

simplify st2cicd workfows and number of moving pieces?
rely more on python packaging solutions?
ditch the deb/rpm packages? Let the users build st2 from sources or maybe partners to provide packaging solutions?
remove the manual Q/A pre-release testing process?
remove st2cicd, rely on CircleCI only?
remove environments and package promotion complexity: staging, unstable, staging-unstable, staging-stable?

@punkrokk will provide a Github Discussion with the hot topic for others to get involved & gather feedback and proposals

Random Discussion: It's hard to setup st2 Development environment to contribute a first PR

Provide a Vagrantfile in stackstorm/st2? https://github.com/StackStorm/st2vagrant/
Provide a docker-compose file in stackstorm/st2? https://github.com/stackStorm/st2-docker

StackStorm v3.6.0 release planning - moved to August TSC Meeting

Release manager: @winem. Release assistant: WHO from @StackStorm/tsc?
Maintenance release? Just ship what was merged before the release date?
When? (+3 mo or different?)
Due to low TSC presence, release planning moved to the next August TSC Meeting

StackStorm Partners Program

StackStorm Partners Program was officially shipped https://stackstorm.com/partners/ :tada:

Thanks @mickmcgrath13 for brilliantly leading it  :+1:
@armab  to follow-up on announcing it to ST2 OSS Community.

Project Expenses - re-iterate at August TSC Meeting
AWS

We burned all the CommunityBridge donated $ due to the most recent 2 x $600+ bills

FOSS program 2-month lag, AWS being slow on renewing FOSS credits

https://crowdfunding.lfx.linuxfoundation.org/projects/aec7b5bf-bb7a-4385-9820-eaef4e92bcfa (numbers are not updated yet, but it's close to 0).
@punkrokk reports AWS promised to apply the AWS credits last week
AWS confirmed: 2021 is the last year of FOSS credits

@punkrokk suggested to further minimize the AWS costs where possible

Biggest $ back hole: Running full st2 e2e tests on 4 platforms by spinning fresh VM instances: U16/U18, EL7/EL8
Team agreed to switch from nightly to weekly CI/CD e2e builds & tests (Done :heavy_check_mark:  by @amanda11: https://github.com/StackStorm/st2cd/pull/466)
@punkrokk will provide a PR to run builds on AWS spot instances instead of using EC2 on-demand (repo: https://github.com/StackStorm/st2ci/)

PackageCloud

Hidden complexity of moving to other deb/rpm provider: rework st2cicd workflows, create new st2 integration pack, releases, st2cicd, update users with the new URL
With no $ on CommunityBridge and with the new official st2 Partners Program, reiterate with PackageCloud on FOSS program (we pay ~$120/mo)
Last 14 month of PackageCloud BW usage was below the FOSS limits (Screenshot)
TODO: Clean up unused deb/rpm packages (Screenshot)

forum.stackstorm.com migration to GH Discussions - moved to August TSC Meeting
stackstorm.com migration to GH static pages - moved to August TSC Meeting
Relaxing ST2 Governance for Maintainers - moved to August TSC Meeting

Problem: The requirements to join the TSC and become a StackStorm Maintainer are too high
https://github.com/StackStorm/st2/blob/master/GOVERNANCE.md#how-to-become-a-maintainer
Due to low TSC quorum, discussed has been moved to August TSC Meeting

Actionable Items:

[ ] StackStorm Partners Program: @armab will work on announcing it to st2 OSS Community
[ ] Faster StackStorm Releases: @punkrokk will provide a focused Github Discussion with the topic for others to provide feedback and get involved
[x] Reduce AWS $:  @amanda11 to switch from nightly to weekly CI/CD builds (Done :heavy_check_mark:: https://github.com/StackStorm/st2cd/pull/466)
[ ] Reduce AWS $: @punkrokk will provide a PR to run builds on AWS spot instances instead of on-demand (repo: https://github.com/StackStorm/st2ci/)
[ ] PackageCloud: Clean up unused deb/rpm packages. WHO @StackStorm/tsc ?


chore(hapi): database persistence of blockchain events

Database persistence of blockchain events
What does this PR do?

Resolve #30

Steps to test

Run the project
Go to the folder hapi/src/services/hyperion/index and see the changes
Go to the folder hapi/src/services/hyperion/updaters and see the changes on eosiotoken and genesiseden

CheckList

[x] Follow proper Markdown format
[x] The content is adequate
[x] The content is available in both english and spanish
[x] I Ran a spell check

Requested changes fixed.

This pull request fixes 1 alert when merging afc0f81 into 9cce1c3 - view on LGTM.com
fixed alerts:

1 for Unused variable, import, function or class

@warnerHurtado  please check


lognormal\boomerang not registered with bower

GET http://bower.herokuapp.com/packages/boomerang
Result:
{"name":"boomerang","url":"git://github.com/bluesmoon/boomerang.git","hits":127}
According to this pull request, it looks like the intention was to register the lognormal\boomerang repo?
https://github.com/lognormal/boomerang/pull/36

unfortunately no one from the boomerang team actually registered the package with bower.  It was done by someone else and we don't know how to change it.

Hey @josh, any chance you can help us with this?  You had helped before me with https://github.com/nicjansma/usertiming.js/pull/4.  We'd like to redirect the bower info for boomerang to lognormal/boomerang.

bower token login doesn't work.  Waiting for them to fix that first.

We've been able to update https://bower.herokuapp.com/packages/boomerang


HDDS-7328. Improve Deletion of FSO Paths

What changes were proposed in this pull request?
Currently, the deleting speed of paths in the FSO bucket is too slow.
Every time the DirectoryDeletingService executes(every 1m by default),  it chooses only one path from DeletedDirectroyTable and tries adding its sub-files and sub-dirs into the PurgeDirectories Request. The real deletion happens in OMKeyDeleteResponseWithFSO, which moved all sub-dirs into DeletedDirectroyTable.  Then these sub-dirs will be chosen by the future execution of DirectoryDeletingService.
In the real production environment, such deletion speed is not applicable. There could be lots of dirs deleted without sub-dirs or sub-files. The dir deletion speed would lag behind the dir creation speed.
In this PR,  I propose to optimize the logic of the DirectoryDeletingService, we could consume all the quota (ozone.path.deleting.limit.per.task) to delete paths as much as possible. The good news is the PB is already designed to do so, we could add more PurgePathRequest in one PurgeDirectoriesRequest.
Originally: 1 min.  At most 1 path from deletedDirectoryTable.
Now:          1min.   At most 10000 paths from deletedDirectoryTable.
message PurgeDirectoriesRequest {
  repeated PurgePathRequest deletedPath = 1;
}

What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-7328
How was this patch tested?
UT and real env

@linyiqun @rakeshadr PTAL.
This should be compatible with HDDS-5048.
This aims to improve the efficiency of the deletion if not enough sub-files or sub-dirs are chosen.

Thx @JacksonYao287  for the review!

@JacksonYao287 please don't forget to close the Jira issue and set the fix version based on where it was committed.

Thanks @Xushaohong for the improvement and @JacksonYao287 for the review. I have backported this fix into 1.3 branch.


Suggestion: -Timeout

Currently there is no timeout value present (or im utterly blind), i've observed that jobs can have a tendancy to get stuck in running state without doing anything. impacting performance and if you get 50 jobs stuck the whole threadjob would stop.
I've not been able to figure out why the jobs seems frozen, but runtime is in the excess of 5000 seconds for a simple "invoke-command -computername remotecomputer" command. receive-job has first steps of the script so it seems to launch fine.
A -timeout parameter with a supplied number of seconds could easily mitigate the process.
Atlernativley I workarround this by doing a do {} until loop.
    get-job | where state -eq running | select id, PSBeginTime | % {
        $timeoutTime = Get-Date
        $timeoutStartTime = $_.PSBeginTime
        $timeoutCheck = $timeoutTime - $timeoutStartTime

        if ($timeoutCheck.totalseconds -gt "$TimeoutSec") {
            $id = $_.Id
            write-warning -Message "Removed job $id due to timeout value $timeoutsec"
            Stop-Job -id $_.Id
        }

You can use Wait-Job with its timeout parameter:
$job = Start-ThreadJob { 1..10 | % { sleep 1; "Output $_" } }
Wait-Job $job -Timeout 5
$job | Receive-Job


Global test on ns with its own op fix

Fix an issue of e2e/global_test/Global_test_on_namespace_with_its_own_operator which relied to the default ck operator image using "--olm=false" flag value

Release Note
NONE

cce54f6

done

There are a few validation errors as well. Pls fix them accordingly.

sorry, closed by mistake. Now reopened

@vitorz  Can you rebase this PR ?

@claudio4j i rebased the PR

Was able to run test with a custom image, it works, thanks.

@vitorz could you please rebase this PR? cannot merge because a conflict. Thanks.

@squakez i rebased

Merging after the changes applied as required by reviewers. FYI @oscerd @tadayosi


Cause effect behavior to EventEmitter2

Hello, i want to ask how to achieve this Cause=>Effect behavior using EventEmitter2?
To be a little more accurate take a look at this repository
https://github.com/olado/causeeffect
it is possible to do, something like object.on(['effect:1','effect:2','effect:3'],'effect:ok'); which pretty much say that the object will trigger/emit effect:ok only when effect:1,effect:2,effect:3 are all emitted to it.

I think this might be outside of the scope of the library. You may want to wrap over it to achieve the functionality you want. Maybe by tracking which events have been emitted in the past using onAny?


Revert "Upgrade kanister build image to v0.0.8"

Reverts kanisterio/kanister#602
@SupriyaKasten the image has to be built from PR - https://github.com/kanisterio/kanister/pull/597
I am assuming you have built the image from master
$ docker run --rm kanisterio/build:v0.0.8 kind version
v0.5.1

That's why its still using older dependencies.

Let's not override the existing image, instead push image with newer tag

@PrasadG193 my bad, I might have mistakenly checked out one of my local branch before running docker built. Sorry about that 🤦♀


improve test coverage

How should this be manually tested?
Run yarn test:coverage, coverage should have significantly improved.

👍 LGTM 🎉


sct_process_segmentation --> option to compute spinal cord angle with z axis

Would be great!
Something like:
    for iz=1:nbslices-1
        a=centerline_coord(iz+1,:)-centerline_coord(iz,:);
        b=centerline_coord(iz+1,3)-centerline_coord(iz,3);
        angle(iz)=acosd(b/norm(a));
    end

with centerline_coord =[X,Y,Z] --> coordinates of the spinal cord

Done and fixed in latest commit: 2db2ee84d71a660867445bd416c30201073daa36


chore: add evaluation CLI dockerfile

What type of PR is this?
feature

What this PR does / why we need it
Which issue(s) this PR fixes

Special notes for your reviewer

@Lanture1064 Also add a github action to auto-build this image  kubeagi/arcadia-eval:xx


[Maven] DynamicTrees Maven Repo

Hey, is there a DynamicTrees maven repo we can access in order to code compatibility between Dynamic trees and Minecolonies?
If you have none we could help you with setting it up as well.

There isn't one.  I would appreciate the help setting it up as I've never done that before.

I'll check back with the guy who is responsible for our infrastructure including maven, do you have a discord where we could reach you, that'd be easier than via this thread here.

I mill about on Mangoose's mods discord: https://discord.gg/GZBVVEj


Add Steem

https://github.com/thilobillerbeck/awesome-steem
This list is about the steem cryptocurrency network and it's tools, as well as guides and communities.
By submitting this pull request I confirm I've read and complied with the below requirements 🖖
Please read it multiple times. I spent a lot of time on these guidelines and most people miss a lot.
Requirements for your pull request

You have to review at least 2 other open pull requests. Try to prioritize unreviewed PRs, but you can also add more comments to reviewed PRs. Go through the below list when reviewing. This requirement is meant to help make the Awesome project self-sustaining. Comment here which PRs you reviewed. You're expected to put a good effort into this and to be thorough. Look at previous PR reviews for inspiration.
I have read and understood the instructions for creating a list.
This pull request has a descriptive title in the format Add Name of List (Example: Add Swift), not Update readme.md or Add awesome list.
The entry in the Awesome list should:

Include a short description about the project/theme of the list. It should not describe the list itself.Example: - [Fish](…) - User-friendly shell., not - [Fish](…) - Resources for Fish..
Be added at the bottom of the appropriate category.

The list I'm submitting complies with the below requirements.

Requirements for your Awesome list

Has been around for at least 30 days.That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent.
It's the result of hard work and the best I could possibly produce.
Non-generated Markdown file in a GitHub repo.
Includes a succinct description of the project/theme at the top of the readme. (Example)
The repo should have awesome-list & awesome as GitHub topics. I encourage you to add more relevant topics.
Not a duplicate.
Only has awesome items. Awesome lists are curations of the best, not everything.
Includes a project logo/illustration whenever possible.

Either fullwidth or placed at the top-right of the readme. (Example)
The image should link to the project website or any relevant website.
The image should be high-DPI. Set it to maximum half the width of the original image.

Entries have a description, unless the title is descriptive enough by itself. It rarely is though.
Includes the Awesome badge.

Should be placed on the right side of the readme heading.
Should link back to this list.

Has a Table of Contents section.

Should be named Contents, not Table of Contents.
Should be the first section in the list.
Should only have one level of sub-lists, preferably none.

Has an appropriate license.

That means something like CC0, not a code licence like MIT, BSD, Apache, etc.
WTFPL and Unlicense are not acceptable licenses.
If you use a license badge, it should be SVG, not PNG.

Has contribution guidelines.

The file should be named contributing.md. Casing is up to you.

Has consistent formatting and proper spelling/grammar.

The link and description are separated by a dash. Example: - [AVA](…) - JavaScript test runner.
The description starts with an uppercase character and ends with a period.
Consistent and correct naming. For example, Node.js, not NodeJS or node.js.

Doesn't include a Travis badge.You can still use Travis for list linting, but the badge has no value in the readme.

Go to the top and read it again.

Thanks for making an Awesome list! 🙌
It looks like you didn't read the guidelines closely enough. I noticed multiple things that are not followed. Try going through the list point for point to ensure you follow it. I spent a lot of time creating the guidelines so I wouldn't have to comment on common mistakes, and rather spend my time improving Awesome.

Thanks for your answer. I read over it and made some improvements to the descriptions and the contribution guide, removed some dead links and deleted the "Tutorials" section. I double checked the guidelines and didn't encounter anything that is not fullfilled by my list. :smile:

busy - This is a platform: Please don't say "This is". Maybe shorten it to busy - Platform.
Maybe also remove .yo-rc.json.

Thanks for your feedback :smile: I just applied your suggestions

Hey, sorry for the lack of response, please see #1363.

Have to review PRs still. But the lsit should now match the new guidelines.

❯ awesome-lint https://github.com/thilobillerbeck/awesome-steem
✖ Linting

  readme.md:42:3
  ✖   1:18  Invalid badge source                                                                                remark-lint:awesome/badge
  ✖  18:1   ToC item "Chats / Communities" link "#chats" not found                                                      remark-lint:awesome/toc
  ✖  28:27  Text "Youtube" should be written as "YouTube"                                                               remark-lint:awesome/spell-check
  ✖  29:3   Link to https://mapala.net/en/ is dead                                                                      remark-lint:no-dead-urls
  ✖  34:3   Link to https://zappl.com/ is dead                                                                          remark-lint:no-dead-urls
  ✖  38:31  List item description must end with proper punctuation                                                      remark-lint:awesome/list-item
  ✖  42:3   Link to http://steemit.deadfollowers.info/ is dead                                                          remark-lint:no-dead-urls
  ✖  44:3   Link to https://phist.Steemdata.com/ is dead                                                                remark-lint:no-dead-urls
  ✖  45:3   Link to http://piston.rocks/ is dead                                                                        remark-lint:no-dead-urls
  ✖  53:3   Link to http://Steemimg.com/ is dead                                                                        remark-lint:no-dead-urls
  ✖  55:3   Link to https://utopian.io/utopian-io/@mwfiae/steemit-sidebar is dead                                       remark-lint:no-dead-urls
  ✖  58:3   Link to http://www.Steemdollar.com/dollar_per_vote.php? is dead                                             remark-lint:no-dead-urls
  ✖  69:3   Link to https://play.google.com/store/apps/details?id=com.netsolutions.eSteem&hl=de is dead                 remark-lint:no-dead-urls
  ✖  71:3   Link to https://play.google.com/store/apps/details?id=com.droid.steepshot&rdid=com.droid.steepshot is dead  remark-lint:no-dead-urls
  ✖  80:3   Link to http://steemit.chat/ is dead                                                                        remark-lint:no-dead-urls

  15 errors

https://github.com/sindresorhus/awesome-lint

Have to review PRs still.

:arrow_up:

Can you fix the merge conflict?

Closing for lack of response.


fix: fix the signature of Tester.Test and add tests

Codecov Report

Merging #8 into master will increase coverage by 6.69%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master       #8      +/-   ##
==========================================
+ Coverage   55.64%   62.34%   +6.69%
==========================================
  Files           5        5
  Lines         239      239
==========================================
+ Hits          133      149      +16
+ Misses         81       65      -16
  Partials       25       25

Impacted Files
Coverage Δ

fagott/tester.go
58.97% <0%> (+13.67%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62b600c...11c2757. Read the comment docs.


video thumbnail extraction:  some videos reset back to 0? seconds for image returned

Hello,
Using the parameters:
/vts:71/rs:fit:640:380/ results in an image from the expected position in the video.
/vts:72/rs:fit:640:380/ results in an image from the first second of the video.
adding vtk:1 did not change the behaviour.
Will email a link to the content as it is NSFW.

Hey @routehero!
The issue is fixed in v3.22.0

Looks good to me!


Follow porting of cloudant/swift-cloudant to Linux

The current master branch of https://github.com/cloudant/swift-cloudant does not compile on Linux.
This package is needed since it supports https://docs.cloudant.com/cloudant_query.html, which Kitura-CouchDB does not support.

The README specifies explicitly that Linux is not supported. The issue regarding porting to Linux - https://github.com/cloudant/swift-cloudant/issues/121.


Wrong begin form.

This may not be solvable (or may require backtracking when constructing language). But I'll put this here anyway, and if it's not doable, we should output a better error message.
Let's say I have the following language;
#lang nanopass
(define-language Lsrc
  (terminals
   (symbol (s))
   (number (n)))
  (stmt (stmt)
        n
        expr
        (begin stmt ...))
  (expr (expr)
        s
        (begin expr ...)))

I cannot construct the following grammar:
(with-output-language (Lsrc stmt)
  `(begin a 5))

Because it tries to use the expr begin, rather then stmt's. (Which is understandable because an expr is a valid stmt.
So, this makes me think either we need to improve the pattern matcher to allow this, and at least try to pick the right one (if it exists anyway), or if I give an ambiguous grammar, give that as an error message.

Hey Leif,
So there are actually two separate problems here.
The first is already documented (and there is already an issue, though I think it is not spelled out very well in Issue 15).  Basically, things with the same shape in the same production cannot be parsed correctly because we make the decision based on the keyword and the shape, and not based on the types with the language.  There are basically two things we can do with this:

We can identify when this happens and error out.  This is kind of an unsatisfying solution, but is easier to implement.
We can make the parser and meta-parser smarter so that it can deal with this, when the types specify a language that is not ambiguous.

I'd rather do the later, but I am not sure, yet, exactly how this will work in the meta-parser.  (The parser is pretty easy to fix.)
However the language you have here, has a separate problem.  Your language is actually an ambiguous language:  For instance, if you have the program:
`(begin x y z)
Should this be parsed as:
(stmt:begin
  x
  y
  z)
or
(expr:begin
  x
  y
  z)
Technically, either one is valid, but the nanopass framework isn't really setup to deal with this kind of ambiguity.  We could decide that the whichever appears first in your language definition is the one we use (and in fact, that is what is going to happen now, because of the earlier bug).  However, I think we probably want to raise an error (or at least a warning) for this situation even if we've implemented option 2 above.
-andy:)
On August 18, 2015 at 11:04:02 AM, Leif Andersen<EMAIL_ADDRESS>wrote:
This may not be solvable (or may require backtracking when constructing language). But I'll put this here anyway, and if it's not doable, we should output a better error message.
Let's say I have the following language;
#lang nanopass
(define-language Lsrc
(terminals
(symbol (s))
(number (n)))
(stmt (stmt)
n
expr
(begin stmt ...))
(expr (expr)
s
(begin expr ...)))
I cannot construct the following grammar:
(with-output-language (Lsrc stmt)
`(begin a 5))
Because it tries to use the expr begin, rather then stmt's. (Which is understandable because an expr is a valid stmt.
So, this makes me think either we need to improve the pattern matcher to allow this, and at least try to pick the right one (if it exists anyway), or if I give an ambiguous grammar, give that as an error message.
—
Reply to this email directly or view it on GitHub.


Possible bug in cookiecutter shell script for targets

Migrated from GitLab: https://gitlab.com/meltano/sdk/-/issues/271
Originally created by @aaronsteers on 2021-11-16 18:54:36

As reported in this slack conversation: https://meltano.slack.com/archives/C01TCRBBJD7/p1637088359193600?thread_ts=1637076547.186200&cid=C01TCRBBJD7

I think I "solved" the problem. If I simply remove < /dev/stdin everything works fine.

View 3 previous comments from the original issue on GitLab


Easier inclusion of stylesheets

Fix bug: Submitted wrong file contents before
Fix bug: Always update local snapshot set cache
Allow passing custom <head> content
Allow easy submission / usage of local files
Add tests
Update documentation

Closes #23.

TODO: Add short notice to docs that submitted files will be publicly accessible!


Check out a book

Given I am on the books view
If a book is checked out
Then I should see an indication that the book is checked out
And I should see the name of the person who has checked out the book
If a book is in the office
Then I should see the current location and a link to check out the book
Given a book is not already checked out
When I click "check out" next to a book
Then I should be able to enter my name
And the book view should indicate that the book is checked out to me

Completed in PR #12


Fix oauth2 scope specification

They were comma separated, but according to the RFC they're space separated:
https://tools.ietf.org/html/rfc6749#section-3.3
I encountered this because Dex rejected my request when I specified more than simply openid, specifying e.g. openid and email yielded this error:
time="2020-05-25T13:40:44Z" level=error msg="Failed to parse authorization request: Missing required scope(s) [\"openid\"]."

Not really sure why the CI is failing. My individual commits are :heavy_check_mark: but the merged commit is failing for some reason?

Pushed a fix for the tests.

Released as <IP_ADDRESS>!


dev bridge crashes with error

9:29AM INF fetching events for blockheight ID=6314578
9:29AM ERR failed to decode block for height error="unable to find field Balances_Upgraded for event #1 with EventID [2 14]" ID=6314578

I thought the new version was already deployed. Closing


fix(cli): allow exporting dynamic plugins from frontend-plugin-module packages.

The export-dynamic-plugin command of the @janus-idp/cli package, when applied to frontend plugins, doesn't support packages with the frontend-plugin-module.
This should be allowed so that APIFactories can be added, for example to support additional analytics providers.
This PR drops this unnecessary limitation.

/approve


Improve dataflow

Codecov Report
Patch coverage: 100.00% and no project coverage change.

Comparison is base (0e5313f) 100.00% compared to head (7353c9a) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #294   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files          316       316
  Lines         9904      9912    +8
  Branches       961       961
=========================================
+ Hits          9904      9912    +8

Impacted Files
Coverage Δ

src/gravitorch/experimental/dataflow/dataloader.py
100.00% <100.00%> (ø)

src/gravitorch/experimental/dataflow/iterable.py
100.00% <100.00%> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Unable to upgrade azuredatastudio-linux-1.48.0.deb on Ubuntu <IP_ADDRESS>

Azure Data Studio Version: <IP_ADDRESS>
OS Version: Ubuntu <IP_ADDRESS>

Steps to Reproduce:

Does this issue occur when all extensions are disabled?: Yes/No

This is a common problem. Clicking on the upgrade notice downloads the file: azuredatastudio-linux-1.48.0.tar.gz which is no use to man nor beast. I've been through this with you many, many times. Just do what everyone else does, detect the OS then offer the .deb or .rpm or whatever is the correct file format and then make sure it CAN upgrade the application.  Your MS Code colleagues manage it, as do Jetbrains and anyone else involved in providing Linux tooling.  But not you though.

@Verythai The only way I manage to upgrade is to not bother with their download. Just uninstall the application in Terminal and then download the .deb file of the site and reinstall. When it's complete the installer will tell you the same error message. That's because it's now already install. Hope you find this link useful: https://www.makeuseof.com/how-to-install-azure-data-studio-on-linux/


Issue in using Hygieia 1.3.0 version !

I downloaded the below mentioned Hygieia relase.
https://github.com/capitalone/Hygieia/releases
Non Docker version / Binaries in Nexus Central version 1.3.0 source.zip for windows.
I am struggling to know what all steps we need to use for installing the Hygieia if we want to use it for dashboarding purpose. Already installed the MangoDB and it's client. Created a new db, user and pwd. Already compiled the api using "mvn install" command and created dashboard.properties file having information for MangoDB database. While running it using jar command it is giving me error api.jar file not found.
I am not sure about the steps and sequence to follow for using Hygieia for dashboard purpose. I mean do we need to compile api 1st then UI etc. Can you provide clear steps and usage of all modules please?

I would take the latest from master. And follow the exact steps. Note that mvn install will put the JAR in your local maven repo (/.m2/) and in the /target/ folder.

@AtulKamra Follow steps listed in http://www.capitalone.io/Hygieia/getting_started.html . Run "mvn clean install package" from the root of Hygieia.


fixed "require(textures)" is undefind

Thanks!

Even better, update the package.json main field to point to textures.js instead of keeping an index.js file.


Add app execution alias for "cmd" or "bash"

Description of the new feature/enhancement
Add additional app execution aliases in addition to wt
Proposed technical implementation details (optional)
I am used to pressing Win-R then "cmd" to open up a command prompt, can you provide an option for adding bash and cmd as additional aliases (which are disabled by default).  Also detect that they are being used and start up the appropriate shell.

Thanks! Wow, this is a terrifying idea that just might work! However, we don't want to stomp cmd or bash or wsl for anybody who has Terminal installed, because those are used in huge number during automation. This would break even running cmd from CMD.
We're going to tackle this more holistically at the OS level with #492.
/dup #492


schismtracker: 20190805 -> 20200412

Motivation for this change
Version update. Tested on macOS only. Can be merged independently of #87900.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[x] macOS (With #87900)
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Relevant: schismtracker/schismtracker#227


Arrow Flight format support for StringViewArray and BinaryViewArray

Which issue does this PR close?

Closes #5507.
Rationale for this change
To confirm that StringViewArray and BinaryViewArray works with Arrow Flight format.

What changes are included in this PR?
Just added a few test case to show that they should work, and they indeed work.
Nothing important really, it just works as @alamb said.
Please let me know if I need to make some more complex test cases like ones we added to in the IPC reader test cases.

Are there any user-facing changes?
No

Thanks @XiangpengHao  !


Enforce C++17 in llvm-kompile-clang

Fixes #695 by making C++17 a top-level requirement in llvm-kompile-clang; we already depended on it implicitly in a number of places (building the backend, Python bindings), so this change shouldn't be a departure in practice.

Yes, the CI matrix runs against LLVM 12.


Code cleanup

This is a big cleanup PR that fixes a plethora of smaller issues and rewrites other parts.

Q
A

Breaks BC?
✔ big time

Apologies for the lack of specificity but the library was so small that a quick rewrite that breaks BC was more efficient. Hope you have time to review and provide feedback.
Some things this PR does:

Implement interfaces for message signing en encrypting, something Symfony lacks.
Implement wrappers for Symfony's signers & encrypters that implement the new interfaces.
Implement interface SymfonyMessageWrapperInterface which contains the getSymfonyEmail() function that our Mailer needs. This allows us to typehint against the interface not the class.
Rewrote Logger to use the PSR provided trait, allowing us to implement just the log function. Added configurable severity mappings and configurable category.
Removed with- functions in the Mailer, Yii components are traditionally mutable and reconfigurable so this pattern is not needed.
Allow user to set their own TransportFactory this allows them to configure things like a custom HttpClient but also available transports and which Dispatcher, if any, to use.
Added test coverage, almost all code is now fully covered, except Message which sits at ~80%. The proxy wrappers that just contain 2 lines of code like DkimSignerWrapper have been excluded from code coverage.

Is the completion of the work planned ?

Yes definitely. This branch is already in production so I'm pretty sure it works.
Needs a good review though.

@SamMousa shouldn't readme be adjusted?

Hmm, good point, very probably yes. Will try to make some time to finish this!

Is everything bad?

Well it depends on what year we live in. When Yii2 came out it was good, but that was a long time ago. Nowadays the standard "Yii" way is not considered a clean / proper way of writing code. (Not blaming anyone, back then we had php 5.6, no typing, no static analysis etc)
Modern code is different and practices have improved as well.

What needs to be completed for the merger?

The Readme

@SamMousa Is there any way I can help with this?

Definitely, just check the current Readme and make sure it's code samples are still correct!

@samdark as far as I can tell the readme is good, since the public configuration API is mostly unchanged.
This means this can be merged. In my opinion: release it as a new major version, it may require changes in consuming code if they use advanced stuff like message signing or encryption.

@samdark your code style changes should be enforced by easy coding standard. (Check ecs.php)
I can use a different standard / config, but the idea is to automate the check so that code style feedback by humans isn't needed and any PR will fail if it doesn't abide by the rules.

I know. Doing that in Yii3 already via StyleCI.

I've just quickly reviewed some of the changes.  I'm concerned that getSymfonyMailer() method has been made private.  This makes it impossible to extend the Mailer class with a new sendMessage() method.  Please keep it at least protected.
In fact it would be far nicer if $encryptor, $signer and $dkimSignerOptions were also protected and not private.

Please also not that in the sendMessage method, it needs to re-throw the Exception since the calling code will need that to extract the errors.  No need to return false;

There are a lot of changes in this.  Is it possible to include a public socket timeout property?
https://github.com/yiisoft/yii2-symfonymailer/issues/40

In fact it would be far nicer if $encryptor, $signer and $dkimSignerOptions were also protected and not private.

They are public as far as I can tell. So you can configure them however you like.

There are a lot of changes in this. Is it possible to include a public socket timeout property?

This is not really related to these changes. But the way to go about it (and this is purely the Symfony part of the library) is as you suspected.
You'd use a wrapper class (composition instead of inheritance) since Symfony even goes so far as to make their classes final so you cannot extend them.
class SmtpTransportWithTimeoutFactory implements TransportFactoryInterface {
    public function __construct(private TransportFactoryInterface $factory, private float $timeout)
    {
    }

    public function create(Dsn $dsn): TransportInterface
    {
        $result = $this->factory->create($dsn);
        if ($result instanceof SmtpTransport) {
            $result->getStream()->setTimeout($this->timeout);
        }
        return $result;
    }

    public function supports(Dsn $dsn): bool {
        return $this->factory->supports($dsn);
    }
}

@samdark I think it's really done now!

I really hate to bother you guys. I am really looking forward to these changes
When I call:
$mailer = Yii::$app->mailer;
I keep getting a error:
Error
Typed property ....\Mailer::$transportFactory must not be accessed before initialization
I was trying to set it up so I could start building and wiring up a Transport.  The config is very normal and complies with the ReadMe sample with the exception that the 'dsn' key is not used as this will override the other settings.
private function createTransport(array $config = []): TransportInterface
{
    if (array_key_exists('dsn', $config)) {
        $transport = $this->transportFactory->fromString($config['dsn']);
    } elseif (array_key_exists('scheme', $config) && array_key_exists('host', $config)) {
        $dsn = new Dsn(
            $config['scheme'],
            $config['host'],
            $config['username'] ?? '',
            $config['password'] ?? '',
            $config['port'] ?? null,
            $config['options'] ?? [],
        );
        $transport = $this->transportFactory->fromDsnObject($dsn);
    } else {
        throw new InvalidConfigException('Transport configuration array must contain either "dsn", or "scheme" and "host" keys.');
    }
    return $transport;
}

I have tried different ways of "installing" the new version - automagical loading can get confusing - but with the config containing a transport configuration array it appears that the BaseObject constructor is calling Yii::configure($this, $config) before calling $this->init();
Yii::configure will end up calling setTransport with the configuration array.  And since it's an array setTransport calls createTransport which tries to access $this->transportFactory and that causes an exception:
Typed property ....\Mailer::$transportFactory must not be accessed before initialization
It very possible that I've wired up the Mailer wrong - if that's the case I'm very sorry for wasting your time.

This is a sequential view of what's happening, starting with BaseObject::_construct().
yii\base\BaseObject calls BaseYii::configure() before calling $this->init()
public function __construct($config = [])
{
    if (!empty($config)) {
        Yii::configure($this, $config);  [THE CALL]
    }
    $this->init();
}

BaseYii calls yii\base\Component::_set()
public static function configure($object, $properties)
{
    foreach ($properties as $name => $value) {
        $object->$name = $value;

Component calls Mailer::setTransport because we have a 'transport' => array configuration.
public function __set($name, $value)
{
    $setter = 'set' . $name;
    if (method_exists($this, $setter)) {
        // set property
        $this->$setter($value);

Mailer calls its own createTransport because $transport is a configuration array
public function setTransport($transport): void
{
    $this->_transport = $transport instanceof TransportInterface ? $transport : $this->createTransport($transport);

And createTransport tries to access $this->transportFactory before it's initialized by init()
    } elseif (array_key_exists('scheme', $config) && array_key_exists('host', $config)) {
        $dsn = new Dsn(
            $config['scheme'],
            $config['host'],
            $config['username'] ?? '',
            $config['password'] ?? '',
            $config['port'] ?? null,
            $config['options'] ?? [],
        );
        $transport = $this->transportFactory->fromDsnObject($dsn);

You must be in a different timezone 😅 I'll have a look. Note that the tests should show an example of how I wired it up. That is not to say this isn't a bug.

@nd4c give it another go; I've fixed it and added a test case for it.
Funny thing is that this type of bug is normally caught by static analysis, but we had to suppress those initialization checks because of the way object creation works in the framework :-/

Hmm, should we even support these custom options?
Instead we could support just DSN and reference this doc: https://symfony.com/doc/current/mailer.html#transport-setup

I would recommend allowing them because if someone creates a new Transport that has a lot of 'options' it's much easier to see what they are rather than appending them to the 'dsn' string.

Also, I would recommend using 'protected' instead of 'private'.  This allows the classes to be extended.
Quote from the "About Yii" section of the "Guide":
Yii is extremely extensible. You can customize or replace nearly every piece of the core's code. You can also take advantage of Yii's solid extension architecture to use or develop redistributable extensions.
And since this is an official Yii extension rather than an independent library it makes sense to me to follow that "extensible" aspect.

This allows the classes to be extended.

You keep coming back to this, but I believe it is a fundamental misunderstanding of how to write extensible code. Code being extensible does not have to mean that classes are extendable.
Anything you have mentioned wanting to do by using custom configuration or extending classes you can do better by using composition.

I would recommend allowing them because if someone creates a new Transport that has a lot of 'options' it's much easier to see what they are rather than appending them to the 'dsn' string.

The library we use uses a DSN though, and the DSN object inherently loses features like failover or roundrobin configuration. Which means that we sacrifice features from the parent library just to introduce our own configuration syntax which we then need to document and help users with.
Thinking it through a bit more I'm pretty sure that even leaving in the transport configuration option is not the best design.
Ideally you configure the factory and have it support your custom transport. The custom transport is than configured using a DSN like all other transports already supported by the library.
This is way cleaner:
[
    'class' => Mailer::class,
    'dsn' => "sendgrid+api://{$env->get('SENDGRID')}@default"
]

And if you need a custom factory implement that:
[
    'class' => Mailer::class,
    'transportFactory' => new Transport(new MyTransportFactory()),
    'dsn' => "my-custom-protocol://{$env->get('SENDGRID')}@default"
]

Composition it is then.  Of course, you realize that the Mailer class extends BaseMailer...
I don't see that strictly using a 'dsn' element is necessarily cleaner.  When using certain Transports, yes, it's cleaner.  But not for all Transports.
'transport' => [
	'scheme' => 'smtps',
	'host' => 'mail.longwinded.com',
	'port' => 2525,
	'username' =><EMAIL_ADDRESS>	'password' => 'We prefertousea Verylongandunforgettablepassphrase insteadof a password',
	'options' => [
		'verify_peer' => 0,
		'local_domain' => 'example.org',
		'restart_threshold' =< 10,
		'restart_threshold_sleep' => 1,
		'ping_threshold' => 200,
	],
],

That would be a very long 'dsn' string.  And, again, the DSN object just parses the string to get back to what's clearly displayed in the array.

I guess if I wanted to use failover or roundrobin with such complicated transport settings I would probably need a Mailer Factory that could automatically compose the 'dsn' string from a much more readable config array.  So it might make sense to just use the 'dsn' string.  I just keep feeling that we'd be missing a nice feature.

Composition it is then. Of course, you realize that the Mailer class extends BaseMailer...

I do, there's no easy way around it. Also realize that the framework is +- 10 years old, it's core code is not a best practice in 2022.

samdark added this to the 3.0.0 milestone 9 days ago
does that mean never?

No. That means it will be a major release of this exact extension.

@SamMousa thank you for reworking this!
I'm wondering if we could also include MailerEvents as Yii events? (definitely needed to inline CSS or stuff like this prior to sending the message)

@SamMousa thank you for reworking this!
I'm wondering if we could also include MailerEvents as Yii events? (definitely needed to inline CSS or stuff like this prior to sending the message)

Not in this pr. Let's do that after maybe

just curious, what is the ETA on this PR?
or is it possible to require this branch using composer?
thanks for your hard work! 😊

or is it possible to require this branch using composer?

Yes. Google is your friend.

@SamMousa sorry it took so long. Would you please help closing issues this PR solves? Thanks.

@samdark need a tag

@SamMousa, @Krakozaber is readme alright?

Also, I believe the 'scheme' settings is better to be left out.
'scheme' => 'smtps' is kind of misleading.  It doesn't exactly force ssl, but rather causes the code to choose a different transport.
I forget the details, but it's the 'port' => '465' that cause the code to use ssl.  And the default transport works better than the 'smtps' transport.
So the better config would be:
'transport' => [
                'host' => '',
                'username' => '',
                'password' => '',
                'port' => 465,
            ],

I've never dones a PR before.  Any tips?

Personally I believe you should be using DSN in all cases. The underlying library uses DSN and by not using it all you do is lose functionality.

I've never dones a PR before. Any tips?

For these simple things you can just do them inside Github and it will do most of the meta-work for you.
Go here: https://github.com/yiisoft/yii2-symfonymailer/blob/master/README.md and click the pencil top right.
Good luck!

Actually the underlying library uses the inidividual fields.  It will convert any DSN string to individual attributes on it's DSN object.  And not all transports are easy to for a developer to "read" as a DSN string.  (And for that matter, the DSN string is not technically a DSN, but rather a list of configuration settings...)
I will work on the README.md file.


Method add_uplink for LIG Uplinks Set does not work with Q ports nor integer ports

Scenario/Intent
When trying to use the lig_uplink_set method to set a Q port or even using the real integer value of the port, the following error is returned:
 Could not evaluate: Port not supported: Q type not found
Environment Details

OneView SDK Version: 4.2.0

Steps to Reproduce
Run the add_uplink method using a Q or integer port.
i.e.:
OneviewSDK::LIGUplinkSet.new(@client, name: 'test').add_uplink(3, 'Q1:1')

Expected Result
The port specified is added to the uplink set
Actual Result
It returns errors when both an integer or a Q value port is used.

This is related and reported by the issue https://github.com/HewlettPackard/oneview-puppet/issues/148

Is this related to #216 ? I did not have time to test it yet but it should be possible to get correct port number from /rest/interconnect-types. At least for OneView 3.0 ...

@vranystepan Yep, definitely related. I was just looking into using the Q ports and Integer values though, hadn't crossed my mind using different frames.

@fgbulsoni Multiple frames situation is pretty easy. Will try to figure out.
Anyway what do you mean with integer values? Do you mean the final relativeValue which can be directly placed to the Logical Interconnect Group data?

Do you mean the final relativeValue

Yep, I've been asked why it would not work if the correct already converted name is used. Made sense I guess. Definitely not a must and something which may even not be used by users, but again, I've been asked about it..

@fgbulsoni I've just put a few notes in the #216

@fgbulsoni I've just put a few notes in the #216

@vranystepan Looks like great work there, should get rid of all these issues indeed. Great job! :100:  :octocat:

Closing since this was fixed by #230.


Move exposed ownership pieces to swift/ABI/

We've been exposing all of swift/AST/Ownership.h to functions in swift/ABI since 2018. It looks like that was done only for the definition of the ValueOwnership enum. This commit pulls that enum out into the ABI directory to make it clearer that this is exposed to the Swift ABI (via MetadataValues.h) and removed the AST header from MetadataValues.h to prevent accidents.

@swift-ci please test


Indicate a user should install shellcheck before building

Without spellcheck, a make check or even a simple make will fail.
Signed-off-by: Kyle Mestery<EMAIL_ADDRESS>

Hi, I am trying to build following the instructions. But when I do
GOPATH= ./scripts/update-codegen.sh
Calling ./vendor/k8s.io/code-generator/generate-groups.sh
Generating deepcopy funcs
Generating clientset for networkservicemesh.io:v1 at github.com/ligato/networkservicemesh/pkg/client/clientset
Generating listers for networkservicemesh.io:v1 at github.com/ligato/networkservicemesh/pkg/client/listers
Generating informers for networkservicemesh.io:v1 at github.com/ligato/networkservicemesh/pkg/client/informers
Generating other deepcopy funcs
Generating openapi structures
./scripts/update-codegen.sh: line 29: /home/casa/go/bin/openapi-gen: No such file or directory
I looked at travis.yml but no idea how to use it.
Any help is appreciated.
Thanks

Hi @pkdas, this is a merged PR, you should probably comment on a new issue.
Regardless, to get around your issue, run the following:
go install ./vendor/k8s.io/kube-openapi/cmd/openapi-gen

I'll submit a PR with this fix for the docs.


[stable/prometheus] Fix issue with alertmanager name reference

What this PR does / why we need it:
If alertmanager gets a different name then communication fails between prometheus and alertmanager. This PR fixes this issue.
Which issue this PR fixes
No issue created yet
Special notes for your reviewer:

n/a

Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [stable/mychartname])

/assign @gianrubio

@chrisz100 pls have a look :)

/ok-to-test
/assign

@mvoeckle
Please bump the chart version to latest. Thank you.

@jlegrone Would be great if you could have a look at this or bump it to the right folks 👍


No error message for the user when the fields are empty during login

Why is the form to the right hand side? Why is it not at the center. Please fix ASAP!

Resolved