Library failed to compile for Android after upgrade to react native 0.56.0

Summary

Version
0.24.3

Affected OS
Android

OS Version
osx

Current behavior
After I upgraded my app to react-native 0.56.0 I'm not able to compile it for Android platform.
It worked fine before and I'm 100% sure that the library is properly linked.
My current configuration could be found here (package.json, build.gradle, MainApplication.java etc) - https://gist.github.com/lucassus/d40cd8bcca7997df1b9cf1c9871c3edb
[...]
:app:generateReleaseSources
:app:incrementalReleaseJavaCompilationSafeguard UP-TO-DATE
:app:javaPreCompileRelease
:app:compileReleaseJavaWithJavac
:app:compileReleaseJavaWithJavac - is not incremental (e.g. outputs have changed, no previous execution, etc.).
/Users/lucassus/Projects/Airsorted/housekeeping-app/android/app/src/main/java/com/airsorted/housekeeping/MainApplication.java:7: error: package com.learnium.RNDeviceInfo does not exist
import com.learnium.RNDeviceInfo.RNDeviceInfo;
                                ^
/Users/lucassus/Projects/Airsorted/housekeeping-app/android/app/src/main/java/com/airsorted/housekeeping/MainApplication.java:31: error: cannot find symbol
                new RNDeviceInfo(),
                    ^
  symbol:   class RNDeviceInfo
  location: class MainApplication
2 errors
:app:compileReleaseJavaWithJavac FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':app:compileReleaseJavaWithJavac'.

Hi, the error message do seems to say that there's a problem with linking.
Did you dry linking again, resetting your cache, removing and reinstalling node_modules, and cast some druidic spells like that ?

I've tried everything and I ran out of all my mana ;)
But it seems that change
implement 'com.facebook.react:react-native:+'
implement "com.google.android.gms:play-services-gcm:$googlePlayServicesVersion"

to
compile 'com.facebook.react:react-native:+'
compile "com.google.android.gms:play-services-gcm:$googlePlayServicesVersion"

...fixes the issue.

Oh, sorry for the inconvenience. This was changed in 0.24.1
You can find the motivations in this PR: https://github.com/rebeccahughes/react-native-device-info/pull/520. Shall I cast rollback ? 🤔

I'm not sure how it will affect other RN versions.
For now I casted downgrade "react-native-device-info": "^0.23.0" in my package.json
Thank you for help!


[BPMSPL-744] GIT related enhancements for scalable workspaces

#[BPMSPL-744] GIT related enhancements for scalable workspaces
First commit: link
JGITFS support for multiple and scalable FS
(prerequisite for workspaces and cloud, all the FS are as lazy as possible)
Also:
[AF-573] Refactoring in order to centralize FileSystem Calls
[AF-569] Cleanup and simplify clustering
Second commit: link
[AF-584] FS New Cloud Watch Service: new watch clustered/cloud watch service using jms (artemis activemq)
[AF-569] Simplify clustering (removal of zookeper and helix need in appformer cluster - still pending the code cleanup)
Wars to play around:
Kie-wb war: https://www.dropbox.com/s/wd74z7781wjpf7d/kie-wb-7.5.0-SNAPSHOT-eap7.war?dl=0
To run the new cluster infra:
Please, someone, validate this :)

Download artemis 2.3.0 and unzip it;

Create your broker: apache-artemis-2.3.0/bin/artemis create mybroker

Enter bin of your broker and run mybroker/bin/./artemis run
@paulovmr get some issues with busy ports, if this is your case, create your broker on step 2 with --port-offset=1000

Deploy some of the wars in standalone

Run jboss first node:
./standalone.sh -c standalone-full.xml -Dorg.uberfire.nio.git.dir=/tmp/testewildfly -Dappformer-cluster=true -Dappformer-jms-url=tcp://localhost:61616 -Dappformer-jms-username=admin -Dappformer-jms-password=admin

Create a new fresh copy of your wildfly and change the standalone full configs in order to prevent shared ports:

  </extensions>...
<system-properties>
       <property name=“org.uberfire.nio.git.daemon.port” value=“9420"/>
       <property name=“org.uberfire.nio.git.ssh.port” value=“8004"/>
   </system-properties>

Run second node

./standalone.sh -c standalone-full.xml -Dorg.uberfire.nio.git.dir=/tmp/testewildfly -Djboss.socket.binding.port-offset=1000 -Dappformer-cluster=true -Dappformer-jms-url=tcp://localhost:61616 -Dappformer-jms-username=admin -Dappformer-jms-password=admin

Load both web apps (one in incognito mode to prevent errai bus clash), open the same asset in both

Start to type and you will see the lock in the asset. If you see it, it works ;)

Depends on [
https://github.com/errai/errai/pull/297
Child PRs
https://github.com/kiegroup/guvnor/pull/530
https://github.com/kiegroup/kie-wb-common/pull/1257
https://github.com/kiegroup/jbpm-designer/pull/686
https://github.com/kiegroup/jbpm-wb/pull/925
Related PRs (not a dependency)
https://github.com/apache/activemq-artemis/pull/1606 (merged)
Still pending:

Remove old cluster infra
Fix Social to new cluster infra

I saw some formating issues, I'll fix it.

I'm going to test this using the instructions you provided with locally setup cluster environment tomorrow and provide some more feedback.

jenkins retest this

@manstis @jhrcek @tomasdavidorg thanks for the review, I'll take a look on this tomorrow.
I found a war clash issue running the wars + artemis on linux but I've fixed.
@tomasdavidorg i've also updated the how-to run this. Can you please give it a try?

btw, on @paulovmr faster machine I got this issue:
18:01:32,110 WARN  [org.apache.activemq.artemis.core.client] (Thread-0 (ActiveMQ-client-global-threads)) AMQ212051: Invalid concurrent session usage. Sessions are not supposed to be used by more than one thread concurrently.
I'll talk tomorrow with apachemq core commiters and check what is the best strategy for this.

jenkins retest this

@manstis @jhrcek @tomasdavidorg do we need something else?

@porcelli can you please take a look?

@ederign please wait until tomorrow. I am preparing testing session with more "cluster nodes" and users connected. I will let you know if we find any problem.

jenkins retest this

Hello @ederign ,
with @tomasdavidorg , @barboras7 and @jomarko we did multi-node business-central cluster testing as promised yesterday, using the following architecture:
1st node running artemis + NFS folder with niogit + eap with business-central
2nd node running eap with business-central, with mounted NFS folder from 1st node
3rd and 4th node connecting via browser to business-central running on node 1 and 2. All 4 of us tried accessing business-central via browser on both nodes and did some basic project editing tasks (creating/editing/deleting rules, data objects etc).
Here's my attempt to draw the architecture. Tomas will also send you more detailed instructions about environment setup if you're interested.

We found two new issues related to this PR

https://issues.jboss.org/browse/AF-895
https://issues.jboss.org/browse/AF-896

Also there is a third error that we can reproduce with business-central before this PR, which we didn't report expecting that it would be fixed in this PR, but it is still present:

https://issues.jboss.org/browse/AF-897

We think #1 should be addressed still in this PR, the other issues can be addressed separately.

One more issue was found:
4. https://issues.jboss.org/browse/AF-898

@tomasdavidorg @jhrcek a new war with the blocker issue fixed. Can you please give it a try? https://www.dropbox.com/s/wd74z7781wjpf7d/kie-wb-7.5.0-SNAPSHOT-eap7.war?dl=0

please jenkins execute full downstream build

@porcelli full downstream build is fine, the tests are not related

trying again...

please jenkins execute full downstream build

please jenkins execute full downstream build

Build finished. 3577 tests run, 6 skipped, 0 failed.

please jenkins execute full downstream build

Build finished. 28498 tests run, 557 skipped, 0 failed.

Build finished. 3571 tests run, 6 skipped, 1 failed.

jenkins retest this


Dart2js generates code for async* which crashes at run-time.

Example code:
Stream<int> foo() async* {
  yield 1;
}

main() {
 foo();
}

crashes with:
.../sdk/lib/_internal/js_runtime/lib/preambles/d8.js:263: TypeError: Closure '_wrapJsFunctionForAsync_closure': type '(int, dynamic) => dynamic' is not a subtype of type '(dynamic, dynamic) => dynamic'
          throw e;
          ^
TypeError: Closure '_wrapJsFunctionForAsync_closure': type '(int, dynamic) => dynamic' is not a subtype of type '(dynamic, dynamic) => dynamic'
    at Object.wrapException (yield2.dart.out:737:17)
    at Object.functionTypeCheck (yield2.dart.out:1225:17)
    at _RootZone.registerBinaryCallback$3$1 (yield2.dart.out:3477:18)
    at _RootZone.registerBinaryCallback$1 (yield2.dart.out:3480:21)
    at Object._wrapJsFunctionForAsync (yield2.dart.out:1872:30)
    at Object.foo (yield2.dart.out:3755:26)
    at main (yield2.dart.out:3788:9)
    at action (.../sdk/lib/_internal/js_runtime/lib/preambles/d8.js:275:31)
    at eventLoop (.../sdk/lib/_internal/js_runtime/lib/preambles/d8.js:258:9)
    at self.dartMainRunner (.../sdk/lib/_internal/js_runtime/lib/preambles/d8.js:276:5)

This is very suspicious since the stream is never even listened to, so there are no user-provided callbacks involved, this is entirely in the code added by the compiler for the async* function.

Was apparently an out-of-date/sync SDK issue. A complete rebuild removed the problem.


Refine documentation with generic metrics

Refine documentation with generic metrics beyond minio specific metrics.
Addresses https://github.com/minio/minio/issues/6140

closing as PR submitted by error on the fork instead of upstream


(wip) cleanup(scripts): cleanup systemd unit in DEB + RPM packages

What type of PR is this?
/kind cleanup

Any specific area of the project related to this PR?
/area build

What this PR does / why we need it:
This PR builds off the work introduced in #1448, which converted Falco's initscripts to a systemd unit.
Currently, when removing, reinstalling, and/or upgrading the Falco package via DEB or RPM, the systemd unit file can be left in an unhygienic state and the user needs to perform a sudo systemctl daemon-reload.
This change re-introduces the falco service cleanup that the DEB and RPM packages perform for it's systemd unit when (re)installing and removing the packages.
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:

This change is in WIP at the moment, as the RPM-equivalent changes have not been committed

Does this PR introduce a user-facing change?: Yes

falco.service systemd unit is now cleaned-up during (re)install and removal via the DEB and RPM packages

@Happy-Dude: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.
:memo: Please follow instructions in the contributing guide to update your commits with the DCO
Full details of the Developer Certificate of Origin can be found at developercertificate.org.
The list of commits missing DCO signoff:

9bf88e0 cleanup(scripts): cleanup systemd unit in DEB installer

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Happy-Dude
To complete the pull request process, please assign mstemm after the PR has been reviewed.
You can assign the PR to them by writing /assign @mstemm in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Hey team, submitting my first PR to Falco.
I didn't file an issue tied to this PR primarily since I discovered this while trying to incorporate Falco into my company's build pipeline. The systemd service unit got into a weird state after installing various builds from source and these changes should help maintain/clean that up.
The changes to the DEB postinst/prerm/postrm scripts were primarily generated by debhelper. I believe a long-term fix would be to have debhelper generate + validate the debian contents, but that introduces another dependency and requires a few changes to the CPack config.
Additionally, there is not debhelper equivalent for Fedora / RPM as far as I know. I'm pretty confident that these can be done by translating what debhelper generated to their systemctl equivalents, but I'll need to build a RPM package to test on a Fedora VM. I can get to setting all that up sometime later this/next week.
Please let me know any of your thoughts or concerns and I'll do my best to address them!

Hi @Happy-Dude, thank you for the contribution! As first steps, I'd ask you to un-draft your PR and to sign-off your commit, so that all the checks can proceed.

Thanks Jason, I've

changed the status of the PR from draft to ready for review
amended my commit with the signed-off message

Appreciate the guidance!

/milestone 0.33.0

Apologies for the delay in working on the RPM-equivalent series of changes.
I'll review https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_systemd to see if there are any tidbits; thus far, it seems like calling systemctl equivalents are sufficient.

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.
:memo: Please follow instructions in the contributing guide to update your commits with the DCO
Full details of the Developer Certificate of Origin can be found at developercertificate.org.
The list of commits missing DCO signoff:

bb382f7 Merge branch 'falcosecurity:master' into installer-systemd-cleanup

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Happy-Dude
Once this PR has been reviewed and has the lgtm label, please assign mstemm for approval by writing /assign @mstemm in a comment. For more information see:The Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Happy-Dude: Adding label do-not-merge/contains-merge-commits because PR contains merge commits, which are not allowed in this repository.
Use git rebase to reapply your commits on top of the target branch. Detailed instructions for doing so can be found here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.
:memo: Please follow instructions in the contributing guide to update your commits with the DCO
Full details of the Developer Certificate of Origin can be found at developercertificate.org.
The list of commits missing DCO signoff:

c7a2c4d First pass at RPM script cleanup

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.
:memo: Please follow instructions in the contributing guide to update your commits with the DCO
Full details of the Developer Certificate of Origin can be found at developercertificate.org.
The list of commits missing DCO signoff:

d82d695 cleanup(scripts): cleanup systemd unit in RPM installer

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Hey team,
I just committed the RPM equivalent changes and this should be ready for review.
I tired my best to convert the deb-systemd-helper commands to straight systemctl equivalents. Additionally, I tried to incorporate RPM scriptlets where applicable. To understand the $1 value, please see the following references and table:

https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_systemd
https://docs.fedoraproject.org/en-US/packaging-guidelines/DefaultServices/
https://wiki.networksecuritytoolkit.org/index.php/RPM_Quick_Reference#Systemd_Service_Control
https://github.com/andrew-hardin/cpack-systemd-demo

install
upgrade
uninstall

%pretrans
$1 == 1
$1 == 2
(N/A)

%pre
$1 == 1
$1 == 2
(N/A)

%post
$1 == 1
$1 == 2
(N/A)

%preun
(N/A)
$1 == 1
$1 == 0

%postun
(N/A)
$1 == 1
$1 == 0

%posttrans
$1 == 1
$1 == 1
(N/A)

I am not 100% confident that these are outright correct; I'm doing some rudimentary testing on a Fedora VM and would appreciate any extra validation and testing from fellow contributors 🙏
Let me know any questions or concerns and how I can facilitate better!

Hey @Happy-Dude
Is this PR still a WIP or ready to be reviewed?

A few of the situations I'd like to make sure are in an okay systemd situation:

upgrade falco from old version to new version -- is service enabled/started and if the service is already running, does it refresh to the new version (condrestart) ?
when uninstalling the new version, the falco service is "masked" -- does the service get "unmasked" when installing again?

Thanks for testing 🙏

ei @Happy-Dude thank you for this! I will take a look in the next few days :rocket:

Closing and reopening to trigger the CI
/close

@leogr: Closed this PR.

In response to this:

Closing and reopening to trigger the CI
/close

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/reopen

@leogr: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Happy-Dude
Once this PR has been reviewed and has the lgtm label, please assign leogr for approval by writing /assign @leogr in a comment. For more information see:The Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/help

@Happy-Dude So, i finally made some tests:
Old behavior
Install:

falco.service is not started neither enabled

Uninstall:

falco.service is not masked neither daemon-reload is called, so that the systemd unit remains in a cached state
if falco is uninstalled while falco is running, rmmod fails

New behavior
Install:

falco.service is gracefully started and enabled, so that falco is immediately running (if either a driver could be downloaded from download.falco.org, or kernel-headers are installed and it is able to auto-build the driver)

Uninstall:

falco.service unit is masked and daemon-reload is called; the systemd state is consistent
if falco is uninstalled while falco is running, rmmod fails

All in all, this is a nice improvement!
Do you thing we can do anything about:

if falco is uninstalled while falco is running, rmmod fails
?
Thanks!

Thanks @FedeDP for the feedback! The made the changes accordingly and hope everything works as expected.

LGTM label has been added.  Git tree hash: 41a9557294ffa793e0ec462d0837281c83002429

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: FedeDP, Happy-Dude, jasondellaluce
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [FedeDP,jasondellaluce]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Can you elaborate how this frameworks works in FreeCAD?

Perhaps you'd be interested in showcasing it to the FC community in the User Showcase subforum ?

Actually I am in the process of separating the FreeCAD part of the code, which is for generating sets of models describing geometric parameter sweeps off a base model. From each model STL files are saved. Each part of the model which will have a different material in the final electromagnetic simulation has it's own STL.
The separated Frontend code is here: https://github.com/alunmorgan/EM_CAD_frontend
The rest of the framework ingests the STLs runs electromagnetic simulations on the various models. Analyses the simulation results, and also collates, and presents them in a more easily digestable form.
What is involved in showcasing?

Cool!
Explaining how FreeCAD is involved in your project. Screenshots, What have you so far, Roadmap of future developments, link to a thread where users can offer feedback.
Stuff like that.


implement min max scalar function

This is related to issue #144.  Currently the name of the scalar functions min and max are conflicting with the aggregated functions min and max. I am using min_arr and max_arr instead and wanted to get your input on what we can do to keep both with the same name. What comes to my mind is adding conditional logic inside AggFunc::Min/Max.

@brayanjuls The need to change the function resolution code to allow function overloading. That is, the number of arguments should be a factor in which function we pick.

@brayanjuls The need to change the function resolution code to allow function overloading. That is, the number of arguments should be a factor in which function we pick.

I thought rust did not support function overloading by the number of parameters. I am going to investigate it and implement it. Thanks.

@brayanjuls Rust doesn't support that. But the point was that FromStr trait for Func should map max to aggregate or scalar depending on how many arguments got passed to it. That may be not possible with the FromStr trait so we might want to introduce a resolve_function(name, arg_count) helper somewhere.


Do you support nested data?

If there is nested structure in the data, how will it be transferred into csv?
var data = [{
name: "name1",
nested: {
nestedName: "nestedName1"
}
}];

Any suggestions for this issue?

probably handle it like this converter does:
https://json-csv.com/

have you guys found a workaround for this?


Nextcloud uploading files >64MB fails

This is basically the same issue as https://github.com/storj/storj/issues/3765 but that one was created with the old gateway so I thought I'll open a new ticket in this repository with the information from the current release rc6:
If i try to upload a file with a size bigger than the segment size of 64MB then the upload fails with this error message shown in Nextcloud GUI and the GUI just remains in the state of an unfinished upload:
Error when assembling chunks, status code 504

(This also happens with files smaller than 64MB but those still do get uploaded correctly and are there after a refresh of the gui)
According to netdata statistics the file still gets uploaded when the message is shown. However, after the upload is done, it seems like nextcloud tries to delete the file again and the gateway shows this warning:
2020-03-11T16:18:03.751+0100    WARN    Failed deleting object  {"path": "test-bucket/yEd-<IP_ADDRESS>_with-JRE13_64-bit_setup.exe", "error": "object not found: metainfo error: object not found: key not found: \"50e7dea3-3a19-417d-b7a5-57eff1d62a79/l/test-bucket/\\x02پk-S\\xafV\\xf5\\xa1\\xbe\\xab\\x92\\xd8\\x03\\xbbc!\\xab\\xaa\\xfd\\xc1\\x95 j\\xf5x\\xc8>C\\r\\x99\\b\\xaf\\xacD\\xcc\\xd3\\xc7Z\\xc8\\xf8LP\\xfe\\x02\\x9aެ\\v\\xb7\\xa87\\xaff_ݵ\\x89\\xcc\\x01\\x02\\xfa\\xfb\\x01\\x02\\x958P\\xf06\\xd9\"", "errorVerbose": "object not found: metainfo error: object not found: key not found: \"50e7dea3-3a19-417d-b7a5-57eff1d62a79/l/test-bucket/\\x02پk-S\\xafV\\xf5\\xa1\\xbe\\xab\\x92\\xd8\\x03\\xbbc!\\xab\\xaa\\xfd\\xc1\\x95 j\\xf5x\\xc8>C\\r\\x99\\b\\xaf\\xacD\\xcc\\xd3\\xc7Z\\xc8\\xf8LP\\xfe\\x02\\x9aެ\\v\\xb7\\xa87\\xaff_ݵ\\x89\\xcc\\x01\\x02\\xfa\\xfb\\x01\\x02\\x958P\\xf06\\xd9\"\n\tstorj.io/uplink/private/metainfo.(*Client).BeginDeleteObject:662\n\tstorj.io/uplink/private/storage/streams.(*streamStore).Delete:427\n\tstorj.io/uplink/private/storage/streams.(*streamStore).cancelHandler:531\n\tstorj.io/uplink/private/storage/streams.(*streamStore).Put.func1:106\n\tstorj.io/uplink/private/storage/streams.(*streamStore).Put:223\n\tstorj.io/uplink/private/storage/streams.(*shimStore).Put:54\n\tstorj.io/uplink/private/stream.NewUpload.func1:43\n\tgolang.org/x/sync/errgroup.(*Group).Go.func1:57"}

And nextcloud shows this error log:
[files_external] Error: Aws\S3\Exception\S3Exception: Error executing "CopyObject" on "http://localhost:7777/test-bucket/yEd-<IP_ADDRESS>_with-JRE13_64-bit_setup.exe"; AWS HTTP error: Client error: `PUT http://localhost:7777/test-bucket/yEd-<IP_ADDRESS>_with-JRE13_64-bit_setup.exe` resulted in a `404 Not Found` response:
<?xml version="1.0" encoding="UTF-8"?>
<Error>NoSuchKey<Message>The specified key does not exist.</Message> (truncated...)
 NoSuchKey (client): The specified key does not exist. - <?xml version="1.0" encoding="UTF-8"?>
<Error>NoSuchKey<Message>The specified key does not exist.</Message><Key>yEd-<IP_ADDRESS>_with-JRE13_64-bit_setup.exe</Key><BucketName>test-bucket</BucketName><Resource>/test-bucket/yEd-<IP_ADDRESS>_with-JRE13_64-bit_setup.exe</Resource><RequestId>15FB48EEA0E4BA69</RequestId><HostId>fd7b4035-a365-4eea-9163-c9863d7967c8</HostId></Error> at <<closure>>

 0. /var/www/nextcloud/3rdparty/aws/aws-sdk-php/src/WrappedHttpHandler.php line 97
    Aws\WrappedHttpHandler->parseError("*** sensitive parameter replaced ***", GuzzleHttp\Psr7\Request {}, Aws\Command {}, [])
 1. /var/www/nextcloud/3rdparty/guzzlehttp/promises/src/Promise.php line 203
    Aws\WrappedHttpHandler->Aws\{closure}("*** sensitive parameters replaced ***")
 2. /var/www/nextcloud/3rdparty/guzzlehttp/promises/src/Promise.php line 174
    GuzzleHttp\Promise\Promise::callHandler(2, "*** sensitive parameter replaced ***", [GuzzleHttp\Prom ... }])
 3.  }])
17.  "}, Sabre\HTTP\Response {})
32. /var/www/nextcloud/3rdparty/sabre/event/lib/EventEmitterTrait.php line 105
    call_user_func_array([Sabre\DAV\CorePlugin {},"httpMove"], [Sabre\HTTP\Requ ... }])
33. /var/www/nextcloud/3rdparty/sabre/dav/lib/DAV/Server.php line 479
    Sabre\Event\EventEmitter->emit("method:MOVE", [Sabre\HTTP\Requ ... }])
34. /var/www/nextcloud/3rdparty/sabre/dav/lib/DAV/Server.php line 254
    Sabre\DAV\Server->invokeMethod(Sabre\HTTP\Reque ... "}, Sabre\HTTP\Response {})
35. /var/www/nextcloud/apps/dav/lib/Server.php line 319
    Sabre\DAV\Server->exec()
36. /var/www/nextcloud/apps/dav/appinfo/v2/remote.php line 35
    OCA\DAV\Server->exec()
37. /var/www/nextcloud/remote.php line 165
    require_once("/var/www/nextcl ... p")

MOVE /remote.php/dav/uploads/kevin_koeck/web-file-upload-59495c93aab61c15d58f986efdb146fe-1583939769325/.file
from <ip> by kevin_koeck at 2020-03-11T15:18:03+00:00

This seems to be slightly different than how it was with the old gateway.
Now there is no file in the bucket, while with the old gateway there was a file of 0B instead of the original size.
But since the original issue in storj/storj is tracked in your internal jira, you might already be aware of this current state.

@kevinkk525 I spend some time today reproducing and investigating the issue. It seems there are two issues:

For some reason, after uploading the object, NextCloud requests CopyObject with the same source and destination, i.e. it tries to overwrite the object over itself. I think it tries to encrypt the uploaded object with S3 server-side encryption. The S3 Gateway didn't handle this situation well, which resulted in destroying the object, especially if it was a big one.
Larger uploads seem to take longer time than the PHP max execution time, which causes the Error when assembling chunks error.

We released gateway v1.0.4 to resolve the first issue: https://github.com/storj/gateway/releases/tag/v1.0.4
For the second issue, you should take a look at how to increase the max execution time in your PHP configuration. Here is an article that talks about this: https://help.nextcloud.com/t/error-when-assembling-chunks-status-code-504/56751

Thank you! This version works great! No problems uploading multiple big files.
The gateway is really useful now :)
Thanks for the link about the issue 2, that is indeed on the nextcloud side only.


Updating breaking changes to include 2 WCF appcompat changes

Adding two WCF and 1 networking application compatibility changes
Summary

Based on the PRs submitted below, the tool regenerated the documentation.

https://github.com/Microsoft/dotnet/pull/419
https://github.com/Microsoft/dotnet/pull/417

This also changes all the links that have https://doc.microsoft.com/dotnet/articles... to their relative paths in the repository.

Suggested Reviewers
@rpetrusha

@rpetrusha I've fixed the issue and it builds now


Advanced recipie NBT append or replace

If you already have this feature and I missed it, I apologize.   I am trying to define crafting recipes that either replaces or append NBT data from one of the input items to the output.
Example:
recipe.addShapeless(minecraft:diamond_sword.appendTag(allEnchanments),
[minacraft:golden_sword.withTag(allEnchantments), minecraft:diamond_block]);
recipe.addShaped(minecraft:diamond_sword.replaceTag(allEnchanments(1,1)),
[null, null, null],
[null, minacraft:golden_sword.withTag(allEnchantments), minecraft:diamond_block],
[null, null, null]
]);
Where the (1,1) is the row and column of the crafting table counting [0-2 x 0-2] rows & columns.

would be nice if rocky tweaks anvil recipes supported this also.

That is already possible in the form of recipe functions:
https://docs.blamejared.com/en/#Vanilla/Recipes/Crafting/Recipe_Functions/
You can see an example in here:
https://github.com/CraftTweaker/CraftTweaker-Examples/blob/master/crafttweaker/crafting table recipes/recipe functions/enchantment_transfer/enchantment_transfer.zs


Term change suggestion SDG1.a - [remittance]

SDG:1
Target & phrase: a
Suggested term/change: consider adding"remittance" to financial terms, perhaps combined with "inflow" or similar
(from the abstract:
"we find that financial development and remittance inflows help ameliorate poverty conditions in developing countries. In addition, we find that remittances substitute for financial development in the poverty-alleviating process.")
Reason: article found in Elicit but not in our search that seems relevant: 10.1016/J.JECONBUS.2017.12.001

We decided this was not relevant since remittances are about individual transfers of money, while the target is about larger scale (international/commercial) investment.


publisher-github: Asset name with spaces doesn't match already uploaded asset name

Preflight Checklist

[x] I have read the contribution documentation for this project.
[x] I agree to follow the code of conduct that this project follows, as appropriate.
[x] I have searched the issue tracker for a bug that matches the one I want to file, without success.

Issue Details

Electron Forge Version:

 v6.0.0-beta.51

Expected Behavior

publisher-github correctly detect already published asset.
Actual Behavior

publisher-github doesn't match already uploaded asset name.
To Reproduce

Publish asset with spaces in name My App.dmg
Try to publish second time

{"resource":"ReleaseAsset","code":"already_exists","field":"name"}

Additional Information
The following check is not valid because: GitHub renames asset filenames that have special characters, non-alphanumeric characters, and leading or trailing periods.
https://github.com/electron-userland/electron-forge/blob/a2de8ea5ec7d66725cd20ef8dabbd727843b52a3/packages/publisher/github/src/PublisherGithub.ts#L97-L99
<!--
Add any other context about the problem here.

For example:
* Console output when you run your `electron-forge` command with the environment variable
  `DEBUG=electron-forge:*`. (Instructions on how to do so
  [here](https://www.npmjs.com/package/debug#usage)). Please include the stack trace if
  one exists.
* Command line arguments you are passing to `electron-forge` (e.g.,
  `electron-forge make --not-a-real-flag`)
* The `config.forge` data in `package.json` or `forge.config.js` in use
* A failing minimal testcase (with a link to the code) or detailed steps to reproduce the problem.
  Using `electron-forge init` is a good starting point, if that is not the source of your problem.

Ideally something like octokit would have a way for us to sanitize the asset filenames so we can do this check better.

@malept Github documentation suggests to contact support https://github.com/contact

GitHub renames asset filenames that have special characters, non-alphanumeric characters, and leading or trailing periods. The "List assets for a release" endpoint lists the renamed filenames. For more information and help, contact GitHub Support.

octokit sends the name to API as is.


updated logo

Closes
Closes #1087

Description

link updated
Screenshots

Note to reviewers

Checklist:

[x] I have linked the PR to the correct issue.
[x] I have read the Contribution Guidelines
[x] I have built and tested the changes, and they do not break or show any errors.

@Vaishnavi-Patil2211 please review the pr

@Vaishnavi-Patil2211


Adding recv_into support as for issue #71

Coverage increased (+0.0009%) to 99.824% when pulling 635173e566a8bdbf4567c18fbb080bbfc7a64d22 on recv-into into 7b6bbaa8cd7acc439bd6c885c7d87290f4aecd30 on master.

Coverage increased (+0.0009%) to 99.824% when pulling 635173e566a8bdbf4567c18fbb080bbfc7a64d22 on recv-into into 7b6bbaa8cd7acc439bd6c885c7d87290f4aecd30 on master.


Add grouping of created photos by date

Task Summary
📅 Due date: mid-Feb
🎯 Success criteria: Group photos in create-output folder by date.
Please add additional date sub-directory.
create-output/jane-doe/2022-01-24/...
                      /2022-01-25/...
                      /2022-02-11/...
create-output/mitra-moe/2022-01-24/...
                       /2022-01-25/...

To Do

[ ] Add feature
[ ] Deploy this for BCN instance

Are we ok adding this behavior as the default for the server? Or do we want this to be somehow configurable or switchable?

I think default is ok.


BUG: Text in Book exchange Hub is misaligned

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
The line of text in Book exchange Hub is going out of the margin.
Here's a screenshot,

Hello @anuragverma108
Please assign me this issue under GSSOC'24.
Thank You!
Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

@kashvi9 Assigned!
Make sure to attach before & after screenshots in your PR. Also, star the repo before working on it. While creating your PR, ensure you pull all existing changes beforehand to avoid conflicts.
Happy open-source contributing!

@kashvi9 Assigned! Make sure to attach before & after screenshots in your PR. Also, star the repo before working on it. While creating your PR, ensure you pull all existing changes beforehand to avoid conflicts. Happy open-source contributing!

@anuragverma108
Sir, I think this issue has already been solved.

Do you want me to do any other changes in this?


Primitives support

Here is a list of the primitives that I plan to support. Items marked with "?" are aspects I am still unsure how to implement:

[x] Lines
[x] Rectangle

[ ] Rounded corners?

[x] Circles
[x] Ellipses
[x] Triangles
[ ] Polygons
[ ] Polylines
[ ] Bézier curves
[ ] Paths? (https://developer.mozilla.org/en-US/docs/Web/SVG/Tutorial/Paths)
[ ] Drawing text

All primitives should support attributes like stroke size, stroke color, and fill color.
Anti-aliasing should be enabled by default.

I initially intended to support stroke_size from the beginning,
but I have been struggling to find a suitable approach for drawing thick lines.
I have tried using a polygon and an edited version of Bresenham's algorithm,
but the lines look different from their SVG counterpart.
I still need to research more on how SVG renders thick lines.


AS20HPL1HRA and hOn app

AS20HPL1HRA air conditioner mentioned as supported device, but I can not add it to hOn app. The manual of AC says that it works with EVO app (and I added it there), but when I try to add it to hOn app, it says that serial number is wrong.
(there is no any problem with hOn app on my side - two other devices are added there successfully)
Since it is defined as supported by addon, I would like to understand how it was done.

@Andre0512 could you please help me with this? Who reported AS20HPL1HRA as supported device?

Hi, sorry I don't know who added it (it was reported anonymously). I remove it from supported list until someone can prove otherwise...


Remix tests greaterThan() & lesserThan() implementation

Implement greaterThan() & lesserThan() functionality for remix-tests

great!
would it be possible to add the list of available methods for testing in https://github.com/ethereum/remix/blob/master/docs/unittesting_tab.md

Available methods
Supported types

ok()
bool

equal()
uint, int, bool, address, bytes32, string

notEqual()
uint, int, bool, address, bytes32, string

greaterThan()
uint, int

lesserThan()
uint, int

@yann300 @iurimatias Does this table look good enough to explain available methods ? I think more appropriate place for this table should be https://github.com/ethereum/remix/blob/master/remix-tests/README.md. Let me hear your suggestions.

yep that also need to be pushed to README.md


Configuration cache should have a way to exclude known ignorable properties

Expected Behavior

Currently, configuration cache is sensitive to just about everything. On one hand I understand this, but on the other it's often invalidating on irrelevant things that we don't consume in our build. There should be a way to indicate to gradle that some env vars or properties are never relevant.
Current Behavior

It will fail on unexpected changes, such as this
Calculating task graph as configuration cache cannot be reused because system property 'jnidispatch.path' has changed.

I don't know what that property is or why it's changing, we're not using it. There are new APIs for this in 7.5-rc-1, but they pertain to cases where one would intentionally access certain props and vars

Two new options are now available to mitigate that. For simpler use cases, there are the Provider-based APIs to access system properties or environment variables with names starting with some prefix. Advanced processing, like filtering names with regular expression, can be done inside a custom ValueSource implementation. Reading a file, an environment variable, or a system property no longer adds a build configuration input inside the implementation of the ValueSource. The value of the ValueSource is recomputed each time the build runs, and the configuration cache entry is only invalidated if the value changes.

Context

See above
Steps to Reproduce

Unknown, sort of the reason it's a problem
Your Environment

Build scan URL:

Another case where this becomes problematic – we capture system properties about gradle-profiler scenarios/phases for build scans so we can filter by them accordingly, but must forfeit configuration cache in gradle-profiler runs as a result because we cannot indicate they are just for build scans only

// -Dscan.tag.BENCHMARK=ignored
System.getenv("GRADLE_BENCHMARK")?.let {
  tag("BENCHMARK")
  value("BenchmarkScenario", System.getProperty("gradleBenchmarkScenario"))
}
// gradle-profiler injected properties
// Learned from https://github.com/gradle/gradle-profiler/issues/323#issuecomment-788745082
System.getProperty("org.gradle.profiler.phase")?.let {
  value("ProfilerPhase", it)
}
System.getProperty("org.gradle.profiler.number")?.let {
  value("ProfilerNumber", it)
}
System.getProperty("org.gradle.profiler.step")?.let {
  value("ProfilerStep", it)
}

Another use case:
We use Gitlab CI and inject a CI_JOB_TOKEN that is present for the runners. This is used to authenticate against a private maven repository.
The effect of this is that on the CI, the config cache is never applied.

If you are calling System.getProperties() during config or any of your plugins are calling System.getProperties() it could trigger this issue and Gradle will see that all system properties where read during config.
For example common-custom-user-data-gradle-plugin before 1.6.3 had a call to System.getProperties()
The System.getProperties() call was removed here: https://github.com/gradle/common-custom-user-data-gradle-plugin/commit/7d9f4372e9ee99fc85de9aa7bb414afdd1dc00aa#diff-5b3d8f7156853c4ccba4274026d005962fd9ec2e8d92c944867ebf0dc5146f25L88
When you get an unexpected config cache miss due to a system property read, the HTML report will tell you which plugin or script read the system property (if you expand everything).

Sorry for the late reply.
This feature request is in the backlog of the relevant team and is prioritized by them.

So far we see some use cases where suppressing an input can be a viable option:

Legacy configuration code that cannot be easily changed, but its inputs are benign (e.g. it enumerates system properties to find just one). We're reluctant to provide a blanket option of excluding an input everywhere, but some scope function to call the offending code is not out of question. So far, a ValueSource or a WorkAction may serve as such a function sometimes, but they have limitations.
Tokens and toggles of various sorts that are used at configuration time, but do not really affect the resulting work graph, e.g. a system property that affects configuration-time logging - it is fine to skip the logs when CC entry is reused.
Credentials (e.g. short-lived access keys) for dependencies that are needed when resolving the dependencies at store time but do not affect the work graph itself. These are tracked in #24203.
Running some work in parallel with the configuration phase, e.g. monitoring thermal throttling.

We are working on providing ways to address these use cases.
There are case where suppressing inputs is not a good solution:

overzealous build logic written without consideration for inputs in general - this is better to be rewritten with the new APIs Gradle provides.
tasks that can only be configured eagerly, like setting system properties for the Test task - should be addressed by the migration to Provider API in Gradle 9, and suppressing inputs here is not safe anyway.
supplying eager values in build scans - buildscan.background and buildscan.buildFinished can help there.

We also recognize that sometimes it is hard to pinpoint an exact input, especially when it is accessed by a library code. Several improvements are considered here:

https://github.com/gradle/gradle/issues/30305
https://github.com/gradle/gradle/issues/23634
https://github.com/gradle/gradle/issues/26019

We are also keen on this feature. In our case it's the credentials case you mention above.
In our case it's the GOOGLE_APPLICATION_CREDENTIALS which is a file path containing a token regenerated for each build. This is generated at a different path for each build.
Someway to manually exclude environmental variables from the input sources check would be ideal.


Conda package

Comment:
Is there a reason to have a conda-forge package for this, given getdist is pure python?
If it's going to cause conflicts after updates, it would be nice to at least have it set to auto-merge so it updates quickly and automatically.
"packaging" should also be added to meta.yaml as reported by the autobot. Perhaps you could also add me to maintainers, so I can if necessary fix updates myself.
Thanks,
Antony

Hi Antony,
Regarding our packaging for https://github.com/LSSTDESC/firecrown, we exclusively utilize conda-forge for all prerequisites due to the presence of compiled extensions in many of them. We avoid mixing with pip for two reasons: it complicates consistent environment updates, and package updates may introduce additional prerequisites with compiled code.
To address this, we have created conda-forge packages for all (almost all) prerequisites, including this one. We've designated this package as noarch since it lacks any architecture-dependent code.
I will add you as a maintainer so that you can implement any necessary updates or modifications.
Best,
Sandro

@cmbant I just added you as a maintainer, tell me if you have further questions so I can close this issue.

Thanks


Chrome browser become unresponsive after we embeded the treeview components into kendo grid's column template.

Hi Support,
Sample code as below, change loop to new Array(200).
<button>AH</button>
<input type="checkbox" *ngFor="let x of loop">
<div style="display:none">
<tree-root [nodes]="nodes" [options]="options" *ngFor="let x of loop"></tree-root>
</div>
And there is a huge number of mousedown and keydown attached to every single clickable element.

How can i get rid of these if i not intend to use ActionMapping?
Thank you

That's strange, mousedown on body should only be set once per tree.
I don't see this problem in the demo:
https://rawgit.com/500tech/angular2-tree-component/master/example/cli/dist/#/
Can you share plunkr or something or try to debug it to understand why it happens in your configuration?

Closing this issue due to inactivity. Please open a new issue if the problem still exists.


Add Refresh project list button to link menu

Firebottle was following the tutorial and got to the link step without a project. Once created he had to awkwardly escape out of the link dialog and then re-link.
Add a refresh button to the link menu to re-pull the projects

Fixed in linked commit


Update Set-SPOTenant.md

Removed "In Development" notes from:
[-ExternalUserExpirationRequired ]
[-ExternalUserExpireInDays ]

Docs Build status updates of commit f8da1ad:
:clock10: Full build: the average full build time is 12 min(s) 25 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit f8da1ad:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

sharepoint/sharepoint-ps/sharepoint-online/Set-SPOTenant.md
:white_check_mark:Succeeded
View (sharepoint-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 1758128:
:clock10: Full build: the average full build time is 12 min(s) 25 sec(s), this is based on the last 1000 build(s) for this repository.

Replaced with: https://github.com/MicrosoftDocs/office-docs-powershell/pull/5109

Docs Build status updates of commit 1758128:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

sharepoint/sharepoint-ps/sharepoint-online/Set-SPOTenant.md
:white_check_mark:Succeeded
View (sharepoint-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


docs bug with "entryFileName"

What package is your question related to?
typedoc-plugin-markdown
What would you like to ask?
On this page:
https://typedoc-plugin-markdown.org/plugins/docusaurus/options
It says that it uses "entryFileName": "index.md".
However, "entryFileName" is not documented on the list of options:
https://typedoc-plugin-markdown.org/plugins/docusaurus/options
It is also not a TypeDoc option:
https://typedoc.org/options/
Is this a bug in the docs?

This is a typedoc-plugin-markdown option https://typedoc-plugin-markdown.org/docs/options/file-options#--entryfilename.
Sorry it probably is a bit confusing having options documented in separate places. There is a link to these options at the top of the options page but it should probably be made more explicit.

Oh sorry, I missed that. Thank you for the quick reply!

I will review the docs and try to make clearer. This is all useful feedback.


[FLINK-3756] [state] Add state hierarchy to CheckpointCoordinator

This commit introduces a state hierarchy for the StateForTask objects kept
at the CheckpointCoordinator. Task states are now grouped together if they
belong to the same ExecutionJobVertex. The StateForTask objects are now
stored in so called StateForTaskGroup objects. The StateForTaskGroup object
can also store the key group state handles associated to a ExecutionJobVertex.

Very nice, Till! I like where this is going and am really looking forward to the follow up changes.
As this is work in progress, the most important changes are in the restore methods of the checkpoint/savepoint coordinator and those look good to me.
The Travis test failures are unrelated, so +1 to merge this.

Thanks for the review @uce. I've addressed your comments. Will merge this PR then.

Failing test is unrelated. Merging.

Unrelated, but shouldn't we consolidate the code in SavepointCoordinator.restoreSavepoint() and CheckpointCoordiantor.restoreLatestCheckpointedState?

I agree that this is duplicated code. As far as I can tell, this was introduced in order to output different error messages in the savepoint restore and the checkpoint restore case and to support the allOrNothingState checkpoint recovery. The latter seems to be only introduced for testing purposes.
Independent on our decision, I think this should be addressed as a separate issue.

Also, we'll still call StateForTask like that, even though it's more like an operator state? And KvStateForTasks has the s at the end because it is theoretically for several tasks/subtasks/operators? Which wouldn't really work, right? 😅

Also, I think we should rename the task business classes to accurately reflect what they are for. But this can be done once the rest of the state reworking is in.

👍 good to merge, then

I agree. Our terminology is a mess an should be cleaned up. Will do this as part of my other refactorings.

Yes, it was introduced to give detailed error message, which were helpful in the past. We can certainly consolidate this.


For anyone interested in the format of the transaction

As I didn't find an obious entry point on how the data has to look like, and as I'm too new as to have concluded it by pure thought, I went through the hassle of debugging it to figure it out:
When you want to send a broadcast, you need:
ByteType``ByteVarintSizeKey``BytesVarintKey``BytesKey``ByteVarintSizeValue``BytesVarintValue``BytesValue
With ByteType one of

0x01 for a set
0x02 for a remove
for Check/AppendTx and one of
0x01 for 'by Key'
0x02 for 'by Index'
for Query

In the end, it should have been obvious by looking at merkleeyes/app/app.go as it uses the generic GetByteSlice() from go-wire after switching on the initial Tx-Type byte.
I apologize, if this is documented elsewhere. Just wanted to leave this as a note for other newcomers in case they get stuck as I did :)
PS: thanks for this demonstrator app!

thanks for this. adding to readme now!


Follow-up: Improve getFilteredCardList function

Explanation of Change

Follow-up of https://github.com/Expensify/App/pull/52871: Improve getFilteredCardList function
Fixed Issues

$ https://github.com/Expensify/App/issues/52820
PROPOSAL: N/A
Tests

[x] Verify that no errors appear in the JS console

Workspace A - 1 member, multiple cards to assign
Workspace B - several members, 1 card to assign (if you don't have a workspace with only 1 card you can change this code from)
Workspace C - 1 member, 1 card to assign
Workspace D - several members, several cards to assign
Make sure to check both - custom and direct feeds.
Workspace A

Go to Workspace A -> Company Cards -> Assign Card
Verify that the Assignee step is skipped, you're on the Card selection step
Go to members -> member details -> New Card
Verify that the Assignee step is skipped, you're on the Card selection step (the behavior was the same before, it should not change)

Workspace B

Go to Workspace B -> Company Cards -> Assign Card
Verify that after choosing Assignee the Card selection step is skipped - you land on the Transaction Start step
Go to members -> member details -> New Card
Verify that the Assignee and Card Selection steps are skipped - you land on the Transaction Start step

Workspace C

Go to Workspace C -> Company Cards -> Assign Card
Verify that the Assignee and Card Selection steps are skipped - you land on the Transaction Start step
Go to members -> member details -> New Card
Verify that the Assignee and Card Selection steps are skipped - you land on the Transaction Start step

Workspace D

Go to Workspace D -> Company Cards -> Assign Card
Verify that you land on the Assignee step like before
Go to members -> member details -> New Card
Verify that only the Assignee is skipped - you land on the Card selection step

Offline tests

Same, as in the Tests section.
QA Steps

[x] Verify that no errors appear in the JS console

Same, as in the Tests section.
PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

MacOS: Chrome / Safari

https://github.com/user-attachments/assets/290500cb-823a-4b77-b890-d12d16c9df80
https://github.com/user-attachments/assets/b9494d9f-d685-48ca-9811-5912f36ecc14
https://github.com/user-attachments/assets/0d5768a0-0129-4b52-adf7-23612a4aa456
https://github.com/user-attachments/assets/fb572d1d-854a-4c4a-937e-96b57d53355a

Note for testing if anyone needed: Mock Direct feed
Onyx.set(`sharedNVP_private_domain_member_18600095`, {
    settings: {
        oAuthAccountDetails: {
            'oauth.chase.com': {
                accountList: ['BILT WORLD ELITE MASTERCARD 2602'],
                credentials: 'ASDF',
                expiration:<PHONE_NUMBER>,
            },
        },
        companyCards: {
            'oauth.chase.com': {
                asrEnabled: false,
                forceReimbursable: 'force_no',
                liabilityType: 'personal',
                preferredPolicy: '',
                reportTitleFormat: '',
                shouldApplyCashbackToBill: true,
                statementPeriodEndDay: 1,
                uploadLayoutSettings: [],
            },
        },
    },
});

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

https://github.com/user-attachments/assets/1c6c8174-42d9-46df-b995-1e9c0a2ccefc

iOS: Native

https://github.com/user-attachments/assets/8cb9aedc-0def-4838-ab59-1987b400da56

iOS: mWeb Safari

https://github.com/user-attachments/assets/3b6acb52-a73b-4e00-9750-073183fae233

MacOS: Chrome / Safari

https://github.com/user-attachments/assets/514b62b4-3008-462f-a405-b9932e2640f4

MacOS: Desktop

https://github.com/user-attachments/assets/4cdd4446-e88a-4d3b-890a-140555b30814

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Go to Workspace B -> Company Cards -> Assign Card
Verify that after choosing Assignee the Card selection step is skipped - you land on the Transaction Start step
Go to members -> member details -> New Card
Verify that the Assignee and Card Selection steps are skipped - you land on the Transaction Start step

I think this is intended to be that we select assignee (as there are multiple), but skip card selection. Tested with that in mind. Works for both direct and custom feeds!

Workspace C
Go to Workspace C -> Company Cards -> Assign Card
Verify that the Assignee and Card Selection steps are skipped - you land on the Transaction Start step
Go to members -> member details -> New Card
Verify that the Assignee and Card Selection steps are skipped - you land on the Transaction Start step

Works for both direct and custom feeds!

Workspace D
Go to Workspace D -> Company Cards -> Assign Card
Verify that you land on the Assignee step like before
Go to members -> member details -> New Card
Verify that only the Assignee is skipped - you land on the Card selection step

I think this is intended to say no steps are skipped. Tested as such. Custom feed case works here. I don't have a direct feed with multiple cards.

https://expensify.slack.com/archives/C06ML6X0W9L/p1733164288712939


Use ext directive instead of custom extra directive

The float executor currently uses a custom process directive extra to apply float CLI options to specific processes:
process FOO {
  extra = '--option value'
}

However, this is using a hack by setting a directive with the equals sign. It's an unfortunate aspect of the current Nextflow DSL that this syntax happens to be allowed, but only the following syntax is intentionally supported:
process FOO {
  extra '--option value'
}

This is how users normally specify directives, but if they try this with extra then it will fail, because it is not defined as a directive in Nextflow.
I ignored it for a while because I see the value of this directive and couldn't provide an "official" way to implement it. But now I realize it can be done with the ext directive. This directive basically allows for custom directives, so you can use it to define process-specific CLI options, for example:
// nextflow.config
process {
  withName:'FOO' {
    ext.float = '--option value'
  }
}

// main.nf
process FOO {
}

This approach is much more aligned with what Nextflow users expect. Note also that the custom options are defined in the config file instead of the process definition, so a user can define them in a custom config file without having to modify the pipeline code.
Happy to review the code if you decide to implement it.

Maybe an even simpler solution is the clusterOptions directive, which is used by grid executors to apply custom CLI options. I guess I didn't think of it before because Float isn't really a cluster, even though it uses a CLI.
So you could use clusterOptions for now, and if you ever refactor to use an API (#24), you can use something like ext.float for that to distinguish CLI options from API options.

Thank you very much for the suggestion, Ben. However, at this time, I’m not sure we have the resources to implement it.  Will let you know if we decide to move forward with this idea.

Of course it's up to you to decide when and how to implement it, since it's your plugin. But I also wanted to mention, we are working on a more strict syntax parser for Nextflow scripts, which will not support something like extra = ... in the process definition. You still have a long time to migrate before it becomes the default behavior in Nextflow, just giving you some advance notice

Thanks for the updates.  So we will definitely do this sooner or later.

I took some time to look into this issue and it is not complex.  So I fixed it and tested it.  Looks good so far.

Change is available in nf-float 0.4.4


Use proxy for pull mirror

Use the proxy (if one is specified) for pull mirrors syncs.
Pulled the code from https://github.com/go-gitea/gitea/blob/c2774d9e80d9a436d9c2044960369c4db227e3a0/modules/git/repo.go#L164-L170

Downstream issue: https://codeberg.org/forgejo/forgejo/issues/302

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@c07199f). Click here to learn what that means.
The diff coverage is 33.33%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@           Coverage Diff           @@
##             main   #22771   +/-   ##
=======================================
  Coverage        ?   47.29%
=======================================
  Files           ?     1111
  Lines           ?   149412
  Branches        ?        0
=======================================
  Hits            ?    70666
  Misses          ?    70363
  Partials        ?     8383

Impacted Files
Coverage Δ

services/mirror/mirror_pull.go
27.66% <33.33%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


FF Fix: Status-Indicator-Chip text not updating when status is toggled

Challenge:
Status-Indicator-Chip text not updating when status is toggled.
But the style does. They are based on the same data, so...
I couldn't figure it out at end of day, maybe you will be the hero.

QA: this works now


Add SQLiteChatMessageHistory

It's based on already existing PostgresChatMessageHistory
Use case somewhere in between multiple files and Postgres storage.

I just came across this looking for a solution to store users' chat histories - in order to replicate eg the ChatGPT history feature, you want the table to store user id's as well as sessions, and the delete-on-close functionality is not desirable. Would also be better to get the table name from config/ENV than have it hard-coded.

Thanks for this. I think what might be best if we just use SqlAlchemy, then we could basically use the same class to persist chat history in a variety of sql dbs like postgres, sqlite, mysql etc.

Good idea, especially since SqlAlchemy is already a dependency.

I just came across this looking for a solution to store users' chat histories - in order to replicate eg the ChatGPT history feature, you want the table to store user id's as well as sessions, and the delete-on-close functionality is not desirable. Would also be better to get the table name from config/ENV than have it hard-coded.

I guess in that case one can make a separate table chat himself that would have user_id session_id fields. It probably comes down to how general / simple langchain wants to be. As for the table name - you can pass it to a constructor right now.

Hmm, why didn't running lint locally caught this?


⚠ SSH 🇮🇩 Indonesia IDJ 1 has degraded performance

In 9e49312, SSH 🇮🇩 Indonesia IDJ 1 (http://ids-1.opensvr.net:8080/) experienced degraded performance:

HTTP code: 400
Response time: 7387 ms

Resolved: SSH 🇮🇩 Indonesia IDJ 1 performance has improved in 06d40d3.


Breakpoint names can break rules

UnoCSS version
0.61.2
Describe the bug
Breakpoint names can break rules, just look at the example below.
Reproduction
Create a config with a breakpoint m, try to use any class starting with m like m-1. The class will not be recognized by any rule and therefor not be included into the final build. But mb-1 for example, will work.
import {defineConfig, presetWind,} from 'unocss'
import {presetBase} from "./uno.preset";

export default defineConfig({
  presets: [
    presetWind(),
  ],
  theme: {
    breakpoints: {
      m: 100px,
    },
  }
})

System Info
No response
Validations

[X] Read the Contributing Guidelines.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

@Simon-He95 what do you want to tell me?
This is not working:

import {defineConfig, presetWind,} from 'unocss'
import {presetBase} from "./uno.preset";

export default defineConfig({
  presets: [
    presetWind(),
  ],
  rules: [
    [/^m-(\d+)$/, ([, d]) => ({ margin: `${d / 4}rem` })],
  ],
  theme: {
    breakpoints: {
      m: 100px,
    },
  }
})

We temporarily closed this due to the lack of enough information. We could not identify whether it was a bug or a userland misconfiguration with the given info.
Please provide a minimal reproduction to reopen the issue.
Thanks.

Why reproduction is required


Deprecated API Migration

Hi,
this PR migrates the use of deprecated apis for k8s 1.22
Fixes #223

Proposed Changes

migrate CustomResourceDefinition to apiextensions.k8s.io/v1
migrate MutatingWebhookConfiguration to admissionregistration.k8s.io/v1
migrate ValidatingWebhookConfiguration  to admissionregistration.k8s.io/v1

Release Note
- Deprecated API Migration for K8s 1.22

/assign @matzew
:)

The same happens for GitHubBinding CRD:
error: error parsing https://github.com/knative-sandbox/eventing-github/blob/d1098e3933db6e89de0a888e57b27c9099648ef2/config/core/300-githubbinding.yaml: error converting YAML to JSON: yaml: line 186: mapping values are not allowed in this context

I see, thanks!

/cc @devguyio @lionelvillard

/cc @matzew (as being an owner too)

Hi @Fabian-K,
Thanks for the PR. Not sure whether this error is related to your change, but when i run ko apply -f config I am getting the following error:
Error: error processing import paths in "config/500-webhook.yaml": error resolving image references: exit status 2
2022/05/13 01:05:12 error during command execution:error processing import paths in "config/500-webhook.yaml": error resolving image references: exit status 2

Any idea why I am getting this error?

Hey, sorry I cannot reproduce that error on my side. Is it something that you only get with the changes or do you also face this on latest main?

It works fine on my end.
/approve
/lgtm

/cherry-pick release-1.4


No rss/atom link?

Am I correct in seeing that there is no rss/atom link in the head of the templates?
...reason?

This is done in cleanup.php: https://github.com/olefredrik/FoundationPress/blob/master/library/cleanup.php
If you remove the line about the RSS-feed it will come back.

Yes it's by design. WordPress outputs a lot of junk in the ´´´´ by default. Feel free to include this if you need it in your project.
See this file:
https://github.com/olefredrik/FoundationPress/blob/master/library/cleanup.php
To load all the stuff that's included by default (including rss/atom link), remove this line
https://github.com/olefredrik/FoundationPress/blob/master/library/cleanup.php#L36


[BUG] Incorrectly Identifying Compatible Mod Versions

Version Information
KSP 2 Version
0.1.1
Space Warp Version
1.0.1

Bug Information
Describe the bug
SpaceWarp is failing to correctly understand the min and max compatible KSP2 versions for mods. There are numerous mods (e.g.,
Community Fixes, Cheat Menu, Kerbal Part Manager, etc.) where the max compatible version is set to a value larger than 0.1.1 (e.g. 0.2.0) and yet spacewarp.modlist is showing them as "(unsupported)". The only mods I'm aware of that don't have this problem are using a max of either 1 or *.
To Reproduce
Select MOD menu at game stat or press Alt-M in the game. Click any SpaceWarp mod that's listed in red. Check the KSP2 version range.
Expected behavior
SpaceWarp should show mods where the current KSP2 version is bounded between the min and max values listed for the mod as being compatible.
Link to crashlog [If Applicable]
N/A
Screenshots
Easily reproduced on any system
Additional context
Thanks! Love SpaceWarp and the mods that are available! Keep up the good work!

This is known about, and I will be looking into it

fixed?

Yes

👍


Add tests for Meeting

Codecov Report
Base: 66.64% // Head: 69.36% // Increases project coverage by +2.72% :tada:

Coverage data is based on head (f33b450) compared to base (82bfcf7).
Patch coverage: 33.33% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #110      +/-   ##
============================================
+ Coverage     66.64%   69.36%   +2.72%
- Complexity      399      421      +22
============================================
  Files            78       77       -1
  Lines          1334     1335       +1
  Branches        139      139
============================================
+ Hits            889      926      +37
+ Misses          413      371      -42
- Partials         32       38       +6

Impacted Files
Coverage Δ

...main/java/seedu/address/model/meeting/Meeting.java
57.14% <ø> (+57.14%)
:arrow_up:

src/main/java/seedu/address/model/ClientBook.java
85.18% <33.33%> (-6.49%)
:arrow_down:

...u/address/model/meeting/NoConflictMeetingList.java
9.75% <0.00%> (+9.75%)
:arrow_up:

.../java/seedu/address/model/meeting/Description.java
57.14% <0.00%> (+57.14%)
:arrow_up:

.../java/seedu/address/model/meeting/MeetingDate.java
57.14% <0.00%> (+57.14%)
:arrow_up:

.../java/seedu/address/model/meeting/MeetingTime.java
57.14% <0.00%> (+57.14%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


add generation script for MOSTLYAI

Closes #18

TODO: Add instructions to the repo

Opened a new issue for reproducibility scripts #20


Add badge

:tada: This PR is included in version 1.1.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


BinaryLoader: lock parse cache file before saving the cache

Eliminates ObjectInputStream exceptions when several K instances run in parallel over same definition.
Tested on verified-smart-contracts.
Essentially only one line matters:
out.getChannel().lock();

Everything else is refactoring.

No, just multiple instances of kprove. Why would you run multiple instances of kompile over the same destination dir? If they run over different destinations, then each has its own cache file and there is no race condition.

What I want to test is multiple different K definitions that compile to different directories but share the same cache file and have some files in common.

No I didn't test that but this fix should make them work properly. It doesn't matter who rewrites the cache after all - kprove or kompile.

Okay, I will approve this and then try it once it's merged.


Uncaught TypeError: Cannot read property 'style' of null

Config
custom_header:
  background: 'rgba(150, 150, 150, 0.1)'
  chevrons: false
  exceptions:
    - conditions:
        user: Vb
      config:
        disable_sidebar: true
        hide_help: true
        hide_unused: true
        voice_dropdown: true
        hide_tabs: '7 to 10'
    - conditions:
        user: Vc
      config:
        disable_sidebar: true
        hide_help: true
        hide_unused: true
        voice_dropdown: true
        hide_tabs: '0 to 9'
        hidden_tab_redirect: true
        compact_mode: true
    - conditions:
        user: Xc
      config:
        hide_tabs: '0 to 9'
        hidden_tab_redirect: true
        compact_mode: true
    - conditions:
        user: Xy
      config:
        hide_tabs: '7 to 10'

HA Logs
Log Details (ERROR)
Logger: frontend.js.latest.202005191
Source: components/system_log/init.py:209
First occurred: 9:21:17 PM (2 occurrences)
Last logged: 9:25:51 PM
https://blahblah/local/custom-lovelace/custom-header/custom-header.js:1:7028 Uncaught TypeError: Cannot read property 'querySelector' of undefined
https://blahblah/local/custom-lovelace/custom-header/custom-header.js:1:11797 Uncaught TypeError: Cannot read property 'style' of null
Chrome DevTools
Uncaught TypeError: Cannot read property 'style' of null
at buildButton (custom-header.js:1)
at custom-header.js:1
at custom-header.js:1
HA v0.110.1
Custom Header v1.4.5 - manual install
Chrome / HA Android app
I've searched opened and closed issues, HA forums etc. and nothing seems to work so far :/
I've tried:

CH releases 1.3.9, 1.4.3, 1.4.5
change all the 'iron-icon' entries to 'ha-icon'
Replacing all (13) paper-icon-button with ha-icon-button
Restart after each change, nothing helped. All the version / changes were combined.

Any help would be appreciated, I might downgrade to HA 0.109 since that version was absolutely OK with CH.

I've tested your config using the latest 1.4.5 and am unable to recreate the issues, everything seems to be working fine and I get no errors.
Since you installed manually are you adding to a version number to the end of the resources URL, clearing cache, and refreshing? Does this happen with every user or just one?

With the latest CH version there is no need to modify anything, so do not edit the file.

Hello,
issue occurred with upgrading to HA 0.110.1, I then upgraded CH to v1.4.5, unmodified. That's where I started to try and fix it via old issues / forums as mentioned.
Putting version number in resources did the trick! Thank you, closing this.
Have a great weekend!


Stability docs update

IBM Cloud Secrets Manager posture is stable
Added 0.6.0

@moolen When does the website get regenerated to include the changes?

hey @IdanAdar ! It should be available here already https://external-secrets.io/main/ . It will become "latest" whenever we do a new release

It is there on main: https://external-secrets.io/main/stability-support/
But not for the latest 0.6.0 release because this was merged after the release.
I guess we'd like to have it for the 0.6 release, but unfortunately we don't have a way to backport these changes

Lol.. as i was typing :D


Error downloading datasets

Target objective:
REST server initial download
Steps to objective:

[x] clone repository and install
[x] nlp_architect server -p 8080
[x] answer YES to download archive files

Pull-Request related:
Trace:
mrc_model can be downloaded from http://nervana-modelzoo.s3.amazonaws.com/NLP/mrc/mrc_model.zip
The terms and conditions of the data set license apply. Intel does not grant any rights to the data files or database

To download 'mrc_model' from http://nervana-modelzoo.s3.amazonaws.com/NLP/mrc/mrc_model.zip, please enter YES: YES
Downloading mrc_model...
Unable to determine total file size.
Downloading file to: /root/nlp-architect/mrc-pretrained/mrc_data/mrc_data.zip
1MB [00:00, 1045.70MB/s]
Download Complete
Unable to determine total file size.
Downloading file to: /root/nlp-architect/mrc-pretrained/mrc_trained_model/mrc_model.zip
1MB [00:00, 1985.94MB/s]
Download Complete
Traceback (most recent call last):
  File "/usr/local/bin/hug", line 10, in <module>
    sys.exit(development_runner.hug.interface.cli())
  File "/usr/local/lib/python3.6/site-packages/hug/interface.py", line 551, in __call__
    raise exception
  File "/usr/local/lib/python3.6/site-packages/hug/interface.py", line 547, in __call__
    result = self.output(self.interface(**pass_to_function), context)
  File "/usr/local/lib/python3.6/site-packages/hug/interface.py", line 100, in __call__
    return __hug_internal_self._function(*args, **kwargs)
  File "/usr/local/lib/python3.6/site-packages/hug/development_runner.py", line 59, in hug
    api_module = importlib.machinery.SourceFileLoader(file.split(".")[0], file).load_module()
  File "<frozen importlib._bootstrap_external>", line 399, in _check_name_wrapper
  File "<frozen importlib._bootstrap_external>", line 823, in load_module
  File "<frozen importlib._bootstrap_external>", line 682, in load_module
  File "<frozen importlib._bootstrap>", line 265, in _load_module_shim
  File "<frozen importlib._bootstrap>", line 684, in _load
  File "<frozen importlib._bootstrap>", line 665, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 678, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/src/nlp-architect/nlp_architect/server/serve.py", line 103, in <module>
    prefetch_models()
  File "/src/nlp-architect/nlp_architect/server/serve.py", line 36, in prefetch_models
    services[model] = Service(model)
  File "/usr/local/lib/python3.6/site-packages/nlp_architect/server/service.py", line 117, in __init__
    self.service = self.load_service(service_name)
  File "/usr/local/lib/python3.6/site-packages/nlp_architect/server/service.py", line 181, in load_service
    upload_service.load_model()
  File "/usr/local/lib/python3.6/site-packages/nlp_architect/api/machine_comprehension_api.py", line 107, in load_model
    self.download_model()
  File "/usr/local/lib/python3.6/site-packages/nlp_architect/api/machine_comprehension_api.py", line 96, in download_model
    data_zip_ref = zipfile.ZipFile(data_zipfile, 'r')
  File "/usr/local/lib/python3.6/zipfile.py", line 1131, in __init__
    self._RealGetContents()
  File "/usr/local/lib/python3.6/zipfile.py", line 1198, in _RealGetContents
    raise BadZipFile("File is not a zip file")
zipfile.BadZipFile: File is not a zip file

Hi @autodidacticon, the issue has been fixed now.
Thanks for reporting!


create cache when install

Codecov Report

Merging #144 (f7af820) into main (e38628a) will decrease coverage by 0.00%.
The diff coverage is 86.66%.

@@            Coverage Diff             @@
##             main     #144      +/-   ##
==========================================
- Coverage   77.56%   77.56%   -0.01%
==========================================
  Files          87       88       +1
  Lines        3232     3231       -1
  Branches      331      330       -1
==========================================
- Hits         2507     2506       -1
  Misses        598      598
  Partials      127      127

Impacted Files
Coverage Δ

towhee/tests/engine/test_pipeline.py
93.93% <ø> (-1.07%)
:arrow_down:

towhee/engine/operator_loader.py
80.95% <50.00%> (+0.95%)
:arrow_up:

towhee/engine/task_executor.py
90.24% <66.66%> (+0.50%)
:arrow_up:

towhee/__init__.py
95.23% <100.00%> (-0.32%)
:arrow_down:

towhee/engine/__init__.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e38628a...f7af820. Read the comment docs.

/approve
/lgtm


Request about Code

Hi, your CDConv is inspiring and achieves very excellent results. However, your repository only contains the readme file. Do you plan to release all the code?

Hi, will be at the end of April.

@limei0307 Uploaded. Sorry for the missing file.


upgrade rostopic-hz to noetic

Codecov Report

Merging #96 (0db3816) into main (34094f5) will increase coverage by 0.15%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #96      +/-   ##
==========================================
+ Coverage   82.22%   82.37%   +0.15%
==========================================
  Files          46       46
  Lines        4477     4477
==========================================
+ Hits         3681     3688       +7
+ Misses        581      574       -7
  Partials      215      215

Impacted Files
Coverage Δ

node.go
80.21% <0.00%> (+0.26%)
:arrow_up:

actionclient.go
58.25% <0.00%> (+1.37%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Scoreboard for Tic Tac Toe Game

Feature Request: Scoreboard for Tic Tac Toe Game
Is your feature request related to a problem? Please describe.
The current Tic Tac Toe game lacks a scoreboard to track wins and losses for each player. This can make it difficult to see who is winning overall and doesn't provide a sense of accomplishment or competition.
Describe the solution you'd like
I'd like to add a scoreboard to the Tic Tac Toe game. This scoreboard should display:
Player 1 Wins: [Number]
Player 2 Wins: [Number]
Ties: [Number]
The scoreboard should update automatically after each game. Wins should be awarded based on the standard Tic Tac Toe win conditions. A tie should be declared if the board is filled and no player has achieved a winning line.
Please assign me this task I'm eager to contribute on this project.

Assigned Go ahead @atharva012004
before Starting PUSH the MAIN branch

completed #53


minifying GIF - stdout maxBuffer exceeded

When minifying a bunch of gifs from the command line, I get this error at some point:
MaxBufferError: stdout maxBuffer exceeded
    at PassThrough.<anonymous> (C:\Users\[snip]\get-stream\index.js:41:19)
    at PassThrough.emit (events.js:327:22)
    at addChunk (_stream_readable.js:295:12)
    at readableAddChunk (_stream_readable.js:271:9)
    at PassThrough.Readable.push (_stream_readable.js:212:10)
    at PassThrough.Transform.push (_stream_transform.js:152:32)
    at PassThrough.afterTransform (_stream_transform.js:96:10)
    at PassThrough._transform (_stream_passthrough.js:46:3)
    at PassThrough.Transform._read (_stream_transform.js:191:10)
    at PassThrough.Transform._write (_stream_transform.js:179:12)

What's also not great about this, is that all other gifsicle processes are nuked as well when this happens. It might be useful to know, the biggest gif in the collection I'm minifying, is about 33MB. I'm not sure if that's the one it fails on. I don't know which one is causing this crash.
I'm on Node.js 12.18 and imagemin-cli 6.0.0.
Edit: it appears to crash even on files that are less than 10MB

I'm having the same issue.

Same here

I too am having the same issue
(node:16700) UnhandledPromiseRejectionWarning: MaxBufferError: stdout maxBuffer exceeded
node 14.5 and gulp

Same here

I solved it this way.
YOUR_PROJECT/node_modules/imagemin-gifsicle/index.js

Before

        const {stdout} = await execa(gifsicle, args, {
		encoding: null,
		input,
	});

After

        const {stdout} = await execa(gifsicle, args, {
		encoding: null,
                maxBuffer: Number.POSITIVE_INFINITY,
		input,
	});

If you want to keep the changes, you can use patch-package.


Why does errLogToConsole suppress error?

I'm trying to understand why passing errLogToConsole: true suppresses the error event from being emitted on the stream. I think it's useful for the stream to emit an error still so that the gulp process will fail and the process will have a non-zero exit code. If I want this to happen as it's built currently I have to do something like this:
        .pipe(sass({
            onError: function (error) {
                console.error('[gulp-sass] ' + error.message + ' on line ' + error.line + ' in ' + error.file);
                process.exit(1);
            }
        }))

Am I missing something?

That's a gulp-sass thing, not a gulp thing: https://github.com/dlmanning/gulp-sass#errlogtoconsole-true
I'm not sure I understand what you're saying anyway. You want the error to be thrown? Just don't set errLogToConsole.

As @callumacrae said, this is not a gulp issue.

Blargh, sorry, meant to open this on gulp-sass and had too many tabs open.
On Wednesday, March 11, 2015, Blaine Bublitz<EMAIL_ADDRESS>wrote:

Closed #952 https://github.com/gulpjs/gulp/issues/952.
—
Reply to this email directly or view it on GitHub
https://github.com/gulpjs/gulp/issues/952#event-250550441.

As for what I'm saying, this issue is that you apparently have to choose
between useful human-readable output and useful machine-readable exit codes
which seems like a design flaw (in gulp-sass).
On Wednesday, March 11, 2015, Eric Capps<EMAIL_ADDRESS>wrote:

Blargh, sorry, meant to open this on gulp-sass and had too many tabs open.
On Wednesday, March 11, 2015, Blaine Bublitz<EMAIL_ADDRESS><javascript:_e(%7B%7D,'cvml','notifications@github.com');>> wrote:

Closed #952 https://github.com/gulpjs/gulp/issues/952.
—
Reply to this email directly or view it on GitHub
https://github.com/gulpjs/gulp/issues/952#event-250550441.


Fix rat issue

Moved the rat exclude up into the pcj fluo parent pom
so Function gets ignored regardless of profile.
Description

What Changed?
Moved rat exclude up one pom.

Tests

Coverage?
Ran build locally with geo profile and without

Links
N/A
Checklist

[ ] Code Review
[x] Squash Commits

People To Reivew
@pujav65
@amihalik

asfbot build


Propagate labels/annotations from values.yaml to both template and workload

Description
K8S-10729
Fixes: https://github.com/Dynatrace/dynatrace-operator/issues/3182
We are a bit inconsistent on where we put the custom labels/annotations defined in the values.yaml file.
Now we put them both on the pod and their owners(deployment, daemonset).
How can this be tested?
In the values.yaml mess around with the following values:
operator:
  labels:
  annotations:

webhook:
  labels:
  annotations:

csidriver:
  labels:
  annotations:

see that they are added onto both the pod and the owner.

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 64.71%. Comparing base (c6ad295) to head (cb5d177).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3645   +/-   ##
=======================================
  Coverage   64.71%   64.71%
=======================================
  Files         399      399
  Lines       21397    21397
=======================================
  Hits        13848    13848
  Misses       6230     6230
  Partials     1319     1319

Flag
Coverage Δ

unittests
64.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Fix REGEXP_EXTRACT may access overflow when input was binary data

What type of PR is this：

[x] bug
[ ] feature
[ ] enhancement
[ ] others

Which issues of this PR fixes ：
Fixes #3193

Please add UT

run starrocks_be_unittest


Change keyframe loop

We need to be looping by the amount of frames in a timeline instead of the amount of keyframes.

Fixed in 71447e2cba680c537e659b4f509f20e2d04e5fd6


Set up CI with Azure Pipelines

[skip ci]

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: BjarniThor sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.