tar with symbolic links

I could create a symbolic links by ln -s.
root@localhost:~# ls -l kkk
total 0
-rw-rw-rw- 1 root root 14 Apr  7 04:53 atest
lrwxrwxrwx 1 root root  5 Apr  7 04:54 btest -> atest

But I can't archive with the tar.
root@localhost:~# tar cvf kkk.tar kkk
kkk/
kkk/atest
tar: kkk/btest: Cannot readlink: Invalid argument
tar: Exiting with failure status due to previous errors

In reverse, the symbolic links in a tar file which built on Linux can't be extracted.

Related to #3 and/or #6 ?

The error messages are different.
In my case, ln -s is working, but not compatible with tar.
Here is the reverse operation output. ( extracting symlinks containing tar whilch is built on real Linux )
root@localhost:~# tar tvf /mnt/c/temp/kkk.tar
drwxr-xr-x root/root         0 2016-04-07 05:25 kkk/
lrwxrwxrwx root/root         0 2016-04-07 05:25 kkk/btest -> atest
-rw-r--r-- root/root        12 2016-04-07 05:24 kkk/atest
root@localhost:~# tar xvf /mnt/c/temp/kkk.tar
kkk/
kkk/btest
tar: kkk/btest: Cannot create symlink to ‘atest’: Invalid argument
kkk/atest
tar: Exiting with failure status due to previous errors

I can echo this: I tried to install rvm from get.rvm.io and the script crashes and burns because of the tar symlink incompatibility.

I also can confirm this.  (Running on 64-bit, on the off chance that matters).  Can create symlinks just fine, cannot tar them or untar packages which contain them.  As an interesting consequence, apt packages which contain symlinks (Java) also cannot be installed.

I was trying to copy files from a real linux box using tar. Also running into the symlink issue. As a workaround I was able to copy the files using bsdtar which creates symlinks correctly.

This is affecting http://nvm.sh installs via windows as well. https://github.com/creationix/nvm/issues/1054

This might relate to is #44 as well...for me anyway, the move won't work on tarballs/zips from CPAN which contain soft links.

+1.
Can't install Meteor due to this issue.
Copying the files from a Linux VM sort of works if you re-create the tarball with the h option (i.e. tar cvfh).

As @ljharb said: nvm doesn't install properly. And none of the tools that uses symlinks with tar works right now.

To clarify, this is affecting nvm's ability to install node. nvm itself installs fine.

because of this error i am not able to install rbenv

The tar extraction problem with symlinks is caused by the missing symlinkat syscall (symlink was supported but not the at variant). This bug has been fixed internally.
Similarly, I believe creating a tar file with symlinks fails because readlinkat is missing.

Just as a note if someone else stumbles upon this: this also affects installation of Miniconda using Continuum Analytics Miniconda installation shell script that extracts a tar archive containing symlinks.
You get errors like this:
tar: bin/2to3: Cannot create symlink to ‘2to3-3.5’: Invalid argument

Having the same trouble installing RVM. I can download the zip version and install manually, but I get a warning at the end of the install:
`  * WARNING: you are missing '/dev/fd' it is important for shell scripting used by RVM,
You can fix it on most linux systems with:
  ln -sf /proc/self/fd /dev/fd`

/proc/self/fd does exist, but following those instructions gives me:
root@localhost:~# ln -s /proc/self/fd /dev/fd ln: failed to create symbolic link ‘/dev/fd’: Operation not permitted
This is a different error. I make a note here wondering if the (internal) fix would address this, or if we're into some unsupported behavior in the /proc filesystem now.
I got RVM installed manually, but, of course, it wants to install rubies from tar-ed sources, which loops me back around to the original problem, and I'm tired of fighting it.

DunKirk, that error is due to some limitations of our /dev filesystem that prevent you from creating a link there. We're working to address this. This is separate from the symlinkat error.

@SvenGroot thank you much!

I have an example where openat() on a symlink returns no such file or directory despite the symlink existing but not the target. Does the symlinkat fix also apply here?
# e.g. openat("libsolv.so") fails with no such file or directory
root@localhost:# ls -l
total 0
lwrxwrxwrx 1 root root 12 Apr 10 23:33 libsolv.so -> libsolv.so.1
root@localhost:#

Example: https://github.com/haiku/haiku/blob/master/src/bin/package/command_extract.cpp#L552

Thanks for the feedback. Support for both symlinkat and readlinkat has been added to the code, but the build has not made it to flighting yet.

Is there some kind of workaround for this?

Thanks for the feedback. Support for both symlinkat and readlinkat has been added to the code, but the build has not made it to flighting yet.

@sunilmut - any idea about when the new build will be released? Is there a release plan hidden somewhere? :wink:

@perlun - Sorry, that information is not something we can provide reliably at this time. Though, we understand the need for better tracking and availability of information, and are looking into how we can improve that on our side. So, please bear with us until then.

Thanks for the feedback. Support for both symlinkat and readlinkat has been added to the code, but the build has not made it to flighting yet.

@sunilmut Does this also include openat?

Openat is already supported in the current publicly available build.

Will this thread be updated as soon as this functionality gets fixed? Thanks!

any workaround? i have to install node =/

@stewones We need to wait for Windows Update.

Build 14328 seems to have fixed the general symbolic link problem. Awesome, and thanks. However, I encountered this bug by trying to install RVM, and I still can't complete the process because of the related-but-different bug I listed above (about linking /dev/fd). Maybe we could re-open #222 to continue tracking this issue?

Sure I'll reopen #222.  Will you add more detail in that thread about the  issue's you're seeing?

@perlrun

any idea about when the new build will be released? Is there a release plan hidden somewhere?
Yes, :). A new Windows build 14328 has been released and WSL specific release notes are here

@sunilmut - cool! When will it be out on the Fast channel?

@perlun Its being released today to the Fast ring. So, any moment, I would say.

updating... u.u

@sunilmut - awesome. Will try it once I get the update (sometime next week then, I guess).

The update is now live and on the fasttrack:  https://msdn.microsoft.com/en-us/commandline/wsl/release_notes
Good news and bad news for this thread.  The good news is you can now untar items with symlinks under a non-mount directory.  Bad news is the fix to create a tar with a symlink is not in this build yet.
We do have the fix internally, along with the fix so this works on the /mnt drives.  These fixes are moving through the system and will be in a later build.

The good news is you can now untar items with symlinks under a non-mount directory.

As long as you're running as root. Otherwise, tar prints errors and return an exit status that indicates failure.
tar: <symlink name>: Cannot utime: Operation not permitted

That's with a user created by lxrun /setdefaultuser. The symlinks do get created, but all symlinks appear to have root as their owner. Is that why utime is not permitted? Should I report this as a separate issue?

@hvdijk Thanks for reporting this issue. I've tested it, and was able to reproduce it in the current Windows Insider build. This issue has already been fixed in our internal builds (the links have the correct owner now), and this fix will be released in a future Insider build.

I tested the same thing which I did when I created this issue.
In build 14328, the symbolic link containing tar file is successfully extracted.  It didn't work in 14316. Thanks.
root@DESKTOP-V9QH45Q:~# tar tvf kkk.tar
drwxrwxr-x tinysun/tinysun   0 2016-04-23 22:40 kkk/
-rw-rw-r-- tinysun/tinysun  11 2016-04-23 22:40 kkk/atest
lrwxrwxrwx tinysun/tinysun   0 2016-04-23 22:40 kkk/btest -> atest
root@DESKTOP-V9QH45Q:~# tar xvf kkk.tar
kkk/
kkk/atest
kkk/btest
root@DESKTOP-V9QH45Q:~# ls -l kkk
total 0
-rw-rw-r-- 1 1000 1000 11 Apr 23 22:40 atest
lrwxrwxrwx 1 1000 1000  5 Apr 23 22:40 btest -> atest

But the archiving test was failed with same messages as I showed at the first post.
root@localhost:~# tar cvf kkk2.tar kkk
kkk/
kkk/atest
tar: kkk/btest: Cannot readlink: Invalid argument
tar: Exiting with failure status due to previous errors

@SvenGroot is there a reason the concept of an "internal build" exists? can this not be compiled natively from an open source repo and used within Windows?

@ljharb I obviously don't speak for MS here, but it seems like a lot of these fixes are in the underlying subsystem in Windows not the high-level "Bash on Ubuntu on Windows" application that can be compiled and pushed on its own. It will probably be coupled to Windows builds for the foreseeable future.

@nsvrana you are correct. I'll also add on that internal builds exist for development and validation.  We go through a validation process to make sure that what is released to Insiders meets a certain quality bar and isn't going to harm their machine.
That being said, It would be nice if our update frequency was faster and we're discussing ways to make this possible in the future.

sudo apt-get upgrade ubuntu-on-windows :wink:

This looks to be fixed.  Try it with the new 14332 build.

It works finally!
root@DESKTOP-V9QH45Q:~# ls -lR kkk
kkk:
total 0
-rw-rw-r-- 1 1000 1000 11 Apr 23 22:40 atest
lrwxrwxrwx 1 1000 1000  5 Apr 23 22:40 btest -> atest
root@DESKTOP-V9QH45Q:~# tar cvf kkk.tar kkk
kkk/
kkk/atest
kkk/btest
root@DESKTOP-V9QH45Q:~# tar tvf kkk.tar
drwxrwxr-x 1000/1000         0 2016-04-23 22:40 kkk/
-rw-rw-r-- 1000/1000        11 2016-04-23 22:40 kkk/atest
lrwxrwxrwx 1000/1000         0 2016-04-23 22:40 kkk/btest -> atest

It seems that the problem I presented in beginning is solved. If there is no objection, I will close this issue in this weekend.
Thanks you WSL team, that's totally awesome!

its fixed in the new build?

This doesn't appear to be completely fixed or has been reverted.  I am running build 14343..rs1_release.160506-1708.
This can be tested in the following way:
JUPITER:~/tmp$ ls
JUPITER:~/tmp$ echo FOO > tmp1
JUPITER:~/tmp$ ln -s tmp1 tmp2
JUPITER:~/tmp$ grep -r FOO ./
./tmp1:FOO
grep: ./tmp2: Invalid argument

Good detection!
This thread is for the combination of symlink and 'tar', not for all things related to symlink or tar.
Please create new issue with title like 'grep with symbolic links'.

@therevmj @tinysun212 I tried this repro internally and verified that this is now working.  The fix will be making its way to a windows insider build soon.

Sorry to be a bit OT, but how do you push your insider machine to download the latest build? Mine is still running the "original" 160402 (or so) release, meaning I don't have the symlink fixes etc...

@perlun http://www.cnet.com/how-to/change-to-the-fast-ring-for-more-frequent-windows-10-preview-updates/

@hfaran - thanks. The problem is I am already on the fast ring, but the updates don't seem to be coming. And I cannot find a way to manually force them to come. Any suggestions?


Add test for Cassandra-11031 allow filtering on partition key

dtests for #11031 (still in review)
Puts back riptano/cassandra-dtest#969 once ticket is merged

Looks like this is ready to merge. Can you change the since annotations to 3.10? Also, can you take the change you made in user_types_test, and have that ONLY apply to 3.10+? On 2.2 and 3.0 we should still expect the previous error. Thanks!

Great, I'm waiting only on a couple of missing dtests from @jasonstack

I've added the missing tests myself. Running CI against the latest 3.0, 2.2 and trunk just to make sure everything's all right after my adjustments.

Test results:

2.2
3.0
trunk

If you could take a short final look, it'd be great. We'd close 2 tickets with that one :)

+1! Feel free to merge

@ifesdjeen  sorry for the late reply.. I just came back from the states.. thanks for the help,


Mirah seems to not making distinction between curly blocks and do-end block

In ruby when one omit parenthesis do-end block belongs to first expression in chain and curly block belongs to the last one.

Mirah's parser has the same precedence as Ruby's  for do;end and curly blocks. I added a test to the parser to verify. https://github.com/mirah/mirah-parser/commit/b20dbe74d827092cf285e812e48a2d9cebb3c902
I'm going to close this, but if you have an example where it doesn't work like you'd expect, could you post it?

Following code snipped parsed incorrectly:
A.call an_arg do
  do_block_call
end

Parser treats this as:
A.call(
  an_arg do
    do_block_call
  end
)

Opened parser issue https://github.com/mirah/mirah-parser/issues/33


Appstudio update test-component-pac-jjst

Pipelines as Code configuration proposal

Pipelines as Code CI/test-component-pac-jjst-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
19 seconds
appstudio-init

✅ Succeeded
12 seconds
clone-repository

✅ Succeeded
16 seconds
appstudio-configure-build

✅ Succeeded
15 seconds
sast-snyk-check

✅ Succeeded
41 seconds
build-container

✅ Succeeded
1 minute
clamav-scan

✅ Succeeded
13 seconds
clair-scan

✅ Succeeded
13 seconds
sanity-inspect-image

✅ Succeeded
10 seconds
deprecated-base-image-check

✅ Succeeded
16 seconds
sbom-json-check

✅ Succeeded
12 seconds
sanity-label-check

✅ Succeeded
13 seconds
sanity-optional-label-check

✅ Succeeded
9 seconds
show-summary

Pipelines as Code CI/test-component-pac-jjst-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
19 seconds
appstudio-init

✅ Succeeded
12 seconds
clone-repository

✅ Succeeded
16 seconds
appstudio-configure-build

✅ Succeeded
15 seconds
sast-snyk-check

✅ Succeeded
41 seconds
build-container

✅ Succeeded
1 minute
clamav-scan

✅ Succeeded
13 seconds
clair-scan

✅ Succeeded
13 seconds
sanity-inspect-image

✅ Succeeded
10 seconds
deprecated-base-image-check

✅ Succeeded
16 seconds
sbom-json-check

✅ Succeeded
13 seconds
sanity-optional-label-check

✅ Succeeded
12 seconds
sanity-label-check

✅ Succeeded
9 seconds
show-summary

Pipelines as Code CI/test-component-pac-jjst-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
8 seconds
appstudio-init

✅ Succeeded
11 seconds
clone-repository

✅ Succeeded
20 seconds
sast-snyk-check

✅ Succeeded
17 seconds
appstudio-configure-build

✅ Succeeded
40 seconds
build-container

✅ Succeeded
15 seconds
deprecated-base-image-check

✅ Succeeded
18 seconds
sanity-inspect-image

✅ Succeeded
14 seconds
clair-scan

✅ Succeeded
52 seconds
clamav-scan

✅ Succeeded
18 seconds
sbom-json-check

✅ Succeeded
13 seconds
sanity-optional-label-check

✅ Succeeded
12 seconds
sanity-label-check

✅ Succeeded
8 seconds
show-summary

Pipelines as Code CI/test-component-pac-jjst-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
8 seconds
appstudio-init

✅ Succeeded
11 seconds
clone-repository

✅ Succeeded
20 seconds
sast-snyk-check

✅ Succeeded
17 seconds
appstudio-configure-build

✅ Succeeded
40 seconds
build-container

✅ Succeeded
52 seconds
clamav-scan

✅ Succeeded
18 seconds
sanity-inspect-image

✅ Succeeded
15 seconds
deprecated-base-image-check

✅ Succeeded
14 seconds
clair-scan

✅ Succeeded
18 seconds
sbom-json-check

✅ Succeeded
13 seconds
sanity-optional-label-check

✅ Succeeded
12 seconds
sanity-label-check

✅ Succeeded
8 seconds
show-summary


Anax v3 installchecklistreorg2 v3changes cli

Describe your pull request here: Updating Zowe Docs Install section for Zowe V3
List the file(s) included in this PR: cli-installcli.md
After creating the PR, follow the instructions in the comments.

@adam-wolfe @zFernand0 @awharn @t1m0thyj @traeok @ATorrise:
I've made significant changes to the articles included in this PR. My aim to is better organize our installation content and give it a better focus.
If you're wondering why you've been listed as a reviewer, it's either b/c I consulted w/ you on some of these changes, or you made comments regarding changes to this content in the Zowe CLI V3 readiness status vote document, or you're Adam and you need to review all my content 😺

@adam-wolfe @zFernand0 @awharn @t1m0thyj @ATorrise @sbohnert -- B/c the scope of content here is so broad (sorry), I highly recommend using the deploy build to best read these changes.
Find this content in the build here:
Zowe Docs > Install (top nav bar) > Installing Zowe client-side components (sidebar) > Zowe CLI + all articles under this section
Zowe Docs > Overview (top nav bar) > Glossary of Zowe terminology (sidebar) > team configuration definition
If you need to make comments, as usual, use the diff view.

I've finished adding comments.


.col missing templates

Hello.
Devices with android 4.2.2 and low resolution may display incorrect with included template.
To prevent popup display incorrect add .col to span class:

Thx! Great job anyway!!
Sorry my english :)

I didn't understood clearly. Could you please go in to detail? If there is some screen shot that would be better.

Sorry my bad english!!
I try to explain me.
In timePickerTemplates.js to show popup you uses (in 24hr i.e.):
...
:
...
witch is incorrect and display incorrect with android 4.2.2 and low res devices.
Correct is (note 'col')
...
:
...
And some css improvements to semicolon.
Trying one screenshot :)

Do you have a screen shot now?

@yatiq awesome fix! Thank you! I didn't know what to do! @rajeshwarpatlolla if you want a screenshot just run your code in an Android 4.2.2 or below and you'll see the arrows and the inputs displaying in a same line...

Sorry, but i don't have that version of android device. If you can provide me a screen shot that would be really great.

I pushed the changes to develop branch. You will see the changes in the next release.


[FEATURE] add $name->getFullgivenname() to get given name in original order.

Context: #21
An input of Schuler, J. Peter M. results in
    [firstname] => Peter
    [initials] => J. M.
    [lastname] => Schuler

and thus won't allow to re-compose the original name. As the discussion in #21 showed a change of current behavior might not only be breaking, but its desirability really depends on the situation.
Thus, this change proposes to add a new component fullgivenname to the parser which consists of firstname,middlename,initials in original order. To prevent any breakage this attribute is not exposed to $name->getAll().
Documentation and a single poorly written unit test included.

Coverage decreased (-0.9%) to 99.12% when pulling 2ee80b8e849849304433eb39962e759a5805dfa1 on jpmschuler:feature-initial-before-firstname into c6721fc7f6134157caca60469aaecb59918b5bb2 on theiconic:master.

Hey, @jpmschuler, thanks for this - as always, sorry for the delay, i'll get back to you very soon.

Actually - what i can say right now is - i think the getFullgivenname() function doesn't need an extra parser as all the parts are put on the Name instance in the right order anyway. As such, this method can be implemented without an extra parsing step, just as an export mode on the Name class. Does that make sense?

Get your point, will refactor as soon as time comes up.

Has been replaced by #27 .


implement python tile aware computation

Implement python tile aware solution.
Add jupyter notebooks for experimenting with tile aware selection

Should all instances of the word "expirement" be "experiment" instead?  Just wondering.  Thanks.

See https://github.com/ROCmSoftwarePlatform/Tensile/pull/982#issue-419544566 for merging with develop, resolving conflicts and applying clang-format.

This is rally just to add example jupyter notebook examples of the tile aware selection. I don't think it should be part of the main branch.


Load local settings

I want to be able to read the local configuration for each repository (root_dir).
The idea came from a comment on reddit.
It would be nice to be able to read settings files such as .nlsp-settings/sumneko_lua.json.

必要性を感じたらマージする (今の時点では必要性を感じない...)

https://github.com/tamago324/nlsp-settings.nvim/pull/14


Creating a deep vs shallow copy of an object in Java

Implemented examples of deep and shallow copying techniques in Java using movie.
Added classes: DeepCopyExample.java, ShallowCopyExample.java, Unit Testing (Movie.java Testing.java).
Demonstrated usage of these techniques in the context of Java objects.

Dear Hiring Manager,
I've added the codes examples I used for the article on Creating a deep vs shallow copy of an object in Java as requested. Here is the link to my Pull Request for your review:
[https://github.com/eugenp/tutorials/pull/16846]
Thank you,
Akinwale Oladimeji


Links don't open in new tab when editor is in read only mode

When editable is set to false, clicking a link opens in the same tab instead of opening in a new tab.
When editable is set to true, clicking a link opens in a new tab.
Links should always open in new tab regardless of the value of editable.

:tada: This issue has been resolved in version 1.9.0 :tada:
The release is available on:

GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:

:tada: This issue has been resolved in version 1.9.0 :tada:
The release is available on:

GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:


Vectorized unbounded continuous random number generators (Issue 45)

Submission Checklist

[x] Run unit tests: ./runTests.py test/unit
[x] Run cpplint: make cpplint
[x] Declare copyright holder and open-source license: see below

Summary:
This implements vectorized versions of all the unbounded continuous random number generators (with tests! Hooray!)
Details
I had to make some changes to test/unit/math/prim/mat/prob/vector_rng_test_helper.hpp to allow for anywhere from one to three parameters to be tested.
I also had to update the way the Skew normal random numbers were getting generated to avoid infs (this is part of Issue #527)
I also fixed some indents in test/unit/math/prim/scal/prob/util.hpp and added an extra Google test check there (that will throw if the code tries to do something that leads to segfaults in the tests).
@seantalts Hope you were looking forward to checking some repetitive code
How to Verify:
./runTests.py test/unit/math/prim/mat/prob/normal_test.cpp
./runTests.py test/unit/math/prim/mat/prob/exp_mod_normal_test.cpp
./runTests.py test/unit/math/prim/mat/prob/skew_normal_test.cpp
./runTests.py test/unit/math/prim/mat/prob/student_t_test.cpp
./runTests.py test/unit/math/prim/mat/prob/cauchy_test.cpp
./runTests.py test/unit/math/prim/mat/prob/double_exponential_test.cpp
./runTests.py test/unit/math/prim/mat/prob/logistic_test.cpp
./runTests.py test/unit/math/prim/mat/prob/gumbel_test.cpp

And the scalar tests (though I didn't change these)
./runTests.py test/unit/math/prim/scal/prob/normal_test.cpp
./runTests.py test/unit/math/prim/scal/prob/exp_mod_normal_test.cpp
./runTests.py test/unit/math/prim/scal/prob/skew_normal_test.cpp
./runTests.py test/unit/math/prim/scal/prob/student_t_test.cpp
./runTests.py test/unit/math/prim/scal/prob/cauchy_test.cpp
./runTests.py test/unit/math/prim/scal/prob/double_exponential_test.cpp
./runTests.py test/unit/math/prim/scal/prob/logistic_test.cpp
./runTests.py test/unit/math/prim/scal/prob/gumbel_test.cpp

Side Effects:
Hopefully none
Documentation:
It's all inline
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company): University of California, Santa Barbara
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

Poor ol' Travis. Package manager failed for some reason it seems.

This is failing in unit testing because a new signed comparison warning cropped up in the test code.  Easy fix to change an int to a size_t.

Bah, I use clang++ for the nice errors, but I should probably just switch to g++ cause it seems to be more careful about these things. Tnx for the heads up.

I think this is ready to review. Jenkins failed on some upstream tests for some mystery reason:
Build step 'Execute shell' marked build as failure
ERROR: Step ‘Scan for compiler warnings’ failed: no workspace for Math Pull Request - Upstream - Stan #450
ERROR: Step ‘Publish JUnit test result report’ failed: no workspace for Math Pull Request - Upstream - Stan #450
ERROR: gelman-group-linux is offline; cannot locate JDK8u66

Could easily ask for a retest, but that'll burn another pile of hours on Jenkins for nothing. (no way this gets through without revisions anyway)

Sorry, the linux node has been tricksy so typically we'll just retest when this happens. I'm working on getting it to be more friendly. Bob, are you reviewing this or should someone else (me?)?

tricksy

I just made it through the Hobbit again. Fantastic book. I'm totally into a Golem rebranding of Jenkins.
Maybe if we wanted a rebuild we'd haves to answers one of precious's riddles?

Jenkins retest this please

Jenkins retest this please

Nice! Tests passed with the gcc-4.9 patch in place. This is ready for review.

Hopefully the tests pass. I changed stuff around quite a bit to address the comments.

My first inclination here would be to wrap up the arguments (generate_samples, good_p1, bad_p1, good_p2, bad_p2, good_p3, bad_p3) into a structure.

I changed how _rngs are tested. Now in each test you inherit from an abstract base class and build a special little object that has the right test hooks (see: https://github.com/bbbales2/math/blob/275889c5ba9185ea8cf6ec70b516013e4f63cb6f/test/unit/math/prim/mat/prob/normal_test.cpp). It's not actually a totally correct abstract base class cause the templated member function can't be virtual, but I thought this makes the test code look nice.

My second inclination would be to use typelists to iterate over all the types.

Hopefully done.  I went with a recursive templating solution. There was some variadic templating stuff but it was beyond me. It was tricky to get the right combination of functors/templating so that all the pieces fit together, but it's not so bad now.
I did not add integer tests (or std::vector tests). I guess it's important and I should do some thinking, but I might need to add extra lists of good/bad integer values. Rounding the good/bad double values won't always work (cause rounding a good value might give you an invalid value).
"vector_rng_test_helper.hpp" is starting to get pretty verbose with all its little helpers and functions in it. Should I be breaking this out into pieces? If so, any suggestions on what needs broken out?
I imagine this stuff is going to keep growing as the rest of the distribution things get added, so maybe it's worth waiting to see if any other big structural changes come along before we go through the process of breaking things out.

On Oct 1, 2017, at 6:29 PM, Ben Bales<EMAIL_ADDRESS>wrote:
Hopefully the tests pass. I changed stuff around quite a bit to address the comments.
My first inclination here would be to wrap up the arguments (generate_samples, good_p1, bad_p1, good_p2, bad_p2, good_p3, bad_p3) into a structure.
I changed how _rngs are tested. Now in each test you inherit from an abstract base class and build a special little object that has the right test hooks (see: https://github.com/bbbales2/math/blob/275889c5ba9185ea8cf6ec70b516013e4f63cb6f/test/unit/math/prim/mat/prob/normal_test.cpp). It's not actually a totally correct abstract base class cause the templated member function can't be virtual, but I thought this makes the test code look nice.

I just brought up this same issue w.r.t. the "base class" we want for whole models.  Not
sure what the right answer is without being able to have virtual template methods.

My second inclination would be to use typelists to iterate over all the types.
Hopefully done.  I went with a recursive templating solution. There was some variadic templating stuff but it was beyond me. It was tricky to get the right combination of functors/templating so that all the pieces fit together, but it's not so bad now.

It's always a pain to do this.

I did not add integer tests (or std::vector tests). I guess it's important and I should do some thinking, but I might need to add extra lists of good/bad integer values. Rounding the good/bad double values won't always work (cause rounding a good value might give you an invalid value).

Right---it needs an extra list of good/bad integer values.   And yes, this is important in that not having integers compile properly has bit us many times in the past.  We'll have to make sure that the tests in Stan itself at least instantiate the integer cases.

"vector_rng_test_helper.hpp" is starting to get pretty verbose with all its little helpers and functions in it. Should I be breaking this out into pieces? If so, any suggestions on what needs broken out?

Always break into pieces if you can.

I imagine this stuff is going to keep growing as the rest of the distribution things get added, so maybe it's worth waiting to see if any other big structural changes come along before we go through the process of breaking things out.

Everything will keep growing, but that shouldn't freeze us in the meantime.

For (1), Cherry pick results for now.  File an issue with Boost if
you have examples that fail.  (2) sounds good---we have a lot of
test harness stuff that could stand to be consolidated.

This is ready to be checked

@bob-carpenter, I think @bbbales2 has made all the requested changes. Want to make sure and approve after you're done?

Not everything got fixed.  I don't have time to finish the next review now---I'm only a couple of my comments in but I should be able to get to it over the next few days.

Cool beans, whenever is good. It'll be good to get this rolling again.

I'll take another pass as soon as I can.  Sorry for the delay.

Can't they be scalars, standard vectors, or Eigen vectors?
So I think this should say "container arguments" where you have "vector arguments".

How about I change "vector" to "vector type" (like in https://github.com/stan-dev/stan/blob/develop/src/stan/lang/function_signatures.h#L10). This is how I did it in the normal_rng (must have just not copied it to the other _rngs yet):
mu and sigma can each be either a scalar or vector type (the ones that scalar_seq_view knows about). Any vector inputs must be the same length.
I'd like an easy way to refer to vector-like objects in a vague MATLAB/R this-is-vectorized kind of way.

same comment here about packing arguments as much as possible

Sure thing, this should all be pretty easy. I'll go through and see how much I can compress things.

How about "standard vector, Eigen vector, and Eigen row vector"?  That's explicit and not too long.
The reason to avoid reference to other classes is to preserve encapsulation---those other classes may change without this one changing.

On Oct 25, 2017, at 3:08 PM, Ben Bales<EMAIL_ADDRESS>wrote:
Can't they be scalars, standard vectors, or Eigen vectors?
So I think this should say "container arguments" where you have "vector arguments".
How about I change "vector" to "vector type" (like in https://github.com/stan-dev/stan/blob/develop/src/stan/lang/function_signatures.h#L10). This is how I did it in the normal_rng (must have just not copied it to the other _rngs yet):
mu and sigma can each be either a scalar or vector type (the ones that scalar_seq_view knows about). Any vector inputs must be the same length.
I'd like an easy way to refer to vector-like objects in a vague MATLAB/R this-is-vectorized kind of way.
same comment here about packing arguments as much as possible
Sure thing, this should all be pretty easy. I'll go through and see how much I can compress things.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

I gotta ask for help on this one. I'm not sure what's going on, but it feels fishy. @seantalts or @syclik -- you guys might recognize something here -- it doesn't really have much to do with the actual pull.
The first problem I had was the scalar tests for double_exponential_rng were failing when the vector ones weren't.
I found two ways to fix it (and make the scalar double_exponential tests pass).

Replace log with std::log (https://github.com/stan-dev/math/pull/622/commits/9bf8a0ea2d0dd227c1d2c2e66cce728d32cce725).

The effect I was seeing without this is that log(abs(z)) was going to -Inf, regardless of what z was. It felt like double was being cast to int, but I don't know if that should happen.
My guess was that it was only seeing the log definition here: https://github.com/stan-dev/math/blob/develop/stan/math/prim/scal/fun/log.hpp ? Which is only for ints? And for some reason wasn't seeing the usual std::log definition? But this doesn't explain why the vector tests worked.

Replace the stan/math/prim/scal.hpp include with stan/math/prim/mat.hpp

Both of these feel like wrong sorts of fixes. Any idea what could be going on?

I took a 5 minute look and have only one possible suggestion - the old code had a using std::log; statement - was that present still when you saw the -Inf? It seems from my brief reading of it like that using statement is necessary (because as you point out it can only find the log(int) overload for that unqualified name and would thus try implicit conversions).

@seantalts Oh wow, thanks! Problem solved. I didn't notice that.
Yeah I was wondering how abs was working but using std::abs is right there too. I guess something must just be leaking the the mat.hpp header that is accidentally making this work for the vector case when it shouldn't.

We don't need to do it for this pull request, but we really need to start cleaning up our includes and namespaces.  Developers keep trying to sneak in global using statements, which should be caught by cpplint but isn't.  That's where leaks come from.
When you have
  using std::log;
  log(3.2);  // std::log() available
  log(1);  // std::log() available
  std::log(3.2);  // std::log() forced
  std::log(1);  // std::log() forced

The using statement just the function log() (as defined in std::log) into namespace making it a candidate for resolution.  The most specific resolution will be used and it won't compile if there's not a unique most-specific match.
So wht happens when you have std::log(x) that doesn't happen when you have using std::log; log(x)?

I should've added that if you're in namespace stan { namespace math { ... } } context then all of stan::math is automatically available.

So wht happens when you have std::log(x) that doesn't happen when you have using std::log; log(x)?

Both of those should work. I'd messed up and removed the using std::log in one of my commits (this is what Sean pointed out). I switched to being explicit about std::log and std::abs.
On a related note, stan::math::log in prim doesn't seem to support doubles. stan::math::log in rev does (so the autodiff works). Is this considered a bug? If prim doesn't support what rev does?

This should be good to go.

(Please ignore the 3rd failing check - still working out the kinks)

Fixed the merge conflicts with the string stuff, this is good to go again.

Well you didn't see it before cause in the last commit when I was cleaning up whitespace n' such I just moved all the variable declarations to be in one blob :P. I've moved them below the argument checks now. Should be good to go if the tests pass!

Thanks for moving up the argument validation tests.  I approved (don't know why I'm saying that since it's obvious in the interface).


Add support for editing existing providers

Notes from discussion with @vconzola and @jortel : there are two issues we need to work around here:

Secrets (username, password, SA token, etc) can't be loaded and prefilled in the form, they are write-only.
Editing a secret while a migration is running is not a safe operation.

Proposed solutions:

When editing a provider, hide the secret fields behind a checkbox called "Replace credentials". Require those fields if the box is checked, otherwise don't touch the secret.
Don't allow editing a provider at all if it is currently involved in running migrations.


Probably not your fault.. any idea why I am getting "Page Unavailable" with every auth request?

So, I have followed your directions in the Readme.. but after seeing this:

I always see this after confirming and Quizlet never redirects back to my app.....

Here is what my code looks like
 [[Quizlet sharedQuizlet] startWithClientID:@"________"
                                 withSecretKey:@"________"
                               withRedirectURI:@"wasdesign.us://after_oauth"];

And here is what my redirect uri is in the quizlet dashboard:

I just seen the example, and all is ok.
Maybe it's some problem with your quizlet keys and redirect URI.
I see in my test quizlet account:

Please, try to add 'after_oauth' to your redirect URI in the quizlet developer dashboard.

Perfect, thanks @maximbilan I figured it was something simple.

No problem:)


⚠ Tachidesk Server has degraded performance

In e1f212d, Tachidesk Server (https://tachidesk.culturecloud.eu.org) experienced degraded performance:

HTTP code: 502
Response time: 9207 ms

Resolved: Tachidesk Server performance has improved in d9d3e70.


linux: enable ikheaders as optional module

This module provides kernel headers in procfs at runtime, when loaded.
Enabling this option has no runtime overhead if not used and a small
memory overhead if loaded.

Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Archlinux does this:
CONFIG_DEBUG_INFO_BTF=y
CONFIG_PAHOLE_HAS_SPLIT_BTF=y
CONFIG_DEBUG_INFO_BTF_MODULES=y

they also enable ikheaders but I think this is no longer necessary since ebpf tooling should now support BTF for the most part.

In https://github.com/NixOS/nixpkgs/pull/127922 I enable BTF support. You may be interested in this.

Let's do this.


where can i get /ajax/upload.php

please help

Hello,
This would be your own server-side script to handle the upload logic. It doesn't even have to be written in PHP; it can be in whatever language you want.

You can see this for guidance.


DO NOT MERGE: Allow cluster members identified by DNS

These are the raw changes I needed for make for #89. These changes probably need to be gated behind a flag and are not intended to merge.

Using a forked copy until Node name is available in the downward api and bootkube can update to using that without breaking Vagrant examples.


add lowest_geography to dataset model

What
Add lowest_geogrpahy to Dataset model
Trello - https://trello.com/c/lmWyoTS6/5923-add-lowestgeography-to-filterdataset-model-in-filter-api-and-filter-flex-api
How to review
Confirm changes match those requested in Trello ticket
Who can review
Anyone

Changes not required. See comments above


"Unexpected token o in JSON at position 0"

I get the error in the issue title when I send the output from an amazon-echo device node to the JSON converter node.
Göran

Cannot reproduce the issue with v0.1.10 and Node-RED v3.1.8


"since" filter is too coarse-grained

Environment

Python version:
Nautobot version:
nautobot-circuit-maintenance version:

Expected Behavior
Running the job should pick up all emails that arrived since the last time the job was run

Observed Behavior
Because the since filtering is date-based (not date-time based), any emails that arrived during the same day as the last job run will be skipped over, even though they haven't been processed yet.

Steps to Reproduce

Maybe filtering by read/unread status might be a viable alternative?

I've been investigating this, and the goal of the SINCE filter was to limit the emails read to only do it once.
You are right on the observation about SINCE not being good enough for a periodic fetch of notifications, and I agree with you that a viable option, either for IMAP and Gmail API, would be to use the SEEN/UNSEEN flag to retrieve only the UNSEEN and to mark a email as SEEN after being processed.

implemented in #53


[Snyk] Upgrade match-sorter from 6.3.1 to 6.3.3

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to upgrade match-sorter from 6.3.1 to 6.3.3.
:information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

The recommended version is 2 versions ahead of your current version.
The recommended version was released 22 days ago, on 2024-01-16.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:
🧐 View latest project report
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (c3fb3c5) 66.28% compared to head (5d49fcb) 66.28%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #910   +/-   ##
=======================================
  Coverage   66.28%   66.28%
=======================================
  Files          44       44
  Lines         525      525
  Branches       76       76
=======================================
  Hits          348      348
  Misses        172      172
  Partials        5        5

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[Question] Can we donate our actions to the reviewdog organization?

Hi @haya14busa, I have a question about the organization.
I built a github action to scan IaC files with terrascan using reviewdog. I would love to donate it to the organization.
https://github.com/yu-iskw/action-terrascan
What is terrascan?
https://github.com/accurics/terrascan

Terrascan is a static code analyzer for Infrastructure as Code. Terrascan allows you to:
Seamlessly scan infrastructure as code for misconfigurations.
Monitor provisioned cloud infrastructure for configuration changes that introduce posture drift, and enables reverting to a secure posture.
Detect security vulnerabilities and compliance violations.
Mitigate risks before provisioning cloud native infrastructure.
Offers flexibility to run locally or integrate with your CI\CD.

Hi @yu-iskw
The action looks great!
You can donate to the reviewdog org via https://opencollective.com/reviewdog, or please donate individual reviewdog contributors separately.


Added (at least) description meta to index and ambitions

fixed: https://github.com/derekenos/derekenos.com-generator/commit/86a9e63baf2405cca828746176a275a40434ae76

fixed: https://github.com/derekenos/derekenos.com-generator/commit/86a9e63baf2405cca828746176a275a40434ae76


add the integration test of containerd with youki.

But the integration tests of containerd can't pass.
https://github.com/containers/youki/issues/331

Codecov Report

Merging #514 (4492752) into main (bf9a22c) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #514   +/-   ##
=======================================
  Coverage   60.92%   60.92%
=======================================
  Files          86       86
  Lines       12651    12651
=======================================
+ Hits         7707     7708    +1
+ Misses       4944     4943    -1

I'll make it a little smaller


Remove version: Google.Chrome.Canary version 131.0.6734.0

[Automated] It returns code over 400 in all urls
Microsoft Reviewers: Open in CodeFlow

URL: https://dl.google.com/release2/chrome/o6zl7s7cdusponsv6fjaxhqhn4_131.0.6734.0/131.0.6734.0_chrome_installer.exe
Response status code does not indicate success: 404 (Not Found).
(Automated message - build 896)


actions: bump node

Applied mkpr on .github/workflows/*.yml
sed s/18\.5\.0/18.6.0/

:tada: This PR is included in version 1.32.0 :tada:
The release is available on:

npm package (@latest dist-tag)
v1.32.0
GitHub release

Your semantic-release bot :package::rocket:


Login with empty text of password.

hi,
Thanks for this project. It really help me a lot.
But I found out that if I login with an empty text password, it will not be able to login and type account and password again until restart my browser(Chrome).
I think that is because Chrome remember basic-auth with my empty password.
So I add a if addition myAuth.pass !== "" on WebSSH2/app/server/util.js:12
var myAuth = Auth(req)
if (myAuth && myAuth.pass !== "") {
    req.session.username = myAuth.name

And now the input box of login will appear again just like inputing a wrong password!

Okay, I see your problem here... I think I need to solve it a different way, because it's entirely possible that one could have a blank password... PermitEmptyPasswords is a setting in OpenSSH. Let me take a look at this.
And, it should re-prompt if you after a failure, if you have the allowreauth option set to true, which it currently does not. The problem is in my logic. Standby.

Okay, I need to spend more time on that to support a blank password, for now your suggestion will work fine.


Custom route paths doesnt work with strategy no_prefix

Environment
- Operating System: Darwin
- Node Version:     v21.2.0
- Nuxt Version:     3.9.3
- CLI Version:      3.10.0
- Nitro Version:    2.8.1
- Package Manager<EMAIL_ADDRESS>- Builder:          -
- User Config:      devtools, css, modules, i18n, image, ignore, build
- Runtime Modules<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>- Build Modules:    -

Reproduction
https://stackblitz.com/edit/github-bvgtxu?file=nuxt.config.ts
Describe the bug
Config:
  i18n: {
    vueI18n: './i18n.config.ts',
    strategy: 'no_prefix',
    locales: [
      {
        code: 'de',
        iso: 'de-DE',
      },
      {
        code: 'es',
        iso: 'es-ES',
      },
    ],
    customRoutes: 'config',
    pages: {
      'my-page': {
        de: '/my-page-de',
        es: '/my-page-es',
      },
    },
  },

With strategy no_prefix we have the following bugs:

Route /my-page is still available
Route /my-page-de is not available
Using localePath({ name: 'my-page' }) returns the /my-page instead of /my-page-de

Additional context
It works when using strategy prefix_except_default
Logs
No response

As documented, the no_prefix strategy does not support custom paths.

Too bad! The use case is the following:
I have a website which currently only has one language but it already uses nuxt-i18n and is prepared to be translated in the future. Right now the correct strategy to use (if I am not wrong) would be no_prefix but it does not support custom paths.

@BobbieGoede Do you mind answering my last question? :)

When using differentDomains: true, shouldnt also the strategy be no_prefix? This would mean that different domains and custom paths dont work together, or am I wrong?

I didn't build the differentDomains support and I haven't used it myself, based on the docs (https://i18n.nuxtjs.org/options/domain) it looks like no prefixes will be added when using differentDomains, and in the code I can see a warning will be logged if no_prefix strategy is used at the same time (https://github.com/nuxt-modules/i18n/blob/main/src/module.ts#L117-L122).
From what I can gather from this is that differentDomains is a unique case in which custom paths will probably work, and that you can't use no_prefix strategy, though prefixes will not be added, I can only guess this is to ensure localized routes are generated (which would be skipped when using no_prefix).

@MickL: it is working up to version v8.2.0 when omitting the strategy option.
See: https://github.com/nuxt-modules/i18n/pull/2705#issuecomment-2151036409


lutris: clean up metadata

Describe the bug
The packages with the Attribute name

lutris
lutris-free

have no metadata.
Source: https://nixos.org/nixos/packages.html?channel=nixos-19.09&query=lutris
That leads to errors such as that repology don't recognizes the version:
2019-11-04 12:09:38   lutris-free: ERROR: cannot extract version from "lutris"
2019-11-04 12:09:38   lutris: ERROR: cannot extract version from "lutris"

So people don't find nixpkgs in this list: https://repology.org/project/lutris/versions
Maintainer information:
# a list of nixpkgs attributes affected by the problem
attribute: lutris
# a list of nixos modules affected by the problem
module:

cc @chiiruno

PR not merged yet

j


[FLINK-36497][table]Remove all deprecated methods CatalogTable

What is the purpose of the change
Remove all deprecated methods in CatalogTable
Brief change log
Remove all deprecated methods in CatalogTable
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (no)

@Edward-Gavin are going to continue, i'm asking  since ci is currently failng

@flinkbot run azure

Looks like you have failed the spotless check. You need to run mvn spotless:apply and commit the changes first and then you can actually test your code changes.


Add Support for deprecated drush/drush code

First off, I have to say that I love your work, Mr. Glaman!
I am currently on a Drupal module update-spree and having phpstan-drupal, the upgrade status module and drupal-rector makes my life so much easier!! So big thanks for that. :)
I just wanted to ask if there are any plans to also incorporate drush/drush code into this lovely tool! I was just updating a module, when I realized, that it uses deprecated Drush constants, mainly from "vendor/drush/drush/includes/bootstrap.inc", which is full of deprecated constants!
Furthermore, I am unsure, if this should be part of a seperate "phpstan-drush" repository, or part of phpstan-drupal, so feedback on this would be really helpful. :)

Glad this tool helps you out so much!
When analyzing a module that provides Drush commands, it should detect using deprecated code from Drush automatically. The main magic of this package is to bring Drupal's stateful autoloading into a static autoloader. This package does run some of Drush's magic include file loading as well. If the module was using those constants, then PHPStan would report they couldn't be found if not in context.
What I think you might be encountering is our inability to reflect global constants.
See https://github.com/mglaman/phpstan-drupal/blob/main/src/Rules/Deprecations/AccessDeprecatedConstant.php
So you're right – a kind of phpstan-drush would be useful for tracking these. We could open an issue to replicate the AccessDeprecatedConstant rule for known Drush ones.

Sounds good to me.

I agree!

I created a follow-up issue: https://github.com/mglaman/phpstan-drupal/issues/488! I guess we can close this then! :)


Update geth to the newest version

Refs #3264

changed image version from 1.10.20 to 1.10.24

Closing without merging. Upgrading the version is not enough and the entire new setup for Prysm is needed. For now, we will stick to external providers on testnet.


Move RBD snapshot to a new document

currently, RBD snapshot doc is part for the main example README file. https://github.com/ceph/ceph-csi/tree/master/examples#how-to-test-rbd-snapshot-feature. this need to be moved to a new file

need to add a document for RBD cloning also it can be part of the same document

@Madhu-1 is there any document already written for rbd clonning, or I need write myself. Let me know if you have any resource for that.

@yati1998 nothing is there yet, you need to write new one

@Madhu-1 okay sure.

https://github.com/ceph/ceph-csi/blob/master/docs/cephfs-snap-clone.md rename this to snapshot-clone.md and add both cephfs and rbd inside this doc. it should be the same as expand, static pvc etc (refer doc folder)

okay sure.


Unable to run Backend

Backend code on test  give me below error

Please help .

I'm curious which version of Node.js you are running? Have you tried running Node inside of either Window's Linux sub system, or inside Docker?

my node version:- 5.5.1
I am tried this in windows 8

I don't have access to any Windows 8 machines, so I can't debug what is going wrong here. I'd suggest you use a linux server in the cloud, e.g. Google Cloud Compute Engine.


shairport-sync: 3.3.9 -> 4.1.1

Description of changes
Update shairport-sync from 3.9 to 4.1.1. Additionally it is now formatted and enables configuration using function arguments. Differences from the previous version are enabling jack and pipewire backends by default. Airplay 2 is disabled by default to not break the nixos module as running it is much more complicated (requires nqptp). Added myself as a maintainer.
Closes #198387
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Built each enableXXX option successfully and ran the --help command. Ran nixpkgs default build successfully with the pipewire backend. I have not tested the existing nixos module.
Pinging @LnL7

all fixed

shairport-sync 4.1.1 is out -- I was just about to make a PR myself until I saw this.
version = "4.1.1";
...
sha256 = "sha256-EKt5mH9GmzeR4zdPDFOt26T9STpG1khVrY4DFIv5Maw=";

Is the latest sha if you want to update

Note: I also had to add unixtools as an input to get this to build.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/1733

If this could be merged that would be great!  I'm looking to try the new pipewire backend.

If you mention it on the discourse for already reviewed might help it get merged. Been through a few reviews already so should be good ot go (also you can apply the patch yourself if you want). @hexagonal-sun

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-already-reviewed/2617/851


While editing project, page refreshed with message "Cloud synchronization finished. Reloading..."

I'd been editing my project for 30 minutes or so when a toast popped up with the message "Cloud synchronization finished. Reloading...". Then the entire app reloaded. No data was lost, but it was quite unexpected.

I haven't repro'ed this, and recent code changes should have fixed this.


Added the contributors Page and linked it in the footer

Related Issue
Fixes:  #576
Description
Added the contributors Page and linked it in the footer

Type of PR

[ ] Bug fix
[X] Feature enhancement
[ ] Documentation update
[ ] Other (specify): _______________

Screenshots / videos (if applicable)
https://github.com/user-attachments/assets/10a527e1-d054-4366-88a3-7b9c6fd7e883
Checklist:

[X] I have made this change from my own.
[X] My code follows the style guidelines of this project.
[X] I have performed a self-review of my own code.
[X] I have commented my code, particularly in hard-to-understand areas.
[X] I have made corresponding changes to the documentation.
[X] My changes generate no new warnings.
[x] I have tested the changes thoroughly before submitting this pull request.
[X] I have provided relevant issue numbers and screenshots after making the changes.

@PriyaGhosal Please check this PR and merge it and assign this to me and put relevant labels such as gssoc 2024 ext, hacktoberfest and level. i think it can be level 3 because the page is very important in open source to showcase the efforts of the people contributing in building it and it is not static it is dynamic as a new contributor is added to your repo it will be automatically added there so this is the beauty of this. It is fully responsive and i have added the footer and navbar in it too just like the main page right so extra thing. Please label it according to my hardwork and dedication in this.
I want to request you that don't close the issue if you find a issue then mention me i will fix that don't close it, its a request @PriyaGhosal

@tarunkumar2005 Your pull request has been successfully merged! Don't stop here—continue contributing by addressing more issues and aiming to become a top contributor. Exclusive swag awaits for those who go the extra mile!
Great contribution ! 🎉

@sanjay-kv @MastanSayyad please review it


[feature request] material you theme

Material you theme will look good 👍
Also random quotes while opening the app or at home screen will light up the user's mood

Hi, we are also planning to add a material theme.

Hello, are there plans or any guidelines for adding the quotes? I am interested in adding that feature if possible.

Hi @njouud , you can refer themes wiki

@njouud I don't have anything in mind right now,, if you have have any can you post a rough sketch or worefrt

Yeah of course, this is a mockup of a potential implementation, the user would view a screen with a randomized quote and the diaryvault logo which would disappear after 5 seconds or so, also works as a welcome screen. Let me know your thoughts! thanks

Looks good, is it home screen or splash screen

It would be like a splash screen when the app is opened if that sounds good

yes that's cool


when i am using external picker my contact automatically after selecting contact my contact is deleted from phone book

i used delete method on contact which is object of contact so it was deleting my contact as i removed that line my issue is solved


Feature Request - Toggle each menu separately

Allow players to toggle each menu separately. For instance, you're currently able to disable the Creative inventory, but not the anvil inventory. Mainly for containers, but you could also do that in screens like the title screen or the game menu.

I added the Legacy Creative Tab option because of the other mods tabs, which can't be adapted well, but I think if you to play with Legacy4J, you want an experience as similar as possible to Legacy Edition, and add a option to disable each menu isn't easy and unfeasible, mainly for containers, that pratically only the appeareance was modified, with some exceptions, such as villager trades and the creative tab.


Add support for proxies

Is your feature request related to a problem? Please describe.
This feature request is related to #24, #19, and #18.
Describe the solution you'd like
Add support for proxies in token.js as a configurable option.

Needs a bit of tweaking, but it works

Proxies don't work?
I just randomly downloaded a list from https://openproxy.space/generator, but none seemed to work with this? (they do work with curl cmd etc), do you have any recommended way of getting proxies, or is it some kind of bug in the code?

How would you use that proxy? Currently, the proxy just works with GET requests, and works by appending the proxy URL in front of the kahoot URL:
GET http://<IP_ADDRESS>:8080/https://kahoot.it/reserve/session/foo/<?current date>

Alrighty, too bad


Develop

Added web and android media player functionality

 Here is an overview of what got changed by this pull request:

Issues
======
- Added 23

Complexity increasing per file
==============================
- packages/react-native-media-player/android/src/main/java/com/yajananrao/mediaplayer/SeekBarViewManager.java  4
- packages/react-native-media-player/ios/Podfile  2
- packages/react-native-media-player/android/src/main/java/com/yajananrao/mediaplayer/MediaPlayerModule.java  8
- packages/react-native-media-player/android/src/main/java/com/yajananrao/mediaplayer/MediaStyleHelper.java  3
- packages/react-native-media-player/android/src/main/java/com/yajananrao/mediaplayer/MediaPlayerService.java  7
- packages/react-native-media-player/android/src/main/java/com/yajananrao/mediaplayer/Utils.java  8
- packages/react-native-media-player/android/src/main/java/com/yajananrao/mediaplayer/MediaPlayerPackage.java  2

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Issues
======
- Added 23

Complexity increasing per file
==============================
- packages/react-native-media-player/android/src/main/java/com/yajananrao/mediaplayer/MediaPlayerService.java  7
- packages/react-native-media-player/android/src/main/java/com/yajananrao/mediaplayer/MediaStyleHelper.java  3
- packages/react-native-media-player/android/src/main/java/com/yajananrao/mediaplayer/Utils.java  8
- packages/react-native-media-player/android/src/main/java/com/yajananrao/mediaplayer/MediaPlayerModule.java  8
- packages/react-native-media-player/android/src/main/java/com/yajananrao/mediaplayer/MediaPlayerPackage.java  2
- packages/react-native-media-player/ios/Podfile  2
- packages/react-native-media-player/android/src/main/java/com/yajananrao/mediaplayer/SeekBarViewManager.java  4

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Issues
======
- Added 27

Complexity increasing per file
==============================
- packages/react-native-media-player/android/src/main/java/com/yajananrao/mediaplayer/SeekBarViewManager.java  4
- packages/react-native-media-player/android/src/main/java/com/yajananrao/mediaplayer/MediaPlayerModule.java  8
- packages/react-native-media-player/android/src/main/java/com/yajananrao/mediaplayer/MediaPlayerPackage.java  2
- packages/react-native-media-player/android/src/main/java/com/yajananrao/mediaplayer/MediaPlayerService.java  7
- packages/react-native-media-player/ios/Podfile  2
- packages/react-native-media-player/src/WebPlayer.ts  2
- packages/react-native-media-player/android/src/main/java/com/yajananrao/mediaplayer/MediaStyleHelper.java  3
- packages/react-native-media-player/android/src/main/java/com/yajananrao/mediaplayer/Utils.java  8

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Issues
======
- Added 28

Complexity increasing per file
==============================
- packages/react-native-media-player/android/src/main/java/com/yajananrao/mediaplayer/MediaPlayerService.java  7
- packages/react-native-media-player/android/src/main/java/com/yajananrao/mediaplayer/MediaStyleHelper.java  3
- packages/react-native-media-player/android/src/main/java/com/yajananrao/mediaplayer/MediaPlayerPackage.java  2
- packages/react-native-media-player/android/src/main/java/com/yajananrao/mediaplayer/Utils.java  8
- packages/react-native-media-player/android/src/main/java/com/yajananrao/mediaplayer/SeekBarViewManager.java  4
- packages/react-native-media-player/src/WebPlayer.tsx  2
- packages/react-native-media-player/android/src/main/java/com/yajananrao/mediaplayer/MediaPlayerModule.java  8
- packages/react-native-media-player/ios/Podfile  2

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Issues
======
- Added 27

Complexity increasing per file
==============================
- packages/react-native-media-player/android/src/main/java/com/yajananrao/mediaplayer/MediaPlayerModule.java  8
- packages/react-native-media-player/android/src/main/java/com/yajananrao/mediaplayer/MediaPlayerPackage.java  2
- packages/react-native-media-player/android/src/main/java/com/yajananrao/mediaplayer/Utils.java  8
- packages/react-native-media-player/android/src/main/java/com/yajananrao/mediaplayer/MediaPlayerService.java  7
- packages/react-native-media-player/android/src/main/java/com/yajananrao/mediaplayer/SeekBarViewManager.java  4
- packages/react-native-media-player/android/src/main/java/com/yajananrao/mediaplayer/MediaStyleHelper.java  3
- packages/react-native-media-player/ios/Podfile  2
- packages/react-native-media-player/src/WebPlayer.tsx  2

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 2
- Added 33

Complexity increasing per file
==============================
- ios/Podfile  1
- packages/react-native-media-player/android/src/main/java/com/yajananrao/mediaplayer/MediaPlayerModule.java  8
- packages/react-native-media-player/android/src/main/java/com/yajananrao/mediaplayer/MediaPlayerPackage.java  2
- packages/react-native-media-player/android/src/main/java/com/yajananrao/mediaplayer/Utils.java  8
- packages/react-native-media-player/android/src/main/java/com/yajananrao/mediaplayer/MediaStyleHelper.java  3
- packages/react-native-media-player/android/src/main/java/com/yajananrao/mediaplayer/SeekBarViewManager.java  4
- packages/react-native-media-player/android/src/main/java/com/yajananrao/mediaplayer/MediaPlayerService.java  7

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 3
- Added 18

Complexity increasing per file
==============================
- packages/react-native-media-player/android/src/main/java/com/yajananrao/mediaplayer/MediaPlayerPackage.java  2
- packages/react-native-media-player/android/src/main/java/com/yajananrao/mediaplayer/MediaPlayerService.java  7
- packages/react-native-media-player/android/src/main/java/com/yajananrao/mediaplayer/MediaStyleHelper.java  3
- ios/Podfile  1
- packages/react-native-media-player/android/src/main/java/com/yajananrao/mediaplayer/MediaPlayerModule.java  8
- packages/react-native-media-player/android/src/main/java/com/yajananrao/mediaplayer/SeekBarViewManager.java  4
- packages/react-native-media-player/android/src/main/java/com/yajananrao/mediaplayer/Utils.java  8

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 3
- Added 17

Complexity increasing per file
==============================
- packages/react-native-media-player/android/src/main/java/com/yajananrao/mediaplayer/Utils.java  8
- packages/react-native-media-player/android/src/main/java/com/yajananrao/mediaplayer/MediaPlayerPackage.java  2
- ios/Podfile  1
- packages/react-native-media-player/android/src/main/java/com/yajananrao/mediaplayer/MediaStyleHelper.java  3
- packages/react-native-media-player/android/src/main/java/com/yajananrao/mediaplayer/MediaPlayerModule.java  8
- packages/react-native-media-player/android/src/main/java/com/yajananrao/mediaplayer/MediaPlayerService.java  7
- packages/react-native-media-player/android/src/main/java/com/yajananrao/mediaplayer/SeekBarViewManager.java  4

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 3
- Added 17

Complexity increasing per file
==============================
- ios/Podfile  1
- packages/react-native-media-player/android/src/main/java/com/yajananrao/mediaplayer/MediaStyleHelper.java  3
- packages/react-native-media-player/android/src/main/java/com/yajananrao/mediaplayer/SeekBarViewManager.java  4
- packages/react-native-media-player/android/src/main/java/com/yajananrao/mediaplayer/MediaPlayerService.java  7
- packages/react-native-media-player/android/src/main/java/com/yajananrao/mediaplayer/Utils.java  8
- packages/react-native-media-player/android/src/main/java/com/yajananrao/mediaplayer/MediaPlayerModule.java  8
- packages/react-native-media-player/android/src/main/java/com/yajananrao/mediaplayer/MediaPlayerPackage.java  2

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 3
- Added 16

Complexity increasing per file
==============================
- packages/react-native-media-player/android/src/main/java/com/yajananrao/mediaplayer/MediaPlayerModule.java  8
- packages/react-native-media-player/android/src/main/java/com/yajananrao/mediaplayer/SeekBarViewManager.java  4
- packages/react-native-media-player/android/src/main/java/com/yajananrao/mediaplayer/Utils.java  8
- packages/react-native-media-player/android/src/main/java/com/yajananrao/mediaplayer/MediaStyleHelper.java  3
- packages/react-native-media-player/android/src/main/java/com/yajananrao/mediaplayer/MediaPlayerService.java  7
- packages/react-native-media-player/android/src/main/java/com/yajananrao/mediaplayer/MediaPlayerPackage.java  2
- ios/Podfile  1

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 3
- Added 22

Complexity increasing per file
==============================
- packages/react-native-media-player/android/src/main/java/com/yajananrao/mediaplayer/Utils.java  8
- ios/Podfile  1
- packages/react-native-media-player/android/src/main/java/com/yajananrao/mediaplayer/MediaPlayerService.java  7
- packages/react-native-media-player/android/src/main/java/com/yajananrao/mediaplayer/MediaPlayerModule.java  8
- packages/react-native-media-player/android/src/main/java/com/yajananrao/mediaplayer/MediaPlayerPackage.java  2
- packages/react-native-media-player/android/src/main/java/com/yajananrao/mediaplayer/SeekBarViewManager.java  4
- packages/react-native-media-player/android/src/main/java/com/yajananrao/mediaplayer/MediaStyleHelper.java  3

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 3
- Added 22

Complexity increasing per file
==============================
- packages/react-native-media-player/android/src/main/java/com/yajananrao/mediaplayer/Utils.java  8
- ios/Podfile  1
- packages/react-native-media-player/android/src/main/java/com/yajananrao/mediaplayer/MediaPlayerService.java  7
- packages/react-native-media-player/android/src/main/java/com/yajananrao/mediaplayer/MediaPlayerPackage.java  2
- packages/react-native-media-player/android/src/main/java/com/yajananrao/mediaplayer/SeekBarViewManager.java  4
- packages/react-native-media-player/android/src/main/java/com/yajananrao/mediaplayer/MediaPlayerModule.java  8
- packages/react-native-media-player/android/src/main/java/com/yajananrao/mediaplayer/MediaStyleHelper.java  3

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 3
- Added 17

Complexity increasing per file
==============================
- packages/react-native-media-player/android/src/main/java/com/yajananrao/mediaplayer/MediaStyleHelper.java  3
- packages/react-native-media-player/android/src/main/java/com/yajananrao/mediaplayer/SeekBarViewManager.java  4
- packages/react-native-media-player/android/src/main/java/com/yajananrao/mediaplayer/MediaPlayerModule.java  8
- packages/react-native-media-player/android/src/main/java/com/yajananrao/mediaplayer/MediaPlayerService.java  7
- ios/Podfile  1
- packages/react-native-media-player/android/src/main/java/com/yajananrao/mediaplayer/Utils.java  8
- packages/react-native-media-player/android/src/main/java/com/yajananrao/mediaplayer/MediaPlayerPackage.java  2

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 3
- Added 17

Complexity increasing per file
==============================
- packages/react-native-media-player/android/src/main/java/com/yajananrao/mediaplayer/SeekBarViewManager.java  4
- packages/react-native-media-player/android/src/main/java/com/yajananrao/mediaplayer/Utils.java  8
- packages/react-native-media-player/android/src/main/java/com/yajananrao/mediaplayer/MediaPlayerModule.java  8
- packages/react-native-media-player/android/src/main/java/com/yajananrao/mediaplayer/MediaStyleHelper.java  3
- packages/react-native-media-player/android/src/main/java/com/yajananrao/mediaplayer/MediaPlayerService.java  7
- ios/Podfile  1
- packages/react-native-media-player/android/src/main/java/com/yajananrao/mediaplayer/MediaPlayerPackage.java  2

See the complete overview on Codacy


Log says "Heartbeat successfully sent" even when a network error occurs.

LogTemp: Warning: WakaTime: Sending Heartbeat
LogTemp: Warning: WakaTime: Heartbeat successfully sent.

^ Shows up even though there is no way the heartbeat was actually sent due to no internet connection

https://wakatime.com/faq says
When working offline with supported editors* your coding activity is saved in an sqlite3 database at $HOME/.wakatime.db. The next time you use your IDE when online, your coding activity is synchronized to your WakaTime dashboard.
Due to this, the message is, in fact, correct.


Add the object name to the output

E.g. in case the call is from within a script.
Also in the short version.
Cheers

@5trobl That's an interesting idea. Do you have a specific way of doing this in mind?
I suppose we're talking about reading original variable name passed to a function. If so, it's not so easy to do in Python.
In case we want to read "y" name from snippet:
y = 7
wat / y

we'd have to do something hacky and unreliable like https://stackoverflow.com/a/2749857/6772197. Or is there a better way?
Still, this won't work, if we call this on an anonymous, temporary variables:
wat / (2+2)
wat / math.sqrt(4)

Thank you! It works beautifully.
I wonder... why use a modifier at all, rather than by default? If it only shows up for scripts, then you're always going to need it, right?
What about showing it at the top, prior to value?

I wonder... why use a modifier at all, rather than by default? If it only shows up for scripts, then you're always going to need it, right?

Actually, some information would be still displayed in python console when it's enabled. It doesn't show "caller expression", but "caller file" is there. It doesn't say anything useful though. I believe it would be a bit annoying to always see this line:
caller file: <stdin>:1

Plus, I would have to rewrite most of the unit tests, because test cases would be treated as a script. I know it's not a good argument because it's only about tests, but it makes it all clear and simpler to have it disabled by default. I like to operate on "pure functions".

What about showing it at the top, prior to value?

yeah, maybe it makes sense to first see where it comes from and then what it is. I'll change that.


Doll crashes servers when placed

Minecraft version:
Unabridged or Abridged version:
Issue Description:
Steps to Reproduce:
Crash report or log (uploaded to gist.github.com or pastebin.com):

Fixed in R14


Unable to sign in to Google from pyportify when using Chrome

Hi,
I'm on Windows trying to sign in to Google.  The following error is displayed in the pyportify.exe console window when I click the Submit button.
Error handling request
Traceback (most recent call last):
File "site-packages\aiohttp\server.py", line 266, in start
File "site-packages\aiohttp\web.py", line 90, in handle_request
File "pyportify\app.py", line 36, in google_login
File "site-packages\aiohttp\web_reqrep.py", line 334, in json
File "json__init__.py", line 319, in loads
File "json\decoder.py", line 339, in decode
File "json\decoder.py", line 357, in raw_decode
json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)
This only seems to happen in Chrome.  If I do the same thing in IE, it works fine.

fwiw i just ran into the same issue when trying to log in w/ 2-step verification turned on on my goog account. turning it off seemed to solve the issue for me.

Hmm, I had no problems with 2FA, but I used an app password for pyportify.

Don't turn off your 2-step for this. Use app passwords like russjr08 said https://security.google.com/settings/security/apppasswords

Why people keep recommending that Google app password? The link leads to nowhere.

Do you have 2FA enabled for sure? It takes me to the proper page.
I'd upload a screenshot but I'm on mobile and am a bit too lazy to find somewhere to upload it at the moment :P try searching "Google App Password" on Google.


Feature/fix zod tuple length

This is just a repro regarding the discovered tuples issue

Fixed by @stijnvanhulle himself


[Fix] red glowstick glow duration

About the PR

fixes #19856
Why / Balance

Technical details

Media

[ ] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

Thank you for your contribution. Because this change was not significant enough for a Changelog entry, I have opted to remove it.


Re-enable and fix Node Variants

This reverts #453. Should be merged in accordance with timeline in #451.
An additional PR fixing the build failures is needed and should be merged into this one.

#457 was merged into this, fixing the Node variant.


install-core issues

Hardcoded URLs and file paths: The script uses hardcoded URLs for downloading Bitcoin Core and its checksums. If the URLs change or the files are moved, the script will break. Similarly, the script assumes a certain directory structure. If this structure changes, the script could behave unpredictably.

No verification of the GPG keys: Although the script checks the GPG signatures of the downloaded files, it doesn't check the authenticity of the GPG keys used to sign the files. An attacker who can intercept the download could replace the files and the GPG keys with their own, and the script wouldn't be able to tell the difference.

No error handling: The script doesn't handle errors in many places. If a command fails, the script may continue running with potentially inconsistent or incorrect data.

Use of HTTP instead of HTTPS: The script tries to download files over HTTP before falling back to HTTPS. Downloading files over HTTP is insecure because the data is not encrypted in transit.

Unsecured temporary files: The script creates temporary files without using any measures to secure them. This could potentially expose sensitive data.

Hello git-sgmoore, your code review is greatly appreciated.

I will use variables to store the URLs for downloading Bitcoin Core and its checksums. This way, if the URLs change in the future, we can easily modify the script without breaking it.
I actually do check the authenticity of the GPG keys from two sources: openpgp.org onion service and guix.sigs/builder-keys repository on bitcoin's github, if it cannot find the signer's public key in both these locations it will NOT import that gpg key nor count it as a valid signature towards the threshold 2 good_sigs. Were the signature file faked, they'd also need to fake guix.sigs/builder-keys and upload fraudulent keys to the key server. The last line of defense in that case is the user manually verifying the fingerprint displayed matches the name of the person they are choosing to trust. Let me know if there's anything more I should do or if you want me to explain the check_sigs() function, it probably needs better documentation if it indeed does what I said and that was not clear.
I can experiment with using set -e to make the script exit immediately if any command exits with a non-zero status. I've run it hundreds of times and it's generally pretty stable, can you give me some commands in particular that are likely to fail, it handles the downloads and checkums failing.
http://6hasakffvppilxgehrswmffqurlcjjjhd76jgvaqmsg6ul25s7t3rzyd.onion/en/download/ this is an .onion hidden service url for bitcoincore.org. It's also commented out and not used because the onion service has been down this month. I'm unsure if https was ever available with this service but I'll make sure to use it if they ever fix it.
There is no unencrypted sensitive data stored in temporary files, they're created with mktemp and delete themselves after the script exits
You'd prefer the terminal stay open? I agree it could be risky if someone was working in another terminal simultaneously and lost their work. The only purpose of that command was to clean up the user's desktop after installation. Let me know if you see any other risks besides what I've mentioned. My target user does not even know how to use the terminal so I find this unlikely, but expert users are finding all kinds of edge cases.

For Question 1, I agree the wget commands shouldn't have the URLs directly in the command. The URLs should be variables at the top of the script.
@git-sgmoore does that address your concern here? Of not, how do you suggest Bails would handle a change in the bitcoincore [dot] org directory structure?

@epiccurious you've seemed to have satisfied 1 and 3. I'm fixing 2 with #17 . 4 appears to be invalid and irrelevant since the onion service is still down.
Is 5 invalid? In my bash scripts install-core and setup-persistence what temporary files are leaving sensitive data exposed to other processes on the machine? If none, we can ignore and just clean them up for tidiness sake.
I just figured out how to solve 6 and only close the calling terminal.
PARENT_PID=$(ps -o ppid= -p $$)
echo "Parent PID: $PARENT_PID"
sleep 2
kill -9 $PARENT_PID

So at the completion of install-core it will say "Closing terminal window in 10 seconds, press any key to abort" and count down then issue the kill command.
I'll merge the fix for 6 into master and we should have this important issue closed early this week!

Part 6 resolved by https://github.com/BenWestgate/Bails/commit/69d503916aa8465bc972ef0cdc665cfdc0dfa50c.

Part 5

$XDG_RUNTIME_DIR defines the base directory relative to which user-specific non-essential runtime files and other file objects (such as sockets, named pipes, ...) should be stored. The directory MUST be owned by the user, and he MUST be the only one having read and write access to it. Its Unix access mode MUST be 0700.

This is where we should be making our temporary files. That way other processes on the machine cannot read our files.

Hardcoded URLs and file paths: The script uses hardcoded URLs for downloading Bitcoin Core and its checksums. If the URLs change or the files are moved, the script will break. Similarly, the script assumes a certain directory structure. If this structure changes, the script could behave unpredictably.

@epiccurious: has a branch that resolved this. PR it again at your leisure.

No verification of the GPG keys: Although the script checks the GPG signatures of the downloaded files, it doesn't check the authenticity of the GPG keys used to sign the files. An attacker who can intercept the download could replace the files and the GPG keys with their own, and the script wouldn't be able to tell the difference.

I have assigned myself to this. He is right that I trust the download source to get the GPG keys and my only verification is the user and key server searching the fingerprints are correct. The key server could be faked and 99% of users will not verify fingerprints from another source.
Instead we should download the keys from github.com/bitcoin/bitcoin since we're already trusting GitHub in the install instructions, and use those keys plus some I hardcore into this project repo. Verify by default with a few of these. Then change the option to "Additional Verification" where the user can trust and untrust the current signatures in the file until they reach the threshold of 2.

No error handling: The script doesn't handle errors in many places. If a command fails, the script may continue running with potentially inconsistent or incorrect data.

@epiccurious handled this as well in his branch, at least where it mattered.

Use of HTTP instead of HTTPS: The script tries to download files over HTTP before falling back to HTTPS. Downloading files over HTTP is insecure because the data is not encrypted in transit.

This is currently irrelevant, bitcoincore dot org doesn't seem to have intentions of fixing their onion service any time soon. So we start with https clearnet.

Unsecured temporary files: The script creates temporary files without using any measures to secure them. This could potentially expose sensitive data.

The $TMP_DIR was changed to $XDG_RUNTIME_DIR which is restricted only to the current user, preventing other users from reading the data. Although nothing sensitive was stored in install-core.

This was changed to query the actual PID of the executing terminal and kill only that terminal and only after a 30 second delay. We no longer kill every terminal.
@epiccurious: we can close this issue now when you PR your 1 & 3. Good to see our first security review addressed completely.


Coin activate MEM chips

… while coin aren't affected by MEM chips.
MEM chips are already underpowered, by if coins activate it preventr those chups to potentially catch another attacker right behind 😄
MEM chips shouldn't be activated by coins.

Se issue 67 ... I think that the only thing of preventing the combination ACC+MEM from winning every game is the fact that coins are immune to this.

(Referencing issue #67 for later)
I'm not asking for MEM chips to catch coins.
I'm saying that, since coins are not affected by MEM chips, these MEM chips shouldn't activate when a coin goes by them. Since they have quite a big cooldown, having a coin activate them without being affected means it essentialy doubles its cooldown timer, and potentially prevents them from eating an attacker that would be hugging the coin.

Ah, I see. That's a bug.

fixed in 1.27.


[BUG] Check mount failed after vol has create successed.

What is your environment(Kubernetes version, Fluid version, etc.)
k8s 1.24+k3s1
Describe the bug
Cannot check mount after create vol.
What you expect to happen:
My owner container cannot bootstrap after fuse sidecar already boot.
How to reproduce it
Additional Information
Please update alpine linux image.

Use raw operation. Some like cat /proc/mounts for NOT depend on 'mount'.

I also delpoy k8s v1.22.15+rke2r1 with Ubuntu 20.04.4 LTS   5.4.0-100-generic   containerd://1.5.13-k3s1,but when I use command mount to check csi-nodeplugin-fluid plugins pod, it return empty, use cat /proc/1/mountinfo|grep fuse reurn something.I can't start demo-app to mount example dataset.


Checkbox plugin iCheck cannot  be clicked in mobile emu

Using iCheck makes the checkbox unresponsive when clicked in mobile emulator. When switched back to PC mode it can be clicked.

at this moment I revert back the checkbox to the original design class. Just in case if the checkbox failed to perform in the real world.


Add some change to be production ready

Hello @kost,
We want to use your gem for production purpose. I would like to know if you agree to accept PR for a 1.0.0 release ?

Please see our fork : https://github.com/Cyberwatch/nessus_rest-ruby


[typescript] non nullable GraphQL inputs with default values should NOT be optional for BE code

Describe the bug
If the default value for a non-nullable field is set, the generated output marks the field as optional i.e. suffixed with ?
To Reproduce
Steps to reproduce the behavior:

My GraphQL schema:

ordersSearch(
    size: Int! = 10
    offset: Int! = 0
)

My GraphQL operations:

ordersSearch

My codegen.yml config file:

generates:
    schema:

    plugins:
      - typescript
      - typescript-resolvers
    config:
      federation: true
      contextType: ...
      constEnums: false
      enumsAsTypes: false
      numericEnums: false
      futureProofEnums: false
      enumsAsConst: false
      onlyOperationTypes: false
      immutableTypes: false
      maybeValue: T | null
      noExport: false
      enumPrefix: true
      fieldWrapperValue: T
      wrapFieldDefinitions: false
      skipTypename: false
      nonOptionalTypename: false
      useTypeImports: false

Expected behavior
The type generated for inputs with default values i.e. size and offset should NOT be optional for the typing used in the back-end service, because the value will never be undefined.
Environment:

OS: macOS Big Sur
@graphql-codegen/...: ^1.20.1
NodeJS: V14

Additional context
This is related to another MR: https://github.com/dotansimha/graphql-code-generator/issues/4273
I suspect the request in that MR was based on the assumption that code-gen is only used in the front-end/client application, but we use it in the back end. So there should be a configuration for deciding how the default is treated.

@HunderlineK Can you help us out with sending a PR with a failing test for this?

@n1ru4l As you suggested, I was about to create a failing test (which I didn't succeed - for some reason most of the tests fail on my local setup), but looking at the code I realized there might already be anavoidOptional.defaultValue config flag that provides the behavior I desired as implemented in this MR:
https://github.com/dotansimha/graphql-code-generator/pull/5113
I will verify and if it does not work as expected, I'll re-open the issue, thanks!


Returning view models with additional response data

Controllers can return views or view models directly:
    #[Get(uri: '/')]
    public function __invoke(): View
    {
        return new HomeView(
            name: 'Brent',
        );
    }

This logic happens in the router:
    private function createResponse(Response|View $input): Response
    {
        if ($input instanceof View) {
            return response($input->render($this->appConfig));
        }

        return $input;
    }

First of all, the router shouldn't be concerned with doing this, I suggest to move this logic to the ResponseSender once that's merged (#100). We also need to find a way to access the response object from within the view to modify it, eg. to send headers.

@aidan-casey , would love your input, especially on the second part about getting access to the response.

Let me think on this for a bit. I feel like the router should be returning a response and the sender should simply be sending one, but I'm not sure where that puts this.

@brendt - I am still assembling my thoughts, but I think they basically boil down to this:

The implementation of a response factory. The response factory's only goal is to eventually boil everything down to plain text and return a response object. The router is only concerned about about getting that response object.
The implementation of a view renderer. Somehow (unsure yet how) this can determine different types of views (markdown, html, etc.) and pass them to the correct driver. These then convert the template to plain text.

Not sure if that makes sense or not. 😛

So, a couple of options:
1. Have View extend Response
#[Get('/view-model-with-response-data')]
public function viewModelWithResponseData(): View
{
    return (new ViewModelWithResponseData())
        ->header('x-from-viewmodel', 'true')
        ->status(Status::CREATED);
}

Pros:

Technically, a View is a specialised form of a Response, at leas the way we deal with them in Tempest
You get access to all Response methods on the View directly

Cons:

It might feel weird and incorrect

2. View implements their own header and status methods
We'll copy over this data to the response when creating the response
#[Get('/view-model-with-response-data')]
public function viewModelWithResponseData(): View
{
    return (new ViewModelWithResponseData())
        ->header('x-from-viewmodel', 'true')
        ->status(Status::CREATED);
}

Pros:

We can keep the same public API as the first example
I might feel more correct to people who felt the first option isn't correct

Cons:

Code duplication between Response and View

3. Introduce a way to convert the View to a Response within the controller
This way we can return a response, and we have access to everything. There are several ways of doing so.
A view function takes a View and returns a Response:
return view(new ViewModelWithResponseData())
    ->header('x-from-viewmodel', 'true')
    ->status(Status::CREATED);

A toResponse method on the View:
return (new ViewModelWithResponseData())
    ->toResponse()
    ->header('x-from-viewmodel', 'true')
    ->status(Status::CREATED);

Or a factory:
#[Get('/view-model-with-response-data')]
public function viewModelWithResponseData(ResponseFactory $factory): View
{
    return $factory->make(new ViewModelWithResponseData())
        ->header('x-from-viewmodel', 'true')
        ->status(Status::CREATED);
}

Pros:

Complete separation between View and Response, which might feel more correct
We could make it so that controllers may only return Response objects, leading to less available ways to do something

Cons:

It's more verbose, you need two steps to returning a ViewModel
In both the view() and toResponse() options, we'll need to rely on service location to actually render the view (it needs access to AppConfig. The ResponseFactory option doesn't have this problem, but feels even more verbose.

A very good argument on Twitter: https://twitter.com/Geelik/status/1764571588425396505
"A view can be used in other contexts as well, eg. for mails"

return response()
       ->status(Status::CREATED)
       ->header('x-from-viewmodel', 'true')
       ->view(new ViewModelWithResponseData());

This is the perfect solution. Thanks @aidan-casey 😅

Fixed.


Models without revisions can't be added to the dashboard

mine() scope used here:
https://github.com/area17/twill/blob/master/src/Http/Controllers/Admin/DashboardController.php#L393
is defined only at the HasRevisions trait, causing the dashboard to break if that model has no revisions.
https://github.com/area17/twill/blob/master/src/Models/Behaviors/HasRevisions.php#L12

Hi @ferpetrelli!
We should definitely prevent the dashboard from breaking in that case however the idea of the module for drafts in the dashboard is to display drafts records that do have revisions created by the currently logged in user. The drafts feature is disabled by default if not specified in a dashbord module configuration, so we could decide that it is indeed only compatible with models that use revisions. That shouldn't be a reason for breaking the page entirely though and one could argue that all drafts from models that have no revisions could should up there. Going down that path, we could create a configuration key to toggle that decision.

Fixed in 0481894d!


move section on inputting data

Moved section on inputting data to exercise one; renumbered the remaining exercises

It looks okay. The link in Exercise 4 to Exercise 3 is redirecting to a page of html, but I am not sure if that's normal because it's just a preview. If it's not, I am sorry!


curl "error setting certificate verify locations" after installing rh-dotnet30 on RHEL 7.7

Summary: cURL starts failing with "curl: (77) error setting certificate verify locations" after installing rh-dotnet3 package and enabling rh-dotnet30 SCL.
Steps to reproduce with RHEL 7.7 VM in Azure:

Create a new Azure VM from RHEL 7.7 image;

Log into the newly created VM with Cloud (or local) Shell;

Execute 'sudo yum update' to make sure that all recent updates have been installed;

Confirm that cURL works, e.g. curl https://www.google.com

Install rh-dotnet30 package: sudo yum install rh-dotnet30 -y;

Confirm curl is still functional;

Switch to rh-dotnet30 SCL: scl enable rh-dotnet30 bash;

Try using curl to connect to any resource and observe the error

Expected behavior:
cURL is functional with rh-dotnet30 software collection.
Impact:
I cannot complete Azure DevOps build agent configuration on a RHEL 7.7 machine with .NET Core 3 support, since Build Agent uses cURL internally to connect to Azure DevOps server.
New Issue:
rh-dotnet22 works fine and doesn't have similar issue.

Also tracked here: https://bugzilla.redhat.com/show_bug.cgi?id=1768029
There's a workaround suggested here:
export CURL_CA_BUNDLE=/etc/pki/tls/certs/ca-bundle.crt

Depending on what you are doing (do you need curl when running .NET Core?) you can invoke curl first, then run the scl ...  commands for invoking .NET Core.

@DmitryGulin  did the suggestion provided by @omajid work for you?

A fix for the RPM to address this bug was just released. If you update the VM, a workaround shouldn't be needed anymore.

Are there any plans to publish that update to rhel-7-server-dotnet-rpm repo as well, so that I can update our on-prem server?

I thought that's exactly where the update was pushed. And Azure picked it up from there. Are you seeing something different on your end?

I've got rh-dotnet30 package and all dependencies installed from rhui-rhel-7-server-dotnet-rhui-rpms on Azure VM and noticed that rh-dotnet30-libcurl, for example, was version 7.61.0-6.el7.
Installing rh-dotnet30 on my corporate server would get it installed from rhel-7-server-dotnet-rpms and rh-dotnet30-libcurl version I'm getting from there is 7.61.0-5.el7.
Thus a assumed that update was not available outside of RHUI repos yet.

@DmitryGulin Can you open a support ticket? If you are not seeing rh-dotnet30-libcurl-7.61.0-6.el7.x86_64.rpm as the latest release, that seems like a problem somewhere in software delivery pipeline.

@omajid  I've got this update installed on my on-prem server via rhel-7-server-dotnet-rpms today.
Not sure what was the reason for delay yesterday, but I confirm that the issue has been fixed on-prem as well, thus it can be closed.
Thank you so much!