[v0.11.0] error message not clear when loading invalid TLS secret reference

What steps did you take and what happened:

created a secret of type kubernetes.io/dockerconfigjson
referenced unexpected secret type in Ingress specification for TLS configuration
received error message in logs

contour-6bdd96f88-ftrfp envoy [2019-06-13 05:03:08.569][000001][warning][config] [bazel-out/k8-opt/bin/source/common/config/_virtual_includes/grpc_mux_subscription_lib/common/config/grpc_mux_subscription_impl.h:70] gRPC config for type.googleapis.com/envoy.api.v2.Listener rejected: Proto constraint validation failed (ListenerValidationError.FilterChains[i]: ["embedded message failed validation"] | caused by FilterChainValidationError.TlsContext: ["embedded message failed validation"] | caused by DownstreamTlsContextValidationError.CommonTlsContext: ["embedded message failed validation"] | caused by CommonTlsContextValidationError.TlsCertificates[i]: ["embedded message failed validation"] | caused by TlsCertificateValidationError.CertificateChain: ["embedded message failed validation"] | caused by field: "specifier", reason: is required): name: "ingress_https"

What did you expect to happen:
Error message in logs
secret namespace/name was malformed and unable to be loaded as a TLS listener

Environment:

Contour version: v0.11.0
Kubernetes version: (use kubectl version): v1.14.2
Kubernetes installer & version: kind v0.4.0-alpha
Cloud provider or hardware configuration: local
OS (e.g. from /etc/os-release): osx

Thanks for raising this issue. I'll write a regression test for this now.
Can you please confirm for me:

Which version of Envoy is the customer using?
Does 0.12.1 fix the problem?

@pickledrick thanks for raising this issue. I write up some regression tests in #1170 but was not able to reproduce the issue you reported. As far as I can tell, even going back to 0.11, Contour has always checked that the tls.crt and tls.key keys are present in the secret before Contour will consider it valid.
Are you able to share some more details about the issue that was reported to you so I can help get to the bottom of how that invalid secret made it through to Envoy.

Specific steps to reproduce
ingress-secret.yaml
cat <<EOF > ingress.yaml
---
apiVersion: v1
data:
  .dockerconfigjson: ewogICAgImF1dGhzIjogewogICAgICAgICJodHRwczovL2luZGV4LmRvY2tlci5pby92MS8iOiB7CiAgICAgICAgICAgICJhdXRoIjogImMzUi4uLnpFMiIKICAgICAgICB9CiAgICB9Cn0K
kind: Secret
metadata:
  name: regcred
type: kubernetes.io/dockerconfigjson
---
apiVersion: extensions/v1beta1
kind: Ingress
metadata:
  labels:
    app: kuard
  name: kuard
spec:
  backend:
    serviceName: kuard
    servicePort: 80
  rules:
  - host: some-app.company.net
  tls:
  - hosts:
    - some-app.company.net
    secretName: regcred
EOF

kind create cluster
export KUBECONFIG="$(kind get kubeconfig-path --name="kind")"
 git clone git@github.com:heptio/contour.git
cd contour
git checkout release-0.11
kubectl apply -f deployment/deployment-grpc-v2/
kubectl apply -f https://j.hept.io/contour-kuard-example
kubectl -n heptio-contour scale deploy contour --replicas=1
kubectl apply -f ingress.yaml
kubectl -n heptio-contour logs -f <pod-name> envoy | grep warning

The warning error is returned from envoy, however contour does not supply a meaningful error.

Customer is using  envoy v1.9.1, testing contour v0.12.1

Using the release-0.12 release branch to deploy, envoy still at v1.9.1 doesn't return the same error? Not too sure why. Perhaps different configuration? And no error is returned from contour.

Thanks for the update. 0.11 did no validation of the secret, as long as there was something that matched the name, contour would feed it to envoy. This was fixed in 0.12 and has been strengthened to be even stricter in 0.13 (due next week)
Given than versions of Contour < 0.12.1 should not be used, can we call this issue closed?

On 14 Jun 2019, at 11:05, Peter Grant<EMAIL_ADDRESS>wrote:
Using the release-0.12 release branch to deploy, envoy still at v1.9.1 doesn't return the same error? Not too sure why. Perhaps different configuration? And no error is returned from contour.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub, or mute the thread.

@davecheney , I brought your question with @pickledrick - Peter confirmed that checking in Contour versions > 0.12.1 is more strict and Contour and does not pass the object to Envoy so we don't see the error returned from Envoy.
We have updated the ticket and told the customer if this is good enough. It looks like they were looking for a proper error message in the logs when there is a malformed secret reference. We can't close the issue yet.

Thanks for the update.
The problem with reporting an error on a malformed secret is where to do so,
Logging to contour’s stdout is the obvious place but this has several drawbacks.

those logs may not be accessible to the end user, they may not have permission to tail the logs of a container in the heptio-contour namespace.
these logs are likely to be verbose as a naïve implementation will emit a long line every time contour goes through a configuration rebuild cycle — read potentially any time something related to ingress changes in the api server.

The better place to put this information would be in the status field of a k8s object. The problem is secret has no status field that I know of. This leaves the ingress or ingressroute object itself. I think this is the best place to report a malformed secret.
Sadly status updating has been a sore point for contour for a long time. We plan to fix it, but this is blocked on work scheduled for 0.14 so the soonest we could deliver this feature is 0.15.

On 27 Jun 2019, at 03:20, shabx<EMAIL_ADDRESS>wrote:
@davecheney , I brought your question with @pickledrick - Peter confirmed that checking in Contour versions > 0.12.1 is more strict and Contour and does not pass the object to Envoy so we don't see the error returned from Envoy.
We have updated the ticket and told the customer if this is good enough. It looks like they were looking for a proper error message in the logs when there is a malformed secret reference. We can't close the issue yet.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Thanks @davecheney . I'll update the customer.

I believe this was fixed in 0.14 by #1251
  virtualhost:
    fqdn: httpbin2.davecheney.com
    tls:
      secretName: missing
status:
  currentStatus: invalid
  description: TLS Secret [missing] not found or is malformed

@davecheney @pickledrick How you have updated the cluster to get rid of the problem as mentioned in https://github.com/projectcontour/contour/issues/1169#issuecomment-526055946.
Can I have specific command/steps without impacting much clients cluster

@systemlogic this issue was resolved in 0.14. Can you please upgrade to 1.0, the current stable release and open a new issue if the problem persists. Thanks

@davecheney Can I have steps/Command to do so ?

We have an upgrade guide for recent versions of contour
https://projectcontour.io/resources/upgrading/
If you’re using an older version please consult the releases page
https://github.com/projectcontour/contour/releases

On 16 Nov 2019, at 18:00, GIT<EMAIL_ADDRESS>wrote:

@davecheney Can I have steps/Command to do so ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

I have give up.
I have updated images as mentioned in my cluster. I have also setup new cluster and installed contour using
kubectl create -f https://raw.githubusercontent.com/projectcontour/contour/release-1.0/examples/render/contour.yaml
created secret using self sign crt and pem
and then create ingressRoute resource
apiVersion: contour.heptio.com/v1beta1
kind: IngressRoute
metadata:
  creationTimestamp: "2019-11-16T12:28:04Z"
  generation: 5
  name: development
  namespace: default
  resourceVersion: "2594"
  selfLink: /apis/contour.heptio.com/v1beta1/namespaces/default/ingressroutes/development
  uid: ff81ee23-ff29-4c8d-be70-be62ad702827
spec:
  tcpproxy:
    services:
    - name: development
      port: 80
  virtualhost:
    fqdn: development.monorepo.com
    tls:
      secretName: monorepo
status:
  currentStatus: invalid
  description: TLS Secret [monorepo] not found or is malformed

and service
apiVersion: v1
kind: Service
metadata:
  creationTimestamp: 2019-11-15T15:41:40Z
  labels:
    jobId: 77de3d1d9ed62ef289e45efc6484ea35
    name: development
    serviceKind: microservice
    toolchain: cedp-jsonnet
  name: development
  namespace: default
  resourceVersion: "3901295"
  selfLink: /api/v1/namespaces/default/services/development
  uid: 46b2b412-7a62-41e2-98e0-f02a2c02488c
spec:
  clusterIP: <IP_ADDRESS>
  ports:
  - name: http
    port: 443
    protocol: TCP
    targetPort: 80
  selector:
    jobId: 77de3d1d9ed62ef289e45efc6484ea35
  sessionAffinity: None
  type: ClusterIP

NOTE : I AM ABLE TO SEE APPLICATION DEFAULT PAGE WITH HTTP, HOWEVER USING tls with secretName is always giving me said error. PLEASE HELP.
Is there a proper documentation or an issue is required to fix it.

Is the monorepos secret present in the default namespace? Does it have the correct “kubernetes.io/type”? Is it valid? Sadly the secret object does not have a status field we can report failures on so we must report that data to the contour processes standard error.

On 16 Nov 2019, at 23:58, GIT<EMAIL_ADDRESS>wrote:

I have give up.
I have updated images as mentioned in my cluster. I have also setup new cluster and installed contour using
kubectl create -f https://raw.githubusercontent.com/projectcontour/contour/release-1.0/examples/render/contour.yaml
created secret using self sign crt and pem
and then create ingressRoute resource
apiVersion: contour.heptio.com/v1beta1
kind: IngressRoute
metadata:
creationTimestamp: "2019-11-16T12:28:04Z"
generation: 5
name: development
namespace: default
resourceVersion: "2594"
selfLink: /apis/contour.heptio.com/v1beta1/namespaces/default/ingressroutes/development
uid: ff81ee23-ff29-4c8d-be70-be62ad702827
spec:
tcpproxy:
services:
- name: development
port: 80
virtualhost:
fqdn: development.monorepo.com
tls:
secretName: monorepo
status:
currentStatus: invalid
description: TLS Secret [monorepo] not found or is malformed
and service
apiVersion: v1
kind: Service
metadata:
creationTimestamp: 2019-11-15T15:41:40Z
labels:
jobId: 77de3d1d9ed62ef289e45efc6484ea35
name: development
serviceKind: microservice
toolchain: cedp-jsonnet
name: development
namespace: default
resourceVersion: "3901295"
selfLink: /api/v1/namespaces/default/services/development
uid: 46b2b412-7a62-41e2-98e0-f02a2c02488c
spec:
clusterIP: <IP_ADDRESS>
ports:

name: http
port: 443
protocol: TCP
targetPort: 80
selector:
jobId: 77de3d1d9ed62ef289e45efc6484ea35
sessionAffinity: None
type: ClusterIP
NOTE : I AM ABLE TO SEE APPLICATION DEFAULT PAGE WITH HTTP, HOWEVER USING tls with secretName is always giving me said error. PLEASE HELP.

Is there a proper documentation or an issue is required to fix it.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.


SFI - Images - aspnetdocs repo - Fix all sev 0-1: 82 images total

For repo aspnetdocs: Fix all sev 0 to sev 1 issues for images on aspnetdocs from SFI scan.
82 images total to fix.
Repo: https://github.com/dotnet/AspNetdocs

Associated WorkItem - 319947

Fixed all sev 0 (71 images) so far with: https://github.com/dotnet/AspNetDocs/pull/911
Also determined a couple of images did not actually need a fix as originally thought.  (So fixed 71 sev 0 instead of 76)
Next is all sev 1 (6 images)


Refactor whole module

TBD

          1 Warning

:warning:
Big PR, try to keep changes smaller if you can 😜

  Generated by :no_entry_sign: Danger


React console warnings

First off, Great library!
I know this doesn't relate to your library specifically but in regards to following the README documentation and some browser console warnings I have seen:

Warning: Something is calling a React component directly. Use a factory or JSX instead. See: http://fb.me/react-legacyfactory

Warning: React.renderComponent will be deprecated in a future version. Use React.render instead.

Some fixes I have done to alleviate those warnings:
1- According to http://fb.me/react-legacyfactory you should create Factory if not using JSX:
var UserViewComponent = React.createFactory(UserView);
var userView = UserViewComponent({model: user});
2- Not sure if valid but I think React.renderComponent() is deprecated for React.render() now.
React.render(userView, document.getElementById('element'));
I am still very new to React so this may be isolated to my environment (using requirejs/require-jsx-plugin) and also related to the fact that I am not using JSX to render the component but figure I would pose the question

Both fixes make sense - would love a PR to fix the README with those changes!

Iirc this has changed in React 0.12. I'd be in favour of such a change, but I think we should do a bigger version bump, since this will make it incompatible with a previous version of react (0.10? 0.11?)

@markijbema I believe the warnings @tsjoberg  refers to only happen if you copy+paste the examples from the README, this wouldn't impact the library code itself or require a new version

@clayallsopp I think @markijbema is right in that these new implementation methods were only introduced with React 0.12. So in order to follow .render() instead of .renderComponent one would need React 0.12.x to do so. I believe same goes with createFactory()
React 0.12 Changelog: http://facebook.github.io/react/blog/2014/10/28/react-v0.12.html#changelog
To Mark's point I think we would update the package.json (peerDependecies) to include React 0.12:
"peerDependencies": {     "react": ">=0.12.x <1.x.x",     "backbone": "1.x.x"   },
And depending ... also incrementing the library version because of this peer dependency change

You're both right in that these things are deprecated in React, and we should update the README accordingly, but nowhere in the actual react.backbone code do we use render or instantiate a component using the legacy method, so no reason to bump the dependencies.
put another way, react.backbone is perfectly compatible with old and future versions of React at this point, without warnings

makes sense @clayallsopp will open PR soon for readme updates


Update documentation (README, CONTRIBUTING) for release of WordPressCS 3.0.0

README: updates for WordPressCS 3.0.0
This commit updates the README guide to be in line with WordPressCS 3.0.0.
This commit:

Removes the "Last commit to stable" and "Nr of contributors" badges.
Updates the "Tested on PHP..." badges.
Updates the table of contents to match the new content of the file.
Removes the "Project history" section (has been moved to the wiki).
Makes the pre-requisites for the package more explicit and puts them in a separate section.
Updates the installation instructions and adds update instructions.

Removes the instructions related to stand-alone installs and using composer create-project.
The new installation instructions take the changes in Composer 2.2 (permission required for plugins to run) into account.
The new installation instructions include a link to the end user/ruleset maintainer upgrade guide for WPCS 3.0.0 as the initial upgrade may need extra work.

Updates references to the Composer PHPCS plugin to make sure these reference the new name and link to the correct GH repo (as the repo has moved).
Removes the reference to the VIP ruleset which was removed in WPCS 2.0.0 from the "Rulesets" section.
Adds links to the "customizable properties" section for where to find customizable properties for PHPCS native sniffs and sniffs from PHPCSExtra.
Adds the VariableAnalysis standard and the VIP Coding Standards to the list of optional additional rulesets to use.
Updates the command and output for the example run.
Removes the links to IDE related tutorials in favour of a link to the wiki (to save us having to maintain this list in multiple places).
Ensures the text consistently uses WordPressCS instead of WPCS.

Closes #481
Closes #1821
Closes #1901
CONTRIBUTING: updates for WordPressCS 3.0.0
This commit updates the CONTRIBUTING guide to be in line with WordPressCS 3.0.0.
This commit:

Updates the information about usage of upstream sniffs and reporting upstream issues.
Updates the information on creating a pull request.
Removes the information about the use of a long running release PR (as we don't do this anymore in practice).
Updates the information on running the unit tests, including the information on how to get set up with cloned dependencies.
Updates the examples test run output and removes the outdated the asciinema image.
Updates the code fragments and example output used in the tutorial part to be in line with the current code and run instructions.
Ensures the text consistently uses WordPressCS instead of WPCS.
Replaced some ablist language.

Docs: miscellaneous changes
Change WPCS to WordPressCS in miscellaneous files.

Cricky.. you both are quick! Do we want to merge this already or leave it for just before the release ? I'm fine with merging it now as it won't be long for the release anymore anyway.


Add license settings on package.json when executing vue-init

What problem does this feature solve?
We can choose license on package.json when executing vue-init.
We don't have settings when executing vue init with vuejs's official templates.
But I know it is not vuejs's issue directly, but all official templates don't have settings for license in package.json.
I want to pull-requests to meta.json/meta.js/package.json in all official templates.
What does the proposed API look like?
None.

The difference is that projects created via vue init may be private and not intended for public use, so a license isn't necessary in those cases (it's about copyrights in those cases), and it doesn't make sense to require a license for every project. If you intend to make your code public, just add the license field yourself.


Adding support for PostgreSQL v12?

Any plans supporting latest version of PostgreSQL? Currently only PostgreSQL v11 is supported. Latest v12 is supported by AWS for couple of months already/

This repo tests against the postgres:latest Docker image which is currently 12.1: https://hub.docker.com/_/postgres/
Is there something in particular that isn't working?


[nntp] periodically check all peers for new posts

This is especially helpful when the post rate is really low with frequent netsplits.

added in https://github.com/majestrate/srndv2/commit/bbc4e9ae422adbd3ccc2569c2f6d9f8eae0e1aa9


Implement_Real-Time_Email_Validation_for_Signup's

Overview:
This issue adds real-time email validation functionality to the contact form in signup.html
Users can only enter email addresses from trusted email providers (Gmail, Yahoo, Outlook, Hotmail, and iCloud). If an invalid email is entered, an error message is displayed immediately, enhancing the user experience.
Email Input Validation:

Added an event listener to the email input field to validate the email format and domain in real time.
Implemented a check for trusted email domains, showing an error message if the entered email is not from a trusted provider.

Error Message:

Introduced a user-friendly error message that appears below the email field when an untrusted email is entered.

Benefits:

Improved User Experience: Users receive immediate feedback about their email input, reducing form submission errors and
improving the overall user experience.
Enhanced Data Quality: Ensures that only trusted email addresses are collected through the contact form.

Note: i'm expecting a gssoc-ext with level3 and a hacktoberfest-accepted label!
@MitulSonagara

@smog-root
Are you working on this or i should close the issue

Dude to some exams I'm not working on this!!


Explain how to install front-end dependencies

I was forced to reinstall my Mac today and I found that yarn is never mentioned in the README. This PR adds instructions about installing yarn when setting up the application.

Thanks!


travis php8 tests example

change composer option to ignore platform reqs on php8 for testing purpose

Now, test are launched, but we have errors about namespace, look at the stack trace:

Fatal error: Uncaught Error: Class "MangoPay\Tests\Cases\Base" not found in /home/travis/build/Mangopay/mangopay2-php-sdk/tests/cases/BankAccountsTest.php on line 12
Error: Class "MangoPay\Tests\Cases\Base" not found in /home/travis/build/Mangopay/mangopay2-php-sdk/tests/cases/BankAccountsTest.php on line 12

Fix on PR #480


Readme doesn't mention new "--vbox-share" parameter

https://github.com/boot2docker/boot2docker-cli/pull/258 added support for a new "--vbox-share" parameter.
This seems to be an improvement over the current steps for custom (ie not "C:\Users" or "/Users" mounting), which currently involved manually adding the mounts on both the Virtualbox side & in the Boot2docker VM, which is what is suggested here:
https://github.com/boot2docker/boot2docker#virtualbox-guest-additions
IMO "--vbox-share" should be listed in the boot2docker-cli readme:
https://github.com/boot2docker/boot2docker-cli#usage

Closing this out to de-clutter my GitHub open issues dashboard since I believe this repo is deprecated.


feat(typescript): improve typings

What kind of change does this PR introduce? feature

This change is

Codecov Report

Merging #458 into master will decrease coverage by 0.13%.
The diff coverage is 93.4%.

@@            Coverage Diff             @@
##           master     #458      +/-   ##
==========================================
- Coverage    92.4%   92.26%   -0.14%
==========================================
  Files          16       16
  Lines         777      776       -1
  Branches      210      212       +2
==========================================
- Hits          718      716       -2
- Misses         59       60       +1

Impacted Files
Coverage Δ

src/core/components/formly.group.ts
90% <100%> (-0.91%)
:arrow_down:

src/core/components/formly.attributes.ts
93.02% <100%> (+0.16%)
:arrow_up:

src/core/utils.ts
96.19% <100%> (ø)
:arrow_up:

src/core/services/formly.form.builder.ts
96.51% <100%> (+0.04%)
:arrow_up:

src/core/services/formly.event.emitter.ts
100% <100%> (ø)
:arrow_up:

src/core/services/formly.config.ts
84.7% <100%> (ø)
:arrow_up:

src/core/services/formly.validation-messages.ts
93.33% <100%> (ø)
:arrow_up:

src/core/templates/field.ts
88.23% <50%> (ø)
:arrow_up:

src/ui-bootstrap/formly.validation-message.ts
90.47% <83.33%> (-3.97%)
:arrow_down:

src/core/templates/field.type.ts
91.66% <85.71%> (ø)
:arrow_up:

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb28d38...8c9e37e. Read the comment docs.


Fix webapi8 overview link

The table of contents had a broken link to the Web API 8 overview page. This fixes the link by moving the overview page up a folder.
It also applies the ASP.NET Core OData 8 throughout the article in accordance with this comment from Sam: https://github.com/MicrosoftDocs/OData-docs/pull/263#discussion_r988491376

Learn Build status updates of commit 41558ba:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

Odata-docs/webapi-8/overview.md
:x:Error

Details

Odata-docs/webapi-8/overview.md

Line 11, Column 16: [Error: include-not-found] Invalid include link: '../../includes/appliesto-webapi-v8.md'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Learn Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Learn Build status updates of commit 6ef0792:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

Odata-docs/webapi-8/overview.md
:x:Error

Details

Odata-docs/webapi-8/overview.md

Line 11, Column 16: [Error: include-not-found] Invalid include link: '../../includes/appliesto-webapi-v8.md'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Learn Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Learn Build status updates of commit 1ad750b:
:warning: Validation status: warnings

File
Status
Preview URL
Details

Odata-docs/webapi-8/overview/overview.md
:warning:Warning
n/a (file deleted or renamed)
Details

Odata-docs/TOC.yml
:white_check_mark:Succeeded
View

Odata-docs/webapi-8/overview.md
:white_check_mark:Succeeded
View

Odata-docs/webapi-8/overview/overview.md

[Warning: file-not-redirected - See documentation] File Odata-docs/webapi-8/overview/overview.md was deleted without redirection. To avoid broken links, add a redirection.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Learn Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel


Add amtool command for rendering templates.

Hi, I found quite difficult for users to write the Alertmanager templates.
Mainly it's quite difficult to test them.
Now user has to:

run the alertmanager with the new configuration
send the test aler probably using amtool
have some receiver configured where he can check the result

I do not think this is much user-friendly and I hope we can do better.
This PR is just draft, because the changes required for it are quite big, so I'm not polishing it and finalizing it but just to show the idea:
The command would generate specified number of synthetic alerts which could be somehow parametrized (add custom annotation, label etc). These will be used for rendering of the templates.
It's bit complicated to specify which templates should be rendered, by default it could render al of them possibly user could filter just specified type, id or name of receiver to render.
The rendered output as should be mainly human readable IMHO (but also reproducible in case someone would want to use it for testing for example.) That's why as initial implementation I did the templating as rendering the receiver config as yaml. That unfortunately required bigger refactoring of the receivers configs templating.
Example tool help
$ ./amtool config templates render --config.file examples/ha/alertmanager.yml --help
usage: amtool config templates render

Flags:
  -h, --help                     Show context-sensitive help (also try --help-long and --help-man).
      --config.file=CONFIG.FILE  Config file to be used.
      --receiver.name=RECEIVER.NAME
                                 Name of receiver to be used for templating.
      --receiver.type=RECEIVER.TYPE
                                 Type of receiver to be used for templating.
      --receiver.id=-1           Id of receiver to be used for templating.
      --additional.labels="label-name=label-value"
                                 Labels of the alert used for rendering of the templates.
      --additional.annotations="annotation-name=annotation-value"
                                 Annotations of the alert used for rendering of the templates.
      --alert.count="annotation-name=annotation-value"
                                 Number of alerts to be passed to the rendering.

Example usage output:
$ ./amtool config templates render --config.file examples/ha/alertmanager.yml
--- # receiver:  type: opsgenie index: 1

send_resolved: true
http_config: {}
api_key: <secret>
api_url: https://api.opsgenie.com/
message: '[FIRING:1]  (bar)'
description: |+
  bar
  Alerts Firing:
  Labels:
   - foo = bar
  Annotations:
   - foo = bar
  Source: http://foo.bar

I'll be happy to finish this but I'm not 100% sure about the ideal form of output and input.
Would you be willing to accept such thing and if so, how should it look like ideally?
Thanks for any ideas!

@simonpasquier if you find a while would you give it a look? :pray:

Attempting to implement a more generic variant here: https://github.com/prometheus/alertmanager/pull/2538

#2538 has been merged. Thanks!


Make goal fields nullable

Make goal fields nullable

Codecov Report

Merging #70 (5dada11) into main (16207e8) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #70   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            7         7
  Lines          509       512    +3
  Branches        60        61    +1
=========================================
+ Hits           509       512    +3

Files
Coverage Δ

src/aiowithings/models.py
100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Add a Loading button

Issue:

Great thank you!
@all-contributors please add @akshatgarg12 for idea


expose userdata instead of closure

I don't think a closure is necessary, and this allows doing more advanced things in the future (implement the __tostring method again).

Ha, I was thinking about this before and came to the conclusion it would need more changes. Looks like I was wrong.
Could you implement __tostring while you are at it, so the user gets something more meaningful than userdata: 0x123? Maybe something like jsregexp: /<regex>/<flags>?

And could you remove the two unneeded commits?

Alright I will take a look tonight.

Added the changes + rebase. I believe a copy of the user defined regex is needed as libregex doesn't offer a way to get it?

Added the changes + rebase. I believe a copy of the user defined regex is needed as libregex doesn't offer a way to get it?

Looks like it, but that's fine.
BTW, if you want to check if the windows code runner is working again, you could open a new Draft and force-push it occasionally.

Yea, I will probably make some test branches + pull requests on my own repo to get it working. I know it works because Hisham got it working for teal.

I see. On a side note, do you use this module somewhere and need timely releases on luarocks?

No, its not ready for my use case. I'm looking to get it to the point of something that mimics python's re module. I think that may be done in a separate lua level module.  Also when I do use it, I vendor the code in the repo.
The trickiest things for that will be the replace functions. I'm going to start looking at the quick's implementation to see how easy it is.

My use case is for an embedded lua environment, which is why I want something embeddable like this from quickjs over the massive lrexlib where I don't want to bundle one of the underlying libraries.

Very well. Maybe it would be a good idea to lay out some sort of plan first and see what is actually needed. There are also points to be made about mimicking the lua string library or the js regexp library.

I think this project should stick to mimicking the JS RegExp library. I will probably make a separate shim to mimic python re module from that.

Ok I got the readme cleaned up to remove autosave changes

Looks good. I had a brief look at the javascript library (that I haven't used before) and it seems like the RegExp object only has two methods, test() and exec(), and the remaining functionality (mostly methods of the string type) can be built from these.


Downloading contents from torrent specified in DataSource.

@mwatts15 The added files are:

credentials.json (Google Auth)
token.pickle (Google Auth)
torrent_cli.py (BitTorrent Client script)
torrent_client/ (Folder containing login for torrent_cli.py)
t.py (DataSource with torrent_file_name specified)
s.py (Download the torrent file in DataSource and then its Contents to the Base_Directory,"./")

Coverage decreased (-0.2%) to 77.208% when pulling 55311af0b968ab4d1987038f0710b8c88aa4337e on jaideep-seth:dev into e853c95584c866aa7815ccd7281dcd9cdc56bb20 on openworm:dev.

Please remove your commits from work on #254 . Have a look at Git's interactive rebase for guidance on how to do that.

We shouldn't be directly including the torrent client code in our source tree -- especially not without attribution. It looks like the upstream doesn't package properly. I would suggest asking the author to add a setup.py for his client, or add one yourself and make a PR on their repo. Alternatively, look into a different torrent client.

@mwatts15 , what should I be looking for in a different torrent client?


pythonPackages.missingno: init at 0.4.2

Motivation for this change
missingno is an easy to use Python package for data visualization, especially regarding messy data with missing vlaues.
Things done

[X] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[X] Fits CONTRIBUTING.md.

Notify maintainers
cc @

Too bad we didn't merge it back then, there's merge conflicts now. @melsigl do you still want to get this in?

@doronbehar I do not need that particular package anymore. Thus, we can close this pull request


Release 2.1.8

Codecov Report
Base: 52.51% // Head: 53.21% // Increases project coverage by +0.70% :tada:

Coverage data is based on head (f6dace8) compared to base (16ab5b5).
Patch coverage: 60.67% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #323      +/-   ##
==========================================
+ Coverage   52.51%   53.21%   +0.70%
==========================================
  Files         202      204       +2
  Lines       11286    11562     +276
  Branches     1458     1492      +34
==========================================
+ Hits         5927     6153     +226
- Misses       5359     5409      +50

Impacted Files
Coverage Δ

trade_remedies_api/cases/services/v2/views.py
47.22% <ø> (+0.97%)
:arrow_up:

trade_remedies_api/config/encoders.py
87.50% <0.00%> (ø)

trade_remedies_api/config/serializer_fields.py
0.00% <0.00%> (ø)

..._api/core/services/auth/tests/tests_serializers.py
0.00% <0.00%> (ø)

trade_remedies_api/core/validation_errors.py
100.00% <ø> (ø)

trade_remedies_api/documents/models.py
29.08% <0.00%> (-0.10%)
:arrow_down:

trade_remedies_api/documents/services/v2/views.py
28.57% <12.50%> (-6.57%)
:arrow_down:

trade_remedies_api/invitations/models.py
58.94% <27.27%> (-0.76%)
:arrow_down:

...de_remedies_api/organisations/services/v2/views.py
51.16% <30.76%> (-9.45%)
:arrow_down:

...rade_remedies_api/cases/services/v2/serializers.py
73.26% <42.85%> (-12.07%)
:arrow_down:

... and 23 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Create Households Register Table

This is a subset of Issue #22. This involves creating only the household register table in households register view.

[ ] Create a household register view under the containers.

[ ] Create a navigation item on the header that directs to that view.

[ ] Use the household reducer and client's endpoint to fetch the household list.

[ ] Since the client's interface is used in household reducer, keep blanks to non-matching columns and values for matching columns.

@redoy11 There are a few table components in the onaio/jstools repo, maybe you could use those where they seem useful


Add missing changesets

Adds missing changesets to:
https://github.com/Shopify/hydrogen/pull/1202
https://github.com/Shopify/hydrogen/pull/1201

YOLO


Demo flow / content brainstorming

Rough thoughts. The screen output has to be brief. Large text size, few words. Show rapid iteration and meaningful improvement at each step.

Embeddable AI for SaaS and the Enterprise (react components
Smarter AI at Enterprise  Scale

Smarter

more agents using standard LLMs have better outcomes than one agent running the "best" LLM
easy to test, learn, iterate and deploy: agile is smart!

Enterprise

sensible architecture
K8S deployment and management
secure: built-in auth;

must add docs for

https
secrets
rbac

existing dev tools
modular and api-based

no lock-in for the inevitable shake up and shake out of llm, vector db, memory store
tendency for enterprises to switch cloud providers when they get a better $ deal (lack of brand loyalty)

open source -- no friction
running components and templates

SaaS ok? Need to embed + massive scale for consumer and B2B software
Potential use cases that lend themselves to multiple agents, short prompts, short output  (for grockability and readability)

backlogs: bureaucracies: applications, complaints, feedback

stakeholders (citizens, employees, healthcare clients) are waiting for a decision, often a high-stakes decision
scan through all feedback / forms
summarize the quantity and quality of work
identity how much work is easy / corner cases that need special attention
come up with a plan and timeline to get through all the feedback

backlogs: product teams

stakeholders are customers who can take their business elsewhere -- and influence others to do the same
summarize feature requests, bugs, sentiment
prioritize what to work on (wsjf, user sentiment, opportunity)
plan roadmap

Rough idea of demo (general)

hello world agent
copy hw agent, change system prompt to read/write Spanish
copy Spanish prompt to r/w another language
bring in retriever agents: files, Web pages, api

User prompts (below)
Refine & Scale

cheaper or optimized LLMs (show usage $)
prompt engineering
security -- not sure how to show rbac
deploy more agents to meet demand

Impact

fulfill mission / build business / get promoted
save time and money / faster gtm
build confidence to take on more problems

Need?

retriever (agents?): pdf, web, API, SQL, file store
validator agent? See Swifties example

Assumption: the content is known to be in certain locations (you don't have to find it)
User prompts

what are the top 3 complaints / top 3 suggestions; segment by user persona if possible. Be concise.
do people who do not speak English have the same complaints / suggestions as those who do speak English?
have other organizations solved these problems or implemented suggestions? How?
prioritize and plan a path forward

Rough thoughts. The screen output has to be brief. Large text size, few words. Show rapid iteration and meaningful improvement at each step.

Embeddable AI for SaaS and the Enterprise (react components
Smarter AI at Enterprise  Scale

Smarter

more agents using standard LLMs have better outcomes than one agent running the "best" LLM
easy to test, learn, iterate and deploy: agile is smart!

Enterprise

sensible architecture
K8S deployment and management
secure: built-in auth;

must add docs for

https
secrets
rbac

existing dev tools
modular and api-based

no lock-in for the inevitable shake up and shake out of llm, vector db, memory store
tendency for enterprises to switch cloud providers when they get a better $ deal (lack of brand loyalty)

open source -- no friction
running components and templates

SaaS ok? Need to embed + massive scale for consumer and B2B software
Potential use cases that lend themselves to multiple agents, short prompts, short output  (for grockability and readability)

backlogs: bureaucracies: applications, complaints, feedback

stakeholders (citizens, employees, healthcare clients) are waiting for a decision, often a high-stakes decision
scan through all feedback / forms
summarize the quantity and quality of work
identity how much work is easy / corner cases that need special attention
come up with a plan and timeline to get through all the feedback

backlogs: product teams

stakeholders are customers who can take their business elsewhere -- and influence others to do the same
summarize feature requests, bugs, sentiment
prioritize what to work on (wsjf, user sentiment, opportunity)
plan roadmap

Rough idea of demo (general)

hello world agent
copy hw agent, change system prompt to read/write Spanish
copy Spanish prompt to r/w another language
bring in retriever agents: files, Web pages, api

User prompts (below)
Refine & Scale

cheaper or optimized LLMs (show usage $)
prompt engineering
security -- not sure how to show rbac
deploy more agents to meet demand

Impact

fulfill mission / build business / get promoted
save time and money / faster gtm
build confidence to take on more problems

Need?

retriever (agents?): pdf, web, API, SQL, file store
validator agent? See Swifties example

Assumption: the content is known to be in certain locations (you don't have to find it)
User prompts

what are the top 3 complaints / top 3 suggestions; segment by user persona if possible. Be concise.
do people who do not speak English have the same complaints / suggestions as those who do speak English?
have other organizations solved these problems or implemented suggestions? How?
prioritize and plan a path forward

Pluggability allows good-better-best tradeoffs for individual components to full applications. The framework does not change. The APIs do not change. But you can significantly improve cost/performance by swapping out components with barely more than a parameter in a text file.

Evolution: opening ChatGPT or Claude applications --> desire to automate repetitive work with AI applications --> desire to optimize complex work with agents --> desire to optimize AI applications for cost and performance

Incorporate a Langchain agent into the agent machine. Run it as-is, then show how to quickly create an eidolon native agent that does the same thing, then show why you'd want to do so: easily swap an llm, change temperature or other attributes. Rapid development, deploy to test env, deploy to prod.

Incorporate a Langchain agent into the agent machine. Run it as-is, then show how to quickly create an eidolon native agent that does the same thing, then show why you'd want to do so: easily swap an llm, change temperature or other attributes. Rapid development, deploy to test env, deploy to prod.

Multi LLM
Use case: important decision. Want to get perspective from multiple LLMs. Primary copilot asks multiple LLM models to respond to a prompt. Output 1-3 sentence of each response, then offer it's own recommendation.


[case]Load data with load_parallelism=any > 1 and stream load with compress type

Proposed changes
Issue Number: close #xxx

Further comments
Load data with load_parallelism=any > 1 and stream load with compress type

run buildall

run buildall

run buildall


Make sure bind_trials work as expected for all mechanisms

Sort out which updates (v- and w-values) to avoid and in which mechanisms.

https://github.com/learningsimulator/learningsimulator/issues/164


[Bug]: The website has a very plane background which can be made interesting. [GSSoC'23]

Give a brief about the bug ✍
The website has a very plane background which can be made interesting. A better background. with some gradient in it will make it more fun and interesting.
Here is one sample :

We can add such gradients to give a more fun look to the website.
What is the expected behavior? 🤔
A better background. with some gradient in it will make it more fun and interesting.
Provide step by step information reproduce the bug 📄
I will design a new backgroung through figma and add it to the website
Select program in which you are contributing
GSSoC23
Code of Conduct

[X] I follow CONTRIBUTING GUIDELINE of this project.

Hey @1Shubham7 !
Thank you for raising an issue 💗
You can self assign the issue by commenting /assign in comment 😀
Make sure you follow CODE OF CONDUCT and CONTRIBUTING GUIDELINES 🚀
Don’t Forget to ⭐ our GameZone🎮
Make sure you join our Discord🕹

@kunjgit If you are not accepting the PR, shall I close the issue. Here are some more gradients :

I even created Dark Black gradients that match the current background:

Please try them, trust me they will look good.
Or else do inform me if I should close this issue.

Hello @1Shubham7, Time's Uppp!⏰
Sorry for closing your issue!
But it's more than a week since we haven't received anything from your side 😢 .
Come up with new ideas, create a new issue and make sure you finish it within a week! 🔥
All the best! 🚀
Happy Hacking! 💗

Hey @1Shubham7 ! Thank you so much for your raising the issue💗
It’s all yours, you can come anytime again and make some contributions! 🚀
Alone, we can do little, but together we can do so much! 😇

seriously @kunjgit , you didn't reply me for a week about which gradient should I proceed with. But no worries, thank you for having me.


Token is not recognized as an input, causes bad credentials failure

As defined by here, token is an acceptable input. Using the latest release, 0.1.5, I get the following error:
 Warning: Unexpected input(s) 'token', valid inputs are ['body', 'body_path', 'name', 'draft', 'prerelease', 'files']
Run<EMAIL_ADDRESS>⚠ Unexpected error fetching GitHub release for tag refs/tags/0.2.0: HttpError: Bad credentials
Error: Bad credentials

Link to run

I assume an update to v0.1.15 should solve the problem; your error message names the old version v0.1.5.  Is this intentional?

No, might've been a typo.


Openai

Change to use OpenAI API through databricks proxy endpoint.

This is not ready to be merged, but I need help with the error in #1c97cd4.

Should be ok now. Needed to use gpt-4 (due to context length) in some cases. Used OpenAI directly, does not seem to be supported with the proxy endpoint. Which depends on a secret to be shared with all.


Update tsconfig.json paths property to object

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

A configuration file change.
This change is merely change in tsconfig from an empty array to an empty object to conform with proper tsconfig compiler options. Just to remove type error warnings in coding programs.

What is the current behavior? (You can also link to an open issue here)

Currently the code is paths: []

What is the new behavior (if this is a feature change)?

Proposing a change to paths: {}

Other information:

In the tsconfig.json the property compilerOptions.paths should be an object and not an array.
See https://www.typescriptlang.org/docs/handbook/compiler-options.html

👍


There should be a link to the IDataModelConcept page

https://docs.microsoft.com/en-us/windows-hardware/drivers/ddi/content/dbgmodel/nn-dbgmodel-idatamodelconcept

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0adff9eb-1553-a20a-6313-e8ed6482dc84
Version Independent ID: e08853ba-e811-a758-d546-6b653f9a83c2
Content: IDataModelManager::CreateDataModelObject (dbgmodel.h) - Windows drivers
Content Source: wdk-ddi-src/content/dbgmodel/nf-dbgmodel-idatamodelmanager-createdatamodelobject.md
Product: windows-hardware
Technology: windows-devices
GitHub Login: @DOMARS
Microsoft Alias: domars

@jazzdelightsme - I have added the link here and also to the IDataModelManager2 version. I will close this issue when the changes are live. You are always welcome to send a PR for changes like this.

@jazzdelightsme - The topic updates are live, so closing this issue. Thanks for the issue and your interest in the DbgModel docs.


Update Labels

Label configuration update from Reparo

Coverage remained the same at 22.701% when pulling 9fe3ea632eb9f92060ad6d93026c27381aac437e on labels-update into d70546d1d8925a6a7b87a9a9b35b1ae904fd7ffc on master.


⚠ Bofrost.lu has degraded performance

In 0ec005c, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1443 ms

Resolved: Bofrost.lu performance has improved in b7d4910 after 6 minutes.


Are you charged for events that are unmatched by a subject filter?

Let me explain my scenario.

I have a storage account with 'N' number of storage containers (container 1 ... N).
I have 'N' number of event subscriptions added to this storage account.
Each event subscription is listening to the 'Microsoft.Storage.BlobCreated' event.
Each event subscription has a subject filter that matches only one of the containers ( filter == /path/conatinerN)
Each event subscription forwards the event (when matched) to a unique endpoint.

Question, when a single blob is created in a container, and the 'Microsoft.Storage.BlobCreated' event fires, will I be only charged for 1 event? or N events? Ideally It will be one, or else my cost will increase N^2 as I add more subscriptions to the storage account.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1b572f63-312f-4567-5f06-d09bcccf303e
Version Independent ID: df817c5f-24e4-bdc7-511c-141d07a53d15
Content: Event filtering for Azure Event Grid
Content Source: articles/event-grid/event-filtering.md
Service: event-grid
GitHub Login: @spelluru
Microsoft Alias: spelluru

@spatney Thanks for the question! We will review and get back to you!

@spatney As mentioned in the pricing page, event grid charges per million operations which include ingress of events to Domains or Topics, advanced matches, delivery attempts, and management calls.
In your case, you could just use subject filtering which will NOT cost towards the operation count but if you were to use advanced filters, then each of your events that go through the filter would count up towards the total number of operations.

@spatney Just following up here... Hope my previous comment clears things up.

Thanks Pramod for your prompt response. That does clear it up. I am using subject filters, and it is good to know that it will not count towards total operations.


Update commands.rb

Migration to new VPS requires updated DNS settings, !dns now shows new DNS.

Pulled and restarted. I noticed you mentioned a botch nwc24msg.cfg; let me know what you find of that. The Kaitais in RiiConnect24/Kaitai-Files may be of use.

Sure thing.

Permalink: https://github.com/RiiConnect24/Kaitai-Files/blob/master/Kaitais/nwc24msg.ksy


About the net

Sir ,I want to know the out part of last layer 13x13x255 /26x26x255 /52x52x255(80 classes)..255 may mean Xx3|Yx3|Wx3|Hx3|confidencex3|classesx3 or (X|Y|W|H|confidence|classes)x3,which order is right?

Does 3 means mask number on detection layer?
each object has a information related to x, y, w, h, classes. Therefore, I think, if I correctly understand your question, the later is right.

Thank you very much ,sir~


HAProxy 1.6.10

Can one of the admins verify this patch?

It will fix #359

test this please

It deserves a release, no? =D


Change the arguments to get filenames for the logs

change the arguments of sender and receiver to take log filenames as input

Complete now.


refactor: cleanup CommonJsScanner

Fixes #5197
This PR incorporates:

Cleanup of the CommonJsScanner;
Ensuring that RuntimeGlobals::Module is appended in CommonJsSelfReferenceDependency, aligned with the existing Webpack behavior: https://github.com/webpack/webpack/blob/main/lib/dependencies/CommonJsSelfReferenceDependency.js#L129-L131
move get_referenced_exports and get_condition from ModuleDependency to Dependency
remove the ModuleDpenendecy implement for CommonJsSelfReferenceDependency
Add NullDependency trait

close for outdated


Revert "HBASE-25870 while creating manifest, search only for ancestors insteadd of all of…"

Headsup @rda3mon , our policy is that commit summary start with the JIRA ID and the text matches the jira summary. Reverting this so it can be re-applied according to policy.
Reverts apache/hbase#3246

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m  0s
Docker mode activated.

-1 :x:
patch
0m  2s
https://github.com/apache/hbase/pull/3269 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help.

Subsystem
Report/Notes

GITHUB PR
https://github.com/apache/hbase/pull/3269

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3269/1/console

versions
git=2.17.1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m  0s
Docker mode activated.

-1 :x:
patch
0m  3s
https://github.com/apache/hbase/pull/3269 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help.

Subsystem
Report/Notes

GITHUB PR
https://github.com/apache/hbase/pull/3269

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3269/1/console

versions
git=2.17.1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m  0s
Docker mode activated.

-1 :x:
patch
0m  3s
https://github.com/apache/hbase/pull/3269 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help.

Subsystem
Report/Notes

GITHUB PR
https://github.com/apache/hbase/pull/3269

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3269/1/console

versions
git=2.17.1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


[BUG] Incorrect conflicting classnames

The "classnames are conflicting" warning/error appears when these two classes are on an item.
bg-[url('/image.jpg')]
bg-center
However, they are not actually conflicting and this should be valid.

Try npm i<EMAIL_ADDRESS>

fixed in the latest 3.12.1


Gradle Version, TargetSdk, CompileSdk Upgraded and VersionCatalogs Implemented

Gradle version upgraded to 7.4.2 and Android Gradle Plugin upgraded to 7.2.2
TargetSdk and CompileSdk upgraded to 32
buildSrc added to manage Plugins and common Android Configs
VersionCatalogs implemented with TOML file
TOML file updated

I could not able to find rebase settings. Can you tell me how to do it?

I changed the base branch of your PR to develop, try running git merge develop from your clone and fix any conflict you will probably get. This or alternatively you can start again from develop with a new PR and copy your changes there.

@svlilyas Looks like Android Studio Dolphin has better support for TOML version catalogs 👍


Fixed bug in package_tool

package_tool takes a feature_number and tries to convert it to 1 byte with feature_number.to_bytes(1, "little") which will break for any feature numbers greater than 255 with the error OverflowError: int too big to convert. The technical specification says the feature number is 32 bits long.
To make it conform to the technical specifications but with minimal refactoring (the package number is expected to be 1 byte in several places), and since the only feature numbers that will be used are 1 and 2, the feature number is truncated to 8 bits during packaging

@dtwalter approved


Fix how mkerr handles SSLv3 Alerts

The SSLV3 alert text is not a directly derived from the name of the alert. Instead, the "sslv3" text is replaced with "ssl/tls".
When doing a make update with modified/added errors in the ssl directory, that error text reverts to the default, and looks like an unintentional change which needs to be undone before merging.

Checklist

buildbot build failure seems unrelated.

I wonder why these error reasons aren't handled the same way as the others which are placed in crypto/err/openssl.txt. Perhaps @levitte might have a different way how to fix this.

I wonder why these error reasons aren't handled the same way as the others which are placed in crypto/err/openssl.txt. Perhaps @levitte might have a different way how to fix this.

It's an annoyance that I'd like to get fixed, and I don't care who does it! :)

Alternative PR in #19950

Closing as the alternative PR was merged.


[$250] Flashing skeleton appears when accessing NewDot chat

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @CortneyOfstad
Slack conversation: https://expensify.slack.com/archives/C05LX9D6E07/p1718643033739439
Action Performed:

Open app
Open any chat

Expected Result:
App should load and able to open any chat
Actual Result:
When accessing NewDot, the page flashes the skeleton consistently.
Workaround:
unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
logs-2024-06-17 18_07_45.483.txt

NOTE: trace log is exceeding 25mb and unable to attach

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~015b49dedbd47b081b
Upwork Job ID:<PHONE_NUMBER>462907354
Last Price Increase: 2024-07-01

Issue OwnerCurrent Issue Owner: @mananjadhav

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

App works correctly for me and loads all chats. Maybe there's some old login info remaining?
In any case, I think we can close this for now

@Gonals I am still experiencing this issue both under my login (cortney@expensify.com), my test account<EMAIL_ADDRESS>and my managed customer is still experiencing this (everyone under +@zoominfo.com).

Here is a fresh screenshot from my manager test account:

Going to drop off myself for Cortney as she has the context, and we don't need two BZ on this one. It's not Done, so I've removed that status as well. @muttmuure can probably attest to which priority this falls into within the project.

Marking it as external, as they seem like frontend errors

Thanks @Gonals!

Still experiencing the issue via<EMAIL_ADDRESS>Bumped in Slack here to hopefully get some eyes on this sooner rather than later

Still being worked on here

Still being worked on here

Same

Not overdue — still being worked on!

This will be fixed for Cortney's test account (and every other Xero user) here: https://github.com/Expensify/App/issues/43015


Fix IE8 translated content not being removed.

In IE8 the old translated content is not removed by $animate.leave.  The result is that the element ends up containing both the original content and the translated content.
Adding the $compile ensures the content is removed.

Removing from milestone since we cannot reproduce.


[Feature] support notation login

What?
Add support for logging in/out. Related Issue: https://github.com/notaryproject/notation/issues/119
Work need to be done:

[x] Add new CMDs that supports login and logout.
[x] For login CMD, validate the input credentials through ORAS, and store it in the credentials store.
[x] For logout CMD, remove the credential from the credentials store
[x] For other CMDs that need authentication, we should support both the original -u -p options and using the credentials saved in the credentials store if there is no user input.
[x] Create a submodule that interacts with the credentials store and validate credentials via ORAS.
[x] Integrate with the new Directory pkg to manipulate the config file once it's ready to be use
[x] Add parser that parse the config.json into the required creds config(support configs for both docker and notation)

Test?

[x] Manual test (done):

test plan:

run login cmd
run logout cmd
run other CMDs, e.g. list/push/pull
3.1 user types username/password explicitly. [expect: user-typed credential is used]
3.2 user doesn't type username/password. [expect: saved credential is used]
~/.notaion/config.json is set up
4.1 both credHelpers and credsStore are configured. [expect: only credHeplers is honored]
4.2 only credsStore is configured. [expect: credsStore is honored]
~/.docker/config.json is set up while ~/.notaion/config.json not
5.1 both credHelpers and credsStore are configured. [expect: only credHeplers is honored]
5.2 only credsStore is configured. [expect: credsStore is honored]

[ ] Will create another PR to complete the unit tests

Signed-off-by: Binbin Li<EMAIL_ADDRESS>

@shizhMSFT @binbin-li maybe we could split long PR like this one into multiple smaller PRs in the future to enhance the readability? (there are 20 files been added/updated in this PR) Please suggest if you think otherwise.

@shizhMSFT @binbin-li maybe we could split long PR like this one into multiple smaller PRs in the future to enhance the readability? (there are 20 files been added/updated in this PR) Please suggest if you think otherwise.

You're right. I didn't expect this PR would be so large at the beginning. I would split long PRs next time.

I updated PR https://github.com/notaryproject/notation/issues/119 to reflect the latest.
We should probably complete, then merge #119 before merging this one.

I updated PR #119 to reflect the latest. We should probably complete, then merge #119 before merging this one.

When referring to PR #119 , do you mean https://github.com/notaryproject/notation/pull/223 ?

I updated PR #119 to reflect the latest. We should probably complete, then merge #119 before merging this one.

When referring to PR #119 , do you mean #223 ? @SteveLasker

#119 is an issue. It must be a typo and refers to #223.
@binbin-li Could you update this PR to reflect #223?

Working on it.

Updated as #223 defined.

Moved --plain-http to the global options.
Add --password-stdin option to login cmd.
Add examples.


Enhance welcome header

Closes #74

Codecov Report

Merging #191 into master will increase coverage by 0.02%.
The diff coverage is 80%.

@@            Coverage Diff             @@
##           master     #191      +/-   ##
==========================================
+ Coverage   92.25%   92.27%   +0.02%
==========================================
  Files          85       86       +1
  Lines        1071     1075       +4
  Branches      179      179
==========================================
+ Hits          988      992       +4
  Misses         68       68
  Partials       15       15

Impacted Files
Coverage Δ

packages/warriorjs-cli/src/Game.js
50.68% <0%> (ø)
:arrow_up:

...ackages/warriorjs-cli/src/ui/printWelcomeHeader.js
100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a6acb3...751deb8. Read the comment docs.


100% likely that two function parameters have been merged by accident

https://github.com/allenai/RL4LMs/blob/main/rl4lms/envs/text_generation/policy/seq2seq_policy.py#L263

Oh right. This seems like a merging issue. The good thing is that argument is unused/overridden at the moment. That is why it still works without any run-time errors.


Use source_gen

In the Dart package ecosystem, most of the packages are using source_gen which formats the output code. This process has 2 main benefits:

The generator can just produce valid code and not care about indentation, carriage returns, etc. since the output is formatted at the end anyway
The developer can run dart format . and there is no change in the generated code since it has already been formatted that way.

I have started using slang and everytime I run dart run slang, I have to run dart format . and commit the changes otherwise my CI build is broken.
There is no way to exclude file in Dart formatter (yet) https://github.com/dart-lang/dart_style/issues/864 so having generated code properly formatted like code gen packages do would be great.
To repro:

Clone the slang repo
Run cd slang/example
Run flutter pub get
Run dart format .
Run git diff 👉 There are some changes that shouldn't be here.

A temporary workaround is to remove the generated file inside the CI before running dart format .. This essentially ignores the file as it doesn't exist anymore.
Integrating source_gen requires a lot of effort so it is unlikely in the near future.

Added format config in v4.1.0. This only solves #184 but I think there no additional benefit of using source_gen except the formatting.
Internally, slang_build_runner is calling dart_style while slang is calling dart format directly.


Stop using the same icon for two different buttons on the main screen.

This is a proposal for a quick resolution to #3063, discussed with and suggested by @gnprice.
Before:

After:

Ah, I was thinking actually of "globe" for the upper left -- the one that means "everything" or "all messages". I think the "house" icon is pretty OK for the "home" view aka unreads.

Inbox

That'd be this:

I'd be OK with using that too for "All messages". I remember discussing that now that you mention it, but when @jackrzhang and I looked back through #3063 we didn't see it.
Thinking about "globe" vs. "inbox" for the icon for "All messages", I think my preference is "globe". In particular both "All messages" and the home screen i.e. "Unreads" have sort of the nature of an inbox, and "Unreads" feels like it's more strongly an inbox than "All messages" is. (The "All messages" view does start at your first unread, but it will also include a lot of stuff you've already seen.) But it's not a strong preference. @borisyankov what are your thoughts between those two?
Whatever change we make, we'll also see what feedback we get after sending out the beta; it's easy to change again at that point if we're persuaded of a different choice.

Ah, gotcha @gnprice. (updating)

The argument against globe is that users need to associate it in the other direction that we think of it, not 'what icon should we set to that concept' but 'what does this icon mean' which almost never works for metaphors and not direct depictions of things.
I think that globe means 'world', means 'localization', in fact, we already use it Settings -> Language.
Replacing the bottom icon with 'Inbox' achieves is enough to achieve the goal of having different icons for top and bottom.

I think that globe means 'world', means 'localization'

Hmm interesting.
I don't think this is likely to be a common association -- I don't think I often see it in applications, and also "localization" is not a concept that people not involved in writing software are likely to think about. :-)
It is a pretty reasonable answer for the inverse problem that you mention ("what icon can we use for this 'what language' setting?"), where it supplements a text label.
In any case "house" (-> "home") is completely perverse for the "all messages" screen -- a screen that we don't expect most users to often, or ever, use. So even if we replaced it with an icon that was utterly mystifying for most users, that would be an improvement because at least it wouldn't actively mislead them. But I think "globe" -> "the whole world" -> "everything" is likely to do better than that.

localization => I meant change language.
This is the exact icon used on iOS's Keyboard to switch languages.

Based on the conversation above, I've updated this PR, using the globe icon for "All messages" and the inbox icon for "Unread". Here's how it looks:

Thoughts?

I think the nav layout needs a rework since the presence of nav links both up top and below with seemingly no thought as to which go where is confusing at best. The fact that swiping right from the  “home” screen removes the top menu altogether suggests it is a sub menu to the home section. If that is our thinking then here’s the changes I would like to see:

Add a red circle on top of the home icon ( bottom left ) denoting the number of unread messages. This would have two positive effects;

make the eye travel there first
signal it’s the focus of the application
provide instant information on unreads

Change the home icon on the top left to a “list” icon. I think this more accurately denotes the chronological and flat nature of all messages.

Here are some longer term changes I’d like to see to nav ( a little off topic from this discussion but worth mentioning anyway ):

Make the styling of the top nav in the home section more clearly a secondary menu.

Make the secondary menu up top in the home section a tabbed view instead launching new sections altogether. This disrupts the mental model of what’s going on because they feel like modals rather than content sections and we lose the navibility from them.

Add a default icon to the tabbed secondary menu up top for unread messages which should be the view you initially land on.

@armaanahluwalia I agree that higher-level changes to how navigation works would be beneficial.
At the moment, it's pretty confusing just to see the same icon for two different buttons on the same screen, and I think the commits in this PR are specifically a simple and incremental improvement for that specific aspect of the layout.

I agree that changes to make them not the same icon are probably good. What did you think about the rest of the stuff I said?
Also: I think instead of inbox icon + globe icon we should use home envelope icon + list icon.
Here’s my defence of my icon choices:
The envelope is the same metaphor for messages only it’s more universal and obvious that it’s messages.
The list more accurately depicts all messages because it’s obvious it’s a collection of things ( more obviously a list of messages since it’s supposed to be a secondary menu within messages )

Thanks again @jackrzhang ! Merged, with a couple of tweaks -- take a look.

??????????????

How did we agree to replace the 'All messages' icon with the 'Change language' keyboard icon from iOS?

The purpose of the PR was as the name suggests "Stop using the same icon for two different buttons on the main screen. "
That was achieved with the first two commits.
The second change was utterly ridiculous for two reasons:

it changes the icon from what is in the web app
it is a very well known system icon on iOS

How did we agree to replace the 'All messages' icon with the 'Change language' keyboard icon from iOS?

I think that won't be a salient association for most users.
We'll see what feedback we get! Certainly easy to change to another icon later. But this is a big improvement over the highly misleading "home" icon.

But this is a big improvement over the highly misleading "home" icon.

You mean the icon we use on the web?

I think that won't be a salient association for most users.

I can't imagine how that would be. It is on every iOS keyboard:
https://photos5.appleinsider.com/gallery/22924-28346-leftiekeys-l.jpg

I thought my pitch for a notification count and icon choices was supported by pretty good reasoning. 🤷♂

I don't love the icon on the web either. But on the web, the icon is accompanied by a text label explaining what it actually means:

That makes it a lot lower-stakes if the icon is misleading. We don't have that luxury on mobile.

It is on every iOS keyboard

Huh, I'd have expected it would only be present when you actually have multiple languages / input methods configured. Which I don't think most users do.
Is it really there out of the box, with just one keyboard configured? That would surprise me.

But this is a big improvement over the highly misleading "home" icon.

You mean the icon we use on the web?

FWIW, we're probably going to make that icon go with "All unreads" on the web within a month or so.

@armaanahluwalia I think broader changes to the nav are certainly in order!
But they will take some work. That means they should not block fixing this longstanding complaint which takes just a few lines to fix. :smile:

@timabbott I am talking about the 'Change language' icon that is now used for 'All messages'.
Anyone who knows another language would use a secondary keyboard.

Globe appears on all iPhones I believe out of the box.

Here's a screenshot of an iOS keyboard without the globe:

In fact it comes in a demonstration of typing multiple languages at once! Since iOS 10, even as a multilingual user it's been unnecessary to configure additional keyboards unless the different languages you want to type use different scripts.
https://www.idownloadblog.com/2017/01/16/how-to-multilingual-typing-iphone/

Can we create a ticket for rethinking the nav a little bit? I agree this is a positive change but there's a lot to do to make the whole thing less confusing. I made quite a few suggestions I think are valuable and would appreciate any sort of feedback on those :)

Yeah, I agree not everyone needs a second keyboard.
360 million people speak English as their first language. That is 4.78% of all people on Earth.

360 million people speak English as their first language

Yes, and the screenshot above is of someone typing both Spanish and English, with a single keyboard.
I've made a decision based on the information we have so far, and I think this discussion is no longer adding new information, so let's wrap it here. We'll have more information after users see 23.2.111 with this change and give us feedback (or don't); we can pick the discussion up again when we know more.

Can we create a ticket for rethinking the nav a little bit? I agree this is a positive change but there's a lot to do to make the whole thing less confusing. I made quite a few suggestions I think are valuable and would appreciate any sort of feedback on those :)

Sure, more discussion sounds good. How about starting a chat thread?
I think that'll be a somewhat better medium for that discussion, as there are several different ideas and also there's discussion to be had before a direction is fully specced out.


[fastx client api] Expand the Rust Client API

The current client API supports transfer, receive and get balance
It should be expended to support all the operations supported by OrderKind.
Also get_spendable_amount should be replaced by get_possesed_objects as we no longer have the concept of balance in the system.
The expended Client should contains the following functions :
fn transfer_to_fastpay(
    &mut self,
    object_id: ObjectID,
    recipient: FastPayAddress,
    user_data: UserData
) -> AsyncResult<CertifiedOrder, Error>

fn transfer_to_primary(
    &mut self,
    object_id: ObjectID,
    recipient: PrimaryAddress,
    user_data: UserData,
) -> AsyncResult<CertifiedOrder, Error>

fn publish_module(
    &mut self,
    gas_payment: ObjectRef,
    module_bytes: Dec<u8>
) -> AsyncResult<CertifiedOrder, Error>

fn call_module(
    &mut self,
    module: ModuleId,
    function: Identifier,
    type_arguments: Vec<TypeTag>,
    gas_payment: ObjectRef,
    object_arguments: Vec<ObjectRef>,
    pure_arguments: Vec<Vec<u8>>,
    gas_budget: u64,
) -> AsyncResult<CertifiedOrder, Error>

fn receive_from_fastpay(
    &mut self,
    certificate: CertifiedOrder,
) -> AsyncResult<(), Error>

fn get_possesed_objects(&mut self) -> AsyncResult<Vec<ObjectRef>, Error>

Is this now all done?

most of these are done, I think we can close this, will work with @stella3d and create new issues if new api methods are needed


Support get repo readme file on default branch

Describe the feature
/repos/{owner}/{name}/readme can only get readme from main branch
If it's posible to add a optional query named branch, without provide a branch get readme file from default branch
// ...
let branch = event.context.query.branch

if (!branch) {
  const { default_branch } = await $fetch(`https://api.github.com/repos/${owner}/${repo}`)
  branch = default_branch || 'main'
}

const markdown = await $fetch(
  `https://raw.githubusercontent.com/${repo}/${branch}/README.md`
);
// ...

I don't know if it's a good way to get default branch......
or add a default branch response field in /repos/{owner}/{name} ?
const repo = <GithubRepo & { defaultBranch: string }>{
  id: rawRepo.id,
  name: rawRepo.name,
  repo: rawRepo.full_name,
  description: rawRepo.description,
  createdAt: rawRepo.created_at,
  updatedAt: rawRepo.updated_at,
  pushedAt: rawRepo.pushed_at,
  stars: rawRepo.stargazers_count,
  watchers: rawRepo.watchers,
  forks: rawRepo.forks,
  defaultBranch: rawRepo.default_branch
};

Additional information

[X] Would you be willing to help implement this feature?

OH! I found ghRepo function in utils, and the response has been cached? Maybe add a response field in /repos/{owner}/{name} and get default branch from this is a better way......

#49


Save functionnality

Hey ! How can i save all of my brackets and reuse them ? With AJAX, BDD, FORM PHP ? I don't know how i can save them, so if you can help me i'd be grateful !
In my index test page :
<?php
if(isset($_POST['prenom'])){
	echo "Prénom : ";
} else {
	echo '<form action="test.php" method="POST">
<input type="text" name="test">
<input type="submit" value="Tester">
</form>';
}
?>

In my test.php page :
<?php
	$info = array_map("htmlentities", $_POST);
?>

Thanks by advance ! :+1:

Hi,
As it says in the saveFn(), you can send the data to your backend using JavaScript, e.g. jQuery.ajax() or maybe nowadays with the fetch() API. When you load the page, the data passed to init field should match what you previously saved (the data that was the argument of the saveFn().
You might get some ideas from this very old demo: http://www.aropupu.fi/bracket-server/

I did something like that : http://dianophe.alwaysdata.net/tournament/
I don't know if my logic is right.
If you can help me outside of Github.
I'm learning MVC at school (In paris), but i'd like to learn how works API, that would be great !
(Sorry if my english isn't so gud im a french guy :) )

Ok i understood all, thanks for your response !

Yup. Regardless of how you send it to any backend, that's the format that needs to be available for init when loading the bracket again.


Benchmark and optimize steps of translation

Currently it takes a few seconds to translate a sentence. All steps other than the Codex query should be examined and optimized.

@ayush1801 I have implemented a nearest neighbour search (copying many things you did, in particular using torch.topk) for the case of prompts. I used a simpler model so this should be faster. But still, I wanted to alert you that I am finding that loading  and finding top-k is instantaneous.
It may be worth checking if there is some inefficiency in the main code we use.

Now most of the time will be taken by GTP 3.5/4 so no point in this.


Actually run CI on all pull requests

Wrangling the CI system...

Current dependencies on/for this PR:

master

PR #36   (this PR)

This comment was auto-generated by Graphite.


[Bug] Sum of output audio has missing high frequencies compared to original audio

The issue I'm experiencing is that the sum of spleeter's output audio has missing high frequencies compared to original audio.  Regardless of the file input codec (and audio source), this problem seems to persist.  A full report on what frequencies the sum is missing is provided at the end of the bug report.
I can't tell from my surface-level perspective if this is a decoding issue (ffmpeg decoding audio to a lower bitrate), or if this is inherit with the trained models.  I would expect that part of the training criteria for a AI like this, is that if the AI gets trained so that the sum of the outputs equals almost exactly the input stream.  I'd love to read the white paper to see if this condition was actually in the training criteria.

Step to reproduce

Create venv using python3
Install spleeter via venv's pip3
Run spleeter's executable using any model (2 through 5 stems)
Spleeter outputs correct number of audio files.  Import all audio files into your favorite audio editor (Audacity, Ableton)
Output sum does not contain as much high frequencies as original audio.

Output
Spleeter runs and reports like standard.  No issues are thrown.  Audio data is reported to load successfully.
Environment

OS
MacOS

Installation type
pip

RAM available
16 GB

Hardware spec
i9 9700k,  Radeon RX 590

Experimentation with the issue
After following the steps I provided above, I then imported my original file and the output spleeter audio to Ableton.  I grouped all the spleeter output audio, and inverted the group's audio.  The sum of the original audio and the inverted group reveals the audio "missing" from the spleeter audio.  Using a spectrum analyzer set to a FFT size of 16384 shows a peculiar cutoff in frequencies at 11k Hz (See image).

(Note: audio used here is Earth, Wind & Fire's Let's Groove, provided in the wav codec.  The y scale is in dB.  Notice the almost 72 decibel difference from the low and high shelf)
This odd case of missing frequencies above 11k Hz applies to any audio, any codec, at any sample rate I tried.  Even after resampling EWF's Let's Groove from 44.1k to 192k, the same cutoff applies.
Interestingly, sampling rate of 44.1k divided by 4 results in 11025 Hz, which is roughly 11k.  I have no idea if this gives a clue that it's a decoding issue (ffmpeg), or if its a model issue.  Though, it's interesting to think about.

Able to consistently reproduce. Here's a spectrogram from Audacity of the output.

Apparently this is a duplicate of closed issues and is the intended behavior. Cutoff can be changed here: https://github.com/deezer/spleeter/wiki/5.-FAQ#why-are-there-no-high-frequencies-in-the-generated-output-files-

@CoderSear Interesting find!  The issue thread even has two other issues referenced referencing the same "problem."  I think it would be a good idea for the managers of the repository to put that documentation somewhere easy to find for others!

@zardini123, it is already documented in the FAQ section of the wiki.

@romi1502 I believe it would be best to put a link to that specific FAQ entry in the readme.  The option to change the behavior of the mask seems very crucial for many.  I'd see many more people reporting this same "issue" I did in the future, simply because the information is not in the forefront.

We've just updated the FAQ to provide a new way of performing separation above 11kHz. Also configs that perform separation up to 16kHz were packaged in spleeter as mentioned in the wiki


University of the Ijevan

Institution/School Name
{Name Here}
Instiution/School Website
{Website URL}
Email Users
Please place an x between the square brackets if yes

[x] Students
[ ] Academic/Teaching Staff
[ ] Other/Support Staff
[ ] Alumni

Education Levels
Please place an x between the square brackets if yes

[ ] Post-graduate research
[x] Graduate School
[ ] College (University) or Undergraduate School or equivalent
[ ] Community College or equivalent
[ ] High School or equivalent
[ ] Elementary School or equivalent

icloud.txt

lzu.txt

Add indigitous Hub Edu

itsmeccatronico.txt

> #### Institution/School Name

{Name Here}
www.isima.rnu.tn/
{Website URL}
<EMAIL_ADDRESS>Please place an x between the square brackets if yes
* [x]  Students

* [ ]  Academic/Teaching Staff

* [ ]  Other/Support Staff

* [ ]  Alumni

Education Levels
Please place an x between the square brackets if yes
* [ ]  Post-graduate research

* []  Graduate School

* [ ]  College (University) or Undergraduate School or equivalent

* [ ]  Community College or equivalent

* [x ]  High School or equivalent

* [ ]  Elementary School or equivalent

isima.txt

isima.txt

机构/学校名称
{吉首大学}
Instiution /学校网站
{Jishou University}
电邮用户
如果是，请在方括号之间放置一个X

[x]  学生们
[ ]  学术/教学人员
[ ]  其他/支持人员
[ ]  校友

教育水平
如果是，请在方括号之间放置一个X

[ ]  研究生研究
[ ]  研究所
[x]  学院（大学）或本科学校或同等学历
[ ]  社区学院或同等学历
[ ]  高中或同等学历
[ ]  小学或同等学历
stu.txt

file.zip
Augustinerschule Friedberg

file.zip

file.zip

file.zip

Hi,
It would appear that you have opened a pull-request containing commits from JetBrains/swot which is a fork of this repository (leereilly/swot).
If you intended to create a pull request for JetBrains/swot, may I suggest you create a pull request there.
We cannot accept your pull request if it contains more than one institution, as is the case here.
If you want your institution to be included please follow the following steps:

Delete your fork of swot
Create a new fork of swot based upon this repository
Create the file (and directories if necessary) to add the institution to your fork
Open a new pull request against this repository to merge your fork.

I am closing this pull request, as it is for the wrong repository.


:feet: let the user choose the boot disk for multiboot

Ref: https://github.com/kubev2v/forklift/pull/930
Support: plan.vms[n].rootDisk {string}

@bkhizgiy hi,
a. do you know how the "rootDisk" parameter will be used ?
( for example, is it going to be a number e.g. "1" - first disk (default) "2" - second disk ? )
b. do you plan it to be a plan thing, e.g. all the vms will have the same rootDisk value ?

@bkhizgiy hi,
it's going to be a vsphere only ?
Ref:
https://github.com/kubev2v/forklift/pull/873/files#diff-2bd31ec649de5f659c2c9a2f062e677dd9f4bde75f165d281f32ba98c3d9cc68R57

@yaacov Hi, we just had this conversation yesterday:) I'm still thinking about the best way for the user to specify this property. We were considering passing a number like you suggested; I just need to check if it can be processed correctly in the backend. I'll update here once we have a final conclusion.
And no, I think it should be applicable for OVA as well. From virt-v2v, I saw it's possible to do in OVA conversions as well, so I think we should support all flows.

addressed by: https://github.com/kubev2v/forklift-console-plugin/pull/1205


security issue at global search function

Is it secure when we get the searchable columns from the request at globalSearch via $this->request->searchableColumnIndex() , My end users edit the columns array at the client side to add columns that aren't exists in the original datatable columns so they could do search query on them

You can use the following if that is a concern for your use case:
https://yajrabox.com/docs/laravel-datatables/10.0/whitelist
https://yajrabox.com/docs/laravel-datatables/10.0/blacklist

I know these two functions but I think it won't help because we can add x column as whitelist and this x column have two options searchable is false and orderable is true then the user at the client side edit the searchable to true he will be able to search against this column.

A workaround to disable search on the specific columns is via filterColumn and add an empty closure.
    return DataTables::eloquent($model)
                ->filterColumn('fullname', function($query, $keyword) {})

The same goes with orderColumn.
Lastly, you can do your own manual search and disable global search.

I think we need to check from something at server side instead of doing workaround because we have many causes to handle and  we won't force the  package users to write extra code at every datatable


Cross post this to LinkedIn so we can further promote this project

https://twitter.com/ykdojo/status/1753730930580324620

Scheduled (and informed Mike about it):


Brief guide for using Openshift Local

Thank you Tomas Tomecek for all your help!

Could you please move the markdown from docs/openshift_local_cluster.md to docs/deployment/openshift_local_cluster.md?

Could you please move the markdown from docs/openshift_local_cluster.md to docs/deployment/openshift_local_cluster.md?

Sorry for being annoying, we have it twice now :smile:


Write tests for all languages

Write tests for all languages
Currently, code-executor supports all languages mentioned in src/langs. There are no script yet to test if these languages work properly. You can add tests in test for each language.
Proposed structure

Each language has a folder inside test, the name of the folder is the name of the language
There are two scripts in each folder, one for master and one for the worker.

You might consider using a testing library such as mocha or chai. However, for this, timeouts need to be configured properly since these tests will be running on Github Actions in the future. Nonetheless, adding a unit testing library for each language is not a priority right now, verifying that the Dockerfiles for all the languages work can be done with or without mocha or chai.

I'll do this, @alias-rahil can you assign this to me?


Add BSides Brisbane 2023

Name: BSides Brisbane 2023
Website: https://bsidesbrisbane.com/
Date(s): 15 July 2023
Location: Brisbane, Australia
Free: N

Added, thank you!


assignment of string union defined in class interface should allow without casting

TypeScript Version:  3.4.1

Search Terms:
Class string union from interface
union type does not work in classes
Code
interface namedperson {
    name: "george"|"elaine"|"jerry"|"cosmo"
}

class person implements namedperson {
    name = "george"
}

Expected behavior:
No errors
I would expect the behaviour to work as it does outside classes, e.g:
let person: namedperson = {
    name: "george"
}

Actual behavior:
Error:
Property 'name' in type 'person' is not assignable to the same property in base type 'namedperson'.
  Type 'string' is not assignable to type '"george" | "elaine" | "jerry" | "cosmo"'.

Playground Link: TypeScript Playground
I'm aware that this can be worked around by using either:
class person implements namedperson {
      name:"george" = "george"
}

or:
class person implements namedperson {
    name = "george" as "george"
}

however I find these both heinously ugly and would rather stab myself in the face.

"george" as const is the new way to write that
See https://github.com/Microsoft/TypeScript/issues/10570#issuecomment-296860943

Oh that's a bit nicer, thanks!


Feature Request: Colour/Bold known Symbols whilst Typing

Hi,
Very excited to try the new-and-improved crystal interpreter mode! Very close to being able to replace ruby now, great work!
Something I really like ,coming form the fish shell, if that it highlights commands/functions that don't exist whilst you're typing; they then change colour when you complete a word, and the command is known to it:
https://asciinema.org/a/mrBhMosJptys2L72TaA8f03vx
I think implementing this could be really nice. If a constant, local, method, etc. is known, then when I type or tab-complete, it comes up either in a different colour, or possibly in bold, so that existing colours may be preserved. Or conversely we could add an accent to identifiers that aren't in scope, rather those that are. I think any way is good, I just really like this feature, of interactively checking that your code is correct before you've even had to complete the line.
Thanks

Thank you @stellarpower bringing this!
I really like the idea too, it's something doable but the main difficulty to know which word is valid or not. It need to execute crystal semantics on fly to know the types and know is a method is defined on a local. (e.g. we need to know if x.foo is valid or not) That something not well supported yet, but in a first time we could enable highlight for trivial definitions like keywords, toplevel vars, toplevel constants, and toplevel defs.
That said, in the REPLy repo, we doesn't consider crystal things, we only have to enable highlight on such definition, then it's the matter of the repo above to decide what highlight, e.g. in crystal directly or IC.

Yes, you're quite right. I realised only halfway through it might involve some entanglement.
This might be the route that involves the most effort, but potentially the cleanest idea to me seems to be more of a client-server model. The code using REPLy (i.e. the crystal compiler) could send updates to the repl when it wanted to change something, but also, listen and receive information from the REPL.
Naïvely it could be done for each keystroke; I think more likely would be a sort of dual state machine. The user types a new line, and the REPL pushes an update onto a queue; this gets popped on the compiler side, it does some work, and pushes its message onto the queue in the other direction. So any updates to constants or what have you could come this way. Ideally in some way that frees up the REPL only to need to understand a basic idea of what's important (like you say - constants, locals, globals, typenames, ...), and the compiler then pushes an update to a list. Or alternatively, it might be possible to check with the compiler each time - tab completion, new word, etc.
Idk if it makes much sense with the way the code currently works, it's just an idea that comes to mind. Operating the REPL like a service with its own internal state and lifecycles, also might make sense for other applications. The downside of course is that asynchronous programming like this is quite a bit more annoying to follow, unless you're coming from JavaScript or C# or something similar, where you never seem to find a line without async or await!!!
Thanks for considering this in detail!!

In fact I might go back to this again; because one thing I would sorely love would be a Crystal shell. The interactive prompt in the compiler should do for some of this (and I fully accept that something like this would probably have to come once the interpreter has gained some more sophistication); but as a fish user, I still think the CLI has a massive way to go. Manipulating tables and JSON, making web requests, working with other more typed data is a big part of what we need to do from the terminal these days, not just the sorts of whitespace-delimited text processing people did in the 70s.
Something like Xonsh is a pretty good option. However Python is rather horrid, and the syntax for Xonsh isn't really much better than just straightforward plain Python scripts. So I had been keeping an eye out for a usable and maintained ruby-based shell for some time, that kept the language, but made it a bit more frictionless to invoke other programs. Throw in a proper understanding of types to say "Hey, that's stupid - don't do that", yet still really quick and expressive to work with, and Crystal shell would be the ideal tool IMO. If the REPL could (to some extent) support some of the more advanced requirements for something like this, I think that'd be really cool. Hopefully it wouldn't be too long before someome tried to do it. The other possible location I could see it being used is a bit like pry, in some sort of hybrid-debugger, where we can step through code with a native debugger like lldb; yet somehow also jump to an interactive prompt with the ability to inspect things, evaluate expressions and call methods, possibly even change the program state, if linked against our program.

Yeah, design REPLy more like a client-server could be very beneficial, especially the fact to have a hook for each keystroke. Currently the Repl communicate to the client with overridden methods, and the client send back information through the return value. Without changing the main functioning of this, we could add methods for each event of the Repl. Inside these methods we can then send controls back through already existing methods (e.g. repl.editor.move_cursor_to(x: 0, y: 0), repl.editor.current_line = "Hello", ...)
And we could imagine centralize that on the form of commands with a macro like repl.cmd(:move_cursor_to, x: 0, y: 0), and repl.cmd(:current_line=, "Hello").
Maybe later we could use callbacks instead of overriden methods, but this would be definitively much more work.
In any case, going toward this idea seem to me good!

one thing I would sorely love would be a Crystal shell

Yes, me too!, Could you explain more in detail which features you would like to see over the current crystal repl?

Throw in a proper understanding of types to say "Hey, that's stupid - don't do that",

On the repo IC I put lot of effort to get a smart auto-completion (yet still experimental), which give a pretty good user feedback, but of course, could be improved more.

an interactive prompt with the ability to inspect things, evaluate expressions and call methods, possibly even change the program state

On pry I believe we could already do all these thinks!, but with some limitations (you can change variable content, as long you respect its type, you cannot do hot-reload, ...)
Moreover pry use already REPLy, so it will inherit all shell capacities rather easily.