Not showing the image

Hi there,
I was using the 3.0.0 version but I was having this message for some images :
The cache system is not running. Images will be loaded by your browser instead.
I tried to update to 3.1.0 and 3.1.1, but since then, I can see that the 'img-loader' got a "file//......." so I guess it is working, but the image is not displayed (and I see that the natural size of the image is 0x0 px), and " File Transfer Finished with response code 200".
Maybe I am missing something in the configuration ? (Like the File/File Transfer plugins ? I did the instructions but nothing more)
I am using angularjs4, ionic 3.0.1, and latest cordova.
My issue is on iOs simulator and iOs device.
Thanking you in advance
Regards

Could you please enable Debug Mode and let me know if you get any error messages? See https://github.com/zyra/ionic-image-loader#global-configuration for more information.

I am having the same issue. But if you in global config turn the image into imageLoaderConfig.setImageReturnType('base64');. It will work.

@hughred22  Thanks it is working very well ! I did set the debug mode, but I had no error message

same issue here but on android after updating from 3.0.1 to 3.1.0 and @hughred22 's solution not working it shows an corrupted image  for me when I load from  a URI

@hughred22 you saved my day thx

@hughred22 I just found that on Android 5.0.X, it is not working also (even with your fix). Do you have any idea ? thanks !

bla


fix(venue-proxy): rename Connection type in venue-subgraph to VenueConnection

VENUE GRAPHQL PROXY is deployed to platta: https://venue-graphql-proxy-pr335.dev.hel.ninja :rocket::rocket::rocket:


cantor: fix build

https://hydra.nixos.org/build/275968822/nixlog/1
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Any reason to use this over kdePackages.cantor?

@K900 It is still updating. Why remove it?

It is not, the Qt6 version in kdePackages is.

@K900 Should we remove it?


Syntax lookup: labeled and optional args

Can you add the @tag attribute?
https://rescript-lang.org/docs/manual/latest/variant#tagged-variants

Will do, but in another PR. Added to the list for now.


SetUp help

I am trying to follow the instructions to setup the project, but it seems that you mention a services.xml that does not exist in this repo, namely in thse instructions:

Open Alloy4Fun/WebContent/WEB-INF/services/AlloyService/META-INF/services.xml
* delete all its content and paste the one in this repository in the Alloy4FunWebService folder.

Can you please upload the file, or give any other tips on how to proceed?
Thanks!

This is what I get when searching .xml files in the repo:

searching through the commits i found it here : 3c992a675373a4c41a4d9d2def1c6b15468d5899
hope it helps

Thank you, that was it.


Not possible use ColorInt, only ColorRes

ColorInt is much more universal, you can chnage ColorRes to ColorInt, but not vice versa.
setColor(@ColorInt int color, @ColorInt int color2); would be useful :)

Sorry, I'm stupid, there is a setColors...  :)

No question is stupid!
Thanks for your other contribs.


fix vulnerabilities with dev dependencies

Coverage remained the same at 100.0% when pulling 270fae4ff7482433cc0cad60d292bf0a00baa8b3 on v2.2.2 into ce5de65c8b75a59d091073a01ce594039a3001fe on master.


Add support for suppressing project events

VS doesn't consume (e.g.) syntaxDiag events, so there's no reason to do the work to compute their payloads.

VS appears to have begun to receive these events as of #19864.

Note that only versions of VS patched to pass this additional flag will benefit from the change.

Please add test to verify this functionality

@sheetalkamat Better?

Apparently, it is unwise to use GH's merge tool.  I'll redo it locally.


Add the ability to hide the day field for a Date input in Umbraco

AB#173233 requires a 'Date input' component that only asks for the month and year. This PR makes that an option in Umbraco.

It is a follow-up to #246 to avoid an inevitable merge conflict from that one, so it should not be merged until that one has already been completed. The code can be reviewed now by looking at the relevant commit.
The base <govuk-date-input /> component that we use does not support this option, so we need to use the approach we took for adding validation attributes. This involves creating a tag helper that wraps the original component, reads the HTML output by that component, and updates that HTML using HtmlAgilityPack.
The UmbracoDateInputModelBinder is updated to know when it should not expect a day field, and in that case it uses 1 for the day so that a DateTime or DateOnly object can be created. This is why this change is for Umbraco projects only - the DateInputModelBinder in the base project doesn't do this, and always expects a day.
The backoffice preview reflects the selection made.
The Umbraco example app has an example of a month and year date field.

@HarryAmmon Comments addressed, ready for another look


Compile JS version for new Kotlin IR

Since Kotlin new IR is active in 1.5.x, the multiplatform build should support the IR setting for JavaScript.

Version 1.1 is compiled to do both IR and legacy.


Fix potential npe bug of #14384

Motivation
Fix potential np bug
Modifications
Fix potential np bug
Documentation
Check the box below or label this PR directly (if you have committer privilege).
Need to update docs?

[ ] doc-required
(If you need help on updating docs, create a doc issue)

[x] no-need-doc
(Please explain why)

[ ] doc
(If this PR contains doc changes)

@gaozhangmin Please add some tests to cover this change.

@gaozhangmin Please add some tests to cover this change.

The tests were already covered by BookKeeperPackagesStorageTest.java. But need to change zookeeperServers to metadataStoreUrl @lhotari

/pulsarbot run-failure-checks

@gaozhangmin Please add some tests to cover this change.

The tests were already covered by BookKeeperPackagesStorageTest.java. But need to change zookeeperServers to metadataStoreUrl @lhotari

ok, that explains. At the time I checked the PR there was a fix, but no test changes and that's why I made the comment.


allow special value of "initial" for "max"

Specifying "initial" as the max value will stop increasing the font size beyond the initial font size.

You may set data-fittext-max to the special value "initial" in order to prevent the font size from increasing beyond the CSS-computed style. This requires the font-size property to have been either inherited, or applied via a CSS selector. It does not work for inline font-size set via an inline style attribute. It also requires support for window.getComputedStyle() (IE 9+).

Thanks for the PR, finally implemented : )

:+1:

v4.1.0: uses the more semantic 'inherit' value instead. Also used by data-fittext-min.


Issues with checkpoint files

Can you please fix the checkpoint files? I believe there is some issue with it

Hi Ritik, thanks for your issue. So I've taken a look at the checkpoint files and it appears that for the option --weights_GAN [GAN_checkpoint] you should link to the directory for SN_PatchGAN instead of to checkpoint (as the readme indicates).
Hope this helps!


upgrade circe library

Trying to upgrade circe core library to overcome a dependency eviction error.

Can you provide more details on the error you are seeing?

Closing because this is a duplicate of https://github.com/circe/circe-config/pull/338, we'll get a release cut after https://github.com/circe/circe-config/pull/361 is merged.


the program cannot upload to S3

I get this error when I try using s3cmd
mimoo@server:~$ s3cmd mb s3://my-database-backups
ERROR: Bucket 'my-database-backups' already exists
ERROR: S3 error: 409 (BucketAlreadyExists): The requested bucket name is not available. The bucket namespace is shared by all users of the system. Please select a different name and try again.

And the program gets me this error:
ERROR: S3 error: 400 (InvalidRequest): The authorization mechanism you have provided is not supported. Please use AWS4-HMAC-SHA256.
Old backup removed.
Moving the backup from past week to another folder...
ERROR: S3 error: 400 (InvalidRequest): The authorization mechanism you have provided is not supported. Please use AWS4-HMAC-SHA256.
Past backup moved.

looks like this happen if I create the bucket manually on the aws panel. If I do it with s3cmd it works (and also the error I got was because I have to find a name that no other of their clients have chose

You might have two issues here. Keep in mind that bucket names must be globally unique.

@mimoo You need to create an unique bucket on S3. S3 buckets are unique just like domain names. Try something like this instead: s3cmd mb s3://mub-09876ddc-u


Add Kartik Malik to contributers list

This is a great initiative. Thank you for inspiring me to do this :+1:

Hi  @kartik2406, I'm quite elated about your pull request. I wanna evolve this project to addresses various problems faced by first-time contributors. I'd love to learn about your journey in open source community, the problems, pain points you had etc.
Could you explain how you felt when you went through the tutorial, made a pull request and learned that I merged it?
We’ve recently added social share  to our web app. Could you please go to https://roshanjossey.github.io/first-contributions/#social-share and share your first contribution to open source?
Also, check out projects with easy issues while you’re there.


Enable AWS Shield mitigation using Config auto-remediation

Summary
AWS Shield offers auto-mitigation of DDoS attacks.  However, enabling this causes the Terraform definition for our WAF ACLs to get out of sync with the infrastructure since the auto-mitigation adds a new AWS rule to the ACL.
There is an active AWS provider issue tracking the problem, but no official fix yet.
However, there is a Config based solution that may accomplish what we want:

Continue to use Terraform to manage our WAF ACLs; and
Re-enable AWS Shield auto-mitigation when it gets removed by a Terraform apply action.

Solution:
https://github.com/humanmade/shield-custom-aws-config-rule
Related

hashicorp/terraform-provider-aws#22869

This should now be fixed as of the AWS provider 4.56 release:

hashicorp/terraform-provider-aws#29575

Currently the auto-mitigation still needs to be manually enabled until this lands:

hashicorp/terraform-provider-aws#26873

Confirmed that auto-mitigation rule is now present in the test account and TF is not attempting to manage it:

Hi folks,
I'm an SRE with the GOV.UK Notify team and we have some issues with the ShieldMitigationRuleGroup and I'd like to double check that it's not just us.
tl;dr
With the terraform-aws-provider version 4.56.0, when we do a plan it seems to ignore any ShieldMitigationRuleGroup as expected. However, after we do an apply and we check the AWS Console, that ShieldMitigationRuleGroup is no longer there.
Example
We have 3 rules:

The first is managed by terraform, and we're just changing the threshold
The second is not managed by terraform and should be deleted on apply
The third is a rule with a name that matches the pattern that the wafv2_web_acl ignores, so it should not appear in the plan and should not be removed

Terraform plan shows the expected output:
 # module.paas_proxy.aws_wafv2_web_acl.api_paas_cloudfront will be updated in-place
  ~ resource "aws_wafv2_web_acl" "api_paas_cloudfront" {
        id         = "633d1518-f001-4e32-a962-de935dc29e12"
        name       = "apiWaf"
        tags       = {}
        # (5 unchanged attributes hidden)

      - rule {
          - name     = "2000-Requests-per-second" -> null
          - priority = 0 -> null

          - action {

              - count {
                }
            }

          - statement {

              - rate_based_statement {
                  - aggregate_key_type = "IP" -> null
                  - limit              = 600000 -> null
                }
            }

          - visibility_config {
              - cloudwatch_metrics_enabled = true -> null
              - metric_name                = "BlockedOnMaxRequestsPerIP" -> null
              - sampled_requests_enabled   = true -> null
            }
        }
      + rule {
          + name     = "2000-Requests-per-second"
          + priority = 1

          + action {

              + count {
                }
            }

          + statement {

              + rate_based_statement {
                  + aggregate_key_type = "IP"
                  + limit              = 2000
                }
            }

          + visibility_config {
              + cloudwatch_metrics_enabled = true
              + metric_name                = "BlockedOnMaxRequestsPerIP"
              + sampled_requests_enabled   = true
            }
        }
      - rule {
          - name     = "another-rule-test" -> null
          - priority = 1 -> null

          - action {

              - count {
                }
            }

          - statement {

              - byte_match_statement {
                  - positional_constraint = "EXACTLY" -> null
                  - search_string         = "this-is-a-test" -> null

                  - field_to_match {

                      - single_header {
                          - name = "x-another-waf-test" -> null
                        }
                    }

                  - text_transformation {
                      - priority = 0 -> null
                      - type     = "NONE" -> null
                    }
                }
            }

          - visibility_config {
              - cloudwatch_metrics_enabled = true -> null
              - metric_name                = "another-rule-test" -> null
              - sampled_requests_enabled   = true -> null
            }
        }

        # (2 unchanged blocks hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.

But after the apply this is what we see in the console:

Have you noticed a similar behaviour?

That is odd.  I did a quick check and I'm still seeing ShieldMitigationRuleGroup for accounts that have had a Terraform apply run since we enrolled.  However, none of those TF applies were making WAF ACL rule changes.
I'm off work this week, but when I'm back I'll run some tests to see if I can replicate what you're seeing.

I double checked and it looks that the ShieldMitigationRuleGroup is being removed even if you change just the threshold for one of the rules that you manage in tf.

That's great, thanks for confirming 👍


Why backgroundactive removes vertical centering?

When using this option:
backgroundactive
The overlay no longer stays vertically centered with multiple sizes, it stays fixed. Is this by design or there is something else we should do?

I have the same concern. Please update if you can. Thanks.

Same here, when adding backgroundactive:true to lets say a standalone version, the #standalone_background disappears and #standalone_wrapper changes height from 100% to 0px.

Hi, thanks for reporting and sorry for the delay.
This should be fixed on v2.0.1.
backgroundactive option was removed in version 2.0.1 but you can achieve the same effect with {background:false, absolute:true, blur:false}.
Here's a demo https://codepen.io/anon/pen/EGawMr .
New examples are added to the demo page as well https://dev.vast.com/jquery-popup-overlay/ .


Issue when: 4. Generating Training data

Hi Tanner,
generate_tfrecord.py in section number 4 ( Generating Training data) Dat Tran’s raccoon detector, it
address tf 1.x. while your code addresses tf2.x.
Generates:
Traceback (most recent call last):
File "csv_a_tf.py", line 24, in
flags = tf.app.flags
AttributeError: module 'tensorflow' has no attribute 'app'
i recommend updating the reference to another repo (maybe https://github.com/douglasrizzo/detection_util_scripts)
Best regards
yo0x

I updated the readme as requested. Thanks for pointing out that the section wasn't up-to-date anymore.


[WIP] Add build-support/elf-utils

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/silence-patchelf-wrong-elf-type-messages-from-audit-tmpdir-sh-setup-hook/56348/1


[Bug]: Jetcaster does not show any podcasts and doesn't respond to keyboard input

Is there an existing issue for this?

[X] I have searched the existing issues

Is there a StackOverflow question about this issue?

[X] I have searched StackOverflow

Is this an issue related to one of the samples?

[X] Yes, this is a specific issue related to this samples repo.

Sample app
Jetcaster
What happened?
When running Jetcaster on the emulator, the app does not show any podcasts (which presumably it is supposed to), and when attempting to enter text into the search field, no text appears.
Screen_recording_20240909_154310.webm
Relevant logcat output
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

I think there are 2 issues here.
Re loading podcasts, I ran the app on a couple of devices, including some emulators. On one of the emulators it did take a good few seconds to load podcasts, but they eventually did load, so at this moment I don't have a repro case. @dturner do the podcasts eventually load, or is it blank indefinitely?
Re the search bar, it seems we just never update the text as you type, it's always just "". That much is a quick fix, but the app doesn't have any actual search or text-matching logic, so it won't impact what items are displayed.

I'm getting a NetworkOnMainThreadException when fetching the podcasts, which filters all feeds down to an empty list, so the selectedCategory won't get updated, and discoverItems() just returns without adding any UI.
(I added a breakpoint at PodcastFetcher:83)

I think there are 2 issues here...

Both of these have been addressed, so closing this issue.


Integrate publishers into store

As discussed on Mastodon I found a way to integrate CoreData entity stores (as I call them so far) as suggested here into the store via Combine publishers.
I use a singleton "entity store" per CoreData entity. When I set up the store I hand over one publisher per "entity store" mapping the CoreData changes of the entities to update actions for the store. This action typically has an array of the instances as payload:
EntityStore.shared.instances.map { AppAction.entityAction(.updateEntity($0)) }
Processing such an action in the according reducer would end up updating the composed state with the updated instances of that entity:
      case .updateEntity(let instances):
            state.instances = instances

Don't be confused by the different commits. I reverted the changes re: allowing empty actions for derived stores (I will consider you suggestion to this next) and renamed the branch from development to integrate-pusblishers-into-store.

Hi @apfelnutzer, thanks for your PR.
I think we shouldn't integrate Combine framework in the Store, it looks like Apple silently deprecated it.
Instead you can achieve this by feeding actions into the store from the outside, here is the small example I have in my project:
struct FeedView: View {
  @StateObject private var store: Store<FeedState, FeedAction> = // ...

  var body: some View {
    Text("Hello")
      .onReceive(NotificationCenter.default.publisher(for: UIApplication.significantTimeChangeNotification)) { _ in
        Task {
          await store.send(.fetch(.now))
        }
    }
  }
}

I'm on vacation these days - I will look into thin once I'm back around end of next week!

@apfelnutzer have a nice vacation!


Replace Properties with Map<String, String> in Exporters interfaces

Fixes #6419
This makes changes to the 4.0 branch since the interface is already modified due to other changes.
Changes proposed in this pull request:

Uses of Properties are replaced with Map<String, String> in the export() method of Exporters interfaces
The classes implementing the interfaces are updated to match
Methods exportRows() and countColumnRows() CustomizableTabularExporterUtilities are also changed to use Map<String, String> to accommodate the change
Unit tests are updated to match all changed code and mocking is removed where unnecessary

Thanks a lot for this!
I think I intuitively agree with the idea that it's worth doing this sort of change on the occasion of a larger change of interface, so adding it on top of the data model changes feels right in that sense. On the other hand there is also a case for keeping breaking changes as atomic as possible and giving people the opportunity to migrate gradually. We are currently discussing how to schedule such changes on the forum:
https://forum.openrefine.org/t/scheduling-breaking-changes-we-have-on-our-radar/1410/4
In the light of this discussion, I would keep this PR open (probably for a long time) until we have some clarity on how we proceed.
From my side, I would like to express my support to your approach and my gratitude for your work - even if it might not be reflected in the formal status of this PR as soon as I would wish!

I've adapted this to the master branch and split it into two pieces: API (#6796) & Implementation (#6797) which supersede this PR.
Thanks again for your contribution @karindev ! I've used your commits as the basis for those, so you'll receive credit when they're reviewed and merged.


How to evaluate on BitextMining and Summarization datasets

I want to evaluate my model on all BitextMining and Summarization datasets, but I set task types ['BitextMining', 'Summarization'] and cannot get any result, how can I run it?

I got it, Summarization has been updated, BitextMining does not include the "en" type. Thank you.


itvr-309-300--bcsc

(1) The relevant BCSC token fields (first name, street address, etc.) are used when saving an application. These fields do not come from the frontend; they are taken directly from the token when our API authenticates the request and attached to the user object.
(2) In the admin panel, when viewing a submitted application, if there are no uploaded documents , we see a dash in place of the image.
(3) For a household application, if both applicants are BCSC, the application will compare their BCSC addresses (simple string comparison, nothing fancy). If the addresses don't match, the status of the application is "submitted". However, in this case, in the admin panel, we do not see any address information for the household member. I will make a card to address this issue.
(4) The application assumes that bcsc postal codes (if present), are formatted as "XXX XXX" or "XXXXXX". Also, will bcsc users always have an email (I'm talking about a user email address from the bcsc idp, not the email the user submits on the form). The test bcsc accounts given to us do not; this means that when a user logs in with bcsc for the first time, they'll be directed to a page where they can edit their email, first name, and last name. This may be undesirable. We can actually configure keycloak to turn this behaviour off, but its realm-wide and not client-specific. We should check with the bcsc people about the postal code and email issues - I will make a card for this as well.
(5) The documents fields in the application and household_member models are now non-required fields; however validation for these fields is still required when the user is a bceid user; this validation is now done at the serializer level.

Cool, looks good @tim738745 ! Just needs a rebase after Kuan's merge.

@naomiaro Thanks! Rebased and also fixed an issue with missing details page fields when user is bceid.


cmd/compile: bounds check elimination thwarted by if-foruntil idiom

Please answer these questions before submitting your issue. Thanks!
What version of Go are you using (go version)?
go1.10devel
Does this issue reproduce with the latest release?
yes
What operating system and processor architecture are you using (go env)?
linuxamd64
What did you do?
This code is an example of how for i,x := range array loops are rewritten when
a loop preemption check is inserted, for two variants of the range check (unsigned
and signed -- unsigned should be easier, but because 0 <= i < len(l), signed i+1 is also
guaranteed to be greater than zero).
package foo

func f1(p []byte) bool {
	i := uint(0)
	l := uint(len(p))
	if i < l {
		for {
			if p[i] != 0 {
				return true
			}
			i++
			if i >= l {
				break
			}
		}
	}
	return false
}

func f2(p []byte) bool {
	i := int(0)
	l := int(len(p))
	if i < l {
		for {
			if p[i] != 0 {
				return true
			}
			i++
			if i >= l {
				break
			}
		}
	}
	return false
}

When compiled, it would be nice if the bounds checks for the array access were eliminated, but the rewritten loops does not match of the idioms that are checked for (it is more difficult, since the bounds check fact arrives on two predecessors, and one of those is a backedge).
What did you expect to see?
Bounds checks removed (well, I didn't really expect to see them...)
What did you see instead?
genssa f1
   	00000 (.../ifuntilbounds.go:3)	TEXT	"".f1(SB)
   	00001 (.../ifuntilbounds.go:3)	FUNCDATA	$0, gclocals·...(SB)
   	00002 (.../ifuntilbounds.go:3)	FUNCDATA	$1, gclocals·...(SB)
v8	00003 (.../ifuntilbounds.go:3)	MOVQ	"".p+8(SP), AX
v12	00004 (.../ifuntilbounds.go:6)	TESTQ	AX, AX
b1	00005 (.../ifuntilbounds.go:6)	JLS	16
v23	00006 (.../ifuntilbounds.go:6)	MOVQ	"".p(SP), CX
v19	00007 (.../ifuntilbounds.go:6)	MOVL	$0, DX

v25	00008 (.../ifuntilbounds.go:8)	CMPQ	DX, AX   <- not necessary
b5	00009 (.../ifuntilbounds.go:8)	JCC	20             <- never taken
v21	00010 (.../ifuntilbounds.go:8)	MOVBLZX	(CX)(DX*1), BX
v9	00011 (.../ifuntilbounds.go:8)	TESTB	BX, BX
b10	00012 (.../ifuntilbounds.go:8)	JNE	18
v30	00013 (.../ifuntilbounds.go:11)	INCQ	DX
v6	00014 (.../ifuntilbounds.go:12)	CMPQ	DX, AX
b9	00015 (.../ifuntilbounds.go:12)	JCS	8      <- obviously redundant w/ JCC at 9

v35	00016 (.../ifuntilbounds.go:17)	MOVB	$0, "".~r1+24(SP)
b3	00017 (.../ifuntilbounds.go:17)	RET
v27	00018 (.../ifuntilbounds.go:9)	MOVB	$1, "".~r1+24(SP)
b8	00019 (.../ifuntilbounds.go:9)	RET
v17	00020 (.../ifuntilbounds.go:8)	PCDATA	$0, $1
v17	00021 (.../ifuntilbounds.go:8)	CALL	runtime.panicindex(SB)
b11	00022 (.../ifuntilbounds.go:8)	UNDEF
   	00023 (<unknown line number>)	END

genssa f2
   	00000 (.../ifuntilbounds.go:20)	TEXT	"".f2(SB)
   	00001 (.../ifuntilbounds.go:20)	FUNCDATA	$0, gclocals·...(SB)
   	00002 (.../ifuntilbounds.go:20)	FUNCDATA	$1, gclocals·...(SB)
v8	00003 (.../ifuntilbounds.go:20)	MOVQ	"".p+8(SP), AX
v12	00004 (.../ifuntilbounds.go:23)	TESTQ	AX, AX
b1	00005 (.../ifuntilbounds.go:23)	JLE	16
v23	00006 (.../ifuntilbounds.go:23)	MOVQ	"".p(SP), CX
v19	00007 (.../ifuntilbounds.go:23)	MOVL	$0, DX

v25	00008 (.../ifuntilbounds.go:25)	CMPQ	DX, AX   <- not necessary
b5	00009 (.../ifuntilbounds.go:25)	JCC	20             <- never taken
v21	00010 (.../ifuntilbounds.go:25)	MOVBLZX	(CX)(DX*1), BX
v9	00011 (.../ifuntilbounds.go:25)	TESTB	BX, BX
b10	00012 (.../ifuntilbounds.go:25)	JNE	18
v30	00013 (.../ifuntilbounds.go:28)	INCQ	DX
v6	00014 (.../ifuntilbounds.go:29)	CMPQ	DX, AX
b9	00015 (.../ifuntilbounds.go:29)	JLT	8

v35	00016 (.../ifuntilbounds.go:34)	MOVB	$0, "".~r1+24(SP)
b3	00017 (.../ifuntilbounds.go:34)	RET
v27	00018 (.../ifuntilbounds.go:26)	MOVB	$1, "".~r1+24(SP)
b8	00019 (.../ifuntilbounds.go:26)	RET
v17	00020 (.../ifuntilbounds.go:25)	PCDATA	$0, $1
v17	00021 (.../ifuntilbounds.go:25)	CALL	runtime.panicindex(SB)
b11	00022 (.../ifuntilbounds.go:25)	UNDEF
   	00023 (<unknown line number>)	END

I thought perhaps this had been fixed by all the work done on prove, but apparently not.
(I investigated.)
@aclements I think added some code that was supposed to catch just this idiom; the point is that this should match the rewrites used to avoid off-the-end pointers with preemptible loops, so perhaps the actual rewrite (the one that we care about) is different from this.
That the unsigned case is not caught is unsurprising, because signed is far and away the usual case, but the signed case is also not caught.

This is definitely caught for the real OFORUNTIL. There are some tests at the bottom of test/prove.go, including one "hand coded" foruntil pattern. I'm not sure what's different about your cases.

I need to investigate my case, but the important case is the one we generate automatically, which is what this bug is/was about. So closed.


Limits changed to Elevated Access, margin added + copy changed

Margin added to prevent two-tiered access from looking like a separate product.
Removed "has a rate limit enforced" as this is not a strict requirement of two-tiered access.
Limits changed to Elevated Access to avoid confusion.
Added text to clarify that public access does not require an API key.

🚀 Feature branch deployment: https://api-services-portal-feature-directory-changes.apps.silver.devops.gov.bc.ca

Design wise I think it's a step in the right direction towards clarifying that elevated access is not a separate product.
Additional changes to consider:

Reduce top margin (above Elevated Access).
"Public access does not require..." could be included directly under the public product name which it relates to.
Consider removing "For elevated access, please request access" entirely, since it should be more apparent what the "Request Access" button relates to.

Add in placeholder button

Latest changes:

Hey nice. Three thoughts:

Instead of disabled could we see the secondary style? (to compare at least)
Further reduce padding/margins - there is 40 px between the public/elevated buttons right now, while there is only 30 px between the buttons and the dividers beyond. I feel like these should be same value, or if anything the space between the associated items should actually be less.
Use sentence case 'No API key required' - I think the title case (Request Access) is appropriate when we have buttons with short names but otherwise sentence case is consistent with elsewhere (e.g. "View metrics in real-time") and looks better (IMO)

Thanks for your suggestions. Made those changes:


[testing-karma] Cannot execute a single test when running test:watch

In demo sample when running test:watch in DEBUG mode, I cannot execute a single test (a small right handed arrow next to each test). For instance: http://localhost:9876/debug.html?grep=OpenWc has a default title "Hey there" and counter 5.
The problem is with inline-module that incorrectly interprets grep argument.

we recommend @web/test-runner. If the issue persists there feel free to open an issue at https://github.com/modernweb-dev/web


Drag and drop files into terminal strips characters like \ " '

VS Code Version: 1.55.2
OS Version: MacOS Catalina 10.15.7

Steps to Reproduce:

Select a file with some special character in its name e.g.  \ " '
Drag&Drop it into the intergrated terminal

For example, a file with the name test " ' \ .txt will end up like '/Users/dengyaotriangle/Desktop/test   \\ .txt', which is undesirable.
P.S. In previous versions of VSCode (1.52.1), it seems to work fine. Dragging the file above will give  /Users/dengyaotriangle/Desktop/test\ "\ '\ \\\ .txt
I think the behavior of previous versions are correct, since a read command and the dragged string will yield the actual path
> read a
/Users/dengyaotriangle/Desktop/test\ "\ '\ \\\ .txt
> echo $a
/Users/dengyaotriangle/Desktop/test " ' \ .txt

While now, the string clearly differs from the actual path.
If it isn't a bug but an intentional change, can an option switching between these behaviors be added in the future?

Does this issue occur when all extensions are disabled?: Yes

This change was made intentionally in response to a security issue, we just strip all special characters to avoid running inline commands. We should be able to properly escape them if we're really careful.

I'm regularlay getting caught by this on the ; character.
We work with a lot of files with filenames in the format Author; Title.json and there's zero chance of this convention changing.
Having to manually put the semicolon back in every command is getting frustrating.
The security fix is obviously important but we shouldn't have regressed functionality as wont-fix


Add row limit to staking ledger table

Describe your changes
Issue ticket number and link
Relates to #1082
Checklist for contributors

[x] I have performed a self-review of my code
[x] I have run tier2 tests locally, and they pass

Checklist for reviewers

[ ] I have run tier2 tests locally, and they pass

merging as other PRs like this were approved


Commit Checks: Use new api location

The old checks endpoint isn't supported by github's new Fine Grained
Personal Access Tokens; but this equivalent endpoint is.

QA :+1:
Doesn't crash anymore when using a FAT!

dev_block :+1:
No longer crashes, the but API results are a different shape and it seems to be considering them all "not started". Pause.

un_dev_block :+1:
Had to combine two apis... resulting in six API requests where there used to be just one.

QA :+1:
It's running and refreshing pulls correctly.


Classes prop doesn't respond to changes when computed

Version

Vue version: 3

Description
First off, thanks for the work on this! I really like this select component ❤
When providing the classes prop as a computed property, multiselect doesn't apply the changes (i.e. is not reactive to the change).
I'm struggling attempting to apply "invalid" styling to the element, since the component doesn't re-compute class name changes.
Demo
https://jsfiddle.net/phuqkv0b/
When changing invalid to true and re-running the fiddle, the text and container border is appropriately changed to red. However, changing it dynamically via a button (for example) does not update the classes and reflect the necessary class changes.

Thanks for reporting @stevebauman - classes were indeed not reactive. This got fixed in 2.3.0.

Thanks @adamberecz! Really appreciate it 🙏


aws-c-common: add ptest run of repo tests

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/run


console.wrapConsole is not a function

same problem here that is because the consola hasn't been listed in dependencies but the project does use it!


HTTP Response doesn't always have an 'access_token' key.

The following error occurred in the GitHub authorization flow.
OAuth2Swift.swift

In regard to this response, it has only "error_description", "error" and "error_uri" keys. There are no 'access_token' key. Please consider to validate whether it has "access_token" key or not. if let statement may be a solution.

I don't know why GitHub uses status code 200 for this response.

Already fixed in master branch and available in next release
as you can see in code link you put
   guard let accessToken = responseParameters["access_token"] as? String else {
                    if let failure = failure {
                        let errorInfo = [NSLocalizedFailureReasonErrorKey: NSLocalizedString("Could not get Access Token", comment: "Due to an error in the OAuth2 process, we couldn't get a valid token.")]
                        failure(error: NSError(domain: OAuthSwiftErrorDomain, code: -1, userInfo: errorInfo))
                    }
                    return
                }

Thank you! I expect the release!

どういたしまして


:bug: Fixed HTTPS in jQuery path

I am honored to have received a pull request for the one, the only, @niftylettuce.

Love it @kyleconroy, but the honor is mine!


Support for two inverters with different IP-adress

I tried to find my question/solution in your documentation, the issues and the comments, but I found nothing.
How can I use your component  for two (or more) inverters in my local network, which are not connected by rs485?
Thank you in advance.

Add the integration multiple times.

Thank you for your fast response.
It works!!


Typescript 2.3.0 in npm while latest stable is 2.2.2

TypeScript Version:  2.3.0
During npm installation phase non-stable release (2.3.0) is installed.
How it's possible?
Expected behavior:
Npm site reports that's latest version is 2.2.2
Github version 2.2.2
During npm install it installs version 2.2.2
Actual behavior:
Npm site reports that's latest version is 2.2.2
According to github there is version 2.3.0-rc
During npm install it installs version 2.3.0 (with both ^2.0.0 or * in package.json)

#15125

Thanks for explanation.


On a Members page, filtering Activity by Platform removes the data

Problem

When a user filters activity by platform and there are no results, there is no data shown or empty state below the search bar.
There is also no way to remove the filter once it has been selected

Proposed solution

Add a "clearable" button to platform select component so that filter can be cleared and back to the initial state
If there are no results from the filter, show an empty state "This member has no activities in "platform name""

Can you please elaborate this issue?

Can you please elaborate this issue?

Hey!
This is happening in the Activities timeline on the Member profile page.
Just as mentioned in the description, the goal is to improve how we handle with the platform filter. The 2 major goals are:

If there are no results for the applied filter, show a message
If user wants to remove the applied filter, we should add a clearable button to the select component -> https://element-plus.org/en-US/component/select.html#clearable-single-select

If this doesn't help, could you be a bit more specific on the doubts you have?

Hi, can I look into this issue? If yes, please feel free to assign it to me. Thanks!

Hey, Can you please assisgn me this issue?

Hey @joanagmaia, I think I should be able to resolve this issue given some time. I have worked on Vue.js code bases before. Can you assign this issue to me ?

Hey!
I'm ok with anyone picking this up 😄 Once you do, assign yourself to the issue

picking this up


[FLINK-28548][Connectors / FileSystem] Fix the exception FileNotFoundException when the commit partition base path is not created

What is the purpose of the change
The commit partition base path is not created when no data is sent which may cause FileNotFoundException. Just fix it.
Brief change log

Check whether the base path exists before listStatus for the path.

Verifying this change
This change added tests and can be verified as follows:

Added test testPartitionPathNotExist in FileSystemCommitterTest

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (no)

@flinkbot run azure

@flinkbot  run azure

@flinkbot run azure


kcl Objects have a formatting problem

The following kcl
const bing = { yo: 55 }
const myNestedVar = [{ prop: callExp(bing.yo) }]

when formatting the code, recasts to
const bing = { yo: 55 }
const myNestedVar = [{ prop:   callExp(bing.yo) }]

Notice the extra white space before callExp (3 spaces instead of 1)
It must be related to the value being a call expression as const myNestedVar2 = [{ prop: 'callExp(bing.yo)' }] does not have the formatting problem

oh i can fix this

literally one second

Nice, I got another one for you if you're interested
const myNestedVar = [
  {
  prop:   line([bing.yo, 21], sketch001)
}
]

Look pretty bad too

these are the same bug

oh i see you mean the params ill try

Yeah I meant the } indentation

i improved it

its not like 100% perfect but it looks better someone else can eff w it more if they wwant to

Sounds good.


Add support to CellularConnectionProperties

Implement the Cellular Properties D-Bus demo service
Add support to the Modems D-Bus service to retrieve the data for io.edgehog.devicemanager.CellularConnectionProperties

Close #17

Superseded by https://github.com/edgehog-device-manager/edgehog-device-runtime/pull/402


fix(compose): downloaded binary should now be docker-compose [EE-3631]

Closes EE-3631

Closes https://github.com/portainer/portainer/issues/7142


Investigate: determine p95 scan time for the s3_scan_object module

Summary
Determine how long it takes 95% of objects to be tagged with a scan result by the s3_scan_object module.  This will help downstream users of the service set back-off retry timeouts.

@jimleroyer with the improvements to Scan Files stability, is this still something you're interested in?  We're trying to prioritize our backlog.

This CloudWatch log insights query will provide us the min, max, average and p95 scan time:
fields @timestamp, @message
| parse @message "Key: '*'" as key_value
| filter key_value like /tmp*/
| stats earliest(@timestamp) as start_time,
        latest(@timestamp) as end_time,
        (latest(@timestamp) - earliest(@timestamp)) / 1000 as duration_seconds
by key_value
| stats avg(duration_seconds) as avg_duration,
        min(duration_seconds) as min_duration,
        max(duration_seconds) as max_duration,
        pct(duration_seconds, 95) as p95

This works because it uses the scanned object's S3 key to group results.  This S3 key is logged multiple times during the scan operation, but the useful ones for us are:

When the S3 PutObject event initiates the scan process in the s3-scan-object module.
When the object is tagged with the scan result at the end of the process (again by the s3-scan-object module).

Running the query against our 2 weeks work of log data gives the following values:
avg_duration
2.33 seconds

max_duration
74.30 seconds

min_duration
0.67 seconds

p95
1.74 seconds


How can I set request timeout?

What is the default timeout for a given request and where can I configure that?

You might want to look at https://github.com/prisma-labs/graphql-request/#cancellation

Take a look at https://github.com/jasonkuhrt/graphql-request/issues/103

I would be also interested in a smooth way to set it by configuration.
The mentioned code in #103 seems more like a workaround.


feat: server address printed as QR Code upon server startup

closes #13 originally referenced in https://github.com/lwsjs/local-web-server/issues/148
Shortly:

--qr prints the QR Code of the first server address that matches a private network address-
--qr <iface> prints the QR Code of the network interface passed as arg

If no --qr param is passed the QR Code is not printed, which is the default behavior.
Tests and Coverage implemented

Good work, thanks. Happy with the changes?

Yeah.! I agree with all of them and specially the command line instructions are much cleaner now.
If you need any help, let me know.


Minor edits to the README and TRAINING files

Proposed edits for minor cleanups such as spelling, commas, docker version update, etc.

Thank you for the contribution!

The edit for the latest version of the PyTorch Docker image is incorrect as I later discovered the hard way (see issue #28), we may want to go back to 19.04 until the latest version is supported. My apologies for not preemptively rectifying this once I learned of the error...

https://github.com/NVIDIA/retinanet-examples/pull/25 was merged before yours and updated the image while fixing this issue.


Update bug_report.md

A bunch of pedantic, silly changes to the bug report template. Open to feedback.

Nothing really wrong with it - I'm just good at these little changes. It's like a game for me.


Element modifiers don't work with components

Hi!
I can't figure out a way to use element modifiers with components.
This works:
.my-div{did-insert (action (perform this.realoadData)}

This doesn't:
= my-component{did-insert (action (perform this.realoadData)}

Thanks!

+1

Found a very likely related issue: https://github.com/emberjs/ember-render-modifiers/issues/15


Re-add creative mode instant shell construction

Back in the original mod there was a check when you used a shell constructor which would instantly finish a shell if you were in creative mode. This lets you create a large amount of clones without waiting for them to slowly construct.

Are you sure? Don't remember this was a thing. Anyway, this is a good idea! Will be added as an opt-out feature
P.S. - at the moment you can use endermen to speed up the process *wink-wink*
https://github.com/Kir-Antipov/sync-fabric/blob/ae5f63210a131490432fc267fc50e6f2d98f6d8e/src/main/java/me/kirantipov/mods/sync/block/entity/TreadmillStateManager.java#L139-L148


ENH release v1.0.1

This PR is to release v1.0.1.

Let's hold off on merging this until we push civis-jupyter-notebook to pypi

LGTM


deployment to linux and handling of Pkl in distributed envirnonment

Dear Serengil,
What are your recommendation for alternative ways of Pkl file, as there will be inconsistencies if we use pkl file in ditributed environment?
Secondly , can please brief or share any link for the deployment of this in higher linux environment?
Many Thanks,

if distributed environments have same pandas version, then pkl files should not cause any problem, should it?
unfortunately, I don't have any experience about linux.

if distributed environments have same pandas version, then pkl files should not cause any problem, should it?
unfortunately, I don't have any experience about linux.
What I mean is :
Let say I am appending representation for new image in the existing pkl file. so In case new image appended in node 1 , will not have the same in node 2. so In case find function of node 2 ran ...... I will not be able to find the match . So either pickle file is stored at some remote location as common SFTP for both nodes or there can a DB which does this job so both node can be connected to the same DB.

that is hard to implement but we can add an argument to discard pkl files. You can set that argument to create pkl from scratch.

You might mount the folder among the distributed servers. In this way, they all read the same pkl file?

I am closing this issue because this is not going to handled in the framework side.


[ASCII-1340] Metadata schedule component

What does this PR do?
This PR creates the Metadata schedule component.
Describe how to test/QA your changes

Set log_level at true
Check the metadata payload contains agent_checks (You can search for Sending metadata payload, content in the log of the Agent)

/merge


GROOVY-11294: Make generated toList() and toMap() methods on records …

…return immutable collections

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (5aafcdf) 68.5240% compared to head (3cde7af) 68.5278%.

Additional details and impacted files

@@                Coverage Diff                 @@
##               master      #2047        +/-   ##
==================================================
+ Coverage     68.5240%   68.5278%   +0.0038%
- Complexity      29164      29167         +3
==================================================
  Files            1422       1422
  Lines          113493     113494         +1
  Branches        19545      19545
==================================================
+ Hits            77770      77775         +5
+ Misses          29181      29179         -2
+ Partials         6542       6540         -2

Files
Coverage Δ

.../groovy/transform/RecordTypeASTTransformation.java
86.0294% <100.0000%> (+0.0515%)
:arrow_up:

... and 1 file with indirect coverage changes

+1


Fresh build on OSX doesn't work

Describe the bug
mflaxman@Michaels-MacBook-Pro:~/workspace$ git clone https://github.com/unchained-capital/hermit
Cloning into 'hermit'...
remote: Enumerating objects: 388, done.
remote: Counting objects: 100% (388/388), done.
remote: Compressing objects: 100% (291/291), done.
remote: Total 388 (delta 155), reused 315 (delta 90), pack-reused 0
Receiving objects: 100% (388/388), 386.73 KiB | 2.97 MiB/s, done.
Resolving deltas: 100% (155/155), done.

mflaxman@Michaels-MacBook-Pro:~/workspace$ cd hermit

mflaxman@Michaels-MacBook-Pro:~/workspace/hermit$ make
brew ls --versions zbar || brew install zbar
zbar 0.10_9
/usr/local/bin/python3 -m venv --prompt='hermit' .virtualenv
.virtualenv/bin/pip install wheel
Collecting wheel
  Using cached https://files.pythonhosted.org/packages/00/83/b4a77d044e78ad1a45610eb88f745be2fd2c6d658f9798a15e384b7d57c9/wheel-0.33.6-py2.py3-none-any.whl
Installing collected packages: wheel
Successfully installed wheel-0.33.6
You are using pip version 19.0.3, however version 19.2.2 is available.
You should consider upgrading via the 'pip install --upgrade pip' command.
.virtualenv/bin/pip install -r requirements.frozen.txt
Collecting alabaster==0.7.12 (from -r requirements.frozen.txt (line 1))
  Using cached https://files.pythonhosted.org/packages/10/ad/00b090d23a222943eb0eda509720a404f531a439e803f6538f35136cae9e/alabaster-0.7.12-py2.py3-none-any.whl
Collecting asn1crypto==0.24.0 (from -r requirements.frozen.txt (line 2))
  Using cached https://files.pythonhosted.org/packages/ea/cd/35485615f45f30a510576f1a56d1e0a7ad7bd8ab5ed7cdc600ef7cd06222/asn1crypto-0.24.0-py2.py3-none-any.whl
Collecting atomicwrites==1.3.0 (from -r requirements.frozen.txt (line 3))
  Using cached https://files.pythonhosted.org/packages/52/90/6155aa926f43f2b2a22b01be7241be3bfd1ceaf7d0b3267213e8127d41f4/atomicwrites-1.3.0-py2.py3-none-any.whl
Collecting attrs==19.1.0 (from -r requirements.frozen.txt (line 4))
  Using cached https://files.pythonhosted.org/packages/23/96/d828354fa2dbdf216eaa7b7de0db692f12c234f7ef888cc14980ef40d1d2/attrs-19.1.0-py2.py3-none-any.whl
Collecting Babel==2.7.0 (from -r requirements.frozen.txt (line 5))
  Using cached https://files.pythonhosted.org/packages/2c/60/f2af68eb046c5de5b1fe6dd4743bf42c074f7141fe7b2737d3061533b093/Babel-2.7.0-py2.py3-none-any.whl
Collecting bleach==3.1.0 (from -r requirements.frozen.txt (line 6))
  Using cached https://files.pythonhosted.org/packages/ab/05/27e1466475e816d3001efb6e0a85a819be17411420494a1e602c36f8299d/bleach-3.1.0-py2.py3-none-any.whl
Collecting bson==0.5.8 (from -r requirements.frozen.txt (line 7))
Collecting certifi==2019.6.16 (from -r requirements.frozen.txt (line 8))
  Using cached https://files.pythonhosted.org/packages/69/1b/b853c7a9d4f6a6d00749e94eb6f3a041e342a885b87340b79c1ef73e3a78/certifi-2019.6.16-py2.py3-none-any.whl
Collecting cffi==1.12.3 (from -r requirements.frozen.txt (line 9))
  Using cached https://files.pythonhosted.org/packages/f0/48/5aa4ea664eba26dd5142558d04762f5065c02220b4665b3f7eecb9bb614e/cffi-1.12.3-cp37-cp37m-macosx_10_9_x86_64.whl
Collecting chardet==3.0.4 (from -r requirements.frozen.txt (line 10))
  Using cached https://files.pythonhosted.org/packages/bc/a9/01ffebfb562e4274b6487b4bb1ddec7ca55ec7510b22e4c51f14098443b8/chardet-3.0.4-py2.py3-none-any.whl
Collecting Click==7.0 (from -r requirements.frozen.txt (line 11))
  Using cached https://files.pythonhosted.org/packages/fa/37/45185cb5abbc30d7257104c434fe0b07e5a195a6847506c074527aa599ec/Click-7.0-py2.py3-none-any.whl
Collecting colorama==0.4.1 (from -r requirements.frozen.txt (line 12))
  Using cached https://files.pythonhosted.org/packages/4f/a6/728666f39bfff1719fc94c481890b2106837da9318031f71a8424b662e12/colorama-0.4.1-py2.py3-none-any.whl
Collecting coverage==4.5.4 (from -r requirements.frozen.txt (line 13))
  Using cached https://files.pythonhosted.org/packages/93/07/8302163cdbe2008441aa69f2119750110fde15ffd8a56a687311b143365a/coverage-4.5.4-cp37-cp37m-macosx_10_13_x86_64.whl
Collecting cryptography==2.7 (from -r requirements.frozen.txt (line 14))
  Using cached https://files.pythonhosted.org/packages/63/4e/57b7a6bd98906872fcd2531e74b532de2abe17d675a5cf171931fcb4a9e8/cryptography-2.7-cp34-abi3-macosx_10_6_intel.whl
Collecting docutils==0.15.2 (from -r requirements.frozen.txt (line 15))
  Using cached https://files.pythonhosted.org/packages/22/cd/a6aa959dca619918ccb55023b4cb151949c64d4d5d55b3f4ffd7eee0c6e8/docutils-0.15.2-py3-none-any.whl
Collecting ecdsa==0.13 (from -r requirements.frozen.txt (line 16))
  Using cached https://files.pythonhosted.org/packages/63/f4/73669d51825516ce8c43b816c0a6b64cd6eb71d08b99820c00792cb42222/ecdsa-0.13-py2.py3-none-any.whl
Collecting entrypoints==0.3 (from -r requirements.frozen.txt (line 17))
  Using cached https://files.pythonhosted.org/packages/ac/c6/44694103f8c221443ee6b0041f69e2740d89a25641e62fb4f2ee568f2f9c/entrypoints-0.3-py2.py3-none-any.whl
Collecting flake8==3.7.7 (from -r requirements.frozen.txt (line 18))
  Using cached https://files.pythonhosted.org/packages/e9/76/b915bd28976068a9843bf836b789794aa4a8eb13338b23581005cd9177c0/flake8-3.7.7-py2.py3-none-any.whl
Collecting idna==2.8 (from -r requirements.frozen.txt (line 19))
  Using cached https://files.pythonhosted.org/packages/14/2c/cd551d81dbe15200be1cf41cd03869a46fe7226e7450af7a6545bfc474c9/idna-2.8-py2.py3-none-any.whl
Collecting imagesize==1.1.0 (from -r requirements.frozen.txt (line 20))
  Using cached https://files.pythonhosted.org/packages/fc/b6/aef66b4c52a6ad6ac18cf6ebc5731ed06d8c9ae4d3b2d9951f261150be67/imagesize-1.1.0-py2.py3-none-any.whl
Collecting importlib-metadata==0.19 (from -r requirements.frozen.txt (line 21))
  Using cached https://files.pythonhosted.org/packages/ad/aa/25fcbded2ab4ed4ff3071d1e000cd4f8f9c65653d2d7157dd105a8e81d42/importlib_metadata-0.19-py2.py3-none-any.whl
Collecting imutils==0.5.1 (from -r requirements.frozen.txt (line 22))
Collecting Jinja2==2.10.1 (from -r requirements.frozen.txt (line 23))
  Using cached https://files.pythonhosted.org/packages/1d/e7/fd8b501e7a6dfe492a433deb7b9d833d39ca74916fa8bc63dd1a4947a671/Jinja2-2.10.1-py2.py3-none-any.whl
Collecting MarkupSafe==1.1.1 (from -r requirements.frozen.txt (line 24))
  Using cached https://files.pythonhosted.org/packages/ce/c6/f000f1af136ef74e4a95e33785921c73595c5390403f102e9b231b065b7a/MarkupSafe-1.1.1-cp37-cp37m-macosx_10_6_intel.whl
Collecting mccabe==0.6.1 (from -r requirements.frozen.txt (line 25))
  Using cached https://files.pythonhosted.org/packages/87/89/479dc97e18549e21354893e4ee4ef36db1d237534982482c3681ee6e7b57/mccabe-0.6.1-py2.py3-none-any.whl
Collecting mnemonic==0.18 (from -r requirements.frozen.txt (line 26))
Collecting more-itertools==7.2.0 (from -r requirements.frozen.txt (line 27))
  Using cached https://files.pythonhosted.org/packages/45/dc/3241eef99eb45f1def35cf93af35d1cf9ef4c0991792583b8f33ea41b092/more_itertools-7.2.0-py3-none-any.whl
Collecting mypy==0.701 (from -r requirements.frozen.txt (line 28))
  Using cached https://files.pythonhosted.org/packages/aa/f3/74577ff2b4f29c4b8112b7dc22746ce41c88c36a3e1829641a1b1ec09e3b/mypy-0.701-cp37-cp37m-macosx_10_6_x86_64.macosx_10_9_intel.macosx_10_9_x86_64.macosx_10_10_intel.macosx_10_10_x86_64.whl
Collecting mypy-extensions==0.4.1 (from -r requirements.frozen.txt (line 29))
  Using cached https://files.pythonhosted.org/packages/4d/72/8d54e2b296631b9b14961d583e56e90d9d7fba8a240d5ce7f1113cc5e887/mypy_extensions-0.4.1-py2.py3-none-any.whl
Collecting numpy==1.17.0 (from -r requirements.frozen.txt (line 30))
  Using cached https://files.pythonhosted.org/packages/c1/4b/78119133136c20e5ad2e01bf72b0633241defd619939908223cd394a9c32/numpy-1.17.0-cp37-cp37m-macosx_10_6_intel.macosx_10_9_intel.macosx_10_9_x86_64.macosx_10_10_intel.macosx_10_10_x86_64.whl
Collecting opencv-python==<IP_ADDRESS> (from -r requirements.frozen.txt (line 31))
  Using cached https://files.pythonhosted.org/packages/e2/96/e7a196456fa75c75a7759c98fa6ba5bdacebdd66fbf4fd31e10b80f9d32e/opencv_python-<IP_ADDRESS>-cp37-cp37m-macosx_10_6_x86_64.macosx_10_9_intel.macosx_10_9_x86_64.macosx_10_10_intel.macosx_10_10_x86_64.whl
Collecting packaging==19.1 (from -r requirements.frozen.txt (line 32))
  Using cached https://files.pythonhosted.org/packages/ec/22/630ac83e8f8a9566c4f88038447ed9e16e6f10582767a01f31c769d9a71e/packaging-19.1-py2.py3-none-any.whl
Collecting pbkdf2==1.3 (from -r requirements.frozen.txt (line 33))
Collecting Pillow==6.1.0 (from -r requirements.frozen.txt (line 34))
  Using cached https://files.pythonhosted.org/packages/8f/f3/c6d351d7e582e4f2ef4343c9be1f0472cb249fb69695e68631e337f4b6e9/Pillow-6.1.0-cp37-cp37m-macosx_10_6_intel.macosx_10_9_intel.macosx_10_9_x86_64.macosx_10_10_intel.macosx_10_10_x86_64.whl
Collecting pkginfo==<IP_ADDRESS> (from -r requirements.frozen.txt (line 35))
  Using cached https://files.pythonhosted.org/packages/e6/d5/451b913307b478c49eb29084916639dc53a88489b993530fed0a66bab8b9/pkginfo-<IP_ADDRESS>-py2.py3-none-any.whl
Collecting pluggy==0.12.0 (from -r requirements.frozen.txt (line 36))
  Using cached https://files.pythonhosted.org/packages/06/ee/de89e0582276e3551df3110088bf20844de2b0e7df2748406876cc78e021/pluggy-0.12.0-py2.py3-none-any.whl
Collecting prompt-toolkit==2.0.7 (from -r requirements.frozen.txt (line 37))
  Using cached https://files.pythonhosted.org/packages/d1/e6/adb3be5576f5d27c6faa33f1e9fea8fe5dbd9351db12148de948507e352c/prompt_toolkit-2.0.7-py3-none-any.whl
Collecting py==1.8.0 (from -r requirements.frozen.txt (line 38))
  Using cached https://files.pythonhosted.org/packages/76/bc/394ad449851729244a97857ee14d7cba61ddb268dce3db538ba2f2ba1f0f/py-1.8.0-py2.py3-none-any.whl
Collecting pyAesCrypt==0.4.2 (from -r requirements.frozen.txt (line 39))
  Using cached https://files.pythonhosted.org/packages/65/f4/eacfcc319fda64428cd985d6ccb2a7f130feeca3c2fcc1dd8822b3b7b414/pyAesCrypt-0.4.2-py3-none-any.whl
Collecting pycodestyle==2.5.0 (from -r requirements.frozen.txt (line 40))
  Using cached https://files.pythonhosted.org/packages/0e/0c/04a353e104d2f324f8ee5f4b32012618c1c86dd79e52a433b64fceed511b/pycodestyle-2.5.0-py2.py3-none-any.whl
Collecting pycparser==2.19 (from -r requirements.frozen.txt (line 41))
Collecting pyflakes==2.1.1 (from -r requirements.frozen.txt (line 42))
  Using cached https://files.pythonhosted.org/packages/84/f2/ed0ffb887f8138a8fe5a621b8c0bb9598bfb3989e029f6c6a85ee66628ee/pyflakes-2.1.1-py2.py3-none-any.whl
Collecting Pygments==2.4.2 (from -r requirements.frozen.txt (line 43))
  Using cached https://files.pythonhosted.org/packages/5c/73/1dfa428150e3ccb0fa3e68db406e5be48698f2a979ccbcec795f28f44048/Pygments-2.4.2-py2.py3-none-any.whl
Collecting pyparsing==2.4.2 (from -r requirements.frozen.txt (line 44))
  Using cached https://files.pythonhosted.org/packages/11/fa/0160cd525c62d7abd076a070ff02b2b94de589f1a9789774f17d7c54058e/pyparsing-2.4.2-py2.py3-none-any.whl
Collecting pysha3==1.0.2 (from -r requirements.frozen.txt (line 45))
Collecting pytest==4.4.0 (from -r requirements.frozen.txt (line 46))
  Using cached https://files.pythonhosted.org/packages/7e/16/83b2a35c427b838df9836c9e7e4ae6dfbcbdea643db44652f693b1c57d70/pytest-4.4.0-py2.py3-none-any.whl
Collecting pytest-cov==2.6.1 (from -r requirements.frozen.txt (line 47))
  Using cached https://files.pythonhosted.org/packages/7d/b5/92f32674ab954f80499ac73347bfeb815545ea295439c12b0ef3ac8f0975/pytest_cov-2.6.1-py2.py3-none-any.whl
Collecting python-bitcoinlib==0.10.1 (from -r requirements.frozen.txt (line 48))
  Using cached https://files.pythonhosted.org/packages/30/03/fb7df95fe89baede202cf3fe65e65bea4bf863061b5e8f59b12dab538240/python_bitcoinlib-0.10.1-py2.py3-none-any.whl
Collecting python-dateutil==2.8.0 (from -r requirements.frozen.txt (line 49))
  Using cached https://files.pythonhosted.org/packages/41/17/c62faccbfbd163c7f57f3844689e3a78bae1f403648a6afb1d0866d87fbb/python_dateutil-2.8.0-py2.py3-none-any.whl
Collecting pytz==2019.2 (from -r requirements.frozen.txt (line 50))
  Using cached https://files.pythonhosted.org/packages/87/76/46d697698a143e05f77bec5a526bf4e56a0be61d63425b68f4ba553b51f2/pytz-2019.2-py2.py3-none-any.whl
Collecting PyYAML==5.1.1 (from -r requirements.frozen.txt (line 51))
Collecting pyzbar==0.1.7 (from -r requirements.frozen.txt (line 52))
  Using cached https://files.pythonhosted.org/packages/bd/e7/dc9aa3ee5ddc71df6ea1698f7e9d12dcc874346ad3051524155e121006a6/pyzbar-0.1.7-py2.py3-none-any.whl
Collecting qrcode==6.0 (from -r requirements.frozen.txt (line 53))
  Using cached https://files.pythonhosted.org/packages/79/be/11999004f7e6e5db0fa410c2feacd67c07f472f4500fde0026101f31d0df/qrcode-6.0-py2.py3-none-any.whl
Collecting readme-renderer==24.0 (from -r requirements.frozen.txt (line 54))
  Using cached https://files.pythonhosted.org/packages/c3/7e/d1aae793900f36b097cbfcc5e70eef82b5b56423a6c52a36dce51fedd8f0/readme_renderer-24.0-py2.py3-none-any.whl
Collecting requests==2.22.0 (from -r requirements.frozen.txt (line 55))
  Using cached https://files.pythonhosted.org/packages/51/bd/23c926cd341ea6b7dd0b2a00aba99ae0f828be89d72b2190f27c11d4b7fb/requests-2.22.0-py2.py3-none-any.whl
Collecting requests-toolbelt==0.9.1 (from -r requirements.frozen.txt (line 56))
  Using cached https://files.pythonhosted.org/packages/60/ef/7681134338fc097acef8d9b2f8abe0458e4d87559c689a8c306d0957ece5/requests_toolbelt-0.9.1-py2.py3-none-any.whl
Collecting shamir-mnemonic==0.1.0 (from -r requirements.frozen.txt (line 57))
  Using cached https://files.pythonhosted.org/packages/da/7b/be61fae6dc3685197e3de75d78bcab7b40caac3235a235b2f8170cfc1cd2/shamir_mnemonic-0.1.0-py3-none-any.whl
Collecting six==1.12.0 (from -r requirements.frozen.txt (line 58))
  Using cached https://files.pythonhosted.org/packages/73/fb/00a976f728d0d1fecfe898238ce23f502a721c0ac0ecfedb80e0d88c64e9/six-1.12.0-py2.py3-none-any.whl
Collecting snowballstemmer==1.9.0 (from -r requirements.frozen.txt (line 59))
Collecting Sphinx==1.8.5 (from -r requirements.frozen.txt (line 60))
  Using cached https://files.pythonhosted.org/packages/7d/66/a4af242b4348b729b9d46ce5db23943ce9bca7da9bbe2ece60dc27f26420/Sphinx-1.8.5-py2.py3-none-any.whl
Collecting sphinxcontrib-websupport==1.1.2 (from -r requirements.frozen.txt (line 61))
  Using cached https://files.pythonhosted.org/packages/2a/59/d64bda9b7480a84a3569be4dde267c0f6675b255ba63b4c8e84469940457/sphinxcontrib_websupport-1.1.2-py2.py3-none-any.whl
Collecting tqdm==4.32.2 (from -r requirements.frozen.txt (line 62))
  Using cached https://files.pythonhosted.org/packages/9f/3d/7a6b68b631d2ab54975f3a4863f3c4e9b26445353264ef01f465dc9b0208/tqdm-4.32.2-py2.py3-none-any.whl
Collecting twine==1.13.0 (from -r requirements.frozen.txt (line 63))
  Using cached https://files.pythonhosted.org/packages/28/90/59eec88c0b2ac9e47fe135959007acb93a3cc9f7146366e11fecf718dd15/twine-1.13.0-py2.py3-none-any.whl
Collecting typed-ast==1.3.5 (from -r requirements.frozen.txt (line 64))
  Using cached https://files.pythonhosted.org/packages/a4/7b/3d18d46c64c7052c5ad9b4301562cc46383c20dcbe69409b75cfd7096451/typed_ast-1.3.5-cp37-cp37m-macosx_10_9_x86_64.whl
Collecting urllib3==1.25.3 (from -r requirements.frozen.txt (line 65))
  Using cached https://files.pythonhosted.org/packages/e6/60/247f23a7121ae632d62811ba7f273d0e58972d75e58a94d329d51550a47d/urllib3-1.25.3-py2.py3-none-any.whl
Collecting wcwidth==0.1.7 (from -r requirements.frozen.txt (line 66))
  Using cached https://files.pythonhosted.org/packages/7e/9f/526a6947247599b084ee5232e4f9190a38f398d7300d866af3ab571a5bfe/wcwidth-0.1.7-py2.py3-none-any.whl
Collecting webencodings==0.5.1 (from -r requirements.frozen.txt (line 67))
  Using cached https://files.pythonhosted.org/packages/f4/24/2a3e3df732393fed8b3ebf2ec078f05546de641fe1b667ee316ec1dcf3b7/webencodings-0.5.1-py2.py3-none-any.whl
Collecting zipp==0.5.2 (from -r requirements.frozen.txt (line 68))
  Using cached https://files.pythonhosted.org/packages/da/bd/1a5fdf15aa44231fd09f63ecf175b60f057ae37ec65b343bb009364923f3/zipp-0.5.2-py2.py3-none-any.whl
Requirement already satisfied: setuptools in ./.virtualenv/lib/python3.7/site-packages (from pytest==4.4.0->-r requirements.frozen.txt (line 46)) (40.8.0)
Installing collected packages: alabaster, asn1crypto, atomicwrites, attrs, pytz, Babel, six, webencodings, bleach, python-dateutil, bson, certifi, pycparser, cffi, chardet, Click, colorama, coverage, cryptography, docutils, ecdsa, entrypoints, pyflakes, pycodestyle, mccabe, flake8, idna, imagesize, zipp, importlib-metadata, imutils, MarkupSafe, Jinja2, pbkdf2, mnemonic, more-itertools, mypy-extensions, typed-ast, mypy, numpy, opencv-python, pyparsing, packaging, Pillow, pkginfo, pluggy, wcwidth, prompt-toolkit, py, pyAesCrypt, Pygments, pysha3, pytest, pytest-cov, python-bitcoinlib, PyYAML, pyzbar, qrcode, readme-renderer, urllib3, requests, requests-toolbelt, shamir-mnemonic, snowballstemmer, sphinxcontrib-websupport, Sphinx, tqdm, twine
Successfully installed Babel-2.7.0 Click-7.0 Jinja2-2.10.1 MarkupSafe-1.1.1 Pillow-6.1.0 PyYAML-5.1.1 Pygments-2.4.2 Sphinx-1.8.5 alabaster-0.7.12 asn1crypto-0.24.0 atomicwrites-1.3.0 attrs-19.1.0 bleach-3.1.0 bson-0.5.8 certifi-2019.6.16 cffi-1.12.3 chardet-3.0.4 colorama-0.4.1 coverage-4.5.4 cryptography-2.7 docutils-0.15.2 ecdsa-0.13 entrypoints-0.3 flake8-3.7.7 idna-2.8 imagesize-1.1.0 importlib-metadata-0.19 imutils-0.5.1 mccabe-0.6.1 mnemonic-0.18 more-itertools-7.2.0 mypy-0.701 mypy-extensions-0.4.1 numpy-1.17.0 opencv-python-<IP_ADDRESS> packaging-19.1 pbkdf2-1.3 pkginfo-<IP_ADDRESS> pluggy-0.12.0 prompt-toolkit-2.0.7 py-1.8.0 pyAesCrypt-0.4.2 pycodestyle-2.5.0 pycparser-2.19 pyflakes-2.1.1 pyparsing-2.4.2 pysha3-1.0.2 pytest-4.4.0 pytest-cov-2.6.1 python-bitcoinlib-0.10.1 python-dateutil-2.8.0 pytz-2019.2 pyzbar-0.1.7 qrcode-6.0 readme-renderer-24.0 requests-2.22.0 requests-toolbelt-0.9.1 shamir-mnemonic-0.1.0 six-1.12.0 snowballstemmer-1.9.0 sphinxcontrib-websupport-1.1.2 tqdm-4.32.2 twine-1.13.0 typed-ast-1.3.5 urllib3-1.25.3 wcwidth-0.1.7 webencodings-0.5.1 zipp-0.5.2
You are using pip version 19.0.3, however version 19.2.2 is available.
You should consider upgrading via the 'pip install --upgrade pip' command.

mflaxman@Michaels-MacBook-Pro:~/workspace/hermit$ source environment.sh
basename: illegal option -- b
usage: basename string [suffix]
       basename [-a] [-s suffix] string [...]
[virtualenv] Entering Python virtualenv at /Users/mflaxman/workspace/hermit/.virtualenv
[pythonpath] /Users/mflaxman/workspace/hermit already on PYTHONPATH (:/Users/mflaxman/workspace/hermit)
[path]       Adding /Users/mflaxman/workspace/hermit/bin to PATH (/Users/mflaxman/workspace/hermit/.virtualenv/bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/opt/X11/bin:/Users/mflaxman/gocode/bin)

(hermit) mflaxman@Michaels-MacBook-Pro:~/workspace/hermit$ hermit
Traceback (most recent call last):
  File "/Users/mflaxman/workspace/hermit/bin/hermit", line 4, in <module>
    from hermit.ui import main
  File "/Users/mflaxman/workspace/hermit/hermit/__init__.py", line 3, in <module>
    from .wallet       import *
  File "/Users/mflaxman/workspace/hermit/hermit/wallet.py", line 5, in <module>
    from pybitcointools import (bip32_ckd,
ModuleNotFoundError: No module named 'pybitcointools'

What is your environment?

Operation system & version: [Mac OS 10.14.5]
Python & pip versions: [Python 3.7.4, pip 19.0.3]
Terminal emulator: [Terminal.app]

I believe this is due to pybitcointools being vendored in as a git submodule.  If you run git submodule update --init that should work.  I have updated the readme to use git clone --recursive and updated the environment.sh script to print a helpful error message if it sees no submodule.
Can you please give it another try and let us know if it works for you?  Thanks!


Add support for a custom number of shards for the map

This adds a new constructor to the ConcurrentMap that allows the user to pass in the number of shards we should shard the map to

I have same idea with you that shard number matters.

if you change the shard count dont you have to change the hash function params too? https://en.wikipedia.org/wiki/Fowler–Noll–Vo_hash_function#FNV_hash_parameters

@benitogf No, not unless you create a huge number of shards. The FNV32 hash function just creates a 32 bit hash, which is a number between 0 and 4.29 billion. The code mods this hash by the number of shards, so if you used 100 or 200 shards you would still likely get good dispersion of the keys between the shards. Of course, if you want 4 billion shards (not recommended) then yes you should probably use a different hashing function like FNV128 etc.


Process annotations on constructor parameters

From digging into the code, and my own usage of this library, as far as I can tell, constructor parameters aren't inspected for annotations when generating the schema. This sucks, because when I'm creating request objects with Jackson, I put annotations on the constructor parameters, NOT the fields. But only the fields are inspected by the code. This means if I have a different property name in my Jackson annotation compared to the actual field name, the generated schema will use the internal field name, and not the value Jackson will look for when deserializing.
It'd be great if constructor parameters could also be considered when generating the schema. :)

Could you provide an example of how you define the models with annotations on constructor parameters? I'm not sure i completely understand correctly.
Thank you :D

Sure, here's an example from code I'm actually working on:
@Schema(description = "The username (or email address) and password to login with.")

@JsonDeserialize
@JsonIgnoreProperties(ignoreUnknown = true)
data class LoginRequest(
    @Schema(
        description = "The username or email address of the SWAT account you wish to log in to.",
        example = "Test User"
    )

    @field:NotBlank
    @field:Size(max = 100)
    @JsonProperty("username", required = true)
    val username: String?,

    @Schema(
        description = "The password for the SWAT account you wish to log in to.",
        example = "password123"
    )

    @field:NotBlank
    @field:Size(max = 100)
    @JsonProperty("password", required = true)
    val password: String?
)

It's basically used for request objects; I put @JsonProperty annotations on the properties with specific names, so if I decide to refactor the property name internally, the JSON annotation still has the same property name, and I don't accidentally break my API by renaming. But as far as I can tell, these annotations aren't picked up by the schema-kenerator-jackson library, because the schema-kenerator-reflection library doesn't pick up the annotations that are targeting constructor params.
Specifically, I'm talking about this stuff: https://kotlinlang.org/docs/annotations.html#annotation-use-site-targets
I want the annotations that target @param: to be included. :) (Targeting @param: is the default for annotations on properties in the constructor, as far as I know)

Thanks.
annotations on constructor parameters will now be included with the next version.
See testcase: https://github.com/SMILEY4/schema-kenerator/blob/c127bb7cd50dbe9314da17128f8bf7ca4a04f1d1/schema-kenerator-test/src/test/kotlin/io/github/smiley4/schemakenerator/test/MiscTests.kt#L200


Link coverage page from Records page

Coverage page (needs link in first paragraph removing): https://test3.freebmd.org.uk/cms/draft-coverage/draft-freebmd-progress

I don't think I have access to this - is it a Refinery page? It certainly doesn't show up in my local test environment.

@richardofsussex
The /cms/ part of the address implies a Refinery page.
BTW we have a protocol for updating Refinery pages that is designed to help ensure that updates are properly sequential and that they are made on the most up-to-date version of a page, etc. @DeniseColbert could you point Richard to the Google doc please — many thanks.

@DeniseColbert
Looking a bit closer —
As the page concerned is a  DRAFT, and it is the child of a DRAFT, then I doubt that our protocol covers the situation explicitly. However, looking at the pages concerned, they are both a long way from being ready for publication and I do not think that published versions of the pages exist. So … ?

Sounds as though it should head to the documentation team, rather than to me.

Yes, Alison might think that you want access to Refinery to make changes to the pages but I think you just need to see the page that's there. I thought anyone could see draft pages? Plus, you seem to be a Refinery user on Test 3 so I'm mightily confused as to why you can't see it!

Maybe it's your test environment causing the issue- can you try on a browser?

I can see the page fine: I thought the issue was to remove a link that it contains.

Ah right, sorry for my misunderstanding. It's a placeholder link, and we're a way off having this ready yet. I think you were going to look at getting the coverage charts from FreeBMD1 over to FreeBMD2? My apologies for not noting that in the comments, if so.

Yes, that's a separate issue (#517). As I say there, I think we need to agree the design and content of these pages before trying to produce them.

To investigate what information can be showed on the Records main page

@richardofsussex @nurifreembd How about including a question in user testing on whether users need coverage charts on FreeBMD?

Yes you can to get their feedback
On Wednesday, December 11, 2024, KristinaGadzhieva @.***>
wrote:

@richardofsussex https://github.com/richardofsussex @nurifreembd
https://github.com/nurifreembd How about including a question in user
testing on whether users need coverage charts on FreeBMD?
—
Reply to this email directly, view it on GitHub
https://github.com/FreeUKGen/FreeBMD2/issues/527#issuecomment-2536955006,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BDP72B6F6RZC5NKQBJPB2YD2FCILLAVCNFSM6AAAAABSQ2LWEWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMZWHE2TKMBQGY
.
You are receiving this because you were mentioned.Message ID:
@.***>


First version of a cookie implementation wrapping the cookie crate

Hey Luca,
here is my promised (in Discord) PR for Cookies. I've decided to simply wrap the cookie crate's CookieJar, at the cost of a dependency. I imagine that we can eventually shave off some of the allocations, but I was mostly focused on getting the interface right for now.
The way it works now is:
//in the blueprint
blueprint.wrap(f!(cookie::cookies_middleware));
Cookies::register(&mut blueprint);
// and then in the handler
fn handler(cookies: &Cookies) -> StatusCode {
   cookies.add(("foo","bar").into());
   cookies.remove("baz".into());
   StatusCode::OK
}

Which, for a Rust framework, feels rather magical I must say.
I was not sure if there should be more/better error-handling. I don't think it correct to fail a request on failing to extract cookies from headers, so for now these are just silently skipped. Ideally this is a configurable setting -  I imagine there are more educated opinions than mine on this subject and I am all ears.
Similarily for default-values: I could imagine applications where it would be convenient to just have every cookie live very long by default, or have some flag set by default, which should not be too hard to implement as a configurable thing either.
If you think this makes sense as a general direction I would add support for SignedCookies and PrivateCookies (again just wrapping the cookie crate for now) next, and perhaps create a CookieKit so we can just say CookieKit::signed(key).register(&mut blueprint); and have trusted (or secret) cookies up and running in one line.

Closing in favor of #234


Weird reporting in job & slots, one-line fix, Addresses #17

This is my working version but it definitely breaks some tests.
@rlyon you may want to check this fix with your systems and see if the reporting is right

Could you send me an Xml dump of the output that you are seeing the issue with?  I've not seen that behavior and I'm testing for some of those cases.

Actually, the output_05.xml file covers this issue, as the result should have been
NODE               OS      CPU GPU MEMTOT   MEMUSE   JOBS SLOT LOAD    STATE
--------------------------------------------------------------------------------
node100            linux   32      137.6G   82.0G    3    32   41.81  |  OD E

instead of
NODE               OS      CPU GPU MEMTOT   MEMUSE   JOBS SLOT LOAD    STATE
--------------------------------------------------------------------------------
node100            linux   32      137.6G   82.0G    1    1    41.81  |  OD E```

I guess I should have asked this sooner, but what flavor of pbs are you using?

Version: <IP_ADDRESS>

I read version in my mind :) We are using Moab/torque.
On Thursday, January 8, 2015, Rob Lyon<EMAIL_ADDRESS>wrote:

I guess I should have asked this sooner, but what flavor of pbs are you
using?
—
Reply to this email directly or view it on GitHub
https://github.com/rlyon/qhost/pull/18#issuecomment-69267628.

Ah, newer version than what I've been running.  It must not have the trailing space after the commas in the xml output.  I think that the cleaner/clearer way to solve that one would be to modify the the job handler:
def handle_node_jobs(self, node):
    data = self.getText(node.childNodes).split(',')
    return map(lambda x: x.lstrip(), data)

This way the handler function itself will always return the same job id format regardless of what is coming in.  It also has the added benefit of saving a few cycles because the job id's are being stripped as the new array is being built.
Let me know what you think
Rob

Oops, I'm not yelling really.  I'm not sure what happened there

That is cleaner I will make that change
On Thursday, January 8, 2015, Rob Lyon<EMAIL_ADDRESS>wrote:

Ah, newer version than what I've been running. It must not have the
trailing space after the commas in the xml output. I think that the
cleaner/clearer way to solve that one would be to modify the the job
handler:
def handle_node_jobs(self, node):
data = self.getText(node.childNodes).split(',')
return map(lambda x: x.lstrip(), data)
This way the handler function itself will always return the same job id
format regardless of what is coming in. It also has the added benefit of
saving a few cycles because the job id's are being stripped as the new
array is being built.
Let me know what you think
Rob
—
Reply to this email directly or view it on GitHub
https://github.com/rlyon/qhost/pull/18#issuecomment-69282420.

Don't know why I didn't see the split there, thanks for pointing it out + the cleaner application.
One last thing the 'run.py' is reporting errors, what do you reccommend?

Great!  Merging it now.


Migration: Subnavigation documentation

Document the ng-bootstrap subnavigation component (https://design-system.post.ch/#/post-samples/subnavigation) in storybook.
Since this is an Angular component, it can't be displayed in storybook. Use the Intranet Header documentation as a reference https://next.design-system.post.ch/?path=/docs/components-intranet-header-getting-started--docs for how to document with code only and link to the Demo App archive for a live demo.
### Tasks
- [ ] https://github.com/swisspost/design-system/issues/2469
- [x] Migrate subnavigation documentation

Add Content to the new docs page:

[ ] Name
[ ] Link to ng-bootstrap docs
[ ] Link to archived demo docs
[ ] Installation guide (css imports)
[ ] Post specific informations/examples

This is a normal HTML, CSS component.


It is easy to bring generator into bad state by providing bad seed

When using Prando in tests as a source of reproducible randomness, it is tempting to initialize it with some simple seeds such as '', '42' or '43'.
I'm noticing a number of problems when doing so.
First, when the seed is empty string, Prando seems to get into some stuck state and keeps returning the same number (0.5000000001164153) again and again.
Repro:
it('not eq', () => {
  const p = new Prando('');
  expect(p.next()).not.toEqual(p.next());
});

Second, when using two different seed strings '42', and '43', one could expect the two generated sequences to be completely different (avalanche effect), however they look quite similar (at least first produced number).
I understand that Prando is not designed to provide cryptographical level of randomness, but I expected it to provide at least "random enough" numbers to do basic statistics.
I guess what I expected could be done by calling some cryptographic hash function on the seed before passing it into Prando, buy I'm curious why Prando would not do this internally already.

Hey @burdakovd,
(Sorry, for some reason I missed this issue report before, and only saw it now)
Thanks for your report.

You're right, empty strings are producing an invalid internal seed (0). The same was true of a passed seed of value 0; they cannot be shifted so the generator gets stuck. Seed generation is a bit safer now, recovering from cases like that (simply setting the seed to 1).
I actually agree with you on the string seed issue. Strings with a very close alphanumeric similarity like "41" and "42" would produce a close hash, because it was just a char code count. I didn't want to employ any big third-party hashing algorithm because I wanted to make the library small, but it's clear the current solution was not enough in practice. I've added a change that now passes the string-based hash through the internal xorshifter function, therefore making the string hash result more random-looking. This is a breaking change since the same string seeds now produce different internal seeds.

Both changes are now part of the 4.0.0 release, a major bump due to the breaking changes.
Thanks again!


Fix geojson-extension document rendering

Fixes an issue where geojson documents don’t render tiles until the pane has been resized

👍


Rename examples

Rename scripts from the not obsolete form of exemple to example.
Alternatively the example scripts could be renamed to general components which could directly be used. ExempleSower would then be renamed to SplineSower in line with the SplineExtrusion script (example). This way it wouldn't be weird to use "example" components on your objects.

Exemple have to be renamed, yes.
As stated in code comment, examples are not intended to be used as-is and a SplineMesh user is asked to write his own scripts. SplineMesh use cases are numerous and efficient components would come with big complexity.
SplineExtrusion is different as it is not an example to expand. It can be used to prototype things quickly in your level design and its code is quite complex.

While for efficient scripts or for specific use cases the user will need to create his own scripts I woulnd't see why not to use something as the ExempleSower. I can see a lot of cases for which you wouldn't need to modify it.


Conversion to yml

Is conversion from swagger_3 to yml supported?

If I remember correctly, it gives the results back in the style it was received. Then I used a tool like JS-Yaml to convert from json to yaml if that's what I had to do.


Strange error 'cannot find package.json'

[x] I have read the contribution documentation for this project.
[x] I agree to follow the code of conduct that this project follows, as appropriate.
[x] I have searched the issue tracker for an issue that matches the one I want to file, without success.

Please describe your issue:
Using electron-forge with the native dep level on node 8.9.4
The same repository works for my colleague on linux. I'm on Mac OSX

Console output when you run electron-forge with the environment variable DEBUG=electron-forge:*. (Instructions on how to do so here). Please include the stack trace if one exists.
$ DEBUG=electron-forge:* npm start

><EMAIL_ADDRESS>start /Users/karissa/node_modules/mapfilter-desktop
> electron-forge start

WARNING: DEBUG environment variable detected.  Progress indicators will be sent over electron-forge:lifecycle
  electron-forge:lifecycle Process Started: Checking your system +0ms
  electron-forge:lifecycle Process Succeeded: Checking your system +284ms
  electron-forge:runtime-config setting key: verbose to value: false +0ms
WARNING: DEBUG environment variable detected.  Progress indicators will be sent over electron-forge:lifecycle
  electron-forge:lifecycle Process Started: Locating Application +0ms
  electron-forge:project-resolver searching for project in: /Users/karissa/node_modules/mapfilter-desktop +0ms
  electron-forge:project-resolver electron-forge compatible package.json found in /Users/karissa/node_modules/mapfilter-desktop/package.json +5ms
  electron-forge:lifecycle Process Succeeded: Locating Application +6ms
  electron-forge:lifecycle Process Started: Preparing native dependencies +5ms
  electron-forge:lifecycle Process Succeeded: Preparing native dependencies +442ms
  electron-forge:hook could not find hook: generateAssets +0ms
  electron-forge:lifecycle Process Started: Launching Application +2ms
  electron-forge:lifecycle Process Succeeded: Launching Application +4ms
App threw an error during load
Error: Can't find package.json
    at findPackageJson (/Users/karissa/node_modules/mapfilter-desktop/node_modules/electron-prebuilt-compile/lib/es6-init.js:19:11)
    at findPackageJson (/Users/karissa/node_modules/mapfilter-desktop/node_modules/electron-prebuilt-compile/lib/es6-init.js:29:10)
    at findPackageJson (/Users/karissa/node_modules/mapfilter-desktop/node_modules/electron-prebuilt-compile/lib/es6-init.js:29:10)
    at findPackageJson (/Users/karissa/node_modules/mapfilter-desktop/node_modules/electron-prebuilt-compile/lib/es6-init.js:29:10)
    at findPackageJson (/Users/karissa/node_modules/mapfilter-desktop/node_modules/electron-prebuilt-compile/lib/es6-init.js:29:10)
    at main (/Users/karissa/node_modules/mapfilter-desktop/node_modules/electron-prebuilt-compile/lib/es6-init.js:44:23)
    at Object.<anonymous> (/Users/karissa/node_modules/mapfilter-desktop/node_modules/electron-prebuilt-compile/lib/es6-init.js:59:1)
    at Object.<anonymous> (/Users/karissa/node_modules/mapfilter-desktop/node_modules/electron-prebuilt-compile/lib/es6-init.js:61:3)
    at Module._compile (module.js:569:30)
    at Object.Module._extensions..js (module.js:580:10)

What does your config.forge data in package.json look like?
  "config": {
    "forge": {
      "make_targets": {
        "win32": [
          "squirrel"
        ],
        "darwin": [
          "zip",
          "dmg"
        ],
        "linux": [
          "deb",
          "rpm"
        ]
      },
      "electronPackagerConfig": {
        "asar": true,
        "win32metadata": {
          "CompanyName": "TiziiTizii"
        }
      },
      "electronWinstallerConfig": {},
      "electronInstallerDebian": {},
      "electronInstallerRedhat": {},
      "github_repository": {
        "owner": "digidem",
        "name": "mapfilter-desktop",
        "draft": false
      },
      "windowsStoreConfig": {
        "packageName": "",
        "name": "TiziiTizii"
      }
    }
  },

Please provide either a failing minimal testcase (with a link to the code) or detailed steps to
reproduce your problem. Using electron-forge init is a good starting point, if that is not the
source of your problem.
https://github.com/digidem/mapfilter-desktop

Try cloning a new repository of it somewhere else. That's bizarre.

Yes, this worked -- I had originally cloned it in my ~/node_modules folder, which is where I have all of my node projects because then I can easily swap out dependencies. Cloning in a bare folder without this (e.g., ~/dev) then worked.


Ltd 3242 beis nuclear assessment flow

Stay on Assessment page when submitting products.
If all products have been assessed, stay on Assessment page but show "Make recommendation" button.

Rework done on a new branch


[YUNIKORN-1928] Exceed queue quota requests should be skipped when cl…

…uster auto scaling.
What is this PR for?
In shim side we have skip autoscaling logic both for yunikorn mode and plugin mode, we need to make that exceed queue quota requests should be skipped when cluster auto scaling.
switch request.State {
case si.UpdateContainerSchedulingStateRequest_SKIPPED:
    // auto-scaler scans pods whose pod condition is PodScheduled=false && reason=Unschedulable
    // if the pod is skipped because the queue quota has been exceed, we do not trigger the auto-scaling
    task.SetTaskSchedulingState(interfaces.TaskSchedSkipped)
    if ctx.updatePodCondition(task,
       &v1.PodCondition{
          Type:    v1.PodScheduled,
          Status:  v1.ConditionFalse,
          Reason:  "SchedulingSkipped",
          Message: request.Reason,
       }) {
       events.GetRecorder().Eventf(task.pod.DeepCopy(), nil,
          v1.EventTypeNormal, "PodUnschedulable", "PodUnschedulable",
          "Task %s is skipped from scheduling because the queue quota has been exceed", task.alias)
    }

It will be over auto scaling.
What type of PR is it?

[ ] - Bug Fix
[x] - Improvement
[ ] - Feature
[ ] - Documentation
[ ] - Hot Fix
[ ] - Refactoring

Todos

[ ] - Task

What is the Jira issue?

Open an issue on Jira https://issues.apache.org/jira/browse/YUNIKORN/
Put link here, and add [YUNIKORN-Jira number] in PR title, eg. [YUNIKORN-2] Gang scheduling interface parameters

How should this be tested?
Screenshots (if appropriate)
Questions:

[ ] - The licenses files need update.
[ ] - There is breaking changes for older versions.
[ ] - It needs documentation.

A draft code without unit testing, will submit unit test.

My PR want to improve, when a request is rejected due to queue limit, we don't hurry to auto-scaling for this request, we can make other requests which are not rejected by queue limit to auto scale, i am not sure if it ls a improvement @wilfred-s

See my comment on JIRA -- I don't think this is necessary at all:
I don't think there's any change required here as this logic is already handled properly in the core. We don't reject requests when queues are full, we simply keep the pod in a pending state (but not unschedulable). This prevents the autoscaler from scaling up. However, if the pod would fit in the queue but the cluster itself is full, then we mark it unschedulable to allow the autoscaler to work.
As for making other requests, this also happens - YK is a greedy scheduler and will attempt to fit smaller pods that are further back in the queue if there is room for them.

Thank you @craigcondit and @wilfred-s for confirming this, i will remove the skip logic in another PR.


Support postgresql UUID datatype.

A simple commit that use postgresql UUID datatype.
Hope it helps :)

UUID has been introduced in postgresql 8.3 : http://www.postgresql.org/docs/8.3/static/release-8-3.html

I like this, as a PG fanboy ;), just a little worried if we should think about backwards compatibility...
just switching the datatype might cause people some headaches... specially if you just install the git repo from a requirements files....

Yes, seems django support at least postgresql 8.2.
What kind of headaches would it produce ?
We could use a setting to enable it ?

Sorry for the delay.
My thought was for people that are already using the field it would change the type with an update of django_extensions.
Would this be a backwards compatibility change ? and how would south handle this.. could it be a clean migration from a VARCHAR to a UUID column ?
Also we might want to add a kwargs like 'force_charfield' or 'disable_native_dbtype' or alike, so people can force it to be a charfield if they need it.


Game Crash [Bug]

Minecraft Version

[ ] 1.12.2 (End of support)
[ ] 1.16.5
[ ] 1.18.2
[ ] 1.19.2
[x] 1.20/1.20.1

What happened?

The game crashes in my modpack, I have not been able to identify the cause

Relevant log output
https://gist.github.com/SaraXianLin/b3a40b62620658a7a0fd5c3b5447e58b

Contact Details
<EMAIL_ADDRESS>

the maids keep crashing my game with the same issue, I am going to try to add them to the bad mobs blacklist

Provided too little information and I really can't solve it


#27 - Explore Page

This PR closes #27
Created new explore page
Desktop:

Mobile:

Thanks @Ryan-Maddock-96 for the contribution.
High-quality code.


Remove spine-peer-filters.j2 and references to it

Issue Type

Documentation Report

Summary
As AVD is not using BGP listen-range for dynamic peering any more, spine-peer-filters.j2 template and references in the documentation have to be removed.
Role or Module Name

eos_l3ls_evpn
eos_cli_config_gen

Will be solved with PR #355


Backend Admin

Create all the Admin menu Backend

Model
Controller
Resource

Model done

Controller done
View done
UX filter & search done


KAFKA-8880: Add overloaded function of Consumer.committed [WIP]

Add the overloaded functions.
Update the code in Streams to use the batch API for better latency (this applies to both active StreamsTask for initialize the offsets, as well as the StandbyTasks for updating offset limits).
Also update all unit test to replace the deprecated APIs.

Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

cc @cpettitt-confluent @bbejeck  for another look.

retest this please

retest this please

Merging to trunk; will submit a separate PR for docs change.


Codegen: set required attribute of Property

Per the "Required Properties" section of
https://swagger.io/docs/specification/data-models/data-types/
we will inspect the Type.Schema.required list to determine if
a property is required
Refactored makeWriteableType to push more creation logic into
WriteType in order to be able to centralize the decision of
whether a property is required or not inside the Property class.

Here's an example of using this info in the python formatter: https://github.com/looker-open-source/sdk_codegen/compare/jd-codegen-required-properties...jd-python-fmt?expand=1#diff-4bb035f21e6587f3cdea3e75273214eeR252
you can see the syntax in the test (note both the class level property declaration and the __init__ signature for query_id and result_format) https://github.com/looker-open-source/sdk_codegen/compare/jd-codegen-required-properties...jd-python-fmt?expand=1#diff-27512a037bd7b230c89789ce3087b517R220


Build(deps-dev): Bump @types/node from 17.0.10 to 17.0.12 (#2516)

Pull request opened by the merge tool on behalf of #2516

Merged in 68733e2555609d87ba08c02e316aba8055e41150


Add the missing contextual links for Layout Builder blocks

Summary
This patches core to allow layout builder inline blocks to display the contextual links, thus allowing for translation of the inline blocks.
Metadata

Question
Answer

Did you use a meaningful pull request title?
yes

Did you apply meaningful labels to the pull request?
yes

Did you perform a self review first?
yes

Documentation reflects changes?
no

CHANGELOG reflects changes?
yes

Unit/Functional tests reflect changes?
no

Did you perform browser testing?
yes

Risk level
Low

Relevant links
RIG-160

Yep, all good!
/approved


Issue with NaN not comparable so piling up in Set[float64]

https://go.dev/play/p/2L3NR09zIJu
package main

import (
	"fmt"
	"math"

	"fortio.org/sets"
)

func test(v float64) {
	set := sets.New(v, v, v, v)
	set.Add(v, v, v)
	fmt.Printf("Using %f : %d elems %v and has: %v\n", v, len(set), set, set.Has(v))
}

func main() {
	test(math.Pi)
	test(math.NaN())
}

outputs
# As expected
Using 3.141593 : 1 elems 3.141592653589793 and has: true
# Not great
Using NaN : 7 elems NaN,NaN,NaN,NaN,NaN,NaN,NaN and has: false

Just leaving as a doc issue because otherwise would need to pepper the API and implementation with float/NaN checks

I think that NaN should be forbidden in New and Add: just panic. Because it is better to fail early.
The cmp has an isNaN function.

x != x  is indeed a clever IsNaN that was mentioned on gophers slack when this came up
panic for NaN is a reasonable suggestion, I wonder if there is a noticeable perf effect of adding that check, probably not when inlined