Fine-tuning worsens the quality of speech-synthesis.

I tried fine-tuning the model using some of my accented data. The audio synthesis is quite good as long as the reference voice is a part of the fine-tune dataset. But if any unseen/different-gender data is used as a reference audio, then the synthesized audio is still more similar to the fine-tune data than the reference audio. Is this because it is overfitting/getting biased towards seen data?

Yes, if you want to generalize to unseen speakers, the model has to see a lot of speakers. The base model (LibriTTS) has around 1000 speakers. After fine-tuning, the model will effectively fit on whatever number of speakers you have on your fine-tuning data. If your fine-tuning data has less than 1000 speakers, the performance for unseen speakers will be worse than the base model.

@yl4579 Is there a way to fine-tune for a single speaker?

@platform-kit Yes, the Colab demo finetunes on LJSpeech. The default config was also for LJSpeech, which is a single speaker dataset.

@yl4579 Ah, great news. Say I want to fine tune on a single speaker. Can you give an estimate of how much input audio I need to train on, and how many epochs?

This is the result of one hour of fine-tuning: https://github.com/yl4579/StyleTTS2/discussions/65#discussioncomment-7668393
The demo uses only 15 minutes of a single speaker speech, and the results are reasonably good (you can run the demo to see it yourself).

@yl4579 Got it. So how do I fine-tune with multiple speaker? Do I just create the train_list.txt with multiple speaker IDs?


The flex-sync branch has no podfile to install

Rchat-iOS folder has no podfile for the step below to work
https://www.mongodb.com/developer/products/realm/realm-flex-sync-tutorial/
cd ../../RChat-iOS
pod install
open RChat.xcodeproj

The app now uses Swift Package Manager rather than Pod. The blog post has been updated to reflect that


Add Objective C demo for PopupMenu

Platforms Impacted

[x] iOS
[ ] macOS

Description of changes
Adding an Objective C demo for the PopupMenu. This demo doesn't cover every Objective C API yet, so we should revisit it to add more later, but it's a solid start.
Verification

Pull request checklist
This PR has considered:

[ ] Light and Dark appearances
[ ] iOS supported versions (all major versions greater than or equal current target deployment version)
[ ] VoiceOver and Keyboard Accessibility
[ ] Internationalization and Right to Left layouts
[ ] Different resolutions (1x, 2x, 3x)
[ ] Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
[ ] iPad Pointer interaction
[ ] SwiftUI consumption (validation or new demo scenarios needed)
[x] Objective-C exposure (provide it only if needed)

Microsoft Reviewers: Open in CodeFlow

nit: can you fix the button so it looks normal rather than full screen box?


Export as .ICS

Old ics code: https://github.com/icssc-projects/AntAlmanac/blob/main/client/src/components/Calendar/ics.js


Fixed formatting and lowered verbosity of pod ps

CtrInfo now is formatted in the way originally intended. s/Number Of Containers/# Of Containers and s/Infra Container ID/Infra ID
Signed-off-by: haircommander<EMAIL_ADDRESS>

One naming nit otherwise LGTM

Going to wait for tests to go green and merge

@rh-atomic-bot r+


[BUG] Set-PnPTraceLog: log file is empty

Reporting an Issue or Missing Feature
When use Set-PnPTraceLog (PnP.PowerShell 1.7.0) output log file is empty:
Set-PnPTraceLog -On -LogFile "output.log" -Level Debug

Expected behavior
Output log file is not empty and contains logging information from PnP.PowerShell cmdlets.
Actual behavior
Output log is empty.
Steps to reproduce behavior
Please include complete script or code samples in-line or linked from gists
What is the version of the Cmdlet module you are running?
PnP.PowerShell 1.7.0
Which operating system/environment are you running PnP PowerShell on?

[ x] Windows

I have same issue.

Same issue here, specifically with Get-PnPSiteTemplate

Hopefully, will be resolved by this fix.
Am keeping the issue open till we release 1.8, strangely it works with nightly releases, so will keep an eye on it.

I have the same issue with command 'Invoke-PnPTenantTemplate -Path ./starterkit.pnp '

Any updates on this issue?
I do not get trace logs in the console using the command Invoke-PnPSiteTemplate using version 1.7.0 or 1.8.0.

Same here on 1.8.0. Trace log is created but empty. Ps 7.2 on win 10.

It's kind of annoying issue, specially when an error occurs on build environment :-(. (Without interactive prompt option)
Do we know, what went wrong? The trace logger listener seems to be working, but there are no messages written to the Trace...
Any workaround?
Thanks

I had an idea.
PnP.PowerShell use the PnP.Framework.Diagnostics.TraceLogger (from the  PnP.Framework.dll) wich using the System.Diagnostic.Trace class.
In the PnP.Framework project I see in the Release configuration the TRACE variable is not defined, so because the ConditionalAttribute on the Trace class, the code calling Trace methods is not generated.
I tested with building a new PnP.Framework.dll with the TRACE variable enabled, and my log files are filled.
I don't know how to report this feedback ?
Regards

@ygrenier that would be on the pnp site core side of the project, https://github.com/pnp/pnpframework. Thanks for validating. If we could find which commit changed this variable though, that would be nice...

@ygrenier that would be on the pnp site core side of the project, https://github.com/pnp/pnpframework. Thanks for validating. If we could find which commit changed this variable though, that would be nice...

Thanks, I found the problem: the nightly build use the Release configuration instead of Debug since some month.

Merci @ygrenier ! Ok it's in the build script that changes were done. I wasnt looking at the right place! So if using Build-Debug.ps1 locally, it fixes the problem...

thanks @ygrenier for sharing your finding!
@Micael-stack are there any plans for providing this fix in upcoming release?

@gautamdsheth @erwinvanhunen could you check provided information please. I think root cause is found

@gautamdsheth @erwinvanhunen could you check provided information please. I think root cause is found

Yes @gautamdsheth opened a PR Fix #547 - issue with trace log to fix it.

All - I just ran the test that I posted in Oct using version 1.9.0 and the log file was populated as expected. Thanks for the hard work tracking this down!

@jdegiglio - thanks for confirming the fix.
@ygrenier - thanks for the amazing investigation :)
Closing it now !


Add onEditingComplete to ReactiveTextField

Hey,
Just noticed that there is no option to pass onEditingComplete to a ReactiveTextField.
Please add it,
Thanks :)

@naamapps ReactiveTextField supports custom focusNode
When field looses focus it could be a sign of editing complition
Could you describe your use case more verbose?

@vasilich6107 well it's built into flutter native TextField so I suppose there's a difference.
I need it to focus another input that doesn't exist yet (a dynamic list of inputs) without closing the keyboard.
onSubmitted closes the keyboard and it is not what I want.

Hi @naamapps,
In the example folder of the project, in the complex example, we use onSubmitted to move focus between several ReactiveTextFields, and the behavior is that the keyboard never hides, but the focus jump from one TextField to another.
So I'm not clear yet about the issue. Could you post a dart file with the code so I can include it in an application and test what you want to achieve?
Thanks

@joanpablo,
As far a I know the default onEditingComplete dismisses the keyboard automatically, so overriding it stops this behavior.
And I think it is better to give the developer an option to override all of flutter's TextField properties, even if you think it's not important or unnecessary.
I hope you understand
Thanks

Hi @naamapps,
You are right about giving the developer the option to decide, I completely agree with you. I think it will not harm any feature if I include it in the next release.
Thanks

Hi @naamapps,
The latest version that I have just released v 10.3.0, includes this new callback in the ReactiveTextField.
Don't hesitate to reopen the issue or create e new one if something else is missing.
Thanks for your support, and best regards


Cython3 support

Major change is in d4ca69fe8944548ab2758fa2b21c4409aaba4435 which is a workaround to Cython3 deprecating
the support for translation time constant conditional statements.

cc @mgorny

Well done on finding a workaround @isuruf. If we had unlimited time resources I guess we would come up with something else, but this looks like the simplest fix to me. :)

Maybe we should add a CI-job which explicitly runs with cython>=3?

New CI uses cython3 now


add new pre routine interpolations for geography and albedo data

This pull request contains modules, function and adjustments in existing modules that enable to:

read out any image of the world and converts it into the necessary input format
upscaled the current input files "The_World.dat" and "albedo.dat" but stay in the ratio longitude x (longitude/2 +1)
handle the new directory structure

@noeztekin, can you please add a test for the routines in src/interpolation.jl?

Coverage decreased (-26.6%) to 65.777% when pulling 619eaa4b3948ab3a9848e87cc5672c874bba9758 on noeztekin:PreRoutineInterpolations into 0801595dc81dc3789d0fea67dc794072b6a53b4e on klimakoffer:main.


Set Up Business Process Management Services in Cloud Cockpit

Tutorial URL: https://developers.sap.com/tutorials/cp-starter-ibpm-employeeonboarding-1-setup.html
Please specify the step you are referring to: step 5
When deploying BPMServicesFLP_0.0.1.mtar an error is thrown "Deployment of the "BPMServicesFLP"  project failed" .
I have checked the noted conditions, these are not applicable for me:
'if you have not enabled the entitlements of workflow, business rules, process visibility and portal. Ensure that you have followed Step 1 to do the necessary entitlements.
if you already have the instance of either workflow, business rules or process visibility created of same name. In that case, update modules and resources section in mta.yaml to replace that service instance name with a new unique name.'
Can you please help, as this scenario is needed for training purposes.
Subdomain: s0021505517trial
Org Name: s0021505517trial
API Endpoint: https://api.cf.eu10.hana.ondemand.com
Regards,
Martijn

After retrying several times, the project has now succesfully been deployed. Issue closed.


<EMAIL_ADDRESS>decompress error

PS C:\Users\an.tripathi> scoop install twilio
Installing '7zip' (22.01) [64bit] from main bucket
7z2201-x64.msi (1.8 MB) [=====================================================================================] 100%
Checking hash of 7z2201-x64.msi ... ok.
Extracting 7z2201-x64.msi ... done.
Linking ~\scoop\apps\7zip\current => ~\scoop\apps\7zip\22.01
Creating shim for '7z'.
Creating shim for '7zFM'.
Creating shim for '7zG'.
Creating shortcut for 7-Zip (7zFM.exe)
Persisting Codecs
Persisting Formats
Running post_install script...
'7zip' (22.01) was installed successfully!
Notes
Add 7-Zip as a context menu option by running: "C:\Users\an.tripathi\scoop\apps\7zip\current\install-context.reg"
Installing 'twilio' (5.2.3) [64bit] from twilio-scoop bucket
twilio-win32-x64.tar.xz (32.6 MB) [===========================================================================] 100%
Checking hash of twilio-win32-x64.tar.xz ... ok.
Extracting twilio-win32-x64.tar.xz ... ERROR Exit code was 2!
Failed to extract files from C:\Users\an.tripathi\scoop\apps\twilio\5.2.3\twilio-win32-x64.tar.
Log file:
~\scoop\apps\twilio\5.2.3\7zip.log

This looks like a duplicate issue. Can you please try running this cmd in Powershell ran as an admin ?


Support resource imports

All resources should  support terraform import ...
e.g.
terraform import appoptics_space.appoptics_space.test 751247
Error: Unexpected value for InstanceType field: "test"

For information on valid syntax, see:
https://www.terraform.io/docs/internals/resource-addressing.html

Item was marked as done but it seems that it's not.
terraform import appoptics_dashboard.example_dashboard_to_import 1487925
appoptics_dashboard.example_dashboard_to_import: Importing from ID "1487925"...
╷
│ Error: resource appoptics_dashboard doesn't support import
│


Update issue templates

Resolve: #59

Thanks for the PR @alloro! Can you please update your branch with master. Out of interest what did you base these templates on?

@revett if you look for Github Issue Templates, there's repos with tons of them!

@revett Github actually offers a neat documentation and automatic setup

@alloro do make sure you use the PR template when opening a PR.
I've added our checklist back in, make sure you bump VERSION ;)


Issue with the unMatchedFrameTolerance setting

How to adjust the configuration in Opendatacam so that it tracks an object without interruption?
In my case I am counting driving cars in a video. I noticed under pathfinder that the tracker loses the cars in the video and recognizes them as a new one a few frames later. (The line of the drawn path is interrupted and after a short pause it is drawn again with a new color).
On this page was it recommend to increase "unMatchedFrameTolerance" from value. So I changed it from 5 to 20 and even higher values. Unfortunately, this did not bring any improvements, the error still occurs and does not change.
config.json (for upload as txt file):
config.txt
Screenshot:

Did you build after changing the config?

I also had the feeling that this sometimes does not work. But have never confirmed it yet.
What I can offer as an alternative is changing the iouOverlap to a lower value. This could allow the tracker to keep an eye on faster moving cars. Have you tried tweaking this value as well?

I have had a similar issue as well. I will describe my project below. I am using Jetson Nano 2gb.
I have a video recording from the corner of a traffic intersection with 4 approaches visible. I have labeled the approaches N, S, E and W for the detection lines. When a vehicle enters an intersection, it registers with a unique ID and timestamp. When it exits, it often registers with the same ID but with a different timestamp and a different line crossed. For a given length of video, I list all unique ID's, count the number of occurrences for each ID, and then list the Min and Max timestamp for each ID as well as the corresponding detection lines. This gives me a full count of all all vehicles entering an approach (N,S,E or W) exiting to a different departure direction.
Ideally, number of unique ID's should be twice the vehicle count, and every ID should only show up twice. In my sample video, I had 20 double counts and 29 single counts. All single counts were vehicles that lost their initial ID and got assigned another on exit. I have increased unMatchedFrameTolerance and computeTrajectoryBasedOnNbOfPastFrame values alternatively and did a sudo docker-compose restart after every change, and compared against 20 double and 29 single counts that I get with default config.json. Those values dont change. I am either

adjusting the wrong parameters or
not letting ODC know that parameters are changed (incorrect "build"?)
parameters may not be working properly.

I have not changed IOU settings, but I have seen tracker lose vehicles that were not occluded from beginning till end.
Any suggestions?

Have you tried adjusting the iouLimit? It might be that the object is moving to fast for the tracker to follow its trajectory, a lower iouLimit could work with fast moving objects but might lead to false trajectories in crowded intersections as object may get merged.
Also I don't know if sudo docker-compose restart refreshes changes to the config.json  just to be safe I recommend fully stopping and starting ODC.
Last, which version are you running? Did you check if development behaves the same way?


About the docker image

i can't successfully run the command “docker build -t shinkeli/campus3d:latest .” , and i even can't find the image "shinkeli/campus3d" in the Docker Hub, but i find one named "shinkeli/conda-tf2-open3d", which published before 4 years ago, is this the right image for the project?

Yes, you may attempt to use this image. However, as docker is no longer supported in some countries, it is hard to keep it updated. For the sake of convenient env building, I recommend you use the [reproduce version](https://github.com/Yuqing-Liao/reproduce-campus3d）which is based on pytorch.


Ride language support

Ported from https://bitbucket.org/birkenfeld/pygments-main/pull-requests/819

superseded by #1319


Refactor to use new transform infra

Migrate the definition of gzipBeamFieldsM from the mini-beam example of the large-records test suite here.
Extend the Data.Record.Generic.Transform approach to nullable fields.
Redefine gtblSkeleton in terms of the new Transform infra.
Port gzipTables to the new transform infra.
Port autoDbSettings.
Move autoTblSettings to new module; code basically unchanged, just some stylistic changes for overall coherence (it was not using Exposed at all).
Changed the example into an actual test (albeit a unit test), and extended its scope: add example of a view and of a domain type to the LRDB, so that we also test the corresponding DB settings and (missing in Andres' version) ZipTablesI instance.

The only concept from Andres' original version that does not have an equivalent in the new version is InterpretReqs. I think this is no longer required: in the origin this was used to share some code between zipping and DB settings, but those two functions no longer share any code in the new version.

Here is an annotated version of Andres' original code, with important definitions annotated with where they lives now.
{-# OPTIONS_GHC -Wall #-}
{-# LANGUAGE TypeApplications #-}
{-# LANGUAGE RankNTypes #-}
{-# LANGUAGE PolyKinds #-}
{-# LANGUAGE ConstraintKinds #-}
{-# LANGUAGE ScopedTypeVariables #-}
{-# LANGUAGE MultiParamTypeClasses #-}
{-# LANGUAGE FlexibleInstances #-}
{-# LANGUAGE FlexibleContexts #-}
{-# LANGUAGE TemplateHaskell #-}
{-# LANGUAGE TypeFamilies #-}
{-# LANGUAGE DataKinds #-}
{-# LANGUAGE UndecidableInstances #-}
{-# LANGUAGE DeriveGeneric #-}
{-# LANGUAGE DeriveAnyClass #-}
{-# LANGUAGE InstanceSigs #-}
{-# LANGUAGE QuantifiedConstraints #-}
{-# LANGUAGE UndecidableSuperClasses #-}
{-# LANGUAGE AllowAmbiguousTypes #-}
{-# LANGUAGE QuasiQuotes #-}
{-# LANGUAGE GADTs #-}
{-# LANGUAGE StandaloneDeriving #-}
{-# LANGUAGE OverloadedStrings #-}
{-# LANGUAGE TypeOperators #-}
{-# LANGUAGE ViewPatterns #-}
module Data.Record.Generic.Beam where

import Data.Bifunctor
import Data.Char
import Data.Kind
import Data.Record.Generic
import Data.Record.Generic.Show
import qualified Data.Record.Generic.Rep as R
import Data.Record.TH
import Database.Beam.Schema.Tables
import Unsafe.Coerce
import Control.Applicative
import Data.Coerce
import qualified GHC.Generics as GHC
import qualified Data.Text as T
import Lens.Micro ((%~))
import GHC.TypeLits

-- * Beamable

-- | The generic code for the 'Beamable' class in beam-core distinguishes three different
-- shapes of fields. Simple fields are applications of 'Columnar', mixins / foreign key references
-- are references to other tables that are themselves 'Beamable', and nullable mixins are references
-- to other tables with an additional 'Nullable' flag (which essentially causes 'Maybe') to be
-- applied to all columns within that table.
--
-- EdV: This corresponds to the 3 instance heads of 'ZipInterpreted' (no intermediate GADT)
data BeamField :: (Type -> Type) -> Type -> Type where
  SimpleBeamField        :: Columnar' f a -> BeamField f (Exposed a)
  MixinBeamField         :: Beamable tbl => tbl f -> BeamField f (tbl Exposed)
  NullableMixinBeamField :: Beamable tbl => tbl (Nullable f) -> BeamField f (tbl (Nullable Exposed))

-- | Once we know which form of beam fields we have to deal with, we can combine matching beam fields.
-- The code for this function corresponds to three different instances for the
-- 'Database.Beam.Schema.Tables.GZipTables' class, and is almost directly taken from there.
--
-- EdV: This corresponds to the 3 instance definitions of 'ZipInterpreted'
combineBeamFields ::
  forall f g h m b.
  (Applicative m)
  => (forall a.  Columnar' f a -> Columnar' g a -> m (Columnar' h a))
      -> (forall a. Columnar' (Nullable f) a -> Columnar' (Nullable g) a -> m (Columnar' (Nullable h) a))
    adapt c fa ga = toNullable <$> c (fromNullable fa) (fromNullable ga)

    toNullable :: forall w a. Columnar' w (Maybe a) -> Columnar' (Nullable w) a
    toNullable = coerce

    fromNullable :: forall w a. Columnar' (Nullable w) a -> Columnar' w (Maybe a)
    fromNullable = coerce

-- | In the constraint 'CheckBeamField f b', the type @b@ is supposed to be the type
-- of a field of some type @tbl f@ where @f@ has been instantiated to 'Exposed'.
--
-- 'Exposed' is defined within beam-core and can be used to distinguish the different
-- kinds of fields we are interested in.
--
-- From the shape of @b@, we can then learn the shape of @tbl f@ if @f@ is unknown.
--
-- Each of the instances are corresponding to one of the constructors of 'BeamField'.
--
-- EdV: This (along with instances) is roughly 'HasNormalForm'
class CheckBeamField f b where
  -- | If @tbl Exposed@ has a field of type @b@, then @tbl f@ is supposed to
  -- have the type @OriginalType f<EMAIL_ADDRESS>  type family OriginalType f b :: Type
  checkBeamField :: OriginalType f b -> BeamField f b
  uncheckBeamField :: BeamField f b -> OriginalType f b

-- If a field in the table is of shape @Columnar f x@, then @Columnar Exposed x@
-- reduces to @Exposed<EMAIL_ADDRESS>So in turn we're assuming that if we observe @Exposed x@,
-- we require the shape of the field to be @Columnar f<EMAIL_ADDRESS>--
-- EdV: done
instance CheckBeamField f (Exposed x) where
  type OriginalType f (Exposed x) = Columnar f x
  checkBeamField x = SimpleBeamField (Columnar' x)
  uncheckBeamField (SimpleBeamField (Columnar' x)) = x

-- If a field in the table is of shape @tbl f@, then we observe @tbl Exposed@
-- on the instantiation to<EMAIL_ADDRESS>--
-- EdV: done
instance (Beamable tbl) => CheckBeamField f (tbl Exposed) where
  type OriginalType f (tbl Exposed) = tbl f
  checkBeamField x = MixinBeamField x
  uncheckBeamField (MixinBeamField x) = x

-- If a field in the table is of shape @tbl (Nullable f)@, then we observe
-- @tbl (Nullable Exposed)@ on the instantiation to<EMAIL_ADDRESS>--
-- EdV: done
instance (Beamable tbl) => CheckBeamField f (tbl (Nullable Exposed)) where
  type OriginalType f (tbl (Nullable Exposed)) = tbl (Nullable f)
  checkBeamField x = NullableMixinBeamField x
  uncheckBeamField (NullableMixinBeamField x) = x

-- | Require all fields in a table to be in one of the three beam field
-- cases, by traversing the constraints corresponding to @tbl<EMAIL_ADDRESS>--
-- EdV: This corresponds roughly to @Constraints (table Uninterpreted) ZipInterpreted@
type CheckBeamFields f tbl = (Constraints (tbl Exposed) (CheckBeamField f))

-- | Corresponds roughly to the 'gTblSkeleton' implementation in the
-- 'GTableSkeleton' class.
--
-- Code is taken from the instances of that class.
--
-- EdV: This corresponds to 'ZipInterpreted'
class IgnoreBeamField (a :: Type) where
  ignoreBeamField :: BeamField Ignored a

-- EdV: done
instance IgnoreBeamField (Exposed x) where
  ignoreBeamField = SimpleBeamField (Columnar' Ignored)

-- EdV: done
instance Beamable tbl => IgnoreBeamField (tbl Exposed) where
  ignoreBeamField = MixinBeamField tblSkeleton

-- EdV: done
instance Beamable tbl => IgnoreBeamField (tbl (Nullable Exposed)) where
  ignoreBeamField = NullableMixinBeamField (unI (zipBeamFieldsM transform tblSkeleton tblSkeleton))
    where
      transform :: Columnar' Ignored a -> Columnar' Ignored a -> I (Columnar' (Nullable Ignored) a)
      transform _ _ = I (Columnar' Ignored)

-- EdV: roughly corresponds to 'Interpreted'
newtype O f a = O { unO :: OriginalType f a }

-- | Coercion that makes use of the identity we have for 'OriginalType'.
-- For every field @b@ contained in @tbl Exposed@, we know that @OriginalType f b@
-- is the corresponding field of @tbl<EMAIL_ADDRESS>--
-- EdV: roughly corresponds to 'normalize1'
expose :: CheckBeamFields f tbl => Rep I (tbl f) -> Rep (O f) (tbl Exposed)
expose = unsafeCoerce
{-# NOINLINE expose #-}

-- | Inverse of 'expose', using the same type identity.
--
-- EdV: roughly corresponds to 'denormalize1'
unexpose :: CheckBeamFields f tbl => Rep (O f) (tbl Exposed) -> Rep I (tbl f)
unexpose = unsafeCoerce
{-# NOINLINE unexpose #-}

-- EdV: unnecessary in new approach
checkBeamFields ::
  forall f tbl. (Generic (tbl Exposed), CheckBeamFields f tbl)
  => Rep I (tbl f) -> Rep (BeamField f) (tbl Exposed)
checkBeamFields = R.cmap (Proxy @(CheckBeamField f)) (checkBeamField . unO) . expose

-- EdV: unnecessary in new approach
uncheckBeamFields :: forall f tbl. (Generic (tbl Exposed), CheckBeamFields f tbl)
  => CheckBeamFields f tbl => Rep (BeamField f) (tbl Exposed) -> Rep I (tbl f)
uncheckBeamFields = unexpose . R.cmap (Proxy @(CheckBeamField f)) (O . uncheckBeamField)

-- | Generic implementation of 'zipBeamFieldsM' that can be used in 'Beamable' instances.
--
-- EdV: done
gzipBeamFieldsM ::
  forall tbl f g h m.
  ( Applicative m
  , Generic (tbl f)
  , Generic (tbl g)
  , Generic (tbl h)
  , Generic (tbl Exposed)
  , CheckBeamFields f tbl
  , CheckBeamFields g tbl
  , CheckBeamFields h tbl
  )
  => (forall a.
  ( Applicative m
  , Generic (tbl f)
  , Generic (tbl g)
  , Generic (tbl h)
  , Generic (tbl Exposed)
  , CheckBeamFields f tbl
  , CheckBeamFields g tbl
  , CheckBeamFields h tbl
  )
  => (forall a. Columnar' f a -> Columnar' g a -> m (Columnar' h a))
  -> Rep I (tbl f) -> Rep I (tbl g) -> m (Rep I (tbl h))
zipBeamFieldsM_Rep combine f g =
  let
    ef :: Rep (BeamField f) (tbl Exposed)
    ef = checkBeamFields f

    eg :: Rep (BeamField g) (tbl Exposed)
    eg = checkBeamFields g

    eh :: m (Rep (BeamField h) (tbl Exposed))
    eh = R.zipWithM (combineBeamFields combine) ef eg

    h :: m (Rep I (tbl h))
    h = uncheckBeamFields <$> eh
  in
    h

-- | Generic implementation of 'tblSkeleton' that can be used in 'Beamable' instances.
--
-- EdV: done
gtblSkeleton ::
  forall tbl.
  ( Generic (tbl Ignored)
  , Generic (tbl Exposed)
  , Constraints (tbl Exposed) IgnoreBeamField
  , CheckBeamFields Ignored tbl
  )
  => TableSkeleton tbl
gtblSkeleton =
  let
    e :: Rep (BeamField Ignored) (tbl Exposed)
    e = R.cpure (Proxy @IgnoreBeamField) ignoreBeamField
  in
    to (uncheckBeamFields e)

-- * Database

data Reqs = DefaultReqs | RegularReqs | LRReqs

type family InterpretReqs (reqs :: Reqs) (be :: Type) (tbl :: Type) :: Constraint where
  -- InterpretReqs 'DefaultReqs be tbl = DatabaseEntityDefaultRequirements be tbl
  InterpretReqs 'LRReqs      be tbl = DatabaseEntityLRRequirements      be tbl
  InterpretReqs 'RegularReqs be tbl = DatabaseEntityRegularRequirements be tbl

-- EdV: this along with combineDatabaseFields roughly corresponds to the 'ZipTablesI' instance;
data DatabaseField :: Reqs -> Type -> (Type -> Type) -> Type -> Type where
  DatabaseEntityField :: (IsDatabaseEntity be tbl, InterpretReqs reqs be tbl) => f tbl -> DatabaseField reqs be f (Exposed tbl)

-- EdV: done (this is roughly the ZipTablesI instance)
combineDatabaseFields ::
  forall reqs be f g h m x.
  (Applicative m)
  => (forall tbl.  (Generic (db Exposed), CheckDatabaseFields reqs be f db)
  => Rep I (db f) -> Rep (DatabaseField reqs be f) (db Exposed)
checkDatabaseFields = R.cmap (Proxy @(CheckDatabaseField reqs be f)) (checkDatabaseField . unD) . dbExpose @reqs @be

-- EdV: not needed (part of the Transform infra)
uncheckDatabaseFields ::
  forall reqs be f db. (Generic (db Exposed), CheckDatabaseFields reqs be f db)
  => Rep (DatabaseField reqs be f) (db Exposed) -> Rep I (db f)
uncheckDatabaseFields = dbUnexpose @reqs @be . R.cmap (Proxy @(CheckDatabaseField reqs be f)) (D . uncheckDatabaseField)

-- EdV: done
gzipTables ::
  forall be db f g h m.
  ( Applicative m
  , Generic (db f)
  , Generic (db g)
  , Generic (db h)
  , Generic (db Exposed)
  , CheckDatabaseFields 'RegularReqs be f db
  , CheckDatabaseFields 'RegularReqs be g db
  , CheckDatabaseFields 'RegularReqs be h db
  )
  => Proxy be
  -> (forall tbl.
  ( Applicative m
  , Generic (db f)
  , Generic (db g)
  , Generic (db h)
  , Generic (db Exposed)
  , CheckDatabaseFields 'RegularReqs be f db
  , CheckDatabaseFields 'RegularReqs be g db
  , CheckDatabaseFields 'RegularReqs be h db
  )
  => (forall tbl. (IsDatabaseEntity be tbl, DatabaseEntityRegularRequirements be tbl) => f tbl -> g tbl -> m (h tbl))
  -> Rep I (db f) -> Rep I (db g) -> m (Rep I (db h))
gzipTables_Rep combine f g =
  let
    ef :: Rep (DatabaseField 'RegularReqs be f) (db Exposed)
    ef = checkDatabaseFields f

    eg :: Rep (DatabaseField 'RegularReqs be g) (db Exposed)
    eg = checkDatabaseFields g

    eh :: m (Rep (DatabaseField 'RegularReqs be h) (db Exposed))
    eh = R.zipWithM (combineDatabaseFields combine) ef eg

    h :: m (Rep I (db h))
    h = uncheckDatabaseFields <$> eh
  in
    h

-- EdV: this corresponds roughly to the 'AutoDbSettingsI' class
class AutoDbSetting be (tbl :: Type) where
  autoDbSetting :: String -> DatabaseField 'LRReqs be (DatabaseEntity be db) tbl

-- EdV: this indirection does not exist in the ported code; instead, this is
-- collapsed into the 'AutoDbSettingsI' instances
instance (IsDatabaseEntity' be tbl, DatabaseEntityLRRequirements be tbl) => AutoDbSetting be (Exposed tbl) where
  autoDbSetting fname = DatabaseEntityField (DatabaseEntity (dbEntityLRAuto @be (T.pack fname)))
  -- EdV: this comment is I think out of date:
  -- TODO: The use of `dbEntityAuto` here is wrong. It relies on `DatabaseEntityDefaultRequirements`,
  -- which in turn relies on `GDefaultTableFieldSettings`, which works on the GHC.Generics representation
  -- by using `defTblFieldSettings`. I think we have to replace these as well.

-- EdV: corresponds roughly to our 'AutoDbSettingsI' class (along with 'AutoDbSetting')
class IsDatabaseEntity be entityType => IsDatabaseEntity' be entityType where
  type DatabaseEntityLRRequirements be entityType :: Constraint
  dbEntityLRAuto :: DatabaseEntityLRRequirements be entityType => T.Text -> DatabaseEntityDescriptor be entityType

-- EdV: this is roughly our (only) 'AutoDbSettingsI' instance
instance Beamable tbl => IsDatabaseEntity' be (TableEntity tbl) where
  type DatabaseEntityLRRequirements be (TableEntity tbl) =
    ( Table tbl
    , Generic (tbl (TableField tbl))
    , Constraints (tbl (TableField tbl)) CheckTblField
    )
  dbEntityLRAuto nm =
    DatabaseTable Nothing nm (unCamelCaseSel nm) autoTblSettings

-- EdV: done
instance Beamable tbl => IsDatabaseEntity' be (ViewEntity tbl) where
  type DatabaseEntityLRRequirements be (ViewEntity tbl) =
    ( Table tbl
    , Generic (tbl (TableField tbl))
    , Constraints (tbl (TableField tbl)) CheckTblField
    )
  dbEntityLRAuto nm =
    DatabaseView Nothing nm (unCamelCaseSel nm) autoTblSettings

-- EdV: done
instance IsDatabaseEntity' be (DomainTypeEntity ty) where
  type DatabaseEntityLRRequirements be (DomainTypeEntity ty) = ()
  dbEntityLRAuto =
    DatabaseDomainType Nothing

-- EdV: this corresponds roughly to the 'AutoTblSettingsI' class
class CheckTblField a where
  tblField :: T.Text -> a

-- EdV: done
instance CheckTblField (TableField tbl a) where
  tblField fname =
    TableField (pure fname) (unCamelCaseSel fname)

-- EdV: done
instance
  ( ChooseSubTableStrategy tbl sub ~ strategy
  , SubTableStrategyImpl strategy f sub
  , TagReducesTo f (TableField tbl)
  , Beamable sub
  )
  => CheckTblField (sub f) where
  tblField origSelName =
    let
      tbl :: sub f
      tbl = namedSubTable (Proxy @strategy)

      relName :: T.Text
      relName = unCamelCaseSel origSelName

      settings' :: sub f
      settings' =
        changeBeamRep (reduceTag %~ \(Columnar' (TableField path nm)) -> Columnar' (TableField (pure origSelName <> path) (relName <> "__" <> nm))) tbl
    in
      settings'

-- EdV: done
class SubTableStrategyImpl (strategy :: SubTableStrategy) (f :: Type -> Type) sub where
  namedSubTable :: Proxy strategy -> sub f

-- EdV: done
instance
  ( Generic (sub f)
  , Constraints (sub (TableField tbl)) CheckTblField
  , f ~ TableField tbl
  )
  => SubTableStrategyImpl 'BeamableStrategy f sub where
  namedSubTable _ = autoTblSettings

-- EdV: done
instance
  ( Generic (rel (TableField rel))
  , Constraints (rel (TableField rel)) CheckTblField
  , TagReducesTo f (TableField tbl)
  , Table rel
  )
  => SubTableStrategyImpl 'PrimaryKeyStrategy f (PrimaryKey rel) where
  namedSubTable _ =
    primaryKey
      (changeBeamRep
        (\ (Columnar' (TableField path nm)) ->
          unI (reduceTag (\ _ -> pure (Columnar' (TableField path nm))) undefined)
        )
        (autoTblSettings @rel @rel)
      )

-- EdV: done
instance
  ( CheckNullable f
  , SubTableStrategyImpl 'PrimaryKeyStrategy f (PrimaryKey rel)
  )
  => SubTableStrategyImpl 'RecursiveKeyStrategy f (PrimaryKey rel) where
  namedSubTable _ =
    namedSubTable (Proxy @'PrimaryKeyStrategy)

-- EdV: done
autoTblSettings ::
  forall tbl tbl'.
  ( Generic (tbl (TableField tbl'))
  , Constraints (tbl (TableField tbl')) CheckTblField
  )
  => tbl (TableField tbl')
autoTblSettings =
  let
    fnames :: Rep (K String) (tbl (TableField tbl'))
    fnames = recordFieldNames (metadata (Proxy @(tbl (TableField tbl'))))

    tblFields :: Rep I (tbl (TableField tbl'))
    tblFields = R.cmap (Proxy @CheckTblField) (\ (K n) -> I (tblField (T.pack n))) fnames
  in
    to tblFields

-- EdV: done
autoDbSettings ::
  forall be db.
  ( Generic (db (DatabaseEntity be db))
  , Generic (db Exposed)
  , Constraints (db Exposed) (AutoDbSetting be)
  , CheckDatabaseFields 'LRReqs be (DatabaseEntity be db) db
  )
  => DatabaseSettings be db
autoDbSettings =
  let
    fnames :: Rep (K String) (db Exposed)
    fnames = recordFieldNames (metadata (Proxy @(db Exposed)))

    e :: Rep (DatabaseField 'LRReqs be (DatabaseEntity be db)) (db Exposed)
    e = R.cmap (Proxy @(AutoDbSetting be)) (autoDbSetting . unK) fnames
  in
    to (uncheckDatabaseFields e)

-- * Utilities (should be exported from Beam)

-- EdV: done (this is copied from beam)
unCamelCaseSel :: T.Text -> T.Text
unCamelCaseSel original =
  let symbolLeft = T.dropWhile (=='_') original
  in if T.null symbolLeft
     then original
     else if T.any (=='_') symbolLeft
          then symbolLeft
          else case unCamelCase symbolLeft of
                 [] -> symbolLeft
                 [xs] -> xs
                 _:xs -> T.intercalate "_" xs

-- EdV: done (this is copied from beam)
unCamelCase :: T.Text -> [T.Text]
unCamelCase "" = []
unCamelCase s
    | (comp, next) <- T.break isUpper s, not (T.null comp) =
          let next' = maybe mempty (uncurry T.cons . first toLower) (T.uncons next)
          in T.toLower comp:unCamelCase next'
    | otherwise =
          let (comp, next) = T.span isUpper s
              next' = maybe mempty (uncurry T.cons . first toLower) (T.uncons next)
          in T.toLower comp:unCamelCase next'

-- EdV: done (this is copied from beam)
type family ChooseSubTableStrategy (tbl :: (Type -> Type) -> Type) (sub :: (Type -> Type) -> Type) :: SubTableStrategy where
  ChooseSubTableStrategy tbl (PrimaryKey tbl) = 'RecursiveKeyStrategy
  ChooseSubTableStrategy tbl (PrimaryKey rel) = 'PrimaryKeyStrategy
  ChooseSubTableStrategy tbl sub = 'BeamableStrategy

-- EdV: done (this is copied from beam)
data SubTableStrategy
  = PrimaryKeyStrategy
  | BeamableStrategy
  | RecursiveKeyStrategy

-- EdV: done (this is copied from beam)
type family CheckNullable (f :: Type -> Type) :: Constraint where
  CheckNullable (Nullable f) = ()
  CheckNullable f = TypeError ('Text "Recursive references without Nullable constraint form an infinite loop." ':$$:
                               'Text "Hint: Only embed nullable 'PrimaryKey tbl' within the definition of 'tbl'."

Closing in favour of #4.


-webkit-font-feature-settings: "calt" on, stopped working

Any recent code change that could explain this? The font with contextual alternates continues to work fine in other programs and worked fine i Atom just a couple of hours ago.

I'm using contextual alternates for the ligatures in https://github.com/larsenwork/monoid

cc @nathansobo @as-cii

That's interesting. Thank you for reporting this, @larsenwork!
As far as I understand, this shouldn't be related to the recent legibility issue: @larsenwork, would you be willing to check out if this actually broke in 0.207 (e.g. simply download the previous version and confirm it was working)? Also, you may want to rebuild master now that #7127 was merged: I don't think it's related but it may be worth giving that a try.
@nathansobo: could this be caused by a theme (or any CSS for that matter) which explicitly opts out contextual alternates?
I'll try to investigate what's causing this problem in the meantime and report what I find out here (probably the next week, as my schedule is quite busy as of this one).
Thanks! :bow:

@as-cii thanks for the detailed reply - I will try previous version and report back on my findings:)

Ok this is weird - without changing the font:
207 -> not working -> delete 207 -> install 206 -> works -> press install update and relaunch in the menu -> still works
I haven't changed anything else (themes etc.)
So I can't reproduce the error and since it's currently working I'm closing this. Will reopen should the problem reappear.

Hmm...that was too quick I'm afraid. Didn't work again this morning when I started atom again and reverting to 206 didn't fix it this time around. For anyone else who wants to try
styles.less
*{
  -webkit-font-smoothing:antialiased;
  -webkit-font-feature-settings: "calt" on, "liga" on;
}

font: http://larsen.work/monoid/
try typing e.g.
{5<=x&&y!==2}

it should look like this (from textedit on mac)

I also disabled all community packages to ensure they weren't the culprit.

Thanks for the additional details, @larsenwork. In your description of the issue you mentioned this:

worked fine in Atom just a couple of hours ago.

Would you be willing to try the last few versions of Atom and see which is the last version that works for you as expected? You already tested 0.207 and 0.206, so I think testing 0.205/4/3/2/1 would be enough. Version 0.200 was released 21 days ago, so it's probably a good place to draw the line?

@izuzak I'm not sure how testing older versions will help narrow down the problem as it worked yesterday with both 206 and 207 so the issue is more that it works very unreliably in current versions (I've tried reinstalling, disabling packages etc. to no avail).
I only switched to Atom recently and began using contextual alternates a couple of days ago so I can't vouch for stability in the past.

I only switched to Atom recently and began using contextual alternates a couple of days ago so I can't vouch for stability in the past.

That was the context I was missing -- from your original issue description it sounded like this started happening recently, and you've been using Atom for a while.

Ah, yeah I've only used it a couple of weeks and the calt feature a couple of days - but it worked without problem in the beginning but now I can't even make it work. I'm sorry I can't provide a more detailed description than that:)

@as-cii any updates on this? I still can't seem to make it work - just tested the contextual alternates in chrome browser where it worked perfectly.

I tried to reproduce it like described in this comment: https://github.com/atom/atom/issues/7142#issuecomment-110263393
And in my case it seems to work fine:

Maybe platform related? I'm on OS X 10.10.4, Atom 1.0.3(-6efb48d).

@simurai This is weird - it didn't work yesterday for me on 10.10.4 and 1.0.2 but now it does. Oh well, sorry for the misreport. Closing this :smile:


Upgrading typescript transpile target to ES2020 in build-common

Description
Upgrading typescript target to ES2020 in build-common. After this, I will upgrade the packages depending on this to new version of build common where the target is ES2020.
This change is made so as to decrease the bundle size across packages. More info in the work item:
https://dev.azure.com/fluidframework/internal/_workitems/edit/2772

I noticed you deleted the "Breaking Changes" section of the PR description template despite this being a breaking change. I think it would be better to include that section and populate it accordingly. You did include the update to BREAKING.md which is probably the most important though, so that's good.

@jatgarg in which FF version would we be expected to see the change to use ES2020? Was that in internal 4.0?

@christiango This is the work item which is scheduled in current sprint: https://dev.azure.com/fluidframework/internal/_workitems/edit/2772 which is going to consume this change. I am already working on it but there has been some build issues which I need to fix. It should land in 4.x.x but i think FFX will consume next major only mostly which would be 5.0.0.


Don't truncate genres and etc in -Find?

When using -Find command, I would like to see all the information in the output with nothing is being truncated to ..., especially for Genres and ScreenshotUrl.
I tried -Verbose switch it did not do anything.
How to achieve this?

Can you give an example of which movie is giving you ... outputs? Also the exact command you're running if possible.
None of the fields should be truncating, but there may be an error somewhere that I've missed.

Example:  Javinizer -Find IPX-497 -Aggregated
Search               : IPX-497
Id                   : IPX-497
AjaxId               : 440755
JavlibraryUrl        : http://www.javlibrary.com/en/?v=javme2yozu
Title                : BEAUTY VENUS VII
AlternateTitle       :
Description          :
ReleaseDate          : 2020-07-11
ReleaseYear          : 2020
Runtime              : 243
Director             : Usa-pyon.
Maker                : Idea Pocket
Label                : Dish
Series               : BEAUTY VENUS
Rating               :
RatingCount          :
Actress              : {Hatsukawa Minami, Sakamichi Miru, Kaede Karen}
Genre                : {Blow, Squirting, Slut, 4HR+…}
ActressThumbUrl      :
CoverUrl             : https://pics.r18.com/digital/video/ipx00497/ipx00497pl.jpg
ScreenshotUrl        : {https://pics.r18.com/digital/video/ipx00497/ipx00497jp-1.jpg, https://pics.r18.com/digital/video/ipx00497/ipx00497jp-2.jpg,
                       https://pics.r18.com/digital/video/ipx00497/ipx00497jp-3.jpg, https://pics.r18.com/digital/video/ipx00497/ipx00497jp-4.jpg…}
TrailerUrl           : {https://awscc3001.r18.com/litevideo/freepv/i/ipx/ipx00497/ipx00497_dmb_w.mp4}
DisplayName          : [IPX-497] BEAUTY VENUS VII
FolderName           : IPX-497 [Idea Pocket] - BEAUTY VENUS VII (2020)
ScreenshotFolderName : extrafanart
ScreenshotImgName    : fanart
ActorImgFolderName   : .actors
FileName             : IPX-497
PosterName           : folder
ThumbnailName        : fanart
TrailerName          : IPX-497-trailer
NfoName              : IPX-497
OriginalFileName     :
OriginalBaseName     :
OriginalDirectory    :
OriginalFullName     :
PartNumber           :

Notice the genre line is Blow, Squirting, Slut, 4HR+…
The full list should be Blow, Squirting, Slut, 4HR+, Slender, Digital Mosaic

settings.ini

[Main]
scrape-r18=True
scrape-r18zh=False
scrape-dmm=False
scrape-javlibrary=True
scrape-javlibraryja=True
scrape-javlibraryzh=False
scrape-javbus=False
scrape-javbusja=False
scrape-jav321=False
Actress scrapers
scrape-actress-en=True
scrape-actress-ja=True
[General]
Maximum number of threads to sort with if parameter '-Multi' is applied (range 1-15)
multi-sort-throttle-limit=5
move-to-folder=True
rename-file=True
Available tags for file/folder rename string

I do not recommend changing the filename other than  as you may have to manually rename files if you need to re-sort them at a later date
rename-file-string=""
rename-folder-string=" [] -  ()"
cms-displayname-string="[] "
actors-name-delimiter=", "
poster-file-string="folder"
thumbnail-file-string="fanart"
trailer-file-string="-trailer"
nfo-file-string will only apply if create-nfo-per-file=False
nfo-file-string=""
screenshot-folder-string="extrafanart"
screenshot-img-string="fanart"
actorimg-folder-string=".actors"
Max-title-length will limit the length of your  string
max-title-length=100
Max-path-length will limit the sorting of a file if its full path is greater than this number
max-path-length=255
This option will allow Javinizer to ignore video files below a certain size (in MB)
minimum-filesize-to-sort=0
included-file-extensions=asf,avi,flv,m4v,mkv,mp4,mov,rmvb,dat
excluded-file-strings=-trailer.,-5.
Allows you to use a regex string to match files if the default Javinizer matcher doesn't work
(e.g. In regex ([a-zA-Z|tT28]+-\d+z{0,1}Z{0,1}e{0,1}E{0,1})(?:-pt){0,1}(\d{1,2})? , "[ABP-123] Title text-pt3.mp4", match 1 is "ABP-123, match 2 is "3")
regex-match=False
The match value of your movie ID (e.g. "ID-112")
regex-id-match=1
The match value of your movie part number (e.g. "2")
regex-pt-match=2
regex=([a-zA-Z|tT28]+-\d+z{0,1}Z{0,1}e{0,1}E{0,1})(?:-pt){0,1}(\d{1,2})?
[Metadata]
General metadata options
If you use Emby/Jellyfin, create-nfo-per-file is required (nfo is required to have the same filename)
create-nfo=True
create-nfo-per-file=True
download-thumb-img=True
Download-poster-img requires download-thumb-img to be true
download-poster-img=True
download-screenshot-img=False
download-trailer-vid=False
download-actress-img=False
translate-description=True
View language codes: https://developers.google.com/admin-sdk/directory/v1/languages
translate-description-language=en
Use this if you want R18 series names to be set as clickable tag in Emby. If you primarily use Plex, you can set this to false.
add-series-as-tag=False
True = FirstName LastName / False = LastName FirstName
first-last-name-order=False
This option will convert actress names matching 'Alias' in r18-thumbs.csv to their original full name
convert-alias-to-originalname=True
This will convert all JavLibrary genres to their R18 counterparts to keep a consistent genre schema. If you want to use JAVLibrary genres, set this to false.
normalize-genres=False
List of genres to ignore in comma separated format (no spaces)
ignored-genres="Featured Actress,Hi-Def,Blu-ray"
Metadata scraping priorities
Javinizer will fail the sort on a movie if any fields listed in required-metadata-fields is null
required-metadata-fields=coverurl,genre,id,maker,title,releasedate,releaseyear
actress-priority=javlibrary,r18
actressthumburl-priority=r18
alternatetitle-priority=dmm
coverurl-priority=r18,dmm,javlibrary
description-priority=dmm
director-priority=r18,javlibrary
genre-priority=javlibrary,r18
id-priority=r18,javlibrary
label-priority=r18,javlibrary
maker-priority=r18,javlibrary
rating-priority=dmm
ratingcount-priority=dmm
releasedate-priority=r18,javlibrary,dmm
releaseyear-priority=r18,javlibrary,dmm
runtime-priority=r18,javlibrary,dmm
series-priority=r18
screenshoturl-priority=r18,dmm
title-priority=r18,javlibrary
trailerurl-priority=r18
[Locations]
These locations will only be used if you are running Javinizer with the -Apply parameter
input-path="C:\Downloads\Unsorted"
output-path="C:\Downloads\Sorted"
[Emby/Jellyfin]
You can create an Emby/Jellyfin API key under Dashboard -> Advanced -> Security
server-url=<IP_ADDRESS>:8096
server-api-key=
[JavLibrary]
set-owned=False
username=
session-cookie=
request-timeout-sec=90
[Other]
Log path will default to the javinizer.log file inside your module directory
log-path=
check-updates=True
verbose-shell-output=True
debug-shell-output=False

Did not change much besides Metadata scraping priorities
I am using PowerShell 7.0.2

Ah, got it. That would actually be a  PowerShell console-specific issue with truncating objects.
If you set in your console:
$FormatEnumerationLimit = -1

then the output shouldn't be truncated. You'll need to set this value every time you re-open your console unless you add that command to your PowerShell profile. You could also assign the Javinizer command to a variable to reference certain fields.

Ahh ok it worked. Thank you.


Editor UI: 2d viewport

Merge this with Editor UI basic tour?
Did the toolbar's tools change? Scale, change obj pivot
Mention Alt RMB to pick through even if not new (+ corresponding tool)
Compare the old and new layout
Zoom in and out with KBD

Closing this, video is up on dropbox, I can reopen the issue if there is something missing

Just watched it, all good, thanks :)


Fill regular block comments correctly

Right now fill-paragraph fills non-rustdoc block comments of the following form:
/* Four score and seven years ago our fathers brought forth on this continent a new nation, conceived in liberty, and dedicated to the proposition that all men are created equal. */

Like so:
/* Four score and seven years ago our fathers brought forth on this
/* continent a new nation, conceived in liberty, and dedicated to the
/* proposition that all men are created equal. */

This doesn't work very well because Rust comments nest properly. This patch makes these comments format like so:
/* Four score and seven years ago our fathers brought forth on this
 * continent a new nation, conceived in liberty, and dedicated to the
 * proposition that all men are created equal. */

Which works a whole lot better. :-)

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @huonw (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
Please see the contribution instructions for more information.

I've fixed the failing tests and added a test for the fix.

Third time's the charm.

Thanks!


[Bug]: Screen To Gif doesn't run on ARM64 even after installing .NET

Brief description of your issue
Tracking external Issue:

NickeManarin/ScreenToGif/issues/1075

Steps to reproduce
winget install screentogif -s winget
-or-
winget install screentogif -s msstore
Expected behavior
After install succeeds I can launch Screen To Gif.
Actual behavior

Environment
PS C:\Users\denelon> winget --info
Windows Package Manager v1.2.10271
Copyright (c) Microsoft Corporation. All rights reserved.

Windows: Windows.Desktop v10.0.22000.526
Package: Microsoft.DesktopAppInstaller v1.17.10271.0

winget install screentogif -s msstore

Off-topic, but does the Microsoft Store have a manual review step for win32 apps like the community repository does? It seems like apps that don't run shouldn't make it into the store, although they do here because I'm the only mod with a arm64 device and I rarely test on it :/

Raspberry Pi 4?

Surface Pro X

Surface Pro X

I don't know what all gets tested for the Microsoft Store. I've mentioned this to them.


[RFC] redirect to origin site after login/signup

Objective

After login/sign up from any RDS site the user should get redirected to the origin of the request rather than the main site

Procedure

Setup a route for 'goto' from here to take a URL from a query and redirect the user to the destination.
Tweak the auth handler to redirect to /goto/?state=<TARGET_URL | ORIGIN_URL>
the origin_url would be taken from the request

Request will look like this.
https://github.com/login/oauth/authorize?client_id=<CLIENT_ID>&state=<ORIGIN_URL> this is how the request will look like on the frontend and later will be redirected to the backend

@ivinayakg How do you plan to get the origin URL?

Implementation of this Feature Across RDS

RFC for status site
RFC for member site
RFC for crypto site
RFC for my site
RFC for dashboard site


Explicit initialization

Initializing immediately after the <parametric-svg> is created is what most developers probably want.
But most are not all. I need to provide an option to intialize manually and turn off auto initialization.

Moved to https://github.com/parametric-svg/-/issues/19.


test for reiterated inherited slots, and related cleanup

https://github.com/microbiomedata/nmdc-schema/issues/1597

Rely on inheritance from parent classes. Don't reiterate / repeat slots if they're inherited.


Bug: Copy mintter.xyz URL button does not have feedback

Problem
In testnet, when trying to copy a document URL, the toastbar appearing is blank even thought the link is copied sucessfully.
https://github.com/MintterHypermedia/mintter/assets/11684004/77a981bf-04c8-4b19-9a61-115bec302a1c
Steps to Reproduce
Run the app in testnet
Write something on a new document,
publish
copy document URL
Expected Behavior
I would like to see "Link successfully copied" or smth.
Debug Info

Oh! this is because we don't have proper dark mode support inside toasts. I'll work on this


Generate Makefile for build under OS X

This pull request brings ability to generate a Makefile for OS X and Linux (not tested). The request includes the 'find' routine which tries to determine location of sc2api headers and libraries on the target system.
Unfortunately nobody has packaged sc2api yet so  we don't know how the package structure will be composed. Here we assume that:
a. Either /opt/local/include or /usr/local/include or /usr/include contains sc2api and sc2utils folders with proper headers inside.
b. The sc2api folder mentioned above contains the following folders inside:

the proto/ folder with autogenerated starcraft2 protocol headers.
the contrib/protobuf/src folder which contain Protobuf code (provided with sc2api package).

c. Either /opt/local/lib or /usr/local/lib or /usr/lib contains sc2api folder with all required libraries inside.
To build the project:
# Generate a Makefile
$ cmake .

# Build
$ make

VS solutions could be generated in the same way if somebody improves the cmake's files. That will allow to eliminate the .vs folder completely and avoid manual edition of solutions files.

Thanks!

@alkurbatov how can I get this sc2api folder from the (c) on macOS?
I build the https://github.com/Blizzard/s2client-api locally but the layout looks different.

@vors if you build all the libs then you should place the libs into:
alkurbatov@Vika:~ $ ls /opt/local/lib/sc2api
libcivetweb.a       libprotobuf.a       libsc2api.a         libsc2protocol.a
libprotobuf-lite.a  libprotoc.a         libsc2lib.a         libsc2utils.a
Regarding headers structure and reasons behind it please refer to:
https://github.com/davechurchill/commandcenter/issues/21#issuecomment-323166029

Cool, thank you for the explanation! I didn't work much with cmake and make before.
I tried to do a make install from s2client-api and hit this issue https://github.com/Blizzard/s2client-api/issues/90
I guess will copy libs manually to workaround it.


How to execute raw SQL statements in ent, any examples?

Hey! Please, use client.Debug() for this. For example:
client.Debug().T.
    Query().
    All(ctx)

client.Debug().T.
    Create().
    SetF(v).
    Save(ctx)

Closing, but please feel free to join our Discord community in case you need more help with this 😎

Hey! Please, use client.Debug() for this. For example:
client.Debug().T.
    Query().
    All(ctx)

client.Debug().T.
    Create().
    SetF(v).
    Save(ctx)

Closing, but please feel free to join our Discord community in case you need more help with this 😎

Thanks, but I don't want to depend on model,  For example：
select A.id, name from table1  A join (select uid as id from table2) B on A.id=B.id order by A.id desc;
I want the implementation to be what is written above， Where should this raw sql be placed

Oh, sorry. I misread the question above. Please, see the custom modifiers: https://entgo.io/docs/feature-flags#custom-sql-modifiers


There is no way to use the GPU.

I was able to run your project successfully, but I noticed that the GPU utilization was 0. However, my CUDA is available and I tried to resolve the issue but was unsuccessful.
Can you help me clear up my confusion? Thank you very much!

what does this part of the notebook print in your code (1st cell):

Please ask how long it takes you to complete a training (epochs=100), I successfully displayed Using cuda, but the GPU usage is still 0, the training time is very long。

I don't remember exactly but I am pretty sure that I let it run over night. Moreover the reason your GPU utilization is low might have to do with the fact that models are very lightweight. During the training the CUDA was indeed working for me.

Also you can use the weights I provided. You don't have to train it yourself.

Hi if its working can I close this issue or is further help needed ?

May I ask if there is a corresponding paper for this project? If so, could you please provide information or links to relevant papers?

No, I made this project just for learning how to work with audio data.

Are you working on a research paper ?

我目前没有在写论文。但是我正在做这个领域的学习和研究。另外，非常感谢您耐心的回复。

I am not writing a paper at present. But I am doing learning and research in this field. In addition, I am really grateful for your patient reply.

Oh yeah no worries brother. When I was working in the audio domain I referred to this youtube channel: https://youtube.com/@valeriovelardothesoundofai?feature=shared. You can check it once. It might be helpful.


NIFI-766 Added icon on connection when backpressure is enabled

Here is a proposition to display an icon on a connection when back pressure is enabled.
At the moment, there is no icon displayed whether back pressure is configured or not. (I am not sure it is worth adding information that is not that important to users: back pressure is configured by default)
First time I take a shot at UI dev, please review with care ;)

Reviewing...

@pvillard31,
Following some of the discussion on the mailing list recently and the original commentary on the JIRA [1], I'd like to propose shifting from an icon based approach when back pressure is engaged to a progress bar style approach where the user can quickly get a sense of how 'full' the queue is currently.

The mockup shows various configuration scenarios.

Expiration (clock icon)
Object and Data size backpressure (left and right bars respectively)
Empty bar - backpressure not configured
Partial bar - backpressure configured, partial represent precentage full
Full solid bar - backpressure engaged

If you're up for some additional cycles on this PR I'd be happy to work through the changes with you. If not, I'm happy to take what you started and continue toward the mockup above.
Thanks!
[1] https://issues.apache.org/jira/browse/NIFI-766

Can someone else finish up the review of this PR? I helped contribute to this PR and would prefer someone else's eyes on. Thanks!

@mcgilman @pvillard31 I made one slight change to ConnectionStatus to rename the getters/setters from setBackpressureDataSizeThresholdLong to setBackpressureBytesThreshold to align with the existing naming convention. Otherwise, all looks great! Tested and verified that all worked as expected. The UI looks great. Thanks for updating this, guys. It's been a long time coming and will be very helpful! +1 merged to master.


TASK: Set lastSuccessfulAuthenticationDate on successful login

@kdambekalns,
thats absolutely right :) My cancel was 30 seconds to late - you never have been that fast :)
In july, I already asked @robertlemke, about the background behind the transient account, and why the local account is not used. We use the package for securing the Neos backend, and there are indeed some operations on the user that depend on the account being a persisted account.
Are there any security considerations to not store the account?


Adds CSS file with variables

Addresses #15, and adds a .css file with the swatches as CSS variables.

LGTM 👍 Thanks!


Add GPU recommendation generation mechanism

Description
Please describe the issue or feature and the summary of changes made to fix this.
Fixes # (issue)
Type of change

[ ] Bug fix
[ ] New feature
[ ] Docs update
[ ] Breaking change (What changes might users need to make in their application due to this PR?)
[ ] Requires DB changes

How has this been tested?
Please describe the tests that were run to verify your changes and steps to reproduce. Please specify any test configuration required.

[ ] New Test X
[ ] Functional testsuite

Test Configuration

Kubernetes clusters tested on:

Checklist :dart:

[ ] Followed coding guidelines
[ ] Comments added
[ ] Dependent changes merged
[ ] Documentation updated
[ ] Tests added or updated

Additional information
Include any additional information such as links, test results, screenshots here

This has been split into separate PRs and is no longer needed


Argo stress test

Summary
Currently, for each release, we do not provide the stress test. The stress test would help us to understand the system performance like throughput and scalability for each release.
Motivation
As introduced above
Proposal
We can test Argo runtime performance w.r.t the number of pods, jobs and concurrent workflows.
How do you think this should be implemented?

Message from the maintainers:
If you wish to see this enhancement implemented please add a 👍 reaction to this issue! We often sort issues this way to know what to prioritize.

CPU stress, memory stress, network stress and random fail with backlog would be interesting.
Max archived
Max num  cronworkflows
Max nun templated workflows
Max num cronworkflow start spike

See #3751

This dovetails with the FMEA testing I've been doing recently.
Essentially I run a workflow that create other workflows. This workflow in parameterized as follows:

X - how many workflows to create
Y - how many pods each workflow then create

Initially scheduling the workflow you'll see "Deadline exceeded" - there is a bug in the DAG code (#3905) that needs fixing to address this.
Then you'll see the following errors

Operation cannot be fulfilled...Conflict  - I'm not sure what is causing this
pod ... deleted - this is caused by Kubernetes eviction

What I'm doing next in running various scenarios, e.g. 1000x1 (1000 concurrent workflows with 1 pod).

See #3918


fix: log relayer failures as errors

#269  👈 (View in Graphite)
main

This stack of pull requests is managed by Graphite. Learn more about stacking.


Show a more useful error message when using an invalid escape sequence

Repro
.Message = '^a'

Expected
An error message that indicates that it's an invalid escape sequence, and that only $, ^, ' (in single-quoted strings), and " (in double-quoted strings) need to be escaped.
Actual
The error message is:
Syntax error: Unexpected input.
Expecting to see one of the following:
 • single-quoted-String-end: "'"
 • String-literal (example: "abc")

I notice that FASTBuild allows escaping any character that comes after a ^, and not just the minimal set (source).
So maybe this issue should actually be to allow escaping any character?

Update from Franta (the FASTBuild maintainer): it's expected behavior to allow escaping any character with ^, and not just the minimal set.
So closing this issue in favor of #52.


This training size is less than 44G (train_aug_120x120.zip)

Hi,
Thanks for sharing your amazing code!
I am trying to run your training code. In Training 2, you mentioned
"Download training data from [3DDFA]: train_aug_120x120.zip and extract the zip file under the root folder (This training size is about 44G)."
However, when I open 3DDFA, I only find a train_aug_120x120.zip with 2.15G. After extracting, it only has 2.8G, which is far less than 44G.
I am wondering, am I missing some information to get the whole dataset?

Yes, we use this training data. It should contain about 680K images.


Use the Conan.io Package manager

This PR will fix building on Linux + it will enable support for all compilers having proper C++14 support (so e.g. vs2013 is back in business) (excluding MinGW since I didn't test it)
The build procedure changes heavily. All dependencies get build on the developer machine using the developer compiler so no incompatibilities anymore.
It does use caching: If the dependency exists in prebuilt form on conan.io it will download it from there instead of building it. Furthermore if you already built that version of the dependency you won't need to do so again (it gets saved in your user directory).
Hence you won't need to install any dependencies from your distros package manager except for:

python
doxygen
conan
cmake
git

Build procedure: https://piratenpad.de/p/conan

Building is a three step procedure:
Run Conan (to get our dependencies)
Create a new build folder inside the inexor-code repo
open the [command line](link to smwh explaining that)
cd (change directory) into the build folder
type "cd  or "cd <path_to_subfolder>"
you can use tab for auto completion of names
".." is the name of the parent folder so type "cd .." to go one up
type conan install .. --build missing
this will get all dependencies from the cache servers (or  compile them if they havent been found)
On first invocation this could take some time
and if you switch compilers (or between Release and Debug). Otherwise results are cached.
Run CMake (Create your specific build files) [we could eliminate this point and run cmake with conan: pro: settings missmatched never happen. con: no GUI, flags could be harder
... rest is in the wiki
Notes:
conan install --build=missing fürs script
visual studio multi configuration not supported
git is required now on windows!

TODOS:

[x] change from conanfile.txt to conanfile.py
[x] add a create_visual_studio_project.bat
( optionally add a build_with_gcc.sh )
[x] adjust the install command to install properly
[ ] find a place for the license info of our dependencies

FYI, as soon as Conan works and is merged I will fix, upgrade and make Travis a lot more flexible.

nice :) Ill merge today eve or the next days if @aschaeffer is online

I stroke the last point called "find out about the used packages legal information".
Since this should be part of a distribution.
We could easily generate a file with the contents of that file then.
conan info --only=license (inside the main folder)  will list all used dependencies and its licenses

okay, all points are cleared, can be merged as soon as @aschaeffer tells me its running (building is verified by travis already) on linux

4/4 checks passed, CI is working again :)
Lets merge this today!

The most important questions are though:
Is the rpath already correctly set for linux and is the libudev error back?
In other words: does it start?

merged


fix/remove sitemap

Q
A

Bug fix?
yes

New feature?
no

BC breaks?
yes

Deprecations?
no

Related tickets

License
MIT

Combines:
https://github.com/BitBagCommerce/SyliusCmsPlugin/pull/321
with https://github.com/BitBagCommerce/SyliusCmsPlugin/pull/317
(completes sitemap plugin removal after https://github.com/BitBagCommerce/SyliusCmsPlugin/commit/22bb97d816e41759976de65d238e55b40e137d0e )
combines changes in docs, with moving sitemap plugin to optional dependencies
it should:

describe how to install sitemap as an additional dependency and use sitemap providers from this bundle
make sure all tests pass without sitemap plugin

Great :-) Hope this will be included soon, it seems a lot of users don't want to have it installed by default.

Great :-) Hope this will be included soon, it seems a lot of users don't want to have it installed by default.

@patrick477 Could this be included in the next release?

@patrick477 Could this be included in the next release?

yes, it will be in v3.0

yes, it will be in v3.0

The first beta of v3 still includes it, @patrick477
In the meanwhile I've also released v2.0.0-alpha.1 of the Sitemap Plugin which requires some changes because of BC. Will you adjust the providers or do you want a PR? We can also think about splitting the providers into a separate repository/package that both requires the CMS Plugin and the Sitemap Plugin and combines best of both. WDYT?

@leszczuu you should also remove import sitemap from config.yml otherwise it throw error when install from 3.0 branch.
" Bundle "SitemapPlugin" does not exist or it is not enabled. Maybe you forgot to add it in the "registerBundles()" method of your "App\Kernel.php" file? in @SitemapPlugin/Resources/config/config.yaml (which is being imported from "SyliusCmsPlugin/src/Resources/config/config.yml"). Make sure the "SitemapPlugin" bundle is correctly registered and loaded in the application kernel class. If the bundle is registered, make sure the bundle path<EMAIL_ADDRESS>is not empty.


CRUD Personas with fixes

Summary
This PR modifies the object Persona and PersonaCreate, changing the fields voiceId to Voice object and faceId to Face object
Changes

[x] Modified Persona
[x] Modified PersonaCreate

Related Issues
N/A
Type of Change
This change solved the comments posted on the review of the previous PR created by @rquesada [https://github.com/pAI-OS/paios/pull/4]
Checklist

[x] I have read the CONTRIBUTING documentation.
[x]  I have performed a self-review of my own code.
[x]  I have added tests that prove my fix is effective or that my feature works.
[x]  I have updated the documentation (if applicable).

Screenshots (if applicable)

Additional Context
Tested locally using Swagger.
Based on the premise that we are not expecting that faces and voices to be modified frequently, so  the approach we considered here was to create an "assets" folder (in the front-end) to store the images, videos and audios. Then it was only going to be necessary to store the id of voice and face to help us associate the asset with the voice and face.
For example:
Given the object Persona:
      {
        "name": "Mari",
        "description": "Mari A",
        "voice_id": "x4te5a69-40d6-4246-8d53-f4c777be8080",
        "face_id": "7ffe5a69-40d6-4246-8d54-f4c777be6989",
        "id": "91a7542f-da52-46ab-85b9-08f871722e93"
      }

The frontend will be able to load the files:
:/assests/audio/x4te5a69-40d6-4246-8d53-f4c777be8080.mp3
:/assests/face/7ffe5a69-40d6-4246-8d54-f4c777be6989.jpg
:/assests/video/7ffe5a69-40d6-4246-8d54-f4c777be6989.mp4

Rebased the PR commits onto develop, fast-forwarded develop to include them, and fixed a warning in 67edb65.

It is already merged in other commit


Return multiple sources instead of using frontend fields

For example, now when you do a request giving an input and restriction enzymes, you will get back all possible outcomes in output_list, and their boundaries in fragment_boundaries.
Now, the possible outcomes are inside the source, and then this field is not saved when we export the source, and there are also some extra fields like output_index.
It would make more sense to return two separate lists of sources and sequences, where the first source would give the first sequence, the second source the second sequence, etc.
Instead, the response could be something like:
{
  sources: [
    {}, {},
  ],
  sequences: [
    {}, {},
  ],
};

Missing things:

[ ] Change genbank entrypoint
[ ] Tests for genbank
[ ] Tests for files


[misc] Update automation steps for webmanu-system-android-tests

ECS2-8A:
Impacted TCs num(approved): New 0, Update 3, Delete 0
Unit test Platform: Crosswalk Project for Android 18.46.462.0
Unit test result summary: Pass 3, Fail 0, Blocked 0
https://crosswalk-project.org/jira/browse/XWALK-5583

LGTM


Create Translator action

Should fix #1099
All credit to @mw80, reworked from #1320

The translator.php is mostly for testing, this should be integrated on the main page.


update Activiti/activiti-dependencies to master

UpdateBot pushed version changes from the source code in repository: Activiti/activiti-dependencies ref: master

UpdateBot commands:
updatebot push --ref master https://github.com/Activiti/activiti-dependencies.git

https://github.com/Activiti/activiti-examples/pull/23 is more up to date.


Replace deprecated cf-mysql release with PXC (not the BOSH release)

Description
This pr removes the cf-mysql release which is no longer maintained and instead deploys the official percona-xtradb-cluster chart as a subchart using a SUSE flavored pxc image.
Motivation and Context
cf-mysql no longer compiles on the SUSE stemcell and it's no longer be worked on so we need another solution for an embedded database.
Closes #270. Closes #312.
How Has This Been Tested?
I've deployed this successfully to my local kind cluster. All components come up properyl, apps can be pushed successfully. CATS are passing partly, the failures could be related to a lack of resources.
Caveats:

rotation of the database secrets currently does not work
the scaling of the pxc deployment has to happen in a different place than the scaling of the other cf components, i.e. percona-xtradb-cluster.replicas vs. sizing.*.instances. I couldn't find a way to make it configurable from the same place.
switching between embedded and external database currentlyl happens using two boolean flags one of which has to be set to true. This is due to the fact that conditional subcharts can only be enabled by setting a flag to true. We might want to change the condition of the existing external_database flag to !embedded_database to make this work using only one flag.

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code has security implications.
[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.

The issue with the StatefulSet API version also got fixed by https://github.com/SUSE/kubecf/pull/393/commits/4328e181004a5668963f03d3b7c5fdc8742c4441.

@aduffeck Please, take a look into setting sizing.database.instances=3 and running smoke-tests. I didn't have enough time to investigate why it is very flaky.

The cf-deployment bump to 12.33 would also bump pxc-release from 0.21.0 -> 0.22.0:
https://github.com/cloudfoundry/cf-deployment/compare/v12.18.0...v12.33.0#diff-f39617caec1965e56248ce1bf556db4dR2423
Although its a minor version release, something to be mindful of while testing this PR.

The cf-deployment bump to 12.33 would also bump pxc-release from 0.21.0 -> 0.22.0:
<EMAIL_ADDRESS>Although its a minor version release, something to be mindful of while testing this PR.

@bikramnehra This PR has nothing to do with the BOSH pxc-release.


Can Lumos be combined with reinforcement learning-based ABR algorithms?

Sure. Please refer to "Accurate Throughput Prediction for Improving QoE in Mobile Adaptive Streaming" (TMC 2023), VI. B -- Integrated Into Other ABR Algorithms. Besides, the following works may also help:

PRIOR: deep reinforced adaptive video streaming with attention-based throughput prediction (NOSSDAV 2022)
Data-Driven Bandwidth Prediction Models and Automated Model Selection for Low Latency (TMM 2021)


SystemCheckError: System check identified some issues:

SystemCheckError: System check identified some issues:

ERRORS:
srpy.Article.checker_runtime: (fields.E300) Field defines a relation with model 'SchedulerRuntime', which is either not installed, or is abstract.
srpy.NewsWebsite.scraper: (fields.E300) Field defines a relation with model 'Scraper', which is either not installed, or is abstract.
srpy.NewsWebsite.scraper_runtime: (fields.E300) Field defines a relation with model 'SchedulerRuntime', which is either not installed, or is abstract.

I just copy the tutorial, but something goes wrong.

Found your problem? Did you add dynamic_scraper to your INSTALLED_APPS setting?


fix os compatibility check and add service configuration

I tested it with an archlinux box and it seemed to work. The only breaking point was the service reload wich was done through a ufw reload command. I switched to the ufw module so please check if that works for you now. thx

Thank you @franklinkim it seems to work now!


#945 - Verly long service lists are now scrollable

#945
Fixed

Pull Request Test Coverage Report for Build 899

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 51.443%

Totals

Change from base Build 887:
0.0%

Covered Lines:
3779

Relevant Lines:
6584

💛  - Coveralls


Documentation site is outdated

https://docs.docker.com still show v1.6

Hi!
Please read this important information about creating issues.
If you are reporting a new issue, make sure that we do not have any duplicates already open. You can ensure this by searching the issue list for this repository. If there is a duplicate, please close your issue and add a comment to the existing issue instead.
If you suspect your issue is a bug, please edit your issue description to include the BUG REPORT INFORMATION shown below. If you fail to provide this information within 7 days, we cannot debug your issue and will close it. We will, however, reopen it if you later provide the information.
This is an automated, informational response.
Thank you.
For more information about reporting issues, see https://github.com/docker/docker/blob/master/CONTRIBUTING.md#reporting-other-issues

BUG REPORT INFORMATION
Use the commands below to provide key information from your environment:
docker version:
docker info:
uname -a:
Provide additional environment details (AWS, VirtualBox, physical, etc.):
List the steps to reproduce the issue:
1.
2.
3.
Describe the results you received:
Describe the results you expected:
Provide additional info you think is important:
----------END REPORT ---------
#ENEEDMOREINFO

Thanks @lalyos. We're aware of this. The docs are being updated as we speak. Closing this issue.


Cannot debug graph visualisation

I attempt to make a stab at the marshalling null values for COM, but stuck with producing correct IL. I decide that I'm smart guy and can enable debugging of the DependencyGraph. I'm not sure if this was correct decision, but that's not root cause of the issue which I encounter.
So I start follow Documentation\how-to-debug-compiler-dependency-analysis.md

I setup csproj and include <IlcGenerateDgmlFile>true</IlcGenerateDgmlFile>
I configure to use locally built version of CoreRT.
Launch VS as admin and open ILCompiler-DependencyGraph-Viewer.sln
Launch dotnet publish as admin
Launch ILCompiler-DependencyGraph-Viewer inside VS

events was not there.
Under debugger, line below return false into restarted variable.
https://github.com/dotnet/corert/blob/7f4555b5adedbc628842e2146205d61c592e5643/src/ILCompiler.DependencyAnalysisFramework/ILCompiler-DependencyGraph-Viewer/Program.cs#L258
I suspect that this is related to enabling ETW somehow, or maybe I miss some other step?

Can you try leaving out this: <IlcGenerateDgmlFile>true</IlcGenerateDgmlFile>? I don't think the dependency graph support multiple simultaneous logging facilities.

I don't think the dependency graph will help you though. Try adding --ildump path\to\some\file.il to the ILCompiler command line. This will generate a file with all the generated IL that you can set breakpoints on/step in the debugger.
If you're not even getting that far (e.g. RyuJIT is crashing while compiling the method), your only option is to look at the generated IL in the debugger. We have a debugger visualizer for the MethodIL class so that the VS debugger can show you the IL in a nice format. Set up a breakpoint and inspect the generated MethodIL somewhere around PInvokeILEmitter.EmitIL

Removing <IlcGenerateDgmlFile>true</IlcGenerateDgmlFile> indeed help. I was confused by this line:
https://github.com/dotnet/corert/commit/6d088c250fcd1ef9fe4f7a8e3a4dec61ef3caab5#diff-b6a2437f0be65e16801de473eb0316cdR10
I now realize that this is out of context. But maybe I can add word that dependency graph do not support multiple simultaneous logging facilities, so make sure that you do not set IlcGenerateDgmlFile or invoke ILCompiler ith DGML generation on.
I will try --ildump, thanks. that seems to be what I need. Do you know how to fast sketch IL? or you just know it by heart 😄

Yup, that line would be useful to add.
I used to write a piece of equivalent C#, compile with optimizations on, and disassemble that. But yes, at this point I know most of the important patterns by heart.

Sign. I hope that you know some C# godbolt which can allow me write snippet and see the view of IL. Upon search I found https://sharplab.io/ Is it helpful to use? Because IL optimization likely can be trivial. Or I am miss something important? I'm more or less know IL. Have rusty knowledge and lack of practice.
Also for Windows Forms DGML output and DependencyGraphViewer almost impractical to use 200Mb for trivial app.

Yeah, sharplab.io should work. I use csc.exe/ildasm.exe but that's just because I grew up without internet.
Yeah, the DGML is proportional to the size of the app. Windows.Forms drags in a lot of stuff.


cli schema generation insert Nullable with sqlite INTEGER PRIMARY KEY

Setup
Versions

Rust: 1.32
Diesel: 1.4.0
Database: sqlite
Operating System linux (ubuntu 16.04)

Feature Flags

diesel: ["sqlite"]

Problem Description
When running diesel migration run with a migration creating a table on an sqlite database, with a field tagged as INTEGER PRIMARY KEY, diesel-cli creates a field id -> Nullable<Integer> which is wrong because the primary key can't be NULL
Steps to reproduce
create a new project
cargo init
diesel migration generate create_table
DATABASE_URL=new.sqlite3 diesel migration run

with this migration
CREATE TABLE data (
    id INTEGER PRIMARY KEY
);

creates this schema.rs
table! {
    data (id) {
        id -> Nullable<Integer>,
    }
}

Checklist

[x]  I have already looked over the issue tracker for similar issues.

[x] This issue can be reproduced on Rust's stable channel. (Your issue will be
closed if this is not the case)

Also according to sqlite documentation
"Unless the column is an INTEGER PRIMARY KEY or the table is a WITHOUT ROWID table or the column is declared NOT NULL, SQLite allows NULL values in a PRIMARY KEY column. " https://www.sqlite.org/syntax/table-constraint.html
So in the the case of non INTEGER primary key, it is right to make the column Nullable

We ask SQLite for this information, and SQLite is telling us that the column is nullable. I agree that it's going to auto increment the rowid even if you didn't ask it to do so when you try to give it null, but I'm not sure we want to special case this when SQLite is clearly retaining this information.
sqlite> drop table data;
sqlite> create table data (id integer primary key);
sqlite> pragma table_info('data');
0|id|integer|0||1
sqlite> drop table data;
sqlite> create table data (id integer primary key not null);
sqlite> pragma table_info('data');
0|id|integer|1||1

Ok then, I'll just add NOT NULL to the field. It seems to do the trick.


istioctl: 1.8.0 -> 1.8.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/istio/istio/releases.
meta.description for istioctl is: "Istio configuration command line utility for service operators to debug and diagnose their Istio mesh"
meta.homepage for istioctl is: "https://istio.io/latest/docs/reference/commands/istioctl"
meta.changelog for istioctl is: ""
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 1.8.1 with grep in /nix/store/krfkr307s1vm7wcmdgvsld2wln0y03r7-istioctl-1.8.1

directory tree listing: https://gist.github.com/0bda73418d0df99460c0891e168c316e

du listing: https://gist.github.com/3b5dede37072f3e211558a58ff170a0f

Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
1 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
istioctl

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/krfkr307s1vm7wcmdgvsld2wln0y03r7-istioctl-1.8.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A istioctl https://github.com/r-ryantm/nixpkgs/archive/9dd8d11c31c3c32e3952512012afd5f97046260c.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/krfkr307s1vm7wcmdgvsld2wln0y03r7-istioctl-1.8.1
ls -la /nix/store/krfkr307s1vm7wcmdgvsld2wln0y03r7-istioctl-1.8.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review 1

1 package built:

istioctl

Maintainer pings
cc @veehaitch @kalbasit for testing.

Result of nixpkgs-review pr 106583 run on x86_64-linux 1

1 package built:

istioctl


change display for balance

delete milli token

if amount is less than 0.00001 near token, show <0.00001

hover the amount to see absolute amount

change style to style-components

One other comment (technically out of the scope of this issue), can we align the "Send Money" button with "Balance"?
Designs

change it without showing absolute atto token


Revert "chore(deps): update rust crate openssl to 0.10.60 [security]"

Reverts https://github.com/rust-lang/cargo/pull/13068
<EMAIL_ADDRESS>switches to OpenSSL v3,
which causes Cargo build failure on loongarch64.
See https://github.com/rust-lang/rust/pull/118541#issuecomment-1837197918

@bors r+

:pushpin: Commit df34bdd8d7b04aef165d6fda880bf9dfe96cb47f has been approved by ehuss
It is now in the queue for this repository.

:hourglass: Testing commit df34bdd8d7b04aef165d6fda880bf9dfe96cb47f with merge 8854c4d90b4b6825c900180fcab36d5f2d2eba02...

:sunny: Test successful - checks-actions
Approved by: ehuss
Pushing 8854c4d90b4b6825c900180fcab36d5f2d2eba02 to master...


Adding optional ES2015 support via Babel

Currently the way to opt-in is to rename a new gulp task. let me know if you think of better ways.
We could also simply enable it by default since this workflow also works with ES<=5 files.
@addyosmani PTAL

Fwiw, @gauntface has been exploring ES6 support via Babel as part of the canonical apps project and has some ideas he wanted to share on different ways we could tackle this. Approaches off the top of my head:

Make Babel the default. Our build pipeline works fine for both ES5 and ES6 source without the end-user needing to do anything. In this option, we would also avoid using an .es6 extension which some folks use. I personally would love this to be the default way of tackling ES6 support.
Make Babel opt-in. Similar to this PR. We decide on an approach and make it a simple case of commenting/uncommenting.
Make Babel extension specific. Support it by default, but only pick up files with an .es6` or similar extension so you're separating your ES6 and ES5 build pipelines.

Looping in @thejameskyle as well as he might have an interest in this.

LGTM from me.
I'd vote just making this the default and only script task.
It's a shame that this, like the rest of WSK, requires hard coding file paths and names to work.

I just updated the script gulp task, comments and readme as per @addyosmani's first comment.
I'd also vote for making this the only and default gulp task.
I agree it would also be nice not to have to hardcode the name of the scripts in the gulpfile. I could probably investigate to see how we could solve this using useref on a separate issue.

I certainly think it would be great by default (I may be a tad bit biased) as there's really no harm if people want to continue only using <=ES5 features.

The .babelrc file support gave me a much better/cleaner (I think) way to opt-in ES6 support. Now:

To enable ES6 support remove the line "only": "gulpfile.babel.js", in the .babelrc file.

I'd still prefer having this enabled by default though ;)
The only down-side is that Babel does modify ES5 files a bit. This doesn't make a difference if you use a browser that supports sourcemaps though...

Can we rebase this against master please? :tophat:

Done!

Can we get the commits here squashed? :steam_locomotive:

Done!

Could this be landed?


Switch to conventional script names

Rename NPM scripts to follow the guidance from Conventional Scripts on script naming.

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Experience/5443 upload page static alert

Applies the StaticAlert component (which was based on the existing implementation of static alerts on the Upload page) to the Upload page
Test Steps:
Note that this behavior should be no different from what is on master, but serves to verify that the refactor has not broken the current behavior

start servers on this branch with yarn run start:localdev from frontend-react and ./gradlew run from prime-router
visit http://localhost:3000/upload and log in as necessary
attempt to upload any non report stream related csv
VERIFY: you see an error message matching screenshot below
go through the necessary steps to upload a valid csv. This may involve setting yourself as a specific sender. If you need help here, lemme know
VERIFY: you see the success message matching screenshot below

Screenshots
Error

Success

Checklist
Testing

[ ] Tested locally?
[ ] Ran ./prime test or ./gradlew testSmoke against local Docker ReportStream container?
[ ] (For Changes to /frontend-react/...) Ran npm run lint:write?
[ ] Added tests?

Process

[ ] Are there licensing issues with any new dependencies introduced?
[ ] Includes a summary of what a code reviewer should test/verify?
[ ] Updated the release notes?
[ ] Database changes are submitted as a separate PR?
[ ] DevOps team has been notified if PR requires ops support?

Linked Issues

Fixes #issue

To Be Done
Create GitHub issues to track the work remaining, if any

#issue

Specific Security-related subjects a reviewer should pay specific attention to

Does this PR introduce new endpoints?

new endpoint A
new endpoint B

Does this PR include changes in authentication and/or authorization of existing endpoints?
Does this change introduce new dependencies that need vetting?
Does this change require changes to our infrastructure?
Does logging contain sensitive data?
Does this PR include or remove any sensitive information itself?

If you answered 'yes' to any of the questions above, conduct a detailed Review that addresses at least:

What are the potential security threats and mitigations? Please list the STRIDE threats and how they are mitigated

Spoofing (faking authenticity)

Threat T, which could be achieved by A, is mitigated by M

Tampering (influence or sabotage the integrity of information, data, or system)
Repudiation (the ability to dispute the origin or originator of an action)
Information disclosure (data made available to entities who should not have it)
Denial of service (make a resource unavailable)
Elevation of Privilege (reduce restrictions that apply or gain privileges one should not have)

Have you ensured logging does not contain sensitive data?
Have you received any additional approvals needed for this change?

Should the CSV transition banner be disappearing when we have a failed upload? Trying to remember if that was clearly defined or not; might need to elevate that one level up if not.


Missing types for programmatic usage with TypeScript and Node

System Info
System:
OS: Linux 4.4 Debian GNU/Linux 12 (bookworm) 12 (bookworm)
CPU: (24) x64 AMD Ryzen 9 5900X 12-Core Processor
Memory: 31.09 GB / 47.91 GB
Container: Yes
Shell: 5.9 - /usr/bin/zsh
Binaries:
Node: 18.12.1 - /usr/local/node-version-manager/bin/node
Yarn: 1.22.19 - /usr/local/node-version-manager/bin/yarn
npm: 9.6.0 - /usr/local/node-version-manager/bin/npm
npmPackages:
@rspack/core: ^0.1.7 => 0.1.7
Details
When trying to use rspack programmatically via node and @rspack/core - I have type errors due to missing internal dependencies.
// index.ts
import * as rspack from '@rspack/core'
console.log(rspack.rspack)

$ npx tsc

../node_modules/.pnpm/@rspack+core@0.1.7/node_modules/@rspack/core/dist/compilation.d.ts:11:24 - error TS7016: Could not find a declaration file for module 'webpack-sources'.

<EMAIL_ADDRESS>implicitly has an 'any' type.

  Try `npm i --save-dev @types/webpack-sources` if it exists or add a new declaration (.d.ts) file containing `declare module 'webpack-sources';`

../node_modules/.pnpm/@rspack+core@0.1.7/node_modules/@rspack/core/dist/compilation.d.ts:16:8 - error TS1259:
 Module '"/home/alshdavid/Development/alshdavid/davidalsh-com/node_modules/.pnpm/@rspack+core@0.1.7/node_modules/@rspack/core/dist/ResolverFactory"' can only be default-imported using the 'esModuleInterop' flag

and so on
These type dependencies are marked as devDependencies in the package.json

However they are not marked as dependencies  or peerDependencies of @rspack/core - so tsc fails
I can add these dependencies to my application manually
Reproduce link
No response
Reproduce Steps
mkdir foobar
cd foobar
pnpm init
pnpm install --save typescript @rspack/core
echo "import * as rspack from '@rspack/core'" > main.ts
echo "console.log(rspack.rspack)" >> main.ts
npx tsc --outDir dist --module CommonJS --strict true --target ESNext main.ts

Did you enable skipLibCheck feature of TypeScipr? You might try compiling with skipLibCheck:true to see if the error still exists.

Hey, thanks for the suggestion. That configuration flag does indeed resolve the compilation issue however I believe using skipLibCheck  is not considered a best practice as it reduces the accuracy of types obtained from libraries (beyond just rspack)

I believe using skipLibCheck  is not considered a best practice as

I agree with you. So you might take skipLibCheck: true as a workaround. Currently, we are the focus on https://github.com/web-infra-dev/rspack/issues/2048 and lack manpower
But we have planned to pre-compile dependencies of Rspack, which should solve this problem.
Thanks for your feedback. It's very useful for us to decide which parts we should concentrate on in the future.

But we have planned to pre-compile dependencies of Rspack, which should solve this problem.
That's perfect, thanks for taking the time to respond!

Tacked in https://github.com/web-infra-dev/rspack/issues/6481 and https://github.com/web-infra-dev/rspack/issues/5867