Repo Change

I updated my vimrc to use the ctrlp fork (kien/ctrlp.vim => ctrlpvim/ctrlp.vim) but I have to manually remove the git checkout to have it clone from the new repo location.  It would be nice if this could have re-cloned the repo on an install or update.

Well, this would be a behaviour change as currently only command that removes anything is PlugClean. Install or Update notify to run Clean when required. Update is already double duty doing install and update of plugins. I prefer the user having to remove it separately, while inconvenient he is aware of what is happening on his system.
Also, I imagine if @junegunn wanted the kind of automatic resolution you described he'd have implemented it by now. He can give his final say when he's back, but I don't imagine he'd go for it.
For now you can make use of command aliases to expand something to PlugClean! | PlugInstall. Note on this last bit, cabbrevs sometimes cause problems (notably they expand in searches (/ or ?), you may want to look at my fork of cmdalias.

I prefer the user having to remove it separately, while inconvenient he is aware of what is happening on his system.

Nicely put. Repo changes are quite rare and I don't think we should risk losing local changes that might be in the directory for saving a few keystrokes for PlugClean. I'm closing the issue, thanks for the suggestion anyway.


Echo Show 1.4 release

Hi,
Do you know when the 1.4 code will be released in Maven Central and corresponding sample apps will be updated to show usage of new Template etc..?
We are starting to optimize our skill which is under development for regular Echo to support Echo show and waiting for these new features.
Thanks

1.4 Code is available on maven central - https://search.maven.org/#artifactdetails|com.amazon.alexa|alexa-skills-kit|1.4.0|jar
We're working on updating the sample skills and should have some examples out shortly!

thanks for the quick reply, looking forward to any kind of documentation describing these new features and how they can be used.  Meanwhile i've switched to the latest 1.4 and browsing the code for hints


Add status/selfDiscovered endpoint to indexer for self discovery of indexer (#10679)

Added the status/selfDiscovered endpoint to indexer. Per the api-reference doc, all services support status/selfDiscovered endpoint. So this change would fix that expected behavior.
Also added example config files for indexer process that can be used to spin up the indexer process.
(cherry picked from commit c2e26d2e1cc2218dbb1b25dc2794787fc43e24fa)

Merging as the tests were failing from before and we have https://confluentinc.atlassian.net/browse/METRICS-2619 to fix them.


Spigot server is downloaded on start even when server.jar is present

Describe the problem
I have a working spigot server with a server.jar and spigot_server-1.20.4.jar present in the data directory.
Even though FORCE_REDOWNLOAD is not set, there is an attempt to download the JAR file each time on server start. Since getbukkit.org currently is down, this attempt fails.
As a workaround, I have hosted spigot_server-1.20.4.jar on my own server and set SPIGOT_DOWNLOAD_URL to it. The suggested fix would be to not re-download the server if server.jar is present.
Container definition
docker run -v ./test:/data \
    -e TYPE=SPIGOT -e VERSION=1.20.4 \
    -p 25599:25565 -e EULA=TRUE --name mc itzg/minecraft-server

Container logs
[init] Downloading Spigot from https://download.getbukkit.org/spigot/spigot-1.20.4.jar ...

I'm also experiencing this issue as well. Thanks for the tip on using the SPIGOT_DOWNLOAD_URL option!

Thanks for reporting this. In #2721 I identified a way to both ensure it tries to get an updated copy of that spigot version or fallback to an existing server file if that fails.

That was fast, @itzg! Thanks a lot! I suggest to update the documentation as well to indicate that an attempt for download will be made every time, even if FORCE_REDOWNLOAD is not set.

Well, there's a subtle difference between an attempt and an actual download is made every time (see curl's -z argument), so I think it will only be more confusing than it helps to make a declaration either way.
In any case, I'm going to put a warning on that page that Spigot/Bukkit should no longer be used and Paper used instead. So this is all a moot point since getbukkit has apparently shut down.

Great. Thanks for all the work you are doing with these images!


Lock view

Hi DBeaver users and developers,
Would anyone be interested in using some "Lock view"?
It looks like a table with session locks and details.
And also the lock dependency graph for sessions waiting and holding locks with the possibility of killing the selected session.
I have the issues of analyzing locks on production and dev environment very often, so I did this.
For Oracle, it looks like:

For Postgres like:

It's a little better than just text queries.
If anyone else is interested I am ready to send Pull Request.
Thanks,
Andrew

I'm sure that it will be a good addition to sessions manager.

I've send Pull Request for LockViewer.
Please review and send  me comment.
Andrew.

Great, see comments in pull request

New extension was successfully merged. Excellent feature.
I've made small code formatting and fixed a couple of minor UI issues.
This new plugin will be included in 4.0.5.
Thanks, Andrew.

Sorry for necroing this, but is there any docs on this view? Im looking to understand how I can debug locks that I am having beyond just killing the bad actor.


Removed duplicated binding of two methods

They are bound as both regular and virtual methods which makes ClassDB report the methods twice when querying the API. The non-virtual binding is removed since both methods only seem to be used as virtual.

Added a new commit to also make _clear_highlighting_cache() virtual, as discussed with @Paulb23.

Thanks!


No CRLF added to output files (which is needed for parsing logfile)

Mimikatz logfiles, obviously created on Windows machine add a CRLF line terminator when being created.
Pypykatz does not, which causes issues with other applications/scripts when parsing the logfiles.
Doing a 'file ' gives you this difference:
lsass-mimi.log:  ASCII text, with very long lines, with CRLF line terminators
lsass-pypy.log: ASCII text, with very long lines
Perhaps pypykatz could use the print function differently so it writes files with CRLF?
Now I have to do 'recode CR-LF ', which isn't that hard, but if not needed it would be nice.
https://www.techwalla.com/articles/how-to-use-echo-in-python

I do not see the reason why you want to parse the "logfiles" (assuming you mean the default text output), can you clarify?
I have added --json and --grep output options specifically for parsing the output programmatically. Is there a problem parsing those?

TL;DR: Pypykatz output is a different syntax as Mimikatz (For instance NT:  for pypykatz; * NTLM:  for mimikatz) and therefor my regex fails for extracting needed parts (username, password, domain, NTLM hash).
I dug a little deeper and found it wasn't (only) because of the missing CRLF lines, but the output created by Pypykatz is different from Mimikatz.
Reason I do this is to automate the process as much as possible, by dropping a lsass memory dumpfile a cronjob will run which executes pypykatz (lsa minidump $inputfile -o $outfile).
After this a second part will execute, the parser, which extracts usernames with cleartext credentials in one file, and usernames with NTLM hashes in a second file. The cleartext credentials will be put in the dictionary file. The second file will be fed to Hashcat to be cracked.

The grep flag does show up in the help. pypykatz lsa -h
The normal text output was not meant for automatic parsing, JSON output is the one that has all the information in a structured manner -except for the kerberos tickets-, please use that.
pypykatz's output was never intended to mimic minikatz's output.

Thanks for your patience and explanations! Appreciate your time and effort!


Proposal: migrate to Java 11

Yes, it is this easy

Is this in line with our since-build compatibility clause in plugin.xml?

Our since-build is set to 203. Quoting from here:

What does it mean for you? If you develop a plugin, you can use new language features and APIs from Java 11, but only if the since-build attribute in plugin.xml is set to 203. If your plugin distribution needs to run on multiple versions of the IDE, for example 202 and 203, then you should remain on Java 8.

TL;DR: yes

and what about the modularization from Java 9 @nikke234 https://apluslms.slack.com/archives/CSDV9CA31/p1613045743037700 ?

compileE2eKotlin {
    kotlinOptions {
        jvmTarget = "1.8"
    }
}

should we change this in any way? does it compile still with the existing option?

@superseacat said:

and what about the modularization from Java 9 @nikke234 https://apluslms.slack.com/archives/CSDV9CA31/p1613045743037700 ?

 But we should do that in the future as a part of #531, I'd say.

should we change this in any way? does it compile still with the existing option?

Nice catch! They still compile and work as usual, but I guess there is no harm in using 11 there as well (which also works), so I'll change it


Images display with a height of 1px on Chrome-y browsers

I use Slick on therainbowroll.com and it works like a charm except for one weird bug on Chrome (or Chromium). For some reason, subsequent slides render at 1px high, making them essentially invisible. This is probably a Chrome bug since it works wonderfully on Safari & Firefox, but I still wanted to see if anyone has a way to avoid this.
Here's how I configure Slick:
$(document).ready(function () {
  $('.images').slick({
    dots: true,
    slide: 'img',
    lazyLoad: 'progressive',
    responsive: [
      {
        breakpoint: 760,
        settings: {
          arrows: false
        }
      }
    ]
  });
});

Anyone seen this before? Is there a fix?

Can someone reproduce this in a fiddle?

I had the same issue but simply adding height:auto; to the img seems to work.

I also observed this in Chrome. It happens only sometimes. I solved this by initialization not on document.ready, but on window.load event (had to hide other then first images in the meantime).
No more 1px horizontal stripe appeared, however another issue occured: After the initialization the image shrinked on both width and height and on the right side appeared vertical stripe of next image. It returned to correct state after first slide. See http://jsfiddle.net/5bbrans8/

I'm experiencing this issue in Chrome Version 40.0.2214.115 (64-bit) Mac.
Here's my fiddle: http://jsfiddle.net/kevinkirchner/y3ns3kff/ — sometimes the bug shows, sometimes it doesn't - check all four slides. Maybe has something to do with running slick before the images have completely loaded?
FIXED:
I've confirmed that .slick-slide { height: auto; } fixed the issue for me — thanks @tokant

I'm going to see if there are any issues that arise from adding height auto to core, if not I'll bake that in for the next release

I'm having exactly the same problem. I tried the above fix but it didn't work right for me, but I fixed it in a slightly different way:
add height here:
.slick-slider .slick-track, .slick-slider .slick-list { height: 100%; }

remove height from here:
.slick-slide { height: 100%; }

Once the height was moved from .slick-slide to .slick-slider/track/list, then everything worked perfectly with Chrome.

Have the same problem..
https://jsfiddle.net/0ts3tueq/
Works nicely on ffox 36.0.1 win7 and android, yet on both android and win7 (40.0.2214.115 m) chromes height becomes 1px.
Any ideas, pls? ;)

Same problem, intermittent (meaning, only happens when boss is looking!).
HELP!!!

Try the height fixes above @Modified

Sorry, @kevnk , @voblaunsane's https://jsfiddle.net/0ts3tueq/ is consistently broken for me on Chrome v34 and v43, and neither of the above suggested height changes fixes the bug.

@Modified — are you using background images? If not, then my fiddle works with height: auto on the img — http://jsfiddle.net/kevinkirchner/y3ns3kff/

As I said, I'm seeing this bug only sometimes in my production app, in several Chrome and Chromium versions, and Chrome on Android 4.4. I cannot deliver with this behavior.
@voblaunsane's https://jsfiddle.net/0ts3tueq/ is consistently broken, and as such I think that's where the bug needs to be identified and fixed. Otherwise, how would I trust your fixes in a scenario that doesn't reproduce the problem consistently? You get my drift?
I'm now trying to replicate that jsFiddle, step by step, hoping to identify when/where exactly it appears: http://jsfiddle.net/decode/wzqtwgb1/ .
Thanks! ;o)

Did you try my solution from here? https://github.com/kenwheeler/slick/issues/771#issuecomment-76237035
There is definitely a calculation bug somewhere, but my solution fixed the problem in all my test cases.

Had the same bug. It worked fine for me from the local file system but once I put it on the server stopped working. With height:auto; it works fine though.

For what it's worth, I had the same problem happen, but only when shift-refreshing on Chrome.
This means it's definitely something to do with calculation of the height of images before they are loaded.

The height: auto fix worked for me.

i am facing the same issue here.
height: auto did not work for me.

Writing just to confirm that the height: auto approach worked like a charm for me, thanks!

same here, height: auto seems to work

I still had the problem and actually had to apply the property to the image instead.

i tried every single thing above, nothing worked except adding the property to the images themselves as well

Issues still persist. Looking forward for solution to this deal-breaker bug for else a superb library.

Can you guys reproduce this in a JSFiddle?

@kenwheeler It's inconsistent hence unable to replicate in JSFiddle.  While i'm not able to investigate the issue, it seems to me like it was initiated before the images were loaded, or something along that line.
Thanks for the great stuff btw.

I uses
$(window).load() seems to resolve the issue. Just not as elegant, as it only init slick after all images are loaded.

I've got this exact issue  on a test site: http://test.wildearth.tv/archive/petes-pond-cam - it's a grid with up to 60*24 images - I definitely need the lazyLoad.
@kenwheeler as good as a jsFiddle?

It's inconsistent to reproduce as it's tied with the images being cached. The way I can constantly reproduce this is by opening the carousel in incognito every time. Using @Modified's fiddle http://jsfiddle.net/decode/wzqtwgb1/ in incognito should replicate the issue.

I don't know if it's the same for other people, but in my case the div with classes .slick-list .draggable is assigned a style height: 1px

I have the same issue with height: 1px. I load the slider via ajax and then trigger them with slick. The above solutions of auto height don't seem to work. I tried to include them on the image; the slide div but no impact.

Once the slide buttons (next & previous) are clicked the size of the image is correct.

Same problem here.

All, the below workaround might not fix the problem in first place but it's the best solution and worked immediately. Thanks Ken for the advice!
Just some background: I got the height issue only after loading new slides with imgs via ajax. The initial page loaded perfectly and slides had perfect height.
The reason why the problem only occurs sporadic is that it depends on the loading time of the image. If the image is loaded fast then the height is adapted without problems. Just if the loading  is too slow then slick seems to calculate the height based on whats available... 0 or 1px. I tried all kind of height settings of auto or 100% in each img, div or css without sufficient permanent fix.
The solution is to wait till the images are loaded and then set the slick position.
					ajaxProcessing = true; //Prevent multipe request
					$.ajax({
						url: '/ajax.function.php',
						type:'POST',
						data: 'action=infinite_scroll&page_no=1&ft=2',
						success: function(html){
							ajaxProcessing = false; //Reset
							$('#loadingDivAjax').hide();
							$('#SharesContainer').append(html);
							$('.slide-item').slick({adaptiveHeight: true}); /* Initialize the slick again */
							$('.slide-item').imagesLoaded( function() {
								  // images have loaded
								  $('.slide-item').slick('setPosition');
							});
						},
						error: function(html){
							ajaxProcessing = false; //Reset
							$('#loadingDivAjax').hide();
						}
					});

I hope that helps somebody.

Seems like this is due to slick is initialized before the image is loaded.
Doing such worked for me:
  // load slick on image onLoad(`load() for jQuery`)
  $('img.your-image').load(() => {
     $('.slick').slick();
  });

"I have the same issue with height: 10px. It's working intermittently. I have tried the solution given by "voiceoffriends"  and "ins429 ". I didn't work out for me.
Any suggestion please?

I've looked at some of the fiddles in this thread, and @voblaunsane's is using flexbox and background-images and % heights... so clearly it will always be broken; set a height, or add some content to your slides.
@Modified / @sidnz can be fixed with http://jsfiddle.net/wzqtwgb1/5/ , lazyloading and/or putting images inside containers http://jsfiddle.net/wzqtwgb1/7/
@kevnk fiddle can be fixed with wrapping images in divs, too
http://jsfiddle.net/y3ns3kff/7/
Basically either set your .slick-slide { height: auto; } or wrap the images in a div

Setting this worked for me:
.draggable { 	height: auto !important; }

Fixed this by adding: .slick-list{height:auto !important;} to the stylesheet. When loading content with ajax.

I'm still experiencing this problem. height: auto doesn't work for me.
I think the problem is because slick struggles to work out the height of the slick track because the images aren't loaded. What's weird is that slick doesn't automatically refresh when they are loaded. I think lazy loading the images would help.
Anyway to fix I've done this, which works pretty well. It triggers a resize on the window once page is loaded, which slick will listen for and resize all the loaded slick sliders.
$(window).on('load', function() {
    $(window).trigger('resize');
});

Has anyone found a solution for this?

.slick-slide { height: auto; } will help !
@fabiosang

Put a empty
 tag out of real content would solve this problem.
That's because .slick-slide will add to the first sublayer of target element, and .slick-slide will be added style="position:relative" by script and have beyond style in slick.css:
.slick-slide {
  height: 100%;
  min-height: 1px;
}

So, if you had modified the style of your real content in carousel, these styles might influence each other, or images load incompletely and then make errors.
According to the demo, the code must be

your real content

your real content

your real content

and do the carousel to .your-class.

For me, simply doing
img {
    height: auto;
}

did not work, when I would create multiple slick image carousels. I solved it by doing
img {
     width: 100%;
     height: auto;
}

Put an empty  tag out of real content would solve this problem.

not the same

The last works for me

If your slides are not images but divs with background images, make sure to set BOTH height and min-height on those divs.

If you are using adaptiveHeight: true and lazyLoad, then target .slick-list using devtools on a page refresh(disable cache for better results). If they height of .slick-list is set to 1px, you can override it using CSS for example, setting it to: .slick-list { height: auto !important; }. Then try if it works properly. Notice, resizing the window will calculate the height of the element properly. The issue is just on the init. Hope it helps.

I'm using slick slider with infinite scroll, and what solved the slick-track { height: 1px } issue for me was to set slick-list to height: auto !important  (overriding height: 100% default).
Sliders called via Infinite scroll (endless scroll) were sometimes loading at 1px height (it looked like it wasn't even loading at all until i inspected and saw they were but slick track was calculating height improperly.
Thanks for the fix everyone!

I recently had this issue and figured it had to do with the timing of when Slick loads and when images load.  If Slick is initialized before the images, I suspect thats when we see the 1px height issue.  I used a JS solution- waiting for img.complete for all my images to be true, before initializing Slick.  Seems to be working well.

Fixed this issue by this code
height: auto;
      width: calc(100% - 1px);
      position: relative;
      right: -1px;

what causing the problem is: adaptiveHeight: true
Solved by adding:
.slick-list{
height: auto !important;
}
but it will disable the effect of adaptiveHeight: true

In my case, the developer that set up the carousel used max-width (as a way to add separation between slides) for the individual slides and that was breaking the carousel.

FIX IS HERE! Guys, i've tried all of those advices. Nothing helps. But, i fixed it add by wrapping each single img in div.
Just like AJgarden says. https://github.com/kenwheeler/slick/issues/771#issuecomment-266678781

I've solved by setting :
.slick-list {
height: fit-content;
.slick-track{ height: auto!important; }
}

Thanks. I didn't expect message btw.
вт, 25 июн. 2019 г. в 17:37, canteros21<EMAIL_ADDRESS>
I've solved by setting :
.slick-list {
height: fit-content;
.slick-track{ height: auto!important; }
}
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/kenwheeler/slick/issues/771?email_source=notifications&email_token=AJH4A5STIYYG7VTN3H3V3G3P4IUSPA5CNFSM4AXBZJE2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYQOTKQ#issuecomment-505473450,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AJH4A5WJMDZJROVBPVFHMRTP4IUSPANCNFSM4AXBZJEQ
.

+1 for putting the image in a div (this worked for me for a problem I was having with image sizes using image thumbnails for slider syncing/slider navigation).

None of the previous solutions worked for me.
Here is my solution: after adding slides via ajax, at the end of the loop, I added this instruction:
$(window).trigger('resize');
Hope this help.

+1 Nothing helps

this error is possible if the user has a slow connection and the image has not loaded and the js slick is already initialized and is initialized with a height of 1px. we solved this problem by the following method
$(document).ready(function() {
	let id = setInterval(function() {
		if ($('.slide1').height() > 100){
			initSlider();
			clearInterval(id);
		}
	}, 1000);
});

function initSlider(){
  $('.slider-main-for').slick({
......


feat: allow callback function after getEvents

Introduced changes

Removes warning for types
Allows a callback function to be executed after getEvents, this allows for a loading state or warning to be displayed on the client before the state is fully synced

Summary by CodeRabbit

New Features

Added optional callback functionality to getSyncEvents and getEvents methods, allowing for custom actions post-event fetching.

Bug Fixes

Removed console warning messages from value conversion functions to streamline error handling, enhancing user experience during data processing.

@ponderingdemocritus could you have a look at this one?

hey @edisontim thank's for your contribution, will work on apply this next week, we need to change pattern for function call. Right now, there is too much arguments on function calls.
Something like :
getEvents({ historical: false, logging: false, callback: () => false })

should be preferable imo.
@ponderingdemocritus wdyt ?

@edisontim could you check out why ci job is failing ?


Fix bug that reduces increment icon on Ubuntu on staking modal

Closes #699
Increment symbol before:

Increment symbol after fix (Ubuntu):

Increment symbol after fix (Windows):

@devchoplife implement this on the vote modal too


[Bug] Incremental model run CREATE statement though the table exists

Is this a new bug in dbt-bigquery?

[X] I believe this is a new bug in dbt-bigquery
[X] I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior
I encountered an issue with the incremental model using dbt-bigquery. Upon investigating the executed BigQuery jobs, I observed unexpected behavior. Specifically, a CREATE OR REPLACE TABLE statement was executed with a WHERE clause using is_incremental(), despite the table’s existence. The expected behavior was the execution of a MERGE statement. This issue did not manifest across all incremental models; it was limited to a few.
Our scheduled jobs are managed through dbt on Google Cloud Composer, a fully managed Apache Airflow service. We leverage the KubernetesPodOperator to execute dbt commands within containers. Attempts to replicate the issue locally resulted in the expected execution of a MERGE statement, leaving the root cause of the discrepancy unclear.
The problem first appeared on 2024-02-20. To my knowledge, there were no changes or releases in dbt-core and dbt-bigquery around that time that could have contributed to this issue.
The following configurations define our incremental strategy.
{{ config(
    materialized="incremental",
    incremental_strategy='insert_overwrite',
    on_schema_change="append_new_columns",
    ...
   )
}}

SELECT ...
FROM ...
{% if is_incremental() %}
WHERE ...
{% endif %}

Expected Behavior
The expected behavior is to run a MERGE statement, as the table exists.
Steps To Reproduce
I haven't understand the steps to reproduce. We saw the issue only on scheduled jobs.
Relevant log output
No response
Environment
- Python: 3.11.4
- dbt-core: 1.7.8
- dbt-bigquery: 1.7.6

Additional Context
No response

How many times have you observed this behavior?

Also, can you share the complete model config?


Update teamviewer to 12.0.80984

After making all changes to the cask:

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} left no offenses.
[x] The commit message includes the cask’s name and version.

Additionally, if updating a cask:

[ ] sha256 changed but version stayed the same (what is this?).
I’m providing public confirmation below.

Thank you for your PR!
teamviewer has been changed to version 12 and sha256 no_check and does not need to be updated.


DRY simple_form/bulma customization css and update initializer

There were two simple_form/bulma customization css files, so combined them into one
Changed simple_form initializer to:

include settings for horizontal displays
display radio buttons, checkboxes, and a few other things as horizontal by default

Feel pretty comfortable w merging this, so going to go ahead and do that now


Enhancement: Removing jQuery dependency

Is it possible to remove the jQuery dependency? In many modern apps, jQuery is no longer the framework of choice. Looking through the source, it does not appear to be used a lot - mainly the ajax functionality.

hey @casperfibaek we are currently working on a more modern version of this library. it's not yet public yet, but can't be long :) If you need this ASAP, there is definitely something that we can work out.


CORE-2528: Do not include query param if null and not required

It is HTTP RPC Client change only, as HTTP Server already support not required parameters correctly.
Integration test coverage been extended to expose previously failing scenario.

Are we happy enough with an exception thrown when the param is null but is also required? I guess that's OK since its not the correct usage.

Yes, passing null when parameter is required is an invocation error. Arguably, if parameter is required it should not even be nullable.


Collated Functionality Bugs from PED

Lengkhai:

[x] #369
[x] #361
[x] #360
[x] #347
[x] #333
[x] #339

Pughal:

[x] #353
[x] #362
[x] #359
[x] #348
[x] #345

Johan:

[x] #367
[x] #366
[x] #365
[x] #364, #346, #344
[x] #363
[x] #358
[x] #355

James:

[x] #357 (Does this really affect the functionality tho)
[x] #335

Closed as all issues have been resolved


feature request: add Racket-on-Chez

@jackfirth
I can't find images tagged with -cs and -cs-full at the end in https://hub.docker.com/r/jackfirth/racket/tags

@zaoqi CircleCI is still building, testing, and pushing the images. They ought to be available in half an hour to an hour, assuming nothing goes wrong.


[Bug] Can not restart declined build

example https://wp.laszlo.cloud/woodpecker-ci/woodpecker/246
{
  "status": 500,
  "message": "cannot restart a build with status declined"
}

update: UI hide this now but I think we should allow revoke decline and accept it ...


fix: Verify Google idToken correctly

While trying to work around sign in with Google on Windows using google_sign_in_dartio, I managed to sign in thru the windows frontend but failed on back end. After some digging into the auth module, I found that it was caused by the authenticateWithIdToken function in google_endpoint.dart failing to verify a valid ID token with iss equals https://accounts.google.com.
According to Verify the Google ID token on your server side:

The value of iss in the ID token is equal to accounts.google.com or https://accounts.google.com.

This PR fixed and #2536 auth issues related to ID token flow.
It may also fixed #2354, but I do not have a Mac device to verify it.
Pre-launch Checklist

[X] I read the Contribute page and followed the process outlined there for submitting PRs.
[X] This update contains only one single feature or bug fix and nothing else. (If you are submitting multiple fixes, please make multiple PRs.)
[X] I read and followed the Dart Style Guide and formatted the code with dart format.
[X] I listed at least one issue that this PR fixes in the description above.
[X] I updated/added relevant documentation (doc comments with ///), and made sure that the documentation follows the same style as other Serverpod documentation. I checked spelling and grammar.
[X] I added new tests to check the change I am making.
[X] All existing and new tests are passing.
[X] Any breaking changes are documented below.

If you need help, consider asking for advice on the discussion board.
Breaking changes
None

I have read the CLA Document and I hereby sign the CLA


Something weird happening in transpile after 1.1 release

Environment

Qiskit version: 1.1.0
Python version: 3.11.5
Operating system: MacOS

What is happening?
I noticed Qiskit Experiments tests relying on Qiskit Aer are now all failing, for example 1414. According to the error log the aer simulator backend reports basis gates which is a subset of what it can actually support. This is not a bug in Qiskit Aer.
How can we reproduce the issue?
For example
from qiskit_aer import AerSimulator
from qiskit_experiments.library import StateTomography
import qiskit.quantum_info as qi

seed = 1234
shots = 5000
f_threshold = 0.99

num_qubits = 1

# Generate tomography data without analysis
backend = AerSimulator(seed_simulator=seed, shots=shots)
target = qi.random_statevector(2**num_qubits, seed=seed)

exp = StateTomography(target)
expdata = exp.run(backend, analysis=None)

This code works okey with qiskit==1.0.2. However with 1.1.0 I get this error
TranspilerError: "Unable to translate the operations in the circuit: ['measure', 'h', 'initialize', 'barrier'] to the backend's (or manually specified) target basis: ['store', 'initialize', 'measure', 'barrier', 'snapshot']. This likely means the target basis is not universal or there are additional equivalence rules needed in the EquivalenceLibrary being used. For more details on this error see: https://docs.quantum.ibm.com/api/qiskit/transpiler_passes.BasisTranslator#translation-errors"

What should happen?
Transpile should work as before.
Any suggestions?
I don't know. I'll investigate.

Maybe due to this change https://github.com/Qiskit/qiskit/pull/12410? I confirmed
transpile(exp.circuits()[0], backend=backend, initial_layout=[0])

works okey
transpile(exp.circuits(), backend=backend, initial_layout=[0])

errors.
This makes me thing some compiler pass unexpectedly mutate Target information or some stateful pass is not reset after run.

Also confirmed the backend target is not mutated. So this is likely due to pass state issue.

It's interesting. It works with BasicSimulator but failed with AerSimulator. I made a simple case to reproduce it.
from qiskit import QuantumCircuit, transpile
from qiskit.providers.basic_provider import BasicSimulator
from qiskit_aer import AerSimulator

qc = [QuantumCircuit(1) for _ in range(3)]
qc[0].rx(0, 0)
qc[1].p(0, 0)
qc[2].ry(0, 0)

# OK
backend = BasicSimulator()
_ = transpile(qc, backend=backend)

# NG
backend = AerSimulator()
_ = transpile(qc, backend=backend)

# qiskit.transpiler.exceptions.TranspilerError: "Unable to translate the operations in the circuit: ['p'] to the backend's (or manually specified) target basis: ['measure', 'barrier', 'store', 'snapshot', 'rx']. This likely means the target basis is not universal or there are additional equivalence rules needed in the EquivalenceLibrary being used. For more details on this error see: https://docs.quantum.ibm.com/api/qiskit/transpiler_passes.BasisTranslator#translation-errors"

I also confirmed. Then this should NOT be the pass state issue. I found another behavior.
# OK
backend = AerSimulator()
_ = transpile(qc, target=backend.target)

So this is due to weird interaction between Qiskit and QiskitAer. Perhaps this is why our unit test doesn't catch this serious problem.

I expect this is an aer bug stemming from their custom translation stage pass: https://github.com/Qiskit/qiskit-aer/blob/main/qiskit_aer/backends/plugin/aer_backend_plugin.py . That pass mutates it's own Target, which was always unsound, but likely was never caught because of the serialization that was changed in #12410 because the target was essentially always deepcopied between runs before.
You can probably confirm by either setting ignore_backend_supplied_default_methods=True or running translation_method=translator on the transpile call.

Ah I see this is why https://github.com/Qiskit/qiskit/issues/12425#issuecomment-2116945093 runs without error. Indeed there is no Aer backend that injects that custom pass.


Fix for Issue 25

Hi @hdpe  I've implemented a fix for issue https://github.com/BlackPepperSoftware/bowman/issues/25 this is my first attempt at open source, the IT is passing. Feedback will be greatly appreciated.

Coverage decreased (-0.2%) to 98.237% when pulling db701dbdeaf16c3187e4c582ea00cf885159c9f2 on danapoklepovich:master into 4e2cce695432f5078dc6228f88d7cb642561fc6e on BlackPepperSoftware:master.

Brilliant stuff - thanks very much for your contribution!
Merged and released as 0.6.0.


Improved preprompts for improve flow

I have noticed that the current preprompts for the improve flow sometimes leads to lazy behavior, in the sense that no or little code is written. In this PR, I have aligned the preprompts as much as possible with the generate workflow, which we know is not lazy. I hope this will lead to tangible improvements and hopefully we can soon test the actual improvement using the apps benchmarks which is about to be supported (#1025).

@ErikBjare is there a quick explanation why the codecov workflow fails?

@ATheorell codecov.io has these configurable thresholds for what constitutes an acceptable code coverage.
Since we only use it for informational purposes, and not as a blocker for merging PRs, we don't want the checks to fail.
I was supposed to configure this, but I cannot since I don't have org-level maintainer access.
Here are the steps:

Go here: https://app.codecov.io/gh/gpt-engineer-org
Go to settings -> Global YAML Screenshot
Paste this:

coverage:
  status:
    patch:
      default:
        informational: true
    project:
      default:
        informational: true

Thanks for instructions. I have now updated the global yaml. Tried to rerun the jobs, but maybe I need to make a new commit for this to come into effect. Anyway, we can still merge if we want.

Hi @ATheorell , this looks fantastic! I've noticed instances where the LLMs yield no differences, leading to hit 'no diff' exceptions for users. My workaround has been advising users to reselect files and modify their prompts. However, ensuring that the LLMs consistently offer guidance on changes would enhance user experience, as that's the primary reason users engage with this feature.
Additionally, introducing an option for users to specify their preference for the extent of changes—via a flag—could align well with the new configuration feature from @ErikBjare. This approach could make the tool more user-centric and adaptable to individual user needs.


Please add a license to this repo

First, thank you for sharing this project with us!
Could you please add an explicit LICENSE file to the repo so that it's clear
under what terms the content is provided, and under what terms user
contributions are licensed?
Per GitHub docs on licensing:

[...] without a license, the default copyright laws apply, meaning that you
retain all rights to your source code and no one may reproduce, distribute,
or create derivative works from your work. If you're creating an open source
project, we strongly encourage you to include an open source license.

Thanks!

Plus one on this!!
@spolu mentioned in the discord that it'll be open source in some form in the foreseeable future...it'll be great to clarify.

:ship: MIT


Make the text for the Microsoft Store disclaimer yellow.

Description of the new feature / enhancement
There's been a little confusion (https://github.com/microsoft/winget-pkgs/issues/34313, but I've seen it other places too) about the difference between the msstore source and the winget source from a user perspective.
I think part of this is because the msstore source spews 30 lines to stdout which nobody slows down to read. However, the second line, This package is provided through Microsoft Store. winget may need to acquire the package from Microsoft Store on behalf of the current user. is really important for users when they want to know where to ask questions.
I think this text should be made yellow so that it pops out to the user. (If we have agreement about this, I can make the PR. Literally a one line, five second change.)
Proposed technical implementation details
Change context.Reporter.Info() to context.Reporter.Warn() here.

I've been looking at accessibility. I'm not sure if we're using colors as well as we could. Does bold standout well enough? I think contrasts well enough with black or blue backgrounds, but other terminal background color schemes might not work so well. I also think we need to change the string from "winget..." to "The Windows Package Manager..."

Bold would also work. The thing about colors is that you can override them (or disable them) in most terminals, for example in Windows Terminal my yellow is changed to red (as an example):

I don't know if there's any good documentation about a11y in command line apps, as the assumption is "it's just text", and the colors are not essential to functionality.

Yes, we're working though several a11y issues. There are also differences between the Windows Terminal palette and the PowerShell palette. We have some internal guidance with respect to contrast. Rather than selecting colors, the guidance seems to be heading towards either using text formatting, or a combination of text and color (I'm not a fan of this one as we would need some kind of library to make sure sufficient contrast exists between colors). Something like a "WARNING" or "ERROR" prefix in front of the text. If you don't mind, let's give bold a try and see if that helps. Otherwise we might need to try something else if we get any other feedback.

I've also seen some examples where all warnings are prepended with "WARNING:" and all errors are prepended with "ERROR:". I'm looping back to see if that is a best practice or not. As we move to more behavior around the complexities with upgrading or importing packages (especially when dependencies are involved), I believe this will become more important to get right.


Document required fields explicitly on the site

[ ] bug
[ ] feature request
[X] enhancement

Expected behavior
"In the above, it looks like that appeared there because the field is invalid. It would be worth calling out this style guideline more explicitly." - @vigie via Slack
Actual behavior

Required field design specifications don't exist in detail on the website
there is one small, nested example of a required field but is easily overlooked

in the Compact Forms section of Forms

Reproduction of behavior

To be placed before the "Validation" section on the Forms page
Required Fields
Used to indicate required form fields to be filled out by a user. Required fields show a red asterisk at the end of the label. It is done by applying class=“required” to the form field's label.

fixed


No setup commands in README.md file

There are not any quick start instructions on how to get started with the open_pdks. It needs something like;
git clone https://github.com/RTimothyEdwards/open_pdks.git
cd open_pdks
./configure --with-sky130-source=<directory where you cloned https://github.com/google/skywater-pdk repository>
cd sky130
make tools-a

Unclear to me if the above is correct.
It is unclear to me if anything needs to be done in the google/skywater-pdk repository before using ./configure -- aka do you have to run make timing or?

It says "Instructions" and points you to the README in the "target foundry process" which would in this case be sky130.
So if you follow that and go look at sky130/README, you'll see the full set of installation instructions.  Except that those are not the instructions that you, specifically, want to follow (see below).
The scattershot location of instructions are largely a result of several overhauls of the code since its inception.  Cleanup will happen eventually.
The above is sort of correct;  it's just that what you want out of it is the magic techfile, which is why I directed you to cd to sky130 and do "make tools-a".  Normally one just does "make" from the top level, but since that presupposes that the skywater-pdk repo is installed, then it's not what you want to do to get just the techfile for using to build the skywater-pdk repo.  The instructions you want to follow are atypical.  Likewise, there is no need for you to have the skywater-pdk or run "make timing".  You don't even need to have "--with-sky130-source=" pointing to anything relevant;  it just needs to be set to something non-null to keep the make script from failing.

Fixed this, too.  It will show up in github in a few hours.

I've yet to be able to make the instructions work....

This has been reworked several times, most recently in #127, so I'm closing this issue.


Does not work on gnome 46

I can still do all gestures and the extension does not do anything.
Gnome 46, Ubuntu 24.04

As stated in the README, I am merely publishing someone else's implementation. While I am the original developer of this extension, I am not the original developer of the main source code used within it. Unfortunately, I do not have the expertise to address the current issue. Additionally, I am no longer working with touchscreen devices and do not have the hardware necessary to test if the issue exists.
I am happy to assist in publishing a new version of this extension, provided that someone can offer a working and tested implementation.


deprecate filtered optimizer

Work in progress and open for discussion.
Updates notebooks that freeze parameters and deprecates filtered_optimizer et al.

I tested the tutorial notebook locally, and everything works as expected.

@ottonemo

Yes %matplotlib inline is missing, it should be included.
This is strange, plot_masks should work with both numpy arrays and the pillow image, it calls plt.imshow on the mask.
This could be a bug.

Can you post a github gist of the segmentation notebook you currently working on?

@thomasjpfan
I think by carefully setting up the environment I could eliminate most errors but the images still don't look like the images you showed (did the split or the dataset change?). Also the cropping seems wrong and does not look like the cropping in your version. It would be nice of you to check the current state of the notebook: https://gist.github.com/ottonemo/e52610bef80ee23df36007b2184e379d
I just changed the layer freezing and removed the callback names since they are not necessary anymore.

It looks like the train_test_split is not deterministic

If that turns out not to be the reason, it could also be possible that the underlying data has changed.

@benjamin-work with the nuclei notebook merged, please review the changes


Reintroduce the paste a list of options mode

Bulk pasting was removed from MVP because there wasn't time to focus on crafting a better experience. Let's take a closer look at this feature and see how it might be reintroduced to the UI
Usability tests showed that users wished for a way to add and edit a list of items.

Closing issue. Refer to: Edit/form builder cards: add list, edit description, add other, expand question field #2003


Feat/log format

Added a timestamp
Added a format
Check two env variables to decide if show the log or not:

If is "test" then shouldnt show the logs
If we set HIDE_LOGS env variable in the pod/docker then shouldnt show the logs
Add a parameter to force show logs even in test environments: "showLogs"

Nice, looks promising :)


⚠ Bofrost.lu has degraded performance

In 5f45d3c, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 2979 ms

Resolved: Bofrost.lu performance has improved in ff56211 after 13 minutes.


op setup: don't remove extra packages

I install some libraries such as pytest-sugar to try out, or vpic-api to parse VINs in the openpilot venv, but op setup will nuke these

I don't really like this because it means you will get stuck with old packages forever (and all their dependencies!) even after we remove them from the pyproject.toml (unless you remove them manually or nuke your venv).
This cause a problem because sometimes packages are just broken (pyopencl, pytools,...) and the easy fix is for everybody to just run the setup instead of going after each packages individually


你好 运行代码时候  出现报错 请求您的帮助

运行test_uncertainty.py 时，出现如下的报错：
100%|██████████| 1/1 [00:00<00:00,  5.40it/s]
0%|          | 0/1088 [00:00<?, ?it/s]
Traceback (most recent call last):
File "D:/2023.6.5/TFDSUNet-main/TFDSUNet-main/test_uncertainty.py", line 85, in
MAE, RMSE = Test(test_loder, model, exp_path, 'Result')
File "D:/2023.6.5/TFDSUNet-main/TFDSUNet-main/test_uncertainty.py", line 21, in Test
gamma, nu, alpha, beta = model.forward(x)
File "D:\2023.6.5\TFDSUNet-main\TFDSUNet-main\model\sffnet.py", line 116, in forward
feature = self.SFFBlock(x)
File "D:\ProgramData\Anaconda3\envs\TFDSUNet\lib\site-packages\torch\nn\modules\module.py", line 1190, in _call_impl
return forward_call(*input, **kwargs)
File "D:\ProgramData\Anaconda3\envs\TFDSUNet\lib\site-packages\torch\nn\modules\container.py", line 204, in forward
input = module(input)
File "D:\ProgramData\Anaconda3\envs\TFDSUNet\lib\site-packages\torch\nn\modules\module.py", line 1190, in _call_impl
return forward_call(*input, **kwargs)
File "D:\2023.6.5\TFDSUNet-main\TFDSUNet-main\model\sffnet.py", line 88, in forward
if self.sf is True:
File "D:\ProgramData\Anaconda3\envs\TFDSUNet\lib\site-packages\torch\nn\modules\module.py", line 1265, in getattr
raise AttributeError("'{}' object has no attribute '{}'".format(
AttributeError: 'SFFBlock' object has no attribute 'sf'
运行sffnet.py时，出现如下报错：
Traceback (most recent call last):
File "D:/2023.6.5/TFDSUNet-main/TFDSUNet-main/model/sffnet.py", line 148, in
model = SFFNet(block_num, feature_num, window_size, mid_channel_list, spa_ks_list, fre_ks_list, fus_ks_list)
File "D:/2023.6.5/TFDSUNet-main/TFDSUNet-main/model/sffnet.py", line 129, in init
self.SFFBlock.add_module('SFFBlock'+str(i), SFFBlock(window_size, feature_num, mid_channel_list[i], spa_ks_list[i], fre_ks_list[i], fus_ks_list[i], 2))
TypeError: init() missing 3 required positional arguments: 'fb', 'sf', and 'ff'
请问这要怎么处理？

Thanks for your attention to our newest work. Next, I will give you some guidance on the two problems.
First, the reason why the error in 'test_uncertainty.py' happens is that we modified the 'sffnet.py' to conduct the ablation experiment, and the model we provide is trained using the old version of 'sffnet.py'. As a result, it will raise errors when you try to test the model using the new version of 'sffnet.py'. So you may train the model by yourselves and test it or if it's needed I can offer you the old version (but it will take some time).
Second, we do find the definition in 'if name == 'main':' of 'sffnet.py' is correct, so we have updated the right version and you may try again.
Thank you for submitting the issue, which helps us make our code repository better. If any problems you get into about running our codes, feel free to bring up an issue again.

好的   谢谢您的回答 我已经解决问题了


Open external links in Safari

Fixes #2517
Changes:
Added setting for external links opening in Safari
Notes:
I'm not sure that func presentSafari(url: URL) is a proper name for our method. And also I have some doubts about Defaults+ExternalLinks.swift implementation

@Huddie by default bool value in UserDefaults in false.

Return Value
The Boolean value associated with the specified key. If the specified key doesn‘t exist, this method returns false.

Details see here.

@ismetanin cool 😎!
Sent with GitHawk

@ismetanin you added a file but didn’t upload the project .pbxproj file.
Sent with GitHawk

@Huddie fixed

Love this. Has been requested multiple times!


🚨 Fix warning

This is a new warning in Xcode 12.5.

OAuthWebViewController.swift:23:49: Using 'class' keyword for protocol inheritance is deprecated; use 'AnyObject' instead

thanks
I have tested with Xcode 12.4
ps: I will try to fix the ci (GitHub action and travis)


Block produced with 0 trx and 0 snarks

Two running BPs with same public key  produced 2 blocks for same slot. One block is red with included trx/snarks the other one is green but with 0 trx/snarks inside.
both have Error: 'Duplicate producer and slot.' Where they referencing each other.
There're also examples with one block per slot with same 0 trx/snarks included.
coda2.log
coda1.log
Red block hash: 3NLAnzCyWAfovbwfL1aQC54hyCkdSprUYnuUgCkLUFYPufHG4UCe (coda1.log)
Green block hash: 3NKWnXLwUc7Xg7MypiB4dDZtHxPZ5ncpBBW9rRXmUmGKGKKeqnw3 (coda2.log)
Testnet: Testworld
Git sha-1: [DIRTY]b14e32415b15af04865ca069af31cea7716be251
User pub-key: B62qkaTjpwYmE3tX2KumDxTcBMbAQSyzKGqJArX3HWFjY6dsqryLeVj

Thanks for report that.
The error of "duplicate producer and slot" is just saying one should not run two block producers with the same key.
But I think this has nothing to do with blocks with no snarks and txns. We would look into those.

Thanks for report that.
The error of "duplicate producer and slot" is just saying one should not run two block producers with the same key.
But I think this has nothing to do with blocks with no snarks and txns. We would look into those.

same

same

2021-01-13 10:32:25 UTC [Error] Duplicate producer and slot: producer = $block_producer, consensus_time = $consensus_time, previous protocol state hash = $hash, current protocol state hash = $current_protocol_state_hash
block_producer: "B62qpt6cDbhR93x9mTp4eMzSKqDuc2zUmyX5qzMuoMNp9FogjfhPEdE"
consensus_time: { "slot_number": "6545", "slots_per_epoch": "7140" }
hash: "3NKVtxTN3G4VGpc3cCy87tLQSMQyDoyFwLu92tgPHtRe9k27ZNCz"
current_protocol_state_hash: "3NLMya8rXtt2QPP93uqrPkkk4LbNvthhQpS1WwNmX31L8Aw4HcqK"
2021-01-13 10:32:34 UTC [Warn] Not rebroadcasting block $state_hash because it was received "1 slots too late"        state_hash: "3NLMya8rXtt2QPP93uqrPkkk4LbNvthhQpS1WwNmX31L8Aw4HcqK"

2021-01-13 10:32:25 UTC [Error] Duplicate producer and slot: producer = $block_producer, consensus_time = $consensus_time, previous protocol state hash = $hash, current protocol state hash = $current_protocol_state_hash
block_producer: "B62qpt6cDbhR93x9mTp4eMzSKqDuc2zUmyX5qzMuoMNp9FogjfhPEdE"
consensus_time: { "slot_number": "6545", "slots_per_epoch": "7140" }
hash: "3NKVtxTN3G4VGpc3cCy87tLQSMQyDoyFwLu92tgPHtRe9k27ZNCz"
current_protocol_state_hash: "3NLMya8rXtt2QPP93uqrPkkk4LbNvthhQpS1WwNmX31L8Aw4HcqK"
2021-01-13 10:32:34 UTC [Warn] Not rebroadcasting block $state_hash because it was received "1 slots too late"        state_hash: "3NLMya8rXtt2QPP93uqrPkkk4LbNvthhQpS1WwNmX31L8Aw4HcqK"

Closing this issue as it is stale for a long time.


Distributor as own package

An own package of github.com/karmanyaahm/np2p_linux/distributor would be nice, maybe under:
github.com/UnifiedPush/go_dbus_distributor / unifiedpush.org/go/dbus_distributor

Having it inside np2p is very convenient for development. Apart from that, it's just a naming thing and importing unifiedpush.org/go/dbus_distributor would functionally be the same as importing (the current-new URL) unifiedpush.org/go/np2p_dbus/distributor.
Please let me know if there's a different reason to split than (the only ones I understand) naming conventions and/or separation of repo issues and stuff.

Just beautiful import and maybe just less loading of go.mods, till compile

Does i make someting wrong?
go get -u unifiedpush.org/go/dbus/distributor
go get: module unifiedpush.org/go/dbus/distributor: git ls-remote -q origin in /home/genofire/pkg/mod/cache/vcs/dd9daf5c8fc3043c18a0771d353f3cfc8f061e4df6f7a99dcd6adef111a3184f: exit status 128:
remote: Not Found
fatal: repository 'https://github.com/NoProvider2Push/dbus/distributor.git/' not found

Oh oops I put the url in the document the wrong way

I'll undo this change for now and see how to solve it later
https://github.com/golang/go/issues/33562#issuecomment-519944146
@p1gp1g could you revert the related  documentation PR?


Optimize shadow stack instruction sequences

Closes https://github.com/paritytech/wasmi/issues/920.
TODOs

[x] Fuse i32.add_imm with global.set 0
[x] Fuse global.get 0 with i32.add_imm
[x] Fuse fused global.get 0 + i32.add_imm with i32.local_tee and global.set 0
[x] Support fusion of i32.add with a function local constant rhs register.

 Please review.

Comparison is base (e69f254) 81.24% compared to head (f8c0f57) 81.18%.

Files
Patch %
Lines

crates/wasmi/src/engine/executor/instrs/global.rs
25.00%
15 Missing :warning:

crates/wasmi/src/engine/executor/instrs.rs
33.33%
4 Missing :warning:

...rates/wasmi/src/engine/translator/relink_result.rs
0.00%
3 Missing :warning:

...ates/wasmi/src/engine/translator/visit_register.rs
0.00%
3 Missing :warning:

...rates/wasmi/src/engine/translator/instr_encoder.rs
88.88%
2 Missing :warning:

crates/wasmi/src/engine/translator/visit.rs
80.00%
2 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #928      +/-   ##
==========================================
- Coverage   81.24%   81.18%   -0.07%
==========================================
  Files         256      256
  Lines       23106    23162      +56
==========================================
+ Hits        18772    18803      +31
- Misses       4334     4359      +25

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Comment on why this has not yet been merged despite passing all CI tests and working: it introduces a lot of complexity into the translation pipelined compared to the gains we see and can verify. The runtime gains are mostly single digits and restricted to sets of benchmarks that actually make use of the shadow stack. The global_bump benchmark is heavily affected with roughly 30% performance improvement but it is also very artificial. On the flip side the improvements to memory consumption also exist but are also just single digits for practical Wasm binaries.
So all in all the question is if the gains are worth the added complexities.

The miri CI job fails because of this issue: https://github.com/rust-lang/miri/issues/3404

We might want to block this until we have multiple look-back translation feature in the Wasmi bytecode translator. This allows to get rid of intermediate optimized instructions.

I am closing this now since too much has happened in the code base so that a full rewrite would make more sense. However, I am very uncertain that this optimization is a clear improvement to Wasmi as a whole.


quarkus update removes comments from POM

When I run quarkus update, if there are comments in my POM, e.g. like this:
  <properties>
    <compiler-plugin.version>3.12.1</compiler-plugin.version>
    <maven.compiler.release>17</maven.compiler.release>
    <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
    <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
    <quarkus.platform.artifact-id>quarkus-bom</quarkus.platform.artifact-id>
    <quarkus.platform.group-id>io.quarkus</quarkus.platform.group-id>
    <quarkus.version>3.7.3</quarkus.version>
    <revision>999-SNAPSHOT</revision>
    <skipITs>true</skipITs>
    <surefire-plugin.version>3.2.5</surefire-plugin.version>
    <test.jvm.args>-Xms2g -Xmx2g</test.jvm.args>
    <version.docker.plugin>0.44.0</version.docker.plugin>
    <version.formatter.plugin>2.23.0</version.formatter.plugin>
    <version.impsort-maven-plugin>1.9.0</version.impsort-maven-plugin>
    <!-- This version needs to match the version in src/main/docker/opensearch-custom.Dockerfile -->
    <version.opensearch>2.11</version.opensearch>
  </properties>

The command will just remove them...
Version:
$ quarkus -v
3.7.4

No idea. Everybody reports Hibernate ORM bugs to Quarkus all the time, so I decided to follow the trend and not ask myself where the problem is exactly :D

I see https://github.com/openrewrite/rewrite/issues/1392 but it looks old and fixed.
Can you provide a project and commit pointer which would allow me to reproduce. Thanks.

Ok, I'm sorry. The problem was with quarkus ext add, not with quarkus update.
I did only sleep 4h last night, in my defense. Still, sorry for the noise.
Any idea where I should report problems for quarkus ext add?

Unfortunately quarkus ext add is rewriting the whole BOM. It is even changing the formatting and IMO shouldn't be used.
The problem should be reported in the Quarkus project.

Filed as https://github.com/quarkusio/quarkus/issues/39048


addShortText step should use the same appearance defaults as manager.…

The addShortText step adds a badge that does not render in the same fashion as a badge that is added via the manager (i.e. GroovyPostbuildRecorder.BadgeManager); see attached image.
I would expect these two methods for adding text badges would produce identical badges. The fix here is to initialize ShortText with the same defaults used in BadgeAction,

Tests are failing because they are expecting the old, busted defaults. Should I change the tests?

Hi carej
Thank you for your pull request.
The colors of the short texts have intentionally been kept simple.
If the user likes to have a more colorful appearance he can do this by setting the colors explicitly.
I'd rather keep the default as simple as possible.
If we changed the default now to yellow, all users of the plugin would get a different style after an upgrade of the plugin.
Best Regards,
Marc

Why are the defaults in the Action different from those provided by the
step?
On Fri, Mar 27, 2020 at 3:25 PM Marc Brugger<EMAIL_ADDRESS>wrote:

Hi carej
Thank you for your pull request.
The colors of the short texts have intentionally been kept simple.
If the user likes to have a more colorful appearance he can do this by
setting the colors explicitly.
I'd rather keep the default as simple as possible.
If we changed the default now to yellow, all users of the plugin would get
a different style after an upgrade of the plugin.
Best Regards,
Marc
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/jenkinsci/badge-plugin/pull/24#issuecomment-605256080,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADXJWBJP6YC2TDBUBCJO7OTRJT4UFANCNFSM4LVD6FTA
.

After consulting the code a bit more I realized that there is indeed an inconsistency.
I implemented a slightly different approach to you PR in  https://github.com/jenkinsci/badge-plugin/pull/25
Having the default in the global config, the groovy postbuild plugin could also use them and would therefore bin in sync with the badge plugin.
What do you think?


Setting PortraitTopInset has no effect.

I've noticed that setting the PortraitTopInset doesn't seem to have any effect. Had to manually change the default value in MZFormSheetPresentationController.m

@m1entus Fixed it :) Just had to add the setter and call setupFormSheetViewControllerFrame:
-(void)setPortraitTopInset:(CGFloat)portraitTopInset {     [self setupFormSheetViewControllerFrame]; }


Add Project data structure and storage support

Fixes #37

Notes:
Currently, the project contains a Name (String) and an Id (String) objects.
The Storage component has been updated to read and store projects to the .json file. It remains backwards compatible with AB3 .json files.
Tests have been added to cover the various classes / methods added.


Add auto-updating copyright year

This PR keeps the copyright year in the footer up-to-date automatically.

Good idea. This way we don't need to update translations every year.

There is no good reason to keep this up to date though. It refers to the date of creation of the file, which is 2014.


Bump Go Version to 1.22.7-2

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

[x] The toolchain has been rebuilt successfully (or no changes were made to it)
[x] The toolchain/worker package manifests are up-to-date
[x] Any updated packages successfully build (or no packages were changed)
[x] Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
[x] Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
[x] All package sources are available
[x] cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
[x] LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
[x] All source files have up-to-date hashes in the *.signatures.json files
[x] sudo make go-tidy-all and sudo make go-test-coverage pass
[x] Documentation has been updated to match any changes to the build system
[x] Ready to merge

Summary

Bump Go Version to 1.22.7-2
Change Log

Bump Go Version to 1.22.7-2
https://github.com/microsoft/go/releases/tag/v1.22.7-2

[microsoft/release-branch.go1.22] Update openssl to ms-go1.22-support, 889cd907e03c by @dagood in https://github.com/microsoft/go/pull/1312

This fixes https://github.com/microsoft/go/issues/1290, "With 1.x OpenSSL versions, TripleDES does not panic when expected in some cases"

Does this affect the toolchain?
No
Test Methodology

https://dev.azure.com/mariner-org/mariner/_build/results?buildId=637839&view=results

Failed, but after the build. I think because I hit the "retry" button: an artifact already existed with the same name.

https://dev.azure.com/mariner-org/mariner/_build/results?buildId=638236&view=results

Success.

Closing in favor of https://github.com/microsoft/azurelinux/pull/10565


title's indexed as sections on cards.md

on the cards page there are some headings from examples that are indexed for the nav
http://getbootstrap.com/docs/4.0/components/card/#text-alignment
I encountered this on v4-dev but it happens on the live docs aswel
screenshot,

Yeah it's an issue with our TOC plugin.

I have a PR, see #24466, but that still has the same issue.
I have opened https://github.com/allejo/jekyll-toc/issues/3 and https://github.com/toshimaru/jekyll-toc/issues/37.
At this point, both solutions aren't perfect, so I don't know with which I'll go in the end.

I'll work around it but I really want this to be properly solved.
ul ul .toc-entry.toc-h4 {
    display: none;
}

aah oke, yeah that's not really pretty...


Improve dnf tests inside build_rpm.sh

Fix bug failing to detect dnf in various locations
Add missing sudo to yum/dnf calls
Fix bug where pkg_manager may endup with a multi-line value

LGTM
/approve

/lgtm


Fix duplicated 'data.results' argument on the callback

fixes #42

+1

Would be nice to have this in. There's no working version with the new API afaik.

Already did this, thanks!


Split commmand classes

Codecov Report

Merging #196 into master will decrease coverage by 1.58%.
The diff coverage is 43.06%.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f79d04...47c9f27. Read the comment docs.


ibmcloud-cli: Update urls, remove unused shims

Change it rather in Main https://github.com/ScoopInstaller/Main/blob/master/bucket/ibmcloud-cli.json
This manifest will be deprecated in favor of Main bucket in near future.


Fix Maven group ID

The Maven groupId for koryphe should be updated to uk.gov.gchq.koryphe.

Merged into develop.


Feature request - Add json dump support directly from dataclasses

Hi,
We have a performance critical section of code that looks like
orjson.dumps(CustomSerializer.dump(message)).decode()
The serializer uses serpyco-rs to dump to python object, which is then used by orjson to dump to string.
This part can get much faster if the serializer has an option to create a json directly without involving creating the python object as an intermediary and then jsonifying it.
What do you think about directly creating a serialized json from a dataclass? I can see this being a big usecase for a lot of people.

Hi,
Yes, I agree that it can be faster if there is no need to generate intermediate python objects. At the early stages of development, I already tried this approach, but I did not achieve good results. orjson itself is very fast and optimized, it will be very difficult to achieve similar results.
Unfortunately, I don't have time to invest in this feature right now, maybe a little later I will try to do it again.
Thank you for your suggestion!

Thank you for your consideration! Maybe directly compiling with orjson code internally without involving python could be a relatively easier and more performant approach.

Yes, of course, feel free to open a PR.

+1 - this would be really helpful!
Even as a convenience method, it would be helpful to have a json_dump() method that wraps orjson (makes the code more readable and maintainable). But I didn't think about the perf boost as well - that's another great reason to skip the python dictionary step. 👌

Currently, the library is designed to remain agnostic to the underlying serialization format, whether it’s JSON, MessagePack, TOML or etc, and we aim to maintain that flexibility moving forward. Each serialization library comes with its own set of configuration options, which users should be able to configure as needed.
In your case, you can subclass the Serializer and implement the methods specific to your use case, for example:
from typing import TypeVar

import orjson
from serpyco_rs import Serializer

T = TypeVar('T')

class JsonSerializer(Serializer[T]):

    def load_json(self, data: str) -> T:
        return self.load(orjson.loads(data))

    def dump_json(self, obj: T) -> str:
        return orjson.dumps(self.dump(obj)).decode('utf-8')

def test_json_serializer():
    serializer = JsonSerializer(dict[str, int])

    assert serializer.dump_json({'a': 1}) == '{"a":1}'
    assert serializer.load_json('{"a": 1}') == {'a': 1}

This allows you to extend the base Serializer and customize the serialization and deserialization methods to suit your specific format and needs.


Added remote port

Resolve #668
If there is another header to get the port I can include it too.

Thanks @CleitonDeLima for this PR. please add a new entry in changelog https://github.com/jazzband/django-auditlog/blob/master/CHANGELOG.md in Improvements section

Thanks @CleitonDeLima


Add getTestAvgDuration API

getTestAvgDuration calculates the average test duration from the most
recent matched builds (default limit is 200)
Signed-off-by: lanxia<EMAIL_ADDRESS>

example query: http://localhost:3001/api/getTestAvgDuration?testName=badUTF8inJNI&platform=x86-64_linux
output:
[
{
_id: "badUTF8inJNI_2",
avgDuration: 1880.2941176470588
},
{
_id: "badUTF8inJNI_1",
avgDuration: 1914.3529411764705
},
{
_id: "badUTF8inJNI_0",
avgDuration: 1939.5294117647059
}
]

TRSS is updated:
https://trss.adoptopenjdk.net/api/getTestAvgDuration?testName=jdk_math_0&platform=x86-64_linux
[
{
_id: "jdk_math_0",
avgDuration:<PHONE_NUMBER>5135136
}
]


Docker image for installation

Hello.
This work introduced here is fantastic and I'd like to try it out. However, I have trouble with installation at different stages, with CUDA mismatch, pybind11 etc. I was wondering if you have a docker image that one can use to test and run the module? Thanks

Sorry I do not have enough resources to maintain this project now, so I cannot provide a docker. But the good news is we are transferring the code to PyTorch, and that will be much more easy to use.

Thanks, looking forward to it

Is there any timeline as to when the PyTorch code will be made available? I'm trying to decide whether to wait for that, or transcribe some code I already have from PyTorch to Tensorflow to use with this repo.


fix height = 100 vh problems on mobile using different approach

https://chanind.github.io/javascript/2019/09/28/avoid-100vh-on-mobile-web.html

needs to fix this, mobile browsers push content downwards and not bottom of 100vh section is not visible


FORMS-193 # Added confirmation pop up on sub form removal and updated…

add base popup class
add confirmation pop up
add Typed Errors
fix tests to not rely on DOM manipulation to remove subforms

Is there still at least one test somewhere that confirms that buttons in the DOM call the expected methods in the Backbone View? I generally like the idea of the tests looking cleaner, but I just want to double-check that our bases are covered.

there was one, but it involved random timeouts, one to wait for the popup to show, one to wait for a button to be clicked. It was too fragile for my likes.
I just thought of a way to test it that could be a bit cleaner, i'll try and implement and see how it goes

Even just mocking to confirm that all the craziness in the DOM results in a button with a correct event handler would be sufficient.

ok I added tests for the add/remove buttons on a sub form and the cancel/confirm buttons on the resulting pop up. I used timeouts :(

Have we had a customer advocate give this a quick UX review?


Update spring boot sample to the latest version

Hello,
Can you please update the examples to use the latest version of langchain4j.
Specially the loadDocument part since it changed a lot in the latest release
Thank you

Hi, it was updated during release, please pull

Yes done !
Thank you

Update Done


Grand maybe useful?

Hey Ben! Saw this repo and wondered if Grand meets your needs or if not, if there are improvements we could make that would get things more usable for you?
from grand import Graph
from grand.backends import DataFrameBackend
import pandas as pd

# Create an edges DataFrame
edges = pd.DataFrame({
    'source': [0, 1, 2, 3, 4],
    'target': [1, 2, 3, 4, 0],
    'weight': [1, 2, 3, 4, 5],
})

nodes = pd.DataFrame({
    'name': [0, 1, 2, 3, 4],
    'value': [1, 2, 3, 4, 5],
})

graph = Graph(backend=DataFrameBackend(edge_df=edges, node_df=nodes), directed=True)

(Should work on out-of-core pandas-like big data as well.)
It's useful for me to know what the shortcomings are!

hey @j6k4m8 - that's awesome, thanks for letting me know! I simply didn't know that Grand had those tools, so I'll have to see if it meets the same needs or not.
My initial impression from looking at the Grand wiki is that what I'm more interested in here is a "dialect" that I haven't found in a graph library to my satisfaction, which would mimic the syntax of pandas. Not for the sake of performance (in fact it'll probably be much less optimized than a true graph library) but simply because im used to the pandas syntax for selecting and filtering data. For instance (from the readme), much like a pandas groupby:
for color, subgraph in nf.groupby_nodes("color", axis="both"):
    print(color)
    print(subgraph.edges)

gives
('blue', 'blue')
  source  target  weight
1       1       2       2
3       2       1       4
('blue', 'red')
  source  target  weight
2       2       3       3
('red', 'blue')
  source  target  weight
0       0       1       1
('red', 'red')
  source  target  weight
4       3       0       5

Ooh neat! grand-cypher kinda gets close, though we don't fully meet the cypher spec yet so groupbys are a bit weak...
I've really liked the few minutes I've spent with the networkframe query style so far! Food for thought, wonder if there are synergies in the future :)

Ooh neat! grand-cypher kinda gets close, though we don't fully meet the cypher spec yet so groupbys are a bit weak...

ah, cool! that looks like similar idea but for sql syntax?

I've really liked the few minutes I've spent with the networkframe query style so far! Food for thought, wonder if there are synergies in the future :)

Great! FWIW this is something I pick up and put down periodically if it's helpful for a specific project, so I'm sure there are issues and things that could be improved. But would love to look for synergies!

very sql-like, though specifically targeting the neo4j-popularized cypher language... so everything that works in grand-cypher also works on a neo4j database.
definitely lots of good crossover! easy one that comes to mind is if we could abstract away the underlying data structures and get you access to networkframe queries in, say, graph databases and sql just as easily, through grand. thinking out loud, just starting some threads we can pick back up if it ever becomes relevant!

that sounds great to me, the drawback of what i was doing was always that relying on the dataframes themselves is going to be suboptimal for many graph queries, so abstracting that away but keeping the syntax would be lovely


Update URL - Pizza Tower Wiki

Pizza Tower Wiki on Miraheze - pizzatower.miraheze.org, now has custom domain - pizzatower.wiki

Updated in v3.9.0 (now available for Chrome, should be available in Firefox within a few days). Thanks for opening this issue!


one character off

Is there a way to produce search results when a user may have misspelled a word by one character? For example 'afganistan' instead of 'afghanistan'?

I too would like to know, with lunr.js you can pass in editDistance, but that doesn't seem to be working here.


0.6.0 dev

Here are some upgrades on parts of throughput source codes from 0.5.0 to 0.6.0. To verify them, we can run
cd throughput
cargo build --release --bin z_put_thr --bin z_sub_thr --bin zn_pub_thr --bin zn_sub_thr

I think there are two points can be confirmed:

Different tests for zenoh/zenoh-net layer are needed or not.
The format of argument "locator".

Different tests for zenoh/zenoh-net layer are needed or not.

@eddie9712 I think some difference still remains in the merged API. You can see from the zenoh examples that z_put.rs and z_pub.rs are still separated examples, in which the latter one was for zenoh-net. I think the use of declare_expr and declare_publication will be something worthy of note.

LGTM

Cargo.lock is auto-generated, right? Considering that, should we exclude this file from your commit? @YuanYuYuan

Yes, I once had the same doubt. But Zenoh team may prefer to include it into the git history (https://github.com/eclipse-zenoh/zenoh/blob/master/.gitignore#L5-L6).

Yes, I once had the same doubt. But Zenoh team may prefer including it into the git history (https://github.com/eclipse-zenoh/zenoh/blob/master/.gitignore#L5-L6).

I would say that for the zenoh-perf repository, it is better to keep the Cargo.lock out. It is required in zenoh mainly (but not only) to deal with ABI compatibility. In caso of zenoh-perf, I believe it's good to not constrain it with a Cargo.lock that needs to be updated and maintained.


The minimum version support is ?

I run it with ios 7.1.3 ,and get the crash. did not support ios 7 ?

OK,I find there used iOS 8’s API, so it is crash in ios7 . and i fix it.

(NSString *)getKeyFromLabel:(NSString *)label
{
//    if (![label containsString:@"<"])
//    {
//        return label;
//    }
if ([label<EMAIL_ADDRESS>== NSNotFound) {
return label;
}
NSRange startCharacter = [label rangeOfString:@"<"];
NSRange endCharacter = [label rangeOfString:@">"];
NSString *clearText = [label substringWithRange:NSMakeRange(startCharacter.location + 1, (endCharacter.location - startCharacter.location) - 1)];
return clearText;
}


[BUG] In obsidian 1.7.4, sync errors prevents app from starting

Describe the bug
in Obsidian 1.7.4, the new startup load time optimization feature flags this plugin at start up as "taking a long time to load" and offers the option to disable this plugin. Unless you disable the plugin, Obsidian will never load at startup.
The plugin loads and seems to operate fine (i.e. with no new bugs) if manually enabled after startup.
Method of syncing

N/A

To Reproduce
Steps to reproduce the behaviour:

Open Obsidian Vault with this plugin previously enabled

Expected behaviour
Vault should be loadable with this plugin enabled
Screenshots
If applicable, add screenshots to help explain your problem.
Metadata

OS: Mac 14.7
Plugin version 1.9.2
Obsidian version 1.7.4

Okay, I let the load process run out for longer, and I found that there is a sync error in console for what appears to be every single book. This appears to be a bug with syncing  that is triggered at obsidian start up by enabling "Sync at Startup".
After rerunning the manual sync a few times, these errors went away (despite reloading obsidian half a dozen times and getting the same errors). I'm not sure if this is due to the plugin somehow marking these as failed and giving up, or if rerunning it a bunch of times managed to jostle something into place and fix it. Either way, this error/bug has stopped for me, at least for now
Sync error:
Error syncing book {id: '26035', asin: 'B010PQAUH6', title: 'Oathbringer: The Stormlight Archive Book Three', author: 'Brandon Sanderson', url: 'https://www.amazon.com/dp/B010PQAUH6', …}asin: "B010PQAUH6"author: "Brandon Sanderson"id: "26035"imageUrl: "https://m.media-amazon.com/images/I/91v0vIqvFlL._SY160.jpg"lastAnnotatedDate: Thu Jan 10 2019 00:00:00 GMT+1100 (Australian Eastern Daylight Time) {}title: "Oathbringer: The Stormlight Archive Book Three"url: "https://www.amazon.com/dp/B010PQAUH6"[[Prototype]]: Object t {name: 'YAMLException', reason: 'incomplete explicit mapping pair; a key node is missed; or followed by a non-tabulated empty line', mark: r, message: 'incomplete explicit mapping pair; a key node is mi… B010PQAUH6\n                                    ^', stack: 'YAMLException: incomplete explicit mapping pair; a…r.onload (plugin:obsidian-kindle-plugin:303:4152)'}

I have the same issue

I had this issue, disabled the plugin during the load. After Obsidian loaded, I reenabled the plugin, then went to Kindle Highlights settings, and disabled "Sync at Startup". That seemed to fix the issue.


[Suggestion] Maybe Suggestion After Overhaul

Hi, I am aware of the overhaul that is taking place currently, but I just really wanted to throw out an idea. I was thinking that because nuclear reactors also create heat, NuclearCraft machines like the Manufactory, etc, should also produce heat. It could be set up like the higher the heat, the less efficient the machine will run. There would be a new upgrade slot with an item called "Cooling Upgrade" which could be used to decrease the cooling rate of the machine linearly. Methods to cool the machine might include using water, or other possible new liquids that are designated for liquid cooling. By the way, this mod is great. I love it. Good luck during the overhaul!

That could be how overclocking the machine works. Just add a ton of radiators to it.

That could be how overclocking the machine works. Just add a ton of radiators to it.

He mention about "Cooling Upgrade" - and it's not that bad idea cause you can put a limit of usage on certain machines and one "Cooling Upgrade" could reduce heat amount by 5% and you can put for example max. 5 of them to machine.


update Integration section of README to reflect latest version in SPM…

… usage subsection

@cwkatzmann Thanks a lot for your contribution! Merging


Spring Cloud (Commons) incorrectly handles the Environment

In a nutshell, when the org.springframework.cloud:spring-cloud-services-starter-service-registry dependency is added to the CLASSPATH of a Spring Boot, Pivotal GemFire ClientCache application deployed to PCF, connected to PCC, the dependency loses critical, contextual information stored in the Environment by Spring Boot for Pivotal GemFire (SBDG) using a custom PropertySource.
As a result, the Spring Boot, Pivotal GemFire ClientCache application (based on SBDG) is unable to authenticate and connect to the PCC instance deployed in PCF.
You can successfully reproduce this issue by doing the following:

Clone the SBDG project.

Create a topic branch from 1.0.0.M3 (here).

NOTE: You cannot simply branch from the HEAD of master since I have already checked in a "workaround" to this issue in commit 2e26325.

Add the org.springframework.cloud:spring-cloud-services-starter-service-registry to the CLASSPATH of the SBDG spring-geode-autoconfigure module (for example).

Then, run the AutoConfiguredCloudSecurityContextIntegrationTest class and see the test fail!

Without the org.springframework.cloud:spring-cloud-services-starter-service-registry dependency on the CLASSPATH, the AutoConfiguredCloudSecurityContextIntegrationTest passes as expected.
After in-depth analysis, my debugging revealed the main culprit in this issue involves the BootstrapApplicationListener class.
In summary...
The BootstrapApplicationListener, as its name implies, creates a new (temporary) "bootstrap" ApplicationContext along with a new (also, temporary) Environment object.  This "bootstrap" context becomes the "parent" of the main ApplicationContext started/initialized by the Spring Boot application on startup.  The BootstrapApplicationListener additionally copies/removes critical information (e.g. a SBDG custom PropertySource) from the main Environment to the "bootstrap" Environment object, which is later discarded from the "bootstrap" Environment.  This "bootstrap" Environment is somehow passed to the SDG Security configuration handling classes, thus causing the underlying SDG @Configuration class used to authenticate the GemFire ClientCache app instance with PCC in PCF to not have the necessary Security (auth) credentials available to it upon inspecting the Environment, leading to an eventual authentication error.
Anyway, I tracked the beginning of this issue down to this snippet of code.
Because SBDG used a PropertiesPropertySource to capture the Security (auth) credentials from the VCAP environment into a custom named PropertySource, and the Spring PropertiesPropertySource is an EnumerablePropertySource, this is how the SBDG custom name PropertySource gets copied and lost, unlike other PropertySources, which Spring Boot adds, that won't get lost because they are not EnumerablePropertySources. :(
Additional details for this problem may/will be provided below, in follow up comments, as necessary.

Add the org.springframework.cloud:spring-cloud-services-starter-service-registry to the CLASSPATH of the SBDG spring-geode-autoconfigure module (for example).

I was able to follow the steps above but add this Spring Cloud dependency instead of the Spring Cloud Services dependency:
testRuntime("org.springframework.cloud:spring-cloud-starter-netflix-eureka-server:2.0.2.RELEASE") {
	exclude group: "org.springframework.boot", module: "spring-boot-starter-logging"
}

This also reproduces the problem, and reduces the surface area a bit to Spring Cloud OSS libs.

This in fact is the minimum required
testRuntime("org.springframework.cloud:spring-cloud-starter:2.0.2.RELEASE")

See https://github.com/spring-cloud/spring-cloud-commons/commit/12b9bfbe for the original commits of related functionality.

I am unable to reproduce this in a small standalone project. I added VCAP_APPLICATION and VCAP_SERVICES locally and it works fine. Something about running in PCF and John's test makes the problem occurr (In john's test the env post processor runs 4 times, all my tests run it just twice). If anyone can help repdocuce this locally, that would help. /cc @wxlund

Why isn't the test case described by @jxblum adequate for confirming the bug where the PCC/PCF env is mocked?  We know the test case of pushing to the app to PCF breaks every time its executed and this bug caused a lot of lost time in discovering and isolating.

@wxlund I need a way to reproduce it locally so we can find a fix (we still don't know why it happens in john's test vs locally) and test against regression.

@spencergibb - we have seen this issue consistently on local as well as in PCF, here is the github code to replicate the issue https://github.com/wxlund/spring-boot-for-gemfire-geode-samples

@smanukyan That is the project I was using locally.

@smanukyan a local geode.

@spencergibb - can you please confirm, you can replicate the issue when your local app is connected to PCC running in PCF?

I don't know how to do that

https://github.com/spring-projects/spring-boot-data-geode/pull/22

And then... https://github.com/spring-projects/spring-boot-data-geode/pull/22#issuecomment-462470763

Additionally, my test is local, FTR.  It only mocks a PCF (with PCC) environment.

Finally, I would also add... 1) why does SCS's BootstrapApplicationListener only care about EnumerablePropertySource objects (?) and, 2) why does this class remove EnumerablePropertySource objects from the main Environment object (which it copied to the bootstrapEnvironment) when it finishes its work?

1 more thing... I wrote a example/test Spring Boot application with Spring Cloud on the classpath reproducing the issue.  This example/test does not use SBDG.
See here for more details: https://github.com/jxblum/spring-boot-cloud-example

thank you for fixing the bug! we are currently using spring-cloud-commons  version: 2.1.0.M1  , will this issue be fixed there as well? or we will need to fall back to 2.0.3.RELEASE?

why are you using a milestone?  This will be part of 2.0.3.RELEASE and 2.1.1.RELEASE

FWIW, I ran into the same issue with environmentpostprocessors for the new java-cfenv project and didn't report it since it was tied up in a larger project.  Does this mean env-post-processors will no longer run twice?

@markpollack no it doesn't.


Fix and test SemanticsController.simulatedAccessibilityTraversal

Fixes https://github.com/flutter/flutter/issues/143173
The start and end parameters of SemanticsController.simulatedAccessibilityTraversal were deprecated in https://github.com/flutter/flutter/issues/112413, but no tests were added that verified the new API. 😳
This change

fixes a typo in an error message
fixes the new startNode and endNode not being accounted for in setting the traversal range
adds dart fixes for the deprecations
adds tests for the new API that is meant to replace the deprecated one.

Filed https://github.com/flutter/flutter/issues/143405 to follow up on the new API not working in multiple views.

Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is test-exempt.
[x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

The Google testing shard keeps failing on an infra issue. Filed an internal bug, will follow up in the morning.

Reason for revert: This broke a customer test.


⚠ Bofrost.fr has degraded performance

In ac3c129, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1058 ms

Resolved: Bofrost.fr performance has improved in 0520267.


Update release date in CHANGELOG.md

API change check
API changes are not detected in this pull request.


Optimize shared memory usage for GEMM operation in CUDA

In order to achieve performance close to GEMM libraries we need to use shared memory efficiently. Promotion to shared memory is already implemented but several problems may make shared memory usage inefficient,  we need to try and measure the effect of different transformation to get the optimal code generation.

[x] Make sure the copy to shared memory is vectorized and fully unrolled. This may require switching to using vector distribution for those operations as we don't have an easy way to unroll scf ops after distribution
[x] Try using double buffering to reduce the number of barriers needed in the reduction loop
[x] Try using software pipelining to overlap copies and GEMM compute
[x] Tweak the tile size and workgroup size picked for GEMM to optimize the shared memory usage

This is done for the well aligned case. To handle unaligned we either need to do padding or support masked load.
Experiments with double buffering didn't bring performance improvements. Looking at cutlass it doesn't seem to double buffer. Therefore keeping double buffering for later if we find more information.


⚠ Digital Ocean - https://status.digitalocean.com/ has degraded performance

In de6305d, Digital Ocean - https://status.digitalocean.com/ (https://status.digitalocean.com/api/v2/status.json) experienced degraded performance:

HTTP code: 200
Response time: 170 ms

Resolved: Digital Ocean - https://status.digitalocean.com/ performance has improved in 561e0f0.


Should not throw error when files.length == 0

Directory structure likes below:
tests/
    units/

In units, there isn't any file. When I use mocha to run this path, it throws can't resolve path, but glob(path) returns []. Maybe, it shouldn't throw error.
tests/
    units/
        lib-test.js

If directory structure likes above, it works well.

Thanks for the PR! How are you invoking mocha given the dir structure above to trigger the exception?

like:
mocha --reporter spec --recursive --growl -t 0 ./test/units/*-test.js

This also happens when you invoke mocha without specifying folder / files, and there's no test folder, or there are no files under the folder. It's a common case when starting a new project using a boilerplate, and you don't want to bother with tests just yet because you're experimenting and changing how things work very fast.

Can this be merged?

I think #2450 already covers this case

Is that in the latest version?

I don't think a release has been made yet. It just got merged into master

@Munter should this be closed?  if so, please do

I think it should. If I'm wrong and this error case is not covered by #2450 then please reopen


"Next Step" not localized

The text Next Step is not localized on my-sales page.
https://demo.originprotocol.com/#/my-sales

Fixed by https://github.com/OriginProtocol/origin-dapp/pull/559


mariadb 10.0 has performance schema statement digest, but anemometer doesn't like it

Fatal error: Uncaught exception 'Exception' with message 'Datasource dbv1 has a source_type of performance_schema which requires mysql version >= 5.6. Found version: 10.0.19-MariaDB-2~wheezy-log' in /var/www/anemometer/lib/AnemometerModel.php:138 Stack trace: #0 /var/www/anemometer/lib/Anemometer.php(64): AnemometerModel->set_data_source('dbv1') #1 /var/www/anemometer/index.php(40): Anemometer->__construct(Array) #2 {main} thrown in /var/www/anemometer/lib/AnemometerModel.php on line 138

+1

looks like the Anemometer version check breaks when mariaDB returns a version that is not simply a number:  ( 10.0.19-MariaDB-2~wheezy-log) and the test that the version is  >=   5.6 fails
Look into the Anemometer code at AnemometerModel.php, and fix it:
        // check for correct mysql version with performance schema source type
        $this->connect_to_datasource();
        $result = $this->mysqli->query("SELECT @@version");
        $version = 'unknown';
        if (is_object($result))
        {
            $row = $result->fetch_assoc();
            if ($row['@@version'] >= '5.6')
            {
                return true;
            }
            $version = $row['@@version'];
        }
        throw new Exception("Datasource {$name} has a source_type of performance_schema which requires mysql version >= 5.6.  Found version: {$version}");
    }

https://github.com/box/Anemometer/blob/master/lib/AnemometerModel.php