Include unknown extra variables

Address the feature/bug discussed in #571.

Variables which are not specified in cookiecutter.json are added to the context unless the according flag (known_only=True) is set for generate.apply_overwrites_to_context().
The rationale of 8f082981fdcb3d1138d2962de88622006070ae91 was to not prompt the user for variables which are not declared in cookiecutter.json but injected via default context, as the template most probably doesn't use them.
This is different for extra context though, as it needs to be specified on every single invocation of cookiecutter.
Feedback is greatly appreciated! Thanks :bow:
cc @danielsamuels @pydanny

Imagine the following cookiecutter.json:
{
    "github_username": "hackebrot",
    "plugin_name": "foobar"
}

A user config file ~/.cookiecutterrc:
default_context:
    github_username: "pydanny"
    foo: "bar"

Now if we specify extra context using the Python API:
extra_context = {
    'unknown_in_extra': 'helloworld'
}

The context will look as follows (before user cli overwrites):
{
    "github_username": "pydanny",
    "plugin_name": "foobar",
    "unknown_in_extra": "helloworld"
}

Please note that the user will be prompted for unknown_in_extra!

As mentioned in #571, one of the values we're passing through using the cookiecutter() call is the Git clone URL, we will never need the user to enter this value via the initial prompt so for us it wouldn't make sense for it to be prompted for. I don't know if the codebase currently supports this, but is it possible to have it in the Jinja2 context, but not have it prompted for in the initial question / answer flow?

Nope, it does not (which lead to 8f082981fdcb3d1138d2962de88622006070ae91) :no_mouth: This is not a regression though!
Users are prompted for the context, which is a simple dict that doesn't hold any meta info on whether the variables originates from cookiecutter.json, default_context or extra_context.
Please see https://github.com/audreyr/cookiecutter/blob/master/cookiecutter/main.py#L131

Hmm, I think it would be possible, but perhaps not in a clean way. You could potentially pass extra_context into that prompt_for_config call and have it check the keys within this loop. Would that work at all?

I think you could rather try to prepend your private extra variables with an underscore _.

I think you could rather try to prepend your private extra variables with an underscore _.

:rage: appveyor fails due to git-connectivity problems again...

That's probably the best option actually. In that case, I'm :+1:

Hmm I'm still not quite sure if it's any good to use template variables that are not declared in cookiecutter.json. At the end of the day it is some kind of sanity check they you don't accidentally forget to set a reasonable default. Cookiecutter renders empty strings for unknown variables.

It's been a while since there's been any movement on this, and a discussion doesn't seem to have occurred. Would it be possible to get this merged, or an alternative implemented? This issue is unfortunately blocking a couple of our internal projects from working, so it would great to see it resolved. Is there anything I can do to help?

Rebased :smirk_cat:
@danielsamuels have you tried to add your variables to cookiecutter.json with an _ prefix?

Current coverage is 99.27%

Merging #597 into master will not affect coverage as of 50e9ace

@@            master    #597   diff @@
======================================
  Files           12      12
  Stmts          549     551     +2
  Branches         0       0
  Methods          0       0
======================================
+ Hit            545     547     +2
  Partial          0       0
  Missed           4       4

Review entire Coverage Diff as of 50e9ace

Uncovered Suggestions

+0.36% via ...okiecutter/config.py#19...20
+0.36% via ...ookiecutter/utils.py#27...28

Powered by Codecov. Updated on successful CI builds.

I haven't. If that's a solution that already works, then great, I'll do that. Unfortunately I haven't touched the project I was working on for a little while (I've had to work on other things). I'll give it a try at some point soon.

I tried to review this, but the logic of when context variables override each other is too confusing for me (or @pydanny) to follow. I'm nervous that this PR will make it even more complex.
Before accepting this, we need to at least have a document explaining the latest context override order. (Is there one that I missed?)

By now I think we don't need this. Happy to re-open though. :bow:


feat: run middleware from within a conversation

It would be great to be able to run middleware from within a conversation.
function convo(conversation: MyConversation, ctx: MyContext) {
  await conversation.run(middleware())
}

This would run the middleware once, as soon as it is reached, regardless of whether we are inside a replay operation or not. As a result, we should be able to install grammY plugins specifically for one conversation.
This might very well combine with #42.

Please review #47 and in turn #52.


Offset problems

my environment running ArangoDB
I'm using the latest ArangoDB of the respective release series:

[x] 3.1

Mode:

[x ] Single-Server

On this operating system:

[x ] Fedora .rpm

I'm issuing AQL via:

[x ] web interface with this browser:     running on this OS: Fedora
[ x] this Driver: 4.1.10

The following problem occurs:
I have next query:
FOR c IN users_categories
FILTER c._key == @catID
FOR u IN c.users
FOR u2 IN users FILTER u == u2._key
LIMIT 0, 4
RETURN u2
It returns 4 results, as planned. (I have 4 records)
If I set LIMIT 1, 4 it returns only 2 records. The second record is skipped, even though offset is set only to 1.
If I have only 2 records to show, LIMIT 1, 1 shows no records at all. Somehow it skips the second record in this query.

Which exact ArangoDB version do you use?
Others have reported bugs that look somewhat similar: #2889 and #2879
I will check whether they have the same root cause as the issue you reported.

I use 3.1.10, but I tried it on 3.1.26 with the same behavior.

It seems this issue is about a simliar problem as in #2879, but it is not fixed by the bugfix for #2879.
I have pushed a separate bugfix for it in a PR (https://github.com/arangodb/arangodb/pull/2931).
If all tests pass, this PR and thus the bugfix should be included in release 3.1.27

3.1.27 has been released and is available for download now:
https://www.arangodb.com/repositories/archive/arangodb31/


"event is not defined" with 1.0.0-beta-3

The version published to npm doesn't contain this change: ecc67af0e3f973d0bd915453253e6b1f88c1407c

Yes. It also doesn't contain #2 or #4 :-)
I'm waiting for a few changes to accumulate before releasing the new beta, please give it a few more days!

Fixed in 1.0.1. Requires DevTools 3.0 stable.


kctrl should provide autocomplete capabilities

Describe the problem/challenge you have
Sometimes, typing a kctrl command is too long, and requires the user to go back and forth to other terminal to see the appropriate package or version. It would be awesome if kctrl could provide autocomplete capabilities like other tools (e.g. kubectl) where it even inspects the cluster on autocompletion so that a tab keystroke would help the user to find package-names, package-versions and even commands.
Describe the solution you'd like
Add autocompletion capabilities

Vote on this request
This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.
👍 "I would like to see this addressed as soon as possible"
👎 "There are other more important things to focus on right now"
We are also happy to receive and review Pull Requests if you want to help working on this issue.

@jorgemoralespou Thank you so much for the suggestion.


Incorrect doc link in extension metadata: https://docs.quarkiverse.io/quarkus-cxf/dev/reference/extensions/quarkus-cxf-rt-features-logging.html

The io.quarkiverse.cxf:quarkus-cxf-rt-features-logging extension references https://docs.quarkiverse.io/quarkus-cxf/dev/reference/extensions/quarkus-cxf-rt-features-logging.html in its extension metadata. That docs page doesn't seem to exist anymore.

Is there anything else I can do?

The dummy io.quarkiverse.cxf:quarkus-cxf-rt-features-logging extension should either be marked deprecated, or have the link to the documentation removed in its extension metadata. We're less strict for deprecated extensions, and don't expect the links on those pages to be valid.
https://github.com/quarkiverse/quarkus-cxf/blob/ec77f4cec29dddf76bff615bc53b37a7f30cd042/extensions/features-logging/runtime/src/main/resources/META-INF/quarkus-extension.yaml shows the status as 'stable'. (Camel pioneered adding 'deprecated' to the actual status, so I've updated things to use it.)
It also looks like even if the extension metadata had a deprecated status, it wouldn't have made it into a release yet. As well as the changes above, ideally we wouldn't remove docs pages until the latest release no longer refers to them, but I know keeping docs and code in sync is tricky when there's two distinct release cycles involved.

Camel pioneered adding 'deprecated'
Would it be separated by space from the actual status, like status: stable deprecated ?

It's usually done as an array, for example (taken from https://github.com/apache/camel-quarkus/blob/main/extensions/joor/runtime/src/main/resources/META-INF/quarkus-extension.yaml)
  status:
  - "stable"
  - "deprecated"

The Camel extensions may also do something extra with the deprecated status, because I can see it gets carried across into a [generated metadata file](https://github.com/apache/camel-quarkus/blob/55759dbcd7bc4cc907d8fa4894b296a95530cd5f/docs/modules/ROOT/examples/languages/joor.yml#L7], but I don't know what it gets used for after that!

docs/modules/ROOT/examples/languages/joor.yml is IIRC a data file for generating some antora pages.
OK, let me set the deprecated status and remove the guide link.

I plan to release 3.8.1 within a couple of days, once CXF 4.0.4 is out.


fmriprep error in running multiple nodes on HPC

Hi,
I have recently tried to get fmriprep to work on my university's HPC through a singularity container.
I have checked that the singularity container is working, and fmriprep does run through the HPC. However, when I try to run my automatised bash script for 3 participants with fMRI data I receive an exitstatus=1 termination.
When reading the error file, it states that there was an error in the following:
200205-17:16:49,495 workflow ERROR:
could not run node: fmriprep_wf.single_subject_control0647_wf.func_preproc_task_rest_wf.bold_split
200205-17:16:49,496 workflow ERROR:
could not run node: fmriprep_wf.single_subject_control0647_wf.func_preproc_task_rest_wf.bold_reference_wf.gen_ref
200205-17:16:49,496 workflow ERROR:
could not run node: fmriprep_wf.single_subject_control0647_wf.anat_preproc_wf.skullstrip_ants_wf.t1_skull_strip
200205-17:16:49,980 cli WARNING:
Errors occurred while generating reports for participants: control0647 (3).
fmriprep_error_exitstatus1.txt
I have attached the full error file. I have made sure that the error is not relating to cpus, as I have requested 32 cpus per participant, with 64gb of memory space.
Could someone please help me understand what could be the possible route of this error that keeps occurring?
I did originally think that it was because I was not requesting enough cpus and ram space, however I am not convinced that that is the issue now because the processes are not reaching full-capacity of cpus or mem space.
Thank you,
Natasha

Following up on Neurostars


FixIndexKernelCache

Hi,
I have a 70,000 row data set, and I have converted them into LCT. When I run classification, I got NegativeArraySizeException and the message indicate to usedKernel.setKernelCache(new FixIndexKernelCache(cacheSize)). I think maybe it was caused by the maximum value of Integer. Do I have any other cache to run the data set? Thank you!

Hi,
sorry for this very late answer.
You can you the it.uniroma2.sag.kelp.kernel.cache.FixSizeKernelCache which is implemented into kelp-core.
Hope this help.
Bests
Danilo


Fix clipping when node has border radius

This will be made possible with the Render-To-Texture feature (#11).


Feature Request: change color if temperature is higher than x

Subject says it all. Thank you.

So depends to mac´s model set predetermined temp, color indicator

So depends to mac´s model set predetermined temp, color indicator

That's why I wrote x, a configurable variable ;-) Also people want to set individual numbers for some reasons.

That's why I wrote x, a configurable variable ;-) Also people want to set individual numbers for some reasons.

+1

Doesn't use it anymore.


Global variables in functions

I like this toolkit but there's gotta be a better way 😂

I totally agree. It's still early. Really about 3 hours effort so far

and btw - THANK YOU! That is the best comment I've read in a long time. :)   What would you suggest as an alternative to how I'm saving global values? I could write them to file or registry. That would incur some minor performance overhead, but maybe not enough to notice. Thoughts?

LoLI was just teasing you because I know you can take a joke, but if you want my opinion:
You could use Parameters and pass those with PSBoundParameters.
If the parameter is not specified, you could to ask the user to set them permanently to the registry or a json config file, or temporary for the session.
You could then initialize those once per session or on demand.
For example, I use global vars when I don't need such a complex setup by assigning them to the default value for the parameter. Then I can still pass a different value if I want to. But I would not recommend this in a module for obvious reasons. You want the cmdlets to perform predictably.

Ah! Gotcha! That makes sense and I'll play around with that idea. Sorry for the slow humor> It's been a crazy week. I'm looking forward to sleeping this weekend.

I'm still hoping for something more convenient than global vars, but for now I can't see a better option. I'm making sure the names are longer and unique so hopefully it doesn't conflict with anyone else's variables.


Function specification idea

I can think of an AST transform that could instrument functions. Here's some ideas:

Define specs in separate files/modules (with .spec extension, similar to .d.ts in TypeScript)
Find a way to map spec modules to JS modules

/* @spec path/to/spec.spec */ in JS files?
import from "path/to/spec.spec";

Match specs with function by name?
Use Webpack loader and Babel AST transform to load specs and instrument JS code

I'd be careful prescribing an extension for this, since a lot of people uses *spec* to match test files, but I'm sure there will be a way to have whatever test-runner or bootstrapping script you use to specify where to find the right files.

Wow, that's an interesting suggestion. I don't understand how this would work yet, but worth looking into 👍

You might want to consider ES Decorators to do this instead of magic places and names.


Fix makefile to support window powershell and update readme to include contribute guide

Would you prefer to PR this to apache/arrow-adbc directly?


Do not remove pod labels immediately on deletion timestamp being set, fixes #17913

This change does not remove pod labels immediately when the pod is deleted.
Doing so causes the pod's inbound listeners to be removed and the pod unable
to accept incoming traffic during its shutdown sequence.
Instead, we only remove pod labels once the pod is deleted AND its deletion
grace period has expired.
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ X] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

Hi @gotwarlost. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/ok-to-test

@googlebot I signed it!

@gotwarlost: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-mixer-k8s-presubmit-tests.sh
f78acdf55bad2baef72c882c92d15540bc268ada
link
/test integ-mixer-k8s-presubmit-tests-release-1.2

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@fpesce @lambdai the codecov failure is weird:
    check_report_test.go:249: Failed to verify OKGet report: attribute request.total_size value doesn't match. Actual 0, expected 266

Does that mean that the header/body size fixes haven't been merged to release-1.2 yet?

@duderino we were just looking at this, this branch is out of date. circleci doesn't auto-rebase like prow does

It is intended to not accept incoming traffic during pod shutdown. So we can do graceful shutdown.

Our use case explicitly depends on the pod being able to receive traffic during shutdown for checkpoint state. IMO, as a transparent proxy, wrapping a pod with istio should have no observable side-effects and certainly no loss of functionality. This is a totally valid way to use termination grace periods and lifecycle behavior in Kubernetes.

@gotwarlost: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
36b0bd7f637f50482bddfee1442874d1c398de4d
link
/test istio-pilot-e2e-envoyv2-v1alpha3-release-1.2

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

will leave this unfixed for 1.2.x since 1.3.x doesn't exhibit the same behavior and we plan to upgrade to that instead.

To be clear, the "fix" may have unintended consequences unrelated to the problem at hand.


NPM won't build

0 info it worked if it ends with ok
1 verbose cli [ '/usr/bin/nodejs', '/usr/bin/npm', 'run', 'build', '--verbose' ]
2 info using<EMAIL_ADDRESS>3 info using<EMAIL_ADDRESS>4 verbose run-script [ 'prebuild', 'build', 'postbuild' ]
5 info prebuild<EMAIL_ADDRESS>6 info build<EMAIL_ADDRESS>7 verbose unsafe-perm in lifecycle true
8 info<EMAIL_ADDRESS>Failed to exec build script
9 error<EMAIL_ADDRESS>build: `npm install && ./build`
9 error Exit status 1
10 error Failed at the<EMAIL_ADDRESS>build script.
10 error This is most likely a problem with the groovebasin package,
10 error not with npm itself.
10 error Tell the author that this fails on your system:
10 error     npm install && ./build
10 error You can get their info via:
10 error     npm owner ls groovebasin
10 error There is likely additional logging output above.
11 error System Linux 3.19.0-25-generic
12 error command "/usr/bin/nodejs" "/usr/bin/npm" "run" "build" "--verbose"
13 error cwd /home/liam/groovebasin
14 error node -v v0.10.25
15 error npm -v 1.4.21
16 error code ELIFECYCLE
17 verbose exit [ 1, true ]

This output does not contain an error message. Can you provide the error message? Sadly npm is misleading with its error message.

Re-open with the requested information.


Make the native hls downloader use disk space more efficiently

It now saves the url of the most recently completed segment to figure out from where it has to resume.
Before, it kept ALL segments which resulted in using double the disk space neccessary.

This is for #7087 again.

Another problems:

It does not work at all. After restarting it overwrite the old file since FragementFD does not open it in append mode.
Fragment on which download was cancelled will be completely redownloaded upon resume. It should resume downloading segment from the place where is was interrupted whenever possible.

Thank you for reviewing dstftw.
I fixed  most of the stuff but im not sure about your last two points in your last post.
The behavior for individual fragments that were interrupted should be unchanged from before. My patch does not touch this. I think it all relies on fragment.py setting the dl method in ctx correctly. To me it seems this should be a resumable download anyway (see fragment.py + 34).
I dont know how it would leave fragments undeleted on disk. Each downloaded fragments gets deleted right after copying its contents to the final file.

I tried to make it so other modules using FragmentFD that are not aware of the additional ctx parameters keep working as before.

Any update?

This is only used for for the progress display which you cannot see anyway when writing to stdout right?
In that case I could just check if the filename is - and simply set downloaded_bytes to 0 since the progress is irrelevant.
Do you agree?
The other solution I have in mind is storing the downloaded bytes in the last_segment file which should work but it would be unnecessary in the above case.

I just tried writing to stdout and then redirecting that into a file (> out.mp4) and you do see the progress so I will implement the second solution.

Generally, not using getsize with - should be enough.

Alright, so the first case after all. I used the exception as I thought it was more error proof than just checking tmpfile for - because maybe reading the size can file for other reasons too.

If it fails with correct filepath I don't think it should continue further since it will most likely fail on another file operations as well.

I was thinking maybe there are cases where you cannot read but can write to a file or the filesystem doesnt allow you to get the size or something else esoteric.
If it fails on writing later then it will still just stop and I dont think having the file size call fail as an implicit check for write fails later makes sense.


Unable to Provision new NVv4 virtual machines

When using the Create Resource - Provision a Host Pool, I am unable to select the new generally available NVv4 virtual machines in either the South Central US, or East US region.  I would like to demo the GPU partitioning in Windows Virtual Desktop but am unable to do so.
Please see https://azure.microsoft.com/en-us/blog/power-your-azure-gpu-workstations-with-flexible-gpu-partitioning/ for general availability announcement.
Thank you

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 970202b7-165f-18df-e928-c47c45a18755
Version Independent ID: d5393b62-4211-72f5-fc7a-363f68f6d8a2
Content: Windows Virtual Desktop host pool Azure Marketplace - Azure
Content Source: articles/virtual-desktop/create-host-pools-azure-marketplace.md
Service: virtual-desktop
GitHub Login: @Heidilohr
Microsoft Alias: helohr

@XzeroR3 Thank you for your query, our team will further look into it and get back to you at the earliest.

@ChristianMontoya, Can you please take a look?

@msrini-MSFT , @XzeroR3 : Please follow the link to submit a request in UserVoice to enable this VM size. We require this, as it takes engineering work to test and validate each new SKU that we enable to make sure it works with our deployment templates.

I think I'm running into the same problem. Feels like either the documentation was updated way ahead of time, or there's been an issue with the NVv4 SKUs since they became generally available. All the official documentation says that NVv4 VMs should be available in South Central US, but trying to deploy an ARM template with one fails every time with this error:
InvalidTemplateDeployment - The template deployment failed with error: 'The resource with id:
'/subscriptions/<subscription-id>/resourceGroups/<rg-name>/providers/Microsoft.Compute/virtualMachines/<vm-name>'
failed validation with message: 'The requested size for resource
'/subscriptions/<subscription-id>/resourceGroups/<rg-name>/providers/Microsoft.Compute/virtualMachines/<vm-name>'
is currently not available in location 'southcentralus' zones '' for subscription '<subscription-id>'. Please try
another size or deploy to a different location or zones. See https://aka.ms/azureskunotavailable for details.'.'.

My SKU quota says that I have 20 cores of NVv4 available in that region though... Also, running az vm list-skus --location southcentralus --output table --size Standard_N gave me this output, which does not include NVv4 VMs:
ResourceType     Locations       Name                  Zones    Restrictions
---------------  --------------  --------------------  -------  --------------
virtualMachines  southcentralus  Standard_NV6                   None
virtualMachines  southcentralus  Standard_NV12                  None
virtualMachines  southcentralus  Standard_NV24                  None
virtualMachines  southcentralus  Standard_NV6_Promo             None
virtualMachines  southcentralus  Standard_NV12_Promo            None
virtualMachines  southcentralus  Standard_NV24_Promo            None
virtualMachines  southcentralus  Standard_NC6s_v3               None
virtualMachines  southcentralus  Standard_NC12s_v3              None
virtualMachines  southcentralus  Standard_NC24rs_v3             None
virtualMachines  southcentralus  Standard_NC24s_v3              None
virtualMachines  southcentralus  Standard_NC6                   None
virtualMachines  southcentralus  Standard_NC12                  None
virtualMachines  southcentralus  Standard_NC24                  None
virtualMachines  southcentralus  Standard_NC24r                 None
virtualMachines  southcentralus  Standard_NC6_Promo             None
virtualMachines  southcentralus  Standard_NC12_Promo            None
virtualMachines  southcentralus  Standard_NC24_Promo            None
virtualMachines  southcentralus  Standard_NC24r_Promo           None
virtualMachines  southcentralus  Standard_ND40rs_v2             None
virtualMachines  southcentralus  Standard_NV12s_v3              None
virtualMachines  southcentralus  Standard_NV24s_v3              None
virtualMachines  southcentralus  Standard_NV48s_v3              None
virtualMachines  southcentralus  Standard_NC6s_v2               None
virtualMachines  southcentralus  Standard_NC12s_v2              None
virtualMachines  southcentralus  Standard_NC24rs_v2             None
virtualMachines  southcentralus  Standard_NC24s_v2              None

Oh, and querying just for the regions where it is available, does not include SouthCentralUS in the output:
> az vm list-skus --output table --size Standard_NV4as_v4

ResourceType     Locations      Name               Zones    Restrictions
---------------  -------------  -----------------  -------  --------------
virtualMachines  eastus2        Standard_NV4as_v4  3        None
virtualMachines  northeurope    Standard_NV4as_v4  1        None
virtualMachines  japaneast      Standard_NV4as_v4  3        None
virtualMachines  australiaeast  Standard_NV4as_v4  1        None
virtualMachines  westus2        Standard_NV4as_v4  1,2      None
virtualMachines  uksouth        Standard_NV4as_v4  1        None

Closing this issue as it's not for the docs article, but for the blog article.
#please-close


Engine.Dispose() does not end or kill FFMpeg process

The Engine.Dispose() should end or kill the FFMpeg process.

Currently if I close the application by stopping the debugger in the VS the FFMpeg process keeps running. Opening the application and starting a new task will create another FFMPeg process.
Okay maybe it did not had a chance to dispose the Engine but running the program again should kill the previous priocess:
    private void EnsureFFmpegIsNotUsed()
    {
      if (!Document.IsLocked(this.FFmpegFilePath))
        return;
      try
      {
        this.Mutex.WaitOne();
        EngineBase.KillFFmpegProcesses();
      }
      finally
      {
        this.Mutex.ReleaseMutex();
      }
    }

What if the "Document" is not locked? Then it just create a new instance of the FFMpeg.

Fixed with https://github.com/AydinAdn/MediaToolkit/commit/dac7f88b4fe8ec3347408167c84e97b1da4c3468, cheers!

Nice!


Question about fetchexclude usage

I'm curious about the intended workflow for fetchinclude/fetchexclude. According to the git-lfs-fetch manpage (https://github.com/github/git-lfs/blob/f32da15913e838c1f50ae4aca9191a3390541ade/docs/man/git-lfs-fetch.1.ronn#L55-L58) you use gitconfig to set up paths to exclude when fetching. I have some questions about its usage:

Is there any way to check in the fetchexclude settings to the repo, so that people cloning a repo can avoid fetching certain files at clone-time? (And also without setting global git config paths that could mess up other repos)
If not, would it make sense to use gitattributes for this? Since its already used to declare which files are supposed to be managed by gif-lfs, wouldn't it also be nice to declare which files should/should not be fetched (all in one place)?
I couldn't get fetchexclude to work... I made a test repo (https://github.com/maxogden/lfs-test), made a 2nd local clone, added a new file into the original inside the donotfetch folder, pushed it, then on the 2nd local clone ran git config lfs.fetchexclude "donotfetch" and then pulled, but it still downloaded the new file inside donotfetch. Am I doing it wrong?

Thanks!

Git LFS supports a .gitconfig file in the root of the repository working directory. Git itself will ignore this, of course. You can add to it like so:
 $ git config --file .gitconfig lfs.fetchexclude "donotfetch"

The problem with using .gitattributes is this behavior is default for everyone. Git config values can be overridden or customized per user or even local clone.

It worked for me:

$ GIT_LFS_SKIP_SMUDGE=1 git clone https://github.com/maxogden/lfs-test
Cloning into 'lfs-test'...
remote: Counting objects: 16, done.
remote: Compressing objects: 100% (12/12), done.
remote: Total 16 (delta 4), reused 13 (delta 1), pack-reused 0
Unpacking objects: 100% (16/16), done.
Checking connectivity... done.

$ cd lfs-test
$ ls -l
total 8
-rw-r--r--  1 rick  staff  132 Oct  5 13:15 Archive.zip
drwxr-xr-x  5 rick  staff  170 Oct  5 13:15 donotfetch

$ ls -l donotfetch
total 24
-rw-r--r--  1 rick  staff  131 Oct  5 13:15 marios.zip
-rw-r--r--  1 rick  staff  131 Oct  5 13:15 marios2.zip
-rw-r--r--  1 rick  staff  131 Oct  5 13:15 marios3.zip

$ git config lfs.fetchexclude "donotfetch"
$ git lfs pull
(1 of 3 files) 3.14 MB / 4.10 MB

$ ls -l
total 6432
-rw-r--r--  1 rick  staff  3292005 Oct  5 13:17 Archive.zip
drwxr-xr-x  5 rick  staff      170 Oct  5 13:15 donotfetch

$ ls -l donotfetch
total 24
-rw-r--r--  1 rick  staff  131 Oct  5 13:15 marios.zip
-rw-r--r--  1 rick  staff  131 Oct  5 13:15 marios2.zip
-rw-r--r--  1 rick  staff  131 Oct  5 13:15 marios3.zip

The GIT_LFS_SKIP_SMUDGE env var turns off the automatic downloading on clones so I could test this out.
Make sure you're on Git LFS v0.6.0 or v1.0. Maybe even do a git config -l just before git lfs pull to make sure the value was set correctly.

@technoweenie thanks for the reply!

ah excellent, didn't realize git-lfs looked for a local .gitconfig file!
Gotcha. I see that as a potential feature personally, to support a use case where you have a repo containing metadata for a potentially large set of files, and you want the default to be that none of the files get downloaded by default but can be selectively downloaded later as they are needed
Figured it out by running git config -l, my ~/.gitconfig had fetchexclude = Archive.zip in it (from earlier testing I was doing) and it was overriding the local setting I had set from the CLI

Figured it out by running git config -l, my ~/.gitconfig had fetchexclude = Archive.zip in it (from earlier testing I was doing) and it was overriding the local setting I had set from the CLI

Weird! I'd think local git config would override your user config. Mystery solved, at least :)


added deep_equals in utils/init.py

Adds deep_equals in __init__ to avoid full explicit import all the time.

hm, seems simple enough. I'll try to merge to main to see what the test say about this.

Codecov Report

Merging #181 (b5f168b) into main (790ab90) will increase coverage by 0.00%.
The diff coverage is 100.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@           Coverage Diff           @@
##             main     #181   +/-   ##
=======================================
  Coverage   82.74%   82.75%
=======================================
  Files          43       43
  Lines        2805     2806    +1
=======================================
+ Hits         2321     2322    +1
  Misses        484      484

Impacted Files
Coverage Δ

skbase/testing/utils/deep_equals.py
100.00% <100.00%> (ø)

skbase/utils/__init__.py
100.00% <100.00%> (ø)


SR-8649: Amendment to [SE-0167] to include Range types

Overview
This proposal amendment adds the standard library Range types to the Swift Encoders proposal.
Range is a very useful type to have conform to Codable. A good usage example is a range being sent to/from a client/server to convey a range of time using Date, or a safe operating temperature range using Measurement<UnitTemperature>.
Due to the range types not being defined in Swift Foundation, I've created a new section specifically for them residing in the Standard Library.
Forum Discussion
https://forums.swift.org/t/range-conform-to-codable/15552
Bug report
https://bugs.swift.org/browse/SR-8649
Pull Request
https://github.com/apple/swift/pull/19532

Closing as superseded by #915


Added a home screen

Added a basic home screen to start with, hopefully, the background can get replaced with something more interesting but I am bad at graphic design so someone else can do that.

whoops, wasnt supposed to go to main


Multiple cursors + Word wrap

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.93.1
OS Version: Windows 11

#26393 is still happening, despite having been marked fixed.
https://github.com/user-attachments/assets/9622342d-db90-48f9-b818-b193fdc87f2f
Maybe something has regressed since 2021.

Also marked as fixed by these issues (same functionality, but access through "Change All Occurences", Ctrl+F2)
#105730
#228818
🥲


Roll Flutter Engine from 7326e5b3354b to 05649893f75f (3 revisions)

https://github.com/flutter/engine/compare/7326e5b3354b...05649893f75f
2022-11-11<EMAIL_ADDRESS>Roll Skia from 77620568f467 to 1a7879e4e26a (6 revisions) (flutter/engine#37520)
2022-11-11<EMAIL_ADDRESS>Build display lists from SkParagraph output using the ParagraphPainter interface (flutter/engine#37087)
2022-11-11<EMAIL_ADDRESS>Roll Dart SDK from 1e37edb1f6c1 to 2b6909ba35e5 (1 revision) (flutter/engine#37516)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


Torsion chapters

I added the following chapters to the book:
Strain-diagram -> torsion
Kinematic -> torsion
Constitutive -> torsion
Solve torsional element

circular cross section
thin-walled cross section

@Tom-van-Woudenberg, I will look into it tomorrow!

@gwslingerland, I cherry-picked the ANS exercises to the 2024 branch.


ngx-translate

Demo implementation
For comparison with #48
Desktop builds available as artifacts e.g. https://github.com/BitDesert/Nault/suites/902517465/artifacts/10836896

The desktop release works now and loads the translations.

Closed in favor of #258

Closed in favor of #258


Alternative naming for server functions

Is your feature request related to a problem? Please describe.
Not really a problem, more a concern about clarity.
Describe the solution you'd like
Currently, the functions that are called within server components start with the use prefix. That's React's convention on how to name functions that are hooks.
Since you cannot run hooks in server components and it's unclear (afaik) whether that will ever be possible (or needed), I was wondering if it would make sense to rename the functions to something that couldn't lead developers to confuse them with hook calls (getLocale, getTranslations, for example)?
I'm very curious on your thought about this, and I apologize in advance if I'm missing something important here.
Describe alternatives you've considered
Of course, we can use the library as-is, there is no problem with that, but since RSCs are such a new concept that introduce a completely new paradigm into React programming, I just thought that it might be good to consider these things.

Another problem when using this prefix is that eslint errors with react-hooks/rules-of-hooks when using the functions outside of components.

Thanks for raising this concern!
I did consider different APIs for usage in Server Components, but ultimately decided that a unified API is the way to go. The reason is that there can be components that can be used in either environment (no 'use client'; marker, no interactive APIs) and by using the same API we can make these components work in both environments.

Another problem when using this prefix is that eslint errors with react-hooks/rules-of-hooks when using the functions outside of components.

They shouldn't be used there. As an escape hatch there are these APIs currently: https://next-intl-docs.vercel.app/docs/next-13/server-components#using-internationalization-outside-of-components. However, it's not yet clear if they'll make it into stable, so use them sparingly and only when you have no other choice.


ng-click working wrong when -webkit-overflow-scrolling: touch

Dears,
I have a page full of links ng-clicks, that we can scroll down :
overflow-y: scroll;
-webkit-overflow-scrolling: touch
I've noticed something strange (both iPhone 4 and Android Samsung Galasy S4) :
when you touch the page to scroll (touchstart on a first ng-click directive)
and the scroll has enough speed
and you touch again to stop the scroll (touchstart on a second ng-click directive)
then it opens the first ng-click default action on the touchend.
We would expect nothing or the second ng-click to take action. Because the first one has been forgotten for a while.
Could you please give any help on this issue ?
Thanks

I have the same problem.


How do I send telemetry data to azure iot central?

I try to connect Azure iot central using sim7000e and stm32h4. First, I created a new device on azure iot central. I scanned embedded wireless framework examples but I couldn't find any example about sim7000e connection. How to send telemetry to azure iot central using sim7000e? Is there any sample?

We are working on SIMcom drivers and examples, we plan to push them to GitHub in January 2023.
For IoT Central we have examples for WIN32 that show how to use EWF with IoT Central. Look for the examples that contain azure_iot_provisioning and azure_iot_pnp_provisioning on the name.

The plan changes, not further effort on SIMcom drivers is planned. You can use the WIN32 examples with IoT central as a base to adapt the code to your needs.


Support OpenAPI v3 parameters content

document generation crashes with:
Exception occurred:
  File ".../venv_sphinx/lib/python3.6/site-packages/sphinxcontrib/openapi/openapi30.py", line 281, in _httpresource
    type=param['schema']['type'],
KeyError: 'schema'

since it does not seem to support parameters with content
https://swagger.io/docs/specification/describing-parameters/

This issue does not exist in experimental new renderer.
https://github.com/sphinx-contrib/openapi/blob/227ef532eef5e8d21003ce0a77afc687c92944c3/sphinxcontrib/openapi/renderers/_httpdomain.py#L246-L250
Since current renderer is so hard to maintain and, I believe, this is not the only issue it has with following OpenAPI 3 spec, I simply luck any desire to work on this. Sorry. :(
I'll try my best to finish new renderer as soon as possible and enable it by default on next release.


Added support for 204 (No Content) responses

/azp run

/azp run

Manual validation build submitted by me is successful:
https://dev.azure.com/mseng/Domino/_build/results?buildId=13731311&view=results
Forcing merge.


email_notifications: Fix missed message email notifications of the welcome bot.

A missed message email notification, where the message is the welcome message sent by the welcome bot on account creation, get sent when the user somehow not focuses the browser tab during account creation.
No missed message email notification should be sent for the messages generated by the welcome bot.
A separate function named trivially_should_not_notify is added which extracts the common checks from get_push_notification_trigger and get_email_notification_trigger which are users' notification settings
independent and thus don't depend on what type of notification (email/push) it is.
A check is introduced in trivially_should_not_notify, not to notify if sender_is_welcome_bot is true.
TestCases are updated to include the sender_is_welcome_bot check in the early (False) return patterns of is_push_notifiable and is_email_noitifiable.
One query reduced for both test_create_user_with_multiple_streams and test_register.
Reason: When welcome bot sends message after user creation do_send_messages calls get_active_presence_idle_user_ids, user_ids in get_active_presence_idle_user_ids remains empty if
sender_is_welcome_bot is true because is_notifiable returns false. get_active_presence_idle_user_ids calls filter_presence_idle_user_ids and since the user_ids is empty, the query inside the function doesn't
get executed.
Manual Testing: The issue is hard to reproduce in a UI. To reproduce the issue, raise an exception in zerver/views/home.py by adding raise Exception("Throw exception after account creation") before return web_public_view(home_real)(request) reference
Create a new account, then visit \emails to see the missed message email notification. No more missed message email notification get received after including the changes.
Fixes: #22884

Screenshots and screen captures:
Before

Terminal: missed_message email sent.

Email

After

Terminal: No email sent.

Self-review checklist

[x] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[x] Explains differences from previous plans (e.g., issue description).
[x] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[x] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[x] Each commit is a coherent idea.
[x] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[ ] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[x] Corner cases, error conditions, and easily imagined bugs.

You can have a look at the backend test failing section of the above comment.
I am still trying to find out the potential reason for the failing tests.
Any help is appreciated.

@abhijeetbodas2001 I have updated the PR. Can you please review this? Thanks.

@abhijeetbodas2001 I have updated the PR as per your suggestions. Please have a look and let me know for any changes.

Thanks! This looks good to me 🙂

@timabbott , @abhijeetbodas2001 's feedback has been addressed, so I think this PR is ready for another look from you.

Hi @timabbott, awaiting your another review on this. Thanks.

This looks pretty good, but it's enough of a feature that I think we should leave it for post 6.0. Added a label so we merge it then.

@timabbott

This looks pretty good, but it's enough of a feature that I think we should leave it for post 6.0. Added a label so we merge it then.

I think this should be good to merge now.

Thinking about the semantics, if we merge this, then ALL messages by Welcome Bot will not be eligible for email/push notifications. I think that's correct (we intend Notification Bot to be used for non-onboarding features), but I'd like to figure out where to record that fact such that we don't in the future decide to use Welcome Bot for something where that'd be a problem.

I added a comment and pushed back here. But thinking about this a bit more -- I think we might want to do this a bit differently.
Rather than hardcoding Welcome Bot as being special, I think a cleaner specification would be for internal_send_private_message to accept a parameter disable_external_notifications=True, rather than this extremely specific Welcome Bot detail -- that way, we can potentially control this behavior for specific call points in the future.
Can you rework this pull request with that model? Thanks!

@abhijeetbodas2001
We have a subtle change in the model of how we're handling this.
As Tim Abbott said in the previous comment:

Rather than hardcoding Welcome Bot as being special, I think a cleaner specification would be for internal_send_private_message to accept a parameter disable_external_notifications=True, rather than this extremely specific Welcome Bot detail -- that way, we can potentially control this behavior for specific call points in the future.

I have updated the PR as per sugggestion.
Can you please review this PR once. -- Thanks!

@abhijeetbodas2001 Thanks for the review.
I have updated the PR with your suggested minor updates and Test case addition.
I am facing a problem, while implementing the test case.

The new test case I have implemented calls internal_send_private_message which returns Optional[int].
The already present test cases in MissedMessageHook calls self.send_personal_message or self.send_stream_message which returns int

Now the message_id in assert_maybe_enqueue_notifications_call_args needs to be int.
But for time being I have updated it to Any to bypass linter error.
Can you suggest some workaround? -- Thanks.

You can put a assert message_id is not None and mypy will understand that you expect it to definitely be an int (and the static checks will pass).
More mypy tips at https://zulip.readthedocs.io/en/latest/testing/mypy.html!

@abhijeetbodas2001 It works -- Thanks!

@timabbott
I have updated the PR as per your suggestions.
abhijeetbodas2001 has done another round of review.
You can have a look on this. -- Thanks.

@timabbott
I have made the suggested changes.
ps: Awaiting your response on abhijeetbodas comment

This is great, merged with a slight change to one of the comments, thanks @prakhar1144! Thanks for the careful iteration in what is a fairly complex code path.
You might want to chat with @abhijeetbodas2001 in PMs about good next projects in this code path - stuff like "Follow topic", and then start a thread in #backend about what you'd like to work on next.
(I force-pushed to 1a400b21e72ca50578d3a45f30be79b258e9cb2c since I'd forgotten to apply a small docstring clarification tweak)


Fix/26946: Reset amount when edit waypoint

Details

Reset amount when editing waypoint
Fixed Issues

$ https://github.com/Expensify/App/issues/26946
PROPOSAL: https://github.com/Expensify/App/issues/26946#issuecomment-1718973523
Tests

Create new distance request
Fill start point and end point
Go to confirmation page and observe the amount field
Click back to the distance page and edit waypoint
Go to confirmation page and verify that the amount is updated

[x] Verify that no errors appear in the JS console

Offline tests

Same above
QA Steps

Same above

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/Expensify/App/assets/141406735/25a50c96-7685-4162-8c7a-5af02c56010b

Android: mWeb Chrome
https://github.com/Expensify/App/assets/141406735/ea263a77-6a5e-4d13-8dc4-89f59c08815d

iOS: Native

https://github.com/Expensify/App/assets/141406735/ab188ccb-11bc-4bf2-82e5-ae3a976fc5ad

iOS: mWeb Safari
https://github.com/Expensify/App/assets/141406735/b6f64362-9cde-40ee-88ee-11ff5fa383e4

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/141406735/730539c4-9a15-4e15-a4c1-b02b34733ebe

MacOS: Desktop

https://github.com/Expensify/App/assets/141406735/e35ef9c4-03be-4fc4-a1b7-7d9dc4f4ca38

There are some errors with android and Safari, I will update the screenshot for  android and safari later

There are some errors with android and Safari, I will update the screenshot for android and safari later

Let's focus on fixing them! Let me know if I can help.

@cubuspl42 Sure, But it also happened on the main branch, I am resetting the repository and trying again.

@cubuspl42 Updated all videos. Please help to review PR

I'm on it

@DylanDylann

Updated all videos

Did fixing the problems you mentioned involve any fixes in the PR, or was it a problem on main that got solved?

@cubuspl42

Did fixing the problems you mentioned involve any fixes in the PR, or was it a problem on main that got solved?

It is a problem on main branch but it is resolved after merging latest main

Create new distance request

Fill start point and end point

Go to confirmation page and observe the amount field

Click back to the distance page and edit waypoint

Go to confirmation page and verify that the amount is updated

Won't this test succeed on the main branch, without your fix?

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/francoisl in version: 1.4.21-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
failure ❌

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/marcaaron in version: 1.4.21-4 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
cancelled 🔪

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/marcaaron in version: 1.4.21-4 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
cancelled 🔪

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/marcaaron in version: 1.4.21-4 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅


Feature/develop by han

Codecov Report

Merging #543 (60235da) into v2.6.x_develop (03618e3) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@                Coverage Diff                 @@
##           v2.6.x_develop     #543      +/-   ##
==================================================
- Coverage           62.56%   62.55%   -0.01%
==================================================
  Files                 442      442
  Lines               27406    27409       +3
==================================================
  Hits                17146    17146
- Misses              10260    10263       +3

Impacted Files
Coverage Δ

itsm/ticket/permissions.py
36.47% <0.00%> (-0.24%)
:arrow_down:

itsm/ticket/serializers/ticket.py
69.66% <0.00%> (-0.22%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03618e3...60235da. Read the comment docs.


Chain "write-test" and "code-repair" task with combining different models

Basically we want to execute the "write-test" task, but then optionally chain another model that can do "code-repair" on the generated tests.
Additionally, the "code-repair" model could be different from the model that generated the tests in the first place.
Finally, the scoring should treat both the original "write-test" and the (hopefully) repaired tests as different results from different models (i.e. only model X vs model X with code repair by model Y).

[ ] move assessments.Add  within task.Run so a task is able to add multiple different assessments at once
[ ] introduce model chains, i.e. --model openrouter/X+openrouter/Y means that the task is supposed to be solved by openrouter/X but model openrouter/Y can help

if openrouter/X was able to solve the task, it gets the assessment/score points alone
if not, then continue with openrouter/Y and give the assessment to the "combined" model
how exactly openrouter/Y helps/fixes the incorrect/incomplete solution of openrouter/X is part of the task logic (i.e. to correct "write-test" you need "code-repair") and might be different for other tasks (i.e. there might be tasks where there is no way to correct an incorrect result... like "I have implementation path A, what should be the correct test path B?": wrong answer is just wrong, no way to correct)
[ ] introduce a new container model that just "chains" modelspointer basis

type ModelChain interface {
    Model
    Next() Model
}

type chain struct {
    current Model
    next ModelChain
    id string
}

// Redirects all the methods of normal Model to the current model in the chain, so itself is a model.
// The ID is either the ID of the model (for the first one) or the concated id's of previous models (i.e. `openrouter/X+openrouter/Y).
// The `next` field contains the next link in the chain or `nil` in case the chain is done.

[ ] extend the CLI parsing such that model chains are properly detected and assembled

[ ] exclude Ollama from participating in "model chains" for now since that would require multiple models to be loaded and unloaded and that will be part of future investigations

[ ] extend the "write-test" task such that

[ ] if the first result fails at execution and the current model is a chain (i.e. a ModelChain) it iterates through Next models
[ ] until nil or one of them manages to repair the code
[ ] watch out for the scoring... "code-repair" gives additional score for the next model

the score must be combined intelligently, i.e. don't give two points cause both models did not error!!!
for runtime and character count the score can probably be added up
for coverage and execution only the final "attempt" matters
...

@Munsio plz review

When we want to "repair" something don't we need the data from the previous model? How is it shared?
How does the Next Model in the chain know that it needs to repair something and not generate the thing new?

The task evaluation logic can carry over the "broken code" and just ask the next model to do a "repair". The models themselves don't need to worry about sharing context or what they need to do. The evaluation logic will say "you failed, but you, please fix, this is what we have so far".


[Silicon Labs Platform Example] Bring up CHIP Stack - Support thread setup over BT

Problem
<what's wrong or missing, please include any applicable:

expected behavior
actual behavior
steps to reproduce
system configuration
screenshots, images, logs, etc.

Proposed Solution
<suggested fix, suggested enhancement>

Already done


Actual Training Loss Curve

In the VAR model, a standard cross-entropy loss is employed; Yet Figure 5 illustrates the scaling law on a modified loss function. Could you provide the precise equation detailing how the actual training and test loss are converted to this reduced form? Additionally, is there a training log available that records the actual cross-entropy loss values over the course of the training? Access to this information would greatly enhance readers' comprehension of the training process dynamics for the VAR model.
Thanks a lot!

hi @chenllliang, following previous literature about scaling laws in NLP, we also decompose the standard cross-entropy loss (on the test set) by CE(ground_truth, prediction) = E(ground_truth) + D_KL(ground_truth, prediction). The E(ground_truth) is the so-called irreducable loss and D_KL(ground_truth, prediction) the reducable loss. Figure 5 illustrates the reducable loss, which is calculated by CE - E(ground_truth). E(ground_truth) is calculated on the ground truth token distribution of a trained tokenizer. The E(ground_truth) of the last scale and the average E(ground_truth) are 4.5 and 5, respectively.
I'll post some training logs soon, please stay tuned.

Thanks for your information!

It's obtained by forwarding VQVAE on every ImageNet image, getting the probabilities on each word of the VQ vocabulary, and calculating the entropy.


Failed at the<EMAIL_ADDRESS>start script 'webpack --hide-modules --watch --config assets/build/webpack.config.js'.

Submit a feature request or bug report

[ ] I've read the guidelines for Contributing to Roots Projects
[ ] This is a feature request
[X] This is a bug report
[ ] This request isn't a duplicate of an existing issue
[ ] I've read the docs and NPM Debugging Guidelines post and followed them (if applicable)
[ ] This is not a personal support request that should be posted on the Roots Discourse forums

Replace any X with your information.

What is the current behavior?
npm start not run

Bug report
npm start
><EMAIL_ADDRESS>start M:\sites\wordpress\public\wp-content\themes\tema
> webpack --hide-modules --watch --config assets/build/webpack.config.js

Webpack is watching the files…

npm ERR! Windows_NT 10.0.14393
npm ERR! argv "C:\\Program Files\\nodejs\\node.exe" "C:\\Users\\Marcelo\\AppData\\Roaming\\npm\\node_modules\\npm\\bin\\npm-cli.js" "start"
npm ERR! node v6.9.1
npm ERR! npm  v4.0.2
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>start: `webpack --hide-modules --watch --config assets/build/webpack.config.js`
npm ERR! Exit status 2
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>start script 'webpack --hide-modules --watch --config assets/build/webpack.config.js'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the sage package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     webpack --hide-modules --watch --config assets/build/webpack.config.js
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs sage
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls sage
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     M:\sites\wordpress\public\wp-content\themes\tema\npm-debug.log

WordPress version: 4.6.1
OS: Windows 10
NPM/Node version: 4.0.2/6.9.1
Where did the bug happen? Development or remote servers?
Development
Is there a related Discourse thread or were any utilized (please link them)?
No

I had similar problem. Try the following:

Delete node_modules folder: rimraf node_modules
Open Node.js command prompt as admin
Run npm install

In my case npm start is working properly now.

Same here, @miclap suggestion didn't solve the issue

I had the same problem, stopping at Webpack is watching the files…. Then I remembered that there was a problem with eslint-plugin-import not installing properly due to a version confilct. This fixed it for me:

npm install<EMAIL_ADDRESS>--save-dev
rm -r node_modules
npm install

[ ] I've read the docs and NPM Debugging Guidelines post and followed them (if applicable)
[ ] This is not a personal support request that should be posted on the Roots Discourse forums


Migrate to MC 1.13

Current version of MC is 1.13.
Right now out of the box you would get the following error:
Failed to connect to server
Outdated server! I'm still on 1.12.2

There is a workaround using the launch options to fix it for 1.12.2:
https://www.screencast.com/t/QC2VjDRk5k8t

I tried running the following command to bump up the version:
docker run -it  -p 25565:25565 -e EULA=TRUE -e VERSION=1.13 openhack/minecraft-server /bin/bash

But got the following error:
Empty data volume detected. Populating with default world
Switching to user 'minecraft'
Checking version information.
Checking type information.
Downloading minecraft_server.1.13.jar ...
Creating server.properties
Setting motd to A Minecraft Server Powered by Docker
Setting enable-rcon to true
Setting rcon.password to cheesesteakjimmys
Setting rcon.port to 25575
Setting level-name to world
Setting level-seed to -9363708386013540
Setting pvp to true
Setting online-mode to FALSE
Setting level type to DEFAULT
Setting difficulty to 0
Setting initial memory to 1G and max to 1G
Error: Unable to access jarfile minecraft_server.1.13.jar

Nevertheless, when I run itzg image, it works properly:
https://github.com/itzg/dockerfiles/issues/236

On a side note, nanoserver and nanoserver1709 are pointed to VERSION=latest. And I cannot seem to be able to override that version by hand (-e VERSION=1.12.2). Which leads to the following error:
Empty data volume detected. Populating with default world

StatusCode        : 200
StatusDescription : OK
Content           : {123, 34, 108, 97...}
RawContent        : HTTP/1.1 200 OK
                    Connection: keep-alive
                    Date: Thu, 26 Jul 2018 16:37:39 GMT
                    Via: 1.1 36fbf419b5fa237613e1567ab33d3698.cloudfront.net
                    (CloudFront)
                    Accept-Ranges: bytes
                    Age: 170
                    ETag: "8f4abe1fb6e1...
Headers           : {[Connection, System.String[]], [Date, System.String[]],
                    [Via, System.String[]], [Accept-Ranges,
                    System.String[]]...}
RawContentLength  : 28942

Checking version information.
Checking type information.
Downloading minecraft_server.1.13.jar ...
Invoke-WebRequest : Response status code does not indicate success: 403
(Forbidden).
At C:\minecraft\start.ps1:322 char:5
+     Invoke-WebRequest -Uri "https://s3.amazonaws.com/Minecraft.Downlo ...
+     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : InvalidOperation: (Method: GET, Re...1.14393.100
   0
}:HttpRequestMessage) [Invoke-WebRequest], HttpRequestException
    + FullyQualifiedErrorId : WebCmdletWebResponseException,Microsoft.PowerShe
   ll.Commands.InvokeWebRequestCommand

Guess what..  They re-updated the server again ...


Turn off Strict Mode in Vuex Module Mode

What problem does this feature solve?
As non-module mode for Vuex is deprecated, users need the ability to turn off strict mode.
What does the proposed changes look like?
Allow users to turn off strict mode by passing a config in nuxt.config.js

This feature request is available on Nuxt community (#c8378)

I don't see a problem in adding such a configuration file but what are the benefits/use-cases?

Turning off strict mode in Nuxt currently requires using the deprecated store/index.js, look at https://github.com/nuxt/nuxt.js/issues/1521
The benefit and use-cases are typically two-way binding of Vuex stored properties, storing properties managed by outside libraries such as chrome extensions and in general, turning it off in production to not break the page.

Indeed, that works! :relaxed:
https://github.com/nuxt/nuxt.js/blob/39b558f59c0ecb5aa40bf709ca5dff83a151b20b/packages/vue-app/template/store.js#L75-L81
PS: Strict is disabled in prod anyway because it degrades perf.
Closing here :relaxed:


Added weight tying

As we recently showed in [1], tying the input word embedding to the softmax matrix decreases perplexity on a wide range of language models.
I implemented weight tying, and also ran tests comparing weight tied models to "regular" models, to make sure that it also improves the performance of the various models in this repo. The results are:

REGULAR:
-- rnn_cell = rnn_cell_modern.MGUCell(size, use_multiplicative_integration = True, use_recurrent_dropout = False)
Epoch: 13 Train Perplexity: 50.346
Epoch: 13 Valid Perplexity: 131.284
Test Perplexity: 125.133
-- rnn_cell = rnn_cell_mulint_layernorm_modern.HighwayRNNCell_MulInt_LayerNorm(size)
Epoch: 13 Train Perplexity: 54.869
Epoch: 13 Valid Perplexity: 123.373
Test Perplexity: 117.859
-- rnn_cell = rnn_cell_mulint_modern.GRUCell_MulInt(size)
Epoch: 13 Train Perplexity: 49.530
Epoch: 13 Valid Perplexity: 126.091
Test Perplexity: 120.613

WEIGHT TIED:
-- rnn_cell = rnn_cell_modern.MGUCell(size, use_multiplicative_integration = True, use_recurrent_dropout = False)
Epoch: 13 Train Perplexity: 61.479
Epoch: 13 Valid Perplexity: 128.844
Test Perplexity: 122.353

-- rnn_cell = rnn_cell_mulint_layernorm_modern.HighwayRNNCell_MulInt_LayerNorm(size)
Epoch: 13 Train Perplexity: 64.139
Epoch: 13 Valid Perplexity: 120.395
Test Perplexity: 114.491

-- rnn_cell = rnn_cell_mulint_modern.GRUCell_MulInt(size)
Epoch: 13 Train Perplexity: 60.983
Epoch: 13 Valid Perplexity: 125.205
Test Perplexity: 119.398

Clearly weight tying consistently reduces test set perplexity while increasing the train perplexity which indicates less overfitting.
[1] https://arxiv.org/abs/1608.05859

Thanks for implementing these changes. This will reduce on memory usage as well and decrease parameters.


Bug OCPBUGS-859: Do not create HTTP monitors for UDP on old Octavia

Octavia API before 2.16 doesn't support HTTP monitors on UDP pools. It
will however allow creation of such if all-in-one LB creation call is
used. This is a problem for UDP ETP=Local Services, where
healthCheckNodePort is allocated and CCM will try to create HTTP
monitor there. This monitor will be completely not functional.
OVN Octavia provider doesn't support HTTP health monitors either.
This commit fixes that by making sure we're checking Octavia API version
and if it's lower than 2.16 we fall back to creating UDP-CONNECT health
monitors on a regular port instead. Moreover same is done when provider
is set to "ovn".

/jira refresh

@mandre, you've seen this PR upstream.

/retest

/retest
I'm tempted to just override this, only test failing is one related to etcd performance.

/retest
Just a quota slice issue.

/retest

/retest

/retest

/lgtm

/cherry-pick release-4.12


++ and -- prefix operators not serialized correctly with "soft" constant

Input:
// Sloppy mode
const f = function x() {
  return ++x;
};
f.valueOf = () => 100;
module.exports = f;

Output:
const x = (x$0 => x$0 = function x() {
  return +x$0;
})();
Object.assign(x, {
  valueOf: (0, () => 100)
});
module.exports = x;

x here is a constant, but a "soft" const which doesn't throw an error when assigned to in sloppy mode code.
The original function returns 101, whereas the serialized function returns 100.
The output would be correct if it was x++, but for ++x the function's body should be return +x$0 + 1;.
NB x$0 + 1 (without the preceding +) is insufficient. ++x coerces x to a number, whereas x + 1 may instead coerce 1 to a string, so +x$0 is required to ensure x is coerced to a number before + 1.
Same problem with --x.

Actually, even that doesn't cover one really bizarre case:
// Sloppy mode
const f = function x() {
  return ++x;
};
f.valueOf = () => 100n;
module.exports = f;

If x is a BigInt, +x throws error TypeError: Cannot convert a BigInt value to a number.
Only way to cover this very wacky case is:
++x -> (n=>++n)(x)
x++ -> (n=>n++)(x)
--x -> (n=>--n)(x)
x-- -> (n=>n--)(x)


Implement Convertible instances for ledger types

We need to translate all ledger types to Haskell. The types for which we'll need Convertible instances are all those that appear in Computational instances. The root types of these are ChainState and Block, but there are also some others whose values are only temporarily constructed. In the end, we want to be able to write functions such as utxo-step (including the COMPILE pragma) for every Computational instance.
At the moment, it's fine to keep our own versions of the Haskell Ledger types and ask the Ledger team to translate to them once they want to use our code.
Here's a list of what needs to be covered:

[x] GOV
[x] LEDGER
[x] RATIFY and RATIFY'
[x] ENACT
[x] CERTS, CERT, CERTBASE
[x] POOL
[x] GOVCERT
[x] DELEG
[x] NEWEPOCH
[x] CHAIN

This has been done manually by #426.


File Path test fails in nightly build

Description:
Following test has been failed in during nightly build
[ERROR] Tests run: 31, Failures: 1, Errors: 0, Skipped: 7, Time elapsed: 2.002 s <<< FAILURE! - in TestSuite
[ERROR] testGetAllFilePaths(org.ballerinalang.langserver.compiler.workspace.ExtendedWorkspaceDocumentManagerImplTest)  Time elapsed: 0.009 s  <<< FAILURE!
java.lang.AssertionError: expected [1] but found [3]
	at org.ballerinalang.langserver.compiler.workspace.ExtendedWorkspaceDocumentManagerImplTest.testGetAllFilePaths(ExtendedWorkspaceDocumentManagerImplTest.java:80)

This test has been disabled in following PR
https://github.com/ballerina-platform/ballerina-lang/issues/10427

Issue has been resolved in the latest master. Hence closing.


« Illegal characters »

For a better translation, we should add the ability to add the characters said « illegal » (In reference to the gamemode DarkRP), such as : α ß Á á À à Å å Ä ä Æ æ Ç ç É é È è Ê ê Í í Ì ì Î î Ñ ñ Ó ó Ò ò Ô ô Ö ö Ø ø Ú ú Ù ù Ü ü Ž ž, « »,  etc...
Here is a list more detailed : http://www.copypastecharacter.com/all-characters

Any idea on how this is achieved?

I don't know, when I was translating the HL2RP Schema in French, I have to encode some document in UTF-8 without BOM or in OEM 863: French. Maybe it could help?


https://www.packtpub.com/packt/offers/free-learning

https://azurestankins.azurewebsites.net/recipe/BNR


Allow installation of community_ssl clients on Mac

thanks Jeff!

Was this merged?

Yes. Should be available in 1.1.10. You can install it from github i don't think we pushed it to pypi yet

Sorry i realized that it was not merged yet. Its merged now.


OAuth support

Summary

[x] Tell us about the problem your pull request is solving.
Oauth support
[x] Are there any open issues that are related to this?
Yes #62

If your changes involve documentation updates please mention that and link the appropriate PR in feathers-docs.
Thanks for contributing to Feathers! :heart:

Thank you for the PR. How does a server setup for this look like? I thought for OAuth you always have to hit a URL and then get redirected back?


wrong shape - "Mangal"  (Devnagri) font

The Shape of word is wrong.
word = शृंगार,विद्या,यद्यपि,विद्यालय

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6c629c9b-d28b-aa25-5344-376a3dd28b2e
Version Independent ID: 991734e0-5210-6a12-f671-1c0b07d11e58
Content: Mangal font family - Typography
Content Source: typographydocs/font-list/mangal.md
Product: typography
GitHub Login: @alib-ms
Microsoft Alias: alib

As I recall, earlier versions of Mangal included more traditional ligatures for conjuncts involving retroflex consonants, but these were disabled in response to feedback from some users and some unfortunate recommendations of the Bureau of Indian Standards regarding use of explicit halant in modern Hindi.

The conjuncts such as श्‍व, श्‍ल, and श्‍न are predominantly used in contemporary Hindi. This was also accepted as Standard by the Hindi Spelling Committee of Govt of India. This is widely used by all Hindi Newspapers and Hindi Fonts developed by various private companies. Therefore, the recommendation was to update the default behavior with conjunct like श्‍व.

Dear @pcm8081, please feel free to reopen the issue if you have follow-up thoughts on this matter.


adapt-windows-system

PR Checklist

[ ] Fix linting errors
[ ] Label has been added

Change information
resolve #57

我拿 gen 只是举个栗子.... 具体命名你斟酌一下...

我拉你的代码在 mac 下跑跑
等会


Added Blog Post creation API

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
Attention: Patch coverage is 87.31563% with 43 lines in your changes missing coverage. Please review.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Files
Coverage Δ

blog_platform/api/__init__.py
100.00% <100.00%> (ø)

blog_platform/api/v1/auth.py
100.00% <100.00%> (ø)

blog_platform/api/v1/user.py
100.00% <100.00%> (ø)

blog_platform/config.py
100.00% <100.00%> (ø)

blog_platform/core/database/db.py
100.00% <100.00%> (ø)

blog_platform/core/database/models.py
100.00% <100.00%> (ø)

blog_platform/services/blog_post_service.py
100.00% <100.00%> (ø)

blog_platform/unit_tests/api/test_auth.py
100.00% <100.00%> (ø)

..._platform/unit_tests/api/test_user_registration.py
100.00% <100.00%> (ø)

...form/unit_tests/services/test_blog_post_service.py
100.00% <100.00%> (ø)

... and 14 more


Constant rate of getting wrong responses

I had trained my bot to be able to recognize some statements. But I realised that the bot will always get the correct response for 3 times and wrong response for 3 times and again correct response for 3 times and so on. Would you mind to help me look into it? Thank you.

No chance to support you when you don't provide more information.
Code?
Data used to train?
Actual example?

No chance to support you when you don't provide more information.
Code?
Data used to train?
Actual example?


Fetch feature seems to be broken

I'm using M3 Mac and the fetch feature seems to be broken.
pub fn new()  {
        let browser = Browser::new(
            LaunchOptions::default_builder()
                .headless(true)
                .build()
                .unwrap(),
        )
        .unwrap();
}

This is code I used to spawn browser and
headless_chrome = { git = "https://github.com/rust-headless-chrome/rust-headless-chrome", features = [
    "fetch",
] }

This is the cargo.toml file.
The chrome keep tries to open and fails. I tried to go to the location of downloaded chromium and open it, but it also failed.
the log is
[2024-06-07T05:36:49Z INFO  headless_chrome::browser::fetcher] Getting project dir
[2024-06-07T05:36:49Z INFO  headless_chrome::browser::process] Launching Chrome binary at "/Users/username/Library/Application Support/headless-chrome/mac_arm-1095492/chrome-mac/Chromium.app/Contents/MacOS/Chromium"
[2024-06-07T05:36:49Z INFO  headless_chrome::browser::process] Started Chrome. PID: 40036
[2024-06-07T05:37:19Z INFO  headless_chrome::browser::process] Launching Chrome binary at "/Users/username/Library/Application Support/headless-chrome/mac_arm-1095492/chrome-mac/Chromium.app/Contents/MacOS/Chromium"
[2024-06-07T05:37:19Z INFO  headless_chrome::browser::process] Killing Chrome. PID: 40036
[2024-06-07T05:37:49Z INFO  headless_chrome::browser::process] Launching Chrome binary at "/Users/username/Library/Application Support/headless-chrome/mac_arm-1095492/chrome-mac/Chromium.app/Contents/MacOS/Chromium"
[2024-06-07T05:37:49Z INFO  headless_chrome::browser::process] Killing Chrome. PID: 40169
[2024-06-07T05:38:19Z INFO  headless_chrome::browser::process] Launching Chrome binary at "/Users/username/Library/Application Support/headless-chrome/mac_arm-1095492/chrome-mac/Chromium.app/Contents/MacOS/Chromium"
[2024-06-07T05:38:19Z INFO  headless_chrome::browser::process] Killing Chrome. PID: 40365
[2024-06-07T05:38:49Z INFO  headless_chrome::browser::process] Launching Chrome binary at "/Users/username/Library/Application Support/headless-chrome/mac_arm-1095492/chrome-mac/Chromium.app/Contents/MacOS/Chromium"
[2024-06-07T05:38:49Z INFO  headless_chrome::browser::process] Killing Chrome. PID: 40496
[2024-06-07T05:39:19Z INFO  headless_chrome::browser::process] Launching Chrome binary at "/Users/username/Library/Application Support/headless-chrome/mac_arm-1095492/chrome-mac/Chromium.app/Contents/MacOS/Chromium"
[2024-06-07T05:39:19Z INFO  headless_chrome::browser::process] Killing Chrome. PID: 40505
[2024-06-07T05:39:50Z INFO  headless_chrome::browser::process] Launching Chrome binary at "/Users/username/Library/Application Support/headless-chrome/mac_arm-1095492/chrome-mac/Chromium.app/Contents/MacOS/Chromium"
[2024-06-07T05:39:50Z INFO  headless_chrome::browser::process] Killing Chrome. PID: 40512

With linux ubuntu with arm processor, the log is
[2024-06-07T05:49:09Z INFO  headless_chrome::browser::fetcher] Getting project dir
[2024-06-07T05:49:09Z INFO  headless_chrome::browser::fetcher] Chrome download url: https://storage.googleapis.com/chromium-browser-snapshots/Linux_x64/1095492/chrome-linux.zip
[2024-06-07T05:49:10Z INFO  headless_chrome::browser::fetcher] Total size of download: 162 MiB
[2024-06-07T05:49:10Z INFO  headless_chrome::browser::fetcher] Getting project dir
"/home/ubuntu/.local/share/headless-chrome/linux-1095492.zip"
[2024-06-07T05:49:10Z INFO  headless_chrome::browser::fetcher] Creating file for download: /home/ubuntu/.local/share/headless-chrome/linux-1095492.zip
[2024-06-07T05:49:15Z INFO  headless_chrome::browser::fetcher] Extracting (this can take a while): /home/ubuntu/.local/share/headless-chrome/linux-1095492
[2024-06-07T05:49:18Z INFO  headless_chrome::browser::fetcher] Cleaning up
[2024-06-07T05:49:18Z INFO  headless_chrome::browser::fetcher] Getting project dir
[2024-06-07T05:49:18Z INFO  headless_chrome::browser::process] Launching Chrome binary at "/home/ubuntu/.local/share/headless-chrome/linux-1095492/chrome-linux/chrome"
thread 'main' panicked at src/crawler/mod.rs:18:10:
called `Result::unwrap()` on an `Err` value: Exec format error (os error 8)

Thank you.

The same issue. Docker, rust:1.80.0

Any update here? I'm using M3 too, it seems like chrome binary cannot fetch correctly for linux arm architectures. This always will be a problem while creating multi-platform builds


PGP verification issue

Hi @elliotkillick,
to do git verify-tag v1.0.4 I need your public key, where I can get and where I can confirm your fingerprint?
Your Github says:
Open/libre technology advocate, avid developer, infosec aficionado, student & cybersecurity TA @ UofT SCS. PGP: 018F B9DE 6DFA 13FB 18FB 5552 F9B9 0D44 F83D D5

but
debian@debian:~/qubes/qubes-video-companion$ git verify-tag v1.0.4
gpg: Signature made Wed 21 Apr 2021 07:34:10 AM CEST
gpg:                using EDDSA key 018FB9DE6DFA13FB18FB5552F9B90D44F83DD5F2
gpg: Can't check signature: No public key

It looks like you missing F2 at the end.

Whoops, looks like I hit the character limit on my GitHub bio and accidentally truncated a couple characters off the end of my PGP signature. That is indeed my correct signature and this issue has now been fixed.
If you want to get my PGP signature so it says "Good signature" then also run this before git verify-tag:
gpg --keyserver keys.openpgp.org --recv-keys 018FB9DE6DFA13FB18FB5552F9B90D44F83DD5F2


refactor(concurrency): consistent node-level locks

Summary
Follow-up to the (reverted): https://github.com/Kong/kong/pull/13055 - includes a fixup commit to address some log noise issues created by the original PR.

Several places in the gateway need a node-level lock, some of them used slightly different implementations. This refactor brings consistency in the ways we do node-level locking by using the same implementation (concurrency.with_worker_mutex) everywhere.
Note: in order to maintain the logic of declarative.import unaltered, the concurrency.with_worker_mutex function has been slightly modified to return an additional value ttl in case of timeout error, so that retry_after could be implemented as before.
Checklist

[x] (no/refactor) The Pull Request has tests
[x] A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
[x] (no) There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference
KAG-2337

Hi @gruceo could you help and review this PR? thanks


git reset --hard HEAD leaves untracked files behind

When I run git reset --hard HEAD, it's supposed to reset to a pristine version of what you pulled, as I understand it. Unfortunately, it leaves files lying around, as a git status shows a big list of untracked files.
How do you tell git "Just bring it back to EXACTLY what was in the last pull, nothing more, nothing less"?

git clean - Remove untracked files from the working tree
git clean -f -d

-d - Remove untracked directories in addition to untracked files.
-f - equal to --force


fix(@angular-devkit/build_angular): use webpack 4 hooks for karma plugin

Right now, ng test command will get the warning (node:15240) DeprecationWarning: Tapable.plugin is deprecated. Use new API on '.hooks' instead, like #11202
And as angular-cli uses the webpack 4 right now, I just refactor the code to use the new hooks api.

irrelevant failures, maybe rerun can resolve

e2e-cli failed for timed out.
@clydin  could you rerun this for me? thanks

This has been released already ? Or is it aimed for v7? How can I tell ?


checkout-to-tag.sh and build_cronet.sh are missing

native/README.md contains the instructions for building cronet for Envoy.  There are two scripts mentioned there: checkout-to-tag.sh and build_cronet.sh.  They are not in this git repo, nor included in the Chromium/cronet. They contain the key steps to create cronet-release.aar.

now included in 8c6cbaa108276b351e8bb342f33ed99a26c0cad9 from #6


Change external_files_dir logic and permission logic.

Description
Current implementation has problem, it doesn't show sample list well, I tested on Pixel 6 with Android 13.
I removed changing external_files_dir path. It changed directory path from '/storage/emulated/0/Android/data/com.khronos.vulkan_samples/files' to '/storage/emulated/0/com.khronos.vulkan_samples/'. But on the build.md file guide to copy resource to '/storage/emulated/0/Android/data/com.khronos.vulkan_samples/files'. And also it is better to use '/storage/emulated/0/Android/data/com.khronos.vulkan_samples', because it is deleted automatically when application is deleted.
And about the permission, current logic makes not showing sample list on the Android 13 device. it is happen because WRITE_EXTERNAL_STORAGE and READ_EXTERNAL_STORAGE has no effect after API level 33, current logic think application doesn't have permissions. However it can be used without permission request after API level 19. https://developer.android.com/reference/android/Manifest.permission#READ_EXTERNAL_STORAGE https://developer.android.com/reference/android/Manifest.permission#WRITE_EXTERNAL_STORAGE
I add if API level is same or higher than 19(Kitkat), skip the checkPermissions() and assume it already have these permissions. It is also related with not working on S23 device on https://github.com/KhronosGroup/Vulkan-Samples/issues/646.
Fixes #646
General Checklist:
Please ensure the following points are checked:

[x] My code follows the coding style
[x] I have reviewed file licenses
[x] I have updated the header Copyright to reflect the current year (CI build will fail if Copyright is out of date)
[x] I have commented any added functions (in line with Doxygen)
[x] I have commented any code that could be hard to understand
[x] My changes do not add any new compiler warnings
[x] My changes do not add any new validation layer errors or warnings
[x] I have used existing framework/helper functions where possible
[ ] My changes build on Windows, Linux, macOS and Android. Otherwise I have documented any exceptions
[x] My changes do not add any regressions
[x] I have tested every sample to ensure everything runs correctly
[x] This PR describes the scope and expected impact of the changes I am making

Sample Checklist
If your PR contains a new or modified sample, these further checks must be carried out in addition to the General Checklist:

[x] I have tested the sample on at least one compliant Vulkan implementation
[x] If the sample is vendor-specific, I have tagged it appropriately
[x] I have stated on what implementation the sample has been tested so that others can test on different implementations and platforms
[x] Any dependent assets have been merged and published in downstream modules
[x] For new samples, I have added a paragraph with a summary to the appropriate chapter in the samples readme

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@r-kaczynski will check for Samsung devices.

~Tested this branch on S23+ and S22 and after granting permissions I get this screen:  Pressing the "Grant Permissions" button does nothing. I ran into a similar issue when trying to change the java code.~
Same as @SaschaWillems. I checked again and pushing the assets solves the problem.

I've also noticed that when installing the samples on a new device, this screen might also appear if not granting notifications permissions (i.e. we do not have <uses-permission android:name="android.permission.POST_NOTIFICATIONS"/> in the manifest) which makes the error message about assets misleading. Manually granting notifications permissions fixed the issue for me.


stopLineDrawingOnTouchedSpots or toggleLineDrawingOnTouchedSpots

** Don't make a duplicate issue.
Checked and could not find.
Is your feature request related to a problem? Please describe.
Yes, I will have to re draw the whole graph to update how the line is drawn. A feature to stop drawing the line on the touch spot would be nice.
Describe the solution you'd like
LineChartBarData(
  stopLineDrawingOnTouchedSpots: true,
  ...etc
;)

Or the following, where we simply toggle the drawing between touched.
LineChartBarData(
  toggleLineDrawingOnTouchedSpots: true,
  ...etc
;)

Describe alternatives you've considered
I already have something in place:

First I detect the touch spot index, and calculate it's percentage using spots length (tap on 3rd spot out of 10? => 30%).
Then use the percentage and draw different lines with

LineChartBarData(
  gradient: LinearGradient(
    begin: Alignment.centerLeft,
    end: Alignment.centerRight,
    colors: const [
      Colors.red,
      Colors.transparent,
    ],
    stops: [
      tapPercentage,
      tapPercentage,
    ],
  ),

Finally, Re draw when touched. Sadly, it's a bit buggy and does an extra render. Attached is a video of how it is looking now, and you can notice that dragging my finger to another point triggers a re draw of the full line, even when that case is not triggered in my code.

Additional context
https://user-images.githubusercontent.com/108520495/216626327-4cdad008-1d82-4f0f-ac07-d5c2cb9886f3.mov

There is something wrong with your touch handling. Can you please provide me your simplified code here?
(a runnable code to put in a main.dart file)

Sure, you can check the print message to see.
At the start, the value is 1, and at the end as well (when I left my finger.)
Between 0.5 and 0.75 there is no re build, but you can see still see this weird animation.
Here we go, with 1
Setting to 0.5
Here we go, with 0.5
Setting to 0.75
Here we go, with 0.75
Setting to full!
Here we go, with 1

Here is the code sample:
import 'package:flutter/material.dart';
import 'package:fl_chart/fl_chart.dart';

void main() => runApp(const MyApp());

class MyApp extends StatelessWidget {
  const MyApp({
    Key? key,
  }) : super(key: key);
  // This widget is the root of your application.
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Hello World',
      theme: ThemeData(
        primarySwatch: Colors.blue,
      ),
      home: LayoutBuilder(
        builder: (p0, p1) => Scaffold(
          appBar: AppBar(
            // The title text which will be shown on the action bar
            title: const Text('Chart'),
          ),
          body: SizedBox(
            width: p1.maxWidth,
            height: p1.maxHeight,
            child: const MyChart(),
          ),
        ),
      ),
    );
  }
}

class MyChart extends StatefulWidget {
  const MyChart({
    Key? key,
  }) : super(key: key);

  final spots = const [
    FlSpot(1, 1),
    FlSpot(2, 2),
    FlSpot(3, 1),
    FlSpot(4, 3),
    FlSpot(5, 0),
  ];

  @override
  State<MyChart> createState() => MyChartState();
}

class MyChartState extends State<MyChart> {
  double gradeintStop = 1;

  @override
  Widget build(BuildContext context) {
    print('Here we go, with ${gradeintStop}');
    return LineChart(
      LineChartData(
        lineTouchData: LineTouchData(
          enabled: true,
          touchCallback: ((touchEvent, touchResponse) {
            switch (touchEvent.runtimeType) {
              case FlTapDownEvent:
              case FlLongPressMoveUpdate:
              case FlPanUpdateEvent:
                int? index = touchResponse?.lineBarSpots?.first.spotIndex;
                if (index != null && widget.spots.length > 1) {
                  final newStop = index / (widget.spots.length - 1);
                  if (newStop != gradeintStop)
                    setState(() {
                      print('Setting to ${newStop}');
                      gradeintStop = newStop;
                    });
                }
                break;
              case FlTapUpEvent:
              case FlPanEndEvent:
              case FlLongPressEnd:
                print('Setting to full!');
                setState(() {
                  gradeintStop = 1;
                });
                break;
            }
          }),
        ),
        gridData: FlGridData(show: false),
        titlesData: FlTitlesData(show: false),
        borderData: FlBorderData(show: false),
        lineBarsData: [
          LineChartBarData(
            isCurved: true,
            // color: Colors.green,
            gradient: LinearGradient(
              begin: Alignment.centerLeft,
              end: Alignment.centerRight,
              colors: const [
                Color(0xff568200),
                Colors.transparent,
              ],
              stops: [
                gradeintStop,
                gradeintStop,
              ],
            ),
            barWidth: 1,
            dotData: FlDotData(show: false),
            spots: widget.spots,
          ),
        ],
      ),
      swapAnimationDuration: const Duration(milliseconds: 250),
    );
  }
}


ARROW-14693: [R] Non-integers being passed to chunk_size

LGTM, thanks for the fix!

@github-actions crossbow submit -g nightly

Comparing with another pull request since this is at the head of the repository.


Implement QC metrics upload

Whenever mriqc finishes analyzing _bold or _T1w file its metrics should be uploaded to a central location via a JSON HTTP PUT operation.
This should be opt-out - users can disable it via a command line switch.
Information about these metrics being shared should show in logs in the beginning and at the end of the run.
Data submission should be disabled for development versions.

This is finished with #464 right?