[core-http] Fixing a boolean check

This is required to fix the storage-queue tests. - https://github.com/Azure/azure-sdk-for-js/pull/5082

I am reluctant to change core-http without understanding why this is needed... is it possible to figure that out before taking this change? If we'd rather fix this now and ask questions later, I can be convinced, since the change is minimal and seems fairly safe.

Not needed.
Going for non-breaking changes from master to feature branch for storage SDKs.
More info - https://github.com/Azure/azure-sdk-for-js/pull/5082#discussion_r322974919


I would like a mentor

Question: Have you read the mentoring guide? Please only submit this request for general mentoring (not GSoC).
Answer: Yes I have read the mentoring guide.
What is your background? Any experience with Go, Kubernetes, React, Typescript, etc.?
Answer: I have experience  with Go, Kubernetes and a little Typescript but not React
Is there any particular issue you'd like to work on? You may want to check out the list of good first issues.
Answer: I would like to work with issue #10294
Do you want to work with your mentor async (i.e. by Slack messaging or issue comments), or sync (e.g. using Zoom video)? Please include your time-zone if you want to work sync.
Answer: (async) (UTC +8 MYT timezone)

This pre-dates me joining as an active contributor, but nonetheless apologies that this never got a timely response from anyone!
We have now removed the mentoring template as there is not enough bandwidth to support all mentees and we prefer to assist directly on an issue or PR per #11805


FEAT add verbose logging

Fixes #8
Added "--verbose" flag

👍 great contribution.
We will refine and tweak specific log statements over time but this is a great start and something we needed.


test suite nits

Fix some issues spotted by coverity and unbreak no-ocsp
@levitte the failure mode for the no-ocsp enable-tls1_3 mode is pretty poor, as s_client gives usage() but s_server keeps running, so the test suite appears to hang.  Is there something more systematic we should be doing as well?

Pushed to master; closing.


nixVersions.nix_2_19: drop

We are no longer actively fixing bugs in nix 2.19. Other nix versions will follow in a bit.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@roberth I am trying to drop this but your hercules-ci-cnix-store depends on it.
Also nixd, cc @inclyc

If you want to take maintenance over for these nix versions, let me know, but the nix team cannot support so many different nix versions.

I started updating nixd for nix 2.24 here: https://github.com/nix-community/nixd/pull/613

I'll update the hercules-ci-cnix-* bindings.

Mini update update: I've released the updated packages to hackage. Next I'll make a backportable update by cherry-picking 3ff89d8f12b0f2b3ef4cfb9873df6c76a1d9c761, either during the weekend or on Monday.

cc @inclyc for nixd release update.

Last offender: https://github.com/bluskript/nix-inspect/pull/18


Add variable for button border-radius

Hi Team, thanks for your work, like it.
can I ask you to add a css variable for button border-radius
I have fixed button and I don't need it to have opacity, to solve that I think to add an placeholder with my background color under it, but as you can see radius can be different, so would be usefull to have it as separate variable and just reuse in my code
Thanks!

Hi, thank you for your issue. I think it's wrong way to customize single component. I would recommend pass custom class to your Button, you can also make proxy component

@mainsmirnov I would prefer to use --tgui-- variables to make button background-color change by theme change. The issue is that button bezeled (which uses --tgui--accent_text_color as a background color) has background-color opacity - but I don't need opacity when it is fixed.
here you can see alpha of the background-color of 'bezeled' button:

the same issue with disabled button, it has opacity 0.35 itself that makes button opacity issue is even worse

maybe ideally it is better not to make opacity on buttons and its backgrounds to avoid that, but it is how TelegramUI buttons disabled now.
And in that case not transparent placeholder under the button is the solution to get rid from opacity under the fixed button

here is an example of the issue, content is visible under the button because of opacity:

ant this is example what is expected:

Although using color-mix is also a solution to get rid from placeholder, color-mix(in srgb, var(--tgui--accent_text_color) 10%, var(--tgui--bg_color))


Page no longer valid

This page should be removed as this feature was deprecated last year

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: fc0b0ef4-8a7e-0c1e-e9fa-66efbcdf3faa
Version Independent ID: 5b3f4dbb-627b-8e08-0657-f7bdb8ea4082
Content: Enhance device discovery with a Microsoft Defender for IoT Enterprise IoT network sensor - Microsoft Defender for IoT
Content Source: articles/defender-for-iot/organizations/eiot-sensor.md
Service: defender-for-iot
GitHub Login: @limwainstein
Microsoft Alias: lwainstein

Hi @Steve-MS, we recently added a retirement note to this page, and we're considering deleting it going forward. See top of the page:

Registering a new Enterprise IoT network sensor as described in this article is no longer available. For customers with the Azure Consumption Revenue (ACR) or legacy license, Defender for IoT maintains existing Enterprise IoT network sensors.

#please-close


[azopenai] Fixing issue where you can't use whisper with m4a files.

It's one of the formats that doesn't seem to be recognized without an explicit file extension, which you can pass via Filename
Fixes #22195

/azp run go - azopenai

/azp run go - azopenai


Settings: Add Privacy Policy link

Please use "https://vector.im/privacy.html"

Fixed in
https://github.com/vector-im/vector-android/commit/37f2b75a1364226a1512cf2b543bb0f562ce21af


istanbul üniversity student mail

@mhmtonrn I am sorry, the domain ogr.iu.edu.tr is removed from our trusted domains list because it was abused in the past. If you are the student of this school, please enroll to GitHub Student Developer Program. Then apply for JetBrains educational subscription with your GitHub account (GitHub tab at https://www.jetbrains.com/shop/eform/students).


🎨🔥🚨📦💬 change linter, add lint-related changes

Hi,
I've updated the development branch to use eslint-google and edited server.js to be free of linting errors. This mostly consisted of the following;
adding JSDOC comments
removing or formatting lines longer than 80 characters
other stuff that is auto-fixable by using the shortcut: ⌘ · or ctrl ·

To be able to commit this PR, two people need to approve this code review.
Approving a code review can be done by going to the commit (above this page) click on view changes
review it, comment, or request a change in the code.
If changes are acceptable in your opinion, go to the top of the page click review changes
select approve, type a message, and click submit review.


Removing certain object from RQueue doesn't seem to be working

Hi,
I have a certain amount of items meeting some condition in Redis queues that I want to remove.
The general approach I am using:
public class CleanRedis<T> {

    private final RedissonClient redissonClient;

    public CleanRedis(RedissonClient redissonClient) {
        this.redissonClient = redissonClient;
    }

    public void removeFromQueues(boolean predicate) {
        List<String> keys = redissonClient.getKeys()
                .getKeysStreamByPattern("somePattern")
                .collect(Collectors.toList());

        for (String key : keys) {

            RQueue<T> queue = redissonClient.getQueue(key, new FstCodec());
            List<T> items = queue.readAll();

            for (T item : items) {
                if (predicate) {
                    queue.remove(item);
                }
            }
        }
    }
}

The problem is that this item is not removed and false is being returned..
When calling RQueue.contains(T item) I get false, even thought the item is in the queue, as its details are printed in logs.
I don't know if that helps, but I was testing this on a queue that has only one item. I wanted to remove that single item from the queue.
Can you please take a look at this?
Thanks

Unable to reproduce. Below is the test:
        RQueue<Integer> queue = redisson.getQueue("test");
        queue.add(1);

        List<Integer> tt = queue.readAll();

        for (Integer integer : tt) {
            assertThat(queue.remove(integer)).isTrue();
        }
        assertThat(queue.size()).isZero();

FstCodec is deprecated

What other codec can I use instead?
Class is not annotated as deprecated though.


Changing the app key to be static instead of dynamic based on the host.

This should allow multiple front end apps to run on separate ports and use the same data on the backend.

Looks good @RobertKelly. Thanks!


Integration tests improvement

Not sure if it is possible but, would it be possible to have a testing API that lets test click and enter text inside the vscode window? This would allow me to automate all of the checks i have to manually do. Something like puppeteer.

You can use the TextDocument.applyEdit API from vscode.

Thats not quite what im after. I would like somethnig that would allow me to interact with the UI. For example to right click on a item in the SCM changes list and then click a content option.

For example to right click on a item in the SCM changes list and then click a content option.

That's out of the scope of this utility.

I am also looking for something similar. Since vscode-test supports opening a VS Code editor for running tests, shouldn't support for actually simulating interactions be supported as well ? Without that support, it feels a bit incomplete for me.
In my opinion, if it is out of the scope of this project, at least some hint as to how we should be doing this in the documentation would help the extension developers a lot.

This project only helps you to automate extension test by calling VS Code API, which should satisfy most of the cases for testing extensions.
So you should go to https://github.com/Microsoft/vscode asking for API that allows you to do things like:

Move mouse to (600, 600)
Click
Move mouse to a DOM selector
Right Click

But that's against the VS Code API design principle, see https://code.visualstudio.com/api/extension-capabilities/overview#no-dom-access
If you have concrete cases where you cannot properly test an extension with the current API, open issue at microsoft/vscode to discuss.

We (python extension) do this today using puppeteer (https://github.com/microsoft/vscode-python/tree/master/uitests)

Thank you @octref & @DonJayamanne ! That is helpful !


Priority 5 - Center wise staff reassign in one click

The screen should allow to select the staff name. based on the staff selection the center list should be displayed. The user should be able to select all / few center and click on reassign.The user should be prompted to select new staff name. on click of submit the existing staff of the centers should be unassigned and the new staff should be reassigned.

The ideal flow would be to change the staff values in the centre, its more like a bulk tool or batch tool, now to implement this , it seems like we need to design new screens somewhere in the centres or in the orgs, it would populate all the staff, based on the centre selected and then re-select another staff except the selected one.
Let me know to me, it seems like a tricky one since I don't understand the need of re-assigning the staff in bulk manner, when you can do it one by one.

since it a development, for now, you can reduce the priority of this task, you can resume this task once i tell you in future, and concentrate on the other mentioned issues.


GUACAMOLE-412: Prevent exception propagation for null UserContext

Changes to event listeners from GUACAMOLE-364 (#184) cause modules that do not have a UserContext object to fail at login.  This is a potential fix for that issue - preventing the GuacamoleResourceNotFoundException from propagating down and instead just throwing a warning and debug message into the log file.  Not sure if this is the preferred way to go, or if there are other implications to this?

We may have more problems than simply the unexpected ramifications of an exception:

userContext = session.getUserContext(
    authenticatedUser.getAuthenticationProvider().getIdentifier());

I didn't notice this angle during my review, but it doesn't make all that much sense to fire an event with the UserContext associated with the AuthenticationProvider that produced the AuthenticatedUser. Back when event listeners originally existed, Guacamole only supported one AuthenticationProvider at a time, and there was only one UserContext. That API doesn't make much sense now, since multiple UserContext objects may exist for any one session.

That API doesn't make much sense now, since multiple UserContext objects may exist for any one session.

So, are you thinking that the AuthenticationSuccessEvent needs to be changed to just get the entire GuacamoleSession object?  Or some other direction?

So, are you thinking that the AuthenticationSuccessEvent needs to be changed to just get the entire GuacamoleSession object? Or some other direction?

Not the GuacamoleSession object, as that's internal to the webapp and not part of the public API, but yeah - it looks like AuthenticationSuccessEvent (and perhaps anything from UserEvent onward) needs some rethinking.
Exposing AuthenticatedUser instead could make sense. If the event is fired once for each AuthenticationProvider, exposing both AuthenticatedUser and UserContext could also work.
Any thoughts, @ceharris?

If the event is fired once for each AuthenticationProvider, exposing both AuthenticatedUser and UserContext could also work.

...keeping in mind that, if we do this, we still have to deal with null UserContext objects in a way that doesn't kill the authentication process.

Sort of, but in the current API, it's AuthenticatedUser that defines identity (and that identity may not be readily derived from simply the Credentials), so receiving a Credentials instead of AuthenticatedUser makes less sense now.
As for the potential lack of UserContext, as it's not guaranteed to be defined for a given AuthenticationProvider, this should simply be null if unavailable.

...so receiving a Credentials instead of AuthenticatedUser makes less sense now.

Okay...I can take a stab at reworking the listeners with the AuthenticatedUser object instead of Credentials, and then see if @ceharris has any feedback or suggestions.

As for the potential lack of UserContext, as it's not guaranteed to be defined for a given AuthenticationProvider, this should simply be null if unavailable.

Agreed, but the point of this PR is that it's the attempt to retrieve the UserContext object that causes the exception to be thrown that kills the authentication process when UserContext null.  So, either the code above is needed to prevent that exception from being passed on down the line, or the code in the GuacamoleSession object that throws the exception needs to be tweaked to just return null instead of throwing an exception (which then has other implications for stuff that expects a 404 error when a UserContext is not available.  Or is there another alternative you're thinking of to handle this?

Including AuthenticatedUser in UserEvent makes a lot of sense. This would allow UserEvent.getUserContext to be implemented such it delegates to the AuthenticationProvider associated with AuthenticatedUser to get the UserContext instead of requiring this context object in the event constructor. Not needing the context object to construct the event would avoid the exception that is the subject of this PR.
Similarly CredentialsEvent.getCredentials could be implemented such that it calls AuthenticatedUser.getCredentials, eliminating the need for it in the event constructor as well.
In thinking about per-provider notifications, it also occurs to me that these authentication events should probably include an AuthenticationProvider property.  As it stands right now, a recipient of an AuthenticationFailureEvent doesn't seem to have an easy way to figure out which provider failed the authentication.

Including AuthenticatedUser in UserEvent makes a lot of sense. This would allow UserEvent.getUserContext to be implemented such it delegates to the AuthenticationProvider associated with AuthenticatedUser to get the UserContext instead of requiring this context object in the event constructor. Not needing the context object to construct the event would avoid the exception that is the subject of this PR.
Similarly implementing CredentialsEvent.getCredentials for AuthenticationSuccessEvent could delegate to AuthenticatedUser.getCredentials, eliminating the need for it in the event constructor as well.

So, do the most recent changes look like they address this correctly?

In thinking about per-provider notifications, it also occurs to me that these authentication events should probably include an AuthenticationProvider property. As it stands right now, a recipient of an AuthenticationFailureEvent doesn't seem to have an easy way to figure out which provider failed the authentication.

I glanced briefly at the failure event, but didn't look real close - I'll try to tweak that one to address this, as well.

I glanced briefly at the failure event, but didn't look real close - I'll try to tweak that one to address this, as well.

Turns out this will take a little bit more than minor tweaks to unwind - getting the authentication provider object with what's currently there takes a little doing.  I think it could be retrieved from the UserContext object, but this requires retrieving the UserContext object (which may or may not exist), so it throws the whole ResourceNotFoundException back into the mix, this time on the failure side.  I'll take a little bit of a closer look and see what I can figure out.

Per recent discussion on the mailing lists, the release process for 0.9.14-incubating has begun, and the issue associated with this change (GUACAMOLE-412) is within scope. Please update the merge base of this PR to point to staging/0.9.14-incubating.

I glanced briefly at the failure event, but didn't look real close - I'll try to tweak that one to address this, as well.

FWIW, I'm not seeing a great way to do this right now.  Maybe I'm missing something really simple, but it seems like it would take a lot of changes in a lot of places to get this info into the failure event.  I move that we table that for another time/issue, and move forward with whatever changes need to be made here to deal with this regression.  Objections?

Well, handling the regression is definitely the priority, but creating a new instance of the UserContext for each event isn't something we should do. There isn't a way around this which will not require API changes, either now or in a subsequent release, such that the proper data is made available at the proper time.
If we want the event API to be part of 0.9.14-incubating, I would say the only thing that makes sense is to remove UserContext from the auth success event entirely. I'd be glad to take a stab at the refactor for this.
If there is concern over the new API in general, then the choice would be to roll back those changes, and let them be reconsidered for a later release.

I'd be glad to take a stab at the refactor for this.

Sounds good - I won't be offended :-).

Heh. Very well.

Heh. Very well.

Sounds so enthusiastic.  I'm not opposed to looking at it myself, but I might take longer than we want to wait for 0.9.14-incubating, and I'm pretty sure this fixed in there one way or the other.

If there is concern over the new API in general, then the choice would be to roll back those changes, and let them be reconsidered for a later release.

I think the new API is fine, and this is the only error I've run into with those changes, but obviously impacts any of the extensions that don't provide UserContext objects, which is no longer an insignificant number.  So, I lean more toward sticking with the new API and taking care of this regression than rolling everything back - unless you'd like me to keep hacking it and/or think it's just going to cause significant delays to getting the 0.9.14-incubating release out??

Sounds so enthusiastic.

Don't read too much into my periods. ;)
I'm about to open a PR with my changes.

Closing in favor of Mike's changes.


Walking up on vphysics stairs is inconsistent

Stairs that use vphysics collisions (brush entities or props) are inconsistent compared to IVP.
In the following videos, the translucent stairs are func_brushes with solidbsp 0 and the opaque ones are func_detail.
Volt
IVP

Can you provide the map?

Sure! Here you go:
stairstest.zip

Found a (hopefully) temporary workaround, but it might lag more...at least in Garry's Mod.
Increase vjolt_player_collision_tolerance until you can walk up them normally consistently.

Increasing vjolt_player_collision_tolerance had no effect when it comes to stairs, at least in both CS:S and Momentum.

In Garry's Mod, I have to increase it to a very high value of 1000. I am unable to test Vjolt anywhere else unfortunately.

Should be improved now?


Add whitespace to list of invalid characters for minecraft username in application

If you look here:
https://github.com/mattboy9921/MauveList/blob/eb61fabc86989a594264dec9d8fe78a488b035e9/src/main/java/net/mattlabs/mauvelist/util/PlayerUtils.java#L55
username.matches("\\w+") will only match alphanumeric characters and the underscore. So spaces will cause this to be false and invalidate the check.
This is code from the upcoming release so it should be fixed once that comes out.


Add topics to repos

So we can find them better in the github search (and maybe use it for gittio) we should add tags/topics to the repos.
for our modules:
titanium-module, titanium-sdk
for the repos (e.g. the sdk):
titanium-sdk and other like mobile native android ios like https://github.com/tidev/titanium_mobile if appropriate

@hansemannn the issue about the github topics
Then we can scape e.g. https://github.com/topics/titanium-module (115 already)

I remember going through all the repos and making sure the topics were semi-accurate. It's not a bad way to get a list of modules.

Here is an example API request that returns all repos with the label "titanium" or "ios". We could fine-tune it as we develop it: https://api.github.com/search/repositories?q=titanium native in:topics&sort=created&order=asc

Let's goooo! https://github.com/tidev/module-search-www

Random ideas.
Could have different levels of "verification". If module not updated for X years then show a warning. If module has tag for "ti-sdk-12" then can show it supports the latest SDK for eg.
Also show the number of stars the module repo has of course 😀

some early feedback:
I think the results should not be a direct github api call. A cronjob should do the crawl and check the repo for "ios/manifest" or "android/manifest". That would remove many false positives.
And add a weight to the title. If I search for "map" the actual ti.map is the 3rd result. First one is mixpanel, 2nd the sdk itself.
If you clear the complete input field it will break everything.

Yep, an own site aka gitt.io would be great, but also creates much more overhead to initially create. I wanted to get something out quickly, but of course if can be extended. Next.js also has the capability to do the server-side work directly in the same project (via the /api folder), so that could be a quick start.

I am in favour of using Next.js as I think it is the tool of choice for the overall website and would have broader interest from other devs moving forward in terms of contributing etc. Also provides a lot of options around tooling and ecosystem.

Good idea! Maybe JavaScript could be added in the query, there are some CommonJS or Hyperloop modules.

It's all open source, go for it! :)


Update API endpoints

This pull request introduces several changes to the compass_sdk/compass.py file, primarily focusing on improving error handling, formatting, and function parameterization.

Error Handling: The error_window is now initialized with a maximum length (maxlen) to keep track of the results of the last N API calls. This is used to calculate the error rate and determine if the insertion process should be stopped.
Function Parameterization: The put_request function now includes an additional parameter, num_doc, which is passed to the delayed function call. This change ensures that the num_doc parameter is correctly utilized within the function.
Formatting: The code has been reformatted for consistency and readability. This includes adding parentheses around imported modules and adjusting indentation for better code structure.
Exception Messages: The exception messages for CompassAuthError and CompassMaxErrorRateExceeded have been updated to include parentheses for better formatting.
API Endpoints: The API endpoints for search_documents and refresh have been updated to use the correct paths.
Function Calls: The function calls within the _send_request_with_retry function have been modified to include parentheses for better clarity and consistency.

The unit tests are failing, some mock testing the calls.

Change itself LGTM, perhaps we want to change push_documents to upload_documents but we can have a second PR for that, up to you.

The unit tests are failing, some mock testing the calls.

Fixed.

Change itself LGTM, perhaps we want to change push_documents to upload_documents but we can have a second PR for that, up to you.

Good point. Renamed "push" to "upload".

There is some naming discussion [classical last min :( ] do you mind holding this for an extra hour?

There is only one change missing:
https://github.com/cohere-ai/compass/blob/fcf3484d25b5b7230cb3f7ae97565f0cfae92131/api/src/api/server.py#L579
check the paremeters of the Upload, done that I can approve. Thanks a lot.

There is only one change missing:
https://github.com/cohere-ai/compass/blob/fcf3484d25b5b7230cb3f7ae97565f0cfae92131/api/src/api/server.py#L579
check the paremeters of the Upload, done that I can approve. Thanks a lot.

Done.


Doc/usage of @format should update

Clear and concise description of the problem
Per previous discussion with @timotheeguerin @iscai-msft and @tadelesh , @format should not be used nor be recognized by TCGC therefore our generator will not even know the existence of these decorator which is quite misleading for our users.
Checklist

[X] Follow our Code of Conduct
[X] Read the docs.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

Some generator might/will make use  of it. Service code gen could do it for validation, openapi emitters also use it to carry over that info if needed. Feels to me like docs on the client docs

@markcowl ask author to move


how to use hcm filter?

hi, guys! i want to distribute flow in egress by using hcm, such as
www.xxx.com:8000(sidecar) -> clusterA(egress)
www.yyy.com:8000(sidecar) -> clusterB(egress)
rest request (sidecar) -> original process(egress)
the match request can be routed correctly，but how about the unmatched request?
the unmatched request get 404 response now.
i want to unmatched request to be processed in the original path.
so how can i modify yaml configure to achieve this goal ？？does there have best practice？
apiVersion: networking.istio.io/v1alpha3
kind: EnvoyFilter
metadata:
  name: test
  namespace: istio-system
spec:
  workloadSelector:
    labels:
      istio: egressgateway
  configPatches:
    - applyTo: NETWORK_FILTER
      match:
        context: GATEWAY
        listener:
          filterChain:
            filter:
              name: "envoy.filters.network.http_connection_manager"
      patch:
        operation: REPLACE
        value:
          name: envoy.filters.network.http_connection_manager
          typed_config:
            "@type": "type.googleapis.com/envoy.extensions.filters.network.http_connection_manager.v3.HttpConnectionManager"
            codec_type: AUTO
            stat_prefix: ingress_http
            route_config:
              name: local_route
              virtual_hosts:
              - name: local_service1
                domains: ["www.xxx.com:8000"]
                routes:
                - match:
                    prefix: "/"
                  route:
                    host_rewrite_literal: www.xxx.com:80
                    prefix_rewrite: "/"
                    cluster: "clusterA"
              - name: local_service2
                domains: ["www.yyy.com:8000"]
                routes:
                - match:
                    prefix: "/"
                  route:
                    host_rewrite_literal: www.yyy.com:80
                    prefix_rewrite: "/"
                    cluster: "clusterB"

            http_filters:
              - name: envoy.filters.http.router
                typed_config:
                  "@type": "type.googleapis.com/envoy.extensions.filters.http.router.v3.Router"

    #... other configure here.
    # cluster configure

Why not use  https://istio.io/latest/docs/reference/config/networking/virtual-service/ here?

Why not use https://istio.io/latest/docs/reference/config/networking/virtual-service/ here?

sorry for late!
thanks a lot. i have solved this problem in my way.
i will close this issue.


Automatic Lexer from Regex expressions

could be useful for simple cases.
fully fledged compilers will probably still want to implement their own lexer.

https://github.com/SAP/chevrotain/pull/26


(PUP-10480) Deprecate 'puppet module search'

Rather than using puppet module to search for modules, users should
go to the Puppet Forge to search modules.

It looked like there were a few places to put the deprecation warning, so I just did all of them. Let me know if I should remove or consolidate any of this.


Dont require GITHUB_TOKEN to generate.

Error: env GITHUB_TOKEN is not set```

GITHUB_TOKEN is required because brewfile-desc is designed to go directly to the GitHub repository, not locally (assuming it is not installed) :pray:


Session management update

The following updates/features included in this merge:

login_oidc() now handles a return url parameter provided by gateway middleware and redirects after login
the logout endpoint will now redirect to the keycloak logout endpoint regardless of having an active cookie
new render_candig_template() wrapper for flask.render_template to help load environment variables when loading candig dashboard-related pages
removed unused endpoints
updated docstrings

Codecov Report

Merging #51 into develop will increase coverage by <.01%.
The diff coverage is 29.41%.

@@             Coverage Diff             @@
##           develop      #51      +/-   ##
===========================================
+ Coverage    80.67%   80.67%   +<.01%
===========================================
  Files           37       37
  Lines        14559    14554       -5
  Branches      1437     1439       +2
===========================================
- Hits         11746    11742       -4
+ Misses        2336     2335       -1
  Partials       477      477

Impacted Files
Coverage Δ

ga4gh/server/frontend.py
66.49% <29.41%> (-0.09%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6994c1...e5eb301. Read the comment docs.


[RFC] Explicitly call loaders

Is your feature request related to a problem? Please describe.
I got a little frustrated that the loader functions always have to be named load. It's easy to use, it works fine but it feels a little implicit for me.
I stumbled into this because I wanted to convert an integer array to bytes:
def load(obj, env=None, silent=True, key=None, filename=None):
    obj.set("my_var", bytes(obj.my_var))

Since this is so short, I didn't want to create another module just to put it in there and ended up leaving it in config.py. It feels a little odd to reference itself when passing additional loaders, and it's also odd that I cannot change that function's name.
settings = Dynaconf(
  loaders = ['my_program.config', 'dynaconf.loaders.env_loader'
)

Describe the solution you'd like

Explicitly pass the function names when describing loaders as strings:

# current
LOADERS_FOR_DYNACONF=[
    'myprogram.my_custom_loader',
    'dynaconf.loaders.env_loader'
]
# new
LOADERS_FOR_DYNACONF=[
    'myprogram.my_custom_loader.bananas',
    'dynaconf.loaders.env_loader.load'
]

This could also help declaring multiple loaders in a single file.

Using objects as loaders  would be great also! #612

settings = Dynaconf(
  loaders = [loader_tapioca]
)

Describe alternatives you've considered
My specific issue seems that can be solved with the cast argument for Validators. That would also look very good in the code! I haven't found the documentation for this feature, maybe I can help to document it if it's ok for you guys.

I like the idea of adding :function_name to the loaders string.
Alternatives that can work right now:
1 calling your loaders explicitly
from dynaconf import Dynaconf
from yourloader import your_loader_function

settings = Dynaconf(...)
loader_function(settings)

2 using hooks
Place a file called dynaconf_hooks.py next to your settings file.
def post(settings):
    return {.....}


Ryan- Thanks for this directive.  We have a couple of issues, hopefully you can help with...

Problem #1 - We're using hm-tap on several elements but we were getting 'ghost' taps and problems with the tap being propagated despite our attempts to prevent propagation.
We tried to resolve this with by including hm-manager-options='{"enabled":true,"preventGhosts":true}' with the hm-tap elements but we didn't see any result from including the hm-manager-options.
To make it work, we had to put a timeout on all of our hmtap functions to prevent 'ghost' taps or double taps.  The timeout solution seems to work on some devices but not on others.
Do you have any idea why the hm-manager-options isn't working for us?
Problem #2 - hm-swipe-left - Our app contains infinite vertical scrolling like twitter or instagram.  We tried to include swipe/left/right functionality on elements inside the vertical scroll and it completely disable vertical scrolling.   Again we tried to use hm-manager-options to enable default vertical scrolling (i.e. preventDefault:false,) by including hm-swipe, but again we didn't have a positive result, so we have had to disable all swipe/left/right functionality because it disables our default vertical scrolling.
Are we implementing the hm-manager-options wrong?
Should we be focusing on hm-recognizer-options?
Thanks again for this.  Hope all is well.

Problem #2 - hm-swipe-left - Our app contains infinite vertical scrolling like twitter or instagram. We tried to include swipe/left/right functionality on elements inside the vertical scroll and it completely disable vertical scrolling. Again we tried to use hm-manager-options to enable default vertical scrolling (i.e. preventDefault:false,) by including hm-swipe, but again we didn't have a positive result, so we have had to disable all swipe/left/right functionality because it disables our default vertical scrolling.
Same here, not sure what to do to fix this..

I'm getting the same problem with hm-pan.

Hey all, I got #2 to work by doing:
{"type":"pan","directions":"DIRECTION_HORIZONTAL"}

For me it was
{"type":"swipe","directions":"DIRECTION_HORIZONTAL"}
That fixed it. Thanks!

@beaubarbour , didn't notice this issue and opened new one, related to your first part, with possible solution #42. Could you plz check if it works for you?

Can this be closed?
That first issue you have is a bigger problem with the Hammer library that I have a fix in for, but who knows if/when that will be integrated into their baseline.

Hi Ryan, you saying you have a fix for #1 - can you provide the solution? The Problem still seems to be there :(


[WFLY-14115] Tests failures in multinode with security manager enabled affect other tests

Issue: https://issues.redhat.com/browse/WFLY-14115
Summary of the PR:

Adding FilerPermission on client node to be able to delete xa recovery file in case security manager is enabled.

@gaol Sorry, I somehow missed this PR which is equal to mine.


Docs aren't clear on what the "containers" block in config is for

@gansbrest I'm a little uncertain how the "containers" block in the config factors in to everything. Is it supposed to work like the Fig project (www.fig.sh) where it will actually spin up my cluster for me in Boot2Docker?
I think this project has a lot of use for people working on Node and Front-end based projects that rely on file watchers to do their work. This is a problem I have been working on for quite some time with no luck. I have been trying to integrate Unison into the solution, but it seems you have found a much cleaner way to do that. I'd like to learn more about how we can start leveraging Hodor, and help contribute to it's development.

Not sure if it's still active. Closing for now.

What if I use docker-compose? Does it mean I have to duplicate it in the hodorfile?

Hodor is alternative to docker compose with some special sauce on top
(especially important is volume sharing). We use just hodor, but if you
want to have both, then yes you need to create .hodorfile as well (some
parts are different from compose one)
On Jun 6, 2015 3:16 AM, "BENOIT Julien"<EMAIL_ADDRESS>wrote:

What if I use docker-compose? Does it mean I have to duplicate it in the
hodorfile?
—
Reply to this email directly or view it on GitHub
https://github.com/gansbrest/hodor/issues/7#issuecomment-109542200.


[Question] Module API to get the replication stream

Are there any module API which would provide the final command getting executed on a primary or any API that provide access to the replication stream?
Alternatives
Command filter provides an option to get the command argument received by the server. However, it isn't sufficient in some cases like Hyperloglog, random operations like SPOP  as it can undergo change before the execution.

Starting a issue in valkey package https://github.com/valkey-io/valkey/issues/921


ARROW-8043: [Developer][CI] Provide better visibility for nightly builds

Add a status.json to the gh-pages summary of nightly builds to get around rate limiting

@github-actions crossbow submit -g nightly

@bkietz thanks for doing this. I did some refactoring to better encapsulate the status and asset handling - I should have done it earlier.


How do I use the dashboard theme with vim-plug?

I dont use packer or paq, should i just switch to those?  I'm new to vim stuff

    Plug 'goolord/alpha-nvim'

    lua << EOF
      require'alpha'.setup(require'alpha.themes.dashboard'.config)
    EOF

@goolord
Error detected while processing /home/joey/.config/nvim/init.vim:
line   18:
E5107: Error loading lua [string ":lua"]:3: '=' expected near 'call'
Press ENTER or type command to continue

init.vim.txt

it has to go at the end of the file with the proper indentation, not in the middle of the packer plug#begin()

@goolord
Error detected while processing /home/joey/.config/nvim/init.vim:
line   17:
E5107: Error loading lua [string ":lua"]:3: '=' expected near '<eof>'
Press ENTER or type command to continue

init.vim.txt

call plug#begin()
    Plug 'ryanoasis/vim-devicons'
    Plug 'ayu-theme/ayu-vim'
    Plug 'mcchrish/nnn.vim'
    Plug 'ms-jpq/coq_nvim'
    Plug 'goolord/alpha-nvim'
call plug#end()

set termguicolors
let ayucolor="dark"
colorscheme ayu
set number

lua << EOF      require'alpha'.setup(require'alpha.themes.dashboard'.config)
EOF

like this

that worked! thanks!


Mirror depth buffer glitching

Also the performance is bad, as if there were several clears.

Works now


UnicodeDecodeError when training

When I run the 1st training stage :
CUDA_VISIBLE_DEVICES=0 python train.py --config=miniImageNet_Conv128CosineClassifier

But it comes to an error like this :
Traceback (most recent call last):
  File "train.py", line 72, in <module>
    dataset_train = MiniImageNet(phase=train_split)
  File "C:\Users\lenovo\Desktop\FewShotWithoutForgetting\dataloader.py", line 122, in __init__
    data_train = load_data(file_train_categories_train_phase)
  File "C:\Users\lenovo\Desktop\FewShotWithoutForgetting\dataloader.py", line 90, in load_data
    data = pickle.load(fo)
UnicodeDecodeError: 'ascii' codec can't decode byte 0x91 in position 1: ordinal not in range(128)

Environment  Python 3.7,  pytorch 0.4
Thanks.

When I run the 1st training stage :
CUDA_VISIBLE_DEVICES=0 python train.py --config=miniImageNet_Conv128CosineClassifier

But it comes to an error like this :
Traceback (most recent call last):
  File "train.py", line 72, in <module>
    dataset_train = MiniImageNet(phase=train_split)
  File "C:\Users\lenovo\Desktop\FewShotWithoutForgetting\dataloader.py", line 122, in __init__
    data_train = load_data(file_train_categories_train_phase)
  File "C:\Users\lenovo\Desktop\FewShotWithoutForgetting\dataloader.py", line 90, in load_data
    data = pickle.load(fo)
UnicodeDecodeError: 'ascii' codec can't decode byte 0x91 in position 1: ordinal not in range(128)

Environment Python 3.7, pytorch 0.4
Thanks.

Hello, have you fixed this problem?

When I run the 1st training stage :
CUDA_VISIBLE_DEVICES=0 python train.py --config=miniImageNet_Conv128CosineClassifier

But it comes to an error like this :
Traceback (most recent call last):
  File "train.py", line 72, in <module>
    dataset_train = MiniImageNet(phase=train_split)
  File "C:\Users\lenovo\Desktop\FewShotWithoutForgetting\dataloader.py", line 122, in __init__
    data_train = load_data(file_train_categories_train_phase)
  File "C:\Users\lenovo\Desktop\FewShotWithoutForgetting\dataloader.py", line 90, in load_data
    data = pickle.load(fo)
UnicodeDecodeError: 'ascii' codec can't decode byte 0x91 in position 1: ordinal not in range(128)

Environment Python 3.7, pytorch 0.4
Thanks.

Hello, have you fixed this problem?

This problem had been fixed : data = pickle.load(fo, encoding='bytes'),
but I got other problems

Thanks a lot!
Maybe we can work on it together.

However, when using the ‘bytes’ encoding rule, I met another problem below:
Traceback (most recent call last):
  File "train.py", line 72, in <module>
    dataset_train = MiniImageNet(phase=train_split)
  File "/media/eternal-wang/D/Research/FSL/FewShotWithoutForgetting-master/dataloader.py", line 124, in __init__
    self.data = data_train['data']
KeyError: 'data'

But after changed into ‘iso-8859-1’，the problem disappeared.

However, when using the ‘bytes’ encoding rule, I met another problem below:
Traceback (most recent call last):
  File "train.py", line 72, in <module>
    dataset_train = MiniImageNet(phase=train_split)
  File "/media/eternal-wang/D/Research/FSL/FewShotWithoutForgetting-master/dataloader.py", line 124, in __init__
    self.data = data_train['data']
KeyError: 'data'

But after changed into ‘iso-8859-1’，the problem disappeared.

Changing bytes to iso-8859-1 ?

Yes.
By the way, I finally make the code running after fixed several bugs.

I got the error in  the log after Changing 'bytes' to 'iso-8859-1' :
Traceback (most recent call last):
  File "/content/drive/My Drive/app/fewshotwithoutforgetting/train.py", line 100, in <module>
    algorithm = alg.FewShot(config)
  File "/content/drive/My Drive/app/fewshotwithoutforgetting/algorithms/FewShot.py", line 32, in __init__
    Algorithm.__init__(self, opt)
  File "/content/drive/My Drive/app/fewshotwithoutforgetting/algorithms/Algorithm.py", line 28, in __init__
    self.init_all_networks()
  File "/content/drive/My Drive/app/fewshotwithoutforgetting/algorithms/Algorithm.py", line 84, in init_all_networks
    def_file, net_opt, pretrained_path, key)
  File "/content/drive/My Drive/app/fewshotwithoutforgetting/algorithms/Algorithm.py", line 90, in init_network
    raise ValueError('Non existing file: {0}'.format(net_def_file))
ValueError: Non existing file: architectures/ConvNet.py

I can't figure it out where is the correct path of this file.
Thanks. @EternalWang

I haven't met this error.
Maybe you should check the path of ./architectures/ConvNet.py ？

Have you met this issue before? @EternalWang
Traceback (most recent call last):
  File "/content/drive/My Drive/app/fewshotwithoutforgetting/train.py", line 110, in <module>
    algorithm.solve(dloader_train, dloader_test)
  File "/content/drive/My Drive/app/fewshotwithoutforgetting/algorithms/Algorithm.py", line 278, in solve
    train_stats = self.run_train_epoch(data_loader_train, self.curr_epoch)
  File "/content/drive/My Drive/app/fewshotwithoutforgetting/algorithms/Algorithm.py", line 308, in run_train_epoch
    self.global_iter = self.curr_epoch * len(data_loader) + self.biter
TypeError: 'float' object cannot be interpreted as an integer

change

self.global_iter = self.curr_epoch * len(data_loader) + self.biter

to

self.global_iter = self.curr_epoch * len(data_loader()) + self.biter

Sorry, how to deal with this problem? @EternalWang
Traceback (most recent call last):
  File "/content/drive/My Drive/app/fewshotwithoutforgetting/train.py", line 110, in <module>
    algorithm.solve(dloader_train, dloader_test)
  File "/content/drive/My Drive/app/fewshotwithoutforgetting/algorithms/Algorithm.py", line 286, in solve
    eval_stats = self.evaluate(data_loader_test)
  File "/content/drive/My Drive/app/fewshotwithoutforgetting/algorithms/Algorithm.py", line 330, in evaluate
    for idx, batch in enumerate(tqdm(dloader())):
  File "/usr/local/lib/python3.6/dist-packages/tqdm/_tqdm.py", line 1022, in __iter__
    for obj in iterable:
  File "/usr/local/lib/python3.6/dist-packages/torch/utils/data/dataloader.py", line 560, in __next__
    batch = self.collate_fn([self.dataset[i] for i in indices])
  File "/usr/local/lib/python3.6/dist-packages/torch/utils/data/dataloader.py", line 560, in <listcomp>
    batch = self.collate_fn([self.dataset[i] for i in indices])
  File "/usr/local/lib/python3.6/dist-packages/torchnet/dataset/listdataset.py", line 54, in __getitem__
    return self.load(self.list[idx])
  File "/content/drive/My Drive/app/fewshotwithoutforgetting/dataloader.py", line 445, in load_function
    Exemplars, Test, Kall, nKbase = self.sample_episode()
  File "/content/drive/My Drive/app/fewshotwithoutforgetting/dataloader.py", line 407, in sample_episode
    Knovel, nTestNovel, nExemplars, nKbase)
  File "/content/drive/My Drive/app/fewshotwithoutforgetting/dataloader.py", line 383, in sample_train_and_test_examples_for_novel_categories
    sample_size=(nEvalExamplesPerClass + nExemplars))
  File "/content/drive/My Drive/app/fewshotwithoutforgetting/dataloader.py", line 250, in sampleImageIdsFrom
    return random.sample(self.dataset.label2ind[cat_id], sample_size)
  File "/usr/lib/python3.6/random.py", line 321, in sample
    result = [None] * k
TypeError: can't multiply sequence by non-int of type 'float'

change

nEvalExamplesPerClass = nTestNovel / nKnovel

to

nEvalExamplesPerClass = int(nTestNovel / nKnovel)

in dataloader.py at line 380

@EternalWang
Traceback (most recent call last):
  File "/content/drive/My Drive/app/fewshotwithoutforgetting/train.py", line 110, in <module>
    algorithm.solve(dloader_train, dloader_test)
  File "/content/drive/My Drive/app/fewshotwithoutforgetting/algorithms/Algorithm.py", line 286, in solve
    eval_stats = self.evaluate(data_loader_test)
  File "/content/drive/My Drive/app/fewshotwithoutforgetting/algorithms/Algorithm.py", line 332, in evaluate
    eval_stats_this = self.evaluation_step(batch)
  File "/content/drive/My Drive/app/fewshotwithoutforgetting/algorithms/FewShot.py", line 84, in evaluation_step
    return self.process_batch(batch, do_train=False)
  File "/content/drive/My Drive/app/fewshotwithoutforgetting/algorithms/FewShot.py", line 87, in process_batch
    process_type = self.set_tensors(batch)
  File "/content/drive/My Drive/app/fewshotwithoutforgetting/algorithms/FewShot.py", line 55, in set_tensors
    self.nKbase = nKbase.squeeze()[0]
IndexError: invalid index of a 0-dim tensor. Use tensor.item() to convert a 0-dim tensor to a Python number

How to fix this problem？Thanks

你已经是个成熟的程序员了，应该学会开动小脑瓜自己debug了。


tmux makes system unresponsive when restoring

it freezes the entire system for 30 secons this didnt happened in start but it does now and every single time any way i can fix this

Hello @samarth-nagar,

What do you mean by "when restoring"?
What OS are you using?
Which tmux version?
Did you enable TPM plugins?

i apologise for poor issue information

im using fedora 39 but same issue was in fedora 38
i have tmux next-3.4
yes i did enabe tpm plugins
by restoring i mean when i open tmux after starting my pc the tmux reload from ressurect plugin which results inbetween of 10-30 seconds

now that i think about it i should have addressed it to the ressurect plugin directly
i can give you my config if you want to recreate the same issue

tmux reload from ressurect plugin which results in between of 10-30 seconds
If tmux-resurrect having issues I can't do much 🤷♂

You may want to try the gh-713 branch that adds instrumentation of TPM activity

The gh-713 branch has been merged.
Feel free to reopen this issue if you believe it's not solely caused by the tmux-resurrect plugin


Investigate AFK Disconnect triggering while in-game

I can't reproduce this, I'm closing this for now.


repository_name: 1.0.1-1 in 'indigo/distribution.yaml' [bloom]

Increasing version of package(s) in repository repository_name to 1.0.1-1:

upstream repository: https://github.com/UTNuclearRoboticsPublic/gauges.git
release repository: https://github.com/UTNuclearRoboticsPublic/gauges-release.git
distro file: indigo/distribution.yaml
bloom version: 0.5.22
previous version for package: null

You can also update the patch of this PR by editing the file in the fork / branch this PR is made from. Then you don't need to create a new PR.


iOS Modal：multiple modal not working

Description
When I need to pop up multiple modals at the same time in react native, it doesn't work properly on iOS. It is presented on the native code of react native, iOS native cannot present multiple controllers at the same time
Version
0.61.5
Output of npx react-native info
System:
OS: macOS 12.6.3
CPU: (8) x64 Intel(R) Core(TM) i5-1038NG7 CPU @ 2.00GHz
Memory: 302.82 MB / 16.00 GB
Shell: 5.8.1 - /bin/zsh
Binaries:
Node: 14.17.3 - /usr/local/bin/node
Yarn: 1.22.10 - /usr/local/bin/yarn
npm: 6.14.11 - /usr/local/bin/npm
Watchman: 20200816.222424.0 - /usr/local/bin/watchman
SDKs:
iOS SDK:
Platforms: DriverKit 22.2, iOS 16.2, macOS 13.1, tvOS 16.1, watchOS 9.1
IDEs:
Xcode: 14.2/14C18 - /usr/bin/xcodebuild
npmPackages:
@react-native-community/cli: ^3.0.0 => 3.2.1
react: 16.9.0 => 16.9.0
react-native: ^0.61.5 => 0.61.5
npmGlobalPackages:
react-native-cli: 2.0.1
Steps to reproduce
Create multiple  in rn, let them display at the same time, it does not work properly in iOS
Snack, code example, screenshot, or link to a repository
Create multiple  in rn, let them display at the same time, it does not work properly in iOS

@coderomw it'll work if you nest modals into one another. Like below. Is this something possible for you?
<Modal1>
    <Modal2>
    </Modal2>
</Modal1>

@coderomw     refer to this pr    https://github.com/facebook/react-native/pull/36262/commits

@coderomw can you test changes from this PR? https://github.com/facebook/react-native/pull/31498

Here is a solution using context if it helps: https://github.com/travis575757/react-native-stackable-modals-tutorial

Hi, here is my solution: maintaining a stack to render multiple modals in a nested manner. https://gist.github.com/icedcrow/c0a43e0a2d898333416f2dba47a86bee


Fix lingering connections due to unclosed response body

response.body() were not closed as required by OkHTTP to close connections.
response.body().string() calls close(), which fixes the issue
Will get rid of log messages such as: "A connection to https://oauth.reddit.com/ was leaked.
Did you forget to close a response body?"

Was there any reason you closed the PR?

Woops, I accidentally deleted the pull request branch doing some cleanup, I'm reopening the request

Thanks, looks good!


There is a typo in the project description?

16 -> 15?
Sequoia

Thanks for reminding me, it has been modified


Changed accountId per address (Metadata, Multisig, Restriction)

Remaining endpoints using :accountId

/account/{accountId} -> looks useful to be able to get the account info by address or public key as needed.

/account/{accountId}/namespaces: ->This endpoint will be dropped in favour of the new namespace generic pagination endpoint.

Closes #151


Refactor icons to not use React.FC

See previous open issue here: https://github.com/layer5io/sistent/issues/224
Needed to open another ticket to track towards making this change for v0.16.0.
React has changes it type definitions which means React.FC will no longer be available to use.

[ ] Update each of the icons to use the appropriate props
[ ] Consider using SvgIcon from @mui/material as it has other properties we can benefit from using

Contributor Guide

🎨 Wireframes and designs for Layer5 site in Figma (open invite)

@nebula-aac Should I refactor all the SVG icons to use the SvgIcon component from mui?
import { SVGProps } from 'react';
import { CARIBBEAN_GREEN_FILL, DEFAULT_HEIGHT, DEFAULT_WIDTH } from '../../constants/constants';
import { SvgIcon } from '@mui/material';

const ColumnIcon = ({
  width = DEFAULT_WIDTH,
  height = DEFAULT_HEIGHT,
  fill = CARIBBEAN_GREEN_FILL,
  ...props
}: SVGProps<SVGSVGElement>) => {
  return (
    <SvgIcon>
      <svg
        width={width}
        height={height}
        xmlns="http://www.w3.org/2000/svg"
        viewBox="0 -960 960 960"
        fill={fill}
        {...props}
      >
        <path d="M120-200v-560h220v560H120Zm250 0v-560h220v560H370Zm250 0v-560h220v560H620Z" />
      </svg>
    </SvgIcon>
  );
};

export default ColumnIcon;


Add documentation for Kubernetes deployment

Current documentation has an demo on getting things running with docker but to get things ready in Kubernetes it's a bit painful with just that, and it being a well-known broadly used platform i think it is an worthy effort.
I have a multi-host (cluster) installation successfully running in an private cluster, let me know if you guys have some interest for me to share it/create a PR with the manifests (yamls) i used.

Hi @vniche, absolutely we have interest. If you want to take a crack at it, I'd recommend a new file, something like docs/install/kubernetes.md to cover the basic steps, gotchas, etc., linking back to the Docker content as necessary. Thanks!

@aetter give me heads up if any on the current version of #59 , i'll give it some more attention on the next days.

Hi there, technical writer here. I am new to open source, but interested in helping with documentation.


idrac_exporter works intermittently

Hi,
Tried to get dellhw_exporter working for quite a while, but then i found out it is intended for baremetal installs (which i do not do).
I however have some issues i can't seem to tackle with idrac_exporter. Below are the details and my troubleshooting steps i've taken:

R630
IDRAC8 (enterprise license)
Lifecycle Controller Firmware: <IP_ADDRESS>
BIOS: 2.18.1
mrlhansen/idrac_exporter:latest docker image
idrac_exporter configured in iDRAC, with varying permissions (from Operator to Administrator)

idrac_exporter version:
2024-05-29T07:39:01.366 INFO  Build information: version=1.3.0 revision=ead63e5c64a0fdb76b84c39f2065900f784d4d0a
2024-05-29T07:39:01.366 INFO  Server listening on <IP_ADDRESS>:9348

/etc/prometheus/idrac.yml:
address: <IP_ADDRESS>
port: 9348
timeout: 60
hosts:
  x.x.224.99:
    username: idrac_exporter
    password: "<snip>"
metrics:
  system: true
  sensors: true
  power: true
  sel: false
  storage: false
  memory: false
  network: false

Prometheus scrape config:
  - job_name: 'iDRAC R630'
    scrape_interval: 60s
    static_configs:
      - targets: ['x.x..224.99']
    relabel_configs:
      - source_labels: [__address__]
        target_label: __param_target
      - source_labels: [__param_target]
        target_label: instance
      - target_label: __address__
        replacement: 192.168.x.x:9348

Output of time running from host where the exporter lives:
time curl localhost:9348/metrics?target=x.x.224.99
real    0m2.971s
user    0m0.004s
sys     0m0.007s

Output of time of my scraper, running on another machine in another VLAN:
time curl 192.168.x.x:9348/metrics?target=x.x.224.99
real    0m2.891s
user    0m0.010s
sys     0m0.000s

Initially i saw values of ~10s to do a scrape. I therefore decided to configure a scrape interval of 30s. I am aware of your comment about carefully deciding which metrics i'd want to collect. I then decided to not do Storage, which let the scrape drop to ~3s.
I also imported the dashboards made by @7840vz, but saw gaps in the graphs. Thinking it has something to do with the dashboard hard-coded for 1m refresh (and thus scrape) so i upped the scrape interval to 60s to match the dashboard. Didn't really help:

During troubleshooting i noticed that whenever i keep a session active on the webGUI of iDRAC itself, the graphs look better, but still not perfect:

Leading to think it's some sort of powersaving feature on iDRAC itself, but there is no "powersaving" feature for iDRAC itself, only the host OS running on the machine.
I'm almost out of ideas, and am thinking of diving into the rabbithole called snmp_exporter with MIB's from Dell to use SNMP to monitor my server. But ideally i would use this exporter, as i can simply point it to an iDRAC, configure credentials and it just works (although intermittently at my side).
If you need any more information i can provide that for you, just ask 🙃.

Hi @niek1992
A couple of things comes to mind.

First, the user in iDRAC just needs "Read Only" permissions for the idrac_exporter to work.
Did you also adjust the scrape timeout in Prometheus? Do you see Prometheus timing when out calling the exporter?
Are there any errors in the exporter log?

First, the user in iDRAC just needs "Read Only" permissions for the idrac_exporter to work.

I figured, but wasn't explicitly stated in the readme, therefore i tried upping the permissions. I'll revert back to "Read Only" as i prefer that anyway.

Did you also adjust the scrape timeout in Prometheus? Do you see Prometheus timing out when calling the exporter?

No i didn't! But seeing as it defaults to 10s which makes it plausible that it was hitting timeouts on the first scrapes when the request duration took ~10s. However no errors in the log. I'll update the timeout to something higher.

Are there any errors in the exporter log?

I haven't ran idrac_exporter in --verbose mode yet, but i'll do that tonight. The normal logs do not show any output, other than it started listening on <IP_ADDRESS>:9348.
I'll get back to you later this day with confirmation if it was only the scrape timeout on the Prometheus scraper side.

Allright, an update:
Initially it seemed like it was indeed improved. Changed the timeout from the default (global) scrape_timeout which was 10s, to 30s. Kept the scrape interval at 60s.

But again, after a while i closed the tab with iDRAC on it, things got funky again:

Which was confirmed with timing the request:
time curl 192.168.x.x:9348/metrics?target=x.x.224.99
real    0m54.900s
user    0m0.011s
sys     0m0.000s

Which is obviously above my 50s timeout.
I then logged into iDRAC, with my admin account and did time the request again:
time curl 192.168.x.x:9348/metrics?target=x.x.224.99
real    0m25.322s
user    0m0.004s
sys     0m0.008s

I did notice that sometimes iDRAC is rather sluggish, which recovers on it's own after logging in. The graphs also look fine now, obviously because it's not hitting the timeout anymore:

i'll update the scrape_timeout to 59s, and see what it does this night. Ideally i would like a 60s scrape interval, but if 120s with a 90s timeout or something is more sensible then i'm also fine with that. Something is better than nothing. I haven't looked into enabling debug logging at the scraper side to see if i am indeed hitting the scrape timeout. Current loglevel does not indicate hitting the timeout, e.g. the log is clean.
It's just weird that the response is painfully slow if there is no session active in iDRAC. And the moment i start a session, response drops ~50%.

I am happy that things are improving!
Adding the -verbose flag will not tell you much useful in this case. Any actual error will always be shown. If the log is clean, then the exporter is working as expected.
iDRAC being sluggish on some machines is unfortunately an issue (there is another open issue at the moment, where the user also sees very long scrape times from iDRAC). However, to my knowledge, there is not much that I can actually do about it.


Remove temporary countersign agreement route

Route was only needed for a one off script and can now be removed.

:fire: :+1: :fire:


[Feature] Back to Top Button

Description
A back to top button for better UI
Screenshots

Checklist

[X] I have checked the existing issues.
[X] I follow Contributing Guidelines of this project.
[X] I am a GSSoC'24 contributor.
[X] I want to work on this issue.

Code of Conduct

[X] I agree to follow this project's "Code of Conduct".

@CSEdgeOff please assign me this task

@Scrapper700 Make sure to add that button in all HTML Pages and while making PR add images of O/P in different views.

please assign me this issue @CSEdgeOff under GSSoc'24


Display dates as well as timestamps in status page

Thanks! cc @codesome @juliusv

@sylr Thanks! Would you be able to do the same change to the new UI instead of the old one (or both)? Since the old one is going to disappear soon...

Hmm, actually it seems the head stats are even missing in the new UI on https://demo.promlabs.com/new/tsdb-status :thinking:
So maybe ignore that for now, we need to look at that separately.

:+1:


config: add run modes as config dictionnary

Move run mode from hardcoded in the main code to a config option

Fixes #22


Request for a project license

Would it be possible to add a LICENSE file and specify if this project is released under an open-source license? Would make it easier for contributions.

Added, MIT


DNS CName recordset does not allow setting metadata

Also why do we allow adding tags when Azure DNS doesn't support tags on DNS record sets?
        _azure.DnsZones.Define(zone)
                .WithExistingResourceGroup(_resourceGroupName)
                .WithCNameRecordSet(subdomain, alias)
                .Create();

We have addressed this limitation recently in the DNS implementation, see https://github.com/Azure/azure-sdk-for-java/pull/1758. This will be available in .net sdk in the upcoming release (scheduled for August)
The experience looks like:
zones.Define(topLevelDomain)
                .WithNewResourceGroup(RG_NAME, region)
                .DefineCNameRecordSet("userguide")
                    .WithAlias("doc.contoso.com")
                    .WithMetadata(key1, value1)
                    .WithMetadata(key2, value2)
                    .WithETagCheck()
                    .Attach()
                .Create();

PR taken for v1.2


Deprecated Atom APIs will be removed June 1st

Atom will no longer load this package after June 1st without changes. There are a couple deprecations on the latest version (0.1.2) of this package:

Store package style sheets in the styles/ directory instead of stylesheets/ in the <pack-name> package
Use activationCommands instead of activationEvents in your package.json Commands should be grouped by selector as follows: json "activationCommands": { "atom-workspace": ["foo:bar", "foo:baz"], "atom-text-editor": ["foo:quux"] }
atom.workspaceView is no longer available. In most cases you will not need the view. See the Workspace docs for alternatives: https://atom.io/docs/api/latest/Workspace. If you do need the view, please use atom.views.getView(atom.workspace), which returns an HTMLElement.

Visit https://gist.github.com/benogle/6d09e295c84b717ef9b4 and search for your package name to see up-to-date deprecations.
If this package has been replaced by another package or functionality in core, please reply with this information.
See https://github.com/atom/atom/issues/6867 for more info. Thanks!

@santip: #9 will resolve this issue and ensure that people can still use the move-panes package after June 1 (which is today). Is there anything I can do to help get #9 merged and a new version of move-panes released?


Correction for raw affiliation Haihe Laboratory of Sustainable Chemical Transformations, Tianjin, 300192, People’s Republic of China

Correction needed for raw affiliation Haihe Laboratory of Sustainable Chemical Transformations, Tianjin, 300192, People’s Republic of China
raw_affiliation_name: Haihe Laboratory of Sustainable Chemical Transformations, Tianjin, 300192, People’s Republic of China
new_rors:
previous_rors: 03q99v794
works_examples: W4320710295
contact: f51f336061c41b55c8a2cd4dde2dfcf4:13e4b060bb7af7df19c54efa205b @ univ-lille.fr

This issue was accepted and ingested by the OpenAlex team on 2024-12-19. The new affiliations should be visible within the next 7 days.


Working on plugin, how to send data to console?

hello, since there is no doc on plugins, i'm digging in the source code, but cannot get how do I send testing data to console?
Thanks

sorry,. wrong git, cannot delete (


New release?

A lot has happened since v0.2.3, and I'd be curios to try it out!

Yes, the next release is v.0.3.0, which has several trial features added.
It will be released soon.


[asset editor] Temporary image assets erased by the blank image asset

Describe the bug
Creating a new image without a name based on an asset from the gallery. Go to the asset editor tab and then create a second image based off of the first. You'll now see that there is a third blank image. If you use one of the non-blank images as the sprite for the player and then switch that sprite to the new blank image, one of the old sprites are removed. Though they may be temporary assets, exiting the project and then coming back right after the third blank image asset is created does not erase the first two.
To Reproduce
Steps to reproduce the creation of a blank asset:

Open a new project
Drag a set 'mySprite' to sprite block into the on start block
Open the blank sprite and pick an image from the image gallery.
Save the sprite and click on the Assets tab.
You'll see just the asset you created earlier. Clicking on it will show it's name is Temporary asset.
Click the New Asset button, then image, and then choose your sprite in the My Assets tab in the window that pops up
Modify the sprite by changing the color of something, save the asset without typing in a name
When you press done you'll see three assets. The two you created, and a third blank asset. Clicking on the blank asset will show No Image Selected on the left pane that usually shows information about the asset.

Steps to repro the unexpected deletion of the temporary assets

Follow the previous steps
Go back to the editor view and click on the sprite in the only set 'mySprite' to sprite block
Open the My Assets tab, here you'll only see two assets with the second asset you made missing
Go back to the Assets tab after closing the asset editing window, the second asset you made is missing here as well.
Go back to the editor and click the asset in the only block once more followed by pressing Done.
Go to the My Assets tab and select the blank asset
Press done and go back to the Assets tab.
Go back to the editor and click the blank asset again.
Go to the 'My Assets` tab once more, only the blank asset remains.
Click Done and go back to the Assets tab, only the blank asset remains.

Expected behavior
I don't expect the temporary assets to be deleted by interacting with the blank asset as described above. If leaving a project and coming back does not remove temporary assets, why would opening the My Assets tab when editing a sprite do so? I
Screenshots
https://user-images.githubusercontent.com/6496798/105432212-064cee00-5c0c-11eb-83f3-4e37b96ce961.mp4
Desktop (please complete the following information):

OS: Windows 10 1909
Browser Firefox
Version 84.0.2 (64-bit)

Additional context
Add any other context about the problem here.

By the way great bug report @aznhassan

By the way great bug report @aznhassan


Fix log level setup when using 0 as level

What was wrong?
The logic used to determine log levels was not behaving correctly when the log level was set to 0.
How was it fixed?
Updated the logic to do an explicit is None.
Cute Animal Picture

Merging without review.  Happy to cleanup anything post merge if you have anything you'd like addressed.  Predicting this will be uncontroversial.


Cannot start this animator on a detached view!

How to destroy finished activity theme manager ?????

Hi @SudoDios
If you mean ThemeActivity, it's a simple AppCompatActivity. You can work with it like AppCompatActivity.
If you mean ThemeManager, it's a singleton and doesn't need to be destroyed. the application always needs it. Every time that Fragment/Activity changes, we use it to synchronize the theme. It's not only for change theme animation.
If you don't agree, please tell me in more detail.
Thank you :)

Please wait while I send the code sample

Can you give an example code of how many activities?

Ok, I will add it on this week.

Thanks 🙏

Same happened with me

@SudoDios
Hi,
I added the multi Activities sample and fix the bug.
please use version 1.1.4:
dependencies {
    implementation "com.dolatkia:animated-theme-manager:1.1.4"
}

Thank you for your report.

Thankful.


Add custom renderer parameter to lobby + clean up code

Checklist

[x] Use a separate branch in your local repo (not master).
[x] Test coverage is 100% (or you have a story for why it's ok).

@nicolodavis it looks like npm run test:integration fails on master. Locally I have the following error:
Failed to minify the bundle. Error: static/js/main.38a01738.chunk.js from Terser
TypeError: Cannot read property 'minify' of undefined

It's a bug with terser. They should roll out a fix soon: https://github.com/terser-js/terser/issues/251

The approach from the PR is used here - https://lehasvv2009.github.io/territories/#/online (room creating might be a bit long cause of heroku wake up). Probably just waiting for reviews.

@lehaSVV2009 Sorry about the delay in getting to this.  Looks good!

@nicolodavis Thanks!


Add the option to depend of jest-environment-node instead of js-dom

I'm in a nestjs app, so depending on js-dom seems odd. Maybe having a
@quramy/jest-prisma/environment/node
@quramy/jest-prisma/environment/js-dom
seems more fitting

I think this is the solution you were looking for:
https://github.com/Quramy/jest-prisma/blob/main/packages/jest-prisma-node/README.md


Start folder none not working

Expected behavior
When start folder is set to none (Keine in German) it should display folders instead of contents of a folder.
Actual behavior
Option is still there but INBOX is shown
Steps to reproduce

Set start folder to Keine

Environment
K-9 Mail version:
5.709 via fdroid in German
Android version:
7.0
Account type (IMAP, POP3, WebDAV/Exchange):
IMAP

Duplicate of #4471


⚠ GitLab Server has degraded performance

In c1e7523, GitLab Server (https://gitlab01.its-telekom.eu) experienced degraded performance:

HTTP code: 200
Response time: 11697 ms

Resolved: GitLab Server performance has improved in 3e03d3e.


Instead of an empty crate, give a compile error when not on Windows

Previously, programs trying to use winapi on other targets would see
errors like this:
failed to resolve: could not find um in winapi
... many other related errors ...

Now, they'll see errors like this:
  --- stderr
  error: winapi is only supported on Windows platforms
  help: if your application is multi-platform, use `[target.'cfg(windows)'.dependencies] winapi = "..."`
  help: if your application is only supported on Windows, use `--target x86_64-pc-windows-gnu` or some other windows platform

This is a breaking change. The reason for this change is two-fold:

For programs intending to use winapi, it gives them a much better
error message telling them how to fix the error.
For programs that don't need winapi, it forces them to remove it from
dependencies, decreasing their compile times.

CI is failing because it's still building on linux even though I told it not to, I think because it's using the CI file from the 0.3 branch instead of my PR.

This would be a breaking change - I believe this should target the dev branch instead of the 0.3 branch?

@retep998 what are your thoughts on this? I'm ok with closing it if you don't want it, but I do think it's a good change.


Support cache

RUNNER_TOOL_CACHE is not mounted and it seems the cache doesn't work between runs anyway.


dont fail while over writing existing invalid ufo

fe when required files are missing

@anthrotype should we merge this?

forgot what the issue was.
is this comment relevant? https://github.com/typesupply/defcon/pull/165#discussion_r168920463
feel free to merge if you think it's not

@anthrotype not sure, @typemytype?

the problem is/was that when overwriting an invalid UFO it should not fail to write valid data... instead remove the invalid UFO and write the valid data to disk as a save-as operation.

fixed by #180


Maximum of all subarray of size k

#2304
Description
One of the fixed sliding window problem has been solved and implemented using c++.
Checklist
I've read the contribution guidelines.
I've checked the issue list before deciding what to submit.
I've edited the README.md and link to my code.
#C++
#2304

@bitaashna Multiples program single PR (Told you earlier)


Attachments support

Any file not detected as supported ( = not DPX and not WAV) and relatively small (in order to have e.g. adding a TIFF file, currently not supported, as attachment) is added as attachment, and demuxed during reverse

Note that this would allow (by increasing the maximum size) to package any file format, which is a good thing for the first release.


chore: avoid noisy warning logging for non-container charms

Issue

When using cross-model relations between Prometheus on K8s and some machine/VM charm, the warning logs are unbearable if deferring events where this warning gets logged. Example output from juju debug-log on a VM charm over a 1m period:
unit-zookeeper-0: 16:23:00 WARNING unit.zookeeper/0.juju-log restart:0: 0 containers are present in metadata.yaml and refresh_event was not specified. Defaulting to update_status. Metrics IP may not be set in a timely fashion.
unit-zookeeper-1: 16:23:02 WARNING unit.zookeeper/1.juju-log restart:0: 0 containers are present in metadata.yaml and refresh_event was not specified. Defaulting to update_status. Metrics IP may not be set in a timely fashion.
unit-zookeeper-3: 16:23:02 WARNING unit.zookeeper/3.juju-log restart:0: 0 containers are present in metadata.yaml and refresh_event was not specified. Defaulting to update_status. Metrics IP may not be set in a timely fashion.
unit-zookeeper-2: 16:23:02 WARNING unit.zookeeper/2.juju-log restart:0: 0 containers are present in metadata.yaml and refresh_event was not specified. Defaulting to update_status. Metrics IP may not be set in a timely fashion.
unit-zookeeper-0: 16:23:02 WARNING unit.zookeeper/0.juju-log restart:0: 0 containers are present in metadata.yaml and refresh_event was not specified. Defaulting to update_status. Metrics IP may not be set in a timely fashion.
unit-zookeeper-4: 16:23:02 WARNING unit.zookeeper/4.juju-log restart:0: 0 containers are present in metadata.yaml and refresh_event was not specified. Defaulting to update_status. Metrics IP may not be set in a timely fashion.
unit-zookeeper-1: 16:23:03 WARNING unit.zookeeper/1.juju-log restart:0: 0 containers are present in metadata.yaml and refresh_event was not specified. Defaulting to update_status. Metrics IP may not be set in a timely fashion.
unit-zookeeper-3: 16:23:03 WARNING unit.zookeeper/3.juju-log restart:0: 0 containers are present in metadata.yaml and refresh_event was not specified. Defaulting to update_status. Metrics IP may not be set in a timely fashion.
unit-zookeeper-2: 16:23:03 WARNING unit.zookeeper/2.juju-log restart:0: 0 containers are present in metadata.yaml and refresh_event was not specified. Defaulting to update_status. Metrics IP may not be set in a timely fashion.
unit-zookeeper-4: 16:23:03 WARNING unit.zookeeper/4.juju-log restart:0: 0 containers are present in metadata.yaml and refresh_event was not specified. Defaulting to update_status. Metrics IP may not be set in a timely fashion.
unit-zookeeper-4: 16:23:32 WARNING unit.zookeeper/4.juju-log 0 containers are present in metadata.yaml and refresh_event was not specified. Defaulting to update_status. Metrics IP may not be set in a timely fashion.
unit-zookeeper-4: 16:23:32 WARNING unit.zookeeper/4.juju-log No relation: certificates
unit-zookeeper-1: 16:23:54 WARNING unit.zookeeper/1.juju-log 0 containers are present in metadata.yaml and refresh_event was not specified. Defaulting to update_status. Metrics IP may not be set in a timely fashion.
unit-zookeeper-1: 16:23:54 WARNING unit.zookeeper/1.juju-log No relation: certificates
unit-zookeeper-0: 16:24:16 WARNING unit.zookeeper/0.juju-log 0 containers are present in metadata.yaml and refresh_event was not

Solution

Check if ANY containers exist in charm.meta.containers, if not, skip the WARNING log
Context

I am not sure the implication of skipping this warning for 'normal' K8s charms that want to deploy without a container. If we want to log the warning there, then this change is probably not a good solution. There may be a more specific way of inferring K8s/VM substrate for charms implementing the library as opposed to just checking for 1+ containers, but it isn't clear to me if ops exposes this somewhere.
There are various Juju env-vars that could be useful, KUBERNETES_* to identify K8s, or JUJU_MACHINE_ID to identify VM, but not sure if they're exposed in ops, or if it's worth the effort. Please let me know!
Testing Instructions

N/A
Release Notes

chore: avoid noisy warning logging for non-container charms

Thanks @marcoppenheimer.
This change is related to the conversation in https://github.com/canonical/prometheus-k8s-operator/issues/422.
It seems that the warning is a good thing, because you should explicitly specify the refresh event in your use case.
Wdyt?

Thanks @marcoppenheimer. This change is related to the conversation in #422. It seems that the warning is a good thing, because you should explicitly specify the refresh event in your use case. Wdyt?

Yup, setting refresh_event=self.on_start fixes it. Happy to close the PR!


Prevents arab users from entering Arabic digits to verification code.

Fixes #790

@googlebot I signed it!


Development: Refactor optional usage

Checklist
General

[ ] I tested all changes and their related features with all corresponding user types on a test server.
[ ] This is a small issue that I tested locally and was confirmed by another developer on a test server.
[ ] Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
[ ] I chose a title conforming to the naming conventions for pull requests.

Server

[ ] Important: I implemented the changes with a very good performance and prevented too many (unnecessary) database calls.
[ ] I followed the coding and design guidelines.
[ ] I added multiple integration tests (Spring) related to the features (with a high test coverage).
[ ] I added pre-authorization annotations according to the guidelines and checked the course groups for all new REST Calls (security).
[ ] I documented the Java code using JavaDoc style.

Client

[ ] Important: I implemented the changes with a very good performance, prevented too many (unnecessary) REST calls and made sure the UI is responsive, even with large data.
[ ] I followed the coding and design guidelines.
[ ] Following the theming guidelines, I specified colors only in the theming variable files and checked that the changes look consistent in both the light and the dark theme.
[ ] I added multiple integration tests (Jest) related to the features (with a high test coverage), while following the test guidelines.
[ ] I added authorities to all new routes and checked the course groups for displaying navigation elements (links, buttons).
[ ] I documented the TypeScript code using JSDoc style.
[ ] I added multiple screenshots/screencasts of my UI changes.
[ ] I translated all newly inserted strings into English and German.

Changes affecting Programming Exercises

[ ] I tested all changes and their related features with all corresponding user types on Test Server 1 (Atlassian Suite).
[ ] I tested all changes and their related features with all corresponding user types on Test Server 2 (Jenkins and Gitlab).

Motivation and Context

Description

Steps for Testing

Prerequisites:

1 Instructor
2 Students
1 Programming Exercise with Complaints enabled

Log in to Artemis
Navigate to Course Administration
...

Exam Mode Testing

Prerequisites:

1 Instructor
2 Students
1 Exam with a Programming Exercise

Log in to Artemis
Participate in the exam as a student
Make sure that the UI of the programming exercise in the exam mode stays unchanged. You can use the exam mode documentation as reference.
...

Review Progress

Performance Review

[ ] I confirm that the client changes (in particular related to REST calls and UI responsiveness) are implemented with a very good performance
[ ] I confirm that the server changes (in particular related to database calls) are implemented with a very good performance

Code Review

[ ] Code Review 1
[ ] Code Review 2

Manual Tests

[ ] Test 1
[ ] Test 2

Exam Mode Test

[ ] Test 1
[ ] Test 2

Test Coverage

Screenshots

Codecov Report

Merging #6758 (b273d14) into chore/modernizer-get (f759a11) will increase coverage by 0.00%.
The diff coverage is 93.18%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@                   Coverage Diff                   @@
##             chore/modernizer-get    #6758   +/-   ##
=======================================================
  Coverage                   80.37%   80.38%
  Complexity                  13941    13941
=======================================================
  Files                        2448     2448
  Lines                       93436    93451   +15
  Branches                    13116    13115    -1
=======================================================
+ Hits                        75101    75120   +19
+ Misses                      10105    10103    -2
+ Partials                     8230     8228    -2

Impacted Files
Coverage Δ

...in/www1/artemis/service/TextAssessmentService.java
91.17% <ø> (-0.26%)
:arrow_down:

.../artemis/web/rest/ProgrammingExerciseResource.java
86.53% <50.00%> (+0.10%)
:arrow_up:

...vice/connectors/bamboo/BambooBuildPlanService.java
83.78% <85.71%> (ø)

.../www1/artemis/service/ConsistencyCheckService.java
93.93% <88.88%> (+0.39%)
:arrow_up:

.../in/www1/artemis/service/ParticipationService.java
88.88% <90.90%> (+1.01%)
:arrow_up:

...programming/ProgrammingExerciseGradingService.java
92.83% <100.00%> (+0.02%)
:arrow_up:

.../programming/ProgrammingExerciseImportService.java
96.00% <100.00%> (+0.13%)
:arrow_up:

...gramming/ProgrammingExerciseRepositoryService.java
86.57% <100.00%> (+0.04%)
:arrow_up:

...ervice/programming/ProgrammingExerciseService.java
91.14% <100.00%> (+0.11%)
:arrow_up:

...vice/programming/ProgrammingSubmissionService.java
85.54% <100.00%> (+0.08%)
:arrow_up:

... and 1 more

... and 3 files with indirect coverage changes

Flag
Coverage Δ

client
76.15% <ø> (+<0.01%)
:arrow_up:

server
84.94% <93.18%> (+<0.01%)
:arrow_up:

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f759a11...b273d14. Read the comment docs.


VMware Fusion 11 Not Recognizing VMware Tools

Having trouble enabling shared folders - Vagrant reports VMware tools are not running

Should be fixed by https://github.com/clong/DetectionLab/commit/9b255e939876826be671178de0537d4457619d58


data binding demo does nothing

Chrome has removed the Object.observe function, which breaks the data binding demo.

One could use polyfills instead ;-)

https://github.com/MaxArt2501/object-observe
https://github.com/polymer/observe-j

Lovefield latest versions have removed usage of Object.observer. So, although using Polyfils would work, I think the right solution is to use latest version of Lovefield instead.

Thanks for the updates.
However, I am new to this and just learning Lovefield.
Where is the best place to start that can avoid these pitfalls?

Quick start guide
Codelab Use this version instead of Google IO 2015 website.
Demos

If a demo is not working, we should fix it, so I don't think there is a generic approach to avoid such pitfalls.


Remove the secretRef annotation from the ManagedSeed if the secret is already gone

How to categorize this PR?

/area control-plane
/kind bug
What this PR does / why we need it:
With https://github.com/gardener/gardener/pull/8039, we cleanup the seed secret for the managedseed when the spec.secretRef is set to nil and then remove the reference annotations from the managedseed.
There is a slight chance, if the controller restarts right after deleting the secret but before removing the annotation, then in the next try it could error when the secret is not found.
{"level":"error","ts":"2023-10-26T17:34:13.733Z","msg":"Reconciler error","controller":"managedseed","namespace":"garden","name":"managedseed","reconcileID":"4362718b-9fbc-416c-bcf0-fe1d630d53fb","error":"could not reconcile ManagedSeed garden/managedseed creation or update: could not reconcile seed managedseed secrets: failed getting secret in the managedseed annotations: secrets \"seed-secret\" not found","stacktrace":"sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler\n\tsigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:329\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\tsigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:266\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2\n\tsigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:227"}

This PR ignores this NotFound error and continues to remove the secretRef annotation from the ManagedSeed if the secret is already gone.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
/cc @ialidzhikov @dimitar-kostadinov as reviewers of the original PR
Release note:

A bug causing the managedseed controller to error if the controller restarts and the seed secret is already deleted is now fixed.

/cherry-pick release-v1.82

/cherry-pick release-v1.81

/cherry-pick release-v1.80

/retest


[request] Is there a way to filter out folders from mutations/results?

🚀 Feature Request
Is your feature request related to a problem? Please describe
gremlins is showing NOT COVERED for generated code. I don't want to make it mutate generated code and see that in the report.
Describe the solution you'd like
A --except flag that can be use like --except "./protogen/..."
Or automatically detect generated code, protogen code have this comment on every file:
// Code generated by protoc-gen-go. DO NOT EDIT.

Hi @corentinmusard ! Feature request already exists its #193
Please, check PR and provide feedback if it fits you #228
If you need this feature fast you can use my fork.

This is a duplicate of #193, I'll close this and we continue tracking there.


Support for loading custom Markdown files

This PR adds the following features:

support for loading arbitrary markdown files from the file system tree
support for _spec_.{yaml,yml,json} files, which do not generate a new category
support for sorting categories and items in the sidebar using _category_ or front matter in custom mdx files

Solves:

https://github.com/cloud-annotations/docusaurus-openapi/issues/135
https://github.com/cloud-annotations/docusaurus-openapi/issues/136
https://github.com/cloud-annotations/docusaurus-openapi/issues/137 (using _spec_, but we can change this)

Example
File tree (notice examples/custom-overview.md, examples/petstore/_spec_.yaml, examples/petstore/my-intro.md):

Results:

@bourdakos1 I would love your review on this.
There are a lot of changes in the diff, but most of the stuff (the one in packages/docusaurus-plugin-openapi/src/docs/) has been taken and "tree-shaked" from the original plugin-content-docs plugin (they don't export those functions, unfortunately).

@bourdakos1  It is ready, I am just making some minor linting fixes

It will probably take me a few days to review this, but I’m excited for the update 😁

fixed a bug where the slug property wasn't properly recognized

The "My Custom Petstore" / "My Intro" page doesn't load for me

My bad, I forgot to push stuff. Could you try it again?

Great feature! Do you have plans to release a new version of the package on npm? I'm interested using this feature too :)
Thank you!