Use command without hierarchical order

Checklist

[x] I'm asking a question
[x] I've looked through the README and FAQ for similar questions
[x] I've searched the bugtracker for similar questions including closed ones

Question

WRITE QUESTION HERE
Alright, so I'm using this command:
yt-dlp --audio-format best -x -o '%(playlist)s/%(playlist_index)s - %(title)s.%(ext)s'
It basically creates a folder for each playlist. It is great but I have one big massive issue: it numbers each file.
In other words, if I download a playlist called "Cool music" and there's a song called "epic song" it will download the folder with the original name of the playlist BUT, it will download the file for "epic song" as "01.opus", and I don't want it, I want the file to keep it's name.
I've tried everything, erasing portions of the command, adding stuff, and it always breaks something.
Is there a way to keep the file name?
I've searched for the same issue but I can't find anything. I would really appreciate your help!!!

#30839: "If you were actually usin yt-dlp ..."
However, I'd say the answer is the same for yt-dl too: the extractor for the site doesn't know how to find what you believe is the song's title, so the titles get numbered (yt-dl insists on a non-empty title being extracted, so the problem would be different).
Also, best is not a valid value of --audio-format.


Opt spaceplane parts

Added new $kref to SpaceDock, x_netkan_license_ok set to false (because
it's not in the enum in the spec), and removed unnecessary whitespace
from the depends list.
The mod is being maintained, but I really wish there was a way to add the HUGE caveat that comes with the recent update, and that is that the next update, whenever that happens, will break everyone's ships.

I am going to murderize the GitHub Desktop app.

IT seems the only way to cleanly sync a fork with the upstream is using git: https://help.github.com/articles/syncing-a-fork/

Good lord. Thanks for that. I knew there was a way to fix this silliness but I'd totally forgotten how. Everything I found when searching suggested rebasing as a solution. 😒

The only way I can think to do it via the website is to delete your fork of the repository and make a new one.
The easy way is to always start your new branches from the KSP-CKAN/NetKAN master fork, rather than your own one. It will create a branch based on the upstream master in that case.

Actually, I do create them from the KSP-CKAN/NetKAN master. And yet, it still tries to merge all my commits from my own master fork instead. It's...extremely odd. I'm just going to eschew the desktop app as much as possible and stick to command line. (At least it'll be good practice for future comp. sci. courses. As long as you guys don't mind these little muck-ups.)


Recent TM update breaks YTC on Chrome

TamperMonkey has updated to v4.0 and introduced a new cross-site request function called @connect that seems to drastically change how certain things are handled. As such, the userscript ceases to not only function but validly appear in the TamperMonkey 'Installed Scripts' list and if you try to re/install it causes TamperMonkey to crash.

Looks like tampermonkey guys fixed the issue (link) on their end, reinstalling youtube center worked just fine for me just now.

@DFNCTSC Can you confirm that it works now for you?

I'm not using the beta version of TamperMonkey since it is an entirely
different extension. The stable branch of TM is still v4.0 has rather
unprofessionally not been updated to fix the rampant issues caused by the
original update itself.
So I can confirm the bug still exists for me and I'm using the Chrome
extension (which seems to have it's own bugs, like not being able to
download videos -- it always get's 403 on videoplayback.txt) just to get
the video to resize on load.
When TM updates and the userscript is working I will post an update.
On Sat, Apr 2, 2016 at 9:21 PM, ErdeFB<EMAIL_ADDRESS>wrote:

@DFNCTSC https://github.com/DFNCTSC Can you confirm that it works now
for you?
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/YePpHa/YouTubeCenter/issues/2221#issuecomment-204864853

Tampermonkey just auto updated for me. After that update, in the latest version of 64-bit Chrome, one Chrome process starts using up an entire CPU core and Chrome stops responding, completely.
I managed to enter Tampermonkey and disable the loading of YoutubeCenter and it's now stopped doing that. I was running the dev version 538 fine before this Tampermonkey update. I even tried deleting and re-adding YoutubeCenter. Didn't help, it still crashing Chrome.

This happened to me too.  I had to downgrade Tampermonkey to version 3.12.58 and the cpu load issue went away

I tried updating to Tampermonkey Beta version <IP_ADDRESS> and YouTubeCenter works again. Lost a bunch of my more finely tuned settings like player size though.


build过程中报错 [Error: ENOENT: no such file or directory, open 'C:\Users\xxxx\Desktop\storage.meta\youan\rtwiqr\docs\uxcgph.json'] {

build过程中报错 [Error: ENOENT: no such file or directory, open 'C:\Users\xxxx\Desktop\storage.meta\123\rtwiqr\docs\uxcgph.json'] {

能解决嘛

我也遇到了


Make clap an optional dependency

Hi Jim,
This PR makes clap an optional dependency, only required when building the skani binary.
Since in pyskani I'm vendoring the Rust crates for reproducible compilation from source, I have to download the transitive dependencies for skani on all platforms. Unfortunately, on Windows, clap requires winapi, which is a huge crate. I end up with around 130MB of extra dependencies for clap which I don't really need for the Python bindings:

Hi Martin,
Thanks for the PR. Sounds super reasonable to me. Merging now.
Jim

Thanks!

Could you make a new release (v0.1.1 I guess) when you have the time?

Yeah give me a few days for this. I realized that the new change breaks the command line install as you have to include --features=cli now. Releasing a new tagged version on github would break conda's build recipe.

Ah, in that case you can probably fix it by making cli a default feature I think:
[features]
default = ["cli"]
cli = ["clap"]

This way you don't have to specify --features when installing, and I can still disable clap on my end by manually disabling the cli feature.

Oh that works very nicely. I'll do that then.  Thanks!


The composer global bin path isn't added to $PATH

Describe the bug
The composer global bin path isn't added to $PATH
Virtual environments affected

[ ] macOS 10.15
[ ] Ubuntu 16.04 LTS
[x] Ubuntu 18.04 LTS
[ ] Windows Server 2016 R2
[ ] Windows Server 2019

Expected behavior
The composer global path (/home/worker/.composer/vendor/bin) is added to the $PATH.
Actual behavior
It isn't in the path. and thus you have to call globally installed executables with their full path. As this might change some day, this isn't ideal.
Note that I have only tested this on 18.04, but it's likely an issue on the other environments too.

PR: #391

Hello @georgeboot , unfortunately, adding "export PATH" command to user's .bashrc file didn't resolve problem, we will continue to work on it.

Hmm that is strange. Sure it's added to the correct rc file?

Yes, user's bashrc contains export instruction, but it works only with terminal session, if we use image for ci it's not working ((

PR: https://github.com/actions/virtual-environments/pull/477

The path /home/runner/.config/composer/vendor/bin was added into $PATH. It can use for Github Actions pipelines (user runner).
@georgeboot , I close this issue, please reopen it if you have any concerns, thanks!


Task fails with Didn't find Oryx manifest file under location: /ss-oryx/app-manifest/oryx-manifest.toml error for static export

Describe the bug
Using Azure DevOps task and ubuntu latest image we receive following error on AzureStaticWebApp@0 task
Verbose logging enabled
Build timeout not specified, defaulting to 15 minutes
App Directory Location: './app/dist/' was found.
Looking for event info
Event info parsed from action options.
Skipping step to build /working_dir/./app/dist with Oryx
No Api directory specified. Azure Functions will not be created.
Found staticwebapp.config.json file: 'app/dist/21894/staticwebapp.config.json'
**Didn't find Oryx manifest file under location: /ss-oryx/app-manifest/oryx-manifest.toml
Failed to find a default file in the app artifacts folder (./app/dist). Valid default files: index.html,Index.html.
If your application contains purely static content, please verify that the variable 'app_location' in your deployment configuration file points to the root of your application.
If your application requires build steps, please validate that a default file exists in the build output directory.
App is Not Oryx and we have index.html in ./app/dist folder
To Reproduce
Task used to deploy static webapp
- task: AzureStaticWebApp@0
enabled: true #requires linux agent, so new stage needed and artefact should be exported in this one
displayName: "Deploy Dev01"
name: DeployDev01
inputs:
app_location: './app/dist/'
output_location: '/dist'
skip_app_build: true
skip_api_build: true
verbose: true
is_static_export: true
azure_static_web_apps_api_token:  $(Dev01DT)
If possible, please provide the following information if relevant (do not include sensitive content):
Can not be provided due to sensitive nature
Expected behavior
Static Website got deployed by Azure DevOps task
Screenshots
If applicable, add screenshots to help explain your problem.
Device info (if applicable):
NA
Additional context
Add any other context about the problem here.

Hi @kantipenko just to check, are you sure app/dist is the root folder of your app contents, with the index.html? From the log about staticwebapp.config.json, is it possible that app/dist/21894 is the root?
To also clarify, there's no error with Oryx (that is a warning message that only appears on verbose: true meant to be informational in this case). Also, is_static_export is meant to be used with Next.js apps, is that the case for you?

Thanks @joslinmicrosoft ! Great catch!
Updated task to the inputs below and it worked. Issue can be closed.
- task: AzureStaticWebApp@0
enabled: true #requires linux agent, so new stage needed and artefact should be exported in this one
displayName: "Deploy Dev01"
name: DeployDev01
inputs:
app_location: './app/dist/$(Build.BuildId)/'
output_location: '/dist/'
skip_app_build: true
skip_api_build: true
verbose: true
#is_static_export: true
azure_static_web_apps_api_token:  $(Dev01DT)


I would like to ask where you found gemma’s chat template？

thanks

https://huggingface.co/google/gemma-7b-it/blob/main/tokenizer_config.json#L1507


Api Endpoint Returns An Error Response

Hello,
I use your API to fetch statistics about my simple library. Once fetched, they are displayed on the library's landing page.
Yesterday I noticed that all stats are missing, and after some debugging, I found out that the following endpoint returns an error:
Endpoint:
https://api.npms.io/v2/package/near-duplicate-docs
Response:
{"code":"INTERNAL","message":"Internal server error"}
Best Regards,
Sashe Vuchkov

Should be good now. There will be some 404s in the /package endpoint for a couple of days, because the couchdb database is being re-analyzed. Sorry for the inconvenience.

Should be good now. There will be some 404s in the /package endpoint for a couple of days, because the couchdb database is being re-analyzed. Sorry for the inconvenience.

Thanks :)


Add dataset to dataloader

With recent testing of the Dataset model, it may be helpful if we are all using the same test objects. @marySalvi will be able to add to this object later.

I've created a draft PR over at #44 with the testing related features I requested in this PR pulled out. Unfortunately, fixtures unrelated to the Dataset model are not passing validation. As a result, I see no reason to block this PR from getting merged.
@annehaley Do the commits I pulled out into #44 look like they cover the testing functionality you implemented in this branch? If so, can I reset this branch to set HEAD to the commit before adding serializer testing functionality (cd19b9b2b2dd717d8a9e4f4cc08dde2a5650f78d)?

Yes, #44 is a much better implementation. I'm glad you brought up this whole test idea, I didn't realize other fixtures wouldn't pass.


Include parse to Bug field in Proposal

Include field Bug in Proposal; closes #3

Thanks @digoreis !


[Camera] Avoid microphone permissions request

Use case
My application depends on the camera plugin, specifically video, but it does not require audio. I attempted using CameraController(..., enableAudio = false) to avoid having to request microphone permissions, but I learned from #106557 that enableAudio has no effect on mic permissions, as the hardware is accessed with the availableCameras() method.
I have not found a workaround here, and the Apple App Review Team has rejected my submission due to this:

I did not foresee this obstacle, and I have 4 days to get the application on the App Store. What previously was plenty of time to prepare the presentation, has now turned into a rush to submit the product in time... please help!
Proposal
What seems to be the path of least resistance for me is to mimic the behavior of the enableAudio parameter from CameraController in the availableCameras() method... in other words:
Current:  availableCameras()
Proposal:  availableCameras({enableAudio=true})
This would not break existing implementations, as the default is set to true, but with the ability to set it to false, video could be recorded without requesting microphone permissions.
In the meantime, if someone has a workaround, that would be a blessing! I have tried almost everything, but unfortunately do not have Swift experience (yet) to fork the plugin and solve the problem myself.

but I learned from #106557 that enableAudio has no effect on mic permissions, as the hardware is accessed with the availableCameras() method.

You're referencing App Store review, but the issue you've linked to is about the web implementation of camera, not the iOS implementation. What is the exact plugin call in your application that is triggering an audio permission request? Please provide a reproducible test case.

@stuartmorgan thanks for getting back to me. As mentioned by @exaby73 here...

To me, this does not seem like a bug, but rather missing functionality.

it seems to be a platform-independent lack of plugin functionality. Regardless, here is my minimally reproducible code sample on iOS:

import 'package:camera/camera.dart';
import 'package:flutter/cupertino.dart';
import 'package:flutter_bloc/flutter_bloc.dart';

void main() {
  runApp(const Root());
}

class Root extends StatelessWidget {
  const Root({Key? key}) : super(key: key);
  @override
  Widget build(BuildContext context) {
    return BlocBuilder<CameraCubit, CameraState>(
        bloc: CameraCubit()..initCamera(),
        builder: (context, state) {
          return CupertinoApp(
              home: CupertinoPageScaffold(
                  child: state is CameraStandby
                      ? CameraPreview(state.controller)
                      : const Center(child: CupertinoActivityIndicator())));
        });
  }
}

class CameraCubit extends Cubit<CameraState> {
  CameraCubit() : super(CameraLoading());

  void initCamera() async {
    final cameras = await availableCameras(); //Likely implement [enableAudio = false] here
    final cameraController = CameraController(
        cameras.firstWhere(
            (camera) => camera.lensDirection == CameraLensDirection.back),
        ResolutionPreset.high,
        enableAudio: false, // Assumed this was supposed to avoid microphone permissions, was wrong
        imageFormatGroup: ImageFormatGroup.bgra8888);
    await cameraController.initialize();
    await cameraController.prepareForVideoRecording();
    emit(CameraStandby(controller: cameraController));
  }
}

@immutable
abstract class CameraState {}

class CameraLoading extends CameraState {}

class CameraStandby extends CameraState {
  final CameraController controller;
  CameraStandby({required this.controller});
}

@charlieforward9 I think with iOS, this is different. When selecting a camera, the iOS plugin will request permissions, that too, microphone permissions will only be asked if enableAudio is set to true. See the code snippet from the plugin below:
https://github.com/flutter/plugins/blob/2a330bc0afd58900cbbc08471b9ea914914a3daa/packages/camera/camera_avfoundation/ios/Classes/CameraPlugin.m

I have just verified that the permissions are requested in the CameraController(...) constructor call rather than the availableCameras() method call.
However, I have continued receiving microphone permissions requests with enableAudio = false.

Using the camera example, microphone permissions only appear to be requested with enableAudio = true. Could you provide a complete sample, preferably without any 3rd party libraries?

await cameraController.prepareForVideoRecording();...
The only method I use that the camera example does not.
Per the method docs:

Preparing audio can cause a minor delay in the CameraPreview view on iOS. If video recording is intended, calling this early eliminates this delay that would otherwise be experienced when video recording is started...

Removing this method from my code solves the microphone permissions issue. However, despite not using audio, I still experience a small delay. This significantly affects the usability of my application, which depends on the duration of the video, to the nearest millisecond.
Therefore, the intent of this issue remains the same, but the explanation and proposal have changed: prepareForVideoRecording() should not request microphone permissions if enableAudio = false in the parent CameraController.
Is editing the original (slightly misleading) proposal preferred? Or would opening a fresh issue help prioritize and clarify this issue?

I think we can close this issue as invalid. A new, fresh issue with a  complete and minimal, reproducible example would be great :)

@exaby73  One final question to help me ask better questions. I see you referenced the SO link to proper examples. Is the 3rd-party package what is preventing my example from being non-minimal? I would have to completely restructure my code to make it function the same without the 3rd-party package. This is the reason I chose to leave it in. Are you implying that I should have taken the time to do that?
I appreciate feedback, and thank you for helping on this issue.


Telemetry values should be different for 4.x 5.x AND Core vs. Desktop

Currently they are all the same.

@lovemaths check with other products to see what values they use. We should be consistent.

@mafurman  We need to change telemetry values for 5.2.0.
Have a different value for Core and Desktop


trust failure has unhelpful message

Pulling an unsigned image when you have said you only want signed returns a very generic 401 error, it should specifically say the image is not signed, preferably with more details eg once we anable pinning.
cc @deitch who reported this
Pull image: linuxkit/compose-dynamic-example:de453299b70435f19372dc0b983d018a9501bc72
FATA[0148] Failed to extract root filesystem for linuxkit/compose-dynamic-example:de453299b70435f19372dc0b983d018a9501bc72: Could not pull image linuxkit/compose-dynamic-example:de453299b70435f19372dc0b983d018a9501bc72: Trusted pull for linuxkit/compose-dynamic-example:de453299b70435f19372dc0b983d018a9501bc72 failed: you are not authorized to perform this operation: server returned 401.
make: *** [dynamic] Error 1

cc @riyazdf

@justincormack ah - this is related to the auth system behind the deployed notary server because this repo does not exist in Docker Hub or its Notary Server: https://hub.docker.com/r/linuxkit/compose-dynamic-example/.
cc'ing some of the notary folks for a heads up: @cyli @dlawrence

Oh I see, yes it's normal to return 401 if it might exist but be private
On 2 Jun 2017 16:28, "Riyaz Faizullabhoy"<EMAIL_ADDRESS>wrote:

@justincormack https://github.com/justincormack ah - this is related to
the auth system behind the deployed notary server because this repo does
not exist in Docker Hub or its Notary Server: https://hub.docker.com/r/
linuxkit/compose-dynamic-example/.
cc'ing some of the notary folks for a heads up: @cyli
https://github.com/cyli @dlawrence https://github.com/dlawrence
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/moby/tool/issues/64#issuecomment-305821328, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAdcPDpbuXAx-MBip9Dznpf25Dnmfkqrks5sACougaJpZM4NuDo1
.


561 query dataset doc

Hi @malexthorpe, @yangc71, @bms63
May I please ask you to have a look with your fresh eyes at the queries_dataset vignette and let me know if this is understandable or any comment/suggestion you may have to improve it?
@thomas-neitmann - please feel free to have a look too.
@bundfussr - i have a added a question regarding TERM_NAME and TERM_ID (line 101-103): Would you please have a look and let me know if my understanding is correct?

@kabis-ops Do you have time to address the comments made? I'd really like to include this in the next release and we're slowly running our of time...

Hi @thomas-neitmann - i should be able to take care of this tomorrow: is that OK? Otherwise, please feel free to take over :)

That's fine, thanks a lot!

Hi all, i think i have implemented your comments.
Also @bundfussr,  the question raised by @yangc71 regarding the SCOPE_NUM vs SCOPE may need to be addressed in assert_valid_queries().

@thomas-neitmann - vignette updated as per your comments


[BUG] Extractor pull request shows date and partial-time formats in wrong format

Release version
APIOps Toolkit for Azure APIM v4.1.2
Describe the bug
Extractor returns strings with format 'date' and 'partial-time' in wrong format. This bug has been from the beginning and this makes pull requests very hard to complete.
It has been mentioned:
"Tools can use the format to validate the input or to map the value to a specific type in the chosen programming language. Tools that do not support a specific format may default back to the type alone, as if the format is not specified." - https://swagger.io/docs/specification/data-models/data-types/#string
and specs for formats: https://www.rfc-editor.org/rfc/rfc3339#section-5.6
Expected behavior
Extractor pull request should show string values with format date: 'yyyy-MM-dd' and string values with partial-date: 'HH:mm:ss' or fallback to string format if format is not supported. It doesn't help either used only type string without format field e.g., comment format: partial-time and format: date from specification.
Actual behavior
Extractor pull request shows both formats 'date' and 'partial-date' like this: 'yyyy-MM-ddTHH:mm:00.0000000+00:00'
Reproduction Steps
Add following openapi description to version control (or add it from portal) and deploy it to APIM:
openapi: 3.0.1
info:
  title: myApi
  description: This API provides...
  version: '1.0'
servers:
  - url: https://myservice.my
paths:
  /api/timewindow:
    get:
      summary: Gets time window
      description: Gets time window
      operationId: get-time-window
      responses:
        '200':
          description: Success
          content:
            application/json:
              schema:
                $ref: '#/components/schemas/MyResponse'
              example:
                myDate: '2022-02-17'
                myTimeStart: '07:49:00'
                myTimeEnd: '07:49:00'
components:
  schemas:
    MyResponse:
      type: object
      properties:
        myDate:
          type: string
          description: Date
          format: date
          example: '2022-02-17'
        myTimeStart:
          type: string
          description: Start time
          format: partial-time
          nullable: true
          example: '07:49:00'
        myTimeEnd:
          type: string
          description: End time
          format: partial-time
          nullable: true
          example: '07:49:00'
      additionalProperties: false
      description: Represents a time window
  securitySchemes:
    apiKeyHeader:
      type: apiKey
      name: Ocp-Apim-Subscription-Key
      in: header
    apiKeyQuery:
      type: apiKey
      name: subscription-key
      in: query
security:
  - apiKeyHeader: [ ]
  - apiKeyQuery: [ ]

Run extractor and pull request changes are showing:
'200':
  description: Success
  content:
    application/json:
      schema:
        $ref: '#/components/schemas/MyResponse'
      example:
        myDate: '2022-02-17T00:00:00.0000000+00:00'
        myTimeStart: '2023-04-12T07:49:00.0000000+00:00'
        myTimeEnd: '2023-04-12T07:49:00.0000000+00:00'

You are correct. I get same behavior from portal so this is actually feature request to the APIM team. Sorry about this.


CSUB-114 benchmarks and weights overwrite

Description of proposed changes:
Practical tips for PR review & merge:

[ ] All GitHub Actions report PASS
[ ] Newly added code/functions have unit tests

[ ] Coverage tools report all newly added lines as covered
[ ] The positive scenario is exercised
[ ] Negative scenarios are exercised, e.g. assert on all possible errors
[ ] Assert on events triggered if applicable
[ ] Assert on changes made to storage if applicable

[ ] Modified behavior/functions - try to make sure above test items are covered
[ ] Integration tests are added if applicable/needed

/benchmark

Codecov Report

Merging #177 (e5ac911) into dev (82e8de4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #177   +/-   ##
=======================================
  Coverage   67.01%   67.01%
=======================================
  Files          34       34
  Lines        6748     6748
=======================================
  Hits         4522     4522
  Misses       2226     2226

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more


[MiniLLM] The "processed_data.tar" data link is invalid.

I used the code in the guide to download the data, but found that the URL was no longer valid.
DLINK=$(echo -n "aHR0cHM6Ly9jb252ZXJzYXRpb25odWIuYmxvYi5jb3JlLndpbmRvd3MubmV0L2JlaXQtc2hhcmUtcHVibGljL01pbmlMTE0vcHJvY2Vzc2VkX2RhdGEudGFyP3N2PTIwMjMtMDEtMDMmc3Q9MjAyNC0wNC0xMFQxMyUzQTExJTNBNDRaJnNlPTIwNTAtMDQtMTFUMTMlM0ExMSUzQTAwWiZzcj1jJnNwPXImc2lnPTRjWEpJalZSWkhJQldxSGpQZ0RuJTJGMDFvY3pwRFdYaXBtUENVazNaOHZiUSUzRA==" | base64 --decode) wget -O processed_data.tar $DLINK
I also tried to open the URL https://conversationhub.blob.core.windows.net/, but found that the URL could not be opened either.
On August 16, I could still open it, but when I wanted to download precess_data.tar now, I found that the link was invalid and could not be opened.
Is there any other way to get process_data.tar? Looking forward to your reply!  : )

me too. it shows "403 Key based authentication is not permitted on this storage account."

The links have been fixed. (https://github.com/microsoft/LMOps/blob/main/minillm/README.md)
@aaab8b @shhn1


Book (master) Schema example does not compile: expected attribute, found macro juniper::graphql_object

Describe the bug
Book (master) Schema example does not compile.
$ cargo run
...
error: expected attribute, found macro `juniper::graphql_object`
  --> src/main.rs:58:3
   |
58 | #[juniper::graphql_object(
   |   ^^^^^^^^^^^^^^^^^^^^^^^ not an attribute

To Reproduce
Add
[dependencies]
juniper = "0.14.2"

And try compiling Schema example from the book: https://graphql-rust.github.io/juniper/master/quickstart.html#schema-example
Expected behavior
Should compile.
Additional context
$ cargo version
cargo 1.49.0-nightly (dd83ae55c 2020-10-20)

Cargo.toml should have been
juniper = { git = "https://github.com/graphql-rust/juniper" }


Performance Improvement: Array.init and Array.tabulate

Faster Array Init and Tabulate

Eliminating unnecessary repeated array index bounds check while initializing an array.
Faster iteration through new array on initialization by advancing an element pointer.

Applies to Array.init and Array.tabulate.
Performance Improvement
More than 2x faster array initialization
Micro-Benchmark
Measuring the number of mutator instructions with an array of 10_000_000 Nat elements. Tabulate uses x -> x.

Operation
Unoptimized
Optimized
Speedup

init
260e6
120e6
2.17

tabulate
380e6
280e6
1.36

GC Benchmark
Measuring the number of mutator instructions in GC benchmark.

Benchmark Case
Unoptimized
Optimized
Speedup

blobs
4.56e7
4.44e7
1.03

buffer
2.06e10
2.04e10
1.01

graph
1.09e10
1.02e10
1.07

random-maze
2.51e8
2.47e8
1.02

sha256
3.31e10
2.97e10
1.14

No relevant improvement for the other benchmark cases.
On GC benchmark, the optimization improves performance by 3.4% on average.
Testing

Mototoko test/run and test/run-drun test cases with sanity checks.

Extended the test case test/run/array-gen.mo with larger arrays and edge cases (size 0, 1).

Special branch luc/array-init-checks with extensive sanity checks:

Full memory sanity check after every Array.init and Array.tabulate call.
Checking the bounds of every element access during Array.init and Array.tabulate.

Nice!

Now tempting to inline lambda argument of tabulate when obvious...

@luc-blaeser if you label the PR as auto-merge squash, it'll use your nice description as the commit message without further work.

You could also add a simple one-line description to the changelog (Changelog.md) referencing the PR number.


Token error when access expires

Client error response [url] https://marketplace.commerceguys.com/oauth2/token [status code] 400 [reason phrase] Bad Request

@pjcdawkins What was the solution to this? I am getting a similar message when running platform:
[GuzzleHttp\Exception\ClientException]
Client error response [url] https://marketplace.commerceguys.com/oauth2/token [status code] 400 [reason phrase] Bad Request [error] invalid_grant [error_description] Invalid refresh token

Hi @anderoy - the solution had many parts, but it was mostly fixed on the server side. For you:

Make sure you have the latest version of the CLI with composer global update (2.2.0, but it reports itself as 2.x-dev ... that will be fixed in the next version).
Run platform login again

Thanks @pjcdawkins - I had already tried 1. and it didn't work but then after 2. running platform login again it worked.

Cool... thanks for your patience!


Some copy-paste tidyups + Nautilus 3 compatibility

Fixes #1994
The reader is referred to #1994 for some background behind this.
In this description "Nautilus 3" means versions of Nautilus supplied with GNOME 3 2.29.92 and later.
In the process of investigating that fault, we found that using xclip to query the clipboard for a STRING or UTF8_STRING when files were selected on the Windows side could hang. This PR fixes that by emulating the behaviour of Thunar or Nautilus 3 for such queries.
In all, there are three commits here:-

The first commit adds some memory buffer overflow checking to the clipboard code we're using for files. In particular, the function clipboard_c2s_in_files() now is passed the length of the buffer it has available to write to.
The second commit provides a default STRING or UTF8_STRING response to an X client requesting it when a file list is available.
The third commit adds a variable to sesman.ini which can be used to enable Nautilus 3 compatibility if required.

The intention is to revert the 3rd commit when there is no need to support Nautilus 3. I estimate this will be in about 3 years' time, but it may be more if RHEL 8 (and clones) do not migrate to GNOME 4.
It may be that we decide the third commit is too complicated and we wish to remove it. Even so, I believe the first two commits are worth adding to the codebase.

Awesome! I'll have a look when the sun rises. It is midnight in my time zone.

In this description "Nautilus 3" means versions of Nautilus supplied with GNOME 3 2.29.92 and later.

3.29.92.

Thanks for the quick review.
I did wonder about more flexible ways of doing this (i.e. chansrv setting per login), but it's complicated to get that in. Also, we're only doing this to support LTS distros, so I think the number of users requiring this setting will not be large.
I'm a bit short of time today. I'll fix the typo above, and merge this in tomorrow.

For the record, I've made a couple of minor changes before merging this.
In clipboard_file.c, this line:-
if (str_len > (last - ptr))

replaces:-
if (str_len >= (last - ptr))

which fixes an off-by-one error.
Also, the config setting for UseNautilus3FlistFormat is now logged like other config values in chansrv_config.c

I did wonder about more flexible ways of doing this (i.e. chansrv setting per login), but it's complicated to get that in. Also, we're only doing this to support LTS distros, so I think the number of users requiring this setting will not be large.

Keeping changes minimum is a good idea to get backported. Such LTS distributions only accept security fixes or critical bug fixes with minimum change. If the change includes new features there's little chance to be backported.


Display Python 2.7, 3.6 and other unsupported Python envs in kernel picker

Given this is not supported anymore, should we even display this
What about python 3.6

Closing for now.


SMA SemanticVersion not SemVer 2 compliant

First: System.Management.Automation.SemanticVersion is not SemVer v2 compliant
Second: PowerShell releases are using SemVer v2 syntax
Therefore: $PSVersionTable.PSVersion is truncated and thus broken, as pre-release versions cannot be compared to each other (the only useful assertion possible is that the PSVersion is -lt "6.0.0")
You should be using (an implementation like) Nuget.Core's Nuget.SemanticVersion which handles -prerelease and +patch as well as dotted versions like your 6.0.0-beta.7
Note that both the tests below return TRUE if $SemVer is Nuget.SemanticVersion:
Steps to reproduce
$SemVer = [System.Management.Automation.SemanticVersion]
("6.0.0-beta.10" -as $SemVer) -gt ("6.0.0-beta.7" -as $SemVer)
("6.0.0+fixes" -as $SemVer) -gt ("6.0.0-beta" -as $SemVer)

Expected behavior
True
True

Actual behavior
False
False

Environment data

> $PSVersionTable
Name                           Value
----                           -----
PSVersion                      6.0.0-beta
PSEdition                      Core
GitCommitId                    v6.0.0-beta.7
OS                             Microsoft Windows 10.0.15063
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

@daxian-dbw We discussed this in previous PR - could you please comment the Issue?

Fix for compare is ready.


UniversalKit request: Ledger

It would be really helpful to see how one could integrate Ledger, and other hardware wallets, whether as part of UniversalKit or just as a tutorial to start.
While Ledger can be used through wallets like XDEFI to sign, having native support can enable more users who are more comfortable using Ledger more purely. It'd be great to investigate more to see if it's possible to add -- especially signing from the Bitcoin side.

If I understand correctly, the request is to be able to sign transaction using Ledger directly without an extension wallet.
From what I can tell, nobody is doing that. Hardware Ledger stores a key and is capable of signing, but you need to tell it what to sign.
If you look at wallet connector libs like Dynamic, RainbowKit, they support Ledger Live, which is a mobile and desktop app that essentially acts as a software wallet for the Ledger hardware.

Ok, apparently, ThorSwap connects to Ledger directly. I'll look into this.


Switch to trace-based logging - take three

If at first you don't succeed...

(This is based on PR #1562 and Colin's changes in #1572 )

Quick! Merge it before it runs away!


Add trialforce template org config

This PR adds a new org config trial that will create a scratch org based upon the current production trial template.
Critical Changes
Changes
Issues Closed
New Metadata
Deleted Metadata
Testing Notes
$ cci org browser trial

fyi @kdy618


Logs include control characters (in place of coloring) in Visual Studio output window when using Docker

Repro Steps

Install Docker for Windows Beta and Docker Tools for Visual Studio
New ASP.NET Core Application
Add -> Docker Support
Debug -> Start Without Debugging

Issue
Logs in output window include garbage characters in place of coloring:
DockerTask.ps1 -WaitForUrl -Machine ''
Hosting environment: Production
Content root path: /app
Now listening on: http://*:80
Application started. Press Ctrl+C to shut down.
info: Microsoft.AspNetCore.Hosting.Internal.WebHost[1]
      Request starting HTTP/1.1 GET http://docker/

CC: @glennc

Not sure what's the proper way to fix this would be. Perhaps we can detect we're outputting to VS window and disable colors?

@muratg Wouldn't it be better if VS would interpret the codes and display color output?
The WebPack Task Runner extension by @madskristensen, for example, supports color output in a VS pane:

@nil4 Good point!
@BillHiebert Do you know if that's something we could do?  AFAIK, npm console output has the same issue.

The output window does not support colors today, nor does it recognize and strip the control characters from the text.  There are some extensions you can install which do add colors but I don't know if they handle the control sequences.
Failing that, Docker tooling needs to strip the characters from before sending them on to the output window.

@SteveLasker Are the tools guys thinking about this already or were you expecting something from logging?

If possible, I think we should fix this at the Logging level, so any downstream consumer is fixed.  I know some tools detect whether output is going to a console or redirected (to a file or another process), and change their output format accordingly.

It can be done from .NET via the Console.IsOutputRedirected property.

I ran a simple test and redirected the output to a file, and the file didn't contain any control characters:
var factory = new LoggerFactory();
factory.AddConsole();
var logger = factory.CreateLogger<Program>();
logger.LogInformation("information");

dotnet restore
dotnet build
dotnet bin\Debug\netcoreapp1.0\ConsoleApp1.dll > out.txt

So maybe Logging is already doing the right thing, and this does need to be fixed downstream.  I will send mail to the Docker Tools for VS team.

Putting this in 1.0.1 milestone for further investigation post RTM.

The issue is most likely in Docker Tools for VS, rather than Logging.  They have filed an issue on their end and will fix it when they are able.

We're using this with Kestrel on mono inside docker. We're logging to the console and then we're using docker's syslog driver to forward the logs. As a result we get the string polluted by control characters.
Maybe the simplest solution would be to include an option to disable colors altogether?

@mikeharder what's the current recommendation for this one?
cc @davidfowl

@muratg: We should really look at end-to-end scenarios to see how they can be improved.  For the scenario mentioned above:

We're logging to the console and then we're using docker's syslog driver to forward the logs. As a result we get the string polluted by control characters.

One option might be logging to a file instead of the console.  I've verified that control characters are not present when logging to a file.
Another option might be for docker's driver to remove control characters.  I think any process which writes colors to the console would have the same issue in Docker.
Finally, we could add an option in Logging to disable colors, but this has a few drawbacks.  First, the app author may not know when or whether to disable colors.  It depends on the context the app is being used.  Second, other tools like the CLI would also need to add options to disable colors.

I'm not sure how you were even getting control characters on Windows since we don't write them unless you are on Unix. Unless our IsWindows check isn't working properly on Docker for Windows...

After some investigation we can't easily detect if the output is being redirected, see https://github.com/dotnet/corefx/issues/10428

What is the status of this?  We are using docker containers on AWS, and get the control characters in our logs.  Makes it rather difficult to read.
If it is difficult to auto detect, could we get an Environment variable or some other way to just turn off colorizing?

@pakrym : Can this issue be closed since https://github.com/aspnet/Logging/pull/772 was merged?

As a workaround, it's possible to use the ConsoleLogger.DisableColors option added in 2.1: https://github.com/aspnet/Logging/pull/772

If you are using WebHostBuilder.CreateDefault setting  ASPNETCORE_LOGGING__CONSOLE__DISABLECOLORS environment variable to true would disable colors too.


[Dev][AMD] Add AMD RDNA Arch

Hi @Cunxiao2002 , thanks for your contribution, would you mind add simple test case for this arch?

@microsoft-github-policy-service agree

Thank you for your recommendations and I will improve my code based on them.

I've reviewed the code and left some comments.

@Cunxiao2002  Please fix the lint :)

@Cunxiao2002 Please fix the lint :)

I'll fix it right away, sorry.


Fix bug with history page when connecting to a postgres DB

The current DbTaskHistory class executes the following query when finding all of the latest runs:
SELECT tasks.id AS tasks_id, tasks.name AS tasks_name, tasks.host AS tasks_host
FROM tasks JOIN task_events ON tasks.id = task_events.task_id
WHERE task_events.ts >= %(ts_1)s
GROUP BY tasks.id, task_events.event_name
ORDER BY task_events.ts DESC' {'ts_1': datetime.datetime(2015, 4, 9, 10, 25, 58, 589578)}

This query is not valid in Postgres and gives the following error:
ProgrammingError: (ProgrammingError) column "task_events.ts" must appear in the GROUP BY clause or be used in an aggregate function
LINE 3: ...ROUP BY tasks.id, task_events.event_name ORDER BY task_event...

See http://dba.stackexchange.com/questions/88988/postgres-error-column-must-appear-in-the-group-by-clause-or-be-used-in-an-aggre
I created a simple fix to add the task_events.ts to the GROUP BY clause. This fixed my error and now the history page renders as expected.

Thanks! :) (test case would be nice though :))


CFFL

CFFL

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_1cmb20d0kg/clone/recipe/meta.yaml:28: host_section_needs_exact_pinnings: Packages in host must have exact version pinnings, except python build tools.
ERROR: /tmp/abs_1cmb20d0kg/clone/recipe/meta.yaml:29: host_section_needs_exact_pinnings: Packages in host must have exact version pinnings, except python build tools.
Errors were found


fix: deep_merge should stop recursing at class instances

In #1662 @JBusillo notes that my #1572 is causing an issue when you pass key and cert values in kit.vite.server.https.
I see that he's passing buffers like this:
const config = {
  kit: {
    // hydrate the <div id="svelte"> element in src/app.html
    target: "#svelte",
    vite: {
      server: {
        https: {
          key: fs.readFileSync("example.key"),
          cert: fs.readFileSync("example.crt"),
        },
      },
    },
  },
};

which my deep_merge function tries to deeply clone. Those Buffer objects have a ton of methods on them. Not sure why this doesn't work (need to look more deeply into it), but it seems like we'd want to not clone those rich object and only clone "plain old JS objects" who's constructor is Object. Things that aren't class instances or built-ins.
This is a quick fix. I need to add tests but I'm on the road, won't get to it until this weekend.
Before submitting the PR, please make sure you do the following

[ ] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
[ ] This message body should clearly illustrate what problems it solves.
[ ] Ideally, include a test that fails without this PR but passes with it.

Tests

[x] Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

[ ] If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts

Oh I see what's going on, those two methods toString and toLocaleString, those are enumerable properties of Buffer, but aren't enumerable properties of a plain object. This is an issue I didn't forsee. This fix will fix that though, treating Buffer as opaque.

Thanks for merging Ben... note that there is still a minor issue that if you had a config like:
vite: {
  server: {
    toString: () => {}
  }
}

It would still fail due to that conflicting with the Object's own method. I'll have another small fix for that later.


LSP Folding or Folding in General

I'm interested in seeing if it's possible to add lsp based folding to neovim kickstart. I've been looking around for how to configure this properly and have not found a proper implementation for myself yet.
I've had odd problems like having the same buffer open in two windows will make everything collapse or expand to the last set z-M or z-R once I saved the file with :w and would also move my cursor all the way to the top of the buffer in the other window I wasn't using -- lots of frustrating behaviors that would make me move to doom emacs agan for the next hour or so. I was using UFO -- it's probably just the way I had it configured.
A few other flavors of neovim have decent implementations of folding behavior by default, but that not as fun as having kickstart.

Can you please give a specific example (like a link?) to what you're looking for?

@Maxuvious Please respond. If we don't hear from you in another week I'll close the issue, and thanks for the report!

@Maxuvious
I recently made a PR which might be related to this issue.
Frankly, I think adding a plugin for this feature would be a matter of opinion. However, at least I believe it's necessary for someone, and it wouldn't be a bad idea to note it as a best practice to help those lost beginners.
If you agree with my PR, I would appreciate it if you would use #1198 and give me your feedback.


NOT operator should not return internal error when args are not boolean value

Describe the bug
❯ select not('hi');
Internal error: NOT 'Literal { value: Utf8("hi") }' can't be evaluated because the expression's type is Utf8, not boolean or NULL.
This was likely caused by a bug in DataFusion's code and we would welcome that you file an bug report in our issue tracker
❯ select 1 and 2;
Error during planning: Cannot infer common argument type for logical boolean operation Int64 AND Int64

I think the return error message of NOT should like And operator, they both only work for boolean value.
Originally posted by @haohuaijin in https://github.com/apache/arrow-datafusion/pull/8957#discussion_r1463345264
To Reproduce
No response
Expected behavior
No response
Additional context
No response

Ideally, something early in the code (perhaps the type coercion logic) should return an error if the argument to not can't be coerced to Boolean
It looks like perhaps we need to add a clause to
https://github.com/apache/arrow-datafusion/blob/af3d19038ef40e45c70c6e9a28798ee53795dfe9/datafusion/optimizer/src/analyzer/type_coercion.rs#L179-L182
Perhaps following the model of Expr::IsNotNull
As @haohuaijin  notes we may want to update https://github.com/apache/arrow-datafusion/blob/e642cc2a94f38518d765d25c8113523aedc29198/datafusion/physical-expr/src/expressions/not.rs#L83-L92 to not check for is_null

I think this is a good first issue -- the code should be a matter of following existing patterns and ensuring there is some tests for this

I want try implement this 😄

As @haohuaijin notes we may want to update
https://github.com/apache/arrow-datafusion/blob/e642cc2a94f38518d765d25c8113523aedc29198/datafusion/physical-expr/src/expressions/not.rs#L83-L92
to not check for is_null

I think we still need check is_null, because get_casted_expr_for_bool_op will convert null to ScalarValue::Boolean(NULL), but ScalarValue::Boolean(NULL) can not try_into() to bool type, so it will throw an error: Internal error: Cannot convert Boolean(NULL) to bool.


policiesAPI: Add 'homeOwnershipWithdrawal' Field to the vestedBenefits Schema

Description
Upon reviewing the API specification for the Policy schema, I've identified a enhancement opportunity: the inclusion of a homeOwnershipWithdrawal field.
Currently the homeOwnershipWithdrawal amount is not available.
Suggested Change
I propose the addition of the homeOwnershipWithdrawal field to the vestedBenefits schema:
homeOwnershipWithdrawal:
type: number
description:
The total amount available for the insured person to withdraw or borrow against from their retirement capital for the purpose of financing home ownership.

Proposed change see https://github.com/swissfintechinnovations/ca-pension/commit/ccb60c858a01f0b38d1983ea7ec62ff35cc58877 -> Note: I have proposed a different name for the field.

Resolved with version 1.0.0 of the Pension API.


client.logout() bug

When I use client.logout(); I get this

I use it after client.login() (login is correct, because I can check information about profile). I was trying simple await, but nothing has changed.

Is your client logged into an account before you call the logout method?

Yes

I've given this thread the Bug tag until further updates

This issue is fixed with #31
You can download Amino.NET version 1.7.0-dev0.2.0 from NuGet in order for it to work while no stable new release is out yet


Step/Dir spindle decel issue

Version and Build Date
Version = 1.2.4
Not a bug.  More like Mesact (maybe) needs some tweaking on how a step/dir spindle config is generated.
To summarize, both PnCConf and Mesact create a step/dir spindle config with stepgen.N.enable connected to spindle.N.on.  I believe this connection results in instant decel which doesn't respect the max accel desired for the spindle.
I reported on the forum here:
https://forum.linuxcnc.org/39-pncconf/49366-pncconf-mesact-step-dir-spindle-issue#273871
To Reproduce
Steps to reproduce the behavior:

Create any config with a step/gen spindle
Set max accel for the spindle/stepgen
Check the resulting config.  spindle.N.on will be connected to stepgen.N.enable
When the spindle is turned off (gcode, halui, etc.) the stepgen will stop instantly.
If the spindle drive is in position mode with tight following error or gains, the spindle will abruptly stop - perhaps violently.

Expected behavior
Would like a basic config which respects the spindle accel/decel using a different HAL connection scheme
Operating System
OS =  Debian 12
Not sure what the best solution is, given the various spindle on/off control methods and HAL schemes.  Probably only affects step/dir spindles with the drives in position mode (i.e. C-axis lathes with a shared spindle/axis motor)
Or I could be wrong about this... I don't have a working step/dir spindle (quite) yet, but I stumbled across various discussions of the issue while working on my current project.

interesting you posted that in the pncconf section which is only monitored by Chris and knowing him he will take offense to the mention of mesact in "his" section.
None the less an interesting problem to think about. A quick thought is spindle enable should be connected to power not spindle on.
JT

Oh dear... didn't mean to cause offense.
It's not obvious who is 'in charge' of what in the LCNC backstage world.  I just dropped it in that sub as I noticed identical behavior between PnCConf and mesact.
If there's something I can do to help work on the issue let me know.

And is what you mentioned one of the reasons qtpyvcp appears to have been (slightly) persona-non-grata'ed?

Yes Chris is the author of qtvcp and does not like pyqtvcp because the author worked on qtvcp with Chris until he realized that the approach was wrong.

I see Chris did not reply to your post...
JT

I'm slightly surprised nobody's responded to my post.
Well, thanks for responding here.  I'm guessing you're knee-deep working on V2, but if/when you do get time to take a look at this issue I'll be happy to help with testing.

Ok, I'll see what I can do... it should be fixed in this and V2. You might ask a general question in Driver Boards about spindle decel, maybe Peter will chime in with some of his wisdom.
Aye, I'm plowing along with V2 trying to make it much better and easier to use than this one.
JT


"-"  should not be in the stripped char list

Hi @eksperimental,
Actually the hyphen should be in the list of stripped chars. If you have a title like "The --help option", you would expect an anchor like "the-help-option" rather than "the---help-option". Thank anyway for the patch! :-)

So true, o just overlooked that situation


release apk(s) for cpu arch(s), not in one apk...

it overall takes enough storage for me, knowing it could l
take lesser.

Hey! @idontveapc
Can you please specify the CPU arch apk that you need?
Is it one of them?
app-arm64-v8a-release.apk
app-armeabi-v7a-release.apk
app-x86_64.apk

Hey! @idontveapc  You can checkout the latest release and update me if it's working fine. I will close the issue once you verify.


New cheatsheet item syntax

This PR builds on top of #457. It changes the syntax to the one discussed between @naomiblack  and @kwalrath

this is still not working for me.
I see this on Dart:

I pushed this to master, but not to the live site. I'm fairly sure this is right and just missing content...

Did you run gulp build-dart-cheatsheet?

Closing as this has landed on master. I have created a new PR to update the cheatsheet docs themselves to this new syntax: https://github.com/angular/angular/pull/5733


BTRX-209 & BTRX-172 - Add Archive feature to update election  API - Implement dataUseLetter, dulName and version persistence in election table.

Implement persistence of consent' dataUseLetter, dulName fields when a new election is created. Implement an archived flag in election entity

[X] Submitter: Include the JIRA issue number in the PR description
[X] Submitter: Make sure Swagger is updated if API changes
[ ] Submitter: Check documentation and code comments. Add explanatory PR comments if helpful.
[ ] Submitter: JIRA ticket checks:

Acceptance criteria exists and is met
Note any changes to implementation from the description
Add notes on what you've tested

[ ] Submitter: Update RC_XXX release ticket with any config or environment changes necessary
[ ] Submitter: Update FISMA documentation if changes to:

Authentication
Authorization
Encryption
Audit trails

[ ] Submitter: If you're adding new libraries, sign us up to security updates for them
[ ] Tell the tech lead (TL) that the PR exists if they wants to look at it
[ ] Anoint a lead reviewer (LR). Assign PR to LR

Review cycle:

LR reviews
Rest of team may comment on PR at will
LR assigns to submitter for feedback fixes
Submitter rebases to develop again if necessary
Submitter makes further commits. DO NOT SQUASH
Submitter updates documentation as needed
Submitter reassigns to LR for further feedback

[ ] TL sign off
[ ] LR sign off
[ ] Product Owner sign off
[ ] Assign to submitter to finalize
[ ] Submitter: Verify all tests go green, including CI tests
[ ] Submitter: Squash commits and merge to develop
[ ] Submitter: Delete branch after merge
[ ] Submitter: Test this change works on dev environment after deployment. YOU own getting it fixed if dev isn't working for ANY reason!
[ ] Submitter: Verify swagger UI on dev environment still works after deployment
[ ] Submitter: Inform other teams of any API changes via hipchat and/or email
[ ] Submitter: Mark JIRA issue as resolved once this checklist is completed

Coverage increased (+0.002%) to 61.559% when pulling 6c58d9b42ec1301fcfcfb245707bd7a4508c467d on GAWB-3577 into 119512bf3c23a01a1087af0ff4d1ccf85285c976 on develop.

@rushtong I worked on your feedback. Please let me know if I need to check something else. Thanks!

@vvicario - I leave all further feedback to @ansingh7115 :-) Changes look mostly good.


Fill document not closed

Hello, by filling in the fields in my pdf template, I noticed that the created pdf document is not closed and the following error appears:
java.io.IOException: COSStream has been closed and can not be read. Perhaps its enclosing PDDocument has been closed?
I realized it when I tried to make a renderimage of the closed document.
Can you help me?
This is my code:
`
PDFBoxResourceLoader.init(context);
PDFMergerUtility ut = new PDFMergerUtility();
        PDDocument pdfDest = new PDDocument();

        //Leggo Template
        PDDocument document = PDDocument.load(templateDefault);

        PDDocumentCatalog docCatalog = document.getDocumentCatalog();
        PDAcroForm acroForm = docCatalog.getAcroForm();

        for (Map.Entry<String, String> item : data.entrySet()) {
            String key = item.getKey();
            PDField field = acroForm.getField(key);
            if (field != null) {

                Crashlytics.log(0, "fillPDF", "Form field with placeholder name: '" + key + "' found");
                Log.d("fillPDF", "Form field with placeholder name: '" + key + "' found");

                if (field instanceof PDTextField) {

                    Crashlytics.log(0, "fillPDF", "(type: " + field.getClass().getSimpleName() + ")");
                    Log.d("fillPDF", "(type: " + field.getClass().getSimpleName() + ")");

                    ((PDTextField) field).setValue(item.getValue());
                    field.setReadOnly(true);

                    Crashlytics.log(0, "fillPDF", "value is set to: '" + item.getValue() + "'");
                    Log.d("fillPDF", "value is set to: '" + item.getValue() + "'");

                } else if (field instanceof PDPushButton) {

                    Crashlytics.log(0, "fillPDF", "(type: " + field.getClass().getSimpleName() + ")");
                    Log.d("fillPDF", "(type: " + field.getClass().getSimpleName() + ")");

                    PDPushButton pdPushButton = (PDPushButton) field;

                    List<PDAnnotationWidget> widgets = pdPushButton.getWidgets();
                    if (widgets != null && widgets.size() > 0) {
                        PDAnnotationWidget annotationWidget = widgets.get(0); // just need one widget

                        String filePath = item.getValue();
                        File imageFile = new File(pathImageFirma + filePath);

                        if (imageFile.exists()) {

                            PDImageXObject pdImageXObject = PDImageXObject.createFromFile(imageFile, document);
                            float imageScaleRatio = (float) pdImageXObject.getHeight() / (float) pdImageXObject.getWidth();

                            PDRectangle buttonPosition = getFieldArea(pdPushButton);
                            float height = buttonPosition.getHeight();
                            float width = height / imageScaleRatio;
                            float x = buttonPosition.getLowerLeftX();
                            float y = buttonPosition.getLowerLeftY();

                            PDAppearanceStream pdAppearanceStream = new PDAppearanceStream(document);
                            pdAppearanceStream.setResources(new PDResources());
                            try (PDPageContentStream pdPageContentStream = new PDPageContentStream(document, pdAppearanceStream)) {
                                pdPageContentStream.drawImage(pdImageXObject, x, y, width, height);
                            }
                            pdAppearanceStream.setBBox(new PDRectangle(x, y, width, height));

                            PDAppearanceDictionary pdAppearanceDictionary = annotationWidget.getAppearance();
                            if (pdAppearanceDictionary == null) {
                                pdAppearanceDictionary = new PDAppearanceDictionary();
                                annotationWidget.setAppearance(pdAppearanceDictionary);
                            }

                            pdAppearanceDictionary.setNormalAppearance(pdAppearanceStream);
                            Crashlytics.log(0, "fillPDF", "Image '" + filePath + "' inserted");
                            Log.d("fillPDF", "Image '" + filePath + "' inserted");

                        } else {
                            Crashlytics.log(0, "fillPDF", "File " + filePath + " not found");
                            Log.d("fillPDF", "File " + filePath + " not found");
                        }
                    } else {
                        Crashlytics.log(0, "fillPDF", "Missconfiguration of placeholder: '" + key + "' - no widgets(actions) found");
                        Log.e("fillPDF", "Missconfiguration of placeholder: '" + key + "' - no widgets(actions) found");
                    }
                } else {
                    Crashlytics.log(0, "fillPDF", "Unexpected form field type found with placeholder name: '" + key + "'");
                    Log.e("fillPDF", "Unexpected form field type found with placeholder name: '" + key + "'");
                }
            } else {
                Crashlytics.log(0, "fillPDF", "No field found with name:" + key);
                Log.e("fillPDF", "No field found with name:" + key);
            }
        }

        //Chiudo document
        ut.appendDocument(pdfDest, document);
        document.close();

        long substart = System.currentTimeMillis();
        File output = new File(pathFileFirma, nomeFileFirma);
        pdfDest.save(output);
        Log.d("formData", "save took " + (System.currentTimeMillis() - substart) / 1000);
        pdfDest.close();
        templateDefault.close();

        PDFRenderer renderer = new PDFRenderer(document);
        // Render the image to an RGB Bitmap
        Bitmap pageImage = renderer.renderImage(0, 1, Bitmap.Config.RGB_565);

        // Save the render result to an image
        File renderFile = new File(pathFileFirma, nomeFileImmagineFirma);
        FileOutputStream fileOut = new FileOutputStream(renderFile);
        pageImage.compress(Bitmap.CompressFormat.JPEG, 100, fileOut);
        fileOut.close();

        return true;
    } catch (IOException e) {
        e.printStackTrace();
        return false;
    }
}`

Please post the stack trace
Tell where the exception happens in the code above
Don't do a merge on unsaved files. Save them and then do the merge.
If the exception happens when saving, please look at the half-saved PDF file and post the last few lines of the file, starting with the line that has " obj" in it.


IDEM-9-UI

It bootstrap land, before we moved to another framework, we would have used an alert.  Rather a solid fill like this https://getbootstrap.com/docs/4.0/components/alerts/


feat(ci): add dispatch-sim-evaluation-tools.yaml

Note: Confirm the contribution guidelines before submitting a pull request.
Click the Preview tab and select a PR template:

Standard change
Small change

Do NOT send a PR with this description.

@HansRobo How are you?


Audio Example not working

https://magnum.graphics/showcase/audio/ doesn't play any audio on my end.
Tested on recent Chromium and Firefox (webgl1 enabled).
Also according to someone else:

I get this in Vivaldi's console:
The AudioContext was not allowed to start. It must be resumed (or created) after a user gesture on the page.
https://developer.chrome.com/blog/autoplay/
So, yeah, looks like some media policy thing.

The page requires a "user gesture" to get permission to play audio or video. Either delay the audio playback or app execution on click/key press or click really fast before the application starts :)
This is  a recent change in Chrome and the example doesn't do anything to work around this browser security policy yet.

Interesting. I managed to get it working by spamming click, tho it just sounds like regular stereo panning without HRTF, which I don't think is spatialized, just positional; unless that's the intended effect... or maybe it's just another bug 🤔


How to disable list More Video

How to disable list More Video

You can't, the web player does not allow it.


fixes #3641 convert data type when reporting results

We should raise warning for non-standard value format. This includes: int, float, single-value numpy array, and dict with default float. We should not convert the values for users silently, which might cause unexpected behaviors.

@ZhiyuanChen , could you update this pr based on @ultmaster 's suggestion, if you agree with this suggestion.

@ZhiyuanChen , could you update this pr based on @ultmaster 's suggestion, if you agree with this suggestion.

Can I ask why not use json.dumps here? As it will raise an Error as @ultmaster mentioned
I will update the pr tomorrow

@ZhiyuanChen , could you update this pr based on @ultmaster 's suggestion, if you agree with this suggestion.

Can I ask why not use json.dumps here? As it will raise an Error as @ultmaster mentioned
I will update the pr tomorrow

I think json.dumps can dump quite a lot of different things. But the types that NNI supports are only a subset of those things.

Closing this PR as there has been no update for a long time. Feel free to reopen in case of any updates.


doc+test image updates

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (ffb59f5) 51.89% compared to head (6a20170) 51.89%.

:exclamation: Current head 6a20170 differs from pull request most recent head b1041e9. Consider uploading reports for the commit b1041e9 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1637   +/-   ##
=======================================
  Coverage   51.89%   51.89%
=======================================
  Files          42       42
  Lines        4916     4916
=======================================
  Hits         2551     2551
  Misses       2215     2215
  Partials      150      150

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Identify monetized APIs

The only available documentation we have is this : https://learn.microsoft.com/en-us/graph/metered-api-list?view=graph-rest-1.0
We will be using this list as our foundation. Should we try automating getting the appropriate endpoints or should we build a static json file in our repo and get notifications when this file is updated?
Thoughts @waldekmastykarz


there is no live preview of the code

Describe the bug
this is a little note on your webcontainer which would be a really amazing feature :) when I try it I just see the little lightbulb and some text, I dont the actual project it just says:
Booting WebContainer
Booting WebContainer
Installing dependencies
Link to the blitz that caused the error
https://stackblitz.com/edit/vite-react-tailwindcss-aurciv?file=src%2FExample.jsx
Steps to reproduce

follow this link:  https://stackblitz.com/edit/vite-react-tailwindcss-l5tpiw?file=src%2FApp.jsx

Expected behavior
I expected a live preview of the code
Parity with Local

[ ] I have run the project in my local machine and I could not reproduce the issue.

Screenshots
No response
Platform
Browser name  = Chrome
Full version  = 97.0.4692.71
Major version = 97
navigator.appName = Netscape
navigator.userAgent = Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/97.0.4692.71 Safari/537.36
performance.memory = {
  "totalJSHeapSize": 84804842,
  "usedJSHeapSize": 80581730,
  "jsHeapSizeLimit":<PHONE_NUMBER>
}
Hash = 528f704493b63b14b6f9ee36935eead8382e8395

Additional context
No response

Hey you can add a configuration file to add a default startCommand.
Otherwise you need to run it manually in the terminal

:wave: It seems this issue has been sitting for a while without new info. I'm closing this, but please feel free to open a new one if you still encounter this problem.


bug: PushPlugin makes Android build fail every time !

Type: bug
Platform: android 5.1 webview
Hello,
I wanted to sanitize my app with last versions of everything, so I created a new Ionic project, right after updating Ionic and Cordova CLIs. Then I encountered a big bug with the pushPlugin. Here is how to simply reproduce :
OS : Windows 7 64 bits
Cordova : 5.1.1
Ionic : 1.6.4
ionic start myApp blank
cd myApp
cordova plugin add https://github.com/phonegap-build/PushPlugin.git
ionic platform add android
ionic build android

Note it doesn't matter if the plugin is added before or after the platform. Build fails anyway with the following error :
FAILURE: Build failed with an exception.

* What went wrong:
A problem occurred configuring root project 'android'.
> Could not resolve all dependencies for configuration ':_debugCompile'.
   > Could not find any version that matches com.android.support:support-v4:+.
	 Searched in the following locations:
		 https://repo1.maven.org/maven2/com/android/support/support-v4/maven-metadata.xml
		 https://repo1.maven.org/maven2/com/android/support/support-v4/
	 Required by:
		 :android:unspecified

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug
option to get more log output.

BUILD FAILED

Total time: 4.364 secs

C:\Users\retraite plus\tmp\myApp\platforms\android\cordova\node_modules\q\q.js:126
					throw e;
						  ^
Error code 1 for command: cmd with args: /s /c ""C:\Users\retraite plus\tmp\myApp\platforms\android\gradlew" cdvBuildDebug -b "C:\Users\retraite plus\tmp\myApp\platforms\android\build.gradle" -Dorg.gradle.daemon=true"
ERROR building one of the platforms: Error: cmd: Command failed with exit code 1

You may not have the required environment or OS to build this project
Error: cmd: Command failed with exit code 1
	at ChildProcess.whenDone (C:\Users\retraite plus\AppData\Roaming\npm\node_modules\cordova\node_modules\cordova-lib\src\cordova\superspawn.js:134:23)
	at ChildProcess.emit (events.js:110:17)
	at maybeClose (child_process.js:1015:16)
	at Process.ChildProcess._handle.onexit (child_process.js:1087:5)

Thanks ahead for fixing this asap !

This issue was moved to driftyco/ionic-service-push-client#22

It seems that the old push-plugin is being depreciated for a newer plugin. We're in the process of migrating everything to this new plugin. Shouldn't be too long for support.

Are you using the Facebook plugin too?
I know about an incompability issue with facebook and push plugins.
Hope it helps!

@mhartington yes, the newer plugin is way better, but I didn't want to migrate already since ngcordova didn't yet.
@paulogr that's true, there WAS an incompatibility between them too, I experienced it in the past. But as I said, you can reproduce this bug very simply by simply adding only the push plugin.


SqlSetup: Connect-SQLAnalysis no longer using LoadWithPartialName()

Pull Request (PR) description

Now the correct assembly should load when using the helper function
Connect-SQLAnalysis. Previously is was using LoadWithPartialName() which
meant that it would load the first assembly in GAC, regardless of which
PowerShell module was used (SQLPS or SqlSever).

This Pull Request (PR) fixes the following issues
Maybe helps with issue #812.
Task list

[x] Added an entry under the Unreleased section in the CHANGELOG.md? Entry
should say what was changed, and how that affects users (if applicable).
[ ] Resource documentation added/updated in README.md?
[ ] Resource parameter descriptions added/updated in README.md, schema.mof
and comment-based help?
[ ] Comment-based help added/updated?
[ ] Localization strings added/updated in all localization files as appropriate?
[ ] Examples appropriately added/updated?
[x] Unit tests added/updated?
See DSC Resource Testing Guidelines.
[x] Integration tests added/updated (where possible)?
See DSC Resource Testing Guidelines.
[x] New/changed code adheres to
DSC Resource Style Guidelines
and Best Practices?

This change is

Wasn't so easy as I thought, have to get back to this at another time.
Failing on this when using SQLPS module:
VERBOSE: INTEGRATION ERROR MESSAGE: PowerShell DSC resource MSFT_SqlSetup  failed to execute Set-TargetResource functionality with error message: System.InvalidOperationException: Failed to connected to Analysis Services instance 'APPVYR-WIN\DSCTABULAR'. ---> System.Management.Automation.PSArgumentException: Cannot find type [Microsoft.AnalysisServices.Server]: verify that the assembly containing this type is loaded.

Codecov Report

Merging #1150 into dev will not change coverage.
The diff coverage is 100%.

@@         Coverage Diff          @@
##            dev   #1150   +/-   ##
====================================
  Coverage    97%     97%
====================================
  Files        33      33
  Lines      4005    4005
====================================
  Hits       3916    3916
  Misses       89      89

I going in the direction of require the SqlServer module for working with Analysis Services, unless someone know another way of loading the types (without using LoadWithPartial).
But for me to do that we need to have a resource for downloading modules, and that is in the works in the PowerShellGet repo.

The resource PSModule has been released in the latest PowerShellGet module. So now we can move forward with this PR I think. But this will be a breaking change, as it no longer will support the SQLPS module, but only the SqlServer module. Because the SqlServer module correctly loads the correct assemblies needed to not have to do LoadWithPartial().

Added this new functionality under a feature flag; 'AnalysisServicesConnection'. This makes it to be a non-breaking change this release. In a future release we can make this the default.

Closing a reopening to kick off the tests.

Closing this PR due to inactivity. If there are someone who wants to work on this issue or PR please open a new PR.


Repeated object creation

https://github.com/pardeike/Achtung2/blob/209d8fc813bd541d421de5825ea8db33d796cdb1/Source/Tools.cs#L33-L45
https://github.com/pardeike/Achtung2/blob/209d8fc813bd541d421de5825ea8db33d796cdb1/Source/Settings.cs#L132-L135
https://github.com/pardeike/Achtung2/blob/209d8fc813bd541d421de5825ea8db33d796cdb1/Source/Main.cs#L210-L213
Tools.RescuingWorkTypeDef Calling it multiple times will generated different  object.

Yes, that is correct

Sorry but I don’t understand what you are saying.

Why is it important to only have one instance? It’s a tiny object and will get garbage collected as soon as no references to it exist anymore.

Well, it’s not only about the worktab visuals. The def database has significant influence on mods and the base game


Release Google.Cloud.AppEngine.Logging.V1 version 1.2.0

Changes in this release:
New features

Change netstandard2.1 target to netstandard2.0 (commit 7707366)

Created release for Google.Cloud.AppEngine.Logging.V1-1.2.0


Elementary's tests schema name is configurable.

Hi, is there a chance to make it possible that tests schema is the same as the one where elementary models resides ? I have only one schema in my data warehouse for this

Hi @ma1ster, this PR does not allow it as we ran into a dbt caching issue.
The good news are @elongl already found a solution, and implemented on this PR.
We will release it on the next version, you can track in this issue, or on our Slack / social media / releases updates :)


The saving gas commit was backported to the v4.1.x line, but changing gas usage is state machine breaking as GasUsed is included in a transaction response hash which is in consensus. This commit reverts that change. v4.1.2 should then be retracted and replaced with v4.1.3
Commit Message / Changelog Entry
type: commit message

see the guidelines for commit messages. (view raw markdown for examples)

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

[ ] Targeted PR against correct branch (see CONTRIBUTING.md).
[ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
[ ] Code follows the module structure standards and Go style guide.
[ ] Wrote unit and integration tests.
[ ] Updated relevant documentation (docs/) or specification (x/<module>/spec/).
[ ] Added relevant godoc comments.
[ ] Provide a commit message to be used for the changelog entry in the PR description for review.
[ ] Re-reviewed Files changed in the Github PR explorer.
[ ] Review Codecov Report in the comment section below once CI passes.

Ack, though I'd like some verification from impacted user that this was the cause of any app hash mismatch

I will contact the user that reported this and ask if they can try it.

Thank you, @colin-axner!


p4rt-1.1: ensure that test receives two unique p4rt nodes to configure

Add a check to p4rt-1.1 to make sure that the test configures two different p4rt nodes

This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia’s intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 56.211%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1181

Relevant Lines:
2101

💛  - Coveralls

/gcbrun

waiting on the merge of https://github.com/openconfig/featureprofiles/pull/1258.

/gcbrun

@xw-g pls. take a look at the new proposal (ATE version). findP4RTNodes() should provide us with 2 unique device_ids/port combinations from the topology.
If this looks ok i'll update OTG version as well

Thanks for the review, updated OTG version accordingly.


Add parentheses around the file extension of the filters

A "cosmetic" fix that surrounds the filter's extension with parentheses, similar to other software, e.g. Qt Designer.

Hi. Looks fine.
But there is a missing close parentheses for dat file, and extra spaces for one of the fmt.
Could you please fix that? You can see it easily in "Files changes".

Should be fine now. Thanks!

I had to make another commit with the updated date.

THere is still a problem on (*.dat") -> (*.dat)". Travis complain about that.

Looks good to me.
Thank you for the PR !

Yep. It's fine. Thanks a lot.


Get response function

I read your code a bit and it seems like in this function you let the bot learn from user's response. However, it doesn't seem to work in my test. I probably don't understand it enough. How did you test it? How can I see it in action?

Try this example https://github.com/gunthercox/ChatterBot/blob/master/examples/learning_feedback_example.py#L10
Try to enable logging mechanism, you will get to know how bot learning response and how logic adapters are working, etc.
https://github.com/gunthercox/ChatterBot/blob/d5540e1429100ecea854e8b5a8c51b1d35b3e9ad/examples/learning_feedback_example.py#L10


Login with premium account failing

Describe the bug
When logging in today, I get the error: Authentication failed: premium account required.
This was not a problem yesterday and I have checked that my account is still premium on Spotify's website. I have also confirmed  that the password is correct, as i get a different error when typing it wrong deliberately.
To Reproduce
Open settings and enter spotify credentials.
Expected behavior
No error on login.
Environment
Tested on both macOS + ubuntu with latest built action.

+1

Same. I have a Premium Family account.

Same here, authentication API must have had a change, maybe a fix would be as simple as updating the underlying Spotify libraries being used, unless this has manually implemented the Spotify API.

+1
edit: (Premium Family account)

same here

I am seeing this same error on my libspotify-based application, which is not surprising considering they (finally) killed libspotify today.
Is Psst still using something from this older system? I've not got a librespot install on this machine but I don't think anyone has reported issues with that today.

I am seeing this same error on my libspotify-based application, which is not surprising considering they (finally) killed libspotify today.
Is Psst still using something from this older system? I've not got a librespot install on this machine but I don't think anyone has reported issues with that today.

I believe the Psst Spotify API implementation is inspired by librespot, but is completely original and contained within.

Hi, thanks for the report, I'm on it!

Yes but there are two versions of the reverse engineered APIs. I thought Psst had implemented the newer version (HTTPS-based CDN, like librespot-Java). Perhaps that doesn't also cover the login system.

I've not got a librespot install on this machine but I don't think anyone has reported issues with that today.

if it's any help, I just found an old librespot install (dev branch from October 2021, not new-api) and it's still working fine.

librespot is indeed working fine, investigating!

Installed from Snap, still cant login from spotify premium family ("premium account required")

@fabian-st Try to build from source.


Export-IEFPolicies only exports empty files

Hi,
if I use Export-IEFPolicies on en existing Azure AD B2C configuration I get all the files exported but all files are empty.
If I rerun the command a new empty line is added to all the files.
I am not sure if I am doing something wrong here.
Thanks for your help.

Which version are you using?

Fixed in 2.0.14-alpha.

Thank you verry much!


Provisioning K8s HEAD and Stable v1.12.2 failing on Packet

Problem:

provisioning K8s HEAD and Stable v1.12.2 failing on Packet

Projects affected:

Kubernetes

Providers affected:

Packet

Failing Stage:

provisioning

Failing jobs:

https://gitlab.cncf.ci/cncf/cross-cloud/-/jobs/112326
https://gitlab.cncf.ci/cncf/cross-cloud/-/jobs/112330

Error logs:
Error: Error applying plan:

3 error(s) occurred:

* module.master.packet_device.masters[0]: 1 error(s) occurred:

* packet_device.masters.0: provisioning time limit exceeded; the Packet team will investigate
* module.master.packet_device.masters[1]: 1 error(s) occurred:

* packet_device.masters.1: provisioning time limit exceeded; the Packet team will investigate
* module.master.packet_device.masters[2]: 1 error(s) occurred:

* packet_device.masters.2: provisioning time limit exceeded; the Packet team will investigate

Terraform does not automatically rollback in the face of errors.
Instead, your Terraform state file has been partially updated with
any resources that successfully completed. Please address the error
above and apply again to incrementally change your infrastructure.

real    27m28.548s
user    0m12.564s
sys 0m3.680s
Uploading artifacts...
./data/: found 8 matching files
Uploading artifacts to coordinator... ok            id=112330 responseStatus=201 Created token=jbEWumUM
ERROR: Job failed: exit code 1

Screenshot:

Possibly related to #171


common: Add unit test for GetMapField

In my attempts to understand how gremlin query like G.V().Has('a.b.c.d', 'value') accesses the value of a.b.c.d, and especially what happens if the node's metadata contains arrays (Kubernetes pod metadata, I'm looking at you), I ended up writing a unit test for common.GetMapField to validate my assumptions.
Ideally eventually we would add some documentation to http://skydive.network/documentation/api-gremlin , which has some examples of lookup of keys inside a nested map (like G.V().Has('Docker.Labels.io.kubernetes.pod.namespace' ,'my-namespace').Descendants()) but doesn't mention what happens if the metadata contains arrays.

Can you rebase on top of master please ?


Added custom typings for the inplace method of stable.d.ts to avoid implicit any warnings.

This was causing warnings to emit on build.  Just getting rid of that.

Note to @rictic I decided instead of adding explicit type to the anon function, I added custom typing for the stable package inplace method used.

We need to fix master: this PR caused tests to start failing which are not related to the recent WCT errors.


@conda-forge-admin add user @rhiannonlynne

[ ] I read the conda-forge documentation and could not find the solution for my problem there.

Issue:

Environment (conda list):

$ conda list

Details about  conda and system ( conda info ):

$ conda info

Hi! This is the friendly automated conda-forge-webservice.
I just wanted to let you know that I added user @rhiannonlynne in conda-forge/rubin-sim-feedstock#5.


Enable plugins and byterange in GitHub Action MinGW tests

In support of #2468

In theory cp_win32.c includes config.h, which should include ncconfigure.h.
Wonder why this is not working?

@DennisHeimbigner yeah, it's curious, I'm setting up an MSYS2 64 environment on my PC right now to try to get this working, and then I'll backport what I figure out there into the Github Actions.


Basilica should have phases tag

Issue description
I noticed that the Basilica map does not have the phases tag, but the boss has:

one invuln at 50% health
Second boss after death
second invuln at 66% health
third invuln at 33%T health

Feels like a hard phases boss?
Map name
Basilica
Map image
No response
Layout rating
None
Density rating
None
Boss rating
None
Tags

[ ] League mechanics - If map is good for league mechanics that require some space (Breach, Legion)
[ ] Delirium mirror - If you can hold delirium mirror through whole map or delirium mirror gets good value in it
[ ] Outdoors - If map is outdoors or indoors (Dunes vs Cells for example)
[ ] Linear - If map is linear instead of having multiple paths to take. Map counts as linear even if the line goes in circle
[ ] Few obstacles - If map does not have a lot of obstacles (so for example is good for shield charging around)
[ ] Boss Not spawned - If boss is not spawned on entering the map (important for Altar farming, can be verified by checking for boss altars spawning or not)
[ ] Boss Rushable - If boss is close to map start or can be rushed quickly and reliably, a lot quicker than completing whole map
[X] Boss Phases - If boss has hard phases that force you to wait (delay on initial boss spawn counts too)
[ ] Boss Soft phases - If boss has soft phases that can be bypassed with DPS (teleports at certain threshold, heals, partial damage reduction)
[ ] Boss Separated - If boss room is separated from rest of the map

Thanks, updated


Assertion 'ecma_is_value_integer_number (index_val)' failed in ecma_builtin_promise_all_handler

Jerry version:
Checked revision: 300e40ba
Build command: tools/build.py --debug --logging=on --profile=es2015-subset

OS:
Ubuntu 18.04, x86_64

Test case:
Object.defineProperty(Object.prototype, 6, {});
Promise.all([0]);

Backtrace:
ICE: Assertion 'ecma_is_value_integer_number (index_val)' failed at jerryscript/jerry-core/ecma/builtin-objects/ecma-builtin-promise.c(ecma_builtin_promise_all_handler):348.
Error: ERR_FAILED_INTERNAL_ASSERTION

Program received signal SIGABRT, Aborted.
__GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:51
51	../sysdeps/unix/sysv/linux/raise.c: No such file or directory.
(gdb) bt
#0  __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:51
#1  0x00007ffff7a24801 in __GI_abort () at abort.c:79
#2  0x000055555555f364 in jerry_port_fatal (code=ERR_FAILED_INTERNAL_ASSERTION)
    at jerryscript/jerry-port/default/default-fatal.c:71
#3  0x000055555558ac1f in jerry_fatal (code=ERR_FAILED_INTERNAL_ASSERTION)
    at jerryscript/jerry-core/jrt/jrt-fatals.c:58
#4  0x000055555558ac71 in jerry_assert_fail (assertion=0x5555555da2b8 "ecma_is_value_integer_number (index_val)",
    file=0x5555555da060 "jerryscript/jerry-core/ecma/builtin-objects/ecma-builtin-promise.c",
    function=0x5555555d3e20 <__func__.5164.lto_priv.262> "ecma_builtin_promise_all_handler", line=348)
    at jerryscript/jerry-core/jrt/jrt-fatals.c:82
#5  0x0000555555587d41 in ecma_builtin_promise_all_handler (function=867, this=72, argv=0x5555558f18dc <jerry_global_heap+1324>,
    argc=1) at jerryscript/jerry-core/ecma/builtin-objects/ecma-builtin-promise.c:348
#6  0x00005555555a0776 in ecma_op_function_call (func_obj_p=0x5555558f1710 <jerry_global_heap+864>, this_arg_value=72,
    arguments_list_p=0x5555558f18dc <jerry_global_heap+1324>, arguments_list_len=1)
    at jerryscript/jerry-core/ecma/operations/ecma-function-object.c:589
#7  0x00005555555a1955 in ecma_process_promise_reaction_job (obj_p=0x5555558f18d8 <jerry_global_heap+1320>)
    at jerryscript/jerry-core/ecma/operations/ecma-jobqueue.c:170
#8  0x00005555555a1d73 in ecma_process_all_enqueued_jobs ()
    at jerryscript/jerry-core/ecma/operations/ecma-jobqueue.c:343
#9  0x00005555555befcb in jerry_run_all_enqueued_jobs () at jerryscript/jerry-core/api/jerry.c:570
#10 0x00005555555bdcf1 in main (argc=3, argv=0x7fffffffdc58) at jerryscript/jerry-main/main-unix.c:863

Found by Fuzzinator with grammarinator.

Changing the index (6) in the Object.defineProperty call results further assertion failures:
Changing to 2:
ICE: Assertion 'ecma_is_value_object (capability) && ecma_is_value_object (array) && ecma_is_value_object (ctor)' failed at /home/reni/work/jerryscript/jerry-core/ecma/builtin-objects/ecma-builtin-promise.c(ecma_builtin_promise_do_all):397.
Although, the failure happens in different method, but it's similar to #2468
Changing to 3:
ICE: Assertion 'ecma_is_value_object (value)' failed at /home/reni/work/jerryscript/jerry-core/ecma/base/ecma-helpers-value.c(ecma_get_object_from_value):659.
This might be related to #2465 .
Changing to 4:
ICE: Assertion 'ecma_is_value_boolean (handler) || ecma_op_is_callable (handler)' failed at /home/reni/work/jerryscript/jerry-core/ecma/operations/ecma-jobqueue.c(ecma_process_promise_reaction_job):158.
Changing to 5:
ICE: Assertion 'ecma_is_value_boolean (already_called)' failed at /home/reni/work/jerryscript/jerry-core/ecma/builtin-objects/ecma-builtin-promise.c(ecma_builtin_promise_all_handler):322.
Changing to 7:
ICE: Assertion 'ecma_is_value_object (value)' failed at /home/reni/work/jerryscript/jerry-core/ecma/base/ecma-helpers-value.c(ecma_get_object_from_value):659.
This might be related to #2465
Changing to 8:
ICE: Assertion 'ecma_is_value_object (remaining)' failed at /home/reni/work/jerryscript/jerry-core/ecma/builtin-objects/ecma-builtin-promise.c(ecma_builtin_promise_remaining_inc_or_dec):274.

Number 2 gets fixed with #2491


Verify ConfigMap checksums before reloading

What did you do?
I'm managing the Secret's manually myself to apply relabel_configs. In doing so I ran into the configmaps.json part of the Secret.
Initially this worried me because I'd have to work through the makeRuleConfigMap logic for consistently hashing ConfigMaps, but then it seems that the prometheus-config-reloader doesn't even verify the checksums.
I've verified a custom Secret with invalid checksums is reloaded without concern.
https://github.com/coreos/prometheus-operator/issues/291 talks a bit about requiring this field's existence, but not a verification check.
What did you expect to see?
Checksums should be verified, yes? Are they an artifact of an older design? Or just used for notifications (I'm not too familiar with k8s offers object watches.)

The checksum is only to signify whether the content of a ConfigMap has changed. This is done in order to avoid reloading Prometheus when it's not strictly necessary, or vise versa to force reload Prometheus when a ConfigMap hash has changed.

Alright, do you think they should be verified? RBAC handles the permissions required to update ConfigMaps, so nothing like that is needed here.

The reloads are synchronized by the config reloaded so there can’t be a race condition there.
I don’t think there’s a reason to verify them.

Agreed. Thanks!


feat: holistic SAFE Txids handling

Description
Follows-up on https://github.com/shapeshift/web/pull/7506 by gracefully handling SAFE Tx hashes / Txids across the app.
Actually does - cherry-picks https://github.com/shapeshift/web/pull/7698 + adds SAFE handling on top of that. Note: This does not handle sends, as they will require a new status step.
Tested in:

[x] RFOX

[x] Stake
[x] Unstake
[ ] Claim (unable to test with SAFE)
[x] Change addy

[x] THORChain LP - correctly disabled ✅ - we cannot do this because of tx.origin shenanigans
[x] DeFi section

[x] Savers Deposit is disabled ✅ - we cannot do this because of shenanigans re: tx.origin
[x] ETH/FOX LP

[x] Withdraw
[x] Deposit

[x] ETH/FOX Staking

[x] Withdraw
[x] Deposit
[x] Claim

[x] FOXy

[x] Withdraw
[x] Deposit - implemented for the sake of consistency - deposits are disabled for FOXy
[x] Claim (but untestable currently, gotta wait 13 days)

[x] THORChain Lending effectively ded
[x] Sends
[ ] Swapper

[x] Regression test swapper and ensure SAFE Tx detection is still happy
[x] RFOX Arbitrum Bridge - unapplicable
[x] Arb Claims (implemented but untestable)

Pull Request Type

[ ] :bug: Bug fix (Non-breaking Change: Fixes an issue)
[ ] :hammer_and_wrench: Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
[ ] :nail_care: New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

closes N/A
Risk

High Risk PRs Require 2 approvals

What protocols, transaction types or contract interactions might be affected by this PR?

High - Tx status detection could be borked for both SAFE Txs in swapper, and SAFE and non-safe Txs across the app
Testing

Do a full regression test of all the above, non-SAFE Txs status detection and their Tx link should still be happy (including approvals)
Ensure SAFE Txs are properly handled, with the "x out of y signed" copy/polling and correct Tx links (SAFE Tx link when queued, on-chain Tx afterwards)

Engineering

Operations

Screenshots (if applicable)
RFOX

Stake: https://jam.dev/c/836607d0-9010-4e50-8ee9-4e2fd774418f
Unstake: https://jam.dev/c/8a0a0c16-b5df-4c9a-b979-58dc0ddd6dbd
Claim: Unable to test
Change addy: https://jam.dev/c/0cedf9e1-c3e2-4da6-9b5f-2d4dfd1b9f1c

ETH/FOX LP

Withdraw: https://jam.dev/c/011e08c7-d274-4b89-a3b7-8df2760b6d5d
Deposit: https://jam.dev/c/a8f911eb-2c59-4107-b53c-5f2f08a37480

ETH/FOX Staking

Deposit: https://jam.dev/c/be48cc4d-496f-43e8-9c47-fccc3fb694b9
Withdraw: https://jam.dev/c/c5881ada-0ddf-4616-a900-48762196690a
Claim: https://jam.dev/c/d0ded2e5-35ec-43f4-a62a-38f4ff1380c1

FOXy

Deposit: N/A, disabled
Delayed Withdraw: https://jam.dev/c/0e06ea66-5c47-401a-bac4-bbf65b6ff872
Instant Withdraw: https://jam.dev/c/c7b043cc-ea2a-46c1-95a6-65393c3218d5
Claim: Untestable in sc currently

Sends
https://jam.dev/c/9f25c4ee-c2f3-45c9-a17e-2c498f55d21e
Swapper Regression Test
https://jam.dev/c/43dc3493-7bc9-4af0-9345-d46ca8a8bb36

Opening for early review - note THORChain LP hasn't been tested given the current hardfork shenanigans and may require some touchups before this goes in, but everything non-THOR should be testable.

[x]  Deposit ⁉ (jam.dev/c/7a96495b-44a6-498a-a652-6b8febca743c) Deposit went successful but has never been confirmed in the UI

I can see this isn't a SAFE Tx (or at least doesn't seems to be from what I can see in your Jam) - tested both with SAFE and native, and was able to repro with the latter. Applies to FOX farming as well. Fixed in b75a3ce48e:
UNI-V2 Deposit:

SAFE: https://jam.dev/c/7f69c31d-7dc1-4fe0-b966-18f0badfae37
Native: https://jam.dev/c/fc4862ad-590a-4a53-9675-92604f73a75e

UNI-V2 Withdraw:

SAFE: https://jam.dev/c/775bd1ad-a17a-4e30-ba9c-3850b23a7aac
Native: https://jam.dev/c/84f7237d-42b0-4e60-9ca7-7f8f1af79209

FOX Farming Deposit:

Native: https://jam.dev/c/0a04501d-a62e-460b-94be-3ccf7a6e6f95
SAFE: https://jam.dev/c/4727d4fc-94f6-42ce-9c28-2addea51fdfd

FOX Farming Withdraw:

SAFE: https://jam.dev/c/c2ee041a-a4ea-4527-b451-b36167a3442d
Native: https://jam.dev/c/1f7e16ec-920b-409b-af99-695ce7d77518

Also fixed ETH/FOX staking claims the same way in 89925aaedb273ec86a81a1e92dcee178d561aa46 - tested in gome since borked in localhost:

SAFE: https://jam.dev/c/78391a96-a5e3-4900-bf8f-b67fdccc00bd
Native: https://jam.dev/c/0c26fd33-4be6-4d56-81d7-2aa0e8d48f1d

As discussed with @0xApotheosis, going to merge and tackle comments as follow-up so this guy gets his own release 🙏🏽 tyvm  to yourself and @NeOMakinG for making landing this guy possible!


Bower packege files

In order to fix #326 the "main" files has been changed to these from src directory in the bower.json.
Shouldn't the files be at least 'browserified'? The fact that they aren't causes problems in my Rails project.

See the spec: https://github.com/bower/spec/blob/master/json.md#main

Entry-point files have module exports and may use module imports...so they can be used by build tools.


Bugfix Python Snippets

Overview
Resolves bugs in Python Snippets
Fixes: https://github.com/microsoftgraph/microsoft-graph-explorer-v4/issues/2738
Demo
Optional. Screenshots, curl examples, etc.
Notes
Optional. Ancillary topics, caveats, alternative strategies that didn't work out, anything else.
Testing Instructions

How to test this PR
Prefer bulleted description
Start after checking out this branch
Include any setup required, such as bundling scripts, restarting services, etc.
Include test case, and expected output

Closing in favor of https://github.com/microsoftgraph/microsoft-graph-devx-api/pull/1718