Add config options for the new ArtifactWatchBar.

I have more watchbar code done but the watchbar system is a bit messed up in the beta so I'm going to wait before submitting it.


Update to RT v194.1.0 and .NET 8

Audio will be broken by this PR until https://github.com/space-wizards/RobustToolbox/pull/4761


osgconv can't create jpg file from *.osgb file

osgconv -O "inlineImages" C:\OBJ2GLTF\testobj\osgb\Tile_+000_+001.osgb  C:\OBJ2GLTF\testobj\osgb\Tile_+000_+001.obj
osgconv -O "useExternalBinaryArray mergeAllBinaryFiles" C:\OBJ2GLTF\testobj\osgb\Tile_+000_+001.osgb  C:\OBJ2GLTF\testobj\osgb\Tile_+000_+001.obj
Data written to 'C:\OBJ2GLTF\testobj\osgb\Tile_+000_+001.obj'.
I can see 2 files which genarated ,(.mtl,.obj). And mtl file content is below
newmtl material_2
Ka 0.501961 0.501961 0.501961 1
Kd 0.501961 0.501961 0.501961 1
Ks 0 0 0 1
newmtl material_1
Ka 1 1 1 1
Kd 1 1 1 1
Ks 0 0 0 1
map_Kd Tile_+000_+001_0.jpg===================I can't find this jpg .
why can't jpg file be generated?

@liyihongcug the options you passed to osgconv are exclusive to the osgjs plugin, I mean to convert from osg formats to osgjs ( see https://github.com/cedricpinson/osgjs/wiki/Convert-model-with-OSG ).
If what you want is to convert from osgb to obj the you should do osgconv -O OutputTextureFiles file.osgb file.obj
You can see all the options on the osgb format doing osgconv --format:
/osgconv --format osgb Plugin osgPlugins-3.5.0/osgdb_osg.so {     ReaderWriter : OSG Reader/Writer     {         features   : readObject readNode writeObject writeNode          extensions : .osg                           OpenSceneGraph Ascii file format         extensions : .osgs                          Pseudo OpenSceneGraph file loaded, with file encoded in filename string         options    : OutputTextureFiles             Write out the texture images to file         options    : includeExternalReferences      Export option         options    : precision                      Set the floating point precision when writing out files         options    : writeExternalReferenceFiles    Export option     }     ReaderWriter : OpenSceneGraph Native Format Reader/Writer     {         features   : readObject readImage readNode writeObject writeImage writeNode          extensions : .osg2                    OpenSceneGraph extendable format         extensions : .osgb                    OpenSceneGraph extendable binary format         extensions : .osgt                    OpenSceneGraph extendable ascii format         extensions : .osgx                    OpenSceneGraph extendable XML format         options    : Ascii                    Import/Export option: Force reading/writing ascii file         options    : Compressor=<name>        Export option: Use an inbuilt or user-defined compressor         options    : ForceReadingImage        Import option: Load an empty image instead if required file missed         options    : SchemaData               Export option: Record inbuilt schema data into a binary file         options    : SchemaFile=<file>        Import/Export option: Use/Record an ascii schema file         options    : WriteImageHint=<hint>    Export option: Hint of writing image to stream: <IncludeData> writes Image::data() directly; <IncludeFile> writes the image file itself to stream; <UseExternal> writes only the filename; <WriteOut> writes Image::data() to disk as external file.         options    : XML                      Import/Export option: Force reading/writing XML file     } }
Also for questions related to the OSG is probably better to do them in the osg-users list/forum.
Cheers.

My final destination is to get gltf file.

In This step, I need transform osgb --> (obj mtl jpg) .
Tips: osgb is oblique photograph file by unmanned aerial vehicle;
If success in the last step, I will use OBJ2GLTF plugin to transform obj--> gltf file. OBJ2GLTF plugin need obj that includes jpg file as texture.

But I fail in osg3.4.
osgconv -O WriteImageHint=IncludeData -O OutputTextureFiles   file.osgb file.obj.
you can try it if u don't believe it.  file.Jpg can't be generated.
I have stopped it for one week.

Hi @liyihongcug

In This step, I need transform osgb --> (obj mtl jpg) .
If success in the last step, I will use OBJ2GLTF plugin to transform obj--> gltf file. OBJ2GLTF plugin need obj that includes jpg file as texture.

These are questions for the OSG user-list not the osgjs project. They are different projects. Here is the place to ask to convert from osgb -> osgjs.

you can try it if u don't believe it. file.Jpg can't be generated.

If you post an example file I could try.

I have sent it to your email(osgis@noreply...). It doesn't support upload.(*.osgb).
Only need transform osgb --> (obj mtl jpg) .

Closing this, as it is not related to osgjs.


nixos.programs.neovim: add vimdiffAlias option

Description of changes
I have added an option to have vimdiff alias to NeoViM
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

why do that instead of changing vimdiff into  nvim -d or vim -d ?  Let's not add more code for something this trivial

I'm not sure to understand, can you rephrase it please?

neovim made the choice to remove vimdiff to make things simpler, I see no point of reintroducing the complexity in nixpkgs. What for ? nvim -d is the same number of characters, syntax doesn't change. you can add yourself a vimdiff executable or nvim -d

I'm not sure to understand.
I thought the viAlias and vimAlias was to keep the compatibility when migrating to NeoViM, if so it lacks a proper vimdiff link to be complete (which can be used to configure git).
I'm not seeing my contribution as a cause of huge complexity tbh.

I thought the viAlias and vimAlias was to keep the compatibility when migrating to NeoViM, if so it lacks a proper vimdiff link to be complete (which can be used to configure git).

I disagree with the viAlias and vimAlias settings, nvim != vi or vim. They predate my maintainership and are kept for backwards compatibility.
Can't you use nvimdiff that is supported by any recent git (just run git difftool --tool-help).
Any code has a maintainance cost.


crypto/rsa: RSA keys newly rejected in Go 1.24

This program works in Go 1.23 but fails in Go 1.24 with "invalid CRT coefficient".
The specific key is taken from a larger test that is now failing, because the key is rejected.
openssl rsa -in dummy.key -check -noout has no complaints about the key.
/cc @rolandshoemaker @filosottile
package main

import (
	"crypto/x509"
	"encoding/pem"
	"fmt"
)

var keyPEM = `-----BEGIN RSA PRIVATE KEY-----
MIIBOgIBAAJBAKj34GkxFhD90vcNLYLInFEX6Ppy1tPf9Cnzj4p4WGeKLs1Pt8Qu
KUpRKfFLfRYC9AIKjbJTWit+CqvjWYzvQwECAwEAAQJAIJLixBy2qpFoS4DSmoEm
o3qGy0t6z09AIJtH+5OeRV1be+N4cDYJKffGzDa88vQENZiRm0GRq6a+HPGQMd2k
TQIhAKMSvzIBnni7ot/OSie2TmJLY4SwTQAevXysE2RbFDYdAiEBCUEaRQnMnbp7
9mxDXDf6AU0cN/RPBjb9qSHDcWZHGzUCIG2Es59z8ugGrDY+pxLQnwfotadxd+Uy
v/Ow5T0q5gIJAiEAyS4RaI9YG8EWx/2w0T67ZUVAw8eOMB6BIUg0Xcu+3okCIBOs
/5OiPgoTdSy7bcF9IGpSE8ZgGKzgYQVZeN97YE00
-----END RSA PRIVATE KEY-----
`

func main() {
	p, _ := pem.Decode([]byte(keyPEM))
	k, err := x509.ParsePKCS1PrivateKey(p.Bytes)
	if err != nil {
		panic(err)
	}

	fmt.Printf("%+v\n", *k)
}

Related Issues

crypto/rsa: mismatched keys no longer error #61077
crypto/x509: ParsePKCS1PrivateKey is not complaint with PKCS#1 standard #14512 (closed)
crypto/tls: LoadX509KeyPair fails to parse some keys, yet they are accepted by OpenSSL #21807 (closed)
crypto/x509: ParsePKCS1PublicKey expects invalid key format #29141 (closed)
crypto/x509: unable to parse certificate with rsassa-pss algorithm #48314
x/crypto/openpgp: Treat PubKeyAlgoRSA and PubKeyAlgoRSASignOnly as equivalent for signatures #27888 (closed)
crypto/x509 does not read RSA-PSS private key files #50532 (closed)

(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)

I am seeing a similar failure in golang.org/x/crypto/openpgp/clearsign when running locally, but oddly I am not seeing it on the dashboard.
% go test
--- FAIL: TestMultiSign (2.72s)
    clearsign_test.go:155: cannot create key: crypto/rsa: invalid CRT coefficient
    clearsign_test.go:155: cannot create key: crypto/rsa: invalid CRT coefficient
    clearsign_test.go:155: cannot create key: crypto/rsa: invalid CRT coefficient
    clearsign_test.go:155: cannot create key: crypto/rsa: invalid CRT coefficient
    clearsign_test.go:155: cannot create key: crypto/rsa: invalid CRT coefficient
    clearsign_test.go:155: cannot create key: crypto/rsa: invalid CRT coefficient
    clearsign_test.go:155: cannot create key: crypto/rsa: invalid CRT coefficient
    clearsign_test.go:155: cannot create key: crypto/rsa: invalid CRT coefficient
    clearsign_test.go:155: cannot create key: crypto/rsa: invalid CRT coefficient
    clearsign_test.go:155: cannot create key: crypto/rsa: invalid CRT coefficient
    clearsign_test.go:155: cannot create key: crypto/rsa: invalid CRT coefficient
FAIL
exit status 1
FAIL	golang.org/x/crypto/openpgp/clearsign	2.919s
%

Ah, I see it, p < q, and
https://github.com/golang/go/blob/e5489a34ca2c31608821d3ac4ec07892fb6a2272/src/crypto/internal/fips140/rsa/rsa.go#L251-L255
assumes p > q which is generally true but I believe not required.

Is there something in the code that makes p > q generally true? The openpgp test is generating its own keys which then fail to validate. It is doing so with a terrible random number generator, and if I make the generator less terrible, the error goes away, but a bad RNG should not trigger invalid keys.

Looking at the openpgp/clearsign failure, it looks like something bad happened before the "keep the CRT values" change. Note the failure beginning at "move key generation":
% go test .  # fa38b41be9 crypto/internal/fips140/rsa: check that e and N are odd
ok  	golang.org/x/crypto/openpgp/clearsign	4.912s
% go test .  # 7d7192e54f crypto/rsa: move precomputation to crypto/internal/fips140/rsa
ok  	golang.org/x/crypto/openpgp/clearsign	4.686s
% go test .  # acd54c9985 crypto/rsa: move key generation to crypto/internal/fips140/rsa
--- FAIL: TestMultiSign (7.29s)
    clearsign_test.go:155: cannot create key: crypto/rsa: decryption error
    clearsign_test.go:155: cannot create key: crypto/rsa: decryption error
    clearsign_test.go:155: cannot create key: crypto/rsa: decryption error
    clearsign_test.go:155: cannot create key: crypto/rsa: decryption error
    clearsign_test.go:155: cannot create key: crypto/rsa: decryption error
    clearsign_test.go:155: cannot create key: crypto/rsa: decryption error
    clearsign_test.go:155: cannot create key: crypto/rsa: decryption error
    clearsign_test.go:155: cannot create key: crypto/rsa: decryption error
    clearsign_test.go:155: cannot create key: crypto/rsa: decryption error
FAIL
FAIL	golang.org/x/crypto/openpgp/clearsign	7.513s
FAIL
% go test .  # c5c4f3dd5f crypto/x509: keep RSA CRT values in ParsePKCS1PrivateKey
--- FAIL: TestMultiSign (3.56s)
    clearsign_test.go:155: cannot create key: crypto/rsa: invalid CRT coefficient
    clearsign_test.go:155: cannot create key: crypto/rsa: invalid CRT coefficient
    clearsign_test.go:155: cannot create key: crypto/rsa: invalid CRT coefficient
    clearsign_test.go:155: cannot create key: crypto/rsa: invalid CRT coefficient
    clearsign_test.go:155: cannot create key: crypto/rsa: invalid CRT coefficient
    clearsign_test.go:155: cannot create key: crypto/rsa: invalid CRT coefficient
    clearsign_test.go:155: cannot create key: crypto/rsa: invalid CRT coefficient
    clearsign_test.go:155: cannot create key: crypto/rsa: invalid CRT coefficient
    clearsign_test.go:155: cannot create key: crypto/rsa: invalid CRT coefficient
    clearsign_test.go:155: cannot create key: crypto/rsa: invalid CRT coefficient
    clearsign_test.go:155: cannot create key: crypto/rsa: invalid CRT coefficient
    clearsign_test.go:155: cannot create key: crypto/rsa: invalid CRT coefficient
    clearsign_test.go:155: cannot create key: crypto/rsa: invalid CRT coefficient
FAIL
FAIL	golang.org/x/crypto/openpgp/clearsign	3.906s
FAIL
% go test .  # dd7ab5ec5d crypto/internal/fips140/rsa: do trial divisions in key generation
--- FAIL: TestMultiSign (2.71s)
    clearsign_test.go:155: cannot create key: crypto/rsa: invalid CRT coefficient
    clearsign_test.go:155: cannot create key: crypto/rsa: invalid CRT coefficient
    clearsign_test.go:155: cannot create key: crypto/rsa: invalid CRT coefficient
    clearsign_test.go:155: cannot create key: crypto/rsa: invalid CRT coefficient
    clearsign_test.go:155: cannot create key: crypto/rsa: invalid CRT coefficient
    clearsign_test.go:155: cannot create key: crypto/rsa: invalid CRT coefficient
    clearsign_test.go:155: cannot create key: crypto/rsa: invalid CRT coefficient
    clearsign_test.go:155: cannot create key: crypto/rsa: invalid CRT coefficient
    clearsign_test.go:155: cannot create key: crypto/rsa: invalid CRT coefficient
    clearsign_test.go:155: cannot create key: crypto/rsa: invalid CRT coefficient
    clearsign_test.go:155: cannot create key: crypto/rsa: invalid CRT coefficient
    clearsign_test.go:155: cannot create key: crypto/rsa: invalid CRT coefficient
    clearsign_test.go:155: cannot create key: crypto/rsa: invalid CRT coefficient
FAIL
FAIL	golang.org/x/crypto/openpgp/clearsign	2.928s
FAIL
%

Yeah I think there's two different issues. The key in the initial issue has ⌈log₂(p)⌉ < ⌈log₂(q)⌉ which can't happen with our keygen (because for even sized moduli we produce primes of nlen/2 with the top two bits set, while for odd moduli we make p longer, while this key... has a 512 bit modulus with a 256 bit p and a 257 bit q, which I honestly wonder how you'd non-intentionally generate such a key). That tickled the bug CL 632955 is fixing.
The openpgp/clearsign failure is different I think, and I am looking into it now.

This diff in openpgp, improving the entropy returned by the random reader, "fixes" the errors, but we should understand why we are mishandling the current reader.
diff --git a/openpgp/clearsign/clearsign_test.go b/openpgp/clearsign/clearsign_test.go
index 051b8f1..6b524eb 100644
--- a/openpgp/clearsign/clearsign_test.go
+++ b/openpgp/clearsign/clearsign_test.go
@@ -6,6 +6,7 @@ package clearsign

 import (
 	"bytes"
+	"crypto/sha256"
 	"fmt"
 	"io"
 	"testing"
@@ -123,15 +124,18 @@ func TestSigning(t *testing.T) {
 	}
 }

-// We use this to make test keys, so that they aren't all the same.
-type quickRand byte
+// We use this to make test keys, so that they are deterministic but not all the same.
+type quickRand struct{ buf [32]byte }

 func (qr *quickRand) Read(p []byte) (int, error) {
-	for i := range p {
-		p[i] = byte(*qr)
+	n := 0
+	for len(p) > 0 {
+		qr.buf = sha256.Sum256(qr.buf[:])
+		m := copy(p, qr.buf[:])
+		n += m
+		p = p[m:]
 	}
-	*qr++
-	return len(p), nil
+	return n, nil
 }

 func TestMultiSign(t *testing.T) {
@@ -139,8 +143,7 @@ func TestMultiSign(t *testing.T) {
 		t.Skip("skipping long test in -short mode")
 	}

-	zero := quickRand(0)
-	config := packet.Config{Rand: &zero}
+	config := packet.Config{Rand: &quickRand{}}

 	for nKeys := 0; nKeys < 4; nKeys++ {
 	nextTest:

Hah, found it. The rng is so bad that it causes p = q, and then we compute q⁻¹ = q^(p-2) mod p which for p = q is 0.
I remember thinking "huh, why is this here" and deciding to remove it because a random source that bad kind of ought to explode. (Looking at the history, it actually looks like it's always been there, so it's not clear if it was because Adam stepped into the same problem.)
https://github.com/golang/go/blob/c390a1c22e8951263e6c01346a4281d604b25062/src/crypto/rsa/rsa.go#L402-L409
We could fix the openpgp/clearsign test by retrying when p = q because this RNG is bad but not so bad that the primes keep coming out equal every time (which I think used to infinite loop), but I kinda prefer erroring out with a clear error rather than hide the brokenness of the random source.

+1 for the error case.

Returning an error in this case is great. We've had to improve these bad RNGs in the past as well.


Initial implementation/test of memory core wrapper

Initial test/implementation of memory core wrapper, modeled after cb_wrapper.
Brings in the original memory genesis files. The memory generator passed a sequence of files as an argument to genesis (see https://github.com/StanfordAHA/CGRAGenerator/blob/34900c1a3b3724226e24df293c2fe8b9528c8cc2/hardware/generator_z/memory_core/run.csh#L1), so I augmented the run_genesis interface to support passing a string (one file) or a list of file names.

Pull Request Test Coverage Report for Build 158

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 92.857%

Totals

Change from base Build 155:
0.0%

Covered Lines:
143

Relevant Lines:
154

💛  - Coveralls

Here's an attempt to refactor the code so they can be shared across the two generators f902373
It works, it's pretty magical, but you can define parameters with default values. You can't define types, but we could change it so that it takes a tuple of default value and type. Also, using the generated wrapper function requires you to use kwargs. We could add support for args, but it will be a bit tricky to get all the different cases right. I think forcing kwargs for now is okay.

Very nice!! I like this wrapper. We can potentially iterate on it but I like having this factored out. Thanks!


ClapRVQTrainer does not have log_with

ClapRVQTrainer does not have "log_with" and it causes error in following line
if 'tensorboard' in self.log_with:
self.accelerator.init_trackers(f"clap_rvq_{int(time.time() * 1000)}", config=hps)
else:
self.accelerator.init_trackers(f"clap_rvq", config=hps)
So, I added log_with refer to SingleStageTrainer class and it works fine.
self.log_with = accelerate_kwargs['log_with'] if 'log_with' in accelerate_kwargs else None

my bad! fixed in 0e3ada6


Using ExecuteJsPlugin with dispatchAgent

import ExecuteJsPlugin from '@secret-agent/execute-js-plugin';

handler.dispatchAgent(async (agent: Agent) => {
      try {
        agent.use(ExecuteJsPlugin);

        const { activeTab, document } = agent;
        const { url } = agent.input;
        const resource = await agent.goto(url);
       agent.waitForPaintingStable();
        // @ts-ignore
        const title = await agent.executeJs(() => {
          // @ts-ignore
          return window.document.title;
        });

and i get:
 Error getting url: TypeError: agent.executeJs is not a function
      at /Users/taity/Work/sanbox/scrapper-proxy/src/index.ts:119:35
      at Generator.next (<anonymous>)
      at fulfilled (/Users/taity/Work/sanbox/scrapper-proxy/node_modules/tslib/tslib.js:107:62)
      at processTicksAndRejections (node:internal/process/task_queues:94:5)

What i doing wrong?
I need to execute JS to resolve captchas. Thanks

@ctaity You're doing it right. We have a design flaw that means this can't currently work with handlers

@ctaity, as @blakebyrnes said, Handlers has a flaw with plugins. The solution is to drop Handler and just use PQueue with the Agent class.
An example:
import PQueue from 'p-queue';
import { Agent } from 'secret-agent';
import ExecuteJsPlugin from '@secret-agent/execute-js-plugin';

(async () => {
  async function createAndRunAgent(url) {
    const agent = new Agent();
    agent.use(ExecuteJsPlugin);

    const { activeTab, document } = agent;
    const resource = await agent.goto(url);
    agent.waitForPaintingStable();
    // @ts-ignore
    const title = await agent.executeJs(() => {
      // @ts-ignore
      return window.document.title;
    });
    console.log({ url, title });
    await agent.close();
  }

  const pqueue = new PQueue({ concurrency: 2 });
  const urls = ['https://news.ycombinator.com', 'https://example.org'];

  for (const url of urls) {
    pqueue.add(() => createAndRunAgent(url));
  }

  await pqueue.onIdle();
})();

Ok no problem thanks!!!! @calebjclark @blakebyrnes !

is this in the pipeline?


Does not display hidden files like .htaccess

Is there a specific option to allow displaying file like .htaccess, .bashrc etc?

Go settings, and check "Show Hidden Files" option.


chore(deps): upgrade dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-main" workflow

Codecov Report

Merging #505 (1fe64e8) into main (de4674c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #505   +/-   ##
=======================================
  Coverage   95.69%   95.69%
=======================================
  Files           1        1
  Lines         395      395
  Branches       53       53
=======================================
  Hits          378      378
  Misses         17       17

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Add Datadog contrib for monitoring purpose

Description
Datadog is a tool that allows you to send metrics that you create
dashboard and add alerting on specific behaviors.
Adding this contrib will allow for users of this tool to log their pipeline
information to Datadog.
Motivation and Context
Based on the status change of a task, we log that information to Datadog
with the parameters that were used to run that specific task.
This allows us to easily create dashboards to visualize the health. For
example, we can be notified via Datadog if a task has failed, or we can
graph the execution time of a specific task over a period of time.
The implementation idea was strongly based on the stale PR
https://github.com/spotify/luigi/pull/2044.
Have you tested this? If so, how?
We've been using this contrib for multiple months now (maybe a year?), at Glossier. This is the main point of reference to see the health of our pipeline.

Interesting, I was certain that I had run the spec suite locally to make sure that all was well.
I'll make sure that the problems are resolved ASAP!

@dlstadther I'll take a look at how we could test this contrib without it being painful. Thanks for your input!

@dlstadther Hey! I've added a bunch of fun tests to make sure everything was working and I'm having a bunch of trouble running the spec suite locally. When running each individual new tests locally all works, but I want to make sure that running the whole suite works fine.

Travis seems to always fail on the docs job and the error being displayed is not something I would understand how to fix, do you have suggestions?
Travis seems to have timeouted on some specs and I don't have the power to re-run the suite. What should I do under that situation? Would you want me to rebase to trigger a re-build or shall I ask you to explicitly re-run the spec suite?

Let me know how to proceed further! :)

I've not seen that doc failure before.
I've restarted the build and will review again after the build completes. (Thanks for your efforts!)

docs tests are still failing with same error
Are you able to build the docs locally? tox -e docs

@dlstadther Docs are running file locally:
tox -e docs yields
_____________________________________________________ summary _________________________________________________________
  docs: commands succeeded
  congratulations :)

Also when I'm running the tests locally that seems to hang on Travis, they all suceed. Not sure what this is all about :/

@Tarrasch Have you experienced this sort of Travis doc failure or test exit before?

No idea, I restarted an older build to know if it's due to changes in this PR or not. Maybe Travis just had  a bad day?

@dlstadther I've tried many different things, I can't figure out why the specs, with the addition of this PR, keeps hanging on Travis.
I also can't figure out why the docs keep failing on Travis while I can run it on my local machine without any problems.
When I try to run tox -e py27-nonhdfs on my local machine, I have a bunch of different specs that fail due to many different kinds of errors. Here is a gist that shows what is failing locally: https://gist.github.com/cabouffard/5e20a4cf787752cb0caebdbc467e9ac0.
Fortunately, those specs aren't failing on Travis, but I can't reproduce Travis' behavior locally. I would need help on this.

This is bizarre... Nothing is standing out to me as an issue and yet there is clearly a problem

@dlstadther What would you suggest the next step be? Can you investigate the issue on your side, can any other collaborator jump and give us their point of view on the matter?
Thanks! :)

@dlstadther Hey, what's the latest on this one? :)

So sorry @cabouffard - been kinda busy and unintentionally neglected this. Hoping to have some more time next week - i'll set myself a reminder! Thanks for your patience :)

(Found a little time today to look into this briefly)
@cabouffard I've downloaded this branch locally and tried building docs (tox -e docs) on 2.7.15 and 3.7.0.
2.7.15 failed with the import error.
3.7.0 was successful.
(Spit balling here a bit...) I'm inclined to suspect the from enum import Enum Python 3.4+ module import as the source of the issue here. And the error is trickling down to fail imports.
I've had personal experience with unittest where I've received misleading errors due to package import errors.
Mind looking into a 3.4- solution for Enum and see if that resolves the issues here?
Thanks!

It has been my turn to be busy! Very clever find about the ENUM, I would have expected a better error message. Thank for taking your time to help me out on this! I'll make the additional changes right now! :)

Regarding the use of enum. Take a look at the Visible Parameter PR. I can't
recall the PR number and im not near a computer. That PR also needed enum
compatibility for Py 3.4-
On Thu, Aug 2, 2018, 12:46 PM Charles-André Bouffard <
<EMAIL_ADDRESS>wrote:

@cabouffard commented on this pull request.
In luigi/metrics.py
https://github.com/spotify/luigi/pull/2434#discussion_r207297118:

@@ -0,0 +1,35 @@
+from enum import Enum

That's such a good point. I can either change how this work by removing
the ENUM logic and replace it with something else that is retro-compatible.
I suggest that we hold until #2278
https://github.com/spotify/luigi/pull/2278 is merged because that PR
contains the change you're suggesting. I would have cherry-picked that
specific commit, but the commit also includes changes that related directly
to the PR, which I don't want to pull here.
I'll rebase once #2278 https://github.com/spotify/luigi/pull/2278 is
merged and will re-run the spec suite and see how it goes from there!
Thanks! :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/spotify/luigi/pull/2434#discussion_r207297118, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AHFoB9xeiMQj13dGwElbCgWN9MEXahyVks5uMyz7gaJpZM4UTul6
.

Just got a computer and see that your comment addressed the exact thing i attempted to mention in my email.
If you're ok with it, we can wait for #2278 to be merged (shouldn't be too long from now)

The associated PR has been merged! Mind pulling in those changes?

@dlstadther Hey friend, this is all exciting and stuff!
Do you think you could force a re-run on Travis to ensure that everything is green?
I'm unsure why it seems to not want to run it automagically
Thanks!

I'm not yet sure why Travis isn't showing as a check here. I've restarted an old build for this PR just to see.
I won't merge until Travis cooperates and shows green :)
Thanks for the quick response!

Travis' request error

GitHub payload is missing a merge commit (mergeable_state: "unknown", merged: false)

Google isn't overly helpful, but it sounds like you might want to rebase with master and force push

@dlstadther Donzo, we'll get through it, I swear! ;)

Travis has now accepted the request! Thanks @cabouffard !

@dlstadther Python3.x builds seem to timeout now?
Test that makes Travis timeout are one of the following:

Test ExternalTask without altering global settings.
test_cmdline_logger

Any experience on the matter?

It's not just the Python 3.x builds, it's all the nonhdfs (core) builds... :/

I'll invest some of my time right now to investigate what would be causing this. This is never easy, is it? :P

I've discovered a problem while debugging, I hoped that this was blocking the execution of the tests that are hanging thus causing the problem we were saying but unfortunately this wasn't the case. At least, the bug has been caught and I've added tests to ensure that all is well.
Something that I don't quite understand is that the specs of cmdline_test are running successfully locally but when ran with tox -e py36-nonhdfs they hang. This is annoying :P

For some kind of voodoo reason, it seems to be hanging trying to connect to S3: https://gist.github.com/cabouffard/eab6ded31ef8ef3dca1c5729ba2bb23d
I'm still investigating!

@dlstadther After running it many many times trying to figure out what was wrong with debug breakpoint and stuff I got the following:
test_cmdline_logger (cmdline_test.CmdlineTest) ... Coverage.py warning: No data was collected.
o

And a few seconds later it crashed. Here are the logs: https://gist.github.com/cabouffard/19a6462f2600afa2b37af4507bd886d0
I can't put more time on this today and I'm OOO for about 2 weeks. I think this is a strong starting point. I think that Coverage is the culprit here :/

@dlstadther Hey, do you think you have more information about that Coverage feature? Happy to work with you on that!

Hey @cabouffard Sorry i haven't found the time to investigate this odd failure any further.
I've only seen this crop up on this PR. Separately, we're also having an issue with mocked S3Client failures. So if you rebase your branch with master, anticipate some other test failures.
Unfortunately, I'm pretty swamped with work and thus my independent luigi contribution is minimized at the moment. But i'm happy to review and help guide where I can.

Totally understandable and no worries! It's probably something that I've done somewhere that's screwing this up. I'll investigate deeper like I said I would relatively soon. I'm unfortunately also pretty swamped but it's important for my sanity to get this merged.
Enjoy! :)

The s3client error i previously mentioned appeared to have been a Travis issue. However, the issue this PR has been cursed with still persists.

This is bizarre. @cabouffard Are you able to run the specific tests (added here) locally with success?
Basically, i'm trying to understand if this is a Travis issue or a side effect of these test additions?

 It's for sure something that is related to this pull request but I'm slowly trying to get to it. I have the same failures locally as on Travis.
Depending on the python version that gets run, different spec timeout but the ones that timeout pass on the other python version.
There is something fishy about it and I'm sure there will be a Ah HA! moment once we discover what it is! (one day)

I suspect one of the spec I've written is bonker and it actually white for the regular 3600 timeout for it to retry running a task, which causes the other specs to also timeout.

@dlstadther I'm unsure about the codecov/changes one, but everything is good to go from my point of view! 🎉

🙌
I'll take another look through this and then give a final sign off in the next couple days/nights! Thanks for the hard work getting those tests passing!

This looks super useful - is this ready to be merged. We would like to give it a go.

@justjoheinz Hey! I haven't much time to play with this, I'll try to get Dillon suggestions in by the end of week!

Thx for this! I'd love to see this merged as well!

@dlstadther Sorry for all the force pushes, I've had trouble with my local environment so I decided to test my commits directly on Travis :)
Now that the specs are all passing, I've tested this branch on our development system and all seems to work accordingly. I think we can finally 🚢 it!
Thank you so much for the help!

Hey yall - just wanna say that we're really excited to be able to use this soon! Good luck getting it past the finish line, can't wait to try to measure our pipeline w/ this integration.

Thanks for the long, hard work @cabouffard !

🎉


Alert when there are new plugin versions

Would be nice not having to go to OctoPrint's console to find out that there are new plugin versions ready to be installed. This ticket is to research if this is possible

Just a little UX thing here... I had to look at the code to figure out what Ignore and Dismiss do, as it's not immediately obvious. Since we can't update plugins from the app (which makes sense, it may disrupt prints and so on), wouldn't a single button to acknowledge the message on the app be acceptable? It would essentially be a "preview" of the reminder that the user would get from the web version.
Of course I may have completely misunderstood the whole thing. :D

Both buttons do something different. I was not able to come up with a better word. They did not pass the test of my wife either. :(
Dismiss = Close window and do not alert for a day (I think)
Ignore = Never alert again for this update. If a new plugin update appears then display again alert
Let me know if you have a suggestion for better words.
Grazie,
Gaston

Maybe "Got it" and "Remind me later"? :-)
Or perhaps "Acknowledge" and "Snooze"…


Better RegEx for invites

I'm not entirely sure how regexs work but invite links have /gg in them and i don't see it in there

nvm i'm blind

@KyeNormanGill pls

iconic


Nick's pull request for a version that works on openmind

Summary of changes:

Some cosmetic changes (variables names, formatting, updating README, etc.).
Added display_interface.py.  This introduces a new data table representing display updates.  Each display update comes with several variables (timestamp, object positions, fixation cross size, task phase and closed-loop gaze position).  These are put into a TimeIntervalsInterface as a dataframe.
Added get_session_paths.py.  This factors out a function to get all the paths to the different components of the data, for either openmind (our cluster) or globus.  This function is passed a _REPO flag from the main run script, which can be either 'openmind' or 'globus' to reflect the two filesystems.
Added timeseries_interfaces.py.  This introduces two interfaces, the AudioInterface and the RewardInterface, that add audio and reward datastreams to the nwb file.

Also, apologies for somehow the filename changes not being tracked by git.  Despite now several times re-trying to get git to track  filename changes (using git mv to rename, deleting and re-branching, forking, etc.), I have no idea why some of the filename changes aren't being tracked.
This code all works great on openmind (with the potential exception of automatic uploading, but I'll try that soon).  Specific things I'd love to get your input on:

Are the interfaces in display_interface.py and timeseries_interfaces.py reasonable?

@nwatters01 I resolved all the conflicts from this branch - can you double check for me and see if everything works as expected? If so, go ahead and merge since it all looks good to me

Though one thing I noticed now is there seems to be a duplicated file on your branch
https://github.com/catalystneuro/jazayeri-lab-to-nwb/blob/nwatters/src/jazayeri_lab_to_nwb/watters/timeseries_interface.py
and
https://github.com/catalystneuro/jazayeri-lab-to-nwb/blob/nwatters/src/jazayeri_lab_to_nwb/watters/timeseries_interfaces.py

Everything works as expected on openmind, thanks for your help!
I'm going ahead and merging


93 - JS: (Main) fix venue info box to not show more than one box per card

fixed: 2016/01/27
by:  BG


feat: send the rejection message directly through the bot

It's a little odd to see the bot tell you to send a message in the same thread.

it was specifically requested and agreed on that the vets would like the human to remain as the original sender of rejection messages.

We may want to send the message in the submission review thread then?

once the user copies the message from the bot, the bot message is removed, btw

Little strange, but ok. Might want to remove CCs if there's nobody to CC.

see #107.


Can't send example email in administration

Description
I open up an email template to send an example email.  I do and retry. Still not working.
Possible Solution
I think there is wrong parameter passed into the email sending method that should be the sales channel but it is not.
Additional context

Hi @JoshuaBehrens
This is a little confusing, but you have to hit "save" before you are able to test this.
There is no live-saving in our modules.
Select Sales Channel -> Click save -> send test mail -> works

Thanks for clearing up 👍
Do I get it right, that there are no mails automatically added to a sales channel? I have to enable them for every sales channel first? But mails are working without assignment 💭

Solved already

Solved already

Woohoo

Woohoo


Iteration Plan for October 2022

This plan captures our work in October. This is a 4-week iteration. We will ship in early November.
Endgame

October 24, 2022: Endgame begins
October 28, 2022: Endgame done

The endgame details for this iteration are tracked here.
Plan Items
Below is a summary of the top level plan items.
Legend of annotations:

Mark
Description

:runner:
work in progress

:hand:
blocked task

:muscle:
stretch goal for this iteration

:red_circle:
missing issue reference

:large_blue_circle:
more investigation required to remove uncertainty

:black_circle:
under discussion within the team

:black_large_square:
a large work item, larger than one iteration

Accessibility

[ ] :runner: Accessibility issues, see query @isidorn @meganrogge team
[ ] :runner: Accessibility explorations vscode#162867 @meganrogge
[ ] :runner: Improve accessibility of Setting indicators vscode#159088 @rzhao271

UX

[ ] Provide guidance for usage of Quick Pick titles vscode#158895 @daviddossett
[ ] Explore how to better express view display styles (tree versus list) vscode#162595 @daviddossett
[ ] :runner: Explore presenting deleted lines in the minimap vscode#161386 @daviddossett
[ ] :runner: Explore UI improvements for the GitHub PR extension vscode-pull-request-github#4029 @daviddossett @alexr00

Workbench

[ ] Setting Profiles

[ ] Show Synced Profiles in Settings Sync Data views vscode#162942 @sandy081
[ ] Exploration: Sharing profiles vscode#159891 @sandy081 @isidorn

[ ] :runner: Align trust and policy UX in settings editor with other indicators vscode#157564 @rzhao271 @sandy081
[ ] :runner: Adopt diffIdentityProvider in search for improved performance vscode#127621 @andreamah
[ ] :muscle: Explore ways to improve interacting with root files and folders in a crowded explorer view @lramos15 vscode#151630
[ ] Introduce basic "home view" entry point for the Command Center vscode#158638 @TylerLeonhardt
[ ] :runner: Improve "Continue On..." (performance, usability, completeness) vscode#163077 @joyceerhl
[ ] Improve how title bar visibility interacts with its interactive components vscode#161948 @sbatten @jrieken
[x] Improve View menu structure for editor actions vscode#158458 @sbatten @daviddossett

Web

[ ] :runner: Continue translations in the web vscode#82595 @Tylerleonhardt

Code Editor

[x] Remove too many folding regions notification vscode#163428 @aeschli
[ ] Make it more clear that long lines are truncated vscode#162320 @alexdima

Merge Editor

[ ] Add "Mark as Handled: action in the Result view vscode#162656 @hediet
[ ] Render diff information in Base vscode#160292 @hediet
[ ] Accept both sides under each other when character-level merging is not possible vscode#157632 @hediet
[ ] Continue Merge editor customer development vscode#162815 @isidorn @stevencl

Notebook Editor

[x] :red_circle: Ensure markdown renderers are always loaded successfully @mjbvz @rebornix
[ ] :runner: Help users diagnose notebook rendering perf issues vscode#154873 @mjbvz
[ ] :muscle: Enable scrollable notebook outputs vscode-jupyter#7096 @amunger
[ ] :muscle: Explore improving files search results for notebooks vscode#95275 @andreamah

Jupyter Notebooks

[ ] :runner: Contributions to the vscode-jupyter extension vscode-jupyter#11581 team

Languages
Python

[ ] :runner: Contributions to the python extension vscode-python#19972 @brettcannon team

JavaScript/TypeScript

[ ] Explore automatic type acquisition on web typescript#45314 @mjbvz

Markdown

[ ] :muscle: Stabilize DocumentPasteEditProvider API to support pasting images vscode#30066 @mjbvz
[x] Finalize support for markdown link refactoring updates vscode#148146 @mjbvz

Debug

[ ] Implement StartDebugging DAP request vscode#160169 @roblourens

Terminal

[ ] Allow extensions to contribute terminal quick fixes vscode#145234 @meganrogge
[ ] Adopt editor quick fix widget for terminal quick fixes vscode#162067 @meganrogge
[ ] Improve UX of port quick fix vscode#162217 @meganrogge

Tasks

[ ] Add task dropdown menu to terminals, hidden by default vscode#162469 @meganrogge

Source Control

[ ] Explore implementing certain git status operations without spawning git vscode#64234 @lszomoru
[ ] Responsive UI updates handling of slow status updates in large mono repos vscode#162417 @lszomoru
[ ] Git - Adopt extension log API vscode#162185 @lszomoru
[ ] SCM: Notification API vscode#161200 @lszomoru
[ ] Git: Improve unsafe repository warning vscode#157159 @lszomoru

Extensions

[ ] :runner: Verify signed extension vscode#162284 @sandy081

API

[ ] API finalization: query @jrieken @mjbvz
[ ] API proposals: query @jrieken @mjbvz
[ ] :runner: Continue finalization of remaining proposed notebook API vscode#149861 @mjbvz @rebornix @roblourens
[ ] :runner: Work with LiveShare on content provider migration vscode#147248 @mjbvz
[ ] :runner: Improve Extensions logging vscode#159892 @sandy081

Extension Contributions

[ ] :runner: Improvements to the Remote extensions vscode-remote-release#7315 @eleanorjboyd @chrmarti @aeschli
[ ] :runner: Improvements to the GitHub Repositories extension query @joyceerhl
[ ] :runner: Improvements to the Live Preview extension query @andreamah @roblourens
[ ] :hand: Fix preview of forwarded ports in Codespaces for Simple Browser and Live Preview vscode-livepreview#111 @andreamah @mjbvz
[x] GHPRI: Adopt localization pipeline vscode-pull-request-github#3913 @alexr00
[ ] GHPRI: Show PR review status vscode-pull-request-github#681 @alexr00

Install / Update

[ ] :runner: Enable Windows 11 explorer context menu feature with Insiders vscode#127365 @deepak1556

Engineering

[ ] :runner: Enrich extension host unresponsive telemetry events to include slow stacks vscode#163819 @jrieken
[ ] :runner: Investigate slow stacks reported from the renderer process vscode#163819 @jrieken
[ ] :red_circle: Explore lazy code loading @jrieken @tyriar
[ ] :red_circle: Explore splitting main bundle in multiple files @jrieken
[ ] :runner: Explore reducing typing latency vscode#161622 @tyriar

Electron

[x] Contribute the utility process and APIs to Electron vscode#154007 @deepak1556
[ ] :runner: Enable AutoDisableAccessibility Chromium runtime flag vscode#162331 @deepak1556
[x] WCO black border under buttons vscode#150778 @rzhao271
[ ] :runner: Adopt display language as locale for electron to properly display WCO vscode#159958 @rzhao271

Documentation

[ ] :runner: Review and update Configure C++ Debugging topic vscode-docs#5518 @gregvanl
[ ] :runner: Update Azure Content, ToC vscode-docs#5614 @gregvanl @isidorn
[ ] Update source control documentation to include the merge editor vscode-docs#5618 @hediet @gregvanl
[ ] Update Dev Container documentation vscode-docs#5696 @gregvanl @bamurtaugh
[ ] Add an Git introductory page vscode-docs#5677 @digitarald

Deferred

[ ] Explore migrating from AMD to ESM vscode#160416 @jrieken
[ ] Support actions on quick pick categories vscode#149057 @TylerLeonhardt @daviddossett
[ ] Explore possibility of unifying explorer selection in focus behind a setting @lramos15
[ ] Align editor find widget with the notebook find widget vscode#144851 @rebornix
[ ] Explore accepting parts of an inline completion proposal vscode#155473 @hediet
[ ] Sandboxing: Explore adopting utility process for shared process vscode#154050 @bpasero @deepak1556
[ ] :runner: White flashing when opening a new window vscode#132339 @rzhao271 @deepak1556

An update to latest Electron 19.1.x would also be welcome:
https://github.com/electron/electron/releases/tag/v19.1.0
https://github.com/electron/electron/releases/tag/v19.1.1
https://github.com/electron/electron/releases/tag/v19.1.2
https://github.com/electron/electron/releases/tag/v19.1.3


2024-12-04_01-35-54_master-next_aws-cli

Automatically created.

Backport failed for kirkstone-next, because it was unable to cherry-pick the commit(s).
Please cherry-pick the changes locally and resolve any conflicts.
git fetch origin kirkstone-next
git worktree add -d .worktree/backport-10596-to-kirkstone-next origin/kirkstone-next
cd .worktree/backport-10596-to-kirkstone-next
git switch --create backport-10596-to-kirkstone-next
git cherry-pick -x f557eec18dcba66b989540a98a7831c99c39d5d1

Successfully created backport PR for scarthgap-next:

#10598

Successfully created backport PR for styhead-next:

#10599


Adds test about http.connection with to client

Ticket: #5746

Requires https://github.com/OISF/suricata/pull/8644

Suricata PR has been merged https://github.com/OISF/suricata/pull/8774

Merged with https://github.com/OISF/suricata-verify/pull/1198. Thanks!


Provide migration tool from previous pcfg files to new class names

We changed the class names last week.  This (apparently) broke the hands-on config files.  If this broke existing config files created by users, we need to provide a migration tool to fix them.

We confirmed this was falsely reported right? Is it safe to close this now?

This was not a bug with the classes. The migration mostly forces re links. During the hands on the problem was in the files copied into the usb file. Not sure how the break line got removed between the version of the file and the actual data.


Display proper status message when downloading the source file in VS Code Plugin

(1) When clicked on "Generate code from umple" >> "SQL" to download as language, the status message is wrong when the download is complete. Right now it shows "example.ump". The message should show "example.sql".

(2) When clicked on "Generate code from umple" >> "Ruby" to download as language, the status message is wrong when the download is complete. Right now it shows "example.ump". The message should show "example.rb".

Expected:
The system should display the correct file name at the status bar.

This should not show example.sql ... that is the message that says the input was processed. It could say which files were output perhaps.


IndexError: blueprint 'sensor.other.lane_detector' not found

Hi,
I am trying to run older version of my scenario_runner with the latest Carla version 0.9.5 built from source (on Ubuntu 16.04.) and i get the following error:
The scenario cannot be loaded
...
...
IndexError: blueprint 'sensor.other.lane_detector' not found
blueprint 'sensor.other.lane_detector' not found
No more scenarios .... Exiting
how to fix this error?

That sensor was renamed to sensor.other.lane_invasion.


Output file names swapped on vocal models.

When using models MGM-v5-Vocal_2Band-32000-BETA1 and MGM-v5-Vocal_2Band-32000-BETA2 the outputted WAV file names are swapped, being the instruments labeled as vocals and vice-versa.

This is because your used models are vocal models and vocal models are not yet supported.
They will likely be officially supported in later versions.

I will reference the issue on a fix.

When using models MGM-v5-Vocal_2Band-32000-BETA1 and MGM-v5-Vocal_2Band-32000-BETA2 the outputted WAV file names are swapped, being the instruments labeled as vocals and vice-versa.

While the vocal models are fully operational, the name switch issue will be addressed in the final release.

Fixed. Use the -vm argument.


How to require boost package in header-only mode

Is your feature request related to a problem? Please describe.
We use boost in header-only mode.  The components needs to be built will never be used.
I've tried use  xmake require --info boost to list the info. And find only "filesystem" is default to true.
So, I use like this
add_requires("boost", {configs = {filesystem = false}})

Describe the solution you'd like
We can add boost without building.
Describe alternatives you've considered
No response
Additional context
No response

you can run this command "xrepo info boost",search "installdir" of boost package, cd include . can see your header-only file in include  directory


enhancement: bipartition support stats

Have verbose option also print the tip names relevant for the support value.

implemented in version 1.19.7


Make gist parameter optional in Owl_zoo_cmd.load_file

To address #221, this PR modifies the load_file function.  An example is shown in this gist. A user can use load_file ~gist f to specify a gist as before. When the ~gist option is not used:

if the script is executed locally in, e.g., utop, then load_file f will try to find file f in local directory;
if the script is already uploaded to Gist and run by using #zoo, then load_file f will try to find file f in ~/.owl/zoo/gid/vid. Users do not need to know the gist id of the script's own Gist.

@jzstark You may also want to sync with my master branch, I have fixed many broken things due to changing the sub library names.

Thanks a lot for helping to fix these library names! The code works fine on my machine.


HDDS-7315. SCM order of close of dbstore and other services

What changes were proposed in this pull request?
scmMetaStore to be close at last in sequence, as other service like metric may be using this to access tables.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-7315
How was this patch tested?
Running Unit test and integration test for the impact.

@ChenSammi @nandakumar131  Please review

LGTM + 1.


OracleDatabase setPassword.sh works only after first boot for 12.1

Hey everybody,
The setPassword.sh scripts fails for me after second run of a container.
Steps to reproduce:
docker run --name starterset \
-p 1521:1521 -p 5500:5500 \
-e ORACLE_PDB=STARTERSET \
-v /home/oracle/oradata:/opt/oracle/oradata \
oracle/database:<IP_ADDRESS>-ee

docker exec starterset ./setPassword.sh LetsDocker

docker rm starterset

docker run --name starterset \
-p 1521:1521 -p 5500:5500 \
-e ORACLE_PDB=STARTERSET \
-v /home/oracle/oradata:/opt/oracle/oradata \
oracle/database:<IP_ADDRESS>-ee

docker exec starterset ./setPassword.sh LetsDockerNotSoMuch

/etc/oratab doesn't contain any useful entry on second run, so
ORACLE_SID="`grep $ORACLE_HOME /etc/oratab | cut -d: -f1`"

in setPassword gives an empty SID and oraenv keeps asking for input.
Also, you should probably use . oraenv instead of source oraenv, as it is recommended in oraenv for bash.

I noticed that behavior while developing a workflow with the docker maven plugin.
The stop task removes the container by default.
https://dmp.fabric8.io/#docker:stop
If you / we go the extra mile to keep the database file outside of the container, I expect that the container can be deleted and then created and behave the same, for example like the postgres container does.

The runOracle.sh script now also copies and keeps the /etc/oratab file in the volume location fixing the above issue.
Note . and source are synonymous in bash, i.e they are exactly the same, just like [ and test are.
The reason for using source oraenv rather than . oraenv is because a . can quickly be overlooked, missed or removed while the source command is more obvious and transparent.
Thanks a lot for your contribution, happy Dockering. :)


Add a job to build the install stage of the AMI

Signed-off-by: Steve Kuznetsov<EMAIL_ADDRESS>

Test build running: https://ci.openshift.redhat.com/jenkins/job/ami_build_origin_int_rhel_install/1/console

Test build running: https://ci.openshift.redhat.com/jenkins/job/ami_build_origin_int_rhel_install/2/console

Success: https://ci.openshift.redhat.com/jenkins/job/ami_build_origin_int_rhel_install/6/


Unable to execute the ./dc-build.sh script

Problem description
I am trying to install defect dojo in my ubuntu system  as per https://github.com/DefectDojo/django-DefectDojo, but gettign an error as "Checking docker compose version
is not a supported docker-compose version, please upgrade to the minimum supported version: 2.0" while executing the ./dc-build.sh" script
Steps to reproduce
Steps to reproduce the behavior:

Go to https://github.com/DefectDojo/django-DefectDojo
git clone https://github.com/DefectDojo/django-DefectDojo
cd django-DefectDojo
./dc-build.sh
After executing the above script getting the below Error .
$ ./dc-build.sh
unknown flag: --short
See 'docker --help'.

Usage:  docker [OPTIONS] COMMAND
A self-sufficient runtime for containers
Common Commands:
run         Create and run a new container from an image
exec        Execute a command in a running container
ps          List containers
build       Build an image from a Dockerfile
pull        Download an image from a registry
push        Upload an image to a registry
images      List images
login       Log in to a registry
logout      Log out from a registry
search      Search Docker Hub for images
version     Show the Docker version information
info        Display system-wide information
Management Commands:
builder     Manage builds
buildx*     Docker Buildx (Docker Inc., 0.12.1)
container   Manage containers
context     Manage contexts
image       Manage images
manifest    Manage Docker image manifests and manifest lists
network     Manage networks
plugin      Manage plugins
system      Manage Docker
trust       Manage trust on Docker images
volume      Manage volumes
Swarm Commands:
swarm       Manage Swarm
Commands:
attach      Attach local standard input, output, and error streams to a running container
commit      Create a new image from a container's changes
cp          Copy files/folders between a container and the local filesystem
create      Create a new container
diff        Inspect changes to files or directories on a container's filesystem
events      Get real time events from the server
export      Export a container's filesystem as a tar archive
history     Show the history of an image
import      Import the contents from a tarball to create a filesystem image
inspect     Return low-level information on Docker objects
kill        Kill one or more running containers
load        Load an image from a tar archive or STDIN
logs        Fetch the logs of a container
pause       Pause all processes within one or more containers
port        List port mappings or a specific mapping for the container
rename      Rename a container
restart     Restart one or more containers
rm          Remove one or more containers
rmi         Remove one or more images
save        Save one or more images to a tar archive (streamed to STDOUT by default)
start       Start one or more stopped containers
stats       Display a live stream of container(s) resource usage statistics
stop        Stop one or more running containers
tag         Create a tag TARGET_IMAGE that refers to SOURCE_IMAGE
top         Display the running processes of a container
unpause     Unpause all processes within one or more containers
update      Update configuration of one or more containers
wait        Block until one or more containers stop, then print their exit codes
Global Options:
--config string      Location of client config files (default "/home/devsecops/.docker")
-c, --context string     Name of the context to use to connect to the daemon (overrides DOCKER_HOST env var and
default context set with "docker context use")
-D, --debug              Enable debug mode
-H, --host list          Daemon socket to connect to
-l, --log-level string   Set the logging level ("debug", "info", "warn", "error", "fatal") (default "info")
--tls                Use TLS; implied by --tlsverify
--tlscacert string   Trust certs signed only by this CA (default "/home/devsecops/.docker/ca.pem")
--tlscert string     Path to TLS certificate file (default "/home/devsecops/.docker/cert.pem")
--tlskey string      Path to TLS key file (default "/home/devsecops/.docker/key.pem")
--tlsverify          Use TLS and verify the remote
-v, --version            Print version information and quit
Run 'docker COMMAND --help' for more information on a command.
For more help on how to use Docker, head to https://docs.docker.com/go/guides/
unknown flag: --short
See 'docker --help'.
Usage:  docker [OPTIONS] COMMAND
A self-sufficient runtime for containers
Common Commands:
run         Create and run a new container from an image
exec        Execute a command in a running container
ps          List containers
build       Build an image from a Dockerfile
pull        Download an image from a registry
push        Upload an image to a registry
images      List images
login       Log in to a registry
logout      Log out from a registry
search      Search Docker Hub for images
version     Show the Docker version information
info        Display system-wide information
Management Commands:
builder     Manage builds
buildx*     Docker Buildx (Docker Inc., 0.12.1)
container   Manage containers
context     Manage contexts
image       Manage images
manifest    Manage Docker image manifests and manifest lists
network     Manage networks
plugin      Manage plugins
system      Manage Docker
trust       Manage trust on Docker images
volume      Manage volumes
Swarm Commands:
swarm       Manage Swarm
Commands:
attach      Attach local standard input, output, and error streams to a running container
commit      Create a new image from a container's changes
cp          Copy files/folders between a container and the local filesystem
create      Create a new container
diff        Inspect changes to files or directories on a container's filesystem
events      Get real time events from the server
export      Export a container's filesystem as a tar archive
history     Show the history of an image
import      Import the contents from a tarball to create a filesystem image
inspect     Return low-level information on Docker objects
kill        Kill one or more running containers
load        Load an image from a tar archive or STDIN
logs        Fetch the logs of a container
pause       Pause all processes within one or more containers
port        List port mappings or a specific mapping for the container
rename      Rename a container
restart     Restart one or more containers
rm          Remove one or more containers
rmi         Remove one or more images
save        Save one or more images to a tar archive (streamed to STDOUT by default)
start       Start one or more stopped containers
stats       Display a live stream of container(s) resource usage statistics
stop        Stop one or more running containers
tag         Create a tag TARGET_IMAGE that refers to SOURCE_IMAGE
top         Display the running processes of a container
unpause     Unpause all processes within one or more containers
update      Update configuration of one or more containers
wait        Block until one or more containers stop, then print their exit codes
Global Options:
--config string      Location of client config files (default "/home/devsecops/.docker")
-c, --context string     Name of the context to use to connect to the daemon (overrides DOCKER_HOST env var and
default context set with "docker context use")
-D, --debug              Enable debug mode
-H, --host list          Daemon socket to connect to
-l, --log-level string   Set the logging level ("debug", "info", "warn", "error", "fatal") (default "info")
--tls                Use TLS; implied by --tlsverify
--tlscacert string   Trust certs signed only by this CA (default "/home/devsecops/.docker/ca.pem")
--tlscert string     Path to TLS certificate file (default "/home/devsecops/.docker/cert.pem")
--tlskey string      Path to TLS key file (default "/home/devsecops/.docker/key.pem")
--tlsverify          Use TLS and verify the remote
-v, --version            Print version information and quit
Run 'docker COMMAND --help' for more information on a command.
For more help on how to use Docker, head to https://docs.docker.com/go/guides/
unknown flag: --short
See 'docker --help'.
Usage:  docker [OPTIONS] COMMAND
A self-sufficient runtime for containers
Common Commands:
run         Create and run a new container from an image
exec        Execute a command in a running container
ps          List containers
build       Build an image from a Dockerfile
pull        Download an image from a registry
push        Upload an image to a registry
images      List images
login       Log in to a registry
logout      Log out from a registry
search      Search Docker Hub for images
version     Show the Docker version information
info        Display system-wide information
Management Commands:
builder     Manage builds
buildx*     Docker Buildx (Docker Inc., 0.12.1)
container   Manage containers
context     Manage contexts
image       Manage images
manifest    Manage Docker image manifests and manifest lists
network     Manage networks
plugin      Manage plugins
system      Manage Docker
trust       Manage trust on Docker images
volume      Manage volumes
Swarm Commands:
swarm       Manage Swarm
Commands:
attach      Attach local standard input, output, and error streams to a running container
commit      Create a new image from a container's changes
cp          Copy files/folders between a container and the local filesystem
create      Create a new container
diff        Inspect changes to files or directories on a container's filesystem
events      Get real time events from the server
export      Export a container's filesystem as a tar archive
history     Show the history of an image
import      Import the contents from a tarball to create a filesystem image
inspect     Return low-level information on Docker objects
kill        Kill one or more running containers
load        Load an image from a tar archive or STDIN
logs        Fetch the logs of a container
pause       Pause all processes within one or more containers
port        List port mappings or a specific mapping for the container
rename      Rename a container
restart     Restart one or more containers
rm          Remove one or more containers
rmi         Remove one or more images
save        Save one or more images to a tar archive (streamed to STDOUT by default)
start       Start one or more stopped containers
stats       Display a live stream of container(s) resource usage statistics
stop        Stop one or more running containers
tag         Create a tag TARGET_IMAGE that refers to SOURCE_IMAGE
top         Display the running processes of a container
unpause     Unpause all processes within one or more containers
update      Update configuration of one or more containers
wait        Block until one or more containers stop, then print their exit codes
Global Options:
--config string      Location of client config files (default "/home/devsecops/.docker")
-c, --context string     Name of the context to use to connect to the daemon (overrides DOCKER_HOST env var and
default context set with "docker context use")
-D, --debug              Enable debug mode
-H, --host list          Daemon socket to connect to
-l, --log-level string   Set the logging level ("debug", "info", "warn", "error", "fatal") (default "info")
--tls                Use TLS; implied by --tlsverify
--tlscacert string   Trust certs signed only by this CA (default "/home/devsecops/.docker/ca.pem")
--tlscert string     Path to TLS certificate file (default "/home/devsecops/.docker/cert.pem")
--tlskey string      Path to TLS key file (default "/home/devsecops/.docker/key.pem")
--tlsverify          Use TLS and verify the remote
-v, --version            Print version information and quit
Run 'docker COMMAND --help' for more information on a command.
For more help on how to use Docker, head to https://docs.docker.com/go/guides/
Checking docker compose version
is not a supported docker-compose version, please upgrade to the minimum supported version: 2.0
$
Expected behavior
Images should be created without any error
Deployment method (select with an X)
$ docker-compose --version
Docker Compose version v2.29.6
$
Environment information

Operating System:
22.04 LTS Jammy Jellyfish
DefectDojo version
git show -s --format="[%ci] %h: %s [%d]"
[2024-09-16 13:53:48 -0500] e4fbfe0f2: Merge pull request #10919 from DefectDojo/release/2.38.2 [ (HEAD -> master, tag: 2.38.2, origin/master, origin/HEAD)]
$ docker version
Client:
Version:           24.0.7
API version:       1.43
Go version:        go1.21.1
Git commit:        24.0.7-0ubuntu2~22.04.1
Built:             Wed Mar 13 20:23:54 2024
OS/Arch:           linux/amd64
Context:           default

Server:
Engine:
Version:          24.0.7
API version:      1.43 (minimum version 1.12)
Go version:       go1.21.1
Git commit:       24.0.7-0ubuntu2~22.04.1
Built:            Wed Mar 13 20:23:54 2024
OS/Arch:          linux/amd64
Experimental:     false
containerd:
Version:          1.7.12
GitCommit:
runc:
Version:          1.1.12-0ubuntu2~22.04.1
GitCommit:
docker-init:
Version:          0.19.0
GitCommit:
$
Logs
$ ./dc-build.sh
unknown flag: --short
See 'docker --help'.
Usage:  docker [OPTIONS] COMMAND
A self-sufficient runtime for containers
Common Commands:
run         Create and run a new container from an image
exec        Execute a command in a running container
ps          List containers
build       Build an image from a Dockerfile
pull        Download an image from a registry
push        Upload an image to a registry
images      List images
login       Log in to a registry
logout      Log out from a registry
search      Search Docker Hub for images
version     Show the Docker version information
info        Display system-wide information
Management Commands:
builder     Manage builds
buildx*     Docker Buildx (Docker Inc., 0.12.1)
container   Manage containers
context     Manage contexts
image       Manage images
manifest    Manage Docker image manifests and manifest lists
network     Manage networks
plugin      Manage plugins
system      Manage Docker
trust       Manage trust on Docker images
volume      Manage volumes
Swarm Commands:
swarm       Manage Swarm
Commands:
attach      Attach local standard input, output, and error streams to a running container
commit      Create a new image from a container's changes
cp          Copy files/folders between a container and the local filesystem
create      Create a new container
diff        Inspect changes to files or directories on a container's filesystem
events      Get real time events from the server
export      Export a container's filesystem as a tar archive
history     Show the history of an image
import      Import the contents from a tarball to create a filesystem image
inspect     Return low-level information on Docker objects
kill        Kill one or more running containers
load        Load an image from a tar archive or STDIN
logs        Fetch the logs of a container
pause       Pause all processes within one or more containers
port        List port mappings or a specific mapping for the container
rename      Rename a container
restart     Restart one or more containers
rm          Remove one or more containers
rmi         Remove one or more images
save        Save one or more images to a tar archive (streamed to STDOUT by default)
start       Start one or more stopped containers
stats       Display a live stream of container(s) resource usage statistics
stop        Stop one or more running containers
tag         Create a tag TARGET_IMAGE that refers to SOURCE_IMAGE
top         Display the running processes of a container
unpause     Unpause all processes within one or more containers
update      Update configuration of one or more containers
wait        Block until one or more containers stop, then print their exit codes
Global Options:
--config string      Location of client config files (default "/home/devsecops/.docker")
-c, --context string     Name of the context to use to connect to the daemon (overrides DOCKER_HOST env var and
default context set with "docker context use")
-D, --debug              Enable debug mode
-H, --host list          Daemon socket to connect to
-l, --log-level string   Set the logging level ("debug", "info", "warn", "error", "fatal") (default "info")
--tls                Use TLS; implied by --tlsverify
--tlscacert string   Trust certs signed only by this CA (default "/home/devsecops/.docker/ca.pem")
--tlscert string     Path to TLS certificate file (default "/home/devsecops/.docker/cert.pem")
--tlskey string      Path to TLS key file (default "/home/devsecops/.docker/key.pem")
--tlsverify          Use TLS and verify the remote
-v, --version            Print version information and quit
Run 'docker COMMAND --help' for more information on a command.
For more help on how to use Docker, head to https://docs.docker.com/go/guides/
unknown flag: --short
See 'docker --help'.
Usage:  docker [OPTIONS] COMMAND
A self-sufficient runtime for containers
Common Commands:
run         Create and run a new container from an image
exec        Execute a command in a running container
ps          List containers
build       Build an image from a Dockerfile
pull        Download an image from a registry
push        Upload an image to a registry
images      List images
login       Log in to a registry
logout      Log out from a registry
search      Search Docker Hub for images
version     Show the Docker version information
info        Display system-wide information
Management Commands:
builder     Manage builds
buildx*     Docker Buildx (Docker Inc., 0.12.1)
container   Manage containers
context     Manage contexts
image       Manage images
manifest    Manage Docker image manifests and manifest lists
network     Manage networks
plugin      Manage plugins
system      Manage Docker
trust       Manage trust on Docker images
volume      Manage volumes
Swarm Commands:
swarm       Manage Swarm
Commands:
attach      Attach local standard input, output, and error streams to a running container
commit      Create a new image from a container's changes
cp          Copy files/folders between a container and the local filesystem
create      Create a new container
diff        Inspect changes to files or directories on a container's filesystem
events      Get real time events from the server
export      Export a container's filesystem as a tar archive
history     Show the history of an image
import      Import the contents from a tarball to create a filesystem image
inspect     Return low-level information on Docker objects
kill        Kill one or more running containers
load        Load an image from a tar archive or STDIN
logs        Fetch the logs of a container
pause       Pause all processes within one or more containers
port        List port mappings or a specific mapping for the container
rename      Rename a container
restart     Restart one or more containers
rm          Remove one or more containers
rmi         Remove one or more images
save        Save one or more images to a tar archive (streamed to STDOUT by default)
start       Start one or more stopped containers
stats       Display a live stream of container(s) resource usage statistics
stop        Stop one or more running containers
tag         Create a tag TARGET_IMAGE that refers to SOURCE_IMAGE
top         Display the running processes of a container
unpause     Unpause all processes within one or more containers
update      Update configuration of one or more containers
wait        Block until one or more containers stop, then print their exit codes
Global Options:
--config string      Location of client config files (default "/home/devsecops/.docker")
-c, --context string     Name of the context to use to connect to the daemon (overrides DOCKER_HOST env var and
default context set with "docker context use")
-D, --debug              Enable debug mode
-H, --host list          Daemon socket to connect to
-l, --log-level string   Set the logging level ("debug", "info", "warn", "error", "fatal") (default "info")
--tls                Use TLS; implied by --tlsverify
--tlscacert string   Trust certs signed only by this CA (default "/home/devsecops/.docker/ca.pem")
--tlscert string     Path to TLS certificate file (default "/home/devsecops/.docker/cert.pem")
--tlskey string      Path to TLS key file (default "/home/devsecops/.docker/key.pem")
--tlsverify          Use TLS and verify the remote
-v, --version            Print version information and quit
Run 'docker COMMAND --help' for more information on a command.
For more help on how to use Docker, head to https://docs.docker.com/go/guides/
unknown flag: --short
See 'docker --help'.
Usage:  docker [OPTIONS] COMMAND
A self-sufficient runtime for containers
Common Commands:
run         Create and run a new container from an image
exec        Execute a command in a running container
ps          List containers
build       Build an image from a Dockerfile
pull        Download an image from a registry
push        Upload an image to a registry
images      List images
login       Log in to a registry
logout      Log out from a registry
search      Search Docker Hub for images
version     Show the Docker version information
info        Display system-wide information
Management Commands:
builder     Manage builds
buildx*     Docker Buildx (Docker Inc., 0.12.1)
container   Manage containers
context     Manage contexts
image       Manage images
manifest    Manage Docker image manifests and manifest lists
network     Manage networks
plugin      Manage plugins
system      Manage Docker
trust       Manage trust on Docker images
volume      Manage volumes
Swarm Commands:
swarm       Manage Swarm
Commands:
attach      Attach local standard input, output, and error streams to a running container
commit      Create a new image from a container's changes
cp          Copy files/folders between a container and the local filesystem
create      Create a new container
diff        Inspect changes to files or directories on a container's filesystem
events      Get real time events from the server
export      Export a container's filesystem as a tar archive
history     Show the history of an image
import      Import the contents from a tarball to create a filesystem image
inspect     Return low-level information on Docker objects
kill        Kill one or more running containers
load        Load an image from a tar archive or STDIN
logs        Fetch the logs of a container
pause       Pause all processes within one or more containers
port        List port mappings or a specific mapping for the container
rename      Rename a container
restart     Restart one or more containers
rm          Remove one or more containers
rmi         Remove one or more images
save        Save one or more images to a tar archive (streamed to STDOUT by default)
start       Start one or more stopped containers
stats       Display a live stream of container(s) resource usage statistics
stop        Stop one or more running containers
tag         Create a tag TARGET_IMAGE that refers to SOURCE_IMAGE
top         Display the running processes of a container
unpause     Unpause all processes within one or more containers
update      Update configuration of one or more containers
wait        Block until one or more containers stop, then print their exit codes
Global Options:
--config string      Location of client config files (default "/home/devsecops/.docker")
-c, --context string     Name of the context to use to connect to the daemon (overrides DOCKER_HOST env var and
default context set with "docker context use")
-D, --debug              Enable debug mode
-H, --host list          Daemon socket to connect to
-l, --log-level string   Set the logging level ("debug", "info", "warn", "error", "fatal") (default "info")
--tls                Use TLS; implied by --tlsverify
--tlscacert string   Trust certs signed only by this CA (default "/home/devsecops/.docker/ca.pem")
--tlscert string     Path to TLS certificate file (default "/home/devsecops/.docker/cert.pem")
--tlskey string      Path to TLS key file (default "/home/devsecops/.docker/key.pem")
--tlsverify          Use TLS and verify the remote
-v, --version            Print version information and quit
Run 'docker COMMAND --help' for more information on a command.
For more help on how to use Docker, head to https://docs.docker.com/go/guides/
Checking docker compose version
is not a supported docker-compose version, please upgrade to the minimum supported version: 2.0
$ ^C
Sample scan files
If applicable, add sample scan files to help reproduce your problem.
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context (optional)
Add any other context about the problem here.

Having the same issue...

me too

Can you provide any more details?
I'm working on Linux and not experiencing these issues myself.
$ docker --version
Docker version 27.3.1, build ce12230
$ cat /etc/lsb-release
DISTRIB_ID=Pop
DISTRIB_RELEASE=22.04
DISTRIB_CODENAME=jammy
DISTRIB_DESCRIPTION="Pop!_OS 22.04 LTS"

The docker compose version check issues this command:
docker compose version
So without the dash which was used in the past before compose moved into docker itself (docker-compose --version)
For those with problems, what's the output of docker compose version ?
Other people added the '-' back in and got their builds working: https://owasp.slack.com/archives/C2P5BA8MN/p1726473326185659?thread_ts=1726473181.406109&cid=C2P5BA8MN


Better scale displayed file-size by using appropriate unit and support binary prefixes.

And a another suggestion for improvement:
Better scale displayed file-size by using appropriate unit (kB, MB, TB etc).
Also allow to use SI compliant binary prefixes (KiB, MiB, TiB etc) by setting config
parameter:
useBinarySizePrefixes: true

Example:

Hi @fkoester I pushed your pr and added the config param that is missing here.
Also I added this filter to anchor titles that still used sizeKb()

@joni2back Perfect!

Or let's say almost perfect ;-) You have overwritten the showSizeForDirectories change of the previous PR:
here is the patch:
diff --git a/src/templates/main-table.html b/src/templates/main-table.html
index 8369834..d4d121c 100644
--- a/src/templates/main-table.html
+++ b/src/templates/main-table.html
@@ -53,7 +53,9 @@

+
                 {{item.model.size | humanReadableFileSize }}
+

                 {{item.model.date | formatDate }}

done!


Question about middleware best practices with angular 1.x

Hi folks,
Thanks for this project!
I had a question around middleware, and what might be the best practices for doing such things as Promises, requests to server etc?
Is anyone creating their own middleware using this with angular 1.x (api, promise, etc...)? If so, have you run into any issues or difficulties? Are you using angular's provided utilities ($http, $q, etc.) or are you pulling in another third party lib for doing this stuff?
Any insight would be much appreciated!
Cheers
Mike

Hey Mike,
I'm using something similar to this, in combination with $http for API calls (beware when browsing the code of this repo, it's all deprectated).
You can find another interesting example here, by @e-schultz and @neilff , still using angular's utilities directly inside the middleware.
Works like a charm for me, have you encountered any problem?

Thanks @wbuchwalter , this looks exactly for the type of example I was looking for. I will study this code and let you know if I find any issues in my implementation. Thanks.

@wbuchwalter I'm glad I came across your note about tsRedux because it caused me to search around for available redux middleware :)
So I'm using available middleware for logging and handling promises, but I'm curious what else you consider deprecated about the tsRedux code base? If I'm learning a little from that what else would you not repeat if you worked on a typescript/redux project now?
Thanks again for publishing this code...it's been very helpful for me as I transition from many years of C#/.NET coding into modern javascript development.

Hey!
TsRedux is mostly correct, I said it was deprecated because it used an older version of ng-redux that is very different from the current one.
But this is mostly fixed since @cveld PR which refreshed all that.
There is probably some things that I would do slightly differently now but nothing is there is obviously bad.
Among things that you should think about before repeating them:

Mutations: This is the big one: there is a lot of mutations in the reducers, you should not do that, I did it because I wanted to test things quickly but don't do that. Use something like _.assign.
handleAction decorators: Some devs find the good old switch more explicit and less magic since TS decorators + metadata are quite obscure and not really well decorated for now
Related to the one above, if not using decorators, you can then write your reducers as basic function, no need for a class anymore
Actions are binded once and then injected as a service, you can do that, or you can pass the unbinded action to  connect in the controller where you want to use them instead. Choose the way you prefer

And last but not least, this example was mostly for my personal use, to check that redux would play nice with a use case I had, and this had to work with ~10k items, so I took some shortcut for perfomance reasons. Bottom line, if you feel like something I did is ugly and you could do it in a cleaner way, you are probably right.

@wbuchwalter I really appreciate the thoughts and advice. I think I'm going to simplify my code down to use more functions while I learn and add in the typescript classes and such as I feel comfortable. The note about mutations was a good one too, as while I get that a reducer should return a copy of the state with the needed modifications, I don't think I was handling that properly. I was just updating the state object provided to the reducer, and returning it.
Next on my list is to understand how ui-router fits in (via the redux library for it of course), but this is all starting to click so hopefully that's not too bad :)


Api

Coverage decreased (-0.3%) to 14.557% when pulling eb850ff438e05b603836d81222f120f703cb8161 on api into c8f9e196a08696179edcf55c9901811d4d893f8a on master.


make all build scripts run on windows

In particular, npm run deploy currently uses cp.

Fixed in 38f8e54.


Re-Architect  Domain management API

API for domain management needs to be simpler to use and more intuitive. Rely less on spring data rest and create traditional rest controllers with services so that functionalities can be implemented through aspects easily at different layers.

App Domain API does not need to be revamped since its an admin facing api and not a client facing api. Data can still be adequately accessed using spring data rest repositories. But all /appDomains api's will be protected by the admin token.


Can't run examples on Pi Pico

Hello!
I'm trying to run the examples on the Pi Pico W with a Raspberry debug probe.
I changed the runner to runner = "probe-rs run --chip=RP2040" configured example_secrets.rs
The code gets uploaded to the Pico correctly but I don't see any output and the Pico is not connected to wifi.
What am I missing?

The embassy examples host an Access Point, i.e. their own WiFi network, rather than connecting to an exist network.

Thanks!


Added samplesAsList option to runMCMC and nimbleMCMC

The title says it all.  Adds a new option samplesAsList to runMCMC and nimbleMCMC functions, with default value FALSE.  When samplesAsList = TRUE, the samples return object will be a named list, with named elements corresponding to variables being monitored.  Details:
The number of MCMC iterations will be the first dimension of each named element.  Thus, for 10 MCMC iterations, scalar variables are returned as a length-10 vector, length-3 vector variables are returned as a 10x3 arrays, and 3x4 array variables are returned as 10x3x4 arrays.  This matches the behaviour of jagsUI.
To achieve this, I made changes to the modelValues utility functions as.list.modelValuesBaseClass and as.list.CmodelValues, adding scalarize = TRUE to the dimOrLength call.  See the modified code.  I think this makes more sense, and my guess is that the missing-ness of this only reflects the total lack of usage of these as.list functions.  But perhaps I'm missing a part of the bigger picture here.
Also, I had to wonder, why the duplicate definitions of these functions?  Would it be simpler, and functionally identical, to say:
as.list.modelValuesBaseClass <- as.list.CmodelValues <- function(…) { ... }    ?

Our behaviour does not mimic that of jagsUI, in the case of multiple chains.
In the case of 3 chains, we will return samples as a list of length 3 (elements named "chain1", "chain2", and "chain3"), where the first element is a named list, with elements corresponding to the samples (of each variable) from chain 1, etc ....  In contrast, jagsUI will return a named list as before, with the samples from each chain concatenated.  This is a slight difference in functionality from jagsUI, which we could discuss.
This approach can be wasteful in terms of memory when samplesAsList = TRUE, since runMCMC will still collect samples both in the forms of an array, and also as a list (using this update).  This is because the array form of the samples is used internally for both the (optional) summary, and also the (optional) WAIC calculations, even if not returned to the user.  I'm ok with this, but flagging it for discussion.

I am worried about the memory use but given it's not the default maybe ok.
Would it be possible to create the list form only after doing WAIC and the summary and to first remove the matrix form before creating the list form so as to avoid the extra memory?
Note that once we update WAIC with Josh's work, we will note need the array form for that.

I like the idea of waiting to create the list until after WAIC, in the event WAIC is wanted but coda matrix format is not wanted.
I think we should support both list and coda returns. That's a hassle but the reason is that users may have different needs for different outputs and if they are using nimbleMCMC there is no easy way to get back in to request a different format.
The drafted new argument would change the API.  If a user has existing code with unnamed arguments, what used to be their summary argument will now be their samplesAsList argument.  Both are logicals so I'm not sure there is a good error-trap.  One alternative would be to add the new argument at the end, although that is somewhat inconsistent.  Another would be to convert the samplesAsCodaMCMC argument to a samplesFormat or Format argument with a set of options including TRUE/FALSE (which would provide backward compatibility) and text label options like "Coda" or "List".  If multiple options are provided, multiple formats can be returned.  To error-trap old uses, we can put a "samplesAsCodaMCMC" argument last, in case existing code uses it as a named argument, and handle it with a warning to update their code.  I'd prefer this approach.  It would become redundant with the "samples" argument (because with text labels, "none" could be an option), but keeping both would avoid breaking code, unless you can see a way to consolidate them and catch cases of existing uses.

@perrydv Fair questions about backwards-compatibility.  I'm ok with tabling this PR for now, and waiting until WAIC is finalized.  Then reaching some decisions about arguments and user interface.


Microsoft Azure AD Inventory Apps doc

Purpose of this pull request
This pull request is to create apps doc for Microsoft Azure AD Inventory.
Select the type of change

[ ] Minor Changes - Typos, formatting, slight revisions
[ ] Update Content - Revisions, updating sections
[x] New Content - New features, sections, pages, tutorials
[ ] Site and Tools - .clabot, version updates, maintenance, dependencies, new packages for the site (Docusaurus, Gatsby, React, etc.)

Ticket (if applicable)
Create public doc for Microsoft Azure AD Inventory

I'm publishing this PR at the request of @ankitgoelcmu.


Update mysql56.rb

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same formula update/change?
[x] Have you built your formula locally prior to submission with brew install <formula> (where <formula> is the name of the formula you're submitting)?
[ ] Does your submission pass brew audit --strict --online <formula> (after doing brew install <formula>)?
[ ] Does your submission adhere to Versions "Acceptable Formulae" guidelines?

Thanks for your contribution to Homebrew!  You rock!
For future reference the preferred commit message format for simple version updates is mysql56 5.6.32. Please complete the issue template in future PRs where this format is detailed in the linked Contributing guidelines. Thanks!


Azure details: Filter by many things

Filter by many things in details (not only the main dimension).
Users want the ability to filter on additional projects, clusters, nodes, and tag keys. Although, the table results do not show tags in its columns, this hack will provide the requested functionality.
Fixes https://github.com/project-koku/koku-ui/issues/1220
Mock: https://user-images.githubusercontent.com/17481322/69057929-a1cb4900-09e0-11ea-8ecd-8205e9c3c0f2.png
Demo:

Note: The following issues will need to be addressed server-side
project-koku/koku#1589
project-koku/koku#1596

Codecov Report

Merging #1229 into master will decrease coverage by 0.19%.
The diff coverage is 45.71%.

@@            Coverage Diff            @@
##           master    #1229     +/-   ##
=========================================
- Coverage   75.28%   75.08%   -0.2%
=========================================
  Files         231      231
  Lines        4519     4536     +17
  Branches      880      884      +4
=========================================
+ Hits         3402     3406      +4
- Misses        983      996     +13
  Partials      134      134

Impacted Files
Coverage Δ

src/api/azureReports.ts
82.35% <ø> (ø)
:arrow_up:

src/api/azureQuery.ts
40% <45.45%> (-8.58%)
:arrow_down:

src/utils/getComputedAzureReportItems.ts
87.23% <50%> (-1.66%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28381a2...d9a1a96. Read the comment docs.


Fix diff split view coloring being solid color for the whole row (#553)

This pull requests targets #553,
I've taken the suggestion from the issue with the difference that added or removed lines get a light grey on the other side, just like at github.
This pull request does:

Display lines that were added grey on the left side and green on the right side
Display lines that were modified red on the left and green on the right side
Display lines that were removed red on the left and grey on the right side

Screenshots for this UI change:
Behavior before
Behavior now

LGTM

LGTM

LGTM


Add Colegio de educacion profesional tecnica del estado de Guerrero

Signed-off-by: Enrique García<EMAIL_ADDRESS>We are adding our institution from the state of Guerrero, México

@quiquegarcia Please provide us with:

the school official website URL
the school street address, including city and country
an URL of a page on the official website where the school offers an IT-related long-term (>1 year) course
a proof, which shows that the school recognizes the domain you are submitting as an official email domain for the students.

Official website url: http://conalepgro.edu.mx/
Main address: Boulevard Vicente Guerrero S/N, Edificio Jacsa (1er. Nivel).
Colonia Villamoderna, C.P. 39070, Chilpancingo, Guerrero, México.

@quiquegarcia
Please provide us with a proof, which shows that the school recognizes the domain  conalep-guerrero.edu.mx, which you are submitting as an official email domain for the students.
You can provide us with any of the following:

A copy of instruction (a hard-copy or electronic one) given to you by the school that tells you to use an email address in this email domain
An URL of a page at the official school website that says that students use this email domain
A reference to a recognized journal where an article was published by someone from the school, with explicit affiliation to the school, and e-mail address from the email domain
A WHOIS data that link the email domain to the school somehow
A copy of official letter from the school representative saying that the school provides e-mail addresses in this domain to the students
Anything else that can prove this fact in similar way, i.e. can be verified independently.

@quiquegarcia You might miss my previous comment. Please react.

@quiquegarcia I am sorry, this request remains unanswered for a while. I have to close it without merging. Please reopen and comment if you have an update regarding the aforementioned issue. Thank you for your understanding!


ConditionGet always adds "must-revalidate" directive to Cache-Control header

Minify version: 2.x
PHP version: 5.x

What steps will reproduce the problem?
1. Using Minify with conditional GETs, setting a maxAge
2. Using the URI builder with groups to generate a single URI with a timestamp

Expected output:
Because we're using a timestamp, there is no need for an extra HTTP request
(albeit one that returns a 304) for minified resources, as the timestamp
will change when any of the resources change.

Actual output:
However with maxAge set, the Cache-Control header is sent in the
constructor of the ConditionalGet class, which is fine, but it is *always*
sent with the must-revalidate directive which forces the browser to always
send a request to check the etag and update headers to see if the file has
changed, returning a 304 if it hasn't.

Did any unit tests FAIL?
No.

Please provide any additional information below.

I think the best solution for this is an extra settings passed into the
constructor, like maxAge, that allows must-revalidate to be disabled, find
an example patch attached.

In high-load sites we've found getting rid of even this small extra request
per resource can make a difference.

Original issue reported on code.google.com by<EMAIL_ADDRESS>on 13 Jan 2009 at 4:49
Attachments:

ConditionalGet.php

When max-age is set (even with "must-revalidate"), the browser honors it: when
you
browse links, further requests for the file are not sent (unless you manually
refresh the page). I've just verified this behavior using Fiddler on Opera,
Firefox
3 and IE8b2.

Are you directly reloading the page (F5) and seeing 304s? Because there's
nothing we
can do about that AFAIK. Do you have a public URL?

Original comment by<EMAIL_ADDRESS>on 13 Jan 2009 at 11:30

Changed state: NeedInfo

Sorry didn't attach the patch.

Original comment by<EMAIL_ADDRESS>on 13 Jan 2009 at 4:50
Attachments:

ConditionalGet.php.patch

My apologies for a useless report. Having taken a look at the problem myself, it
seems the tech dept had Apache misconfigured so that a pragma directive was also
coming through on the live servers (but not on dev), having sorted this out you
are
indeed right about browsers respecting max-age.

Original comment by<EMAIL_ADDRESS>on 14 Jan 2009 at 10:15

No problem.

Original comment by<EMAIL_ADDRESS>on 14 Jan 2009 at 12:14

Changed state: Invalid


Host (Linux): devicetree path for OBP hosts

At least SPARC devices have their model name in this devicetree node and do not have a "model" node.  Possibly also POWER Macs, do not have one to test though.

Thanks


Unclear whether one has to do both or one. Maybe clarify it?

Describe the bug
It says "to ..., you must do the following" and then it lists 3 bullet points. But I am not sure if I do all of them, or if the first bullet point is an obsolete one. The first one is editing the manifest file, the second one is editing the app.config file, and the third one is calling a method.
But there is an "Important" box at the end of the second bullet that says "In previous versions of the .NET Framework, you used the manifest to add high DPI support. This approach is no longer recommended, since it overrides settings defined on the app.config file." What exactly is "you used the manifest file to add"? Is that the thing in the first bullet or something else?
That is, is it saying that I should not do the thing that is described in the first bullet any more? In such case, why is it still in the same-level of bullet points? Shouldn't it be like:

Do one of the following

Modify app.config
Modify manifest (deprecated) And the "Important" should be moved from "app.config" section to here.

Call the method

Or I should do all of the three bullet points and the thing that is mentioned in the "important" box is something I do not have to care about now? In such case, probably it is better to be more specific what that use of manifest was, so that readers would not think it is the first bullet point.
To Reproduce
Steps to reproduce the behavior:

Go to https://docs.microsoft.com/en-us/dotnet/framework/winforms/high-dpi-support-in-windows-forms
Scroll down to Configuring your Windows Forms app for high DPI support

Expected behavior
Clear, unambiguous, up-to date information for setting up high DPI support.

This issue was moved to dotnet/docs#19477


Vulnerability GHSA-q6cp-qfwq-4gcv in httpmock's dependency - h2

Summary
The dependency h2(0.3.24) has vulnerability issue, check details from https://github.com/advisories/GHSA-q6cp-qfwq-4gcv
Details
The dependency h2(0.3.24) has vulnerability issue, check details from https://github.com/advisories/GHSA-q6cp-qfwq-4gcv
Fixed in 0.4.4
The 'hyper' has new version. Need to update.
Dependency Tree
├─┬ httpmock 0.7.0 - Cargo
│ └─┬ hyper 0.14.28 - Cargo
│   └── h2 0.3.24 - Cargo

Thanks!

Should be fixed starting with v0.8.0-alpha.1