v3-rc0: ionic start with missing Cordova tells me to install cordova plugin - but not where, and doesn't tell me if anything else is missing

What version of the CLI are you using? Output of ionic --version
3.0.0-rc.0
Short description of the problem:
When I ionic start with missing Cordova the output tells me to install cordova plugin - but not where (which should be IN the newly created project directory)
PS C:\Users\Jan\Documents> ionic start
? What would you like to name your project: rc0test
? What starter would you like to use: blank
✔ Creating directory C:\Users\Jan\Documents\rc0test - done!
✔ Downloading blank starter template - done!
✔ Updating project dependencies to add required plugins - done!
✔ Creating configuration file for the new project - done!
Installing dependencies may take several minutes!
✔ running command: npm install - done!
✔ running command: npm install --save-dev --save-exact @ionic/cli-plugin-ionic-angular@beta - done!
✖ running command: npm install --save-dev --save-exact @ionic/cli-plugin-cordova@beta - failed!
[ERROR] An error occurred while running npm install --save-dev --save-exact @ionic/cli-plugin-cordova@beta (exit code 1):

        ><EMAIL_ADDRESS>postinstall C:\Users\Jan\Documents\rc0test\node_modules\@ionic\cli-plugin-cordova
        > node ./bin/postinstall

        ###########################################################################################
        >>>>>                                                                                <<<<<
        >>>>>                    Cordova CLI was not found on your PATH.                      <<<<<
        >>>>>                                                                                <<<<<
        >>>>>    This plugin needs Cordova intalled globally. Please try the following:       <<<<<
        >>>>>                                                                                <<<<<
        >>>>>                            npm install -g cordova                               <<<<<
        >>>>>                                                                                <<<<<
        >>>>>              If that doesn't work, see the installation docs:                   <<<<<
        >>>>> https://cordova.apache.org/docs/en/latest/guide/cli/#installing-the-cordova-cli <<<<<
        >>>>>                                                                                <<<<<
        >>>>>                               Sorry about that!                                 <<<<<
        >>>>>     When Cordova is installed, please try re-installing the plugin again:       <<<<<
        >>>>>                                                                                <<<<<
        >>>>>                 npm install --save-dev @ionic/cli-plugin-cordova                <<<<<
        >>>>>                                                                                <<<<<
        ###########################################################################################
        npm WARN optional SKIPPING OPTIONAL DEPENDENCY<EMAIL_ADDRESS>(node_modules\chokidar\node_modules\fsevents):
        npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for<EMAIL_ADDRESS>wanted {"os":"darwin","arch":"any"} (curren
t: {"os":"win32","arch":"x64"})
        npm ERR! Windows_NT 10.0.15063
        npm ERR! argv "C:\\Program Files\\nodejs\\node.exe" "C:\\Program Files\\nodejs\\node_modules\\npm\\bin\\npm-cli.js" "install" "--s
ave-dev" "--save-exact" "@ionic/cli-plugin-cordova@beta"
        npm ERR! node v6.10.2
        npm ERR! npm  v3.10.10
        npm ERR! code ELIFECYCLE

        npm ERR<EMAIL_ADDRESS>postinstall: `node ./bin/postinstall`
        npm ERR! Exit status 1
        npm ERR!
        npm ERR! Failed at the<EMAIL_ADDRESS>postinstall script 'node ./bin/postinstall'.
        npm ERR! Make sure you have the latest version of node.js and npm installed.
        npm ERR! If you do, this is most likely a problem with the @ionic/cli-plugin-cordova package,
        npm ERR! not with npm itself.
        npm ERR! Tell the author that this fails on your system:
        npm ERR!     node ./bin/postinstall
        npm ERR! You can get information on how to open an issue for this project with:
        npm ERR!     npm bugs @ionic/cli-plugin-cordova
        npm ERR! Or if that isn't available, you can get their info via:
        npm ERR!     npm owner ls @ionic/cli-plugin-cordova
        npm ERR! There is likely additional logging output above.

        npm ERR! Please include the following file with any support request:
        npm ERR!     C:\Users\Jan\Documents\rc0test\npm-debug.log

Also it is not clear if the project was started successfully anyway? Are any other steps missing?
What behavior are you expecting?

Tell me where to run the command
Tell me if ionic start was finished successfully

Post the output of ionic info below please
global packages:
@ionic/cli-utils : 1.0.0-rc.0
Ionic CLI        : 3.0.0-rc.0

System:
Node       : v6.10.2
OS         : Windows 10
Xcode      : not installed
ios-deploy : not installed
ios-sim    : not installed

It's going to be hard to catch this error. Maybe if we didn't pre-install the plugins...

With "catch" you mean not exiting the process?

I just mean handle it nicely.

I am having this problem. Has this issue been fixed?

ChenDamins-MacBook-Air:george chendamin$ sudo ionic info
[WARN] You are not in an Ionic project directory. Project context may be missing.
global packages:
@ionic/cli-utils : 1.0.0
Ionic CLI        : 3.0.0

System:
Node       : v6.10.3
OS         : macOS Sierra
Xcode      : not installed
ios-deploy : not installed
ios-sim    : not installed

ChenDamins-MacBook-Air:george chendamin$ sudo npm install -g typescript
/usr/local/bin/tsc -> /usr/local/lib/node_modules/typescript/bin/tsc
/usr/local/bin/tsserver -> /usr/local/lib/node_modules/typescript/bin/tsserver
/usr/local/lib
└──<EMAIL_ADDRESS>ChenDamins-MacBook-Air:george chendamin$ sudo ionic start myApp tabs
✔ Creating directory /Users/chendamin/Desktop/George/myApp - done!
Fetching app base (https://github.com/driftyco/ionic2-app-base/archive/master.tar.gz)
✔ Downloading - done!
Fetching starter template tabs (https://github.com/driftyco/ionic2-starter-tabs/archive/master.tar.gz)
✔ Downloading - done!
✔ Updating package.json with app details - done!
✔ Creating configuration file ionic.config.json - done!
Installing dependencies may take several minutes!

npm install
✔ Running command - done!
npm install --save-dev --save-exact @ionic/cli-plugin-ionic-angular@latest
✔ Running command - done!
npm install --save-dev --save-exact @ionic/cli-plugin-cordova@latest
✖ Running command - failed!
[ERROR] An error occurred while running npm install --save-dev --save-exact @ionic/cli-plugin-cordova@latest (exit code 1):

    ><EMAIL_ADDRESS>postinstall /Users/chendamin/Desktop/George/myApp/node_modules/@ionic/cli-plugin-cordova
    > node ./bin/postinstall

    ###########################################################################################
    >>>>>                                                                                <<<<<
    >>>>>                    Cordova CLI was not found on your PATH.                      <<<<<
    >>>>>                                                                                <<<<<
    >>>>>    This plugin needs Cordova installed globally. Please try the following:      <<<<<
    >>>>>                                                                                <<<<<
    >>>>>                            npm install -g cordova                               <<<<<
    >>>>>                                                                                <<<<<
    >>>>>              If that doesn't work, see the installation docs:                   <<<<<
    >>>>> https://cordova.apache.org/docs/en/latest/guide/cli/#installing-the-cordova-cli <<<<<
    >>>>>                                                                                <<<<<
    >>>>>                               Sorry about that!                                 <<<<<
    >>>>>     When Cordova is installed, please try re-installing the plugin again:       <<<<<
    >>>>>                                                                                <<<<<
    >>>>>                 npm install --save-dev @ionic/cli-plugin-cordova                <<<<<
    >>>>>                                                                                <<<<<
    ###########################################################################################
    npm ERR! Darwin 16.5.0
    npm ERR! argv "/usr/local/bin/node" "/usr/local/bin/npm" "install" "--save-dev" "--save-exact" "@ionic/cli-plugin-cordova@latest"
    npm ERR! node v6.10.3
    npm ERR! npm  v3.10.10
    npm ERR! code ELIFECYCLE

    npm ERR<EMAIL_ADDRESS>postinstall: `node ./bin/postinstall`
    npm ERR! Exit status 1
    npm ERR!
    npm ERR! Failed at the<EMAIL_ADDRESS>postinstall script 'node ./bin/postinstall'.
    npm ERR! Make sure you have the latest version of node.js and npm installed.
    npm ERR! If you do, this is most likely a problem with the @ionic/cli-plugin-cordova package,
    npm ERR! not with npm itself.
    npm ERR! Tell the author that this fails on your system:
    npm ERR!     node ./bin/postinstall
    npm ERR! You can get information on how to open an issue for this project with:
    npm ERR!     npm bugs @ionic/cli-plugin-cordova
    npm ERR! Or if that isn't available, you can get their info via:
    npm ERR!     npm owner ls @ionic/cli-plugin-cordova
    npm ERR! There is likely additional logging output above.

    npm ERR! Please include the following file with any support request:
    npm ERR!     /Users/chendamin/Desktop/George/myApp/npm-debug.log


[Android] App Crashes On Exit ( XMLHttpRequest related )

If a request is in processes and you exit the app, application will crash.
Sample Code:
import React from 'react';
import { View } from 'react-native';

class Thecomp extends React.Component {

  constructor(props) {
    super(props);

    this.xhr = null;
  }

  componentWillUnmount() {
    if (this.xhr != null) {
      this.xhr.abort();
      this.xhr = null;
    }
  }

  componentDidMount() {
    this.xhr = new XMLHttpRequest();

    var url = "http://SOMEWHERE/";

    this.xhr.open('GET', url);
    this.xhr.send();
  }

  render() {
    return (
      <View>
        App Crash
      </View>
    )
  }

}

module.exports = Thecomp;

But this one wont get crash if you exit app after 2 sec:
import React from 'react';
import { View } from 'react-native';

class Thecomp extends React.Component {

  constructor(props) {
    super(props);

    this.xhr = null;
  }

  componentWillUnmount() {
    if (this.xhr != null) {
      this.xhr.abort();
      this.xhr = null;
    }
  }

  componentDidMount() {
    this.xhr = new XMLHttpRequest();

    var url = "http://SOMEWHERE/";

    setTimeout( () => {
      this.xhr.abort();
    }, 2000 );

    this.xhr.open('GET', url);
    this.xhr.send();
  }

  render() {
    return (
      <View>
        App Crash
      </View>
    )
  }

}

module.exports = Thecomp;

I don't sure but maybe something related to APP Exit or componentWillUnmount.

To simulate the issue, you can use this URL ( this page response after 10 seconds ):
http://tasoft.ir/github/delay.php

Found a workaround:
Abort request on "hardwareBackPress" event using BackAndroid.

Hi there! This issue is being closed because it has been inactive for a while.
But don't worry, it will live on with ProductPains! Check out its new home: https://productpains.com/post/react-native/android-app-crashes-on-exit-xmlhttprequest-related-
Product Pains has been very useful in highlighting the top bugs and feature requests:
https://productpains.com/product/react-native?tab=top
Also, if this issue is a bug, please consider sending a pull request with a fix.

This message was created automatically by mail delivery software.
A message that you sent could not be delivered to one or more of its
recipients. This is a temporary error. The following address(es) deferred:
<EMAIL_ADDRESS>Domain thumbmunkeys.com has exceeded the max emails per hour (72/60 (120%)) allowed.  Message will be reattempted later
------- This is a copy of the message, including all the headers. ------
Received: from filter03.reliabledns.org ([<IP_ADDRESS>]:46756)
by en02-ams.stablehost.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
(Exim 4.87)
(envelope-from<EMAIL_ADDRESS>id 1bzswQ-0004Xd-56
for<EMAIL_ADDRESS>Thu, 27 Oct 2016 22:14:31 +0000
Received: from github-smtp2-ext7.iad.github.net ([<IP_ADDRESS>] helo=github-smtp2a-ext-cp1-prd.iad.github.net)
by filter03.reliabledns.org with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
(Exim 4.86)
(envelope-from<EMAIL_ADDRESS>id 1bzswP-000448-Fb
for<EMAIL_ADDRESS>Thu, 27 Oct 2016 15:14:30 -0700
Date: Thu, 27 Oct 2016 15:13:28 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com;
s=pf2014; t=1477606468;
bh=RTJZpid+kEdQ+8XtHHHT0Ga4FCzMGZwlQ59AUqCV1+I=;
h=From:Reply-To:To:In-Reply-To:References:Subject:List-ID:
List-Archive:List-Post:List-Unsubscribe:From;
b=1isOcUgD8fc8HZdykxyRFS2eL7QOvC82uxSygQ0n96PQfRG+yhWEx/QzKScGKNXos
xEguA7CtlUaROB6rZVWyZryNKsLD+YdTQlIFtfrXfa+S9Cad0Dwyk8pSKNquajou5k
adWXTq/nlKkOpxzI+aFDK9gBj+2+tTczRpHKgQrA=
From: Martin Konicek<EMAIL_ADDRESS>Reply-To: facebook/react-native<EMAIL_ADDRESS>To: facebook/react-native<EMAIL_ADDRESS>Message-ID<EMAIL_ADDRESS>In-Reply-To<EMAIL_ADDRESS>References<EMAIL_ADDRESS>Subject: Re: [facebook/react-native] [Android] App Crashes On Exit (
XMLHttpRequest related ) (#8433)
Mime-Version: 1.0
Content-Type: multipart/alternative;
boundary="--==_mimepart_58127c087460c_34683faa38c7f2a024818f";
charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: mkonicek
X-GitHub-Recipient: bunnyboy1
List-ID: facebook/react-native <react-native.facebook.github.com>
List-Archive: https://github.com/facebook/react-native
List-Post<EMAIL_ADDRESS>List-Unsubscribe<EMAIL_ADDRESS>https://github.com/notifications/unsubscribe/ARoNg151WHQpbGquvhNZGtuAejXeLNDPks5q4SIIgaJpZM4I-ae8
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address<EMAIL_ADDRESS>Received-SPF: pass (filter03.reliabledns.org: domain of github.com designates <IP_ADDRESS> as permitted sender) client-ip=<IP_ADDRESS><EMAIL_ADDRESS>helo=github-smtp2a-ext-cp1-prd.iad.github.net;
X-SPF-Result: filter03.reliabledns.org: domain of github.com designates <IP_ADDRESS> as permitted sender
Authentication-Results: filter03.reliabledns.org; dmarc=pass header.from=github.com
X-Filter-ID: s0sct1PQhAABKnZB5plbIamwIYzgudGL4tMY9zS3pea7KY6rzXjgC+rgKYUjsj8D0JuF70A4EJMc
Wn6O/bsgoWSYW6KbZfj8apx6ohl75uX35Caz8bqM3i8tzwcg+lnkZzoX7PhhDs80mBQKIGWwu/Ku
scxs0Lj66ws3lVlgoDJwJVSL6KLw+g28lkb31HyS94pE1Cssu3RLQ0/o4r6NbA8zp1yYIFRkRN8y
Bn+CxV3zTwFGzukYMVxB5LmELgY9gZ2H7GwAENUy40jGeE6ci5z3A1ed2ITkOuMtrwds5D7K3wOa
hktxrld16n2/ku5KJq/4FZbX1lzD9O+fyiIjB8wTNR/tjjZvmBdM/4lPZO2sASVdHfbtk3LlI8pB
wr4jGeKz8vlEl/GSEiCnxc6Ard0BaVp3jhK5GOBJIv+LCtD+V9//iYPXcUPDr8DL9oJhN0JkcMmQ
sV7j9toT40ga/GYzx2Zgyhf3OXiddZgacWc1/+H6OHgtV1bmxcq0CB3pmrFpDzdgJQc/rZDiOC7K
RpZxGk3X7U/CrpemaTYEqjTUmURjlDc0k2fuHA8w+LTop7+eg7tptOUU98CNo4IBbK0jiD6XqsJZ
tjQxlyCdsewOr32jdvPLa/TCfXr5TU2T209TOOJMB2SW4wvj3us5pA==
X-Report-Abuse-To<EMAIL_ADDRESS>Authentication-Results: reliabledns.org; spf=pass<EMAIL_ADDRESS>Authentication-Results: reliabledns.org; dkim=pass header.i=github.com
X-SpamExperts-Class: ham
X-SpamExperts-Evidence: dnswl/se-reputation (trusted ham)
X-Recommended-Action: accept
X-Spam-Status: No, score=1.1
X-Spam-Score: 11
X-Spam-Bar: +
X-Ham-Report: Spam detection software, running on the system "en02-ams.stablehost.com",
has NOT identified this incoming email as spam.  The original
message has been attached to this so you can view it or label
similar future email.  If you have any questions, see
root@localhost for details.
Content preview:  Closed #8433. -- You are receiving this because you are subscribed
to this thread. Reply to this email directly or view it on GitHub: https://github.com/facebook/react-native/issues/8433#event-839325556
[...]
Content analysis details:   (1.1 points, 5.0 required)
pts rule name              description

-0.0 RCVD_IN_DNSWL_NONE     RBL: Sender listed at http://www.dnswl.org/, no
trust
[<IP_ADDRESS> listed in list.dnswl.org]
1.5 SPF_SOFTFAIL           SPF: sender does not match SPF record (softfail)
1.6 HTML_IMAGE_ONLY_24     BODY: HTML: images with 2000-2400 bytes of words
-1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%
[score: 0.0007]
0.0 HTML_MESSAGE           BODY: HTML included in message
-0.1 DKIM_VALID             Message has at least one valid DKIM or DK signature
-0.1 DKIM_VALID_AU          Message has a valid DKIM or DK signature from author's
domain
0.1 DKIM_SIGNED            Message has a DKIM or DK signature, not necessarily valid
X-Spam-Flag: NO
----==_mimepart_58127c087460c_34683faa38c7f2a024818f
Content-Type: text/plain;
charset=UTF-8
Content-Transfer-Encoding: 7bit
Closed #8433.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/facebook/react-native/issues/8433#event-839325556
----==_mimepart_58127c087460c_34683faa38c7f2a024818f
Content-Type: text/html;
charset=UTF-8
Content-Transfer-Encoding: 7bit
Closed #8433.
—You are receiving this because you are subscribed to this thread.Reply to this email directly, view it on GitHub, or mute the thread.

----==_mimepart_58127c087460c_34683faa38c7f2a024818f--


The process describes adding a value, not a key.

@jasonsandys-microsoft : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off


TestRouteDiscoveryRouterWeightedWithGateway - v1

https://circleci.com/gh/istio/istio/31492

Looks similar to https://github.com/istio/istio/pull/3412

ic, the pr is also 8h old so maybe a dup of #3471


chore(CPlusPlus): array removing duplicates in place

What kind of change does this PR introduce? (check at least one)

[ ] Bugfix
[x] New algorithm
[ ] Optimization in previous algorithms
[ ] Code style update
[ ] Refactor
[ ] Documentation
[ ] Other, please describe:

Briefly describe the changes in this PR

Removing array duplicates without using any extra space in C++
https://leetcode.com/problems/remove-duplicates-from-sorted-array/
Other information:

Hi @ShambhaviSharma0110,
Any update?

You have to push on the main of your repo

Hi @ShambhaviSharma0110,
It has not been updated before June 1, it will be closed

🚧 Closing this issue due to long inactivity.
is someone want to work on this then feel free to either open a new issue or PR regarding the same.


temporary gomod2nix compatability with go 1.23

Temporary fix for gomod2nix with go 1.23 until upstream patch is finished: https://github.com/nix-community/gomod2nix/pull/168

whoops wrong place


[ENHANCEMENT]

Outline of feature request

404 page & its redirect to homepage
Redirect Unauth - Check if user is login 1st or not if not then redirect to /login
Instead of TMDb api if we make poster inside the same folder of content then to fetch it for use
Notification / Announcement Page

Reason

if you try to request with/out sign in to your website

example.com/xyz

it will show blank screen. so therefore we need 404 page.

if any you try to open any url of your content without signing in auth= true condition then it will ultimately buffer.

example.com/view/1c6rnJgFFncbCM5TPPwMing4AmbEsHxfO

so therefore we need to check at request if it is signed or nor if not then to redirect to /login page.

its simple just add image of poster in folder as the respective name of content eg. binod.png for Binod movie
[i thinks this will make complicated so we can skip this one lol!]

A custom page for users to get to know what new has been added to website / Notification - for upcoming content.

I'll split my comment into sections based on the ideas:
404 page: great idea, should be really easy to do
Redirect unauthed: also a good idea, I actually thought I fixed it, but I realize there's some holes in the logic I used, but I should be able to fix it
Local posters: this is similar to another idea from issue #10 , for the same reason, I'll decline
Notification/announcements: I think it's a great idea, but it could be annoying for some users to see notifications, also I'd need to setup an RSS feed and maintain it

I'll split my comment into sections based on the ideas:
404 page: great idea, should be really easy to do
Redirect unauthed: also a good idea, I actually thought I fixed it, but I realize there's some holes in the logic I used, but I should be able to fix it
Local posters: this is similar to another idea from issue #10 , for the same reason, I'll decline
Notification/announcements: I think it's a great idea, but it could be annoying for some users to see notifications, also I'd need to setup an RSS feed and maintain it

I'll split my comment into sections based on the ideas:
404 page: great idea, should be really easy to do
Redirect unauthed: also a good idea, I actually thought I fixed it, but I realize there's some holes in the logic I used, but I should be able to fix it
Local posters: this is similar to another idea from issue #10 , for the same reason, I'll decline
Notification/announcements: I think it's a great idea, but it could be annoying for some users to see notifications, also I'd need to setup an RSS feed and maintain it

okay then wait.......

The 404 page and auth check have been implemented
https://github.com/libDrive/web/commit/f47163a95d1ed21d3125fcfcaa5c98343a385f28
https://github.com/libDrive/web/commit/28ed1355d57040f31ee49a76b08ec94720e18a0a
Expect it in the next update.

Screenshot of the 404 page

Screenshot of the 404 page

Nice!!!

I made a simple announcement page which just displays the 3 latest releases using the GitHub API

commit: https://github.com/libDrive/web/commit/789a09c07fcac74f8a47b68063d8e5f375abccd7

I'll close the issue now.


VM not accessible from other VM

I'm trying to run two VMs on DIND cluster:

VM with MySQL server
VM with NodeJS application that uses MySQL as a storage

I'm having hard time connecting the two. Is this supposed to be working?
Debugging
Cirros VM
In cirros I can see that DNS resolves correctly:
$ nslookup medo-db-service.default.svc.cluster.local
Server:    <IP_ADDRESS>
Address 1: <IP_ADDRESS> kube-dns.kube-system.svc.cluster.local

Name:      medo-db-service.default.svc.cluster.local
Address 1: <IP_ADDRESS> medo-db-service.default.svc.cluster.local

But then I'm unable to reach <IP_ADDRESS> (the MySQL VM) for some reason:
$ curl <IP_ADDRESS>:8000/dashboard/
curl: (7) couldn't connect to host

$ curl medo-db-service.default.svc.cluster.local:8000/dashboard/
curl: (7) couldn't connect to host

Ubutnu Container
Everything works in Ubuntu Container:
$ nslookup medo-db-service.default.svc.cluster.local
Server:		<IP_ADDRESS>
Address:	<IP_ADDRESS>#53

Name:	medo-db-service.default.svc.cluster.local
Address: <IP_ADDRESS>

$ curl <IP_ADDRESS>:8000/dashboard/
<!DOCTYPE html>
<html lang="en">
<head>
...

$ curl medo-db-service.default.svc.cluster.local:8000/dashboard/
<!DOCTYPE html>
<html lang="en">
<head>
...

Host machine
I can access MySQL VM from my host machine as well if I use pod IP.
$ kubectl describe service medo-db-service
Name:			medo-db-service
Namespace:		default
Labels:			<none>
Selector:		case=label-medo-db
Type:			ClusterIP
IP:			<IP_ADDRESS>
Port:			tcp-3306	3306/TCP
Endpoints:		<IP_ADDRESS>:3306
Port:			tcp-8000	8000/TCP
Endpoints:		<IP_ADDRESS>:8000
Session Affinity:	None
No events.

$ curl <IP_ADDRESS>:8000/dashboard/
<!DOCTYPE html>
<html lang="en">
<head>

Should you have any hint what settign am I missing, please let me know!

Can you provide urls to VM images which you are using for both roles?

I'm using OSv unikernels* (built with capstan tool) so giving you disk images will not help you much, but anyways:
http://x.k00.fr/virtlet
I also put the two of my kubernetes yamls there.
* I did try to use Ubutnu 16.04 Server image instead of unikernels, but couldn't run them on kubernetes. No error, just unable to see logs nor ssh.

This problem is easily reproducible using two cirros images: you cannot ssh from one to another. But you can ssh from docker container to cirros either directly either thru service.
In other words, if you deploy these two cirros VMs to the cluster:
cirros-vm.yaml
apiVersion: v1
kind: Pod
metadata:
  name: cirros-vm
  annotations:
    kubernetes.io/target-runtime: virtlet
    scheduler.alpha.kubernetes.io/affinity: >
      {
        "nodeAffinity": {
          "requiredDuringSchedulingIgnoredDuringExecution": {
            "nodeSelectorTerms": [
              {
                "matchExpressions": [
                  {
                    "key": "extraRuntime",
                    "operator": "In",
                    "values": ["virtlet"]
                  }
                ]
              }
            ]
          }
        }
      }
spec:
  containers:
    - name: cirros-vm
      image: virtlet/image-service.kube-system/cirros

cirros-vm2.yaml
apiVersion: extensions/v1beta1
kind: Deployment
metadata:
  name: cirros2-deployment
  namespace: default
spec:
  replicas: 1
  template:
    metadata:
      name: cirros2-pod
      labels:
        case: label-cirros2
      annotations:
        kubernetes.io/target-runtime: virtlet
        scheduler.alpha.kubernetes.io/affinity: >
          {
            "nodeAffinity": {
              "requiredDuringSchedulingIgnoredDuringExecution": {
                "nodeSelectorTerms": [
                  {
                    "matchExpressions": [
                      {
                        "key": "extraRuntime",
                        "operator": "In",
                        "values": ["virtlet"]
                      }
                    ]
                  }
                ]
              }
            }
          }
    spec:
      containers:
        - name: cirros2
          image: virtlet/image-service.kube-system/cirros
          ports:
          - name: ssh
            containerPort: 22
---
apiVersion: v1
kind: Service
metadata:
  name: cirros2-service
  namespace: default
spec:
  type: ClusterIP
  selector:
    case: label-cirros2
  ports:
  - name: tcp-22
    protocol: TCP
    port: 22
    targetPort: ssh

Then you cannot ssh from one to another:
$ kubectl exec -it virtlet-9l1fz -n kube-system -- /bin/bash -c "virsh list"
 Id    Name                           State
----------------------------------------------------
 1     aa65799e-59f4-4cd6-6943-672f1b02c5fa-cirros-vm running
 11    cefc0eda-f400-4c45-5599-7abdb748e122-miha-ubuntu-server running
 14    59e8d605-677d-4725-73a6-b8ff19a42f48-cirros2 running

$ kubectl exec -it virtlet-9l1fz -n kube-system -- /bin/bash -c "virsh console 1"
$ ssh<EMAIL_ADDRESS>ssh: Exited: Error connecting: No route to host
$ ssh<EMAIL_ADDRESS>ssh: Exited: Error connecting: Connection timed out

The very same commands work normally from within container:
$ kubectl run ubuntu-cont --image=ubuntu:16.04 -i --tty
/# ssh<EMAIL_ADDRESS>The authenticity of host '<IP_ADDRESS> (<IP_ADDRESS>)' can't be established.
RSA key fingerprint is SHA256:dNMNiGFj0tZBqoD1PotcN8kFlKbFNgxRL33+QJgQX8k.
Are you sure you want to continue connecting (yes/no)?

/# ssh<EMAIL_ADDRESS>The authenticity of host 'cirros2-service.default.svc.cluster.local (<IP_ADDRESS>)' can't be established.
RSA key fingerprint is SHA256:dNMNiGFj0tZBqoD1PotcN8kFlKbFNgxRL33+QJgQX8k.
Are you sure you want to continue connecting (yes/no)?

@jellonek can you please confirm that this is a bug in virtlet networking and not in my environment? Btw, I really like what you guys at Mirantis do 👍  and would very much like to see this problem solved. My little goal is to get a set of unikernels running on Kubernetes and communicating one with each other. Perhaps, should you have any extra time, could we have a video call on this topic?
/cc @gberginc

It was an RNG problem :) The fix will be merged shortly.


Update react-popper.d.ts

The current type doesn't show that the popper object may be undefined during the first render.
const { styles, attributes } = usePopper(...

console.log(attributes.popper);

when rendering the object is first undefined then during a second render it's populated:

This type update would reflect that fact in TS

That was fast 🏎. Thanks for maintaining this library, just started using it this morning and it's great!


Multi-get performance concerns [JIRA: CLIENTS-662]

This is to do work benchmarking multi-get to ensure that it performs better than serial gets.

Test using regular KV objects
Test using CRDT objects

Paging @wesc :smile:

The Python client includes benchmarking code for multiget. I have run this benchmark on my VM using the following scenarios:

1 cpu, 1 thread
4 cpus, 4 threads
1 cpu, 4 threads

In the 4 cpu / 4 thread case, multiget took half the time of sequential get.
@wesc could you please clone this repository and run the benchmark? Here's how I did it:
git clone git://github.com/basho/riak-python-client.git
cd riak-python-client
PYTHONPATH='.' python riak/client/multiget.py

The benchmark will connect to Riak running on localhost, using PB port 8087 and HTTP port 8098. If you want to run the benchmark from another computer or connect to multiple nodes, you can modify this line to use the same connection settings that your application uses.

In the 4 cpu / 4 thread case, multiget took half the time of sequential get.

First of all, cpython has GIL, adding cpu cores solves nothing in python world :) (as long as you don't release GIL in C extension).
Having parallel get is certainly faster than sequential get. You can also easily test it with gevent (remember to patch), and you will see that with pb it's waaaaaaaay faster than fetching everything in linear way.
Obviously as long as you don't run too much in parallel then riak and OS starts to choke.

Hi @pigmej -
I tried monkey-patching the python client with gevent to see if it made a difference in the benchmarks in riak/client/multiget.py and found that it did not. If you have observed something different please provide information, I would appreciate it.
As I observed earlier today, the only case where multi get was faster than sequential is when my VM had multiple CPUs.

I'll run the benchmark soon, but first a couple comments.
Python releases the GIL when making networking calls via the built in socket module. So you should see an improvement in a network-bound environment with 1 CPU and multiple threads. I'm inferring from your last comment that this is not the case? So that's odd, unless the benchmark is pegging the CPU.
Also, using 4 CPUs for a 2x gain seems... problematic? This means we'd get better overall throughput with one process per CPU, each making sequential gets. It doesn't smell right to me that multiget overhead might eat away half the performance.
gevent uses up a significant amount of CPU compared to regular Python networking, but that only starts to show at extreme network load. Unfortunately I don't have a citation for this and I don't think it's well known. We discovered it while working on services that make networking calls on the order of 10k - 20k round trips per second, where a monkey patched benchmark on a single core started underperforming the same un-monkeyed application.

I'll be interested to see what your benchmark runs show, and if you have comments about the benchmarking code itself.

Using gevent monkey patching significantly speeds up multi get and multi put. That will be the recommended fix until the client can be refactored.
See #446

Fixed, or closed via GitHub issues.
[posted via JIRA by Alexander Moore]


Serving on local or deploying not executing

Salaam,
When i am trying to serve the build using the command: bundle exec middleman or bundle exec middleman deploy, i get the following error:
C:/Ruby26-x64/lib/ruby/gems/2.6.0/gems/net-ssh-2.9.2/lib/net/ssh/authentication/pageant.rb:1:in `require': cannot load such file -- dl/import (LoadError)
please help
shukran

Salaam,
Thank you for your interest in my project. It looks like you're attempting to run Middleman on Windows? If so, please can you confirm that you've followed the Windows installation instructions (here) on Middleman's website?
In addition, it seems that you might be using Ruby 2.6? This project requires Ruby 2.7.8. Please try again using this version of Ruby.
Let me know how it goes.
Shukran wa salaam.


I got banned cause xray, but dont have xray

Hi,
I got banned because of the use of xray, while i was flying (fly was activated) through a Savana to find Nidoran's.
I added the mod JEI to the modpack and did a texturepack to change some textures of the pokemon but I did not used xray.
You can check my inventory and my chests, but there is nothing I could've even xrayed.
My IGN is Richie_Richer
On Discord it's: Richie #8199

You realize we can see every mod you log into the server with, right? It explicitly states every time you log in that you have "xray 2.0.0".

Yes I know you can see this, but I didn't use Xray at any point.

And we can prove that how? You logged onto our server with xray and were banned for it. Whether you used it or not, we don't care.

Well I understand that.
And I must admit I had the mod installed, but I didn't know it anymore.
I removed the mod immediately. It was not my plan to xray or cheat on this server.
I'm playing on Terra for one year now with my friends and really don't want to lose it, because there was a mod installed I allready forgot about.
And about the prove, you can certainly not prove if I used it or not, but I can show you all of my items I got, there is nothing from X-Raying.
And I can repeat my statement, that I did not use the mod at any point on the Server.


NadekoBot Stops Working After 5 Seconds

I wanted to run NadekoBot on my system but this is what I get when launching the .exe with administrator permissions.
I am running Windows 10, 64 bit. NadekoBot version is v1.10.2. Please help me. I have read the help files etc, but still won't work.
14:41:36 NadekoBot | Starting NadekoBot v1.10.2
14:41:36 NadekoBot | Shard 0 logging in ...
14:41:38 NadekoBot | Shard 0 logged in.
14:41:38 NadekoBot | Shard 0 loading services...
Unhandled Exception: StackExchange.Redis.RedisConnectionException: It was not possible to connect to the redis server(s); to create a disconnected multiplexer, disable AbortOnConnectFail. SocketFailure on PING
at StackExchange.Redis.ConnectionMultiplexer.ConnectImpl(Func`1 multiplexerFactory, TextWriter log) in c:\code\StackExchange.Redis\StackExchange.Redis\StackExchange\Redis\ConnectionMultiplexer.cs:line 890
at NadekoBot.Services.Impl.RedisCache..ctor(UInt64 botId)
at NadekoBot.NadekoBot.AddServices()
at NadekoBot.NadekoBot.d__43.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at NadekoBot.NadekoBot.d__45.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at NadekoBot.Program.Main(String[] args)

You need to install Redis via your Nadeko Updater, it's a small button which can be found on the bottom-left side of the app. If it still won't work then try to restart your bot and see if that helped.


Update web-sites-dotnet-rest-service-aspnet-api-sql-database.md

freshness

Hi @Rick-Anderson, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

It looks like you're working at Microsoft (riande). If you're full-time, we DON'T require a contribution license agreement.

If you are a vendor, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

Rick, this PR has conflicts now. If you still need it, can you address the conflicts; otherwise please close.


Improve exceptions logging

Problem
We can't see the cause of the exception that being thrown.
Solution
Use logger for output exceptions' causes.

Done in the common part https://github.com/exasol/virtual-schema-common-java/pull/110


Update mod.

Please update for new COFH and ThermalFoundation.

Your mod is asking for an older version. But they are updated today, and your mod asks for the older version.

or can you remove the max version of dependencies?

This is a repeat. It is impossible to write the code so that it does not happen again? https://github.com/Knugel/Whoosh/issues/15

Fixed this, the new version is going up on Curseforge now.


Revert "Replace deprecated mongodb chart with bitnami/mongodb"

Reverts NikhilM98/sugarizer-chart#7

Sorry for the revert. Merged the code in wrong branch.


Node compatibility – publish to npm?

Set module format to UMD.
Create a package.json.
Publish to NPM.
Write a Tape test suite for #1.

PasteSafe relies on the Web Crypto API, which is a browser API.
The only option would be to use a node port of the API.
Nah.


Added Telegram support

Short Description:
Telegram Support
Fixes/Resolves/Closes (please use correct syntax):
Closes #4353

This would be funny.

@askovpen Only one bot can login one api key?

@solderzzc yes. you can create unlimited bots https://core.telegram.org/bots#3-how-do-i-create-a-bot

Is that possible to split the api into auth.conf ? We now have -af auth.conf to easy the configuration copy job after changes. But I tried to setup another task list in the auth.conf, it's not working.

yes

This is awesome! Thank you @askovpen !


[Bug] FirebaseAnalytics.SetConsent

[REQUIRED] Please fill in the following fields:

Unity editor version: _____2020.3.38f
Firebase Unity SDK version: _____11.7
Source you installed the SDK: _____ (.unitypackage or Unity Package Manager)
Problematic Firebase Component: _____ (Auth, Database, etc.)
Other Firebase Components in use: _____ (Auth, Database, etc.)
Additional SDKs you are using: _____ AdMax(11.11.4),Admob(8.5.2),FirebaseAnalytics(11.7),FirebaseCrashlytics(11.7),FirebaseRemoteConfig(11.7)
Platform you are using the Unity editor on: _____ Mac
Platform you are targeting: _____ iOS
Scripting Runtime: _____  IL2CPP
Pre-built SDK from the website or open-source from this repo: _____

[REQUIRED] Please describe the issue here:

I add Arguments according to the document to add debug console view events - FIRAnalyticsVerboseLoggingEnabled, but can't see any Log, must add extra - FIRAnalyticsDebugEnabled, Log:ad_storage is granted. analytics_storage is granted. ad_user_data is granted. ad_personalization is granted.
Then I call Firebase. Analytics. FirebaseAnalytics. SetConsent (dicConsent); After that, the AD_storage-related log, instead, Analytics data has been reset and Resetting App Measurement data
Even if I call the native method [FIRAnalytics setConsent:consent]; remain get the log:Analytics data has been reset and Resetting App Measurement data

I find the problem,if i call the unity-firebase remote config, the the log will disapper

Hi @yangjiechao,
Apologies for the late revert. Could you provide a minimal, reproducible example of your implementation along with the steps you've taken to replicate the issue? Could you also clarify what you mean when you said that your Analytics data has been reset?

Hi @yangjiechao,
Apologies for the late revert. Could you provide a minimal, reproducible example of your implementation along with the steps you've taken to replicate the issue? Could you also clarify what you mean when you said that your Analytics data has been reset?

Although you cannot see the log messages about ad_storage is granted. after calling firebase remote.FetchData or analytics.SetConsent of unity firebase sdk, it still works normally and I will close the issue.


Apple-Clone

Describe the project you want to add with tech stack

Apple-Clone with  html, Css
Assign this issue to me under GSSOC'23

@MohitGupta121 please assign this issue

@tanishkagupta27 this issue is already assigned to @shraddha761 so please pick other one.


MiniEngine: Simple shader

I am having an issue using miniengine with this kind of simple shader(s)
//RS
#if USE_VERTEX_BUFFER
#define Simple_ShaderRS_RootSig
"RootFlags(ALLOW_INPUT_ASSEMBLER_INPUT_LAYOUT)"
#elif USE_ROOT_BUFFER_SRV
#define Simple_ShaderRS_RootSig
"RootFlags(0)"
#else
#define Simple_ShaderRS_RootSig
"RootFlags(0)"
#endif
//VS
struct PSInput
{
float4 position : SV_POSITION;
float4 color : COLOR;
};
//[RootSignature(Simple_ShaderRS_RootSig)]
PSInput main(PSInput input)
{
PSInput result;
result.position = input.position;
result.color = input.color;

return result;

}
I will help full if you give a hint how to use simple shader like in miniengine without loading a model via mode object.
Thanks

Can you elaborate a bit more on what your issue is?  What errors are you seeing?

the error is generic like this:
Exception thrown at 0x00007FFA12017788 in SimpleViewer.exe: Microsoft C++ exception: _com_error at memory location 0x000000E40890D430.
If there is a handler for this exception, the program may be safely continued.
this is my code try to fill root and PSO:
m_RootSig.Reset(0, 0);
m_RootSig.Finalize(L"SimpleViewer", D3D12_ROOT_SIGNATURE_FLAG_NONE);
/*ComPtr<ID3DBlob>  g_pSimple_ShaderVS;
D3DCompileFromFile(L"Shader//Simple_ShaderVS.hlsl", nullptr, nullptr, "VSMain", "vs_5_0",0, 0, &g_pSimple_ShaderVS, nullptr);

*/
DXGI_FORMAT ColorFormat = g_SceneColorBuffer.GetFormat();
DXGI_FORMAT DepthFormat = g_SceneDepthBuffer.GetFormat();

D3D12_INPUT_ELEMENT_DESC vertElem[] =
{
	{ "POSITION", 0, DXGI_FORMAT_R32G32B32_FLOAT, 0,0, D3D12_INPUT_CLASSIFICATION_PER_VERTEX_DATA, 0 },
	{ "COLOR", 0, DXGI_FORMAT_R32G32B32_FLOAT, 0, 12, D3D12_INPUT_CLASSIFICATION_PER_VERTEX_DATA, 0 }
};

m_ModelPSO.SetRootSignature(m_RootSig);
m_ModelPSO.SetRasterizerState(RasterizerDefault);
m_ModelPSO.SetInputLayout(_countof(vertElem), vertElem);
m_ModelPSO.SetPrimitiveTopologyType(D3D12_PRIMITIVE_TOPOLOGY_TYPE_TRIANGLE);
m_ModelPSO.SetDepthStencilState(DepthStateDisabled);
m_ModelPSO.SetVertexShader(g_pSimple_ShaderVS, sizeof(g_pSimple_ShaderVS));
m_ModelPSO.SetPixelShader(g_pSimple_ShaderPS, sizeof(g_pSimple_ShaderPS));

m_ModelPSO.SetBlendState(BlendNoColorWrite);
m_ModelPSO.SetDepthStencilState(DepthStateDisabled);
m_ModelPSO.SetRenderTargetFormats(1, &ColorFormat, DepthFormat);

m_ModelPSO.Finalize();
after I call finalize is failing at assert call withing pipelinestate object:
if (firstCompile)
{
ASSERT_SUCCEEDED( g_Device->CreateGraphicsPipelineState(&m_PSODesc, MY_IID_PPV_ARGS(&m_PSO)) );
s_GraphicsPSOHashMap[HashCode].Attach(m_PSO);
}
Sorry my ignorance I am by an expert but I am learning ...
Thanks

I closed by mistake

ASSERT_SUCCEEDED will print some info into the debug Output window and break into the debugger.  I would expect the SDK Layers to also print some information there as well.  Can you take a look and let me know what you see there?  (Make sure you are running the "Debug" configuration, not "Release" or "Profile")

this is what debug output is showing..   aaha ..!
D3D12 ERROR: ID3D12Device::CreateInputLayout: The provided input signature expects to read an element with SemanticName/Index: 'SV_POSITION'/0, but the declaration doesn't provide a matching name. [ STATE_CREATION ERROR #65: CREATEINPUTLAYOUT_MISSINGELEMENT]
D3D12 ERROR: ID3D12Device::CreateGraphicsPipelineState: Graphics pipeline state object uses input-assembler, but the root signature does not have the D3D12_ROOT_SIGNATURE_FLAG_ALLOW_INPUT_ASSEMBLER_INPUT_LAYOUT flag set [ STATE_CREATION ERROR #683: CREATEGRAPHICSPIPELINESTATE_MISSING_ROOT_SIGNATURE_FLAGS]
Exception thrown at 0x00007FFA12017788 in SimpleViewer.exe: Microsoft C++ exception: _com_error at memory location 0x000000AC4A8FD280.

Shaders.zip
shaders files for the above error

I can help you debug this, but was hoping you would take a quick look at the errors and try to resolve it yourself before I told you the answer.  I'll give you a hint for the first one.  It's an issue with your vertex shader.

It look like I fix both of them or at least the first, now I have this error (it is going deep):
D3D12 ERROR: ID3D12Device::CreateGraphicsPipelineState: Rasterization Unit is enabled (PixelShader is not NULL or Depth/Stencil test is enabled and RasterizedStream is not D3D12_SO_NO_RASTERIZED_STREAM) but position is not provided by the last shader before the Rasterization Unit. [ STATE_CREATION ERROR #682: CREATEGRAPHICSPIPELINESTATE_POSITION_NOT_PRESENT]
Exception thrown at 0x00007FFA12017788 in SimpleViewer.exe: Microsoft C++ exception: _com_error at memory location 0x0000002C45CFD3E0.

I changed to POSITION and root.Finalize looks this:
m_RootSig.Finalize(L"SimpleViewer", D3D12_ROOT_SIGNATURE_FLAG_ALLOW_INPUT_ASSEMBLER_INPUT_LAYOUT);

Very good.  So the issue I would expect that you're hitting now is because your vertex shader is outputting POSITION instead of SV_TARGET.  I would recommend using different structs for VS input and output.

correction.  I meant to say SV_POSITION, not SV_TARGET.  Sorry about that.  I'll edit my original reply as well.

Thanks Bob
With above fix, now my modelPSO is initializing after I also modified my shaders.  See the attached
Now I have to continue and display my buffer.  I learned a lot since you gave the first hint.
Now this matter is closed
Thanks again ..
Shaders.zip

I wish @amomer had provided a hint as to how they solved the first error. I am currently struggling with it myself, and came across this through Google.


[HOLD for payment 2023-05-25] [$1000] When request money for $80.60 the last digit changes

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Open Expensify
Select any chat
Request Money
Type Amount of 80.60
Send Request

Expected Result:
It should be same amount as we type 80.60
Actual Result:
its not same amount we type it convert to 80.59 automatically
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: <IP_ADDRESS>
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/43996225/a7d7f2d7-f4e0-4602-b3c4-2f5173cd8281
https://github.com/Expensify/App/assets/43996225/27fccca7-c20c-41af-8d15-e8b28218572c
Expensify/Expensify Issue URL:
Issue reported by: @corange-lab
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1683656531439209
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01e8d9bbc7d92c8bfb
Upwork Job ID:<PHONE_NUMBER>571867136
Last Price Increase: 2023-05-10

Proposal
Please re-state the problem that we are trying to solve in this issue.
Amount automatically changes in some cases when requesting for money, for example 80.60 changes to 80.59.
What is the root cause of that problem?
This is because of how floating point numbers are stored in binary format, you can read more about it on this StackOverflow question.

What changes do you think we should make in order to solve the problem?

Solving this issue is very simple, all we have to do is round the number instead of truncating it in the code shown below using Math.round().
https://github.com/Expensify/App/blob/45c3212061983394e0919839248512874c2af83f/src/libs/CurrencyUtils.js#L87-L90

Screencast from 10-05-23 09:34:41 AM IST.webm
What alternative solutions did you explore? (Optional)
None

Reproduced on web
https://github.com/Expensify/App/assets/54866469/f7b7196f-e2a9-4f09-9716-951c92c57175

Proposal
Please re-state the problem that we are trying to solve in this issue.
The requested amount changes in certain scenarios when they include decimal points.
What is the root cause of that problem?
Due to the way JavaScript handles all numbers as floating point values, some precision errors may arise from some calculations. For example, when trying to convert 80.60 to the lowest currency unit (multiplying by 100), the result is 8059.999999999999.
https://github.com/Expensify/App/blob/45c3212061983394e0919839248512874c2af83f/src/libs/CurrencyUtils.js#L87-L90
What changes do you think we should make in order to solve the problem?
When dealing with currency and monetary values, it is best practice to avoid operations that result in manipulating or changing the values. The convertToSmallestUnit method will have to be modified to make use of String operations to perform the conversion.
It can be reimplemented in the following steps:

Get the numeric value that is requested as a String
Count the number of digits that come after the decimal separator.
If the number of digits after the decimal separator is less than the number of decimals (currently only 2 supported decimal places), pad with zeroes until the length matches.
Remove the decimal separator with using a String replace operation
Return the whole number value.

The convertToWholeUnit method would also have to be modified to make use of string operations by inserting the decimal separator at the correct index in the string derived from the whole number.
What alternative solutions did you explore? (Optional)
None.

@thesahindia I have a different proposal. Can I propose? I can see that some proposals have been already selected. Thank you!

Hey @mdneyazahmad! You can definitely still propose until we make a final decision!

Proposal
Please re-state the problem that we are trying to solve in this issue.
The problem is that the accuracy of currency conversion between its minimum denomination and standard value is not guaranteed due to limitations in the JavaScript floating-point representation of decimal values.
What is the root cause of that problem?
The root cause of the issue is that JavaScript represents floating-point numbers in a way that cannot always accurately represent decimal values. This can result in precision and accuracy issues when working with monetary values, which require exact decimal representation.
What changes do you think we should make in order to solve the problem?
A solution to the problem would be to use integer arithmetic to represent monetary values instead of floating-point arithmetic. This would avoid the limitations of floating-point representation and ensure accurate and consistent calculations. The convertToSmallestUnit and convertToWholeUnit functions in CurrencyUtils.js can be modified to use integer arithmetic as outlined below :
function convertToSmallestUnit(currency, amountAsFloat) {
    const currencyUnit = getCurrencyUnit(currency);
    const currencyDecimals = getCurrencyDecimals(currency);
    const paddedDecimalAmount = amountAsFloat.toFixed(currencyDecimals);
    const integerPartString = String(paddedDecimalAmount).split('.')[0];
    const decimalPartString = String(paddedDecimalAmount).split('.')[1];
    return parseInt(integerPartString, 10) * currencyUnit + parseInt(decimalPartString, 10);
}

function convertToWholeUnit(currency, amountAsInt) {
    const currencyUnit = getCurrencyUnit(currency);
    const decimalPart = amountAsInt % currencyUnit;
    if (currencyUnit === 1) {
        return amountAsInt;
    }
    if (decimalPart === 0) {
        return Math.round(amountAsInt / currencyUnit);
    }
    const integerPart = Math.floor(amountAsInt / currencyUnit);
    return parseFloat(`${integerPart}.${decimalPart}`);
}

As the final step, you can integrate convertToWholeUnit into convertToDisplayString. I have also included a patch file that you can promptly apply against the main branch to verify if the implementation is working correctly.
0001-fix-correct-inaccuracies-in-currency-conversion.patch
What alternative solutions did you explore? (Optional)
During my search for alternative solutions, I evaluated the possibility of using a library like decimal.js to overcome the limitations of floating-point arithmetic.

Hey all! So I think the simplest way forward is going to be using Math.round à la @therealsujitk. I was a little worried about the imprecision that might be involved with that solution, but I saw in the code (and checked with the author) the comment: we do not currently support any currencies with more than two decimal places. Sorry Tunisia :( so as long as our rounding goes to that level of precision, we should be fine (we're not introducing any NEW inconsistency).
I'm going to go ahead and assign you to this - if you disagree at all @thesahindia speak now or forever hold your peace 😃

Applied to upwork job, will add a PR shortly.

@therealsujitk offer sent for $1,000 (we'll issue $500 bonus when paying)!

@thesahindia offer sent for $1,000 (we'll issue $500 bonus when paying)!

@corange-lab offer sent for $250!

@thesahindia could you also please complete your portion of the BZ checklist? We'll need to complete that before we issue payment here. Thanks!

@joekaufmanexpensify Thank you for sending offer. i have accepted
Thank you.

@thesahindia Sounds good for the regression test. Just to clarify for the other items, was their no PR that introduced this bug?

Chatted with @dangrous and confirmed the first 3 items of the BZ checklist don't apply here, and that this bug just arose because of JS behaving in an unusual way we did not expect.

All set to issue payment here!

@therealsujitk $1,500 sent and contract ended!

@corange-lab $250 sent and contract ended!

@thesahindia when you have a chance, can you accept our offer for this so we can pay you? Thanks!

Payment received, thanks everyone!

@corange-lab $250 sent and contract ended!

@joekaufmanexpensify thank you payment received.

@thesahindia great, thanks! $1,500 sent and contract ended.

Upwork job closed.

Bug is fixed, BZ checklist complete, and all payment issued. Closing as this is all set. Thanks everyone!


feat: email notification integration

feat: email notification integration - #1693
Test Plan

[ x] acceptance tests

References
https://docs.snowflake.com/en/user-guide/email-stored-procedures

Thanks @mlorek, this looks good!.  I have been working on a new design for the Snowflake SDK to replace the "snowflake" package. You can learn more about it here: https://github.com/Snowflake-Labs/terraform-provider-snowflake/discussions/1767. Would appreciate if you had any feedback / would be able to contribute using this new design pattern in the future.


Response headers available in callback

Type of issue

[x] Feature request

Uploader type

[x] Traditional

Details
Hello,
I found that in the response object of the onComplete callback, contains only the raw response json, i.e. headers are missing. I think it makes sense to have the headers available in there, so that they can be used for any purpose.
In my app I'm using redux-token-auth to authenticate users, I'm having troubles mixing redux-token-auth and fine-uploader (via react-fine-uploader), in order enable only authenticated users to upload images.
I opened this issue as well.
I managed to perform an image upload by configuring the uploader with:
  request: {
    endpoint: backend.createImage,
    customHeaders: {
      "access-token": localStorage.getItem("access-token"),
      "token-type": localStorage.getItem("token-type"),
      client: localStorage.getItem("client"),
      uid: localStorage.getItem("uid")
    }
  },

token auth is designed so that at each request it generates a new token, that needs to be saved in the client, so that it can be used for the next time. I would need to be able to access the response headers in the callback in order to save them back.
  onComplete: (id, name, response) => {
  if (response.success) {
    reduxTokenAuth.updateToken({
      "access-token": response.headers["access-token"],
      "token-type": response.headers["token-type"],
      client: response.headers["client"],
      uid: response.headers["uid"]
    });
    console.log("UPLOAD SUCCESS: response: " + JSON.stringify(response, 0, 2));
  } else { [..] }
};

The XHR instance is passed to your callback as a fourth parameter. You can obtain the headers from this. See the docs for more details.


EPIC Generate a report of values for all shares held

Updating the stop/loss for all shares I hold is something that I do every week, so this could help speed up the process. I also want to see which shares are making me money and the shares that are tailing off.

Download EOD Data for the previous week.
Import the data into the app.
Using the latest Friday prices, generate a report of held shares showing: Share ticker, name, number held, price paid, latest price, profit, new stop/loss.

Steps

[x] Import securities list from EOD Data file.
[x] Import transactions for shares. #6
[ ] Produce holdings table from transactions. #4
[ ] Import share prices from EOD data and store prices for shares that have been held or are being held.
[ ] Update holdings table with latest prices and values.

Reviewed work so far and updated this epic.
Split out design notes from README.
1h00


Problem of align draft.fa and reads.fasta

Hi, I had problem running the quick start tutorial, and here is the problem:
Commend:
bwa mem -x ont2d -t 8 draft.fa reads.fasta | samtools sort -o reads.sorted.bam -T reads.tmp
Messages:
s.sorted.bam -T reads.tmp
sort: invalid option -- 'T'
open: No such file or directory
[bam_sort_core] fail to open file reads.sorted.bam
[M::bwa_idx_load_from_disk] read 0 ALT contigs
[M::process] read 112 sequences (617552 bp)...
[M::mem_process_seqs] Processed 112 reads in 3.999 CPU sec, 4.300 real sec
Please help, thanks

The version of samtools you are using is too old, please upgrade.
Jared

Thanks, the problem solved.


Split theme in 2: with and without login page (default)

As a user, I should not be presented with a KeyCloak login form
Create 2 themes:

bcgov-with-login
bcgov-without-login

resolved by PR #4


Spans not exported for requests without IO operations in Cloudflare Workers

Description
When using the otel-cf-workers library to instrument a Cloudflare Worker, spans are not being exported for requests that don't involve any IO operations outside of the worker.
Context
My worker is instrumented using this library. It works like a dream when we have IOs outside of the worker in the request. However, when there is no IO, the spans are not exported.
I did add a dummy KV cache GET/PUT to test that theory and it works (most of the time).
I noticed that when I could not see spans with 401s. A 401 does not make any call outside of the worker; but,  successful requests which involve a network call had spans associated to them.
I may be wrong on the cause of this.
Current Behavior

Spans are successfully exported when there are IO operations outside of the worker in the request.
Spans are not exported when there are no IO operations.
Adding a dummy KV cache GET/PUT operation seems to resolve the issue most of the time.
Spans are not visible for 401 errors, which typically don't involve external calls.

Expected Behavior
Spans should be exported consistently for all requests, regardless of whether they involve IO operations or not.
Possible Cause ( I may strongly be wrong about this)
The issue may be related to how the worker's clock is updated (See details here). The scheduler.wait function in the library might be waiting indefinitely when there's no IO operation, as the clock is not being updated.

Doing this very ugly path seem to do the trick
const app = {
  async fetch(request: Request, env: Env, ctx: ExecutionContext): Promise<Response> {
    const startTime = performance.now();
     // Rest of code (Calling or not IOs)
    const endTime = performance.now();

    // This means that there hasn't been any IO, so we need to make a dummy call
    if (endTime - startTime === 0) {
      ctx.waitUntil(
        Promise.resolve().then(async () => {
          await incrementTime(env, 10);
        }),
      );
    }
  }
};

async function incrementTime(env: Env, delay: number): Promise<void> {
  const startTime = performance.now();
  const id = crypto.randomUUID();
  const maxTries = 50;
  let tries = 0;
  while (performance.now() - startTime < delay && tries < maxTries) {
    tries++;
    try {
      await env.CACHE.put(`dummy-call-to-trigger-spans ${id}`, 'dummy-value');
      await env.CACHE.delete(`dummy-call-to-trigger-spans ${id}`);
    } catch {
      // noop
    }
  }
}

That is a very ugly trick.. And absolutely a bug.
I am currently working on a major internals refactor to better handle this kind of flow and will make sure that this case is tested :)

Hey @gbmarc1, Apologies for the delay, but I just wanted to let you know that this is fixed in the core-logic-refactor branch.. (https://github.com/evanderkoogh/otel-cf-workers/tree/core-logic-refactor).
Please do not try this as everything but HTTP is broken in there, but here is what it looks like in Honeycomb..


Picture-glance not working with entity-filter

picture-glance isn't working alongside entity-filter, it works fine when changed to just glance.
Code used in Demo environment to test:
      - type: entity-filter
        entities:
          - light.bed_light
          - light.ceiling_lights
          - light.kitchen_lights
        state_filter:
          - 'off'
        card:
          type: picture-glance
          image: https://images2.roomstogo.com/is/image/roomstogo/br_rm_belmar_black_pan~Belmar-Black-5-Pc-Queen-Bedroom.jpeg?$pdp_gallery_945$

Running on Docker Dev environment as of 14/07/2018 9am GMT, but also confirmed to not be working on 0.73.1

It helps to describe the error and the expected behavior

No, the error appears only when an entity is turned on (in my case since it was lights). When nothing is supposed to be showing, everything is fine.


How to install liblua.a?

liblua.a is available in the zig-cache/ directory after running ziglua.compileAndCreateModule in my project’s build.zig. Can ziglua possibly install liblua.a into zig-out/? This would help in doing Zig-Go interop — I’d like Go to link against this liblua.a. Perhaps there’s a way of doing this from my project’s build.zig

Hi @atweiden!
This is a known issue (see https://github.com/natecraddock/ziglua/pull/13). The package manager that will be part of the 0.11.0 release has some of the pieces required for this to work, but we are still waiting on a PR to be merged.
Once the package manager can handle exposing data other than Zig modules, this will become easy. The code would look something like this in a build.zig.
const ziglua = b.dependency("ziglua", .{
    .target = target,
    .optimize = optimize,
});

// here is the library "liblua.a" and can be linked against anything you need, or written to a file
ziglua.artifact("lua");

There may be a way to get this fixed sooner, but I am inclined to wait until the package manager properly supports this use case. Let me know if I misunderstood anything!

Hi @atweiden, sorry for the long wait on this.
This is now fixed and I tested to verify this works. The readme has been updated with build instructions that use the new package manager. Here is an example that shows how to link the artifact with your project, and how to write the lua library artifact to the output folder.
// build.zig.zon
.{
    .name = "array",
    .version = "0.0.1",
    .dependencies = .{
        .ziglua = .{
            .url = "https://github.com/natecraddock/ziglua/archive/ab111adb06d2d4dc187ee9e1e352617ca8659155.tar.gz",
            .hash = "12206cf9e90462ee6e14f593ea6e0802b9fe434429ba10992a1451e32900f741005c",
        },
    }
}

// build.zig
const std = @import("std");

pub fn build(b: *std.build.Builder) void {
    const target = b.standardTargetOptions(.{});
    const optimize = b.standardOptimizeOption(.{});

    const ziglua = b.dependency("ziglua", .{
        .target = target,
        .optimize = optimize,
        .version = .lua_54,
        .shared = true,
    });

    const lib = b.addSharedLibrary(.{
        .name = "array",
        .root_source_file = .{ .path = "src/array.zig" },
        .target = target,
        .optimize = optimize,
    });

    // These lines link lua to the output library
    lib.addModule("ziglua", ziglua.module("ziglua"));
    lib.linkLibrary(ziglua.artifact("lua"));

    // This line installs liblua to the zig-out/lib/ directory
    b.installArtifact(ziglua.artifact("lua"));

    b.installArtifact(lib);
}


Boogie fails with a parse error if a procedure name is yield

It would be useful to report that yield is a reserved name; especially to a vanilla/novice Boogie user, the parse error is probably surprising.

I just tried Boogie and discovered that this is a uniform issue with all keywords, not just yield.  Better error messages across all of that is low priority for now.  So closing this issue.  But, thanks a ton for reporting.


feat(spanner): pass fieldMask option when Instance#exists() is called

The problem here is that exists() uses reload(), which will update the cached representation of the instance. If the class already holds a full representation of the object, we may be losing information which the user expects.
For instance:
$instance->reload(); // we now have a cached resource.
echo $instance->info()['displayName']; // This comes from the cache, no new service request.

var_dump($instance->exists(); // check if the instance exists

echo $instance->info()['displayName']; // This value is no longer set, PHP raises a NOTICE.

My preference is to leave things as they are. If that is not something we can do, we should be a bit smarter about it. @skuruppu can you help with that decision?
Perhaps something like this:
public function exists(array $options = [])
{
	try {
		// already cached
    	if ($this->info) {
			$this->connection->getInstance($options + ['fieldMask' => ['name']);
		} else {
			$this->reload($options);
		}

		return true;
	} catch (NotFoundException $e) {
		return false;
	}
}

Let me know if that doesn't make sense.

@ava12 is this an optimization you're trying to do? Or was this required to help with some other PR? Just wanted to understand the context before making a decision.
I agree with @jdpedrie. We don't want to lose the cached information so the improvement that he suggested would work better here.

@ava12 is this an optimization you're trying to do? Or was this required to help with some other PR? Just wanted to understand the context before making a decision.
I agree with @jdpedrie. We don't want to lose the cached information so the improvement that he suggested would work better here.

It's a minor optimization, related to PR #2530.
And I agree that ruining info field is wrong. I'll fix that.


[BUG]: Deserializing https://api.github.com/repos/{owner}/{repository} to Octokit.Webhooks.Models.Repository will throw

What happened?
When attempting to deserialize a successful rest request response from https://api.github.com/repos/{owner}/{repository} to Octokit.Webhooks.Models.Repository, STJ will throw the following exception:
System.Text.Json.JsonException: The JSON value could not be converted to System.String. Path: $.organization | LineNumber: 0 | BytePositionInLine: 5592.
 ---> System.InvalidOperationException: Cannot get the value of a token type 'StartObject' as a string.
   at System.Text.Json.ThrowHelper.ThrowInvalidOperationException_ExpectedString(JsonTokenType tokenType)
   at System.Text.Json.Utf8JsonReader.GetString()
   at System.Text.Json.Serialization.Metadata.JsonPropertyInfo`1.ReadJsonAndSetMember(Object obj, ReadStack& state, Utf8JsonReader& reader)
   at System.Text.Json.Serialization.Converters.ObjectDefaultConverter`1.OnTryRead(Utf8JsonReader& reader, Type typeToConvert, JsonSerializerOptions options, ReadStack& state, T& value)
   at System.Text.Json.Serialization.JsonConverter`1.TryRead(Utf8JsonReader& reader, Type typeToConvert, JsonSerializerOptions options, ReadStack& state, T& value, Boolean& isPopulatedValue)
   at System.Text.Json.Serialization.JsonConverter`1.ReadCore(Utf8JsonReader& reader, JsonSerializerOptions options, ReadStack& state)
   --- End of inner exception stack trace ---
   at System.Text.Json.ThrowHelper.ReThrowWithPath(ReadStack& state, Utf8JsonReader& reader, Exception ex)
   at System.Text.Json.Serialization.JsonConverter`1.ReadCore(Utf8JsonReader& reader, JsonSerializerOptions options, ReadStack& state)
   at System.Text.Json.Serialization.Metadata.JsonTypeInfo`1.ContinueDeserialize(ReadBufferState& bufferState, JsonReaderState& jsonReaderState, ReadStack& readStack)
   at System.Text.Json.Serialization.Metadata.JsonTypeInfo`1.DeserializeAsync(Stream utf8Json, CancellationToken cancellationToken)
   at System.Net.Http.Json.HttpContentJsonExtensions.ReadFromJsonAsyncCore[T](HttpContent content, JsonSerializerOptions options, CancellationToken cancellationToken)

I suspect this is because Octokit.Webhooks.Models.Repository should be of type Octokit.Webhooks.Models.Organization instead of a string. When reproducing, ensure the repository you're calling the route on belongs to an organization, not a user.
Versions

Dotnet SDK: 8.0.302
Octokit.Webhooks NuGet package: 2.2.2

Relevant log output
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

When attempting to deserialize a successful rest request response from https://api.github.com/repos/{owner}/{repository} to Octokit.Webhooks.Models.Repository

This library isn't designed to deserialize REST API Responses. I think you might be looking for https://github.com/octokit/octokit.net

@OoLunar I'm closing this for now, as I don't believe this library is the correct one for what you're doing. Please leave a comment if I've misunderstood and I can re-open the issue.


Git hub Login not working

Type: Bug
i am not be able to login into github account in VS code.
VS Code version: Code 1.86.2 (903b1e9d8990623e3d7da1df3d33db3e42d80eda, 2024-02-13T19:40:56.878Z)
OS version: Windows_NT x64 10.0.19045
Modes:

System Info

Item
Value

CPUs
Intel(R) Core(TM) i3-6006U CPU @ 2.00GHz (4 x 1992)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: enabled_ondirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_graphite: disabled_offvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: enabled

Load (avg)
undefined

Memory (System)
7.91GB (3.24GB free)

Process Argv
--crash-reporter-id c74d9541-efda-41ed-87c7-807703ecc98b

Screen Reader
no

VM
0%

Extensions (18)

Extension
Author (truncated)
Version

better-comments
aar
3.0.2

vscode-tailwindcss
bra
0.10.5

path-intellisense
chr
2.8.5

vscode-eslint
dba
2.4.4

es7-react-js-snippets
dsz
4.4.3

prettier-vscode
esb
10.1.0

auto-rename-tag
for
0.1.10

code-runner
for
0.12.1

vscode-pull-request-github
Git
0.80.0

vscode-gutter-preview
kis
0.30.0

vscode-language-babel
mgm
0.0.40

cpptools
ms-
1.18.5

vsliveshare
ms-
1.0.5905

color-highlight
nau
2.5.0

prisma
Pri
5.9.1

vscode-xml
red
0.26.1

LiveServer
rit
5.7.9

vscode-icons
vsc
12.7.0

(1 theme extensions excluded)

A/B Experiments
vsliv368:30146709
vspor879:30202332
vspor708:30202333
vspor363:30204092
vswsl492:30256859
vscorecescf:30445987
vscod805:30301674
binariesv615:30325510
vsaa593cf:30376535
py29gd2263:30899288
c4g48928:30535728
azure-dev_surveyone:30548225
a9j8j154:30646983
962ge761:30959799
pythongtdpath:30769146
welcomedialog:30910333
pythonidxpt:30866567
pythonnoceb:30805159
asynctok:30898717
pythontestfixt:30902429
pythonregdiag2:30936856
pyreplss1:30897532
pythonmypyd1:30879173
pythoncet0:30885854
h48ei257:30962250
pythontbext0:30879054
accentitlementsc:30887149
dsvsc016:30899300
dsvsc017:30899301
dsvsc018:30899302
pydisww2:30959801
edj9j583:30958191
7j2b6412:30967274

Can you follow these steps so that we can get more information on what's going on?

Trigger the sign in
Wait for the issue to happen...
Open the Output pane (ctrl+shift+u on Windows)
drop in this issue he contents of the following:

GitHub Authentication Output channel

@ankitwaware do you have any firewall or proxy configured on this machine that would prevent VS Code from connecting to GitHub?

i dont have  any firewall or proxy configured on my machine.

Sounds like a network issue. https://github.com/orgs/community/discussions/41347 mentioned that IP before.

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


onInit function only called once in life of App

Describe the bug
Moving to a page that uses onInit to do some initial functionality works first time only.
To Reproduce

On navigating to a new page, controller is created in GetBuilder.
Controller does data retrieval in onInit method.
Leave page, and controller is deleted from memory
Return to page, and controller is recreated, but onInit is not run so data is not retrieved.

Expected behavior
onInit is run each time a controller is instantiated.
Flutter Version:
1.17.3
Get Version:
2.11.0
Minimal reproduce code
 @override
  void onInit() {
    getDataFromFirebase();
    super.onInit();
  }

Describe the bug
Moving to a page that uses onInit to do some initial functionality works first time only.
To Reproduce

On navigating to a new page, controller is created in GetBuilder.
Controller does data retrieval in onInit method.
Leave page, and controller is deleted from memory
Return to page, and controller is recreated, but onInit is not run so data is not retrieved.

Expected behavior
onInit is run each time a controller is instantiated.
Flutter Version:
1.17.3
Get Version:
2.11.0
Minimal reproduce code
 @override
  void onInit() {
    getDataFromFirebase();
    super.onInit();
  }

I tested it on the pub dev sample application and is working with SmartManagement.full.
Which option are you using?

I think you are using SmartManagement.onlyBuilder.
I'm going to take a look at that now.

I am using SmartManagement.onlyBuilder.

isDependencyInit is not firing because the controller is still kept in the tree even though I used Get.offAndToNamed and the controller was removed from memory.

I have same problem on Get 2.11.0, Controller does data retrieval in onInit method. and the smartManagement is default, I didn't set it.

Fix on 2.11.1


Vulnerability in dash copay?

https://github.com/dominictarr/event-stream/issues/116#issuecomment-441744514

I got it decoded. Package description "A Secure Bitcoin Wallet". The targeted package is: https://www.npmjs.com/package/copay-dash

https://github.com/dominictarr/event-stream/issues/116#issuecomment-441749105

So, for people who try to understand what the malicious payload is doing: it's basically crawling your dependencies for a peer dependency on the package copay-dash, and it's an attack basically crafted towards this package.
If your overall application has both this malicious package and "copay-dash", then it's going to try stealing the bitcoins stored in it.

Hi, thanks for reporting. This vulnerable package is 2 years old and not a supported package. One of our developers still has access and has added a warning not to use this. It was never our current Dash CoPay lib, which is actually named dash-copay (note the reversal).
These are separate NPM packages (copay-dash !== dash-copay). The latter is the supported one and not affected by this particular vulnerability, because the particular search string doesn't exist in the supported NPM package description.


Normalizing CRLF in test assertions

When a contribution comes in by way of Windows, I believe it causes test failures due to the difference in line endings..
https://travis-ci.org/apigee-127/swagger-test-templates/jobs/110661936

security swagger assert-option expect should have path parameters with an obvious indicator:

I added some CRLF line feed normalization to the tests. There are probably other ways to do this, such as forcing conversion upon check-in, but the method used herein was also used in at least one other location.

@djabraham thanks for making the changes on the tests.
This replacement is only necessary for the diffs to work, right? The generated JavaScript still works on Windows, yes? Just want to be sure.

Correct. The templates seem to work fine on Windows. JS parsers don't care what line endings look like, and neither do most editors now either. So the output still looks good, unless you have a picky editor or something.
I think it's just because editors running under Windows tend to persist files with '\r\n' instead of '\r'. So that's likely the reason the tests were seeing mixed results.

lgtm @djabraham thank you


Timeout option

Maybe I didn´t find the option, but I want to set a manual timeout. Some servers aren´t answering and then the script will run over 30s...
I tried with CURL Loader, without success.

Have you tried with SocketLoader?
https://github.com/io-developer/php-whois/blob/9f93d372f2680f8185fb775cc71950dcdd9ce374/src/Iodev/Whois/Loaders/SocketLoader.php#L34


Different item sizes cause visualization problems

Hello,
I have created a simple chat app that shows the messages sent by the users, so each item in recycler view has a different size. The error occurred when you scroll down because sometimes an undesired spacing appears between elements, as you can see in this image. Is there any solution for this?
Thank you

https://github.com/angelgutlop/SQawker

@angelgutlop, it's strange. To start, remove from the SqwakAdapter this.notifyDataSetChanged();.
Then I see you use FlexibleItemDecoration with withDefaultDivider(), this accepts nothing or the item layout (not the divider id, it's already android default divider!) to which you want to apply the divider, possibly with drawOver.

Thanks for answering!! However, these changes that you have proposed to me have not solved the problem. Can the problem be related to the layout of the item? To help investigate the cause I have initialized the app database with random messages of different sizes. You can download it from the previous url

@angelgutlop, I see you removed the decorator, so it's not anymore involved. Do other extremely important modifications in SqwakItem which generally help your code:

Use public static class SqwakViewHolver;
Move private final ViewBinderHelper viewBinderHelper = new ViewBinderHelper(); to your custom adapter. Then in order to have a unique reference to that helper, you can cast the adapter: a) at the creation; b) in the viewholder; c) in the binding.

I never got this issue in my apps, going for exclusion, I would say it might be something related to the layout or constraintLayout and not from the Adapter. Try change/play with the layout a bit.

@angelgutlop, You can use also Layout Inspector from the menu tools in Android Studio.

Hi. Thank you very much for your advices. I did not know the tool to inspect layouts. I have been checking the problem and it has to do with the sliding layout of the FrameLayout type of the SwipeRevealLayout. From time to time, this layout changes height and takes up more screen space as it has no limitations on its size. I am trying to solve this problem.

<com.chauthai.swipereveallayout.SwipeRevealLayout
android:layout_width="match_parent"
android:layout_height="wrap_content"
app:dragEdge="right"
app:mode="same_level">
<FrameLayout
    android:layout_width="wrap_content"
    android:layout_height="match_parent">

    <ImageView
        android:id="@+id/imagen_unfollow"
        android:layout_width="wrap_content"
        android:layout_height="wrap_content"
        android:layout_gravity="center_vertical|center_horizontal"
        app:srcCompat="@drawable/ic_visibility_off_white_24dp" />

</FrameLayout>

<android.support.constraint.ConstraintLayout
    android:id="@+id/vista_frontal"
    android:layout_width="match_parent"
    android:layout_height="wrap_content"
    android:background="@android:color/background_light"
    android:padding="8dp">
    .  .  .

</com.chauthai.swipereveallayout.SwipeRevealLayout>`

Hi. I have been investigating the causes of this problem and it turns out that it is a problem in the library https://github.com/chthai64/SwipeRevealLayout to make the swipe. With this one, I have not had any problems. https://github.com/daimajia/AndroidSwipeLayout
Thanks for the help!!

@angelgutlop, thanks for your investigation.


uncomment skip tests

This PR re-activates some of the tests i had to skip when migrating to gdsfactory8
it would be great to fix get_netlist_flat and get_netlist_recursive before merging this PR so we keep tests always passing
Simon and Troy, I would need some help from you to fix those functions
@simbilod
@tvt173

Simon, i removed the get_netlist_flat as it seems duplicated from get_netlist_recursive

Simon, i removed the get_netlist_flat as it seems duplicated from get_netlist_recursive

Hmmmm get_netlist_flat used to unroll the netlist by labeling all instances differently, whereas netlist_recursive only considers the component hierarchy
But I guess we don't really use get_netlist_flat anymore so it probably doesn't matter

We can always bring it back if we need it


🔗 Fix broken URL for Codespace Create button

This PR fixes the broken URL for the Codespace Creation as observed;

Hi @alfredodeza, @burkeholland could you please have this fixed? Thanks!

Hi @saragibby
Could you please review this PR? Thank you!

Hi @alfredodeza
The change has been Implemented through https://github.com/github-education-resources/codespaces-teaching-js-template/pull/47/commits/7adc61aa9c4c84dd65d49f7e1afe62d5f1274375

@AnthonyByansi what I meant is that the image shouldn't come from a user account that uploaded it. In this case, the correct svg should be this one: https://github.com/codespaces/badge.svg
Can you make that change?


Settings: Use documented NavigationView adaptive behavior and always set title bar

Remove AdaptiveTrigger for window width in favor of using the PaneDisplayMode="Auto" setting with CompactModeThresholdWidth="0" for identical behavior
Fix bug where the titlebar (custom drag region) was only set when the Settings page is first created (fixes #1498)

@duke7553 Great work!


SiteContents not being persisted to the generator?

Describe the bug
First off, sorry if this isn't the correct place for this. I have a strong feeling it's more PICNIC than an actual bug, but perhaps shedding a bit of light on this might be valuable for anyone in the same position. I also tried casting my hook into the Slack, but didn't get any bites.
I've restructured the basic example a little and was just toying with Fornax generally, but I'm finding that whatever I put in to my SiteContents within my loaders is not then available in my generators. I'm not sure if I'm missing something super basic, but I was hoping I could get a little bit of guidance. If it's something that perhaps needs clearing up in the docs for clueless people like me, I'm happy to help with that.
I've tried a number of dfferent types, and I've also been able to confirm that the record goes in to the DI container (as I can get it back out within the loader), but once I come to the generator stage, I can't seem to retrieve them. I know it's something obvious I'm missing...
I've created a dump of the repo I was working on here here.
To Reproduce
Steps to reproduce the behaviour:

Clone the example
fornax watch
Observe the exception that the Site record couldn't be pulled from the DI container, despite being added in the globalloader.fsx

Environment (please complete the following information):

OS: macOS Mojave
Ionide version:
VSCode version: 1.50.0
dotnet SDK version:
mono / .Net Framework version: 5.0 RC1

Did you write helpers.fsx yourself or did you copy it from somewhere? I'm not sure precisely what I would do to fix them, but they may be a little too generic? When I attempted to replace their use with out-of-the-box TryGetValue/TryGetValues I was getting data out.
FTR the error I was getting on fornax watch is:
`An unexpected error happend:
System.Reflection.TargetInvocationException:
Exception has been thrown by the target of an invocation.
--->
System.Exception: Could not get FSI_0016.Types+Site
at FSI_0016.Helpers.SiteContents.GetValue[t](SiteContents X1)
at FSI_0016.Post.generate(SiteContents ctx, String projectRoot, String page)
--- End of inner exception stack trace ---.`

Sorry, I'm not sure why I didn't include the stack trace originally 🤦
Is it possible to add break points to Fornax, or would I have to clone, build and run it like that?

Ok, this is tricky. Basically, as far as I understand, the issue is a result of including types.fsx file multiple times - it's included in every loader and every generator (through includes.fsx file). Every time you include types.fsx file new Site record type is defined and as a result, those are actually different types (if you'd inspect all that through reflection you'd notice the fully qualified names of types are different).
The solution to that is to include types.fsx file normally only once (just in globalloader.fsx for example), and for all other files it needs to be added in #if !FORNAX section - this will "power" editor tooling but won't be actually evaluated in underlying F# Interactive session that Fornax creates.

Woof, I really don't understand why this is happening and I fiddled around with you repo for a while, but it persists fine with just fornax new which is confusing me.
As far as I'm aware you'd have to clone, build and run.
I think you'd have to look somewhere around generateFolder function.
SiteContents is just a ServiceContainer so I'm not really clear on what you could do to log the contents. Not really a part of .NET I'm familiar with.

Thanks for looking at this @Krzysztof-Cieslak!
I'll have a look at doing that and see where I get with it. Now I understand the use of the #if !FORNAX directive too, awesome.