Actor stuck after 'Move Actor' completes

Describe the bug
Using move actor to, in a scene, all triggers using this now cause the actor to become stuck in place where it is and cycle through all of its animations at high speed. this does not happen on every occasion but cause a complete lock out when it does.
Expected behavior
A clear and concise description of what you expected to happen.
actor to move to position and continue with script
Platform (please complete the following information):
Windows 64 Beta4
Additional context
https://youtu.be/UkDhvxYCldo

Ive have found that buy reducing the actor speed from 2 to 1 it has stopped it happeneing.
I also tested across Beta's 1 3 and 4 with the same results.

Crosspost https://www.reddit.com/r/gbstudio/comments/jij777/getting_stuck_when_going_through_a_second_hit_of/gatu47y
Important to note this is a Platformer Scene.
I think this helps me to understand the bug we're facing, my theory is with per pixel movement of platformer, and using a speed that jumps 2 or 4 pixels at a time, there's a 50% chance the move to event, which just moves you x pixels, then checks if you're on tile, is never lining up with the tiles pixel.
Workaround, use "Set position" player x, player y, then up the speed and move, This should make sure you're on tile before the move.
The bug itself is not good, and requires a bit (lot) of a rewrite to actor movement...

Related issues to the current movement algorithim, #510
This variant of the issue is with actions being immediate, so while topdown 2d is grid based, interrupting movement mid move has the same chance to be off tile, but that case also might be off tile in x or y, causing the same issue even with speed 1.
#449 Off tile, changing to different direction, moves off screen forever.
#629
This is the most similar bug, changing to speed 2px/frame, mid tile, has a 50% chance of breaking just like here.


Replace Vela up in the github CI

Describe the bug
vela up is being deprecated but we are still using it to setup e2e test in CI.
To Reproduce
Expected behavior
Use helm install instead as recommended in our documents.
Additional context
Currently, the e2e/setup test suite is empty and we somehow relies on it in the e2e test setup to make sure the setup is correct.  We need to add some setup tests.

@ryanzhang-oss Ryan, do you mean replacing vela install?

@ryanzhang-oss Ryan, do you mean replacing vela install?

This will be fixed in #1005

hi @ryanzhang-oss , is this issue still valid?


Operator controller pod ignores delete/create cycle of iop

Bug description
The following install/uninstall cycle is not working for us with 1.5.0

Operator pod is deployed and  running

apply iop

control plane resources created

delete iop

control plane resources removed

apply iop (exact same one as above)

nothing  happens in the cluster!

see this in the logs Generated manifest objects are the same as cached for component ...

If I restart the operator pod, then the control plane is created, that should not be necessary, any cache should be removed when the iop is deleted.

operator.log.txt
Expected behavior
Should be able to cycle install (create iop) and uninstall (delete iop) and see the control plane resources come and go.
Steps to reproduce the bug
above
Version (include the output of istioctl version --remote and kubectl version and helm version if you used Helm)
1.5.0
How was Istio installed?
Environment where bug was observed (cloud vendor, OS, etc)

cc @sdake @linsun @howardjohn

@dgn @ostromart I believe one of you was responsible for the implementation of the caching layer. I'd really really like to bundle this in the 1.5.1 release. Anything you can do to fix this on your own or provide pointers for me to fix myself would be appreciated.
It sort of appears like the caching is not flushed on a removal of an IOP.

@kramvan1 this was fixed in https://github.com/istio/istio/pull/21847. It appears while this PR merged prior to release 1.5 (march 5th), the PR itself didn't make it into the final build. I have tested 1.5.0 (broken), 1.5-dev (works correctly), master (works correctly).
This also appears to be a duplicate of https://github.com/istio/istio/issues/21467
If you feel this issue was closed in error, please feel free to reopen.

fixed, thx!


BackfillJob overrides start date but that doesn't propagate to executor commands

I'm frankly not sure if this is a bug or not but it's weird so I'm creating a tracking issue for it. This will probably be addressed as part of either the #1225 resolution or the start_date roadmap item.
BackfillJob overrides the start date of a dag and its tasks. However, the override doesn't carry through to the executor commands. For example, SequentialExecutor issues an airflow run command and loads the same dag with its original start date.
This creates a problem because BackfillJob will always think the first iteration of a task with depends_on_past=True is runnable, since the execution date and start date match. But the executor it assigns to run that task will conclude that it it NOT runnable, because execution date and start date don't match.

Closed in #1271


large pages support update the detection.

Thanks! Any more detail on what RH-based means? Any particular version this started in/etc?

Pushed to next, thanks!

released in 1.6.14


Potential undefined behavior

https://github.com/Visecy/Karuha/blob/master/karuha/event/message.py#L61
Adding await here will allow us to control the sequence of actions (now the call is actually undefined due to the lack of await).
It might be more correct to write it like this:
await event.bot.note_read(event.topic, event.seq_id)
await MessageEvent.from_data_event(event).trigger(return_exceptions=True)

We first mark that the bot has read the message. Then we call the client implementation.

I don’t think strict ordering is needed here, note_read only provides read information, it can be parallelized with message processing to reduce the chatbot’s response time.

Yes, I agree. I will close this issue


[BUG] Overflow is missing on the description column from the Archetypes view

Is there an existing issue for this?

[X] I have searched the existing issues

Konveyor version
0.5.0-alpha.2
Priority
Undefined (Default)
Current Behavior
Overflow if missing in the description column from the Archetypes view, ellipsis is not displayed and the text is cut instead:

Expected Behavior
Ellipsis is displayed on overflow.
How Reproducible
Always (Default)
Steps To Reproduce
No response
Environment
Konveyor 0.5.0-alpha.2

Anything else?
No response

Related to #1753


Train on my own dataset

Hi, everyone. I want to train PV-RCNN on my own point cloud data.
I have converted the data to KITTI format, with .bin file and one-to-one .txt annotation file. However, there is an essential problem confused me that the object heading.
In the case of my data, x-axis is forward, y is the left and z is up, and the orientation defines the angle between the object and x-axis. It is different from the KITTI setting, and how should I modify the code in the OpenPCDet project to promise the rotation consistently?
Any help would be appropriated a lot!

For OpenPCDet, I think it is easy to adapt to new datasets with different coordiante, and you just need to write your own dataloader and transform your coordinate to our unified coordinate of OpenPCDet before going to the model.forward.

Thanks. Another problem confused me is whether the 'rotation' parameter in my own label should be converted into a radian format? In KITTI readme file, the rotation_y ranges from -pi to pi.
In other words, I want to ensure what format do you use to present the object rotation in the whole project, radian or angle?
Thanks in advance, and any helps would be appreciated!

By the way, how to determine the 'anchor_bottom_height' in the config file?


ThriftScanner.serversWaitedForWrites - make configurable for user tables

Clients pass true for the waitForWrites parameter to the startScan and startMultiScan Thrift service calls when the client is scanning a specific server for the first time. The comments in ThriftClientHandler indicate the reason for this, but it's arguable that for some applications a client may not need to wait for writes to complete against user tables.

I have asked @ddanielr to look at this.

@dlmarion I read through your documentation and I'm working on this.
Can you assign this issue to me?

WIP up with current changes.
https://github.com/apache/accumulo/pull/3187
I based these changes off 1.10. Did you want that branch targeted? or is this a 2.1 change?

This issue is on hold, pending a response to https://github.com/apache/accumulo/pull/3187#issuecomment-1422338787

Closing this as won't fix for 1.10 and 2.1.1. If we find this is an issue in the future, then we can re-open.


Support qt5

This is based on https://github.com/msmolens/CTK/tree/wip-support-qvtkopenglwidget
The only difference is:
git diff msmolens/wip-support-qvtkopenglwidget..support-qt5
diff --git a/CMakeExternals/PythonQt.cmake b/CMakeExternals/PythonQt.cmake
index a500f80..2443cb3 100644
--- a/CMakeExternals/PythonQt.cmake
+++ b/CMakeExternals/PythonQt.cmake
@@ -78,7 +78,7 @@ if(NOT DEFINED PYTHONQT_INSTALL_DIR)
   endif()

   if (CTK_QT_VERSION VERSION_GREATER "4")
-    set(revision_tag 2e0a0045bf29def7ca198aa9892b111ae23a579a) # patched-7
+    set(revision_tag 93c280395aea05b16e1dc7025af969d3aa39fa38) # patched-8
   else()
     set(revision_tag 1afe4f8906345063b25047652e8962f641010a55) # patched-5
   endif()

Is the following commit in the PythonQt/patched-8 branch?
https://github.com/commontk/PythonQt/commit/2e0a0045bf29def7ca198aa9892b111ae23a579a

Is the following commit in the PythonQt/patched-8 branch?
commontk/PythonQt@2e0a004

Good catch. It is now integrated.


How  to bind  to a single address instead of all network interfaces by default

How  to bind  to a single address instead of all network interfaces in that host by default
For eg. Is there a  way to specify?
python proxy2.py <IP_ADDRESS>:3128

Currently such invocation is not supported.
You can edit the below line or implement customized test() function.
https://github.com/inaz2/proxy2/blob/e8fd304717c70cd39363858b4e6f2d591aaec577/proxy2.py#L375


ARROW-13125: [R] Throw error when 2+ args passed to desc() in arrange()

Let's wait to merge until we see if there is any response to https://github.com/tidyverse/dplyr/issues/5921.


:bug: Fix issue #223, ensure trailing forward slash baseURL during search index build

Fix to issue #223.
Should now hopefully verify that baseURL contains a trailing forward slash. This fixes my personal issue with search not working, hopefully it doesn't break anyone else's search.

Thanks for this fix, @eliaserland. I've tested the change and it works. I can't see any reason why this would break any other build configurations as the base URL should always end in a forward slash so I'll go ahead and merge this in.


Fixing docs

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@bonclay7 Fixed the issues pointed.


How to access the browser console and/or open DevTools?

Hi! So there has already been an SO question on this topic regarding WebView2. And the answer was: There is a method to do so.
https://stackoverflow.com/questions/64981617/how-to-open-devtools-from-code-in-webview2
The method is called OpenDevToolsWindow() and is part of the Web32 CPP API. You can find it under https://docs.microsoft.com/en-us/microsoft-edge/webview2/reference/win32/icorewebview2?view=webview2-1.0.664.37#opendevtoolswindow). Is there a waywith the current release of flutter-webview-windows to call this method, perhaps via the MethodChannel you established?

Closing this: There has been a merged PR for this: https://github.com/jnschulze/flutter-webview-windows/pull/102

Reopen: The merged PR #102 has no release version. So we cannot open the Devtools.

I've just published version 0.1.7.


Add Material Design Icons to documentation

Please list Material Design Icons in https://getbootstrap.com/docs/4.4/extend/icons/
The maintainer has to choose to add this listing under Preferred or under More options
Motivation for supporting these icons is the combination of the design quality (based on Material Design) and the quantity obtained by remixing.

You can always make a PR and someone will review.

Google Material icons is added in https://getbootstrap.com/docs/4.4/extend/icons/

Google Material icons is added in getbootstrap.com/docs/4.4/extend/icons

Indeed, closing this.


[Snyk] Security upgrade @angular-devkit/build-angular from 0.1102.19 to 13.2.0

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to fix one or more vulnerable packages in the `npm` dependencies of this project.
Changes included in this PR

Changes to the following files to upgrade the vulnerable dependencies to a fixed version:

frontend/package.json

Vulnerabilities that will be fixed
With an upgrade:

Severity
Priority Score (*)
Issue
Breaking Change
Exploit Maturity

658/1000  Why? Proof of Concept exploit, Recently disclosed, Has a fix available, CVSS 5.3
Regular Expression Denial of Service (ReDoS) SNYK-JS-SEMVER-3247795
Yes
Proof of Concept

(*) Note that the real score may have changed since the PR was raised.
Check the changes in this PR to ensure they won't cause issues with your project.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
🛠 Adjust project settings
📚 Read more about Snyk's upgrade and patch logic

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Regular Expression Denial of Service (ReDoS)

Checkmarx One – Scan Summary & Details – ff73b7da-e9e3-4124-98f4-1387612b3811
New Issues

Severity
Issue
Source File / Package
Checkmarx Insight

CVE-2022-23539
Npm-jsonwebtoken-0.4.0
Vulnerable Package

CVE-2022-23539
Npm-jsonwebtoken-0.1.0
Vulnerable Package

CVE-2022-23540
Npm-jsonwebtoken-0.4.0
Vulnerable Package

CVE-2022-23540
Npm-jsonwebtoken-0.1.0
Vulnerable Package

CVE-2022-23541
Npm-jsonwebtoken-0.4.0
Vulnerable Package

CVE-2022-23541
Npm-jsonwebtoken-0.1.0
Vulnerable Package

CVE-2022-25881
Npm-http-cache-semantics-3.8.1
Vulnerable Package

CVE-2022-25887
Npm-sanitize-html-1.4.2
Vulnerable Package

CVE-2022-3517
Npm-minimatch-3.0.4
Vulnerable Package

CVE-2022-36313
Npm-file-type-6.2.0
Vulnerable Package

CVE-2022-36313
Npm-file-type-5.2.0
Vulnerable Package

CVE-2022-36313
Npm-file-type-4.4.0
Vulnerable Package

CVE-2022-36313
Npm-file-type-3.9.0
Vulnerable Package

CVE-2022-36313
Npm-file-type-11.1.0
Vulnerable Package

CVE-2022-38900
Npm-decode-uri-component-0.2.2
Vulnerable Package

CVE-2023-28155
Npm-request-2.88.2
Vulnerable Package

CVE-2023-29017
Npm-vm2-3.9.11
Vulnerable Package

CVE-2023-29199
Npm-vm2-3.9.11
Vulnerable Package

CVE-2023-30547
Npm-vm2-3.9.11
Vulnerable Package

CVE-2023-32314
Npm-vm2-3.9.11
Vulnerable Package

CVE-2023-32695
Npm-socket.io-parser-4.0.5
Vulnerable Package

Cxc7705965-e0f0
<EMAIL_ADDRESS>Vulnerable Package

SQL_Injection
/routes/dataExport.ts: 30
Attack Vector

SQL_Injection
/routes/dataExport.ts: 14
Attack Vector

CVE-2022-41940
Npm-engine.io-4.1.2
Vulnerable Package

CVE-2023-0842
Npm-xml2js-0.4.23
Vulnerable Package

CVE-2023-26115
Npm-word-wrap-1.2.3
Vulnerable Package

CVE-2023-32313
Npm-vm2-3.9.11
Vulnerable Package

Missing_Encryption_of_Sensitive_Data
/data/datacreator.ts: 98
Attack Vector

CVE-2023-2251
Npm-yaml-1.10.2
Vulnerable Package

Use_of_Broken_or_Risky_Cryptographic_Algorithm
/Gruntfile.js: 73
Attack Vector

Fixed Issues

Severity
Issue
Source File / Package
Checkmarx Insight

CVE-2020-28469
Npm-glob-parent-3.1.0
Vulnerable Package

CVE-2021-23440
Npm-set-value-2.0.1
Vulnerable Package

CVE-2021-23449
Npm-vm2-3.9.3
Vulnerable Package

CVE-2021-23555
Npm-vm2-3.9.3
Vulnerable Package

CVE-2021-35065
Npm-glob-parent-5.1.2
Vulnerable Package

CVE-2021-35065
Npm-glob-parent-3.1.0
Vulnerable Package

CVE-2021-44906
Npm-minimist-0.2.1
Vulnerable Package

CVE-2022-21213
Npm-mout-1.2.3
Vulnerable Package

CVE-2022-24771
Npm-node-forge-0.10.0
Vulnerable Package

CVE-2022-24772
Npm-node-forge-0.10.0
Vulnerable Package

Cx347a3da7-ba99
Npm-node-forge-0.10.0
Vulnerable Package

CVE-2022-0122
Npm-node-forge-0.10.0
Vulnerable Package

CVE-2022-24773
Npm-node-forge-0.10.0
Vulnerable Package

Cxb41ee3b9-e4b0
Npm-adm-zip-0.4.16
Vulnerable Package

Client_DOM_Open_Redirect
/frontend/src/app/login/login.component.ts: 52
Attack Vector

Unprotected_Cookie
/routes/videoHandler.ts: 39
Attack Vector

Unprotected_Cookie
/routes/videoHandler.ts: 32
Attack Vector


Provide Guidelines on GSoC Application and Handling Funding

CDF Projects propose projects to Google Summer of Code (GSoC) which provides funding to selected projects. The Linux Foundation provides support accepting funding from GSoC and distributing them to projects. Ensure this process is documented so projects could receive support from the Linux Foundation.

Doc is available: https://github.com/cdfoundation/foundation/blob/main/CDF GSoC Guidelines.md
Closing the issue.


NoReverseMatch : 'pictures' is not a registered namespace

In the last 1.0rc2 update I came across the error "NoReverseMatch : 'pictures' is not a registered namespace", after comparing the last version with the previous one I noticed that a default configuration for the USE_PLACEHOLDERS was missing, so I was able to fix this by adding to the PICTURES in the file settings.py
PICTURES = {
"BREAKPOINTS": {
"xs": 576,
"s": 768,
"m": 992,
"l": 1200,
"xl": 1400,
},
"GRID_COLUMNS": 12,
"CONTAINER_WIDTH": 1200,
"FILE_TYPES": ["WEBP"],
"PIXEL_DENSITIES": [1, 2],
"USE_PLACEHOLDERS": False, <- fixed the problem adding this line
}

Hi @eduardo-victor,
Thank you for reaching out. I believe this is because you didn't set up the placeholder's URLs.
I think we need to improve both the documentation and error handling. Likewise, I believe a more verbose error message would be prudent.
I am curious, why didn't you set up the URL bit, and why aren't you using the placeholders in development?
Cheers!
Johannes

I'm using the library for student purposes, maybe I didn't understand how to set the URL bit.
I came across this "error" while trying to list images registered in an API with the DRF, in this way I managed to correct it, but I will study a little more about the library. However thanks for your attention :)
Cheers.

Hi @eduardo-victor, there are no wrong questions. I'll reopen the issue and try to improve the docs. Software adoption is crucial to the success of this project ;)

@eduardo-victor thanks again for bringing this to my attention. Version 1.0rc3 comes with a dedicated check for this as well as with an updated documentation.


feat: #2386 - added tests about localization parameters

Impacted file:

plural_translation_test.dart: added tests about localization parameters; simplified

What

Tests were added for all labels that currently need parameters.
If new labels with parameters appear, they need to be added there too.
Good news: the tests currently fail, for 6 languages.

Fixes bug(s)

Closes: #2386

Not sure how we fail fil while having 0% translations: https://crowdin.com/project/openfoodfacts/fil
══╡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK ╞════════════════════════════════════════════════════
The following TestFailure was thrown running a test:
Expected: contains '2080706050'
Actual: 'One product'
When the exception was thrown, this was the stack:
#4      main.. (file:///home/runner/work/smooth-app/smooth-app/packages/smooth_app/test/plural_translation_test.dart:214:11)
#5      main.. (file:///home/runner/work/smooth-app/smooth-app/packages/smooth_app/test/plural_translation_test.dart:18:42)
#6      testWidgets.. (package:flutter_test/src/widget_tester.dart:170:29)

(elided one frame from package:stack_trace)
This was caught by the test expectation on the following line:
file:///home/runner/work/smooth-app/smooth-app/packages/smooth_app/test/plural_translation_test.dart line 214
The test description was:
plural test fil
════════════════════════════════════════════════════════════════════════════════════════════════════

Not sure how we fail fil while having 0% translations: https://crowdin.com/project/openfoodfacts/fil

I didn't understand either, I did double-check, and at least for this label it's exactly the same as in English.
There are 3 languages that fail for user_list_length.
After investigations, it's because there's a specific way to deal with plurals in fil, lv and tl.
cf. https://github.com/dart-lang/intl/blob/master/lib/src/plural_rules.dart#L132-L139
/// The integer part of [_n]
int _i = 0;
/// Number of visible fraction digits.
int _v = 0;
/// The visible fraction digits in n, with trailing zeros.
int _f = 0;

PluralCase _fil_rule() {
  if (_v == 0 && (_i == 1 || _i == 2 || _i == 3) ||
      _v == 0 && _i % 10 != 4 && _i % 10 != 6 && _i % 10 != 9 ||
      _v != 0 && _f % 10 != 4 && _f % 10 != 6 && _f % 10 != 9) {
    return ONE;
  }
  return OTHER;
}

And my crazy int was<PHONE_NUMBER> (_v == 0 && _i % 10 != 4 && _i % 10 != 6 && _i % 10 != 9 is true, therefore it's like 1).
I've changed the value in my PR, and it works! I mean, other values still fail, but for good reasons!

══╡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK ╞════════════════════════════════════════════════════
The following TestFailure was thrown running a test:
Expected: contains 'の中ழ்'
Actual: 'Open Food Facts でこの製品を見る:'
(ja)
══╡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK ╞════════════════════════════════════════════════════
The following TestFailure was thrown running a test:
Expected: contains 'の中ழ்'
Actual: 'процентне співвідношення'
(uk)
id
══╡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK ╞════════════════════════════════════════════════════
The following TestFailure was thrown running a test:
Expected: contains 'の中ழ்'
Actual: 'Selanjutnya { source_name}'

Codecov Report

Merging #2412 (d045569) into develop (2ea0da3) will decrease coverage by 1.33%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           develop   #2412      +/-   ##
==========================================
- Coverage     8.86%   7.52%   -1.34%
==========================================
  Files          161     204      +43
  Lines         6623    9769    +3146
==========================================
+ Hits           587     735     +148
- Misses        6036    9034    +2998

Impacted Files
Coverage Δ

...kages/smooth_app/lib/widgets/attribute_button.dart
0.00% <0.00%> (-92.00%)
:arrow_down:

...s/smooth_app/lib/data_models/user_preferences.dart
8.73% <0.00%> (-23.57%)
:arrow_down:

packages/smooth_app/lib/themes/smooth_theme.dart
60.00% <0.00%> (-22.98%)
:arrow_down:

...p/lib/generic_lib/dialogs/smooth_alert_dialog.dart
15.29% <0.00%> (-18.92%)
:arrow_down:

...mooth_app/lib/data_models/product_preferences.dart
24.65% <0.00%> (-6.78%)
:arrow_down:

packages/smooth_app/lib/main.dart
14.40% <0.00%> (-3.49%)
:arrow_down:

.../smooth_app/lib/pages/onboarding/welcome_page.dart
0.00% <0.00%> (-3.13%)
:arrow_down:

.../smooth_app/lib/pages/onboarding/scan_example.dart
0.00% <0.00%> (-2.28%)
:arrow_down:

...p/lib/pages/onboarding/consent_analytics_page.dart
0.00% <0.00%> (-1.57%)
:arrow_down:

...smooth_app/lib/pages/product/new_product_page.dart
0.00% <0.00%> (-0.88%)
:arrow_down:

... and 204 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4aa3671...d045569. Read the comment docs.

@teolemon For the record, you fixed pct_match in uk as "".
Of course it failed, because we expect to see the percentage, like in English: "{percent}% match".
That's even the purpose of this PR.
You were testing me, fair enough ;)
In general, a no brainer fix would be to put the English translation.
Feel free to approve this PR.


Netherside Configuration

I am trying to configure the netherside for the phase spell and my world is not named the default world. I cannot manage to get the text configuration correct for it to work could someone give me the exact text and what to replace with my world name.

It might be easier to do /mconfig editor spell phase - there will be a map of worlds there, change the ones that say world to your world name.

Please let me know if you were not able to get this working!


Add facades.Config.Set method

facades.Config.Set(map[string]any{
 "app.name": "local"
})

Hey @hwbrzzl, it this something you want to add in framework, I can see the Config interface but do you want to add it for Config?

Oh sorry @sidshrivastav , just missed this message. I reviewed this requirement and think just changing Add(name string, configuration map[string]any) to Add(name string, configuration any) in contracts/config/config/go is ok, then we can achieve:
facades.Config.Add("test", map[string]any{"a", "b"})
facades.Config.Get("test.a") // b
facades.Config.Add("test.test1", "c")
facades.Config.Get("test.test1") // c

If you have interesting in this, please take a look, thanks! @sidshrivastav

Sure, you can assign it to me. I'll work on it during the weekend.

Thanks! please enrich more unit tests like the above.

Hi @sidshrivastav , hope you have a great weekend.
FYI, we are going to release 1.10.0 in recent days, if there is a chance that merging this feature into master will be great.
There is the v1.10.0 upgrade guide:

I'll push the PR by tomorrow.


doc: Traffic Split

This GitHub issue is for fleshing out the OSM documentation around Traffic Split SMI policy:

[ ] Document Traffic Split (review existing docs) -- save the doc in ./docs/wip/traffic_split.md (?)

[ ] What are the various Traffic Split scenarios available?
[ ] What version of the Traffic Split SMI Spec is supported by v.08? What are all the options enabled by this version?
[ ] How should the Kubernetes Services be labeled?
[ ] What's the role of the apex/root service?
[ ] What are acceptable ranges for the weights?
[ ] Are there other services that integrate w/ OSM via TrafficSplit?

[ ] Create a small demo with sample apps and SMI showing how this feature works -- we already have a decent Traffic Split demo - create something small within this doc to show what the relevant SMI CRDs should look like

[ ] Pointers to other services' docs that work with SMI (Argo + SMI comes to mind)

[ ] List Common Issues

[ ] Create Troubleshooting Guide

[ ] Automate Troubleshooting Guide in pkg/troubleshooter (create appropriate functions) - alternatively create a GitHub Issue with the stub of the function that could be eventually created within pkg/troubleshooter package to automatically troubleshoot this feature.

@draychev @phillipgibson this issue needs a demo to be completed


Add Support for Spring Security Test

In Spring Security Test it's possible to mock a user with the annotation WithMockUser.
For example:
@WithMockUser("user")
void testAbout() {}

Unfortunately, this does not work with the VaadinWebSecurityConfigurerAdapter because there it uses request.getUserPrincipal() that is not set.
It would be great if you could enhance the Spring Security support of Karibu Testing to work with Spring Security Test.

Thank you :+1:  The reason for that is that VaadinWebSecurityConfigurerAdapter uses ViewAccessChecker under the hood, which uses ServletRequest.getUserPrincipal() and ServletRequest.isUserInRole() to check whether there is an active user and whether he has the right to see given page.
In a Spring Boot runtime environment, everything is wired up in a way that ServletRequest.isUserInRole() is hooked to Spring Security; however in Karibu-Testing environment this wiring is not activated automatically.
Probably the best way to fix this would be for Karibu-Testing Spring module to automatically initialize the ServletRequest.isUserInRole() closure to examine the current user using SecurityContextHolder.getContext().getAuthentication()...

Also see #47 and https://github.com/mvysny/vaadin-spring-karibu-testing for more details.

The problem is that Karibu-Testing Spring module doesn't depend on spring-security-core and therefore can't access SecurityContextHolder since it's not on compile classpath. This could perhaps be solved by reflection and runtime dependency only, or by adding a new karibu-testing-v10-spring-security artifact (this one sounds better). However, I'm not 100% sure that the code at https://github.com/mvysny/karibu-testing/issues/47#issuecomment-990637659 is 100% correct: e.g. I'm not sure whether the ROLE_ prefix works correctly, and whether the whole setup works with Spring Security interceptors when calling bean methods. Would be great to have a Spring guru to verify that the code works properly with Spring Security and there is no fundamental problem.

I've enabled method level security in my app
@EnableGlobalMethodSecurity(prePostEnabled = true, securedEnabled = true, jsr250Enabled = true)
And I can confirm that Spring Security works.
This is a secured service
@Service
public class SecuredService {

    @RolesAllowed("SUPER_USER")
    public void onlyForSuperUser() {
        System.out.println("onlyforSuperUser");
    }
}

If I use the correct role in the login method it works fine.
<EMAIL_ADDRESS>"", List.of("SUPER_USER"));

With the wrong role, access is denied
<EMAIL_ADDRESS>"", List.of("ADMIN"));

results in
org.springframework.security.access.AccessDeniedException: Access is denied

About the ROLE_ prefix.
There is a good article that explains it:
https://ducmanhphan.github.io/2019-02-20-Problem-about-role-name-in-Spring-Security/
So it's ok that you add it in the login method for the RoleVoter:
new SimpleGrantedAuthority("ROLE_" + it))
But since Spring Security 4 it's optional when using to check the role
@RolesAllowed({"USER", "ADMIN"}) and @RolesAllowed({"ROLE_USER", "ROLE_ADMIN"})
work both.
But testing this I realized that Vaadin does not support it! So with Vaadin only the first without the ROLE_ prefix works.
I don't know if this is a bug but it may confuse Spring Security users.

I have this little snippet in my mock vaadin setup:
val request = VaadinServletRequest.getCurrent().request as MockRequest
        val authentication = SecurityContextHolder.getContext().authentication
        if(authentication!=null  && authentication.isAuthenticated){
            request.userPrincipalInt = authentication.principal as Principal
            request.isUserInRole = { principal: Principal?, role: String? ->
                val userDetails = SecurityContextHolder.getContext().authentication.principal as UserDetails
                userDetails.authorities.map { it.authority }.contains("ROLE_${role}")
            }
        }

A great solution is also mentioned at https://github.com/mvysny/karibu-testing/issues/180#issue-2740945146 . I'll keep this ticket open until I can properly take a look at this; but I can definitely update README.md to mention these solutions.


api: default log driver goes under task defaults

In general, we'd like to avoid pollute the top-level space of the
cluster configuration with specific items. This parameterizes task
creation using a TaskDefaults subsection. It is arguable that this is
part of the orchestrator, but it is possible to allow task creation
outside of the orchestrator in the future.
Supercedes #322. Wait till we merge docker/swarmkit#1185 before merging this.
Signed-off-by: Stephen J Day<EMAIL_ADDRESS>

@thaJeztah @vdemeester Ok, so we have consensus on swarmkit and docker/swarmkit#1185 has been merged.
Thanks!

LGTM 🐸

LGTM, thanks!
@stevvooe good to merge? (feel free to press the button)


JailBreak detection feature is not working

Double check why JailBreak feature is not working.
After review seems that East US region does not support it.

It worked for me, but I did have to add the required appsettings.json entry:
"JailbreakDetectionEndpoint": "contentsafety/text:detectJailbreak?api-version=2024-02-15-preview"
This setting comes from the API management website provided after configuring the resource:

Then:

Then:

It was a bit difficult to find out how to configure it properly, as it is not described in the documentation.

This issue was due to a temporary error in the platform. It should be solved by now. Closing this issue.
Thank you!


Update pnp-provisioning-engine-and-the-core-library.md

typo
Category

[ ] Content fix
[ ] New article
Related issues: fixes #X, partially #Y, mentioned in #Z

For the above list, an empty checkbox is [ ] as in [SPACE]. A checked checkbox is [x] with no space between the brackets. Use the PREVIEW tab at the top right to preview the rendering before submitting your issue.
(DELETE THIS PARAGRAPH AFTER READING)

What's in this Pull Request?

Please describe the changes in this PR. Sample description or details around bugs which are being fixed.
(DELETE THIS PARAGRAPH AFTER READING)

Guidance

Please update this PR information accordingly. We'll use this as part of our release notes in monthly communications.
Please target your PR to 'master' branch. Released documents are in live branch.
(DELETE THIS PARAGRAPH AFTER READING)

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/solution-guidance/pnp-provisioning-engine-and-the-core-library.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

thx Luis, a valid typo to fix.


beta-10

Nuget package appears to be broken?
Visual Studio 16.7.2:

Try checking the "include pre releases" box.

Do'h ..


fix(Dockerfile): install curl for healthcheck

resolves #1202
The container no longer stays unhealthy.

Thank you for the fix!


Support multiple order by clauses

Currently when we use multiple order by clauses or use comma separated fields as an argument to order by clause, only first one is respected
<!-- #query task  where tags=["p0", "p1"] order by deadline order by tags desc where done=false render [[template/task]]-->

Will only order by deadline and not tags

I have PR ready for this. Just need to clean it up


Increase Nonce Limit on AES GCM

According to IETF RFC 5084 (https://tools.ietf.org/html/rfc5084) the nonce byte size ranges from 12-16 with the default being 12 bytes. The problem here is some things outside of my control are being sent with a 16 byte nonce byte size. My request is that the nonce byte size MaxSize be set to 16 and not the standard of 12.

The most likely reason is conformance with NIST SP 800-38D, section <IP_ADDRESS>:

For IVs, it is recommended that implementations restrict support to the length of 96 bits, to
promote interoperability, efficiency, and simplicity of design.


[Type] fix parameters name in union function.

Pull Request Test Coverage Report for Build 531163172

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 528778503:
0.0%

Covered Lines:
2092

Relevant Lines:
2092

💛  - Coveralls


webrtc-audio-processing: Fetch patch for big-endian support

Description of changes
Related to #253715, but I see no reason for this to depend on any changes from it.
From https://bugs.freedesktop.org/show_bug.cgi?id=95738, was migrated to https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/issues/127.
Fixes building for i.e. powerpc64-linux, natively & pkgsCross.ppc64.
Things done

Built on platform(s)

[x] x86_64-linux
[x] powerpc64-linux
[x] x86_64-linux -> powerpc64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

@ofborg build pkgsCross.ppc64.webrtc-audio-processing


Batch query eval

good to go from my side
USAGE:

constructor:

list of model names from huggingface + "bm25" if you want to use it.
list of weights for each model to use in the weighted sum (see QueryEval.score())

load_dataset: given a DataFrame (following the format of .dataset.load_corpus), compute embeddings for each model and index the corpus for the BM25 model if specified.
save_to_cache: save the embeddings for the models and the indexed corpus for the BM25 model
load_from_cache:
score: given a list of queries $(q_1,q_2,\dots,q_n)$ and a list of documents $(d_1,d_2,\dots,d_n)$, compute

In words, the score function takes a bunch of query-document pairs, and for each such pair, it computes a list of similarity scores (in the range $[0,1]$) and takes their weighted average.
NOTE:

The score function approximates the likelihood that a given query refers to a given document. It does not "rank" the documents in any traditional way.
For dense models, we don't want to compute similarity scores for all documents in the corpus because it is expensive. Instead, we take the cosine similarity (scaled to $[0,1]$) and regard it as it if were a probability.
We cannot do the same with the BM25 score, because its output domain is unbounded. So, we have to score all documents in the corpus, compute softmax and take the value computed for the given document.
Currently, we control the weights and the list of models that we use in the constructor. In the future, we might want to consider fitting the weights to the training set (because, since cosine similarity $\neq$ probability, the scores might not be on the same scale still. A good way to overcome this is by fitting the scores on actual query-document pairs)

Will fix in the morning

got rid of dataframes and simplified to a single dense model


unreadable paragraph

Description
Incorrect line spacing or overlapping of text
(Optional:) Please add any files, screenshots, or other information here.
No response
(Required) What is this issue most closely related to? Select one.
Choose One
Internal issue ID
828593c8-146a-4444-81d4-8cc5b0956960
Paper URL
https://arxiv.org/html/2401.05654v1?utm_source=The Medical Futurist Newsletter
Browser
Chrome/<IP_ADDRESS>
Device Type
Desktop


Cursor is blinking while I am using zsh on WSL

Steps to reproduce
pwsh
wsl
[backspaceKey]

Expected behavior
nothing will happen, the cursor will not move any more

Actual behavior
the cursor is always blinking, it moves to next line then move back.

I an not sure is it a bug of PowerShell, when I use cmd it will happen.
when I use the terminal directly in VisualStudioCode, it will also happen,
but when I use it in VSCode WSL - remote , it won't happen.

Environment data

Name                           Value
----                           -----
PSVersion                      7.0.2
PSEdition                      Core
GitCommitId                    7.0.2
OS                             Microsoft Windows 10.0.19041
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

I an not sure is it a bug of PowerShell, when I use cmd it will happen.
when I use the terminal directly in VisualStudioCode, it will also happen,
but when I use it in VSCode WSL - remote , it won't happen.

If it happens in cmd too, then it's likely not a powershell issue. When running VSCode WSL remote, the terminal runs directly in the WSL distro, so it's different from running wsl from within cmd or powershell.

I an not sure is it a bug of PowerShell, when I use cmd it will happen.
when I use the terminal directly in VisualStudioCode, it will also happen,
but when I use it in VSCode WSL - remote , it won't happen.

If it happens in cmd too, then it's likely not a powershell issue. When running VSCode WSL remote, the terminal runs directly in the WSL distro, so it's different from running from within cmd or powershell.wsl

So how to solve it. Is it a bug of WSL?

I don't really know where to report the issue. You should definitely try reporting it to WSL, or open an issue in https://github.com/microsoft/terminal asking about this, and maybe they can point you to the right place.

Thank you


Display status in chats

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/23134
PROPOSAL:
Tests

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

Before you need setup the status:

Log in using account A.
Navigate to Settings -> Profile -> Status.
Create a new status for account A.
Also, you need to enable betas 'customStatus'

Viewing Status in Chat:

Log in using account B.
Open a chat where account A is a participant.
Verify if the status of account A is displayed next to their name.

Hovering over the Status (Web only):

Hover over the status icon next to account A's name.
Check if the status text is displayed as a tooltip (if one was set in ).

Checking Status in Direct Chat:

Open a direct chat with account A.
Ensure that the status is displayed next to account A's name.

Status Expiry Tooltip:

Hover over the status icon (or text) for account A.
The tooltip should display an expiration note, e.g., "(Until tomorrow)". This indicates that the status is valid until the end of the current day.
Note: In future releases, the ability to change the expiration duration will be added.

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android
![image](https://github.com/Expensify/App/assets/48593211/6d4829f7-a761-4c09-bd8a-399ca59116df)

@stitesExpensify Can you add me to customStatus beta

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web & Desktop
https://github.com/Expensify/App/assets/85645967/bfcde883-2ae6-4464-b7d5-5e6dda9b3125

Mobile Web - Chrome & Mobile Web - Safari
https://github.com/Expensify/App/assets/85645967/b0176630-6b07-4020-b212-0fec999a3d4d

iOS & Android
https://github.com/Expensify/App/assets/85645967/d774c257-5180-43a0-98ba-bdac5ffa4bf4

@stitesExpensify

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/stitesExpensify in version: 1.3.55-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/stitesExpensify in version: 1.3.56-0 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/roryabraham in version: 1.3.56-24 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅


Add up-to-date Android tutorial

This is a WIP PR for two reasons.

There might be things to fix here. I'm fine taking time fix them.

Also, we don't want to merge this PR until we're happier with briefcase & toga's Android support.

Feedback welcome!!!

Hey @freakboy3742  -- I don't have permission to formally request your review, so I will do so here in this comment. Cheerio!

Thanks for the review! I'll adjust and provide a follow-up.

Requesting re-review. I think this addresses all requested changes.
Note that the screenshots of the emulator starting don't have any phone skin on them. I'm OK with that for now. The way we download the emulator doesn't currently download phone skins, and once we fix that, we can take fresh screenshots.

Requesting re-review, but we'll probably want to also follow up over text chat and/or video chat. Thankfully we have our regularly-scheduled call today.


[bug] UI thread blocking

Describe the bug
When clicking the button quickly, there is a probability that it will cause the program to crash
I only added one line of code after generating the code using the create-tauri-app

Reproduction
No response
Expected behavior
No response
Full tauri info output
[✔] Environment
    - OS: Windows 10.0.26100 x86_64 (X64)
    ✔ WebView2: 128.0.2739.54
    ✔ MSVC: Visual Studio Community 2022
    ✔ rustc: 1.80.1 (3f5fd8dd4 2024-08-06)
    ✔ cargo: 1.80.1 (376290515 2024-07-16)
    ✔ rustup: 1.27.1 (54dd3d00f 2024-04-24)
    ✔ Rust toolchain: stable-x86_64-pc-windows-msvc (default)
    - node: 20.12.0
    - pnpm: 9.1.3
    - yarn: 1.22.22
    - npm: 10.8.2

[-] Packages
    - tauri 🦀: 2.0.0-rc.8
    - tauri-build 🦀: 2.0.0-rc.7
    - wry 🦀: 0.42.0
    - tao 🦀: 0.29.1
    - @tauri-apps/api : 2.0.0-rc.4
    - @tauri-apps/cli : 2.0.0-rc.10

[-] Plugins
    - tauri-plugin-shell 🦀: 2.0.0-rc.3
    - @tauri-apps/plugin-shell : 2.0.0-rc.1

[-] App
    - build-type: bundle
    - CSP: unset
    - frontendDist: ../dist
    - devUrl: http://localhost:1420/
    - framework: React
    - bundler: Vite

Stack trace
No response
Additional context
No response

This issue may cause occasional crashes while using the software

Closing in favor of #10546


chore(deps): update dependency ts-loader to v7

This PR contains the following updates:

Package
Type
Update
Change

ts-loader
devDependencies
major
6.2.2 -> 7.0.0

Release Notes

TypeStrong/ts-loader
v7.0.0
Compare Source

Project reference support enhancements - thanks @sheetalkamat!
Following the end of life of Node 8, ts-loader no longer supports Node 8 BREAKING CHANGE

Renovate configuration
:date: Schedule: At any time (no schedule defined).
:vertical_traffic_light: Automerge: Disabled by config. Please merge this manually once you are satisfied.
:recycle: Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "rebase!".
:no_bell: Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

Available now for Enterprise: Renovate Pro with real-time webhook handling and priority job queue.

:tada: This PR is included in version 5.0.22 :tada:
The release is available on:

v5.0.22
GitHub release

Your semantic-release bot :package::rocket:


[Release 1.24] Update flannel and kube-router

Proposed Changes

Backport for #7039
Types of Changes

Verification

Testing

Linked Issues

#7062
User-Facing Change

Further Comments

Codecov Report
Patch coverage has no change and project coverage change: -0.01 :warning:

Comparison is base (c14436a) 9.63% compared to head (350b7af) 9.63%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@               Coverage Diff               @@
##           release-1.24   #7063      +/-   ##
===============================================
- Coverage          9.63%   9.63%   -0.01%
===============================================
  Files               148     148
  Lines             10775   10777       +2
===============================================
  Hits               1038    1038
- Misses             9519    9521       +2
  Partials            218     218

Flag
Coverage Δ

unittests
9.63% <0.00%> (-0.01%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/agent/netpol/netpol.go
0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


another update, another changelog

now the people can be knowledged

OH Shit i forgot this yeah thanks LOL i gotta stop forgetting this


Fix generate results

Codecov Report

Merging #426 (83be2f1) into main (147cc8d) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #426      +/-   ##
==========================================
- Coverage   53.74%   53.72%   -0.02%
==========================================
  Files          44       44
  Lines        2709     2710       +1
  Branches      515      516       +1
==========================================
  Hits         1456     1456
- Misses       1143     1144       +1
  Partials      110      110


[Integration] Publish pocketpy to vcpkg

Description
vcpkg is a cross-platform package manager for C and C++ developers.
It would be useful for users if they can install pocketpy via it.
Our goal

Make necessary changes and submit pocketpy to vcpkg.
Add document about how to install pocketpy via vcpkg.

Hey, I figured out how to publish this package on vcpkg, you have to open a new PR at https://github.com/microsoft/vcpkg

Yes. You will (replace me) submit that PR at https://github.com/microsoft/vcpkg and add docs into pocketpy repo.


cca upgrade fails with "cannot install org.chromium.storage" without storage permission

I thought I made it work with plugins that are forced to install, but its failing for Glenn

I am unable to reproduce this with the latest cca (0.6.0-rc1).  I created a new app, add the "notifications" permission only, then ran upgrade.  All the required/dependent plugins were installed without issue.


[Feature]: FlashAttention 3 support

As you know, flashatten3 promises 1.5x~ improvements
Is there any plan for support? Thanks！
https://github.com/Dao-AILab/flash-attention/commit/7ef24848cf2f855077cef88fe122775b727dcd74

@byshiue @nv-guomingz @nv-hwoo @juney-nvidia @AdamzNV @kaiyux @Shixiaowei02

Is this feature under development? Has there been any progress?

It's currently under consideration, but development hasn't begun yet.

@AdamzNV  I don't understand how an algorithm that you've already implemented the 2nd version of, that provides 1.5x speed boost, can still be under "consideration"

@avianion FA3 is nothing new except for utilizing hopper features (i.e. warp specialized kernels with TMA + GMMA). And this has already been implemented in TRT-LLM since the first public release.

We have also done some benchmarks, which shows TRT-LLM FMHA kernels are faster in most cases (especially for longer sequence lengths). You are free to compare the performance. And let us know if you find cases that TRT-LLM is much worse. Thanks.
Besides, we have much faster FP8 FMHA implementation (note that our implementation still uses per-tensor scales, so it might not be a fair comparison).

@PerkzZheng Thank you for your insights. Can you please share some open-source link for benchmarking that you mentioned above?
Also, when I compare TRT-LLM FMHA kernel (fmha_v2_flash_attention_fp16_64_64_S_qkv_256_causal_tma_ws_sm90_kernel) for input=16384, BS=1, the TFLOP/sec are almost the same as compared to Original FA V3 on H100. Can you please share a simple script to benchmark Trt-LLM FMHA Kernel or some insights if I missed anything. Thank you!

@usajid14
you might want to try with head size 128/256 which should have better performance, but FA3 might have been updated so what we have collected is a bit out of dated. Let me know if there are cases that trtllm kernels are much worse. Thanks.


Support for AES

Any plans for supporting the method 0x6F10701 known as 7zAES?
The package https://github.com/nicholastoddsmith/aesrw provides an AES reader aesrw.NewReader that could be used. The only missing part would be generating the AES key out of the user-provided password.
The key function is a deviation of the of SHA256 with multiple rounds. The C implementation is here: https://github.com/kornelski/7z/blob/a6e2c7e401a3e5976e8522de518a169b0d8a7fac/CPP/7zip/Crypto/7zAes.cpp#L37

@Kleissner Apologies, I've only just seen this.
On first glance it seems pretty easy to implement. I'll see what I can do.

@Kleissner I've now added this.
You can use SetPassword() on the reader, or use the SetPasswordCallback() function to set a callback that you can use to ask an end-user for input when decryption is required etc.
Closing this now. Feel free to re-open or raise another issue if there's a problem with this implementation.


Update MD file on new branch 2017-11-28_23-29-59

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

split/content1.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Hack to get around using sleep

Hello : )
Could you check this out @arun3688

@JKRT , It looks good

@JKRT , It looks good, Do you think using of global variable is a good idea ?

It's on purpose to trick the compiler
It seems to work on my machine but I am not sure that it does on all machines. I have yet to find info on why Julia would optimize away the other check, so I figured that this could be a way of resolving the issue. Another option would be to write an external C function since Julia cannot optimize across shared libraries. Still, that would be more work

@JKRT i think this is fine. I hope you are working on Linux


Handle user not created error during ticket purchase

There's a callback handler that is triggered when the user logs in to add the user to the database. if this fails then the user isn't added to the user table and the FK is violated when they try to buy a ticket.
a better experience would be to add the user to the user table as needed during ticket purchase to prevent this error from impacting the demo

migrated to 1852575


Make executions unique

Right now, executions create a folder with name of task/test case - which is overriden from any following execution. Make the execution unique.

Close #7


Extractor specifying type of output (meta)-data

Following up from the ELN Roundtable, an important point was raised, that there should be a way to force the Extractor to only return metadata.
In my understanding, this is composed of three steps:

allowing downstream to filter Extractors which return meta-only, or meta+data,
allowing Extractor writers to specify both meta-only and meta+data usages in a simple way,
defining what the meta part really is, which is most likely out of scope of this WG.

The short and simple way to do this would be to extend the usage schema to indicate whether a given entry returns meta-only or meta+data. However, this might require two usages for each Extractor.
Tagging @steffenbrinckmann

Closed by #33

Riffing on this, now we have the API harness that can deal with pandas/xarray objects, it would be nice to allow extractors to specify generic packages that are required to be installed to understand the outputs. Currently we just have a couple of defined "common" formats but probably saying you need pandas/numpy/xarray or w/e, would be helpful, could also be extended to cover the idea of returning raw JSON.

Just thinking about this in terms of concrete next steps for schemas to support/encourage, one that might map quite nicely to some of our exisiting filetypes are the allotrope simple models for certain techniques (which are semantic JSON schemas), e.g., powder XRD: https://gitlab.com/allotrope-public/asm/-/blob/main/json-schemas/adm/x-ray-powder-diffraction/REC/2021/12/x-ray-powder-diffraction.embed.schema.json I'm not sure how widely these are used in academia atm but there's definitely industry buy-in. There's lots of a gaps (e.g., this XRD schema doesn't define peaks...) but might be a starting point (TGA for example has peaks defined: https://gitlab.com/allotrope-public/asm/-/blob/main/json-schemas/adm/thermogravimetric-analysis/REC/2021/12/thermogravimetric-analysis.schema.json)


fix: show loading sign aligned better

[x] maybe change to showing loading sign below header as a progress bar

already done


docs: fix output.inlineStyle example

maybe 1KB here is 1024Bytes
Summary
Related Links

Checklist

[x] Tests updated (or not required).
[x] Documentation updated (or not required).

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks ❤


bump version for release

Release #82 ? 🚀

sounds good - I'll add the tag to releases now. Can you bump master to dev0?


The time complexity of Binary Search Tree is not precise.

The Time Complexity for Binary Search Tree (BST) basic operations (Insert, Remove and Search) is not O(log n) if the BST is unbalanced (is O(logn) only when we are talking about Balanced BST such as AVL and Red-Black). The correct time complexity would be O(h) where h is the height of the BST. It is h because the BST may become skewed as the following image.

Well I'II look into this and get back to you


Drag and drop files not working

VSCode Version: Code - Insiders 1.15.0-insider (7bb3b89031cbce46536ba870868d889d639e12f1, 2017-07-11T17:55:51.921Z)
OS Version: Windows_NT x64 10.0.15063
Extensions:

Extension
Author (truncated)
Version

html-snippets
abu
0.1.0

markdown-toc
Ala
1.5.5

Bookmarks
ale
0.15.2

vscode-color
ans
0.4.1

unique-lines
bib
1.0.0

npm-intellisense
chr
1.3.0

path-intellisense
chr
1.4.2

vscode-eslint
dba
1.2.11

githistory
don
0.2.1

tslint
eg2
0.16.0

vscode-npm-script
eg2
0.2.0

react-native-react-redux
EQu
1.0.1

auto-close-tag
for
0.4.3

auto-rename-tag
for
0.0.14

react-jest-vscode-snippets
jal
0.0.3

search-node-modules
jas
1.1.1

vscode-styled-components
jpo
0.0.7

code-stats-vscode
juh
1.0.7

tag-rename
kri
0.2.1

graphql-for-vscode
kum
1.4.2

node-module-intellisense
lei
1.3.0

VBScript
lug
0.0.1

vscode-jade-snippets
mrm
1.0.1

vscode-pugbeautify
mrm
1.0.2

editorconfiggenerator
nep
0.2.1

prettier-now
rem
1.3.1

view-in-default-application
see
3.3.0

code-settings-sync
Sha
2.8.2

vba
spe
1.0.17

language-stylus
sys
1.7.3

vscode-react-redux-snippets
tha
0.3.3

bootstrap4-vscode
the
2.3.3

write-good-linter
tra
0.0.3

lorem-ipsum
Tyr
1.0.0

vscode-wakatime
Wak
1.1.12

JavaScriptSnippets
xab
1.4.1

(3 theme extensions excluded)

Steps to Reproduce:

Install latest VSCode insiders
Try to drag and drop a file in the explorer

Reproduces without extensions: Yes/No

I can reproduce (in insiders only). @sandy081 could this be a regression from your DND work of sections?

@bpasero Yes this is caused from that. Looking into it.

It seems tree view is listening on window for drop and split view is stopping the event. @joaomoreno provided the fix in tree view to listen on tree element for drop.


Simplify full broadcast

This PR simplifies full like ops that can be fused into broadcast ops, such that we can enable constant folding these ops in other situations to fix various issues we've seen with dynamic models.
This also refactors the SimplifyExpr pass somewhat to ease the addition of future patterns.
@vinx13 @jwfromm @icemelon9

Thanks @mbrookhart @masahi


Curt branch

Issue #, if available:
Description of changes:
Made description changes in notebooks 3 and 4. Included a confusion matrix in notebook 4.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Could you please PR to sagemaker-soln-lcsp branch instead of main?


Infra: Rethink infra.Verifier interface

The With.. methods on the infra.Verifier interface feel odd.
After merging the new trust store we should revisit and get rid of them.
At the same time, we should get rid of the *proto.SignS in the arguments, as it is wire format.

not actionable


thuang-update-FE-precommit

Description
Remove husky and lint-staged from npm, so we consolidate to using pre-commit to check for style formatting (prettier in FE)
Issue
N/A
Test plan

Run pre-commit install
Make a file change in ts/src in any of the formats here javascript,jsx,ts,tsx,markdown,html,scss,css,yaml
If prettier catches and autofixes any error, pre-commit will fail and you will be able to inspect the unstaged fixed files before you commit them
NOTE: pre-commit made an explicit design decision to NOT allow auto-committing auto fixed files. Github discussion here

so to start using this pre-commit hook would we have to install npm?

No need! Just pre-commit install to install this new hook and it should just work 👌
Hmm yeah for check-style, I see that backend's Make command uses the same too (make backend-check-style, so I'm not sure where we should maintain the consistency 😆
I don't have a strong opinion in this case!


Missing readmes

Hiya, these are the missing readmes that Rachael mentioned in the readme PR. Most of them were actually here already, so pay close attention to "Unique value renderer" and "feature layer show attributes", which are new. Thanks!

@TADraeseke thanks for the suggestion. Unfortunately this is the sample without a common design or implementation on other platforms---I don't know if you saw the chat.


Add create_db.Rmd

This PR adds pipeline create_db.Rmd which creates a sqlite database file with two tables:

occ_be_all: an exact copy of the text file with GBIF occurrences. with ALL columns
occ_be: a subset of columns AND filtered occurences based on occurreceStatus and issues

The reason to have two tables is that there is no way to DROP columns in sqlite. Moreover, removing the big table after creating the smaller one means calling the VACUUM operator which takes a lot of disk space and computational time.
When we will solve the bug in inborutils::csv_to_sqlite() (see https://github.com/inbo/inborutils/issues/42) I can just use one table only and using DELETE to filter occurrences. At the moment, we can take this solution and go further, I think.

I close this PR as we started to work on PR #6.


comby ignores files in current dir or explicitly provided dir when its hidden

Describe the bug
When using templates and the current directory is a hidden directory (or the -d dir is hidden) comby ignores the files.
Reproducing
❯ pwd
/Users/tekumara/code/myapp/.teamcity
❯ ll
total 40
-rw-r--r--  1 tekumara  staff   4.5K 24 Jun 11:06 settings.kts
❯ comby -config ../comby-patch-settings.toml -f .kts -stats
{
  "number_of_files": 0,
  "lines_of_code": 0,
  "number_of_matches": 0,
  "total_time": 40.49396514892578
}
❯ cd ..
❯ pwd
/Users/tekumara/code/myapp
❯ comby -config ../comby-patch-settings.toml -f .kts -stats -d .teamcity
{
  "number_of_files": 0,
  "lines_of_code": 0,
  "number_of_matches": 0,
  "total_time": 40.49396514892578
}

Expected behavior
When using templates, and the current dir is a hidden directory, or a hidden directory is explicitly provided via -d then comby should work on this files.
Additional context
comby 1.8.1

A work around whilst there's no fix is to provide an empty template and the explicit file names, which produces a warning but will work on the files in the hidden directory:
❯ comby -config comby-patch-teamcity.toml -matcher .txt -f .kts "" "" .teamcity/* -stats
WARNING: Templates specified on the command line AND using -templates. Ignoring match
      and rewrite templates on the command line and only using those in directories.
....
{
  "number_of_files": 1,
  "lines_of_code": 285,
  "number_of_matches": 0,
  "total_time": 92.39006042480469
}

Thanks--looks like this conflicts with --exclude-dir which by default excludes any directories starting with ..
When a flag specifies -d explicitly, I agree it should just work.
In the mean time you can probably use the workaround --exclude-dir "" (didn't check, but it should work)

Thanks for looking into this! When I try -exclude-dir "" I get:
Error parsing command line:

  failed to parse -exclude-dir value "".
  (Failure "Command.Spec.Arg_type.comma_separated: empty list not allowed")

For usage information, run

  comby -help


[Tech Insights] Run checks for multiple entities in a single request

Feature Suggestion
We built some custom pages to display information from the Tech Insights plugin, It's essentially a dashboard of all checks and the overall progress across the org, very similar to what Spotify has internally from what I've seen on some videos. Things like: how many services are on Python 3?
We have 300+ services and the way we do it today is to run the POST tech-insights/checks/run/:namespace/:kind/:name for each service, but that essentially means 300+ HTTP requests from the browser, which is not ideal.
I'd like to suggest a new endpoint which would accept multiple entities in a single request, it'd be far more efficient for this scenario.
Possible Implementation
I'm thinking of something like:
POST tech-insights/checks/run
Body:
{
  "entities": [ "component/default:foo", "component/default:bar" ], // this array could also support a list of object triplet kind/namespace/name
  "checks": [ "check1", "check2" ] // if empty, run all checks
}

Response would look similar to the single entity run, but an object keyed by the component identifier.
{
 "component/default:foo": [ check1result, check2result ... ],
 "component/default:bar": [ check1result, check2result ... ]
}

Benefit of the above is being able to get results of a specific entity with O(1)
Another alternative is to return an array:
[
  {
    "entity": "component/default:foo",
    "results": [ check1result, check2result ... ]
  },
  {
    "entity": "component/default:bar",
    "results": [ check1result, check2result ... ]
  }
}

Thanks @goenning!
Yeah, that makes perfect sense and would be a good addition to those endpoints. I think I like the return type from the API as an array of objects better than keyed results. That way we can add additional data into it without breakages. I do think that for FE manipulation the keyed shape is better so maybe do a quick keyBy loop on the FE API client.

Thanks for the inputs, I created a draft PR


file-type implied by measurement-type

In GitLab by @jakebeal on Sep 9, 2019, 10:16
The file-type field is generally implied by measurement-type; can we fill it in automatically?

In GitLab by @jakebeal on Oct 23, 2019, 16:09
assigned to @tramyn