Not found error

I downloaded model with script file.
When I train with cmd python tools/Train_pasta_HICO_DET.py --data 0 --init_weight 1 --train_module 2 --num_iteration 2000000 --model test_model, I meet error:
tensorflow.python.framework.errors_impl.NotFoundError: /home/ubuntu/project/Action_Recognition/HAKE-Action/Weights/faster_rcnn_resnet101_coco_2018_01_28; No such file or directory
Full error:
`
region_classification/cls_score_A/biases:0 0.0
region_classification/fully_connected/weights:0 -1.5816323e-06
region_classification/fully_connected/biases:0 0.0
region_classification/cls_score_L/weights:0 6.8772733e-06
region_classification/cls_score_L/biases:0 0.0
Restoring model snapshots from /home/ubuntu/project/Action_Recognition/HAKE-Action/Weights/faster_rcnn_resnet101_coco_2018_01_28/model.ckpt
WARNING:tensorflow:From /home/ubuntu/project/Action_Recognition/HAKE-Action/tools/../lib/models/train_Solver_HICO_DET_pasta.py:118: The name tf.model_variables is deprecated. Please use tf.compat.v1.model_variables instead.
Traceback (most recent call last):
File "tools/Train_pasta_HICO_DET.py", line 93, in
train_net(net, Trainval_GT, Trainval_N, output_dir, tb_dir, args.Pos_augment, args.Neg_select, args.Restore_flag, weight, max_iters=args.max_iters)
File "/home/ubuntu/project/Action_Recognition/HAKE-Action/tools/../lib/models/train_Solver_HICO_DET_pasta.py", line 279, in train_net
sw.train_model(sess, max_iters)
File "/home/ubuntu/project/Action_Recognition/HAKE-Action/tools/../lib/models/train_Solver_HICO_DET_pasta.py", line 201, in train_model
self.from_snapshot(sess)      # load from snapshot
File "/home/ubuntu/project/Action_Recognition/HAKE-Action/tools/../lib/models/train_Solver_HICO_DET_pasta.py", line 142, in from_snapshot
self.saver_restore.restore(sess, self.pretrained_model)
File "/home/ubuntu/anaconda3/envs/act_reg/lib/python3.6/site-packages/tensorflow_core/python/training/saver.py", line 1280, in restore
if not checkpoint_management.checkpoint_exists_internal(checkpoint_prefix):
File "/home/ubuntu/anaconda3/envs/act_reg/lib/python3.6/site-packages/tensorflow_core/python/training/checkpoint_management.py", line 366, in checkpoint_exists_internal
if file_io.get_matching_files(pathname):
File "/home/ubuntu/anaconda3/envs/act_reg/lib/python3.6/site-packages/tensorflow_core/python/lib/io/file_io.py", line 363, in get_matching_files
return get_matching_files_v2(filename)
File "/home/ubuntu/anaconda3/envs/act_reg/lib/python3.6/site-packages/tensorflow_core/python/lib/io/file_io.py", line 384, in get_matching_files_v2
compat.as_bytes(pattern))
tensorflow.python.framework.errors_impl.NotFoundError: /home/ubuntu/project/Action_Recognition/HAKE-Action/Weights/faster_rcnn_resnet101_coco_2018_01_28; No such file or directory
(act_reg) ubuntu@02203cbabcdc:~/project/Action_Recognition/HAKE-Action$ python tools/Train_pasta_HICO_DET.py --data 0 --init_weight 1 --train_module 2 --num_iteration 2000000 --model test_model
`
I suppose that I need some pretrained model here. Did you use pretrained model of resnet of tensorflow? Or can you provide your model in this step? I've seen other model in Download script, but none of them for this.

Closed. It is model from tensorflow zoo.

We have fixed the checkpoint path in the latest commit. Try to run the following command to download the checkpoints.
python script/Download_data.py 1IbR4kiWgLF8seaKjOMmwaHs0Bfwl5Dq1 Weights/res50_faster_rcnn_iter_1190000.ckpt.data-00000-of-00001
python script/Download_data.py 1-DbfEloN4c2JaCEMnexaWAsSc4MDlZJx Weights/res50_faster_rcnn_iter_1190000.ckpt.index
python script/Download_data.py 1vc5d3OwCtMtRgXq3Pj4_twpK4x3kjgT0 Weights/res50_faster_rcnn_iter_1190000.ckpt.meta
```.

Ok, this issue is closed. I meet another issue.  I think you should update this to Readme.md to avoid other people open the same issue. Tks.


Its not working as exoected its showing problem

Pls solve the problem I need to learn lots of concept from this application

We are pleased to inform you that the issue has been resolved. You can now continue to use our application as usual. Thank you for bringing this to our attention


search functionality improvements

original issue from @graphicdesign999

if someone's username is their artist name, and their artist name is absent from the release title field, searching “artistname releasetitle” returns no results, even if the releasetitle is spelled correctly
e.g. the release “Summer of Love (2024)" by the user "torus" (which is his artist name)
if you search "torus summer of love" it turns up nothing, because "torus" is absent from the release title, even though it’s his username
can we have the inclusion of a word that’s absent from the release title not cancel out the part that's actually in the release title (summer of love)?
@facing-n 's suggestion: either search each word separately or use a more search friendly db interface than we currently have

can we implement fuzzy matching for misspelled words?
...
images:

we can use the pg extension pg_tgrm to get weighted results as described here: https://www.freecodecamp.org/news/fuzzy-string-matching-with-postgresql/
eg:
SELECT
    *
FROM artists
WHERE SIMILARITY(name,'Claud Monay') > 0.4 ;

seems like a good option and could improve our search but also potentially complicate it.  I have a an example using this library that i was able to run on local db - see highlighted line below.  results in the behavior desired at the top of the issue - if the threshold is put too lower however, we get way too many results


Ability to cancel a deploy

Ability to cancel a deployment (deis deploy:cancel), but the question is will it create:

a new release in Deis (allows for doing a "log" but release is still kept around)
rollback in k8s (no log / audit trail)

This will require a CLI change as well

Like as in a git push or a deis pull? Would it be easier to handle an interrupted HTTP connection instead?

Either - It's to unclog things when Deployment is "in progress" but is not failing (no image pull problems, etc) and you realise you want to cancel it without having to potentially wait for the full timeout.
Handling an interrupted HTTP connection is a double edge sword since those can keep going just fine thanks to Deployment.

This issue was moved to teamhephy/controller#55


Clear Failing Hyper 3.0.2 on Windows 10

Hyper 3.0.2
Windows 10
Clear command failing

View -> Reload fails to solve the problem.
View -> Full Reload fails to solve the problem too.
View -> Reset Zoom fails to solve the problem too.
I killed the hyper.js terminal and restarted.  That cleared the screen.

Also documented in #3238. What happens if you use Window's cls command? Is clear a command from git-bash/windows linux subsystem?

cls works first try. :)

If you had an alias for clear it might be best to set that alias to cls for now until the WSL commands work nicely with hyper, I can't see that being too soon unfortunately.

I am facing the same issue with Hyper 3.0.2 stable. The clear command as well as the 'ctrl + L' shortcut fails to clear the screen buffer. It works sometimes though.


plot_dipole should iterate over layers

Currently, plot_dipole only accepts a layer to be a string. It should be possible to accept it as a list and then make different subplots for each layer if a list is provided. In that case, axes provided should also be a list
https://github.com/jonescompneurolab/hnn-core/blob/0406ed1a2b2335b786e83eb1698f27a5c3dcdadc/hnn_core/viz.py#L226-L228
This way user doesn't have to do a for loop for plotting the different layers

Will work on this now

go go go @chenghuzi !


Is there any method to check if subscription is present?

Right now when we call unsubscribe on stomp client, if subscription is not present client raises an error. So is there any way or method by which we can check if subscription is present before calling the unsubscribe method?
Sample code.
$ stomp_client.subscriber?('/topic/xyz') # or stomp_client.subscriber?('/queue/XYZ')
=> true # or false

If this sounds good idea then I can create quick PR.
Thoughts?

At present what you are doing is the best that can be done.
Send the PR please.


GOOS=linux go vet fails

$ GOOS=linux go vet
internal/glfw/glfw_notwindows.go:23:2: build constraints exclude all Go files in<EMAIL_ADDRESS>
Why?

I don't know but go vet for Linux on macOS doesn't work well...


Add LocalCoinSwap token information

Closing this due to inactivity, feel free to reopen. In addition we implemented a new feature called watchAsset I recommend you to use it, with this you could suggest your users to track your token.


What is the license of zsh-autosuggestions ?

I looked at the zsh-autosuggestions and spefifically at LICENSE
https://github.com/zsh-users/zsh-autosuggestions/blob/master/LICENSE
I didn't find any clarity as to under which license does zsh-autosuggestions exist ?
For inspiration you could look at zsh's own copyright file which goes overboard a bit but gives credit to all the authors and various licenses under which the software could be used.
Can this be fixed with zsh-autosuggestions.
This is necessary as i wanted to file an RFP - Request for package in Debian
Subject: RFP: zsh-autosuggestions -- Fish-like fast/unobtrusive autosuggestions for zsh.
Package: wnpp
Severity: wishlist

 Package name    : zsh-autosuggestions
  Version         : 0.3.3
  Upstream Author : Name<EMAIL_ADDRESS>* URL             : http://www.example.org/
* License         : (GPL, LGPL, BSD, MIT/X, etc.)
  Programming Lang: (C, C++, C#, Perl, Python, etc.)
  Description     : Fish-like fast/unobtrusive autosuggestions for zsh.

can this be fixed ?

The license was around before I got involved with the project, but it looks like it is an MIT license.
See text of MIT license here: https://opensource.org/licenses/MIT


Nuget development/1 1 1

You should Release it here in Github version 1.1.1 to match the nuget version.

The Release is empty... https://github.com/paireks/dotbim/releases
I didn't notice that you are not Releasing in Github. You should start doing that.
Create a tag (1.1.1) and a Release (1.1.1) with the release of what changed.
This Release gonna notify everyone who is watching the repo.

Technically you don't need to add the release file in the Release, only the source code which is done by default.
And the Tag is like a timestamp so you can compare what changes between two versions. At the moment I don't know what changed between version 1.1.0 and 1.1.1, today is easy to figure out, but after a year how gonna know.
With github Action is possible to build and release nuget, I have been doing that when I merge with the main branch in my projects.
If you are doing it manually to release the nuget, I suggest manually releasing it in Github as well to match the version.


Migrate from openapi-parser to openapi-resolver

openapi-parser is closed sources and doesn't supports some features of openapi 3.1 like description/summary overrides.
I didn't fix the webcomponent "json-schema-viewer" which doesn't seem to be documented, and doesn't work in master (at least when I tried it).

@mrin9 Can you have a look at this ? Thanks !

@j3rem1e - I truly hope the best of health for @mrin9 , but given the absence on discord as well as github, would you be interested to work on a forked branch that in future could hopefully be merged back?


how to edit config for 3.0

Ok, so when you asked me about the software working/not working, I was using an older revision.  I uninstalled the old.  And I downloaded version 3.0.0.
When I ran it, it looked like it started up with my configuration.  The one that would startup all the LEDs as blue, and as temperature went up, it would go to red and spin the fan up as temp got hotter.
So I haven't seen the software NOT work after waking computer up from sleep since I updated.
My question, where is the stored config file for the TTController_<IP_ADDRESS>-dev?  In version 2.1, the file "config.json" was in the main directory.  But it's not in version 3.0.

Ali

How did you update the service? The correct way would be to stop the service, remove all files from the directory where it is located (but leave config.json of course), unpack the newest version in the same directory and start the service.
You dont have to uninstall it to upgrade since the "installation" is just an entry in windows registry that just specifies where a service exe is located.
The config should still be located in the same folder as the service exe. Are you sure you started the v<IP_ADDRESS> and not the old version?


Please add knx.stop()

Hi,
As there is a knx.start() should be also a knx.stop() that stops the UDP connection. Not the webserver.
What do you think of adding this?

I think should be better that the main program that uses this library manage by itself if want to listen or not to KNX by an internal variable. So, I'm closing the issue. Thanks


add a few most recent mentions

unilaterally merging this with master branch bc it is only adding new articles


Make font name comparison case-insensitive

Make font name comparison case-insensitive, so a warning message won't
be displayed when settings contain a font name with the wrong case.
Pros:

The warning message isn't shown.

Cons:

If one clicks the Save button on SUI, the fallback font will be
applied. That happens because the selected font face in SUI is
fallback font.

Should we also silently change the font face in the settings in that case?
Fixes #9360

@msftbot make sure @miniksa signs off on this

When you say that the fallback font is displayed in the settings UI, do you mean that it's not selected in the dropdown box because it can't be found in the list (case sensitively)? @carlos-zamora -- can you point @eugenesmlv to the right place?

When you say that the fallback font is displayed in the settings UI, do you mean that it's not selected in the dropdown box because it can't be found in the list (case sensitively)? @carlos-zamora -- can you point @eugenesmlv to the right place?

@eugenesmlv If fallback is happening for settings UI, you may want to do the same kind of comparison here

Oh no, we're using the localized name there. I might have led you astray. Carlos, do you know if we use localized or raw font names when looking up fonts? This could .. be .. important ...

@DHowett yes, I do. When I open the settings editor the profileFontFace in CurrentFontFace method is set to the value from settings.json. I've tried to call _settings.FontFace(actualFontName) after the string comparison, but it doesn't help.
https://github.com/microsoft/terminal/blob/99b09c08d51ba073889820ff8d520eeb353045f3/src/cascadia/TerminalSettingsEditor/Profiles.cpp#L429-L442

Oh no, we're using the localized name there. I might have led you astray. Carlos, do you know if we use localized or raw font names when looking up fonts? This could .. be .. important ...

Unfortunately, I actually don't know. I tracked it down to the renderer here:
https://github.com/microsoft/terminal/blob/99b09c08d51ba073889820ff8d520eeb353045f3/src/renderer/dx/DxFontRenderData.cpp#L643
And the docs for IDWriteFontCollection::FindFamilyName don't say anything on it, it seems:
https://docs.microsoft.com/en-us/windows/win32/api/dwrite/nf-dwrite-idwritefontcollection-findfamilyname

I'll look behind the FindFamilyName interface and see where it's pulling from...

@miniksa this is really gonna ruin your day.

@miniksa this is really gonna ruin your day.

NNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNNN

I'll look behind the FindFamilyName interface and see where it's pulling from...

It actually contains all names in that dictionary but will yield the en-us one first if one exists... UGH.

We might have a couple things to do here.

Control/Warning: We probably cannot take the "easy way out" with the font name comparison any more. We need the DX Engine to tell TermControl that fallback took place. That's the only way to know if we actually hit the provided fallback table.
Settings UI: We probably need to store every localized name (or maybe just the current localized name AND the base unlocalized name) in the SUI ViewModel Font object so that we can map the user's request into an actual font name.

To get the list of names... we have to...
IDWriteFontFamilyCollection::FindFamilyName which will give us the UINT32 of the index of the font family in that collection that matches the name. It will search its internal dictionary which contains a map of all the names it knows of to the indexes. And as an example both MS Gothic and MS　ゴシック should yield the same index.
Then we have to do IDWriteFontFamilyCollection::GetFontFamily with the index to get a IDWriteFontFamily.
Then IDWriteFontFamily::GetFamilyNames to get all the names that it knows about in all languages as IDWriteLocalizedStrings.
Then we need to loop IDWriteLocalizedStrings::GetStringLength and IDWriteLocalizedStrings::GetString for the count of IDWriteLocalizedStrings::GetCount to get all the possible names the family has in all locales, using ::GetLocaleName and ::GetLocaleNameLength if we want to know the matching locale name too.

That'll be good for 2, the Settings UI work. It won't help us much for 1, the "we need to actually know about fallback instead of guessing based on the name" work.

k let me dig to see if there's a better way to know of the fallback next.

@DHowett

Settings UI: We probably need to store every localized name (or maybe just the current localized name AND the base unlocalized name) in the SUI ViewModel Font object so that we can map the user's request into an actual font name.

We already store the current localized name and the base unlocalized name in Editor::Font. However, we only compare what the user wrote to the localized name (see below).
https://github.com/microsoft/terminal/blob/99b09c08d51ba073889820ff8d520eeb353045f3/src/cascadia/TerminalSettingsEditor/Profiles.cpp#L429-L442
Should we just make that look something like this then:
 for (const auto& font : currentFontList)
 {
     // GH#XXXX: check localized name and base name
     if (font.LocalizedName() == profileFontFace || font.Name() == profileFontFace)
     {
         return box_value(font);
     }
     else if (font.LocalizedName() == L"Cascadia Mono" || font.Name() == L"Cascadia Mono")
     {
         fallbackFont = box_value(font);
     }
 }

@DHowett

Settings UI: We probably need to store every localized name (or maybe just the current localized name AND the base unlocalized name) in the SUI ViewModel Font object so that we can map the user's request into an actual font name.

We already store the current localized name and the base unlocalized name in Editor::Font. However, we only compare what the user wrote to the localized name (see below).
https://github.com/microsoft/terminal/blob/99b09c08d51ba073889820ff8d520eeb353045f3/src/cascadia/TerminalSettingsEditor/Profiles.cpp#L429-L442
Should we just make that look something like this then:
 for (const auto& font : currentFontList)
 {
     // GH#XXXX: check localized name and base name
     if (font.LocalizedName() == profileFontFace || font.Name() == profileFontFace)
     {
         return box_value(font);
     }
     else if (font.LocalizedName() == L"Cascadia Mono" || font.Name() == L"Cascadia Mono")
     {
         fallbackFont = box_value(font);
     }
 }

There could be N names. Not just one localized and one unlocalized. Or at least that's how DWrite stores it internally. :|

And we're going to want to make the comparison case-insensitively.

@eugenesmlv sorry we took over your pull request as our chat channel for this issue. There's a significant Teams outage, it seems, and GitHub has really worked out for us 😉

@DHowett it was interesting! Unfortunately, I don't know much about the terminal internals to participate in the discussion, but I'll be glad to help you fix that font comparison issue ☺

k let me dig to see if there's a better way to know of the fallback next.

We know that we fall back to a different face in DxFontRenderData::_ResolveFontFaceWithFallback after the first _FindFontFace call fails.
We also know that we couldn't find the name we were looking for in the current locale and did a fallback to a different name in DxFontRenderData::_GetFontFamilyName (and this function is also a great example of how to dig the names out like I was describing for the IDWriteLocalizedStrings business above.)
So I think just bubbling this information out of the lookups and to the interface is just what needs to be done.

@eugenesmlv, thanks for this proposal. But I'm going to close this in favor of the solution I wrote in #9734 that handles a few more scenarios than this and avoids comparing strings at all. Thanks for lighting a fire under me. :)


Any way to skip login?

I have this running inside my network, and there's really no need to have it password protected that I can tell.
Is there any way to enable an option to skip login?
I'm using it inside the docker-homebridge image.

dabbled in the config.json for the docker image and it appears i can disable auth after all!


Broken config auto generation

When deleting the Tinyinfo.ini file, which contains the settings for the Program, the Program is supposed to generate a new file with default values. This currently does not work.

Found the issue at lines 759-761 in MainWindow.cs. Working on a fix now.

Those lines actually werent the problem, found the issue in lines 19-21 in Splash.cs

Issue is not present in the micro version.


This has 15 commits but only one is real so do like matt says in the ss in the comments, essentially I made getPlayerYaw() slightly more efficient

http://prntscr.com/h3bipt the screenshot that matty boi says is good @FalseHonesty idk how to assign u so i @'d u

how have you managed this


ACI stealth mode

Max brought up latest update that current ACI website needs to hide pretty much everything for now (no showing of the projects etc).
Here's my proposal then.
Keep working on staging leaving on production only home/landing page (if possible), looking something like this:

@despiegk and Max see if that works.

why bother doing so? we have a website already working
doing some upgrades to the UI is not related the functionality of the website!

possible solutions

temporary disable all links in code and deploy with this intermediate state
through caddyserver we make it display the coming soon page (static) for that domain [easy]
other solutions will require adding authentication, and lots of complexities to the website while not needed

I agree that website without marketing activities and promotion is 'invisible' to the world anyways.

@despiegk can navigate this best

Only home page shows up in case and when pass code entered you will get access to the full site or a message to reach out to threefold for access.


CSharpKernel: Possibility for a memory leak?

Describe the bug
We are using CSharpKernel through Microsoft.DotNet.Interactive.CSharp version 1.0.0-beta.22606.2 (also tested with 1.0.0-beta.23152.2) in our ASP.NET Core based application.
Lately there has been memory issues with the system and I've tried to pinpoint the origin. Through profiling I've noticed that things from Microsoft.CodeAnalysis namespace are using quite huge amounts of memory. I'm currently inclined to believe that there's maybe something going on in the latest versions of the CSharpKernel.
Here's a simple .NET 7 Console app which has only this additional Nuget:
    <PackageReference Include="Microsoft.DotNet.Interactive.CSharp" Version="1.0.0-beta.22606.2" />

var kernel = new CSharpKernel();
var code = "var c = 15; c";

for (int i = 0; i < 1000; i++)
{
    await kernel.SendAsync(new SubmitCode(code), CancellationToken.None);
}

And here's how its memory usage behaves:

After 1000 runs, the app is using more than 5GB of memory. Now if we dig little deeper, this is what we see:

The Microsoft.CodeAnalysis.CommonReferenceManager seems to be the main problem. If we look at the call stack, here's what we can see:

I tried switching from kernel.SendAsync to kernel.SubmitCodeAsync but it is displaying the same:

The situation is better if the package Microsoft.DotNet.Interactive.CSharp is downgraded to 1.0.0-beta.22103.1. Now in the end the application takes little more than 1GB of memory:

The memory usage again goes back to more than 5GB if we upgrade to the latest version 1.0.0-beta.23152.2:

As a test I also tried a variant where new kernel is used for every execution and here's the result from that:

I cloned the interactive repo to test things out. It seems if I comment out this line:
https://github.com/dotnet/interactive/blob/66fe81b1c2711c39fdc703e9fd49819e9e671828/src/Microsoft.DotNet.Interactive.CSharp/InteractiveWorkspace.cs#L133
The memory usage drops to 1.0.0-beta.22103.1 levels, so from more 5GB to 1GB.

Thank you for this detailed analysis, @mikoskinen! We're looking into it now.

Fixed with #2866


Refactor and add support for Handler Mapping Strategies

As discussed in #44 and #60, this (very broken, very Work in Progress) PR does two things:

Refactor some of our most tangled internals
Add support for letting folks autowire their own command -> mapping strategies

What does it change?
It guts the TacticianExtension and CommandHandlerCompilerPass, separating their contents out into three objects: BusBuilder(s), HandlerMapping, and Routing. Each part is now much more testable and a lot of the spooky-action-at-a-distance-pass-data-through-container-parameters stuff is eliminated.
How do folks add their own?
Implement your own HandlerMapping interface and pass it to the TacticianBundle when instantiating it in your AppKernel. For prior art, see: https://github.com/matthiasnoback/symfony-bundle-plugins
I know hat's not the normal way of doing things in Symfony, folks would expect a "tactician.handler_mapping" container tag or a config option for a service value but here's the problem: most of the configuration methods that people want to use rely on manipulating/reading the container data (tags, mapping, etc). However, in our case the container isn't built yet (because we're in the process of building it), so we can't rely on anything we'd in it. The best we could do is a FQCN in the config class but considering you might want to put them in a Composite/Chained HandlerMapping strategy, that's awkward too.
In the end, this is the best way I've found to inject strategies into the Bundle's compilation process and the "surprise" of it is something we can easily mitigate with good documentation.
What will this not support?
Basically, the type of mappings strategies you'd want to run after the container is built, maybe those that use complex object graphs or an external cache to build/keep performant. The only usecase I actually seeing us missing out on is probably annotations but the longer I look at how that would work in practice, the more inclined I am to push people towards using the DI config. Besides, folks could still do that if they want or use JMS/Metadata as autoloading is active at this point.
I looked at using a CacheWarmer instead of a Compilation step to keep the command routing performant yet customizable. In the end, it gets very awkward since the implementation for pre-compilation and post-compilation routing would be very different.
Honestly, if folks have very specific needs/wishes, they should just write their own replacement for the command handler middleware. They'll be done in 30-50 lines what would take us hundreds to support in configuration.
What remains to be done?

[ ] The new objects all need tests. Some of the old ones have been ported but it's not enough.
[ ] Need to review the old tests and see which ones would be better off being relocated.
[x] Implement the new strategies we'll support (starting with a reflection based one that looks at the typehints on unary handler methods)
[ ] Decide what the new starting ones will be
[ ] Documentation
[ ] Add a "tactician:debug" command which shows which commands are routed to what services
[ ] Much, much remaining cleanup.

What will make it go faster?

Let me know if you have any feedback on the new design, it's just an idea. :)
Send PRs for the above points, I'm happy to get 'em!

BC breaks

Removed the tactician.commandbus.class parameter
Some different exceptions are now thrown in container building error cases

I would like to add some tests for the new classes. How should I proceed? Clone the repo and push my additions to this branch? Or what is the correct way to do it?

Hi Daniel, thanks! Best bet is to probably make a PR against this branch :)
On Sep 17, 2017 7:04 PM, "Daniel Mecke"<EMAIL_ADDRESS>wrote:
I would like to add some tests for the new classes. How should I proceed?
Clone the repo and push my additions to this branch? Or what is the correct
way to do it?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/thephpleague/tactician-bundle/pull/67#issuecomment-330062722,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAI9TqdZ_e7WQgskQjeoJ3omSFVRgi6Lks5sjVEkgaJpZM4PaMiG
.

I definitively like it ! Very nice behavior and possibilities !

Regarding the tactician:debug we are ok we should build the routing and dump it ? In order to achieve it we will need to put the bus ids as container parameter.

About the debug, I was thinking (and this is just an idea) about creating an object "TacticianDebugReport." We instantiate it in the compiler pass with its two required parameters: routing and the BusBuilders collection. The object then has a from/toArray which we can stash the value of as an opaque parameter in the container.
It's a bit overcomplicated but it gives us a stable interface to work with and the only data we stash has a defined interface for loading/retrieving it.

FYI, that last commit adds the automatic typehint mapping as discussed. The idea is that if you have a class like this:
class MyHandler
{
    public function handle(RegisterUser $command){}
}

and a service definition like this:
services:
    my_handler:
        class: MyHandler
        tags:
            - [name: 'tactician.handler', auto=true]

then we'll find the typehint and automatically route RegisterUser to that handler This is enabled by default (provided you add auto=true). This can also be combined with the normal "command" option as well. I'm open to make changes on this one (auto=true might be too broad a name) but at the moment, I'm thinking this will be the automagical reflection based one we ship with maybe possibly perhaps.
If folks want to add another one (annotations or something) we can talk about it but I want to strongly push people to maintaining their own implementation rather than supporting every naming convention under the sun.

If folks want to add another one (annotations or something) we can talk about it but I want to strongly push people to maintaining their own implementation rather than supporting every naming convention under the sun.

AMEN.

So thanks to this PR and latest Symfony changes we will be able to write:
    My\Namespace\App\:
        resource: '../src/App'
        public: true
        tags:
            - { name: tactician.handler, auto: true }

Cannot wait \o/

Merged tests from @dmecke, added a bunch of other tests and did some cleanup, etc.
I think code-wise we're in a pretty okay place now, though I haven't put this through a working app yet. Will try to do something with documentation soon-ish.
The big missing feature right now is the tactician:debug command, which is something I'd like to have before shipping this but isn't a must-have per se. @tyx Did you ever start on this?
Once I have the docs done, I'll merge this back to master and maybe some of y'all can give it a spin in your codebases? :)

Once I have the docs done, I'll merge this back to master and maybe some of y'all can give it a spin in your codebases? :)

Sure, I can't wait to squash my 300+ lines (and growing) command_handler.yml to 5 lines! :-)

Okay, added documentation for new features, etc.
This PR is feeling more stable now, so I'm going to merge this PR (which has been open for quite a while) and update the Roadmap issue, as well as open a new "Help Wanted" issue for the tactician:debug command.

Once I have the docs done, I'll merge this back to master and maybe some of y'all can give it a spin in your codebases? :)

I've tested the current master with my codebase and it works like a charm! 🥇


Fix landmark inference

[x] Test with generate vs pipeline reach parity
[ ] Test confirm in ooba

It's the wrong config. We should target add_special_token=False


Stream Video From Multiple UAVs in Swarm

Hello,
Is there any way to live stream videos from multiple UAVs in Swarm at once?

I am very curious about this as well.  It looks like when I turn on the video connected to an Access Point, no data comes out.  This is very disappointing.  I also don't know why the firmware does not let you do this.


Prevent terminal window from showing when using ping on Windows

Tick the checkbox if you understand [x]:

[x] I have read and understand the pull request rules.

Description
On Windows using the Ping monitor will open a terminal every time a host is pinged. This PR fixes this by enabling the windowsHide option of spawn. I cannot test this on other systems, but as far as I understand the docs this should only affect Windows.
Type of change
Please delete any options that are not relevant.

Bug fix (non-breaking change which fixes an issue)

Checklist

[x] My code follows the style guidelines of this project
[x] I ran ESLint and other linters for modified files
[x] I have performed a self-review of my own code and tested it
[ ] I have commented my code, particularly in hard-to-understand areas
(including JSDoc for methods)
[x] My changes generate no new warnings
[ ] My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)
Please do not use any external image service. Instead, just paste in or drag and drop the image here, and it will be uploaded automatically.

Wondering how to reproduce this, because I developed Uptime Kuma on Windows whole time and have never seen this before.

You don't see it if the host is reachable. If it's not the window is visible for about half a second.
Nonetheless, it is probably more correct this way whether it is necessary for everyone or not.


Some questions about large training loss

Hi, I download you code and BSDS500 dataset to learn edge detection model and print the loss of each iteration, however, the training losses are very large and keep increasing which indicate that the model is not converge. I just keep the default parameters, can you give me any hints to solve these problems?

I have the same question with you. and when i train the model, training loss becomes very large which fluctuates around 4000.

I also found that there were increasing loss result and it cannot coverage, what about you guys setting of parser.add_argument() ?

我和你有同样的问题。当我训练模型时，训练损失变得非常大，在 4000 左右波动。

我和你有同样的问题。当我训练模型时，训练损失变得非常大，在 4000 左右波动。

请问大佬最终的loss值稳定在哪里？我这边在15000左右

This ain't a simple issue.

这不是一个简单的问题。

<EMAIL_ADDRESS>

Hi, I download you code and BSDS500 dataset to learn edge detection model and print the loss of each iteration, however, the training losses are very large and keep increasing which indicate that the model is not converge. I just keep the default parameters, can you give me any hints to solve these problems?

问题怎么解决的呀，求指点


[LD-237] Make sure to set system enviroment variable in crontab.

innobackupex-runner fails to  run due to invalid MySQL config.

Yup go ahead and merge.


is AtomVM still alive?

this is not an issue but a question. because i do not see much activity: is this project dead or alive?
thanks in advance for your answers, e.

Alive: https://github.com/bettio/AtomVM/commits/master
@fadushin has recently did a great work by implementing maps (which enables us full Elixir power), while I'm finishing adding support to supervisors ;)
We are close to tagging the first release, since we have support for all the most important erlang/elixir functions.

Also real time chat has been moved to discord: https://discord.gg/n8V7t7rw

i'm glad to read your words.
thanks for the info, e.

thanks for your fast answer bettio,
currently i try to start a little project  using atomvm but i find it hard to get restarted.
i cloned your repository (git clone https://github.com/bettio/AtomVM.git) and compiled it but i an quite unhappy.
eg. atomvm seems to be unable to start proceses. i try to run
-module(p).

-export([start/0, ping/2, pong/0]).
ping(0, Pong_PID) ->
    Pong_PID ! finished,
    io:format("ping finished~n", []);
ping(N, Pong_PID) ->
    Pong_PID ! {ping, self()},
    receive
        pong ->
            io:format("Ping received pong~n", [])
    end,
    ping(N - 1, Pong_PID).
pong() ->
    receive
        finished ->
            io:format("Pong finished~n", []);
        {ping, Ping_PID} ->
            io:format("Pong received ping~n", []),
            Ping_PID ! pong,
            pong()
    end.
start() ->
    io:format("starting pong..~n"),
    Pong_PID = spawn(p, pong, []),
    io:format("starting ping..~n"),
    spawn(p, ping, [3, Pong_PID]).
this little pgm just outputs:
..
Starting: p.beam...
starting pong..
starting ping..
AtomVM finished with return value = <0.3.0>
going to sleep forever..
is there anything i might have missed?
thanks for your answer.
gustav
Am Sa. 10. April 2021 15:42 CEST, schrieb Davide Bettio @.***>:

Alive: https://github.com/bettio/AtomVM/commits/master
@fadushin has recently did a great work by implementing maps (which enables us full Elixir power), while I'm finishing adding support to supervisors ;)
We are close to tagging the first release, since we have support for all the most important erlang/elixir functions.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

Try adding
receive X -> X end

to the end of your program.
What is happening is that your program is terminating immediately.
You may also want to use ?MODULE in place of p in your program.

thanks,
this was the missing part - may fault.
thanks again.
gustav
Am So. 25. April 2021 21:07 CEST, schrieb Fred Dushin @.***>:

Try addingreceive X -> X end
to the end of your program.
What is happening is that your program is terminating immediately.
You may also want to use ?MODULE in place of p in your program.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or unsubscribe.


Update README.md

Added warning about possible problems with using the project for the first time, e.g. resolving dependencies and recognizing the project as a Maven project

.


Show all empty applications in app list

Saves every application that is created to config.
This will make sure that we display all created applications in application list (even empty applications)
fixes https://github.com/redhat-developer/ocdev/issues/105

Sorry, I know that this looks like big PR, but probably more than half are changes in tests


[🐛] - Saving file in fsedit does not purge cache

Running cat on a file you just changed in fsedit will show old content

Seems to have been resolved years ago, oops!


fix for ghost platoons not showing

Only one relevant line in UIManager changed, line 111.

smarter design would probably be to have all methods that use ghostUnits to get it from the ongoing buytransaction :p


Patch 19

@aalborov please change target branch to develop

@aalborov @yssemaev @vmatveic as there is no answer for 2 weeks, can we close this PR without merge?
The content is completely unclear and most likely outdated.

I've changed the target branch to develop. And we've got just one file of diff. I think it should be reviewe and merged if it's ok. @aalborov , please comment asap! Also, please resolve merge conflicts here. Thanks!

@aalborov @vmatveic please resolve conflicts.

Jenkins please retry a build


Invoke-RestMethod is sending empty body with PUT requests

Steps to reproduce
Invoke-RestMethod is sending empty body under following circumstances:

PUT method is used and
body object is passed directly to Invoke-RestMethod.

See the complete working example below. To demonstrate this issue I am using testing JSONPlaceholder API that returns body it received (it is just adding id property). Note that described scenario is failing just in case of PUT method as POST example below works as expected. The theory is that Invoke-RestMethod fails to serialize passed payload but silently continues with an empty body. I would expect either throwing an error or working just fine as in POST scenario.
$body = @{
    name = "Gandalf"
};
$post = "https://jsonplaceholder.typicode.com/posts";
$put = "https://jsonplaceholder.typicode.com/posts/1";

# Sending empty body
$response1 = Invoke-RestMethod -Uri $put -Method Put -Body $body
Write-Host $response1

# Working
$response2 = Invoke-RestMethod -Uri $put -Method Put -Body ($body|ConvertTo-Json -Depth 99) -ContentType "application/json"
Write-Host $response2

# Working
$response3 = Invoke-RestMethod -Uri $post -Method Post -Body $body
Write-Host $response3

# Working
$response4 = Invoke-RestMethod -Uri $post -Method Post -Body ($body|ConvertTo-Json -Depth 99) -ContentType "application/json"
Write-Host $response4

Expected behavior
@{name=Gandalf; id=1}
@{name=Gandalf; id=1}
@{name=Gandalf; id=101}
@{name=Gandalf; id=101}

Actual behavior
@{id=1}
@{name=Gandalf; id=1}
@{name=Gandalf; id=101}
@{name=Gandalf; id=101}

Environment data
Name                           Value
----                           -----
PSVersion                      7.3.4
PSEdition                      Core
GitCommitId                    7.3.4
OS                             Microsoft Windows 10.0.22621
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

@onetocny Could you test it in Powershell 7.4preview3 ?

I can confirm that sample script works as expected in Powershell 7.4preview3.


How to add second vaccumvaletudo-mapper

Possible using your valetudo-mapper addon when using two vaccums?

Duplicate of #62
Please take a look there.


Add support for Arizona Public Service

I'm bumping the version in https://github.com/home-assistant/core/pull/125981 and mentioning the support in the documentation in https://github.com/home-assistant/home-assistant.io/pull/34739
Could you create a virtual integration in Home Assistant? You need 3 PRs similar to https://github.com/tronikos/opower/pull/87#issuecomment-2253017806

Here are my PR's to the Home Assistant project.
Virtual Integration: https://github.com/home-assistant/core/pull/126014
Documentation: https://github.com/home-assistant/home-assistant.io/pull/34749
Brands: https://github.com/home-assistant/brands/pull/5864


[WIP] Refactor code-manager functions

I've been working on #672. I'm looking for any feedback you have.
What I have so far:

Add an editor arg to each function in code-manager that references an atom$TextEditor
Get everything to clear flow errors
Update the code-manager spec to include the new arguments (the modified tests pass)

Things I'm still looking at (let me know if anything else)

Reading back through the changes for style/logic cleanup (mainly focused on above points up to now)
Reviewing the modified spec to make sure my changes are not cheating

There are a number of follow up commits so far. I figure if this ends up getting merged we can figure out how best to squash/clean up. (Also working on proper commit messages!)

Since you're touching these function, I would make them pure functions too
@n-riesco That's a good point, i'll be thinking about this as I rework this a little bit. I think having an editor defined before each entry point could help with issues like #685 and #669

@lgeiger Thanks for all the feedback! I did a few unusual things to get flow errors resolved, gradually learning as I go. I'm looking forward to going back with only one error at a time as I pick them off.

I love when Flow finds bugs for us. 😄

@lgeiger as of that last commit I've covered all the feedback so far. Good learning experience for me so far, let me know if you have any other thoughts.

@BenRussert Great job! I didn't merge it already since the work in progress tag is still there.
I'll take a look at it 👍

I'm not in a hurry. Take your time to review.
On Sun, Apr 2, 2017, 6:10 PM Lukas Geiger<EMAIL_ADDRESS>wrote:

@BenRussert https://github.com/BenRussert Great job! I didn't merge it
already since the work in progress tag is still there.
I'll take a look at it 👍
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/nteract/hydrogen/pull/686#issuecomment-291021931, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AKW4cShW-k-eC_sLS1cGRL7MY4IzKSQ-ks5rsCr7gaJpZM4MweSl
.

--

Ben R

Thanks, I'll be able to make these changes pretty quickly later when I get home from work.

Woo excellent! Now we can actually start testing this part of the code base in a reasonable way 🎉

:smile:


https://new-issue.vuejs.org/?repo=vuejs/vue-cli

Version
3.2.1
Reproduction link
https://github.com/vuejs/vue-cli
Environment info
all

Steps to reproduce
npm run build
What is expected?
Automatic deal with sprite img
What is actually happening?
I should config webpack sprite plugin like webpack-spritesmith manual in vue-cli 3.0  ?

Sorry but you're not making any sense


feat: Condensed objects

[x] depends on: #4505

This PR/issue depends on:

leanprover-community/mathlib4#4505
By Dependent Issues (🤖). Happy coding!

This PR/issue depends on:

leanprover-community/mathlib4#4505
By Dependent Issues (🤖). Happy coding!

Thanks :tada:
bors merge


feat: add created date in suggestions

Description
This adds the created date ➕ suggestion, which inserts the ➕ symbol with the current date when selected.
I'm not sure what the exact implementation should look like but I'm happy to take feedback and update the PR accordingly!
Motivation and Context
Addresses #1743 .
How has this been tested?
I built main.js, replaced the existing main.js in the plugin folder in my test vault.
I then manually tried to create tasks and edit existing ones to view the suggestions and select them in various orders.
I also did the smoke test in the sample vault.
Screenshots (if appropriate)

After selecting "➕ created today":

Types of changes

Changes visible to users:

[ ] Bug fix (prefix: fix - non-breaking change which fixes an issue)
[x] New feature (prefix: feat - non-breaking change which adds functionality)
[ ] Breaking change (prefix: feat!! or fix!! - fix or feature that would cause existing functionality to not work as expected)
[x] Documentation (prefix: docs - improvements to any documentation content for users)
[ ] Sample vault (prefix: vault - improvements to the Tasks-Demo sample vault)
[ ] Contributing Guidelines (prefix: contrib - any improvements to documentation content for contributors - see Contributing to Tasks)

Internal changes:

[ ] Refactor (prefix: refactor - non-breaking change which only improves the design or structure of existing code, and making no changes to its external behaviour)
[ ] Tests (prefix: test - additions and improvements to unit tests and the smoke tests)
[ ] Infrastructure (prefix: chore - examples include GitHub Actions, issue templates)

Checklist

[x] My code follows the code style of this project and passes yarn run lint.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] My change has adequate Unit Test coverage.

Terms

[x] My contribution follow this project's contributing guide
[x] I agree to follow this project's Code of Conduct

Wow. Thank you very much @ldanet. I'm reviewing several PRs at the moment, and will test this out as soon as I can.
I really appreciate the contribution! 🎉

Whilst you were working on this, I edited a line in Auto-Suggest.md that you correctly deleted.
How comfortable are you with Git and merging in the latest from main?
If you are 100% comfortable, please could you merge in main, so that I can tell GitHub to go ahead and run the tests here?

Whilst you were working on this, I edited a line in Auto-Suggest.md that you correctly deleted.
How comfortable are you with Git and merging in the latest from main?
If you are 100% comfortable, please could you merge in main, so that I can tell GitHub to go ahead and run the tests here?

I'm very comfortable with git! I'll update and fix any conflicts!

Any chance you could also edit this bit of the docs, please, to add to the ways that Create date can be - erm - created:
https://publish.obsidian.md/tasks/Getting+Started/Dates#Created+date
(You've probably seen already but editing the docs/ folder as a vault in Obsidian is a great way of editing the docs, for ease of linking - and see how the docs will look when published)

Apologies if you've done this already - I need to get some sleep ....
But I wonder, should it only offer to add Created date via auto-suggest if the created field is turned on in settings?

Apologies if you've done this already - I need to get some sleep ....
But I wonder, should it only offer to add Created date via auto-suggest if the created field is turned on in settings?

That's definitely technically possible, but I'm not sure if it would be more helpful or more annoying from a user standpoint 🤔
Would there be a case where users don't want the plugin to include the creation date automatically but would still like to add it manually if it's easy to do? Or can we safely assume that if they don't have enabled "Set created date on every task", they don't want to record creation dates at all? I guess the completed date is the similar in the sense that it's not easy to record the completion date if you do not enable the setting to have it automatically done either!
I personally don't mind either way, I have the setting enabled in my own vault 😄
I can add the check if you'd like.

FYI When I smoke-test this, I will update any screenshots that have changed with this PR, and push to your branch.
Hope you don't mind. It saves me doing more work creating a PR or manual commit separately...

It's updated and ready to review again. I moved the new created date suggestion to the bottom of the task property suggestions and reverted the change to the number of date suggestions. I also updated the screenshots in the documentation. ✨

@ldanet FYI I am doing a little refactoring to enable the skipped test in Suggestor.test.ts having discovered that it has been failing for a little while, and I never knew because it was skipped....
I'm making it so that maxGenericSuggestions can be passed in to makeDefaultSuggestionBuilder().

@ldanet FYI I am doing a little refactoring to enable the skipped test in Suggestor.test.ts having discovered that it has been failing for a little while, and I never knew because it was skipped....
I'm making it so that maxGenericSuggestions can be passed in to makeDefaultSuggestionBuilder().

Cancel that. It would increase the conflicts with #1824.

I think we should probably move this to a new issue, so comments don't get lost in this one... @esm7 would you be able to do that please?

I was originally about to do just that, but I thought that if what I see as inconsistent and unexpected behavior is actually intentional, there's no point to open a new issue for it. Is this the case or can it be considered an issue?

That's a fair point.
Earlier discussion (from memory)
We debated above whether to make the Created field optional in Auto Suggest, depending on the user's setting.
In the end, I opted for sticking with the original (current) proposed implementation, to then see what feedback there is from users.
Also, there is also discussion above about refining the parameters used to control how many items - and what sort - are displayed in the auto suggest menu.
I don't remember any discussion about what happens when you specifically type today.
A possible workaround
Also, @esm7 - what happens when you increase the number of suggestions in settings? Do you get the behaviour you want?
Created and today
I do think that it is logical to make the Created suggestion add today's date. It will be rare for someone to want a different date.
What next
If it's annoying, it doesn't matter if it was intentional or not... It's still valid feedback - and worth logging to track it, I feel.

I was originally about to do just that, but I thought that if what I see as inconsistent and unexpected behavior is actually intentional, there's no point to open a new issue for it. Is this the case or can it be considered an issue?

That's a fair point.
Earlier discussion (from memory)
We debated above whether to make the Created field optional in Auto Suggest, depending on the user's setting.
In the end, I opted for sticking with the original (current) proposed implementation, to then see what feedback there is from users.
Also, there is also discussion above about refining the parameters used to control how many items - and what sort - are displayed in the auto suggest menu.
I don't remember any discussion about what happens when you specifically type today.
A possible workaround
Also, @esm7 - what happens when you increase the number of suggestions in settings? Do you get the behaviour you want?
Created and today
I do think that it is logical to make the Created suggestion add today's date. It will be rare for someone to want a different date.
What next
If it's annoying, it doesn't matter if it was intentional or not... It's still valid feedback - and worth logging to track it, I feel.

My feedback is not related to the number of suggestions, on the contrary. As you can see in the video I posted above, "created today" can get triggered more than any other suggestion, and in contexts where no other suggestion is triggered.
I agree that the most sensible suggestion would be "created today", but in this case to be consistent with how the auto-suggest logic currently works, it needs to be triggered when the user starts typing "created". "today" on its own should not trigger a suggestion (as it never did), and definitely not after an emoticon of a different field.
If that's agreed upon I guess I can go ahead and open an issue.

Please do report the bug, and if you have any suggestions for improvements then include them too. Thank you.


set download button text in php for translations

makes button text set in php for translations for #1054

I'm not sure if hidden is well supported enough, unless we are willing to drop IE 10. Other things just user style="display:none;"

ah, i'll add that too then


Posting just the Date in a Composition

Configuration information

  <status>
    <ehrbase_version>0.16.5</ehrbase_version>
    <openehr_sdk_version>39cb1fd</openehr_sdk_version>
    <archie_version>5a4a9442e5e2516aed5f25636ac236682aace7b9</archie_version>
    <jvm_version>Oracle Corporation 11.0.11+9</jvm_version>
    <os_version>Linux amd64 5.8.0-43-generic</os_version>
    <postgres_version>PostgreSQL 13.3 (Debian 13.3-1.pgdg100+1) on x86_64-pc-linux-gnu, compiled by gcc (Debian 8.3.0-6) 8.3.0, 64-bit</postgres_version>
  </status>

Steps to reproduce

DRX.EntryPoint.v0.opt.txt
FLAT Composition
{
	"drx.entrypoint.v0/problem_diagnosis/chief_complaint|value": "Head",
	"drx.entrypoint.v0/problem_diagnosis/chief_complaint|code": "69536005",
	"drx.entrypoint.v0/problem_diagnosis/chief_complaint|terminology": "local",
	"drx.entrypoint.v0/problem_diagnosis/date_of_onset": "2021-06-05",
	"drx.entrypoint.v0/category|code": "433",
	"drx.entrypoint.v0/category|value": "event",
	"drx.entrypoint.v0/category|terminology": "openehr",
	"drx.entrypoint.v0/context/start_time": "2021-06-06T14:49:17.825Z",
	"drx.entrypoint.v0/context/setting|code": "238",
	"drx.entrypoint.v0/context/setting|value": "other care",
	"drx.entrypoint.v0/context/setting|terminology": "openehr",
	"drx.entrypoint.v0/problem_diagnosis/language|code": "en",
	"drx.entrypoint.v0/problem_diagnosis/language|terminology": "ISO_639-1",
	"drx.entrypoint.v0/problem_diagnosis/encoding|code": "UTF-8",
	"drx.entrypoint.v0/problem_diagnosis/encoding|terminology": "IANA_character-sets",
	"drx.entrypoint.v0/composer|name": "Medblocks UI",
	"drx.entrypoint.v0/language|code": "en",
	"drx.entrypoint.v0/language|terminology": "ISO_639-1",
	"drx.entrypoint.v0/territory|code": "IN",
	"drx.entrypoint.v0/territory|terminology": "ISO_3166-1"
}

Actual result
Error:
{
  "error": "java.lang.IllegalArgumentException: Unsupported field: HourOfDay (through reference chain: com.nedap.archie.rm.datavalues.quantity.datetime.DvDateTime[\"value\"])",
  "status": "Bad Request"
}

Seems like the field "drx.entrypoint.v0/problem_diagnosis/date_of_onset": "2021-06-05" is the problem. Setting the time also fixes this.

Expected result (Acceptance Criteria)
Accept just a date like 2021-06-05 for type DV_DATE_TIME.

Definition of Done

[ ] The defect is checked by an unit or an integration test (Robot)
[ ] Merge Request approved
[ ] Unit tests passed
[ ] Build without errors
[ ] Release notes prepared
[ ] No additional runtime warnings

DV_DATE may be more appropriate for recording ISO8601 date string formats.
https://specifications.openehr.org/releases/RM/Release-1.0.2/data_types.html#_dv_date_class

The DV_DATE might be more appropriate, but shouldn't the DV_DATE_TIME also support an ISO8601 date string? It's usually the case that sometimes the time is known and at other times, it's not. Wouldn't want to change the template just to accommodate this.

DV-DATE accepts Iso8601_date
https://specifications.openehr.org/releases/BASE/latest/foundation_types.html#_iso8601_date_class
format which does not have the time and DV_DATE_TIME inherits
Iso8601_date_time
https://specifications.openehr.org/releases/BASE/latest/foundation_types.html#_iso8601_date_time_class
which required both date and time. If you have only date for a datetime
data type, you have to use 0s in the time part.
regards
Dileep V S
Founder
HealtheLife Ventures LLP
m: +91 79756 70933
a: 9/1, 19th Main Road, 1st 'N" Block, Rajaji Nagar, Bangalore 560010
w: http://ayushehr.comehr.network, http://ehr.networkayushehr.com
http://ayushehr.com e: @.***
On Sun, Jun 20, 2021 at 7:17 PM Sidharth Ramesh @.***>
wrote:

The DV_DATE might be more appropriate, but shouldn't the DV_DATE_TIME also
support an ISO8601 date string? It's usually the case that sometimes the
time is known and at other times, it's not. Wouldn't want to change the
template just to accommodate this.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/ehrbase/ehrbase/issues/526#issuecomment-864557996,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFKVCXHAHCWEV5WGS6AKFNLTTXWP7ANCNFSM46GA7LPA
.

@sidharthramesh @dileep-ehr do you think this issues can be considered resolved?

I think yes @birgerhaarbrandt. Closing.


BlakeNaccarato/issue52

Adopt tooling from blakeNaccarato/copier-python
Fixes #53

These workflows are working over on blakeNaccarato/tooling, so I'm not sure why they aren't working here. I'm going to merge the pull request and see if the workflows magically pass once merged.


Update FHIR Core to latest release of Data Capture

Name of feature to enhance
Update the Data Capture library to the latest version
NB
The last release was done from this PR
Might need to follow up on this PR to support the barcode issue. either resolve the issue on that SDK or port the code to FHIR core

Blocked - Current release from SDK not yet published

We can push our own release of the SDK for this if we need it

This is now published https://oss.sonatype.org/content/repositories/snapshots/org/smartregister/data-capture/

Tag https://github.com/onaio/android-fhir/releases/tag/v0.1.0-alpha03-preview-SNAPSHOT


npx install issue with Node 10

Most likely the same as this upstream issue: https://github.com/npm/npm/issues/20624

Using npx and @availity/workflow without issues so closing.


Adapting initial guess without Rosetta

Hi,
I wad wondering if it would be possible to encode the initial guess without relying on Rosetta capabilities (perhaps translating the work to BioPython?) Thanks so much!

It certainly is possible to translate this codebase to BioPython! I'm happy to merge a PR if you want to make those changes


Missing period in instructions

Challenge Waypoint: Storing Values with the Equal Operator has an issue.
User Agent is: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_10_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/47.0.2526.106 Safari/537.36.
Please describe how to reproduce this issue, and include links to screenshots if possible.
My code:
// Setup
var a;
var b = 2;

// Only change code below this line
a = 7;
b = a;

Missing period in first sentence of instructions.

I eagerly await your PR.


(#158) Implement distinguishing between different kinds of bindings in BDB

See #158
Also adds a TODO.
Please let me know if you have any issues with this PR.

On 1/30/21 8:42 AM, Alexey Kutepov wrote:

@rexim requested changes on this pull request.

@@ -276,24 +324,29 @@ Bdb_Err bdb_run_command(Bdb_State *state, String_View command_word, String_View
String_View where_sv = sv_chop_by_delim(&arguments, ' ');
String_View count_sv = arguments;

   Inst_Addr where = 0;

   if (bdb_parse_label_or_addr(state, where_sv, &where) == BDB_FAIL)

   // TODO: Rethink the types in the `examine` command of bdb

What do you mean by "rethink"? What's the problem here?

That was merely me, working with the unintuitive types. I may refactor
this later, because juggling around with the Word union was really
awkward. However, we may just remove this TODO for now if it is
distracting or inappropriate.
--
Sent from Thunderbird@Triton / FreeBSD 13-ALPHA2
Please remember: https://useplaintext.email/#etiquette
Do NOT send me Microsoft Office documents. I will and cannot open them.
Nico Sonack<EMAIL_ADDRESS>

On 1/30/21 8:42 AM, Alexey Kutepov wrote:

@rexim requested changes on this pull request.

@@ -276,24 +324,29 @@ Bdb_Err bdb_run_command(Bdb_State *state, String_View command_word, String_View
String_View where_sv = sv_chop_by_delim(&arguments, ' ');
String_View count_sv = arguments;

   Inst_Addr where = 0;

   if (bdb_parse_label_or_addr(state, where_sv, &where) == BDB_FAIL)

   // TODO: Rethink the types in the `examine` command of bdb

What do you mean by "rethink"? What's the problem here?

That was merely me, working with the unintuitive types. I may refactor
this later, because juggling around with the Word union was really
awkward. However, we may just remove this TODO for now if it is
distracting or inappropriate.
--
Sent from Thunderbird@Triton / FreeBSD 13-ALPHA2
Please remember: https://useplaintext.email/#etiquette
Do NOT send me Microsoft Office documents. I will and cannot open them.
Nico Sonack<EMAIL_ADDRESS>

@herrhotzenplotz yeah, it sounds too vague. I'm just afraid that after some time we won't be able to recall what it was about. Neither it is a very important issue imo.

@herrhotzenplotz thank you for your contribution!


Not found because of proxy error: Error: socket hang up

I'm trying to get indications of a walk route quering the Cartociudad service. The service url is ok and responds with a JSON with all the indications.
Testing the service URL in my navigator the result is ok but in my Angular app when i try
http.get("http://<IP_ADDRESS>:8123/http://www.cartociudad.es/services/api/route?orig=40.44184877149766,-3.5748567877248845&dest=41.36999441400242,2.1469160601647803&locale=es&vehicle=WALK") the result is a 404 NOT FOUND. Response._body is "Not found because of proxy error: Error: socket hang up"
Trying with other proxy the result is OK. Any ideas ?
Thanks.
Current proxy.js
var host = process.env.PORT ? '<IP_ADDRESS>' : '<IP_ADDRESS>';
var port = process.env.PORT || 8123;
var cors_proxy = require('cors-anywhere');
cors_proxy.createServer({
originWhitelist: [], // permite todos los orígenes
requireHeader: [],
removeHeaders: ['cookie', 'cookie2'],
setHeaders : {
"x-powered-by": "CORS Anywhere"
}
}).listen(port, host, function() {
console.log('Ejecutando proxy en ' + host + ':' + port);
});
System INFO
| request http://www.cartociudad.es/services/api/route?orig=40.44184877149766,-3.5748567877248845&dest=41.36999441400242,2.1469160601647803&locale=es&vehicle=WALK
| node 6.11.1
| npm 3.10.10
| Operating System Windows 10

Trying with other proxy the result is OK.

Is this proxy also running on localhost?

Yes, the proxy is on localhost (<IP_ADDRESS>:8123)

Not CORS Anywhere, the other proxy that is working according to you. I am asking in order to determine whether the issue is specific to CORS Anywhere, or specific to your local setup (e.g. your IP is blocked by that other site, or your firewall has blocked outbound connections).

oh, sorry. No the other proxy isn't on localhost

When you use another program to send the request to the destination, with the same request headers (e.g. curl), does the request succeed?

Im not working now tomorrow Will test with CURL. Thanks a lot
El 08/11/2017 18:24, "Rob Wu"<EMAIL_ADDRESS>escribió:

When you use another program to send the request to the destination, with
the same request headers (e.g. curl), does the request succeed?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Rob--W/cors-anywhere/issues/94#issuecomment-342891060,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ALUVSI6eDxGuufhWUa2SjSNtcCVGRMFbks5s0eO8gaJpZM4QWT_0
.

More info:
curl -v "<IP_ADDRESS>:8123/http://www.cartociudad.es/services/api/route?orig=43.1514858477619,-4.0472363927932&dest=40.44184877149766,-3.5748567877248845&locale=es&vehicle=WALK"
STATE: INIT => CONNECT handle 0x20081ad8; line 1407 (connection #-5000)
Added connection 0. The cache now contains 1 members
Trying <IP_ADDRESS>...
TCP_NODELAY set
STATE: CONNECT => WAITCONNECT handle 0x20081ad8; line 1460 (connection #0)
Connected to <IP_ADDRESS> (<IP_ADDRESS>) port 8123 (#0)
STATE: WAITCONNECT => SENDPROTOCONNECT handle 0x20081ad8; line 1567 (connection #0)
Marked for [keep alive]: HTTP default
STATE: SENDPROTOCONNECT => DO handle 0x20081ad8; line 1585 (connection #0)
GET /http://www.cartociudad.es/services/api/route?orig=43.1514858477619,-4.0472363927932&dest=40.44184877149766,-3.5748567877248845&locale=es&vehicle=WALK HTTP/1.1
Host: <IP_ADDRESS>:8123
User-Agent: curl/7.51.0
Accept: /
STATE: DO => DO_DONE handle 0x20081ad8; line 1664 (connection #0)
STATE: DO_DONE => WAITPERFORM handle 0x20081ad8; line 1791 (connection #0)
STATE: WAITPERFORM => PERFORM handle 0x20081ad8; line 1801 (connection #0)
HTTP 1.1 or later with persistent connection, pipelining supported
HTTP/1.1 200 OK
x-request-url: http://www.cartociudad.es/services/api/route?orig=43.1514858477619,-4.0472363927932&dest=40.44184877149766,-3.5748567877248845&locale=es&vehicle=WALK
Server Apache-Coyote/1.1 is not blacklisted
server: Apache-Coyote/1.1
content-type: application/json
transfer-encoding: chunked
date: Thu, 09 Nov 2017 09:35:47 GMT
Marked for [closure]: Connection: close used
connection: close
x-final-url: http://www.cartociudad.es/services/api/route?orig=43.1514858477619,-4.0472363927932&dest=40.44184877149766,-3.5748567877248845&locale=es&vehicle=WALK
access-control-allow-origin: *
access-control-expose-headers: server,content-type,transfer-encoding,date,connection,x-final-url,access-control-allow-origin
bbox":["-4.153689089872445","40.44187308607131","-3.5741682031937287","43.152457508872246"],"distance":"353022.13238046836","found":"true","from":"43.1514858477619,-4.0472363927932","geom":"yekfGpcuWRm@f@qATo@Ja@n@gAPaACcBn@MfCu@VKRUb@_
e@tC_@@Gf@KFAA]ZA~DGZCTKpDsBzA}@K_GbDiBl@YVIv@S\OLGLWVQHINERCT@bALATl@AvCV@C|@IdA@hAT@TX@Rh@Ll@DjAHj@LJl@h@NPJEPMVSBPLhALAH^JZVz@LZLZr@hA|@bAp@l@r@h@~@f@|B|@zDv@dARj@Hd@BF@~@XAb@fB~@d@\x@r@dApALT\p@JVPVJVLTL^JVNZLTLVZn@PT^j@P
TNVp@ANRNVZd@T\\j@fAJVLXf@lANVZp@HXj@fAHPBDd@f@b@b@f@\\RNTJRJz@f@C~@pAr@x@l@hAfARPPTNT@f@NZPTJT@f@lAtBp@rANVJNPRJLNFJHEBVLVDTD\DVHTDj@T~@Xn@?xAOf@Wh@]dAoA@e@ROPSd@a@LSlA}@bAWj@AbAN~@^@JV?ASAYROPSTq@B[A_@?@A]?@@_@J{@Tu@L[Zm@
g@ROTIbAQj@?l@Bj@Lj@PRLTHfBnA|@d@TBV?AWj@IV?TDTHb@@t@x@RNj@Vh@VRPB@NLPRB@r@p@h@VTHvAb@f@ZPR^j@NVJXTt@LZJV@j@PFzA^RHTNj@NTHj@VRFj@TAZRLTJRNRHRJvAj@RLTJpAp@RRb@d@LVJZXn@NV\p@NRPT^l@n@ANVNV^j@n@fAJVHZD\\@^H\\JVNTRNTLTJ|@f@THRFn@@bAKl TIRKTMz@g@~@e@tCqATI@CH?TBd@NdAb@RLv@v@AzAJJxDpD\\Vh@PfCLXFTHl@d@b@n@Zz@H@Db@XtBDPDPFLTXXPZBn@Eh@?b@H@ZZb@Pj@Jp@@ZCZ@ZDZHXJVNRPLPHTBT?z@Ud@Eh@@d@Hv@b@hC~C\\VTHTB~BAb@Bj@Pp@@lAnBAtAVTZJZARGbBmAREPCZAAFxBr@h@HbC?AMR@RFRJNNVb@Rt@Xr ApAVVRHRB\\EhBg@rAM^O\\[dBwBXWd@ErADt@NTHpAlA~@\\NLB@bCbEzAhCnAvBrAzCX@VTXLt@JdBH@@dGv@hANfBBnDKb@BlBHjAPx@\fBpAD@B@FFXLx@RfBNt@Xr@j@TXhA|Ax@v@n@b@j@XJBxAb@fAJl@?dCUj@IjAAl@JdBz@^TLDbARACpCi@l@AXHd@Jf@Vd@@hBvCZ@p@h@NFRHb@LpBJdANTJD Bd@b@NTHLP@Rx@FZTxEV~AVr@N\v@AZRNJLDr@^zJhELDj@TZJF@@JB?hAHp@An@Gl@Qz@a@lCsAlAg@j@OBADAt@QfBU~AA@BhBP|C~@fCv@f@Hf@BF?J@x@CdAYfDqA|A[tBObB?hAN|Ah@h@@t@z@l@jATv@|@dF@jAh@|@t@p@^P@J@B@CnDk@z@GnAC~@BPAl@LbAR~CdAhB^vANpIVtCLp@JfAX|
@z@h@fBfBdAv@TLpBb@^Jh@\VVTZ|BxDvDpGXn@Nb@RlAjDt\LbABVHp@LdA@bBnAjDJZ\\jAX~A\\rCTjATl@|A~CV~@Hj@FbABl@MhI?ZK~G?vBHvAPpAPr@?@@FDR^hAd@fAj@x@j@p@hAz@pAf@v@NpENAHjARjAb@fAp@A~@|@rAAvAj@x@n@t@d@^JFDDx@^~@T|@DvAAhB?nBAbABx@@T@L?bB\D@B
BhAl@^\HJFHh@p@@x@LRVt@dBxHFRBH\\z@Vh@t@hA~@~@dAp@b@TfFxAzAp@pAA~A|AZd@f@p@z@bBn@dBZv@f@|@l@z@h@p@h@d@bAx@JF@@RLB~@z@b@VLdAb@nDbBhCvAlAl@D@XNtAb@zBl@z@NrCb@pCNpCDPArDIrBa@~@[fBy@JEtCuBJGd@_@D?x@e@@Qt@UnA]x@QXCZCAAbABz@H~@N~@PhBj@X @Nx@Zr@^bCtAXP~@t@vAlAVTZZBrAvBbBhErDz@p@dBxA|DdDl@f@ZVfGbFfAAvBlBbCfBv@p@dAbATRb@j@\\h@RXVb@DH|AdC@|@x@BJVPZL\\x@nBJ\\Rh@d@vAN^Pj@@vAPt@J@XnAR~@FVNn@v@jDVbADP@HH^b@hBV~@JXb@tAl@|A^t@JXr@pAt@hAXh@bAxAHH\\d@jAdBh@~@b@r@Xf@T@Vf@|@f
ApB^~@Zv@JXJ^HP\hAN@HT@@FP~AlFn@fB@hAJ^Vx@f@lA^x@b@l@JL^@PJRPf@ZLDFB@NPBv@HR@V?\BrA?XCj@ATARAP?h@EZCv@Gn@I^ElAQPEf@KASVCzAa@bGcC~BmAbCsAxBuAjBeBtAcBvBaCpByBjAoANQfCwCtBkBpBeBtBuB|BmAlCa@z@FZHTHlA\\bCpApCx@bAFDEl@CRARCZEf@KZK|@]j

Hi i think i found the problem:
I'm loading the app on localhost and the proxy on <IP_ADDRESS>, in this case fails the request

if load the app over <IP_ADDRESS> the request works !!

More info: Changing my configuration to use localhost in request an proxy.js to run CORS Anywhere on localhost (not <IP_ADDRESS> ) didn´t work:

Is localhost resolving to <IP_ADDRESS> ?

Yes
El 11/11/2017 02:24, "Rob Wu"<EMAIL_ADDRESS>escribió:

Is localhost resolving to <IP_ADDRESS> ?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Rob--W/cors-anywhere/issues/94#issuecomment-343628649,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ALUVSN7rlPjJYtmVil77jDI87s7lwPjdks5s1PdhgaJpZM4QWT_0
.

Curl works right:

Can you use exactly the same curl command as the browser (in the devtools you can right-click on a request row and click to copy as a curl command). Then repeatedly issue the request and remove headers at each step until you found which request header results in a difference of how a request is handled.


readme: Link unclosed version of GC issue

Thanks, @ohAitch for the correction. Normally I'd need to ask you to sign our contributor agreement, but since it was only a 4 character change, I just went ahead and did it myself.
Thanks again!


Convert to using logging module

Main changes:

The log file receives all DEBUG output.
Terminal stdout only displays specific messages intended to always be seen, regardless of DIALOG or LOG_LEVEL.
Terminal stderr displays WARNING or CRITICAL messages or higher by default, but can display DEBUG, INFO, WARNING, and CRITICAL if --verbose flag is used.

Still to decide:

Is winetricks -v too verbose? It created a 1.6 MB file on a single run.
Definitely add an option to --clean-log?

Here's an example of an install.log and stdout.log with current logging configuration:
install.log
stdout.log

    Is winetricks -v too verbose? It created a 1.6 MB file on a single run.
    Definitely add an option to --clean-log?

We can leave -v as it stands. If we want to reduce it in the future, we can. That was the purpose in meaning adding two levels of wine output, for instance, debug and no debug (i.e., the former -D|--debug.
Please squash and push and I will merge. Thanks for this conversion!


Miscellaneous updates

Bumps the uap-core version, as well as SnakeYAML and some build- and test-related things.

Codecov Report

Merging #29 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master    #29   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           6      6
  Lines          79     79
  Branches        5      6    +1
=====================================
  Hits           79     79

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e69ff9f...c788d83. Read the comment docs.

Unilaterally merging since there are no API changes and the updates should be uncontroversial.


Command parsers: use exceptions for error handling #305

Fixes #305.
Proposed merge commit message:
All CommandParser#parse(String) return a generic Command type, instead
of the specific command that they are tasked to parse (for example,
AddCommand for AddCommandParser).

This is because the methods might also return an IncorrectCommand if it
encounters a parse error. However, this behavior is not explicit, as
the CommandParsers are expected to only deal with the type that they
are tasked to parse (for example, the AddCommandParser is expected to
return an AddCommand, and nothing else). This also means that the
caller of the methods are unable to handle parse errors themselves.

Let's change all CommandParser#parse(String) methods to return their
specific command type, and throw a ParseErrorException instead when
encountering an error, to allow the caller to deal with it.

v1
@yamgent submitted v1 for review.

[v1 1/3] Add ParseErrorException
[v1 2/3] Modify all CommandParser#parse(String) to throw ParseErrorException
[v1 3/3] Change CommandParser#parse(String) return type to be more specific

(:books: Archive)

Checkout this PR version locally
git fetch https://github.com/se-edu/addressbook-level4.git refs/pr/333/1/head:BRANCHNAME

where BRANCHNAME is the name of the local branch you want to fetch this PR to.

I'm not sure referring to command parsers in general as CommandParser is a good practice, as that might imply that there is a CommandParser parent class.

v2
@yamgent submitted v2 for review.

[v2 1/4] Add ParseException
[v2 2/4] Modify all command parsers' parse(String) to throw ParseException
[v2 3/4] Change command parsers' parse(String) return type to be more specific
[v2 4/4] Modify Parser#parseCommand(String) to not wrap ParseException

(:books: Archive) (:chart_with_upwards_trend: Interdiff between v1 and v2)

Checkout this PR version locally
git fetch https://github.com/se-edu/addressbook-level4.git refs/pr/333/2/head:BRANCHNAME

where BRANCHNAME is the name of the local branch you want to fetch this PR to.

v3
@yamgent submitted v3 for review.

[v3 1/4] Add ParseException
[v3 2/4] Modify all command parsers' parse(String) to throw ParseException
[v3 3/4] Change command parsers' parse(String) return type to be more specific
[v3 4/4] Modify Parser#parseCommand(String) to not wrap ParseException

(:books: Archive) (:chart_with_upwards_trend: Interdiff between v2 and v3)

Checkout this PR version locally
git fetch https://github.com/se-edu/addressbook-level4.git refs/pr/333/3/head:BRANCHNAME

where BRANCHNAME is the name of the local branch you want to fetch this PR to.

v4
@yamgent submitted v4 for review.

[v4 1/4] Add ParseException
[v4 2/4] Modify all command parsers' parse(String) to throw ParseException
[v4 3/4] Change command parsers' parse(String) return type to be more specific
[v4 4/4] Modify Parser#parseCommand(String) to not wrap ParseException

(:books: Archive) (:chart_with_upwards_trend: Interdiff between v3 and v4)

Checkout this PR version locally
git fetch https://github.com/se-edu/addressbook-level4.git refs/pr/333/4/head:BRANCHNAME

where BRANCHNAME is the name of the local branch you want to fetch this PR to.

@PierceAndy May I have your review for this iteration?

v5
@yamgent submitted v5 for review.

[v5 1/4] Add ParseException
[v5 2/4] Modify all command parsers' parse(String) to throw ParseException
[v5 3/4] Change command parsers' parse(String) return type to be more specific
[v5 4/4] Modify Parser#parseCommand(String) to not wrap ParseException

(:books: Archive) (:chart_with_upwards_trend: Interdiff between v4 and v5)

Checkout this PR version locally
git fetch https://github.com/se-edu/addressbook-level4.git refs/pr/333/5/head:BRANCHNAME

where BRANCHNAME is the name of the local branch you want to fetch this PR to.

v6
@yamgent submitted v6 for review.

[v6 1/4] Add ParseException
[v6 2/4] Modify all command parsers' parse(String) to throw ParseException
[v6 3/4] Change command parsers' parse(String) return type to be more specific
[v6 4/4] Modify Parser#parseCommand(String) to not wrap ParseException

(:books: Archive) (:chart_with_upwards_trend: Interdiff between v5 and v6)

Checkout this PR version locally
git fetch https://github.com/se-edu/addressbook-level4.git refs/pr/333/6/head:BRANCHNAME

where BRANCHNAME is the name of the local branch you want to fetch this PR to.

v7
@yamgent submitted v7 for review.

[v7 1/4] Add ParseException
[v7 2/4] Modify all command parsers' parse(String) to throw ParseException
[v7 3/4] Change command parsers' parse(String) return type to be more specific
[v7 4/4] Modify Parser#parseCommand(String) to not wrap ParseException

(:books: Archive) (:chart_with_upwards_trend: Interdiff between v6 and v7)

Checkout this PR version locally
git fetch https://github.com/se-edu/addressbook-level4.git refs/pr/333/7/head:BRANCHNAME

where BRANCHNAME is the name of the local branch you want to fetch this PR to.

v8
@yamgent submitted v8 for review.

[v8 1/3] Modify all command parsers' parse(String) to throw ParseException
[v8 2/3] Change command parsers' parse(String) return type to be more specific
[v8 3/3] Modify Parser#parseCommand(String) to not wrap ParseException

(:books: Archive) (:chart_with_upwards_trend: Interdiff between v7 and v8)

Checkout this PR version locally
git fetch https://github.com/se-edu/addressbook-level4.git refs/pr/333/8/head:BRANCHNAME

where BRANCHNAME is the name of the local branch you want to fetch this PR to.

v9
@yamgent submitted v9 for review.

[v9 1/3] Modify all command parsers' parse(String) to throw ParseException
[v9 2/3] Change command parsers' parse(String) return type to be more specific
[v9 3/3] Modify Parser#parseCommand(String) to not wrap ParseException

(:books: Archive) (:chart_with_upwards_trend: Interdiff between v8 and v9)

Checkout this PR version locally
git fetch https://github.com/se-edu/addressbook-level4.git refs/pr/333/9/head:BRANCHNAME

where BRANCHNAME is the name of the local branch you want to fetch this PR to.

v10
@yamgent submitted v10 for review.

[v10 1/3] Modify all command parsers' parse(String) to throw ParseException
[v10 2/3] Change command parsers' parse(String) return type to be more specific
[v10 3/3] Modify Parser#parseCommand(String) to not wrap ParseException

(:books: Archive) (:chart_with_upwards_trend: Interdiff between v9 and v10)

Checkout this PR version locally
git fetch https://github.com/se-edu/addressbook-level4.git refs/pr/333/10/head:BRANCHNAME

where BRANCHNAME is the name of the local branch you want to fetch this PR to.

@yamgent please request a review from those who approved earlier than the recent changes.

Do we also need to add a @throws ParseException in all the relevant javadocs as well?

Which does make me wonder if they should be the same commit. I don't have a strong preference for this, but if you want them to be separate please add in a paragraph to [1/3]

To add on, [1/3] and [3/3] should be grouped together (come directly one after another) since they have a strong coupling with each other.

v11
@yamgent submitted v11 for review.

[v11 1/2] Modify all command parsers' parse(String) to throw ParseException
[v11 2/2] Change command parsers' parse(String) return type to be more specific

(:books: Archive) (:chart_with_upwards_trend: Interdiff between v10 and v11)

Checkout this PR version locally
git fetch https://github.com/se-edu/addressbook-level4.git refs/pr/333/11/head:BRANCHNAME

where BRANCHNAME is the name of the local branch you want to fetch this PR to.

v12
@yamgent submitted v12 for review.

[v12 1/2] Modify all command parsers' parse(String) to throw ParseException
[v12 2/2] Change command parsers' parse(String) return type to be more specific

(:books: Archive) (:chart_with_upwards_trend: Interdiff between v11 and v12)

Checkout this PR version locally
git fetch https://github.com/se-edu/addressbook-level4.git refs/pr/333/12/head:BRANCHNAME

where BRANCHNAME is the name of the local branch you want to fetch this PR to.

Merge commit message:

However, this behavior is not explicit, as
the CommandParsers are expected to only deal with the type that they
are tasked to parse (for example, the AddCommandParser is expected to
return an AddCommand, and nothing else). This also means that the
caller of the methods are unable to handle parse errors themselves.

Would this be better?
This causes an unnecessary loss of specificity in the return value type
if the parsing is successful (e.g. receiving a Command object instead
of an AddCommand object), and in the error info if the parsing failed
(e.g. receiving an IncorrectCommand instead of a specific Exception object
containing the exact stack trace).

v13
@yamgent submitted v13 for review.

[v13 1/2] Modify all command parsers' parse(String) to throw ParseException
[v13 2/2] Change command parsers' parse(String) return type to be more specific

(:books: Archive) (:chart_with_upwards_trend: Interdiff between v12 and v13)

Checkout this PR version locally
git fetch https://github.com/se-edu/addressbook-level4.git refs/pr/333/13/head:BRANCHNAME

where BRANCHNAME is the name of the local branch you want to fetch this PR to.

@damithc De-conflicted and also updated the merge commit message.

v14
@yamgent submitted v14 for review.

[v14 1/2] Modify all command parsers' parse(String) to throw ParseException
[v14 2/2] Change command parsers' parse(String) return type to be more specific

(:books: Archive) (:chart_with_upwards_trend: Interdiff between v13 and v14)

Checkout this PR version locally
git fetch https://github.com/se-edu/addressbook-level4.git refs/pr/333/14/head:BRANCHNAME

where BRANCHNAME is the name of the local branch you want to fetch this PR to.

Changes have to be made because EditCommandParserTest could not compile on this PR.

v15
@yamgent submitted v15 for review.

[v15 1/3] Modify all command parsers' parse(String) to throw ParseException
[v15 2/3] Change command parsers' parse(String) return type to be more specific
[v15 3/3] Remove IncorrectCommand

(:books: Archive) (:chart_with_upwards_trend: Interdiff between v14 and v15)

Checkout this PR version locally
git fetch https://github.com/se-edu/addressbook-level4.git refs/pr/333/15/head:BRANCHNAME

where BRANCHNAME is the name of the local branch you want to fetch this PR to.

@damithc I removed IncorrectCommand for this iteration, need you to take a look at it again to approve the new design decision.

v16
@yamgent submitted v16 for review.

[v16 1/3] Modify all command parsers' parse(String) to throw ParseException
[v16 2/3] Change command parsers' parse(String) return type to be more specific
[v16 3/3] Remove IncorrectCommand

(:books: Archive) (:chart_with_upwards_trend: Interdiff between v15 and v16)

Checkout this PR version locally
git fetch https://github.com/se-edu/addressbook-level4.git refs/pr/333/16/head:BRANCHNAME

where BRANCHNAME is the name of the local branch you want to fetch this PR to.

v16: Rebased
@damithc Just a reminder for the review. :)

v17
@yamgent submitted v17 for review.

[v17 1/3] Modify all command parsers' parse(String) to throw ParseException
[v17 2/3] Change command parsers' parse(String) return type to be more specific
[v17 3/3] Remove IncorrectCommand

(:books: Archive) (:chart_with_upwards_trend: Interdiff between v16 and v17)

Checkout this PR version locally
git fetch https://github.com/se-edu/addressbook-level4.git refs/pr/333/17/head:BRANCHNAME

where BRANCHNAME is the name of the local branch you wish to fetch this PR to.


feat: Design System Setup

🔴 [Mandatory] What's the change?

Design System module added
Design related common files moved there.

🔴 [Mandatory] Why do we need this change?

Doodle needs a specified theme and i need to learn how to properly configure the theme on compose :)

Related issues/PRs/Jira ticket links

https://github.com/enesky/Doodle/issues/34

🔴 [Mandatory if it's UI related] Screenshots

Current state of selected colors


fixed set command optional arguments and added tests to set command

#1507
The set command options are not functioning properly.
We found out about it thanks to @Ealenn open an issue.
In order to avoid the repetition of similar bugs, the PR incorporates a fix and a large quantity of tests.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@acarbonetto Please have a look on the tests, see if you think this is a good structure.

Consider adding UT/IT for all options in options

@Yury-Fridlyand - Can you explain a bit more? I'm not sure i understand what is the different from the existing tests to what you offer.

In java client we added UT where we test that all combinations of options are properly converted to command args.


adding liche CI test

adds checks for broken links

Tested by introducing a broken link in a story, which was successfully detected. Removed the broken link and all CI jobs passed. Looks good.


Don't consider the "grace period" when decrypting coinbase outputs

Motivation
ZIP-212 specifies that coinbase transaction with Sapling or Orchard outputs must be decryptable with an all-zero outgoing viewing key, and that

[Canopy onward] Any Sapling or Orchard output of a coinbase transaction decrypted to a note plaintext
according to the preceding rule MUST have note plaintext lead byte equal to 0x02 . (This applies even during
the “grace period” specified in [ZIP-212].)

We'll use librustzcash to implement the decryption in https://github.com/ZcashFoundation/zebra/issues/2362. However, it always allows the "grace period" (some 30K blocks after Canopy activation where the lead byte can be 0x01) and there currently isn't a way to work around that with librustzcash as is.
Work around the issue, either by

Waiting librustzcash to support it
Changing librustzcash to support it
Waiting for our own implementation of the decryption and implementing it there

Since the grace period has long passed, this doesn't seem to be urgent (maybe not even necessary?), but I'm not completely sure.
Specifications

[Heartwood onward] All Sapling and Orchard outputs in coinbase transactions MUST decrypt to a note
plaintext , i.e. the procedure in § 4.19.3 ‘Decryption using a Full Viewing Key ( Sapling and Orchard )’ on p. 67
does not return ⊥, using a sequence of 32 zero bytes as the outgoing viewing key . (This implies that before
Canopy activation, Sapling outputs of a coinbase transaction MUST have note plaintext lead byte equal to
0x01 .)

[Canopy onward] Any Sapling or Orchard output of a coinbase transaction decrypted to a note plaintext
according to the preceding rule MUST have note plaintext lead byte equal to 0x02 . (This applies even during
the “grace period” specified in [ZIP-212].)

https://zips.z.cash/protocol/protocol.pdf#txnencodingandconsensus
Alternatives

Modify the librustzcash API
Set the mandatory Zebra checkpoint after the grace period
Document that Zebra will continue to follow the correct chain due to proof of work (is this ok?)

Related Work

The fastest way to fix this issue would be to set the mandatory Zebra checkpoint after the grace period. That way, we never use the incorrect consensus rules from librustzcash.

This issue will be resolved by the mandatory checkpoint changes in #2368.


How to update an existing installation?

Please document how to upgrade an existing installation from 0.2.7 to 0.3.0

See #200.