Ionic 2

I am looking to use this app in my Ionic 2 projects. It seems there is an issue importing the plugins directly with TypeScript so I used this method:
(<any>window).plugins.AdMob.createBannerView();
I saw you had updated the plugin to have Classes banner:Banner. I tried to use it but I couldn't get it to work.
The problem I have with this is that Ionic 2 comes with a native "AdMob" plugin from https://github.com/floatinghotpot/cordova-admob-pro that uses the same name"AdMob"
Since I am not importing the native plugin in my TypeScript file I feel as if it shouldn't be accessing that plugin API. How can I be sure I am using this plugin and not the native one?

I removed this plugin and it didn't work. Added it back and it worked again. Seems I am accessing this plugin. I still would like some info on how to not use the deprecated functions in Ionic 2 if possible. Thank you.

(window).plugins.AdMob.banner.config( {})
(window).plugins.AdMob.banner.prepare();
(window).plugins.AdMob.banner.show();
I don't know why I didn't think this would work. Closing but if anyone else runs into this issue I hope this helps them spend less time than me figuring it out.

@bflopez I'm also using the Ionic 2 for my projects, and I've even wrote a simple injectable provider to make things easier (to for example switch between different plugins without touching the pages/components). I'm still adding there new stuff, as I find anything is needed in one of my projects.
import { Injectable } from "@angular/core";

@Injectable()
export class AdService {
  constructor() {}

  initialize(banner: string, interstitial: string, reward: string) {
    let engine = this.getEngine();
    if (engine) {
      engine.banner.config({
        id: banner,
        isTesting: false,
        autoShow: true,
        overlap: false
      });

      engine.interstitial.config({
        id: interstitial,
        isTesting: false,
        autoShow: false
      });

      engine.rewardvideo.config({
        id: reward,
        isTesting: false,
        autoShow: false
      });
    }
  }

  getEngine() {
    let engine = window["admob"];
    return engine;
  }

  showBanner() {
    let engine = this.getEngine();
    if (!engine) {
      return;
    }

    engine.banner.prepare();
  }

  removeBanner() {
    let engine = this.getEngine();
    if (!engine) {
      return;
    }

    engine.banner.remove();
  }

  prepareFullScreen() {
    let engine = this.getEngine();
    if (!engine) {
      return;
    }

    engine.interstitial.prepare();
  }

  showFullScreen() {
    let engine = this.getEngine();
    if (!engine) {
      return;
    }

    engine.interstitial.show();
  }

  isFullscreenReady() {
    return new Promise(resolve => {
      let engine = this.getEngine();
      if (!engine) {
        resolve(false);
      } else {
        engine.interstitial.isReady().then(isReady => {
          resolve(isReady);
        });
      }
    });
  }

  prepareRewardVideo() {
    let engine = this.getEngine();
    if (!engine) {
      return;
    }

    engine.rewardvideo.prepare();
  }

  showRewardVideo() {
    let engine = this.getEngine();
    if (!engine) {
      return;
    }

    engine.rewardvideo.show();
  }

  isRewardVideoReady() {
    return new Promise(resolve => {
      let engine = this.getEngine();
      if (!engine) {
        resolve(false);
      } else {
        engine.rewardvideo.isReady().then(isReady => {
          resolve(isReady);
        });
      }
    });
  }
}

Using it is not any kind of magic, so probably anyone playing around with Angular 2 knows how to inject it into the project.

Re-open this to keep track for future improvement.
It should be something like https://github.com/driftyco/ionic-native/blob/master/src/plugins/admob.ts

Hi everyone.
I arrived to this project when finding some way to make sure interstitial is fully loaded before calling its show function. I have received letter from Google that complains about that. My problem was reported here.
The example above seems to have this check feature ( isFullscreenReady()). May you help me with this issue? Is the example above a good start to it!

@ratson I use Ionic on the daily basis and just found out they have introduced support for this library. Awesome! Don't know yet how does it work and if it exposes all the supported interfaces, but definitely worth to look at. I won't be using it in my current projects, but will give it a try in the project I'm currently working at.
http://ionicframework.com/docs/v2/native/adbmobfree/
https://github.com/driftyco/ionic-native/tree/master/src/%40ionic-native/plugins/admob-free

@vintage Thanks for the information, good to know it is supported.


Possible ScummVM integration?

I know this implementation of this game engine is still a work in progress, but I'm wondering if it makes sense to plan a future integration as a ScummVM engine (which already have a good number of RPGs). ScummVM also provides a number of image/sound decoders from old games which helps to reduce code duplication.

Hi, yes we've been discussing a bit with the ScummVM team, and that is something that could be possible in the future.


CS.countries also pulls headers

CS.countries also includes the following pair in the array:
:COUNTRY_ISO_CODE => "country_name"

I got this too, I'm surprised no one else is talking about this - maybe no one really using the gem.
Anyway - i use it just as array so I do this:
(CS.countries.values - ['country_name']).sort

I think its fair to say this is no longer being maintained, I recommend maybe getting each one out and creating your own tables?


Add additional settings to handle CORS

CorsInterceptor in frontend & Access-Control-Allow-Credentials in cloud orchestrator allows HTTP requests to carry cookies
Explicitly added allowed methods
Handle preflight request as specified from MDN

@k311093 PTAL


Bugdown: Add support for autolinking websites if prepended by characters

Fixes #7740

In action:

Thanks @dgarvit! The manual testing examples you did were great; could you also add those to the markdown test suite?
Also, does the frontend js markdown also linkify links?

Also, does the frontend js markdown also linkify links?

Yes, I tried ahttps://www.duckduckgo.com in current master the display was blue briefly then replaced with plain text.

@rishig I added the tests to the test suite!
As @rht mentioned, yes, the front-end js markdown linkifies the links.

Closing as this is abandoned and I don't think it's the right implementation strategy for solving the original issue (as evidenced by all the tests it changes).


Add cypress cheatsheet

Need to have a cypress cheatsheet

I am planning to work on it.
@LuigiImVector , @eshellman , @davorpa


print friendly message with an invalid --ssh-config

If the path given to --ssh-config does not exist then ceph-medic stops
before checks are started and prints a message.
Signed-off-by: Andrew Schoen<EMAIL_ADDRESS>

fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1489447


Bump version to 0.4.1.

As far as I can tell 9e4baf40ebe59b025b7e9a63b50dcc0460dc78a5 avoided any issues with breaking changes, so a minor version bump should be acceptable.

Unfortunately it's semantically a large breaking change, so I'll make a major release bump.


index: md5: don't use state or LargeFileCallback

Reducing to a pure and simple implementation that is easy to add progress bars to. Note that this is currently only used for cloud versioning, where state wasn't working anyway, so this won't change anything for now.
State loading/dumping should be performed on the whole index anyway.

Codecov Report
Base: 58.48% // Head: 58.29% // Decreases project coverage by -0.19% :warning:

Coverage data is based on head (8e82662) compared to base (ee59fc7).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #181      +/-   ##
==========================================
- Coverage   58.48%   58.29%   -0.20%
==========================================
  Files          40       40
  Lines        2522     2520       -2
  Branches      451      340     -111
==========================================
- Hits         1475     1469       -6
- Misses        959      968       +9
+ Partials       88       83       -5

Impacted Files
Coverage Δ

src/dvc_data/index.py
82.79% <100.00%> (ø)

src/dvc_data/hashfile/build.py
59.67% <0.00%> (-1.62%)
:arrow_down:

src/dvc_data/hashfile/tree.py
59.44% <0.00%> (-0.93%)
:arrow_down:

src/dvc_data/hashfile/hash.py
80.20% <0.00%> (-0.21%)
:arrow_down:

src/dvc_data/cli.py
32.10% <0.00%> (ø)

src/dvc_data/hashfile/state.py
35.34% <0.00%> (ø)

src/dvc_data/hashfile/db/index.py
0.00% <0.00%> (ø)

tests/hashfile/test_hash_stream.py
100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


[SPARK-30361][REST] Monitoring URL do not redact information about environment

UI and event logs redact sensitive information. But the monitoring URL, https://spark.apache.org/docs/latest/monitoring.html#rest-api , specifically /applications/[app-id]/environment does not, which is a security issue.
What changes were proposed in this pull request?
REST api response is redacted before sending it
Why are the changes needed?
If no redaction is done for rest API call, it can leak security information
Does this PR introduce any user-facing change?
No
How was this patch tested?
Tested manually

cc @dongjoon-hyun @srowen

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Test build #4978 has started for PR 27018 at commit 6a9ea54.

Test build #4978 has finished for PR 27018 at commit 6a9ea54.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

retest this please

Test build #4978 has finished for PR 27018 at commit 6a9ea54.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

test failures do not look related to this PR

retest this please

Jenkins retest this please

Test build #115870 has started for PR 27018 at commit 6a9ea54.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/20662/
Test PASSed.

Test build #115870 has finished for PR 27018 at commit 6a9ea54.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115870/
Test PASSed.

Gentle ping @vanzin @srowen @HyukjinKwon

Merged to master


RancherOS ami-37b00f21 US-East-1 v0.9.1 doesn't work with anything other than T2-Micro instance.

Rancher Versions:
Server: v0.9.1 AWS US-East-1 ami-37b00f21
Docker Version:
Default for v0.9.1
OS and where are the hosts located? (cloud, bare metal, etc):
AWS
Setup Details: (single node rancher vs. HA rancher, internal DB vs. external DB)
AWS
AMI: ami-37b00f21
Instance: C4.4XL
Environment Type: (Cattle/Kubernetes/Swarm/Mesos)
AWS
Steps to Reproduce:
Attempting to create instance with any type other than T2-Micro will not allow ssh key to be used during creation.
Choose AMI ami-37b00f21 and any instance larger than T2-Micro and after that VM is running I am not able to ssh into the machine.  I changed to version 0.9.0 and it worked so something is broken with the latest AMI (at least ami-37b00f21).
Results:

Duplicate of "Can't get into AWS M4 machines #1751"


Extension of the ReportPortal plugin using API [WIP]

PR should cover following use cases:
1.|  Create one launch for all plans and create suite per each plan
2.|  Additionaly upload new suite/tests to a an existing launch
3.|  Prepare launch with empty (idle) tests and additionally report their results (within the same run id)
4.|  Rerun and upload new version into new Retry item within the last launch based on mapping via names.
5.|  Upload files
6.|  Enable using v2
New implemented options:

option --launch-per-plan for creating a new launch per each plan (default)
option --suite-per-plan for mapping a suite per each plan, all enclosed in one launch (launch uuid is stored in run of the first plan)
option --launch-description for providing unified launch description, intended mainly for suite-per-plan mapping
option --upload-to-launch LAUNCH_ID  to append new plans to an existing launch
option --upload-to-suite SUITE_ID to append new tests to an existing suite within launch

Additional work behind that:

rewritten environment variables to the uniform form TMT_PLUGIN_REPORT_REPORTPORTAL_${option}
enabled to report without results
get launch attributes from all common ones in plans (suite-per-plan)
storing uuids per each launch/suite followed by reusing them (update based on identifiers)
analyzed option combinations

Yet todo:

uploading files
version v2
uploading to suites
check stored identifiers
restrict problematic option combinations
resolve problems with mypy
and lot of small debugging
schemas, documentation and tests

@4N0body5 can you share progress pls?

@4N0body5, is the WIP tag still relevant or is the pull request ready for review?

@4N0body5, is the WIP tag still relevant or is the pull request ready for review?

@psss  This week, I plan to look into uploading files, setting version, fixing the problem with uploading to suites, and resolving problems due to option combinations and plan to remove the tag afterwards.

Thanks for the update, @4N0body5. Nice progress!

PR should cover following use cases:

Create one launch for all plans and create suite per each plan
Additionaly upload new suite/tests to a an existing launch
Prepare launch with empty (idle) tests and additionally report their results (within the same run id)
Rerun and upload new version into new Retry item within the last launch based on mapping via names.
Upload files
Enable using v2

New implemented options:

option --launch-per-plan for creating a new launch per each plan (default)
option --suite-per-plan for mapping a suite per each plan, all enclosed in one launch (launch uuid is stored in run of the first plan)
option --launch-description for providing unified launch description, intended mainly for suite-per-plan mapping
option --upload-to-launch LAUNCH_ID  to append new plans to an existing launch
option --upload-to-suite SUITE_ID to append new tests to an existing suite within launch
option --launch-rerun for reruns with 'Retry' item in RP, name-based mapping, only for suite-per-plan structure.
option --defect-type for passing the defect type to failing tests, enables report idle tests to be additionally updated.

 Would it make sense to cover e.g. the upload files in a separate pull request and not block already finished changes on it? Or is everything here too much intertwined that it would not make sense to have smaller pull requests dedicated to a single change / smaller scope?

... Would it make sense to cover e.g. the upload files in a separate pull request and not block already finished changes on it? Or is everything here too much intertwined that it would not make sense to have smaller pull requests dedicated to a single change / smaller scope?

@psss It does make sense. I guess I'll make a brief look into the issue; If it is no struggle, I'll try adding it, so it can be effectively reviewed with all of others, but as soon as it shows any sign of difficulties, I'll suggest postponing it into another PR.
E.g. with the version I only hope to add one environment variable as a quick (maybe temporary) solution, but I'm not so sure about the upload files.
Definitely, the main priority is debug those already implemented parts.

One thing I am struggling with is how to properly use options like --launch-rerun, --upload-to-suite etc for a rerun. An example would be nice.

One more thing to think about. How a user or an automation will find out URLs od created RP launches. Especially once tests will ve running through TF.

One more thing to think about. How a user or an automation will find out URLs of created RP launches. Especially once tests will ve running through TF.

AFAIK I could only provide it via info log that lists the link in terminal. I'm not sure how TF works, let me know if there's any idea to make the url more available.

/packig test -i full

/packit test -i provision


  On to finding something else.

oh sweet, thank you. gonna close this issue!


updated test that works with pandas 1.2 #1562

This PR addresses #1562
A test requiring sorting was updated such that it works the same with pandas<1.2.0 or pandas>=1.2.0.
The issue was caused by the test having identical values to sort.

I think that having the case with identical values is actually useful, since otherwise we're not checking this edge case. Ideally, I think we should be using a stable sort so results will be consistent in the case of similar values.

I think that having the case with identical values is actually useful, since otherwise we're not checking this edge case. Ideally, I think we should be using a stable sort so results will be consistent in the case of similar values.

Huh, it looks like pandas does not have the option for doing a stable sort here, so maybe we should change the test.

Huh, it looks like pandas does not have the option for doing a stable sort here, so maybe we should change the test.

Yeah, I check to see if there was some option to get the same sorting regardless of the pandas version, but could not find anything. I will merge the change.

Yeah, I check to see if there was some option to get the same sorting regardless of the pandas version, but could not find anything. I will merge the change.


Fix director bug in looking up prefix for cache

Fixes #1241
The bug was introduced in 7.8.0 where the director uses hostname of DataURL of the cache to concatenate with /caches/{hostname} for looking up the namespace prefix for the cache in the registry. This is based on the premise that the default value of Xrootd.Sitename is Server.Hostname, which is what the cache used to register itself at the registry.
However, in most of our ITB/production servers, we changed Xrootd.Sitename to something more human-readable, which causes the discrepancy between director look-up and what register records.
This PR fixes the issue by adding a new field in origin/cache advertisement, RegistryPrefix, which is the full namespace prefix the cache used to register itself at the registry, i.e. /caches/{Xrootd.Sitename}, so that the director can use this value for registry look up.
This extra field will also help use build #1107 in the future.
This PR also fixed a bug in the UI where editing cache registration will prepend /caches/ to the existing namespace prefix, causing duplicated prefix /caches/caches/blah/blah
Come with tests.

@turetske since the bug was introduced in 7.8.0, we should be good to only patch this in for 7.8

@turetske Since Brian suggested a change to the approach, let's hold the patch release for this PR and wait for a revision. I'll try to get this done today so that we can unblock @williamnswanson

@turetske Just talked to Brian and due to backward compatibility issues, we won't do another revision for 7.8, so you are good to release this patch. The revision will come in 7.9.


Jadeite SUnit tests have typo

Open the SUnit tab in the browser.
Hover over the clock in the far right of the pane.
Fix the spelling error 'Mesure'.

in case this is still relevant

Spelling healed by 3.0.51


Issue on google colab

Hi there,
Thank you for your valuable work; it is very much appreciated. However, I encountered an error when trying to run the code on Google Colab.
at line: from nemo.collections.asr.models.msdd_models import NeuralDiarizer

OSError                                   Traceback (most recent call last)
 in <cell line: 11>()
9 import librosa
10 import soundfile
---> 11 from nemo.collections.asr.models.msdd_models import NeuralDiarizer
12 from deepmultilingualpunctuation import PunctuationModel
13 import re
18 frames
/usr/local/lib/python3.9/dist-packages/nemo/collections/asr/init.py in
13 # limitations under the License.
14
---> 15 from nemo.collections.asr import data, losses, models, modules
16 from nemo.package_info import version
17
/usr/local/lib/python3.9/dist-packages/nemo/collections/asr/losses/init.py in
13 # limitations under the License.
14
---> 15 from nemo.collections.asr.losses.angularloss import AngularSoftmaxLoss
16 from nemo.collections.asr.losses.audio_losses import SDRLoss
17 from nemo.collections.asr.losses.ctc import CTCLoss
/usr/local/lib/python3.9/dist-packages/nemo/collections/asr/losses/angularloss.py in
16 import torch
17
---> 18 from nemo.core.classes import Loss, Typing, typecheck
19 from nemo.core.neural_types import LabelsType, LogitsType, LossType, NeuralType
20
/usr/local/lib/python3.9/dist-packages/nemo/core/init.py in
14
15 import nemo.core.neural_types
---> 16 from nemo.core.classes import *
/usr/local/lib/python3.9/dist-packages/nemo/core/classes/init.py in
16 import hydra
17 import omegaconf
---> 18 import pytorch_lightning
19
20 from nemo.core.classes.common import (
/usr/local/lib/python3.9/dist-packages/pytorch_lightning/init.py in
28     _logger.propagate = False
29
---> 30 from pytorch_lightning.callbacks import Callback  # noqa: E402
31 from pytorch_lightning.core import LightningDataModule, LightningModule  # noqa: E402
32 from pytorch_lightning.trainer import Trainer  # noqa: E402
/usr/local/lib/python3.9/dist-packages/pytorch_lightning/callbacks/init.py in
12 # See the License for the specific language governing permissions and
13 # limitations under the License.
---> 14 from pytorch_lightning.callbacks.base import Callback
15 from pytorch_lightning.callbacks.device_stats_monitor import DeviceStatsMonitor
16 from pytorch_lightning.callbacks.early_stopping import EarlyStopping
/usr/local/lib/python3.9/dist-packages/pytorch_lightning/callbacks/base.py in
23
24 import pytorch_lightning as pl
---> 25 from pytorch_lightning.utilities.types import STEP_OUTPUT
26
27
/usr/local/lib/python3.9/dist-packages/pytorch_lightning/utilities/init.py in
16 import numpy
17
---> 18 from pytorch_lightning.utilities.apply_func import move_data_to_device  # noqa: F401
19 from pytorch_lightning.utilities.distributed import AllGatherGrad  # noqa: F401
20 from pytorch_lightning.utilities.enums import (  # noqa: F401
/usr/local/lib/python3.9/dist-packages/pytorch_lightning/utilities/apply_func.py in
27
28 from pytorch_lightning.utilities.exceptions import MisconfigurationException
---> 29 from pytorch_lightning.utilities.imports import _compare_version, _TORCHTEXT_LEGACY
30 from pytorch_lightning.utilities.warnings import rank_zero_deprecation
31
/usr/local/lib/python3.9/dist-packages/pytorch_lightning/utilities/imports.py in
116 _TORCH_QUANTIZE_AVAILABLE = bool([eg for eg in torch.backends.quantized.supported_engines if eg != "none"])
117 _TORCHTEXT_AVAILABLE = _package_available("torchtext")
--> 118 _TORCHTEXT_LEGACY: bool = _TORCHTEXT_AVAILABLE and _compare_version("torchtext", operator.lt, "0.11.0")
119 _TORCHVISION_AVAILABLE = _package_available("torchvision")
120 _WANDB_AVAILABLE = _package_available("wandb")
/usr/local/lib/python3.9/dist-packages/pytorch_lightning/utilities/imports.py in _compare_version(package, op, version, use_base_version)
69     """
70     try:
---> 71         pkg = importlib.import_module(package)
72     except (ImportError, DistributionNotFound):
73         return False
/usr/lib/python3.9/importlib/init.py in import_module(name, package)
125                 break
126             level += 1
--> 127     return _bootstrap._gcd_import(name[level:], package, level)
128
129
/usr/local/lib/python3.9/dist-packages/torchtext/init.py in
4
5 # the following import has to happen first in order to load the torchtext C++ library
----> 6 from torchtext import _extension  # noqa: F401
7
8 _TEXT_BUCKET = "https://download.pytorch.org/models/text/"
/usr/local/lib/python3.9/dist-packages/torchtext/_extension.py in
62
63
---> 64 _init_extension()
/usr/local/lib/python3.9/dist-packages/torchtext/_extension.py in _init_extension()
56         raise ImportError("torchtext C++ Extension is not found.")
57
---> 58     _load_lib("libtorchtext")
59     # This import is for initializing the methods registered via PyBind11
60     # This has to happen after the base library is loaded
/usr/local/lib/python3.9/dist-packages/torchtext/_extension.py in _load_lib(lib)
48     if not path.exists():
49         return False
---> 50     torch.ops.load_library(path)
51     return True
52
/usr/local/lib/python3.9/dist-packages/torch/_ops.py in load_library(self, path)
571             ) from e
572
--> 573         # let the script frontend know that op is identical to the builtin op
574         # with qualified_op_name
575         torch.jit._builtins._register_builtin(op, qualified_op_name)
/usr/lib/python3.9/ctypes/init.py in init(self, name, mode, handle, use_errno, use_last_error, winmode)
372
373         if handle is None:
--> 374             self._handle = _dlopen(self._name, mode)
375         else:
376             self._handle = handle
OSError: /usr/local/lib/python3.9/dist-packages/torchtext/lib/libtorchtext.so: undefined symbol: _ZN2at4_ops10select_int4callERKNS_6TensorElN3c106SymIntE
looks like it is caused by torchtext then i tried to uninstall it and reinstall it. but nothing get changed.

After installing the regular way, you should try to run this:
!pip uninstall torchtext torchaudio -y
!pip install torch==1.13.1 torchvision==0.14.1 torchaudio==0.13.1

Did you solve the problem? I have the same error

thank you there is another error in whisperX


QuickSearch Box on DetailList Grid

Hello!
I want a search option on the DetailList grid
Is there any sample?

I believe there were some samples about sorting and filtering, that may set u in the right direction.
or maybe split grid sample in premium package...

hello @ga5tan  It would be great if you share some reference link here.

Hey @ga5tan  I also add Quickfilter attribute to my details column and it creates the searchbox but couldn't search for the string
I think am missing something very basic Please guide me.

just search here in forums for the in-memory grid search and sorting option
Quickserach usualy works, do you use lookup columns? maybe that needs some extra tricks...

@ga5tan  Thanks for the reply.
As you suggest I have gone through the previous issue but I fail to find actual QuickSearch on detail editor
As well as you can see in the previous screenshot the characteristics constant coming from populate items on the selection of dropdown BOM

and for that I want quicksearch option
Hope this is enough
Thanks in advance!

I dont thin there was quicksearch for in-memory grid.

I've already demonstrated that there is a way to implement search/filtering and sort order on in-memory grids, just search the issues ;)

@brunobola am unable to find search in-memory grid samples. please help me ASAP

I used some code from PermissionCheckEditor.ts and modify it a bit and now my searchbox works perfectly fine like grid serachbox
If anyone needs help regarding this then let me know and for now, am closing this issue

@Shraddha996,   Yes Please , Share the sample code. thank you

@sispk6 add this in your editor.ts file
protected onViewFilter(item: PermissionCheckItem): boolean {
if (!super.onViewFilter(item)) {
return false;
}
        if (!Serenity.SlickTreeHelper.filterById(item, this.view, x => x.ParentKey))
            return false;

        if (this.searchText) {
            return this.matchContains(item) || item.IsGroup && Q.any(this.getDescendants(item, false), x => this.matchContains(x));
        }

        return true;
    }

    private matchContains(item: PermissionCheckItem): boolean {
        //Select2.util.stripDiacritics(item.ItemMaterialDescription || '').toLowerCase().indexOf(this.searchText) >= 0;
        return Select2.util.stripDiacritics(item.CharacteristicsCharacteristicsName || '').toLowerCase().indexOf(this.searchText) >= 0;
    }

    private getDescendants(item: PermissionCheckItem, excludeGroups: boolean): PermissionCheckItem[] {
        let result: PermissionCheckItem[] = [];
        let stack = [item];
        while (stack.length > 0) {
            let i = stack.pop();
            let children = this.byParentKey[i.Key];
            if (!children)
                continue;

            for (let child of children) {
                if (!excludeGroups || !child.IsGroup) {
                    result.push(child);
                }

                stack.push(child);
            }
        }

        return result;
    }

export interface PermissionCheckItem {
    ParentKey?: string;
    Key?: string;
    IsGroup?: boolean;
    CharacteristicsCharacteristicsName?: string;
}


Allow v0.7.1 ODP submissions with an alternative schema url

What's being sent doesn't match what's on GitHub.

OSL will be fixing PlanX to use the correct schema URL


Represent percentage values with maximum available resolution

Is your feature request related to a problem? Please describe.
When encoding a percentage value in a BTHome packet, the value is usually scaled by a factor of 10^n. The data type used is an unsigned integer value with a fixed size. This results in data transmissions which are never utilizing the maximum possible resolution for the used data type.
Describe the solution you'd like
To utilize the maximum possible resolution, percentage values should be encoded with the full resolution possible for the data type. E.g. if using an 8 bit unsigned integer, 100%=255. Thus the scale factor is 1/2^8. If using a 16 bit unsigned integer, the scale factor is 1/2^16
Additional context
This idea arose while implementing the BTHome protocol for b-parasites.
This is obviously not fully required as the current solution functions sufficiently as well. It is just something that is bothering me with the protocol definition as an embedded engineer.

I understand what you are saying. The only issue I saw was that you will get results like 99.6078 % (254/255). From a user point of view, I don't care about the .6078...., I just want to see if it is 100% or 99%. But if you really need it, we can add it, by adding a object_id with factor 1/255.

But if you really need it, we can add it, by adding a object_id with factor 1/255.

Thus, all object_id will end tomorrow.
For household devices, there is not enough id for the mains voltage (110..380+ V):
Id: 0x0C,"voltage", uint16 (2 bytes), step 0.001 -> max 65V.
... Etc.
The v2 format is very complex - it is impossible to implement reception on the MCU if there is an unknown object_id in the transmission. Can't recommend for use.

I have a logged meter that requires transmission:
Voltages: +-32V, 24 bits, step 0.0000038V (3.8uV)
Current: +-500mA, 24 bits, step 0.0000000596A (59.6nA)
And many other options...
object_id is definitely not enough due to the size limit and units in the data.

Why couldn't the size of the object be set to 2 bits of object_id?
00b - 1 byte
01b - 2 bytes
10b - 3 bytes
11b - 4 bytes
Then it will be possible to parse a packet with an unknown identifier.
Then parsing a packet with an unknown id is painless.
The current id table contains a total of 52 id types, 6 with different sizes.
Of these, the maximum number of id with one data byte is 35 types.

We have thought of this and solved this in a slightly different way in V2 format.
A sensor should send the data with object_id's from low to high (numerical order), see this part in the documentation

In that way, the receiver is able to parse all the object_id's with the lower numbers up till it sees an unknown object_id (with a high number). New object_id's will always be added with a higher number than the latest supported number.
There is a warning if the object_id's are not in numerical order.
                if prev_obj_meas_type > obj_meas_type:
                    _LOGGER.warning(
                        "BTHome device is not sending object ids in numerical order (from low to "
                        "high object id). This can cause issues with your BTHome receiver, "
                        "payload: %s",
                        payload.hex(),
                    )

About the measurement types you need/want, it is possible to add these, no problem. Just let me know how many bytes and which factor you want for each measurement
e.g. Voltage, 2 bytes, factor 0.01, unsigned integer (0-655,35 V)
We have also thought of running out of object_ids. We can use the object_ids above 127 (0x7F`) (or something else) to use an extra byte, such that we have 128*256 = 32768 "secondary" object_ids with 2 bytes and 128 "primary" object_ids.
0x7E
0x7F
0x8000
0x8001
etc.

We have thought of this and solved this in a slightly different way in V2 format. A sensor should send the data with object_id's from low to high (numerical order), see this part in the documentation

This does not allow a third-party device to get a selection of only the data it needs, without having the entire decryption table.

Yes, but one can make a smaller decryption table with only the object_id and length of the objects you don’t want. Shouldn’t be that hard. I understand it isn’t ideal, but having to split up the object_ids already in 4 byte lengths isn’t ideal either, as it might limits the number of objects ids of a certain length.
But let’s keep this in mind when we start to develop a BTHome V3 in the future.

Here is a potential solution for a one-byte per object_id decoder table.
static const uint8_t PROGMEM MEAS_TYPES_FLAGS[] = { /* 8th bit Unused | 6-7th bits Factor | 4-5th bits DataType | 1-2-3rd bits DataLen */
  0b00000001, /* 0x00 | packet_id | packet_id | uint8 (1 byte) | 0 */
  0b00000001, /* 0x01 | battery | battery | uint8 (1 byte) | 0 */
  0b01001010, /* 0x02 | temperature | temperature | sint16 (2 bytes) | 2 */
  0b01000010, /* 0x03 | humidity | humidity | uint16 (2 bytes) | 2 */
  0b01000011, /* 0x04 | pressure | pressure | uint24 (3 bytes) | 2 */
  0b01000011, /* 0x05 | illuminance | illuminance | uint24 (3 bytes) | 2 */
  0b01000010, /* 0x06 | mass_kg | mass_kg | uint16 (2 byte) | 2 */
...

https://github.com/afarago/esphome_component_bthome/blob/master/components/bthome_base/bthome_common_generated.h


Add contributing.md file

Description
Adding contribution guidelines file to the project.
Sample file: Contributing Guide

hello @Shruti3004 , I would like to work on this issue .Can you please assign me

@Shruti3004 , @ChakshuGautam
I can work on this issue . Please assign this to me.

Closed at #11


update documentation for custom slot mappings

Proposed changes:

fix https://github.com/RasaHQ/rasa/issues/7211
recommend to use FormValidationAction everywhere.
update how custom slots are extracted
describe how to deal with dynamic slot mappings

Status (please check what you already did):

[ ] added some tests for the functionality
[x] updated the documentation
[ ] updated the changelog (please check changelog for instructions)
[ ] reformat files using black (please check Readme for instructions)

@JulianGerhard21 Happy to hear your feedback on this as well!

Let's define 3 use cases these changes should facilitate (there may be more). For each, I give the steps to do in a custom validation action (subclassing FormValidationAction) that I thought would be necessary & sufficient to solve the use case.
Use case 1: change mapping for an "existing" slot
"Custom Slot Mappings" in docs
Conditions:

The slot is listed for this form in the domain
Want to change only how the slot is extracted

Solution:

Implement extract_{slot} for this slot

Use case 2: add slot to be requested
Conditions:

Some list of slots listed for this form in the domain
Want to change this list by only 1) adding a slot not listed for this form in the domain

Solution:

Override required_slots where I insert my new slot into the existing list of slots coming from the domain (I may want to append, prepend, insert the new slot…)
Implement extract_{slot} only for my new slot

Use case 3: change set of requested slots
"Dynamic Slot Mappings" in docs
Conditions:

Some list of slots listed for this form in the domain
Want to change this list by both 1) adding some more slots, 2) not requiring some of the original ones

Solution:

Override required_slots where I insert my new slot into the existing list of slots coming from the domain and remove from the list the slots I don’t want to request
Implement extract_{slot} only for my new slot

+++++++++++++++++++++++++++++++++++++++++++++++++++++++
Now my comments -- mostly about where the solution I imagine doesn't align with the current implementation or with the proposed docs changes:

For UC1 I shouldn't need to override required_slots because, as @kearnsw pointed out, changing mappings is a different use case than changing which slots the form requires.

UC3 could be renamed from "Dynamic Slot Mappings" to "Dynamic Requested Slots" (proposed by @akelad) because it's not (necessarily) about mappings.

Also re the solution to UC3, @wochinge explained:

"if you defined slot mappings in the domain then Rasa Open Source will consider them by default. In that case you'd need to override missing_slots or next_requested_slot. TBH, it's best to not define any slot mappings in the domain if you advanced stuff like this in your FormValidationAction"

I think the name required_slots doesn't reflect the true purpose of this function. As a user, I'd expect that from there I can change which slots the form requires, but currently I can only add some more slots that the form will require. Could we perhaps change how missing_slots and required_slots are implemented such that inside required_slots the default implementation will grab all slots for this form from the domain, and in missing_slots the default will merely check for slots that aren't filled yet?

Prompted by a question from @wochinge I realised that for UC1 we might not be able to figure out which extract_{slot} method to use if there some mapping defined for a slot in the domain but the user also implements custom mapping, i.e. extract_{slot} in the form validation action. The issue as I understand it is that we first extract slots in FormAction (following the mappings from the domain) and only then call the validation action. If FormAction could "see" that there's a custom extract_{slot} defined, it wouldn't try to extract the given slot at all, but it can't see this. @wochinge is my understanding right?

For UC1 I shouldn't need to override required_slots because, as @kearnsw pointed out, changing mappings is a different use case than changing which slots the form requires.

How would we know which extract_ methods we should call then? We can get this by inspecting the class, but I think being explicit is more helpful then having a lot of logic going on behind the curtains.

UC3 could be renamed from "Dynamic Slot Mappings" to "Dynamic Requested Slots" (proposed by @akelad) because it's not (necessarily) about mappings.

Sure 👍

Could we perhaps change how missing_slots and required_slots are implemented such that inside required_slots the default implementation will grab all slots for this form from the domain, and in missing_slots the default will merely check for slots that aren't filled yet?

mhm, that would mean that the FormValidationAction would always set the requested_slot even if the action only validates slots. I'd like to avoid doing this and rather set the requested_slot in the Rasa Open Source code then 🤔 We could add a check that the FormValidation action only sets the requested_slot in case the output of required_slots(...) is different than the slots defined in the domain though 👍

I realised that for UC1 we might not be able to figure out which extract_{slot} method to use if there some mapping defined for a slot in the domain but the user also implements custom mapping, i.e. extract_{slot} in the form validation action.

I think if an extract_ method is defined and a slot mapping in the domain, we should print a warning. Currently the extract_ method would override any extractions based on mappings in the domain for this slot.

If FormAction could "see" that there's a custom extract_{slot} defined, it wouldn't try to extract the given slot at all, but it can't see this. @wochinge is my understanding right?

I don't think the FormAction has to see if there is extract_ method defined in the SDK. We can just override the extracted slot in the custom action.
My issue is regarding the request to override a slot by defining a extract_<slot name> method in the FormValidationAction without overriding required_slots. We can inspect the python class during runtime and simply call all extract_<slot name> methods we find. However, I consider this too much magic and would rather go for explicitness in this case.

I think if an extract_ method is defined and a slot mapping in the domain, we should print a warning. Currently the extract_ method would override any extractions based on mappings in the domain for this slot.

Now thinking about it, I agree. So then the solution to UC1 would be to implement custom extract_{slot} AND ensure that no mapping is defined for the slot in the domain, right?

We can inspect the python class during runtime and simply call all extract_ methods we find. However, I consider this too much magic and would rather go for explicitness in this case.

I don't have a strong opinion here. Maybe we can use magic if it simplifies the job of the user. If we go for less magic and more transparency, then I'd create a new method (or even just an instance variable of FormValidationAction) called slots_with_custom_mapping or similar, where the user would list the slots they want to extract using custom functions. And then required_slots would be used to manage all the slots required by the form in UC2&3.

So then the solution to UC1 would be to implement custom extract_{slot} AND ensure that no mapping is defined for the slot in the domain, right?

Yes! We can implement a warning in the SDK in case both are defined.

Then I'd create a new method (or even just an instance variable of FormValidationAction) called slots_with_custom_mapping or similar, where the user would list the slots they want to extract using custom functions. And then required_slots would be used to manage all the slots required by the form in UC2&3.

What about this approach?

We could add a check that the FormValidation action only sets the requested_slot in case the output of required_slots(...) is different than the slots defined in the domain though 👍

We could add a check that the FormValidation action only sets the requested_slot in case the output of required_slots(...) is different than the slots defined in the domain though 👍

In the context of UC1, personally, I would still go with a separate place where to specify the slots that should be extracted using custom extract_{slot} functions. For the sake of clarity. Because required_slots is, I think, a misleading name for someone who just wants to do UC1.
In the wider context, though, I think this kind of check could lead users towards using FormValidationAction the intended way. Though we should be careful here: The way I saw people use required_slots, sometimes they don't return the whole list of slots that the form needs to request, only those that haven't been filled yet. Also, the ordering of slots should be taken into account too. So, strictly speaking, I'd say that we should catch the cases where the empty slots in the list returned by required_slots are the same (and in the same order) as the empty slots from the list of slots for the form in the domain.

The way I saw people use required_slots, sometimes they don't return the whole list of slots that the form needs to request

That wouldn't be a problem 👍

So, strictly speaking, I'd say that we should catch the cases where the empty slots in the list returned by required_slots are the same (and in the same order) as the empty slots from the list of slots for the form in the domain.

Thinking about it, having a function additional_slots (or slots_with_custom_mapping) seems actually cleaner and less error prone. Then required_slots would be domain slots + slots with custom mapping.
And we only set a requested_slot in case required_slots is different (different order, different values) than the pure slots from the domain. Does that make sense?
Then things would look like this:

Use case 1: change mapping for an "existing" slot: They can actually use validate_<my slot> for this
Use case 2: add slot to be requested: Override additional_slots and define extract_<my function>
Use case 3: change set of requested slots: Override additional_slots and maybe change next_requested_slot

What do you think?

having a function additional_slots (or slots_with_custom_mapping) seems actually cleaner and less error prone.

I agree -- if we're still talking about the thing meant for UC1.

Then required_slots would be domain slots + slots with custom mapping.

Hmmm, this isn't aligned with the way I understood UC1. I thought the user already had all the required slots listed for the form in the domain, but for the custom mapping ones they didn't define any mapping in the domain and instead implemented custom extract_{slot} methods. Then the role of slots_with_custom_mapping as I understand it is only to remember which ones of the domain slots should be extracted using the custom extractor methods. In other words, slots_with_custom_mapping would always be a subset of domain_slots. Otherwise we bring in the issues from UC2&3.

Use case 1: They can actually use validate_<my slot> for this

I have doubts about this because validate and extract are conceptually different things. But I've seen people doing extraction in validate_{slot} and maybe sometimes the difference isn't so clear. Or maybe I didn't get you and you can explain :-)

Use case 2: Override additional_slots and define extract_<my function>

I think this introduces an unnatural gap between use cases 2 & 3 as we discussed at some point earlier. Because while this works for UC2, you (I assume) can't easily change whether the additional slot(s) will be requested before, after, or in between some of the remaining domain slots. Then the moment you want to change this ordering, you are in UC3 and need a place where you fully customise the list of required slots.

Use case 3: Override additional_slots and maybe change next_requested_slot

Here's the problem. By overriding additional_slots you can't remove some of the domain slots from the required slots list. You also can't change the order. All of these changes you'd have to do somewhere else and next_requested_slot doesn't sound like a natural place. For UC3, I think the right place to make your changes is required_slots, where you have access to both the (unfilled) domain slots and the (unfilled) custom mapping ones and you can re-shuffle them and/or remove some as you need.

@samsucik Updated it according to our talk. Could you please have another look?

I also made the PR with the changes to the SDK https://github.com/RasaHQ/rasa-sdk/pull/338

@melindaloubser1 @JulianGerhard21 @kearnsw Any further comments or can I merge?


[Request] Alert on beforeunload when editing content block or composer form

When I accidentally leave my tab, my content will go away. Let's prevent this accident by alert popup.
It may be related with #7680
It seems easy to implement.
https://stackoverflow.com/questions/53557044/how-to-block-the-popups-alert-on-beforeunload-while-using-custom-alert-popup

No one is interested in this issue...?

Seems like it'd be fairly easy to implement in composer – if there were a pull request we'd certainly look to review and accept it.

Fixed via #9579


Fix syntax error

Fix a syntax error that causes "make[1]: libroboticscape.so: Command not found"

thanks!!


formatting removes comments!

formatting removes comments. do not use this tool until this is fixed.

Hi, @lion444. Thanks for reporting this! Could you provide a sample of commented XML that exhibits this behavior? A simple test using the following XML retains the comment:
<Root><!-- comment --><Node1>value</Node1></Root>

Also, please verify the xmlTools.removeCommentsOnMinify setting is set to false:

let me try your code and check that setting.

I checked the settings. They are as described. I tried your line of code and when I right click->format, the comment goes away!

and is there a way to keep empty lines when formatting? thanks

Do you have any other XML formatting extensions installed? Another extension could be overridding the format command. For example, older versions of the XML Formatter extension are known to remove comments on format. An easy way to verify this is the case, is to use the XML Tools: Minify XML command. If your comments stick around, another extension is likely to blame for the formatting issues. If not, we might try reinstalling the XML Tools extension to verify you have the latest bits.
As far as empty lines, there is currently no way to keep them around. I'll certainly track it as an enhancement request though and get it rolled in to a future build.
Thanks!

Yes, that command kept the comments. Is there a way not to minify? just format?

Okay, so there is definitely another extension installed that has registered itself as a document formatter for the XML language. This is causing your XML comments to be stripped. Unfortunately, the only way to resolve conflicting formatters is to uninstall one.
Regarding empty lines, the best way to keep them around will likely be to skip the minification step when formatting XML (I minify the document before formatting it to keep results consistent). I'll probably expose a setting to make this minification step optional.

Auto Backlog
This issue was created 15+ days ago and is not assigned to an iteration. It will be assigned to the backlog until further action is taken.

Empty line retention tracked in #59.


Can not change field value in form

There is no way to change the field value once they are created, I have create a form with fields initially, then some user interaction will change the status, but all the fields remain the same regardless that I call setState(), in the build function I can see the status data have been changed.
Looking into source code, it looks like the field control state is not recreated and is associated with the attribute as key.

Yes. Kindly use a StatefulWidget.
This is a known issue with stateless widget but I haven't given it much priority since in most cases the form is used within a stateful widget in order to collect data after submission.
Thanks for your contribution, I'll find time to look into it.

@danvick thank but it is already in a StatefulWidget.
Please look at screenshot below
Would a video be of any help ?


Ensure that a device mapper task is referenced until task is complete

DeviceMapper tasks in go use SetFinalizer to clean up C construct
counterparts in the C LVM library.  While thats well and good, it relies
heavily on the exact interpretation of when the golang garbage collector
determines that an object is unreachable is subject to reclaimation.
While common sense would assert that for stack variables (which these DM
tasks always are), are unreachable when the stack frame in which they
are declared returns, thats not the case.  According to this:
https://golang.org/pkg/runtime/#SetFinalizer
The garbage collector decides that, if a function calls into a
systemcall (which task.run() always will in LVM), and there are no
subsequent references to the task variable within that stack frame, then
it can be reclaimed.  Those conditions are met in several devmapper.go
routines, and if the garbage collector runs in the middle of a
deviceMapper operation, then the task can be destroyed while the
operation is in progress, leading to crashes, failed operations and
other unpredictable behavior.
The fix is to use the KeepAlive interface:
https://golang.org/pkg/runtime/#KeepAlive
The KeepAlive method is effectively an empy reference that fools the
garbage collector into thinking that a variable is still reachable.  By
adding a call to KeepAlive in the task.run() method, we can ensure that
the garbage collector won't reclaim a task object until its execution
within the deviceMapper C library is complete.
Signed-off-by: Neil Horman<EMAIL_ADDRESS>
- What I did
- How I did it
- How to verify it
- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

Patch looks good but why on the -hotfixes branch?!

Wrong branch, will submit new PR.


feat: L2 aggregation for uniswap L1 swap

This PR fixes #879 and supports aggregation using public functions where the user can later claim funds in private. It is not full aztec connect style, but almost.
Bridged assets have too high precision for noir to handle 😬 Both dai and weth are 1e18 but we want the u120 to do math on them which is running into trouble when multiplying. To avoid the issue, i'm reducing the precision of input assets by 1e9 in the share computation.
BROKEN
This PR was broken after changes to how the unshielding work in underlying token implementation. Earlier they were requiring only knowledge of the pre-image and ability to create the nullifier, now they also depend on the contract coming from a specific msg_sender. This makes the flow in both the lending and this contract broken since they were using this structure before 🤷. As alluded to in #1743 a standard should be made.
Since only some assets where updated, there are really two paths to this case.

Simply use another token implementation and don't think much about it
Fix the vulnerable tokens, private-"approvals" and then these contracts.

Consider the discussion that @spalladino and I had in https://discourse.aztec.network/t/account-guardians-eip1271-and-recursive-proofs/675
Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.

[ ] If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag.
[ ] I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code.
[ ] Every change is related to the PR description.
[ ] I have linked this pull request to relevant issues (if any exist).

Closed as stale, reopen as needed.


fix(android): Return data uris as an URI

Platforms affected
Android
Motivation and Context

Makes data urls returned as actual URIs instead of just the base 64 encoded data.
This sisters PR https://github.com/apache/cordova-plugin-camera/pull/902
Closes https://github.com/apache/cordova-plugin-camera/issues/420
Description

Prefixes the base64 with the data uri header.
Testing

paramedic tests passes
Manual testing
Checklist

[x] I've run the tests to see all new and existing tests pass
[x] I added automated test coverage as appropriate for this change
[x] Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
[x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
[x] I've updated the documentation if necessary

Doesn’t really fully closes https://github.com/apache/cordova-plugin-camera/issues/420, this only changes the behavior for android, but iOS and browser are still “broken”

Yah, it will be covered by https://github.com/apache/cordova-plugin-camera/pull/911 and https://github.com/apache/cordova-plugin-camera/pull/912


Ducking seems to work globally

My sound config looks like this:
sound_system:
  tracks:
    voice:
      volume: 0.9
      priority: 2
      simultaneous_sounds: 1
      preload: true
      ducking:
        target: music
        delay: 0
        attack: 0.3 sec
        attenuation: 0.45
        release_point: 0.5 sec
        release: 1.0 sec
    sfx:
      volume: 0.9
      priority: 1
      preload: true
      simultaneous_sounds: 3
    music:
      volume: 0.4
      simultaneous_sounds: 1
  buffer: 2048  # previous value was 512
  frequency: 44100
  channels: 1
  master_volume: 0.8
  enabled: true

Ducking works fine and sounds awesome for all callouts. However, I noticed that it also applies to all my sounds in the sfx track. When I remove ducking for callouts it also disappears for sfx. Any idea why that happens and how to fix it?

I'm surprised it works at all assigning it at the track level as it is a sound asset property and not associated with any track attributes.
How about assigning it in the default asset settings as follows:
assets:
    sounds:
        default:
            load: preload
        voice:
            load: preload
            track: voice
            ducking:
              target: music
              delay: 0
              attack: 0.3 sec
              attenuation: 0.45
              release_point: 0.5 sec
              release: 1.0 sec

I can try that. I think I added that loading from the track stuff a while back.

I tried the assets config way and it also happens. Dunno why. I verified that the sounds play in the right track (in verbose log).

Sounds like a real bug. I will write a test to verify and find a fix.
On Wed, Mar 14, 2018 at 3:10 PM jabdoa2<EMAIL_ADDRESS>wrote:

I tried the assets config way and it also happens. Dunno why. I verified
that the sounds play in the right track (in verbose log).
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/missionpinball/mpf-mc/issues/315#issuecomment-373175858,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ALxozcShymlEZ5R8fY3UGdkAtv4NL9v3ks5teYc6gaJpZM4SrDUh
.

Wrote simple test to check sound ducking settings and they are getting set correctly using the assets config method.  Now I need to dive in deeper and see if I can replicate the issue.


Use appropriate HTTP proxies from botocore.

Since PynamoDB breaks abstraction barriers to use botocore's vendored
requests module directly, we ought to thread through the proxies that
exist in the botocore Endpoint. Otherwise we will not respect proxies
that are set by system environment variables or Boto configuration.

Also fixes: #92
@jlafon What would it take to get this merged?

Thanks!

Thanks, @jlafon, do you have any expected timeline for when this might make it into a new release?


use writeFile from fs/promises instead promisify(writeFile)

thanks for this!
why is there a changeset if this is not a feature or a bugfix?

@acao removed!


Added emojis from Emoji Versions 13,0, 13.1, 14.0 and 15.0

Type of changes

[ ] Bug fix
[x] New feature
[ ] Documentation / docstrings
[ ] Tests
[x] Other

Checklist

[x] I've run the latest black with default args on new code.
[x] I've updated CHANGELOG.md and CONTRIBUTORS.md where appropriate.
[ ] I've added tests for new code.
[x] I accept that @willmcgugan may be pedantic in the code review.

Description
Added emojis from Emoji Versions 13.0, v13.1, v14.0, v15.0
Emoji Version 13.0
Approved for release in early 2020. The final list was announced on 2020-01-29, with 117 new emojis arriving on major platforms throughout 2020.
Added Emojis
🥲 Smiling Face with Tear
🥸 Disguised Face
🫀 Anatomical Heart
🫁 Lungs
🫂 People Hugging
🦬 Bison
🦣 Mammoth
🦫 Beaver
🦤 Dodo
🪶 Feather
🦭 Seal
🪲 Beetle
🪳 Cockroach
🪰 Fly
🪱 Worm
🪴 Potted Plant
🫐 Blueberries
🫒 Olive
🫑 Bell Pepper
🫓 Flatbread
🫔 Tamale
🫕 Fondue
🫖 Teapot
🧋 Bubble Tea
🪨 Rock
🪵 Wood
🛖 Hut
🛻 Pickup Truck
🛼 Roller Skate
🪄 Magic Wand
🪅 Piñata
🪆 Nesting Dolls
🪡 Sewing Needle
🪢 Knot
🩴 Thong Sandal
🪖 Military Helmet
🪗 Accordion
🪘 Long Drum
🪙 Coin
🪃 Boomerang
🪚 Carpentry Saw
🪛 Screwdriver
🪝 Hook
🪜 Ladder
🛗 Elevator
🪞 Mirror
🪟 Window
🪠 Plunger
🪤 Mouse Trap
🪣 Bucket
🪥 Toothbrush
🪦 Headstone
🪧 Placard
⚧ Transgender Symbol
🤌 Pinched Fingers (5 skin tone variants included)
🥷 Ninja (5 skin tone variants included)
🤵♂ Man in Tuxedo (5 skin tone variants included)
🤵♀ Woman in Tuxedo (5 skin tone variants included)
👰♂ Man with Veil (5 skin tone variants included)
👰♀ Woman with Veil (5 skin tone variants included)
👩🍼 Woman Feeding Baby (5 skin tone variants included)
👨🍼 Man Feeding Baby (5 skin tone variants included)
🧑🍼 Person Feeding Baby (5 skin tone variants included)
🐈⬛ Black Cat
🐻❄ Polar Bear
🏳⚧ Transgender Flag

Emoji Version 13.1
Emoji 13.1 is the set of emojis recommended for release in September 2020. Additions include mixed skin tone support for all variations of 💏 Kiss and 💑 Couple with Heart, which until this release were only available in default yellow on most major platforms.
Added Emojis
😶🌫 Face in Clouds
😮💨 Face Exhaling
😵💫 Face with Spiral Eyes
❤🔥 Heart on Fire
❤🩹 Mending Heart
🧔♂ Man: Beard (5 skin tone variants included)
🧔♀ Woman: Beard (5 skin tone variants included)

Emoji Version 14.0
Emoji 14.0 is the latest set of emojis recommended for release, approved September 14, 2021 alongside Unicode 14.0.
Additions include mixed skin tone support for 🤝 Handshake, which until now has been only default yellow on most major platforms. Other new emojis include a saluting face, a mirrored disco ball, and biting lip.
Added Emojis
🫠 Melting Face
🫢 Face with Open Eyes and Hand Over Mouth
🫣 Face with Peeking Eye
🫡 Saluting Face
🫥 Dotted Line Face
🫤 Face with Diagonal Mouth
🥹 Face Holding Back Tears
🫱 Rightwards Hand (5 skin tone variants included)
🫲 Leftwards Hand (5 skin tone variants included)
🫳 Palm Down Hand (5 skin tone variants included)
🫴 Palm Up Hand (5 skin tone variants included)
🫰 Hand with Index Finger and Thumb Crossed (5 skin tone variants included)
🫵 Index Pointing at the Viewer (5 skin tone variants included)
🫶 Heart Hands (5 skin tone variants included)
🫦 Biting Lip
🫅 Person with Crown (5 skin tone variants included)
🫃 Pregnant Man (5 skin tone variants included)
🫄 Pregnant Person (5 skin tone variants included)
🧌 Troll
🪸 Coral
🪷 Lotus
🪹 Empty Nest
🪺 Nest with Eggs
🫘 Beans
🫗 Pouring Liquid
🫙 Jar
🛝 Playground Slide
🛞 Wheel
🛟 Ring Buoy
🪬 Hamsa
🪩 Mirror Ball
🪫 Low Battery
🩼 Crutch
🩻 X-Ray
🫧 Bubbles
🪪 Identification Card
🟰 Heavy Equals Sign

Emoji Version 15.0
Emoji 15.0 is the latest set of emojis recommended for release, approved September 13, 2022 alongside Unicode 15.0.
Added Emojis
🫨 Shaking Face
🩷 Pink Heart
🩵 Light Blue Heart
🩶 Grey Heart
🫏 Donkey
🫎 Moose
🪿 Goose
🪽 Wing
🪼 Jellyfish
🪻 Hyacinth
🫛 Pea Pod
🫚 Ginger
🪭 Folding Hand Fan
🪮 Hair Pick
🪈 Flute
🪇 Maracas
🪯 Khanda
🛜 Wireless
🫸 Rightwards Pushing Hand (5 skin tone variants included)
🫷 Leftwards Pushing Hand (5 skin tone variants included)
🐦⬛ Black Bird

Note

The battery emoji code is renamed to charged_battery, as the newly added battery emoji code is low_battery

When? 🙏

When? 🤌  🙏

By 'when' you mean when did I make these changes?😅

No, I mean when it will be merged and new version released 😆 I really need the "pinched fingers" for my big development tool at my work 😅

Oh I honestly don't know. There have been recent releases of Rich but this has not been merged yet.
That being said, I developed my own Emoji Library, you can take a look at it and use that in your project if you want Glyphoji

This would be great!   I was looking to use 🪨 and noticed it didn't work in rich. 😦

This would be great!   I was looking to use 🪨 and noticed it didn't work in rich. 😦

You can find it in glyphoji by using glyph.rock.
Example:
from glyphoji import glyph

print(glyph.rock)

you can take a look at it and use that in your project if you want Glyphoji

Unfortunately, it seems I can't. I use rich_click for having rich markup in click handler docstings and this works really well. Maybe if there were such thing as f-docstring;-)
Example of one subcommand:


Can't get onChange event for non-text input types

Hello! My issue is that onChange function I pass to columns config fires when using inputType=EditControlType.TextField only. It is ignored for any other inputs - DropDown, etc.
UPD: Also, even for TextField - onChange event fires whenever I type a new letter, but it doesn't fire when I submit the changes by clicking Enter. So I'm struggling to implement pushing the values to backend because when onChange fires - it means that the user is continuing input but I don't know when they finish. Please help.

Hi @akgitrus
Thanks for pointing out the bug regarding column onChange. I have just checked-in the code to add support to other EditableControlType types like Dropdown, Date & TagPicker. For the implementation, please check the commented code in 'attachGridValueChangeCallbacks' function in gridconsumer.tsx file. Do let me know if this solves your issue.
Regarding your second question for onChange, column level onChange is just meant to be a callback when the user is making any live changes, where it sends you back the live changes in grid data, even if the user hasnt saved those. This implementation was provided to give control to the user to implement their custom functionality on the grid data if need be.
An example of that would be 'Showing Summation of any number column'. In this case, user may want the summation to be live as he/she edits the values in the number column.
As for your requirement, where you need to push values to backend, column level onChange will not be the right choice.
What you need is 'onGridSave' callback function. You can check the implementation for the same in onGridSave function in gridconsumer.tsx file.
onGridSave gets fired when the user clicks on the 'Submit' button in the grid. The function callback receives entire Grid data. If you need to identify the rows that you have updated, you can use 'grid_row_operation' property in the data like this:-
data.filter(item => item.grid_row_operation == Operation.Update)
Same way you can filter for both Added and Deleted rows as well.
I have updated the onGridSave function to show these implementations as well.
please do let me know if this solves your problem.

Hi Kushal, thank you for quick response and fix! I think it solves my current issue.
Regarding the column's onChange - it is more clear now after your explanation. But consider my idea, may be for future releases, - I didn't want to use the "Submit" button at all - to make the UI more concise and save changes on-the-fly as the user make their input.
Anyways, now I'm ok. Thanks again, appreciate your help.

Hi Kushal, thank you for quick response and fix! I think it solves my current issue.
Regarding the column's onChange - it is more clear now after your explanation. But consider my idea, may be for future releases, - I didn't want to use the "Submit" button at all - to make the UI more concise and save changes on-the-fly as the user make their input.
Anyways, now I'm ok. Thanks again, appreciate your help.

Hi @akgitrus . Point taken. I can consider adding that functionality based on a configuration. May be not triggering onGridSave callbacks as and when the user is typing but when the user is done with on-the-fly changes and wants the grid to auto-reconcile(i.e. without having to explicitly click on the 'Submit' button). Thanks for the feedback.
Since your issue is resolved, I'll close this thread but do feel free to open more issue threads as and when you face any challenges and I can help resolve those. Thanks.


fix(locales): updated translation from Crowdin

:tada: This PR is included in version 3.29.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


IndexOutOfBoundsException

In ChatPatches.cs on line 74 chat is added to the server. You have the following line when chat is added to the server.
if (chatMessage.StartsWith("[morecompanycosmetics]"))
  {
      ReflectionUtils.InvokeMethod(__instance, "AddPlayerChatMessageServerRpc", new object[] {chatMessage, 99});
      return false;
  }

This causes an index out of bounds by trying to get playerID 99 in AddPlayerChatMessageClientRpc.
It seems that
public static bool Prefix(ref HUDManager __instance, ref string chatMessage, int playerId)
        {
            NetworkManager networkManager = __instance.NetworkManager;
            if (networkManager == null || !networkManager.IsListening)
            {
                return false;
            }

            if (networkManager.IsServer)
            {
                if (chatMessage.StartsWith("[replacewithdata]"))
                {
                    chatMessage = ServerReceiveMessagePatch.previousDataMessage;
                    HandleDataMessage(ref chatMessage);
                    return false;
                }
                else if (chatMessage.StartsWith("[morecompanycosmetics]")) // This does not work correctly?
                {
                    // The server already handled this when the server branch was dealing with it.
                    return false;
                }
            }
            else
            {
                if (chatMessage.StartsWith("[morecompanycosmetics]"))
                {
                    HandleDataMessage(ref chatMessage);
                    return false;
                }
            }

            return true;
        }
        ```
and you may want to put another check on playerId here.

@LoafOrc this has already been fixed for the next version https://github.com/notnotnotswipez/MoreCompany/pull/48/files

💀
forgot not everybody has the code that is on the main branch be their code that is live on thunderstore


Add "This is a beta/RC" warning to v2.1 docs

Calico v2.1 has been released, and is no longer in beta, so this is not needed.
A header warning was added in #650. For the next RC, we will need to modify that code so that it doesn't jump to the next release until it is out of RC.


Error when generating HTTPRequest / HTTPResponse handler body

Describe the bug
Current solutions supports defining HTTPRequest and HTTPResponse structs in HTTP handler function definitions.
However, if we define additional struct for our HTTPRequest, e.g. Dependency, and HTTPRequest includes that Dependency as one of the fields, swaggo/swag cli will report an error and won't produce valid yaml.
To Reproduce
Steps to reproduce the behavior:

Create file with this content:

package main

import (
	"net/http"
)

func main() {

}

// HelloWorld says hello to the world.
//
//	@Summary		Hello world.
//	@Description	Hello world.
//	@Id				hello-world
//	@Accept			json
//	@Produce		json
//	@Param			request	body	main.HelloWorld.HTTPRequest	required	"HTTP Request Body"
//	@Success		204
//	@Failure		400
//	@Router			/hello-world [POST]
func HelloWorld() http.HandlerFunc {
	type Dependency = struct {
		Name string `json:"name"`
	}

	type HTTPRequest struct {
		SingleDep    Dependency   `json:"single_dep"`
		Dependencies []Dependency `json:"dependencies"`
	}

	return func(writer http.ResponseWriter, request *http.Request) {
	}
}

Run swag init --v3.1 --parseInternal --ot "json,yaml" --output ./spec

Output will be unexpected (missing fields in HTTPRequest definition)

components:
  schemas:
    main.HelloWorld.HTTPRequest:
      type: object
externalDocs:
  description: ""
  url: ""
info:
  description: Hello world.
  title: ""
  version: ""
openapi: 3.1.0
paths:
  /hello-world:
    post:
      description: Hello world.
      operationId: hello-world
      requestBody:
        content:
          application/json:
            schema:
              $ref: '#/components/schemas/main.HelloWorld.HTTPRequest'
        description: HTTP Request Body
        required: true
      responses:
        "204":
          description: No Content
        "400":
          description: Bad Request
      summary: Hello world.

Your swag version
Swag version:  v2.0.0
Your go version
go version go1.21.4 darwin/arm64
Desktop (please complete the following information):

OS: MacOS Ventura 13.6.1
Browser: Chrome
Version: 119.0.6045.159

Here is an example of PR which fixes it: https://github.com/svennjegac/swag/pull/1
(I opened it on my fork, will open it on this original repo if you agree)
cc @Nerzal


In case of a failed verification (RED), the app should only display the reason for the fail

Describe the bug
Despite a failed verification, the verifier app shows the certificate data set and no reason for failure is shown.

Expected behaviour
In case of a failed verification (RED), the app should only display the reason for the fail.

Steps to reproduce the issue

Open verifier app;
Scan a QR-Code for an invalid certificate.

Technical details
Galaxy XCover 4, Modellnummer: SM-G390F,
Android-Version: 9, Verifier App 1.0.0
Possible Fix

Additional context

Additional info: This behaviour decribed above occures just only for Android-VerifierApp.
IOS-VerifierApp shows only the reason(s) of the failed check (without showing any further datas of the vaccination and the vaccinated person).

This Certificate is invalid.  The reason is: "The test result is positive."

After scanning the above invalid QR Code with the iOS Verifier App -- the reason for invalidation is displayed: "The test result is positive."

Other specific Errors to be displayed are: "The cryptographic Signature is invalid.", "The test date is in the future", etc.

PR: https://github.com/eu-digital-green-certificates/dgca-verifier-app-android/pull/48

PRs:
https://github.com/eu-digital-green-certificates/dgca-verifier-app-android/pull/66
https://github.com/eu-digital-green-certificates/dgca-app-core-android/pull/19

retested in release 1.0.5


TagBot trigger issue

This issue is used to trigger TagBot; feel free to unsubscribe.
If you haven't already, you should update your TagBot.yml to include issue comment triggers.
Please see this post on Discourse for instructions and more details.
If you'd like for me to do this for you, comment TagBot fix on this issue.
I'll open a PR within a few hours, please be patient!

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/114823

Triggering TagBot for merged registry pull request
This extra notification is being sent because I expected a tag to exist by now, but it doesn't.
You may want to check your TagBot configuration to ensure that it's running, and if it is, check the logs to make sure that there are no errors.


Fix comma in exit Ghidra while actions are running prompt

This makes one wonder if that comma ever had a purpose or if it was just trying to fit in.

All it ever wanted was to be wanted.
On another note, I can't help but wonder why on Earth a StringBuffer is being used here. It doesn't even need to be a StringBuilder. Iirc it can just be a normal string that is concatenated as StringBuilder will be used under the hood.

On another note, I can't help but wonder why on Earth a StringBuffer is being used here. It doesn't even need to be a StringBuilder. Iirc it can just be a normal string that is concatenated as StringBuilder will be used under the hood.

Now you are really looking at how the sausage is made.    Ghidra is old.  So old, that the code predates the JVM update that switched to using string buffers under the hood.  (I'm speculating a bit here, but I am pretty confident that some of the code was written before Java 1.2, for reference.).  At this point, we have so much code that still uses StringBuilders to compose elementary stings that could probably be replaced with basic concatenation without losing performance.  However, to change all of those places is not only a large effort, it would also make the code somewhat stylistically inconsistent, unless we updated all use cases.
Think of reading this code as software archeology.

On another note, I can't help but wonder why on Earth a StringBuffer is being used here. It doesn't even need to be a StringBuilder. Iirc it can just be a normal string that is concatenated as StringBuilder will be used under the hood.

Now you are really looking at how the sausage is made. Ghidra is old. So old, that the code predates the JVM update that switched to using string buffers under the hood. (I'm speculating a bit here, but I am pretty confident that some of the code was written before Java 1.2, for reference.). At this point, we have so much code that still uses StringBuilders to compose elementary stings that could probably be replaced with basic concatenation without losing performance. However, to change all of those places is not only a large effort, it would also make the code somewhat stylistically inconsistent, unless we updated all use cases.
Think of reading this code as software archeology.

That is fair. However it is still a StringBuffer vs StringBuilder thing where StringBuffer is synchronized and StringBuilder is not. It should at least be changed to StringBuilder since that portion requires no synchronization.

It's also worth noting that string concatenation using + will be simplified when the result is a constant expression (JLS §15.8.1, JLS §15.29).  So for multi-line string constants joined with +, there would be a slight (probably negligible) performance improvement.  (I don't think the same optimization happens when using += multiple times though.)

That is fair. However it is still a StringBuffer vs StringBuilder thing where StringBuffer is synchronized and StringBuilder is not. It should at least be changed to StringBuilder since that portion requires no synchronization.

This is true.  These we do fix as we run into them.


Error Placement is only calling first time

I am using the "errorPlacemen" inside the .validate method but it´s only been called the first time the form has errors.
For example:
Input A has validation errors ---->> I click on Submit -->> errorPlacement is called --->> I correct Input A ---> the error disappears --->> I make another error on Input A ---> the error appears again but errorPlacement IS NOT called !!!

I'm sorry for the lack of activity on this issue. Instead of leaving it open any longer, I decided to close old issues without trying to address them, to longer give the false impression that it will get addressed eventually.
To the reporter (or anyone else interested in this issue): If you're affected by the same issue, consider opening a new issue, with a testpage that shows the issue. Even better, try to fix the issue yourself, and improve the project by sending a pull request. This may seem daunting at first, but you'll likely learn some useful skills that you can apply elsewhere as well. And you can help keep this project alive. We've documented how to do these things, too. A patch is worth a thousand issues!


[backstage-plugin-jira] Support custom jql queries

We would like to be able to retrieve the number of issues matching a custom JQL query.
Feature Suggestion
It would be great to be able to provide JQL queries in our entities, alongside the plugin configuration. Those queries would be used to display the number of issues matching them.
Possible Implementation
I took the liberty to try out a potential implementation, you can see it on my fork : https://github.com/tbourrelovh/roadie-backstage-plugins/commit/12909b06de149e7d9a39881fb6a2027c58227b4b
Main changes being in :

plugins/frontend/backstage-plugin-jira/src/types.ts
plugins/frontend/backstage-plugin-jira/src/hooks/useProjectEntity.ts
plugins/frontend/backstage-plugin-jira/src/hooks/useCustomQueriesCount.ts
plugins/frontend/backstage-plugin-jira/src/components/JiraCard/components/CustomQueryStatus.tsx
plugins/frontend/backstage-plugin-jira/src/components/JiraCard/JiraCard.tsx
plugins/frontend/backstage-plugin-jira/src/api/index.ts

Some changes where induced by prettier 🙂
Entity configuration
metadata:
  ...
  annotations:
    jira/project-key: MYPROJECT
  jira:
    count:
      - title: "P1 & P2"
        query: 'project = MYPROJECT AND issuetype = Incident AND status = Open AND "Application Services DTR" = SERVICE AND Severity in (P1, P2)'
      - title: "P3, P4, P5"
        query: 'project = MYPROJECT AND issuetype = Incident AND status = Open AND "Application Services DTR" = SERVICE AND Severity in (P3, P4, P5)'
      - title: "All bugs"
        query: 'project = MYPROJECT AND issuetype = Bug  AND "Application Services DTR" = SERVICE'
    ...

Display
In term of displaying the data, I thought that it could be added in an another section under the actual count section.

Context
We want to track the number of issues based on custom fields in our jira issues.

@tbourrelovh Thanks for the feature suggestion! I think the idea is good, do you mind opening a PR and we could take it to the implementation and get started reviewing it, if you are comfortable with it!:)

Great news  @kissmikijr !
I'll gladly do it 👍

I opened the PR https://github.com/RoadieHQ/roadie-backstage-plugins/pull/390

Hey @tbourrelovh we have discussed with the maintainers of backstage. They said it is valid however they suggested for this particular use case a backend plugin would be more suitable and I agree, I think it will be better as a backend plugin.
We won't have the time for this in the near future, but feel free to try to move it into a backend plugin, however at this point I think it might be more useful to start ideating about this plugin in its current shape and form, I think it worth a redesign.
Thank you for your patience with this issue and pull request!
I share your concerns regarding how each team would be able to set the list of queries they'd like to be executed when using a backend plugin. Maybe it would be possible to read entity files to fetch the jira/project-key annotation and the queries to execute too, but it would still mean having the queries in a custom metadata section...
Moreover, having a backend plugin managing the requests would still mean having a frontend plugin responsible for displaying the data, am I right ?

Going on with the actual shape of the plugin. What do you have in mind concerning the redesign ?
On my internal fork, I have implemented a sort of "guard" to filter out JQL queries attempting to call another project than the one defined in the jira/project-key annotation, would you be interested in it ?

Sorry, lot of questions 😄
And don't worry, I prefer we take the time necessary to implement this feature in a future-proof manner, instead of making future changes harder...

Hello @kissmikijr 🙂
Can I do something to move forward with the implementation ?


[Bug] Fix CLIENT_REGISTER behavior in ConsumerManager#registerConsumer

Before Creating the Bug Report

[X] I found a bug, not just asking a question, which should be created in GitHub Discussions.

[X] I have searched the GitHub Issues and GitHub Discussions  of this repository and believe that this is not a duplicate.

[X] I have confirmed that this bug belongs to the current repository, not other repositories of RocketMQ.

Runtime platform environment
No need
RocketMQ version
5.1.0
JDK Version
No response
Describe the Bug
The ConsumerGroupEvent CLIENT_REGISTER means that the client of this consumer is new registered. So the callConsumerIdsChangeListener CLIENT_REGISTER should be called when updateChannel return true.
https://github.com/apache/rocketmq/blob/3aa5d1936f1162afefccdf03fcc55bf0f7ee642c/broker/src/main/java/org/apache/rocketmq/broker/client/ConsumerGroupEvent.java#L33-L36
https://github.com/apache/rocketmq/blob/3aa5d1936f1162afefccdf03fcc55bf0f7ee642c/broker/src/main/java/org/apache/rocketmq/broker/client/ConsumerGroupInfo.java#L135-L166
Steps to Reproduce
No need
What Did You Expect to See?
The ConsumerGroupEvent CLIENT_REGISTER should be called when a new client is registered.
What Did You See Instead?
The ConsumerGroupEvent CLIENT_REGISTER is called when a new group is first registered.
Additional Context
No response

it is useful


vcpkg install freetype

D:\software\MeshLab>vcpkg install freetype
The following packages will be built and installed:
freetype[core]:x86-windows
Starting package 1/1: freetype:x86-windows
Building package freetype[core]:x86-windows...
-- CURRENT_INSTALLED_DIR=D:/software/vcpkg/vcpkg/installed/x86-windows
-- DOWNLOADS=D:/software/vcpkg/vcpkg/downloads
-- CURRENT_PACKAGES_DIR=D:/software/vcpkg/vcpkg/packages/freetype_x86-windows
-- CURRENT_BUILDTREES_DIR=D:/software/vcpkg/vcpkg/buildtrees/freetype
-- CURRENT_PORT_DIR=D:/software/vcpkg/vcpkg/ports/freetype
-- Downloading http://download.savannah.gnu.org/releases/freetype/freetype-2.8.1.tar.bz2...
-- Downloading http://download.savannah.gnu.org/releases/freetype/freetype-2.8.1.tar.bz2... Failed. Status: 7;"Couldn't connect to server"
CMake Error at scripts/cmake/vcpkg_download_distfile.cmake:155 (message):
  Failed to download file.
  If you use a proxy, please set the HTTPS_PROXY and HTTP_PROXY environment
  variables to "https://user:password@your-proxy-ip-address:port/".
  Otherwise, please submit an issue at https://github.com/Microsoft/vcpkg/issues

Call Stack (most recent call first):
ports/freetype/portfile.cmake:4 (vcpkg_download_distfile)
scripts/ports.cmake:72 (include)
Error: Building package freetype:x86-windows failed with: BUILD_FAILED
Please ensure you're using the latest portfiles with .\vcpkg update, then
submit an issue at https://github.com/Microsoft/vcpkg/issues including:
Package: freetype:x86-windows
Vcpkg version: 0.0.113-nohash
Additionally, attach any relevant sections from the log files above.
I notice that there is an issue about the problem. And I've tried  "Project->C++->Command Line" to add " /source-charset: utf-8 " But it doesn't work.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: fbf8c665-4a38-7b59-e9e9-4887092c0aec
Version Independent ID: c3fb32c6-e29e-9a2f-cdac-d68502a86dc4
Content: vcpkg-- A C++ package manager for Windows, Linux and MacOS
Content Source: docs/vcpkg.md
Service: unspecified
Product: visual-cpp
GitHub Login: @mikeblome
Microsoft Alias: mblome

Thanks @Modori1998. I have forwarded this to the product team.

@Modori1998
Just tried to install freeetype, and works fine now.
the error you got, mean at the time you tried to install, the server was down or too busy to allow you download the archive.
Let us know if problem persists.


RouteCollectionBuilderToRoutingConfiguratorRector should not rename confifgureRoutes to configureRouting

The following fixer:
https://github.com/rectorphp/rector-symfony/blob/a0af12a8d67d0edefe6cffd22cdced62729a1dd9/rules/Symfony51/Rector/ClassMethod/RouteCollectionBuilderToRoutingConfiguratorRector.php#L78-L132
renames the kernel's configureRoutes() method to configureRouting(). However, it looks like Symfony didn't rename the method they are looking for, so after the fixer fixes the code, this method is no longer being used.

Also, the fixer doesn't fix any other usages of the RouteCollectionBuilder class. For example, if the configureRoutes() method passes its $routes argument to another method, that other method remains unfixed and still requires an instance of RouteCollectionBuilder and not a RoutingConfigurator.
Here's an example of such kernel: https://github.com/BitBagCommerce/OpenMarketplace/blob/master/src/Kernel.php.

Hi, could you send a faling test fixture for RouteCollectionBuilderToRoutingConfiguratorRector? That way we'll have it covered and can fix the behavior

I'm looking into this and this change comes only in Symfony 5.1:
https://github.com/symfony/symfony/pull/32937
It should not be used in previous version and could have changed in future versions. If that happened and Rector missed this change, it will require a new rule in particular Rector versoin

To reopen, please send a failing test fixture to RouteCollectionBuilderToRoutingConfiguratorRectorTest so we know exactly what is being changed :)

I'm looking into this and this change comes only in Symfony 5.1: symfony/symfony#32937
It should not be used in previous version and could have changed in future versions. If that happened and Rector missed this change, it will require a new rule in particular Rector version

Maybe this PR was later reversed? Because even when looking at this file in 5.1 branch, I don't see any references to configureRouting(), but I definitely see some to configureRoutes(). Or am I confusing something?

In fact, if you look at the history of this file, you'll find that the change you referenced (Nov. 25, 2019) was overwritten a couple weeks later (Dec 13, 2019) and the method name was changed back.
I'm not sure how you decide to write these fixers, but I suppose it would be safer to work on them only when the relevant target branch tags a stable release, and to look at the UPGRADE-x.y.md file first.

I see. It's possible this rule was created in that window.  Thanks for investigation :+1:
Could you send a PR to remove this rule then?

Please take care of this if you can. :pray: I'm not sure when I would get to this myself.

No worries, I'll check it when I found some time


Disable zombie catching by default

I don't think that enabling this functionality by default is a good idea.

Why is it not a good idea?

It operates application runtime and interacting with core objects memory management. I've seen crashes in the handleDealloc_NSObject function. And anyone who wants to disable zombie handling has to have it enabled it first with all runtime manipulations.

Good point.


An example issue

What extention/adblocker/firewall do you have?

[ ] AdBlock Plus
[ ] AdGuard (browser)
[X] uBlock Origin
[ ] Other (explain)

What OS/browser do you have (optional)
FreeBSD 1.0
What list(s) are you using?

[X] Porn.txt
[X] Antirickroll
[ ] Antimalware
[ ] Other (explain)

What other lists do you have (optional - helps me find the problem)
Bob's anti-cheese
uBlock Origin badware
What is the issue?
This is an example issue

[ ] Is this a feature request?
[X] Is this site breakage?

If it is site breakage, how is the site broken:
This is an example.
Site breakage would be images not loading or you can not sign in.

Oh no!
This example issue must be fixed

Please provide a url where this breakage happens

https://example.com

https://example.com

Confirmed

@iam-py-test what other extensions do you have?

@iam-py-test I only have uBlock Origin installed


On Route method, when fails to retrieve a route param, always calls ThrowIfAnyErrors();

Since I am handling errors using ProblemDetails API and a Global ExceptionHandler, I would like to handle the errors when a route param cannot be cast to, for example an integer and use my own error handling.
It will be nice to have this ThrowIfAnyErrors() as optional in the Route method.

And then be able to handle validation like this:

PS: I am already using DontThrowIfValidationFails() in the configure method, but the Route method call seems to ignore it.

have you tried the following:
public override void Configure()
{
    DontCatchExceptions();
}

Oh yeah, that works! So that will also works with DTOs validation and I can remove DontThrowIfValidationFails() method?


Management Group Scope Missing

It states "levels at which you can scope access to Azure blob and queue resources". Shouldn't Management Groups be listed as well???
Cheers,
Jeff Smalley MCT
Chicagoville

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1ca94e03-5f05-6703-1672-8062f31c0780
Version Independent ID: a6a8d9e9-9aac-c0ed-c474-34cbd0609584
Content: Use the Azure portal to assign an RBAC role for data access - Azure Storage
Content Source: articles/storage/common/storage-auth-aad-rbac-portal.md
Service: storage
Sub-service: common
GitHub Login: @tamram
Microsoft Alias: tamram

@JeffSmalley - Thanks for brining this to our attention. We will investigate it further and update you shortly.

#reassign: @tamram

@JeffSmalley - This article is specifically about assigning RBAC roles for accessing blob and queue data, as stated in the title. Management roles are covered elsewhere in the Azure docs.
Please see these sentences in the article for links to resources about assigning management roles:
Only roles explicitly defined for data access permit a security principal to access blob or queue data. Built-in roles such as Owner, Contributor, and Storage Account Contributor permit a security principal to manage a storage account, but do not provide access to the blob or queue data within that account via Azure AD.
For detailed information about built-in RBAC roles for Azure Storage for both the data services and the management service, see the Storage section in Azure built-in roles for Azure RBAC. Additionally, for information about the different types of roles that provide permissions in Azure, see Classic subscription administrator roles, Azure RBAC roles, and Azure AD roles.
You can see that assigning management roles with the portal is covered in the RBAC docs:
Add or remove Azure role assignments using the Azure portal
#please-close

I think you are missing my thought.  I am talking about the absence of the Management Group scope in the article.  It mentions the Storage Account itself, the Resource Group, and the Subscription as possible scopes. If you are mentioning that, you should be complete and add the Management Group scope as well.
Cheers,
Jeff
On Jul 13, 2020, at 1:45 PM, PRMerger17<EMAIL_ADDRESS>wrote:

Closed #58824.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

@JeffSmalley - I am not sure what "management group scope" refers to. There are four scopes that support RBAC role assignment for data access in storage:

subscription
resource group
storage account
container/queue

Though I have not tried to see if it works, you can assign identities to Storage related roles on Management Groups. Attached is a png picture from the Azure portal.
In terms of general Azure resource scope hierarchies for RBAC, it goes:
--Management Groups
--Subscriptions

  --Resource Groups

    ---Resources (i.e. Storage Accounts)

Source: https://docs.microsoft.com/en-us/azure/role-based-access-control/overview
Jeff
From: Tamra Myers<EMAIL_ADDRESS>Sent: Monday, July 13, 2020 3:32 PM
To: MicrosoftDocs/azure-docs<EMAIL_ADDRESS>Cc: JeffSmalley<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/azure-docs] Management Group Scope Missing (#58824)
@JeffSmalley https://github.com/JeffSmalley  - I am not sure what "management group scope" refers to. There are four scopes that support RBAC role assignment for data access in storage:

subscription
resource group
storage account
container/queue

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/MicrosoftDocs/azure-docs/issues/58824#issuecomment-657778592 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AD7MIMXUMFS44CZOAK7H6LDR3NVMXANCNFSM4OXCX2MA .  https://github.com/notifications/beacon/AD7MIMUYTMJQUKSTFAZRPJLR3NVMXA5CNFSM4OXCX2MKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOE42OPIA.gif

@JeffSmalley - Thanks for pointing this omission out to us. You're right, the list should include management groups. I've updated the doc accordingly.
#please-close