Use _64 ILP64 symbols for MKL

MKL 2022.0.1 now has ILP64 symbols with a _64 suffix. I've verified this on Linux, and presumably this has been implemented on Mac and Windows too.
$ nm libmkl_intel_ilp64.so | grep -i _64 | grep -i dpotrf
000000000036f7c0 T dpotrf2_64
000000000036f7c0 T DPOTRF2_64
000000000035f900 T dpotrf_64
000000000035f900 T DPOTRF_64

julia> dlopen(joinpath(MKL_jll.artifact_dir, "lib", "libmkl_intel_ilp64.so"))
ERROR: could not load library "/home/mose/.julia/artifacts/c284c144ceaa0b7ab2811b3726c4efc008a13bf0/lib/libmkl_intel_ilp64.so"
/home/mose/.julia/artifacts/c284c144ceaa0b7ab2811b3726c4efc008a13bf0/lib/libmkl_intel_ilp64.so: undefined symbol: mkl_blas_dgemm
Stacktrace:
 [1] dlopen(s::String, flags::UInt32; throw_error::Bool)
   @ Base.Libc.Libdl ./libdl.jl:117
 [2] dlopen (repeats 2 times)
   @ ./libdl.jl:117 [inlined]
 [3] top-level scope
   @ REPL[54]:1

julia> filter(l -> contains(l, "NEEDED"), readlines(`readelf -d $(joinpath(MKL_jll.artifact_dir, "lib", "libmkl_intel_ilp64.so"))`))
1-element Vector{String}:
 " 0x0000000000000001 (NEEDED)             Shared library: [libdl.so.2]"

It has undefined symbols and depends exclusively only on libdl....

julia> dlopen(joinpath(MKL_jll.artifact_dir, "lib", "libmkl_intel_ilp64.so"))
ERROR: could not load library "/home/mose/.julia/artifacts/c284c144ceaa0b7ab2811b3726c4efc008a13bf0/lib/libmkl_intel_ilp64.so"
/home/mose/.julia/artifacts/c284c144ceaa0b7ab2811b3726c4efc008a13bf0/lib/libmkl_intel_ilp64.so: undefined symbol: mkl_blas_dgemm
Stacktrace:
 [1] dlopen(s::String, flags::UInt32; throw_error::Bool)
   @ Base.Libc.Libdl ./libdl.jl:117
 [2] dlopen (repeats 2 times)
   @ ./libdl.jl:117 [inlined]
 [3] top-level scope
   @ REPL[54]:1

julia> filter(l -> contains(l, "NEEDED"), readlines(`readelf -d $(joinpath(MKL_jll.artifact_dir, "lib", "libmkl_intel_ilp64.so"))`))
1-element Vector{String}:
 " 0x0000000000000001 (NEEDED)             Shared library: [libdl.so.2]"

It has undefined symbols and depends exclusively only on libdl....

I can confirm the macOS library has the ILP64 symbols:
% julia-16 --compile=min -e 'using BinaryBuilderBase; BinaryBuilderBase.runshell(Platform("x86_64", "macos"))'
sandbox:${WORKSPACE} # nm MKL.v2022.0.0.x86_64-apple-darwin/lib/libmkl_intel_ilp64.dylib | grep -i 'dpotrf.*_64'
0000000000771060 T _DPOTRF2_64
0000000000717220 T _DPOTRF_64
0000000000770eb0 T _dpotrf2_64
0000000000716f40 T _dpotrf_64

As far as I can tell, no library in the Windows package exports any symbol at all, let alone the ILP64 ones, so good luck forwarding anything there :roll_eyes:

I can confirm the macOS library has the ILP64 symbols:
% julia-16 --compile=min -e 'using BinaryBuilderBase; BinaryBuilderBase.runshell(Platform("x86_64", "macos"))'
sandbox:${WORKSPACE} # nm MKL.v2022.0.0.x86_64-apple-darwin/lib/libmkl_intel_ilp64.dylib | grep -i 'dpotrf.*_64'
0000000000771060 T _DPOTRF2_64
0000000000717220 T _DPOTRF_64
0000000000770eb0 T _dpotrf2_64
0000000000716f40 T _dpotrf_64

As far as I can tell, no library in the Windows package exports any symbol at all, let alone the ILP64 ones, so good luck forwarding anything there :roll_eyes:

These symbols do not get auto-detected by LBT, even when I modify the LBT source to test the ILP64 suffixes to be checked before the LP64 ones. Perhaps the set_layer api needs to be called correctly to opt into the ILP64 with 64_ suffixes.

Here's my patch:
diff --git a/src/autodetection.c b/src/autodetection.c
index 24d6add..561debd 100644
--- a/src/autodetection.c
+++ b/src/autodetection.c
@@ -15,10 +15,11 @@ const char * autodetect_symbol_suffix(void * handle) {
         "dpotrf_",
     };
     const char * suffixes[] = {
-        // First, LP64-mangling suffixes: No underscore, single underscore, double underscore
+        // ILP64-mangling suffixes
+        "64_", "_64_", "_64__", "__64___",
+        // LP64-mangling suffixes: No underscore, single underscore, double underscore
         "", "_", "__",
-        // Next, ILP64-mangling suffixes: the same, but with the suffix prepended as well:
-        "64_", "_64__", "__64___",
+
     };
     char symbol_name[MAX_SYMBOL_LEN];
     for (int symbol_idx=0; symbol_idx<sizeof(symbol_names)/sizeof(const char *); symbol_idx++) {

On MacOS, this still ends up detecting "" as the suffix.

@staticfloat This is a last step to cleaning up the MKL stuff so that the LP64 and ILP64 stuff can co-exist, but doesn't just work out of the box. Could you take a look when convenient?


[DRAFT - DO NOT MERGE] Add PoP token support to get-token interactive flow

Adds support for getting a Proof-of-Possession (PoP) token when running kubelogin get-token with --login interactive mode.
Adds 2 new flags to kubelogin get-token:

--pop-enabled: boolean flag indicating whether or not to request a PoP token
--pop-claims: string slice formatted as a comma-separated list of key/value pairs, eg. "key1=val1,key2=val2"

Both flags must be provided together in order to use the PoP token flow; providing one but not the other will result in an error during flag validation. PoP claims must contain the u claim containing the ARM ID of the connected cluster (host) to request the PoP token for, in the format "u=<ARM_ID>".
NOTES:

PR currently contains changes to allow PoP token support during devicecode login flow. This is included only for testing and will be removed.
Unit test updates are in progress.

Codecov Report

Merging #319 (247f286) into master (e5dd891) will decrease coverage by 3.73%.
The diff coverage is 12.68%.

@@            Coverage Diff             @@
##           master     #319      +/-   ##
==========================================
- Coverage   60.68%   56.96%   -3.73%
==========================================
  Files          16       16
  Lines        1249     1350     +101
==========================================
+ Hits          758      769      +11
- Misses        445      531      +86
- Partials       46       50       +4

Files Changed
Coverage Δ

pkg/token/interactive.go
0.00% <0.00%> (ø)

pkg/token/devicecode.go
35.61% <15.09%> (-36.26%)
:arrow_down:

pkg/token/options.go
93.91% <25.00%> (-3.94%)
:arrow_down:

pkg/token/provider.go
47.14% <35.00%> (-4.79%)
:arrow_down:

please add UT to pkg/converter/convert.go

For exported functions, i'd recommend adhering to golang coding convention to start comment with function name.


Change severity for code smells

Hi,
We want to change the severity from major to minor for one of the rules. Therefore we have add a new line .severity=MINOR.
We compile the project and put the jar in Sonar-plugins-directory and restart the Sonar-server.
Then we check the source code with Sonar and the changed rule had been violated, but with severity major (instead of minor). When we click on the violated rule to see more information about it, then we see that the severity is minor.
Can you help us how we can change the severity to minor, so we can see this in the first overview.
Best regards,
Lida

So typically to override severity of a rule you do it through the admin interface (i.e. you don't need to recompile anything). Hit up the Quality Profiles, find the rule you want to amend and click into it - hit Change then alter the severity.
So far as I know, the plugin's default severities only get applied the first time SonarQube sees the rule - if a plugin upgrade changes the severity of a rule you've already got activated I'm not sure that it'll update in your profile. I'm kind of surprised it shows as minor when you click through, really. You could try creating a new rules profile and applying it to your project then re-analysing?

OK. Thanks!
I have changed the severity in the Dashboard. Run Sonar again and now the code smells have severity minor .


Console font preferences don't stick first time round.

From<EMAIL_ADDRESS>on 2011-03-11T01:53:26Z
What steps will reproduce the problem?

Change console font size in Preference settings and apply
Observe how font has changed (as expected)
Type any expression in the console What is the expected output? What do you see instead? 4. I expect the Font size to stay to what I set it to. Font reverts back to its startup value. In other words, if you now exit the session and restart spyder, the Preference that you set will take effect. What version of the product are you using? On what operating system? Spyder 2.0.8 on Mac OS X 10.5 (EPD). Also observed on same spyder version under ubuntu linux 10.04

Please provide any additional information below
. This is not a problem for Editor or other plugins.
Original issue: http://code.google.com/p/spyderlib/issues/detail?id=582

From pierre.raybaut on 2011-03-11T13:53:34Z
This issue was closed by revision 703b9d15ad .
Status: Fixed

From pierre.raybaut on 2011-03-11T07:45:07Z
Status: Started

From pierre.raybaut on 2011-04-24T07:38:30Z
This issue was closed by revision 703b9d15ad70 .


Oracle bad performance <IP_ADDRESS>-ee

Hello I have a problem with performance on Oracle 12ee running on docker
I run the container without any limits on memory and CPU. My procedures which invoke several selects (nothing special) and it took 15 minutes  when on the another machine with the same parameters it took 3minutes
The command i run is
docker run -d --restart=unless-stopped --name oracle-ee-12 -v /docker/data/oracle-ee:/ORCL  -p 1515:1521  store/oracle/database-enterprise:<IP_ADDRESS>
So I tried increase memory via env DB_MEMORY but set it to 4GB do not give any improvment
docker run -d --restart=unless-stopped --name oracle-ee-12 -v /docker/data/oracle-ee:/ORCL -e DB_MEMORY=4GB  -p 1515:1521  store/oracle/database-enterprise:<IP_ADDRESS>
I'm using the latest docker version
root@server:/# docker version
Client:
 Version:           18.09.4
 API version:       1.39
 Go version:        go1.10.8
 Git commit:        d14af54
 Built:             Wed Mar 27 18:36:06 2019
 OS/Arch:           linux/amd64
 Experimental:      false

Server: Docker Engine - Community
 Engine:
  Version:          18.09.4
  API version:      1.39 (minimum version 1.12)
  Go version:       go1.10.8
  Git commit:       d14af54
  Built:            Wed Mar 27 18:01:48 2019
  OS/Arch:          linux/amd64
  Experimental:     false

Unfortunately we cannot help much with why Docker appears to be slow on one machine while it runs fast on another. However, hopefully the community is of help here.
Go get things started it probably would be best if you can share more information on steps to reproduce, docker info, OS config and more.

Please provide the output from docker info on both the fast and slow machines, as @gvenzl requested.

Hi
Docker info:
root@xxx:# docker info
Containers: 2
 Running: 2
 Paused: 0
 Stopped: 0
Images: 3
Server Version: 18.09.4
Storage Driver: overlay2
 Backing Filesystem: extfs
 Supports d_type: true
 Native Overlay Diff: true
Logging Driver: json-file
Cgroup Driver: cgroupfs
Plugins:
 Volume: local
 Network: bridge host macvlan null overlay
 Log: awslogs fluentd gcplogs gelf journald json-file local logentries splunk syslog
Swarm: inactive
Runtimes: runc
Default Runtime: runc
Init Binary: docker-init
containerd version: bb71b10fd8f58240ca47fbb579b9d1028eea7c84
runc version: 2b18fe1d885ee5083ef9f0838fee39b62d653e30
init version: fec3683
Security Options:
 seccomp
  Profile: default
Kernel Version: 4.9.0-8-amd64
Operating System: Debian GNU/Linux 9 (stretch)
OSType: linux
Architecture: x86_64
CPUs: 6
Total Memory: 5.733GiB
Name: xxx
ID: xxx
Docker Root Dir: /var/lib/docker
Debug Mode (client): false
Debug Mode (server): false
Username: xxx
Registry: https://index.docker.io/v1/
Labels:
Experimental: false
Insecure Registries:
 xxxx:5000
 xxx.xxx.x.xxx:5000
 <IP_ADDRESS>/8
Registry Mirrors:
 http://xxx.xxx.x.xxx:5000/
 http://xxx:5000/
Live Restore Enabled: false
Product License: Community Engine

WARNING: No swap limit support

on the second machine oracle is installed without docker
this is classic install

Oracle on docker work slow
Oracle with classic install  work normally

I'm hitting the same problem on CentOS Linux release 7.6.1810 (Core).
`docker version
Client:
Version:           18.09.6
API version:       1.39
Go version:        go1.10.8
Git commit:        481bc77156
Built:             Sat May  4 02:34:58 2019
OS/Arch:           linux/amd64
Experimental:      false
Server: Docker Engine - Community
Engine:
Version:          18.09.6
API version:      1.39 (minimum version 1.12)
Go version:       go1.10.8
Git commit:       481bc77
Built:            Sat May  4 02:02:43 2019
OS/Arch:          linux/amd64
Experimental:     false`
docker info Containers: 2  Running: 1  Paused: 0  Stopped: 1 Images: 18 Server Version: 18.09.6 Storage Driver: overlay2  Backing Filesystem: xfs  Supports d_type: true  Native Overlay Diff: true Logging Driver: json-file Cgroup Driver: cgroupfs Plugins:  Volume: local  Network: bridge host macvlan null overlay  Log: awslogs fluentd gcplogs gelf journald json-file local logentries splunk syslog Swarm: inactive Runtimes: runc Default Runtime: runc Init Binary: docker-init containerd version: bb71b10fd8f58240ca47fbb579b9d1028eea7c84 runc version: 2b18fe1d885ee5083ef9f0838fee39b62d653e30 init version: fec3683 Security Options:  seccomp   Profile: default Kernel Version: 3.10.0-957.12.1.el7.x86_64 Operating System: CentOS Linux 7 (Core) OSType: linux Architecture: x86_64 CPUs: 4 Total Memory: 15.51GiB Name: gebit-sparpos-poslive-dev ID: IYXR:6T2C:3EK5:3LDU:POE4:6KZ4:4IAJ:BTJN:IGTO:BGBR:FJLZ:TYDT Docker Root Dir: /var/lib/docker Debug Mode (client): false Debug Mode (server): false Registry: https://index.docker.io/v1/ Labels: Experimental: false Insecure Registries:  <IP_ADDRESS>/8 Live Restore Enabled: false Product License: Community Engine

<IP_ADDRESS> ist not affected.

I've observed that specifically system table access seems remarkably slower in 12.2, 18c and 19c under docker vs 12.1. This command run from SQL*Plus runs almost instantaneously from a 12.1 db in a container, but takes multiple minutes on 12.2, 18c, and 19c
SELECT COUNT(*) FROM ALL_OBJECTS;
Is that what you are seeing?

I have same issue on Oracle 12.2 in docker container on Windows and on MacOs. Seems that recreate scripts on sqlplus in bash are slow, but it depends on machine performance. I think that main problem is that after db recreate inserts are very slow, deletion is fast. I run container with memory setup and without. I didn't face those issues on previous versions of Oracle.

Hi,
Same issue on 12.2 se2.
It looks that following queries are fixing performance issue:
ALTER SYSTEM SET disk_asynch_io = FALSE SCOPE = SPFILE;
ALTER SYSTEM SET FILESYSTEMIO_OPTIONS=DIRECTIO SCOPE=SPFILE;

And restart oracle.

I'm going to close this issue as performance tuning is nominally beyond the scope of this repository.
However, if you are still experiencing Database container-related performance issues, please open a new issue to discuss those.

I decided to flag it with more-info-required just in case this is still an issue. The stalebot will reap it, if not.


Add support for binding to tcp address on Windows

In order to support clients above containerd that might not support
npipe's adding support for tcp endpoints to ctr and containerd is the
easiest option for now.
Signed-off-by: Justin Terry (VM<EMAIL_ADDRESS>

@crosbymichael - This CI failure is unrelated to my changes. Can we restart it?

Could you be more specific on a case where npipe (or UNIX sockets on recent Windows?) cannot be used?
Also, can we make TLS mandatory for TCP endpoint?

Codecov Report

Merging #2604 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2604   +/-   ##
=======================================
  Coverage   44.03%   44.03%
=======================================
  Files          94       94
  Lines       10235    10235
=======================================
  Hits         4507     4507
  Misses       5008     5008
  Partials      720      720

Flag
Coverage Δ

#linux
47.5% <ø> (ø)
:arrow_up:

#windows
40.66% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acced5d...2810ae7. Read the comment docs.

Possibly create a new listener?  GetLocalListener implies local where this can be any TCP address.

@AkihiroSuda - The issue is that all upstream clients of containerd may not support Windows npipe's. But almost all clients support tcp sockets by default. And currently although Unix socket support has been added to recent versions of Windows it is 1: Not included in Golang yet; and 2: we cannot use it as this will be supported on older versions as well without Unix socket support. So even though this is intended to use TCP locally its really just to allow clients other than the containerd client to connect to this daemon. I don't mind TLS but since it was local I didn't think it was necessary to make a requirement.
@ehazlett - My intent was that a user would only use TCP in a local case to support larger set of clients. So tcp://<IP_ADDRESS>:$PORT. I could put a hard block in that its a <IP_ADDRESS> address if you like?

Ok. Will close for now and work on getting npipe support into upstream clients instead. Thanks.


Simple copy and paste between different storage accounts within SE fails

Preflight Checklist

[X] I have installed the latest version of Storage Explorer.
[X] I have checked existing resources, including the troubleshooting guide and the release notes.
[X] I have searched for similar issues.

Storage Explorer Version
1.30.0
Regression From
No response
Architecture
x64
Storage Explorer Build Number
20230713.8
Platform
Windows
OS Version
Windows 10
Bug Description
If a copy and paste is attempted from one storage account to another, and the file exists in the destination storage account, the paste operation fails with an "UnexpectedCancel" error.
Steps to Reproduce

Create entries for file shares residing in two different storage accounts.
Ensure a file with the same name (can be different content) exists in both file shares.
Copy file from one file share (using the SE copy menu item).
Past to the other file share (using the SE paste menu item).
Respond to dialog by clicking "Apply to all conflicts".
Transfer fails.

Actual Experience
See "Steps to Reproduce."
Expected Experience
That the copy/paste operation completes without failure.
Additional Context
I can download the file from storage_account_1 to my local machine, then upload the file to storage_account_2 and no errors are generated.

@bakoontz2 Could you use the "Copy AzCopy Command to Clipboard" action in the activity to get the command, retry executing it with AzCopy cli from the terminal and then let us know what error is printed in the console? You can get AzCopy executables here https://learn.microsoft.com/en-us/azure/storage/common/storage-use-azcopy-v10#download-azcopy

2023/07/20 21:24:27 AzcopyVersion  10.19.0
2023/07/20 21:24:27 OS-Environment  windows
2023/07/20 21:24:27 OS-Architecture  amd64
2023/07/20 21:24:27 Log times are in UTC. Local time is 20 Jul 2023 16:24:27
2023/07/20 21:24:27 ISO 8601 START TIME: to copy files that changed before or after this job started, use the parameter --include-before=2023-07-20T21:24:22Z or --include-after=2023-07-20T21:24:22Z
2023/07/20 21:24:28 WARN: Failed to check if the destination is a folder or a file (Azure Files). Assuming the destination is a file: -> github.com/Azure/azure-storage-file-go/azfile.newStorageError, C:/Users/VssAdministrator/go/pkg/mod/github.com/!azure/azure-storage-file-go@v1.6.1-0.20201111053559-3c1754dc00a5/azfile/zc_storage_error.go:42

===== RESPONSE ERROR (ServiceCode=ResourceNotFound) =====

Description=The specified resource does not exist.

RequestId:aaa6dcff-001a-005c-2950-bbb1dc000000

Time:2023-07-20T21:24:28.3336722Z, Details:

   Code: ResourceNotFound

   GET https://corp.file.core.windows.net/cor-p/nfs/npportal_ncprd/apps/sched/bin/test.sh?restype=directory&se=2023-07-27t18%3A15%3A53z&sig=-REDACTED-&sp=rl&sr=s&st=2023-07-20t18%3A15%3A53z&sv=2022-11-02&timeout=901

   User-Agent: [AzCopy/10.19.0 Azure-Storage/0.8.0 (go1.19.8; Windows_NT)]

   X-Ms-Allow-Trailing-Dot: [true]

   X-Ms-Client-Request-Id: [c3a7a7f0-63a8-4a40-4cd7-c3a7f2dd3eef]

   X-Ms-Source-Allow-Trailing-Dot: [true]

   X-Ms-Version: [2022-11-02]

   --------------------------------------------------------------------------------

   RESPONSE Status: 404 The specified resource does not exist.

   Content-Length: [223]

   Content-Type: [application/xml]

   Date: [Thu, 20 Jul 2023 21:24:27 GMT]

   Server: [Windows-Azure-File/1.0 Microsoft-HTTPAPI/2.0]

   X-Ms-Client-Request-Id: [c3a7a7f0-63a8-4a40-4cd7-c3a7f2dd3eef]

   X-Ms-Error-Code: [ResourceNotFound]

   X-Ms-Request-Id: [aaa6dcff-001a-005c-2950-bbb1dc000000]

   X-Ms-Version: [2022-11-02]

2023/07/20 21:24:28 WARN: Failed to check if the destination is a folder or a file (Azure Files). Assuming the destination is a file: -> github.com/Azure/azure-storage-file-go/azfile.newStorageError, C:/Users/VssAdministrator/go/pkg/mod/github.com/!azure/azure-storage-file-go@v0.6.1-0.20201111053559-3c1754dc00a5/azfile/zc_storage_error.go:42

===== RESPONSE ERROR (ServiceCode=ResourceNotFound) =====

Description=The specified resource does not exist.

RequestId:3a44f006-d01a-002c-0750-bb3e00000000

Time:2023-07-20T21:24:28.7487416Z, Details:

   Code: ResourceNotFound

   GET https://cors.file.core.windows.net/cor-s/nfs/npportal_ncstg/apps/sched/bin/test.sh?restype=directory&se=2023-08-19t18%3A31%3A17z&sig=-REDACTED-&sp=rwl&sr=s&sv=2022-11-02&timeout=901

   User-Agent: [AzCopy/10.19.0 Azure-Storage/0.8.0 (go1.19.8; Windows_NT)]

   X-Ms-Allow-Trailing-Dot: [true]

   X-Ms-Client-Request-Id: [359537bf-4c39-4a51-7e74-15b78510efdf]

   X-Ms-Source-Allow-Trailing-Dot: [true]

   X-Ms-Version: [2022-11-02]

   --------------------------------------------------------------------------------

   RESPONSE Status: 404 The specified resource does not exist.

   Content-Length: [223]

   Content-Type: [application/xml]

   Date: [Thu, 20 Jul 2023 21:24:28 GMT]

   Server: [Windows-Azure-File/1.0 Microsoft-HTTPAPI/2.0]

   X-Ms-Client-Request-Id: [359537bf-4c39-4a51-7e74-15b78510efdf]

   X-Ms-Error-Code: [ResourceNotFound]

   X-Ms-Request-Id: [3a44f006-d01a-002c-0750-bb3e00000000]

   X-Ms-Version: [2022-11-02]

2023/07/20 21:24:28 WARN: Failed to create destination container cor-s. The transfer will continue if the container exists
2023/07/20 21:24:28 Any empty folders will be processed, because source and destination both support folders. For the same reason, properties defined on folders will be processed
2023/07/20 21:24:28 Job-Command copy https://corp.file.core.windows.net/cor-p/nfs/npportal_ncprd/apps/sched/bin/test.sh?se=2023-07-27t18%3A15%3A53z&sig=-REDACTED-&sp=rl&sr=s&st=2023-07-20t18%3A15%3A53z&sv=2022-11-02 https://cors.file.core.windows.net/cor-s/nfs/npportal_ncstg/apps/sched/bin/test.sh?se=2023-08-19t18%3A31%3A17z&sig=-REDACTED-&sp=rwl&sr=s&sv=2022-11-02 --overwrite=prompt --from-to=FileFile --preserve-smb-info=true --recursive --log-level=INFO --trailing-dot=Enable
2023/07/20 21:24:28 Number of CPUs: 16
2023/07/20 21:24:28 Max file buffer RAM 8.000 GB
2023/07/20 21:24:28 Max concurrent network operations:  will be dynamically tuned up to 3000 (Based on auto-tuning limit. Set AZCOPY_CONCURRENCY_VALUE environment variable to override)
2023/07/20 21:24:28 Check CPU usage when dynamically tuning concurrency: true (Based on hard-coded default. Set AZCOPY_TUNE_TO_CPU environment variable to true or false override)
2023/07/20 21:24:28 Max concurrent transfer initiation routines: 64 (Based on hard-coded default. Set AZCOPY_CONCURRENT_FILES environment variable to override)
2023/07/20 21:24:28 Max enumeration routines: 16 (Based on hard-coded default. Set AZCOPY_CONCURRENT_SCAN environment variable to override)
2023/07/20 21:24:28 Parallelize getting file properties (file.Stat): false (Based on AZCOPY_PARALLEL_STAT_FILES environment variable)
2023/07/20 21:24:28 Max open files when downloading:<PHONE_NUMBER> (auto-computed)
2023/07/20 21:24:28 Final job part has been created
2023/07/20 21:24:28 Trying 4 concurrent connections (initial starting point)
2023/07/20 21:24:28 Final job part has been scheduled
2023/07/20 21:24:29 WARN: [P#0-T#0] Block size 8388608 larger than maximum file chunk size, 4 MB chunk size used
2023/07/20 21:24:29 ==> REQUEST/RESPONSE (Try=1/83.0856ms, OpTime=284.4859ms) -- RESPONSE SUCCESSFULLY RECEIVED

   HEAD https://corp.file.core.windows.net/cor-p/nfs/npportal_ncprd/apps/sched/bin/test.sh?se=2023-07-27T18%3A15%3A53Z&sig=-REDACTED-&sp=rl&sr=s&st=2023-07-20T18%3A15%3A53Z&sv=2022-11-02&timeout=901

   X-Ms-Request-Id: [03a65db7-d01a-0012-5750-bb9f54000000]

2023/07/20 21:24:29 INFO: [P#0-T#0] Starting transfer: Source "https://corp.file.core.windows.net/cor-p/nfs/npportal_ncprd/apps/sched/bin/test.sh?se=2023-07-27T18%3A15%3A53Z&sig=-REDACTED-&sp=rl&sr=s&st=2023-07-20T18%3A15%3A53Z&sv=2022-11-02" Destination "https://cors.file.core.windows.net/cor-s/nfs/npportal_ncstg/apps/sched/bin/test.sh?se=2023-08-19T18%3A31%3A17Z&sig=-REDACTED-&sp=rwl&sr=s&sv=2022-11-02". Specified chunk size 4194304
2023/07/20 21:24:29 ==> REQUEST/RESPONSE (Try=1/79.4754ms, OpTime=276.0767ms) -- RESPONSE SUCCESSFULLY RECEIVED

   HEAD https://cors.file.core.windows.net/cor-s/nfs/npportal_ncstg/apps/sched/bin/test.sh?se=2023-08-19T18%3A31%3A17Z&sig=-REDACTED-&sp=rwl&sr=s&sv=2022-11-02&timeout=901

   X-Ms-Request-Id: [808441aa-601a-005b-5b50-bbeb94000000]

2023/07/20 21:24:30 PERF: primary performance constraint is Unknown. States: W:  0, F:  0, S:  0, E:  0, T:  0, GRs:  4
2023/07/20 21:24:30 0.0 %, 0 Done, 0 Failed, 1 Pending, 0 Skipped, 1 Total,
2023/07/20 21:24:31 JobID=3858bf64-258c-4844-4d16-fec1405982e2 canceled
2023/07/20 21:24:31 all parts of entire Job 3858bf64-258c-4844-4d16-fec1405982e2 successfully completed, cancelled or paused
2023/07/20 21:24:31 all parts of entire Job 3858bf64-258c-4844-4d16-fec1405982e2 successfully cancelled
2023/07/20 21:24:31 is part of Job which 1 total number of parts done
2023/07/20 21:24:31 WARN: [P#0-T#0] https://corp.file.core.windows.net/cor-p/nfs/npportal_ncprd/apps/sched/bin/test.sh?se=2023-07-27T18%3A15%3A53Z&sig=-REDACTED-&sp=rl&sr=s&st=2023-07-20T18%3A15%3A53Z&sv=2022-11-02 File already exists, so will be skipped Dst: https://cors.file.core.windows.net/cor-s/nfs/npportal_ncstg/apps/sched/bin/test.sh?se=2023-08-19T18%3A31%3A17Z&sig=-REDACTED-&sp=rwl&sr=s&sv=2022-11-02

The errors in that log don't appear to reflect reality, because I can download and then upload the same artifact without any issues.

@bakoontz2 Could you try doing it from the command line instead? When we show "UnexpectedCancel", chances are that AzCopy exe crashed for some reason. The crash info is only printed in the console and won't be written to log file.

All of the runs above were from the command line.  Sanitizing the console output is a chore though, so I pulled from the .azure logs.  Here is a console log for the FileFile run (the first run, the one that's failing):
$ ./azcopy.exe copy "https://corp.file.core.windows.net/cor-p/nfs/npportal_ncprd/apps/sched/bin/test.sh?sv=2022-11-02&st=2023-07-20T18%3A15%3A53Z&se=2023-07-27T18%3A15%3
A53Z&sr=s&sp=rl&sig=-REDACTED-" "https://cors.file.core.windows.net/cor-s-zeaus-npp-app-stagebeta/nfs/npportal_ncstg/apps/sched/bin/test.sh?sv=2022-11-0
2&se=2023-08-19T18%3A31%3A17Z&sr=s&sp=rwl&sig=-REDACTED-" --overwrite=prompt --from-to=FileFile --preserve-smb-info=true --recursive --log-level=INFO --trailing-dot=Enabl
e;
INFO: Please note: the preserve-permissions flag is set to false, thus AzCopy will not copy SMB ACLs between the source and destination. To learn more: https://aka.ms/AzCopyandAzureFiles.
INFO: Scanning...
INFO: Proxy detected: https://azcopyvnextrelease.blob.core.windows.net -> //REDACTED
INFO: Failed to create one or more destination container(s). Your transfers may still succeed if the container already exists.
INFO: Any empty folders will be processed, because source and destination both support folders. For the same reason, properties defined on folders will be processed

Job 1db2c98d-12fa-ad41-7295-5b85ce19599e has started
Log file is located at: C:\Users\REDACTED\.azcopy\1db2c98d-12fa-ad41-7295-5b85ce19599e.log

INFO: Trying 4 concurrent connections (initial starting point)
https://cors.file.core.windows.net/cor-s-zeaus-npp-app-stagebeta/nfs/npportal_ncstg/apps/sched/bin/test.sh already exists at the destination. Do you wish to overwrite? Please confirm with:
[Y] Yes  [N] No  [A] Yes for all  [L] No for all y
INFO: Confirmed. https://cors.file.core.windows.net/cor-s-zeaus-npp-app-stagebeta/nfs/npportal_ncstg/apps/sched/bin/test.sh will be overwritten.
INFO: Authentication failed, it is either not correct, or expired, or does not have the correct permission -> github.com/Azure/azure-storage-file-go/azfile.newStorageError, C:/Users/VssAdministrator/go/pkg/mod
/github.com/!azure/azure-storage-file-go@v0.6.1-0.20201111053559-3c1754dc00a5/azfile/zc_storage_error.go:42
===== RESPONSE ERROR (ServiceCode=CannotVerifyCopySource) =====
Description=This request is not authorized to perform this operation.
RequestId:42170348-301a-0079-3ae0-bb2e8b000000
Time:2023-07-21T14:37:29.7922337Z, Details:
   Code: CannotVerifyCopySource
   PUT https://cors.file.core.windows.net/cor-s-zeaus-npp-app-stagebeta/nfs/npportal_ncstg/apps/sched/bin/test.sh?comp=range&se=2023-08-19t18%3A31%3A17z&sig=-REDACTED-&sp=rwl&sr=s&sv=2022-1
1-02&timeout=901
   Content-Length: [0]
   User-Agent: [AzCopy/10.19.0 Azure-Storage/0.8.0 (go1.19.8; Windows_NT)]
   X-Ms-Allow-Trailing-Dot: [true]
   X-Ms-Client-Request-Id: [0bd2f40f-cdde-4fd4-6f68-7b1c67d94a3f]
   X-Ms-Copy-Source: [https://corp.file.core.windows.net/cor-p/nfs/npportal_ncprd/apps/sched/bin/test.sh?se=2023-07-27t18%3A15%3A53z&sig=-REDACTED-&sp=rl&sr=s&st=2023-07-
20t18%3A15%3A53z&sv=2022-11-02]
   X-Ms-Range: [bytes=0-247]
   X-Ms-Source-Allow-Trailing-Dot: [true]
   X-Ms-Source-Range: [bytes=0-247]
   X-Ms-Version: [2022-11-02]
   X-Ms-Write: [update]
   --------------------------------------------------------------------------------
   RESPONSE Status: 403 This request is not authorized to perform this operation.
   Content-Length: [248]
   Content-Type: [application/xml]
   Date: [Fri, 21 Jul 2023 14:37:29 GMT]
   Server: [Windows-Azure-File/1.0 Microsoft-HTTPAPI/2.0]
   X-Ms-Client-Request-Id: [0bd2f40f-cdde-4fd4-6f68-7b1c67d94a3f]
   X-Ms-Error-Code: [CannotVerifyCopySource]
   X-Ms-Request-Id: [42170348-301a-0079-3ae0-bb2e8b000000]
   X-Ms-Version: [2022-11-02]

0.0 %, 0 Done, 0 Failed, 1 Pending, 0 Skipped, 1 Total, 2-sec Throughput (Mb/s): 0.001

Job 1db2c98d-12fa-ad41-7295-5b85ce19599e summary
Elapsed Time (Minutes): 0.0669
Number of File Transfers: 1
Number of Folder Property Transfers: 0
Number of Symlink Transfers: 0
Total Number of Transfers: 1
Number of File Transfers Completed: 0
Number of Folder Transfers Completed: 0
Number of File Transfers Failed: 0
Number of Folder Transfers Failed: 0
Number of File Transfers Skipped: 0
Number of Folder Transfers Skipped: 0
TotalBytesTransferred: 0
Final Job Status: Cancelled

I brought your issue to AzCopy team but they haven't responded yet. Since you can reproduce this issue from the command line as well, you can create an issue in their repository to bring more attention to your issue. https://github.com/Azure/azure-storage-azcopy/issues

@bakoontz2 Did the response from AzCopy explain why your copy failed?

Hi @bakoontz2, if you have firewall on source, this copy would not work. In that case, enable private endpoint for souce and destination in the same vnet.

I've asked for clarification, however, since I also pointed out that doing two azcopys (one to download, one to upload) works fine, so it's unclear to me how a firewall issue would be the problem.

I have left a comment on the AzCopy issue explaining.

@JasonYeMSFT Thanks for the assist, I am now convinced that both source and destination SAs need to have private endpoints on the same vnet.


i dont have a pcap.h file

Hello
I don't have a pcap.h file and other .h files.where can i download it from?

It is contained in libpcap (or WinPCAP).
Please refer to other documents to build development environments.


Real fullscreen

Hi,
now we have "tabris.ui.set("toolbarVisible", false);" which hides toolbar but I can still see time and battery indicator. But I'm looking for the way to show some image in real fullscreen mode - w/o any other information.
Thank you

Currently we don't support that yet. We are aware of its usefulness and have it on our feature list for an upcoming release.

Related: #171

In Android, there are two different fullscreen modes called Lean Back and Immersive, that differ in the gestures used to exit fullscreen mode.
All systems also seem to support translucent system bars.
I'd prefer an enum property like displayMode to a boolean one, because that would allow us to add additional variants in the future. In the first version, valid properties could be "fullscreen" and "normal".
The obvious object to hold the new property seems to be tabris.ui.

Implemented on Android and iOS. You can now use tabris.ui.set("displayMode", "fullscreen"); to hide the system bar.


CacheBeta task: Frequent cache misses right after cache hit

Required Information
Entering this information will route you directly to the right team and expedite traction.
Question, Bug, or Feature?
Type: Bug
Enter Task Name: CacheBeta
Environment

Server - Azure Pipelines or TFS on-premises?

If using Azure Pipelines, provide the account name, team project name, build definition name/build number: account: SaxoBank project: SaxoTrader build definition: SaxoTrader-Cypress-CI

Agent - Hosted or Private:

If using Hosted agent, provide agent queue name:

If using private agent, provide the OS of the machine running the agent and the agent version: Windows_NT, 2.155.1

Issue Description
We get one build that gets a cache hit.
Very soon after we get another build that gets a cache fail.
The docs state that caches last 7 days and have no limits.
The problem is that it affects our strategy - if its occasional its fine, but if it happens all the time, it makes certain optimisations not worth it, e.g. https://github.com/microsoft/azure-pipelines-tasks/issues/10925#issuecomment-529918183
Task logs
First build, succeeds:
2019-09-10T11:49:35.2758486Z ##[section]Starting: Cache Npm packages
2019-09-10T11:49:35.2858508Z ==============================================================================
2019-09-10T11:49:35.2858557Z Task         : Cache (Beta)
2019-09-10T11:49:35.2858609Z Description  : Cache files between runs
2019-09-10T11:49:35.2858639Z Version      : 0.1.0
2019-09-10T11:49:35.2858670Z Author       : Microsoft Corporation
2019-09-10T11:49:35.2858719Z Help         : https://aka.ms/pipeline-caching-docs
2019-09-10T11:49:35.2858750Z ==============================================================================
2019-09-10T11:49:35.6892542Z Resolving key `npm | v8 | Windows_NT | d:\work\1\s/package-lock.json | $(CYPRESS_INSTALL_BINARY)`...
2019-09-10T11:49:35.7806896Z File hashes summarized as `8xH0A5ByRH6bICVoFakpoA5ZWSFOvC113l9Xn541SO0=` from BASE64(SHA256(`
2019-09-10T11:49:35.7807142Z SHA256(s\package-lock.json)=[944040]D2740A810231E68EB4FA7EC289F51F8FE157551BABB4F1963F3576C460990F32`))
2019-09-10T11:49:35.7831314Z Resolved to `npm|v8|Windows_NT|8xH0A5ByRH6bICVoFakpoA5ZWSFOvC113l9Xn541SO0=|$(CYPRESS_INSTALL_BINARY)`.
2019-09-10T11:49:36.7809148Z Information, Getting a pipeline cache artifact with one of the following fingerprints:
2019-09-10T11:49:36.7809884Z Information, Fingerprint: `npm|v8|Windows_NT|8xH0A5ByRH6bICVoFakpoA5ZWSFOvC113l9Xn541SO0=|$(CYPRESS_INSTALL_BINARY)`
2019-09-10T11:49:36.9459174Z Information, There is a cache hit: `npm|v8|Windows_NT|8xH0A5ByRH6bICVoFakpoA5ZWSFOvC113l9Xn541SO0=|$(CYPRESS_INSTALL_BINARY)`
2019-09-10T11:49:36.9459404Z Information, Used scope: 22;2a4e21b6-7b9c-47c3-9a4f-0430e7a2fec9;refs/heads/master;8857af23-3c62-4fae-940e-e908b1672e54
2019-09-10T11:49:37.0290068Z Entry found at fingerprint: `npm|v8|Windows_NT|8xH0A5ByRH6bICVoFakpoA5ZWSFOvC113l9Xn541SO0=|$(CYPRESS_INSTALL_BINARY)`
2019-09-10T11:49:37.0296435Z Information, DedupManifestArtifactClient will correlate http requests with X-TFS-Session 7284c027-dd48-4fb0-be14-59b8880c7f81
2019-09-10T11:49:37.1576365Z Information, ArtifactHttpRetryMessageHandler.SendAsync: https://vsblobprodsu6weu.vsblob.visualstudio.com/Ad2f735ff-1e43-4ce8-826b-9e3578951332/_apis/dedup/chunks/8894CD299E6CA1C9EDC5BE944DB1EEF45C21EDD72DF67831483D53CD4EB4113201 attempt 1/6 failed with StatusCode RedirectMethod, IsRetryableResponse False
2019-09-10T11:49:37.3747393Z Information, Could not initialize dataport.
2019-09-10T11:49:37.3804364Z Information, Downloaded 0.0 MB out of 144.0 MB (0%).
2019-09-10T11:49:43.0132685Z Information, Downloaded 111.8 MB out of 144.0 MB (78%).
2019-09-10T11:49:46.3579185Z Information, Downloaded 144.0 MB out of 144.0 MB (100%).
2019-09-10T11:49:46.3593261Z Information,
2019-09-10T11:49:46.3593523Z Download statistics:
2019-09-10T11:49:46.3594307Z Total Content: 144.0 MB
2019-09-10T11:49:46.3594519Z Physical Content Downloaded: 144.0 MB
2019-09-10T11:49:46.3595295Z Compression Saved: 0.0 MB
2019-09-10T11:49:46.3595447Z Local Caching Saved: 0.0 MB
2019-09-10T11:49:46.3595947Z Chunks Downloaded: 1,826
2019-09-10T11:49:46.3596097Z Nodes Downloaded: 3
2019-09-10T11:49:46.3596619Z
2019-09-10T11:49:46.3623793Z Information, Download completed.
2019-09-10T11:49:46.4580003Z Cache restored.
2019-09-10T11:49:46.4667611Z ##[section]Finishing: Cache Npm packages

Second build fails:
2019-09-10T12:25:04.0077833Z ##[section]Starting: Cache Npm packages
2019-09-10T12:25:04.0173327Z ==============================================================================
2019-09-10T12:25:04.0173375Z Task         : Cache (Beta)
2019-09-10T12:25:04.0173423Z Description  : Cache files between runs
2019-09-10T12:25:04.0173455Z Version      : 0.1.0
2019-09-10T12:25:04.0173486Z Author       : Microsoft Corporation
2019-09-10T12:25:04.0173537Z Help         : https://aka.ms/pipeline-caching-docs
2019-09-10T12:25:04.0173568Z ==============================================================================
2019-09-10T12:25:04.4199659Z Resolving key `npm | v8 | Windows_NT | d:\work\1\s/package-lock.json | $(CYPRESS_INSTALL_BINARY)`...
2019-09-10T12:25:04.4948577Z File hashes summarized as `8xH0A5ByRH6bICVoFakpoA5ZWSFOvC113l9Xn541SO0=` from BASE64(SHA256(`
2019-09-10T12:25:04.4948838Z SHA256(s\package-lock.json)=[944040]D2740A810231E68EB4FA7EC289F51F8FE157551BABB4F1963F3576C460990F32`))
2019-09-10T12:25:04.4973180Z Resolved to `npm|v8|Windows_NT|8xH0A5ByRH6bICVoFakpoA5ZWSFOvC113l9Xn541SO0=|$(CYPRESS_INSTALL_BINARY)`.
2019-09-10T12:25:04.9343162Z Information, Getting a pipeline cache artifact with one of the following fingerprints:
2019-09-10T12:25:04.9343837Z Information, Fingerprint: `npm|v8|Windows_NT|8xH0A5ByRH6bICVoFakpoA5ZWSFOvC113l9Xn541SO0=|$(CYPRESS_INSTALL_BINARY)`
2019-09-10T12:25:05.2682653Z Information, There is a cache miss.
2019-09-10T12:25:05.3323094Z ##[section]Finishing: Cache Npm packages

key1: npm|v8|Windows_NT|8xH0A5ByRH6bICVoFakpoA5ZWSFOvC113l9Xn541SO0=|$(CYPRESS_INSTALL_BINARY)
key2: npm|v8|Windows_NT|8xH0A5ByRH6bICVoFakpoA5ZWSFOvC113l9Xn541SO0=|$(CYPRESS_INSTALL_BINARY)

I think my colleague worked it out - these are builds on 2 different branches.
💥 That is totally absolutely crazy!!!!
the product name is "azure devops" - devops usually encorporates CI, which without trunk based development means lots of short lived feature branches.
and every single one of them has its own cache.
What could possibly be the reason for this? it can't be to protect against pipeline changes because this would give a false sense of security as you'd get a new cache on your branch but an existing cache once merged. Is it security because you can set permissions on different branches?
Is there a plan to change this?

I added a feature request to be able to configure how branch name affects cache keying, over at  dev comminity (whatever the right place is), see here

It'd be nice to see the entire key (both explicit as configured in yaml) and implicit (whatever the task adds on it's own) so that one can see why there are cache misses. It reduces confusion.
The cache task is a great feature btw, just needs some polish around the corners to get out of beta.

It'd be nice to see the entire key (both explicit as configured in yaml) and implicit (whatever the task adds on it's own) so that one can see why there are cache misses. It reduces confusion.
@owenhuyn  / @fadnavistanmay - I thought we had updated to include this. Has it just not rolled out yet?

every single one of them has its own cache
@lukeapage / @marcussonestedtbarium - Thanks for your feedback here - you are right that the concern is security.  There are flows that are particularly concerning (like a CI on a PR from a fork being able to affect the CI cache) and there are flows that are much less (two feature branches from contributors should be able to share a cache).  We are starting with an (overly?) safe default, but have talked about a "namespace" override as you mention.

I should say that though there is a cache per branch. PRs builds can read the cache of multiple branches.

For example, PR builds are able to read from both the source and target branch caches (and previous iterations of the PR).

For longer-lived feature branches, you may want to set up a CI on that branch so that the cache for that branch is populated and PRs into that feature branch can leverage that branch.
https://docs.microsoft.com/en-us/azure/devops/pipelines/caching/?view=azure-devops#cache-isolation-and-security

Let us know which scenarios/flows don't work well - thanks!

It'd be nice to see the entire key (both explicit as configured in yaml) and implicit (whatever the task adds on it's own) so that one can see why there are cache misses. It reduces confusion.

@owenhuyn / @fadnavistanmay - I thought we had updated to include this. Has it just not rolled out yet?
Yup. It looks like this has not been rolled out yet.

@lukeapage / @marcussonestedtbarium - Thanks for your feedback here - you are right that the concern is security. There are flows that are particularly concerning (like a CI on a PR from a fork being able to affect the CI cache) and there are flows that are much less (two feature branches from contributors should be able to share a cache). We are starting with an (overly?) safe default, but have talked about a "namespace" override as you mention.
I should say that though there is a cache per branch. PRs builds can read the cache of multiple branches.

I sort-of get the security standpoint with public repos and PRs, although if they are set up so that a cache data set is immutable, we could avoid the issue. (i.e. depend on packages.lock/,csproj/etc).
If that's not solvable, having the option, or the default, to make caches readable from in-repo-branches but copy-on-write for PR's seems like a good compromise from a security standpoint, methinks.
In our case, we have a private repo so security is not a big concern. Our cache key has correct dependencies so it is rebuilt anyway. Build times are more an issue though since more agents cost money on private repos, and we're sometimes on that bottleneck, esp on Windows build which are slower (nuget/npm/cypress especially).

I sort-of get the security standpoint with public repos and PRs, although if they are set up so that a cache data set is immutable, we could avoid the issue. (i.e. depend on packages.lock/,csproj/etc).

The cache is immutable, the problem is that the task is defined in YAML which can be edited as part of a rogue PR.  That is, my rogue PR would not only have malware in it, it would change the build YAML to have the cache task use a cache key that the next CI build would use.

If that's not solvable, having the option, or the default, to make caches readable from in-repo-branches but copy-on-write for PR's seems like a good compromise from a security standpoint, methinks.

Interesting - would being able to opt-in to read from specific branches be equivalent?

Being able to configure master to write and branches to read from master would solve it for me. Alternatively a security option on the repo since we only have private repos.
Our issue is that the builds are not Pr builds but we have many short live branches.

The cache is immutable, the problem is that the task is defined in YAML which can be edited as part of a rogue PR. That is, my rogue PR would not only have malware in it, it would change the build YAML to have the cache task use a cache key that the next CI build would use.

Well, a rouge PR could do a lot if it is allowed to builds & run. Regardless, IIUC, it could not overwrite a cache that some other branches use. If it creates a new cache key, no other build would use that. (Unless it adds package X + malware, tags it as X, and then another CI also adds X, then it'd get the malware. Ok. But external PR builds should maybe have different security policy w.r.t. cache altogether?)
Anyway, like @lukeapage , we have mainly short-lived feature branches. Opt-in to read from some branches (dev & master for us) would work.

Thanks @lukeapage  and @marcussonestedtbarium  for your feedback and following-up on my questions. I've tried to coalesce the feedback into a new issue: https://github.com/microsoft/azure-pipelines-tasks/issues/11374.

Deploying via #11374


Pmkees ffsv11.27

Upate for FFSv11.27 - update curl version dependency

Sorry - didn't mean to apply this to your project


Allow the registration of separate URLs to receive the EndpointDataReference

Feature Request
We have the use-case to have multiple client applications on consumer side which will fetch data through the EDC via the HttpProxy method. These are separate application with different use-case based on different data etc. Therefor, they mostly don't know anything about each other.
As far as I know (please correct me if I'm wrong!) we just have the possibility to configure only one specific URL on the EDC (config property edc.receiver.http.endpoint) where the information about the DataPlane access (EndpointDataReference) will be sent to. This is fine if we have just one client application which is using the EDC.
With having multiple client applications which are independent, we would need the possibility to somehow define the URL where the EndpointDataReference (EDR) object will be sent to.
For example:

Application A wants to get the access to the data, send the EDR object to: https://app-a:8080/callback
Application B wants to get the access to the data, send the EDR object to: https://app-b:8080/callback
...

Which Areas Would Be Affected?
DPF
Why Is the Feature Desired?
Already described above
Solution Proposal
One idea could be, that every time a TransferProcess will be created by the client, we configure in the TransferProcessDto object the URL where the EDC should send the EDR to.
But I'm not so deep into this topic, maybe there are better ways to make this dynamically configurable by the client application.

This sounds like a fanout scenario. Can you detail the concrete scenario and use case behind this? Thx.

@jimmarino I tried to improve it. Can you have a look at it again? :-)
\cc @ndr-brt

OK, thanks, this is not a fan-out but support for dynamic callback addresses. When initiating a request, the client can specify an optional callback address.
I'm going to ask @wolf4ood to take a look.

Maybe we should rename this to, "Add support for dynamic HTTP Receiver callback endpoints? Registration sounds as if it is done upfront where what we want is request-time behavior.

Hi @florianrusch-zf
I' m working on this PR which basically creates a new module for handling dynamic http receiver based on custom properties on TransferProcessDTO.
It's still on draft cause it needs some docs, in case if you have feedback you can check it out
Thanks


Fix Executable base path

/cc @RobertHenry6bev

Explanation please!

@BrennanConroy, sorry ;)
There is a bug that when you pass executable: foo.exe it will look for published\foo.exe because it was adding \published in all cases. Now it's not adding it if executable:  is set.
The other part is to force a project to exclude a published folder from the publication because otherwise it would recursively copy this folder after each build is the repository is cached on the agent. This is a mitigation for another bug (noBuild: true, detailed in an open issue) until I find why it not working anymore (we know which commit broke the feature).

I rebase to upstream, and am still getting failures
  pmu_getter:
    executable: pmu_support/pmu_getter.sh
    readyStateText: STARTED
    isConsoleApp: true

11:06:39 INF] Skipping build step, no required
[11:06:39 INF] [/mnt/robhenry/crank_0/dotnet_bench/crank/src/Microsoft.Crank.Agent] chmod +x /mnt/robhenry/crank_0/robhenry_crank_0/benchmarks-server-380025/24jo1wej.isl/pmu_support/pmu_getter.sh
[11:06:39 INF] [STDERR] chmod: cannot access '/mnt/robhenry/crank_0/robhenry_crank_0/benchmarks-server-380025/24jo1wej.isl/pmu_support/pmu_getter.sh': No such file or directory
[11:06:40 INF] An unexpected error occurred while building the job. System.AggregateException: One or more errors occurred. (Command chmod +x /mnt/robhenry/crank_0/robhenry_crank_0/benchmarks-server-380025/24jo1wej.isl/pmu_support/pmu_getter.sh returned exit code 1)
 ---> System.InvalidOperationException: Command chmod +x /mnt/robhenry/crank_0/robhenry_crank_0/benchmarks-server-380025/24jo1wej.isl/pmu_support/pmu_getter.sh returned exit code 1
   at Microsoft.Crank.Agent.ProcessUtil.RunAsync(String filename, String arguments, Nullable`1 timeout, String workingDirectory, Boolean throwOnError, IDictionary`2 environmentVariables, Action`1 outputDataReceived, Boolean log, Action`1 onStart, Action`1 onStop, Boolean captureOutput, Boolean captureError, CancellationToken cancellationToken) in /mnt/robhenry/crank_0/dotnet_bench/crank/src/Microsoft.Crank.Agent/ProcessUtil.cs:line 166
   at Microsoft.Crank.Agent.ProcessUtil.RunAsync(String filename, String arguments, Nullable`1 timeout, String workingDirectory, Boolean throwOnError, IDictionary`2 environmentVariables, Action`1 outputDataReceived, Boolean log, Action`1 onStart, Action`1 onStop, Boolean captureOutput, Boolean captureError, CancellationToken cancellationToken) in /mnt/robhenry/crank_0/dotnet_bench/crank/src/Microsoft.Crank.Agent/ProcessUtil.cs:line 168
   at Microsoft.Crank.Agent.Startup.StartProcess(String hostname, String benchmarksRepo, Job job, String dotnetHome, JobContext context) in /mnt/robhenry/crank_0/dotnet_bench/crank/src/Microsoft.Crank.Agent/Startup.cs:line 4563
   at Microsoft.Crank.Agent.Startup.<>c__DisplayClass81_4.<<ProcessJobs>b__22>d.MoveNext() in /mnt/robhenry/crank_0/dotnet_bench/crank/src/Microsoft.Crank.Agent/Startup.cs:line 909
   --- End of inner exception stack trace ---
[11:06:40 INF] Starting -> Failed (pmu_getter:10)


Added 'delay' prop.

Animation will now delay a number of seconds before replaying.
This is done by adding a 3rd element to the keyframes' animation, causing it to be at its finishing state early, depending on the ratio between delay and duration, then extending the animation to the total of both.  Works with zero, and when either delay or duration is larger.
For example, if you have a duration of 3, and a delay of 1, it will create a keyframe at 75% that is the same as 100%, and the delay is added to the duration, making the total duration 4.  thus the animation 'finishes' early at 3 seconds, but loops at 4 seconds, after the delay.

Couldn't resolve the conflicts, so I manually copied the changes over. This will be released in v2.2.0.


Errors on Pf1e

What happened?
I am not a dev, and have almost no knowledge for coding stuff. I am also not sure if this would be categorize under bug, but I thank you for your time regardless!
I am getting several errors for all player characters. It seems to be something with Polyglot. This is on Pathfinder 1e v10.7 and Foundry 11.315, with no other modules other than Polyglot. I haven't had the chance to test the module more deeply to check if it is working even though it warns errors.

Reproduction Steps

Create an updated pf1e world (currently Pathfinder 1e v10.7, which relies on Foundry 11.315).
Active Polyglot module in Manage Modules.
Create an actor (can be generic, does not need to name or anything).
Create a scene (can also be generic)
Press f12 to see DevTools.
Drag the actor to the scene canvas.
Click/select the actor.

It apparently happens each time the actor is selected. If you f5 and click on the actor, it should list errors again.
Which game system, and which version, are you using?
Pathfinder 1e v10.7
Which Polyglot version are you using?
2.4.14

Which Polyglot version are you using?
2.4.14

Is this correct? 2.4.14 is V12-only but PF1 is still on V11.
That version was released before PF1 changed how its languages worked. Either downgrade to <IP_ADDRESS> if you are on V11 or upgrade to the latest version if you are on V12.

That indeed was the issue apparently. Silly me didn't even considered what was likely the most obvious cause. It does not list errors anymore, thanks for your answer!


Update Readme and follow coding standards

also add factory for future: adding more job scraper

are you referring to the Scrape() method or the instantiation of the scraper object?

@syahnur197
Not sure why I can't reply to the thread.
What I meant was that if we had to scrape the job centre website on each API call, the response would be very slow.


Assetloader: Recursive loading // Check for file types

Overview
I put some more work into the asset loader to add the ability to load directories recursively and to fix the game crashing when trying to load a file with the wrong love function (e.g love.audio.newSource for an image file).
For audio files I also added a file size limit to determine if a file should be loaded in streaming or static mode.
This PR should reduce the amount of work we have to put into loading assets even more & also allows us to easily create sub-folders if we want e.g for assets that belong to a single object like the fuelBase (landingLights.png, fulebaseOn.png, fuelbaseOff.png).
Other changes

Changed file name "landingLights2" back to "landingLights"
toggled debug output (to console) for the asset loader to "true" by default

I just added a license because I believe this can be useful separately for other smaller scale projects in the future & I'd like to make sure ppl can use it freely.

Nice. I'll check it tomorrow.
Can we pass an optional text parameter to force stream or static? Determining by file size is neat and will work 98% of the time but it world be nice to have the option to force a specific setting.
Perhaps something for the future?

Can we pass an optional text parameter to force stream or static? Determining by file size is neat and will work 98% of the time but it world be nice to have the option to force a specific setting.
Perhaps something for the future?

Sure, I'll look into it.

Can we pass an optional text parameter to force stream or static? Determining by file size is neat and will work 98% of the time but it world be nice to have the option to force a specific setting.

Okay, right now it's possible to load audio files in the desired mode by loading the files manually with
Assets.newSound("assets/streamAudio/rapMusic.mp3", "stream")

-- And using it with e.g
local music = Assets.getSound("rapMusic")
music:setVolume(.2)
music:play()

I also added an argument for Assets.loadDirectory(path, audioMode) to load all files from a specific directory with the desired mode (static mode by default). Usage:
-- Load images
Assets.loadDirectory("assets/images")
-- Load sounds (static mode)
Assets.loadDirectory("assets/sounds")
-- Load music (stream mode)
Assets.loadDirectory("assets/music", "stream")

When loading directories recursively, it's not possible to choose between audio loading modes because that would need me to pass something like an additional file list to the function for it to determine which file should be stream or not.
In that case I think it's better to just set the file size limit (Assets.audioStreamSizeLimit) to make sure that big audio files are not shoved directly into memory, which is the reason why the modes exist.

Tested. All good. Merging. Thanks.


feat: add adamr default config

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

6 of 6 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 96.694%

Totals

Change from base Build<PHONE_NUMBER>:
0.02%

Covered Lines:
468

Relevant Lines:
484

💛  - Coveralls


Change main page title and fix navigation

Hello I want to work on this issue.
Change this title

Fix this navigation

:white_check_mark: To be Mentioned while taking the issue :

Full name : Gustavo Felipe Dias Alexandre
GitHub Profile Link :  github.com/gfda
Participant ID (If not, then put NA) : NA
Approach for this Project :  I would use HTML, CSS and JS (if its necessary)
What is your participant role? Hacktoberfest contributor

@gfda please fill up the google form in the contributing.md file. If done so, start with your work. Please upload the file in the Projects Folder. Do not edit any file in the main directory. Create a copy for the files and then edit and then upload in the Projects folder.

Hey, @Nirvik07 , if @gfda isn't working on this issue anymore, could you assign it to me?

Oh, okay then, np bro. Wish you luck!


Delay when scrolling on the Backlog view page (Azure DevOps Server 2019)

I faced a problem with the delaying of the display of backlog items on the Backlog View page when scrolling.
We have a project with about 200 backlog items, I think it's not too much. It looks like the problem relates to forced reflow or layout of the page every time I scroll. In my case, the layout process takes from 75% to almost 99% of the time of the whole display task, and the average time of display after the scrolling about 500ms.
Could you try to investigate this?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 02ab6fbc-4df4-bc2d-da58-19dee9395256
Version Independent ID: e613f4a0-37a5-c2fa-fdf5-345c945de6db
Content: How are Backlogs used to support portfolios, priority, and multi-team ownership - Azure Boards
Content Source: docs/boards/backlogs/backlogs-overview.md
Product: devops
Technology: devops-agile
GitHub Login: @KathrynEE
Microsoft Alias: kaelli

@jok26r Thanks for your question. It looks like you've encountered an issue with the product itself, rather than an issue with the documentation. To make sure it gets in front of the right people, please submit your bug here.


DisplayLink Support

(copying the issue template from hyprland)
System Info and Version

System/Version info
Hyprland, built from branch  at commit cba1ade848feac44b2eda677503900639581c3f4  (props: bump version to 0.40.0).
Date: Sat May 4 15:42:32 2024
Tag: v0.40.0, commits: 4606
flags: (if any)
System Information:
System name: Linux
Node name: censored
Release: 6.8.10-400.asahi.fc40.aarch64+16k
Version: #1 SMP PREEMPT_DYNAMIC Mon May 27 16:05:41 UTC 2024
GPU information:
os-release: NAME="Fedora Linux Asahi Remix"
VERSION="40 (Workstation Edition)"
ID=fedora-asahi-remix
ID_LIKE=fedora
VERSION_ID=40
VERSION_CODENAME=""
PLATFORM_ID="platform:f40"
PRETTY_NAME="Fedora Linux Asahi Remix 40 (Workstation Edition)"
ANSI_COLOR="0;38;2;60;110;180"
LOGO=fedora-logo-icon
CPE_NAME="cpe:/o:fedoraproject:fedora-asahi-remix:40"
DEFAULT_HOSTNAME="fedora"
HOME_URL="https://fedora-asahi-remix.org/"
DOCUMENTATION_URL="https://docs.fedoraproject.org/en-US/fedora/f40/system-administrators-guide/"
SUPPORT_URL="https://discussion.fedoraproject.org/c/neighbors/asahi/asahi-help/94"
BUG_REPORT_URL="https://bugzilla.redhat.com/"
REDHAT_BUGZILLA_PRODUCT="Fedora"
REDHAT_BUGZILLA_PRODUCT_VERSION=40
REDHAT_SUPPORT_PRODUCT="Fedora"
REDHAT_SUPPORT_PRODUCT_VERSION=40
VARIANT="Workstation Edition"
VARIANT_ID=workstation
plugins:

Bug or Regression?
Bug
Description
DisplayLink dongles are USB-to-HDMI (or some other display connector) devices that use some Synaptics black magic to transfer the display signal over USB instead of USBs DP alt-mode.
Currently, attempting to start Hyprland with the DisplayLink drivers installed (from synaptics' website) just crashes Hyprland outright, unless WLR_RENDERER_ALLOW_SOFTWARE is enabled. From what I've been able to find this is due to missing wlroots support, everything works on gnome/mutter.
Supposedly this patch makes "regular" wlroots play nice with DisplayLink, unfortunately I haven't been able to manually build hyprland on my machine so I haven't been able to test it out.
How to reproduce
Install the DisplayLink drivers. It doesn't seem to whether a dongle is plugged in or not, just having the drivers installed is enough to crash Hyprland.
Crash reports, logs, images, videos
hyprlandCrashReport1316.txt

you can throw the patch into patches/ and it will automatically be applied during build.
g clone --recursive https://github.com/hyprwm/Hyprland
go into subprojects/wlroots-hyprland
throw the patch into patches/
build hyprland normally

you can throw the patch into patches/ and it will automatically be applied during build.

Unfortunately I can't build hyprland on arm64 Fedora, seems like build issues on Fedora are pretty common (and yes, I've followed the steps in https://github.com/hyprwm/Hyprland/discussions/284) and the arm64 part probably doesn't help.
If I set up an Arch arm64 VM, build hyrland there and copy the binary to my fedora system, would that work?

likely not

Update: I got it to build on my machine although I had to revert #10. DisplayLink works great, even the full edid data shows up in hyprctl.
@vaxerski Should I create a Pull request, even though I have no idea how the .patch works, just that it does?

feel free

Ran into a few issues setting up Hyprland + Evdi/DisplayLink myself - documenting here in hopes it'll helps someone.
My Laptop has an integrated intel GPU and a dedicated Nvidia GPU.
I have two external monitors connected via a wavlink docking station. A few options I explored to get the triple-screen setup working:

❌ Using Nvidia proprietary drivers

could not get hyprctl monitors to detect the two external monitors

❌ Using nouveau

all 3 monitors render properly, but Hyprland crashes often (I couldn't deduce why) and was occasionally laggy

✅ Using intel integrated graphics

this is what I ultimately went with - it's also recommended in the Multi-GPU Hyprland docs
out of the box, monitors were detected with hyprctl monitors, but no signals (black screen)
works well after manually patching wlroots

For (3), the workaround and explanation provided by Kacper Zuk is available here (do note the caveats):

https://gitlab.freedesktop.org/wlroots/wlroots/-/issues/1823#note_1254398

Specific to Hyprland, building from source, the steps are:

Cloning and building from source after installing all dependencies as per the installation docs:git clone --recursive https://github.com/hyprwm/Hyprland
cd Hyprland
make all && sudo make install

Edit one line in subprojects/wlroots-hyprland/backend/backend.c using the hack by Kacper Zuk, i.e.// change this line (at line 261 for me for wlroots-hyprland commit hash 422207db):
struct wlr_backend *drm = wlr_drm_backend_create(session, gpus[i], primary_gpu);

// to this:
struct wlr_backend *drm = wlr_drm_backend_create(session, gpus[i], NULL);

Build & recombile, then relaunchmake all && sudo make install

Other details
Hyprland Version:
Hyprland, built from branch main at commit d7ea1b7785f31e9fd6477490309721a19a835592
Tag: v0.41.2-14-gd7ea1b77, commits: 4900

linux version: 6.9.7.arch1-1
evdi-git version: 1.14.5.r2.ge36efa8-1
displaylink version: 6.0-0

This patch is not working correctly.
hyprctl monitors is able to detect the displays, but nothing happens and some apps like waybar crash or freeze.
I have maintained these AUR Packages for a while: https://aur.archlinux.org/pkgbase/hyprland-displaylink-git/
it had a working Patch til Hyprland 0.38.1 https://aur.archlinux.org/cgit/aur.git/tree/displaylink.patch?h=hyprland-displaylink-git
With the combination of patched wlroots https://gitlab.freedesktop.org/kennylevinsen/wlroots/-/compare/master...displaylink-hack?from_project_id=12103

Using this patch, now DisplayLink is working perfectly in my hyprland. However, i noticed that my laptop fan will constantly be running super loud (Temp > 75°C) with just a Firefox tab.
Then i checked the CPU usage and here's the result

Never experienced this before, Just switch to Hyprland yesterday

@Dev-Aligator see if you can reproduce the same issue on Sway or DWL (may need to apply the same wlroots patch elsewhere). If you can, then it may not be a Hyprland issue at all.


Fixed by #30532


Closes: #1

Updated validations.py python script.
Fixed the behavior of validate_user function in validations.py.
Fixes #<issue_number_goes_here>

It's a good idea to open an issue first for discussion.

[ ] Tests pass
[ ] Appropriate changes to README are included in PR

Make sure the first letter is always an alphabet.
Contributors : @avidekar


Add asserted distribution and collection object to geographic_area/shape search

Still used ST_ContainsProperly, and only does spatial matching (see #532, outstanding).

Coverage decreased (-0.003%) to 72.459% when pulling 464e551cb9fb7d878a0936100d59a892d4d58c9c on add_ad_to_geo_search into 787b10f7f1cf15055f5b8b02c182e071119eccd7 on development.


Error panel filtering

The error panel has some cool stuff (e.g the copy to clipboard button, project wide analysis etc).

But if you are migrating a javascript code base the errors can get too much to handle. Allow error panel filtering like "limit to open files" (atom style) and "search". Also they should work with goto next error.

The key design goal of this project is make it easy for the great majority of JavaScript projects out there to migrate to TypeScript. Quite commonly they will start in a sea of errors. We now have facility to help them reduce the noise to proceed step by step :rose:


local edit

Hi,
Thank you for your great work.
Which control are you using for the local editing?
Thanks,
Rotem

Hi @rotemshark ,
We conducted an ablation study on various types of controls in the paper, as illustrated in Figure 8. The study demonstrates that, despite style differences, these adjustments do not compromise overall consistency (such as changing a train to a cake).
Furthermore, we used depth-zoe as our default control approach in the RAVE paper for all other figures and metric results. For instance, the editing of "a man wearing a glitter jacket is typing" in Figure 1 was performed using this approach.
Thank you for your kind words.
Best,
Baris


Include this language tag for bash

Website: https://www.freecodecamp.org/news/symlink-tutorial-in-linux-how-to-create-and-remove-a-symbolic-link/
On inspect:

ln -s /home/james/transactions.txt trans.txt

Fixed in 4.7


Allow TextureAtlasBuilder in AssetLoader

Objective
Allow TextureAtlasBuilder in AssetLoader.
Fixes #2987
Solution

TextureAtlasBuilder no longer hold just AssetIds that are used to retrieve the actual image data in finish, but &Image instead.
TextureAtlasBuilder now required AssetId only optionally (and it is only used to retrieve the index from the AssetId in TextureAtlasLayout),

Issues

The issue mentioned here https://github.com/bevyengine/bevy/pull/11474#issuecomment-1904676937 now also extends to the actual atlas texture. In short: Calling add_texture multiple times for the same texture will lead to duplicate image data in the atlas texture and additional indices.
If you provide an AssetId we can probably do something to de-duplicate the entries while keeping insertion order (suggestions welcome on how exactly). But if you don't then we are out of luck (unless we can and want to hash the image, which I do not think we want).

Changelog
Changed

TextureAtlasBuilder add_texture  can be called without providing an AssetId
TextureAtlasBuilder finish no longer takes Assets and no longer returns a Handle

Migration Guide

For add_texture you need to wrap your AssetId in Some
finish now returns the atlas texture image directly instead of a handle. Provide the atlas texture to add on Assets to get a Handle

@doonv, want to take a look at this one too? And lemme know if you'd like org membership so you can triage things/I can request your review directly.

@B-Reif @adtennant I'd be interested in your opinions too.


Start sourcing icons from Sistent (1st phase)

Notes for Reviewers
This PR related to #9830
Signed commits

[ ] Yes, I signed my commits.

@nebula-aac, here's one that is ripe for your review.


Behavior when trying to transfer money from a wallet containing tokens so that the balance is less than 1 ADA

If you send money from a wallet that does not contain tokens so that the balance is less than 1 ADA, the balance that would have remained will be added to the fee.
This means that the balance after the transfer will never fall below 1 ADA, and the transfer will be successful.
However, it seems that this function does not work well with wallets that contain tokens, and you can move to the confirmation screen without adding the commission fee.
When I try to send money  entering the password, the message "Not enough ada for fees. Try sending a smaller amount.

@sakakibaraakio Are you trying to move all the ADA on your wallet and not the tokens?
If that's the case, Daedalus won't allow this action, since it calculates how much ADA you'd need to move the tokens you still have in the wallet and it prevents any transaction that would result in a smaller balance.
In other words, you cannot empty a wallet with tokens, since you'd need ADA to operate them.
We're aware the messaging and fee calculation might not be clear about this, so there will be future improvements in that regard.
Let me know if you have further questions!

Hi @sakakibaraakio, I spoke to the team and apparently we've already got an improvement for this: https://github.com/input-output-hk/daedalus/pull/2783 - it will be shipped with the upcoming release, so stay tuned! 📻
I'm going to close this issue, if you have any further questions or feedback, please leave a comment here and we'll reopen the issue.


Add default mutation operators to Config constructor

This task includes following. Suppose we init config from yaml with mutaton operators: add, negate. If Config constructor has default mutation operators : negate, add, remove, than YAMLTraits will map: add -> negate, negate -> add, thus producing following: add, negate, remove instead of add, negate.

@Quolyk I now see that you mean something different, not just parsing default 3 values from a YAML file correctly. I would recommend you to add a unit test to demonstrate a specific behavior you're talking about here.


swamp: flakiness TestFullReconstructionFromBridge/TestFullReconstructFromLights

2022-08-22T14:10:26.7726609Z === RUN   TestFullReconstructFromBridge
2022-08-22T14:10:26.8829082Z 2022-08-22T14:10:26.882Z	DEBUG	basichost	basic/basic_host.go:313	failed to fetch local IPv6 address	{"error": "no route found for ::"}
2022-08-22T14:15:26.7657184Z     reconstruct_test.go:73:
2022-08-22T14:15:26.7658964Z         	Error Trace:	/home/runner/work/celestia-node/celestia-node/node/tests/reconstruct_test.go:73
2022-08-22T14:15:26.7659500Z         	Error:      	Received unexpected error:
2022-08-22T14:15:26.7659980Z         	            	context deadline exceeded
2022-08-22T14:15:26.7660391Z         	Test:       	TestFullReconstructFromBridge
2022-08-22T14:15:26.7916402Z --- FAIL: TestFullReconstructFromBridge (300.03s)

2022-08-22T14:15:26.7918426Z === RUN   TestFullReconstructFromLights
2022-08-22T14:15:26.9144991Z 2022-08-22T14:15:26.914Z	DEBUG	basichost	basic/basic_host.go:313	failed to fetch local IPv6 address	{"error": "no route found for ::"}
2022-08-22T14:15:57.3519653Z     reconstruct_test.go:180:
2022-08-22T14:15:57.3520532Z         	Error Trace:	/home/runner/work/celestia-node/celestia-node/node/tests/reconstruct_test.go:180
2022-08-22T14:15:57.3521085Z         	Error:      	Received unexpected error:
2022-08-22T14:15:57.3521961Z         	            	context deadline exceeded
2022-08-22T14:15:57.3522404Z         	Test:       	TestFullReconstructFromLights

It started to happen after #1010, so might be bitswap update introduced flakiness. Specifically, from 0.8.0 to 0.9.0


fix: responsive Footer Alignment for Various Screen Sizes #1676

Description
Resolved issue #1676 by ensuring proper alignment of footer content across smaller screen sizes for improved responsiveness and visual consistency.

@Mayaleeeee Can you please give your reviews regarding this alignment?
IMHO, no design changes are required in the footer. It is already good from my side.


chore(ci): Update renku actions to v1.5.0

Update acceptance tests
/deploy #persist

You can access the deployment of this PR at https://renku-ci-nb-1545.dev.renku.ch

merged into #1548


Implement SOAP decoder

This patch implements a SOAP decoder as specified in MC-NBFS. The specification basically specifies a predefined dictionary.
This should be the last pull-request for now. I also implemented an encoder but it's not yet ready (some testing with an actual .NET backend is still needed).

Thank you so much for all your contributions. It's all extremely well written.


[workloadmeta,tagger] Move proto utils

What does this PR do?
It's a small refactor.
Moves the protobuf utils to convert to and from Workloadmeta and Tagger types from pkg/util/proto to the workloadmeta and the tagger directories.
pkg/util/proto only contained helpers for workloadmeta and tagger so I think it makes sense them to move to their respective directories.
Describe how to test/QA your changes
Skip.

/merge


os.rename can not found model-2600

I didn't change any file
Traceback (most recent call last):
File "train.py", line 161, in
train_cnn_rnn()
File "train.py", line 151, in train_cnn_rnn
os.rename(path, trained_dir + 'best_model.ckpt')
FileNotFoundError: [Errno 2] No such file or directory: './checkpoints_1504000981/model-2600' -> './trained_results_1504000981/best_model.ckpt'

I have change the code as follow:
logging.critical('Training is complete, testing the best model on x_test and y_test')
saver.save(sess, trained_dir + 'best_model.ckpt')
Evaluate x_test and y_test
saver.restore(sess, checkpoint_prefix + '-' + str(best_at_step))


How do I use routes?

I've installed cloud-controller-manager and I'm researching about routes features. I didn't find any mentions about router configuration in the docs, but in sources there's routes.go with some functionality. I hoped that it'd allow CNI to send routes to openstack router and avoid using network encapsulation like VxLan, etc.
I'm using the following snippet in cloud.conf:
    [Global]
    auth-url="https://auth.pscloud.io/v3/"
    application-credential-id="$OS_APPLICATION_CREDENTIAL_ID"
    application-credential-secret="$OS_APPLICATION_CREDENTIAL_SECRET"
    region="kz-ala-1"

    [Metadata]
    search-order="metadataService"

    [Route]
    router-id=27fdfeba-1f16-41bd-9610-6ca7b74d1c2b

Router ID is identifier from openstack UI for router that's connected to the network Kubernetes running in.
With this configuration controllers are crashing and I'm getting the following scary but not very informative log:
I0712 15:15:32.553250       1 controllermanager.go:272] Starting "service"
I0712 15:15:32.558110       1 openstack.go:336] Claiming to support LoadBalancer
I0712 15:15:32.558370       1 controllermanager.go:291] Started "service"
I0712 15:15:32.558446       1 controller.go:233] Starting service controller
I0712 15:15:32.558461       1 shared_informer.go:255] Waiting for caches to sync for service
I0712 15:15:32.558558       1 controllermanager.go:272] Starting "route"
I0712 15:15:32.868259       1 openstack.go:449] Claiming to support Routes
E0712 15:15:32.868293       1 controllermanager.go:275] Error starting "route"
F0712 15:15:32.868298       1 controllermanager.go:180] error running controllers: failed to parse cidr value:"" with error:invalid CIDR address:
goroutine 225 [running]:
k8s.io/klog/v2.stacks(0x1)
        /home/runner/work/cloud-provider-openstack/cloud-provider-openstack/.go/pkg/mod/k8s.io/klog/v2@v2.60.1/klog.go:860 +0x8a
k8s.io/klog/v2.(*loggingT).output(0x306f3a0, 0x3, 0x0, 0xc0000f8690, 0x1, {0x257807f, 0x1}, 0x306ff00, 0x0)
        /home/runner/work/cloud-provider-openstack/cloud-provider-openstack/.go/pkg/mod/k8s.io/klog/v2@v2.60.1/klog.go:825 +0x686
k8s.io/klog/v2.(*loggingT).printfDepth(0x306f3a0, 0x2041a28, 0x0, {0x0, 0x0}, 0xc000487920, {0x1da6686, 0x1d}, {0xc000726820, 0x1, ...})
        /home/runner/work/cloud-provider-openstack/cloud-provider-openstack/.go/pkg/mod/k8s.io/klog/v2@v2.60.1/klog.go:630 +0x1f2
k8s.io/klog/v2.(*loggingT).printf(...)
        /home/runner/work/cloud-provider-openstack/cloud-provider-openstack/.go/pkg/mod/k8s.io/klog/v2@v2.60.1/klog.go:612
k8s.io/klog/v2.Fatalf(...)
        /home/runner/work/cloud-provider-openstack/cloud-provider-openstack/.go/pkg/mod/k8s.io/klog/v2@v2.60.1/klog.go:1516
k8s.io/cloud-provider/app.Run.func1({0x20593d0, 0xc0007b6e00}, 0xc000113400)
        /home/runner/work/cloud-provider-openstack/cloud-provider-openstack/.go/pkg/mod/k8s.io/cloud-provider@v0.24.0/app/controllermanager.go:180 +0x345
k8s.io/cloud-provider/app.Run.func2({0x20593d0, 0xc0007b6e00})
        /home/runner/work/cloud-provider-openstack/cloud-provider-openstack/.go/pkg/mod/k8s.io/cloud-provider@v0.24.0/app/controllermanager.go:225 +0xe4
created by k8s.io/client-go/tools/leaderelection.(*LeaderElector).Run
        /home/runner/work/cloud-provider-openstack/cloud-provider-openstack/.go/pkg/mod/k8s.io/client-go@v0.24.0/tools/leaderelection/leaderelection.go:211 +0x154

goroutine 1 [select (no cases)]:

and then huge stacktrace follows.
I tried to google about this feature, but it's not mentioned anywhere. Except in logs if I remove this router-id configuation, it's mentioned very shortly that router-id is missing (which is why I started to research this at all).
Without router-id everything works just fine.

I hoped that it'd allow CNI to send routes to openstack router and avoid using network encapsulation like VxLan, etc.

don't fully understand the use case.. the router is L3 concept and likely in VxLAN /Geneve , so if you want to avoid such
then I think use provider network (L2 concept) is the thing you should use? thus router-id is not something you should set?
anyway, need clearer view on the goal you want to achieve.. thanks

RIght now I'm using calico with encapsulation mode. As I understand it: all IP packets from pod network are encapsulated using something called VXLAN and those encapsulated packets are sent to a target node, then unwrapped and delivered to the target pod. This encapsulation process introduces overhead and isolates pod network from node network (so I can't ping my pods from node, for example).
Calico by default does not do encapsulation and as I understand it, uses BGP to announce routes for pod network to the router. Router is supposed to receive those routes and then use them to route packets between pods. It does not work for me, at least with my provider. I thought that if I would be able to announce those routes via openstack router API instead of BGP, it would work, and I expected this routes.go code to do exactly that.
I don't manage openstack installation, I'm more like client of it, so I can't configure server side.
If I'm wrong, then I guess that's not an issue to me. But still there's code in repo, there's warning in logs about unconfigured option (if not configured), so it'd be nice to have some documentation about this feature.

I didn't write the route, but to solve your case , kubectl edit daemonset  openstack-cloud-controller-manager -n kube-system  and add this line
      containers:
      - args:
        - /bin/openstack-cloud-controller-manager
        - --v=1
        - --cluster-name=$(CLUSTER_NAME)
        - --cloud-config=$(CLOUD_CONFIG)
        - --cloud-provider=openstack
        - --use-service-account-credentials=true
        - --bind-address=<IP_ADDRESS>
        - --cluster-cidr=<IP_ADDRESS>/20 ===> depends on your settings, add this line and your desired CIDR

then you can avoid the error you saw and you will see something like follwing in the log,
need more insight on the routes itself due to not so much expertise on it for now
I0716 08:33:03.745333       1 route_controller.go:194] Creating route for node capi-quickstart-md-0-5lnfl <IP_ADDRESS>/24 with hint 6d82fd41-5fea-4a12-b4aa-32c9a2b8977e, throttled 16.589µs
I0716 08:33:03.745343       1 route_controller.go:194] Creating route for node capi-quickstart-control-plane-ffmnt <IP_ADDRESS>/24 with hint 47910415-4bf0-461c-8c19-e26d0c057eca, throttled 11.087µs
I0716 08:33:05.638241       1 route_controller.go:214] Created route for node capi-quickstart-md-0-5lnfl <IP_ADDRESS>/24 with hint 6d82fd41-5fea-4a12-b4aa-32c9a2b8977e after 1.892902135s
I0716 08:33:07.051831       1 route_controller.go:214] Created route for node capi-quickstart-control-plane-ffmnt <IP_ADDRESS>/24 with hint 47910415-4bf0-461c-8c19-e26d0c057eca after 3.306492795s

this is for my own reference and maybe some expert can comment to help as well
the routes seems create route on given router which means it makes pod inside tenant able to communicate through given router , I doubt whether it's needed if CNI like calico is used .. need more dig
openstack router show 5ea61b43-a36a-4bd9-922f-5cd1765dc0f7
....
| routes                  | destination='<IP_ADDRESS>/24', gateway='<IP_ADDRESS>'                                                                                |
|                         | destination='<IP_ADDRESS>/24', gateway='<IP_ADDRESS>'


Slides with dynamic content show initial value when used with infinite scroll

Describe the bug
Dynamic slides do not work as intended with "infinite" prop.
To Reproduce
Steps to reproduce the behavior:

Go to https://codesandbox.io/s/x3k64q47qq
Click on -/+ buttons on the first slide.
Click arrows to go from last slide to the first one.
Notice that the initial value can be seen before current value is set.

Expected behavior
There should be no visible change of the values when going back and forth on the carousel.
Screenshots

Additional context
I made an implementation that does not have this issue (based on https://medium.com/@incubation.ff/build-your-own-css-carousel-in-react-part-one-86f71f6670ca).
Later I'll upload demo to show how it could be implemented, although I am not sure if it would not cause big changes in the API.
I am looking for a carousel library that works correctly, but from ones that I have tested (Swiper, react-slick ) all suffer from the same problem. This may be a specific need that is not required for most users, but it would be nice to have if it does not introduce big breaking changes or need to rewrite big portions of the codebase.

Hi @jaworek
First off, thank you for your effort of providing complete information about that issue. Unfortunately, we won't be able to look into it any time soon. In reference to the Additional context would you be willing to take a look into it? There might be a straightforward fix for that. What do you say?

Hi,
Sorry for late reply. I'm not working on the project related to this issue anymore.
I'll try to find a solution, when I have some spare time.

@jaworek
are you able to find time to fix it?
no problem if not, I just remind you because maybe you have some time available but you forgot about this issue

You can close it for now.

@jaworek
Can I ask you to fill in this form https://docs.google.com/forms/d/1tfRs1Io49tJBwz-06aDnz8hrJ3WySJTi45y4k6hHGaQ ?


Week 2.5: use Datastore to permanently store comments

Be sure to include descriptions with your PRs. This will help give reviewers more context into your changes and help them provide better feedback.


Fix inconsistent ValidatorState after re-org'ing deposit

WIP: Opened to get early feedback
This commit fixes the issue with deposits during re-orgs.
Reference to the issue: https://github.com/dtr-org/unit-e/issues/972
Signed-off-by: Kostiantyn Stepaniuk<EMAIL_ADDRESS>

Closing this PR in favor of this one https://github.com/dtr-org/unit-e/pull/1009


Add FirebaseStorage for Android and iOS

Library
Class
Platforms

storage
FirebaseStorage
Android, iOS

I need this module for the app I'm currently building so I'm taking a crack at it. Does anyone have any guidance on how to handle the two platform apis being different?

Hi @mjmarathon can you send links to the API docs for the methods you mentioned? Generally, the best way to handle these difference is to find the kotlin way to do the same kind of thing use that instead - for example, the 3 platforms all have different ways to serialise objects so we use kotlin serialization and convert to the platform specific formats under the hood

Hey there @nbransby! Thanks for the quick follow up.
Docs for the aforementioned methods here:
https://firebase.google.com/docs/reference/android/com/google/firebase/storage/StorageReference#getStream(com.google.firebase.storage.StreamDownloadTask.StreamProcessor)
https://firebase.google.com/docs/reference/android/com/google/firebase/storage/StorageReference#putStream(java.io.InputStream, com.google.firebase.storage.StorageMetadata)
If the ios platform sdk doesn't support/use streams I'm unsure about how to keep the streaming methods exposed.

I need this module for the app I'm currently building so I'm taking a crack at it. Does anyone have any guidance on how to handle the two platform apis being different? E.g. Android's StorageReference.get/putStream() vs ios' nothing.

I can think of 3 ways to solve that issue:

You could share putStream and abstract the Stream class, to receive a Stream and call putStream on Android, and receive a NSFile and call putFile on iOS;
You could share putStream but have a no-op (dummy) implementation on iOS
You could keep the putStream method only for Android (you might just access it through the StorageReference.android member directly when you want to use it, or you could create a method on StorageReference in androidMain)

I think the 3rd option is the best, at least inside the library. Not everything should be shared. And if you want to create an extension function in your final shared code, that calls putFile on iOS and putStream on Android

Was added in https://github.com/GitLiveApp/firebase-kotlin-sdk/pull/393


Java DS added

I have added 4 algos and also updated readme

There's no need to add links to the end of README. These algorithms already exist in the README. Just append. :)

@saru95  I have Updated Read me as said by you. And also added the algos. U can merge them

Please resolve the merge conflicts :)

I will be creating a new Pull Request very Shortly. I am closing this pull request.


added anomaly detection model in matlab langugae

Hey, @KayJey Please describe your project in the readme file please elaborate on it !!


Finish git-lfs install

Currently, for git lfs to work (added in #468), the user must add to their bootstrap script
su buildkite-agent -l -c 'git lfs install'

(This command adds the necessary hooks to ~/.gitconfig.)

Odd, I thought this was covered in the install already! I wonder if this is something we should do by default?

Thank you for this report @pauldraper! Sorry this was so long coming but I have added this in #912 for packaging in our next release 🎉  We appreciate you taking the time to help us improve our product :bow:


Changed default page to name lookup

From what I can tell this seems to be the simple fix for issue #64

I love a good one line change to resolve an issue.


Question: Costs and Pricing of Webdataset Writing to AWS S3 using Pipe Mode

Hi,
The following code works to write a numpy array of 1000 samples to an S3 webdataset in Pipe mode.
import numpy as np
import webdataset as wds
from dotenv import load_dotenv
from tqdm import tqdm

assert load_dotenv("/home/ubuntu/.security/.s3-update.env")

data = np.random.rand(1000, 1000, 1000)

with wds.TarWriter("pipe:aws s3 cp - s3://my-bucket-name/test.tar") as sink:
    for i in tqdm(range(len(data))):
        sink.write({"__key__": f"{i}", "data.npy": data[i]})
print("done")

My question is, how to estimate the AWS costs for two scenarios:

Running locally on my laptop?
Running on an EC2 instance in the same region as the S3 bucket?

The main thing I want to know is do I pay per sample or do I pay per pipe connection?
Thanks!

AWS doesn't know anything about samples; as far as it is concerned, you are just writing a stream to a bucket, if slowly. So, you're paying for ingress bandwidth and storage. But AWS may not charge for ingress bandwidth at all (Google doesn't).
However, the recommended way of writing shards is to local disk and then use "aws cp localfile.tar s3://my-bucket/shard-00123.tar". That's both because some object storage systems don't like small writes, and because you want the upload to happen only when the shard was created successfully.
Shardwriter has a special callback that gets called every time a shard is complete to let you do that.


[Bug] Memory aliasing keeps entire ztoc file in memory

Description
When looking at a heap profile of the soci snapshotter while a workload is running, the memory usage is dominated by io.ReadAll coming from ztoc.Unmarshal. The memory from io.ReadAll is the memory allocated to the ztoc when we read it from disk here. Normally, this buffer would be GC'd once the method returns, but flatbufToZtoc creates a *Ztoc which has a direct reference to compressionInfo.CheckpointBytes() which forces the entire unparsed ztoc to remain in memory until that reference is released. Since the ztoc stays in memory for the lifetime of the container, the memory is used indefinitely.
I haven't looked too closely, so there might be other aliasing, but at the very least we should copy the checkpoint bytes so we can free the rest of the unparsed ztoc.
Example flamegraph (the image doesn't really matter, it seems to always be ztocs that use the memory):

Steps to reproduce the bug

Launch a container with SOCI where the config contains debug_address = ":6060"
Wait for the ztocs to be downloaded and the fuse filesystems to be set up
curl for a heap profile: curl -s localhost:6060/debug/pprof/heap > heap.pprof
visualize the pprof: go tool pprof -http :8080 ./heap.pprof

Describe the results you expected
io.ReadAll should not be present in the heap profile.
Host information

OS:
Snapshotter Version:
Containerd Version:

Any additional context or information about the bug
No response

Fixed in #975


CT documentation

POD documentation for the Certificate Transparency API - fixes #1274.
This is a draft, and is likely to be missing useful information - please point out what would be helpful to add. Some of the PODs are missing most of their content - I'll update this PR over the next couple of days filling those holes.

Looking better. There are still a few outstanding comments, and still some pods that need filling in. I assume you are planning to fill these in?

@RJPercival what is the status of this...9 days to 1.1.0 release...?

I'm working on it again today, and will have it done this week. I was OOO
all of last week.
On Tue, 16 Aug 2016 at 10:30 mattcaswell<EMAIL_ADDRESS>wrote:

@RJPercival https://github.com/RJPercival what is the status of
this...9 days to 1.1.0 release...?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/openssl/openssl/pull/1372#issuecomment-240052585, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AB29lNSly-xPLlhxS_9ijyTtRUOL6UTZks5qgYNEgaJpZM4JZ6fX
.

3 days to go...

I've also been ill (not a great couple of weeks for getting stuff done!). I'm typing PODs as we speak though.

I re-read every single comment here.  I think this is the only outstanding change:
diff --git a/doc/crypto/SCT_new.pod b/doc/crypto/SCT_new.pod
index a12408b..754df23 100644
--- a/doc/crypto/SCT_new.pod
+++ b/doc/crypto/SCT_new.pod
@@ -145,7 +145,7 @@ required for verifying the SCT.
 Some of the setters return int, instead of void. These will all return 1 on
 success, 0 on failure. They will not make changes on failure.

-Most of the setters will reset the validation status of the SCT to
+All setters will reset the validation status of the SCT to
 SCT_VALIDATION_STATUS_NOT_SET (see L<SCT_verify(3)>).

 SCT_set_source() will call SCT_set_log_entry_type() if the type of
;

Fixed, along with PR #1487.

Is this now finished (aside from review?). With a quick scan through I didn't spot any sections still to be filled in.

All issues raised so far have been addressed.  Plus-one from me.  I encourage a separate MR for new podpages.

+1 merge

any new doc updates or additions should go into a separate MR.

All comments addressed.

+1 subject to the following commit being added. If I can get a +1 from the team for that I can push this:
From 43acc3254a04a5a1fc19de45f6524a298beca25d Mon Sep 17 00:00:00 2001
From: Matt Caswell<EMAIL_ADDRESS>Date: Wed, 24 Aug 2016 10:03:04 +0100
Subject: [PATCH] Misc tweaks and fixes for the CT documentation

---
 doc/crypto/CTLOG_new.pod    | 1 -
 doc/crypto/SCT_print.pod    | 4 ++--
 doc/crypto/ct.pod           | 2 +-
 doc/crypto/o2i_SCT_LIST.pod | 6 +++---
 4 files changed, 6 insertions(+), 7 deletions(-)

diff --git a/doc/crypto/CTLOG_new.pod b/doc/crypto/CTLOG_new.pod
index de196f4..ccda6b9 100644
--- a/doc/crypto/CTLOG_new.pod
+++ b/doc/crypto/CTLOG_new.pod
@@ -45,7 +45,6 @@ the string remains with the CTLOG.

 CTLOG_get0_public_key() returns the public key of the CT log. Ownership of the
 EVP_PKEY remains with the CTLOG.
-with

 =head1 RETURN VALUES

diff --git a/doc/crypto/SCT_print.pod b/doc/crypto/SCT_print.pod
index d14a98e..88ad43e 100644
--- a/doc/crypto/SCT_print.pod
+++ b/doc/crypto/SCT_print.pod
@@ -25,8 +25,8 @@ is provided, it will be used to print the description of the CT log that issued
 each SCT (if that log is in the CTLOG_STORE). Alternatively, NULL can be passed
 as the CTLOG_STORE parameter to disable this feature.

-B<SCT_validation_status_string> will return the validation status of an SCT as
-a human-readable string. Call L<SCT_validate>() or SCT_LIST_validate()
+SCT_validation_status_string() will return the validation status of an SCT as
+a human-readable string. Call SCT_validate() or SCT_LIST_validate()
 beforehand in order to set the validation status of an SCT first.

 =head1 SEE ALSO
diff --git a/doc/crypto/ct.pod b/doc/crypto/ct.pod
index 65a4ea2..bdcda98 100644
--- a/doc/crypto/ct.pod
+++ b/doc/crypto/ct.pod
@@ -31,7 +31,7 @@ functions for:

 L<d2i_SCT_LIST(3)>,
 L<CTLOG_STORE_new(3)>,
-L<CTLOG_STORE_get0_log_by_id(3),
+L<CTLOG_STORE_get0_log_by_id(3)>,
 L<SCT_new(3)>,
 L<SCT_print(3)>,
 L<SCT_verify(3)>,
diff --git a/doc/crypto/o2i_SCT_LIST.pod b/doc/crypto/o2i_SCT_LIST.pod
index 302a288..82922fc 100644
--- a/doc/crypto/o2i_SCT_LIST.pod
+++ b/doc/crypto/o2i_SCT_LIST.pod
@@ -23,14 +23,14 @@ treated and the return values.

 =head1 RETURN VALUES

-All of the functions have return values consist with those stated for
+All of the functions have return values consistent with those stated for
 L<d2i_SCT_LIST> and L<i2d_SCT_LIST>.

 =head1 SEE ALSO

 L<ct(3)>,
-L(d2i_SCT_LIST(3)>,
-L(i2d_SCT_LIST(3)>
+L<d2i_SCT_LIST(3)>,
+L<i2d_SCT_LIST(3)>

 =head1 HISTORY

--
2.7.4

Oh...scratch that last comment. Your updates didn't show up here so didn't see them.

+1

Ping @richsalz for reconfirm

+1 from me

Merged. Thanks!


The plugin doesn't work for me.

The Indent Indicator never appears.
nvim --version: NVIM 0.1.5
Operating system/version:Linux version 4.7.5-1-ARCH (builduser@tobias) (gcc version 6.2.1 20160830 (GCC) ) #1 SMP PREEMPT Sat Sep 24 13:04:22 CEST 2016
Terminal name/version:rxvt-unicode
$TERMscreen-256color

I found the problem due to the plugin being lazy load.


Extracts Options for react_component helper

This change is

Looks good -- CI needs to pass and please don't remove the comments per the comments below.

Reviewed 4 of 4 files at r1.
Review status: all files reviewed at latest revision, 2 unresolved discussions, some commit checks failed.

app/helpers/react_on_rails_helper.rb, line 104 [r1] (raw file):
Please do not remove these comments

app/helpers/react_on_rails_helper.rb, line 111 [r1] (raw file):
Please do not remove these comments

Comments from Reviewable

Review status: 1 of 4 files reviewed at latest revision, 2 unresolved discussions.

app/helpers/react_on_rails_helper.rb, line 104 [r1] (raw file):
Done.

app/helpers/react_on_rails_helper.rb, line 111 [r1] (raw file):
Done.

Comments from Reviewable

Coverage increased (+0.5%) to 85.325% when pulling ea14b10632f614e697a3cb7701cc7a07f3406dca on mario/extract-react-component-options into 5e0b7d5042996b4da9a1c9e2c88acbccada356e7 on master.

 @mapreal19 Please sync with master and I'll merge this.

Reviewed 3 of 3 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

Coverage increased (+0.5%) to 85.325% when pulling 1e38e34d61b9631f3fa3ecd40b2185c6cb577841 on mario/extract-react-component-options into efbf7055cb9f184135f35187bd718c2452468eb4 on master.

Done :shipit:

Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.

Comments from Reviewable