SSL Communication Between Containers

Is your feature request related to a problem? Please describe.
Having an issue communicating between containers which orbstack doesn't really solve.
I used to use a reverse proxy which handled all the SSL, but now I'm trying to have this centralised in orbstack.
Communication between host works fine i.e. https://container.orb.local resolves SSL perfectly.
However within containera.orb.local I'm trying to call https://containerb.orb.local, there is no port 443 listening of course, so this doesn't work.
This is because within containers speaking to another container only resolves the actual ports it's listening to, i.e. the raw ports.
Describe the solution you'd like
Realistically .local should be similar within containers as it is host>container.
If needed "ports" could still be possible using docker network and communicating via the container name directly (i.e. http://localstack:4566).
Ideally there would also be a path in which the SSL cert can easily be accessed to it can be added into the certificate chains of all containers.

I just found this issue while trying to understand why a frontend running as a compose service can make successful requests from the browser to the backend running in the same compose project, while the same frontend app fails to make server side requests (from within the container) to the other container. Any ideas how to solve this? Given the emphasis that orbstack's marketing puts on ssl and urls, I was really confused that the assigned URLs don't work from within a container.

@jmotes thanks for pointing me to those discussions! I have the same issue, just a different frontend with hybrid rendering (nuxt) and a nodeJS backend instead of wordpress. I don't need SSL for my purposes (local testing), so I'll try to disable https for the containers and see if that makes container->container communication any easier to handle, since @kdrag0n refers specifically to "https communication" in one of the discussions :)

@jmotes, the proposed solution works on a basic level, but it introduces complications.
For example, we use LocalStack for S3, and the URL users access files from (via the OrbStack SSL) is https://s3.orb.local/.
Due to this bug, our app cannot communicate with https://s3.orb.local/ and has to use http://localstack:5544/ instead. However, this causes all S3 signed URLs to be generated for http://localstack:5544/.
As a result, we've had to add additional logic to switch the URL paths, leading to our app being filled with code handling these URL changes, which just gets messy.
Ideally if a container is using https://*.orb.local it should be no different from the host talking to the stack.

@alexw23 I agree that would be ideal.
The workaround I'm using in my project includes Caddy in to give me [container].[project].local domains instead of the *.orb.local ones. I added caddy aliases to our docker-compose file and installed the root cert in each container to give for container-to-container HTTPS communication using the same domains. I wrote a setup script that installs the certs so I don't have to do it manually.
It's not a perfect solution by any means, but keeps us moving while we wait on native support in OrbStack.

Added in v1.8.0.

Thanks @kdrag0n! I saw that in the release notes the other day. It's working well!!

@kdrag0n how does this work exactly, as I'm getting self-signed issues when trying to communicate between containers using the new https?
> curl https://othercontainer.acme.local/2015-03-31/functions/a-really-cool-function-name/invocations -vvv
*   Trying <IP_ADDRESS>:443...
* Connected to othercontainer.acme.local (<IP_ADDRESS>) port 443 (#0)
* ALPN, offering h2
* ALPN, offering http/1.1
* successfully set certificate verify locations:
*  CAfile: /etc/ssl/certs/ca-certificates.crt
*  CApath: /etc/ssl/certs
* TLSv1.3 (OUT), TLS handshake, Client hello (1):
* TLSv1.3 (IN), TLS handshake, Server hello (2):
* TLSv1.3 (IN), TLS handshake, Encrypted Extensions (8):
* TLSv1.3 (IN), TLS handshake, Certificate (11):
* TLSv1.3 (OUT), TLS alert, unknown CA (560):
* SSL certificate problem: self signed certificate in certificate chain
* Closing connection 0
curl: (60) SSL certificate problem: self signed certificate in certificate chain
More details here: https://curl.se/docs/sslcerts.html

curl failed to verify the legitimacy of the server and therefore could not
establish a secure connection to it. To learn more about this situation and
how to fix it, please visit the web page mentioned above.

@alexw23 my understanding is it only works with the domains that the reverse proxy generates: [service].[network].orb.local

@jmotes you can use custom domains for anything *.local, doesn't have to be orb.local.
The URL (https://othercontainer.acme.local) resolves fine on the host machine without any SSL errors.
In saying this rule out any possible misunderstanding I've tested with orb.local also:
root@3bc7f3f8fe3d:/# curl https://containername.project.orb.local --verbose
*   Trying <IP_ADDRESS>:443...
* Connected to containername.project.orb.local (<IP_ADDRESS>) port 443 (#0)
* ALPN, offering h2
* ALPN, offering http/1.1
* successfully set certificate verify locations:
*  CAfile: /etc/ssl/certs/ca-certificates.crt
*  CApath: /etc/ssl/certs
* TLSv1.3 (OUT), TLS handshake, Client hello (1):
* TLSv1.3 (IN), TLS handshake, Server hello (2):
* TLSv1.3 (IN), TLS handshake, Encrypted Extensions (8):
* TLSv1.3 (IN), TLS handshake, Certificate (11):
* TLSv1.3 (OUT), TLS alert, unknown CA (560):
* SSL certificate problem: self signed certificate in certificate chain
* Closing connection 0
curl: (60) SSL certificate problem: self signed certificate in certificate chain
More details here: https://curl.se/docs/sslcerts.html

curl failed to verify the legitimacy of the server and therefore could not
establish a secure connection to it. To learn more about this situation and
how to fix it, please visit the web page mentioned above.

I assume this is because the self-signed certificates aren't mounted in the container?

You may be right. I still have Caddy's root cert mounted in my containers from when I was using my own reverse proxy, so that might be helping things work for me.

@jmotes got it, so you're using own SSL certs with orbstack?

@alexw23 actually, I just tried with curl and have the same issues as you! I have container-to-container connections using PHP's Guzzle that appear to be working just fine though. I'll try to dig more into this tomorrow to see if I can figure out what's going on.

@jmotes  Fixed this for now by installing the Orbstack root certificate into my main containers.

@tisba Nothing in orbctrl I believe. Your CLI prompt would be the best way to do this... I just clicked on the certificate in chrome, selected "OrbStack Development Root CA" and hit "export".
As for this issue I'm not sure how the developers would even fix this accounting for all the variations of linux docker flavours etc.

I guess that's pretty distro AND application specific inside the container. I actually ment obtaining the certificate itself. Using security find-certificate depends on the name not changing.
In case you want to automate this, what works for me:
security find-certificate -c "OrbStack Development Root CA" -p > ~/OrbStack/docker/containers/$CONTAINER_NAME/usr/local/share/ca-certificates/orbstack.crt

And then run update-ca-certificates in the container. For quick hacks you can also directly append to /etc/ssl/certs/ca-certificates.crt (which might get overwritten).

security find-certificate -c "OrbStack" might be safer. Also if it doesn't find a certificate it exits with exit code 44.


[SPARK-23672][PYTHON] Document support for nested return types in scalar with arrow udfs

What changes were proposed in this pull request?
Clarify docstring for Scalar functions
How was this patch tested?
Adds a unit test showing use similar to wordcount, there's existing unit test for array of floats as well.

cc @BryanCutler

Test build #88600 has started for PR 20908 at commit 342d222.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1764/
Test PASSed.

Test build #88600 has finished for PR 20908 at commit 342d222.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88600/
Test FAILed.

Test build #88765 has started for PR 20908 at commit 88b65c5.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1870/
Test PASSed.

Test build #88765 has finished for PR 20908 at commit 88b65c5.

This patch fails Python style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88765/
Test FAILed.

Test build #88824 has started for PR 20908 at commit 091a761.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1908/
Test PASSed.

Test build #88824 has finished for PR 20908 at commit 091a761.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88824/
Test FAILed.

Test build #89452 has started for PR 20908 at commit f5aeafc.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2391/
Test PASSed.

Test build #89452 has finished for PR 20908 at commit f5aeafc.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Jenkins retest this please.

Test build #90235 has started for PR 20908 at commit f5aeafc.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2938/
Test PASSed.

Test build #90235 has finished for PR 20908 at commit f5aeafc.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90235/
Test FAILed.

Merged build finished. Test FAILed.

Jenkins retest this please

Jenkins retest this please

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/930/
Test PASSed.

Merged build finished. Test PASSed.

Test build #92976 has started for PR 20908 at commit f5aeafc.

Test build #92976 has finished for PR 20908 at commit f5aeafc.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92976/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/2143/
Test PASSed.

Test build #94698 has started for PR 20908 at commit 03798e0.

Test build #94697 has finished for PR 20908 at commit 7a42096.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94697/
Test FAILed.

Test build #94698 has finished for PR 20908 at commit 03798e0.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Jenkins retest this please.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/2959/
Test PASSed.

Test build #95850 has started for PR 20908 at commit 03798e0.

Test build #95850 has finished for PR 20908 at commit 03798e0.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95850/
Test PASSed.

merged to master and branch-2.4, thanks @holdenk !


Add dark toggle button

The website does not have a dark mode, which is a highly requested feature for users who prefer lower brightness settings.
I can implement a dark mode toggle with smooth transitions between light and dark themes.
Please assign me this issue under gssoc'24 EXTENDED and hacktoberfest

please assign to me

completing by tomorrow

@shreyad2806 any update?

can you assign this to me also , I'll give you my version of dark mode and then you can select whichever version you like more

@coderashhar another contributor raised this issue before you, so I need to give them priority.


Is it normal there is no controller in the package?

I get his error
Interface 'Symfony\Cmf\Bundle\TreeBrowserBundle\Tree\TreeInterface' not found
using
doctrine-phpcr-admin-bundle
So is it normal or did the cleanup was too much strong?

are you already using the unstable 2.0 of doctrine-phpcr-admin-bundle? otherwise you should never end up with version 2 of this bundle.
if you are on version 2 already, check with @WouterJ who is doing that refactoring. might be that there is some issue currently, with the heavy refactoring we are doing.

You are using SonataDoctrinePhpcrAdmimBundle 2.0-dev. That one is not yet stable and at the moment not updated with the most recent treebrowserbundle.
In general, don't use unstable packages...

Ok Thx for the info


Raise test timeout

In
https://github.com/jensblanck/cdar/blob/f7e6b6bfb296a89232b0555425f698accb98264b/test/Test.hs#L24
the test timeout is set to 200 ms. That breaks running the tests on massively parallel CI servers, such as the one I run for static-haskell-nix, where the process may not be scheduled for a while.
It would be great if the timeout could be raised to make that unlikely, or if one could give an option to set it from the CLI or disable the timeout entirely.

Hi, I'm a newbie with regards to project maintenance. I'd be happy to change to whatever value you wish, or if you could tell me how to disable the limit.

@jensblanck I'll just do a semi-educated guess and that 10x the current value (2 seconds) will probably be fine on most very-busy machines.
You're apparently using tasty; that seems to have a CLI option --timeout. If you could find out which one takes precedence if that's given (that value, or your mkTimeout value in the code above), and it turns out that it's that value, that would also provide a nice way to override it externally.
Thanks!

Changed to 4 seconds.

Thanks!


Suggestion

Submitter: LovinglyGaslight
The ability to make Ghouls on the creator would be super helpful.

Thanks for the feedback. This is already suggested in #161 and mentioned in #177 as well. Good to know it's a highly desired feature though. Closing this issue.


different results when using SI's set and merge

Hi there I encountered this inexplicable difference when using seamless immutable's set and merge. For example
let item = store.getState().items[0] // --> an immutable item {price: 100}

afterItemA = item.set('price', 123) // {price: 123}
afterItemB = item.merge({price: 456}) // {price: 456}

// Updating with the merged object
store.dispatch({
    type: 'ITEMS_UPDATE_START',
    record: afterItemB,
})
// then a generic ajax request is made to backend and we get a response 'res'
store.dispatch({
    type: 'ITEMS_UPDATE_SUCCESS',
    record: res
})
let item = store.getState().items[0] // --. It STILL is a seamless immutable js object

// updating with the set object
store.dispatch({
    type: 'ITEMS_UPDATE_START',
    record: afterItemA,
})
 // same everything ajax request and calling dispatch with ITEMS_UPDATE_SUCCESS, BUT:
  let item = store.getState().items[0] // --. It IS NO LONGER a seamless immutable js object

Is there a reason why?
Thank you!

I don't have an explanation for this, I will have to put a test together to try to replicate this issue

This is no longer relevant in v2


Scripting against the API

The idea to script against the MDT API has come up in the MDP to support bulk export from a system and get the data into the MDT.
It would be an interesting experiment to see how easy one could script an upload, post a data mapping and trigger a process to create the datasets. This will of course require very consistently formatted input files to be repeatable.
If this is feasible, can we document a process to explore the potential?

I wonder if we can just record the traffic from a browser session to capture the requests sent and turn that into a document?

See this example


az login --service-principal --username <> --tenant <> --password <>/service-principal.key errors with below error

This is autogenerated. Please review and update as needed.
Describe the bug
Command Name
az login
Errors:
[('PEM routines', 'PEM_read_bio', 'no start line')]
Traceback (most recent call last):
python3.7/site-packages/knack/cli.py, ln 206, in invoke
    cmd_result = self.invocation.execute(args)
cli/core/commands/__init__.py, ln 603, in execute
    raise ex
cli/core/commands/__init__.py, ln 661, in _run_jobs_serially
    results.append(self._run_job(expanded_arg, cmd_copy))
cli/core/commands/__init__.py, ln 654, in _run_job
    six.reraise(*sys.exc_info())
...
azure/cli/core/_profile.py, ln 1020, in __init__
    cert = load_certificate(FILETYPE_PEM, self.cert_file_string)
python3.7/site-packages/OpenSSL/crypto.py, ln 1837, in load_certificate
    _raise_current_error()
python3.7/site-packages/OpenSSL/_util.py, ln 54, in exception_from_error_queue
    raise exception_type(errors)
OpenSSL.crypto.Error: [('PEM routines', 'PEM_read_bio', 'no start line')]

To Reproduce:
Steps to reproduce the behavior. Note that argument values have been redacted, as they may contain sensitive information.

Put any pre-requisite steps here...
az login --service-principal --username {} --tenant {} --password {}

Expected Behavior
Environment Summary
Darwin-18.7.0-x86_64-i386-64bit
Python 3.7.4
Shell: bash

azure-cli 2.0.71 *

Extensions:
azure-devops 0.12.0

Additional Context

Looks similar to https://github.com/Azure/azure-cli/issues/9970. Please let us know if this solves the issue. If not, please provide all commands used. Thanks.


[HOTFIX] Implemented quick fixes identified during demo

Completed

updated generic labels
updated tooltips
updated tables
updated db schema

TODO

updated test data
replace remaining simple tables with data tables
standardise all data tables

Changes are great. One comment re lower bound capacity no longer being used on supervisor my projects table so it can be removed.
Something else to note, may not be important right now, but an instance can be created without any of the required flags - Level 4, Level 5 and Software Engineering. We may want to implement this in future.

Yes, I didn't add that as a requirement just yet as I was waiting to hear back about whether we'll setup the allocation instance or not.


fix: review sonarcloud security hotspot

This pull request works on security issues that sonar cloud detect.
To fix them, I did the next changes:

Set the cookies the right way to add secure flags and make sure that works only with the http protocol
Add noopener to secure links on all files and deny basic phishing attacks.

i no see any test 👀


Fix Silverlight uninstall

The bundle id was wrong. Even after fixing it there were some files
leftover that weren't included in the receipt data. Turns out these
leftover "*.ni.dll" files are compiled during the installation process,
so the only way to get rid of the plugin completely is to delete the
entire Silverlight.plugin package.

Thanks!


filter/search boxes positioning and margins off

the boxes are not all enough and have a gap below them.

It's fixed in https://github.com/twosigma/beakerx/pull/7311


Improve release automation using xtask

Currently, largely due to the sheer number of packages in this repository, releasing is a bit of a headache to put it mildly. Let's please discuss how we can automate this process to remove the possibility of human error as much as possible.
Some possible improvements:

Determine which packages have changes, and why type of version increase the changes warrant (e.g. minor, patch)
Automatically bump version numbers as needed, and update any dependent packages in the repository accordingly
Automatically update CHANGELOG.md files prior to releasing
Publish packages automagically

@MabezDev @tom-borcin let's please discuss this tomorrow in our meeting.

My 2 cents;
I've been using the following tool: https://github.com/clog-tool/clog-lib for a while in one of my project and it's been going well. If this helps with the mentioned points above, that's good.

I don't know if I'm just slow or what, but I have tried cargo-semver-checks multiple times now and failed to ever get it working, constantly getting new horrifying errors, so unfortunately at this point I'm going to rule this out as a possibility. If anybody else has had success using this for embedded libraries I would love to hear how you got it working.
I will see if I can try to come up with some alternative approach.

I don't think the first item in the task list is reasonably possible at this point, this will still require manual review.


Allow browsing of downsampled thanos data in Grafana

As per https://github.com/improbable-eng/thanos/issues/601
We need to enable the '--query.auto-downsampling' flag
So that grafana can browse data beyond the Raw Data period of prometheus/sidecar
Dashboard showing 70d data of prometheus and alertmanager config-reloads

looks good to me on green

thanks!


Add one CloudStack test to quick e2e tests

Issue #, if available:
Description of changes:
This PR adds the one CloudStack test to the quick e2e test suite.
To accommodate the introduction of more tests, the quick tests are now being filtered through retrieving a list of regex from a yaml file.
Testing (if applicable):

Ran the test against CI

Documentation added/planned (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/lgtm

/approve


broken link in fargate doc

https://github.com/awslabs/mxnet-model-server/blob/master/docs/mms_on_fargate.md
See:
With the current release of MMS, 1.0, Official pre-configured, optimized container images of MMS are provided on Docker hub.
awsdeeplearningteam/mxnet-model-server:1.0.0-mxnet-cpu
Link to awsdeeplearningteam/mxnet-model-server:1.0.0-mxnet-cpu is creating 404

Thanks for reporting this issue. We will fix the broken link.

This is fixed.


GUI : Test 32 characters minimum password requirement

Test 32 characters minimum password requirement via GUI.
Dev story - https://github.com/ibm-openbmc/dev/issues/981

Anything pending here ?


⚠ Shadow's Blogosphere has degraded performance

In 889d91b, Shadow's Blogosphere (https://blog.everythingbagel.me) experienced degraded performance:

HTTP code: 200
Response time: 10892 ms

Resolved: Shadow's Blogosphere performance has improved in 16bcc52 after 12 minutes.


Add Felix Cabrera to Contributors list

Hi  @ysites, I'm quite elated about your pull request. I wanna evolve this project to addresses various problems faced by first-time contributors. I'd love to learn about your journey in open source community, the problems, pain points you had etc.
Could you explain how you felt when you went through the tutorial, made a pull request and learned that I merged it?
We’ve recently added social share  to our web app. Could you please go to https://roshanjossey.github.io/first-contributions/#social-share and share your first contribution to open source?
Also, check out projects with easy issues while you’re there.

The process was really smooth. I felt great because of the excellent explanation on the README.md file and the resources provided there. Also, it felt awesome when I saw the purple icon that said that you merged the commit. Sure.


Conda env create problem

I encountered this exception when i try to  create a fresh env with the latest environment file.
I have testet this on mac and ubuntu.
The jupyter_nbextensions_configurator requirement(for the cell magic in nb?)  occurs the problem. Without this requirement the installation is working.
Requirement already satisfied: testpath in ./anaconda3/envs/catalyst_0_5_20/lib/python3.6/site-packages (from nbconvert->notebook>=4.0->jupyter_nbextensions_configurator==0.4.0->-r condaenv.cajbfptk.requirements.txt (line 34))
Exception:
Traceback (most recent call last):
  File "envs/catalyst_0_5_20/lib/python3.6/site-packages/pip/_vendor/pkg_resources/__init__.py", line 2797, in _dep_map
    return self.__dep_map
  File "envs/catalyst_0_5_20/lib/python3.6/site-packages/pip/_vendor/pkg_resources/__init__.py", line 2608, in __getattr__
    raise AttributeError(attr)
AttributeError: _DistInfoDistribution__dep_map

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "envs/catalyst_0_5_20/lib/python3.6/site-packages/pip/_vendor/packaging/requirements.py", line 92, in __init__
    req = REQUIREMENT.parseString(requirement_string)
  File "envs/catalyst_0_5_20/lib/python3.6/site-packages/pip/_vendor/pyparsing.py", line 1617, in parseString
    raise exc
  File "envs/catalyst_0_5_20/lib/python3.6/site-packages/pip/_vendor/pyparsing.py", line 1607, in parseString
    loc, tokens = self._parse( instring, 0 )
  File "envs/catalyst_0_5_20/lib/python3.6/site-packages/pip/_vendor/pyparsing.py", line 1379, in _parseNoCache
    loc,tokens = self.parseImpl( instring, preloc, doActions )
  File "envs/catalyst_0_5_20/lib/python3.6/site-packages/pip/_vendor/pyparsing.py", line 3376, in parseImpl
    loc, exprtokens = e._parse( instring, loc, doActions )
  File "envs/catalyst_0_5_20/lib/python3.6/site-packages/pip/_vendor/pyparsing.py", line 1383, in _parseNoCache
    loc,tokens = self.parseImpl( instring, preloc, doActions )
  File "envs/catalyst_0_5_20/lib/python3.6/site-packages/pip/_vendor/pyparsing.py", line 3164, in parseImpl
    raise ParseException(instring, loc, self.errmsg, self)
pip._vendor.pyparsing.ParseException: Expected stringEnd (at char 33), (line:1, col:34)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "envs/catalyst_0_5_20/lib/python3.6/site-packages/pip/_vendor/pkg_resources/__init__.py", line 2874, in __init__
    super(Requirement, self).__init__(requirement_string)
  File "envs/catalyst_0_5_20/lib/python3.6/site-packages/pip/_vendor/packaging/requirements.py", line 96, in __init__
    requirement_string[e.loc:e.loc + 8]))
pip._vendor.packaging.requirements.InvalidRequirement: Invalid requirement, parse error at "'; extra '"

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "envs/catalyst_0_5_20/lib/python3.6/site-packages/pip/basecommand.py", line 215, in main
    status = self.run(options, args)
  File "envs/catalyst_0_5_20/lib/python3.6/site-packages/pip/commands/install.py", line 335, in run
    wb.build(autobuilding=True)
  File "envs/catalyst_0_5_20/lib/python3.6/site-packages/pip/wheel.py", line 749, in build
    self.requirement_set.prepare_files(self.finder)
  File "envs/catalyst_0_5_20/lib/python3.6/site-packages/pip/req/req_set.py", line 380, in prepare_files
    ignore_dependencies=self.ignore_dependencies))
  File "envs/catalyst_0_5_20/lib/python3.6/site-packages/pip/req/req_set.py", line 699, in _prepare_file
    set(req_to_install.extras) - set(dist.extras)
  File "envs/catalyst_0_5_20/lib/python3.6/site-packages/pip/_vendor/pkg_resources/__init__.py", line 2757, in extras
    return [dep for dep in self._dep_map if dep]
  File "envs/catalyst_0_5_20/lib/python3.6/site-packages/pip/_vendor/pkg_resources/__init__.py", line 2799, in _dep_map
    self.__dep_map = self._compute_dependencies()
  File "envs/catalyst_0_5_20/lib/python3.6/site-packages/pip/_vendor/pkg_resources/__init__.py", line 2809, in _compute_dependencies
    reqs.extend(parse_requirements(req))
  File "envs/catalyst_0_5_20/lib/python3.6/site-packages/pip/_vendor/pkg_resources/__init__.py", line 2867, in parse_requirements
    yield Requirement(line)
  File "envs/catalyst_0_5_20/lib/python3.6/site-packages/pip/_vendor/pkg_resources/__init__.py", line 2876, in __init__
    raise RequirementParseError(str(e))
pip._vendor.pkg_resources.RequirementParseError: Invalid requirement, parse error at "'; extra '"

CondaValueError: pip returned an error

Hi @avolution, I wasn't able to reproduce your issue on MAC. Do you already have an environment called catalyst while trying to create a new one? If so, please make sure that the environment does not exist before following these steps: https://enigma.co/catalyst/install.html# (another solution is to change the name of the environment in the YML file by updating the name specified in the first line). Please update me if the problem was resolved.

Tested again and it works now.
Maybe a temporary problem with the package manager service.


Huge bundle size!

google-protobuf is adding about 50Kb gzipped to the bundle size! (230 minified)
Is there a way to improve this?

We are aware of the issue and agree we could do better. A good path forward would be to investigate tree shaking when building our runtime.

Can I work on this somehow?


Handle multiple result sets

I'd like to improve SQLPad's handling of multiple result sets. What this looks like I'm not sure yet, and may end up having to be database dependent due to driver implementation.
Multiple result sets will be broken out and rendered into multiple grids. For the initial implementation, data visualization will likely be disabled when multiple results are returned (or at least limited to 1 result set)

Regardless of any connection,  multi queries separated by semicolon need to be supported. Despite some drivers (eg: mysql, allowMultiQueries=true) can native support.

@dengc367 the server side of things is handled for this by the sql-limiter library.
Regardless of driver, sqlpad will split queries on ; and run them separately (reusing the same database connection if possible).
What's left is to work on the UI to render these a separate queries. Right now the last query run is displayed

Maybe we can change the GUI to be more "flowing", so when a query is "RUN" its output will be displayed at the bottom

similar to Jupyter Notebooks except that you can't edit the past, only add at the bottom. This way is more similiar to  CLIs (terminal) in the sense that user can look back to what s/he did and see previous error messages etc.

@eladeyal-intel if the flowing format were used, would you see an issue if the table was paginated and fixed to displaying a small number of rows at a time (like 10 or so)? I'm thinking it would be necessary to prevent having a scrollable area inside another scrollable area, which can become tricky to navigate. Maybe the smaller table could be expanded to full screen if a full scrollable table was desired?
If this was implemented, I'd  personally want it to be an option for end user to switch between the 2 layouts.
When I write SQL I tend to iterate without much need for history, and its kind of nice to have everything fixed in place.
Regardless of layout, I still need to figure out how charting is going to work with this...

I think the TAB format above the result region is good for habit, like multi-queries scenario in Navicat software.

Update on this - multiple result set support is implemented in v6 branch but not with the flowing UI.
I think its worth exploring this alternative display though, so I'm going to leave this issue open and target a 6.x release.

Tried experimenting with a flowing UI and I'm not so sure its a good fit. A lot of little nuances of interaction became kind of tricky to deal with and impacted some of the existing flows today (do you focus on next editor? what happens if query results fill page?). These UI interactions are solved when on the CLI, but started to feel clunky on the web.
Another challenge stems from having to "virtualize" the blocks of information, as the gradual addition of components from prior runs starts to take a toll on React perf without special handling.
Instead I leveraged the flowing layout somewhat and added a history button, which opens the history for the current query. Each entry can be loaded back into editor state, including chart configuration, which is kind of neat.

Limitation to current implementation however is that query results are not shown. This is partially a restriction on front end data limits, as well as a consequence of how the query result data is stored. Each query result is stored as a JSON blob, so there's no efficient way to take a small subset from each without reading the whole thing.
Enhancing the history previews will require some minor enhancements to the way query data is being stored today, but I'm not sure how strong the need is for that.


Remove Freenom

Freenom isn't a good option for free domain names any longer, can we remove it?
Domain registration has been halted due to a lawsuit, their website doesn't allow registration.
https://krebsonsecurity.com/2023/03/sued-by-meta-freenom-halts-domain-registrations/
Existing customer domains are getting taken down.
https://www.reddit.com/r/freenom/comments/154c1x8/ml_domains_are_getting_taken_down_and_no_longer/

Thank you for contributing!


Iteration Plan for November 2019

This plan captures our work in November. This is a 5-week iteration. We will ship our November Update in early December.
Last month we focussed on getting our issue database back in shape and we made great progress. As this included bug fixing and debt work, unlike in other months, we'll start with feature work right away and skip our typical debt week. Unsurprisingly, November is densely packed with feature work all across VS Code. It stretched from addressing paper cuts all the way to big-rock items such as settings sync and more flexible workbench layout. You also see a new Web section. With the public availability of Visual Studio Online you can now use VS Code also in the browser and we'll surface any related future work on our iteration plans.
Endgame

December 2nd, 2019: Endgame begins
December 6th, 2019: Endgame done

The endgame details for this iteration are tracked in TBD.
Plan Items
Below is a summary of the top level plan items.
Legend of annotations:

Mark
Description

:runner:
work in progress

:hand:
blocked task

:muscle:
stretch goal for this iteration

:red_circle:
missing issue reference

:large_blue_circle:
more investigation required to remove uncertainty

:black_circle:
under discussion within the team

UX

[X] :runner: Create a design toolkit for extension authors https://github.com/microsoft/vscode/issues/83952 @misolori
[ ] :muscle: Identify design inconsistencies with UI + JSON experiences https://github.com/microsoft/vscode/issues/84309 @misolori

Workbench

[ ] :runner: Support for custom editors https://github.com/microsoft/vscode/issues/77131 @mjbvz @jrieken @bpasero
[x] Compressed tree support in the explorer (merging sequences of single child directories in the Explorer) https://github.com/microsoft/vscode/issues/41627 @joaomoreno
[ ] :runner: Settings sync support (settings, extensions, key bindings, snippets) https://github.com/microsoft/vscode/issues/2743 https://github.com/microsoft/vscode/issues/78966 @sandy081
[ ] :runner: Provide login support for settings sync https://github.com/microsoft/vscode/issues/84332 @rmacfarlane
[ ] :muscle: Setting sync support in the default Settings editor https://github.com/microsoft/vscode/issues/84431 @roblourens
[X] :runner: Use icon fonts for product icons https://github.com/microsoft/vscode/issues/78889 @misolori @bpasero
[ ] :muscle: Support for custom views with WebView contents https://github.com/microsoft/vscode/issues/83911 @alexr00
[x] Show SCM decorations in the minimap https://github.com/microsoft/vscode/issues/20934 @rmacfarlane
[x] Support search as you type across files https://github.com/microsoft/vscode/issues/46326 @jacksonkearl
[x] Support auto-expanding all search results in the search viewlet https://github.com/microsoft/vscode/issues/83917 @jacksonkearl
[ ] :runner: Copy search results in a search-results editor https://github.com/microsoft/vscode/issues/23931 @jacksonkearl
[x] Filter by type in problems view https://github.com/microsoft/vscode/issues/47354 @sandy081
[x] Show problems only for current active file - https://github.com/microsoft/vscode/issues/30038  @sandy081
[x] Show current error in status bar - https://github.com/microsoft/vscode/issues/20183  @sandy081
[x] Improve trusted domain support for url shorteners https://github.com/microsoft/vscode/issues/83731 @octref
[ ] :runner: Allow to move sidebar views to the panel and vice versa https://github.com/microsoft/vscode/pull/84642 @sbatten
[x] Polish custom dialogs with long contents (such as the open url confirmation) @sbatten
[ ] :runner: Explore how to improve existing notebook implementations https://github.com/microsoft/vscode/issues/84293 @rebornix

Editor

[ ] :runner: Semantic coloring - VS Code Language API and implementation https://github.com/microsoft/vscode/issues/77140 @alexandrudima
[ ] :runner: Semantic coloring - Syntax tokens and theming https://github.com/microsoft/vscode/issues/77133 @aeschli
[x] Improve the editor release process with automated builds and tests monaco-editor#1668 @rebornix

Terminal

[x] Experimental WebGL renderer https://github.com/microsoft/vscode/issues/84949 @Tyriar

Languages

[ ] :runner: Finish Call Hierarchy navigation and align it with the find all references support https://github.com/microsoft/vscode/issues/83419, https://github.com/microsoft/vscode/issues/83274 @jrieken
[x] Review and polish existing code navigation gestures, https://github.com/microsoft/vscode/issues/83752 @jrieken
[x] Run reference search when running go-to-symbol command on target, https://github.com/microsoft/vscode/issues/73081 @jrieken
[ ] :runner: Navigate between symbols in file, https://github.com/microsoft/vscode/issues/46153 @jrieken
[x] Show keybindings in Refactor menu https://github.com/microsoft/vscode/issues/84101 @mjbvz
[ ] :runner: Explore how extensions can announce all refactorings they support https://github.com/microsoft/vscode/issues/82718 @mjbvz

LSP / LSIF

[ ] :runner: Finalize LSP spec version 3.15 @dbaeumer
[ ] Add LSIF to the LSP portal @dbaeumer
[ ] :runner: Support Call Hierarchy navigation https://github.com/microsoft/language-server-protocol/issues/468 @dbaeumer
[ ] :muscle: Support semantic coloring in the spec LSP #18  @dbaeumer
[ ] :muscle: Support semantic coloring in the LSP libraries LSP Libs #368 @dbaeumer
[ ] Productize the TypeScript LSIF indexer issues @dbaeumer

CSS/HTML/JSON

[x] Improve performance of emmet in large html files https://github.com/microsoft/vscode/issues/71996 @octref
[x] Explore Saas variable completion across files https://github.com/microsoft/vscode/issues/6734 @octref
[x] Improve ranking of css properties based on statistics like chromestatus.com https://github.com/microsoft/vscode/issues/3145 @octref
[x] :runner: Improve performance of auto-rename tag (core or extension contribution) https://github.com/microsoft/vscode/issues/47069 @octref
[ ] Publish blog post about our custom data support https://github.com/microsoft/vscode/issues/83928 @octref

TypeScript/JavaScript

[X] Adopt TS v3.7 https://github.com/microsoft/vscode/issues/83935 @mjbvz

Debug

[ ] :runner: Investigate into using language service support for scope resolution https://github.com/microsoft/vscode/issues/84044 @weinand
[ ] Allow attaching/detaching from the debug targets https://github.com/microsoft/vscode/issues/79314 @weinand
[ ] :runner: Improve initial debug / run experience https://github.com/microsoft/vscode/issues/84677 @isidorn @weinand
[ ] :runner: Debug console - Improve presentation of input/output https://github.com/microsoft/vscode/issues/37363 @isidorn
[x] :runner: Improve discoverability of 'Restart Frame' https://github.com/microsoft/vscode/issues/84045 @isidorn
[ ] Debug console - Support for log grouping https://github.com/microsoft/vscode/issues/34981 @isidorn
[ ] :muscle: Debug console - Support to find text https://github.com/microsoft/vscode/issues/4338 @isidorn
[ ] :runner: Improve support for PWAs https://github.com/microsoft/vscode-pwa/issues/56 @connor4312 @roblourens

SCM

[ ] :runner: Explore File History view https://github.com/microsoft/vscode/issues/84297 @eamodio
[ ] :runner: Investigate a more organic integration between GitLens with the core SCM https://github.com/microsoft/vscode/issues/84300 @eamodio
[x] :runner: Adopt FileSystemProvider API: https://github.com/microsoft/vscode/issues/55110 @joaomoreno
[ ] :runner: Git: Adopt editor in SCM input: https://github.com/microsoft/vscode/issues/84831 @joaomoreno

API

API finalization: query
API proposals: query
Closer engagement with the VS Code extension authors

[ ] :runner: Make it easier for extension authors to follow our API workflow https://github.com/microsoft/vscode/issues/84507 @eamodio @jrieken
[ ] :runner: Explore closer feedback loop with extension authors https://github.com/microsoft/vscode/issues/84506 @eamodio

Extension Contributions

[ ] Improvements to the Remote extensions (see plan here) team
[ ] :runner: ESLint - Improve TypeScript integration and support #802 @dbaeumer
[x] ESLint - Improve support for mono repositories https://github.com/microsoft/vscode-eslint/issues/745 @dbaeumer
[x] ESLint - Improve Auto fix support https://github.com/microsoft/vscode-eslint/issues/154 @dbaeumer

Web

[x] Improve support for Firefox and Safari @bpasero @rebornix
[x] Improve support for mobile @rebornix
[x] Support running VS Code Web out of sources aka yarn web @bpasero
[x] Enrich yarn web by adding mock search provider, mock problems provider, custom task running, ... @bpasero
[x] Provide hosted version of yarn web for issue validation https://github.com/microsoft/vscode/issues/84485 @bpasero
[x] :runner: Enrich yarn web by adding debug support @weinand

Engineering

[ ] Notarization of VS Code builds for OS X/Catalina https://github.com/microsoft/vscode/issues/74782 @bpasero @joaomoreno
[ ] :runner: Automatic signing of RPM packages https://github.com/microsoft/vscode/issues/78727 @tyriar
[ ] :runner: Explore upgrade to electron 7 https://github.com/microsoft/vscode/pull/83796 @deepak1556
[ ] Identify the work required to use chrome process architecture https://github.com/microsoft/vscode/issues/79138 @deepak1556
[ ] :runner: Convert native modules to NAPI https://github.com/microsoft/vscode/issues/79137 @deepak1556
[x] Adopt strictPropertyInitialization https://github.com/microsoft/vscode/issues/78168 team
[ ] :runner: Adopt enableStrictFunctionTypes https://github.com/microsoft/vscode/issues/81574 team
[ ] :runner: Implement revised issue triaging workflow https://github.com/microsoft/vscode/issues/83125 @kieferrm @chrmarti
[x] :runner: Improve build resubmission perf https://github.com/microsoft/vscode/issues/85107 @joaomoreno

Planning

[ ] Develop and publish the 2020 roadmap https://github.com/microsoft/vscode/issues/84015 @egamma @kieferrm @chrisdias
[ ] Collaborate with TS on their 2020 roadmap https://github.com/microsoft/vscode/issues/84102 @mjbvz

Deferred Items

:runner: Increase automation for upgrading to newer Electron versions https://github.com/microsoft/vscode/issues/77159 @deepak1556

it's nice including code --web as a feature.

will vs-code web opensource recently?

Re yarn web: Please see https://github.com/microsoft/vscode-docs/blob/vnext/release-notes/v1_40.md#run-vs-code-web-out-of-sources for docs.

hi, why update 1.40.2 for ubuntu is not available in repository but only can be downloaded on vs code website page?

@zeroidentidad It updated now. Please try again.

@chrmarti thanks, I check it out

@kieferrm @chrmarti
I'm the author of Settings Sync extension. I wanted you know about the plans of integrating Settings Sync within code. I saw multiple tickets with that.
Are you guys going to develop full Sync solution within code inlcuding UX, API and backend provider ( like Gist in Settings Sync ) or the goal will be to provide the API access to authors to manage the backend providers

What about #12058, pretty please?

@shanalikhan Current plan is to build end to end settings sync feature. Please see https://github.com/microsoft/vscode/issues/2743#issuecomment-560116420 about the proposal.

It will be great if support attaching to kubernetes container.

I agree ill start a workshop for u
On Sun, Dec 1, 2019, 10:52 PM Zheyu Zhang<EMAIL_ADDRESS>wrote:

It will be great if support attaching to kubernetes container.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/vscode/issues/83930?email_source=notifications&email_token=AN5O42ZPETS7QZVZTYV4TT3QWSA6NA5CNFSM4JIUZ762YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFSDX6A#issuecomment-560217080,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AN5O423ZYH5FFVIK3SJSFW3QWSA6NANCNFSM4JIUZ76Q
.

i am coming

It would be nice to see the multi-line tabs feature implemented soon.

Duplicate of #
@zeroidentidad

#86048


blog.excalidraw.com/year-three

It seems that it is time to hang a ready total of 2022 ? It's not vital, so it's up to you, I was interested to read last years totals,  https://blog.excalidraw.com/year-two/ https://blog.excalidraw.com/one-year-of-excalidraw/
Thank you for your work and Happy New 2023 Year🎄

Thanks. Coming out soon!


FileStorageProvider::getFileForSaving() seems to have wrong arguments

According to https://adobexdplatform.com/plugin-docs/reference/uxp/module/storage.html#module-storage-filesystemprovider-getfileforsaving, types (an array of file extensions) is the only valid option. However, initialDomain is set in the typings (https://github.com/AdobeXD/typings/blob/master/types/uxp.d.ts#L200).

@kerrishotts I think I remember that in the Beta, initalDomain actually was an argument that could be passed and had a bunch of symbols somewhere in the storage module. Have they since been removed (since they aren't part of the docs anymore)?

Could also be relevant for https://github.com/AdobeXD/typings/blob/master/types/uxp.d.ts#L212, https://github.com/AdobeXD/typings/blob/master/types/uxp.d.ts#L186 and https://github.com/AdobeXD/typings/blob/master/types/uxp.d.ts#L396.


Creates a schedule for the ~quarterly Working Group updates

This documents a schedule for the ~quarterly Working Group updates as described in #13.
Currently the Code of Conduct and Approvers WG are not included.
/cc @ampproject/tsc
@jpettitt and @lannka as FYI since they would be the first two to present.

SGTM thanks for the heads up.
How long an update should we prepare?

This is the WG member pages we wanted to generate?  Interesting idea.
One tricky thing is to make sure that we account for weeks we skip due to holidays and the creation/modification/disbanding of working groups, but these aren't insurmountable.
@sebastianbenz WDYT?  How hard would it be to add this logic as part of the code that's generating the team list pages?  Basically we'd assign upcoming Design Review slots to each WG in a round-robin fashion.
Regarding @lannka's question, @cramforce do you have a sense of how long an update the @ampproject/tsc would like from the WGs?  I was thinking 10-15 minutes to leave the rest of the hour for the design review.

10-15 minutes sounds good. And this can merge, of course, before we figure out a long-term plan.

@cramforce sgtm; can you approve the PR? :)


docs/usage: lspconfig.setup directly?

Is it possible to do directly?
require "lspconfig".efm.setup {
    init_options = {documentFormatting = true},
    settings = {
        rootMarkers = {".git/"},
        languages = {
            lua = {
                require('efmls-configs.linters.luacheck'),
                require('efmls-configs.formatters.stylua'),
            }
        }
    }
}

This way no need to go indirectly through efmls-configs-nvim setup API

At this point not really, there is one option that we have called default_config which will load a list of predefined linters and formatters listed in default configurations
I can move it to a function that lspconfig can consume with
require "lspconfig".efm.setup {
    init_options = {documentFormatting = true},
    settings = {
        rootMarkers = {".git/"},
        languages = require "efmls-configs".default_languages
    }
}

But will require some changes to how it's being handled

At this point not really, there is one option that we have called default_config which will load a list of predefined linters and formatters listed in default configurations page.
I can move it to a function that lspconfig can consume with:
require "lspconfig".efm.setup {
    init_options = {documentFormatting = true},
    settings = {
        rootMarkers = {".git/"},
        languages = require "efmls-configs".default_languages
    }
}

Initially the way I wrote it was for my diagnosticls-configs plugin and was wanting to simplify the same interface into this plugin.
But open for some suggestions!

require "efmls-configs".default_languages

This makes a lot of sense! Works nicely with tbl_extend / tbl_deep_extend. Probably can already use require "efmls-configs/defaults". Just a matter of pointing it out in the README if it works I think. I'll try it in my own config sometime when I get the chance.

Thinking of the following ways to setup (adding them here for reference):
Method 1 - Standalone
-- Setup a list of default linters/formatters to run with efm
local languages = require('efmls-configs').default_languages

require('lspconfig').efm.setup({
  filetypes = vim.tbl_keys(languages),
  settings = {
    rootMarkers = { '.git/' },
    languages = languages,
  },

  on_attach = ...,
  capabilities = ...,
  init_options = {
    documentFormatting = true,
    documentRangeFormatting = true,
  },
})

Languages can also be defined as a custom table if you don't want all the default ones:
-- Define a custom configuration
local languages = {
  typescript = {
    require('efmls-configs.linter.eslint'),
    require('efmls-configs.formatters.prettier'),
  },
  lua = {
    require('efmls-configs.linter.luacheck'),
  },
}

Method 2 - with a setup() API
However I wanted to make a simple API for my usecase, which is optional.
local efm_config = require('efmls-configs').setup({
  -- Setup a list of default linters/formatters to run with efm
  defaults = true,

  -- Define a custom configuration
  -- Also overrides any language defined in `defaults`
  -- `linters`/`formatters` take a string or a table
  languages = {
    typescript = {
      linters = {
        'eslint',
        require('efmls-configs.linters.xo'),
      },
      formatters = { 'prettier' },
    },
    lua = {
      linters = { 'luacheck' },
    },
  },
})

require('lspconfig').efm.setup(vim.tbl_extend('force', efm_config, {
  on_attach = ...,
  capabilities = ...,

  -- Below will be automatically included from `setup()`
  -- init_options = {
  --   documentFormatting = true,
  --   documentRangeFormatting = true,
  -- },
}))

Referencing this PR for relevance: #30

Amazing!


Fix typo

Thanks @toanalien ... Well spotted. Fixing this in this other PR https://github.com/0xPolygon/polygon-docs/pull/173


[staging] Negative values and more than three digit values can be inserted in Tilt Range filters

Steps to Reproduce

Click on Tilt Range filter
Enter negative values and more than three digits value in fields
Click on Apply button

Actual Results
negative values and more than three digits value can be inserted in fields and turn into a valid filter
Expected Results
Fields should be top to no more less than 0 and more than 180
Evidence

tilt range = tilt_max - tilt_min, so it is always positive.


Initial-revamp the styling

revamped a couple of FE code to improve styling

bigger PRs are also welcome. Apart from that looks good!


Fix a compilation error

The current code cannot compile because the wrong method is called to populate the request with OAuth headers (addOAuthHeader instead of addOAuthHeaderWithCredential)

thx


Checkbox checked fill colour

When a checkbox is checked the current fill colour is the accent colour. Material Design Lite (for one) uses the primary colour and it would be nice to have a choice. The following approach works OK although others might have alternate views on implementation.
Start with an Enum:
   public enum FillColour     {         Primary,         DarkPrimary,         LightPrimary,         Accent     }
Add an attribute to the checkbox:
       private FillColour checkedFillColour = FillColour.Accent;         [Description("Fill colour for checked box"), Category("Behavior")]         public FillColour CheckedFillColour         {             get { return checkedFillColour; }             set             {                 checkedFillColour = value;                 if (Checked) { Invalidate(); }             }         }
And then an addition to the short GetColor*** functions in the skin manager class maybe:
       public Color GetCheckBoxCheckedFillColor(FillColour checkedFillColour)         {             switch (checkedFillColour)             {                 case FillColour.Accent:                     return colourScheme.AccentColor;                 case FillColour.DarkPrimary:                     return colourScheme.DarkPrimaryColor;                 case FillColour.LightPrimary:                     return colourScheme.LightPrimaryColor;                 default:                     return colourScheme.PrimaryColor;             }         }
and finally a tweak to the relevant line in the checkbox Paint:
var brush = new SolidBrush(Color.FromArgb(colorAlpha, Enabled ? GetCheckBoxCheckedFillColor(checkedFillColour) : GetCheckBoxOffDisabledColor()));

This would be a great contribution. Feel free to open a pull request.
Considering this isn't exactly an issue I'm closing this.

How do i change the checkbox color or theme?? please reply


Sync dev to master

Syncing dev to master

Linting is failing since the template update was not merged so I'm bypassing branch protections (it only includes changes from master into dev - zenodo placeholder updates)


update log4j dependency to 2.17.0

@kaisecheng should we be concerned about the ci failure?

@jsvd ci fail for 8.0. I think we can go for 7.16 and 6.8 release


correcting Xbox One Elite 2 controller mapping

the mapping had the triggerbuttons wrong. This fixes it

Ty.


Ender dragon has no trophies

Versions

Minecraft: 1.19.2
Forge: 43.1.52
Progressive Bosses: 3.7.4
InsaneLib: 1.7.2
No interference from other MODs

Ender dragon has no loot. I have enabled loot table insertion in settings
After I modified the loot table of ender dragon, there is still no loot
In the same loot table, the death of the wither will produce loots, but the death of the ender dragon will not

The Dragon has only a chance to drop a GApple

The Dragon has only a chance to drop a GApple, so check if that's actually the case
I tried many times, but golden apple never appeared

I manually modified its loot, but it still has no loot
Ender dragon doesn't seem to have loot

What do you mean you modified manually the loot?

I found that even if the probability in the loot table of the ender dragon is changed to 100%, there is still no loot

I copied the contents of the wither json file to the ender dragon, but there is still no loot. But Wither works normally

I need the datapack

I didn't use datapack. I do this by modifying the json file in the jar file
entity.zip

You should never do that
Use datapacks, exist for a reason

I do this because I don't know how to use packets.
The key point of this issue is that the loot of the end dragon does not exist
I hope you check that's all.

I just suspect that the loot of the ender dragon was not inserted successfully
There has never been an enchanted gold apple (no interference from other MODs)

The problem does not exist. When the health value of the ender dragon is 0, the golden apple will fall immediately, and it will really die near the portal

You should never do that Use datapacks, they exist for a reason
I modify the JAR because I don't know how to use the data package

Do it via datapack, check if it works. If it doesn't sent it here so I'll check it out.

Do it via datapack, check if it works. If it doesn't sent it here so I'll check it out.

The problem does not actually exist.
I always thought that falling objects would fall with experience.
The Ender dragon will drop the loot when the HP is 0, rather than after the body emits purple light.


feat(Skeleton): text wrapping

Fixes #2518
Discussed with design ✅

It also seems like the height of text is now broken again, old left, this pr right

Stories updated, but the height is not broken - it is how tall the font is when including the height of ascender and descender of the characters. Our previous implementation relied on a ::before element, shrinking the skeleton area to 60% of the font height. When using box-decoration-break, we need to also use display: inline - this is verified with Lasse but I can do another round on it ☺

It also seems like the height of text is now broken again, old left, this pr right

Stories updated, but the height is not broken - it is how tall the font is when including the height of ascender and descender of the characters. Our previous implementation relied on a ::before element, shrinking the skeleton area to 60% of the font height. When using box-decoration-break, we need to also use display: inline - this is verified with Lasse but I can do another round on it ☺

As long as this is cleared with design, and it will be updated in figma to match this, it's fine


Fix coverage in UserService

\OCA\ScienceMesh\Service::UserService
Methods:  33.33% ( 1/ 3)   Lines:  40.00% (  2/  5)

@michielbdejong I think we need to close this issue too. It is coverage 100%.


Getting 404 in XLA JIT page

Thank you for submitting a TensorFlow documentation issue. Per our GitHub
policy, we only address code/doc bugs, performance issues, feature requests, and
build/installation issues on GitHub.
The TensorFlow docs are open source! To get involved, read the documentation
contributor guide: https://www.tensorflow.org/community/contribute/docs
URL(s) with the issue:
https://www.tensorflow.org/xla/jit
Description of issue (what needs changing):
Getting not found when opening
Clear description
For example, why should someone use this method? How is it useful?
Correct links
Is the link to the source code correct?
Parameters defined
Are all parameters defined and formatted correctly?
Returns defined
Are return values defined?
Raises listed and defined
Are the errors defined? For example,
https://www.tensorflow.org/versions/r2.0/api_docs/python/tf/feature_column/categorical_column_with_vocabulary_file#raises
Usage example
Is there a usage example?
Request visuals, if applicable
Are there currently visuals? If not, will it clarify the content?
Submit a pull request?
Are you planning to also submit a pull request to fix the issue? See the docs
contributor guide: https://www.tensorflow.org/community/contribute/docs and the
docs style guide: https://www.tensorflow.org/community/contribute/docs_style

@cheshire : FYI.
I've got a fix inflight. Thanks for reporting.

We do not recommend using XLA_* devices, as their usage can cause various issues, that's why the page was deleted. Instead, the recommended way is to use auto-clustering, documented at https://www.tensorflow.org/xla


[ENH] Begins to add Cammoun 2012 gcs fetcher

As well as functions for interfacing with FreeSurfer to label subject native data with GCS files

Codecov Report

Merging #18 into master will decrease coverage by 3.04%.
The diff coverage is 9.8%.

@@            Coverage Diff             @@
##           master      #18      +/-   ##
==========================================
- Coverage   32.61%   29.56%   -3.05%
==========================================
  Files          14       17       +3
  Lines         647      734      +87
==========================================
+ Hits          211      217       +6
- Misses        436      517      +81

Impacted Files
Coverage Δ

netneurotools/datasets/datasets.py
96.15% <ø> (+26.15%)
:arrow_up:

netneurotools/freesurfer.py
0% <0%> (ø)

netneurotools/datasets/utils.py
0% <0%> (ø)

netneurotools/datasets/__init__.py
100% <100%> (ø)
:arrow_up:

netneurotools/datasets/cammoun.py
42.1% <42.1%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c844519...91491a0. Read the comment docs.


Center button contents

Would love both of your input on this @artehe @J0nathan550 I can't tell if centered looks better or not

If icons would be on same position on left and text on center this would look good! 😄

I did try that initially but since they're inside a stack panel a center align wont work so it'd require some kind of change to the buttons

I did try that initially but since they're inside a stack panel a center align wont work so it'd require some kind of change to the buttons

You can use grid :D

Idk if my brain is just cooked tonight but using a grid set to auto, * wouldn't center align the text since the content align would be to the column it's in and I can't think of a better way. I'm sure there is one I just can't think of how to do this tonight

I've returned to this and determined with the size constraints there probably isn't a good way to have the icons be left aligned and text center aligned (size, * , size would technically work but wouldn't work for the larger texts). Do you think this should be merged or closed?

I'd say just close it for now, gonna have some tweaks to that page soon ish anyway I think if I get round to improving the install ui stuffs


Feature/simplify code

Coverage remained the same at ?% when pulling f9375cc88dc914193761dc650274c6d163dfc75c on feature/simplify-code into c0f22ebe2ea075f89424341ba7898e81abb670b4 on dev.


fix: documentation.value can be nil

Avoid throwing an error when documentation.value is nil.

@Saghen Oh, this PR wasn't purely speculative. I keep running into this:
Error executing vim.schedule lua callback: ...re/nvim/lazy/blink.cmp/lua/blink/cmp/lib/window/docs.lua:240: attempt to index local 'text' (a nil value)
stack traceback:
        ...re/nvim/lazy/blink.cmp/lua/blink/cmp/lib/window/docs.lua:240: in function 'split_lines'
        ...re/nvim/lazy/blink.cmp/lua/blink/cmp/lib/window/docs.lua:17: in function 'render_detail_and_documentation'
        ...k.cmp/lua/blink/cmp/completion/windows/documentation.lua:71: in function 'fn'
        ...al/share/nvim/lazy/blink.cmp/lua/blink/cmp/lib/async.lua:86: in function 'cb'
        ...al/share/nvim/lazy/blink.cmp/lua/blink/cmp/lib/async.lua:44: in function 'cb'
        ...al/share/nvim/lazy/blink.cmp/lua/blink/cmp/lib/async.lua:44: in function 'resolve'
        ...zy/blink.cmp/lua/blink/cmp/sources/lib/provider/init.lua:133: in function <...zy/blink.cmp/lua/blink/cmp/sources/lib/provider/init.lua:133>

The problem is coming from this configuration which I'm attempting in LazyVim:
  {
    'saghen/blink.cmp',
    optional = true,
    dependencies = { 'PaterJason/cmp-conjure', 'saghen/blink.compat' },
    opts = {
      sources = {
        compat = { 'conjure' },
        providers = { conjure = { kind = 'Conjure' } },
      },
      appearance = { kind_icons = { Conjure = '🪄' } },
    },
  },

Full disclosure, my attempted fix in this PR didn't actually work. I had to additionally check that doc was a string, rather than just that it was non-nil. I don't pretend to know what's going on here. 😂
So my "working" version looks like this:
  local doc = type(documentation) == 'table' and documentation.value
  if type(doc) == 'string' then

but of course the problem actually comes from cmp-conjure which I'm loading as a compat provider.

Oh, right, I see the bug in my original "fix." I forgot to retain documentation if it's not a table. Lua language woes.
local doc = type(documentation) == `table` and documentation.table or documentation
if doc ~= nil then

I inserted some debugging:
  local doc = type(documentation) == 'table' and documentation.value or documentation
  print('DOC\n' .. vim.inspect(doc))

and got this:
DOC
{
  kind = "plaintext"
}

so apparently documentation.value is a nested table.

That sounds like a bug in cmp-conjure since they're not respecting the types


api: Fill Transform revision

refactored the Fill matrix to hold internal data statically.
refactored for clean & neat the raster engine logic.

API Modification:

Matrix Fill::transform() const -> Matrix& Fill::transform() const

issue: https://github.com/thorvg/thorvg/issues/1372

Hold this, we might wanna spec out the Fill Transform.


Perform pre-validation checks in PyValidator.

This change is

We're currently processing your upload.  This comment will be updated when the results are available.


FormData part.body.read does not fill buffer

Bug Report
I had this bit of working code before, but the behavior seems to have changed at some point. Run this and open Chrome, paste a good amount of text and submit the form. You should get a 400 error. For some reason part.body.read does not attempt to fill the buffer even though there's plenty of space left. I expect it to return size < slice size only if there isn't more data to read. This was the behavior before.
require "http/server"

server = HTTP::Server.new do |context|
  path = context.request.path

  case context.request.method
  when "GET"
    context.response.content_type = "text/html; charset=utf-8"
    context.response.print <<-HTML
    <form method=POST enctype=multipart/form-data>
    <textarea name=data rows=50 cols=100></textarea>

    <input type=submit>
    </form>
    HTML
  when "POST"
    case path
    when "/"
      data = nil
      HTTP::FormData.parse(context.request) do |part|
        case part.name
        when "data"
          body = Bytes.new 1024
          size = part.body.read body
          puts "read", size
          if part.body.read_byte.nil?
            puts "read as much as we could!"
          elsif size < 1024 && part.body.read body
            puts "could still read more!"
          end
        end
      end
      unless data
        context.response.status_code = 400
        context.response.print "Bad Request"
      end
    end
  end
end

port = 8080

server.bind_tcp port
puts "Listening on http://<IP_ADDRESS>:#{port}"
server.listen

Per documentation, IO#read does not guarantee to fill the entire slice.
It reads as much data as is immediately available on the socket buffer. This can of course differ depending on utilization of the connection which explains why the code may fill the entire slice sometimes but sometimes not.
If you want to ensure filling the slice, you'll need to do repeated reads until there is no data left. IO#read_fully can be useful for that, but it expects there to be enough data available for a fill. You might also consider IO.copy which has no size requirements.

Thanks for clarifying. IO.copy seems to have the same caveat ("at most"). It would be nice to have a method that reads as much as possible up to a limit. It seems #11896 might address this.

IO.copy continues reading until there is no more data available (i.e. IO#read returns 0).
It seems the documentation needs some clarification.


proposal: runtime: annotation for sysAlloced types

@randall77 recently found some subtle issues related to write barriers on fields that point from runtime structures allocated from non-GCed (and hence non-scanned) memory to GCed heap memory. I manually audited all non-GCed structures to find any other such pointers, but obviously manual auditing can get out of date.
One possible way to help automate this is to add an annotation on types that are allocated from non-GCed memory. This annotation would disallow pointers to types that do not have this annotation and would disallow calling new on this type (implicit heap allocations are already disallowed in the runtime). It should probably also disallow unsafe.Pointer in annotated types (effectively requiring uintptr instead).
/cc @randall77 @ianlancetaylor @rsc @RLH

We could also change fixalloc to take a _type* rather than a size, and then perhaps we could somehow ensure that the type had the new annotation.

This doesn't need the formality of the proposal process. Anything that works and that you are willing to implement is fine.


Ignore invalid !help arguments at the end if beginning matches valid subcommand

Let's say you see an abbreviated command like
!i a l <message>
that you're not familiar with and you want to figure out what it does. So, you go:
!help i a l
Currently, the response will be:

This is because despite the fact that the first two characters correspond to a valid subcommand, the final term of the command line, l, is an argument and not a subcommand. Maybe you will understand this and you correct your help command and go
!help i a
which will display the description of !infraction append, including what l stands for and  what it does.
At best, this means finding out what the command line does is a two-step process for no good reason. At worst, you might think you misspelled the original command line and will waste time trying to figure out what you did wrong.
This problem can be solved if we simply ignore the final arguments to !help as long as the first matches some subcommand. So, if you go
!help i a l
the first two characters will match infraction append, a valid subcommand, and will display the help page for this command, ignoring the fact that the final character does not match a command. You can then read the help page to find out that l actually is an abbreviation for the last flag.

@evgriff and I would like to tackle this.  Can someone assign us?


Angular 1.4.1 compatibility with $attributes service

Hi Brian,
thanks for all the busy work you put into form-for the last few weeks. I just migrated to Angular 1.4.1 and noticed that in directives, the $attributes service now actually has all the attributes as properties with a value of undefined. This makes the following lines break:
$scope.onFocus = function () {
    if ($attributes.hasOwnProperty('focused')) {
        $scope.focused();
    }
};

so the output of the generated form-for code would have to check not only with "hasOwnProperty", but also for a truthy value or the existance of a function before calling it:
$scope.onFocus = function () {
    if (typeof $attributes['focused'] === 'function') {
        $scope.focused();
    }
};

No idea how to accomplish this in typescript. but this is really the only issue i found so far with compatibility with angular 1.4.1

Hi @hutzelknecht,
You're welcome. And thank you. :)
I'll try to take a look at this this evening. Off the top of my head, I don't know what may have changed between versions that would have caused this. (What version did you upgrade from?)

I switched from 1.3.15 to 1.4.1. There was no mention of this change on the migration guide. Haven't figured out why it happens so far.

This fix is out in the 4.0.3 release.


Document exact XML functionality

Especially as Badgerfish isn't a true standard, complete documentation of this will help users a lot

Some details how it works currently:
If a node's children are all text, then there is one $ key with the complete text.
If a node's children contain any CDATA, optionally with text, there with be $1, #2, $3 etc (note: numbers wholly determine order and are not separate between the two) keys, and also a $ key with the whole text. Note: this behavior is sufficiently desirable it is not controlled by a mediatype attribute.
If a node's children are mixed content of text/cdata and elements, they will be represented by $1, #2, $3, $4 etc, where elements use the $ prefix too, and are a JSON object with a single key of their name and their representation as the value.
If a node's children are just elements, and no two elements with the same name are separated by any elements with different names, then the output is exactly as we do currently, elementname: [elementone, elementtwo]
If a node's children are just elements but two elements with the same name are separated by other elements, then behavior is determined by the preserveOrder attribute on the mediatype. If preserveOrder is true (the default), then they are represented the same as if the contents were mixed content. If false, they are represented as if they were not out of order.

We may want to update the whole text key prefix thing with something more descriptive, since it is also used for elements in mixed content scenarios.
Alternatively, we may want to introduce another prefix with a default special character for elements (can't be !, which is reserved for comments, which we might want to support but not include when parsing by default).


🐛 [firebase_messaging] Adding latest version to project blocks app badge on macOS

Bug report
Describe the bug
If I add the following to pubspec.yaml and launch a Flutter app on macOS, my app badge notification count no longer shows. I am updating the badge counter using a separate plugin, nothing to do with firebase messaging. This works if I do not include firebase messaging in my app.
dependencies:
  firebase_messaging: 9.0.0

Removing the dependency again does not fix this. Even stopping the app, running flutter clean, deleting the Pods folder and Podfile.lock all do not help. I have to remove the entire macOS folder in my project and recreate it for the badge to show again.
Steps to reproduce
Steps to reproduce the behavior:

flutter create --platforms=macos
Add firebase_messaging: 9.0.0 to pubspec.yaml
Try to update the app badge counter. You could for example use this package to do so on macOS: https://pub.dev/packages/flutter_app_icon_badge
Adding firebase_messaging 9.0.0 requires an update of the Podfile platform :osx version to 10.12 from the default 10.11 (could this be an issue?)

Expected behavior
The firebase messaging package does not interfere with the app badge.

Additional context
Add any other context about the problem here.

Flutter doctor
Run flutter doctor and paste the output below:
Click To Expand
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 2.0.1, on macOS 11.2.1 20D74 darwin-x64, locale en-GB)
[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
[✓] Xcode - develop for iOS and macOS
[✗] Chrome - develop for the web (Cannot find Chrome executable at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome)
    ! Cannot find Chrome. Try setting CHROME_EXECUTABLE to a Chrome executable.
[✓] Android Studio (version 4.0)
[✓] IntelliJ IDEA Community Edition (version 2020.2.3)
[✓] VS Code (version 1.54.2)
[✓] Connected device (1 available)

! Doctor found issues in 1 category.

Flutter dependencies
Run flutter pub deps -- --style=compact and paste the output below:
Click To Expand
Dart SDK 2.12.0
Flutter SDK 2.0.1
gif_test 1.0.0+1

dependencies:
- app_badge 1.0.0 [flutter app_badge_platform_interface app_badge_linux app_badge_macos app_badge_windows]
- firebase_messaging 9.0.0 [firebase_core firebase_core_platform_interface firebase_messaging_platform_interface firebase_messaging_web flutter meta]
- flutter 0.0.0 [characters collection meta typed_data vector_math sky_engine]

dev dependencies:
- cupertino_icons 1.0.2
- flutter_test 0.0.0 [flutter test_api path fake_async clock stack_trace vector_math async boolean_selector characters charcode collection matcher meta source_span stream_channel string_scanner term_glyph typed_data]

transitive dependencies:
- app_badge_linux 0.0.1+4 [flutter]
- app_badge_macos 1.0.0 [flutter]
- app_badge_platform_interface 1.0.0 [flutter meta plugin_platform_interface]
- app_badge_windows 1.0.0 [flutter]
- async 2.5.0 [collection]
- boolean_selector 2.1.0 [source_span string_scanner]
- characters 1.1.0
- charcode 1.2.0
- clock 1.1.0
- collection 1.15.0
- fake_async 1.2.0 [clock collection]
- firebase_core 1.0.1 [firebase_core_platform_interface firebase_core_web flutter meta]
- firebase_core_platform_interface 4.0.0 [flutter meta plugin_platform_interface]
- firebase_core_web 1.0.1 [firebase_core_platform_interface flutter flutter_web_plugins js meta]
- firebase_messaging_platform_interface 2.0.0 [firebase_core flutter meta plugin_platform_interface]
- firebase_messaging_web 1.0.1 [firebase_core firebase_core_web firebase_messaging_platform_interface flutter flutter_web_plugins js meta]
- flutter_web_plugins 0.0.0 [flutter js characters collection meta typed_data vector_math]
- js 0.6.3
- matcher 0.12.10 [stack_trace]
- meta 1.3.0
- path 1.8.0
- plugin_platform_interface 2.0.0 [meta]
- sky_engine 0.0.99
- source_span 1.8.0 [charcode collection path term_glyph]
- stack_trace 1.10.0 [path]
- stream_channel 2.1.0 [async]
- string_scanner 1.1.0 [charcode source_span]
- term_glyph 1.2.0
- test_api 0.2.19 [async boolean_selector collection meta path source_span stack_trace stream_channel string_scanner term_glyph matcher]
- typed_data 1.3.0 [collection]
- vector_math 2.1.0

Hi @seanmc86
Could you confirm if you just try to use the badging package on its own with 10.12 if it works? We should have no code to even do anything with badging.
Thank you

Apologies, this issue was tangential to updating to the latest version and was not caused by it, but rather a change in one of the recent macOS updates.


Scrim with coaches bomb glitch

It seems if you have a coach the bomb can glitch, so 1 player has a bomb, but because the coach might have spawned with the bomb or smth like it, it also looks like there is a bomb in spawn, its very problematic

Also have had this issue for closer to 2 months when we have our coach in the coaching slot, within this week we aren't even able to scrim anybody, our server just crashes after starting the scrim.

Hey!
Would it be possible for you to share a clip or screenshot of the same?
The coach seems to be very problematic 😅

Hey @xGuysOG @nrbcs,
We have made some improvements in the coaching system (0.8.2 update) and these glitches should also be resolved with it.
Requesting you to take a look at it!


v3 breaks my app

I'm not sure what's happening. I (ab)use reselect to calculate derived values from component props and state, by using my React element as state, not simply the redux store.
Example:
class Table extends React.Component {
    	getColumns = createSelector(
		[
			() => this.props.columns,
			() => this.state.show,
		],
		(origCols = {}, show) => {
			// calculate the column object to give to the table component
		}
	)

	render() {
		const allCols = this.getColumns()
		// …
	}
}

I am passing extra data (via deep mutation) through the columns object to the Table component, and to make sure the columns are recalculated, I copy the column object into a new one. That works fine with v2.5.4, but in v3 the selector doesn't update.
Is there a deeper comparison of the inputselectors being made in v3? The columns object changes but its direct descendants don't.
I suppose I should just man up and rewrite that code so the mutations are an extra input, but it would be good if this is noted as a possibly breaking change.

Oh, sorry! I wasn't aware of any behaviour change, our tests didn't pick it up. Would it be possible to knock up a quick test case which demonstrates the difference between the versions?

👋
This broke right here: https://github.com/reactjs/reselect/pull/194/files#diff-1fdf421c05c1140f6d71444ea2b27638R69
I assumed that it would be ok since reselect was built for redux and if you're mutating the state in the redux then you won't even get to the point where you're calling selectors to get values out of the state since nothing is going to know it needs to update.
However you're calling reselect outside of redux and just in react which does support mutation. If mutation is something that reselect should support then it should definitely be something that is explicitly enabled. I do feel that this does go against the spirit of the library itself and the library it's built for.
But yes, I think that at the very least we should update the CHANGELOG to show this has changed from v2-v3.

I see three easy options:

keep the old behavior on createSelector and add a createPureSelector
break the old behavior and add createImpureSelector
stop supporting the old behavior

One thing to note though, IIRC when redux calls its subscribers, the store
object has always changed, so this optimization won't help.
On Sun, Mar 26, 2017, 6:35 PM John Haley<EMAIL_ADDRESS>wrote:

👋
This broke right here:
https://github.com/reactjs/reselect/pull/194/files#diff-1fdf421c05c1140f6d71444ea2b27638R69
I assumed that it would be ok since reselect was built for redux and if
you're mutating the state in the redux then you won't even get to the point
where you're calling selectors to get values out of the state since nothing
is going to know it needs to update.
However you're calling reselect outside of redux and just in react which
does support mutation. If mutation is something that reselect should
support then it should definitely be something that is explicitly enabled.
I do feel that this does go against the spirit of the library itself and
the library it's built for.
But yes, I think that at the very least we should update the CHANGELOG to
show this has changed from v2-v3.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/reactjs/reselect/issues/231#issuecomment-289295575,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AADWlhDbiIV0kSmN7lL_JmXHA-gSBSWiks5rppPSgaJpZM4MpB_T
.

Not exactly true. combineReducers will return the same root state object if it thinks all of the slice reducers returned their previous slices of state untouched.

The biggest benefit is if you have a selector used as a root selector that is called multiple times from other selectors per state update. Instead of determining that a referentially equal state has a change, if you use redux as it's designed and consider the state immutable you only have to run that calculation once for any given state update.

I guess that line is the cause of #233 too.

I think @johnhaley81 is right in that Reselect was intended to be used with immutable data. The 'impure' use case was accidentally supported. I am trying to see if there is a nice way to have the optimization as the default, but allow the old behavior too. Suggestions welcome.

By nice, I mean preferably with no breaking changes and the most minimal introduction of top level API possible (I'm not keen on trying to write the docs for createImpureSelector!)

Until we reach a conclusion on what we want to do here, I've added a breaking changes section to the release notes.

Well, no breaking changes means making the initial state comparison
optional, and adding a third argument to createSelector for backwards
compatible API createSelector(inputSelectors, compute, isPure).
On Mon, Mar 27, 2017 at 5:34 PM Lee Bannard<EMAIL_ADDRESS>wrote:

By nice, I mean preferably with no breaking changes and the most minimal
introduction of top level API possible (I'm not keen on trying to write the
docs for createImpureSelector!)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/reactjs/reselect/issues/231#issuecomment-289420860,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AADWllimaWV8tUuTVMNjJSvdBQwdv96Kks5rp5ZsgaJpZM4MpB_T
.

The problem with allowing the grey case of mutable data is that it could be confusing for the user since reselect would be the exception where everything else that's built in redux land assumes immutability.
And that exception would also not be universal in reselect. The root state object is mutable but all subvalues are not. I guess the main difference is that you could override the underlying equality function but not the equality function for the top level state === state. That could be a start if this is to be implemented.
However, by default everything assumes immutability and that's why it can do things so fast. By falsifying that assumption at any level you then must full verify things haven't changed for each call which can really slow down root level selectors that are called multiple times for any given state change.
Reading over the above example however, I feel like using a selector inside the render would be sub-optimal.
Think about it this way, when you're inside of the render, if you're doing potentially expensive calculations then you should either short circuit that inside of that component's shouldComponentUpdate or pass that slice of your component's prop and state (i.e. this.props.columns and this.state.show) down to a subcomponent that would then do the prop equality check inside of shouldComponentUpdate. And then React could optimize that DOM update away.
Using the internal lifecycle methods of React that are built for what you're trying to do seems a lot more sane to me.
With all of that being said, I'm really sorry my PR broke your code :(

Well, no breaking changes means making the initial state comparison
optional, and adding a third argument to createSelector for backwards
compatible API createSelector(inputSelectors, compute, isPure).

v3.0.0 has been released now though, so I'm thinking a breaking change would be to return to the v2.5.4 behavior if we are following semver.

So, any thoughts on this in the meantime?
For me, the solution would be to only check the state for equality if the state is not undefined. Then it will run my bound input selectors and everything will work as it should. This is entirely backwards compatible.
More generically, I think adding an option parameter to createSelector, or making a different createNonPureSelector would provide an easy upgrade path for people that are relying on the unintended v2 behavior.

@wmertens if you're looking for a solution in the meantime, this should work. Obviously doesn't work for use in @connect(), but is a convenient way to avoid the === check for your use case.
function createClassConnector(...args) {
  const selector = createSelector(...args);
  const wrapper = () => selector({});
  return Object.assign(wrapper, selector);
}

I also got bit by this.
Solved it with the following workaround that should be fine unless your input functions are using the argument count or otherwise can't handle an extra argument
export const createNonPureSelector = (...args) => {
  const selector = createSelector(...args);
  return (...args) => selector(...args, {});
};

I ran into the same limitation as well.
In my case, I was trying to use reselect as an incremental migration path for non-redux-based code: to initially calculate derived values from mutable state, using the same API you would eventually use with immutable state.


Unable to start container on Fedora 22

I'm unable to start a container using runv and qemu on my Fedora 22 system.
The busybox container rootfs along with config.json and runtime.json is in the current dir.
The qemu instance does get created. Any suggestions on debugging the issue ?

# ./runv --kernel ../hyperstart/build/kernel --initrd ../hyperstart/build/hyper-initrd.img start start
tag=qck14w9g
Failed to reset winsize
copy from stdin to remote 0, err write unix @->/run/opencontainer/containers/runv/runv.sock: write: broken pipe
runvRequest failed: dial unix /run/opencontainer/containers/runv/runv.sock: connect: connection refused
start container failed: dial unix /run/opencontainer/containers/runv/runv.sock: connect: connection refused

# ps aux | grep qemu
root     21259 96.0  1.1<PHONE_NUMBER>4 ?        Sl   11:41   0:03 qemu-system-x86_64 -machine pc-i440fx-2.0,accel=kvm,usb=off -global kvm-pit.lost_tick_policy=discard -cpu host -kernel /home/pradipta/temp/hyperstart/build/kernel -initrd /home/pradipta/temp/hyperstart/build/hyper-initrd.img -append "console=ttyS0 panic=1 no_timer_check" -realtime mlock=off -no-user-config -nodefaults -no-hpet -rtc base=utc,driftfix=slew -no-reboot -display none -boot strict=on -m 128 -smp 1 -qmp unix:/var/run/hyper/vm-MjoAidCDJo/qmp.sock,server,nowait -serial unix:/var/run/hyper/vm-MjoAidCDJo/console.sock,server,nowait -device virtio-serial-pci,id=virtio-serial0,bus=pci.0,addr=0x2 -device virtio-scsi-pci,id=scsi0,bus=pci.0,addr=0x3 -chardev socket,id=charch0,path=/var/run/hyper/vm-MjoAidCDJo/hyper.sock,server,nowait -device virtserialport,bus=virtio-serial0.0,nr=1,chardev=charch0,id=channel0,name=sh.hyper.channel.0 -chardev socket,id=charch1,path=/var/run/hyper/vm-MjoAidCDJo/tty.sock,server,nowait -device virtserialport,bus=virtio-serial0.0,nr=2,chardev=charch1,id=channel1,name=sh.hyper.channel.1 -fsdev local,id=virtio9p,path=/var/run/hyper/vm-MjoAidCDJo/share_dir,security_model=none -device virtio-9p-pci,fsdev=virtio9p,mount_tag=share_dir

thanks for report, i will look into it.

panic on https://github.com/hyperhq/runv/blob/master/hypervisor/vm_states.go#L289
since userPod.Containers is nil

Any suggestions for debugging this issue ?

@bpradipt Sorry for late response, you can run runv with the options runv start -v=3 and found the log in /var/log/hyper/runv-ns-daemon.xxx, since runv may panic, the glog has no chance to flush out logs, you may need to change the glog package in Godep, call Flush() in func (l *loggingT) output(...).
For this problem, please try this patch.
diff --git a/hypervisor/vm_states.go b/hypervisor/vm_states.go
index 3f345c3..9715cdb 100644
--- a/hypervisor/vm_states.go
+++ b/hypervisor/vm_states.go
@@ -107,6 +107,7 @@ func (ctx *VmContext) prepareContainer(cmd *NewContainerCommand) *VmContainer {
ctx.ptys.attachId++
}

  ctx.userSpec.Containers = append(ctx.userSpec.Containers, *cmd.container)
  ctx.vmSpec.Containers = append(ctx.vmSpec.Containers, *vmContainer)

@gao-feng I verified your patch and it works fine. Thanks a lot!!

@bpradipt You are welcome, thanks for the report


Issue 575

Hopefully fixes https://github.com/Azure/azure-docs-sdk-dotnet/issues/575

:warning: Validation status: warnings

File
Status
Preview URL
Details

docs-ref-conceptual/includes/create-sp.md
:warning:Warning
View
Details

api/overview/azure/cosmosdb.md
:white_check_mark:Succeeded
View

docfx.json
:white_check_mark:Succeeded

msdn.4.5.2.zip
:white_check_mark:Succeeded

docs-ref-conceptual/includes/create-sp.md

Line 22: [Warning] The content part of NOTE/WARNING/CAUTION/IMPORTANT/NEXT syntax is suggested to start in a new line.
Line 22: [Warning] The content part of NOTE/WARNING/CAUTION/IMPORTANT/NEXT syntax is suggested to start in a new line.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


fuse-agent needs to handle inputDatasetType & outputResultsType as arrays

This impacts the service_info.json in the fuse-tools (pca & cellfie)

this is done


update doc site url for all sub-modules

review all sub-modules and replace out-of-dated url https://zebrunner.github.io/zebrunner by https://zebrunner.github.io/community-edition

done. after merging to master and rebuilding docs we have to verify all links inside the documentations


Update to Zombie 3.x

Seems reasonable to me. We should probably bump the major version and republish after the merge. Thoughts?

Sounds fine.