Backport "HBASE-23561 Look up of Region in Master by encoded region name is O(n)" and addendum to branch-2

Depends on backport of HBASE-23102 / #5048 ; will rebase once that one is merged.
FYI @mwkang

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 45s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 21s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m  6s
branch-2 passed

+1 :green_heart:
compile
3m 14s
branch-2 passed

+1 :green_heart:
checkstyle
0m 51s
branch-2 passed

+1 :green_heart:
spotless
0m 43s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
2m 15s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 32s
the patch passed

+1 :green_heart:
compile
3m 12s
the patch passed

+1 :green_heart:
javac
3m 12s
the patch passed

+1 :green_heart:
checkstyle
0m  8s
The patch passed checkstyle in hbase-procedure

+1 :green_heart:
checkstyle
0m 34s
hbase-server: The patch generated 0 new + 5 unchanged - 1 fixed = 5 total (was 6)

+1 :green_heart:
checkstyle
0m  7s
The patch passed checkstyle in hbase-rsgroup

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
19m 36s
Patch does not cause any errors with Hadoop 2.10.2 or 3.2.4 3.3.4.

-1 :x:
spotless
0m 42s
patch has 1 errors when running spotless:check, run spotless:apply to fix.

-1 :x:
spotbugs
1m 39s
hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

_ Other Tests _

+1 :green_heart:
asflicense
0m 23s
The patch does not generate ASF License warnings.

45m 22s

Reason
Tests

FindBugs
module:hbase-server

Return value of putIfAbsent is ignored, but node is reused in org.apache.hadoop.hbase.master.assignment.RegionStates.createRegionStateNode(RegionInfo)  At RegionStates.java:ignored, but node is reused in org.apache.hadoop.hbase.master.assignment.RegionStates.createRegionStateNode(RegionInfo)  At RegionStates.java:[line 129]

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5049/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5049

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux 676301e42139 5.4.0-1092-aws #100~18.04.2-Ubuntu SMP Tue Nov 29 08:39:52 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 3f25f33bc3

Default Java
Eclipse Adoptium-11.0.17+8

spotless
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5049/1/artifact/yetus-general-check/output/patch-spotless.txt

spotbugs
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5049/1/artifact/yetus-general-check/output/new-spotbugs-hbase-server.html

Max. process+thread count
86 (vs. ulimit of 30000)

modules
C: hbase-procedure hbase-server hbase-rsgroup U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5049/1/console

versions
git=2.34.1 maven=3.8.6 spotbugs=4.7.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  2s
Docker mode activated.

-0 :warning:
yetus
0m  5s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 55s
branch-2 passed

+1 :green_heart:
compile
1m  9s
branch-2 passed

+1 :green_heart:
shadedjars
4m 11s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 52s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 42s
the patch passed

+1 :green_heart:
compile
1m  8s
the patch passed

+1 :green_heart:
javac
1m  8s
the patch passed

+1 :green_heart:
shadedjars
4m 10s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 46s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 13s
hbase-procedure in the patch passed.

-1 :x:
unit
205m 58s
hbase-server in the patch failed.

+1 :green_heart:
unit
4m 16s
hbase-rsgroup in the patch passed.

235m 28s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5049/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5049

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux de772e63eef1 5.4.0-135-generic #152-Ubuntu SMP Wed Nov 23 20:19:22 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 3f25f33bc3

Default Java
Temurin-1.8.0_352-b08

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5049/1/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5049/1/testReport/

Max. process+thread count
2513 (vs. ulimit of 30000)

modules
C: hbase-procedure hbase-server hbase-rsgroup U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5049/1/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 39s
Docker mode activated.

-0 :warning:
yetus
0m  5s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
5m 45s
branch-2 passed

+1 :green_heart:
compile
1m 41s
branch-2 passed

+1 :green_heart:
shadedjars
5m 35s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 21s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 17s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m  0s
the patch passed

+1 :green_heart:
compile
1m 30s
the patch passed

+1 :green_heart:
javac
1m 30s
the patch passed

+1 :green_heart:
shadedjars
6m 29s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 33s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 46s
hbase-procedure in the patch passed.

-1 :x:
unit
236m 38s
hbase-server in the patch failed.

+1 :green_heart:
unit
5m 25s
hbase-rsgroup in the patch passed.

279m 25s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5049/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5049

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux efa52f206c25 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 3f25f33bc3

Default Java
Eclipse Adoptium-11.0.17+8

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5049/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5049/1/testReport/

Max. process+thread count
2389 (vs. ulimit of 30000)

modules
C: hbase-procedure hbase-server hbase-rsgroup U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5049/1/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 39s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
3m 45s
branch-2 passed

+1 :green_heart:
compile
0m 41s
branch-2 passed

+1 :green_heart:
shadedjars
4m 56s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 25s
branch-2 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 53s
the patch passed

+1 :green_heart:
compile
0m 47s
the patch passed

+1 :green_heart:
javac
0m 47s
the patch passed

+1 :green_heart:
shadedjars
5m  9s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 25s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
216m 13s
hbase-server in the patch passed.

240m 53s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5049/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5049

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 2b9da235e0ba 5.4.0-1094-aws #102~18.04.1-Ubuntu SMP Tue Jan 10 21:07:03 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 3b6d8c3394

Default Java
Temurin-1.8.0_352-b08

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5049/2/testReport/

Max. process+thread count
2341 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5049/2/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  5s
Docker mode activated.

-0 :warning:
yetus
0m  5s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
3m 40s
branch-2 passed

+1 :green_heart:
compile
0m 46s
branch-2 passed

+1 :green_heart:
shadedjars
4m 37s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 28s
branch-2 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 24s
the patch passed

+1 :green_heart:
compile
0m 47s
the patch passed

+1 :green_heart:
javac
0m 47s
the patch passed

+1 :green_heart:
shadedjars
4m 36s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 26s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
211m 39s
hbase-server in the patch passed.

236m 41s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5049/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5049

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux d0b2dab2d600 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 3b6d8c3394

Default Java
Eclipse Adoptium-11.0.17+8

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5049/2/testReport/

Max. process+thread count
2339 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5049/2/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Existing spot-bugs issue as also present on master, fixed in HBASE-23983. Will backport that too.


LZW compression in TIFFimageIO.

Description

Based on a quick online search, it appears that the patent on LZW has expired (but don't quote me on the this). So lzw patent is perhaps not an issue for tiff images anymore. However, if using it is still not possible, what is the point of exposing LZW compression? Why not just remove the option from TiffImageIO?
Expected coding style

Remove LZW comrpression option from TiffImageIO.

@HaaPut since the patent has expired, we could enabled it. Would you like to create a patch?


feat: add Array.__awkward_function__ method

Codecov Report

Merging #295 (c7255ed) into main (65e5502) will decrease coverage by 0.34%.
The diff coverage is 10.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@            Coverage Diff             @@
##             main     #295      +/-   ##
==========================================
- Coverage   92.49%   92.16%   -0.34%
==========================================
  Files          21       21
  Lines        2466     2476      +10
==========================================
+ Hits         2281     2282       +1
- Misses        185      194       +9

Impacted Files
Coverage Δ

src/dask_awkward/lib/core.py
91.56% <10.00%> (-1.00%)
:arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Config Import Screen working indefinitely

Describe the bug
When we import a config a pop up shows (Global) Global Config Update Succeeded whereas the screen shows Working indefinitely and does not go back to Configuration page or Home page.
To Reproduce
Steps to reproduce the behavior:

Go to Configuration
Click on Global Configuration under General Configuration
Scroll down to Import Global Configuaration
Paste the backed up json of global config
Click on Import button
Click on OK button on Attention pop up
Click on OK button on Attention pop up again

Expected behavior
A pop up showing Success / Failure in loading the global config and go back to Configuration page or home page.
Screenshots

Installation Method
As per official document here.

Hi @ArlanNugara,
Thank you for feedback! We will research this issue and include a fix in the next release.

Bryan

Hi @ArlanNugara,
I have continued to research this and remembered we had a fix for this in the last update. Can you confirm what version of the tool you are running? If you go to the Admin page, it will show the current version at the top.
Thank you!
-Bryan

Closed due to inactivity

@BryanSoltis  Sorry for late response. The version we are using is 3.1.0 and the issue is still persisting. Do you think upgrading to 3.1.1 will fix the issue ?

@BryanSoltis The issue persists in 3.1.0.

When v3.1.0 was released I had updated the Global Configuration to handle this, so I'm a little curious as to what is causing it. I may have to see your configuration and step through the code to test it. I will cr4eate a private repo and invite you shortly for collaborati0on.
-Bryan

Closed due to inavtivity.

@BryanSoltis  Sorry, we can not share our configurations with you. However, the issue persists with / without specific configuration. And we are getting used to the issue..


bme280 reading extreme values

Describe the Bug
Every once in a while, the measurements from the bme280 read extreme values. Some fields read near the max for a double and another reads closer to 0. I don't have an example of the data. The function do not appear to trigger any of the built in library errors.
To Reproduce
Steps to reproduce the behavior:

Flash the device with pio run -e example_bme280
Observe measurement discrepancies.

Expected Behavior
Ignoring other environmental changes the temperature/pressure/humidity should remain relatively stable.
Screenshots
N/A
Environment
Linux spruce 6.8.2-arch2-1 #1 SMP PREEMPT_DYNAMIC Thu, 28 Mar 2024 17:06:35 +0000 x86_64 GNU/Linux
PlatformIO Core, version 6.1.7
Used ST-Link V3 MINIE
SPS v2.2.0
Arduino bme280
Additional Context
Need to get example of extreme measurements

Issue is due to the measurement mode of the bme280. Currently have it configured to operate in normal mode where the device is continuously performing measurements and the read command reads directly from the devices register. When it reads 0 values, the register query is happening during a conversion, so the status code returns something other than BME280_OK.
Normal

Partial error when data being copied

Error (no data returned)


Fixed default mapping when lambda function called

Motivation and context
make_default_mapping didn't work well for lambda functions with attributes
Related #8213
How has this been tested?

Checklist

[x] I submit my changes into the develop branch
[x] I have created a changelog fragment
[ ] I have updated the documentation accordingly
[ ] I have added tests to cover my changes
[ ] I have linked related issues (see GitHub docs)
[ ] I have increased versions of npm packages if it is necessary
(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)

License

[x] I submit my code changes under the same MIT License that covers the project.
Feel free to contact the maintainers if that's a concern.

Summary by CodeRabbit

New Features

Improved mapping functionality by generating default mappings based on task labels instead of model labels.

Bug Fixes

Simplified the validation process for attribute mappings, ensuring consistent behavior when creating mappings.

Codecov Report
Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 83.32%. Comparing base (e0da3a2) to head (4a26e32).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8250      +/-   ##
===========================================
- Coverage    83.36%   83.32%   -0.05%
===========================================
  Files          388      388
  Lines        41395    41395
  Branches      3856     3856
===========================================
- Hits         34508    34491      -17
- Misses        6887     6904      +17

Components
Coverage Δ

cvat-ui
79.64% <ø> (-0.09%)
:arrow_down:

cvat-server
86.60% <0.00%> (ø)


Updates to improve pkgdown website

I improved some of the function descriptions, added you (Jasmine Lai) as a contributor, changed the recommended installation method and attempted to make some changes to how the functions appear on the pkgdown site. I (think) that I added subheadings under the references tab to categorize the functions.

merging these in, though Travis is still failing


fix: allow dependency injection in factory

In the current state external provider cannot be injected into useFactory in module init.
The imports option was able to be set in IFtpConnectionOptions but wasn't really handled.

@AbdessalemLetaief could you publish a patch with this change to the npm?


Switch default branch to 2.0

Now we successfully released Jolokia 2.0 last year, it should make sense to make 2.0 branch as default and keep the current main as a maintenance branch. Maybe it's better to rename it from main to 1.x.
May I apply the changes to branches?  @grgrzybek @rhuss @apupier

Ah ok, 2.0 is already merged to main. No worries!


Iris Flowers Classification

Describe the project you want to add with the tech stack
Predict the different species of flowers on the length of there petals and sepals only Jupyter notebook code.
Expected behavior

The iris dataset contains three classes of flowers, Versicolor, Setosa, Virginica, and each class contains 4 features, ‘Sepal length’, ‘Sepal width’, ‘Petal length’, ‘Petal width’. The aim of the iris flower classification is to predict flowers based on their specific features.

/assign

I would like to work on this issue, can you assign it to me :)

Assign that issue to me i have worked so many algorithms in Machine Learning


Allow filtering of tree API children by extinct flag

demand by API users, see https://discourse.gbif.org/t/extinction-status-and-the-species-api-routes/2312/2

done

thanks! is that change on the /species/{id}/children/  route? And what parameter? isExtinct ?

No, there is actually a simpler tree API that returns smaller objects, may include extra infos about the source in case of aggregated datasets like the CoL and is designed to drive tree navigations.
To get the root of the tree:
http://api.catalogue.life/dataset/3/tree?extinct=true
To list children:
http://api.catalogue.life/dataset/3/tree/0/children?extinct=true
http://api.catalogue.life/dataset/3/tree/061950e4-9782-4d1a-9c87-dcf375788e6b/children?extinct=true

you can also get the parents in case you need to open a tree from some known ID:
http://api.catalogue.life/dataset/3/tree/5a45f4b7-3ab5-41f4-bbaf-81be3a0edd35

http://api.catalogue.life/dataset/3/tree/80774660-983d-4b20-aadc-04d068e3a1d2/children
http://api.catalogue.life/dataset/3/tree/80774660-983d-4b20-aadc-04d068e3a1d2/children?extinct=false

thanks!


Improving implementations for Verlet Integration

1. Printing inside the individual functions vs. printing in main
Some of the code examples print the results directly inside the verlet function. Others have the functions return the results and print them in main.
With #243, we're already steering in the direction of printing in main instead of the individual functions. To keep everything in line, we should do this in every example.
2. Using the velocity variable in Stormer-Verlet
Currently, the chapter about Verlet Integration includes code examples for the Stormer-Verlet and Velocity-Verlet methods. Both of them have a velocity term, but it's completely unused in Stormer-Verlet. The variable is assigned a value which is never actually used. In #256, @leios and I already agreed that it would be an improvement to also print the velocity. I want to leave this up for discussion before we decide on it.
I think that if we print the velocity for Stormer-Verlet, we should also print it for Velocity-Verlet.
Progress
If we were to change these 2 things, these are the languages examples that would need adjustment:

[x] C (#298)
[x] C++ (both)
[x] Java (#290)
[x] JavaScript (print velocity)
[x] Julia (both)
[x] Python (#256)
[x] Rust (#297)

Feel free to post your opinion on the second topic and to submit PRs for the listed languages. I will keep this list updated as the code comes in.

For point 2, it should be more clear which form of the velocity equation is being calculated, the one at t or the one at t + dt.

According to both the book and Wikipedia, there is the form where the velocity is calculated one step behind (t) with error squared in t, and the form where velocity is calculated at the same step (t + dt) with error linear in t. Because there are multiple choices for defining the velocity, it should be stated which one is used in the code. I suppose it's clear from "Here's what it looks like in code", but the divergence in how this is presented in the two articles was temporarily confusing.

It appears that this has been resolved already!


Capitalize formatter does not capitalze first word if there is leading whitespace in selection.

In dictation mode, I try to use the following set of commands:
the quick brown fox jumped over the lazy dog
select that
format selection capitalize

in most cases dictation mode inserts a leading whitespace in front of the quick brown fox jumped over the lazy dog, and when I try to correct that with format selection capitalize, the leading whitespace prevents the first word from being capitalized.

Retest after #696

Re #696: as described here it wouldn't be fixed because this is a shortcoming of the capitalize formatter (which I think is worth fixing separately). However,  my PR does add a new "cap that" command which correctly handles this and is easier to use than the command sequence described here.


He initialization

The default initialization for linear and convolutional modules seems to be Glorot initialization, but for the commonly used ReLU activation function He initialization is superior, while only requiring a quick change to the stddev definition, should we implement better defaults?
I know that there are many initialization schemes, I only suggest it as it would't be computationally expensive and would also be only a minor code change.

Hey @joaogui1 as with deepmind/dm-haiku#6 this is available via the variance scaling initializer. We've included the various ways of driving this in the docs https://sonnet.readthedocs.io/en/latest/api.html#variancescaling.


Add more documentation and control taxid input more thoroughly

The input using a list of taxa can be multiple conditions, in which the taxa are non unique between the conditions. Therefore, multiple weights may be given to one taxid. The processing of those files works correctly, but the input check is not robust and was not clearly defined yet. This PR adds a few checks to be sure that the corresponding script throughs an error if abundances are given, but the file format was not correctly defined.
PR checklist

[x] This comment contains a description of changes (with reason).
[ ] If you've fixed a bug or added code that should be tested, add tests!
[ ] If you've added a new tool - have you followed the pipeline conventions in the contribution docs- [ ] If necessary, also make a PR on the nf-core/metapep branch on the nf-core/test-datasets repository.
[x] Make sure your code lints (nf-core lint).
[ ] Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
[ ] Usage Documentation in docs/usage.md is updated.
[ ] Output Documentation in docs/output.md is updated.
[x] CHANGELOG.md is updated.
[ ] README.md is updated (including new tool citations and authors/contributors).

PR waits for PR of test-data repo, as the taxid tests will fail until then.


Standalone program fails with ModuleNotFoundError: 'sklearn.neighbors._quad_tree'

Hello!
I am attempting to compile a fairly substantial program using nuitka. This process seems to complete successfully, with no major warnings and very quickly (usually within 20 mins). Upon completing compilation and running the executable in the .dist/ folder using a git bash terminal, I receive the following error:
$ ./nnse.exe --help
Traceback (most recent call last):
  File "D:\life\uwo\ece\phd\code\nuitka\standalone\attempt_3\nnse.dist\nnse.py", line 18, in <module>
  File "D:\life\uwo\ece\phd\code\nuitka\standalone\attempt_3\nnse.dist\graphical\interface.py", line 26, in <module graphical.interface>
  File "D:\life\uwo\ece\phd\code\nuitka\standalone\attempt_3\nnse.dist\pipeline\experimental_framework.py", line 13, in <module pipeline.experimental_framework>
  File "D:\life\uwo\ece\phd\code\nuitka\standalone\attempt_3\nnse.dist\pipeline\pipeline.py", line 22, in <module pipeline.pipeline>
  File "D:\life\uwo\ece\phd\code\nuitka\standalone\attempt_3\nnse.dist\pipeline\functional.py", line 14, in <module pipeline.functional>
  File "D:\life\uwo\ece\phd\code\nuitka\standalone\attempt_3\nnse.dist\hdbscan\__init__.py", line 1, in <module hdbscan>
  File "D:\life\uwo\ece\phd\code\nuitka\standalone\attempt_3\nnse.dist\hdbscan\hdbscan_.py", line 37, in <module hdbscan.hdbscan_>
  File "D:\life\uwo\ece\phd\code\nuitka\standalone\attempt_3\nnse.dist\hdbscan\plots.py", line 9, in <module hdbscan.plots>
  File "D:\life\uwo\ece\phd\code\nuitka\standalone\attempt_3\nnse.dist\sklearn\manifold\__init__.py", line 9, in <module sklearn.manifold>
  File "D:\life\uwo\ece\phd\code\nuitka\standalone\attempt_3\nnse.dist\sklearn\manifold\_t_sne.py", line 30, in <module sklearn.manifold._t_sne>
  File "sklearn\manifold\_barnes_hut_tsne.pyx", line 1, in init sklearn.manifold._barnes_hut_tsne
ModuleNotFoundError: No module named 'sklearn.neighbors._quad_tree'

It doesn't seem to matter what command I give my program, the output is the same. The output is confusing because I can see that the sklearn module is referenced as compilation is occurring, so I don't understand how this module is not included. Is there some way I can manually include it? Further details are below...

Nuitka version, full Python version, flavor, OS, etc. as output by this
command.

1.1
Commercial: None
Python: 3.10.4 | packaged by conda-forge | (main, Mar 30 2022, 08:38:02) [MSC v.1916 64 bit (AMD64)]
Flavor: Anaconda Python
Executable: D:\installs\programs\Anaconda3\envs\nnse\python.exe
OS: Windows
Arch: x86_64
WindowsRelease: 10

How did you install Nuitka and Python

All related libraries (vedo, nuitka, python) are installed using Anaconda command line in an anaconda environment

The specific PyPI names and versions
It should be taken from this output if there specific packages involved, e.g.
numpy, you are expected to shorten this to the relevant ones.

python -m pip freeze

Wasn't sure what to remove, so left the entire output here.
certifi==2022.9.24
click @ file:///C:/ci/click_1646056762388/work
colorama @ file:///home/conda/feedstock_root/build_artifacts/colorama_1655412516417/work
cycler @ file:///home/conda/feedstock_root/build_artifacts/cycler_1635519461629/work
dearpygui==1.6.2
Deprecated @ file:///home/conda/feedstock_root/build_artifacts/deprecated_1632758190537/work
fonttools==4.25.0
hdbscan @ file:///D:/bld/hdbscan_1644613083537/work
joblib @ file:///tmp/build/80754af9/joblib_1635411271373/work
kiwisolver @ file:///D:/bld/kiwisolver_1657953239132/work
laspy @ file:///home/conda/feedstock_root/build_artifacts/laspy_1656594965604/work
loguru @ file:///D:/bld/loguru_1649442989339/work
matplotlib @ file:///D:/bld/matplotlib-suite_1659031634610/work
mkl-fft==1.3.1
mkl-random @ file:///C:/ci_310/mkl_random_1643050563308/work
mkl-service==2.4.0
munkres==1.1.4
Nuitka @ file:///D:/bld/nuitka_1664172646218/work
numpy @ file:///C:/ci/numpy_and_numpy_base_1652784037925/work
opencv-python==4.5.5
ordered-set @ file:///home/conda/feedstock_root/build_artifacts/ordered-set_1643221357603/work
packaging @ file:///home/conda/feedstock_root/build_artifacts/packaging_1637239678211/work
pandas @ file:///D:/bld/pandas_1656001224800/work
Pillow==9.2.0
Pympler @ file:///home/conda/feedstock_root/build_artifacts/pympler_1658620692385/work
pyntcloud @ file:///home/conda/feedstock_root/build_artifacts/pyntcloud_1659284224615/work
pyparsing @ file:///home/conda/feedstock_root/build_artifacts/pyparsing_1652235407899/work
PyQt5==5.12.3
PyQt5_sip==4.19.18
PyQtChart==5.12
PyQtWebEngine==5.12.1
python-dateutil @ file:///home/conda/feedstock_root/build_artifacts/python-dateutil_1626286286081/work
pytz @ file:///home/conda/feedstock_root/build_artifacts/pytz_1660580468234/work
scikit-learn @ file:///C:/ci_310/scikit-learn_1642249118560/work
scipy @ file:///C:/ci_310/scipy_1642247684282/work
seaborn @ file:///tmp/build/80754af9/seaborn_1629307859561/work
sip==4.19.13
six @ file:///tmp/build/80754af9/six_1644875935023/work
tabulate @ file:///home/conda/feedstock_root/build_artifacts/tabulate_1655900837660/work
threadpoolctl @ file:///Users/ktietz/demo/mc3/conda-bld/threadpoolctl_1629802263681/work
torch==1.12.1
tornado @ file:///D:/bld/tornado_1656937966227/work
typing_extensions @ file:///C:/Windows/TEMP/abs_dd2d0moa85/croots/recipe/typing_extensions_1659638831135/work
vedo @ file:///home/conda/feedstock_root/build_artifacts/vedo_1661755873429/work
vtk===-PKG-VERSION
win32-setctime @ file:///home/conda/feedstock_root/build_artifacts/win32_setctime_1642883564726/work
wincertstore==0.2
wrapt @ file:///D:/bld/wrapt_1651495425905/work

Provide in your issue the Nuitka options used

python -m nuitka --standalone nnse.py --enable-plugin=numpy --enable-plugin=pyqt5 --enable-plugin=matplotlib  --enable-plugin=anti-bloat --output-dir=/d/life/uwo/ece/phd/code/nuitka/standalone/attempt_3
Here is the full compilation output (looks pretty good, to be honest):
Nuitka-Options:INFO: Used command line options: --standalone nnse.py --enable-plugin=numpy --enable-plugin=pyqt5 --enable-plugin=matplotlib --enable-plugin=anti-bloat --output-dir=D:/life/uwo/ece/phd/code/nuitka/standalone/attempt_3
Nuitka-Plugins:WARNING: anti-bloat: Plugin is defined as always enabled.
Nuitka-Plugins:WARNING: matplotlib: Plugin is defined as always enabled.
Nuitka:INFO: Starting Python compilation with Nuitka '1.1' on Python '3.10' commercial grade 'not installed'.
Nuitka-Plugins:INFO: multiprocessing: Injecting pre-module load code for module 'multiprocessing':
Nuitka-Plugins:INFO: multiprocessing:     Monkey patching "multiprocessing" load environment.
Nuitka-Plugins:INFO: multiprocessing: Injecting post-module load code for module 'multiprocessing':
Nuitka-Plugins:INFO: multiprocessing:     Monkey patching "multiprocessing" for compiled methods.
Nuitka-Plugins:INFO: pyqt5: Injecting pre-module load code for module 'PyQt5':
Nuitka-Plugins:INFO: pyqt5:     Adding binary folder to runtime 'PATH' environment variable for proper Qt loading.
Nuitka-Plugins:INFO: pyqt5: Injecting post-module load code for module 'PyQt5.QtCore':
Nuitka-Plugins:INFO: pyqt5:     Setting Qt library path to distribution folder. We need to avoid loading target
Nuitka-Plugins:INFO: pyqt5:     system Qt plugins, which may be from another Qt version.
Nuitka-Plugins:INFO: pkg-resources: Injecting post-module load code for module 'pkg_resources':
Nuitka-Plugins:INFO: pkg-resources:     Registering Nuitka loader with "pkg_resources".
Nuitka:INFO: Completed Python level compilation and optimization.
Nuitka:INFO: Generating source code for C backend compiler.
Nuitka:INFO: Running data composer tool for optimal constant value handling.
Nuitka:INFO: Running C compilation via Scons.
Nuitka-Scons:INFO: Backend C compiler: cl (cl 14.3).
Nuitka-Scons:INFO: Backend linking program with 1774 files (no progress information available).
Nuitka-Scons:INFO: Running 'link @C:\\Users\\Jon\\AppData\\Local\\Temp\\tmp31q_dh9p.lnk' took 468.79 seconds
Nuitka-Scons:INFO: Compiled 1774 C files using clcache with 1774 cache hits and 0 cache misses.
Nuitka-Plugins:INFO: data-files: Included data file 'certifi\cacert.pem' due to package data for 'certifi'.
Nuitka-Plugins:INFO: matplotlib: Included 183 data files due to package data for 'matplotlib.
Nuitka-Plugins:INFO: matplotlib: Included data file 'matplotlib\mpl-data\matplotlibrc' due to updated matplotlib config file with backend to use.
Nuitka-Plugins:INFO: data-files: Included data file 'pandas\io\formats\templates\html.tpl' due to package data directory 'templates' for 'pandas.io.formats'.
Nuitka-Plugins:INFO: data-files: Included data file 'pandas\io\formats\templates\html_style.tpl' due to package data directory 'templates' for 'pandas.io.formats'.
Nuitka-Plugins:INFO: data-files: Included data file 'pandas\io\formats\templates\html_table.tpl' due to package data directory 'templates' for 'pandas.io.formats'.
Nuitka-Plugins:INFO: data-files: Included data file 'pandas\io\formats\templates\latex.tpl' due to package data directory 'templates' for 'pandas.io.formats'.
Nuitka-Plugins:INFO: data-files: Included data file 'pandas\io\formats\templates\latex_longtable.tpl' due to package data directory 'templates' for
'pandas.io.formats'.
Nuitka-Plugins:INFO: data-files: Included data file 'pandas\io\formats\templates\latex_table.tpl' due to package data directory 'templates' for 'pandas.io.formats'.
Nuitka-Plugins:INFO: data-files: Included 601 data files due to package data directory 'zoneinfo' for 'pytz'.
Nuitka-Plugins:INFO: data-files: Included data file 'torch\bin\asmjit.dll' due to package data directory 'bin' for 'torch'.
Nuitka-Plugins:INFO: data-files: Included data file 'torch\bin\fbgemm.dll' due to package data directory 'bin' for 'torch'.
Nuitka-Plugins:INFO: data-files: Included data file 'torch\bin\protoc.exe' due to package data directory 'bin' for 'torch'.
Nuitka-Plugins:INFO: data-files: Included 7688 data files due to package data directory 'include' for 'torch'.
Nuitka-Plugins:INFO: pyqt5: Including Qt plugins 'iconengines,imageformats,mediaservice,platforms,platformthemes,printsupport,styles' below 'PyQt5\qt-plugins'.
Nuitka-Plugins:INFO: numpy: Found 42 files DLLs from numpy installation.
Nuitka-Plugins:INFO: dll-files: Found 22 files DLLs from torch installation.
Nuitka:INFO: Keeping build directory 'D:\\life\\uwo\\ece\\phd\\code\\nuitka\\standalone\\attempt_3\\nnse.build'.
Nuitka:INFO: Successfully created 'D:\\life\\uwo\\ece\\phd\\code\\nuitka\\standalone\\attempt_3\\nnse.dist\\nnse.exe'.

Hopefully, once again, you will be able to help me fix this and compile my program.
Thanks in advance,
Cheers
j

Can youj provide a reproducer, I am tempted to say that import sklearn.manifold fails on Anaconda (and probably only there), but I usually insist that users produce it.

This is the reproduction code (in file reproducer.py):
# This is a test file
from numpy.random import RandomState
import matplotlib.pyplot as plt
from matplotlib import ticker

from sklearn import manifold, datasets

def run():
    """Test"""
    rng = RandomState(0)
    n_neighbors = 12  # neighborhood which is used to recover the locally linear structure
    n_components = 2  # number of coordinates for the manifold
    n_samples = 1500
    S_points, S_color = datasets.make_s_curve(n_samples, random_state=rng)

    def add_2d_scatter(ax, points, points_color, title=None):
        x, y = points.T
        ax.scatter(x, y, c=points_color, s=50, alpha=0.8)
        ax.set_title(title)
        ax.xaxis.set_major_formatter(ticker.NullFormatter())
        ax.yaxis.set_major_formatter(ticker.NullFormatter())

    def plot_2d(points, points_color, title):
        fig, ax = plt.subplots(figsize=(3, 3), facecolor="white", constrained_layout=True)
        fig.suptitle(title, size=16)
        add_2d_scatter(ax, points, points_color)
        plt.show()

    t_sne = manifold.TSNE(
        n_components=n_components,
        learning_rate="auto",
        perplexity=30,
        n_iter=250,
        init="random",
        random_state=rng,
    )
    S_t_sne = t_sne.fit_transform(S_points)

    plot_2d(S_t_sne, S_color, "T-distributed Stochastic  \n Neighbor Embedding")

if __name__ == '__main__':
    print("This is before main")
    run()
    print("This is after main")

When run using:
python reproducer.py
the output is the following:

When compiled using:
$ python -m nuitka --standalone reproducer.py --enable-plugin=numpy --enable-plugin=pyqt5 --output-dir=/d/life/uwo/ece/phd/code/nuitka/standalone/attempt_4
And then run from inside the .dist folder, the output is the following:
$ ./reproducer.exe
Traceback (most recent call last):
  File "D:\life\uwo\ece\phd\code\nuitka\standalone\attempt_4\reproducer.dist\reproducer.py", line 6, in <module>
  File "D:\life\uwo\ece\phd\code\nuitka\standalone\attempt_4\reproducer.dist\sklearn\manifold\__init__.py", line 9, in <module sklearn.manifold>
  File "D:\life\uwo\ece\phd\code\nuitka\standalone\attempt_4\reproducer.dist\sklearn\manifold\_t_sne.py", line 30, in <module sklearn.manifold._t_sne>
  File "sklearn\manifold\_barnes_hut_tsne.pyx", line 1, in init sklearn.manifold._barnes_hut_tsne
ModuleNotFoundError: No module named 'sklearn.neighbors._quad_tree'

Is this an ok reproduction or did I do something wrong here?
Cheers
j

Hi Kay,
I just want to make sure this reproducer I gave was appropriate or whether you need something more from me. Please let me know.
Cheers
j

@jkissi yes it is, the thing with non-immediate reproducers is that I tend to overlook them.

This was part of the 1.1.5 hotfix release, but not yet reported.

That's great news! Thanks for your efforts here, very much appreciated!!!


Voice Support

So Voice has kinda become quite a large project. Which to be fair isn’t entirely unexpected, but still.
As of right now the plan is to write voice support as a Windows Runtime Component in C++/WinRT because it’s easier to work with native, non UWP APIs (which will be needed to both record and playback audio), it’s more expandable in future with potential for video chat and screen share, and hopefully more performant.
Work has started in the voice branch, and there is a slightly more detailed README.md document in the voice implementation folder.
The current status of the implementation will still be detailed here.

[x] Connecting / Disconnecting
[x] Receiving audio
[x] Transmitting audio
[x] Capturing audio
[x] Playing audio
[ ] Audio processing

[ ] Noise Reduction
[ ] Echo Reduction
[ ] Auto Level
[ ] Sample rate conversion

[ ] Voice activity
[ ] Stereo / Mono selection
[ ] Deafen / Mute
[ ] Connection Info & Ping Monitoring

I've done a lot of work on this over the past few days, and as of 03fba7707f2c45e7a5f493fb87dda3778e472674, it works! A test application can send audio data from the default microphone to discord, and receive audio data from discord for playback through the default speakers!


[WIP] Add Jenkins SITL testing for avoidance

This PR is adds SITL testing for the avoidance package

@Jaeyoung-Lim can we bring yaml_cpp_catkin to the PX4 ROS containers instead? Also, MAVROS is already installed on the Kinetic and Melodic containers.

Limited build to the avoidance package which doesn't have dependency problems.
@TSC21 yaml_cpp_catkin is not published as a deb package. I would need to see if it is compatible with the libyaml-cpp-dev

@jkflying I would suggest we first merge this as to fix the Jenkins build test failing on master and add the SITL tests in another PR


Show clearer feedback (snackbar, etc) when applicant hits Next but has unfilled questions

When you're filling out an application and hit Next without filling in all the required fields, the operation just fails silently. Some red error text appears near unfilled questions, but those may be all the way up the page. There's little feedback given around the Next button itself. This is confusing for screen readers, since they can't see the changes halfway up the page, and even for users without screen readers, since there's no immediate way of knowing why the Next button is failing.
Instead, we could:

Gray out the Next button until all required fields are filled
Reload the page and show a prominent error message (such as in snackbar)
Go back to the part of the page that had an error (scrolling?) and focus on the error messages so that the screen reader will read it.

This problem is mostly apparent with Name and Address questions, which have small red validation text way up the page.
Tester's original report

Actual results:
At Step 6, observe error messages / text are displayed in red for input text fields like 'address line 1' , 'city', 'state', 'zip code', 'first name' & 'last name' but screen reader does not announce the error messages.
Expected results: Error's , warnings visually being displayed should also be notified for screen reader users appropriately.

Something similar happens with Enumerator questions: if you don't fill in any enumerated values but then hit Next, it fails silently. Some error text pops up near the enumerator input fields, but nothing around the Next button.

I think the smoothest solution in this case is to disable the Next button until someone properly fills in at least one enumerated value.

Now the same thing happens with the File Upload button. If I hit Upload without uploading a file, the form does not submit, but the red error message is not next to the Upload button, making it potentially confusing for screen readers.

Like before, I think the move here is to disable the Upload button and gray it out until a file is uploaded, so the user knows (even if they're using a screen reader) that they can't go forward without doing something (or skipping).

Closing in favor of https://github.com/civiform/civiform/issues/3563, which suggests a fix recommended by the a11y team for this described issue.


VPN tests still failing on GKE

Failure Information (for bugs)
Ping is not a success for VPN tests sometimes. Reproducing only on veth-interfaces (i.e. only on GKE).
https://circleci.com/gh/networkservicemesh/networkservicemesh/118900
https://circleci.com/gh/networkservicemesh/networkservicemesh/118867
Steps to Reproduce

Use vhostnet i.e. pass env to vppagent-forwarder
Run any vpn test many times

Context

Kubernetes Version:
etc.

Failure Logs

https://circleci.com/gh/networkservicemesh/networkservicemesh/119195

https://circleci.com/gh/networkservicemesh/networkservicemesh/119483

vppagent-firewall-nse-1-firewall-nse.log
Found a strange repeated messages in logs
/usr/bin/vpp[12]: clib_time_verify_frequency:249: Rejecting large frequency change of +infinity%.
The problem can be related to vpp-agent.

still actual https://circleci.com/gh/networkservicemesh/networkservicemesh/121365

The same in https://github.com/networkservicemesh/networkservicemesh/pull/2113


Can't run Jest tests when component uses Dialog

Category

[x] Question
[ ] Typo
[x] Bug
[ ] Additional article idea

I use @microsoft/sp-dialog 1.5.1 and SPFx 1.5.1
Expected or Desired Behavior
When I test my component with Jest I get the next error
    Jest encountered an unexpected token

    This usually means that you are trying to import a file which Jest cannot parse, e.g. it's not plain JavaScript.

    By default, if Jest sees a Babel config, it will use that to transform your files, ignoring "node_modules".

    Here's what you can do:
     • To have some of your "node_modules" files transformed, you can specify a custom "transformIgnorePatterns" in your config.
     • If you need a custom transformation specify a "transform" option in your config.
     • If you simply want to mock your non-JS modules (e.g. binary assets) you can stub them out with the "moduleNameMapper" config option.

    You'll find more details and examples of these config options in the docs:
    https://jestjs.io/docs/en/configuration.html

    Details:

    C:\Code\SPFx\mywepart\node_modules\@microsoft\sp-dialog\lib\Dialog.js:7
    import { sealed } from '@microsoft/decorators';
    ^^^^^^

    SyntaxError: Unexpected token import

    > 12 | import Dialog from "@microsoft/sp-dialog/lib/Dialog";

Very similar thing happens with Guid class
Jest encountered an unexpected token

    This usually means that you are trying to import a file which Jest cannot parse, e.g. it's not plain JavaScript.

    By default, if Jest sees a Babel config, it will use that to transform your files, ignoring "node_modules".

    Here's what you can do:
     • To have some of your "node_modules" files transformed, you can specify a custom "transformIgnorePatterns" in your config.
     • If you need a custom transformation specify a "transform" option in your config.
     • If you simply want to mock your non-JS modules (e.g. binary assets) you can stub them out with the "moduleNameMapper" config option.

    You'll find more details and examples of these config options in the docs:
    https://jestjs.io/docs/en/configuration.html

    Details:

    C:\Code\SPFx\***\node_modules\@microsoft\sp-core-library\lib\index.js:11
    export { default as _BrowserDetection } from './BrowserDetection';
    ^^^^^^

    SyntaxError: Unexpected token export

       7 | import { connect, Dispatch } from "react-redux";
    >  9 | import { Guid } from "@microsoft/sp-core-library";

Hi Sergei,  I just wanted to confirm that I'm seeing the same issue also.  Likewise I'm using v1.5.1.
In my case I've added an import for the DisplayMode from the sp-core-library import { DisplayMode } from '@microsoft/sp-core-library';  As soon as I do this my tests being failing with the same error:
C:\Projects\UserGroupsViewer\node_modules\@microsoft\sp-core-library\lib\index.js:11     export { default as _BrowserDetection } from './BrowserDetection';     ^^^^^^
Pete

Tried to wite transformIgnorePatterns but didn't help

@aslanovsergey Did you come up with a solution to this?

I have the same error with jest testing on '@microsoft/sp-core-library':
\node_modules\@microsoft\sp-core-library\lib\index.js:11     export { default as _BrowserDetection } from './BrowserDetection';     ^^^^^^

@crsanghani Unfortunately no and @microsoft/sp-dialog 1.6.0 doesn't change the situation

@aslanovsergey any progress? i have the same issue

I'm also encountering the same error as @gosiaborzecka even after removing all references to Dialog.  SPFx v1.5.0

Hi everyone, @aslanovsergey
I did some further research on this and have managed to get my jest tests working but I'm not quite sure yet at what cost.
I took a copy of Velin Georgiev's jest testing sample: https://github.com/SharePoint/sp-dev-fx-webparts/tree/master/samples/react-jest-testing.  This sample is using SFPX v1.6.0.
I did an initial build and ran "npm test" successfully.    I then took the "IceCreamShop.tsx" component and added a reference to the Guid class e.g. import { Guid } from '@microsoft/sp-core-library';   I also added a var which generated a new guid in the main render method e.g. var guid: Guid = Guid.newGuid();.
After this change I ran "npm test" once again and got it to fail with the "Unexpected token export" error.
To get the tests running again I then did the following:

In the package.json file I changed the "transform" configuration from:
"^.+\\.(ts|tsx)$": "ts-jest" to
"^.+\\.(js|ts|tsx)$": "ts-jest".

Note the addition of "js".

In the pacakge.json file I added a "transformIgnorePatterns" configuration value: e.g.
"transformIgnorePatterns": [    "node_modules/(?!(@microsoft/sp-core-library))"  ],

In the tsconfig.json file, I removed the "declaration" configuration and added an "allowJs" configuration with it's value set to "true".
"allowJs": true,

Following these changes I was able to run "npm test" again and the tests all ran successfully.
I've been able to replicate these steps using a new project also built using SPFx v1.7.0 with the same results.
I can't say I fully understand the implications of the changes I've made but building, running and testing of my components is now working.   Hopefully these changes might further help in figuring out this issue.   I need to do some more research to further understand the implications of these changes.

Hi everyone, @aslanovsergey
I did some further research on this and have managed to get my jest tests working but I'm not quite sure yet at what cost.
I took a copy of Velin Georgiev's jest testing sample: https://github.com/SharePoint/sp-dev-fx-webparts/tree/master/samples/react-jest-testing. This sample is using SFPX v1.6.0.
I did an initial build and ran "npm test" successfully. I then took the "IceCreamShop.tsx" component and added a reference to the Guid class e.g. import { Guid } from '@microsoft/sp-core-library'; I also added a var which generated a new guid in the main render method e.g. var guid: Guid = Guid.newGuid();.
After this change I ran "npm test" once again and got it to fail with the "Unexpected token export" error.
To get the tests running again I then did the following:

In the package.json file I changed the "transform" configuration from:
"^.+\\.(ts|tsx)$": "ts-jest" to
"^.+\\.(js|ts|tsx)$": "ts-jest".

Note the addition of "js".

In the pacakge.json file I added a "transformIgnorePatterns" configuration value: e.g.
"transformIgnorePatterns": [ "node_modules/(?!(@microsoft/sp-core-library))" ],
In the tsconfig.json file, I removed the "declaration" configuration and added an "allowJs" configuration with it's value set to "true".
"allowJs": true,

Following these changes I was able to run "npm test" again and the tests all ran successfully.
I've been able to replicate these steps using a new project also built using SPFx v1.7.0 with the same results.
I can't say I fully understand the implications of the changes I've made but building, running and testing of my components is now working. Hopefully these changes might further help in figuring out this issue. I need to do some more research to further understand the implications of these changes.

For me it works, thanks!

Hi @petecuttriss
It is not working for me what ever you have shared. Still I am getting the error like "export { default as _BrowserDetection } from './BrowserDetection'".
Please help me on this.


ImageImport_use_latest_libguestfs_version_from_debian

Adding support for RHEL-9 OS require upgrading libguestFS version to be v1.46.2 or more. For now we'll use latest version available on debian packages of libguesFS which is v.1.48.2
/assign yswe
/cc yswe

We discussed offline, to deliver support for RHEL-9 ASAP we will add integration tests for worker images later.

/lgtm


feat(require-default-props): add option to ignore functional components

Addresses the discussion from https://github.com/yannickcr/eslint-plugin-react/issues/1009
Specifically from the recommendation at: https://github.com/yannickcr/eslint-plugin-react/issues/1009#issuecomment-516485145 to 'warn less'.
This PR adds an option to require-default-props to ignore functional components, as react will soon deprecate defaultProps on functional components https://github.com/reactjs/rfcs/pull/107.

Let's also add some tests for export function Foo() {} and export const Foo = () => {} and export default function Foo() {}, and let's make sure all these tests run on all the parsers.

to which rules specifically? these exports tests, all of my new tests, or all tests in this file? i assumed the first option

The first option, yes :-)


upgrade dependencies version

Change-Id: I709938f69f21096bc5cd29a24191f0f282dcbc97
Description
Brief description of what this PR is about

If this change is a backward incompatible change, why must this change be made?
Interesting edge cases to note here

Codecov Report

Merging #1012 (defb8c8) into master (77809f4) will increase coverage by 0.07%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1012      +/-   ##
============================================
+ Coverage     69.97%   70.05%   +0.07%
- Complexity     5106     5108       +2
============================================
  Files           504      504
  Lines         22601    22601
  Branches       2367     2367
============================================
+ Hits          15815    15833      +18
+ Misses         5519     5504      -15
+ Partials       1267     1264       -3

Impacted Files
Coverage Δ

api/src/main/java/ai/djl/Device.java
65.95% <0.00%> (-4.26%)
:arrow_down:

...rc/main/java/ai/djl/ndarray/internal/NDFormat.java
83.90% <0.00%> (-1.15%)
:arrow_down:

...ne/src/main/java/ai/djl/mxnet/jna/StringArray.java
92.85% <0.00%> (ø)

...e/src/main/java/ai/djl/mxnet/jna/PointerArray.java
94.11% <0.00%> (ø)

api/src/main/java/ai/djl/repository/Artifact.java
93.10% <0.00%> (+1.72%)
:arrow_up:

...ava/ai/djl/translate/ServingTranslatorFactory.java
84.28% <0.00%> (+14.28%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77809f4...defb8c8. Read the comment docs.


Escape identifier confused for keyword

The following:
pt = x: 123, y: 456
from = 'x'
to = 'y'
from: pt.[from], to: pt.[to]

should yield:
{"from":123,"to":456}

but instead gives:
{"from":123,"to":[]}

Looking at AST for the last object literal, it seems that [to] is being confused for slicing:
  Obj
    Prop
      Key from
      Chain
        Var pt
        Index .
          Parens
            Var from
    Prop
      Key to
      Slice to
        Chain
          Var pt
        Literal

Is there a way to escape to so it's not confused for the keyword to? I couldn't find anything in the documentation.

Not really. Don't use to as a variable name is the usual advice. array[optFrom to optTo] is already something in LS :).

You could write:
from: pt.(from), to: pt.(to)

Yeah, or arr"#to"

@pepkin88 Thanks, that seems like the best workaround & which will help if & when #818 gets addressed.


Impossible to put constants as output measure in filters

Description
It is currently impossible to create a measure with atoti.filter using a constant as the output. I instead have to create a constant measure, and then filter on it :
m["example"] = tt.filter(1.0, condition)
will raise a ValueError
While :
m["one"] = 1.0
m["example"] = tt.filter(m["one"], condition)
will produce the desired output correctly.
Context
I'm trying to create a measure that can take values according to different (4) formulas depending on conditions on other levels. Therefore, I created 4 filtered measures, one for each formula and added them to create the desired measure. Two of these formulas are just constants (1.0 and -1.0 ).
Other information (if relevant)
Constants can be used in atoti.where, so I could also use several layered atoti.where to get the desired measure.

This will be supported in the next release.


Removed fixupCorridor and replaced with dtMergeCorridorStartMoved

In the function dtMergeCorridorStartMoved is re-implemented in NavMeshTesterTool.cpp as fixupCorridor.
I removed fixupCorridor and replaced with dtMergeCorridorStartMoved.
Fixes #634

Looks great.  Thanks for this!


vkcube should use the first available physical device

Highly related to #153
Code in question - https://github.com/KhronosGroup/Vulkan-Tools/blob/a2224abf350f61211462a33e5b540201fa17de0d/cube/cube.c#L4185
As a result of this logic, vkcube always picks a discrete GPU on multi-gpu systems. This is in conflict with the principle of vkEnumeratePhysicalDevice returning the adapters in a "preferred" order by the system (see https://github.com/KhronosGroup/Vulkan-Loader/issues/153#issuecomment-515007898 for context). If Vulkan loader is indeed trying to return the first adapter as the preferred, and/or there are applications expecting them, then I think vkcube should just pick the first (available) physical device instead of doing any kind of sorting. If you want to demonstrate a more comprehensive use of Vulkan, you could keep the sorting functionality behind an option.
The context here is - some systems returning Intel GPU as the first but actually failing to present with it. See https://gitlab.freedesktop.org/mesa/mesa/-/issues/4688 and https://gitlab.freedesktop.org/mesa/mesa/-/issues/12212 for examples. vkcube is often used to simply check "does Vulkan work on your system", and always returning the discrete GPU isn't actually providing this signal, which causes confusion.
Examples of confusion:

https://bbs.archlinux.org/viewtopic.php?id=280222

If you want to demonstrate a more comprehensive use of Vulkan, you could keep the sorting functionality behind an option.

vkcube --gpu_number 0 could help you always select first GPU.

vkcube is often used to simply check "does Vulkan work on your system", and always returning the discrete GPU isn't actually providing this signal, which causes confusion.

If you want to check all physical devices could work on your system, you could get total number GPU number and run vkcube --gpu_number <index> in a loop.

I'm opposed to the premise of this issue's problem statement.
We intentionally added sorting to bring Vulkan on par with APIs like D3D12 on Windows. On Windows, there is OS arbitration of physical device sorting. This sorting spans devices from separate IHVs (which is this issue's configuration.)  The OS provides centralized user control that overrides the default heuristics. Users do use this capability. Matching D3D12 behavior in Vulkan is desired.
Linux lacks centralized control that spans IHVs. In part, there is an allergic reaction from linux maintainers to the concept of centralized arbitration that spans drivers. Recent discussion within the Vulkan working group has seemed to come to realize that centralized arbitration might in fact be good, and there might be an "education campaign" in the coming months. The future is TBD.
In the absence of centralized arbitration, the Vulkan loader for linux has implemented its own heuristics. The topic of this issue is really about the heuristics that were implemented inside the Vulkan loader for linux. My words do not debate the quality and efficacy of those heuristics. What I'm doing in this comment is clarifying the problem space and some background that is relevant to the discussion.

@jjulianoatnv thank you for a well-thought response!
If there is a gap in Linux support for Vulkan with regards to supporting multiple IHV, I don't think vkcube is the right place to solve it. Introducing adapter sorting in vkcube is not going to magically bring Vulkan on par with D3D12 for everybody.
The proper solution would lie somewhere in writing the Vulkan layers (like the MESA device select), working with linux maintainers (like you mentioned), etc. vkcube should assume a healthy system, not try to fix it.


Adding self-hosting AT server capabilities

Added environment variable for selfhosters of the AT server
Put in small checks to use environment variable instead of bsky.social if present
Updated README, installation docs.
Did NOT add to the installation script.

Thank you for the pull request.
I will check the details separately, but first I would like to comment on the tab character.
Tab characters have been changed to spaces in some places, but the tab character plays an important role in this script. Therefore, changing this tab character to a space character is not acceptable.
https://github.com/uriel1998/bsky-sh-cli/blob/e0912b25baaf518cdb7c721c051684bd0ede37f3/lib/api/proxy.sh#L10C1-L10C6
https://github.com/uriel1998/bsky-sh-cli/blob/e0912b25baaf518cdb7c721c051684bd0ede37f3/lib/bsky_core.sh#L10
https://github.com/uriel1998/bsky-sh-cli/blob/e0912b25baaf518cdb7c721c051684bd0ede37f3/lib/bsky_core.sh#L2720
https://github.com/uriel1998/bsky-sh-cli/blob/e0912b25baaf518cdb7c721c051684bd0ede37f3/lib/bsky_core.sh#L2804
https://github.com/uriel1998/bsky-sh-cli/blob/e0912b25baaf518cdb7c721c051684bd0ede37f3/lib/bsky_core.sh#L2878
https://github.com/uriel1998/bsky-sh-cli/blob/e0912b25baaf518cdb7c721c051684bd0ede37f3/lib/bsky_core.sh#L5410

If I approve your pull request, please note that for my release management purposes, I will merge it into a different branch (probably 0.13.0 or a feature branch) instead of the main branch.
After that, I will start preparing for the release.

@uriel1998
Do you have any comments on my comments so far?
If you don't respond, I'd like to add a feature based on your changes.
If I were to merge this request, I would like you to at least revert the tab character change, if possible.

Apologies; it's been a weird two weeks for me.  Will def. check it out, thanks for your patience.

Okay, should have the IFS tabs restored (stupid IDE auto-replaced them, that's why I didn't realize it).  Also added a check I missed where I'd hardcoded my AT endpoint, whoops.
I apologize for any other errors I may have introduced; your skill level and sophistication with BASH far exceeds mine.

Thank you for your kind response.
I will check it, make any necessary adjustments, and release it, so please wait.


User cannot focus or select radio button component with keyboard

Environment
Chrome 70
macOS Mojave
Violation
The user cannot focus or activate a radio button in the component example. Neither space or enter selects or deselects the radio button.

Closing. Selection with the keyboard is done with the arrow keys. 💯


Please may you tag a new version

There have been quite a few bug fixes since the last version, please could you make a new release?

That is actually a good idea. There's a new version coming (see the branch v0.10.0-working) but that might take a bit longer as that's quite a big change so I'm gonna cut a new release now


Adding standby_usage for LCA001 and LCT015 (measured)

Adding a couple of missing standby_usage. I measured them using TP-LINK HS110 as usual.

I couldn't add "measure_method" and "measure_device" because I don't know how the LUT files have been measured...

Thanks. I will add them later.


Fix margins on the "our story" section of /about

Description
The "our story" section of the about page currently runs into the text surrounding it.
Ask
Add margins to the "our story" section.
Additional Info

Yeah would be really helpful to isolate the .support{} class to the donation page, as that is why this spacing got wacked...

@minamarkham are you taking this or just setting the issue? I can tackle if you'd like

I can do it.

Okay! Didn't wanna overlap if you were on it :+1:

@minamarkham I am going to re-assign this to @kstack7, as we need to get this wrapped up before launch! thanks for offering to help <3

Better, right?

@kstack7 much! :sparkler:

Fixed #216.


Carthage build issue

Since Swift isn't ABI stable yet, the prebuilt binaries that Carthage gets from Github on the releases page are not working with the latest versions of XCode/Swift. Would recommend that they be removed, as XCode won't build with them.

Hi @danielrhodes, thanks for your issue.
I tried with Carthage, the framework build by Carthage is good for me.
Here is my test project: TestJi.zip, works well.
What errors did you get?

The error I got was that the project was built with Swift 3 and not 3.0.1. Not a source level issue, but whatever pre-built binaries you have on Github which Carthage is using instead of compiling the library locally.

@danielrhodes There's no pre-build binaries on GitHub, Carthage should build the framework locally.
I guess the error is caused by your target's Use Legacy Swift Language Version settings. Because setting to "No" in Xcode 8.2 results in SWIFT_VERSION  = 3.0, while Xcode 8.1 sets to 3.0.1

That is likely. My project is on 3.0.2 I belive.

Xcode 8.2 just uses SWIFT_VERSION = 3.0 instead of 3.0.x.
Will you be able to provide a sample project with the error you met?

Hi, I also have an issue with Ji when building with Carthage:
*** Building scheme "Ji iOS" in Ji.xcworkspace
** BUILD FAILED **

The following build commands failed:
	CompileSwift normal arm64
	CompileSwiftSources normal arm64 com.apple.xcode.tools.swift.compiler
(2 failures)
/Users/vmonaco/Programming/Current-iOS/Carthage/Checkouts/Ji/Tests/JiNodeXMLTests.swift:11:18: error: module 'Ji' was not compiled for testing
/Users/vmonaco/Programming/Current-iOS/Carthage/Checkouts/Ji/Tests/JiTests.swift:11:18: error: module 'Ji' was not compiled for testing
/Users/vmonaco/Programming/Current-iOS/Carthage/Checkouts/Ji/Tests/htmlXPathTests.swift:11:18: error: module 'Ji' was not compiled for testing
/Users/vmonaco/Programming/Current-iOS/Carthage/Checkouts/Ji/Tests/JiNodeHTMLTests.swift:11:18: error: module 'Ji' was not compiled for testing
/Users/vmonaco/Programming/Current-iOS/Carthage/Checkouts/Ji/Tests/xmlXPathTests.swift:11:18: error: module 'Ji' was not compiled for testing
A shell task (/usr/bin/xcrun xcodebuild -workspace /Users/vmonaco/Programming/Current-iOS/Carthage/Checkouts/Ji/Ji.xcworkspace -scheme "Ji iOS" -configuration Release -sdk iphoneos ONLY_ACTIVE_ARCH=NO BITCODE_GENERATION_MODE=bitcode CODE_SIGNING_REQUIRED=NO CODE_SIGN_IDENTITY= CARTHAGE=YES clean build) failed with exit code 65:
** BUILD FAILED **

The following build commands failed:
	CompileSwift normal arm64
	CompileSwiftSources normal arm64 com.apple.xcode.tools.swift.compiler
(2 failures)

somehow Carthage is trying to build the test scheme? Maybe this could be excluded from the "Ji iOS" scheme


Change Buddist to Buddhist in Religion Picklist

lurch: attach W-009637

Included in beta release version 1.7 (Beta 1) and higher

Included in production release version 1.7


Redirects to external site that ends in static file extension is appending a slash at the end.

Example =
redirect: "/sample"
destination: "https://www.sample.com/page.html"
Result =
destination: "https://www.sample.com/page.html/"
The destination server doesn't like this and throws an exception.

Hi @GreyGhostStudio ! Thank you for reaching out and creating a bug report.
Can you share with me if your Umbraco is configured to add trailing slashes behind urls? You can find out more about this config here in the Umbraco docs: https://docs.umbraco.com/umbraco-cms/reference/configuration/requesthandlersettings#add-trailing-slash
Notice that this configuration is true by default, so if you haven't explicitly set it yourself, it's likely enabled.
The URL Tracker's behaviour with trailing slashes is linked to this configuration. You may be able to work around this issue by disabling trailing slashes. That would be a quick fix for you.

Hi @D-Inventor. That work around did the trick and will get us by for now. Thanks!!


Project loading is sequential and it take ages.

Is your feature request related to a problem? Please describe.
Trying to open big solution (~160 projects) with Ionide 4.0.0
Projects are loading one-by-one (even if they are independent from each other) and it takes ages to finish.
Describe the solution you'd like
They should load in parallel. Even if some work could be done twice, it's worth doing.
Describe alternatives you've considered
Rider does "synchronization project" initialization in 2 minutes with going extreme load with SSD and CPU.

Problem for @Krzysztof-Cieslak is that then I'm complaining about CPU usage (and unusable system) when opening Fake.sln ;)

Changes in a project parsing strategy are planned for the future. @enricosada knows more about that

With 160 projects sounds like you have bigger issues to think about first  :-)

@7sharp9 160 doesn't sound like a number a computer cannot handle either. I think it should work. Saying that's too much is not reasonable when Microsoft internally tests VS against such numbers and therefore all other editors can work with that number just fine.

when Microsoft internally tests VS against such numbers

If I get whole team working just on project system it will be reasonable to expect Ionide supporting such amounts without any problem ;-)

Yes, there are various enhancement we can do to reach that goal eventually.
For sure i think we can incrementally improve, one step at time, i hope to do so.

Honestly I unironically hope we don't support 160 projects in a single solution. The cognitive load of that sounds bad. Multiple solutions is not a crime. Supporting so many projects in a solution is in itself a footgun and leads to a scenario where I could theoretically work there.

And I already have a lots of tooling issues ;)
I don't feel any cognitive load to be honest. In fact it's a lot easier to find stuff now than it was with "FakeLib" (imho)

TBF, I’m just not sure how well we can support such loads - not only in terms of just a project loading (improvements here will affect everyone, even smaller projects) but just in terms of FCS/FSAC/BackgroundService performance

I'm currently looking at a solution with millions of lines with half as many projects. It needs to be broken up into more than one solution.

@Krzysztof-Cieslak I don't see any reason why it wouldn't work. The issues I currently see are not mainly performance to be honest. Yes startup perf is an issue but even once everything is loaded I run into lots of issues I'm trying to figure out and report properly, but I don't see any high load after everything is loaded. This has drastically improved from 3 to 4
Problems are more like:

Everything suddenly stops working (intellisense, line lense, ...) after some hours <- I see this on small solutions as well
I think there is an issue with multi-targeting which I'm trying to figure out which breaks some stuff
Issues I have already reported on various locations
Sometimes FSAC seems to decide it needs to reload everything. I feel like this happens when you run a fake build, maybe all project files are touched and Ionide goes crasy about that (even if there are no actual changes). This obviously is much worse if you have lots of projects.

Back to this issue: I don't see anything we couldn't work out.

For the record I talked to @matthid  on slack and better understand why his project is the way it is :). The moral of the story is don't comment if you haven't gotten a full night's rest.

Should be fixed with 5.0
The project loading is still sequential but should be way faster


neuroscope helper function data flow

Though what is currently used works fine as is, there is a decent amount of direct data retrieval from source files such as the .XML within the neuroscope.py helper functions which obtains data that is also retrieved in the same fashion but stored previously within upstream metadata of the converter.
Such occurrences are computationally redundant and the helper functions should instead receive the values as passed input from the metadata, which should grab all relevant values prior to running the conversion.

There's been a lot of changes to the approach of metadata handling since this issue was posted, so the distribution of access ought to either be leveled or appropriate to it's current intent.


IXW-971 [File Storage - Stowage SDK] Increase buffer size and remove …

There were 2 separate errors that I noticed while using Stowage's Amazon S3 File Storage.
The 1st issue I discovered was that when using Stowage's Amazon S3 file storage, small files would upload to S3 with no issues for me and larger files would throw a 400 Bad request error inside the CompleteMultipartUpload method. I came to realize that the problem was with the buffer size. Before uploading the file, the file would be broken up into multiple parts depending on the size of it. After some research I read that the parts (not counting the very last part) had to be at least 5Mib in size or else they would fail during the multipart upload. This explains why small files would work but large files would not. For a small file, only one part would be used and even though it would be less than 5Mib, it would be ok since the size of the last part is ignored. Since there is only 1 part, it is considered the last part. However for larger files, multiple parts under 5Mib would be created and attempted to be upload. This would cause the 400 response back from AWS during the Multipart upload. To resolve this, the buffer size had to be increased from 1Mib to 5Mib. I also had to make sure on my end, when using the copyToAsync method when copying the local stream to my s3 stream, that I had to specify a buffer size of 5Mib as well. Once these changes were made large files were able to be sent to S3 storage without problems.
The 2nd issue occurred whenever I attempted to upload a local file to s3 and tried to put spaces in the s3 file name. Every time I attempted to do this, the upload would fail. After some further digging I learned that this was a problem with the encoding of the canonical  Uri. When calling the SignAsync() method before sending the request, you would attempt to encode the Canonical Uri twice. This would cause the space in the file name to be encoded to %20 and then it would get encoded a second time, causing the % to be encoded as well. This would ultimately result in the upload request failing.

thanks for investigating this, looks good. Just cleaning up a few typos.

code moved over instead of merge, thank you!


PWA config iconPaths not working properly

Version
3.0.4
Node and OS info
node 8.11.2 / npm 6.4.1 / Windows 10
Steps to reproduce
Base Setup with Vue Cli,  install official PWA plugin, attempt to re-define the iconPaths and manifest path within the pwa object in vue.config.js, build, nminify the outputted index and walah
What is expected?
the href property for each element specified is supposed to be the exact value set within the vue.config.js file
What is actually happening?
the href property remains outputting as the default value, regardless of what I try to put into the config file

I have tried adding file extensions, a blank space, null, various different pathing types, restarting the server, closing and reopening the folder, and am following the official guidelines. I have opened a ticket with screenshots attached on stackoverflow at https://stackoverflow.com/questions/53837709/vue-pwa-plugin-adjusting-iconpaths-and-manifest-destination

big darn. well I attached screenshots on my stack overflow post if that helps.
Not really sure how I can help anyone reproduce this error, its really just an issue of the config not doing what it claims it should be doing

Not really sure how I can help anyone reproduce this error,

create a new project
follow your own steps that you provided
create a new commit with those changes
push repository to github
share github repository here.

thank you, will do, one moment.

very strange. It worked with the reproduction.. same syntax copied and pasted over..
im going to try to update the dependencies maybe this was addressed in a patch

wow yeah that was it. I guess i was still using the r.c version of the pwa plugin as well as a few other dependencies that were a few versions behind, this issue was solved by simply running npm update.
thank you


Use tenant key on console commands instead of id

In some cases 'id' would not be used (For example, assume one has a key named slug and deleted id column, commands would not recognize tenant on console comment, this simple PR fixes that).

Codecov Report

Merging #768 (ff68bd9) into 3.x (2726f07) will decrease coverage by 0.02%.
The diff coverage is 66.66%.

@@             Coverage Diff              @@
##                3.x     #768      +/-   ##
============================================
- Coverage     87.02%   87.00%   -0.03%
  Complexity      372      372
============================================
  Files           103      103
  Lines          1102     1100       -2
============================================
- Hits            959      957       -2
  Misses          143      143

Impacted Files
Coverage Δ

src/Commands/TenantList.php
0.00% <0.00%> (ø)

src/Commands/Migrate.php
93.75% <100.00%> (ø)

src/Commands/Rollback.php
93.75% <100.00%> (ø)

src/Commands/Run.php
100.00% <100.00%> (ø)

src/Commands/Seed.php
92.85% <100.00%> (ø)

src/Listeners/UpdateSyncedResource.php
100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2726f07...ff68bd9. Read the comment docs.

Thanks!


Missing license?

I noticed that your main repo has an MIT license but this repo seems to be missing one. Is this code also available under the MIT license? It would be lovely if the license were copied over to this repo too.

Per your suggestion, an MIT license file has been added.
Recently, our team will spend more time on maintain the tutorials, helping users to get familiar with FinRL.


Small font icons

I'm having issues with font icons that look small compared to the font itself (especially in the gutter area in Neovim). They're fine in, for example, Wezterm. I'm not sure if this is related to #3029.
Ghostty left, Wezterm right:

Used font: JetBrainsMono Nerd Font
Ghostty version: 1.0.0 build 8469
Hardware: MacBook Pro M1 (if it's relevant)
Ghostty config:
font-family = JetBrainsMono Nerd Font Mono
font-size = 15

theme = catppuccin-mocha
background-opacity = 0.85
background-blur-radius = 20

Looks like a duplicate of https://github.com/ghostty-org/ghostty/issues/1903

Ah, I only looked in open issues. Yeah, having a non-nerd font as primary and an icons-only font as fallback helped. I'm closing the issue.

@anatskiy In my case I didn't actually need to specify a fallback font. I believe Ghostty supplies its own so you might be able to getaway without it too.

@zuqini The only font config that actually worked for me is (the first two lines are only for the sake of explicitness):
font-family = ""
font-family = JetBrains Mono
font-family = Symbols Nerd Font Mono
font-size = 15

Unfortunately, this brings another issue. Icons in some apps like Lazygit and Neovim have improper scaling when selected/hovered:
https://github.com/user-attachments/assets/e0da04b7-9a6c-43b2-a4bd-f38bcad90797
https://github.com/user-attachments/assets/7d7ae34b-c69d-4ece-a7f0-77be9011b02a
This is better than small icons but still very annoying. I'll see how much of a dealbreaker this is for me.
@mitchellh Is this worth looking into?


[QA] DCLMF24 | Reload command not working

Build version:
0.45.0
Issue Description:
Using the command /reload does not work properly. It reloads everything except for the set of the Music Festival (either reloads the scene but not the stage or you get the not in sdk7 message)
STR:

Open 0.45.0
Go to the MF
Use the command /reload on the main stage
Check that the set does not reload but the entire scene does

❌ Actual Result:
Reload command not working
✔ Expected Result:
The command reload should reload everything and also the set
Additional Notes:
This issue happens on both platforms

This issue is still happening on latest dev and latest release (0.49.0)


MSID: 100282 Version: 1 DOI: 10.1101/2<IP_ADDRESS>6000

MSID: 100282
Version: 1
Preprint DOI: https://doi.org/10.1101/2<IP_ADDRESS>6000
Step 1. Awaiting reviews
Editorial to post reviews via hypothesis
Useful links:

DocMap: https://data-hub-api.elifesciences.org/enhanced-preprints/docmaps/v2/by-publisher/elife/get-by-manuscript-id?manuscript_id=100282
New model tracking: https://docs.google.com/spreadsheets/d/1_fHaoOy7hjyocptKtVJRijeNpUY4hBS7Ck_aVmx6ZJk/
Reviews on sciety: https://sciety.org/articles/activity/10.1101/2<IP_ADDRESS>6000

For trouble shooting (e.g. no Docmaps available):

DocMap issue addressing: https://miro.com/app/board/uXjVNCwK6EI=/
Explore DataHub DocMaps API: https://lookerstudio.google.com/reporting/4c2f0368-babb-4beb-b5b3-497e7e7b0f08/page/ejphD
Unmatched submissions and preprints: https://lookerstudio.google.com/u/0/reporting/9f86204f-3bf7-477c-9b18-5c5ef141bf69/page/p_gxi57ha93c
Unmatched manuscripts spreadsheet: https://docs.google.com/spreadsheets/d/15QcK8w-ssB7109RQEDtFpJPZ0J5HTGxoHa_2TtpMBbg/edit#gid=1336081641

Step 2. Preview reviewed preprint
Production QC content ahead of publication
Instructions:

QC preview: https://prod--epp.elifesciences.org/previews/100282v1
Update ticket with any problems (add blocked label)
When QC OK, add QC OK label to ticket and add publication date and time to https://docs.google.com/spreadsheets/d/1amAlKvdLcaDp5W8Z8g77NmkwbMF5n_u89ArSqPMO8jg
Move card to next column
(At end of the day post link in #enhanced-preprint and ask for PDF to be generated)

Useful links:

Preprint DOI :  https://doi.org/10.1101/2<IP_ADDRESS>6000
Confirm reviews returned by EPP: https://prod--epp.elifesciences.org/api/reviewed-preprints/100282/v1/reviews
To update the MECA path in the docmap: https://docs.google.com/spreadsheets/d/1mctCQuNFBjSn97Lihy7_vBO6z7-N-oqyLv4clyi6zHg

Step 3: Awaiting search reindex
This step adds the reviewed preprint to the homepage: https://elifesciences.org
The search reindex is triggered once an hour. We need the reviewed preprint to be indexed as the search application serves the journal homepage.
Useful links:

Jenkins pipeline to reindex search can be triggered sooner or monitored here: https://alfred.elifesciences.org/job/process/job/process-reindex-reviewed-preprints/

Step 4: Published! PDF requested
Waiting for PDF to be generated
Useful links:

PDF tracking: https://docs.google.com/spreadsheets/d/106_XeDjmuBae7gexOTNzg60lapeqjl2aRn9DzupGyS8/

Step 5: Introduce PDF to data folder and git repo
Upload PDF to relevent folder in git repo https://github.com/elifesciences/enhanced-preprints-data/
Step 6: Done!

[ ] Kettle is on!

warn: [journal-ref-text-content] This journal reference (id c15) has untagged textual content - ; Forman-Kay, J. D.et al. . Is it tagged correctly?
warn: [journal-ref-text-content] This journal reference (id c32) has untagged textual content - . (acccessed 6/6/2024).. Is it tagged correctly?
warn: [journal-ref-text-content] This journal reference (id c34) has untagged textual content -  10.1101/2<IP_ADDRESS>4233. (acccessed 2024-05-15).. Is it tagged correctly?
warn: [journal-ref-text-content] This journal reference (id c35) has untagged textual content -  10.1038/s41557-024-01489-x.. Is it tagged correctly?
error: [journal-ref-article-title] This journal reference (id c40) has no article-title element.


Define the physical format of a Tosca Archive

In order to upload and eventually validate a "Tosca Archive" within the "Service Publishing" process, the packaging format (zip file?) and contents of it have to be defined.
Once they are defined, the Validation activity within the Publishing process will be able to distinguish all required artifacts within the archive itself and perform the specific validations for each of them.

A definition of the CSAR file can be found in the following link: http://docs.oasis-open.org/tosca/TOSCA/v1.0/os/TOSCA-v1.0-os.html#_Toc356403711

Yes the format is known and defined in the standard we will stick to that.
The Tosca component will mange its complexity


BrokenResponseError: Can not build a coherent char history after a broken streaming response (See the previous Exception fro details). To inspect the last response object, use chat.last.To remove the last request/response Content objects from the chat call last_send, last_received = chat.rewind() and continue without it

Traceback (most recent call last):
File "", line 1, in
File "/home/asahi/Проекты/Python/gemini/gemini/init.py", line 5, in main
run()
File "/home/asahi/Проекты/Python/gemini/gemini/main.py", line 81, in run
process_directory(SRC, DST)
File "/home/asahi/Проекты/Python/gemini/gemini/main.py", line 73, in process_directory
translate_file(src_path=src_path, dst_path=dst_path)
File "/home/asahi/Проекты/Python/gemini/gemini/main.py", line 48, in translate_file
translated = translate(src_path)
^^^^^^^^^^^^^^^^^^^
File "/home/asahi/Проекты/Python/gemini/gemini/main.py", line 36, in translate
second_response = chat.send_message(content=MESSAGE_FOR_SECOND_PART + second_part, stream=True)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/asahi/.cache/pypoetry/virtualenvs/gemini-UM_oiH3g-py3.12/lib/python3.12/site-packages/google/generativeai/generative_models.py", line 467, in send_message
history = self.history[:]
^^^^^^^^^^^^
File "/home/asahi/.cache/pypoetry/virtualenvs/gemini-UM_oiH3g-py3.12/lib/python3.12/site-packages/google/generativeai/generative_models.py", line 686, in history
raise generation_types.BrokenResponseError(
google.generativeai.types.generation_types.BrokenResponseError: Can not build a coherent char history after a broken streaming response (See the previous Exception fro details). To inspect the last response object, use chat.last.To remove the last request/response Content objects from the chat call last_send, last_received = chat.rewind() and continue without it.
code:
# --snip--
chat = model.start_chat()
PART_LEN = len(content) // 2
first_part = content[:PART_LEN]
second_part = content[PART_LEN:]
first_response = chat.send_message(content=MESSAGE_FOR_FIRST_PART + first_part, stream=True)
for chunk in first_response:
        chunks.append(chunk)
second_response = chat.send_message(content=MESSAGE_FOR_SECOND_PART + second_part, stream=True)
for chunk in second_response:
        chunks.append(chunk)

Typo fix: https://github.com/google-gemini/generative-ai-python/pull/313
It's trying to tell you that the first stream broke, and it's not sure what to do.
Is the first part not raising an error?

The first part doesn't give any errors. The second part gives an error, previously everything worked, with identical code (I automate translation, and I was able to translate about 15 .md files), then just started to pop up this error and that's it, nothing helps.

def translate(path: str) -> str:
    file = io.FileIO(file=path)
    content = str(file.read())
    model = genai.GenerativeModel(model_name=MODEL, generation_config=GENERATION_CONFIG)
    chunks = []
    chat = model.start_chat()
    PART_LEN = len(content) // 2
    first_part = content[:PART_LEN]
    second_part = content[PART_LEN:]
    first_response = chat.send_message(content=MESSAGE_FOR_FIRST_PART + first_part, stream=True)
    for chunk in first_response:
        chunks.append(chunk)
    second_response = chat.send_message(content=MESSAGE_FOR_SECOND_PART + second_part, stream=True)
    for chunk in second_response:
        chunks.append(chunk)
    result = "".join(part.text for chunk in chunks for candidate in chunk.candidates for part in candidate.content.parts)
    return result

The error occurs here:
second_response = chat.send_message(content=MESSAGE_FOR_SECOND_PART + second_part, stream=True)


Is the webpack assets supposed to be in git or not?

When using Heroku, the assets generated with assets:precompile should be added to git. Is it the same for the webpack assets in public/webpack/production?
It seems to me that the webpack assets does not exist when running the app from heroku, but the /public/webpack/* is on the other hand in .gitignore which implies that they should not be added...
How is it supposed to work?

When using Heroku, the assets generated with assets:precompile should be added to git.

Where is this documented? I believe the precompiled assets should never be added to git.

Is it the same for the webpack assets in public/webpack/production?
See my previous statement

It seems to me that the webpack assets does not exist when running the app from heroku, but the /public/webpack/* is on the other hand in .gitignore which implies that they should not be added...

.gitignore is for developers so git knows that stuff in the deployment directories is not a pending change.

How is it supposed to work?
Have I answered your questions above?

If you want personalized help on this, please consider our Coaching Plan.

@justin808 It is in the Heroku dokumentation: https://devcenter.heroku.com/articles/rails-asset-pipeline "Adding public/assets to your git repository will make it available to Heroku..."
I don't need a Coaching Plan, but it would be great with a complete documentation, this part seems to be out of date: https://github.com/shakacode/react_on_rails/blob/master/docs/additional-reading/rails-assets-relative-paths.md, since I am using v8+...

@alfredvaa The Heroku docs are an inferior way.

Note: this doc needs updating to reflect how v8.x+ no longer puts Webpack generated files through the asset pipeline. PR's welcome!

We'd love a PR to help!

I guess that I kind of solved this for now. Instead of adding the precompiled assets to git, I let Heroku manage the precompilation. But for this to work there should not be a sprocets-manifest file in the public/assets folder added to git, so I had to remove that first (this should probably be added to .gitignore). I also had to set up buildpacks to use one for nodejs and one for ruby, but that is already in the docs for react on rails.


Too many api.rs codes generate very stuck

How to generate multiple files
https://github.com/cunarist/flutter-rust-app-template
Or like him, no need to generate, pass the specified logo

There are some PRs related to multi-file:

#1205
#1145

Will those work for your scenario?

Thank you

@107295472, Currently, the tutorial for multi-blocks is here. But don't use customized-defined structs at present, or an issue will appear.


Missing Contributing.md file

Description:
The repository is missing a CONTRIBUTING.md file, which is essential for guiding contributors on how to properly contribute to the project. This file typically outlines important guidelines, such as how to report issues, create pull requests, code style conventions, and other contribution practices.
Tasks:

[ ] Create a CONTRIBUTING.md file.
[ ] Include sections for:

Contribution guidelines (pull requests, issues, feature requests).
Code style and formatting rules.
Branching and commit message conventions.
Testing requirements before submitting code.
How to set up the development environment (if needed).
Any other project-specific instructions.

[ ] Review with the project maintainers and refine the guidelines.

Please @07sumit1002 assign me this task with label "GSSOC-Ext", "Hacktoberfest-accepted" and "level1".

@07sumit1002 please assign me the label "Hacktoberfest-accepted"

Hey @07sumit1002 please assign me the labels again as it is showing up in my hacktoberfest repo
"GSSOC-Ext", "hacktoberfest-accepted" and "level1"
I'm sorry for inconviences.


Unable to use interpolation without Vue

One of useful features of this library is an ability to use it both for Vue and non-vue parts of application.
Unfortunately, there is no ability to use interpolation in there.
I think, it would be great to expose the gettextInterpolate method as well.

Resolved


ENH: add global meta data

Based on the discussion in https://github.com/bilby-dev/bilby/pull/867, I've made a start on a possible implementation of a global meta data object.
For now, it's just a singleton dictionary that, by default, tracks the rng. Things like the cosmology can then be added when they're set.
I still need to test this properly, but hopefully it gives us something to discuss.

The tests are going to fail until https://github.com/bilby-dev/bilby/pull/867 is merged, since it adds support for properly saving the cosmology objects


'ui-sref' of Angular UI-Router not working as expected

If I am working with href, UI Router works as expected. But, if I am using ui-sref, it is not working as expected.
I have two issues with the following example:

the anchors 'link-series-2-no-param' and 'link-series-2-one-param' do not trigger 'otherwise' (they do in 'link-series-1'). What to do if they need to go to 'otherwise'?

if you click all 'link-series-2' and do the same in reverse, it's not going to work (always shows the result of 'link-series-2-two-params', even if you click on others)

I am unable to properly format the code here and I posted code at:
http://stackoverflow.com/questions/41429784/ui-sref-of-angular-ui-router-not-working-as-expected

That is expected behavior.  ui-sref uses inherit: true by default, which inherits the current parameter values when navigating.
Use ui-sref-opts="{ inherit: false }" or explicitly nullify the params you do not want to inherit ui-sref='foo({ param1: 1, param2: null })'

use ui-sref-opts="{inherit: false}" it works, thx


rest.api

hello,
I finished both sides for the beginning. flask is working in local (5000) I sent ping and its turning pong.
after that, I finished the second part but they are not speaking with each other. There is no text on the button . both of them is working separately but they are not working at the same time what is my fault. if you can help me I will be so appreciated

ı found the problem if I copy the script on Ping.vue and I paste the App.vue it is working server and rest.api is working together but if I put the script on the Ping.vue I think router.js is not working how can I fix this


Create a Proposal Process read-me

This PR does add a readme about the proposal process into the proposal process directory.
Reviewers

Comment on the idea of asking for 2 approvals since these changes are supposed to be significant. Could be convinced to keep our 1 approver rule.

Re: 2+ reviewers, I don’t have a strong opinion since I don’t feel I really know what the team’s current bandwidth is. In general, I think it seems reasonable since you have a dedicated team and a major design should usually require more feedback.

Re: 2+ reviewers, I don’t have a strong opinion since I don’t feel I really know what the team’s current bandwidth is. In general, I think it seems reasonable since you have a dedicated team and a major design should usually require more feedback.


Macros require explicit use gfx; in Rust 2018

This is only a small thing and I'm not sure if it's worth an issue, but it took me a while to figure out how to make my code compile. I'm also a beginner with gfx-rs.
Rust 2018 got rid of extern crate and made some changes to how paths are interpreted in use-statements. From a submodule and by default, you can't access gfx via use super::gfx; anymore, but this is what some macros (like gfx_pipeline!) are trying which results in a compiler error. You have to explicitly use gfx; in the top-level-module to make the compiler happy which I think shouldn't be needed.
Try this with Rust 2018:
use gfx; // shouldn't be necessary
use gfx::*;

gfx_defines! {
    vertex Vertex {
        pos: [f32; 2] = "a_Pos",
        color: [f32; 3] = "a_Color",
    }

    pipeline Pipeline {
        vbuf: VertexBuffer<Vertex> = (),
        out: RenderTarget<gfx::format::Srgba8> = "Target0",
    }
}

fn main() { }

This issue is about the pre-ll API, which is no longer updated. The new gfx-hal macros properly refer to the hal crate without requiring use gfx


[Question] When executing the code in examples, is it necessary to enable the runtime of the tcp protocol?

Search before asking

[X] I had searched in the issues and found no similar issues.

Question
When I run http.demo, if the runtime only supports the HTTP protocol, the subscribe process will not start.
Actually I found that this is a problem caused by the spring sample code. Because the startup of SpringSourceConnector relies on the TCP protocol as runtime.
If I understand wrong please give me some hints.

@pandaapo 目前spring connector和http demo中都有一个springboot的启动方式，而启动http demo中的SpringBootDemoApplication时，它会自动扫描spring.pub包中的SpringSourceConnector，而这个connector将会依赖于tcp协议的runtime。
如果我只启动http协议的runtime，那么SpringBootDemoApplication将无法正常运行。

@pandaapo sorry,i make a mistake.SpringConnectServer implement CommandLineRunner, and so after running SpringBootDemoApplication main method ,it will call org.apache.eventmesh.connector.spring.server.SpringConnectServer#run no soon.

Would you be willing to submit an issue and PR to fix this problem? Including the same problems in other examples.

It's my pleasure.