Create Best Practices doc

We need a place where we can establish and document best practices for chart creation. This should then be reference from the README in order to point users to this repositories conventions.

Things that need to be discussed:

[ ] Upgrading
[ ] Configuration files
[ ] Command line flags

Thanks for capturing this @viglesiasce. @sameersbn put together a great set of kubernetes manifest and helm chart authoring guides (https://github.com/bitnami/charts/tree/master/_docs) that could provide a base for something.

The one thing that has been bugging me is docker standards.  @viglesiasce we probably need to get together with a couple of people to discuss, or we can hijack a sig apps.

A doc for us to collaborate on: https://docs.google.com/document/d/120IobQc4Q1__wSL5XZ7cSJEm2LDePoamUbX6N9SVuBA/edit?usp=sharing

@michelleN should we set 15 min in the helm sig or sig-apps to knock this out? I am knee deep in writing the HA upgrade guide, so I am not sure how we can knock this out.

@chrislovecnm have a look at the technical requirements that I bolstered today. I think it will be best to just build out that section in the docs:
https://github.com/kubernetes/charts/blob/master/CONTRIBUTING.md#technical-requirements

Nice! Added a bunch of notes to the doc.

We need a linter to check for that stuff btw

For ease of reading

camel case vs uppercase for vars
Helper templates and other toyaml kungfu
Use docker's from main product? Redis maintains there own docker
Where do we put Dockerfiles in the repo?
Break up docker name and version number
Sections for the Readme - template?
How are we going to name charts that have multiple variants
For example Redis without ha, redis with slaves, redis clustered
Do we have one massive nasty chart or three charts?

Also upgrades are not supported by Petsets... Just a note to the section

My pet list of things to consistify, after reading through a good number of these charts:

values.yaml flat vs nested/grouped
yaml list indention or flat
standard ways to define resource limits (I like what we're seeing with the toYaml method, subjectively)
comment style (two hashes vs 1)
documenting things in values.yaml and/or README.md. afraid to duplicate right now.
outlined expectations on when ConfigMaps are expected.
guidance on standard PVC usage patterns
since AWS ELBs can't forward UDP, we should have a standard pattern for Services and a blurb for NOTES.txt (NodePort?)

My best practice recs:

static container names

if one container, use {{ template name . }}
if multiple, use {{ template name . }}-{{ .Values.container1.name }}, {{ template name . }}-{{ .Values.container2.name }}, etc.

app labels on resources should also use {{ template name . }} instead of current {{ template fullname . }} pattern
charts that consist of multiple "components" should assign static component labels to the respective resources

component services should also have component as a selector

I explained my reasoning for the first two items in #168 (specifically here, here, and here).
The last item is a pattern I use at work, explained here.

I would like to add a best practice item. I would love to see the recommendation and practice of using a global property
persistence:
  enabled: true/false

in all official stable charts that completely disables PVs/PVCs in the main Chart and Dependent charts.
Why?
On k8s clusters with no PVs you have to go figure out what non standard parameters disable the PVC for each snowflake chart values and then also for the its dependencies. This is true e.g. for existing charts like WordPress in K8s Stable (you need to turn off PVs for MariaDB specifically).
In my view, this is a UX problem for newbies using the official Stable charts because on a cluster like "kube-solo" or "minikube", that many start on, there are no PVs and in those cases there will never be a mixed situation where part of the chart should have PVs. If this became a standard (you should also be able to individually turn chart PVCs off or on) it will undoubtedly mean less grief for users and chart maintainers...
Also, if this became a best practice standard then perhaps this could be added as a Helm install option (further improving UX).

I would like to add a best practice item request... I would love to see the recommendation and practice of using a global property

I'm a big -1 on this, as outlined in the matching discussion on the gitlab-ce PR:
https://github.com/kubernetes/charts/pull/202#issuecomment-260711737
tl;dr: Some charts like factorio, gitlab, and even Cassandra store various bits of data in different places. There are cases when some of your users might want persistence for one, but not the other.
I think our policy of sane defaults covers the split, in that users with special needs will read the chart README/values and adjust as needed.

@gtaylor did you read my answer on #202? The use case is clusters with no persistent storage which right now are pretty much all out of the box do-it-yourself dev cluster like minikube, kube-solo, kube-cluster and I'm suggesting having both flags per dependency and a global, not either or. So more flexible.

Another one for this list:
Ensure repository (not just tag) is configurable.
https://github.com/kubernetes/charts/pull/276/files

Echoing what @mgoodness said above, app labels are problematic (and long) when they include the release, I've also noticed that many charts don't have an app label either.  We've needed to add component labels to various charts also so that we can select pieces to use with kubectl port-forward, etc.  I also add the release label to selectors for specificity there.
Example changes for the prometheus server service:
@@ -2,7 +2,7 @@
 kind: Service
 metadata:
   labels:
-    app: {{ template "fullname" . }}
+    app: "{{ .Chart.Name }}"
     chart: "{{ .Chart.Name }}-{{ .Chart.Version }}"
     component: "{{ .Values.server.name }}"
     heritage: "{{ .Release.Service }}"
@@ -15,6 +15,7 @@
       protocol: TCP
       targetPort: 9090
   selector:
-    app: {{ template "fullname" . }}
+    app: "{{ .Chart.Name }}"
+    release: "{{ .Release.Name }}"
     component: "{{ .Values.server.name }}"
   type: "{{ .Values.server.serviceType }}"

I'd like to know what the best practices are for indicating whether values are required or optional.

In addition to my previous suggestions, I've taken to changing the fullname template in my internal charts. Rather than having it generate RELEASE_NAME-CHART_NAME, it's flipped to CHART_NAME-RELEASE_NAME. If a chart handles multiple components, I'll do something like CHART_NAME-COMPONENT-RELEASE_NAME. I find it's easier to view multiple releases of the same chart in kubectl when using that pattern.

Pod name should have an identifier

Pod names should include both the release name and chart name. When using a chart as a dependency its good to be able to distinguish pods that belong to the same release.
@prydonius,
Do we have a macro for this yet or is the _helper template for "fullname" the best we have right now?

@viglesiasce the fullname template is the best we have for now, see https://github.com/kubernetes/helm/issues/1186 - looks like it's slated for 2.3.0

would it make sense to say:

it is preferred to include defaults in a packaged values.yaml over using the default function in the manifest templates?

it seems having default everywhere in a template makes it less readable, and a secure default values.yaml needs to be provided according to the technical requirements anyway?
(plus, you can see a lot of documentation is added to most stable chart values.yaml - which is a single place to look instead of that information being spread over the files in templates folder)
I've tried to take into the comments in this thread, as well as Bitnami's documentation into conventions for my company - https://gist.github.com/so0k/f927a4b60003cedd101a0911757c605a

Checksum your configs in an annotation on your deployments so that config changes can automatically update your pods:
annotations:
        checksum/config: {{ include (print $.Chart.Name "/templates/configmap/spinnaker-config.yaml") . | sha256sum }}

@viglesiasce k8s configmaps mounted in volumes are updated and fire inotify... I think the above is more applicable for secrets (I'm not sure about configmaps referenced in env vars)

@so0k I think exceptions can (should?) be made for applications that monitor filesystem events and reload their configuration. But for the majority of cases, it's helpful to force a re-deploy when ConfigMaps and/or Secrets change.

Standardize (to the extent possible) how Ingresses are created. It's the wild west out there!

some I've hit recently:
Need a way to set nodeSelectors on templates. Otherwise, arrangement is completely random, which fails on nonuniform clusters.
For svc's, I would like a way to set the external_ip on them so I can access them outside the cluster without having to setup an ingress.

summary
For Helm Charts to really take off as a standard way of managing k8s deployments, I think it is important for chart consumers to understand the usage patterns any Best Practices are designed to work best with.

[...] Pod names should include both the release name and chart name. When using a chart as a dependency its good to be able to distinguish pods that belong to the same release.

I sort of understand using  this pattern with deployment/rs/rc/pod/etc names; though, I must say that I have gotten used to using label filters rather than relying on kubectl's default get output.
Specifically, with services, names such as chartname-flinging-monkey don't work.  (I also have taken to putting the chartname before the release name)  Even with specifically named releases, names end up similar to 'component-dev-feature-YYZ420`.
e.g.: I have a telegraf daemonset that exposes its statsd service to the cluster. One of the modifications I made to the telegraf chart was to set .metadata.name to match the exposed service port.
Before:
dig +search +short _statsd._udp.telegraf-ds-prod-monitor.monitors SRV
after
dig +search +short _statsd._udp.statsd.monitors SRV
It gets even uglier when dealing with service configuration data via the container environment. (not terribly useful for inter-namespace work but stil)
With that said, I'm also interested in understanding the production context that this pattern comes from.  The pattern seems to run counter to maintaining loose coupling between resources and components.  I'm fairly certain my perception is due to not understanding and not any lack of wizardry on the part of the implementors.

Best practices for naming of template partials is discussed here: https://github.com/kubernetes/helm/issues/1688

Exposing the resource-policy annotation on PV/PVC is covered here: https://github.com/kubernetes/helm/issues/1875

The summary provided by @so0k gist actually summarise most of the things we talked here + what I have seen in multiple charts in kubernetes repo.
In our startup, right now, we are converting our kubernetes yaml files by writing a lot of charts. We are planning to use @so0k gist for now.

Also, we follow "if you want best practices followed by most people, you should provide practical implementation & common use case examples" in our company.
For that, we are thinking about using "includes" or "blocks" for common labels and names patterns such as app, heritage, release, chart, component. Maybe templates for container-name, service-name... . So that we don't need to remember or copy-paste each time to follow the best practices.

I'd like to make small adjustments (haven't applied these back to the gist):

File naming convention, Prefix the files with the name of the Chart component only makes sense if there are more than 1 component, to make a more re-usable chart base apps with a single component should have an agreed prefix (none or app-)
I do find the default fullname template to be useful sometimes... I think my understanding of the way the subchart is referenced was a bit wrong and you still need to re-define the scoped fullname template in the parent chart anyway
My argumentation for nested hierarchies kind of falls away when you always have to document all options in values.yaml (and this is preferred over sprinkling  | default in the templates.

For helm,
Are everyone @viglesiasce @mgoodness @technosophos is on the same page about improving up on @so0k gist and adding it to the docs as best_practices.md?
@so0k What do you think about providing includes, block or templates for best practices you summarised?
Sorry for bugging you all with many messages, I wanted helm charts move forward before we move everything to helm charts

includes / blocks / templates for best practices such as the labels sounds good - there must already be charts out there that follow this practice?
ps, I personally also like the following snippet I saw in one of @ohaiwalt charts:
This converts snake-cased maps in the values.yaml to environment variables:
# values.yaml
config:
  kelsey-rating: "pretty dope"
  env: gcpug
  asset-pipeline: false

# manifest template fragment
env:
{{- range $key, $value :=  .Values.config }}
- name: {{ $key | upper | replace "-" "_" }}
  value: {{ $value | quote }}
{{- end }}

# rendered template fragment:
env:
- name: ASSET_PIPELINE
  value: "false"
- name: ENV
  value: "gcpug"
- name: KELSEY_RATING
  value: "pretty dope"

Example chart from a workshop I gave last week.

...to make a more re-usable chart skeleton... apps with a single component should have an agreed prefix (none or app- ?)

None IMHO, because multi component charts are app as a whole too.

I do find the default fullname template to be useful sometimes... I think my understanding of the way the subchart is referenced was a bit wrong and you still need to re-define the scoped fullname template in the parent chart anyway

I saw charts with multi components have scoped fullname s for naming components yamls with their own names, like here.
For subcharts, I didn't tried but subcharts fullname template will use parents chart .Chart and .Release, so it should be same fullname in parent and sub charts as I remember from docs.

My argumentation for nested hierarchies kind of falls away when you always have to document all options in values.yaml (and this is preferred over sprinkling | default in the templates). ...

I don't like default in the templates too, Defaults should be given in values.yaml for having them on one place.

@so0k
I am just writing followings for demonstration purposes
for deploy.yaml
...
metadata:
  name: {{ template "deployment-name" .}}
  labels:
{{ include "labels" . | indent 4 }}
spec:
  template:
    metadata:
      labels:
{{ include "labels" . | indent 8 }}
    spec:
      containers:
      - name: {{ template "container-name" .}}
...

Why we may use many templates even if they follow the same pattern: They may be just alias for readability.
For multi component case, we may have these templates scoped.
Reason why we use includes instead of templates for labels here

@so0k Also, the implication here is we should have labels (app, heritage...) and names (name, fullname and different patterns) same as best practices at the _helpers.tpl.
Chart developer can add their own labels directly to the yaml templates just over the {{ include "labels".... We don't add limit them, we just make it easy to follow conventions.

@technosophos added best practices guide at kubernetes/helm#2007 for helm 2.3

I hadn't seen it before - thanks for the link!
So we can PR on those documents to add sample templates for default labels?

That's also news to me. Give us maintainers a chance to review and decide if we want to adopt those as the best practices for this repo. We'll also want to consider all the suggestions/requests made in this thread.

For first point of @mgoodness, I invite everyone to kubernetes/helm#2007 for reviewing current state of the guide. I believe we have still time for little changes until 2.3 on that PR.
Then we should shape&move suggestions here by discussing over a new PR at kubernetes/helm.
Unsuprisingly, @so0k gist mostly overlap with best practices guide but also includes additional suggestions that can be added as additional parts to the guide. I believe it is a good starting point for our new PR.
@so0k if you are willing to work on this, we can work together on that new PR and everyone is welcome.
Our plan is maybe:

[ ] Extract differences between guide and gist

[ ] For each difference, discuss rationale, benefits, and drawbacks

[ ] Fork and write results cleanly
[ ] Open a PR and ref here to discuss with everyone
[ ] Scan this thread for different suggestions and ref them on PR

If anyone(esp. @so0k) want to join me (actively), I want to work on this together

After best practices shaped more clearly, we can add suggestive comments and recommended templates to the default starter pack with another PR in the future. (@so0k That is better place to discuss including one template for recommended labels I mentioned before)

Hey everyone, where is the best place to address yaml indentation inconsistencies across the stable charts?
For example, is there a standard for YAML array indentation?
- One
- Two

vs
  - One
  - Two

Both are legit, but most docs I see across projects (eg Symfony) use the second. Does charts have a standard?
I was talking with @prydonius about YAML linting - he noted https://yamllint.readthedocs.io/en/latest/rules.html#module-yamllint.rules.hyphens (personally, I am an advocate for indentation: {spaces: 2, indent-sequences: consistent}, but really whatever the standard, as long as it’s consistent). Perhaps we could do as an automated PR check in the charts repo? But in either case, it seems this would be a good helper command in helm.
I noticed this was raised this comment https://github.com/kubernetes/charts/issues/44#issuecomment-256472424 and also in https://github.com/kubernetes/helm/issues/1663. I sought this out as a response to https://github.com/kubernetes/charts/pull/920. I'll be happy to follow up wherever is best, if anyone has a good idea of where to go with this?

Should this be closed with the introduction of https://docs.helm.sh/chart_best_practices/#the-chart-best-practices-guide?

@bacongobbler That makes sense. And we can continue to discuss these topics in separate issues/PRs against https://github.com/kubernetes/helm/tree/master/docs/chart_best_practices?

/remove-lifecycle rotten
/remove-lifecycle stale

/remove-lifecycle rotten


Doesn't open mail app

Does seem to do it here, and no prints show after result. Any ideas? Im on Android 8 on samsung s7

Code sample? What installed mail apps are on your device? Also see #10

Code sample? What installed mail apps are on your device? Also see #10


getting started

Hi Anthony, none of your code challenges pass at this time. Each challenge is worth 1.25 points. Please complete and re-submit for additional credit. Thanks!


Potential to miss file download sequences

Potential to miss file download sequences
From @kb1ooo

I think that there might be another potential point of failure. Since the escape sequences are multi-character, isn't there a possibility that they (more likely FILE_END if it's going to happen) can get split across data buffers? In that case, the current implementation would appear to miss the marker because it's expecting it to be contiguous in the data buffer. I.e. data.indexOf(FILE_END) would never return anything but -1. I know next to nothing about terminals (nor about javascript) so I could be totally wrong, maybe you are guaranteed that those sequences are contiguous?

We need to look into how we can guarantee we won't miss the FILE_BEGIN or FILE_END sequence of characters if they're split up over multiple data calls.
Thanks to @kb1ooo for pointing this out! :D
I'd also like to point out the likelihood of something like this happening is probably quite low - at the very least worth discussing :)

@butlerx, I'm happy for you to assign this to me :)

@benletchford I've been working on a fix for this, mostly because I made a change to accommodate the gnu screen issue and figured I'd work on this as well.    As I got into it, I realized that there are actually a few more corner case (and not so corner case issues).

Data in the buffer, but outside the begin/end delimiters, is lost (i.e. not written to the terminal).
A FILE_BEGIN sequence that occurs after a FILE_BEGIN but before a FILE_END is not handled properly.  Or similarly a FILE_END that occurs before a FILE_BEGIN has occurred is not ignored.
There may be multiple segments that occur within a single buffer and that is not handled.

I've fixed these 3 issues.  But the original problem (a marker may be split across multiple buffers) is a bit tricky to get right.  Let me know if you've started on this or how far you've gotten.

@benletchford oops I missed your fix.  I will take a look.

Appreciate the fix @benletchford, pushed version working well on my end.  To work around my gnu screen issue (if you recall I mentioned before that gnu screen buffers with multiple beg/end sequences) I added a character to the begin end sequences that wetty is looking for and then remove all the extra begin/end sequences from the buffer in the onCompleteFileCallback.  So in src/client/download.ts
-const DEFAULT_FILE_BEGIN = '\u001b[5i';
-const DEFAULT_FILE_END = '\u001b[4i';
+const DEFAULT_FILE_BEGIN = '\u001b[5i[';
+const DEFAULT_FILE_END = '\u001b[4i]';

And then in src/client/index.ts
   const fileDownloader = new FileDownloader((bufferCharacters: string) => {
     let fileCharacters = bufferCharacters;
+    const FILE_BEGIN_SEG = '\u001b[5i';
+    const FILE_END_SEG = '\u001b[4i';
+
+    fileCharacters = fileCharacters.split(FILE_BEGIN_SEG).join('');
+    fileCharacters = fileCharacters.split(FILE_END_SEG).join('');

Just changes adding a character to the sequences in the script to initiate the download.  Actually, I have a suggestion in the example script to use octal codes instead of embedding the escapes because if you cat the script it will initiate a download.   I post a separate issue.
Thanks,
kb1ooo


redefinition of 'g_param_spec_unref'

With latest GObject we get this error.

We tried to fix that. Please test with
nimble uninstall gintro
nimble install gintro@#head


New game added - Hangman_game

PR Description 📜
I added a new word set to the repository
Fixes #2892

Mark the task you have completed ✅

[x] I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
[x] I have performed a self-review of my own code or work.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] My changes generates no new warnings.
[x] I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
[x] I have added screenshot for website preview in assets/images
[x] I have added entries for my game in main README.md
[x] I have added README.md in my folder
[x] I have added working video of the game in README.md (optional)
[x] I have specified the respective issue number for which I have requested the new game.

Add your screenshots(Optional) 📸

Thank you soo much for contributing to our repository 💗

Thank you @D4vc-198 ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

Thank you  @D4vc-198 , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀


EKUBO

EKUBO: dimples. From Japanese.
https://www.memrise.com/en-us/learn-japanese/japanese-course/phrasebook/65575566770434/how-to-say-dimple-in-japanese
Charl confirms. One more?

Meral di diak a mo uai kau / er a renguk sel kulebedebek / Engedel a medam me aikel osengem / a luldak er a ekubo

Confirm.
On Wed, Apr 24, 2024 at 13:14 JimGeselbracht @.***>
wrote:

Meral di diak a mo uai kau / er a renguk sel kulebedebek / Engedel a medam
me aikel osengem / a luldak er a ekubo
—
Reply to this email directly, view it on GitHub
https://github.com/tekinged/missing/issues/493#issuecomment-2075762678,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AF2DJJFAZPA3VQU5AVAFTK3Y7AHCJAVCNFSM6AAAAABGXOAJT2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANZVG43DENRXHA
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


Nested multiple router outlets

Hello guys,
Thanks for your great job. I am trying to create an app which i need to have multiple templates structure. Inside of each template i will have nested router-outlets. Is there any way to work like this ? Check a live example (https://plnkr.co/edit/GSY4dvSFTOxXZMBgR6lF?p=preview). This code not works cause i can't complete it, just get the vision.
Thank you very much for your time.

@gtzinos Is there a repo with the project generated from CLI where you are getting this issue.

Hello @sumitarora i sent you a url of a plnkr project.

Hello, we reviewed this issue and determined that it doesn't fall into the bug report or feature request category. This issue tracker is not suitable for support requests, please repost your issue on StackOverflow using tag angular-cli.
If you are wondering why we don't resolve support issues via the issue tracker, please check out this explanation.

https://github.com/angular/angular-cli/issues/6152#issue-225699378

I have the same problem. How to resolve it?


Update<PHONE_NUMBER>1.lua

fixes the survival game killaura

Committed

Committed

why didn't you merge it :skull:

fr


Working with s3

I am trying to figure out the best way to use this with s3.   Before I initiate a s3 download I want to check to see if it's in cache.   If not then I will download
Thoughts?

If you are looking to simply check the cache to see if an image already exists, you can use the HNKImageCache method, -fetchImageForKey:formatName:success:failure:. See here. It will return NO if an image is not cached, and you will then be able to download however you choose.

I believe this is the default behavior of using HNKCache with HNKNetworkFetcher (which all the built in URL setting categories do). HNKCache will only do the fetch if the image has not already been downloaded and cached.

@bdorfman My guess is that @mdaymond is wanting to use access the UIImage outside of a UIImageView. I looked at the code for HNKNetworkFetcher and it doesn't appear to have any caching logic in there.
But yeah, from what I could understand HNKImageCache would work fine for his check, and then use HNKNetworkFetcher to download the image if it's not cached.

The caching logic is all on HNKCache. You don't need to check anything manually, it will do it by default for you if you use fetchImageForFetcher:formatName:success:failure: and use an HNKNetworkFetcher with the URL you desire as the fetcher param. It will give the UIImage back to you in the success block.


Error Code 400

The thing crashed after some time like a hour or so with the error 400

Hello @Dasher-Minecraft , could you provide logs for the occurrence please ?
Note: All 400's errors are logged to ./app/debug.log if the DEBUG setting is enabled in your config file.


Full MSVC support and bug fixes.

Why
Closes #18
Made this repo available to MSVC.
What is changing
Added:

util/magic_names.hpp
util/meta_string.hpp
A uniform MSVC/GCC/Clang implementation of reflecting qualified function names.
A meta_string class for template programming as non-type parameter when enabling C++20.

Added:

util/benchmark
util/examples
util/tests
Some static asserts for ensuring correctness of newly added code.

Modified/Fixed:

coro_rpc: CMakeLists.txt
coro_rpc/tests/ServerTester.hpp
coro_rpc/tests/test_coro_rpc_server.hpp
util/function_name.h
.gitignore
Fixed fatal issues when compiling with MSVC.
Fixed incorrect function names when using MSVC.
Added .gitignore items for .vs/out folders.

All unit tests have passed on MSVC 19.3x/GCC11.x/12.x/Clang 15+.
Core logics have passed on GoldBolt.
Example
Please view src/util/tests

@PikachuHyA Please review. Appreciate.

MacOS lack of std::ranges support, you could replace std::range with STL algorithm.

/Users/runner/work/yalantinglibs/yalantinglibs/include/util/meta_string.hpp:118:46: error: invalid operands to binary expression ('std::string_view' (aka 'basic_string_view<char>') and 'std::string_view')
  return static_cast<std::string_view>(left) <=>

It seems that Apple Clang don‘t implement the operator<=> in std::string_view……
For workaround, could we just remove it?

MacOS lack of std::ranges support, you could replace std::range with STL algorithm.

OK. I have fixed this. Apple Clang complained no support for the spaceship operator and I am working around it.

/Users/runner/work/yalantinglibs/yalantinglibs/include/util/meta_string.hpp:118:46: error: invalid operands to binary expression ('std::string_view' (aka 'basic_string_view<char>') and 'std::string_view')
  return static_cast<std::string_view>(left) <=>

It seems that Apple Clang don‘t implement the operator<=> in std::string_view…… For workaround, could we just remove it?

Emmm... a broken heart.. lol  I'm working in process for it.

It seems thar the Clang14 in Ubuntu 20.04 crashed.
[ 98%] Building CXX object src/util/tests/CMakeFiles/util_tests.dir/static_asserts.cpp.o
PLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ and include the crash backtrace, preprocessed source, and associated run script.
Stack dump:
0.	Program arguments: /usr/bin/clang++ -I/home/runner/work/yalantinglibs/yalantinglibs/include -O3 -DNDEBUG -std=gnu++20 -MD -MT src/util/tests/CMakeFiles/util_tests.dir/static_asserts.cpp.o -MF CMakeFiles/util_tests.dir/static_asserts.cpp.o.d -o CMakeFiles/util_tests.dir/static_asserts.cpp.o -c /home/runner/work/yalantinglibs/yalantinglibs/src/util/tests/static_asserts.cpp
1.	/home/runner/work/yalantinglibs/yalantinglibs/src/util/tests/static_asserts.cpp:77:1: current parser token 'void'
2.	/home/runner/work/yalantinglibs/yalantinglibs/src/util/tests/static_asserts.cpp:4:1: parsing namespace 'refvalue'
3.	/home/runner/work/yalantinglibs/yalantinglibs/src/util/tests/static_asserts.cpp:5:26: parsing function body 'refvalue::tests::meta_string_tests'
Stack dump without symbol names (ensure you have llvm-symbolizer in your PATH or set the environment var `LLVM_SYMBOLIZER_PATH` to point to it):
/lib/x86_64-linux-gnu/libLLVM-14.so.1(_ZN4llvm3sys15PrintStackTraceERNS_11raw_ostreamEi+0x31)[0x7f333812ad01]
/lib/x86_64-linux-gnu/libLLVM-14.so.1(_ZN4llvm3sys17RunSignalHandlersEv+0xee)[0x7f3338128a3e]
/lib/x86_64-linux-gnu/libLLVM-14.so.1(_ZN4llvm3sys15CleanupOnSignalEm+0xfb)[0x7f333812a0ab]
/lib/x86_64-linux-gnu/libLLVM-14.so.1(+0xd6bdff)[0x7f3338056dff]
/lib/x86_64-linux-gnu/libc.so.6(+0x42520)[0x7f3336dd2520]
/lib/x86_64-linux-gnu/libc.so.6(free+0x69)[0x7f3336e354c9]
/lib/x86_64-linux-gnu/libclang-cpp.so.14(+0x1[127](https://github.com/alibaba/yalantinglibs/actions/runs/3375003050/jobs/5601226001#step:5:128)671)[0x7f333ece4671]
/lib/x86_64-linux-gnu/libclang-cpp.so.14(_ZN5clang4Sema30PopExpressionEvaluationContextEv+0x7ce)[0x7f333ef9b5be]
/lib/x86_64-linux-gnu/libclang-cpp.so.14(_ZN5clang4Sema23ActOnFinishFunctionBodyEPNS_4DeclEPNS_4StmtEb+0x1a32)[0x7f333ee54c62]
/lib/x86_64-linux-gnu/libclang-cpp.so.14(_ZN5clang6Parser26ParseFunctionStatementBodyEPNS_4DeclERNS0_10ParseScopeE+0x118)[0x7f333e668878]
/lib/x86_64-linux-gnu/libclang-cpp.so.14(_ZN5clang6Parser23ParseFunctionDefinitionERNS_17ParsingDeclaratorERKNS0_18ParsedTemplateInfoEPNS0_18LateParsedAttrListE+0xddf)[0x7f333e68259f]
/lib/x86_64-linux-gnu/libclang-cpp.so.14(_ZN5clang6Parser14ParseDeclGroupERNS_15ParsingDeclSpecENS_17DeclaratorContextEPNS_14SourceLocationEPNS0_12ForRangeInitE+0x1210)[0x7f333e5dacc0]
/lib/x86_64-linux-gnu/libclang-cpp.so.14(_ZN5clang6Parser30ParseDeclOrFunctionDefInternalERNS_25ParsedAttributesWithRangeERNS_15ParsingDeclSpecENS_15AccessSpecifierE+0x35b)[0x7f333e6815ab]
/lib/x86_64-linux-gnu/libclang-cpp.so.14(_ZN5clang6Parser36ParseDeclarationOrFunctionDefinitionERNS_25ParsedAttributesWithRangeEPNS_15ParsingDeclSpecENS_15AccessSpecifierE+0x190)[0x7f333e681060]
/lib/x86_64-linux-gnu/libclang-cpp.so.14(_ZN5clang6Parser24ParseExternalDeclarationERNS_25ParsedAttributesWithRangeEPNS_15ParsingDeclSpecE+0x92a)[0x7f333e6804da]
/lib/x86_64-linux-gnu/libclang-cpp.so.14(_ZN5clang6Parser19ParseInnerNamespaceERKN4llvm11SmallVectorINS0_18InnerNamespaceInfoELj4EEEjRNS_14SourceLocationERNS_16ParsedAttributesERNS_24BalancedDelimiterTrackerE+0xbc)[0x7f333e5eecbc]
/lib/x86_64-linux-gnu/libclang-cpp.so.14(_ZN5clang6Parser19ParseInnerNamespaceERKN4llvm11SmallVectorINS0_18InnerNamespaceInfoELj4EEEjRNS_14SourceLocationERNS_16ParsedAttributesERNS_24BalancedDelimiterTrackerE+0x1b5)[0x7f333e5eedb5]
/lib/x86_64-linux-gnu/libclang-cpp.so.14(_ZN5clang6Parser14ParseNamespaceENS_17DeclaratorContextERNS_14SourceLocationES2_+0x14b9)[0x7f333e5ee809]
/lib/x86_64-linux-gnu/libclang-cpp.so.14(_ZN5clang6Parser16ParseDeclarationENS_17DeclaratorContextERNS_14SourceLocationERNS_25ParsedAttributesWithRangeEPS2_+0x41e)[0x7f333e5d488e]
/lib/x86_64-linux-gnu/libclang-cpp.so.14(_ZN5clang6Parser24ParseExternalDeclarationERNS_25ParsedAttributesWithRangeEPNS_15ParsingDeclSpecE+0xc4)[0x7f333e67fc74]
/lib/x86_64-linux-gnu/libclang-cpp.so.14(_ZN5clang6Parser17ParseTopLevelDeclERNS_9OpaquePtrINS_12DeclGroupRefEEEb+0x3ad)[0x7f333e67eb1d]
/lib/x86_64-linux-gnu/libclang-cpp.so.14(_ZN5clang8ParseASTERNS_4SemaEbb+0x2fd)[0x7f333e5c18ed]
/lib/x86_64-linux-gnu/libclang-cpp.so.14(_ZN5clang13CodeGenAction13ExecuteActionEv+0xb1)[0x7f333f735b71]
/lib/x86_64-linux-gnu/libclang-cpp.so.14(_ZN5clang14FrontendAction7ExecuteEv+0x67)[0x7f33400d1b57]
/lib/x86_64-linux-gnu/libclang-cpp.so.14(_ZN5clang16CompilerInstance13ExecuteActionERNS_14FrontendActionE+0x336)[0x7f33400293a6]
/lib/x86_64-linux-gnu/libclang-cpp.so.14(_ZN5clang25ExecuteCompilerInvocationEPNS_16CompilerInstanceE+0x29b)[0x7f334014b45b]
/usr/bin/clang++(_Z8cc1_mainN4llvm8ArrayRefIPKcEES2_Pv+0x99b)[0x4[132](https://github.com/alibaba/yalantinglibs/actions/runs/3375003050/jobs/5601226001#step:5:133)8b]
/usr/bin/clang++[0x4114bc]
/lib/x86_64-linux-gnu/libclang-cpp.so.14(+0x20eaed2)[0x7f333fca7ed2]
/lib/x86_64-linux-gnu/libLLVM-14.so.1(_ZN4llvm20CrashRecoveryContext9RunSafelyENS_12function_refIFvvEEE+0xdd)[0x7f3338056b6d]
/lib/x86_64-linux-gnu/libclang-cpp.so.14(_ZNK5clang6driver10CC1Command7ExecuteEN4llvm8ArrayRefINS2_8OptionalINS2_9StringRefEEEEEPNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEEPb+0x140)[0x7f333fca79c0]
/lib/x86_64-linux-gnu/libclang-cpp.so.14(_ZNK5clang6driver11Compilation14ExecuteCommandERKNS0_7CommandERPS3_+0x3f3)[0x7f333fc72183]
/lib/x86_64-linux-gnu/libclang-cpp.so.14(_ZNK5clang6driver11Compilation11ExecuteJobsERKNS0_7JobListERN4llvm15SmallVectorImplISt4pairIiPKNS0_7CommandEEEE+0x8a)[0x7f333fc7240a]
/lib/x86_64-linux-gnu/libclang-cpp.so.14(_ZN5clang6driver6Driver18ExecuteCompilationERNS0_11CompilationERN4llvm15SmallVectorImplISt4pairIiPKNS0_7CommandEEEE+0x1a7)[0x7f333fc8c507]
/usr/bin/clang++(main+0x2816)[0x410f26]
/lib/x86_64-linux-gnu/libc.so.6(+0x29d90)[0x7f3336db9d90]
/lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0x80)[0x7f3336db9e40]
/usr/bin/clang++(_start+0x25)[0x40e3b5]
clang: error: clang frontend command failed with exit code [139](https://github.com/alibaba/yalantinglibs/actions/runs/3375003050/jobs/5601226001#step:5:140) (use -v to see invocation)
Ubuntu clang version 14.0.0-1ubuntu1
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/bin
clang: note: diagnostic msg:
********************

See : https://godbolt.org/z/1qzfT64nr
Crashed in Clang 14.0.0 & 12.0.0
Passed in Clang 15.0.0,13.0.1,12.0.1 & 12.0.0

See : godbolt Crashed in Clang 14.0.0 & 12.0.0 Passed in Clang 15.0.0,13.0.1,12.0.1 & 12.0.0

Appreciate your tests and I found x86-64 Clang crashed when there were too many static constexpr variables... and after removing the static token it compiled.

See : godbolt Crashed in Clang 14.0.0 & 12.0.0 Passed in Clang 15.0.0,13.0.1,12.0.1 & 12.0.0

Appreciate your tests and I found x86-64 Clang crashed when there were too many static constexpr variables... and after removing the static token it compiled.

It's not the problem of static constexpr variables...
See This simpifly example

See : godbolt Crashed in Clang 14.0.0 & 12.0.0 Passed in Clang 15.0.0,13.0.1,12.0.1 & 12.0.0

Appreciate your tests and I found x86-64 Clang crashed when there were too many static constexpr variables... and after removing the static token it compiled.

It's not the problem of static constexpr variables...
See This simpifly example

Ummm... I see, thanks.I tested this workaround and the designated Clang version passed my code.

See : godbolt Crashed in Clang 14.0.0 & 12.0.0 Passed in Clang 15.0.0,13.0.1,12.0.1 & 12.0.0

Appreciate your tests and I found x86-64 Clang crashed when there were too many static constexpr variables... and after removing the static token it compiled.

It's not the problem of static constexpr variables...
See This simpifly example

Ummm... I see, thanks.I tested this workaround and the designated Clang version passed my code.

LGTM

Created an issue to LLVM.

Some assertion failed in clang14 debug mode.
/home/runner/work/yalantinglibs/yalantinglibs/src/util/tests/static_asserts.cpp:118:3: error: static_assert failed due to requirement 'qualified_name_of_v<&func_template<int, double>> == refvalue::meta_string<58>{"refvalue::tests::ns1::ns2::ns3::func_template<int, double>"}'
  static_assert(
  ^
/home/runner/work/yalantinglibs/yalantinglibs/src/util/tests/static_asserts.cpp:135:3: error: static_assert failed due to requirement 'name_of_v<&func_template<int, double>> == refvalue::meta_string<26>{"func_template<int, double>"}'
  static_assert(name_of_v<&func_template<int, double>> ==
  ^             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

~

Got it. I am writing some cases to make sure what the signature of a function template is.

Some assertion failed in clang14 debug mode.
/home/runner/work/yalantinglibs/yalantinglibs/src/util/tests/static_asserts.cpp:118:3: error: static_assert failed due to requirement 'qualified_name_of_v<&func_template<int, double>> == refvalue::meta_string<58>{"refvalue::tests::ns1::ns2::ns3::func_template<int, double>"}'
  static_assert(
  ^
/home/runner/work/yalantinglibs/yalantinglibs/src/util/tests/static_asserts.cpp:135:3: error: static_assert failed due to requirement 'name_of_v<&func_template<int, double>> == refvalue::meta_string<26>{"func_template<int, double>"}'
  static_assert(name_of_v<&func_template<int, double>> ==
  ^             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Got it. I am writing some cases to make sure what the signature of a function template is.

PRETTY_FUNCTION does not contain template function arguments symbols, only contain function name, so i think we can't support template rpc function now, and i think it is acceptable.
So remove template function test case is fine.

I find a solution to support template function, i will improve this pr :)

I find a solution to support template function, i will improve this pr :)

Can we merge this PR first, and add it later?

I find a solution to support template function, i will improve this pr :)

Perfect; welcome to improve this code. lol

@refvalue please check these failed tests
https://github.com/alibaba/yalantinglibs/actions/runs/3383985039/jobs/5620424487

@refvalue please check these failed tests
https://github.com/alibaba/yalantinglibs/actions/runs/3383985039/jobs/5620424487

Alright. I am reviewing the report.

Alright. I am reviewing the report.

@refvalue After you fixed all failed tests. I will rerun CIs.

@PikachuHyA Emm... Sorry but the issue still exists...I will make a full test on x86 architecture to resolve this.

Is it only failed in x86? May be we can add it's support in next PR.

hmm, the test is timeout?
https://github.com/alibaba/yalantinglibs/actions/runs/3386262607/jobs/5625436568

@refvalue please check these failed tests
https://github.com/alibaba/yalantinglibs/actions/runs/3383985039/jobs/5620424487

hmm, the test is timeout? https://github.com/alibaba/yalantinglibs/actions/runs/3386262607/jobs/5625436568

Yeah..it seems that there are some issues on the lifetimes of io_context and coro test calls. I will try resolving them today.

@refvalue please check these failed tests
https://github.com/alibaba/yalantinglibs/actions/runs/3383985039/jobs/5620424487

hmm, the test is timeout? https://github.com/alibaba/yalantinglibs/actions/runs/3386262607/jobs/5625436568

Yeah..it seems that there are some issues on the lifetimes of io_context and coro test calls. I will try resolving them today.

No hurry, i will look at the failed cases at this weekend, maybe because of temporary variable life time when call rpc.

@refvalue please check these failed tests
https://github.com/alibaba/yalantinglibs/actions/runs/3383985039/jobs/5620424487

hmm, the test is timeout? https://github.com/alibaba/yalantinglibs/actions/runs/3386262607/jobs/5625436568

Yeah..it seems that there are some issues on the lifetimes of io_context and coro test calls. I will try resolving them today.

No hurry, i will look at the failed cases at this weekend, maybe because of temporary variable life time when call rpc.

Fine.

Could you rebase the branch: fix_for_msvc?

Could you rebase the branch: fix_for_msvc?

Sure. I'll rebase my local branch.

Not ready

Do it later, not ready now.

There is a bug in asio on windows, we can continue support msvc after fixing the bug.
But your PR can be merged firstly, please rebase main, i will merge this PR.

There is a bug in asio on windows, we can continue to support msvc after fixing the bug. But your PR can be merged firstly, please rebase main, i will merge this PR. @refvalue

Perfect. I'll finish rebasing tonight.

MSVC CI passed without ssl, we will fix ssl in next PR, thanks for your PR @refvalue

MSVC CI passed without ssl, we will fix ssl in next PR, thanks for your PR @refvalue

No problem. My pleasure to contribute code to the Community.

@refvalue could you also provide a c++17 version magic name?Because some one need to compile it with gcc8.3.


Set up ORMs & DAOs with MySQL

'LMUser' DAO was created in the process of integrating MySQL into the project. ORM appears to be done automatically as well via the Repository class.


build: create metrics service when installing hub

Co-authored-by: Maggie Chen<EMAIL_ADDRESS>Signed-off-by: Tomer Figenblat<EMAIL_ADDRESS>

/hold

/approve
/lgtm

/assign @qiujian16
Hi @qiujian16 , could you help review and approve this PR? Thanks!

Standalone deployment modified in https://github.com/open-cluster-management-io/multicloud-operators-subscription/pull/259.

/unhold

/approve
/lgtm


Missing documentation on IMixedReaalityService / BaseService Disable() / Enable()

Describe the issue
As discussed in #7474 I'd like to add another topic here, that may be worth looking at to improve documentation. I ran into this recently.
IMixedRealityService defines Enable() and Disable(). For me and other devs with Unity background this does suggest, that a disabled service will not receive Update() etc. event calls when disabled. In fact, executing Disable() on a service will not do anything and it will continue to work just as it did before. Of course there is ways to work around this.
Proposed Solution
Add docs that specifically explain the IMixedRealityServiice event functions and when they will run.
Alternative Solution
Add bool IsEnabled { get; } to IMixedRealityService interface and implement in BaseService and update MixedRealityToolkit so that a service will only receive frame updates when enabled.
Feature area
Service lifecycle documentation
Existing doc link
Not really existing, but most likely a documentation about service lifecycle / event functions would live here:
https://microsoft.github.io/MixedRealityToolkit-Unity/Documentation/ServiceUtilities/MixedRealityServiceRegistryAndIMixedRealityServiceRegistrar.html

We appreciate your feedback and thank you for reporting this issue.
Microsoft Mixed Reality Toolkit version 2 (MRTK2) is currently in limited support. This means that Microsoft is only fixing high priority security issues. Unfortunately, this issue does not meet the necessary priority and will be closed. If you strongly feel that this issue deserves more attention, please open a new issue and explain why it is important.
Microsoft recommends that all new HoloLens 2 Unity applications use MRTK3 instead of MRTK2.
Please note that MRTK3 was released in August 2023. It features an all new architecture for developing rich mixed reality experiences and has a minimum requirement of Unity 2021.3 LTS. For more information about MRTK3, please visithttps://www.mixedrealitytoolkit.org.
Thank you for your continued support of the Mixed Reality Toolkit!


chore(deps): migrate to NestJS

closes #389
closes #386

Seems like something went wrong with the deployment, not sure why. Will check later


Grading review

I think we should squash this PR when we're done, there was quite a lot of commits with code that is no longer used. That said, we should also separately store this history, so that if can later reuse some of the code.


react-native-community/datetime-picker as a peer dependency in a package with react-native-modal-datetime-picker should fail?

When we say react-native-modal-datetime-picker uses react-native-community/datetime-picker internally, what does that mean?

I installed react-native-modal-datetime-picker in my package, and mentioned react-native-community/datetime-picker as a peerDependency, and it worked fine.
But, according to my understanding, peer dependencies are not installed.
=> I didn't have a react-native-community/datetime-picker in my node_modules.
so, how did react-native-modal-datetime-picker work fine?
I was just import from react-native-modal-datetime-picker in that package, and exporting the DateTimeModal and the types for props, and then importing this package1 into another package2, when I was using the DateTimeModal
and this package2 did have react-native-community/datetime-picker in it's node_modules though
But, since I do import from the library in package1, => I am making use of this lib, even if it is to just export stuff. Why did package1 not throw any error?

Thank you,
You can direct me to any articles too! Happy to read and research too. I want to understand this stuff, but not able to find many resources on this

ok, I just learnt that , although peer dependencies are not installed, but we can still use them and import from them!! This is magic. I will next need to figure out how this is possible

Hey @smriti-spotnana  :)
I'm glad you're figuring out how this all works but this is not the right place for general discussions :/ If you're interested in the topic, I'd suggest you check https://nodejs.org/es/blog/npm/peer-dependencies/


Add Forecast by Date to C# Library Contract

Description
As a developer of a carbon-aware application, I want to consume the Forecast by Date as a C# library so that I can run the SDK within a single application.
Note:  Past Forecasts are not available in Electricity Maps.  Testing will need to occur with WattTime.
Acceptance Criteria

[x] Ensure the developer can access the getCarbonIntensityForecastAsync Data Source function
[x] Ensure that the forecast response is returned to the application when the function is called with past dates
[x] Unit Tests are completed and the code passes tests
[x] Documentation and examples are provided for C# Library Forecast

Dependencies
#160
#166
Task List

[X] Add GetForecastByDateAsync() to IForecastHandler
[X] Implement GetForecastByDateAsync() in ForecastHandler
[X] Add unit tests
[X] Add documentation updates

Sprint-Ready Checklist

[x] Acceptance criteria defined
[x] Acceptance criteria is verifiable / testable
[x] External / 3rd Party dependencies identified
[ ] Engineering team understands acceptance criteria
[x] Is the user story small enough to be implemented in a short amount of time, but large enough to provide value?

merged


build: Don't ignore main

This is a dangerous name to ignore -- basically any Java/Scala code will be in a directory like src/main which will be entirely ignored by this pattern.
We should either ignore /main (if we really want to ignore it only at the root level) or better yet change the configuration of wren to not compile to main.

@kevinjnguyen @epinzur Do you know where we produce this name? I think it's because wren is called main.go. We could maybe change that to wren.go (not sure about Go patterns), and/or compile with -o wren to change the output name. I'm not sure of the full history, so want to make sure there aren't other places we should change to make this less problematic.

You are correct. The default output name of a go binary is the name of the main file. This is most likely the only reason for adding the main to the git ignore.

@kevinjnguyen @epinzur Do you know where we produce this name? I think it's because wren is called main.go. We could maybe change that to wren.go (not sure about Go patterns), and/or compile with -o wren to change the output name. I'm not sure of the full history, so want to make sure there aren't other places we should change to make this less problematic.

We do use the -o option with the go compiler
https://github.com/kaskada-ai/kaskada/blob/a76693cad49a27b5cf5affaad050fbc40f2ce63e/.github/workflows/reusable_ci_wren.yml#L81
I am guessing the entry in the .gitignore file was leftover from a previous setup?

I did find one place we didn't use -o wren (in the Makefile) and fixed it.


Importer: "enum 'SHARP' not found" with Torus

Bug Description
Mitsuba-blender fails to import the Torus asset from https://www.mitsuba-renderer.org/download.html.
To Reproduce

Import Torus asset XML
See error being thrown

Expected behavior
No error.
Resources

Environment:

OS: MacOS Sonoma 14.4.1
Blender Version: 4.0.2
Add-on Version: v0.4.0

Hi,
Thanks for bringing this up, a fix will be incorporated soon.
Please note that importing this particular scene will still not work, because this is a Mitsuba 0.6 scene, which contains plugins that are no longer supported by Mitsuba 3. In particular, the integrator and the Sun-Sky model are not supported anymore. Furthermore, the importer is currently unable to import geometry from the serialized file format.
In order to work around these issues, I suggest you remove/replace the unsupported plugins, load the geometry using Mitsuba's python API, and export the meshes one by one as PLYs.

Thanks for the detailed answer!


SimplifyCFG: fix a compile time bug from exponential jump threading.

Change the way how to limit jump threading.  Instead of counting the
number of jump threading optimizations on a block, count the number of
copied instructions due to jump threading.
rdar://problem/51416939
Patch by Erik Eckstein!
(cherry picked from commit 75ff6216af36c9dc1a5cd5c413cd855e935ca933)

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

@swift-ci test.

@swift-ci test source compatibility.


Make NavigatorIndex.Builder ignore language variants when requested

Bug/issue #, if applicable:  rdar://138183564
Summary
Clients might want the Navigator Index to not preemptively add an entry for nodes that have a language variant trait. For example, a client might not have a renderer cable of applying language variants, in this instance it doesn't make sense to generate a navigator hierarchy for other languages.
Testing
Updated unit tests to validate the behavior
Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.

[X] Added tests
[X] Ran the ./bin/test script and it succeeded
[X] Updated documentation if necessary

@swift-ci please test


Add OWASP ZAP to Web solve section, an indispensible and versatile tool.

Thanks a lot, this has landed in master.


Couldn't find path to GroupImage.png

Can anyone fix my issues?

Related to #110 and is fixed in #71
My suggestion is to move it out of Program Files and use it on the Desktop.

My suggestion is to move it out of Program Files and use it on the Desktop. (The folder)

I have the same issue, and it didn't seem to work for me

moving to a different drive seems to six it


[varLib.interpolatable] Does not correctly handle discrete axes

Hi @behdad @anthrotype,
I love the varLib.interpolatable tool, and I would love to use it on a designspace with a discrete axis. But, when I try to run one through, it gives the following error:
  File "/Users/colinmford/Git/fonttools/Lib/fontTools/varLib/interpolatable.py", line 718, in main
    axis_triples = {
                   ^
  File "/Users/colinmford/Git/fonttools/Lib/fontTools/varLib/interpolatable.py", line 719, in <dictcomp>
    a.name: (a.minimum, a.default, a.maximum) for a in designspace.axes
             ^^^^^^^^^
AttributeError: 'DiscreteAxisDescriptor' object has no attribute 'minimum'

Larger context:
https://github.com/fonttools/fonttools/blob/ba20aa2f56c90da06000aac7110a99ccfacb8239/Lib/fontTools/varLib/interpolatable.py#L710-L723
I suppose it should split up the designspace into its subspaces, (probably using designspaceLib.split.splitInterpolatable) and then run the interpolatable tests on each subspace, though I can see this being a can of worms.
I can attempt a PR to enable discrete axes with interpolatable, but I wanted to check first with the both of you to see that something wasn't already in progress, or if you had any suggestions to start.
Thanks!

I can attempt a PR to enable discrete axes with interpolatable, but I wanted to check first with the both of you to see that something wasn't already in progress, or if you had any suggestions to start.

It hasn't been on my radar. Let me think about it. I think it can be done without splitting the designspace. Right now I collect all masters, and for each one, pick a closest master to compare with. I just need to have multiple groups of masters.

If you don't mind sending me a reproducer, I can work on it right away. You can email me. Thanks.

@behdad I don't have your email, here it is attached:
Discrete Axis.zip

@behdad I don't have your email address, here it is attached. It's just a simple 2-axis set up, with one axis discrete.

Thanks. first.last@gmail works...

Thanks. This should fix it: https://github.com/fonttools/fonttools/pull/3599

@behdad Thanks so much!


OpenJS Foundation Security Collab Space Meeting 2023-10-02

Time
UTC Mon 02-Oct-2023 18:00 (06:00 PM):

Timezone
Date/Time

US / Pacific
Mon 02-Oct-2023 11:00 (11:00 AM)

US / Mountain
Mon 02-Oct-2023 12:00 (12:00 PM)

US / Central
Mon 02-Oct-2023 13:00 (01:00 PM)

US / Eastern
Mon 02-Oct-2023 14:00 (02:00 PM)

EU / Western
Mon 02-Oct-2023 19:00 (07:00 PM)

EU / Central
Mon 02-Oct-2023 20:00 (08:00 PM)

EU / Eastern
Mon 02-Oct-2023 21:00 (09:00 PM)

Moscow
Mon 02-Oct-2023 21:00 (09:00 PM)

Chennai
Mon 02-Oct-2023 23:30 (11:30 PM)

Hangzhou
Tue 03-Oct-2023 02:00 (02:00 AM)

Tokyo
Tue 03-Oct-2023 03:00 (03:00 AM)

Sydney
Tue 03-Oct-2023 05:00 (05:00 AM)

Or in your local time:

https://www.timeanddate.com/worldclock/fixedtime.html?msg=Node.js+Foundation+Security Collab Space+Meeting+2023-10-02&iso=20231002T1800
or https://www.wolframalpha.com/input/?i=06PM+UTC%2C+Oct+02%2C+2023+in+local+time

Links

Minutes Google Doc: https://docs.google.com/document/d/1ANsCJ0Hn4srZ7mIaWzudhzGbvJF2YTV324jn13_79xM/edit

Agenda
Extracted from security-agenda labelled issues and pull requests from the openjs-foundation org prior to the meeting.
openjs-foundation/security-collab-space

Review Latest Revisions To OpenJS SBOM Best Practices & Secure Releases and CVE Management for the JS Ecosystem #64
Discuss: Request for Information on Open-Source Software Security: Areas of Long-Term Focus and Prioritization #53
Get Feedback On Draft "OpenSSF CII Best Practices Badge for JS Projects" #50
Create a prescriptive best practices toolchain #45
Milestone: Compliance Report / Audits / Dashboard Created And Populated By Tier 2 Projects #17
Milestone: SBOM Generation /  Tooling Best Practices Created #18

Invited

OpenJS Foundation Security Collab Space Members
OpenJS Foundation Cross Project Council
OpenJS Foundation Project Maintainers
OpenJS Foundation Board of Directors
All are welcome

Observers/Guests
Notes
The agenda comes from issues labelled with security-agenda across all of the repositories in the openjs-foundation org. Please label any additional issues that should be on the agenda before the meeting starts.
Joining the meeting
link for participants: Zoom link: https://zoom.us/j/94497273832

For those who just want to watch: https://livestream.openjsf.org

Invitees
Please use the following emoji reactions in this post to indicate your
availability.

:+1: - Attending
:-1: - Not attending
:confused: - Not sure yet

No meeting notes taken or perhaps meeting was canceled


Version 3 not working

(27361) Wronge device type
can you implement the new version (3) of this device - please

Duplicate https://github.com/JoJ123/ioBroker.mihome-airpurifier/issues/31


Unable to connect

Hello.
I have problem with connection.
In configuration i write ip, name and generated token. Then in pop up i click allow. In next window i write device ID (di from site) and click allow again on  pop up. After typing and clicking allow, the same window appears. the situation repeats itself over and over again.
Below I am pasting information from "http://device-id:8001/api/v2/"
{"device":{"FrameTVSupport":"false","GamePadSupport":"true","ImeSyncedSupport":"true","OS":"Tizen","TokenAuthSupport":"true","VoiceSupport":"true","countryCode":"PL","description":"Samsung DTV RCR","developerIP":"<IP_ADDRESS>","developerMode":"0","duid":"uuid:62c4e1f4-61d8-4c60-b94c-39d95a89694a","firmwareVersion":"Unknown","id":"uuid:62c4e1f4-61d8-4c60-b94c-39d95a89694a","ip":"<IP_ADDRESS>","model":"17_KANTM_UHD","modelName":"UE55MU7052","name":"[TV] Samsung 7 Series (55)","networkType":"none","resolution":"3840x2160","smartHubAgreement":"true","type":"Samsung SmartTV","udn":"uuid:62c4e1f4-61d8-4c60-b94c-39d95a89694a","wifiMac":"none"},"id":"uuid:62c4e1f4-61d8-4c60-b94c-39d95a89694a","isSupport":"{"DMP_DRM_PLAYREADY":"false","DMP_DRM_WIDEVINE":"false","DMP_available":"true","EDEN_available":"true","FrameTVSupport":"false","ImeSyncedSupport":"true","TokenAuthSupport":"true","remote_available":"true","remote_fourDirections":"true","remote_touchPad":"true","remote_voiceControl":"true"}\n","name":"[TV] Samsung 7 Series (55)","remote":"1.0","type":"Samsung SmartTV","uri":"http://<IP_ADDRESS>:8001/api/v2/","version":"2.0.25"}
Could there be anything else I could do?

You need to change settings on your TV to ask authorization for external device "only first time"!

of course I have it set up.

Did you try to cold boot your TV. If nothing solve, enable debug add attach here HA log file.


Greate work!

Hello! This is a awesome project. And you profi! Please post documentation in english.

The initial project was to write documentation and code comments in English, but I found that after I did not maintain the code, I came back to look at the code for a while, and I found that I could n’t understand them well because my English is not good , I have to convert those crappy English back to Chinese to understand its meaning, but this effect is very poor. So recently I started to comment in Chinese, after all, My native language is Chinese.
But I still insist on using git commit in English, I hope some key places in the future, I can write both Chinese and English.

最开始项目是用英文写文档和代码注释，但我发现，在我不维护代码后一段时间再回来看这些代码，我发现连我自己都不能很好理解它们了，因为我的英文并不好，我必须把之前那些蹩脚的英文转回中文去理解它的意思，不过这样效果很差。所以最近我开始用中文注释，毕竟我的母语是中文。
但 git commit 我还是会坚持用英文，希望以后某些关键的地方，我可以同时写上中文和英文。


[1.20.1] Recipe tree not working for some items from other mods

I am not sure if there is any configuration or prerequisite for this to work. I've looked over the issues and I haven't found any bug reports about this. Excuse me if I'm missing any config or if there's another issue about this.
I am using the EMI 1.0.10 in Minecraft 1.20.1 with Forge 47.1.3 and some other mods. I have noticed that the mod's recipe tree does not work for some items from other mods. For example, I cannot view the view recipe tree for the Inferium Sword (from Mystical Agriculture) using the mod's recipe tree.

nvm ... just learned that you can set the recipe that will be used in the recipe tree


As a Developer, I want to have discovery tests in fast-passing CI workflow, so I can have quick feedback

Categories of tests:

Testing P2P
Testing bootstrapping
...

Basic scenarios are:

OCaml and Rust nodes, connecting to a seed node (OCaml)
We query peers and make sure needed peers are there
Different start order/timing
The test should be runnable locally

Current version run in GHA:
https://github.com/openmina/openmina/actions/workflows/ci.yaml

Working with the #150


[YUNIKORN-2270] GPU Preemption is not triggered as expected when all available GPUs are used.

What is this PR for?
I am testing GPU preemption scenarios, and in the following scenario, the preemption isn't happening as expected.
queue structure is pretty simple:
root
 - a
   min=100
   max=300
 - b
   min=0
   max=300

the cluster has a total of 300 GPUs available, no autoscaling. Reproducing steps:

Create 600 pods in root.b queue, each needs 1 GPU. This will consume all 300 GPUs available in the cluster, and 300 pods pending
Create 100 pods in root.a queue, each needs 1 GPU. The expectation is queue a will preempt 100 GPU from queue b reach the guarantee.

observation: a small number of pods preempted resources from queue b got started on queue a, the result is not stable. it could not reach guaranteed resources.
When I debug, I found in these lines: https://github.com/apache/yunikorn-core/blob/620687afe10638d3e191edffbc81959985abbbb4/pkg/scheduler/objects/preemption.go#L576-L587. When it marks an ask as triggered preemption, when the next time doing tryPreemption(), it will be skipped. However, when the queue headroom is enough, in my case, because all GPUs are utilized, the headroom for GPU is 0, it skipped to create the reservation. Then even one pod gets evicted, the pod initiated this preemption cannot get the spot.
Not sure why we need the check here, when I removed it and always return a reservation, it works much better and much stable now.
What type of PR is it?

[x] - Bug Fix
[ ] - Improvement
[ ] - Feature
[ ] - Documentation
[ ] - Hot Fix
[ ] - Refactoring

Todos
N/A
What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-2270

@craigcondit please help to take a look, thanks!

Good catch @yangwwei , i think it's because we allow preemption when request don't fit the headroom, so we should allow the reservation when it don't fit the headroom, thanks. Need @craigcondit @wilfred-s for double check.
// resource must fit in headroom otherwise skip the request (unless preemption could help)
		if !headRoom.FitInMaxUndef(request.GetAllocatedResource()) {
			// attempt preemption
			if allowPreemption && *preemptAttemptsRemaining > 0 {
				*preemptAttemptsRemaining--
				fullIterator := fullNodeIterator()
				if fullIterator != nil {
					if alloc, ok := sa.tryPreemption(headRoom, preemptionDelay, request, fullIterator, false); ok {
						// preemption occurred, and possibly reservation
						return alloc
					}
				}
			}
			sa.appEvents.sendAppDoesNotFitEvent(request, headRoom)
			continue
		}

@manirajv06 this is what we have been discussing around preemption and reservations. It came up after the preemption discussion we had with Rainie.

a small number of pods preempted resources from queue b got started on queue a

My understanding is, even small number of pods preempted here should have not happened through reserved allocation because p.headroom check would have always failed. How old is p.headroom? It holds the available resource calculated much earlier in the allocation process. Even though, some pods has been removed completely (after confirmation from shim) as part of current preemption loop, p.headroom still carries the old value. So, it is always bound to fail. I think none of the preemption would have happened through reserved allocation so far for the cases like this. By any chance, are you seeing "Reserving node for ask after preemption" in the logs before applying the fix?

On further analysis, observed that ask (preemptor) acquired resources through normal preemption process may be preempted by requiredNodePreemptor to free up spaces for daemon sets. It may happen once ask (preemptor) starts running on the node. So, whole preemption effort in making up spaces for this ask (preemptor) won't be beneficial as expected. Filing a jira for now. Need to investigate more on this.

Thanks @manirajv06 .
In my testing, without the patch, it gets me to 9 out of 20 replicas:
job-a-preempt-job   9/20    20           9           29m

with the patch, it can reach 20. It should get all these allocated because this is under the guaranteed capacity.
I saw some logs like:
2023-12-20T10:28:36.542-0800    INFO    core.scheduler.preemption       objects/preemption.go:585       Preempting allocations for ask, but not reserving yet as queue is still above capacity  {"allocationKey": "a3ea8a58-7594-4d11-907c-6b603ecea3ec", "victimCount": 1}

I have attached the log for reference.
yk.log

I don't see any reserved allocation ""Reserving node for ask after preemption"" in the logs. I can see "Preempting allocations for ask, but not reserving yet as queue is still above capacity" for 7 allocations. As expected, none of the preemption has happened through reserved allocation process.
We can go ahead with the changes for now. jira would improve this situation much better.

Do you know when we'll see a release for this? Thanks!

We haven't yet planned release 1.5.0 and it may take couple of months from now. If we plan 1.4.1 release in the interim, then we will include this.


Allow configurable file extension types that will be recognized by the workbench features

Is your feature request related to a problem? Please describe.
We have query files stored in our solution as .n1ql. We would like to be able to use the workbench extension inline of our code repo for all of these files. The only way to accomplish this today is to alter the extension during development to .sqlpp to gain access to the workbench features, then modify the extension back to .n1ql like our application expects them to be.
Describe the solution you'd like
Add an extension option for a configurable extension type (ideally, a comma separated list of values so we can do something like .sqlpp, .sql, .n1ql )
Describe alternatives you've considered
We can work around this by modifying the extension of a query file to .sqlpp when we want to run a query. Ideally, we can avoid having to take on the risk of altering code to accept the .sqlpp extension and modifying all query files in our app and any accidental check-ins that modify the file types.

Hi,
We will also add support for the ".n1ql" extension but making it configurable is something tricky. The IDE expects a fixed extension type to select which editor should be used.

We are adding support for n1ql files. Now you can have all workbench features right inside .n1ql files. Just note creating a new workbench from extension will still result in sqlpp file format. You can still manually create files.
The update should be released next week

@amfrye777 , We have released version 2.0.4 with .n1ql files support.
Please do try it out and we will be waiting for more feedbacks from you


spek plugin hangs waiting for jvm to shut down threads

Dynamodb embedded is a bit horrible (and hacky). The following delegate:
https://gist.github.com/andaag/ee02753549c910ba6ea5ad4b27262682
With this dependency:
testCompile 'com.amazonaws:DynamoDBLocal:1.11.86'
Works fine in gradle, but runs forever when running it through intellij with the spek plugin. (Tests green, but task has to be killed). The reason is that dynamodb embedded does not properly shut down all threads. Maybe the spek plugin can skip waiting for a graceful shutdown?

Created a new ticket in the main repo, see https://github.com/spekframework/spek/issues/345.


how to change the location of the 'archive', (picam-streamer/archive) directory to a attached pendrive (viz /media/usb/archive)

Hi sir, Thank you for this wonderful project.
I need to change the  'picam-streamer/archive' to a directory in the attached usb drive, I want to directly save the recorded videos on a attached USB pendrive, please help me with that

Sir, I'am using ur script in "https://github.com/iizukanao/picam/issues/89" for recording, is it possible to write a script to check and 'mv' all the video files in "picam-streamer/archive", viz "picam-streamer/archive/*.ts "  to a folder in mounted USB drive to raspberry pi continuously as and so that also maintain a circular buffer of recording

Hi @rajeshkrarora1,
Apologies for the delayed response. Yes, you can replace the archive directory with a symbolic link in order to store recorded files into somewhere else. If you mount a USB drive at /mnt/mydisk, run these commands:
sudo service picam-streamer stop
mv /home/pi/picam-streamer/archive/* /mnt/mydisk/
rmdir /home/pi/picam-streamer/archive
ln -s /mnt/mydisk /home/pi/picam-streamer/archive
sudo service picam-streamer start

Hi Sir, Thank you for your response. This is working like magic now

Great, thanks for the feedback! 🙂


The eñe character in ScalySansSmallCapsRemake (V3) is borked

ScalySansSmallCapsRemake is used in V3 for H5 headings.
In Legacy, the font-face is ScalySansSmallCaps, and the glyph is correct.

Put this into a V3 brew..
##### Gravedad del Daño in V3

##### Gravedad del Daño in Legacy
{font-family:ScalySansSmallCaps}

<style>
/* copied from 5ePhbLegacy.style.css */
@font-face {
  font-family: ScalySansSmallCaps;
  src: url('../fonts/5e legacy/Scaly Sans Caps.woff2');
  font-weight: normal;
  font-style: normal
}
</style>

Releasing a PR to fix this right now.

We definitely do not want to use the Legacy font in V3. The V3 font fixes several other issues with that existed in the Legacy font. Just fixing one character is not a good enough tradeoff.
What we actually want to do is go into the V3 font and just add the missing character.


Add a closurecompiler task to compile apprtc JS into one file

No optimization is turned on for now, only whitespace and comments removal.
Change to the GAE push process and local deployment:
Must run grunt first, to generate the compiled js in samples/web/content/apprtc/js/compiled.
See http://gruntjs.com/getting-started for how to install grunt.
CC: @samdutton @marwahvikas @phoglund @KaptenJansson @chuckhays @tkchin

overall lgtm, aside from comment and build failure. Chuck can give final LGTM.

lgtm, I may have caused a merge conflict for you with my jscs cleanup.


Keep the position and zoom when split the images and compare between  2 images

Hi ,
http://codepen.io/anon/pen/RpWoar
(try to click on show and hide button few times after zooming the first image) and you will see the lost zoom problem(it has to keep the zoom )
i found that preserveImageSizeOnResize : true help and work but only for one image and when i add the sync between the images(the handlers) its makes lot of problems
I have 1 big image width 100% with fixed height and button that split the screen to 49.5% and 49.5% for each div
I m use  preserveViewport:true   to keep the zoom while I split the image so both images should keep the zoom and position
the problem is when I close and open the div from split (2 images) to 1 image  I lost the zoom a little bit . and sometimes it just return to home . or move to other position.
I also tried  to save bounds .= viewer1.viewport.getBounds();  on show button
and on hide button : viewer1.viewport.fitBounds(bounds);
but afterI print again the  viewer1.viewport.getBounds() . its not took the previous bound
on the button click I just used : (I have 2 buttons  - show and hide)
                 viewer1.open(tileSource1);
                viewer2.open(tileSource2);
                viewer1.preserveViewport = true;

So what I need is to keep the compare between 2 images that I zoom in the 1 big image and then should keep the zoom when split the images . and  when close it ...etc
thx all for helping
html code

my openseadragon viewers code is:
var viewer1 = OpenSeadragon({
             id: "mainImage",
             maxZoomPixelRatio:6,
           defaultZoomLevel: 	0.75,
           minZoomLevel: 	0.75,
           visibilityRatio: 	1,
             preserveViewport:true,
             prefixUrl: "img url",
   });
var viewer2 = OpenSeadragon({
                id: "comparedImage",
                maxZoomPixelRatio:6,
                defaultZoomLevel: 	0.75,
                minZoomLevel: 	0.75,
                visibilityRatio: 	1,
             preserveViewport:true,
                prefixUrl: "img url",
      });
```

 // this for control the pan and zoom together
      var viewer1Leading = false;
      var viewer2Leading = false;

      var viewer1Handler = function() {
        if (viewer2Leading) {
          return;
        }

        viewer1Leading = true;
        viewer2.viewport.zoomTo(viewer1.viewport.getZoom());
        viewer2.viewport.panTo(viewer1.viewport.getCenter());
        viewer1Leading = false;
      };

      var viewer2Handler = function() {
        if (viewer1Leading) {
          return;
        }

        viewer2Leading = true;
        viewer1.viewport.zoomTo(viewer2.viewport.getZoom());
        viewer1.viewport.panTo(viewer2.viewport.getCenter());
        viewer2Leading = false;
      };

      viewer1.addHandler('zoom', viewer1Handler);
      viewer2.addHandler('zoom', viewer2Handler);
      viewer1.addHandler('pan', viewer1Handler);
      viewer2.addHandler('pan', viewer2Handler);`

Yeah, because you're wanting and taking such control over the pan and zoom, you can't rely on the automatic things like preserveViewport. The trick is to turn off autoResize and handle it yourself, like so:
http://codepen.io/iangilman/pen/YZyejG

@iangilman  thx  a lot  look like autoResize is engough and I dont need smth else ?
now if i  want to disable the zoom between other buttons ? preserveViewport will return to the home zoom?
btw can we do something with the gray background until the right image is loading?
thx a lot again

Wow, lots of questions! I may not be able to answer them all.
I suppose you noticed that it's not just autoResize: false, but also the maintainZoom function. In particular, when you have auto-resize off, you need to explicitly call viewer.viewport.resize. This is what's causing the stretching whenever you see that. You'll probably want to do something for window resize events and anything else that will cause one of your viewers to resize, such as the "move next" button.
preserveViewport is only for preserving the pan/zoom when opening a new image. Because you're taking control of things, best to leave that off and set the pan/zoom explicitly.
In fact it might be good for you to always keep a separate copy of the master pan/zoom info so you're not reliant on what's stored in the viewers.
The gray background when the right image is loading is because we're not resizing it until the fadeIn is complete. I did that because you actually don't know the proper size before the fadeIn starts, because the element is hidden. You could probably figure out how to get it to happen right after the fadeIn starts though. Another option, of course, would be to just show/hide rather than fading it in.
The timing issue with the fadeIn is also why there's a delay before taking you to the zoom point, which I think might be what you're referring to as an animation.
I hope that helps!

@iangilman
thx a lot . You are amazing . Learned a lot from your Answers and support
Promise this is the last question in that issue :)
I tried what you said about resize and also to keep the Zoom and in variables but I did not mange to fix that wIred thing.
When click on show the divs become white and the images disappear until you click on the mouste
http://codepen.io/anon/pen/dvGbPB

I've taken a whack at it, including using my suggestion to keep master zoom/pan variables. Take a look:
http://codepen.io/iangilman/pen/BWKKxQ


Kalman

Pull Request Test Coverage Report for Build 16

480 of 492 (97.56%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+14.3%) to 86.266%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

gps_helper/simulator.py
76
88
86.36%

Totals

Change from base Build 14:
14.3%

Covered Lines:
760

Relevant Lines:
881

💛  - Coveralls

Pull Request Test Coverage Report for Build 16

480 of 492 (97.56%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+14.3%) to 86.266%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

gps_helper/simulator.py
76
88
86.36%

Totals

Change from base Build 14:
14.3%

Covered Lines:
760

Relevant Lines:
881

💛  - Coveralls

Pull Request Test Coverage Report for Build 16

480 of 492 (97.56%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+14.3%) to 86.266%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

gps_helper/simulator.py
76
88
86.36%

Totals

Change from base Build 14:
14.3%

Covered Lines:
760

Relevant Lines:
881

💛  - Coveralls


[FEATURE REQUEST] Home page texts are too large for small devices

Description
Is your feature request related to a problem? Please describe.
Text on the home page is too large for small devices, and it doesn't look good
Describe the solution you'd like
I would like to make text size and images responsive when we switch to small screen devices
Additional Information
Screenshots or Mockups (optional)

Before

After

Go for it!


tmui tag is displayed as-is on the Participating_in_the_Mozilla_project page

@moijes12 commented on Tue Mar 12 2019
This issue was observed on page https://developer.mozilla.org/en-US/docs/Mozilla/Participating_in_the_Mozilla_project on a Mozilla Developer Edition 66.0b14 (64-bit).
Below is what I see on the above page

I am not sure about the usage of tmui. Is this a valid html tag ?

I do not see <tmui> on the page or in the revision source. Maybe it is added by a plugin like TextMarker? Try disabling add-ons and see if the tag remains.


Adding dotnet standard support

Correct me if I'm wrong. Isn't it possible to target same project to standard as well?
I don't think copying the entire project is not the clean way. It will be difficult to manage in the long run.

@ajinasokan  yeah I agree.
the two next commits are making it multi targeting . .net 4.5 and .net standard2.0

There are more changes which needs to be done to accommodate the changes between MS Serializer and Newtonsoft.json. For my development I need to use dotnet standard and I'll be keep doing the changes.  dont merge this pr for now .


Added Web Images Support =)

-Web image support using SDWebImage (more accurately, 'UIActivityIndicator-for-SDWebImage') Pod: now the JPSThumbnail has a new property named: imageURL where the URL for the thumbnail can be set, instead of the image property (this latter one must be left as nil in order to use the imageURL property).
-Changed demo project to Use Cocoapods, in order to be able to Use the UIActivityIndicator-for-SDWebImage Pod
-Added the UIActivityIndicator-for-SDWebImage dependency into the podspec file.
-Updated README file to reflect the new feature.

Hi, Just in case you want to check I added a pull request today with a more simple approach adding only SDWebImage, here is the link #28


Template literals with a variable expression breaks syntax

Minimal example:
---
import Layout from '../layouts/Layout.astro';
const title = 'Example text';
---

<Layout title={`${title} | Website`}>
</Layout>

The closing bracket of ${title} is interpreted as the closing bracket for the prop's value (and therefore the string), which causes code after it to be interpreted as a new string, which it is not.
In the code above the template string can be constructed in the code fence section at the top, so this is more of an issue for code like:
---
import Layout from '../layouts/Layout.astro';
const slugs = ['a', 'b', 'c'];
---

<Layout>
	{slugs.map((slug) => (
		<div data-id={slug}>
			<PostLink
				href={`/post/${slug}`}
			/>
		</div>
	))}
</Layout>

Although writing that example, the issue seems to arise at the closing bracket in data-id={slug}, so there seems to be something up with the closing bracket in general.

This bug is fixed in Astro 2.0.0, which requires at least ST4126+.
It won't be fixed in Astro 1.x


Options now drop invalid keywords from kwargs

PR to fix #1463 - invalid keywords weren't actually being skipped (i.e dropped from kwargs) which meant invalid values were being set on the options tree.
If the tests go green I'll add a unit test to make sure this stays fixed.

@philippjfr Ready to review/merge. I had to restart one build because of a transient - it should pass like the others soon.

Looks good and a straightforward improvement.


Execute single batch inside expiring orders task

I want to merge this to change the way how expiring-orders task is being executed.
Instead of expiring all orders inside one task, we will now expire only a batch of orders
CeleryTask object will no longer be needed, I will prepare PR to clean that code in separate PR.
Tests that have been done on database with 2M orders, where 1M Orders are considered expired, with ~5M OrderLines and Allocations.
Time to complete the single batch:
100: ~2s
200: ~3s
500: ~6s
Memory usage is now significantly lower, but cause of the times shown above I decided to not increase batch size.
Impact

[ ] New migrations
[ ] New/Updated API fields or mutations
[ ] Deprecated API fields or mutations
[ ] Removed API types, fields, or mutations
[ ] Documentation needs to be updated

Pull Request Checklist

[ ] Privileged queries and mutations are guarded by proper permission checks
[ ] Database queries are optimized and the number of queries is constant
[ ] Database migration files are up to date
[ ] The changes are tested
[ ] GraphQL schema and type definitions are up to date
[ ] Changes are mentioned in the changelog

@kadewu Merged, we can port to main.


Local minimum info 2

A plugin refactor of PR(#674)

Coverage increased (+0.05%) to 93.945% when pulling 2e11e7839c193453b62585858950538b2008ced3 on local_minimum_info_2 into 81a206bd14e300cb4f98f1396074c046f5875bcd on master.


Add Signal Voltage Generation measurement

What does this Pull Request accomplish?
Adds the Signal Voltage Generation measurement for the PCBA-FCT Offering and generates a standard function of a sine and square wave as that is what the existing PCBA Toolkit currently supports.
Why should this Pull Request be merged?
Measurement has been validated manually and built successfully.
What testing has been done?
Connected Ch0 of FGEN to Ch0 of SCOPE.

SCOPE reads back generated signal:

Generated square wave:

Measurement builds successfully:

Built exe + other files copied to Services works.

TestStand

@kirstyong I am not in the review list, but I saw your PR and found there's some missing VI (Wait Until Generation Complete.vi) in this branch. On both of the test machines, it is linked to the one C:\Users\Administrator\Desktop\Wait Until Generation Complete.vi. It seems it is part of Logic VI, so can you clarify if this is really in the correct directory?


Option returning null with generator arguments

I'm using generator arguments and the last option, --name, always returns null when I try to set it.
*args() {
  const member = yield {
    type: "memberMention",
    prompt: {
      start: "...",
      retry: "...",
    },
  };

  const playlist = yield {
    type: (message, phrase) =>
      Playlist.resolvePlaylist(phrase, message.client, member.id), // returns null or object
    match: "rest",
    prompt: {
      start: "...",
      retry: `...`,
    },
  };

  const name = yield {
    type: Argument.validate("string", (m, p, str: string) => str.length <= 20),
    match: "option",
    flag: ["--name", "-n"],
    default: playlist.title,
    prompt: {
      optional: true,
      retry: "Please limit the name to 20 letters and try again",
    },
  };

  return { member, playlist, name };
}

If I omit --name then it uses the set default and works fine. However, if I do use --name or -n, it returns null. This is also the case if I don't provide a string after the flag, or if I provide a string over 20 characters. There is no prompting.
Logging parsed.optionFlags at the bottom also returns an empty array.

I believe this is because generator functions have their own value for this which happens to be used internally with Argument.validate. I've run into a similar issue when trying to use custom types in an argument generator function, since they can't be accessed without a reference to the client's command handler. I think a solution to this would be for the framework to pass a reference to either the client or the command handler as an optional fourth parameter to the generator argument function. This should provide the functionality we're looking for without breaking anyone else's code.

I guess you are using the stable version?

@yoon4027 Yes

try using the master version and see if works or not. Let me know!


FTP.remote fails to download file.

Snakemake version

7.30.1
Describe the bug

snakemake fails when downloading a file with FTP.remote, even thouh it works fine with HTTP.remote.
Logs

$ snakemake -j 10 out/nt/v5/nt.fas.gz
Building DAG of jobs...
MissingInputException in rule download_ncbi_nt in file ./Snakefile, line 6:
Missing input files for rule download_ncbi_nt:
    output: out/nt/v5/nt.fas.gz
    wildcards: version=5
    affected files:
        ftp.ncbi.nlm.nih.gov/blast/db/v5/FASTA/nt.gz.md5

Minimal example

from snakemake.remote.FTP import RemoteProvider as FTPRemoteProvider
FTP = FTPRemoteProvider()

rule download_ncbi_nt:
    input:
        md5 = FTP.remote("ftp.ncbi.nlm.nih.gov/blast/db/v{version}/FASTA/nt.gz.md5"),
    output:
        ref = "out/nt/v{version}/nt.fas.gz",
    log:
        "logs/nt/v{version}/nt.log",
    threads: 1
    shell:
        "aria2c --max-concurrent-downloads {threads} --file-allocation none --retry-wait 5 --console-log-level warn --log-level notice --log {log} --out {output.ref} ftp://ftp.ncbi.nlm.nih.gov/blast/db/v{wildcards.version}/FASTA/nt.gz > /dev/null"

Additional context

The path is correct, since wget works fine:
wget ftp://ftp.ncbi.nlm.nih.gov/blast/db/v5/FASTA/nt.gz.md5

There is something odd with the FTP server. It is not possible to list the files of this particular folder via FTP.
I advise you to use the HTTP version of the site  (https://ftp.ncbi.nlm.nih.gov/blast/db/) and download it with the Read-only web (HTTP[S]): snakemake.remote.HTTP)
It is possible to solve this case, but I am not sure it is good practice to make a workaround for a N=1 case.

Do you think is is something to do with this specific server? But wget works fine...

Do you think is is something to do with this specific server? But wget works fine...
You can read the technical discussion at https://todo.sr.ht/~sschwarzer/ftputil/156#event-252738

I will try to fix this error without a significant performance hit, but I am not sure at the moment if that is possible.


InterfaceAlias DOES take wildcards.

The docs say that the --InterfaceAlias option does not take wildcards. However, I find it does.
Namely, using * works fine. This is on Win 2016 Server STandard edition.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4f9afadf-377c-e00a-a23e-5c7127945f94
Version Independent ID: 6efb7c0d-7e37-65e5-b508-0d1b286a1fc1
Content: Get-NetIPAddress (nettcpip)
Content Source: docset/windows/nettcpip/get-netipaddress.md
Product: w10
GitHub Login: @coreyp-at-msft
Microsoft Alias: coreyp

@officedocsbot unassign @e0i
@officedocsbot assign @yogkumgit

Hello @jmwolfe thanks for your feedback.
I could reproduce, so I created a pull request to correct the article.
Thank you


Support for large input field

Hi,
thanks for great package!
I was wondering, however, if you could add a support for larger (width, multiline) input fields. The change for width seems quite a simple, so as for swapping input type to textarea.
Current:

Area width change:

Input -> textarea:

Version 1.1.0 adds both textarea fields and also gives you the option of adding different width fields when using a non-stacked form (for example you could have a full width input followed by two half width inputs).
I'm not planning on supporting all the nova default fields just because this package works along fairly different lines but it would be cool.  If anyone figures this one out then PRs are open!

@fourstacks Glad to hear that and I'd love to update! However, it seems that you forgot to update on Packagist, could you let me know when it's ready? :)

@flexchar - can you check again?  I can see v1.2.0 on packagist and the readme on there is up to date too.


java version as variable

We have the same for the collector getting started, makes it easier to update (and it's one step closer towards automation)

That's awesome! 🚀 With this in place we'll be able to implement post-release automation pretty easily.

If you know how to do that, that would be awesome, we could make use of it for the other SIGs where applicable as well.

Also, there's another place where the project version is mentioned: it's the /java/automatic/annotations/ page

added, please have a look

If you know how to do that, that would be awesome, we could make use of it for the other SIGs where applicable as well.

Yeah, it would look very similar to e.g. https://github.com/open-telemetry/opentelemetry-java/blob/main/.github/workflows/reusable-create-java-instrumentation-pull-request.yml

I sent automation:

https://github.com/open-telemetry/opentelemetry-java/pull/4765, and
https://github.com/open-telemetry/opentelemetry-java-instrumentation/pull/6650

will test them out in a few weeks with the 1.19.0 release

Oh, really nice @trask!

teamwork 👏


Preserving HTML elements

I have one field in an xml document that contains HTML.
<CustomInstructions>This is really important -  Complete legal description.

 Copies must be provided.

 Certificate of title must accompany the search</CustomInstructions>

Can this preserved?

Is it XHTML or is it HTML?

HTML

I can't give any guarantees for HTML.

Can you include the entire XML document @susnick? Or atleast the surrounding nodes?

<VendorService>
							<ServiceId>6615159</ServiceId>
							<ServiceCode>1OWNER</ServiceCode>
							<CustomInstructions>This is really important -  Complete legal description.

 Copies must be provided.

 Certificate of title must accompany the search</CustomInstructions>
						</VendorService>

Do you have access to generating the XML?
If you do, wrap the CustomInstructions with <![CDATA[ ... ]]>
That will "fix" the issue

Unfortunately I dont have access. Thanks anyways


Add bindings for git_revert{,_commit}

Closes #571

@alexcrichton I think this looks good to go

Thanks!


typo: efffective -> effective

Removed a few stray "e"s as well

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

Line 26: [Error] Restore nuget package W:\vtdy-s.optemp\packages\opbuild.scripts.1.63.6\tools\packages.config in folder:W:\vtdy-s.optemp\packages failed, possibly due to transient errors from nuget servers. Please try to close and reopen the PR to see if the issue can be resolved. Otherwise, refer to the instructions here to resolve the build issue: https://opsdocs.azurewebsites.net/en-us/opsdocs/partnerdocs/faq?branch=master&tabs=pr-validation-error-solution#q-why-do-i-get-pr-validation-result-with-cryptic-error-or-warning-messages-not-related-to-the-changes-i-make-in-my-working-branch. If the issue still happens, open a ticket in http://SiteHelp.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

Line 26: [Error] Restore nuget package W:\2t5w-s.optemp\packages\opbuild.scripts.1.63.6\tools\packages.config in folder:W:\2t5w-s.optemp\packages failed, possibly due to transient errors from nuget servers. Please try to close and reopen the PR to see if the issue can be resolved. Otherwise, refer to the instructions here to resolve the build issue: https://opsdocs.azurewebsites.net/en-us/opsdocs/partnerdocs/faq?branch=master&tabs=pr-validation-error-solution#q-why-do-i-get-pr-validation-result-with-cryptic-error-or-warning-messages-not-related-to-the-changes-i-make-in-my-working-branch. If the issue still happens, open a ticket in http://SiteHelp.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Update TTL to 1 day + make VPCNETWORKINTERFACE alertable

Relevant information
It seems there is a misconfiguration from very old domain-types that should be 1 DAY, like rest of INFRA domain-types, this is confirmed by #beyond
Also, AWSVPCNETWORKINTERFACE do have metrics, so it can be potentially alertable.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Miguel Rueda seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Content checker for second ed not working

Hi. I’ve just updated to 8.2.5. The Content Checker button was blinking and I opened it up. When I checked for missing 2e content, it said my content is up to date. Problem is, I haven’t yet and I can’t see any wave 2 ships (only black squares with numbers). Hope you can help. Thanks!

if you find some issues with the vassal module, you can leave questions and remarks on its project page  https://github.com/Mu0n/XWVassal/issues instead of here.

as far as I know, only the resistance bomber has missing graphics (along with its pilot cards). The tie silencer was also broken, but I fixed it. Ships with missing graphics are still playable though. You can also broadcast card abilities in the chat by right clicking on them and using 'query card text' or simply doing ctrl-Q

one thing you could do to help your situation is to doing a complete refresh of the content by going to the content Checker, clicking on the check button, then clicking on the checkbox of 'download all' and then clicking on download. It will force the module to redownload everything, including graphics that might have been updated silently (it's rare though) . If you wait until tomorrow, I'll have the resistance bomber thing repaired.


pnpm

If using pnpm as a package manager I believe the hygen command can't find local templates
command pnpm hygen Component new Navigator
or npx hygen Component new Navigator
error message...
Loaded templates<EMAIL_ADDRESS>Error: I can't find action 'new' for generator 'Component'.

      You can try:
      1. 'hygen init self' to initialize your project, and
      2. 'hygen generator new --name Component' to build the generator you wanted.

      Check out the quickstart for more: http://www.hygen.io/docs/quick-start

Hygen v6.2.10

Available actions:
init: init repo, init self

same command when dependencies are installed using yarn in same project works

same here :(

i use npx hygen


chore: upgrade to Fresh v1.3

@marvinhagemeister, PTAL at the CI failures. It appears that any async function capable of returning synchronously causes issues for async route components.

I've had to revert some changes so CI can pass. As previously stated, not all routes had to be converted to async route components. It's not ideal, but not an issue either.


Improve how the toggle component can be checked/unchecked

Is your feature request related to a problem? Please describe.
The objective is to improve the toggle component. The html produced by framework7 is something like:

            Batman

                <input type="checkbox" checked="">

To change the value of a toggle (from "unchecked" to "checked", for instance) the user has to click/tap the actual toggle (that is, the  el). But it's also natural to tap the text associated to that toggle (that is, the Batman el).
Unfortunately the toggle will not work that way. The developer has to manually handle that behaviour, which is frustrating
Describe the solution you'd like
When the user makes a click/tap in the text associated to the toggle, the toggle should change (the toggle's toggle() method should be called).
Thanks for considering this.

You have to options to do it:
1)

    Batman

      <input id="batman-toggle" type="checkbox" checked>

  Batman

    <input id="batman-toggle" type="checkbox" checked>