Remove duplicate withOnyx calls

[x] Held on https://github.com/Expensify/react-native-onyx/pull/385 so that the version of react-native-onyx can be updated
[x] Held on https://github.com/Expensify/App/pull/29169 to bump the version of Onyx that includes the above PR

Details
This PR removes the duplicates usages of withOnyx and turns the ESLint error back on. I used this grep to find multiple calls to withOnyx(. The only remaining files are ones where "withOnyx()" exists in comments.
grep -cr 'withOnyx(' src | grep -v ':[01]$'

Fixed Issues
$ https://github.com/Expensify/App/issues/28824
Tests

Load the app
Switch chats a lot
Verify there is no degradation of performance
Verify you can create money requests
Create a scan request
Access the details of the "scanning in progress" request and verify the header at the top of the chat shows that it is "scanning in progress"
Create a manual request on a workspace and verify that you can select a category for it on the confirmation step (need to expand "more options")

[ ] Verify that no errors appear in the JS console

Offline tests
None
QA Steps
Same as the tests above

[ ] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

I tested this with a large account today and the performance remains fine when switching chats.

@situchan are you able to do the checklist today? If now, we can reassign to someone else with spare cycles. Thanks!

planned today. Just to confirm if @tgolen planned to remove dupe withOnyx in AttachmentCarousel in https://github.com/Expensify/App/pull/30866

I think everywhere right? @tgolen

Now that Onyx is updated I can remove the nested withOnyx in the Attachment carousel. I'll handle that in https://github.com/Expensify/App/pull/30866 directly.

@tgolen conflicts!

@situchan conflicts are resolved now

@situchan bump for review please

reviewing

Looks good but only one concern above.
Can that be out of scope and fix in Onyx repo?

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native
https://github.com/Expensify/App/assets/108292595/2a2d7c82-80dc-43c3-a25c-ba938691fd06

Android: mWeb Chrome
https://github.com/Expensify/App/assets/108292595/c77e2a1f-6a87-4d66-87d4-60d529a27531

iOS: Native
https://github.com/Expensify/App/assets/108292595/ebf70515-2f67-4e50-a776-8f832e093aad

iOS: mWeb Safari
https://github.com/Expensify/App/assets/108292595/e8462aea-0bde-47bd-8489-d596fa644ff6

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/108292595/81af9f14-521f-4f2f-80c0-f6e50a7d82bd

MacOS: Desktop
https://github.com/Expensify/App/assets/108292595/d04b2e7a-e62b-4d4a-a58f-c071ae320bdf

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/mountiny in version: 1.3.98-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/roryabraham in version: 1.3.98-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/mountiny in version: 1.3.99-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/roryabraham in version: 1.3.99-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


version `GLIBC_2.38' not found

This was with the roc website build script:
$ ./www/build-dev-local.sh
++ dirname ./www/build-dev-local.sh
+ DIR=./www
+ cd ./www
+ rm -rf dist/
+ cp -r build dist/
+ cp -r public/different-names public/favicon.svg public/license public/site.css public/site.js public/zulip-icon-circle.svg dist/
+ roc run main.roc -- content/ dist/
roc: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.38' not found (required by /nix/store/c2yb135iv4maadia5f760b3xhbh6jh61-gcc-13.2.0-lib/lib/libstdc++.so.6)
roc: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.36' not found (required by /nix/store/c2yb135iv4maadia5f760b3xhbh6jh61-gcc-13.2.0-lib/lib/libstdc++.so.6)

The solution is probably to build the release with musl. For x86 linux, we need to use the env var CARGO_BUILD_TARGET: x86_64-unknown-linux-musl and for aarch64 linux these env vars:
CARGO_BUILD_TARGET: aarch64-unknown-linux-musl
CC_aarch64_unknown_linux_musl: clang-16
AR_aarch64_unknown_linux_musl: llvm-ar-16
CARGO_TARGET_AARCH64_UNKNOWN_LINUX_MUSL_RUSTFLAGS: "-Clink-self-contained=yes -Clinker=rust-lld"

You also need an if like this one

This error was encountered on Ubuntu 22.04.4 LTS inside the roc nix dev shell.


fix: add cgr.dev into known www_authenticate schemes

This is necessary on top of #237 for pulling authenticated images from cgr.dev (Chainguard Images). Without this patch, the following error occurs:
Error in fail: Failed to fetch https://cgr.dev/v2/chainguard/static/manifests/latest curl: (22) The requested URL returned error: 401

@tstromberg can you also add an oci_pull target fetching from cgr.dev to fetch.bzl and oci/tests/BUILD.bazel so that we ensure it works?

Sounds good, I'll do that!

@tstromberg any luck adding the tests?

Ugh. I'm going to re-propose this PR from a clean fork.


Range Fans By Feature tool needs inputs that are not packaged with the template

Range Fans By Feature tool needs inputs that are not packaged with the template
Open the tool, select an input, but nothing that is packaged with the template that can be used as input centers has the appropriate fields for this tool.

This issue was moved to ArcGIS/solutions-templates#8


Linting is much slower than npm-groovy-lint

I often see a list of files queued for linting in VS code which take a long time.
I've tested using npm-groovy-lint directly and this seems to be a lot quicker, for example a single Jenkinsfile with 1100 lines takes vscode-groovy-lint over 5 seconds whereas npm-groovy-lint direct is just over a second with all files being checked in just of 6 seconds.
I've tried to see exactly what vscode-groovy-lint is running, but it doesn't seem to say even with debug and verbose enabled.
Any tips on debugging what the difference might be?

The main problem is in npm-groovy-lint , which is half-broken for a while, and i can't really find why as i'm rusty in java / groovy :/

Ok I've made some progress on this, seems it reports timing even when it errors out and it's not actually running properly due to a binding issue.
I believe I know how to fix but would be great if you tell me how to get npm-groovy-lint debug to appear in Groovy Lint output log when debug is enabled. Any pointers on that as I'm not familiar with creating vs code extensions.

@stevenh you can follow these instructions and add breakpoints :)
https://github.com/nvuillam/vscode-groovy-lint/blob/master/CONTRIBUTING.md
Please let me know if u need more ibfo :)

Thanks @nvuillam continuing to make progress, found and fixed at least a few bugs, I think at least one is in CodeNarc, but just updating to the latest version to see.

You are a hero to the groovy community ❤
If you make npm-groovy-lint & vscode-groovy-lint i'll ask u yo be co-maintainer 🎉

I definitely have the both building, as they will both need fixes.
I love the option to update vscode-groovy-lint from npm-groovy-lint by the way 😄

Think I finally have all the fixes, as there's a combination of things I'll split it up into a few PR's that fix each of the bugs.

Ok all the fixes for npm-groovy-lint have PR's. The main one seems like it was IPv6 fix which was causing request to fail, but there where a bunch of others that caused random failures making it look like things were slow when in fact failures happening.
One the npm-groovy-lint changes are merged and a new release made I can do a PR to bump the dependencies alongside the  other PRs to this repo.
Locally with all these fixes it's been solid and performing well :)

@stevenh plz accept me on Linkedin ;)

@stevenh it seems it is fixed now, right ?
I made tests on my computer and the results were satisfying :)


simple dev server?

Hi I came across to this project and it looks like exactly what I wanted
My only problem is that the only way to locally test your app with this project seems to be installing gunicorn or uwsgi, its exactly what I will do in production but on my local PC I'm using windows.
and installing gunicorn or uwsgi on windows makes things a lot more uglier and unstable.
isn't there any way to run a simple dev server from within Falcon itself? like I'm used from Flask or any other micro framework actually
Thanks in advance

@kfir124 see https://github.com/BaseAdresseNationale/ban/blob/master/ban/commands/server.py for an example

@yohanboniface  Thanks didn't know about that feature in python


transition() bug

_transition = transition "_transition: argument" in vendor.styl causing bug, out put will have underscore "_transition" results in mixin not working.

"_transition: argument" remove the underscore ~

Sorry just notice I post this in the wrong place, this is a bug with previous version of Axis, they fixed this at the newer version.


Rip out all the non-cosim stuff from dv/uvm/core-ibex scripts

Depends on #1565 but, once we've got working "cosim tooling", we should get rid of the old way of doing things.
This doesn't include the work to rip out the old sequences for e.g. exceptions: we'll track that separately.

estimate 2

The dependency #1565 has been closed out by Greg on 10 May.
As a tldr; for Cosim tooling:
Spike with cosim support. Main thing discussed in #1565 was to get Spike running with Cosim and then deb package it and have it run on the CI.
Main files that reference this are under:
https://github.com/lowRISC/ibex/tree/master/dv/uvm/core_ibex
Namely; Makefile and compare.py. The tests will also use a post_compare flag that will need to be deprecated/removed.
Estimate of time needed is half a day for documentation removal of any post_compare and non-cosim tooling and a couple of hours for modifying the code to remove references. Total est time: 1 day.

Adding this related issue that is touched upon by cosim changes.
https://github.com/lowRISC/ibex/issues/1669

Per the Thursday HW Ibex DV meeting. Splitting this issue into two parts.
This issue has been re-labeled with the tools and scripts elements. New issue related to documentation to be created. This issue should then be able to be closed off by @hcallahan-lowrisc fairly soon. Believe that it is waiting on a PR that @hcallahan-lowrisc can link here.

@johngt Will be closed by #1705, which addresses this among other refactoring changes.

@hcallahan-lowrisc  - believe that https://github.com/lowRISC/ibex/pull/1705 is now merged so that this can now be closed out. Not tagging is completed just yet.

@johngt I've created one final small PR to remove the last few items. I've setup that PR to close this issue.


docs: inconsistency and slight improvement in how to translate

Checklist:

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the main branch of freeCodeCamp.
[x] I have tested these changes either locally on my machine, or GitPod.

What I have changed and why:

Removed the not whenever it's possible, while I was translating I faced situations in which I had misunderstood the original context of the English string, and I think most of them happened because my brain decided "nope, there is no not there, for now"
I have changed this to "## Select a Project and language", because what contributors tend to see first is Project -> language -> file.
Changed work to contribute, because translation is a group effort and I think the usage of the word contributing will push people to communicate more and less self-centered, I don't know if this is true tho, I just hope it's.
In the 4th point in "## Translate Curriculum", I have removed the "You will not be able to save an identical translation - instead", because the flow indicate that the contributor is seeing the translation in front of them (and they want to push identical translation, maybe for points), so instead of adding boilerplate, just tell them what they can do.
I have changed the note in line 124, because I spent a good while thinking about the logic of not translating alt text, and I came up there is no logic for not translating it, it just misinterpreted. I hope this make it clearer.
in line 147 I have changed the focus on language lead, because there are languages without one, but they have active contributors and Rafael.
in line 198, the () made reading it and understanding the context harder, I had to open LearnRPG project to understand it well enough. I don't think my suggestion here is good enough, and I hope that it will be changed for the better, but I have no idea how. I am open to suggestion

I'm not sure how I feel about changing to contractions, tbh.

I'm not sure how I feel about changing to contractions, tbh.

Just wanted to do my due diligence. But I kinda wish for this PR to be closed to be honest, as I won't be translating the file again, and I won't be prone to silly mistakes again.


load the IDE within the Flow UI

Right now, the IDE is opened in a separate window.  It would be nice to load it within the Flow UI framework in a later version.

Fixed with 1.4.2


Documentation: Feature list

Would be pretty useful to have it.

I really need someone to help me do this.


Bug: Using images out of ImageSets\Main\trainval.txt for training

In convert_tfrecords.py, it converts all images in VOCdevkit\VOC2012\JPEGImages into tfrecords for training,
https://github.com/HiKapok/SSD.TensorFlow/blob/b47ff6164c8925a8bbccc593719d5bbbab996058/dataset/convert_tfrecords.py#L366-L370
However, not all the images in VOC2012 are for detection, there are only 11540 images specified in ImageSets\Main\trainval.txt for detection. But in JPEGImages there are 17125 images, these extra images are for action classification, so they only annotate human, ignoring other classes.
Eg,

Using these images will be harmful for training.

after removing the images and using 11540 images to train the model, I got 0.7780 mAP with the default setting
AP for bottle = 0.5178
AP for cow = 0.8360                                                                                [0/1983]
AP for sofa = 0.7974
AP for bus = 0.8493
AP for dog = 0.8606
AP for cat = 0.8744
AP for person = 0.8000
AP for train = 0.8735
AP for diningtable = 0.7956
AP for aeroplane = 0.8154
AP for car = 0.8588
AP for pottedplant = 0.5080
AP for tvmonitor = 0.7666
AP for chair = 0.6129
AP for horse = 0.8562
AP for bird = 0.7538
AP for boat = 0.6997
AP for motorbike = 0.8463
Mean AP = 0.7780


Suggestion to extend CODEOWNERS with new contributor

@fmvilas I'd like to propose we extend list of codeowners for the specification and the json schema repo. I hope @dalelane agrees 🙏🏼
@dalelane, even though affiliated with IBM, demonstrated several times that he is a great community member and helped in many specification-related works that were not directly beneficial only to IBM. What I mean is that from my perspective Dale demonstrated he can be trusted to help in spec maintenance for the good of the community and not the company he works for:

Dale voluntarily coordinated latest 2.3 release of AsyncAPI specification (https://www.asyncapi.com/blog/release-notes-2.3.0). This makes him learn contributing guide in practice.
Dale is working on a PR to improve current release process basing on 2.3 release experience
Dale helps a lot in the community in spec topic related to Kafka:

Helped to extend security part of the spec https://github.com/asyncapi/spec/pull/502
Writes articles in his private blog about AsyncAPI and Kafka https://dalelane.co.uk/blog/?p=4219
Is also a code owner of Kafka binding https://github.com/asyncapi/bindings/blob/master/CODEOWNERS#L11

Dale not only cares about the spec but also related tools, he is a codeowner for Avro Schema parser -> https://github.com/asyncapi/avro-schema-parser

Technically speaking, @fmvilas I'd love to have Dale as codeowner:

here https://github.com/asyncapi/spec/blob/master/CODEOWNERS#L8
here https://github.com/asyncapi/spec-json-schemas/blob/master/CODEOWNERS#L9

@dalelane I hope you accept 🙏🏼 I personally would be honored 🍺
P.S. I summarized your achievements for the first time while writing this issue. I have to say you raised a bar for new potential code owners pretty high 😆 and I bet I did not mention all topics

Huge YES from my side ♥🙌🎉

That's very kind, I'd love to - thank you!

PRs created ☝


Update Rollup dependencies

Fix #345
I'm not sure if https://github.com/vaadin/vaadin-router/commit/3d47ff8cb938853dfc57f58f6bbfdcc0bd386bdf is the right approach...
Reference: https://github.com/rollup/rollup-plugin-babel#modules

This change is

Updated! Thanks both for the review!


Spyder behaves unnaturally on ipython console

Issue Report Checklist

[x] Searched the issues page for similar reports
[x] Read the relevant sections of the Spyder Troubleshooting Guide and followed its advice
[x] Reproduced the issue after updating with conda update spyder (or pip, if not using Anaconda)
[x] Tried basic troubleshooting (if a bug/error)

[x] Restarted Spyder
[x] Reset preferences with spyder --reset
[x] Reinstalled the latest version of Anaconda
[x] Tried the other applicable steps from the Troubleshooting Guide

[x] Completed the Problem Description, Steps to Reproduce and Version sections below

Problem Description
Example first and described below the screenshot

In [1] shows an example when pwd is understood as python variable, not the UNIX command. As the number (1) indicates, this is the very first thing I typed on the console after turning on spyder.
In [2] shows an example when the code is not ending after hitting return key for several times (more than 1 sec interval)
Also, spyder IPython console is sometimes extremely slow (e.g., declaring a variable takes few seconds).
These happen very randomly. Sometimes, I have to reopen spyder and it works fine for a while, but it gets like this again after executing few lines.
I am using OS X 10.14 (Mojave), spyder 3.3.1, Python 3.6.6, and IPython 7.0.1.
None of the above issues appear when I use IPython on terminal.
Also I hadn't experienced these problems when I used OS X 10.13, Windows 10 and Ubuntu 16.04 (until ~1-2 weeks ago). So I am guessing there is something when I use spyder on Mojave..?
What steps reproduce the problem?
Described above
What is the expected output? What do you see instead?
Described above
Paste Traceback/Error Below (if applicable)
Described above
Versions

Spyder version: 3.3.1
Python version: 3.6.6
Qt version: 5.9.6
PyQt version: 5.9.2
Operating System name/version: OS X 10.14 Mojave

Dependencies

IPython >=4.0     :  7.0.1 (OK)
cython >=0.21     :  0.28.5 (OK)
jedi >=0.9.0      :  0.12.1 (OK)
matplotlib >=2.0.0:  3.0.0 (OK)
nbconvert >=4.0   :  5.3.1 (OK)
numpy >=1.7       :  1.15.2 (OK)
pandas >=0.13.1   :  0.23.4 (OK)
psutil >=0.3      :  5.4.7 (OK)
pycodestyle >=2.3 :  2.4.0 (OK)
pyflakes >=0.6.0  :  2.0.0 (OK)
pygments >=2.0    :  2.2.0 (OK)
pylint >=0.25     :  2.1.1 (OK)
qtconsole >=4.2.0 :  4.4.1 (OK)
rope >=0.9.4      :  0.11.0 (OK)
sphinx >=0.6.6    :  1.8.1 (OK)
sympy >=0.7.3     :  1.3 (OK)

I had the exact same issue. Running pip install ipykernel==4.8.2 ipython==6.5.0 solved it.

@jpaasen, are you using Mojave too?

@ccordoba12
Thank you very much for the prompt proper reply.
That solved the problem completely.
It's quite unexpected that the new ipython gives this problem....
Anyway I think the problem is now gone :)
I will not close this issue at the moment as you asked and didn't get the answer yet.

I will not close this issue at the moment as you asked and didn't get the answer yet.

Ok, thanks.

@minrk, do you know what could be happening here?

@jpaasen, are you using Mojave too?

Yes.

mojave and ipython 7 / ipykernel 5 were released the same week, so I'd guess it's a coincidence on the mac version, and rather a purely ipykernel issue, since there were major changes in how messages are handled. But it's technically possible it's related. Do folks see this only in spyder, or also straight qtconsole?
I've tried setting up a test environment, but haven't been able to reproduce the error yet.

I was having similar issues on High Sierra. Running conda install ipykernel=4.8.2 ipython=6.5.0 fixed the issues, so I'd guess @minrk is correct that the issues coinciding with the Mojave release is a coincidence.

Just to provide a bit more of info, I had a working version of Spyder under Mojave, no problems at all.. then updated to a newer version of Spyder 3.2.8. Running conda install ipykernel=4.8.2 ipython=6.5.0 seemed to help

Closing in favor of #2902, where there's more people talking about this problem.


fix(apiToken): Changed _this.axiosOptions to this.axiosOptions

:tada: This PR is included in version 4.20.6 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Publishing default ASP.Net Core Web app template to azure doesn't modify the log location in web.config, resulting in no logs being produced #540

With the project created from templates the log path is set to be .\logs\stdout. If the user turns on logging but does not modify the path or delete the attribute the path will be used as is (publish-iis does not change path as it might have been set by the user). When publishing this project for Azure the path won't be correct and no logs are written.
More details:
See: https://github.com/aspnet/Tooling-Internal/issues/540
Need to decide what we want to do.

@moozzyk  is the change in publish-iis command or the templates?
@Eilon @DamianEdwards do we want to fix this for RC2?
cc @danroth27 @glennc

I don't think it can be done in templates (or only in templates). When the application is being created you don't know whether it's going to be published for Azure or IIS. When publish-iis is invoked we know if we are publishing for Azure or not. This is when we have a chance to react. The question is how we should know whether to react. One option is to not put stdoutPath to the web.config by default (this would requires changes in templates) at all. In this case publish-iis will set the path accordingly. Another way is just to leave the templates alone as today and have publish-iis check the value - if the stdoutPath has the default value it would be overwritten otherwise it would be not touched to not overwrite something the user set. In this case the changes are needed only in publish-iis tool.

The other alternative is to have the templates set the log path to %LOG_PATH% like we do for the app and args. Then it publish-iis could check for this default and replace it for normal or azure publish.

If we can make a very simple fix (aka extremely-low-risk) to the templates ASAP then I'm OK with this for RC2. Otherwise, we should revisit this in RTM.

davidebbo commented 7 minutes ago • edited
Today, when git deploying an app to Azure, you end up with this in web.config:

To enable logging (including streaming), you need to change it to:

But Azure Web App already has an existing mechanism to enable logging, and it would be good to just honor it. It works as follows:
there is a file called settings.json in %home%\site\diagnostics
it contains something like this: {"AzureDriveEnabled":true,"AzureDriveTraceLevel":"Error"}
if AzureDriveEnabled is true, it logs to files in %home%\LogFiles\Applicatio

Repasting my comment as your formatting got corrupted (should delete yours to avoid duplication)
Today, when git deploying an app to Azure, you end up with this in web.config:
<aspNetCore processPath="dotnet" arguments=".\AspNetCoreRC2.dll" stdoutLogEnabled="false" stdoutLogFile=".\logs\stdout" forwardWindowsAuthToken="false" />

To enable logging (including streaming), you need to change it to:
<aspNetCore processPath="dotnet" arguments=".\AspNetCoreRC2.dll" stdoutLogEnabled="true" stdoutLogFile="%home%\LogFiles\dotnetcore" forwardWindowsAuthToken="false" />

But Azure Web App already has an existing mechanism to enable logging, and it would be good to just honor it. It works as follows:

there is a file called settings.json in %home%\site\diagnostics
it contains something like this: {"AzureDriveEnabled":true,"AzureDriveTraceLevel":"Error"}
if AzureDriveEnabled is true, it logs to files in %home%\LogFiles\Application

The setting.json based logging mechanism uses .NET tracing - so it's tracing from the application. Here we are talking about IIS capturing whatever was written to standard output and dumping it to a file. Very useful for troubleshooting issues (e.g. startup) but probably not as much for application logging. Application can configure logging and decide to log elsewhere in which case these entries won't show up in stdOutLog. We will hover need to verify if the setting.json based Azure logging mechanism can be used to write application logs.

We decided to overwrite the outpath always to "\?%home%\LogFiles"  when publishing for Antares since the stdoutLog should be used for diagnostic purposes and the folder always exists.

%home%\LogFiles\Application might be a better choice. By default, when looking at log streams in VS, that's the only folder that gets looked at. So if you don't write there, most people will get confused (VS allows changing this, but it's an advanced setting).

@moozzyk please discuss with @glennc, as he's working on a separate logging provider which would likely conflict with this. His approach will grow better into supporting storage logging and more advanced features.

@davidebbo - as I said before - stdoutLogOutput is not for logging it is just for diagnosing (mostly startup) issues. It's especially useful to troubleshoot issues which happen even before we have a logger at all. Configuring a console logger and using stdoutLogOutput to log to a file is not a substitute for a file logger.
As for the path - we have always used %home%\LogFiles\ - feels a bit late to change this and I don't think it works out of the box. I just checked on one of my website on Azure and there is no Application subfolder in LogFiles:
> ls
D:\home\LogFiles
eventlog.xml
kudu

IIS does not create a folder for logging so you set stdoutLogEnabled and nothing is created and you are hitting this: https://github.com/projectkudu/kudu/issues/2014#issuecomment-220402231

I'm not sure I quite buy this argument. The fact is that by default apps are configured with:
loggerFactory.AddConsole(Configuration.GetSection("Logging"));

Such that anything they log using ILogger will go there, for the lifetime of the console app (and not just the startup sequence).
Point is that if this is enabled and so is @glennc's logger, we will end up writing the same content under D:\home\LogFiles twice. And if someone turns on log streaming at the root (which is D:\home\LogFiles), every log line will be streamed twice.

Why would applications in production log to the Console? How do you even read it when you run in Antares (let's say AspNetCoreModule does not have stdoutLog feature)?
stdoutLog is a IIS/AspNetCoreModule feature and not AspNet's and you only turn it on when you need to diagnose things - it's unstructured and you may and will get additional spew not related to your application at all (e.g. when the application starts we Console.WriteLine some things, when there is a misplaced Console.WriteLine in the app it will get it).
If you use stdoutLog only for diagnostic purposes you will get (especially when application starts) some additional content that logger can't get and you should not run your application with stdoutLog enabled otherwise (this is one of the reasons why it is disabled by default).

As long as users keep that off in Azure Web Apps and primarily use the new logger, I guess we're fine. And this will probably be the guidance, with the exception of diagnosing startup condition. If some does turn it on, then they will get duplicate stream, but hopefully this will be rare.

Agreed.

Fixed in 31a6a12

TL;DR: ANCM console logging :sparkles: just works :sparkles: in spite of its accidental existence and lack of support. However, it shouldn't be used probably because 3rd party logging implementations only require a little more effort to install and configure for a much longer list of logging features.
I used the "anti-pattern" for six months here successfully relying upon the ANCM-generated log with production and test apps. I would like to answer this for posterity and then make a completely different argument why it shouldn't be done:

Why would applications in production log to the Console?

.NET Logging is an abstraction for logging and not an implementation. Devs looking for really simple file-based logging are basically forced at :boy: :gun: to use a 3rd party implementation (e.g., Serilog, NLog, etc.) or to roll their own implementation, which is a huge PITA.
Setup is crazy simple: (1) Add a dep on Microsoft.Extensions.Logging.Console, (2) Configure in WebHostBuilder > .ConfigureLogging > options.AddConsole(LogLevel.Warning); with LogLevel.<level> set based on the environment to whatever level you need to log (Warning for production, Debug for development), (3) Console.WriteLine("...") anywhere in the app to shoot logging messages to the console, thus to the file, and (4) Turn on the module logging stdoutLogEnabled="true" and stdoutLogFile=".\logs\logfilename". (5) Done!
It :sparkles: just works :sparkles:. I used this approach for six months and never had a problem. It's simple, secure, reliable, and efficient. It's all many need from a practical standpoint. If you're a small shop and just need one little log for each app to write a few lines into every so often or trap some data on exceptions, this works very well. No bells-and-whistles. Nothing fancy. It :sparkles: just works :sparkles:.
I don't think the concerns hold-up from a practical point-of-view. (1) It doesn't work outside of ANCM: True! but Console.WriteLine("...") still logs to the Debug output on-screen, (2) It's not ASP.NET: So what? idk ... that's not a real reason not to do it IMO, (3) It's unstructured: So what? idk ... that's kind'a the point in that it's simple messages, (4) You'll get output in the log from Console.WriteLine("..."): That's the whole point ... that is how you log. (5) You'll get extra ANCM messages in your log: So what? That's a minimal inconvienance. Then, if there is an ANCM problem, it will get logged right along with the logging that you're doing in the same file.

This is a happy marriage between the simplicity of setting up console logging with the Logging infrastructure and the completely unrelated ANCM shelling out console to a file.
At this point, I would have suggested there should be another repo in .NET, maybe a part of Logging, maybe not, that would provide a basic logging implementation that works just like what the ANCM module is doing: Shelling out console to a file. For those that just want to Console.WriteLine("...") a few bits to a file here and there (or even go as far as I did and log exceptions across the entire app this way), it would work just like what I describe without having to rely upon the ANCM log, without having to use a 3rd party package, and without having to roll your own.
The real reason not to do this as far as I can see are not any of the reasons provided thus far, because they don't say "it isn't simple," "it isn't safe," and/or "it isn't practical." I think the best reason is the pay-for-play argument ... Logging implementations like Serilog, NLog, elmah.io, and Loggr are not much more difficult to setup and use. Because you get so much more bang-for-the-buck with really nice bells-and-whistles, devs should jump right into one of the 3rd party implementations. I still think MS could have done something for this, and I hope MS will, but until then, I see great logging happening with the 3rd party approaches (once you get past some dodgy documentation IMO).

https://github.com/aspnet/Logging/issues/441

Is there any update on enabling logging to azure blob?

@Sharpeli There is no built-in logging implementation. There are implementations though with Azure sinks. Serilog has DocumentDB and Table Storage sinks. Log4Net has an Azure Blob piece.
https://github.com/serilog/serilog/wiki/Provided-Sinks
http://stemarie.github.io/log4net.Azure/

@GuardRex  Thanks GuardRex, looks like the log4net is incompatible with .net core. Is there any workround to make the built-in “ILoggerFactory” or "Diagnostics.Trace" can log to azure blob for asp.net core app ?

@purekrome says on Slack to check out NLog. He says they use it quite a lot with great success, and it has an Azure Blob Storage sink.

https://github.com/nlog/nlog/wiki/Targets
http://stackoverflow.com/questions/23518078/store-nlog-generated-logs-to-azure-blob-storage-in-seperate-columns
http://stackoverflow.com/questions/35058029/how-to-integrate-nlog-to-write-log-to-azure-streaming-log
https://aspnetcore.slack.com/messages/general/details/

Disclaimer:

I've never logged to Azure Blob storage before.
I love using nLog
I now use Serilog with an nLog sink (with various targets as required) :)

I believe that's what https://github.com/aspnet/AzureIntegration/ does - it wires up logging along with Serilog and pushes log data to tables/blobs/wherever.

There isn't much in the way of guidance tho for the new package. cc/ @Rick-Anderson @danroth27 @spboyer

Thanks all, I've found an simple trick for azure app ,see https://github.com/aspnet/Logging/tree/dev/src , just add the package "Microsoft.Extensions.Logging.AzureAppServices": "1.0.0-preview1-final" and update related dependencies,
add the azure diagnostics in startup.cs like this :
loggerFactory.AddAzureWebAppDiagnostics();   // for default setting.
or
loggerFactory.AddAzureWebAppDiagnostics(new AzureAppServicesDiagnosticsSettings( ...));   // add custom setting.
And enable the diagnostics log on azure, both logging on blob and file are work well. No need for any
extra configuration. :)


Fix IndexOutOfBoundsException on async cache

What changes are proposed in this pull request?
Fix https://github.com/Alluxio/alluxio/issues/13828 and fix https://github.com/Alluxio/alluxio/issues/13050
This patch will fix a miscaculation of block to async cache
In earlier Alluxio versions prior to https://github.com/Alluxio/alluxio/pull/13064, users may see the following errors:
2021-03-12 08:36:48,521 ERROR AlluxioFuseFileSystem - Failed to read file=/data/0.5G_9.txt, offset=536862720, size=8192
java.lang.IndexOutOfBoundsException: Index: 4, Size: 4

After 13064, we will not see the error anymore but caching the last block when fileSize happens on block size boundary will fail silently.
Why are the changes needed?
Correct a bug when calculating the block id to async cache, when current pos is fileSize which is a multiple of blockSize
Does this PR introduce any user facing changes?
No

Codecov Report

Merging #13845 (6773c63) into master (6469555) will decrease coverage by 26.05%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             master   #13845       +/-   ##
=============================================
- Coverage     43.57%   17.52%   -26.06%
+ Complexity     9084     2673     -6411
=============================================
  Files          1386     1386
  Lines         80633    80632        -1
  Branches       9812     9812
=============================================
- Hits          35138    14132    -21006
- Misses        42538    65254    +22716
+ Partials       2957     1246     -1711

Impacted Files
Coverage Δ

...n/java/alluxio/client/block/AlluxioBlockStore.java
5.93% <ø> (-72.04%)
:arrow_down:

.../java/alluxio/client/file/AlluxioFileInStream.java
0.00% <0.00%> (-74.21%)
:arrow_down:

...re/common/src/main/java/alluxio/wire/FileInfo.java
72.28% <ø> (-5.43%)
:arrow_down:

...mon/src/main/java/alluxio/shell/CommandReturn.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...mon/src/main/java/alluxio/util/ExceptionUtils.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...n/src/main/java/alluxio/wire/AlluxioProxyInfo.java
0.00% <0.00%> (-100.00%)
:arrow_down:

.../src/main/java/alluxio/wire/AlluxioMasterInfo.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...src/main/java/alluxio/job/meta/JobIdGenerator.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...n/src/main/java/alluxio/stress/BaseParameters.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...src/main/java/alluxio/client/UnderStorageType.java
0.00% <0.00%> (-100.00%)
:arrow_down:

... and 664 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6469555...6773c63. Read the comment docs.

Hi @apc999 Do you have any update on this PR?

alluxio-bot, merge this please

alluxio-bot, cherry-pick this to branch-2.6 please


Double exception hangs processor when erasing coredump partition (IDFGH-6573)

Environment

Development Kit:      Huzzah32
Module or chip used:  ESP32-WROOM-32
IDF version: 4.3.2
Build System: CMake
Compiler version: 2021r2-8.4.0
Operating System:    Linux
Using an IDE?: vscode
Power Supply:        external 5V

Problem Description
My app has coredump to flash enabled, and provides a special led indication if a coredump is detected on reboot (using first 16 bytes of coredump partition != 0xFF). Everything works as expected.
A separate command line portion of my app allows me to erase the coredump partition once I have offloaded/analysed it (using esp_partition_find_first + esp_partition_erase_range).
Unfortunately the code never returns from the erase operation, and instead always completely hangs both cores with a double exception. However, after a manual reboot, I can see that the erase operation did succeed.
I assume this is a bug - or else it needs documenting as a limitation on a coredump partition. In either event I would expect the double exception to trigger the WDT event (as I read was planned in a couple of other double exception posts).
Debug Logs
The following is a except from the JTAG debugger:
Thread 9 hit Breakpoint 2, parse_errors (cmd=) at ../main/debug.c:282
...
p partition
$1 = (const esp_partition_t *) 0x3ffbc408
p *partition
$2 = {flash_chip = 0x3ffb4038 <default_chip>, type = ESP_PARTITION_TYPE_DATA, subtype = ESP_PARTITION_SUBTYPE_DATA_COREDUMP, address = 1114112, size = 65536, label = "coredump\000\000\000\000\000\000\000\000", encrypted = false}
Info : Target halted. CPU0: PC=0x4008B091
Target halted. CPU0: PC=0x4008B091
Info : Target halted. CPU1: PC=0x400803C0 (active)
Target halted. CPU1: PC=0x400803C0 (active)
warning: while parsing threads: not well-formed (invalid token)
[New Thread<PHONE_NUMBER>]
Thread
4 received signal SIGTRAP, Trace/breakpoint trap.
[Switching to Thread<PHONE_NUMBER>]
_DoubleExceptionVector () at /home/aussiross/esp32/esp-idf-v4.3.2/components/freertos/port/xtensa/xtensa_vectors.S:455
455	    break   1, 4                            /* unhandled double exception */
warning: while parsing threads: not well-formed (invalid token)
Error: Error reading stack frame from thread
Error: RTOS: failed to get register list
warning: while parsing threads: not well-formed (invalid token)

A significant factor is that I've been chasing down random flash cache errors in my IRAM_ATTR'd timer ISR.
By disabling that prior to the erase I can avoid the double exception. So I'll close this issue and continue chasing that.


Update igdbURL to v3 endpoint

Wanted to start playing around with the IGDB API, but it turns out that new API keys are only valid for this new API v3 endpoint.
I'm not sure if more changes are probably in order for v3 compatibility: https://api-docs.igdb.com/#migration-to-v3

Just gave a look at the migration docs - definitely more work to be done after this. I'll gladly accept any PR's that address any of the data structure or query changes. Thanks for the heads up!


Immutably Rename Object Keys

Thanks you, @AngusYang9 👍
The snippet is available at https://1loc.dev/#immutably-rename-object-keys

Thanks you, @AngusYang9 👍
The snippet is available at https://1loc.dev/#immutably-rename-object-keys


mount /dev/mqueue, make symlinks for stdin, stdout and stderr

Next initrd edits: for correct operation it is necessary to mount /dev/mqueue and make symbolic links for stdin, stdout and stderr.
Signed-off-by: Petr Fedchenkov<EMAIL_ADDRESS>

@rvs please review


Converted js to ts logic for umccrise tools. Added include, debug and exclude parameter options

TODO

[x] #319
[x] #320

Waiting for wfr.ef81e1c2ff9f4d85b5f976c324e1025e to complete


enhancements to print_result

Allow printing multiple tasks by task_id
If task_id is specified but something went wrong print everything

Solved by #98


Create debug info trait

Draft of debug info trait - do task - size and sprint to be determined

Created simple trait last week, done.
Not implemented - needs "hooks" resolution see issue 152.


Custom UID and restartable container

Hi,
Here are two little changes but useful:

New USER_UID env var if you want to reflect an existing user on a /data volume. For example, if you are using maxexcloo/data Docker image, the “core” user is created with uid=500.
Container can be restarted, it won’t exit because user already exists.

Thanks for your contribution! :)


Recover dropped commit utility function from pkg/scalers/scaler.go

Hi team,
As mentioned in the reply https://github.com/kedacore/keda/pull/5228#issuecomment-1868382916, I created this PR to recover dropped commits when rebasing. This commit would enable us to take in value of any type and convert to any other type
Checklist

[x] I have verified that my change is according to the deprecations & breaking changes policy
[x] Tests have been added
[x] Changelog has been updated and is aligned with our changelog requirements*
[x] Commits are signed with Developer Certificate of Origin (DCO - learn more)

Relates to https://github.com/kedacore/keda/pull/5228 and https://github.com/kedacore/keda/issues/5037

/run-e2e internal


[Add]

Site URL
https://pauljerimy.com/security-certification-roadmap/
Description of the above provided site
An interactive Cyber-Security certification roadmap site.
Category
Other
Sub Category
roadmaps
Checklist

[X] I have checked the existing issues
[X] I have read the Contributing Guidelines
[X] I am willing to work on this issue (optional)
[X] I am participating in Hacktoberfest 2023

@brodante
Hacktoberfest is over.
I have assigned you the issue. Please proceed with it, and don't hesitate to tag me @Anmol-Baranwal or @CBID2 if you require any assistance.

@brodante are you still working on it?

I'm closing this issue due to inactivity. Please feel free to reopen it if you'd like to contribute or have further discussions.


[wip] preallocated msm benchmark

👀 !gpu-benchmark

Oh there was no difference :(

Well, as I like to say, it's not a lot but it's honest work and well deserved


Anyone else facing the same issue ?

Wait @sayskar500 let me check..
It happens due having same name.

Issue resolved @py3-coder !


Latest code in master is broken after removing Control from Leaflet

I cloned LiveAtlas and tried to build and run it, but the current version of the code appears to be broken.
I see the following error in the Firefox console:
Uncaught TypeError: class heritage (intermediate value).Layers is not an object or null
  <anonymous> http://localhost:8080/src/leaflet/control/LiveAtlasLayerControl.ts:11

See the relevant line: https://github.com/JLyne/LiveAtlas/blob/9ab3becd5407126e5ee6f6e11bdababb8ab34f72/src/leaflet/control/LiveAtlasLayerControl.ts#L37
I think this was broken by https://github.com/JLyne/Leaflet/commit/4aa9e62e01dede9696cf43135a427895ea31565f which removed Control.

This should be resolved. Thanks for the report.


Skoda Enyaq: not showing entities

Describe the bug
I'm not being able to login with both of our Skoda Connect accounts.
Latest working release
Never used it before. Installed the latest stable and the latest beta
Debug logs
Logging from latest stable:
DEBUG (MainThread) [skodaconnect.connection] Using service https://msg.volkswagen.de DEBUG (MainThread) [skodaconnect.connection] Got authorization endpoint, logging on. ERROR (MainThread) [skodaconnect.connection] Login failed for skoda account, 'NoneType' object has no attribute 'find_all' WARNING (MainThread) [custom_components.skodaconnect] Could not login to Skoda Connect, please check your credentials and verify that the service is working ERROR (MainThread) [homeassistant.setup] Setup failed for skodaconnect: Integration failed to initialize.
Logging from latest beta:
DEBUG (MainThread) [skodaconnect.connection] Using service https://msg.volkswagen.de DEBUG (MainThread) [skodaconnect.connection] Initiating new login DEBUG (MainThread) [skodaconnect.connection] Got authorization endpoint DEBUG (MainThread) [skodaconnect.connection] Authenticating with email and password. DEBUG (MainThread) [skodaconnect.connection] Parsing login response. DEBUG (MainThread) [skodaconnect.connection] Login successful, received authorization code. DEBUG (MainThread) [skodaconnect.connection] Trying to fetch user identity tokens. DEBUG (MainThread) [skodaconnect.connection] User identity token verified OK. INFO (MainThread) [skodaconnect.connection] Successfully logged in DEBUG (MainThread) [skodaconnect.connection] Trying to fetch api tokens. DEBUG (MainThread) [skodaconnect.connection] VW-Group API token verified OK. DEBUG (MainThread) [skodaconnect.connection] Fetching vehicles associated with account DEBUG (MainThread) [skodaconnect.connection] HTTP GET "https://msg.volkswagen.de/fs-car/usermanagement/users/v1/skoda/CZ/vehicles" DEBUG (MainThread) [skodaconnect.connection] Request for "https://msg.volkswagen.de/fs-car/usermanagement/users/v1/skoda/CZ/vehicles" returned with status code [200] DEBUG (MainThread) [skodaconnect.connection] Failed to retrieve list of cars, trying new API DEBUG (MainThread) [skodaconnect.connection] Got authorization endpoint DEBUG (MainThread) [skodaconnect.connection] Authenticating with email and password. DEBUG (MainThread) [skodaconnect.connection] Parsing login response. DEBUG (MainThread) [skodaconnect.connection] Login successful, received authorization code. DEBUG (MainThread) [skodaconnect.connection] Trying to fetch user identity tokens. DEBUG (MainThread) [skodaconnect.connection] User identity token verified OK. INFO (MainThread) [skodaconnect.connection] Successfully logged in to Skoda new API DEBUG (MainThread) [skodaconnect.connection] HTTP GET "https://api.connect.skoda-auto.cz/api/v2/garage/vehicles" WARNING (MainThread) [homeassistant.setup] Setup of skodaconnect is taking over 10 seconds. DEBUG (MainThread) [skodaconnect.connection] Request for "https://api.connect.skoda-auto.cz/api/v2/garage/vehicles" returned with status code [200] DEBUG (MainThread) [skodaconnect.connection] Going to call vehicle updates DEBUG (MainThread) [skodaconnect.connection] HTTP GET "https://mal-1a.prd.ece.vwg-connect.com/api/cs/vds/v1/vehicles/[VIN]/homeRegion" ERROR (MainThread) [skodaconnect.connection] Got unhandled error from server: 404 DEBUG (MainThread) [skodaconnect.connection] Could not get homeregion, error 'homeRegion' DEBUG (MainThread) [skodaconnect.vehicle] Get homeregion for VIN [VIN] DEBUG (MainThread) [skodaconnect.connection] HTTP GET "https://msg.volkswagen.de/fs-car/promoter/portfolio/v1/skoda/CZ/vehicle/[VIN]/carportdata" DEBUG (MainThread) [skodaconnect.connection] Attempting extraction of subject from identity token. DEBUG (MainThread) [skodaconnect.connection] HTTP GET "https://customer-profile.apps.emea.vwapps.io/v1/customers/[GUID]/realCarData" DEBUG (MainThread) [skodaconnect.connection] Request for "https://msg.volkswagen.de/fs-car/promoter/portfolio/v1/skoda/CZ/vehicle/[VIN]/carportdata" returned with status code [200] DEBUG (MainThread) [skodaconnect.connection] Request for "https://customer-profile.apps.emea.vwapps.io/v1/customers/[GUID]/realCarData" returned with status code [200] INFO (MainThread) [skodaconnect.vehicle] Vehicle [VIN] added. Homeregion is "https://msg.volkswagen.de" DEBUG (MainThread) [skodaconnect.vehicle] Attempting discovery of supported API endpoints for vehicle. DEBUG (MainThread) [skodaconnect.connection] HTTP GET "https://msg.volkswagen.de/api/rolesrights/operationlist/v3/vehicles/[VIN]" ERROR (MainThread) [skodaconnect.connection] Got HTTP 400 "Bad Request" from server, this request might be malformed or not implemented correctly for this vehicle WARNING (MainThread) [skodaconnect.connection] Could not fetch operation list, HTTP status code: 400 WARNING (MainThread) [skodaconnect.connection] Could not update information: 'serviceInfo' WARNING (MainThread) [custom_components.skodaconnect] Could not login to Skoda Connect, please check your credentials and verify that the service is working ERROR (MainThread) [homeassistant.setup] Setup failed for skodaconnect: Integration failed to initialize.
Installation:

Home Assistant variant: Core
Python version: 3.8.9
Python library versions: pip==20.2.3, setuptools==49.2.1

Additional context
Clean set-up via HACS, logged on with same credentials via https://www.skoda-connect.com/ and that works. Accepted new terms.
App screenshot

Same here🤔.
2021-04-30 12:22:18 WARNING (MainThread) [homeassistant.setup] Setup of skodaconnect is taking over 10 seconds.
2021-04-30 12:23:07 WARNING (MainThread) [homeassistant.bootstrap] Waiting on integrations to complete setup: skodaconnect
2021-04-30 12:23:11 WARNING (MainThread) [custom_components.skodaconnect] Could not login to Skoda Connect, please check your credentials and verify that the service is working
2021-04-30 12:23:11 ERROR (MainThread) [homeassistant.setup] Setup failed for skodaconnect: Integration failed to initialize.
I can access Skoda Connect through a browser or mobile app.
I tried to reinstall and remove the app again but it didn't help.

Same here.

What car do you have? Did the integration work at any point for you?

Clean set-up via HACS, logged on with same credentials via https://www.skoda-connect.com/ and that works. Accepted new terms.

From the logs it looks like the data for your car isn't available through any of the known API endpoints. It might be that your car has been migrated from VW-Group servers to Skodas own API servers but I can't tell.
The only way to say for sure is to debug the native app, disable SSL pinning and run the connections through a SSL MITM proxy to inspect the HTTP calls.

Hi Farfar,
The car is Škoda Octavia and the integration worked normally until two hours ago.
Thanks,
Vlad

The car is Škoda Octavia and the integration worked normally until two hours ago.

OK then I would say that the service is temporary down, try again later.

Update: The Citigo-e seems to be working (without adding the VIN because I've outcommented the Citigo-e so it seems that all of the cars will be added automatically?).
The Enyaq isn't working though, is that known common issue?

@Farfar is there a way to help you, help me with having my Enyaq entities visible within HASS?

You're making a very good point!
It seems that the data within the app show the same (wrong) results.
I'm ready on the internet that Skoda-Connect should work after the 13th of May!
By the way, is is possible to show Enyaqs Odometer? That's something I need for my statistics :D

By the way, is is possible to show Enyaqs Odometer? That's something I need for my statistics :D

Not yet, the only exposed endpoints so far is charging/status and charging/settings. This is the data returned:
charging/status
{
    "battery": {
        "cruisingRangeElectricInMeters": 218000,
        "stateOfChargeInPercent": 72
    },
    "charging": {
        "chargeMode": "MANUAL",
        "chargingPowerInWatts": 0.0,
        "chargingRateInKilometersPerHour": 0.0,
        "chargingType": "Invalid",
        "remainingToCompleteInSeconds": 0,
        "state": "ReadyForCharging"
    },
    "plug": {
        "connectionState": "Disconnected",
        "lockState": "Unlocked"
    }
}

charging/settings
{
    "autoUnlockPlugWhenCharged": "Permanent",
    "maxChargeCurrentAc": "Maximum",
    "targetStateOfChargeInPercent": 100
}

The name was the default "My Enyaq" that is given to it during the account setup. I renamed it in the app and reloaded Skodaconnect but it is still giving me FALSE as a name

When it's been added under a name you either have to rename all entities or remove the integration config (comment it out), restart hass and remove entities, add config again and reboot hass.
Do you still get the realCarData error? I don't remember without the debugs in front of me if that endpoint is where the nickname is set.

I have complete uninstalled Skodaconnect and reconnected it and now I am seeing the right name in all my entities!

I'm not seeing updates to all entities;
I did a fresh install of a Home Assistant docker instance.
Then install RC5 within the docker container, and configured my Enyaq. Then the entities start showing up, however the binary sensors are never changed, although I do get the data when I look at the response which is logged (see below).
I am a new Home Assistant user, (but not new to domotica), and some data seems to be shown but not all. So did I forget something or is something else wrong ?
`2021-05-24 10:39:15 DEBUG (MainThread) [skodaconnect.connection] Got vehicle data {'plug': {'connectionState': 'Connected', 'lockState': 'Locked'}, 'charging': {'state': 'ReadyForCharging', 'remainingToCompleteInSeconds': 0, 'chargingPowerInWatts': 0.0, 'chargingRateInKilometersPerHour': 0.0, 'chargingType': 'Invalid', 'chargeMode': 'MANUAL'}, 'battery': {'cruisingRangeElectricInMeters': 315000, 'stateOfChargeInPercent': 80}}
2021-05-24 10:41:16 DEBUG (MainThread) [skodaconnect.connection] Got vehicle data {'plug': {'connectionState': 'Connected', 'lockState': 'Locked'}, 'charging': {'state': 'Charging', 'remainingToCompleteInSeconds': 2400, 'chargingPowerInWatts': 10500.0, 'chargingRateInKilometersPerHour': 53.0, 'chargingType': 'Ac', 'chargeMode': 'MANUAL'}, 'battery': {'cruisingRangeElectricInMeters': 319000, 'stateOfChargeInPercent': 81}}`

2021-05-24 10:41:16 DEBUG (MainThread) [skodaconnect.connection] Got vehicle data {'plug': {'connectionState': 'Connected', 'lockState': 'Locked'}, 'charging': {'state': 'Charging', 'remainingToCompleteInSeconds': 2400, 'chargingPowerInWatts': 10500.0, 'chargingRateInKilometersPerHour': 53.0, 'chargingType': 'Ac', 'chargeMode': 'MANUAL'}, 'battery': {'cruisingRangeElectricInMeters': 319000, 'stateOfChargeInPercent': 81}}`

Thanks, this is still WIP and since I don't have a Enyaq myself I can't test all endpoint data.
With this info I'll be able to fix theese sensors, RC6 on the way!

Great and if you need any testing or info, I would be happy to help.
Thanks for this so far!

Any news on RC6 @Farfar?
I just got my Enyaq and I'm experiencing similar issues as @Raainman with certain sensors not updating or showing the correct state. What seems to be working is the electric range and the battery percentage.
It would be great if you could get this working and even greater if we were able control the HVAC from HA! 🙂
As others have said, I'd be happy to supply log files or help in other ways if needed.🙂

Any news on RC6 @Farfar?
I just got my Enyaq and I'm experiencing similar issues as @Raainman with certain sensors not updating or showing the correct state. What seems to be working is the electric range and the battery percentage.
It would be great if you could get this working and even greater if we were able control the HVAC from HA! 🙂
As others have said, I'd be happy to supply log files or help in other ways if needed.🙂

New RC out now with config flow. It's a bit untested for merging yaml config so I recommend to setup from scratch. It should contain fixes for correct sensor states.


Add methods to get number of policies and templates in a PolicySet

Description of changes
Add methods to get number of policies and templates in a PolicySet
Issue #, if available
#1179
Checklist for requesting a review
The change in this PR is (choose one, and delete the other options):

[ ] A breaking change requiring a major version bump to cedar-policy (e.g., changes to the signature of an existing API).
[X] A backwards-compatible change requiring a minor version bump to cedar-policy (e.g., addition of a new API).
[ ] A bug fix or other functionality change requiring a patch to cedar-policy.
[ ] A change "invisible" to users (e.g., documentation, changes to "internal" crates like cedar-policy-core, cedar-validator, etc.)
[ ] A change (breaking or otherwise) that only impacts unreleased or experimental code.

I confirm that this PR (choose one, and delete the other options):

[ ] Updates the "Unreleased" section of the CHANGELOG with a description of my change (required for major/minor version bumps).
[X ] Does not update the CHANGELOG because my change does not significantly impact released code (doesn't seem maintained in 3.x?)

I confirm that cedar-spec (choose one, and delete the other options):

[X] Does not require updates because my change does not impact the Cedar formal model or DRT infrastructure.
[ ] Requires updates, and I have made / will make these updates myself. (Please include in your description a timeline or link to the relevant PR in cedar-spec, and how you have tested that your updates are correct.)
[ ] Requires updates, but I do not plan to make them in the near future. (Make sure that your changes are hidden behind a feature flag to mark them as experimental.)
[ ] I'm not sure how my change impacts cedar-spec. (Post your PR anyways, and we'll discuss in the comments.)

Closing -- will merge to the release/3.4.x branch along with #1186.


503 from nixplay

Hi there,
Has been working like a charm, but now I keep getting:
"Error syncing album AllMyStuff: POST 503 Service Temporarily Unavailable"
My poor debugging skills have led me to this function: https://github.com/andrewjjenkins/picsync/blob/master/pkg/nixplay/photo.go#L36
So i assume the 503 is coming from Nixplay.
Any advice for me? I tried changing the name of the album to no avail.
Thanks
/Rickard

Thanks for the heads-up Rickard, and sorry it took me a few days to look into this.
It appears something changed in the nixplay API that is causing some of the sync code to misbehave.  A big problem here is that there is a bug in the album sync logic, which looks something like this:

See if album "AllMyStuff" already exists
If not, create album AllMyStuff
Sync photos to AllMyStuff

The implementation of "1" is flawed - it considers "I had an error checking if AllMyStuff exists" to be equivalent to "AllMyStuff doesn't exist".  Unfortunately, the implementation of "2" seems to still work.  I am observing that means many albums named "AllMyStuff" will be created (same name, but different internal ID in the API).
I am going to fix that behavior, add a method to delete the extraneous albums, and fix the photo fetching/syncing issue you're seeing.

Rickard, I pushed code to fix this.  This is the tag of the container that has the fix:
gcr.io/picsync-build/github.com/andrewjjenkins/picsync:master-0cbf954
master-0cbf954: digest: sha256:e96cb10be53472ae032baad2b5eb89cbf17ebd49fa038807d237247965f56adf
(it is also now the new gcr.io/picsync-build/github.com/andrewjjenkins/picsync:master-latest)
If you (like me) left this running and it made a bunch of duplicate albums named AllMyStuff, you probably want to clean them all up, then re-run sync and re-associate with the frame.
Caution: this will delete all the photos in these albums on nixplay.  That is probably not a problem, since they are still in your google photos, but if for some reason you manually put photos into an album on nixplay, I wanted to warn.
picsync nixplay delete album AllMyStuff --delete-multiple

After that, run the usual picsync sync.
I apologize, the bug in the logic that allowed creating duplicate albums when the API breaks created a mess.  Thanks again for the report!


Cleanup: Remove legacy invoke tasks

Purpose

Remove some old, unused invoke tasks for running services; we use docker-compose now.
Changes

Delete tasks that run mongo and elasticsearch locally.
Ticket
No ticket

Merged into release/next-djangole. RIP mongo


⚠ Bofrost.at has degraded performance

In e2b9ca0, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1286 ms

Resolved: Bofrost.at performance has improved in 31f45e4 after 14 minutes.


Decode on iam-htr experiment

Hi, I trained the model from the iam-htr example, but when I try to run the decode script it gives the following error
./src/decode_net.sh
ERROR: File "data/lang/lines/char/aachen/te.txt" does not exist!

I did solve this one changing the path with puigcerver partition te.txt file, but then comes another missing file error.
Do you have a running version of the decode part of the iam-htr example?
Thank you,
Manu

I had the same problem, I changed the path to "data/lang/puigcerver/lines/char/te.txt" from the decode_net.sh.
I don't know if this is the solution to our problem, because I had another afterwards (probably, they are not related :
WARNING: compute-wer-bootci was not found, so CER/WER won't be computed!)

The files missing are supposed to get created during the prepare_texts.sh step of the process. However, some refactoring done to that script has left the decode_net.sh script outdated. @jpuigcerver Can you have a look at the changes?
@kleopatramarkou That is just a warning since those metrics are computed using the compute-wer-bootci tool provided with Kaldi. Feel free to use an equivalent tool on the generated transcriptions.

I ended up having a look myself. It should be fixed by 809d9d50ea9c44121d0a33a352dfb945122ad972.
Feel free to close this issue if the problem is solved.

Now it does not give any path error and starts decoding, I get the following error though
UnicodeDecodeError: 'ascii' codec can't decode byte 0xd7 in position 5: ordinal not in range(128)

Seems like the experiment checkpoint being loaded to start the decoding process has some encoding issue. Was it generated using the same machine? Or perhaps using Python 2?

Possibly python 2, I will train and run again.

It works after reinstalling pylaia making sure it runs everything with python3


fix(http): remove unexpectedly changing origin header when unsafe-headers feature enabled

When you use the unsafe-headers feature flag, the website displays CORS-related errors, because when you turn on the unsafe-headers feature flag, tauri automatically set the Origin header to localhost.
This is very confusing, and it is impossible to debug unless you look at the source code.
It will have to be up to developer to set up Origin header value not tauri.
And it doesn't even fit the name "unsafe-headers".
In the first place, why tauri filter the headers by the unsafe-headers feature?
When I first used plugin-http, I had a hard time because a specific header was not recognized by tauri.
May I know why this feature was introduced?
If it's a security issue, it should be fully explained in documentation.

The origin is automatically set, as requested in https://github.com/tauri-apps/plugins-workspace/issues/1167, you can override this behavior by setting the origin using unsafe-headers feature flag or we can add a new option to disable this behavior.

I think it's very confusing to make "automatically setting Origin header" behaviour be able to turn off by turning on another feature flag.
It's just different between possible to change Origin headers and forces default Origin value to some other value.
For convenience, I wish that code gets removed.

I don't mind having an option to disable setting the origin header, and doesn't need to be a feature flag, it could be an option set on each fetch request

yeah adding option to each fetch call would be better because dev doesn't need to read external document for that.

@PeraSite will you be implementing the option in this PR or would you like to close this and create an issue instead of me or someone else can work on it?

@PeraSite would you like to implement the option in this PR or would you like to close this and create an issue instead of me or someone else can work on it?

Let me close this PR first.
And after that, I'll post a new PR to edit ClientOptions type to have unsafe-header boolean.
Also remove #[cfg(not(feature = "unsafe-headers"))] and is_unsafe_header part from the Rust codebases.
Adding fetch parameter should give better experience than Rust's feaature flag.


Install plugins and themes in correct multisite folders

When having multisite folders with different user folders and one installs a plugin or a theme, Grav always installs it in the "root" folders like user/plugins or user/themes.
This PR addresses the issue (cf. https://github.com/getgrav/grav-plugin-admin/issues/319) and fixes it with full backward-compatibilty and without any change to the Grav GPM package system.
However in the future I advise to use streams in the package system, which are resolved to the respective folders in the grav installs of the users. This PR is a step to this direction and (I guess) will be tackled in Grav v2.x.

Yes we definitely plan on moving the CLI stuff to streams.  Probably before Grav 2.x, Maybe even Grav 1.2.

Thanks btw.

As mentioned in getgrav/grav-plugin-admin/issues/319 the easiest work around we now use is to create symlinks for plugins, themes in sites. We do the same for pages/pagetrees from other sites we want to "reuse" in other sites.
Unfortunately this does not solve the CLI issue which we need for automated deployments (and e.g. reindex search)


Getting RuntimeError:  Render window interactor must be initialized before processing events.

Describe the bug
When running the tutorial Compute coherence in source space using a MNE inverse solution, the compiler return an error

RuntimeError: Render window interactor must be initialized before processing events.

at line brain.show_view('lateral')
Actual results
The full tracebackl
---------------------------------------------------------------------------

RuntimeError                              Traceback (most recent call last)

/tmp/ipykernel_23683/1897321839.py in <module>
    139 print('t1')
    140 # Now we can visualize the coherence using the plot method.
--> 141 brain = coh_stc.plot('sample', 'inflated', 'both',
    142                      time_label='Coherence %0.1f Hz',
    143                      subjects_dir=subjects_dir,

~/anaconda3/envs/source_space_mne/lib/python3.9/site-packages/mne/source_estimate.py in plot(self, subject, surface, hemi, colormap, time_label, smoothing_steps, transparent, alpha, time_viewer, subjects_dir, figure, views, colorbar, clim, cortex, size, background, foreground, initial_time, time_unit, backend, spacing, title, show_traces, src, volume_options, view_layout, add_data_kwargs, brain_kwargs, verbose)
    649              src=None, volume_options=1., view_layout='vertical',
    650              add_data_kwargs=None, brain_kwargs=None, verbose=None):
--> 651         brain = plot_source_estimates(
    652             self, subject, surface=surface, hemi=hemi, colormap=colormap,
    653             time_label=time_label, smoothing_steps=smoothing_steps,

<decorator-gen-153> in plot_source_estimates(stc, subject, surface, hemi, colormap, time_label, smoothing_steps, transparent, alpha, time_viewer, subjects_dir, figure, views, colorbar, clim, cortex, size, background, foreground, initial_time, time_unit, backend, spacing, title, show_traces, src, volume_options, view_layout, add_data_kwargs, brain_kwargs, verbose)

~/anaconda3/envs/source_space_mne/lib/python3.9/site-packages/mne/viz/_3d.py in plot_source_estimates(stc, subject, surface, hemi, colormap, time_label, smoothing_steps, transparent, alpha, time_viewer, subjects_dir, figure, views, colorbar, clim, cortex, size, background, foreground, initial_time, time_unit, backend, spacing, title, show_traces, src, volume_options, view_layout, add_data_kwargs, brain_kwargs, verbose)
   1779     else:
   1780         with use_3d_backend(backend):
-> 1781             return _plot_stc(
   1782                 stc, overlay_alpha=alpha, brain_alpha=alpha,
   1783                 vector_alpha=alpha, cortex=cortex, foreground=foreground,

~/anaconda3/envs/source_space_mne/lib/python3.9/site-packages/mne/viz/_3d.py in _plot_stc(stc, subject, surface, hemi, colormap, time_label, smoothing_steps, subjects_dir, views, clim, figure, initial_time, time_unit, background, time_viewer, colorbar, transparent, brain_alpha, overlay_alpha, vector_alpha, cortex, foreground, size, scale_factor, show_traces, src, volume_options, view_layout, add_data_kwargs, brain_kwargs)
   1861                              'mayavi backend')
   1862     with warnings.catch_warnings(record=True):  # traits warnings
-> 1863         brain = Brain(**kwargs)
   1864     del kwargs
   1865

~/anaconda3/envs/source_space_mne/lib/python3.9/site-packages/mne/viz/_brain/_brain.py in __init__(self, subject_id, hemi, surf, title, cortex, alpha, size, background, foreground, figure, subjects_dir, views, offset, show_toolbar, offscreen, interaction, units, view_layout, silhouette, theme, show)
    526                         decimate=self._silhouette["decimate"],
    527                     )
--> 528                 self._renderer.set_camera(**views_dicts[h][v])
    529
    530         self.interaction = interaction

~/anaconda3/envs/source_space_mne/lib/python3.9/site-packages/mne/viz/backends/_pyvista.py in set_camera(self, azimuth, elevation, distance, focalpoint, roll, reset_camera, rigid)
    597                    focalpoint='auto', roll=None, reset_camera=True,
    598                    rigid=None):
--> 599         _set_3d_view(self.figure, azimuth=azimuth, elevation=elevation,
    600                      distance=distance, focalpoint=focalpoint, roll=roll,
    601                      reset_camera=reset_camera, rigid=rigid)

~/anaconda3/envs/source_space_mne/lib/python3.9/site-packages/mne/viz/backends/_pyvista.py in _set_3d_view(figure, azimuth, elevation, focalpoint, distance, roll, reset_camera, rigid)
    994         figure.plotter.camera.SetRoll(figure.plotter.camera.GetRoll() + roll)
    995
--> 996     figure.plotter.update()
    997     _process_events(figure.plotter)
    998

~/anaconda3/envs/source_space_mne/lib/python3.9/site-packages/pyvista/plotting/plotting.py in update(self, stime, force_redraw)
   1401             update_rate = self.iren.get_desired_update_rate()
   1402             if (curr_time - Plotter.last_update_time) > (1.0/update_rate):
-> 1403                 self.right_timer_id = self.iren.create_repeating_timer(stime)
   1404                 self.render()
   1405                 Plotter.last_update_time = curr_time

~/anaconda3/envs/source_space_mne/lib/python3.9/site-packages/pyvista/plotting/render_window_interactor.py in create_repeating_timer(self, stime)
    607         timer_id = self.interactor.CreateRepeatingTimer(stime)
    608         if hasattr(self.interactor, 'ProcessEvents'):
--> 609             self.process_events()
    610         else:
    611             self.interactor.Start()

~/anaconda3/envs/source_space_mne/lib/python3.9/site-packages/pyvista/plotting/render_window_interactor.py in process_events(self)
    629         # Note: This is only available in VTK 9+
    630         if not self.initialized:
--> 631             raise RuntimeError('Render window interactor must be initialized '
    632                                'before processing events.')
    633         self.interactor.ProcessEvents()

RuntimeError: Render window interactor must be initialized before processing events.

Additional information:
Ubuntu 18.04
Issue occur for both Python 3.7 and 3.9.

Hi @agramfort , it is exactly as provided in the website.
https://mne.tools/mne-connectivity/stable/auto_examples/mne_inverse_coherence_epochs.html

"""
==============================================================
Compute coherence in source space using a MNE inverse solution
==============================================================

This example computes the coherence between a seed in the left
auditory cortex and the rest of the brain based on single-trial
MNE-dSPM inverse solutions.
"""
# Author: Martin Luessi<EMAIL_ADDRESS>#
# License: BSD (3-clause)

import numpy as np

import mne
from mne.datasets import sample
from mne.minimum_norm import (apply_inverse, apply_inverse_epochs,
                              read_inverse_operator)
from mne.connectivity import seed_target_indices, spectral_connectivity

print(__doc__)

###############################################################################
# Read the data
# -------------
#
# First we'll read in the sample MEG data that we'll use for computing
# coherence between channels. We'll convert this into epochs in order to
# compute the event-related coherence.

data_path = sample.data_path()
subjects_dir = data_path + '/subjects'
fname_inv = data_path + '/MEG/sample/sample_audvis-meg-oct-6-meg-inv.fif'
fname_raw = data_path + '/MEG/sample/sample_audvis_filt-0-40_raw.fif'
fname_event = data_path + '/MEG/sample/sample_audvis_filt-0-40_raw-eve.fif'
label_name_lh = 'Aud-lh'
fname_label_lh = data_path + '/MEG/sample/labels/%s.label' % label_name_lh

event_id, tmin, tmax = 1, -0.2, 0.5
method = "dSPM"  # use dSPM method (could also be MNE or sLORETA)

# Load data.
inverse_operator = read_inverse_operator(fname_inv)
label_lh = mne.read_label(fname_label_lh)
raw = mne.io.read_raw_fif(fname_raw)
events = mne.read_events(fname_event)

# Add a bad channel.
raw.info['bads'] += ['MEG 2443']

# pick MEG channels.
picks = mne.pick_types(raw.info, meg=True, eeg=False, stim=False, eog=True,
                       exclude='bads')

# Read epochs.
epochs = mne.Epochs(raw, events, event_id, tmin, tmax, picks=picks,
                    baseline=(None, 0),
                    reject=dict(mag=4e-12, grad=4000e-13, eog=150e-6))

###############################################################################
# Choose channels for coherence estimation
# ----------------------------------------
#
# Next we'll calculate our channel sources. Then we'll find the most active
# vertex in the left auditory cortex, which we will later use as seed for the
# connectivity computation.

snr = 3.0
lambda2 = 1.0 / snr ** 2
evoked = epochs.average()
stc = apply_inverse(evoked, inverse_operator, lambda2, method,
                    pick_ori="normal")

# Restrict the source estimate to the label in the left auditory cortex.
stc_label = stc.in_label(label_lh)

# Find number and index of vertex with most power.
src_pow = np.sum(stc_label.data ** 2, axis=1)
seed_vertno = stc_label.vertices[0][np.argmax(src_pow)]
seed_idx = np.searchsorted(stc.vertices[0], seed_vertno)  # index in orig stc

# Generate index parameter for seed-based connectivity analysis.
n_sources = stc.data.shape[0]
indices = seed_target_indices([seed_idx], np.arange(n_sources))

###############################################################################
# Compute the inverse solution for each epoch. By using "return_generator=True"
# stcs will be a generator object instead of a list. This allows us so to
# compute the coherence without having to keep all source estimates in memory.

snr = 1.0  # use lower SNR for single epochs
lambda2 = 1.0 / snr ** 2
stcs = apply_inverse_epochs(epochs, inverse_operator, lambda2, method,
                            pick_ori="normal", return_generator=True)

###############################################################################
# Compute the coherence between sources
# -------------------------------------
#
# Now we are ready to compute the coherence in the alpha and beta band.
# fmin and fmax specify the lower and upper freq. for each band, respectively.
#
# To speed things up, we use 2 parallel jobs and use mode='fourier', which
# uses a FFT with a Hanning window to compute the spectra (instead of
# a multitaper estimation, which has a lower variance but is slower).
# By using faverage=True, we directly average the coherence in the alpha and
# beta band, i.e., we will only get 2 frequency bins.

fmin = (8., 13.)
fmax = (13., 30.)
sfreq = raw.info['sfreq']  # the sampling frequency

coh, freqs, times, n_epochs, n_tapers = spectral_connectivity(
    stcs, method='coh', mode='fourier', indices=indices,
    sfreq=sfreq, fmin=fmin, fmax=fmax, faverage=True, n_jobs=1)

print('Frequencies in Hz over which coherence was averaged for alpha: ')
print(freqs[0])
print('Frequencies in Hz over which coherence was averaged for beta: ')
print(freqs[1])

###############################################################################
# Generate coherence sources and plot
# -----------------------------------
#
# Finally, we'll generate a SourceEstimate with the coherence. This is simple
# since we used a single seed. For more than one seed we would have to choose
# one of the slices within ``coh``.
#
# .. note:: We use a hack to save the frequency axis as time.
#
# Finally, we'll plot this source estimate on the brain.

tmin = np.mean(freqs[0])
tstep = np.mean(freqs[1]) - tmin
coh_stc = mne.SourceEstimate(coh, vertices=stc.vertices, tmin=1e-3 * tmin,
                             tstep=1e-3 * tstep, subject='sample')

# Now we can visualize the coherence using the plot method.
brain = coh_stc.plot('sample', 'inflated', 'both',
                     time_label='Coherence %0.1f Hz',
                     subjects_dir=subjects_dir,
                     clim=dict(kind='value', lims=(0.25, 0.4, 0.65)))
brain.show_view('lateral')

But, I suspect the latest vtk 9.0.3 is the culprit.

It could be VTK 9.0.3. On your 3.7 Python you can use vtk==9.0.1 and see if it helps.
I don't see pyvistaqt installed, so I'm assuming you want this to run in the notebook? In theory it should auto-detect this, but try putting mne.viz.set_3d_backend('notebook') at the top of the example to see if it helps

Thanks for the time entertain this issue @larsoner.
There are two question from your comment above

May I know at which top position do you mean to place the mne.viz.set_3d_backend('notebook'). Place the line just below import mne still give me the error

RuntimeError: Render window interactor must be initialized before processing events.

Currently, I place the   mne.viz.set_3d_backend('notebook') as shown below.
import numpy as np

import mne
mne.viz.set_3d_backend('notebook')
from mne.datasets import sample
from mne.minimum_norm import (apply_inverse, apply_inverse_epochs,
                              read_inverse_operator)
from mne.connectivity import seed_target_indices, spectral_connectivity

data_path = sample.data_path()
subjects_dir = data_path + '/subjects'
fname_inv = data_path + '/MEG/sample/sample_audvis-meg-oct-6-meg-inv.fif'
fname_raw = data_path + '/MEG/sample/sample_audvis_filt-0-40_raw.fif'
fname_event = data_path + '/MEG/sample/sample_audvis_filt-0-40_raw-eve.fif'
label_name_lh = 'Aud-lh'
fname_label_lh = data_path + '/MEG/sample/labels/%s.label' % label_name_lh

May I know there exist any setting to halt program execution until the vtk  is closed when using .py to render the plot.

brain.show_view('lateral',block=True)?
This is because, the 3D viz ui open and close in instance when using .py to render the plot.

May I know at which top position do you mean to place the mne.viz.set_3d_backend('notebook'). Placing this line just below import mne still produce the error

Yeah that's what I had in mind. This will only work if you're running in a jupyter notebook, though. If you're in plain Python or IPython it shouldn't work. (In principle it should raise an error, but it might not...)

May I know whether there exist any setting to halt program execution until the vtk is closed when using .py to render the plot.

I usually run Python in interactive mode, e.g., python -i script.py for this. Or open ipython and do %run script.py, etc.

This will only work if you're running in a jupyter notebook,

The issue still remain,this maybe as I'm using Pycharm in-build Notebook

usually run Python in interactive mode, e.g., python -i script.py for this. Or open ipython and do %run script.py, etc.

Thanks for the trick.
Please advice whether this issue should be closed or otherwise

I think we're good for now, thanks for letting us know it's working @balandongiv !


ci: codespell: add spell checking CI job

The codespell util allows catching typos with minimal false positives, because it uses a list of known common typos along with their correct spelling.
To limit the scope of this CI job to files we actually control, this excludes all external layers and all patch files via the .codespellrc.

Instead of providing a long exclude list, might it be easier to provide the paths to check (mainly meta-lxatac-* and the README.md) as an argument to the codespell call?

Instead of providing a long exclude list, might it be easier to provide the paths to check (mainly meta-lxatac-* and the README.md) as an argument to the codespell call?

Having an exclude list brings the advantage, that new code will be checked, even if the author does not know that it may needs to be added to a list.
The exclude list still fits on a single line on screen. I would be fine with that.

Hi,

Instead of providing a long exclude list, might it be easier to provide the paths to check (mainly meta-lxatac-* and the README.md) as an argument to the codespell call?

Having an exclude list brings the advantage, that new code will be checked, even if the author does not know that it may needs to be added to a list. The exclude list still fits on a single line on screen. I would be fine with that.

looks like we've look into this PR at this at the same time. While you wrote this comment I went ahead and updated the PR to use the explicit list suggested by @ejoerns.
Do you think we should keep it that way? I don't have a strong opinion either way.

looks like we've look into this PR at this at the same time. While you wrote this comment I went ahead and updated the PR to use the explicit list suggested by @ejoerns. Do you think we should keep it that way? I don't have a strong opinion either way.

Well, bad timing. I don't have a strong opinion either.  So let's stick to the explicit list.


Add script update disease name - script flags disease names to be updated (dyadic names)

scripts/misc/dump_database.pl

add option --column-statistics=0

Add script scripts/python/update_disease_names.py

this script prints to a file which diseases can be updated in the db to use the dyadic name

This script is not necessary.
We can update the disease names when we run the migration (https://github.com/EBI-G2P/ensembl-gene2phenotype/pull/95)


Dump instanceIDs for master nodes in clusterloader

Idea:
If we start dumping instanceIDs for master nodes in gce tests and write it to 'finished.json' this information will be then available in k8s-gubernator.build.all and can be used for programmatically analyzing runs.
Usage: this PR writes 'cl2-metadata.json' file. If we include this file in --metadata-sources, it should be merged into finished.json which is what we need.

/assign @mm4tt

/assign @mm4tt

Fixed, ptal

Fixed, ptal

/lgtm
/unhold

/lgtm
/unhold


mendeley: 1.17.8 -> 1.17.9

Motivation for this change
Minor version bump (which app prompts about :)).
Things done

[x] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

https://www.mendeley.com/release-notes/ looks okay


feat: add workspace layout to user page

Description
Implement WorkspaceLayout component and wrap it on the existing user page

Related Tickets & Documents
Closes #3520
Related to #2780

Mobile & Desktop Screenshots/Recordings
https://github.com/open-sauced/app/assets/20603494/80180914-4e60-4c05-87ec-074061b84a98

Steps to QA

Tier (staff will fill in)

[ ] Tier 1
[ ] Tier 2
[x] Tier 3
[ ] Tier 4

[optional] What gif best describes this PR or how it makes you feel?

What's with the space in the layout?

Was going to mention the same, but @bdougie beat me to it. Once that is sorted, this should be good to go as the sidebar works.

Fixed! This will also close #3524! This required removing padding and margins from the WorkspaceLayout, causing layout shifts to every other page already using it. So if you see changes to other pages, that's me adding the padding back to avoid errors (see workspace home below).
cc. @bdougie @nickytonline

Padding now seems broken on the workspaces page?
Deploy preview:

### Beta:

Just like we have a footer slot in the workspaces layout, maybe a header slot will help with the spacing issues while still preserving the layout of pages already using the workspaces layout.
https://github.com/open-sauced/app/blob/8eb580dd723f81ef169af26830e74f2ed2a1fa42/components/Workspaces/WorkspaceLayout.tsx#L84-L88

Just like we have a footer slot in the workspaces layout, maybe a header slot will help with the spacing issues while still preserving the layout of pages already using the workspaces layout.
https://github.com/open-sauced/app/blob/8eb580dd723f81ef169af26830e74f2ed2a1fa42/components/Workspaces/WorkspaceLayout.tsx#L84-L88

I'll be adding the padding to each individual page, otherwise it would break the padding fix for the user page.