Whitelisting Server IP addresses information in the Networking docs

Summary
The Things Stack uses a port per the protocol and we have default ports listed here that should be allowed to connect with TTS. Information on whitelisting Server IP addresses would be needed for few customer scenarios.
Why do we need this?
Using The Things Stack behind the firewall.
What is already there? What do you see now?
The Current documentation contains the Default Ports used by the protocols in TTS. Ref: https://www.thethingsindustries.com/docs/reference/networking/#port-allocations
What is missing? What do you want to see?
Information on the Server IP addresses, i.e., whitelisting IP addresses information while using TTS.
Insights:
The Things Stack Cloud clusters are currently deployed to the following AWS regions:
eu1: eu-west-1
nam1: us-west-1
au1: ap-southeast-2

Ref: The Things Stack Cloud

As we are working with the public cloud, it is possible that the IP addresses change and we can’t make any commitments to keeping the same IP addresses over time. One can refer to the AWS IP address ranges to know the IP addresses range of the above-mentioned AWS regions.
To use dedicated IP addresses, users might opt to have a dedicated cloud-hosted deployment. Ref: Deployment Options
If hosting on your own, as per the ECS docs,

All incoming connections to The Things Stack will use the IP addresses of the NLBs, and all outgoing connections will use the IP addresses of the NGWs. This means that you can use these IP addresses in the firewall rules for gateways that need to connect to your deployment, and on other servers that need to connect to your deployment or receive connections (webhooks) from it.

How do you propose to document this?
...
Can you do this yourself and submit a Pull Request?
No. @benolayinka

I'm not sure what you mean - if using The Things Stack Cloud, TTI manages the instance and port allocation. You just need to be able to use HTTPS to access the console. Or do you mean that some firewalls are blocking access to the ECS IP address that TTS Cloud is hosted on? Can't they just whitelist the DNS address instead?

@benolayinka
As you rightly pointed, suggested method would be to whitelist the DNS. But few users of The Things Stack Cloud request if they can whitelist IP addresses instead of DNS address. So, we need to document the recommended way is to whitelist DNS and IP addresses change as we work with public cloud. However, they can refer the AWS reference to know and whitelist the entire address range if they prefer that way.


MOAR DATA

Hello,
I'm working on bringing up an ARPANET using emulated IMPs.  Naturally I find your map very exciting!
I have access to old host tables.  Do you want more detailed data for your map?

As for topological data, look here:
http://mercury.lcs.mit.edu/~jnc/tech/arpageo.html
http://mercury.lcs.mit.edu/~jnc/tech/arpalog.html


Clean minor things.

Codecov Report

Merging #372 into master will increase coverage by 0.04%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #372      +/-   ##
============================================
+ Coverage     89.82%   89.86%   +0.04%
  Complexity      565      565
============================================
  Files            95       95
  Lines          2171     2171
  Branches        176      176
============================================
+ Hits           1950     1951       +1
+ Misses          181      180       -1
  Partials         40       40

Impacted Files
Coverage Δ
Complexity Δ

...va/io/opencensus/trace/internal/RandomHandler.java
75% <ø> (ø)
1 <0> (ø)
:arrow_down:

...n/java/io/opencensus/trace/config/TraceParams.java
100% <ø> (ø)
3 <0> (ø)
:arrow_down:

...ensus/trace/internal/ThreadLocalRandomHandler.java
50% <ø> (ø)
1 <0> (ø)
:arrow_down:

api/src/main/java/io/opencensus/trace/Span.java
100% <ø> (ø)
9 <0> (ø)
:arrow_down:

...in/java/io/opencensus/trace/base/TraceOptions.java
97.05% <ø> (ø)
18 <0> (ø)
:arrow_down:

...a/io/opencensus/trace/export/RunningSpanStore.java
81.81% <ø> (ø)
1 <0> (ø)
:arrow_down:

...va/io/opencensus/trace/export/ExportComponent.java
100% <0%> (+14.28%)
3% <0%> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 175ff38...9add7ad. Read the comment docs.


[OTHER] The issue template is coded via Node?

What would you like to share?
Is the issue template coded via Node?
Additional information
No response

The Labels are defined here

The Labels are defined here

Then why don't the labels defined work? #62

I think the labels defined in the templates aren't available in the repo. We are using standard-labels across all Eddiehub-projects, thats probably the issue 🤔

I think the labels defined in the templates aren't available in the repo. We are using standard-labels across all Eddiehub-projects, thats probably the issue 🤔

Oh ok.

Query Resolved... Closing


Broken images in components pages

There are several broken images on multiple component pages (mostly the style pages).
I'm not sure if it's formatting or the images have been moved

There is an image grid custom component on the old website that didn't get ported over thats causing most of the issues. working on it now.


[docs] Use present tense for bool prop descriptions

-If `true`, the accordion will be displayed in a disabled state.
+If `true`, the accordion is displayed in a disabled state.

-If `true`, screens this size and down will be hidden.
+If `true`, screens this size and down are hidden.

Rule added in https://trello.com/c/1Q7hqXHu/2714-technical-documentation-guidelines.


[Japanese] Add support for language

Should be:

[x] Add ja / app_i18n.json
[x] Add ja / client_strings.js
[x] Get tables from game in langauge
[x] get trade site static json
[x] add ja to all langauge build
[x] add Japanese trade site
[x] add Japanese language
[ ] Other stuff? - probably a bunch more

ja
https://jp.pathofexile.com/api/trade2/data/filters
https://jp.pathofexile.com/api/trade2/data/items
https://jp.pathofexile.com/api/trade2/data/static
https://jp.pathofexile.com/api/trade2/data/stats

Most now done, currently dealing with a dependency upgrade caused by having to repoll data files from game data.
Noticing some problems that will NOT be solveable probably.

fake pseudo will not be supported since it depends on old json files that were never generated for new languages. This could be done but it would be fully manually which is not worth the time for, again, something ggg will eventually make obsolete.
A few other minor problems like above, where they were dependent on originally generated json files.


Update circe-generic to 0.14.1

Updates io.circe:circe-generic from 0.12.3 to 0.14.1.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "io.circe", artifactId = "circe-generic" } ]

labels: library-update, semver-minor

Superseded by #192.


[diem-transactional-tests] migrate remaining tests + nuke functional tests -- 3/3

This gets all remaining functional tests migrated and gets rid of the old testsuite and infrastructure.
It also adds some minor features to the diem-transactional-test-harness, in order to support some rare test cases:

Support for multi agent transaction scripts
An --override-signer flag that would allow you to sign and send the transaction from an address that's different from the module's. (I would consider this a hack and would love to get it removed in the future, but right now it seems like the easiest way to get those tests fixed.)

There is also one test (account_limits/test.move) that had already been in a broken state, and it didn't seem to be easily repairable, so I simply copied it over and disabled it by changing the file extension from ".move" to ".broken".

/land

:broken_heart: Test Failed - ci-test

/land


Getting "RestoreFailed" error

If you are creating an issue for a BUG please fill out this information. If you are asking a question or requesting a feature you can delete the sections below.
Failure to fill out this information will result in this issue being closed. If you post a full stack trace in a bug it will be closed, please post it to http://gist.github.com and then post the link here.
Bug Information
Hello James,
Our iOS app being rejected by the app store as they are getting the "RestoreFailed" error. We tried to reproduce the error and also We are getting the error. But, the error occurrence rate is intermittent. We have been facing this issue since last 3 weeks. We were used version 5.6.1(got the error) and currently upgraded  to 6.6.1. but, still issue is not resolved. Can you please let us know what are the chances to get this error? Please let us know the solution for this error ASAP.
Thank you.
Device Tested On: iPhone 13 and iPad
Simulator Tested On: NA
Version of VS:  Visual studio community edition 2019
Version of Xamarin: <IP_ADDRESS>5
Versions of other things you are using:
Steps to reproduce the Behavior

Click on sign-in button
Executes the line  var getPurchases = await CrossInAppBilling.Current.GetPurchasesAsync(ItemType.Subscription);

Expected Behavior
Get purchase history
Actual Behavior
Exception: "RestoreFailed"
Code snippet
var getPurchases = await CrossInAppBilling.Current.GetPurchasesAsync(ItemType.Subscription);
Screenshotst

@PonyOny , @nishitgupta3 Hi. I have seen your comment in closed issue which is related to "restore transaction failed". Is it resolved to you or still you have?

We are having the same issue utilizing the InAppBilling plug-in. After submitting our build to Apple for release to Production, Apple keeps rejecting the build as they keep conveying during their testing they are receiving the "RestoreFailed" error when they try to Sign In to our App. We are not able to reproduce it. Further, we have had no issues like this over the past year and we have made no changes to the Sign In code and have been submitting new builds at least once per month. @jamesmontemagno - please help and provide your feedback.

I haven't seen this at all. Maybe don't display the pop up and just re-try? I have not seen this issue.

Please try https://www.nuget.org/packages/Plugin.InAppBilling/6.7.1-beta

I am having the same issue, wondering if and how you were able to resolve this?

iOS sand-box Test?
I set up a subscription sandbox test on iOS like this.
[iPhone Settings]
Settings -> App Store >Sandbox Test

[appstoreconnect.apple.com Settings]
https://github.com/jamesmontemagno/InAppBillingPlugin/assets/42885949/0862076d-891b-4e5d-813f-a2ce5448ad89
Before testing, try clearing your purchase history in appstoreconnect.

After getting this issue again, I check for restore failed message, if it occurs then do the same call a second time and it is successful.


refactor transaction titles

closes #261

is it supposed to look like this?

well, it's like before. Still fighting with that react data table, where the title column is supposed to grow when space is available, which works quite well on history page transactions table but for whatever reason in this small space it shrinks correctly but the table is still pushed in overflow for whatever reason

table does lots of auto-calculation based on actual content so not sure how much I can influence this with CSS-only, or the possible table settings. Hacked something in so scrollbar shouldn't be there, which is fine as long as the time text is not super long


librarycarpentry/lc-spreadsheets

tracking issue for https://github.com/librarycarpentry/lc-spreadsheets

[x] (maybe) address missing anchors

episodes/02-common-mistakes.md:38 [missing anchor]: [Using formatting to make the data sheet look pretty](#formatting_pretty)
episodes/02-common-mistakes.md:41 [missing anchor]: [Field name problems](#field_name)

fixed in c4e0c0fe5573a9df1dccacf4597e8e316d513a6a


Fix/dartagnan optimize

Depends on #26

Can you explain what was broken? (I cannot infer it from the changes in the code)

@hernanponcedeleon The explanation is contained in the commit message. I am not sure how to make it appear in the PR.

Following the same pattern in check_genmc.go, dartanan checker
should first check if the command has been canceled or the
timeout has been reached before it looks whether the call to
dartagnan returned an error.

If the context times out or is canceled (ctrl-c), the child process gets killed and possibly returns with an error. If we just check is err != nil, we'll think that the program had an issue. So first we have to check whether the context caused the program to be stopped and if not we then should check if the subprocess returned with an error. This pattern was used in check_genmc.go but not in genmc_dartagnan.go.
The consequence is that vsyncer optimize  with dartagnan was not able to distinguish whether the check (the subprocess) failed due to time or some internal error. That lead the optimization to ignore the cases where timeout supposedly indicate a good barrier selection.


Add YangKeao to maintainer

What problem does this PR solve?
What is changed and how does it work?
Check List
Tests

No code

Code changes

No

Side effects

No

Related changes

No

Codecov Report

Merging #190 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #190   +/-   ##
=======================================
  Coverage   39.47%   39.47%
=======================================
  Files          17       17
  Lines         608      608
=======================================
  Hits          240      240
  Misses        337      337
  Partials       31       31

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44979cf...26bf1e7. Read the comment docs.


Missing documentation for unsupported combination in RandomSplitter

Hello,
using the RandomSplitter I have verified that there is a combination actually not supported (why?) which is not documented. I think that can be useful for users to be aware of this behaviour. In fact, in this case the resulting splits are completely empty and isn't displayed any error message.
See this for reference: https://github.com/recommenders/rival/blob/master/rival-split/src/main/java/net/recommenders/rival/split/splitter/RandomSplitter.java#L99
Cheers,
Alessandro

Thank you for noticing.
Indeed, it is a problem since there is no warning displayed.
Thanks again.
Alejandro

If you want I have implemented a simple fix in my fork. Here there is the related commit: https://github.com/aleSuglia/rival/commit/e7d347f0cc35ab78d0c9084888145d9f63e8fc52

@aleSuglia please do a pull request.


Get the request protocol from express request.

This seems fine, but we might be safer with request.protocol || 'http' since this module tends to be used in contexts with mocked requests that don't necessarily have a full set of properties.

might also be worth looking at req.secure too

@kshay ping


Code Review PR

Start of the code review PR.

This PR is ready for your review.


Best way to override renderer rules?

I'm working on something where users can use markdown.  I'd like for all of the links to open in a new window.  The following code works, but is this the best way to achieve this?
var md = new markdownit("default", {
	breaks: true, linkify: true, typographer: true
});
//Override link render to open all link in a new window
md.renderer.rules.link_open = (tokens, idx) => {
	var title = tokens[idx].title ? (' title="' + md.utils.escapeHtml(md.utils.replaceEntities(tokens[idx].title)) + '"') : '';
	return '';
};

I also want to allow fenced code to have a simpler syntax where you don't need to have the triple backticks on their own lines.  Input example would be:
```for (var i = 0; i <= items.length; i++) {
  console.log(i);
}```

How can I achieve this?  Right now I've got a hacky partial solution where it treats the language parameter as the first line of code, but the last line isn't seen.
//allow simpler fenced code
md.renderer.rules.fence = (tokens, idx, options) => {
	var token = tokens[idx];
	console.log(token)
	return '
'
		+ md.utils.escapeHtml(token.params+"\n" +token.content)
		+ '
\n';
};

I know this isn't a good solution, and it seems like md.renderer.rules.fence isn't the right place to do this sort of thing.  How can I achieve this?

You can copy fence rule and rewrite it as you need. See existing plugins as start point (those add different rules types). Markdown-it allows to replace existing rules and renderers if you don't like those.

Thanks for the point in the right direction.  I've got something started for the fence override, but I think I need a little help getting it to work the way I want.
This is my test input:
test here ```//Some nice preformatted code!
for (var i = 0; i <= items.length; i++) {
  console.log(i);
}``` more here

And this is my copy/paste of the built in fence rule with my attempts to modify it.  Can anyone point me in the right direction to get this to work?
I've got a working demo here: http://jsfiddle.net/rz9qkk8d/4/
function fence(state, startLine, endLine, silent) {
    var marker, len, params, nextLine, mem,
	haveEndMarker = false,
	markerStartPos = state.bMarks[startLine] + state.tShift[startLine],
	max = state.eMarks[startLine];

  if (markerStartPos + 3 > max) { return false; }

	marker = state.src.charCodeAt(markerStartPos);
	if (marker !== 0x60 /* ` */) {
		return false;
	}

	// scan marker length
	mem = markerStartPos;
	markerStartPos = state.skipChars(markerStartPos, marker);

	len = markerStartPos - mem;

	if (len < 3) { return false; }

	console.log(state)

	//Locate the language name
	//params = state.src.slice(markerStartPos, max).trim();

	//if (params.indexOf('`') >= 0) { return false; }

	// Since start is found, we can report success here in validation mode
	if (silent) { return true; }

	// search end of block
	nextLine = startLine;

	for (; ;) {
		nextLine++;
		if (nextLine >= endLine) {
			// unclosed block should be autoclosed by end of document.
			// also block seems to be autoclosed by end of parent
			break;
		}

		markerStartPos = mem = state.bMarks[nextLine] + state.tShift[nextLine];
		max = state.eMarks[nextLine];

		//if (pos < max && state.tShift[nextLine] < state.blkIndent) {
		//	// non-empty line with negative indent should stop the list:
		//	// - ```
		//	//  test
		//	break;
		//}

		if (state.src.charCodeAt(markerStartPos) !== marker) { continue; }

		//if (state.tShift[nextLine] - state.blkIndent >= 4) {
		//	// closing fence should be indented less than 4 spaces
		//	continue;
		//}

		markerStartPos = state.skipChars(markerStartPos, marker);

		// closing code fence must be at least as long as the opening one
		if (markerStartPos - mem < len) { continue; }

		// make sure tail has spaces only
		markerStartPos = state.skipSpaces(markerStartPos);

		if (markerStartPos < max) { continue; }

		haveEndMarker = true;
		// found!
		break;
	}

	// If a fence has heading spaces, they should be removed from its inner block
	len = state.tShift[startLine];

	state.line = nextLine + (haveEndMarker ? 1 : 0);
	state.tokens.push({
		type: 'fence',
		params: params,
		content: state.getLines(startLine, nextLine, len, true),
		lines: [startLine, state.line],
		level: state.level
	});

	return true;
};

md.block.ruler.at('fence', fence);
md.renderer.rules.fence = function (tokens, idx, options) {
	var token = tokens[idx];
	return "<pre>" + md.utils.escapeHtml(token.content) + "</pre>\n";
};

Your input does not fit in possible markdown markup. "```" can't start/ent in the middle of text content. In your first question difference was only in first line (content instead of params).
Second example can't be parsed with this parser. It's writen for markdown and expects some minimal conventions. I think, it's better to read commonmark spec prior to try any modifications.

Closed - no activity.

Hey @puzrin can u help?
with the new version of markdown-it how i can implemente this:
//Override link render to open all link in a new window
md.renderer.rules.link_open = (tokens, idx) => {
    var title = tokens[idx].title ? (' title="' + md.utils.escapeHtml(md.utils.replaceEntities(tokens[idx].title)) + '"') : '';
    return '';
};

token.attrPush([ 'target', '_blank' ]); anywhere, then forward to default renderer. if you need something else - add more details what you need to reach.

actually i need make that all links rendered with markdown-it have a target _blank in the code that i put before what i have to change to make it work with the new version?
something like this??
//Override link render to open all link in a new window
md.renderer.rules.link_open = (tokens, idx) => {
    token.attrPush(['target', '_blank']);
};

That's full logic, can be reduced:
val old_render = md.renderer.rules.link_open;

md.renderer.rules.link_open = (tokens, idx, options, env, self) => {
    token[idx].attrPush(['target', '_blank']);

   if (old_render) {
     old_render(tokens, idx, options, env, self);
   } else {
     self.renderToken(tokens, idx, options);
   }
};

Or patch attributes in core chain:
https://github.com/markdown-it/markdown-it-for-inline#use (example 3)

thank you some much thats helps a lot.
Nice work.

Simplified snippet.
If you have some time - write me summary about problems you had on migration to 4.0. I'll try to update dev docs with better examples.

actually im new in markdown world and the idea behind how work a markdown parser is new to me.
If i have to say something about how start making plugins for dummies is better get the most simple examples to get inside of this world.
Sorry for my english not is my native language.

https://github.com/markdown-it/markdown-it/tree/master/docs there are general advices for devs.


conversion time and intervals

Nice work, just what i needed but ran into an issue.
I tried a conversion time of 1000 millis but i only get 1 reading, the 1500 millis as in the example works until....
If _conversionMillis is higher than the set interval, requestTemperature is never called, should not be a problem if the interval is higher than 750 millis for 12 bit but there is a catch..
_conversionMillis is adaptive to the actual conversion time but that is where the problem is, the time calculated for the new _conversionMillis   includes the overhead in my main loop, not the actual convertion time of the sensor so in my main loop i interact with a rotary encoder, switchs menus, rebuild a screen etc, the time this takes is included in the new _conversionMillis and once this is higher than the set interval, no more readings.
This is also why it does not work with a setting of 1000 millis because i build my screen at the start and that takes a little bit more time than the interval.

@Jay-esp So you have some procedure that is taking longer than the set interval. Are you using delay function in your main loop?

No delays but yes the screen handling can take some time but its the adaptive part that is causing it, it should not adapt the timing or at least have a switch on it to disable, after all we more or less know how long the real conversion will take, once triggered it is not depending on what goes on in the loop, i solved it by using the raw code i used before but split it up, a start of conversion, no longer wait for it but check back in my loop after enough time has expired and then read it


add model_info_local argument to download function

Motivation
We want to parse model info from remote when using download function. Fixes https://github.com/open-mmlab/mim/issues/51
Modification
add model_info_local argument to download function.
BC-breaking (Optional)
Previous usage is not affected.

Thanks for your contribution. But why we need download a checkpoint from remote GitHub.

Thanks for your contribution. But why we need download a checkpoint from remote GitHub.

@zhouzaida because model_zoo.yml file may not be available at local.

got it

Got it. Please add an unittest. Another thing is that the config file can not be obtained from remote because the config is parsed from the local repo.

Got it. Please add an unittest. Another thing is that the config file can not be obtained from remote because the config is parsed from the local repo.

@zhouzaida it is also an issue. wheel package of mmdetection does not include configs directory and mim gives an error when trying to find config load from local. I have created a separate issue for that: https://github.com/open-mmlab/mim/issues/50

@zhouzaida added tests for model_info_local=False.

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@1bb17cd). Click here to learn what that means.
The diff coverage is n/a.

:exclamation: Current head eb35cce differs from pull request most recent head 74e8203. Consider uploading reports for the commit 74e8203 to get more accurate results

@@           Coverage Diff           @@
##             main      #49   +/-   ##
=======================================
  Coverage        ?   63.82%
=======================================
  Files           ?       21
  Lines           ?     1562
  Branches        ?      347
=======================================
  Hits            ?      997
  Misses          ?      430
  Partials        ?      135

Flag
Coverage Δ

unittests
63.82% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bb17cd...74e8203. Read the comment docs.


OpenSSL disabled ripemd160

Around November 2021, OpenSSL disabled the ripemd160 algorithm by default, so that hashlib.new('ripemd160') fails.

To fix, follow instructions here.


BUG: avoid segfault in ndimage.fourier_ellipsoid with length-1 dims

Reference issue
Closes gh-12763
What does this implement/fix?
Replaces a segmentation fault with a ValueError.
The three python functions ndimage.fourier_ellipsoid, fourier_gaussian and fourier_uniform call the C function NI_FourierFilter in ndimage/src/ni_fourier.c. If the size of any of the dimensions of the supplied input array is less than 2 a segmentation fault occurs in the C code. This PR checks the input array dimension sizes and raises a ValueError instead.
The new code is in the C function rather than repeated 3 times in the python functions.
Additional information
Test added and docstrings updated.

It looks to me like the code is trying to support length-1 dims, it just has a logic bug. Gaussian and Uniform modes always guard their array accesses with if (params[kk]) but ellipsoid doesn't.
If you look at the if-else starting on Line 298, it's even trying to handle to the size 1 case. Only it does it by accessing the unallocated array:
if (params[hh]) {
   // ..
}
else if (PyArray_DIM(input, hh) > 0) {
    params[hh][0] = 1.0;
}

So, I think allocating the array unconditionally when filter_type == _NI_ELLIPSOID would be an appropriate fix.

@peterbell10 Following your recommendation, I've changed this PR so that ndimage.fourier_ellipsoid now supports length-1 dimensions. I've also modified one of each of the fourier_ellipsoid, fourier_gaussian and fourier_uniform tests to show that they all support length-1 dimensions.
Commits squashed to remove changes that I subsequently reverted.

Now this PR only changes fourier_ellipsoid, the other two functions fourier_gaussian and fourier_uniform remain as they were.
Added a test for zero-length dimensions. There are quite a few parameter combinations which may be overkill.

Thanks @ianthomas23. Remaining CI failure is just a failed download, so merging.


Revert "Make jQuery 2.0 the minimum supported version."

LGTM. Will merge as soon as Travis finishes.

Ah, right. Freaking https://github.com/travis-ci/travis-ci/issues/5092

Thank you!

Thank you!


docs: fix typos

Hey :wave:,
This PR will fix :
1 typo in docs/build/get-started.md
Best!

Dear @pgrimaud - wow - thank you so much for this helpful PR! SO GOOD - just merged it!
With this merge, if you are interested, you're eligible to claim this XMTP contributor POAP!
Let me know if you have any questions - and again - sending you much gratitude!


No field String("x") in record

Following code complains
No field String("data") in record Playground.this.Data with shapeless.labelled.KeyTag[Symbol with shapeless.tag.Tagged[String("data")],Playground.this.Data] :: shapeless.HNil

import shapeless._
import shapeless.syntax.singleton._
import shapeless.record._

case class Data(a: Int, b: Int)

type P = Record.`'data->Data`.T

def encode(p: P) = p("data")

https://scastie.scala-lang.org/4ZETdquzQeiYQwoqAdaHJw

Try p('data) instead of p("data"). You'd better to ask questions in the gitter channel than in github issues.

Thanks for that @guersam ... yup, the gitter channel is the best place to ask questions :-)


[INLONG-5967][Manager] Add save and delete interfaces of cluster management in OpenAPI

Prepare a Pull Request
(Change the title refer to the following example)

Title Example: [INLONG-XYZ][Component] Title of the pull request

(The following XYZ should be replaced by the actual GitHub Issue number)

Fixes #5967

Motivation
Explain here the context, and why you're making that change. What is the problem you're trying to solve?
Modifications
Describe the modifications you've done.
Verifying this change
(Please pick either of the following options)

[ ] This change is a trivial rework/code cleanup without any test coverage.

[ ] This change is already covered by existing tests, such as:
(please describe tests)

[ ] This change added tests and can be verified as follows:
(example:)

Added integration tests for end-to-end deployment with large payloads (10MB)
Extended integration test for recovery after broker failure

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
If a feature is not applicable for documentation, explain why?
If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation

The registration process of sort-standalone task will be interageted into manager sdk, instead of openapi

the cluster managerment will be done by the users, instead of integrating it in inlong manager


undefined reference error in compiling

What's your question?
undefined reference error in compiling
Additional Context
I used centoOS 7 and openssl version is OpenSSL 1.0.2k-fips  26 Jan 2017.
get error while compiling
/opt/rh/devtoolset-9/root/usr/libexec/gcc/x86_64-redhat-linux/9/ld: librestpp_lib.a(auth.cpp.o): in function jwt::algorithm::rsa::verify(std::string const&, std::string const&, std::error_code&) const': *****/jwt-cpp/jwt.h:957: undefined reference to EVP_MD_CTX_destroy'
/opt/rh/devtoolset-9/root/usr/libexec/gcc/x86_64-redhat-linux/9/ld: *****/jwt/jwt-cpp/jwt.h:957: undefined reference to `EVP_MD_CTX_create'
collect2: error: ld returned 1 exit status

What version of jwt-cpp are you using?

0.6.0 thanks for your reply

🤔 hmm are you sure about that version of openssl is the one being pulled into your build scripts and being linked against?
I've not used devtoolset-9 but perhaps it has a never version? You could run scl enable devtoolset-9 "openssl --version" to check.

I wanted to double check the docs but I am only getting a 404 https://www.openssl.org/docs/man1.0.2/man3/EVP_MD_CTX_destroy.html
This should be the correct logic, in 1.1.0 they changed everything to free
https://github.com/Thalhammer/jwt-cpp/blob/ce1f9df3a9f861d136d6f0c93a6f811c364d1d3d/include/jwt-cpp/jwt.h#L486
You can check the CI but we compile from source and test each one
https://github.com/Thalhammer/jwt-cpp/blob/ce1f9df3a9f861d136d6f0c93a6f811c364d1d3d/.github/workflows/ssl.yml#L14

i used the command  scl enable devtoolset-9 "openssl --version"
it returns OpenSSL 1.0.2k-fips  26 Jan 2017.

more info
if i use  auto verify = jwt::verify().allow_algorithm(jwt::algorithm::hs512{jwt_secret}).with_issuer("auth0"); in my project, it compiles OK.
but i add the other verify = jwt::verify().allow_algorithm(jwt::algorithm::rs256(private_key, "", "", ""))
.with_issuer("auth0"); in my project, then it returns undefined reference error by compiler.
I think it may related to rs256 algorighm?

Can you comment out the library code and print OPENSSL_VERSION_TEXT https://www.openssl.org/docs/manmaster/man3/OPENSSL_VERSION_NUMBER.html
How are you linking to OpenSSL? What build system are you using?

I think it may related to rs256 algorighm?

Yes the cryptographic keys use the evp context, the hmac   is very basic (and insecure) so it doesn't use APIs that have changed

seems like i use openssl 1.1.0 version for linker but i have another openssl 1.0.2 version installed on my machine.

I highly recommend using a package manager to manage  3rd party dependencies.
Unfortunately there is jot much I can , I will mark this as closed. Bestnof luck!


Fraction bars aren't rendered as text

I know this might be beyond the scope of this project, but the CSS text attribute doesn't include fraction bars. The result, in my case, is that the transparency I'm attempting to use (background-clip: text;) doesn't render. This is x/0, which renders normally elsewhere:

Thanks for considering, let me know if I can provide further documentation!

Also, it's worth mentioning I love this tool -- I built a whole project around using MathJax!

This sounds like an issue with the rendering output of MathJax, which is outside the scope of this repo. You'd want to report that on the MathJax repo.


Add support for plugins actions

Hi @BretCameron,
First of all, thank you for this amazing plugin! It's really useful and save me a lot of time and headaches. 🙏
I have a feature request : as of now, you handle the api routes (contentTypes), but in my company case, we would want to give access to plugin too.
Do you think it's possible to add it as a plugin feature?
Some examples of our app needs:

listLocales from i18n plugin, to define the enabled locales in our app
find from redirects plugin
 to handle in-app redirections.

If you don't have the time or inclination to implement this feature, could you help me a bit so that I could open a PR?
Thank you very much!

Thank you for the feature suggestion!
I think we could add a separate config argument for plugins, since I don't think they'll play nicely with the wildcard feature we have for API actions.
I will look into this in the coming week.

The plugins configuration option has been added in v0.2.0.
I hope this is useful!

Thank you very much, really appreciated!


0.3.0 not released on pip?

Hi, I'm excited for the new LocStream capabilities shown in the docs, but I don't think the latest 0.3.0 is released on pip even though it's advertised in the docs and tagged under releases.
Thanks!

Should be fixed now!


Godeps

Updates the project to use Godeps instead of gpm.  Main goal is to get this project building with standard go tools and without symlinking. This reduces the friction for new coders to get up and going, especially Windows go developers.

Went with Nut instead.  #331.


Add a synchronous method for executing plain sql queries

I haven't exhuastively filled out the subclasses of DBIOAction, but this seems to work for my use cases. With this implicit you can now do
db.withSession { implicit session =>
  sql"SELECT * FROM foo".head.run
}

I'd like to add some test coverage, but first I figured I'd get some feedback

Slick 2 compatible API to help existing Slick 2 users to move to Slick 3. So I would not like to add another methods or features to blocking-slick.
In blocking-slick, you can run plain sql synchrnously as following. This is the Slick2 way:
https://github.com/takezoe/blocking-slick/blob/1172c5117144fd5ce36605c3513309a2391a6ac1/src/test/scala/com/github/takezoe/slick/blocking/SlickBlockingAPISpec.scala#L55-L79

It could be an idea to 'hide' this functionality behind a separate import or something?

The execute method only works for basic sql actions, my extension works with chained flatMaps and andThens. My project was slick 2 and when I updated it to slick 3 there were some parts I wanted to upgrade to slick 3 async style, and some parts I couldn't.
I'd like to see it merged in, but if you think it's too obscure of a use case for your library that's also fine. At least this pr is here for anyone with the same problem to google into.

Also, I should mention, thanks so much for this library! I was stuck on slick 2 for years before I found this

I understood. It seems to be nice help for moving to Slick3 gradually. 👍

If you don't want this pr, can I make another one to make this protected?
https://github.com/takezoe/blocking-slick/blob/master/src/main/scala/com/github/takezoe/slick/blocking/BlockingProfile.scala#L24
That will let me subclass BlockingAPI and have these changes locally

That's unnecessary. I would like to merge this PR, but I want you to add tests and also update README.md to let users to know this feature helps to port Slick2 style code to Slick3 style gradually.

@drapp Hi! What is your status? I want to proceed this pull request as below:

I would like to merge this PR, but I want you to add tests and also update README.md to let users to know this feature helps to port Slick2 style code to Slick3 style gradually.
Should I merge this pull request once? or are you going to do additional work in this pull request?

I'm on vacation this week. I'll add the tests next week, sorry about the
delay
On Fri, Oct 13, 2017 at 11:26 AM Naoki Takezoe<EMAIL_ADDRESS>wrote:

@drapp https://github.com/drapp Hi! What is your status? I want to
proceed this pull request as below:
I would like to merge this PR, but I want you to add tests and also update
README.md to let users to know this feature helps to port Slick2 style code
to Slick3 style gradually.
Should I merge this pull request once? or are you going to do additional
work in this pull request?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/takezoe/blocking-slick/pull/33#issuecomment-336531789,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABVZ8PfQuO67sUd8Ske4vT55AGBgtNLjks5sr6tRgaJpZM4Pv1LN
.

@drapp No problem. Enjoy vacation! 😄

added the readme comment and tests

Thanks!

@drapp I want to update README a little to describe that this feature is useful to move to the Slick3's DBIOAction style gradually. In my understanding, this pull request makes possible to run DBIOAction synchronously, not only plain SQL, right?

yes

Thanks! I will release the next version includes this pull request in this week end.


fix: Vertical overflow tab component example in demo site glitching

🐛 Bug Report

💻 Repro or Code Sample
https://www.fluentui-blazor.net/Tabs
https://github.com/microsoft/fluentui-blazor/assets/36118918/8c0145ca-b3b4-4a1c-b5fe-826923c3a863
🌍 Your Environment

OS & Device: Windows 11 on PC
Browser: Microsoft Edge

Hotfix pushed to demo environment


Debug Checkmarx Vulnerability

Hey,
After scanning my website recently with Checkmarx, a new vulnerability is shown regarding the debug NPM.
The vulnerability states the following:
"In NPM debug, the enable function accepts a regular expression from user input without escaping it. Arbitrary regular expressions could be injected to cause a Denial of Service attack on the user's browser, otherwise known as a ReDoS (Regular Expression Denial of Service). This is a different issue than CVE-2017-16137."
Is that something you could solve?
Thanks in advance.

Please search the issues before opening new issues.


Infra - Standardise CMakeLists formatting

Formatting rules are open for discussion
TODO:

[x] GH action
[x] .cmake-format should contain all rules, not just changes from defaults

this just makes sure all cmake files conform to formatting and we'll manually comply to this? looks good just double-checking in case I'm missing something obvious

You can use the CMake Format VSCode extension to autoformat, and I have a script also so could add that to scripts


SD-1123 Collect disk IO stats on Linux

Let's clarify the behavior when we can't parse the file.  We might want to list it as a known limitation if "zeros are returned" is all that will happen.  Other than that lgtm.

WRT invalid values: on an unsupported kernel (2.4 or earlier) without 14 columns in /proc/diskstats, we'll produce no metrics at all. If there were a kernel where the column values weren't valid unsigned longs, we would produce 0s for invalid columns. In that case we would have the bigger problem that we couldn't trust any values. As part of the "removing panics from SIGAR" I'll see if I can make their error handling more sane in all cases.


fix: remove duplicated word in readme

Hello @maxmonakhov,
Thanks for noticing and providing a fix.
However all improvements are happening on the development version.
Kind Regards
KJ


Bot can't leave a voice channel.

So I came from here but this doesn't work for some reason; I think it's something within adding AudioService to IServiceColletion but I stopped caring and made my own.
Here's my code for joining a channel - working.
//audioClient is declared as private in the class.
[Command("join", RunMode = RunMode.Async)]
        public async Task JoinCmd()
        {
            try
            {
                audioClient = await (Context.User as IVoiceState).VoiceChannel.ConnectAsync();
            }
            catch(Exception e)
            {
                Console.WriteLine(e.Message);
            }
        }

and here's my code for disconnecting - the problem here is that it returns "Object reference not set to an instance of an object."
[Command("leave", RunMode = RunMode.Async)]
        public async Task LeaveCmd()
        {
            try
            {
                await audioClient.StopAsync();
                Console.WriteLine($"[VOICE CHANNEL] Left {Context.Guild.Name}.");
            }
            catch(Exception e)
            {
                Console.WriteLine(e.Message);
            }
        }

so I tried mixing them up. First I connect it, then disconnect it. Surprisingly it works, but now the bot needs to join first before leaving!
audioClient = await (Context.User as IVoiceState).VoiceChannel.ConnectAsync();
await audioClient.StopAsync();

What's the proper way of doing this?

Modules are disposed of as soon as a command is executed.

I see...
Not meaning to be rude but how to do it properly then?

You'd need a service where you store all your data and add it as a singleton in your service collection.


Visually suggest that the prompt has been sent and is being processed

Is there a way (spinning hourglass or similar) you could indicate that the prompt has been sent and is being processed by Ollama?

Can results be streamed to the response area? This could help inform the user that something is indeed happening.


Add extra clarification for changelog

It was unclear that a value of "true" is needed (a reading of the code
indicates this is the case)
I think people may assume that if they run the migration, the default
could be changed. Add text to make clear that is not currently the
case.

Why was this only done for 1.4? We have this changelog notes in master too. @timcharper

@zen-dog the text on master has been updated, also.


python.testing.cwd not respected for python rewrite

while on the rewrite ("python.experiments.optInto": ["pythonTestAdapter"]), the following setting python.testing.cwd is not respected. It is not considered in the code and so it must be fix to respect this setting when provided.

discovered during testing: https://github.com/microsoft/vscode-python/issues/20711

verification steps:

go to this repo: https://github.com/eleanorjboyd/inc_dec_example_repo/tree/main/inc_dec_example_test_suite clone it and go int othe inc_dec_example_test_suite folder
add in a value for settings.testing.cwd so it points at a subdirectory of your workspace (like outer_nested_folder)
in the command line do python -m pip install pytest then reload window
click on the test explorer to run tests. If it is asking you to configure tests pick pytest then default values
Now check that when you look at the test explorer there are no errors and the root folder you see is the one you put in as settings.testing.cwd

@joyceerhl , @eleanorjboyd said this isn't in insider's yet fyi

there is a new build out with this change and @paulacamargo25 offered to test it


Updates EJBCA compatibilty

Since version 8.3 EJBCA provides support for hybrid certificates. This information is available in the release notes on the official website. Link here

Thanks


dirent.h@10,2: #error "<dirent.h> not supported" on some platforms

need a smart way of getting around this.

@neil-tan It was introduced with the CI setup. The issue is around how we do directory management for testing. I should be able to work around it.


Question about the model training

Hi
Thank you for your great work, very clean and well structured code, I learned so much from your work. And I have some questions about the model training.
I've followed the instructions from this repository to train the tpse-vc model for 200k iterations. I found that the conversion quality is not that good, after about 100k iterations, the conversed audios sounded almost identical as the source audios.
I used the default setting without any modification. the dataset I used is the newer vctk dataset, all the audios are end with 'flac' suffix.
I noticed that the batch_size used in the code is 64, not 128 which mentioned by the paper. So I am retraining the model with 128 batch_size. I hope you could give some help to reproduce the model.
Thanks

I've changed the batch size to 128, and that didn't give me a better result either.
the logger information of bs 128 training is:
[94000/200000], loss_rec=0.55, loss_content=0.06, loss_style=0.57, loss_adv=0.17 | loss_dis=-0.62
Finally, I recalled that the paper of AutoVC suggest that small batch size improve the generalization ability, so I changed the batch size to 2, and that did give me a better result.


jenkins.build should return the build number too

Currently jenkins.build returns this kind of message.
{ message: 'job is executed',
location: 'http://jenkins.com/queue/item/3435/' }

Would be useful if the build number is returned too as a separate property in the response. This can be used to get the build info and to create the url of the build to allow users use that information. In some versions of jenkins or configurations the queue url is not available or accessible.

I just ran into the same thing @msdark. The location is nice, but a build number would be very helpful!

It looks like this is a problem with Jenkins and not node-jenkins-api. Here's a link to the relevant Jenkins bug report. Unfortunately that bug is marked Won't fix. If it's any consolation, at least it looks like they have some good reasons for not fixing it ¯_(ツ)_/¯


props not passed all the way to children of children

Version
2.2.6
Reproduction link
https://github.com/martinchu/Game-of-Life
Steps to reproduce

run the code on localhost
click the orange cell

What is expected?
the cell should turn to grey, like the rest of the grid
(the color depends on the prop(state) and it should be false)
What is actually happening?
nothing changed. The main.js/original data is changed. The board & row is updated dynamically but the cell level remain unchanged somehow.

https://github.com/martinchu/Game-of-Life/blob/master/src/main.js#L54
Vue can't detect this change, see:
https://vuejs.org/v2/guide/list.html#Array-Change-Detection
You have to use this.$set()

Thanks a lot!


Handlebars 4.x support?

Glimmer has handlebars ^3.0.1 support but some of the niceness of decorators and block partials are missing.
I changed the package version to ^4.0.0 so my fork would let me use Handlebars 4 but threw an error when I tried using
{{#*inline "myPartial"}}
  My Content
{{/inline}}

where the error was

parser.ts:52 Uncaught TypeError: this[node.type] is not a function

Is there a possible future for using ^4.0.0 (and 5.0.0 someday)?

@mmun @rwjblue what's the tl;dr here? do we want to stay on old handlebars? do we want to update? it seems that AST fixes in handlebars can only be unlocked if we update to 4.x at some point. would it be possible to update to 4.x but without supporting certain new constructs like the above?

do we want to stay on old handlebars?

No.

do we want to update?

Yes.

it seems that AST fixes in handlebars can only be unlocked if we update to 4.x at some point.

Confirm, we need to update.

would it be possible to update to 4.x but without supporting certain new constructs like the above?

Yes.  One way would be by detecting them via an AST walker and throwing a compilation error.

would it be possible to update to 4.x but without supporting certain new constructs like the above?

What would be turned off?

Decorators and Inline Partials
partial blocks
partials
block parameters

@rafde Partials (specifically the {{> foo}} syntax and its variations and decorators. They weren't designed with glimmer in mind and it's not clear at this time how they fit into our component story.

hmm... can {{> foo}} get evaluated to {{partial "foo"}} or a component?
I was hoping to use glimmerjs to replace handlebarsjs to reap the benefits but the templates I've been creating use inline decorators and partials a lot.

@rafde partials are now deprecated in Ember too. If you want to use partials then you should probably continue using handlebars.

Partials are not deprecated. They require an RFC and some work to be done in Glimmer to be deprecated.

Confirm. However, we do not support the Handlebars special syntax for partials (which is what we will disable in #397 before landing the Handlebars update).

@chadhietala sorry, thought I read about that deprecations somewhere, but apparently I confused it with something else

This has now  landed in #397

@Turbo87 {{render}} is getting deprecated.
Any advice regarding having glimmerjs work with existing Handlebarsjs project?
I've wanted to use this for a while without having to switch out the framework that is used at work to emberjs.
I figure glimmerjs is the best shot of getting handlebars syntax with (better than?) react performance. So for I noticed that the substitute for partials is using a glimmer class to render the string which is then given to another glimmer object to use via <...> and gets registered somehow to glimmerjs.


Implement support for indy-vdr, askar, indy-shared-rs

Current state

aries-vcx is currently based on vdr-tools, 2021 fork of libindy by Evernym

Target state

we want to enable to opt-in into usage of

indy-shared-rs
indy-vdr
aries-askar
Instead of vdr-tools.

Notes

This probably can't be swapped completely behind the scenes, especially in regard to possible differences between libindy type of wallet VS askar wallet. Usage of libindy or the libs above should be up to aries-vcx user to choose from to avoid breaking existing applications.
Ideally, there would be some migration from users of vdr-tools to the new libs.
Eventually, later in the future we might drop support for vdr-tools.

Steps

Currently, vdr-tools is leaking into other parts of the codebase, like state machines, handlers etc. This should be hidden behind some sort of abstraction, perhaps wallet service, pool service.
Implement the services using vdr-tools
Implement the services using the 3 libs
Enable a way to opt-into one or the other

Architecture setup, indy-credx integration (prover/holder flows), indy-vdr integration (mostly prover/holder flows) has been completed in #648 .
Some remaining work:

Aries-Askar implementation of BaseWallet, AskarWallet - anticipated to be possible without changing the interface.
Extra wallet generic helper methods which apply for askar and indy (e.g. create, open, delete, etc)
Implementation of remaining methods for IndyCredxAnoncreds and IndyVdrLedger (currently stubbed out)
Create an askar based Profile - AskarProfile, which uses IndyCredxAnoncreds IndyVdrLedger and AskarWallet
Ideally, determine the approach for migrating indy wallets to askar (I don't believe aca-py directly supported this)

if it could be useful, a python migration tool:
https://github.com/andrewwhitehead/acapy-wallet-upgrade


Kubernetes with docker tag 5.6.2

I'm having an issue when using the official image of 5.6.2 to run in a pod.
I'm using helm to install the package.
And how should the liveness and readiness be setup? Currently I have this:
livenessProbe:
  httpGet:
    path: /
    port: http
  initialDelaySeconds: 30
readinessProbe:
  httpGet:
    path: /
    port: http
  initialDelaySeconds: 10

But instead I get this error:
Readiness probe failed: Get http://<IP_ADDRESS>:5601/: dial tcp <IP_ADDRESS>:5601: getsockopt: connection refused

And when it does run, I get this issue:

I think this is really a question about how to configure Kubernetes. Please be aware that we develop and test the image for vanilla Docker. We do try to accommodate various orchestrators, if there are specific requests for changes from people who specialize in those orchestrators.
However, we're not really in a position to offer orchestrator-specific configuration advice for Kubernetes, Swarm, ECS, Openshift etc. Hopefully, the Kubernetes community can be of some help to you.

We use Kibana (5.4.3) inside of Kube and haven't run into the error you're seeing in the status breakdown panel. But since you asked, here's a copy of our probe configuration in case it might help.
       livenessProbe:
        httpGet:
          path: "/"
          port: 5601
        initialDelaySeconds: 120
        timeoutSeconds: 5
      readinessProbe:
        httpGet:
          path: "/"
          port: 5601
        initialDelaySeconds: 120
        timeoutSeconds: 5


Updated project-json.md

Changed (PDF file) to (PDB file) under debug type

Hi @tamaw, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, DNFBOT;

@tamaw Thank you for your contribution.  We really appreciate it.
:shipit:  Merging now.


Mappings Exercise

Implement a solution for the Mappings exercise

Submitted to Base Goerli: https://goerli.basescan.org/address/0x717539f676963c2E2F308c0352B329480c467616#code


Deduplicate Transfer Arg Parsing in Client.

About These Changes

closes #1578

bors r+

bors r+

bors r+

bors r+


Feature/index detail

Description
[Describe what this change achieves]
Issues Resolved
[List any issues this PR will resolve]
Check List

[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #312 (db398ee) into index-operation (9bb3643) will increase coverage by 0.52%.
The diff coverage is n/a.

@@                 Coverage Diff                 @@
##           index-operation     #312      +/-   ##
===================================================
+ Coverage            51.45%   51.97%   +0.52%
===================================================
  Files                  198      200       +2
  Lines                 6303     6386      +83
  Branches               988     1007      +19
===================================================
+ Hits                  3243     3319      +76
+ Misses                2819     2817       -2
- Partials               241      250       +9

Impacted Files
Coverage Δ

...CreateIndex/containers/CreateIndex/CreateIndex.tsx
52.38% <0.00%> (-7.88%)
:arrow_down:

...CreateIndex/components/IndexDetail/IndexDetail.tsx
65.71% <0.00%> (-6.17%)
:arrow_down:

...ds-plugin/public/pages/Indices/utils/constants.tsx
87.50% <0.00%> (-0.74%)
:arrow_down:

...ement-dashboards-plugin/public/pages/Main/Main.tsx
6.66% <0.00%> (-0.23%)
:arrow_down:

...gement-dashboards-plugin/public/utils/constants.ts
100.00% <0.00%> (ø)

...CreateIndex/containers/AliasSelect/AliasSelect.tsx

.../pages/Indices/components/IndicesActions/index.tsx
75.00% <0.00%> (ø)

...lic/pages/Indices/components/IndexDetail/index.tsx
62.16% <0.00%> (ø)

...pages/CreateIndex/components/AliasSelect/index.tsx
65.71% <0.00%> (ø)

...ublic/pages/Indices/containers/Indices/Indices.tsx
78.66% <0.00%> (+2.80%)
:arrow_up:

... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Update links to glossaries

include targets into the links pointing to the glossary files.
Code: Copy/Paste
#Fix glossary-links' targets
$re = [regex]'(?s)\[[^\]]+\]\([^)]+(vbe-glossary.md|glossary-vba.md)\)'
$fList=@();ls *.md -recurse | %{if($re.IsMatch((gc $_) -join "`n")){$fList+=$_;}};$fList=($fList|sort -unique)
$LookFor = '\[(?''TargetName''[^\]]+?)s?\].*'
$ReplaceWith = '${TargetName}'
filter fltr([switch]$Preview){
   $content=(gc $_) -join "`n"
   $mList = $re.matches($content)
   if($mList.count -gt 0){
      foreach($ToFind in $mList.value){
         $Tag = ($ToFind -replace $LookFor,$ReplaceWith).replace(' ','-')
         $ToSet = ($ToFind.substring(0,$ToFind.Length-1)+"#$Tag)")
         $content = $content.replace($ToFind,$ToSet)
      }
      $pth = resolve-path $_ -relative
      if($Preview){$pth = ".\ReviewTmp\$pth";$null = (ni $pth -type file -force)}
      sc $pth $content -force
      resolve-path $pth -relative
   }
}
#$fList[0..7] | fltr -preview | ac UpdatedFiles.txt
$fList | fltr | ac UpdatedFiles.txt
#$re.Matches((gc $fList[7]) -join "`n").value -replace $LookFor,$ReplaceWith

#fix glossary terms that are supposed to end in s
#$re = [regex]'(?m)^[\s-[\n]]*\#\#\s*[^\n]+?s[\s-[\n]]*$'
$re = [regex]'\#(system-color|base-clas?|clas?|date-separator|focu|in-proces?|intrinsic-constant)\)'
$fList=@();ls *.md -recurse | %{if($re.IsMatch((gc $_) -join "`n")){$fList+=$_;}};$fList=($fList|sort -unique)
$LookFor = '\#(?''CreamFilling''[^)]+)\)'
$ReplaceWith = '#${CreamFilling}s)'
filter fltr([switch]$Preview){
   $content=(gc $_) -join "`n"
   $mList = $re.matches($content)
   if($mList.count -gt 0){
      foreach($ToFind in $mList.value){
         $ToSet = ($ToFind -replace $LookFor,$ReplaceWith)
         $content = $content.replace($ToFind,$ToSet)
      }
      $pth = resolve-path $_ -relative
      if($Preview){$pth = ".\ReviewTmp\$pth";$null = (ni $pth -type file -force)}
      sc $pth $content -force
      resolve-path $pth -relative
   }
}
$fList | fltr | ac UpdatedFiles.txt

:warning: Validation status: warnings

File
Status
Preview URL
Details

Language/Concepts/Forms/object-model-for-microsoft-forms.md
:warning:Warning
View
Details

Language/Concepts/Forms/what-is-a-shortcut-menu.md
:warning:Warning
View
Details

Language/Concepts/Getting-Started/avoiding-naming-conflicts.md
:warning:Warning
View
Details

Language/Concepts/Getting-Started/calling-property-procedures.md
:warning:Warning
View
Details

Language/Concepts/Getting-Started/creating-object-variables.md
:warning:Warning
View
Details

Language/Concepts/Getting-Started/creating-recursive-procedures.md
:warning:Warning
View
Details

Language/Concepts/Getting-Started/declaring-arrays.md
:warning:Warning
View
Details

Language/Concepts/Getting-Started/declaring-constants.md
:warning:Warning
View
Details

Language/Concepts/Getting-Started/declaring-variables.md
:warning:Warning
View
Details

Language/Concepts/Getting-Started/deftype-statements.md
:warning:Warning
View
Details

Language/Concepts/Getting-Started/executing-code-when-setting-properties.md
:warning:Warning
View
Details

Language/Concepts/Getting-Started/looping-through-code.md
:warning:Warning
View
Details

Language/Concepts/Getting-Started/making-faster-fornext-loops.md
:warning:Warning
View
Details

Language/Concepts/Getting-Started/returning-strings-from-functions.md
:warning:Warning
View
Details

Language/Concepts/Getting-Started/type-conversion-functions.md
:warning:Warning
View
Details

Language/Concepts/Getting-Started/understanding-automation.md
:warning:Warning
View
Details

Language/Concepts/Getting-Started/understanding-objects-properties-methods-and-events.md
:warning:Warning
View
Details

Language/Concepts/Getting-Started/understanding-the-lifetime-of-variables.md
:warning:Warning
View
Details

Language/Concepts/Getting-Started/understanding-visual-basic-syntax.md
:warning:Warning
View
Details

Language/Concepts/Getting-Started/using-arrays.md
:warning:Warning
View
Details

Language/Concepts/Getting-Started/using-constants.md
:warning:Warning
View
Details

Language/Concepts/Getting-Started/using-data-types-efficiently.md
:warning:Warning
View
Details

Language/Concepts/Getting-Started/vartype-constants.md
:warning:Warning
View
Details

Language/Concepts/Getting-Started/visual-basic-naming-rules.md
:warning:Warning
View
Details

Language/Concepts/Getting-Started/writing-a-property-procedure.md
:warning:Warning
View
Details

Language/How-to/check-or-add-an-object-library-reference.md
:warning:Warning
View
Details

Language/How-to/enter-a-declaration-in-code.md
:warning:Warning
View
Details

Language/How-to/find-a-procedure.md
:warning:Warning
View
Details

Language/How-to/set-reference-to-a-type-library.md
:warning:Warning
View
Details

Language/How-to/set-visual-basic-environment-options.md
:warning:Warning
View
Details

Language/How-to/split-the-code-window.md
:warning:Warning
View
Details

Language/How-to/user-defined-type-may-not-be-passed-byval.md
:warning:Warning
View
Details

Language/How-to/user-defined-type-without-members-not-allowed.md
:warning:Warning
View
Details

Language/Reference/User-Interface-Help/a-compatible-activex-component-must-be-a-visual-basic-executable-or-a-dll.md
:warning:Warning
View
Details

Language/Reference/User-Interface-Help/a-module-is-not-a-valid-type.md
:warning:Warning
View
Details

Language/Reference/User-Interface-Help/a-procedure-of-that-name-already-exists.md
:warning:Warning
View
Details

Language/Reference/User-Interface-Help/a-procedure-with-a-paramarray-argument-cannot-be-called-with-named-arguments.md
:warning:Warning
View
Details

Language/Reference/User-Interface-Help/abs-function.md
:warning:Warning
View
Details

Language/Reference/User-Interface-Help/activevbproject-property-vba-add-in-object-model.md
:warning:Warning
View
Details

Language/Reference/User-Interface-Help/activex-component-can-t-create-object-or-return-reference-to-this-object-error-4.md
:warning:Warning
View
Details

Language/Reference/User-Interface-Help/activex-control-item-not-found-error-363.md
:warning:Warning
View
Details

Language/Reference/User-Interface-Help/add-in-can-t-reference-project.md
:warning:Warning
View
Details

Language/Reference/User-Interface-Help/add-procedure-dialog-box.md
:warning:Warning
View
Details

Language/Reference/User-Interface-Help/addfromguid-method-vba-add-in-object-model.md
:warning:Warning
View
Details

Language/Reference/User-Interface-Help/addressof-operator.md
:warning:Warning
View
Details

Language/Reference/User-Interface-Help/ambiguous-name-detected.md
:warning:Warning
View
Details

Language/Reference/User-Interface-Help/and-operator.md
:warning:Warning
View
Details

Language/Reference/User-Interface-Help/appactivate-statement.md
:warning:Warning
View
Details

Language/Reference/User-Interface-Help/argument-not-optional-error-449.md
:warning:Warning
View
Details

Language/Reference/User-Interface-Help/array-argument-must-be-byref.md
:warning:Warning
View
Details

This comment lists only the first 50 files in the pull request.

Language/Concepts/Forms/object-model-for-microsoft-forms.md

Line 20: [Warning] Illegal link: Collections -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named Collection.

Language/Concepts/Forms/what-is-a-shortcut-menu.md

Line 24: [Warning] Illegal link: Containers -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named Container.

Language/Concepts/Getting-Started/avoiding-naming-conflicts.md

Line 16: [Warning] Illegal link: scoping -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named scoping.

Language/Concepts/Getting-Started/calling-property-procedures.md

Line 31: [Warning] Illegal link: properties -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named propertie.

Language/Concepts/Getting-Started/creating-object-variables.md

Line 14: [Warning] Illegal link: properties -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named propertie.

Language/Concepts/Getting-Started/creating-recursive-procedures.md

Line 14: [Warning] Illegal link: Procedures -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named Procedure.

Language/Concepts/Getting-Started/declaring-arrays.md

Line 14: [Warning] Illegal link: Arrays -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named Array.

Language/Concepts/Getting-Started/declaring-constants.md

Line 16: [Warning] Illegal link: Module-level -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named Module-level.

Language/Concepts/Getting-Started/declaring-variables.md

Line 16: [Warning] Illegal link: String data type -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named String-data-type.

Language/Concepts/Getting-Started/deftype-statements.md

Line 45: [Warning] Illegal link: Boolean -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named Boolean.
Line 46: [Warning] Illegal link: Byte -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named Byte.
Line 47: [Warning] Illegal link: Integer -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named Integer.
Line 48: [Warning] Illegal link: Long -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named Long.
Line 51: [Warning] Illegal link: Currency -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named Currency.
Line 52: [Warning] Illegal link: Single -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named Single.
Line 53: [Warning] Illegal link: Double -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named Double.
Line 54: [Warning] Illegal link: Decimal -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named Decimal.
Line 55: [Warning] Illegal link: Date -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named Date.
Line 56: [Warning] Illegal link: String -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named String.
Line 57: [Warning] Illegal link: Object -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named Object.
Line 58: [Warning] Illegal link: Variant -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named Variant.

Language/Concepts/Getting-Started/executing-code-when-setting-properties.md

Line 56: [Warning] Illegal link: Property procedures -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named Property-procedure.

Language/Concepts/Getting-Started/looping-through-code.md

Line 55: [Warning] Illegal link: properties -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named propertie.

Language/Concepts/Getting-Started/making-faster-fornext-loops.md

Line 14: [Warning] Illegal link: Variant data type -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named Variant-data-type.
Line 29: [Warning] Illegal link: Long data type -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named Long-data-type.

Language/Concepts/Getting-Started/returning-strings-from-functions.md

Line 14: [Warning] Illegal link: Variant data type -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named Variant-data-type.
Line 14: [Warning] Illegal link: String data type -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named String-data-type.
Line 14: [Warning] Illegal link: Null -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named Null.
Line 30: [Warning] Illegal link: Chr$ -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named Chr$.
Line 30: [Warning] Illegal link: ChrB$ -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named ChrB$.
Line 30: [Warning] Illegal link: Command$ -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named Command$.
Line 31: [Warning] Illegal link: CurDir$ -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named CurDir$.
Line 31: [Warning] Illegal link: Date$ -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named Date$.
Line 31: [Warning] Illegal link: Dir$ -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named Dir$.
Line 32: [Warning] Illegal link: Error$ -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named Error$.
Line 32: [Warning] Illegal link: Format$ -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named Format$.
Line 32: [Warning] Illegal link: Hex$ -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named Hex$.
Line 33: [Warning] Illegal link: Input$ -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named Input$.
Line 33: [Warning] Illegal link: InputB$ -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named InputB$.
Line 33: [Warning] Illegal link: LCase$ -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named LCase$.
Line 34: [Warning] Illegal link: Left$ -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named Left$.
Line 34: [Warning] Illegal link: LeftB$ -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named LeftB$.
Line 34: [Warning] Illegal link: LTrim$ -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named LTrim$.
Line 35: [Warning] Illegal link: Mid$ -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named Mid$.
Line 35: [Warning] Illegal link: MidB$ -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named MidB$.
Line 35: [Warning] Illegal link: Oct$ -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named Oct$.
Line 36: [Warning] Illegal link: Right$ -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named Right$.
Line 36: [Warning] Illegal link: RightB$ -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named RightB$.
Line 36: [Warning] Illegal link: RTrim$ -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named RTrim$.
Line 37: [Warning] Illegal link: Space$ -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named Space$.
Line 37: [Warning] Illegal link: Str$ -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named Str$.
Line 37: [Warning] Illegal link: String$ -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named String$.
Line 38: [Warning] Illegal link: Time$ -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named Time$.
Line 38: [Warning] Illegal link: Trim$ -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named Trim$.
Line 38: [Warning] Illegal link: UCase$ -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named UCase$.

Language/Concepts/Getting-Started/type-conversion-functions.md

Line 41: [Warning] Illegal link: Boolean -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named Boolean.
Line 42: [Warning] Illegal link: Byte -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named Byte.
Line 43: [Warning] Illegal link: Currency -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named Currency.
Line 44: [Warning] Illegal link: Date -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named Date.
Line 45: [Warning] Illegal link: Double -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named Double.
Line 46: [Warning] Illegal link: Decimal -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named Decimal.
Line 47: [Warning] Illegal link: Integer -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named Integer.
Line 48: [Warning] Illegal link: Long -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named Long.
Line 51: [Warning] Illegal link: Single -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named Single.
Line 52: [Warning] Illegal link: String -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named String.
Line 53: [Warning] Illegal link: Variant -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named Variant.

Language/Concepts/Getting-Started/understanding-automation.md

Line 16: [Warning] Illegal link: Automation object -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named Automation-object.

Language/Concepts/Getting-Started/understanding-objects-properties-methods-and-events.md

Line 14: [Warning] Illegal link: properties -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named propertie.

Language/Concepts/Getting-Started/understanding-the-lifetime-of-variables.md

Line 16: [Warning] Illegal link: Variant -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named Variant.
Line 16: [Warning] Illegal link: Empty -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named Empty.

Language/Concepts/Getting-Started/understanding-visual-basic-syntax.md

Line 14: [Warning] Illegal link: function -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named function.
Line 32: [Warning] Illegal link: Arguments -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named Argument.

Language/Concepts/Getting-Started/using-arrays.md

Line 65: [Warning] Illegal link: Variant data type -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named Variant-data-type.

Language/Concepts/Getting-Started/using-constants.md

Line 18: [Warning] Illegal link: Intrinsic constants -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named Intrinsic-constant.
Line 18: [Warning] Illegal link: object libraries -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named object-librarie.
Line 18: [Warning] Illegal link: Object Browser -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named Object-Browser.
Line 28: [Warning] Illegal link: Conditional compiler constants -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named Conditional-compiler-constant.

Language/Concepts/Getting-Started/using-data-types-efficiently.md

Line 14: [Warning] Illegal link: Variant data type -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named Variant-data-type.

Language/Concepts/Getting-Started/vartype-constants.md

Line 22: [Warning] Illegal link: Integer -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named Integer.
Line 26: [Warning] Illegal link: Currency -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named Currency.
Line 27: [Warning] Illegal link: Date -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named Date.
Line 28: [Warning] Illegal link: String -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named String.
Line 31: [Warning] Illegal link: Boolean -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named Boolean.
Line 32: [Warning] Illegal link: Variant -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named Variant.
Line 34: [Warning] Illegal link: Decimal -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named Decimal.
Line 35: [Warning] Illegal link: Byte -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named Byte.

Language/Concepts/Getting-Started/visual-basic-naming-rules.md

Line 24: [Warning] Illegal link: functions -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named function.

Language/Concepts/Getting-Started/writing-a-property-procedure.md

Line 22: [Warning] Illegal link: Object Browser -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named Object-Browser.

Language/How-to/check-or-add-an-object-library-reference.md

Line 14: [Warning] Illegal link: object libraries -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named object-librarie.
Line 29: [Warning] Illegal link: Object Browser -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named Object-Browser.
Line 29: [Warning] Illegal link: properties -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named propertie.

Language/How-to/enter-a-declaration-in-code.md

Line 14: [Warning] Illegal link: standard -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named standard.
Line 16: [Warning] Illegal link: scoping -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named scoping.
Line 24: [Warning] Illegal link: Object box -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named Object-box.
Line 26: [Warning] Illegal link: Procedure box -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named Procedure-box.

Language/How-to/find-a-procedure.md

Line 18: [Warning] Illegal link: Object box -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named Object-box.
Line 18: [Warning] Illegal link: Procedure box -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named Procedure-box.

Language/How-to/set-reference-to-a-type-library.md

Line 36: [Warning] Illegal link: Object -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named Object.
Line 45: [Warning] Illegal link: properties -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named propertie.

Language/How-to/set-visual-basic-environment-options.md

Line 42: [Warning] Illegal link: Procedures -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named Procedure.

Language/How-to/split-the-code-window.md

Line 14: [Warning] Illegal link: Procedure -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named Procedure.
Line 14: [Warning] Illegal link: Object box -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named Object-box.

Language/How-to/user-defined-type-may-not-be-passed-byval.md

Line 14: [Warning] Illegal link: User-defined types -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named User-defined-type.

Language/How-to/user-defined-type-without-members-not-allowed.md

Line 14: [Warning] Illegal link: User-defined types -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named User-defined-type.

Language/Reference/User-Interface-Help/a-compatible-activex-component-must-be-a-visual-basic-executable-or-a-dll.md

Line 18: [Warning] Illegal link: dynamic-link library (DLL) -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named dynamic-link-library-(DLL).

Language/Reference/User-Interface-Help/a-module-is-not-a-valid-type.md

Line 18: [Warning] Illegal link: MDI form -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named MDI-form.

Language/Reference/User-Interface-Help/a-procedure-of-that-name-already-exists.md

Line 14: [Warning] Illegal link: Procedure -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named Procedure.

Language/Reference/User-Interface-Help/a-procedure-with-a-paramarray-argument-cannot-be-called-with-named-arguments.md

Line 17: [Warning] Illegal link: Named-argument -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named Named-argument.

Language/Reference/User-Interface-Help/abs-function.md

Line 20: [Warning] Illegal link: Null -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named Null.

Language/Reference/User-Interface-Help/activevbproject-property-vba-add-in-object-model.md

Line 16: [Warning] Illegal link: Project window -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named Project-window.

Language/Reference/User-Interface-Help/activex-component-can-t-create-object-or-return-reference-to-this-object-error-4.md

Line 14: [Warning] Illegal link: dynamic-link libraries (DLL) -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named dynamic-link-libraries-(DLL).
Line 22: [Warning] Illegal link: Automation object -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named Automation-object.

Language/Reference/User-Interface-Help/activex-control-item-not-found-error-363.md

Line 14: [Warning] Illegal link: ActiveX control -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named ActiveX-control.

Language/Reference/User-Interface-Help/add-in-can-t-reference-project.md

Line 14: [Warning] Illegal link: Projects -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named Project.

Language/Reference/User-Interface-Help/add-procedure-dialog-box.md

Line 19: [Warning] Illegal link: Sub -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named Sub.
Line 19: [Warning] Illegal link: Function -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named Function.

Language/Reference/User-Interface-Help/addfromguid-method-vba-add-in-object-model.md

Line 28: [Warning] Illegal link: Long -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named Long.

Language/Reference/User-Interface-Help/addressof-operator.md

Line 25: [Warning] Illegal link: dynamic-link library (DLL) -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named dynamic-link-library-(DLL).

Language/Reference/User-Interface-Help/ambiguous-name-detected.md

Line 22: [Warning] Illegal link: Module-level -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named Module-level.

Language/Reference/User-Interface-Help/and-operator.md

Line 39: [Warning] Illegal link: Null -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named Null.

Language/Reference/User-Interface-Help/appactivate-statement.md

Line 25: [Warning] Illegal link: String expression -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named String-expression.
Line 26: [Warning] Illegal link: Boolean -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named Boolean.

Language/Reference/User-Interface-Help/argument-not-optional-error-449.md

Line 20: [Warning] Illegal link: parameter  -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named parameter-.

Language/Reference/User-Interface-Help/array-argument-must-be-byref.md

Line 14: [Warning] Illegal link: Arrays -- missing bookmark. The file Language/Glossary/vbe-glossary.md doesn't contain a bookmark named Array.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

oh fart, of course they would be case sensitive

I don't think it's a case-sensitive issue; the links appear to have bookmarks that aren't there anymore. Do you want me to take a look?

I take that back; BOOKMARKS are case-sensitive.... By the way, I updated the glossaries so that all the entries are level too, and as a result, the entries appear in the right navigation. So you can just remove all the bookmarks in the links to that page if you like...
Also, we used to have duplicate copies of the glossary, but we removed all but the one under Glossaries.
So be sure you're pointing to that one.

@Linda-Editor I personally find it more convenient when I click on the linked term and it goes straight to the referenced term, but it is nice now that they are all now in the navbar as well. I didn't change the file to which the links were pointing only added the # target at the end of the link. I've fixed the case sensitive issue on my local repo, but that also lead to a few missing/broken links that I'm still working to resolve before I reissue this PR

gloss
Tag
Target
ReTarget

VBA-Glossary
cleared
(../Language/Glossary/glossary-vba.md#cleared)

VBA-Glossary
format
(../Language/Glossary/glossary-vba.md#format)

VBA-Glossary
group
(../Language/Glossary/glossary-vba.md#group)

VBA-Glossary
Input-Method-Editor-(IME
(../Language/Glossary/glossary-vba.md#Input-Method-Editor-(IME)

VBE-Glossary
ANSI
(../Language/Glossary/vbe-glossary.md#ANSI)

VBE-Glossary
array'
(../Language/Glossary/vbe-glossary.md#array')

VBE-Glossary
ASCII
(../Language/Glossary/vbe-glossary.md#ASCII)

VBE-Glossary
bit-wise-comparison
(../Language/Glossary/vbe-glossary.md#bit-wise-comparison)

VBE-Glossary
Boolean
(../Language/Glossary/vbe-glossary.md#Boolean)

VBE-Glossary
Boolean-variable
(../Language/Glossary/vbe-glossary.md#Boolean-variable)

VBE-Glossary
Byte
(../Language/Glossary/vbe-glossary.md#Byte)

VBE-Glossary
Byte-variable
(../Language/Glossary/vbe-glossary.md#Byte-variable)

VBE-Glossary
Chr$
(../Language/Glossary/vbe-glossary.md#Chr$)

VBE-Glossary
ChrB$
(../Language/Glossary/vbe-glossary.md#ChrB$)

VBE-Glossary
classe
(../Language/Glossary/vbe-glossary.md#classe)

VBE-Glossary
Command$
(../Language/Glossary/vbe-glossary.md#Command$)

VBE-Glossary
constant-
(../Language/Glossary/vbe-glossary.md#constant-)

VBE-Glossary
CurDir$
(../Language/Glossary/vbe-glossary.md#CurDir$)

VBE-Glossary
Currency
(../Language/Glossary/vbe-glossary.md#Currency)

VBE-Glossary
Currency-variable
(../Language/Glossary/vbe-glossary.md#Currency-variable)

VBE-Glossary
Date$
(../Language/Glossary/vbe-glossary.md#Date$)

VBE-Glossary
Date
(../Language/Glossary/vbe-glossary.md#Date)

VBE-Glossary
Date-separator
(../Language/Glossary/vbe-glossary.md#Date-separator)

VBE-Glossary
Date-variable
(../Language/Glossary/vbe-glossary.md#Date-variable)

VBE-Glossary
DBC
(../Language/Glossary/vbe-glossary.md#DBC)

VBE-Glossary
Decimal
(../Language/Glossary/vbe-glossary.md#Decimal)

VBE-Glossary
Decimal-variable
(../Language/Glossary/vbe-glossary.md#Decimal-variable)

VBE-Glossary
design-mode
(../Language/Glossary/vbe-glossary.md#design-mode)

VBE-Glossary
Dir$
(../Language/Glossary/vbe-glossary.md#Dir$)

VBE-Glossary
docked
(../Language/Glossary/vbe-glossary.md#docked)

VBE-Glossary
Double-(double-precision-floating-point
(../Language/Glossary/vbe-glossary.md#Double-(double-precision-floating-point)

VBE-Glossary
Double
(../Language/Glossary/vbe-glossary.md#Double)

VBE-Glossary
dynamic-data-exchange
(../Language/Glossary/vbe-glossary.md#dynamic-data-exchange)

VBE-Glossary
dynamic-link-librarie
(../Language/Glossary/vbe-glossary.md#dynamic-link-librarie)

VBE-Glossary
dynamic-link-libraries-(DLL
(../Language/Glossary/vbe-glossary.md#dynamic-link-libraries-(DLL)

VBE-Glossary
dynamic-link-library-(DLL
(../Language/Glossary/vbe-glossary.md#dynamic-link-library-(DLL)

VBE-Glossary
dynamic-link-library
(../Language/Glossary/vbe-glossary.md#dynamic-link-library)

VBE-Glossary
Error$
(../Language/Glossary/vbe-glossary.md#Error$)

VBE-Glossary
expression-
(../Language/Glossary/vbe-glossary.md#expression-)

VBE-Glossary
Format$
(../Language/Glossary/vbe-glossary.md#Format$)

VBE-Glossary
function
(../Language/Glossary/vbe-glossary.md#function)

VBE-Glossary
Hex$
(../Language/Glossary/vbe-glossary.md#Hex$)

VBE-Glossary
host-application'
(../Language/Glossary/vbe-glossary.md#host-application')

VBE-Glossary
host-application's-
(../Language/Glossary/vbe-glossary.md#host-application's-)

VBE-Glossary
identifier'
(../Language/Glossary/vbe-glossary.md#identifier')

VBE-Glossary
Immediate-Window-or-Pane
(../Language/Glossary/vbe-glossary.md#Immediate-Window-or-Pane)

VBE-Glossary
Input$
(../Language/Glossary/vbe-glossary.md#Input$)

VBE-Glossary
InputB$
(../Language/Glossary/vbe-glossary.md#InputB$)

VBE-Glossary
Integer
(../Language/Glossary/vbe-glossary.md#Integer)

VBE-Glossary
Integer-variable
(../Language/Glossary/vbe-glossary.md#Integer-variable)

VBE-Glossary
Intrinsic-constant
(../Language/Glossary/vbe-glossary.md#Intrinsic-constant)

VBE-Glossary
LCase$
(../Language/Glossary/vbe-glossary.md#LCase$)

VBE-Glossary
Left$
(../Language/Glossary/vbe-glossary.md#Left$)

VBE-Glossary
LeftB$
(../Language/Glossary/vbe-glossary.md#LeftB$)

VBE-Glossary
linked
(../Language/Glossary/vbe-glossary.md#linked)

VBE-Glossary
Locals-Windows-or-Pane
(../Language/Glossary/vbe-glossary.md#Locals-Windows-or-Pane)

VBE-Glossary
Long-(long-integer
(../Language/Glossary/vbe-glossary.md#Long-(long-integer)

VBE-Glossary
Long
(../Language/Glossary/vbe-glossary.md#Long)

VBE-Glossary
LTrim$
(../Language/Glossary/vbe-glossary.md#LTrim$)

VBE-Glossary
Mid$
(../Language/Glossary/vbe-glossary.md#Mid$)

VBE-Glossary
MidB$
(../Language/Glossary/vbe-glossary.md#MidB$)

VBE-Glossary
module'
(../Language/Glossary/vbe-glossary.md#module')

VBE-Glossary
numeric
(../Language/Glossary/vbe-glossary.md#numeric)

VBE-Glossary
object-librarie
(../Language/Glossary/vbe-glossary.md#object-librarie)

VBE-Glossary
Oct$
(../Language/Glossary/vbe-glossary.md#Oct$)

VBE-Glossary
parameter-
(../Language/Glossary/vbe-glossary.md#parameter-)

VBE-Glossary
procedure'
(../Language/Glossary/vbe-glossary.md#procedure')

VBE-Glossary
propertie
(../Language/Glossary/vbe-glossary.md#propertie)

VBE-Glossary
property,
(../Language/Glossary/vbe-glossary.md#property,)

VBE-Glossary
referencing-project'
(../Language/Glossary/vbe-glossary.md#referencing-project')

VBE-Glossary
Right$
(../Language/Glossary/vbe-glossary.md#Right$)

VBE-Glossary
RightB$
(../Language/Glossary/vbe-glossary.md#RightB$)

VBE-Glossary
RTrim$
(../Language/Glossary/vbe-glossary.md#RTrim$)

VBE-Glossary
scoping
(../Language/Glossary/vbe-glossary.md#scoping)

VBE-Glossary
SendKeys-Statement
(../Language/Glossary/vbe-glossary.md#SendKeys-Statement)

VBE-Glossary
Single-(single-precision-floating-point
(../Language/Glossary/vbe-glossary.md#Single-(single-precision-floating-point)

VBE-Glossary
Single
(../Language/Glossary/vbe-glossary.md#Single)

VBE-Glossary
Single-precision-value
(../Language/Glossary/vbe-glossary.md#Single-precision-value)

VBE-Glossary
Space$
(../Language/Glossary/vbe-glossary.md#Space$)

VBE-Glossary
standard
(../Language/Glossary/vbe-glossary.md#standard)

VBE-Glossary
Str$
(../Language/Glossary/vbe-glossary.md#Str$)

VBE-Glossary
String$
(../Language/Glossary/vbe-glossary.md#String$)

VBE-Glossary
String
(../Language/Glossary/vbe-glossary.md#String)

VBE-Glossary
Sub
(../Language/Glossary/vbe-glossary.md#Sub)

VBE-Glossary
Time$
(../Language/Glossary/vbe-glossary.md#Time$)

VBE-Glossary
Trim$
(../Language/Glossary/vbe-glossary.md#Trim$)

VBE-Glossary
type-librarie
(../Language/Glossary/vbe-glossary.md#type-librarie)

VBE-Glossary
UCase$
(../Language/Glossary/vbe-glossary.md#UCase$)

VBE-Glossary
Variant
(../Language/Glossary/vbe-glossary.md#Variant)

VBE-Glossary
Watch-Window-or-Pane
(../Language/Glossary/vbe-glossary.md#Watch-Window-or-Pane)

Okay -- I would like to merge to LIVE sometime today, so I will wait for you to make these changes. Thanks.

@Linda-Editor I'm getting a little busy at my real job, I don't know if I'll have the above list of broken links updated by today. I can do the case sensitive PR with out those updates if that's preferred?

Will the case-sensitive PR fix all the broken glossary links? It seems like all the broken links have to do with these bookmarks.

@Linda-Editor it fixes most of them, but the ones listed above do not land in the glossary files. Some are easy propertie should probably be property, but some are not Double should probably be redirected to a different file or added to the glossary.

Okay, just do what you can today. Can you move the ones you can't fix to another PR?


[BUGGY?] indexed_queue.h Clear changes fixed size queue to infinite

IndexedQueue in indexed_queue.h provided a fixed size queue.
The capacity is not means the size of the container but the max element number of such queue.
However when call clear to remove all elements in such queue, the clear method change the queue capacity to 0 which means this queue support inserting infinity elements into the queue.
Buggy code as follows:

@natashadsouza  Any updates?

@histfuture good catch. it was fixed.
thanks for supporting Apollo!