(PUP-7745) package latest method does not refresh metadata on Solaris

The latest method currently uses pkg list -Hvn which does not imply a
periodic refresh of package metadata. With this change the latest method
uses pkg list -Hav which implies a periodic refresh of package
metadata.

CLA signed by all contributors.

@shawnferry when I run pkg list -Hvn and pkg list -Hav I get slightly different output for some packages - ie,:
:~# diff Hvn Hav
...
< pkg://solaris/x11/server/xorg/driver/xorg-video-trident@1.3.6,5.11-<IP_ADDRESS>.0.22.0:20130902T214014Z --o
---
> pkg://solaris/x11/server/xorg/driver/xorg-video-trident@1.3.5,5.11-<IP_ADDRESS>.0.24.1317:20120904T180055Z ---
...

Is that expected?

This PR should be suspended. I'm in the middle of discussions about the change internally and we have some disagreements about the method.
There are a couple of options:

the simplest would be adding pkg(:refresh) to latest to make sure metadata is updated
switching to pkg update -nv res to see if it can be updated instead of list etc

The first one is obsoleted '--o'
The second one is available '---'
From my internal discussion about the possibility of checking for all available updates at once for performance reasons and which -a/-n should be preferred:

It all depends on what the intent is; if you want to find what can be updated without updating the operating system, then 'pkg list -a' will (give you an approximation) of that.
If you want to find out simply whether any updates are known including those that require an OS update, then 'pkg update -nv' is indeed what you want.

OS Package puppet
No installable updates available
pkg list -Hav puppet
pkg://nightly/system/management/puppet@4.10.0-<IP_ADDRESS>.0.125.8122.51:20170512T185418Z i--

Updates available only with OS level package changes
pkg list -Hnv puppet
pkg://nightly/system/management/puppet@4.10.0-<IP_ADDRESS>.0.2.8381.56:20170705T190610Z ---
pkg://solaris/system/management/puppet@4.10.0-<IP_ADDRESS>.0.127.0:20170625T213847Z ---

However, It is not possible to update puppet even with a newer package available, due to system level dependencies.
pkg update -nv puppet@4.10.0-<IP_ADDRESS>.0.2.8381.56:20170705T190610Z
Creating Plan (Solver setup): \
pkg update: No matching version of system/management/puppet can be installed:
  Reject<EMAIL_ADDRESS>  Reason:  No version matching 'require' dependency<EMAIL_ADDRESS>can be installed
 ...
    Reason:  This version is excluded by installed incorporation<EMAIL_ADDRESS>    ----------------------------------------

If you update everything it is possible to pull the whole system forward.
pkg update -n --parsable=0
...
["pkg://solaris/entire@5.12,5.12-<IP_ADDRESS>.0.123.0:20170501T160002Z", "pkg://solaris/entire@5.12,5.12-<IP_ADDRESS>.0.127.0:20170626T143028Z"],
["pkg://nightly/system/management/puppet@4.10.0,5.12-<IP_ADDRESS>.0.125.8122.51:20170512T185418Z",
"pkg://nightly/system/management/puppet@4.10.0,5.11-<IP_ADDRESS>.0.2.8381.56:20170705T190610Z"],
...

Random Package Foo
After making a random package foo:
pkg list -Hvn foo
pkg://nightly/system/management/puppet/foo@2.0.1-<IP_ADDRESS>.0.2.8381.4:20170706T195035Z ---

pkg list -Hav foo
pkg://nightly/system/management/puppet/foo@2.0.1-<IP_ADDRESS>.0.2.8381.1:20170706T195006Z i--

pkg update -n --parsable=0 foo
{
...
   "change-packages":[
      [
         "pkg://nightly/system/management/puppet/foo@2.0.1,5.11-<IP_ADDRESS>.0.2.8381.1:20170706T195006Z",
         "pkg://nightly/system/management/puppet/foo@2.0.1,5.11-<IP_ADDRESS>.0.2.8381.4:20170706T195035Z"
      ]
   ],
...
}

@MosesMendoza I'm going to update this pull to simply execute a pkg(:refresh) in latest and very likely refactor the whole thing later.

I forgot to update the spec for the pkg(:refresh) it passes now.

This has been updated to the code integrated with Solaris userland.


Separating the concerns of PWA and Monolith Server

Background
Our application consists mainly of PWA and Monolith Server. Since http-only cookies are the only truly secure way to store user authentication credentials in the browser, we currently use a monolith server mounting PWA entrypoint and use cookies to authenticate GraphQL API requests.
As we may package PWA as a desktop app in the future, we need to refactor it to separating the concerns of PWA and Monolith Server.
Goals

Split user authentication and API authentication;
Use GraphQL query to instead of globalThis.brickdocContext to access metadata;
Render and serve PWA entrypoint page using a static web server (To be discussed);
Admin panel should be part of monolith server;

Solution

Internal Note: Our private monorepo has a PoC implementation of this refactor, which is available here.

We could use inertia.js to build fullstack features with React.js. And use doorkeeper-oidc to implement API authentication logic.
user authentication related features such as sign up, forgot password are implemented in the monolith server by inertia.js. PWA will be focused on the user facing features, and use PKCE flow to authenticate API requests.  (The token needs to be stored in memory only, and remember-me will be transparently implemented in the monolith server via a cookie.)

Use GraphQL query to instead of globalThis.brickdocContext to access metadata;

Instead of an async GraphQL query, I tried using importing a dynamically rendered JS by the server to get server context. See #374. This way we can still use sync calls of window.mashcardContext.

Render and serve PWA entrypoint page using a static web server (To be discussed);

In #374, the front-end build results are still put under the server's public dir. I don't think we need a static web server for now which increases complexity.


Fix when max size used and disk partitioned and formatted but not mounted - Fixes #103

Pull Request (PR) description
This PR fixes the issue in xDisk and xDiskAccessPath that occurs when the Size parameter is not specified, but the partition on the disk already exists but is not assigned to a Drive Letter or an Access Path.
This also improves the integration test layout by adding contexts to group the tests.
This Pull Request (PR) fixes the following issues:

Fixes #103

Task list:

[x] Change details added to Unreleased section of CHANGELOG.md?
[ ] Added/updated documentation, comment-based help and descriptions in .schema.mof files where appropriate?
[ ] Examples appropriately updated?
[x] New/changed code adheres to Style Guidelines?
[x] Unit and (optional) Integration tests created/updated where possible?

@johlju - another one for you sir if you get time -no rush! :grin: I applied autoformatting to the files as well, which did correct some of the lines.

This change is

Codecov Report

Merging #130 into dev will increase coverage by <1%.
The diff coverage is 96%.

@@         Coverage Diff         @@
##           dev   #130    +/-   ##
===================================
+ Coverage   94%    95%   +<1%
===================================
  Files        5      5
  Lines      671    693    +22
===================================
+ Hits       636    659    +23
+ Misses      35     34     -1

Great work on this! Just a minor typo.

Reviewed 11 of 11 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

Tests/Unit/StorageDsc.Common.Tests.ps1, line 320 at r1 (raw file):

mulitple

Typo. Here and the one below.

Comments from Reviewable

All done! Thanks @johlju

Review status: 10 of 11 files reviewed at latest revision, 1 unresolved discussion.

Tests/Unit/StorageDsc.Common.Tests.ps1, line 320 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…

mulitple

Typo. Here and the one below.

Great catch! Fixed.

Comments from Reviewable

Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


P_Batt forecast value calculation issue

Describe the bug
P_Batt forecast value calculation uses eta_disch as a multiplier and this causes issue where p_batt is lower than it should be.
For example at the moment max sell from battery should be happening.
Pd_max: 15600
eta_disch: 0.95
P_batt should be 15600, but it is 15600 * 0.95 =14 820

I'm using p_batt in automation to set the discharge power and in this case losing some power.
Expected behavior
Would be nice to get the real b_batt value. I think it would be beneficial for utilizing battery the most. Maybe it will be a possibility to make the eta_disch calculation for after the p_batt so that load and grid would be correct.

It could be that we need to apply the efficiency factor before publishing the battery power sensor?
It is something we have missed all along the way.
In the meantime you can also apply this efficiency on HA just before controlling your equipment

It could be that we need to apply the efficiency factor before publishing the battery power sensor? It is something we have missed all along the way. In the meantime you can also apply this efficiency on HA just before controlling your equipment

Great and yes, i'm applying this efficiency in HA at the moment.

I have been setting discharge efficiency to 1.00 to workaround this issue.


Generating webhook secrets not possible in creation of new account workflow

Generating webhook secrets not possible in creation of new account workflow
Possible to hack around by modifying webapp to send an accountSid of 0 if there is no account sid, then modified the API to still be able to generate a new webhook secret even if the specified account doesn't exist.
See hacky work around:
api-server.txt
webapp.txt
Cleaner fix would be to either move generation of new ids directly to the add form, or to create new top level endpoint to generate secrets for adding flow.

Please pull the latest jambonz-api-server, which fixes this issue in this commit


The build is broken

This is due to an upstream issue: https://bugs.launchpad.net/pkginfo/+bug/1585006

The upstream issue has been fixed and the build is now working again.


SSL_ERROR_RX_RECORD_TOO_LONG

Hello
I followed this info to setup on Ubuntu 22:
https://github.com/Mintplex-Labs/anything-llm?tab=readme-ov-file#how-to-setup-for-development
When I access the the browser, it gives error: SSL_ERROR_RX_RECORD_TOO_LONG
node -v
v18.20.2
Any idea please?
Sincerely,
Yongsheng

Don’t use localhost when using docker

See markdown file in docker dir

This really is not an issue with anything LLM. It is just how networking works in general for docker containers. I understand your frustration as I too lost time to this error recently.

No idea sorry
On Fri, May 17, 2024 at 3:46 AM Yongsheng Ma @.***>
wrote:

See markdown file in docker dir
Hi atljoseph
I'm not using docker. I setup manually in ubuntu 22. No nginx. Can you
give any details how to configure it to solve this ssl issue?
Thanks!
Yongsheng
—
Reply to this email directly, view it on GitHub
https://github.com/Mintplex-Labs/anything-llm/issues/1419#issuecomment-2116951338,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AF632FM4CMZ2LIIPNACIBC3ZCWYV3AVCNFSM6AAAAABHZW6E2CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJWHE2TCMZTHA
.
You are receiving this because you commented.Message ID:
@.***>

@yongshengma
Are you using NGINX? This is an NGINX error, not AnythingLLM.
In your server block for HTTP are you using listen 443 ssl;? Some people just put listen 443 which listens on the port but is the SSL port standard and will lead to issues like that.

@yongshengma Are you using NGINX? This is an NGINX error, not AnythingLLM.
In your server block for HTTP are you using listen 443 ssl;? Some people just put listen 443 which listens on the port but is the SSL port standard and will lead to issues like that.

it could be somewhere I didn't config correctly.  I didn't use nginx.
Please let me give more details.

env
cd anything-llm-master
cat frontend/.env
VITE_API_BASE='/api'

yarn setup

yarn dev:server

yarn run v1.22.22
$ cd server && yarn dev
$ NODE_ENV=development nodemon --ignore documents --ignore vector-cache --ignore storage --ignore swagger --trace-warnings index.js
[nodemon] 2.0.22
[nodemon] to restart at any time, enter rs
[nodemon] watching path(s): .
[nodemon] watching extensions: js,mjs,json
[nodemon] starting node --trace-warnings index.js
$ node ./swagger/init.js
[TELEMETRY STUBBED] Anonymous Telemetry stubbed in development.
[CommunicationKey] RSA key pair generated for signed payloads within AnythingLLM services.
Primary server in HTTP mode listening on port 3001
Swagger-autogen:  Success ✔
Swagger-autogen:  Patched servers.url ✔

yarn dev:frontend
yarn dev:collector
http://<IP_ADDRESS>:3001/

When I access the URL, it responds: 404 Not Found
No nginx.
Thanks!

Are you trying to run the service in production or in development? Looks like you are running the server in development mode in which case the frontend needs to be run separately and will be on port 3000 yarn dev:frontend.
If you are trying to run this in production you should only be running yarn prod:server and only be running this after yarn prod:frontend && cp -R frontend/dist server/public.
Then the frontend will be bundled and present in server/public and the whole app will live on 3001

Are you trying to run the service in production or in development? Looks like you are running the server in development mode in which case the frontend needs to be run separately and will be on port 3000 yarn dev:frontend.
If you are trying to run this in production you should only be running yarn prod:server and only be running this after yarn prod:frontend && cp -R frontend/dist server/public.
Then the frontend will be bundled and present in server/public and the whole app will live on 3001

Hi Timothy
I was trying to run in development and I can access localhost:3000 now. Thanks!
But when I run in production, I get an issue:

Any idea please?

@timothycarambat
I find it's caused by STORAGE_DIR. Now I can start it up in production by following the steps you gave. Appreciate!
Sorry to abuse this post as a newbie. Just one more question. Where's the login page or user front?

The way the storage dir works between the normal and the render image is a
bit odd. I fought and fought with the normal image the longest time. Tim
mentioned the render image, and that worked great, but not 100% sure why
both images are needed. Maybe the render image is helpful to you. Maybe
not.
On Tue, Jun 4, 2024 at 9:37 AM Yongsheng Ma @.***>
wrote:

@timothycarambat https://github.com/timothycarambat
I find it's caused by STORAGE_DIR. Now I can start it up in production by
following the steps you gave. Appreciate!
Sorry to abuse this post as a newbie. Just one more question. Where's the
login page or user front?
—
Reply to this email directly, view it on GitHub
https://github.com/Mintplex-Labs/anything-llm/issues/1419#issuecomment-2147557769,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AF632FNTDHPHHNXCTE6UGILZFW7ILAVCNFSM6AAAAABHZW6E2CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBXGU2TONZWHE
.
You are receiving this because you commented.Message ID:
@.***>

@atljoseph

@atljoseph
The error points clearly to the storage dir. I guess we are talking about different things. Anyway I still have the problem on remote access 3000 or 3001 even though I modified in frontend/.env as:
# VITE_API_BASE='http://localhost:3001/api' # Use this URL when developing locally
# VITE_API_BASE="https://$CODESPACE_NAME-3001.$GITHUB_CODESPACES_PORT_FORWARDING_DOMAIN/api" # for Github Codespaces
VITE_API_BASE='/api' # Use this URL deploying on non-localhost address OR in docker.

i'm trying to do more research before ask new questions.


Roll Engine from 7e962ba91133 to c61258da7230 (2 revisions)

https://github.com/flutter/engine/compare/7e962ba91133...c61258da7230
2020-09-15<EMAIL_ADDRESS>Roll Skia from 6253b5787df8 to 37fd658981dd (1 revision) (flutter/engine#21162)
2020-09-15<EMAIL_ADDRESS>Force builders to run. (flutter/engine#21167)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Commit queue failed; closing this roll.


Add DERA model

questions on current implementation:

Add non-default mass matrix entries.
Where does current limit logic, voltage trip logic, frequency trip logic belong?
Remove additional states based on combinations of flags? (more complex implementation)
Is the use of inner vars appropriate?

This PR requires https://github.com/NREL-SIIP/PowerSystems.jl/pull/901

I did a rebase yesterday before this latest round of changes. So I think it should be OK?

Besides the individual comments. We may need to talk with Gustavo before merging if it makes sense based on his experience to make some functions use mass_matrix approach if for those states is common to have a time constant equals to zero. Any comments here @tavovalmo ?

Great job Matt! I think that all lab blocks in this model should use the mass_matrix approach as users may set the time constants to zero. Generally I use even a small value to represent the transducers.

@tavovalmo or @rodrigomha What is a good example for the mass matrix implementation of the lag blocks?

@tavovalmo or @rodrigomha What is a good example for the mass matrix implementation of the lag blocks?

You can check the EXST1 model in avr_models.jl. Rodrigo explained to me how to do it.

I changed most of the states to mass matrix implementation. I left Ip and Iq as is because the PSSE documentation explicitly requires time constant greater than zero for those states. I left the DynamicWrapper dispatch as is because @jd-lara mentioned he had a fix in mind.

This is looking good. I think once we release the updated version of the struct in PSY this should be ok.


show all backend services in haproxy config

rancher/rancher#8226
To test, repeat the steps mentioned in the issue description. And check /etc/haproxy/haproxy.cfg to confirm all backends are there.

@kinarashah could you add the unit test? Also could you check the https://github.com/rancher/lb-controller/pull/80 and see if it does something similar

Closing this, similar implementation - #80.


Bugfix/dev typo

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: zkoppert:x: dwybanYou have signed the CLA already but the status is still pending? Let us recheck it.


Use encodeUri() if part of the URL path

When reviewing your template we've noticed that it is using user-defined parameters to build a URL. It's best practice to use encodeUri() if part of the URL path [1].

Thanks.
Fixed in https://github.com/stape-io/facebook-leads-tag/commit/bdd6e0fcda93b312ba1a921753f20792d97ab568


Running Powertoys as administrator causes UAC on sign in every time

Environment
0.18.1
Steps to reproduce

Install Powertoys through chocolatey
Elevate to admin mode
Toggle on "run at startup"
Toggle "Always run as Administrator"

Expected behavior
Powertoys to start up silently
Actual behavior
When I sign in or turn my PC on for the first time I get a UAC control for Powertoys. When installing through the msi from the releases with the same settings, the UAC control does not appear

Hi @samwdp
open the PowerToys settings and turn OFF and then ON again the Run at startup option, that should fix it.

@enricogior That worked 🙂


UI Error display improvements

An error message is not wrapped which makes it difficult to figure out the cause of an error.

PR: https://github.com/hortonworks/streamline/pull/1122 fixes this


ERROR Error when sending message to topic testKL with key org.apache.kafka.common.errors.UnknownTopicOrPartitionException

Questions?
I am getting above exception while working with 3 node kafka cluster deployed on kubernetes. This error happens when I scale down the kafka nodes. I configured it on SSL protocol

Sorry created in the wrong project.


lossy node events results in flaky tests

The iroh::node::Node struct has a .subscribe() method which returns a broadcast receiver with 256 slots.  Since events are emitted for every blob it is hard to ensure you receive all events.  Yet for some applications, i.e. our tests, it is required to not miss any events.
We could enable this system to provide backpressure and slow down the provider.  One option is to use an callback to receive events, then it is up to the user to decide how to handle the events and whether they should provide backpressure or be lossy.

Can we just make the buffer really big and have a test that makes sure that the messages are manageable in size, in the short term? That should solve it for now, and I think we have more urgent things to do than to obsess about a, say 128kb, buffer.
#[cfg(test)]
fn test_msg_size() {
  assert!(std::mem::size_of::<Msg>() <= 32);
}


Rye sync connection error

Steps to Reproduce
steps:

rye pin 3.7.9
rye sync

It seems due to connection issue, I was unable to finish sync file.
Then I tried to resync again. It tells me unable to run pip-compile.
And I got stuck there.
Thanks.
Expected Result
finish sync
Actual Result
PS C:\Users\ya\code> rye sync
Initializing new virtualenv in C:\Users\ya\code.venv
Python version<EMAIL_ADDRESS>Generating production lockfile: C:\Users\ya\code\requirements.lock
Creating virtualenv for pip-tools
WARNING: Retrying (Retry(total=4, connect=None, read=None, redirect=None, status=None)) after connection broken by 'ProxyError('Cannot connect to proxy.', OSError(0, 'Error'))': /simple/pip-tools/
WARNING: Retrying (Retry(total=3, connect=None, read=None, redirect=None, status=None)) after connection broken by 'ProxyError('Cannot connect to proxy.', OSError(0, 'Error'))': /simple/pip-tools/
WARNING: Retrying (Retry(total=2, connect=None, read=None, redirect=None, status=None)) after connection broken by 'ProxyError('Cannot connect to proxy.', OSError(0, 'Error'))': /simple/pip-tools/
WARNING: Retrying (Retry(total=1, connect=None, read=None, redirect=None, status=None)) after connection broken by 'ProxyError('Cannot connect to proxy.', OSError(0, 'Error'))': /simple/pip-tools/
WARNING: Retrying (Retry(total=0, connect=None, read=None, redirect=None, status=None)) after connection broken by 'ProxyError('Cannot connect to proxy.', OSError(0, 'Error'))': /simple/pip-tools/
ERROR: Could not find a version that satisfies the requirement pip-tools==6.13.0 (from versions: none)
ERROR: No matching distribution found for pip-tools==6.13.0
error: could not write production lockfile for project
Caused by:
failed to initialize pip-tools venv (install dependencies)
PS C:\Users\ya\code> rye sync
Reusing already existing virtualenv
Generating production lockfile: C:\Users\ya\code\requirements.lock
error: could not write production lockfile for project
Caused by:
0: unable to run pip-compile
Version Info
rye 0.11.0
commit: 0.11.0 (f6f63d6c1 2023-07-18)
platform: windows (x86_64)
self-python<EMAIL_ADDRESS>symlink support: true
Stacktrace
No response

This doesn't seem to be a problem with rye, you need to check your internet connection.

This doesn't seem to be a problem with rye, you need to check your internet connection.

What I mean is I get stuck in this error status. How do I resync the project?
Maybe should have a function like rye sync reset or rye resync? So when user get stuck under these kind situation, he can restart sync the project.
Thanks!

This doesn't seem to be a problem with rye, you need to check your internet connection.

What I mean is I get stuck in this error status. How do I resync the project? Maybe should have a function like rye sync reset or rye resync? So when user get stuck under these kind situation, he can restart sync the project.
Thanks!

I found out that the previous connection error was due to low python version. I was trying to sync python 3.7, apparently, rye doesn't support that version. No wonder rye sync failed.


Add cannot checks

Fixes #3

Coverage increased (+3.8%) to 92.0% when pulling 7a7c62d8c8ca59ad93c715adf2ed8d8da2cfed52 on laravel-5.5 into 4874b1828d257eabc2f214a811a5c8918c339485 on master.


removed duplicate code, improved tests

Coverage decreased (-0.05%) to 92.488% when pulling 22916489c15015d931d89546c9974d307b29c6bb on remove-duplication into 87be10ad71de0ca55361532dd4deab4d7463e8ed on master.

Coverage increased (+1.5%) to 94.053% when pulling 455002980c137195c110f74e7db55ceae81305cb on remove-duplication into 87be10ad71de0ca55361532dd4deab4d7463e8ed on master.


code of conduct

Should have a code of conduct, to make a public commitment and welcome new contributors.

[x] setup separate mailing list (not publicly archived, includes core developers as recipients)
[x] update the README
[x] update the Governance wiki page

@sbenthall @Aryan-Barbarian I plan to update the Governance wiki page to note that:

All members of the community are expected to abide by and maintain the code of conduct in order to make participation in our project and our community a harassment-free experience for everyone.

Let me know if there are any objections / different language for that more formal page.

This is good, IMO. Thanks, Nick.

See the recent dev list discussion about some (small!) discrepancies between the roles defined in the Code of Conduct and the roles defined in the Governance document.
I don't think this is anything that should block the adoption of the code of conduct, but getting clarity on how those two documents interact would be a nice addition to the governance process.
For example: in the Governance document, we could note that contributors need to sign off on the pledge, perhaps by committing their names to the end of the code of conduct document in version control.

updated the Governance page with that link. I agree we could clarify or update the exact roles at some point too.
I'm not sure we need contributors to sign/update the pledge, as it's an expectation for everyone even before they're formal committers.

Hmm. I kind of like that idea though...I'd like to open it up for more discussion. I'll make a new issue


Update to use fully resolved paths for babel plugins

Babel will resolve plugins relative to the cwd (this may be a slight simplification). This usually works as expected, however, I have stumbled on an edge case when using a monorepo structure with abstracted build configuration.
/packages
  /shared-build
    /node_modules
      + react-svg-loader
      + babel-plugin-syntax-jsx
      + babel-plugin-transform-object-rest-spread
  /app
    /node_modules
      + shared-build // symlink

In this case, babel is unable to resolve the plugins which live within the node_modules directory of the symlinked package, shared-build.
While slightly more verbose, we can bypass this problem by utilizing the full paths to the plugins that are installed relative to this package.

Tests passed locally.
Quickly reading trace on the failing CI, and the error doesn't appear tied to this particular PR.

Appreciate the  quick merge 🙌
Would be hugely helpful if you could publish the updates as well.
Thank you!


[MXNET-1361] Change 'The Straight Dope' to 'Dive into Deep Learning' on the website

Description
Change The Straight Dope to Dive into Deep Learning on the website.
JIRA: https://issues.apache.org/jira/browse/MXNET-1361
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.

[x] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
[x] Changes are complete (i.e. I finished coding on this PR)
[x] All changes have test coverage:
Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
[x] Code is well-documented:
For user-facing API changes, API doc string has been updated.
For new C++ functions in header files, their functionalities and arguments are documented.
For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
[x] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

[x] Doc update.

Comments
NA

Thank you for the contribution. Please take a look at the conflict and CI failure.

Thanks for helping me resolving the conflict!


While I understand on a technical level that the nature of DLL hooking and function overrides that this is doing is what's causing it, it makes it hard to just send a release to friends I want to play emperor with and ask them to play together.
Imagine if somebody messages you on discord out of the blue and goes "hey, come play this game with me" and sends you a zip with an exe that gets auto detected as a virus by windows. yeah. yikes.
I'm not sure how interested you are in this project at this point, it seems like you met your original goals with IDA reverse engineering practice based on reading your post at wheybags.com/blog/emperor.html, but do you think at any point in the future you would be interested in trying to get around this issue? Maybe it's possible to just package a single prepatched binary without needing any hooking?
I do appreciate your desire to keep emperor playable for everyone forever, and I wonder if you have a full writeup of a knowledge dump allowing someone else to learn about your journey with this on a more detailed technical level, and then potential continue your work.
Either way, thanks a lot for making this! I grew up on Dune RTSs, and they're also what got me into programming. It's really cool to see this. you're the best

Hey, thanks for the interest!
Unfortunately there's not much I can do about this. It could be worked around if I bought a windows code signing key and signed the binaries, but that's not something I want to get into for this project.
Maybe if enough people report false positives somewhere it would go away, I don't know. In the meantime all you can do is either unquarantine it, or disable windows defender completely.

Well, I have no problem getting around this myself; the main problem lies in sending this to other people and getting them to trust me that this is actually something they can use to play a game and not just a scam to hack their computer by someone who took over my account and is pretending to be me.
I wonder if using UPX can get around the issue... or maybe an implementation in a non-C programming language that uses an existing exe that is already signed, e.g. such as electron. it's bloated but it might avoid the security warning.


Fetch response status code

The way to check an error is to compare the status code of the response to "200".
It would be better to check the all range of success code:
var status = request.status;
if (status < 200 || status >= 300 ) {
var err = JSON.parse(request.response);
err.statusCode = status;
failure(err);
}

Fix https://github.com/KleeGroup/focus/commit/d4f556e9883725dc0511eb559bc0229065cd53f2


Non-Ascii character breaks setup py

The 'î' in "Benoît Chesneau" ala...
(py3)➜  ghp-import git:(master) python setup.py install                                                              master
Traceback (most recent call last):
File "setup.py", line 9, in
LONG_DESC = open(os.path.join(os.path.dirname(file), "README.md")).read()
File "/Users/szabel/.virtualenvs/py3/bin/../lib/python3.4/encodings/ascii.py", line 26, in decode
return codecs.ascii_decode(input, self.errors)[0]
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 1362: ordinal not in range(128)

Pull request #31 is prolly the correct fix.


Users list

The data format/layout in the users.txt what should this be? With or without enters/spaces, quotes?
It could take up to 24 hours? after making 3 versions of the users.txt (with quotes, without, with breaks, without) etc it seems to provision after a couple of minutes! but we have to check manually each time!
Also we need another scrip in order grant control to a secondary admin for every users.
Please give us an easier option in the GUI or Powershell to preprovision all Onedrives without the user having to go there in order for it to provision. This manual scripting is a major headache with data migrations.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6f61076b-1d49-4f87-b400-fff52d067ea8
Version Independent ID: 8173ce51-c1ef-50be-2069-1ccd3d0ab5b3
Content: Request-SPOPersonalSite (sharepoint-online)
Content Source: sharepoint/sharepoint-ps/sharepoint-online/Request-SPOPersonalSite.md
Service: sharepoint-powershell
GitHub Login: @trent-green
Microsoft Alias: trgreen

@officedocsbot assign @yogkumgit

Hello @tijs0289 thanks for your feedback.
There is no mention of a txt file in the referenced article where you created this issue.
About your suggestions, I need to kindly suggest visit User Voice https://sharepoint.uservoice.com which is the resource to share ideas for new features.
Thank you

@tijs0289  Thank you very much for your kind feedback. Considering your valuable feedback, as suggested please log this issue as a User Voice. Concerning team will evaluate and take the appropriate action, as per their schedule. Thanks again for taking out some time and sharing your feedback.

@officedocsbot close


Issue 4123 fix: SEI + Composite Integrations and lithium plating functions updated

Description
Updated SEI and lithium plating submodels with domain options
Fixes #4123
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

[ ] New feature (non-breaking change which adds functionality)
[ ] Optimization (back-end change that speeds up the code)
[x] Bug fix (non-breaking change which fixes an issue)

Key checklist:

[ ] No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
[ ] All tests pass: $ python run-tests.py --all (or $ nox -s tests)
[ ] The documentation builds: $ python run-tests.py --doctest (or $ nox -s doctests)

You can run integration tests, unit tests, and doctests together at once, using $ python run-tests.py --quick (or $ nox -s quick).
Further checks:

[ ] Code is commented, particularly in hard-to-understand areas
[ ] Tests added that prove fix is effective or that feature works

@allcontributors add @parkec3 for code


merge from arlac77/template-arlac77-github,arlac77/template-esm-only,arlac77/template-nginx,arlac77/template-pacman,arlac77/template-systemd

package.json

chore(deps): add ^6.12.12 remove ^6.12.11 (devDependencies.npm-pkgbuild)

Pull Request Test Coverage Report for Build 3833

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 83.871%

Totals

Change from base Build 3830:
0.0%

Covered Lines:
72

Relevant Lines:
87

💛  - Coveralls


How to recreate all current "symlink" folders

I moved the scoop folder from a drive to another via  zip and of course I lost all my current folders - is there a way to create them back ?

try:
scoop reset *

that seems to do the trick however, the reset could be updated to detect if
"current" is a folder - if it is should remove it. I experiences this when
moved the apps folder from one drive to another.
On Wed, 10 Mar 2021 at 23:39, HUMORCE @.***> wrote:

try:
scoop reset *
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/lukesampson/scoop/issues/4286#issuecomment-796470887,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAUAPPY3ASF72HCJLGNWC4LTDBJQLANCNFSM4Y5BF3KA
.

when you must to be 🤣🤣🤣
but if you have to do it, you may not need my mind anymore

In fact, need to reinstall first.
env variables is important for the scoop.
ifthere are no other problems then you should be close this thread.

Thanks. Closings it.


Dynamic require of "util" is not supported

I'm getting this error using adapter-node with sveltekit after upgrading to latest.
Dynamic require of "util" is not supported
Here's the node error:

$ node build/index.js
Listening on <IP_ADDRESS>:3000
Error: Dynamic require of "util" is not supported
    at file:///home/ettinger/www/grazily.com/grazily-ui/build/server/chunk-BHN6OJC3.js:12:9
    at node_modules/natural/lib/natural/tokenizers/aggressive_tokenizer.js (file:///home/ettinger/www/grazily.com/grazily-ui/build/server/chunk-METZWSI6.js:239:16)
    at __require2 (file:///home/ettinger/www/grazily.com/grazily-ui/build/server/chunk-BHN6OJC3.js:15:50)
    at node_modules/natural/lib/natural/phonetics/phonetic.js (file:///home/ettinger/www/grazily.com/grazily-ui/build/server/chunk-METZWSI6.js:255:21)
    at __require2 (file:///home/ettinger/www/grazily.com/grazily-ui/build/server/chunk-BHN6OJC3.js:15:50)
    at node_modules/natural/lib/natural/phonetics/soundex.js (file:///home/ettinger/www/grazily.com/grazily-ui/build/server/chunk-METZWSI6.js:285:20)
    at __require2 (file:///home/ettinger/www/grazily.com/grazily-ui/build/server/chunk-BHN6OJC3.js:15:50)
    at node_modules/natural/lib/natural/index.js (file:///home/ettinger/www/grazily.com/grazily-ui/build/server/chunk-METZWSI6.js:12623:23)
    at __require2 (file:///home/ettinger/www/grazily.com/grazily-ui/build/server/chunk-BHN6OJC3.js:15:50)
    at node_modules/in-a-nutshell/lib/in-a-nutshell.js (file:///home/ettinger/www/grazily.com/grazily-ui/build/server/chunk-METZWSI6.js:12683:19)

Same here.

I checked the source files that are mentioned in your stack trace. But I don't see a dynamic require of util. Any clue what is going on?

I have the exact same issue as @adaboese has when using in a Remix app, but the same code works fine when running outside of Remix directly on Node.js so it could very well be an issue with Remix

Oke, let's have a look.
Webworker threads are not dynamically required, a try-catch construct is used:
try {
  Threads = require('webworker-threads')
} catch (e) {
  // Since webworker-threads are optional, only thow if the module is found
  if (e.code !== 'MODULE_NOT_FOUND') throw e
}

So it is always tried to load the module.


editorial: field not explicitly required can be considered optional

I suggest

to use a clear BCP14 terminology

instead

can be considered OPTIONAL

is not clear.
note

I'd explicitly add OPTIONAL on optional fields. "Explicit is better than implicit"

otherwise I'd state

if a field is not explicitly REQUIRED, it is OPTIONAL

@jasonbstanding does this cover the issue you raised a couple of weeks ago?

@ioggstream was this related to another issue or discussion? (sorry, I realise it's been a while!)

iirc it was open to suggest a more clean language in the spec
I don't remember if expressions like the above are still present in the latest specs.
The general advise still remains.

I think we could add a note about anything that isn't required being considered optional, if it would make it clearer to anyone.

@lornajane we already have that note at the top of the whole "Schema" (meaning structure of OAS, not JSON Schema) section (3.0.3 §4.7; 3.1.0 §4.8):

In the following description, if a field is not explicitly REQUIRED or described with a MUST or SHALL, it can be considered OPTIONAL.

We discussed this in a TDC meeting and since we have required fields clearly marked and an overall remark about non-required fields being optional by default, we agreed not to add optional to all other fields.
I suggested that it does not improve readability and was not contradicted. I do want to say thanks for the suggestion though - it was a good discussion and ideas are always welcome!


oraclejdk: 8u60 -> 8u65, 8u66

8u65 is a Critical Patch Update (CPU), contains critical security updates.
8u66 is a Patch Set Update (PSU), contains all updates of the CPU, plus additional fixes.
Oracle recommends using CPU version unless users are affected by the bugs fixed by the PSU, so that I made separate packages for each versions and made CPU version as the defaults (without postfix).
http://www.oracle.com/technetwork/java/javase/cpu-psu-explained-2331472.html
8u65 release notes: http://www.oracle.com/technetwork/java/javase/8u65-relnotes-2687063.html
8u66 release notes: http://www.oracle.com/technetwork/java/javase/8u66-relnotes-2692847.html
Both tested on x86_64.

this should also be backported to 15.09

Thank you!


Hamburger icon should replace with close icon if menu opens up

Describe the Issue
Hamburger icon needs to be replaced with close icon if menu opens up
Affected Page
https://contribute.freecodecamp.org/faq/
Steps to Reproduce

Expected behavior

Screenshots

System

Device: android
Browser: chrome

Additional context
No response

Hello @alinmigea please assign this issue to me under gssoc 24


[3.5 RC 7] flicker on some materials when Shader Compilation Mode = Asynchronous + Cache

Godot version
3.5 RC7
System information
Ubuntu 22.04, GLES3, Geforce 1030
Issue description
By runnig https://github.com/miskatonicstudio/intrepid in Godot v3.5-rc7, you can see some flickering(something like shadow) on cryopod's door in the start of the game when Shader Compilation Mode = Asynchronous + Cache.
I found out reverting of #62628 will fix the problem.
Steps to reproduce
clone https://github.com/miskatonicstudio/intrepid and run it in Godot multiple times in Synchronous and Asynchronous Compilation Mode to see the difference.
The problem appears after showing this picture  and before door will be opened:

Minimal reproduction project
N/A

Fixed by #64096.


Display incorrect in Win7_IE10 and OSX10.9_Safari7

Challenge Build a Personal Portfolio Webpage has an issue.
User Agent is: Mozilla/5.0 (Windows NT 5.1; rv:45.0) Gecko/20100101 Firefox/45.0.
Please describe how to reproduce this issue, and include links to screenshots if possible.

I can't reproduce this. I don't have Windows 10 but at least for Windows 7, all browsers work. I can try and verify the Safari issue later.

Turns out I don't have OSX 10.9 so I couldn't verify either issue..I'll keep this open in case other people get issues.

I can confirm this via native testing on OSX 10.9 and Safari 7.
Here is the full user-agent string :
Mozilla/5.0 (Macintosh; Intel Mac OS X 10_9_3) AppleWebKit/537.76.4 (KHTML, like Gecko) Version/7.0.4 Safari/537.76.4
/cc @hallaathrad : Do you know if these older browsers have some form of 'shims' or 'polyfill' techniques to get this working?

Hmmm I've just checked on my Windows 10, all browsers seem to handle it fairly well in their latest versions (including Firefox 45, like the OP). However, cannot check Safari on OSX 10.9.
Arguably, the screenshots are from a cross-browser testing tool, which in my experience hasn't been reliable enough for production testing. Therefor I have machines to actually run natively.
Will try to get the Safari test going, but thus far, I still cannot reproduce.

Aaaand thanks to @raisedadead, we should've found a solution to whatever issues you were having related to this. @georgebakerus please reopen this issue if you are still having the same problem.
Closing as fixed meanwhile (and hopefully forever)

Thanks to @hallaathrad for doing the fixes. After all he is the CSS Ninja at FCC 😉 !


Using the subscript of a dict inside a non-escaping async closure in an actor fails

Describe the bug
When using the subscript of a dictionary inside an async method that is non-escaping in an actor it produces a compiler error. While calling .updateValue() works without problems.
Looking at this code:
actor Foo {
    var dict = [String: String]()
    func foo() async {
        await withTaskGroup(of: Void.self) { _ in
            dict.updateValue("Bar", forKey: "Foo")
            dict["Foo"] = "Bar" // Actor-isolated property 'dict' cannot be passed 'inout' to 'async' function call
        }
    }
}

Expected behavior
The above code should compile fine
rdar://97775762

It's the same if you use an array... but then you don't have the option to use anything like updateValue.
actor Foo {
	var arr = [String]()
	func foo() async {
		await withTaskGroup(of: Void.self) { _ in
			self.arr[0] = "Bar" // Actor-isolated property 'arr' cannot be passed 'inout' to 'async' function call
		}
	}
}

But in comparison, append would work:
actor Foo {
	var arr = [String]()
	func foo() async {
		await withTaskGroup(of: Void.self) { _ in
			arr.append("test")
		}
	}
}

This was fixed by https://github.com/apple/swift/pull/69126


Usage of writeTransaction and writeAndPublish

Supposed I want to write and publish an opration to ApolloStore. I can use the writeAndPublish method directly and it seems to work. But there's also writeTransaction method, which aquires the lock for writing the store. Should I use it at all times? When is it safe to just write to the store without acquiring the lock, and when I should make sure to have the lock acquired?
Also writeTransaction method is public, but it accepts a Transaction, which belongs to com.apollographql.apollo.cache.normalized.internal package. Is it safe to use it despite internal package?

writeAndPublish calls writeTransaction under the hood so it should be safe to use that.
Regarding internal packages, it's safer to not rely on them as implementation might change without warning.

Thank you :)


Spatially resolved multiomics of human cardiac niches

Project short name: SpatialCardiacNiches
Primary Wrangler: Wei
Secondary Wrangler:

Associated files

Google Drive: https://drive.google.com/drive/folders/11GswTlPZ9mCWJYbiNSIGAUkmK8_1mlY1?usp=drive_link
Ingest: https://contribute.data.humancellatlas.org/projects/detail?uuid=925f9a4c-cac0-444a-ad2c-612656ab3a85&tab=experiment-info

Published study links

Paper: https://www.nature.com/articles/s41586-023-06311-1#Sec14

Accessioned data:

Key Events

[ ] Convert published metadata to HCA spreadsheet
[ ] Manually curate dataset to meet HCA metadata standard
[ ] Collect any matrix and cell-type annotation files
[ ] Are the analysis files suitable for CellxGene? If something is missing get in touch with the authors to request it
[ ] Upload sheet to validate metadata
[ ] Transfer raw files to ingest to validate data files
[ ] Check linking using ingest graph validator
[ ] Ask the Secondary Wrangler for an end-to-end review of the project. Ask the Expertise Wrangler to review specific tabs if needed
[ ] Submit dataset to Production
[ ] Complete the Export SOP
[ ] Convert project data to SCEA format following the SCEA conversion SOP if appropriate

Spreadsheet complete - next step is to try and submit it to ingest for validation.

Nice work on a huge project, Wei!
Here are my comments:
Donor

D1 sex in supplementary table 1 is female while on spreadsheet is unknown.
Some donors (D1, D2, D4, D11) do not have a linking with specimens
I did some more digging and these donors exist in the h5ad, but their sangerID points to the previous ENA project, that has been wrangled before but metadata are not available on DCP. In ingest the submission is archived with many metadata errors. I am not sure what is the case here, but for the sake of this secondary review, the aforementioned donors have been wrangled on another published DCP project. We could either omit the donors, or add the existing values in this project too.
For all donors, biomaterial name has an excel function not a value
For donors that no diseases is recorded, we could add normal for known diseases

Imaged specimen

imaged_specimen.slice_thickness in FFPE samples is noted as 10 μm while in protocol and paper is noted as 5 μm

Cell suspension

cell j40 has a function

Sequence file

fastq files from Visium, although the input biomaterial is in the cell_suspension input column, they are referenced as imaged_specimen (i.e. HCAHeartST9383358_imaged_specimen) which would be in separate imaged_specimen column

Image file

Tiff image files for all imaged specimens could be added from heartcellatlas.org in the 3rd dropdown menu (Visium - Interactive sections with cell2location prediction minimal abundances (q05cell_abundance))

Analysis file

log-normalized h5ads do not contain ATAC data. There is a separate h5ad in the heartcellatlas.org site (download here) with the ATAC Peak matrix.

Project was stuck in exporting and was later re-triggered manually by Enrique. Discussion here.
On ingest it is still seems stuck in exporting, but probably can be changed to exported.

State changed (tracker re-started), verified in browser.


Dismantling the ax-toolkit

Currently, there is a VERSION file in the root of the repository that is used by all the projects (currently, ax-invconv and ax-get). This was so it wouldn't be necessary to modify the versions of each individual package in the repository. However, ever since the switch to poetry, versions for each individual package have had to be specified anyway.
Furthermore, it might be nice to upload some of the modules within this repository to the pypi. It would be inconvenient to do so with the current repository layout.
Finally, not all versions of the toolkit modify every project within this repository. For example, v0.6.1 corrected a bug with the ax-invconv script, but the ax-get script remained untouched.
Therefore, I propose separating the following packages/modules (in the following order) and archiving the repository:

[ ] cell_pos (from ax-invconv)
[ ] axm (from ax-invconv)
[ ] ax-get
[ ] ax-invconv

I further propose that we only mark each task as completed when the package reaches pypi.
@108Mbps do you approve of this plan?

That sounds like a good plan.

@108Mbps since you contributed most of the code to cell_pos, I'll leave the creation of a new repository to you. Feel free to change the name of the repository. The code that I've contributed to the module, I hereby grant ownership of the code to you. That way, the whole of cell_pos can be licensed under the zlib license, which makes things simpler.

I personally use Poetry, but feel free to use any build system you wish.

ax-get is now in a separate repository: https://github.com/TechPowerAwaits/ax-get


[ENHANCEMENT] Toolbar uses two rows for small screens

Signed-off-by: Christine Donovan<EMAIL_ADDRESS>With this PR:

When the screen size is tablet or bigger, the toolbar buttons will take up one row (existing behavior).
When the screen size is smaller, the toolbar buttons will be split into two rows to save space

Tablet or bigger screens

Small screens

mmm I thought we said it won't be possible to edit things on mobile phone (small screen). So we should be able to gain space here.

Out of curiosity, is there any push behind this change related to supporting smaller screens or is this just a one-off nice-to-have?

Yes I'm a pushing it for that. It is something I think that will be useful when you have an incident and a link to the dashboard is linked. A high manager join the conversation from a phone and see the dashboard directly in its phone. We should have something decent to display.

This is definitely an edge case (I don't think users do this often), but at the least, it doesn't hurt to assure that the layout looks good at phone-sized screen sizes.

Totally inline with that. Thank you @cndonovan !!


Add support for GHE by checking for github in hostname

Added support for Github enterprise based on the assumption that the hostname would have github in it.
Not sure if the the approach is ok or not.
@jessepollak

@jessepollak Any chance you could have a look at this? I love the extension but really need it to work with GHE.

Sorry about the delay! Shipping at 1.2.0!


bypass-checks doesn't work any more.

A similar previous report is #3418, although there it still worked sometimes.
This used to work a while (some months) ago, but now it always opens the 'details' page.
URL where the bug appears: https://github.com///pull/1216
Screenshot:
As per my reading of #3418 this URL should go directly to CI.
There is a link on the checks page that can be followed, which goes to https://<organisation>.visualstudio.com/<GUID>/_build/results?buildId=<number>:

The HTML for this link looks like this, if it helps:

        <a class="text-small text-gray-light" target="_blank" rel="noopener noreferrer" data-hydro-click="{"event_type":"check_suite.external_click","payload":{"check_suite_id":2102516452,"check_run_id":1959824889,"link_url":"https://<organisation>.visualstudio.com/<GUID>/_build/results?buildId=<number>","link_text":"View more details on","originating_url":"https://github.com/<organisation>/<project>/pull/1216/checks?check_run_id=1959824889","user_id":59690011}}" data-hydro-click-hmac="<gibberish>" href="https://<organisation>.visualstudio.com/<GUID>/_build/results?buildId=<number>">
          <svg class="octicon octicon-link-external mr-2" viewBox="0 0 16 16" version="1.1" width="16" height="16" aria-hidden="true"><path fill-rule="evenodd" d="M10.604 1h4.146a.25.25 0 01.25.25v4.146a.25.25 0 01-.427.177L13.03 4.03 9.28 7.78a.75.75 0 01-1.06-1.06l3.75-3.75-1.543-1.543A.25.25 0 0110.604 1zM3.75 2A1.75 1.75 0 002 3.75v8.5c0 .966.784 1.75 1.75 1.75h8.5A1.75 1.75 0 0014 12.25v-3.5a.75.75 0 00-1.5 0v3.5a.25.25 0 01-.25.25h-8.5a.25.25 0 01-.25-.25v-8.5a.25.25 0 01.25-.25h3.5a.75.75 0 000-1.5h-3.5z"></path></svg>View more details on Azure Pipelines

This does seem to include the $('[data-hydro-click*="check_suite.external_click"]') mentioned on #3418.
Current version of GitHub Refined is 21.2.23, Firefox 85.0.2 (64-bit)

URL where the bug appears: github.com//pull/1216

Can you find and post a real, public URL?

I've tried to look for a public link, but curiously it seems like this does work for public repositories?? E.g. on https://github.com/Azure/azure-powershell/pull/14304 the details links are linked directly to azure for me... However in my private repo it still doesn't work and links to https://github.com/<organisation>/<project>/pull/1216/checks?check_run_id=1968477386 instead. Is there something I can look at to help debug this?
Working links for me on public repositories:
https://github.com/Azure/azure-powershell/pull/14304
https://github.com/microsoft/azure-pipelines-tasks/pull/14445
https://github.com/vercel/next.js/pull/11408
https://github.com/jet/XRay/pull/3
https://github.com/commitizen/cz-cli/pull/808

Do you see any errors in the console? In the Network tab of the developer tools there should also be a fetch to that URL ending i check_run_id=*********

The only thing that stands out is an error that is thrown on the private repo page, but not on the public one:

There doesn't appear to be a network request to check_run_id as far as I can tell.

Can't replicate. I'd probably accept a PR if you sent it.


The FPS label in the 3D viewport partially covers the Camera Preview button

Operating system or device, Godot version, GPU Model and driver (if graphics related):
Godot 3.0 Beta 433cb6f
Issue description:
The FPS label partially covers the Camera Preview button.

how about moving it to left bottom corner?


Update Jenkins Operator Role

Update Role with Image and Build apigroups
Remove openshift-mode annotation and security context from example

Thanks submitting your Operator. Please check below list before you create your Pull Request.

Flat operator directory structure is obsolete from 23-rd of October 2019, only nested directory structure will be accepted.

New Submissions

[ ] Does your operator have nested directory structure?
[ ] Have you selected the Project Community Operator Submissions in your PR on the right-hand menu bar?
[ ] Are you familiar with our contribution guidelines?
[ ] Have you packaged and deployed your Operator for Operator Framework?

[ ] Have you tested your Operator in all supported installation modes?
[ ] Is your submission signed?

Updates to existing Operators

[x] Is your new CSV pointing to the previous version with the replaces property?
[x] Is your new CSV referenced in the appropriate channel defined in the package.yaml ?
[x] Have you tested an update to your Operator when deployed via OLM?
[x] Is your submission signed?

Your submission should not

[ ] Modify more than one operator
[ ] Modify an Operator you don't own
[ ] Rename an operator - please remove and add with a different name instead
[ ] Submit operators to both upstream-community-operators and community-operators at once
[ ] Modify any files outside the above mentioned folders
[ ] Contain more than one commit. Please squash your commits.

Operator Description must contain (in order)

[ ] Description about the managed Application and where to find more information
[ ] Features and capabilities of your Operator and how to use it
[ ] Any manual steps about potential pre-requisites for using your Operator

Operator Metadata should contain

[ ] Human readable name and 1-liner description about your Operator
[ ] Valid category name1
[ ] One of the pre-defined capability levels2
[ ] Links to the maintainer, source code and documentation
[ ] Example templates for all Custom Resource Definitions intended to be used
[ ] A quadratic logo

Remember that you can preview your CSV here.
--
1 If you feel your Operator does not fit any of the pre-defined categories, file an issue against this repo and explain your need
2 For more information see here

cc @akram @khelil

/assign @J0zi

Note : Need to update the Operator CSV for this particular version as and not patch it with a new version as there was a mistake in the earlier PR.


Auto-Updater may fail for signed electron apps

Bug Description:
When testing updating from Theia-Blueprint 1.13.0 (https://download.eclipse.org/theia/1.13.0/windows/) to the latest version, it fails with this log message:
[error] Error: Error: sha512 checksum mismatch, expected YYK4Rj/MMIRE/MeFSfVuQOeShXxrwdM5TMgjgPc5uvNxLkQpqUMqTX7MoqYeLpW2gvcgaeVDYPfFROu8LIhtSw==, got EwV8hwXMsQ+5qIjZ1HFGcdPJyBqdkXyCZCSopvhPzhRzwltCZRWvthszWrVUGb/ranElMKAH38YFLo8Y0IfRSw==
This is probably caused because we sign the installers after this checksum was computed. So we will have to update the metadata file https://download.eclipse.org/theia/latest/windows/latest.yml with the checksum after signing
Auto-Update works for the unsigned Linux AppImage
Steps to Reproduce:

Download 1.13.0 and attempt an update
Check logs at C:\Users\<username>\AppData\Roaming\Theia Blueprint\logs\main.log

@brianking Could you please check this for Mac by updating the 1.13 version: https://download.eclipse.org/theia/1.13.0/macos/
As this is signed as well, I would expect the same issue as for windows.

It's failing on macOS, but with a different error.
[2021-06-30 10:54:08.685] [info]  Checking for update
[2021-06-30 10:54:09.385] [info]  Found version 1.14.0 (url: TheiaBlueprint.dmg)
[2021-06-30 10:54:37.295] [info]  Downloading update from TheiaBlueprint.dmg
[2021-06-30 10:54:37.299] [error] Error: Error: ZIP file not provided: [
  {
    "url": "https://download.eclipse.org/theia/latest/macos/TheiaBlueprint.dmg",
    "info": {
      "url": "TheiaBlueprint.dmg",
      "sha512": "...",
      "size": 341751733
    }
  }
]

I have omitted the sha512 value on purpose, not sure if it is sensitive info.

It's failing on macOS, but with a different error.
[2021-06-30 10:54:08.685] [info]  Checking for update
[2021-06-30 10:54:09.385] [info]  Found version 1.14.0 (url: TheiaBlueprint.dmg)
[2021-06-30 10:54:37.295] [info]  Downloading update from TheiaBlueprint.dmg
[2021-06-30 10:54:37.299] [error] Error: Error: ZIP file not provided: [
  {
    "url": "https://download.eclipse.org/theia/latest/macos/TheiaBlueprint.dmg",
    "info": {
      "url": "TheiaBlueprint.dmg",
      "sha512": "...",
      "size": 341751733
    }
  }
]

I have omitted the sha512 value on purpose, not sure if it is sensitive info.

Thanks! Seems like https://github.com/electron-userland/electron-builder/issues/2199
I'll have a look at this as well

Short update on the windows situation. Updating file size and hash in the metadata file is possible and then leads to the installer being downloaded and invoked. However we then hit a further bug: https://github.com/electron-userland/electron-builder/issues/4711

@jfaltermeier Any updates about macOS?
For Windows, do you see any possible workarounds?
I presume we don't want to get out of beta (1.0?) without having updates fixed, right?

For Windows I have applied a manual fix at the moment, which then leads to a working update: https://download.eclipse.org/theia/latest/windows/
In PR https://github.com/eclipse-theia/theia-blueprint/pull/129 I am working on integrating this into the build process, so that no manual fixes are required. This already fixes the issue mentioned in https://github.com/eclipse-theia/theia-blueprint/issues/116#issuecomment-887495744
Once this is done, I will continue with Mac, as this is a blocker for getting out of beta.

@brianking I've set up a small testing environment and I think updating from e.g 1.16.0 (https://download.eclipse.org/theia/1.16.0/) to 1.17.1 on mac os should work now.
It does not work when the dmg is launched from the Downloads directory directly, as this is then mounted as read-only (for this we should probably open a ticket to improve error reporting, because this was only visible in the logs).
But when I copy blueprint to the Applications directory, the update worked for me. Could you please test this as well?

This update worked successfully for me @jfaltermeier. The only thing missing for me is a progress indicator for the download. It appeared for a while that nothing was happening, until the notification came up prompting me to apply the update.

Thanks! I've opened https://github.com/eclipse-theia/theia-blueprint/issues/160 and https://github.com/eclipse-theia/theia-blueprint/issues/161


Support required namespaces

Support required namespaces when calling session update.
Issue for reference: https://github.com/WalletConnect/walletconnect-specs/issues/52

PR


[UI] Review Answer Tildes

Ensure all the tilde checking stuff works.
Prefix, suffix, in a set including alternate readings that contain both tildes and no tildes (部屋, 〜室)
Easiest way would be to strip all tildes from answer input, compare against chars and readings with tildes stripped. Then return the match with its tilde to replace the answer input field.

Done.


tests: usb: Make tests for usb mass sample more robust

It was found that the existing regex check was not enough to validate
correctness of execution of mass samples. Tests would pass even when
a filesystem failed to be mounted. An additional line to check is added
to validate the setup of a filesystem.
Signed-off-by: Maciej Perkowski<EMAIL_ADDRESS>

@jfischer-no Commit msg amended and gh description edited.


Release 4.9 fixes

Summary
MM-10106 - Extra line in user popover if no email
MM-10100 - Mobile post menu in search style issue
MM-10097 - Fixing footer link styling on mobile
Ticket Link
https://mattermost.atlassian.net/browse/MM-10106
https://mattermost.atlassian.net/browse/MM-10100
https://mattermost.atlassian.net/browse/MM-10097
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[ ] Ran make check-style to check for style errors (required for all pull requests)
[ ] Ran make test to ensure unit and component tests passed
[ ] Added or updated unit tests (required for all new features)
[ ] Has server changes (please link)
[ ] Has redux changes (please link)
[x] Has UI changes
[ ] Includes text changes and localization file (.../i18n/en.json) updates
[ ] Touches critical sections of the codebase (auth, posting, etc.)

@hmhealey Have a look.

@asaadmahmood Looks like there's a build failure


chore: bump version 0.4.0-beta.26

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 6.54%. Comparing base (ac60ce4) to head (984a3bc).
Report is 124 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@          Coverage Diff          @@
##            main    #324   +/-   ##
=====================================
  Coverage   6.54%   6.54%
=====================================
  Files        105     105
  Lines       6742    6742
  Branches    1315    1315
=====================================
  Hits         441     441
  Misses      5041    5041
  Partials    1260    1260

Flag
Coverage Δ

unittests
6.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Big problem on import mysql dump

Hello.
I am trying to import a data dump. After 1-2 minutes pod restart several times in a row

Readiness probe errored: rpc error: code = NotFound desc = failed to exec in container: failed to load task: no running task found: task bb1fe3b46fc402cb7e074622aee15a6f1adc2270fe2f731982f903e9cd569dfe not found: not found

Liveness probe errored: rpc error: code = NotFound desc = failed to exec in container: failed to load task: no running task found: task bb1fe3b46fc402cb7e074622aee15a6f1adc2270fe2f731982f903e9cd569dfe not found: not found

Readiness probe failed: ERROR 2003 (HY000): Can't connect to MySQL server on '<IP_ADDRESS>:3306' (111) /bin/sh: line 0: test: -eq: unary operator expected

v 0.5.3

Wery similar to
https://forums.percona.com/t/fresh-instance-with-percona-xtradb-cluster-operator-v1-8-0-not-starting-completly-under-okd/10415/12
I change calico to cilium, and error gone
BUT - https://forums.percona.com/t/fresh-instance-with-percona-xtradb-cluster-operator-v1-8-0-not-starting-completly-under-okd/10415/22
Maybe it matters


Upgrade to AFNetworking 4.0 Podspec dependency

The type of this PR is: Enhancement

Description
Update Podspec to use AFNetworking v4.0.

Codecov Report

Merging #63 into master will decrease coverage by 1.75%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #63      +/-   ##
==========================================
- Coverage   94.86%   93.10%   -1.76%
==========================================
  Files           4        4
  Lines         292      261      -31
  Branches       12        0      -12
==========================================
- Hits          277      243      -34
- Misses         15       18       +3

Impacted Files
Coverage Δ

Tests/AFNetworkActivityLoggerTests.m
96.62% <0.00%> (-2.27%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fba9eb...af81c89. Read the comment docs.


KubeObjectProtection: exclude VR from Backups

VRs are watched by VRG, and should have ownerReferences to the VRG. When VRs are restored via KubeObjectProtection, ownerReferences are removed. Omitting VRs from Backups allows the VRG to recreate them.
addresses #884

Fixes #884


[FLINK-CDC-BASE] Reorder dependency  flink-table-runtime in pom.xml to avoid dependency conflict.

Search before asking

[X] I searched in the issues and found nothing similar.

Motivation
flink-cdc-base declares flink-table-runtime as its direct dependency. There are two transitive dependencies org.codehaus.janino:commons-compiler and org.codehaus.janino:janino in the dependency tree as listed below. They are introduced by flink-table-planner_2.12.
[INFO] com.ververica:flink-cdc-base:jar:3.0-SNAPSHOT
[INFO] +- org.apache.flink:flink-table-planner_2.12:jar:1.18.0:test
[INFO] |  +- org.codehaus.janino:commons-compiler:jar:3.1.10:test
[INFO] |  +- org.codehaus.janino:janino:jar:3.1.10:test
[INFO] +- org.apache.flink:flink-table-runtime:jar:1.18.0:test

Some duplicate classes in flink-table-planner are also in commons-compiler and janino as listed below.
    org.codehaus.commons.compiler.lang.ClassLoaders$SubresourceGetter
    org.codehaus.commons.compiler.Location
    org.codehaus.commons.compiler.util.LineAndColumnTracker$1
    org.codehaus.commons.compiler.AbstractCompilerFactory
    ...

    org.codehaus.janino.util.ClassFile$CodeAttribute
    org.codehaus.janino.Java$ArrayAccessExpression
    org.codehaus.janino.util.ClassFile$AnnotationDefaultAttribute
    org.codehaus.janino.Java$TryStatement$LocalVariab
    ...

The problem is that the two transitive dependencies are ahead of flink-table-runtime in the dependency tree, thus ahead of flink-table-runtime in the classpath. When multiple JAR files contain the same class, the class loader will load the first occurrence it finds based on the classpath order. This means the classloader will select classes in the transitive dependencies rather than direcly declared flink-table-runtime.
Solution
Change the order of flink-table-runtime and flink-table-planner_2.12 so that flink-table-runtime appears ahead of flink-table-planner_2.12 in classpath. In this way, flink-table-runtime is used as it's meant to be.
Alternatives
No response
Anything else?
No response
Are you willing to submit a PR?

[X] I'm willing to submit a PR!

Closing this issue as it has been migrated to Apache Jira.


support for ed25519 SSH keys broken

Hey @vitobotta just migrate us from Podman with your image to your static linked binaries.
But seems support for modern SSH keys in ed25519 is now broken unlike with image/gem:
LoadError : "cannot load such file -- ed25519_ref10"
#<Thread:0x0000560baa9dc360 /__enclose_io_memfs__/local/lib/hetzner/k3s/cluster.rb:272 run> terminated with exception (report_on_exception is true):
Traceback (most recent call last):
	24: from /__enclose_io_memfs__/local/lib/hetzner/k3s/cluster.rb:272:in `block (2 levels) in wait_for_servers'
	23: from /__enclose_io_memfs__/local/lib/hetzner/utils.rb:54:in `wait_for_ssh'
	22: from /__enclose_io_memfs__/lib/ruby/2.7.0/timeout.rb:110:in `timeout'
	21: from /__enclose_io_memfs__/lib/ruby/2.7.0/timeout.rb:33:in `catch'
	20: from /__enclose_io_memfs__/lib/ruby/2.7.0/timeout.rb:33:in `catch'
	19: from /__enclose_io_memfs__/lib/ruby/2.7.0/timeout.rb:33:in `block in catch'
	18: from /__enclose_io_memfs__/lib/ruby/2.7.0/timeout.rb:95:in `block in timeout'
	17: from /__enclose_io_memfs__/local/lib/hetzner/utils.rb:59:in `block in wait_for_ssh'
	16: from /__enclose_io_memfs__/local/lib/hetzner/utils.rb:59:in `loop'
	15: from /__enclose_io_memfs__/local/lib/hetzner/utils.rb:60:in `block (2 levels) in wait_for_ssh'
	14: from /__enclose_io_memfs__/local/lib/hetzner/utils.rb:83:in `ssh'
	13: from /__enclose_io_memfs__/lib/ruby/gems/2.7.0/gems/net-ssh-7.0.1/lib/net/ssh.rb:254:in `start'
	12: from /__enclose_io_memfs__/lib/ruby/gems/2.7.0/gems/net-ssh-7.0.1/lib/net/ssh/authentication/session.rb:71:in `authenticate'
	11: from /__enclose_io_memfs__/lib/ruby/gems/2.7.0/gems/net-ssh-7.0.1/lib/net/ssh/authentication/session.rb:71:in `each'
	10: from /__enclose_io_memfs__/lib/ruby/gems/2.7.0/gems/net-ssh-7.0.1/lib/net/ssh/authentication/session.rb:87:in `block in authenticate'
	 9: from /__enclose_io_memfs__/lib/ruby/gems/2.7.0/gems/net-ssh-7.0.1/lib/net/ssh/authentication/methods/publickey.rb:18:in `authenticate'
	 8: from /__enclose_io_memfs__/lib/ruby/gems/2.7.0/gems/net-ssh-7.0.1/lib/net/ssh/authentication/key_manager.rb:110:in `each_identity'
	 7: from /__enclose_io_memfs__/lib/ruby/gems/2.7.0/gems/net-ssh-7.0.1/lib/net/ssh/authentication/key_manager.rb:264:in `load_identities'
	 6: from /__enclose_io_memfs__/lib/ruby/gems/2.7.0/gems/net-ssh-7.0.1/lib/net/ssh/authentication/key_manager.rb:264:in `map'
	 5: from /__enclose_io_memfs__/lib/ruby/gems/2.7.0/gems/net-ssh-7.0.1/lib/net/ssh/authentication/key_manager.rb:267:in `block in load_identities'
	 4: from /__enclose_io_memfs__/lib/ruby/gems/2.7.0/gems/net-ssh-7.0.1/lib/net/ssh/key_factory.rb:83:in `load_public_key'
	 3: from /__enclose_io_memfs__/lib/ruby/gems/2.7.0/gems/net-ssh-7.0.1/lib/net/ssh/key_factory.rb:102:in `load_data_public_key'
	 2: from /__enclose_io_memfs__/lib/ruby/gems/2.7.0/gems/net-ssh-7.0.1/lib/net/ssh/buffer.rb:248:in `read_key'
	 1: from /__enclose_io_memfs__/lib/ruby/gems/2.7.0/gems/net-ssh-7.0.1/lib/net/ssh/buffer.rb:337:in `read_keyblob'
/__enclose_io_memfs__/lib/ruby/gems/2.7.0/gems/net-ssh-7.0.1/lib/net/ssh/authentication/ed25519_loader.rb:19:in `raiseUnlessLoaded': unsupported key type `ssh-ed25519' (NotImplementedError)
net-ssh requires the following gems for ed25519 support:
 * ed25519 (>= 1.2, < 2.0)
 * bcrypt_pbkdf (>= 1.0, < 2.0)
See https://github.com/net-ssh/net-ssh/issues/565 for more information

Is it just a Gem missing or is there something more to why this doesn't work with v0.6.4 binary?
As always thanks for you much appreciated efforts to this very neat tool from belove Finland :smile:

check this – I encountered the same issue but was able toi run the tool by adding the keys to my keychain

@Privatecoder Thanks for this info. What is the difference when adding the key to keychain? I am not familiar with it. If that solves these issues I could see if I can make the tool use the agent somehow.

I just tested with an ed25519 key and I was finally able to reproduce the same problem using the mac binary.
However I tried with the Ruby gem I didn't have any problems. I didn't try anything to keychain.
Still investigating....

@vitobotta I found the keychain-solution following this

Thanks, will check it out later. I made a small change to the gems required and am building new prerelease binary to check if it makes any difference.
Are you using a key with a passphrase then if you use an agent? same question for @krauthosting

Like I said in the other issue I've started rewriting it in Rust to solve these issues and the standalone binaries. It shouldn't take long.

I have released the Crystal rewrite, 0.6.5, which should solve a number of issues that the Ruby version had. Please let me know if you have a chance to give this new version a try. :)

@vitobotta Finally managed to test it and works fine on Crystal :+1: Thanks & Cheers from DE to FI :smiley:

Thanks @krauthosting for letting me know :)


[EventRequest] PurchPost.Codeunit.al (codeunit 90 "Purch.-Post")

Hi MS,
Please help us in migrating our verticalized solution by adding below events in PurchPost.Codeunit.al Codeunit.
Standard Code (Screenshot from PostPurchLine Function)

Modified Code

Event Signature

Thanks
SUD

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


TimePeriodSubtractor ignores the parameter combinePeriods

source  ---|------
remove        --
result  ---|--  --

source has 2 segments that touch each other
result has now 3 segments - first source segment is untouched, 2nd source segment got split into two pieces
source https://github.com/Giannoudis/TimePeriodLibrary/pull/11

Fixed in release v2.1.2
many thanks to @Mar-Pfa


App not terminating node child process on macOS

Can't reproduce that anymore.

Can't reproduce that anymore.


use fs::OpenOptions with write flag for writing tag

So I was playing with this library and noticed that Tag::write_to_path(file_name, version) always results in error. So I found a problem and fixed it.

Thanks.


Trying to change color in the SplitButton first sample crashes the app.

Describe the bug
When navigating to the Basic Input> SplitButton and trying to change color in the first sample the app crashes.
Steps to reproduce the bug

Steps to reproduce the behavior:

Go to 'Basic Input> SplitColor'
Click on 'Color split button on first example'

Expected behavior
Color on text changes
Actual behavior
App crashes
Version Info

[X] App downloaded from Store

If so, which version? <IP_ADDRESS>

[ ] App built locally from source

If so, which branch? (WinUI 3 versions are built off the winui3 branch)

Additional context

Windows version:

[X] Insider Build (22000.194)
[ ] May 2021 Update (19043)
[ ] October 2020 Update (19042)
[ ] May 2020 Update (19041)
[ ] November 2019 Update (18363)
[ ] May 2019 Update (18362)
[ ] October 2018 Update (17763)
[ ] April 2018 Update (17134)
[ ] Fall Creators Update (16299)
[ ] Creators Update (15063)
[ ] Anniversary Update (14393)

Device form factor:

[X] Desktop
[ ] Mobile
[ ] Xbox
[ ] Surface Hub
[ ] IoT

Thank for for filing this bug @JuanMejiaVelez ! I can't repro this bug using the latest version of the Gallery so I will close this bug. Feel free to reopen it if you encounter it again.


Feature Request: non-blocking recv()

It would be nice to have a way of non-blocking recv(). I think there is many applications for it, just like in std::sync::mpsc::Receiver.

@tstellanova ping

@wucke13 feel free to submit a pull request

I have looked into this a bit more. AFAIK, there are two ways of accomplishing this:

ugly: spawning a new thread, blocking recv() in that thread, push to MPSC, use MPSC try_recv() to get async behavior. That's what I'm currently doing as a hot fix.
correct: Adding state to read_versioned_msg(). Detect if buffer is not big enough to parse the message, and return std::io::ErrorKindWouldBlock in that case. Preserve the so far consumed bytes, as they might be part of a valid message. That way it becomes trivial to implement the actual try_recv(). One could orient at tokio's codec trait, for the implementation.

The correct way of doing this involves re-implementing parts of the MAVLink parser. Any chances that you will look into this? Can you confirm my understanding of the possible solutions, or is there a neat way that I'm missing out on?

Sounds like you’re making progress on a design.
Agreed the second approach seems more beneficial than the first.
I’m unlikely to have time to add features in the next few months, and admittedly I have not kept up with the latest async features in rust, so may not be the best person to advise on that. Last I heard, @podhrmic was working on a significant refactor, but I don’t know where that’s at.

On Dec 26, 2019, at 10:35 AM, wucke13<EMAIL_ADDRESS>wrote:
I have looked into this a bit more. AFAIK, there are two ways of accomplishing this:
ugly: spawning a new thread, blocking recv() in that thread, push to MPSC, use MPSC try_recv() to get async behavior. That's what I'm currently doing as a hot fix.
correct: Adding state to read_versioned_msg(). Detect if buffer is not big enough to parse the message, and return std::io::ErrorKindWouldBlock in that case. Preserve the so far consumed bytes, as they might be part of a valid message. That way it becomes trivial to implement the actual try_recv(). One could orient at tokio's codec trait, for the implementation.
The correct way of doing this involves re-implementing parts of the MAVLink parser. Any chances that you will look into this? Can you confirm my understanding of the possible solutions, or is there a neat way that I'm missing out on?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

Hi @wucke13 !
I thought about this library as "bare minimum" - i.e. it only provides struct definitions and a couple of convenience functions (socket and serial read for example). What you are mentioning would benefit from using rust futures for example.
That being sad, feel free to submit a PR with your solution, just make sure it is properly feature gated with #[cfg(feature = "...")] (we want the library to be usable even in no-std environments)
@tstellanova I got kind of stuck typechecking enums and implementing a set of sensible quickcheck tests, then I ran out of time. So it is kind of half finished at the moment:-/

I would oppose to using futures for this. From recent experiment I took away that futures are only beneficial when one build complex dependencies on them. For a simple "give it to me, if and only if its ready" they are not a good fit. I would therefore still prefer the try_recv style interface.
Also, I think try_recv should be considered part of bare minimum. I mean, even the Arduino serial interface offers a an aswer to "How much can I receive". So IMHO even in an absolute bare minimum setup, there should be an non blocking way of asking for new messages.
I'm still not convinced that my understanding is sufficient to make a PR for this, we will see :smile:

Just to update this issue, I'm working to add such feature, probably a PR should be ready in a couple of days, the ideas is to implement something like try_recv as @wucke13 commented, and maybe in the future having something closer to mpsc.

@patrickelectric That is very good news! However, please note: Since I wrote my comment, futures came a long way! Especially with smol the futures thing became much more accessible, at least to me. I think the correct way of doing making the mavlink crate future proof is this:

Offering recv() for legacy compatibilitie, and because it is sufficient sometimes
Offering try_recv() for simple async-ish stuff. This is important especially for no_std, as it may not be so simple to spawn a real async executor there.
Offering async recv(). This is the most useful way of interacting with a message stub, IMO.

Internally, recv() could just await the aysn recv for the sake of simplicity. I don't see any reason so far, why this wouldn't work. That way mavlink.rs can offer a rich and modern API without too much code duplication or other sacrifices.
What do you think about this?


while typing inValid URL then it is not navigating to page not found page

when i type the inValid and enter it is not navigating to error page or Page not found Screen. instead of this,  I'm getting errors in logs.

This is my code
final routerDelegate = BeamerDelegate(
transitionDelegate: const ReverseTransitionDelegate(),
notFoundRedirectNamed: "/error",
locationBuilder: RoutesLocationBuilder(routes: {
'/': (context, state, data) => HomeScreen(),
'/articles/': (context, state, data) => ArticlesHomeScreen(),
'/articles/authors': (context, state, data) => ArticleAuthorsScreen(),
'/articles/genres': (context, state, data) => ArticleGenresScreen(),
'/books/authors': (context, state, data) => BookAuthorsScreen(),
'/books/genres': (context, state, data) => BookGenresScreen(),
'/books/*': (context, state, data) => BooksHomeScreen(),
}),

@lakshya2024 You need to add the "/error" route to the routebuilder.
The error route actually needs to exist.


GeoJSON properties only

Hi!
I'm working with GeoJSON large files. An example of entry:
{
   "type":"FeatureCollection",
   "features":[
      {
         "type":"Feature",
         "id":"500410000A0055",
         "geometry":{
            "type":"Polygon",
            "coordinates":[
               [
                  [
                     -1.8556355,
                     49.6650877
                  ],
                  [
                     -1.8556206,
                     49.6650552
                  ],
                  [
                     -1.8555928,
                     49.6650017
                  ],
                  [
                     -1.8552808,
                     49.6650365
                  ],
                  [
                     -1.85531,
                     49.6651397
                  ],
                  [
                     -1.8555869,
                     49.6650975
                  ],
                  [
                     -1.8556355,
                     49.6650877
                  ]
               ]
            ]
         },
         "properties":{
            "id":"500410000A0055",
            "commune":"50041",
            "prefixe":"000",
            "section":"A",
            "numero":"55",
            "contenance":248,
            "arpente":false,
            "created":"1902-09-20",
            "updated":"2021-03-09"
         }
      }
   ]
}

I only need some properties informations like contenance, section and numero. From now, I using this:

$datas = Items::fromFile('datas/50041.json', ['pointer' => '/features']);

foreach ($datas as $key => $data) {

  if ($data->properties->contenance == 248) {

  	echo $data->properties->commune;
  	echo $data->properties->section;
  	echo $data->properties->numero;
  	//Etc

  }

}

But, I don't need geometry who takes a lot of time to load.
So I tried to use this more precise pointer:

$datas = Items::fromFile('datas/50041.json', ['pointer' => '/features/-/properties']);

foreach ($datas as $key => $data) {
  var_dump($data);
}

But JSON Machine don't return an object...
So, is it possible to pointer GeoJSON properties as an object with JSON Machine without load geometry?
Thanks!

Hi, thanks for the question, and sorry for the delay. I had much stuff going on in life 😄. I'll try to get to it asap. In the meantime, you can try dev-recursive version from #36 if it works for you. Let me know.

HI!
I tried this:

$datas = Items::fromFile('datas/50041.json', ['recursive' => true]);

foreach ($datas as $data) {

  foreach ($data as $d) {

    foreach ($d as $dKey => $dValue) {

      if ($dKey === 'properties') {

        if ($dValue->contenance == 248) {

          echo $dValue->commune;
          echo $dValue->section;
          echo $dValue->numero;
        }

      }

    }

  }

}

... but it doesn't seem more efficient.
Is it the good way to use recursive ?

What exactly do you mean by efficient? Quicker or less memory usage?

This is the same execution time with the two methods.

Yes. The recursive method is there to lower memory consumption in bigger subtrees. The speed is more or less the same.

But JSON Machine don't return an object...
What does it return?

But, I don't need geometry who takes a lot of time to load.

Btw you can't avoid parsing geometry internally, as the parser has to read everything sequentially to know where it is. JSON is by by nature a format where you have to go through all the data to find what you need. There are no places on the data known beforehand that mark where you can safely jump.

What does it return?

$datas = Items::fromFile('datas/50041.json', ['pointer' => '/features/-/properties']);

foreach ($datas as $key => $data) {
  var_dump($data);
}

Returns:
string(14) "500410000A0084"
string(5) "50041"
string(3) "000"
string(1) "A"
string(2) "84"
int(51040)
bool(false)
string(10) "1902-09-20"
string(10) "2021-03-09"
string(14) "500410000A0086"
string(5) "50041"
string(3) "000"
string(1) "A"
string(2) "86"
int(1885)
bool(false)
string(10) "1902-09-20"
string(10) "2021-03-09"
etc.

Can you please elaborate more on what's wrong about this output?

Recursive iteration #36 is now finished, merged, and released.

Oh, I see what you mean now.  This is the result of the architecture of this library. The pointer specifies a structure, that will be iterated over. If you specify .../properties, you get an iterator over the insides of the properties. Support for different JSON file formats is currently out of the scope of this lib... If the original problem is, that geometry takes a long time to load, there's no way around it. The parser cannot jump, it has to read everything sequentially to find what you're looking for. One thing, that might help is to try /features/- pointer. The solution may involve PassThruDecoder, which skips decoding and may save you some time. You then decode only the properties key. Updating your example (not tested):
$feature = Items::fromFile('datas/50041.json', ['pointer' => '/features/-', 'decoder' => new PassThruDecoder]);

foreach ($feature as $key => $value) {
  if ($key == 'properties') {
    json_decode($value);
  }
}

Updating your example

Nice, this is faster!

Edit: You may also want to try the recursive iteration

I will try, but you said than The speed is more or less the same, right?
Thanks a lot!

I will try, but you said than The speed is more or less the same, right?

Right, it was just another suggestion in case the problem is also in unacceptable memory consumption of geometry.
(Also, after finishing the recursive iteration feature, performance tests show it's actually about 2x slower. See Readme.)


Make orthogonal side views behave like 2D view

Godot version:
3.0.2, but is present in 3.1 dev
OS/device including version:
Elementary OS Loki
Issue description:
In 2D view middle mouse pans and mouse wheel zooms, left mouse selects. This makes sense.
In 3D view, when the user switches to orthogonal left view (which is what it is - a 2d view for a 3d scene), the controls stay the same as they were for 3d - which is, middle mouse orbits the scene (leaving left view). That's a major break of continuity in the interface, which forces the user to memorize two different behaviors for two different 2D views, and on the mistake, rips them out of the zone.
Steps to reproduce:
Switch to 2D view. Use mouse wheel to zoom, and middle mouse to pan.
Switch to 3D view. Switch to left orthogonal view. Use mouse wheel to zoom, and middle mouse to orbit and leave left view.

This does not seem like a good idea. An orthogonal left view is not really any more a 2D view for a 3D scene then any other orthogonal camera angle in the 3D view. I think that there would be an even greater, and very unintuitive, continuity break if the "middle click to rotate" action was altered purely due to the angle of your camera. I believe making hot-keys function differently given a 2D or 3D context is perfectly acceptable, for example I would not want the mouse wheel to zoom while using the text editor.

All game level editors I know of have 2D viewports for 3D scenes. Unreal, Radiant, Trenchbroom, Quark, you name it - they all have an option of switching into 2D projection and manipulating 3D objects as if they were 2D. It speeds up the design process greatly, and some things just can't be done without it. Leaving what is perceived as 2D view by trying to pan and rotating the camera instead is an extremely annoying experience.
At the very least least we should have an option.

I wonder if just changing the hotkeys would solve your problem.
If you go into Editor -> Editor Settings  then  Editors -> 3d and swap the values for Orbit Modifier to "Shift" and Pan Modifier to "None" does that fix your issue?
This would mean that middle click would always pan in the 3D view and in order to rotate you will need to hold shift.

I wonder if just changing the hotkeys would solve your problem.
If you go into Editor -> Editor Settings then Editors -> 3d and swap the values for Orbit Modifier to "Shift" and Pan Modifier to "None" does that fix your issue?
This would mean that middle click would always pan in the 3D view and in order to rotate you will need to hold shift.

Yeah, but then it breaks the 3d view, where I should hold shift to orbit.
The 3d editor needs fixed 2d views.

You can check Lock View Rotation on each viewport's Perspective menu. This will pan when using the middle mouse button, without rotating.

Thanks, Calinou.

I'll close this issue, as the base feature is already present. If it needs to be further improved, please create a proposal on the Godot proposals repository.


Source licensing program update

As Project Acoustics continues to evolve, the team has been interested in gaining an understanding for how the project can provide impact to others.  One of the ways that we have gained a better understanding of the project is by having deeper collaborations with partners by providing access to the source code.  This pilot program has allowed us to gain valuable insights into the potential for the technology.
The Project Acoustics team is no longer accepting new partners for the source code access program. We appreciate those who have participated in this program.  The valuable insights our partners have provided through this program have made the project better in innumerable ways.
Existing partners that currently have access to the source code will continue to have access and can continue to utilize the code for their ongoing projects, although we will no longer be providing source code updates. In addition, the publicly available binary tools on Microsoft's Download Center and Unreal Marketplace will continue to be available and supported.

Hi Noel, thank you for the update.
In light of this, what would be the recommended course of action for studios looking to start using Project Acoustics on unsupported platforms?
As you mentioned in #150:

we are investigating the viability of a fully supported commercial offering.

Is there a time table on when your team may be able to share more regarding this ?

@MiniJo we thank you for your interest in the project.  We sincerely appreciate everyone who has been paying attention to the evolution of the technology.  Unfortunately, we are just beginning the exploration for commercial viability and don't have any timeline to share regarding the public licensing of the source.
We will let everyone know as soon as we have more information to share.


The console button should also dismiss the console

Clicking the console again should dismiss it.
Also, should clicking on it dismiss it or not? Maybe the first negates the need for the second

Ha, was just saying this on Slack 👍


COCT refactoring

This PR integrates the idea of the CoctLogic class into the Coct itself, simplifying the creation of COCT files and hiding a good amount of logic. I am 100% sure this is generating COCT complaint files thanks to the commented test CollisionTests.PreserveCollision, but it breaks compatibility with LightCollision, since they have a weird value as BoundingBoxIndex. This specific part will be fixed but it is not the scope of this PR.
This is just the first part of the COCT refactoring I have in mind, but I am proposing the change now because I do not want to go too much in depth with the changes yet, in favour of continuous integration.
A bit off topic, but there is another branch called feature/collision-optimization-wip that refactors the VertexIndex part as well. But even if it was generating virtually the same files, the output contained different indices when compared to a COCT generated by SquareEnix. They are not read in order as I found a 0 1 2 3 8 9 10 11 12 13 6 7 4 5 14 15 pattern on how vertices are stored in the file. Probably they are performing some logic that we are missing at the moment.

Kh2MapCollisionEditor fixed. Thanks for the feedback :) be free to accept it if you think it is correct.
Before merging though, I would like to have people like @Disgustor or @Tomk1004 to test it, in case of any regression.

I converted this pull request from Ready to Draft due to a problem that @Disgustor discovered.
The problem seems to be related to the following commit: 7aa2ace597f0ec15b2132e1605267222e23aa319 on CreateDoctFromCoct(). This PR can not be merged into master until this problem is fixed.


Add undocumented var

Fails with:
Error: CiviForm environment variables are not correctly documented. See <placeholder> for documentation instructions. Issues:
The following vars are not documented in /home/runner/work/civiform/civiform/server/conf/env-var-docs.json:
{'MY_NEW_VAR'}


Provide a means of avoiding distinct() on MultipleChoiceFilter

When using the MultipleChoiceFilter (or anything derived from it) we were having issues with the performance of queries whenever they included a superfluous distinct() call (not at all needed in our case, the filter doesn't add duplication).  Seems this is easily avoided in the base Filter class but not in the MultipleChoiceFilter.  Changed: Adding the same self.distinct check as seen in Filter and defaulting to 'distinct=True' on the MultipleChoiceFilter for backward compatibility sake.
Generally a bit bemused by the distinct tangle we have here;  deferring all logic on whether distinct() is needed would surely sits better with whatever is responsible for running the final query?

Hey @JonPeel — Thanks. This looks great.
The Travis build doesn't appear to have run — I'll have a look and see if I can work that out in the morning.

Pull request updated with similar changed to honour the exclude=True flag provided by the base Filter class.
I've skipped DateRangeFilter as dealing with the class level lambda's is an interface change I don't want to get involved in. Everything else is rather straightforward.
Please let me know what changes, if any, would be required to merge

Has this been read again yet ? Would be very useful to us !

It's been read. I'll get to it.
Sorry for the delay — it's a question of time. We're currently at 17 issues and 15 PRs — down from >100 and ≈40 when I took on the project — so we're Getting There™

Sure :) Was just an inquiry. Impressive work by the way...

I'm closing this in favour of #278 — that just brings this up to the latest develop. (Having not got to it sooner I felt bad asking you to update.)
Thanks for the work here @JonPeel! Awesome!

@carltongibson - no worries, thanks for the update / merge.


What is the approximate scarebleu score of the de_en dataset in the example？

Hello, I would like to ask that the score of the de_en data set is very low, and the score I run is 3.63, is this normal？

This is not normal, but I don't know what your experimental setup is.
You can debug in the following steps:

Run base NMT to ensure that the performance of the pretrained model is normal.
Run vanilla kNN-MT to verify that the datastore is useful.
If both models perform well, you can try to adjust the hyperparameters of robust kNN-MT. We recommend setting beta to 0 first to ensure that the trained module is useful.

I have found this problem due to insufficient memory of the graphics card, thank you for your suggestion!! Great implementation results