chore(typings): upgrade 'tsd' to 'typings'

This is mostly done, however there are several type warnings still... it does build and works though.
@gdi2290 I would greatly appreciate your help in finalizing this if you could checkout this typings branch and clear the remaining type warnings (stuck on those):
https://github.com/NathanWalker/angular2-seed/tree/typings

Thanks @gdi2290 I updated per your suggestions, however I still get these warnings:
app/about/components/about.e2e.ts(1,1): error TS2304: Cannot find name 'describe'.
app/about/components/about.e2e.ts(3,3): error TS2304: Cannot find name 'beforeEach'.
app/about/components/about.e2e.ts(4,5): error TS2304: Cannot find name 'browser'.
app/about/components/about.e2e.ts(7,3): error TS2304: Cannot find name 'it'.
app/about/components/about.e2e.ts(8,5): error TS2304: Cannot find name 'expect'.
app/about/components/about.e2e.ts(8,12): error TS2304: Cannot find name 'element'.
app/about/components/about.e2e.ts(8,20): error TS2304: Cannot find name 'by'.
app/about/components/about.e2e.ts(11,3): error TS2304: Cannot find name 'it'.
app/about/components/about.e2e.ts(12,5): error TS2304: Cannot find name 'expect'.
app/about/components/about.e2e.ts(12,12): error TS2304: Cannot find name 'element'.
app/about/components/about.e2e.ts(12,20): error TS2304: Cannot find name 'by'.
app/about/components/about.e2e.ts(15,3): error TS2304: Cannot find name 'it'.
app/about/components/about.e2e.ts(16,5): error TS2304: Cannot find name 'element'.
app/about/components/about.e2e.ts(16,13): error TS2304: Cannot find name 'by'.
app/about/components/about.e2e.ts(17,5): error TS2304: Cannot find name 'element'.
app/about/components/about.e2e.ts(17,13): error TS2304: Cannot find name 'by'.
app/about/components/about.e2e.ts(18,5): error TS2304: Cannot find name 'expect'.
app/about/components/about.e2e.ts(18,12): error TS2304: Cannot find name 'element'.
app/about/components/about.e2e.ts(18,20): error TS2304: Cannot find name 'by'.
app/app/components/app.e2e.ts(1,1): error TS2304: Cannot find name 'describe'.
app/app/components/app.e2e.ts(3,3): error TS2304: Cannot find name 'beforeEach'.
app/app/components/app.e2e.ts(4,7): error TS2304: Cannot find name 'browser'.
app/app/components/app.e2e.ts(7,3): error TS2304: Cannot find name 'it'.
app/app/components/app.e2e.ts(8,7): error TS2304: Cannot find name 'expect'.
app/app/components/app.e2e.ts(8,14): error TS2304: Cannot find name 'browser'.
app/app/components/app.e2e.ts(11,3): error TS2304: Cannot find name 'it'.
app/app/components/app.e2e.ts(12,7): error TS2304: Cannot find name 'expect'.
app/app/components/app.e2e.ts(12,14): error TS2304: Cannot find name 'element'.
app/app/components/app.e2e.ts(12,22): error TS2304: Cannot find name 'by'.
app/app/components/app.e2e.ts(15,3): error TS2304: Cannot find name 'it'.
app/app/components/app.e2e.ts(16,7): error TS2304: Cannot find name 'expect'.
app/app/components/app.e2e.ts(16,14): error TS2304: Cannot find name 'element'.
app/app/components/app.e2e.ts(16,22): error TS2304: Cannot find name 'by'.
app/app/components/app.e2e.ts(19,3): error TS2304: Cannot find name 'it'.
app/app/components/app.e2e.ts(20,7): error TS2304: Cannot find name 'expect'.
app/app/components/app.e2e.ts(20,14): error TS2304: Cannot find name 'element'.
app/app/components/app.e2e.ts(20,22): error TS2304: Cannot find name 'by'.
app/app/components/app.e2e.ts(23,3): error TS2304: Cannot find name 'it'.
app/app/components/app.e2e.ts(24,7): error TS2304: Cannot find name 'expect'.
app/app/components/app.e2e.ts(24,14): error TS2304: Cannot find name 'element'.
app/app/components/app.e2e.ts(24,22): error TS2304: Cannot find name 'by'.
app/home/components/home.e2e.ts(1,1): error TS2304: Cannot find name 'describe'.
app/home/components/home.e2e.ts(3,3): error TS2304: Cannot find name 'beforeEach'.
app/home/components/home.e2e.ts(4,5): error TS2304: Cannot find name 'browser'.
app/home/components/home.e2e.ts(7,3): error TS2304: Cannot find name 'it'.
app/home/components/home.e2e.ts(8,7): error TS2304: Cannot find name 'expect'.
app/home/components/home.e2e.ts(8,14): error TS2304: Cannot find name 'element'.
app/home/components/home.e2e.ts(8,22): error TS2304: Cannot find name 'by'.
app/home/components/home.e2e.ts(12,3): error TS2304: Cannot find name 'it'.
app/home/components/home.e2e.ts(13,7): error TS2304: Cannot find name 'expect'.
app/home/components/home.e2e.ts(13,14): error TS2304: Cannot find name 'element'.
app/home/components/home.e2e.ts(13,22): error TS2304: Cannot find name 'by'.
app/home/components/home.e2e.ts(17,3): error TS2304: Cannot find name 'it'.
app/home/components/home.e2e.ts(18,7): error TS2304: Cannot find name 'expect'.
app/home/components/home.e2e.ts(18,14): error TS2304: Cannot find name 'element'.
app/home/components/home.e2e.ts(18,22): error TS2304: Cannot find name 'by'.
app/hot_loader_main.ts(5,1): error TS2304: Cannot find name 'System'.
/Users/nathanbackup/Documents/github_projects/angular2-stuff/angular2-seed/node_modules/angular2/src/core/change_detection/parser/locals.d.ts(3,14): error TS2304: Cannot find name 'Map'.
/Users/nathanbackup/Documents/github_projects/angular2-stuff/angular2-seed/node_modules/angular2/src/core/change_detection/parser/locals.d.ts(4,42): error TS2304: Cannot find name 'Map'.
/Users/nathanbackup/Documents/github_projects/angular2-stuff/angular2-seed/node_modules/angular2/src/core/di/provider.d.ts(436,103): error TS2304: Cannot find name 'Map'.
/Users/nathanbackup/Documents/github_projects/angular2-stuff/angular2-seed/node_modules/angular2/src/core/di/provider.d.ts(436,135): error TS2304: Cannot find name 'Map'.
/Users/nathanbackup/Documents/github_projects/angular2-stuff/angular2-seed/node_modules/angular2/src/core/zone/ng_zone.d.ts(2,37): error TS2304: Cannot find name 'Zone'.
/Users/nathanbackup/Documents/github_projects/angular2-stuff/angular2-seed/node_modules/angular2/src/facade/collection.d.ts(1,25): error TS2304: Cannot find name 'MapConstructor'.
/Users/nathanbackup/Documents/github_projects/angular2-stuff/angular2-seed/node_modules/angular2/src/facade/collection.d.ts(2,25): error TS2304: Cannot find name 'SetConstructor'.
/Users/nathanbackup/Documents/github_projects/angular2-stuff/angular2-seed/node_modules/angular2/src/facade/collection.d.ts(4,27): error TS2304: Cannot find name 'Map'.
/Users/nathanbackup/Documents/github_projects/angular2-stuff/angular2-seed/node_modules/angular2/src/facade/collection.d.ts(4,39): error TS2304: Cannot find name 'Map'.
/Users/nathanbackup/Documents/github_projects/angular2-stuff/angular2-seed/node_modules/angular2/src/facade/collection.d.ts(7,9): error TS2304: Cannot find name 'Map'.
/Users/nathanbackup/Documents/github_projects/angular2-stuff/angular2-seed/node_modules/angular2/src/facade/collection.d.ts(8,30): error TS2304: Cannot find name 'Map'.
/Users/nathanbackup/Documents/github_projects/angular2-stuff/angular2-seed/node_modules/angular2/src/facade/collection.d.ts(11,43): error TS2304: Cannot find name 'Map'.
/Users/nathanbackup/Documents/github_projects/angular2-stuff/angular2-seed/node_modules/angular2/src/facade/collection.d.ts(12,27): error TS2304: Cannot find name 'Map'.
/Users/nathanbackup/Documents/github_projects/angular2-stuff/angular2-seed/node_modules/angular2/src/facade/collection.d.ts(14,23): error TS2304: Cannot find name 'Map'.
/Users/nathanbackup/Documents/github_projects/angular2-stuff/angular2-seed/node_modules/angular2/src/facade/collection.d.ts(15,25): error TS2304: Cannot find name 'Map'.
/Users/nathanbackup/Documents/github_projects/angular2-stuff/angular2-seed/node_modules/angular2/src/facade/collection.d.ts(94,41): error TS2304: Cannot find name 'Set'.
/Users/nathanbackup/Documents/github_projects/angular2-stuff/angular2-seed/node_modules/angular2/src/facade/collection.d.ts(95,22): error TS2304: Cannot find name 'Set'.
/Users/nathanbackup/Documents/github_projects/angular2-stuff/angular2-seed/node_modules/angular2/src/facade/collection.d.ts(96,25): error TS2304: Cannot find name 'Set'.
/Users/nathanbackup/Documents/github_projects/angular2-stuff/angular2-seed/node_modules/angular2/src/facade/lang.d.ts(2,22): error TS2304: Cannot find name 'BrowserNodeGlobal'.
/Users/nathanbackup/Documents/github_projects/angular2-stuff/angular2-seed/node_modules/angular2/src/facade/lang.d.ts(48,59): error TS2304: Cannot find name 'Map'.
/Users/nathanbackup/Documents/github_projects/angular2-stuff/angular2-seed/node_modules/angular2/src/facade/promise.d.ts(1,10): error TS2304: Cannot find name 'Promise'.
/Users/nathanbackup/Documents/github_projects/angular2-stuff/angular2-seed/node_modules/angular2/src/facade/promise.d.ts(3,14): error TS2304: Cannot find name 'Promise'.
/Users/nathanbackup/Documents/github_projects/angular2-stuff/angular2-seed/node_modules/angular2/src/facade/promise.d.ts(8,32): error TS2304: Cannot find name 'Promise'.
/Users/nathanbackup/Documents/github_projects/angular2-stuff/angular2-seed/node_modules/angular2/src/facade/promise.d.ts(9,38): error TS2304: Cannot find name 'Promise'.
/Users/nathanbackup/Documents/github_projects/angular2-stuff/angular2-seed/node_modules/angular2/src/facade/promise.d.ts(10,35): error TS2304: Cannot find name 'Promise'.
/Users/nathanbackup/Documents/github_projects/angular2-stuff/angular2-seed/node_modules/angular2/src/facade/promise.d.ts(10,93): error TS2304: Cannot find name 'Promise'.
/Users/nathanbackup/Documents/github_projects/angular2-stuff/angular2-seed/node_modules/angular2/src/facade/promise.d.ts(11,34): error TS2304: Cannot find name 'Promise'.
/Users/nathanbackup/Documents/github_projects/angular2-stuff/angular2-seed/node_modules/angular2/src/facade/promise.d.ts(12,32): error TS2304: Cannot find name 'Promise'.
/Users/nathanbackup/Documents/github_projects/angular2-stuff/angular2-seed/node_modules/angular2/src/facade/promise.d.ts(12,149): error TS2304: Cannot find name 'Promise'.
/Users/nathanbackup/Documents/github_projects/angular2-stuff/angular2-seed/node_modules/angular2/src/facade/promise.d.ts(13,43): error TS2304: Cannot find name 'Promise'.
/Users/nathanbackup/Documents/github_projects/angular2-stuff/angular2-seed/node_modules/angular2/src/platform/browser/browser_adapter.d.ts(75,33): error TS2304: Cannot find name 'Map'.
/Users/nathanbackup/Documents/github_projects/angular2-stuff/angular2-seed/node_modules/angular2/src/platform/dom/dom_adapter.d.ts(84,42): error TS2304: Cannot find name 'Map'.
/Users/nathanbackup/Documents/github_projects/angular2-stuff/angular2-seed/node_modules/rxjs/CoreOperators.d.ts(22,67): error TS2304: Cannot find name 'Promise'.
/Users/nathanbackup/Documents/github_projects/angular2-stuff/angular2-seed/node_modules/rxjs/CoreOperators.d.ts(72,67): error TS2304: Cannot find name 'Promise'.
/Users/nathanbackup/Documents/github_projects/angular2-stuff/angular2-seed/node_modules/rxjs/CoreOperators.d.ts(77,31): error TS2304: Cannot find name 'PromiseConstructor'.
/Users/nathanbackup/Documents/github_projects/angular2-stuff/angular2-seed/node_modules/rxjs/CoreOperators.d.ts(77,54): error TS2304: Cannot find name 'Promise'.
/Users/nathanbackup/Documents/github_projects/angular2-stuff/angular2-seed/node_modules/rxjs/Observable.d.ts(65,67): error TS2304: Cannot find name 'PromiseConstructor'.
/Users/nathanbackup/Documents/github_projects/angular2-stuff/angular2-seed/node_modules/rxjs/Observable.d.ts(65,88): error TS2304: Cannot find name 'Promise'.
/Users/nathanbackup/Documents/github_projects/angular2-stuff/angular2-seed/node_modules/rxjs/Observable.d.ts(72,84): error TS2304: Cannot find name 'Promise'.
/Users/nathanbackup/Documents/github_projects/angular2-stuff/angular2-seed/node_modules/rxjs/Observable.d.ts(77,38): error TS2304: Cannot find name 'Promise'.
/Users/nathanbackup/Documents/github_projects/angular2-stuff/angular2-seed/node_modules/rxjs/Observable.d.ts(100,66): error TS2304: Cannot find name 'Promise'.
/Users/nathanbackup/Documents/github_projects/angular2-stuff/angular2-seed/node_modules/rxjs/Observable.d.ts(154,66): error TS2304: Cannot find name 'Promise'.
/Users/nathanbackup/Documents/github_projects/angular2-stuff/angular2-seed/node_modules/rxjs/Observable.d.ts(159,31): error TS2304: Cannot find name 'PromiseConstructor'.
/Users/nathanbackup/Documents/github_projects/angular2-stuff/angular2-seed/node_modules/rxjs/Observable.d.ts(159,54): error TS2304: Cannot find name 'Promise'.

@NathanWalker the gulp build system isn't including typings/main.d.ts since you're not using the files provided in tsconfig

I've been trying to become more knowledgable with typings but I'm a little unclear on what is needed.
The tsconfig.json includes main.d.ts:
"files": [
        "typings/main.d.ts",
        "app/main.ts"
    ],

I'm missing something or don't quite understand what you are hinting at ;)

the problem is more of with the build system not including type definitions rather than typescript. see https://github.com/NathanWalker/angular2-seed/blob/typings/tools/tasks/build.js.dev.ts#L6...L13
and see https://github.com/gdi2290/answers-app/blob/typings/tasks/compile.ts#L7...L12

You're the best @gdi2290 thank you! that gives me a good idea of what I need to do :+1:

this might help too https://gist.github.com/gdi2290/e544407980e261acc172

Thanks, I'll try to clear this today, gotta head out for a bit.
I will say, I find systemjs configuration frustrating at best. webpack is better is this regard but when you get systemjs configured right, it's great.

@gdi2290 One last question with regards to tsconfig.json... It's building out main.js correctly now but nothing else. I thought that since main pulled in AppCmp, it would fork out and build everything from there. Do I really need to add every single .ts file in the files?
"files": [
        "typings/main.d.ts",
        "app/main.ts",
        // everything else here really?
    ],

I tried using just exclude with only node_modules but that didn't work either.

you only need to include the entry files. So files that include other files will be seen by typescript. This might be a problem with tests since they normally don't include other files so much as everything being global

Ok good to know that's what I thought. Unfortunately it doesn't seem to be working that way. The PR is updated with the changes but it only builds out main.js. strange...
Once I solve this here, I should be able to help and solve it on universal as well (if you hadn't gotten to it yet).

This is all fixed up now thanks to the amazing @gdi2290. Dev workflow verified, prod build verified, unit test workflows verified, and e2e all set to go.
The appveyor issue is what's on master already related to beta.1 issue: https://github.com/angular/angular/issues/6501
Please verify and merge @mgechev or @ludohenin when you can, thanks.

@NathanWalker @gdi2290 Awesome, will check that out tonight.

@ludohenin @mgechev I need to fix npm run docs. I'll try to fix that soon and update this PR.

It was a simple fix, updated now :+1:

Thanks! I am on a trip to Malta, coming back on board on Saturday.

Thanks @ludohenin, I'll leave this open for @mgechev to look at as well. I want to make sure he is okay with these changes as well.

Just 2 cents... to typings work behind proxy you need to create a .typingsrc with proxy settings... Already submited a pull to look at http_proxy environment variable too...
Great work Nathan!

@NathanWalker the upgrade of tsd to typings can be merged here https://github.com/mgechev/angular2-seed/pull/420.


Portable interpreter invocation

*BSD does not have /bin/bash.  Use /usr/bin/env bash for portability.

Some notes on these changes:
There are a couple of minor whitespace changes involved here as well.  In particular, a few files didn't have a final \n and opening and saving them on a Unix box added this.  There was one file where I removed trailing whitespace on the last line too.
There are tradeoffs with this approach versus other options I considered.  I'll attempt to enumerate them here.
Use "/usr/bin/env bash" vs "/bin/bash"
Pros

This approach should work on all platforms (standards compliant)
It requires a relatively small number of changes.

Cons

The first instance of 'bash' in PATH is selected, which may not be in the one in /bin and may not even be the Bourne Again Shell (any executable named bash counts).  Note that this is also the feature that allows this to work on *BSD, so it being a con is debatable.
Other code that is downloaded as part of the tests doesn't get this fix.  E.g. the use of getSHA.sh from the OpenJ9 repo is not fixed by this change and will require an upstream change or another approach.

Convert all of the scripts to be POSIX sh compliant
Pros

This approach should work on all platforms (standards compliant)

Cons

This may be a considerable amount of work.  Based on checkbashisms(1), some scripts could already be moved over, but a script like /perf/liberty/scripts/bin/common_utils.sh showed a lot of hits for potential bashisms.
Developers are restricted to POSIX sh features in scripts and can't use bashisms.

*Anyone working on BSD creates a symlink
Pros

Requires no code changes
Will work for other code pulled in by the tests

Cons

Requires root access on *BSD, which is a requirement no other platform has.  This effectively rules out developers who either don't have root access or are unprepared to change their system in this fashion.  This has additional impact in that it complicates onboarding for new *BSD machines for either the project or developers who want to use them.
Symlinks are potentially fragile.  Copying the bash executable could be used to work around this, but there are still potential problems during package or system update for those who might use /bin/bash as a shell once they see it exists.

Overall I thought using /usr/bin/env had the best set of trade offs.

Grinders:
openjdk/xlinux:
https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder_Advanced/390
openjdk/aix:
https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder_Advanced/391
openjdk/osx:
https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder_Advanced/393

See also,
https://github.com/AdoptOpenJDK/stf/pull/67
https://github.com/AdoptOpenJDK/openjdk-systemtest/pull/291
https://github.com/eclipse/openj9/pull/7024

All 3 related PRs are merged, non-BSD grinders passed (to verify existing testing unaffected).  Still waiting on a machine to actually be able to run testing, but can merge now, as it is a benign change from perspective of existing testing.

Thanks Shelley!
I believe @gdams was going to set up FreeBSD builds and mentioned that there are some FreeBSD machines that should be available for this.  I haven't seen him on Slack for a while though.  Maybe he is out of office?

Created https://github.com/AdoptOpenJDK/openjdk-infrastructure/issues/945 to capture the request more formally.  :)


Ensure only failed tests are run with --rerun-failed

What this PR does / why we need it:
This reintroduces the e2e --rerun-failed behaviour which had been
accidentally removed as part of a refactor. As part of reintroducing this
behaviour, it was noticed that the generated rergex for running specific
tests was invalid and would cause a panic when running ginkgo. In the
generated regex, we were double escaping [] characters. This doesn't
seem to be necessary as we do not double escape these characters for
other regexes (e.g. defaultSkipList).
Which issue(s) this PR fixes

Fixes #797

Special notes for your reviewer:
This behaviour was removed in #315. I have verified the fix works manually but I don't know if there is a better way to test this so that is covered under CI. I wasn't sure if it was worth adding another more testing logic to our Travis CI script so I would appreciate any input that you might have.
Release note:
Fixed a bug where the `--rerun-failed` flag for the `e2e` command would run all the tests, not only the failed tests.

So I thought the manual test was going to be a formallity but it actually failed:
+ /usr/local/bin/ginkgo '--focus=\[k8s.io\] Pods should be submitted and removed \[Conformance\]' --skip= --noColor=true /usr/local/bin/e2e.test -- --disable-log-dump --repo-root=/kubernetes --provider=local --report-dir=/tmp/results --kubeconfig=
+ set +x
+ tee /tmp/results/e2e.log
...
...
===================================
Random Seed:<PHONE_NUMBER> - Will randomize all specs
Will run 0 of 3585 specs
...

So the regexp we make there doesn't actually run any specs. Will tinker for a bit on this and get back to you.

Oh, that's disappointing :( I wonder if the . in the test name prefix is impacting it and also needs to be escaped. I think the test case that I tried it with had the prefix [sig-apps].

So actually I am now frustrated and relieved :)
I think it works fine. I do think that the . could be escaped but it isn't probably going to change any selection. I would worry about some more generic problems though and think it would be wise to go ahead and use https://golang.org/pkg/regexp/#QuoteMeta instead of our own, simple replacer.
The problem I ran into was that to test this I grabbed a random tarball, forced a failure in the log, then tried to rerun it. The issue was that the test name for the test changed between that [older] tarball and the tests that run against my cluster. So it legitimately didn't match any test. No fundamental problem.

Codecov Report

Merging #801 into master will increase coverage by 0.03%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master     #801      +/-   ##
==========================================
+ Coverage   42.79%   42.83%   +0.03%
==========================================
  Files          71       71
  Lines        4229     4200      -29
==========================================
- Hits         1810     1799      -11
+ Misses       2311     2294      -17
+ Partials      108      107       -1

Impacted Files
Coverage Δ

cmd/sonobuoy/app/e2e.go
21.21% <0%> (-0.67%)
:arrow_down:

pkg/client/e2e.go
89.74% <100%> (+15.38%)
:arrow_up:

pkg/discovery/discovery.go
0% <0%> (-5.09%)
:arrow_down:

cmd/sonobuoy/app/status.go
57.14% <0%> (-2.2%)
:arrow_down:

cmd/sonobuoy/app/gen.go
51.93% <0%> (-2.14%)
:arrow_down:

pkg/config/config.go
58.62% <0%> (-2.04%)
:arrow_down:

pkg/discovery/pods.go
0% <0%> (ø)
:arrow_up:

pkg/discovery/queries.go
14.11% <0%> (+0.16%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 700ac79...093fd28. Read the comment docs.


docs: document how to add OAuth with OauthProxy in front of Capacitor

Hello @evandam thanks for your question.
The tldr is that we are investigating the how, and over time this will land in Capacitor.
This question popped up on Kubecon a couple of times, and you summarized it perfectly for Github.
To respect Kubernetes RBAC in Capacitor we need to do two things:

We need to be certain about the user's identity
We need to impersonate the user in our Kubernetes API calls.

An alternative to Kubernetes RBAC would be Capacitor's own RBAC, but it is considered as a subpar option.
We need to be certain about the user's identity
This needs some investigation, but either we integrate with auth systems like OIDC (maybe more?), or we utilize something like oauth2-proxy and that will forward the authenticated identity to Capacitor.
Then we need to impersonate the user in our Kubernetes API calls. This is fairly understood how it can be done with client-go. Here is a codesample on how Weave did it: https://github.com/weaveworks/weave-gitops/blob/2af6d1133a5717fc3b0f367734443557074b1548/pkg/kube/config_getter.go#L74
If we ever cache API responses and share them between users, the client-go equivalent of kubectl auth can-i feature can help us filtering the cached results and prevent privilege escalation.
https://stackoverflow.com/questions/66994829/how-to-make-impersonate-work-with-kubernetes-go-client

@laszlocph , nice project, also landed here from weave-gitops.
I would second @evandam on this and vote for this nice feature (if users could only see the flux resources to what they have access to).
However, I would like to drop in the fact that weave-gitops did not implement this properly as for their implementation the users had to have access to flux-system (see this ticket for more details).
Flux has a multi-tenancy deployment model that is considered best practice from security point of view when you have multiple teams using the platform. Implementing something that supports that model sounds like the right way to go.

For what it's worth, I thought having Dex do the heavy lifting for OIDC and even controlling access (required GitHub org, groups, etc.) was a really good way to handle it, without weighing down the GitOps/Capacitor configuration and code base (I'm assuming).

@laszlocph do you think we should create a new ticket about this request? By now, this seems like way more than just a documentation issue... (and possibly not good for a first issue)

I've done this in the past with some toy applications. It generally boils down to:

Authenticate the user using the same OIDC provider as Kubernetes itself
Extract impersonation information from the OAuth token claims
Proxy requests to the Kubernetes API and inject impersonation headers

Doing this, all authentication is deferred to Kubernetes/OIDC provider and Capacitor doesn't need to much.
I'd be happy to take a shot at it if you'd like.

Hello everyone!
@django1194 do you have any updates here?


PUT requests should replace and not update current definitions

Breaking API Change
Currently, the PUT app updates only fields in the AppDefinition which are explicitly set.
This does not correspond to the conventional usage of PUT (it corresponds more to PATCH) and can lead to surprises.
It is not possible for example, to switch an AppDefinition from using "cmd" to using "args" because it is not possible to remove an attribute from an AppDefinition without DELETEing it before that.
It also means that you have to be generally more careful about your group/app definitions since you have to think about your old definitions and thus depends on your upgrade path. It might work in you staging environment and fail in production because of a different prior state.

Compatible alternative in #1418


Getting remote: HTTP Basic: Access denied\nfatal: Authentication failed for repository with deploy token

Repro steps.

your project built successfully on your dev machine but failed on Azure? Yes
It is a django project in python, and Kudu engine is used to deploy from external source.

Project structures.

I have a python django project on Gitlab and followed exact steps to setup external repository with deploy token taken from kudu server.

The log/error given by the failure.

Normally this include a stack trace, error code and some more information.
While syncing or deploying the app, it fails while fetching from remote repo.
Getting remote: HTTP Basic: Access denied\nfatal: Authentication failed for repository with deploy token

Debug your Azure website remotely.

After logging into kudu server, I confirmed that public key matches the deploy key added on external repository.
I also tried to run 'git fetch' and faced the same error. I tried to change config but it needs superuser.

Please help to fix the authentication issue!

Did the deployment log details show what cred being used?  For deploy key/private repo hint, Kudu supposes to use SSH not basic auth over http.


Auto Create Table defines the Exception column as NOT NULL

Standing up a Core 2 app with all the latest bits from Nuget (Serilog, MSSSQL Sink, Seq sink, etc).  Could not discover why the table would be created yet we could not write data to the table.  After turning on Self log, discovered that it kept throwing a "Cannot write null value to the exception column" error.  Looked at the table definition and this is how it was  defined:
CREATE TABLE [dbo].[ReferralsAzureAuth](
[Id] [INT] IDENTITY(1,1) NOT NULL,
[Message] NVARCHAR NOT NULL,
[MessageTemplate] NVARCHAR NOT NULL,
[Level] NVARCHAR NOT NULL,
[TimeStamp] [DATETIME] NOT NULL,
[Exception] NVARCHAR NOT NULL,   <----------
[Properties] NVARCHAR NOT NULL,
CONSTRAINT [PK_ReferralsAzureAuth] PRIMARY KEY CLUSTERED
(
[Id] ASC
)WITH (STATISTICS_NORECOMPUTE = OFF, IGNORE_DUP_KEY = OFF) ON [PRIMARY]
) ON [PRIMARY] TEXTIMAGE_ON [PRIMARY]
GO
Is there a correct way to do this?  Currently, I am using SQL Server's built in script function to DROP/CREATE the table (after Serilog makes it), edit the column to NULL, then run the script.  Quite painful when we have 6 apps and each app can be run in 6 environments...

Hi,
I attempted to recreate the behaviour using the methods below:

Integration test with direct call to

// arrange
var options = new ColumnOptions();
var standardNames = new List<string> { "Message", "MessageTemplate", "Level", "TimeStamp", "Exception", "Properties" };

// act
var logTableName = $"{DatabaseFixture.LogTableName}DefaultStandard";
var sink = new MSSqlServerSink(DatabaseFixture.LogEventsConnectionString, logTableName, 1, TimeSpan.FromSeconds(1), null, true, options);

Integration test as well as a console app running on .NET Core 2.1.302

var loggerConfiguration = new LoggerConfiguration();
Log.Logger = loggerConfiguration.WriteTo.MSSqlServer(
   	connectionString: DatabaseFixture.LogEventsConnectionString,
   	tableName: DatabaseFixture.LogTableName,
   	autoCreateSqlTable: true)
   .CreateLogger();

All the tests used the LocalDB and the code in the current development branch. In all cases, the table is created with a nullable Exception column.
Could you kindly provide more infromation and/or a sample project to assist us locate the issue please?

The default is to allow nulls.
.NET Framework XML config here
Microsoft.Extensions.Setting config here

@KeithBarrows can you post code and config that reproduces this?

Closing, can't reproduce. If @KeithBarrows can reproduce this, we can re-open it.


cblas3 and zblas3 tests are failing on Broadwell and Skylake with GCC 11.1.0

I have tried building OpenBLAS v. 0.3.15 on my workstation with Intel Xeon E5-2687W v4 and GCC-11.1.0 and some of the tests, namely cblas3 and zblas3 seem to be failing with a completely wrong result. This is reproducible also on my Skylake i7 CPU at home. The error looks like this:
OMP_NUM_THREADS=2 ./xzcblat3 < zin3
TESTS OF THE COMPLEX*16 LEVEL 3 BLAS

THE FOLLOWING PARAMETER VALUES WILL BE USED:
FOR N 0 1 2 3 5 9 35
FOR ALPHA ( 0.0, 0.0) ( 1.0, 0.0) ( 0.7,-0.9)
FOR BETA ( 0.0, 0.0) ( 1.0, 0.0) ( 1.3,-1.1)

ROUTINES PASS COMPUTATIONAL TESTS IF TEST RATIO IS LESS THAN 16.00

COLUMN-MAJOR AND ROW-MAJOR DATA LAYOUTS ARE TESTED

RELATIVE MACHINE PRECISION IS TAKEN TO BE 2.2E-16

cblas_zgemm PASSED THE TESTS OF ERROR-EXITS

******* FATAL ERROR - COMPUTED RESULT IS LESS THAN HALF ACCURATE *******
EXPECTED RESULT COMPUTED RESULT
1 ( 0.495928E-01, 0.197144 ) ( -0.176908 , -0.293573E-01)
2 ( -0.154221 , -0.169237 ) ( 0.179134 , 0.164118 )
******* cblas_zgemm FAILED ON CALL NUMBER:
8644: cblas_zgemm ( CblasColMajor,CblasConjTrans, CblasNoTrans,
2, 1, 1, ( 1.0, 0.0) , A, 2, B, 2, ( 0.0, 0.0) , C, 3).
******* cblas_zgemm FAILED ON CALL NUMBER:
4537: cblas_zgemm ( CblasRowMajor, CblasNoTrans, CblasNoTrans,
1, 1, 0, ( 0.0, 0.0) , A, 2, B, 1, ( 0.0, 0.0) , C, 2)

Both should be the same cpu target (Haswell) as far as OpenBLAS is concerned. I cannot reproduce this with either gcc 10.2 or a recent snapshot of gcc12 right away, will need to install 11.1 to check. Can you please make sure that gcc and gfortran are the same version, and the cpu firmware is reasonably current ?

Not reproduced on i7-8700K with gcc-11.1 and either 0.3.15 or current develop branch.

Did you specify any non-default build options ? Also, one possible pitfall when using a non-default installation of gcc on a system is that while gcc may already point to the "new" compiler, cc still invokes the system compiler. One can use the CC argument to make/cmake to specify which compiler to use (as in make CC=gcc or make CC=/opt/gcc11/bin/gcc etc).

Somewhat disconcerting. but not reproducible on my systems even after repeated compiles (tried both gmake and cmake builds)

I have the same test errors on gcc11

What is your hardware @cyyever ? (OS is some BSD if I remember correctly)

archlinux + gcc11
cpu is (fetchted from Windows)
Caption                                 DeviceID  MaxClockSpeed  Name                                      NumberOfCores  Status
Intel64 Family 6 Model 158 Stepping 10  CPU0      2592           Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz  6              OK

Just in case, for me everything works fine as long as I do not use GCC 11, e.g. GCC 10.x works perfectly fine for me.

Saw this now with current develop and a gcc11.1 built from source, but only when building with cmake and setting CMAKE_BUILD_TYPE=Release, could be some kind of compiler option mixup in the cmake build files.

As build type "Release" selects -O3 rather than the more conservative -O2 used in gmake builds, this is possibly "just" an optimizer bug in 11.1, or in any case something that could be worked around with a #pragma GCC optimize "O2" in the affected file(s)

Interestingly it appears to be the ctest3 and ztest3 programs themselves that fail when compiled at -O3 by gcc 11.1 or a development snapshot of 12.

Problem goes away with adding !GCC$ novector directives to the loops that calculate the reference values in both tests. (Unfortunately this directive is not known to older versions of gfortran and treated as an error by at least  v7.5.0)

-fno-tree-vectorize achieves the same and is understood by older versions. Still need to trim this down to something that can serve as a reproducer for a gcc bug report

Possibly GCC bug 10125 which just got fixed with GCC 11.2


[DropdownMenu] First menu item is selected when trigger is clicked on mobile device

Bug report
Current Behavior
If user clicks bottom part of trigger button then menu content flashes on screen and first item is selected.
This issue is at least present on Android 12 with Firefox 103.2.0. It can be also reproduced on desktop version of Chrome (Version 104.0.5112.79, macOS 12.5) when mobile device simulation is on (dev tools).

Expected behavior
If user clicks bottom part of trigger button it should just open the menu content.
Reproducible example
https://www.radix-ui.com/docs/primitives/components/dropdown-menu
Suggested solution

Additional context

Your environment

Software
Name(s)
Version

Radix Package(s)
@radix-ui/react-dropdown-menu
1.0.0

Browser
Firefox
103.2.0

Operating System
Android
12

I can confirm this is an issue on touch devices, including iOS.
I think this will be addressed by #657 as we do in Select.

I can't reproduce this on Android or emulation on desktop, I assume this is fixed and can be closed?


bgfx::CallbackI::screenshot callback never gets called on MacOS Metal

requesting a screenshot with bgfx::requestScreenshot, does not trigger a screenshot callback on MacOS Metal.
Looking at the code, the issue seems to be with m_saveScreenshot, which is set to true only in requestScreenShotPre, method that is used nowhere.
Forcing a reset with BGFX_RESET_CAPTURE, triggers the screenshot callback, because m_capture is not NULL anymore, but requestScreenshot should work without BGFX_RESET_CAPTURE.

requestScreenshot can be used to get the content of a window's backbuffer.
On Metal this is CAMetalLayer's nextdrawable's texture. By default it has a property of framebufferOnly. This means we cannot get data from it. (We cannot even copy it to other texture like other renderers do) https://developer.apple.com/documentation/metal/mtltexture/1515749-framebufferonly?language=objc
Possible solutions:

We can override this behaviour, but the docs suggest it will have a performance penalty. I haven't benchmarked how severe it is. But always paying the extra cost is not the best solution. I think we can enable this only for frames where it is needed, but we should know about the requestScreenshot request at the beginning of the frame to set it.
https://developer.apple.com/documentation/quartzcore/cametallayer/1478168-framebufferonly?language=objc

Another solution to render an ordinary rendertarget texture that has similar properties to back buffer, get data from this texture and copy content with submitQuad to backbuffer. (This is implemented right now, but missing msaa and multiple window support)
This also needs info at the before renderer::submit to handle rendering to the temp buffer instead of backbuffer.

So both method has an extra performance penalty for rendering. We should only pay for this extra cost for frames where it is needed.
To test this feature I think it would be beneficial to add a request screenshot feature to 22-windows as it is the only example that has multiple windows.
@bkaradzic

@attilaz Yes, we can change CommandBuffer::RequestScreenShot command to be pre-submit command (for all renderers), which whould just cache values, and then it would get executed after rendering. This way you would be able to switch Metal into mode to capture screenshot.

also, another thing that I've noticed:
because requestScreenshot hadn't worked, I tried readTexture. This one worked only on macs with intel only gpus. Using a mac with hybrid gpus (intel with shared memory and amd with dedicated memory), readTexture returned only empty buffers.

@bkaradzic "cache values" means storing every requestScreenShot param pairs (fb handle, filename) in an array in every renderer then process at the end of submit? This seems too much change inside every other renderers.
How about requestScreenShot() generating two commands, for example adding a pre-submit requestScreenShotPrepare(fb). Other renderers could just ignore this.
@georged-youi
I don't have access to mac with dedicated gpu, so I won't be able to check that. Does metal validation give any error?
Matbe we are missing synchronization.
https://developer.apple.com/documentation/metal/mtlblitcommandencoder/1400757-synchronizetexture?language=objc
Can you try replacing renderer_mtl.mm's readTexture with this? https://gist.github.com/attilaz/3cabb555457949099ac611895fb7ee90

@attilaz, yes, the new code allows me to successfully read textures on mac with dedicated gpu.

@attilaz

This seems too much change inside every other renderers.

I think it should be only 1 request per frame buffer. And way how it works right now it would generate multiple requests. I'll make change to all renderers and then you can fix Metal.

@bkaradzic  great, thanks!
@georged-youi great! I will test it on my setup, and if I find no problem will send PR.

Is there anything missing to be able to fix this? From what I understand from the above, adding a "pre" frame operation will allow us to detect if we're going to request a screenshot or not, then do whatever magic Metal needs to be able to read from its texture, but not sure if there is anything else that requires changing.

@bkaradzic @attilaz can any of you offer any guidance on how to fix this? I don't mind opening a PR for it but I need to know where to start, I really need to get this working reliably, screenshots are not optional for my project.
Thanks again.

Lastest commit bgfx::CallbackI::screenshot callback gets called , but the data is empty。See example-07-callback

I have just tested the latest bgfx version on macos (metal renderer) and the 'screenShot' callback function was called with proper data and tga/png images was succesfully saved.
@klob Are  you seeing this with metal renderer? Other parameters are missing too, or only the data is null?

Hi, in relation with this discussion I'm trying to subvert the capture() functions to do what I want, but I ran in the problem that enabling capture (using BGFX_RESET_CAPTURE or requesting a screenshot) breaks the "windows" example (I copied in it the callback class from the "callback" example).
What happens is that the content of all windows gets drawn in the main window (that is captured), and that the secondary windows becomes black. I've tracked it to what happens in setFrameBuffer() when m_screenshotTarget exists, and noticed that requestScreenShot() doesn't use the FrameBufferHandle argument like in other renderers but I'm a bit stuck.


[Scenario] Acaso dos Deuses Antigos - PRÓLOGO

What kind of mission do you want to add (mark with an X, e.g. [X] Descent)?

[X] Mansions of Madness
[ ] Descent

Please enter the GitHub Url to your scenario here
https://github.com/malkavk/AcasoDosDeusesAntigos-PROLOGO

I've added this


Make export pipeline logs more readable

Silences output of gdal calls in favor of tqdm, making logs much more readable.
In the logs there was a constant warning:
Warning 1: General options of gdal_translate make the COPY_SRC_OVERVIEWS creation option ineffective as they hide the overviews

I have removed this option in this MR, but it should be investigated if that is really the way to go. Link to cogification docs

Not much to review, the changes make sense to me. One question, should this be parametrizable via the pipeline? I guess not, but just wanted to point it out anyway.

i was thinking about it, but I didn't see much point in keeping the old logs. Also not having them silenced breaks the tqdm

I talked to the GDAL wizards and they informed me that we are idiots (which we knew) and are using a cogification method for old GDAL and/or planar tiffs, which are not suitable for us (which we didn't know).
So i switched to the recommended way of cogification for newer GDAL versions.

So i switched to the recommended way of cogification for newer GDAL versions.

Did you check if the GDAL version used is the appropriate one?

I remembered about one more potential issue. if you're using deflate compression with Float32 values, you should set the predictor to 3
from docs:

NOTE: for many types of data adding a predictor can further reduce the file size. It is best you test this on your own data. To enable the predictor, add to the above command -co PREDICTOR=2 for integers, and -co PREDICTOR=3 for floating points.

So i switched to the recommended way of cogification for newer GDAL versions.

Did you check if the GDAL version used is the appropriate one? Should be GDAL 3.1 or newer.

GDAL 3.1 was released in 2020. Do you think we need to check the version and raise an exception if the GDAL version is older than that?

I remembered about one more potential issue. if you're using deflate compression with Float32 values, you should set the predictor to 3

Hmmm, at this point perhaps the utility functions should have a is_discrete flag which then sets these parameters accordingly :thinking:

GDAL 3.1 was released in 2020. Do you think we need to check the version and raise an exception if the GDAL version is older than that?

It might make sense, because older versions of GDAL had some mismatch issues where the resulting tiff could contain an offset. Not sure how relevant it is due to it being released in 2020, but I imagine it could happen..
Some more info I remember from https://git.sinergise.com/sentinel-core/java/-/issues/1400

Hmmm, at this point perhaps the utility functions should have a is_discrete flag which then sets these parameters accordingly 🤔

What if we use the dtype parameter for this, since it's limited to ["int8", "int16", "uint8", "uint16", "float32"]? This way if the user provides float32 (or if float32 is recognized automatically), then the predictor 3 would be used. I would assume if the inputs are 1.0, 2.0, 3.0, ... the user would provide dtype int8 use integers.

What if we use the dtype parameter for this, since it's limited to ["int8", "int16", "uint8", "uint16", "float32"]? This way if the user provides float32 (or if float32 is recognized automatically), then the predictor 3 would be used. I would assume if the inputs are 1.0, 2.0, 3.0, ... the user would provide dtype int8 use integers.

how in the absolute hell did i miss that i have dtype at my disposal....


Currently ignoring custom dateFormatters when creating dictionaries

If a user explicitly provides a dateFormatter, I think you want to use it.
Looks like a simple typo.
Let me know if I am missing something. I needed to generate ISO8601 date strings to send to a service and I think line of code was tripping me up.
Thanks,
-Luther

Good catch, thanks


Allow null employment type for applicants

The employed attribute is not always present when submitting applicant data to CFE.
This led to this
bug.
The updates the applicant schema to allow null types.

Closing in favour of #1173


Fixed #9762 -- Made DateFormat.r() locale-independent.

Thanks to Antonio Melé for the original report all those years ago
and to all the contributors who helped along the way.
ticket-9762

@bmispelon Thanks again :+1: I pushed minor edits.

Excellent, thanks :+1: `
Is there a particular reason why you went with if type(self.data) is datetime.date instead of if isinstance(self.data, datetime.date)?

Yes, because datetime.datetime() is an instance of datetime.date.

Oh, I hadn't thought of that :man_facepalming:


This should show an example on how to use variables in condition

something along the lines of
condition: eq(variables['Build.Reason'], 'PullRequest');

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: dd7e0bd3-1f7d-d7b6-cc72-5ef63c31b46a
Version Independent ID: dae87abd-b73d-9120-bcdb-6097d4b40f2a
Content: Define variables - Azure Pipelines
Content Source: docs/pipelines/process/variables.md
Product: devops
Technology: devops-cicd-process
GitHub Login: @juliakm
Microsoft Alias: jukullam

@trajano There are examples in the expressions article. I'll add some links to it from the variables article to make the connection clearer.


Default scripts type should be "text/javascript"

For the sake of being compatible with different browsers the default scripts type should be "text/javascript", not "application/javascript"
https://github.com/thegorgon/sinatra-sprockets/blob/master/lib/sinatra/sprockets/helpers.rb#L65
Please consider, I just wasted an hour and a half figuring this out today, but I was able to fix right away by adding the type option to my include_tag, so thanks for that at least.
P.s. Otherwise this has been awesome for some small projects I'm working on, cheers.

+1 . any update on this?  this would really be awesome


[Cosmos] add logic for parallelizing asynchronous queries

We are in general missing parallelization/ concurrent logic for executing document producers on the async side that could be leveraged to improve performance at the cost of more RU/s being consumed.
We would need a way to expose configuration settings to our users for them to decide on how parallelized a query should be depending on the performance/cost they are looking for.

Exposing a new kwarg on the async query methods
Syncing with other SDKs on default behaviors/ limits

We would need some solid benchmarking of before/after to get an idea of ratios, improvements, and any additional relevant info.

@tvaron3 - please take a look at this!


Can't run prisma generate on Ubuntu 22.04

Bug description
> Downloading Prisma engines for Node-API for debian-openssl-3.0.x [                    ] 0%
Error: Not Found https://binaries.prisma.sh/all_commits/bcc2ff906db47790ee902e7bbc76d7ffb1893009/debian-openssl-3.0.x/libquery_engine.so.node.gz

How to reproduce

running prisma generate

Expected behavior
No response
Prisma information

generator client {
  provider        = "prisma-client-js"
  previewFeatures = ["mongoDb"]
}

datasource db {
  provider = "mongodb"
  url      = env("MONGODB_URL")
}

model credentials {
  id String @id @default(auto()) @map("_id") @db.ObjectId
  token String
  adnetwork String
}

model statistics {
  id String @id @default(auto()) @map("_id") @db.ObjectId
  date String
  impression Int
  revenue Float
  cpm Float
  adnetwork String
  lastupdate Int
}

Environment & setup

OS: PopOS 22.04
Database: MongoDB
Node.js version: v16.14.2

Prisma Version
prisma                  : 3.13.0
@prisma/client          : 3.9.2
Current platform        : debian-openssl-3.0.x
Query Engine (Node-API) : libquery-engine efdf9b1183dddfd4258cd181a72125755215ab7b (at<EMAIL_ADDRESS>Migration Engine        : migration-engine-cli efdf9b1183dddfd4258cd181a72125755215ab7b (at<EMAIL_ADDRESS>Introspection Engine    : introspection-core efdf9b1183dddfd4258cd181a72125755215ab7b (at<EMAIL_ADDRESS>Format Binary           : prisma-fmt efdf9b1183dddfd4258cd181a72125755215ab7b (at<EMAIL_ADDRESS>Default Engines Hash    : efdf9b1183dddfd4258cd181a72125755215ab7b
Studio                  : 0.459.0
Preview Features        : mongoDb

You need to update both Prisma CLI and Prisma Client to 3.13.0 - then it will work.

@janpio thank you!

still dosen't work. I get a new Error
Unable to establish a connection to query-engine-node-api library
i used the starter project only changed the version from 3.12 to 3.13

Please open a new bug issue and provide all the information it asks for. Thanks.

You need to update both Prisma CLI and Prisma Client to 3.13.0 - then it will work.

This solved for me


Thanks to @olblak for redirect reviews!

@olblak helped us with redirects
Links

https://github.com/jenkins-infra/jenkins-infra/pulls?q=is%3Apr+is%3Aclosed

Screenshots
Please add screenshots if relevant.
If they are already linked from the pull request, no need to duplicate

Thanks for your contribution!
@all-contributors please add @olblak for documentation and reviews


Tags break sources in the lineage view

From Slack
Given an example source configured with a tag:
version: 2
sources:
  - name: myproject
    tags:
      - mytag
    tables:
      - name: mytable

The source is not rendered in the lineage DAG. Removing the mytag tag fixes the issue.

Also just ran into this issue setting up a bunch of tags for sources!

Hey @drewbanin I'm looking to spend some time today and tomorrow trying to fix this issue. Any pointers on where to get started? Full disclosure, don't have much experience with front end stuff in general so treating this as a learning opportunity...


Can't direct Headlamp to retrieve metrics on a sub-path of a Prometheus(-like) query service

Hi,
In my cluster(s) I deploy VictoriaMetrics stack (a Prometheus equivalent) which exposes an endpoint for querying metrics using Prometheus-compatible API on a sub-path within the HTTP Service. In Lens, for example, I specify the following to display metrics:
vmstack/vmselect-vmstack-victoria-metrics-k8s-stack:8481//select/0/prometheus
Trying to enter such string into the Headlamp setting called "Prometheus Service Address", it displays an error below the field:
Invalid format. Use: namespace/service-name:port
If I just enter this:
vmstack/vmselect-vmstack-victoria-metrics-k8s-stack:8481
...it of course doesn't work.
Would it be possible to enable specifying the sub-path in this field too?

Same here
I saw headlamp is using this plugin for that. One can either tweak the code somehow to make VictoriaMetrics scraped
Or ...open this exact same issue report over the plugin repo

At the end, everything is just a question of time !

cc/ @yolossn ^


pull request for e2e test at 12/11/2016 10:26:02

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Readme. Parse AST back to JSX

The readme mentions parsing JSX to an AST, but can it parse AST back to JSX?
Is there additional documentation anywhere? The readme is pretty sparse.

@Seanmclem did you find a way to do this? I'm looking to do this myself

@Seanmclem did you find a way to do this? I'm looking to do this myself

I ended up using babel to parse. I'm add some code samples momentarily


[Bug Report]: Profile avatar cannot update

Describe the Bug

When I edit the profile, the button select image is just not working, no error showing in the console tab
This is happening on the newest release, the demo site also got the same issue
Steps to Reproduce

Login
Click on user name -> edit profile
Scroll down to Avatar setting, click on select image

Expected Behaviour
Should prompt the select file window to select a new avatar
Screenshots or Additional Context
No response
Exact BookStack Version
next version
PHP Version
No response
Hosting Environment
Ubuntu 18

Hi @phucnguyenvn,
The button is showing the file picker for me, I'm on Firefox 96 on fedora 35, tested on the demo site.

What operating system and browser version are you using?
Does it still occur in a private/incognito window (Or other browser).
Does clicking the "Click Me" box on this page show the filepicker?

hi @ssddanbrown the click me not showing on my side. I'm using Google Chrome Version 97.0.4692.99 (Official Build) (x86_64)

@phucnguyenvn Just tested on Chrome (Version 97.0.4692.99 (Official Build) (64-bit)) on fedora 35 and seems to work for me.
The method used to show the filepicker, in both bookstack and the example above, are quite simplistic usages of html functionality, there's no custom script going on. I'd question if there's something wrong with your instance of chrome.

As above, what operating system are you using (to run chrome)?
Does it still occur in a private/incognito window (Or other browser).

@ssddanbrown I'm using MacOS Monterey, following your test I just make a restart for the whole system, now it's working without any issue. Let me close this bug. Really appreciate your help!!

Cool, thanks for confirming, glad we found the answer!


[Azure Monitor OpenTelemetry] Add MeterProvider and LoggerProvider as global

Packages impacted by this PR
@azure/monitor-opentelemetry
Fixed issue of OTLP exporter enabled even if configured off
Fixed issue of Logs not being flush when client was flushed

API change check
API changes are not detected in this pull request.


Desktop and Web support

What would need to go into adding Desktop and Web support to this?
It looks like the platform specific code is only for cryptography. Would it be possible to use the cryptography instead, which supports Web and Desktop already?
That package supports both X25519 and AES-CTR (used by esp_prov according to docs. These are implemented in Dart, not native like this package. However, I don't believe there would be any noticeable difference in performance, as we are not sending many messages.

I've managed to make it work on Web and Linux Desktop. It probably works on Windows too, but I don't use that for development. I've made a few hacky workarounds, once these are ironed out, I'll send a PR.
https://github.com/Barabas5532/esp_softap_provisioning/tree/feature/web-support

Hi @Barabas5532,
Sorry for the late reply. It's been busy weeks. I already use the cryptography library, its version is 2.0.1(not the latest). I've seen your PRs. Let me check.


Using HOC as ES7 decorator causing error "Property .. is incompatible"

Here is example from manual https://flow.org/en/docs/react/hoc/#toc-injecting-props-with-a-higher-order-component. Default example works without errors, however rewritten version using ES7 decorator syntax produces error below:
/* @flow */
import * as React from 'react';

function injectProp<Props: {}>(
  Component: React.ComponentType<{ foo: number } & Props>,
): React.ComponentType<Props> {
  return function WrapperComponent(props: Props) {
    return <Component {...props} foo={42} />;
  };
}

@injectProp
class MyEnhancedComponent extends React.Component<{
  a: number,
  b: number,
  foo: number,
}> {}

<MyEnhancedComponent a={1} b={2} />;

As result I'm getting:
Flow: props of React element `MyEnhancedComponent`.
This type is incompatible with object type  Property `foo` is incompatible: property `foo`.
Property not found in props of React element `MyEnhancedComponent`

Is there a way to fix this error and keep ES7 decorator syntax in place?

Getting this too

Decorators are not well supported. Even in the latest proposal in stage 3, it's only supported for class members.


Dismiss all when stacking modals

Will there be a way to dismiss the whole stack of modals at the same time when the close button is clicked on, rather than popping each and every modal off the stack?
Thank you so much for your work on this lib and sharing it!

Sorry, I think I have the answer closeAllModals()? https://github.com/mattjennings/react-modal-stack

Yup, closeAllModals is the way to do it!


chore: revisit system data contracts

Issue being fixed or feature implemented

We need to ensure that our system data contracts are up to date with the recent version of Drive and that there are no problems or mistakes.
What was done?

Dashpay:

Ensure that at least one of the profile fields is present (according to the DIP14)
Ensure all three avatarUrl, avatarHash and avatarFingerprint are present or non of them
Switch to system $createdAtCoreBlockHeight instead of user-based

DPNS:

Switched to mutability options instead of data triggers
Added $createdAt and $updatedAt for the domain document type

Masternode reward shares:

Removed duplicated index

Withdrawals:

Prevented creation of the withdrawal documents with document config

How Has This Been Tested?

Updated dashpay contract tests
Added additional tests for dashpay queries to validate indexes
Added query tests for masternode reward shares

Breaking Changes

Dashpay and DPNS contracts and their validation logic has changed so previously created blockchain data is not valid.
Checklist:

[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have added or updated relevant unit/integration/functional/e2e tests
[x] I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
[x] I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

[x] I have assigned this pull request to a milestone

We should add "$transferredAt" for DPNS domain


Respect @static fingerprint in deploys

Architect allows for automatic static asset fingerprinting with @static fingerprint. We should support this in Begin!

/cc @andyweiss1982

Good news, Begin now supports both fingerprinting and can be configured to respect 3rd party framework fingerprinting, too! Docs here: https://docs.begin.com/en/static-assets/working-with-static-assets
Try it out and let me know what y'all thing!


Judge bugs

Fix one bug here and added Python3 submission support. The bug was that over a network (with a delay), sorting the problems in the judge controller would break because the problems may not have existed yet.

Cool sauce, looks great.


Use CaseInsensitiveString for Headers

Re: #136
Following the discussion in the above issue, this converts from Object String to Map CaseInsensitiveString String. Let me know if anything should be done differently.
Also addresses part of #113.

CI is broken right now, I need to fix it, so please ignore the failures... sorry about that!

@joneshf Sweet!  This is really great, thanks a bunch!
Just one question, I don't think there's any value any more in making Headers a newtype.  The only reason it was originally a newtype was so that it could have an instance of Lookup that did case-insensitive lookup, but now that Headers is a Map CaseInsensitiveString String there's no reason to have a unique instance.  Thoughts?

Sounds good to me.

Eh, most of the tests in Test.HTTPure.HeadersSpec will break:
1) HTTPure Headers show is a string representing the headers in HTTP format
  "(fromFoldable [(Tuple (CaseInsensitiveString \"Test1\") \"1\"),(Tuple (CaseInsensitiveString \"Test2\") \"2\")])" ≠ "Test1: 1\nTest2: 2\n\n"
2) HTTPure Headers append when there is a duplicated key uses the last appended value
  (fromFoldable [(Tuple (CaseInsensitiveString "Test") "foo")]) ≠ (fromFoldable [(Tuple (CaseInsensitiveString "Test") "bar")])
3) HTTPure Headers empty is an empty Map in an empty Headers
  "(fromFoldable [])" ≠ "\n"
4) HTTPure Headers header creates a singleton Headers
  "(fromFoldable [(Tuple (CaseInsensitiveString \"X-Test\") \"test\")])" ≠ "X-Test: test\n\n"
5) HTTPure Integration runs the middleware example
  "middleware" ≠ "router"

Some of this is the different behavior of Show and others are different behavior for Semigroup. Still worth it.

Ah, right. I'd forgotten about those differences. Thank you for checking it out!

Still worth it.

Sorry, this was supposed to be, "Still worth it?"

I think that we could clean up these APIs a bit and get rid of the newtype, but I think it's out of scope for this change.  So let's go ahead and merge this and I'll add a separate ticket to remove the newtype.


HLS stream crashes iPhone 14 Pro Max

What do you want to do with Clappr?
Hello, I am trying to find out if anyone else has had issues with iPhone 14.
Our hls stream using Clappr player has worked flawlessly for a long time...
But now, it crashes the iPhone 14 Pro Max.
When you click the link to view our hls stream.
The whole phone turns off.
Has anyone reported any issues like this?
What have you tried so far?
We have tried testing on multiple devices.
The only phone that crashes is the iPhone 14 Pro Max.
Thanks for your time.

Hi @cviewsupport , it still crashing?
We just release a new version of @clappr/hlsjs-playback. Maybe testing the new version it solves your problem.

Closing this issue due to inactivity.


Add a way to config Hmr Error Overlay ignore some error.

Changes

Some time we when to ignore some error when use Hmr Error Overlay. Such as error: [ResizeObserver loop limit exceeded] (https://stackoverflow.com/questions/49384120/resizeobserver-loop-limit-exceeded).
Learn from Sentry, https://blog.sentry.io/2017/03/27/tips-for-reducing-javascript-error-noise#ignore-troublesome-errors, I add window.snowpackHmrErrorOverlayIgnoreErrors to do it.
Code: https://github.com/snowpackjs/snowpack/pull/2363/files#diff-a469e5beb7b6062baa2325f61e5d5e73a94c17767fa166a42ef32920dca89e0aR239
Testing

No need update test case, need test it manually.
Docs

TODO, may be explain this in here: https://www.snowpack.dev/reference/configuration#devoptions.hmrerroroverlay

I just found this feature and used it as a workaround for an uncatchable deterministic error: https://github.com/cubing/cubing.js/commit/dd1006a37ebda7d0cfa97c3df54f999068fe59c6
Is this meant to be a proper supported feature / should there be any documentation or tests for it? Or is it "best effort" for folks like us who just need a workaround?


Where is the action_names_XXX.txt?

Hi, I want to run generation on chi3d test set, but I can not find the action_names_XXX.txt which is for "action_file" arg. Can you provide some help for me to get it?

Sorry for the late reply. The action files are already uploaded.


Error in the file /data/log/serial-starter/current

Describe the bug
@4000000061d721bc1b35b89c *** starting serial-starter ***
@4000000061d721bd0653fccc find: /service/dbus-serialbattery/service/service/service/.../service/: Too many levels of symbolic links
To Reproduce
Steps to reproduce the behavior:

Install v0.10 release
Connect FT232R to USB port, restart Raspberry Pi
Open file /data/log/serial-starter/current
See error

Expected behavior
There should not be an endless nesting of service folders
Screenshots
see above "Describe the bug"
VenusOS (please complete the following information):

Device type: Raspberry Pi 4
Firmware Version: Venus OS v2.80_33-large-24

Battery/BMS (please complete the following information):

BMS/Battery type: It doesn't matter at this step.
Cells: -
Interface: USB-RS485

Additional context

There is a new beta4 release that should solve this issue. Please give it a test


Can we support connectionParams for the graphql-ws protocol?

I've noticed using GraphiQL that the request headers are not being sent for subscriptions.  When I generate the Context I use the headers to get an access token, but the headers I defined within GraphiQL are not getting sent.  The headers do work for queries and mutations.
Is there a better alternative or is this a bug?

I guess what I'm really asking is:  what is the best way to authenticate the user for subscriptions?

https://www.apollographql.com/docs/apollo-server/data/subscriptions#onconnect-and-ondisconnect

https://github.com/enisdenjo/graphql-ws/discussions/263

https://github.com/enisdenjo/graphql-ws/discussions/263#discussioncomment-1612011
This seems like the way to do it.  I think all it involves is accepting a payload for ConnectionInit.  That payload could then be passed to the contextBuilder as another parameter.  Then the contextBuilder could implement the logic to see if it was getting the parameters from the request or the connectionParams.

It's a bit more work to do that. I think I can still make the change though.

This is definitely a bug

The difficult part is that connectionParams is loosely typed and many examples just put whatever on it. I am not really liking the approach of adding another parameter to the contextBuilder because now you have to check for the Request and the additional payload to get a header for instance. Not to mention that in the subscriptions portion of the application, the request query is not present inside the Request object. I was considering having a seperate contextBuilder instead since now you will be provided with the payload, the query, and the arguments as well.

I have a somewhat of working solution with the seperate context builder but I have finals today so I'll make sure everything work properly and publish the new version later the day.

Awesome!  I like that solution and I agree with you on your points

I couldn't find anything on GraphiQL that will let it pass the request header given in the header tab into the connectionParams, and whether that is even possible.
This is websocket message sent by GraphiQL with some values in the header tab:

I am aware of passing it manually shown https://github.com/graphql/graphiql/issues/2181#issuecomment-1046114322. However, I couldn't any resolution to passing the request header tab values as connectionParams.
I am personally using BananaCakePop which does sent the headers in the header tab into the connectionParams which verify that the changes made #41 does work.

However, it also have issues with not sending any other header with a key that is not the common header list.

I verified this does work with Apollo Sandbox, which was able to sent the request header specified in the header tab to the connectionParams which is received by the websocket context builder.

Technically, this library now properly support connectionParams in graphql-ws in 0.7.0, but since your original question involved GraphiQL which is not capable to pass the request header into the connectionParams, I will keep this issue open until I can resolve that issue.

Thanks for doing this so quickly!  I guess I'm using Apollo Sandbox for now

Update

#43

Latest version of @apollo/sandbox now have supported subscriptions and seemed to meet feature parity with the cloud hosted version.
Whether there are still some issue with the self hosted one, I am not too sure. I will be spending some time looking into this and possibly update this library to have that as its default GraphQL IDE

Update

graphql/graphiql#2181

Latest version of graphiql also now pass request headers as connectionParams . Although, I have to check whether everything work properly with the way it is setup.
In terms of default option for playground, both seemed like good choices now. I am considering Apollo Sandbox as the default option if both are working well. I will be closing this issue after I checked and fixed any issue with both IDEs

Update

graphql/graphiql#2181

Latest version of graphiql also now pass request headers as connectionParams . Although, I have to check whether everything work properly with the way it is setup.
In terms of default option for playground, both seemed like good choices now. I am considering Apollo Sandbox as the default option if both are working well. I will be closing this issue after I checked and fixed any issue with both IDEs

GraphiQL can send connectionParams for graphql-ws but not for subscriptions-transport-ws. To be fair, this is a non issue as subscriptions-transport-ws is considered legacy now, but this also meant the default IDE is likely going to be Apollo Sandbox instead of GraphiQL.

The default is changed now. Made sure both Apollo Sandbox and GraphiQL should be working properly using the latest version in v0.10.1.
Closing this issue for now, feel free to reopen an issue related come up


[MINOR] Add trivial cosmetic changes on STYLE.md

What is this PR for?
This PR proposes a little bit of cosmetic changes on STYLE.md.
Before
                  "src-noconflict/mode-sql.js",
                  "src-noconflict/mode-markdown.js",
                  "src-noconflict/keybinding-emacs.js",
                 "src-noconflict/ext-language_tools.js",
+                 "src-noconflict/theme-github.js"],
       "version": "1.1.8",
       "name": "ace-builds"
    },
    "highlightjs": {
        "main": ["highlight.pack.js",
+                 "styles/github.css"],
      "version": "8.4.0",
      "name": "highlightjs"
     }

-      $scope.editor.setTheme('ace/theme/github');
+      $scope.editor.setTheme('ace/theme/monokai');

-                 "src-noconflict/theme-github.js"],
+                 "src-noconflict/theme-monokai.js"],

After
                  "src-noconflict/mode-sql.js",
                  "src-noconflict/mode-markdown.js",
                  "src-noconflict/keybinding-emacs.js",
                  "src-noconflict/ext-language_tools.js",
+                 "src-noconflict/theme-github.js"],
       "version": "1.1.8",
       "name": "ace-builds"
    },
    "highlightjs": {
        "main": ["highlight.pack.js",
+                 "styles/github.css"],
      "version": "8.4.0",
      "name": "highlightjs"
     }

-      $scope.editor.setTheme('ace/theme/github');
+      $scope.editor.setTheme('ace/theme/monokai');

-                 "src-noconflict/theme-github.js"],
+                 "src-noconflict/theme-monokai.js"],

What type of PR is it?
[Documentation]
What is the Jira issue?
MINOR
How should this be tested?
Manually checked the rendering
Questions:

Does the licenses files need update? No
Is there breaking changes for older versions? No
Does this needs documentation? N/A

Hi @felixcheung, it seems the last change was by you. Could you please take a look? I think I am not used to this and also not sure if this change is good or not but just decided to submit this as it just looks a little bit prettier apparently.

@HyukjinKwon Thanks for your contribution. Looks nice 👍

Thank you, @AhyoungRyu.

nice!

Thanks @fellixcheng, would I maybe have to retrigger the build for the green?

CI failure is not related, since this is a .md that is not part of the doc build

merged


fix: selection and deletion of shapes

fixes #68

I don’t mind merging this into dev,  but I’m missing a test, before putting it into a release.


Test/update dividend tax withholding list

:tada: This PR is included in version 2.0.1-beta.69 :tada:
The release is available on:

npm package (@beta dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Claudino-Bartlett basis sets

Hi,
you could add the Claudino-Bartlett basis sets available from Daniel Claudino's repo
https://github.com/danclaudino/basis_sets
where the references are also included.

Should be pretty straightforward. The data seems to be all there.
The readme says they are available on the old BSE, but it looks like they were never "published". But it should be easy to add them here.
@danclaudino Any issues/objections?

Not at all.
The ANO-VT-XZ basis sets are also on the old BSE, but were never made public.
Let me know if you have any questions.

Added in 17aa3c784409599aa77a82208fac109d5ac6334b
FYI @danclaudino , you have a bit of duplication in your directory structure:
https://github.com/danclaudino/basis_sets/tree/master/FANO-NZ/FANO-TZ
Other than that it was easy to add.  Let me know if there are any errors or if you would like to add notes, etc.

Thanks for pointing this out.


Roll Flutter Engine from 4f6180a2a577 to e04440f91cee (2 revisions)

https://github.com/flutter/engine/compare/4f6180a2a577...e04440f91cee
2024-12-11<EMAIL_ADDRESS>Roll Dart SDK from f863f0b43625 to d87b2f6d2b03 (2 revisions) (flutter/engine#57110)
2024-12-11<EMAIL_ADDRESS>Roll Skia from 854eb19c722e to b2f13d9a5678 (1 revision) (flutter/engine#57114)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


Package subpath './package.json' is not defined by "exports" in /Users/xxx/my_repo/node_modules/cesium/package.json

This is Cesium installed via npm and integrated in a Svelte/Sapper route.

npm install cesium
Add a Svelte page to a Sapper basic demo app for the route /cesium which will load a basic Cesium Viewer.
run npm run dev

The Svelte page

<svelte:head>
    <title>Cesium Demo</title>
</svelte:head>

The error message
Package subpath './package.json' is not defined by "exports" in /Users/xxx/repos/my_repo/node_modules/cesium/package.json

Workaround
Delete the exports field in node_modules/cesium/package.json.
Re-launch npm run dev.

@rapha-opensource I would recommend you ask about this on https://community.cesium.com since no one on the Cesium team uses Svelte. Also, we use GitHub for confirmed bugs and feature tracking so it's always better to start there first anyway unless you are 100% sure of a bug.
exports is required for NodeJS compatibility, it was introduced in #8659.  There's nothing non-standard about Cesium's behavior here so the problem is most likely on the svelte side (or whatever build tool you are using with it).
If you find out more information that points to something Cesium is doing wrong, please let us know and we can re-open the issue.

This is an issue on more than just Svelte, as many bundler plugins check for config in package.json (react-native, etc.). The fix is not to remove the exports config, but to modify it to also contain ./package.json as was done in this commit.
I recommend re-opening and I'll be happy to add a PR.

Lots of tools need to require.resolve package.json, and in the latest versions of node.js it's impossible to do in a package with exports unless the package.json is explicitly exported. There's lots of discussion about this here:
https://github.com/nodejs/node/issues/33460
But in the short term, I believe adding package.json to exports is a safe and effective solution. I'm going to re-open this, and I think we'd be happy to take a PR for it @wallw-bits.


../Grouping/src/utils/openroad: undefined symbol: _ZdlPvm, version Qt_5

Hello,
I followed the steps "https://github.com/The-OpenROAD-Project/OpenROAD" to setup openroad environment, however when running "python3 flow.py" under MacroPlacement/MacroPlacement-main/CodeElements/CodeFlowIntegration path, I will get below error:
../Grouping/src/utils/openroad ../Grouping/src/utils/extract_hypergraph.tcl setup.tcl
../Grouping/src/utils/openroad /ic/proj/comet/root/MacroPlacement/MacroPlacement-main/CodeElements/CodeFlowIntegration/extract_hypergraph.tcl
../Grouping/src/utils/openroad: symbol lookup error: ../Grouping/src/utils/openroad: undefined symbol: _ZdlPvm, version Qt_5
The OS is Centos 8.
Anyone knows how to solve this issue?
Thank you very much!

@sharkoo7,  Thanks for your reply.  Yes,  sharkoo7 is right.  I suggest you take a look at OpenROAD installation guide.

thank you guys @ZhiangWang033 @sharkoo7 , I switch the OS to ubuntu18.04 and install tools as I did in centos8, and it works

Mainly, this issue might happen on the newer versions than Ubuntu 18.04 such as: Ubuntu 20.04. To fix this issue without switching to Ubuntu 18.04, we can use these steps below.
change a path to save .run file
cd /path/to/
wget https://download.qt.io/new_archive/qt/5.11/5.11.2/qt-opensource-linux-x64-5.11.2.run
chmod +x qt-opensource-linux-x64-5.11.2.run
./qt-opensource-linux-x64-5.11.2.run
copy all libs from Qt5.11.2 to /usr/lib/x86_64-linux-gnu/
sudo cp -a /path/to/Qt5.11.2/5.11.2/gcc_64/lib/. /usr/lib/x86_64-linux-gnu/


fix(#163): remove uninstalled apps from home screen

This is a draft PR that fixes #163

@jkuester Thank you for finishing this PR!


PostCSS line return parsing error - https://github.com/advisories/GHSA-7fh5-64p2-3v2j

Good Morning, I
m getting the next error and I'm not sure how to vercome it
any advice will be great
Severity: moderate
PostCSS line return parsing error - https://github.com/advisories/GHSA-7fh5-64p2-3v2j
No fix available
node_modules/postcss
@ellucian/react-design-system
Depends on vulnerable versions of postcss
node_modules/@ellucian/react-design-system

Sorry, no idea on what could cause this.
This repo was just updated to the latest Experience SDK 7.7.0.
Please update and see if that solves the issue.
Bret

Thanks Bret, I will try
Mario :-)


refactor(coral): Refactor useFiltersValues to allow easier extensability (default values, pagination) (hashtag1278)

hashtag What is currently missing?
This PR put into light that there are flaws with the approach taken by useFiltersValues:
The source of the flaws is that the useFiltersValues does several jobs when called:

it gets the values from the URL with useSearchParams
if they do not exist in the URL search params, it will return default values for each filter type

these default values can be passed as arguments  to useFiltersValues

it defines a setFilterValue function which uses setSearchParams

this function also adds a page search params to always reset a table to the first page when a filter is set this way (for consistent behaviour and avoiding bugs

it returns each filter value and the setFilterValue function

hashtaghashtaghashtag Flaw 1: default values
The problem is that useFiltersValues is used both in a parent component which renders some data a user wants to filter (mostly to get the filter values) and in filter components which are provided to the user to filter that data.
This means that default values passed to useFiltersValues in the parent component will be overridden by the useFiltersValues in the  filter components, which does not have any default values.
The only solution currently is to not set default values at the parent component useFiltersValues level, but on the filter component level, where it can be forwarded to the inner useFilterValues. It is clunky and counterintuitive.
hashtaghashtaghashtag Flaw 2: adding a paginated boolean flag
We may not always want to have the page search param set in the URL when filtering. Similarly, the only solution is to pass it as a prop to filter components, which has the same drawbacks, but even worse: the same prop needs to be passed individually to every filter we want to use on a given set of rendered data, when it would make sense that we could pass the option once at the parent component's useFilterValues level.
hashtag How could this be improved?
After a little research, the main candidate for a solution is the use of a Context, as described in this comment:
This would solve Flaw 1 and 2 by allowing to pass default values at the Provider level, like so:
It would also allow to access the filter values and the setFilterValue function without overriding the defaults, and without the need for extra props on filter components:
hashtag To be discussed
The need to wrap every component wanting to filter data or access the value of the filters in the FiltersProvider is bulky and a little unpleasant. I don't currently have any idea to make it better, apart from some kind of higher-order component in this style:

hashtag Is this a feature you would work on yourself?

[ ] I plan to open a pull request for this feature

All in all, I think using a Provider is a good solution for us! Thanks for all the investigating ✨

The need to wrap every component wanting to filter data or access the value of the filters in the FiltersProvider is bulky and a little unpleasant.

I think it's not too bad! It is very explicit: "This component needs the context." It reflects the complexity, which I think is a good thing in regards to readability / understandability (is this a word?? :D )

In case you had not seen it, this is the implementation proposal ^^


Fix shape inference for Loop@v19 and v21

Fixes #163
Checklist

[x] Added a CHANGELOG.rst entry

I'm marking this as "draft" since the current implementation is too limiting / inconsistent.


Dockerfile no longer builds

The current ./docker/run-docker.sh script and associated Dockerfile.cpu fails a PyTorch installation with the following error:
Executing transaction: ...working... done
Retrieving notices: ...working... failed
Traceback (most recent call last):
  File "/home/nfraser/.local/miniconda3/lib/python3.9/site-packages/conda/exceptions.py", line 1129, in __call__
  File "/home/nfraser/.local/miniconda3/lib/python3.9/site-packages/conda/cli/main.py", line 86, in main_subshell
  File "/home/nfraser/.local/miniconda3/lib/python3.9/site-packages/conda/cli/conda_argparse.py", line 93, in do_call
  File "/home/nfraser/.local/miniconda3/lib/python3.9/site-packages/conda/notices/core.py", line 75, in wrapper
  File "/home/nfraser/.local/miniconda3/lib/python3.9/site-packages/conda/notices/core.py", line 39, in display_notices
  File "/home/nfraser/.local/miniconda3/lib/python3.9/site-packages/conda/notices/http.py", line 36, in get_notice_responses
  File "/home/nfraser/.local/miniconda3/lib/python3.9/site-packages/conda/notices/http.py", line 39, in <genexpr>
  File "/home/nfraser/.local/miniconda3/lib/python3.9/concurrent/futures/_base.py", line 609, in result_iterator
  File "/home/nfraser/.local/miniconda3/lib/python3.9/concurrent/futures/_base.py", line 446, in result
  File "/home/nfraser/.local/miniconda3/lib/python3.9/concurrent/futures/_base.py", line 391, in __get_result
  File "/home/nfraser/.local/miniconda3/lib/python3.9/concurrent/futures/thread.py", line 58, in run
  File "/home/nfraser/.local/miniconda3/lib/python3.9/site-packages/conda/notices/http.py", line 42, in <lambda>
  File "/home/nfraser/.local/miniconda3/lib/python3.9/site-packages/conda/notices/cache.py", line 37, in wrapper
  File "/home/nfraser/.local/miniconda3/lib/python3.9/site-packages/conda/notices/http.py", line 58, in get_channel_notice_response
  File "/home/nfraser/.local/miniconda3/lib/python3.9/site-packages/requests/sessions.py", line 600, in get
  File "/home/nfraser/.local/miniconda3/lib/python3.9/site-packages/requests/sessions.py", line 587, in request
  File "/home/nfraser/.local/miniconda3/lib/python3.9/site-packages/requests/sessions.py", line 701, in send
  File "/home/nfraser/.local/miniconda3/lib/python3.9/site-packages/requests/adapters.py", line 460, in send
  File "/home/nfraser/.local/miniconda3/lib/python3.9/site-packages/requests/adapters.py", line 263, in cert_verify
OSError: Could not find a suitable TLS CA certificate bundle, invalid path: /home/nfraser/.local/miniconda3/lib/python3.9/site-packages/certifi/cacert.pem

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/nfraser/.local/miniconda3/bin/conda", line 15, in <module>
    sys.exit(main())
  File "/home/nfraser/.local/miniconda3/lib/python3.9/site-packages/conda/cli/main.py", line 129, in main
  File "/home/nfraser/.local/miniconda3/lib/python3.9/site-packages/conda/exceptions.py", line 1429, in conda_exception_handler
  File "/home/nfraser/.local/miniconda3/lib/python3.9/site-packages/conda/exceptions.py", line 1132, in __call__
  File "/home/nfraser/.local/miniconda3/lib/python3.9/site-packages/conda/exceptions.py", line 1172, in handle_exception
  File "/home/nfraser/.local/miniconda3/lib/python3.9/site-packages/conda/exceptions.py", line 1183, in handle_unexpected_exception
  File "/home/nfraser/.local/miniconda3/lib/python3.9/site-packages/conda/exceptions.py", line 1245, in print_unexpected_error_report
ModuleNotFoundError: No module named 'conda.cli.main_info'
The command '/bin/sh -c conda install -y pytorch==1.4.0 torchvision==0.5.0 cpuonly -c pytorch &&     conda clean -ya' returned a non-zero code: 1

Resolved by 17389d347b45002c5bb4e95fbaeb7ed4dd1eddbd.


Commit amend fails with renamed files?

Steps to Reproduce
Not exactly sure how to set up directory yet, but...
$ gg commit --amend

Expected Behavior
Editor opens to amend the commit message.
Actual Behavior
gg fails with this error:
gg: read diff entry: expected '\x00' after 'R' or 'C', but not found

--show-git output:
gg: exec: git --version
gg: exec: git status --porcelain -z -unormal
gg: exec: git log --max-count=1 -z --pretty=tformat:%H%x00%P%x00%an%x00%ae%x00%aI%x00%cn%x00%ce%x00%cI%x00%B HEAD --
gg: exec: git diff --name-status -z 99e476b18674ff0737873c0f4e98d64baddf9073

Version Info
gg built from source at debcabbbb901c74f64e79e9a5b2703140a6c5953 on 2020-10-12T16:53:39Z
go: go1.15.2 gc linux/amd64
git version 2.17.1

Seems like this occurs when amending a commit that contains renames.


[Safe App] Aave v1.2

There is a new update for the Aave Safe App: https://github.com/aave/gnosis-safe-app/releases/tag/1.2

Code review
QA
Add to IPFS & pin
Add to safe-react

Code seems fine. Loads correctly. Only able to test on mainnet:
https://gateway.pinata.cloud/ipfs/Qmcs2UnBZwrjmPRz4HAQb5d8KsW6aXfS8pnFteiorwoE5c

Tried to deposit 1 DAI and I got this error

The console

I wasn't able to sign anything, it fails in the app right away @dasanra

This should be fixed in this test version:
https://gateway.pinata.cloud/ipfs/QmZiZ2h1YrSCAhhxRjQ8cCc6iHtssRbXxXV3oovLGm1b17/

I tried this in both, the rinkeby prod env and mainnet prod env
RInkeby: https://rinkeby.gnosis-safe.io/app/#/safes/0x9913B9180C20C6b0F21B6480c84422F6ebc4B808/apps
https://gnosis-safe.io/app/#/safes/0x8675B754342754A30A2AeF474D114d8460bca19b/balances
I added in both the URL given in the previous comment

In rinkeby I was able to add the app, but the tokens show no funds.
I have USDC, SNX, ETH, DAI... none of them showed any tokens in the Aave app

In prod the funds can be seen in the app, but the tx always fail when I try to sign it. The signature is an "off chain" type of tx.
This new URL is only for testing env? if that's the case then maybe is that why it fails every time

Tried regular tx (send funds) signatures and I had no issues, so tx themselves are working properly

Issue was related to the link length. This can be tested here:
https://ipfs.gnosisdev.com/ipfs/QmX1NUtvm9WjbvT79sTdeg3sw1NxZAM273y44nBy5d2jZb/

Tried again with a new URL and it worked fine
Tested here: https://gnosis-safe.io/app/#/safes/0x8675B754342754A30A2AeF474D114d8460bca19b/balances
App URL: https://ipfs.gnosisdev.com/ipfs/QmX1NUtvm9WjbvT79sTdeg3sw1NxZAM273y44nBy5d2jZb/


Fix the typehint used by the TestMessage

This tells me that nobody ever used this command btw :smile:

Thanks :)


Question on styling tabs a certain way.

Current behaviour
Trying to get the style I've attached, but can't seem to do it. Should this be possible? The selected tab needs to have a background color, the deselected tab white.
Expected behaviour
Code sample
Screenshots (if applicable)

What have you tried
Your Environment

software
version

ios or android
ios

react-native
0.59.9

react-native-tab-view
2.6.0

react-native-gesture-handler

react-native-reanimated

node

npm or yarn

You need a custom tab bar for that. See the README for example.


Upgrade to core v4.0.0-rc5

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

3 of 3 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
531

Relevant Lines:
531

💛  - Coveralls


Add support for module instances.

Don't pad logical operands to one bit.
Use operand width and signedness in $reduce_bool.
Shift amounts are unsigned and shouldn't be padded.
Group "is invalid" with the wire declaration, not its use (otherwise it is incorrectly wired to 0).

Merged into YosysHQ master, then into ucb-bar master.


Add border to covid 19 find support block

What
We need to look at updating the content, and possibly the design, of the 'Find support if you're struggling' box. The content needs to more accurately reflect the service.
Update the box with this final design (in cover) and attached 'Final support design'
Why
Research has shown that some users are either not noticing, or not understanding the content in the 'Find support if you're struggling' box on the landing page.
Demo
https://govuk-collec-add-border-3uwnln.herokuapp.com/coronavirus
Before

After

https://trello.com/c/UzmUWkvX/674-update-the-find-support-if-youre-struggling-box

Is it worth putting in some kind of fallback for older browsers? This is IE9, for example...

Looks like the border isn't being styled properly but it's still there. I'd suggest providing a colour for the border (which would then be overridden by border-image). Maybe either something bright to make it stand out, or just the colour of the box itself? Might be a question to run by a designer.

Thanks for spotting that - I'll speak with a designer and get back to you

Thanks for spotting that - I'll speak with a designer and get back to you

Another thought relating to that - if the decision is to not colour the border in this situation, it might look a little out of balance (as it's adding 10px to the left of the box) - might be worth adding an extra 10px of padding to the right to centre the text.

Thanks for spotting that - I'll speak with a designer and get back to you

Another thought relating to that - if the decision is to not colour the border in this situation, it might look a little out of balance (as it's adding 10px to the left of the box) - might be worth adding an extra 10px of padding to the right to centre the text.

Hey @andysellick - Had a chat with Kate and she said the yellow solid border is fine on IE10 and below. I have updated the screenshot above for your reference.


Solving OS X compilation issue

Hi,
I wanted to test the library on OS X using standard apple compiler. Using the develop branch, it fails to compile (I only tested similarity_search directory for now).
The issue is the following :

use of undeclared identifier '_MM_HINT_T0'

The _mm_prefect is an SSE instruction so you may include xmmintrin.h instead of mmintrin.h (which is MMX only). If I replace the include of mmintrin.h by xmmintrin.h in the following files :

src/method/hnsw.cc
src/method/pivot_neighb_invindx.cc
src/method/small_world_rand.cc
src/method/vptree.cc

now the library compiles fine using the standard apple compiler. I also tested using macports version of clang (4.0) and it works too.
I don't know the implications on the rest of the library and on the other platforms (that's why I didn't make a PR) but it may be a simple approach to solve compilation issue on OS X.

Hi @rperrot thank you for the issue, this problems seems to be solved in the master branch: https://github.com/searchivarius/nmslib/issues/105 but it is certainly present in some versions. Which branch/release do you use?

I only tried the develop branch.

@rperrot ohh, I see let me merge master into develop.

@rperrot please, try to pull from the develop and recompile (please, do cmake . first and may be even remove cmake caches).

That's ok in develop branch now. (either with standard apple compiler and macports clang-4.0). Thanks for your support.
Finally, jjust a question to understand your development process : what is the most stable branch ? master or develop ?

@rperrot thank you for checking. master is a bit more stable, but the library is being actively developed.


ffmpeg console windows briefly appearing

Checklist

[ ] I'm reporting a broken site support issue
[x] I've verified that I'm running youtube-dl version 2021.06.06
[x] I've checked that all provided URLs are alive and playable in a browser
[x] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[x] I've searched the bugtracker for similar bug reports including closed ones
[x] I've read bugs section in FAQ

Verbose log

Not applicable

Description

On Windows. I'm running a Python script from the Task Scheduler, which calls youtube-dl. When it does the post-processing using ffmpeg, I get brief flashes of console windows which steal the focus. This seems to go away if I add the creationflags = subprocess.CREATE_NO_WINDOW argument to the subprocess.Popen calls of ffmpeg.py (lines 180 and 230).

Oops, sorry - I guess I missed that. Thanks!

Continued in #22627.