g2o: fix CHOLMOD and upgrade

Motivation for this change
Fix build of CHOLMOD solver and upgrade to latest version.
Things done

[X] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[X] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[X] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[X] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 113539 at 0d518832 run on x86_64-linux 1

1 package built:

g2o

2 suggestions:

warning: unclear-gpl
gpl3 is a deprecated license, check if project uses gpl3Plus or gpl3Only and change meta.license accordingly.
Near pkgs/development/libraries/g2o/default.nix:41:5:
   |
41 |     license = with licenses; [ bsd3 lgpl3 gpl3 ];
   |     ^

warning: unclear-gpl
lgpl3 is a deprecated license, check if project uses lgpl3Plus or lgpl3Only and change meta.license accordingly.
Near pkgs/development/libraries/g2o/default.nix:41:5:
   |
41 |     license = with licenses; [ bsd3 lgpl3 gpl3 ];
   |     ^


bug: Open WebUI RAG Malfunction with Ollama Versions Post 0.2.1

What is the issue?
Summary:
Retrieval-Augmented Generation (RAG) functionality within Open WebUI breaks when using Ollama versions later than 0.2.1 for local models. While external models (e.g., GroqCloud's LLama 3 8B) function correctly with RAG, local models fail to utilize the selected document, returning irrelevant or fabricated information. This issue occurs with both SentenceTransformers and Ollama RAG embedding models.
Affected Versions:

Ollama: 0.2.2, 0.2.3, 0.2.4, 0.2.5, 0.2.6, 0.2.7, 0.2.8
Open WebUI: Latest dev and main branches

Unaffected Versions:

Ollama: versions prior to 0.2.1
Open WebUI: ?

Steps to Reproduce:

Clean Slate:

Downgrade Ollama to version 0.2.0 (ollama --version).
In Open WebUI, clear all documents from the Workspace > Documents tab.
Navigate to Admin Panel > Settings > Documents and click Reset Upload Directory and Reset Vector Storage.

Successful RAG Test (Ollama 0.2.0 & 0.2.1):

Add a .txt document to the Open WebUI Documents workspace.
Start a new chat and select the document using the # key.
Input a query related to the document content.
Verify that both local and external LLMs respond accurately, incorporating information from the selected document.
Repeat steps 1 & 2 for Ollama version 0.2.1 after upgrading (ollama --version).

Failing RAG Test (Ollama 0.2.2 onwards):

Upgrade Ollama to version 0.2.2 (ollama --version).
Start a new chat, select the same document from step 2 using the # key, and input the same query.
Observe that local LLMs fail to utilize the document content, providing irrelevant or fabricated responses.
Verify that external LLMs still function correctly with RAG.
Repeat step 3 for Ollama versions 0.2.3, 0.2.4, and 0.2.5, observing the same behavior.

Expected Behavior:
Local LLMs should successfully utilize the selected document for RAG, providing accurate and relevant responses based on its content, regardless of the Ollama version used.
Actual Behavior:
Local LLMs fail to perform RAG accurately when using Ollama versions 0.2.2 and later, while external models remain unaffected. This occurs despite successful document loading and embedding generation (confirmed by testing with both SentenceTransformers and Ollama embedding models).
Additional Notes:

The issue persists across multiple attempts, regenerations, and message edits.
The problem is not specific to a particular document or query, as it consistently occurs with different inputs.
Resetting the Open WebUI upload directory and vector storage, as well as re-uploading documents, does not resolve the issue.
The issue is not related to Tika document extraction for RAG within Open WebUI, as confirmed through testing.
Downgrading Ollama to version 0.2.0 completely resolves the RAG malfunction within Open WebUI.

Conclusion:
A regression appears to have been introduced in Ollama versions after 0.2.1, specifically impacting the interaction between Ollama and Open WebUI for local model RAG functionality. This issue necessitates investigation and resolution to ensure the proper functioning of RAG across all supported Ollama versions.
Related issue on the Open WebUI repo: https://github.com/open-webui/open-webui/discussions/3907
The maintainer of Open WebUI has also confirmed this bug on the latest version of Open WebUI in combination with the latest version of Ollama:

Latest Open WebUI RAG + Ollama v0.2.2 (failures 100% of the time with local models it seems):

OS
Windows, Docker
GPU
AMD RX 6800 XT
CPU
Intel i7-12700K
Ollama version
0.2.2, 0.2.3, 0.2.4, 0.2.5 (latest)

Confirming the issue on my side too with the last update.
Nvidia (4090)
AMD Ryzen 7950 X

To help with variables, I also have the issue on arch linux with a non-docker install.
AMD RX 6900 XT
CPU AMD Ryzen 5950X

Samme issue for me !
I use GPU NVIDIA A100 and Intel CPU with Windows server 2022

I'm going to do more test, because for me I have also encontered bug wtih the version 2.1.

Update/Bump:
After thorough testing, it has been determined that setting the Top K value within Open WebUI's Documents settings to a value of 1 resolves compatibility issues with RAG when using Ollama versions 0.2.1 and later.
Additionally, configuring the context length for your RAG model to a higher number, such as 8192, has been found to maintain functionality with these specific Ollama versions.
These observations are based on empirical data collected by the maintainer of Open WebUI and myself following rigorous testing. The provided screenshots serve as visual evidence supporting these findings:
Setting to adjust:
Open WebUI maintainer's findings:
RAG working with context length set to 8192:

RAG working with Top K set to 1 within Open WebUI's Documents settings:'

On my end, I have a very simple prompt, total token count of the document is around 2k token, slighty more than the 2048 default. However, even if the model is set to 4096, or if in the "current chat settings" it's set to 4096, the issue is still there. Using 8112 works. But 4096 should be way more than enough for my query.
@silentoplayz it seems that using the context length of the "current chat settings" on the sidebar, doesn't have any effect. I can set it to 1, 5,<PHONE_NUMBER>65, the model will answer the ragquery only depending on the settings I've set in the model settings ( workspace>model>edit model>advanced settings.

On my end, I have a very simple prompt, total token count of the document is around 2k token, slighty more than the 2048 default. However, even if the model is set to 4096, or if in the "current chat settings" it's set to 4096, the issue is still there. Using 8112 works. But 4096 should be way more than enough for my query.
@silentoplayz it seems that using the context length of the "current chat settings" on the sidebar, doesn't have any effect. I can set it to 1, 5,<PHONE_NUMBER>65, the model will answer the rag query only depending on the settings I've set in the model settings ( workspace>model>edit model>advanced settings.

It is odd that adjusting the Context Length value within the Chat Controls on the right-hand sidebar doesn't have any effect for you. I have noticed it works to "fix" RAG for me within Open WebUI, even just by raising the context length to 4096 in some cases.
I also came to report that this bug is present on Ollama v0.2.6. Same exact issues as reported above.

any update ?

Hi, any news with this problem ?

Looks like 0.3.0 still has that problem

is this a openweb UI issue then ?

I have tried it on multiple systems now: The jetson container (arm64) wasn't affected. Looks like it's x86_64 that's acting up.

After doing more testing on the dev branch of Open WebUI and the latest version of Ollama today, I've come to the conclusion that I need to adjust the context length of the model within chat controls or within the modelfile in Model settings of the Workspace section for RAG to tell me about documents. This is what I've come to find. It's still a bug to me, as RAG worked fine without having to do any of this before, and I've talked with Open WebUI contributors enough to find out that this is not normal behavior.
The solution? Set the model's context length to something reasonable per modelfile within Open WebUI.
C:\Users\G30>ollama --version
ollama version is 0.3.0

Update: A workaround fix has been applied in the latest dev branch of Open WebUI, resurrecting RAG functionality back to the way it worked before; and that is for it to essentially out of the box. It's a bit sneaky/hacky of a fix, but it DOES work!
So what changed? Basically, instead of using system prompt to provide context to the LLM, Open WebUI now injects the context to the user prompt.

I will say that I was having issues with this too, ollama LLMs not reading the provided documents at all and generating bad answers. I tried providing the context as a user prompt instead of a system prompt, but the issue persisted so I don't think it's a prompt issue, BUT changing the context length in the advanced options helped. So looking into the max context length of the LLM you're using and setting that option to a multiple of that helps. Not sure what the "magic" amount is, but that helped me.


add root argument to the dataset visualizer to visualize local datasets

What this does
This PR adds the root argument to the dataset visualizer. This parameter is passed to LeRobotDataset.__init__,  which enables visualizing local datasets, as an alternative to setting the DATA_DIR env variable.
closes #248
How it was tested
Explain/show how you tested your changes.

added a unit test to tests/test_visualize_dataset that visualizes the local copy of the lerobot/pusht dataset

How to checkout & try? (for the reviewer)
Examples:
python lerobot/scripts/visualize_dataset.py --repo-id lerobot/pusht --root tests/data/ --episode-index 0 --mode distant

This change is

@Cadene feel free to provide feedback!


Fix tests 1944, case 2 for branch dk/projects.

Fix for two tests for target PR
Motivation and context
Fail of two tests in the target PR .
How has this been tested?

Checklist

[ ] I submit my changes into the develop branch
[ ] I have added description of my changes into CHANGELOG file
[ ] I have updated the documentation accordingly
[ ] I have added tests to cover my changes
[ ] I have linked related issues (read github docs)
[ ] I have increased versions of npm packages if it is necessary (cvat-canvas,
cvat-core, cvat-data and cvat-ui)

License

[ ] I submit my code changes under the same MIT License that covers the project.
Feel free to contact the maintainers if that's a concern.
[ ] I have updated the license header for each file (see an example below)

# Copyright (C) 2020 Intel Corporation
#
# SPDX-License-Identifier: MIT

@ActiveChooN This fix should help.

@ActiveChooN Could you please review the patch because it is dedicated for your branch?


injectManifest with importWorkboxFrom option?

Library Affected:
workbox-build
Browser & Platform:
all browsers
Issue or Feature Request Description:
*Does injectManifest support importWorkboxFrom? I saw https://github.com/GoogleChrome/workbox/issues/1260 and https://github.com/GoogleChrome/workbox/pull/1290 but if I pass importWorkboxFrom: 'local' as an option of injectManifest, it still generates ValidationError. I'm using https://github.com/nuxt-community/pwa-module/tree/develop/packages/workbox *
I'm in China. I can't access google cdn for well known reasons. importWorkboxFrom: 'local' is a must for me. Please help
When reporting bugs, please include relevant JavaScript Console logs and links to public URLs at which the issue could be reproduced.
 ERROR  build:done

  ValidationError: "importWorkboxFrom" is not a supported parameter.

  - errors.js:190 Object.exports.process
    [eoi-portal]/[joi]/lib/errors.js:190:19

  - index.js:668 internals.Object._validateWithOptions
    [eoi-portal]/[joi]/lib/types/any/index.js:668:31

  - index.js:702 internals.Object.validate
    [eoi-portal]/[joi]/lib/types/any/index.js:702:21

  - validate.js:20 module.exports
    [eoi-portal]/[workbox-build]/build/entry-points/options/validate.js:20:33

  - inject-manifest.js:44 Object._callee$
    [eoi-portal]/[workbox-build]/build/entry-points/inject-manifest.js:44:23

  - runtime.js:62 tryCatch
    [eoi-portal]/[babel-runtime]/[regenerator-runtime]/runtime.js:62:40

  - runtime.js:296 Generator.invoke [as _invoke]
    [eoi-portal]/[babel-runtime]/[regenerator-runtime]/runtime.js:296:22

  - runtime.js:114 Generator.prototype.(anonymous function) [as next]
    [eoi-portal]/[babel-runtime]/[regenerator-runtime]/runtime.js:114:21

  - asyncToGenerator.js:17 step
    [eoi-portal]/[babel-runtime]/helpers/asyncToGenerator.js:17:30

  - asyncToGenerator.js:35
    [eoi-portal]/[babel-runtime]/helpers/asyncToGenerator.js:35:14

  - new Promise

  - _export.js:36 new F
    [eoi-portal]/[core-js]/library/modules/_export.js:36:28

  - asyncToGenerator.js:14 Object.<anonymous>
    [eoi-portal]/[babel-runtime]/helpers/asyncToGenerator.js:14:12

  - inject-manifest.js:123 Object.injectManifest
    [eoi-portal]/[workbox-build]/build/entry-points/inject-manifest.js:123:17

  - index.js:225 hook
    [eoi-portal]/[@nuxtjs]/workbox/index.js:225:20

  - nuxt.js:122 fn
    [eoi-portal]/[nuxt]/lib/core/nuxt.js:122:47

importWorkboxFrom isn't a supported option when using injectManifest mode with the workbox-build plugin. (It is supported when using the workbox-webpack-plugin, but that's not what's being used here.)
You can replicate that behavior by using the workbox-cli and running workbox copyLibraries <path/to/libraries>, or just downloading the archive for a given version from the release page.
Then, in your swSrc file, you can follow the steps documented here to point to the local files.


Add Hierarchy of Section Titles to Needs Metadata

@danwos Can you cancel #52? I've re-worked this feature per our discussion and squashed the commits.   It was just easier to rebuild off a new branch to lose the merge commits.
This feature adds the section title hierarchy to each need as part of its internal metadata.  This can be used in two key ways.

The sections are now exported as part of needs.json as a list.  The first item is the needs current section, and the remaining items (if any) represent the chain of parent sections.

sections is now available in :filter: specifications.

One note on the implementation, when Sphinx creates a section title with auto-section numbering (.. sectnum::), then it inserts 3 non-breaking spaces between the section number and the section title.  I opted to automatically replace those with a single normal space.  I think that makes it easier to work with, but it's not precisely what the section title is.

And again, Thanks! :)
Merged it and created also a new version for this and your last awesome changes on pypi: 0.2.2 https://pypi.org/project/sphinxcontrib-needs/


Adds an option (--alfred-file) for existing alfred json files

To be able to create a nodes.json without an alfred instance running in master mode I added an option (--alfred-file) to bat2nodes.py that allows the processing of an existing alfred json file (e.g. ffmap.freifunk-rheinland.net/alfred.json).

State.json is stored in the current working directory.
I think a better approach is to store the file in the given destination directory.

The state.json is needed only in ffmap-backend to load the last state in the next run of bat2nodes.py. Why store state.json in ffmap-d3 while it won't use it?

Hm, ok, that's a point.
I was just wondering about those state.json files lingering around everywhere.
So I have to modify my script to chdir before calling bat2nodes.py.


wait until completion with condition variable

feel free to squash out e1588d3, lol
basic idea: leaf nodes in the future tree signal a shared condition_variable in the context when they are done executing.

also, FIRST


Here is the ultimate test

This is not an issue. Sorry, there is no discussion page.
But here is the ultimate test for food-not-food.

Hahahah!
The ultimate test and it's both: food & not food!
That might break the model.

Well... looks like it's "food".
Just cleaned up a bunch of code/trying to make it reproducible.
The new model is trained on about ~40k images of food + ~25k images of not food.
So the model probably has a bias to predicting food.

Oh no! :(


Add Metadata Decorator [WIP] #124

Based on issues #124 and #163. Does this fit what you were thinking for the implementation?
Currently it only covers Fields + Objects until I understand you are happy with the simple implementation. From my understanding you want the Metadata decorator to be callable multiple times for the same objects/fields.
If this is what you're after, please point me in the right direction for writing some tests.

Basically it looks ok. Metadata interface name might be confusing as we have ParamMetadata and other so it looks a bit like a base type.
In examples I would focus only on placing metadata, with fresh example, not copy-paste from the base, simple example. Copy-pasted mutations only introduce noise, not good use cases.
We should show all the possibilites of usage:

placing metadata decorator once and twice
creating own decorator for placing specific metadata key (e.g. the query-complexity case as it should be later refactored into metadata decorator usage)
placing in:

object type
input type
query
fields

reading the metadata (probably in info of resolver/middleware execution)
others (maybe integration with some npm package for graphql?)

And of course the usage and all possibilities have to be well described in docs.

If this is what you're after, please point me in the right direction for writing some tests.

I always try to test only the usage, so you should check if the metadata realy exist in all the types and fields after building the schema, if mutliple decorators overwrites the metadata key, etc.
You should create own test file for that, don't pollute the existing ones.

@DavidHooper
What is the progress of your work? Are you going to continue working on this feature? 😉


Migrate article: Viewing service logs

Migrate the content from this article to fit the documentation portal format https://help.aiven.io/en/articles/2357598
(Assign this issue to yourself before you start, and remember to mention the issue number when you open your pull request)

@lornajane Where would be the best place to add the link for this in devportal?

PR is here
https://github.com/aiven/devportal/pull/1205


Github#11869: Add RangeOnRangeFacetCounts

Description

Issue: https://github.com/apache/lucene/issues/11869
Adds RangeOnRangeFacetCounts which supports double ranges and long ranges to mirror RangeFacetCounts. Currently, this does not have support for multivalues fields and uses basic linear scanning to count the facets.

@mdmarshmallow started to dig into this. Will get you some feedback this week. Just letting you know it's on my radar. Thanks for all the hard work on this!

Thanks for looking at this @gsmiller, I know it's a large PR. I based a lot of this off of LongRangeSlowRangeQuery, which does handle multidimensional fields. However, if I understand it correctly, it does so in a way that is similar to FacetSets where it treats all the dimensions as defining a hyper rectangle. By this I mean that input ranges are only compared with the stored range of the same dimension. I figured we shouldn't do that for RangeOnRangeFacetCounts as FacetSets already does this. So I guess I wasn't super sure on how to handle it? Like if we allow for multidimensional ranges, then should we make sure that every input range matches every stored range regardless of dimension (take a cross product)? I can add this if you think it makes sense.

@mdmarshmallow it's similar to FacetSets but a bit different since FacetSets work over stored points, while this would work over stored ranges. I think it would make sense to eventually support multiple dimensions here, since the data (LongRangeDocValueFields) allow for it. I'm thinking about a user who is storing multi-dim ranges and creating queries that filter over those same ranges, but has no way to facet over them.
As for how to handle faceting of multi-dim ranges, I think the logic would be the same as the "slow" query you reference, and would depend on the RangeFieldQuery#QueryType specified.
But... as for concrete next steps, I see the value in simplifying the problem to a single dimension to get started. That likely covers most use-cases anyway. But I'd also like to create a path towards supporting multi-dim without having to create a completely new API. Could we re-use LongRangeDocValueFields for the indexing piece of this, and create a faceting implementation that functions over that data, but only make it work for single dimensions to start? Maybe the faceting API you create is simplified to the single-dimension case and it validates that the underlying field being faceted is single-dim? That way, in the future, if we add multi-dim support, users can keep using the same field type for their documents but the API gets generalized?

Ah yeah good point on the FacetSets... so I actually already use LongRangeDocValueFields here: public class LongRangeDocValuesFacetField extends LongRangeDocValuesField. The difference is that the LongRangeDocValuesFacetField constructor enforces a single dimension. I'd imagine if we want to extend it, it shouldn't be that hard to just add another constructor here.
With regards to this though:

As for how to handle faceting of multi-dim ranges, I think the logic would be the same as the "slow" query you reference, and would depend on the RangeFieldQuery#QueryType specified.

I think I will need to change this PR a bit then. Right now what happens is that the query can have multiple ranges, which all need to "match" the stored range, which matches the "cross product" idea I talked about earlier which we won't be doing. So the way to go from here I think would be to either enforce only one range in the query, or just go ahead and do the multidimensional implementation. I think the latter makes more sense since I will need to change code either way.

Ah yeah good point on the FacetSets... so I actually already use LongRangeDocValueFields here: public class LongRangeDocValuesFacetField extends LongRangeDocValuesField. The difference is that the LongRangeDocValuesFacetField constructor enforces a single dimension. I'd imagine if we want to extend it, it shouldn't be that hard to just add another constructor here.

Right. What I'm questioning here is the need for LongRangeDocValuesFacetField. If the only value it adds is a ctor that "speaks" in a single-dimension, I wonder if we should keep it or just ask our users to use LongRangeDocValuesField directly. If we think users would benefit from a simpler, single-dim API, let's consider adding that directly to LongRangeDocValuesField.

Right now what happens is that the query can have multiple ranges, which all need to "match" the stored range, which is pretty much the "cross product" idea I talked about earlier which we won't be doing.

I don't think I'm following. Are you referring to the current "slow query" implementation? It doesn't support multiple ranges right? It supports multiple dimensions? And yes- each dimension needs to satisfy the requirements specified by the provided QueryType. I imaging faceting doing the same thing, but separately considering each range for facet counting. Maybe we're confusing the concept of "multiple dimensions" with "multiple ranges" in our discussion here?

or just go ahead and do the multidimensional implementation

Yeah, I think that's fine. I don't think it will be significantly more complex to implement multi-dim support. I think the only complexity comes in thinking about the problem and conveying something usable to users (who, I suspect, will be looking for a single-dim implementation most of the time).

Edit: now that I think about it a bit more, I'm not actually doing a cross product, I think I was getting the concept of multidimensional ranges for multiple ranges mixed up in my mind. I'll need to look more into the API to see how we can make it extensible in case we want to make this multi-dimensional in the future.

Ah ok. Maybe disregard my above comment about mixing up "multiple ranges" and "multiple dimensions." Sounds like maybe that's whats going on. Let me know if I can help disambiguate. Thanks!

Hey @gsmiller, sorry for the delay but finally got around to your feedback. I decided to just add multidimensional support since it was fairly straightforward (if not a bit tedious to test lol). I kept the single dim API the same (there's some syntax sugar) and made the multidimensional API similar to LongSlowRangeQuery. Thanks for all the feedback!


Remove comments, move DOM creation to html

I'm mixing 2 concerns with this PR, so feel free to agree with only one part.

Remove comments... it was just getting hard to read. Ideally we should be more self explanatory.

Move DOM creation to HTML... Shortened fn significantly and improved readability. On the flip, encapsulation into code proposal may be harder with this model, although it could be done through webpack.

yeah, i wasn't a huge fan of the notes overload. happy to see them go. love the idea of moving DOM into the HTML file since that's not really part of the exercise. We should do that for all dice demos

yeah, i wasn't a huge fan of the notes overload. happy to see them go. love the idea of moving DOM into the HTML file since that's not really part of the exercise. We should do that for all dice demos

I'm not sure if we should remove it for everything. There's a question on how much of the DOM Fluid should encapsulate. Curious what @ChumpChief thinks...

I shouldn't have mixed concerns. I'll close this and open another.


SVG image is opening on the browser not appearing in the Flutter application

Steps to reproduce
I am trying to implement SVG images in my Flutter application.
Expected results
I need to implement SVG images in my Flutter application.
Actual results
I am not getting any error messages.
Code sample
import 'package:flutter/material.dart';
import 'package:flutter_svg/flutter_svg.dart';

class Profile extends StatelessWidget {
  const Profile({super.key});

  @override
  Widget build(BuildContext context) {
    // Variable to find the size of the device screen.
    final deviceScreenWidth = MediaQuery.sizeOf(context).width;
    final deviceScreenHeight = MediaQuery.sizeOf(context).width;
    return Scaffold(
      appBar: AppBar(
        title: const Text(
          'My profile',
          style: TextStyle(
            color: Colors.white,
          ),
        ),
      ),
      body: SingleChildScrollView(
        child: Column(
          children: [
            Container(
              height: deviceScreenHeight * 0.15,
              decoration: BoxDecoration(
                color: const Color(0xffEEEEEE),
                borderRadius: BorderRadius.circular(10),
              ),
              margin: const EdgeInsets.all(10),
              child: Row(
                children: [
                  Container(
                    color: Colors.orange,
                    child: SvgPicture.asset(
                      'assets/images/profile_icon.svg',
                      // color: Colors.black,
                      semanticsLabel: 'My SVG Picture',
                    ),
                  ),
                  const Text('Name'),
                ],
              ),
            )
          ],
        ),
      ),
    );
  }
}

Screenshots or Video

Screenshots / Video demonstration

Upload media [here]

Logs
Logs
[Paste your logs here]

Flutter Doctor output
Microsoft Windows [Version 10.0.22631.3374]
(c) Microsoft Corporation. All rights reserved.

C:\Users\VISHNU PRABHAKARAN>flutter doctor
Doctor summary (to see all details, run flutter doctor -v):
[√] Flutter (Channel stable, 3.19.5, on Microsoft Windows [Version 10.0.22631.3374], locale en-IN)
[√] Windows Version (Installed version of Windows is version 10 or higher)
[√] Android toolchain - develop for Android devices (Android SDK version 33.0.0)
[√] Chrome - develop for the web
[!] Visual Studio - develop Windows apps (Visual Studio Professional 2022 17.9.4)
    X Visual Studio is missing necessary components. Please re-run the Visual Studio installer for the "Desktop
      development with C++" workload, and include these components:
        MSVC v142 - VS 2019 C++ x64/x86 build tools
         - If there are multiple build tool versions available, install the latest
        C++ CMake tools for Windows
        Windows 10 SDK
[√] Android Studio (version 2023.2)
[√] VS Code (version 1.88.0)
[√] Connected device (4 available)
[√] Network resources

! Doctor found issues in 1 category.

C:\Users\VISHNU PRABHAKARAN>

Hi @VISHNUPRABHAKARAN-7100, could you share profile_icon.svg file? Which platform are you seeing the issue on?

did you add in pubspec.yaml ?


Block behaves like CaseBlock when following Case or Default

Fixes https://github.com/davelondon/jennifer/issues/4

Codecov Report

Merging #5 into master will increase coverage by 0.54%.
The diff coverage is 63.82%.

@@            Coverage Diff             @@
##           master       #5      +/-   ##
==========================================
+ Coverage   48.11%   48.65%   +0.54%
==========================================
  Files          13       13
  Lines        1858     1901      +43
==========================================
+ Hits          894      925      +31
- Misses        917      929      +12
  Partials       47       47

Impacted Files
Coverage Δ

jen/jen.go
36.73% <0%> (ø)
:white_check_mark:

jen/comments.go
59.09% <100%> (ø)
:white_check_mark:

jen/tokens.go
67% <100%> (ø)
:white_check_mark:

genjen/render.go
98.76% <100%> (+0.02%)
:white_check_mark:

jen/lit.go
58.13% <25%> (ø)
:white_check_mark:

jen/generated.go
35.74% <52.94%> (+0.22%)
:white_check_mark:

jen/tag.go
69.69% <77.77%> (ø)
:white_check_mark:

jen/group.go
54.71% <81.81%> (+8.05%)
:white_check_mark:

jen/statement.go
84.61% <91.66%> (+4.61%)
:white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a67594...bb018c5. Read the comment docs.


Update instructions in [Configuring a subdomain] help article

What article on docs.github.com is affected?
https://docs.github.com/en/free-pro-team@latest/github/working-with-github-pages/managing-a-custom-domain-for-your-github-pages-site#configuring-a-subdomain
What part(s) of the article would you like to see updated?
Current:

To set up a www or custom subdomain, such as www.example.com or blog.example.com, you must create a CNAME file in your site's repository and configure a CNAME record with your DNS provider.

It should probably be changed to something like:

To set up a www or custom subdomain, such as www.example.com or blog.example.com, you must add your domain in the repository settings, which will create a CNAME file in your site’s repository. After that, configure a CNAME record with your DNS provider.

Additional information
Users should NOT create the CNAME file themselves, this is done automatically once they update their custom domain settings with the domain name and hence the need for this change.
If we can get the wording that would explicitly convey to users that they should NOT create the CNAME file, that will be even better
CC for visibility
@github/support-technical
@github/business-support-all

@peterjuma Thanks for opening an issue! I'll get this triaged for the right team to take a look 👀

Hi, can I take this issue?

Hi, can I take this issue?

Yes you can try to untangle the thraed
Yuliadocs<EMAIL_ADDRESS>schrieb am Sa., 9. Jan. 2021, 21:45:

Hi, can I take this issue?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/github/docs/issues/2184#issuecomment-757364703, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ASCGUT3OZNIUSR6DQYST2Y3SZC57BANCNFSM4U7UOWIQ
.

Yes you can try to untangle the thraed
Yuliadocs<EMAIL_ADDRESS>schrieb am Sa., 9. Jan. 2021, 21:45:

Hi, can I take this issue?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/github/docs/issues/2184#issuecomment-757364703, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ASCGUT3OZNIUSR6DQYST2Y3SZC57BANCNFSM4U7UOWIQ
.

You're welcome to open a PR @Yuliadocs 💖

You're welcome to open a PR @Yuliadocs 💖

Hi @Yuliadocs - I'm just checking through issues and found the timeline on this one really confusing. None of the various pull requests listed in the issue history above are relevant.
This issue is still available to work on.

Hi @Yuliadocs - I'm just checking through issues and found the timeline on this one really confusing. None of the various pull requests listed in the issue history above are relevant.
This issue is still available to work on.


Update container-instances-managed-identity.md

Managed identity in Windows containers work differently. Metadata server is not available in windows. Need to capture this in public documentation.

@tomvcassidy
Can you review the proposed changes?
Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team


Can't load the Hausa audio dataset

common_voice_train = load_dataset("common_voice", "ha", split="train+validation")

Could you provide the error details. It is difficult to debug otherwise. Also try other config. ha is not a valid.


Verification/proof of player identity

Statement of the issue
We currently have no way to verify the identity of an http request made by a client.
A system that allows 3rd party HTTP servers to know if an HTTP request was made by a genuine player would be great.
Use case
For Tone API, this would allow players to authenticate with our backend.
This would mean we can create per-player settings on the backend, and allow players to edit them using a client mod.
We would also be able to let users link their UID with Discord (using a client mod and a discord bot for example)
Linking UIDs with Discord users would mean being able to login through our website (using Oauth2) and change settings.
It would also facilitate fetching one user's stats from the discord bot, or even change settings through the bot.
Proposal
I'd suggest to use a token-based authentication system

client logins to masterserver, mastserver gives a token to the client
client sends an HTTP request containing the token to a 3rd party HTTP server
3rd party server checks authenticity of token with masterserver using an HTTP request

Informations the masterserver could return :

if the token is genuine or not
token owner UID
token expiration date.

Some thoughts:

Each third-party server should have a unique token if we do this.
Would probably use a short-lived JWT as the third-party token to reduce load on Atlas.
For linking the UID, we can (and should) add a built-in button to the lobby which opens an Atlas account page in a browser. That link would be populated during origin auth.
This will come after the API redesign.


Added 1.298 Tips for Client source

The actual source was lack of the complete 33 tips which being used in
1.298 (IDS_HELP_TIP_ALL)

Last Pull Request was wrong , although this one is the one!

Very Nice!! Welcome to the contributors list my friend!

Thank you mate!

This issue was moved to ApexKO/OpenKO#7


Fix internal API error

It doesn't like defaultValue: '' for some reason :) Please re-upload when you get time.

Looks like a job for @coldenate ;)


infra: create init.py file for Python 2 import of protobuf during tests

Description of changes:

Currently running into build issues: ImportError: No module named google.protobuf
This change adds protobuf to the dependencies for tox tests.

Merge Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

[x] I have read the CONTRIBUTING doc
[x] I used the commit message format described in CONTRIBUTING
[ ] I have added tests that prove my fix is effective or that my feature works (if appropriate)
[ ] I have updated any necessary documentation (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

found the root cause at https://stackoverflow.com/a/45141001


PR: Display plots from collections editor in the Plots pane

Description of Changes

[x] Wrote at least one-line docstrings (for any new functions)
[x] Added unit test(s) covering the changes (if testable)
[x] Included a screenshot or animation (if affecting the UI, see Licecap)

The collection editor is opened when the user edits a list, set, dict or tuple in the Variable Explorer. At the moment, plotting in the collection editor opens a new window with the plot. This PR changes this so that the plot is displayed in the Plots pane, for consistency with the namespace browser. The Plots pane is brought to the front so that users notice the new plot. However, if the user unticks the setting "Mute inline plots" in the Plots pane, then the old behaviour is restored and plots are shown in a separate window.
The collection editor is also used in several places outside the Variable Explorer:

The IPython Console uses it to show environment variables and sys.path contents. Neither of these can be plotted as far as I can see.
The oedit() function can create a collection editor. I am not sure about this function. I don't think it is used anywhere in Spyder but perhaps it is meant to be run from the Internal Console. Plotting from a collection editor created by oedit() will not work, because the signal is not connected to anything.

One niggle is that plots from the collection editor will be shown in the currently active figure browser in the Plots pane, which is associated to the currently active console. However, the variable shown in the collection editor may originate from a different console.

Issue(s) Resolved

Fixes #21145
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: Jitse Niesen

One niggle is that plots from the collection editor will be shown in the currently active figure browser in the Plots pane, which is associated to the currently active console. However, the variable shown in the collection editor may originate from a different console.

We could set the shellwidget associated to the current namespace browser in the Variable Explorer as an attribute to the collection editors opened by the user from it. Then, when plotting, we could set that shellwidget as the focused one in the console so the plot is added to the right figure browser.
Since that would represent a potentially confusing UX for users in the future, would it be possible to address it here?

@ccordoba12 It is certainly possible to do as you say, and (probably) quite easy, so I have no issue with doing it in this PR.
The disadvantage is that the plot will be hidden. Suppose that the user opens one console, opens a collections editor for one of the variables in that console, then opens another console and plots from the collections editor in the first console. You say (and I agree that is most logical) that the plot should appear in the figure browser associated with the first console. However, the figure browser associated with the second console is currently shown, so the user will not get any visual feedback on their plot command.
I honestly don't know what is best.
Another aspect is that if the collections editor is coupled to the shellwidget, further down the line we can update the values in the editor if the variable in the shell changes. I think this has been requested several times; or maybe this was only for the array and dataframe editor, but the principle is similar. I would argue this is out of scope for this PR, but if this is a direction we want to move into then that's something to take into concern.

I made the following changes after our discussions and rebased the branch:

Change the condition for determining whether plots should go in the Plots plugin or in a separate window. Plots will be displayed in the Plots plugin if the following three conditions are all met:

the Plots plugin is enabled, and
the setting "Mute inline plotting" in the Plots plugin is set, and
the graphics backend in the IPython Console preferences is set to "inline".

When plotting in the Plots plugin, raise the plugin and also the Spyder window so that the user will see the plot immediately (I believe that a further change is needed on MS Windows for this to work because the collection editor window is not properly independent from the main Spyder window).
When plotting in the Plots plugin, activate the console that the variable being plotted originates from. This brings the figure browser associated with that console to the front. The plot will be shown in that figure browser.
When plotting in the Plots plugin, honour the user preferences for inline plotting as set in IPython Console > Graphics (whether to use PNG or SVG, the figure resolution, the figure size, and whether to use a tight layout).

I am not very satisfied with how I implemented the condition that the Plots plugin is enabled. As far as I know, this can only be queried in the plugin, not in a widget. I moved the plot function from the collection editor to the namespace browser, so that it is closer to the plugin level, and then wrote the following:
class NamespaceBrowser:
    ...
    def plot(self, data, funcname):
        stacked_widget = self.parent()
        variable_explorer_widget = stacked_widget.parent()
        variable_explorer_plugin = variable_explorer_widget.get_plugin()
        if (variable_explorer_plugin.is_plugin_enabled(Plugins.Plots)
            ...

This going up to the plugin seems a bit iffy to me, but I don't also don't like any of the two alternatives that I thought of:

I can move the whole plot function to the plugin. That is the easiest to implement but my feeling is that the plugin should only contain glue code and that the functionality should be implemented at the widget level.
I can raise a signal, say check_plots_plugin_enabled. That signal propagates to the Variable Explorer plugin, which does the check and then calls yet another function at the widget level with the result of the check; that function does the actual plotting. This is perhaps the cleanest in terms of loose coupling but it requires more code and all these functions remind me of callback hell in JavaScript.

I'd be grateful for any advice on how widgets can best request information from plugins.

I am not very satisfied with how I implemented the condition that the Plots plugin is enabled.

After we discussed this a few days ago, I changed the implementation (see last commit).

After we discussed this a few days ago, I changed the implementation (see last commit).

Looks good to me now, thanks!

@ccordoba12 @jitseniesen I think this PR doesn't work with py3.8. The py3.8 tests from this PR have failed (see e.g. https://github.com/spyder-ide/spyder/actions/runs/6013236935/job/16310283258)
E     File "/home/runner/work/spyder/spyder/spyder/plugins/variableexplorer/widgets/tests/test_namespacebrowser.py", line 222
[55](https://github.com/spyder-ide/spyder/actions/runs/6013236935/job/16310283258#step:15:56)
E       return_value=mock_png) as mock_print_figure,
[56](https://github.com/spyder-ide/spyder/actions/runs/6013236935/job/16310283258#step:15:57)
E                              ^
[57](https://github.com/spyder-ide/spyder/actions/runs/6013236935/job/16310283258#step:15:58)
E   SyntaxError: invalid syntax

@impact27 Thanks, looks like the with (...): syntax that I used was only introduced in Python 3.10. I'll fix this in a couple of days.


Update rejectUnsupportedFeatures.ts

A filter is added on the visitFunctionDefinition that checks if 'this' keyword is encountered in the constructor to call the external function, and abandons the transpilation if encounters such.

Sem Tests Pass


Add support for regex string for password policy validatorPattern setting

fixes issue #3302

@bhaskaryasa This is good! Particularly thorny issue if you are using the parse-server lib directly (i.e $ parse-server /path-to-config.json). It is basically impossible to supply either a validation callback or pure regex. this fixes the regex bit. still don't think you can pass a callback in the currently documented way.
@acinader before this fix, if you submit a regex string it fails JSON validation with "unexpected token..."

@livingstonef you can provide a 'js' config file as well, as it's loaded through a require call :)

@acinader - I believe JSON parsing itself would fail if you passed something like '\xx'. That should cause the Parse Server startup failure with the exception logged.

@flovilmart - I did not know that was possible!! Nice 👍

@bhaskaryasa yeah, that'd be my guess to.  Can you please verify that the server doesn't start and that the error doesn't get eaten somehow?

@acinader - Yes, tested. Startup fails with SyntaxError: Unexpected token x in JSON at position 202.
I think we are good.

@flovilmart could you please provide an example of js file that can be used for initialization of parse-server?

// config.js
module.exports = {
  appId: "hello",
  masterKey: "world"
  /* more options */
}

parse-server ./config.js

@flovilmart thanks!


Reduce number of e2e tests to reduce VM usage

/kind test
This should reduce pressure on VM quota and save some $$$.
Merge "message of the day" test with other tests.
I also don't think we need to test all permutations of OS and Network for gpu tests. GPU and K8s Network should be unrelated.

might also consider just adding a new tag to indicate that a given scenario shouldn't be executed by default?
granted scenarios with said tag would probably just end up rotting anyways

might also consider just adding a new tag to indicate that a given scenario shouldn't be executed by default?
granted scenarios with said tag would probably just end up rotting anyways

We could use some sort of "suggestions" for when to run certain scenarios like there are in RP, but many of the tests are tied to CSE execution which could get borked for other things for no reason sometimes... so not sure how safe that would be.


Android 11 won't install

Hello westnordost!
I own two cellphones that are operated by Android 11 and have  Open GL Version 3.2
Google won't install the app,  it says that my phones are not suitable for the app.
Could you change the manifest, so that android 11 is allowed?

11 is allowed. Your device is likely not in the list of supported devices for ARCore. See https://developers.google.com/ar/devices


Process Faces dataset

Remaining / highlighted issues:

Original dataset doesn't store fine-calibration and crosstalk files according to BIDS, so not doing Maxwell filtering for now

I'd like to calculate the contrast of "face" vs "scrambled", however, to do that, I'd need to merge the "familiar" and "unfamiliar" events to "faces". We need to add support for operations like this.

Tests will fail until https://github.com/mne-tools/mne-bids/pull/680 has been merged.

Whoops this doesn't address #41! I misread the dataset used there… it wasn't ds000117! Hmm… oh well…

Whoops this doesn't address #41! I misread the dataset used there… it wasn't ds000117! Hmm… oh well…


feat(home-manager): add support for spotify-player

I have an issue with the theme:
The playback_metadata component has the same color as the background and is therefore not legible.
But this should be fixed in the catppuccin repo, right?

didn't mean to make the ci status disappear by updating the branch ^^'
here are the results of the run:
https://github.com/catppuccin/nix/actions/runs/10280254042


Resolve Issue 21 with Failing Tests

Resolved Issue #21
• Issue with failing tests as a result of Vite's native use of import.meta.env
• interfaces updated for extra backend connections
• Utilized function call to pull variables to mock the function calls in jest testing
• Modularized function calls for the various import.meta variables into separate files
• updated .env with new variables, please check documentation
🍦 To Test:

npm run dev and run through application to ensure login functionality is working as intended
npm run test to ensure all tests pass
Please ensure your .env file is up to date

Glad that the issue is fixed! Tried the fix on my machine and it appears to work here as well, thanks for addressing it


Import Error running qcluster command Python 3.7 Django 2.1.5

Traceback (most recent call last):
  File "manage.py", line 22, in <module>
    execute_from_command_line(sys.argv)
  File "ENV/lib/python3.7/site-packages/django/core/management/__init__.py", line 381, in execute_from_command_line
    utility.execute()
  File "ENV/lib/python3.7/site-packages/django/core/management/__init__.py", line 375, in execute
    self.fetch_command(subcommand).run_from_argv(self.argv)
  File "ENV/lib/python3.7/site-packages/django/core/management/__init__.py", line 224, in fetch_command
    klass = load_command_class(app_name, subcommand)
  File "ENV/lib/python3.7/site-packages/django/core/management/__init__.py", line 36, in load_command_class
    module = import_module('%s.management.commands.%s' % (app_name, name))
  File "ENV/versions/3.7.0/lib/python3.7/importlib/__init__.py", line 127, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1006, in _gcd_import
  File "<frozen importlib._bootstrap>", line 983, in _find_and_load
  File "<frozen importlib._bootstrap>", line 967, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 677, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "ENV/lib/python3.7/site-packages/django_q/management/commands/qcluster.py", line 4, in <module>
    from django_q.cluster import Cluster
  File "ENV/lib/python3.7/site-packages/django_q/cluster.py", line 24, in <module>
    from django_q import tasks
  File "ENV/lib/python3.7/site-packages/django_q/tasks.py", line 12, in <module>
    from django_q.cluster import worker, monitor
ImportError: cannot import name 'worker' from 'django_q.cluster' (ENV/lib/python3.7/site-packages/django_q/cluster.py)
Sentry is attempting to send 1 pending error messages
Waiting up to 10 seconds
Press Ctrl-C to quit

@viperfx could it have been that you were running Django 1.11?

Is this a known issue on Django 1.11?

I'm running into this issue as well...

Django 2.1.7 - Django-q 1.0.1

+1
Django-q 1.0.1
Django 2.1.4
Python 3.6.0

I have a temporary fix.
In django_q/tasks.py, replace the line :
from django_q.cluster import worker, monitor

by
from django_q.cluster import *

The manage.py qcluster command works for me.

Same with Django 2.1.7, django-q 1.0.1, python 3.6.8
Same with Django 2.1.5, django-q 1.0.1, python 3.6.8
Same with Django 2.1.0, django-q 1.0.1, python 3.6.8
Same with Django 2.1.0, django-q 1.0.0, python 3.6.8

I have same issue.
Python 3.7.2,Django              2.1.5,django-q            1.0.1

@Koed00 I think it's worth reviewing this?
Seems to be a long list of people having this issue?

Can reproduce here:

django.VERSION == (2, 2, 0, 'final', 0)
django-q version 1.0.1
sys.version is 3.7.2+ (default, Feb  2 2019, 14:31:48) \n[GCC 8.2.0]

Alternative PR created at https://github.com/Koed00/django-q/pull/356

Put your django_q app in INSTALLED_APPS after django.contrib.admin

I'm not using django.contrib.admin and am seeing this.

Guys! - had the same issue with Python 3.7.0 - and Django 2.1.7
Solved it - the issue was that I didn't have django.contrib.admin in the INSTALLED_APPS - just make sure it's there and before django_q
Cheers!

Perhaps, but that's not the real, ongoing solution. I mean, django-q should not require using the Django admin, at the very least, and the order of INSTALLED_APPS should not make any difference.


PHP Compatibility check for PHP_CodeSniffer

I would like to see PHP Compatibility check for PHP_CodeSniffer integrated in service-cli container.
https://github.com/wimg/PHPCompatibility
It is useful to validate the code compatibility with PHP7.x on old projects which worked on PHP5.x before.

@vaza18 can this exist as a project level dependency or does it have to be installed globally?

Hi @lmakarov . Yes, it can. I install it on a project level now. But theoretically it can be useful for all projects which are going to work on PHP7


let Stackable client script receive logs

When an integration test run fails on the new CI, the T2 cluster gets destroyed right away and we have difficulties analyzing what might have gone wrong. To help the devs, we'd like to extract the log files from the Stackable components via the Stackable client script to archive them along with other artifacts.

https://github.com/stackabletech/agent-integration-tests/pull/82

5 from 6 operators done, the missing one is: https://github.com/stackabletech/opa-operator-integration-tests/pull/8


[engine] Match Node requirement of Reaction

Fixes this issue:
~/C/A/force [update-node-requirement] » nvm use
Now using node v8.11.3 (npm v5.6.0)
~/C/A/force [update-node-requirement] » yarn install
yarn install v1.10.1
[1/5] 🔍  Validating package.json...
[2/5] 🔍  Resolving packages...
[3/5] 🚚  Fetching packages...
error<EMAIL_ADDRESS>The engine "node" is incompatible with this module. Expected version "8.12.x". Got "8.11.3"
error Found incompatible module

👍
merge on green

Merge on green isn't working right now


feat(edn): it's an EDN file, here's how to parse

this is why i love python, there's always a library for, "the thing"


Consolidate doc collision detection.

This removes the separate collision detection pass (in cargo_doc.rs) and uses the global collision detection instead. This removes the separate pass for running the resolver (which resulted in running the resolver four times every time cargo doc was run).
The --open option needs to know which path to open, so this is passed in a roundabout way via Compilation. Since this method uses the root units, I added a sort on the roots so that the crate that is opened is consistent between runs. This results in some slight behavioral changes.
This also makes the collision check slightly more stringent. The test doc_multiple_targets_same_name now generates an error instead of a warning because the old code did not check for collisions between libs and bins across packages (which should be very rare).

r? @alexcrichton
(rust-highfive has picked a reviewer for you, use r? to override)

@bors: r+

:pushpin: Commit 81defa6d1e83f763af139e678e8a96056af8bf74 has been approved by alexcrichton

:hourglass: Testing commit 81defa6d1e83f763af139e678e8a96056af8bf74 with merge 0c9eb206c53b062a5a138cf5a2a9bd1217665205...

:sunny: Test successful - checks-actions
Approved by: alexcrichton
Pushing 0c9eb206c53b062a5a138cf5a2a9bd1217665205 to master...


A clear statement should be provided when authentication fails

The aliyuncli ecs DescribeInstances gives SDK.InvalidRegionId and Can not find endpoint to access when authentication fails. It would be much better and clear if aliyuncli provides a statement like "SDK.InvalidCredentials" or something like "Authentication failure".
Test code:
[cheshi@cheshi-desktop1 ~]$ aliyuncli configure
Aliyun Access Key ID [****************tdse]:
Aliyun Access Key Secret [****************FXOw]: BadCredentialsHere
Default Region Id [us-west-1]:
Default output format [json]:
[cheshi@cheshi-desktop1 ~]$
[cheshi@cheshi-desktop1 ~]$ aliyuncli ecs DescribeInstances
{
"Message": "Can not find endpoint to access.",
"Code": "SDK.InvalidRegionId"
}
Detail of Client Exception:

SDK.InvalidRegionId Can not find endpoint to access.

The aliyuncli ecs DescribeInstances gives SDK.InvalidRegionId and Can not find endpoint to access when authentication fails. It would be much better and clear if aliyuncli provides a statement like "SDK.InvalidCredentials" or something like "Authentication failure".
Test code:
[cheshi@cheshi-desktop1 ~]$ aliyuncli configure
Aliyun Access Key ID [****************tdse]:
Aliyun Access Key Secret [****************FXOw]: BadCredentialsHere
Default Region Id [us-west-1]:
Default output format [json]:
[cheshi@cheshi-desktop1 ~]$
[cheshi@cheshi-desktop1 ~]$ aliyuncli ecs DescribeInstances
{
"Message": "Can not find endpoint to access.",
"Code": "SDK.InvalidRegionId"
}
Detail of Client Exception:

SDK.InvalidRegionId Can not find endpoint to access.

Hi, we have update in lastest version. So we recommend that you update to the latest version. If you have any other questions, please contact with us.
Thank you for your attention to AliCloud CLI Project!

The aliyuncli ecs DescribeInstances gives SDK.InvalidRegionId and Can not find endpoint to access when authentication fails. It would be much better and clear if aliyuncli provides a statement like "SDK.InvalidCredentials" or something like "Authentication failure".
Test code:
[cheshi@cheshi-desktop1 ~]$ aliyuncli configure
Aliyun Access Key ID [****************tdse]:
Aliyun Access Key Secret [****************FXOw]: BadCredentialsHere
Default Region Id [us-west-1]:
Default output format [json]:
[cheshi@cheshi-desktop1 ~]$
[cheshi@cheshi-desktop1 ~]$ aliyuncli ecs DescribeInstances
{
"Message": "Can not find endpoint to access.",
"Code": "SDK.InvalidRegionId"
}
Detail of Client Exception:

SDK.InvalidRegionId Can not find endpoint to access.

Hi, we have update in lastest version. So we recommend that you update to the latest version. If you have any other questions, please contact with us.
Thank you for your attention to AliCloud CLI Project!

Tried with release 3.0.10, it has been fixed. Thanks!
$ aliyun ecs DescribeInstances
ERROR: SDK.ServerError
ErrorCode: IncompleteSignature


Add Video block to use in stream fields

Thanks for this, I've used most of the code from this merge request in #51, rather than getting you to rebase and remove the draft status

Thanks for this, I've used most of the code from this merge request in #51, rather than getting you to rebase and remove the draft status


HoodieDeltaStreamer doesn't support parquet files as source

I noticed that the option --source-format for the deltastreamer has the possible values: [AVRO, JSON, ROW, CUSTOM]. So my questions/problems are:

Is there parquet support planned in the future or is there already an implementation/some workaround that I can use?

The comment for SourceDataFormat.ROW states that it will be added later, but the one for CUSTOM does not, even though I cannot see an implementation for that.

Trying to change the source-format by adding the option --source-format AVRO always throws an Exception for me:

Exception in thread "main" java.lang.NullPointerException at com.beust.jcommander.JCommander.convertValue(JCommander.java:1305) at com.beust.jcommander.JCommander.convertValue(JCommander.java:1228) ... at com.uber.hoodie.utilities.deltastreamer.HoodieDeltaStreamer.main(HoodieDeltaStreamer.java:415)

Hey. thanks for a taking a look at the deltastreamer.
On Parquet:

Its currently is ingestion centric, thats probably why it does not support parquet yet...
if you are looking to just do a one-time parquet import, the HDFSParquetImporter could help. There is a CLI command..
you can always just use the datasource and wrap it in your own Spark job.

Actually there is planned work to rework the deltastreamer to simply use Spark data source API and move away from RDD level APIs it uses. That should fix most of your first two issues.. How hard is it for you to try the datasource api in the mean time? Longer term, we are planning integrations with Apache Gobblin and also uber's own ingestion system would be open sourced soon - which will work with Hoodie out-of-box. (again none of these support Parquet source, since users mostly write their own spark jobs for etls)..

Thanks for the reply. I can also use avro as a source-format, I just wanted to check whether there is parquet support, so I don't do any unnecessary work.

Hi @vinothchandar, I am working with @cb149 on applying Hudi in our production. We are looking for supporting DeltaStreamer for parquet. Is this duplicated with #429 which is about generalizing data source by using Spark data source API?
My question is also how hard is refactoring the code by using spark datasource api v2 fashion.

#429 has some open issues which I don't know how to proceed..
I think the short term approach for parquet source makes sense to me.. @bvaradar is currently doing some work on an HoodieIncrementalSource, which consumes incrementally from an upstream hoodie dataset. Would this help with your usecase?
Or do you need source as raw parquet files? I vaguely remember discussing an alternate solution for use case with someone on slack (not sure if its @cb149) .. Let's assume you are currently reading from source system X (which may be kafka, kinesis..) and writing out parquet. Instead of reading these parquet files and writing using deltastreamer (your ask in this issue), could be just have deltastreamer read from X directly and write a hoodie dataset? Then, it also becomes easy to compare the two datasets (plain parquet and hoodie) head-head for freshness, correctness etc..
if above don't suffice, yes. Happy to support a ParquetDFSSource . Let me know.. :)

Thank you @vinothchandar !
Consumes incrementally from an upstream hoodie dataset might not be in our usecase. Since, we still need to do one-time parquet import for incremental changes periodically.
For our case, we dump avro messages in Kafka to HDFS (parquet files) by using Kafka Connect. As you said, we could directly have deltastreamer to read Avro from Kafka using AvroKafkaSource. I will try this first. If it doesn't work, I'll try to support a ParquetDFSSource.

@vectorijk Were you able to use AvroKafkaSource to address your use-case ?

Moved to https://issues.apache.org/jira/browse/HUDI-40


Driver liberty tempest tests need to be added to nightly test run

Description
There exists tempest tests in the liberty branch, but they are not yet running in nightly. We need to get them into the run_neutron_lbaas.sh script and ensure they become a part of our nightly test run.

See commits in master.


Fixe req.body example

http://expressjs.com/api.html#req.body
We should be able to remove the multer reference... I think this was a copy/replace error. Or we need to fix the usage. multer has a set of methods like multer.single('avatar') to populate req.file and similar.
@crandmck @hacksparrow

Also see: https://github.com/strongloop/express/issues/2762

Looks like the issue is not with our docs--they were fine, but what happened was multer released a 1.0.0 with breaking changes. You can see the old docs (https://github.com/expressjs/multer/tree/7f6d840bd3a3ce6b4d81b1fb230e999880cc8438#usage) shows app.use(multer()) which works if you install the pre-1.0 versions.
I think the documentation should make it clear what version of third-party module are being used in the examples when we provide them, so that this doesn't keep popping up :)

Updated the example and indicated the multer version in a comment.

Since the other issue was closed without a response? @ritch
let fd = new FormData(document.querySelector('form'));
let xhr = new XMLHttpRequest();
xhr.open('POST','https://www.somewhere.com/url');
xhr.send(fd);

This results in a multipart/form-data request to the endpoint that might be setup with express (without a way to change the encoding type from my research), so I would say an example needs to be made for this use case. This is how to deal with it though:
let multer = require('multer');
let formDataMiddleware = multer();

app.post('/url', formDataMiddleware.array(), (req, res) => {
  console.log(req.body); // req.body is populated with form inputs
});

@silenceisgolden the example has already been updated. Please take a look - http://expressjs.com/4x/api.html#req.body.

looks good, thanks


Embeds break on some URLs

Bug
When playing back a video from a Twitter embed, it some times breaks.
To Reproduce
Embed a video on Twitter (https://twitter.com/kcsebby/status/1340086993330581505)
Playback the video within that Twitter embed.
See error.
Expected behavior
Should playback without showing the search button, hamburger menu, etc.
Screenshots

Additional context
Upon refresh, and second attempt at playback, the issue went away. Was able to replicate it again by refreshing a few more times.

Thanks for filing ,def a strange one! We've seen it break with some special characters before, but not the case here. We'll take a look.

@kcseb What OS/browser are you using?

Windows 10 - Firefox 83.0 (x86_64)
On 18 December 2020 21:17:13 Sean Yesmunt<EMAIL_ADDRESS>wrote:

@kcseb What OS/browser are you using?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

Broken one on this page https://lemediaen442.fr/a-quoi-ressembleront-les-emplois-de-demain-selon-le-forum-economique-mondial/

This should be fixed now with a hotpatch from Sean.

The issue is actually worst, no movies are showing up on theirthe link given by @kauffj above

@seanyesmunt embed fix was incomplete. It fixed most of them, but this one is now entirely broken:
https://lemediaen442.fr/a-quoi-ressembleront-les-emplois-de-demain-selon-le-forum-economique-mondial/

In firefox, I see (also happens in other browsers, but works there)  Uncaught TypeError: $ is not a function     <anonymous> https://lemediaen442.fr/a-quoi-ressembleront-les-emplois-de-demain-selon-le-forum-economique-mondial/:1029 a-quoi-ressembleront-les-emplois-d
Seems to work fine in Opera/Chrome/Brave here.

sorry I am not a developper, just publisher... If I understood well, something in the link is not working properly?

Is it still broken for you? Can you show a screenshot of what it looks like? Also, if you can, press ctrl-shift-I to bring up the side bar, go to the console tab, then refresh and take a screenshot of that.

Is it still broken for you? Can you show a screenshot of what it looks like? Also, if you can, press ctrl-shift-I to bring up the side bar, go to the console tab, then refresh and take a screenshot of that.

Sorry, I was replying to the other user having the issue on his site! I think we fixed most cases.

Sorry, I was replying to the other user having the issue on his site! I think we fixed most cases.

"Content not found" here for me : https://lemediaen442.fr/allemagne-il-est-statistiquement-tres-probable-que-les-gens-ayant-ete-vaccines-meurent/

"Content not found" here for me : https://lemediaen442.fr/allemagne-il-est-statistiquement-tres-probable-que-les-gens-ayant-ete-vaccines-meurent/

We found the problem with this video embeded on the webpage mentionned above. The video URL was https://odysee.com/@TraductionEn442:a/Warning_Head_of_Gov't_Health_Agency_Admits_in_Advance_People_VOSTFR:8 and the apostrophe in the URL (Gov't) was breaking the embeded code not showing then the video.

We found the problem with this video embeded on the webpage mentionned above. The video URL was https://odysee.com/@TraductionEn442:a/Warning_Head_of_Gov't_Health_Agency_Admits_in_Advance_People_VOSTFR:8 and the apostrophe in the URL (Gov't) was breaking the embeded code not showing then the video.

Glad you found that, the share urls for those should be fixed soon.

Glad you found that, the share urls for those should be fixed soon.


feat(mfi-v2-xnft): updates to xNft & jupiter implementation

Jupiter implementation for the marginfi Xnft

holding off on the rebasing from main in the target branch as it's a non-trivial one
let me know when what we discussed in ready and I'll merge here first


InternVL−Chat−V1.5-Int8 inference is slow

Hi @all
Thank you for your good work!
I notice using the InternVL−Chat−V1.5-Int8 model, the inference time is very slow, as mentioned in link
Do you support using lmdeploy to improve the inference speed or or any method to improve the inference speed?
Thanks in advance.

Using the 4-bit model quantized by AWQ is recommended, which is very fast and occupies less GPU memory than int8.

https://huggingface.co/OpenGVLab/InternVL-Chat-V1-5-AWQ

from lmdeploy import pipeline
from lmdeploy.messages import TurbomindEngineConfig
from lmdeploy.vl import load_image

model = 'OpenGVLab/InternVL-Chat-V1-5-AWQ'
image = load_image('https://raw.githubusercontent.com/open-mmlab/mmdeploy/main/tests/data/tiger.jpeg')
backend_config = TurbomindEngineConfig(model_format='awq')
pipe = pipeline(model, backend_config=backend_config, log_level='INFO')
response = pipe(('describe this image', image))
print(response)

or service
lmdeploy serve api_server OpenGVLab/InternVL-Chat-V1-5-AWQ --backend turbomind --model-format awq


Better examples for tracing

chore: Update rust-cli references to clap-rs

Since we moved the repo to clap-rs org, I went and updated the references.

docs(examples): Update examples

I have updated the tracing example to be much more simpler.

Thanks! No need to do this "conventional commit" stuff though! :smile:

Because we moved it to clap-rs org. I have merge permissions too but will wait for epage to take a look.


Single quotes in image URL is not working

I am using this image as css background https://images.activityhero.com/activity_photo/4859/large/It's_yoga_kids_group.jpg, But when i passed it to the data attribute as escaped URL like this https://images.activityhero.com/activity_photo/4859/large/It\'s_yoga_kids_group.jpg.
It hits the encoded version of URL https://images.activityhero.com/activity_photo/4859/large/It%5C's_yoga_kids_group.jpg", in the dummy image tag and thus it fails to load and it results in no image in background.

You are kind of asking trouble by using special characters in URL. It would be better just to use URL safe characters.


Stats and balance disappearance

Hello! I was checking my wallet om Tuesday and realized that my stats and money balance have disappeared randomly. I had 195 stats and $75 dollars in Canadian. My significant other gave me the stats/balance on Sunday via Lighting.

Here! Screenshots in order:
Payment details
Me receiving payment
After Sunday, my stats disappeared.

Can you provide logs? It is in the Settings > Emergency Kit
Also have you tried restoring from seed?

mutiny-logs.txt

I don't see you ever creating an invoice in your logs. Are you sure this is the original wallet you used to receive? Have you tried restoring from your seed words?

Also I see you have hodl invoices enabled, that is not recommended

I don't see you ever creating an invoice in your logs. Are you sure this is the original wallet you used to receive? Have you tried restoring from your seed words?

Yes, it is the original wallet I used to receive but I haven't tried restoring.

Ben, I restored my wallet as you mentioned and it worked.


Handle OpenTracing key-value logging, finished work in PR #25

This PR finishes the work started in PR #25 and handles OpenTracing key-value logging in the same way as Jaeger. If only a single key-value log Field exists with key "event", the payload of the log Field will be used instead of a JSON object with log Fields.

we should probably add to the README a big caution on encoding json, as it will screw up other tooling, such as datastore-layer queries which are used in the zipkin ecosystem. Here's a note about this https://github.com/openzipkin/openzipkin.github.io/issues/52#issuecomment-249749327
Another option is to open a hook for a formatter, similar to most logging libraries, such that people can avoid this problem.


changes if your site isn't actually in the root of the git repo

The git structure at my company makes the laravel website under directory a subfolder under git like so:
+site
  app/
  artisan
  bootstrap/
  etc
+docs
+ide_lint_setup

but alot things will then fail like 'composer install --no-dev' needs to run from the site/ directory. same for things like 'php artisan migrate', or setting up of the sym-links to the shared files/directories.
Is there something currently can do to alleviate this?
For another capistrano-like deploy system (Deployer.org), I setup a custom task to temporarily change the release_path variable before the laravel specific tasks (to something like releases/#/site/ ) and then changed it back at the end to the original main path so the sym-link to the main releases/# could be setup.  For example in Deployer.org, i did this:
after('deploy:update_code', 'change_to_custom_site_dir'); //changed the release_path temporary
before('deploy:symlink', 'change_to_original_release_dir');//changed back to orig release_path
The other solution was ugly. For each task I could cd into that custom dir. But that would mean i copy 9 or so default/defined task's code into my code just to add a cd command to the top of it. Lots of code just to change a directory for each task (and i would override and therefore not get any updates to those default tasks).
Not sure if a temporary solution like above can be setup (and if so, before/after which tasks?).
Or a more permanent solution where you can specify a custom variable for release_site_path where certain command/tasks cd into before doing their things.

As for the shared directories, overriding the following should accomplish that: :laravel_4_linked_dirs, :laravel_5_linked_dirs, :laravel_4_acl_paths, and :laravel_4_acl_paths. Though, for the .env file and artisan commands, we'd have to extract those out to become variables for the paths. Right now they expect the project directory to be the top dir.


400 bad request

hi guys,
i have some troubles with this gem, it return error 400, sometimes 401 and 403.
someone have this little piece of code who work ?
or know where is my error ?
require "woocommerce_api"

api = WooCommerce::API.new(
  "https://xxx.co",
  "ck_",
  "cs_",

  {
    version: "v3",
  }
)

p api.get("").parsed_response

thanks guys
i give roses for my hero

Responses comes from the server you are making the requests. Sometimes your server have something blocking or just doing bad requests. But doesn't sounds like an issue with this library, even more because you are using HTTPS and there's no need to build a oAuth1.0a request, so sounds like it's something in your server, try check the access log and error log for the requests, also check if is getting blocked by mod_Security or something like, even CloudFlare could influence. I hope you can solve it.


Fix cargo tree bug + CICD issues

adds work-around for bugs caused by absorption of cargo tree into cargo
ref: GH:rust-lang/cargo#8062
Fixes: #1478

I'll merge this as soon as the AppVeyor CI completes successfully.


Input syntax

Since this is a resource containing from scratch, guide about input also in the basics notebook

Sure


Url schema out of date?

This page states that for VSTS, urls for workitems follow this pattern: _workitems?id=133&_a=edit
On the subdomains on visualstudio.com that I have access to, the url pattern is: _workitems/edit/133 and the former is not recognized.
This must have changed some time between two versions of VSTS?
Do all subdomains on visualstudio.com run the same version of VSTS and do they have the same url scheme?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a2a2fa2c-bdbd-3357-1f4f-ff6504367404
Version Independent ID: aba4b3e9-7572-e1f1-e618-291fbd5b704f
Content: Define the hyperlink for a work item - VSTS & TFS
Content Source: docs/work/work-items/work-item-url-hyperlink.md
Product: devops
GitHub Login: @erickson-doug
Microsoft Alias: kaelli

@skovsboll - Thank you for the feedback.  All subdomains on visualstudio.com should run the same version of VSTS and have the same url scheme. I'm updating the article to reflect the URL change for VSTS.


DecalBatch rare crash when sorting tons of close decals

Please ensure you have given all the following requested information in your report.
Issue details
The current implementation of the Comparator in the CameraGroupStrategy class causes a crash when floating-point errors happen.
The issue is in the following code snippet:
this.cameraSorter = new Comparator<Decal>() {
    @Override
    public int compare (Decal o1, Decal o2) {
        float dist1 = CameraGroupStrategy.this.camera.position.dst(o1.position);
        float dist2 = CameraGroupStrategy.this.camera.position.dst(o2.position);
        return (int)Math.signum(dist2 - dist1);
    }
};

The casting to an integer after calling Math.signum on the difference can lead to inconsistencies in the comparison.
A solution to this is to simply use Float.compare instead like so:
this.cameraSorter = new Comparator<Decal>() {
    @Override
    public int compare(Decal o1, Decal o2) {
        float dist1 = CameraGroupStrategy.this.camera.position.dst(o1.position);
        float dist2 = CameraGroupStrategy.this.camera.position.dst(o2.position);

        return Float.compare(dist2, dist1);
    }
};

Changing this prevents the crash from occuring.
Reproduction steps/code
Spawn tons of particles very close together such that a floating-point error is likely to occur.
Version of libGDX and/or relevant dependencies
1.12.0
Stacktrace
Exception in thread "main" java.lang.IllegalArgumentException: Comparison method violates its general contract!
	at com.badlogic.gdx.utils.TimSort.mergeHi(TimSort.java:791)
	at com.badlogic.gdx.utils.TimSort.mergeAt(TimSort.java:449)
	at com.badlogic.gdx.utils.TimSort.mergeForceCollapse(TimSort.java:396)
	at com.badlogic.gdx.utils.TimSort.doSort(TimSort.java:138)
	at com.badlogic.gdx.utils.Sort.sort(Sort.java:59)
	at com.badlogic.gdx.utils.Array.sort(Array.java:433)
	at com.badlogic.gdx.graphics.g3d.decals.CameraGroupStrategy.beforeGroup(CameraGroupStrategy.java:137)
	at com.badlogic.gdx.graphics.g3d.decals.DecalBatch.render(DecalBatch.java:143)
	at com.badlogic.gdx.graphics.g3d.decals.DecalBatch.flush(DecalBatch.java:135)
	at rpg.client.graphics.ParticleSystem.renderDecals(ParticleSystem.java:96)
	at rpg.client.RpgClient.render(RpgClient.java:892)
	at com.badlogic.gdx.backends.lwjgl3.Lwjgl3Window.update(Lwjgl3Window.java:387)
	at com.badlogic.gdx.backends.lwjgl3.Lwjgl3Application.loop(Lwjgl3Application.java:192)
	at com.badlogic.gdx.backends.lwjgl3.Lwjgl3Application.<init>(Lwjgl3Application.java:166)
	at rpg.client.desktop.DesktopLauncher.main(DesktopLauncher.java:59)

Please select the affected platforms

[X] Android
[X] iOS
[X] HTML/GWT
[X] Windows
[X] Linux
[x] macOS

The only thing Float.compare() does differently, as far as I can tell, is handle the case when one or both of its inputs are NaN. What could be the issue here has to do with comparison with NaN in general, which is... a mess. With the signum appoach, if either distance is NaN, then the difference between the distances is NaN, signum(NaN) is also NaN, and (int)NaN is 0, signifying everything is considered equivalent to a NaN distance. That would break the contract for sure. If you have NaN positions, switching to Float.compare() will fix their positions in a sort, arguably, but will not fix the other issues inherent in having NaN in with your other values.
I think you should try to catch the IllegalArgumentException and get a complete log of all Camera and Decal positions when this happens. Ideally, you'd also have the data of which Decals were being compared when the crash happens. If nothing anywhere is NaN, then the issue could be in how dst() is calculated -- it returns NaN if the squared distance is somehow less than 0, though I don't know how that could happen given that the squared distance should always be >= 0 .

I'll debug it and take a look at what exactly is going on.

This is definitely caused by a problem in my code. Decal's were having their position set to NaN. I'm going to close this issue but it may be a good idea to support decals having a NaN position. Rendering something with an inifinite or NaN position doesn't usually crash things, they just don't appear. It may be a good idea for DecalBatch to also be consistent with this. Cheers!


TFRecordReader num_records_produced() and num_work_units_completed() do not work

Hey guys, since I've been dealing a lot with TFRecord files lately, I stumbled upon the following bug:
file_queue = init_queue(dataset)

records_reader = tf.TFRecordReader(name='...')

_, record = records_reader.read(file_queue, name='...')

 #do something with record in a while loop

And when I call the two aforementioned functions they always return 0. I am sure I have used the records since I have seen the end results dumped to an excel spreadsheet.
Cheers, Kris

Can it be so that within a while loop one and the same parsed record gets used and this does not trigger queues?

mrry already answered on stackoverflow. Many thanks and this thread can be closed now


Updated ReadME.md

Fixed typos and grammatical errors in ReadME.md file. This PR has been made as a part of Hacktoberfest.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


[BUG] 应用顶部栏不能用鼠标进行拖动

Version Check

[x]  I have checked and the version I'm running is up to date.

State Check

[x] I have tried right click and menu have shown.
[x]  I can see the splash or loading screen.

Duplication Check

[x]  I have searched the issue list and haven‘t found any imformation about my issue.

Describe the bug
应用顶部栏不能用鼠标进行拖动
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
鼠标可以进行拖动
Screenshots
If applicable, add screenshots to help

如图所示,没有可以进行鼠标拖动的地方
Desktop (please complete the following information):

OS: macos 13.6.3 (22G436)
Program Version 版本0.4.3 (0.4.3)

Additional context
Add any other context about the problem here.

补充下intel 芯片的mac os

刚才发了个新版本，你可以试一下，顺便帮我看看macos上的图标是不是方块形的图标

已经修复了, 图标也是方块的


End-to-End Streaming Tests in botbuilder-js

Fixes #2226
Description
PR automates the testing of botframework-streaming's compatibility with browsers.

This is done using a React app that uses DLJS and a bot that both point to the latest preview versions of botframework-streaming. They communicate by enabling DL ASE.
Tests are automated using Azure Pipelines as well as leveraging Selenium WebDriver to automate browser testing

Specific Changes
E2E Streaming Tests Architecture

E2E Streaming Tests Pipeline here (currently under temporary name "[experimental]E2E_Streaming_Test_Ashley")
Running the pipeline will:

Provision & Deploy Projects:

Bot: point bot to use the daily build of botframework-streaming (latest preview version)
React App:

Provision a brand new react app via npx create-react-app command
Set up the React app to use WebChat (ReactWebChat)
Install a custom version of DirectLineJS (DLJS) into the app

Configures DLJS to use the latest botframework-streaming preview version

Run Tests

Downloads the browser-appropriate Driver necessary for Selenium WebDriver to automate testing in a browser (Chrome)
Runs the tests that have React and bot talk to each other

See README for further details of PR, if wanted.
Testing

It's all green!

This PR is already large enough, and it only tests 1 scenario (webpack'd project + chrome browser). In future expansions of streaming tests, we could include the following (detailed per William):
Different Build Scenarios:

Use create-react-app (CRA) without WebChat, just talk to bot using DLJS
Use webpack without CRA
Add Rollup in addition to webpack

Different Browsers:

Edge UWP
Edge Chromium
Firefox
IE11
macOS Safari
iOS Safari
Android Chrome

The expansion should go more quickly now that this PR lays down the foundational infrastructure for E2E testing of streaming bits (at least for adding additional browsers to test against).

Pull Request Test Coverage Report for Build 149629

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 81.606%

Totals

Change from base Build 149594:
0.0%

Covered Lines:
13380

Relevant Lines:
15640

💛  - Coveralls

Updated:

Removed chromedriver installation ✔

The image already has chrome & chromedriver installed and maintains compatible versions for them
w00t! taken care of before R11 🎊

Removed OnMembersAdded handler from bot to speed up testing time dramatically in Azure Pipeline environment

Details

Times running Selenium tests vary wildly on in Pipelines (27s - 3+ min) versus on my own computer (20s)--we're at the mercy of whatever build machines the pipeline's tasks land on and pray for a good one

Removing extra cruft so that tests could run faster and complete in a more reasonable time

Cleaned up configure-to-bbjs-daily.yml (it repeats a step one less time) ✔

To work around the issue of Azure Pipelines not expanding nested YAML variables, just did the get&set from w/in one PS script, so we didn't need to repeat steps in YAML

Mocha tests now use pipeline variable instead of me writing value to .env ✔

Could not get: react app to pull from pipeline variables ❌

I imagine this has something to do with the react app being in browser and/or not having access to the pipeline variables once deployed to App Service
For R11, once we do the work for hosting the react app locally, I'll see if it's possible then...but it seems like from researching, their docs pointed to using a .env for react apps and must be prefixed with REACT_APP_ in the variable name or using webpack with DefinePlugin

Hmm, looks like I need to provide more timeout time, so I'll update that too. Like I mentioned, sometimes it completes within 30 s., sometimes it takes minutes, just depending on the agent it lands on...


No paging for long community lists.

On community pages with more than 20 "Communities of this Community", there is no way to navigate beyond those first 20.  No paging options, no previous nor next buttons.  See the screenshot.  There are more than 150 sub-communities here.

Closing this issue as this was already implemented in #505


"Error in HTTP connection"

I installed today the current version of mitm (v0.14) on ArchLinuxARM on Raspberry Pi and installed certificates in FireFox browser on other ArchLinux machine by opening the "mitm.it" site and clicking the "Other" icon. I start mitmdump with the command:
mitmdum -b localhost -p 12345 -q
When I open various sites, I get in stodut on Raspberry Pi many error messages like these:
<IP_ADDRESS>:40142: ProtocolException("Error in HTTP connection: TlsException('',)",)
<IP_ADDRESS>:40148: ProtocolException("Error in HTTP connection: TlsException('',)",)
<IP_ADDRESS>:40150: ProtocolException("Error in HTTP connection: TlsException('',)",)
<IP_ADDRESS>:40158: ProtocolException("Error in HTTP connection: HttpSyntaxException('Bad HTTP request line: \\x81\\xc1\\xcd~z\\x90\\xb1/\\x0f\\xf5\\xbe',)",)
<IP_ADDRESS>:40176: ProtocolException("Error in HTTP connection: TlsException('',)",)
<IP_ADDRESS>:40184: ProtocolException("Error in HTTP connection: TlsException('',)",)
<IP_ADDRESS>:40186: ProtocolException("Error in HTTP connection: TlsException('',)",)
<IP_ADDRESS>:40188: ProtocolException("Error in HTTP connection: TlsException('',)",)
<IP_ADDRESS>:40192: ProtocolException("Error in HTTP connection: TlsException('',)",)
<IP_ADDRESS>:40198: ProtocolException("Error in HTTP connection: TlsException('',)",)
<IP_ADDRESS>:40102: ProtocolException("Error in HTTP connection: TcpDisconnect('[Errno 32] Broken pipe',)",)
<IP_ADDRESS>:40206: ProtocolException("Error in HTTP connection: TlsException('',)",)
<IP_ADDRESS>:40208: ProtocolException("Error in HTTP connection: TlsException('',)",)
<IP_ADDRESS>:40210: ProtocolException("Error in HTTP connection: TlsException('',)",)
<IP_ADDRESS>:40216: ProtocolException("Error in HTTP connection: TlsException('',)",)
<IP_ADDRESS>:40218: ProtocolException("Error in HTTP connection: TlsException('',)",)

I searched the web but there is no results for such error messages. Is this problem a known one and there is some standard solution to it?

Thanks for the report. Just to clarify - the websites you open work normally, you're only wondering why there are error messages?

The sites seem to work normally, but I supposed that if error messages are reported, then something 'under the hood' may be not normal.

Thanks. These errors indicate timeouts, SSL errors or disconnects, so if you don't observe any obvious issues there's nothing to worry about.
It looks like we accidentally increased the error verbosity with the latest release - that is something we should fix, so I'll leave this issue open.

This should be fixed now. If I missed something, please let me know!


Add Python requirements.txt

This pull request moves the list of python dependencies from install_dependencies.sh into requirements.txt.  There are a few reasons to do this:

With the dependencies defined outside of the install script, it's possible to install them or easily read the list of dependencies with other tools without running the install script. For example, the reason I am making this PR is that in the PKGBUILD for the Arch User Repository package I maintain, I can just do pip install -r requirements.txt. Currently, I have pretty much the same 8 pip install lines that you have in install_dependencies.sh. If these lines are changed in kiri without my noticing, the AUR package would break.
Having a requirements.txt file (or setup.py file) is the Python standard
It should be faster to only invoke pip once with the full list of dependencies

This pull request moves the list of python dependencies from install_dependencies.sh into requirements.txt. There are a few reasons to do this:

Ok.

Ok, I am fine with this one
I don't care
Nah, it is run just once.

Here is your requirements.txt
grep "yes | pip" install_dependencies.sh | cut -d"\"" -f2

I don't like this file because it uses a silly name. Not even a creative one. The name requirements.txt means nothing. If it was at least python_requirements.txt I will think it is ok.
Are you ok if we name this file python_requirements.txt?


Studio V6 Integration

changing session storage depending on what is given from parent iframe

Codecov Report
Attention: Patch coverage is 0% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 65.87%.  Consider uploading reports for the commit 3a3b33d to get more accurate results

Files
Patch %
Lines

src/App.vue
0.00%
4 Missing :warning:

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1288   +/-   ##
=======================================
  Coverage   65.87%   65.87%
=======================================
  Files         189      189
  Lines       20132    20132
  Branches     4334     4334
=======================================
  Hits        13261    13261
  Misses       6871     6871

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

I think there is more to this....
We have logic that allows to attach to the old session. Where is that logic? Is that logic affected?
With that "setItem('session_id')", we're again "spreading around" the session id logic. I would like all logic that touches the session id to be accumulated in one place, not having to hunt it down between the place where we have it no, to here.

Fixed


Rate Limiter has initialization race condition

I've been looking into why the TestROService Go end-to-end test often fails with a rate limit error. It only makes one API call but it makes that call pretty much immediately:
func TestKubernetesROService(c *client.Client) bool {
	svc := api.ServiceList{}
	err := c.Get().
		Namespace("default").
		AbsPath("/api/v1beta1/proxy/services/kubernetes-ro/api/v1beta1/services").
		Do().
		Into(&svc)

Now that a fresh client is created for each test, we can encounter a race where the channel used to represent tokens for service availability are not yet pre-charged before a client can make a call. Here is the code in handler.go that checks for tokens:
// RateLimit uses rl to rate limit accepting requests to 'handler'.
func RateLimit(rl util.RateLimiter, handler http.Handler) http.Handler {
	return http.HandlerFunc(func(w http.ResponseWriter, req *http.Request) {
		if rl.CanAccept() {
			handler.ServeHTTP(w, req)
			return
		}
		w.WriteHeader(http.StatusServiceUnavailable)
		w.Header().Set("Retry-After", "1")
		fmt.Fprintf(w, "Rate limit exceeded.")
	})
}

The problem is the cl.CanAccept() can be called before the token channel is populated. The rate limiting is done in throttle.go and here are some relevant snippet.
First, the code that creates the ticker. This will insert tokens into the ticker channel at the QPS rate.
func NewTokenBucketRateLimiter(qps float32, burst int) RateLimiter {
	ticker := time.Tick(time.Duration(float32(time.Second) / qps))
	rate := newTokenBucketRateLimiterFromTicker(ticker, burst)
	go rate.run()
	return rate
}

The initialization will pre-charge the channel to provide a window in which a burst is permitted as long as the QPS is not violated over a window that is the size of the burst.
func newTokenBucketRateLimiterFromTicker(ticker <-chan time.Time, burst int) *tickRateLimiter {
	if burst < 1 {
		panic("burst must be a positive integer")
	}
	rate := &tickRateLimiter{
		tokens: make(chan bool, burst),
		ticker: ticker,
		stop:   make(chan bool),
	}
	for i := 0; i < burst; i++ {
		rate.tokens <- true
	}
	return rate
}

The problem is that there is a short period where neither the first tick nor the pre-charge have been executed but a request could already have been made -- which would be rejected (incorrectly) for rate limit reasons.
Hopefully the Retry-After PR #3704 that I submitted will mask this situation.
@filbranden

I don't actually see what the race condition is here, we fill up the channel with tokens before we return the rate limiter, so the channel has to be full of tokens to be used up.  How can the pre-charge not have finished, we run it in a for loop before we return the rate limiter?

Good point: I mis-understood the code to think that the rate limit could be accessed earlier -- but no -- it has to be returned before it is used. Which then makes the ROService behaviour even more mysterious. How can a test that makes exactly ONE API call run foul of the rate limiter? Will look more closely.

@brendandburns Let me explain a but more my confusion. This is where you return the rate limiter:
func NewTokenBucketRateLimiter(qps float32, burst int) RateLimiter {
	ticker := time.Tick(time.Duration(float32(time.Second) / qps))
	rate := newTokenBucketRateLimiterFromTicker(ticker, burst)
	go rate.run()
	return rate
}

What pre-charges the channel with tickeds? The goroutine that asynchronously runs rate.run() relative to this function. So I thought the returned rate could be used before the goroutine had a chance to fill up the channel.


Editing Strings causes them to be moved to newline

When i edit string variables using this .vimrc, it always moves the string to a new line below the variable that im assigning it to
this cause lots of problems in my shell scripts

@AddAndy please provide more info such as Vim version, language you are editing, and a concrete example of the issue you are having.


New casks for lytro, neat and flixster

I revised the casks based on fanquake's feedback and the rubocop style warnings.

In the future, please submit separate pull requests for each cask, as more often than not this type of pull request brings problems with one or more of them, and it halts the inclusion of the other ones.
In this case there are multiple issues. Will be pointed out in the relevant lines.

Updated with requested changes.

Thank you, @dwaite. Looks great.

Weird. Github seemed to have screwed up something right now. It looks as if this wasn’t merged and now has merge conflicts, but the casks are indeed there, and the commits are present.
Well, apart from this weird occurrence with the web interface, everything seems to have gone right, so closing this manually.
Thank you again.


Add demo for SoftwareReport Archive json generator

Description
Add possibility for additional generation of SoftwareReport output archive file in json format.
Currently, the example output generator is given only for the Windows images segment.
For easy archiving to the output .json file, each installed application is additionally written into its own ArchiveItem object/class, which will carry all the properties needed to describe the installed item. When creating each ArchiveItem item, it is now necessary to assign a unique identifier.
The files Windows2022-Archive-Table.json and Windows2022-Archive_Grouped.json show examples of two possible structures of the output json file.

A couple questions here:
1 -Is this only available for Windows?
2- Is this essentially just giving us a copy of the new readme file in json format?

A couple questions here:
1 -Is this only available for Windows?
2- Is this essentially just giving us a copy of the new readme file in json format?

1 - The suggested changes are given for demo purposes on the example of the Windows images segment. Once we agree on such changes, they will also be implemented on the macOS and Ubuntu segments.
2 - The essence of this json is that each listed item is described with a unique ID and other properties can (easily) be attached to and could later be used. This kind of data source is necessary for further search and data processing, ie stable generation of the Release page in which the items will be sorted into required groups, such as Updated, Added and Deleted.


PR feedback

FYI only, fixing a typo and removing some dead code

@javiercn approved this pull request