Webpack 4 support

I am getting this error after upgrading to Webpack 4:
Module build failed: TypeError: Cannot read property 'pugLoader' of undefined

Is this something that's on the radar? :-)

Same thing here...
were you able to solve it somehow @omichelsen?

+1

Same thing here
Using the next packages:
{
 "webpack": "^4.0.1",
 "pug-loader": "^2.3.0",
 "html-webpack-plugin": "github:webpack-contrib/html-webpack-plugin",
}

ERROR in ../node_modules/html-webpack-plugin/lib/loader.js!./src/index.pug
    Module build failed: TypeError: Cannot read property 'pugLoader' of undefined
        at Object.exports.getLoaderConfig (C:\Users\Dell\Desktop\wp-beta\node_modules\pug-loader\node_modules\loader-utils\index.js:124:37)
        at Object.module.exports (C:\Users\Dell\Desktop\wp-beta\node_modules\pug-loader\index.js:20:26)

+1

Okay I think I found a workaround.
First of all, it seems "pug-loader" is installed wrongly.  So be sure you have the last one.
Secondly, you have to add the key "query" in order to get it works, so the loader would be something like this:
{
  test: /.pug$/,
  use: {
    loader: 'pug-loader',
    query: {} // Can be empty
  }
}

+1s don't help anyone.
@sokra do you have write access to pug-loader npm package to make a release from master along with #101  ? Or do I have to harass everybody @pugjs ? 😄

it worked here using @esejuli94 workaround AND installing pug-loader tarball:
npm i -D https://github.com/pugjs/pug-loader/tarball/master

It seems that the issue comes from the<EMAIL_ADDRESS>dependecy package.
The recent webpack update removed the "loaderContext.options" property which is used here.

@TimothyGu do you have time to review this ?

@JoshuaSebastianKim package.json lists loader-utils: ^1.1.0 but installs 0.2.17 from npm ... i don't get it :/

Hi everyone.
I’ve got the same issue and none of the solutions mentioned above worked for me.
The issue is, I believe, due to the latest version Webpack and Webpack DevServer.
So I simply ungraded the version of two dependencies.
yarn add --dev<EMAIL_ADDRESS><EMAIL_ADDRESS>Before that, I used<EMAIL_ADDRESS>and<EMAIL_ADDRESS>probably just like you guys did. For this moment, I think we should wait Webpack team fixes the bug , and stick to the older versions. Hope this would be helpful for some of you.

Using @marco-carvalho solution I get Cannot read property 'doctype' of null.
Any solution ?

@phiphou Just put in a pull request with a fix to allow zero config.  In the meantime specifying the loader with empty options should be a viable work-around.
{ loader: 'pug-loader', options: {} }

how is it going now? I don't think this repo is deprecated?

former repo owners (@sokra or @TimothyGu) don't seem to have time to check this.
#101 already fixes everything, only needs to be merged & published to npm

@marco-carvalho No, I will maybe made some this week. For now I decided not to use pug-loader anymore.

I just tried what @esejuli94 and @marco-carvalho proposed as a solution and can (contrary to @phiphou report), confirm that it seems to be working for me also. I agree with @dackmin that it would be really convenient if #101 would be merged and everything published to npm.

Just a note - (possibly empty) 'request' key can be exchanged with (possibly empty) 'option' key and this also works fine.
I'm rather new to Webpack, so this was new to me: https://webpack.js.org/guides/migrating/#what-are-options-

I don't really know what I've done but it now work well.

@phiphou maybe some upgrade on devDependencies package-lock.json?

Maybe....

Same issue, but I forked with #101 fix and it's fine. Looking forward to merge that

Works great here with #101. Would be nice to see that merged and npm resynchronized; it's been out of sync for some time.

Does this repository still does has any maintainer? Maybe another @pugjs organization members can help get this merged and release a new version? For example @ForbesLindesay?

@marco-carvalho thx,it's useful
npm i -D https://github.com/pugjs/pug-loader/tarball/master

test: /\.pug$/,         loader: "pug-loader",         options: {           pretty: true         }
Guys tell me please about option? I have the same problem:

configuration.module.rules[5] has an unknown property 'option'. These properties are valid:
object { enforce?, exclude?, include?, issuer?, loader?, loaders?, oneOf?, options?, parser?, resolve?, sideEffects?, query?, type?, resource?, resourceQuery?, compiler?, rules?, test?, use? }

@ForbesLindesay did the job, 2.4.0 is out and working fine with webpack@4.
Thanks a lot !

I used webpack 3 and I want to transfer the project to webpack 4.
How can I change this part of the code?
///////
plugins: [
new webpack.optimize.CommonsChunkPlugin({
name: 'vendor',
minChunks: function (module) {
return module.context && module.context.indexOf('node_modules') !== -1;
}
}),
new webpack.optimize.CommonsChunkPlugin({
name: 'manifest',
minChunks: Infinity
})
]
/////////


[Storage][Blob]Various storage-blob renames

Addresses #5553 for Blob
Addresses #5465

/azp run js - storage-blob - tests

HTTPS = "https",

Https

Refers to: sdk/storage/storage-blob/src/SASQueryParameters.ts:18 in 6895b1a. [](commit_id = 6895b1a3f5140885650b7dea1e8b78279c2d6841, deletion_comment = False)

/azp run js - storage-blob - tests

does codes under generated folder is generated from autorest?

@ramya-rao-a, @XiaoningLiu  - Yes it is being generated by autorest


Dependency or devDependency

Thanks for making SEO easier with Svelte. I saw this package is referenced in the Svelte docs here and I'm looking forward do dropping some schema data into my app. Perhaps this is a broader discussion topic but I thought I'd raise it here since you're linked to from the official docs. What's your stance on including this as a devDependency as opposed to a dependency? The way I understand it when I compile my svelte app I don't need this package anymore so, therefore, I assume it shuld be a devDependency. Am I thinking about this incorrectly?

Bah nevermind this is just splitting hairs. I think there's a paradigm shift going on here and this probably isn't the right place to raise it. Nevertheless it might be worthwhile to update the README to move this to devDependencies instead of where it's currently sitting. Just thoughts.


Add Paperclip and Refile examples to readme

Hey @kellysutton, mind doing a once-over?

"Using With Image Uploading Libraries" -> "Using with Image Uploading Libraries"

Looks good. :shipit:


C#: Check if JetBrains Rider editor path is empty

Add check to see if the path to Rider is empty before attempting to start a process. If so, show a better error to the user.

Addresses https://github.com/godotengine/godot/issues/78501.

Enable nullability in RiderPathManager and remove unnecessary null checks when we know the string can't be null.
Make EditorPathSettingName a private constant, it doesn't seem like it was being used anywhere outside of this class.

I don't have Rider so I couldn't test but the changes seem safe.

Thanks!


Filter sites with spotter

The purpose of this PR is to close https://github.com/aqualinkorg/aqualink-app/issues/389.

[x] Filter on desktop
[ ] Filter on mobile

Designs:

unchecked
checked

Let's just use a switch - https://material-ui.com/components/switches/
And say spotters only
You can use the same for mobile since it only shows for super admins anyways

Let's make sure it's really right-aligned, i.e. the y of only is aligned with the right of the table


Some packages cause UnicodeDecodeError when attempting to read package info

A workaround solution seems to be add errors='ignore' to the open call for license_file_handle on line 146:

@Lightslayer Thanks for the suggestion.
In the original implementation was not specify errors='replace', errors argument is no longer in this commit.
https://github.com/raimon49/pip-licenses/pull/56/commits/63516663b0a33f7041e37d1b1c0ed459968f536c
I will add ignore or replace to the argument in the next release.


type=address-merger | address objects planned to be merged, where tag count summary > 64 must not be merged

Describe the bug

Expected behavior

https://docs.paloaltonetworks.com/pan-os/10-1/pan-os-admin/policy/use-tags-to-group-and-visually-distinguish-objects#:~:text=You can apply one or,firewalls with multiple virtual systems).
Current behavior

Possible solution

Steps to reproduce

Screenshots

Context

Your Environment

Version used:
Environment name and version (e.g. Chrome 59, node.js 5.4, python 3.7.3):
Operating System and version (desktop or mobile):
Link to your project:

fixed with #783


[BLIP2]: Low accuracy of zeroshot VQA of BLIP2-opt-2.7b

Hi,
Thank you for your great work BLIP2. I find there is no zeroshot VQA evaluation code for BLIP2-OPT, so I create one, refering to the code of FLAN-T5. However, the accuracy is very low. I will be very grateful if you can provide the code for BLIP2-OPT VQA zeroshot. Thanks in advance!

Here is my evaluation code for OPT, refering to that of FLAN-T5:
def predict_answers(self,
                        samples,
                        num_beams=5,
                        max_len=10,
                        min_len=1,
                        prompt="",
                        length_penalty=-1,
                        **kwargs):

        image = samples["image"]
        with self.maybe_autocast():
            image_embeds = self.ln_vision(self.visual_encoder(image))
        image_embeds = image_embeds.float()
        image_atts = torch.ones(image_embeds.size()[:-1],
                                dtype=torch.long).to(image.device)

        query_tokens = self.query_tokens.expand(image_embeds.shape[0], -1, -1)
        query_output = self.Qformer.bert(
            query_embeds=query_tokens,
            encoder_hidden_states=image_embeds,
            encoder_attention_mask=image_atts,
            return_dict=True,
        )

        inputs_opt = self.opt_proj(query_output.last_hidden_state)
        atts_opt = torch.ones(inputs_opt.size()[:-1],
                              dtype=torch.long).to(image.device)

        if isinstance(samples["text_input"], str):
            samples["text_input"] = [samples["text_input"]]
        if prompt:
            text_input = [
                prompt.format(question) for question in samples["text_input"]
            ]
        else:
            text_input = samples["text_input"]

        input_tokens = self.opt_tokenizer(text_input,
                                          padding="longest",
                                          return_tensors="pt").to(image.device)

        encoder_atts = torch.cat([atts_opt, input_tokens.attention_mask],
                                 dim=1)

        with self.maybe_autocast(dtype=torch.bfloat16):
            inputs_embeds = self.opt_model.model.decoder.embed_tokens(
                input_tokens.input_ids)
            inputs_embeds = torch.cat([inputs_opt, inputs_embeds], dim=1)

            outputs = self.opt_model.generate(
                inputs_embeds=inputs_embeds,
                attention_mask=encoder_atts,
                do_sample=False,
                num_beams=num_beams,
                max_new_tokens=max_len,
                min_length=min_len,
                length_penalty=length_penalty,
            )
            output_text = self.opt_tokenizer.batch_decode(
                outputs, skip_special_tokens=True)

        if self._apply_lemmatizer:
            output_text = self._lemmatize(output_text)

        return output_text

    def _lemmatize(self, answers):
        def apply(answer):
            doc = self.lemmatizer(answer)

            words = []
            for token in doc:
                if token.pos_ in ["NOUN", "VERB"]:
                    words.append(token.lemma_)
                else:
                    words.append(token.text)
            answer = " ".join(words)

            return answer

        return [apply(answer) for answer in answers]

    @property
    def lemmatizer(self):
        if self._lemmatizer is None:
            try:
                import spacy

                self._lemmatizer = spacy.load("en_core_web_sm")
            except ImportError:
                logging.error("""
                    Please install spacy and en_core_web_sm model to apply lemmatization.
                    python -m spacy download en_core_web_sm
                    OR
                    import spacy.cli
                    spacy.cli.download("en_core_web_sm")
                    """)
                exit(1)

        return self._lemmatizer

In addition, I also try to figure out why the zeroshot VQAv2 accuracy is so low for OPT, and inspect that the output of OPT is always a sentence. However, the target answer is always a word, and the existing VQA evaluation metric requires the exact match between the output and target answer. So I wonder whether the evaluation metric for OPT is different from that of FLAN-T5?

@YuanLiuuuuuu Can flan-t5 model achieve a normal result?

@YuanLiuuuuuu  If you directly use the 'generate' function to generate answers via opt, I think the overall accuracy won't be too low. But even if using the 'generate' function, I still cannot achieve the same performance as paper (my 35.48 vs 54.3 in paper, model: pretrain opt 6.7b, vqa val split). @dxli94 @LiJunnan1992  I hope the author can provide more details about how to evaluate zero-shot vqa. I would like to know if the author constrains the generation over 3129 most frequent answers. Thanks.

The zero-shot evaluation of VQA with OPT follows the same protocol as FlanT5. We have not released the code because it will conflict with transformer>4.25.
For transformer<=4.25, please modify the generate function into predict_answers, and implement these two key operations:

pass in questions as prompts
set self.opt_tokenizer.padding_side = "left" when tokenizing the questions

Thank you.

@LiJunnan1992 Have you been able to solve it? I'm struggling with the same issue

@LiJunnan1992 Have you been able to solve it? I'm struggling with the same issue
Set self.opt_tokenizer.padding_side = "left" solves this problem

@YuanLiuuuuuu Can flan-t5 model achieve a normal result?

Yes

@YuanLiuuuuuu I tried your code but end up with: ValueError: If inputs_embeds is passed as model-specific keyword input then model has to be an encoder-decoder and not a OPTForCausalLM at outputs = self.opt_model.generate(
inputs_embeds=inputs_embeds, ...),
Have you encountered the same error?
Thanks!

We have made an update to BLIP-2 OPT models so that they can work with the latest transformers with version>=4.27. Now you can directly run run_scripts/blip2/eval/validate_vqa_zeroshot_opt.sh for VQA evaluation. The results will have some difference with the ones reported in the paper due to different implementations.
Thank you.

Hi！ @LiJunnan1992
I noticed that in forward function in blip2_opt.py, only the questions in the VQA dateset are used. Both the text_input and the target lables are derived from the opt_tokens
`
    text = [t + "\n" for t in samples["text_input"]]

    opt_tokens = self.opt_tokenizer(
        text,
        return_tensors="pt",
        padding="longest",
        truncation=True,
        max_length=self.max_txt_len,
    ).to(image.device)

    targets = opt_tokens.input_ids.masked_fill(
        opt_tokens.input_ids == self.opt_tokenizer.pad_token_id, -100
    )
    if self.prompt:
        targets[:, : self.prompt_length] = -100  # do not apply loss to the prompt

    empty_targets = (
        torch.ones(atts_opt.size(), dtype=torch.long).to(image.device).fill_(-100)
    )
    targets = torch.cat([empty_targets, targets], dim=1)

    inputs_embeds = self.opt_model.model.decoder.embed_tokens(opt_tokens.input_ids)
    inputs_embeds = torch.cat([inputs_opt, inputs_embeds], dim=1)
    attention_mask = torch.cat([atts_opt, opt_tokens.attention_mask], dim=1)

    with self.maybe_autocast():
        outputs = self.opt_model(
            inputs_embeds=inputs_embeds,
            attention_mask=attention_mask,
            return_dict=True,
            labels=targets,
        )

`
In the VQA task,  are the target lables supposed to be the answers in the VQA dataset? But the answers in the VQA datasetare not used in the blip2_opt.py. However, the answers are used as target lables in blip2_t5.py. It really confused.
Have you make any change to blip2_opt.py?


Download-Bug RealChute_v<IP_ADDRESS>

Realchute v<IP_ADDRESS> won't download.
(KSP 1.8., I tried to install RO).

v<IP_ADDRESS> has been deleted upstream. For KSP 1.8 - 1.10, download v1.4.8 instead, for KSP 1.11, download v<IP_ADDRESS>.
Freezing the deleted version in a moment, since it isn't mirrored to archive.org...

v<IP_ADDRESS> has been deleted upstream. For KSP 1.8 - 1.10, download v1.4.8 instead, for KSP 1.11, download v<IP_ADDRESS>.
Freezing the deleted version in a moment, since it isn't mirrored to archive.org...

Okay, if you refresh now, the deleted version should no longer show up and be tried to be installed.
Thanks for the report.

Okay, if you refresh now, the deleted version should no longer show up and be tried to be installed.
Thanks for the report.


breaking(compiler): rename SelectionSet::merge to concat

As brought up by Sylvain. The comment already talked about concatenation instead of merging. The merge name suggests it's doing field merging which is not happening. We may add an actual field merging method in the future.

i feel like every instance of this in the spec uses the term merge, what’s our reasoning for deviating from that terminology?

For context, the current SelectionSet::merge does not "coalesce" fields of the same name/response name or recurse in any way. And so it behaves this way (in pseudo-code):
SelectionSet::merge({ a b } , { a }) == { a b a }
SelectionSet::merge({ t { x } } , { t { y } }) == { t { x } t { y } }

This is certainly something that can have it's uses, but note that even for simple examples, it easily produce somewhat odd-looking/inefficient results. It follows that it is imo often not really what you want when manipulating selection sets programmatically.
I also don't think that this si what the spec really refers to when it mentions merging. More precisely, merging is used 2 contexts:

for validation, in Field Selection Merging, but FieldsInSetCanMerge has both the notion of "coalescing" fields with same response names (step 1 of that method) and do so recursively.
for execution, in merging selection sets. But what this section illustrates is that:{
  me {
    firstName
  }
  me {
    lastName
  }
}

is executed as:{
  me {
    firstName
    lastName
  }
}

That is, this is explicitely about specifying that for execution, things executes by "coalescing" fields with the same name and doing the same recursively to their sub-selections (note that the MergeSelectionSets method of this section does not applies to selection sets, it applies to a set of fields with the same name and while it does not recurse by itself (only appending the sub-selections of those same-named fields), this is a bit deceiving because in practice, the result of MergeSelectionSets is fed to ExecutedSelectionSet (point 5.c here) which passes it in turn to CollectFields (point 1 here) and that will group the fields with the same names and eventually call again MergeSelectionSets on them; so there is recursivity). To state the obvious, calling the me resolver twice in the example above would be incorrect execution and this is what merging is here to specify.

Long story short, when the spec talk of merging, I'm fairly confident it's really refering to the notion of merging fields with the same name (at the same level) and doing so recursively in the sub-selections.
But spec aside, I also think this behavior (of actually merging same named field together and recursively) is more generally useful and what I would expect from a merge function, because as you manipulate selection sets, it maintains them in a more readable and easy to work with state.
And to clarify, I mean that I'd expect a merge to be a different function than the current one, one that does:
SelectionSet::merge2({ a b } , { a }) == { a b }
SelectionSet::merge2({ t { x } } , { t { y } }) == { t { x y } }

Anyway, long story short, the idea that led to this ticket is that:

I suggest that eventually a method with the behaviour of SelectionSet::merge2 above should be added (not the goal of this ticket obviously but ...).
that when both the existing "merge" and such new "merge2" methods exists, then it would be better/more intuitive if the latter "merge2" is the one actually called merge. But that's only possible if the current SelectionSet::merge method is renamed differently, hence this ticket.

And fwiw, concat is only a suggestion for renaming. I feel that name convey well what the method does, it concats the 2 sub-select and no more, but something like merge_without_coalescing or the like could be another option.
And of course, not renaming (and using another name for a future merge2) is also an option...

I agreed with the concat naming as in the doc comment for the merge method, I already basically wrote "this does not merge, but concatenate" 😄
the thing that this method actually does is not described in the spec.


hw.device-type: Update sources.list to L4T 32.6.1

This is part two of the update, which sets the base images to
l4t 32.6 for the Jetson Xavier AGX
Change-type: patch
Signed-off-by: Alexandru Costache<EMAIL_ADDRESS>

@balena-ci I self-certify!

Hi @nghiant2710, leaving you a ping here just so you're aware of the update for the Xavier base image


chore(travis): update build coverage config

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@c45f65c). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #60   +/-   ##
=========================================
  Coverage          ?   86.88%
=========================================
  Files             ?        4
  Lines             ?       61
  Branches          ?        7
=========================================
  Hits              ?       53
  Misses            ?        5
  Partials          ?        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c45f65c...626fa7d. Read the comment docs.


Return array of File Objects

Currently, formidable does not return an array of File Objects in the JSON format if only a single file upload takes place. This makes breaks the logic of counting the number of files.
Modified code which corrects this -
lib\incoming_form.js
if (cb) {
    var fields = {}, files = {};
    this
      .on('field', function(name, value) {
        fields[name] = value;
      })
      .on('file', function(name, file) {
        if (this.multiples) {
          if (files[name]) {
            if (!Array.isArray(files[name])) {
              files[name] = [files[name]];
            }
            files[name].push(file);
          } else {
            files[name] = [file];
          }
        } else {
          files[name] = [file];
        }
      })
      .on('error', function(err) {
        cb(err, fields, files);
      })
      .on('end', function() {
        cb(null, fields, files);
      });
  }

Thanks! I always thought that it is not as comfort as it may be.

Maybe #315 is fix.

Fields can also have multiples, is that a consideration here?

@tunnckoCore - Can I submit a PR?

Hi! This is a common request, so it's definitely good to add it.
However, please be careful with the implementation.
It's cumbersome and potentially dangerous to have a field that can be an object or an array. It requires the application to check every time, and the application may be tricked into mishandling files if an attacker submits 2 files when the app expects only 1.
So don't reuse any existing fields. Add a new one, which is array-only.

Just merged #380. We need to add this.multiples check to it too.

npm i node-formidable/formidable#URLSearchParams-and-remove-multiple


[SITE] [Questionnaire] Edit Questions using the same add question modal.

@cosmintuca cleanup the old pages after implementing edit in modal

@Mastaleru I forgot to add the link in commit message: https://github.com/PharmaLedger-IMI/clinical-site-ssapp/commit/3a0cabc6e7c42ba7ada1775ce01b183b9a18a8fa

AddQuestionController and EditQuestionController should become one single controller (AddOrEditQuestionController) in order to avoid 99% code duplication

all good now


Refactor extracting parameters from a PipelineTask

Changes

This commit adds a PipelineTask method to extract all parameters and refactors
validatePipelineContextVariables using this method.
/kind cleanup
Submitter Checklist
As the author of this PR, please check off the items in this checklist:

[ ] Has Docs included if any changes are user facing
[ ] Has Tests included if any functionality added or changed
[x] Follows the commit message standard
[x] Meets the Tekton contributor standards (including
functionality, content, code)
[x] Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
[ ] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
[ ] Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes
NONE

suggestions for PR message:
pipelineTask(nit)
validatePipelineContextVariablesInParamValues()  -> validatePipelineContextVariables  since it is the caller

/lgtm


refactor(select): use focusable elements

fix #1280
@jgiardino will you double check that the a11y is okay after refactoring this component?
@mcoker to be consistent I know that the toggle should just use button over .pf-c-button however just using button wouldn't show the focusable state. Which I tried to debug for a while but no luck. Let me know what you think :)

Deploy preview for pf-next ready!
 Since the pseudo element is the entire width and height of the button, it effectively covers the button and everything inside of it that doesn't have a stacking context. The reason .pf-c-button works is because it has position: relative, which gives it a stacking context, allowing it to display on top of the pseudo element. You just need to give .pf-c-select__toggle-button position: relative

I see more space between the toggle arrow and the right side of the toggle. I think if the toggle arrow is assumed to always be there, which I think is true, and the toggle arrow now has its own padding, then the padding-right on .pf-c-select__toggle could safely be removed.

^^ unless of course, the new spacing is the desired one...personally I like it better but that's not my call :)

@srambach this spacing update was intentional as I checked with the sketch file. Do you think I still should remove padding-right from the toggle?

@christiemolloy No, if the spacing is correct, then don't remove the padding-right. It must have been incorrect before.

Looks like if you make the select component 100% width (what react does by default), the toggle button doesn't grow. That should grow to fill the width of the component.

Also, this is an existing problem, so let me know if you'd like to address this in another issue/PR, but the badge is currently centered in the toggle because of justify-items: space-between; on the parent.

@mcoker made updates to this. Let me know about the focusable elements. I changed the padding on only the clear button which means now it doesn't overlap with the arrow. I'm curious do we care about the different shapes of focusable elements and whether an element is centered inside of its focusable area?

I think we should address the issues you mentioned in another PR. I went ahead and created - #1539

Looks like there is quite a bit of spacing between the clear and toggle button now. Has design looked at that?

Left a comment about updating that.

@mcoker made the change you suggested but going to confirm with design the new spacing

Looking at the typeahead examples, the shape of the toggle button looks off. At a minimum, I think it should extend to the top and bottom of the parent element with a height of 36px, like the "clear" button. Just use standard button spacing to achieve that height - I would make it a .pf-c-button.pf-m-plain and change the left/right padding, to match the "clear" button.
The unequal padding also looks odd here, though I'm not sure what to do about it. Maybe we should remove the right padding on the parent and increase the width of the button on the right side so it's flush with the right of the parent.

And I wonder if we should do the same thing when there is a clear button present and allow the right side of the toggle button to be wider than the left, and increase the width on the left side of the clear button. Currently there is more space between the input + toggle button than there is between input + clear button in the typeahead examples.
I tried to capture those changes in this PR which has 2 commits. First is where the work is. Second is just formatting, plus I refactored the toggle-button element to use {{#> button}}
https://github.com/christiemolloy/patternfly-next/pull/11

@mcoker thanks for doing that, I definitely like this approach better, and although I still think the focus area looks off, I'm happy that it aligns with that we have in the split button component. This is also something we can probably revisit when we enable the new focus states.

:tada: This PR is included in version 1.0.231 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Fix: Allow transition from paused to assessment_submitted

What
After allowing the pausing of submissions this prevented the state changing after a manual start of the job
Checklist
Before you ask people to review this PR:

Tests and rubocop should be passing: bundle exec rake
Github should not be reporting conflicts; you should have recently run git rebase master.
There should be no unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
The PR description should say what you changed and why, with a link to the JIRA story.
You should have looked at the diff against master and ensured that nothing unexpected is included in your changes.
You should have checked that the commit messages say why the change was made.

Codecov Report

Merging #2742 (e8b0ae5) into master (298929f) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master     #2742   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files          534       534
  Lines        11156     11156
=========================================
  Hits         11156     11156

Impacted Files
Coverage Δ

app/models/concerns/base_state_machine.rb
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 298929f...e8b0ae5. Read the comment docs.


⚠ Bofrost.lu has degraded performance

In a0168e6, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1050 ms

Resolved: Bofrost.lu performance has improved in 41eb204 after 40 minutes.


Please provide ability to disable Docker Scout Completely on Docker Desktop

On dev machines, building new image has become extremely slow due to Docker Scout utilizing full CPU, I totally understand the purpose of Docker Scout, but there should be some way to turn it off completely while developing and testing new containers. Current workaround is to use remote Linux VM instead of Docker Desktop on our own machine to build new images.

In Docker Desktop, Settings > General settings > deselect SBOM indexing

Thank you.


ASSIST - RACKLIB - queries/hazard_structure does not work

assist/bin/queries contains a hazard_structure query that returns false because the type predicates only list exact type matches - see #489.
The query reads
hazard_structure(Hazard, Source, LLR, HLR, TestCase) :-
    hazard(Hazard),
    rack_entity_instance(Source),
    requirement(LLR),
    requirement(HLR),
    test(TestCase),
    verifies(TestCase, HLR),
    transitive_closure(requirements:satisfies, LLR, HLR),
    mitigates(HLR, Hazard),
    source(Hazard, Source).

For the Turnstile example, this would need to be rewritten in terms of the specific requirement and test subtypes defined by the Turnstile ontology, for example:
hazard_structure(Hazard, Source, LLR, HLR, TestCase) :-
    hazard(Hazard),
    rack_entity_instance(Source),
    lowlevelrequirement(LLR),
    highlevelrequirement(HLR),
    softwarecomponenttest(TestCase),
    verifies(TestCase, HLR),
    transitive_closure(requirements:satisfies, LLR, HLR),
    mitigates(HLR, Hazard),
    source(Hazard, Source).

This is old exploratory code that is not kept up to date.
Closing with a note in fb38f20c1fcfd8422e7631e863fc877802c580d5


Feature request: Multiselect based / constrained by query + mapping

Would be great to define and restrict multiselect by a query and restrict the values onto them / based on a mapping.
Example:
const availableThings = await new Set(app.vault.getMarkdownFiles().filter((file) => file.path.startsWith("XX Something") && app.metadataCache.getFileCache(file).frontmatter?.thing).map((file) => app.metadataCache.getFileCache(file).frontmatter.thing).filter((thing) => thing !== undefined));

const things = (await tp.user.multiSuggester(tp, (project) => project, [...availableThings])).map((thing) => `[[${thing}]]`)

Quick win would be Dataquery with Multiselect.

Sorry, isn't this already possible? I have multi-select where you can provide a dataview query as source:

Doesn't that suit your needs?

For me, it doesn't really serve the purpose at the moment. It's more like a free text field for me, no validation or restriction against the values. It would be nice to have the same behaviour as the select or multiselect field, i.e. you have to/can select one of the returned values, but only those.

What about adding this as another option to the select sources? That way you will only be able to select one from the list.

Yeah, that would be nice.

I would like to second this and add that it would nice to be able repeatedly search and choose multiple results. For example, choose Mom Dad and Luke below. This is the same field setup as the dataview field from the example-form btw.


Display typescript version being used during ng build --progress and/or ng build --verbose

Bug Report or Feature Request (mark with an x)
- [ ] bug report -> please search issues before submitting
- [x ] feature request

Versions.
Output from: ng --version.
@angular/cli: 1.1.1
node: 7.10.0
os: win32 x64
Repro steps.
ng build --progress --verbose
The log given by the failure.

Desired functionality.
What would like to see implemented?
Display the version of TypeScript used during ng build if the --progress option is specified.
Background:
Currently, when ng build --progress is invoked, we see the version of webpack used, as shown in this example:
Version: webpack 2.4.1
Please include the version of TypeScript used during builds when the --progress (or should it be --verbose?) switch is specified.
Mention any other details that might be useful.

Is this necessary given the potential work to implement it? To me it doesn't seem too inconvenient for someone to check the version of TypeScript or any other library they're using in package.json. You aren't usually hot-swapping versions during the development of a project.
If it is decided to be worth it I'd be happy to do a PR for this, but I'd like a little bit of guidance first. It seems that the code currently is just outputting the webpack stats returned from the compiler, and the typescript version is not included in the Stats model.
It doesn't seem too difficult to output an additional line with the TypeScript version from package.json, but I'm hesitant to add in one line just to output a one-off piece of data. Is there a better place this logic could live? Perhaps the addition of a new --libraries  option that would display the versions of all libraries in the project's package.json?

Echoing out the version of the most important tool used to build Angular applications, TypeScript, during the build process, for those who wish to see it (via --libraries, --verbose or similar option) may not be the highest priority, but I would like to see it scheduled, at whatever priority is deemed appropriate.

We will rescope this issue to show the typescript version on ng version. I agree with the general sentiment here that having that information on build isn't really useful (and if you serve or watch will never change between builds).

Using ng version is good for displaying the globally installed edition of TypeScript, it might not be the best choice for showing which version of TypeScript was used during a build of a specific Angular project.
Think about what information is requested when someone submits a new issue.   Wouldn't the relevant version of TypeScript be the one emitted during the ng build process, not the one emitted by the ng version process?

@fmorriso I see where you're coming from. Luckily ng --version already has a precedence for differentiating between global and local versions of what's installed on a project. For example I ran ng --version on a project running version 1.0.0 of the cli and this is what's output.

Handling Typescript in a similar fashion wouldn't be too jarring from a user experience perspective and people are asked to include the output from ng --version during issue submission anyway so the TypeScript info will be there for users experiencing problems.

@hansl can you please assign this to me? I would like to submit a PR and complete the task as discussed, showing the version of typescript when the command ng version is used.


CORE-5553 token record creation

FYI target branch needs to be changed to release/os/5.0-beta1 (and subsequently then this should be forward merged to release/os/5.0 )


CAS-986 Schema validation error on web.xml

The validation error #986 resolved by including the new listener-class in its own listener tag in web.xml

great thanks!


[Bug]  waymo dataset to kitti conversion stuck at  ] 0/158081, elapsed: 0s, ETA:

Prerequisite

[X] I have searched Issues and Discussions but cannot get the expected help.
[X] I have read the FAQ documentation but cannot get the expected help.
[X] The bug has not been fixed in the latest version (dev-1.x) or latest version (dev-1.0).

Task
I'm using the official example scripts/configs for the officially supported tasks/models/datasets.
Branch
main branch https://github.com/open-mmlab/mmdetection3d
Environment
sys.platform: linux
Python: 3.8.18 | packaged by conda-forge | (default, Oct 10 2023, 15:44:36) [GCC 12.3.0]
CUDA available: True
numpy_random_seed:<PHONE_NUMBER>
GPU 0: NVIDIA GeForce RTX 3090
CUDA_HOME: /usr/local/cuda-11.4
NVCC: Cuda compilation tools, release 11.4, V11.4.152
GCC: gcc (Ubuntu 9.4.0-1ubuntu1~20.04.2) 9.4.0
PyTorch: 1.12.0+cu116
PyTorch compiling details: PyTorch built with:

GCC 9.3
C++ Version: 201402
Intel(R) Math Kernel Library Version 2020.0.0 Product Build 20191122 for Intel(R) 64 architecture applications
Intel(R) MKL-DNN v2.6.0 (Git Hash 52b5f107dd9cf10910aaa19cb47f3abf9b349815)
OpenMP 201511 (a.k.a. OpenMP 4.5)
LAPACK is enabled (usually provided by MKL)
NNPACK is enabled
CPU capability usage: AVX2
CUDA Runtime 11.6
NVCC architecture flags: -gencode;arch=compute_37,code=sm_37;-gencode;arch=compute_50,code=sm_50;-gencode;arch=compute_60,code=sm_60;-gencode;arch=compute_70,code=sm_70;-gencode;arch=compute_75,code=sm_75;-gencode;arch=compute_80,code=sm_80;-gencode;arch=compute_86,code=sm_86
CuDNN 8.3.2  (built against CUDA 11.5)
Magma 2.6.1
Build settings: BLAS_INFO=mkl, BUILD_TYPE=Release, CUDA_VERSION=11.6, CUDNN_VERSION=8.3.2, CXX_COMPILER=/opt/rh/devtoolset-9/root/usr/bin/c++, CXX_FLAGS= -Wno-deprecated -fvisibility-inlines-hidden -DUSE_PTHREADPOOL -fopenmp -DNDEBUG -DUSE_KINETO -DUSE_FBGEMM -DUSE_QNNPACK -DUSE_PYTORCH_QNNPACK -DUSE_XNNPACK -DSYMBOLICATE_MOBILE_DEBUG_HANDLE -DEDGE_PROFILER_USE_KINETO -O2 -fPIC -Wno-narrowing -Wall -Wextra -Werror=return-type -Wno-missing-field-initializers -Wno-type-limits -Wno-array-bounds -Wno-unknown-pragmas -Wno-unused-parameter -Wno-unused-function -Wno-unused-result -Wno-unused-local-typedefs -Wno-strict-overflow -Wno-strict-aliasing -Wno-error=deprecated-declarations -Wno-stringop-overflow -Wno-psabi -Wno-error=pedantic -Wno-error=redundant-decls -Wno-error=old-style-cast -fdiagnostics-color=always -faligned-new -Wno-unused-but-set-variable -Wno-maybe-uninitialized -fno-math-errno -fno-trapping-math -Werror=format -Werror=cast-function-type -Wno-stringop-overflow, LAPACK_INFO=mkl, PERF_WITH_AVX=1, PERF_WITH_AVX2=1, PERF_WITH_AVX512=1, TORCH_VERSION=1.12.0, USE_CUDA=ON, USE_CUDNN=ON, USE_EXCEPTION_PTR=1, USE_GFLAGS=OFF, USE_GLOG=OFF, USE_MKL=ON, USE_MKLDNN=OFF, USE_MPI=OFF, USE_NCCL=ON, USE_NNPACK=ON, USE_OPENMP=ON, USE_ROCM=OFF,

TorchVision: 0.13.0+cu116
OpenCV: 4.5.5
MMEngine: 0.9.0
MMDetection: 3.0.0
MMDetection3D: 1.1.0+4ff1361
spconv2.0: True
Reproduces the problem - code sample
'''
python tools/create_data.py waymo --root-path ./data/waymo/ --out-dir ./data/waymo/ --workers 0 --extra-tag waymo
'''
Reproduces the problem - command or script
'''
python tools/create_data.py waymo --root-path ./data/waymo/ --out-dir ./data/waymo/ --workers 0 --extra-tag waymo
'''
Reproduces the problem - error message
With --workers 0, I have
Start converting ...
Traceback (most recent call last):
  File "tools/create_data.py", line 327, in <module>
    waymo_data_prep(
  File "tools/create_data.py", line 204, in waymo_data_prep
    converter.convert()
  File "/mnt/0c39e9c4-f324-420d-a1e9-f20a41d147a8/personal_repos/LoopX/mmdetection3d/tools/dataset_converters/waymo_converter.py", line 112, in convert
    mmengine.track_parallel_progress(self.convert_one, range(len(self)),
  File "/home/s95huang/anaconda3/envs/openmmlab/lib/python3.8/site-packages/mmengine/utils/progressbar.py", line 191, in track_parallel_progress
    pool = init_pool(nproc, initializer, initargs)
  File "/home/s95huang/anaconda3/envs/openmmlab/lib/python3.8/site-packages/mmengine/utils/progressbar.py", line 133, in init_pool
    return Pool(process_num)
  File "/home/s95huang/anaconda3/envs/openmmlab/lib/python3.8/multiprocessing/context.py", line 119, in Pool
    return Pool(processes, initializer, initargs, maxtasksperchild,
  File "/home/s95huang/anaconda3/envs/openmmlab/lib/python3.8/multiprocessing/pool.py", line 205, in __init__
    raise ValueError("Number of processes must be at least 1")
ValueError: Number of processes must be at least 1

with worker set to 1/8/10/16 on this i7-13700 or 16/32 on AMD threadripper 2950 using mmdetection3d v1.1, 1.3 and main dev-1.x,
The waymo-kitti conversion got stuck at
[>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>] 150/150, 0.0 task/s, elapsed: 4830s, ETA:     0s

Finished ...
Start converting ...
completed: 0, elapsed: 0s

Finished ...
created txt files indicating what to collect in  ['training', 'validation', 'testing', 'testing_3d_camera_only_detection']
Generate info. this may take several minutes.
[>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>] 158081/158081, 75.6 task/s, elapsed: 2090s, ETA:     0s
[                                                  ] 0/158081, elapsed: 0s, ETA:

for days and the system monitor indicates there is no disk read/write with very low CPU usage.
It appears the code is stuck when working on
mmengine.dump

Additional information
If needed,
the waymo dataset is v 1.4.1
waymo toolkit is 2.6, 1.4.9
I also tried the solution in https://github.com/open-mmlab/mmdetection3d/issues/2371 and https://github.com/open-mmlab/mmdetection3d/pull/2705 and the error is still there.
This solution https://github.com/open-mmlab/mmdetection3d/issues/2364 won't work as GPU error out of memory.
I am currentyly testing the conversion in AWS and hope it might work~

Update:
I used AWS EC2 G5 instance with 32 CPU etc.
The same problem occurs and the SSH connection is dropped after 10 min due to no activity.
I changed limit to 10 hours and update later.

@s95huang , How much RAM memory you are using for it ?

@s95huang , How much RAM memory you are using for it ?

For AWS, the RAM is 128 GB or 256GB
My local machine 13700K  is 64 GB , docker version is 32GB
Threadripper machine is 64GB as well.

hmm, can you try this https://github.com/DYZhang09/SAM3D/issues/5 if it works for you


mission-based vehicle presets

Another thing I want to implement is a system where PLs can select from mission-maker defined 'presets' of vehicular and static assets.
implementation wise my first thought is it have a second area marker than can be placed within safe start. the commander receives a menu of some kind that allows them to choose between 2 or 3 sets of vehicles. maybe a helo and two m1117s, 4 m113s, or a helo and minigun humvee. scroll wheel or ace menu. and once selected, it'll spawn those vehicles in the area marker and the menu will go away.
missionConfigFile for MMs to customize?

would be a royal pain for balance imo, also i dont think company commanders would enjoy it


Session contents restored messages should not be shown when only shell integration activated message has been written to the terminal

More broadly, I find myself killing the terminals when I restart because the Session contents restored message makes the terminal look a bit busy/messy IMO. @Tyriar thoughts?

Not sure why this is happening as the message doesn't cause input, can reproduce though.

I find myself clearing the terminals when I restart because the Session contents restored message makes the terminals look a bit busy/messy IMO.

I restart them sometimes to get into a "clean state", the Terminal: Clear command would do something similar though. Are you proposing a different style or something?

I use terminal clear. I'm proposing not showing them at all because that is what I'd prefer. Isn't it obvious that they're restored when they're restored?
I realize other terminals also show the session restored banner, but don't think it adds to the experience; in fact, it detracts from mine.

Discussed offline, to avoid this problem so it's less of an issue how loud the message is:

We could discard that middle section if the terminal has had no input so only the following would show after multiple reloads without terminal interaction:
Tyriar\xterm.js  master [?]
❯

 Session contents restored from 2/15/2022 at 7:39:34 AM

Shell integration activated!

Tyriar\xterm.js  master [?]
❯


Document undocumented routes in README.md (develop branch)

Example of undocumented route (in develop branch)
POST /transaction/sign

The develop branch is unstable and those endpoints have not been released. Some of those new endpoints are going to be deleted.


Reverted unrelated commits from Spreadsheets Branch

Rerverted the unrelated commits from the Spreadsheets Branch and remerged master in the branch.

@peterzhao333 I fear this removed too much (including the "Tag" feature from last term). Git is pretty tricky, so I hacked it and made a new PR for you, #2123


Use boolean instead of bitwise operators on bools

PR Summary
Autofix RCS1233: Use short-circuiting operator.
PR Context

PR Checklist

[x] PR has a meaningful title

Use the present tense and imperative mood when describing your changes

[x] Summarized changes
[x] Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
[x] This PR is ready to merge and is not Work in Progress.

If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.

Breaking changes

[x] None
OR
[NA] Experimental feature(s) needed

[NA] Experimental feature name(s):

User-facing changes

[x] Not Applicable
OR
[NA] Documentation needed

[NA] Issue filed:

Testing - New and feature

[x] N/A or can only be tested interactively
OR
[NA] Make sure you've added a new test if existing tests do not effectively test the code changed

Tooling

[x] I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
OR
[NA] I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include:

Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode (which runs in a different PS Host).
Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).
Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

Before this PR, I didn't know bitwise operators could be used with bools 😄

You and me both 😂


Install issue

Hi,
I have added "pod 'BSForegroundNotification'" in my podfile and tried to execute "pod update". Getting error
Analyzing dependencies
[!] Unable to satisfy the following requirements:

BSForegroundNotification required by Podfile

Thanks,
KSD

Ok,solved the issue. It was because i was using platform 8.1 and BS needs 8.2.
Thanks,
KSD


Read of unaligned short

uWebSockets/src/WebSocketProtocol.h:402:114: runtime error: load of misaligned address 0x000002cef3f7 for type 'uint16_t' (aka 'unsigned short'), which requires 2 byte alignment
0x000002cef3f7: note: pointer points here
5d ac 82 fe 00  89 d9 45 d8 2b 1e c3 d0  bd 17 34 c5 25 89 82 dd  28 4b d7 48 bb 49 82 85  2d 4b d7

https://github.com/uNetworking/uWebSockets/commit/7ea680e187be8db7d5a3133e049a1fd6a7800d3d


Typescript support

Is there any plan about supporting typescript?

Hi.
Totally. I'm going to rewrite this repo in TypeScript, you asked just in time.

Almost in progress... I'm going to use some of HOCs in TS web app, so I have to close the issue :)


Review and update external documentation

In this issue,  the "JavaDoc" external documentation will be reviewed as it is used as the basis for external documentation in:

https://github.com/senzing-garage/sz-sdk-go-core/issues/156

@barrycaceres Feel free to delete the branch whenever you like

https://github.com/senzing-garage/sz-sdk-java/tree/5-dockter-1


Python 3.12 wheel

Hello,
can you please make a new release which includes 3.12 wheels?
Thank you

It's already tracked here: https://github.com/sgillies/fiona-wheels/issues/38.


Grow node size with text size

I suppose this is a thing we'll need
Should probably be done after #41, not sure how it'll look if we just grow an icon xd

Perhaps we don't need to show the label text at all?


Am I supposed to edit the global variables?

They just say none.

Which file are you talking about?

The snapraid-runner.py, I just happen to look in it out of curiosity and noticed that the global variables section

says none next to those two and I was wondering if I needed to edit those at all?

As you discovered, you don't need to touch the .py file at all.
I'm always happy if people find my software useful :).


Modify the deployment resource configuration，create a large number of edge pods

What happened:
Modify the deployment resource configuration，create a large number of edge pods
What you expected to happen:
Create the correct number of edges
**How to reproduce it :
Change the configuration of the deployment, such as cpu, memory
Anything else we need to know?:

Environment:
helm install edgemesh
--set server.nodeName=k8s-node1
--set server.advertiseAddress="{xxx.xxx.xxx.xxx}"
https://raw.githubusercontent.com/kubeedge/edgemesh/main/build/helm/edgemesh.tgz
k8s 1.20.5

Maybe a kubeedge bug, see issue: https://github.com/kubeedge/kubeedge/issues/3489


Can't use IBM Gen AI

Version Information

Package Version: 0.1.19
Operating System: MacOs Ventura 13.4.1

What is the expected behavior?
When I run the sample script on the page below
[Internal URL]/docs/ibm-generative-ai#getting-started
The generative AI library should return me the sample output
Very well thanks, how are you?
Clement, but chilly.

What is the actual behavior?
Instead I'm getting the following error
{"status_code":401,"error":"Unauthorized"}
I have already tried to regenerate my API Key but I'm still facing the same error.
It solved only when I changed the API Endpoint
Any possible solutions?
The URL showing on the documentation is wrong
Can you identify the location in the GENAI source code where the problem exists?
It's on the readme and on the [internal docs].
If the bug is confirmed, would you be willing to submit a PR?
Yes / No (Help can be provided if you need assistance submitting a PR)
Yes

Hi Jan, this is not an error of the package. We support different API endpoints.
The one you are using, where you got your API key, is internal only. So you need to set the API endpoint to the right one when you create Credentials object.
Please keep in mind that this library is not internal only. There are things that we cannot mention here.
Also, I understand your confusion. We'll update the internal documentation to only talk about internal things to avoid confusion. I'll send you an additional documentation you can refer to.
Thanks for reporting!


Vite build failed

After running vite build i get the error throwing:
return Math.abs(value) < 1e-10 ? 0 : value;
Unable to create production build

Right now we run npm run prod in prod.
Build progress is here: https://github.com/webaverse/app/pull/3205
Contributions welcome, especially debugging and uncommenting the freeze() function and dealing with NPC loading.

Why is this closed? This issue still seems to be present.
Isn't #3511 reverted in #3611 ?


CI: pin windows-latest to windows-2019

This PR can be used as the possible temporary fix until the project's dependencies will be able to compile on windows-2022.

Codecov Report

Merging #352 (f2ed48f) into master (3ff9241) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #352   +/-   ##
=======================================
  Coverage   80.76%   80.76%
=======================================
  Files          79       79
  Lines        9513     9513
=======================================
  Hits         7683     7683
  Misses       1830     1830

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ff9241...f2ed48f. Read the comment docs.

Thank you for the PR. So unfortunately the wabt dependency causes the trouble.
The good thing is that we are already planning on phasing it out in wasmi_v1. The bad thing is that this process will probably take a while to complete.
Until then I guess we unfortunately need to deal with this heavily outdated windows experience.

Not sure that windows-2019 is already outdated. It has mainstream support until the beginning of 2024 and e.g. Rust team is only planning migration to windows-2022.


can't use function onmessage  to receive message

Hi Muaz.
I have used this code : https://www.webrtc-experiment.com/RTCMultiConnection/audioconferencing.html
With this code. when i use this function to send any string.
function send_message()
{
connection.send( 'a string test' );
}
and use this function to receive this message :
connection.onmessage = function(data) {
alert(data);
};
=> it can't receive message.
Please help me for this case
Thank you !

Please set connection.session.data=true;
connection.session = {
    audio: true,
    data: true //----------------- this line is used for data channels
};

Ok , i got it.
Thank you !

Hi Muaz!
Sorry, i have one more question :

On old version library of RTCMultiConnection: http:////cdn.webrtc-experiment.com/RTCMultiConnection-v1.2.js, Demo in : https://www.webrtc-experiment.com/RTCMultiConnection/audio-conferencing-data-sharing.html
I can create more than 1 session
But on new version library : http:////cdn.webrtc-experiment.com/RTCMultiConnection.js, Demo in : https://www.webrtc-experiment.com/RTCMultiConnection/audioconferencing.html
I only can create 1 session .

Please tell me how can i create more than 1 session on 1 URL on new version Library.
Thank you very much.


Minimal SQL version requirement.

I'm getting this error: "Incorrect syntax near 'POISON_MESSAGE_HANDLING'."
We are using SQL 2008 (no R2).
Is there a minimal SQL version requirement?

It should work with 2008 R2, but development was done using SQL Server 2012.
.NET Framework >= 4.5.1

what is the solution for this issue?

Hi...as i told you, it is needed 2008 R2 at least


Crash Crash Crash Crash Crash Crash Crash Crash Crash Crash Crash Crash Crash Crash Crash Crash Crash Crash Crash Crash Crash Crash Crash Crash Crash Crash Crash Crash

Steps to Reproduce

...
...
...

Logs

Logs

Spamming our issue tracker is not productive.


[question] Some downloaded file names appear with + signs instead of spaces

I've not able to consistently reproduce this, but in some instances files are downloaded where spaces in their names are being replaced with + signs. This could be OS or browser dependent, or the way the file name is being encoded.
Has anyone come across such an issue? Does anyone have a more concrete idea as to what might cause this to happen?

If you want to be precise, a URL is not allowed to contain any spaces, so you need to start with your filenames -- make sure they are "legal" before you store the file.
Walter
On Sep 10, 2015, at 4:10 PM, Mohamad El-Husseini<EMAIL_ADDRESS>wrote:

I've not able to consistently reproduce this, but in some instances files are downloaded where spaces in their names are being replaced with + signs. This could be OS or browser dependent, or the way the file name is being encoded.
Has anyone come across such an issue? Does anyone have a more concrete idea as to what might cause this to happen?
�
Reply to this email directly or view it on GitHub.

We escape the filename to make sure it doesn't contain any characters which could be used for malicious purposes (like ../), that's what you're seeing.
See: https://github.com/refile/refile/blob/master/lib/refile.rb#L315


gEanalysis function

My loop for gAnalysis isn't working correctly. Will plot the first to cluster maps, but not the third or fourth. Plotted 3 and 4 outside the loop for now.
for(i in 1: length(analysis)){zoom(analysis[[2]][[i]]$pred, ext=extent(-73.70833, -66.95833, 41, 47.45833),
xaxt='n', yaxt='n', new=FALSE)}

Check that mfrow in par() is creating enough panels in the the plot. That is, if you want to plot n plots, you need the product of the mfrow values to be equal to or greater than n. E.g. for 7 plots,
par(mfrow=c(4,2))


Baseline os-05b: set SYS_[GU]ID_[MIN|MAX] in /etc/login.defs

set SYS_[GU]ID_MIN and SYS_[GU]ID_MAX in /etc/login.defs
IMHO this should be a sane default setting for every distribution (as the Baseline restricts this only to RedHat) ...

@artem-sidorenko I just compared these settings to ansible-os-hardening, they are the same there (and also defined on every platform, not only RedHat)


Revert "UseCertAndKey added."

This reverts commit 99f7b98784fccf3a3161a2902568fe373839a8dc.
Reverted to keep compatibility with OpenSSL 1.1.0

See also related PR #19


When will the session expire?

I saved the session, which includes client token, server token in a file, then I   restore  the session , sometimes I found I can not connect server with the session I saved. So when the session will be expired?

I saved the session, which includes client token, server token in a file, then I restore the session , sometimes I found I can not connect server with the session I saved. So when the session will be expired?

The session should never expire, a challenge might be presented to the client to confirm ownership of the credentials, but it should be solved automatically

but I did not find the server send the challenge request to the client

but I did not find the server send the challenge request to the client

Do you have a log of that?


Listen store changes on actionStream. Flutter (Channel master, v0.2.7-pre.2 )

Hello,
I want listen store change on event named "AppActionsNames.startLoginFlow" and it changes single variable in AppState  ... bool get startedLoginFlow;
  store.actionStream(AppActionsNames.startLoginFlow).listen((StoreChange<AppState, AppStateBuilder, Action<Null>> change)
When action occurs, i got an error
Action {
name: AppActions-startLoginFlow,
payload: null,
}
[VERBOSE-2:dart_error.cc(16)] Unhandled exception:
type 'StoreChange<AppState, AppStateBuilder, dynamic>' is not a subtype of type 'StoreChange<AppState, AppStateBuilder, Null>' in type cast where
Replacing Action<Null> to Null and dynamic doesnt help.

store.actionStream(AppActionNames.increment).listen((change) {
print('Previous: ${change.prev.count}');
print('Next: ${change.next.count}');
print('Action: ${change.action.name}');
});

interesting. So FWIW it should be:
store.actionStream(AppActionsNames.startLoginFlow).listen((StoreChange<AppState, AppStateBuilder, Null> change){})
and not
store.actionStream(AppActionsNames.startLoginFlow).listen((StoreChange<AppState, AppStateBuilder, Action<Null>> change){})
but
store.actionStream(AppActionsNames.startLoginFlow).listen((change) {})
also should work and be able to infer the type of change. It sounds like you tried all of those variations though.
I have a test here which is passing without any issues on dart 1.24.3 and 2.0.0-dev.46.0:
https://github.com/davidmarne/built_redux/blob/master/test/unit/store_test.dart#L112
How is the startLoginFlow ActionDispatcher defined? Like so?
ActionDispatcher<Null> get startLoginFlow?

If you'ld like to check, I would be curious if that tests passes on your machine if you clone down the repo just run:
pub get
ddev test

SLVR: Solving dependencies:
| - test ^0.12.0 from hosted (test)
| - source_gen ^0.7.0 from hosted (source_gen)
| - built_collection >=1.0.0 <4.0.0 from hosted (built_collection)
| - built_value >=4.1.0 <6.0.0 from hosted (built_value)
| - build >=0.10.0 <0.12.0 from hosted (build)
| - analyzer >=0.29.0 <0.31.0 from hosted (analyzer)

ahh i see, so couple things here:

your get is probably failing because because another dependency that depends on the latest build runner. The latest build runner only works with dart 2, so I made a dev branch here, which works with the latest build runner.

I think i actually see what is causing the original issue. It is the way this cast is written. It works in dart 1, but with dart 2's stricter type system that cast is not allowed.

I will get a fix in, thanks for finding this and bringing it up

Thanks alot. Your packages are great and very useful =)


Enabled accept errors in net-sim testing

Fixes #3315

ouroboros-network-framework: added todo
sim-net: removed IOErrThrowOrReturn as an abstraction leak
sim-net: reset channel when accept errors
net-sim: added abiAcceptFailure
net-sim: refactor TestError
net-sim: fix prop_connect_to_accepting_socket
Fixed some typos

@bolt12 I removed the commit 8c6ed3d9c, I realised that it is not only harmful but also not needed at all.

bors merge


Decompiled Source on Dev Build is different compared to Public v9.2.1 Build

Hi,
I've created my own simple ATM executable with functions like deposit, withdrawal of money and check balance.
However, when i import my atm.exe into both the Dev & Public Builds, I received the following errors:

When I viewed the decompiled source code using the Public v9.2.1 Build, the decompiled code seems readable as shown below.

However, when i import the same exe into the dev Build, the decompiled code seems weird and difficult to understand

Is it normal for me to receive the errors above? And is it normal for the decompiled code in Dev Build to be less readable?

The ghidra repo does not contain all of the large Function ID database files, which are used to identify your missing library functions.  They can be found in this repo: https://github.com/NationalSecurityAgency/ghidra-data/tree/master/FunctionID
Here is another ticket that talks about how to get them imported into Ghidra: https://github.com/NationalSecurityAgency/ghidra/issues/1847

@ryanmkurtz sflr, thank you for your reply, will try it out. But for the errors on the missing DLLs as shown in the first screenshot, is it normal to receive those?

The [KERNEL32.DLL] -> not found means that when Ghidra was trying to resolve the external references of the program you imported, it failed to find an already imported KERNEL32.DLL program in your Ghidra project.  You could either manually import it, or when you go to import your main program, check the "Load External Libraries" option.  This is only useful if you want to also reverse engineer kernel32.dll and you want the convenience of being able to click on the external reference from your main program to have Ghidra automatically take you into kernel32.dll at the right spot.


Can't find dev server on safari

Hi I created a new bedframe project. After running converting to safari, running in xcode, running npm run dev safari, I can't open the extension settings

Did a miss a set up step?

Hi @MalikElate Thanks for checking out Bedframe! No, I don't think you missed a step.
It's just not how the Safari Web Extension dev process works. I'm not sure (right now) its going to be possible to dev for Safari like you would the Chromium-based and Firefox browsers.
Using the convert:safari package.json script, the packaged /dist/safari output is being referenced in the XCode project but since you actually have to package (aka compile) the extension and install it for Safari, I don't think the traditional JS dev process (with Vite's HMR/ live reloading) is going to be possible there.

In case I'm wrong, peruse the official Developing a Safari Web Extension docs and see if you find any info about it there.
Might also be helpful to check out the safari-web-extension-converter docs so you can update the convert:safari script options if need be


[BugFix] Fix the HttpServer not wait the threads finished.

Upon exit gracefully, the HttpServer should guarantee all the threads
are finished. Otherwise, the memory leak will be thrown. The pull request fixes the bug.
What type of PR is this：

[x] bug
[ ] feature
[ ] enhancement
[ ] refactor
[ ] others

Which issues of this PR fixes ：

Fixes #6738
Problem Summary(Required) ：

run starrocks_clang-format


Removed Fixnum and Bignum

Prints deprecation warnings about Fixnum and Bignum, in ruby 2.4 these types are unified to integer.

Coverage increased (+0.5%) to 97.527% when pulling a761fbef702bccf6366d5a824b72ae9b491a6286 on janmaghuyop:patch-1 into 0ce7faa451db8c66b9cbfac4b27e7eb708ea9879 on piotrmurach:master.

Coverage increased (+0.5%) to 97.527% when pulling a761fbef702bccf6366d5a824b72ae9b491a6286 on janmaghuyop:patch-1 into 0ce7faa451db8c66b9cbfac4b27e7eb708ea9879 on piotrmurach:master.

Coverage increased (+0.5%) to 97.527% when pulling a761fbef702bccf6366d5a824b72ae9b491a6286 on janmaghuyop:patch-1 into 0ce7faa451db8c66b9cbfac4b27e7eb708ea9879 on piotrmurach:master.

Coverage increased (+0.5%) to 97.527% when pulling a761fbef702bccf6366d5a824b72ae9b491a6286 on janmaghuyop:patch-1 into 0ce7faa451db8c66b9cbfac4b27e7eb708ea9879 on piotrmurach:master.

Coverage increased (+0.5%) to 97.527% when pulling a761fbef702bccf6366d5a824b72ae9b491a6286 on janmaghuyop:patch-1 into 0ce7faa451db8c66b9cbfac4b27e7eb708ea9879 on piotrmurach:master.

Oops, have to fix other versions too.

Hi Jan,
Thanks for using the library and attempting to fix the issue.
I would suggest fixing the problem by detecting ruby version with RUBY_VERSION constant.


[XGLUE] Adding new dataset

XGLUE is a multilingual GLUE like dataset propesed in this paper.
I'm planning on adding the dataset to the library myself in a couple of weeks.
Also tagging @JetRunner @qiweizhen in case I need some guidance

Amazing!

Small poll  @thomwolf @yjernite @lhoestq @JetRunner @qiweizhen .
As stated in the XGLUE paper: https://arxiv.org/pdf/2004.01401.pdf , for each of the 11 down-stream tasks training data is only available in English, whereas development and test data is available in multiple different language cf. here:

So, I'd suggest to have exactly 11 "language-independent" configs: "ner", "pos", ... and give the sample in each dataset in the config a "language" label being one of "ar", "bg", .... => To me this makes more sense than making languaga specific config, e.g. "ner-de", ...especially because training data is only available in English. Do you guys agree?

I see your point!
I think this would be quite feasible to do and makes sense to me as well! In the paper results are reported per language, so it seems more natural to do it this way.
Good for me @yjernite ! What do the others think?

I agree with Yacine on this!

Okey actually not that easy to add things like test-de to datasets => this would be the first dataset to have this.

IMO we should have one config per language. That's what we're doing for xnli, xtreme etc.
Having split names that depend on the language seems wrong. We should try to avoid split names that are not train/val/test.
Sorry for late response on this one

@lhoestq agreed on having one config per language, but we also need to be able to have different split names and people are going to want to use hyphens, so we should at the very least warn them why it's failing :) E.g. for ANLI with different stages of data (currently using underscores) or https://www.tau-nlp.org/commonsenseqa with their train-sanity or dev-sanity splits

Yes sure ! Could you open a separate issue for that ?

Really cool dataset 👍 btw. does Transformers support all 11 tasks 🤔 would be awesome to have a xglue script (like the "normal" glue one)

Just to make sure this is what we want here. If we add one config per language,
this means that this dataset ends up with well over 100 different configs most of which will have the same train split. The train split is always in English. Also, I'm not sure whether it's better for the user to be honest.
I think it could be quite confusing for the user to have
``
train_dataset = load_dataset("xglue", "ner-de", split="train")

in English even though it's `ner-de`.

Oh yes right I didn't notice the train set was always in english sorry.
Moreover it seems that the way this dataset is used is to pick a pretrained multilingual model, fine-tune it on the english train set and then evaluate on each test set (one per language).
So to better fit the usual usage of this dataset, I agree that it's better to have one test split per language.
Something like your latest example patrick is fine imo :
train_dataset = load_dataset("xglue", "ner", split="train")
test_dataset_de = load_dataset("xglue", "ner", split="test.de")

I just replace test-de with test.de since - is not allowed for split names (it has to follow the \w+ regex), and usually we specify the language after a point.

Closing since XGLUE has been added in #802 , thanks patrick :)

Closing since XGLUE has been added in #802 , thanks patrick :)

I need xglue Urdu summarization dataset so how can i get it?

According to the table in https://huggingface.co/datasets/xglue, Urdu only exists for POS and XNLI in XGLUE - not for summarization

any other solution for urdu summarization?


bug: running instance_segmentation or object_detection without RENDER_MODE input caused xcb error

Version
What release version was the issue found in? 1.6.0
Hardware configuration
all
Describe the bug
when running instance_segmentation or object_detection without RENDER_MODE input, it will failed the pipeline run with below error:
[ INFO ] Connecting to remote model: localhost:9000/models/instance-segmentation-security-1040
[ INFO ] 	Input layer: image, shape: [1, 608, 608, 3], precision: FP32, layout: NHWC
[ INFO ] 	Output layer: 3523, shape: [-1, 5], precision: FP32, layout:
[ INFO ] 	Output layer: masks, shape: [-1, 28, 28], precision: FP32, layout:
[ INFO ] 	Output layer: 3524, shape: [-1], precision: I64, layout:
Authorization required, but no authorization protocol specified
qt.qpa.xcb: could not connect to display :1
qt.qpa.plugin: Could not load the Qt platform plugin "xcb" in "/usr/local/lib/python3.10/site-packages/cv2/qt/plugins" even though it was found.
This application failed to start because no Qt platform plugin could be initialized. Reinstalling the application may fix this problem.
Available platform plugins are: xcb.
when running script command without RENDER_MODE=1, the default would be 0, in such case, we wouldn't need to trigger the UI or the xcb error above
To Reproduce
in a clean box,

make build-ovms-server
make build-grpc-python
make build-python-apps
./camera-simulator/camera-simulator.sh
PIPELINE_PROFILE="object_detection" sudo -E ./run.sh --workload ovms --platform core --inputsrc rtsp://<IP_ADDRESS>:8554/camera_0
go to r0.jsonl file under results/, you will see above error

Add workaround in troubleshooting.md

Re-tested and unable to reproduce the xcb error behavior either for object_detection profile nor instance_segmentation profile.
This old issue may have already been fixed from past commits.
close the issue.


renewed certificate not reflecting in mutatingwebhookconfigurations inferenceservice.serving.kubeflow.org

/kind bug
What steps did you take and what happened:
We have a cluster up and running since 3 months, last week, kfserving-webhook-server-cert certificate was updated
Certificate: kfserving-webhook-server-cert
Valid Beginning:
01/29/2021 (7 days ago)
Expires:
04/29/2021 (in 3 months)
Algorithm:
RSA - 256 bits
Issuer:
kfserving-webhook-server-service.kubeflow.svc
Since then, we were getting the following when we try to create a kfserving inferenceservice
kubectl --kubeconfig=cloudconfig apply -f pytorch-transformer.yml -n ainadel-ns
Error from server (InternalError): error when creating "pytorch-transformer.yml": Internal error occurred: failed calling webhook "inferenceservice.kfserving-webhook-server.defaulter": Post https://kfserving-webhook-server-service.kubeflow.svc:443/mutate-inferenceservices?timeout=30s: x509: certificate signed by unknown authority (possibly because of "x509: invalid signature: parent certificate cannot sign this kind of certificate" while trying to verify candidate authority certificate "kfserving-webhook-server-service.kubeflow.svc")
We deleted the inferenceservice.serving.kubeflow.org and validation webhook and deleted the kfserving-controller-manager-0 pod
The kfserving-controller-manager-pod-0 came up but the inferenceservice.serving.kubeflow.org and validation webhooks were not recreated.
After a bit of reading on https://cert-manager.io/docs/concepts/ca-injector/
cabundle on the mutating webhooks was updated with the  ca.crt from the “kfserving-webhook-server-cert” and mutating webhooks were recreated from backup. Then the inferenceservice was deployed successfully.
What did you expect to happen:
After  kfserving-webhook-server-cert certificate is updated , the cabundle should automatically get updated in the webhooks and kfserving controller should create those webhooks
Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]
Environment:

Istio Version: 1.3
Knative Version: 0.11
KFServing Version: 0.4.0
Kubeflow version: 1.1
Kfdef:[k8s_istio/istio_dex/gcp_basic_auth/gcp_iap/aws/aws_cognito/ibm]
Minikube version:
Kubernetes version: (use kubectl version): 1.16
OS (e.g. from /etc/os-release):

Thank you @prgawade for raising the issue. It helped me solve this issue.
Environment:

Istio Version: 1.5
Knative Version: 0.15
KFServing Version: 0.3.0
Kubeflow version: 1.1

In case anybody has the same issue, this is what worked for us:
As written here https://cert-manager.io/docs/concepts/ca-injector/, we need to make sure that caBundle if the mutatingwebhookconfiguration (and validatingwebhookconfigurations) is the same as the ca.crt field of the secret. In this case, for kfserving, the resources are:
mutatingwebhookconfiguration: inferenceservice.serving.kubeflow.org
validatingwebhookconfigurations: inferenceservice.serving.kubeflow.org
certificate: serving-cert
secret: kfserving-webhook-server-cert

These should be equal:
kubectl get mutatingwebhookconfiguration inferenceservice.serving.kubeflow.org -o yaml | grep caBundle
kubectl -n kubeflow get secret kfserving-webhook-server-cert -o yaml | grep ca.crt

These also should be equal:
kubectl get validatingwebhookconfiguration inferenceservice.serving.kubeflow.org -o yaml | grep caBundle
kubectl -n kubeflow get secret kfserving-webhook-server-cert -o yaml | grep ca.crt

The solution was to recreate mutatingwebhookconfiguration and validatingwebhookconfiguration.
First delete them:
kubectl delete mutatingwebhookconfiguration inferenceservice.serving.kubeflow.org
kubectl delete validatingwebhookconfiguration inferenceservice.serving.kubeflow.org

Find the template here: webhooks.yaml
Get the ca.crt value from the certificate secret:
kubectl -n kubeflow get secret kfserving-webhook-server-cert -o yaml | grep ca.crt
Copy the value to the caBundle fields of webhooks.yaml.
Apply the changes (create webhooks):
kubectl apply webhooks.yaml

For others who encounter the same problem, @d-gol 's solution was correct.
However I recommend use kubectl edit to change the caBundle value, instead of a template webhooks.yaml, as the template may be incompatible with your version.


Add a lines_between_sections setting

Pretty self-explanatory. I'd like to be able to still split imports into sections, but not have a blank line between each section. This seems to do the trick nicely, and would allow people to put more space between sections if they wanted, too. Test included.

LGTM! Thanks for implementing this :)
~Timothy

Thanks for accepting it! Any chance I could pester you for a PyPI update?


feat: add local storage plugin clear on submit config

I have just added a little config for clearing the local storage on submission of the form.
We have a use case where it is helpful to not clear this on submit. I have made it default to true so this should have no consequences for existing users.

This looks good to me! We'll get it folded into the next release!


feat: add forward_attrs to all macros

Previously, only allow, cfg and doc are forwarded. This makes the crate hard to use with crates like serde that need attributes.
This PR adds forward_attrs to all macros and allows users to specify which attributes to forward. An example would be:
#[derive(Debug, PartialEq, Serialize, Deserialize, Omit)]
#[omit(arg(ident = OmitCD, fields(c, d), derive(Debug, PartialEq, Serialize, Deserialize), forward_attrs(serde)))]
#[serde(rename_all = "UPPERCASE")]
pub struct Foo {
    a: u8,
    b: Option<u8>,
    c: Option<Vec<u8>>,
}

let omit_cd: OmitCD = serde_json::from_str(r#"{"A": 1, "B": 2}"#).unwrap();
assert_eq!(omit_cd, OmitCD { a: 1, b: Some(2) });

Mostly fix #9, but several issues are not solved yet:

users' provided attributes overwrite the default list. Users must manually specify allow, cfg, and doc if forward_attrs is used.
Which attributes should be in the default list? Maybe all common attributes in Rust should be forwarded?
Currently, custom attributes for specific generated structs or enums are not implemented. That is, only forwarding is implemented in this PR

I have updated the behavior of forward_attrs according to @siketyan 's suggestions:

If not provided, all attributes are forwarded by default.
If provided with a list of attributes, only the specified attributes are forwarded.

For example, forward_attrs(doc, serde) will forward only doc and serde.
If provided with only * (forward_attrs(*)), all attributes are forwarded.
If provided with an empty list (forward_attrs()), no attributes are forwarded.

If provided with a list inside not(), all attributes except the specified attributes are forwarded.

For example, forward_attrs(not(serde)) will forward all attributes except serde.

I haven't thought of how to fully test these attributes. But the cargo-expand's result seems good.


refactor: replace pify by util.promisify

Types of changes

[ ] Bug fix (a non-breaking change which fixes an issue)
[ ] New feature (a non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[x] Refactor

Description

Since Node.js v8.0.0, a new utility function util.promisify() is available. It converts a callback-based function to a Promise-based one. So the pify dependency become useless.
Note that a part of Nuxt's source code already uses util.promisify.
Checklist:

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly. (PR: #)
[ ] I have added tests to cover my changes (if not applicable, please state why)
[ ] All new and existing tests are passing.

Codecov Report

Merging #4617 into dev will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##              dev    #4617   +/-   ##
=======================================
  Coverage   90.88%   90.88%
=======================================
  Files          67       67
  Lines        2206     2206
  Branches      536      536
=======================================
  Hits         2005     2005
  Misses        182      182
  Partials       19       19

Impacted Files
Coverage Δ

packages/webpack/src/builder.js
93.68% <100%> (ø)
:arrow_up:

packages/builder/src/builder.js
96.7% <100%> (ø)
:arrow_up:

packages/server/src/listener.js
98.11% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf4803a...458d8e6. Read the comment docs.


[Bug] there is a unexpect bracket

Reproducible in vscode.dev or in VS Code Desktop?

[X] Not reproducible in vscode.dev or VS Code Desktop

Reproducible in the monaco editor playground?

[ ] Not reproducible in the monaco editor playground

Monaco Editor Playground Link
https://microsoft.github.io/monaco-editor/playground.html?source=v0.49.0#XQAAAAI9AQAAAAAAAABBqQkHQ5NjdMjwa-jY7SIQ9S7DNlzs5W-mwj0fe1ZCDRFc9ws9XQE0SJE1jc2VKxhaLFIw9vEWSxW3yscrRIG9UcqL31As63aQy62VWhMDHT6IcUUnGGdK_1yrN_xlAwToPtHwWASnqo0pHyQu_gITish86Pp5B0Fw1Q7j_2KlSwLhjOnhRdGp6F4BgtjleFmVH0tJ8Iy3zQ02nnT4MoqKwtaS6_QF4EtEk4SIi7DIkgUEfPBy_8I0mzmj_5b_ECI4x04vlhLgRwgep0bRNi6Vnt8myG4U6CnlCwvWhkENLFaM1yqKhdLhtqL8fqRPW19ls-DMhVNEhx_0KDr-NMeJeP-36av9qo-R
Monaco Editor Playground Code
const value = /* set from `myEditor.getModel()`: */ `echo \$(hello | grep "no such file(s)")`;

const myEditor = monaco.editor.create(document.getElementById("container"), {
	value,
	language: "shell",

});

echo $(hello | grep "no such file(s)")

Reproduction Steps
No response
Actual (Problematic) Behavior

Expected Behavior
No response
Additional Context
No response

any suggestion?


Broken link

There are two broken links.
https://github.com/rancher/docs/blob/master/content/rancher/v2.x/en/installation/server-installation/_index.md#rancher-server-installation

Fixed in https://github.com/rancher/docs/commit/e1e17ddbf6e32aa71e17ea516556fee44e41c476


Migrate pub in flutter_tools to null safety

Part of #71511

Trade you for https://github.com/flutter/flutter/pull/80462

Trade you for #80462

Done.


Metrics table view selected isn't remembered when coming back to metrics

Should be remembered like instrument is.

Persistence via query string


process has died

I installed the package following instructions but I see the package name is lucid_vision_driver while readme file says another. However, I am now using correct package name in the launch file and got this error:
zillur@trc:~$ ros2 launch lucid_vision_driver test_node_container.launch.py
[INFO] [launch]: All log files can be found below /home/zillur/.ros/log/2023-06-18-12-40-10-272274-trc-4375
[INFO] [launch]: Default logging verbosity is set to INFO
[INFO] [component_container-1]: process started with pid [4388]
[component_container-1] [INFO] [1687117210.670763303] [perception.object_detection.camera_node_right]: Load Library: /home/zillur/ros2_ws/install/lucid_vision_driver/lib/libarena_camera_node.so
[component_container-1] [INFO] [1687117210.751479257] [perception.object_detection.camera_node_right]: Found class: rclcpp_components::NodeFactoryTemplate<ArenaCameraNode>
[component_container-1] [INFO] [1687117210.751533363] [perception.object_detection.camera_node_right]: Instantiate class: rclcpp_components::NodeFactoryTemplate<ArenaCameraNode>
[component_container-1] Camera readed from yaml file. Camera Name:camera_1 Frame id:camera_top/camera_link Serial no:221202855 Pixel_format:bgr8 FPS:15
[component_container-1]  ~ArenaCamerasHandler()
[ERROR] [component_container-1]: process has died [pid 4388, exit code -11, cmd '/opt/ros/humble/lib/rclcpp_components/component_container --ros-args -r __node:=camera_node_right -r __ns:=/perception/object_detection'].
^C[WARNING] [launch]: user interrupted with ctrl-c (SIGINT)
[WARNING] [launch_ros.actions.load_composable_nodes]: Abandoning wait for the '/perception/object_detection/camera_node_right/_container/load_node' service response, due to shutdown.
zillur@trc:~$

Encountered the same issue, was this every solved?

Im facing with the same problem. Is there any solution?


Repressed Memory - small bug where looking at discard pile reduces max hp

Per nl364 in discord, deferring review for the moment:

I’m away from computer, but I just realized RepressedMemory needs a separate thing on start of act. Kinda just making a note/saying don’t look at the pr again yet

The debuff should only happen when discarded from hand (end of turn or manually). See response from jorbs:
https://discordapp.com/channels/329758756076519436/638465421598654496/770289567063998464
I think all we need to do is override the triggerOnManualDiscard() and triggerOnEndOfPlayerTurn(). For the later, we need to check if player has runic pyramid. The rest should be fine I think.

Also I think you have the same issue here with branch names as with posession, one is repressedMemory one is repressedmemory, the later looks like it is more up to date.

Closing PR so that I can submit one from my repo with master merges/fixes/etc


ngModel doesn't work with onClick

I'm not sure if it's the same bug as the ngModelChange. I modified the existing demo to this:
native-cmp.html

Async local data of countries - overrideSuggested, inputDisabled, inputClass and
                fieldTabindex

				<ng2-completer [(ngModel)]="countryName3" [dataService]="dataService3" [minSearchLength]="3"
					[placeholder]="'search country'" [overrideSuggested]="true" [disableInput]="searchcb"
					[fieldTabindex]="-1" [inputClass]="'my-input-class'">
				</ng2-completer>

				<button (click)="onClick()">click</button>

Selected: {{countryName3}}

            Disable search
            <input type="checkbox" [(ngModel)]="searchcb" />

native-cmp.ts
	private countryName3: string;
	public onClick() {
		alert(this.countryName3);
	}

Enter something in the ng2-completer input. Do NOT press enter or select anything. Just click on the button. The alert will not get the value of what was entered. If you click it the second time, the ngModel will then get the change and alert will display the correct input value.

my solution was to use a viewchild on the CompleterCmp and get its searchStr
.
.
.
onClick() {
   this.value = this.completer.searchStr;
}

I know it looks like a complete hack but can anyone think of something that can go wrong?

@NguyenDo-Consulting I think it's a duplicate of #93 since what you want is to get the input string before it is selected right?

Same here, exactly that: get the input string before it is selected
how is possible?

is it still relevant?

It is because I have to add my fix for every new release you make. Can you
add an attribute to from and default to false? This is so it doesn't break
what people already has.
On Jun 9, 2017 11:08 PM, "Ofer Herman"<EMAIL_ADDRESS>wrote:

is it still relevant?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/oferh/ng2-completer/issues/119#issuecomment-307537956,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AVITkWgexKR1c-9QeL-iNA0PSsYVM16-ks5sCgiXgaJpZM4LdRsa
.

With 1.6.0 looks like it's working properly


mergeSchema - fragments can be filtered even if subfragments are valid

If the interface or union only exists on mergedSchema level, subschema query merging will filter out fragments on that interface, even if its contets are valid.
Example

This is fixed now with abstract type expansion in #527


Fix deprecation warning: _app_ctx_stack -> g

There are Flask deprecation warnings, this PR aims to update to the current approach recommended by Flask
======================================= warnings summary ========================================tests/test_decorators.py::test_cognito_login
tests/test_decorators.py::test_cognito_custom_state
tests/test_decorators.py::test_cognito_custom_scopes
tests/test_plugin.py::test_plugin_get_tokens
  /home/jak/code/flask-cognito-lib/src/flask_cognito_lib/plugin.py:70: DeprecationWarning: '_app_ctx_stack' is deprecated and will be removed in Flask 2.4. Use 'g' to store data, or 'app_ctx' to access the current context.
    ctx = ctx_stack.top

tests/test_decorators.py: 10 tests with warnings
  /home/jak/code/flask-cognito-lib/src/flask_cognito_lib/plugin.py:54: DeprecationWarning: '_app_ctx_stack' is deprecated and will be removed in Flask 2.4. Use 'g' to store data, or 'app_ctx' to access the current context.
    ctx = ctx_stack.top

I think I've used the right approach here, slightly hesitant to have removed the if ctx is not None: check, and wondering if it should be replaced by something like
with app.app_context():

Thanks,
Jak

Codecov Report

Merging #19 (fd4b30b) into main (c493f07) will not change coverage.
The diff coverage is 100.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@            Coverage Diff            @@
##              main       #19   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            9         9
  Lines          304       299    -5
=========================================
- Hits           304       299    -5

Impacted Files
Coverage Δ

src/flask_cognito_lib/plugin.py
100.00% <100.00%> (ø)

LGTM thanks. Think the recommendation is store to store in g now as you have done.


Support functions, but without return statements

With this PR:

We can declare functions, but they cannot have return statements in the body
We can apply functions that we've declared OR the built in functions

The value of a function application is the value of the last statement in the body.
Reason for omitting return statments: To get a basic working implementation of function applications first
Try in the REPL:
list(amb(1,2,3));
function integer_from(n) { amb(n, integer_from(n + 1)); } integer_from(1);
function an_element_of(xs) { require(!is_null(xs)); amb(head(xs), an_element_of(tail(xs))); } an_element_of(list(1,2,3));

I've added a very basic draft of the return statements' support (without tail call optimisation)


Produce profiling information

Very useful for performance analysis for our PASC paper will be all or part of the following:

GPU Occupancy
Computation / Communication Times (Measuring overlap)
GFlops

Related Idea on Korali's side: https://github.com/cselab/korali/issues/317

I close it from here, this does not belong to that repository


fix: add stderr logging

Will delay merge as I want to put in tests for both standard and error logging


Array format for plot_multi functions

At the moment, the functions in the module trope_clustering.plot.*_multi() are still taking the array of data points in the old shape (n_dims, n_particles, n_frames). This is because we are not still committed to a specific input format for the clustering functions, due to the compatibility issues with scikit-learn.
So, I will address this problem only when that issue will be solved. For now, the functions are usable, just with the "old" array shape.

The issue with the array shape in scikit is solved, but I am having problems in correctly change the plotting code.
Updates will follow. Anyway, everything works correctly right now, so nothing to worry about.


[wip] notifier.run() emits a single notification per violation pipeline

The idea is to make notifier.run() emit a single notification per violation pipeline with the least amount of code change

the notifier section in forseti_conf.yaml does not change
the violations for all enabled resources are added to a single, shared pipeline instance (see first commit)
all (violation) pipelines need to be adjusted so they can handle violations for 1+ resources (see second commit)

This fixes (part of) issue #1060
TODO: switch all violation pipelines from json to CVS.

This will not work. As Joe pointed out, the pipeline configuration may be very different in which case we cannot emit a single notification. Please ignore.


Default process user to container config user.

Fixes #14115
Signed-off-by: David Calavera<EMAIL_ADDRESS>

Looks like it should be ok, but really needs a test.
Probably two tests, one to make sure the user in the exec is as expected, and another that subsequent exec's default user config are correct.

do we have a small image to test user changes? I'm not sure if we can test this with busybox.

How come?
docker run -d -u 1000 --name test busybox top
docker exec test id                   # should be `uid=1000 gid=0(root)`
docker exec -u 1001 test id           # should be `uid=1001 gid=0(root)`
docker exec test id                   # should be `uid=1000 gid=0(root)`

I added a test

@LK4D4 I've cleaned the test. There was a bunch of copy/paste from the builder tests that was not necessary.

LGTM

LGTM

Cherry picked into the 1.7.1 release branch.

Thanks guys :+1:


'FakeFilesystem' object has no attribute 'create_file' with pytest

import os

from pyfakefs.pytest_plugin import fs

def test_my_fakefs(fs):
    # "fs" is the reference to the fake file system
    fs.create_file('/var/data/xx1.txt')
    assert os.path.exists('/var/data/xx1.txt')

When this test is executed I get the following error. I've tested on both Python2 and Python3 with the latest versions of pytest and pyfakefs
fs = <pyfakefs.fake_filesystem.FakeFilesystem object at 0x106bef290>

>   ???
E   AttributeError: 'FakeFilesystem' object has no attribute 'create_file'

Users/cada/development/user.workflow.A62099B7-A846-46E1-9BB0-652882B4C083/test_macdown.py:12: AttributeError
======================================================================== 1 failed in 0.28 seconds ========================================================================

Does this happen with the current master?

This also fails with the same error
import glob
import unittest

from pyfakefs.fake_filesystem_unittest import Patcher

class TestMacdown(unittest.TestCase):
    def test_stuff(self):
        with Patcher() as patcher:
            patcher.fs.create_file('/tmp/macdown/test.md')

Let me check if happens with the latest master! 👍

I'm asking because the API has changed from the last released version to be pep8 conform. So if you are using the version from pypi, you have to check the release documentation.
http://jmcgeheeiv.github.io/pyfakefs/release/

Yes of course I was reading the latest documentation while using the 3.3 version :)

Ok, we will probably  release a new version soon to avoid this kind of confusion :)

Can we close this issue then?

Yes absolutly!


added www.codepreneur.io entry

:)

@MoOx ^

Won't be online quickly are we are freezing v0.x right now to focus on v1 (first public alpha at the end of this month)


API Validation and Cleanup

Adds min and max length everywhere possible
Removes +required since it is inferred
Updates default fields to no longer be optional
Updates Routes to use HTTP forward to style and shared type
Fixes all examples to be valid again

Fixes https://github.com/kubernetes-sigs/service-apis/issues/290
/cc @hbagdi @danehans

Rob, is it a lot of work to remove Flattening Route form this PR?
That might help with quality and speed of reviews and getting this in faster.

@hbagdi That's definitely my intent. For now they're two separate commits in the same PR because I already have so many others that will require rebasing. I'm trying to push for those to get in first and then work on the clean up and then flattening the route just so I don't have endless rebasing.

If anyone would prefer to review route flattening separately, I've created another PR that is a subset of this one: https://github.com/kubernetes-sigs/service-apis/pull/353

If anyone would prefer to review route flattening separately, I've created another PR that is a subset of this one: #353

If route flattening has been removed from this PR, can you update the description.

A few nits, otherwise LGTM.

Now that https://github.com/kubernetes-sigs/service-apis/pull/353 is in, I've updated this PR to be purely focused on API cleanup again. Thanks to everyone for the great feedback, I think I've resolved everything now. PTAL.

/lgtm
/approve


Field "valid until" for recovery is not checked in Android - should be equal to iOS App check

If the date in the valid until field is expired, certificate should not longer be vaild.
The behaviour should be the same like in iOS App so that both apps show the same certificate status and message.

https://github.com/SchulzeStTSI/dgca-verifier-app-android/commit/5c53221c69579a9d184751ca040bbc3080a92b18
https://github.com/SchulzeStTSI/dgca-app-core-android/commit/48534b5939b983e6c4a2b16f013944a99105b074
https://github.com/SchulzeStTSI/dgca-app-core-android/commit/bfa1849574072ca1dc1def9f6c6cb459dde87938
https://github.com/SchulzeStTSI/dgca-app-core-android/commit/ebbb5a9d7934e201f6ac7e7cc24409936bf98533
https://github.com/SchulzeStTSI/dgca-app-core-android/commit/af1010166e4e7d917bbd67cf8b76b1febee024f9


git-branch-push.ps1 and git-push-changes.yml should support skipping remediation steps

Since the remediation process could change the SHA this can break instances where a commit SHA is referenced in commits that were intended to be pushed.
In short: Try to push what's in the repo and do not try to remediate if the push fails.

We have a workaround for the problem that came up originally.  This was a follow up item.  Now that 7 months have passed, I'd say we're probably not going to get to this.  If it comes up again, we'll deal with the problem at hand at that time.