PathFor("tmp") weirdness on OSX

I thought this was fixed, or I found a workaround.
'readCoverageGlobal' task is having problems finding the tmpdir

Right, I remember now...
Firefox
FileUtils.getFile("TmpD","").path
"/Users/glind/Library/Caches/TemporaryItems"

node-global
'/var/folders/0z/4g3t_26s3gv835xswsslbn400000gq/T/istanbul-jpm-coverage.json'

Suggestion for fixing this seem best if we force them to be the same somehow.  Ideas welcome :)  Seems like putting both in the coverage dir (via process.env?) might might sense?

Never mind, we fixed this in #2 :)  upgrading now :)

yes, I made a minor version bump and due to how semver works npm might not auto update it if you installed it with --save(-dev).


Thoughts on Hyperpixel Screens?

Juj-
Was curious if you have experimented with either of the Hyperpixel displays, especially the new 4.0” version. I wonder if your driver could incorporate that display and the resolution that it puts out?

The HyperPixel displays (if this product?) seem to use a DPI bus, which means that the Raspberry Pi GPU firmware has built-in support for outputting to the display. So a software driver such as fbcp-ili9341 is then not needed. (fbcp-ili9341 is only for SPI based displays)
The built-in firmware support should give it hiccup free 60fps update rate out of the box.
That aside, theoretically a resolution of 800x480 would not be infeasible for fbcp-ili9341 on an SPI display, but it naturally it would limit the maximum refresh rate, and increase CPU usage. On a Pi Zero, 800x480 would definitely be too much that one would have to resort to full screen updates, diffing 800x480 images would be too much work. On a Pi 3B, small graphical changes, such as X11 with only mouse cursor moving on screen, would still be expected to be fluid, although at a higher CPU overhead cost. I don't know if anyone actually manufactures a 800x480 sized SPI display, that is a bit high resolution for regular drivers to manage.


initial commit for flow dump feature to split architecture

Signed-off-by: Koushik-kopanati<EMAIL_ADDRESS>

Dont think this is correct. The plan is to have all TDI-related changes under stratum/hal/lib/tdi folder, while leaving all the bfrt_* related API calls in stratum/hal/lib/barefoot as they are.
@ffoulkes and @nupuruttarwar can comment for further clarification

Dont think this is correct. The plan is to have all TDI-related changes under stratum/hal/lib/tdi folder, while leaving all the bfrt_* related API calls in stratum/hal/lib/barefoot as they are.
@ffoulkes and @nupuruttarwar can comment for further clarification

Yes that's correct. @Koushik-kopanati please make changes under stratum/hal/lib/tdi for target agnostic changes and under stratum/hal/lib/tdi/dpdk for 7DPDK target specific changes

Need a follow up on why  build is failing


New pydantic release 2.0.0 breaks event-model

pydantic just released 2.0.0 which has api changes that break event-model.

Apologies, just made a new release specifying pydantic < 2.0.


Reusing existing parameter store parameters across several accounts is not possible and blocks the deployment

If the deployment of a service on an environement is done an account already (in my case the organisation account) and I want to deploy it in another account without properly deleting it from the original account it's not working.

Actually it seems that S3 access is the problem on the gamekit-dev-garou-main cloud formation file.
I tried to manually upload it to my account with the all admin access on it but I can't because of this S3 denied access problem.
Do you have any idea why this is happening?
Thanks,

Hey DevGarou,
Thanks for calling out this issue. We will look into reproducing it. To help us with reproducing this issue on our end would please add the following information?

Unreal Editor Version [e.g. 4.27.2]
OS and Version that you are developing on: [e.g. Windows 10]
The feature(s) you are deploying in both accounts [e.g. identity, achievements]
The environment(s) you are deploying to in both accounts [e.g. development]
The method you are using to delete the features from the original account.
If you made any changes to the cloudformation files.
Additionally, would you please help by providing your exact steps for reproducing the issue? Please do not include any sensitive information.

Thank you

Thank you for the information. I am continuing to try to reproduce this. In the meantime, i just wanted to verify if you had already gone through the steps mentioned in the AWS GameKit Docs for the second user where you are getting this permission error.

Try generating and using IAM user using this with your dev account details.
Also create a user for production environment using the script with production credentials and test that as well.
Let us know if any of them succeed or fail.

Thanks a lot for that, I tried it but this wasn't the issue.
I found out that in the generated cloudformation files for the project in dev/cloudformation/main/parameters the GameKitBase36AwsAccountId parameter was still the old accound ID so it couldn't access the resources since it was generated by another account and no access to it.
I had to manually replace the value with the new GameKitBase36AwsAccountId that I got from the s3 bucket containing the cloud formation files.

Note: That goes for other services that were enabled before like Identity, usergameplaydata etc...

Hello DevGarou,
Thank you for your update, I'm going to reopen this, as this sounds like a bug we should investigate further.
We will update this when we have more information.


Update README.md

A preview environment was automatically created via Qovery.
Click on the link below to follow its deployment and use it.
:point_right: [PR] test - Update README.md - 2023-03-22T15:49:50Z
Another comment will be posted when deployments are terminated


EfficientNet Fine Tuning : method built_model(num_classes) seems to use wrong parameter global NUM_CLASSES

Hi,
I think that the following method is corrupted as it is using the NUM_CLASS rather than the num_class parameter of the method.
def build_model(num_classes):
    inputs = layers.Input(shape=(IMG_SIZE, IMG_SIZE, 3))
    x = img_augmentation(inputs)
    model = EfficientNetB0(include_top=False, input_tensor=x, weights="imagenet")

    # Freeze the pretrained weights
    model.trainable = False

    # Rebuild top
    x = layers.GlobalAveragePooling2D(name="avg_pool")(model.output)
    x = layers.BatchNormalization()(x)

    top_dropout_rate = 0.2
    x = layers.Dropout(top_dropout_rate, name="top_dropout")(x)
    outputs = layers.Dense(NUM_CLASSES, activation="softmax", name="pred")(x)

    # Compile
    model = tf.keras.Model(inputs, outputs, name="EfficientNet")
    optimizer = tf.keras.optimizers.Adam(learning_rate=1e-2)
    model.compile(
        optimizer=optimizer, loss="categorical_crossentropy", metrics=["accuracy"]
    )
    return model

Best regards
Jerome

Thanks for reporting the issue.
It does not make any difference IMO, since the method call assigns num_classes=NUM_CLASSES in the below code.
with strategy.scope():
    model = build_model(num_classes=NUM_CLASSES)

I will create a PR to fix this typo.


Github integration

+1 on this!
since there are so many people/teams and company using github today,
having a good integration to github would imho be a major driver for adaption.
In best case there is a full working example of 2 microservices in 2 repositories connected with a pipeline of actions which has compatibility of both microservices "ready to deploy" as an automatic quality gate, similar to e.g. automatic checks for CVEs...

maybe fyi in this field:
it's a good help/save some time when dealing with 2 repositories, that reusable workflows is now available https://github.blog/2022-02-10-using-reusable-workflows-github-actions/

Thanks @hpvd, you can track this issue for sure as we add detail to it and schedule it on our roadmap. We think it will be a great enabler for our customers also :).
P.S. hope to see you in our community!

Lovely, thank you :)


Cyclops Level Builder 1.0.4 doesn't work in Godot 2.4.1 due to parse error

forgot details, it specifically doesn't allow to be checked on even after a full restart of Godot (closing and manually reopening.)

I followed the setup instructions incorrectly, there is no issue.


MediaSession is not working on V3

The mediaSession is not working properly on V3 branch. I wanna if anyone else also get the same issue.
This is very weird, if I comment out the initMediaSession function, it gets a higher probability to show the media control properly. However, it's not stable. When I keep attempting to reload and play music, I get a chance to see the function broken again.

My mediaSession will break on very rare occasions. Refreshes seem to fix the issue. I can't to reproduce it. Maybe we can try access navigator.mediaSession see the metadata is contact on a failed run?


Right align and reduce width of well clearing icon

Acceptance Criteria

[ ] Have the x icon be small and right aligned, like carats in step lists

Currently on production:

@howisthisnamenottakenyet same as #2672 ?


button box msg getter throws error if message was not previously set.

>>> box = eg.buttonbox('Test!', run=False)
>>> box.msg
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "\easygui\boxes\button_box.py", line 182, in msg
    return self._msg
AttributeError: 'ButtonBox' object has no attribute '_msg'

To avoid this, the _msg attribute should ideally be set in the BottonBox's __init__  method.

@spyoungtech - yep, I'd agree with your assessent! I've got a work-in-progress refactor on a branch which would do this, but it is incomplete. If you'd like to submit a patch request for this specific change in the meantime we could get it in sooner? Alternatively we can leave this open until I get around to finishing the refactor and fixing this.


Tests timeout in slow hardware

Hi,
I have received a few reports of goleveldb failing to compile in Debian, and all of these I could attribute to test timeouts expiring in slower hardware, or under CPU contention. Sometimes, the whole LevelDB suite would be killed by go test for passing the 10m mark.
I have made these changes in the Debian package, and it could be good to merge them in the tree, or get rid of timeouts altogether if that is possible (I don't know ginkgo).
I also had to disable completely TestCacheMap, as it seemed to hang on busy machines.
--- a/leveldb/iterator/indexed_iter_test.go
+++ b/leveldb/iterator/indexed_iter_test.go
@@ -69,7 +69,7 @@
 					}
 					testutil.DoIteratorTesting(&t)
 					done <- true
-				}, 1.5)
+				}, 15.0)
 			}
 		}

--- a/leveldb/testutil/kvtest.go
+++ b/leveldb/testutil/kvtest.go
@@ -140,7 +140,7 @@
 			TestIter(db, nil, kv.Clone())
 		}
 		done <- true
-	}, 3.0)
+	}, 30.0)

 	It("Should iterates and seeks slice correctly", func(done Done) {
 		if db, ok := p.(NewIterator); ok {
@@ -162,7 +162,7 @@
 			})
 		}
 		done <- true
-	}, 50.0)
+	}, 200.0)

 	It("Should iterates and seeks slice correctly", func(done Done) {
 		if db, ok := p.(NewIterator); ok {
--- a/leveldb/external_test.go
+++ b/leveldb/external_test.go
@@ -37,7 +37,7 @@
 				testutil.DoDBTesting(&t)
 				db.TestClose()
 				done <- true
-			}, 20.0)
+			}, 80.0)
 		})

 		Describe("read test", func() {
@@ -111,7 +111,7 @@

 				db.TestClose()
 				done <- true
-			}, 30.0)
+			}, 240.0)
 		})
 	})
 })
--- a/leveldb/iterator/merged_iter_test.go
+++ b/leveldb/iterator/merged_iter_test.go
@@ -49,7 +49,7 @@
 					}
 					testutil.DoIteratorTesting(&t)
 					done <- true
-				}, 1.5)
+				}, 15)
 			}
 		}

Unfortunately the timeout can't be disabled, but I can increase the timeout like you suggested. As for TestCacheMap I can probably reduce test params for short test (i.e. -test.short flag is set).


Auth error

Got this error :(
No access_token cached. Receiving new one
Opening browser
Paste url you've been redirected: Opening in existing browser session.
http://<IP_ADDRESS>/?code=d2G23X&state=state
Code: d2G23X
Bad response for getting access_token: <!doctype html><title>HTTP Status 401 – Unauthorized</title>
HTTP Status 401 – Unauthorized

Type Status Report

Message Unauthorized

Description The request has not been applied because it lacks valid authentication credentials for the target resource.

Apache Tomcat/9.0.43

CLIENT_ID and CLIENT_SECRET are OK

Hmmm, strange. Tried to get new token right now and all works. Maybe try different browser?

@UnkwUsr sorry for offtop, can you please tell me why this error appears?
it also doesn't work if i try it with sudo.
ticktask
zsh: Access denied: ticktask

sudo ticktask
sudo: ticktask: command not found

@LenaKiseleva I've noted this in the installation section now. Thanks!

@artromone reopen please if this is still issue for you

ftr I ran into this issue today but managed to work around it using python requests from this post

Hi! this still happens to me...
Bad response for getting access_token: <!doctype html>HTTP Status 401 – UnauthorizedHTTP Status 401 – UnauthorizedType Status ReportMessage UnauthorizedDescription The request has not been applied because it lacks valid authentication credentials for the target resource.Apache Tomcat/9.0.43
I am using <IP_ADDRESS> as the redirect url


SOLR-16584 BATS test fails stopping two instances

Well @janhoy looks like its not just your change :) I haven't figured out how to collect the logs yet, but worth trying to figure out why its failing separate of your change.

Don't we have at least nightly Jenkins runs of ./gradlew integrationTests ?

Don't we have at least nightly Jenkins runs of ./gradlew integrationTests ?

not that I could find from a quick check of the jobs here: https://ci-builds.apache.org/job/Solr/

Perhaps we should modify all our "Check xxx" Jenkins jobs to do check integrationTests? Or should check include integrationTests?

Perhaps we should modify all our "Check xxx" Jenkins jobs to do check integrationTests? Or should check include integrationTests?

I added it to the Project Solr-Check-main job (https://builds.apache.org/job/Solr/job/Solr-Check-main/) and it failed some times, but last run was successful! Did anything change on main branch or is this some timing/environment issue? 180 seconds is a looong time to shut down two solr nodes... But Jenkins may run on slow HW, and if it has low entropy as it sometimes complains, perhaps that has some impact?

I haven't narrowed the issue down any further yet. But my hunch is it fails to even try to kill the process with the separate port. I don't even see it yet to shutdown in the logs. Most likely need to add more logging to bin/solr to find out why

I added integrationTests task to Check jenkins job for 9.1 and 9.x as well, so we can see if it fails for those as well, or if this is something introduced in main.

The Check-main jenkins job had one single SUCCESS run, with integrationTests enabled, so we can officially declare it "flaky" and env-related.

I added integrationTests task to Check jenkins job for 9.1 and 9.x as well, so we can see if it fails for those as well, or if this is something introduced in main.

Interesting - the 9.1 jenkins runs succeed https://ci-builds.apache.org/job/Solr/job/Solr-check-9.1/
while the 9.x runs seem to be 50/50 https://ci-builds.apache.org/job/Solr/job/Solr-Check-9.x/

Well since solr/bin/* are the only files involved. That helps narrow it down considerably. I would guess its one of these changes...
# git log branch_9x..branch_9_1 -- solr/bin
commit a46d75ac8dd4a3550220c2ef46279873514749ce
Author: Kevin Risden<EMAIL_ADDRESS>Date:   Mon Nov 7 19:52:38 2022 -0500

    Revert "SOLR-16457: solr.data.home should not be set to empty string in bin/solr (#1066)" (#1165)

    This reverts commit e9100b9383a1f7e85285b381f5ee3eefda7814b4.

commit 69dde164368f999ffdf8ba43f18db958edcf6d28
Author: Houston Putman<EMAIL_ADDRESS>Date:   Thu Oct 20 11:58:47 2022 -0400

    SOLR-16482: Add internal envVar for passing opts to solr/bin (#1096)

    The name of the envVar is SOLR_OPTS_INTERNAL

    (cherry picked from commit fabdc8e836264f309c0224ef190abe13bb749641)

commit 99bd072c3cbff7b64aeba66aa6719f51fdb8502f
Author: Jan Høydahl<EMAIL_ADDRESS>Date:   Thu Oct 20 09:54:32 2022 +0200

    SOLR-16463: Workaround for serious crash on JDK17+ (#1090)

commit e9100b9383a1f7e85285b381f5ee3eefda7814b4
Author: Kevin Risden<EMAIL_ADDRESS>Date:   Wed Oct 12 12:11:26 2022 -0400

    SOLR-16457: solr.data.home should not be set to empty string in bin/solr (#1066)

So @janhoy can you sanity check me - at the bottom of https://github.com/apache/solr/actions/runs/3658565463 are the logs from the integration test run.
I don't see in solr.log or solr-7574-console.log anything about Solr shutting down or even attempting to.

I would guess the failure is line 850 though since it does || true
there must be some failure in Java stop script that doesn't log

@janhoy https://github.com/apache/solr/pull/1223/commits/b6d814aace03837fcc61e2aa2f4315b93610487b may have fixed it! I wonder if its a Jetty 10.x change...
I'm looking into https://github.com/apache/solr/pull/1223/commits/6b9e7ecd7c27d2eab491674023f8be2a84374eff as well.

Yes, I was just looking into the same...

I reproduced this locally in Docker:
docker run --rm -ti apache/solr-nightly:10.0.0-SNAPSHOT bash
Unable to find image 'apache/solr-nightly:10.0.0-SNAPSHOT' locally
10.0.0-SNAPSHOT: Pulling from apache/solr-nightly
Digest: sha256:df810e8fc7b81238f1339a9267ab3e0689a9295cb031776e8a8c9c5ba68dbdd3
Status: Downloaded newer image for apache/solr-nightly:10.0.0-SNAPSHOT
WARNING: The requested image's platform (linux/amd64) does not match the detected host platform (linux/arm64/v8) and no specific platform was requested
solr@00c425e5b1ca:/opt/solr-10.0.0-SNAPSHOT$ solr start -p 7000
Java 17 detected. Enabled workaround for SOLR-16463
Waiting up to 180 seconds to see Solr running on port 7000 [-]
Started Solr server on port 7000 (pid=127). Happy searching!

solr@00c425e5b1ca:/opt/solr-10.0.0-SNAPSHOT$ solr stop -V -p 7000
Using Solr root directory: /opt/solr
Using Java: /opt/java/openjdk/bin/java
openjdk version "17.0.5" 2022-10-18
OpenJDK Runtime Environment Temurin-17.0.5+8 (build 17.0.5+8)
OpenJDK 64-Bit Server VM Temurin-17.0.5+8 (build 17.0.5+8, mixed mode, sharing)
Sending stop command to Solr running on port 7000 ... waiting up to 180 seconds to allow Jetty process 127 to stop gracefully.
Solr process 127 is still running; jattach threaddumping it now.
Could not start attach mechanism: No such file or directory
Solr process 127 is still running; forcefully killing it now.
Killed process 127
solr@00c425e5b1ca:/opt/solr-10.0.0-SNAPSHOT$

So I undid all my changes for debugging and so what is left is just the stop.port and stop.key parts. In theory this will just work.
I have NO idea why this passes locally before this change...

I have NO idea why this passes locally before this change...

It all works on my Macbook. But in Docker under Ubuntu it is definitely not happy

I exec'ed into the container during the 180 seconds it tried to stop and found this
docker exec -ti 00c425e5b1ca bash                                                                                 ✔  10016  22:13:04
solr@00c425e5b1ca:/opt/solr-10.0.0-SNAPSHOT$ ps -efwww
UID        PID  PPID  C STIME TTY          TIME CMD
solr         1     0  0 21:08 pts/0    00:00:00 /usr/bin/qemu-x86_64 /usr/bin/bash bash
solr       127     1 99 21:10 pts/0    00:03:07 /usr/bin/qemu-x86_64 /opt/java/openjdk/bin/java /opt/java/openjdk/bin/java -server -Xms512m -Xmx512m -XX:+UseG1GC -XX:+PerfDisableSharedMem -XX:+ParallelRefProcEnabled -XX:MaxGCPauseMillis=250 -XX:+UseLargePages -XX:+AlwaysPreTouch -XX:+ExplicitGCInvokesConcurrent -Xlog:gc*:file=/var/solr/logs/solr_gc.log:time,uptime:filecount=9,filesize=20M -Dsolr.jetty.inetaccess.includes= -Dsolr.jetty.inetaccess.excludes= -Dsolr.log.dir=/var/solr/logs -Djetty.port=7000 -DSTOP.PORT=6000 -DSTOP.KEY=solrrocks -Duser.timezone=UTC -XX:-OmitStackTraceInFastThrow -XX:+CrashOnOutOfMemoryError -XX:ErrorFile=/var/solr/logs/jvm_crash_%p.log -Djetty.home=/opt/solr-10.0.0-SNAPSHOT/server -Dsolr.solr.home=/var/solr/data -Dsolr.install.dir=/opt/solr -Dsolr.default.confdir=/opt/solr-10.0.0-SNAPSHOT/server/solr/configsets/_default/conf -Dlog4j.configurationFile=/var/solr/log4j2.xml -Dsolr.jetty.host=<IP_ADDRESS> -Xss256k -XX:CompileCommand=exclude,com.github.benmanes.caffeine.cache.BoundedLocalCache::put -Djava.security.manager -Djava.security.policy=/opt/solr-10.0.0-SNAPSHOT/server/etc/security.policy -Djava.security.properties=/opt/solr-10.0.0-SNAPSHOT/server/etc/security.properties -Dsolr.internal.network.permission=* -DdisableAdminUI=false -Dsolr.log.muteconsole -jar start.jar --module=http --module=requestlog --module=gzip
solr       470     1  0 21:11 pts/0    00:00:00 /usr/bin/qemu-x86_64 /usr/bin/bash bash /opt/solr/bin/solr stop -V -p 7000
solr       594   470  0 21:11 pts/0    00:00:00 /usr/bin/qemu-x86_64 /usr/bin/bash bash /opt/solr/bin/solr stop -V -p 7000
solr      2819     0  2 21:13 pts/1    00:00:00 /usr/bin/qemu-x86_64 /usr/bin/bash bash
solr      2857   594  0 21:13 pts/0    00:00:00 /usr/bin/qemu-x86_64 /usr/bin/sleep sleep 2
solr      2875   470  0 21:13 pts/0    00:00:00 /usr/bin/qemu-x86_64 /usr/bin/sleep sleep 0.5
solr      2878  2819  0 05:27 ?        00:00:00 ps -efwww
solr@00c425e5b1ca:/opt/solr-10.0.0-SNAPSHOT$ ps -efwww
UID        PID  PPID  C STIME TTY          TIME CMD
solr         1     0  0 21:08 pts/0    00:00:00 /usr/bin/qemu-x86_64 /usr/bin/bash bash
solr       127     1 99 21:10 pts/0    00:03:19 /usr/bin/qemu-x86_64 /opt/java/openjdk/bin/java /opt/java/openjdk/bin/java -server -Xms512m -Xmx512m -XX:+UseG1GC -XX:+PerfDisableSharedMem -XX:+ParallelRefProcEnabled -XX:MaxGCPauseMillis=250 -XX:+UseLargePages -XX:+AlwaysPreTouch -XX:+ExplicitGCInvokesConcurrent -Xlog:gc*:file=/var/solr/logs/solr_gc.log:time,uptime:filecount=9,filesize=20M -Dsolr.jetty.inetaccess.includes= -Dsolr.jetty.inetaccess.excludes= -Dsolr.log.dir=/var/solr/logs -Djetty.port=7000 -DSTOP.PORT=6000 -DSTOP.KEY=solrrocks -Duser.timezone=UTC -XX:-OmitStackTraceInFastThrow -XX:+CrashOnOutOfMemoryError -XX:ErrorFile=/var/solr/logs/jvm_crash_%p.log -Djetty.home=/opt/solr-10.0.0-SNAPSHOT/server -Dsolr.solr.home=/var/solr/data -Dsolr.install.dir=/opt/solr -Dsolr.default.confdir=/opt/solr-10.0.0-SNAPSHOT/server/solr/configsets/_default/conf -Dlog4j.configurationFile=/var/solr/log4j2.xml -Dsolr.jetty.host=<IP_ADDRESS> -Xss256k -XX:CompileCommand=exclude,com.github.benmanes.caffeine.cache.BoundedLocalCache::put -Djava.security.manager -Djava.security.policy=/opt/solr-10.0.0-SNAPSHOT/server/etc/security.policy -Djava.security.properties=/opt/solr-10.0.0-SNAPSHOT/server/etc/security.properties -Dsolr.internal.network.permission=* -DdisableAdminUI=false -Dsolr.log.muteconsole -jar start.jar --module=http --module=requestlog --module=gzip
solr       470     1  0 21:11 pts/0    00:00:00 /usr/bin/qemu-x86_64 /usr/bin/bash bash /opt/solr/bin/solr stop -V -p 7000
solr       594   470  0 21:11 pts/0    00:00:00 /usr/bin/qemu-x86_64 /usr/bin/bash bash /opt/solr/bin/solr stop -V -p 7000
solr      2819     0  0 21:13 pts/1    00:00:00 /usr/bin/qemu-x86_64 /usr/bin/bash bash
solr      3070   594  1 21:13 pts/0    00:00:00 /usr/bin/qemu-x86_64 /usr/bin/sleep sleep 2
solr      3079  2819  0 05:27 ?        00:00:00 ps -efwww
solr      3082   470  0 21:13 pts/0    00:00:00 /usr/bin/qemu-x86_64 /usr/bin/ps ps -o pid= -p 594

You see Solr itself running in PID 127. But the ps command targets PID 594, which is the PID of the stop script, which sleeps in a loop of 2 seconds.
I think now that we have a super fast way of reproducing, it should be easier to debug

You see Solr itself running in PID 127. But the ps command targets PID 594, which is the PID of the stop script, which sleeps in a loop of 2 seconds.

ok cool thanks @janhoy most likely SOLR_PID is getting set wrong somehow.
One of these invocations:
# git grep -nF stop_solr
solr/bin/solr:840:function stop_solr() {
solr/bin/solr:905:} # end stop_solr
solr/bin/solr:1858:          stop_solr "$SOLR_SERVER_DIR" "$port" "$STOP_KEY" "$NEXT_PID"
solr/bin/solr:1879:          stop_solr "$SOLR_SERVER_DIR" "$port" "$STOP_KEY" "$CHECK_PID"
solr/bin/solr:1939:    stop_solr "$SOLR_SERVER_DIR" "$SOLR_PORT" "$STOP_KEY" "$SOLR_PID"

I think it is SOLR-16191

If I debug even on my laptop, the command ps -o stat='' -p $SOLR_PID returns just a single S, not a PID

I think thats correct - as long as it isn't a Z or empty - it finds the stat column without the header - so it returned a result.

I think thats correct - as long as it isn't a Z or empty - it finds the stat column without the header - so it returned a result.

Ok, might have been too quick to conclude there. And SOLR-16191 is in Solr 9.1 as well...

@janhoy at least from github actions the pid looks correct...:
https://github.com/apache/solr/actions/runs/3689576579/jobs/6245669505
#   line 1858
...
#   runner      2651  107  9.2 3098124 661288 ?      Sl   21:42   0:05 /opt/hostedtoolcache/Java_Temurin-Hotspot_jdk/11.0.17-8/x64/bin/java -server -Xms512m -Xmx512m -XX:+UseG1GC -XX:+PerfDisableSharedMem -XX:+ParallelRefProcEnabled -XX:MaxGCPauseMillis=250 -XX:+UseLargePages -XX:+AlwaysPreTouch -XX:+ExplicitGCInvokesConcurrent -Xlog:gc*:file=/home/runner/work/solr/solr/solr/packaging/build/test-output/solr-home/logs/solr_gc.log:time,uptime:filecount=9,filesize=20M -Dsolr.jetty.inetaccess.includes= -Dsolr.jetty.inetaccess.excludes= -Dsolr.log.dir=/home/runner/work/solr/solr/solr/packaging/build/test-output/solr-home/logs -Djetty.port=7574 -DSTOP.PORT=6574 -DSTOP.KEY=solrrocks -Dhost=localhost -Duser.timezone=UTC -XX:-OmitStackTraceInFastThrow -XX:+CrashOnOutOfMemoryError -XX:ErrorFile=/home/runner/work/solr/solr/solr/packaging/build/test-output/solr-home/logs/jvm_crash_%p.log -Djetty.home=/home/runner/work/solr/solr/solr/packaging/build/solr-10.0.0-SNAPSHOT/server -Dsolr.solr.home=/home/runner/work/solr/solr/solr/packaging/build/test-output/solr-home -Dsolr.install.dir=/home/runner/work/solr/solr/solr/packaging/build/solr-10.0.0-SNAPSHOT -Dsolr.default.confdir=/home/runner/work/solr/solr/solr/packaging/build/solr-10.0.0-SNAPSHOT/server/solr/configsets/_default/conf -Xss256k -Djava.security.manager -Djava.security.policy=/home/runner/work/solr/solr/solr/packaging/build/solr-10.0.0-SNAPSHOT/server/etc/security.policy -Djava.security.properties=/home/runner/work/solr/solr/solr/packaging/build/solr-10.0.0-SNAPSHOT/server/etc/security.properties -Dsolr.internal.network.permission=* -DdisableAdminUI=false -Dsolr.log.muteconsole -jar start.jar --module=http --module=requestlog --module=gzip
...
#   stop_solr /home/runner/work/solr/solr/solr/packaging/build/solr-10.0.0-SNAPSHOT/server 7574 solrrocks 2651

and from the jstack - Solr is 100% still running.
So I'm back to "$JAVA" $SOLR_SSL_OPTS $AUTHC_OPTS -jar "$DIR/start.jar" "STOP.PORT=$THIS_STOP_PORT" "STOP.KEY=$STOP_KEY" --stop || true not working correctly somehow.

Yea, I tried java -jar server/start.jar --help and get
  --stop
                   Sends a stop signal to the running Jetty instance.
                   The running Jetty instance must have been started with a
                   stop.port=<port> property and the --stop command must
                   be executed with the same property.

  stop.port=<number>
                   Used with the --stop command.
                   Specifies the port to use to contact the Jetty server
                   to stop.

  stop.key=<alphanumeric>
                   Used with the --stop command.
                   The passphrase required to stop the Jetty server.

  stop.wait=<number>
                   Used with the --stop command.
                   The time, in seconds, to wait for confirmation that the
                   running Jetty server has stopped.
                   If not specified, the stopper will not wait.

So I think we must also START solr with lowercase stop.port

Well after 6ba8d29 the logs are reporting something interesting... https://github.com/apache/solr/actions/runs/3689870566/jobs/6246292033#step:7:545
Jetty thinks it stopped....
So need to figure out what is going on...

It is logical to think that it is related to Jetty 10.
However, it it was pure Java change, we should see same behavior on local mac. That's why I felt the need to try from Docker to simulate a Linux environment.
Have to call it a day...

I think now that we have a super fast way of reproducing, it should be easier to debug

Unfortunately, this may be a dead end. What I thought was a reproduction may have been the effect of running an and64 docker image on an M1 Mac, which is a bit buggy and slow due to rosetta, so sometimes a process in the container may hang. I think that was the reason for the timeout and killing. Cause when I build a docker image locally and try to reproduce, all works fine.
I thought for a moment that the -all flag was broken on linux, but since the official Docker image sets the ENV SOLR_PORT in Dockerfile, this leaks into bash and into the script, so that due to an unfortunate if-test it fails to enter the -all logic since SOLR_PORT is given. I.e. it believes that SOLR_PORT comes from the -p argument. :-)

Jetty thinks it stopped....

Are you sure that is not the new "start.jar" jetty that executes the STOP command? Cause we kind of fire up the jetty start jar to take jetty down...

Well at this point @janhoy I'm not sure what to do. I have debug logging on for bin/solr and I see no indications that Solr or Jetty decided to stop. I see in the output that the start.jar stop command happened and reported it successfully stopped. I tried with upper and lower case stop parameters (ie: stop.port).
I would expect to see SOMETHING in the Solr logs about stopping.
I would also expect to see SOMETHING about port 6574 being listened to. I'm going to experiment more locally, but right now at a dead end.

Well I dug through the Jetty code and found ShutdownMonitor - which has a separate DEBUG property to actually do logging - 7aa80ee
Locally testing in ./solr/packaging/build/solr-10.0.0-SNAPSHOT/server/logs/solr-7574-console.log I found the following:
[ShutdownMonitor] command=stop
[ShutdownMonitor] Performing stop command
java.security.AccessControlException: access denied ("java.io.FilePermission" "/private/var/folders/_9/1c1gx5717xqc4vpbtkx2k12h0000gn/T/jetty-127_0_0_1-7574-webapp-_solr-any-10834318635653572205" "read")
	at java.base/java.security.AccessControlContext.checkPermission(AccessControlContext.java:485)
	at java.base/java.security.AccessController.checkPermission(AccessController.java:1068)
	at java.base/java.lang.SecurityManager.checkPermission(SecurityManager.java:416)
	at java.base/java.lang.SecurityManager.checkRead(SecurityManager.java:756)
	at java.base/java.io.File.exists(File.java:829)
	at org.eclipse.jetty.util.IO.delete(IO.java:363)
	at org.eclipse.jetty.webapp.WebInfConfiguration.deconfigure(WebInfConfiguration.java:87)
	at org.eclipse.jetty.webapp.WebAppContext.stopContext(WebAppContext.java:1316)
	at org.eclipse.jetty.server.handler.ContextHandler.doStop(ContextHandler.java:1086)
	at org.eclipse.jetty.servlet.ServletContextHandler.doStop(ServletContextHandler.java:312)
	at org.eclipse.jetty.util.component.AbstractLifeCycle.stop(AbstractLifeCycle.java:132)
	at org.eclipse.jetty.util.component.ContainerLifeCycle.stop(ContainerLifeCycle.java:182)
	at org.eclipse.jetty.util.component.ContainerLifeCycle.doStop(ContainerLifeCycle.java:205)
	at org.eclipse.jetty.server.handler.AbstractHandler.doStop(AbstractHandler.java:97)
	at org.eclipse.jetty.util.component.AbstractLifeCycle.stop(AbstractLifeCycle.java:132)
	at org.eclipse.jetty.util.component.ContainerLifeCycle.stop(ContainerLifeCycle.java:182)
	at org.eclipse.jetty.util.component.ContainerLifeCycle.doStop(ContainerLifeCycle.java:205)
	at org.eclipse.jetty.server.handler.AbstractHandler.doStop(AbstractHandler.java:97)
	at org.eclipse.jetty.util.component.AbstractLifeCycle.stop(AbstractLifeCycle.java:132)
	at org.eclipse.jetty.util.component.ContainerLifeCycle.stop(ContainerLifeCycle.java:182)
	at org.eclipse.jetty.util.component.ContainerLifeCycle.doStop(ContainerLifeCycle.java:205)
	at org.eclipse.jetty.server.handler.AbstractHandler.doStop(AbstractHandler.java:97)
	at org.eclipse.jetty.util.component.AbstractLifeCycle.stop(AbstractLifeCycle.java:132)
	at org.eclipse.jetty.util.component.ContainerLifeCycle.stop(ContainerLifeCycle.java:182)
	at org.eclipse.jetty.util.component.ContainerLifeCycle.doStop(ContainerLifeCycle.java:205)
	at org.eclipse.jetty.server.handler.AbstractHandler.doStop(AbstractHandler.java:97)
	at org.eclipse.jetty.util.component.AbstractLifeCycle.stop(AbstractLifeCycle.java:132)
	at org.eclipse.jetty.util.component.ContainerLifeCycle.stop(ContainerLifeCycle.java:182)
	at org.eclipse.jetty.util.component.ContainerLifeCycle.doStop(ContainerLifeCycle.java:205)
	at org.eclipse.jetty.server.handler.AbstractHandler.doStop(AbstractHandler.java:97)
	at org.eclipse.jetty.server.handler.gzip.GzipHandler.doStop(GzipHandler.java:227)
	at org.eclipse.jetty.util.component.AbstractLifeCycle.stop(AbstractLifeCycle.java:132)
	at org.eclipse.jetty.util.component.ContainerLifeCycle.stop(ContainerLifeCycle.java:182)
	at org.eclipse.jetty.util.component.ContainerLifeCycle.doStop(ContainerLifeCycle.java:205)
	at org.eclipse.jetty.server.handler.AbstractHandler.doStop(AbstractHandler.java:97)
	at org.eclipse.jetty.server.Server.doStop(Server.java:517)
	at org.eclipse.jetty.util.component.AbstractLifeCycle.stop(AbstractLifeCycle.java:132)
	at org.eclipse.jetty.server.ShutdownMonitor$ShutdownMonitorRunnable.stopLifeCycles(ShutdownMonitor.java:456)
	at org.eclipse.jetty.server.ShutdownMonitor$ShutdownMonitorRunnable.run(ShutdownMonitor.java:363)
	at java.base/java.lang.Thread.run(Thread.java:833)
[ShutdownMonitor] Informing client that we are stopped
[ShutdownMonitor] Killing JVM
java.security.AccessControlException: access denied ("java.lang.RuntimePermission" "exitVM.0")
	at java.base/java.security.AccessControlContext.checkPermission(AccessControlContext.java:485)
	at java.base/java.security.AccessController.checkPermission(AccessController.java:1068)
	at java.base/java.lang.SecurityManager.checkPermission(SecurityManager.java:416)
	at java.base/java.lang.SecurityManager.checkExit(SecurityManager.java:629)
	at java.base/java.lang.Runtime.exit(Runtime.java:113)
	at java.base/java.lang.System.exit(System.java:1860)
	at org.eclipse.jetty.server.ShutdownMonitor$ShutdownMonitorRunnable.run(ShutdownMonitor.java:374)
	at java.base/java.lang.Thread.run(Thread.java:833)

which is the missing logs I was looking for. I'm not surprised that the JVM can't be killed. The security manager seems to be taking care of that... I just don't know how this ever worked...

So my only guess so far as to why this is broken is related to:
https://github.com/eclipse/jetty.project/blob/jetty-10.0.x/jetty-server/src/main/java/org/eclipse/jetty/server/ShutdownMonitor.java#L359
and
SOLR-16457 where https://github.com/apache/solr/commit/f4cca0d0a51d49266baac422cb07a100aa6e2172 changed some of the security policy about what files were readable/writable. It might be that with read everywhere - the JVM just says ok I stopped and never gets to the kill JVM part.

Well the even more interesting part is the logs from github actions:
[ShutdownMonitor] command=stop
[ShutdownMonitor] Performing stop command
java.lang.IllegalStateException: !STOPPED
	at org.eclipse.jetty.server.handler.HandlerWrapper.destroy(HandlerWrapper.java:135)
	at org.eclipse.jetty.server.ShutdownMonitor$ShutdownMonitorRunnable.stopLifeCycles(ShutdownMonitor.java:459)
	at org.eclipse.jetty.server.ShutdownMonitor$ShutdownMonitorRunnable.run(ShutdownMonitor.java:363)
	at java.base/java.lang.Thread.run(Thread.java:829)
[ShutdownMonitor] Informing client that we are stopped
[ShutdownMonitor] Killing JVM
java.security.AccessControlException: access denied ("java.lang.RuntimePermission" "exitVM.0")
	at java.base/java.security.AccessControlContext.checkPermission(AccessControlContext.java:472)
	at java.base/java.security.AccessController.checkPermission(AccessController.java:897)
	at java.base/java.lang.SecurityManager.checkPermission(SecurityManager.java:322)
	at java.base/java.lang.SecurityManager.checkExit(SecurityManager.java:534)
	at java.base/java.lang.Runtime.exit(Runtime.java:114)
	at java.base/java.lang.System.exit(System.java:1752)
	at org.eclipse.jetty.server.ShutdownMonitor$ShutdownMonitorRunnable.run(ShutdownMonitor.java:374)
	at java.base/java.lang.Thread.run(Thread.java:829)
Dec 14, 2022 3:27:41 PM org.glassfish.jersey.server.wadl.WadlFeature configure
WARNING: JAXBContext implementation could not be found. WADL feature is disabled.

so something is definitely broken :D

I'm no closer to figuring out:
java.lang.IllegalStateException: !STOPPED
	at org.eclipse.jetty.server.handler.HandlerWrapper.destroy(HandlerWrapper.java:135)
	at org.eclipse.jetty.server.ShutdownMonitor$ShutdownMonitorRunnable.stopLifeCycles(ShutdownMonitor.java:459)
	at org.eclipse.jetty.server.ShutdownMonitor$ShutdownMonitorRunnable.run(ShutdownMonitor.java:363)
	at java.base/java.lang.Thread.run(Thread.java:829)

I added a Jetty work dir to avoid the tmp dir stuff in security manager - 779df94 - this fixes some of the errors locally. I am avoiding adding exitVM.0 until can figure out the above.

Ah, there I think we have it - security policy. I can understand how running locally on laptop perhaps has all files within already allowed folders, but how come System.exit() works locally, should be disabled by security manager too?
Aside: I keep seeing STOP.KEY=solrrocks. While you can add a custom -k <key> on the solr stop command, there is no such option on solr start. It would be a best practice to add your own stop key, else someone may scan a network for IP addresses and fire stop commands on port 7983 :) I do think you can set STOP_KEY=foo in solr.in.xx and it will be inherited by bin/solr though, but could be good to document.

Ah, there I think we have it - security policy. I can understand how running locally on laptop perhaps has all files within already allowed folders, but how come System.exit() works locally, should be disabled by security manager too?

Not 100% sure its security manager in github actions yet. It looks like the shutdown works WITHOUT the forced vm exit. Its like the vm exit is the fallback - but once shutdown is triggered Jetty will stop.
I'm still trying to figure out the following
java.lang.IllegalStateException: !STOPPED
	at org.eclipse.jetty.server.handler.HandlerWrapper.destroy(HandlerWrapper.java:135)
	at org.eclipse.jetty.server.ShutdownMonitor$ShutdownMonitorRunnable.stopLifeCycles(ShutdownMonitor.java:459)
	at org.eclipse.jetty.server.ShutdownMonitor$ShutdownMonitorRunnable.run(ShutdownMonitor.java:363)
	at java.base/java.lang.Thread.run(Thread.java:829)

which I haven't seen locally yet. Adding more debugging to dig further.

Aside: I keep seeing STOP.KEY=solrrocks.

yea something good to do separately.

After implementing 93c8523, I don't see any access denied from the security manager prior to this message in the console:
java.lang.IllegalStateException: !STOPPED
	at org.eclipse.jetty.server.handler.HandlerWrapper.destroy(HandlerWrapper.java:135)
	at org.eclipse.jetty.server.ShutdownMonitor$ShutdownMonitorRunnable.stopLifeCycles(ShutdownMonitor.java:459)
	at org.eclipse.jetty.server.ShutdownMonitor$ShutdownMonitorRunnable.run(ShutdownMonitor.java:363)
	at java.base/java.lang.Thread.run(Thread.java:829)

I also don't see any exceptions in the Solr log either.
It would be awesome if HandlerWrapper shared what the state was and what it was actually wrapping...
https://github.com/eclipse/jetty.project/blob/jetty-11.0.x/jetty-server/src/main/java/org/eclipse/jetty/server/handler/HandlerWrapper.java#L132
I am not sure how to enable more logging right this second. I think I can put this in a debugger and see - but not in github actions. Overwriting this class isn't easy since only Jetty jars are in lib/ext and so not easy to add a custom jar there.

Ok so with 4304fb5 I was able to test this on my fork and get the debugger hooked up to github actions. The state is starting for gzip handler - so its like we are shutting stuff down too quickly...
I'm going to look at putting in a temp sleep to see how that works.

So I put in a temp sleep and that made the gzip handler go to "stopped" and then destroy works - trying that here: https://github.com/apache/solr/pull/1240

My theory at this point is the security manager stuff is nice to fix but doesn't block shutdown (both the work dir and the vm exit). If jetty is up and ready to shutdown - it works. However on github actions and jenkins - its slower. This at least makes it so the handler is not ready to get shutdown.
At least the above is my working theory getting tested by itself here: https://github.com/apache/solr/pull/1240
It could be the security manager stuff is also playing a part but still try to narrow it down further.

woot https://github.com/apache/solr/pull/1240 passed - now why does this work on branch_9_0 and not on main. idk....

Closed since not debugging here anymore for now.


Asterisks instead of bold text

Under Step 2 of the Software requirements section, there is a space between each set of asterisks surrounding the word File, so it's not bold and we can see the asterisks. Thanks :)

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: acc64ec1-ba7d-bcd3-51a6-a99a5d060e2c
Version Independent ID: 2e6ca190-14c5-5ae5-780a-00ca99ccc9fd
Content: Plan for multi-factor authentication for Office 365 Deployments
Content Source: Office365-Admin/security-and-compliance/multi-factor-authentication-plan.md
Service: o365-administration
GitHub Login: @Sirkkuw
Microsoft Alias: sirkkuw

@officedocsbot assign @mypil

@douglasac10 - Thank you for submitting feedback.
I will get this issue over to the O365ITPro writing team for investigation.
Thank you for reporting and making the docs better. Much appreciated.
I made a note to request the team to update this when the work is complete.


[beta.21 and later] Setting timezone on the server (TZ env variable) does not work anymore

It seems that on beta.21 and later the TZ env variable is not working, which causes server rendering to print incorrect time values.
Example: My app lives in a +2 timezone (Finland). Before beta.21 I could set TZ=Europe/Helsinki and everything would work fine (SSR and client displayed same values). But now, even though console.log(process.env.TZ) still prints "Europe/Helsinki" on the server console correctly, the values printed by moment(value).format('L') are 2 hours earlier on server than on the client.

We need clear re-production info to test this.
Anyway, you have no way to access process.env.TZ in the client.
I suggest you to try some other timezone independant design and I'm pretty sure this is not related to Next.
Try to create a re-producible app with the issue.
If it's a Next.js one let's fix it.
In the meantime, I'll close this.
Reopen with the ^^^ info.


grpc,1.27.3 sendmessage ,crash

grpc 1.27.3, client
crash, I donnot know the reason!!! help
addr2line -f -e ./gent -a 0xc9b256
0x0000000000c9b256
_ZNK6google8protobuf10Reflection30UnsafeArenaSetAllocatedMessageEPNS0_7MessageES3_PKNS0
_15FieldDescriptorE
protobuf/src/google/protobuf/generated_message_reflection.cc:1501
(discriminator 6)
addr2line -f -e ./agent -a 0xc9ae74
0x0000000000c9ae74
_ZNK6google8protobuf10Reflection10GetMessageERKNS0_7MessageEPKNS0_15FieldDescriptorEPNS
0_14MessageFactoryE
google/protobuf/generated_message_reflection.cc:1452
addr2line -f -e ./agent -a 0x50daaf
0x000000000050daaf
_ZNSt8_Rb_treeIiiSt9_IdentityIiESt4lessIiESaIiEE8_M_eraseEPSt13_Rb_tree_nodeIiE
/usr/local/include/c++/4.9.4/bits/stl_tree.h:1239
addr2line -f -e ./agent -a 0xcfa8f0
0x0000000000cfa8f0
_ZN6google8protobuf13RepeatedFieldIlE3SetEiRKl

It is easy to trigger a crash when the client frequently sends data to the server.
The above is the captured stack information.

The stack traces indicate protobuf. I would guess that there is an error in the usage of protobuf in the client code. I would have been able to provide more help if I could read the code, but based on the stack traces that's my best guess.
As a side-note, for general help, please redirect questions towards wider communities like stack-overflow or https://groups.google.com/g/grpc-io


Uninstall option for install script

Implement a uninstall option to allow users to remove the local installed color theme file again including a optional name parameter for custom named theme files.
The user should be asked to confirm this process before removing the file.

Wiping existing config without confirmation and warning is pretty rude and not what i expected.
This should at least be clearly visible in README.
A merge into existing config would be preferable.

Any updates here? I just tried to run install.sh and get all my local settings wiped and I had to restore all of them manually. It is really unexpected and frustrating behaviour.

This should be fixed!

@TolichP Thanks a lot for the report 🙏
I'm really sorry for the data loss and hope you were able to restore the config again.
I've never really like these scripts so I've documented the bug in #12 and fixed it in #13.
This will now also make this issue as well as #4 obsolete.


Move test code in the end of api.py to a pytest

This issue has been closed because this action is not required


grading label

Changes
update button label to Grading when grading
Implementation details
following up on this comment, the running indicator button is updated to show Grading instead of Running when the Grade action is taken
How to read this PR

run some graded code exercises, the button should show Running
grade some graded code exercises, the button should show Grading

Screenshots
https://user-images.githubusercontent.com/13156555/183580249-d3aac26f-4e7f-4e00-8e08-5e3753eba19c.mov

@JRussellHuffman

Looks great. thanks!


Plotting can change position of the model

Steps to reproduce
Load the wrist model
Plot the flexion moment arm as a function of flexion for the pre/post ECU
Close the plot and change the elbow flexion angle.
Expected result
Wrist flexion does not change
Actual result
Wrist flexes
(include screen grabs where appropriate)
Environment and GUI version
Mac OpenSim 4.0-2018-11-06-f854814

Replicated issue with arm26 and then tested that this was fixed in OpenSim 4.0-2018-11-08-ca20f56c.
@chrisdembia you mentioned this before, should there be another issue made for this (for after 4.0)?

Another related issue: if I have loaded a motion with my model and then I put the model in some random pose and then open any of the tools or the plotter window, the model goes to the initial pose in the motion.

Done https://github.com/opensim-org/opensim-gui/issues/1077


Low score on Naive Bayes

I think part of this is that we take the log of the conditionals, but not the log of the prior. So the prior is dominating the prediction. But that shouldn't effect a balanced dataset, since the priors are the same for all classes. So there may still be some sneaky bug in their.

We are taking log of priors and then adding them to the logs of likelyhood probabilities right?
Also, it will be interesting to find out if we don't add log priors at all, does that balance the distribution of predicted labels over documents?


Documentation for theme.palette string incorrect

In the "Themes" section of the documentation the following instructions are given:

Setting a palette can be done by.

theme: {
  palette: 'colorPalette1' // upto colorPalette10
}

I believe it should read palette1 instead of colorPalette1.
The codepen examples specify the correct string value, however.

Thank you for the catch.
Fixed!

It would be awesome if you could add an example on where to insert the theme attribute. I defined "palette4" in my bar chart but all bars are light blue. Would be great to have some more detail in the documenation. Greetings and thanks!


Update 114-bubble-sort.md

Added a p5 version of this challenge (sorry, but currently only the code and no example)

Looks like there is a markdown error, can you double-check? Thanks for the contribution!

Yay! :+1:


mac install

mac install from source and binary is not 100% clear and accurate
installLisk.sh: line 228: syntax error near unexpected token >'
`
https://lisk.io/documentation/lisk-core/setup/binary#execute-the-installation-script

Hi @benjyz !
Mac is not supported for Binary installation, see https://lisk.io/documentation/lisk-core/setup/binary#determine-if-your-platform-can-run-lisk-core
If you want to install Lisk Core on Mac, please install it from Source or with the Docker distribution, see: https://lisk.io/documentation/lisk-core/setup


Add icTarCana1

Assembly review request

ToLID: icTarCana1
Species: Tarphius canariensis
Project: ERGA-BGE
Affiliation: Sanger

ok

Hi @auryjm and @CaroB-M sorry for the excess of pings, we detected a bot anomaly that we are fixing.
@auryjm do you agree to review this EAR? Please reply to this message only with Yes or No by 30-Sep-2024 at 16:49 CET
@CaroB-M you should not have been called at this point. So please pretend you have not been contacted (yet!)

Thank you, @tommathers and @JoannaCollins for this genome assembly of the coleoptera. The long-read assembly looks good, with a low number of contigs per chromosome and the X chromosome assembled in a single contig!
Here are a few things I noticed, although some may be explained by the fact that the Hi-C was performed on a different individual.
SUPER_1 @ 43.29-43.34: allelic duplication
SUPER_1 @ 45.19-45.23: very few contacts with SUPER_1; move to the end of SUPER_7? Also, very low coverage, which could indicate a falsely duplicated region.
SUPER_2 @ 20.59-20.63: allelic duplication
SUPER_2 @ 37.30-37.37: unlocalized (possibly because Hi-C was performed on another individual?)
SUPER_3 @ 3.40-3.47: allelic duplication
SUPER_3 @ 15.44-15.49: allelic duplication
SUPER_4 @ 2.70-2.84: allelic duplication
SUPER_4 @ 19.11-19.15: allelic duplication
SUPER_4 @ 33.15-33.21: very few contacts with SUPER_4; move to the end of SUPER_7? Also, very low coverage, which could indicate a falsely duplicated region.
SUPER_5: small region at the start has more contact with the end of SUPER_4 (possibly because Hi-C was performed on another individual?)
SUPER_5 @ 15.82-15.85: allelic duplication
SUPER_7 @ 17.50-17.58: allelic duplication
SUPER_8: small region at the start has more contact with the end of SUPER_7 (possibly because Hi-C was performed on another individual?)
SUPER_8 @ 4.06-4.17: allelic duplication
SUPER_8: small region at the end has more contact with the end of SUPER_7 (possibly because Hi-C was performed on another individual?)
SUPER_9 @ 10.94-10.97: allelic duplication
SUPER_9 @ 20.94-20.99: allelic duplication
SUPER_X: small region at the start has more contact with the end of SUPER_9 (possibly because Hi-C was performed on another individual?)

Thank you for the review @auryjm
@tommathers @JoannaCollins could I ask you to please look through the list of suggestions and make any changes you see fit?

Hi @auryjm
Thank you very much for reviewing the assembly of icTarCana1 :slightly_smiling_face: .
I have investigated all of the issues that you raised and have added my comments on each point below:
SUPER_1 @ 43.29-43.34: allelic duplication - contigous - data supports current assembly.
SUPER_1 @ 45.19-45.23: very few contacts with SUPER_1; move to the end of SUPER_7? Also, very low coverage, which could indicate a falsely duplicated region. - contigous region/not gapped, coupled with Hi-C from a different individual which makes moving the sequence a potentially ambiguous placement so I think its not appropriate to make the change. Low cov likely due to sequence being repetitive.
SUPER_2 @ 20.59-20.63: allelic duplication - contigous - data supports current assembly.
SUPER_2 @ 37.30-37.37: unlocalized (possibly because Hi-C was performed on another individual?) - contigous, and has ambiguous hits elsewhere - not appropriate to make change.
SUPER_3 @ 3.40-3.47: allelic duplication - There is a gap here but the data supports current assembly.
SUPER_3 @ 15.44-15.49: allelic duplication - contigous - data supports current assembly.
SUPER_4 @ 2.70-2.84: allelic duplication - contigous - data supports current assembly.
SUPER_4 @ 19.11-19.15: allelic duplication - contigous - data supports current assembly.
SUPER_4 @ 33.15-33.21: very few contacts with SUPER_4; move to the end of SUPER_7? Also, very low coverage, which could indicate a falsely duplicated region.-contigous, and has ambiguous hits elsewhere - not appropriate to make change. Low cov likely due to sequence being repetitive.
SUPER_5: small region at the start has more contact with the end of SUPER_4 (possibly because Hi-C was performed on another individual?) - contigous, and has ambiguous hits elsewhere - not appropriate to make change.
SUPER_5 @ 15.82-15.85: allelic duplication - contigous - data supports current assembly.
SUPER_7 @ 17.50-17.58: allelic duplication- There is a gap here, but data supports current assembly.
SUPER_8: small region at the start has more contact with the end of SUPER_7 (possibly because Hi-C was performed on another individual?) - contigous, and has ambiguous hits elsewhere - not appropriate to make change.
SUPER_8 @ 4.06-4.17: allelic duplication - There is a gap in this region, but data supports current assembly.
SUPER_8: small region at the end has more contact with the end of SUPER_7 (possibly because Hi-C was performed on another individual?) - contigous, and has ambiguous hits elsewhere - not appropriate to make change.
SUPER_9 @ 10.94-10.97: allelic duplication - contigous - data supports current assembly.
SUPER_9 @ 20.94-20.99: allelic duplication- contigous - data supports current assembly.
SUPER_X: small region at the start has more contact with the end of SUPER_9 (possibly because Hi-C was performed on another individual?) - contigous, and has ambiguous hits elsewhere - not appropriate to make change.
As you noted the assembly was of very high quality prior to curation, and I was able to utilise the merged hap1/hap2 map for curation which showed very nicely that the automated assembly process had produced an essentially complete assembly for each haplotype.
With regard to the regions where Hi-C suggests a different placement, these regions are all contiguous, thus I agree with your comments that this is most likely as a result of the underlying data and Hi-C being derived from different individuals. The sequence in question also seems to have ambiguous hits across the map, so taking all of the above into account I think it is appropriate to leave these regions as they were originally assembled.
Thanks again, Best wishes, Jo

Hi @auryjm,
Thanks for taking another look at this.
In terms of verfiying the current assembly I looked at each of the regions that you noted in the HiGlass map of the data set. As HiGlass provides a much more detailed view of the underlying data than pretext it allows for easier identification of genuine haplotypic duplications. Typically the hap dups we see are at contig gaps (although not always) are accompanied by a drop in coverage of the PacBio data to approximately half and have a typical motif as seen in the following image (not from this assembly).

So for instance in the case of the issue you noted @ SUPER_3 @ 15.44-15.49: allelic duplication, you can see from the picture below that with the high resolution map there is no obvious error.  So my point "contiguous - data supports current assembly" is really just saying at this point in the assembly, there are no gaps in the underlying data and there is no evidence from HIC mapping in the high resolution map that there is an assembly error at this location.

Best Wishes
Jo

Thank you @JoannaCollins and @auryjm
In case it's helpful, this is the pipeline I use to generate the .mcool files for visualising the maps in HiGlass. I really struggle with the pretext maps, so also tend to end up using these to make most of my decisions: https://workflowhub.eu/workflows/795
If you are happy with the genome as it is, could you please "Approve" the pull-request Jean-Marc and then we can send another happy genome off to ENA.
Thank you both again for the work and input

Morning both,
Sorry to pester again. @auryjm Have I interpreted correctly that you are happy with the assembly? We would like to merge this (and open you up as a reviewer again ;))
@JoannaCollins I think this can be submitted, in case you are waiting for the go-ahead


[v6-alpha.3] navigate(-1) does not work after refresh

Version
[v6-alpha.3]
Test Case
https://codesandbox.io/s/distracted-https-4s5zs
Sandbox have 2 pages:

Page One to Page Two with a "Go Back" button using navigate("/"); Works fine after refresh
Page One to Page Three with a "Go Back" button using navigate(-1); Does not work after refresh

Steps to reproduce

Route to next page with a "Back" button using navigate(-1)
Refresh the page
navigate(-1) no longer works

Expected Behavior
Go back to previous page after refresh.
Actual Behavior
Unable to navigate back after refresh.

This is how history has always behaved. When you refresh the page, you're resetting the history stack to one item. So, there is nothing to "go back" to. This is intended behavior.

Noted and thanks. But can check is there any means to "go back" using "-1" rather than "path", as the "Back" button is a common component that are used by many different components.


vmware-workstation: 17.0.0 -> 17.0.2

Description of changes
Just a small bump.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 251536 run on x86_64-linux 1
8 packages marked as broken and skipped:
linuxKernel.packages.hardkernel_4_14.vmware
linuxKernel.packages.linux_4_14_hardened.vmware
linuxKernel.packages.linux_4_19_hardened.vmware
linuxKernel.packages.linux_5_4_hardened.vmware
linuxPackages_4_14_hardened.vmware
linuxPackages_4_19_hardened.vmware
linuxPackages_5_4_hardened.vmware
linuxPackages_hardkernel_latest.vmware

5 packages failed to build:
linuxPackages_latest.vmware
linuxPackages_6_4_hardened.vmware
linuxPackages_latest-libre.vmware
linuxPackages_testing_bcachefs.vmware
linuxPackages_xanmod_latest.vmware

@gepbird That looks suspicious to me - why did it fail?
It works just fine for me.

@gepbird That looks suspicious to me - why did it fail? It works just fine for me.

After cloning nixpkgs on the master branch, (running nixpkgs-review on some other PRs) then running it on this PR it gives me these errors:
error: builder for '/nix/store/iiy3f6j5cfk7bpglxsgk3zirzcqxmg3f-vmware-modules-17.0.2-6.4.12.drv' failed with exit code 2;
       last 10 log lines:
       >   LD [M]  /build/source/vmmon-only/vmmon.ko
       >   BTF [M] /build/source/vmmon-only/vmmon.ko
       > Skipping BTF generation for /build/source/vmmon-only/vmmon.ko due to unavailability of vmlinux
       > make -C $PWD SRCROOT=$PWD/. \
       >   MODULEBUILDDIR= postbuild
       > make[2]: Entering directory '/build/source/vmmon-only'
       > make[2]: 'postbuild' is up to date.
       > make[2]: Leaving directory '/build/source/vmmon-only'
       > cp -f vmmon.ko ./../vmmon.o
       > make[1]: Leaving directory '/build/source/vmmon-only'
       For full logs, run 'nix log /nix/store/iiy3f6j5cfk7bpglxsgk3zirzcqxmg3f-vmware-modules-17.0.2-6.4.12.drv'.
error: builder for '/nix/store/d2qjy1hxqasgn82c3i2ymg6clcsg8q23-vmware-modules-17.0.2-6.4.11.drv' failed with exit code 2;
       last 10 log lines:
       >   LD [M]  /build/source/vmmon-only/vmmon.ko
       >   BTF [M] /build/source/vmmon-only/vmmon.ko
       > Skipping BTF generation for /build/source/vmmon-only/vmmon.ko due to unavailability of vmlinux
       > make -C $PWD SRCROOT=$PWD/. \
       >   MODULEBUILDDIR= postbuild
       > make[2]: Entering directory '/build/source/vmmon-only'
       > make[2]: 'postbuild' is up to date.
       > make[2]: Leaving directory '/build/source/vmmon-only'
       > cp -f vmmon.ko ./../vmmon.o
       > make[1]: Leaving directory '/build/source/vmmon-only'
       For full logs, run 'nix log /nix/store/d2qjy1hxqasgn82c3i2ymg6clcsg8q23-vmware-modules-17.0.2-6.4.11.drv'.
error: builder for '/nix/store/hbj954ziacrrkpzi8n0r1lfag1l9bw14-vmware-modules-17.0.2-6.4.11.drv' failed with exit code 2;
       last 10 log lines:
       >   MODPOST /build/source/vmmon-only/Module.symvers
       >   CC [M]  /build/source/vmmon-only/vmmon.mod.o
       >   LD [M]  /build/source/vmmon-only/vmmon.ko
       > make -C $PWD SRCROOT=$PWD/. \
       >   MODULEBUILDDIR= postbuild
       > make[2]: Entering directory '/build/source/vmmon-only'
       > make[2]: 'postbuild' is up to date.
       > make[2]: Leaving directory '/build/source/vmmon-only'
       > cp -f vmmon.ko ./../vmmon.o
       > make[1]: Leaving directory '/build/source/vmmon-only'
       For full logs, run 'nix log /nix/store/hbj954ziacrrkpzi8n0r1lfag1l9bw14-vmware-modules-17.0.2-6.4.11.drv'.
error: builder for '/nix/store/lhqdppqns3v1wgy7fcpa9bcfsapcscs3-vmware-modules-17.0.2-6.4.12.drv' failed with exit code 2;
       last 10 log lines:
       >   LD [M]  /build/source/vmmon-only/vmmon.ko
       >   BTF [M] /build/source/vmmon-only/vmmon.ko
       > Skipping BTF generation for /build/source/vmmon-only/vmmon.ko due to unavailability of vmlinux
       > make -C $PWD SRCROOT=$PWD/. \
       >   MODULEBUILDDIR= postbuild
       > make[2]: Entering directory '/build/source/vmmon-only'
       > make[2]: 'postbuild' is up to date.
       > make[2]: Leaving directory '/build/source/vmmon-only'
       > cp -f vmmon.ko ./../vmmon.o
       > make[1]: Leaving directory '/build/source/vmmon-only'
       For full logs, run 'nix log /nix/store/lhqdppqns3v1wgy7fcpa9bcfsapcscs3-vmware-modules-17.0.2-6.4.12.drv'.
error: builder for '/nix/store/xsgx65kkvyziq3xh35xgcyx7l7dc5sr1-vmware-modules-17.0.2-6.4.12.drv' failed with exit code 2;
       last 10 log lines:
       >   LD [M]  /build/source/vmmon-only/vmmon.ko
       >   BTF [M] /build/source/vmmon-only/vmmon.ko
       > Skipping BTF generation for /build/source/vmmon-only/vmmon.ko due to unavailability of vmlinux
       > make -C $PWD SRCROOT=$PWD/. \
       >   MODULEBUILDDIR= postbuild
       > make[2]: Entering directory '/build/source/vmmon-only'
       > make[2]: 'postbuild' is up to date.
       > make[2]: Leaving directory '/build/source/vmmon-only'
       > cp -f vmmon.ko ./../vmmon.o
       > make[1]: Leaving directory '/build/source/vmmon-only'
       For full logs, run 'nix log /nix/store/xsgx65kkvyziq3xh35xgcyx7l7dc5sr1-vmware-modules-17.0.2-6.4.12.drv'.
error: 5 dependencies of derivation '/nix/store/ayqids3z8w3piqpn1fcn6ivkaxaj7q04-review-shell.drv' failed to build

Link to currently reviewing PR:
https://github.com/NixOS/nixpkgs/pull/251536

8 packages marked as broken and skipped:
linuxKernel.packages.hardkernel_4_14.vmware linuxKernel.packages.linux_4_14_hardened.vmware linuxKernel.packages.linux_4_19_hardened.vmware linuxKernel.packages.linux_5_4_hardened.vmware linuxPackages_4_14_hardened.vmware linuxPackages_4_19_hardened.vmware linuxPackages_5_4_hardened.vmware linuxPackages_hardkernel_latest.vmware

5 packages failed to build:
linuxPackages_latest.vmware linuxPackages_6_4_hardened.vmware linuxPackages_latest-libre.vmware linuxPackages_testing_bcachefs.vmware linuxPackages_xanmod_latest.vmware

14 packages built:
linuxKernel.packages.linux_4_14.vmware linuxKernel.packages.linux_4_19.vmware linuxKernel.packages.linux_5_10.vmware linuxPackages_5_10_hardened.vmware linuxKernel.packages.linux_5_15.vmware linuxPackages_5_15_hardened.vmware linuxKernel.packages.linux_5_4.vmware linuxPackages.vmware linuxPackages_hardened.vmware linuxPackages-libre.vmware linuxPackages_lqx.vmware linuxPackages_xanmod.vmware linuxPackages_zen.vmware vmware-workstation

error: cannot find flake 'flake:None' in the flake registries
error: cannot find flake 'flake:None' in the flake registries
error: cannot find flake 'flake:None' in the flake registries
error: cannot find flake 'flake:None' in the flake registries
error: cannot find flake 'flake:None' in the flake registries
error: cannot find flake 'flake:None' in the flake registries
error: cannot find flake 'flake:None' in the flake registries
error: cannot find flake 'flake:None' in the flake registries

I'm not sure what cannot find flake 'flake:None' in the flake registries error means, is something wrong on my side?

@gepbird The log looks like the vmware modules built fine, so it is not a "traditional" build failure at least.
I haven't seen such an error message and it doesn't seem to be related to this, but I have no idea.

https://github.com/NixOS/nixpkgs/pull/251651 related


Multiple changes

Working CSV example (to be implemented for all resources)
Incorporate 'whatwasit' to enable audit-tracking for each model change.

Fix for Issue #11

@smpallen99 - could you please merge?
Changes:

Collapsed some migrations.
The first admin user ('demouser') should be created during the migrations itself.
Example authorization.
Example scope.
General code cleanup.
Incorporated audit using whatwasit.
Example of custom css/js for each admin page.

@smpallen99 - could you please review this and merge this PR?

@smpallen99 - ping - could you please merge this into your repo? If not, please provide review comments. I am trying to use your repo as a reference when i teach newcomers to adopt/switch over to Elixir/Phoenix - and this is a major cause for hesitation when we try to go through the many_to_many examples.

@smpallen99 - is this going to be merged anytime soon? I am starting another project in the next couple of days - and would like to start off with this as the reference


urlencode() -> rawurlencode()

Replace all usage of urlencode() to rawurlencode()

@m4tthumphrey the idea is to replace all occurrences of urlencode() to rawurlencode() ?

Yes, your MR just gave me the push I needed to get around to updating it!

@m4tthumphrey can i take in charge this issue ?

Of course! :)

PR: https://github.com/m4tthumphrey/php-gitlab-api/pull/82

@paolomainardi Are you still planning on completing this for all of the API endpoints?

@m4tthumphrey yes but probably you missed this MR: https://github.com/m4tthumphrey/php-gitlab-api/pull/82 :)

No I did see it but it only has the project endpoints updated at the moment...?

It covers also the other endpoints:
https://github.com/m4tthumphrey/php-gitlab-api/pull/82/files

Ah yes so it does, I'm sorry!


Description of use uses the quote macro without explaining it

In the code sample in http://elixirschool.com/lessons/basics/modules/#use, you use the quote macro but I don't yet know what that means.

quote macro is described in metaprogramming lesson. We should add some links in modules lesson like typespec in documentation.

Solution in https://github.com/doomspork/elixir-school/pull/686


Configurable "BluetoothLEAdvertisementWatcher"

Hello.
Can you add the possibility to provide the BluetoothLEAdvertisementWatcher instance in the WindowsBluetoothPacketProvider constructor?
I need to configure SignalStrengthFilter and currently I'm using reflection:
_windowsBluetoothPacketProvider = new WindowsBluetoothPacketProvider();
_beaconManager = new BeaconManager(_windowsBluetoothPacketProvider);
var field = typeof(WindowsBluetoothPacketProvider).GetField("_watcher", BindingFlags.NonPublic | BindingFlags.Instance);
var watcher = (BluetoothLEAdvertisementWatcher) field.GetValue(_windowsBluetoothPacketProvider);

watcher.SignalStrengthFilter ... (etc)

I thin that can be very usefull.
Best regards
Marco

Take a look at this PR:
https://github.com/andijakl/universal-beacon/pull/18

@ctacke I've looked at the PR and I think that is perfect 👍
Thanks


Can't reinitilize dependuncies bindings when Get.off()

Describe the bug
I suppose that I can reinitialize the dependencies bindings for some cases ex: Get.off(), like the below example. I want to replace the route not push it.
**Reproduction code
example:
import 'package:dio/dio.dart';
import 'package:flutter/material.dart';
import 'package:get/get.dart';

void main() {
  runApp(MyApp());
}

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return GetMaterialApp(
      initialRoute: '/register',
      getPages: [
        GetPage(
          name: '/register',
          page: () => RegisterView(),
          binding: AuthBindings(),
        ),
        GetPage(
          name: '/login',
          page: () => LoginView(),
          binding: AuthBindings(),
        ),
      ],
    );
  }
}

class AuthBindings extends Bindings {
  @override
  void dependencies() {
    Get.lazyPut(() => Dio());
    Get.lazyPut(() => AuthRemoteDataSource(dio: Get.find()));
    Get.lazyPut(() => AuthRepository(authRemoteDataSource: Get.find()));
    Get.lazyPut(() => RegisterController(authRepository: Get.find()));
    Get.lazyPut(() => LoginController(authRepository: Get.find()));
  }
}

class RegisterView extends GetView<RegisterController> {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      body: Center(
        child: Column(
          mainAxisAlignment: MainAxisAlignment.center,
          children: [
            RaisedButton(
              child: Text('Call Register'),
              onPressed: () {
                controller.register();
              },
            ),
            RaisedButton(
              child: Text('Goto Login'),
              onPressed: () => Get.off(LoginView()),
            ),
          ],
        ),
      ),
    );
  }
}

class LoginView extends GetView<LoginController> {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      body: Center(
        child: Column(
          mainAxisAlignment: MainAxisAlignment.center,
          children: [
            RaisedButton(
              child: Text('Call Login'),
              onPressed: () {
                controller.login();
              },
            ),
            RaisedButton(
              child: Text('Goto Login'),
              onPressed: () => Get.off(RegisterView()),
            ),
          ],
        ),
      ),
    );
  }
}

class RegisterController extends GetxController {
  RegisterController({this.authRepository});

  final AuthRepository authRepository;

  register() {
    authRepository.register();
  }
}

class LoginController extends GetxController {
  LoginController({this.authRepository});

  final AuthRepository authRepository;

  login() {
    authRepository.login();
  }
}

class AuthRepository {
  AuthRepository({this.authRemoteDataSource});

  final AuthRemoteDataSource authRemoteDataSource;

  login() async {
    return await authRemoteDataSource.login();
  }

  register() async {
    return await authRemoteDataSource.register();
  }
}

class AuthRemoteDataSource {
  AuthRemoteDataSource({this.dio});

  final Dio dio;

  login() async {
    await dio.get('https://www.google.com');
  }

  register() async {
    await dio.get('https://www.google.com');
  }
}

To Reproduce
Steps to reproduce the behavior:

Click on Call Register
Click on Goto Login
Click on Call login

Expected behavior
Supposed that dependencies are reinitialized, but they are removed from memory and cant be initialized again.
Performing hot restart...
Syncing files to device Android SDK built for x86...
Restarted application in 2,896ms.
[GETX] "GetMaterialController" has been initialized
[GETX] GOING TO ROUTE /register
[GETX] Lazy instance "RegisterController" created
[GETX] Lazy instance "AuthRepository" created
[GETX] Lazy instance "AuthRemoteDataSource" created
[GETX] Lazy instance "Dio" created
[GETX] "RegisterController" has been initialized
[GETX] REPLACE ROUTE /register
[GETX] NEW ROUTE /LoginView
[GETX] "Dio" deleted from memory
[GETX] "AuthRemoteDataSource" deleted from memory
[GETX] "AuthRepository" deleted from memory
[GETX] "RegisterController" onClose() called
[GETX] "RegisterController" deleted from memory
[GETX] Lazy instance "LoginController" created

════════ Exception caught by gesture ═══════════════════════════════════════════════════════════════
The following message was thrown while handling a gesture:
"AuthRepository" not found. You need to call "Get.put(AuthRepository())" or "Get.lazyPut(()=>AuthRepository())"

When the exception was thrown, this was the stack:
#0      GetInstance.find (package:get/get_instance/src/get_instance.dart:284:9)
#1      Inst.find (package:get/get_instance/src/extension_instance.dart:66:44)
#2      AuthBindings.dependencies.<anonymous closure> (package:getx_sample/main.dart:37:59)
#3      GetInstance.find (package:get/get_instance/src/get_instance.dart:288:50)
#4      GetView.controller (package:get/get_state_manager/src/simple/get_view.dart:36:37)
...
Handler: "onTap"
Recognizer: TapGestureRecognizer#270b0
  debugOwner: GestureDetector
  state: possible
  won arena
  finalPosition: Offset(173.0, 303.0)
  finalLocalPosition: Offset(40.5, 25.0)
  button: 1
  sent tap down

Flutter Version:
1.22.2
Getx Version:
3.15.0
Describe on which device you found the bug:
Emulator

After a lot of attempts I solved this issue, but I want to see your solutions.
:)

After a lot of attempts I solved this issue, but I want to see your solutions.
:)

Hi, could you please share the solution. I am having lot of issues due to this... In my application when I save the form and use Get.off, it deletes all the Controller Instances.. leaving no states in memory apart from dpenedencies where I have used loaded as permamnent. Or something I am doing wrong .. If anyone can share a good example using GetX and Auth with firebase and storage, along with a simple crud, like a blog.. with post and comments stream. Using GetX folder structure. Please help, I am strugling to use GetX full fledged.
Thanks in advance, Prakash

AuthRemoteDataSource, AuthRepository, RegisterController and LoginController must extend GetxService and not GetxController.
GetxService can not be removed from memory.
See: https://github.com/jonataslaw/getx#getxservice

If you don't want to use GetxService, an alternative is to use the fenix property of the lazyPut method. For example:
class AuthBindings extends Bindings {
  @override
  void dependencies() {
    Get.lazyPut(() => Dio(), fenix: true);
    Get.lazyPut(() => AuthRemoteDataSource(dio: Get.find()), fenix: true);
    Get.lazyPut(() => AuthRepository(authRemoteDataSource: Get.find()), fenix: true);
    Get.lazyPut(() => RegisterController(authRepository: Get.find()), fenix: true);
    Get.lazyPut(() => LoginController(authRepository: Get.find()), fenix: true);
  }
}

fenix is similar to "permanent" (Get.put property), the difference is that the instance is discarded when is not being used, but when it's use is needed again, Get will recreate the instance.

Hi I’m sharing my code.. please if you can just have a quick look and let me know how can I improve.. I am not using repositories, providers .. because I am yet to understand how to distinguish in them.. I’m actually using MVC pattern only .. I am waiting for a good example on GetX package, so that I can understand what goes where, and differentiate repository, service, controller and repositories.
Please have a look, lots of thanks again.
https://prod.liveshare.vsengsaas.visualstudio.com/join?B1B35782779A75E67C3636AE44A4CFF9EDFE
Regards, Prakash
Sent from Mailhttps://go.microsoft.com/fwlink/?LinkId=550986 for Windows 10
From: Eduardo<EMAIL_ADDRESS>Sent: Wednesday, 4 November 2020 5:29 AM
To<EMAIL_ADDRESS>Cc<EMAIL_ADDRESS><EMAIL_ADDRESS>Subject: Re: [jonataslaw/getx] Can't reinitilize dependuncies bindings when Get.off() (#757)
AuthRemoteDataSource, AuthRepository, RegisterController and LoginController must extend GetxService and not GetxController.
GetxService can not be removed from memory.
See: https://github.com/jonataslaw/getx#getxservice
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/jonataslaw/getx/issues/757#issuecomment-721437120, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AONSOGTZRR3W5IED4RPXXPDSOCKMJANCNFSM4TGDRFGA.

How can you force the controller to be deleted and recreated/reinitialised on command?

Do not use Get.off, but Get.offNamed if you are using named routes.
Use the fenix parameter if you want the controller to reboot after deleting.
Since I couldn't find a problem in the code presented, I'm closing this


Use v1.17.2 kindest image because 1.17.4 is not available

Bump k8s version down from 1.17.4 -> 1.17.2 by using pre-built kindest image.
https://hub.docker.com/layers/kindest/node/v1.17.2/images/sha256-59df31fc61d1da5f46e8a61ef612fa53d3f9140f82419d1ef1a6b9656c6b737c?context=explore

Can you do this on the new yelp fork?
https://github.com/Yelp/kind


Fix: Prevent query parameter parsing from consuming request body in S…

This pull request addresses an issue where the use of @QueryParameter in Stapler was causing the request body to be prematurely consumed in some servlet containers (see #416 ).
The fix involves modifying QueryParameter.java to manually parse the query string instead of using request.getParameter(). This change ensures that query parameters are obtained without triggering the consumption of the request body, which is especially important for POST requests that need to retain their body content.
Automated Tests: Ran the existing test suite, which verifies the functionality of @QueryParameter.
Manual Tests:
Tested GET and POST requests with query parameters to confirm they are parsed correctly.
Verified that POST requests with a body retain their content and are unaffected by query parameter processing.
Checked that requests without required query parameters trigger the appropriate exceptions.
Submitter Checklist
-Created the PR from a topic branch, not the main branch.
-Provided a descriptive title for the pull request.
-Linked to the relevant issue: #416 .
-Added new tests to cover the change, ensuring it works as expected.

Thank you for the detailed feedback and insights! I understand now that the behavior of @QueryParameter—accessing both query and body parameters—is a critical part of Jenkins core and plugin interactions. Based on your comments, I’d like to propose the following steps to address the concerns:

Preserving Current Behavior:
Since Jenkins relies on this behavior, I agree that it cannot be altered without significant work and potential breakages. Instead, we can update the documentation or contract for @QueryParameter to reflect this dual behavior clearly. This would inform consumers of the API about the implications when using @QueryParameter with POST requests.

Alternative Approach for #416:
If the root issue of #416 (request body consumption) remains valid, we could explore alternate solutions, such as:
Introducing a new annotation (e.g., @QueryOnlyParameter) specifically designed to fetch query parameters without consuming the body.
Providing guidance for consumers on handling scenarios where both query and body parameters are needed.

Validation and Secrets Handling:
I acknowledge the potential security concerns raised by @jtnord regarding exposing secrets in query parameters through HTTP logs. This is a valid concern, and any proposed changes should carefully account for such risks.

Path Forward:
Given the dependency on the existing behavior, would you agree to:
Update the documentation for @QueryParameter to reflect its dual behavior?
Open a new discussion or issue to explore safer and more robust alternatives to fetch query parameters without consuming the request body?

Please let me know your thoughts, and I’d be happy to adjust the PR or contribute further in line with your guidance. Thank you again for taking the time to review and discuss this in detail.

From my point of view, option 4 updating the docs makes sense, 2 would be possible if there is a need for it, but I'm not sure there is a need.


indicate the correct ipex model class in testing

Hi @echarlaix . It's just a minor change to indicate the correct ipex model class in the testing. Fixed the wrong match of the token classification task and sequence classification task.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.


[docs] fix broken accordions on leafletjs.com + offline docs

added missing reference.js to html layout (see #6759)
all live docs since 1.0.0 affected  (tested on chrome / safari /firefox)

Thanks for noticing this!


Dual boot between Mojave and Ventura

Hello everybody!
Running successfully a 5.1 Mac Pro (2010) with OCLP Ventura. Before updating to 1.4.3 I could easily switch between Mojave and Monterey. The two OS are on separate SSD-drives. Now that I have Ventura and 1.4.3 booting Mojave doesn't work anymore. I can press the drive in Picker but then the computer shuts down and nothing is happening anymore. Is there somebody who could give me some advise? Many thanks for your help!

Hi again community
I tried a few things but didn't make it work.
I found out that when trying to boot the "old" installation of Mojave in Boot picker it doesn't recognise the system (Ø) but when I take out the new system disc (Ventura), booting directly from the old drive works perfectly fine.
So it seems to me that the EFI Boot Picker is somehow broken. Is there a way to fix it?
Many thanks to you all for reading and helping!
Uli


Some Docker updates

I'm considering moving this to its own repo so that it can be updated separately from Vumi itself and Travis can test the container and such things. Anyway, for now here are a few changes.

Vumi 0.6.8
Some tweaks to the entrypoint script
Made the entrypoint script the CMD rather than ENTRYPOINT this means that if you want to pass arguments to the script you have to do CMD ["/app/vumi-entrypoint.sh", "arg1", "arg2"] but it means it's easier to do things like docker run vumi bash and get a shell. I prefer having the entrypoint fixed and updating the command. This will require some small changes to one or two images in mama-ng-dockerconfig.

Plus one on making a separate repository for the docker container.

:+1:


charts,manifests: Fix the invalid metering image tag in the upstream CSV manifest

There's no quay.io/coreos/metering-ansible-operator:4.7 image tag, but there is a release-4.7 one that got overridden by the PR that bumped all of the image tags to 4.7.

/retest

/retest

/retest

/retest

/retest

Going to push this through as there's nothing in this PR that would cause e2e failures.
/override ci/prow/metering-e2e-aws
/override ci/prow/metering-upgrade-aws


Automatically reconnect PostgreSQL database connections

Before issuing a query we always make sure a database connection is set up. But if this connection has become broken the query will fail anyhow. This adds a connection status check as well before any query, and if the connection status is not OK we simply reconnect.

Woho! :+1:


power sensor problem

tell me what the problem is, at the moment of activation of the power sensor, information about the operation mode of the air conditioner disappears, although the air conditioner continues to work as expected.
https://youtu.be/_e50ELtY73c

Ya I too see when power sensor is OFF, I am able to control modes & Temperature which is not correct.
When Power sensor is OFF all the controls in the UI should be disabled. When Power Sensor ON all the controls in the UI should be enabled .
Please help to fix


Add daily Go builds

Discussed in #140
This may not be the best way to accomplish the goal, but it's a starting point.
Much of this is copy/paste from the CPP build scripts. I've tested the Docker image. The S3 push/pull is untested.
Thanks in advance for taking the time to review this!

Works a treat! thanks :)


[builds-1.1] BUILD-1023: Set labels on operator bundle

Set the missing EC required labels on the operator bundle. Most values were sourced from the bundle image for v1.0.2.

EC validations for missing labels on the bundle are now passing.


Aspose .NET Duplicate Detection Readme Added

Please merge the changes with the main branch

Thank you for Quick response. Please reply me with ur name, i would like to discuss something about releases<EMAIL_ADDRESS>


Chat – “Hmm... ” page appears briefly when navigate to IOU link while logout

Details

This PR replaces withOnyx with useOnyx to obtain reportMetadata in ReportScreen. It fixes the issue with displaying the not found page briefly when deeplinking to the specific report after logging in. reportMetadata stores the loading state for fetching the report. When it was read using withOnyx this state wasn't properly obtained from Onyx, reportMetadata?.isLoadingInitialReportActions was false while the report was loading what caused showing the not found page.
It also fixes the issue with reading routes from navigationRef in the resetHomeRouteParams function.
Fixed Issues

$ https://github.com/Expensify/App/issues/45899
PROPOSAL:
Tests

[ ] Verify that no errors appear in the JS console

Launch the Expensify app
Log in with Gmail account
Create a IOU in a conversation
Navigate to the IOU report (conversation)
Copy the URL
Log out of the app
Navigate to the IOU URL
Log in with the same account
Verify if the not found page doesn't appear on the ReportScreen.

Offline tests

QA Steps

[ ] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

MacOS: Chrome / Safari

https://github.com/user-attachments/assets/b8f6e84f-463e-47c7-9e94-0700d62f4d86

checking now

@abdulrahuman5196 This issue should already be resolved, I see that Report Screen has been migrated to use useOnyx in this PR. If this error no longer appears, I'll close this PR

@WojtekBoman I think we can close this PR since the issue was not reproducible - https://github.com/Expensify/App/issues/45899#issuecomment-2306955980


Add "scope" to now.json

I am a member of multiple teams, and it has happened to me many times that I deploy a project with the wrong team.
It would be great to be able to specify a whitelist of possible teams to deploy a certain project with in the now.json, for example:
{
  "teams": ["space-program", "mxstbr"]
}

Second this ++

You can now set scope in now.json for this (details here).


Add Typix

Repo URL: https://github.com/loqusion/typix
I wasn't sure where to add it, so I added it under "Programming" because I figured that's where it fit best.

Thanks for the awesome contribution @tomodachi94 !


Freeplay assets dissapearing

Describe your bug here.
Im working on a custom character and it all works but i have an issue, whenever i enter and exit a song the virtual numbers and the bg completely dissapear
before entering a song

after entering a song

Command Prompt/Terminal logs ()
No response
Are you modding a build from source or with Lua?
Lua
What is your build target?
Windows
Did you edit anything in this build? If so, mention or summarize your changes.
copied and modified bf's character data

Fixed in2.0.1


Add a SFINAE friendly iterator_traits and use that instead.

Fixes https://github.com/nlohmann/json/issues/1341 by implementing our own iterator_traits and using that instead to detect whether a type is an iterator.

Pull request checklist
Read the Contribution Guidelines for detailed information.

[x]  Changes are described in the pull request, or an existing issue is referenced.
[x]  The test suite compiles and runs without error.
[x]  Code coverage is 100%. Test cases can be added by editing the test suite.
[x]  The source code is amalgamated; that is, after making changes to the sources in the include/nlohmann directory, run make amalgamate to create the single-header file single_include/nlohmann/json.hpp. The whole process is described here.

Please don't

The C++11 support varies between different compilers and versions. Please note the list of supported compilers. Some compilers like GCC 4.7 (and earlier), Clang 3.3 (and earlier), or Microsoft Visual Studio 13.0 and earlier are known not to work due to missing or incomplete C++11 support. Please refrain from proposing changes that work around these compiler's limitations with #ifdefs or other means.
Specifically, I am aware of compilation problems with Microsoft Visual Studio (there even is an issue label for these kind of bugs). I understand that even in 2016, complete C++11 support isn't there yet. But please also understand that I do not want to drop features or uglify the code just to make Microsoft's sub-standard compiler happy. The past has shown that there are ways to express the functionality such that the code compiles with the most recent MSVC - unfortunately, this is not the main objective of the project.
Please refrain from proposing changes that would break JSON conformance. If you propose a conformant extension of JSON to be supported by the library, please motivate this extension.
Please do not open pull requests that address multiple issues.

Coverage remained the same at 100.0% when pulling f665a9233062397c9e713bbac1ff63f5f0a6fe45 on davedissian:bugfix/sfinae-iterator-traits into d2e6e1bf5852d9c8f2470c7c99eb6e600bb79138 on nlohmann:develop.

@davedissian Could you please have a look at the requested changes?

@nlohmann Sorry, yes. Been meaning to get round to it :)

I think this is ready to merge. @theodelrieu Do you agree?

I added a minor comment, otherwise it looks good to me


iKK/SPM

This PR implements the following changes:

Use XCode's automatic Swift5 update
update SwiftLint version (from 0.25.0 to newest 0.42.0 in file .swiftlint.yml
eliminate deprication warning by re-writing hash.withUnsafeBytes { ... } inside file IconGenerator.swift (i.e. selectColors() method)
Swift Package Manager SPM added

Please, don't forget to tag your branch as SPM to make SPM work!

Please update .travis.yml to use a newer Xcode image.

no clue what travis is or how I would mittigate this missing checks


xilem_core: Support generic Messages

This adds yet another generic parameter Message to the View, ViewSequence and AnyView trait, such that implementors have more freedom about what the message is. This is necessary for xilem_web, as a Send bound is not possible to use with wasm_bindgen IIRC. (At least I had to remove it in the DynMessage to get it to compile...).
It was fortunately straight-forward to just add the Message param with the default DynMessage. Basically search replace... (I hope I haven't missed anything, but I went through it twice...)

So obviously this does have some consequences for the ergonomics of Xilem Web, but makes Xilem "proper" more ergonomic.

I don't think it's too bad, when it doesn't directly concern the end-user, maybe all of this is less of an "issue" when we get something like trait aliases. In any way I agree.


Automate pulling list of tickets

We will pull the list of tickets from Pretix to a local store (csv for data base) in a certain time interval (e.g. 1 hour)
related to #3 - we need integration to Pretix to do that.

Since #108, all Pretix data is fetched on bot startup, and updated with recent changes every 5 minutes. Code:

Periodic fetch
Only fetch updates since last fetch


Not working iOS 11 + Carthage

When running:
dyld: Library not loaded: @rpath/Gloss.framework/Gloss
  Referenced from: /Users/rafaelferreira/Library/Developer/CoreSimulator/Devices/D6083D1C-6AAB-4A4B-804F-8F0310FDBE78/data/Containers/Bundle/Application/7190F704-5B50-4679-B319-194175A0A3EF/TheMovieDB.app/Frameworks/RxCache.framework/RxCache
  Reason: image not found

Apparently Gloss.framework is required by project even when I didn't use it.