[Bug]: AndroidDisplayMetrics missing check null

Platform
Android 14
Plugin
device_info_plus
Version
9.1.2
Flutter SDK
3.27.1
Steps to reproduce
Some deveice in product missing prama
Code Sample
No response
Logs
# Crashlytics - Stack trace
# Application: com.example.example
# Platform: android
# Version: 1.0.0 (13)
# Issue: 36b01d51db2362e921df861b1fba2019
# Session: 677363B3006900011DF4B20039DDF8D9_DNE_0_v2
# Date: Tue Dec 31 2024 10:23:32 GMT+0700 (Indochina Time)

Non-fatal Exception: io.flutter.plugins.firebase.crashlytics.FlutterError: type 'Null' is not a subtype of type 'double'
       at AndroidDisplayMetrics._fromMap(android_device_info.dart:302)
       at AndroidDeviceInfo.fromMap(android_device_info.dart:169)
       at DeviceInfoPlugin.androidInfo(device_info_plus.dart:54)
       at SFirebaseAnalytics.initialize(firebase_analytics.dart:37)
       at main.<fn>(main.dart:39)
       at .main(main.dart:24)

Flutter Doctor
[✓] Flutter (Channel stable, 3.24.5, on macOS 12.7.6 21H1320 darwin-x64, locale en-VN)
    • Flutter version 3.24.5 on channel stable at /Users/longtn/fvm/versions/3.24.5
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision dec2ee5c1f (7 weeks ago), 2024-11-13 11:13:06 -0800
    • Engine revision a18df97ca5
    • Dart version 3.5.4
    • DevTools version 2.37.3

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Users/longtn/Library/Android/sdk
    • Platform android-34, build-tools 34.0.0
    • ANDROID_HOME = /Users/longtn/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.11+0-17.0.11b1207.24-11852314)
    • All Android licenses accepted.

Checklist before submitting a bug

[X] I searched issues in this repository and couldn't find such bug/problem
[X] I Google'd a solution and I couldn't find it
[X] I searched on StackOverflow for a solution and I couldn't find it
[X] I read the README.md file of the plugin
[X] I'm using the latest version of the plugin
[X] All dependencies are up to date with flutter pub upgrade
[X] I did a flutter clean
[X] I tried running the example project

Display metrics were removed in version 10, you have a version mismatch somewhere.
I'd suggest upgrading dependencies and/or using dependency overrides to pinpoint to the latest device info plus.


Adding welcome messages from sbm

@rudigiesler @smn here are the welcome messages that are prepended to the app.
Review please.

Are we sure about the filename? The snippet @rudigiesler shared in Slack mentioned static/audio/registation/eng_NG/welcome_mother.mp3 not welcome_message.mp3

I think that the filename is welcome_mother.mp3 instead of welcome_message.mp3 https://github.com/praekelt/hellomama-registration/blob/2549c8314a1a05acea513b5dda18fea9a8223723/registrations/tasks.py#L221

:+1:

:+1:


[PE-D][Tester B] Names do not accept "/" which is common in Indian names

It is common for Indian names to contain "s/o" or "d/o" which is not allowed as a name in the current implementation. I believe it is reasonable for clients to have names containing "/" and thus this should be allowed to be in the name.

Labels: severity.Low type.FeatureFlaw
original: ChenLeiyu/ped#4

Will fix this by updating UG to show the work around to use 's o' or 'son off '


Macro: "Zoom" tool

There is a zoom button
Zoom button has 3 options

zoom in
zoom out
100%

When user clicks to zoom in, system zooms in to the center of the current view (limits and step similar to ketcher)
When user clicks to zoom out, system zooms out of the center of the current view (limits and step similar to ketcher)
When user clicks 100% the system returns to 100% scale

Manual tests added to the Automation table


Clean up unused keywords

AlaSQL now has many unused keywords, we need to clean it also.

We can put here candidates:

VALUE (but keep VALUES for INSERT)
ROW
MATRIX
RECORDSET
TEXTSTRING

Other keywords can be analyzed from wiki - they have empty pages...


b21: Creating style elements for ViewEncapsulation.Native

Prior to b21 every style elements was created with DOM.createStyleElement but with b21 for ViewEncapsulation.Native it creates with AppView.createStyleElement that simple uses document.createElement('STYLE').
I am using Angular and Polymer together so in my application I need to use document.createElement('STYLE', 'custom-style'). I'm extends from BrowserDomAdapter and override createStyleElement with this logic. But now it is working only for ViewEncapsulation.Emulated and ViewEncapsulation.None.
It is possible to override AppView and use custom or maby in AppView.createStyleElement you can use DOM.createStyleElement insted of call to document.createElement?

@ferhatb: Due to recent changes?

We made a decision to prefer speed and a simple code path to supporting overriding how style elements are created in this particular case. What does custom-style do @dentra?

@matanlurey custom-style is extension of the native <style> element that allows defining styles in the main document that can take advantage of several special features of Polymer's styling system. In html it looks like <style is="custom-style"> and can be created by calling document.createElement with custom-style as second parameter.
But this is only a part of problem, also I need to add additional include attribute to <style> elements (example: <style is="custom-style" include="shared-style">), so at this moment DOM.createStyleElement is prefferd way for me to override <style> element creation logic, but I am will happy to consider any other options.
Please take a look at Polymer's documentation https://www.polymer-project.org/1.0/docs/api/custom-style for details.

Ack, thanks. Ok, I found you a workaround for now:
In angular2/lib/src/platform/dom/shared_styles_host.dart there is a global variable called sharedStyleHost that we initialize at bootup. You can add your own, i.e.:
class PolymerCompatibleSharedStylesHost extends SharedStylesHost {
  ...
}

void main() {
  sharedStyleHost = new PolymerCompatibleSharedStylesHost();
}

@matanlurey unfortinally overriding SharedStylesHost is not an option because at addHost I can't get any style element - it created after this call.
  ShadowRoot createViewShadowRoot(dynamic hostElement) {
    assert(componentType.encapsulation == ViewEncapsulation.Native);
    var nodesParent;
    Element host = hostElement;
    nodesParent = host.createShadowRoot();
    sharedStylesHost.addHost(nodesParent); // <--- this might be overriden
    List<String> styles = componentType.styles;
    int styleCount = styles.length;
    for (var i = 0; i < styleCount; i++) {
      nodesParent.append(createStyleElement(styles[i])); // <--- can't get this style element to extend them
    }
    return nodesParent;
  }

  StyleElement createStyleElement(String css) {
    StyleElement el = document.createElement('STYLE');
    el.text = css;
    return el;
  }

Also I am not sure that we need to duplicate every style elements in DomSharedStylesHost.onStylesAdded previosly created for Emulated scope elements.

@matanlurey have you any update?

Hi sorry for the breakage. We are moving createStyleElement from AppView to SharedDomStyleHost so you can subclass and override. You'll have to create initializeSharedStyleHost() that will run before bootstrap. ETA: 9/29. Please manually patch app_view on your devbox until we land this.


Operations implement predicate instead of override equals and hashcode

I think this can be closed, @maheshrajamani ?


Impossible to build after renew Apple distribution certificates

Hello, I renew my 1year apple development account. I done all the processus to renew my certificates, Xcode is ok with my distribution provisioning profile, but when I run flutter I have this issue ( even after reboot, flutter clean, Xcode build clean )

Launching lib/main.dart on iPhone in debug mode...
Automatically signing iOS for device deployment using specified development team in Xcode project: 74XXXXXXX
Running Xcode build...
Xcode build done.                                           80,2s
Installing and launching...
════════════════════════════════════════════════════════════════════════════════
No Provisioning Profile was found for your project's Bundle Identifier or your
device. You can create a new Provisioning Profile for your project in Xcode for
your team by:
  1- Open the Flutter project's Xcode target with
       open ios/Runner.xcworkspace
  2- Select the 'Runner' project in the navigator then the 'Runner' target
     in the project settings
  3- Make sure a 'Development Team' is selected.
     - For Xcode 10, look under General > Signing > Team.
     - For Xcode 11 and newer, look under Signing & Capabilities > Team.
     You may need to:
         - Log in with your Apple ID in Xcode first
         - Ensure you have a valid unique Bundle ID
         - Register your device with your Apple Developer Account
         - Let Xcode automatically provision a profile for your app
  4- Build or run your project again

It's also possible that a previously installed app with the same Bundle
Identifier was signed with a different certificate.

For more information, please visit:
  https://flutter.dev/setup/#deploy-to-ios-devices

Or run on an iOS simulator without code signing
════════════════════════════════════════════════════════════════════════════════
2020-11-05 14:17:28.181 ios-deploy[13367:3403760] [ !! ] Error 0xe8008015: A valid provisioning profile for this executable was not found. AMDeviceSecureInstallApplication(0, device, url, options, install_callback, 0)
Could not run build/ios/iphoneos/Runner.app on 00008030-000448183438802E.
Try launching Xcode and selecting "Product > Run" to fix the problem:
  open ios/Runner.xcworkspace

Error launching application on iPhone.

Here is all my certificates steps. What is wrong ?

Thank you

@nitneuq33000
As the error says A valid provisioning profile for this executable was not found. AMDeviceSecureInstallApplication, this seems to indicate it could be an issue with Xcode provisioning and not related with flutter framework.
I'd suggest you ask this question on apple support forum or better suited on stackover flow.
Closing this from here. If you disagree, write in comments and I'll reopen.
Thanks.


Add option to disable service config in Go & Python

Disable the gRPC ServiceConfig DNS resolution in Go & Python.
Fixes #2778

Bump @lukesneeringer if you get a second, please review the changes to the python snippets to disable service config resolution in gRPC core


f-string parsing error

Describe the bug
Pylyzer fails to parse f strings with other strings inside them
Reproducible Code
pylyzer -c 'print(f"{"hello"}")'
Expected behavior
No error since this is valid python
Screenshots
If applicable, add screenshots to help explain your problem.
Environment

OS: macos Sequoia 15.0.1 (24A348)
Version: pylyzer 0.0.72

Additional context
The example is intentionally simplified, pylyzer also breaks on dictionary access by string keys inside f strings: pylyzer -c 'd={"1": ""}; f"{d["1"]}"'

Using strings inside f-strings is a relatively new syntax allowed in Python 3.12.
pylyzer uses RustPython/Parser for parsing Python syntax, but the current implementation does not seem to support this syntax.


toast message bug with scalars

Market range was 120-200
I entered an order to buy 1 share at 150...shows as 270 in the toast

fixed -closing


Open source this repo

Problem description
This package isn't open source, to allow for an easy transition after projects complete.
Expected behaviour/Acceptance criteria

Add a LICENSE file to this package (MIT)
Update the license in the package.json
Mark this repo as non-private
Mark the NPM package as non-private

:tada: This issue has been resolved in version 0.16.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Being able to invalidate/refresh family providers conditionally

Similar to select feature, being able to invalidate/refresh a family provider based on a function that returns a boolean and receives as parameters the family param(s)/key(s)

I'm not sure what the syntax for this would be.
We can't use ref.invalidate(family(arg: value)) because some args may be required or have default values. We'd need something else

I will try to study the code so I could propose a more feasible solution (if possible)

This feels like we'd need some way to programmatically select a specific set of arguments, based on what family instances already exist.
perhaps something like
ref.invalidate(family.selectWhere((arguments) => switch (arguments) {
      (_, 'foo', id: 1) => true,
      (false, 'bar', id: 2) => true,
      _ => false,
   },
));

which would invalidate family(true, 'foo', id: 1),  family(false, 'foo', id: 1), and family(false, 'bar', id: 2) if they exist
This would presumably require querying the container for all existing providers for the family, and running it's arguments record through the selector, and acting that way.
One would have to wonder what would happen when you tried to read this selector. would you get a list of values?

I do not want to expose a way to iterate over the existing arguments available, so I don't want such an API

Closing as I don't want to expose a way to iterate over arguments (as this could very easily be misused)

i dont think that "completed" is what this should have been closed as, but eh


feat(docs): Integrate Rust docs to our general mkDocs

Description

Integrated Rust docs to the general docs building process
Added corresponding links from mkDocs pages to the Rust docs

Related Issue(s)
Closes #148
Please confirm the following checks

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream module

docs: https://input-output-hk.github.io/catalyst-voices/branch/feat_rust_docs/

depends on https://github.com/input-output-hk/catalyst-ci/pull/120


fixes #13

Codecov Report

:exclamation: No coverage uploaded for pull request base (completa-pagina-curso@fe91dbe). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@                   Coverage Diff                    @@
##             completa-pagina-curso      #17   +/-   ##
========================================================
  Coverage                         ?   89.23%
========================================================
  Files                            ?        9
  Lines                            ?      715
  Branches                         ?        0
========================================================
  Hits                             ?      638
  Misses                           ?       77
  Partials                         ?        0

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Envoy performance does not match the same version

Envoy are all V1.17.0. But the envoy you compiled a month ago has a QPS of 1000. The latest QPS of 3000. why？

Looks like this was sent to wrong github project. People here (including me) know nothing about performance tweaking of envoy.


User request: show a warning when starting a game if the opponent has a disconnection rate of more than 3%

The information can be extracted from the JSON of /@/<username>/perf/<speed control> (i.e. /@/TotalNoob69/perf/rapid):
stat.count.disconnects/stat.count.all

Implemented in v2.3.22


Status server panics in aws-sdk

Full stack trace:
thread 'main' panicked at '`async fn` resumed after completion', /home/ubuntu/.cargo/registry/src/github.com-1ecc6299db9ec823/aws-sdk-s3-0.16.0/src/paginator.rs:40:33                                                                               [22/1213]
stack backtrace:
   0: rust_begin_unwind
             at /rustc/fe5b13d681f25ee6474be29d748c65adcd91f69e/library/std/src/panicking.rs:584:5
   1: core::panicking::panic_fmt
             at /rustc/fe5b13d681f25ee6474be29d748c65adcd91f69e/library/core/src/panicking.rs:143:14
   2: core::panicking::panic
             at /rustc/fe5b13d681f25ee6474be29d748c65adcd91f69e/library/core/src/panicking.rs:48:5
   3: aws_sdk_s3::paginator::ListObjectsV2Paginator::send::{{closure}}::{{closure}}
             at /home/ubuntu/.cargo/registry/src/github.com-1ecc6299db9ec823/aws-sdk-s3-0.16.0/src/paginator.rs:40:33
   4: <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll
             at /rustc/fe5b13d681f25ee6474be29d748c65adcd91f69e/library/core/src/future/mod.rs:91:19
   5: <core::pin::Pin<P> as core::future::future::Future>::poll
             at /rustc/fe5b13d681f25ee6474be29d748c65adcd91f69e/library/core/src/future/future.rs:124:9
   6: <aws_smithy_async::future::fn_stream::FnStream<Item,F> as futures_core::stream::Stream>::poll_next
             at /home/ubuntu/.cargo/registry/src/github.com-1ecc6299db9ec823/aws-smithy-async-0.46.0/src/future/fn_stream.rs:77:25
   7: <futures_util::stream::stream::map::Map<St,F> as futures_core::stream::Stream>::poll_next
             at /home/ubuntu/.cargo/registry/src/github.com-1ecc6299db9ec823/futures-util-0.3.21/src/stream/stream/map.rs:58:26
   8: <futures_util::stream::stream::flatten::Flatten<St,<St as futures_core::stream::Stream>::Item> as futures_core::stream::Stream>::poll_next
             at /home/ubuntu/.cargo/registry/src/github.com-1ecc6299db9ec823/futures-util-0.3.21/src/stream/stream/flatten.rs:55:44
   9: <futures_util::stream::stream::FlatMap<St,U,F> as futures_core::stream::Stream>::poll_next
             at /home/ubuntu/.cargo/registry/src/github.com-1ecc6299db9ec823/futures-util-0.3.21/src/lib.rs:102:13
  10: <core::pin::Pin<P> as futures_core::stream::Stream>::poll_next
             at /home/ubuntu/.cargo/registry/src/github.com-1ecc6299db9ec823/futures-core-0.3.21/src/stream.rs:120:9
  11: <S as futures_core::stream::TryStream>::try_poll_next
             at /home/ubuntu/.cargo/registry/src/github.com-1ecc6299db9ec823/futures-core-0.3.21/src/stream.rs:196:9
  12: <futures_util::stream::try_stream::try_collect::TryCollect<St,C> as core::future::future::Future>::poll
             at /home/ubuntu/.cargo/registry/src/github.com-1ecc6299db9ec823/futures-util-0.3.21/src/stream/try_stream/try_collect.rs:46:26
  13: poc_store::file_store::FileStore::list_all::{{closure}}
             at /home/ubuntu/poc5g-server/store/src/file_store.rs:65:58
  14: <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll
             at /rustc/fe5b13d681f25ee6474be29d748c65adcd91f69e/library/core/src/future/mod.rs:91:19
  15: poc5g_status::loader::Loader::process_events::{{closure}}
             at ./src/loader.rs:70:68
  16: <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll
             at /rustc/fe5b13d681f25ee6474be29d748c65adcd91f69e/library/core/src/future/mod.rs:91:19
  17: poc5g_status::loader::Loader::handle_store_tick::{{closure}}::{{closure}}::{{closure}}
             at ./src/loader.rs:57:66
  18: <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll
             at /rustc/fe5b13d681f25ee6474be29d748c65adcd91f69e/library/core/src/future/mod.rs:91:19
  19: <futures_util::stream::futures_unordered::FuturesUnordered<Fut> as futures_core::stream::Stream>::poll_next
             at /home/ubuntu/.cargo/registry/src/github.com-1ecc6299db9ec823/futures-util-0.3.21/src/stream/futures_unordered/mod.rs:514:17
  20: futures_util::stream::stream::StreamExt::poll_next_unpin
             at /home/ubuntu/.cargo/registry/src/github.com-1ecc6299db9ec823/futures-util-0.3.21/src/stream/stream/mod.rs:1626:9
  21: <futures_util::stream::stream::for_each_concurrent::ForEachConcurrent<St,Fut,F> as core::future::future::Future>::poll
             at /home/ubuntu/.cargo/registry/src/github.com-1ecc6299db9ec823/futures-util-0.3.21/src/stream/stream/for_each_concurrent.rs:104:19
  22: poc5g_status::loader::Loader::handle_store_tick::{{closure}}
             at ./src/loader.rs:58:15
  23: <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll
             at /rustc/fe5b13d681f25ee6474be29d748c65adcd91f69e/library/core/src/future/mod.rs:91:19
  24: poc5g_status::loader::Loader::run::{{closure}}
             at ./src/loader.rs:40:89
  25: <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll
             at /rustc/fe5b13d681f25ee6474be29d748c65adcd91f69e/library/core/src/future/mod.rs:91:19
  26: <tokio::future::maybe_done::MaybeDone<Fut> as core::future::future::Future>::poll
             at /home/ubuntu/.cargo/registry/src/github.com-1ecc6299db9ec823/tokio-1.20.0/src/future/maybe_done.rs:68:48
  27: poc5g_status::main::{{closure}}::{{closure}}
             at /home/ubuntu/.cargo/registry/src/github.com-1ecc6299db9ec823/tokio-1.20.0/src/macros/try_join.rs:162:24
  28: <tokio::future::poll_fn::PollFn<F> as core::future::future::Future>::poll
             at /home/ubuntu/.cargo/registry/src/github.com-1ecc6299db9ec823/tokio-1.20.0/src/future/poll_fn.rs:38:9
  29: poc5g_status::main::{{closure}}
             at ./src/main.rs:33:5
  30: <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll
             at /rustc/fe5b13d681f25ee6474be29d748c65adcd91f69e/library/core/src/future/mod.rs:91:19
  31: tokio::park::thread::CachedParkThread::block_on::{{closure}}
             at /home/ubuntu/.cargo/registry/src/github.com-1ecc6299db9ec823/tokio-1.20.0/src/park/thread.rs:263:54
  32: tokio::coop::with_budget::{{closure}}

We not handle the pagination ourselves and have not seen this panic since that change.


Question: first read memories

During the first run, mems == None, and the model doesn't attend to any "read" tokens, as per:
https://github.com/lucidrains/recurrent-memory-transformer-pytorch/blob/3be7d43604c6921a7dbdc68f88c7f3c534f82d2a/recurrent_memory_transformer_pytorch/recurrent_memory_transformer.py#L350-L355
Why not attend to read_memory_emb, and replace with
 read_mem_length = mem_length
 read_mems = repeat(self.read_memory_emb, 'm d -> b m d', b = batch)
 if exists(read_memories):
     read_mems += read_memories

@pfeatherstone ohh, yea i could add it and mask it out
is that the only thing keeping it from being onnx-able?

Pretty much. Basically nothing can be optional with tracing and ONNX. So both mems and mask must be specified

cool, will get it done later today!

@pfeatherstone decided to take the easy way out https://github.com/lucidrains/recurrent-memory-transformer-pytorch/commit/90de2ac64c1ce2d2ef90f3b63dbdcecf8af2a024 let me know if this does it

You still need to pass mems in the forward pass when tracing. So i think the fix would be to pass mems full of zeros and make the code handle that is if it were None

Then probably need some control flow in a torch.jit.script function which handles the different cases

@pfeatherstone have you tried this manually?

Yeah I have. I could submit a PR but I didn't know if passing zeros and allowing to attend to that was ok.

@pfeatherstone it is harmless to attend to it, as the 0s get summed to the read mem positional embeddings
however, decided to add a keyword argument on forward that can mask out the read memories if need be

@pfeatherstone all good?

Ah yes I need to try. Can it wait till Tuesday?

@pfeatherstone yea, just checking, take your time


[Enhancement] Save Asset View Options Settings (#147)

PR Details
Saving out asset view options (Filter tags, zoom, etc) so that new instances of the editor dont repeatively use default values. Some of the view options actually are already able to be saved between instances, added the filter tags and tile and grid zoom to those saved out.
Related Issue
Issue: https://github.com/stride3d/stride/issues/147#issuecomment-2157012923
Types of changes

[ ] Docs change / refactoring / dependency upgrade
[ ] Bug fix (non-breaking change which fixes an issue)
[X ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[ ] My change requires a change to the documentation.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.
[X] I have built and run the editor to try this change out.

Sorry about the delay, sounds like @Kryptos-FR is busy, I'll check back in on or two weeks if he hasn't looked at it by then

Looks good otherwise, thanks :)

Thanks !


[WIP] Added automatic port info detection from Dockerfile

Experimental

There is conflict between docker version of dockerfile and kedge :(


Add media queries to make the headers on the landing page responsive

Hey Aditya, that is a valid point.  I made it so the font size will change if both conditions are met.  We can discuss it at the meeting.
James


Make resolve-uri() optional for objects

I am referring to an image file in my Docbook file. The reference looks like this:
<mediaobject>
  <imageobject>
    <imagedata fileref="assets/L_2017117EN.01011402.tif.jpg"/>
  </imageobject>
</mediaobject>

The assets/ path is a path that's only resolvable in the final environment where the HTML file is placed, the assets are generated programmatically and retrieved via API call.
However, the tp:process-object template in objects.xsl uses resolve-uri() to create an absolute path to the asset. This turns out to be the local path on the system where I process the Docbook source:

Obviously, the file:/ URI is not resolvable in the target web environment where the browser interprets the HTML and then retrieves the image.
It would be great if there would be an option to retain the original URI of the media object.

This is supposed to be possible already by setting the $mediaobject-input-base-uri. In this case, if you set the input base URI to /var/folders/vc/j3pr3vw92ks_lvpknckv60t0000101/T/, you should get just assets/L_2017117EN.01011402.tif.jpg in the output.
I've struggled with this problem in lots of different ways.
I don't object to your patch in #90 but I'll have to think about how to explain how it relates to the other options.

Ah, I wasn't aware of that parameter! I'll try to use it, it's perfectly fine if it works that way. No additional parameters needed if that's the way it was intended to work.
My main use case is that I'm processing the Docbook file in a completely different folder structure than the one used to serve it to a browser, so I need control about how the asset paths are resolved.


Implement Serialize on IgnoreList

Closes #3536.

Thanks for your review. I added a test in https://github.com/rust-lang/rustfmt/pull/3565/commits/b37df8a3c143b857d38e0248bbf2852d29a0dca0.

thanks


Installation Guide - Link to STMS empty - SAPLink nuggets appear old

Dear colleagues,
in the wiki it is told that there is beside of abapGit (Preferred) also the option to install via STMS or SAPLink. But the link behind STMS appears to be empty. And when I look for SAPLink Nuggets in the given links, I see only old nuggets.
Do I miss some information?
Or should we remove the links to STMS and SAPLink as it appears that abapGit is the only pratical path to install abap2xlsx.
Thank you very much,
Rainer Winkler

Rainer,
you are right, STMS and SAPLink are obsolete and no longer maintained.

Dear Rainer,
what you could do is to import abap2xlsx in your NetWeaver ABAP Developer Edition using abapGit and assign the Objects to a package that is assigned to a transport request. That way you can create a transport request containing the latest abap2xlsx version. In future we might be able to use ABAP on SAP Cloud Platform to automate this process.
Best regards
Gregor

Dear Ivan, Dear Gregor,
thank you very much. I will see whether I manage to get a transport file from my developer edition.
Thank you very much,
Rainer

Dear Ivan, Dear Gregor,
I used now the export and import to and from zip file function from abapGit. I exported from my developer edition and imported into a sandbox system of my customer. This worked well. Although I was forced to repeat the import a few times (thereby sometimes overwriting "locally" changed objects or not setting the overwriting). After a few tries I was able to run ZDEMO_EXCEL without errors.
Thank you very much
Rainer


Add assignments to job#show

Originally created by Tom Smyth at 2018-03-20 22:18, migrated from redmine-#8176

Status changed from New to Closed

By Tom Smyth at 2018-04-02 01:01

Version set to 6.0

By Tom Smyth at 2018-04-29 11:24


Adds feature for enforcing ssl

In our project Varnish is responsible for redirecting to https

I think this is such a rare edge case that we don't need that specially defined. Should be able to archieve this by using the varnish_extra_definition blocks. @iler that might need some additional documentation ;)


Sample code doesn't work

The bellow sample code doesn't work. At least, it seems to need to be imported "date_format" and "when" function.
taxi_df = sampled_taxi_df.select('totalAmount', 'fareAmount', 'tipAmount', 'paymentType', 'rateCodeId', 'passengerCount'\
                                , 'tripDistance', 'tpepPickupDateTime', 'tpepDropoffDateTime'\
                                , date_format('tpepPickupDateTime', 'hh').alias('pickupHour')\
                                , date_format('tpepPickupDateTime', 'EEEE').alias('weekdayString')\
                                , (unix_timestamp(col('tpepDropoffDateTime')) - unix_timestamp(col('tpepPickupDateTime'))).alias('tripTimeSecs')\
                                , (when(col('tipAmount') > 0, 1).otherwise(0)).alias('tipped')
                                )\
                        .filter((sampled_taxi_df.passengerCount > 0) & (sampled_taxi_df.passengerCount < 8)\
                                & (sampled_taxi_df.tipAmount >= 0) & (sampled_taxi_df.tipAmount <= 25)\
                                & (sampled_taxi_df.fareAmount >= 1) & (sampled_taxi_df.fareAmount <= 250)\
                                & (sampled_taxi_df.tipAmount < sampled_taxi_df.fareAmount)\
                                & (sampled_taxi_df.tripDistance > 0) & (sampled_taxi_df.tripDistance <= 100)\
                                & (sampled_taxi_df.rateCodeId <= 5)
                                & (sampled_taxi_df.paymentType.isin({"1", "2"}))
                                )

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 075d1d7b-372e-0926-d74e-80cd173bd7a7
Version Independent ID: 86d2610b-7050-5150-7894-e8b766a81911
Content: Build a machine learning app with Apache Spark MLlib and Azure Synapse Analytics - Azure Synapse Analytics
Content Source: articles/synapse-analytics/spark/apache-spark-machine-learning-mllib-notebook.md
Service: synapse-analytics
GitHub Login: @euangms
Microsoft Alias: euang

@hidwatanabe do you perhaps have a cached or old version of the doc, the imports cell includes an import for date_format and when

The user must have been using an old or cached version of the doc as the current public doc no longer has this problem because an explicit import was added

@hidwatanabe  We will now proceed to close this thread. If there are further questions regarding this matter, please comment and we will gladly continue the discussion.


Explicitly list all reductions in api.rst

This PR makes a number of updates to api.rst. The main goal is to make it easier to navigate using the right-side "Contents" menu. By moving things from api-hidden.rst to api.rst many methods are now easier-to-discover.
list all reduction methods in their own subsection under "Dataset" and "DataArray".
before

after

List reductions for groupby etc
I've also added sections for rolling, coarsen, groupby, resample that again list available reductions. These were previously hidden

Class method names are much more readable.
Before

after

This looks great!
The only thing I noticed is that when I click on the headers in the content table to the right, the above header is exploded:

This behavior doesn't feel intuitive to me. It does happen on the stable version as well so it isn't related to this PR. Tested on windows 10 and Firefox.

Yeah I noticed that too on Firefox and Chrome (ubuntu)
cc @andersy005

@pydata/xarray I'd like to merge this to stable since it is doc-only and a pretty nice improvement

I think we should add the commit to both main and stable by cherry-picking to the other branch. A commit that is only on stable can be accidentally dropped on a new release.

This behavior doesn't feel intuitive to me. It does happen on the stable version as well so it isn't related to this PR. Tested on windows 10 and Firefox.

I'll look into this... It appears to be a CSS issue


Use bcrypt instead bcryptjs

Bcrypt has proper async handling. See https://github.com/dcodeIO/bcrypt.js/issues/39

Bcryptjs has a quite good async handling too. Due to easier dependencies, let us stick with it over bcrypt. See https://github.com/dcodeIO/bcrypt.js/issues/39


feature request: async before and after

https://github.com/svnlto/barf

I think this is a cool idea, but I'm going to close this since there hasn't been any further interest or activity.


added package.json for npm

It would be great to have that module in npm as well. It does not require any special formatting afaik, package.json is enough to be able to publish it by running npm publish.

It have already supported  bower. Now support npm is fine too.

Thank you! Would also be so kind to actually publish it?

Ok. Please wait for 30. I am on mobile now.

Here you are https://www.npmjs.com/package/html5-sortable-angularjs

Sweet! Thank you!

You're welcome :)


GCC_ARM compiler reports wrong code size

Hi,
When I tried to down size an app from STM32F401RE to STM32F401RC, I noticed the code size reported by GCC_ARM is usually less than actual code size. For the following blinky code:
#include "mbed.h"

int main() {
    Watchdog &watchdog = Watchdog::get_instance();
    watchdog.start(30000);
    printf("system started\r\n");

    DigitalOut led(PA_5);

    while (1)
    {
        printf("%d: System running\r\n", time(NULL));
        led = !led;
        ThisThread::sleep_for(1000);
        watchdog.kick();
    }
}

Running the following command:
mbed compile -t gcc_arm -m nucleo_f401re --profile release

leads to output:
Total Static RAM memory (data + bss): 14320(+48) bytes
Total Flash memory (text + data): 52276(+9736) bytes

However, when I open the generated HEX file in STM32CubeProgrammer, the code size reported to be 0xD648 = 54856
In the actual app I am working on, the code size reported by GCC_ARM is usually 70+KB less than actual size, something like 200KB vs 300KB. As a result, I ended up with a small batch of PCB that I don't know what to do with.

Thank you for raising this detailed GitHub issue. I am now notifying our internal issue triagers.
Internal Jira reference: https://jira.arm.com/browse/IOTBTOOL-676

I had reported this recently, but could not fix it completely. https://github.com/ARMmbed/mbed-os/issues/12541


Pdf.js viewer.html not calling all range requests

I have some issue in downloading the pdf using range requests. I am using spring boot application to provide download service. viewer.html makes 1st request which is cancelled since service supports range request and initiates partial request which is as expected but there are no further requests from browser, Its just 2 range requests where as i am expecting it to request till whole pdf is downloaded. Is there any special header that needs to be added in response so that browser sends all request to service. When i tried https://mozilla.github.io/pdf.js/web/viewer.html?file=compressed.tracemonkey-pldi-09.pdf link and inspect networks then i am able to see 1st request getting 200 response code which is cancelled before whole pdf is downloaded and then range requests(for all ranges) are initiated which gives 206 partial content
I have used spring boot for serving pdf by following https://gist.github.com/davinkevin/b97e39d7ce89198774b4
With these 2 set up and enabling cors requests. I am able to accomplish following

client is recognizing that server supports range request and is cancelling main request.
client is initiating range requests
added headers in response : accept-ranges, content-length, content-range, accept, etag, content-type, content-disposition, last-modified, expires, Connection,vary,via,Cache-Control and exposed all of them.

Problem faced :

client is initiating only 2 range requests after cancelling main request and stops there

In its current form, the issue will be closed as incomplete/invalid since its missing too much information.
You need to provide all of the information requested in https://github.com/mozilla/pdf.js/blob/master/.github/ISSUE_TEMPLATE.md when opening an issue, and please make sure to follow https://github.com/mozilla/pdf.js/blob/master/.github/CONTRIBUTING.md (emphasis mine):

If you are developing a custom solution, first check the examples at https://github.com/mozilla/pdf.js#learning and search existing issues. If this does not help, please prepare a short well-documented example that demonstrates the problem and make it accessible online on your website, JS Bin, GitHub, etc. before opening a new issue or contacting us on the IRC channel -- keep in mind that just code snippets won't help us troubleshoot the problem.

Indeed. Without a working demo, there is practically nothing we can do to debug this.


MG [ Error] [$rootScope:inprog] $apply already in progress

When I click on the button for the social login, i.e the Facebook Button, the login itself works fine but I get this error in the console:
MG [ Error] [$rootScope:inprog] $apply already in progress
It seems that the error is caused by the $auth.authenticate(provider) functionality.
Does anyone have the same issue or an idea how this can be solved?
Thanks alot :)

Does nobody have an idea? ;(

Same error, but occur sometimes calling $auth.authenticate(provider).
Maybe in $auth.authenticate there is a call to $apply without checking $digest, or in the button or the function that call $auth.authenticate(provider) need a prevent.default, preventing call twice the function $auth.authenticate and so the $apply just called by such function.

@ZengineAlex @antonellof @sahat
any news? same error here, but only happens on firefox


fix(#2265): add token side-menu-parent-color-bg-selected for side-men…

This is how to override the value:

Allow pp team to override the side-menu-group a.heading when one of its child is selected.

I have a question, if --goa-side-menu-parent-color-bg-selected is not set, the side-menu parent heading will have no backgroup when select. is it a breaking change, or do I missing some setup here?

This issue is verified on react and angular

:tada: This PR is included in version 5.0.0-alpha.13 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 3.0.0-alpha.9 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.29.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


DOI for VIS datasets

The two VIS datasets currently do not have a DOI issued by GBIF. One option - just like for Florabank - would be to give it the DOI of the datapaper (http://doi.org/10.3897/zookeys.475.8556). The difference would be that the two datasets would then share the same data paper DOI.
@DimEvil, thoughts? If OK, I'll contact GBIF.

The datasets have now DOIs. Both dataset DOI and data paper DOI are mentioned in the resource citation.


Stock Buy and Sell I

hey @ayu8 i want to contribute this problen in the DP folder. Pls assign me this and mark this issue under hacktoberfest label.

I want to work on this. Please assign me this.


HTTP path issue

This may be a simple issue, but it's beyond me currently.  I'm trying to setup redbird to reverse proxy my docker services, which are seen when I start redbird. However, the paths aren't respected when I try the URL. For example, when I type domain.ext:8080/prn, I'm redirected to domain.ext:8080/userlogin, which is the page that plexrequests automatically diverts a user to. If I change the URL to domain.ext:8080/prn/userlogin, I get the page, minus the CSS for it, and the log says "no valid route found for the given source".  I think I need some sort of "baseurl" function, but don't know how to manage that in the config.  My config is below. Any assistance you can offer would be appreciated.
`var proxy = require('redbird')({
port: 8080,
});
// var redbird = require('redbird')({
//     port: 8080,
// });
require('redbird')
.docker(proxy)
.register("domain.net/prn", 'rogueosb/plexrequestsnet');
require('redbird')
.docker(proxy)
.register("domain.net/nzb", 'linuxserver/nzbget');
`

I think you need this: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/base
In order to debug this, check in chrome dev tools what urls are actually being generated by your application. Proxy is stateless, he just proxies one url to another, it does not do anything besides that.

I've also tried adding ROOT_URL="http://localhost/prn" to the environment config for the container, which didn't help.  According to this area's comment on this page, https://github.com/tidusjar/PlexRequests.Net/issues/199, adding         proxy_pass http://localhost:3579/request;
to the proxy config may help. How would I add that to the redbird config file?  Thanks again for your help.

now trying a new docker image, from linuxserver/plexrequests. It says to add an environment variable of URL_BASE=/directory to the environment, which is what I've done. When I start the docker container, I can get to it using host:3000/prn, but when I use redbird, I get a 404 w/ manderso.net/prn. When i use manderso.net:3000/prn, the page comes up fine, css and all. Why wouldn't the specified port be passing? This is my current config:
`var proxy = require('redbird')({
port: 80,
});
// var redbird = require('redbird')({
//     port: 8080,
// });
require('redbird')
.docker(proxy)
.register("manderso.net/prn", 'linuxserver/plexrequests');
`

I have a similar problem. Paths are relative, so this should be fine.
App runs on :8080, reverse proxy routes to :80/cockpit

What am I doing wrong?

I found the culprit.
usually when you create a static express server, the path is interpreted as a folder.
Of course, that only works if the path ends with a slash: localhost/app/
Unfortunately, redbird does not support that as of now, so this does not work:
proxy.register('localhost/app/', 'localhost:8080')

I found my way around this problem by using subdomains.
proxy.register('app.localhost', 'localhost:8080')

Best,
Martin


--snapshot-id does not seem to work

When I followed the steps on the page, I am getting an error when trying to add a nodepool to an existing AKS cluster using the snapshot. I tried this on Azure Cloud Shell as well as on my local machine. az-cli version is 2.36.0 in both places.
az aks nodepool add --name np2 --cluster-name [cluster name] --resource-group [RG name] --snapshot-id $SNAPSHOT_ID
unrecognized arguments: --snapshot-id /subscriptions/[subscription ID]/resourceGroups/[RG name]/providers/Microsoft.ContainerService/snapshots/MySnapshot

I am getting a similar error message when trying to create a cluster using the az aks create command with the --snapshot-id parameter.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ba2a49af-10d0-9f2a-92b4-564f8a7ab514
Version Independent ID: 291646ac-698b-569c-c603-a3bbe74e3013
Content: Snapshot Azure Kubernetes Service (AKS) node pools - Azure Kubernetes Service
Content Source: articles/aks/node-pool-snapshot.md
Service: container-service
GitHub Login: @palma21
Microsoft Alias: jpalma

@felixtsem5 Thanks for the question! We are investigating and will update you shortly.

Hello @felixtsem5,
I think this may need aks-preview extension. Could you try update your cli and run:
az extension add --name aks-preview
az extension update --name aks-preview

@felixtsem5 - Any update on the above?

No luck. I am trying this in my Azure Cloud Shell.
felix@Azure:~$ az extension update --name aks-preview
felix@Azure:~$ az version
{
  "azure-cli": "2.36.0",
  "azure-cli-core": "2.36.0",
  "azure-cli-telemetry": "1.0.6",
  "extensions": {
    "ai-examples": "0.2.5",
    "aks-preview": "0.5.69",
    "ssh": "1.1.0"
  }
}
felix@Azure:~$ az aks snapshot create --name MySnapshot --resource-group [RG name] --cluster-id=[Cluster name] --nodepool-id $NODEPOOL_ID --location southcentralus
unrecognized arguments: --nodepool-id /subscriptions/[Subscription ID]/resourcegroups/[RG name]/providers/Microsoft.ContainerService/managedClusters/[Cluster name]/agentPools/nodepool1

Also, it seems like the second block of code in the page (az aks snapshot create) is missing the --cluster-id parameter.

@felixtsem5, I am testing this internally, I will update you shortly.

@felixtsem5,
Apologies for delay in getting back.  I have assigned the issue to the content author to investigate further and update the document as appropriate.

#reassign:asudbring

Related issue https://github.com/MicrosoftDocs/azure-docs/issues/97071

#reassign:Nickomang


Errors while compiling objc_exception v0.1.1

Hi,
I'm a total noob in the rust/cargo world and no matter how I try to build pathfinder 3, I always get stuck at objc_exception v0.1.1 (please see text dump below). Am I missing something or there's a bug?

Given the lack of cc1obj my guess is that you're missing the objective-C compiler in your installation.  Depending on your Linux distro the package name will differ, but on my computer it's called gobjc
I've no idea whether installing that will be sufficient, but it might get you a bit closer.

Hi @kinnison ,
thanks very much for your help, I guess you are right and I'll try to install the objective-C compiler (I had no clue from the error messages, now, thanks to your hint, they look more meaningful).
I'm sorry I posted this here, I didn't know it could the wrong place.
I'll folllow your advice and, if can't still sort it out, post a bit more detailed question in the user forum (I don't know where it is, but I'll search for it).
Thank again very much, I'm closing the thread :-)
Mario


Fix step tip styles overlapping during first animation

This PR fixes an issue that emerged after updating to ReacNative v0.64.0. It looks like native animations have improved, and give some of the styles are dynamic to create nice transitions/animations, the styles that come from the implemented step tip can potentially overlap with the async animation styles. The fix is simply to check if the animation styles are already present before rendering the tour tip.
Additionally, useRef(..) for animated values has been replaced with useState(..) which is better to handle state changes.

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Qualifying an enum value through Enum::MyEnum::Value does not work correctly in BC14

Please include the following with each issue:
1. Describe the bug
When using the syntax Enum::MyEnum::MyValue to reference an enum value inside a code block, the app compiles without issues. When I then try to publish this app to a BC14 (CU10) instancen using Publish-NAVApp I get the following error:
[...] (yy,xx): error AL0104: Syntax error, ',' expected"

2. To Reproduce

Define an enum with some values
Use that enum anywhere in the code using Enum::MyEnum::MyValue
Build the app
Install the app on a BC14 CU10 instance by using Publish-NAVApp

3. Expected behavior
There are two possibilities. The first would be to allow this kind of qualification on BC14 as well (BC17+ does not have any issues here). But I guess that for a number of reasons that is not possible and that's also fine.
The other solution would be to generate a compile-time error when trying this on a runtime that does not support this kind of syntax.
4. Actual behavior
Compilation works. Deployment fails.
5. Versions:

AL Language: v7.4.496506
Visual Studio Code: 1.59.1
Business Central: Platform 14.0.40464.0 + Application 41204 (W1 14.11)

Hi @hemisphera,
Thank you for logging the issue, I believe your code looks something like this:
enum 50120 MyEnum
{
    Extensible = true;

    value(0; MyFirstValue)
    {
    }

    value(1; MySecondValue)
    {
    }
}

codeunit 50130 MyCodeunit
{
    trigger OnRun()
     var
        myEnumInstance: Enum MyEnum;
    begin
        myEnumInstance := Enum::MyEnum::MyFirstValue;
    end;
}

Please, check if either of these workarounds will unblock you and you can continue developing. :)

enum 50120 MyEnum
{
    Extensible = true;

    value(0; MyFirstValue)
    {
    }

    value(1; MySecondValue)
    {
    }
}

codeunit 50130 MyCodeunit
{
    trigger OnRun()
     var
        myEnumInstance: Enum MyEnum;
    begin
        myEnumInstance := MyEnum::MyFirstValue;
    end;
}

enum 50120 MyEnum
{
    Extensible = true;

    value(0; MyFirstValue)
    {
    }

    value(1; MySecondValue)
    {
    }
}

codeunit 50130 MyCodeunit
{
    trigger OnRun()
     var
        myEnumInstance: Enum MyEnum;
        myOtherEnumInstance: Enum MyEnum;
    begin
        myEnumInstance := myOtherEnumInstance::MyFirstValue;
    end;
}

Hi @nndobrev ,
sure, they both work fine. And that is exactly what I did to continue working.
But this is clearly a bug of the AL compiler nonetheless. It allows me to compile an app that I cannot install. Why has this issue been closed?

@nndobrev Any update to why this issue is closed? This workaround can not be the definitive solution.

Hi @hemisphera, sorry that I have missed your previous comment.
We respect the community effort and the time you guys spend to log the errors and to show us the right direction we should follow in order to make AL compiler and hence Business Central a better production. However, our resources are not limitless and we have to prioritize our work.
There is indeed an issue on our side that we don't report the error earlier- in the VSC extension. I tested with an older version of the extension and it seems to be regression. The behaviour should be that even using the latest available extension from the marketplace when you target older runtime (in your case 3.0) you should see it. Considering the fact that the compiler reports the error when you are trying to publish the extension, even though later in the development process and also there is a clear workaround I closed the issue.

I had this issue, today again with AL Compiler version <IP_ADDRESS>77.
I'm only adding a comment, that I can find this issue more easily, since it looks like it won't be fixed.
Personally I would prefer a prioriziation tag for the issues instead of closing them.


cross-compile to OSX from linux

In the cross-compilation docs it looks like cross-compilation is mostly for building windows gems from OSX or Linux, but is there a way to build an OSX native gem from a Linux host?

No.
Because cross-compiler toolchain (such as MinGW for Windows) for macOS isn't provided on Linux.

@kou thanks!


REQUEST: New membership for

GitHub Username
bodhisatan
Requirements

[x] I have reviewed the community membership guidelines (https://github.com/cloudwego/community/blob/main/COMMUNITY_MEMBERSHIP.md)
[x] I have joined to the Slack Channel and Feishu Group Chat (for Chinese)
[x] I am contributing (any of the following apply: issues, discussions, PRs, reviews) to 1 or more CloudWeGo repositories

List of contributions to CloudWeGo
fix:

https://github.com/cloudwego/kitex/pull/398
https://github.com/hertz-contrib/jwt/pull/6
https://github.com/kitex-contrib/registry-servicecomb/pull/2
https://github.com/kitex-contrib/registry-etcd/pull/16

feat:

https://github.com/hertz-contrib/jwt/pull/1
https://github.com/hertz-contrib/swagger/pull/1
https://github.com/kitex-contrib/registry-servicecomb/pull/1
https://github.com/cloudwego/biz-demo/pull/24
https://github.com/hertz-contrib/jwt/commit/b6635d79f1cc76fa7a2281dbc13c270aea01ead3

test:

https://github.com/cloudwego/kitex/pull/392

doc:

https://github.com/cloudwego/cloudwego.github.io/pull/162
https://github.com/cloudwego/cloudwego.github.io/pull/191
https://github.com/cloudwego/cloudwego.github.io/pull/180

chore:

https://github.com/hertz-contrib/swagger/pull/2
https://github.com/hertz-contrib/jwt/pull/2
https://github.com/cloudwego/hertz/pull/29
https://github.com/cloudwego/kitex/pull/268

code review:

https://github.com/hertz-contrib/registry/pull/11

issues opened:

https://github.com/cloudwego/kitex/issues/405
https://github.com/cloudwego/hertz/issues/28

+1 ❤

+1

+1

+1

Thanks for your contribution! +1

+1

1

+1,  agree !

+1

Hi, your request has been reviewed by the CloudWeGo community management team and passed with majority approval. Congratulations !
You have been invited to join CloudWeGo org, kitex-contrib  and hertz-contrib as a public member, as well as Kitex Committer Team in CloudWeGo. Your certificate is here.
Please check Responsibilities and privileges for more details.
Welcome to Join us !

thank you all and I will keep learning and keep contributing to cwg!


Remove max version restriction for Dask/Distributed

In advance of our next release, removes the max version restriction for Dask/Distributed so that we can check for potential compatibility issues (specifically those raised in https://github.com/dask-contrib/dask-sql/issues/350 since dask-ml hasn't cut a release since @ayushdg's fix)

Codecov Report

Merging #369 (0af0a25) into main (286681f) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #369      +/-   ##
==========================================
- Coverage   95.57%   95.56%   -0.01%
==========================================
  Files          67       67
  Lines        2935     2933       -2
  Branches      547      547
==========================================
- Hits         2805     2803       -2
  Misses         79       79
  Partials       51       51

Impacted Files
Coverage Δ

dask_sql/physical/rel/custom/predict.py
95.34% <0.00%> (-0.11%)
:arrow_down:

dask_sql/utils.py
100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 286681f...0af0a25. Read the comment docs.


Use hex string as the representation of byte array for queries

Use hex string to represent byte[] value in query.
Refer to https://github.com/apache/incubator-pinot/issues/4040

Codecov Report

Merging #4041 into master will increase coverage by 0.03%.
The diff coverage is 42.85%.

@@             Coverage Diff              @@
##             master    #4041      +/-   ##
============================================
+ Coverage     67.24%   67.28%   +0.03%
  Complexity       20       20
============================================
  Files          1033     1033
  Lines         51338    51348      +10
  Branches       7181     7185       +4
============================================
+ Hits          34524    34550      +26
+ Misses        14432    14416      -16
  Partials       2382     2382

Impacted Files
Coverage Δ
Complexity Δ

...impl/dictionary/BytesOffHeapMutableDictionary.java
73.91% <33.33%> (-7.04%)
0 <0> (ø)

.../impl/dictionary/BytesOnHeapMutableDictionary.java
71.42% <50%> (-7.89%)
0 <0> (ø)

...er/validation/BrokerResourceValidationManager.java
50% <0%> (-31.25%)
0% <0%> (ø)

...cheduler/resources/PolicyBasedResourceManager.java
75% <0%> (-18.75%)
0% <0%> (ø)

...ore/query/scheduler/resources/ResourceManager.java
85.71% <0%> (-10.72%)
0% <0%> (ø)

...mpl/dictionary/DoubleOffHeapMutableDictionary.java
74.54% <0%> (-3.64%)
0% <0%> (ø)

...e/operator/dociditerators/MVScanDocIdIterator.java
60.6% <0%> (-3.04%)
0% <0%> (ø)

.../pinot/core/query/scheduler/PriorityScheduler.java
78.08% <0%> (-2.74%)
0% <0%> (ø)

...pinot/server/starter/helix/HelixServerStarter.java
52.94% <0%> (-2.21%)
0% <0%> (ø)

...not/broker/requesthandler/RangeMergeOptimizer.java
89.7% <0%> (-1.48%)
0% <0%> (ø)

... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c71c24...807e15c. Read the comment docs.

can we add a test case?

can we add a test case?

Modified existing dictionary test to let BYTES dictionary index values contain half byte[] and half hex String.

can we add a test case?

Modified existing dictionary test to let BYTES dictionary index values contain half byte[] and half hex String.

Can you add some motivation behind the change? I am guessing (but not sure) that we want to ingest string data that are known to be hexbytes. Is that right? Is this a part of a bigger design document? If so, can you point me to one (or, add one under https://cwiki.apache.org/confluence/display/PINOT/Design+Documents)
thanks

Can you add some motivation behind the change? I am guessing (but not sure) that we want to ingest string data that are known to be hexbytes. Is that right? Is this a part of a bigger design document? If so, can you point me to one (or, add one under https://cwiki.apache.org/confluence/display/PINOT/Design+Documents)
thanks

My major motivation is related to this issue: https://github.com/apache/incubator-pinot/issues/4040.
Basically I want to ingest data like uid as bytes format and write a lookup query on top of it. Since hex string is used to display bytes type in query results, I extend this concept and make hex string/bytes both accepted for this column.

Can you add some motivation behind the change? I am guessing (but not sure) that we want to ingest string data that are known to be hexbytes. Is that right? Is this a part of a bigger design document? If so, can you point me to one (or, add one under https://cwiki.apache.org/confluence/display/PINOT/Design+Documents)
thanks

My major motivation is related to this issue: #4040.
Basically I want to ingest data like uid as bytes format and write a lookup query on top of it. Since hex string is used to display bytes type in query results, I extend this concept and make hex string/bytes both accepted for this column.

Is it not possible to use a string datatype for this? Assuming that the string is byte-array encoded does not seem right to me. Perhaps I am missing something here

Can you add some motivation behind the change? I am guessing (but not sure) that we want to ingest string data that are known to be hexbytes. Is that right? Is this a part of a bigger design document? If so, can you point me to one (or, add one under https://cwiki.apache.org/confluence/display/PINOT/Design+Documents)
thanks

My major motivation is related to this issue: #4040.
Basically I want to ingest data like uid as bytes format and write a lookup query on top of it. Since hex string is used to display bytes type in query results, I extend this concept and make hex string/bytes both accepted for this column.

Is it not possible to use a string datatype for this? Assuming that the string is byte-array encoded does not seem right to me. Perhaps I am missing something here

This is to match the data in select query. Basically in select uid from myTable limit 10 query, I got a random row with uid value shown as "c8b3bce0b378fc5ce8067fc271a34892" which is a hex string. And if I want to fetch this row with predicate, I should use the same hex string in my query, say
select * from myTable where uid="c8b3bce0b378fc5ce8067fc271a34892"

will do
On Tue, Jun 11, 2019 at 09:30 Subbu Subramaniam<EMAIL_ADDRESS>wrote:

@mcvsubbu commented on this pull request.
@fx19880617 https://github.com/fx19880617 can you please add a query
example in https://pinot.readthedocs.io/en/latest/pql_examples.html
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/apache/incubator-pinot/pull/4041?email_source=notifications&email_token=ALCZUHHUJFENIW63LJQUTBTPZ7HKXA5CNFSM4HCN4AU2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB3GLJVQ#pullrequestreview-248296662,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ALCZUHHNE6XGSZVAETPT3OLPZ7HKXANCNFSM4HCN4AUQ
.


a button to swap between entering in ETH or entering in USD

https://github.com/BuidlGuidl/scaffold-wallet/pull/27


cdk/scrolling - scrolling is not working smoothly  for some input for custom strategy implemented by extending VirtualScrollStrategy

Is this a regression?

[ ] Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was
No response
Description
We have to implement virtual scrolling for list of items where item can be of either 100px hight or 50px height.
The hight of each item is known before rendering, We implemented custom strategy by extending VirtualScrollStrategy.
But the scrolling is not smooth and it is flickering for some combination of elements.
We have tried the approach used this link - https://stackblitz.com/edit/custom-virtual-scroll-stack-overflow-answer?file=src%2Fapp%2Fcustom-virtual-scroll-strategy-directive.ts
Is it really possible to implement virtual scrolling for variable size items by extending VirtualScrollStrategy?
Reproduction
Steps to reproduce:

open https://stackblitz.com/edit/custom-virtual-scroll-stack-overflow-answer?file=src%2Fapp%2Fcustom-virtual-scroll-strategy-directive.ts

Make the below changes to files
app.component.ts
                     import { Component, VERSION } from '@angular/core';

                     @Component({
                       selector: 'my-app',
                       templateUrl: './app.component.html',
                       styleUrls: ['./app.component.css'],
                     })
                     export class AppComponent {
                       items: number[] = Array.from(Array(500).keys()).map((i) =>
                         (i + 1) % 5 ? 50 : 100
                       );
                     }

app.component.html
              <cdk-virtual-scroll-viewport customVirtualScrollStrategy [itemHeights]="items">
                <div *cdkVirtualFor="let item of items; index as i">
                  {{ i }}
                </div>
              </cdk-virtual-scroll-viewport>

app.component.css
          div:nth-child(5n) {
            height: 100px;
            background: cyan;
            border: 1px black solid;
          }
          div {
            height: 50px;
            background: magenta;
            border: 1px black solid;
          }
          cdk-virtual-scroll-viewport {
            height: 500px;
          }

Expected Behavior
should scroll smoothly.
Actual Behavior
scrolling is not smooth and flickers sometime.
Environment

Angular:14.1.0
CDK/Material:14.1.0
Browser(s):Chrome
Operating System (e.g. Windows, macOS, Ubuntu):Windows

Same issue here but only when scrolling up :/


Correlated SQL sub-queries crashing

I have been testing some complex SQL sub-queries on MonetDB before the Nov2019 release and they triggered crashes. Meanwhile I see the same happens on DuckDB.
I think the best plan should be fixing one query at the time, because some of the problems might be correlated altogether.
Bellow each query I output the outcome from MonetDB, but notice that it might differ on DuckDB depending where the correlation happens, either inner or outer query.
CREATE TABLE tbl_ProductSales (ColID int, Product_Category  varchar(64), Product_Name  varchar(64), TotalSales int);
INSERT INTO tbl_ProductSales VALUES (1,'Game','Mobo Game',200),(2,'Game','PKO Game',400),(3,'Fashion','Shirt',500),(4,'Fashion','Shorts',100);
CREATE TABLE another_T (col1 INT, col2 INT, col3 INT, col4 INT, col5 INT, col6 INT, col7 INT, col8 INT);
INSERT INTO another_T VALUES (1,2,3,4,5,6,7,8), (11,22,33,44,55,66,77,88), (111,222,333,444,555,666,777,888), (1111,2222,3333,4444,5555,6666,7777,8888);

SELECT col1 IN (SELECT ColID + col1 FROM tbl_ProductSales) FROM another_T GROUP BY col1;
	-- False
	-- False
	-- False
	-- False

PS: I know these queries are very complex and barely anyone writes them. At the same time, I have a hard time figuring out Niels' code 🙁

Indeed a bug, I get
Assertion failed: (index != INVALID_INDEX), function VisitReplace, file ../../src/execution/column_binding_resolver.cpp, line 23.

Thanks for the bug report! If something is not working properly it will always eventually end up in a real query :) it's much better to catch it early in a small unit test. The bug seems to be related to the aggregation, basically the correlated column col1 is bound to the base table column col1 instead of to the group col1, which then fails to resolve the column during the column binding as the base table columns are not available after the grouping. Will look into fixing it now.

Interestingly this is not actually related to subqueries, but rather to GROUP BY binding. The subquery handling is fine. The following query experiences a crash as well:
CREATE TABLE another_T (col1 INT, col2 INT, col3 INT, col4 INT, col5 INT, col6 INT, col7 INT, col8 INT);
SELECT col1+1, col1+42 FROM another_T GROUP BY col1+1;

Going to take another look tomorrow when I have time.

Addressed in b077e6673ca2bf02dba2135f62790eedbe5a0a91, this was basically a combination of two problems:
(1) If a query had no aggregations but only groups, no error would be thrown if there were column references bound outside of the original grouping columns and the subsequent column resolution would fail.
(2) Binding to the group inside the subquery would not work because BindTableNames() was not called prior to performing the group lookup, leading to col1 being not equal to another_T.col1.
There was also an additional problem found relating to the BoundExpression that would make a composite grouping column not bind properly in subqueries, e.g. the following query would fail to bind:
SELECT (col1 + 1) IN (SELECT ColID + (col1 + 1) FROM tbl_ProductSales) FROM another_T GROUP BY (col1 + 1);

Note that this query actually also fails to bind in PostgreSQL, but SQLite correctly binds it. This I resolved by making the BoundExpression use the underlying ParsedExpression, so now this query also works correctly.
All in all three bugs found :) Thanks for the bug report! Let us know if you find any other issues.

This was really fast Mark!

This might be an old bug, for me I get the following error: Query failed with message: Parser: a GROUP BY clause is required before HAVING. Thanks for the report though! Let me know if you have more problematic subqueries.

I'm using the Debug build instead of RelWithDebInfo (i.e. default one). We have to check if the SQL standard allows this or not. I think it does, as I compiled it successfully on MonetDB and PostgreSQL. I know the only purpose of it is to either output the global aggregate value or an empty result set, which makes it not much useful.

I would think that SELECT 1 FROM tbl_ProductSales HAVING MIN(col8) IS NULL is not permissible on its own already?

SQLite does not allow a HAVING clause without a GROUP BY clause. I would also argue that there is not much of a point to allowing it. It only introduces potential errors for users. Testing it I did find this bug in MonetDB (although I am using an old version)
SELECT SUM(42) HAVING 42>80;
-- expected result: empty set
-- actual result: 42

Thanks Mark for the bug in MonetDB, I fixed it today. I tried the following little query on DuckDB:
select avg(rank() over ()) over();

and it crashed. MonetDB outputs a result, but it shouldn't as windowing functions cannot be nested. About the HAVING query I have to say DuckDB allows WHERE without FROM, which can correlate to HAVING without GROUP BY. Let's fix the bugs together :)

Doing this combination of queries, makes the second go forever.  Maybe because the query before didn't release the lock after throwing the error.  Please confirm if you can reproduce this.

Indeed, thanks for the bug reports! I will take a look next week as I'm still on holiday now and will be without my laptop for a few days. You have gotten very good at finding bugs and it's great to catch them early like this :) thanks for taking the time to add small testcases too!

I just fixed the nested window function one, but I cannot reproduce the second one. Did you run only the create table + inserts and those two queries, or where there other queries involved as well? Did you run them in the shell?
As for the having, indeed since other RDBMS engines allow it perhaps it's better we also allow it. I will take a look at fixing it and allowing a HAVING without a GROUP BY clause as well.

Yes. I switched to the RelWithDebInfo build. I started the shell, then created the two tables and ran the two queries combination shown above.

Ah I see, I tried it now on Linux and I get the same behavior, however it looks like it's related to the shell itself and not to the database. The shell doesn't properly handle deletion of the error because the statement is not properly initialized. I won't fix this for now, the shell in its entirety was written very early in DuckDB's lifecycle and in my opinion requires a rewrite anyway. The current version is more for easy testing of queries rather than being very stable/bug-free. Thanks for the report :)

HAVING without GROUP BY is now allowed #306.

@PedroTadim this issue can be closed now?

Here's the next one:
SELECT
	CASE WHEN 1 IN (SELECT (SELECT MAX(col7)) UNION ALL (SELECT MIN(ColID) FROM tbl_ProductSales INNER JOIN another_T t2 ON t2.col5 = t2.col1)) THEN 2 ELSE NULL END
FROM another_T t1;

Depending here the correlation happens, the output can be either a single NULL value or four. I got a Segmentation fault.

@PedroTadim do you have more? if so, please post all of them. This trickling method seems odd.

After this one, we can close it, and I take the remaining queries offline.

Thanks for the bug report again! Should be fixed in b0f46c3312b6fa10f16d4c64ecd301ba388884da, the plan_subquery and has_unplanned_subqueries were not properly being propagated through set operations which lead to nested correlated subqueries being prematurely planned which triggered an assertion (and which lead to a crash on release mode).
Maybe indeed it is better to take the queries offline, or post all the queries here. I realize the bugs might be "correlated" (hehe) but better to have a large batch of queries to test at once to verify they all work correctly :) also less work for you in having to recompile and verify again after every fix.

Closing this now


Think about to fix the issues found by adapter checker

I am an automatic service that looks for possible errors in ioBroker and creates an issue for it. The link below leads directly to the test:
https://adapter-check.iobroker.in/?q=https://raw.githubusercontent.com/DrozmotiX/ioBroker.multicast

[ ] [E150] No common.connectionType found in io-package.json
[ ] [E152] No common.dataSource found in io-package.json
[ ] [E154] common.dependencies must contain{"js-controller": ">=2.0.0"} or {"js-controller": ">=3.0.0"}
[ ] [E504] found setInterval in "main.js, but no clearInterval detected
[ ] [E603] NO "## Changelog" found in README.md
[ ] [E605] No actual year found in copyright. Please add "Copyright (c) 2022 DutchmanNL<EMAIL_ADDRESS>at the end of README.md
[ ] [E701] No actual year found in LICENSE. Please add "Copyright (c) 2022 DutchmanNL<EMAIL_ADDRESS>at the start of LICENSE
[ ] [E816] file tsconfig.json found in repository, but not found in .npmignore

Thanks,
your automatic adapter checker.
P.S.: There is a community in Github, which supports the maintenance and further development of adapters. There you will find many experienced developers who are always ready to assist anyone. New developers are always welcome there. For more informations visit: https://github.com/iobroker-community-adapters/info

Thanks, that all bugs have been fixed.


Exception: Invariant Violation: Objects are not valid as a React child (found: object with keys {key, text}). If you meant to render a collection of children, use an array instead.

Hey @JesusDiazDiaz happy to look into your problem but can you please provide some example code? Thanks

From example
import React from 'react';
import {Text, View} from 'react-native';
import {SwipeListView} from 'react-native-swipe-list-view'

const mock = new Array(30).fill(true).map((item, index) => {
  return {
    key: index,
    item: 'kek',
  }
});

const HistoryList = () => (
  <SwipeListView
    data={mock}
    renderItem={ (data, rowMap) => (
      <View>
        <Text>I am {data.item} in a SwipeListView</Text>
      </View>
    )}
    renderHiddenItem={ (data, rowMap) => (
      <View>
        <Text>Left</Text>
        <Text>Right</Text>
      </View>
    )}
    leftOpenValue={75}
    rightOpenValue={-75}
  />
);

export {HistoryList};```

"react": "16.8.6",
"react-native": "0.60.5",
"react-native-swipe-list-view": "^2.0.1"

react-cli

Hey @kldkv change
<Text>I am {data.item} in a SwipeListView</Text>

to
<Text>I am {data.item.item} in a SwipeListView</Text>

And you'll be good to go

@jemise111 just FYI, the reason this happened is because this from the example code in the README.  I had the same problem because I just copy/pasted it from there.


The problem with too many queries

First, thank you for your submission. While reviewing your code, I just saw some points for improvements. Therefore, I wanted to open an issue for the project.
The getWholeTree method of the GroupService queries the groups. Then, it iterates all the groups with a for loop. For each group, it runs another query to retrieve group data. Moreover, for each vehicle under each group, another query is run. Let's say we have N groups, each with M vehicles on average. Then you need to run 1 + N * (1 + M) queries. This amount of separate queries would result in performance problems with large N and M values.
How can you improve the performance of this method (and the others with a similar case)?

In old code, First I was getting all Groups(1 query), Then for each group and for each vehicle in that group, I was getting Vehicle by Id from database.(If there are N groups each with M vehicles, this means N*M query). But now, I am just getting all Groups(1 query) and all Vehicles(1 query), after this, I am doing other operations. This means 2 queries for getWholeTree() function. I can't test with large data but it must be faster now. (related commit -> 26f2178812cf17b16eb25f72e7e6394f17315216)


Pull access denied for openlane

While trying to setup openlane, i got the following error message:
Unable to find image 'openlane:rc6' locally
docker: Error response from daemon: pull access denied for openlane, repository does not exist or may require 'docker login': denied: requested access to the resource is denied.

My machine is running Ubuntu 18.04.
I change the IMAGE_NAME ?= openlane:rc6 (line 21) in the make file to IMAGE_NAME ?= efabless/openlane, which solved the issue apparently.
Magic DRC Summary:
Source: /openLANE_flow/designs/spm/runs/openlane_test/logs/magic/magic.drc
Total Magic DRC violations is 0
----------------------------------------

LVS Summary:
Source: /openLANE_flow/designs/spm/runs/openlane_test/results/lvs/spm.lvs_parsed.log
LVS reports no net, device, pin, or property mismatches.
Total errors = 0
----------------------------------------

Antenna Summary:
Source: /openLANE_flow/designs/spm/runs/openlane_test/reports/routing/antenna.rpt
Number of pins violated: 0
Number of nets violated: 0
[SUCCESS]: Flow Completed Without Fatal Errors.
Basic test passed

I only got two warning messages,
[WARNING]: Current core area is too small for a power grid
[WARNING]: Minimizing the power grid!!!!

@ammar89: It's not very clear what the issue is here. You used dockerhub to pull the openlane docker instead of building it locally (as per the instructions), then you had to export IMAGE_NAME to the new name which is efabless/openlane:rc6 instead of the locally built image name openlane:rc6 (as the instructions in the README say). By doing so as per the instrcutions, you were able to run the docker image successfully and get a clean run out of openlane. So, where is the issue or where is the question?
As for the 2 warnings, they are just to tell you that the flow will auto adjust the power grid to allow it to fit inside the design's small core area. Nothing to worry about.
README instructions on dockerhub usage:
https://github.com/efabless/openlane#pulling-an-auto-built-docker-image-from-dockerhub
https://github.com/efabless/openlane#running-the-pulled-auto-built-docker-image

I also can't get make test to work:
(base) robtaylor@Roberts-MacBook openlane % make test
cd /Users/robtaylor/Code/Chipflow/openlane &&
docker run -it -v /Users/robtaylor/Code/Chipflow/openlane:/openLANE_flow -v /Users/robtaylor/Code/Chipflow/:/Users/robtaylor/Code/Chipflow/ -e PDK_ROOT=/Users/robtaylor/Code/Chipflow/ -u 501:20 openlane:rc7 sh -c "./flow.tcl -design spm -tag openlane_test -disable_output -overwrite"
Unable to find image 'openlane:rc7' locally
docker: Error response from daemon: pull access denied for openlane, repository does not exist or may require 'docker login': denied: requested access to the resource is denied.
I've followed the README to the letter.

@robtaylor: Your case is different. When you rebased to develop to submit PR #133 you switched to openlane:rc7 (current develop), while before rebasing you were in master (openlane:rc6). So, you'll have to rerun make after rebasing. (or switch back to master in a different branch of your fork). Did I get that right?

Thanks agorararmard, it was a mistake from my end, I built openlane locally and it is working fine. I apologize for the inconvenience.


File picker for ONLYOFFICE

The main idea:
Allow the user to:

Open a new file without leaving the editor.

Create a new file without leaving the editor.

Flow:

Add “Open” and “Create” buttons to the File menu of OO to open the file selection dialog.

The buttons will appear in the OO interface when the flags OpenDocumentPostMessage and CreateFilePostMessage are enabled, similar to other XXX-PostMessage flags.

When the button is clicked, ONLYOFFICE will send a PostMessage: UI_OpenDocument and UI_CreateFile. (not based on the WOPI standard, but rather on an extension of Collabora's format.

OC will handle these messages, display the file selection dialog, and open the file in a new tab.

@tbsbdr @AlexAndBear
IMHO this is solved in a different way.

In the ownCloud Web TopBar, click on the "Three Dots"
Select "Open"
Browse via the FilePicker
Click on selected file to open it in a new tab

Screenshots

@dj4oC From our POV, this requirement is already fulfilled and needs no "custom" integration inside the OnlyOffice UI.

Was just working on the same and came to a similar clue.
Can we add/enable a "new" button to the embedded web view? Then everything would be fine.

@micbar any progress on this item?

@tbsbdr @kulmann is that on your radar?

Open a new file without leaving the editor.

✅ fulfilled via 3-dots menu -> open

Create a new file without leaving the editor.

@AlexAndBear can we add the New button? I think it makes sense to have it.

@tbsbdr Technically yes, but since this action is inside the iframe, we need to discuss what should happen when the file is created.

I'd say, when a file was created, it should just sit there (no auto-open) if feasible
restricting to filetypes: i guess the user value is low, it could even be negative. I'd try to implement Nr 1 and see how it feels and if users complain about too many filetype options.

We need to check, but this can be an new ticket for the new sprint 👍


wlroots: backport patch for free() of ununitialized

Description of changes
This cherrypicks an upstream-but-unreleased commit for the following build failure.  Strangely, this warning is not emittted on x86_64.
FAILED: libwlroots.so.11.p/render_egl.c.o
gcc -Ilibwlroots.so.11.p -I. -I.. -Iinclude -I../include -Iprotocol -I../protocol -Irender/gles2/shaders -Irender/vulkan/shade
../render/egl.c: In function 'egl_init_display':
../render/egl.c:179:17: error: 'external_only' may be used uninitialized in this function [-Werror=maybe-uninitialized]
  179 |                 free(external_only);
      |                 ^~~~~~~~~~~~~~~~~~~
../render/egl.c:128:29: note: 'external_only' was declared here
  128 |                 EGLBoolean *external_only;
      |                             ^~~~~~~~~~~~~
../render/egl.c:178:17: error: 'modifiers' may be used uninitialized in this function [-Werror=maybe-uninitialized]
  178 |                 free(modifiers);
      |                 ^~~~~~~~~~~~~~~
../render/egl.c:127:27: note: 'modifiers' was declared here
  127 |                 uint64_t *modifiers;
      |                           ^~~~~~~~~
cc1: all warnings being treated as errors

Things done

Built on platform(s)

[x] x86_64-linux
[x] powerpc64le-linux

[x] Fits CONTRIBUTING.md.

@ofborg eval

Is it a powerpc64le-linux-specific issue? Not seeing this on Hydra on aarch64-linux and x86_64-linux.

Is it a powerpc64le-linux-specific issue? Not seeing this on Hydra on aarch64-linux and x86_64-linux.

If you take a look at the code they are very obviously using an uninitialized variable.  And they admit so and fix it in the patch that is backported here.
The only mystery is why gcc doesn't produce a warning on x86_64 or aarch64.  It should.

The patch does not apply for me:
$ # github:NixOS/nixpkgs is at 089fa2e1131765839c058c8cdd08b28d2e693995
$ nix build -L 'github:NixOS/nixpkgs/089fa2e1131765839c058c8cdd08b28d2e693995#wlroots_0_16'
wlroots> unpacking sources
wlroots> unpacking source archive /nix/store/kpbd31jbph0bkmax8qiga9lfi452vqa1-source
wlroots> source root is source
wlroots> patching sources
wlroots> applying patch /nix/store/rpmkvanwa0shk55rdaf0k1w1750s0fbl-ed71915742160f2b9157adbad79364e22ab7ebda.patch
wlroots> patching file render/egl.c
wlroots> Reversed (or previously applied) patch detected!  Assume -R? [n]
wlroots> Apply anyway? [n]
wlroots> Skipping patch.
wlroots> 1 out of 1 hunk ignored -- saving rejects to file render/egl.c.rej
error: builder for '/nix/store/qw7jqma6yw5kkbghl6fxa4zcfvklyxv3-wlroots-0.16.1.drv' failed with exit code 1;

@B4dM4n Sorry for the inconvenience! Reverted.
@amjoseph-nixpkgs It looks like wlroots points to wlroots_0_15, so ofborg didn't catch the error. Could you please check if the patch has already been applied?


grid connection status for sunsynk power flow card

wattsonic.yaml:
template:
binary_sensor:
- name: "wattsonic_grid_connected"
state: >
{% set w1 = states('sensor.wattsonic_inverter_running_status') %}
{% if w1 == '2' %} 1
{% else %} 0
{% endif %}
sunsynk.yaml line 44:
grid_connected_status_194: binary_sensor.wattsonic_grid_connected

thank you!, updated sources


storage: implement the row value checksum encode logic in tikv side

What is changed and how it works?

Issue Number: Ref #14528
What's Changed:
Implement the checksum row value encode logic on the tikv side, mainly used for test cases in tikv.
In the previous design, there was no anticipation of introducing development work related to compatibility. However, testing coverage is still required, especially to verify if row values containing checksum parts can be processed by the decoder with lower versions.
Related to https://github.com/pingcap/tidb/pull/42859
Related changes
Check List
Tests

Unit test

Side effects
Release note
None

/merge


How to configure the nextcloud openid back end connect IDP?

How to configure the nextcloud openid back end connect IDP?

idp-config.json
Does "externalUrl" refer to the server address of the NEXTCLOUD?

Could give me a configuration example?
how to configure the nextcloud openid back end connect IDP

In idp-config.json, you don't configure anything related to NEXTCLOUD.
The IDPKit has no awareness of nextcloud.
I'm not familiar with nextcloud, but I do assume the configuration will be similar to other applications:

Create a client_id and client_secret (Client registration)
configure the endpoints of the idpkit on nextcloud
enter client_id and client_secret and choose authentication method client_secret_basic

idp-config.json Does "externalUrl" refer to the server address of the NEXTCLOUD?

No, it refers to the URL by which the IDP Kit is available to external clients.


Scene/Prefab-based graphs

I want to be able to create graphs that are then saved as part of a scene or prefab. With BaseGraph inheriting ScriptableObject, that makes it difficult. ScriptableObjects can be saved as part of a scene, but not as part of a prefab.
Maybe BaseGraph can be redefined as a serializable class which then is serialized by ScriptableObject and MonoBehaviour wrappers with SerializeReference?

+1 👍🏾 @PeturDarriPeturs
I have the same requirement in my project. I would like the similar feature like this another package: xNode/Scene-Graphs.
I tought that the script Examples/GraphBehaviour.cs will keep gameObjects and prefabs references, but the method BaseGraph.LinkToScene(scene) just automate the scene close when the graph window is closed 😢


Add Steps component to sitecore.mdx

Add Steps component to sitecore.mdx
Adds the Step component where needed.

Lunaria Status Overview
🌕 This pull request will trigger status changes.

Learn more
By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.
You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale
File
Note

en
guides/cms/sitecore.mdx
Source changed, localizations will be marked as outdated.

Warnings reference

Icon
Description

🔄
The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

!coauthor


Update HLint workflow

We get a warning that GitHub forces node 20 on us. Why not just update?

Thanks!


fix variable redeclared in error

Decleration is shadowing the variable. The intention is to reuse the variable from outside the loop.

I'll look into the while condition but I'm merging this as clearly the shadowing is not intentional.


wl_listener is defined as an opaque pointer

From what I have seen of most examples in C, when constructing a wl_listener to listen for signals a struct is created that has a pointer to wl_notify_func (which you define) in the .notify field.
However, in the wayland-sys crate in server.rs, it's defined as a opaque pointer which means it can't be constructed by this library directly. Is this a bug?
Here is the common definition I'm finding in the header files: https://people.freedesktop.org/~whot/wayland-doxygen/wayland/Server/structwl__listener.html

This is likely an oversight, as this struct is not directly used by wayland-client or wayland-server...

Actually, do you only need wl_listener, or do you plan to use the whole wl_signal machinery?
I've tried to give a go and expose the wil_signal_init/wl_signal_get/ etc.. functions, but unfortunately these are defined in the headers of the C libs, and designed to be inlined, as such, they are not exposed in the symbols of the C library. Which means we'd need to re-implement them in rust.
Now, some of them (wl_signal_get and wl_signal_emit) are built in C using the wl_list_for_each macro, itself built using the wl_container_of macro. But I don't see how we can implement this wl_container_of macro in rust in a way that does not invoke UB. It uses offsetof, which we do not have in rust, and I don't see how we can implement it.

I have actually somewhat re implemented those types in my library that uses wayland-rs, so it would be nice to have these here upstream.
In regards to wl_container_of, I have a very unsafe implementation that never the less works. It would only work on #[repr(C)]   structs, due to the reordering optimization from the Rust compiler. I don't think these are possible to make safe in a general sense (unless you can guarantee the data passed to the macro is  #[repr(C)], which I don't think you can), but it would be nice if those unsafe primitives were still exposed.

I believe this can be closed now. Please open a new issue if you encounter any problem with the implementation. :)


Use canonical import paths instead of forked repo name

The code referes to canonical import paths, so the code needs to be
available there even if CircleCI is building from a forked repository.
Otherwise the tests fail, e.g. https://circleci.com/gh/mtrmac/notary/3 vs. https://circleci.com/gh/mtrmac/notary/4 .

:+1:

LGTM


I want to deploy it to a web application, I follow the docs, but failed.

Hi, I am new here, these days I try to deploy ohif viewers into a web application ,  but it's hard to do it when I follow the docs.
Description
It seem that the docs is a little old.The docs tell me to download the react branch, but I can't find the react branch. And the docs tell me to input yarn run build:web, but this version don't have this command.
I try to use the master branch , go to platform/viewers and input build:viewer ,and I copy the dist folder into a tomcat's webapps.But it doesn't work. I can't see the ohif viewer on the browser.I really have no idea about how to deploy the application.
in short,I have 3 questions:

which branch is suit for deploy.
which command I shoule type if I want to deploy it.
If tomcat could deploy the application?If not, what can?

Thank you for reading here. I will appreciate it if you can give me some advise.

@LRQLRQ, we've had a few major releases, and one large restructuring since those docs were written. Unfortunately, the items most impacted were those related to file locations and npm scripts. You can read more about how/where things now live here:
https://github.com/OHIF/Viewers/issues/768
More than happy to accept even very small behaviors to clean up what is now incorrect. After we have all of our CI updated, and IE + Edge functionality working as expected, rectifying docs are the next highest priority.

which branch is suit for deploy.

master

which command I shoule type if I want to deploy it.

It depends on your use case, but most likely yarn run build from the repository root to generate the static assets you should deploy.

If tomcat could deploy the application?If not, what can?

Any web server capable of serving up static assets will suffice.

which branch is suit for deploy.

master

which command I shoule type if I want to deploy it.

It depends on your use case, but most likely yarn run build from the repository root to generate the static assets you should deploy.

If tomcat could deploy the application?If not, what can?

Any web server capable of serving up static assets will suffice.

Thank you very very much!! I will have a try!

@LRQLRQ any updates?

@dannyrb Thank you for still remember me! I was touched by you.
I am a little busy these days, just did little updates about viewers. Here are my new questions I met:

I tried to follow what you said, but the console shows these errors. I think I probabely ignored some important config files.

I want to build the Nginx + Image + Archive and User Account Control  which on the docs, and I learned docker to build it, but I meet some problems, I looked for the solution in these issues, and I
found my problems are the seem to #785 .

My chores have been dealt with, and I will study the documentation and how to deploy the application in the near future.
My English is a little poor ,but I really appreciate that! Thanks again!

@LRQLRQ, it does look like default.js is missing. In the latest version, master, this would be app-config.js. It should be produced when you run yarn run build from the repository root, alongside the rest of the progressive web application's static assets.
yarn run build --> <repo-root>/platform/viewer/dist/**/*
You can see how the Dockerfile in the root of this repository builds that output, and then uses it in an nginx image:
https://github.com/OHIF/Viewers/blob/master/Dockerfile#L60

I think my problem relates to this. I have a Tomcat folder called ohif where i want to deploy platform/viewer/dist content. However, OHIF is not able to find its static files. Here is a screenshot of what happens:

Tomcat runs at http://<IP_ADDRESS>:17545 and i want to serve OHIF at http://<IP_ADDRESS>:17545/ohif
I am trying to connect OHIF with an Orthanc instance behind a NGINX reverse proxy.

@Diegovictorbr, can you ask this question in a new issue? This one is closed and older. We tend to not revisit these for new questions.


Log out tree

Hi @Yomguithereal ,
It seems that when you log out the tree monkeys are exposed as "getters". That is a bit troublesome when debugging.
Maybe there should be a way to get the tree with the values of the monkeys? So basically three scenarios here:

tree.get() just like it works now. Got the exposed "getters" for monkeys. Used in components etc.
JSON.stringify(tree) just like it works now. The tree without monkey values
tree.something(). The tree as a JSON like object with monkey values (no "getters")

The reason for point 3 is that Chrome does no let you debug "getters". They are just functions, can not look at the value they return :-/
Personally I think explicit methods would be valuable here as it gets a bit complex with these three scenarios.

tree.get() = Normal version of tree, to grab values. Monkeys are "getters"
tree.export() = Get tree without monkeys
JSON.stringify(tree) = Get string version of tree with the values of the monkeys
tree.import(someState) = Will let you import some object

That way Cerebral could JSON.parse(JSON.stringify(tree)) to get a clean representation of the tree. That would be nice :)

Let me check that :). Chrome lets you see the getter's return if you click on the ellipsis if I record correctly though.

Any update about this @christianalfoni.

We made a fix on this in Cerebral, where we serialize/parse the data before sending it to the debugger. That said, I am not sure if monkeys still appear when logging. I see @guria states that on gitter channel, though I am not sure which version he is referring to. I would say we can close this and set up a new issue if it still occurs

chrome console doesn't allow to expand objects returned by getters aka monkeys. Is there a way to log whole tree which will contain pre computed monkey values instead of getters?

Thanks @Guria. I am thinking of adding an option (for dev only, not prod) that would let the monkey write data not in a lazy fashion for convenience.

Great, thanks

Following up on #354.


What does it mean: Function cannot be called on any member of intersection type intersection?

What is the problem?
        const event = new CustomEvent('custom:event', {
            detail: { data: 'lalala' },
            bubbles: true,
            cancelable: true,
        });
        document.dispatchEvent(event);
        ...
        function handleMyEvent(event: CustomEvent) {
                const { data } = event.detail;
                .....
        };
        ...
        document.addEventListener('history:changed', handleMyEvent);
        ^^^^^Error: call of method `addEventListener`. Function cannot be called on any member of intersection type intersection

I suspect that it's due to incorrect addEventListener params type definition without custom name ...

The full error message should have a lot more information than you've posted here. Based on the definition of addEventListener in dom.js, it looks like you're hitting this override, which expects a function with a Event argument, instead of CustomEvent.

Flow doesn't match event name with theirs definition file from ../AppData/Local/Temp/flow/flow.../dom.js