Fix undeclared type name errors when targeting android aarch64.

Resolves use of undeclared type name errors for sighandler_t and sigset_t when compiling for aarch64-linux-android.

Thanks @romanb! I'm trying out this new "gate master on checks passing" thing GitHub has, and apparently that means that you can only merge one PR at a time! If you rebase this CI looks like it'll pass and I'll merge.
As a side note, do you know if there's a way to run binaries for aarch64-linux-android? I'd love to set up automation here to ensure it keeps building and it's correct.

As a side note, do you know if there's a way to run binaries for aarch64-linux-android? I'd love to set up automation here to ensure it keeps building and it's correct.

That would indeed be great but I've only recently started experimenting with cross-compiling for aarch64-linux-android and haven't actually used or tested the resulting binaries yet, so I don't know of a good way for automated testing yet. I only happened to run into these compile errors when upgrading libc for the Android library I'm building.

Ah ok, well if something ends up working out just let me know!


EUSAGE thrown if service container built without submodules

Trying to build service image for current master without submodules initialised (302b58237ac0b0c8d8c5aa49c682b919052f0aad) throws an error:
$ docker compose build service
WARN[0000] The "DOMAIN" variable is not set. Defaulting to a blank string.
WARN[0000] The "DOMAIN" variable is not set. Defaulting to a blank string.
WARN[0000] The "SYSADMIN_EMAIL" variable is not set. Defaulting to a blank string.
WARN[0000] The "DOMAIN" variable is not set. Defaulting to a blank string.
WARN[0000] The "DOMAIN" variable is not set. Defaulting to a blank string.
WARN[0000] The "SYSADMIN_EMAIL" variable is not set. Defaulting to a blank string.
WARN[0000] The "DOMAIN" variable is not set. Defaulting to a blank string.
WARN[0000] The "SYSADMIN_EMAIL" variable is not set. Defaulting to a blank string.
[+] Building 3.1s (17/24)
 => [internal] load build definition from service.dockerfile                                                                                0.1s
 => => transferring dockerfile: 1.25kB                                                                                0.0s
 => [internal] load .dockerignore                                                                                0.2s
 => => transferring context: 67B                                                                                0.0s
 => [internal] load metadata for docker.io/library/node:16.19.1                                                                              0.8s
 => [internal] load build context                                                                                0.1s
 => => transferring context: 4.94kB                                                                                0.0s
 => [intermediate 1/8] FROM docker.io/library/node:16.19.1@sha256:e97b6d302062583e09be70f430b703637f6ef26c2cbb0d7bfed61e0be9d7a974           0.0s
 => CACHED [stage-1  2/13] WORKDIR /usr/odk                                                                                0.0s
 => CACHED [stage-1  3/13] RUN echo "deb http://apt.postgresql.org/pub/repos/apt/ $(grep -oP 'VERSION_CODENAME=\K\w+' /etc/os-release)-pgdg  0.0s
 => CACHED [stage-1  4/13] COPY files/service/crontab /etc/cron.d/odk                                                                        0.0s
 => CACHED [stage-1  5/13] COPY server/package*.json ./                                                                                0.0s
 => CACHED [intermediate 2/8] COPY . .                                                                                0.0s
 => CACHED [intermediate 3/8] RUN mkdir /tmp/sentry-versions                                                                                0.0s
 => CACHED [intermediate 4/8] RUN git describe --tags --dirty > /tmp/sentry-versions/central                                                 0.0s
 => CACHED [intermediate 5/8] WORKDIR server                                                                                0.0s
 => CACHED [intermediate 6/8] RUN git describe --tags --dirty > /tmp/sentry-versions/server                                                  0.0s
 => CACHED [intermediate 7/8] WORKDIR ../client                                                                                0.0s
 => CACHED [intermediate 8/8] RUN git describe --tags --dirty > /tmp/sentry-versions/client                                                  0.0s
 => ERROR [stage-1  6/13] RUN npm clean-install --omit=dev --legacy-peer-deps --no-audit --fund=false --update-notifier=false                1.9s
------
 > [stage-1  6/13] RUN npm clean-install --omit=dev --legacy-peer-deps --no-audit --fund=false --update-notifier=false:
#0 1.743 npm ERR! code EUSAGE
#0 1.751 npm ERR!
#0 1.752 npm ERR! The `npm ci` command can only install with an existing package-lock.json or
#0 1.752 npm ERR! npm-shrinkwrap.json with lockfileVersion >= 1. Run an install with npm@5 or
#0 1.752 npm ERR! later to generate a package-lock.json file, then try again.
#0 1.752 npm ERR!
#0 1.753 npm ERR! Clean install a project
#0 1.753 npm ERR!
#0 1.753 npm ERR! Usage:
#0 1.753 npm ERR! npm ci
#0 1.753 npm ERR!
#0 1.753 npm ERR! Options:
#0 1.754 npm ERR! [-S|--save|--no-save|--save-prod|--save-dev|--save-optional|--save-peer|--save-bundle]
#0 1.754 npm ERR! [-E|--save-exact] [-g|--global] [--global-style] [--legacy-bundling]
#0 1.754 npm ERR! [--omit <dev|optional|peer> [--omit <dev|optional|peer> ...]]
#0 1.754 npm ERR! [--strict-peer-deps] [--no-package-lock] [--foreground-scripts]
#0 1.754 npm ERR! [--ignore-scripts] [--no-audit] [--no-bin-links] [--no-fund] [--dry-run]
#0 1.754 npm ERR! [-w|--workspace <workspace-name> [-w|--workspace <workspace-name> ...]]
#0 1.754 npm ERR! [-ws|--workspaces] [--include-workspace-root] [--install-links]
#0 1.754 npm ERR!
#0 1.755 npm ERR! aliases: clean-install, ic, install-clean, isntall-clean
#0 1.755 npm ERR!
#0 1.755 npm ERR! Run "npm help ci" for more info
#0 1.758
#0 1.759 npm ERR! A complete log of this run can be found in:
#0 1.759 npm ERR!     /root/.npm/_logs/2023-04-26T08_17_19_508Z-debug-0.log
------
failed to solve: process "/bin/sh -c npm clean-install --omit=dev --legacy-peer-deps --no-audit --fund=false --update-notifier=false" did not complete successfully: exit code: 1

Running git submodule update -i allows docker compose build service to complete successfully.
Would it be helpful/appropriate to document this, or is it better to keep the README of this repo more end-user-focussed?

We mention in the user docs the need to run git submodule update -i before docker compose build. The readme links to those docs. Do you think that provides enough information?
I think it'd be nice to keep the readme pretty light. That said, while we have contribution guides for Backend and Frontend, we don't for this repo. If there are things that would be helpful for us to document for developers, we could think about creating a contribution guide here as well.

If there are things that would be helpful for us to document for developers, we could think about creating a contribution guide here as well.

:+1: For now, I'm just happy to have it logged here so it will come up in searches.


[Bug]: error: eufy-security.0 (1270) Response code not ok [{"code":26006,"msg":"Email address or password incorrect."}]

Adapter version
0.7.5
JS-Controller version
3.3.22
Node version
14.18.3
Operating System type
Linux
Operating system version
11
Describe the bug
I followed all the rules in the manual about configuration and authentication. I first tried with my existing account, then created a second Eufy account and I still receive the same message:
error: eufy-security.0 (1270) Response code not ok [{"code":26006,"msg":"Email address or password incorrect."}]
error: eufy-security.0 (1270) Token error
Can anyone please help?
To reproduce

Go to 'Setup of Eufy instance'
Click on 'username/password, type in correct login data'
Scroll down to 'log'
See error : eufy-security.0 (1270) Response code not ok [{"code":26006,"msg":"Email address or password incorrect."}]
error: eufy-security.0 (1270) Token error

Screenshots & Logfiles
No response
Additional context
No response

Use latest version (0.8.2).


Add more precise overloads for agg

DataFrame.agg and Series.agg have multiple possible return types
per https://pandas.pydata.org/docs/reference/api/pandas.DataFrame.agg.html#pandas.DataFrame.agg
and https://pandas.pydata.org/docs/reference/api/pandas.Series.agg.html#pandas.Series.agg;
note that the possible return types are different between DataFrame.agg and Series.agg,
and also depend on the type of the func input argument.
Add more precise overloads for the cases that mypy can statically handle:

multiple aggregation functions
(either a list/dict, OR if func=None where the funcs are specified via kwargs)
the str and Callable cases for a single aggregation function

numpy may not be in the mypy venv,
in which case numpy functions would be seen as Any
and thus can't be used for @overload type dispatching in mypy,
so don't be precise in the case of a numpy function.
When mypy sees it as Any, trying to be precise would cause errors like
Overloaded function signatures 1 and 2 overlap with incompatible return types.
Additionally, avoid Scalar as a return type even when it would be correct.
Scalar is a large Union that produces many (currently 13) lines of dense error output
when there is a type mismatch;
given users would almost always have to cast in this case,
use Any instead and avoid providing a type hint in this case.
The docs recommend using the .agg alias for .aggregate,
so don't provide overloads for the latter to nudge folks towards the former.
Add test cases (from the docs) for lists and dicts of aggregation functions.

One thing I wasn't sure about was if Series.agg should accept a Dict for func - I tried one or two ways locally but couldn't find a way that works. I'm new to pandas so would love advice on what to do!

Thanks for the feedback. About to head on vacation but will try to update this PR when I get back.

Closing this PR as pandas-stubs has moved to another repository and will now be managed alongside pandas itself: https://github.com/pandas-dev/pandas-stubs
Feel free to re-opening there if you find it appropriate.


error on using oidc-client.js in angular2 app

Hi Broke!
I'm really stuck in this error, I've already tried to search a solution...but nothing...the project where I'm in use systemjs for module loading and typescript, I don't know if you could need specific clues about this error, please let me know :( :( :(

If you're using angular2 then you are using a module loader. You want to use the "~/lib" version of oidc-client, not the "~/dist" version.

thank you so much Brock! I've already tried to do what you say!  but it show me another error :(

You will have to debug into it further -- I don't use Angular2 so I'm not familiar with how they set things up.

@MattiaMalandrone as far as I know, angular 2 uses the webpack module loader inside the cli. I don't think you need to configure much. In the file you need the oidc-client you should be able to just put import oidc from "oidc-client" and it should work. (https://coryrylan.com/blog/angular-2-cli-adding-third-party-libraries)

@brockallen Thank you, I'll try to figure out the cause, thx!
@kristofdegrave thank you so much! I will let you know!

Hard to tell without seeing your code. But did you inject your AuthService as a provider somewhere? For example I have:
// app.routes.ts
import { Routes, RouterModule }  from '@angular/router';
import { AuthGuard } from  './shared/services/ipreoaccount-authguard.service';
import { AuthService } from  './shared/services/ipreoaccount-auth.service';

const routes: Routes = [
  { path: '', loadChildren: './dashboard/dashboard.module#DashboardModule' }
];

export const appRouterProviders = [
  AuthGuard,
  AuthService
];

export const routing = RouterModule.forRoot(routes);

Then I add appRouterProviders into the top app NgModule providers
//app.module.ts
import { NgModule }      from '@angular/core';
import { BrowserModule } from '@angular/platform-browser';
import { HttpModule } from '@angular/http';
import { routing, appRouterProviders } from './app.routes';

@NgModule({
    imports: [
        BrowserModule,
        routing,
        HttpModule
    ],
    declarations: [//deleted for simplicity
    ],
    bootstrap: [//deleted for simplicity
    ],
    providers: [
        appRouterProviders
    ]
})

export class AppModule {}


conhost.exe crashes when inserting emoji

Steps to repro:

Open cmd.exe or Powershel.exe
Press Win+. in order to open the Emoji Picker overlay
Click on any emoji, multiple times, until the console crashes

Duplicate of #678

I actually need to un-dupe this. I have a solution to the conhost emoji-picker part, but not the terminal hang part.
Reactivating this so I can fix it (along with the internal crash bug MSFT: 20990158 that has been reported)


Error when mapper changes number of outputbuffers

mapper a(i,a,b) {
a;a;b;b
}

Does not work. It produces the output a,a
  test/CodeSpec.hs:73:7:
  1) Code, Lib.convert (integration tests), computes in the right value when there is a reduction in buffers in the mapper
       expected: Just [[1,1,1]]
        but got: Just [[1,1,1],[0,0,0],[0,0,0],[0,0,0]]

  To rerun use: --match "/Code/Lib.convert (integration tests)/computes in the right value when there is a reduction in buffers in the mapper/"

  test/CodeSpec.hs:76:7:
  2) Code, Lib.convert (integration tests), computes in the right value when not all buffers are mapped
       expected: Just [[1,1,1],[1,1,1],[1,1,1],[1,1,1],[1,1,1],[1,1,1]]
        but got: Just [[1,1,1],[1,1,1],[1,1,1],[1,1,1]]

Has been resolved by a complete rewrite


Sorted menus, sort alphabetically

It would be nice, if you could add an option to the sorted menu mod to sort the lists by name. (Rather than armor)

Also an option to sort by DMG (Sum) would be nice.

sorting by name should already be the case. are you sure the config is setup to sort the crafting menu you are looking at? the mod might also not work correctly for the current version, but I'm about to test that. the mod should also work with any language, even if you don't get the benefit of the custom override files by default (but you can easily create them for german. I'm german, but I play in english, so I only wrote custom sort overrides for english).
I'm not interested in adding sort by damage, but thanks for the suggestion.

mod is updated and working correctly for current version. if this issue still persists, please reopen the issue


tf: cleanup old usages of template

Please provide a description of this PR:

@howardjohn: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-security-multicluster_istio
b10f483af8982ad030a93e73ab474d8470d04ae7
link
true
/test integ-security-multicluster

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-security-multicluster_istio
b10f483af8982ad030a93e73ab474d8470d04ae7
link
true
/test integ-security-multicluster

integ-security-istiodremote_istio
b10f483af8982ad030a93e73ab474d8470d04ae7
link
true
/test integ-security-istiodremote

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-security-multicluster_istio
b10f483af8982ad030a93e73ab474d8470d04ae7
link
true
/test integ-security-multicluster

integ-security-istiodremote_istio
b10f483af8982ad030a93e73ab474d8470d04ae7
link
true
/test integ-security-istiodremote

integ-security_istio
b10f483af8982ad030a93e73ab474d8470d04ae7
link
true
/test integ-security

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-security-multicluster_istio
fca7d0465499ce80f1b7b3ee9f04ae989763b6e3
link
true
/test integ-security-multicluster

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest


Implement semantic role attribute

The role attribute allows to have semantic markup but with greater expressiveness. For example a button can be marked with role="link" in case we want to show a link but need a form to make a POST request. Also, the role="none" or role="presentation"  can be used to remove the semantic meaning of an element.
See :

https://w3c.github.io/using-aria/
https://www.w3.org/TR/wai-aria/#roles_categorization

Yes, it's true that it could be used (and should be for accessibility), but I'm not sure we want to tie styling to those attributes since it expands the numbers of things a UI designer would have to remember to get an MVP shipped.


[release/v2.3] Add ability to set MTU for CNI

Backport of https://github.com/rancher/types/pull/1050
https://github.com/rancher/rancher/issues/24096

LGTM


Cannot infer shapes or values for node "Resize_164"

Hello，
I've met a problem when converting onnx model to openvino IR, errors are like this
Model Optimizer version: 	2019.3.0-375-g332562022 [ ERROR ]  Cannot infer shapes or values for node "Resize_164". [ ERROR ]  There is no registered "infer" function for node "Resize_164" with op = "Resize". Please implement this function in the extensions.   For more information please refer to Model Optimizer FAQ (https://docs.openvinotoolkit.org/latest/_docs_MO_DG_prepare_model_Model_Optimizer_FAQ.html), question #37.  [ ERROR ]   [ ERROR ]  It can happen due to bug in custom shape infer function <UNKNOWN>. [ ERROR ]  Or because the node inputs have incorrect values/shapes. [ ERROR ]  Or because input shapes are incorrect (embedded to the model or passed via --input_shape). [ ERROR ]  Run Model Optimizer with --log_level=DEBUG for more information. [ ERROR ]  There is no registered "infer" function for node "Resize_164" with op = "Resize". Please implement this function in the extensions.
My openvino version is 2019 and my os system is linux.
My commands are like this
python /opt/intel/openvino/deployment_tools/model_optimizer/mo.py \ --input_model yolox.onnx \ --data_type FP16
Could you help me with this problem? Thanks a lot!

Seems you have to update to the newest openvino version.

Seems you have to update to the newest openvino version.

Seems no other better solutions, thanks~


Feature add player

This is the first version of the player, I know this is a pretty much BIG amount of code to review, just wanted to share the changes here for the record so everybody can check what work has been done.
The video player will have as a result 2 binary objects.

One is the player.resources.bundle file, that contains the view configuration and view resources as button images, etc.
The second one is the library itself  in format player.a

From this starting point we can improve the release process to any release channel
The requirements for this are AVFoundation.framework (since it uses the very basic AVPlayer, AVPlayerLayer, etc) and libxml2. The reasons for this are to gain some control over the playback and mute options as long as with the fullscreen options.
The player works with an internal state machine that will iterate among the following states

IDLE: Nothing loaded, view is empty and black, from here we can go only to LOAD
LOAD: Loading the URL, cannot load again, showing a loading spin in the view, from here we can go to IDLE (if closed) or READY
READY: Shown only the first frame of the video, from here we can go to IDLE(if closed) or PLAY
PLAY: This state is while the video is in reproduction, will show controls (mute, progress, open and fullscreen if enabled), from here we can go to IDLE (if closed) PAUSE or READY (if completed)
PAUSE: This state is active when the video is paused, from here we can go to PLAY or IDLE (if closed)

It contains the following configurable public options

loadWithURL starting this point it should be seen in the screen something a loading spin and the first frame when it's ready
play: This should play/resume/replay if finished
pause: This will pause playback
close: This will clean the buffer, hide all controls and will set the player to IDLE

 (8) Video player in iOS library [10]


Fix php errors, add clone url shortcode

are you able to update the wp plugin ?
Best regards
fix php errors (quite everywhere this time)
fix shortcode & widget extract process
add shortcode to show https & ssh url
Option page :
fix js for primjs integration, add languages support
dynamic repo & user if filled

Will try to push it this weekend to the wordpress repository.

ok, ( I did not update the wp description though )
if you need help i'm on wordpress too :
https://profiles.wordpress.org/moabi

a last fix for today, removed curl to use wp http API


Sample flow for conversation

A sample flow is required for the new conversation node.

We now have 2
https://github.com/watson-developer-cloud/node-red-labs/tree/master/starter-kits/ok_watson
and
https://github.com/watson-developer-cloud/node-red-labs/tree/master/basic_examples/conversation


[Feature] endpoint name drop-down box to the limit

Search before asking

[X] I had searched in the issues and found no similar feature requirement.

Description
export const Endpoints = {
variable: '$serviceId: ID!, $keyword: String!',
query: getEndpoints: searchEndpoint(serviceId: $serviceId, keyword: $keyword, limit: 100) { key: id label: name },
};

Because skywalking has access to many systems and there are many endpoints, it is obviously inappropriate to add the data of the drop-down box to the limit
Use case
recovery input endpoint name  the request path
Related issues
not
Are you willing to submit a PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Endpoint search would not pull all data, that is unrealistic.

What's the point of endpoint name search? There is no reference meaning. I think it is better to replace the input box before 8.6 instead of the drop-down selection box. That's what I mean

I think we can open this question and think about it

When the user inputs, the server will fuzzy query the latest data return according to the user input, which is the best user experience

There was a long discussion one year ago, this search is simple but has a super bad performance impact on the trace query. So, the community has decided to remove it.
This is a community, diverse groups of people, make the final decision. If you want your voice to be considered seriously, you need to be a part of the committer team based on your contributions to this community.
A project can't make everyone happy

please， How to be part of the submitter team.

I hope to submit the corresponding code to contribute to this community

There is no submitter team in the ASF.
The committer team is the one is trusted by the PMC(Project Management Committee), who could do routine code review and merging. The PMC is a smaller group of people watching and sheepherders of the project.
This doc would show how a committer gets promoted, https://skywalking.apache.org/docs/main/latest/en/guides/asf/committer/, and here are the current committers and PMC members, https://skywalking.apache.org/team/.
The basic principle is, that you need to begin contributing to the project through pull requests, such as bug fixing, or begin to work on a new feature if you have an idea, the idea gets discussed, and at least one of PMC gets you to support to do.
SkyWalking is a community of volunteers, so, there is no one to assign you anything, you need to find things to do because you feel you want to.
About this feature(endpoint name-based search), the conclusion was made, that unless we have committers to initial a new discussion again, we wouldn't accept it back in the mainstream. This is how a community works, we have 600+ code contributors, and countless users. The decision is the decision, very serious, not be able to change randomly.

I see. Thank you for your answer。

skywalking 8.7.0 have a webui bug, submene  "xxx.com:8080/trace" refresh page，It will jump to the back-end 404 address

skywalking 8.7.0 have a webui bug, submene "xxx.com:8080/trace" refresh page，It will jump to the back-end 404 address

After my testing of each version, only 8.7 will have this problem, and neither 8.6 nor 8.8 will

Now, we are working on 9.1, the old versions are not our concern.

There are no plans to use versions above 9.0

ok, Thanks


Sorting is broken on vue3 version

Basic column sorting does not work anymore on the vue3 version
I can provide a codepen if necessary
Thanks for the great work, this plugin is awesome!

It related to the way of refresh. I have patch the fix in new ver. Please pull it and try.


Clangd is not completting

Hi i´m here again. 😀
Well I do this issue because as I could already install clangd, now that I wanted to make a .c file it does not give me the autocompletion option, but, when I write and repeat again, the "option" appears.
autocomplete but with buffer, if I do it in a .vim or .lua file if I get the autocomplete option.
Could you help me to know what the problem is? 🤔😅
Here are some evidences:
.vim file

.c file
In this part I want to write int, but I don´t see that the autocomplete is working in .c files

@XtraSavx  Hi some times the lsp is slow connecting the servers can you check if when open a C file run :LspInfo see clangd attached to this buffer?

@XtraSavx Hi some times the lsp is slow connecting the servers can you check if when open a C file run :LspInfo see clangd attached to this buffer?

Yes, I can see clangd

@XtraSavx  This is relative normal to the binaries of language servers or the .bat or script files because takes some time add the complete can you test the completion after 30 seg this can be solve your problem.
Or can you send the issue to the nvim-lspconfig repository for make this more faster i think. What you think @williamboman ?

From what I can see the server is successfully installed, which is where the scope of this plugin ends. I am not having any issues personally with clangd. Probably something else going on

From what I can see the server is successfully installed, which is where the scope of this plugin ends. I am not having any issues personally with clangd. Probably something else going on

Can I put this issue in the lsp-config?

Can I put this issue in the lsp-config?

I don't think this is an issue with lspconfig either. If I had to guess it's either caused by

some other plugin
certain combination of plugins that triggers the issue
some personal config

Do you use null-ls? https://github.com/jose-elias-alvarez/null-ls.nvim/issues/229

Can I put this issue in the lsp-config?

I don't think this is an issue with lspconfig either. If I had to guess it's either caused by

some other plugin
certain combination of plugins that triggers the issue
some personal config

Do you use null-ls? jose-elias-alvarez/null-ls.nvim#229

Ok thanks, i´m gonna check that. 😀👏

Good luck 😄

https://github.com/williamboman/nvim-lsp-installer/issues/116#issuecomment-933446758
had same issue, this worked for me for macos.


Update classifier.py

Hi, I don't know if it is correct, but I obtained better performances using the second pre-trained model 20180402-114759. I just add fixed standard normalization option instead of the default prewhiten.

hey @alenic please can you share the link of your code.
and also the procedure to run it?

Hi @gauravzende the link of the code that I fixed is here:
https://github.com/alenic/facenet/blob/master/src/classifier.py
It's a python script, then you can run it with python...

@alenic  to running this code which properties of sample images can affect on it?
I Coudn't found accurate output as i expected.


Set GC intervals to 10 sec

This is te lowest value of the ones defined in the Marvin configs.
When this DB setting is < Marvin there is no issue. The other way around causes issues. This makes sure the DB is aligned with the lowest setting. Even better would be to align all Marvin configs and set them to 10.

Ping @borisroman

LGTM! Will fix the following test:
Create a redundant VPC with 1 Tier, 1 VM, 1 ACL, 1 PF and test Network GC Nics ... === TestName: test_04_rvpc_network_garbage_collector_nics | Status : FAILED ===


Flutter always no device

Steps to Reproduce

start android studio
press run
get no connected devices found
execute  flutter doctor

Logs

[√] Flutter (Channel master, v0.9.4-pre.31, on Microsoft Windows [Version 10.0.17134.285], locale zh-CN)
[√] Android toolchain - develop for Android devices (Android SDK 27.0.3)
[√] Android Studio (version 3.1)
[√] Android Studio (version 3.0)
    X Flutter plugin not installed; this adds Flutter specific functionality.
    X Dart plugin not installed; this adds Dart specific functionality.
[!] IntelliJ IDEA Ultimate Edition (version 2017.2)
    X Flutter plugin not installed; this adds Flutter specific functionality.
    X Dart plugin not installed; this adds Dart specific functionality.
[√] Connected devices (1 available)

! Doctor found issues in 1 category.

flutter run error : can't find /lib/main.dart(It's exist)

does not look related to devices found or not.
Please post the comment you executed to get the error message
and the exact and full error output the command caused.

flutter run error : can't find /lib/main.dart(It's exist)

does not look related to devices found or not.
Please post the comment you executed to get the error message
and the exact and full error output the command caused.

I did .

What is the actual error now

can't find /lib/main.dart

or

no connected devices found

Did you try restarting your computer?

What is the actual error now

can't find /lib/main.dart

or

no connected devices found

no connect devices found

Did you try restarting your computer?
Now  i execute flutter. I always get this

Because flutter_tools depends on file 5.0.6 which doesn't match any versions, version solving failed

What is the actual error now

can't find /lib/main.dart

or

no connected devices found
no connected devices found.I try to use  flutter run  then I get this can't find /lib/main.dart

Try switching to beta or dev channel
flutter channel beta
flutter doctor

Try switching to beta or dev channel
flutter channel beta
flutter doctor

get this Can't load Kernel binary: Invalid kernel binary format version.

If you are trying to execute 'flutter run' make sure you are in your projects folder. Also, Andrioid Studio would only see my LG phone if it was connected in chargeing mode.

Also try flutter clean

from what you provided you need to install or finish installing flutter and dart.  https://flutter.io/get-started/editor/

I made it work.I reinstalled  flutter.Thanks for you.

lutter supports both iOS and Android device/simulators.
In terminal, run the flutter devices command to verify that Flutter recognizes your connected Android device.
Here is a reference document, How you can setup Device/Simulator to run your application.
For, Android (on mac system)
Set up your Android device
To prepare to run and test your Flutter app on an Android device, you’ll need an Android device running Android 4.1 (API level 16) or higher.
Enable Developer options and USB debugging on your device. Detailed instructions are available in the Android documentation.
Using a USB cable, plug your phone into your computer. If prompted on your device, authorize your computer to access your device.
In the terminal, run the flutter devices command to verify that Flutter recognizes your connected Android device.
Start your app by running flutter run.
By default, Flutter uses the version of the Android SDK where your adb tool is based. If you want Flutter to use a different installation of the Android SDK, you must set the ANDROID_HOME environment variable to that installation directory
Find Out At Here


ChangeFeedRequestOptions Refactor

ChangeFeedRequestOptions Refactor
Description
Refactored ChangeFeedRequestOptions to have the following design points:

Avoid users setting mutually exclusive fields like continuation token and start from
StartFrom Beginning is just not setting a start from and avoid setting to a magic number like DateTime.MinValue
Enforces that StartTime is always in correct UTC format.
Adds visitor so that work won't break when new types are added
Made static constructors for intellisense discoverablity.
Removed static methods that enrich the request message, when it could be done in PopulateRequestMessage.

Is this work towards making the ChangeFeedIterator part of the non-preview releases? I have issues with the feed processor, and I need to use the change feed iterators to solve my problem. Are there any planned dates for when the ChangeFeedIterator becomes generally available?


Added adp operator

Added required manifests for the oadp operator

@james-cccc , looks good - just two small updates if you don't mind :)
Thanks!

Thanks for the contribution!


log4j 2.17.0

https://logging.apache.org/log4j/2.x/security.html

Coverage remained the same at 50.509% when pulling e29edc84e1bae6ddd090d03744b941a25befecd6 on sullis:log4j-2.17.0 into 9ca84ca02f9049d1e1ab68a338a2886052ec57e9 on apache:master.


Move the k8s namespace field from organization to project

This will temporarily break the exisiting code, but the a next change will implemenet the logic.

https://github.com/llm-operator/rbac-manager/pull/39 is the draft PR.


feat: Fabric route filter resource and data sources

Addition of:

data equinix_fabric_route_filter
data equinix_fabric_route_filters
equinix_fabric_route_filter

Includes testing and documentation

@ctreatma , I made the changes for the comments. I won't be able to get the Validate Docs PR to pass because I do want to leave the docs out until this is publishable. Though I do need the rest of the code for the other resource additions coming after this one.
Do you have some guidance on how to proceed in scenarios like that?

My recommendation is to document the resources as they are added to the provider.  Once a PR is merged to main it can be released at any time by any user with access to the release job, so we don't have a notion of a thing that is in main but is not exposed to users.  Given our on-demand release process, I don't think it's a big problem to roll out related resources across multiple releases, as long as the resources in each release work correctly.
I suppose you could disable the tests and remove the provider.go changes so that the resource and data source are unreachable, and then add the provider wiring and enable the tests later to actually expose the resources to customers, but then you won't get test feedback until much later and that enablement PR could become unmanageable if it contains a bunch of fixes for test failures that could have been caught earlier.

My recommendation is to document the resources as they are added to the provider. Once a PR is merged to main it can be released at any time by any user with access to the release job, so we don't have a notion of a thing that is in main but is not exposed to users. Given our on-demand release process, I don't think it's a big problem to roll out related resources across multiple releases, as long as the resources in each release work correctly.
I suppose you could disable the tests and remove the provider.go changes so that the resource and data source are unreachable, and then add the provider wiring and enable the tests later to actually expose the resources to customers, but then you won't get test feedback until much later and that enablement PR could become unmanageable if it contains a bunch of fixes for test failures that could have been caught earlier.

Copy that. Will include docs and make this releasable. It won't be much use to customers until the other two are included, but it will work completely fine on its own.

@ctreatma , this is ready to go now.


[API] orgEditTeam make Fields optional

as title

Codecov Report

Merging #9556 into master will decrease coverage by 0.06%.
The diff coverage is 45.72%.

@@            Coverage Diff             @@
##           master    #9556      +/-   ##
==========================================
- Coverage   42.06%   41.99%   -0.07%
==========================================
  Files         574      577       +3
  Lines       75430    75973     +543
==========================================
+ Hits        31730    31907     +177
- Misses      39761    40118     +357
- Partials     3939     3948       +9

Impacted Files
Coverage Δ

modules/structs/hook.go
6.66% <ø> (ø)
:arrow_up:

services/mirror/mirror.go
18.75% <0%> (ø)
:arrow_up:

models/error.go
33.82% <0%> (-0.32%)
:arrow_down:

modules/markup/sanitizer.go
85.71% <100%> (+1.09%)
:arrow_up:

modules/markup/common/footnote.go
21.22% <21.22%> (ø)

modules/markup/common/linkify.go
34.69% <34.69%> (ø)

routers/api/v1/repo/issue_reaction.go
75.27% <57.14%> (-0.72%)
:arrow_down:

modules/markup/markdown/goldmark.go
68.18% <68.18%> (ø)

models/issue_reaction.go
84.02% <80%> (-3.92%)
:arrow_down:

modules/markup/mdstripper/mdstripper.go
89.61% <87.87%> (-10.39%)
:arrow_down:

... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aaef90a...f196f1e. Read the comment docs.

@lunny tested and worked!

https://github.com/go-gitea/gitea/pull/9556/files#diff-3456f19402661bf53eee0c00f4b034c6R206 make sure name is not empty ...

and if you mean https://github.com/go-gitea/gitea/blob/master/models/org_team.go#L581-L586
this only make sure two teams with same name exist ...

Have you tested a blank name? Or could you add a test for that situation?

@lunny added Test and make all Fields optional

@lunny I looked throu the whole function and found out that the API need all fields to be filed otherwhies it changes - eaven if you don't intend to :(
now all fields are optional (beside id ...)

@lafriks added your suggestions

@lunny look's like an xorm issue, can you confirm?
[E] EditTeam: mssql: Cannot insert explicit value for identity column in table 'team_unit' when IDENTITY_INSERT is set to OFF.
log:
testlogger.go:71: 2020/01/02 14:14:36 ...ers/routes/routes.go:100:func1() [I] Started PATCH /api/v1/teams/16?token=4b9184a7c8f09c17a73509376e4d8fe22b596e4e for
--
190 | testlogger.go:71: 2020/01/02 14:14:37 ...dules/context/api.go:78:Error() [E] EditTeam: mssql: Cannot insert explicit value for identity column in table 'team_unit' when IDENTITY_INSERT is set to OFF.
191 | api_team_test.go:92:
192 | Error Trace:	integration_test.go:365
193 | integration_test.go:223
194 | api_team_test.go:92
195 | Error:      	Not equal:
196 | expected: 200
197 | actual  : 500
198 | Test:       	TestAPITeam
199 | Messages:   	Request: PATCH /api/v1/teams/16?

@6543 You should not insert records with id on mssql since it's autoincrement. But mysql will support that.

@lunny done
https://github.com/go-gitea/gitea/pull/9556/files#diff-f13bb9abff87d33ca9cfc067797eb48bL609-R609


Expand example does not run: getToggleAllRowsExpandedProps is not a function

Describe the bug (required)
A clear and concise description of what the bug is.
The expand example does not run.
Provide an example via Codesandbox! (required)
Use a new react-table codesandbox to reproduce the issue.
N/A
Steps To Reproduce (required)
Steps to reproduce the behavior:

Clone the react-table repository
Change directory to examples/expand
Run the command yarn && yarn start
See error

TypeError: getToggleAllRowsExpandedProps is not a function
Header
D:/Reference/react-table/examples/expanding/src/App.js:92
  89 | {
  90 |   // Build our expander column
  91 |   id: 'expander', // Make sure it has an ID
> 92 |   Header: ({ getToggleAllRowsExpandedProps, isAllRowsExpanded }) => (
     | ^  93 |     <span {...getToggleAllRowsExpandedProps()}>
  94 |       {isAllRowsExpanded ? '👇' : '👉'}
  95 |     </span>

Expected behavior (Recommended)
A clear and concise description of what you expected to happen.
Example program should run without error.
Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

OS: [e.g. iOS] Windows, Linux
Browser [e.g. chrome, safari] N/A
Version [e.g. 22] N/A

Smartphone (please complete the following information):

Device: [e.g. iPhone6] N/A
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

:tada: This issue has been resolved in version 7.6.3 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This issue has been resolved in version 7.6.3 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


WIP: Fix: Use schema and column from CLI as defaults

Description
Fixes: #1547
This PR uses the defaultSchema and defaultColumn from CLI if a Caggs PromQL query does not return any data. This may be because the user missed applying a __colum__ information, which case we should return a default column. This default column defaults to avg since most downsampling systems use/expect avg. This features behaves just like metrics.promql.default-subquery-step-interval which is applied if the user forgets to use a step value in PromQL subquery.
Note: DO NOT REVIEW. Needs more work based on some quick discussion.
Merge requirements
Please take into account the following non-code changes that you may need to make with your PR:

[ ] CHANGELOG entry for user-facing changes
[ ] Updated the relevant documentation

Based on the team discussion, we have decided to return all the __column__ as individual series if the __column__ label was not found. This will be in line with the multi-columnar PromQL queries.
Hence, closing this PR as per the above plan.


Pre-preparation for new update

Bump version.
Automatically fetch versioncode from buildconfig.
Code cleanup.

good luck guys


Add Sensirion SEN5x library

Hi @Sensirion-Bot @MBjoern . I see that your pull request has developed a merge conflict due to overlapping other work on the project.
If you will resolve the merge conflict we can proceed with merging this. There is some information about that here:

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/addressing-merge-conflicts/resolving-a-merge-conflict-on-github
https://docs.github.com/en/github/collaborating-with-pull-requests/addressing-merge-conflicts

I would be happy to assist with that, but it seems you have disabled the pull request's "Allow edits from maintainers" setting. You can enable me to fix the conflict by following these instructions:
https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork
Once that is done, please comment here to let me know.
Please let me know if you have any questions or concerns.

Closing due to lack of response.  @Sensirion-Bot @MBjoern if you get around to resolving the conflict, feel free to comment here and I'll reopen, or you can submit a new pull request if you prefer.


Update profanity_wordlist.txt

hi @Andriybeats, thank you for contributing to my small repo.
Your wordlist is very extensive and detailed (even cover some words I didn't think of!). However, personally I just want to keep the default wordlist small and allow users to use their own preferred wordlist.
I will still keep this PR open, and will reconsider if there are more requests for updating the wordlist :)

This wordlist was very helpful in creating my own wordlist, but where you draw the line for different swear words is very dependent on the use case and locale of the users


remove the deprecated io/ioutil package

Signed-off-by: myan<EMAIL_ADDRESS>Resolve the following issue when building the manager image:
SA1019: "io/ioutil" has been deprecated since Go 1.19: As of Go 1.16, the same functionality is now provided by package io or package os, and those implementations should be preferred in new code. See the specific function documentation for details. (staticcheck)
        "io/ioutil"
        ^

/cc @clyang82 @morvencao

Good catch. But it seems you need to ensure the code coverage is greater than 70% so that it can be merged.


Elastic lb provider fix - does not run deregister, always tries to register

See issue: https://github.com/opscode-cookbooks/aws/issues/132
This allows the deregister action to actually run and prevents the register action from running if the node is currently in the ELB.

+1
It looks good to me.

LGTM

:+1:
@someara bump?

Thanks!


Contact customfield page - When we reset filter the label does not get removed

Describe the bug

When we filter customfield with some text and reset them then ther search text and filtered with label does not get removed

https://www.berrycast.com/conversations/1a8fd114-7e03-57d6-a7bb-3fdb149438a9


Add message on entered giveaways in chat

User should receive a notification when bot entered a giveaway with a link to it.

Link is not added, separate enhancement needed.


Add dependency up-to-date checks

Not clear how to make this work with Travis. Besides, as of now it only lists the junit dependency.


fix: add_provider takes a provider class reference, not an object

Thank you, released in version 0.4.1


New Cluster node IP in Azure?

I can't wrap my head around how I create a new Cluster node object in AD and create an IP address, and then magically everything in Azure routes to a made up IP on the Azure VNet? What am I missing here? How does traffic route to an IP without an interface in the Azure network?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 706b2e1a-e90e-d70e-431f-5476b0ca52c1
Version Independent ID: 70721d4c-642c-61f8-6c61-84b1dd1ae96c
Content: Deploy a two-node Storage Spaces Direct SOFS for UPD storage in Azure
Content Source: WindowsServerDocs/remote/remote-desktop-services/rds-storage-spaces-direct-deployment.md
Product: windows-server-threshold
Technology: remote-desktop-services
GitHub Login: @Haley-Rowland
Microsoft Alias: harowl

For a SOFS the client connects to the node address (and potentially gets redirected to the other node if that is better).   The SOFS name eg my-sofs1  should get regeistered in dns as the addresses of both nodes

When I am creating the cluster it does not register the IP with Azure.  Meaning any system in Azure could grab that IP.  Where as on prem I would reserve that IP in DHCP.

Thanks for your dedication to our documentation. If we have been unable to review your issue in a timely manner, we sincerely apologize for the delayed response. We have captured the informtion you have provided for review. We are closing this issue for now, but if you feel that it's still a concern, please respond and let us know. If you determine another possible update to our documentation, please don't hesitate to reach out again. #please-close


Install depends on rustc to find target triple

If --target isn't supplied there is a dependency on rustc to find the target triple.
https://github.com/japaric/trust/blob/08c86c03efb887c33abd4bd5bc3677f81bac98e7/install.sh#L99-L102
https://github.com/japaric/trust/blob/08c86c03efb887c33abd4bd5bc3677f81bac98e7/install.sh#L127
Given the usage instructions at https://github.com/japaric/trust#use-the-binary-releases-on-travis-ci, it surprised me that the script uses rustc to find the target triple.
If we could determine target by using commands like uname -a this script would be significantly more portable.
I'll try and dig up what could work across macOS and Linux.

This is work in progress, but I've also run the script through shellcheck and made a few improvements such as checking if the repository returns a 404 before downloading the releases.
https://gist.github.com/sjparkinson/327dc78c60ab81a06c946630b4288910
I'll make a PR to include these changes too.

A project I maintain recently ran into the issue the current trust download script fails on systems where rustc reports a linux-gnu target, because we only provide a prebuilt linux-musl target for portability reasons.
Please feel free to consider this not in-scope for this issue, but it would be nice if a linux system would try to download both the -gnu target and the -musl target. Ideally, it would try the -musl target first, because that's more likely to work on all linux versions of all linux distros, even ones that have a very old system libc.

I wrote a near drop-in replacement install script that will check for -musl, -gnu suffixes and also even doesn't require rustc to be present on the system to detect the platform (uses platform detection code take from rustup). It should work with the latest cross. Contributions welcome 😄.
https://github.com/rossmacarthur/install
curl -LSfs https://rossmacarthur.github.io/install/crate.sh \
    | bash -s -- --repo "japaric/cross" --to ~/.cargo/bin


Incorrect spelling of "occured"

v1.0.4
Line 2892
var occurredWhen = " occured when " + sentance.map(function (word) {

Correct spelling:
var occurredWhen = " occurred when " + sentance.map(function (word) {

Interestingly, the variable "occurredWhen" is using the correct spelling.

;) Thnks.


AAP-28426 change get to getBy, add test for download buttons

Related to https://issues.redhat.com/browse/AAP-28426
Add tests for all download buttons

The CI checks are failing on remotes.cy.ts. Is that unrelated to these changes?


Is our new authentication backwards compatible?

While working on the docs we were not sure if the new authentication is backwards compatible (and thus supports configuration on ScaledObject) or not?
From what I'm seeing I'd say it is.
Either outcomes are fine but would just be good to know so we can align the docs.
/cc @jeffhollan

When adding TriggerAuth support for AWS Cloudwatch, I was asked to remove the scaled object configuration https://github.com/kedacore/keda/pull/397#discussion_r338602074
I have done the same for AWS SQS Scaler.  I can add them back if necessary.

I found this today, there is now an official pod identity provider for AWS https://github.com/aws/amazon-eks-pod-identity-webhook it's a mutating webhook that injects the AWS_ROLE_ARN into the pod based on an annotation from the Service Account of the pod. Maybe we should consider re-adding pulling at least AWS_ROLE_ARN from the pod, possibly only if podIdentityProvider == "aws"

I've created #457 for that - Even if we keep the environment variables I think we should make it automagically for AWS customers.
My comment (https://github.com/kedacore/keda/pull/397#discussion_r338602074) was based on the assumption that we were killing backwards compatibility but @jeffhollan brought this up and I'm not longer sure if my assumption is correct - If this is the case, I'm sorry for asking you to remove it @zach-dunton-sf
I personally would not go there for sake of simplicity but I don't want to block this.

I have a PR ready for #457 that is pulling the annotation from the service
account. I’m waiting on one of the other two to be merged first so I can
rebase to that branch and push it.
On Thu 14. Nov 2019 at 12:22, Tom Kerkhove<EMAIL_ADDRESS>wrote:

I've created #457 https://github.com/kedacore/keda/issues/457 for that

Even if we keep the environment variables I think we should make it
automagically for AWS customers.

My comment (#397 (comment)
https://github.com/kedacore/keda/pull/397#discussion_r338602074) was
based on the assumption that we were killing backwards compatibility but
@jeffhollan https://github.com/jeffhollan brought this up and I'm not
longer sure if my assumption is correct - If this is the case, I'm sorry
for asking you to remove it @zach-dunton-sf
https://github.com/zach-dunton-sf
I personally would not go there for sake of simplicity but I don't want to
block this.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kedacore/keda/issues/453?email_source=notifications&email_token=AEH7ZDLZ6YGFZ6P4AL42JNLQTUYG5A5CNFSM4JNG4PJKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEBQBFQ#issuecomment-553844886,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEH7ZDLU3NTCR3WMV5B2ZK3QTUYG5ANCNFSM4JNG4PJA
.

Yes I think in general we’ve preserved the way to inline authentication to both preserve backwards compatibility and also to provide an easy way to create a scaled object with secrets. I don’t know if there’s a compelling reason to force trigger auth and somewhat like what other scalers have done to show you can do both
https://keda.sh/scalers/azure-service-bus/
Thanks @zach-dunton-sf thesr PRs are awesome

Sounds good to me, but then we'll have to do a sweep to ensure that all scalers use this approach!

Ive kept the environment variable auth for redis while TriggerAuthentication takes precedence.

I think we can close this, ok?

Yes. I believe so.
Tom Kerkhove<EMAIL_ADDRESS>schrieb am Mo. 9. März 2020 um
09:27:

I think we can close this, ok?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kedacore/keda/issues/453?email_source=notifications&email_token=AEH7ZDPHZ2CAWNBNRXKVIVLRGSR6DA5CNFSM4JNG4PJKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOGDXFQ#issuecomment-596392854,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEH7ZDJYJFXBPXI4CHWZLETRGSR6DANCNFSM4JNG4PJA
.


update package install dependency

#12

Sorry this took so long. It completely slipped of my radar.


the slide feature is not working and also its not showing the banner when pressing the corresponding point

Describe the bug
the slide feature is not working and also its not showing the banner when pressing the corresponding point
To Reproduce
https://github.com/user-attachments/assets/b7fffc0c-4d17-4e39-8cc6-3226cf76f5b2
Expected behavior
it should respond and slide when i try to slide it

Hey can you assign me this issue
I'm getting this warning

#318 is similar to your issue , ask to be assigned on that


🍒 Cherry pick PR #16918 to staging 🍒

🍒 Cherry pick https://github.com/Expensify/App/pull/16918 to staging 🍒

🚀 Cherry-picked to staging by https://github.com/OSBotify in version: 1.2.94-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

🚀 Deployed to production by https://github.com/thienlnam in version: 1.2.94-3 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 1.3.28-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.3.28-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Sync eng/common directory with azure-sdk-tools for PR 1524

Sync eng/common directory with azure-sdk-tools for PR https://github.com/Azure/azure-sdk-tools/pull/1524  See eng/common workflow

/check-enforcer override


Helm Chart Refactoring

Description
This PR refactors the code of the Liqo helm chart (Ref. #460):

[x] Remove existing subcharts
[x] Splits templates into different files to simplify troubleshooting

How Has This Been Tested?

[x] E2E Testing

/rebase

/rebase

/rebase

/rebase

/rebase

/rebase


Fix psalm issues

Q
A

Bugfix?
✔

[x] Need to cover \Spiral\Http\Request\InputManager::bearerToken()
[x] \Spiral\Core\Internal\Factory::autowire in line if (!\class_exists($class) && !isset($this->state->injectors[$class])) {

For level 4 see https://github.com/spiral/framework/tree/hotfix/psalm-issues-level4


[ko] Translated the glossary term 'Endpoints' into Korean

from #35555

A tip
I would make it clear that the kind for an Endpoints is Endpoints (plural) and that you cannot omit the “s” from the end. Readers who speak Korean and also know basic English grammar might assume otherwise.

Thank you for the tip!
In the Korean language we do not distinguish between plural and singular nouns in formal context.
But I will leave the original English term in the title along with the translated Korean term, so readers can see that the term is supposed to be plural.

It's also OK to write a short note about the pluralness (or explicitly say something like 이 API의 이름은 Endpoint가 아니라 Endpoints입니다).

It's also OK to write a short note about the pluralness (or explicitly say something like 이 API의 이름은 Endpoint가 아니라 Endpoints입니다).

Okay, that seems like a more convenient option for readers to understand.
I will make sure to add a note that serves the purpose. Thanks!

@sftim
I noticed that the names of the glossary markdown files are 'endpoint.md' instead of 'endpoints.md', even in the original English version.
Should this be an issue to be addressed?

@jihoon-seo
리뷰해주셔서 감사합니다!
말씀하신 사항들 반영하여 수정해보았습니다.

@rollony @sftim Thank you all!
/lgtm

@seokho-son
말씀하신 사항 반영해 보았습니다!
리뷰해주셔서 감사합니다 :)

감사합니다! :)
/lgtm
/approve


[Help]

Hello i cant join discord is there anyproblem with it ?

Its closed only devs

Hello, access to the Discord server is closed, keep an eye on the relevance of the link, you may be able to log in
https://discord.gg/cottonbuds
If there are no more questions, please close the topic.

okay thank you


Implement access to the API via a token, create a new role that have permission to manage tokens

Initially limited to read-only and the meta endpoint. Prefer to have it on a separate domain, api.opentech.fund.

@danblah How the token will be used? A few more details about the usage will help to decide the package

Token expire time requirements.
Can a user generates a Token by making a request or we need Token authentication for internal usage so only admin can create? Which client (Mobile app or) will make the request?

We have three options for a token authentication here

DRF inbuilt token authentication
django-rest-knox
JSON Web Token using django-rest-framework-simplejwt

@danblah @Parbhat As I understand it the tokens should be permanent. But I think most services call this a API KEY.
Right now you can only access the API if you are logged in and have the right permissions.
I believe OTF want authorised users to be able to create a API KEY (token) that can be used to access the API until they are revoked.

@frjo Thanks for the information. Then we will need a different strategy. The above packages are meant to authenticate users with a token. An alternative to current session based authentication so clients like Mobile apps, desktop apps can use the API.
Our use case seems like allowing server-side clients to use our API. These clients (machines) do not have an account on our site but still need to interact with our API. For this requirement djangorestframework-api-key will be a good option.

@Parbhat let her what @danblah says first. It might be that the keys/tokens should belong to an account.
Sent with GitHawk

From a users perspective:

User is added to role API Access (or whatever)
User has new tab or some interface within https://apply.opentech.fund/account/ named "Access Keys/Tokens" or whatever. Ideally, this tab is only accessible if the user is from an approved domain (opentech.fund) with an active OAuth token, and/or has MFA enabled, and is in this role.
User has option to generate new Access Keys, view previously generated keys, and revoke previously generated keys.
User generates an Access Key (Access Key ID and Secret Access Key) can give it an expiration date, and provide a short description for its use
User can then then submit a json PUSH/GET/PUT request that includes the access key id and secret access key to send/retrieve as needed as they could from the web interface.
All requests are logged as from the user as they would be from the web interface but with an additional indication that it was authenticated with an Access Key via the api interface.

That help?

Sounds good. So, the access token/key is linked to a user account which gives them access to the API. Only users in a group say API access can authenticate themselves using a token along with current session authentication.

@danblah @frjo The workflow mentioned here is not generally used by web apps. The commonly used method is to first get a token using email/username and password by making an API request. The user receives a token and it is sent in Authorization header for subsequent API requests. And token is a single value and not a combination of Access Key ID and Secret Access Key. Mentioning the generally used method before implementing the custom solution. DRF TokenAuthentication and django-rest-knox both are based on general workflow.

@Parbhat  No need for Access Key ID and Secret Access Key as far as I can see,  just one access key/token will do. I believe @danblah just copied how it works on Amazon AWS, overkill for us.
The rest framework gives an example using an auth token with curl:
curl -X GET http://<IP_ADDRESS>:8000/api/example/ -H 'Authorization: Token 9944b09199c62bcf9418ad846dd0e4bbdfc6ee4b'

Looks exactly like what we want. That token the users should be able to retrieve from it's user account on the OTF WebApp. Create and delete as @danblah wrote above.
The django-rest-knox seems to have a better implementation so I would use that.

Thanks, django-rest-knox looks better than DRF token authentication. Is making the first API request using token a requirement? Can not a user just obtain the token first using email and password using Login API? And then create subsequent requests using the attained token. We can create an interface on the web app to generate and manage tokens. But from a security view, tokens should have a short expiry time. Allowing users to manage tokens is not seen commonly.

@Parbhat My impression is that requests mainly will come from other webb applications, e.g. something like https://dataviz.opentech.fund/.
@danblah Is that correct or do we have other use cases?
Having them add e-mail and password to the app configuration to be able to get api tokens from OTF Web App is not optimal I think.

@Parbhat My impression is that requests mainly will come from other webb applications, e.g. something like https://dataviz.opentech.fund/.

Do not know much about the DataViz platform. From the current look, looks like there are no user accounts. If the requirement is just to access data from OTF via API then djangorestframework-api-key is a good choice.

djangorestframework-api-key allows server-side clients to safely use your API.

Server-side clients are third-party backends and services (i.e. machines) which do not have a user account but still need to interact with your API in a secure way.

@Parbhat The DataViz is an example of an app that would use the API to pull data.
The developer of that site would get an account on the OTF Web App with permissions to generate API tokens. Take that token and add it to the DataViz system so it can pull data from the OTF Web App.
Talked with OTF about this and they would really like to have this API access via token on a separate domain, api.opentech.fund.

This sounds like an ideal case for djangorestframework-api-key. Here we want another service like DataViz to access our API. Other options like Django inbuilt token authentication are meant for giving users an option other than session authentication.
The workflow will be:

Admin user/a user in a certain group can create, view and revoke API keys (token) via the admin site.
API calls can be made using this API key from DataViz platform to access OTF API endpoints. We can only allow access to certain endpoints only using an API key.

@danblah Feedback?

Sounds right to me.

And me.


Previous request was cancelled due to a new request - iOS

Hello. I get this error after upgrading from 12.10.4 to 12.15.1
Environment:
react-native-iap: 12.15.1
react-native: 0.72.5
Platforms (iOS, Android, emulator, simulator, device): iphone, real devices
Previous request was cancelled due to a new request
Flow: I put the app in background and return after some time.

+1 also having this issue suddenly. Trying to run getSubscriptions, getProducts, one after another, using await before my functions.
`
useEffect(() => {
const fetchSubscriptions = async () => {
try {
const fetchedSubscriptions = await getSubscriptions({
skus: subscriptionIds,
});
setSubscriptions(
fetchedSubscriptions.sort(
(a, b) =>
subscriptionIds.indexOf(a.productId) -
subscriptionIds.indexOf(b.productId),
),
);
} catch (err) {
console.warn(err);
}
};
const fetchProducts = async () => {
  try {
    const fetchedProducts = await getProducts({skus: productIds});
    setProducts(
      fetchedProducts.sort(
        (a, b) =>
          productIds.indexOf(a.productId) - productIds.indexOf(b.productId),
      ),
    );
    setLoading(false);
  } catch (err) {
    console.warn(err);
  }
};

const fetchAllData = async () => {
  setLoading(true);
  await fetchSubscriptions();
  await fetchProducts();
  setLoading(false);
};

fetchAllData();

}, [])`

I am also having this issue now, although I didn't change anything in the IAP part of my app lately. I now realize based on the comment above, that the only change has that I upgraded to<EMAIL_ADDRESS><EMAIL_ADDRESS>platform iOS

The solution that worked for me was to use async await functionality and make sure to call getProducts and getSubscriptions one after another from an onPress rather than a useEffect.

useEffect works fine for me. Just make sure to use async await (or then) to avoid parallel requests.

const fetchSubscriptions = async () => {
if (isFetchingSubscriptions) return; // Prevent multiple requests
console.log('fetchSubscriptions');
setFetchingSubscriptions(true);

try {
  setLoading(true);
  const fetchedSubscriptions = await getSubscriptions({
    skus: subscriptionIds,
  });
  console.log(
    '🚀 ~ fetchSubscriptions ~ fetchedSubscriptions:',
    fetchedSubscriptions,
  );
  setSubscriptions(
    fetchedSubscriptions.sort(
      (a, b) =>
        subscriptionIds.indexOf(a.productId) -
        subscriptionIds.indexOf(b.productId),
    ),
  );
  console.log('fetchSubscriptions success');
} catch (err) {
  console.error('Error fetching subscriptions:', err);
  Alert.alert('Error', 'Failed to fetch subscriptions. Please try again.');
} finally {
  setLoading(false);
  setFetchingSubscriptions(false);
}

};

I am also using useEffect but 2x, so I end up with:
`
const isConnected = useConnectionToIap();
const { products } = useProducts(isConnected);
const { subscriptions } = useSubscriptions(isConnected)
`
Since it seems like await getProducts() must not run at the same time with await getSubscriptions() (based on comments above), I solved it like this:
const { products } = useProducts(isConnected); const { subscriptions } = useSubscriptions(isConnected && products)

I'm pretty sure this won't be fixed. I think this is an explicit behavior from #2604 to fix other issues, so we should just work within its constraints.

Yes. I already made a workaround and it's fine. I will close the issue


Fixing some spigot world import issues

Spigot worlds were incorrectly identified as multiple worlds and when copying the worlds the code would not copy the nether and end properly. This change will hide the nether and end worlds from the multiple world search and also copy the nether and end if it exists.
There is existing code that I thought did the latter on first glance, but it is actually to convert a world to a spigot world only.
Fixes #682

When using the newest docker image containg this fix, the world download fails:
[init] Resolved version given LATEST into 1.16.4
[init] Resolving type given PAPER
[init] Downloading PaperMC 1.16.4 (build 323) ...
[init] Unzipping world
find: unrecognized: -printf
BusyBox v1.29.3 (2019-01-24 07:45:07 UTC) multi-call binary.

I think the -printf flag isn't supported in alpine (https://github.com/google/cadvisor/issues/1556).

I'm sorry, I should have tested that also myself. Fix is on the way...


'NoneType' has no attribute 'name' error in command reactionrole list

Cause was a deleted role being referenced (either as a RoleChange or RoleRequirement).


NullPointerException if you run help for a command with arguments

if you run help for a command with arguments, like build or decompile, this happens:
> help build
 - build        Build the jar or a zip with modified classes
Optional parameters:
Exception in thread "main" java.lang.NullPointerException
        at org.mcphackers.mcp.main.MainCLI.<init>(MainCLI.java:147)
        at org.mcphackers.mcp.main.MainCLI.main(MainCLI.java:60)

This is fixed in latest commits. It is not available in a release yet.


dry-run commands should use the actual command to be executed, not a text approximation

dry-runs like here are great but have no guarantee that they're in sync with the real code.  Instead, what about using something like:
cmd = sh.COMMAND.bake(args)
print(f"executing {cmd}")
if not dry_run:
    cmd()

It would be interesting to check if we can disable some sh commands entirely somehow, so that we wouldn't even need to pass down the dry_run flag.


update

Adding bar across the top

Codecov Report

Merging #9 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master       #9   +/-   ##
=======================================
  Coverage   78.57%   78.57%
=======================================
  Files          12       12
  Lines          98       98
  Branches        8        8
=======================================
  Hits           77       77
  Misses         20       20
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1891670...ce3d2a2. Read the comment docs.


[FEATURE]-Additional improvements to Feedbacks

Is your feature request related to a problem? Please describe.
The current feedback paradigm requires you to maintain state externally of the Feedback and pass in a valueFunc at construction to notify listeners of a value change.  This process is tedious, especially since you have access to the last state already baked into the Feedback.  I'd propose passing in a function to the FireUpdate method.  This way you wouldn't have to manage state externally, and you could update state based on context.  This is partly inspired by #743
Describe the solution you'd like
pseudo code for a bool feedback class:
        public void FireUpdate(Func<bool> valueFunc)
        {
            bool newValue = valueFunc();
            if (newValue != _BoolValue)
            {
                _BoolValue = newValue;
                LinkedInputSigs.ForEach(s => UpdateSig(s));
                LinkedComplementInputSigs.ForEach(s => UpdateComplementSig(s));
                OnOutputChange(newValue);
            }
        }

        public void FireUpdate(Func<bool, bool> valueFunc)
        {
            bool newValue = valueFunc(_BoolValue);
            if (newValue != _BoolValue)
            {
                _BoolValue = newValue;
                LinkedInputSigs.ForEach(s => UpdateSig(s));
                LinkedComplementInputSigs.ForEach(s => UpdateComplementSig(s));
                OnOutputChange(newValue);
            }
        }

Describe alternatives you've considered
An entirely new class and update the LinkInputSig extensions

Do you have a use case for something like this? I'm not sure I'm a fan of state NOT being managed by a device class. There are also other things that access state outside of feedbacks on occasion.

pseudo code:
OnStringReceivedFromAGather(args)
{
PowerFeedback.FireUpdate(ProcessPowerFeedback(args.Text))
}
static bool ProcessPowerFeedback(string)
{
return a new power state
}

I have to agree with @ngenovese11 it offers a cleaner way to update feedbacks. Its also backwards compatible enhancing feedbacks but still allows for the current methods as well.

I find it exceptionally hard to argue with an enhancement that is fully backwards compatible while offering additional flexibility.

Also a method to update the ValueFunc was just added, this seems like the next logic step to that.  How is the below any different:
OnStringReceivedFromAGather(args)
{
var newPower = ProcessPowerFeedback(args.Text);
PowerFeedback.SetValueFunc(() => newPower);
PowerFeedback.FireUpdate()
}
static bool ProcessPowerFeedback(string)
{
return a new power state
}

Yeah - I hadn't seen that one - that seems far more egregious if we're worried about the device being the source of truth because it allows you to utterly decouple the feedback from the value you're already tracking without context.

#743

I believe (@ndorin can correct me if I'm wrong) we added the SetValueFunc to allow for changing the source of the state value that's provided when FireUpdate is called because we had a need for that with the EssentialsPartitionManageer that was added to enable room combining in Essentials.  The state still isn't being maintained in the Feedback class, just the source of the state, either directly from a partition sensor or from a variable set manually from a UI. And, as I'm thinking about it, we probably could have achieved the same thing using a getter instead of changing the feedback func on the fly.
While I think we can go ahead and add this as it just extends on the SetValueFunc added previously, I'm worried we're opening Pandora's box that might make things harder to debug and troubleshoot later on.
Conceptually, the feedbacks are like the selectors in the Redux pattern I've come to know and love while working with NgRx in Angular. I think they should be pure functions, in the sense that if you feed in the same value, you get the same value out every time without any side effects. Little different in practice, because of the nature of the feedbacks and trilist stuff.
One other thing to consider: as we move more towards standalone Essentials with HTML5 UI's, there is less and less of a need for trilist-based communications. It becomes easier to serialize a class and its properties entirely, without relying on our existing feedback classes to provide state to HTML5 UI's.

Also don't discount the value of the feedback class even outside of the context of trilists.  At its heart its something that maintains a primitive value and then fires an update when it changes.  This functionality on its own is still very useful, and it probably wouldn't be too much of an effort to extend it to non primitive values provided that the state being managed implements IEquateable

Well...selectors also have side effects linked to them when they update. The selector takes in the immutable state object and gets some piece of it out. The FireUpdate is more akin to Observable.next that gets called when the state changes. The selector analog for Feedbacks is the function being passed in to determine the value that goes out when FireUpdate is called. May be taking the analogy too far here...
Thinking about it a little more...I'm wondering if it would be better to add an overload that just takes in a value instead of a func. You could accomplish the same thing , but still maintain the state in the device class.

I have thought about this as well, but I think that passing in Func's gives you more flexibility (especially with the Func<bool, bool> parameter).  I also think that working with funcs as parameters is cleaner and more expressive but no need to go down that rabbit hole.

I would say both...have the ability to fireUpdate(value) and fireUpdate(func)

Not to derail this, but @ndorin 's concerns about thread safety are valid.  We'd need something like the below to deal with it.
public class ThreadsafeBookFeedback
{
  public readonly bool Value;
  public readonly BoolFeedback Feedback;

  public BoolFeedbackState()
  {
    Feedback = new Feedback(() => Value);
  }

 public BoolFeedbackState(value, feedback)
  {
    Feedback = feedback;
   Value = value;
   feedback.SetValueFunc(() => Value);
   Feedback.FireUpdate()
  }

   public static BoolFeedback Reduce(this BoolFeedback state, func<bool> reduce)
   {
     var newValue = reduce();
    return new BoolFeedbackState(newValue, state.Feedback);
   }
}

Is the threadsafe argument valid for Feedbacks at large, or only in the context of this proposed enhancement?

I suggest we have a quick call about this.  After reviewing with @hvolmer I was able to confirm my concern about the original intended function of the Feedback class.
There are definitely quality of life improvements that can be made, but we want to make sure everyone understands why the Feedback is designed as it currently is.

If fireUpdate(func) or fireUpdate(var) is called its still FORCED to run with the absolute latest value. The developer called it to do so. The ability to set a func reference in the feedback still remains as well.
There's nothing stopping a dev from calling SetValueFunc(newFunc) immediately followed by FireUpdate(), what's the difference with FireUpdate(newFunc)?
This is a helper method to throw around primitives. It should be as flexible and accessible as possible IMHO.

I think the difference as Nick proposed it is that passing a func into the FireUpdate call is a one-time thing. That func is used for that specific FireUpdate call and never used again, and a standard FireUpdate call would then result in possibly a different value being sent out.
Using the SetValueFunc -> FireUpdate sequence results in all subsequent FireUpdate calls using the func set through SetVauleFunc until SetValueFunc is used to change it again.

so?

It could be possible that the only time FireUpdate is called its called as FireUpdate(func)...its the developers choice.

Also, for any interested parties, you can join our Zoom call at 2 PM EDT at the link below:
https://pepperdash.zoom.us/j/83548462062?pwd=M2FrdFZXY3BpRkRIek9LbG1zb3Vhdz09

That's 4 EDT, I think.
Trevor Payne, CTS, CCMP-Silver
Software Engineer
PepperDash
www.pepperdash.com
617.206.9807
PepperDash Mobile Control™ - BYOD Crestron Control, no special app required
On Mar 16, 2022 2:03 PM, Andrew Welker @.***> wrote:
Also, for any interested parties, you can join our Zoom call at 2 PM EDT at the link below:
https://pepperdash.zoom.us/j/83548462062?pwd=M2FrdFZXY3BpRkRIek9LbG1zb3Vhdz09
—
Reply to this email directly, view it on GitHubhttps://github.com/PepperDash/Essentials/issues/919#issuecomment-1069497348, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AKQSYOQGWE6I7YYLMYBFIVDVAIWAZANCNFSM5Q4EEVKQ.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you commented.Message ID: @.***>

so?

I was more answering Jason's question of what the difference between using the SetValueFunc -> FireUpdate vs FireUpdate(someFunc) was.
The more I'm thinking about it, the more I'm thinking that the better route is adding a FireUpdate(T value) method. In this scenario, there's no real reason that the FireUpdate method has to go run a Func. If/when something throws an exception in the func that's passed in, figuring out where in the chain, especially for more inexperienced developers, is going to be painful. You get the same benefit of bypassing the func passed in through the constructor, with more readability and easier troubleshooting.

In the original paradigm, If/when the func passed into the constructor throws how would it be any different?

Just to wrap this up and document our discussions:

We will proceed implementing a variation of feedbacks by either wrapping the class or recreating the class but not manipulating the base feedbacks classes.
We will create an interface that describes feedbacks both as they exist today and future iterations.

Also we discussed some criteria for features worth documenting:

New features should be functional
New features should not manipulate core functionality. Its better to wrap or rewrite.
Backwards compatibility must be maintained unless implemented on the new dev breaking changes branches.


ARROW-9550: [Rust] [DataFusion] Remove use of Rc<RefCell<_>> in HashAggregate - DRAFT

So this actually made things marginally slower ... need to look at this some more tomorrow

@jorgecarleitao fyi, maybe this wasn't a good idea after all


Remove Makefile and yaml_source

Work on removing the makefile and yaml_source.
The goal is to not use make for scripty things.

The makefile has been removed but /bin/yaml_source is still being installed by pentagon. This is now provided by other internal tooling and should still be removed.

Makefile is already gone but yaml_source maybe should still be removed?


episode 1: What are GPUs and why are they used in computation?

history
what caused/ motivated GPU-like solutions to initial certain (general programming) problems
why everyone has to get started with GPUs (>95% of supercomputing capacity in near future)

mention also energy efficiency, which is becoming more important every year.
Possible example demostration: VASP study from NSC showing ~9x lower energy consumption when running on GPUs

done


Stunner (jbpm designer NEXT) integration into kie-wb-common.

This is the initial integration of the new jbpm designer, named Stunner, into kie-wb-common.
This code comes from this repo -> https://github.com/romartin/wirez
This PR depends on this one -> https://github.com/droolsjbpm/droolsjbpm-build-bootstrap/pull/289
@manstis Here is the small PR!! :P Lemme know something when possible. Good luck! :)
Thanks!

Jenkins fails due to the KIE BOM is not updated with this https://github.com/droolsjbpm/droolsjbpm-build-bootstrap/pull/289

@romartin I suspect you're going to need to use consistent branch names for Jenkins to be able to compile your PRs "together". droolsjbpm-build-bootstrap branch is called stunner and this one stunner-wb-integration

@jlindop @tsurdilo @csadilek Want to help review? :-)

@manstis oh didnt know that making branches names match will make this PRs compile together... good point. Will rename the branch for the droolsjbpm PR right now htanks!

Hi guys, as @manstis commented, I have reopened the build-bootstrap PR with same branch name -> https://github.com/droolsjbpm/droolsjbpm-build-bootstrap/pull/290

how can I make this PR being rebuilt by Jenkins?

@romartin You need to ask nicely.

Jenkins please retest this.

@manstis hahaha oh good! Thx :)

Oh love that green icon :)

😵
One thing I will ask is to run the code formatter e.g. to get rid of blocks like this with excessive new lines: https://github.com/romartin/kie-wb-common/blob/6ac02b7dd24c8a572d16effad6293288f32b9b8c/kie-wb-common-stunner/kie-wb-common-stunner-client/kie-wb-common-stunner-lienzo/src/main/java/org/kie/workbench/common/stunner/client/lienzo/components/palette/impl/LienzoDefinitionSetPaletteImpl.java#L127
Doing that now (in the first commit) will make sure we have meaningful diffs in the future.

Hi @csadilek @manstis ,
Until geOffrey updates and fixes our code-style setting files (https://github.com/droolsjbpm/droolsjbpm-build-bootstrap/tree/master/ide-configuration), I have tried to create manually the settings and added a new commit. Hopes this style is better now. I have done some cleans and rebased from master as well.
Thanks!

It's failing a test for the wb screens stuff, it does not happens locally, not sure if related, no updates on that modules done from my side

Jenkins please retest this.

Looks good, and the tests and showcase are both working fine.
+1

looks good to me too +1


Markdig.Extensions.SharpCs

I've created an extension for Markdig here:
https://github.com/macaba/Markdig.Extensions.ScriptCs
It essentially allows any arbitrary C# code to output markdown or HTML to the document. The C# can either be in the markdown or the bulk of it can be put into csx files that are referenced from the markdown for better separation of code from content. Readme.md shows a few good examples.
I don't think it's suitable for a pull request into this repo as it has large nuget dependencies so it wouldn't make sense (to me) to pollute core Markdig with these.
However I do want to invite comments and suggestions so I thought I'd open this issue.

Glad that you were able to make your way to get an extension working without much documentation there. I can see interesting usages of your extension, but yeah, it is likely outside of the scope of the core parts. Anyway, thanks for the feedback!


Remove Path usage

This will allow implementation of no_std support in the future.

Coverage increased (+1.6%) to 75.882% when pulling 63baba2f3d2e18a809115db3a51660e76d8a95e7 on philipc:path into 93727def51cadd52c0b4fc99fc54c29faa7ff06a on gimli-rs:master.


License?

We'd like to extend this utility (to wait for a LDS/ CDS update before starting). Would you consider releasing with a permissive license?

Done! MIT.


Sveltev5 date range picker to many updates

Hello, I faced an issue related to sveltev5 when I try to change the dates it just throws too many updates.
I found you're PR with the preview with the preview of the new svelte and there on the tab date range picker you can check the reproduction of this bug https://bits-ui-git-svelte-5-huntabyte.vercel.app/docs/components/date-range-picker
P.S. I understand that the work is still in progress, but I just wanted to point to the problem. Thanks in advance

I haven't touched the date picker for Svelte 5 yet, thanks!


Add refresh lb code to gcp

This adds LB refreshment (ahh) to the GCP provider; specifically it returns load balancers, listeners, pools, and pool members; however it does not currently cover health checks (coming in a subsequent PR).
I introduced some stubbing into the network manager that let me test what I had written without resorting to integration tests/VCR tapes. I'm curious to get feedback on whether this is something we want to maintain in these tests, or if we should instead rely only on VCR tapes.
(Also note I'm not advocating we do stub/mock style tests to replace VCR tests; instead I am proposing that they are helpful in addition to.  The VCR cassettes will be coming either on this PR or a subsequent one (as soon as I learn how to record them that is!))

/cc @erjohnso @blomquisg @agrare

@miq-bot add_label google_provider
@miq-bot add_label enhancement

@miq-bot add_label providers/google

Also would appreciate some advice on how I can avoid the long-line rubocop errors without pulling that string into another variable (which I feel inhibits readability)

Failures look due to VCR tests. Will rerecord and add as part of this PR.
Also tagging @chrisarcand as Greg said he is an rspec expert and can provide advice if possible with the specs.

Added updated VCR tests and re-recoded casette

Addressed feedback by @agrare, @chrisarcand

Tests are looking fine; I'd love to see less or more refined stubbing but I don't see any good examples of how other refresher specs do that (or if they do...) and I'm not familiar enough with the refresh parsers to give a better way to do it now. Leaving final review to @agrare or anyone else more familiar with this area. Let me know if you have any more specific questions for me.

Thanks a log @chrisarcand !

Address @chrisarcand's comments. Thanks for the thorough review Chris, the specs are looking better already!

@Ladas can you take a look and make sure this is in line with other providers' load balancers?

@selmanj You need to add a service model for the Google::NetworkManager::LoadBalancer

@selmanj few nits, otherwise it's awesome :-) @durandom would like to use more stub/mock tests for AWS refresh specs, maybe he can review. :-)
@agrare will we provide @selmanj our VCR env so he can refresh it or will we send him the VCR?

@Ladas I made @selmanj a project admin for our VCR env so he can record them himself


Update AboutUs

Photo and roles and responsibility description for Adam are added.

Codecov Report

Merging #7 (9de1876) into master (24f790c) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master       #7   +/-   ##
=========================================
  Coverage     72.15%   72.15%
  Complexity      399      399
=========================================
  Files            70       70
  Lines          1232     1232
  Branches        125      125
=========================================
  Hits            889      889
  Misses          311      311
  Partials         32       32

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24f790c...9de1876. Read the comment docs.


is consistent process units' transformer IO type necessary?

in process units' transform method, the input and output type are different like

list input list output as LowercaseUnit
https://github.com/faneshion/MatchZoo/blob/b3d61fba9e7120a9216729f02cf8b9127208682d/matchzoo/preprocessor/process_units.py#L55
list input np.ndarry output as WordHashingUnit
https://github.com/faneshion/MatchZoo/blob/b3d61fba9e7120a9216729f02cf8b9127208682d/matchzoo/preprocessor/process_units.py#L329-L332
np.ndarry input np.ndarry output as SlidingWindowUnit
https://github.com/faneshion/MatchZoo/blob/b3d61fba9e7120a9216729f02cf8b9127208682d/matchzoo/preprocessor/process_units.py#L374
even transform one type to another is easy, but is it necessary to require a consistent IO type for these units?

I agree that list and np.ndarray should be consistent.

Thanks for reporting. I fixed this by changing all of them to list.