Condition not being evaluated in Where?!

Maybe I am missing something really obvious or this is a bug?
    IQueryable<Project> projects = _context.Projects.AsQueryable();
    Boolean? condition = null;
    var a = projects.Where(x => true);
    var b = projects.Where(x => condition == null);
    Boolean itemCountIsTheSame = await a.CountAsync() == await b.CountAsync();

Should not itemCountIsTheSame be true? I get 8 projects on "a" and 0 projects on "b"?!
To give some context on my project what I have is something like:
    var result = projects.Where(x => x.IsActive == query.IsActive || query.IsActive == null);

So I filter by Active (true or false) when query.IsActive is not null ...

I did got the SQL for the following 2 queries:
    var c = await projects.Where(x => true).Select(x => x.Id).ToListAsync();

    var b = await projects.Where(x => condition == null).Select(x => x.Id).ToListAsync();

Which was:
SELECT [x].[Id]
FROM [Projects] AS [x]
WHERE 1 = 1

SELECT [x].[Id]
FROM [Projects] AS [x]
WHERE @__condition_0 = NULL

What am I missing?

This is a duplicate of https://github.com/aspnet/EntityFramework/issues/5499. I got the fix ready so this will be fixed for RTM

@maumar Thanks for pointing out ...


O_CLOEXEC not found at make on UP running Ubilinux v3

As indicated in the subject line, I'm getting a compile error of O_CLOEXEC undeclared when building. It first pops up at gpio_chardev.c line 170, func mraa_get_chip_info_by_path.
This is compiling on an Aaeon UP running Ubilinux v3. I can run the cmake portion just fine minus the SWIG and GTest, as I won't be using either.
Given this def is part of POSIX 2008, I'm surprised to have this pop up. Any ideas?

What compiler & version are you using?

@Corusco is this still actual? Please provide the requested information if yes.

Closing for no response.


Subscribe and Fields

When subscribing, fields are not passed to mailerlite
using:
fields = {'country': 'Netherlands'}
new user is in mailerlite but not the field info, @LarryBrid any ideas?

I'm not sure how they are expecting this data, I've emailed them. Their docs show it as:
$subscriber = array(
'email' =><EMAIL_ADDRESS>'name' => 'First name',
'fields' => array(
array( 'name' => 'custom_field_1', 'value' => "field value 1" ),
array( 'name' => 'custom_field_2', 'value' => "field value 2" )
)
);
I tried to send:
{'apiKey': '', 'name': 'test', 'fields': [{'name': 'Country', 'value': 'USA'}], 'resubscribe': 0, 'email'<EMAIL_ADDRESS>'id': ''}
via requests and the fields seem to be ignored. I tried a few other variants as well, all with no luck. I've emailed their support team to ask for clarification on the proper way to format that.

Great, lets wait and see!

OK, I think I have worked out why this isn't working.
https://github.com/kennethreitz/requests/issues/2284
The above details that python/urllib/requests/whatever don't seem to handle nested arrays 'properly' and so the dictionary being serialized into form-encoded data here is ending up pretty mangled.
Specifically, we end up with:
'fields=name&fields=value&apiKey=12345&id=00000&name=test+user&email=foo%40test.com'
which pretty clearly shows why this isn't working.
I'm going to think about a decent way to solve this, but if you have any suggestions please let me know (or just submit a PR).

Hello,
I have come to have the same problem the other days, perhaps, and had to send the nested JSON(dictionaries, etc) as string.
So your data would be:
{'apiKey': '', 'name': 'test', 'fields': """[{'name': 'Country', 'value': 'USA'}]""", 'resubscribe': 0, 'email'<EMAIL_ADDRESS>'id': ''}
Cheers,
Adrian


Show hidden files, and show drive letters options re greyed out

Describe the bug
Show hidden files, Show drive letters in the Files and Folders menu of options are greyed out and 'untogglable'
To Reproduce
Steps to reproduce the behavior:

Go to Settings
Click on Files and Folders item
See Show hidden files option and Show drive letters option greyed out

Expected behavior
The options should have been togglable
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS Version: [e.g. Windows 10 19042.330] (20H2)
App version: [v0.11.0]

They are grayed out because they aren't implemented yet.

okay jaiganeshkumaran good to know and sorry for the inconvenience!


Update p2p framework

Codecov Report

Merging #233 into dev will decrease coverage by 0.14%.
The diff coverage is 1.15%.


Can't ssh into windows instance

rejected: administratively prohibited (SSH is not supported on windows cells)
Do you support ssh into windows cell's instance?

Hi, @JackXuF,
Thanks for asking! We don't currently support SSH access to Windows instances, although the CF Greenhouse team has a story at https://www.pivotaltracker.com/story/show/100162006 to provide it at some point. @sbenario and @benmoss from that team may know more about current plans for support.
Best,
Eric, CF Runtime Diego PM

Yep, making the SSH client work on Windows is a non-trivial amount of work due to the lack of PTY in Windows. We have this in our targets for the future, but it's not currently a top priority.

Closing, as we don't intend to fix this in the near future, and there's work represented in the Greenhouse tracker around making it available eventually.


Use inhibit to suppress alerts

Since Kapacitor is streaming data, I get many alerts when Influx is missing the data.
It will be great to check the cluster state before triggering alerts. Maybe use inhibit to suppress all alerts when the cluster is not receiving data?

Closing this issue as it turns out that this can be done already: https://docs.influxdata.com/kapacitor/v1.5/guides/hierarchical-alert-suppression/#using-the-inhibit-method-to-suppress-alerts


disable fetching alertmanagers on status page in agent mode

Took a shot at fixing https://github.com/prometheus/prometheus/issues/9928. This disables fetching alertmanagers from /status page in agent mode.

Thanks, looks good to me besides the comment! Could you change the branch to merge into to be release-2.32 ("Edit" at the top and then change the target branch), since we merge bug fixes into the latest release branch?

Looks good now, but would be great to add a regression test for this to https://github.com/prometheus/prometheus/blob/main/web/ui/react-app/src/pages/status/Status.test.tsx - that's a snapshot-based test. I think you can just duplicate the few it('should match table snapshot', () => { ... lines with the Agent mode enabled and then update the saved snapshots for that by pressing i when running the web tests locally (see https://jestjs.io/docs/snapshot-testing#interactive-snapshot-mode) via npm run test from the web/ui directory.

Looks good now, but would be great to add a regression test for this to https://github.com/prometheus/prometheus/blob/main/web/ui/react-app/src/pages/status/Status.test.tsx - that's a snapshot-based test. I think you can just duplicate the few it('should match table snapshot', () => { ... lines with the Agent mode enabled and then update the saved snapshots for that by pressing i when running the web tests locally (see https://jestjs.io/docs/snapshot-testing#interactive-snapshot-mode) via npm run test from the web/ui directory.

hmm ok, I tried to create a quick test but it seems like the existing tests cover <StatusContent> component, which gets the useFetch results, after agentMode has been evaluated. I attempted to add a quick test for <Status> but ran into some issues, and I imagine I would need to find a way to mock the results of useFetch? I tried something like this but will have to circle back around on this as it's getting pretty late for me here:
    it('should match table snapshot with agent mode', () => {
      const wrapper = shallow(<Status agentMode={true} />);
      expect(toJson(wrapper)).toMatchSnapshot();
      jest.restoreAllMocks();
    });

Ah, you are right of course. Sorry, didn't see it tested only the inner component. I think it's good enough for now then, but it would definitely be good to add tests for the outer component somehow later.
Will merge for now, thanks! :+1:

thanks @juliusv 🙏


runtime/race: unexpected race when Conn.Close used for synchronization

go version devel +a714470 Wed Sep 27 16:29:18 2017 +0000 linux/amd64
The following program reports a race even though the read of x
cannot happen in parallel with the assignment to x because
we wait for the connection to be closed before reading it.
https://play.golang.org/p/ufvoScCbSm
==================
WARNING: DATA RACE
Read at 0x00c42008a220 by main goroutine:
  main.main()
      /home/rog/src/tst.go:24 +0x288

Previous write at 0x00c42008a220 by goroutine 7:
  main.main.func1()
      /home/rog/src/tst.go:16 +0x7a

Goroutine 7 (finished) created at:
  main.main()
      /home/rog/src/tst.go:14 +0x16d
==================
2017/10/04 16:48:53 1
Found 1 data race(s)
exit status 66

If the Dial and Read were to return errors for whatever reason, you would have a read before the write.

That's not true for Dial - we exit if Dial returns an error, but I added a couple more error checks to make the code clearer. I fixed the link above to point to the new code.

I think you may be asking too much of the race detector.  There is no obvious reason that the two different network connections are related.  I mean, sure, they are, but only if you know that the Dial that created one matches the Accept that created the other.  Only when you know that can you see that the Close of one affects the Read of the other.
CC @dvyukov

@ianlancetaylor Does that apply to any causal connection through a network connection (for example using an httptest.Server and relying on being able to read variables after an HTTP request has replied) ?

To the best of my knowledge, yes.

Interesting; it's not something I'd previously considered. I suspect we have hundreds of potentially race-flagged tests with this issue.

I still see two different issues with the way it is written.

Given that there is no synchronization, the x++ could be moved below the c.Close() by a compiler and be considered equivalent.
You have no guarantee over the value read on line 30. The increment done on line 20 may not be published to the other go routine.

Unless my understanding of how things could work is inaccurate.

Since c.Close() will call into the kernel, I don't think any plausible Go compiler could move the x++ across the call.  Similarly, I think the x++ must be published.  I think that any Go implementation must assume that the kernel may cause a happens-before relationship to be created.  It's true that this is not in the memory spec, but in general Go is not trying to trick the programmer.

Ultimately any system call can synchronize with any other system call (e.g. create a file, another process notices that the dir becomes non-empty and send us a signal, so now creation of the file is somehow synchronized with arrival of the signal). But synchronizing everything with everything has a substantial negative effect in that it masks real data races.
In C++ we do more elaborate logic and e.g. actually track that connection between the pair of fd's returned by pipe and then how that propagates via dup's:
http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/tsan/rtl/tsan_fd.cc?revision=308929&view=markup
But we still don't track relation for sockets, theoretically should be possible to track connections within a process by looking at local/peer adds, but this still won't solve the problem when connection goes through a separate process/machine.
To summarize: I don't see anything simple that we could do for Go to solve the problem. If we are talking about tests, I would suggest to add a separate chan that notifies about completion of handling of request/connection.


Building for x86_64 linux?

I'm tying to build for x86_64 linux, but the released files are always marked with arm64. I have added
[target.x86_64-unknown-linux-gnu]
linker = "x86_64-linux-gnu-gcc"

to src-tauri/Cargo.toml and
with:
  # other properties...
  args: ${{ matrix.platform == 'ubuntu-20.04' && '--target x86_64-unknown-linux-gnu' || '' }}

to .github/workflows/release.yml and can see that tauri build --target x86_64-unknown-linux-gnu is the command run during the build step but still no luck.
What configuration should I add to correctly build targeting x86?

are you sure it's saying arm64 and not amd64? Otherwise i can't imagine why it'd build for arm64, especially since that should fail at some point in the build pipeline.

You're quite right, it says amd!
Terribly sorry for the confusion


Refactor/remove auth components

wip

we'll keep user management here. So, closing this PR and preparing a new one for a better user management usability


Feature Request: Support styling of web pages created by service: webrtc.create_link

I am using the service webrtc.create_link, to cast my video doorbell to a NestHub device.
Currently it is not possible to style the resulting page using the style attribute like it exists for the custom:webrtc-camera dashboard widget.
My concrete use-case is to render a 4:3 aspect ratio camera stream on the 16:9 NestHub screen:
style: 'video {aspect-ratio: 16/9; object-fit: cover;} .mode {display: none}'
When I add the style property to the create_link service description, I get the following error message:
2023-12-11 14:28:50.200 ERROR (MainThread) [homeassistant.components.script.create_camera_link] Create Camera link: Error executing script. Invalid data for call_service at pos 2: extra keys not allowed @ data['style']
Please add the webrtc-camera styling functionality also to the webrtc.create_link service.

I figured out this is already available, but not officially documented:
It is possible to add the style parameters as an encoded GET parameter to the URL.
Eg for the example above, the resulting parameter is:
http://<hassioHostAndPort>/webrtc/embed?url=<generatedUrlParameter>&style=video%20{aspect-ratio%3A%2016%2F9%3B%20object-fit%3A%20cover%3B}%20.mode%20{display%3A%20none}


fix nil pointer

What this PR does:
fix some nil pointer
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

Codecov Report

Merging #517 (e69abd3) into develop (8dc4bd6) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop     #517      +/-   ##
===========================================
- Coverage    54.70%   54.67%   -0.04%
===========================================
  Files          666      666
  Lines        77864    77865       +1
===========================================
- Hits         42596    42569      -27
- Misses       31631    31653      +22
- Partials      3637     3643       +6

Impacted Files
Coverage Δ

pixiu/pkg/config/config_load.go
44.53% <0.00%> (-0.38%)
:arrow_down:

pilot/pkg/serviceregistry/kube/controller/sync.go
75.00% <0.00%> (-25.00%)
:arrow_down:

pkg/config/mesh/kubemesh/watcher.go
59.01% <0.00%> (-11.48%)
:arrow_down:

pkg/kube/inject/watcher.go
48.14% <0.00%> (-8.65%)
:arrow_down:

pkg/kube/controllers/queue.go
55.22% <0.00%> (-7.47%)
:arrow_down:

pkg/istio-agent/xds_proxy_delta.go
46.11% <0.00%> (-5.70%)
:arrow_down:

pilot/pkg/model/addressmap.go
63.23% <0.00%> (-4.42%)
:arrow_down:

security/pkg/nodeagent/sds/sdsservice.go
84.76% <0.00%> (-2.65%)
:arrow_down:

pilot/pkg/xds/adstest.go
66.66% <0.00%> (-1.52%)
:arrow_down:

.../pkg/serviceregistry/kube/controller/controller.go
71.92% <0.00%> (-0.61%)
:arrow_down:

... and 10 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Random binding listeners are removing on unmount

https://github.com/moreartyjs/moreartyjs/blob/master/src/Morearty.js#L702
This chunk of code seems not working as intended. Listeners are not removing properly. Moreover, because listener ids are incremental, random listeners for default binding may be removed. Therefore I think this is highly critical issue.

Thanks, will look into this asap.

@valff, could you please clarify why listener aren't removed properly? And why random listeners may be removed?

@Tvaroh, because all listeners are removed from one default binding, not from binding, to which they are attached. And random listener may be removed, because listener ids may be collided for two distinct bindings.
I propose to store listener remover closures instead of _observedListenerIds. Should I make pull request?

I see this was a regression from 0.7.15. Will create pull request soon.

@valff, thank you so much! Just merged the code. Awesome!

Does current behavior cause some problems?

Thank you for merging! I found that addBindingListener have similar problem when listening to other than default binding. It has strange implementation, and I want to fix it.
Have a question about shouldRemoveListeners(), why we ever need it? If I don't want listerers to be removed, I use binding.addListener(...) instead. I propose to remove this method from API.

Regarding shouldRemove listeners, it protects from cases when multiple components bind to same state section.

Regarding addBindingListener - yep, looks like it needs to be fixed too.

@valff, in which situation listener ids may collide? IIRC, this should be avoided.

What happens when multiple components bind to same section? Isn't it safe to add listeners at the same binding, and removing them independently?
Listener ids may collide in normal and meta bindings. They are not share _sharedInternals.

They are not sharing _sharedInternals.

I see. That's what should be fixed. We're following the wrong path.

Will look into PR a bit later.

@valff, regarding shouldRemoveListeners.
Two components on a page bind to the same state section, and one of them uses addBindingListener. What if another component is removed from the page? Without shouldRemoveListeners it would remove listeners attached to the first component as well (since bindings bound to same path are same object instance).

@valff, regarding shouldRemoveListeners: with your updated implementation this check may be safely removed. Just did it. Thank you!

Release in 0.7.21.


Hosts

Added files for issue #1264
Here is the complete pic of execution

@nwinkler  kindly review this

Closing because no reply

@tbhaxor hey, if you re-opened this and added some tests, pretty sure we can get some attention on this. Thanks!


ML flow call backs fails at missing keys

System Info
Langchain version 0.0.191 , python version 3.9.15
Who can help?
@agola
Information

[ ] The official example notebooks/scripts
[X] My own modified scripts

Related Components

[X] LLMs/Chat Models
[ ] Embedding Models
[ ] Prompts / Prompt Templates / Prompt Selectors
[ ] Output Parsers
[ ] Document Loaders
[ ] Vector Stores / Retrievers
[ ] Memory
[ ] Agents / Agent Executors
[ ] Tools / Toolkits
[X] Chains
[X] Callbacks/Tracing
[ ] Async

Reproduction
following the notebook given at  https://python.langchain.com/en/latest/integrations/mlflow_tracking.html?highlight=mlflow
I just changed the chain from LLM chain to retrieval chain and OpenAI to Azure Open AI
i continuously faced the error KeyError: "None of [Index(['step', 'prompt', 'name'], dtype='object')] are in the [columns]"
But some data is getting logged into ML_flow experiments. like chain_1_start and chain_2_start and their ends respectively.
Expected behavior
To have the necessary data in the ML flow experiment logs and should work without throwing any error.

I have the same error with the retrival chain

I faced the same error:
KeyError: "None of [Index(['step', 'prompt', 'name'], dtype='object')] are in the [columns]"

But realized I wasn't passing callbacks=[mlflow_callback] parameter to the LLM (ex. AzureOpenAI). I was only passing it to LLMChain.
After that I came across this error:
KeyError: "['name'] not in index"

which I've tried fixing it in: https://github.com/hwchase17/langchain/pull/7051


evaluation: results from the resgister to extern python program

Hi,
i am wondering could we directly read the results value from the register to extern python program for a further evaluation?
i notice that in SwitchTree, you counted the number of detected attacks and normal packets based on the port respectively. However, when i prefer to use these values to draw a result figure, i have no idea to input these value directly into the python program. Or can i only manually record them and input into the python?
Thank you~~
Best regards,
Louisa

Hello,
Switchtree is using CLI for control plane. For controlling it using python and possibly reading statistics, you may check p4runtime examples . It shows an example to use python scripts such as mycontroller.py.
For that one will have to make gRPC work as well.
Another way could be to launch the CLI command using a python script and parse the output.
Best Regards,


Templates auto-applied by the note's name

Please select if your request is either something new or an enhancement

[X] Enhancement of an existing Feature.
[ ] Request of a new feature.

Please select the area your request applies to. (Multiple selections are Possible. You can leave blank if you're not sure.)

[X] Lookup - Dendron's Lookup Command

Describe the solution you'd like
Create a template with something like a "noteName", which would be automatically applied when creating a note with that name. (in any stub)
This would help since not only could I use the lookup feature to create a note based on a template, but it would also be automatically applied.

Thank you for the request.
We currently support templating by adding schemas or using Dendron: Insert Note. See: https://wiki.dendron.so/notes/861cbdf8-102e-4633-9933-1f3d74df53d2/
Would these be sufficient for your usecase?

Yes I know, this is more of an improvement than a new feature itself,
basically have it be automatically applied to a note, depending on its name.
For instance creating a note named "todo", would apply the "todo" template.
(configurable whether or not to do this, in the template)
On Mon, Jan 24, 2022, 02:54 Mark Hyunik Choi @.***>
wrote:

Thank you for the request.
We currently support templating by adding schemas or using Dendron:
Insert Note. See:
https://wiki.dendron.so/notes/861cbdf8-102e-4633-9933-1f3d74df53d2/
Would these be sufficient for your usecase?
—
Reply to this email directly, view it on GitHub
https://github.com/dendronhq/dendron/issues/2257#issuecomment-1019665066,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACM7UVAQII7TG4TDDRVXT6DUXS5MZANCNFSM5MR2UQKA
.
You are receiving this because you authored the thread.Message ID:
@.***>


Model Group gpt-4o-2024-08-06

I've worked out a model version called gpt-40, but it doesn't seem to work and I'm still using the default model

It says "incorrect API key" in your error message


More Force Merge Threads by default

Is your feature request related to a problem? Please describe.
Today Force Merge threads are always 1 per node . Even if the nodes have lots of CPU, the number of force merge threads is limiting .
Describe the solution you'd like
Use ScalingExecutorBuilder instead of FixedExecutorBuilder which caps the max threads based on number of processors
Describe alternatives you've considered
Use yaml to update the count of Force Merge threads .

@gbbafna The force merges can interfere with the active write/ read traffic if no. of threads are increased. Do you have plan to benchmark?

Yes Shweta, we will definitely need to do benchmarks on this one.


[C#] Unexpose GodotSharp

Based on discussion in chat
As an optional addition I exposed the is_runtime_initialized method as a static method on CSharpScript, as CSharpLanguage isn't exposed that was the best place I could think of, if we do need to expose it in the first place
Alternatively, for an even hackier approach than the existing one we could create a dummy class in the editor docs to handle this, haven't tried that out though, but it should be possible

Fixes: https://github.com/godotengine/godot/issues/91458

I don't think we need to re-expose is_runtime_initialized. I'm a bit worried about breaking users currently using this method but they'd be broken by this change anyway.

Thanks!


Tip to avoid node heap out of memory issues

With large captures, you can have node directly invoke dprof with options to allow use of more memory.
gzcat dprof.json.gz | node  --max_old_space_size=4096 /usr/local/lib/node_modules/dprof/bin/dprof.js

What can we do to improve this? Why is the capture itself not a problem?
/cc @Fishrock123

Yeah I've come across this too, I'm not sure why it happens on the parsing end either.

The the json file is only parsed to  check the dprof version. Now that we have an online visualizer that should actually be on the client side.

Do you have a test script I can try?.
I tried our recursive test which generates very big dump files:
'use strict';
setImmediate(function recursive(remaining) {
  if (remaining === 0) return;
  setImmediate(recursive, remaining - 1);
}, 368999);

Anything bigger than 368999 and the script outputs:
/Users/Andreas/Sites/node_modules/dprof/dprof.js:213
    fs.writeFileSync('./dprof.json.gz', zlib.gzipSync(JSON.stringify(data)));
                                                           ^

RangeError: Invalid string length
    at JSON.stringify (<anonymous>)
    at process.writeDataFile (/Users/Andreas/Sites/node_modules/dprof/dprof.js:213:60)
    at emitOne (events.js:96:13)
    at process.emit (events.js:188:7)

The uncompressed dumpfile is 256 MB, but that parses fine when running node bin/dprof.js.

@AndreasMadsen here ya go!
dprof.json.gz
Babs:orov-cockpit brian$ gzcat dprof.json.gz | dprof
server ready on http://localhost:3343

<--- Last few GCs --->

   56773 ms: Mark-sweep 1374.5 (1434.3) -> 1374.5 (1434.3) MB, 2443.5 / 0 ms [allocation failure] [GC in old space requested].
   59164 ms: Mark-sweep 1374.5 (1434.3) -> 1374.5 (1434.3) MB, 2391.0 / 0 ms [allocation failure] [GC in old space requested].
   61597 ms: Mark-sweep 1374.5 (1434.3) -> 1374.5 (1434.3) MB, 2432.5 / 0 ms [last resort gc].
   63963 ms: Mark-sweep 1374.5 (1434.3) -> 1374.5 (1434.3) MB, 2366.4 / 0 ms [last resort gc].

<--- JS stacktrace --->

==== JS stack trace =========================================

Security context: 0x912fb0c9e59 <JS Object>
    1: get [/usr/local/lib/node_modules/dprof/node_modules/babel-traverse/lib/path/index.js:~76] [pc=0x294ec2c9f791] (this=0x196bcc347639 <JS Function NodePath (SharedFunctionInfo 0x31b18efbfbf9)>,_ref=0x2e48c9849951 <an Object with map 0xd9aa07c2649>)
    2: node [/usr/local/lib/node_modules/dprof/node_modules/babel-traverse/lib/index.js:~94] [pc=0x294ec23724e9] (this=0x230a3c52ec91 <JS Functio...

FATAL ERROR: CALL_AND_RETRY_LAST Allocation failed - JavaScript heap out of memory
Abort trap: 6

Works for me, what node version are you running?

Ah, I missunderstod. I though the error happened on initialization, but it actually happens when http://localhost:3343 is opened. Thus it is not the JSON.parse part that causes the error.
This gave me the hunch that maybe it was babelify that choked on parsing the dump file. I think this was correct, after setting babelify up to ignorering the dump file I can't reproduce the error.
Could you try out dprof v0.18.2 and see if it works?

Nice. I ran into this with very large npm output.


4.5.0 coldstaking - qt wallet transaction record display shows amount in/out of coldstaking address incorrectly

The transactions shown in the following screen are (i) transfer to self owned coldstaking address of 59.8 m NAV (10/12/18 12:21), and (ii) transfer to third party address of 10,000 NAV (10/12/18 12:22).

Display issues:

Amount for transactions out of the coldstaking address will show the amount incorrectly. Looks like it is input tx value + output tx value and no subtraction of change amount.
Transaction amounts into the coldstaking address owned by the user will not be classified as payments to self
Transaction amount into the coldstaking address owned by the user will show the full amount and not be net off (debit - credit)

This is only an issue when the wallet holds both spending and staking keys.


Better schema documentation in inspector panel

The Overture explore site can be a great way to better understand the Overture schema in practice. I envision a deeper integration with the Inspector Panel where users can view the documentation for a select entity and its attributes, either via inline tooltips, expandable sections, or links to the overture schema.
Assuming the schema is published alongside each release, we may be able to download it and display the descriptions inline (e.g. https://github.com/OvertureMaps/schema/blob/main/schema/buildings/building.yaml#L4). As an MVP, we should at least dynamically update the schema link at the bottom of the panel to the correct theme based on the selected entity.

For reference, here's how the iD editor does this:


Pass URLs to Telegram API directly

Downloading files to temporary files to re-upload them to Telegram is not necessary.
Telegram accepts URLs (and file_ids) in all the media keys (photo, video, document, etc.)

@knu Hey buddy, mind dropping in and checking out this PR?


docs: clear up section about Next APIs

Summary
I noticed docs about SSR with Next are a little bit outdated, and missing
some potentially juicy approaches using direct schema execution.
Set of changes

adjust docs to assume { ssr: false} is the default
add an explicit section for { ssr: true }
move note about _app static optimisation to section with { ssr: true }
add section about server-only code and direct schema execution when using getServerSideProps and getStaticProps

Might need to do another push for the CI to run


add extending OutlinedInputProps by SelectProps (#31208)

[ ] I have followed (at least) the PR section of the contributing guide.

According to docs Select should have OutlineInput props available. Functionality works, but typescript coverage was lacking.

Closes https://github.com/mui/material-ui/issues/31208

👍 I think adding notched?: boolean to the SelectProps interface should be enough (no need to extend the OutlinedInputProps again because it extends StandardProps).

I see your point, however, according to docs Props of the OutlinedInput component are also available.
If OutlinedInput props were ever to change, then Select props would fall out of sync. I see that now only notched is what's different, but both InputProps and OutlineInputProps extends StandardProps<InputBaseProps> I don't see a harm in that.
Let me know what you think and I'll add tests in meantime.

If OutlinedInput props were ever to change, then Select props would fall out of sync. I see that now only notched is what's different, but both InputProps and OutlineInputProps extends StandardProps<InputBaseProps> I don't see a harm in that.

Yep, you are right about it. Thanks for clarifying.


springify the CellSetFormatter with a factory

see http://ask.analytical-labs.com/questions/666/springify-the-cellsetformatter for original discussion
write a CellSetFormatter factory in saiku-web, which requires moving interface ICellSetFormatter in saiku-web.

I will make a pull request on that issue


uncaught TypeError: a.taget.className.indexOf is not a function

I think it's happening in the bookmarks function, but even with all plugins disabled, I'll sometimes get
uncaught TypeError: object is not a function.
I'm not asking for you to fix this, I'm asking for guidance on debugging. Is there a developers forum outside of issues?

The exception is in gen_dashboard.js - part of stock intel.
There's something they do - probably as part of the 'botguard' protection, that causes an exception to be thrown on the first link clicked after a page load. Not much we can do about this really...


Incus UI - Creating an instance with a manually exported image

From Incus UI, creating an instance with an image manually created from another instance fails with the error "Instance creation failed - Image not provided for instance creation" even though the image is properly selected. This problem does not occur if the image source is "Linux Containers".

Duplicate of #36
A fix has landed in the daily package, it will make its way into stable next time a new version is pushed (probably later this week).


AC-3 audio support + Chromecast subtitles

What version of WebTorrent Desktop? (See the 'About WebTorrent' menu)
Version 0.17.2 (0.97.2)
What operating system and version?
Windows10
What did you expect to happen?
Decode AC-3 audio and show subtitles on TV
What actually happened?
Don't decode AC-3 or display subtitles
I really love WebTorrent but it would be great if it could decode AC-3 audio, because most movies use it, and it would be great if subtitles could appear on TV
Thanks

AC3 support can be tracked here: #350

Subtitle support for chrome cast would be awesome!

Chromecast subtitle support can be tracked here: https://github.com/feross/webtorrent-desktop/issues/530
Closing as duplicate.


Revoke access to unpublished recipe

What I have done

Remove the user's access to the unapproved recipes (except those they created).
Remove the favorite button from the unapproved recipe detail page.
Prevent a POST request trying to toggle the favorite of the unapproved recipe.

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Files with missing lines
Coverage Δ

webpage/models.py
100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes


Fix for incorrect insufficient base fund errors on Kucoin

Description
When running Kucoin on a new traded pair, the log would have errors of insufficient base funds.  This was caused by the additional Kucoin code originally added.  Now added an extra check to prevent the error message.
Neither the original problem or the fix affect the actual trades, just an error in the logs and now not there if this is why the check was called.
Fixes # (issue)
Type of change
Please make your selection.

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
[ ] This change requires a new dependency
[x] Code Maintainability / comments
[ ] Code Refactoring / future-proofing

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.
Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added pytest unit tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules
[x] I have checked my code and corrected any misspellings

could you please update CHANGELOG and advance the version in README?


Polymer 3

This needs to be run through the modulizer and pushed to npm.

TL;DR

Jumping straight to lit-element (Polymer 4)
Early alpha coming beginning of January (hopefully)
Work has started on the new elements, you can see it here: https://github.com/admwx7/am-time-picker
Ownership will be moved under https://github.com/CommunityElements

The long of it, the modularizer script came back with thousands of errors in this repo, after some investigation the effort to resolve was quite high.  That combined with the known tech debt and the fact it will have to get reworked to support something like lit-html anyway, it makes more sense to just jump into that now.  I can also start utilizing some things I've been working with lately such as TS to get some better docs and such.
I've been collaborating with a few other members in the polymer community for a while now and we've been tossing around the idea of an org on github to supplement element support and drive better quality standards.  We created a channel on the Polymer slack and I will be moving the new element under that org on github.  The goal of this is to ensure this element will continue to get fixes and support even when I get swamped with life.
I've gotten a start on the project with a temporary naming and location (https://github.com/admwx7/am-time-picker) once it gets to an alpha stage I'll rename it and move it under the org I mentioned above.  I have a month of vacation for the holidays starting this coming Friday, aside from a few days of travel my goal is to hit an early alpha before January.


Need to add CODEBUILD_RESOLVED_SOURCE_VERSION to a file during buildspec.yml (or possibly Dockerfile).

Purpose: Each job has a list of versions of software (APBS, PDB2PQR, job_control?, Python?) used to generate the data
Created/Maintained: During CodePipeline build step and create/update new file
Job Services would look for S3://web/$info/versions.json file and include it in the job_status.json file


8810M Not Connecting. Unknown Error Occured or Connection Failed, depending on port.

I have enabled Automation mode using the installation guide for this model. I have successfully connected a different model to my Home Assistant instance. IP confirmed correct by comparing MAC on device to MAC on network using arp-a command. IP Address pings. Device communicates with Aprilaire mobile app. Attempted ports 7000 and 8000. Field data reads "(usually 7000 or 8000)", wondering if there is a way to determine which port(s) can be tested.

Attempted 7001 and 8001, both resulted in an immediate "Unknown Error Occurred" error. Port 8000 is the only one that loads for ~30 seconds, and reads Connection failed. Port 8000 was used for my other Aprilaire device successfully.

@hollywoodscotty Unfortunately I have not seen anything documented from Aprilaire about which port is used consistently. Their documentation on these aspects is really poor, to the extent that I don't even have a concrete list of which devices are supported (Aprilaire themselves couldn't provide a list).
If it fails immediately, then that almost definitely is not the right port. If it hangs for 30 seconds, then that means that it connected to the port but that it isn't responding with some data (the timeout is 30 seconds).
If you haven't already, I recommend power cycling the thermostat, as they can get in a state where they don't respond to sockets at all.
If it still fails after power cycling, then you can try enabling debug logging in HA and sending the output. Set this in your configuration.yaml, restart Home Assistant, wait till everything is initialized and then clear the log. Then go re-add the device and copy the resulting debug lines from your log. You can comment out the log and reboot once you have logs for the first minute or so after adding.
logger:
default: error
logs:
custom_components.aprilaire: debug

Any updates on this? I own the same model.

This integration has been merged to Home Assistant core and will not receive future updates here.


[9.102.x-prod] SRVLOGIC-480: [CLI] Help text of gen-manifest has typo in --custom-ge…

…nerated-manifests-dir parameter example
https://issues.redhat.com/browse/SRVLOGIC-480

@domhanak good catch!

@domhanak thanks, merging this one. Just please remember to send it upstream too if not already.


Fatal Issue!!!

System Details

OS: Linux Mint 21 x86_64 with Kernel: 6.2.0-34-generic
Thorium Version M117.0.5938.157

Problem
Whenever I lunch the Thorium throught Terminal, or via AppImage. I'm always meet with "Illegal instruction (core dumped)"
Screenshots

pplicable, add screenshots to help explain your problem.
Additional Notes
I just discovered your browser and want to use at daily basis. :)

Alex says in the Thorium description that it is built with AVX, and that it requires 2nd generation Intel or newer (released in 2011). However, that's not the only thing to worry about. Your processor has Atom-series cores, not desktop cores. Atom-series cores didn't get AVX for a very long time, until 2020/2021 I believe. So your processor cannot run Thorium as it is built.

Please try the SSE3 version and check again to see if you can use the Thorium browser properly
https://github.com/Alex313031/Thorium-Special/releases/tag/M117.0.5938.157
@IssamSY

Thank you @gz83 for suggesting the SSE version. It work just fine, and can use it.
And @jdpatdiscord for clarifying the reason for the error.


PNG images throw exception.

Need to test PNG locally.
EXCEPTION processing image01.png: System.NullReferenceException: Object reference not set to an instance of an object.
   at DTStamp.DTStamp.Main(String[] args)

Removed support for PNG images. Too complicated to support.


Cache response for store details

Currently, showing the groupDetail page fires duplicate requests to the backend, one for each pickup in the list.

This is the code in question:
https://github.com/yunity/foodsaving-frontend/blob/master/client/app/components/_pickupList/pickupList.controller.js#L37
Could be optimized by caching the promises or the resolved promises in an object.

We're now down to one request per store as of #297. Could be improved further, but doesn't warrant an issue right now.


Google not working

Bot is ready!
DBM MODS (Node Module Installer v2.1) Attempting To Install Node Module: 'google-it'. Please wait...
DBM MODS (Node Module Installer v2.1): Node Module 'google-it' does not exist!
Command failed: npm install google-it --loglevel=error --save
DBM MODS (Node Module Installer v2.1) Attempting To Install Node Module: 'google-it'. Please wait...
DBM MODS (Node Module Installer v2.1): Node Module 'google-it' does not exist!
Command failed: npm install google-it --loglevel=error --save
Error with Event "Google Search", Action #2: Error: Cannot find module 'google-it'
Can some one help? Problem is still there on beta

The module which Google Search used is now broken.
Also that error you are getting has nothing to do with the mod.
You just need to run the bot using cmd

It's also better if you ask for support in the servers instead of here, click here


Bliink Bid Adapter Doc - Optional video url

🏷 Type of documentation

[ ] new bid adapter
[ ] update bid adapter
[ ] new feature
[ ] text edit only (wording, typos)
[ ] bugfix (code examples)
[ ] new examples

📋 Checklist

[x] Related pull requests in prebid.js or server are linked -> https://github.com/prebid/Prebid.js/pull/10290
[ ] For new adapters check submitting your adapter docs

Thanks for the docs update @Niass . Please always link the related pull request from prebid.js or prebid server. It speeds up the review process 🙏

Hello, thanks for your review and sorry for missing that part 🙏🏼


doc: Improve Docs + Add Branded Dokka

Uploading the resulting docs pages will be done by GitHub Action, as there is no reasonable way to do it via Gradle

This won't build until the gradle plugin has been completed


get_mut doesn't seem to work

I'm not sure what happened here:
extern crate hyper;
use hyper::header::Headers;
use hyper::header::{ContentLength, ContentType};
use hyper::http::RawStatus;
use hyper::method::Method;
use hyper::mime::{Attr as MimeAttr, Value};

fn main() {
    let mut x = Headers::new();
    x.set_raw("Content-Type", vec!["text/plain;charset=shift-jis".bytes().collect()]);

    println!("old: {:?}", x); // charset is shift-jis
    if let Some(old_ct) = x.get_mut::<ContentType>() {
        println!("old old_ct: {:?}", old_ct); // still shift-jis
        let mut new_ct = old_ct.clone();
        for param in (new_ct.0).2.iter_mut() {
            if param.0 == MimeAttr::Charset {
                println!("old param {:?}", param); // shift-jis
                *param = (MimeAttr::Charset, Value::Ext("hi".into()));
                println!("new param {:?}", param); // hi
            }
        }
        *old_ct = new_ct;
        println!("new old_ct: {:?}", old_ct); // hi
    }

    // at this stage I'd expect the header to have changed. But it hasn't.
    println!("new get: {:?}", x.get::<ContentType>()); // hi
    println!("new get raw: {:?}", x.get_raw("content-type")); // shift-jis again??
    println!("new: {:?}", x); // shift-jis again??
}

I guess the mixture of raw and non-raw methods is breaking it, but I'm not sure. Does set_raw create two copies of the thing -- one typed, one untyped?

I guess the issue is that typed_mut doesn't remove the header from the raw headers when inserting a typed one.

Ah, this is a bug. The invariants I've been enforcing are: if you get an immutable view (raw or typed), and it doesn't exist, it will generate it and then give it to you (either serializing a typed, or parsing a raw). However, if you get a mutable reference, because you can cause them to be out of sync, it should obliterate the other stored value. So, get_mut should kill the raw part. I believe it does this correctly when you do headers.set(Foo), so it's a hole in get_mut.


CCM governance recommendations and overview page

Added two new markdown files to cover Governance recommendations and one for the overview page.
Updated Set up cost visibility for AWS with permissions for governance

https://6462406c30002a20219fa209--harness-developer.netlify.app/docs/cloud-cost-management/use-ccm-cost-governance/asset-governance/gov-overview

https://6462406c30002a20219fa209--harness-developer.netlify.app/docs/cloud-cost-management/use-ccm-cost-optimization/ccm-recommendations/governance

https://6462406c30002a20219fa209--harness-developer.netlify.app/docs/cloud-cost-management/getting-started-ccm/set-up-cloud-cost-management/set-up-cost-visibility-for-aws#cloud-asset-governance

https://6462406c30002a20219fa209--harness-developer.netlify.app/docs/cloud-cost-management/use-ccm-cost-optimization/optimize-cloud-costs-with-intelligent-cloud-auto-stopping-rules/load-balancer/create-load-balancer-aws - @riyasyash, this one sneaked in from another branch, but anyway needs to be published.

@charanya-j Reviewed for lambda code update section doc

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app

Updated comments and created another pull request and merged
https://github.com/harness/developer-hub/pull/1815


CONAN_BASE_PROFILE_BUILD is not correctly passed to Docker

Description of Problem, Request, or Question
ConanMultiPackager(use_docker=True) doesn't correctly handle build profile settings. If I set CONAN_BASE_PROFILE_BUILD=my_build_profile, CPT adds
-e CPT_PROFILE_BUILD="@@include(my_build_profile)@@@@[settings]@@@@[options]@@@@[env]@@@@[build_requires]@@@@"

to Docker command line, but the build fails inside Docker because my_build_profile does not exist there:
 File "c:\python39\lib\site-packages\conans\client\profile_loader.py", line 132, in read_profile
    return _load_profile(text, profile_path, default_folder)
  File "c:\python39\lib\site-packages\conans\client\profile_loader.py", line 151, in _load_profile
    profile, included_vars = read_profile(include, cwd, default_folder)
  File "c:\python39\lib\site-packages\conans\client\profile_loader.py", line 119, in read_profile
    profile_path = get_profile_path(profile_name, default_folder, cwd)
  File "c:\python39\lib\site-packages\conans\client\profile_loader.py", line 107, in get_profile_path
    raise ConanException("Profile not found: %s" % profile_name)
conans.errors.ConanException: Profile not found: my_build_profile

Another problem is that in the absence of CONAN_BASE_PROFILE_BUILD CPT passes empty settings for the build profile:
-e CPT_PROFILE="@@include(default)@@@@[settings]@@arch=x86_64@@build_type=Release@@compiler=Visual Studio@@compiler.runtime=MD@@compiler.version=15@@os=Windows@@[options]@@@@[env]@@@@[build_requires]@@@@"
-e CPT_PROFILE_BUILD="@@include(default)@@@@[settings]@@@@[options]@@@@[env]@@@@[build_requires]@@@@"

That breaks my build that worked before with CPT 0.35.0. Why not pass the same settings in CPT_PROFILE_BUILD as in CPT_PROFILE if CONAN_BASE_PROFILE_BUILD is not set?
Environment Details

Conan Package Tools Version: 0.37.0
Conan version: conan 1.43.0

I'm having a similar issue. I'm trying to force docker to use a build profile that would force build_requirements to be in Release mode even if the recipe itself is built in Debug mode (for 1) performance reasons, and 2) working around an issue I have with m4 that throws debug asserts https://github.com/conan-io/conan-center-index/issues/8920)
The idea to pass a build profile like so
include(default)
[settings]
build_type=Release

I've been uselessly trying to patch conan-package-tools to correctly pass CONAN_BASE_PROFILE_BUILD to docker but I haven't managed to make it work. I have opened a draft PR with my failed attempts at https://github.com/conan-io/conan-package-tools/pull/596 in the hope that it'll spark a conversation. #596 will be either cleaned if possible, or just closed if not.

I also have encountered some problems with the changes introduced in commit 830e84a79c2c32b57824a227bc88b95406c3944d.
It forces Conan to always be called with a build profile. This changes some of the internal behavior of Conan and prevents the imports() method from copying files of private requirements of my top-level package (I am not sure if this might be a bug in Conan or if it is desired behavior, haven't looked into it, yet)
I have a implemented a workaround that removes the "default" base profile when creating the Docker runner. This should now behave like the non-Docker path (pull request #604)

The Release 0.38.1 includes the hotfix the PR #604. Please, update your local copy: https://pypi.org/project/conan-package-tools/0.38.1/


fetch error when upgrading from node.js 16 to 18

Environment

Operating System: Darwin
Node Version:     v18.15.0
Nuxt Version:     3.5.3
Nitro Version:    2.4.1
Package Manager<EMAIL_ADDRESS>Builder:          vite
User Config:      modules, experimental
Runtime Modules<EMAIL_ADDRESS>Build Modules:    -

Reproduction

clone this repo https://github.com/moebiusmania/atmmi-info-ui and install dependencies
run it with Node.js 16, you should see a populated page on localhost:3000 and no error on console
switch to Node.js 18 and re-run the dev server
on localhost:3000 you will see placeholder values and on console many 500 error coming from server side fetch

Describe the bug
Hello fellow devs, I have this small toy project built with Nuxt since early phases of v3 https://github.com/moebiusmania/atmmi-info-ui its a simple app that scrape data from a website using API routes and then some components consumes that same APIs and render the data on page.
I've used Node.js 16 since the beginning since there were some errors on Node.js 18, but trying again now I'm noticing this issue still lives. Since Node.js 16 will reach EOL within few months I would like to understand what's happening, I've browsed some similar issues and all of the proposed solution are not working.
Its really few lines of code that works perfectly on 16 and suddenly breaks on 18 with no apparent reason or explanation, by logging the fetch error I get something like this:
  statusCode: 500,
  fatal: false,
  unhandled: false,
  statusMessage: undefined,
  data: {
    url: '/api/traffic',
    statusCode: 500,
    statusMessage: '',
    message: 'fetch failed (https://www.atm.it/it/Pagine/default.aspx)',

which doesn't help much especially coming from the previous scenario where everything works.
Does anyone have a clear idea of what's breaking the fetch requests between the two environments?
thanks in advance
Additional context
No response
Logs
No response

It's the ofetch library. Apparently it has some problems with node 18. According to this issue and a few others, and from personal experience, downgrading to node 16 fixes the issue.
It's sad cause basic server-side data fetching examples from the documentation also fail.

Can you please check ofetch version installed?

@pi0 I'm able to reproduce this and it's   oftech "version": "1.0.1"
@moebiusmania for a workaround you can use native fetch directly for node versions that are above 18.
const getPage = async (): Promise<string> => {
  const response = await fetch(ENDPOINT, {
    method: "GET",
    mode: "cors"
  })
  return response.text()
}

export { ENDPOINT, getPage }

It's possible this is not ofetch but an issue with the native node fetch implementation it uses on Node 18+. It's possible this has been fixed in newer Node versions. Would you try with the latest Node 20.2?

It's possible this is not ofetch but an issue with the native node fetch implementation it uses on Node 18+. It's possible this has been fixed in newer Node versions. Would you try with the latest Node 20.2?

I can reproduce the same issue in node 20 too

Update: So my problem suddenly magically disappeared. I have zero clue what made it work. It now works on both node 18 and 20. I'm using nvm with vscode on linux so don't take my word for it.
I was looking forward to actually finding the solution for everyone and I'm a little sad that I can no longer reproduce it. I think the problem was there also on my windows laptop to I'll check if I can reproduce it there.
I'll be here in case anyone needs more info or cooperation. cheers.

@oMoMa thanks for sharing about ofetch library, regarding your first comment: I've kept Node.js 16 up to now to avoid the issue, but as stated here https://github.com/nodejs/release#release-schedule on September v16 will reach EOL, so it would be better to find a solution now or give more visibility about it to Nuxt team.
regarding the following comments: yep, the other problem is that it looks like there isn't a universal solution so far.
@pi0 it's v1.0.1, the one that got installed when creating a Nuxt project
@Hebilicious thanks a lot, I've tried using regular fetch as you suggested but now the error seems to have moved to the undici package when using both v18.x and v20.3.x
{
"url": "[/api/status](http://localhost:3001/api/status)",
"statusCode": 500,
"statusMessage": "",
"message": "fetch failed",
"stack": "
at Object.fetch (node:internal/deps/undici/undici:11413:11)\nat process.processTicksAndRejections (node:internal/process/task_queues:95:5)\nat async getPage (./.nuxt/dev/index.mjs:758:20)\nat async ./.nuxt/dev/index.mjs:819:16\nat async Object.handler (./node_modules/h3/dist/index.mjs:1255:19)\nat async Server.toNodeHandle (./node_modules/h3/dist/index.mjs:1330:7)
"
}

@danielroe unfortunately this happens also on latest v20.3.x, although as I wrote above the error stack is different
thanks everybody for the support so far, but just to make clear my intention: I don't care about my project working or not, as I said its a toy that I'm using to play and learn with Nuxt, but I'm fearing that at this point everyone that encountered this issue did just got fine with Node.js v16.x like me and didn't brought it up. With EOL date approaching this could become quite a pain when bigger project will migrate to newer versions of Node.js.

@oMoMa thanks for sharing about ofetch library, regarding your first comment: I've kept Node.js 16 up to now to avoid the issue, but as stated here nodejs/release#release-schedule on September v16 will reach EOL, so it would be better to find a solution now or give more visibility about it to Nuxt team.
regarding the following comments: yep, the other problem is that it looks like there isn't a universal solution so far.
@pi0 it's v1.0.1, the one that got installed when creating a Nuxt project
@Hebilicious thanks a lot, I've tried using vanilla fetch as you suggested (and updated the repo) but now the error seems to have moved to the undici package when using both v18.x and v20.3.x
{
"url": "[/api/status](http://localhost:3001/api/status)",
"statusCode": 500,
"statusMessage": "",
"message": "fetch failed",
"stack": "
at Object.fetch (node:internal/deps/undici/undici:11413:11)\nat process.processTicksAndRejections (node:internal/process/task_queues:95:5)\nat async getPage (./.nuxt/dev/index.mjs:758:20)\nat async ./.nuxt/dev/index.mjs:819:16\nat async Object.handler (./node_modules/h3/dist/index.mjs:1255:19)\nat async Server.toNodeHandle (./node_modules/h3/dist/index.mjs:1330:7)
"
}

@danielroe unfortunately this happens also on latest v20.3.x, although as I wrote above the error stack is different
thanks everybody for the support so far, but just to make clear my intention: I don't care about my project working or not, as I said its a toy that I'm using to play and learn with Nuxt, but I'm fearing that at this point everyone that encountered this issue did just got fine with Node.js v16.x like me and didn't brought it up. With EOL date approaching this could become quite a pain when bigger projects will migrate to newer versions of Node.js.

That's strange, I'm unable to reproduce the issue with node 18+ and native fetch.

Update: So my problem suddenly magically disappeared. I have zero clue what made it work. It now works on both node 18 and 20. I'm using nvm with vscode on linux so don't take my word for it. I was looking forward to actually finding the solution for everyone and I'm a little sad that I can no longer reproduce it. I think the problem was there also on my windows laptop so I'll check if I can reproduce it there. I'll be here in case anyone needs more info or cooperation. cheers.

Interesting, the problem magically just appeared for me despite not changing anything to my repro repo, it just started appearing

@Hebilicious so you're telling me that the issue is not the fetch code (beside throwing error messages that could use more details) but on the fetched website server? 🤦 Welcome to the public services of the "most advanced" italian city 😄
well, I gues it explains some of the "magical behaviors
Thanks a lot for your dedication and solution to this issue! this could be a nice snippet for Nuxt docs here https://nuxt.com/docs/api/utils/dollarfetch#fetch because honestly I wouldn't been able to get to this by myself.

@Hebilicious Thank you so much for looking into this ❤

@Hebilicious so you're telling me that the issue is not the fetch code (beside throwing error messages that could use more details) but on the fetched website server? 🤦 Welcome to the public services of the "most advanced" italian city 😄
well, I guess it explains some of the "magical" behaviors
Thanks a lot for your dedication and solution to this issue! this could be a nice snippet for Nuxt docs here nuxt.com/docs/api/utils/dollarfetch#fetch because honestly I wouldn't been able to get to this by myself.

Yes, this is an aspx page, so there's using .net / IIS (ie Microsoft tech), which is notorious to have a critical security issue if you're not using the latest versions.
And yes from the Nuxt/ofetch side the only issue is that the error message doesn't show the actual reason (which I think we should find a way to fix)
I'm not sure if that should go in the docs, as this dispatcher fetch parameters  has nothing to do with Nuxt, and it appears to be undici only (ie node), so this solution probably wouldn't work on other runtimes (deno/bun/workerd ...) ?

Why the issue was closed? the problem is still present.
Only server-side $fetch not working
FetchError: fetch failed (*)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async $fetchRaw2 (file:///*/frontend/node_modules/ofetch/dist/shared/ofetch.d438bb6f.mjs:215:14)
    at async $fetch2 (file:///*/frontend/node_modules/ofetch/dist/shared/ofetch.d438bb6f.mjs:239:15)
    at async Object.handler (file:///*/frontend/.nuxt/dev/index.mjs:675:24)
    at async Object.handler (file:///*/frontend/node_modules/h3/dist/index.mjs:1285:19)
    at async Server.toNodeHandle (file:///*/frontend/node_modules/h3/dist/index.mjs:1360:7)

@affinage-digital it has been closed because in the end it was an issue related to the fetched server configuration and the fact that Node.js v18 use a different implementation of the fetch API that does throw error in these situations, so it was unrelated to Nuxt itself.

Update: So my problem suddenly magically disappeared. I have zero clue what made it work. It now works on both node 18 and 20. I'm using nvm with vscode on linux so don't take my word for it. I was looking forward to actually finding the solution for everyone and I'm a little sad that I can no longer reproduce it. I think the problem was there also on my windows laptop so I'll check if I can reproduce it there. I'll be here in case anyone needs more info or cooperation. cheers.

Interesting, the problem magically just appeared for me despite not changing anything to my repro repo, it just started appearing
The good news is that it seems to not be related to Nuxt.
Running this file with node directly (without Nuxt)
const ENDPOINT = "https://www.atm.it/it/Pagine/default.aspx"
const getPage = async () => {
  const response = await fetch(ENDPOINT, {
    mode: "cors",
    headers: { "Content-Type": "application/json" }
  })
  return response.text()
}
console.log(getPage())

node:internal/deps/undici/undici:11522
    Error.captureStackTrace(err, this);
          ^

TypeError: fetch failed
    at Object.fetch (node:internal/deps/undici/undici:11522:11)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async getPage (/Users/hebilicious/GitHub/atmmi-info-ui/test.js:3:20) {
  cause: [Error: 005ED20402000000:error:0A000152:SSL routines:final_renegotiate:unsafe legacy renegotiation disabled:../deps/openssl/openssl/ssl/statem/extensions.c:922:
  ] {
    library: 'SSL routines',
    reason: 'unsafe legacy renegotiation disabled',
    code: 'ERR_SSL_UNSAFE_LEGACY_RENEGOTIATION_DISABLED'
  }
}

Doing some digging, it appears to be related to misconfigured IIS servers, and node refusing to connect to them after 18.
A node specific workaround would be to do something like this :
import { Agent } from "undici"
import crypto from "node:crypto"

const ENDPOINT = "https://www.atm.it/it/Pagine/default.aspx"
const getPage = async () => {
  const response = await fetch(ENDPOINT, {
    mode: "cors",
    dispatcher: new Agent({
      connect: {
        rejectUnauthorized: false,
        secureOptions: crypto.constants.SSL_OP_LEGACY_SERVER_CONNECT
      }
    })
  })
  return response.text()
}

@danielroe went to the bottom of this, we should definitely try to throw better error messages, the reason appears clearly when using node directly, but is hidden when it fails through ofetch.
@moebiusmania For your use case you should use this :
import { Agent } from "undici"
import crypto from "node:crypto"

const ENDPOINT: string = "https://www.atm.it/it/Pagine/default.aspx"
const getPage = async (): Promise<string> =>
  $fetch(ENDPOINT, {
    mode: "cors",
    dispatcher: new Agent({
      connect: {
        rejectUnauthorized: false,
        secureOptions: crypto.constants.SSL_OP_LEGACY_SERVER_CONNECT
      }
    })
  })

export { ENDPOINT, getPage }

work for me


gPRC label

Do we want a gPRC label for issues like we have for SignalR?
We could have a bot apply it for all gRPC docs.
cc @scottaddie  @BrennanConroy @JamesNK @JunTaoLuo

It's really easy. I'll take care of it today.

All gRPC issues can be found at: https://github.com/aspnet/AspNetCore.Docs/issues?utf8=✓&q=is%3Aissue+sort%3Aupdated-desc+label%3AgRPC+


Function is not being inlined

We are trying to find out why a function is not being inlined in some cases.
The callsites look like this:
,$getExistingServiceForWindow$$module$src$service$$(this.getWin(),"extensions").loadExtension

…and the function itself looks like:
function $getExistingServiceForWindow$$module$src$service$$($win$$7$$,$id$$7$$){return $win$$7$$[$id$$7$$]}

Most calls of the function are being inlined.

Found out the reason: It was because of the no inlining if temps have to be introduced into scopes that have functions.


PLSS Points toggle

Add a map tool to toggle the PLSS points on/off so users can view the underlying line data sets more clearly, when needed.

like the one that's already there?

Doh!


fix: transpile server not work

Types of changes

[x] Bug fix (a non-breaking change which fixes an issue)
[ ] New feature (a non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Description

Checklist:

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly. (PR: #)
[ ] I have added tests to cover my changes (if not applicable, please state why)
[ ] All new and existing tests are passing.

Codecov Report

Merging #4338 into dev will increase coverage by 0.05%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##              dev    #4338      +/-   ##
==========================================
+ Coverage   91.49%   91.55%   +0.05%
==========================================
  Files          56       56
  Lines        1857     1870      +13
  Branches      468      469       +1
==========================================
+ Hits         1699     1712      +13
  Misses        148      148
  Partials       10       10

Impacted Files
Coverage Δ

packages/config/src/options.js
94.73% <ø> (-0.04%)
:arrow_down:

packages/webpack/src/config/server.js
100% <100%> (ø)
:arrow_up:

packages/webpack/src/config/base.js
95.83% <100%> (+0.44%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae8dc96...5ba2cb5. Read the comment docs.


1874 itemized distribution updates

Resolves #1874
Description
Add updates to the Itemized Distributions sections of the dashboard.

Sort by total distributed instead of item name.
Add total on hand column.
Add indicator if the total on hand is below the minimum quantity of an item.

Type of change

New feature (non-breaking change which adds functionality)

How Has This Been Tested?
Verified that the correct values are showing up on the page.
Screenshots

Thanks!


documentation

I've added a documentation section with a focus on writing as opposed to reading. I thought this would be a doss, but turns out it's hard. Happy to be beaten over the head with the opinions of others.

Thoughts:

[ ] Change title to "Writing documentation", then #64 will precede this section as it is explaining how to find and read documentation.
[ ] Add "reading and finding documentation" to prerequisites
[ ] Maybe don't contextualise the first paragraph in "research", perhaps "learning and research" (keep the audience open as possible)
[ ] 'functional' to functional (formating IDGAF really)
[ ] Make 'the code below solves Bragg's law for an orthorombic crystal to determine the Bragg angle associated with a given miller plane' bold
[ ] make the # symbol code case
[ ] # define miller indicies to # define miller indices
[ ] Are you wanting comments and docstrings to be two separate sections?
[ ] "emphasis" to "emphasise"
[ ] "arguemnts" to "arguments"

I like this

[ ]  Are you wanting comments and docstrings to be two separate sections?

My thinking here was that docstrings require an appreciation of functions, but I don't feel like an understanding of basic documentation should necessitate understanding functions, so I separated them out. I'm not strongly attached to this way of working though.

I personally would be happy with them together, just change the name of that subsection to "Docstrings" or something and add functions to the overall prerequisites (this part will definitely be coming after the functions part in the structure of the book so it should be fine).

Happy for you to merge this @alexsquires


Unibabel.bufferToBase64 seems not to be working.

This is an interactive consloe session in Firefox 42.0:
fr.readAsArrayBuffer(file_input.files[0])
undefined

fr.result
ArrayBuffer { byteLength: 585 }

Unibabel.bufferToBase64(fr.result)
""

It may be that you have to convert from ArrayBuffer to TypedArray first.
var arr = new Uint8Array(fr.result);
Unibabel.bufferToBase64(arr);

I don't handle native binary conversions in the library on purpose - just Arrays and TypedArrays (because they have similar enough APIs to not require special code).

Thank you very much! I just assumed I could use an ArrayBuffer directly.

Yeah... the Browser APIs are... weird...


Create Clusterrole allowing pv actions

This clusterrole is then applied to the service-account via a cluster-role binding such that worker script-pods may operate on persistent-volumes, as is required during a helm upgrade.

@rain-on I think we can close this?

overtaken by events.


Add handling of voice messages

The bot should be able to receive voice messages and decode these to text.
Thus using some speech2text library/model to transcribe the message.
Some solutions could either encompass automatic speech recognition models from huggingface such as openai/whisper-large.
There are also some python libraries which propose methods to do the same with tutorials: https://thepythoncode.com/article/using-speech-recognition-to-convert-speech-to-text-python.

[x] HuggingFace's whisper models
[ ] Other HuggingFace model archs
[ ] APIs (e.g. Google Cloud, Whisper API, IBM, etc.)

models


Write and publish public API docs for Preview 1 APIs

[ ] Each public member must have accompanying API docs. Snippets are not required for preview 1
[x] Build a process for publishing API docs to the repo's gh-pages site
[ ] Publish the final Public API docs

Closing in favor of individual issues: #372, #373, and #374.


fix: Issue with sql pool

Fixes the issue with sql pool by adding the missing dependencies.
Fixes the issue: #180

@tuncaytunc-zf do you know, why this wasn't catched by any tests? Is it even possible to fetch this by any kind of test?

@tuncaytunc-zf do you know, why this wasn't catched by any tests? Is it even possible to fetch this by any kind of test?

Fully agree. I also wanted to create a few black box tests for the image (which can be only additional tests to what you mentioned) and what limits me is that with the image you have to use azure vault and I can not mock it because of hardcoded domain name in AzureVault.java
.vaultUrl("https://" + keyVaultName + ".vault.azure.net")

If no security reason is against this, I would propose to make this configurable.

@tuncaytunc-zf do you know, why this wasn't catched by any tests? Is it even possible to fetch this by any kind of test?

Probably this bug was made by Gradle migration. Unfortunately our tests don't cover so much, in our business-test we just test one image "edc-controlplane-postgresql-hashicorp-vault". This is not the only bug we couldn't catch, there were many others too which could be caught when we would have more tests in place.

Of course we need more tests but starting such a fundamental discussion on such a minor bugfix makes no sense for me.
We should have had such a discussion before we made a lot of fundamental changes in our code where we fixed them afterwards and still fixing, this is not the only one we have fixed. It seems for me we didn't test our fundamental changes so much. I think we could spend more time on making our products more stable instead of refactoring running/stable code were we introduce a lot of new bugs, since we really don't have so much tests. Instead of implementing new tests we have already started to refactor the existing ones :smiley:


minimum permissions required for user assigned identity?

There is no mention of exactly what permissions are to be given to the user assigned identity which is assigned to run deployment scripts under.
I have sample (just hello world) above failing with error like below:
The client  with object id  does not have authorization to perform action 'Microsoft.Resources/subscriptions/providers/read' over scope '/subscriptions/' or the scope is invalid. If access was recently granted, please refresh your credentials
Can you document exact minimum permissions that identity must have? We try to keep least permissions so it will be good to know minimum requirements here.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b5c4c8c5-7757-a969-5800-17f2f2312649
Version Independent ID: 9ced8dd5-43ca-6d1f-c054-842299db8327
Content: Use deployment scripts in templates - Azure Resource Manager
Content Source: articles/azure-resource-manager/templates/deployment-script-template.md
Service: azure-resource-manager
Sub-service: templates
GitHub Login: @mumian
Microsoft Alias: jgao

I see the requirements as:
"A user-assigned managed identity with the contributor's role to the target resource-group"
Is there any way this can work without contributor permissions at resource group level?

@GitHubSachin Thanks for your comment! We will review and provide an update as appropriate.

@GitHubSachin - It is a requirement for right now.  However, we are changing the authentication model.  Once the new model is implemented, we will update the article.
#please-close


release 1.2.26/v.2.0.23 with a CI red ?

Why do you release a gem 2.0.23 with a red ci on Postgresql ?
On commit : https://github.com/Faveod/arel-extensions/commit/10e6f418c167f956817d68d9748c8da86c222dac
The Github Action/CI report :
https://github.com/Faveod/arel-extensions/runs/4380304716?check_suite_focus=true
..........................E

Error:
the to_sql visitor#test_0019_should be possible to use as on anything:
NameError: uninitialized constant Arel::TableAlias
    /home/runner/work/arel-extensions/arel-extensions/lib/arel_extensions.rb:207:in `as'
rake aborted!
Command failed with status (1): [ruby -w -I"lib:lib:test" -I"/opt/hostedtoolcache/Ruby/2.7.2/x64/lib/ruby/gems/2.7.0/gems/rake-13.0.1/lib" "/opt/hostedtoolcache/Ruby/2.7.2/x64/lib/ruby/gems/2.7.0/gems/rake-13.0.1/lib/rake/rake_test_loader.rb" "test/visitors/test_to_sql.rb" ]

Tasks: TOP => test:to_sql
(See full trace by running task with --trace)
    /home/runner/work/arel-extensions/arel-extensions/test/visitors/test_to_sql.rb:292:in `block (2 levels) in <module:VisitorToSql>'

rails test home/runner/work/arel-extensions/arel-extensions/test/visitors/test_to_sql.rb:285

...S.........

Hi Cyril,
Sorry, some bad mishandling from me.
Sincerely sorry for the inconvenience. Previous and next gems should work fine.


WebExt: Add alternative Fetch 'SendLogs' function to support changes to webextensions

Chrome MV3 has moved to service workers, abandoning the historical "Background Pages". As such this will not support XMLhttpRequest, favoring Fetch.
UserALE's SendLogs function uses XMLhttpRequest. As such, we'll need to the WebExt to use it's own SendLogs function using Fetch.
https://developer.chrome.com/docs/extensions/mv3/intro/mv3-migration/#background-service-workers
Mozilla is adopting MV3 in full to support cross-browser compatability

@poorejc -- per:  https://github.com/apache/incubator-flagon-useralejs/pull/286 this issue can be closed, is that right?

Correct, this is closed, although the MV3 madness is far from done with us.


Implement unit testing

This PR addresses issue #12, by extracting parsing functionalities into a new class library called RegAutomation.Core, and implementing a test suite (RegAutomation.Core.Tests) for it. Functions in the Parser class in RegAutomation have been ported to ParserBase in RegAutomation.Core, and there is a new generic class MacroParser<T> which is inherited by parsers for each reg macro. There is also a parser that inherits directly from ParserBase, being IncludeParser, which doesn't need to parse macros.
I also made some minor modifications to the implementation of enum parsing and binding (using the enum key directly instead when binding each enum key's value, so constant expressions can be processed automatically without having to evaluate them in C#).
Right now, if you're opening from solution.sln, simply using dotnet test (or in Visual Studio, "Run All Tests") would trigger build.bat, wasting a lot of time running scons before the tests are actually run, so you'd want to run the test project directly instead.
There's a new solution RegAutomation.sln that does not contain example_project and ProjectLauncher that you can use to avoid this issue altogether.

I still haven't figured out how to set up GitHub Actions  to automate tests but that can be a future goal. (Though that might be better handled here rather than in my fork) I'm also looking into porting the binding generation code into Binder classes so we can test those as well.

Good work, as usual!
Just curious, why do we need a new .sln for RegAutomation?
Notes:
Project and file structure

RegAutomation.sln RegAutomation/ RegAutomation.Core/ and RegAutomation.Core.Test/ could be moved into a new RegAutomation folder, to keep it all contained in one place.
In RegAutomation.Core.csproj and RegAutomation.Core.Test.csproj,  should be set to the .temp folder.
Basically we should try to keep the main folder as clean as possible.

Code

The test classes could be renamed to improve readability, ex Test_ClassParser". Similar to how the Pattern classes are named.
Most newly added .cs files have a bunch of unused using directives that should be removed.
Maybe add some text about how to set up testing in a readme

Just curious, why do we need a new .sln for RegAutomation?Just curious, why do we need a new .sln for RegAutomation?

In solution.sln, running unit tests using Visual Studio's "Run All Tests" command (which corresponds to the CLI command dotnet test) would trigger the entire solution's build process before actually running the tests. This means you'll have to spend several minutes waiting for scons to finish building C++ every time you want to run tests, and can be frustrating. This can be side-stepped by running tests in RegAutomation.Core.Tests directly (in Visual Studio, right click the Tests project and run tests from the context menu), but it isn't as ergonomical, and this setup wouldn't work from the CLI (as dotnet test will always build the solution first before testing), making it harder to automate tests later on.

In RegAutomation.Core.csproj and RegAutomation.Core.Test.csproj, should be set to the .temp folder.

These aren't auto-generated files, so I don't think it's a good idea to put them into .temp folder.
Aside from that, these all sound like good ideas. I'll take care of them later.

Should be all fixed now. Please let me know if there's anything else that needs fixing.

Nope, looks really good 👏
One reason for compilation slowdown is that we're not excluding the correct source folders in the SConstruct recursive glob, meaning that the entire folder structure of RegAutomation and ProjectLauncher (including temp files) is included for every compile units. I've made some changes
to prevent this


Grammatical Errors in README.md and contributing.md

The idea behind this repo is awesome but I got few grammatical errors in the README.md and contributing.md. I request you to assign me this issue. Thank you

@oreo-gif I would insist you to first make those changes and open a Pull Request, reviewing after which I will give you labels and points.

The idea behind this repo is awesome but I got few grammatical errors in the README.md and contributing.md. I request you to assign me this issue. Thank you

Done!!

Can I work on this?

@ambivert-sam Open a new issue and this task is already done. Check for tasks that are not done on a new thread.


Code Quality: Appended Legacy to the existing storable implementations

Resolved / Related Issues
To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

Closes #

Steps used to test these changes
Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

Open Files app

Why not use [Obsolete("")] attribute instead?

I added that too and they need to be renamed to other names because my new storable would be named to WindowsStorable, which is powered by Windows Shell API instead of System.IO or WinRT Storage API and because of that what File Explorer can explorer can be explored through my new WindowsStorable.
Never mind that it is named NativeStorable, I changed my mind:

03066096000

16505


Hotfix/citation utils

Fixes a number of smaller bugs related to the citation utilities around observational datasets, and updates the MF data sources in all data files.

Docs build failed due to upstream changes to ssptools package name (astro-ssptools). This is fixed in #210, not a problem here.


Version 2.0.3 has significant performance issues

Upgrading to 2.0.3 causes code generation to take something like 10x more time.

👋 Hello @bsrz ,
thank you for raising the awareness about the performance issue.
Could you please provide a little more context, what is the exact issue - to be able to understand and investigate, because I cannot think of anything from the top of my head - which template format do you use, swift compiler version etc.
Please provide as many details as possible,
Thank you 👍🏻

@art-divin apologies, I should have included more information.
Here's an example, we generate a ton of tests:
$ sourcery --version
2.0.2

$ time bundle exec fastlane generate_all_tests
[✔] 🚀
+---------------------------+---------+-------------------------------------------------------------+
|                                           Used plugins                                            |
+---------------------------+---------+-------------------------------------------------------------+
| Plugin                    | Version | Action                                                      |
+---------------------------+---------+-------------------------------------------------------------+
| fastlane-plugin-appcenter | 2.1.0   | appcenter_codepush_release_react, appcenter_fetch_devices,  |
|                           |         | appcenter_fetch_version_number, appcenter_upload            |
+---------------------------+---------+-------------------------------------------------------------+

[11:37:47]: -------------------------------------------------------------
[11:37:47]: --- Step: Switch to ios generate_accessibility_tests lane ---
[11:37:47]: -------------------------------------------------------------
[11:37:47]: Cruising over to lane 'ios generate_accessibility_tests' 🚖
[11:37:58]: Cruising back to lane 'ios generate_all_tests' 🚘
[11:37:58]: ------------------------------------------------------------
[11:37:58]: --- Step: Switch to ios generate_designsystem_tests lane ---
[11:37:58]: ------------------------------------------------------------
[11:37:58]: Cruising over to lane 'ios generate_designsystem_tests' 🚖
[11:38:01]: Cruising back to lane 'ios generate_all_tests' 🚘
[11:38:01]: --------------------------------------------------------
[11:38:01]: --- Step: Switch to ios generate_snapshot_tests lane ---
[11:38:01]: --------------------------------------------------------
[11:38:01]: Cruising over to lane 'ios generate_snapshot_tests' 🚖
[11:38:13]: Cruising back to lane 'ios generate_all_tests' 🚘
[11:38:13]: ----------------------------------------------------------
[11:38:13]: --- Step: Switch to ios generate_styleguide_tests lane ---
[11:38:13]: ----------------------------------------------------------
[11:38:13]: Cruising over to lane 'ios generate_styleguide_tests' 🚖
[11:38:13]: Cruising back to lane 'ios generate_all_tests' 🚘

+------+-------------------------------------------------+-------------+
|                           fastlane summary                           |
+------+-------------------------------------------------+-------------+
| Step | Action                                          | Time (in s) |
+------+-------------------------------------------------+-------------+
| 1    | default_platform                                | 0           |
| 6    | Switch to ios generate_accessibility_tests lane | 0           |
| 7    | Switch to ios generate_designsystem_tests lane  | 0           |
| 8    | Switch to ios generate_snapshot_tests lane      | 0           |
| 9    | Switch to ios generate_styleguide_tests lane    | 0           |
+------+-------------------------------------------------+-------------+

[11:38:13]: fastlane.tools finished successfully 🎉
bundle exec fastlane generate_all_tests  32.57s user 5.10s system 132% cpu 28.337 total

With 2.0.2 it takes about 33 seconds.
Upgrading to 2.0.3:
$ sourcery --version
2.0.3

$ time fl generate_all_tests
[✔] 🚀
+---------------------------+---------+-------------------------------------------------------------+
|                                           Used plugins                                            |
+---------------------------+---------+-------------------------------------------------------------+
| Plugin                    | Version | Action                                                      |
+---------------------------+---------+-------------------------------------------------------------+
| fastlane-plugin-appcenter | 2.1.0   | appcenter_codepush_release_react, appcenter_fetch_devices,  |
|                           |         | appcenter_fetch_version_number, appcenter_upload            |
+---------------------------+---------+-------------------------------------------------------------+

[11:41:33]: -------------------------------------------------------------
[11:41:33]: --- Step: Switch to ios generate_accessibility_tests lane ---
[11:41:33]: -------------------------------------------------------------
[11:41:33]: Cruising over to lane 'ios generate_accessibility_tests' 🚖
[11:47:00]: Cruising back to lane 'ios generate_all_tests' 🚘
[11:47:00]: ------------------------------------------------------------
[11:47:00]: --- Step: Switch to ios generate_designsystem_tests lane ---
[11:47:00]: ------------------------------------------------------------
[11:47:00]: Cruising over to lane 'ios generate_designsystem_tests' 🚖
[11:47:38]: Cruising back to lane 'ios generate_all_tests' 🚘
[11:47:38]: --------------------------------------------------------
[11:47:38]: --- Step: Switch to ios generate_snapshot_tests lane ---
[11:47:38]: --------------------------------------------------------
[11:47:38]: Cruising over to lane 'ios generate_snapshot_tests' 🚖
[11:53:57]: Cruising back to lane 'ios generate_all_tests' 🚘
[11:53:57]: ----------------------------------------------------------
[11:53:57]: --- Step: Switch to ios generate_styleguide_tests lane ---
[11:53:57]: ----------------------------------------------------------
[11:53:57]: Cruising over to lane 'ios generate_styleguide_tests' 🚖
[11:54:06]: Cruising back to lane 'ios generate_all_tests' 🚘

+------+-------------------------------------------------+-------------+
|                           fastlane summary                           |
+------+-------------------------------------------------+-------------+
| Step | Action                                          | Time (in s) |
+------+-------------------------------------------------+-------------+
| 1    | default_platform                                | 0           |
| 5    | Switch to ios generate_accessibility_tests lane | 0           |
| 6    | Switch to ios generate_designsystem_tests lane  | 0           |
| 7    | Switch to ios generate_snapshot_tests lane      | 0           |
| 8    | Switch to ios generate_styleguide_tests lane    | 0           |
+------+-------------------------------------------------+-------------+

[11:54:06]: fastlane.tools just saved you 13 minutes! 🎉
bundle exec fastlane generate_all_tests  654.49s user 54.57s system 93% cpu 12:34.93 total

With 2.0.3 it takes about 13mins.
I'm attaching the templates we are using:
templates.zip

Thank you for providing the info!
There were many bug fixes done and additional features implemented in 2.0.3, so it is quite hard to pin-point, ones that I can think about are !1172 !1179 !1169 !1186 but I can be mistaken here.

@krzysztofzablocki excuse me for pinging, do you have any idea where to dig here?
I might suggest the following:

add a way to debug generated code compilation time
output that log in a readable format

But apart from that, any other options?

Can we get numbers with benchmark flag? That way we'll get info which phases/templates are costly

I run through some numbers in one of my larger projects and it seems to be swifttemplate related issue, for me 2.0.2 vs 2.0.3 looks like this:
Cached scan: 1.08s vs 1.07s
Cached swiftemplate:  0.24s vs 18.7s
Basically looks like one of the changes to Swift templates broke caching so they rebuild each time, which is very expensive since it's actually compiling them

Nice, thank you for checking, I might already have enough material to investigate 🕵🏻
Would be nice to have a unit test for this so I would be able to investigate and fix, otherwise it is a bit over my head, those templates at this point still 👀

@art-divin all of SwiftTemplate logic should be isolated to SwiftTemplate.swift file, in the render method there is some logic to resolve cache or build clean so I assume something changed related to that

@art-divin any updates on this?

Hey @bsrz ,
thank you for asking 👍🏻
I am quite busy at the moment, but I am processing this issue in the back of my head anyway.
I'll update you once I'll fix this (my favourite type of bug 🐞  ).

Update
I have dug into SwiftTemplate.swift file, and indeed, the way cacheKey was calculated before #1163 was that includedFiles collection was empty on consequent runs, whereas after #1163, that collection always contains file paths.
 var cacheKey: String? {
        var contents = code

        // For every included file, make sure that the path and modification date are included in the key
-       let files = includedFiles.map({ $0.absolute() }).sorted(by: { $0.string < $1.string })
+       let files = (includedFiles + buildDir.allPaths).map({ $0.absolute() }).sorted(by: { $0.string < $1.string })
        for file in files {
            let modificationDate = file.modifiedDate?.timeIntervalSinceReferenceDate ?? 0
            contents += "\n// \(file.string)-\(modificationDate)"
        }

        return contents.sha256()
    }

@k-o-d-e-n do you have any insight on why did you need to change files collection in this method? What did you intend to accomplish and what was not working with the original version?
Thank you 🙏🏻

Update
Because of the aforementioned change in the logic of calculating cacheKey hash, the following issue occurs:

buildDir path includes all files in .build folder, and thus, cacheKey depends on the build folder contents
buildDir contains files like master.swiftdeps, .swiftsourceinfo, main.swift.o, DWARF/SwiftTemplate, build.db, context.bin, which change every time a build is performed (I suppose timestamp is used in these files in one way or another).
Due to this change, hash of the key does not match and "previous" cache get deleted instead of being reused

Possible solutions

Revert the logic to the original, probably losing functionality @k-o-d-e-n relied upon for his SPM support integration
Ignore master.swiftdeps and other dynamic files from the contents of buildDir folder.
Ignore all files except under SwiftTemplate/2.0.3/Sources folder, i.e. ignore all files under .build folder

I lean towards the second option, because it should still support what was expected before, both providing good cache and SPM support, albeit I am unsure why exactly this change was required.
I have tried Solution # 2 and it works with caching.
@krzysztofzablocki do you have any idea which solution is the best option to move forward?
Thanks 🙏🏻

I use external dependencies to build a template. After changing the code in the project, the next time you run Sourcery, so it is necessary that the project is rebuilt.
If it has such a serious impact on performance, then this change could be removed. But your code snippet already uses the modification date instead of the file content, this should probably solve the problem.
Yes, and of course it was necessary to exclude .build folder.
Thank you and sorry for this trouble.

Thank you for your response, @k-o-d-e-n !
Great that you have provided an insight.

If it has such a serious impact on performance, then this change could be removed. But your code snippet already uses the modification date instead of the file content, this should probably solve the problem.

In fact, it does not. I probably took a Sourcery 2.0.2 version of that logic, and I tried both approaches - only solution was to exactly exclude the dynamic pieces from .build folder.
I suspect that due to dynamism it is indeed better to ignore .build folder contents for cacheKey calculation.

Thank you and sorry for this trouble.

Not an issue at all, thank you for your contribution! 🤝

I use external dependencies to build a template. After changing the code in the project, the next time you run Sourcery, so it is necessary that the project is rebuilt.

As far as I can see, you can leverage from using --cacheDisabled flag. Including folders according to new logic is unfortunately unstable, i.e. brings inconsistent results between runs, sometimes hash is the same, sometimes it is not the same.
So I would need to revert this change and advise to use --cacheDisabled flag because it would provide exactly the same behaviour as it is now in version 2.0.3.

@art-divin appreciate all the help and work on this! 🙌


swift 3.0

What is your question!

(Sorry for the exclamation point. Autocorrect.)

there is no swift 3.0 support in your lib, can it be added?
2017-02-24 14:45 GMT+02:00 Rob Napier<EMAIL_ADDRESS>
(Sorry for the exclamation point. Autocorrect.)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/RNCryptor/RNCryptor/issues/238#issuecomment-282282940,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AG1VMH4giBwHLZOMR1NYgXq1QhBoyJ_yks5rftEHgaJpZM4MK-gF
.

The latest version of RNCryptor only supports Swift 3. Why do you think there's no Swift 3 support?

when in Installing RNCryptor (5.0.1) using cocoa pods i get message

i did that with new, empty project, maybe you just forgot to tag new version for cocoapods

I believe this is tagged. Are you seeing this problem still?


add multiple os to matrix strategy

Attempting to test on ubuntu, windows, and mac...

Run Rscript -e 'cmdstanr::check_cmdstan_toolchain(fix = TRUE)'
Installing mingw32-make with Rtools40
The C++ toolchain required for CmdStan is setup properly!
Run Rscript -e 'cmdstanr::install_cmdstan(version = "2.35.0", cores = 2)'
Error: Error: unexpected numeric constant in "cmdstanr::install_cmdstan(version = 2.35.0"
Execution halted
Error: Process completed with exit code 1.

The remaining issue is with R 4.1 and is very odd. It looks to be due to the way that windows on that version of R only is interpreting strings?

Note this is currently pinned to a fixed release but needs to be changed back to the rolling release once that has been updated

@kaitejohnson I think cmdstanr wise this is now working and is "stable". The mac dependency installation issue is a odd one. I haven't seen the package that is causing the issue before.

Can you describe briefly what you changed here @seabbs ?

I updated the rolling release of install-cmdstan to use the gh cli with a GITHUB secret rather than using the API directly with a API secret. I also switched to using javascript rather than custom bash and powershell across OS's to increase stability.
The last change I needed to make in order to get this working with R 4.1 and windows (i.e it already worked on the latest release) was to be careful about the use of " and ' quotes. Apparently windows sometimes treated these interchangeable (but only when used in one order).
Its not relevant here but I also added support for installing cmdstanr in the action if its not present in the calling action. I tried to do this in R but couldn't get it to only install R if not present vs all the time (mostly due actually neededing to try and detect the user having called setup-r in the wrapper step vs R (as the built in R can't be used to install packages).
The code changes here were almost entirely exploratory and should now be mostly set back to what you had. I found this still failed on mac but that this failure was unrelated to cmdstan (its something in your dependencies that I have never seen before).

Wow thank you @seabbs. I'll pretend I understood 50% of that.
I think I am in favor of the rolling release so we internally know when breaking changes are introduced (if I am understanding correctly), even
Looks like the ruleset names got updated because these all ran.

Note also that all windows VM seem very slow at downloading cache objects which makes them run slower than they otherwise would. This is new behaviour as far as I am aware and so will hopefully be transient.

@dylanhmorris I now can't seem to change the names of the checks anywhere -- I thought it was in the ruleset but it is not an option I am seeing...

@dylanhmorris I now can't seem to change the names of the checks anywhere -- I thought it was in the ruleset but it is not an option I am seeing...

I already did that, but for future reference:
Settings > Rules > Rulesets > (click on the ruleset to modify)
then scroll to "Branch rules"; find "Require status checks to pass", and click on "Show additional settings'