Request feature to support self-signed cert for cert validation

In file https://github.com/dynatrace-oss/dynatrace-gcp-monitor/blob/master/k8s/helm-chart/dynatrace-gcp-monitor/values.yaml, there are following lines:

requireValidCertificate: if true function requires valid SSL certificates when communicating with Dynatrace cluster
may be used to bypass SSL certificates errors when traffic is proxied through Active Gate with self-signed certificate.
Allowed values: "true"/"yes", "false"/"no"
requireValidCertificate: "true"

Could please add feature to support self-signed certificate as following? Thanks.

set requireValidCertificate as"true".
add a new variable like "selfSignedCert" which accept PEM format cert, or variable like "selfSignedCA" which accept PEM format CA cert(so multiple certs signed by this CA can be validated).
Once dyntrace-gcp-monitor pod is running and talk to Dynatrace ActiveGate which has cert as "selfSignedCert" or has cert signed by "selfSignedCA", it can accept the self-signed cert.

AFAIK, that would depend on the AG's acceptance, not only up to this integration. Please go to DT community for this request: https://community.dynatrace.com/t5/Dynatrace-product-ideas/idb-p/DynatraceProductIdeas


spellcheck/deps: bump diff to 3.5.0

GitHub says that there's a vulnerability in the version of diff within spellcheck/ on master, so let's upgrade it.

🤷♂


Augmenting telemetry metrics metadata with process information

Sometimes people may want to send their metrics based on some parameter that is external to the metric. For example, multi-tenant applications may want to segregate their data in someway.
Generally speaking, the way to do this is by attaching some metadata in the process dictionary. We could do our own book keeping on telemetry but maybe the simplest approach is to have something like :logger_metadata that retrieves the data from Erlang's logger and automatically adds it to the metric?
I am not sure this is the best way to go (especially because it is not decided yet if Elixir will merge its metadata with Erlang's) but I thought I would open this up for discussion.

automatically adds it to the metric

Do you mean adding it to the set of avaialble tags, i.e. merging it with event metadata?

Yes, something like logger_tags maybe?
José Valimwww.plataformatec.com.br
http://www.plataformatec.com.br/Founder and Director of R&D

I'm only wondering what happens if the same key is found in both event metadata and logger_tags - which one should tak precedence? IMO logger_tags should override metadata, because if we want to rely on the procdict, we usually also control it, so we can always rename the key so that there are no conflicts.

Agreed. But yeah, I would wait a bit until we unify logging metadata in the
Elixir front too.
José Valimwww.plataformatec.com.br
http://www.plataformatec.com.br/Founder and Director of R&D

Hm, I've considered using logger metadata for opencensus tags, maybe we should. I think the main reason to not was that span context doesn't fit well in logger metadata. We set logger metadata for each span context but formatted to what you'd expect in logs, not the actual span context record which has integers not strings. So we are messing with the pdict anyway. But for tags it may make sense to just use logger metadata, especially if telemetry_metrics will want to grab from there.


code --install-extension hangs forever on macOS

VSCode Version: 1.15.1 41abd21afdf7424c89319ee7cb0445cc6f376959
OS Version: macOS 10.10.5 (14F2511)

Steps to Reproduce:
code --install-extension vscodevim.vim
Hangs at
$ code --install-extension vscodevim.vim
Found 'vscodevim.vim' in the marketplace.
Installing...
(node:75765) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 1): TypeError: this._state.then is not a function
(node:75765) DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

Also happens for other plugins, like iGN97.fuse-vscode
I'm able to install plugins just fine from the GUI.

Same as this: https://github.com/Microsoft/vscode/issues/32381

Thanks @decoomanj. Duplicate of #32381


fix: Resolve security issues

:tada: This PR is included in version 3.0.13 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Crash when no permission to attachment

Expected behavior
K9 displays a toast message that it can't read the attachment
Actual behavior
K9 crashes
Steps to reproduce

Try sharing a GPX track in OSMAnd
Pick k-9
Crash

This is due to a bug in OSMAnd, but it wouldn't hurt if k-9 handled this more gracefully
Environment
K-9 Mail version:
5.010
Android version:
4.4.4
Account type (IMAP, POP3, WebDAV/Exchange):
IMAP
Crash log:
10-20 10:50:24.665 I/k9      (25481): Committing preference changes
10-20 10:50:24.690 I/k9      (25481): Preferences commit took 28ms
10-20 10:50:24.710 I/k9      (25481): Committing preference changes
10-20 10:50:24.715 I/k9      (25481): Preferences commit took 8ms
10-20 10:51:28.510 I/PackageManager(2311): Adding preferred activity ComponentInfo{com.fsck.k9/com.fsck.k9.activity.MessageCompose} for user 0 :
10-20 10:51:28.555 I/Timeline(27016): Timeline: Activity_launch_request id:com.fsck.k9 time:253834704
10-20 10:51:28.560 I/ActivityManager(2311): START u0 {act=android.intent.action.SEND typ=application/gpx+xml flg=0x3000001 cmp=com.fsck.k9/.activity.MessageCompose (has clip) (has extras)} from pid 27016
10-20 10:51:28.915 V/k9      (25481): /storage/sdcard1/osmand/tracks/rec/2016-02-06_17-52_sob..gpx
10-20 10:51:28.915 V/k9      (25481): new attachment.size: 692
10-20 10:51:29.125 E/AndroidRuntime(25481): Process: com.fsck.k9, PID: 25481
10-20 10:51:29.125 E/AndroidRuntime(25481): Caused by: java.lang.UnsatisfiedLinkError: Couldn't load os-compat from loader dalvik.system.PathClassLoader[DexPathList[[zip file "/data/app/com.fsck.k9-1.apk"],nativeLibraryDirectories=[/data/app-lib/com.fsck.k9-1, /vendor/lib, /system/lib]]]: findLibrary returned null
10-20 10:51:29.125 E/AndroidRuntime(25481): 	at com.fsck.k9.activity.loader.AttachmentContentLoader.loadInBackground(AttachmentContentLoader.java:58)
10-20 10:51:29.125 E/AndroidRuntime(25481): 	at com.fsck.k9.activity.loader.AttachmentContentLoader.loadInBackground(AttachmentContentLoader.java:24)
10-20 10:51:29.335 W/ActivityManager(2311):   Force finishing activity com.fsck.k9/.activity.MessageCompose
10-20 10:51:30.885 I/ActivityManager(2311): Process com.fsck.k9 (pid 25481) has died.
10-20 10:51:30.885 W/ActivityManager(2311): Scheduling restart of crashed service com.fsck.k9/.service.PushService in 1000ms

This is actually caused by failing to load the os-compat library for SafeContentResolver.
Fixed in #1545


BEVFormer-S (static) config

Hallo,
what changes do I have to implement to have the static variant of BEVFormer (as presented in the paper)?
Or is there a config file available for the static variation.
Best,
Tim

+1


Getting it MVP ready

Changed the k8s manifests to by-name in order to remove the load-generator.
Changed the docker build process of the .NET cart service so it works with Rookout.
Added rookout to: Cart, Loadgen, Recommendation.
Added a sleep before running the loadgen test to fix an issue I had.

This shouldn't work as there aren't any tokens.

/jira open task

will happen here - https://github.com/Rookout/microservices-demo/pull/2


docs: update README.adoc

Issue
https://graviteedevops.atlassian.net/browse/DOC-178
https://github.com/gravitee-io/gravitee-docs/issues/843
Description
Add some information in circuit breaker documentation

Gravitee.io Automatic Deployment
🚀 A prerelease version of this package has been published on Gravitee's private artifactory, you can:

use it directly by updating your project with version: 1.1.3-circuit-breaker-doc-SNAPSHOT
download it from Artifactory here

:tada: This PR is included in version 1.1.3 :tada:
The release is available on:

1.1.3
GitHub release

Your semantic-release bot :package::rocket:


(Ionic) Handling already logged in users to bypass login screen?

Hi,
Was wondering how you would handle users with ng2-ui-auth_token already in the local storage, and bypass a login/create account screen. Is there routing logic for ionic to validate with this in ng2-ui-auth?

Make the default redirect the main screen and add an auth guard that will check if the user is logged in else redirect him to the login screen

Hmm, ok. If you don't mind, I'm going to keep this question open since your package uses an auth guard with routes in angular2, wanted to apply it to Ionic which requires Ionic pages/deep link system. I'll post some code here and close it when I figure out a mock solution

If anyone is looking for the solution, the best way I found was found to create a page-routing service that consists of an event emitter. Keep in mind this solution works with a navController
@Injectable()
export class PageRouteService {
	routeLogin = new EventEmitter<any>();
	constructor(){
	}
}

Then create a subscriber in the app.component on the constructor:
constructor(...){
		this.pageRoute.routeLogin.subscribe((data)=>{
			console.log(data)
			this.nav.push(TabsPage, data);
		});
}

this way you can push data from the login screen to any component you want, or in this case, the nav page.


chore: Refactor BannerPlugin

What kind of change does this PR introduce?
refactoring

Did you add tests for your changes?
Nope

Does this PR introduce a breaking change?
Nope

What needs to be documented once your changes are merged?
N/A

cc @sokra

The code-snippet here could be refactored as :-
if (["string", "function"].indexOf(typeof options) !== -1) { // ["string", "function"].includes(typeof options)
  //
}

or even,
if (["string", "function"].some(type => type === typeof options)) {
  //
}

But tsc --pretty fails for the above case.
@sokra thoughts :thinking:

cc @sokra

The code-snippet here could be refactored as :-

Better avoid that. This makes is less readable and probably slower.

Thanks

@sokra I would love to collaborate with, would be awesome if you could add me to the org :clap:

@sokra I would love to collaborate with, would be awesome if you could add me to the org :clap:

Also, I would love to collaborate with, would you mind adding me to the org?


TOMEE-2750 - Memory leak on undeploy (also contains commits about MyFaces integration)

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?


Allow twiddle factors to be configured during run time

Different applications have different configurations for twiddle factors, these can effect the output of NTT.
An example is flipping twiddles for gnark breaking this test https://github.com/ingonyama-zk/icicle/blob/fdf03460df5e5d85ade1f55a7df47ba392881281/src/test_bls12_377.rs#L1585

Same as https://github.com/ingonyama-zk/icicle/issues/183


day3-PullRequest

About this project
This is a project about the 10 days of Hackerrank Challenges.
This is challenge n.3 for day3.
For it:
Gitflow is respected and a featured branch is created.
I added the explanation of the challenge.
I added the solution of the challenge in JS.

Status: APPROVED 🟢
Hi @IvonneBenitesRodriguez ✋
Your project is complete!  There is nothing else to say other than... it's time to merge it: ship it:
Congratulations! :tada: :clap: :clap: :100:
Highlights!

 However, I strongly recommend considering them as they can improve your code.
Cheers, and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread and tag me @maximoortelli  if something is not 100% clear.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


Update changelog

Add recently merged changes to the change log. I also added links to the PR and a mention of the author. If it doesn't add too much noise I think it is nice to give a shout out to the contributor.
One thing I noticed while looking at the PRs merged since #426 is that things like work on the docs isn't captured in the changelog. What would be a good way to add this? In my mind the change log is a good way for people to see what has changed (not just code but also new/better docs) and give credit to those doing the work.

Just realised: the change log is rst not markdown. I'll update the syntax and find the right way to only list user's URLs once.

Syntax updated and implemented your changes @choldgraf. Merge away!

:shipit:


The Menuhax installation of Homebrew Launcher (Browser) is not necessary and confusive

Although installing Menuhax can give us some benefits on rebooting HBL (when you missed something or got an error on entering SysDowngrader):

Quick restart.
No adjusting date and time (for 9.9~) or facing up with extremely low bootrate of Sliderhax (for O3DS) anymore.

It has the following issues:

We actually don't need it for everything. If no Menuhax, we can still use the exploit first booted into HBL.
When Menuhax upgrades, the old versions will never work. NOOBS will stuck on this step when they don't know they should update Menuhax.

AFAIK, menuhax is only used in the guide as an easier way to launch homebrew channel. It's completely removed in the end of the Guide. Why make things more difficult?

It's included because browserhax is less reliable, and it's removed at the end.

Just to say again.
Noobs will get stuck when Menuhax is updated or Menuhax server is down.
This makes noobs CLAIM on the guide because they think they cannot go further without installing Menuhax BUT ACTUALLY THEY CAN!


Updated chart to be a stateful set.

What this PR does / why we need it:
This PR updates the postgresql helm chart to use a stateful set instead of a deployment.
Which issue this PR fixes : references  #1863
Special notes for your reviewer:
None.

@databus23

signed

@hiddeco
I have refactored the statefulset to use a volumeClaimTemplate for postgresql's data. I have maintained the pvc because it seems to be required for the metrics container that can optionally run with postgresql. Is this acceptable?

@hiddeco
Roadblocks:

[ ] removing the pvc and the volumes sections of the statefulset.yaml file results in a helm install . to never create a pod.
[ ] Should the optional metrics container be a part of a vanilla postgresql helm chart? Should it have its own directory called postgres-prometheus?

Why would it make sense to convert this to a statefulset?

@unguiculus It is my understanding that databases in general should be statefulsets unless the application does not need durability guarantees. If you think this is not worthy of modification to the existing chart, would it instead be worth creating a new chart?

@lucasyvas I am not sure what you are talking about. I desire to have a statefulset chart for postgresql.

@gaigepr @lucasyvas It depends on the database whether or not a statefulset makes sense. This PR would create a PVC for each replica if you scale up. This is not how Postgres works. Statefulsets make sense for databases that can scale horizontally, such as Cassandra, CockroachDB, MongoDB, etc.

/assign


fix: https passthrough. aiohttp_client compatability

This is an alternative to #55 that maintains compatibility with pytest-asyncio and fixes #51 and fixes #52.
The is_ssl method was monkey-patched in a synchronous way that couldn't work when simultaneous requests needed it both patched and not-patched.  Instead of undoing the ClientRequest monkey-patching we create DirectClientRequest and have our passthrough session use it instead.
For compatibility between aresponses and aiohttp_client fixtures we use a work-around recommended by @serjshevchenko  (https://github.com/pytest-dev/pytest-asyncio/issues/170#issuecomment-706114516) that replaces the aiohttp_client loop fixture with the event loop provided by pytest-asycnio.  The hanging was caused by different fixtures running on different event loops.
Also added add_local_passthrough which is useful when working with your own application server or other local resources.  To work with assert_plan_strictly_followed you should pass in the number of times it will be called as the repeat argument.
It's equivalent to
LOCALHOST = re.compile(r"127\.0\.0\.1:?\d{0,5}")
aresponses.add(
    host_pattern=LOCALHOST,
    repeat=aresponses.INFINITY,
    response=aresponses.passthrough
    )

@elupus @Zopieux I think I prefer this solution over #55 although it does require the developer to manually override the loop fixture.  I'll leave these pull requests open for a few days to give you both an opportunity to comment.

@Zopieux thanks for taking a look at this.

@Zopieux thanks for taking a look at this.

The hanging was caused by different fixtures running on different event loops.

*sigh* Thanks for looking. That makes sense, and this always has been a huge hassle in asyncio libraries and projects. This is often a friction point when it comes to making two libraries interact, all the more with magic-heavy things such as pytest.
Given that pytest-aiohttp is 1. popular 2. documented as the go-to solution, I'd obviously prefer a solution that is not incompatible with it, even if it requires some extra setup work. At the same time, pytest-aiohttp looks kinda abandonware at this point: https://github.com/aio-libs/pytest-aiohttp/issues/13, https://github.com/aio-libs/pytest-aiohttp/issues/16.

The hanging was caused by different fixtures running on different event loops.

*sigh* Thanks for looking. That makes sense, and this always has been a huge hassle in asyncio libraries and projects. This is often a friction point when it comes to making two libraries interact, all the more with magic-heavy things such as pytest.
Given that pytest-aiohttp is 1. popular 2. documented as the go-to solution, I'd obviously prefer a solution that is not incompatible with it, even if it requires some extra setup work. At the same time, pytest-aiohttp looks kinda abandonware at this point: https://github.com/aio-libs/pytest-aiohttp/issues/13, https://github.com/aio-libs/pytest-aiohttp/issues/16.

@Zopieux I've addressed your feedback and I think you're saying you are okay with this approach. Let me know if you have anything further.
FYI pytest-aiohttp is just a pointer to the testing fixture built in to aiohttp itself, so active development would be happening there. It makes sense that there wouldn't be much activity in the actual pytest-aiohttp repo.

@Zopieux I've addressed your feedback and I think you're saying you are okay with this approach. Let me know if you have anything further.
FYI pytest-aiohttp is just a pointer to the testing fixture built in to aiohttp itself, so active development would be happening there. It makes sense that there wouldn't be much activity in the actual pytest-aiohttp repo.

If this works.. But those two pytest add-ons are inherently incompatible.
I don't see why this lib should depend on either. I agree it is needed for its own test suite. But it should be possible to make sure the lib when used by end users ie standard pip install case does not bring in any of those test frameworks.

If this works.. But those two pytest add-ons are inherently incompatible.
I don't see why this lib should depend on either. I agree it is needed for its own test suite. But it should be possible to make sure the lib when used by end users ie standard pip install case does not bring in any of those test frameworks.

See for example here on how to only add that dependency for tests: https://github.com/elupus/nibeuplink/blob/ea12d4b63c5cb23923d0d970c2d992356b83120a/setup.py#L37

See for example here on how to only add that dependency for tests: https://github.com/elupus/nibeuplink/blob/ea12d4b63c5cb23923d0d970c2d992356b83120a/setup.py#L37

I don't see why this lib should depend on either.

The aresponses fixture has to depend on an event loop.  See https://github.com/CircleUp/aresponses/blob/master/aresponses/main.py#L266
Since pytest-asyncio covers a wider set of use cases I went with that one.  If there is some other option let me know.

I don't see why this lib should depend on either.

The aresponses fixture has to depend on an event loop.  See https://github.com/CircleUp/aresponses/blob/master/aresponses/main.py#L266
Since pytest-asyncio covers a wider set of use cases I went with that one.  If there is some other option let me know.

Yes. But that is an extremely simple fixture. It could easily introspect to see which pytest addon is available and just add a fixture that is compatible.
Or it could just be part of documentation.

Yes. But that is an extremely simple fixture. It could easily introspect to see which pytest addon is available and just add a fixture that is compatible.
Or it could just be part of documentation.

It could easily introspect to see which pytest addon is available and just add a fixture that is compatible.

I don't know how to do this, how would I do this?

It could easily introspect to see which pytest addon is available and just add a fixture that is compatible.

I don't know how to do this, how would I do this?

Careful with introspection code that tries to bring compatibility with various versions of various similar libraries. This is doomed to age badly and break. I'd much prefer documentation with 2-line code stubs for each poplar library. This allows developers to understand and maintain the compatibility "layer" in their own code, explicitly.
As long as that layer is thin and documented, which in this case it is (right?), I'd prefer this over tech debt magic. 👍

Careful with introspection code that tries to bring compatibility with various versions of various similar libraries. This is doomed to age badly and break. I'd much prefer documentation with 2-line code stubs for each poplar library. This allows developers to understand and maintain the compatibility "layer" in their own code, explicitly.
As long as that layer is thin and documented, which in this case it is (right?), I'd prefer this over tech debt magic. 👍


How to retrieve information about a historical version of a subgraph?

I am running the Graph Protocol locally and have deployed a subgraph named "test" with the version v0.0.1, which I can access at http://<IP_ADDRESS>:8000/subgraphs/name/test.
I then deployed another version of the subgraph with the same name but with version v0.0.2. Is the data from version v0.0.1 still available? How can I access the data from version v0.0.1?

I would be very grateful if someone could tell me it


[Improvement]: Introduce distribution field to Dependencies.toml and bump dependencies if a higher distribution is used

Description
Currently, the Dependencies.toml does not record the distribution version that is used to build the ballerina project. However it records the versions of dependencies that the previous build has used. Moreover, the dependencies are only bumped in patch versions from what is specified in Dependencies.toml.
Describe your problem(s)
No response
Describe your solution(s)
The above needs to be changed as follows.

Dependencies.toml should keep track of the distribution version used as follows.[ballerina]
dependencies-toml-version = "2"
distribution-version = "2201.5.0"

In order to be backward compatible, field distribution-version should be optional.
If a project is built using a newer distribution version than what is recored in the Dependencies.toml, the dependencies should be bumped to the latest minor version compatible with that distribution version.
If the distribution version is not mentioned in the Dependencies.toml, the dependency versions should be bumped similar to (2).

Related area
-> Compilation
Related issue(s) (optional)
No response
Suggested label(s) (optional)
No response
Suggested assignee(s) (optional)
No response

Re opening since we need to add more automated tests to validate the functionality. However the feature is implemented and merged to the master branch. This will go with SL Update 5.

We should add CLI tests as well. Opening the issue to track it.

Need to update documentation in https://ballerina.io/learn/manage-dependencies/#update-dependency-versions to match this change.


[SPARK-33225][SQL] Extract AliasHelper trait

What changes were proposed in this pull request?

Extract methods related to handling Aliases to a trait.
Why are the changes needed?

Avoid code duplication
Does this PR introduce any user-facing change?

No
How was this patch tested?

Existing UTs cover this

Test build #130173 has started for PR 30134 at commit 783b763.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34779/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34779/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/34779/
Test PASSed.

Test build #130173 has finished for PR 30134 at commit 783b763.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/130173/
Test PASSed.

NOTE: This PR comes from the comment in https://github.com/apache/spark/pull/30018#discussion_r510101973 cc: @cloud-fan @viirya
@tanelk Thanks for the work. Have you checked all the place where Aliass are used in analyzer/optimizer?

looks fine

Test build #130292 has started for PR 30134 at commit bd2e8bc.

Have you checked all the place where Aliass are used in analyzer/optimizer?

There were some places, but I did not feel that they deserved to get a method extracted. For example:
https://github.com/tanelk/spark/blob/63abab41b40e98947a5cb340a966e657e6b03632/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala#L3741

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34893/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34893/

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/34893/
Test PASSed.

Merged build finished. Test PASSed.

Test build #130292 has finished for PR 30134 at commit bd2e8bc.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/130292/
Test PASSed.

There were some places, but I did not feel that they deserved to get a method extracted. For example:
https://github.com/tanelk/spark/blob/63abab41b40e98947a5cb340a966e657e6b03632/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala#L3741

okay, thanks for the check. LGTM.

Thanks! Merged to master.


Add syndicate details to email notification of user reassignment

Request from Brenda:- When a user is re-assigned to a different syndicate, the coordinator of the new syndicate receives an email notification, as below:
"Dear Brenda;
New User at<EMAIL_ADDRESS>and userid new_user123, has been re-assigned to your syndicate.
Please make them welcome
The FreeCEN Team"
This isn't helpful when the coordinator has multiple syndicates.
Action: add details of which syndicate a user has changed to.

@FreecenBren implemented on test2.


fix: fix document code

fixed #9

:tada: This PR is included in version 1.2.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Add remediation for BTM corruption if users are upgrading from <IP_ADDRESS>501

Preinstall: checks if a problematic version (81501) is installed, and touches a file if so.
Postinstalls: same logic in both, looks for the touch file and if found runs the remediation.
Currently getting an "illegal byte sequence" error as I wrote this assuming /bin/sh and not ZSH - will continue working on this in Slack after dinner.
All the credit to @kevinmcox and @tuxudo for finding the BTM plist is editable and figuring out the PlistBuddy pieces.

Ready for testing!

For linking purposes: fixes https://github.com/macadmins/nudge/issues/515

Thanks for putting this all together @rickheil!

I have a theory. What if we ran the nudge uninstall SMApp cli flag instead? Would it remove the same keys from that file?

Also you need to do this on the dev branch not main. I haven't merged the other code yet into main.

Erik, is that the --unregister flag?
I tried that one yesterday and it didn't work.
That said, I can't promise I tried it in all combinations of scenarios, so definitely worth trying again after installing 1.1.13.

Do you have a v4 or v8 on disk? It would appear the v3 is from a very early version of Ventura

I no longer think this option is viable and am tempted to close the PR. This change is going to require full disk access.
When I first saw the PR, I thought it was a security issue in that if you can delete, you can add. In my testing, accessing this file on a terminal without FDA gives this error.
/private/var/db/com.apple.backgroundtaskmanagement/BackgroundItems-v8.btm: file does not exist or is not readable or is not a regular file (Error Domain=NSCocoaErrorDomain Code=257 "The file "BackgroundItems-v8.btm" couldn't be opened because you don't have permission to view it." UserInfo={NSFilePath=/private/var/db/com.apple.backgroundtaskmanagement/BackgroundItems-v8.btm, NSUnderlyingError=0x600003548000 {Error Domain=NSPOSIXErrorDomain Code=1 "Operation not permitted"}})

Thats great then. Apple's edge case here is going to cause a bit of...pain.


Change detector calls, so that only hostname is needed in detectors configuration

Description
As an orchestrator contributor, I want to change the code calling detector endpoints, so that I can set only the hostname in the hostname parameter in detectors configuration (e.g. https://my-detector.com instead of https://my-detector.com/api/v1/text/generation).
Note: This should be done for all detector endpoints.
Discussion
This was raised as an issue as a comment in one of the recent PRs. Making this change would allow two things:

Support detectors that implement more than one endpoint (detectors API reference).

I've tried the following:
    /// Invokes detectors implemented with the `/api/v1/text/generation` endpoint
    pub async fn generation_detection(
        &self,
        model_id: &str,
        request: GenerationDetectionRequest,
    ) -> Result<Vec<DetectionResult>, Error> {
        let client = self.client(model_id)?;
-        let url = client.base_url().as_str();
+       let url = client.base_url().join("/api/v1/text/generation").unwrap();
        let response = client
-            .post(url)
+            .post(url.as_str())
            .header(DETECTOR_ID_HEADER_NAME, model_id)
            .json(&request)
            .send()
            .await?;
        if response.status() == StatusCode::OK {
            Ok(response.json().await?)
        } else {
            let error = response.json::<DetectorError>().await.unwrap();
            Err(error.into())
        }
    }

As a result, detector hostnames could be configured as desired. I also noticed that, if a detector was configured with a full url (say https://mydetector.com/a/full/url), the path was entirely replaced (i.e. https://mydetector.com/a/full/url becomes https://mydetector.com/api/v1/text/generation, not https://mydetector.com/a/full/url/api/v1/text/generation.
Acceptance Criteria

[ ] Unit tests cover new/changed code
[ ] Examples build against new/changed code

This is going to be addressed by  #205.

This is required for the client refactor, so I am adding validation to ensure only base urls are set in the config for http clients.


shared encodings

When sublevels are treated more like stock databases, shouldn't they also have the default encodings that levelUp has?

My expectation is that I should be able to treat a sublevel just like another LevelUp database and to pass it the same initialization options (including encodings).  There may be an abstraction design problem here.

@NodeGuy you can indeed do that, check the recent docs. (this issue was 4 years old)


Explorer Searching functionality

please change or add a search functionality that is like visual studio or rider, when you search for something it would look in folders too.

Sounds like a duplicate of #66971


License missing

Hello!
First of all, thanks for building this!
Although it looks useful and super easy to use, legally speaking, no one is allowed to use it without a proper license, which is missing from this repo.
Could you add a license to your repo (preferably MIT)?
http://opensource.stackexchange.com/q/1720/775
Thanks!

@mateuscruz tks for suggestion. Just added the MIT license, is it okay now?

Yes it is! Thank you very much.


option to hide viewer count and duration of the stream when you hover on the split

Fixes #1621

Should there be a separate option for this? I think using the existing setting for this would be fine.


Workspace - Reimburse expenses- "Fast reimbursements = happy members!" and  "Unlock Next day"  headings are switching after every refresh

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:
Precondition: Add VBA flow

Go to https://staging.enew.xpensify.com/
Make sure you added VBA
Go to Settings - Reimburse expenses
Refresh the page

Expected Result:
Either Fast reimbursements = happy members!  or Unlock Next day should keep appearing after refresh the page
Actual Result:
Fast reimbursements = happy members! have been switched with Unlock Next day after refresh the page
Workaround:
Unknown
Platform:

Where is this issue occurring?

Web

Version Number: <IP_ADDRESS>
Reproducible in staging?:  y
Reproducible in production?: y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
https://user-images.githubusercontent.com/43996225/168916137-20c14424-0797-435b-917a-8aa64f7400c2.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause
Slack conversation:
View all open jobs on GitHub

Would like to hang onto this and fix internally

PR: https://github.com/Expensify/App/pull/9138 (Not sure why it didn't link itself?)


App Installation Issues

Dear I am trying to install this apps on erpnext version 14 . but there are installation issue. can you guide.
Thanks

Ther is error while building the app after installation

hi @gsbaig i have tried install the app on ERPNext version 14, and still works. You should install ERPNext first.. this repo depend on some ERPNext feature


Augmenting external module that is re-exported?

TypeScript Version: 2.5.2
Code
This can't be demonstrated with a simple 1-file code example so I made a trivial project to demo it:
https://github.com/chriseppstein/typescript_module_augmentation_bug
Instructions for how to run the demo and work around the issue are included on the README there.
When I include an interface in a node module's main index.ts file, then it is open for merging with a declare module "my_npm_module" {} but when I move that interface into a local submodule and export it in the main index.ts with a export * from "./local_module"; then the downstream consumer breaks.
Expected behavior:
It seems to me that the point of being able to export from other modules is to keep downstream consumers protected from internal refactors and maintain an existing public API. So I expect to be able to augment an interface and have it behave the same whether or not it has been re-exported.
Actual behavior:
It looks like the interface gets forked into two definitions, the downstream module sees only the interface surface that was added and the upstream module only sees the interface surface it defined.

This is a known limitation see #9532  and its cross-referencing for more details.
The only workaround is to augment the module that directly exports the declaration which of course presents maintainability problems and diminishes the level of abstraction. I've run into this a number of times. I usually just take the risk, targeting the module directly in the augmentation, knowing it may well break in the future.

@aluanhaddad Thanks for the reply. I've moved the code that needs to be augmented to the root of the node module. Not ideal, to say the least.

Look like this is bug in TypeScript 3.3.3333  I found that when using export star will cause augmentation failed. Workaround is manually export like below
export  { ClassA, ClassB, otherInstance, otherNamespace } from "my-cool-module"

@ktutnik Thanks for the solid workaround.
I've moved all my "augmentable" types to a file called augmentable.ts.
Then, in index.ts,
export {
  TypeA,
  TypeB,
  TypeC,
  //snip
} from "./augmentable";

All other types (generics, functions, etc) that rely on declaration merging/augmentation import from augmentable.ts.
It seems to work well so far.

Hi, I think this is not a problem. If you need to extend or augment a third-party library module in one or more submodules of your project, you need to add a declaration in the .d.ts file, this file will import your declaration into each module of your app.


The components in router-view doesn't show up

Version
3.1.4
Reproduction link
https://github.com/fahmiduldul/tvs_frontend/tree/7855ad4c367ea5a6830eae00612458e0e0cca4c5
Steps to reproduce
npm run serve
click Dashboard and other components in router-view disappear
i got this error after adding PollAndStat component to Dashboard views
What is expected?
the component shows in router-view
What is actually happening?
no component in router-view showed

I got this error message
Unhandled error during execution of scheduler flush. This is likely a Vue internals bug. Please open an issue at https://new-issue.vuejs.org/?repo=vuejs/vue-next
Uncaught (in promise) TypeError: Cannot read property 'parentNode' of null
at parentNode (runtime-dom.esm-bundler.js?830f:34)
at componentEffect (runtime-core.esm-bundler.js?5c40:5295)
at reactiveEffect (reactivity.esm-bundler.js?a1e9:42)
at callWithErrorHandling (runtime-core.esm-bundler.js?5c40:155)
at flushJobs (runtime-core.esm-bundler.js?5c40:387)

Hi, thanks for your interest but Github issues are for bug reports and feature requests only. You can ask questions on the forum, the Discord server or StackOverflow.

Hi @posva, what makes you think this is not a bug?
Because I got error message that state this is a bug like Unhandled error during execution of scheduler flush. This is likely a Vue internals bug.
if it's not a bug can you give me the clue? thanks!


Go metallinter requirement on PRs is poorly specified and should be removed

Description

Over the weekend, someone unilaterally added a requirememnt for PRs that the developer must have run gometalinter on changed files and resolved all of the errors. This requirement should be scrapped until the following issues are addresed.
First, the gometalinter is a complex and highly configurable set of capabilities, yet this requirement was made without any documentation of exactly how the gometalinter was to be installed and run to satisfy this requirement. For example, I've been trying to figure out for the last 30 minutes how to make it recognize the "vendoring" structure of our GOPATH (without success).
Ignoring that, let's take a look at some of the issues uncovered in the core/chaincode directory:
1. chaincode_support.go:363::warning: cyclomatic complexity 24 of function (*ChaincodeSupport).Launch() is high (> 10) (gocyclo)
2. core/chaincode/chaincode_support.go:330:1:warning: comment on exported method ChaincodeSupport.Stop should be of the form "Stop ..." (golint)
3. core/chaincode/chaincode_support.go:563:14:warning: printf-style function with dynamic first argument and no further arguments should use

According to this new requirement, someone suggesting a minor change to a file is now required to:

Refactor all complex routines in the file to satisfy an arbitrary "cyclomatic complexity" limit.

Correct or add documentation to all exported functions of the file.

Change print statements based on the arbitrary opinion that Printf("foo") (which is perfectly legal) should be changed to Print("foo").

Clearly this wasn't the intent of the new requirement. However this leads to the question, what was the intent of this new requirement? This question needs a crisp answer.
Once a crisp answer is available, in my opinion a comprehensive code cleanup should be undertaken as a separate project, rather than piecemeal as files are changed. Since the large majority of the existing code was created by IBM software development teams, to me it would natually fall to the IBM developer who was the original owner of the files or package to lead this effort, as they would be able to most efficiently and correctly refactor, document, etc. their own code.

I added that. The intent of the requirement is to have everyone run these tools.
gofmt
goimports
go vet
golint
This ensures a minimum standard for code formatting and comments. These are standard in the Go community and help to ensure readability of code.
I thought gometalinter would make life easier as it's just one tool, but that doesn't seem to be the case. I'll open a PR to suggest these four tools instead of gometalinter.

@srderson If you can provide a script that runs the exact tools you had in mind, precisely how you have them in mind, that would be great.
I do still have hesitations though. Every linter includes a caveat like the one included with golint:
The suggestions made by golint are exactly that: suggestions. Golint is not perfect, and has both false positives and false negatives. Do not treat its output as a gold standard.

I agree that adherence to standards is important, but the standards have to be "decidable", like gofmt. What mechanism will be used to decide if a golint warning is allowed?
I also see that golint will suggest that I should fix pre-existing documentation in a file I modified, as well as rename a structure
chaincode_support.go:138:6: type name will be used as chaincode.ChaincodeSupport by other packages, and that stutters; consider calling this Support
chaincode_support.go:330:1: comment on exported method ChaincodeSupport.Stop should be of the form "Stop ..."
chaincode_support.go:362:1: comment on exported method ChaincodeSupport.Launch should be of the form "Launch ..."
chaincode_support.go:500:1: comment on exported method ChaincodeSupport.Deploy should be of the form "Deploy ..."

I don't believe it is fair or wise to require the community to clean up IBM code. So I still believe that it would be good for the IBM developers to first use these tools to clean up the codebase. Once they have had that experience, and identified and agreed on false positives and scripted them to be ignored, only then require all new submissions to adhere to a set of well-thought-out standards.

Fixed by the new PR boilerplate.


modified and add some models

As mentioned in #16 , I hacked the original models under tasks.classification to alter the activation layer type of them to softmax, which I put in the file shadow_models.py.
I also refactored several deep models structures into child classes, so they could be directly used in Kashgari, which I put in the file deep_models.py.
Hope to be helpful.

This is really cool, thanks~ I will add some test case and publish to Pypi later.

You are welcome.
Because I don't have gpu, I modified some models, in which I alter the CuDNNGRU layer to GRU layer. You may change them back to CuDNNGRU if necessary.

@alexwwang Here is a test error with test case TestKMaxCNNModel, maybe you could help me fix this error. Thanks~


Feature Request: Provide own LevelToStringFunc in the TextFormatter struct

The TextFormatter is almost perfect for our use case except for one small thingy. We want the levels printed with Capitals and use "WARN" iso "warning". So this request is about adding a function e.g.: LevelToStringFunc as part of the TextFormatter struct where I can provide my own return strings for the different logrus levels (DebugLevel, InfoLevel, ...).
E.g.:
func LogLevelToString(level logrus.Level) string {
switch level {
case logrus.DebugLevel:
return "DEBUG"
case logrus.InfoLevel:
return "INFO"
case logrus.WarnLevel:
return "WARN"
case logrus.ErrorLevel:
return "ERROR"
case logrus.FatalLevel:
return "FATAL"
case logrus.PanicLevel:
return "PANIC"
}
return "UNKNOWN"
}
And in the !isColored() case check whether a function has been provided in the TextFormatter struct for printing the entry.Level.
text_formatter.go.txt

logrus.patch.txt

Closing per the project being put into maintenance mode


Feature Programming Exercise: Allow tutors to respond to complaints

Checklist

[x] I tested all changes and all related features with different users (student, tutor, instructor, admin) on the test server https://artemistest.ase.in.tum.de.
[x] Server: I added multiple integration tests (Spring) related to the features
[x] Server: I added @PreAuthorize and check the course groups for all new REST Calls (security)
[x] Server: I implemented the changes with a good performance and prevented too many database calls
[x] Server: I documented the Java code using JavaDoc style.
[x] Client: I added multiple integration tests (Jest) related to the features
[x] Client: I added authorities to all new routes and check the course groups for displaying navigation elements (links, buttons)
[x] Client: I documented the TypeScript code using JSDoc style.
[x] Client: I added multiple screenshots/screencasts of my UI changes
[x] Client: I translated all the newly inserted strings into German and English

Motivation and Context

Students are already able to create complaints and more feedback requests, but the tutors can't respond to them. This PR aims to add complaints inside the Update Result dialog.
Description

Tutors can respond to complaint from both 'List of Complaints' and 'Programming Exercise Dashboard' pages. The complaint is located inside the 'Update Manual Result' dialog.
Additionally, this feature brings some code duplication to the server, which will be solved in follow-up PRs.
Steps for Testing

Log in to Artemis
Navigate to Course Administration
Select 'Tutor Course Dashboard'
Select 'Exercise Dashboard' on Programming Exercise
Click 'Update Result' in Complaints list

Screenshots

Resolving Complaint

List of Complaints

Thanks for this pull request @maxr96!
I have some ideas and questions:

Thank you for the comments @jpbernius . I applied some of the suggested changes and left some comments.

I have tested your feature and found some issues within the implementation. Can you please have a look at them? Thank you :)
* When a tutor navigates to the List of complaints page, then accepted complaints cannot be opened by clicking `Show the complaint`. Also, the submission ID is missing (see screenshot).
  ![image](https://user-images.githubusercontent.com/33764166/68983848-48f78700-080d-11ea-8619-78d41e0b62ea.png)

* When the tutor navigates to the List of complaints and opens the complaint for his/her own assessment, then it looks like he/she can update the assessment or reject the complaint (which is not possible -> only errors are thrown).  Wouldn't it be better to disable the buttons `update assessment` and `reject complaint` in this case and replace `cancel` and `save` with `close`?

* Moreover a REST call for participations is made, e.g. `https://artemistest.ase.in.tum.de/api/participations/156496` where the student information is visible to the tutor. Shouldn't this information be hidden?
  ![image](https://user-images.githubusercontent.com/33764166/68984023-6842e400-080e-11ea-85c3-b4e57cd2f9d6.png)

@lovaiible Thank you for checking my PR and reporting about the issues.
I was not able to reproduce the first issue, for me it all worked good. This also seems to be related to how the complaints are created and not the programming exercise in particular. I guess it can be tackled in a separate bugfix.
I fixed the second issue, turned out to be I was getting the assessor too early. Now if the assessor and current user is the same it will only see the text of complaint, but can't edit it.
Regarding the last issue, the previous implementation was showing the student name. Now we got rid of it and don't show it anymore. The call to participation service was deleted for updating the result of complaint.

Why are there no client tests? Please add them!

Also make sure that you do not use Transactional any more. This is bad design, we should put this into our design guidelines that Transactional should be avoided if it is not absolutely necessary!!!

@krusche I think the logic here is not complete as well since the assessment due date is also missing (same situation as with the file upload exercises we discussed yesterday). But maybe this should be done in a separate PR?

I found another problem: I think the Programming Exercises Score Pages does not reflect changes made because of a complaint.

I found another problem: I think the Programming Exercises Score Pages does not reflect changes made because of a complaint.

@jpbernius Do you mean that it throws exception? What Sentry shows me is that it is happening after we check for file upload, modeling and text exercise, so programming exercise should not affect it. I don't understand yet why this happens.

Nice feature!
I marked the problems that I found with red rectangulars on the screenshots below.
(I am not sure if this one is a part of this PR) The number of my Assessments as well as the number of the Complaints remains 0 when it should be 1:

I don't have/see/get a Complaint response window:

Also one note (which might as well not be a part of this PR) - it takes 5+ seconds in order for the numbers on the right side on the 1st screenshot to load, which is quite a long time.

Hi @maxr96, somehow after your latest changes I haven't been able to respond to a complaint:
Please log in as test user 6 and go to the page https://artemistest.ase.in.tum.de/#/course/19/exercise/1223/tutor-dashboard for example.

Moreover if I don't add an assessment text, the console throws the following error. It would be better to show an alert or to allow no text assessments:

And another feedback: I don't think the date picker in the complaint modal changes anything, but it would be better to keep the date-picker disabled here.

But if you could disable the date-picker in the manual assessment modal as well, this would be great:
The reason is, if manual results are allowed, then the tutor can change the submission date of a late submission and so that the manual assessment can be counted to the student's score.

Thank you for checking my PR @lovaiible

The due date hasn't passed yet, that is why you are not able to resolve the complaint.
Added a warning, it should not throw exception anymore.
Good idea with the date-picker, I disabled it completely.

@ungaralex and I fixed most of the important issues so that this should work much more reliable.
By doing that we also fixed some other issue related to this feature in general.
It would be great if everyone can again test this PR on the test server, so that we can merge and release it tonight!

The main functionality of this feature works and I can respond to complaints!
Some issues mentioned above still exist and others I found now but I think they can be handled in a follow-up PR.
Here are my findings that could be handled in a different PR:

Instructors can't see complaints that have been evaluated by a tutor anymore
expected behavior here: instructors should be able to see all 2 complaints

Assessors can see complaints about their own assessment and click on evaluate complaint -> disable button
here I am logged with the account of the assessor but can still see the complaints about my own assessment and even click on evaluate:

programming exercise does not show in the instructors dashboard
complaints about your assessment do not reflect the correct number, shows 0 but when we click on 0 it shows one complaint (mentioned above)

I can still observe the behavior I was observing before.
One other thing that I noticed is that the numbers on the tutor exercise dashboard are also not updated (+some console errors):

Thanks to everyone for testing. As we still have too many issues in this PR, we move it to the next release 3.9.4

why did you remove this? I added this on purpose!

I updated it to 'View Result', because it is used only for showing results with complaints to the assessor. So the tutor can't either resolve the complaint or update the result, but only view both result and complaint.

The main functionality of this feature works and I can respond to complaints!
Some issues mentioned above still exist and others I found now but I think they can be handled in a follow-up PR.
Here are my findings that could be handled in a different PR:
* Assessors can see complaints about their own assessment and click on evaluate complaint -> disable button
  here I am logged with the account of the assessor but can still see the complaints about my own assessment and even click on evaluate:
  ![image](https://user-images.githubusercontent.com/50635005/69349699-81b5b700-0c78-11ea-99aa-9f21da244c0f.png)
  ![image](https://user-images.githubusercontent.com/50635005/69349792-af9afb80-0c78-11ea-97ca-6b79fc4793f1.png)

* programming exercise does not show in the instructors dashboard

* complaints about your assessment do not reflect the correct number, shows 0 but when we click on 0 it shows one complaint (mentioned above)

Thank you for the review @HanyaElhashemy . Regarding the issues you mentioned:

The assessor indeed can see the complaint and this is also how it works for other exercise type. But I agree that the button title was misleading, so I changed it to 'View Result'
Yes they don't show up there. I don't know when do we plan to add programming exercises to the instructor dashboard, but it is out of scope of this PR
It is actually an intended behavior. In Complaints about your assessments we count only those complaints that were accepted. I believe this needs more explanation to the user or maybe we should rework it. I think that is a good point for discussion and should be changed in another PR

Hi @maxr96, I tested the new changes on the test server and found some other issues:
* The number of complaints is still wrongly displayed. It is only correctly calculated when the complaint has been addressed. (In my screenshot, it should be 2 complaints. When I navigate to the list of complaints, two complaints are correctly displayed in the table).
  ![image](https://user-images.githubusercontent.com/33764166/69352421-3651d780-0c7d-11ea-923b-c2217fc7cae8.png)

* When accepting/rejecting complaints I receive a 404 error, see screenshots:
  ![image](https://user-images.githubusercontent.com/33764166/69352573-6ef1b100-0c7d-11ea-98cf-9b25d8755437.png)
  ![image](https://user-images.githubusercontent.com/33764166/69352583-744efb80-0c7d-11ea-9567-15ee58f4c3d2.png)

* Rejecting complaints without entering a response text leads to the error, that the original tutor is replaced with the tutor who did the complaint assessment. And the complaint has still the status `no reply yet` (see screenshot: tutor who assessed the submission and received the complaint was test user 7, but was changed to test user 8 who assessed the complaint)
  ![image](https://user-images.githubusercontent.com/33764166/69352671-9cd6f580-0c7d-11ea-8aa1-ba674dc5598d.png)

* Afterwards test user 7 can assess his own complaint because the reviewer is wrongly saved as test user 8

* After the complaints have been resolved, the buttons in the student submission table looks like this:
  ![image](https://user-images.githubusercontent.com/33764166/69353009-1ff84b80-0c7e-11ea-8ee8-200fca7f23f1.png)
  I think the label `evaluate the complaint` is misleading because the complaint cannot be evaluated here. It would be better to call it `view assessment` or `view manual result` instead imo.

Thank you for testing it @lovaiible It took me some time to fix the issue with result being assigned to the current user after resolving the complaint. Awesome that you spotted it, before it can affect real users :+1:  Regarding your feedback:

Wrong numbers, as I already mentioned are right, since they only count accepted complaints. Will be solved in another PR.
This is fixed now. We don't call the endpoint on each complaint response anymore
Next two points are fixed now
Good suggestion. I added View Manual Result as a title button for this use case

@maxr96 please make a note for your next refactoring PR that we are not using the same component for responding to complaints in the tutor dashboard. There is the jhi-programming-assessment-manual-result component referenced in the tutor dashboard template and a callback to a method viewComplaint in the complaints section for tutors. In the end, both methods create the same modal ProgrammingAssessmentManualResultDialogComponent. We either should have a separate modal for complaints or just use the same components. As of now, the used buttons are inconsistent depending on who is logged in (tutor vs. instructor).

@ungaralex Indeed it should be changed in the next PR. This will also include moving manual result handling to a separate page.

I have one additional question: Is there any reason that we keep using wrapper classes in Java for primitive types? I get that we need Long for uninitialized model objects, but for all our API endpoints and method parameters it really makes no sense to me to allow null values for IDs when we clearly expect an actual ID instead of null. Maybe we can discuss this in the next meeting

Thank you for the detailed review @ungaralex . I addressed all the issues you mentioned. I also think it is better to use primitive types. I changed Long to long in the code I touched. However, it is a good idea to discuss it in the developers meeting to understand if there can be some complications with this approach. One small thing that I already found is that we can't use primitive type in Generics, so our repositories will still extend JPARepository with class Long

Some comments here:

Thank you for the comments @jpbernius . Resolved them.

One last thing: please disconnect the result given to the complaing modal on the tutor dashboard from the result showing on the dashboard itself. Any changes on the result in the modal (s.a. changing the score) are immediately refelcted on the dashboard. Because of that, i can change the score in the modal, then just close the dialog or reject the complaint, but the result on the dashboard will still show my changes from the modal until I reload the page. This will  probably be quite confusing to some tutors.

One last thing: please disconnect the result given to the complaint modal on the tutor dashboard from the result showing on the dashboard itself. Any changes on the result in the modal (s.a. changing the score) are immediately reflected on the dashboard. Because of that, i can change the score in the modal, then just close the dialog or reject the complaint, but the result on the dashboard will still show my changes from the modal until I reload the page. This will probably be quite confusing to some tutors.

Thank you for this suggestion @ungaralex . Indeed that can be very frustrating if discovered by the user. I changed the behavior by passing deep clone of the result to the dialog. Now the result in the dialog and component from which it was called is not referenced anymore

Is it supposed to say:

Complaints about your assessments:
0

Even though it is actually 1?
I have seen comments on this before. Not sure if this is addressed in a follow up?

This issue will be fixed in other PR, since it is not related to my changes. Complaints about your assessment always shows only accepted complaints. This is how it was designed in the beginning. I am not sure what was the argument for doing so.

Here, it says:

There are no complaints at this moment.

But there are complaints, they are on my assessment so I cannot work on them.
I think it is not always clear if complaints are on my assessments, or if complaints are on other tutors assessments and I need to resolve them.
On a general note: This works. I can submit complaints, and work on them, only as a different user than doing the initial result.
However:
* This is not very intuitive to use! Especially inconsistencies in numbers make me not trust the dashboard!

* I feel tutors will not work on complaints as they simply cannot find them?

* I think some problems I face are related to the wording: This is one the one side always talking on complaints on my assessment, however I should not work on those, but rather on complaints on others assessments.

Further, I think that instructors should be allowed to respond to complaints on their own assessments? Not sure what other think on this.

If the Complaints are not on your assessment then they will appear in Complaints table.
In my opinion complaints are quite visible. You can find them on the tutor course dashboard and tutor exercise dashboard under clickable Complaints about your assessment (here I would agree that it should reacheable under Total Complaints or maybe Active Complaints). Also in the Tutor Course dashboard you can see the button near number of submissions is becoming red.
In general, I totally agree that we need to improve the complaints process. I guess we should discuss this on the next developers meeting and create a separate PR to address all issues regarding complaints in general

Stephan told me that the person reviewing the complaint needs to be different than the one who created the result. With that, I was able to test the update assessment functionality and it worked as expected. Good work!
Smaller UI things that I noticed:

Clicking on "Update assessment" or "Reject complaint" does nothing if the complaint's response is left empty. The buttons should be disabled until they can actually be clicked and there should probably be a form validation error displayed to the user that the complaint response can't be empty.

The actions buttons are center aligned in some tables which can be confusing since all the other columns are left aligned. At first I thought maybe there is an element left of the button taking up space but not getting rendered properly.

I tested the feature and I could still find additional problems :-(
I immediately fixed the most important ones.
The remaining issues are:

if you reject a complaint, it will not be updated in the Tutor Exercise Dashboard. The tutor has to refresh the page. Same for answering more feedback requests.
If you accept a complaint, the result will not be automatically displayed to the student when the navigates to the exercise details page. The student has to reload the application first. Otherwise the old result is shown. I think we can use the websocket here so that students do not need to refresh the page.
For some reason there is an [object%20Module] REST Call between complaint-instruction and complaint component that leads to a 404 when navigating to the exercise details page
When clicking on X for complaints and more feedback requests for programming exercises, this often leads to a typescript error

I think we can address these issues and the ones mentioned by @madwau and @HanyaElhashemy in a follow up PR and now merge this PR because our users want this feature urgently and the main functionality works. Please do that as soon as possible!


[SUPPORT][REOPEN] Caused by: java.lang.ClassNotFoundException: org.apache.hudi.org.apache.avro.util.Utf8

as desc in #6588
Stacktrace:
00:34  WARN: [kryo] Unable to load class org.apache.hudi.org.apache.avro.util.Utf8 with kryo's ClassLoader. Retrying with current..
22/09/05 11:17:58 ERROR AbstractHoodieLogRecordReader: Got exception when reading log file
com.esotericsoftware.kryo.KryoException: Unable to find class: org.apache.hudi.org.apache.avro.util.Utf8
Serialization trace:
orderingVal (org.apache.hudi.common.model.DeleteRecord)
	at com.esotericsoftware.kryo.util.DefaultClassResolver.readName(DefaultClassResolver.java:160)
	at com.esotericsoftware.kryo.util.DefaultClassResolver.readClass(DefaultClassResolver.java:133)
	at com.esotericsoftware.kryo.Kryo.readClass(Kryo.java:693)
	at com.esotericsoftware.kryo.serializers.ObjectField.read(ObjectField.java:118)
	at com.esotericsoftware.kryo.serializers.FieldSerializer.read(FieldSerializer.java:543)
	at com.esotericsoftware.kryo.Kryo.readObject(Kryo.java:731)

Steps to reproduce the behavior:
1.use Flink to insert data
2.use spark to query data
3.has delete block in log file
for HoodieDeleteBlock, it will use kryo serialize

in flink and spark, the type char、varchar、string will use org.apache.avro.util.Utf8
flink:

spark:

The flink bundle has relocation the avro but spark and presto bundle  didn't, so will cause ClassNotFound when the log file has delete block. So, how to compatible it will better?
<relocation>
                  <pattern>org.apache.avro.</pattern>
                  <shadedPattern>${flink.bundle.shade.prefix}org.apache.avro.</shadedPattern>
</relocation>

@KnightChess Does the solution proposed in https://github.com/apache/hudi/issues/6588#issuecomment-1236580669 work for you?

@codope yes, it's work, but I think need fix to compatible between the multy engines

Yes, I think we should shade/relocate avro in all bundles where it is included. The issue here is that it is shaded in one bundle but not in another. By shading in all bundles, there shouldn't be a conflict between shaded and unshaded class. Created HUDI-4954 to track it. If you would like to contribute, feel free to put up a PR.

Closing it as we have a PR that fixes the issue.


"Cost" description not clear

In docs/design is this description:

Suppose we want to store 100TB of metric data. At about 1.07 bytes/sample in total data size, this is equivalent to storing 6.5 years of data across an average of 1 million active time series.
The cost for this amount of metric data would cost approximately $2400/month on top of the baseline Prometheus setup. In return, being able to reduce the retention time of Prometheus instances from weeks to hours will provide cost savings for local SSD or network block storage (typically $0.17/GB) and reduce memory consumption. This calculation does not yet account for shorter retention spans of low-priority data and downsampling.

Would be helpful if we include a reference to how many samples per minute we're making such that others can follow up on this math.

I am pretty sure it is for 15s scrape internval so 4 samples / minute x 1 mln actibe series = 4mln samples / min (:

Hi @Bplotka,
Maybe I'm missing something, but:
3,416,400 min * 4mln samples / min *  1.07 bytes/sample = 14,622,192,000,000 bytes, or 13.3 TB? I thought we wanted 100TB?
I think instead it's 30 samples / min:
3,416,400 min * 30mln samples / min *  1.07 bytes/sample = 109,666,440,000,000, or 100 TB.
For reference: there are 3,416,400 min within 6.5 years.
If this is correct it would be very useful for those of us in the community to have that note added to the cost section.

yup, broken math (: Let's update this. 30 mln samples/ min is quite large with 1 mln time series the interval would be 2s which is not real.

Maybe while here we can update the retention period as well? Right now it's listed as 6.5 years, which is a little usual.
I more frequently see 3, 5 and 7 as requirements, so using one of these might be helpful for an apples to apples comparison.

I think if you can provide the values for each variable and make the math line up, that's all that matters.
Then people can calculate the costs for their own use cases :)
I was just doing this math earlier this week as well.

Cool, let's do this. I think this 2s interval in the example was to showcase the ridiculous amount of data and still how cheap it is.
I think we can make this more real, agree

Agree - but the devil's in the details. I monitor on a 1s interval... every 2s appears "fake" to me. :)


Increase timeout for OSX builds of the vagrant OSX box FLOC-3373

oneliner,
it increases the timeout from 60min to 120min for the nightly cron job that refreshes the OSX vagrant basebox for OSX run client tests

heads-up, not kicking a BB build of this PR branch as the tests don't exercise the build.yaml file.
jenkins green build here:
http://ci-live.clusterhq.com:8080/job/ClusterHQ-flocker/job/flocker-vagrant-basebox-FLOC-3373/job/_build_vagrant_basebox_for_osx_yosemite/2/console

LGTM.


[DOC] Document Transforms for Digital Pathology

With https://github.com/rapidsai/cucim/pull/100 in, how should we document these new functions ?  Should we simply add cucim.skimage.operations ?  Or broken out for each subsection: cucim.core.operations.color/ cucim.core.operations.expose.transform / etc

cc @shekhardw @gigony


refactor(all): refactor for lint tests

Most changes were of the following variety:

change let to const
change casting with <> to as
change Object param type to object

fixes #43

Don't have permissions to approve, but this LGTM


Issue with incorrect file TTL calculation

Describe the bug
When I uploaded a file with a TTL of 1439m, I expected the file to have a TTL of 1439m, but the actual TTL was 159m. The debugging process is shown in the following figure. Could you please take a look at the reason? Thank you!

System Setup

List the command line to start "weed master", "weed volume", "weed filer", "weed s3", "weed mount".
OS version windows 11
output of weed version seaweedfs 3.15

TTL has only 2 bytes. First byte is used for count of up to 255. Second byte is for unit.
1439m is parsed into 1280+159m, and 1280 was truncated.
You can use 24h instead.


[stable/atlantis] Allow for multiple-hostnames in ingress

Is this a new chart

NOTE: We're experiencing a high volume of PRs to this repo and reviews will be delayed. Please host your own chart repository and submit your repository to the Helm Hub instead of this repo to make them discoverable to the community. Here is how to submit new chart repositories to the Helm Hub.

No
What this PR does / why we need it:
Allows an operator to specify multiple-hostnames for the ingress that ships with the chart. TLS allows for multiple hostnames, the ingress object should follow the same pattern. Due care was taken to ensure the chart continues to behave as expected with both values declared, or a mix/match of the two. (note: no additonal logic was added to the tls block, and the operator is still expected to list all hostnames that require TLS in the TLS configuration block)

Its often that we deploy a service under a serialized "cluster dns" tier, and then CNAME a short-hand TLD to the serialized "cluster dns". The current chart only accepts a single hostname and that breaks the assumption of how we have our ingress tree is structured.

Special notes for your reviewer:
This was an attempt to not fully deprecate an existing config option, and retain compatibility until a 4.0.0 release target was reached to deprecate the single-hostname ingress. Please advise if there is a better pattern you'd like me to implement.
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [stable/mychartname])

/assign @callmeradical
:wave: Drive by commit here, please advise on anything further required to review/ammend.  thank you!

I found some side effects, I'll rework and resubmit.


Palo-Alto - Panorama | Under Investigation

Submission Template

Vendor Name
Palo-Alto

Product Name
Panorama

Version(s) affected
Unknown at this time

Status:  Please choose from one of the following (Unknown/Affected/Not Affected/Fixed/Under Investigation).
Under Investigation

Update Available:  Yes or No (If Yes, please provide link to information)
No

Notes
"Panorama includes Elasticsearch, which uses the log4j library. New information about CVE-2021-44228 has become available and the impact of the vulnerability on PAN-OS software running on Panorama hardware and virtual appliances is under active investigation. Palo Alto Networks is still planning to upgrade the version of Elasticsearch used in Panorama.
"

References
https://security.paloaltonetworks.com/CVE-2021-44228

Last Updated:  Date of last update
12/14/2021

Supporting Information from Elastic:
ElasticSearch
Supported versions of Elasticsearch (6.8.9+, 7.8+) used with recent versions of the JDK (JDK9+) are not susceptible to either remote code execution or information leakage. This is due to Elasticsearch’s usage of the Java Security Manager. Most other versions (5.6.11+, 6.4.0+ and 7.0.0+) can be protected via a simple JVM property change. The information leak vulnerability does not permit access to data within the Elasticsearch cluster. We have released Elasticsearch 7.16.1 and 6.8.21 which contain the JVM property by default and remove certain components of Log4j out of an abundance of caution. This is applicable to both CVE-2021-44228 and CVE-2021-45046. Additional details below.
https://discuss.elastic.co/t/apache-log4j2-remote-code-execution-rce-vulnerability-cve-2021-44228-esa-2021-31/291476
Supporting Information from Palo
Panorama 10.0 OSS
https://docs.paloaltonetworks.com/oss-listings/panorama-oss-listings/panorama-10-0-open-source-software-oss-listing.html
ElasticSearch Version 5.6.7 used in Pano 10.0
Panorama 10.1 OSS
https://docs.paloaltonetworks.com/oss-listings/panorama-oss-listings/panorama-10-1-open-source-software-oss-listing.html
ElasticSearch Version 5.6.7 used in Pano 10.1

Confirmed by Palo 12-15-2021 ~3:15 PM CST

Thank you for reaching out and we have updated the list.


v-model and 'date' props in slot #day is not same format

Describe the bug
in v-model I got the value: 2024-06-29T00:00:00.000000Z
in 'date' props in slot #day I got the value: 2024-06-28T16:00:00.000Z  (I assume the wrong return is in this part)
Expected behavior
Should return the same value, so it easier to compared that
Desktop & mobile (please complete the following information):

Browser: Firefox
Library version: 8.7.0

The code:
<DatePicker
    v-model="datexxx"
    inline auto-apply
    :disabled-dates="disableBeforeToday"
    :enable-time-picker="false"
>
    <template #day="{ day, date }">
        {{ date == datexxx }}
    </template>
</DatePicker>

This is intended behaviour, the dates in the calendar have time reset values


MedplumClient updates for Health Gorilla

Change the default Accept header value from application/fhir+json to application/fhir+json, */*; 0.1 - this allows all content types, but prefers FHIR
Added default value for Media.status to uploadMedia (status is a required field)

coverage: 93.911% (-0.004%) from 93.915% when pulling 3cf6adc789008432dade4d7e8ff155e158c981b6 on cody-client-fixes-for-health-gorilla into 5a8380e85d76852a355a7c3057473cd25619ba8d on main.


vagrant up fails to import virtual machine

Describe the bug
This is most likely a configuration issue on my end, or a lack of understanding of packer and vagrant. I've extracted the repo to a local directory and placed the preconfigured .box file within that same directory. Executing vagrant up fails when attempting to run import_vm.ps1.
Operating System/Hypervisor
Please include the operating system, hypervisor, and DARKSURGEON build you're having issues with.

Windows 10 v1803
Hyper-V
DARKSURGEON_1803

Screenshots

Additional context
PowerShell ExecutionPolicy is set to Bypass

Hey @joshuamcvay  -
Thanks for reporting this! Can you try running this command:
vagrant up .\DARKSURGEON_w10_1803_x64_hyperv.box

Thanks for getting back with me! The command provided produces the
following output.
The machine with the name '.\DARKSURGEON_w10_1803_x64_hyperv.box' was not
found configured for
this Vagrant environment.

On Tue, Jul 3, 2018, 4:32 PM DANΞ<EMAIL_ADDRESS>wrote:

Hey @joshuamcvay https://github.com/joshuamcvay -
Thanks for reporting this! Can you try running this command:
vagrant up .\DARKSURGEON_w10_1803_x64_hyperv.box
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/cryps1s/DARKSURGEON/issues/30#issuecomment-402298212,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ALafCk1JBSfpoaUBNFSrRc9b1qz2BC3qks5uC-MFgaJpZM4U9rYU
.

Hey @joshuamcvay  - I'll replicate on a clean environment shortly. Can you send me the version of vagrant you're using and, if possible, the sha1 hash of the .box file you have?

The hashes match on the ISO. I was using Vagrant 2.1.2. After dropping back to version 2.0.3 I received this error which seems related.


Better chunk manager error

What happened?
I just ran in to this error in an environment without dask.
TypeError: Could not find a Chunk Manager which recognises type <class 'dask.array.core.Array'>

I think we could easily recommend the user to install a package that provides dask by looking at type(array).__name__.  This would make the message a lot friendlier

How was an instance of dask.array.core.Array even created if you were in an environment without dask?
I agree that message could be clearer though - opened #7963.

How was an instance of dask.array.core.Array even created if you were in an environment without dask?

Yeah i realized that out 2 minutes later. Not sure what happened, may be bad editable install.

Actually wait it's possible this might be a real bug - if xarray.core.pycompat.is_duck_dask_array returns False for an instance of dask.array.core.Array. We shouldn't see that type though, so if you can't reproduce it easily it's probably a bad install instead though.

Closing as probable bad install


Refactor 2016 04 12

Other than the two things :+1:. Option parsing might warrant a test or two at this point.

Let's write tests when we on the mood. hmm...


Hide Container Restore

Note that I didn't remove BlobContainerProperties.DeletedOn and BlobContainerItem.IsDeleted.  This would require a swagger or swagger readme change.  BlobContainerProperties.DeletedOn will always be null, and BlobContainerItem.IsDeleted will always be false, accurately reflecting the state of the container to the user.  This feature will be re-enabled in the near future, so I don't see it as a major issue.


Paimon.moe and multiple accounts

I have multiple accounts on my paimon.moe. Unlike seelie.me (which is an amazing implementation thank you) I can't extract each account's JSON separately, they all get saved as one JSON.
It would be great to have the option to add the achievements to the 2nd account as well.
I can switch the other ACC to be the main ACC and to it like that, but it would be nice to have said functionality in the akasha scanner.
Additional context
When I add the base JSON to akasha, it keeps the info from all of the accounts but only adds achievements to the first one
P.S. I absolutely love this app, wonderful work

Sorry didn't know Paimon.moe support multiple accounts XD. Will fix this soon.


[AIRFLOW-1771] Rename heartbeat to avoid confusion

Dear Airflow maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
@aoen @bolkedebruin
JIRA

[x] My PR addresses the following Airflow JIRA issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"

https://issues.apache.org/jira/browse/AIRFLOW-1771

Description

[x] Here are some details about my PR, including screenshots of any UI changes: People confuse "Boom" with something going bad (Boom sounds like an explosion, not a heartbeat). We should rename this to avoid confusion

Tests

[x] My PR adds the following unit tests OR does not need testing for this extremely good reason: n/a

Commits

[x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

will add the jira issue in a sec

LGTM

Codecov Report

Merging #2743 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #2743   +/-   ##
======================================
  Coverage      73%     73%
======================================
  Files         155     155
  Lines       11835   11835
======================================
  Hits         8640    8640
  Misses       3195    3195

Impacted Files
Coverage Δ

airflow/jobs.py
79.6% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44710d7...0f28dd0. Read the comment docs.


Store Present bought tickets Locally on device

Describe the feature you'd like
Due to unreliable internet connections , ticket doesn't get loaded . Present event tickets are important . So store them Locally on device and display ticket in TicketFragment . Remove the tickets from local storage , once event date has passed
Update :

EventBrite also does this . Display Tickets in Tickets_fragment (even if offline)
No network calls for purchased Tickets
I would also implement mechanism , such that if user re-install/ re-login in the app , it would get downloaded
That is
First Check local -> if found then OK else store to local
On logout , storage will be cleared.

Would you like to work on the issue?

[ :heavy_check_mark:  ] Yes
[ ] No
Other:

@theLimitBreaker it is already implemented you can download tickets in the app so no need to implement this

@aggarwalpulkit596  I know , but people download ticket for variety of purpose. If people use eventBrite/eventyay App, for tickets of event . They would likely to go tickets section first to see the ticket.
Also EventBrite does this too.
Benefit :

User naturally go to tickets_section for tickets. Displaying tickets in TicketFragment from Local Storage. Provide Single easy point of access to tickets , that too offline
Also save network calls for user ticksts

Why are we not saving tickets in DB right now? Please take this up on priority

Why are we not saving tickets in DB right now? Please take this up on priority

we are saving the ticket in DB there is a ticketDao class but current implementation do let the user access it without the internet

Why are we not saving tickets in DB right now? Please take this up on priority

Thats how I want to implement it

@aggarwalpulkit596 may be you want to say don't If I am not wrong

Yes, please load it from DB first and fetch from network as well.

@iamareebjamal I am unable to place order for free events. OrdetAPi throws exception while using placeOrder() and I get "unable to create order" message. Currently I don't have any tickets on my account. If i can get test account which have tickets . I can check

@iamareebjamal I am unable to place order for free events. OrdetAPi throws exception while using placeOrder() and I get "unable to create order" message. Currently I don't have any tickets on my account. If i can get test account which have tickets . I can check

You can easily have tickets from any free event try it on prod server instead of staging server

@aggarwalpulkit596 thanks for suggesstion. But I already tried both server. Getting same result HTTP 422 UNPROCESSABLE ENTITY

Open issue on server

@iamareebjamal  I checked the body being sent to server some attributes of Order model were null (like amount & order notes)
When I sent the same request using Postman I got same HTTP error code 422 with this reasoning
{
    "errors": [
        {
            "detail": "Field may not be null.",
            "source": {
                "pointer": "/data/attributes/amount"
            },
            "status": "422",
            "title": "Validation error"
        }
    ],
    "jsonapi": {
        "version": "1.0"
    }
}

@iamareebjamal  should I create the issue for this on android-client ?

Yes

@iamareebjamal  I am facing some issue
to store show tickets firstly
orders under user fetched -> events under that order -> tickets shown
So I had to store orders into database.
But
orders relationship to attendee and event
attendee relationship to ticket and event .
So I had to store ticket and attendee too into database otherwise I would get FOREIGN KEY CONSTRAINT FAILED ERROR
Attempt to solve
When orders are fetched  , for events under order I fetched tickets (from API) and stored them
when events and tickets are stored into database , I fetch attendees under order(from API) and tried to store and here I get error .
2019-04-24 19:28:18.405 16032-16032/com.eventyay.attendee I/PUI: Attendee(id=8545, firstname=Rohan, lastname=Maity<EMAIL_ADDRESS>address=, city=, state=, country=null, isCheckedIn=false, pdfUrl=https://api.eventyay.com/static/media/attendees/tickets/pdf/6c693b6b-9b84-421f-a43a-6d18bc8911cf/bzlmdU1DU2/0144a9e1-d7a8-479b-bd64-198ba364b89f.pdf, ticketId=207, event=null, ticket=null)
2019-04-24 19:28:18.414 16032-16032/com.eventyay.attendee I/PUI: Attendee Parameter specified as non-null is null: method kotlin.jvm.internal.Intrinsics.checkParameterIsNotNull, parameter ticketId

here it mentioned ticketId id specified as non null is null . But ticketId is not null here .
parameter ticket (type TicketId) of attendee model is null here . But its specified as Nullable.
Could you help here little ?

@iamareebjamal I am facing an issue
for showing tickets firstly
orders under user fetched -> events under that order -> tickets shown
So I tried to store orders into database So I got the error FOREIGN KEY constraint failed (code 787 SQLITE_CONSTRAINT_FOREIGNKEY)
now since Order class has relationship to event and attendee
and attendee in turn has relationship ti ticket and event
So I also have to store related attendee and tickets for orders .
Attempt to solve
I stored the events under order successfully
I fetched tickets for event(that are under order) (from API) and stored them successfully
I also fetched attendees for orders (from API) and stored them successfully
But still I am getting the same error  FOREIGN KEY constraint failed (code 787 SQLITE_CONSTRAINT_FOREIGNKEY)
Could you help a little ?

@theLimitBreaker can I take upon this I was able to resolve this and have done most of the work

@aggarwalpulkit596 I am currently working. Just stuck at some point . If you could help me with this then that would be appreciated .

there was no update for over a week so I started this myself and issue is quite simple as attendee data needs to be saved before order data and the way I understand the DB there shouldn't be any relationship of attendee and order and there weren't working even before

@aggarwalpulkit596 Sorry for misunderstanding caused but I am working .
Also points you mentioned . I have included in above comment. (Please look)
On one Order placed there can be multiple attendees (so why no relationship)
Plus I points I mentioned are on the basis of the code (Please look the points)

and also listAttendeeId Converter is not working as jacksonObjectMapper doesn't understand array you have to feed him a object {} and not this[{}]

All other things were getting stored properly . Only order created problem. Only difference was order was having List unlike others .
Thanks for confirming this.

@iamareebjamal we might have to use to gson here as jacksonObjectMapper doesn't understand this and i guess we cannot manipulate [{}] into {}

@theLimitBreaker if you're still unable to rectify the issue you can take a look at this https://github.com/aggarwalpulkit596/open-event-android/commit/7d3c5d04bbcaa952f39d2c659d0ce2265bc81053

@theLimitBreaker if you're still unable to rectify the issue you can take a look at this aggarwalpulkit596@7d3c5d0
this branch is working as expected

@aggarwalpulkit596  I checked the string formed by Jackson & gSon both are forming same strings when fed List<AttendeeId>
2019-04-25 08:53:09.529 4834-4869/com.eventyay.attendee I/PUI: Converter
    jackson [{"id":224},{"id":225}]

    gson [{"id":224},{"id":225}]

I dont think so issue is with Jackson

@theLimitBreaker obviously the read string would be the same in both cases it's about the output and jacksonObjectMapper doesn't understand this [] so it fails

I used GSON still its failing giving same error FOREIGN KEY constraint failed (code 787 SQLITE_CONSTRAINT_FOREIGNKEY) . Thats why I said I dont think so issue is with Jackson

Yes you will be getting an foreign key constraint failed because the attendee corresponding to it hasn't been saved and you're trying to save it and secondly try removing constraint claws and then try Saving the order to db you'll know what I'm trying to tell you

corresponding Attendees are saved to DB as metioned earlier

there no point getting that error then if you're but I highly doubt that they are saving because I tried it was failing and try with removing foreign key constraint it would show error for jackson

Attendees -> relationship to tickets  (Just like order -> attendees) . I stored tickets then successfully stored tickets.
Same way tried with order . But thrown exception .
This is what  I have already  mentioned up

I tried it was failing

You have to store corresponding tickets too before saving attendees

and I told you I was able to resolve this and my current implementation is working as expected without any hiccups even with retaining that relationship

Thanks for information you provided till now.  But I am just stuck at this just one issue. I have already done enough work, So I would like to fix this.

@iamareebjamal I am facing an issue
for showing tickets firstly
orders under user fetched -> events under that order -> tickets shown
So I tried to store orders into database So I got the error FOREIGN KEY constraint failed (code 787 SQLITE_CONSTRAINT_FOREIGNKEY)
now since Order class has relationship to event and attendee
and attendee in turn has relationship ti ticket and event
So I also have to store related attendee and tickets for orders .
Attempt to solve

I stored the events under order successfully
I fetched tickets for event(that are under order) (from API) and stored them successfully
I also fetched attendees for orders (from API) and stored them successfully

But still I am getting the same error FOREIGN KEY constraint failed (code 787 SQLITE_CONSTRAINT_FOREIGNKEY)
Could you help a little ?

@iamareebjamal  @nikit19  any help

@aggarwalpulkit596  were you talking about this when Jackson wasn't able to deserialize
order local Cannot construct instance of `org.fossasia.openevent.general.attendees.AttendeeId` (although at least one Creator exists): cannot deserialize from Object value (no delegate- or property-based Creator)
        at [Source: (String)"[{"id":8545}]"; line: 1, column: 3] (through reference chain: java.util.ArrayList[0])

@theLimitBreaker yup

there no point getting that error then but I highly doubt that they are saving because I tried it was failing and try with removing foreign key constraint it would show error for jackson

@aggarwalpulkit596  after removing clause it does store orders.
But I re-checked my previous approach (without removing clause) . it was storing events, tickets, attendees but for order thrown exception.
I checked database with this https://github.com/amitshekhariitbhu/Android-Debug-Database

you can use DBSQlite brower for saving which values are saved to db and which are not i used that

you can use DBSQlite brower for saving which values are saved to db and which are not i used that

I tried that first , But it wasn't working. It showed me empty database and but in LOGS was able to retrieve result. (Throgh Logs I checked list size coming from DB its non -emepty)

Wierd it should the results i use this for everywhere and works like a charm

@aggarwalpulkit596  Thanks for your guidance till now. I was able to deserialize with Jackson only. No need for GSON.
thing was we were supposed to use jackSonObjectMapper from jackSon-kotlin-module` not regular objectMapper.

@iamareebjamal  @nikit19
Currently for FOREIGN KEY constraint failed (code 787 SQLITE_CONSTRAINT_FOREIGNKEY) I propose two soluttions

if want to keep FOREIGN_KEY_CONSTRAINT of AttendeeID in Order

Store Order in First Normal Form
This would include addition of AttendeeID property in order . and explicitly creating each AttendeeId from attendeeList amd initializing it in Order object
Con : For each Attendee , other order details would be repeated (Increase size Storage)
Pros: It would serve FOREIGN_KEY constraint and support onCascade Delete

If we remove FOREIGN_KEY_CONSTRAINT

use JacksonObjectMapper from Jackson-Kotlin-Module. Thats all
Pros:  Wont increase storage
-Con : Wont serve FORIEGN_KEY constraint

Have you checked whether the data is saving or not because i remember that i used jacksonObjectMapper in first place and it wasn't working

Yes they are getting stored . I checked it with stetho and debug-database


move Product, SwiftPMProductError from TSC to SwiftPM

motivation: these are specific to SwiftPM and should not be in TSC
changes:

move Product, SwiftPMProductError from TSC to SwiftPM
refactor how SwiftPMProduct is used in tests
update all callsites (tests)

@swift-ci smoke test

@swift-ci smoke test windows

@swift-ci smoke test

@swift-ci smoke test windows

@swift-ci smoke test windows


bug: version1.50.0->version1.51.0 file: textDiffEditor.ts new import function multibyteAwareBtoa  Maximum call stack size exceeded

VSCode Version: 1.51.0
OS Version:

Steps to Reproduce:

https://stackoverflow.com/questions/38432611/converting-arraybuffer-to-string-maximum-call-stack-size-exceeded
function toBinary(str: string): string {
   const codeUnits = new Uint16Array(str.length);
   for (let i = 0; i < codeUnits.length; i++) {
   	codeUnits[i] = str.charCodeAt(i);
   }
   return String.fromCharCode(...new Uint8Array(codeUnits.buffer));
}

toBinary(new Array(100000).fill('vs').join('')) // Uncaught RangeError: Maximum call stack size exceeded

Does this issue occur when all extensions are disabled?: Yes/No

Fixed by #112015

@bpasero We talked through the issue in Redmond and have decided not to fix it in 1.52. Based on my understanding, this should only be triggered for very long file paths and is not a regression compared to 1.51.


Add an empty bootloader with attributes to modules

Bootloader section and attributes are automatically installed with the
kernel (if they don't already exist). This enables make flash which
uses tockloader to automatically determine how to program the board
from the attributes listed on the board.
This is the first step towards eventually checking at app install time
that you are on a board that supports the given app.

Updated


local content rollback, all new stuffmissing

:{

@gingercat-maki what do you mean? can you elaborate?

At my trial on excalidraw, I didn't use the plus edition. As the free one does not support multi-files, so I deleted original contents for new graphs. I didn't store them to local by exporting them, and I just left them in the chrome. Then things happened that I refreshed the chrome, and all new contents gone and old ones re-appeared. So I lost everything.


Feature request: Close Icon or Esc-Key for txt files

My Setup

Operating System: Mircrosoft Windows 10 Pro
App Version: 2.15.0
Installation type: exe

[x] I have tested with the latest version
[X] I can simulate the issue easily

Description

upload a txt file and open it in rocket chat
Current Behavior

cannot find any obvious way to close the file
have to use View -> Back (Alt + Left Arrow)
Expected Behavior

a close icon in the right corner
esc key to close the file view
back key to close the file view

Please test if the latest release did solve this. If not please reopen the issue or create a new one and tell us. I will be closing this one for now.
Thank you!


Add React gitignore file

Reasons for making this change:
This PR adds the gitignore file for React, a UI Library that gained popularity in the last couple of years.
For the coding of a React project you need several node modules, that are generated upon installation and easily occupy a lot of space, and therefore should be ignored. The necessary package management  system can create error logs, which should be ignored as well.
To run a React project you need to bundle your files, e.g. with Webpack. This generates a build directory that is generated automatically and should be ignored for versioning with git.
Link to application or project’s homepage:
https://facebook.github.io/react/

@kristinbaumann This is included in https://github.com/dvcs/gitignore
https://www.gitignore.io/api/reactnative

I'm closing this our because Node.gitignore covers most of these rules, and I don't believe /build/ matches the conventions from webpack (they use dist in the example on their home page, but this can be changed by the user easily, and other tools exist for bundling your React app).


Create Dockerfile for this project

Create a Dockerfile to allow building a Docker image from this repository easily. Can use Dockerfile as reference.
Also consider adding a document to the project's wiki page to describe how to build a docker image and deploy a container with the bot.

Pushed commit edae384c6932e56998d1769400c094b62c47fccb that closes this enhacement. Also created a wiki page to document how to build a Docker image and container for the bot.