Various fixes for KRPC.jl

Hello,
I am not sure if you like to receive PR with one PR doing one thing each, or receive fixes all at once, so I collected my accumulated fixes in one PR. If you prefer the other way around, we can close this and try again.
Here are the list of changes:
Minor changes

2cc9c2e (HEAD -> develop, fork/develop) doc: add helpful inline comments for close(Listener)
this contains simple commentaries to help myself. Maybe you don't want it? We can drop this commit.

4ddc0df refactor: downgrade error() in close(Listener) to warning
I thought throwing an error here is abit overkill, although having a request to closed stream might indicate that something else is wrong and having come "de-sync" issues. Let me know if you think this is a bad idea.

17fd742 fix: remove unused PipeBuffer
Probably a leftover from past code?

Fixes

a13a707 fix: remove undescore in Tuple_ from types
I think this is the one you told me in KRPC discord..

1942084 fix: use one_to_many to checking unbound stream removal
This is a fix for a regression I introduced. I was not properly handling closing of streams.

47344ab fix: close the Julia channel when closing listener
This signals the consumer that the channel is closed and there is no point in waiting anymore.

ff8e994 fix: use try-finally to release semaphore
I pointed this out after you merged my previous fix for raw.jl, and it's finally getting patched.

This format is fine - sorry, I'm not in a place where I can really
review/help much right now.
The one thing I'm concerned about is the Tuple_ to Tuple change. That was
done originally to dodge Base.Tuple; does it still work now?
On Sat, May 20, 2023, 6:22 AM Rhahi @.***> wrote:

Hello,
I am not sure if you like to receive PR with one PR doing one thing each,
or receive fixes all at once, so I collected my accumulated fixes in one
PR. If you prefer the other way around, we can close this and try again.
Here are the list of changes:
Minor changes

2cc9c2e
https://github.com/BenChung/KRPC.jl/commit/2cc9c2ee36df3c13f75f37df87eae9939f97d90f
(HEAD -> develop, fork/develop) doc: add helpful inline comments for
close(Listener)
this contains simple commentaries to help myself. Maybe you don't want
it? We can drop this commit.
4ddc0df
https://github.com/BenChung/KRPC.jl/commit/4ddc0df0fcd3879740cd76ab01a4fc0ae74d4678
refactor: downgrade error() in close(Listener) to warning
I thought throwing an error here is abit overkill, although having a
request to closed stream might indicate that something else is wrong and
having come "de-sync" issues. Let me know if you think this is a bad idea.
17fd742
https://github.com/BenChung/KRPC.jl/commit/17fd742134ef9afe58d0c2fa3fc97ef11d751bfe
fix: remove unused PipeBuffer
Probably a leftover from past code?
Fixes

a13a707
https://github.com/BenChung/KRPC.jl/commit/a13a707fdf77065941872bdd5f346f70d24e83ad
fix: remove undescore in Tuple_ from types
I think this is the one you told me in KRPC discord..
1942084
https://github.com/BenChung/KRPC.jl/commit/19420843b00bdc008ff90d8b546e5252b267cc0e
fix: use one_to_many to checking unbound stream removal
This is a fix for a regression I introduced. I was not properly
handling closing of streams.
47344ab
https://github.com/BenChung/KRPC.jl/commit/47344abf1d87573e6c53a8eabd48a8ecda7ffcf1
fix: close the Julia channel when closing listener
This signals the consumer that the channel is closed and there is no
point in waiting anymore.
ff8e994
https://github.com/BenChung/KRPC.jl/commit/ff8e994143ce5a9c9ffabaf78b5b2430b8edb53d
fix: use try-finally to release semaphore
I pointed this out after you merged my previous fix for raw.jl, and
it's finally getting patched.

You can view, comment on, or merge this pull request online at:
https://github.com/BenChung/KRPC.jl/pull/13
Commit Summary

ff8e994
https://github.com/BenChung/KRPC.jl/pull/13/commits/ff8e994143ce5a9c9ffabaf78b5b2430b8edb53d
fix: use try-finally to release semaphore
17fd742
https://github.com/BenChung/KRPC.jl/pull/13/commits/17fd742134ef9afe58d0c2fa3fc97ef11d751bfe
fix: remove unused PipeBuffer
47344ab
https://github.com/BenChung/KRPC.jl/pull/13/commits/47344abf1d87573e6c53a8eabd48a8ecda7ffcf1
fix: close the Julia channel when closing listener
1942084
https://github.com/BenChung/KRPC.jl/pull/13/commits/19420843b00bdc008ff90d8b546e5252b267cc0e
fix: use one_to_many to checking unbound stream removal
a13a707
https://github.com/BenChung/KRPC.jl/pull/13/commits/a13a707fdf77065941872bdd5f346f70d24e83ad
fix: remove undescore in Tuple_ from types
4ddc0df
https://github.com/BenChung/KRPC.jl/pull/13/commits/4ddc0df0fcd3879740cd76ab01a4fc0ae74d4678
refactor: downgrade error() in close(Listener) to warning
2cc9c2e
https://github.com/BenChung/KRPC.jl/pull/13/commits/2cc9c2ee36df3c13f75f37df87eae9939f97d90f
doc: add helpful inline comments for close(Listener)

File Changes
(3 files https://github.com/BenChung/KRPC.jl/pull/13/files)

M src/raw.jl
https://github.com/BenChung/KRPC.jl/pull/13/files#diff-133b29085c26e5621735abbb3cee752d819faa2fc8716a508476f4afe62e674b
(15)
M src/streams.jl
https://github.com/BenChung/KRPC.jl/pull/13/files#diff-b5160c782c75f0255b5dbab87529fa941769f9fa8392df20e927c1c03bfcf2cc
(16)
M src/types.jl
https://github.com/BenChung/KRPC.jl/pull/13/files#diff-525588e68b2421901be164965272940effa093de733a3fd36c4b9a4344b8c20c
(2)

Patch Links:

https://github.com/BenChung/KRPC.jl/pull/13.patch
https://github.com/BenChung/KRPC.jl/pull/13.diff

—
Reply to this email directly, view it on GitHub
https://github.com/BenChung/KRPC.jl/pull/13, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AACADVV3FVB4B22VO4JFHBDXHDAQ7ANCNFSM6AAAAAAYIXUYNE
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

I just looked back on Discord chat log. You did not mention this line before; it's something I changed on my own. I probably changed it because something didn't work, I will change it back to Tuple_ and see how it goes again.


⚖ Register Validator: Test

Network Choice
dentrite-1
Who are you?
A testing validator
Delegator address
axone1g2ffjshwhck5mau3exg35fqygu0rm8pev6fnjg
gentx
{"body":{"messages":[{"@type":"/cosmos.staking.v1beta1.MsgCreateValidator","description":{"moniker":"your-moniker","identity":"6C36E7C076BFDCE4","website":"https://foo.network","security_contact":"validator@foo.network","details":"My validator"},"commission":{"rate":"0.050000000000000000","max_rate":"0.200000000000000000","max_change_rate":"0.010000000000000000"},"min_self_delegation":"1","delegator_address":"","validator_address":"axonevaloper1g2ffjshwhck5mau3exg35fqygu0rm8peu09pg2","pubkey":{"@type":"/cosmos.crypto.ed25519.PubKey","key":"DTRiZpMP1WHVdJe/WO6eqNZAqqyhWITsqaYnl1KxIPI="},"value":{"denom":"uaxone","amount":"1000000000000"}}],"memo":"9b960c976d2f2d5050f3664e3c0192a449353085@<IP_ADDRESS>:26656","timeout_height":"0","extension_options":[],"non_critical_extension_options":[]},"auth_info":{"signer_infos":[{"public_key":{"@type":"/cosmos.crypto.secp256k1.PubKey","key":"Az+B1UuhX06jw6VQ2rZe4Uy1r9boV1IQOjRvHmrpPbvZ"},"mode_info":{"single":{"mode":"SIGN_MODE_DIRECT"}},"sequence":"0"}],"fee":{"amount":[],"gas_limit":"200000","payer":"","granter":""},"tip":null},"signatures":["xw95FEwRC/lpgO5PrUgkjjTnV+rxbUjA1oni7EfBMo49BAtQea4l3I614UQh2eIzxdUCnSxW9wnZL/wrIqQouA=="]}

😢 I couldn't process your request...

😉 Here is the corresponding PR: https://github.com/axone-protocol/networks/pull/764

Test ok, let's close this


Statistics page

@calvintam236 I think quite a bit of important information is being missed here. Under the pool config it reads

Payout scheme
Minimum Payment w/o #
Minimum Payment w/ #
Pool Fee
Donation

Would it not be better to show:

Payout scheme
Minimum payment
Donation address taken from the pool admins nominated address in the config file
Pool Fee
Pool IP/host:Port

What do you think?

After a review on the example API response, it does not provide wallet address for admin. You're welcome to hardcode that in the UI yourself on your copy.
I am going to add pool address & ports on the "Connect" page, as API provides a lot of info that I don't think it fits in the stats page.

Ok no worries.
That makes sense as well i was just wary that it hasn't been included yet.
I did also notice that button to select the coin in the drop down menu only works once, after which seems to do nothing.

I have added pool address to stats page at 1cc1729. The pool info card will be moved to connect page soon.

@pfeiflelukas I have moved the pool info card to the new connect page. 👍

@calvintam236 Awesome work. I will take a look at the progress

@calvintam236 what is the difference between the two minimum payments?
$('#minimumPayment1').text(value.paymentProcessing.minimumPayment + ' ' + value.coin.type);
$('#minimumPayment2').text(value.paymentProcessing.minimumPaymentToPaymentId + ' ' + value.coin.type);

By MiningCore config, the different is paying to a wallet with and without payment ID. For example, when you send to a exchange wallet, it requires you to have payment ID.


Create Page(s) for Partner and Promote Events

To include:
Partner

[x] Count of Partner Events
[x] Map of location of Partner Events (pulled from Partner Programme View on AirTable)
[x] Number of Partner Events over time (pulled from Partner Programme view on AirTable)

Promote

[x] Count of Promote Events
[x] Map of location of Promote Events (where this can be gleaned)
[x] Number of Promote Events over time

Blocked by #123

Data prep in #150

@taz-chiles This is ready to start, at least. I'm not completely convinced by the data that I've extracted, but propose we make a start and use that to have the discussion about data quality / content.
You should find /metrics/events/partner/ and /metrics/events/promote/ folders with _data directories. You should be able to plot number of events by ward and over time from those. Maybe not yet aggregated over time. No information about attendees that I can see.

I have created a new branch for now and pushed changes to  main/122-create-pages-for-partner-and-promote-events
The bare bones are on there for each, a headline event count, hexmap with events per ward and a line chart of events over time. They're both identical for now and need some content.
Looking into the data, there are several events (15 from partner and 14 promote) missing a ward code therefore currently not shown on the map.
The sum of Partner events in by_ward (25) and by_month (22) are different, however the two values are the same for Promote.
Will have a chat with @ODILMichelle this afternoon about this ticket and #133

Proposing we close this ticket as completed then I'll create new tasks for the above, and for the actions that came out of my meeting with Sarah last week. Thoughts? @ODILMichelle @gilesdring

Closing #122 as completed.


fix(demo): address refresh after save

Description
closes: https://github.com/shopware/frontends/issues/340
Type of change

[X] Bug fix (non-breaking change which fixes an issue)

Additional context
Passing the success event to the next component to trigger a reload after the address is saved.

@BrocksiNet  I checked it in PR preview and the problem still exist

Thx for testing @kstala. And yes I missed one thing.
Pushed the fix for the "New Address" Button.
I was only testing with the "Edit Address" Button.
:+1:


Restore backwards compatibility with applications using input.contentType

Fixes #633

rebased, fixed the checkstyle issues, squashed the commits - merged.


feat: store a hash of the device config used during the interview

This PR implements a hash method that condenses the configuration file used during an interview into a buffer that can easily be compared. This is stored and can be used to keep track of changes to config files which likely require a re-interview to be picked up.
fixes: https://github.com/zwave-js/node-zwave-js/issues/4079
for: https://github.com/zwave-js/node-zwave-js/issues/2909

@zwave-js-bot automerge


Blueprint file polygonal mesh "yields no data" unless it has offsets.

Describe the bug
I made a really simple 2D topology with 2 polygonal zones and when I converted it to a root file so VisIt could read it, the file read but VisIt said that it had no data when I made a mesh plot. I added an offsets array and then VisIt could successfully plot the mesh. It seems to me that if the offsets are not present, and the Blueprint reader needs them, that it could call generate_offsets. Offsets are optional.
Helpful additional information

VisIt yielded no data when the file lacked offsets.

To Reproduce
Steps to reproduce the behavior. For example:

open the file
Add a mesh plot
Draw

Expected behavior
I expected Visit to make a mesh plot with 2 squares.
Attachments
Note: this file needs be run through relay::io::blueprint::save_mesh().
coordsets:
  coords:
    type: "explicit"
    values:
      x: [0.0, 1.0, 1.0, 0.0, 2.0, 3.0, 3.0, 2.0]
      y: [0.0, 0.0, 1.0, 1.0, 0.0, 0.0, 1.0, 1.0]
topologies:
  test:
    type: "unstructured"
    coordset: "coords"
    elements:
      shape: "polygonal"
      connectivity: [0, 1, 2, 3, 4, 5, 6, 7]
      sizes: [4, 4]
      # NOTE: uncomment offsets and the file will work.
      #offsets: [0, 4]

Desktop

rzgenie/Linux
VisIt 3.3.3

This looks like a bug within Conduit. The provided mesh does not succeed conduit.blueprint.mesh.verify. The verify failure information is provided:
coordsets:
  valid: "true"
  coords:
    type:
      valid: "true"
    info:
      - "mesh::coordset::explicit: 'type' has valid value 'explicit'"
      - "mesh::coordset::explicit: 'values' is an mcarray"
    values:
      valid: "true"
    valid: "true"
topologies:
  valid: "false"
  test:
    coordset:
      valid: "true"
    type:
      valid: "true"
    info:
      - "mesh::topology::unstructured: 'type' has valid value 'unstructured'"
    elements:
      valid: "false"
      shape:
        valid: "true"
        info:
          - "mesh::topology::shape: has valid value 'polygonal'"
      connectivity:
        valid: "true"
      errors:
        - "o2mrelation: requires both 'sizes' and 'offsets' specs"
      info:
        - "o2mrelation: applying relation to path 'connectivity'"
    valid: "false"
valid: "false"

When I tried this with quads instead of polygons it worked fine. I will investigate within Conduit Blueprint.

https://github.com/LLNL/conduit/blob/v0.8.8/src/libs/blueprint/conduit_blueprint_o2mrelation.cpp#L107

We should use generate_offsets before the verify step is called to make sure that this works in the blueprint plugin. Also will investigate in Conduit: https://github.com/LLNL/conduit/issues/1175


Switch from mountpoints to contentSourceUrl and contentSourceType

Mountpoints will be deprecated

:tada: This issue has been resolved in version 6.45.2 :tada:
The release is available on:

GitHub release
v6.45.2

Your semantic-release bot :package::rocket:


Any chance this binding will get updated to work with PhysX 5??

As PhysX 5 was recently Open Sourced - https://github.com/NVIDIA-Omniverse/PhysX

Hello.
I've actually played with PhysX 5 this weekend and it's very cool although I must confess I'm disappointed that it's focused on Windows platform... while it shouldn't be too hard to port it to say macOS and consoles, mobile is certainly a mission and for game development that's not good news. On top of that, the GPU accelerated code was kept proprietary. That being said, PhysX 5 is definitely the best option depending on your requirements, although it's now a much more niche product, which is aligned with the scope of Nvidia's Omniverse.
To answer your question: there's a small chance I'll update this to PhysX 5 given my very limited time available for personal side projects these days. The much narrower scope of PhysX 5 and the availability of Bepu Physics 2 as a reasonable alternative for most use cases also diminished my incentives to work on this. PhysX 5 does provide value like articulations, PBD, a few extra joints, different solvers, Flex and Blast integration, as well as USD support and substantial development backed by a big company, so it would be useful to have C# bindings.
On a more general note, is there a specific reason you're interested in PhysX bindings for C# and not say Jolt or just using the native Bepu 2?
I will keep this open for others and if I ever start working on an update I'll reply here.

@Alan-FGR thanks for the detailed response. Greatly appreciated!

You're welcome 😊... Well, I would say check those out. Bepu 2 is incredibly fast on modern processors when compiled with recent RyuJIT versions. It scales impressively well to multiple processor cores and you won't be paying any interop overhead. Jolt is also pretty fast although in my tests I wasn't happy with some simulation quality but maybe I was just pushing it too far. Both (on CPU) are top-tier performance wise along with PhysX. Jolt has a detailed paper on performance comparing it with PhysX 4 (which isn't that far from PhysX 5 as PEEL shows). Bepu 2 contributors also did some less scientific benchmarks but all of these are definitely comparable in performance, in most typical real-world scenarios they will perform within a margin small enough that when not negligible is definitely not a decisive factor.

auto ret = *(new std::remove_pointer<PxGroupsMaskPtr>::type());
auto heap = new char[sizeof PxGroupsMask];

There are many similar writing methods in the code, wouldn't this cause a memory leak?


Gradient Support for Unique operator

I am trying to run a custom graph with only Unique op for a debugging.
with tf.GradientTape() as g: y = tf.unique(x) dy_dx = g.gradient(y, x)
The Forward pass runs fine, but getting this error during Backward pass:

LookupError: gradient registry has no entry for: Unique

Gradient yet to be supported for Unique (or) there is no gradient for Unique ? Please help me understand why incase if its the second one.

@Prasandhmcw please provide us with complete executable code and the tensorflow version to replicate the issue faced by you in our environment.

File : (please rename to .py)
unique.txt
TF version :
>>> tf.__version__ '1.14.0'

i have replicated the code shared and issue persist, please find the gist here

@gowthamkpr the labels have been changed, does this mean Gradient for Unique is not yet supported ?

I think you have to register this op as mentioned here @Prasandhmcw

@gowthamkpr But this ain't a Custom Op. Its one of the TF's operator - https://www.tensorflow.org/api_docs/python/tf/unique

I don't belive there's a gradient, but re-assigning to Yong Tang for double-checking.

Hi There,
We are checking to see if you still need help on this, as you are using an older version of tensorflow which is officially considered end of life . We recommend that you upgrade to the latest 2.x version and let us know if the issue still persists in newer versions. Please open a new issue for any help you need against 2.x, and we will get you the right help.
This issue will be closed automatically 7 days from now. If you still need help with this issue, please provide us with more information.


add function to remove or update comment in a cell

when we try to add comment to a cell with comment, when open the excel file, the excel program will complain about 'there is an error occur, but we has recovery from it'

Hi @coreyzzp, thanks for your feedback, could you provide any code and attachments to reproduce this issue?

func TestCreateExcelAndUpdateComment(t *testing.T) {
target := "test.xlsx"
target2 := "test-after.xlsx"
{
var err error
fd := excelize.NewFile()
err = fd.AddComment("Sheet1", "A1", fmt.Sprintf({"author":"Excelize: ","text":"This is a comment" }))
require.Nil(t, err)
err = fd.SaveAs(target)
require.Nil(t, err)
// here open test.xlsx is find
}
{
	fd, err := excelize.OpenFile(target)
	require.Nil(t, err)
	err = fd.AddComment("Sheet1", "A1", fmt.Sprintf(`{"author":"Excelize: ","text":"hello world"}`))
	require.Nil(t, err)
	err = fd.SaveAs(target2)
	require.Nil(t, err)
	// now open test-after.xlsx an error popup
}

}
open test.xlsx

open test-after.xlsx

it will be good to has a method to delete or update comment  in a cell

This lib doesn't support modify comment and set the comment repeatedly on one cell currently. I've add this feature support in the Roadmap.

thx~

find an article about "comments" and "notes": The difference between threaded comments and notes

[WeOpen Star] I would like to help

[WeOpen Star] I would like to help


Bug42732and44390

bug #42732 make all place holders in advanced search consistent with field name in person finder in fat client.
bug #44390 the format for keyword doesn't work and the generated expression from advanced search should be equivalent to direct input with the same expression in simple search.

Looks good to me 👍


Traininig errors with 2 GPUs

Traceback (most recent call last):
File "tools/train.py", line 113, in
launch(
File "/home/leesoon/Projects/Detection/YOLO/YOLOX/yolox/core/launch.py", line 58, in launch
mp.spawn(
File "/home/leesoon/anaconda3/lib/python3.8/site-packages/torch/multiprocessing/spawn.py", line 230, in spawn
return start_processes(fn, args, nprocs, join, daemon, start_method='spawn')
File "/home/leesoon/anaconda3/lib/python3.8/site-packages/torch/multiprocessing/spawn.py", line 188, in start_processes
while not context.join():
File "/home/leesoon/anaconda3/lib/python3.8/site-packages/torch/multiprocessing/spawn.py", line 130, in join
raise ProcessExitedException(
torch.multiprocessing.spawn.ProcessExitedException: process 1 terminated with signal SIGKILL
Traceback (most recent call last):
File "", line 1, in
File "/home/leesoon/anaconda3/lib/python3.8/multiprocessing/spawn.py", line 116, in spawn_main
exitcode = _main(fd, parent_sentinel)
File "/home/leesoon/anaconda3/lib/python3.8/multiprocessing/spawn.py", line 126, in _main
self = reduction.pickle.load(from_parent)
_pickle.UnpicklingError: pickle data was truncated

This is caused because your memory is not enough, you could modify num_workers here to samller number and try again.

This exception is raised because your memory is not enough, you could modify num_workers here to samller number and try again.

Thank you for your prompt response. The problem has been solved.


Update targets/ dir to match current artifacts in metadata

remove obsolete revocation/revocation.list and rekor.0.pub: Neither is included in current TUF metadata
add registry.npmjs.org/keys.json: This file is included in the current metadata

targets/ now matches the metadata in repository/repository and artifacts in repository/repository/targets (apart from trusted_root.json that has been modified in targets/ after the last signing event).
This is part of #1247 (tuf-on-ci uses this directory to generate new targets metadata: this means it should not contain obsolete files)

I'll try to kick DCO with close & reopen but may have to make a commit message if that does not work


Bug fix/8472 variables and flow control are missing for old scripts

Bug fix/8472 variables and flow control are missing for old scripts

 Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- Ginger/GingerCoreNET/Run/RunListenerLib/ExecutionLoggerManager.cs  2

See the complete overview on Codacy


[#3243] Add response data during file upload to handle metadata status changes

[#3243] This PR extends the logic used to render metadata status changes of resource landing page to functionality regarding file uploads.
Note that the duration of the message has been incremented to 8 seconds (up from 3 seconds) to allow the message to be read.

Pull Request Checklist:

[x] Positive Test Case Written by Dev

[x] Automated Testing

[x] Sufficient User and Developer Documentation

[x] Passing Jenkins Build

[ ] Peer Code review and approval

Positive Test Case

Create a new resource.
Add a Title, Abstract and Keywords.
Add some content files.
At this point the metadata status message should appear indicating that the resource can be made Public.

Cool, thanks for picking this one up.

@sblack-usu - Good catch, I forgot to add the rest of the logic to update the buttons. I have done so no. Please have another look when you get a chance.
The time this message appears was incremented from 3 seconds to 8 seconds. Based on my judgment, three seconds wasn't enough time for reading this message. But since this message now stays longer, it was not immediately obvious that it would go away. And that is way the progress bar was added.

@Maurier - I'm approving the change functionally... I think it's worth passing the progress bar change by someone like @Lizabrazil.  It is introducing a new user feedback mechanic.

@Maurier @sblack-usu I think we should try to avoid introducing UI elements that are not consistent throughout the website. If a user see this and notices it, they would expect that it to show up on other pop ups on the website. Also, progress bar usually indicates that something is happening and in this it is not in progress of an action. I'd say either keep the increased time and remove the bar or just make it a pop up that has to be exited out of. We have the banner up top for when they create a resource about adding keywords, etc. So this pop up is just an additional important reminder.

@Lizabrazil, @sblack-usu - Understood, I have removed the progress bar indicator from the message. This looks exactly as before except for the increased timer in order to be able to read the message.

@Maurier - Could you add an x in the top right corner of the popup so the user can close it like?

@sblack-usu - I have added the button. Please have another look when you get a chance.


Added Ludo Game Board Design

Description 📜
Added Ludo Game Board Design
Fixes #585

Type of change 📝

[x] Add a new project

Domain of Contribution 📊

[x] Project using only HTML & CSS

Checklist ✅

[x] I have performed a self-review of my own code or work.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] My changes generates no new warnings.
[x] I'm GSSoC'22 contributor

Screenshots / Gif (Optional) 📸

Added readme file do check


Test install interface

Description
This PR adds tests for the package install interface. I chose to skip the platforms that are either too hard to test or have a broken install interface. The project that is consuming the install interface does little more than find the package and build its headers. This seems to be sufficient.
These tests will better enable some fixes to install code and CMake changes that result in more generated files which we must ensure get installed correctly. I'm happy with how little code ended up being necessary to implement these.

SFMLBuildMaster: Build this please.

Rebased to get new CI jobs.

SFMLBuildMaster: Build this please.

Because these are tests and not examples, I moved them from examples/ to tests/ and renamed some things accordingly. Now this program is called test-sfml-install which matches the names of all the other test executables. This is not meant to ever get run though so it will not get registered with CTest.
I also instantiated some objects in here to better test for linker issues. I picked a few different types from each module.

SFMLBuildMaster: Build this please.

SFMLBuildMaster: Build this please.

SFMLBuildMaster: Build this please.

SFMLBuildMaster: Build this please.

SFMLBuildMaster: Build this please.

SFMLBuildMaster: Build this please.

🥳


Vickel: Watch usdt-eth20.com

Vickel requests the watch of the watch_keyword usdt-eth20\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

usdt-eth20\.com has been seen in 0 true positives, 0 false positives, and 0 NAAs.

Approved by cigien in Charcoal HQ


have all 4 quadrants shown in line chart

Hi
I need to have a the X,Y center point in the middle of the chart so all the 4 quadrants are active. it is possible in some charts like scatter, or bubble but I need it in line chart .
How can I do that in version 2 ?

@makarbasi I think this is what you want in your config. It will put (0,0) in the center of your graph. You'll probably want to set the size of the canvas container to be a square in this case to prevent stretching.
config = {
    scales: {
        xAxes: [{
            ticks: {
                min: -10,
                max: 10
            }
        }],
        yAxes: [{
            ticks: {
                min: -10,
                max: 10
            }
        }]
    }
};

@etimberg
Thank you for your reply.
this is the code:
var config = {
type: 'line',
data: {
labels: ["January", "February", "March", "April", "May", "June", "July"],
datasets: [ {
hidden: true,
label: 'hidden dataset',
data: [randomScalingFactor(), randomScalingFactor(), randomScalingFactor(), randomScalingFactor(), randomScalingFactor(), randomScalingFactor(), randomScalingFactor()],
}, {
label: "My Second dataset",
data: [randomScalingFactor(), randomScalingFactor(), randomScalingFactor(), randomScalingFactor(), randomScalingFactor(), randomScalingFactor(), randomScalingFactor()],
}]
},
options: {
responsive: true,
title:{
display:true,
text:'Chart.js Line Chart'
},
            scales: {
    xAxes: [{
        ticks: {
            min: -10,
            max: 10
        }
    }],
    yAxes: [{
        ticks: {
            min: -100,
            max: 100
        }
    }]
}
        }
    };

and it is how I periodically generate new data:
$(document).ready(function() {
            setInterval(function() {

			//if (config.data.datasets.length > 0) {
            var month = MONTHS[config.data.labels.length % MONTHS.length];
            config.data.labels.push(month);

            $.each(config.data.datasets, function(i, dataset) {
                dataset.data.push(randomScalingFactor());

            });

            window.myLine.update();
   //     }

			config.data.labels.splice(-1, 1); // remove the label first

        config.data.datasets.forEach(function(dataset, datasetIndex) {
			updateGraph(dataset);
			dataset.data.shift();
        });

        window.myLine.update();

			}, 1000);

I also have attached the .txt file of the html file.
this is how it looks:

As you see, the Y axes is still at right side not in the middle.
Thanks alot
Amin
line.txt

@makarbasi you have a text scale for the X-axis, not numbers. So the -10/10 values wouldn't do anything. I haven't tested this but my guess is that your X-axis should look like this:
xAxes: [{
        ticks: {
            min: 'January',
            max: 'July'
        }
    }],

This should theoretically put your center at "April". Give it a try and report back, would be interested to know whether this works.

I don't think @sassomedia's solution will work with a category scale (default X axis type). There is currently no way to move the left axis to the middle. Tagging as an enhancement.


[iOS] added property to turn off data store handling table operations

Used for custom implementation of data insertion and requiring the sync context to only handle server message creation.
Won't cause any breaking changes to existing clients as the property for the MSCoreDataStore will default to YES. Does allow custom implementations per app for insertion into the data store, as experimented with in the multiple-contexts branch.

Hi @damienpontifex, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by Microsoft and real humans are currently evaluating your PR.
TTYL, AZPRBOT;

This is just grabbed from the other branch?

Yes. But just the control properties.
i.e. leaves the actual implementation of the observer separate. I thought pulling this in wouldn't have any effect on clients that didn't care, but allow some to implement custom insert logic. Similar to what we have done in the multiple-contexts branch, but bringing that forward into the MobileApp so I can keep that implementation in my project while not releasing that feature to the public build in here.


Integration with Orthanc DicomWeb with HTTP Authorization

Description
Is there any documentation which describes the steps to use OHIF viewer with Orthanc DicomWeb which has HTTP authentication ?
I have given it couple of tries but it work only for the first view where the patient list is shown and fails when clicking on a patient to view the images.  It asks for the orthanc password. My guess is OHIF Viewer is not sending the Authorization Header in this ajax request. (Snapshot at the bottom)
I am using docker-compose for latest orhtanc-plugins and ohif viewer
My use case is to use the viewer to show the user dicom images, who doesnt any idea about the orthanc as the backend. Also i can't disable orhtanc's authentication as that would be a security issue.
Any help would be appreciated.
Also is there a way so that the dicomweb user and password can be hidden as it is clearly visible in the app-config.js file which gets down loaded. Basically a better way to protect the dicomweb credentials.
Here is my docker-compose
version: '3.6'
services:

  viewer:
    image: ohif/viewer:v<IP_ADDRESS>95
    container_name: viewer
    depends_on:
      - orthanc
    restart: always
    ports:
      - '80:80'
    networks:
      - frontend
    volumes:
      # Nginx as a reversed proxy for orthanc and the viewer
      - ./config/nginx.conf:/etc/nginx/conf.d/default.conf:ro
      # OHIF Viewer configuration to reach DICOMWeb endpoints
      - ./config/viewer.js:/usr/share/nginx/html/app-config.js:ro

  orthanc:
    image: jodogne/orthanc-plugins:1.6.0
    container_name: orthanc
    restart: always
    networks:
      - frontend
    volumes:
      - ./config/orthanc.json:/etc/orthanc/orthanc.json:ro
    command: /etc/orthanc/orthanc.json

networks:
  frontend:

Here is the relevant orthanc config:
"AuthenticationEnabled" : true,
  "RegisteredUsers" : {
    "final1":"final1"
  },

  "DicomWeb" : {
    "Enable" : true,            // Whether DICOMweb support is enabled
    "Root" : "/dicom-web/",     // Root URI of the DICOMweb API (for QIDO-RS, STOW-RS and WADO-RS)
    "EnableWado" : true,        // Whether WADO-URI (previously known as WADO) support is enabled
    "WadoRoot" : "/wado",       // Root URI of the WADO-URI (aka. WADO) API
    "Ssl" : false,              // Whether HTTPS should be used for subsequent WADO-RS requests
    "QidoCaseSensitive" : true, // For QIDO-RS server, whether search is case sensitive (since release 0.5)
    "StudiesMetadata" : "Full", // How study-level metadata is retrieved (since release 1.1, cf. section below)
    "SeriesMetadata" : "Full"   // How series-level metadata is retrieved (since release 1.1, cf. section below)
  }

Here is the viewer.js dicom part
dicomWeb: [
        {
          name: 'ORTHANC',
          wadoUriRoot: 'http://localhost:80/pacs/wado',
          qidoRoot: 'http://localhost:80/pacs/dicom-web',
          wadoRoot: 'http://localhost:80/pacs/dicom-web',
          qidoSupportsIncludeField: true,
          imageRendering: 'wadors',
          thumbnailRendering: 'wadors',
          enableStudyLazyLoad: true,
	  	  requestOptions: {
		          auth: "demo:demo",
		          logRequests: true,
		          logResponses: false,
		          logTiming: true,
		          requestFromBrowser: true,
		        }
        },
      ],

Screenshot of send page:

You should not use HTTP Basic Auth unless you store your credentials on a server side somewhere.
Did you look at https://docs.ohif.org/deployment/recipes/user-account-control.html ?

Thanks for the reply @swederik
I was looking at it in the documentation however the documentation didn't follow the project/folder structure hence i dint pursue it further.  The documentation requires few update to run these examples as per the current project/folder structure. But i ll try to run it today by taking hints from the docs.
However the bigger problem still exists, of the ajax call request, to get the the dicom frame, doesn't have the authorization header as shown in the the screen shot at the bottom of my question which is causing a 401 Unauthorized error. The same is being faced by other user for the latest version as described in #1604

I was looking at it in the documentation however the documentation didn't follow the project/folder structure hence i dint pursue it further. The documentation requires few update to run these examples as per the current project/folder structure. But i ll try to run it today by taking hints from the docs.

Always happy to review and merge PRs for inconsistencies in docs ^_^

The same is being faced by other user for the latest version as described in #1604

Have you confirmed this is a regression? Does your config work with older Docker images?

Hey @dannyrb
So I managed to step up Keycloak, nginx, orthanc, and OHIF viewer. However, there were issues with the OHIF Viewer. Viewer is able to redirect to the keycloak login page, however when login is successful viewer is not adding the Authorization header (from the keycloak access_token) to the AJAX request it is making to orthanc DicomWeb urls. I have attached the screen shot below.
I can successfully login into orthanc explorer using the keycloak authentication but not OHIF.
Once my setup works successfully, I will create a PR for the keycloak recipe and the related documentation :)
My observations can be reproduced using the repo i have created for running the setup locally: https://github.com/FossilBlade/keycloak-nginx-viewer
OHIF Viewer Redirection to keycloak login Page:

Keycloak returning valid tokens after login success:

Login to keycloak success but Viewer not adding Authentication header to the AJAX call to orthanc:

I'm going to close this as a duplicate of: https://github.com/OHIF/Viewers/issues/1604

We recently added several recipes for implementing authentication with Keycloak in OHIF. You can find them here:
https://docs.ohif.org/deployment/user-account-control


chore(web-app): save page, pageSize, and query to localStorage

Closes #313

Need to get #260  in first

closing, might reopen once we get resolution on #313


Mujoco Viewer Setup as in 2.1.0

Dear Team,
We are working on migration from mujoco2.1 to mujoco3.1. I have referred the https://mujoco.readthedocs.io/en/latest/python.html#migration-from-mujoco-py.
I am unable to understand the set up of the mujoco viewer. I need to get the window which has no GUI tabs for the simulation set up, but just the simulation window with statistics (fps, steptime etc). Can you kindly help me in this regard?

See last bullet in this section

Thank you.


flakes.yaml: add TestEKSSuite/TestAdmissionControllerWithAutoDetected…

…Language

What does this PR do?
Followup to #32422 with a different suite test
Motivation
Describe how you validated your changes

Possible Drawbacks / Trade-offs
Additional Notes

/merge


How to run an inference on a data set with a model pretrained pointrcnn for example

Thank you for your great work in making the OpenPCDet project available for multi-object detection.
I followed Get Started to do a test on kitti's dataset but the command "python test.py --cfg_file cfgs/kitti_models/pointrcnn.yaml --ckpt /home/lume/OpenPCDet/stev_models/pointrcnn_7870.pth" didn't work for inference on my dataset downloaded from the official kitti.
OBS1: I followed the organization of folders as requested by the Get Started documentation.
I would just like to make an inference, can you help me?
I need set some path of my data set for inference?

When i run the demo works fine. But i need run in data set of kitti official.

It seems that you can already obtain the evaluation results. You want to make visualization on kitti validation set?

@jihanyang Exactly, I want to visualize the detection of my kitti dataset (not just one image, but all of them, all at once). Could you help me?

Another question, when I run test.py am I training and doing the evaluate inferring my dataset for 3D detection? My objective is to evaluate the model in my dataset and in the output I would like the visualization to be a video of my trajectory with the car, for example. Could you help me?

Sorry for late reply. You can add such visualization command  https://github.com/open-mmlab/OpenPCDet/blob/f221374a5cb9398fd089aa7194732c808c700355/tools/demo.py#L100-L103 to https://github.com/open-mmlab/OpenPCDet/blob/f221374a5cb9398fd089aa7194732c808c700355/tools/eval_utils/eval_utils.py#L66-L67

For the video, I don't have any experience on it.

@jihanyang I did add the lines of demo.py
https://github.com/open-mmlab/OpenPCDet/blob/f221374a5cb9398fd089aa7194732c808c700355/tools/demo.py#L6-L7
under of line 9
https://github.com/open-mmlab/OpenPCDet/blob/f221374a5cb9398fd089aa7194732c808c700355/tools/eval_utils/eval_utils.py#L9-L11
and did add
https://github.com/open-mmlab/OpenPCDet/blob/f221374a5cb9398fd089aa7194732c808c700355/tools/demo.py#L100-L103
under of line 65, replacing data_dict to batch_dict , because if not an error called "data dict is not defined"
https://github.com/open-mmlab/OpenPCDet/blob/f221374a5cb9398fd089aa7194732c808c700355/tools/eval_utils/eval_utils.py#L65-L67
and the output is printed from image

Note that the eval stays at zero even if I press ESC or Q to skip image and it returns eval: 0%

Hello @EstevanCandido, you code is correct. I also run visualization as you did. In my experience, the evaluation should continue after you close the open3d visualization box.
If you comment the added visualization codes, will the program run normal?


Update the title to show the packet name

When we start a new game, or load the UI state from the application store, we should update the website's title to include the packet name. This will require storing the filename in UIState, since we don't have that information when we create the new game (doing it when we load the packet is too early).
Setting it when we create a new game should be pretty easy. Setting it when we initialize UIState may be harder; this might be something we use mobx.autorun for.

I'm not sure we should do this anymore given that it's an embeddable component. Maybe the demo application could try to do this.

Should probably not be marked Low priority: there's no way to visually confirm what packet is loaded on screen at all otherwise.

It was marked low priority because this is really a bug for the demo (the component shouldn't overwrite the title), and when other software like TMS is out, there should be less dependency on using the demo.


Agree on test data needed

Background Information
Potential test data needed:
OE
SC (for study eye selection - confirm this is general use)
AE (for eye laterality)
Definition of Done
No response

Will test data be within admiral.test, or as it is Ophtha specific does it go to admiralophtha?

Ideally, test data and the program to create it would be live in admiral.test.  If its preferable, the optha team could initially create test data within the optha area, and then we (or I) could move it over.
Please see https://github.com/pharmaverse/admiral.test/tree/main/inst/data_scripts to get an idea of how some data was created for Onco.

Potentially need test data for rescue treatments, although I'm not sure which domain this would come under, as standard

yes, it would be nice to have intercurrent events data. In some of the ophtha studies we even created ICE ADaM datasets (ADICE & ADICESUM) to support the efficacy analysis. Instead of using SDTM data, we used mostly ADaM datasets, e.g. ADSL, ADCM, ADPR, to create these two because some of the flags need to be derived at ADaM level.
A question to the team: Are we going to add ICE datasets to our scope?

Thanks @aliceBIU -  I think we may need to wait for the estimand guidance to mature a little more before pursuing this in this space, and even then it would be a general admiral approach rather than Ophtha specific. For now I'd recommend we keep just the known standards in scope, and hopefully later on see how estimands are incorporated.

Ideally, test data and the program to create it would be live in admiral.test. If its preferable, the optha team could initially create test data within the optha area, and then we (or I) could move it over. Please see https://github.com/pharmaverse/admiral.test/tree/main/inst/data_scripts to get an idea of how some data was created for Onco.

Hi @millerg23 , the link is not working. Are you able to help. Thanks

Hi @millerg23 , Where should the test data stored?

Hi @eriola11 sorry for not replying sooner, here is the relevant link:
https://github.com/pharmaverse/admiral.test/blob/main/README.md
Ideally the test data would be stored in admiral.test.


Display datetime when HW spots were saved

SpotFormActivity receives a "datetime" field when place info is downloaded. Display this field as is. Make sure the edit button is disabled or not shown.
Format:
"datetime":"2010-07-29 15:12:20"

If converting it to local standard (which uses Date()) is better, this can be used:
DateFormat df = new SimpleDateFormat("yyyy-MM-dd HH:mm", Locale.ITALIAN);
Date dateBeforeDST = df.parse("2018-03-25 01:55");


Some binaries missing in release jdk-17.0.9+9 that got added in jdk-17.0.9+9.1

Question
I'm maintaining a tool for packaging JVM applications and it uses Adoptium releases to package the applications. Users of the tool can configure an Adoptium release to package their applications with. I have built the tool such that it accepts a single version such 17.0.6+10 and expects to find binaries for each platform such as Windows, macos, Linux with the respective architecture suffixes at https://github.com/adoptium/temurin17-binaries/releases/download/[version]/[filename]. This has been working OK for a while in the past, but now with jdk-17.0.9+9 it seems no Windows artifacts have been released and then jdk-17.0.9+9.1 looks like it adds the missing binaries. However our algorithm for determining the exact path to retrieve the binaries from the web is not working as it doesn't include any logic for this kind of situtation. My questiones are:

is there any place such as a release notes statement somewhere where I can learn about a specific release, which OS's are supported by it etc?
Is it generally a naive assumption that a release usually includes binaries for all OS's and architectures and should I foresee such situations in the future (by making it possible to specify a specific JVM version per OS) or is generally a good assumption?
If the 9.1 release was just made to add the missing Windows files, is there maybe any URL that redirects the missing jdk-17.0.9+9 files to the jdk-17.0.9+9.1 ones? maybe my approach of retrieving the binaries from that location mentioned above is not the recommneded one?

https://adoptium.net/blog/2023/11/eclipse-temurin-8u392-11021-1709-and-2101-available/ mentions the Windows binary respin, but this likely doesn't help your automation story.
In the future, there will likely be cases, though we hope will not happen often, where a respin is needed, and we produce a dot release for particular platforms.
https://github.com/adoptium/api.adoptium.net/issues/829 discusses the challenge from the API perspective somewhat.

Thanks for the explanation. I think I'll just add some kind of mapping to the tool that lets it know how to map exceptional versions such as this one to the appropriate URLs.


Doc has outdated screenshots of Web Push in the portal

@sethmanheim can we please update this doc with updated screenshot. Currently Web Push isn't showing in the portal. Is this feature still available? see below

feedback from Microsoft Q&A: https://learn.microsoft.com/en-us/answers/questions/1425325/web-push-not-available-in-notification-hub?comment=question
Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: db792152-4bc3-37aa-f04a-d988be47bba8
Version Independent ID: ef78ce72-dc0a-cd24-8a3a-288188c5c48b
Content: Send browser (web push) notifications with Azure Notification Hubs
Content Source: articles/notification-hubs/browser-push.md
Service: notification-hubs
GitHub Login: @sethmanheim
Microsoft Alias: sethm

@Grace-MacJones-MSFT
Thanks for your feedback! We will investigate and update as appropriate.

Hi @Grace-MacJones-MSFT, sorry for the slow response. This feature is currently in preview -- you can access the browser push features on the portal by using this link: https://portal.azure.com/?feature.browserpush=true. I will update the documentation with this link ASAP. Thanks for pointing this out. #please-close


when logging an exception the "ClassName" property remains empty

Does this issue relate to a new feature or an existing bug?

[x] Bug
[ ] New Feature

What version of Serilog.Sinks.Elasticsearch is affected?  Please list the related NuGet package.
Serilog.Sinks.ElasticSearch, version 6.5.0
What is the target framework and operating system? See target frameworks & net standard matrix.

[x] netCore 2.0
[ ] netCore 1.0
[ ] 4.7
[ ] 4.6.x
[ ] 4.5.x

Please describe the current behavior?
When an exception is logged and sent to Elasticsearch, in Kibana I can see the exceptions property. Several subproperties in exceptions are filled as expected, like Message, Source, StackTraceString, but the property ClassName remains empty. This appears to be related to the fact that NO_SERIALIZATION is defined when compiling for netstandard1.3. (Because if NO_SERIALIZATION is defined, then var className = string.Empty; is used.)
Please describe the expected behavior?
I expect the ClassName property under the exceptions property to not be empty, but instead contain the full name of the type of the exception (e.g. System.InvalidOperationException).
If the current behavior is a bug, please provide the steps to reproduce the issue and if possible a minimal demo of the problem
I created a fork and I think I fixed it there (see the last 2 commits (633ae5efc19c8e5b2b64c4de192a057c88d7de9e and 338587206a101ba4d5732e03330a129a6da3f3d1) on https://github.com/roelandvh/serilog-sinks-elasticsearch) using exception.GetType().FullName, but I'm not sure that is a valid solution for this case (perhaps .GetType is too expensive in this context?).
Also I had to tweak the .csproj file to force NO_SERIALIZATION to be set (which I did not commit) because apparently everything was building and running as if targetting net45. (When I did this, the test actually failed when I removed my fix, and succeeded after re-applying the fix, so I'm confident it works as expected when NO_SERIALIZATION is set.)

I'm seeing this error currently. What do I have to do to apply the fix in #222 that supposedly fixes this?

Hey, @ffMathy. Which version do you use? The issue was fixed with adding target to .netstandard2.0, which was shipped in 7.2.0-alpha001 version.

Ah I see. Currently only using latest stable release. That makes sense, thanks :+1:


4B Visual Data Processing, error in Data Processing

When running command:
!git clone https://github.com/BardiaKh/UoC_ARS_VisualDataProcessing.git
!mv UoC_ARS_VisualDataProcessing/* .
get error:
Cloning into 'UoC_ARS_VisualDataProcessing'...
fatal: could not read Username for 'https://github.com/': No such device or address
mv: cannot stat 'UoC_ARS_VisualDataProcessing/*': No such file or directory
Thank you

Thank you for bringing this to our attention. We have fixed the issue, and it should work now.
I will close this issue, but feel free to re-open it if you need anything else.

Thank you very much! 4B Visual Data Processing is now working.


[Bug]

Search before asking

[X] I searched in the issues and found nothing similar.

Flink version
redo_log_catalog策略运行cdc程序，但是没有增量数据，是因为Oracle11G不支持redo_log_catalog属性，还是说online_log中的数据还没刷新到redo_log中
Flink CDC version
flink：1.16.1   cdc：2.3.0
Database and its version
Oracle11G
Minimal reproduce step
redo_log_catalog策略运行cdc程序，但是没有增量数据，是因为Oracle11G不支持redo_log_catalog属性，还是说online_log中的数据还没刷新到redo_log中
What did you expect to see?
1
What did you see instead?
1
Anything else?
No response
Are you willing to submit a PR?

[ ] I'm willing to submit a PR!

Considering collaboration with developers around the world, please re-create your issue in English on Apache Jira under project Flink with component tag Flink CDC. Thank you!


More user-friendly API.

I was trying to use this crate and stumbled upon the API. I figure that it's easier to just offer a redesign and ask for critique.
Basically, the changes are:

made cycles not public because I don't think it was supposed to be
renamed Config to Builder so that it makes a bit more sense
removed Ratelimit::new because it was confusing; it makes more sense to say Ratelimit::default
removed Ratelimit::configure and replaced it with Builder::new
renamed block to wait_for and added wait which is just wait_for(1)
wrapped clone_sender into an opaque Handle type with methods wait and try_go instead of send and try_send
renamed Ratelimit to Limiter
made run private and encapsulated it in a SyncLimiter, which spawns a run thread and offers the creation of Handle

It may be easier to understand the changes by just running cargo doc and viewing the changes directly. Let me know what you think of the changes!
A few other potential things that could be done to the docs:

Clarify exactly what quantum/capacity/interval actually mean, explaining the algorithm more in detail. I understand this but can't really fully word it right now.
Specify a few use case examples for configurations that make use of the above.

PS: thanks for the great crate!

Hi @clarcharr - thanks for your PR! I definitely want to make sure the library's API makes it easy to use - and admit there's definitely room for improvements. Let me take some time to review the changes in more detail so I can offer some meaningful review.

@clarcharr I like the changes. Seems like it's really going to make it much cleaner to use the library.
I found https://github.com/blankenshipz/oanda-rs/blob/master/src/client.rs which makes use of the multi-threaded version. Looks like the changes make sense within the context of that use-case.
Once the tests are passing, I'm happy to merge and cut 0.5.0

So I thought that I ran cargo test and it passed but I probably missed a lot. I'll fix these later today.

One other important change I made I figure I should point out: for a while I'd been adding deny(warnings) to my crates too, but it makes a lot more sense to do cfg_attr(test, deny(warnings)) to future-proof the crate from new lints being added.
So I updated that for this crate while I was at it.

(This should all work, and everything is ready to merge. I'd appreciate if you took another look at the rustdoc just to make sure everything makes sense before you do though.)

@clarcharr - I suspect you need to lower the capacity - as that sets the capacity of the mpsc::SyncSender. Since we're using the queue backwards, I suspect it's able to push the token onto the queue, and therefor doesn't block on call to wait(). Reducing the capacity to 1 might make sense for these tests?

That makes sense for the tests but what I'm more concerned about is the fact that Handle::wait and Limiter::wait have different functionality and I'm not quite sure how to reflect that in the names/docs.

Yeah, this actually makes describing the functionality challenging. I wonder if we should refactor to use a MPMC queue in the correct direction. crates.io/crates/mpmc is pretty fast.
Thanks for uncovering this issue though. Correctness is important, and it seems off in the current state. =)

Seems like a good idea! I don't mind merging what's there now (as it replicates all the existing functionality under a different API) and then modifying the underlying implementation later. The nice thing about using opaque types is that the underlying implementation can be changed without actually changing the API.
I mean, the only thing that feels wrong to me is that Handles can be used after a RateLimiter is dropped. I did document this behaviour for now, and this could be solved by mucking around with PhantomData to add extra lifetimes, but I'm not necessarily sure if that's a reasonable path to go down.

Totally. That was broken before. I think going back to the "normal" direction for the SyncLimiter is the most reasonable course. That should address the behavior if the RateLimiter is dropped too? (mpmc queue would back-up with tokens, and wait() would block indefinitely?)

@brayniac that one is actually solved by the fact that creating a SyncLimiter consumes the original Limiter, so, the original limiter will only be dropped if the SyncLimiter is dropped.
This is because when the SyncLimiter is dropped, an Arc<Atomic> bool is switched to false. This will get caught by the while loop in the running thread, signalling the thread to exit, dropping the original limiter.

Planning to merge this evening. I want to take one more look at the rustdoc first.

Merged. Thanks @clarcharr for your submission!


Migrations: Improve format of model snapshot (possibly using JSON)

Currently we are generating code that provides a shadow state equivalent of the CLR based model. We may need to improve the metadata API/model to properly handle the requirements of a snapshot... or move to another format (possibly JSON).

@rowanmiller we discussed with @bricelam and @ajcvickers today and we would like to use the core metadata API directly for this (see #1484). We would like move this one to the backlog.

@divega we need to work out how that plays with blocking shadow state entities since the model snapshot can't reference the actual CLR types.

@rowanmiller Do you mean that using the core metadata will make blocking shadow state entities harder?

@divega I meant that the model snapshot needs to be 100% shadow state since it can't reference the model classes. We were planning to block having entities that are 100% shadow state - but perhaps we just block this from the model builder API and allow it in core metadata (though we may want to see if there are places we should detect ad throw in the stack too if we detect a model with shadow entities).

@rowanmiller Ok. I believe that could be done regardless of how the model snapshot is represented. E.g. it could be done in the validation step described in #1205 or potentially in a separate validation step we would only perform while loading the model with the purpose of executing CRUD operations. I don't think the model snapshot would need to be validated in either way.

@rowanmiller I think what you said about blocking it only in the model builder API sounds good too (perhaps that is the same as saying we block in model validation). BTW disabling shadow state entries is tracked in #748.

@rowanmiller @divega I don't think using the core APIs will make it harder to block use of shadow state entities. The idea that has been mentioned most often is to have a check when the context instance is created. That is, you could build a model with shadow state entities, but if you tried to create a session for it, then we would throw. However, I think just removing the ModelBuilder API might be even better since people won't even be led down a path of trying to create them..

@ajcvickers Both sound good to me, remove it from top level API and then have a simple check when you create context.

Sound good.

@divega Is there anything left do to for this issue, or is it all tracked by #1484 now?

I am ok with closing it, but perhaps we could leave it open in the backlog to consider doing it in the future @rowanmiller @ajcvickers @anpete  what do you think?

If we don't have a specific reason to do it now I would close it


Use default parameter definition in scribble()

As per STANN.co's recommendation along with a suggestion from TabularElf on the GM Kitchen server, here's a PR for the adjusted default parameter definition in scribble(). I looked through the rest of the functions and this was the only one not using them.

On advice from Zach (YYG), we shouldn't edit a named param from the function signature. Thanks for your contribution but I can't accept this one.

All good. Nice to know about that performance oddity, I'll be sure to keep that in mind.


qtwebkit marked as insecure causes nixos-unstable to fail evaluation for dbus

Describe the bug
Due to qtwebkit-5.212.0-alpha4 being marked as insecure, it is preventing the serviceDirectories variable in nixos/modules/services/system/dbus.nix from being evaluated. Even if Qt or qtwebkit are not explicitly specified, it still causes this error message.
error: Package ‘qtwebkit-5.212.0-alpha4’ in /nix/store/rhpn666sxdwxdlksvmg49v81r5dcx33s-source/pkgs/development/libraries/qt-5/qtModule.nix:72 is marked as insecure, refusing to evaluate.

       Known issues:
        - QtWebkit upstream is unmaintained and receives no security updates, see https://blogs.gnome.org/mcatanzaro/2022/11/04/stop-using-qtwebkit/

       You can install it anyway by allowing this package, using the
       following methods:

       a) To temporarily allow all insecure packages, you can use an environment
          variable for a single invocation of the nix tools:

            $ export NIXPKGS_ALLOW_INSECURE=1

        Note: For `nix shell`, `nix build`, `nix develop` or any other Nix 2.4+
        (Flake) command, `--impure` must be passed in order to read this
        environment variable.

       b) for `nixos-rebuild` you can add ‘qtwebkit-5.212.0-alpha4’ to
          `nixpkgs.config.permittedInsecurePackages` in the configuration.nix,
          like so:

            {
              nixpkgs.config.permittedInsecurePackages = [
                "qtwebkit-5.212.0-alpha4"
              ];
            }

       c) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
          ‘qtwebkit-5.212.0-alpha4’ to `permittedInsecurePackages` in
          ~/.config/nixpkgs/config.nix, like so:

            {
              permittedInsecurePackages = [
                "qtwebkit-5.212.0-alpha4"
              ];
            }

       … while evaluating 'handleEvalIssue'

       at /nix/store/rhpn666sxdwxdlksvmg49v81r5dcx33s-source/pkgs/stdenv/generic/check-meta.nix:227:38:

          226|
          227|   handleEvalIssue = { meta, attrs }: { reason , errormsg ? "" }:
             |                                      ^
          228|     let

       … from call site

       at /nix/store/rhpn666sxdwxdlksvmg49v81r5dcx33s-source/pkgs/stdenv/generic/check-meta.nix:385:16:

          384|         {
          385|           no = handleEvalIssue { inherit meta attrs; } { inherit (validity) reason errormsg; };
             |                ^
          386|           warn = handleEvalWarning { inherit meta attrs; } { inherit (validity) reason errormsg; };

       … while evaluating the attribute 'no'

       at /nix/store/rhpn666sxdwxdlksvmg49v81r5dcx33s-source/pkgs/stdenv/generic/check-meta.nix:385:11:

          384|         {
          385|           no = handleEvalIssue { inherit meta attrs; } { inherit (validity) reason errormsg; };
             |           ^
          386|           warn = handleEvalWarning { inherit meta attrs; } { inherit (validity) reason errormsg; };

       … while evaluating the attribute 'handled'

       at /nix/store/rhpn666sxdwxdlksvmg49v81r5dcx33s-source/pkgs/stdenv/generic/check-meta.nix:383:7:

          382|       # or, alternatively, just output a warning message.
          383|       handled =
             |       ^
          384|         {

       … while evaluating the attribute 'passAsFile'

       at /nix/store/rhpn666sxdwxdlksvmg49v81r5dcx33s-source/pkgs/build-support/buildenv/default.nix:77:5:

           76|     # XXX: The size is somewhat arbitrary
           77|     passAsFile = if builtins.stringLength pkgs >= 128*1024 then [ "pkgs" ] else [ ];
             |     ^
           78|   }

       … while evaluating the attribute 'passAsFile' of the derivation 'qt-full-5.15.7'

       at /nix/store/rhpn666sxdwxdlksvmg49v81r5dcx33s-source/pkgs/stdenv/generic/make-derivation.nix:270:7:

          269|     // (lib.optionalAttrs (attrs ? name || (attrs ? pname && attrs ? version)) {
          270|       name =
             |       ^
          271|         let

       … while evaluating the attribute 'passAsFile'

       at /nix/store/rhpn666sxdwxdlksvmg49v81r5dcx33s-source/pkgs/build-support/buildenv/default.nix:77:5:

           76|     # XXX: The size is somewhat arbitrary
           77|     passAsFile = if builtins.stringLength pkgs >= 128*1024 then [ "pkgs" ] else [ ];
             |     ^
           78|   }

       … while evaluating the attribute 'passAsFile' of the derivation 'system-path'

       at /nix/store/rhpn666sxdwxdlksvmg49v81r5dcx33s-source/pkgs/stdenv/generic/make-derivation.nix:270:7:

          269|     // (lib.optionalAttrs (attrs ? name || (attrs ? pname && attrs ? version)) {
          270|       name =
             |       ^
          271|         let

       … while evaluating 'check'

       at /nix/store/rhpn666sxdwxdlksvmg49v81r5dcx33s-source/lib/types.nix:482:15:

          481|       descriptionClass = "noun";
          482|       check = x: isCoercibleToString x && builtins.substring 0 1 (toString x) == "/";
             |               ^
          483|       merge = mergeEqualOption;

       … from call site

       at /nix/store/rhpn666sxdwxdlksvmg49v81r5dcx33s-source/lib/modules.nix:749:22:

          748|       if isDefined then
          749|         if all (def: type.check def.value) defsFinal then type.merge loc defsFinal
             |                      ^
          750|         else let allInvalid = filter (def: ! type.check def.value) defsFinal;

       … while evaluating anonymous lambda

       at /nix/store/rhpn666sxdwxdlksvmg49v81r5dcx33s-source/lib/modules.nix:749:17:

          748|       if isDefined then
          749|         if all (def: type.check def.value) defsFinal then type.merge loc defsFinal
             |                 ^
          750|         else let allInvalid = filter (def: ! type.check def.value) defsFinal;

       … from call site

       at /nix/store/rhpn666sxdwxdlksvmg49v81r5dcx33s-source/lib/modules.nix:749:12:

          748|       if isDefined then
          749|         if all (def: type.check def.value) defsFinal then type.merge loc defsFinal
             |            ^
          750|         else let allInvalid = filter (def: ! type.check def.value) defsFinal;

       … while evaluating the attribute 'value'

       at /nix/store/rhpn666sxdwxdlksvmg49v81r5dcx33s-source/lib/modules.nix:760:27:

          759|     optionalValue =
          760|       if isDefined then { value = mergedValue; }
             |                           ^
          761|       else {};

       … while evaluating anonymous lambda

       at /nix/store/rhpn666sxdwxdlksvmg49v81r5dcx33s-source/lib/types.nix:492:14:

          491|       merge = loc: defs:
          492|         map (x: x.value) (filter (x: x ? value) (concatLists (imap1 (n: def:
             |              ^
          493|           imap1 (m: def':

       … from call site

       … while evaluating the attribute 'serviceDirectories' of the derivation 'dbus-1'

       at /nix/store/rhpn666sxdwxdlksvmg49v81r5dcx33s-source/pkgs/stdenv/generic/make-derivation.nix:270:7:

          269|     // (lib.optionalAttrs (attrs ? name || (attrs ? pname && attrs ? version)) {
          270|       name =
             |       ^
          271|         let

       … while evaluating 'check'

Steps To Reproduce
Steps to reproduce the behavior:

Try running nix build or nix-build of a derivation that is defined in config.system.build in a nixOS definition.

Expected behavior
dbus should evaluate and run.
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Using  nixos-unstable in a project but nixos-22.05 on host
Notify maintainers

@worldofpeace
@qknight
@ttuegel
@periklis
@bkchr
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
 - system: `"x86_64-linux"`
 - host os: `Linux 5.15.71, NixOS, 22.05 (Quokka), 22.05.4274.cf63ade6f74`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.8.1`
 - channels(root): `"expidus, nixos-22.05"`
 - channels(ross): `"expidus"`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos

 … while evaluating the attribute 'passAsFile' of the derivation 'qt-full-5.15.7'

From the trace it seems to be that somewhere you add qt5Full to your system packages. qt5Full isn't referenced in Nixpkgs from anywhere other than hsqml.

I ran grep on my stuff for qt5Full and I get nothing.

Looking for Qt5, I see that my version of nixos/modules/installer/cd-dvd/installation-cd-graphical-calamares-gnome.nix has Qt5 in it but I am not building the derivation from that. I am building this which does not mention Qt5 anywhere. Not sure how Qt5 is being included and nix repl doesn't show why.

Surely there must be a general way to resolve this back to a setting in /etc/nixos? I'm in the process of upgrading from nixpkgs 22.05 to 22.11, and bisecting my entire configuration is going to be extremely painful.

@l0b0 You can permit the use of qtwebkit in NixOS with
nixpkgs.config.permittedInsecurePackages = [
  "qtwebkit-5.212.0-alpha4"
];

in your configuration. However, I think it should be fixed upstream so wherever this is being called, it doesn't require everyone to add that.

Fixed my case by checking for references to the package using rg -l qtwebkit-5.212.0-alpha4 /nix/store and then uninstalling the only package which used it.

closing as there are no actions we can do. qtwebkit is deprecated.


Asp.NET 5 Sample Fixups

Added NuGet.config to identify the NuGet sources.
Doesn't require SSL for ASP.NET 5 sample. I am not aware of any easy way to have HTTPS binding set in all platforms when you run the sample. So, I just disabled this for the sample to work. May not be the desired behaviour though :disappointed: One alternative would be to provide some scripts to run for each platform to set this up and add the info to Readme.

Hi @tugberkugurlu, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.
TTYL, DNFBOT;

Also, hooked logging in for ASP.NET 5 sample. Looks something like this now:

cool. thanks!


[FEATURE] Discord .NET Version

Why do you want this feature? What is the problem?
Brackeys Bot is running Discord.Net v2.1.1.
A clear and concise description of what you want to happen.
Which is not the latest Discord .Net v2.2.0, so can you upgrade it?

From what I can find there is no changelog (yet) for v2.2.0, so there is no reason for us to upgrade without reason.

Okay thanks xD


give some love to x/oauth2

As regular user of x/oauth2 outside of the common providers I've noticed that x/oauth has a semi-abandoned feeling to it.
Readme links to abandoned Travis:

https://github.com/golang/oauth2/issues/640

Resolved issues are not closed:

https://github.com/golang/oauth2/issues/481

An, most importantly, x/oauth2 could offer a lot more flexibility for more than basic use cases with very little additional api looking at these issues:

https://github.com/golang/oauth2/issues/354
https://github.com/golang/oauth2/issues/483
https://github.com/golang/oauth2/issues/484
https://github.com/golang/oauth2/issues/521
https://github.com/golang/oauth2/issues/526
https://github.com/golang/oauth2/issues/533

Requests for feedback on open issues are not answered. Of course the Go team sets the priorities- however I'd like to raise the point of community need for more oauth2 flexibility.
/cc @sagikazarmark

Duplicate of #56402

https://github.com/golang/go/issues/56402#issuecomment-1374003935

https://dev.golang.org/owners records the primary x/oauth2 code owner as @bradfitz. Secondary owners are @rakyll @broady @shinfan @codyoss. The responsibilities of code owners aren't documented. It looks like reviews  are automatically assigned to the primary owner.

Any volunteers for new owners? I'd consider it if the responsibilities are explained.


Add www.drawk.cab to the webring

Not sure about data-lang="en". The link isn't in any particular language. But the site is in English so I'm leaving it there.

Oh also sorry the image is a bit small. I'll fix that when I have more internet.

oh jeez i just realized i need to switch image depending on prefers-color-scheme. definitely a more internet problem

Please let me know if the site doesn't fit the ring's vibe. I've enjoyed browsing through it and though my efforts are a bit scattershot I'd be honoured to be included.
Thanks!

I'll have a second look today : )

Hi!
Sorry for the extreme delay, I've been away from bandwidth for too long, I've had another look at your site today and I'm happy to bring it in to the webring, again, sorry for the long wait. Love your site :)

Thanks :)


Summary is redundant in ReviewDetails

In ReviewDetails:
https://github.com/brandingbrand/flagship/blob/b6ba811acea1db8b5b2da201fcbc3b45f6062106/packages/fscommerce/src/Review/types/ReviewDetails.ts
summary is completely redundant to statistics, because statistics extends summary and all of its new keys are optional. This can cause confusion because a user won't know whether to put something into summary or statistics.

Another redundant value:
https://github.com/brandingbrand/flagship/blob/b6ba811acea1db8b5b2da201fcbc3b45f6062106/packages/fscomponents/src/components/ProductItem/ProductItem.tsx#L50
swatchesProps also contains items: SwatchItemType[]
These are merged together in ProductItemSwatches, though the component only checks to see if swatchItems has a list, not if swatchesProps.items does:
https://github.com/brandingbrand/flagship/blob/b6ba811acea1db8b5b2da201fcbc3b45f6062106/packages/fscomponents/src/components/ProductItem/components/ProductItemSwatches.tsx#L35


Add in ability to delete all fields in session data

A /creds route allows more flexibility for operations with the credentials table in the future, so my vote is for /creds/session or /credentials/session. I don't think we would do anything else with session, since most of the operations with session_data are part of the webauthn protocol.

A /creds route allows more flexibility for operations with the credentials table in the future, so my vote is for /creds/session or /credentials/session. I don't think we would do anything else with session, since most of the operations with session_data are part of the (public) webauthn protocol under /auth.

Fair enough. I didn't think we'd do anything else with credentials so i thought maybe there's no point in overthinking it. I like /credentials more since its a real word but otherwise sgtm.


reg loss became Nan when it came to 2.6k iters

Hi,
It seems that the reg loss of training process become Nan, when it comes to 2.6k iters.
Besides, how can I make use of the network to test my own imgs?
best wishes!

Hello @mxmxlwlw ,
There are a lot of issues at the moment facing the problem, that the training will be NaN or stop after some iterations, did you take a look at them and found that this is a complete new issue ?
See #42 , #24
Also did you already get a snapshot of the trained weights or does the computation stop before that point?

Hi,
I think i'm getting the same behaviour. I have an overflow in the function bbox_transform.py. right after the overflow the reg loss  is jumping until it becomes nan. I came up with some fix which seems to work. can you please look and tell whether you get the same behaviour?
if yes, I will propose a PR.
iter 267: image-id:0123208, time:0.817(sec), regular_loss: 0.214897, total-loss 1.0351(0.0118, 0.3499, 0.001303, 0.0411, 0.6309), instances: 1, batch:(20|104, 2|66, 2|2)
[  1 640 853   3]
iter 268: image-id:0477321, time:0.727(sec), regular_loss: 0.215178, total-loss 135.3920(0.5606, 81.0835, 0.000000, 53.7479, 0.0000), instances: 2, batch:(20|96, 0|64, 0|0)
[  1 640 853   3]
/home/amir/Deployment/FastMaskRCNN-fork/train/../libs/boxes/bbox_transform.py:61: RuntimeWarning: overflow encountered in exp
pred_w = np.exp(dw) * widths[:, np.newaxis]
/home/amir/Deployment/FastMaskRCNN-fork/train/../libs/boxes/bbox_transform.py:61: RuntimeWarning: overflow encountered in multiply
pred_w = np.exp(dw) * widths[:, np.newaxis]
/home/amir/Deployment/FastMaskRCNN-fork/train/../libs/boxes/bbox_transform.py:62: RuntimeWarning: overflow encountered in exp
pred_h = np.exp(dh) * heights[:, np.newaxis]
/home/amir/Deployment/FastMaskRCNN-fork/train/../libs/boxes/bbox_transform.py:62: RuntimeWarning: overflow encountered in multiply
pred_h = np.exp(dh) * heights[:, np.newaxis]
iter 269: image-id:0215226, time:0.715(sec), regular_loss: 0.216160, total-loss 183.3571(5.7902, 177.5669, 0.000000, 0.0000, 0.0000), instances: 2, batch:(2|34, 0|64, 0|0)
[   1  640 1137    3]
iter 270: image-id:0477310, time:2.707(sec), regular_loss: 0.224796, total-loss<PHONE_NUMBER>.0000(38611.8828,<PHONE_NUMBER>.0000, 0.000000, 0.0000, 0.0000), instances: 2, batch:(2|34, 0|64, 0|0)
[  1 640 963   3]
iter 271: image-id:0057707, time:0.770(sec), regular_loss:<PHONE_NUMBER>24.000000, total-loss nan(0.0088, 0.4111, nan, nan, 0.6301), instances: 1, batch:(15|84, 1|65, 1|1)
[[<PHONE_NUMBER>4<PHONE_NUMBER>8<PHONE_NUMBER>1<PHONE_NUMBER>9   76.        ]]

I came across the same problem too.

@CharlesShang can you please review/comment?

Problem solved! But how can I make use of the network to test my own imgs and get the rects and masks?

@amirbar Hi, problem solved! But how can I make use of the network to test my own imgs and get the rects and masks?

@mxmxlwlw  please share your solution, how did you modify your code to stop regular-layer from becoming Nan? thanks!

@blitu12345  Hi, they already changed the code in github, just download it, and normally, it will be ok. If you still meet the problem sometimes. Just lower the learning rate. It may works.

@blitu12345 And there may still be some bugs in the training code.

Already using the updated code, initially i got nan values at 1500
iterations but now i m at 3000 and its working fine.Dont know how this
works.By the way thanks mate !!!
On Jun 4, 2017 7:07 AM, "mxmxlwlw"<EMAIL_ADDRESS>wrote:

@blitu12345 https://github.com/blitu12345 And there may still be some
bugs in the training code.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/CharlesShang/FastMaskRCNN/issues/47#issuecomment-306011787,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AOosN28cnYuoA4j6P3qbQDBSoe3L5-xpks5sAgpMgaJpZM4NaoIO
.

@blitu12345  Yeah, they commit with comment "Change computation for numerical stability". However, there may still be some bugs... And I really looking forward they giving some sample code for testing their network. Just one image would be fine.

@mxmxlwlw have you trained the whole model ? i m just at 120k iteration and its already more than 24 hrs, seems like it would take a long time to train.How much time did your model took to train?Are they storing and saving the trained model at successive interval in this code ?Thanks !!

@mxmxlwlw I wrote a short code for bounding box visualization I can PR
There are still bugs. I'm currently testing only the RPN component and it seems to work with few code fixes and hyper params search. I will try to PR today
The repository seems far from reproducing the original work

@blitu12345 I just use the original code for training. And yes, it took long time to train.

@amirbar Wow, thank you for your share! You help me a log.

@mxmxlwlw , according the the experiments I performed, training will not lead you to anything unless you merge #50, which at least fixes the RPN component.
anyway, because this thread issue is resolved can you please close? there are too many issues to track anyway :)

Ok.

Check my comment here


Error when list/query for not created tables

Describe the bug
The creation of tables occur on the first insertion (call to CreateDocument function.
For this reason, code that tries to get records from a table that did not had a created document will return an error.
To Reproduce

Start the CLI $ backend server
Issue a ListDocument request

$ curl -H "SB-PUBLIC-KEY: dev-memory-pk" -X POST -d '{"email"<EMAIL_ADDRESS>"password": "devpw1234"}' http://localhost:8099/login
$ curl -H "SB-PUBLIC-KEY: dev-memory-pk" -H "Authorization: Bearer session-token-you-got-above" http://localhost:8099/db/new-table-here

Error returned:
collection not found

Expected behavior
Might be better to return an empty slice instead of an error. The "standard" web CRUD flow is to create the "listing" page before users go to create entity.
Output of staticbackend -v
StaticBackend version v1.4.0-rc2-13-gb392f7a | 2022-08-23.05:33:15 (b392f7a)
Additional context
This should be the same behavior for all 3 database package: postgresql, mongo, and memory.

To add more context. I think we should detect the error on the database provider side and return the empty slice only for this error, not all error.
For instance, code taken from database/postgresql/base.go line:120:
if err = pg.DB.QueryRow(qry, auth.AccountID, auth.UserID).Scan(&result.Total); err != nil {
  return
}

We'd need to check  for the specific error regarding table / relation does not exists and only in that case return the empty slice without error.
Same for mongo and memory database package.

@dstpierre may I fix this issue?


(PDB-1627) Benchmark tests + improved runinterval tests

Refer to this link for build results (access rights to CI server needed):
http://jenkins-enterprise.delivery.puppetlabs.net/job/enterprise_puppetdb_init-multijob_githubpr-master/51/
Test FAILed.

Refer to this link for build results (access rights to CI server needed):
http://jenkins-enterprise.delivery.puppetlabs.net/job/enterprise_puppetdb_init-multijob_githubpr-master/52/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
http://jenkins-enterprise.delivery.puppetlabs.net/job/enterprise_puppetdb_init-multijob_githubpr-master/54/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
http://jenkins-enterprise.delivery.puppetlabs.net/job/enterprise_puppetdb_init-multijob_githubpr-master/56/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
http://jenkins-enterprise.delivery.puppetlabs.net/job/enterprise_puppetdb_init-multijob_githubpr-master/57/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
http://jenkins-enterprise.delivery.puppetlabs.net/job/enterprise_puppetdb_init-multijob_githubpr-master/61/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
http://jenkins-enterprise.delivery.puppetlabs.net/job/enterprise_puppetdb_init-multijob_githubpr-master/70/
Test PASSed.

taking a look at this now

Refer to this link for build results (access rights to CI server needed):
http://jenkins-enterprise.delivery.puppetlabs.net/job/enterprise_puppetdb_init-multijob_githubpr-master/82/
Test PASSed.

worked through the issues with this with @mullr today. I suspect the tests have some race conditions but he's on top of it -- once that's resolved I'm +1, this is a big improvement.

Refer to this link for build results (access rights to CI server needed):
http://jenkins-enterprise.delivery.puppetlabs.net/job/enterprise_puppetdb_init-multijob_githubpr-master/84/
Test PASSed.

@wkalt fixed up the test

Refer to this link for build results (access rights to CI server needed):
http://jenkins-enterprise.delivery.puppetlabs.net/job/enterprise_puppetdb_init-multijob_githubpr-master/89/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
http://jenkins-enterprise.delivery.puppetlabs.net/job/enterprise_puppetdb_init-multijob_githubpr-master/96/
Test PASSed.


"123".should.not.exist is not failing as expected

I'm using mocha 2.2.4 and should 5.2.0.
Any should.not.exist assertion is always passing no matter what.

OK, so this may be a non-issue / misunderstanding.
should.not.exist("123") works, but "123".should.not.exist does not.
Leaving it open in case the "123".should.not.exist is supposed to be working. I assumed all assertions worked either way and I like the Object extension syntax better so that's what I was using.

There is no .should.exist (and never was). Form of property call really does not make any sense, because in all relevant cases when it will be usefull it will not work:
null.should.not.exist;//not work
undefined.should.not.exists;//not work

// all other cases will work (which has prototype of cause), but does not make any sense if above 2 does not work.

Heh, yeah ok, now that I think of it more I see where my brain was failing me :)


Previous button does not work after users click on "next page".

The issue comes from the Manga chapter view.html page.

Do you think the problem lies with prev_page() in manga.js?

Do you think the problem lies with prev_page() in manga.js?

I think the problem lies on how functions Next_Page() and Prev_Page(). The functions work by getting the first selected option and moves to previous or next option. The problem is, If the original selected option was started at "0", I call Next_Page() and the page picture was changed to "1". But this did not update the page so Prev_Page() function still believes the select option was still at "0". Therefore, when users clicks on "Previous Page" button, it gets an error because it is trying to go to the previous 'page' of a non selected value.
Its hard to explain but imagine like this:

User clicks on Page 3.
Next_Page() and Prev_Page() both thinks the select option started at Page 3.
User clicks Next_Page and the image was changed to Page 4. But the html page did not update to "page 4", it only updated the image.
When users clicks Prev_Page(), it won't work because Prev_Page() is trying to go to Page 2 (It believes the user is viewing Page 3).

minor issue, won't need fix. The button still works, won't cause any performance issue or user usability issue.


client-lvgl segfaults on macos

client-lvgl segfaults on macos after default compile. the binary was compiled from the rvdmfix branch in https://github.com/cyclops1982/voorkant-core/tree/rvdmfix .
The build segfaults as follows:

'bt all' gives:

some more investigation into the trace points to lvgl failing to allocate:

this apparently does not happen with the demo instance - which only has like six lights, not >35

fixed in #53


exe: drop unused deps on zlib compressor code

Description:
//source/exe:envoy_common_lib doesn't really depend on zlib compressor/decompressor directly.
Risk Level: Low
Testing: unit tests and manual testing
Docs Changes: N/A
Release Notes: N/A

/retest


Fantastic Project!

Hi Sandeep,
I'm really impressed by this project and the article you wrote about it. Its exactly what I've been looking for.  I hope to leverage it to update my cat doorbell.  I do have a couple questions, though.

In the "Load wive file data" section, there is a dog barking example loaded.  Is that necessary for the project? I'm not sure why its there, tbh. :)
In the "Download datasets" section, I'm not sure what this construct for github means:
'https://github.com/ArmDeveloperEcosystem/ml-audio-classifier-example-for-pico/archive/refs/heads/fire_alarms.tar.gz',
Did you add the tar file to github, delete it, then refer to it based on the archive?  Never seen this construct before.  Could you explain how that was done?

Thank you, sir.

Hi @gamename,
Thanks for the positive feedback!

In the "Load wive file data" section, there is a dog barking example loaded. Is that necessary for the project? I'm not sure why its there, tbh. :)

It was there to demonstrate how to load a wave file, and is used to train a broader baseline model, along with other data from the ESC-50k dataset.

In the "Download datasets" section, I'm not sure what this construct for github means:
'https://github.com/ArmDeveloperEcosystem/ml-audio-classifier-example-for-pico/archive/refs/heads/fire_alarms.tar.gz',
Did you add the tar file to github, delete it, then refer to it based on the archive? Never seen this construct before. Could you explain how that was done?

The files are in the fire_alarms branch of this repo, that url is a way to download the items of that branch without using git.
You can see the branch here: https://github.com/ArmDeveloperEcosystem/ml-audio-classifier-example-for-pico/tree/fire_alarms

Thank you, sir. I may have more questions as I progress in my project.
Thanks again,
-T


Error scoring on Marques2020_Ringach2002, AssertionError

I am getting this error when I see the scoring process log for the model I submitted. I am wondering if this happens because this benchmark requires some specific model definition?
Traceback (most recent call last):
  File "/scratch2/weka/quest/shared/jenkins/miniconda3/envs/yudixie_resnet50_imagenet1kpret_0_240312_Marques2020_Ringach2002-or_bandwidth/lib/python3.7/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/scratch2/weka/quest/shared/jenkins/miniconda3/envs/yudixie_resnet50_imagenet1kpret_0_240312_Marques2020_Ringach2002-or_bandwidth/lib/python3.7/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "brainscore_vision/__main__.py", line 20, in <module>
    fire.Fire()
  File "/scratch2/weka/quest/shared/jenkins/miniconda3/envs/yudixie_resnet50_imagenet1kpret_0_240312_Marques2020_Ringach2002-or_bandwidth/lib/python3.7/site-packages/fire/core.py", line 143, in Fire
    component_trace = _Fire(component, args, parsed_flag_args, context, name)
  File "/scratch2/weka/quest/shared/jenkins/miniconda3/envs/yudixie_resnet50_imagenet1kpret_0_240312_Marques2020_Ringach2002-or_bandwidth/lib/python3.7/site-packages/fire/core.py", line 482, in _Fire
    target=component.__name__)
  File "/scratch2/weka/quest/shared/jenkins/miniconda3/envs/yudixie_resnet50_imagenet1kpret_0_240312_Marques2020_Ringach2002-or_bandwidth/lib/python3.7/site-packages/fire/core.py", line 693, in _CallAndUpdateTrace
    component = fn(*varargs, **kwargs)
  File "brainscore_vision/__main__.py", line 9, in score
    result = _score_function(model_identifier, benchmark_identifier, conda_active)
  File "/rdma/vast-rdma/scratch/Sun/score_plugins_vision_env_163/vision/brainscore_vision/__init__.py", line 105, in score
    score_function=_run_score, conda_active=conda_active)
  File "/scratch2/weka/quest/shared/jenkins/miniconda3/envs/yudixie_resnet50_imagenet1kpret_0_240312_Marques2020_Ringach2002-or_bandwidth/lib/python3.7/site-packages/brainscore_core/plugin_management/conda_score.py", line 88, in wrap_score
    result = score_function(model_identifier, benchmark_identifier)
  File "/rdma/vast-rdma/scratch/Sun/score_plugins_vision_env_163/vision/brainscore_vision/__init__.py", line 76, in _run_score
    score: Score = benchmark(model)
  File "/rdma/vast-rdma/scratch/Sun/score_plugins_vision_env_163/vision/brainscore_vision/benchmark_helpers/properties_common.py", line 46, in __call__
    pos=stim_pos)
  File "/rdma/vast-rdma/scratch/Sun/score_plugins_vision_env_163/vision/brainscore_vision/benchmark_helpers/properties_common.py", line 100, in filter_receptive_fields
    rf_pos, rf_map = map_receptive_field_locations(model_identifier=model_identifier, model=model, region=region)
  File "/scratch2/weka/quest/shared/jenkins/miniconda3/envs/yudixie_resnet50_imagenet1kpret_0_240312_Marques2020_Ringach2002-or_bandwidth/lib/python3.7/site-packages/result_caching/__init__.py", line 80, in wrapper
    result = function(*args, **kwargs)
  File "/rdma/vast-rdma/scratch/Sun/score_plugins_vision_env_163/vision/brainscore_vision/benchmark_helpers/properties_common.py", line 115, in map_receptive_field_locations
    _assert_grating_activations(rf_activations)
  File "/rdma/vast-rdma/scratch/Sun/score_plugins_vision_env_163/vision/brainscore_vision/benchmark_helpers/properties_common.py", line 232, in _assert_grating_activations
    == nStim
AssertionError

Looking into this now. I'll let you know what I find!

Addressed in #711


After upgrade (pull) to netbird on docker

After my upgrade... and a backup of course..
I can no longer log in using authentic... all my clients connect without issue.. I just can't log in to the dashboard any longer.
It will say "unauthorized"
I see no errors regarding logins in management log.
my "PKCEAuthorizationFlow": shows local url .. same as my older backed up json file.
I did a compare on old versus new.. they are the same... I also have the backup of db files.. I have not tried to restore them as I didn't want to break it further.
Only thing i noticed was an extra file after the upgrade... openid-confiugration.json.. my backup does NOT contain this file..
Latest version is showing.30.2
Any insights would be appreciated.

Same here. Were you able to get the dashboard to log users in again?
It seems like Authentik 2024.10 might have caused some issues, though rolling it back to 2024.8 didn't help in my case.

my issue ended up being Firefox... i did a reset on it and authentik was fine...
i'm running 2024.10.0 without issue


Any documentation on how to train it on our own  data for the new GAN based algorithm?

See the last few paragraphs of this document


Hyas Insight Splunk SOAR Integration

Name of the app
hyasinsight
Integration
Splunk SOAR.
About
This app implements investigative actions that return Hyas Insight lookup for the provided indicator.

Repo created at https://github.com/splunk-soar-connectors/hyasinsight


[Fix Issue #15719] Add a variable for .form-group's margin-bottom

[Fix Issue #15719] Add a variable for .form-group's margin-bottom

I'm good with this.

SemVer requires that this would be for v3.4.0 rather than the next patch release.

Really? For a variable change? If so, let's punt on it, but I know we've added variables for things previously without bumping a minor version.

Guess it's a matter of how strict we wanna be. I'm very much in favor of adding the var over not adding it.


Fix Frank!Doc classic GUI (detect order field)

Hmm, commit from FrankRunnerBuildOtherModules seems to be added to this pull request. I probably did something wrong while creating the pull request. Let me check...

I''ll redo my PR, that's easier than trying to fix it (rebase didn't do the trick) :-)


Bump Node.js version

Hi,
As per official docs it seems that Photoshop currently supports very old Node.js v4.8.4 version (Security support ended in 2018) and evaluating v8.11.1. Is there any time line for this action?
Best regards,
Zhi

I updated the wiki page you referenced, thanks


Width attribute values missing "px" in compiled HTML

When I export my MJML source to HTML, I've noticed that it generates code like this:

      ...

Note the style="width:650;" and style="max-width:650;" – this is incorrect because the px suffix is missing from the values, which causes Outlook to ignore them and display the tables at 100% width instead.
For now, I'm working around this by doing a find/replace in my compiled HTML (width:650; -> width:650px; – that catches both the width and max-width attributes), but this is annoying and MJML clearly seems to be in the wrong here, no?
I'm using version 2.8.0 of the MJML app on macOS, and MJML 4.0.3.

Hi @daGUY could you provide your mjml ? You need to specify the unit manually, in your mjml did you specify the px or just width="650" ?

Ah! You're right, I had <mj-body width="650"> instead of <mj-body width="650px">. I think because the syntax looks like regular HTML, I was thinking it wasn't supposed to have the px suffix. Thanks!