Error : Dialogflow API has not been used in project

Environment details

OS: Linux (Ubuntu)
Node.js version: 9.0.0
npm version: 5.5.1
dialogflow version: 2

Steps to reproduce

Use dialogflow-nodejs-client-v2 without GOOGLE_APPLICATION_CREDENTIALS environement variable
call sessionClient.detectIntent(request)
you will see this kind of error :

Error: Dialogflow API has not been used in project firebase-cli before or it is disabled.
Enable it by visiting https://console.developers.google.com/apis/api/dialogflow.googleapis.com/overview?project=firebase-cli then retry.
If you enabled this API recently, wait a few minutes for the action to propagate to our systems and retry.
    at /home/me/projects/dialogflow-cmd/node_modules/grpc/src/client.js:564:15

Steps to fix

Go to https://console.cloud.google.com/apis/credentials/serviceaccountkey
Download json auth file like foobar-123.json
Add environement variable :

export GOOGLE_APPLICATION_CREDENTIALS="/home/me/secure/foobar-123.json"

Conclusion
IMHO the error is not clear at all. The two help explanations in the error ("Dialogflow API has not been used in project firebase-cli before or it is disabled.") are false and looking for the string "firebase-cli" on my project files was a dead end.
Something like "Environement variable GOOGLE_APPLICATION_CREDENTIALS not detected or empty, it is needed to authenticate throught service, please follow explantions here https://cloud.google.com/docs/authentication/getting-started"
I still dont understand where the "firebase-cli" string come from...
Also, this bug has been reported on these :
https://stackoverflow.com/questions/47941896/failure-calling-dialogflow-api-by-using-npm-programm
https://stackoverflow.com/questions/48145572/connecting-with-dialogflow-v2-api-using-python
https://productforums.google.com/forum/#!topic/dialogflow/akANtXsILKg

I notice all the API call examples have "// optional auth parameters" in their options object, so I believe there is more than one way to get authentication in place. i.e. GOOGLE_APPLICATION_CREDENTIALS in environment isn't the only way so not sure the error should only say that.
But otherwise, yes the message is pretty unclear if it is talking about random project names!

the gcloud tool seems to be an alternative option to set up auth, but it's still a auth related error right ?

Oh yeah - Not denying it's an auth thing. Just questioning whether the error message is the right place to describe a (raft of?) different authenticating mechanisms.
P.S. Are you sure you've never had a project called firebase-cli? Try "firebase logout" and see what changes? "firebase login" and "firebase use" store state in some magical location that has caused me similar drama in the past...

yup this name was pretty curious to me, never created a project called firebase-cli, like if I was mad enough to create a command line tool for something I just discovered few days ago :stuck_out_tongue_closed_eyes:
also I looked everywhere (with a recursive find/grep) in the source files and also in node_modules, I also did a search in my /home directory to find some config files related to google/firebase things, nothing... on my google console where all my projects are listed nothing, also on firebase console...

BTW - I've confirmed in my project just released here: https://www.npmjs.com/package/voice-assistants-cli
That you can also 'point to' that same credential file via the property keyFilename in the options object passed into all API calls. (Without setting env.GOOGLE_APPLICATION_CREDENTIALS)
This is some Google API standard it seems.
With your "firebase-cli" mystery... Have you tried "firebase logout/login" in your shell? I looked EVERYWHERE (like you) for something like this with firebase CLI before and never found it... Binary? Encrypted? Magic storage? who knows... Eventually I had to re-run "firebase use" to fix my mysterious problem.
I wonder if the Devs ever pass by these parts...

The error is coming from the grpc module

node_modules/dialogflow/node_modules/grpc/src/client.js:554:15

This client lib could catch the error, check the code (7), and throw a more suitable error message.
Here's the error dump, in case it's helpful.
{ Error: Dialogflow API has not been used in project firebase-cli before or it is disabled. Enable it by visiting https://console.developers.google.com/apis/api/dialogflow.googleapis.com/overview?project=firebase-cli then retry. If you enabled this API recently, wait a few minutes for the action to propagate to our systems and retry.
    at /Users/username/workspace/project/functions/node_modules/dialogflow/node_modules/grpc/src/client.js:554:15
  code: 7,
  metadata:
   Metadata {
     _internal_repr:
      { 'google.rpc.help-bin': [Object],
        'grpc-status-details-bin': [Object],
        'grpc-server-stats-bin': [Object] } } }

Steps for setting up credentials are described in the doc for setting up the local firebase function emulator. Maybe we can point there?
https://firebase.google.com/docs/functions/local-emulator

Isn't the error message terrible? ;-)
I just got this message and if I did not find this (closed) issue I think I would have been stuck for a while, sending a bug report etc. Thinking that this does not work yet.
BTW, using the URL that is mentioned in the error message just gives another error.
Please provide a better error message.

ERROR: { Error: 7 PERMISSION_DENIED: Cloud Speech-to-Text API has not been used in project nnnnnnn before or it is disabled. Enable it by visiting https://console.developers.google.com/apis/api/speech.googleapis.com/overview?project=nnnnnnnn then retry. If you enabled this API recently, wait a few minutes for the action to propagate to our systems and retry.

Hi, thanks for noting this. I've filed some bugs to help get these 2 issues improved.

Better error message to note when credentials aren't provided
Fix the error link provided to enable the API (if it hasn't been done yet)

Thanks @nnegrey , but would it not be much better to just fix the problem? The emulator should of course get the relevant data from the cloud. It just seems that the data for the used API:s is not yet fetched by the emulator.
A lot of people would be thankful if this was fixed.

I'm afraid, we can't create credentials on your behalf.


GeoJSON to/from LocalDataSource

Adding x0.000 points to LocalDataSource may take many seconds, so bulk adding (and loading) makes sense in such cases. Two methods to LocalVectorDataSource:

[ ]  addGeoJson(String, style) to load GeoJSON data (in WGS84), all objects with given single style. If several styles needed, separate GeoJSON files have to be used
[ ]  getGeoJson() to export GeoJSON data from DataSource, ignore styling.

This is now implemented in develop branch, though with little bit different API. As the SDK already has serialization to/from geojson using 'FeatureCollection' class, this was reused and the implemented methods are renamed to addFeatureCollection and getFeatureCollection.

Part of SDK 4.1.0RC1


Upgrade sarama to support Kafka 2.2.0

Upgrade Shopify/sarama to 1.22.0
to support kafaka 2.2.0
Just like PR: https://github.com/linkedin/Burrow/pull/447

Coverage remained the same at 74.488% when pulling 5ef6943b9de5279ea18a9fe67a3400060b6cc78a on asaf400:kafka-2.2.0 into f7de04fc33e88e9ca3a9e0f2e7f35551209cc0c3 on linkedin:master.

Thanks for your contribution!


Java counting sort

This adds Counting Sort implemented in java.
It returns the sorted array.
Here is the wiki link : https://en.wikipedia.org/wiki/Counting_sort

Comment on d133706867a6f2e808aa19d22c224aabcc297007, file counting_sort/Java/count_sort.java, line 28.
Line contains following spacing inconsistencies:

Trailing whitespaces.

Origin: SpaceConsistencyBear, Section: all.pyjava.
The issue can be fixed by applying the following patch:
--- a/tmp/tmp3fxanglr/counting_sort/Java/count_sort.java
+++ b/tmp/tmp3fxanglr/counting_sort/Java/count_sort.java
@@ -25,7 +25,7 @@
          */
         int maximum_number = getMax(arr);              // get the max number in the array in order to declare count array.
         int[] count_arr = new int[maximum_number + 1]; // maximum_number + 1 as we need to correctly
-                                                      //map each index with the number in the array
+                                                      //map each index with the number in the array

         for (int i = 0; i < count_arr.length; i++) {
             count_arr[i] = 0;

Comment on d133706867a6f2e808aa19d22c224aabcc297007, file counting_sort/Java/count_sort.java, line 40.
Line contains following spacing inconsistencies:

Tabs used instead of spaces.

Origin: SpaceConsistencyBear, Section: all.pyjava.
The issue can be fixed by applying the following patch:
--- a/tmp/tmp3fxanglr/counting_sort/Java/count_sort.java
+++ b/tmp/tmp3fxanglr/counting_sort/Java/count_sort.java
@@ -37,7 +37,7 @@

         for (int i = 1; i < count_arr.length; i++) {
             count_arr[i] += count_arr[i - 1]; // rolling sum to get the count of numbers less than the
-            				      // current index in the original array
+                                  // current index in the original array
         }

         int[] sorted_arr = new int[arr.length]; // declare and initialize the sorted array so elements from

I think the patch suggests I have CountSort.java as the filename. I changed that to count_sort.java to adhere to the repo coding guidelines. Can you provide a new patch please?
@sangamcse

I converted all tabs to spaces. Please let me know in case of any other issues.

Comment on 8f1a8860a92858697b395756cf89a6582b1a5b54, file counting_sort/Java/CountSort.java, line 28.
Line contains following spacing inconsistencies:

Trailing whitespaces.

Origin: SpaceConsistencyBear, Section: all.pyjava.
The issue can be fixed by applying the following patch:
--- a/tmp/tmpc_mpjr4g/counting_sort/Java/CountSort.java
+++ b/tmp/tmpc_mpjr4g/counting_sort/Java/CountSort.java
@@ -25,7 +25,7 @@
          */
         int maximum_number = getMax(arr);              // get the max number in the array in order to declare count array.
         int[] count_arr = new int[maximum_number + 1]; // maximum_number + 1 as we need to correctly
-                                                      //map each index with the number in the array
+                                                      //map each index with the number in the array

         for (int i = 0; i < count_arr.length; i++) {
             count_arr[i] = 0;


Add guide for other config vars

I'm mostly concerning these two that are required

Hey
What guide would you like for these vars (I know this sounds stupid, but I would like your to hear your input in this)

Just how to get them/set them up because they're required and I have no idea what they are for and I don't even know what AMQP is

Oh, okay. I will add that in the next release.
Did you manage to get it set up or do you need help?

I got through the discord bot/app set up and tried to deploy to heroku with the bot token but is still missing those two required values mentioned above

Also I just noticed that you don't need to configure those when you deploy via docker. How come?

Only required variables is TOKEN, this can be set as environment variables using export ENV_NAME=VALUE on linux based OS or $env:VARIABLE_NAME=VALUE on Windows based OS

Oh okay
So for the AMQP:

small intro into what it is why I bot needs it

AMQP is protocol which enables server to instantly queue messages which then can get picked up by client. This is mostly used for CPU intensive tasks where it is used as acknowledgment for client that processing has started or delivery of small client messages such as in instant messaging apps like Instagram or Facebook messenger. This bot uses AMQP as dynamic job queue because if there is large amount of requests being made to image generation models, then messages get blocked so they don't overload server (DDoS/DoS countermeasure)

As for filling this environment varble o  heroku I strongly advise for usage of Cloud  AMQP which is largest AMQP provider and has excellent uptime. You can log into it with github. Once your account is created, you need to create new amqp instance (free plan will completely suffice) by clicking on this button.  Then go to instance you created and copy field URL under section AMQP Details . . This is the value you need to insert into required variable named AMQP_URL

For the MongoDb
Small intro into mongodb:

MongoDb is widely used NoSql database mostly used for large scale programmes. This was necessary once and decided to add :envelope: feature because it is used for storage of generated collages so they can be sent to end user.

For creating your longo instance i would advise you to use Mongo Atlas which is native MongoDb provider. You will need to create cluster (free will suffice), once you fill in all required fields for it you will be given popup with credentials. What is important, is that you copy MongoUri field, thi is what you will use in MONGO_URL variable. I will be honest with you, I am on my phone and I am not sure if this variable just pops up. If it doesn't please copy you login credentials and URL on which cluster is hosted. Resulting URI will be I  format mongodb://{userName}:{password}@{host}:27017

If there are any inaccuracies or problems, come to my Deko discord server and I will help you as much as I can 🤗

Thank you so much for the comprehensive guide. I'll set this up and get back to you if I had any question

Is there a preferred way to configure this? I assume I'd need to get the IP after I started my heroku instance?

No there is not, and please dont setup IP list as heroku rotates IPs once in 24 hours.

So I should not set it up at all is what I'm hearing

I got this error when I built and tried to run on heroku

Maybe it's bc I haven't set this up properly?

Okay ... i see. Dont want to del with this publically. Do you have discord? If so please write to me there

Closing as this was resolved over at discord. Will improve documentation next release :v:


Add iterators

Add iterators for NimBLEScan: NimBLEadvertisedDevice, NimBLEClient: NimBLERemoteService, NimBLERemoteService: NimBLERemoteCharacteristic and NimBLERemoteCharacteristic: NimBLERemoteDescriptor
This is handy e.g. for showing every address of the advertised devices from a scan. To do so, first get a new scan and next:
for(auto pAdvertisedDevice: pBLEScan->getResults()) {
  Serial.printf("Address is %s\n", std::string(pAdvertisedDevice->getAddress()).c_str());
}

Of course any other property of the advertised device can be shown (or looked up, if that is your use case)
Also this is handy e.g. for showing every UUID in a peripheral. To do so, first connect to a peripheral and next:
for(auto pService: *pClient) {
  Serial.printf("Service UUID is %s\n", std::string(pService->getUUID()).c_str());
  for(auto pCharacteristic: *pService) {
    Serial.printf("Characteristic UUID is %s\n", std::string(pCharacteristic->getUUID()).c_str());
    for(auto pDescriptor: *pCharacteristic) {
      Serial.printf("Descriptor UUID is %s\n", std::string(pDescriptor->getUUID()).c_str());
    }
  }
}

Again of course any other property can be shown, or looked up.

Good QOL improvement for the application. Looks good to me.


Double occurrence of the same default analysis rule

The rule "SetGid" with "ResultType": "FILE" occures two times in https://github.com/microsoft/AttackSurfaceAnalyzer/blob/main/analyses.json.
Is this intended?

No. That is not intended.

Ok great, thank you!


Watcher rpc dont listen on dev

:clipboard: Hotfix to issue found on Friday, root cause found by @pthomalla 🙇
Overview
Watcher RPC on DEV env don't listen on its port - refuses connection
Changes
Fixed misconfigured endpoint. Minor cleaning in Watcher configuration.
Testing
curl -X POST localhost:7434/status.get
on locally ran Watcher in DEV environment.

@jrhite This is why it didn't work yesterday ;)


Adding content in about page

Adding the below-mentioned content in the about us page
Content for main about section:
"Most of the time students will be willing to learn new skills like web development, android development, etc but they lack proper guidance and they find it really difficult to start with the tech stack and gradually start lacking interest in it.
Career Path is a website developed by the students as a part of the Uplift Project to tackle this problem. In this website, we provide a  proper path to excel in a particular tech stack so that the students can have a smooth learning journey.
We also have separate sections for interview experiences, recent internship opportunities, and blogs. If a student faces a problem they can always reach out to us in the chat section."
Contributors:

Irshad Ahamed
Hari Sapna Nair
Mahima Goyal
Jyoti Balodhi
Kashika Jain
K Harshavardhan
Ishita Singh
Kanha
Harsh Bardhan Mishra
Himakshi Pandey

Please review whether the content is correct.

Please assign me this issue

I solve this issue and pull request ,thank you

I'm interested @Sapna2001 . Please assign me this.


How can I reset the flexdatalist on a new element?

I have a form in which I have pre-set fields where I have instilled the flexdatalist.
By pressing a button I add other fields in which the flexdatalist is not instantiated, how can I instantiate it for these elements?

jquery working example (by class name)
$("NEWELEMENT").flexdatalist({
minLength:1,
data:"/ajax?action=someaction.'",
searchIn:"name",
valueProperty:"value",
searchByWord: true,
selectionRequired: true,
//noResultsText:"text"
});
$(".flex-init").removeClass("flex-init");


MongoDB embedded documents Introspection does not give any names to fields with invalid names

Bug description
While introspecting MongoDB database with command npx prisma db pull --force --composite-type-depth=1
It generates the types correctly but shows validation error.

How to reproduce
Make the keys name in an embedded document numeric like (1,2,3..) and introspect the database.
Expected behavior
No response
Prisma information
generator client {
  provider        = "prisma-client-js"
  previewFeatures = ["mongoDb"]
}

datasource db {
  provider = "mongodb"
  url      = env("DATABASE_URL")
}

type CampaignsContestPayoutPercentages {
   Int  @map("1")
   Int? @map("10")
   Int? @map("2")
   Int? @map("3")
   Int? @map("4")
   Int? @map("5")
   Int? @map("6")
   Int? @map("7")
   Int? @map("8")
   Int? @map("9")
}

type CampaignsContestPayoutWinnersUserId {
   String  @map("1")
   String? @map("2")
   String? @map("3")
}

model campaigns {
  id                                String                                       @id @default(dbgenerated()) @map("_id") @db.ObjectId
  v                                 Int                                          @map("__v")
  campaignId                        String
  charityId                         String
  charityPayoutPercentage           Int
  contestPayoutPercentages          CampaignsContestPayoutPercentages?
  contestPayoutWinnersUserId        CampaignsContestPayoutWinnersUserId?
  createdAt                         DateTime                                     @db.Date
  description                       String?
  distributionWallet                CampaignsDistributionWallet?
  eventPayoutPercentage             Int?
  eventPayoutReceiverUserId         String?
  fundsAllocation                   CampaignsFundsAllocation?
  fundsAllocationStatus             String?
  fundsTransferToDistributionWallet CampaignsFundsTransferToDistributionWallet[]
  inviteLink                        String
  isDeleted                         Boolean?
  isMultipleEntriesAllowed          Boolean
  isParticipationAllowed            Boolean?
  lastUpdatedAt                     DateTime?                                    @db.Date
  name                              String
  organizerReimbursementAmount      Int?
  organizerReimbursementPercentage  Int?
  organizerUserId                   String
  /// Multiple data types found: Double: 4.9%, Int32: 95.1% out of 327 sampled entries
  participationFees                 Int
  photoURL                          String
  status                            String
  /// Multiple data types found: Double: 1.8%, Int32: 98.2% out of 327 sampled entries
  totalAmountRaised                 Int
  totalDonations                    Int
  type                              String
  updatedAt                         DateTime                                     @db.Date
}

Environment & setup

OS: Mac OS
Database:  MongoDB
Node.js version: v12.9.1

Prisma Version
prisma                  : 3.8.1
@prisma/client          : 3.8.1
Current platform        : darwin
Query Engine (Node-API) : libquery-engine 34df67547cf5598f5a6cd3eb45f14ee70c3fb86f (at<EMAIL_ADDRESS>Migration Engine        : migration-engine-cli 34df67547cf5598f5a6cd3eb45f14ee70c3fb86f (at node_modules/@prisma/engines/migration-engine-darwin)
Introspection Engine    : introspection-core 34df67547cf5598f5a6cd3eb45f14ee70c3fb86f (at node_modules/@prisma/engines/introspection-engine-darwin)
Format Binary           : prisma-fmt 34df67547cf5598f5a6cd3eb45f14ee70c3fb86f (at node_modules/@prisma/engines/prisma-fmt-darwin)
Default Engines Hash    : 34df67547cf5598f5a6cd3eb45f14ee70c3fb86f
Studio                  : 0.452.0
Preview Features        : mongoDb

Internal note: Confirm how we handle this for columns in a table (including potential output by the CLI).

Regarding how the SQL databases introspect fields where we just cannot take the number out and decide on something:
model a {
  id   Int     @id
  // This field was commented out because of an invalid name. Please provide a valid one that matches [a-zA-Z][a-zA-Z0-9_]*
  // 1 String? @map("1")
}

This means the user needs to uncomment that and manually name the field to something that should work with the client, e.g. one. I'll do the same for MongoDB.

off topic here but is there any docs on type?

off topic here but is there any docs on type?

Not yet. It is work in progress and available soon. Introspection parts have been there for a while, but client will not support them yet.
In general it is typed json, used in embedded obects in Mongo first. Possible expansion later to Postgres JSONB etc.


docs: How to use AWS SDK JavaScript with Minio?

https://github.com/minio/minio/issues/2642 - reference issue here.

Can be closed via https://github.com/minio/cookbook/pull/87#pullrequestreview-15944


Background Colour of the button?! Please provide a method for that

@cam123raj
In the new version of the library (1.1.2), you can use this method:
mCycleMenuWidget.setBackground(int backgroundColor)  for this,
you can also set the color through the attributes in xml:
app:cm_background = "@android:color/transparent"


Works on Fire TV, but the mediathek search is not usable

Livestreaming works great, nice app. But the search in the mediathek view can't be used because the onscreen keyboard is not opening.

Which version of Zapp are you using?
I have no access to a fire tv, so I won't be able to fix this issue, but maybe other people might be able to help.

I’m using the newest version everytime.

I’m using the newest version everytime.
Are you sideloading the app or using any app store?

I'm sideloading the apk.

I'll see if I can reproduce this issue on some sort of emulator.

I was able to reproduce this on an Android TV emulator. Fixed with help of this thread: https://stackoverflow.com/questions/12022715/unable-to-show-keyboard-automatically-in-the-searchview

I was able to reproduce this on an Android TV emulator. Fixed with help of this thread: https://stackoverflow.com/questions/12022715/unable-to-show-keyboard-automatically-in-the-searchview

Will try it, thank you very much!


No spaces allowed in any part of JSON read through tickParse!

I was doing some testing related to the problems discovered in issue #35 and found this.
If you try to tickParse some JSON, any JSON, that contains spaces anywhere in it (keys, values, or interstitially), you will get one of these errors:
Most serious: In a value
ticktick.sh: eval: line 424: unexpected EOF while looking for matching `"'
ticktick.sh: eval: line 425: syntax error: unexpected end of file

Interstitially or in a key, like in #35
ticktick.sh: line 424: TICKTICK: command not found

@kristopolous I'm pretty sure that this issue and #35 are related to some eval and quote expansion interaction somewhere.

It is required that spaces be allowed in string values to JSON elements.
We can work around the interstitial case by removing spaces outside quotes while tokenizing.
I'm not sure if the JSON spec allows spaces in keys, but reading in JSON without tickParse (I.E. through the normal double backtick method) replaces the space with a number 32, which is fine.

hah ok it should definitely allow it

see 1d257919f9944ed2882d89f610c0b9b0d6e21fe7 for the tests

ah ok it breaks everything right ... isn't this lovely ... can we do unicode?

heh nope ... I bet kaos's bash array thing would work here.
essentially I'll need to create a notion of "escaping" that avoids collision ... always fun.

I spend one evening creating a transpiler in bash 9 years ago ...

Hahhahhah!
I may take a run at fixing it later this weekend.

I actually already had put in code to handle it apparently ... it should be working ... so this is a bug, not an unimplemented feature.

ok yes, this makes things hard with the given approach, what a pain:

m  = ["a b"]

This space should be preserved.

m = {"a b": "c"}

This one is not.

What about

m["a b"] ?

We need to now have a white-space ignoring look-behind of 2

I suppose I can support this basic syntax ...

alright, super close, just doing some testing

My question is this:
importing with:
something = { "the space": "should go here" }
Already works fine.
Can tickParse be refactored to use whatever mechanism the code scraping method
is using?
I know how tickParse and the chain it calls work, but haven't read enough to
figure out how the ... part does its thing.

nope. it's more complicated. I'm almost done

there, it was simpler than I first thought

Sorry, no.
Try this JSON:
{"string":"strin gy!","int":7,"array":["first","seco nd"]}
ticktick.sh: eval: line 424: unexpected EOF while looking for matching `"'
ticktick.sh: eval: line 425: syntax error: unexpected end of file
And if you try this JSON:
{"string":"stringy!", "int":7, "array":["first","second"]}
ticktick.sh: line 424: TICKTICK: command not found
string='stringy!'
That's actually issue #35 again, but fixing this should fix #35.

I think you might be able to replace that whole function body with something
like this:
__tick_json_sanitize_value() {
sed -r 's/[-\";,=()[]{}.''': ]/'''/g
}
Doing that, with this JSON:
{"string": "string'y!", "int":7, "array":["fir-st","sec;ond"]}
No longer gives the first set of errors above.
It still fails because of #35 though. So I can't actually confirm that this is a
fix for this issue, only that it still appears to work in cases where it worked
before.
Remove the spaces from that, and the change gives:
array_000000000000=fir-st
array_000000000001='sec;ond'
int=7
string='string'''y!'


[Admin] Update Project landing page

Related to PR https://github.com/OfficeDev/office-js-docs-pr/pull/1932.

Docs Build status updates of commit 678bf1b:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docs/index.yml
:warning:Warning
View
Details

docs/project/index.yml
:white_check_mark:Succeeded
View

docs/index.yml

Line 0: [Warning-InvalidFileLink] Invalid file link:(~/outlook/index.md).
Line 0: [Warning-InvalidFileLink] Invalid file link:(~/onenote/index.md).

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 32335de:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/index.yml
:white_check_mark:Succeeded
View

docs/project/index.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 3f8697c:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/index.yml
:white_check_mark:Succeeded
View

docs/project/index.yml
:white_check_mark:Succeeded
View

docs/reference/overview/powerpoint-add-ins-reference-overview.md
:white_check_mark:Succeeded
View

docs/reference/overview/project-add-ins-reference-overview.md
:white_check_mark:Succeeded
View

docs/toc.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Ignore namespace when getting provider from reference

Description of your changes

Though the Provider type is cluster-scoped, we use
corev1.ObjectReference as the field so a user may also include a
namespace. When getting the Provider, we never want to include an
extraneous namespace because it may cause the operation to fail.
Signed-off-by: hasheddan<EMAIL_ADDRESS>Temporary fix that will be further enhanced by https://github.com/crossplane/crossplane-runtime/pull/182
Slack thread: https://crossplane.slack.com/archives/CEG3T90A1/p1593112864471900
Checklist

I have:

[x] Run make reviewable to ensure this PR is ready for review.
[x] Ensured this PR contains a neat, self documenting set of commits.
[x] Updated any relevant documentation, examples, or release notes.
[x] Updated the dependencies in app.yaml to include any new role permissions.

Are you sure including a namespace when getting a cluster scoped resource causes the operation to fail? I thought it would just be ignored.

@negz I thought it would also, but slack thread indicates it does cause it to fail. Verifying manually now

@negz verified by creating Provider and referencing it from Cluster managed resource:
conditions:
  - lastTransitionTime: "2020-06-25T21:32:54Z"
    message: 'connect failed: cannot get provider: Provider.aws.crossplane.io "aws-provider"
      not found'
    reason: Encountered an error during resource reconciliation
    status: "False"
    type: Synced

I then removed namespace and it worked as expected. I wonder if this is a recent change in controller-runtime :thinking:

I'll open symmetrical PR's for other providers once this is merged :+1:

Closing this in favor of longer-term solution in https://github.com/crossplane/crossplane-runtime/pull/182


add project type selection in new command

hi! really interesting project you've got here. in the spirit of hacktoberfest i want to contribute something.
as per #229 i've had a go at adding some flags like cargo's --bin and --lib options. i went with "app" instead of "bin" as i felt it made more sense in the context of python, but this naming is very much up for discussion.
the PR so far is mostly plumbing and the switches don't do too much right now, though i did make it put a dummy script entrypoint into the pyproject.toml file for --app type projects.
the following are some examples of what this change adds.
by default, an "app" type project is created with a script entrypoint:
$ huak new myproject
$ cat myproject/pyproject.toml
...
[project.scripts]
myproject = "myproject:run"
...

you can also specify --app explicitly if you like for the same result:
$ huak new --app myproject
$ cat myproject/pyproject.toml
...
[project.scripts]
myproject = "myproject:run"
...

specifiying --lib instead gets you a library-type project with no script entrypoint:
$ huak new --lib myproject
$ cat myproject/pyproject.toml
[project]
name = "myproject"
version = "0.0.1"
description = ""
dependencies = []
authors = []

[build-system]
requires = ["hatchling"]
build-backend = "hatchling.build"

and finally you cannot ask for both at the same time:
$ huak new --app --lib myproject
Some arguments were conflicting with each other.

please let me know what you think of this implementation so far, and what more would need to be done for it to be accepted!
closes #229

Wow thanks! Yea I think this will be super cool to do. So I love what you're adding here. I should be able to check this out in more detail very soon. Really appreciate the PR.

i wrote a test to make sure that creating an app project puts the right script entrypoint into pyproject.toml, let me know if there's anything else you'd like me to add.

just saw your comments about including a main.py with a main function, that's a lot better than my broken-out-of-the-box dummy entrypoint.

just saw your comments about including a main.py with a main function, that's a lot better than my broken-out-of-the-box dummy entrypoint.

i didn't want to make you include that here since it's kinda increasing the PRs scope. we don't bootstrap the project structure yet, but this PR definitely opens that door nicely.

Thanks for the PR!

my pleasure!


Add has root cert validation check option

This validation check would look for the presence of a root certificate in the chain and note any found.
I should also lookup current best practices and add a reference link both here in the documentation. If best practices indicate that root certificates are allowed, but discouraged, then a WARNING could be issued. If best practices indicate that root certificates are disallowed (entirely), then a CRITICAL state could be flagged.
It may be best to have this validation check set as ignored by default.
See also:

GH-211
GH-359

Perhaps a Got Root validation check name instead? :)

Perhaps a Got Root validation check name instead? :)

No. While memorable, this implies a specific expected state and doesn't fit well with the other neutral check names.
I think just Root will do for now.


sdk/get_quote: add get_quote interface for sdk

This PR depends on https://github.com/intel/confidential-cloud-native-primitives/pull/81.


Create DockerFile

Description

All Submissions:

[x] Have you ensured there aren't other open Pull Requests for the same update or change?
[ ] Have you created a new branch for your changes and PR from that branch and not from your master branch?

New Image Submissions:

[ ] Have you added your image to the Github workflows?
[ ] Have you updated the README list to contain your new image?

Support for Java 19 OpenJ9 image

This is standard openjdk and not hotspot.


return Pending/Denied if StatusCode is 202/403

Fix for issue https://github.com/stellar/bridge-server/issues/109

@bartekn no problemo, signed the CLA. Thanks


Non-standard URI for AzureWebJobsStorage

There is no mention of the AzureWebJobsStorage__blobServiceUri, AzureWebJobsStorage__queueServiceUri, or AzureWebJobsStorage__tableServiceUri app settings anywhere in the docs that I could find. These app settings are required when using managed identity to access function app storage in an environment with custom DNS (or a cloud other than Public).
This page might also be a suitable location. It should be at least motioned as a note somewhere.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 0f821505-196d-9b84-e407-47cc461bfd57
Version Independent ID: 6f50473f-a345-b9d1-2d66-7181ebb7232a
Content: Create a function app without default storage secrets in its definition - Azure Functions
Content Source: articles/azure-functions/functions-identity-based-connections-tutorial.md
Service: azure-functions
GitHub Login: @ggailey777
Microsoft Alias: glenga

@matferrari-msft
Thanks for your feedback! We will investigate and update as appropriate.

@matferrari-msft , This document only talks about AzureWebJobsStorage__accountName app setting which is a modification of AzureWebJobsStorage app setting. Also this feature is still in preview. There are no mentions of AzureWebJobsStorage__blobServiceUri, AzureWebJobsStorage__queueServiceUri, or AzureWebJobsStorage__tableServiceUri, Also I am not aware of these settings.

@MughundhanRaveendran-MSFT There are references to the settings here.
I think at a minimum, https://learn.microsoft.com/EN-us/azure/azure-functions/functions-identity-based-connections-tutorial should have a note about URIs and provide a link to this page.

Ah. Awesome. Thank you!

@matferrari-msft we probably should add these preview identity-specific setting to the App Settings reference. I'll add this to our list. Thanks!


New community site, mostly ready.

Still missing a couple pages, videos, and illustrations, but this is good enough to get something live and reach out to the community for feedback.

Since this is an aggregation of all other reviewed PRs go ahead.

Nice!


languagetool: update to windows desktop version 1.0.10

Update version to 1.0.10

[x] I have read the Contributing Guide.

/verify

/verify

/verify

Apologies for the clutter; I noticed that the Latest.yml file you referenced seemed to be providing a SHA512 hash, and figured it would be best to base on that. I was mistaken, and now everything is working with that fixed. Thank you for looking at this!

/verify


NCCL v2.9.8

pfnCI, test this please.

Jenkins CI test (for commit fa880f494d3e62eef37ee396b39aac83081c0d70, target branch master) failed with status FAILURE.

pfnCI, test this please.

Jenkins CI test (for commit fa880f494d3e62eef37ee396b39aac83081c0d70, target branch master) succeeded!


Review input variable descriptions

Description
Some confusions - not an exhaustive list - may be worth a review with @SirSpidey :

Indicate when an input refers to an existing resource. Prefix the variable name with existing_ if possible. This will help distinguish between resource created by the DA and existing resources that are prereq to run the DA
Indicate where some variables are related - eg: some variables enable to take either the crn, id, or guid.
Avoid some acronyms that are not obvious to most users - eg: PAT.
...

New or affected modules

By submitting this issue, you agree to follow our Code of Conduct

Will prioritise reducing inputs first https://github.com/terraform-ibm-modules/terraform-ibm-devsecops-alm/issues/387

Will be addressing this in an upcoming release, reducing the number of optional properties, grouping related variables and improving descriptions.


XP Changed is not emitted during level up

Similar to #23. In the increase_level() function, the XP bar is not updated when the XP is reset. I believe this can be easily fixed by updating this function as follows:
        current_xp -= get_experience_to_next_level()
	current_level += 1
	xp_changed.emit(current_xp, get_experience_to_next_level())
	leveled_up.emit()

Thank you for mentioning this, and thank you for your patience. Today I finally got the chance for some bug fixing and revisions.
I added that code to part 11 and following, and added the code and a mention of it in the written tutorial.


sd-card-formatter: Fix manifest

[x] I have read the Contributing Guide.

Closes #14568

Seems like they have gone back to the old dl path naming scheme on their server.

@rasa I guess I should've kept #14568 linked, it can be closed.


config_loader: Support ssl when an url is used

We ran into this issue while trying to deploy to heroku, which requires ssl for the connection.
Please let me know if this changeset is sufficient or whether you see a simple way to update the existing tests.

Hey @BlueHotDog any chance you could take a look at this PR? It'd be great to get this merged and published. The diff is fairly straight forward. Let me know if you have any questions!

Looks good, but i'm no longer maintaining the project.
@joaosa can you please take a look and approve?


\Sidepieces\Angle_brackets\3x5 Angle Bracket Flat Right.stl

can you please verify that "\Sidepieces\Angle_brackets\3x5 Angle Bracket Flat Right.stl" is correct, it is as thick as the "\3x5 Angle Bracket Flat Center.stl"  (27.6mm), when I expected it to be the same thickness as the "\3x5 Angle Bracket Flat Left.stl" (13.7mm).  Thank you for your time, and your amazing work on this collection.

I can confirm, "3x5 Angle Bracket Flat Right" looks like a copy of "3x5 Angle Bracket Flat Center". The files are very nearly identical. I think one can just mirror the left one to get a right one, unless I'm missing something...

Thank you, i did mirror Left to get the right one, and it worked great.  Recommend removing the "3x5 Angle Bracket Flat Right.stl" file so someone doesn't inadvertently print a center piece.  Thanks agin.


Method 'IUserDialogs.ActionSheet' not found

Please check all of the platforms you are having the issue on

[ ] iOS
[x] Android
[ ] UWP
[ ] PCL

I'm trying to open an ActionSheet via UserDialogs.Instance.ActionSheet(ActionSheetConfig).

This issue came into being after updating the NuGet packages via NuGet package manager.
Changes in the PCL project references, according to SVN:

Acr.UserDialogs.4.2.1 updated to Acr.UserDialogs.5.2.2 for Acr.UserDialogs and Acr.UserDialogs.Interface

Changes in the Android project references, according to SVN:

Acr.Support.1.1.1 updated to Acr.Support.2.1.0 for Acr.Support.Android
Acr.UserDialogs.4.2.1 updated to Acr.UserDialogs.5.2.2 for Acr.UserDialogs and Acr.UserDialogs.Interface
Acr.UserDialogs.4.2.1 changed to AndHUD.1.2.0 for AndHUD

Exception details from the "Output" window:

System.MissingMethodException: Method 'IUserDialogs.ActionSheet' not found.

Smartphone: HUAWEI Y550-L01, Android 4.4, API 19
App was running fine just before the package update.

Make sure you uninstall the appcompat Nuget package as it is no longer required.  Best bet is to uninstall all Acr.userdialog packages and reinstall

Are you talking about the Xamarin.Android.Support.v7.AppCompat library? Isn't that required by Xamarin.Forms?

No.  Just uninstall all Acr libraries and reinstall.

I now uninstalled Acr.XamForms.UserDialogs, Acr.UserDialogs and Acr.Support (in that order); Acr.UserDialogs.Android.AppCompat was not installed if you referred to that.
I then carefully rebuilt all my projects in their dependency order.
My findings: when I build them and run the app in "Release" mode, it works. When I build the projects and run the app in "Debug" mode, the error occurs.

Delete your bin/obj folders.  This is a typical thing with xamarin.  And with that, I do consider this a case closed as your issue is external to this library


Inline objects & arrays as right part of a boolean expression

This is a common pattern to write default values.

LGTM, fwiw

Yeah, sounds good to me!


Overview of modalities

Related to #1.
In addition to including a summary of the types of samples (diagnosis, disease timing), we should also include information on the types of modalities available in each project. In particular it would be important to display if samples have libraries that include CITE-seq, have associated bulk data, are multiplexed, or have spatial data. Since samples could have multiple modalities (such as bulk data and CITE-seq), I think a table might be the best approach for showing this:

Project ID
Total samples
Bulk
CITE (ADT)
Spatial
Multiplexed

SCPCP000001
23
23
0
0
0

A few things to consider:

Do we want to add columns for single-cell vs. single-nuclei?
Do we want to summarize the total number of samples or libraries? I think samples make more sense since that's what you download on the portal.

For the modalities overview, we are going to present it two ways.

Fig. 1B - Bar plot showing a summary of all libraries broken down by modalities. This plot should have proportion of libraries on the y-axis (ranging from 0 - 100) and then each modality listed on the x-axis (all single-cell/nuclei, bulk, spatial, and CITE). The bars will then be colored based on how many samples are single-cell or single-nuclei. If there are any samples that don't have a matching single-cell/nuclei sample then they will not be included.

Table S1 - This will include a summarized table showing the breakdown of number of samples for each project by type. In addition to the columns shown in https://github.com/AlexsLemonade/scpca-paper-figures/issues/14#issue-2062639488, we will add in a column for diagnosis group and diagnosis. The diagnosis column will contain a semi-colon separated list of all diagnosis found in that project with that diagnosis group.

Closed by #17 and #18


Check token’s status

@dang03
UM endpoint for this..?
Thanks

Hi @jbonnet,
Endpoint info to check if token's status is active:

Method: GET
Endpoint: /api/v1/token-status
Requires Authentication header with the token to be evaluated

Responses:

Valid token: 200, OK
Expired token: 401, Unauthorized

Examples:
GET
url = URI("http://<address>:<port>/api/v1/token-status")
request["authorization"] = 'Bearer eyJhbGciOiJSkxX0NpUUhmTm9nIn0...'

i did send 50 eth and all the verifications where done but still now tokens in my wallet what do i do wrong?????

Great, @dang03
On my list...


typo in the repo-name

I think you meant to make the repo-name:
transcriptome-differential-expression

Currently, it is missing the c in transcriptome:
transriptome-differential-expression

I think a rename should be relatively painless, as GitHub redirects stuff, as far as I'm aware. Also, I guess this is still fairly early on in the development process.

done


Flutter loading wrong package version after build web

I'm declaring cloud_firestore: ^0.13.3 and path_provider: ^1.6.1 but flutter is giving error on
AppData\Roaming\Pub\Cache\hosted\pub.dartlang.org\cloud_firestore-0.13.4+2
and
AppData\Roaming\Pub\Cache\hosted\pub.dartlang.org\path_provider-1.6.5
Tried flutter clean, deleting .gradle, deleting %appdata%pub folder, deleting .dart_tool, delete flutter folder and git clone to stable channel...
flutter doctor
Doctor summary (to see all details, run flutter doctor -v):
[√] Flutter (Channel stable, v1.12.13+hotfix.8, on Microsoft Windows [versÃ£o 10.0.18363.720], locale pt-BR)

[√] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
[√] Android Studio (version 3.6)
[√] VS Code (version 1.43.0)
[√] Connected device (1 available)

• No issues found!

Nevermind... for some reason it was build and I could launch it


feat(snapshot): add seqence number to sst rows

this is one of a series of PRs to add snapshot support into slatedb.
this PR makes a change on the sst row format to encode the sequence number inside it. this PR is considered as a BREAKING CHANGE. if it's needed, i can also make a versioned decoding logic to keep this envolve backward compatibile.
all the sequence numbers are still zero in this PR, the generation & maintaince of sequence number is planned to be seperated in another PR.
the change could be illustrated as:
-///  |--------------------------------------------------------------------------|
-///  |       u16      |      u16       |  var        | var  |    u32    |  var  |
-///  |----------------|----------------|-------------|------|-----------|-------|
-///  | key_prefix_len | key_suffix_len |  key_suffix | meta | value_len | value |
-///  |--------------------------------------------------------------------------|
-///  |-------------------------------------------------------------------------------------------------------------|
+///  |       u16      |      u16       |  var        | u64     | 1 byte    | u16       | var   |    u32    |  var  |
+///  |----------------|----------------|-------------|---------|-----------|-----------|-------|-----------|-------|
+///  | key_prefix_len | key_suffix_len |  key_suffix | seq     | flags     | extra_len | extra | value_len | value |
+///  |-------------------------------------------------------------------------------------------------------------|

we had a flexible meta field to store the metadata of the rows such as tombstone, timestamp, expiration, etc. however, it might have benefits to put seq a higher position:

seq is in fact a part of key, concatenating key and seq allows us storing multiple versions of a key in the LSM, and key + seq makes a unique identifier of a row.
in the iterator with sequence number, we need to construct a prefix scan with key + seq to find the row we want, it's a must for us to store them adjacently.

in leveldb, there's a concept called "InternalKey" which concatenates UserKey (which is the key user orignally inputed), seq, flags (which is a tombstone marker) together. this refactor upgrades the seq and flags upwards, and move the optional part to a flat buffer encoded SstRowExtra struct, which contains two optional fields create_ts and expire_ts.
i dunno whether it's too heavy weight to having flat buffer here or not. another choice might be having a RowFlags::WithExpireTs and RowFlags::WithCreateTs in flags, and reading these two i64 optionally. having flat buffer may help it easier to extend in the future, but with my limitted knowlege on rocksdb / badger, there're few chances to further extend these extra metadata besides the key TTL's requirement. any suggestion would be appreciated on this.
this PR also made a refactor about renaming KeyValueDeletable into RowEntry, it expands the fields key, value, seq, flags, create_ts, expire_ts into a flat struct. all these fields are frequently accessed, a flat struct may make these fields easier to access. also, we can directly pass RowEntrys between SsTableBuilder, BlockBuilder and even MemTable instead of (key, value, attrs) after this refactor, this may make it easier to keep these value consistent across several function calls.

I haven't yet reviewed the PR (it's on my TODO list) but for some of the discussion points:

however, it might have benefits to put seq a higher position:

+1, this makes sense to me as I don't think we want to make it optional to have the sequence number -- it seems pretty fundamental to the design of transactions

another choice might be having a RowFlags::WithExpireTs and RowFlags::WithCreateTs in flags

I don't think this is necessary because this would be encoded in the SST-level "row features" (see RFC-3). Generally either every row in the SST or no rows in the SST would have expire_ts/create_ts.
Row "flags" are for things like tombstones, that must be stored per-row.

another choice might be having a RowFlags::WithExpireTs and RowFlags::WithCreateTs in flags

I don't think this is necessary because this would be encoded in the SST-level "row features" (see RFC-3). Generally either every row in the SST or no rows in the SST would have expire_ts/create_ts.

thank you for explanation, i found it might be more intuitive for me to use per-row optional encoding than SST-level features because:

these timestamps are per-row attributes, different rows within same SST may have different lifecycle requirements, it might be more intuitive to manage these lifetimes at the row level.
having them as row-level optional (using row flags or flatbuffer) may simplifies encoding/decoding logic without needing to maintain SST-level state on both read and write, all we need is store these optional fields as it is from the user input.

@agavra wdyt?

@flaneur2020 the motivation for having it be SST level is to decrease the overhead of deserialization since there's fewer conditionals - in retrospect we can argue (with a high degree of validity) that it's a premature optimization. I'm happy either way, may be worth getting @criccomini @rodesai to chime in and see what they think.

(synced from discord)
it seems that badger (the only LSM engine which supports key level TTL?) simply always encoded a 64 bit expire_ts and no create_ts in the row encoding 🤔, https://github.com/dgraph-io/badger/blob/7f657f862cbde20503d33a546cdfc928e8d833cd/structs.go#L79, i feel having only expire_ts and no create_ts may help us less worry about the storage efficiency issue and fewer condition branches?
so the encoding might be the following with no optional field as well:
+///  |       u16      |      u16       |  var        | u64     | u8        | u64        ｜ u32       | var    |
+///  | key_prefix_len | key_suffix_len |  key_suffix | seq     | flags     | expire_ts  ｜ value_len | value |

on the "as of time x" feature, there might have other way to implement this like we can figure out a mapping between seqnum and the timestamp in sst (could not become very accure at millisecond level though).

@agavra @rodesai @vigneshc made some changes as comments suggested 🫡, PTAL

resolved merge conflict, i think this pr is ready to merge now 😁


Mapbox: add map help and shortcuts for mapbox

Help and shortcuts from Mapbox should be accessible (how to move, drag and rotate the map, and other shortcuts)

It won't be relevant when we switch to deck.gl


Propel can't get the table name if the column is like "COUNT(DISTINCT t.c)"

Propel can't get the table name if the column is like "COUNT(DISTINCT books.price)"
in line 441, $tableName will be always equals to null and the test (space exists) must be do in the column name
in line 443, we must get the column name (and not table name which be equals to null) and get the string from the space to the dot (and not to the end of string)

There is a problem with your issue:

There was 1 failure:

1) ModelCriteriaTest::testFindPksSimpleKey
Failed asserting that 'findPks() returns a PropelCollection' matches expected true.

/Users/william/projects/Propel/Propel/test/testsuite/runtime/query/ModelCriteriaTest.php:1593

I've been working this issue in parallel in #217.
The expression that gave me trouble was like IF(a, t1.b, t2.c)
The original code gives 'a, t1.b, t2' as the table name - clearly wrong.
Your fix gives 't1.b, t2' - better, but still not right.

I'm closing this PR as #217 should fix it.


Orthographic projection?

Any suggestion for using this to cull a view using orthographic projection (directional shadow for example)?  Ortho projection isn't compatible with z = 1/w transform used by library (w is always 1 for ortho).  Is there any trick to make this work?

Hi Ingramb,
Unfortunately there's no support for orthographic projection at the moment, but it sounds like it might be a useful feature. Could you tell us a bit more about the use case, will you be doing culling only using the library? The z-buffer generated by the library is approximate, so it may not be directly useful for shadowmapping.
I think you can work around this by doing your own transformations. Instead of submitting a matrix to RenderTriangles(), use the TransformVertices() utility function to transform your vertices to clip space. Once in clip space you can multiply the x/y components of each vertex by its w component. That should cancel out the projection, but keep the depth values intact, so the depth test still works.
Regards,
Jon

Yeah, that was poor wording on my part. I meant multiplying the xyw components by the z-value just as you suggested (or copy the z-value to the w channel unless you are certain w = 1). I think it should work as far as the projection goes (i.e. the triangles should cover the expected pixels on screen), but it does change depth interpolation. If you instead multiply the xyw components by 1/z that might solve any interpolation issues you have. The library internally interpolates 1/w linearly, so if you multiply w by 1/z it would interpolate 1/(1/z) = z, which would be expected for orthographic projection I believe.
It would probably be best to comply with GL/DX conventions, and use w for projection and z for depth interpolation. I don't think it would affect the rasterizer part of the library significantly. Main caveat is that it requires fetching 4 values per vertex (at least when specifying vertices in clip-space), or some extra transform operations. This is usually fine, but vertex processing can be a pretty significant portion of the execution time for highly tessellated meshes.

I've played around with this a bit more, and multiplying by (1/z) as you suggest seems to do the trick.  A dedicated orthographic mode could potentially fetch Z directly and skip fetching W, as well as skip dividing XY by W, so that could be just as efficient.  I'm not sure if that's really necessary though, as this trick seems to work fine, without any real overhead.
I'll let you know if I find any problems with this, but for now I think this may work.  Thanks for your help.

Awesome, glad you got it working. I might look into adding real ortho projection support at some point. Unfortunately I'm not working in this project anymore. I'd have to do it on my spare time, so that makes me a bit hesitant to promise anything :).

Hi Ingramb,
Feel free to drop me an email at<EMAIL_ADDRESS>we can discuss the best way to move forward with this and if it make sense to add this as an official part of the lib.
Regards,
Leigh

It appears I'm running into the same issue as originally mentioned by @ingramb. I want to use the library for occlusion culling shadow rendering which is using an orthographic projection.
Using the trick described by @Hasselgren - multiplying the x, y and w components with 1/z - works fine for regular cases, but is giving me weird results when triangles clip the near plane. I'm not sure why this happens, but it looks like the triangles 'flip'. My guess is that that this occurs because my w becomes negative, and we do the clipping 'before' we apply the perspective correction on x and y? I've attached a screenshot of how it looks using the ComputePixelDepthBuffer debug info, before and after the triangle clips the near plane. (Mesh is just a test quad consisting of 2 triangles).

I've quickly tried adapting the source by adding a template parameter BinTriangles<ORTHO>, which calls a custom ProjectVertices<ORTHO> that does more or less what @ingramb suggested: skipping the XY division by W. (I'm already passing in per-transformed vertices with w == viewspace z, so no need to fetch Z instead of W). The result looks correct in that case.

So now to the actual questions I have:

Am I misunderstanding something, or does the 1/z trick not work for orthographic clipping?
Is there still any plan or possibility to get orthographic projections as an official feature, or would there be interest in me creating a very basic pull request with what I have?)

Note that a solution for this problem can be found in the orthographic branch:
https://github.com/GameTechDev/MaskedOcclusionCulling/tree/Ortho

Hi @plekakis!
If I recall correctly I did manage to get this working. I'm not sure if I had to do anything special - it's been a year after all. Make sure to call the SetOrtho function. I would assume TestRect behaves the exact same indeed.
Could you elaborate about the issues you're seeing?

Hey Mikilas,
Thanks for replying :-)
I see a lot of false occlusion as I move the camera, seems that the shadow casters flicker on and off.
I wonder if you had the same issue, it seems very unstable.
Rendering a test quad at z=0.01 blocks them all correctly without any flickering. I’m not sure what could be going wrong really.
Best regards

On 27 May 2021, at 16:29, Mikilas @.***> wrote:

Hi @plekakis!
If I recall correctly I did manage to get this working. I'm not sure if I had to do anything special - it's been a year after all. Make sure to call the SetOrtho function. I would assume TestRect behaves the exact same indeed.
Could you elaborate about the issues you're seeing?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.


Fix typos

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: GauthamBanasandra sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


context_test won't compile on Archer2

fixes #17
updates to the specific (non-shared) Makefile for the context_test example added in #14

Can you remove the second underscore for variables NETCDF_LIB_DIR and NETCDF_INC_DIR, in the comments section of the Makefile. Thanks.

Can you remove the second underscore for variables NETCDF_LIB_DIR and NETCDF_INC_DIR, in the comments section of the Makefile. Thanks.

of course, done as requested


Added simple Drawing App project. Fixes #636

Added simple drawing app project on the website.
demo video is attached below.
https://github.com/user-attachments/assets/1970337a-ad5e-4273-9f15-e1511602561c

hey @iamrahulmahato,
i have added the project on the website.
can you check this pr?

Fixes #636

hey @iamrahulmahato, i have resolved the conflict.
can you please check it?


Update Issue - 65728261

default description
URL tested: http://ci.bsstag.com/welcome
Open URL on Browserstack

Property
Value

Browser
Chrome 38.0

Operating System
Windows XP

Resolution
1024x612

Screenshot Attached
Screenshot URL

Click here to reproduce the issue on Browserstack

Updated Screenshot Attached


How to get more Voice Type List?

First I thank you for this wonderful application.
I want to ask you about how to get voice list type for languages other than Japanese?
Thank you very much!

Thank you for using!
I am using only the Japanese version, so I don't know how the international version works, but I requested each voice and checked its communication (websocket) to get the voice ID.
However, there were some hidden IDs that could not be checked that way, so I went and typed the IDs in sequential numbers and did my best to find them.
If you do the same, you should be able to get the English version of speaker!
Good luck!


Fix Object::notification order

resolve #52325
resolve godotengine/godot-proposals#5585
CPP-bindings: godotengine/godot-cpp#1151

Previously the p_reversed parameter didn't influence the order in a correct way.
Also script overridden _notification functions were not called in the correct order.
To fix this, some notification functions had to add a p_reversed parameter. This made it necessary to adjust mono and cpp bindings, since they use these functions.
MRP for testing: ReverseNotification.zip (based on notes in #52325)

[X] Investigate necessary changes for GDExtension (MRP: ReverseNotificationCPP.zip)
[X] Investigate necessary changes for mono (MRP: ReverseNotificationMono.zip)
[X] Ensure compatibility (see comment)
[ ] Revert debugging print_line additions

IMO we should consider writing tests for this as well (either in this PR or in a follow up).

This PR is failing the CI checks, those need to be resolved.

@dsnopek Thank you for the detailed review. I believe, that I have addressed all your comments.
From other deprecation-uses, I'm aware of
#ifdef DISABLE_DEPRECATED
#endif // DISABLE_DEPRECATED

Should they be used here as well?

Thank you for the detailed review. I believe, that I have addressed all your comments.

Thanks, the changes look great!

From other deprecation-uses, I'm aware of
#ifdef DISABLE_DEPRECATED
#endif // DISABLE_DEPRECATED

Should they be used here as well?

Hm. I'm not exactly sure how we'd use that in this context.
gdextension_interface.h isn't a "normal" part of Godot's source code, it's meant to be used by other projects for interfacing with Godot, and may not even be parsed by a C/C++ compiler (as is the case for the godot-rust bindings for example), making it almost more like data than code. So, in the past we've made a point of using only the absolute minimum of preprocessor directives in gdextension_interface.h.
But maybe we could exclude the implementation of the old function in gdextension.cpp if DISABLE_DEPRECATED is defined? I think that's likely to break binary compatibility for plenty of GDExtensions, though.

Thanks for the explanation, which lets me think, that DISABLE_DEPRECATED shouldn't be used here.

Looks pretty good! Save for the comments I added and the GDExtension pending changes.

I was confused as the deprecated function names are unnumbered and the names that need to stay are numbered.
So created an overview.

What I would suggest is to name and structure this PR is similar to https://github.com/godotengine/godot/pull/76577/files
Whereas much as possible the deprecated code is stuffed in .compat.inc.
The final code implements a standard naming convention without numbers.
And all checks and references that still need to be in the other files are wrapped in #ifndef DISABLE_DEPRECATED
Resulting in the following overview.

Where I am struggling with is the double implementation of GDExtensionClassNotification in Object::ObjectGDExtension and GDExtensionScriptInstanceNotification in  GDExtensionScriptInstanceInfo
I do not have any idea what the expectations are if using ifdef in a struct.
Maybe renaming these to ‘…_depreciated’ is a solution?

What I would suggest is to name and structure this PR is similar to https://github.com/godotengine/godot/pull/76577/files
Whereas much as possible the deprecated code is stuffed in .compat.inc.

While this is how it's done for compatibility methods registered in ClassDB, I don't know that this can be applied to changes in the GDExtension interface (ie. gdextension_interface.h).
Like I mentioned above, we don't want to put any more preprocessor macros into gdextension_interface.h, beyond the bare minimum, since it may not be processed by a C/C++ compiler, but instead some tool to generate C binding code for another language.
We could conceivably remove the implementations of the deprecated functions when DISABLE_DEPRECATED is defined, but this would break binary compatibility for GDExtensions (possibly in a way that leads to crashes or unexpected behavior) which I'm not sure is something we want to do even when DISABLE_DEPRECATED is defined? Maybe someone who knows more about the goal of DISABLE_DEPRECATED could speak to that?

We could conceivably remove the implementations of the deprecated functions when DISABLE_DEPRECATED is defined, but this would break binary compatibility for GDExtensions (possibly in a way that leads to crashes or unexpected behavior) which I'm not sure is something we want to do even when DISABLE_DEPRECATED is defined? Maybe someone who knows more about the goal of DISABLE_DEPRECATED could speak to that?

DISABLE_DEPRECATED is meant for people who'd want to remove all compatibility code to only get and use the latest APIs, thus (marginally) reducing the size of the engine. And it doubles as a nice way to find compatibility code in the codebase for eventual cleanup when we change major version and can remove compat code.
So breaking binary compatibility would be the expectation here (all ClassDB compat methods have been registered with #ifndef DISABLE_DEPRECATED).
Now, that doesn't necessarily mean it's good for gdextension_interface.h specifically, which has other constraints and can use different rules.

the same thing should be done for script_instance_create

That is done in https://github.com/godotengine/godot/compare/c3dfa8fa76c309adbd207635fb9eedd075dcce49..60d88571d73ce334580f5ed1176e37f7a063b1cf
My understanding is, that the function script_instance_create can't be removed, because it is declared in gdextension_interface.h and that file should not have any #ifndef.
That is why I replaced its function-content by a minimal implementation when DISABLE_DEPRECATED is defined.

My understanding is, that the function script_instance_create can't be removed, because it is declared in gdextension_interface.h and that file should not have any #ifndef.

Right, we can't put any #ifndef in gdextension_interface.h, but it should be OK to completely #ifndef away the implementation from gdextension_interface.cpp (the .cpp file), because the header only declares function pointers, not the actual functions.

Also I have verified that the line can't be removed, because it causes a compiler-error (function script_instance_create is unused):

I think if you wrap the whole gdextension_script_instance_create() function (not just the function body) in #ifndef DISABLE_DEPRECATED, then removing this should work.
And having the function fail to load (because it's not registered) is a better way to break compatibility than having the function turn into a no-op, which could lead to crashes or weird behavior (as opposed to the GDExtension just failing to load).

I think if you wrap the whole gdextension_script_instance_create() function (not just the function body) in #ifndef DISABLE_DEPRECATED, then removing this should work.

Yes, that did the trick. Thank you for the explanation.

Discussed at the GDExtension meeting, and the consensus among those present was that we should prioritize the cleanliness of the interface, and remove the deprecated fields from the new structs. We also talked about the naming scheme of adding an integer to the new function pointer typedefs and structs, and for the most part we think this is fine, or at least we can't think of a better way that maintains source compatibility.

Yes, that did the trick. Thank you for the explanation.

Thanks, the change looks good!

Discussed at the GDExtension meeting, and the consensus among those present was that we should prioritize the cleanliness of the interface, and remove the deprecated fields from the new structs.

To follow-up on the decision from last night's GDExtension meeting, these are the concrete steps (copied from an earlier post) to implement this:

Make a new struct based on GDExtensionScriptInstanceInfo but only for internal use by ScriptInstanceExtension, which has both notification fields. Godot would copy the data from GDExtensionScriptInstanceInfo or GDExtensionScriptInstanceInfo2 for use internally.
We don't need to do the same thing for GDExtensionClassCreationInfo because we already have ObjectGDExtension for use internally
GDExtensionScriptInstanceInfo and GDExtensionScriptInstanceInfo2 as well as GDExtensionClassCreationInfo and GDExtensionClassCreationInfo2 would each only have one notification_func - the old one on the old structs, and the new one on the new structs.
Refactor or duplicate the code in _register_extension_class()/_register_extension_class2() and gdextension_script_instance_create()/gdextension_script_instance_create2(), to accept the interface structs and copy the data on to the internal structs (rather than just having the older function construct the newer struct and pass it to that function)

@Sauermann Sorry for all the back and forth on this! This is the first time we've modified a struct in gdextension_interface.h and so there's some amount of figuring things out as we go. When future contributors need to do the same thing, they'll have the model setup in this PR to follow, but as the PR that's setting the model, this has unfortunately meant work (and re-work) for you. Thanks for all your efforts on this! :-)

Sorry for all the back and forth on this

No need to worry about that. If I had wanted to abandon this PR, I would have already done so. But yeah, originally I thought, this would be a small fix :-D Thanks for taking the time to provide guidance. It is better to work out the issues as early as possible.

Make a new struct based on GDExtensionScriptInstanceInfo but only for internal use by ScriptInstanceExtension, which has both notification fields. Godot would copy the data from GDExtensionScriptInstanceInfo or GDExtensionScriptInstanceInfo2 for use internally.

I did deviate from this suggestion in my implementation in order to reduce code duplication.
The rest of the implementation is now also done.

Thanks for the comments, I have made the necessary renames.

Debug code is now removed.
@Bromeon Thanks for your idea of reducing code-redundancy in https://github.com/godotengine/godot/pull/78634#discussion_r1297714654!

Thanks!

Hi running in to

So want to ask some questions.
Currently, I am using a  GDExtensionScriptInstanceInfo2 without binding any methods

It tries to access a notification function when a .lr script gets attached. Only I have not defined a function jet so it should skip it. Not?

code here
void *godot::LinkerScript::_instance_create(Object *for_object) const {
    Ref<LinkerScript> top = Ref<LinkerScript>(this);
    while (top->base.is_valid()) {
        top = top->base;
        ERR_PRINT("LinkerScript::_instance_create() " + String(top->_save_path));
    }

    return create_instance(nullptr, 0, for_object, Object::cast_to<RefCounted>(for_object) != nullptr);
}

GDExtensionScriptInstancePtr godot::LinkerScript::create_instance(const Variant **p_args, int p_argcount, Object *p_owner, bool p_is_ref_counted) const {

    /* STEP 1, CREATE */
    LinkerInstance *instance = memnew(LinkerInstance);
    instance->_base_ref_counted = p_is_ref_counted;
    instance->_script = Ref<Script>(this);
    instance->_owner = p_owner;
    instance->_owner_id = p_owner->get_instance_id();

    /* STEP 2, INITIALIZE AND CONSTRUCT */
    instance->initialize();

    return internal::gdextension_interface_script_instance_create2 (
        &LinkerInstanceGlue::INSTANCE_INFO,
        instance
    );
}

@Gallilus:
How is LinkerInstanceGlue::INSTANCE_INFO initialized? All I could find in the code was the declaration here (where it's not initialized to any value) and this (which has all the assignments commented out).
In C++, memory isn't initialized to zero by default. So, if you aren't setting anything, LinkerInstanceGlue::INSTANCE_INFO.notification_func isn't nullptr, it's just some random value that happened to be in memory. :-)

Found the problem, I think.
I now initialised all INSTANCE_INFO functions to nullptr.
This did not help to prevent crashes on deprecated_native_info.notification_func so set that to nullptr and it seems to work.


[FLINK-22897][Connectors/Hive] fix the issue that sink to hive with different parallelism will due to produce many small files

What is the purpose of the change
*To fix the issue that sink to hive with different parallelism will due to produce many small files *
Brief change log

set DynamicGrouped = true only when dynamicGrouping and the sink's parallelism is equal to the parallelism of upstream

Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency):  no
The public API, i.e., is any changed class annotated with @Public(Evolving):  no
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? no

@flinkbot run azure


Flutter Web: TextFormField shows a different behavior on Microsoft Edge.

This is my first time opening an issue on github. If there is something I need to edit, tell me.
I was building a Flutter Web Application with a login form. In this form there is a TextFormField for the password value. In this field, I've implemented a simple show/hide password mechanism, but when I open it on Microsoft Edge(debug), there is another iconButton that was never coded.
From what I've tested, it only appears if obscureText == true, if the field is on focus and if the field has any value.
Post I made on StackOverflow:
https://stackoverflow.com/questions/68812458/flutter-web-textformfield-shows-another-suffixicon-on-microsoft-edge?noredirect=1#comment121612575_68812458
Steps to Reproduce

Create a Flutter project
Use this sample app:

minimal code sample
import 'package:flutter/material.dart';

InputDecoration loginFormFieldDecoration = InputDecoration(
  constraints: const BoxConstraints(maxWidth: 400, maxHeight: 70),
  border: OutlineInputBorder(
      borderSide: BorderSide(color: Colors.grey[300]!, width: 1.0), borderRadius: BorderRadius.circular(12)),
  focusedBorder: OutlineInputBorder(
      borderSide: BorderSide(color: Colors.grey[300]!, width: 1.0), borderRadius: BorderRadius.circular(12)),
);

void main() {
  runApp(const MaterialApp(
    home: Home(),
  ));
}

class Home extends StatefulWidget {
  const Home({Key? key}) : super(key: key);

  @override
  State<Home> createState() => _HomeState();
}

class _HomeState extends State<Home> {
  bool isObscured = true;

  final _password = TextEditingController();

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      body: Center(
          child: TextFormField(
        controller: _password,
        keyboardType: TextInputType.visiblePassword,
        obscureText: isObscured,
        decoration: loginFormFieldDecoration.copyWith(
            prefixIcon: const Icon(
              Icons.lock,
              color: Colors.grey,
            ),
            suffixIcon: IconButton(
                splashRadius: 0.1,
                onPressed: () {
                  setState(() {
                    isObscured = !isObscured;
                  });
                },
                icon: Icon(
                  isObscured ? Icons.visibility_off : Icons.visibility,
                  color: isObscured ? Colors.grey : Colors.blueAccent,
                )),
            hintText: "Type your password"),
      )),
    );
  }
}

Run it on Chrome(web):
It will run just fine, as it would on Android emulator.

Run it on Microsoft Edge:
You will notice that when you type something on the TextFormField, an unwanted interactable visibility icon will appear.

Expected results:

Actual results:

Logs

flutter run --verbose
[  +71 ms] executing: [C:\flutter/] git -c log.showSignature=false log -n 1 --pretty=format:%H
[ +520 ms] Exit code 0 from: git -c log.showSignature=false log -n 1 --pretty=format:%H
[   +1 ms] 5cda761161de53f0a7b1d4b039b5fbb41366d3c7
[   +1 ms] executing: [C:\flutter/] git tag --points-at 5cda761161de53f0a7b1d4b039b5fbb41366d3c7
[  +82 ms] Exit code 0 from: git tag --points-at 5cda761161de53f0a7b1d4b039b5fbb41366d3c7
[   +1 ms] executing: [C:\flutter/] git describe --match *.*.* --long --tags 5cda761161de53f0a7b1d4b039b5fbb41366d3c7
[ +111 ms] Exit code 0 from: git describe --match *.*.* --long --tags 5cda761161de53f0a7b1d4b039b5fbb41366d3c7
[   +1 ms] 2.4.0-0.0.pre-82-g5cda761161
[   +7 ms] executing: [C:\flutter/] git rev-parse --abbrev-ref --symbolic @{u}
[  +51 ms] Exit code 0 from: git rev-parse --abbrev-ref --symbolic @{u}
[        ] origin/master
[        ] executing: [C:\flutter/] git ls-remote --get-url origin
[  +44 ms] Exit code 0 from: git ls-remote --get-url origin
[        ] https://github.com/flutter/flutter.git
[ +133 ms] executing: [C:\flutter/] git rev-parse --abbrev-ref HEAD
[  +47 ms] Exit code 0 from: git rev-parse --abbrev-ref HEAD
[        ] master
[  +79 ms] Artifact Instance of 'AndroidGenSnapshotArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'AndroidInternalBuildArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'IOSEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterWebSdk' is not required, skipping update.
[   +6 ms] Artifact Instance of 'WindowsEngineArtifacts' is not required, skipping update.
[   +1 ms] Artifact Instance of 'WindowsUwpEngineArtifacts' is not required, skipping update.
[   +1 ms] Artifact Instance of 'MacOSEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'LinuxEngineArtifacts' is not required, skipping update.
[   +1 ms] Artifact Instance of 'LinuxFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'MacOSFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterRunnerSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterRunnerDebugSymbols' is not required, skipping update.
[  +73 ms] executing: C:\Users\Alan\AppData\Local\Android\sdk\platform-tools\adb.exe devices -l
[  +53 ms] List of devices attached
[   +7 ms] Artifact Instance of 'AndroidGenSnapshotArtifacts' is not required, skipping update.
[   +1 ms] Artifact Instance of 'AndroidInternalBuildArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'IOSEngineArtifacts' is not required, skipping update.
[   +6 ms] Artifact Instance of 'WindowsUwpEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'MacOSEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'LinuxEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'LinuxFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'MacOSFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterRunnerSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterRunnerDebugSymbols' is not required, skipping update.
[  +83 ms] Multiple devices found:
[  +29 ms] Windows (desktop) • windows • windows-x64    • Microsoft Windows [versÃ£o 10.0.19042.1165]
[   +2 ms] Chrome (web)      • chrome  • web-javascript • Google Chrome 92.0.4515.159
[   +1 ms] Edge (web)        • edge    • web-javascript • Microsoft Edge 92.0.902.73
[   +3 ms] [1]: Windows (windows)
[        ] [2]: Chrome (chrome)
[        ] [3]: Edge (edge)
[   +3 ms] Please choose one (To quit, press "q/Q")
[   +1 ms] :
[+10830 ms] 3
[  +32 ms] Skipping pub get: version match.
[ +132 ms] Generating C:\Users\Alan\Desktop\teste issue\teste_issue\android\app\src\main\java\io\flutter\plugins\GeneratedPluginRegistrant.java
[ +107 ms] Launching lib\main.dart on Edge in debug mode...
[ +133 ms] Updating assets
[  +86 ms] Waiting for connection from debug service on Edge...
[ +106 ms] <- reset
[  +12 ms] C:\flutter\bin\cache\dart-sdk\bin\dart.exe --disable-dart-dev C:\flutter\bin\cache\artifacts\engine\windows-x64\frontend_server.dart.snapshot --sdk-root
C:\flutter\bin\cache\flutter_web_sdk/ --incremental --target=dartdevc --debugger-module-names --experimental-emit-debug-metadata -DFLUTTER_WEB_AUTO_DETECT=true --output-dill
C:\Users\Alan\AppData\Local\Temp\flutter_tools.9fa073d6\flutter_tool.8c7c515c\app.dill --libraries-spec file:///C:/flutter/bin/cache/flutter_web_sdk/libraries.json --packages
C:\Users\Alan\Desktop\teste issue\teste_issue\.dart_tool\package_config.json -Ddart.vm.profile=false -Ddart.vm.product=false --enable-asserts --track-widget-creation
--filesystem-root C:\Users\Alan\AppData\Local\Temp\flutter_tools.9fa073d6\flutter_tools.f8d6df71 --filesystem-scheme org-dartlang-app --initialize-from-dill
build\b1b715402d823b7fd5c2b68d2edcb2ce.cache.dill.track.dill --platform file:///C:/flutter/bin/cache/flutter_web_sdk/kernel/flutter_ddc_sdk_sound.dill --sound-null-safety
[  +14 ms] <- compile org-dartlang-app:/web_entrypoint.dart
[+16851 ms] Waiting for connection from debug service on Edge... (completed in 17,0s)
[   +1 ms] Synced 26.0MB.
[        ] <- accept
[        ] Caching compiled dill
[ +952 ms] [CHROME]:[32628:21896:0817/231604.312:ERROR:storage_reserve.cc(164)] Failed to open file to mark as storage reserve:
C:\Users\Alan\AppData\Local\Temp\flutter_tools.9fa073d6\flutter_tools_chrome_device.ec688a65\Default\Code Cache\js
[  +22 ms] [CHROME]:
[  +21 ms] [CHROME]:DevTools listening on ws://<IP_ADDRESS>:60002/devtools/browser/0c026c1f-dfcb-429f-ab62-e1f62c0a36bb
[ +911 ms] DwdsInjector: Received request for entrypoint at http://localhost:58105/main_module.bootstrap.js
[   +7 ms] MetadataProvider: Loading debug metadata...
[  +12 ms] MetadataProvider: Loaded debug metadata (sound null safety)
[   +7 ms] DwdsInjector: Injected debugging metadata for entrypoint at http://localhost:58105/main_module.bootstrap.js
[+1893 ms] ChromeProxyService: Initializing expression compiler for main_module.bootstrap.js with sound null safety: true
[  +69 ms] DevHandler: Debug service listening on ws://<IP_ADDRESS>:51694/H0TDqapgm_o=/ws

[  +24 ms] This app is linked to the debug service: ws://<IP_ADDRESS>:51694/H0TDqapgm_o=/ws
[  +11 ms] Debug service listening on ws://<IP_ADDRESS>:51694/H0TDqapgm_o=/ws
[        ]  Running with sound null safety
[   +3 ms]   To hot restart changes while running, press "r" or "R".
[        ] For a more detailed help message, press "h". To quit, press "q".
[   +1 ms] An Observatory debugger and profiler on Edge is available at: http://<IP_ADDRESS>:51694/H0TDqapgm_o=
[ +696 ms] Activating Dart DevTools...
[+8259 ms] Activating Dart DevTools... (completed in 8,3s)
[ +507 ms] The Flutter DevTools debugger and profiler on Edge is available at: http://<IP_ADDRESS>:9102?uri=http://<IP_ADDRESS>:51694/H0TDqapgm_o=

flutter analyze
Analyzing teste_issue...
No issues found! (ran in 1.7s)

[√] Flutter (Channel master, 2.4.0-1.0.pre.82, on Microsoft Windows [versÃ£o 10.0.19042.1165], locale pt-BR)
    • Flutter version 2.4.0-1.0.pre.82 at C:\flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 5cda761161 (6 weeks ago), 2021-07-05 21:46:01 -0400
    • Engine revision 60ff03819c
    • Dart version 2.14.0 (build 2.14.0-280.0.dev)

[√] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at C:\Users\Alan\AppData\Local\Android\sdk
    • Platform android-30, build-tools 30.0.3
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6842174)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[√] Visual Studio - develop for Windows (Visual Studio Community 2019 16.8.5)
    • Visual Studio at C:\Program Files (x86)\Microsoft Visual Studio\2019\Community
    • Visual Studio Community 2019 version 16.8.31005.135
    • Windows 10 SDK version 10.0.18362.0

[√] Android Studio (version 4.2.0)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6842174)

[√] VS Code (version 1.59.0)
    • VS Code at C:\Users\Alan\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.25.0

[√] Connected device (3 available)
    • Windows (desktop) • windows • windows-x64    • Microsoft Windows [versÃ£o 10.0.19042.1165]
    • Chrome (web)      • chrome  • web-javascript • Google Chrome 92.0.4515.159
    • Edge (web)        • edge    • web-javascript • Microsoft Edge 92.0.902.73

Hi @al4nnw
I see there's an open issue addressing the case you described.
Please follow up on that issue, Closing as duplicate of https://github.com/flutter/flutter/issues/83695
If you disagree, please write in the comments and I will reopen it.
Thank you


Build error on iOS

Failed to build iOS app
Error output from Xcode build:
↳
** BUILD FAILED **
Xcode's output:
↳
/Users/xxx/flutter/.pub-cache/hosted/pub.dartlang.org/sumup-0.2.2/ios/Classes/SwiftSumupPlugin.swift:2:8: error: no such module 'SumUpSDK'
import SumUpSDK
^

Hi,
You probably need a flutter clean and a pod install.


Update anchor id for "quota usage"

R: @petele @kaycebasques
@kaycebasques changed the id to use for the anchor in https://github.com/google/WebFundamentals/pull/6856, but unfortunately, we already have that https://developers.google.com/web/tools/chrome-devtools/progressive-web-apps#opaque-responses URL hardcoded into Chrome's DevTools interface.
I'm cool with the change to the section heading that Kayce made, but we need to use the specific id in this PR so that the original URL works.

Whoops!
There were 26 warnings that will prevent this PR from being merged. Please take a look, and either fix, or provide a justification for why they can't be fixed.
WARNINGS
src/content/en/tools/chrome-devtools/progressive-web-apps.md#L28 - Common typo found: 'Service Worker' Should it be 'service worker'? Capitalize Service if it's the first word in the sentence.
src/content/en/tools/chrome-devtools/progressive-web-apps.md#L105 - Common typo found: 'Service Worker' Should it be 'service worker'? Capitalize Service if it's the first word in the sentence.
src/content/en/tools/chrome-devtools/progressive-web-apps.md#L109 - Common typo found: 'Service Worker' Should it be 'service worker'? Capitalize Service if it's the first word in the sentence.
src/content/en/tools/chrome-devtools/progressive-web-apps.md#L27 - Common typo found: 'Homescreen' Should it be 'home screen'? See: https://developers.google.com/style/word-list#home-screen
src/content/en/tools/chrome-devtools/progressive-web-apps.md#L35 - Common typo found: 'homescreen' Should it be 'home screen'? See: https://developers.google.com/style/word-list#home-screen
src/content/en/tools/chrome-devtools/progressive-web-apps.md#L37 - Common typo found: 'homescreen' Should it be 'home screen'? See: https://developers.google.com/style/word-list#home-screen
src/content/en/tools/chrome-devtools/progressive-web-apps.md#L37 - Common typo found: 'homescreen' Should it be 'home screen'? See: https://developers.google.com/style/word-list#home-screen
src/content/en/tools/chrome-devtools/progressive-web-apps.md#L54 - Common typo found: 'homescreen' Should it be 'home screen'? See: https://developers.google.com/style/word-list#home-screen
src/content/en/tools/chrome-devtools/progressive-web-apps.md#L54 - Common typo found: 'Homescreen' Should it be 'home screen'? See: https://developers.google.com/style/word-list#home-screen
src/content/en/tools/chrome-devtools/progressive-web-apps.md#L62 - Common typo found: 'Homescreen' Should it be 'home screen'? See: https://developers.google.com/style/word-list#home-screen
src/content/en/tools/chrome-devtools/progressive-web-apps.md#L62 - Common typo found: 'homescreen' Should it be 'home screen'? See: https://developers.google.com/style/word-list#home-screen
src/content/en/tools/chrome-devtools/progressive-web-apps.md#L64 - Common typo found: 'homescreen' Should it be 'home screen'? See: https://developers.google.com/style/word-list#home-screen
src/content/en/tools/chrome-devtools/progressive-web-apps.md#L66 - Common typo found: 'Homescreen' Should it be 'home screen'? See: https://developers.google.com/style/word-list#home-screen
src/content/en/tools/chrome-devtools/progressive-web-apps.md#L67 - Common typo found: 'homescreen' Should it be 'home screen'? See: https://developers.google.com/style/word-list#home-screen
src/content/en/tools/chrome-devtools/progressive-web-apps.md#L68 - Common typo found: 'Homescreen' Should it be 'home screen'? See: https://developers.google.com/style/word-list#home-screen
src/content/en/tools/chrome-devtools/progressive-web-apps.md#L72 - Common typo found: 'Homescreen' Should it be 'home screen'? See: https://developers.google.com/style/word-list#home-screen
src/content/en/tools/chrome-devtools/progressive-web-apps.md#L72 - Common typo found: 'Homescreen' Should it be 'home screen'? See: https://developers.google.com/style/word-list#home-screen
src/content/en/tools/chrome-devtools/progressive-web-apps.md#L74 - Common typo found: 'homescreen' Should it be 'home screen'? See: https://developers.google.com/style/word-list#home-screen
src/content/en/tools/chrome-devtools/progressive-web-apps.md#L78 - Common typo found: 'Homescreen' Should it be 'home screen'? See: https://developers.google.com/style/word-list#home-screen
src/content/en/tools/chrome-devtools/progressive-web-apps.md#L80 - Common typo found: 'Homescreen' Should it be 'home screen'? See: https://developers.google.com/style/word-list#home-screen
src/content/en/tools/chrome-devtools/progressive-web-apps.md#L82 - Common typo found: 'Homescreen' Should it be 'home screen'? See: https://developers.google.com/style/word-list#home-screen
src/content/en/tools/chrome-devtools/progressive-web-apps.md#L90 - Common typo found: 'Homescreen' Should it be 'home screen'? See: https://developers.google.com/style/word-list#home-screen
src/content/en/tools/chrome-devtools/progressive-web-apps.md#L91 - Common typo found: 'homescreen' Should it be 'home screen'? See: https://developers.google.com/style/word-list#home-screen
src/content/en/tools/chrome-devtools/progressive-web-apps.md#L27 - Line must be at most 100 characters
src/content/en/tools/chrome-devtools/progressive-web-apps.md#L28 - Line must be at most 100 characters
src/content/en/tools/chrome-devtools/progressive-web-apps.md#L30 - Line must be at most 100 characters

Thanks for the fix. Sounds like I need to create some sort of test that throws an error if someone changes an anchor that DevTools depends on.

:tada: This has been pushed live to https://developers.google.com/web/


NativeScript encountered a fatal error: Uncaught ReferenceError: TouchEvent is not defined

When I tap on the canvas I receive the next fatal error:
NativeScript encountered a fatal error: Uncaught ReferenceError: TouchEvent is not defined
at
_getTouchEvent(file: app/webpack:/@nativescript/template-hello-world-ts/node_modules/@nativescript/canvas/Canvas/common.js:278:0)
at _emitEvent(file: app/webpack:/@nativescript/template-hello-world-ts/node_modules/@nativescript/canvas/Canvas/common.js:281:0)
at _touchEvent(file: app/webpack:/@nativescript/template-hello-world-ts/node_modules/@nativescript/canvas/Canvas/common.js:115:0)
at _executeCallback(file: app/webpack:/@nativescript/template-hello-world-ts/node_modules/@nativescript/core/ui/gestures/index.ios.js:197:0)
at TouchGestureRecognizer.executeCallback(file: app/webpack:/@nativescript/template-hello-world-ts/node_modules/@nativescript/core/ui/gestures/index.ios.js:403:0)
at TouchGestureRecognizer.touchesBeganWithEvent(file: app/webpack:/@nativescript/template-hello-world-ts/node_modules/@nativescript/core/ui/gestures/index.ios.js:375:0)
package.json
  "dependencies": {
    "@nativescript/canvas": "^1.0.0-alpha.2",
    "@nativescript/canvas-phaser": "^1.0.0-beta.0",
    "@nativescript/core": "~8.1.1",
    "@nativescript/theme": "~3.0.1",
    "phaser": "3.55.2",
    "xmldom-qsa": "^1.0.3"
  },

main-page.xml
<Page xmlns:canvas="@nativescript/canvas">
    <GridLayout width="100%" height="100%">
        <canvas:Canvas width="100%" height="100%" id="canvas" ready="onCanvasReady"/>
    </GridLayout>
</Page>

main-page.ts
export function onCanvasReady(args: EventData) {
  const canvas = <any>args.object;
  const config: Phaser.Types.Core.GameConfig = {
    canvas,
    type: Phaser.CANVAS,
    customEnvironment: true,
    width: 800,
    height: 600,
    backgroundColor: '#000000',
  };
  // @ts-ignore
  const game = new TNSPhaser.Game(config);
}

Trying installing @nativescript/canvas-polyfill@beta

installed, this was helpful, thank you.


Approach for Paging with Observable Array

I was wondering if there was an approach to implementing automatic paging for an observable array bound to a tableView. i.e. Automatically fetching results in the background and appending the new results to the observable array.
I'm currently experiencing a performance hit when appending data to the array on the main thread (tableView freezes).

Was not using ObservableArrayEvent.... my mistake.


Consider nicknames when searching

With this PR, searching now also finds results using nicknames instead of usernames.
The way I've done this is by prepending the stylized username to the search text, as it seems that nickname matching is based on the stylized username, instead of only the login name / display name. This isn't the best solution, as it does lead to a bit of duplication in the search text for users without a nickname (for example, for the username chrrrs, it would lead to something like chrrrs chrrrs: message). If anyone has a better solution here, I'd be up for changing things around.

https://github.com/Chatterino/chatterino2/blob/e9432d3b6590090961b869fdc260d3ec462ada39/src/widgets/settingspages/NicknamesPage.cpp#L20-L23
This will need to be updated also

Ah yeah, I updated it now to remove the search part from the text

@chrrs As a first-time contributor, you can add yourself to the contributors list that's shown inside the About page in Chatterino.
If you want this, wait for this PR to be merged in, then open a new PR where you modify the resources/contributors.txt file and add yourself to the list. Make sure to read the comments at the top for instructions.


6 new systems added

New systems:

wonderswan
wonderswancolor
sega game gear
neogeo pocket
neogeo pocket color
supergrafx

and NDS wallpaper improvement.

Beautiful pack!

Beautiful pack!

Thank you sensei 🙏

Definitely one of the best! ❤

Definitely one of the best! ❤

I really appreciate it, thank you. 😁


Changing BLEU tokenizer behavior and making the default tokenizer 13a

As it was previously discussed in an issue from 2020, inconsistent tokenization in BLEU can cause reproducibility issues. The proposed solution was to use tokenizer 13a, such as is the default case for SacreBLEU and WMT.
After discussion with @lhoestq , I made this the default dehavior of the BLEU implementation, however making it possible to use other tokeniizers such as NLTK's word_tokenize.
I also updated the README to reflect these changes and to further discuss the impact that tokenization can have on reproducibility of BLEU scores.
Please let me know what you think, @lvwerra and @lhoestq !
cc @thomwolf cause you were involved in the original discussion in the issue I linked above.

PS: for the code quality to pass you might need to run make quality && make style.
done! thanks for the recommendation


Problem Importing phone number

Hello,
I created a CSV file that contains phone number.
Each phone start with a 0 or +32 (for Belgium).
The CSV file look good but when i import it, the number 0 disappear.
Exemple number :<PHONE_NUMBER> result to 444123456 when i import it.
Have you a solution for me ?
Thanks

This should be fixed with 1.3.0

I have the same problem with xlsx
exemple :<PHONE_NUMBER> result to 774768867

Using 2.1.0, but this issue seems to exist