Mm 12290 inline image collapse

Summary
The purpose of this PR is to introduce capability for inline Markdown image to be expanded/collapsed. Moreover, they should take into account user preferences in terms of default embedded content display mode - either collapsed or expanded.
Ticket Link
https://github.com/mattermost/mattermost-server/issues/16636
Related Pull Requests
N/A
Screenshots
Hovering large inline image now displays a special "Collapse" button in the top-left corner of the image:

You can collapse it by clicking on the button and then expand it again by clicking on a special collapsed view of the inline image:

Hello @TheDarkestDay,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

Hello @TheDarkestDay,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

Thanks @TheDarkestDay! This is great. Just a few tweaks from my standpoint:

The image has a border on it when you hover on it. Can we remove that?
Is it possible to animate the collapsing transition? This would help orient users. If not, we could look at that in a separate PR
Can we reduce the margin on the top of .markdown-inline-img to 2px instead of 5px? That should even out the positioning of the arrow button

Thanks @matthewbirtch! Okay, let me try to tackle this step by step.
I've been digging around point 3 and the only question I am currently having - should we apply this change universally to all of the Markdown inline images or should just create some special edge case for this one?
I tried applying this thing globally and I didn't manage to find any specific issues caused by this change. On the other hand, for sure I might be missing some use case which would really explain the purpose of this margin setting.
What do you think, does it make sense to apply this change universally, push it here and let you and the team check it?

Thanks @TheDarkestDay! This is great. Just a few tweaks from my standpoint:

The image has a border on it when you hover on it. Can we remove that?
Is it possible to animate the collapsing transition? This would help orient users. If not, we could look at that in a separate PR
Can we reduce the margin on the top of .markdown-inline-img to 2px instead of 5px? That should even out the positioning of the arrow button

Thanks @matthewbirtch! Okay, let me try to tackle this step by step.
I've been digging around point 3 and the only question I am currently having - should we apply this change universally to all of the Markdown inline images or should just create some special edge case for this one?
I tried applying this thing globally and I didn't manage to find any specific issues caused by this change. On the other hand, for sure I might be missing some use case which would really explain the purpose of this margin setting.
What do you think, does it make sense to apply this change universally, push it here and let you and the team check it?

The image has a border on it when you hover on it. Can we remove that?

Oh, that's the same story, actually.
The thing is that each inline Markdown image is supposed to be clickable - and on click it should be shown in full size in a modal window. And I guess the reason for this shadow-on-hover effect is exactly to give a hint that this image is clickable.
So, the question is - should we treat these "images with expand" somehow different? Should we remove this thing for them or rework somehow?

The image has a border on it when you hover on it. Can we remove that?

Oh, that's the same story, actually.
The thing is that each inline Markdown image is supposed to be clickable - and on click it should be shown in full size in a modal window. And I guess the reason for this shadow-on-hover effect is exactly to give a hint that this image is clickable.
So, the question is - should we treat these "images with expand" somehow different? Should we remove this thing for them or rework somehow?

Is it possible to animate the collapsing transition? This would help orient users. If not, we could look at that in a separate PR

I think at least I could try. The only thing I am concerned about here is performance of height change animation - but we will only find it out if we try it in the wild.
May I kindly ask you to share some assets for this animation? Things like duration, easing function, maybe even some gif would be helpful.

Is it possible to animate the collapsing transition? This would help orient users. If not, we could look at that in a separate PR

I think at least I could try. The only thing I am concerned about here is performance of height change animation - but we will only find it out if we try it in the wild.
May I kindly ask you to share some assets for this animation? Things like duration, easing function, maybe even some gif would be helpful.

I've been digging around point 3 and the only question I am currently having - should we apply this change universally to all of the Markdown inline images or should just create some special edge case for this one?
I tried applying this thing globally and I didn't manage to find any specific issues caused by this change. On the other hand, for sure I might be missing some use case which would really explain the purpose of this margin setting.
What do you think, does it make sense to apply this change universally, push it here and let you and the team check it?

Ok, let's leave this as-is for now and we can look in to it later if we feel strongly that it needs to change.

The thing is that each inline Markdown image is supposed to be clickable - and on click it should be shown in full size in a modal window. And I guess the reason for this shadow-on-hover effect is exactly to give a hint that this image is clickable.
So, the question is - should we treat these "images with expand" somehow different? Should we remove this thing for them or rework somehow?

Makes sense. Let's leave the border and shadow effect

I think at least I can try. The only thing I am concerned about here is performance of height change animation - but we will only find it out if we try it in the wild.
May I kindly ask you to share some assets for this animation? Things like duration, easing function, maybe even some gif would be helpful.

Give these a go:
transition: height 250s cubic-bezier(0.5, 0, 0.5, 1);

We may need to tweak the above, but we'll see when it's in the wild.

I've been digging around point 3 and the only question I am currently having - should we apply this change universally to all of the Markdown inline images or should just create some special edge case for this one?
I tried applying this thing globally and I didn't manage to find any specific issues caused by this change. On the other hand, for sure I might be missing some use case which would really explain the purpose of this margin setting.
What do you think, does it make sense to apply this change universally, push it here and let you and the team check it?

Ok, let's leave this as-is for now and we can look in to it later if we feel strongly that it needs to change.

The thing is that each inline Markdown image is supposed to be clickable - and on click it should be shown in full size in a modal window. And I guess the reason for this shadow-on-hover effect is exactly to give a hint that this image is clickable.
So, the question is - should we treat these "images with expand" somehow different? Should we remove this thing for them or rework somehow?

Makes sense. Let's leave the border and shadow effect

I think at least I can try. The only thing I am concerned about here is performance of height change animation - but we will only find it out if we try it in the wild.
May I kindly ask you to share some assets for this animation? Things like duration, easing function, maybe even some gif would be helpful.

Give these a go:
transition: height 250s cubic-bezier(0.5, 0, 0.5, 1);

We may need to tweak the above, but we'll see when it's in the wild.

@matthewbirtch feel free to have a look at the animation. I am not exactly sure that this is the behavior we would like to achieve but let's at least use this as some sort of starting point.

@matthewbirtch feel free to have a look at the animation. I am not exactly sure that this is the behavior we would like to achieve but let's at least use this as some sort of starting point.

Thanks @TheDarkestDay.

It looks like the animation may be too fast. Maybe we need to make it 300ms in duration.
I think we can constrain the animation to the height and have it crop the image as the height of the container shrinks.
It feels a little jittery due to the way the transition happens between the title and collapsing image

It looks like the title animates in from the right which seems odd. This element doesn't need to move horizontally at all

If this is adding too much complexity to this PR, we can consider leaving the animation out of this and we could look to enhance with animation in another ticket. Thoughts?

Thanks @TheDarkestDay.

It looks like the animation may be too fast. Maybe we need to make it 300ms in duration.
I think we can constrain the animation to the height and have it crop the image as the height of the container shrinks.
It feels a little jittery due to the way the transition happens between the title and collapsing image

It looks like the title animates in from the right which seems odd. This element doesn't need to move horizontally at all

If this is adding too much complexity to this PR, we can consider leaving the animation out of this and we could look to enhance with animation in another ticket. Thoughts?

@TheDarkestDay one other thing I noticed is that using the /collapse /expand slash commands should cause the inline markdown images to collapse or expand in the view, similar to image link previews (ie posting https://www.mattermost.org/wp-content/uploads/2016/03/logoHorizontal.png)

@TheDarkestDay one other thing I noticed is that using the /collapse /expand slash commands should cause the inline markdown images to collapse or expand in the view, similar to image link previews (ie posting https://www.mattermost.org/wp-content/uploads/2016/03/logoHorizontal.png)

For expanding/collapsing with those commands, we'd need to make it so that we store the expanded/collapsed state in local storage like the collapsed state for link previews. If it's storing the expanded/collapsed state in the same place, then those commands as well as the "expand/collapse by default" user setting should just work with these images too.

For expanding/collapsing with those commands, we'd need to make it so that we store the expanded/collapsed state in local storage like the collapsed state for link previews. If it's storing the expanded/collapsed state in the same place, then those commands as well as the "expand/collapse by default" user setting should just work with these images too.

@esethna thanks for bringing this up. I was completely unaware of this feature in Mattermost.
I've fixed that - as far as I got for know expand/collapse settings are common for both link previews as well as these Markdown inline images. I assume that this should be fine, right? @hmhealey

@esethna thanks for bringing this up. I was completely unaware of this feature in Mattermost.
I've fixed that - as far as I got for know expand/collapse settings are common for both link previews as well as these Markdown inline images. I assume that this should be fine, right? @hmhealey

If this is adding too much complexity to this PR, we can consider leaving the animation out of this and we could look to enhance with animation in another ticket. Thoughts?

I will try my best to play around this during weekend - just in order to be sure that this thing truly deserves separate ticket.

If this is adding too much complexity to this PR, we can consider leaving the animation out of this and we could look to enhance with animation in another ticket. Thoughts?

I will try my best to play around this during weekend - just in order to be sure that this thing truly deserves separate ticket.

@TheDarkestDay how's this going? Let us know when you're ready for another review

@esethna sure, thanks for getting in touch.
I am currently working on fixes proposed by @hmhealey (thank you for review, by the way) and yet another (last, I suppose) take for collapse/expand animation.
I'll let you know as soon as it is ready.

Hey, @hmhealey.
I think I've covered all of the point from your last review. So, feel free to have a look.
The only difference from your proposal here is that inline images visibility data is stored inside storage fields prefixed with dedicated INLINE_IMAGE_VISIBLE prefix. I think it might be a good idea to setup this way of distinguishing between regular embeds preview and inline images. Semantically these things are different so that's why I have been tentative to use the same prefix for both of them.
Let me know your opinion - if general approach is OK, I will finish this work up with some missing unit tests.

@amyblais can we add this to the v5.34 milestone?

@amyblais can we add this to the v5.34 milestone?

@metanerd I don't have permissions to add new milestones for webapp PRs, can you help share the permission with me?

Seems good to me. We can look at animation in another PR later

I am terribly sorry that I didn't reach out to you regarding animations. Okay, let's move it to separate ticket, since I anyway haven't managed to find anything feasible.

Hey, guys. I've fixed most of the latest issues related to key used for keeping expand/collapse state in local storage. On the other hand, I think I've found something concerning from a QA perspective.
At first, I added couple of inline images into one post:

Then I decided to expand both of them and I ended up looking at this post with content being cut, just like this:

Meanwhile I can observe a special behavior for regular posts which simply hold a lot of text content. They can be expanded/collapsed via "Show more / Show less" buttons.
So, I guess ideally we would like to have the same "Show more / Show less" feature enabled for posts whose height can be dynamically changed due to inline images expansion or collapse, right?

So, I guess ideally we would like to have the same "Show more / Show less" feature enabled for posts whose height can be dynamically changed due to inline images expansion or collapse, right?

That's a good catch @TheDarkestDay. I think you're right. We should account for this

Oh yeah, I hadn't thought of that. We're not triggering the code that checks to show the Show More button in that case (link) since the image has already been loaded at that point. The naming is a bit unfortunate, but I suppose we could just have the onImageLoaded prop called when the image expands or collapsed. That should work since the MarkdownImage already has access to that callback anyway.

Oh yeah, I hadn't thought of that. We're not triggering the code that checks to show the Show More button in that case (link) since the image has already been loaded at that point. The naming is a bit unfortunate, but I suppose we could just have the onImageLoaded prop called when the image expands or collapsed. That should work since the MarkdownImage already has access to that callback anyway.

Got it. Yep, I've tried doing it this way. So far seems to be working, but there is only thing that I would like to consult about. MarkdownImage component passes an object containing image dimensions via onImageLoaded prop:
https://github.com/mattermost/mattermost-webapp/blob/master/components/markdown_image.jsx#L79
However, there is one party which does not really expect receiving an object like this. This component is called PostMessageView
https://github.com/mattermost/mattermost-webapp/blob/master/components/post_view/post_message_view/post_message_view.tsx#L61
and it actually expected to get only height as a dimension, without wrapping object (handleHeightReceived gets passed to MarkdownImage props via this.imageProps).
As far as I got, this thing has not been working at all so far. Is it safe to simply migrate to obtaining dimensions object from onImageLoaded?
On top of that - what was the actual point of recalculating height change only when height is greater than zero? Is it possible to get it negative for some reason?

I don't think we can completely change the type of handleHeightReceived unfortunately since it's also passed into plugins via the Pluggable component in there. Perhaps we could implement a separate method that takes a dimensions object and calls handleHeightReceived from that? Then we could pass that in imageProps instead.
I don't actually know why we only recalculate when height is greater than 0. It dates back to https://github.com/mattermost/mattermost-webapp/pull/1606, but that was added quite a while ago, and I'm not sure if @saturninoabril would remember why he added that.

Thanks for guidance, @hmhealey.
At this moment it looks as if we don't need any information regarding image dimensions in order to figure out, whether we should check post overflow or not.
That's why I've decided to extend MarkdownImage API to expose another prop called onImageHeightChanged which is intended to be used when image changes its height during runtime for some reason. Like in our case, this change might occur because of somer special user interaction like expanding/collapsing. So, now PostMessageView utilizes this callback as a simple trigger, doing overflow checks when this callbacks gets called.

I don't actually know why we only recalculate when height is greater than 0. It dates back to #1606, but that was added quite a while ago, and I'm not sure if @saturninoabril would remember why he added that.

I've added that for plugin that changes post message view like in the case of autotranslate plugin where the height changes depending on returned text translation. handleHeightReceived might not be named properly specially the height parameter since it's not really an actual height change of a text but just a number for the webapp to trigger recompute and eventually render post message with translation correctly (not being cut-off) , and render "Show more" / "Show less" as necessary. This was done so that height change is handled by the webapp and not by the plugin.
Before translation:

After translation:

Thanks, @esethna -- taking a look now :)

I pulled latest changes from master and it looks as though these elevation values had already been updated to 0.12. Therefore, I assume that this discussion point is resolved.

@TheDarkestDay Yup.

/update-branch

Thank you @TheDarkestDay
Looks great, few questions

When a post has multiple images, is it expected when clicking on one button to collapse/expand all images at the same time? Each image has a separate collapse button, it made me believe I could action each separately.
When inline image is linked, button is part of the link and breaks the underline a bit (see image);

Thanks, @jgilliam17

When a post has multiple images, is it expected when clicking on one button to collapse/expand all images at the same time? Each image has a separate collapse button, it made me believe I could action each separately.

This is some sort of drawback we have been aware of.
The thing is that we have to store each image state (is it collapsed or not) by some key. The only viable option we had here is to use image URL as a key. This is the reason why multiple inline images with the same URL will expand and collapse simultaneously.
Other approaches might result in more harmful UX (like collapsing/expanding images suddenly after editing) or require a way more efforts.
Our assumption was that it would not be a widespread use case to upload several inline images with the same URL. However, if you see some issues with this assumption - feel free to let us know, maybe we should rethink it.

Thank you @TheDarkestDay
I agree, post with multiple inline images may not be used often, I don't have any objections to proceeding with the current implementation.
For the second point

When inline image is linked...

I discussed this with @matthewbirtch, his suggestion is to remove underline on hover

I discussed this with @matthewbirtch, his suggestion is to remove underline on hover

Oh, many thanks for taking care of it. I will work on this shortly.

Hey, guys.
I've finished working on the getting rid of underlining, but it looks as if I am no longer able to run ESLint checks. Here is the output of my make check-style command:
Checking for style guide compliance
npm run check

><EMAIL_ADDRESS>check /Users/abrenchev/Documents/dev/mattermost/mattermost-webapp
> eslint --ext .js,.jsx,.tsx,.ts . --quiet --cache

Oops! Something went wrong! :(

ESLint: 7.19.0

ESLint couldn't find the plugin "eslint-plugin-mattermost".

(The package "eslint-plugin-mattermost" was not found when loaded as a Node module from the directory "/Users/abrenchev/Documents/dev/mattermost/mattermost-webapp".)

It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:

    npm install eslint-plugin-mattermost@latest --save-dev

The plugin "eslint-plugin-mattermost" was referenced from the config file in ".eslintrc.json".

If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team.

npm ERR! code ELIFECYCLE
npm ERR! errno 2
npm ERR<EMAIL_ADDRESS>check: `eslint --ext .js,.jsx,.tsx,.ts . --quiet --cache`
npm ERR! Exit status 2
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>check script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR!      /Users/abrenchev/.npm/_logs/2021-04-02T09_00_06_732Z-debug.log
make: *** [check-style] Error 2

Node.js version is 10.15.3.
Have you recently changed something in a repo workflow? Should I add some additional dependencies or maybe post this issues in some other channel?

There hasn't been any changes to the dependencies in the last week or two. Our ESLint plugin doesn't exist on npm, so you won't be able to install it that easily, but it can be installed by pointing npm install to the git repo directly. That said, it should be installed automatically if you remove node_modules and re-run npm install.
The linting issues from CircleCI are as follows though:
/root/mattermost/mattermost-webapp/components/markdown_image_expand/index.ts
  3:1  error  There should be at least one empty line between import groups                      import/order
  4:1  error  There should be at least one empty line between import groups                      import/order
  5:1  error  `react-redux` import should occur before import of `mattermost-redux/types/store`  import/order

Got latest updates from master branch. Now everything seems to be working fine.

@hmhealey Can you please help merge. Thanks 🙂

Merged! Thanks again for the PR, @TheDarkestDay. This will be on Mattermost Cloud some time in the next couple weeks and then in (I think) Mattermost 5.35 after that.

/cherry-pick cloud

Cherry pick is scheduled.


fix: update references to logging exporter

This exporter has been replaced by the debug exporter and will be removed soon. Related to https://github.com/open-telemetry/opentelemetry-collector/pull/11037

pinging @open-telemetry/sig-mainframe-approvers

note that the logging exporter has been removed since this PR has been opened.

thanks, @codeboten .


Missing type declarations for commands inside chat instance

Expected behaviour
Following the documentation, you should be able to timeout an user.
Actual behaviour
Typescript throws:
Property 'timeout' does not exist on type 'Chat'.
Steps to reproduce
A typescript file, like:
// example.ts

import TwitchJs from 'twitch-js'
const config= {
  username: 'twitch-username',
  token: 'twitch-token,
}

export const { chat } = new TwitchJs(config)

const run = async () => {
  await chat.connect()
  await chat.join('twitch-username')
  await chat.timeout('twitch-username', 'user-to-timeout', 100)
}

I managed to bypass it by adding this to my global.d.ts file:
declare module 'twitch-js' {
  declare class Chat extends Chat {
    timeout(channel: string, username: string, seconds: ?number)
  }
}

This is just a temporary fix for someone having the same problem, but I wish this could be fixed correctly.
My environment

Operating system(s): Win 10
TwitchJS version: 2.0.0-beta.33
NodeJS version: 14.7.0
TypeScript version: 4.0.2

Duplicate of #234


Use /proc/mdstat to see if the raid array exists

instead of checking /dev/mapper
since the raid array isn't showing up in /dev/mapper

@bmhatfield do we still need this? what do you think about it?

closing since this is very old. we can re-open if needed.


Problem while trying to run project

I dont know if someone is still working on this, but this repo is just my salvation for finish my last course on the university, whatever, when i uploaded the version of the eyetribe server to the last release, got the following error:

Maybe im making something weird or just the update of  the eyetribe sdk or maybe node is making this issue.
Hope someone can help me with this! because is extremely necessary this repo for me

Just was the version of node, if you pass through the same error just try to use some version of node < 6, cheers


SystemError: new style getargs format but argument is not a tuple

When we run "Main_Stereo_Vision_Prog.py" it gives the above error in stereocalibrate function
# StereoCalibrate function
flags = 0
flags |= cv2.CALIB_FIX_INTRINSIC
#flags |= cv2.CALIB_FIX_PRINCIPAL_POINT
#flags |= cv2.CALIB_USE_INTRINSIC_GUESS
#flags |= cv2.CALIB_FIX_FOCAL_LENGTH
#flags |= cv2.CALIB_FIX_ASPECT_RATIO
#flags |= cv2.CALIB_ZERO_TANGENT_DIST
#flags |= cv2.CALIB_RATIONAL_MODEL
#flags |= cv2.CALIB_SAME_FOCAL_LENGTH
#flags |= cv2.CALIB_FIX_K3
#flags |= cv2.CALIB_FIX_K4
#flags |= cv2.CALIB_FIX_K5
retS, MLS, dLS, MRS, dRS, R, T, E, F= cv2.stereoCalibrate(objpoints,
                                                          imgpointsL,
                                                          imgpointsR,
                                                          mtxL,
                                                          distL,
                                                          mtxR,
                                                          distR,
                                                          ChessImaR.shape[::-1],
                                                          criteria_stereo,
                                                          flags)

Output:
Starting calibration for the 2 cameras...
Cameras Ready to use
Traceback (most recent call last):
  File "/home/prasad/Desktop/Distance with SV/Main_Stereo_Vision_Prog.py", line 135, in <module>
    (flags,flags))
SystemError: new style getargs format but argument is not a tuple

Hello @prasad01dalavi and thank you for testing our code!
Do you have opencv3 installed on your computer? Because some people seems to have the same kind of error when it is installed: https://github.com/ros-perception/image_pipeline/issues/124

Hello LearnTechWithUs,
I have opencv 2.4.9 and 2.4.13

I am using ubuntu. How do I install opencv3. could you just help me with that please?

Can you try to enter this in your python command line to see which version is actually used when importing opencv?
import cv2
and then
cv2.__version__

yes. I got <IP_ADDRESS>

done. opencv3 solves that error. But not able to get the clear display of object

Hello? Are you there man. Let me show you the results: Please have a look on them. can you please suggest how to get that white box as shown in your video?

Please check this image.

I'm glad you could finally run the script!
The stereo calibration has certainly not been done correctly. One possible reason is that you don't have enough calibration pictures or they are maybe blurry!
You should certainly take new (and more) pictures of the chessboard with your cameras.
Don't give up ;)
I hope it will work!

Thank you so much for your reply. I had taken 65 images (65 left + 65 right). As you said i am also doubtful about their blurry style. I am gonna do it and let you know.

It works bro! Thank you so much. Moving towards accuracy like you had in your video. i was just 50% of that.


[2635] snag trainee data summary card not shown even after complete

Context

This trello ticket

Changes proposed in this pull request

The edit page was rendered entirely inside of the TraineeData::View component, even parts that were specific to the edit page.
I moved the edit page specifics out of the component so we can render the summary cards in the trainee record
When I have reviewed this section has been ticked, progress_tracker for trainee_data was also updated to true

Guidance to review

Make sure an Apply Draft Trainee has their trainee data section completed, and ticked with I have reviewed this section
Then go to the check-details section and you will see the summary card(s) of the trainee data section in that view.

Working for me too - nIce!


Add BranchInfo and getBranches Method

Hi Urs,
I've added a getBranches() method to the ProjectApi which will return a list of BranchInfo objects for the queried project. I'm intending on extending this to get all of the branch endpoints, but right now this functionality is very useful for my Gerrit project.
Tim

Coverage decreased (-0.89%) to 89.74% when pulling d14c6d1b7089c2bde0f9758f9072c894626f4cd3 on timrcoulson:master into f16364af081ebe1dac0468ca8bd3d93d96f1a8ce on uwolfer:master.

Hi Tim
Thank you!
You have touched com.google classes. When we extend this code, we should contribute it back to Gerrit code base.
I think there is already API in ProjectApi for getting branches. See: https://gerrit.googlesource.com/gerrit/+/HEAD/gerrit-extension-api/src/main/java/com/google/gerrit/extensions/api/projects/ProjectApi.java
Do you think this API could be implemented?

Hi Urs,
Yes, I hadn't checked the latest in the Gerrit source! Scratch that work, I'm implementing these now.
Tim

Replaced with PR #13.


Use uuid instead of node-uuid

This avoids the following deprecation warning upon npm install:
npm WARN deprecated<EMAIL_ADDRESS>use uuid module instead

web-ext still uses node-uuid indirectly (via sign-addon -> request),
but I'm working on fixing that too. See https://github.com/mozilla/sign-addon/pull/245

Cross project clean up, nice :+1:


`odo create' overwrites .odo configuration without warning

[kind/bug]
What versions of software are you using?

Operating System: Windows 10
Output of odo version: build from master

How did you run odo exactly?
>dist\bin\windows-amd64\odo.exe create nodejs nodejs-test1 --app new --project myproject --context C:\Temp\nodejs-ex\nodejs-ex
 V  Checking component
 V  Checking component version
Please use `odo push` command to create the component with source deployed

.odo/config.yaml content is
kind: LocalConfig
apiversion: odo.openshift.io/v1alpha1
ComponentSettings:
  Type: nodejs
  SourceLocation: C:\Temp\nodejs-ex\nodejs-ex
  SourceType: local
  Application: new
  Project: myproject
  Name: nodejs-test1

>dist\bin\windows-amd64\odo.exe create nodejs nodejs-test2 --app new1 --project myproject1 --context C:\Temp\nodejs-ex\nodejs-ex
 V  Checking component
 V  Checking component version
Please use `odo push` command to create the component with source deployed

.odo/config.yaml content was updated without warning with new values
kind: LocalConfig
apiversion: odo.openshift.io/v1alpha1
ComponentSettings:
  Type: nodejs
  SourceLocation: C:\Temp\nodejs-ex\nodejs-ex
  SourceType: local
  Application: new1
  Project: myproject1
  Name: nodejs-test2

Actual behavior
No warnings about creating new component over existing one
Expected behavior
Warning about current configuration for context is coing to be replaced with new one
Any logs, error output, etc?
N/A

Thank you @dgolovin  for testing odo.
We already have  issue for this https://github.com/openshift/odo/issues/1447


Make phpdoc of Node and its subclasses more accurate

Some node subclasses have Token (not an array) as $this->children
Undefined variable in coalesce
be more specific about getRoot()'s expected value.
use string ...$classNames (same syntax as a real signature)
https://github.com/phpDocumentor/fig-standards/pull/87#r37054459
EchoExpression has ExpressionList (no expressions would be invalid PHP)
One form of string literal can be a single token, others (e.g. "something $varName" may have multiple tokens and expressions)

@TysonAndre,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

Thanks!


[SPARK-14416][Core]Add thread-safe comments for CoarseGrainedSchedulerBackend's fields

What changes were proposed in this pull request?
While I was reviewing #12078, I found most of CoarseGrainedSchedulerBackend's mutable fields doesn't have any comments about the thread-safe assumptions and it's hard for people to figure out which part of codes should be protected by the lock. This PR just added comments/annotations for them and also added strict access modifiers for some fields.
How was this patch tested?
Existing unit tests.

cc @andrewor14

Test build #55044 has started for PR 12188 at commit 837988f.

Test build #55044 has finished for PR 12188 at commit 837988f.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/55044/
Test FAILed.

Merged build finished. Test FAILed.

Thanks, I love this patch!

retest this please

Test build #55047 has started for PR 12188 at commit 837988f.

Test build #55047 has finished for PR 12188 at commit 837988f.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/55047/
Test FAILed.

retest this please, it should be fixed by now...

Test build #55056 has started for PR 12188 at commit 837988f.

super may not be used on value minRegisteredRatio

Scala doesn't allow to override a val and call super.

Test build #55056 has finished for PR 12188 at commit 837988f.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/55056/
Test FAILed.

Test build #55059 has started for PR 12188 at commit 6a94b7f.

Test build #55063 has started for PR 12188 at commit 33abf5c.

Test build #55063 has finished for PR 12188 at commit 33abf5c.

This patch fails MiMa tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/55063/
Test FAILed.

retest this please

Test build #55070 has started for PR 12188 at commit 33abf5c.

Test build #55059 has finished for PR 12188 at commit 6a94b7f.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/55059/
Test PASSed.

Test build #55070 has finished for PR 12188 at commit 33abf5c.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/55070/
Test PASSed.

Merged build finished. Test PASSed.

Mergd into amster


Saves log on success

This change adds the option to save the log when there is a successful build, by default will be turned off.
We need this to gather valuable information of the build as number of warnings per target, number of tests per target, duration of tests per target, path of the generated .app so we can track its size via a test, build duration, etc..

already added in this pr https://github.com/bitrise-steplib/steps-xcode-test/pull/143


Short Namespaces Quickly PARA Method Confirmation Hyperlink (Paste URL) Confirmation DONE task

Submit new Plugins to Marketplace
Plugin Github repo URL:
https://github.com/YU000jp/logseq-plugin-short-namespaces
https://github.com/YU000jp/logseq-plugin-quickly-para-method
https://github.com/YU000jp/logseq-plugin-confirmation-hyperlink
https://github.com/YU000jp/logseq-plugin-confirmation-done-task
Github releases checklist

[x] a legal package.json file.
[x] a valid CI workflow build action for Github releases. (Optional for theme plugin only).
[x] a release which includes a release zip pkg from a successful build.
[x] a clear README file, ideally with an image or gif showcase. (For more friendly to users, it is recommended to have English version description).
[x] a license in the LICENSE file.

A per plug-in PR is probably better


!tclearadds message when calling tclear on empty topics

Bug
If the bot clears the topic list while it is empty (i.e. there are no topics), a message will be sent in the topics channel.
Recreation
Call !tclear on an empty topics list.
Expected Behavior
Nothing
Actual Behavior
The following message is sent in the topics channel:
List of Topics

React to the respective icon below to subscribe to the topic!

#14


Manifest validation succeeds when NestedInstaller(Type | Files) is used for non-zip packages

Brief description of your issue
Seen in microsoft/winget-pkgs@5694bd8 (#162833). The manifest specifies NestedInstallerType and NestedInstallerFiles when InstallerType is not zip.  Package validation succeeds without any warnings. Although it doesn't have an effect in either the uninstall or install flow for the package in mentioned PR, this doesn't seem to be the semantic / appropriate way of writing out the manifest file. May have unintended consequences elsewhere but I couldn't find a significant issue with it yet
Steps to reproduce
Add following in any installer manifest
InstallerType: (msi|exe|portable|inno...any non-zip)
NestedInstallerType: (msi|exe|portable...)
NestedInstallerFIles:
- RelativeFilePath: <any_path>
  PortableCommandAlias: <any_alias>
- RelativeFilePath: <any_path2>
  PortableCommandAlias: <any_alias2>
...

Run winget validate --manifest <path_to_manifest>
Expected behavior
Manifest validation fails
Actual behavior
Manifest validation succeeds with no warnings
Environment
Windows Package Manager v1.8.1911
Copyright (c) Microsoft Corporation. All rights reserved.

Windows: Windows.Desktop v10.0.22631.3880
System Architecture: X64
Package: Microsoft.DesktopAppInstaller v1.23.1911.0

Winget Directories
-----------------------------------------------------------------------------------------------------------------------
Logs                               %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\Diag…
User Settings                      %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\sett…
Portable Links Directory (User)    %LOCALAPPDATA%\Microsoft\WinGet\Links
Portable Links Directory (Machine) C:\Program Files\WinGet\Links
Portable Package Root (User)       %LOCALAPPDATA%\Microsoft\WinGet\Packages
Portable Package Root              C:\Program Files\WinGet\Packages
Portable Package Root (x86)        C:\Program Files (x86)\WinGet\Packages
Installer Downloads                %USERPROFILE%\Downloads

Links
---------------------------------------------------------------------------
Privacy Statement   https://aka.ms/winget-privacy
License Agreement   https://aka.ms/winget-license
Third Party Notices https://aka.ms/winget-3rdPartyNotice
Homepage            https://aka.ms/winget
Windows Store Terms https://www.microsoft.com/en-us/storedocs/terms-of-sale

Admin Setting                             State
--------------------------------------------------
LocalManifestFiles                        Enabled
BypassCertificatePinningForMicrosoftStore Disabled
InstallerHashOverride                     Enabled
LocalArchiveMalwareScanOverride           Disabled
ProxyCommandLineOptions                   Disabled
DefaultProxy                              Disabled

[Policy] Issue-Bug
[Policy] Command-Validate


Proxy Preserve Host option on Custom Locations and Proxy Hosts

By default nginx seem to don't preserve the host port (in certain case).
in some case is usefull like in https://github.com/esphome/issues/issues/4327 to preserve the host AND the port.
in apache you have an options to do that ProxyPreserveHost, in nginx you can use http_host variable to that.
in this maner:
proxy_set_header Host $http_host;

https://serverfault.com/questions/706438/what-is-the-difference-between-nginx-variables-host-http-host-and-server-na
it would be possible to add an option (in proxy host and in custom locations) to pass the host as is (with port) in the Nginx Proxy Manager as flag on/off to simplify the usage ?

👍


Exposing FunctionInputConverterException and FunctionWorkerException

Fixes #746
Exposing FunctionInputConverterException and FunctionWorkerException as public so that users can use these in middlewares of custom input converters as needed.
I have not updated the package versions in this PR. We shall club this change with another package release we plan to do shortly.

/check-enforcer evaluate


sh.vim: Feature request - Better processing of bash's substring expansion

A valid substring expansion that can be differentiated from the :- expansion should not show as an error.
#!/bin/bash
f() {
  local last=${1: -1:1}
  echo ${last}
}
f abc

Please try v168 of syntax/sh.vim -- I don't see a problem with your example with it.
Regards,
Chip Campbell

Tried out 168 and still seeing the error.
Uploading some screenshots showing the error colorization.  Also uploaded some highlight colorization showing that colorization is an error colorization.

Fixed by e4a3bcf28d92d0bde9ca227ccb40d401038185e5.


Change "Pages to show the sidebar" into "Hide sidebar on the following pages"

This change is needed to fix issues which occur frequently when the admin is unable to make the sidebar visible on some pages (example: pages of unsupported extension).
By inverting the logic for this option, such issues will be fixed, and it will be possible to show the sidebar on all pages.

Out of scope.


Service tags as connection requirements for Azure Portal need to be updated

To allow access to the Azure Portal, we need to allow the service tag "AzureFrontDoor.FirstParty".
However, the below description is lack of the service tag "AzureFrontDoor.FirstParty".
https://learn.microsoft.com/en-us/azure/azure-portal/azure-portal-safelist-urls?tabs=public-cloud#azure-portal-urls-for-proxy-bypass

portal.azure.com is resolved to <IP_ADDRESS>.

nslookup portal.azure.com
.….
Addresses:  2603:1061:11::27
<IP_ADDRESS>
Aliases:  portal.azure.com
portal.azure.com.trafficmanager.net
azureportal.z01.azurefd.net
azurefd-p-prod.trafficmanager.net
shed.s-part-0027.p-0010.p-msedge.net

This IP address range is included in ‘AzureFrontDoor.FirstParty’, so permission is required.
https://www.microsoft.com/en-us/download/details.aspx?id=56519

@rinoue-m
Thanks for your feedback! We will investigate and update as appropriate.

@rinoue-m
Thank you for bringing this to our attention.
I've delegated this to content author, who will review it and offer their insightful opinions.


feat: add callFrom entry point

prototype implementation for #1358

Current dependencies on/for this PR:

main

PR #1372

PR #1370

PR #1364   👈

This comment was auto-generated by Graphite.


Inspecting active sessions and queries

Add 1.1 page for SHOW SESSIONS
Add 1.1 page for SHOW QUERIES
Generate sql diagrams
Add statements to 1.1 sidenav
Add statements to 1.1 sql statements overview

Note: In separate PRs, I'll cover CANCEL QUERY and inspecting schema changes in the UI and add more details to the page on troubleshooting query behavior.
Fixes #1562
Fixes #1572

This change is

cc: @knz, @dianasaur323, and @nstewart, if you want to take a look as well.

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/60d74b83ec92cae64c0c2b4e6b5836b412ee1927/

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/dcdbccbb4b35713e8372cd56b1cda3bad1c0708c/

Great, thank you. This is on my list of features to QA, so I'll let you know if I hit any issues.

Actually, @nstewart and @dianasaur323, please hold off on your reviews until @itsbilal gets his in. Want to ensure everything's correct technically. Also need to integrate some changes from https://github.com/cockroachdb/cockroach/pull/17579.

TFTR, @itsbilal. Just expanded the SHOW SESSIONS to cover last_active_query. Please take a quick look.
I can't quite understand your suggestion about filtering above. I think part of your query got truncated?

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/bfbb23a9808bbb8b08040485f29b210fcd1762eb/

@jseldess The initial message got truncated but I edited it. Take another look? It's basically just the nesting of a SELECT inside the CANCEL QUERY.
LGTM otherwise. It's your call on whether to mention the nested query example in the docs or not, but I'd argue it's a very useful one to have in there.

Added your nester query example, @itsbilal. Thanks! Also added a dummy SHOW JOBS page to fix broken links. Will tackle that page in a follow-up PR.

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/a5ef25aa067f25f719cbffce11e97f5bfee6267a/

@nstewart, @dianasaur323, PTAL when you have time.

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/d03fd7da19a08ade57b2dc53b42cd8263083102e/

Ping, @nstewart.

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/c6c7c8373f84a00e6d45126899365ad12c430cdb/

@itsbilal, I ended up expanding this PR to cover CANCEL QUERY and another high-level page on Managing Long-Running Queries that links the disparate SQL statements. PTAL.

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/58430df67479bea3ab52373524a7f5afde7e0bb3/

Might need to integrate changes from https://github.com/cockroachdb/cockroach/pull/17739.

When the cancelled query is part of a multi-statement transaction, CockroachDB aborts the transaction and sends a query execution cancelled error to the client, at which point the client should issue a ROLLBACK statement.

This seems to imply that CANCEL QUERY only works for queries in multi-statement transactions, and that it won't do anything for autocommit queries. It would be good to mention that it does cancel standalone/autocommit queries too. However cancellation isn't guaranteed; if the request is received too late, the query could still run till completion. That should probably be stated too.
Also note that the spelling of cancelled in the query execution cancelled error has been changed to canceled in https://github.com/cockroachdb/cockroach/pull/17739 .

Thanks, @itsbilal. Made updates.

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/fd31a6c0928f0f17f1a552519260732aab9cdc25/

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/93b5eb769c385d245e17be210e63ad5073f0ebf9/

I already ran through the docs, and things worked fine for me. Thanks Jesse.
On Mon, Aug 21, 2017 at 10:30 AM Jesse Seldess<EMAIL_ADDRESS>wrote:

Ping, @nstewart https://github.com/nstewart.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/cockroachdb/docs/pull/1828#issuecomment-323757325,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFgDWI_Su9imvGNqVglBPh381RWdHo42ks5saZRpgaJpZM4O5TI3
.

--
Diana Hsieh
<EMAIL_ADDRESS>407-690-9048


Update/maintainers.md

Description
Adding information for maintainers about the role.
Issues Resolved
#95
#684
Check List

[N/A ] New functionality includes testing.

[N/A ] All tests pass

[N/A ] New functionality has been documented.

[N/A ] New functionality has javadoc added

[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

We've been iterating on org-wide docs. I think I want to thin out the ones in this repo and start pointing to the ones in https://github.com/opensearch-project/.github like in https://github.com/opensearch-project/OpenSearch/pull/853. @CEHENKLE you're cool with this? Want to port this content into RELEASING in .github?

I'm going to close this out because much of the other notes have been folded into https://github.com/opensearch-project/OpenSearch/pull/853  Let's go take a look at those.


Fix cluster overview dashboard

How to categorize this PR?

/area monitoring
/kind bug
What this PR does / why we need it:
With GEP-19, the name of the prometheus job changed. The expression used in the dashboard panel meant that because there didn't exist a time series named up with the label value pair job="prometheus", the panel showed Prometheus as down. Thanks @ScheererJ for noticing this! 🙇
Special notes for your reviewer:
/cc @istvanballok @vicwicker
FYI @ScheererJ
Release note:

NONE

/cherry-pick release-v1.95


Remove game from recently played list

Adds a cross button in order to remove a game from the recently played list.
Tested that it works with the export save button.
Fixes #178  and partially #353.

Hi!
Thanks for submitting this PR!
Would it be possible for you to modify this PR so that it requires two clicks to remove the game from the list with a visual indication that a second click is required(i.e. button changes to red) after the first one?
We are a little worried about accidental deletes, and think something like this could resolve that.

I'm going to close this pull request as its code is now being continued and tracked in this pull request: https://github.com/skylersaleh/SkyEmu/pull/468


Forgot/Set New-Password-Admin-App Sprint-1

Description:

Build the Screen using the style guide.
Integrate Screen with the Backend

I would take this on


Changelog

Have a changelog.

That would be a good thing to keep it up to date, it exists here : https://github.com/TelescopeJS/Telescope/blob/master/History.md


input integer #define-s should be changed to enum-s

... this is mostly a style enhancement which would ease auto-generated documentation by grouping related parameters within a defined enum and provide better support for code-completion in an IDE.
for example:
#define EN_CVPIPE       0
#define EN_PIPE         1
#define EN_PUMP         2
#define EN_PRV          3
#define EN_PSV          4
#define EN_PBV          5
#define EN_FCV          6
#define EN_TCV          7
#define EN_GPV          8

should be converted to:
typedef enum {
  EN_CVPIPE       = 0,
  EN_PIPE         = 1,
  EN_PUMP         = 2,
  EN_PRV          = 3,
  EN_PSV          = 4,
  EN_PBV          = 5,
  EN_FCV          = 6,
  EN_TCV          = 7,
  EN_GPV          = 8
} EN_LinkType;

Is this in epanet2.h? Would it break backward compatibility for people who uses these parameters?

As long as the enums are set up to correspond to the the existing integer values it should work. Then again this may vary depending on the C dialect. I will look into this issue prior to making any changes.

this ended up being implemented in relation to #33 to ease the documentation of this vocabulary, so i'm closing this to merge into the other issue.


Title: merklemap-cli search "example.com" not working

When running the command merklemap-cli search example.com, it fails to return any results or produces an error.
 merklemap-cli search "example.com" or  merklemap-cli search bing.com etc

Error: InvalidContentType("application/json", Response { url: "https://api.merklemap.com/search?query=example.com&stream=true&stream_progress=true", status: 200, headers: {"date": "Thu, 07 Nov 2024 08:23:44 GMT", "content-type": "application/json", "transfer-encoding": "chunked", "connection": "keep-alive", "access-control-allow-origin": "*", "vary": "origin, access-control-request-method, access-control-request-headers", "vary": "accept-encoding", "cf-cache-status": "DYNAMIC", "report-to": "{\"endpoints\":[{\"url\":\"https:\/\/a.nel.cloudflare.com\/report\/v4?s=6VbNUES9itcqIbbESsYgYO0Yj5LBC3rQygx74YYdpJcHIk70RHD9qbObBPwN8xrm4rWONUPrQGRhxIP0Vx6E9gv75jeSDoGqwXFIPf8OMogplz6ihs68gjLTD61cP8EHSBFN\"}],\"group\":\"cf-nel\",\"max_age\":604800}", "nel": "{\"success_fraction\":0,\"report_to\":\"cf-nel\",\"max_age\":604800}", "x-content-type-options": "nosniff", "server": "cloudflare", "cf-ray": "8debec4058ade1fc-MRS", "alt-svc": "h3=\":443\"; ma=86400", "server-timing": "cfL4;desc=\"?proto=TCP&rtt=140140&sent=5&recv=6&lost=0&retrans=0&sent_bytes=2830&recv_bytes=776&delivery_rate=29422&cwnd=249&unsent_bytes=0&cid=10a210a8f92a5748&ts=1040&x=0\""} })

It's a cloudflare issue. It's blocking the request for some reason. I've tried modifying the code, tried different user agents. Sometimes it works other times it does not. Cloudflare is blocking for some reason. it works fine with curl, so probably a request headers issue.

The issue is the content type it seems. I have the same issue.

any update?


The navigator of the document is broken.

Page: https://microsoft.github.io/language-server-protocol/specification
The link in the navigator on the right of the page refer to #diagnostics-side, this is a wrong link.
Actually it's #diagnostics.

@vincentdchan this is done by the side generator. The Diagnostics entry is actually not navigatable since clicking on it expands / collapse the note. I do set the right anchor though (see https://github.com/microsoft/language-server-protocol/blob/539c919cbc3b2d8c5c9e08ab27d883a6772c3d80/_data/specification-3-16-toc.yml#L158).
I am not a deep expert of bootstrap. So I don't know if this can be changed. Does anyone else know?

I think the anchor field should be diagnostics-side?
What side generator are you using?

The default GitHub which is Jekyll together with bootstrap.

I will close the issue since this got addressed with the restructuring of the documents.


Add test file exclude pattern

Example:
When you would like to run tests only from spec/features directory then run:
KNAPSACK_PRO_TEST_SUITE_TOKEN_RSPEC=$API_TOKEN_FOR_FEATURE_TESTS \
KNAPSACK_PRO_TEST_DIR=spec \
KNAPSACK_PRO_TEST_FILE_PATTERN="spec/features/**{,/*/**}/*_spec.rb" \
bundle exec rake knapsack_pro:queue:rspec

Problem:
What if you would like to run all tests except the spec/features directory?
We could use KNAPSACK_PRO_TEST_FILE_PATTERN and use a pattern that works with Dir.glob but sometimes it's hard to exclude something.
For now users have to specify all directories they want to run tests from.
https://github.com/KnapsackPro/knapsack_pro-ruby#how-to-run-only-rspec-feature-tests-or-non-feature-tests
Idea (todo):
We could add new variable KNAPSACK_PRO_TEST_FILE_EXCLUDE_PATTERN
and then you could do this:
files = Dir.glob(KNAPSACK_PRO_TEST_FILE_PATTERN)
files -= Dir.glob(KNAPSACK_PRO_TEST_FILE_EXCLUDE_PATTERN)

This issue is related: https://github.com/KnapsackPro/knapsack_pro-ruby/issues/57

I added exclude pattern in this PR https://github.com/KnapsackPro/knapsack_pro-ruby/pull/72 and I've just released a new version of knapsack_pro gem.
Here is documentation for exclude pattern:
https://github.com/KnapsackPro/knapsack_pro-ruby#how-to-exclude-tests-from-running-them


NaNs in FS2 posnet

So i've trained Fastespeech2 on my dataset using phones based on MFA extraction (pull request incoming later tomorrow).
But I meet weird NaNs in eval postnet after ~50k steps postnet is only producing nans.
I'm not an expert using tensorflow (last 2.5 years i've use mainly pytorch) so I have question if it is possible that it's caused by fp16 training [later i'll train fp32 model to confirm this but it needs a lot more time] and how to do training more stable on fp16 (maybe some tricks how to debug nans in tensorflow)?

@machineko mixed precision is still on experimental module of tensorflow so it is not stable yet. In my case it ălways fine in my private dataset and ljspeech. If you get nan, you can training float32, the training speed is still very fast even it is float32. You just need < 1 day to train fastspeech. But if you still want to use float16, you can try this trick: resume training float32 at the step you get nan for around 5k steps. Then resume again with float16 :))

Same problem #125 with tacotron2 training at 53.5k steps (1080ti, tensorflow 2.2). Restart training from 50k solved my problem so far.

Sure I'll try both of ur solutions later and post updates here :)

It's looks like fp16 stability turning off and retraining on 32precision didn't have any nans problem. (probably we can fix it excluding some layers from fp16 training and i'll test it in next week)


Is SyncCopyToCPU really thread-safe？

In mxnet::NDArray::SyncCopyToCPU, it calls WaitToRead at first and then do the copy. However, I was just wondering whether the src data would be changed during the copy. Because there is no mechanism to prevent src from being changed by other operation which may be pushed into
engine and executed after the call of WaitToRead.

if the code is only issued from a single python script, it is fine, because all the write ops before wait to read is issued, and the followups write won't issue until synccopy  finish

thx, if the assumption is true, this explanation sounds reasonable. : )

This issue is closed due to lack of activity in the last 90 days. Feel free to ping me to reopen if this is still an active issue. Thanks!


Test case failed occasionally in test/unit/expire.tcl

Search before asking

[X] I had searched in the issues and found no similar issues.

Motivation
Check expire at test case failed occasionally, we should fix it to make the CI happy.
*** [err]: EXPIREAT - Check for EXPIRE alike behavior in tests/unit/expire.tcl
Expected '1[345]' to equal or match '16'
Error: Process completed with exit code 1.

Solution
No response
Are you willing to submit a PR?

[X] I'm willing to submit a PR!

*** [err]: PERSIST can undo an EXPIRE in tests/unit/expire.tcl
Expected '50 1 -1 foo' to equal or match '49 1 -1 foo'

Another failure in expire.tcl: https://github.com/apache/incubator-kvrocks/runs/7450339994?check_suite_focus=true

Thanks @PragmaTwice, also fixed it by add some tolerant range.


PolyLine Gradient

Is it possible to use a gradient as a PolyLine stroke?
I know the gradient line could be achieved using an SVG placed on top of the map, but I'm not sure how I'd line up the map point coordinates with points of the SVG, and then compensate for any zooming/scrolling of the map.
Does anybody have an idea of how this could be achieved?

you can do it by setting the span style (natively)
example on ios using google maps.
-(void)setFillColor:(UIColor *)fillColor
{
  UIColor *color = [UIColor colorWithRed:52.0f/255.0f green:73.0f/255.0f blue:94.0f/255.0f alpha:1.0f];

  UIColor *toColor = [UIColor colorWithRed:255.0f/255.0f green:66.0f/255.0f blue:60.0f/255.0f alpha:1.0f];
  GMSStrokeStyle *style = [GMSStrokeStyle gradientFromColor:color toColor:toColor];

  _fillColor = color;
  _polyline.spans = @[[GMSStyleSpan spanWithStyle:style]];
}

gives you

Note: The colors from above snippet should be passed around from js bridge. And the span will overrides the stroke color.

I've done some work on it but never gotten around to finish it:
https://github.com/IjzerenHein/react-native-maps/tree/feature-gradientpolyline3

Just added the PR for this on iOS/MapKit: #1911


upgrade pillow to 2.7.0

https://www.djangoproject.com/weblog/2015/jan/02/pillow-security-release/

I restarted this on travis to see if it was intermittent

It's not, there must have been some API change that I'll have to investigate. It was worth a try ;)

I believe I have a fix now

r+


[DS-3469] added context and item.gethandle to vscan call to curate

This PR is as yet untested, but it does compile correctly. Will test today.


Tasks Checklist

[x] Upload pdf
[x] Convert pdf to text
[x] Apply NLP to the text extracted.
[ ] Use the text generated after applying NLP in the API
[ ] Query the API
[ ] Visualise the API data received
[ ] Display top 5 matched links

@sidntrivedi012  @code-monk08
25 credits / month
6,250 words / month
2 concurrent scans
Low priority

Thats what the copy leaks free plan says. What does concurrent scans means ? And is it we have only 2 scans possible ? I have made an account on it and will continue at night . Going Shipra now. @sidntrivedi012 Please verify it with our senior project you found and clear my query.

Ok @nightwarrior-xxx . Checking it .

NLP script currently removes unnecessary punctuation from source text,
Tokenizes the source text to sentences,
makes a new file which contains clean and upper case text making it easier for further comparison with string algorithms.

I was also exploring string based algorithms through out the day, finding common strings between source and target text files is not as straight forward.
the project which I found uses Bloom Filters, Aho-Corasick Algorithm for Pattern Searching, Rabin Karp all together.
I am currently understanding Aho-Corasick Algorithm, it is based on automata theory, then finally I will move to Rabin Karp, will push the python scripts for the same by midnight maybe, after which we will get head start for last task in the task list.


no scroll bar on inspect window

As shown in image, I cant inspect more data without scroll bar. Tested on Firefox 54.0.1(64bit).

dup of #355


Setting menu disappears on reload

The following code I have added to my start passage:
<<script>>
	var settingFontSize = function () {
		var emSize = (settings.fontSize/100).toString();
		document.getElementById("passages").style.fontSize = emSize+"em";
	};
	Setting.addHeader("");
	Setting.addRange("fontSize", {
		label    : "Font size",
		min      : 100,
		max      : 200,
		step     : 5,
		default  : 100,
		onInit   : settingFontSize,
		onChange : settingFontSize
	});
	Setting.addToggle("playSound", {
		label    : "Play music?",
		default  : false
	});
	Setting.save();
<</script>>

Starting a new game the setting dialog works like expected. But after reloading the game (reload the window on browser or close and open the html file) or after resetting the values (with the default reset button on setting dialog) the setting button disappears from the menu.

That is expected behavior. If your start passage doesn't run, neither does that code. It should be in story JavaScript. If you absolutely insist on having it in a passage, use StoryInit.

That's it! Thank you. I hadn't thought of that the Setting setup would be temporary on the Start passage.


Intellisense suggestions for string literal type.

Would be great if CTRL+Space (or whatever your hotkey is for show suggestions) would show all the literal string options available for string literals.
In my case I have an <Icon> React component which takes an icon key as one of its props, and I want to limit the options that can be chosen. The string literals work great. Unfortunately because of the number of icons it's somewhat difficult to know what your options are and the intellisense is next to useless in this case because you get basically the first 3 or 4 options in the description, but nothing more. Being able to invoke suggestions and get the list would be a huge help.

Thanks for filing, but this is a duplicate of #606.


Native component for "BlurView" does not exist on android

Hi!
I think I've installed the package as the documentation says but get with the warning.
Add the following to your android/build.gradle :
allprojects {
    repositories {
        maven { url "https://github.com/500px/500px-android-blur/raw/master/releases/" }
        mavenLocal()
        jcenter()
        maven {
            // All of React Native (JS, Obj-C sources, Android binaries) is installed from npm
            url "$rootDir/../node_modules/react-native/android"
        }
    }
}

And to
android/app/build.gradle :
dependencies {
    compile project(':bugsnag-react-native')
    compile project(':react-native-linear-gradient')
    compile project(':react-native-picker')
    compile project(':react-native-blur')
    compile project(':react-native-fbsdk')
    compile project(':react-native-video')
    compile project(':react-native-vector-icons')
    compile project(':react-native-maps')
    compile "com.fivehundredpx:blurringview:1.0.0"
    compile fileTree(dir: "libs", include: ["*.jar"])
    compile "com.android.support:appcompat-v7:23.0.1"
    compile "com.facebook.react:react-native:+"  // From node_modules
}

Did I make a mistake somewhere?
I've seen this issue https://github.com/react-native-community/react-native-blur/issues/156 but not sure is it related or not.

Hi @ivan133, apparently react-native-blur is not working on Android anymore. I think we just have to wait for an Android developer to fix the issue and push a new version.

Could you tell me if there is some other libs or methods for Android? Can't find anything

I've actually been diving into the source code and I think I might have figured out how to fix it. I will let you know if I get something working

Oh, it would be great! It seems that this lib is the last one which can support android blur in nearest future. Thanks!

I pushed a fix: #173
You can try it out now by adding this to your package.json:
"react-native-blur": "ndbroadbent/react-native-blur#android-fix",

And make sure you follow the instructions I added to the README. You have to update the Gradle version, and add "renderscript" lines.

Thank your answers! But i cant get it working( I did all the steps from your readme file

Hi @bintoll, could you please update to the latest version from Github, and try again?
You can add this to your package.json:
...
"react-native-blur": "react-native-community/react-native-blur",
...

and run npm install.

Please, try<EMAIL_ADDRESS>


Fast scrolling up and down crashes the app for large ListView with embedded png files

Android.txt
iOS.txt
Please see http://forums.xamarin.com/discussion/59431/ffimageloading-does-not-display-images-properly#latest

Thanks @adrianknight89
It was an issue with Streams used in lists: while scrolling fast a task was cancelled but the TaskCancelledException wasn't catched


MIxS core geo_loc_nam - alignment with INSDC specification

Current term details
Looks like we have, at some point, diverged in the formatting of this term, from the INSDC
geo_loc_nam is current (MIxS 5.0)
Expected Value:
country or sea name (INSDC or GAZ);region(GAZ);specific location name
value syntax: {term};{term};{text}
It should be colon, then comma, not semicolons to separate Country:region, specific location
as outlined here:
country="<country_value>[:][, ]"
INSDC: http://www.insdc.org/files/feature_table.html#3.4
Term name -
Term ID - [if known]
Structured comment name -
Definition -
Expected value -
Value syntax -
Example -
Preferred unit -
Package(s) -

**Suggested update(s)**
Please supply the new suggestions for any of the details listed below (only insert text to those details that should be updated):

Term name -
Structured comment name -
Definition -
Expected value -
Value syntax -
Example -
Preferred unit -
Package(s) -

**Additional context**
Add any other context about the update request here, e.g. why you think this needs to be updated.

https://www.ncbi.nlm.nih.gov/genbank/collab/country/

suggested update for MIxS v6:
Term name = geo_loc_name
Term ID = MIXS:0000010
Structured comment name = geographic location (country and/or sea,region)
Definition = The geographical origin of the sample as defined by the country or sea name followed by a specific region and/or a location name. Country or sea names should be chosen from the INSDC country list (http://insdc.org/country.html), or the GAZ ontology (v 1.512) (http://purl.bioontology.org/ontology/GAZ)
Expected value = SeaOrCountry:Region, Specific location
Value syntax = {text}:{text}, {text}
Example = Belgium:Ghent, Bourgoyen nature reserve
Preferred unit = none
Package(s) = MIxS Core

geo_loc_name has been updated across core and checklists.
I did remove the version of GAZ, as it is out of date and we are working on a new version currently.
Cheers,
Lynn


Expired Subscription State

Task/Issue URL: https://app.asana.com/0/1205648422731273/1207313382804224/f
Description

Show expired subscription state in settings.
Allow purchasing subscription when in expired state.

Steps to test this PR
See task.
UI changes

Before
After

!(Upload before screenshot)
(Upload after screenshot)

#4548  👈
develop

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @lmac012 and the rest of your teammates on  Graphite


Don't rely on global trace.ApplyConfig in tests

Some tests are relying on previous tests changing the global sampler
leading to random failures when tests are run in isolation.
Set an explicit sampler rather than relying on globals.

Please fix the build.


Responsiveness of the website

The website breaks at a few dimensions.
Dimension: 280 x 653

Dimension: 360 x 640

I can solve the issue if needed. If yes, then do assign me 😃

I will read this through properly and reply in around half an hour.

Just got back! Hi 👋! I am looking into this and fixing it right now. I'll link the pull request and fix it within the hour.

@karishmashuklaa @Harry-Hopkinson
I have recently pushed to a  branch called improve-styles-responsiveness,  and it won't render on my side. Can someone check this?

@karishmashuklaa if you are up for completing this, please do!

@Password-Classified Yes sure! I will start working on it and make a PR ASAP

Thanks!

This is GREAT!!!!!!!! Thanks so much.
Is it possible that the 3 links in the nav could be centered (except the Neuron AI title)

@Password-Classified Yes they can be but I personally feel it is always better to either push them to left or right(except the title) for better responsive behavior. But I will change it ASAP 👍

Thanks so much!

Has the center title been done yet?

We can probably leave the center title. It actually looks better how it is.


Fix the swift-inspect build on Darwin.

We had a few typos and such from the recent reorganization.
Same as https://github.com/apple/swift/pull/41619 except pulling from my fork.

@swift-ci please smoke test


CMD_DAP_SWJ_CLOCK failed / DAP init failed

Hi,
Something goes wrong for SWD programming.
It's seems that the DAPLink is not working as expected.
OS : Ubuntu 20.04 (64bits)
The installation was done as specified on the github page (ie compiling openocd from the raspberry repository).
I tried with 2 different USB cables, and on USB2 and USB3 ports, same results...
So, having only the Pico-PMOD-ExtBoard plugged :
dap_flash_write.sh /opt/pico/pico-examples/blink/blink.bin
EXT: bin
Open On-Chip Debugger 0.10.0+dev-g18b4c35-dirty (2021-09-30-17:31)
Licensed under GNU GPL v2
For bug reports, read
	http://openocd.org/doc/doxygen/bugs.html
swd
Info : Hardware thread awareness created
Info : Hardware thread awareness created
Info : RP2040 Flash Bank Command
Info : CMSIS-DAP: SWD  Supported
Info : CMSIS-DAP: FW Version = 0256
Info : CMSIS-DAP: Serial# =<PHONE_NUMBER>430034390000084e50364aa5a5a5a597969908
Info : CMSIS-DAP: Interface Initialised (SWD)
Info : SWCLK/TCK = 1 SWDIO/TMS = 1 TDI = 0 TDO = 0 nTRST = 0 nRESET = 1
Error: CMSIS-DAP command CMD_DAP_SWJ_CLOCK failed.

I tried to add "transport select swd" and "adapter speed 5000" in the cmsis-dap.cfg file,
it fails with
Open On-Chip Debugger 0.10.0+dev-g18b4c35-dirty (2021-09-30-17:31)
Licensed under GNU GPL v2
For bug reports, read
	http://openocd.org/doc/doxygen/bugs.html
adapter speed: 5000 kHz

Info : Hardware thread awareness created
Info : Hardware thread awareness created
Info : RP2040 Flash Bank Command
Info : CMSIS-DAP: SWD  Supported
Info : CMSIS-DAP: FW Version = 0256
Info : CMSIS-DAP: Serial# =<PHONE_NUMBER>430034390000084e50364aa5a5a5a597969908
Info : CMSIS-DAP: Interface Initialised (SWD)
Info : SWCLK/TCK = 1 SWDIO/TMS = 1 TDI = 0 TDO = 0 nTRST = 0 nRESET = 1
Info : CMSIS-DAP: Interface ready
Info : clock speed 5000 kHz
Error: Sequence 4 not supported
Info : DAP init failed

Running openocd in debug mode gives more interesting information :
Debug: 347 277 arm_dap.c:116 dap_init_all(): Initializing all DAPs ...
Error: 348 309 cmsis_dap_usb.c:935 cmsis_dap_swd_switch_seq(): Sequence 4 not supported
Debug: 349 341 cmsis_dap_usb.c:920 cmsis_dap_swd_switch_seq(): SWD line reset
Debug: 350 389 cmsis_dap_usb.c:728 cmsis_dap_swd_read_process(): SWD ack not OK @ 0 JUNK
Debug: 351 389 adi_v5_swd.c:655 swd_multidrop_select_target(): Failed to select core 0, retrying...
Debug: 352 421 cmsis_dap_usb.c:920 cmsis_dap_swd_switch_seq(): SWD line reset
Debug: 353 469 cmsis_dap_usb.c:728 cmsis_dap_swd_read_process(): SWD ack not OK @ 0 JUNK
Debug: 354 469 adi_v5_swd.c:655 swd_multidrop_select_target(): Failed to select core 0, retrying...
Debug: 355 501 cmsis_dap_usb.c:920 cmsis_dap_swd_switch_seq(): SWD line reset
Debug: 356 549 cmsis_dap_usb.c:728 cmsis_dap_swd_read_process(): SWD ack not OK @ 0 JUNK
Debug: 357 549 adi_v5_swd.c:655 swd_multidrop_select_target(): Failed to select core 0
Info : 358 549 arm_dap.c:337 handle_dap_init(): DAP init failed

Any idea is welcome.
Thanks.

hello, have you tried another pico, the first log seems that the e Pico-PMOD-ExtBoard is good, but it didn't detect the pico (rp2040)

and do you have another MCU board, this Pico-PMOD-ExtBoard can also debug other ARM Cortex-M series MCU,  please reference
here https://github.com/wuxx/openocd-toolbox

Luckily, I have 5 rpi pico and 3 Pico-PMOD-ExtBoard, so I tried with a new pico and a new board.
Same behaviour... :(

I looked at the signals with a logic analyzer, I see activity on SWDIO and SWCLK but I'm not able to decode them.

Using a rpi pico with picoprobe, openocd was able to flash the pico with the WSD protocol.
IMHO, there is a bug in the firmware of the Pico-PMOD-ExtBoard.

eh... lots board already shipped with this firmware... strange..

have you tried the Pico-PMOD-ExtBoard. with some MCUs like STM32 and others..

don't know what logic analyzer you use,  but if you use fx2lafw based logic analyzer https://github.com/wuxx/nanoDLA the pulseview support SWD protocol

I use an AnalogDiscovery2.
Here is the capture that you can view/load/export with their (free) WaveForms software
(https://mautic.digilentinc.com/waveforms-download)
=> capture :    https://www.openconcerto.org/swd.dwf3logicacq
I have no STM32 card or nanoDLA to go further.
From my tests, all I can say is

my 5 rpi pico are working fine
swd works with a picoprobe
all the 3 Pico-PMOD-ExtBoard have the same issue.

Hello, here is my local test, everything is well.
tested on raspberry pi, the detail log is here
`
pi@raspberrypi:~/oss/pico/pico-lab $ cd tools/
pi@raspberrypi:~/oss/pico/pico-lab/tools $ ls
dap_attach.sh      dap_flash_write.sh  dfw     env.sh  rpi_attach.sh      rpi_flash_write.sh  rreset
dap_flash_dump.sh  dap_reset.sh        dreset  rfw     rpi_flash_dump.sh  rpi_reset.sh
pi@raspberrypi:~/oss/pico/pico-lab/tools $ source env.sh
pi@raspberrypi:~/oss/pico/pico-lab/tools $ cd ..
pi@raspberrypi:~/oss/pico/pico-lab $ ls
demo  doc  firmware  LICENSE  README_cn.md  README.md  software  tools
pi@raspberrypi:~/oss/pico/pico-lab $ cd demo/
pi@raspberrypi:~/oss/pico/pico-lab/demo $ ls
blink.bin  breakout_board         hello_serial_io01.uf2    hello_serial_io1617.uf2  pico_ws2812.uf2
blink.uf2  hello_serial_io01.bin  hello_serial_io1617.bin  pico_ws2812.bin          vgademo_board
pi@raspberrypi:~/oss/pico/pico-lab/demo $ dfw blink.bin
EXT: bin
Open On-Chip Debugger 0.10.0+dev-g7c96119-dirty (2021-02-03-19:20)
Licensed under GNU GPL v2
For bug reports, read
http://openocd.org/doc/doxygen/bugs.html
adapter speed: 10000 kHz
Info : Hardware thread awareness created
Info : Hardware thread awareness created
Info : RP2040 Flash Bank Command
Info : CMSIS-DAP: SWD  Supported
Info : CMSIS-DAP: FW Version = 0256
Info : CMSIS-DAP: Serial# =<PHONE_NUMBER>4200354b0000144e4d3434a5a5a5a597969908
Info : CMSIS-DAP: Interface Initialised (SWD)
Info : SWCLK/TCK = 1 SWDIO/TMS = 1 TDI = 0 TDO = 0 nTRST = 0 nRESET = 1
Info : CMSIS-DAP: Interface ready
Info : High speed (adapter speed 10000) may be limited by adapter firmware.
Info : clock speed 10000 kHz
Info : SWD DPIDR 0x0bc12477
Info : SWD DLPIDR 0x00000001
Info : SWD DPIDR 0x0bc12477
Info : SWD DLPIDR 0x10000001
Info : rp2040.core0: hardware has 4 breakpoints, 2 watchpoints
Info : rp2040.core1: hardware has 4 breakpoints, 2 watchpoints
Info : starting gdb server for rp2040.core0 on 3333
Info : Listening on port 3333 for gdb connections
target halted due to debug-request, current mode: Thread
xPSR: 0xf1000000 pc: 0x000000ee msp: 0x20041f00
target halted due to debug-request, current mode: Thread
xPSR: 0xf1000000 pc: 0x000000ee msp: 0x20041f00
Info : RP2040 B0 Flash Probe: 2097152 bytes @10000000, in 512 sectors
target halted due to debug-request, current mode: Thread
xPSR: 0x01000000 pc: 0x00000178 msp: 0x20041f00
target halted due to debug-request, current mode: Thread
xPSR: 0x01000000 pc: 0x00000178 msp: 0x20041f00
target halted due to debug-request, current mode: Thread
xPSR: 0x01000000 pc: 0x00000178 msp: 0x20041f00
Info : Writing 16384 bytes starting at 0x0
target halted due to debug-request, current mode: Thread
xPSR: 0x01000000 pc: 0x00000178 msp: 0x20041f00
target halted due to debug-request, current mode: Thread
xPSR: 0x01000000 pc: 0x00000178 msp: 0x20041f00
target halted due to debug-request, current mode: Thread
xPSR: 0x01000000 pc: 0x00000178 msp: 0x20041f00
shutdown command invoked
pi@raspberrypi:~/oss/pico/pico-lab/demo $
`

how I connect

and notice the script dap_flash_write.sh assume you has opneocd installed under /home/pi/oss/pico/openocd, maybe you need to modify the path in dap_flash_write.sh

Interesting!
The differences I see :

OS : [you] Rapsbian (32bits?)    [me] Ubuntu 20.04 x64
hardware : [you] raspberry Pi (v?)   [me] standard x64 PC
software : [you] openocd from february   [me] september
configuration : [you] 10 000 KHz, wich is nowhere in cmsis-dap.cfg openocd config   [me] 5000 KHz I added in cmsis-dap.cfg

I try to add adapter speed 10000 in cmsis-dap.cfg, but that's not solving the problem.
(of course, dap_flash_write.sh was modified to point to my install folder)
So it could be a problem on the cmsis-dap driver on x64 provided by raspberri
via git clone https://github.com/raspberrypi/openocd.git --recursive --branch rp2040 --depth=1

yes, it's Raspbian on raspberrypi 3B+,  I will also try it on my x64 ubuntu, please wait for a while.

also try on my x64 ubuntu, it's still ok, openocd (https://github.com/raspberrypi/openocd.git) commit id is 7c96119
detail log
wuxx@ubuntu:~/oss/pico/pico-lab/demo$ uname -a
Linux ubuntu 4.4.0-173-generic #203-Ubuntu SMP Wed Jan 15 02:55:01 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
wuxx@ubuntu:~/oss/pico/pico-lab/demo$ dfw blink.bin
EXT: bin
Open On-Chip Debugger 0.10.0+dev-g7c96119-dirty (2021-10-04-19:26)
Licensed under GNU GPL v2
For bug reports, read
        http://openocd.org/doc/doxygen/bugs.html
adapter speed: 10000 kHz

Info : Hardware thread awareness created
Info : Hardware thread awareness created
Info : RP2040 Flash Bank Command
Info : CMSIS-DAP: SWD  Supported
Info : CMSIS-DAP: FW Version = 0256
Info : CMSIS-DAP: Serial# =<PHONE_NUMBER>4200354b0000144e4d3434a5a5a5a597969908
Info : CMSIS-DAP: Interface Initialised (SWD)
Info : SWCLK/TCK = 1 SWDIO/TMS = 1 TDI = 0 TDO = 0 nTRST = 0 nRESET = 1
Info : CMSIS-DAP: Interface ready
Info : High speed (adapter speed 10000) may be limited by adapter firmware.
Info : clock speed 10000 kHz
Info : SWD DPIDR 0x0bc12477
Info : SWD DLPIDR 0x00000001
Info : SWD DPIDR 0x0bc12477
Info : SWD DLPIDR 0x10000001
Info : rp2040.core0: hardware has 4 breakpoints, 2 watchpoints
Info : rp2040.core1: hardware has 4 breakpoints, 2 watchpoints
Info : starting gdb server for rp2040.core0 on 3333
Info : Listening on port 3333 for gdb connections
target halted due to debug-request, current mode: Thread
xPSR: 0xf1000000 pc: 0x000000ee msp: 0x20041f00
target halted due to debug-request, current mode: Thread
xPSR: 0xf1000000 pc: 0x000000ee msp: 0x20041f00
Info : RP2040 B0 Flash Probe: 2097152 bytes @10000000, in 512 sectors

target halted due to debug-request, current mode: Thread
xPSR: 0x01000000 pc: 0x00000178 msp: 0x20041f00
target halted due to debug-request, current mode: Thread
xPSR: 0x01000000 pc: 0x00000178 msp: 0x20041f00
target halted due to debug-request, current mode: Thread
xPSR: 0x01000000 pc: 0x00000178 msp: 0x20041f00
Info : Writing 16384 bytes starting at 0x0
target halted due to debug-request, current mode: Thread
xPSR: 0x01000000 pc: 0x00000178 msp: 0x20041f00
target halted due to debug-request, current mode: Thread
xPSR: 0x01000000 pc: 0x00000178 msp: 0x20041f00
target halted due to debug-request, current mode: Thread
xPSR: 0x01000000 pc: 0x00000178 msp: 0x20041f00
shutdown command invoked
wuxx@ubuntu:~/oss/pico/pico-lab/demo$

the source code of debugger is here https://github.com/ARMmbed/DAPLink , already used with many boards, my experience is pretty stable.

Hah!  Looked this over, found a blog that went on an on about checking the wiring.  .... It was the wiring for me.  Maybe for you too?  A loose dupont connector on ground.

Mac mini and PicoProbe v.1.0.2 needed adapter speed 1000 (but also seems to work with anything up to 5000).
Instead of modifying tcl/interface/cmsis-dap.cfg it might be better to use OpenOCDLaunchCommands in your .vscode/launch.json:
{
    "version": "0.2.0",
    "configurations": [
        {
            ... other commands ...
            "openOCDLaunchCommands": [
                "adapter speed 3000"
            ],
            ... other commands ...
          }
    ]
}


Please merge the pull requests!

There are currently 21 pull requests that pass checks, provided by various contributors, and I need the functionality of some of them (TextBuffer additions) in my project. Please be so kind and review them, merge them into the repo, or close them for a reason.
Incomplete list:
https://github.com/gotk3/gotk3/pull/431
https://github.com/gotk3/gotk3/pull/430
https://github.com/gotk3/gotk3/pull/429
https://github.com/gotk3/gotk3/pull/428
https://github.com/gotk3/gotk3/pull/427
https://github.com/gotk3/gotk3/pull/426
https://github.com/gotk3/gotk3/pull/425
https://github.com/gotk3/gotk3/pull/423
https://github.com/gotk3/gotk3/pull/422
https://github.com/gotk3/gotk3/pull/421
https://github.com/gotk3/gotk3/pull/418
https://github.com/gotk3/gotk3/pull/416
https://github.com/gotk3/gotk3/pull/413
https://github.com/gotk3/gotk3/pull/412
https://github.com/gotk3/gotk3/pull/411
https://github.com/gotk3/gotk3/pull/410
https://github.com/gotk3/gotk3/pull/409
https://github.com/gotk3/gotk3/pull/408
https://github.com/gotk3/gotk3/pull/407
https://github.com/gotk3/gotk3/pull/406
https://github.com/gotk3/gotk3/pull/400

Hello @rasteric,
i have reviewed many pull requests and merged them. But three changes has no little git conflicts and therefore these remain open for the time being

Thank you so much!


WARNING: DraftEntity.get will be deprecated soon! Please use "contentState.getEntity" instead.

Related to https://github.com/sstur/draft-js-import-element/issues/31
This should be an easy fix.

I can start work on this - is this project still being maintained?

Just created a PR for the fix

Doesn't seem to be any activity on this repo in a while.. is it unmaintained? Is there an active fork anywhere?

Perhaps: https://github.com/jpuri/draftjs-to-html


Add support for command HINCRBYFLOAT

Add support for the HINCRBYFLOAT command in DiceDB similar to the HINCRBYFLOAT command in Redis. Please refer to the following commit in Redis to understand the implementation specifics - source.
Write unit and integration tests for the command referring to the tests written in the Redis codebase 7.2.5. For integration tests, you can refer to the tests folder. Note: they have used TCL for the test suite, and we need to port that to our way of writing integration tests using the relevant helper methods. Please refer to our tests directory.
For the command, benchmark the code and measure the time taken and memory allocs using benchmem and try to keep them to the bare minimum.

Can I take this issue @arpitbbhayani @JyotinderSingh

Can I take this issue @arpitbbhayani @JyotinderSingh

Assigned

@arpitbbhayani Can I pick this issue?

I am posting this comment to update the status of this issue. I have implemented the basic functionality and am currently writing tests for this command. I will raise the PR in a couple of days. Thanks!


Add invariant IFormatterProvider to avoid issues based on user locale

Code analytics raised CA1305, this PR fixes the potential user locale issue by:

Adds CultureInfo.InvariantCulture for locale insensitive "ToString"
string.Format handles null so removed that assignment

@devlead is there a reason to have the string Format broken out into a seperate const?
If not, if we are in this file making changes anyway, why not combine it into a single line?

@gep13 nothing more than readability I guess, tried to change as little as possible in the existing code.

@gep13 Yeah, it's for readability. Don't like too long lines and it's a const so the compiler will merge it :smile:

@patriksvensson @devlead gotcha.  no worries, just thought I would ask.  Having to mind switch between two ways of doing things, as another project, who shall rename nameless, works slightly differently :smile:

Looks good to me. Rebase against develop and I'll merge it :+1:

@patriksvensson Rebased.


Model Output Explanation Needed

Original Model - https://github.com/datakalp/RetinaFace-Cpp/tree/master/convert_models/mnet
I used the caffe weights to convert this model to openvino format. The input size is [640,640,3]
Code used :
`import os
import cv2
import numpy as np
try:
    from openvino import inference_engine as ie
    from openvino.inference_engine import IENetwork, IEPlugin
except Exception as e:
    exception_type = type(e).__name__
    print("The following error happened while importing Python API module:\n[ {} ] {}".format(exception_type, e))
    sys.exit(1)

# Plugin initialization for specified device and load extensions library if specified.
plugin_dir = None
model_xml = '/home/datakalp-tanmay/Desktop/retinaface-openvino/mnet.xml'
model_bin = '/home/datakalp-tanmay/Desktop/retinaface-openvino/mnet.bin'
# Devices: GPU (intel), CPU, MYRIAD
plugin = IEPlugin("CPU", plugin_dirs=plugin_dir)
# Read IR
net = IENetwork.from_ir(model=model_xml, weights=model_bin)
assert len(net.inputs.keys()) == 1
#assert len(net.outputs) == 1
input_blob = next(iter(net.inputs))
out_blob = next(iter(net.outputs))
# Load network to the plugin
exec_net = plugin.load(network=net)
del net

# Run inference
fileName = '/home/datakalp-tanmay/Desktop/elevate/face.jpeg'
img = cv2.imread(fileName)
img = cv2.resize(img , (640,640) , interpolation = cv2.INTER_AREA)
img = img.transpose(2,0,1)
res = exec_net.infer(inputs={input_blob: img})
print(res)`

res has the following keys :
face_rpn_bbox_pred_stride16
face_rpn_bbox_pred_stride32
face_rpn_bbox_pred_stride8
face_rpn_cls_prob_reshape_stride16
face_rpn_cls_prob_reshape_stride32
face_rpn_cls_prob_reshape_stride8
face_rpn_landmark_pred_stride16
face_rpn_landmark_pred_stride32
face_rpn_landmark_pred_stride8
With various shapes. I want to find the key that will give me the face bounding box and correspoding face landmarks.
Please ask for any further details that are required.

following keys

They are model specific.
All of these are come from the used model. See here:
https://github.com/datakalp/RetinaFace-Cpp/blob/master/convert_models/mnet/mnet.prototxt

I want to find the key that will give me the face bounding box and correspoding face landmarks

IMHO,
You should ask author of the model (or find/read related article or sample code) how to interpret their results.

@tanmay-bhatnagar , as I can see (using graph visualization tools like netron or netscope) there is no difference between outputs described by you in openvino converted model and caffe model which you use (and original mxnet model also), so you better to ask help from model author or inspect code in the repo where you find model, the process of output parsing with openvino should be the same.

@tanmay-bhatnagar you can parse output as it done in https://github.com/deepinsight/insightface/blob/master/RetinaFace/retinaface.py.

@tanmay-bhatnagar  if it is still actual you can find output explanation and postprocessing code (inside accuracy checker) in https://github.com/opencv/open_model_zoo/pull/994

@tanmay-bhatnagar if you have no more questions, we will close this issue in a few days.

Closing as promised.


Update to Node16

Node12 is being deprecated for github actions.
I got the following failure on CI
https://github.com/Shopify/ruby/actions/runs/3716253253
Links here: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/
I haven't tested this. Just figured I'd make the PR with the change as a way of letting you know.

@jimmyhmiller Sorry to late response. I released v3.1.0 with your PR.


Make Button shortcuts triggerable by gamepads

This can be tested in Escape Space by starting the game with a controller connected, entering a submenu then pressing B (Xbox) or Circle (PlayStation) to go back to the main menu.
Please test in your projects if you can :slightly_smiling_face:
This closes #25741.

Thanks!


New name

What about algolia/autocomplete.js with the .aa- CSS prefix? cc @bobylito @pixelastic @vvo

So published as @algolia/autocomplete.js on npm? And algolia/autocomplete.js on jsdelivr? Looks good to me

So published as @algolia/autocomplete.js on npm? And algolia/autocomplete.js on jsdelivr? Looks good to me

Yes


crash when create new world

crash-2024-09-06_20.21.20-client.txt

This is an issue with TFCFlorae, it is not compatible with newer versions of TFC.


fix: updated deps

:tada: This PR is included in version 1.13.155 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Need support for MAUI Blazor

Hi Coud i use this lib for Maui Blazor? Thanks

For blazor I add it in the MainPage.xaml

I have added it like this, but how do I invoke it from a razor component? Thanx

It seem library is called in XAML page not razor page component

see #39 for a hybrid solution


Improve ockam enroll argument --identity (clap command)

Current behavior
The command ockam enroll --identity <IDENTITY_NAME> runs the command with the given identity name. And this is what you see when you run ockam enroll --help.

Desired behavior
The ockam enroll --help command should provide some more information on the --identity flag.
Add a comment to the field describing what it is: /// Run the command as the given identity name.
To make this change take a look at this file. Add a doc comment w/ the text above to the EnrollCommand::identity field.

We love helping new contributors! ❤
If you have questions or need help as you explore, please join us on Discord. If you're looking for other issues to contribute to, please checkout our good first issues.

Hello nazmulidris,
This is my first commit to github in a long time. I hope all is well with what and how  I have pushed back.
Cheers.

@axd99 Hi 👋🏽 Would you like to work on this issue?

@axd99 That's awesome, this is all yours. Please let us know if you have any questions as you explore. You can also ask questions on the contributors discord https://discord.gg/RAbjRr3kds

Hello @nazmulidris,
Thank you for assigning this to me.
Yes, I'd like to work on this.
I created a pull request this morning (#6400)  and I reckon  it provides the fix.
Please let me know if I got that wrong, or anything that needs reworking.
Thank you.

On another note, I've tried to access the contributors discord on the link above, but I get an error message 'Unable to accept invite'. I have raised a ticket with the discord help desk, and they have come back to me (very quickly I must add) confirming that the link is valid but that my IP address must be banned (somehow) and that I should ask the moderator 'to clear all bans in Server Settings > Bans'.
I should then restart my client and try again.
Or it could also be (this is still from the help desk)  with my discord tag being in a black list (in a moderator bot?). I have joined Discord recently and have has very limited activity.
Any chance someone could have a look on your side?


Gyroscope, Magnetometer, and Gravity All Return Zero Vector on Android

Godot version:
3.1.2 Stable (Steam)
3.2 Beta 5
OS/device including version:
Amazon Kindle Fire 7
Lenovo Tab 4
Issue description:
These functions all return Vector3(0, 0, 0):
var grav = Input.get_gravity()
var mag = Input.get_magnetometer()
var gyro = Input.get_gyroscope()

This does still work:
var acc = Input.get_accelerometer()

Steps to reproduce:
Just place the above code in a project and export for Android (you can print the values)
Minimal reproduction project:
Download the "Sensors" demo from the Asset Library. It shows the problem perfectly.

Actually, I tried some apps like CPU-Z and VR Checker, and it seems my devices don't have these sensors. On the Fire tablet it says it only has an accelerometer (no gyro, magnetometer, or compass) and on the Lenovo it says it has no sensors in VR Checker (but CPU-Z reads the accelerometer). Sorry for the confusion.


Correction for raw affiliation Aeres University of Applied Sciences; Wageningen University and Research [Wageningen]

Correction needed for raw affiliation Aeres University of Applied Sciences; Wageningen University and Research [Wageningen]
raw_affiliation_name: Aeres University of Applied Sciences; Wageningen University and Research [Wageningen]
new_rors: 03jnx2c74;04qw24q55
previous_rors: 04qw24q55
works_examples: W2625046260
contact: 601fe0f8e37bb2641a5cd5ae80ca65e3:e2f38ca37a82f5dc @ aeres.nl

This issue was accepted and ingested by the OpenAlex team on 2024-10-10. The new affiliations should be visible within the next 7 days.


Make fieldnorm module public

Necessary for the term-wise index rewriting that I'm currently doing.
Will add documentation to not have warnings from it.

Ok with me as long as the doc is there.


keybase.io: expired cert in chain

keybase.io's cert chain still includes the recently expired Sectigo AddTrust External CA Root, which breaks certain clients (e.g. OpenSSL 1.0.x).
This can be easily checked using https://whatsmychaincert.com/.

Could you check again? We updated the chain. Thanks.

Works now, thanks!


Parent-Child Relationship System

Is your feature request related to a problem? Please describe.
As of now, there does not exist a way to "group" multiple Entities together, such as Meshes of a single Model.
Describe the solution you'd like
Implement Parent-child Relationship system using Components. The whole system would run on a component:
class Relationship
{
public:
    Entity parent;
    std::vector<Entity> children;

    SetParent(Entity parent);
    AddChild(Entity child);
    RemoveChild(Entity child);
};

Here's a sample usage:
Entity parent = scene.CreateEntity();
Entity child = scene.CreateEntity();

scene.Assign<Relationship>(parent).AddChild(child);
// OR Alternative method:
scene.Assign<Relationship>(child).SetParent(parent);```

afaik using vectors would be bad for performance
here is a cache friendly approach provided by creator of entt
https://skypjack.github.io/2019-06-25-ecs-baf-part-4/

Ah, that indeed seems like the better approach of solving this. The Unconstrained model should fit our needs pretty well.
I was finished implementing the before-mentioned hierarchy system using vectors, guess it's time to rewrite before I push haha. Ducktape's been pretty stale in terms of development lately due to my exams so it'll take a month or two before I get back.
Anyway, thanks for pointing it out!


Update chroot-environment-linux.md

@kelleyguiney22 : Thanks for your contribution! The author(s) have been notified to review your proposed change.


[QUESTION] open link

When I insert a link and set isNewWindow to true, the link is still opened on the current page.
controller.insertLink(linkName, linkUrl, true);
How can I open it in Safari?

You can follow the guide at https://github.com/tneotia/html-editor-enhanced/issues/88#issuecomment-878695455, use url_launcher package and return NavigationActionPolicy.PREVENT to open the links :)

When I click on this link, can I jump directly instead of popping up this box?

No unfortunately because the package provides the ability for the user to remove the hyperlink and just keep the google text. Pressing on it once more should open the link.

Thank you for your answers. Unfortunately, I am currently using the stable version of flutter and cannot use 2.2.0+1-dev.1. I look forward to you updating the new version.

Thank you for your answers. Unfortunately, I am currently using the stable version of flutter and cannot use 2.2.0+1-dev.1. I look forward to you updating the new version.

2.2.0 is the same functionality as 2.2.0+1-dev.1 but yes I hope to push a new update soon. Maybe this week or next.

Hi, Can I forbid this behavior? When I click on this link, I don't want it popping up this box and I also don't want to jump.

Hi, Can I forbid this behavior? When I click on this link, I don't want it popping up this box and I also don't want to jump.

Yes you can remove this popup, in the HtmlEditorOptions parameter customOptions please use
"""
popover: {
  image: [
    ['image', ['resizeFull', 'resizeHalf', 'resizeQuarter', 'resizeNone']],
    ['float', ['floatLeft', 'floatRight', 'floatNone']],
    ['remove', ['removeMedia']]
  ],
  link: [],
  table: [
    ['add', ['addRowDown', 'addRowUp', 'addColLeft', 'addColRight']],
    ['delete', ['deleteRow', 'deleteCol', 'deleteTable']],
  ],
},
"""

As you can see in the string we set link: [] which removes the display for the link popup only.

As you can see in the string we set link: [] which removes the display for the link popup only.

Thank you for your reply. Can I only set like this?
"""
popover: {
link: []
},
"""``

If you do like that then the buttons for resizing image on tap will disappear. This syntax is JavaScript syntax so it does not have a default value for every parameter.

OK, Thank you very much.