Issue with PromptDialog.Choice and Facebook

I have my Facebook bot online and I am inspecting all the requests in my server. Sometimes my server is not receiving messages. If I retry and send a message many times, it works. If I use the emulator it works fine.
Example image
I wrote three times "pollo" to get the answer.
Any idea?

hi @yamifr07 - can you provide more details about your issue?
Pre-flight checklist

[ ] I have reviewed the BotBuilder SDK Contribution Guidelines
[ ] I posted a question about this issue on Stack Overflow using the tag #botframework.
[ ] I have asked for help in the Bot Framework Gitter group before filing this issue.
[ ] I have searched the existing issues before logging a new one.

Environment

Operating System:

Windows
macOS
Linux

SDK Platform:

C#/.NET
Node.js

SDK version:
Development environment:

localhost
Azure Web App
Azure Bot Service App
other

If you are using the Node.js SDK:

Node.js version:
NPM version:

Issue
What the issue is, in broad strokes. Link to Stack Overflow post.
Example Code
The code snippet or complete bot example (preferred) that demonstrates the issue.
Steps to Reproduce
Please provide the shortest amount of steps to reproduce your issue.
Expected Behavior
What you expected to happen.
Actual Results
What actually happened. Please give examples and support it with screenshots, copied output or error messages.

Pre-flight checklist
I have reviewed the BotBuilder SDK Contribution Guidelines
x I posted a question about this issue on Stack Overflow using the tag #botframework.
I have asked for help in the Bot Framework Gitter group before filing this issue.
x I have searched the existing issues before logging a new one.
Environment
Operating System:
Windows
macOS
x Linux
SDK Platform:
C#/.NET
x Node.js
SDK version:
Development environment:
x localhost
Azure Web App
Azure Bot Service App
other
If you are using the Node.js SDK:
Node.js version: v6.6.0
NPM version: 3.10.3
Issue
What the issue is, in broad strokes. Link to Stack Overflow post.
StackOverflow
I log everything in my server using morgan and I don't see messages when bot does not reply. The log when it works is: POST /api/messages 202 - [10/Apr/2017:20:03:30 +0000] - - - 1.624
I don't know if that 202 is the problem... When I develop a web, my server sends 200 to requests. But, just the propmts choice are not working fine. The other widgets such as HeroCard are ok.
Example Code
Steps to Reproduce
Answer multiple Prompts choices quickly (reply as soon as you receive the options). Chat displays the answer but is not being received in the server.
Expected Behavior
What you expected to happen.
Receive user messages
Actual Results
What actually happened. Please give examples and support it with screenshots, copied output or error messages.
Must send the message many times to receive it.
Image

I also tried the example code I found in this repository. Same problem... So you can run Microsoft example in Facebook messanger and some message are being ignore. Sometimes it replays ok and sometime doesn't.

So... Any updates. If it doesn't work on Facebook I must use another framework :(

I think this is the same issue I am currently having. Did you check for errors on your botframework login? The errors I am seeing are from the BotFramework showing unauthorized and then authorized and then unauthorized. StackOverflow Here Now it appears to be working but any custom facebook channel data is still experiencing this problem. As a side note, I noticed Facebook released a new version of it's API on April 18th... Coincidence?

Hi @yamifr07 We have just released many updates to the Bot Framework including a complete re-write of the prompts system available in<EMAIL_ADDRESS>NPM module.
Are you still experiencing the issue after upgrading botbuilder to v3.8.x? To upgrade use npm upgrade --save botbuilder.
If you are still having issues after upgrading the botbuilder module, can you post your complete bot code? This will help us debug the issue.

Yes, still having issue. I think it's easy to reproduce but here is my code:
	bot.dialog('/menu', [ 		(session) => { 			builder.Prompts.choice(session, 'Bots disponibles:', 'Horoscope|News', {listStyle: builder.ListStyle.button}); 		}, 		(session, results) => { 			let dialog; 			switch(results.response.index) { 				case 0: 					dialog = 'horoscope'; 					break; 				case 1: 					dialog = 'news'; 					break; 			} 			session.beginDialog('/' + dialog); 		}, 		(session, results) => { 			session.replaceDialog('/menu'); 		} 	]) 	.reloadAction('reloadMenu', null, { matches: /^menu/i });

Hi @yamifr07 ! Have you tried replaceDialog instead of beginDialog to see a change in behaviour?

@chitrang89 yes, same issue.

Error: Request to 'https://state.botframework.com/v3/botstate/facebook/conversations/xxxxxxx-xxxxxxx/users/xxxxxxx' failed: [400] Bad Request

I Have this error if send
builder.Prompts.choice(session, ' ', 'Button1|Button2', {listStyle: builder.ListStyle.button});
with empty or white space message. Is it possible just to show button without preceding message? Emulator and Web Channel allows white space message, fails with empty message however.

please open a new issue if anyone is still facing this problem


Wait 85 seconds to login

Describe the bug
Once you really harden the security of your docker server, the login and registration takes forever (85 seconds) to simply authenticate or register a user.
It also happen when, as admin, you click on About > System, and Plugins.
Container error:
fetch store error FetchError: request to https://store.saltcorn.com/api/packs?fields=name,description failed, reason: getaddrinfo EAI_AGAIN store.saltcorn.com
    at ClientRequest.<anonymous> (/usr/local/lib/node_modules/@saltcorn/cli/node_modules/node-fetch/lib/index.js:1461:11)
    at ClientRequest.emit (node:events:390:28)
    at ClientRequest.emit (node:domain:475:12)
    at TLSSocket.socketErrorListener (node:_http_client:447:9)
    at TLSSocket.emit (node:events:390:28)
    at TLSSocket.emit (node:domain:475:12)
    at emitErrorNT (node:internal/streams/destroy:157:8)
    at emitErrorCloseNT (node:internal/streams/destroy:122:3)
    at processTicksAndRejections (node:internal/process/task_queues:83:21) {
  type: 'system',
  errno: 'EAI_AGAIN',
  code: 'EAI_AGAIN'

My server has limited access to DNS and external websites on purpose. It shouldn't need to check for stuff on saltcorn.com each time a user authenticate. It looks like telemetry.
Additional context
0.7.4-beta.0, may be it's already fixed.

There is definitely no telemetry, but you are right that it is trying to refresh the list of available packs as this is displayed in one of the tabs on the administrators "welcome page" (which is displayed to the administrator if they have not chosen a start page for their role). You can change the URL for the store but of course realistically you are only going to get to that once you have gone through the "admin welcome page"
I agree we should do something about this. The simplest would probably be to replace the list of available packs with a link to /plugins?set=packs. Then we should make it easier to disable the module store by setting store endpoint to blank

I agree we should do something about this. The simplest would probably be to replace the list of available packs with a link to /plugins?set=packs. Then we should make it easier to disable the module store by setting store endpoint to blank

Thank you @glutamate, I agree.
Once the webservice is ready for production, store shouldn't need to update except if we visit the plugin section.
You provided a solution so feel free to close this one.

Fixed the packs fetch. the other problem is that it tries to see if an update is available for saltcorn in npm

also fixed in #1487. It will still make the request to npm but only wait 500ms.

Thank you @glutamate!


ddnet 18.1 -> 18.2 (plus one patch to workaround a libcurl problem)

Description of changes
https://ddnet.org/downloads/#18.2
https://github.com/ddnet/ddnet/compare/18.1...18.2
Runtime libcurl problem and workaround
When testing if found out that there is a problem when comping 18.2 with the latest libcurl in NixOS unstable (8.7.1). This also happens if one builds 18.1 with this libcurl version.
The problem will lead to some libcurl downloads fail but not all. E.g. the flag status in ddnet server browser will not be updated anymore (easily testable by selecting a username with ddnet score 0 and pressing reload in server browser, flag status will stay the same - requires user with some solved maps to test).
Also there are some error messages in the log of the ddnet client, like:
2024-05-05 17:20:55 E http: https://master1.ddnet.org/ddnet/15/servers.json failed. libcurl error (23):

I tracked it down and it seems that brotli is the problem. A very simple patch is added to this PR and will disable brotli for this release. ddnet works well with that path.
Sadly i can not fully reproduce this as the problem occurs with the ddnet master server which is not part of this package at all. So it is maybe a combination of the client and server libcurl versions and settings. I asked in ddnet discord bugs room, but no one had any idea.
A friend tested to compile ddnet on arch which uses libcurl 8.7.1 as well, no problems there.
Maybe anyone reading this PR got an idea what the problem might be. Also please advice if the patch is a solution clean enough to merge this or not .

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

I encountered the same problem. Should we maybe directly patch curl? This commit is enough https://github.com/curl/curl/commit/b30d694a027eb771c02a3db0dee0ca03ccab7377

fyi: https://github.com/NixOS/nixpkgs/pull/306633

fyi: #306633

oh nice, that means we better just wait until this hits unstable and then i will remove the patch from this PR?

it seems the curl fix has not hit unstable yet, i thought is might be a side effect of 24.05 release (very uneducated guess..), so i was waiting for that
what about merging this version with the patch and remove the patch in a later update, when it is no longer needed?

The fix is in nixos-unstable AFAICT: you can track it here and check that the patch is there.

thanks, that helped
the libcurl PR seems to hit unstable now and now it works w/o the workaround, so i removed it
this PR is now really small as usual and works great for me

Can we skip ahead to 18.3?

at first try 18.3 did not compile and right now i have no time to investigate that, so if it does not hurt, lets wait if someone else wants to check that (its something related to -Werror=format-security)


docs: Initial notes on remote functions.

Re: https://github.com/dxos/dxos/issues/3205

🤖 Generated by Copilot at 89d8fcd
Summary
📝🚀🌐

Added a design document for the remote functions feature in docs/docs/design/remote-funcitons.md. The document explains the spec, architecture, and use cases of the feature, which allows users and developers to run functions over ECHO spaces and external systems.

Remote functions -
Designing for DXOS platform
Winter of coding

Walkthrough

Add a new markdown document that describes the design of remote functions (link)

fyi forever https://www.npmjs.com/package/forever


Remove checks for 'put_content' in features

https://trello.com/c/u9kRKVsX/1324-extract-title-and-summary-into-classes-views-and-config
Previously we added these steps to many features as a way to check the
tangential outcomes of a user action, including the document state and API
requests to Publishing API and Asset Manager, which arise from the
PreviewDraftEditionService. Checking API requests in features was pragmatic
when we had limited tests at lower levels, and the idea was that each
feature would cover its specific part of the Publishing API payload. Since
then, we've introduced the
'failsafe preview' feature, such that its far less important or
'optional' that a request is made, since a fallback exists. The checker for
draft user state was added with a similar mindset, to ensure that the
edition state is (re)set appropriately on edit, which is now covered by
'editable?' assertions.
This removes the checks for API requests and draft user state, and renames
or removes the associated step method to leave one that checks for a
timeline entry only.

I am interested indeed, nice work @benthorner!


STEP-26: Create unit and integration tests for "Transformer selection information"

Create unit and integration tests for "Transformer selection information"
Acceptance criteria:

unit test created
integration test created

Implements in https://github.com/EllsaG/power-supply-design/pull/68 pull request.

Implements in https://github.com/EllsaG/power-supply-design/pull/75 pull request.
Added new tests.


Copy button for OCR text

Add a button to copy the whole text recognized by OCR, ideally with newlines #75

@balporig good idea

@balporig new build released on github. You can copy from the OCR data view. You can also long press on the button to show OCR data to quickly copy it

@balporig  sorry about that. new build is up!

there is already on  android 13 but you are right I LL add one on older android

@balporig the visual confirmation has been added. Thanks for mentioning it


Ammo JS is not included in dist

I thought it should be important to note somewhere that you must find and include ammo.js if using playcanvas offline. I was expecting it to be a part of the distribution file, https://code.playcanvas.com/playcanvas-stable.min.js.

Ammo.js in an optional library to be included, and is not a part of the engine, although have close integration. Many projects do not use physics, so loading the library for those cases would be not desirable.

Yeah, ammo.js is considered by the engine to be an asset (of type 'module'). Same for Draco and the Basis transcoder. These modules can be found here:
https://github.com/playcanvas/engine/tree/dev/examples/src/lib
Since these modules tend to be loaded by the engine dynamically instead of being included into your app at build time (courtesy of say, Rollup or Webpack), they probably don't belong in the PlayCanvas Engine's NPM module distribution.
So I think I'll close this now since this was originally opened a year ago. But if anybody would like to follow up, be my guest. 😄


Failing to import Dependency via gradle

I can't seem to import the library using gradle
compile 'com.github.mabbas007:TagsEditText:v1.0.1'

Even when i add the @aar qualifier, it still fails to resolve properly

Don't forget to add the following
allprojects {
repositories {
maven { url "https://jitpack.io" }
}
}

I've added and no change.same issue
On Sat, Sep 17, 2016, 7:54 PM Mohammad Abbas<EMAIL_ADDRESS>wrote:

Don't forget to add the following
allprojects {
repositories {
maven { url "https://jitpack.io" }
}
}
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/mabbas007/TagsEditText/issues/14#issuecomment-247797430,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGMQfbtjna9HXu2af8zwa6v8HdStWie2ks5qrDdpgaJpZM4J_rRq
.

It now works thanks @mabbas007 . But why do i have to use the tag above when i am already using the jitpack repositories in the project wide build.gradle?

Glad to hear that, I'm not sure why.


Change display of sumstats availability in info box

On Publication and Study page, in the info box, sumstats availability is indicated in the Full Summary Statistics field, with an icon (for availability) or dash (if unavailable). The dash should be changed to text "Not available" to match the new table display.

Tested, looks good


Replacing textframe text leaves traces of previous text

Check the repo at https://github.com/rubenanton90/ShapeCrawlerTextBug , the offending pptx is samplepptx_es.pptx, you can change the code to point to samplepptx.pptx, that one works fine
Going through all the text frames in a slide and reversing their text:
  foreach (ITextFrame item in slide.TextFrames())     {         item.Text = ReverseText(item.Text);     }
(Any other text replacement also fails in a similar way, reversing text is just an example)
results in some text not being replaced properly. For example, in the first slide, from the input text "Fichero powerpoint de ejemplo" instead of displaying the text "olpmeje ed tnioprewop orehciF", it displays "olpmeje ed tnioprewop orehciFpowerpoint de ejemplo"
Also tried some workarounds, such as going through each paragraph in the text or even using paragraph.ReplaceText(paragraph.Text, reversedText) to no avail

Seems to be an issue with IParagraph.cs, in this section:
https://github.com/ShapeCrawler/ShapeCrawler/blob/master/src/ShapeCrawler/Texts/IParagraph.cs#L96-L101
            // To set a paragraph text we use a single portion which is the first paragraph portion.
            var baseARun = this.AParagraph.GetFirstChild<A.Run>() !;
            foreach (var removingRun in this.AParagraph.OfType<A.Run>().Where(run => run != baseARun))
            {
                removingRun.Remove();
            }

It doesn't actually remove all the A.Run elements that it is meant to, only the first element.
Copying the runs with .ToList() then iterating over that seems to fix it - the runs to be removed are actually removed, then the text can be set correctly on the base run as expected:
            // To set a paragraph text we use a single portion which is the first paragraph portion.
            var baseARun = this.AParagraph.GetFirstChild<A.Run>() !;
            var remainingRuns = this.AParagraph.OfType<A.Run>().Where(run => run != baseARun).ToList();
            foreach (var removingRun in remainingRuns)
            {
                removingRun.Remove();
            }

@edwardmcleodjones, thank you for your fix https://github.com/ShapeCrawler/ShapeCrawler/pull/719 👍
@rubenanton90, could you please check your case with the latest version.

Hi! Sorry for the delay. Can confirm it works properly in 0.53.1
Thank you @edwardmcleodjones  and @ashahabov for your great work!


Update software_support.md

Description

Reason: To expand the list of GUI software available to help beginners and new users interested in Jpeg XL)
Library:

Jpeg XL coder for Android 21+ (https://github.com/awxkee/jxl-coder)

Image editor:

XL Converter (https://github.com/JacobDev1/xl-converter)
Image Toolbox (https://github.com/T8RIN/ImageToolbox)

Pull Request Checklist

[x] CLA Signed: Have you signed the Contributor License Agreement (individual or corporate, as appropriate)? Only contributions from signed contributors can be accepted.
[x] Authors: Have you considered adding your name to the AUTHORS file?
 You can use ./ci.sh lint for automatic code formatting.

Please review the full contributing guidelines for more details.

CLA signed.


The entity tree structure is not built correctly

it is possible to have something like in the figure below: c1 has two children: c5 and c2, but in the tree c2 is shown as child of c5

This situation can be reproduced doing:

  I choose an entity with no children, e.g c3

  I define a children, e.g c10

  Click save, having c3/c10 in the tree

  I define another children, c11

  I click save, I have c3/c11,c10 in the tree, the list on the rigth side has other order, c10,c11

  I choose the first children on the tree, c11, the element below c3

  I create a children, eg. C12

  I save

  The tree is corrupted: c10 is shown as children od c11 instead of c3. But only the first time that the root (c3) appear in the tree.

Sometimes the tree is not corrupted yet, normally the component with the children appears at the end of children. In that case:
10. Choose the other children, the one without children yet
11. Add a children and save


Clarified ambiguous example in the readme

In the readme there is this example:
// get the user directly
$user = $client->fetchUser();

// get the access token and then user
$accessToken = $client->getAccessToken();
$user = $client->fetchUserFromToken($accessToken);

What's not quite obvious to the untrained eye in my opinion is that you cannot execute the example code exactly like this, because $client->fetchUser() "burns" the authorization code so you cannot use it again in $client->getAccessToken(). The OAuth2 server will report an error "code is invalid or expired".
A simple "OR" in the comment should make it more clear that both ways of acquiring the user data are mutually exclusive in the example and not to be executed one after the other.
// get the user directly
$user = $client->fetchUser();

// OR: get the access token and then user
$accessToken = $client->getAccessToken();
$user = $client->fetchUserFromToken($accessToken);

dammit


ci: setting up job to sync service_config.proto

Thank you for opening a Pull Request! For general contributing guidelines, please refer to contributing guide
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

[ ] Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
[ ] Ensure the tests and linter pass
[ ] Code coverage does not decrease (if any source code was changed)
[ ] Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕

Talked with Blake. Because the file is seldom updated, it's better to add a section in README.md.
Also this pull request relies on master branch, not a released version, which may contain temporary changes there.


update dep requirement: scrapy>=2.6.0

Some users encounter problems like the one below when using the old version of Scrapy:
ERROR: <twisted.python.failure.Failure scrapy.exceptions.NotSupported: Unsupported URL scheme 'https': type object 'TextResponse' has no attribute 'attributes'>

It stems from using the new Response.attributes of Scrapy 2.6.
I'm proposing to require users to have a minimum of scrapy>=2.6.0 to be able to use it.
Fixes https://github.com/scrapy-plugins/scrapy-zyte-api/issues/22

Thanks @BurnzZ!


add version back to release products

fixes https://github.com/adoptium/jmc-build/issues/67

@gdams thanks a lot 🙌


Query Dataset

Is your feature request related to a problem? Please describe.
I rely on Senzing to handle information coming from a data stream that I don't always have deep insight into. I would like to be able to perform some queries via the webapp that allow me to see the current state of entities in my database.
Describe the solution you'd like
The Desktop application has a feature similar to what I am seeking. Running the Desktop app you see a general view of the entities in the database, broken down by relationships, possible matches, etc. Having a similar "general" view on the webapp would be very beneficial.
Describe alternatives you've considered
I currently workaround the issue by launching PGAdmin and querying the dsc_record table. VERY unfriendly experience. Also, I've looked into using the Desktop application and configuring it to use my webapp database as a data source.  That's a non-starter (but the next ticket I'll be writing. ;))
Additional context
I'm not looking to boil the ocean but an API / webapp interface that allows me to generally understand what entities I've collected in my DB would be useful so some filtering ability may be nice.

I'm not sure what you mean by "general" view. In the desktop app you can browse by datasource -> filtered by (duplicates | matches etc). If this is the view you are looking for you are correct, there is no functionality supporting this type of browsing in the webapp. I am unaware of any immediate plans to support this type of browsing(although it has been brought up), the app can do it easily because it is a local instance/db and those sample sets are pre-generated behind the scenes. I'll raise the issue/topic at the next planning meeting. We know people want that, and we want it for feature parity, it's got some technical/design issues that need to be worked out before we can add that.

@LRSutton We have work planned over the coming quarters that may address your request. Can you please set up a time with me so that we can discuss your needs in greater detail?
Laura Product@Senzing
<EMAIL_ADDRESS>

We are leaving this open as a relevant feature request that is not on our near-term roadmap for the web app.
This year's goals with the web app focus on:

Loading records via the interface (for product evaluation only)
Adding "Why Entities" functionary from the command line EDA tools to the exploration workflow of the web app.

We have more data exploration features planned, if there are any you are looking for and highly desire please post a feature request to this project.


bpf: constify pointer function arguments

Constify pointer function arguments where possible.

test-me-please

@tklauser The tests for this ended up on a machine with no free disk. It will probably fail. Sorry!

Coverage increased (+0.03%) to 45.521% when pulling 161c8aaba8bb30a1e99dc0f57574a44a705926ea on pr/tklauser/bpf-const-args into 3de06351e01b9c2589565cad5c34b830335e5e42 on master.

@tklauser The tests for this ended up on a machine with no free disk. It will probably fail. Sorry!

@raybejjani no worries, this isn't something urgent, so I can retrigger the failed tests once the issue is sorted out.

test-with-kernel

I wonder if we could write a Coccinelle script for this

We do have a coccinelle script in our repo:
https://github.com/cilium/cilium/blob/master/contrib/coccinelle/null.cocci
I think we can invoke them via make check, but probably makes more sense to extend them and integrate into our CI, same with the sparse in there so we can bail out early and catch such bugs?

I wonder if we could write a Coccinelle script for this

We do have a coccinelle script in our repo:
https://github.com/cilium/cilium/blob/master/contrib/coccinelle/null.cocci
I think we can invoke them via make check, but probably makes more sense to extend them and integrate into our CI, same with the sparse in there so we can bail out early and catch such bugs?

Opened #10842.


backport: bitcoin-core/gui#29, gui#123, #164, gui#256, gui#309, gui#313, gui#329, gui#331, gui#333, gui#393, partial gui#346

Issue being fixed or feature implemented
Gui related backports from bitcoin v22
What was done?
See commits
How Has This Been Tested?
Run unit/functional tests
See also:

Breaking Changes
N/A
Checklist:

[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have added or updated relevant unit/integration/functional/e2e tests
[ ] I have made corresponding changes to the documentation
[x] I have assigned this pull request to a milestone

It seems as all GUI changes in this PR doesn't really worth to be mentioned in the Release notes, maybe except quick access for "online/offline" switch from peer button, but I am open for suggestions
@UdjinM6 @PastaPastaPasta @thephez

On the console screen, these still don't look like buttons for me. I thought one of these PRs changed that?

That's right, we have our own style by "css", so, these changes in backport doesn't actually changed style of buttons, just unified code with bitcoin. They doesn't look nice as rectangle buttons here I think, should we change it?

On the console screen, these still don't look like buttons for me. I thought one of these PRs changed that?

That's right, we have our own style by "css", so, these changes in backport doesn't actually changed style of buttons, just unified code with bitcoin. They doesn't look nice as rectangle buttons here I think, should we change it?

I don't mind them the way they are. But I'm a horrible judge of good ui/ux :smile:

LGTM but gui346 shouldn't be partial imo - we update translations all at once so there won't be another backport gui#346

LGTM but gui346 shouldn't be partial imo - we update translations all at once so there won't be another backport gui#346

Indeed, removed "partial" mark


api: add proto transform quick mode

The current proto transform tooling takes quite a bit of time to run. During the dev/test cycle it would be very nice to have a "fast" mode where we only transform a specific set of proto files and copy them out to the shadow files. This would greatly speed up the dev flow when making a feature, especially until we get rid of the checked in shadow files and have them built directly by bazel on demand.
cc @htuch

My starting point here would be to look back in the tree to the last GitHub merged commit and list the proto files that have changed, restricting protoxform to just these files. This should provide a huge speedup. We already do something like this, deciding whether to do a proto format run based on whether any protos have changed since the last GitHub merged commit.
This is on my TODO, but not at the top, so if someone else wants to work on it please go ahead.


Feature request: Lint when server starts

It would be cool to have automatically linting when running npm run dev instead of actively starting it with npm run lint.

Heya, you can achieve that by amending your the dev script in package.json to the folllowing:
"dev": "nodemon src/index.js --exec \"node -r dotenv/config -r babel-register\" & npm run lint",
Does that help?

Hey, that works perfectly, thanks a lot! Why not adding this to package.json :) ?

No worries. I'm not adding it because it very much depends on preference, most people want the server output be on a different terminal app than the lint output, and they also lint inside their editors normally rather than on the terminal. It's a very easy change so I'm leaving it as is for now :) Thanks for your interest btw!

Just a minimal improvement:
"dev": "nodemon src/index.js --exec \"node -r dotenv/config -r babel-register\" | npm run lint"

This let's you kill both processes at once with Ctrl + C.


Fix unimplemented! vulnerability

Panicking at SOA record currently can be easily exploited by "hacker" - he can kill the process easily.
Also, I have increased errorchain version - now there are no compilation warnings. I introduced struct field shorthand too.

Nice work, sorry for the delay!

Released 0.2.3


[dropIn] onChange event not triggered when switching payment method type

Describe the bug
We're using the onChange event to validate/invalidate our payment flow. When selecting a payment method type + issuer and switch from payment method type and back. The onChange event is not being triggered when switching from payment method type. It's only being triggered when actually updating the values within the payment method forms.
To Reproduce
Steps to reproduce the behavior:

Go to https://github.com/adyen-examples/adyen-node-online-payments#run-this-integration-in-seconds-using-gitpod and setup an example
Click on Drop-in
Click on Continue to checkout
Select a issuer in the iDeal payment method
A onChange event is triggered
Click on Credit or debit card
A onChange event is triggered
Click on iDeal
NO onChange event is triggered

Expected behavior
An onChange event should be triggered every time the form changes state. So the actual returned value could represent the current form state.
Desktop & smartphone (please complete the following information):

OS: all
Browser all
Version all

Additional context
Tested with sdk 5.30.1

Hey @michielmetcake
The onChange event is triggered when the input fields are rendered by the first time or when the user interacts with it by changing its value.
What is happening in this case is: When you open iDeal, the input field is created, then you switch to the Card and its fields are created, then you come back to iDeal but the field is already created, and it was just hidden. That leads to onChange not be triggered. This can be something that we can take a look internally, seems like this could be improved.
Which kind of validation are you trying to achieve here? You can also use the onSelect to detect when the shopper changes the payment method in the dropin , and you can also get the payment method data from this callback.

@ribeiroguilherme thank you for your quick reply.
You're 100% correct. But I can't get the values that I'm looking for from the arguments of the onSelect callback.
The values from the onChange callback are:
{
    "data": {
        "paymentMethod": {
            "type": "ideal",
            "issuer": "0511"
        },
        "clientStateDataIndicator": true
    },
    "errors": {
        "issuer": null
    },
    "valid": {
        "issuer": true
    },
    "isValid": true
}

And if I look into the component argument from the onSelect then I see a state and props value which might be kind of the same, but not 100%.
{
    "data": {
        "issuer": "0511"
    },
    "valid": {
        "issuer": true
    },
    "errors": {
        "issuer": null
    },
    "isValid": true
}

Especially for the creditcard it's lacking a lot of information that's not available in the onSelect  arguments. Do you see any possibility to get the same values?

Can you shed some light of which arguments are you looking for, and what is the use-case?


Need Minimal Configuration for sequence of images to MP4.

Hi,
I need minimal configuration for convert the sequence of images to mp4. Please give.
No need audio and any other formats. Just bitmaps to mp4 video.
Thank you.

Hello @sabishm ,
This project automates downloading and building of the FFmpeg library per se. Fulfilling the particular requirements of your project is actually your responsibility, as you know your project better and it is you how will integrate the SO libraries and support it in future.
The only thing I can direct you to is the configure script of the FFmpeg itself that contains the list of supported flags.


Use VRSkeletalTracking_Estimated Instead of VRSkeletalTracking_Partial

Fixes #2300
This fix works on VRChat, but I was unable to verify compatibility with other games like Resonite due to Linux compatibility issues

@Meister1593 @The-personified-devil do you want to test or do we just merge?

Estimated is technically a downgrade from Partial for controllers that actually support it (though I don't think most controllers of standalone headsets would properly qualify as Partial). But my preferred solution would be to only use Estimated when the separate controllers option is used.

I would tend to agree with that


Multiple errors running "python demo.py --xyz" with OAK-D camera

Hello @geaxgx and thank you so much for this terrific software! I have been able to get depthai_blazepose to work in many modes with my OAK-D camera. For example when I run python demo.py --edge --lm_m='lite' I see 26 FPS which is awesome!
However, I really want to be able to see the xyz coordinates, however when I run python demo.py --xyz I get several errors (see below) including a RuntimeWarning and a TypeError, and the program quits. Am I doing something wrong?

Pose detection blob file : /Volumes/GoogleDrive-102536951206467607597/My Drive/Projects/Punchout/SkeletalTracker/depthai_blazepose/models/pose_detection_sh4.blob
Landmarks using blob file : /Volumes/GoogleDrive-102536951206467607597/My Drive/Projects/Punchout/SkeletalTracker/depthai_blazepose/models/pose_landmark_full_sh4.blob
Internal camera FPS set to: 13
Sensor resolution: (1920, 1080)
Internal camera image size: 1152 x 648 - crop_w:0 pad_h: 252
2254 anchors have been created
Creating pipeline...
Creating Color Camera...
Creating Pose Detection pre processing image manip...
Creating Pose Detection Neural Network...
Creating Landmark Neural Network...
Pipeline created.
[14442C1001FA60D700] [61.040] [NeuralNetwork(12)] [warning] Number of inference threads assigned for network is 1, assigning 2 will likely yield in better performance
[14442C1001FA60D700] [61.055] [NeuralNetwork(12)] [warning] The issued warnings are orientative, based on optimal settings for a single network, if multiple networks are running in parallel the optimal settings may vary
Pipeline started - USB speed: SUPER
/Volumes/GoogleDrive-102536951206467607597/My Drive/Projects/Punchout/SkeletalTracker/depthai_blazepose/mediapipe_utils.py:246: RuntimeWarning: overflow encountered in exp
scores = 1 / (1 + np.exp(-scores))
Traceback (most recent call last):
File "/Volumes/GoogleDrive-102536951206467607597/My Drive/Projects/Punchout/SkeletalTracker/depthai_blazepose/demo.py", line 68, in
frame = renderer.draw(frame, body)
File "/Volumes/GoogleDrive-102536951206467607597/My Drive/Projects/Punchout/SkeletalTracker/depthai_blazepose/BlazeposeRenderer.py", line 158, in draw
self.draw_landmarks(body)
File "/Volumes/GoogleDrive-102536951206467607597/My Drive/Projects/Punchout/SkeletalTracker/depthai_blazepose/BlazeposeRenderer.py", line 114, in draw_landmarks
cv2.rectangle(self.frame, body.xyz_zone[0:2], body.xyz_zone[2:4], (180,0,180), 2)
TypeError: Argument 'thickness' is required to be an integer

Hi, thanks for the quick reply!
I tried your suggestion but got this error:

TypeError: argument for rectangle() given by name ('thickness') and position (4)

Out of curiosity I also tried adding a debug line: print(body.xyz_zone) and it printed [322, 479, 350, 507], so maybe the problem is that the body.xyz_zone[2:4] slice went out of bounds of the array ?


Drawer Page Selector

Added switch cases on Layout component to select which pages you would like to display the drawer on. This solution is a little dirty but I think its the best way aside from adding the drawer component to every page that needs it.

This is alright but I think we should just move the component to the pages that we need it on. We will need to pass props to the like the name of the company and maybe meeting tags.


add scalafmt to build and reformat all sources

This took a while as I was quite unhappy with some of the defaults and ended up reading the the documentation for every single configuration option.
Many settings are not worth discussing in detail, but there are two which will allow for a tiny amount of inconsistencies in formatting to prevent some of the outcomes I found undesirable:
Scaladoc
I did not find an option that would wrap all lines in documentation comments that do exceed maxColumn, but leave everything else untouched. Instead the wrapping option would reflow the entire comment, which breaks the intended formatting style for scaladoc in this project: adding line breaks after periods and commas even if there is still space on the line to avoid a complete reflow in case of amendments. Without this the comments are harder to read and very often lead to larger diffs in PRs as adding a single word to the beginning of a comment can trigger a reflow of all subsequent lines. For this reason the option docstrings.wrap = no has been added.
Select Chains
The default for scalafmt is that if a select chain does not fit onto a single line, then each select will be put onto a separate line. This is fine for most cases, but ruins the intended formatting for Helium configuration which is used a lot throughout the unit tests in the laika-io module. The Helium API always semantically groups two selects and I'd prefer to preserve this.
Example:
val theme = Helium.defaults
  .all.metadata(
    title = Some("Project Name"),
    language = Some("de"),
  )
  .epub.navigationDepth(4)
  .pdf.navigationDepth(4)
  .build

For this purpose the option newlines.selectChains = keep has been added.
These two options should be mentioned explicitly in the contributor's guide (which is also still on my todo list).

In case you are not already aware of it—I recommend adding a .git-blame-ignore-revs with the formatting commit.
Example:
https://github.com/typelevel/cats/blob/555a4f19a6d18f640223103d73ba15a5d74f2e58/.git-blame-ignore-revs
Of course, to be effective you will have to avoid the squash-merge for this PR :)

Ah, nice, didn't know this. Will add this.
But first I need to figure out why scalafmtCheckAll fails on CI, but not locally...


DMN decision logging doesn't log input variable values

version: 1.2.0, as docker container
values of input-variables of DMN (table) decisions aren't logged properly:
dmn-worker  | 2021-12-17 15:59:13.956  INFO 1 --- [pool-3-thread-2] i.z.dmn.DmnDecisionTableLoggingListener  : Evaluated decision table [name: 'Decision 1', key: 'decision1']
dmn-worker  | > Input [label: 'from input1', value: 'null']
dmn-worker  | > Input [label: 'in_weather', value: 'null']
dmn-worker  | > Input [label: 'in_celsius', value: 'null']
dmn-worker  | > Input [label: 'do_it', value: 'null']
dmn-worker  | > Matched rule [index: 2]
dmn-worker  | >  Output [label: 'null', name: 'out_weather_finegrained', value: 'moderately sunny']
dmn-worker  |
dmn-worker  | 2021-12-17 15:59:13.966  INFO 1 --- [pool-3-thread-2] i.z.dmn.DmnDecisionTableLoggingListener  : Evaluated decision table [name: 'Decision 2', key: 'decision2']
dmn-worker  | > Input [label: 'from decision 1', value: 'null']
dmn-worker  | > Matched rule [index: 2]
dmn-worker  | >  Output [label: 'null', name: 'out_final', value: 'worked: anything other than very sunny']

but all variables are definitely provided to the business rule task and recognized by the DMN, as the decisions are working properly, with expected results.
from Operate:

@vobu thank you for reporting :+1:
It's working for me using the sample DMN in the project.
zeebe-dmn-worker | 2021-12-20 10:02:59.331  INFO 1 --- [pool-3-thread-2] i.z.dmn.DmnDecisionTableLoggingListener  : Evaluated decision table [name: 'Risk Check', key: 'checkRisk_en']
zeebe-dmn-worker | > Input [label: 'Age', value: '30']
zeebe-dmn-worker | > Input [label: 'Employment', value: 'Salaried']
zeebe-dmn-worker | > Input [label: 'Category', value: 'test']
zeebe-dmn-worker | > Input [label: 'Score', value: '80']
zeebe-dmn-worker | > Matched rule [index: 1]
zeebe-dmn-worker | >	 Output [label: 'Risk', name: 'risk', value: 'Won't Pay In Time']
zeebe-dmn-worker | >	 Output [label: 'Risk Level', name: 'riskLevel', value: 'red']

Please add the steps to reproduce the issue including your DMN files and the variables.

env
DMN is included in attached BPMN "business rule task"
bpmn.txt
dmn.txt
please note: had to rename both files to .txt in order for gh to allow file upload
in DMN model 1:
from input 1 has an DMN input element with id input1 that gets filled at runtime
in_weather is mapped to a higher-/gobal scoped var of the same name, same for in_celsius and do_it
in DMN model 2:
from decision 1 is mapped to the output var of DMN model 1, out_weather_finegrained
reproduce

provide attached DMNs to docker container via volume mappingvolumes:
    - ../path/to/dmns:/usr/share/zeebe/dmn-repo

Node.js zeebe client zeebe-node is used for triggering BPMN process execution.
a buiness rule worker is implemented and provides the above mentioned global variables:await zbc.createProcessInstance({
    bpmnProcessId: "linked-dmns-in-biz-rule-task",
    variables: {
     "input1": "evaluate sunny",
      "in_weather": "sunny",
      "in_celsius": 20,
      "do_it": true
    },
    version: 5
  })

→ the process instance is correctly created, also with the supplied variables (see screenshot from Operate) in original post

result
expected
dmn-worker  | > Input [label: 'from input1', value: 'evaluate sunny']
dmn-worker  | > Input [label: 'in_weather', value: 'sunny']
dmn-worker  | > Input [label: 'in_celsius', value: 22]
dmn-worker  | > Input [label: 'do_it', value: true]
dmn-worker  | > Matched rule [index: 2]
dmn-worker  | >  Output [label: 'null', name: 'out_weather_finegrained', value: 'moderately sunny']
<snip />
dmn-worker  | > Input [label: 'from decision 1', value: 'moderately sunny'']
dmn-worker  | > Matched rule [index: 2]
dmn-worker  | >  Output [label: 'null', name: 'out_final', value: 'worked: anything other than very sunny']

actual
dmn-worker  | > Input [label: 'from input1', value: 'null']
dmn-worker  | > Input [label: 'in_weather', value: 'null']
dmn-worker  | > Input [label: 'in_celsius', value: 'null']
dmn-worker  | > Input [label: 'do_it', value: 'null']
dmn-worker  | > Matched rule [index: 2]
dmn-worker  | >  Output [label: 'null', name: 'out_weather_finegrained', value: 'moderately sunny']
dmn-worker  |
<snip />
dmn-worker  | > Input [label: 'from decision 1', value: 'null']
dmn-worker  | > Matched rule [index: 2]
dmn-worker  | >  Output [label: 'null', name: 'out_final', value: 'worked: anything other than very sunny']

@vobu thank you for providing the example :+1: I can reproduce the issue.
I checked the DMN. The Zeebe worker behaves as expected but there is an issue in the DMN itself.
In Decision 1, the input from input1 should read the variable input1. But the input doesn't have an input expression. Instead, it defines the Input Variable as input1. It works in this case but it is not the intended/recommended way of modeling it. An input should always define an input expression that accesses the variable.
If you set an input expression for the input (as you can see in the screenshot) then the input values are printed by the Zeebe worker.

The modified DMN: dmn-modified.txt
Does this make sense for you?

thanks a lot for providing the modeling guidance and the updated DMN!
can confirm that this resolved the "issue".
2022-01-11T20:25:31.76+0100 [APP/PROC/WEB/0] OUT 2022-01-11 19:25:31.765  INFO 8 --- [pool-3-thread-3] i.z.dmn.DmnDecisionTableLoggingListener  : Evaluated decision table [name: 'Decision', key: 'decision_person_amicable']
   2022-01-11T20:25:31.76+0100 [APP/PROC/WEB/0] OUT > Input [label: 'in', value: 'warm']
   2022-01-11T20:25:31.76+0100 [APP/PROC/WEB/0] OUT > Matched rule [index: 1]
   2022-01-11T20:25:31.76+0100 [APP/PROC/WEB/0] OUT >	 Output [label: 'result', name: 'calculated_person_status', value: 'sunny person!'

→ closing this


expand text extraction and / or write example on insults?

I worked on 3.4 but have not done 3.5 - I can do it based on your blog or you can do it - up to you

Sorry I'm offline till Monday night. Maybe we should just go with the 20
news? Don't worry about it, I have a notebook on the insults.
On Jun 28, 2015 6:39 PM, "Kyle Kastner"<EMAIL_ADDRESS>wrote:

I worked on 3.4 but have not done 3.5 - I can do it based on your blog or
you can do it - up to you
—
Reply to this email directly or view it on GitHub
https://github.com/amueller/scipy_2015_sklearn_tutorial/issues/20#issuecomment-116356432
.

OK that works for me. I will look at other sections - I did a little bit
(really just cut some stuff) for text feature extraction "methods" part.
If you would rather just use 20 news that is cool - you are the master of
the insult part so I will let you choose :D. I will go through day 2 and
see if I see anything, though I will wait til any of your changes are in
before doing anything more than take notes on what to fix.
On Mon, Jun 29, 2015 at 3:04 AM, Andreas Mueller<EMAIL_ADDRESS>wrote:

Sorry I'm offline till Monday night. Maybe we should just go with the 20
news? Don't worry about it, I have a notebook on the insults.
On Jun 28, 2015 6:39 PM, "Kyle Kastner"<EMAIL_ADDRESS>wrote:

I worked on 3.4 but have not done 3.5 - I can do it based on your blog or
you can do it - up to you
—
Reply to this email directly or view it on GitHub
<
https://github.com/amueller/scipy_2015_sklearn_tutorial/issues/20#issuecomment-116356432
.

—
Reply to this email directly or view it on GitHub
https://github.com/amueller/scipy_2015_sklearn_tutorial/issues/20#issuecomment-116486182
.

thinking a bit more - is the troll detection data public or only through
Kaggle? If it is only through Kaggle we may not be able to use it
On Mon, Jun 29, 2015 at 7:57 AM, Kyle Kastner<EMAIL_ADDRESS>wrote:

OK that works for me. I will look at other sections - I did a little bit
(really just cut some stuff) for text feature extraction "methods" part.
If you would rather just use 20 news that is cool - you are the master of
the insult part so I will let you choose :D. I will go through day 2 and
see if I see anything, though I will wait til any of your changes are in
before doing anything more than take notes on what to fix.
On Mon, Jun 29, 2015 at 3:04 AM, Andreas Mueller<EMAIL_ADDRESS>
wrote:

Sorry I'm offline till Monday night. Maybe we should just go with the 20
news? Don't worry about it, I have a notebook on the insults.
On Jun 28, 2015 6:39 PM, "Kyle Kastner"<EMAIL_ADDRESS>wrote:

I worked on 3.4 but have not done 3.5 - I can do it based on your blog
or
you can do it - up to you
—
Reply to this email directly or view it on GitHub
<
https://github.com/amueller/scipy_2015_sklearn_tutorial/issues/20#issuecomment-116356432
.

—
Reply to this email directly or view it on GitHub
https://github.com/amueller/scipy_2015_sklearn_tutorial/issues/20#issuecomment-116486182
.

ok done with a very simple and small sms dataset


Sink doesn't fail on 403, and other non-success codes

In the EmitBatchAsync method in LogglySink.cs, there is nothing that I could find that will cause the exception on line 42 to actually be caught, since HttpClient does not throw by default.
Perhaps we could change it to
var result = await httpClient.PostAsync(_logglyUrl, content);
result.EnsureSuccessStatusCode();

To force an exception on non-success result codes?  I noticed this while writing a local test and intentionally putting the wrong CustomerToken in, I did not get any output to Trace or Serilog.Debugging.SelfLog as I would expect on a 403.
Open to other fixes as well.

@jamesbascle if you could submit a PR this would be great

additionally i don't own a PC anymore so I can't really do anything with this code... sooooooo you might want to fork it make the changes and create your own nuget package.

I also have this issue and would appreciate immediate resolution

:+1: I depend heavily on this framework

Me too

@samirahmed I have no problems taking over this thing...I'll fork and try to set up an Appveyor CI NuGet build this week.  Will update this thread when done.

Alright, I've got a CI build set up on AppVeyor, and it can push to NuGet.org.  Currently have it set to Serilog.LogglyBulk.  Would prefer to use the one @samirahmed set up if he can scrounge up the creds and XFer ownership/invite me as an Owner.

@jamesbascle what is your nuget.org username? i added a jamesbascle as owner ... hopefully that is you

It is indeed, but I don't see anything that has changed on NuGet.org from my side.  I'll try pushing to it using a -prerelease package with 0 functional changes.

Hmm. I am still unable to view any ownership capabilities in the NuGet.org site, nor is AppVeyor able to push to that feed using my API key.

For all following the thread, I've released a new version with the suggested changes at https://www.nuget.org/packages/Serilog.LogglyBulk/<IP_ADDRESS>
You can see the code on my fork of this repo.  Hopefully we can work out the issues with the original NuGet.org feed, and the repo can be XFerred to me, otherwise I'll maintain my fork and feed if any new issues come up.


Track new features/options/ideas to add that use the custom Config parameters.

Create an Issue to track new features/options/ideas for additional features to add that use the Config parameters.
Originally posted by @GitMurf in https://github.com/GitMurf/roam-highlighter/issues/89#issuecomment-716833232

#88 may be a good one for this.


Split functions over smaller, more manageable, source files.

No logical changes.
Move most functions from src/main.rs into src/sv_*.rs.
Public components at top.
Rename parse_module_declaration_ansi to module_declaration_ansi.
Rename parse_module_declaration_nonansi to module_declaration_nonansi.

@vasilissoti Are you happy with this split?

Yes of course!


Add the all the CSS bezier-based easings (see easings.net) as built-in aliases in parseq

This is now implemented (see the curve parameter on the bez function).


--localToRemote should resolve name of HOST remotely, not locally

Is your feature request related to a problem? Please describe.
Maybe I did something wrong but I did achieved to use the localToRemote feature when using a hostname as HOST which is known where I call this.
Describe the solution you'd like
It would be nice if the value for HOST could be some hostname which exists in the remote network internally.
Describe alternatives you've considered
I found a solution using localhost as hostname but this makes things more complicated.

Can you give me the command line you are using ?
Because the host from --localToRemote is already resolved by wstunnel server and not on the client.

Hi @erebe,
thanks for your quick reply.
I tried to repoduce my problem but now I only found it working as you described it. This way it makes absolutely sence and I am not able to find out what went wrong.
So don't mind this "issue" and thanks for a great app!


edit description for list and add command UG

Codecov Report

Merging #51 (b53cc10) into master (c2cd394) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #51   +/-   ##
=========================================
  Coverage     72.15%   72.15%
  Complexity      399      399
=========================================
  Files            70       70
  Lines          1232     1232
  Branches        125      125
=========================================
  Hits            889      889
  Misses          311      311
  Partials         32       32

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2cd394...b53cc10. Read the comment docs.


3.11 windows builds

fix #260

waiting for https://github.com/PyO3/maturin/issues/1221

Codecov Report

Merging #311 (6265867) into main (8f2daf6) will decrease coverage by 0.03%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #311      +/-   ##
==========================================
- Coverage   97.36%   97.33%   -0.04%
==========================================
  Files          55       55
  Lines        6344     6346       +2
  Branches       45       44       -1
==========================================
  Hits         6177     6177
- Misses        167      168       +1
- Partials        0        1       +1

Impacted Files
Coverage Δ

pydantic_core/core_schema.py
99.51% <0.00%> (-0.49%)
:arrow_down:

src/input/input_python.rs
98.19% <0.00%> (ø)

src/errors/kinds.rs

src/errors/types.rs
78.24% <0.00%> (ø)

src/errors/location.rs
98.18% <0.00%> (+0.06%)
:arrow_up:

src/errors/value_exception.rs
94.56% <0.00%> (+0.24%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f2daf6...6265867. Read the comment docs.

@messense any idea why aarch64 on macos is suddenly missing a 3.7 interpreter?
I'm happy to drop this case, but just wanted to check why this is happening.

aarch64 macos only supports Python 3.8 and later versions.


Don't overwrite browser zoom shortcuts

Some browsers enable the user to set the zoomlevel of the website using Ctrl and + or -. The default version of KeyboardZoom catches these keydown events and adjusts the map zoomlevel. There might be a situation where a user wants to increase or decrease the size of e.g. the controls as well. They are not able to do this via shortcuts because they are handled by OpenLayers. To get around this, I suggest that the default KeyboardZoom should only adjust the zoom level if + or - was pressed without Ctrl being pressed at the same time. This way, the event is raised to the browser if Ctrl was pressed, too.

I‘d suggest fixing this directly in KeybordZoom.js, because it‘s the documented and expected behavior.

True - I adjusted the code according to your suggestion.

Many keyboard layouts use the shift key to access +.  Using noModifierKeys alone will prevent that working.  It will need a custom function such as
 function (mapBrowserEvent) {
      return (
        (noModifierKeys(mapBrowserEvent) || shiftKeyOnly(mapBrowserEvent)) && targetNotEditable(mapBrowserEvent)
      );
 }

Many keyboard layouts use the shift key to access +.

That's a good point! I extended the filter criteria to allow shift. I did this using a custom function as you suggested. I had the feeling that it could also be an option to add another ol/events/condition like noPlatformModifierKey. However, as this is my first PR to the project I wasn't sure if you prefer not to have such an additional Condition if it's only used at a single location in the code.

@fjellfly I think having a platformModifierKey condition would make sense, which returns true when the Ctrl (or Command on Mac) modifier key is pressed.

@fjellfly I think having a platformModifierKey condition would make sense, which returns true when the Ctrl (or Command on Mac) modifier key is pressed.

Okay, I added a platformModifierKey condition that is used to prevent zoom if ctrl/meta is pressed.

@fjellfly There is a minor issue with the new test: on a Mac, it will fail. Instead of testing with the Ctrl key hard coded, the Ctrl or Cmd key should be used, depending on the platform. Would be great if you could create a small follow-up pull request to fix that.

@fjellfly There is a minor issue with the new test: on a Mac, it will fail. Instead of testing with the Ctrl key hard coded, the Ctrl or Cmd key should be used, depending on the platform. Would be great if you could create a small follow-up pull request to fix that.

@ahocevar Oh, of course, here is a fix for that.


Dual termostat heat and cool with only one switch

Hello,m i have aeroterm machine, with radian floor, I have a solenoid valve and a thermometer in each room. I config a dual termostac for each room, but only can change from off to heat mode, because y only have one switch for heat and cold, is the same switch.
Is it possible to configure hot and cold mode with a single switch?
or i hve to config one termostac to cool mode and another to heat mode.
thanks

I am not familiar how your machine works. Could you exolain how it works? Is it a heater?

Hello, is a heat pump air/water, my system is vaillant, and can change parameters with ebusd addon in HA, but only can manage one room.  the model is Vaillant aroTHERM VWL 115/2 + UniTOWER VIH QW 190/1 E.
This system need radiant floor, and heat or cold the liquid.
I prefer manage the rooms separately, so install a rele in each solenoid valve, this rele open or close the room circuit, so i connect in HA ble termometer for manage it, so i config the dual termostat, but i have only one switch (rele), so i only can turn off or heat.

I see. In this case you must set some helper entities in Home Assistant to make it work.

You need an automation that changes the HVAC mode on the thermostat to the current HVAC mode of the heat pump(HEAT/COOL)
The thermostat can do the rest.

If you try to control the heat pump per room, you will not be able to do heating and cooling at the same time. But maybe it's not required after all.
So if you want the thermostat to control your heat pump:

you need a switch that runs a script on the ON and OFF state for both the heater and cooler switch entities.
the script must set the heat pump to heat or cool and set the valve state for the room on/off

Obviously, the switches should work the opposite way in regards to the HVAC mode of your heat pump.
I hope this makes sense.

thanks for your answer, and sorry for my english ;)
You are on the correct way, the heat pump only change mode two times a year, so this is no the problem.
I only want to change hvac mode in dual termostat i had create for each room. I think about your idea to make a script ot  create a false switch to use in cold mode, that control the original switch that i use to heat mode, that work in the opposite way.
i´ll try this idea.

you can create a new helper using "Change device type of a switch" and set it as light, after that you can use the normal switch as cooler and the helper as heater


Allow config to be derived from defaults using functions

This PR is intended to allow configuring the tokens in classy-ui.config.js using functions as the return values. This allows people to derive tokens from defaultTokens without requiring to import classy-ui/tokens. This can be done on a per token-category basis as well. The functionality it allows is:
module.exports = {
  tokens: {
    spacing: spacing => ({
      ...spacing,
      oneLine: "32px",
      twoLines: "64px",
      threeLines: "96px",
      fourLines: "128px"
    }),
  }
};

const theme = require("./src/core/theme");

module.exports = ({ tokens: defaultTokens }) => ({
  tokens: {
    ...defaultTokens,
    colors: theme.colors,
    spacing: spacing => ({
      ...spacing,
      oneLine: "32px",
      twoLines: "64px",
      threeLines: "96px",
      fourLines: "128px"
    }),
    lineHeight: (lineHeight) => ({
      ...lineHeight,
      ...defaultTokens.spacing,
      oneLine: "32px"
    }),
    fontSizes: {
      ...defaultTokens.fontSizes,
      size: fontSizes
    }
  }
});

Sorry for the poorly named PR and description, this is my first PR to an OSS project :P

Hi @nksaraf and thanks so much for your suggestion! I think you did a great job explaining this 😄
We actually did have a callback version previously, but it was dropped for just doing:
const defaultTokens = require('classy-ui/tokens').default

module.exports = {
  tokens: {
    ...defaultTokens,
    opacity: {
      NONE: '0',
      FADED: '0.75',
      FULL: '1'
    },
  }
}

Though, what I do not quite like about the approach we have in our current version is the .default you need on the end there. Also I like what you did  here separating internals of classy-ui and what you want to use yourself.
One complexity I think we can do without though is also having callbacks for each token category.
So:
const theme = require("./src/core/theme");

module.exports = ({ tokens: defaultTokens }) => ({
  tokens: {
    ...defaultTokens,
    colors: theme.colors,
    spacing: {
      ...defaultTokens.spacing,
      oneLine: "32px",
      twoLines: "64px",
      threeLines: "96px",
      fourLines: "128px"
    },
    lineHeight: {
      ...defaultTokens.lineHeight,
      ...defaultTokens.spacing,
      oneLine: "32px"
    },
    fontSizes: {
      ...defaultTokens.fontSizes,
      size: fontSizes
    }
  }
});

Lets you do whatever you want and there is less documentation and options to choose from :) Basically we allow you to define your config as a function which receives the base config :)
Does that make sense? I did push an update today which changes out the tokens a bit. The reason is that we lean on system-ui which is a set of token categories. Also we use the 10 system.... will be explained in docs very soon :-)

I removed the option for functions for specific token categories. I do agree that it adds unnecessary complexity.
Also thank you so much for the response! This library is so awesome (my favorite part is you can just tab your way through styling).

Also with the current version, and I raised an #24 because I was not being able to import the tokens package, (actually couldn't find it in node_modules either)

Hi again @nksaraf,
Yeah, this tokens thing is a bug, but with your version here it becomes easier to manage this anyways :)
Lets get this in and ship final beta before we create our release candidate 🎈 👍


bootstrap 4 support validation

bootstrap 4 comes with new classes to the input control in order to add an icon feedback (such as v or x marks along with green/red colors)
the classes are :
form-control-success and form-control-danger which should be attached to the input element.
currently the module does not add these class which results in no mark feedback only different border colors (green/red)
I will be happy to create a pull request to support this.
The classes will be added and they will do nothing for those who uses bootstrap 3
@1000hz  is it ok by you ? or you wanna do it ?
see https://v4-alpha.getbootstrap.com/components/forms/#validation

The plugin won't support Bootstrap v3 and v4 simultaneously. v4 uses class names from v3 in slightly different ways which would cause problems. When v4 leaves alpha I'll work on a version of the plugin for it, but for now it remains unsupported. See https://github.com/1000hz/bootstrap-validator/pull/292#issuecomment-261304888 for more details.


Bucket Class details page doesn't have the complete details in UI

Added "Edit Bucket Class resources" modal to details page action Kebab.

/approve
/lgtm
/override ci/prow/odf-console-e2e-aws

/override ci/prow/odf-console-e2e-aws
/lgtm

/cherrypick release-4.11

/cherrypick release-4.11-compatibility


Make sure "TITLE" & "GRAPHIC" SIZE is consistent across pages

https://threefold.io/public/#/partners has bigger TITLE size and very small GRAPHIC size as compared to other pages.
Lets make it more consistent
i.e. make font size same then on other pages' titles + increase design size to match other pages intro...

we made this design according to this issue https://github.com/threefoldfoundation/www_tfgrid/issues/120 by @maximilianrang
they need testimonials at header
so put testimonials blow the header banner ?

Just changing the fontsize should work.

font size updated

Increase size of current graphic @ partner page by about 50% and cut spacing between text and testimonials by 1/2


Gradianto isn't the same as the screens

Hello,
I installed the Gradiento theme but it doesn't look like the screens.
Gradiento in my spotify:

I didn't touch anything in the color.ini or user.css.
Thanks!

Maybe you forgot to run spicetify apply


change repo name and module API

Hi, as discussed here (https://github.com/INT-NIT/AnDOCreator/issues/1), we need to

rename this repo to AnDO

rethink the structure of the code, to make the three tools (Checker, Generator, Viewer) exist at the same level of hierarchy... also, before doing this fairly vast refactoring of the code, let's discuss and decide on which API we want to settle... how do we want to import these tools?

from AnDO import Generator (and the same with the two other tools)
or are there other options? @JuliaSprenger @Slowblitz

let us discuss the name Checker vs Validator... indeed, as @JuliaSprenger mentioned in the other discussion, Validator might be better, but we had just chosen Checker to distinguish this from what exists in BIDS... WDYT?

Yes, I agree with the suggestions for renaming this repo to AnDO. However, I don't have the rights to do this so one of you has to use your power. I can take care of renaming the modules.

Yes, I agree with the suggestions for renaming this repo to AnDO. However, I don't have the rights to do this so one of you has to use your power. I can take care of renaming the modules.

ok, I just changed the name of the repo...

ok, I just changed the name of the repo...


"hashValues" should use "identical" instead of ==

Currently, the implementation of dart:ui's hashValues function compares the passed in object with _hashEnd, like this:
if (arg03 != _hashEnd) {
  result = _Jenkins.combine(result, arg03);
  …
}

Let's say you have a class like the following:
class EqualToEverything {
  bool operator ==(Object other) => true;
  int get hashCode => 42;
}

Of course, that's a bad implementation of the == operator. 😄 I'm just saying that an implementation of hashValues that compares the arguments to _hashEnd using a flipped comparison (_hashEnd == arg03) wouldn't have any disadvantages compared to the current implementation but does behave more deterministic with regard to this one special case.

Another (and faster) alternative is to use identical for the comparisons.

I think that identical and == should have the same  performance for primitive types? I guess one way to check would be to look at the generated code

@jonahwilliams Wouldn't this better filed at the Dart repo? or is dart:UI only flutter? I don't think this qualifies as an engine topic, does it?

hashValues is implemented in dart:ui which is I'm the engine

dart:ui no longer uses HashValues, closing as obsolete


Analytics

Analytics for open, screen shots on texts and snaps.  Can we get some of these stats using the api?

You can. By calling GetUpdates and iterating through the arrays

On 6/11/2015, at 10:27, phplab83<EMAIL_ADDRESS>wrote:
Analytics for open, screen shots on texts and snaps. Can we get some of these stats using the api?
—
Reply to this email directly or view it on GitHub.

but in getupdates there is no data return
can you please guide me any how the exact array return?

log the GetUpdates or GetConversation functions to see them first, and search for the info there.

On 6/11/2015, at 10:48, mgp25<EMAIL_ADDRESS>wrote:
Closed #256 https://github.com/mgp25/SC-API/issues/256.
—
Reply to this email directly or view it on GitHub https://github.com/mgp25/SC-API/issues/256#event-456927940.

Pilo Basualdo

when i am call this its not return anything.. Please help me on this.
$updates = $this->getUpdates();
echo "";
print_r($updates);
exit;

you are then doing something wrong

On 6/11/2015, at 10:55, phplab83<EMAIL_ADDRESS>wrote:
when i am call this its not return anything.. Please help me on this.
$updates = $this->getUpdates();
echo "
";
            print_r($updates);

            exit;

—
Reply to this email directly or view it on GitHub https://github.com/mgp25/SC-API/issues/256#issuecomment-154415405.

Pilo Basualdo

@phplab83 first of all: learn php, once you know, come back here and ask API questions not PHP.
//considering $snapchat has the instance

$updates = $snapchat->getUpdates();
print_r($updates); // you can also use var_dump


Kerberos authentication - Elasticsearch & Kibana

I have installed SearchGuard into Elasticsearch and Kibana then set to use Kerberos. When I start kibana, it says Authentication Exception
Here are the configuration I did:
Elasticsearch.yml
cluster.name: aaa
node.name: aa
network.host: 192.168.1.x
http.port: 9201
transport.tcp.port: 9301
cluster.initial_master_nodes: aa

I am using the certificates generated using the searchguard-tlstool.
I have also added the below in the elasticsearch.yml
searchguard.kerberos.acceptor_keytab_filepath: <filename>.keytab
searchguard.kerberos.acceptor_principal: 'HTTP\localhost'
searchguard.kerberos.krb5_filepath: krb5.conf

In the sg_config.yml file: I have changed the following
authc:
   kerberos_auth_domain:
     http_enabled: true
     transport_enabled: true
     order: 1
     http_authenticator:
       type: kerberos
       challenge: true
       config:
              krb_debug: true
              strip_realm_from_principal: true
    basic_internal_auth_domain:
       http_enabled: true
       transport_enabled: true
       order: 0
       http_authenticator:
          type: basic
          challenge: false

everything remains the same for the sg_config.yml
Kibana.yml
server.port: 5602
server.host: "<IP_ADDRESS>"
elasticsearch.hosts: ["https://192.168.1.x:9201"]
elasticsearch.preserveHost: true
kibana.index: ".kibana"
elasticsearch.requestHeadersWhitelist: ["Negotiate Authorization"]
searchguard.auth.type: "kerberos"

I am using Elasticsearch and Kibana version 7.1

Kerberos is sometimes hard  to debug, but at first glance, it seems the elasticsearch.requestHeadersWhitelist is not correct.
"Negotiate" is actually part of the response, not the request. The header for the request is "Authorization". Since this is also the default setting of elasticsearch.requestHeadersWhitelist,  you  can simply try to remove:
elasticsearch.requestHeadersWhitelist: ["Negotiate Authorization"]
from your kibana.yml. Or, if you  want to make it more explicit:
elasticsearch.requestHeadersWhitelist: ["authorization"]
If you still have no luck please also post the ES log files.


CI:add main tigger to unittest

And test codecov function .

Codecov Report

Merging #2543 (fe9196b) into main (b1e5ebf) will decrease coverage by 1.75%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2543      +/-   ##
==========================================
- Coverage   61.52%   59.76%   -1.76%
==========================================
  Files         138      138
  Lines       25698    23219    -2479
==========================================
- Hits        15810    13877    -1933
+ Misses       8030     7547     -483
+ Partials     1858     1795      -63

Impacted Files
Coverage Δ

pkg/sync/config.go
0.00% <0.00%> (-83.34%)
:arrow_down:

pkg/object/minio.go
61.29% <0.00%> (-15.19%)
:arrow_down:

cmd/sync.go
56.46% <0.00%> (-12.87%)
:arrow_down:

pkg/chunk/utils_linux.go
66.66% <0.00%> (-8.34%)
:arrow_down:

cmd/version.go
42.85% <0.00%> (-7.15%)
:arrow_down:

pkg/utils/utils.go
69.81% <0.00%> (-6.76%)
:arrow_down:

pkg/object/file.go
65.76% <0.00%> (-6.71%)
:arrow_down:

pkg/chunk/utils_unix.go
66.66% <0.00%> (-6.67%)
:arrow_down:

pkg/meta/tkv_tikv.go
61.90% <0.00%> (-6.31%)
:arrow_down:

pkg/utils/logger_syslog.go
42.30% <0.00%> (-5.97%)
:arrow_down:

... and 127 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


No error output at all

My upload command stopped working:
I run gradle install then gradle bintrayUpload:
$ gradle bintrayUpload
Deprecated Gradle features were used in this build, making it incompatible with Gradle 5.0.
See https://docs.gradle.org/4.5/userguide/command_line_interface.html#sec:command_line_warnings

BUILD SUCCESSFUL in 0s
25 actionable tasks: 2 executed, 23 up-to-date

Here's the end of the verbose output:
7:53:51.754 [DEBUG] [org.gradle.launcher.daemon.server.exec.ExecuteBuild] The daemon has finished executing the build.
17:53:51.761 [DEBUG] [org.gradle.launcher.daemon.client.DaemonClientInputForwarder] Dispatching close input message: org.gradle.launcher.daemon.protocol.CloseInput@79d30a26
17:53:51.761 [DEBUG] [org.gradle.launcher.daemon.client.DaemonClientConnection] thread 14: dispatching class org.gradle.launcher.daemon.protocol.CloseInput
17:53:51.761 [DEBUG] [org.gradle.launcher.daemon.client.DaemonClient] Received result Success[value=null] from daemon DaemonInfo{pid=48315, address=[c17927b2-ef6b-4e36-acb2-10baebef4915 port:49648, addresses:[/0:0:0:0:0:0:0:1, /<IP_ADDRESS>]], state=Idle, lastBusy=1517277225110, context=DefaultDaemonContext[uid=08d8189b-d075-496a-a3f9-fe81505102b4,javaHome=/Library/Java/JavaVirtualMachines/jdk1.8.0_112.jdk/Contents/Home,daemonRegistryDir=/Users/ben/.gradle/daemon,pid=48315,idleTimeout=10800000,daemonOpts=-XX:+HeapDumpOnOutOfMemoryError,-Xmx1024m,-Dfile.encoding=UTF-8,-Duser.country=US,-Duser.language=en,-Duser.variant]} (build should be done).
17:53:51.761 [DEBUG] [org.gradle.launcher.daemon.client.DaemonClientConnection] thread 1: dispatching class org.gradle.launcher.daemon.protocol.Finished
17:53:51.762 [DEBUG] [org.gradle.launcher.daemon.client.DaemonClientConnection] thread 1: connection stop

It does not upload the artifacts, I also don't see any error message or warning that could be related... What can I do to debug the issue?

Could this be the same issue as https://github.com/bintray/gradle-bintray-plugin/issues/170 ?


Testing PR

Testing PR that showcases that the generated SARIF results work with GitHub actions. I couldn't use pyre because building from source was havoc and the new changes haven't been landed yet!
This PR should never be merged. Only view the sarif file.

The analysis not found is because this is the first time a sarif result was uploaded from this repository (the fork) via GitHub actions.


lnrpc+rpcserver: expose short chan id on feereport

This commit adds each channel's short chan id to the feereport rpc.
Without this, it can be tedious to lookup more info about a particular
channel since most rpcs only accept short chan ids and not channel
points. For instance, now one can take a channel id from feereport and
look it up directly via getchaninfo to examine the policy in more detail.

Two reviewers already, unassigning myself


merge from arlac77/template-github,arlac77/template-kronos-module

package.json

chore(package): add ^12.3.0 remove ^12.2.0 (devDependencies.documentation)

Codecov Report

Merging #609 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #609   +/-   ##
=======================================
  Coverage   99.04%   99.04%
=======================================
  Files           1        1
  Lines         105      105
  Branches       11       11
=======================================
  Hits          104      104
  Misses          1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77d97b8...38cc9cb. Read the comment docs.

:tada: This PR is included in version 5.0.18 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Serialize CircuitGraph to QASM

Description of the Change:

Adds CircuitGraph.to_openqasm() method, which serializes the circuit graph as an OpenQASM string. A dummy 'QASM Serialization' device is also created, allowing the serialization method to take advantage of built-in decomposition logic. For example:
>>> dev = qml.device("default.qubit", wires=2)
>>> @qml.qnode(dev)
>>> def qnode(x, y, z):
...    qml.Rot(x, y, z, wires=1)
...    return qml.expval(qml.PauliX(0))
>>> qnode(0.3, 0.1, 0.2) # construct the qnode
>>> print(qnode.circuit.to_qasm())
OPENQASM 2.0;
include "qelib1.inc";
qreg q[2];
creg c[2];
rz(0.3) q[1];
ry(0.1) q[1];
rz(0.2) q[1];
h q[0];
measure q[0] -> c[0];
measure q[1] -> c[1];

Adds circuit_graph/test_qasm.py test file, containing three test classes:

Unit tests, directly testing the CircuitGraph.to_openqasm() method

Integration tests, checking that QASM serialization continues to work when the circuit is created via a QNode.

Conformance tests, to ensure that the generated QASM is valid and agrees with that generated by the PennyLane-Qiskit plugin.

Adds the self.num_wires attribute to the CircuitGraph, so that the number of wires in the graph can be extracted.

Benefits:

Provides a circuit serialization method that conforms to the OpenQASM standard, allowing easy integration with plugins that support QASM.

Possible Drawbacks:

Currently, the QASM serialization assumes that the qelib1.inc file is included, which contains additional gate definitions. Some implementations of QASM might not provide this header file, or may support additional gate definitions.

PennyLane currently does not have an in-built decomposition for arbitrary unitaries, so QubitUnitary is not supported.

The conformance tests require PennyLane-Qiskit and Qiskit.

The generated QASM string does not take into account QNode variables; all QASM gate parameters will be numeric, and the QASM string will be re-generated every time the method is called. A future optimization could perform 'parametric serialization', similar to the parametric compilation performed by the Forest plugin.
In this case, serialization would only happen on the first call, with free parameters encoded as QASM variables. Another CircuitGraph method could be used to get a dictionary of QASM variables to numeric values.
E.g., in Qiskit:
>>> from qiskit.circuit import Parameter
>>> from qiskit import QuantumCircuit
>>> theta = Parameter('θ')
>>> angle = 0.5
>>> qc = QuantumCircuit(2)
>>> qc.rz(theta, [0])
>>> print(qc.qasm())
OPENQASM 2.0;
include "qelib1.inc";
qreg q[2];
rz(θ) q[0];

However, it is unclear if the benefits of supporting 'parametric serialization' are significantly useful or not, so I suggest leaving this as a future possible enhancement.

Related GitHub Issues: n/a

@co9olguy: I'm marking this PR as 'on-hold' until the next release, unless you feel this would be priority to have in this release.

moving the conformance tests to PennyLane-Qiskit (as was something we did with circuit conversion tests)

I think the main difference is in that case is that the conversion logic actually lives in the PennyLane-Qiskit plugin, with PennyLane core just having a UI entry point (that isn't created until PennyLane-Qiskit is installed). In this case, the logic and the UI lives in PennyLane core.
I tend to be in favour of having the tests in the same location as where the logic lives, as changes to the logic should result in a test failure straight away.