chore: setup commit hooks with lint-staged

:tada: This PR is included in version 3.10.3 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Feature/session-replay/compound-button-mappers

What does this PR do?
Merge feature branch of session replay compound button and switch compat mapper into develop
Motivation

RUM-4718
RUM-4716
RUM-4715
RUM-4717

Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] Make sure you discussed the feature or bugfix with the maintaining team in an Issue
[ ] Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

Codecov Report
Attention: Patch coverage is 69.64286% with 51 lines in your changes missing coverage. Please review.

Project coverage is 69.46%. Comparing base (d2a5741) to head (747a877).
Report is 25 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2120      +/-   ##
===========================================
- Coverage    69.84%   69.46%   -0.38%
===========================================
  Files          715      715
  Lines        26577    26588      +11
  Branches      4457     4468      +11
===========================================
- Hits         18561    18467      -94
- Misses        6821     6895      +74
- Partials      1195     1226      +31

Files
Coverage Δ

.../sessionreplay/internal/DefaultRecorderProvider.kt
93.16% <100.00%> (+0.12%)
:arrow_up:

...nreplay/internal/recorder/mapper/CheckBoxMapper.kt
100.00% <100.00%> (ø)

...ternal/recorder/mapper/CheckableWireframeMapper.kt
100.00% <100.00%> (ø)

...play/internal/recorder/mapper/RadioButtonMapper.kt
66.67% <100.00%> (-33.33%)
:arrow_down:

...roid/sessionreplay/internal/utils/DrawableUtils.kt
93.75% <50.00%> (-1.49%)
:arrow_down:

...nternal/recorder/mapper/CheckableTextViewMapper.kt
59.26% <91.30%> (-37.29%)
:arrow_down:

.../internal/recorder/mapper/CheckedTextViewMapper.kt
78.12% <55.56%> (-17.53%)
:arrow_down:

...lay/internal/recorder/mapper/SwitchCompatMapper.kt
92.31% <89.74%> (+2.39%)
:arrow_up:

...l/recorder/mapper/CheckableCompoundButtonMapper.kt
37.93% <23.40%> (-56.81%)
:arrow_down:

... and 25 files with indirect coverage changes


Add more clients into PropertiesConfigFactory

Add the following:

DropBox
Github
Yahoo
Google
FourSquare
Windows Live

Adding more clients would be great. But I think we need a better way to be able to configure almost anything like a LdapAuthenticator. My best thought so far was to define the configuration as a Groovy script (greatly inspired by what you did in CAS ;-)

Help me understand this better please: how do you envision a groovy script doing client registration?

Sure. Currently, we have the ConfigFactory interface to implement to build a Config:  https://github.com/pac4j/pac4j/blob/master/pac4j-core/src/main/java/org/pac4j/core/config/ConfigFactory.java This is used for the J2E implementation.
So the idea would be to create some Groovy class extending the ConfigFactory to build the Config and indicate the path to this Groovy class. That said, I was thinking of Groovy as it feels more dynamic, but it could maybe be in Java or in Javascript using the capabilities of the JVM.

OK, I think I understand. Few concerns there:

A groovy implementation of the config factory, as you noted, may point to some custom groovy script that builds and loads clients. Problem with that approach (regardless of whether it's groovy or JS, etc) is that someone has to write that script! I wouldn't want that, ever :) I'd much rather we ship "preconfigured" clients that folks can easily configure with key=value type of settings.

Let developers write the groovy implementation and everything that follows afterwards.

Doing this via properties and such has the advantage of leveraging spring boot/cloud to proxy those beans and make them dynamic. A groovy/JS script basically amounts to the same thing, but on a more complicated level.

If as we expect developers to write a groovy script that is loaded by the groovy ConfigFactory, why wouldnt they just write the thing in Java to begin with?! Specially if your target audience are developers with the know-how, why introduce a level of indirection for folks who are expected to use APIs directly?

OK. I understand. So how do we handle advanced use cases with properties? Like setting a bean as the property of another bean. I think we would be very close to the INI configuration system of Shiro, wouldn't we?

On a case by case works best I think. Two approaches:

The autoconfiguration of clients must account for advanced scenarios like that of above as you describe. It should be smart enough to autoconfigure the context and prep all beans and dependencies based on "guessing" what the ultimate intention is. If one isnt happy with that guess and how we think that client should work best, they can always tune it manually. We don't have to support every property and every feature of every client. Just what makes sense for the most.
We should design clients that do not have advanced requirements like that, to make #1 easier. Keep them simple as much as possible. A client that can accept and has 5 bean dependencies on other objects is much harder to construct with an opinion in mind than a client that just has a few boolean/string fields. I'd even argue that design is easier to work with anyway, regardless of approach here anyway.

Eventually at some point, we'll extract a more comprehensive design out of all this. At this point, I think it's too soon to provide a super comprehensive flexible platform to handle all. Let's collect use cases and clients that folks are most interested in. Figure out who our majority are.

Regarding point 2, I agree: we should design as simple as possible clients. Though, on the other side, we don't want to reinvent the wheel and use well-known libraries for the plumbery, like Ldaptive for the LDAP support. In that case, we have indeed a very simple LdapAuthenticator, but the Ldaptive Authenticator configuration is complex.
But yes, let's start small and see what happens...


[mesheryctl]: lint checks failing

See mesheryctl Command Tracker for current status of commands.
Current Behavior
Several lint checks are failing in the recent GitHub Actions run for mesheryctl. This issue is linked to the following GitHub Actions run: link to the GitHub Actions run.

Environment

Host OS: Mac Linux Windows
Meshery Server Version: stable-v
Meshery Client Version: stable-v
Platform: Docker Kubernetes

Contributor Guides and Handbook

📚 mesheryctl Contributing Guide
📺 Beginner's guide to contributing to Meshery and mesheryctl
⌨ mesheryctl Command Tracker
⌨ Meshery CLI Commands and Documentation
🙋🏾🙋🏼 Questions: Discussion Forum and Community Slack

@RipulHandoo Maybe I can give it a try for it.


Test-driver failed due to an ion-python incompatible issue

Test driver failed after upgrading python and ion-python version.
It's not because of test-driver itself or any files fails the tests. From the log,

amazon.ion.exceptions.IonException: IERR_INVALID_ARG assertion failed: len == 1

It's because test-driver's use case (maybe --equiv mode?) is incompatible with ion-python 0.9.x. Need more investigation.
Example workflow,
ion-java - https://github.com/amzn/ion-java/actions/runs/3039157212/jobs/4893762191
ion-js - https://github.com/amzn/ion-js/actions/runs/2000741133/jobs/2872821385

Downgraded ion-python version 2fdac20 and a successful workflow - https://github.com/amzn/ion-java/actions/runs/3325129408/jobs/5497475141
Refer to https://github.com/amzn/ion-python/issues/218 to see why ion-test-driver cannot work with C extension.


fix: fix get txs test

Remove check that txs were inserted after new --- this tests new, which is out of scope.
use check_mempool_txs_eq to check mempool contents.

This change is

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 75.97%. Comparing base (52a30e1) to head (5c2055a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #294   +/-   ##
=======================================
  Coverage   75.97%   75.97%
=======================================
  Files          28       28
  Lines        1386     1386
  Branches     1386     1386
=======================================
  Hits         1053     1053
  Misses        275      275
  Partials       58       58

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Updated link for Consumption Credit rates

old link, update with new Teams page.

@benhopperau - thanks for contributing to the content, much appreciated!  One note, it is best to remove the /en-us/ from the link so then the link will open in whatever the language is the person is using in their web browser.
@LolaJacobsen and @CarolynRowe - let me know if link is correct and I can merge and remove the /en-us/. Thanks!

Thanks for the tip on the language, great to know!
I'll keep that in mind for future
On Thu, 8 Nov. 2018, 7:49 am Ken Withee<EMAIL_ADDRESS>wrote:

@benhopperau https://github.com/benhopperau - thanks for contributing
to the content, much appreciated! One note, it is best to remove the
/en-us/ from the link so then the link will open in whatever the language
is the person is using in their web browser.
@LolaJacobsen https://github.com/LolaJacobsen and @CarolynRowe
https://github.com/CarolynRowe - let me know if link is correct and I
can merge and remove the /en-us/. Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/OfficeDocs-SkypeForBusiness/pull/1029#issuecomment-436790014,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEOLsfKGZ8Nc5e6VWAPQyVbaS6MsAOLqks5us1V4gaJpZM4YSS_4
.

@LolaJacobsen and @CarolynRowe Can I merge this?

@CarolynRowe - this is your area.

@benhopperau - confirmed with Lola and merged this one. One note is if you can remove the   en-us   on a PR that will let people in other locales have it load in their language. Thanks for your work on this, much appreciated!


HERO BANNER: Implement Hero Banner Variant MEDIUM

@twhite313 Do we care to work on a MEDIUM variant for HERO Banner?
https://www.esri.com/en-us/capabilities/mapping/overview (hero banner medium variant example)
https://main--esri-eds--esri.aem.live/en-us/capabilities/mapping/overview

I'm not worried about supporting all of the possible options. Let's just make sure that what we have matches the live page


Remove .validation for manifests\b\ByteDance\BytedanceMiniappIDE - Empty directory

Microsoft Reviewers: codeflow:open?pullrequest=https://github.com/microsoft/winget-pkgs/pull/115565&drop=dogfoodAlpha

[Policy] Needs Manual Merge


fixed compile errors and exaStamp compatibility

@carrardt compilation issue in exaDEM -> see github actions.
   >> 598    /home/runner/work/exaNBody/exaNBody/spack/opt/spack/linux-ubuntu22.
            04-zen2/gcc-12.3.0/exanbody-main-pnnuzywskljin6oa25uo5iz6u3zuhwmn/s
            rc/exanb/compute/include/exanb/compute/compute_cell_particles.h:190
            :37: error: 'dims' was not declared in this scope
     599      190 |     PForFuncT pfor_func = { cells , dims , gl , func , cpfi
            elds, filled_cells };


Task: Local pining cluster test

The task at  hand is to test the Local Pinning feature in the cluster level with all the protocols working.
Pre-conditions:

A connected cluster (if kademlia is used, let it saturate for sometime)
Each node should be configured to have a small DB capacity (ex: 500 chunks)
Upload a chunk in node A and download it from node B, just to see if everything is fine

Pinning Testcase 1:

pick a node (Node A) and upload small file (ex: 10 chunks) and pin it
upload a larger file below the DB capacity (ex: 100 chunks) in node A
download the small file and check if it is found and check in the pinning list API

Pinning Testcase 2:

pick a node (Node A) and upload small file (ex: 10 chunks) and pin it
upload a larger file below the above the DB capacity (ex: 1000 chunks) in node A
download the small file and check if it is found and check in the pinning list API

Pinning Testcase 3:

pick a node (Node A) and upload small file (ex: 10 chunks) and pin it
upload a larger file below the above the DB capacity (ex: 1000 chunks) in node A
upload many larger files above the DB capacity in node A
download the small file before every large file upload and check if it is found and check in the pinning list API

Acceptance criteria

Leave the cluster for sometime (depends on our infra cost)
Download the small file from Node A and see if it can be downloaded

Failure case:
If at any time, the smaller file cannot be downloaded, then pinning failed.
Unpinning Testcase 1:

pick a node (Node A) and upload small file (ex: 10 chunks) and pin it
upload a larger file below the above the DB capacity (ex: 1000 chunks) in node A
download the small file and check if it is found and check in the pinning list API
unpin the file using the API
upload muliple larger file below the above the DB capacity (ex: 1000 chunks) in node A
download the small file and it should not be present

Add a flag during startup to specify the dbCapacity (@jmozah )

Blocked by #259

Merged into beekeeper

@mortelli , could you have a look on whether this integration test covers the scenario, as discovered in global pinning in Swarm?

Also make an issue to have a look at this from more theoretical perspective (based on comment @acud)

so this is what we gathered together with @acud after taking some time looking at the code:
Pinning Test Case n°3
Retrieval of the pinned file should be done only after uploading all of the larger files, not after each one.

We could keep this test case as is, or alternatively take this idea for a 4th test case instead.
Cluster test bugs
Size
It appears file sizes are taken in bytes, rather than chunks. This means that tests need to be updated so that they use the swarm chunk size when calculating the file size to be uploaded.
Pinned chunks
Also, it seems only the root chunks of the files to be pinned are actually pinned, rather than all of the chunks that make up the file. As far as we know, there is no "pin file" operation, but rather a "pin chunk" operation, so this is an expected (but incorrect) behavior for these test cases.
A bug could arise if the pinned files are big, since the more chunks that make up a file, the greater the chance that they are garbage collected and the file cannot be retrieved due to only having its root chunk pinned.
We could create a test case that pins big files instead of just small ones.
Design flaw: race conditions
We believe the current local pinning implementation has a race condition built-in in the design. There are 2 scenarios under which we understand that content can be gc'd after being uploaded but before being pinned.
This is not so relevant for the operation of pinning content previously uploaded, as these are 2 separate operations (first upload, then pin after x time has passed) and a failure in the second one is more acceptable (i.e. attempt to pin → sorry, can't find the chunk).
 For this, the storage should be at its limit and other parallel uploads can take place so that the GC is triggered.
Scenario II
Same as scenario I, but having the file push synced rather than accessed. This would also put the chunks up for garbage collection.
Testing
We can both aim at having these scenarios as beekeeper tests, as well as attempt to manually trigger them.
Proposal
The solution to this problem would be to have the upload and pin operation executed in an atomic manner, rather than sequentially as 2 (internal) operations based on a single API call.
We could have a pin flag set by HTTP request headers and condense the upload and pin operations into a single one, so that on each call to the localstore which uploads the chunks, they are immediately pinned too.
Additionally, this would allow us to place the uploaded content into the GC right after it is uploaded, regardless of whether it is accessed (or maybe even synced).

@mortelli  First, test case 3 never says to download the small file after every upload of the large file. It clearly says to download the file as the last step.
Secondly, the design flaws you pointed is in the old Swarm code, why are we even talking them here.
We should say, we are yet to implement local pinning for /files, /bytes and /bzz api's.

Hi @jmozah , afaik, the pinning has been mostly taken from Swarm in it's current form and, hence, design flaws there mean design flaws in Bee.
This analysis is not personal to you or your code in any way, it is a thorough analysis of a feature which is crucial to get right.
I believe @mortelli and @acud have done a good job, inspecting the code and writing down the conclusions here. They are a good basis to improve upon local pinning.
Constructive comments from you on the content of this ticket are very welcome, of course.

I just spoke with @jmozah to clarify this.
His issue was with the seemingly infeasible test case scenario (pin file), as pinning a file is not even possible in Bee. Having said this, the research is in my opinion still valid, as it of course needs to be solved when we do pinning of a file in Bee.
In all honesty, I was not aware that the pinning operation is solely available on the /chunks endpoint in the current code and pinning on our other upload endpoints should be supported as well.
If the described design flaw is still possible on the /chunks endpoint only, I believe we should fix it right now. If it is not yet possible, I suggest we fix it when we add pinning to the other endpoints (which would enable the scenario).
W.r.t. the cluster test, this should of course be fixed asap and investigated why a faulty test still passes.
Thanks guys and let's keep peace :bird:


users w/o priv_settings can't log in to admin portal - error 500 (Demo)

there are 8 users w/o priv settings on demo. And these users cant log in to admin portal.

In order to perform this action you can use user with email<EMAIL_ADDRESS>request
{
   "token":{
      "grant_type":"password",
<EMAIL_ADDRESS>      "password":"12345678",
      "client_id":"{{fe_client_id}}",
      "scope":"app:authorize"
   }
}

response
{"meta":{"url":"http://demo.ehealth.world/oauth/tokens","type":"object","request_id":"df94e7109bkkgs8tlfb5er740u21uq15","code":500},"error":{"errors":{"detail":"Internal server error"}}}

Problem explored & fixed.


Updating Testing instructions with utils/run-test

Updating Testing instructions with utils/run-test.  I find this utility useful and others might too.

@swift-ci please smoke test

Wow this is nice work!
My friend told me run-test recently.
If it is written in Testing.md, I would have known earlier.


questions regarding coal modeling

It's a coal specific question (not issue) however tightly relevant to android icc APIs.
As to Intent.model of https://github.com/siis/ic3/commit/20e3164ddebfdac08609df5125da3388e00316f5 , some query declarations are Activity specific, but it is modeled as a more general parent class Context, so is it deliberately designed so?
Another question is that some "exit" methods of Activity is ignored, e.g., startIntentSenderFromChild. From android document this api is added from Level 16. In my viewpoint, it should also be intent relevant since it passes an intent and may start another activity similarly.

Hi,
You are correct that some of the method are specific to Activity and not Context. However, since Activity is a subclass of Context this should not be a problem. To be thorough it could be fixed for future versions of IC3.
In general I agree that it would be nice to support methods from new API versions.

@docteau Got it and thanks for the clarification!


Hot reloading seems broken on V6

After fixing #876, I noticed that the hot reloading is having issues in all examples, even the basic one.
The hot reloading module recommends using hot(app) instead of hot(module)(app). But while this does work, it seems to reload the route component only and removes the app html ( for example).
We may need to downgrade the hot reloading to an older version or update our usage to make it work with new version.

Checked, HMR only reload the index.js and App.js. All others not working

Not sure if I can look into it today so made the ticket here so someone else may fix it sooner 😄

This is the same issue that v5 had that was supposedly fixed in v6; did it work at some point?

It's been a constant battle. React hot loader is in disarray right now and
especially is having a hard time with the 16.6 and 16.7 versions of react.
Unfortunately this is an upstream issue for the most part and we'll have to
wait and see what happens but we're going to do everything we can to get it
to work in its current state.
On Tue, Dec 18, 2018 at 9:39 AM Herohtar<EMAIL_ADDRESS>wrote:

This is the same issue that v5 had that was supposedly fixed in v6; did it
work at some point?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/nozzle/react-static/issues/894#issuecomment-448285403,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFUmCYZzENP8ZbohaTd5kL2SAee4ixw_ks5u6Ro1gaJpZM4ZYHQR
.

Disable code splitting on dev should work, doesnt it?

Code Splitting doesn't happen in dev in v6 at all. If you look at tmp/dev-server/react-static-templates.js you'll see it's just raw imports :)

I'm having an issue where I have to re-start the whole server after a few minutes. I'm already refreshing the browser in between edits to see the updates, but after some minutes even the refresh stops working and waiting perpetually for the site to load. Is this related?
Running fresh install with styled-components and Pixelatex's recent edits.

It could be related yes. The hot-reloading like you can see above right now is very finicky. It's honestly never worked quite right since React 16.6 and I have a really good feeling that it's upstream in RHL.
Ultimately, @theKashey would know more about this issue, since he's heading up RHL nowadays. I know he is also working closely with Gatsby to solve this problem on their end, too. It's likely the solution for them will work for us too (probably not as complex to implement though, since the hot-reloading for React-Static lives in user-land, instead of in React-Static)

React-Hot-Loader 4.3.0 and below was not supporting forwardProps, thus StyleComponents were broken.
React-Hot-Loader 4.6.1 and below has a bug if you call hot(module)(app) twice per one module. Resolved in 4.6.2 yesterday - https://github.com/gatsbyjs/gatsby/issues/10528
There is a bug with HOC of different sort (for example Redux), where any your component could replace any your component. Found it just yesterday.

Just give me some example to reproduce, and I'll fix it.

Start with installing react static and running react-static create and
choosing the basic template. From there you can experiment with different
RHL configurations and also try editing any of the src files. It's very
straight forward, almost like CRA.
On Tue, Dec 18, 2018 at 9:40 PM Anton Korzunov<EMAIL_ADDRESS>wrote:

Just give me some example to reproduce, and I'll fix it.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/nozzle/react-static/issues/894#issuecomment-448467314,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFUmCeYEJLEG-6qEF4uuS8ABVd6eNuimks5u6cMsgaJpZM4ZYHQR
.

@theKashey the weird thing is that it hot reloads the pages... but... it ditches all the html in app.js.
pre-hot-reloaded app.js does this:
 <nav>
      <Link to="/">Home</Link>
      <Link to="/about">About</Link>
      <Link to="/blog">Blog</Link>
    </nav>
    <div className="content">
      <Routes />
    </div>

After hotreload, this is what you get:
<Routes />

@tannerlinsley - react-hot-loader/babel is applied twice :)

Some packages are inside node_modules, some packages are inside react-static. It always uses the "closest one", as result - just not work.
react/react-dom/react-hot-loader should be singlentones.

Interesting. I'll try and correct this and see if it changes anything.
On Wed, Dec 19, 2018 at 3:06 AM Anton Korzunov<EMAIL_ADDRESS>wrote:

Some packages are inside node_modules, some packages are inside
react-static. It always uses the "closest one", as result - just not work.
react/react-dom/react-hot-loader should be singlentones.
[image: screen shot 2018-12-19 at 9 04 45 pm]
https://user-images.githubusercontent.com/582410/50213489-e5cd5c80-03d1-11e9-90ca-2261ceca5d53.png
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/nozzle/react-static/issues/894#issuecomment-448539366,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFUmCfek91jlJOhfD39-qCtB5dWglzs7ks5u6g-WgaJpZM4ZYHQR
.

@theKashey thanks for stepping in here! Really appreciate it when the authors themselves come forwards to help. It’s few and far between. #broforce

I've been noticing this behavior too.
react-static v 6.0.18
For me, it's only an issue in page-level components. HMR seems to work fine for an App level component and components nested within page-level components, just not the page level components themselves.
Making changes to the page components seems to trigger a rebuild/update which is logged by node, it's just that the browser doesn't update until the page is refreshed.
Perhaps the issue has something to do with how the Routes component works. Not sure, but I thought this info might be helpful.

Could be my code-splitting points? I’ll check my HMR and also run it past the author of react hot loader himself.

@ScriptedAlchemy - check for duplications

react packages duplication I've noticed in my example
babel plugins applied twice

Something is very wrong here, and one have to fix it prior any other changes.

Thanks Anton, looks like we need to do some digging

also seeing this issue, used react-static create basic app, with:
    "react-hot-loader": "^4.3.12",
    "react-static": "^6.0.18",
    "react-static-plugin-styled-components": "6.3.0",

browser says React-Static data hot-loader websocket connected. Listening for data changes..., console updates with Rebuilding...Build complete, but browser does not update.

Hey, stalebot! Issues would not fix themselves!

I know this is still going on, but would just like to check in and say that we're still looking into this. It's top priority.

My build has been working as expected. I'm using React Static 6.3.6 and I bumped React Hot Loader to "react-hot-loader": "4.6.3". That seemed to do the trick. Here's the repo - https://github.com/kirklikecaptain/afov-react -- File save to browser update takes < 1s.
Here's my root level file that handles the RHL logic:
import React from 'react';
import ReactDOM from 'react-dom';

// Your top level component
import App from './app/App';
import ReactGA from 'react-ga';

// Export your top level component as JSX (for static rendering)
export default App;

// Render your app
if (typeof document !== 'undefined') {

	ReactGA.initialize('UA-117674715-1');

  const renderMethod = module.hot ? ReactDOM.render : ReactDOM.hydrate || ReactDOM.render;

  const render = Comp => {
    renderMethod(<Comp />, document.getElementById('root'));
  };

  // Render!
  render(App);

  // Hot Module Replacement
  if (module.hot) {
    module.hot.accept('./app/App', () => render(require('./app/App').default));
  }
}

You shall not use module.hot.accept if you have React-Hot-Loader. It is disabled out of HMR event, it might not detect here.

Just installed and it still happening.

@cassianomon - what is happening?

@theKashey I did a fresh install, choose basic template and it doesnt reload when I change .js files, only reloads if I change the main index.js.

Hot reloading should now work flawlessly in v7 🤞. If it does not, please reopen a NEW issue. Thanks!


Emulate Touch From Mouse function has no effect when using iPad and apple pencil

Godot version
3.5
System information
13.0.1 (22A400)
Issue description
Project->Project Settings->General->Input Devices->Pointing->Emulate Touch From Mouse
The Emulate Touch From Mouse function is effective when sliding the mouse on the mac os. It can simulate the events of InputEventScreenTouch and InputEventScreenDrag. However, when using Apple Pencil to slide on the iPad, the events of InputEventScreenTouch and InputEventScreenDrag cannot be simulated through InputEventMouseButton and InputEventMouseMotion.
Ask the developer to help confirm whether this is a bug or how to set it to simulate the event. It has been a while since the problem was solved. Thank you very much.
Steps to reproduce
When using Apple Pencil to operate on the iPad's godot app.
Minimal reproduction project
N/A

A look at the code for iOS it looks like the pencil is treated as touch

Pencil input is not mouse input, so this would require a separate project setting.

Thank you for your answer!
Because our projects are developed based on InputEventScreenTouch and InputEventScreenDrag gestures. Turn on the Emulate Touch From Mouse function. There will be InputEventMouseButton and InputEventMouseMotion events, as well as InputEventScreenTouch and InputEventScreenDrag events when moving with the mouse on the PC. Is there any way to make apple pencil have these four events in use? Currently, there are only InputEventMouseButton and InputEventMouseMotion events. We do not need to obtain the parameter values of press and tilt, but only the events of InputEventScreenTouch and InputEventScreenDrag.


fix: event emitter warning

I'm able to reproduce the issue
WARN  new NativeEventEmitter() was called with a non-null argument without the required addListener method.
WARN  new NativeEventEmitter() was called with a non-null argument without the required removeListeners method.
The solution is based on those research:
https://stackoverflow.com/a/69650217/11969222
https://github.com/react-native-netinfo/react-native-netinfo/issues/486#issuecomment-902029567

What issue does this fix?

What issue does this fix?

For fixing https://github.com/amplitude/Amplitude-ReactNative/issues/145

Thanks for fixing this! I think this is related to: https://github.com/amplitude/Amplitude-ReactNative/pull/143.


Remove incorrect explanation of probe config

Description
Remove the incorrect explanation of initialDelaySeconds with periodSeconds relation in configure probes.
Page: Configure Liveness, Readiness, Startup Probes.
Issue
Closes: #48519

This line was introduced in https://github.com/kubernetes/website/pull/43289, and the author then said that the behavior was tested. So ... this needs a tech review.

/sig node

@kubernetes/sig-node-pr-reviews I've not tested this, but I do agree: it will need a tech review from SIG Node before we can merge the change.

Thanks for your attention. Using this example to test on K8s v1.27 several time, the same behaviors shows that if initialDelaySeconds: 0, first probe is not periodSeconds but immediately after start. From the code, we can also reach this conclusion. So the issue mentioned was misleading, therefore opening this PR. Thanks for taking a look.

Thanks for your attention. Using this example to test on K8s v1.27 several times, the same behaviors show that if initialDelaySeconds: 0, first probe is not periodSeconds but immediately after start. From the code, we can also reach this conclusion. (initialDelaySeconds is neither ignored, nor shall assume it will be added to periodSeconds for fist probe.) So current explanation on the website mentioned is misleading, therefore opening this PR. Thanks for taking a look.

Thanks for the confirmation. Please make sure the revised text clearly and precisely describe the system behavior then. Setting initialDelaySeconds: 0 is different from omitting it.

Trying to rephrase the problem: I intend to fix the explanation that when initialDelaySeconds<periodSeconds, the original text "then the initialDelaySeconds will be ignored" is misleading, it is different from "removing initialDelaySeconds or setting it to 0".
Because if initialDelaySeconds is omitted (defaults to 0), or set to 0, first probe happens immediately. But if 0<initialDelaySeconds<periodSeconds, initialDelaySeconds will be "contained"/"merged" into periodSeconds, first probe happens after interval.
Thanks for the discussions, and sorry for bringing confusion, but I intend to avoid future misunderstanding.
What's confusing: Doc says that initialDelaySeconds is time before probes are initiated, generally one would assume periodSeconds will start after initialDelaySeconds, therefore contradicts the behavior when initialDelaySeconds<periodSeconds, they don't add up.
However, the fact is periodSeconds starts on itself, initialDelaySeconds blocks any probe happening during this time since start, probes appear disabled; after that time probes go through and are effective. This means consistent behavior when initialDelaySeconds < = > periodSeconds.
Thanks @tengqm @tnqn @Dyanngg


Error when deploying mixtral

I get a very non-specific error when deploying mixtral to sagemaker:
Traceback (most recent call last):   File "XXX", line 47, in <module>     huggingface_model.deploy(   File "XXX", line 315, in deploy     return super(HuggingFaceModel, self).deploy(   File "/XXX", line 1654, in deploy     self.sagemaker_session.endpoint_from_production_variants(   File "/XXX", line 5380, in endpoint_from_production_variants     return self.create_endpoint(   File "XXX", line 4291, in create_endpoint     self.wait_for_endpoint(endpoint_name, live_logging=live_logging)   File "XXX", line 5023, in wait_for_endpoint     raise exceptions.UnexpectedStatusException( sagemaker.exceptions.UnexpectedStatusException: Error hosting endpoint XXX: Failed. Reason: Request to service failed. If failure persists after retry, contact customer support.. Try changing the instance type or reference the troubleshooting page https://docs.aws.amazon.com/sagemaker/latest/dg/async-inference-troubleshooting.html
AWS has not created a log group in cloudwatch at this time.
Is anyone else experiencing the same problem?

Can you please shar ethe code you used to deploy?

`import json
from sagemaker.huggingface import HuggingFaceModel
configure model
role = "XXX"
model_s3_location = "XXX"
instance_type = "ml.g5.48xlarge"
number_of_gpu = 8
health_check_timeout = 300
config = {
"SM_NUM_GPUS": json.dumps(number_of_gpu),
}
huggingface_model = HuggingFaceModel(
model_data=model_s3_location,
image_uri="763104351884.dkr.ecr.us-west-2.amazonaws.com/huggingface-pytorch-tgi-inference:2.1.1-tgi1.3.3-gpu"
"-py310-cu121-ubuntu20.04-v1.0",
role=role,
env=config
)
llm = huggingface_model.deploy(
endpoint_name=endpoint_name,
initial_instance_count=1,
instance_type=instance_type,
container_startup_health_check_timeout=health_check_timeout,
)
`

Can you please check here https://www.philschmid.de/sagemaker-mistral#4-deploy-fine-tuned-mistral-7b-on-amazon-sagemaker
You need to define more variables in the config for TGI to know here your model is stored.

My model is inside a tar file.
Do I need to define the variable as well? Various examples from huggingface or aws only use model data.

The blog post describes your use cases.


Only match pattern of order instead of letters

We are working with Fuse in our project, but we notice that we get very weird search results because of how Fuse handles search queries. If you for example look for "Recruiter", you match on the word "Developer" even though the words are nothing alike, but it matches on the patterns "r", "e", "r" again and "er" inside the word "Recruiter", which doesn't make sense.
I know it's possible to set it up a minMatchCharLength. Is it also possible to setup that the letters have to appear in the order of the query, so "recruiter" would match with, for example, "copywriter" (match of "iter"), but not with "developer" as the letters don't appear in the same order?

bump to prevent close

I'm running into this right now. I have minMatchCharLength set to 2, and it's telling me that the "ma" portion of my search term ("main") is matching on "am" in the text I'm searching. The order should matter.


Page without a link in Visual Studio Docs

There is no link addressing this page in Visual Studio Documentation. I would suggest to change the link in this page from What's new in Visual Studio 2017 to Welcome to Visual Studio 2017.
See the answer by Carlos Quintero to a question of mine in Visual Studio General Questions.

Thanks for the feedback. We're in the process of considering the proper navigation on the VS IDE hub page, and we'll keep your comments in mind.

I agree this is a problem, but so far we haven't found a good solution. You can't just change the link to the What's New, and our design only allows the three links.

Closing this as By Design.


Nested DataSequence

Implement nested DataSequence in dashboard.py
you can cherry-pick -n a22640d which is part of layers feature then grab only vmngclient/response.py then parse using
return self.session.get("/dataservice/health/devices").dataobj(DevicesHealth, None)

will work for pydantic.BaseModel, nested attrs dataclasses could be unsupported (not sure)
Originally posted by @sbasan in https://github.com/CiscoDevNet/vManage-client/pull/209#discussion_r1163362334

This issue was migrated from an old repository: https://github.com/CiscoDevNet/catalystwan/issues/214


replace gometalinter (which is deprecated)

as seen here the tool relies on gometalinter
https://github.com/gojp/goreportcard/blob/bc8ceed159f60e73cbaf0f9208413e48e86537fe/tools/tools.go#L7
but https://github.com/alecthomas/gometalinter is archived and pushing people towards ttps://github.com/golangci/golangci-lint
I do not want to install gometalinter on my machine as there is an alternative which is maintained
is the migration in the roadmap and if not how can I help to make it a reality?

similar to  #349

@shawnps  this is the issue I was discussing

Thanks @georgettica we'll take a look.

I remembered the tool was not using the new versions and had an alternative that did so I forgot I commented on other PR's

FWIW we've pinned a version of gometalinter that does work, but this is something we've been discussing for a while now so I'll chat with @hermanschaaf about it.

Was this discussed? current Go Report Card still includes golint as a check

Bump


brew cask search lacks --desc

feature request:
brew cask search is really difficult to find what packages are
brew normally has brew search --desc (which has issues of its own, but still, it exists).
there's currently no analog for brew cask searches.

Homebrew-Cask is not a discoverability service.

so, what you're saying is that if i were to add --desc, you'd reject the PR?


setting the fh.cloud timeout from an env var instead of using the def…

…ault 1 min.
I think it would be good to have a timeout for the client when sending requests to the cloud, separate to the cloud making requests to services.

Coverage increased (+0.09%) to 64.683% when pulling 142f8dff1a19c8b938cbd041fa50d3bbfb50ffae on darachcawley:pr-timeout into a27c30c76f89dd222df32f02489f662ad8e4ae17 on feedhenry-raincatcher:master.


Create github action to automatically generate and commit docs

Run npm run docs on PR open/sync
Commit changed files automatically

No longer relevant #179


Previous Version Request : Need ignite 0.2.1 version

Previous Version Request : Please provideignite 0.2.1 version (or let me know the branch to clone) for an old project build. Greatly appreciated!

Ignite started from version 1.0, there was no 0.2.1 - please double check your project.


Allow Ctrl+Return to run code

Allow pressing Ctrl and the Return key at any point to run the code in the editor instead of having to click submit or use up all lines and press Return.

This is a great suggestion. Could you make some minor tweaks to PR?

Separate this as its own condition. Reason being that ctrl-return should submit no matter what, but if there's any whitespace before or after, it will be trimmed instead.
Have it be the first condition, again so it's guaranteed to submit.
Also check for e.metaKey for Mac.

Like this? :)

:+1: Looks good, thanks for this!

No problem, thank you for a great resource :)


Add SSL_DOMAIN environment variable for custom Common Name

Create environment variable SSL_DOMAIN (optionally set and pulled from value in .env) which will be used in server.pem creation.
Allows self-signed certificates to have a custom Common Name (instead of localhost, which would still be the default).
Use case:
This allowed me to view my local application at https://mydomain.test by setting SSL_DOMAIN=*.mydomain.test in .env

For Chrome to accept the certificate as valid, it required a subjectAlternativeName to be set. Added another variable, SSL_ALT_NAME, to specify (e.g. SSL_ALT_NAME=DNS:localhost,DNS:mydomain.test).
Updated README.md to explain both variables.


(Bug) store.set(loading) causes re-render

For example in marketplace when we set loading:false the page gets re-rendered with visible change
go over places using store loadingIndicator:

use memo or some other method to prevent re-render
OR stop using the global loading indicator and use it as a local component

@sirpy
https://drive.google.com/a/nordwhale.com/file/d/1D-pts50T4F4YIj9FH9ZKZwbV1rliUphx/view?usp=drivesdk
What exactly wrong with visual changes?

hmm maybe the market refresh is because of something else.
please look at the console and examine re-renders performance wise,  also examine other places where indicator is used

@sirpy
I don't see any wrong visual changes in the app related to rerenders.
But I see in the console that 'stackNavigation Render: FIXME rerender' printed a few times when you change the screen or doing something in view. Maybe that is the thing which matters to you.
Looking at the code stackNavigation.js I see that it happens because of the state is changing inside the component.


Incorrect syncing files number

In my test, the rule is shown as bellow. After this rule is enabled, web UI shows that 20,000 files are syncing, but there are only 10,000 files under the syncing directory in HDFS which is consistent with DB's file table. And the progress percentage increased from a negative one. Wei and I found that in file_diff table there are two records for some or all files under the syncing directory. I am not sure how did this problem occur currently.
Rule:
file: path matches "/1MB_10000/*"  | sync -dest hdfs://sr518:9000/1MB_10000/
Because the DB is not formated for a long time. There are around 180k records in file_diff table. Maybe SSM should clean the unused records in this table on certain conditions.

Please refer to issue #1700: A getFile issue occurs when sync files.


[WIP] Propagate Explicit Module Build command arguments to compile jobs.

This PR adds the compile command argument interface for Explicit Module Builds, as specified in: https://github.com/apple/swift/pull/32125

-disable-implicit-swift-modules and -Xcc -Xclang -Xcc -fno-implicit-modules are passed to all compile jobs to prevent the frontend from building any modules implicitly and diagnose if they have to.
When building a module, the compile commands are passed paths to the module's direct dependencies with -Xcc -Xclang -Xcc -fmodule-map-file= and -Xcc -Xclang -Xcc -fmodule-file= and -swift-module-file=.

For now, I include a test that verifies that the commands are generated as expected w.r.t. their dependencies. Once the frontend puzzle piece is landed, we should be close to getting a full end-to-end test.
This PR subsumes #112.

@swift-ci test

@swift-ci test

@swift-ci please test

@swift-ci test

@swift-ci test

@swift-ci test

@swift-ci test

@swift-ci test

@swift-ci please test

@swift-ci please test

The test added in this PR is failing in CI because it needs to invoke the compiler (dependency scanner) and I suspect that this is due to the way the driver currently does path resolution when looking for the compiler executable.
It attempts the following, in order, whichever method succeeds first:

Try to find it with executable-specific environment variable
(This is a typical development workflow, hence why "it works on my machine".)
Try to find with xcrun -sdk macosx --find <executable>
Try to search default search paths, which are just set to PATH
Fallback to /usr/bin/.

Because CI points the driver to the latest toolchain with PATH, the driver ends up invoking the wrong compiler (system compiler found with xcrun, I suspect).
@DougGregor , we can make this work by doing either:

Have CI export SWIFT_DRIVER_SWIFT_EXEC to point to the downloaded toolchain's bin.
Swap the order 2 <-> 3 above.
Am I right in thinking that the path resolution order is what it is for a good reason and we should pursue option (1)?

@DougGregor , we can make this work by doing either:

Have CI export SWIFT_DRIVER_SWIFT_EXEC to point to the downloaded toolchain's bin.
Swap the order 2 <-> 3 above.
Am I right in thinking that the path resolution order is what it is for a good reason and we should pursue option (1)?

I think we should do (1), because we might want to fiddle with path resolution order for other reasons, but SWIFT_DRIVER_SWIFT_EXEC will remain the first point of override regardless of what we do.
Thank you!

@swift-ci please test

@swift-ci please test

@swift-ci please test

@swift-ci please test

@swift-ci please test

@swift-ci please test

@swift-ci please test

@swift-ci please test

@swift-ci please test


error converting YAML to JSON:

Hi, when running the CLI I am getting this error when running most commands
anthony@penguin:~$ scalr -help create-environment
panic: error converting YAML to JSON: yaml: line 14570: could not find expected ':'

goroutine 1 [running]:
main.loadAPI()
        /home/runner/work/scalr-cli/scalr-cli/main.go:146 +0x4a7
main.printHelpCommand({0x7ffcba822163, 0x12})
        /home/runner/work/scalr-cli/scalr-cli/help.go:112 +0x3e
main.printHelp()
        /home/runner/work/scalr-cli/scalr-cli/help.go:44 +0x110
main.main()
        /home/runner/work/scalr-cli/scalr-cli/main.go:100 +0x51c
anthony@penguin:~$ scalr -version
0.9.0
anthony@penguin:~$

This is working now. I would assume that the API spec which the CLI pulled down was invalid and that has since been sorted


Chore: add .env.example file

Description
Added a .env.example file to facilitate easier onboarding
Fixes #150
Type of change

[X] Documentation

How Has This Been Tested?
NA
Checklist:

[X] I have performed a self-review of my own code.
[X] I have commented on my code, particularly in hard-to-understand areas.
[X] I have made corresponding changes to the documentation.
[X] My changes generate no new warnings.
[X] I have ensured that my pull request title is descriptive.

Looks good, thank you @kinskiwu!
Some of us had to manually create the config folder at the root level a couple days ago, this would be super useful!


⚠ Bofrost.fr has degraded performance

In 023a183, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1614 ms

Resolved: Bofrost.fr performance has improved in 31c8594.


Contradictions in PPU FIFO size

In the documentation of the PPU FIFO it says the Gameboy has two 16-pixel FIFO's ("Each FIFO can hold up to 16 pixels"). But further down it says the fetcher will never push to FIFO unless the FIFO is empty, which means that the FIFO will never hold more than 8 pixels.

Some of the information in the current page is known to be wrong; see #379.


fixed some odd behavior when changing properties of cluster collections

Scope & Purpose
Slighty improved the behavior of properties retrieval and update of clustered collections:

when retrieving the properties of a collection that uses "distributeShardsLike", now the "replicationFactor" and "writeConcern" values of the prototype collection are returned as expected. The previous behavior was to return the values that were used when initially creating the collection, but this did not take into account any changes of the properties of the prototype collection.

trying to change the "writeConcern" value of a collection that uses "distributeShardsLike" is now handled with a proper error message. Previously a cryptic message with an internal plan id was returned.

trying to change the "shardingStrategy" attribute of an existing collection will now result in a "bad parameter" error. The previous behavior was to silently ignore the change attempt.

[x] Bug-Fix for devel-branch (i.e. no need for backports?)

[x] The behavior in this PR can be (and was) manually tested (support / qa / customers can test it)

[x] The behavior change can be verified via automatic tests

Testing & Verification
This PR adds tests that were used to verify all changes:

[x] Added new integration tests (i.e. in shell_server / shell_server_aql)

http://<IP_ADDRESS>:8080/view/PR/job/arangodb-matrix-pr/10771/

http://<IP_ADDRESS>:8080/view/PR/job/arangodb-matrix-pr/13783/

http://<IP_ADDRESS>:8080/view/PR/job/arangodb-matrix-pr/13783/

http://<IP_ADDRESS>:8080/view/PR/job/arangodb-matrix-pr/13788/

http://<IP_ADDRESS>:8080/view/PR/job/arangodb-matrix-pr/13788/

http://<IP_ADDRESS>:8080/view/PR/job/arangodb-matrix-pr/13792/

http://<IP_ADDRESS>:8080/view/PR/job/arangodb-matrix-pr/13792/

http://<IP_ADDRESS>:8080/view/PR/job/arangodb-matrix-pr/13793/

http://<IP_ADDRESS>:8080/view/PR/job/arangodb-matrix-pr/13793/

http://<IP_ADDRESS>:8080/view/PR/job/arangodb-matrix-pr/13798/

http://<IP_ADDRESS>:8080/view/PR/job/arangodb-matrix-pr/13798/

Tests blue

Setting back to Draft status, as we found that when updating writeConcern for the prototype collection, the change is not pushed forward to the dependent collections.


updated reference from fetch to refetch_data

Introduction and Explanation
Some introductory context and overview
JIRA
Link ticket(s)
Documentation
There should be enough internal documentation for a product owner to write customer-facing documentation or a separate PR linked if writing the customer documentation directly. Link all that are relevant below.

Internal: notion link
Customer docs PR: link
OpenAPI/SDK

Generated docs: link to example if possible
Command to generate: here

Tests
Make a quick statement and post any relevant links of CI / test results. If the testing infrastructure isn’t yet in-place, note that instead.

What are the critical unit tests?
Explain the Integration Tests such that it’s clear Correctness is satisfied. Link to test results if possible.

Known issues
If there are any known issues with the solution, make a statement about what they are and why they are Ok to leave unsolved for now. Make tickets for the known issues linked to the original ticket linked above

Summary by CodeRabbit
Refactor:

Renamed fetch() function to _data() in the DataRow class of encord/orm/dataset.py.
Added new function refetch_data() as a replacement for fetch().
Updated all references from fetch() to refetch_data() in the signed_url() method of the DataRow class.

🎉 Here's to code that's lean and mean,
With changes so smooth, they're barely seen.
From fetch() to _data(), a subtle shift,
And refetch_data() - what a gift!
So raise your glasses high, let's toast,
To the refactor we needed most! 🥂

LGTM
But I hope we can update our writing style a little.

Pyright seems to complain for the wrong reasons. @sergei-encord maybe you can investigate.


DOC Transfer doc issues to napari/docs

📚 Documentation
With https://github.com/napari/napari/pull/5216/https://github.com/napari/napari/issues/4306 relevant doc issues should be transfered to napari/docs.
Note not all doc issues should be moved over:

some issues that relate to overall infrastructure, or API docs, or gallery examples, should remain on the main repo, for example.

Also note that this can only be done with someone with the right permissions in napari/napari and napari/docs. How to transfer: https://docs.github.com/en/issues/tracking-your-work-with-issues/transferring-an-issue-to-another-repository
cc @jni @melissawm

I've create the documentation-migrate-do-docs label, reason being that I can tag issue with this label, but don't have enough permissions to migrate. Devs in the same category as me can thus tag issues, and a core dev can just look at all of those tagged issues and migrate them.

I believe this is taken care of for now? There are a few items related to docs still in this repo but I think they should stay.

Thanks closing in that case!

I've tagged a few more with the migrate tag that seem worth transferring. Maybe you can glance at them @melissawm and @lucyleeow ?

I can transfer them, just wanted to let people see them first, so that we don't need to transfer any back 😊


Unknown function btrim

Hi guys.
I tried to use function trim in "where" block in postgres and got the error message: "Unknown function btrim QUERY:SELECT field FROM "default".test_table WHERE ((btrim(field) <> ''))"
How to reproduce:

Create table in ClickHouse

create table test_table (field String) engine = MergeTree() ORDER BY (field);

Add value to table

insert into test_table values ('213');

Create fdw table in postgres

create foreign table test_table ("field" text) server clickhouse_svr;

Select data and use function trim in where

select * from test_table where trim(field) <> '';

I checked on versions:

PostgreSQL 12.3 (Debian 12.3-1.pgdg110+1+b1) on x86_64-pc-linux-gnu, compiled by gcc (Debian 9.3.0-14) 9.3.0, 64-bit
ClickHouse Verion <IP_ADDRESS>

I found workaround. But it's very strange
You can use functions ltrim, rtrim  together. It works.
select * from test_table where ltrim(rtrim(field)) <> '';

It's not strange, clickhouse already has ltrim and rtrim functions, but not btrim. I haved added translation to trimBoth.


Hide local player's avatar text mesh

Somewhat related: https://github.com/webaverse/app/issues/258


[BUG REPORT] Tensor Size error while training RVC model

Describe the bug
After creating an RVC workspace and preprocessing the data, this error occurs when I click the Train button.
To Reproduce
Steps to reproduce the behavior:

Create or load a workspace in the "Train" tab.
Assuming you have extracted pitches, go to the "train" sub-tab and click the blue Train button.
Check the log.
See error.

Expected behavior
It should start training.
Log
Running on local URL:  http://<IP_ADDRESS>:7860

To create a public link, set `share=True` in `launch()`.
v2 48k
gin_channels: 256 self.spk_embed_dim: 109
<All keys matched successfully>
<All keys matched successfully>
D:\Github\audio-webui\venv\lib\site-packages\torch\functional.py:641: UserWarning: stft with return_complex=False is deprecated. In a future pytorch release, stft will return complex tensors for all inputs, and return_complex=False will raise an error.
Note: you can still call torch.view_as_real on the complex output to recover the old return format. (Triggered internally at ..\aten\src\ATen\native\SpectralOps.cpp:867.)
  return _VF.stft(input, n_fft, hop_length, win_length, window,  # type: ignore[attr-defined]
torch.Size([4, 128, 28]) torch.Size([4, 128, 33])
D:\Github\audio-webui\webui\ui\tabs\training\training\rvc_workspace.py:737: UserWarning: Using a target size (torch.Size([4, 128, 33])) that is different to the input size (torch.Size([4, 128, 28])). This will likely lead to incorrect results due to broadcasting. Please ensure they have the same size.
  loss_mel = F.l1_loss(y_mel, y_hat_mel) * HParams.c_mel
Traceback (most recent call last):
  File "D:\Github\audio-webui\venv\lib\site-packages\gradio\routes.py", line 437, in run_predict
    output = await app.get_blocks().process_api(
  File "D:\Github\audio-webui\venv\lib\site-packages\gradio\blocks.py", line 1352, in process_api
    result = await self.call_function(
  File "D:\Github\audio-webui\venv\lib\site-packages\gradio\blocks.py", line 1093, in call_function
    prediction = await utils.async_iteration(iterator)
  File "D:\Github\audio-webui\venv\lib\site-packages\gradio\utils.py", line 341, in async_iteration
    return await iterator.__anext__()
  File "D:\Github\audio-webui\venv\lib\site-packages\gradio\utils.py", line 334, in __anext__
    return await anyio.to_thread.run_sync(
  File "D:\Github\audio-webui\venv\lib\site-packages\anyio\to_thread.py", line 33, in run_sync
    return await get_asynclib().run_sync_in_worker_thread(
  File "D:\Github\audio-webui\venv\lib\site-packages\anyio\_backends\_asyncio.py", line 877, in run_sync_in_worker_thread
    return await future
  File "D:\Github\audio-webui\venv\lib\site-packages\anyio\_backends\_asyncio.py", line 807, in run
    result = context.run(func, *args)
  File "D:\Github\audio-webui\venv\lib\site-packages\gradio\utils.py", line 317, in run_sync_iterator_async
    return next(iterator)
  File "D:\Github\audio-webui\webui\ui\tabs\training\training\rvc_workspace.py", line 737, in train_model
    loss_mel = F.l1_loss(y_mel, y_hat_mel) * HParams.c_mel
  File "D:\Github\audio-webui\venv\lib\site-packages\torch\nn\functional.py", line 3263, in l1_loss
    expanded_input, expanded_target = torch.broadcast_tensors(input, target)
  File "D:\Github\audio-webui\venv\lib\site-packages\torch\functional.py", line 74, in broadcast_tensors
    return _VF.broadcast_tensors(tensors)  # type: ignore[attr-defined]
RuntimeError: The size of tensor a (28) must match the size of tensor b (33) at non-singleton dimension 2

48k RVC models training is not implemented, although the options do show. https://github.com/gitmylo/audio-webui/issues/46

Ah ok. Does v2 40k work?

Yep, both 40k modes work.

Also I found the text to speech menu a bit confusing at first. The Model menu lets you select between Coqui TTS and Bark. The Bark part is easy to understand, but selecting Coqui TTS, and going to the TTS model dropdown presents a huge list of models from Tortoise, Tacotron2, VITS and some others. I think it would be helpful if the Model menu was expanded to let you select other backends like Tortoise and VITS, and the TTS model dropdown contained the model name and backend/method used.

Coqui is a library used for text to speech. It handles tortoise, tacotron2 and vits. But it's selected as a model as the dropdown it is in is meant for models.
If you want a seperate implementation of Tortoise, Tacotron2, VITS, or another, you can create an extension which adds it to the dropdown if you want to implement it yourself.
Again, for clarity, bark and Coqui are 2 seperate implementations. But the models inside of Coqui are not. I do not provide expansions to the source code for Coqui models, only for specifically implemented models, doing so with Coqui models is far more likely to break in an update.


Slippy map has non-performant response to timeslider adjustments

Bug description
The slippy map is responding inconsistently or not at all to timeslider input.
The map should respond reasonably quickly to adjustments to the timeslider setting.
Repro Steps
This behavior appears to be episodic and may not be reliably reproducible, so I've included the video below, which shows adjustment of the slider and some forced page reloads.
Screenshots & URL
https://drive.google.com/file/d/1CRWLujAuJvsc7oh1Vtm-KFK3rtzddMEM/view?usp=sharing

There appears to be much funkiness on the site right now.
Even zooming in and out creates weird dynamics.
See this screenshot for many errors & complete absence of timeslider altogether:

I wonder if the intermittent issues we saw in the past have been made worse by the upgrade to MapLibre.

Here's a video of the weird zooming behavior:
https://drive.google.com/file/d/184yVrtRdLXqz606eJI79oIA7rtk71yDy/view?usp=sharing

I have to admit that with Chrome on macOS I'm not seeing any strange behavior apart from the usual console full of missing static tiles (GET https://static-tiles-lclu.s3.us-west-1.amazonaws.com/8/43/100.png 404 (Not Found)) and occasional warnings about missing sprite images. I assume you've done a hard reload and tried clearing your cache?

When this happens, can you copy the JavaScript errors that appear in the console? The screenshot only shows the most recent ones, which aren’t very informative.

Good point about the JS error copy.
This problem persisted through a reboot, but not through a cache flush. So, not good, but not unsolvable.

I've always thought that Rails did a decent job of cache busting, @jeffreyameyer, so I'm surprised a cache flush would be required. Still, one could encounter some cruft when jumping two major versions of a mapping library.


WAF - 980xxx rules

Hello,
I have question regarding rules description.
As part of the investigation, we came across several blockages according to the 980xxx rules
 However, these rules are outside the OWASP rulebase
https://docs.microsoft.com/en-us/azure/web-application-firewall/ag/application-gateway-crs-rulegroups-rules?tabs=owasp30
resp. It is not possible to disable / configure within the configuration.
What is the logic in the background, or more information about these rules?
I found some information, but outside the official MS KB. (e.g. https://www.netnea.com/cms/core-rule-set-inventory/)
Thanks in advance.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 079888f6-188c-1bb9-0516-bd52ad0f287e
Version Independent ID: 1971c541-4019-f620-b57b-8cfd5acf87a1
Content: CRS rule groups and rules - Azure Web Application Firewall
Content Source: articles/web-application-firewall/ag/application-gateway-crs-rulegroups-rules.md
Service: web-application-firewall
GitHub Login: @vhorne
Microsoft Alias: victorh

@tukan17 , We are looking into this query and will update you as soon as possible.

@tukan17 , Appreciate your patience. We have assigned this issue to the WAF SME for better insights.
@winthrop28 , Could you please provide your insights here?

@SubhashVasarapu-MSFT @winthrop28 Hello, any update upon this?

@tukan17 , Appreciate your patience. We have assigned this issue to the WAF SME for better insights. Meanwhile please do provide some more details around using these rules in your infra setup for better insights.
@winthrop28 , Could you please provide your insights here?

Hello,
sorry for the late reply.
Its pretty simple. We deployed basic webapp (wordpress) plus other dummy app in k8s cluster. both services deployed via application gw with WAF enabled. OWASP 3.0 ruleset enabled.
Then we tried several mal-requests on GW and saw these rules in Log Analytics.
If you need more detail explain what you want to know, thanks.

Thank you for your dedication to our documentation.
Unfortunately, we have been unable to review this issue in a timely manner. We sincerely apologize for the delayed response. We are closing this issue. If you feel that the problem persists, please respond to this issue with additional information.
Please continue to provide feedback about the documentation. We appreciate your contributions to our community.
#please-close


Need Private Link CLI or PowerShell Commands Listed (or Link) (Or refer to PG for creation)

Specific area of the article with the issue: https://learn.microsoft.com/en-us/azure/data-factory/managed-virtual-network-private-endpoint#managed-private-endpoints
Should have PowerShell and Azure CLI commands for creating private endpoints specifically for Azure SQL Managed Instance.  Even the referenced Private Link documentation is the general page, not the pages on creating the private link.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 0b7d5707-9f14-db2b-00fb-5edd7bbcd06f
Version Independent ID: 2a0f8297-bdf7-3056-121e-963140ec0703
Content: Managed virtual network and managed private endpoints - Azure Data Factory
Content Source: articles/data-factory/managed-virtual-network-private-endpoint.md
Service: data-factory
Sub-service: integration-runtime
GitHub Login: @lrtoyou1223
Microsoft Alias: lle

@jarredm-demo
Thank you for bringing this to our attention.
I've delegated this to content author @lrtoyou1223, who will review it and offer their insightful opinions.

Our team doesn't own the creation of private endpoint. So we can just point it to the public doc of private link. You can contact networking team for the command of SQL MI private endpoint creation. Thanks.

Thanks for providing feedback that helps improve our documentation. This issue has been resolved and we are closing the issue. #please-close


ParticleEmitter copy does not copy particleEmitter position

Issue details
if you make a copy of a particle Emitter, the new particle Emitter does not get initialized with the source position.
Reproduction steps/code
call
newEmitter = new ParticleEmitter(oldEmitter);
new Emitter position (x and y) is initialized as 0
the values is not copied across from oldEmitter.
I will do

a PR with an updated copy constructor
update the ParticleEmitter test to add a test for this

Version of LibGDX and/or relevant dependencies
1.9.9
Please select the affected platforms

[x] Android
[x] iOS (robovm)
[x] iOS (MOE)
[x] HTML/GWT
[x] Windows
[x] Linux
[x] MacOS

ah ok, sorry, shall we close it or I wait for the PR to be merged to do so?


Toggle code comments on/off

Many of the code examples have 50% or more of the example filled with the code comments. It would be great to be able to be able to toggle on/off all the comments to just view the code so it's easier to follow. There are may times I miss a line of code because it gets lost in all the comments.

@LarryWMSN Please link an example.

This is a random example I found that shows the issue:
https://docs.microsoft.com/en-us/dotnet/csharp/programming-guide/classes-and-structs/how-to-implement-a-lightweight-class-with-auto-implemented-properties

If comments could be toggled off, All the code would fit on one screen without scrolling. There are many more that have much more comments, but I didn't save any links to them.


kotlin.KotlinNullPointerException

ava.util.concurrent.TimeoutException
private static final String INSTANCE_LOCATOR = "v1:us1:dc4e0506-ea28-4fcb-a27e-6278e1188315";
private static final String TOKEN_PROVIDER_ENDPOINT = "tokenProvider";
private static final String USER_ID = "ep_ahk";

@emadph What's this? How does this related to ChatKit?

@troy379 I don't think this is related to ChatKit at all. Have been using it with Kotlin for 8 or 9 months already and never faced a NPE caused by ChatKit itself.

@mradzinski Yea, the provided code snippet looks weird and not related to the library obviously. Closing this one


feat(app): migrate from browserRouter to hashRouter

:tada: This PR is included in version 2.19.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


JOSS: Running tutorials

While the tutorials run fine, and I got experience with C++, it isn't quite obvious how the tutorials are run. Am I missing something?
E.g. here https://arc-opt.github.io/Documentation/tutorials/vel_introductory_example.html
Could you please add
cd build/tutorials/kuka_iiwa
./cart_pos_ctrl_hls_hierarchies

or similar.
Refers to https://github.com/openjournals/joss-reviews/issues/6696

Done


Amplify Mock is not working again

How did you install the Amplify CLI?
npm
If applicable, what version of Node.js are you using?
v18.16.0
Amplify CLI Version
11.1.0
What operating system are you using?
Mac
Did you make any manual changes to the cloud resources managed by Amplify? Please describe the changes made.
No manual changes made
Describe the bug
When I run amplify mock on the current version 11.1.0, I get the same errors shown in https://github.com/aws-amplify/amplify-cli/issues/10578. When I downgrade back to 10.6.2, amplify mock works again.
Expected behavior
amplify mock should work like it did on 10.6.2
Reproduction steps

use latest version of amplify 11.1.0
run amplify mock
see the same issues posted on https://github.com/aws-amplify/amplify-cli/issues/10578

Project Identifier
No response
Log output
No response
Additional information
No response
Before submitting, please confirm:

[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.
[X] I have removed any sensitive information from my code snippets and submission.

It appears this has been an issue for a while.
https://github.com/aws-amplify/amplify-category-api/issues/1369
https://github.com/aws-amplify/amplify-category-api/issues/1269


Fix CS1573

Using 5.0.2 I get an error when compiling (I have warnings as errors):
CS1573 - Parameter 'parameter' has no matching param tag in the XML comment for 'parameter' (but other parameters do)
Although the interface is internal (I define LIBLOG_PROVIDERS_ONLY), the warning is still raised as one of the parameters is missing the XML documentation.

Thanks for PR!


nixos/nginx: fix mincore filtering

Mincore is a syscall, not a group.

Motivation for this change
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

I had opened https://github.com/NixOS/nixpkgs/issues/148009 to address this issue.
I'd vote for either removing mincore from nginx or adding it to all other services that use negative syscall filters.
To quote myself:
@ajs124, what's the reason for prohibiting mincore? nginx is the only NixOS service where this syscall is explicitly excluded.
cc @Izorkin

This bug is still unfixed.
I'm getting deployment errors on my systems due to systemd-analyze verify checks for service units, which fail for nginx.
Let's remove mincore for now and maybe re-add it to all services that use negative syscall filters in a separate PR.
I'd also be happy with just merging this PR.

dropped and solved merge conflict.


Vello image rendering artifacts?

Hello! I'm working on a nine-patch rendering system using vello image rendering:

The lines that are appearing I believe are the result of texture atlas bleeding. Although I'm not entirely convinced that is the case since the image is rasterized in compute there should be no issue with atlas bleeding as compute shaders do not have UV's and UV address modes. You can see that they(the artifacts) do not exist in the atlas that Vello produces:

Another possibility is that anti-aliasing is causing these artifacts. I would think it would be odd if AA ran on images though, but perhaps its an effect that runs "post render" I simply don't know enough about vello's internals.
Its also entirely possible that this issue is entirely my fault in my own code, although I am using fairly well tested(bevy code). I'll attempt to reproduce this in a MRE as soon as I am able to.

The lines that are appearing

There are lots of lines in your image. Can you clarify to which lines you are referring?

The lines that are appearing

There are lots of lines in your image. Can you clarify to which lines you are referring?

The black parts are meant to be completely black:

I was able to reproduce this using only vello:

you can find my MRE here:
https://github.com/StarArawn/vello/commit/0c3b0dbc701f98153130a616ed8cfe56948236f4
Curiously it appears as though the scale of the image causes the issue.

I believe that the artifacts you are seeing are called conflation artifacts. I don't have a good suggested workaround, although you might be able to introduce some artificial overlap between the sections.
This is a very hard problem to solve, although we are working on it. See #gpu>Conflation Artifact Free Compositing.
I think we probably could close this as a duplicate of #49.

@dfrg has pointed out that I have likely mis-triaged this issue. Could you please try this with #722, which I think should fix at least some of this?


UI: Fixes for dark theme

abapGit color & background

color for error messages (closes https://github.com/larshp/abapGit/issues/3487)

darker color js debug info

There's a few more that bother me:

remote url is unreadable
borders are too white

There's a few more that bother me:

remote url is unreadable
borders are too white

also branch border is rather light.
I would also review the default text color, blue tint is a bit destructing. More common solution is either pure grey or a warmer color rather than colder. (light brown)

The css needs refactoring. Without that even small changes take a lot of trial&error.
I will see what I can do

On Jun 23, 2020, at 14:52, Alexander Tsybulsky<EMAIL_ADDRESS>wrote:

also branch border is rather light.
I would also review the default text color, blue tint is a bit destructing. More common solution is either pure grey or a warmer color rather than colder. (light brown)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

maybe wait with the logo a bit, see latest comments in https://github.com/larshp/abapGit/pull/3498#issuecomment-648246966

Url, table borders, branch box border:

I didn't change the font color. The blue tint is for links, not text. Since you can click on mostly everything, you see a lot of "blue". Not sure which "link color" is good for dark theme.

@FreHu & @sbcgua any comments, can this be merged?

I'd propose merging it after #3498 (unless @FreHu is OK with it), 'cause they will conflist in css changes.
I'd also suggest separating the logo change. The design proposed here is good. But the only issue with the current logo is that it is not transparent. Changing it as I proposed in #3498 should fix the issue imho instead of adding the complexity.

P.S. sorry for fonts in dark screen shot - this was some old css to make it quickly

This PR currently changes logo for dark theme to have light font color. @larshp the alternative would be to use the same font color for default and dark theme as suggested above (which would not work for a "red" theme, haha ).

@sbcgua to be merged?


Support /// Text as an alternative doc comment format

It's a lot less annoying to type than the current Javadoc style one.

Can you give an example?


Untitled-2

http://scratch.mit.edu/projects/131878815/
http://phosphorus.github.io/#131878815
Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/54.0.2840.99 Safari/537.36

This is a 1.4 project, which we don't support. (#311)


Adding shouldUpdate and onUpdate functions for customized rerendering

This is really important in large applications where rerendering everything is very costly.

Follow up: please see https://github.com/gaearon/react-deep-force-update/issues/8.


fix(repo): Change name to virtualout instead of Vi

Changed to avoid potential legal trouble and to make it actually make sense

in main


Fixed domain matching for site location permissions.

Task/Issue URL:
Description
Steps to test this PR
Feature 1

[ ]
[ ]

UI changes

Before
After

!(Upload before screenshot)
(Upload after screenshot)

Current dependencies on/for this PR:

develop

PR #3845   👈

This stack of pull requests is managed by Graphite.


ECS Custom Password vulnerability when pushing to Bitbucket

Hi,
This might be tricky to fix. I was getting ready to deploy your plugin to our Camunda instances, but when I tried to push the plugin *.js files to my git repo, I got a bunch security related output and my repo refused to accept the push. See error messages below.
Any ideas on how to fix or what is being complained about?
 It is mentioned in README, because it is required with the Docker setup mentioned in README due to how Docker volume mounts work.
That aside, the error sounds like a custom check, and it is impossible for me to know what it is checking and how to fix it.
I'm quite sure that the error could be fixed by pushing source files instead of the final bundles and building those bundles in CI, but I cannot help in that.

I expected that you wouldn't be able to help without significant additional information. I'll work on acquiring that and I'll also I'll look into the alternate deployment method that you described. Thanks.

I have a little more information. Our security scanner thinks that it sees a hardcoded user id or password. The relevant files are:
definition-historic-activities.js
instance-historic-activities.js
instance-route-history.js
instance-tab-modify.js
tasklist-audit-log.js
I'll be looking at source files today to try to find the problem.

@datakurre After further looking into things, all of the security warnings were false positives. I'll can fix things by white listing. Thanks


Added Raspberry PI book list and two other books.

What does this PR do?
Add Resources
Description
Added Raspberry PI meta list, added books made by Al Sweigart on Scratch and Minecraft programming.
Why is this valuable (or not)?
There are lot of books here, from Raspberry PI, Scratch and Minecraft.
How do we know it's really free?
Raspberry PI magazine books are free obviously, and books by Al Sweigart are available on Al's websites.
For book lists, is it a book? For course lists, is it a course? etc.
There is one book list and two normal books.
Checklist:

[x] Not a duplicate
[x] Included author(s) if appropriate
[x] Lists are in alphabetical order
[x] Needed indications added (PDF, access notes, under construction)

@eshellman I removed the list, let me know if I should add the books one by one.


Diff tabs opened from the Source Control panel no longer in preview mode

VSCode Version: 1.12.1
OS Version: OS X EI Capitan 10.11.3

Steps to Reproduce:

Open some project from GitHub.
Make some changes to a file A.cs, and save it.

3.a Stay on the editor of A.cs, and click the button of Open Changes on the top right corner above the editor.
4.a A diff tab opened to show the difference between the changed A.cs and the version in GitHub. Before version 1.12, this diff tab will be open in the preview mode (the tab title font is in italic), now the new diff tab is just a normal tab.
3.b Open the Source Control panel, click A.cs.
4.b A diff tab opened to show the difference between the changed A.cs and the version in GitHub. Before version 1.12, this diff tab will be open in the preview mode (the tab title font is in italic), now the new diff tab is just a normal tab.

If I have 50 files changed, and iterate the changes in the 50 files from Source Control panel, it will open 50 diff tabs for me! This new behaviour isn't very desired. The old behaviour in the previous versions is much more convenient and consistent with opening files from the Explorer panel.

FYI, this changed here: https://github.com/Microsoft/vscode/commit/9f01642853d797978b62714b31edc8d8f1acd18b#diff-5d0a5d79d21dddf1284ed8ca92298d24R384

cc @jrieken

This was to align the behaviour of our various open-calls. @joaomoreno you do have an option tho, simply set preview to true and everything is back to normal

I think the extension should not decide to set the preview flag unless really making sure that something does not open as preview (e.g. a usecase I can see is to open a playground to the side of the current editor that should not go away), otherwise the extension should not set the preview flag explicitly and let the workbench handle this. Otherwise settings like "workbench.editor.enablePreview": false are ignored, which is bad.

@jrieken I have set "workbench.editor.enablePreview": true in user settings but no luck. Is there any other setting to be set explicitly?

This isn't about the setting @bdinesh. Foremost extensions can express their intent when showing a text document (preview or not). Unsure how the setting plays into that, but I have a feeling that the editor service should use it and simply overrule the API choice. Correct @bpasero or are there editors that must open as preview despite have that setting which blocks putting this into the service?

@jrieken @joaomoreno today we have two settings that play a role to decide if an editor should open as preview or not:

workbench.editor.enablePreview (default: true)
workbench.editor.enablePreviewFromQuickOpen (default: true)

If these settings are configured by default, in most cases we open files in preview (e.g. click in explorer, open from quick open).
However, there are still some user interactions that can lead to not using preview after all independent from the setting:

double click in the explorer
opening a dirty file
moving a file from the explorer

If the workbench.editor.enablePreview setting is configured to be false you will never see an editor as preview no matter how the user configured it from the API.
If the workbench.editor.enablePreviewFromQuickOpen setting is configured to be false, it only impacts editors that open from quick open but nothing else.
My understanding is that we added new API for TextDocumentShowOptions to control if a document opens as preview or not. However, we are not having this option from our vscode.diff command, and as such there we now hardcode pinned: true. Wouldn't it best we do not set pinned at all for any editor we open from extensions and let the extension decide this? For example, we could add support for the vscode.diff command to define similar TextDocumentShowOptions and then the GIT extension can actually decide to open pinned or not based on user interaction (e.g. double click vs. single click).

However, we are not having this option from our vscode.diff command, and as such there we now hardcode pinned: true.

No, that isn't correct. We have added that option when adding the option for showing a text document. The only that happened is that both are now aligned wrt the default, which is 'pinned'. The diff-command used to be different here and because it is less official got aligned with the show-function. To get to old behaviour you need to pass {preview: true} when calling the diff-command.

Before these changes extensions could do the following (at least as I've observed them):
commands.executeCommand('vscode.open' ...) - would always open the document in preview (not pinned) and steal focus
commands.executeCommand('vscode.diff' ...) - would always open the diff in preview (not pinned) and steal focus
window.showTextDocument(...) - would always open the document not in preview (pinned) and you could control the focus
After these changes:
commands.executeCommand('vscode.open' ...) - unchanged since it is deprecated
commands.executeCommand('vscode.diff' ...) - opens the diff in not in preview (pinned) by default (to align with the default of showTextDocument) and takes the new TextDocumentShowOptions to control preview, focus, column, etc
window.showTextDocument(...) - opens the document in not in preview (pinned) by default and takes the new TextDocumentShowOptions to control preview, focus, column, etc
Hope that helps and makes sense.

@jrieken @eamodio to me the only right way of fixing this is to not set pinned option in showTextDocument and vscode.diff unless the caller is explicitly setting this option. Otherwise there is no way to get the default behaviour we have everywhere else where the settings of the user are being looked at.
Otherwise, the only way of fixing it for the git extension is to read the user settings (specifically workbench.editor.enablePreview) and then make the decision of setting pinned or not based on that. But basically any extension that uses the vscode.diff command or the showTextDocument would have to do that if they wanted the default behaviour. I would change it and let those extensions adopt the pinned command that really want the editor to open pinned.

@bpasero You are proposing to change both showTextDocument & vscode.diff to default the preview parameter (if undefined) to the value of workbench.editor.enablePreview right?
If so, I agree that sounds like the best way, but it will likely come with some short-term pain -- as the preview default of showTextDocument was always true and vscode.diff was always false. IMO at least it sounds like it might be worth it to actually honor the workbench.editor.enablePreview by default, but still allow extensions to override that depending on their needs.

@eamodio yes, the only time the workbench explicitly sets the pinned option is when there is a specific user action that makes it worth opening as pinned, for example a double click on a file.
I think if we communicate this change properly, extensions can adopt it, especially since we provide this option for both the command and the method.

Isn't this a regression? I was hoping that it might be fixed in a patch release.
It's quite annoying. (=

@joaomoreno Will you please consider adding this to the milestone for May?

Likely not happening for May, sorry man.

Turns out I was wrong.

@joaomoreno while that commit fixed it for the SCM/Git case, it didn't address @bpasero's concerns above -- so should this be re-opened or should that be moved into a separate issue?


Sort by oldest first

Is it possible to change the sort order to show oldest first rather than newest first? I don't see a way, or at least haven't figured out how to do so.

Set elfeed-sort-order to ascending:
(setf elfeed-sort-order 'ascending)
The docstring for that variable mentions a caveat for live filters.

Ah, thank you! I've customized that variable now.


Fix crash callonchildren

Anis and me managed to fix this in a proper way than: #1508

This just prevent a crash caused by callOnChildren call.
You shouldn't call delete function directly. You can do it with a schedule:
exampleGroup.callOnChildren(schedule,0,"delete");


Proposal for optimizing func storageRsyncCopy- rsync's checksum

Required information

Distribution: Ubunu
Distribution version:16.04
The output of "lxc info" or if that fails:

Kernel version:<IP_ADDRESS>
LXC version:
LXD version:2.6.2-0ubuntu1~ubuntu16.04.1~ppa1

Due to the recently introduced dir based containers snapshot- "init rsync->freeze->second rsync->unfreeze" the option "--checksum" in rsync's exec.Command becomes a bit over reinsurance and not needed neither on the first nor the second rsync stage- the frozen state during the second rsync would take care of it- size + time of change on 1 sec granularity(in rsync 3.1.1) is enough guarantee in this case. Because of the fact that it's so slow it leads to often errors in snapshots like for example:
root@lx1:~# lxc snapshot cms working error: rsync failed: file has vanished: "/var/lib/lxd/containers/cms/rootfs/var/lib/cloudera-service-monitor/ts/stream/partitions/stream_2016-12-02T18:56:29.683Z/000019.log" rsync warning: some files vanished before they could be transferred (code 24) at main.c(1183) [sender=3.1.1]
Not to mention the extra performance hit.
What if whether to use it or not is a parameter of the storageRsyncCopy func- while using it in dir based containers snapshots is not needed it might be wise to have it elsewhere.
Cheers,
Atanas
Steps to reproduce

Step one
Step two
Step three

Information to attach

[ ] any relevant kernel output (dmesg)
[ ] container log (lxc info NAME --show-log)
[ ] main daemon log (/var/log/lxd.log)
[ ] output of the client with --debug
[ ] output of the daemon with --debug

Hmm, I'm very much not convince that this is safe to do.
Say one of the last files of the first rsync pass was modified immediately before rsync copies it, then changed immediately afterwards without its size changing (say abc -> def), now the second pass will assume that it's unchanged, giving you "abc" on disk instead of "def".
In fact we added that rsync option specifically because our testsuite was tripping this very issue in our snapshot tests where we have a tiny container (few KBs large) and the test file we use for the snapshot contains "abc" changing to "def" (so same size).

Unfortunately the rsync protocol doesn't seem to allow for a file list to be generated on both source & target without checksums and then for checksums to be generated only for files which otherwise look identical.
It is however moderately clever in that it will checksum all the source files, but only checksum the destination files which otherwise look identical, skipping the hashing for any file that's marked as needing transferring for any other reason.

lets put on test the worst case:

while running the "initial sync" the last file synced from the operation is such a file- "abc" changes on disk to "def" right after the rsync's finish- this doesn't change the size but it does change the modify time. If the second rsync pass run extremely fast right after the first one- say in 1 sec this would lead to your case for sure as we have 1sec granularity
What if we add Sleep(1) or Sleep(2)(more safe) between the first rsync pass and say the freeze ot the beginning of the second rsync pass-  in that case the file will be copied due to the changed modificaton time regarding of the same file size. 1 or 2 seconds will be far less than the complications of the "--checksum"

Add a sleep wouldn't change anything. The two version of the files would still have a timestamp that's within 1s of each other and with the same size.
So long as something in the container can write before and after the first rsync, this race is possible. The only way to avoid it would be to freeze the container even for the first rsync but that'd make the snapshot overhead (as far as time), massively bigger.

Ahh you're right. Shame the patch https://lists.samba.org/archive/rsync/2015-September/030341.html hasn't been committed yet.


Update project to recent stable dependencies: pytorch, cuda, pip deps

This project needs an update to the recent stable releases e.g. for

cuda dockerfiles
dependencies in dockerfiles we compile from source
pytorch
dependencies in the requirements lockfile

otherwise nothing should have changed and it should Just Work :tm:
cc @sandhawalia aren't you using this at the moment?

Heute Lidar Nicht


Any plan to release the datasets?

Hi, thank you for this work, it is interesting.
May I wonder if you have any plan to release the datasets currently?

+1
Really looking forward to the release of the valuable dataset! Many thanks!


[FEAT] CAD project v.20220312

Closes #225
📑 Description

✅ Checks

[x] My pull request adheres to the code style of this project
[x] My code requires changes to the documentation
[ ] I have updated the documentation as required
[x] All the tests have passed

ℹ Additional Information

Looks Really Good To Me.
Merging PR

FYI: The PDF with the assembly instructions for the project contributed in this PR is available at
https://arneis.blob.core.windows.net/public-folder/arneis-conveyor-20220312.pdf (140.1 MB)


Encountering difficulties while attempting to upgrade the SaaS Accelerator

The issue we are facing is regarding the SaaS Accelerator Upgradation, we have deployed SaaS Accelerator provided by Microsoft itself for the functionalities of Landing Page, Admin Site as well as SaaS Webhook for our SaaS Offer. Now, our offer is published, and we were trying to update the Landing Page of the SaaS Accelerator and redeploying it with the modifications we required, following the tutorial provided by Microsoft for the Accelerator Upgradation. I am providing you the link for that video tutorial also which demonstrate the procedure of how we can modify the Accelerator as well as redeploy it over Azure: https://youtu.be/H8p9n1bVTjY?si=A-yflxoYYWv-FO0Z
The issue arrives when we are looking for redeployment post modifications, this is the upgradations script that we need to follow to redeploy the accelerator as provided by Microsoft itself for Accelerator Updation:
git clone https://github.com/Azure/Commercial-Marketplace-SaaS-Accelerator.git -b  --depth 1;
cd ./Commercial-Marketplace-SaaS-Accelerator/deployment;
.\Upgrade.ps1 -WebAppNamePrefix "marketplace-SOME-UNIQUE-STRING"
-ResourceGroupForDeployment "marketplace-SOME-UNIQUE-STRING"
Now, the issue occurs when we run this script over Azure PowerShell for redeploying the Accelerator, the error that we are encountering is:
Deploying new database
ERROR: <urllib3.connection.HTTPSConnection object at 0x7f8b0bc9f9d0>: Failed to establish a new connection: [Errno -2] Name or service not known
Upgrade.ps1: Cannot bind argument to parameter 'Source' because it is an empty string.
We reviewed the Upgrade.ps1 script and identified that it expects WebAppNamePrefix and ResourceGroupForDeployment parameters but encounters issues with Source value handling.
Our Azure PowerShell environment is configured correctly, and we have necessary permissions for deployment.
### We went through the code of Upgrade.ps1 file, they are expecting WebAppNamePrefix, ResourceGroupForDeployment  some source value with start and end index here’s the code:
Param(
[string][Parameter(Mandatory)]$WebAppNamePrefix, # Prefix used for creating web applications
[string][Parameter(Mandatory)]$ResourceGroupForDeployment # Name of the resource group to deploy the resources
)
Function String-Between
{
[CmdletBinding()]
Param(
[Parameter(Mandatory=$true)][String]$Source,
[Parameter(Mandatory=$true)][String]$Start,
[Parameter(Mandatory=$true)][String]$End
)
$sIndex = $Source.indexOf($Start) + $Start.length
$eIndex = $Source.indexOf($End, $sIndex)
return $Source.Substring($sIndex, $eIndex-$sIndex)
}
Can we get some information regarding this source parameter, like what value is expected here and from where we can fetch it for resolving this issue.

@wns-rohanraj The above is a function that gets called at various times during the script run to split a string to get specific values.  You don't need to provide the source parameter in this case.
Concerning your upgrade script breaking, we do not at the moment have an upgrade script for certain versions of the accelerator, specifically if your current deployment uses vnet. If so, please redeploy with version 7.6.2 (not with the upgrade script, but as a standalone deployment) and you can simply republish your offer with the latest technical configurations.


fix: joins on Timestamp columns

Which issue does this PR close?
Closes #187
Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

I will merge it when all the tests pass.

I will merge it when all the tests pass.

Ok, thanks.

Is this issue #959  related to this?

🎉

Thanks again @francis-du !


MacAddrField truncates MAC addresses that are too long

The MAC address form field has a length limit, but if the user omit colons or hyphens they can fit more characters in the field, which are silently truncated on form submission. The form field should instead raise a ValidationError in this case.

Resolved by https://github.com/OSU-Net/cyder/pull/835


Raised Exception when timeout is encountered waiting for LB to be active

@alena1108 , Can you please review?

LGTM


Request for a non snapshot release

Hi,
We're using your helpful library in production and would like to depend on a non-snapshot release. Would you consider bumping what's currently available as a non-snapshot release or is it still too alpha?
Thanks!
Gabriel

Hi @cldwalker,
Snapshot has been stable and we haven't gotten any bug reports, so I just released 0.1.0 to clojars
Best,
Julien

Pulled this into production. Thanks!


Allow unions to specify fields as optional.

Resolves #43.

@blampe @breerly @junchaowu

Yup. :shipit:


Intellisense ergonomics

Please select if your request is either something new or an enhancement

[x] Enhancement of an existing Feature.
[ ] Request of a new feature.

Please select the area your request applies to. (Multiple selections are Possible. You can leave blank if you're not sure.)

[x] Workspace - VSCode workspace, vaults, Intellisense/autocomplete, Dendron settings
[ ] Lookup - Dendron's Lookup Command
[ ] Views - Dendron Preview, Tree View, Side Panels in the UI
[ ] Schema - Dendron Schemas
[ ] Pod - Data import from / export to Dendron
[ ] Publish - External Site Publish
[ ] Markdown - Markdown features, such as syntax support and features

Is your feature request related to a problem? Please describe
With dendron the note names usually get very loing, much longer than the intellisense field can show. This makes it much less useful borderline useless as one cannot see which note is selected.
Describe the solution you'd like
I'd like a solution that lets me either see the whole note name no matter the length (but I guess due to vscodes UI that is difficult) or shows me an incremental suggestion, so that when I entered a few nodes it just shows the nodes below and clipps the entered higher nodes from the name.

Thanks @funnym0nk3y for your suggestion 🙏


command not found?

I'm probably using this wrong, but I get the above error when I try the following:

Place nvidia-htop.py in my current directory.
Call nvidia-smi | nvidia-htop.py -l

Calling nvidia-smi on its own works just fine. Any suggestions?

Ahem, as often happens, I had a thought just immediately after hitting Post.
nvidia-smi | python nvidia-htop.py -l appears to work. I do not understand why your suggestion would work, do you ?

(also, thanks for sharing awesome work!)

On Linux you can't run programs from current directory just by typing their names. Correct way to do it is
    nvidia-smi | ./nvidia-htop.py -l

I'll fix the example, thanks for pointing this out.

Cheers, I didn't actually realise you could run python files like that on linux.
Note that one might need to change permissions on the file (I had to), ala
chmod 744 nvidia-htop.py