SRT inference get wrong results

Hi, I execute this command:python exps/BASE-eval-image.py --image ./cache_data/cache/self.jpeg --face 250<PHONE_NUMBER> --model checkpoint-regression.pth,but get wrong landmark like followings pic. Any suggestions? @D-X-Y

I can't even run inference with this --model checkpoint-regression.pth checkpoint as I right away get a  Missing key(s) in state_dict: error.

I can't even run inference with this --model checkpoint-regression.pth checkpoint as I right away get a  Missing key(s) in state_dict: error.

@AndriiHura Could you please show your step-by-step commands? The missing keys are due to the mismatch between DaraParallel Model and the original model

@AndriiHura Could you please show your step-by-step commands? The missing keys are due to the mismatch between DaraParallel Model and the original model

@D-X-Y Please see my results, Any suggestions?

@D-X-Y Please see my results, Any suggestions?

@flynnamy It was my fault that used an old eval file from SBR.. I just updated the codes, please have a try now. I tried it on my laptop and works fine.

@flynnamy It was my fault that used an old eval file from SBR.. I just updated the codes, please have a try now. I tried it on my laptop and works fine.

Please feel free to re-open this issue if you have another question.

Please feel free to re-open this issue if you have another question.

@D-X-Y Now it works great! Thanks a lot :)

@D-X-Y Now it works great! Thanks a lot :)


fix get_ttvs_nodata

get_ttvs_nodata sometimes returns NaNs for non-coplanar orbits. This does not cause issues in fitting because get_ttvs (fitted) works fine, but is inconvenient for plotting.

Wrote a modified (jitted) function get_transit_times_all. Need to update

plot_models
check_timing_precision
sample_means_and_stds

At some point it might be nice if we could carry out a detailed comparison with NbodyGradient.jl.

At some point it might be nice if we could carry out a detailed comparison with NbodyGradient.jl.

Yes, that would be useful. I've opened a new issue for this, so please feel free to add any ideas for tests.

Pushed fix to develop branch. Replaced non-jittable get_ttvs_nodata with jittable version get_transit_times_all.

Pushed to main branch.


GLFW callbacks not invoking

Environment

LWJGL version: 3.2.3, 3.2.2
LWJGL build #: 13
Java version: 11.0.2, 10, 11.0.3, 1.8
Platform: Windows 10
Module: glfw

Description
GLFW callbacks are sometimes not invoked (around 5% of launches).  The window, gl context, and frame buffers all create normally, but the callbacks such as event handling, window resizing, window closing, etc aren't being invoked.
This is reproducible with the hello world from the guide (https://www.lwjgl.org/guide)
Rapidly relaunch the hello world application, closing via clicking the close button. The window will always close but on some launches the close button will not invoke the close handler, and therefore the process will remain active.

I have not yet tried on other operating systems.
lwjgl3hello.zip

I don't see a close callback in the source code, only a glfwSetKeyCallback and a GLFWErrorCallback.createPrint. I wouldn't expect either of those to be called. What part are you referring to?

Ah, you're right, I've probably mislabeled the issue.
When clicking the close button, the close callback (if there was one, but you're right, not in the hello world example) is never called, and glfwWindowShouldClose(window) never returns true and therefore the application never closes.
The window closes, but the process never terminates.
And again, this happens about 5% of the time

@octylFractal were you able to reproduce it?

I'm on Arch Linux, so I didn't attempt to reproduce it. Nevertheless, I tried just now, and I can't. Might be a Windows-only bug, and probably in GLFW itself. I would try out a GLFW example to see if it has the same issue for you.

I can try on other platforms, I'm pretty sure this didn't happen in lwjgl 2.9.+ It seems to happen less often when running from a standalone jar than running via class files in the IDE so I suspect it's possibly a race condition.

Not happening in LWJGL 2 isn't surprising considering it used a completely different window library.


Source menu should be ordered somehow

The edit-sequence page allows the assignment of chants to a source in the database, but the dropdown is not in any kind of order, so it's hard to find the right one:

We don't really expect to have to do this after the Bower data is cleaned up, so it's not a priority, but it would make the cleaning up easier...

Agreed. I think this is something we will get to in the broader overhaul of segments and projects ... I'm not sure exactly how, but it will definitely be different/better than this.

wait, they are ordered, just by the city, with special characters at the end of the alphabet (which happened to be where I looked first). So not quite as bad as I thought...

It’s quite obvious because Unicode code points for non-Latin characters are outside of the range 0-127 and thus their numeric value is higher, and OBVIOUSLY when sorting text you want to sort by the ASCII code point and not by their lexical value.
Says every database ever.
(Yes, it’s dumb)

(Yes, it’s dumb)

speaking from personal experience with lowercase "d" falling after uppercase Z...agreed.


#trigger() method not support IE10/IE9?

I use browser stack test IE browser.
When I use
wrapper.find('.classname')[0].trigger('click')
Get Error Message: Object doesn't support this action.
I want to know how to fix it?

I won't have time to look at this until next week, but I think it can be fixed by adding an event polyfill - https://stackoverflow.com/questions/26596123/internet-explorer-9-10-11-event-constructor-doesnt-work
If you wanted to make a PR, it would be greatly appreciated 😇

Sorry, shouldn't have closed.
I've added a workaround in 2.6.3 but am unable to confirm in IE.
Can you confirm the fix?

Are you able to test this some time?

I've alreadty test this fix in IE. It works.
I'm sorry to test this too late. Thank you.


Move ESlint into its own package

There are too many cross-cutting concerns having eslint as part of our build chain in Webpack. It should really be extracted out and run as a separate task, like tests.
Acceptance criteria

We have a new package for our shared eslint config on npm
All modules that use webpack are updated to use it
Webpack config is updated to not use eslint

Pull requests

[ ] https://github.com/silverstripe/webpack-config/pull/13
[ ] https://github.com/silverstripe/silverstripe-asset-admin/pull/687
[ ] https://github.com/silverstripe/silverstripe-campaign-admin/pull/75
[ ] https://github.com/silverstripe/silverstripe-admin/pull/343

@unclecheese in eslint-config could we remove index.js and have the package.json entry "main": ".eslint.js" instead?
Also would be good to have some README.md explaining the purpose of the package, nice-to-have option a short explanation for how we use it.


Add securityContext to run as root for kaniko example 🤖

Changes
As of today, kaniko assumes it is running as root, which means, this
example fails on platform that default to run containers as random
uid (like OpenShift). Adding this securityContext make it explicit that
it needs to run as root.
Related to #1551 (although it doesn't fully fix it as, for OpenShift, to run as root, you need anyuid :sweat_smile:)
Signed-off-by: Vincent Demeester<EMAIL_ADDRESS>Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:

[ ] Includes tests (if functionality changed/added)
[ ] Includes docs (if user facing)
[x] Commit messages follow commit message best practices

See the contribution guide for more details.
Double check this list of stuff that's easy to miss:

If you are adding a new binary/image to the cmd dir, please update
the release Task to build and release this image.

Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

/lgtm

/approve


[Draft] RFC: #[cfg(path_exists(..)/version(..)/nightly)]

This is a draft version of an RFC for you to review, before a formal proposal is made for consideration.
Summary
Permit users to #[cfg(..)] on whether:

they are on a nightly compiler (#[cfg(nightly)]).
they have a certain minimum Rust version (#[cfg(version("1.27"))]).
a certain external path exists #[cfg(path_exists(::std::mem::ManuallyDrop))].

Nice work. My main question is: why would one want to target multiple versions of the Rust language and/or stdlib with the same code? Also, can't a stable crate depend on a nightly crate currently?
In the RFC text: s/tenant/tenet

@alexreg "If this feature is available, integrate with it, but keep working with old versions of Rust."
If not for the hack where macro_export accepted arguments in old versions, we would have wanted this to allow the equivalent of macro_export(local_inner_macros).
Or, we could use this to declare a function as must_use for new Rust without breaking compatibility with old Rust.

Thanks all for reviewing! Time to publish ;)


Facebook login Graph API calls using Graph API, iOS

Hi, I have successfully implemented Facebook login in my app, but when I open Facebook login, It gives me alert "If you are not using Limited Login, you will need to handle all Graph API calls using Graph API, iOS. Access token will not be valid,..."
Login by Facebook is working despite of this error but alert is not desirable in production.
Coul you please help me to fix this problem??
thanks a lot

@riderx The problem is, that I do not know how to use it. Can you please help?

@riderx I get the same warning message on iOS when I use limitedLogin option

"If you are not using Limited Login, you will need to handle all Graph API calls using Graph API, iOS. Access token will not be valid,..."

await SocialLogin.login({           provider: 'facebook',           options: {             limitedLogin: true,             permissions: ['email', 'public_profile'],           },         });
Am I missing something?


Add support for Mean Squared Logarthmic Error

Adding support for mean squared logarithmic error along with a test for correctness.
#127

I'm all for proper API documentation :smile:. Thanks for the the guidance.

@rxwei Is the swift log natural log or log base 10?

log(_:) is natural log, same as TensorFlow's.

Please disregard the test failure—it's a compiler regression introduced in https://github.com/apple/swift/pull/25293. It will be fixed soon!


Additional functionality: spatial averaging over polygons

Completed with https://github.com/roocs/rook/pull/251


For Python2+Python3 compatibility, add some from __future__ imports.

https://github.com/cvxgrp/cvxpy/pull/150#issuecomment-68882598
These are used in numpy and scipy, so if the tests pass locally using Python 2, they will probably also work with Python 3.

Right now cvxpy is using the use_2to3=True flag in setup.py so that a Python 2 (or Python 3) compatible version is built automatically. It's been very convenient. You can use a//b in the code and it will convert it into int(a/b). It would seem that the from __future__ imports aren't necessary.
What's your opinion on this approach? @rmcgibbo added Python 3 support. I don't have any previous experience with Python 3.

What's your opinion on this approach?

Thankfully I didn't have to suffer through these transitions for numpy, scipy (https://github.com/scipy/scipy/pull/397), IPython (https://github.com/ipython/ipython/issues/2440), sympy (http://ondrejcertik.blogspot.com/2013/08/how-to-support-both-python-2-and-3.html), etc. so I don't have first-hand battle stories to explain why it is a good idea, but apparently it is the consensus 'best practice' for Python 2 and 3 support, despite the fact that it conflicts with the original advice in http://legacy.python.org/dev/peps/pep-3000/.

In my opinion, the most important thing for multilingual python development
is the CI system -- especially if, as a developer, you're working only with
one of py27/py34, you're pretty likely to accidentally introduce trivial
incompatibilities unless the CI warns you. But given the notifications from
the CI, it's usually trivial to maintain cross-version compatibility.
I've worked with both single codebase py2/py3 projects (usually using the
six library to make things more smooth) and with projects that use 2to3.
For starting new projects, I always go with single codebase, and recommend
it to to others. Development is easier, because thing like setup.py develop work better when source translation isn't required. Also,
debugging py3-specific issues can be a little trickier when the "canonical"
source is not runnable in the py3 interpreter.
But it's not that big of a deal. When the project is already working just
fine with 2to3, changing it to single-codebase style shouldn't be a
priority, IMO.

What does "CI" stand for?

What does "CI" stand for?

It's continuous integration, like Travis or Jenkins.


Upgrade eslint-config-base dependencies

Changes in eslint-config-base:

Upgrade versions of eslint, eslint-config-airbnb-base
Use @babel/eslint-parser instead of deprecated babel-eslint

I've noticed that CircleCI didn't run checks for that PR and https://github.com/datarockets/style-guide/pull/37
https://app.circleci.com/pipelines/github/datarockets/style-guide

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


android render  problem

I ran into this when running the canvas_minimal example on android, any ideas?

Sorry, I think I've found the answer!!!!

@zhuyijiang what was the problem?
I am getting the same artifacts.

Occurred the same problem on an Android device, does anyone have idea?


Settings: Add setting for custom list types

In the settings page (see #8), allow the user to add custom list types. The two default types are "Shopping" and "To-Do," but the user may have other list types they want to add.

#15 will need to be completed first.

List types define behaviors (for example, shopping lists include item quantities, whereas to-do lists do not). Allowing the user to define custom list types would imply they can define custom behavior for their list type, which is not the case.
This task will be closed.


Add Code to process css classes passed to Timebar elements

css classes are processed and handled in the same way that they are when passed to timeline elements.

What is the status of pull requests on this project. Hoping to get this change in.

@atkinchris @peterplloyd Someone please let me contribute to this project. Working one a new project with this and looking to add a few small features like this as well as work on some documentation.


Unable to start service as specific user

So, in the xml, I have
<service>   <id>   <description>   ...   <serviceaccount>     <domain>domain</domain>     <user>username</user>     <password>pass123</password>     <allowservicelogon>true</allowservicelogon>   </serviceaccount> </service>
However, when I ran the .exe with install, and then start, Services still indicate that the this service is logged on as "Local System."
Anyone know if this is a bug, or if there's something I'm doing wrong?
Thanks!

Which Windows version do you use?
And just to be sure... Have you modified the file before launching app.exe install or after it?

I'm using Win7 x64.
I modified the file before, and checked that the xml file includes the serviceaccount node.

Sorry for the missing response, missed this issue update.
I'm pretty sure I've tested this case some time ago, but I will re-check it

I can't reproduce this.


i am new developer in react native .. please write example

See https://github.com/bamlab/react-native-braintree-payments-drop-in#basic and the Braintree docs for server-side.


IReliableConcurrentQueue.TryDequeue Timeout behavior description

The documentations says:

If a value was dequeued within the given time, return a ConditionalValue with HasValue as false, else it returns a ConditionalValue with HasValue as true and the Value as the dequeued item of Type T

shouldn't it be:

If a value was >>>not<<< dequeued within the given time, return a ConditionalValue with HasValue as false, else it returns a ConditionalValue with HasValue as true and the Value as the dequeued item of Type T

?
Second topic
I as a reader can't understand what the exact timeout behavior is, because there is this the sentence I mentioned above, but there is also a TimeOutException. The documentation should be more explicitly about the differences and when wich case happens.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 717b1d3d-c79c-79bf-d5e6-580ab89954ed
Version Independent ID: 3e72f47e-8899-ce6e-1fb8-c18ef8a3c978
Content: IReliableConcurrentQueue<T>.TryDequeueAsync(ITransaction, CancellationToken, Nullable<TimeSpan>) Method (Microsoft.ServiceFabric.Data.Collections) - Azure for .NET Developers
Content Source: [xml/Microsoft.ServiceFabric.Data.Collections/IReliableConcurrentQueue1.xml](https://github.com/Azure/azure-docs-sdk-dotnet/blob/master/xml/Microsoft.ServiceFabric.Data.Collections/IReliableConcurrentQueue1.xml)
Service: service-fabric
GitHub Login: @rloutlaw
Microsoft Alias: routlaw

Thank you for your feedback.  Tagging and routing to the team best able to assist.


Feat: Better complex struct inputs

Description
https://github.com/scaffold-eth/scaffold-eth-2/assets/80153681/c388aa58-ce10-4089-9d49-e633ba83524f
Tried handling better structs inputs and complex structs array, lol not the best optimized approach but in my testing seems to work nicely
For testing I have updated YourContract.sol with a nested struct along with a multidimensional struct array but please feel free to play around / test different cases.
You could also try putting Opensea contract in externalContract on mainnet to see how UI looks for testing.
Didn't go too much on visual UI part but maybe we could handle it more better just wanted to get functionality inplace.
Also note, this PR only handles structs array and not primitive types array maybe we could it another PR since it should be alot easier and didn't wanted to clutter this PR 🙌
OG Idea: https://twitter.com/_jxom/status/1748068858047668227

Magic! 🪄
Looks awesome! Really great job!
Noticed that I can't send array with 0 entries, there's at least one and I can't remove it.
Also a question: do we need it also for reading, or only for writing?

Noticed that I can't send array with 0 entries, there's at least one and I can't remove it.

Ohh yeah, I completely forgot that you could pass in empty array fixed at https://github.com/scaffold-eth/scaffold-eth-2/pull/702/commits/df3fd3eb1b7c46bf24697d27538a996a4ff6b5d8, by default it shows 0th element (I think its nice UX to show it at default, but we could keep empty by default) but you can remove 0th element and empty array will passed

Also a question: do we need it also for reading, or only for writing?

Yeah lol again forgot about read ! fixed at https://github.com/scaffold-eth/scaffold-eth-2/pull/702/commits/1394397f3f1f738573d6053ec25e029c5337aecc also updated test contract
Thanks Rinat 🙌

visual representation for each tuple item (0, 1, 2..). Maybe we could add a bit more descriptive text like Item[0], or TupleItem[0] or something similar.

Yup, completely get it,  updated at https://github.com/scaffold-eth/scaffold-eth-2/pull/702/commits/cc89cfead4c5175ba52ff83ea895a6da30319c32

Used tuple instead item or any other name since people can name the args as item or any other thing and it will clash with our naming and might make it more confusing (they won't be able to use tuple as arg name since its reserved)
Only showing tuple[index] for 1D array elements since technically marking 2D / ND  marking their all levels with tuple[index] might not make sense

to add more visual differentiation between tuple items we could play with bg color. Here is an example with a zebra pattern, but maybe that's a bit ugly, this could go in a future iteration with some designer help

Love this idea !!!! It kind of makes it visually easy to digest, we can think maybe changing the color a bit for an alternate zebra strip, not adding this changes in PR but should probably handle this in separate PR  🙌
Tysm Pablo for the great feedback !!

Tysm all for testing !! Just locked dasiyUI version at https://github.com/scaffold-eth/scaffold-eth-2/pull/702/commits/f9c4a0f6bb849d58348bb78a7765049f01a4a1d5 since they seem to have broken Accordian in their latest version and when you deploy to prod we use their version and its broken there eg:

The accordian arrow does not show up here https://se2-structs.vercel.app/
After locking daisyUI version here is prod version : https://se2strcut-prod.vercel.app/
TODO:

Create an issue on SE-2 for better styling of this https://github.com/scaffold-eth/scaffold-eth-2/pull/702#pullrequestreview-1875065425
Create an issue on DaisyUI regarding Accordian issue

Merging this 🙌


Update a vector search index does not work

Expected Behavior
I want to update the vector search when files are deleted in my documentation
Actual Behavior
The vector search is not updated by as written in the documentation:

I check the 'id' of the chunks
I add them in the delete_file.txt in the delete/ directory:
delete_file.txt :
id1 \n id2 \n id3

Steps to Reproduce the Problem

Create a vertex index and deploy it
Add a id to the delete_file.txt
Update the index
Check if the number of vectors have check in the Google Vector Search interface

Specifications

Version: Last
Platform: M1

@BastinFlorian Is this an issue with an official notebook or the online documentation?

It is an issue on the official documentation, I close the issue. Thank you


Tests

Tests are sorely missing. Gonna try to fill that gap today.

what tools do you wanna use here?

I'd probably use Mocha + createShallowRenderer() from React's TestUtils.

I think at this point a basic testing environment is quite important. Makes refactoring safer...

Should we close this?

Yep! Great job.


apollo-client-config-data support spring boot 3.0

What's the purpose of this PR
apollo-client-config-data support spring boot 3.0
Which issue(s) this PR fixes:
Fixes apolloconfig/apollo#4668
Brief changelog
Replace Log with DeferredLogFactory.
The DeferredLogFactory is only available in spring boot 2.4.3+, so this PR will drop support for spring boot 2.4.0 ~ 2.4.2
Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Read the Contributing Guide before making this pull request.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Write necessary unit tests to verify the code.
[x] Run mvn clean test to make sure this pull request doesn't break anything.
[x] Update the CHANGES log.

The DeferredLogFactory seems only valid for spring boot 2.4.0+, does that mean apollo-client-config-data doesn't support versions prior spring boot 2.4.0 anymore? Is it possible to use other means to do the defer log? e.g. com.ctrip.framework.apollo.core.utils.DeferredLoggerFactory?

the config data loader is only available in spring boot 2.4.0+ , so this PR only drop support for spring boot 2.4.0, 2.4.1, 2.4.2


fix: appType mpa

Description

Fix appType: 'mpa' which currently doesn't work: indexHtmlMiddleware() doesn't work without spaFallbackMiddleware(). In other words MPAs also need spaFallbackMiddleware().
This seems to have been a glitch we missed at #8452.
Additional context
This is a blocker for Telefunc.

What is the purpose of this pull request?

[x] Bug fix
[ ] New Feature
[ ] Documentation update
[ ] Other

Before submitting the PR, please make sure you do the following

[x] Read the Contributing Guidelines.
[x] Read the Pull Request Guidelines and follow the Commit Convention.
[x] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
[x] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
[x] Ideally, include relevant tests that fail without this PR but pass with it.

Could you explain a bit more here @brillout? And we should add a test case too. I thought not having the spa fallback was one of the reasons to have appType: 'mpa'. cc @benmccann

Why doesn't the index middleware work without the spa middleware and is that something we should fix?

The reason for 'mpa' was to avoid setting single: true for sirv(), which this PR preserves.
I unfortunately don't have the bandwidth to implement a test case.
I found a workaround, so this is not urgent/important from my side. But I do think we should fix this for other folks.

@brillout more than a test case, we need to understand why this is needed. I still don't get what are we fixing here.

indexHtmlMiddleware() only serves URLs ending with .html:
https://github.com/vitejs/vite/blob/cc8800a8e7613961144a567f4024b71f218224f8/packages/vite/src/node/server/middlewares/indexHtml.ts#L291
While spaFallbackMiddleware() appends '.html' to URLs:
https://github.com/vitejs/vite/blob/cc8800a8e7613961144a567f4024b71f218224f8/packages/vite/src/node/server/middlewares/spaFallback.ts#L17-L24
In other words:

Fix appType: 'mpa' which currently doesn't work: indexHtmlMiddleware() doesn't work without spaFallbackMiddleware(). In other words MPAs also need spaFallbackMiddleware().

I do agree that a proper fix would be to split out spaFallackMiddleware() in two middlewares (one that appends .html and a second one that does the SPA fallback). This fix is not perfect, but for sure better than the current situation.

I do agree that a proper fix would be to split out spaFallackMiddleware() in two middlewares (one that appends .html and a second one that does the SPA fallback). This fix is not perfect, but for sure better than the current situation.

Nevermind, I implemented another proper fix. See the latest commit.
I believe everything is fixed now.

@benmccann @matthewp @danielroe are you removing the spaFallbackMiddleware in SvelteKit, Astro, Nuxt using its function name? I would like to check if applying this fix in 3.1 is safe. If not, we will need to create another middleware, but that would also be breaking if you need to remove it. Another option is to wait until Vite 4, but this looks like a bug we should fix sooner.

We are not using spaFallbackMiddleware in Nuxt 👍

@danielroe to clarify, it isnt about using it, but if you are manually removing it by function name. If you are removing this middleware, then your app could break as the name is going to change.

We do remove that one in Astro, yes: https://github.com/withastro/astro/blob/fc32e2d94cf0eb19e5715055865d6bb200b8918c/packages/astro/src/vite-plugin-astro-server/index.ts#L31-L43

Thanks for the feedback @matthewp, I see you are now using appType: 'custom' everywhere, no?
https://github.com/withastro/astro/blob/ac03218247763e4782824e220a384fd20ae6d769/packages/astro/src/core/config.ts#L510
If that is the case, then you don't need to remove by hand this middleware anymore (from Vite 3). And you shouldn't be affected by this PR either. appType: 'custom' doesn't include any of the PRs in that list you linked. You can delete that part, it was one of the reasons to add 'custom' 👍🏼
Check the code that is adding the middlewares here https://github.com/vitejs/vite/blob/2d2f2e590eeeef502042a14ea9fe00627d92d256/packages/vite/src/node/server/index.ts#L544

@bluwy SvelteKit is also using appType: 'custom', no? I think we could merge this PR in 3.1 at the end

Yup SvelteKit is using custom too.

I just checked to confirm - we don't remove spaFallbackMiddleware anymore for SvelteKit now that there's the custom mode. The only ones we still have to remove are ['viteServePublicMiddleware', 'viteServeStaticMiddleware']

@jiby-aurum This PR needs a rebase and the naming changes discussed above. If you'd like to help out that'd be great! You can submit a PR to brillout's fork or open a new PR here with the updated changes.

@bluwy sure, happy to help. I opened a new PR with the updated changes #10336


Adjustments of the homepage on mobile

Adjustments to the homepage on mobile

Remove left and right margin in the top, near the „menu” and „cart” buttons
Make slider higher
Change color of circle on „cart” button, like in the design;
Add 2 columns of product boxes;
Add gray background to the photo in the product box;
Add transparency of product photo (20%), like in the design (it changes to 0% after mouseover);
Change color of the headlines of sections, like in the design;
Change colors of fonts in product box, like in the design;
Add mouseover effect on the product box - change color of background, change transparency of the photo from 20% to 0%;
Remove underline of price for mouseover for product box;
Change size of font of headline „New Luna Yoga Collection” and other headlines of sections, like in the design;
Adjust sizes, margins etc. in „New Luna Yoga Collection” section, like in the design;
Turn off automatic sliding of product in „New Luna Yoga Collection” section;
Adjust size and margin of Inspiration blocks in "Get inspired" section
Change font, colors, button in „Subscribe to the newsletter” section - like in the design;
Add Social media section in the bottom - like in the design;
Add mouseover effect for buttons in "social media section”;
Add underline in footer
Add changes in colors of font and underline for mouseover state of links

Improvements:

Adding slider’s pagination (dots) on the slides;
Add „search" and „favorite" button in the top - it requires changes of left and right margins
When there’s no product in cart - there should be only the icon of cart in the top, without circle and number 0;
Change animation of the top while scrolling from the top to bottom, only above the fold;
Add one product box - like in the design;
Add static new section „Promoted offers” with static banners below slider.

There's the view "Homepage on mobile" available here - https://www.figma.com/file/VKyqbHFI55TKIKcQlFLiVpVF/Vue-Storefront-Open-Source.

Please just mark the issues you’re working on or already fixed by marking the specific points in comments

@talalus


Follow man page conventions

The lintian utility (Debian's package lint tool) complains if a utility's man page doesn't start with a "NAME" section.
While I'm here, rename "USAGE" to "SYNOPSIS" and "OVERVIEW" to "DESCRIPTION" to match man-pages(7).

Thanks for maintaining the debian package :). Merged as 2c1ec7 (github doesn't like rebases).


[stdlib] Fix incorrect sort result on small collections with NaN values

What's in this pull request?

Calling sort() or sorted() on a small collection (count < 20)
containing NaN values could return incorrect results, sorting
the individual ranges in the collection between the NaN values
but not the collection as a whole.
E.g.:
[7.0, 6.0, 5.0, .nan, 3.0, 2.0, 1.0].sorted()
would return
[5.0, 6.0, 7.0, .nan, 1.0, 2.0, 3.0]
This case is already inherently handled by the heap sort implementation used for collections with at least 20 elements — this pull request just updates the insertion sort implementation to mirror that behavior and cut down on unexpected behavior.
Resolved bug number: (SR-1990)

Before merging this pull request to apple/swift repository:

[ ] Test pull request on Swift continuous integration.

Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
    Platform     | Comment
    ------------ | -------------
    All supported platforms     | @swift-ci Please smoke test
    All supported platforms     | @swift-ci Please smoke test and merge
    OS X platform               | @swift-ci Please smoke test OS X platform
    Linux platform              | @swift-ci Please smoke test Linux platform

A smoke test on macOS does the following:

Builds the compiler incrementally.
Builds the standard library only for macOS. Simulator standard libraries and
device standard libraries are not built.
lldb is not built.
The test and validation-test targets are run only for macOS. The optimized
version of these tests are not run.

A smoke test on Linux does the following:

Builds the compiler incrementally.
Builds the standard library incrementally.
lldb is built incrementally.
The swift test and validation-test targets are run. The optimized version of these
tests are not run.
lldb is tested.

Validation Testing
    Platform     | Comment
    ------------ | -------------
    All supported platforms     | @swift-ci Please test
    All supported platforms     | @swift-ci Please test and merge
    OS X platform               | @swift-ci Please test OS X platform
    OS X platform               | @swift-ci Please benchmark
    Linux platform              | @swift-ci Please test Linux platform

Lint Testing
    Language     | Comment
    ------------ | -------------
    Python       | @swift-ci Please Python lint

Note: Only members of the Apple organization can trigger swift-ci.

Thanks, but this issue will be fixed in a principled way with the introduction of the spaceship operator <=> and the corresponding changes to the semantics of comparisons for floating point.  Not just the sorting is affected, every algorithm that uses Equatable is affected (even index(of:)).  (See the swift-evolution discussion.)


Host in missing when loading saved project

Whenever I load my saved project, the URL is now missing. See screenshot:

+1 also happens when loading from history.
Host, path, query parameters are not loaded in the UI - although the call does seem to be executing properly.

Hi,
Thank you for issue report. I think it was fixed in yesterday's release. However, try to close the URL panel (to simple view) and check if this is working. And probably your app has been updated already so the issue is fixed. Just let me know.

Confirmed fixed.

Thank you!


Can I add my own colors?

Colorful is a very simple library, you can fork it and add your own colors to your desire, if you understand how it works. Colorful is nothing more than a dynamic theme loader that provides a simple java API to managing large numbers of themes. I've opted to only include the material color pallete.
To answer your question, yes, you can. Though there is no API for it.


Agree on a coding style

Across my recent projects I use the operator-first style. It's actually the philosophy of comma-first, pushed forward to other operators.
It may look strange at first – but if you're interested, here's some reasoning behind it. As well as that:

you get clean diffs – only one line changed when you add/remove a value to a JSON/JS file;
any operator is visible and understandable at the first glance – in western cultures we scan everything from left to right;
I personally like how you get the left edge aligned like bullets in a list – where every bullet carries a meaning.

Comments? Ideas?

Just like in the real world: when you write a to-do list, you place a comma before writing down a new item unless it's the first one.

In the real world, bullets indicate every item. In Javascipt, trailing commas are valid (but IE<9 will throw up on them).
TBH the operator first is more readable overall. In practice I'm happy to go along with all of this :+1:

@barneycarroll since your suggestion in https://github.com/tomekwi/mithril-n/issues/12 I’ve been using airbnb style for all my projects.
But by the way, I’ve just stumbled upon a todoMVC written in elm: https://github.com/evancz/elm-todomvc/blob/master/Todo.elm#L133. Nice to see how good my original style looks in a pure functional language :) And it looks like they’re using it throughout the community.
Anyway, elm itself is also worth a look. If JavaScript is a language I like, I think I’m falling in love with elm :)

Hey @tomekwi, I was just thinking about you the other day — I wrote a cheeky ultra-minimal function for passing this as the first argument of a supplied function, and was crestfallen when I realised someone had already taken as on NPM ;)
I've been sticking to my guns on coding style for a while, but TBH I haven't seen fit to cement it. It just happens, but I'm not precious. A new guy came in and started coding in his own particular way. He uses less blank lines, puts semi-colons everywhere, avoids spaces between arguments… it's interesting to have the opportunity to reflect on, but it's certainly not a problem :)
I've seen Elm mentioned before. Looks nice and light, although I don't get the propensity for brackets. What draws you to it?

:) I’m sorry, I really didn’t mean to :)

I don't get the propensity for brackets

I thought the same when I first saw some Elm code. But – guess what – we were both wrong. The swarms of brackets we see are just lists ([]), records ({}) or tuples (()).
It’s just that they stand out in a peculiar way. And they stand out because there’s virtually no need for grouping things in function calls.
They have some clever tricks for that. What we’d write as a(b, c, d(e, f)) in JS
would be a b c (d e f) in Elm
– or even a b c <| d e f
– or even a more natural, bash-like d e f |> a b c

What draws you to it?

Four things, really:

They seem to have devised a safe type system without sacrificing expressiveness. These things can be written down optionally – like we write jsDocs – but can just as well be implied by the compiler.

There are no runtime exceptions, so they say. Whatever could possibly go wrong is caught by the compiler.

Purity. Functional programming in JS with its throws, trys, process.exits, and element.setAttributes is often a struggle.

This was the biggest wow for me. Their [package system] detects backwards-incompatible API changes and enforces semver.

I don’t have much experience with Elm yet though. It’s not real love yet, just preliminary flirting :)

Keep up the flirting! :)
I've come to the end of a year developing with Mithril and I gotta say, I'm looking elsewhere. I used to get some satisfaction helping people get to grips with the API, solve edge cases, and trying to propose changes. But I ended up writing a lot of plugins compensating for deficiencies in the core API and in the end… it just became a quagmire. Now whenever somebody says "I thought I'd be able to do this with Mithril" I just have to walk away because my response is "oh yeah well what you have to understand is [wall of text] so use this plugin because [wall of text]".
Instead of fighting against the tide with Mithril I'm thinking of bringing my hard-won experience to developing a component & lifestyle framework for citojs, which is an alternative vdom library inspired by Mithril. The reason I bring this up is that citojs deals with document fragments out of the box. Leo says he's doing a re-write of Mithril inspired by citojs's performance, but TBH I'm not sure how much hope I should hold out given the attitude to recurring issues with the fundamental Mithril APIs.

Wow, amazing how similar our paths are :)
I moved away from Mithril even ealier. After quite a successful project where I used Mithril as a framework I realized that I don’t want a framework after all. Everything I made to be reusable turned out to be useless outside the warm embrace of the framework.
So I tried using Mithril as a library – and it occured to me that that it’s not a library at all.
Then I switched to the library virtual-dom which you surely know. Similar to citojs, so it seems.


DPL-nnn [BUG] 'New' PhiX registration doesn't set study on PhiX aliquots

Describe the bug
In May 2019, we updated the aging PhiX registration page to support dual indexing. However it has taken up to now for PhiX stocks to be depleted, and the page to be used for the first time.
This has revealed that we are no longer setting a study on the registered aliquots. Previously this was hard-coded as study 198 ('Illumina Controls').
PhiX::Stock.generate_stocks should set study_id on the created aliquots.
The study should be retrieved from a helper method on PhiX. See config/phi_x.yml for a good place to store the name/other attributes Either want to use find_or_create_by, or add it to the seeds.
RT Ticket Number
If applicable
To Reproduce
Steps to reproduce the behaviour:

Go to page '...'
Click on button '...'
See error

Expected behaviour
What was expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

Windows or Mac?
Browser Chrome, Firefox, Safari or other?
Browser version (use 'About' to look up)?

Additional context
Add any other context about the problem here.

Given some other stories where they may wish to associate PhiX with different studies, there may be a need for a drop down instead.

https://github.com/sanger/sequencescape/issues/3268


[DO NOT MERGE] Enabling fp16 packet optimizations in Eigen

/cc @ekuznetsov139 @jerryyin @whchung

Can one of the admins verify this patch?

@ekuznetsov139, how did you go about doing the per measurements for fp16 vs fp32 in issue #827 ? I want to see if using the TF built using the changes in this PR makes any improvements

import tensorflow as tf
from tensorflow.keras.applications.densenet import DenseNet201
from tensorflow.keras.models import Model
from tensorflow.keras import backend as K
import numpy as np
import time

K.set_image_data_format('channels_last')

#uncomment to test in float16
#tf.keras.mixed_precision.experimental.set_policy('mixed_float16')
model = DenseNet201()

dim=tf.constant((100*224*224*3,), dtype=tf.int32)
x = tf.random.uniform(dim, dtype=tf.float32)
x=tf.reshape(x, (100,224,224,3))
model.summary()

runtimes=[]
for n in range(10):
	start = time.time()
	preds = model.predict(x,steps=1)
	t=(time.time()-start)
	print(t)
	if n!=0:
		runtimes.append(t)
	x=tf.sin(x*preds[0,0])

runtimes.sort()
print("Median", runtimes[len(runtimes)//2])

be advised that it takes quite a while to start up, especially the first time, when it's generating the MIOpen DB entries (could take 3-5 minutes)

hmm, when I try out Eugene's example
the run with Find Mode

is hanging (3 hours and still in the first run) for fp16 mode.
took about 30 mins (for the first run) for fp32 mode.

If I switch to Immediate mode, I can see an improvement of about 10% with fp16. I get the same 10% improvement with and without the changes in this PR. That is kinda expected, since we have seen that Eigen kernels are typically memory bound, and enabling vector optimizations does not help their preformance.
As for this PR, I first need to upstream the workaround for LeakyRelu function. If that gets accepted, I will push out the PR to upstream the Eigen change. Once that gets accepted and shows up on the TF side, we can checkin the change to drop the extra header includes.

A tangential observation to this PR.
@daniellowell
turns out that Immediate Mode rankings for the results returned are not necessarily accurate.
In a fresh container (in which we have not yet this test in Find DB mode), if we run with

immediate mode enabled (set TF_ROCM_USE_IMMEDIATE_MODE=1)
instruct immediate mode API to return only the best algo (set TF_ROCM_RETURN_BEST_ALGO_ONLY=1)
then fp32 run median time is approx 3.1 s

Now if you let immediate mode API return all algos and let TF code pick the best one by profiling them,  (unset TF_ROCM_RETURN_BEST_ALGO_ONLY), then the fp32 run median time is approx 1.3x. This implies that the best algo returned by immediate mode might not be best.
Note that once you run with Find Mode enabled, this experiment will no longer reproduce the results above, since the Find Mode run will populate the DB with the correct best algo.

You can try to replace the two 100s with smaller numbers, that reduces the startup time proportionally but makes the timing less accurate. At least you'd be able to confirm it runs in fp16.
Re: immediate mode rankings, isn't that precisely what we discussed in a meeting a few weeks ago? With immediate mode enabled, it has no way of picking the "best" option for anything not in the DB, so it'll return GEMM for all misses.
Your times are quite high, I'm seeing ~0.31 s with fp32 and ~0.27 s with fp16.

closing this PR out for now, as we need to fix get the Eigen changes upstreamed and then for TF to move the Eigen pointer beyond that point


Remove ic_launcher.png from library

Library does not need ic_launcher.png. Including it causes build errors in gradle 1.2.3 such as this:
build/intermediates/res/debug/drawable-hdpi-v4/ic_launcher.png: error: Duplicate file.
builder/intermediates/res/debug/drawable-hdpi/ic_launcher.png: Original is here. The version qualifier may be implied.
https://plus.google.com/+DanBachelderZumper/posts/YVuLY7rod6M

This is sorted in the project's new home, this repo is no longer maintained.  https://github.com/anothem/android-range-seek-bar


Allow arbitrary gravity shifts when cropping

In an CMS type application I develop I need to determine the gravity for the image for many different crop sizes.
For example, the person's head in the photography should always be visible and the thumbnail on the main page is different then the thumbnail in the list of articles. If it is placed in the upper left corner then I would have to choose gravity "north" or "west" dependent on the aspect ratio. This is the reason why set of "centre", "north", "east", etc. is not enough.
Additionally, I am trying to add visual tool to the editor to choose the most important part of the photo (always visible), with a single click. For this purpose I need to set arbitrary value for the gravity, e.g. in units of 0-100% in horizontal and vertical dimension.

Hello Marcin, thank you very much for your work on this enhancement.
I understand the need for additional north-east, south-east, south-west and north-west gravities. This would bring things line with *magick's -gravity flag. Perhaps these additional compass points should be exposed in the sharp.gravity object?
Are you able to provide some functional tests to help me understand what the slightly more complex variable (0.0 - 1.0) crop gravity might provide beyond the existing extract feature?

I think the gravity feature does not provide new feature beyond extract in general. You can always first extract area with desired aspect ratio, then scale. With gravity you do not have to check the size of the photo first. For this reason adding noth-east, etc. would be valuable, because it does not require apriori knowledge of aspect ration.
In case of slightly more complex gravity with horizontal and vertical shift between 0-100% the additional benefit is smaller - but in my case I need it :) My use case:
Choose the position of the face in the portrait aspect ratio photo [http://en.wikipedia.org/wiki/Portrait#/media/File:VanGogh_1887_Selbstbildnis.jpg] - lets say 50% from left (horizontal center) 30% from top (shifted). For the crop into landscape banner (e.g. aspect ratio 4:3) gravity center could cut upper part of the head, and gravity top would leave to much white space above and cut the lower part of the face. I want to give full control to the editor of the post, so the photo will look good anywhere in the CMS system will show it.
Just like in the case of the simple gravity - you can always do it extract, but its is harder. You have to check the size of the photo while uploading and store it.
Gravity centre:

Gravity top:

Thanks for providing more info about "variable gravity" @ndziorlg. Your scenario is similar to #130 and your addition would seem to make more sense as an improvement to the extract method. Any thoughts @jonathanong as originator of that request?

Coverage remained the same at 93.01% when pulling 969e882bea99f1d9754b2419482de7a6fe665653 on ndziorlg:master into 783826aa26ca2f3adde21f9dc2f3f065d5f8982e on lovell:master.

@ndziorlg Sorry for the delay getting back to this PR and thanks again for your contributions.
Are you able to separate the features in your excellent work and, at least initially, include only the addition of new northEast, southEast, southWest and northWest attributes to the existing sharp.gravity Object, preferably with associated tests?
The next release is taking shape on the knife branch, so please use that as the PR target.
This should keep separate and therefore allow any deliberation on adding the % to crop vs extract (vs crop+extract) to continue unabated.

:+1:

Hi @martinheidegger, thanks for the +1. Are you able to provide more details of which feature(s) you're referring to as there are a couple of improvements under discussion here?

@lovell Just read the code and really liked what I saw. Having the same properties as GraphicsMagick is a good step ahead. Since sharp's api is already quite departed from gm in other regards it doesn't hurt to me to see the percentage option open. I found the solution clean and superior, so: :+1:

@martinheidegger Thank you!

I'm still very happy to accept a PR that adds support for north-west etc. gravities part of this PR.
Our golang sibling has just added this via https://github.com/DAddYE/vips/commit/6e5942207107df6a405dd72b5302d78814a40139
The addition of #236 should provide enough API for the variable cropping/extracting feature.

Might take a look at pulling in the additional gravities soon if there still isn't movement here.

I briefly looked at using the approach laid out here but it wasn't passing unit tests. In favor of time, I simply extended the existing approach to support these extra gravity settings in pull request #291.

#291 has been merged, adding support for the additional gravity values, thanks @brandonaaron.

v0.11.4 is now available via npm and includes the additional corner gravities part of this PR.
The variable gravity idea should be made possible via #236 - please feel free to continue the discussion there.
Thanks again for your time and suggestions @ndziorlg!


[Deque Analysis] Item Edit "Bitstreams" Tab "serious" accessibility issues

Serious: This issue results in serious barriers for people with disabilities, and will partially prevent them from accessing fundamental features or content. People relying on assistive technologies will experience significant frustration as a result. Issues falling under this category are major problems, and remediation should be a priority.

Deque Analysis Summary
Our Item Edit "Bitstreams" tab has a total of 11 serious accessibility issues (not including color contrast which are handled in other tickets).  (UPDATE AS OF DEC 2023, only 6 issues still appear on this page.  See details below)

Two structure issues with all the buttons on the "Bitstreams" tab:

(ID 470939) "Buttons have same name but different actions."  Every button on this page has no name/label (Upload, download, edit, delete, undo).  Their text should either be in a <button> tag and/or have an aria-label or similar.
(ID 470941) "Non-decorative content is inserted using CSS pseudo-elements.".  Every button on this page (Upload, download, edit, delete, undo) is represented by an icon, but those icons are inserted using CSS :before and :after pseudo-element.

RULE : Non-decorative content MUST NOT be inserted using CSS :before and :after pseudo-elements unless there is a way to access the content with CSS turned off.
HOW TO FIX: Fix this issue by including the content directly in the DOM using HTML
NOTE: This same issue occurs on "Metadata" tab, so this fix should use the same solution as #1193
FIXED BY #2683

(IDs 470962, 471456) "Status message not automatically announced." after discarding changes (on Bitstreams tab & Metadata tab).  When you discard changes, a blue status message appears saying "Changes discarded. Your changes were discarded. To reinstate your changes click the 'Undo' button".  This message is not announced to screen readers.

Fix this issue by using ONE of the following techniques: (1) Set focus to the interstitial message: https://dequeuniversity.com/class/dynamic-updates2/notify-users/move-focus OR (2) Announce the interstitial message via an ARIA live region: https://dequeuniversity.com/class/dynamic-updates2/notify-users/aria-live

(IDs 470965, 471459) "Content visually appears and disappears with no ability to adjust timing." on any alert/status message that appears on either Bitstreams tab or Metadata tab (e.g. the "Changes discarded. Your changes were discarded. To reinstate your changes click the 'Undo' button".)

Fix this issue by doing ONE of the following: (1) Leave the content on the screen until dismissed by the user. OR (2) Allow the user to adjust the amount of time temporary content is displayed on the screen, up to 10 times the default.

(ID 471035, 471039) "Content is lost at 200% zoom" & "Content overlaps other content at 320px width." on Bitstreams tab. When zoomed in or on a 320px wide screen, the name & description columns overlap & become unreadable.
(ID 471042, 471463) "Keyboard focus is lost or misplaced due to user interaction or content update." after clicking on either the "Delete" or "Undo" button.  This issue occurs on both the "Bitstreams" tab and "Metadata" tab.

When the user activates the "Delete" or "Undo" icon, the keyboard focus is lost and on the next keyboard tab keypress, it enters the "Admin Sidebar" logo link.
HOW TO FIX: Fix this issue by explicitly placing focus on a logical element when content is removed, refreshed, or added, for example: (1) For content added to the screen in reaction to a user-fired event, focus should be shifted to the new content - such as in single page applications. (2) For content removed/changed from the screen in reaction to a user-fired event, focus should be shifted to the next logical place in the interaction.

(ID 470739) "id attribute value must be unique". Document has multiple static elements with the same id attribute: p-dad

NOTE: Rated a "minor" issue, not "serious", but it may be simple to fix. If it's not simple, it should be delayed & moved to a different ticket.

Full list of issues is viewable at (requires login): https://axeauditor.dequecloud.com/test-run/0856438a-a19a-11eb-bc31-b7d5be387c86/issues?activeTab=dt-issue&page=0&pageSize=50&sortField=ordinal&sortDir=asc&row=9&filter[severity]=3&filter[type]=issue&filter[page_number]=13
More Information / Tools

Consider using Deque's free Chrome plugin to check your work
Deque's color contrast tool: https://dequeuniversity.com/rules/axe/4.1/color-contrast?application=axeAPI

NOTE: This ticket likely should be worked on with #1193 (Item Edit "Metadata" tab issues) as there is a lot of overlap in the issues on these two tabs.  Additionally, it might be combined with #1190 (Item Edit "Status" tab issues)

Atmire would like to claim this issue as well as https://github.com/DSpace/dspace-angular/issues/1270 and https://github.com/DSpace/dspace-angular/issues/3154, and refactor this page to solve them all

@artlowel : Sounds good.  If possible, I'd appreciate it if you could provide a rough estimate of the work.  This just helps us to track the remaining budget for paid development on accessibility tickets

@tdonohue This will take about 16hrs


Hydration bug wrt resource-dependent content

Describe the bug
If content depends on the result of at least two resources in somewhat non-direct ways, it is possible to get client errors "A hydration error occurred while trying to hydrate an element", where the client seemingly expects the HTML that would be there if both resources have been resolved, but the server sends the fallback for resource 2, with the resolution attached in a


fix(report): use cwd for more accurate reports

Description of change
Replaced path resolution from __dirname to process.cwd to have
more control over the destination of report files.
Associated issue(s)
Resolves #8

[x] The acceptance criteria for all associated issues have been completed, tested, and validated.

PR check-list

:white_check_mark: Please review and check the appropriate items.

1. Code standards compliance

[x] ESLint passes.

2. Code quality

[x] The quality gateways pass with an "A" grade.

Measure
Scores

Complexity

Duplications

Issues

Maintainability

Reliability

Security

3. Test coverage

[x] The source code is 100% covered with passing specs.

:information_source: These tasks are not required to open a PR, and may be addresses while the PR is open.

Coverage remained the same at 100.0% when pulling 9e1cd3251b706ce2e1fafc08359b953ad5c57fa6 on fix/#8-report-destination into ad04e43bf8521c534f9e330ac24c55a508541bc8 on master.


Ctrl-c or Esc doesn't kill the job and so there is no way to stop the prompt without closing vim or waiting till its over.

Thank you @JulesHauchecorne , I'll look into it once https://github.com/David-Kunz/gen.nvim/pull/36 is merged (which changes quite a few things).

Hi @JulesHauchecorne ,
With the newest version, once the window is closed, the job will be destroyed.
Best regards,
David

Amazing Thank you!!


[typescript] VS Code won't use lib ES2015 type definitions

I'm trying to use some ES2015 features (specifically Object.assign).
Since typescript 2, there is built in type definitions for ES2015 using the --lib option and similarly, there is a lib compilerOptions key in the tsconfig.json file.
I have the lib option changed to contain es2015. My project compiles fine with from tsc with no errors but VS Code yells at me for using Object.assign and other ES2015 features.
I see that VS Code actually contains the type definitions in Microsoft VS Code\resources\app\extensions\typescript\server\typescript\lib\lib.es2015.d.ts.
Is there a way to get vs code to use those type definitions? Is this a bug and should this already happen?
I already have webpack including the respective polyfills but I can't seem to get the type definitions working in vs code. Any ideas?
Thanks!

VSCode Version:
1.6.1
OS Version:
Windows 10
Steps to Reproduce:

Use vs code to open a typescript project with es2015 types with an es5 target.
Observe that vs code yells at you

This works for me. What if you restart vs code?

I restarted VS Code and tried it on another windows 7 installation. I still have the same problem. I can provide the whole project folder or any other resources if that helps identify anything.

Just to clarify, vs code is suppose to use the es2015 type definitions if i include the es2015 string in the lib compilerOptions, correct? Is this seemingly a bug or is it my fault?

Yeah, for me, it works like you expect.

I created a brand new typescript project with "lib": ["es2015", "dom"] and Object.assign is working like expected. But my existing typescript project doesn't work and I have the same compiler options for this project. It seems like I'm doing something wrong here or this is some weird edge case.
I've cloned the same project and tested it on three windows machines (one with a brand new vs code installation) and i'm getting the same error. The project is available here (ignore the contents).
Steps to reproduce (if you're so willing):

Clone this
Open folder with code
Navigate to src/example.ts
Observe the errors from Object.assign

It did not work for me right away in vscode insiders. I had to use the version of typescript (2.0.6) bundled with insiders and then it works. Using the bundled version changes "typescript.check.workspaceVersion" to false in .vscode/settings.json.
Works for me in vs code stable if I npm install typescript@next (which is currently<EMAIL_ADDRESS>and then add change "typescript.tsdk" to "./node_modules/typescript/lib" in .vscode/settings.json.
Anyway I'm just the bug is already fixed. Just gotta wait till a new version of typescript to be released


Some questions

Hi I just read about DOC and have some questions. I am developing in python since a few years but never really worked with AI yet. But this project is fascinating me because it may be the help/assistance I have been looking for.
Why am I interested so much in this ?
I love reading scifi books (I have read every big sci-fi book series there is and a lot of lesser known novels).
In the past few month I had a great idea for a scifi novel and have already a outline created for it. My biggest problem is that I am not a writer myself so I can not bring my idea to life or even create a more detailed outline of it.
Since I am a developer myself I already thought there must be something that can help me get around my shortcomings and after reading your paper just now, this sounds very promising.
My question now is can DOC be used to generate longer story's than 3,5k to 4k word long stories ?
I would love to use DOC to create and develop together with it a much longer rough story with me like 30000 to 40000 words long. I know it would probably not be perfect at all but it would be a great starting point for me to bring my idea for a story roughly to life and then just fine-tuning and fixing storyline issues my self. Then I could have a book based on my own idea. That would be awesome.
If writing such long stories is not possible, could DOC help me to create a very detailed outline a few thousand words long ?
If the answer is yes that would be possible then I will definitely test it myself but before investing all the time to understand every detail of DOC I thought it would make the most sense to ask here first.
Best,
Gelsas

Hi Gelsas,
Thanks for reaching out! In principle, this repo is able to generate much longer stories such as the length you're suggesting, but the quality might be worse and you might lose a bit of coherence over time; I haven't tested stories of such length myself. It would also take a very long time to generate a story of that length through the public OPT API (3.5k-4k tokens already might already take a day or more, since each individual API call can take a few seconds), so if you don't have compute to set up your own OPT server you might want to just use GPT3 although the quality will be a bit lower. If I had to guess, the total cost of generating an entire 40k token story using our system through the GPT3 API (using the davinci model, and given an existing outline) would be on the order of $20.
Generating just the outline should also be possible (and in fact is recommended if you're trying to generate a much longer story). I haven't tested generating much more detailed outlines, but you can follow the instructions in the Plan + Outline Generation section of the README to generate the outline, setting --outline-levels to increase the depth of the outline. You could try a value like 5 or 6. There's a lot of filtering / reranking here so I'd guess it would cost $50 or so on the GPT3 API with default settings, but it can be made much cheaper as noted in options in the README.
Since you already have a story idea in mind, you could try to work with the outlining system "interactively" as well, although admittedly the procedure for doing so is a bit convoluted currently. For interactive outlining you'd use the --outline-restart-pkl option: start with a premise and generate using --outline-levels 1, then open the pkl and manually edit the outline object (the saved pickle object is a dict with an 'outline' key containing the outline, which you can print and then index into starting from the root node; then change the text, scene, and selected_entities at each node as needed). Then re-save the pkl and provide it to the plan generation and use --outline-levels 2, etc. (In principle, you could also work with the system interactively when you generate the main story after finishing the outline to help it stay on track, although we didn't add functionality for this yet. The easiest place to add it would probably be at https://github.com/yangkevin2/doc-story-generation/blob/main/scripts/main.py#L175, where you would manipulate beam[0].paragraphs_by_outline_section[outline_section] which will include the passages generated for the current outline item; make sure to also edit the last few passages in beam[0].all_paragraphs to maintain consistency.)
Hope that helps! To be totally upfront, we're not anywhere near the level of a strong human author yet; you can get a sense for average story quality by looking at the example outlines + stories at the end of the appendix in our paper. But if that level of writing looks acceptable to you for just initial outlining/drafting purposes, then go for it, and of course working with the system interactively will make the results a lot better. Please let me know if you have any other questions / difficulties.
Thanks,
Kevin

Hi Kevin,
First of all I want to thank you for this detailed response. It already gives me a better understanding and guidance on what I need to do.
I am currently waiting to hear back from the Alpa guys on Slack but I might not be eligible to use the API, since I am not working for any institute but doing this research as a hobby. Do you know of any other ways to use OPT-175B via an API.
Since I don't think I would be eligible in Facebooks/Metas point of view since I am not someone researching at an institute. Also I am not sure how much compute I would need, do you have some more info regarding that ?
So currently it looks like I will need to go with Option 3: GPT3-175B (easy to get started; worse quality)
My questions here are the following:
Why is it not possible to use the detailed controller when using GTP3-175B?
Since OpenAI just released their chatgpt API: gpt-3.5-turbo (https://openai.com/blog/introducing-chatgpt-and-whisper-apis)
It is 10x cheaper and apparently better than the text-davinci-003 model.
Do you think this could be used instead of the current model that is used?
That would be all questions for know since I couldn't start my tests/experiments yet, but once I start testing I might have some more specific questions.
Just wanted to say thank you again for taking the time to respond to my questions.
Best,
gelsas

Hi Gelsas,
I don't know of other OPT-175B APIs, unfortunately. You would also need a lot of compute to serve OPT-175B; recently they also released the LLaMA models https://ai.facebook.com/blog/large-language-model-llama-meta-ai/ which might be better and wouldn't require quite as much compute, but I'd guess you probably still need multiple high-end GPUs (40-80GBs) to serve it yourself if using the larger models, depending on which one exactly.
The reason we can't use the detailed controller with GPT3-175B is because the detailed controller relies on manipulating the logprobs of tokens at each step of generation. Not only does the GPT3 API severely limit how many logprobs you can get back, but it's unbelievably inefficient to use in this pipeline because it doesn't let you cache computation - you'd have to re-query with an entirely new prompt for every token you generate. The ChatGPT API will have the same issues. The Alpa API doesn't have these limitations (because I added the required functionality myself via a pull request a few months ago, lol). But it's not necessarily a dealbreaker if you can't use the detailed controller due to using GPT3 instead; just expect the model to wander off track away from your outline a bit more frequently. This can probably be remedied to a decent extent by manual intervention if you're willing to spend the effort to work with the system interactively paragraph by paragraph.
As for using ChatGPT or a text-davinci-00X model: during outline generation, due to generating the outline in breadth-first expansion order, you want the model to handle suffix context in addition to just a prefix (i.e., the prompt). Last I checked, text-davinci-003 and ChatGPT still didn't support this; we used text-davinci-002 in the paper. But if they do support suffix context you can swap them out.
For the main story generation where we use the base non-instruction-tuned davinci model, you also need to be a bit careful. My initial experiments with using text-davinci-002 instead were a complete disaster (it's mentioned in a footnote in our earlier Re3 paper https://arxiv.org/abs/2210.06774). I think the prompt we use, which contains hundreds of tokens of context, is totally out of distribution for these instruction-tuned models; in addition, the instruction-tuned models are usually finetuned to produce shorter outputs rather than full-length stories, whereas the base davinci's pretraining set actually contains a lot of novels which is what we want. We observed that text-davinci-002 usually generated maybe 1 paragraph of somewhat reasonable text before reliably starting to repeat itself or degenerating into gibberish. I think these problems are alleviated to some degree with text-davinci-003 and ChatGPT, but not completely gone: if you try to use these models I think you'll usually observe that they write in sort of a "higher-level" style compared to what you want in a story, i.e., they like to "tell" instead of "show."
It's definitely possible that you could get around these limitations with the newer text-davinci-003 and ChatGPT models with better prompt engineering, though, and it's worth exploring further. There are of course potential benefits. For example, text-davinci-003 and ChatGPT are definitely better at staying on-topic and not contradicting the context in the prompt compared to the base davinci model. So if you could resolve the style issues and use them as the inner model that DOC calls during story generation, it'd likely improve some of our metrics.
Hope that gives you some perspective on the possible choices.
Thanks,
Kevin

Hi Kevin,
Thank you for the very detailed response.
I just got approved by meta for the LLaMA models and I am thinking of using vast.ai to rent the GPUs I probably need for this.
I have chatted with a few people and a few of them mentioned they used LLaMA-65B successfully on a single A100 80GB with 8bit quantization.
Using LLaMA is probably much better than using GPT3, correct?
Would it be possible to get some more insights on how I can use the LLaMA models with DOC ?
Can the detailed controller be used when using the LLaMA models ?
I hope you don't mind all these questions. Even if they are maybe "stupid" questions.
Pretty new to working with anything AI/ML related, basically just got into this after reading the DOC paper.
Best,
gelsas

Hi Gelsas,
I haven't actually run the LLaMA models myself but I would guess it's better than GPT3 if you use the detail controller. There's no problem with using the detail controller in principle, but there could be some practical issues with tokenization though-- if the LLaMA models use different tokenization than OPT (I'm not sure if they do - you'd have to check) then you'd have to retrain the detail controller using a model that uses LLaMA tokenization. In this case you'd follow the instructions near the bottom of the readme to retrain it, and you'd probably also have to modify https://github.com/yangkevin2/doc-story-generation/blob/main/story_generation/common/controller/models/fudge_controller.py (see especially the bottom of the file where it has versions for GPT and OPT based models). Retraining might also be complicated since the smallest LLaMA model is 7B, which is a bit large for this purpose, so it would result in the detail controller running more slowly at inference time since it's not very performance-optimized currently. On the other hand, if it turns out that LLaMA uses the same tokenizer as OPT, then you can avoid all this trouble and directly use the existing one I provide in the download.
Finally, you'd have to modify the code that interfaces with the 65B LLaMA model that you're calling, since right now it's assuming the Alpa interface.
TBH, I would consider starting with GPT3 anyway (you wouldn't need LLaMA for the planning stage anyway, only for the main drafting procedure after the planning is done) since it's so much easier to get started and try it out interactively, to get a rough sense of what the system can do. Then you could try to switch to LLaMA if you think it's worth the effort trying to improve it further for your purposes.

Hi Kevin,
As per your suggestion I am starting with GPT3.
I have followed the instructions in the readme.
I ran into the following issue:
C:\Users\gelsas\Desktop\doc-story-generation-main>python -u scripts/main.py --controller none none none longformer_classifier --loader none none none order --controller-load-dir none none none doc_data/ckpt/outline_order_reranker --controller-model-string none none none roberta-large --no-editor --setup-only --outline-levels 3 --save-outline-file output/plan.pkl --log-file output/plan.log --premise PREMISE TEXT HERE --outline-levels 6 C:\Users\gelsas\AppData\Local\Programs\Python\Python310\lib\site-packages\torch\_masked\__init__.py:223: UserWarning: Failed to initialize NumPy: module compiled against API version 0xf but this version of numpy is 0xe (Triggered internally at  ..\torch\csrc\utils\tensor_numpy.cpp:68.)   example_input = torch.tensor([[-3, -2, -1], [0, 1, 2]]) Traceback (most recent call last):   File "C:\Users\gelsas\Desktop\doc-story-generation-main\scripts\main.py", line 7, in <module>     from story_generation.edit_module.entity import *   File "c:\users\gelsas\desktop\doc-story-generation-main\story_generation\edit_module\entity.py", line 15, in <module>     from story_generation.common.util import *   File "c:\users\gelsas\desktop\doc-story-generation-main\story_generation\common\util.py", line 25, in <module>     from flair.data import Sentence   File "C:\Users\gelsas\AppData\Local\Programs\Python\Python310\lib\site-packages\flair\__init__.py", line 25, in <module>     from . import (  # noqa: E402 import after setting device   File "C:\Users\gelsas\AppData\Local\Programs\Python\Python310\lib\site-packages\flair\models\__init__.py", line 1, in <module>     from .clustering import ClusteringModel   File "C:\Users\gelsas\AppData\Local\Programs\Python\Python310\lib\site-packages\flair\models\clustering.py", line 14, in <module>     from flair.embeddings import DocumentEmbeddings   File "C:\Users\gelsas\AppData\Local\Programs\Python\Python310\lib\site-packages\flair\embeddings\__init__.py", line 13, in <module>     from .document import (   File "C:\Users\gelsas\AppData\Local\Programs\Python\Python310\lib\site-packages\flair\embeddings\document.py", line 16, in <module>     from flair.embeddings.token import FlairEmbeddings, StackedEmbeddings, TokenEmbeddings   File "C:\Users\gelsas\AppData\Local\Programs\Python\Python310\lib\site-packages\flair\embeddings\token.py", line 10, in <module>     import gensim   File "C:\Users\gelsas\AppData\Local\Programs\Python\Python310\lib\site-packages\gensim\__init__.py", line 11, in <module>     from gensim import parsing, corpora, matutils, interfaces, models, similarities, utils  # noqa:F401   File "C:\Users\gelsas\AppData\Local\Programs\Python\Python310\lib\site-packages\gensim\corpora\__init__.py", line 6, in <module>     from .indexedcorpus import IndexedCorpus  # noqa:F401 must appear before the other classes   File "C:\Users\gelsas\AppData\Local\Programs\Python\Python310\lib\site-packages\gensim\corpora\indexedcorpus.py", line 14, in <module>     from gensim import interfaces, utils   File "C:\Users\gelsas\AppData\Local\Programs\Python\Python310\lib\site-packages\gensim\interfaces.py", line 19, in <module>     from gensim import utils, matutils   File "C:\Users\gelsas\AppData\Local\Programs\Python\Python310\lib\site-packages\gensim\matutils.py", line 1030, in <module>     from gensim._matutils import logsumexp, mean_absolute_difference, dirichlet_expectation   File "gensim\_matutils.pyx", line 1, in init gensim._matutils ValueError: numpy.ndarray size changed, may indicate binary incompatibility. Expected 96 from C header, got 88 from PyObject

Hi again, I was able to resolve the error above but for this error I have no idea on how to fix it, do you have any recommendations?
Some weights of the model checkpoint at roberta-large were not used when initializing RobertaForSequenceClassification: ['roberta.pooler.dense.bias', 'lm_head.decoder.weight', 'roberta.pooler.dense.weight', 'lm_head.layer_norm.weight', 'lm_head.dense.weight', 'lm_head.layer_norm.bias', 'lm_head.bias', 'lm_head.dense.bias']
- This IS expected if you are initializing RobertaForSequenceClassification from the checkpoint of a model trained on another task or with another architecture (e.g. initializing a BertForSequenceClassification model from a BertForPreTraining model).
- This IS NOT expected if you are initializing RobertaForSequenceClassification from the checkpoint of a model that you expect to be exactly identical (initializing a BertForSequenceClassification model from a BertForSequenceClassification model).
Some weights of RobertaForSequenceClassification were not initialized from the model checkpoint at roberta-large and are newly initialized: ['classifier.out_proj.weight', 'classifier.out_proj.bias', 'classifier.dense.bias', 'classifier.dense.weight']
You should probably TRAIN this model on a down-stream task to be able to use it for predictions and inference.
C:\Users\gelsas\AppData\Local\Programs\Python\Python310\lib\site-packages\transformers\optimization.py:306: FutureWarning: This implementation of AdamW is deprecated and will be removed in a future version. Use the PyTorch implementation torch.optim.AdamW instead, or set `no_deprecation_warning=True` to disable this warning
  warnings.warn(
2023-03-08 16:12:13,095 SequenceTagger predicts: Dictionary with 53 tags: <unk>, O, UH, ,, VBD, PRP, VB, PRP$, NN, RB, ., DT, JJ, VBP, VBG, IN, CD, NNS, NNP, WRB, VBZ, WDT, CC, TO, MD, VBN, WP, :, RP, EX, JJR, FW, XX, HYPH, POS, RBR, JJS, PDT, NNPS, RBS, AFX, WP$, -LRB-, -RRB-, ``, '', LS, $, SYM, ADD
Traceback (most recent call last):
  File "c:\users\gelsas\desktop\doc-story-generation-main\story_generation\plan_module\plan.py", line 267, in generate_plan_info
    outline, (characters, character_strings, infer_attributes_string) = generate_outline(args, premise, setting, characters, character_strings, infer_attributes_string, instruct_model, outline_max_tokens, outline_levels=args.outline_levels, previous_outline=outline)
  File "c:\users\gelsas\desktop\doc-story-generation-main\story_generation\plan_module\plan.py", line 126, in generate_outline
    found_acceptable_outline, characters, character_strings, infer_attributes_string = outline.expand(premise_setting_chars,
  File "c:\users\gelsas\desktop\doc-story-generation-main\story_generation\plan_module\outline.py", line 351, in expand
    filtered_outline_sections = [o for o in outline_sections if simple_outline_section_check(o.strip(), tokenizer=model.tokenizer, min_piece_length=min_piece_length, max_piece_length=max_piece_length, repetition_strings=repetition_strings + [c.text for c in children], repetition_length=repetition_length, levenshtein_ratio=levenshtein_ratio)]
  File "c:\users\gelsas\desktop\doc-story-generation-main\story_generation\plan_module\outline.py", line 351, in <listcomp>
    filtered_outline_sections = [o for o in outline_sections if simple_outline_section_check(o.strip(), tokenizer=model.tokenizer, min_piece_length=min_piece_length, max_piece_length=max_piece_length, repetition_strings=repetition_strings + [c.text for c in children], repetition_length=repetition_length, levenshtein_ratio=levenshtein_ratio)]
  File "c:\users\gelsas\desktop\doc-story-generation-main\story_generation\plan_module\outline.py", line 46, in simple_outline_section_check
    if is_imperative_interrogative(piece):
  File "c:\users\gelsas\desktop\doc-story-generation-main\story_generation\plan_module\outline.py", line 23, in is_imperative_interrogative
    return pos_tag(text)[0].tag == 'VB' # heuristic for imperative: verb for first word
  File "C:\Users\gelsas\AppData\Local\Programs\Python\Python310\lib\site-packages\torch\autograd\grad_mode.py", line 27, in decorate_context
    return func(*args, **kwargs)
  File "c:\users\gelsas\desktop\doc-story-generation-main\story_generation\common\util.py", line 606, in pos_tag
    spans = sentence.get_spans()
TypeError: Sentence.get_spans() missing 1 required positional argument: 'type'

I was able to resolve this aswell. Switched from python 3.10 to 3.8.15
How long should the process approximately take ? To finish the oultine?
It was running for a bit and now it shows this in the plan.log: context length 1025 exceeded artificial context length limit 1024
and this in the command line: Token indices sequence length is longer than the specified maximum sequence length for this model (1025 > 1024). Running this sequence through the model will result in indexing errors
Not sure how to fix that, can you advice what is causing the context length to be exactly 1 character to long ?
This is the content of the plan.log
enerating characters and outline...
Initial Characters (will be filtered down later): 1.

Full Name: Taliyah Sutton

Character Portrait: Taliyah Sutton is a young woman with long brown hair and hazel eyes.

2.

3.

Full Name: Nova Starr

Character Portrait: Nova Starr is a short, slender woman with long blonde hair and green eyes.

4.

Full Name: Zephyr Clarke

Character Portrait: Zephyr Clarke is a tall, lanky man with shortbrown hair and green eyes.

5.

6.

Full Name: Overseer Kaelyn

Character Portrait: Overseer Kaelyn is a tall woman with long curly hair and blue eyes.

7.

8.

Full Name: Senator Cassius

Character Portrait: Senator Cassius is a tall man with short grey hair and blue eyes.

9.

Full Name: Guardian Devon

Character Portrait: Guardian Devon is a tall woman with short blonde hair and green eyes.
Generating initial outline attempt 0
Expanding outline level 1
Total nodes: 1
Expanding node 0
Expansion attempt 0 with temperature 1.2000000000000002
Done expanding outline level 1
Expanding outline level 1
Total nodes: 1
Expanding node 0
Expansion attempt 0 with temperature 1.2000000000000002
Done expanding outline level 1
Expanding outline level 1
Total nodes: 1
Expanding node 0
Expansion attempt 0 with temperature 1.2000000000000002
Done expanding outline level 1
Expanding outline level 2
Total nodes: 1
Expanding node 0
Expansion attempt 0 with temperature 1.2000000000000002
Done expanding outline level 2
Expanding outline level 2
Total nodes: 1
Expanding node 0
Expansion attempt 0 with temperature 1.2000000000000002
Done expanding outline level 2
Expanding outline level 2
Total nodes: 1
Expanding node 0
Expansion attempt 0 with temperature 1.2000000000000002
Done expanding outline level 2
Expanding outline level 2
Total nodes: 1
Expanding node 0
Expansion attempt 0 with temperature 1.2000000000000002
Done expanding outline level 2
Expanding outline level 2
Total nodes: 1
Expanding node 0
Expansion attempt 0 with temperature 1.2000000000000002
Done expanding outline level 2
Expanding outline level 2
Total nodes: 1
Expanding node 0
Expansion attempt 0 with temperature 1.2000000000000002
Done expanding outline level 2
Expanding outline level 2
Total nodes: 1
Expanding node 0
Expansion attempt 0 with temperature 1.2000000000000002
Done expanding outline level 2
Expanding outline level 3
Total nodes: 1
Expanding node 0
Expansion attempt 0 with temperature 1.2000000000000002
Warning: didn't find acceptable outline
Expansion attempt 1 with temperature 1.3000000000000003
Done expanding outline level 3
Expanding outline level 3
Total nodes: 1
Expanding node 0
Expansion attempt 0 with temperature 1.2000000000000002
Warning: didn't find acceptable outline
Expansion attempt 1 with temperature 1.3000000000000003
Warning: didn't find acceptable outline
Expansion attempt 2 with temperature 1.4000000000000004
Warning: didn't find acceptable outline
Done expanding outline level 3
Expanding outline level 3
Total nodes: 1
Expanding node 0
Expansion attempt 0 with temperature 1.2000000000000002
Done expanding outline level 3
Expanding outline level 3
Total nodes: 1
Expanding node 0
Expansion attempt 0 with temperature 1.2000000000000002
Done expanding outline level 3
Expanding outline level 3
Total nodes: 1
Expanding node 0
Expansion attempt 0 with temperature 1.2000000000000002
Done expanding outline level 3
Expanding outline level 3
Total nodes: 1
Expanding node 0
Expansion attempt 0 with temperature 1.2000000000000002
Warning: didn't find acceptable outline
Expansion attempt 1 with temperature 1.3000000000000003
Done expanding outline level 3
Expanding outline level 3
Total nodes: 1
Expanding node 0
Expansion attempt 0 with temperature 1.2000000000000002
Warning: didn't find acceptable outline
Expansion attempt 1 with temperature 1.3000000000000003
Warning: didn't find acceptable outline
Expansion attempt 2 with temperature 1.4000000000000004
WARNING: no entities found, taking previous node's entities
Done expanding outline level 3
Expanding outline level 3
Total nodes: 1
Expanding node 0
Expansion attempt 0 with temperature 1.2000000000000002
Warning: didn't find acceptable outline
Expansion attempt 1 with temperature 1.3000000000000003
Warning: didn't find acceptable outline
Expansion attempt 2 with temperature 1.4000000000000004
Done expanding outline level 3
Expanding outline level 3
Total nodes: 1
Expanding node 0
Expansion attempt 0 with temperature 1.2000000000000002
Warning: didn't find acceptable outline
Expansion attempt 1 with temperature 1.3000000000000003
Done expanding outline level 3
Expanding outline level 3
Total nodes: 1
Expanding node 0
Expansion attempt 0 with temperature 1.2000000000000002
Warning: didn't find acceptable outline
Expansion attempt 1 with temperature 1.3000000000000003
Warning: didn't find acceptable outline
Expansion attempt 2 with temperature 1.4000000000000004
Warning: didn't find acceptable outline
Done expanding outline level 3
Expanding outline level 3
Total nodes: 1
Expanding node 0
Expansion attempt 0 with temperature 1.2000000000000002
Warning: didn't find acceptable outline
Expansion attempt 1 with temperature 1.3000000000000003
Warning: didn't find acceptable outline
Expansion attempt 2 with temperature 1.4000000000000004
Done expanding outline level 3
Expanding outline level 3
Total nodes: 1
Expanding node 0
Expansion attempt 0 with temperature 1.2000000000000002
Warning: didn't find acceptable outline
Expansion attempt 1 with temperature 1.3000000000000003
Done expanding outline level 3
Expanding outline level 3
Total nodes: 1
Expanding node 0
Expansion attempt 0 with temperature 1.2000000000000002
Warning: didn't find acceptable outline
Expansion attempt 1 with temperature 1.3000000000000003
Warning: didn't find acceptable outline
Expansion attempt 2 with temperature 1.4000000000000004
WARNING: no entities found, taking previous node's entities
Done expanding outline level 3
Expanding outline level 3
Total nodes: 1
Expanding node 0
Expansion attempt 0 with temperature 1.2000000000000002
Warning: didn't find acceptable outline
Expansion attempt 1 with temperature 1.3000000000000003
Warning: didn't find acceptable outline
Expansion attempt 2 with temperature 1.4000000000000004
Warning: didn't find acceptable outline
Done expanding outline level 3
Expanding outline level 3
Total nodes: 1
Expanding node 0
Expansion attempt 0 with temperature 1.2000000000000002
Warning: didn't find acceptable outline
Expansion attempt 1 with temperature 1.3000000000000003
Warning: didn't find acceptable outline
Expansion attempt 2 with temperature 1.4000000000000004
Warning: didn't find acceptable outline
Done expanding outline level 3
Expanding outline level 4
Total nodes: 1
Expanding node 0
Expansion attempt 0 with temperature 1.2000000000000002
Done expanding outline level 4
Expanding outline level 4
Total nodes: 1
Expanding node 0
Expansion attempt 0 with temperature 1.2000000000000002
Done expanding outline level 4
Expanding outline level 4
Total nodes: 1
Expanding node 0
Expansion attempt 0 with temperature 1.2000000000000002
Done expanding outline level 4
Expanding outline level 4
Total nodes: 1
Expanding node 0
Expansion attempt 0 with temperature 1.2000000000000002
Warning: didn't find acceptable outline
Expansion attempt 1 with temperature 1.3000000000000003
Warning: didn't find acceptable outline
Expansion attempt 2 with temperature 1.4000000000000004
Done expanding outline level 4
Expanding outline level 4
Total nodes: 1
Expanding node 0
Expansion attempt 0 with temperature 1.2000000000000002
Done expanding outline level 4
Expanding outline level 4
Total nodes: 1
Expanding node 0
Expansion attempt 0 with temperature 1.2000000000000002
Done expanding outline level 4
Expanding outline level 4
Total nodes: 1
Expanding node 0
Expansion attempt 0 with temperature 1.2000000000000002
Done expanding outline level 4
Expanding outline level 4
Total nodes: 1
Expanding node 0
Expansion attempt 0 with temperature 1.2000000000000002
Done expanding outline level 4
Expanding outline level 4
Total nodes: 1
Expanding node 0
Expansion attempt 0 with temperature 1.2000000000000002
Warning: didn't find acceptable outline
Expansion attempt 1 with temperature 1.3000000000000003
Done expanding outline level 4
Expanding outline level 4
Total nodes: 1
Expanding node 0
Expansion attempt 0 with temperature 1.2000000000000002
Warning: didn't find acceptable outline
Expansion attempt 1 with temperature 1.3000000000000003
Done expanding outline level 4
Expanding outline level 4
Total nodes: 1
Expanding node 0
Expansion attempt 0 with temperature 1.2000000000000002
Done expanding outline level 4
Expanding outline level 4
Total nodes: 1
Expanding node 0
Expansion attempt 0 with temperature 1.2000000000000002
WARNING: too many logit biases in outline character description generation, skipping uppercase biases
Warning: didn't find acceptable outline
Expansion attempt 1 with temperature 1.3000000000000003
Warning: didn't find acceptable outline
Expansion attempt 2 with temperature 1.4000000000000004
WARNING: too many logit biases in outline character description generation, skipping uppercase biases
WARNING: too many logit biases in outline character description generation, skipping uppercase biases
WARNING: no entities found, taking previous node's entities
Done expanding outline level 4
Expanding outline level 4
Total nodes: 1
Expanding node 0
Expansion attempt 0 with temperature 1.2000000000000002
WARNING: too many logit biases in outline character description generation, skipping uppercase biases
WARNING: too many logit biases in outline character description generation, skipping uppercase biases
Done expanding outline level 4
Expanding outline level 4
Total nodes: 1
Expanding node 0
Expansion attempt 0 with temperature 1.2000000000000002
WARNING: too many logit biases in outline character description generation, skipping uppercase biases
Warning: didn't find acceptable outline
Expansion attempt 1 with temperature 1.3000000000000003
WARNING: too many logit biases in outline character description generation, skipping uppercase biases
WARNING: too many logit biases in outline character description generation, skipping uppercase biases
Done expanding outline level 4
Expanding outline level 4
Total nodes: 1
Expanding node 0
Expansion attempt 0 with temperature 1.2000000000000002
WARNING: too many logit biases in outline character description generation, skipping uppercase biases
WARNING: too many logit biases in outline character description generation, skipping uppercase biases
Done expanding outline level 4
Expanding outline level 4
Total nodes: 1
Expanding node 0
Expansion attempt 0 with temperature 1.2000000000000002
WARNING: too many logit biases in outline character description generation, skipping uppercase biases
WARNING: too many logit biases in outline character description generation, skipping uppercase biases
Done expanding outline level 4
Expanding outline level 4
Total nodes: 1
Expanding node 0
Expansion attempt 0 with temperature 1.2000000000000002
WARNING: too many logit biases in outline character description generation, skipping uppercase biases
Warning: didn't find acceptable outline
Expansion attempt 1 with temperature 1.3000000000000003
WARNING: too many logit biases in outline character description generation, skipping uppercase biases
Warning: didn't find acceptable outline
Expansion attempt 2 with temperature 1.4000000000000004
WARNING: too many logit biases in outline character description generation, skipping uppercase biases
WARNING: too many logit biases in outline character description generation, skipping uppercase biases
WARNING: too many logit biases in outline character description generation, skipping uppercase biases
Done expanding outline level 4
Expanding outline level 4
Total nodes: 1
Expanding node 0
Expansion attempt 0 with temperature 1.2000000000000002
WARNING: too many logit biases in outline character description generation, skipping uppercase biases
WARNING: too many logit biases in outline character description generation, skipping uppercase biases
WARNING: too many logit biases in outline character description generation, skipping uppercase biases
WARNING: too many logit biases in outline character description generation, skipping uppercase biases
WARNING: too many logit biases in outline character description generation, skipping uppercase biases
Done expanding outline level 4
Expanding outline level 4
Total nodes: 1
Expanding node 0
Expansion attempt 0 with temperature 1.2000000000000002
Warning: didn't find acceptable outline
Expansion attempt 1 with temperature 1.3000000000000003
Warning: didn't find acceptable outline
Expansion attempt 2 with temperature 1.4000000000000004
WARNING: too many logit biases in outline character description generation, skipping uppercase biases
WARNING: too many logit biases in outline character description generation, skipping uppercase biases
WARNING: too many logit biases in outline character description generation, skipping uppercase biases
WARNING: too many logit biases in outline character description generation, skipping uppercase biases
WARNING: too many logit biases in outline character description generation, skipping uppercase biases
Done expanding outline level 4
Expanding outline level 4
Total nodes: 1
Expanding node 0
Expansion attempt 0 with temperature 1.2000000000000002
WARNING: too many logit biases in outline character description generation, skipping uppercase biases
WARNING: too many logit biases in outline character description generation, skipping uppercase biases
Warning: didn't find acceptable outline
Expansion attempt 1 with temperature 1.3000000000000003
WARNING: too many logit biases in outline character description generation, skipping uppercase biases
WARNING: too many logit biases in outline character description generation, skipping uppercase biases
WARNING: too many logit biases in outline character description generation, skipping uppercase biases
WARNING: too many logit biases in outline character description generation, skipping uppercase biases
context length 1025 exceeded artificial context length limit 1024

retrying...
context length 1025 exceeded artificial context length limit 1024

retrying...
context length 1025 exceeded artificial context length limit 1024

retrying...
context length 1025 exceeded artificial context length limit 1024

retrying...
context length 1025 exceeded artificial context length limit 1024

retrying...
context length 1025 exceeded artificial context length limit 1024

retrying...
context length 1025 exceeded artificial context length limit 1024

retrying...
context length 1025 exceeded artificial context length limit 1024

retrying...
context length 1025 exceeded artificial context length limit 1024

retrying...
context length 1025 exceeded artificial context length limit 1024

retrying...
context length 1025 exceeded artificial context length limit 1024

retrying...
context length 1025 exceeded artificial context length limit 1024

retrying...
context length 1025 exceeded artificial context length limit 1024

retrying...
context length 1025 exceeded artificial context length limit 1024

retrying...
context length 1025 exceeded artificial context length limit 1024

retrying...
context length 1025 exceeded artificial context length limit 1024

retrying...
context length 1025 exceeded artificial context length limit 1024

retrying...
context length 1025 exceeded artificial context length limit 1024

retrying...
context length 1025 exceeded artificial context length limit 1024

retrying...
context length 1025 exceeded artificial context length limit 1024

retrying...
context length 1025 exceeded artificial context length limit 1024

Oh, now that I think about it, we never ran into this during our own tests since we limited the depth (number of outline levels) to 3 for our experiments. The problem is that we limit the GPT3/OPT context length for all methods to 1024 for fair comparison with baselines during our paper experiments, and you can end up exceeding that limit if you increase the depth further. You should be able to remove this artificial limitation by changing the --max-context-length argument, which defaults to 1024. The GPT3 API should support 2048 or 4096 depending on the model.

I have added --max-context-length 2048 to my command but now I am getting this error:
Token indices sequence length is longer than the specified maximum sequence length for this model (1027 > 1024). Running this sequence through the model will result in indexing errors

The initial warning can be ignored -- it's complaining because we use the GPT2 tokenizer. GPT2 presumably has a max context length of up to 1024, but GPT3 shares the same tokenizer while using a longer context length.
I see in your initial command from earlier that you set --outline-levels to 6, which is probably excessive; I don't think I'd go more than 4 or 5. The outline itself is going to be growing exponentially in size as you increase the number of levels, and the time will increase correspondingly as well. You could run it with --outline-levels set to 3 first to verify that it works, then try 4, then maybe 5 if you still want it to be longer? Using 3 levels of outline usually takes several minutes, so 4 should take under an hour (probably not particularly close). 5 might take a couple of hours though if I had to guess. I'm not too surprised that you hit 5-6 hours with 6 levels of outline. I'm guessing that in your most recent run, it probably finished generating the first 5 levels of the outline and crashed while doing the 6th (you could check the logs if you saved them)
Your most recent crash looks like it's due to the context length getting too long for outline order reranker. The context length was fine for the length that we used in our paper experiments, but the outline is getting too long for it with your current settings. The problem might just go away if you decrease --outline-levels to 4 or 5, but otherwise you might need to retrain the outline order reranker described at the bottom of the readme using a model with longer context length (e.g. longformer instead of roberta); alternatively, truncate the context being fed into it as input at https://github.com/yangkevin2/doc-story-generation/blob/main/story_generation/plan_module/outline.py#L400 .
Sorry for all the trouble; we haven't carefully tested larger values of --outline-levels so it's somewhat new ground for me as well.