make: Don't strictly require go1.12

The gopherjs documentation states:
    GopherJS requires Go 1.12 or newer.

This commit prevent offline builds from erroring out when using a recent version of go.

GopherJS is a thorn in our project's side. It's been neglected and we need to migrate off of it. Until we do, we can't just pick any Go version to use with GopherJS... we have to use only a version of Go that GopherJS is compatible with.
To do a Perkeep build, I think we require two version of Go currently. @mpl, is that right?

GopherJS is a thorn in our project's side. It's been neglected and we need to migrate off of it. Until we do, we can't just pick any Go version to use with GopherJS... we have to use only a version of Go that GopherJS is compatible with.
To do a Perkeep build, I think we require two version of Go currently. @mpl, is that right?

I checked the issue tracker for GopherJS and it does look like it only runs on v1.12 for now, which contradicts the bits in the documentation that I linked above.
In the end I built Perkeep in “online mode” because even when skipping this version check to accommodate GopherJS, make.go complained that the code had to be located in $GOPATH, which isn't possible when building a package (ArchLinux package I made to build on ARM).

I checked the issue tracker for GopherJS and it does look like it only runs on v1.12 for now, which contradicts the bits in the documentation that I linked above.
In the end I built Perkeep in “online mode” because even when skipping this version check to accommodate GopherJS, make.go complained that the code had to be located in $GOPATH, which isn't possible when building a package (ArchLinux package I made to build on ARM).

Off-topic question, since I don't want to create another irrelevant issue: do you have any plans for Perkeep (short/long term)? I see that @mpl stopped working on it, and neither them nor you are on the IRC channel.

Off-topic question, since I don't want to create another irrelevant issue: do you have any plans for Perkeep (short/long term)? I see that @mpl stopped working on it, and neither them nor you are on the IRC channel.

GopherJS is a thorn in our project's side. It's been neglected and we need to migrate off of it. Until we do, we can't just pick any Go version to use with GopherJS... we have to use only a version of Go that GopherJS is compatible with.
To do a Perkeep build, I think we require two version of Go currently. @mpl, is that right?

Yes, to do a full offline build, we probably need the specific old version for gopherjs (Go 1.12?), and then for the actual Perkeep build the latest version.

GopherJS is a thorn in our project's side. It's been neglected and we need to migrate off of it. Until we do, we can't just pick any Go version to use with GopherJS... we have to use only a version of Go that GopherJS is compatible with.
To do a Perkeep build, I think we require two version of Go currently. @mpl, is that right?

Yes, to do a full offline build, we probably need the specific old version for gopherjs (Go 1.12?), and then for the actual Perkeep build the latest version.

Note that we may be able to simplify the gopherjs build system by migrating to https://github.com/goplusjs/gopherjs which support 1.15.

Note that we may be able to simplify the gopherjs build system by migrating to https://github.com/goplusjs/gopherjs which support 1.15.

oh, that is interesting, thanks.

oh, that is interesting, thanks.


Basic git authentication support needed for Windows environments

Windows Chef Developer Here.  All our systems are Windows (client, server, source control, CI, etc - everything).
The primary Windows-centric source control systems (TFS2013 and Visual Studio Online) do not support ssh keys and only support the use of oAuth or username/password for git repositories.
Without support for basic authentication features in this git cookbook, the use of git within Windows-centric environments with enterprise class development systems is not possible.
Thanks!

I second this.  We also need support for Visual Studio Online.

:+1:

This cookbook installs a git client on Windows. What are you looking for beyond that? Do you have ideas about how it could be implemented?

@joshburt I'm going to go ahead and close this. If you folks have ideas about how this could be implemented, please do reopen with your thoughts.
Thanks!


No beta versions for unlisted addons (bug 1160654)

Fixes bug 1160654

r+. Nice. I'll rebase once this is merged.


[10.1.x] ISPN-11323 Isolate JGroupsTransport MBean references to private methods

https://issues.redhat.com/browse/ISPN-11209

Merged. Thanks @wburns !


Add Mayastor data plane network bind to dedicated NIC

Is your feature request related to a problem? Please describe.
We have two NICs, one plan for storage network (OpenEBS), another plan for service application.
if we want to bind the mayastor dataplane with the NIC for storage network, how can I do it?
I saw the configs in mayastor-daemonset.yaml as following, but sure how to set the dedicated NIC with ip range.
mayastor-daemonset.yaml:
spec:
hostNetwork: true
# To resolve services from mayastor's namespace
dnsPolicy: ClusterFirstWithHostNet
Describe the solution you'd like
we can set hostNetwork: true and set mayastor daemonset configmap to IP/subnetwork for a NIC/VF.
The Mayastor network can separate with application service network.
Describe alternatives you've considered
OpenEBS Mayastor network based on SRIOV/Multus CNI.
Additional context
N/A

Looks like the same as : https://github.com/openebs/mayastor/issues/1048
This really a critical thing. It should be able to use separate networks...

@silverhandy @kpoos Thank you for your input and suggestion.  I hope you won't mind if I ask some clarifying questions.
Question 1:  Why do you consider this to be a 'critical' requirement?  What is your primary driver for storage network segregation?  Is it a matter of:

performance/latency - QoS, rate limiting, reserved BW etc.?
security?
availability?
all of the above / something else ?

Question 2: On the face of it , any solution appears (to me, at least) to be very tightly coupled with the CNI implementation that you intend to use.  If we made this feature available, which one do you think we should choose to support?  Multus?  DANM?

Actually if you have separate NIC for storage on node level, which is quite often used in on-prem data center solutions, you need to set up mayastor not to use the cluster networking but to use the other data channel on the second nic. In our solution - which was prior mayastor v1.0 - I just changed the data plane (mayastor) and the mayastor-csi pods command lines with overwriting the the MY_NODE_NAME / MY_POD_IP env vars (which is in that case was the node IP as it runs in hostNetwork: true mode, so I was able to get  mayastor listen on the 2nd interface, while all the other communication goes in the k8s network. In our case this is needed, as the storage network has 10G interfaces and the normal network has only 1G interfaces.
I would say, it is mostly performance related, however a separate storage network is good to have in security and availability point of view as well.
I think, in such a case - when you synch data over the network - it is mandatory to have a selectable interface on the binary, which is used for data communication in cases when you have several interfaces on node level.
As I previously said, it is nothing to do with the CNI, because these components run in the host network. It is just should be one parameter, to say to the binary, which network interface/IP to use for the data communication on the data plane layer, mostly for volume resynchronization. The other communication which is taken place in the k8s cluster networking can remain in the normal way as it is.

Thanks.  Good points, well made.  For 'supported', I should have really said 'tested'.  If there were an early consensus on likely use-case(s), this might help guide the selection of system test environment(s) where it comes to that functionality, for anyone wishing to contribute to it (the maintainers included).

The code where the listen address is determined is in subsys/nvmf/target.rs Currently; it grabs whatever get_ipv4_address() returns. This was done very early during the development of mayastor and very limited indeed.
A proper approach would be to add appropriate gRPC methods to add and/or remove listeners on the fly and perhaps a new ENV (for easy deployment) which would accept a list of IP & port tuples (separated by ;).  The latter in particular is pretty trivial to do. @valkolaci if you want to draft the patches I'd be happy to review them.

This feature (ability to define target port binding on the basis of subnet, interface name or specific IP address) has been implemented and is currently in test.
Targeting version 2.0.0, which is currently expected to be released within the next 30-60 days.

do we have an updated release date on this feature?

@Daxcor69 We're still targeting this for Mayastor 2.0.  Provisionally, we're looking at early to mid-September for that release, based on current progress.

The changes for this feature have already been merged into the develop branch.
In lieu of formal documentation at this time, the implementation chosen was to add the argument --tgt-iface to the mayastor binary (the environment variable NVMF_TGT_IFACE may be set instead, if preferred.)
Usage:
--tgt-iface ip:<IP_ADDRESS> : binds the target to the specified IPv4 address
--tgt-iface subnet:<IP_ADDRESS>/24 : binds to the IPv4 address which matches the specified subnet mask (CIDR notation)
--tgt-iface mac:00:12:5c:74:2d:cd : binds to the IPv4 address of the interface with the specified MAC address
--tgt-iface name:eth0 : binds to the IPv4 address of the interface with the specified name
If a match cannot be made, then the mayastor container will terminate.  For the official release, this configurable parameter will be included in the Helm chart's values.yaml file.


Step 5 last bullet

We are trying to re deploy the AEM  code with the changes as part of the last bullet in step 5(mvn -PautoInstallPackage clean install)
The complete log is attache
aem-redploy.txt
d

Hi Girish.
Could you help verify:

NPM is available on your system: npm -v
GIT is installed on your system: git -v (NPM requires GIT to access packages which are available on public GitHub repository - in our case - https://github.com/adobe/json-formula).
On windows - you are running the command using Run as Administrator option.

the error went away!!!!. I  am good now

Yes- the previous steps worked fine
Only at the last step it is failing
Sent from my iPhone
On Aug 11, 2022, at 5:35 PM, Sudhanshu @.***> wrote:

EXTERNAL: Use caution when clicking on links or opening attachments.
Hi Girish.
Could you help verify:

NPM is available on your system: npm -v
GIT is installed on your system: git -v (NPM requires GIT to access packages which are available on public GitHub repository - in our case - https://github.com/adobe/json-formulahttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fadobe%2Fjson-formula&data=05|01|gbedekar%40adobe.com|fa2e4f38404d4fdeee2308da7bfa93af|fa7b1b5a7b34438794aed2c178decee1|0|0|637958613396572262|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=zasaN3M70TXyv4Rs7ywW%2BEvtkD58hgi6Gk0%2F%2BDu8CIk%3D&reserved=0).
On windows - you are running the command using Run as Administrator option.

—
Reply to this email directly, view it on GitHubhttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fadobe%2Faem-forms-af-runtime%2Fissues%2F6%23issuecomment-1212620148&data=05|01|gbedekar%40adobe.com|fa2e4f38404d4fdeee2308da7bfa93af|fa7b1b5a7b34438794aed2c178decee1|0|0|637958613396572262|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=WGt%2BcKvYD9hdpJdnPk2kL0xsvdWQ%2FG5uTxazpUrMnpE%3D&reserved=0, or unsubscribehttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAEGW54FIVUY7B5AKQDOP743VYWL5RANCNFSM56FV7IVA&data=05|01|gbedekar%40adobe.com|fa2e4f38404d4fdeee2308da7bfa93af|fa7b1b5a7b34438794aed2c178decee1|0|0|637958613396572262|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=O3S1KIYaxDcr5T4CFIy7eBFmb4RcSxEZD4u1ct%2Bk5g4%3D&reserved=0.
You are receiving this because you authored the thread.Message ID: @.***>


Allow to train policy on actual user messages

Right now the policy is trained on intents, the labels assigned to the incoming messages from NLU.
There are models we want to try out that would benefit from the additional information the whole message provides. The training data passed into the Rasa Core policy should contain the nlu user message.

Closed in Rasa Open Source 2.2 with the introduction of end-to-end

Closed in Rasa Open Source 2.2 with the introduction of end-to-end


boards: shields: add TI BOOSTXL-SENSORS

This shield adds digital sensors to a TI LaunchPad development kit. It
is useful for exercising the I2C interface.

We need a way to specify that this shield is compatible only with the TI LaunchPad dev Kit.
I don't see other good way than defining a connector, similarly to what is done for arduino connector.

I have updated this to use the connector in #16392.


Blank window in browser

Hello guys,
after a lot of problems I finally got the tool opening a browser window (tried in Edge, Chrome and Opera) on Win10 but it seems to be only the basic scheme/design of it, without any buttons or something in it. I'm not that deeply into programming, so I have no idea what caused this and would appreciate any help I can get - Thanks in advance! (PS: just in case: I've tried to turn off AdBlock, didn't do anything)

A complete reinstall did it for me, works like a charm now!

I have same problem ? reinstall  what?


Write Part - 2 Step - 8 & unit test

Implement Step08Controller and write all unit tests. Verify the display name of the test conforms to the pattern of "Part X Step Y". Follow the standardize naming, comments, etc. to be consistent.

This is similar to Part 01 Step 14 however, there is some different logic.  Assigning for review of <IP_ADDRESS> & <IP_ADDRESS>


Max entries per page resets on language switch

Changing the maximum entries per page\

on the events page (/#/events/events) or
on the series page (/#/events/series) \

to something else than 10 and your are going to switch language (i.e. to 100) the max. entires per page are reset to 10.
Expected to keep the value when switching languages in the UI.

Likely related: https://github.com/opencast/opencast-admin-interface/issues/447


no such file or directory, open '/xxx/package.json

sudo npm install --save @google-cloud/speech
npm WARN saveError ENOENT: no such file or directory, open '/Users/xxx/package.json'
npm WARN enoent ENOENT: no such file or directory, open '/Users/xxx/package.json'
npm WARN xxx No description
npm WARN xxx No repository field.
npm WARN xxxNo README data
npm WARN xxx No license field.
Environment details

OS:  MacOS 10.15.2
Node.js version: 13.5.0
npm version: 6.13.4

Can I ignore these warnings???

Hey @bbookman, I"m not seeing this issue locally:
+<EMAIL_ADDRESS>added 92 packages from 109 contributors and audited 291 packages in 5.127s
found 0 vulnerabilities

I would not recommend installing any modules with sudo, I wonder if this is part of the issue. Could you try:
mkdir test
cd test
npm init
npm i @google-cloud/speech

I used sudo simply because i was already running into the issue w/o, it was
an attempt at a work around.
for that last line...  that's executed in npm ???  when i do that I get:
package name: (test) i @google-cloud/speech
Sorry, name can only contain URL-friendly characters.
package name: (test) @google-cloud/speech
version: (1.0.0)
On Mon, Jan 6, 2020 at 3:41 PM Benjamin E. Coe<EMAIL_ADDRESS>wrote:

Hey @bbookman https://github.com/bbookman, I"m not seeing this issue
locally:

<EMAIL_ADDRESS>added 92 packages from 109 contributors and audited 291 packages in 5.127s
found 0 vulnerabilities

I would not recommend installing any modules with sudo, I wonder if this
is part of the issue. Could you try:
mkdir test
cd test
npm init
npm i @google-cloud/speech
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/googleapis/nodejs-speech/issues/499?email_source=notifications&email_token=AD5ZUQ23KYBZQ3YKLHT5KWTQ4O6SDA5CNFSM4KDMUPJKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIHFGNA#issuecomment-571364148,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AD5ZUQ4EJ43VITLLAJHBRILQ4O6SDANCNFSM4KDMUPJA
.

--
Bruce Bookman

@bbookman I believe you're in an environment that has either a corrupt package-lock.json, or a partial install in node_modules:
mkdir test
cd test
npm init
npm i @google-cloud/speech

:point_up: the following should all be run in the command line, and creates a fresh npm project with a fresh install of @google-cloud/speech.
I believe the error:
npm WARN saveError ENOENT: no such file or directory, open '/Users/xxx/package.json'
npm WARN enoent ENOENT: no such file or directory, open '/Users/xxx/package.json'
npm WARN xxx No description

:point_up: is unrelated to @google-cloud/speech, and is likely that you're in a folder that's not an npm module, or that has a slightly odd configuration.

Sorry for being dim...  I did exactly as you described (test folder) and
received the same errors.  How is that "likely that you're in a folder
that's not an npm module"?  What would you do to debug?  I'd like to solve
this problem.  Also, unfortunately I'm not a node.js expert and am running
a little blind here.
On Tue, Jan 7, 2020 at 9:51 AM Benjamin E. Coe<EMAIL_ADDRESS>wrote:

@bbookman https://github.com/bbookman I believe you're in an
environment that has either a corrupt package-lock.json, or a partial
install in node_modules:
mkdir test
cd test
npm init
npm i @google-cloud/speech
☝ the following should all be run in the command line, and creates a
fresh npm project with a fresh install of @google-cloud/speech.
I believe the error:
npm WARN saveError ENOENT: no such file or directory, open '/Users/xxx/package.json'
npm WARN enoent ENOENT: no such file or directory, open '/Users/xxx/package.json'
npm WARN xxx No description
☝ is unrelated to @google-cloud/speech, and is likely that you're in a
folder that's not an npm module, or that has a slightly odd configuration.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/googleapis/nodejs-speech/issues/499?email_source=notifications&email_token=AD5ZUQYLE4A2NQUGQ4JCZMLQ4S6LPA5CNFSM4KDMUPJKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIJWS6A#issuecomment-571697528,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AD5ZUQ5U5WZCXJYTZEG22L3Q4S6LPANCNFSM4KDMUPJA
.

--
Bruce Bookman

@bbookman I've also tested a fresh install on OSX, I believe the root of the problem is that you have a bad Node.js installation on your computer. I suggest you use nvm to configure your macbook for development, and try with a fresh installation of Node's current LTS 12:
nvm install 12
nvm use 12
mkdir test-installation
cd test-installation
npm init
npm i @google-cloud/speech

The only other possible problem I can think of, if a fresh installation of Node.js continues to fail, is that perhaps you're on a read only mount or something?


Aux 1 timer

Is it possible to add a timer that can track the amount time that Aux 1 has diverted power to a SSR to heat water ?

no, the app just reads data stored in the controller.
If you're into tinkering with arduino/ESP32 you could take a look at my
project on github (https://github.com/graham22/ClassicMQTT)
once the data in published to MQTT you could use NodeRed along with
InfluxDB and Grafana to track the information similar to (
https://www.youtube.com/watch?v=JdV4x925au0)
On Mon, Apr 8, 2019 at 1:01 PM psheppit<EMAIL_ADDRESS>wrote:

Is it possible to add a timer that can track the amount time that Aux 1
has diverted power to a SSR to heat water ?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/graham22/Classic/issues/6, or mute the thread
https://github.com/notifications/unsubscribe-auth/AFGATTXGpSR78JqLhU8jVxqWwXDx9l-Oks5ve3X0gaJpZM4ciqmr
.

--
Graham A. Ross
(613) 769-1331


fixed labelForTutorialSwipe alignment on iPhone 6 devices by using windo...

fixed labelForTutorialSwipe alignment on iPhone 6 devices by using window width instead of the device width of previous devices. fixed tutorialLabel which would get cutoff when exceeding a certain number of characters and height.

Hi @AfonsoTsukamoto , will this get pulled in? I'm using cocoa pods to pull in your controller, and have this fix implemented in my local, but if I do a pod update, it gets overwritten. Not sure a better way to manage this other than trying to make sure this gets pulled in!

Hey! Sorry for the (longgggg) delay. I'll review it now.
Once again, sorry.


Allow dataset contact to be different?

Currently, the dataset contact person is the creator of the dataset. Would be nice if that wasn't the case! Some cases where this is problematic:

when the creator moves on and doesn't want responsibility for the project
when the creator is the admin account
when the creator is a member of staff in DDI who has created a dataset for someone but shouldn't be the contactable person for it

Currently we have code that just uses creator_user_id as the recipient for the email. Perhaps we could use the new CKAN collaborators stuff? Either send to all admins or maybe add a new "Contact" role?
h/t @essvee

This is fixed and ready for release.
The change only takes effect if admin collaborators have been added to the dataset, otherwise the original functionality of emailing the creating user remains. If there are admin collaborators specified then they will be emailed when the "contact dataset" form is used.


WIP: Implement kube-master HA for multiple masters

We need to cover HA for kube-master components. Kubernetes HA cluster guide [1]. #725
User specifies multiple nodes under the master role [2]. Ansible should seamlessly create a cluster with a collection of masters, with api services appropriately load balanced, and other kube-master components leader-elected.

[x] Enable static etcd clustering (working with #711)
[x] Deploy kube-apiserver on multiple nodes
[x] Load balance kube-apiserver instances (e.g. add haproxy/keepalived roles)
[x] Create controller-manager & scheduler services for each apiserver (leader-elected)

(optional, good to have)

[x] add in support to run master components in containers (related, #673)

[1] http://kubernetes.io/docs/admin/high-availability/
[2] https://github.com/kubernetes/contrib/blob/master/ansible/inventory.example.ha

@danehans @stephenrlouie @rutsky

@adamschaub if this is WIP, can you describe what is your plan and what is left to do to achieve K8s HA deployment?

Related issue: https://github.com/kubernetes/kubernetes/issues/18174

@rutsky keep in mind that @adamschaub work will include a load-balancer role within contrib/ansible, so https://github.com/kubernetes/kubernetes/issues/18174 should not be an issue as kubelet/proxy will connect to a vip. Let em know if I missed anything with the related issue.

Sorry for the messy commits, but I wanted to get my changes out there for visibility. I've separated master tasks into single-master and ha-master groups, based on the number of nodes in 'masters' group.
No load balancing yet, and the HA tasks are CoreOS dependent at the moment.
Each master node runs an instance of kube-apiserver (via hyperkube), and kube-scheduler/kube-controller-manager are leader elected using podmaster. I'm finishing up load-balancing configuration with haproxy+keepalived pods.

@adamschaub looks like you're making good progress.
@eparis @rutsky I would appreciate you taking time to review this WIP PR to add Master HA based on the k8s ha guide: http://kubernetes.io/docs/admin/high-availability/

@danehans @eparis @rutsky I've removed the haproxy/keepalived bits. After discussion with @danehans, we've decided to add haproxy/keepalived under a separate PR.
I've tested this with CentOS 7 and CoreOS (stable) on a virtualbox environment. If you add more than one master node, kubelet is installed on all masters and master components are run on pods and leader-elected as required.
Each master node runs an apiserver pod. They are not currently load balanced/tied to a floating IP, so clobbering the first master in the list will cause communication issues with the other pieces.

Note: That the separate haproxy/keepalived will address the limitation that @adamschaub describes:
Each master node runs an apiserver pod. They are not currently load balanced/tied to a floating IP, so clobbering the first master in the list will cause communication issues with the other pieces.

@danehans Updated taking most of your advice. I've kept apiserver_endpoint defined in group_vars for now, cleanest solution I've found to maintaining the right apiserver address for kubelets/kube-proxies/etc.
Note: I've had issues getting HA to work correctly for centos7 atm (some SSL issues as far as I can tell, triaging rn). Should work fine on CoreOS as is. I'll update soon with a fix.

Hey guys which is the state of this PR?!
Is there something still to be done to let this get finally merged?

@atosatto yes sorry for the delay, travel has slowed me down. I need to revisit SSL certs and other auth because of the occasional, but fatal, authentication issue. Then it should be relatively stable, although I will come back and make improvements.

Thank you very much for your brief update. I definitively would like to
contribute to this. I'll start looking at your changes. Hopefully I'll be
able to reproduce the SSL problem you were mentioning and maybe help you
fixing it.
--
Andrea Tosatto
On May 8, 2016 4:03 PM, "Adam Schaub"<EMAIL_ADDRESS>wrote:

@atosatto https://github.com/atosatto yes sorry for the delay, travel
has slowed me down. I need to revisit SSL certs and other auth because of
the occasional, but fatal, authentication issue. Then it should be
relatively stable, although I will come back and make improvements.
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/kubernetes/contrib/pull/761#issuecomment-217721639

@atosatto Great! Keep in mind I've started with CoreOS first, so centos/Ubuntu and the like are likely to have more issues. I'm pretty new to kunernetes, so your critiques and additions are very welcome!

@danehans Incorporated most of the points you made, kept kube_apiserver_endpoint for now because it was the most straightforward method I tried. Works on my vagrant environment for both CoreOS and CentOS 7.
Note that a single machine can't be both a master and a node with this implementation. Once this is reviewed and the general process is vetted, I'll start addressing #838, which will allow me to split up the node dependencies and enable master/node to be colocated.
When testing, keep in mind that there is a dependency on #843 for load balancing services.

@danehans @atosatto, have you had a chance to review? Lmk if you are good to move forward with this.

I will this night! :) I'll keep you posted. Thanks
--
Andrea Tosatto
On May 12, 2016 16:41, "Adam Schaub"<EMAIL_ADDRESS>wrote:

@danehans https://github.com/danehans @atosatto
https://github.com/atosatto, have you had a chance to review? Lmk if
you are good to move forward with this.
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/kubernetes/contrib/pull/761#issuecomment-218778615

@ingvagabund we are working with @eparis to get CI setup. I'm hoping this will be complete in the next week. In the meantime, could you run this PR through your CI? It's pretty big and an important PR to merge, so I want to avoid breakage.

@danehans  will give it a spin

@adamschaub aside from my inline comments, I'm willing to give a +1 if you create a separate GH Issue or WIP PR that breaks out kubelet into a separate role and you explain/document the limitation(s) of HA in this PR.

@ingvagabund thanks. You can see some of the PR feedback I provided to @adamschaub. If you haven't run the PR through CI yet, then hold off until the feedback is addressed. I think this PR is really close to complete. It will be great to get HA added to the project :-)

@danehans just for record, this PR passed in my CI :)

@ingvagabund sweet! We may need your help one more time with this after the final changes are implemented.

@ingvagabund Thanks for the testing! @danehans Implemented your suggested changes.
Note that without the kube_apiserver_endpoint abstraction, there will be errors if #843 isn't incorporated to manage the kube_apiserver_vip.

#923 will make this much easier to test on a local vagrant env

ready to be tested again? :)

@adamschaub a few nits. otherwise this is so close. @ingvagabund let's hold off a bit longer.

@danehans Addressed your nits, and documented the HA limitation in inventory.example.ha: https://github.com/kubernetes/contrib/pull/761/files#diff-0efb63ed59ed18740155cf21b563930fR1

@ingvagabund I rolled back renaming kube_master_api_port. @danehans Updated the documentation and VIP example in group_vars. Either of you cats have anything else for me? Final pass through CI?

@adamschaub on it

RH ansible test passed for commit kubernetes@54af1c5
Build time: 0:28:04

Let me try the CI here too :)

@rh-kube-bot contrib this

test this please

@rh-kube-bot test this please

Ok, ignore all the spams from rh-kube-bot, need to do more testing.

@rh-kube-bot test this please

@rh-kube-bot contrib this

@adamschaub since the PR is no longer WIP, can you please remove WIP from the PR title.

@adamschaub can you update master > etcd dependency:
$ git diff -w roles/master/meta/main.yml
diff --git a/ansible/roles/master/meta/main.yml b/ansible/roles/master/meta/main.yml
index ca127c8..272c38d 100644
--- a/ansible/roles/master/meta/main.yml
+++ b/ansible/roles/master/meta/main.yml
@@ -2,3 +2,4 @@
 dependencies:
     - { role: common }
     - { role: kubernetes }
+    - { role: etcd }

Sorry guys for being my victim again :)

@redhat-k8s-bot test this

@redhat-k8s-bot test please

@ingvagabund all looks good with our testing of this patch. @atosatto since you're interested in this work, have you tested it?

I'll give it a spin this evening and let you know if it works to me.
I've already tested it few days ago and everything was working fine to me.
Can someone share the way he is testing the PR? How many masters are you
using? And minions? Which OS? Which virtualization provider? Have you
performed some additional operations in order to check if kubernetes is
running properly?
I'm asking all these questions because I want to find out which is the
current test case in order to provide much more consistent feedbacks.
--
Andrea Tosatto
On May 27, 2016 20:52, "Daneyon Hansen"<EMAIL_ADDRESS>wrote:

@ingvagabund https://github.com/ingvagabund all looks good with our
testing of this patch. @atosatto https://github.com/atosatto since
you're interested in this work, have you tested it?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes/contrib/pull/761#issuecomment-222225831,
or mute the thread
https://github.com/notifications/unsubscribe/AA1LhjSE4DyL3y0EUaHSOBHjL8j9XXKDks5qFz1hgaJpZM4IFGJ0
.

@atosatto I've been testing using vagrant+virtualbox provider. I either modify the Vagrantfile directly to include at least 2 masters, 3 etcds, and 1 node. Once the install is complete, I hop onto a master node, verify that the master service pods are running docker ps (should have a kube-apiserver on each master, scheduler/controller-manager should each be running on exactly one master). Use etcdctl get [/scheduler or /controller] to see what master each is assigned to. Then I take any generic rc manifest and create it using kubectl. Once it is successfully assigned to a node and running, all should be ship shape.

@atosatto, any updates?

@adamschaub sorry Adam for my very late response but I had no time to check this until yesterday.  I've been able to make things working with your setup but I had issues with a greater number of master nodes. I will try to dig into this. Maybe we can ping each other on Hipchat in order to let you drill down the issue.

Hey @adamschaub, do you have any update on this PR?  After pulling down this PR, and incorporating the changes from #711, I am still getting the error below.  This is a CoreOS cluster in AWS with 5 hosts (2 Masters).
fatal: [<IP_ADDRESS>]: FAILED! => {"changed": false, "failed": true, "invocation": {"module_args": {"dest": "/etc/kubernetes/manifests/kube-api-hyperkube.yml", "src": "kube-api-hyperkube.yml.j2"}, "module_name": "template"}, "msg": "AnsibleUndefinedVariable: ERROR! 'dict object' has no attribute 'etcd_interface'"}
I'll dig into this more and submit a PR if I locate the issue.

@smugcloud Thanks. Haven't touched this in a while... etcd_interface is being set in etcd role. I think there might be a requirement that all nodes in the master group also be in the etcd group. Try adding them to etcd. If that's the case, I definitely need to document that.

recomputing cla status...

[APPROVALNOTIFIER] The Following OWNERS Files Need Approval:

ansible

We suggest the following people:
cc @lavalamp
You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancelin a comment


sparse: 0.5.0 -> 0.6.3 and fixes

Added sqlite and gtk+3 that are now wanted by sparse.
Sparse expects to find system includes at /usr/include redirect this
to glibc.dev.
Sparse uses gcc -print-file-name= extensively to find gcc includes, due
to split in nixos this direct to gcc-lib, which does not include the headers
so redirect to GCC_BASE as defined in derivation. There might be a better way
to do this, but I did not immediately find one.
Define PREFIX as Make parameter, as old sed expression was broken.
Slightly irrelevant ref.
https://bugzilla.redhat.com/show_bug.cgi?id=1114755

Motivation for this change
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 134638 at ae7645de run on x86_64-linux 1

1 package built successfully:

sparse

1 suggestion:

warning: build-tools-in-build-inputs
llvm is a build tool so it likely goes to nativeBuildInputs, not buildInputs.
Near pkgs/development/tools/analysis/sparse/default.nix:21:3:
   |
21 |   buildInputs = [ gtk3 libxml2 llvm perl sqlite ];
   |   ^

@cole-h ofborg internal error on this and some other PRs
is there a page where the error can be seen?

Feel free to kick off a fresh evaluation whenever you see the label (just please don't remove it). The logs are not publicly visible because it may leak secrets. These days, the label basically means "GitHub responded with an incomplete API response which caused ofborg to choke".
@ofborg eval


Roles and Permission to edit Naming Policies

To edit the Naming Policies, the article says that a User Administrator role is required. Only the Groups Administrator and Global Administrator can edit the Naming Policies. The User Administrator can't upload a CSV file, the button to select the file is not enabled.
https://docs.microsoft.com/pt-br/azure/active-directory/users-groups-roles/groups-naming-policy

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e3fb85a8-d842-f101-909e-86751922da43
Version Independent ID: 0c99b5ef-753e-1085-a682-c55ea4059207
Content: Enforce group naming policy in Azure Active Directory
Content Source: articles/active-directory/users-groups-roles/groups-naming-policy.md
Service: active-directory
Sub-service: users-groups-roles
GitHub Login: @curtand
Microsoft Alias: curtand

@thahma
Thanks for your feedback! We will investigate and update as appropriate.

@thahma
I have created a PR to update the documentation and will now close out this issue. Please allow some time for the changes to reflect and if you don't see the document update, please let me know.
I will be more than happy to re-open this issue and look into what happened.
Thank you for your time and patience!


Media: Avoid taking an existing element's base color

Context

Summary
While working on another ticket, I noticed that sometimes, the base color was repeated the same color. This was becuase it was reusing the existing element on the page. By passing a unique id, it creates a new element and fixes the issue.
Relevant Technical Choices

To-do

User-facing changes

Testing Instructions

[x] This is a non-user-facing change and requires no QA

This PR can be tested by following these steps:

Reviews
Does this PR have a security-related impact?

Does this PR change what data or activity we track or use?

Does this PR have a legal-related impact?

Checklist

[ ] This PR addresses an existing issue and I have linked this PR to it in ZenHub
[ ] I have tested this code to the best of my abilities
[ ] I have verified accessibility to the best of my abilities (docs)
[ ] I have verified i18n and l10n (translation, right-to-left layout) to the best of my abilities
[ ] This code is covered by automated tests (unit, integration, and/or e2e) to verify it works as intended (docs)
[ ] I have added documentation where necessary
[ ] I have added a matching Type: XYZ label to the PR

Fixes #

This makes me wonder: Why are the img elements added to the DOM in the first place? Seems necessary. Avoiding that would fix this too.

This makes me wonder: Why are the img elements added to the DOM in the first place? Seems necessary. Avoiding that would fix this too.

@miina I wonder this as well. Can you explain why this is needed?

@miina I wonder this as well. Can you explain why this is needed?

Perhaps the base color was previously created based on some URLs of images when they weren't anywhere yet?
I don't remember why it was added like this, by all means, feel free to change it! The baseColor logic has been completely reworked meanwhile, we should def opt for the most suitable approach.

I‘d recommend opening an accompanying ticket if this requires more work.

I now just create a unquie id for every base color generation. I will create a ticket for refactoring the logic. It is a little hard to understand as it. Not sure I understand why we create a div, we can just pass in a node.

If we're gonna fix it, let's fix it properly in the new year

It is a little hard to understand as it. Not sure I understand why we create a div, we can just pass in a node.

@spacedmonkey the div was previously created because we added the node to the DOM -- it was a wrapper that visually hid the added image from the screen, and always the same wrapper was used to just add it once (not a separate one per every element). If we can just pass the image node, there's no reason at all for creating that div.

I had a quick look into this and this code needs refactoring now. It is very confusing to follow. I have created issue for this. https://github.com/google/web-stories-wp/issues/10025
For now, I am going back to simple fix, which means passing an id, which fixes the duplicate color issues, I was seeing. Longer term, I really want to refactor this code.

I'd like to properly fix and refactor this in the current/upcoming sprint.

Created issue https://github.com/google/web-stories-wp/issues/10099 and closing as larger refactor is needed.


[BUG] 500 internal server Error

Describe the bug
I can't login to the toolbox I'm getting a 500 with the message "No Response From IDN"
I went through the developper tools and the first access calls go to 302 or 303 but the callback returns a 500.
I've also tried using a private navigation in localhost:3000. It does ask me for authentication, which then works if I open another tab from this navigation to my IDN tenant.
Screenshots

Operating System (please complete the following information):

OS: Windows 10 19045.4170

I'm available for more test if needed.

I am also having the same issue with Macbook Pro M1 14.6.1


sys.dm_exec_requests.status incomplete enumeration

https://github.com/MicrosoftDocs/sql-docs/blob/live/docs/relational-databases/system-dynamic-management-views/sys-dm-exec-requests-transact-sql.md doesn't mention that the status column can also have a value of 'rollback'.

@clement911 Thanks for your feedback. Once I've confirmed this with a PM, we'll get the article refreshed and updated.

Thanks.
By the way, I believe the statuses should also all be lowercasw


[SILGen] Disable emitAssignLValueToLValue peephole when enforcing exc…

…lusivity
The peephole causes the the formal access to the source and destination to
overlap. This results in unwanted exclusive access conflicts when assigning
from one struct stored property to another.
At John's suggestion I've added an isObviouslyNonConflicting() helper
method on LValue that tells when when it is safe to use the peephole
even when exclusivity enforcement enabled. For now, the helper is toothless. It
can be extended to claw back some of the peephole opportunities.

@swift-ci Please smoke test and merge


ScottPlot 5 Legend: Fixes symbols, reduces remeasuring

Purpose:

Fixes an issue where children of a legend item could be duplicated
Fixes an issue where legend symbols did not respect padding
Eliminates remeasuring of child legend items
Fixes indentation of child legend items

Outstanding issues:

You cannot customize what items go in a legend (this might be out of scope for this issue)

Before:

After:

Thank you so much for this @bclehmann! This is a great improvement.
I plan to rework many style classes (Fill, Stroke, Font, Marker, etc.) but until that work is done I'd like to prevent other code from using them. For this reason I'll revert your Stroke back into distinct LineWidth and LineColor, but definitely soon in the future when the time is better I will refactor the whole code base to use more intelligent style objects.
I'll make that change and merge within the next several minutes

You cannot customize what items go in a legend (this might be out of scope for this issue)

I'll create a new ManualLegend object this morning and add a cookbook recipe for it


Example Overlay for Feature Film Deliverables

Sam Pluemacher writes:

Here’s a screenshots with my ideal settings  Of course every vendor wants them in slightly different positions on-screen, so if one can re-arrange the displayed fields that would really great. The text in red ist just explanatory. In the second screenshot I’ve highlighted the Resolve Data Burn In options that I’d like to use in Metaburner.

I believe all these fields are currently available in the latest beta, so closing for now.


Change points and user summary for TVSum dataset

Hey Stev,
I am trying to understand you implementation to generate the dataset. In fact, for the TVSum, I compared the change points you made public with the ones from  KaiyangZhou's work. It seems like they are very different despite you are using the same features. I could be some differences in the parameters of the KTS algorithm, but I would like to have your insights.
Second, to generate the user summary for the TVSum dataset, you are thresholding the ground truth scores. However, I think we should apply the knapsack algo on the GT scores to get the shots that belong to the summary.
Thanks for answering my concerns.

Hey Terbouche, sorry for the late reply. I missed this. But I hope I can help you. Regarding your first question, I think it also depends on the Python version. In fact, I couldn't replicate the results and I saw in several projects that they just used it and assumed it was correctly constructed.
Second, yeah you are right. I made a simplified version but to be fair what you mentioned should be applied for TVSum dataset


Fix repo file upload timeout

Fixes the issue where working does not update when Dropzone is uploading. See commit messages for details on the fix.

 [general-229] Guanxi Chen needs an ability to upload 28G + (Opened)

 Fix session timeout when uploading large files


Patches Manager

Is your feature request related to a problem? Please describe.
I'm always frustrated when I want to apply patches to games in the Xenia Emulator. Currently, there's no straightforward way to manage these patches within the Xenia Manager. I have to manually find, apply, and update patches, which can be time-consuming and prone to errors.
Describe the solution you'd like
I would like to see a Patches Manager integrated into Xenia Manager. This feature would allow users to browse, apply, and manage patches directly within the application. Key functionalities would include:

A repository of available patches that can be accessed and downloaded directly.
A user-friendly interface to apply, enable/disable, and remove patches.
Automatic updates for patches to ensure users have the latest versions.
Compatibility checks to prevent the application of incompatible patches.

Describe alternatives you've considered
Currently, the only alternative is to manually download patches from various sources and apply them by editing configuration files or replacing files in the game directory. While this works, it’s not ideal and can be difficult for less experienced users. Another alternative could be using external tools, but integrating this directly into Xenia Manager would provide a more seamless experience.
Additional context
Adding this feature would significantly improve the user experience, making it easier to enhance games with community-created patches. It could also help in reducing game issues caused by incorrect patch application. Screenshots or mockups of how this could look within the Xenia Manager UI would be beneficial to further illustrate the idea.   !AI Request!

Not sure if I understand this correctly. You can install patches with Xenia Manager, as noted in the FAQ page.

Closing this issue as I see something requested that's already in Xenia Manager


serializers: fix handling deserialization of many=True fields

This fixes #48.
The way we need to handle this is terrible. This will be much easier in 1.0.0 where we redesign resource validation.

Coverage remained the same at 100.0% when pulling 1ff658e188518d178c0fd584f68598ce998c71bf on fix/issue-48-fix-many-fields-deserialization into 957a1c3164b91c64f4b0e64e1901536aeb2aeecd on master.


As a gardener operator, I want to statically assign initial resources (CPU, memory) to Shoot kube-apiservers instead of doing it depending on maximum Node count, such that clusters with little usage aren't wasting that many resources anymore.

How to categorize this issue?

/area auto-scaling
/area control-plane
/kind enhancement
Disclaimer: The following descriptions assume you have HVPA enabled. For Seeds where HVPA is disabled, the behavior is different!
Problem background
The current scaling mechanism for Shoot kube-apiservers works in three steps

the kube-apiservers get an initial amount of resources, depending on the ScalingClass associated with the Shoot.  See the next section for more details about how this is done and some context why this a was built in the first place.
HVPA uses HPA's scaling recommendation to scale horizontally until maxReplicas is hit and
only afterwards uses VPAs scaling recommendation to adjust the kube-apiserver resources

This works reasonably well for clusters, which see a high amount of use and scale to maxReplicas and afterwards get more or fewer resources assignes for each replica, but falls short when clusters see little usage and their kube-apiserver are never scaled to more replicas. In this scenario, we end up with kube-apiservers which have requests much higher than they actually need, but VPA recommendations are never applied by HVPA.
Proposed Solution
We propose to remove the dynamic configuration of initial kube-apiserver resources as it shouldn't be necessary anymore for control-plane stability and replace it with a static set of initial resources. To make the switch from the current implementation towards a statically defined set of resources controllable by operators, we propose that the static resource configuration is not a part of the Gardener code, but a new property on the Seed resource.
Current implementation details and historical context
The current implementation sums up the maximum possible Node count over all worker pools and assigns one of four ScalingClasses based on this. The ScalingClass determines the initial resource requests for the Shoot's kube-apiserver.
This implementation was introduced at a time of "v1 Vertical Pod Autoscaler", which didn't live up to its promise and lacked a lot of the functionality that we now have – that's why it was later re-implemented as "v2 VPA", which is what we're using now. See the original auto-scaling story and the PR introducing ScalingClass for more context. We needed a working solution at that time and couldn't wait for "v2 VPA" to be available, because of concrete issues during operations of clusters under higher load.
Implementation details for proposed static assignment of initial resources

Add a new property shootApiserverInitialResources to .spec.settings on a Seed of type ResourceList
Example content

spec:
  settings:
    shootApiserverInitialResources:
      cpu: 500m
      memory: 1G

The current ScalingClass implementation remains intact and get an additional case for Seeds which have the above property shootApiserverInitialResources set
The additional case doesn't consider Node count, but just returns the configured shootApiserverInitialResources

Relation to GEP-22 and removing HVPA from Shoot kube-apiserver scaling
After GEP-22 has been implemented and HVPA is no longer used to scale Shoot kube-apiservers, we can remove the ScalingClass implementation, as we get vertical Pod autoscaling right from the start of a kube-apiserver Pod. The VPA will adjust the resources to the necessary level automatically and we don't have to wait for horizontal scaling to max out. However, GEP-22 as a proposal hasn't been merged yet, therefore the implementation and rollout is still several months from now. With this proposal we want to enable a quick way to reduce the resource waste caused by clusters with little usage and high maximum Node count.
The static assignment of initial resources proposed here will be useful even after GEP-22 has been implemented, such that operators can have different start values for their Shoot control planes e.g. based on if this is a development or testing landscape or a production landscape.
Risks

Operators could configure the set of initial resources so low that kube-apiservers fail right after starting the Pod without giving VPA the necessary time and amount of usage samples to make reasonable recommendations. This could lead to control-plane downtimes or perceived longer times until a control-plane is ready after starting a cluster.
Operators could configure the set of initial resource way too high, resulting in even more resource waste than choosing the initial resources based on the maximum Node count

Given that all this scaling-class annotation is marked as 'alpha', we could also remove it immediately w/o further notice. Would this be an option as well? If not, then we should probably find another way to allow operators configuring the initial resources. I don't think it's reasonable to add a new field to the core API which basically is deprecated already before initial introduction.

I don't think it's reasonable to add a new field to the core API which basically is deprecated already before initial introduction.

Can you elaborate a bit on this? I'm not sure I understood what you mean. I assume you're saying that the new field added to the Seed would need to be removed once we remove the ScalingClass from Gardener code?
Above, I tried to argue that what we're proposing to add will still remain useful, even after ScalingClass and HVPA are completely removed:

The static assignment of initial resources proposed here will be useful even after GEP-22 has been implemented, such that operators can have different start values for their Shoot control planes e.g. based on if this is a development or testing landscape or a production landscape.

Does this make sense?

The static assignment of initial resources proposed here will be useful even after GEP-22 has been implemented, such that operators can have different start values for their Shoot control planes e.g. based on if this is a development or testing landscape or a production landscape.

Does this make sense?

TBH, I don't think so. We should try to avoid treating the API server pods specially. Otherwise, why wouldn't we expose similar "initial resource" configurations for other control plane components (e.g., etcd or controllers)?
If this is really needed, perhaps it's a better approach to let operators use third-party tools like Kyverno/OPA if they really want to have such behaviour for testing/development landscapes.

Operators could configure the set of initial resources so low that kube-apiservers fail right after starting the Pod without giving VPA the necessary time and amount of usage samples to make reasonable recommendations. This could lead to control-plane downtimes or perceived longer times until a control-plane is ready after starting a cluster.

Finding the correct value might need some fiddling with the values, and may even be different on DEV and PROD landscapes, so I think we should avoid a solution that requires code changes to adjust the resources or fixes all landscapes on the same set of resources.

How are such values specific to the landscape purpose like DEV or PROD? How are they specific to all control planes on a seed cluster at all? In my understanding, they are at most specific for dedicated shoots, so I cannot see how a seed-global configuration can be the appropriate way of addressing this problem. Perhaps it's more reasonable to address these downsides in VPA directly?

How are such values specific to the landscape purpose like DEV or PROD?

My thinking was that on DEV you might be fine defining any start values much more aggressively than on a production system. I do understand your point that we're not doing this for any other components in Gardener, and it is reasonable to not start doing this for a single component.

How are they specific to all control planes on a seed cluster at all?

They are not. The only reason why we proposed making this a property on a Seed is to allow for controlled rollout. That's what was meant above with

To make the switch from the current implementation towards a statically defined set of resources controllable by operators, we propose that the static resource configuration is not a part of the Gardener code, but a new property on the Seed resource.

Alternatively, we could also have static values in the code and make this a feature gate on gardenlet?

Perhaps it's more reasonable to address these downsides in VPA directly?

I'm not sure which downsides you're suggesting to address in VPA, could you elaborate on this a bit? My idea with this issue was to get to the point where we can remove code and a band-aid implementation from Gardener code, not make any real changes to autoscaling behavior.

IIUC, your goal is to drop the initial static resources assignment from the code entirely because "it shouldn't be necessary anymore". In this light, adding a new field to the API that is deprecated before it is even introduced is rather confusing. If you want to make the rollout controllable, then you can indeed just use a feature gate that disables the static resource assignment behaviour, and that eventually gets promoted to GA and removed again. Feature gates are easier to graduate and remove than changing the user-facing APIs.

I'm not sure which downsides you're suggesting to address in VPA, could you elaborate on this a bit?

I wrote this because you said "we should probably find another way to allow operators configuring the initial resources" - this contradicts with the initial goal description of this issue (removing initial static resources assignments entirely). My point was that we should rather improve the autoscaling in case we are not happy with the scale-up behaviour when new clusters right away get a lot of load (which was the motivation to introduce the static assignments in the beginning).
TL;DR: If you just want to make the removal of the code controllable, let's use a feature gate that we actively promote and drop again within a few release cycles. If you want to allow operators to configure initial resources assignments, let's make them rely on external tools like Kyverno/OPA instead of only exposing this possibility for API servers.

OK, if

We still want to define some value for resource requests and not leave this empty.

does not mean that a human operator still needs to define this somehow via Gardener means (not via third-party tools), then I'm fine. From Gardener PoV, I think we should treat KAPI similar to other components.

Edited the original post above:

moved the original proposal of adding a Seed property into "Alternatives"
changed the proposed implementation to a feature gate

WDYT?

Thanks, sounds much better now! Except for the "Rollout/Feature gate removal" section:

the open source repository should not contain any specifics to any special landscape (what is "our own landscape" in the open source context?)
the feature gate promotion should happen as usual, independent of how landscape operators decide to use or not use it: (1) introduced as alpha, disabled by default. (2) promoted to beta, enabled by default. (3) promoted to GA, locked to default (enabled). (4) removed from the code base. Hence, four release cycles will be needed to cover the full lifecycle.


Update ExistingData mechanism

The ExistingData class in the test folder is used to setup some initial data the integration test rely on.
This has a manual step that is tedious: Think about a better method for this.
One option is to create a file to store the ids of the created objects: this should speed up successive tests run on the same environment. This feature should be opt-in for the developer:
by default everything should run out of the box without requiring any manual changes

Solved in https://github.com/3AP-AG/harvest-client/pull/10


Make app the main command and application as alias

Now when hitting odo command app will be show as command
application is made alias so that users can use both
#296

@piyush1594 can you please modify all e2e tests to use odo app instead of  odo application the same for docs, if it is mentioned anywhere

@kadel Yaa sure, will do that and soon push. Thanks

Tried / Tested, Worked for me, LGTM


Subscriptions are not supported yet with t.prismaFields

TODO

Waiting for https://github.com/prisma/nexus/issues/21 to land
Resolve subscription types
Generate proper typings for subscription types

Hey !
PR are always appreciated, feel free to dig into the codebase and create a PR if you feel like so !
As far as I can tell, there are two things to change:

The generated resolvers needs to support subscriptions (atm, it just throws)
And generate the correct types in nexus-prisma-generate

Update: This needs to be rolled out first https://github.com/prisma/nexus/issues/21

@Weakky prisma/nexus#21 is now closed!
More details on PR: https://github.com/prisma/nexus/pull/66
I'm very anxious about subscriptions with nexus-prisma.
I'll try to dig out in the code this weekend to propose a PR. Thanks for the good work!

@nevescode That's amazing! If you need any help, feel free to DM me on the Prisma slack @weakky 🙏

Hi any news about this? 😢

Hey everyone,
While we haven't implemented subscriptions yet, it's important to mention that subscriptions should already work nonetheless with nexus if you implement the resolvers yourself with subscriptionField().
What doesn't work yet are the automatic resolvers when using t.prismaFields([])

hey, may I ask if you/somebody knows when to expect with this feature?

+1

Awesome. Hope as soon as possible.
Have a good day.

So topic is dead? :(

Should be fixed with this v0.3.7.

Apologies if I am missing something but isn’t that rather a workaround?
I think subscription via t.prismaFields() syntax is what we are all after.


unexpected keyword argument 'use_ssl' for ELASTICSEARCH_AWS_HOSTED

PGSync version: 3.1.0
Postgres version: 16
Elasticsearch/OpenSearch version: 7.17.13
Redis version: 7.2.5
Python version: 3.11
(elasticsearch==8.14.0)
Problem Description:
Looks like the latest versions of python elasticsearch client lib rejects the parameter 'use_ssl'. As i see it was commented out in code for 'else' client but not for AWS-hosted https://github.com/toluaina/pgsync/blob/main/pgsync/search_client.py#L401
Error Message (if any):
TypeError: Elasticsearch.init() got an unexpected keyword argument 'use_ssl'

Thanks for that. sorry for the dealy. All fixed

Any update on this, it looks like this fix was not included in the 3.2.0 release

this is now included in 3.2.1 release here


[bug] X-External-Path header ignored in some cases.

Version
Checklist:

[x] I am not using Home Assistant. Or: a developer has told me to come here.
[x] I have checked the troubleshooting section and my problem is not described there.
[x] I have read the changelog and my problem is not mentioned there.

Build/Run method

[ ] Docker
[ ] PKG
[ ] Snap package
[x] Manually built (git clone - yarn install - yarn run build )

Zwavejs2Mqtt version: 5.7.x (both .0 & .1)
Z-Wave JS version: Whatever was shipped with the above
Describe the bug

A clear and concise description of what the bug is.

Some assets don't load when using the X-External-Path, as the header seems to be ignored.

To Reproduce
Steps to reproduce the behavior:
Set up a reverse proxy putting Z-Wave2MQTT in a subfolder, ensure X-External-Path is sent.
See browser debug console it doesn't load the woff2 files, as the subpath passed is ignored.
Expected behavior
To work
Additional context
Introduced in 5.7.0

@frenck Could you show me if you have warnings or errors in console log?

No, no warnings in the console. Only a 404 on the path, as the external path header was ignored when retrieving the woff2 files

Quite sure it's something related to https://github.com/zwave-js/zwavejs2mqtt/commit/c2bd96784ab34a48757f1cd1a02c805e10b812cc.
If I open a PR could you test it? @frenck

If I open a PR could you test it? @frenck

Yes

@frenck PR ready

Installing...

Some changes visible, but no sigar

The filenames have changed, there is a notable double dot (.) before the filename extension. However, as you can see on the right side, the request URL is missing the forwarded path.
For comparison a JS file:

Sincerly I have no clue why that happens, I will do another try, if still not working I will revert the css-loader to previous version

Try last commit please

@robertsLando I'm still recovering from surgery, so not full-time online. At this point, I'm working towards the Home Assistant beta, which has a higher priority. I'll get back to this asap.

I'm sorry, hope you are well. Don't worry take your time

The last commits make no difference in terms of visible results and in results in the browser debugger.

Cannot detect why this is happening BTW I know that the only thing I touched is webpack build to update css-loader here c2bd96784ab34a48757f1cd1a02c805e10b812cc so I have reverted that commit. Try now please

Yep... works


代码的问题

这里是不是有点问题呀

而且，这个代码是不是没有写完？看着好多地方都不完整

It should be a = unjson(p_a). p_a and p_g are the path of origin annotation and changed annotation, respectively.

thanks！

It should be a = unjson(p_a). p_a and p_g are the path of origin annotation and changed annotation, respectively.

thanks

It should be a = unjson(p_a). p_a and p_g are the path of origin annotation and changed annotation, respectively.

I don't think your code works, There are many mistakes. ce has not been defined yet

I'm sorry for these errors. I have modified these errors and check loss files and files to generate noisy annotation now.

I'm sorry for these errors. I have modified these errors and check loss files and files to generate noisy annotation now.

Thank you for your reply, I have seen the corrected code. That is great! I will study it seriously. Thanks again.

I'm sorry for these errors. I have modified these errors and check loss files and files to generate noisy annotation now.

Hello, I'm sorry to need your help all the time. What I want to ask is which file is the loss function.I sent you an email, but I didn't get a reply, so I came to GitHub to ask again. thanks very much!


Request Specs Converting Non String Values to Strings

as a request spec both of these fails because they get converted into strings.
require 'spec_helper'

describe 'parameters' do
  before { post 'orders.json', order: {boolean: true, integer: 123} }
  it 'should have boolean value' do
    request.params['order']['boolean'].should == true
  end
  it 'should have integer value' do
    request.params['order']['integer'].should == 123
  end
end

as a controller spec boolean passes, integer fails.
require 'spec_helper'

describe OrdersController do
  before { post :create, order: {boolean: true, integer: 123} }
  it 'should have boolean value' do
    controller.params['order']['boolean'].should == true
  end
  it 'should have integer value' do
    controller.params['order']['integer'].should == 123
  end
end

This is with Rails 3.2.8 and RSpec 2.11.0

If anyone's struggling with this, as of rails 4.2, you can get it to work with:
    post :create, {order: {boolean: true, integer: 123}, :format => :json}

Shoutout to these folks

In Rails5, I seem to be having this problem again.

In Rails5, I seem to be having this problem again. Even with format: :json, all integers get turned into strings, which does not match how Rails is actually delivering them to me in production (from a json-format post'd body).
Is there a regression in rails5?

@jrochkind try as: :json

Yep, that's what worked. Sorry I forgot to come back and update, I was knee deep in yak shaving.
Not sure where one would have figured that out from any documentation, but hey now it's here for those who end up here by googling, thanks @bkudria!

In rails 4.2.9, Rspec 3.6, I had to do post :create, params.merge(format: :json) to make it work. This was very annoying!!

Still have this issue when writing a request spec for API with POST to url and not an action.
params = { count: 1 }
post "/posts.json?#{params.to_query}"

count is a string when running the test and in real application its an integer.

All params are strings always. Thats the HTML standard. You can apply further parsing, and Rails will parse request bodies as JSON, I'm unsure wether it should parse your example as JSON, but it's a Rails issue.


[Remove Snap] Aptos Wallet

Description
Note: Removing a Snap from the registry means that users who have installed the Snap may continue to use it. New users will not be able to install the Snap.
Checklist
All items in the list below needs to be satisfied.

[ ] Is the reason for the removal documented in this issue?
[ ] Are the key parts of the communication with the developer to remediate the concerns documented in this issue?
[ ] The corresponding pull request in this repo has been merged.

The Aptos Wallet Snap @rise-wallet/aptos-snap is not being maintained and does not have any dapp UI for users to manage their Aptos accounts. The developer has agreed to have it removed.


Update tenant-apps-catalog-teams.md

https://github.com/MicrosoftDocs/OfficeDocs-SkypeForBusiness/issues/1709
Added instructions for - Use the Office 365 admin portal to manage the Tenant Apps Catalog

@lolaj Hi Lola, can you please check and merge? Thanks!


Check for Windows 10 SDK reports it is missing when there is only 1 SDK installed.

Overview
Warning about wrong SDK version with correct version installed
Expected Behavior
No Warning
Actual Behavior
Warning in console:
Unable to find the required Windows 10 SDK Target!
Please be sure to install the 10.0.16299.0 SDK from Visual Studio Installer.
Steps to reproduce
Use the Mixed Reality build dialog and check the console.
Unity Editor Version
2017.4.0f1
Mixed Reality Toolkit Release Version
latest release

            for (var i = 0; i < windowsSdkPaths.Length; i++)
            {
                if (string.IsNullOrEmpty(currentSDKVersion))
                {
                    currentSDKVersionIndex = windowsSdkPaths.Length - 1;
                }
                else
                {
                    if (windowsSdkPaths[i].Equals(SdkVersion))
                    {
                        currentSDKVersionIndex = i;
                    }
                }
            }

            if (currentSDKVersionIndex == 0)
            {
                Debug.LogErrorFormat("Unable to find the required Windows 10 SDK Target!\nPlease be sure to install the {0} SDK from Visual Studio Installer.", SdkVersion);
            }

New to reporting on issues, so please excuse if I made an error.
In my case, I have ONLY 10.0.16299.0 installed.  The code above checks if index == 0, and reports a warning that it's not there.  The problem is, index 0 is the first entry in the string array, which equals 10.0.16299.0.  Suggested fix is to initialize currentSDKVersionIndex to = -1, and check if == -1, instead of 0.
Thanks!
-Blayne Watt

@StephenHodgson, Patch4 (2<IP_ADDRESS>) should be going out mid April. I am targeting the week of 4/16

Adding this to the April (aka Patch4) release. I'll port @StephenHodgson's fix.

Looks like the fix may already be in Patch4.... I do not see the explicit check for index==0. Testing now.

I downloaded the pre-built release unity package...
HoloToolkit-Unity-2<IP_ADDRESS>.unitypackage
-B


Doc: Api

Current coverage is 77.41% (diff: 100%)

Merging #943 into master will increase coverage by 0.06%

@@             master       #943   diff @@
==========================================
  Files           131        131
  Lines          7004       7006     +2
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits           5418       5424     +6
+ Misses         1586       1582     -4
  Partials          0          0

Powered by Codecov. Last update 945ffce...5e0b5de


Missing git tag for 0.3.1 release

It would be nice to keep PyPI releases and git tags in sync :)

Done! Thanks for the reminder :)


Index values need to be strings (or binaries) when using RegExp matching

Probably "obvious", but when I used integers as indexes to make it simple to say in which range the indexfold should be, everything worked fine until using RegExp matching:
leveled_eqc:init_backend(o_rkv, [{root_path, Dir}, {cache_size, 7}]) -> <0.3321.0>
leveled_eqc:indexfold(<0.3321.0>, <<98, 117, 99, 107, 101, 116, 51>>,
    {#Fun<leveled_eqc.22.101590978>, []}, {dep, 0, 2},
    {false, <<15>>}, 7) ->
  #Fun<leveled_runner.4.26787583>
leveled_eqc:put(<0.3321.0>, <<98, 117, 99, 107, 101, 116, 51>>,
    <<0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0>>,
    <<53, 1, 0, 0, 0, 77, 131, 108, 0, 0, 0, 6, 104, 2, 100, 0, 4,
      100, 97, 118, 101, 97, 1, 104, 2, 100, 0, 5, 101, 108, 116, 111,
      110, 97, 2, 104, 2, 100, 0, 5, 99, 108, 97, 114, 97, 97, 3, 104,
      2, 100, 0, 4, 100, 97, 118, 101, 97, 4, 104, 2, 100, 0, 5, 105,
      115, 97, 97, 99, 97, 5, 104, 2, 100, 0, 5, 104, 97, 114, 114,
      121, 97, 6, 106, 0, 0, 0, 1, 0, 0, 0, 33, 1, 1, 44, 80, 107, 181,
      113, 86, 30, 141, 176, 51, 8, 2, 208, 218, 45, 67, 128, 2, 32,
      16, 155, 93, 14, 128, 36, 86, 193, 190, 209, 144, 211, 0, 0, 0,
      15, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 1, 101, 0>>,
    [{add, dep, 1}], o_rkv) ->
  ok
leveled_eqc:fold_run(7, #Fun<leveled_runner.4.26787583>) ->
  {'EXIT',
     {{badarg,
         [{re, run,
             [1,
              {re_pattern, 0, 0, 0,
                 <<69, 82, 67, 80, 73, 0, 0, 0, 0, 0, 0, 0, 17, 0, 0, 0, 255,
                   255, 255, 255, 255, 255, 255, 255, 15, 0, 0, 0, 0, 0, 0, 0,
                   0, 0, 64, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
                   0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 131, 0, 5, 29, 15, 120,
                   0, 5, 0>>}],
             []},

Recommendation: specify the type of IndexVal in book_indexfold spec provided in leveled_bookie or at least remark very clearly that regular expressions work over the IndexVals and that therefore these need to be strings if one uses this RegExp option.

Hopefully https://github.com/martinsumner/leveled/pull/175 is adequate


Fixes #RHIROS-1266 - Add groups support through RBAC

Why do we need this change? :thought_balloon:
The RBAC now returns groups to which user has access to. The System and dependent objects should be gated as per the group details.
Documentation update? :memo:

[ ] Yes
[ ] No

Security Checklist :lock:
Upon raising this PR please go through RedHatInsights/secure-coding-checklist
:guardsman: Checklist :dart:

[ ] Bugfix
[x] New Feature
[ ] Refactor
[ ] Unittests Added
[ ] DRY code
[ ] Dependency Added
[ ] DB Migration Added

Additional :mega:
Feel free to add any other relevant details such as links, notes, screenshots, here.

Just for the curiosity, when we return list of the system we also depend on if it has the performance profile associated. Is it necessary to only return the systems which are having performance profile when we do get systems api call?

Codecov Report
Patch coverage: 83.03% and project coverage change: +1.11% :tada:

Comparison is base (aa6c910) 72.96% compared to head (89a0c62) 74.07%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #346      +/-   ##
==========================================
+ Coverage   72.96%   74.07%   +1.11%
==========================================
  Files          29       30       +1
  Lines        1387     1462      +75
==========================================
+ Hits         1012     1083      +71
- Misses        375      379       +4

Flag
Coverage Δ

unittests
74.07% <83.03%> (+1.11%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed
Coverage Δ

ros/lib/rbac_interface.py
58.76% <70.58%> (+24.80%)
:arrow_up:

ros/lib/utils.py
86.84% <90.00%> (+1.87%)
:arrow_up:

ros/api/common/add_group_filter.py
100.00% <100.00%> (ø)

ros/api/common/utils.py
93.33% <100.00%> (+0.11%)
:arrow_up:

ros/api/v1/hosts.py
86.86% <100.00%> (+0.16%)
:arrow_up:

ros/api/v1/recommendations.py
86.84% <100.00%> (+0.35%)
:arrow_up:

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Thanks @PreetiW and @kgaikwad for quick reviews! I am merging this one!


Import into Nextcloud Cookbook

Hello 👋🏼
I want to import from your site into my nextcloud, but in order to do that I need your pages to have the right schema.
Nextcloud cookbook uses this 👉🏼  https://schema.org/Recipe as a way to know what elements are waht.
Is that something that you could help with?
issue with Nextcloud Cookbook: https://github.com/nextcloud/cookbook/issues/2520

Related to https://github.com/LukeSmithxyz/based.cooking/issues/954

Thank you for bringing this issue up. Let me look into the schema and get an idea for what is needed to make this happen. On Oct 29, 2024, at 11:33 PM, blackboxlogic @.***> wrote:
Related to LukeSmithxyz/based.cooking#954
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: @.***>


Property 'toSatisfyApiSpec' does not exist on type 'Matchers<void, Response>'

Are you using jest or chai?
jest
Are you using OpenAPI 2, 3.0.X, or 3.1.0?
3.0
Describe the bug clearly
Following the example for using jest-openapi when running the tests I get this message:
tests/openapi.test.ts:148:34 - error TS2339: Property 'toSatisfyApiSpec' does not exist on type 'Matchers<void, Response>'.

The environment is node 16.x running inside a docker container, configured as Typescript 4.8.x, ESM, and jest 27.x
Steps to reproduce the bug:

Install the library with yarn add -D jest-openapi
create a test following the example given here https://github.com/openapi-library/OpenAPIValidators/tree/master/packages/jest-openapi#readme
run the test

What did you expect to happen instead?
Test should run successfully

Got it to work by installing types from @types/jest and removing
import { expect } from '@jest/globals';


Enable only-new-issues for golangci-lint-action to fix linting unch…

Changes
There is an issue https://github.com/golangci/golangci-lint-action/issues/535 that has golangci-lint-action lint unchanged files which we are now seeing. People report that setting the version v1.47.3 address this issue. However, downgrading gets us https://github.com/golangci/golangci-lint-action/issues/440. Setting the  only-new-issues flag seems to fix the issue we are experiencing for now.

:bug: Fix bug

Still catches lint errors ^
example of passing without triggering unchanged files https://github.com/kvmware/serving/pull/8

/lgtm
/approve


Export scan

Hello,
I will like know how I can export scan in xml or json format.
Thanks and a greeting

The code is outputting the findings to a txt file, and isn't configured to output in xml or json.
You can easily adjust the nmap parts to output to xml, but this will not cover the recon results.

This files txt are saved in this route --> C:\N-Stalker\Free X\reports  ??

This is a Bash script, and is only meant to he ran on Linux.

Sorry I mixed tools


Set global_context_cache._platform use CUDA and mixed precision

When running a perses h-repex simulation with 60 replicas on lilac (using 1 node), I was seeing that on lx nodes, the job was running out of memory and subsequently using the CPU without throwing any warnings.
I added loggers to print out the platform. Here is a snippet of the log for the first iteration:
DEBUG:openmmtools.utils:LangevinSplittingDynamicsMove: Context request took    5.055s
DEBUG:openmmtools.utils:LangevinSplittingDynamicsMove: step(250) took  729.812s
DEBUG:openmmtools.utils:LangevinSplittingDynamicsMove: update sampler state took    0.002s
DEBUG:openmmtools.mcmc:LangevinSplittingDynamicsMove: Context obtained, platform is CPU
DEBUG:openmmtools.utils:LangevinSplittingDynamicsMove: Context request took    5.136s
DEBUG:openmmtools.utils:LangevinSplittingDynamicsMove: step(250) took  772.275s
DEBUG:openmmtools.utils:LangevinSplittingDynamicsMove: update sampler state took    0.001s
DEBUG:openmmtools.mcmc:LangevinSplittingDynamicsMove: Context obtained, platform is CPU
DEBUG:openmmtools.utils:LangevinSplittingDynamicsMove: Context request took    5.172s
DEBUG:openmmtools.utils:LangevinSplittingDynamicsMove: step(250) took  704.387s
DEBUG:openmmtools.utils:LangevinSplittingDynamicsMove: update sampler state took    0.001s
DEBUG:openmmtools.mcmc:LangevinSplittingDynamicsMove: Context obtained, platform is CPU
DEBUG:openmmtools.utils:LangevinSplittingDynamicsMove: Context request took    4.738s
DEBUG:openmmtools.utils:LangevinSplittingDynamicsMove: step(250) took  683.204s
DEBUG:openmmtools.utils:LangevinSplittingDynamicsMove: update sampler state took    0.002s
DEBUG:openmmtools.mcmc:LangevinSplittingDynamicsMove: Context obtained, platform is CPU
DEBUG:openmmtools.utils:LangevinSplittingDynamicsMove: Context request took    4.859s
DEBUG:openmmtools.utils:LangevinSplittingDynamicsMove: step(250) took  711.483s
DEBUG:openmmtools.utils:LangevinSplittingDynamicsMove: update sampler state took    0.002s
DEBUG:mpiplus.mpiplus:Running _get_replica_move_statistics serially.
DEBUG:openmmtools.utils:Propagating all replicas took 11295.271s

We should set global_context_cache._platform use CUDA and mixed precision in the future, so that an error will be raised if no CUDA context is available.

I think this has been addressed by @ijpulidos's context cache PR, so this can be closed, right?

Fixed by #938


Add pagination to GetPlayerNameWorldHistories()

Added pagination to PlayerNameWorldHistoryRepository.GetPlayerNameWorldHistories() because long queries are hitting the expression depth limit.
Not an urgent fix.

Thank you. I'm trying to wrap up the new API now and will push this together.


Errata for metadata terms

From<EMAIL_ADDRESS>on August 25, 2012 13:14:14

'defined class' - the definition is annotated as 'term editor'

'failed exploratory term' - the definition contains the type-o "used used"

'universal' - it has a definition source, but not a definition

Review the definitions and current intended use of curator and editor notes.  In talking with Alan, it seems that these definitions do not fit the way that these annotation terms are used.

'editor note' - currently defined as "An administrative note intended for its editor. It may not be included in the publication version of the ontology, so it should contain nothing necessary for end users to understand the ontology."
'curator note' - currently defined as "An administrative note of use for a curator but of no use for a user"
Original issue: http://code.google.com/p/information-artifact-ontology/issues/detail?id=136

From<EMAIL_ADDRESS>on January 14, 2014 14:55:33
1 and 2 are done rev 655.
For 3, I think maybe Barry could help and provide an acceptable definition of universal? Possibly with reference?
For 4 I don't know what was the discussion with Alan, for me the definitions match usage: editor note is stag users may be interested in, so should be kept, while curator notes are intended to be internal documentation.
Apologies for the exceptional delay in addressing those...
Status: Started
Cc<EMAIL_ADDRESS>


Fatal crash

Received this via Crashlytics, will share more details as I get from user.
Error Message -
Fatal Exception: java.lang.RuntimeException
Failure delivering result ResultInfo{who=null, request=1, result=-1, data=Intent { }} to activity {com.udaan.calculator.android/com.udaan.calculator.android.MainActivity}: java.lang.IllegalStateException: Reply already submitted

Stack -
Caused by java.lang.IllegalStateException: Reply already submitted
       at io.flutter.embedding.engine.dart.DartMessenger$Reply.reply(DartMessenger.java:35)
       at io.flutter.plugin.common.MethodChannel$IncomingMethodCallHandler$1.a(MethodChannel.java:14)
       **at com.hui.bluetooth_enable.BluetoothEnablePlugin.a(BluetoothEnablePlugin.java:37)**
       at io.flutter.embedding.engine.FlutterEngineConnectionRegistry$FlutterEngineActivityPluginBinding.a(FlutterEngineConnectionRegistry.java:25)
       at io.flutter.embedding.engine.FlutterEngineConnectionRegistry.a(FlutterEngineConnectionRegistry.java:15)
       at io.flutter.embedding.android.FlutterActivityAndFragmentDelegate.a(FlutterActivityAndFragmentDelegate.java:51)
       at io.flutter.embedding.android.FlutterActivity.onActivityResult(FlutterActivity.java:10)
       at android.app.Activity.dispatchActivityResult(Activity.java:8249)
       at android.app.ActivityThread.deliverResults(ActivityThread.java:4968)
       at android.app.ActivityThread.handleSendResult(ActivityThread.java:5016)
       at android.app.servertransaction.ActivityResultItem.execute(ActivityResultItem.java:51)
       at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:135)
       at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:95)
       at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2071)
       at android.os.Handler.dispatchMessage(Handler.java:107)
       at android.os.Looper.loop(Looper.java:224)
       at android.app.ActivityThread.main(ActivityThread.java:7561)
       at java.lang.reflect.Method.invoke(Method.java)
       at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:539)
       at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:995)

I am also seeing this issue with some users, did you ever find a fix? or at least a root cause?

Here's how a regular Play Store crash stack looks:
java.lang.RuntimeException:
  at android.app.ActivityThread.deliverResults (ActivityThread.java:5506)
  at android.app.ActivityThread.handleSendResult (ActivityThread.java:5547)
  at android.app.servertransaction.ActivityResultItem.execute (ActivityResultItem.java:51)
  at android.app.servertransaction.TransactionExecutor.executeCallbacks (TransactionExecutor.java:135)
  at android.app.servertransaction.TransactionExecutor.execute (TransactionExecutor.java:95)
  at android.app.ActivityThread$H.handleMessage (ActivityThread.java:2307)
  at android.os.Handler.dispatchMessage (Handler.java:106)
  at android.os.Looper.loop (Looper.java:246)
  at android.app.ActivityThread.main (ActivityThread.java:8512)
  at java.lang.reflect.Method.invoke (Native Method)
  at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run (RuntimeInit.java:602)
  at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:1130)
Caused by: java.lang.IllegalStateException:
  at io.flutter.embedding.engine.dart.DartMessenger$Reply.reply (DartMessenger.java:155)
  at io.flutter.plugin.common.MethodChannel$IncomingMethodCallHandler$1.success (MethodChannel.java:238)
  at com.hui.bluetooth_enable.BluetoothEnablePlugin.onActivityResult (BluetoothEnablePlugin.java:98)
  at io.flutter.embedding.engine.FlutterEngineConnectionRegistry$FlutterEngineActivityPluginBinding.onActivityResult (FlutterEngineConnectionRegistry.java:739)
  at io.flutter.embedding.engine.FlutterEngineConnectionRegistry.onActivityResult (FlutterEngineConnectionRegistry.java:426)
  at io.flutter.embedding.android.FlutterActivityAndFragmentDelegate.onActivityResult (FlutterActivityAndFragmentDelegate.java:677)
  at io.flutter.embedding.android.FlutterActivity.onActivityResult (FlutterActivity.java:624)
  at android.app.Activity.dispatchActivityResult (Activity.java:8541)
  at android.app.ActivityThread.deliverResults (ActivityThread.java:5499)

Notes: https://stackoverflow.com/questions/65666404/java-lang-illegalstateexception-reply-already-submitted-when-trying-to-call
Maybe result.success("true"); and result.success("false"); needs to be wrapped in a runOnUiThread? I haven't tried it yet.

The only way I could reliably reproduce this was to make it so there were two instances of the Bluetooth prompt on screen at once. When the user dismissed the second instance, the app would crash with the same error. Not sure if its the same root cause, but I'm working around it by making sure we don't prompt the user more than once

@insertjokehere You mean from two separate apps at the same time? Two apps which are both Flutter based and use the same plugin?

@MrCsabaToth no, just the one app. This was a bug where the user could press a button that would trigger the Bluetooth prompt while a task was running that would trigger the prompt after a few seconds - if you got the timing wrong, you could press the button to trigger the prompt before the task realised you didn't have Bluetooth turned on, so the app ended up asking you to turn Bluetooth on a second time before you had a chance to deal with the first prompt

"This was a bug" - is that bug ticketed? Is it fixed but there's some relapse happening here?

"This was a bug" as in a bug in our code, not in the library code

@insertjokehere Thanks, I should revise my code. In my case Bluetooth is an essential feature to my app so I kick in the bluetooth_enable during the start. But maybe users could disable the bluetooth while the app is in the background or something. I should experiment. But it'd still be good to have a solution at the plugin level as well to make it more robust?

HI I have looked through the error reported. Let me see if I can replicate it.

Hi I have looked through the error reported. Let me see if I can replicate it.

FYI this crash happened only a couple of times in the wild in my app, so it's a rare issue. I was not able to replicate it on my end.

It'd be beneficial to include java.lang.IllegalStateException in the title of the issue because "Fatal crash" is too broad.

Lately I got some NPE (NullPointerException) also in release from Android 12 phones, also inside onActivityResult just like the IllegalStateException:
java.lang.RuntimeException:
  at android.app.ActivityThread.deliverResults (ActivityThread.java:5304)
  at android.app.ActivityThread.handleSendResult (ActivityThread.java:5343)
  at android.app.servertransaction.ActivityResultItem.execute (ActivityResultItem.java:54)
  at android.app.servertransaction.ActivityTransactionItem.execute (ActivityTransactionItem.java:45)
  at android.app.servertransaction.TransactionExecutor.executeCallbacks (TransactionExecutor.java:135)
  at android.app.servertransaction.TransactionExecutor.execute (TransactionExecutor.java:95)
  at android.app.ActivityThread$H.handleMessage (ActivityThread.java:2214)
  at android.os.Handler.dispatchMessage (Handler.java:106)
  at android.os.Looper.loopOnce (Looper.java:201)
  at android.os.Looper.loop (Looper.java:288)
  at android.app.ActivityThread.main (ActivityThread.java:7842)
  at java.lang.reflect.Method.invoke (Native Method)
  at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run (RuntimeInit.java:548)
  at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:1003)
Caused by: java.lang.NullPointerException:
  at com.hui.bluetooth_enable.BluetoothEnablePlugin.onActivityResult (BluetoothEnablePlugin.java:98)
  at io.flutter.embedding.engine.FlutterEngineConnectionRegistry$FlutterEngineActivityPluginBinding.onActivityResult (FlutterEngineConnectionRegistry.java:739)
  at io.flutter.embedding.engine.FlutterEngineConnectionRegistry.onActivityResult (FlutterEngineConnectionRegistry.java:426)
  at io.flutter.embedding.android.FlutterActivityAndFragmentDelegate.onActivityResult (FlutterActivityAndFragmentDelegate.java:677)
  at io.flutter.embedding.android.FlutterActivity.onActivityResult (FlutterActivity.java:624)
  at android.app.Activity.dispatchActivityResult (Activity.java:8382)
  at android.app.ActivityThread.deliverResults (ActivityThread.java:5297)


ext/html: Mixins are broken when passing single argument

Here is a minimal example:
mixin test(arg)
    p= arg

.hello
    +test('world')

Expected result:

world

Actual result:

w

While does it happen: in ext.html.Compiler._make_mixin._mixin, arguments are parsed like this:
if args:
    arg_values = self._do_eval(args)
else:
    arg_values = []
...
local_context = dict(zip(arg_names, arg_values))

As a result, if there are at least 2 arguments passed, args is something like 'world', 2 and is evaluated to tuple: ('world', 2). Then later zip properly joins sequence of names with sequence of values.
But if there is only one argument, then eval returns this argument. As a result, string is interpreted as a sequence of characters. And if it is not a string but something more complex (like WTForms field) then we get error.
How can this be fixed:
I think that before passing args to _do_eval we should just wrap them with []:
arg_values = self._do_eval('[%s]' % (args or ''))

This will properly work even when no arguments was passed.

And for now there is a workaround: add , after last argument.


Technical user page click on copy icon should trigger Snackbar

Also configure IDP overlay Redirect URL
Current Behaviour
Technical user page click on copy icon should trigger snackbar
Screenshot

Expected Behaviour
Technical user page click on copy icon should be in Blue and  trigger snackbar
Steps To Reproduce
1.Login to Catena-X portal
2.Click on connector Management
3.Click on Details
4.Click on technical user link and Observe

Hi @MaximilianHauer
i Tested this issue it's working fine Can you close this ticket.
Attached Screenshots for References:


generator: add FIXED feature to generator

Scope
The scope of this update is to add the FIXED feature to the generator so that all future components can take advantage of the feature.
There is a secondary scope to this as there is a bug in all of the repos that have this feature. Upgrading to the 3.0 generator will address that bug.
Exit criteria
This issue will be complete once the FIXED feature has been implemented within the generator and is automatically set up as an option with any new development.

Scope added to https://github.com/AlaskaAirlines/WC-Generator/pull/112


chore: Use Zephyr logging macros directly

Zephyr logging is a complex thing that does a lot of magic and optimizations. Using the macros from one place with a single '%s' argument leaves no room for magic. By using the macros directly from various places in our sources and with the various arguments, we give the magic a chance to happen.
Note
This makes zero difference in how things work (or rather doesn't) on my ESP32-EVB board. The only difference is that I now see the full URL:
[00:00:09.878,000] <inf> mender: Downloading artifact with id 'f47ef20...', name 'update56', uri 'https://c271964d41749feb10da762816c952ee.r2.cloudflarestorage.com/mender-artifacts-us/66eaa007a9b44e490044b0f5/d1758124-ab9d-4e8f-b05a-1d511d29826c?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=a848c3308d7d52663bbd129dff6a18b7%2F20241122%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20241122T123414Z&X-Amz-Expires=86400&X-Amz-SignedHeaders=host&response-content-disposition=attachment%3B%20filename%3D%22update56.mender%22&response-content-type=application%2Fvnd.mender-artifact&x-id=GetObject&X-Amz-Signature=04dfcf135a363040852b004034ad7cacb4745447d32bc7a3bc4b1a72ae41defc'

(so the changes are applied and "working")

At least we know now. We must look somewhere else to remove crashes.

But this ideally should not be exposed as a library (mender-log.h) and just use a set of macros in mender-utils.h like MENDER_LOG_INFO that does LOG_INFO on Zephyr, and SOMETHING_ELSE in future platforms .

I don't see a difference between this being in mender-utils.h and in mender-log.h. Except for better readability and nicer structure in the latter case. Esp. if it has #ifdefs which make things harder to read. The fact that something is a separate header file doesn't mean it's a "library". I'd actually put the zephyr stuff into mender-log-zephyr.h and do
#ifdef __ZEPHYR__
#include "mender-log-zephyr.h"
#endif

in mender-log.h.

My point is to drop the .c file(s). Hence making it header only once it is already platform specific in there.

But you need to do some initialization. The mender_log_init() is empty for now, but still we at least need to do LOG_MODULE_REGISTER() exactly once somewhere. Why do you think having a .c file as well is an issue?


Runtime Error

The "ta2-search.py" code does not run in the current  #17 . In 'Controller.py':8 we have import dsbox.template.runtime as runtime that results in following error:
ModuleNotFoundError: No module named 'dsbox.template.runtime'.
In the previous version of the code, this line was import d3m.runtime as runtime. So either the file is not added to repo or this import should not change.

Just added runtime.py
For now I decided to move runtime.py into our code, so the people don't have to manually copy my version of the file. If d3m updates their runtime.py, then we may switch back.


Minor tables fixes

I made this breaking because of the TableRefNameField change.

Nothing's depending on it yet, so we could stick with revision if the first version of sdbe to use DefaultTables will use this PR.

@alissapajer Yeah, revision is probably fine, I can depend on this version over in sdbe.

@wemrysi oops I pushed the PreparationEvent commit to this branch. I meant to push to a new branch and make a new PR.

@alissapajer no worries, let's just change the version to feature.


DevTools: Kafka Env Refresh

Description of your changes
We've created a super fast script to refresh the Kafka development environment running locally.  It deletes relevant keys and namespaces, reinstalls Kafka on Kubernetes, and sets up the passwords using generic files.
May be better applied in the Makefile, but for now it works and is efficient.
The prerequisites are having everything installed.  This does not break the process of manual installs using the README, or alter the process in any other way.
This is for development only, and won't work in other environments, nor is it intended to.  I placed them in a subdirectory devutils to prevent confusion.  Can easily be deleted and deprecated at release time.

@marshmallory this sounds great!
There are also some utilities in build repo for local development, which would make thing work with make and could also handle installing some dependencies. provider-helm uses that to spin up a local dev environment. Please let me know if you are interested in integrating that and I can help further.


Add validation check before changing bird config

This is a partial fix for https://github.com/projectcalico/calico-bird/issues/12, preventing BIRD from updating its config if the updated config will cause bird to fail.

LGTM