Turned off debug mode in shared_library

This turns off the debug mode for the shared_library build configuration for the time being, as was agreed by the maintainers. There's no need to revert the "dcheck" patches, as they have no effect in non-debug mode.

@jkleinsc All the builds were aborted, can you please restart them?

@alexeykuzmin builds have been restarted

Shall we merge it? All builds are 🍏

@alexeykuzmin Even though it was marked as green, the linux-x64 build didn't upload to S3.  I would like to test it locally with Electron on linux-x64 before merging because that the arch that we were having issues with.

I am rerunning the linux-x64 build now, so hopefully it runs properly this time.

@alespergl It seems like there is one redundant commit in this PR because of a force push into master.

How did that happen? Can we force-push the previous master back, so that I don't have to trigger new builds of this by rebasing?

How did that happen?

Bad things happen from time to time, see https://github.com/electron/libchromiumcontent/pull/336#issuecomment-321419320.

Can we force-push the previous master back, so that I don't have to trigger new builds of this by rebasing?

I wouldn't do that, some other folks have already created PRs on the top of the new master.
Anyway, let the GitHub guys to decide.

@alespergl it was my fault.  I'll clean it up.

@alespergl this tests fine so I am going to merge it in.  cc @alexeykuzmin


Create a user-guide

Take a look at asciidoc, gitbook, etc.

We need a user guide. What are our business and technical requirements?

which input format, e.g. markdown, ...
which output format(s) (pdf, html, ...)?
infrastructure, e.g. how to maintain/deploy?

Additionally we need a draft of an outline.

Do you want to focus on source code examples?

AsciiDoctor is better than Markdown, if you want to show code examples and highlight important parts.

Do you want to be able to update the documentation on a tablet using just a Browser instead of using a developer notebook with Git and other tools installed?

You could use GitHub, TravisCI and AsciiDoctor for that
Or readme.io

Do you need offline documentation?

AsciiDoctor can generate the same documentation in HTML, PDF and EPUB.

XML + XSLT = Any format! :)

How about markdown. I think Github Flavoured Markdown is sufficient and a lot of people comfortable to write in markdown.
i will take a look to AsciiDoctor.

How about integration with javaslang.com website. I think it cooler if documentation available on website too. So reader no need to look at github wiki.

AsciiDoctor documentation looks like this. http://docs.spring.io/spring-boot/docs/current/reference/htmlsingle/
Table of Content can also be on the left or right side.
As I said Markdown sucks compared to AsciiDoctor, but the syntax is quite similar.

AsciiDoctor seem nice.
+1 for AsciiDoctor

any idea for draft of an outline?

+1 for AsciiDoctor
@RobWin @jasoet-gdp I also thought about using Markdown because of simplicity. But asciidoc seems to be the right tool here. It is also simple but more powerful. It is a standardized way to produce documentation targeting different formats (print, web, ...). Let's take it! Compared to readme.io I prefer asciidoc because we have no vendor dependency and we are free to build our own build and deployment chain with the tools of our choice.
@lukaseder it may be tempting to use XML + XSLT. I've done it years ago with apache fop :-) My resumé: simple things are possible - complex things are masochistic ;-)

@jasoet-gdp I will write an outline this evening (GMT+1 here)

@RobWin The Griffon Guide looks awesome!

Why masochistic? It's fun! What do you mean by "complex"? Our docs are all done with XSLT: http://www.jooq.org/learn

Maybe I'm a little out-dated here. I used fop 9-10 years ago. I'm sure that it emerged in the mean-time.
I prefer non-xml formats for readability reasons (less noise).

No one wants to write text in XML! :)
Have a look at http://www.asciidocfx.com/ as a nice tool to write in AsciiDoctor with a live view.

@robwin there needs to be a business case for lukas. The consumer of the documentation will see no difference I guess. However, a xslt from xml to asciidoc should be seemlessly possible :-)
/cc @lukaseder

But the writer does see the difference, if you dont use a tool for docbook.

Okay.  I'll try AsciiDoctor tonight. GMT+7 Here :)
On 17 Sep 2015 17:22, "Robert Winkler"<EMAIL_ADDRESS>wrote:

But the writer does see the difference, if you dont use a tool for docbook.
—
Reply to this email directly or view it on GitHub
https://github.com/javaslang/javaslang/issues/280#issuecomment-141037342
.

Great!

Note:
We should target all of these output formats: HTML, PDF and EPUB.
Also the documentation should be integrated on the website. Maybe we will open a new tab for now because the website is a single page.

Have a look at Spring Boot Docs too see how they are doing it with Maven
https://github.com/spring-projects/spring-boot/tree/master/spring-boot-docs

Noted
On 17 Sep 2015 17:42, "Daniel Dietrich"<EMAIL_ADDRESS>wrote:

Note:
We should target all of these output formats: HTML, PDF and EPUB.
Also the documentation should be integrated on the website. Maybe we will
open a new tab for now because the website is a single page.
—
Reply to this email directly or view it on GitHub
https://github.com/javaslang/javaslang/issues/280#issuecomment-141040350
.

We will remove slice(beginIndex) since it has exactly the same semantics as drop(count) (even if slice() takes an index and drop() take a count).
However, subSequence(beginIndex) is still needed because it throws on invalid index.

there needs to be a business case for lukas

Exactly. I can change stylesheet, layout, versioning, formatting, etc. extremely easily using XSLT. But if you don't need that, I agree that XML is more tedious to write. It's always a tradeoff.

:+1:

The User Guide should give an overview over the Javaslang 2.x functionality. Here is a draft/first shot of the outline:
Lines starting with - are hints to the corresponding methods/functions, e.g. - memoized.
Tuples
Functions and Lambdas
  Unchecked vs. Checked Functions
  Function Memoization
    - memoized
  Curried Functions
    - curried
  Function Composition
    - andThen
    - compose
  Lambda Type Reflection
    - getType
Interface Iterable
  Equality
    - equals
    - eq
    - corresponds
Values
  Capturing State and Monadic Operations
    - get
    - isEmpty
    - map
    - flatMap
    - filter
  Conversion Operations
    - toXxx
  Side Effects
    - forEach
    - peek
    - out
    - stdout
    - stderr
Lazy Evaluation
Controls
  Option: Null Safety
  Try: Failure Handling
  Either: Disjoint Union Type
  Pattern Matching
Collections
  Interface TraversableOnce
  Interface Traversable
  Sequences
    Indexed Sequences
    Linear Sequences
  Sets
  Maps
  Concrete Immutable Collection Classes
  Arrays
  Character Sequences
  Iterators
  Conversions Between Java and Javaslang
    - ofAll
    - toXxx (see Value)
  Performance Characteristics
Concurrency
  Future
  Promise
Property Checking
  Generators
  Arbitrary Objects
  Properties
  Check Results and Assertions

We should add an additional first-level section Idioms, which provides deep insight into the design of Javaslang.
Idiom: Static Factory Methods
Javaslang's collection interfaces like Seq, IndexedSeq, ..., Set, ... are similar to Scala's. But there is one important difference: Javaslang does not provide static factory methods for inner interfaces (read: non-terminal types) like Seq. Exception: List, but this is not really an exception, because List is composed of Nil and Cons, so we need factory methods in the List interface.
Example:
// Scala: Seq[Int] = List(1, 2, 3)
val seq = Seq(1, 2, 3)

// Javaslang: Seq<Integer> = List(1, 2, 3)
Seq<Integer> seq = List.of(1, 2, 3)

What we see is, that Scala provides a default implementation for Seq, which is List. In Javaslang, we keep the (Java) code clean of any kind of implicit defaults, conventions over configuration magic etc. Everything is explicit, the user has to choose the behavior. This makes the code readable and predictable and we are able to reason about it.

@jasoet-gdp @RobWin in a first step we should setup asciidoc within our project. E.g. by adding it to the pom.xml. The resources should not be included in a 'normal' build/jar. It is ok, if we build it locally 'by hand' in a first step, i.e. it is not necessarily needed to be built automatically with a travis-ci build for now.
Question: Are there any best practices for the (maven) folder/project structure, e.g.

src/main/asciidoc
doc/...
src-doc/...

If we have the build up and running, the second step is to create the outline (without content). It would be cool to see html, pdf and epub at this stage :-)

Is Javaslang a standard GitHub account or an organsiation?
Create another repo or maven module called javaslang-docs and the folder src/main/asciidoc.
Create an index.adoc which includes all other files and specifies some constants. See as an example https://github.com/spring-projects/spring-boot/edit/master/spring-boot-docs/src/main/asciidoc/index.adoc

Thx! Javaslang is currently a GitHub account. I hesitated to convert it to an Organization because there is no way back and I don't know the benefits. Can you explain?

Add the AsciiDoctor maven plugin
<plugin>
						<groupId>org.asciidoctor</groupId>
						<artifactId>asciidoctor-maven-plugin</artifactId>
						<version><IP_ADDRESS></version>
						<executions>
							<execution>
								<id>generate-doc</id>
								<phase>generate-resources</phase>
								<goals>
									<goal>process-asciidoc</goal>
								</goals>
								<configuration>
									<sourceDocumentName>index.adoc</sourceDocumentName>
									<backend>html5</backend>
								</configuration>
							</execution>
						</executions>
					</plugin>

I think its better if javaslang converted to Organization. So more people (github account) can associate with it.
For AsciiDoctor there are a lot of example using maven plugin https://github.com/asciidoctor/asciidoctor-maven-examples. We just need to pick what we need.
@danieldietrich so, which repository that we will use to store User-Guide. I think its better if user-guide repository separated from main javaslang repository.

In an organisation you can have multiple repos under one common name and you can create teams and add members to teams which are allowed to contribute to different repos.

@danieldietrich @RobWin and if javaslang in an organization, we can create a repo contains example usage for javaslang in conjunction with other framework such as Spring Framework, Spring Data JPA, Jackson JSON Module, etc.

@jasoet-gdp @RobWin this all sounds really exiting. The only stopper of progress can be only 'fear' - as always in life... My fear is to loose control, e.g. about growth. Let me sleep one night about that and I will create an organization :-)

@jasoet-gdp @RobWin Done. Javaslang is now an organization. Feels good :-)

Wooaah - this turns out to be complicated. Whom to invite to the organization an whom not??

@jasoet-gdp @RobWin I've created a new repo javaslang-docs. You will get write permissions there when joining the organization.

You dont have to add us as Team members. We still can and should contribute via PRs.

Ok. What is your suggestion regarding whom to invite to take part of the open source organization? How do other companies it?

I like to have a team of committers - active or not.

PR's are important. They need to be mentioned in the CONTRIBUTION file (which needs a rewrite). I like the Typelevel Scala CONTRIBUTION.md.

Documentation has now its own home (and issues). We close this ticket. Next we will create an outline.
See javaslang/javaslang-docs#7


Table API - Tag Mapping Filter Updates

The filter for the right click mapping menu should be set to "Update while typing" so the results are filtered instantaneously rather than having the user click out of the box.
It would also be nice to include a checkbox that filters out tags that already have a reader if attempting to map a "from tagbus" channel. I've noticed that with projects with large numbers of tags, most tags only have one reader anyways. This would greatly simplify mapping and reduce mapping errors.
I'm happy to implement the changes if anyone else thinks this is a good idea.

Sounds like a great idea!


Remove the SetElasticityOptions call

The SetElasticityOptions for the BoomerAMG preconditioner in the solid mechanics module was seg faulting on HYPRE_BoomerAMGSetInterpRefine(amg_precond, interp_refine) in a user code. This turns off that feature in favor of a simpler system size adjustment.
It also fixes a bug in the ParameterizedLinearIsotropicSolid material object and adds a test to ensure it compiles.

Codecov Report

Merging #957 (1b5b03e) into develop (6b8c563) will increase coverage by 0.00%.
 Consider uploading reports for the commit 4654396 to get more accurate results

@@           Coverage Diff            @@
##           develop     #957   +/-   ##
========================================
  Coverage    89.23%   89.24%
========================================
  Files          141      141
  Lines        10554    10562    +8
========================================
+ Hits          9418     9426    +8
  Misses        1136     1136

Impacted Files
Coverage Δ

...physics/materials/parameterized_solid_material.hpp
100.00% <100.00%> (ø)

src/serac/physics/solid_mechanics.hpp
85.06% <100.00%> (ø)

src/serac/physics/tests/solid.cpp
95.68% <100.00%> (ø)

src/serac/physics/tests/solid_shape.cpp
100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

I believe this is ready to go now.


Add data exploration and add plot_bold_nii functions in utils

add data_exploration ipython notebook file, which explores our data
add plot_bold_nii function in utils to plot every slice of an 3D fMRI image in one plot
add a README file
modify Makefile

Resolved your merge conflict and created a new pull request. Please take a look.


add headers to http response is not work

in the demo code,  add to HTTP response header is not work because the response had committed!
@Configuration(proxyBeanMethods = false)
class MyConfig {

    @Bean(name = HttpServerResponseParser.NAME)
    HttpResponseParser myHttpResponseParser() {
        return (response, context, span) -> {
            Object unwrap = response.unwrap();
            if (unwrap instanceof HttpServletResponse) {
                // http response have committed, so not work.
                boolean isCommitted = ((HttpServletResponse) response.unwrap()).isCommitted();
                HttpServletResponse resp = (HttpServletResponse) unwrap;
                resp.addHeader("MyCustom", "Header");
            }
        };
    }

}

https://docs.spring.io/spring-cloud-sleuth/docs/current/reference/html/howto.html#how-to-add-headers-to-the-http-server-response

Hmm that might be a problem then. Cause we set it up for Brave to process it. Can you create a small sample that replicates this problem? I would see how (if) we could work this around.

debug enter it, return readonlyheader, can not modify.
because reponse is State.COMMITTED.

Yeah... most likely I need to change the docs and show an example of a filter to achieve sth similar.

New examples:
import org.springframework.cloud.sleuth.Span;
import org.springframework.cloud.sleuth.Tracer;

import javax.servlet.Filter;
import org.springframework.web.server.WebFilter;

@Configuration(proxyBeanMethods = false)
class MyConfig {

		// Example of a servlet Filter for non-reactive applications
		@Bean
		Filter traceIdInResponseFilter(Tracer tracer) {
			return (request, response, chain) -> {
				Span currentSpan = tracer.currentSpan();
				if (currentSpan != null) {
					HttpServletResponse resp = (HttpServletResponse) response;
					// putting trace id value in [mytraceid] response header
					resp.addHeader("mytraceid", currentSpan.context().traceId());
				}
				chain.doFilter(request, response);
			};
		}

		// Example of a reactive WebFilter for reactive applications
		@Bean
		WebFilter traceIdInResponseFilter(Tracer tracer) {
			return (exchange, chain) -> {
				Span currentSpan = tracer.currentSpan();
				if (currentSpan != null) {
					// putting trace id value in [mytraceid] response header
					exchange.getResponse().getHeaders().add("mytraceid", currentSpan.context().traceId());
				}
				return chain.filter(exchange);
			};
		}
}


[BUG] Smart search - string validator issues

Describe the bug
When using the smart search and adding a field with a string value using the suggestion it worked fine.
After the string field is added, editing it causes the string to be invalid
To Reproduce
Steps to reproduce the behavior:

Add a string field using the suggestion
click outside of the search
edit the existing value string(add a letter at the end)
See that the search input is invalid

@sefija this should depends on scheme, no? if it is something like field: ['aa', 'bb'] there will be an error, but if it's field: ['aa', 'bb', 'string'] there should be not


Revised GetGroup and GroupRequest

This removes the GetGroupByUserAndCourse RPC method and the GetGroupRequest message type, since these can be handled via the GetGroup method using GroupRequest.
Fixes #935

Codecov Report

Merging #936 (f35ee29) into master (d733d76) will increase coverage by 0.19%.
The diff coverage is 16.66%.

@@            Coverage Diff             @@
##           master     #936      +/-   ##
==========================================
+ Coverage   30.49%   30.69%   +0.19%
==========================================
  Files          92       92
  Lines        8994     8955      -39
==========================================
+ Hits         2743     2749       +6
+ Misses       5957     5913      -44
+ Partials      294      293       -1

Flag
Coverage Δ

unittests
30.69% <16.66%> (+0.19%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

qf/ids.go
0.00% <ø> (ø)

qf/quickfeed.pb.go
87.50% <ø> (ø)

qf/validation.go
0.00% <0.00%> (ø)

web/interceptor/access_control.go
67.85% <ø> (ø)

qf/requests.pb.go
3.79% <3.12%> (+0.16%)
:arrow_up:

web/quickfeed_service.go
34.46% <91.66%> (+1.28%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Make the status of getNodeAvailability dynamic

Description
Make the status of getNodeAvailability dynamic, it was down even it's standby
Changes

Related Issues

https://github.com/threefoldtech/tfgrid-sdk-ts/issues/2900

Checklist

[ ] Tests included
[x] Build pass
[ ] Documentation
[x] Code format and docstrings
[x] Screenshots/Video attached (needed for UI changes)

I think it's just up from a second, @AhmedHanafy725 can you confirm?

I think it's just up from a second, @AhmedHanafy725 can you confirm?

It wasn't up at all in the past seconds and just went up, is that the case?

I think it's just up from a second, @AhmedHanafy725 can you confirm?

It wasn't up at all in the past seconds and just went up, is that the case?

it's what I got too, @0oM4R can you check the same node again please?

I think it's just up from a second, @AhmedHanafy725 can you confirm?

It wasn't up at all in the past seconds and just went up, is that the case?

it's what I got too, @0oM4R can you check the same node again please?

@samaradel  after about 1 hour

and for many other up nodes


ProgressBar: Add with_elapsed for overridding elapsed time

This PR adds ProgressBar::with_elapsed() which provides a way to override the elapsed time of a progress bar.
This is useful for scenarios where you dynamically create additional ProgressBars for "sub-tasks" and want to preserve the elapsed time in the output. Since ProgressBar exposes the elapsed time as a Duration, with_elapsed is more ergonomic than with_start_time.

Thanks, this makes sense! (Especially thanks for the pre-emptive note about the with_start_time() alternative.)


encrypt() and decrypt() APIs use own ArConnect-specific encryption methods

Is there any good reasons why ArConnect doesn't allow direct RSA encryption/decryption, without ArConnect's algorithm with adding symmetric keys there?

We haven't received any requests for this yet. Feel free to work on it tho :)

@martonlederer Thanks for reply! How do you think, how many apps are already using arconnect version, and should we add 2 new methods instead (encryptRSA, decryptRSA), because changing algorithm to default RSA encryption/decryption instead of ArConnect's version will result to breaking changes.

I'd like to hear the opinion of @jfbeats and @DanMacDonald  as well.

Hey Marton! 😀 The encrypt and decrypt for arweave.app already use the model @angrymouse is talking about so that people can implement their own protocols.
If you want to add them, I think you can do it without breaking changes by looking at the number of parameters for the function call, and just selecting between the old and new implementations depending on if the required params are provided or not.

Thanks @jfbeats, will proceed accordingly. 😀

Yeah, I have two codepaths for decrypting weavemails, one for arweave.app one for arconnect. It would be nice to combine them into one. With the wallet only performing an RSA encrypt, it frees the app up to use whatever flavor of AES (or other) encryption they like.
e.g. of what my code looks like right now...
export async function decryptMessage(message: PermamailData, arweave: Arweave): Promise<InboxItem> {
  let encryptedData = message.messageBlob;
  let walletType = walletService.getWalletType();
  let mailData = null;

  switch (walletType) {
    case WalletType.JWK:
    case WalletType.WalletConnector:
      // Split up the transaction data into the correct parts
      const symmetricKeyBytes: Uint8Array = new Uint8Array(encryptedData.slice(0, 512));
      const mailBytes: Uint8Array = new Uint8Array(encryptedData.slice(512));

      // Decrypt the symmetric key from the first part
      const symmetricKey = await walletService.decryptRSA(symmetricKeyBytes);

      // Use the symmetric key to decrypt the mail from the last part
      const decryptString = Arweave.utils.bufferToString(await Arweave.crypto.decrypt(mailBytes, symmetricKey));
      mailData = JSON.parse(decryptString);

    break;
    case WalletType.ArConnect:
      // ArConnect specific decrypt flow
      const stringData  = await window.arweaveWallet.decrypt(
        encryptedData, { algorithm: "RSA-OAEP", hash: "SHA-256" }
      );
      mailData = JSON.parse(decryptString);
    break;
    default:
      console.error(`Decrypting with unknown wallet type ${walletType}`);
    break;
  }

If ArConnect was only to perform RSA encrypt/decrypt this could all be collapsed to use the same 4 lines for all cases.


Restructure package

Currently, all the functionalities of GHEtool are placed in the main_class.py, with a few variable classes.
Since the number of functionalities of GHEtool is increasing, a new structure is needed in order to cope with this changes.
This issue is related to this task.
The idea is to split the main_class.py into a Borefield, GeothermalSystem and HybridGeothermalSystem class, each extending on the previous class.

The Borefield class will contain all the information about borefield sizing from the borefield perspective itself.
The GeothermalSystem class takes the heat pumps into account, so there can be accounted for variable COP's. Also the functionality to optimise the load profile will be moved to this class, since it works with the geothermal system and not so much the borefield itself. The active- and passive cooling functionality will be implemented here.
The HybridGeothermalSystem class will move towards a hybridisation of the system. E.g. regeneration will be taken into account here.

Furthermore, up until now, everything related to g-functions has been part of the main_class.py. This will also be moved to a seperate class to improve readability.

Everything related to the g-function calculation is moved to issue #57 .

[ ] _calculate_temperature_profile should be changed once optimise_load_profile is moved into the GeothermalSystem class. Currently, it checks whether or not 'hourly_heating_load_on_the_borefield' differs from an empty array. When using the GeothermalSystem class, all the profiles in the Borefield class will be geothermal by nature, so this distinction is no longer needed! The _calculate_temperature_profile which will be implemented into the GeothermalSystem class will use only the 'load_on_the_borefield' to calculate everything.

For this major restructuring, the following tasks will be created in separate subbranches (issue45-restructure-package-XX). Afterwards all these branches will be merged into the issue45-restructure-package branch and merged into the main branch.
The goal of this restructuring is creating classes which have single responsibilities.

[ ] GUI: restructure gui so calculation thread and data storage class don't need to be altered anymore.
[ ] GUI: split gui_classes into seperate classes in a new folder
[ ] Grounddata: create ground data metaclass with three instances: GroundConstantTemperature, GroundFluxTemperature, GroundGradientTemperature. This will make the 'use_constant_Tg' variable in SizingSetup class obsolete
[ ] Load: create a meta class for the loads with two subclasses (monthly and hourly). These separate classes make it so that the check whether or not there is hourly load available, becomes obsolete, due to the difference in classes themselves.
[ ] Limit: create an abstract class for the temperature limits, with two subclasses: ConstantTemperatureLimit and VariableTemperatureLimit. These classes also contain the simultion_period data
[ ] Pipe: create an abstract pipe class with two subclasses: UPipe and CoaxialPipe. This also refers to issue #40 .
[ ] Borehole: create a borehole class, containing a pipe class, fluid class and the Rb* calculation. Also the param 'use_constant_Rb' can be moved in this class.

After all the above changes are implemented, we have to look at two things:

[ ] Backwards compatibility (we need to update this test to include v2.1.2).
[ ] The JSON storage for I do not know if it is capable right now of storing nested classes. This has to be checked later.

[ ] Update documentation

Hi @wouterpeere,
I have implemented a new json apporach which should take care of the different types of objects for the Ground Data etc. The main think we have to take care of is to define the v2.1.1 Version of the different object. Like GroundFluxTemperature is the groundData type for v2.1.1. Important is that the Object can handle all possible data like the flux attribute for the groundData, which the GroundConstantTemperature does not have. Can you please have a look at it?
With best regards
@tblanke

Hi @tblanke
I noticed some bugs when loading files in the GUI restructuring branch.
You can replicate this bug as follows:

delete the backup
create a random GHEtool file with certain parameters and two different scenario's. Important: set the autosave option to True.
save this file
save this file again but under another name
change one input of the first scenario in the current file
save and open the other one
you can see that the change you made in the first document, is visible here as well

Best,
@wouterpeere

Hi @tblanke
I noticed you created a max_depth function in issue45-restructure-package-load, like this: "(t_max - self.Tg)/(2 * self.flux) * 2 * self.flux". This does not return a depth buth a temperature, as far as I can tell, since the '2*self.flux' cancel out.

Hi @wouterpeere ,
Correct I have uploaded a fix. It is (t_max - self.Tg)/self.flux * self.k_s

Hi @tblanke
I added the coaxial pipes to the GUI (branch issue45-restructure-package-pipe).
Can you just add the German translations for the last 6 rows in the translations.csv document?
Afterwards is will merge this into the main issue45-restructure-package branch.
Best regards,
@wouterpeere

Hi @wouterpeere,
done.
With best regards
@tblanke

Hi @tblanke
Thanks!
I was implementing tests for the coaxial pipe in the gui, when I noticed that the equivalent borehole thermal resistance of the coaxial pipe (in contrast with the U-tubes) does not depend on the ground thermal conductivity. I opened an issue on pygfunction to check this: https://github.com/MassimoCimmino/pygfunction/issues/263
Do you think this is normal behaviour?
Best,
@wouterpeere


Wave 02 - Bug in Fixed Controls

Describe the bug
I found a feature or bug in the fixed controls on pages in BC15.
We have some pages with this feature. It worked fine for the last versions. But now the Captions is displayed, even though it should be hidden.
To Reproduce
Steps and to reproduce the behavior:
I searched for your pages in the webclient (Page 39 or 253 or 254 for example). The caption is shown there too.
This is an example for the page 39:

AL Code to reproduce the issue
Expected behavior
I think it should be fixed and the „AccName“ should not be shown there.
Screenshots
This is the code example (which was copied from a standard page before):

5. Versions:
<IP_ADDRESS> (BC wave 2)

Hi @GeekEding, thank you for reporting the issue. We've already fixed this bug on our side by putting ShowCaption = false on this field. Please try the latest BC build, it should be fixed there.


Improve address configuration for waypoints

This changes waypoint Gateway's to report IP address as status instead of Hostname. This will allow us to ready Gateway's for waypoints instead of Service, helping with things like https://github.com/istio/istio/issues/46495.
This moves towards the goal of having Waypoints solely configured based on Gateway, with the Service/Pods being an implementation detail that is not depended on. This would allow, for example, running the waypoint via a different mechanism.
hold: discussing with gateway community if this makes sense

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@howardjohn: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
e7dc49ffe510fb1ea4e0a4a055a427bfffe54b63
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
e7dc49ffe510fb1ea4e0a4a055a427bfffe54b63
link
true
/test lint

gencheck_istio
e7dc49ffe510fb1ea4e0a4a055a427bfffe54b63
link
true
/test gencheck

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Are we copying spec.addresses into status then, and the rest of our code relies on readiness?
Should multi-network gateways that utilize gateway API also rely on this behavior?

Are we copying spec.addresses into status then, and the rest of our code relies on readiness? Should multi-network gateways that utilize gateway API also rely on this behavior?

We should come up with some way to say "This was ready once". The current conditions can change from ready->not ready so I don't think its appropriate.
This proposal is to use Address to be the "sticky ready". But I want to see if we can get some upstream consensus on this. Rob mentioned, for example, this may not be good for things that want to operate on the address before its ready (for instance, external-dns)

Questions around upstream consensus, aside this LGTM

ok I think this is good to go, we can have more discussion with upsteam but this is strictly and improvement over the current state IMO

Is there a reasonable way to test this? I guess it's difficult to integ test since we do deploy it at setup. Can we add and remove a waypoint in some individual test?

hold: discussing with gateway community if this makes sense

Added hold just because of this line in the description. LGTM

The concern was not adding Address before we are ready. In this PR, we don't change that, just make sure we keep the address even if we become not-ready, so I think this is strictly an improvement. We may need to make other adjustments but I think we can go ahead with this for now


community: add modelscope endpoint

Description
Add ModelScope inference API endpoint for both LLMs and ChatModels.
ModelScope is a leading platform to bridge model checkpoints and model applications. It offers the infrastructure for sharing open models and facilitating model-centric development (https://github.com/modelscope).

We have already integrated the modelscope embedding at https://github.com/langchain-ai/langchain/blob/master/libs/community/langchain_community/embeddings/modelscope_hub.py. What should we do next? Should we still release a new package and include the embedding in it?


Weird glitter around icons and text

After 'tab' to another apps I can see apperance of weird glitter around icons as well as text (as soon as I start editing text glitter dissapears though). Glitter around icons usually persist for up to few minutes. Obviously this is the case only with VS.

/duplicate of #93356 or #94523
Should be fixed with starting VS Code with code --disable-gpu or more permanent setting https://code.visualstudio.com/updates/v1_40#_disable-gpu-acceleration


Monitoring Disk Space

Discuss and determine solution for monitoring disk space. If disk is almost full, we should report warning.
If using a 3rd party tool, we should have easy configuration instructions that we can add to the repository.

I have a solution.
But this service provides 15 days free support.
So I want you to try this.
http://www.monitis.com/support/server-device-monitoring/drive-monitoring

This solution will work


Fix etcdctl command in bottlerocket etcd backup documentation

Issue #, if available:
Description of changes:
Testing (if applicable):
Documentation added/planned (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/approve
/cherry-pick release-0.20
/cherry-pick release-0.19

/cherry-pick release-0.19


tape-eval error

When I run tape-eval transformer secondary_structure results/secondary_structure_transformer_20-03-10-17-00-07_837748/ --metrics mae --split casp12 it gives me an error about the metric not existing in the metric_name_mapping.

I used tape-train transformer secondary_structure --batch_size=4 --gradient_accumulation_steps=4 --num_train_epochs=1 to quickly train a model to test out tape-eval.
I've tried adding the following to the top of main.py
from metrics import *
from . import metrics

and this to the top of training.py:
from .metrics import *

since it seems the metrics were not getting registered, but I still got the same error message. Adding cls.metric_name_mapping to line 194 of tape/registry.py, and results in printing an empty dictionary.

Hi Brendan,
I'm not able to reproduce this error - I just tried exactly the commands you used and it seems to load properly. I'm not sure if you've made further modifications, but if so could you try ensuring that you're working with an unmodified version of master first?
I did get a separate error (as expected) since mae is not a sensible metric for secondary structure, but it did load the metric just fine.

Hey Roshan,
I still get this error if I do a fresh pip install tape-proteins and try the above. I think you're right though that I'm not working with an up-to-date master. In particular, it seems that the changes from https://github.com/songlab-cal/tape/commit/13dc981eb43d1b020056c4087dcf1c132e330427 aren't present in the pip-installed version. tape/__init.py__ is missing line 2 in the fresh pip install:
from . import metrics  # noqa: F401

Adding this line to my version solves the problem. I still get some other errors, though, and I think it's probably because of the other fixes in the above commit. I tried updating tape-proteins with pip, but this didn't make any changes. Is the package updated in pip?

Ah yes I must not have updated it in pip after the most recent fixes. If you clone master it should work. I will update pip in the next day or two.

Thanks!

Finally got around to fixing this in the latest release.


Fix Firebase authentication

Firebase auth lifecycle in Workflow Editor app has some issues.

What is the best way to check auth user in the new Firebase API?
How to set state on async login when it succeeds? Is there a promise then statement?

This has been fixed using state to re-render with/without login form based on auth check.


Fix(Bookmark): #649: Added jS code to polyfill str.includes

@clarkjefcoat
@wski
@akonsowski
Please review

:+1:

:+1:

:+1:


[SPARK-46957][CORE][FOLLOW-UP] Use Collections.emptyMap for Java compatibility

What changes were proposed in this pull request?

This PR replaces Map.of() with Collections.emptyMap().
Why are the changes needed?

To fix the Java compilation error for branch-3.5/3.4.
Does this PR introduce any user-facing change?

No.
How was this patch tested?

Covered by existing tests.
Was this patch authored or co-authored using generative AI tooling?

No.

This fix will be cherry-picked along with the backport PR https://github.com/apache/spark/pull/47122. This PR itself is for master only.

@yaooqinn @LuciferYang Could you take a look? Thanks!

@yaooqinn @LuciferYang  Thanks for taking care of the backport PR. What do you think about merging this PR to master for code consistency?

Merged to master, thank you @Ngone51


test pull

test comment

test comment2 w/ username

test comment 3 w/userName

test comment 4 formatted username

test comment 4 retry

test comment 5

test comment 6

test comment 7

test multiple lines
test multiple lines
test multiple lines
test multiple lines

Test
italicized
Two line

bullets
bullets

Test
italicized
Two line

[ ]  checkbox
@test

testlink
console.log()

three_tics

bullets
bullets

Test
italicized
Two line

[ ]  checkbox

@test
testlink
console.log()

three_tics

bullets
bullets

Test
italicized
Two line
checkbox
@test
testlink
console.log()
three_tics
bullets
bullets

Test
italicized
Two line
checkbox
@test
testlink
console.log()
three_tics
bullets
bullets

Test
italicized
Two line
checkbox
@test
testlink
console.log()
three_tics
bullets
bullets

test6

this is a github event

this is a github event

this is a github event

test

test payload 12

git hub event

github event

git hub event

test

test

test

test

git hub event

test github event

githubfwr

test

332576

test

github event

github event

test

from PR4

from pr 4

from pr 4

from pl4

from pl 4

from pr4

from pr 4

from pr 4

from pr 4

pr4-1 4:1

testpr4-2 4:39

testpr4-2 4:39

test pr4 -3 4:39

testpr4-3 4:39

test pr4-3 4:1

test url

test from pr 4

test from pr4


Navigation using StructureViewer and the Home button

Version: pre-0.0.1 (internal release)
Navigate (and pick active StoryItem) with Structure Viewer (sidebar) and the Home button

(note:  Left/Right buttons or keyboard-based navigation not working yet)


ci: fix names of artifacts uploaded by vpc egress agteway e2e test

Pull Request

[x] Make sure you have followed Kube-OVN Code Style.

What type of this PR
Examples of user facing changes:

Features
Bug fixes
Docs
Tests

Which issue(s) this PR fixes
Fixes #(issue-number)

Pull Request Test Coverage Report for Build<PHONE_NUMBER>3
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 18.675%

Totals

Change from base Build<PHONE_NUMBER>1:
0.0%

Covered Lines:
8682

Relevant Lines:
46490

💛  - Coveralls


Fixing base URL

Fixing the 404 issue of the breadcrumb navigation in R2.
/assign @efiacor @liamfallon
This supposed to fix the issue for the R2 branch pointed out by @efiacor in https://github.com/nephio-project/docs/pull/128#pullrequestreview-2101516416

I downloaded this PR to test it but when I ran hugo serve, the result was:
>  hugo serve

Hugo provides its own webserver which builds and serves the site.
While hugo server is high performance, it is a webserver with limited options.

...skipped lines....

Use "hugo server [command] --help" for more information about a command.

Error: command error: Unable to locate config file or config directory. Perhaps you need to create a new site.
Run `hugo help new` for details.

I downloaded this PR to test it but when I ran hugo serve, the result was:
>  hugo serve

Hugo provides its own webserver which builds and serves the site.
While hugo server is high performance, it is a webserver with limited options.

...skipped lines....

Use "hugo server [command] --help" for more information about a command.

Error: command error: Unable to locate config file or config directory. Perhaps you need to create a new site.
Run `hugo help new` for details.

Never mind, my mistake, I pulled the wrong PR.


Merge API integration changed to Main

Merge API integration changed to Main

Codecov Report

Merging #14 (249db57) into main (f8270e1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #14   +/-   ##
=======================================
  Coverage   68.02%   68.02%
=======================================
  Files          14       14
  Lines         269      269
=======================================
  Hits          183      183
  Misses         86       86

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8270e1...249db57. Read the comment docs.


[question] Derivation differences between Scala 2 and 3

I am currently porting our code base from Scala 2 to 3 and we are heavy users of Tapir.
A lot of semi-auto schema derivations broke after the update. From what I can gather, this affects classes, case classes and final case classing implementing AnyVal.
This scastie snippet does not work with Scala 3, but if you change it to Scala 2.13 (and the tapir dependency ofc.) it compiles:
https://scastie.scala-lang.org/BMdIdq6hSRaXrVDNbtjZfg
The code is simply:
import sttp.tapir.Schema

class MyCode(val code: Int) extends AnyVal
val s1: Schema[MyCode] = Schema.derived

The error:
No given instance of type scala.deriving.Mirror.Of[Playground.MyCode] was found for parameter m of method derived in trait SchemaMagnoliaDerivation. Failed to synthesize an instance of type scala.deriving.Mirror.Of[Playground.MyCode]:
	* class MyCode is not a generic product because it is not a case class
	* class MyCode is not a generic sum because it is not a sealed class

My question: Is this to be expected? Is there a way around providing manual schemas for all of these?

Ah, I guess #527 answers that - it's not implemented yet.

Ah ... we should get it implemented then :)

@cptwunderlich see https://github.com/softwaremill/magnolia/issues/552


Can't restrict zoom level to whole integers for zooming with trackpad

I want to restrict zooming with trackpad to whole integer numbers like it can be done with PinchZoom constrainResolution but such an options seems to be missing in MouseWheelZoom.

Pull request welcome.


Add test and ARM64 support for K_MEM_PERM_USER

Expand the mem_protect/mem_map test to also test the K_MEM_PERM_USER parameter and make ARM64 supporting that.

qemu_x86_tiny is failing on a different test from the one I just added. Re-triggering the CI just in case.


File uri containing percent encoded character doesn't seem to convert properly.

If the file uri has a percentage in it, it seems to not convert it properly.
Such as file:///c%3A/Users/Admin/Desktop/Github_Stuff/Discord_Bots/StratoBotElite/branches/master/src/bot/commands/Logging/user-join.js will return /c%3A/Users/Admin/Desktop/Github_Stuff/Discord_Bots/StratoBotElite/branches/master/src/bot/commands/Logging/user-join.js
while file:///c:/Users/Admin/Desktop/Github_Stuff/Discord_Bots/StratoBotElite/branches/master/src/bot/commands/Logging/user-join.js will return c:/Users/Admin/Desktop/Github_Stuff/Discord_Bots/StratoBotElite/branches/master/src/bot/commands/Logging/user-join.js

As of year 2021 this is what I'm seeing
URI :               file:///d%3A/MAO/repos/Petrel-XML-data/test.xml
converted to : d:\\d%3A\\MAO\\repos\\Petrel-XML-data\\test.xml
Is this extension still supported or should we "fork it"


the add-on is not working

@cupaaaa223 The repositories on this account to archive after CODE BLUE death.

https://github.com/lolteam4u/Blues-Bar
There is a fix there i cant push it to here if there is more broken parts now let me know and ill look into them


[#1554] feat(spark): Fetch dynamic client conf as early as possible

What changes were proposed in this pull request?
Fetches dynamic client config as early as possible, to be able to use dynamic client config to create the shuffle client with updated config.
Why are the changes needed?
Providing config or the shuffle client via coordinator is operationally useful as cluster-wide settings can be deployed through the cluster and changed over time. Clients and apps do not need to change configs.
Fixes Spark part of #1554
Does this PR introduce any user-facing change?
More configs can be provided via coordinators.
How was this patch tested?
Existing and follow-up unit tests.

And I think the PR title is not proper for this change, which don't reflect the feature of overwriting the existing client conf.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 53.78%. Comparing base (9f4ccde) to head (b687162).
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1557      +/-   ##
============================================
+ Coverage     53.63%   53.78%   +0.15%
+ Complexity     2822     2269     -553
============================================
  Files           436      358      -78
  Lines         24549    15920    -8629
  Branches       2080     1447     -633
============================================
- Hits          13167     8563    -4604
+ Misses        10562     6869    -3693
+ Partials        820      488     -332

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

... overwriting the existing client conf.

this is not new, this existed before

Could you help resolve the conflict? @EnricoMi

Fixed.


B859

[ ] The justification for this PR is:  Addresses #859 by using new collections implementation by @ljwolf

Note travis glitched on my initial commits and push to my origin - some of the tests passed but a couple failed due to what I think were travis related issues and not these commits.

Yeah, not sure what's up with that on travis. I was talking with @weikang9009 about the use of conda config --add channels conda-forge (in .travis.yml, borrowed from the geodatascience install instructions), and didn't realize that it prioritizes the forge over standard conda.
We might get more stable installs/tests if we only use the forge for the requirements_plus.txt install, since that's the stuff borrowed from the geodatasceince setup. I'll look into it if tests keep failing with weird conda errors.

Err, that diff should to to dev. Fixing the link.

Coverage decreased (-0.1%) to 82.414% when pulling b04bff65e7aea578cc32354c19f228eac66a0a60 on sjsrey:b859 into b18c2cff22abb00a4f69fedc66ed10b013b63bee on pysal:dev.

Merging as the failures are conda related not due to code changes in this pr.


Fail to attach accounts/services with SAS

Storage Explorer Version: 1.7.0_20190417.3
Platform/OS: Linux Ubuntu/macOS High Sierra/Windows 10
Architecture: ia32/x64
Regression From: Previous release 1.7.0
Steps to reproduce:

Right click one normal account -> Select 'Get Shared Access Signature...'
Set a specific expiry time and permissions on SAS dialog -> 'Create'.
Copy the generated SAS connection string -> Paste it to 'Attach with Connection String' dialog.
Check the result.

Expect Experience:

There is no error.
'Next' button is enabled.

Actual Experience:

Cause an error 'missing required parameter 'se' or 'si' in SAS token.

'Next' button is disabled.

More info:

This issue also reproduces when attaching services with SAS.
This issue doesn't reproduce when attaching resources with the set access policy.

Hi @craxal ,This issue has been fixed on latest master build 20190417.7. Could you help to resolve it?

Has this issue resurfaced?  Using exact same steps by  @v-xuanzh in build 20190510.6 is resulting in the same error "missing required parameter 'se' or 'si' in SAS token"


Better README.md

Create a better README.md, with screenshots, future, features etc. take a look at my project's readme: https://github.com/BenHerbst/idaesbasic and also add guidlines.

Is it better now?

Way better


More broken links

Deprecations

https://docs.codat.io/changelog/upcoming-2023-01-31-deprecation-of-uat-environment
https://docs.codat.io/changelog/upcoming-2023-04-10-changes-to-handling-of-deleted-data
https://docs.codat.io/changelog/44714-deprecation-string-request-create-connections-endpoint
https://docs.codat.io/changelog/upcoming-2023-04-10-deprecation-of-legacy-bank-account-endpoints
https://docs.codat.io/changelog/upcoming-2023-04-10-deprecation-of-api-key-management
https://docs.codat.io/changelog/upcoming-2023-01-10-quickbooks-online-purchases-will-no-longer-be-fetched-as-bills-and-bill-payments
https://docs.codat.io/changelog/42327-qbo-change-to-invoice-push-validation
https://docs.codat.io/changelog/42998-qbd-push-validation-accountref-itemref
https://docs.codat.io/changelog/upcoming-2023-01-10-freshbooks-expenses-no-longer-fetched-as-bills-and-bill-payments
https://docs.codat.io/changelog/41921-sage-50-deleted-payment-on-accounts-soft-deleted

Frequent broken links are linking to:
--
11:14:05.479 | - /datamodel-shared-date
11:14:05.479 | - /common-api#/schemas/DateTime
11:14:05.479 |
11:14:05.479 | Exhaustive list of all broken links found:
11:14:05.479 |
11:14:05.480 | - On source page path = /updates/221023-push-history:
11:14:05.480 | -> linking to /pull-and-push-history#push-history (resolved as: /pull-and-push-history)
11:14:05.480 |
11:14:05.480 | - On source page path = /assess/categories/api-categorization-of-accounts:
11:14:05.480 | -> linking to /datamodel-shared-date
11:14:05.480 |
11:14:05.480 | - On source page path = /assess/data-integrity/api-data-integrity:
11:14:05.480 | -> linking to /data-model/accounting/-bankaccounts
11:14:05.480 | -> linking to /data-model/accounting/-account-transactions
11:14:05.481 | -> linking to /data-model/banking-banking-accounts
11:14:05.481 | -> linking to /data-model/banking-banking-transactions
11:14:05.481 | -> linking to /datamodel-shared-date
11:14:05.481 | -> linking to /querying-1
11:14:05.481 | -> linking to /using-the-api/pagination
11:14:05.481 | -> linking to /assess-api-data-integrity#transactions-matches (resolved as: /assess-api-data-integrity)
11:14:05.481 | -> linking to /assess-api-data-integrity#accounts-matches (resolved as: /assess-api-data-integrity)
11:14:05.481 |
11:14:05.481 | - On source page path = /assess/metrics/accounting/api-financial-metrics:
11:14:05.482 | -> linking to /common-api#/schemas/DateTime (resolved as: /common-api)
11:14:05.482 |
11:14:05.482 | - On source page path = /assess/metrics/accounting/api-marketing-metrics:
11:14:05.482 | -> linking to /datamodel-shared-date
11:14:05.482 |
11:14:05.482 | - On source page path = /assess/metrics/commerce/api-customer-retention:
11:14:05.483 | -> linking to /datamodel-shared-date
11:14:05.483 |
11:14:05.483 | - On source page path = /assess/metrics/commerce/api-lifetime-value:
11:14:05.483 | -> linking to /datamodel-shared-date
11:14:05.483 |
11:14:05.483 | - On source page path = /assess/metrics/commerce/api-orders:
11:14:05.483 | -> linking to /datamodel-shared-date
11:14:05.483 |
11:14:05.483 | - On source page path = /assess/metrics/commerce/api-refunds:
11:14:05.483 | -> linking to /datamodel-shared-date
11:14:05.483 |
11:14:05.484 | - On source page path = /assess/metrics/commerce/api-revenue:
11:14:05.484 | -> linking to /datamodel-shared-date
11:14:05.484 |
11:14:05.484 | - On source page path = /assess/portal/overview:
11:14:05.484 | -> linking to /assess/portal/overview-categorization-of-accounts
11:14:05.484 | -> linking to /assess/portal/overview-categorization-of-accounts#how-to-categorize-accounts (resolved as: /assess/portal/overview-categorization-of-accounts)
11:14:05.485 | -> linking to /assess-accounting-metrics
11:14:05.485 | -> linking to /assess-enhanced-balance-sheet
11:14:05.485 | -> linking to /assess-api-financial-metrics
11:14:05.488 | -> linking to /assess-api-marketing-metrics
11:14:05.488 | -> linking to /assess-audit-report
11:14:05.488 |
11:14:05.488 | - On source page path = /assess/reports/banking/banking-account-balances:
11:14:05.488 | -> linking to /common-api#/schemas/DateTime (resolved as: /common-api)
11:14:05.488 |
11:14:05.488 | - On source page path = /assess/reports/banking/banking-account-inflows-and-outflows:
11:14:05.488 | -> linking to /common-api#/schemas/DateTime (resolved as: /common-api)
11:14:05.488 |
11:14:05.488 | - On source page path = /assess/reports/enhanced-cash-flow-report/transactions:
11:14:05.488 | -> linking to /common-api#/schemas/DateTime (resolved as: /common-api)
11:14:05.488 |
11:14:05.488 | - On source page path = /assess/reports/enhanced-financials/profit-and-loss:
11:14:05.488 | -> linking to /common-api#/schemas/DateTime (resolved as: /common-api)
11:14:05.488 |
11:14:05.488 | - On source page path = /assess/reports/excel-reports:
11:14:05.489 | -> linking to /common-api#/schemas/DateTime (resolved as: /common-api)
11:14:05.489 |
11:14:05.489 | - On source page path = /auth-flow/build/build-your-own-authorization-journey:
11:14:05.489 | -> linking to /using-the-api/managing-companies/managing-companies
11:14:05.489 |
11:14:05.489 | - On source page path = /auth-flow/optimize/privacy:
11:14:05.489 | -> linking to /auth-flow/build/build-your-own-authentication-journey
11:14:05.489 |
11:14:05.489 | - On source page path = /bank-feeds-api/qbo-bank-feeds/qbo-bank-feeds-push-bank-transactions:
11:14:05.489 | -> linking to /bank-feeds-api/qbo-bank-feeds/qbo-bank-feeds-smb-customer-steps
11:14:05.490 |
11:14:05.490 | - On source page path = /integrations/accounting/wave/accounting-wave:
11:14:05.490 | -> linking to /integrations/accounting/wave/wave-setup
11:14:05.490 |
11:14:05.490 | - On source page path = /integrations/commerce/mollie/commerce-mollie:
11:14:05.490 | -> linking to /integrations/commerce/mollie/commerce-mollie-integration-reference
11:14:05.490 |
11:14:05.490 | - On source page path = /integrations/commerce/mollie/commerce-mollie-retrieve-data:
11:14:05.490 | -> linking to /use-link-for-the-authentication-flow
11:14:05.490 |
11:14:05.490 | - On source page path = /integrations/commerce/stripe/commerce-stripe-setup:
11:14:05.490 | -> linking to /test-stripe
11:14:05.490 |
11:14:05.490 | - On source page path = /integrations/commerce/sumup/setup-sumup-in-uat:
11:14:05.490 | -> linking to /integrations/commerce/sumup/test-sumup
11:14:05.490 |
11:14:05.490 | - On source page path = /introduction/first-steps:
11:14:05.490 | -> linking to /core-concepts/account-signup
11:14:05.490 |
11:14:05.491 | - On source page path = /other/portal/companies:
11:14:05.491 | -> linking to /assess-overview
11:14:05.491 |
11:14:05.491 | - On source page path = /sfc/build-with-sync-for-commerce/customizing-the-sync-configuration-flow:
11:14:05.491 | -> linking to /sync-platform-selection
11:14:05.491 |
11:14:05.491 | - On source page path = /sfc/build-with-sync-for-commerce/functional-examples-of-data:
11:14:05.491 | -> linking to /integrations/accounting/xero/xero-mapping-specification
11:14:05.491 | -> linking to /qbo-mapping-specification
11:14:05.491 | -> linking to /sync-data-pushing
11:14:05.491 | -> linking to /functional-examples-of-data#example-1-an-order-representing-a-sale (resolved as: /functional-examples-of-data)
11:14:05.491 | -> linking to /functional-examples-of-data#example-2-a-payment-associated-with-the-order-from-example-1 (resolved as: /functional-examples-of-data)
11:14:05.491 | -> linking to /functional-examples-of-data#example-3-a-transaction-that-reconciles-the-order-from-example-1-and-the-payment-from-example-2 (resolved as: /functional-examples-of-data)
11:14:05.491 | -> linking to /integrations/accounting/xero/xero-mapping-specification#payment-fees (resolved as: /integrations/accounting/xero/xero-mapping-specification)
11:14:05.491 | -> linking to /functional-examples-of-data#example-4-a-transaction-that-reconciles-the-order-from-example-1-and-the-payment-of-commerce-provider-fees-associated-with-this-order (resolved as: /functional-examples-of-data)
11:14:05.491 |
11:14:05.491 | - On source page path = /sfc/build-with-sync-for-commerce/implementing-codats-no-code-merchant-configuration:
11:14:05.491 | -> linking to /synchronization-schedule
11:14:05.491 | -> linking to /mapping-specifications
11:14:05.491 | -> linking to /sync-data-pushing
11:14:05.491 |
11:14:05.491 | - On source page path = /sfc/build-with-sync-for-commerce/sync-data-pushing:
11:14:05.491 | -> linking to /functional-examples-of-data
11:14:05.491 | -> linking to /sync-your-own-merchant-journey#how-to-trigger-manual-syncs-for-testing (resolved as: /sync-your-own-merchant-journey)
11:14:05.491 |
11:14:05.491 | - On source page path = /sfc/sync-merchant-configuration/overview:
11:14:05.491 | -> linking to /sync-your-own-merchant-journey
11:14:05.491 |
11:14:05.491 | - On source page path = /sfc/sync-merchant-configuration/sync-your-own-merchant-journey:
11:14:05.491 | -> linking to /sync-your-own-merchant-journey#creating-a-company-and-establishing-a-data-connection (resolved as: /sync-your-own-merchant-journey)
11:14:05.492 | -> linking to /sync-your-own-merchant-journey#data-mapping-configuration (resolved as: /sync-your-own-merchant-journey)
11:14:05.492 | -> linking to /sync-your-own-merchant-journey#ongoing-configuration (resolved as: /sync-your-own-merchant-journey)
11:14:05.492 | -> linking to /sync-your-own-merchant-journey#disabling-a-data-connection (resolved as: /sync-your-own-merchant-journey)
11:14:05.492 | -> linking to /sync-platform-selection
11:14:05.492 | -> linking to /synchronization-schedule
11:14:05.492 | -> linking to /sync-data-model
11:14:05.492 |
11:14:05.492 | - On source page path = /sync-for-expenses/gettingstarted:
11:14:05.492 | -> linking to /use-link-for-the-authentication-flow
11:14:05.492 | -> linking to /auth-flow/build/build-your-own-authentication-journey
11:14:05.492 |
11:14:05.492 | - On source page path = /sync-for-expenses/sync-process/uploading-receipts:
11:14:05.492 | -> linking to /using-postman-to-call-the-api

@mcclowes - All of the broken links in Deprecations are still there. I forgot about those.

I will pick up the broken links in the "Updates" section.


Updates for wordpress

Thanks @tomwpaterson-shape You may want to merge main into this branch. I think most of the SVGs you're adding here duplicate SVGs I've added in PRs already merged into main. I wasn't aware of the numbering system, so the ones I put in are called things like triangles-combined-children.svg rather than biggive-double-triangle-brand-5.svg. It would be good to avoid having both, if they're used for the same thing.
I've also added some comments inline. I don't think I know this code well enough to fully review the PR, so I'd wait for Ali or Noel to do a proper review.

triangles-combined-children.svg rather than biggive-double-triangle-brand-5.svg

These are not exact duplicates btw - the heights and widths are different in these two files. I based the ones I created on your triangles-combined.svg file.

@tomwpaterson-shape Thanks for taking my suggestions on components.d.ts - but since I wrote that I learned that that file is auto generated and overwritten every time we run npm run build. The real source code that the comment about docblocks relate to is in biggive-icon-button.tsx

Superseded by other updates, as discussed on Slack


plugin: Move plugins to second party org

@yashlamba is leading this effort

Closed in favor of #1113


popovers: Add topic auto-complete to "Move topic" menu

Issue #19876
We add topic auto-complete to the left sidebar menu as sometimes user
may want to merge the topic they are moving with an existing topic.
https://user-images.githubusercontent.com/75037620/155842853-43446899-00a8-4ded-a57f-3ed456a0a221.mp4

This looks great aside from the implementation comments posted above; let me know when you've resolved those. Thanks @anurastogiji!

@timabbott, I have made the changes you suggested. Can you have a look at it?
Thank you!

@anurastogiji can you resolve the merge conflict? We now have a different on_update handler, so I think we need some slightly nontrivial work to call both.

@anurastogiji can you resolve the merge conflict? We now have a different on_update handler, so I think we need some slightly nontrivial work to call both.

Yes @timabbott I will resolve the merge conflict today only, I wasn't able to solve this till now because of exams.

@timabbott the merge conflict has been resolved, so this may be ready to integrate.

Merged, after cleaning up some legacy comments. Thanks for doing this @anurastogiji!
@alya one small note -- the way the topic options appear is a dropup in the inline message edit UI, and a dropdown here; it seems fine, but that inconsistency is explicit in the code, and I figured I'd flag it as something we could consider making consistent.
(Probably dropup in both places would be the version that sense the most sense).

Hm, I'd just make it a dropdown everywhere, to be consistent with the stream dropdown, as well as compose box behavior. Should I file an issue?


Add non existence proof

Currently, we have only existence proofs, as they are they simplest and quite agnostic or the underlying structure.
A non existence proof, to validate a given key is not in the tree, is also useful in many cases. This can be constructed as the simplest form of a range proof.... Two existence proofs (one for a key lower and one for a key higher than queried), and then a way to prove these two keys are neighbors in the original tree.
Checking the "neighbors" is achievable with good knowledge of the tree structure. But we also want a generic way to validate this. Not only for binary trees, but also for tries.
This should extend the spec format from #3 to define what a valid adjacency proof needs.

How to define if two ExistenceProofs are neighbors... it depends on the Path ([]*InnerOp). Note that the Path is defined to start with the leaf and go to the root.  Here is a basic algorithm to see if two proofs (called Left and Right) are neighbors.

Find the common suffix from the Left.Path and Right.Path and remove it. We have LPath and RPath now, which must be neighbors.
Validate that LPath[len-1] is the left neighbor of RPath[len-1]
For step in LPath[0..len-1], validate step is right-most node
For step in RPath[0..len-1], validate step is left-most node

Exceptions:

If Right.Path is nil, check that Left.Path is right-most for every step
If Left.Path is nil, check that Right.Path is left-most for every step

This leaves us with three checks we need to be able to configure in ProofSpec:

isLeftNeighbor: given InnerOp A and B with a common parent, check if A is left of B and there is no path between them.
isLeftMostPath: given InnerOp A, check if the unset value (child) is in the left most, non-nil position.
isRighttMostPath: given InnerOp A, check if the unset value (child) is in the right most, non-nil position.

This information can be extracted from Prefix and Suffix if we know the hash size (of the children), the ordering, and how missing subtrees are represented (0 bytes, 1 fixed byte, 32 bytes all 0, etc). Eg. iavl uses prefix || left || right. merk uses prefix || left || right || here. Such that left < here < right when determining neighbors and leftMost/rightMost.


Consider splitting logs to separate files

After a while, I decided that it wont be necessary at all. The app is too small for that and it will add unnecessary complexity to debugging. The main reason of this issue was difficulties with reading logs but it was refactored and it seems ok now.


NPE in Fate command

Running the fate command in the shell fate print with only one sub command will give:

2022-05-26T09:32:06,812 [shell.Shell] DEBUG: java.lang.NullPointerException
java.lang.NullPointerException: null
	at org.apache.accumulo.shell.commands.FateCommand.printTx(FateCommand.java:223) ~[accumulo-shell-2.1.0-SNAPSHOT.jar:2.1.0-SNAPSHOT]
	at org.apache.accumulo.shell.commands.FateCommand.execute(FateCommand.java:178) ~[accumulo-shell-2.1.0-SNAPSHOT.jar:2.1.0-SNAPSHOT]
	at org.apache.accumulo.shell.Shell.execCommand(Shell.java:774) ~[accumulo-shell-2.1.0-SNAPSHOT.jar:2.1.0-SNAPSHOT]
	at org.apache.accumulo.shell.Shell.start(Shell.java:593) ~[accumulo-shell-2.1.0-SNAPSHOT.jar:2.1.0-SNAPSHOT]
	at org.apache.accumulo.shell.Shell.execute(Shell.java:524) ~[accumulo-shell-2.1.0-SNAPSHOT.jar:2.1.0-SNAPSHOT]
	at org.apache.accumulo.start.Main.lambda$execKeyword$0(Main.java:126) ~[accumulo-start-2.1.0-SNAPSHOT.jar:2.1.0-SNAPSHOT]
	at java.lang.Thread.run(Thread.java:829) ~[?:?]

It works if you put anything as the 3rd argument: fate -print 1234

I believe in PR #2215, I did fix this. I did not realize it was something
that happened against main though.
On Thu, May 26, 2022 at 9:38 AM Mike Miller @.***>
wrote:

Running the fate command in the shell fate print with only one sub
command will give:
2022-05-26T09:32:06,812 [shell.Shell] DEBUG: java.lang.NullPointerException
java.lang.NullPointerException: null
at org.apache.accumulo.shell.commands.FateCommand.printTx(FateCommand.java:223) ~[accumulo-shell-2.1.0-SNAPSHOT.jar:2.1.0-SNAPSHOT]
at org.apache.accumulo.shell.commands.FateCommand.execute(FateCommand.java:178) ~[accumulo-shell-2.1.0-SNAPSHOT.jar:2.1.0-SNAPSHOT]
at org.apache.accumulo.shell.Shell.execCommand(Shell.java:774) ~[accumulo-shell-2.1.0-SNAPSHOT.jar:2.1.0-SNAPSHOT]
at org.apache.accumulo.shell.Shell.start(Shell.java:593) ~[accumulo-shell-2.1.0-SNAPSHOT.jar:2.1.0-SNAPSHOT]
at org.apache.accumulo.shell.Shell.execute(Shell.java:524) ~[accumulo-shell-2.1.0-SNAPSHOT.jar:2.1.0-SNAPSHOT]
at org.apache.accumulo.start.Main.lambda$execKeyword$0(Main.java:126) ~[accumulo-start-2.1.0-SNAPSHOT.jar:2.1.0-SNAPSHOT]
at java.lang.Thread.run(Thread.java:829) ~[?:?]
It works if you put anything as the 3rd argument: fate -print 1234
—
Reply to this email directly, view it on GitHub
https://github.com/apache/accumulo/issues/2736, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHASSV5356RKS54ZBBN4UKLVL55FLANCNFSM5XBG3ULA
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


Triggering prod CLI release for 0.19.9

Description of changes:
Triggering prod CLI release for 0.19.9
/hold
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/lgtm

/unhold
/approve


What's the 2.0 strategy for including styles seen in engines?

The changes with Tailwind 3 mean that its server needs to know where all styles are to be found. How do we communicate that dynamically in the case of engine code?
Engine gems may be installed in multiple places, and in Ruby we can identify the filesystem location with MyEngine.root. In the prior release all we needed to do was not have them be purged which could be accomplished like this in production.rb:
  config.assets.css_compressor = Tailwindcss::Compressor.new(files_with_class_names:
    Rails.root.glob("app/views/**/*.*") +
    MyEngine::Engine.root.glob("app/views/**/*.*")
  )

Is there a supported strategy to communicate that in the tailwind.config.js file, which doesn't speak Ruby?
Or do we just need to generate that file with all locations added?

I'm building a component library built with Tailwind at the moment and have run into this.
Initially I tried inserting something like MyEngine::Engine.root.join("app/components/**/*.*") into tailwind.config.js as part of an install task. Given the engine root will differ between environments I'm not sure how well this approach could work in practice, though.
How about if your engine builds an engine.css file and you add that as a separate stylesheet_link_tag in the application? I haven't tried this approach yet, but I think it might work reasonably well for now. One problem with this approach is the duplication of styles, but I'm not sure how to avoid that right now.

I'm doing something similar with a rake task. I'm ignoring the config/tailwind.config.js file and generating it on relevant tasks with this (app is named "rice"):
namespace :rice do
  namespace :tailwind do
    desc "Generate a component-aware config/tailwind.config.js file"
    task :generate do
      components = [
        Foo::Engine,
        Bar::Engine,
      ]
      paths = components.map do |c|
        [
          "'#{c.root}/app/views/**/*'",
          "'#{c.root}/app/assets/javascripts/**/*'",
        ]
      end.flatten

      File.open(File.join(Rails.root, "config", "tailwind.config.js"), "w") do |f|
        f.write <<-JS
        const defaultTheme = require('tailwindcss/defaultTheme')

        module.exports = {
          content: [
            './app/helpers/**/*.rb',
            './app/javascript/**/*.js',
            #{paths.join(",\n            ")},
          ],
          theme: {
            extend: {
              fontFamily: {
                sans: ['Inter var', ...defaultTheme.fontFamily.sans],
              },
            },
          },
          plugins: [
            require('@tailwindcss/forms'),
            require('@tailwindcss/aspect-ratio'),
            require('@tailwindcss/typography'),
          ]
        }
        JS
      end
    end
  end
end

Rake::Task["tailwindcss:build"].enhance(["rice:tailwind:generate"])
Rake::Task["tailwindcss:watch"].enhance(["rice:tailwind:generate"])

So far so good, but we're in heavy development mode and don't have it in production yet.

I've come across this need as well. I found a Stackoverflow answer that used Bundler for providing the path. An example:
const execSync = require('child_process').execSync;
const gemPath = execSync('bundle show gem-name', { encoding: 'utf-8' });
module.exports = {
  content: [
    gemPath.trim() + '/app/assets/stylesheets/**/*.css',
    gemPath.trim() + '/app/views/**/*.{erb,haml,html,rb}',
    # ...
  ]
}

Would either of you have happened to ship CSS in that Rails Engine that was written with Tailwind CSS and meant to be included and precompiled with the Rails app that is using the engine? Is there a way to get Postcss imports to work with Rails Engine based stylesheets? I figure it's a similar path problem to this. Only way I've found around that is having to build an NPM package of stylesheets for the app to reference as part of its TailwindCSS build.

Hello!

Would either of you have happened to ship CSS in a Rails Engine that was written with Tailwind CSS but meant to be included and precompiled with the Rails app that is using the engine?

@javierjulio I'm facing a similar problem right now. In Avo we're building our own style-sheet and we add it with a stylesheet_link_tag. The host app can have it's own separate style-sheets and also import them with the stylesheet_link_tag through a hook into our application.html.erb. The problem here is that sometimes there are conflicts between stylesheets even on simple and equal styles.
I'm trying to figure out ways to compile both, the Avo's and host app styles and include them with only one stylesheet_link_tag. I've been trying several approaches one of them is this one with the Bundler:
const execSync = require('child_process').execSync;
const gemPath = execSync('bundle show gem-name', { encoding: 'utf-8' });
module.exports = {
  content: [
    gemPath.trim() + '/app/assets/stylesheets/**/*.css',
    gemPath.trim() + '/app/views/**/*.{erb,haml,html,rb}',
    // ...
  ]
}

Unfortunately I'm facing some issues with it since Avo's module.exports become complex and I need to include more than just the content (plugins etc...).
Did you solved it? Is there a documented way to build both, gem's and host's app tailwind together?! Or is there another better path to follow? We're open to suggestions.

I'm not sure if you can precompile Avo's styles in your app because they are already compiled and shipped with the gem itself so all your app is doing is loading a plain CSS file (no Tailwind compilation performed), if I understand right.

You understand that right @javierjulio. Actually I'm working on improving that process on Avo itself and allow the Tailwind compilation to perform on the host app. I implemented a POC following the Stackoverflow answer that used Bundler for providing the path but I wonder if there is another straight forward way of doing this integration between the gem and the app.

@Paul-Bob not that I know of, sorry. That's why I commented here to share what I found and see what others are doing or would suggest/comment with. If you do find another approach, please let us know. I'd like to know what other approach can be taken. It just doesn't seem that the new asset gems (e.g. jsbundling-rails) account for this when it comes to engines.

Let's consolidate this conversation into one place: https://github.com/rails/tailwindcss-rails/discussions/355


Android : app has to be restarted to notice the change of system language

I have to restart the android app to notice the system language change. On ios the app will be automatically rebuild.
Any ideas to solve this?

@nibo - Yes basically the system locale is only retrieved/used during the application initialization.
Changes to the system locale while the application is running are not currently detected on Android.
On iOS, as you mentioned, the app is rebuilt so the new locale is picked up during initialization.
I`m going to implement this behavior for Android as well, in the near future.
Until then, you could use the ACTION_LOCALE_CHANGED intent to detect the locale change and select the new locale if supported.

Moved to https://github.com/bratan/flutter_translate/issues/21


Ability to run Node for tests in the directory of the script

I'm trying to do something similar to scalajs-bundler in https://github.com/nafg/mill-bundler. One issue I'm hitting is that it needs to generate a package.json and npm install somewhere under out/, but IIUC because it's running Node from the base directory it won't see node_modules/.
This is even worse for JsDom, because with JsEnvConfig.NodeJs I can override fastLinkJSTest to inject a bundling step, producing a script that doesn't need node_modules anymore. But IIRC JsDom will require("jsdom") outside the script.

On second thought...
I edited the title, because maybe the solution is not to have a new setting or parameter to pass in the working directory. Maybe it should automatically use the script's location as the working directory.
Although, I guess most people currently maintain a package.json by hand in the root directory and manually npm install. So I guess for them tests should run in the base directory. So maybe it does have to be a setting or parameter?

Typically in Mill, test run in a forked process and support the setting of forkWorkingDir. Unfortunately, ScalaJSModule currently does not support this setting.

https://github.com/com-lihaoyi/mill/issues/1036

Duplicate of #1036


BUG: Logo not consistent through out the website

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
The logo upon the background cover needs to be align with all container items
https://github.com/Anushkabh/krishiconnect/assets/99901964/b54231aa-daf4-4104-9bda-33683a646961
Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

I would like to work on this . Please could you assign me this issue under GSSOC'24

@Anushkabh can you look into this issue, and assign me with GSSoC'24 labels

@Anushkabh I Fixed the issue and raised the PR. it also alignes with #119 So you can merge this PR's without having merge conflicts. Let me know if i need to make any changes

@Madhu-mac next time raise pr only for issues that are assigned to you

@Madhu-mac next time raise pr only for issues that are assigned to you

Actually in #173  , I've raised the issue and also said that im working on it if its assaigned, but you merged smone else PR without assaining to that person..


Website

Hey ur Website is offline i cant join the Support Discord can u send me The Link ?

Hello. We ran into some difficulties. You can try again!

Nop
https://discord.com/invite/FqdH4sfKBg


Add missing useRouteError import in loader docs

Closes: #

[ ] Docs
[ ] Tests

Testing Strategy:

Thank you for the update - would you mind signing the CLA so we can merge this?

@brophdawg11 Done! Sorry, I wanted to adjust the description etc. and then mark as ready to review, but feel free to merge it.


Counties have data, but show on map as having no data.

summary
some counties appear grey on the map, but actually have analyses.
expected result
color of a county on the map matches the status of the county on the county-specific page
actual result
sometimes there's a full projection/analysis for that county already
environment
web
link
https://covidactnow.org/us/wa/county/skamania_county
screenshot

cc @ghop02 this is due to the summary file not including the county fips code for a county that does have data

Hmm I wonder if this is because we're generating the county/state files separately for the pyseir data.  Once the whole pipeline is in action I'd think this would get resolved? (but i haven't looked at it specifically)

the map uses:

FWIW- Doesn't seem to be resolved. :-/


Unreachable code in AnimatedIcon

Describe the bug
While porting the AnimatedIcon source code, I noticed that the UpdateMirrorTransform() call cannot be reached by any possible path:
https://github.com/microsoft/microsoft-ui-xaml/blob/ba55e86fab216886a10b0b248c931e11a4e0a64f/dev/AnimatedIcon/AnimatedIcon.cpp#L543-L554
Should it be moved above or removed?
Steps to reproduce the bug
See code
Expected behavior
Should be reachable.
Screenshots
N/A
Version Info
main

Looks like dead code to me, a bit surprised the compiler wouldn't mention it. If you are porting it to Uno Platform, did the C# compiler mention this?

@chingucoding yes, I noticed it thanks to IntelliSense underlining it 😀

Wow, our tests missed this too because they only test changing the flow direction, not the initial value... Thank!!

If you want to contribute a fix that'd be awesome! otherwise I'll get to it soon.

@StephenLPeters happy to do it! Just remove the call?


dataSource.filter to accept objects or arrays other than string

Bug, feature request, or proposal:
proposal
What is the expected behavior?
dataSource.filter should accept any object so that filterPredicate function is more flexable. for example one should be able to pass an array then use it on filterPredicate to filter multiple columns.
What is the current behavior?
currently dataSource filter support only String. so we have to contacate and split on predicateFunction

@Abenezer I think you can create your own DataSource and make the filter supports objects/arrays.
@andrewseguin Is this something we plan to do?

your right you can extened the DataSource but you have to overide perdicateFunction also as it's filter parameter is typed 'String' . but it would be realy nice if it support object/arrays in the first place.

One thing I've done is pass in a string and convert it to a JavaScript Object. Kind of hacky, but saves you the time of extending DataSource

Do you know if there's any updates on this one? Have a good day you all!

Our intention with the MatTableDataSource is to help start the basic use cases and not get too much functionality. We encourage users to develop their own DataSource that matches their needs, using the MatTableDataSource as an inspiration. This would give clients full control over what they need from the data source without adding opinions to the basic MatTableDataSource which might not fit others needs


Allow anonymous queue declaration

In some cases, it could be useful to use anonymous queues, for instance when we are connecting to a fanout exchange.
Documentation states that :

The queue name MAY be empty, in which case the server MUST create a new queue with a unique generated name and return this to the client in the Declare-Ok method.

An example is available in RabbitMQ Tutoral 3 (link to receive_logs.php).
Note that currently setting queue name in config.yml to an empty string or null will throw an exception.
I'm not sure if this makes sense in a producer point of view.

v2.4.0


React Hooks helpers

Based on current React RFC https://github.com/reactjs/rfcs/pull/68

I am actually pretty eager of what this bring to the table in the state management story.
Again, I very much like the hx approach.

I'm going to work on updating the examples to use hooks instead of (or at least along side) react classes. I did an initial POC of some hooks helpers in this repo: https://github.com/Lokeh/hooks-demo
I'm not super familiar with rum's cursor implementation but sure, go ahead. IMHO atomic cursors should be their own library; but implementing it in hx might be the only tenable to do it performantly (a la reagent)... yes create an issue :P

Great. Thank you very much!

And yes hooks-demo was the place I have seen it. Thanks!

I am looking at the examples now, and it seems to me, that hx actually has all I need. I just did not grasp it fully at first.
I will try to update hxor ASAP to see if I get it right.


Refresh the app list on app start

The app almost works on TV. The only issue is that there is no swipe down to refresh on TV, I tried on an emulator so i can swipe down to refresh and once the app list is there it is usable to download and update apps without an other changes.
Given that there are a couple of apps that have a TV UI, that will be very helpful for users of those.

When did you last try this? Accrescent should refresh on app start since https://github.com/accrescent/accrescent/commit/12e252c4d1c806d557ebddd02eb8a4913ac01c07.

ok, it was v1.15.1 and it was not working.
I tried with 1.15.2 and it is working now.

Great!


Document in YAML whether discoverable loaders append or upsert (or both)

Migrated from GitLab: https://gitlab.com/meltano/hub/-/issues/33
Originally created by @DouweM on 2021-01-12 22:22:54

So that users will know whether https://gitlab.com/meltano/meltano/-/issues/2504 applies.
We'll have to think about how to represent this in the YAML. Could be under capabilities or another generic key. Would prefer not to diverge tap/target specs.

View 11 previous comments from the original issue on GitLab


Make the [With] attribute work for inherited members

Is your feature request related to a problem? Please describe.
I'd like to use this library to generate With methods for a class that inherits from a base class, however, I only get With methods generated for the members of the class I apply the attribute on.
This of course wouldn't be a problem if I owned the base class, but that is not the case as the base class comes from an external library.
Describe the solution you'd like
Optionally allow to generate With methods on inherited members.
I image it could be a property on the WithAttribute, something like:
[With(IncludeInheritedMembers = true)]
public class MyClass : ExternalBaseClass
{
    // ...
}

Describe alternatives you've considered
An alternative solution would be to apply the WithAttribute to the base class, but as mentioned before, that's not possible in my case.

I like the solution with the IncludeInheritedMembers option! If this is urgent, you could look into opening a PR, I will probably only get to it sometime this month.

I already solved the problem by implementing my own source generator for it but I'll try to find time to open a PR here as well.

@michaldivis I have started working on this now.

Available in v2.4.0

@CollinAlpert Thanks a lot!


Unit tests, Travis CI and Coveralls integration

Added tests for all public methods of RKNotificationHub using Specta/Expecta, FBSnapshots and Expecta+Snapshots during CocoaPods Test Jam.
Currently Travis CI and Coveralls integration uses my GitHub account. Feel free to turn them on yourself as I don't have admin rights on the original repo. See https://travis-ci.org and https://coveralls.io.
Current coverage is 88%. Note that - (CGRect)nextRectWithDiameter:(float)diameter method is not covered since it's not used anywhere (please review this). Demo ViewController class is also not covered and it's included in stats since it's located in the same folder as RKNotificationHub.m.

hey i'm really sorry about not responding, I turned off notifications for this by accident. checking out the code now

removed nextRectWithDiameter, nice catch

I'm a little confused as to what this PR achieves.  Would you mind explaining a little?

The PR doesn't change any existing behaviour of the library. But it does cover almost all the code with unit tests, thus facilitating possible further changes, refactoring efforts and in a certain way documenting current behaviour using specs. I was using Specta/Expecta for test cases and FBSnapshotTestCase for snapshot testing (here's a good source on testing techniques in iOS: http://www.objc.io/issue-15/). I've added tests to the test target of the demo project (RKNotificationHub.xcodeproj). Please note that you need to perform "pod install" and then open generated RKNotificationHub.xcworkspace to be able to run the tests (⌘+u in Xcode).
Moreover, the PR enables automated builds of the test target on Travis CI on every change pushed to the repository. In addition, generated test coverage stats are sent from Travis CI to the Coveralls service making it possible to track changes in code coverage stats.
Please let me know if you would need any further details on the PR.

Ok so I'm new to this kind of thing, but from my experience, testing is only really needed when you're working on an expansive project that has many moving parts.  I've heard of specta, but why would one need a testing framework for a pretty basic UI-based repository? I'm unfamiliar with Travis, but again, I'm struggling to see why it would be necessary for something like this.
What benefit does this have for the end user? (the developer using the pod).  It would make it a little less readable in my opinion.

Ok so I'm unfamiliar with this kind of thing, but from my experience, testing is only really needed when you're working on an expansive project that has many moving parts. I've heard of specta, but why would one need a testing framework for a pretty basic UI-based repository?

I would agree that unit tests are probably much more valuable when you are dealing with a big library with thousands and thousands lines of a code especially when the code was contributed by different people. But actually any library that have any kind of behaviour can benefit from being covered with tests. Even those libraries that are more UI-oriented; their views can be tested using snapshot testing techniques.

I'm unfamiliar with Travis, but again, I'm struggling to see why it would be necessary for something like this (also I don't think I understand what it does. The website isn't very clear).

It's a great automated tool that performs builds and runs all tests for the repo thus checking the status of the build on every change that was pushed to the repo. If someone sends a PR, you will be able to see if those changes break the build or make any test fail (or even if it changes the test coverage stats in case you also have Coveralls integrated).

What benefit does this have for the end user? (the developer using the pod). Or is it mostly just for me for when I further development of the pod?

Unit testing facilitates further changes (improvements or refactoring of the existing features, new features) by providing a simple way to check if everything still behaves as expected. This is especially helpful for other contributors that might not know all the implicit intricacies of the library implementation and preventing them from changing behaviours that they haven't intended to change.
Also, BDD-styled specs serve as a kind of a documentation and library usage samples. It also provides a clear context of a failing scenario if any test fails.
One more benefit for the end user (developer) is that test coverage gives more confidence about the reliability of the code and thus making it safer to use it in production. Code coverage stats from the Coveralls banner in the Readme file even gives a numeric proof of that :)

This CocoaPods blog post includes a list of pull requests that were made during the Test Jam for other popular pods besides RKNotificationHub: http://blog.cocoapods.org/Jamming-2015/. Note that many of them are also UI-based.

Thanks for the clear response, one last question: for the snapshot technique, this would have to be changed if I ever change the default aesthetic, correct?

Yes, in this case you need to update the snapshots to test against. This is really simple, just replace the calls to haveValidSnapshot() / haveValidSnapshotNamed(...) with recordSnapshot() / recordSnapshotNamed(...) in corresponding test cases, then run the tests to update snapshot files. Return back to haveValidSnapshot() / haveValidSnapshotNamed (...) once you're done. There's also a handy Xcode plugin available for quick browsing through all failed snapshot tests and override old snapshots with updated versions with a single tap: https://github.com/orta/snapshots.

sounds good.  Last last question (sorry haha). So you said I have to run pod install, does this mean everyone is required to have more dependencies when using this repo or is it just for the test / demo project.  Also looks like I should set up travis and coverall accounts huh

Installing RKNotificationHub via using cocoa pods doesn't require more dependencies. But this was a good point anyway: simply checking out the repo and running the demo project required it. I've updated the PR and disabled test target when building for running, so this is no longer the case. The user would need to pod install for the demo project only for running tests while the main target doesn't have any extra dependencies.
As for Travis and Coveralls, the setup is pretty basic. Go to https://travis-ci.org and https://coveralls.io, login using your GitHub account (it's free for open source projects) on both and enable RKNotificationHub repo for both. After any change pushed to the repo (for example, merging PR would do), GitHub would automatically trigger a build script on Travis, which in turn will send code coverage info to Coveralls. The last thing would be to update Travis and Coveralls banner links in the Readme file once you are ready with the integration. Let me know if you have any trouble with those services :)

thanks, this has been really informative. Merging!

I'm getting this error:
diff: /../Podfile.lock: No such file or directory
diff: /Manifest.lock: No such file or directory
error: The sandbox is not in sync with the Podfile.lock. Run 'pod install' or update your CocoaPods installation.

I reverted this for now until the error is figured out.  That's my bad for not checking out the branch first.  I think it should definitely be a requirement that someone can without cocoapods setup should be able to open and run the project.

Sorry you had to revert this. Actually those errors are related to the test target only and I'm able to run the main target without any extra work (please try this on your side and confirm). But, I would agree that it's not clear for the developer that those errors can be ignored as long as they don't use test target.
I would suggest 2 ways of resolving this:

Remove Pods and *.xcworkspace from .gitignore and push pods sources to the repo, so there's no need to have an environment with cocoa pods installed; all dependencies would be packaged right within the repo (here's a helpful note on this approach vs. keeping it in .gitignore: https://guides.cocoapods.org/using/using-cocoapods.html#should-i-check-the-pods-directory-into-source-control).
Create a separate Xcode project inside the repo solely for testing. This project would require "pod install", but the original demo project would remain as it was.
Let's decide what option to use and I will amend my PR.


Sendgrid account creation through Azure ARM template or azure portal throws ResourcePurchaseValidationFailed error

I am facing issue while trying to create a sendgrid account either through portal or by ARM template deployment. Below is the issue. If someone has any knowledge about this please let me know.
Summary
{"code":"DeploymentFailed","message":"At least one resource deployment operation failed. Please list deployment operations for details. Please see https://aka.ms/arm-debug for usage details.","details":[{"code":"BadRequest","message":"{\r\n "error": {\r\n "code": "ResourcePurchaseValidationFailed",\r\n "message": "User failed validation to purchase resources. Error message: 'Offer with PublisherId: Sendgrid, OfferId: sendgrid_azure cannot be purchased due to validation errors. See details for more information.'"\r\n }\r\n}"}]}
Raw Error
{
"code": "DeploymentFailed",
"message": "At least one resource deployment operation failed. Please list deployment operations for details. Please see https://aka.ms/arm-debug for usage details.",
"details": [
{
"code": "BadRequest",
"message": "{\r\n  "error": {\r\n    "code": "ResourcePurchaseValidationFailed",\r\n    "message": "User failed validation to purchase resources. Error message: 'Offer with PublisherId: Sendgrid, OfferId: sendgrid_azure cannot be purchased due to validation errors. See details for more information.'"\r\n  }\r\n}"
}
]
}

Hello @satyajitmahapatra,
We're sorry you're having this issue! Since this is not a docs-related issue, please contact our Support team directly and they can help you out. You can access support contact options by logging into https://support.sendgrid.com.
SendGrid Docs Team

Hello @satyajitmahapatra,
I am getting the same error, what was the resolution?

+1 ...

I am curious how we can log a support case given we are not being able to create an account / login to that. Underwhelming experience.


Refactor backfill for unit testing

An 'id' and '_id' attribute are set on the resume marker object. This is to match pre-refactor behavior.
If an exchange uses time as opposed to trade_id in its API queries for trades, the tradeService will get the correct trade from the DB, and pass in its time. #1267

I was working around this in bittrex it uses a combo of numeric and time depending on where it is getting its backfill data.   I was converting it to numeric only (converting both sources to use ms from 1970)  is this still needed?

field selector is missing in the trade dataset after backfill refactor.
this field was present in the prior version.


[T5A1][T10-B1] Lee Jing He

@he1994 Some comments added. Please close the PR after reading comments.


NodeKey with zeros (like \x00) is not processed correctly.

Background
I have got a NodeKey with stub.ListPeers:
031f04c86df5ac2b2c10b75fe54c9d007c119e1fbe4e8e3d244d91f76dd044a458
as you cann see there is a 00 after 9d.
When I try to open a channel to such node, in the log file I see:
[DBG] RPCS: [openchannel] request to NodeKey(031f04c86df5ac2b2c10b75fe54c9d) allocation(us=10000000, them=0)
[ERR] RPCS: [/lnrpc.Lightning/OpenChannel]: invalid pub key length 15
But when I cnage 00 to any other number the server is parsed it correctly. Of course it cannot to complere request but it parses the NodeKey correctly:
[DBG] RPCS: [openchannel] request to NodeKey(031f04c86df5ac2b2c10b75fe54c9d017c119e1fbe4e8e3d244d91f76dd044a458) allocation(us=10000000, them=0)
Your environment

version of lnd: v0.10.3-beta.rc1
which operating system Windows 10
version of btcd, bitcoind: bitcoind: 0.20
any other relevant environment details

Steps to reproduce
You can take any other address, for example:
02d1a817e4ef53b55c27f2314d034b03fb5914f0b6874fab3e5d6799bde477210b
then replace 03 to 00. The error is happens. Only half of the address is recognized.
And you will get:
[ERR] RPCS: [/lnrpc.Lightning/OpenChannel]: invalid pub key length 15
Expected behaviour
Such bad key:
031f04c86df5ac2b2c10b75fe54c9d007c119e1fbe4e8e3d244d91f76dd044a458
was generated for me by the node.
And it should work, I think :)
Actual behaviour
[ERR] RPCS: [/lnrpc.Lightning/OpenChannel]: invalid pub key length 15

And also, It you put that \x00 somewhere in the NodeKey, the node will recognize only the part before \x00.

How are you passing in this value? Via the RPC interface, or on the command line?

Judging from your mention of stub.ListPeers I assume this is done through RPC with either Python or a similar language. It sounds like the encoding of the pubkey in the language of your choice is probably the problem.
Are you using node_pubkey_string or node_pubkey to send the pubkey?

Due to the project rquirements I have to use C++ with Visual Studio 15 2017 Win64.
Also I have built a grpc-1.28.0 with:
cmake .... -G "Visual Studio 15 2017 Win64"
And then I call:
lnrpc::OpenChannelRequest openchannel_request;
openchannel_request.set_node_pubkey("\x02\xd1\xa8\x17\xe4\xef\x00\xb5\x5c\x27\xf2\x31\x4d\x03\x4b\x01\xfb\x59\x14\xf0\xb6\x87\x4f\xab\x3e\x5d\x67\x99\xbd\xe4\x77\x21\x0b");
I put literal here for an example.
You can see those \x00 there.

I'm going to run some more tests in various languages.

Yes, this behavior is confirmed in the simplest client server with Visual Studio 15 2017 Win64

Thank you guys. \x00  means end of line.
So I just need to use set_node_pubkey with lenth specified explicitly:
openchannel_request.set_node_pubkey("\x02\xd1\xa8\x17\xe4\xef\x00\xb5\x5c\x27\xf2\x31\x4d\x03\x4b\x01\xfb\x59\x14\xf0\xb6\x87\x4f\xab\x3e\x5d\x67\x99\xbd\xe4\x77\x21\x0b", 33);