feat(namespace): add namespacing paths

replaces #32
This one does not rely on gateway features to be added, but uses a pre-functions plugin to strip the added namespace again before proxying. Ugly but works.
Once a proper solution in gateway is in place, we can switch to that (instead of adding the plugin here).
The plugin config generated: https://github.com/Kong/go-apiops/pull/129/files#diff-77a71302fdcf78eb63e7b91cb21a5c04a1eee45dd70789265057526444df380fR248-R263
$ go-apiops namespace --help
Namespaces API paths by prefixing it.

By prefixing paths with a specific segment, colliding paths to services can be
namespaced to prevent the collisions. Eg. 2 API definitions that both expose a
'/list' path. By prefixing one with '/addressbook' and the other with '/cookbook'
the resulting paths '/addressbook/list' and '/cookbook/list' can be exposed without
colliding.

A "pre-function" plugin will be added to remove the prefix from the path before
the request is routed to the service. If the prefix is matching the 'service.path'
suffix, then that property is updated, and no plugin is injected.

Example file:

routes:
- paths:
  - ~/tracks/system$
  strip_path: true
- paths:
  - ~/list$
  strip_path: false

namespaced using "--path-prefix=/kong":

routes:
- paths:
  - ~/kong/tracks/system$
  strip_path: true
- paths:
  - ~/kong/list$
  strip_path: false
  plugins:
  - name: pre-function
    config:
      access:
      - "local ns='/kong' -- this strips the '/kong' namespace from the path\nlocal <more code here>"

Usage:
  go-apiops namespace [flags]

Flags:
      --format string          output format: json or yaml (default "yaml")
  -h, --help                   help for namespace
  -o, --output-file string     output file to write. Use - to write to stdout. (default "-")
  -p, --path-prefix string     the path based namespace to apply
      --selector stringArray   json-pointer identifying routes to update (can be specified more than once)
  -s, --state string           decK file to process. Use - to read from stdin. (default "-")

Global Flags:
      --verbose int   this value sets the verbosity level of the log output (higher == more verbose)

Codecov Report
Attention: 44 lines in your changes are missing coverage. Please review.

Comparison is base (ec26109) 68.87% compared to head (da13935) 69.34%.

Files
Patch %
Lines

namespace/namespace.go
75.95%
34 Missing and 10 partials :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #129      +/-   ##
==========================================
+ Coverage   68.87%   69.34%   +0.46%
==========================================
  Files          19       20       +1
  Lines        2606     2789     +183
==========================================
+ Hits         1795     1934     +139
- Misses        679      713      +34
- Partials      132      142      +10

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Please update the PR with an example usage including an example input file and expected results

--path feels confusing as the argument name.  I think it should be more explicit.  Either : --namespace or --path-prefix, or provided as a positional argument like other apiops commands.

The selector help states:
--selector stringArray   json-pointer identifying routes to update (can be specified more than once)

Which implies to me a route object is required to be selected.
I can run the command without error selecting a non-route but see no visible change, so the function must be detecting a proper object. The command should fail if a user provides a selector that returns a non-route object, and warn (on STDERR) if the selector returns no object.

The resulting lua code is essentially obfuscated.
- "-- this will strip the '/abc' path-namespace from the upstream_uri\nlocal
          ns,nst,sn\nns='/abc'\nnst=ns:sub(-1,-1)=='/' and ns or (ns..'/')\nfunction
          sn(u)\n\tlocal s,e=u:find(nst,1,true)\n\tif s then\n\t\treturn u:sub(1,s)..u:sub(e+1,-1)\n\tend\n\tif
          u:sub(-#ns,-1)==ns then\n\t\tu=u:sub(1,-#ns-1)\n\t\tif u=='' then u='/'
          end\n\tend\n\treturn u\nend\nngx.var.upstream_uri=sn(ngx.var.upstream_uri)"

Is it possible to make this more human friendly in a multi-line yaml string with formatting?  I think users will want to be able to validate the plugin code, otherwise they are left to assume the logic is proper.  Manually or externally formatting is too tedious. Additionally the code will land in git repos and human friendly format would be better, for example if someone updates the path prefix in a CICD system the change will be easier to validate in a commit on the resulting file.

@rspurgeon

--path feels confusing as the argument name. I think it should be more explicit. Either : --namespace or --path-prefix, or provided as a positional argument like other apiops commands.

Since there is also a possibility to namespace by hostname (possible future enhancement), I think the --path-prefix makes most sense.

The resulting lua code is essentially obfuscated.
Is it possible to make this more human friendly in a multi-line yaml string with formatting?

Internally everything is treated as JSON, hence the code gets escaped in a JSON format. Afaik there is no easy way to get multiline output.

I think users will want to be able to validate the plugin code, otherwise they are left to assume the logic is proper. Manually or externally formatting is too tedious. Additionally the code will land in git repos and human friendly format would be better, for example if someone updates the path prefix in a CICD system the change will be easier to validate in a commit on the resulting file.

The code is always identical, except for the prefix itself. I'll try to update the code such that prefix is always on the first line, so in diffs only that line will appear.

Since there is also a possibility to namespace by hostname (possible future enhancement), I think the --path-prefix makes most sense.

Can you please briefly explain this idea as I'd like to consider the implications on this feature.

Since there is also a possibility to namespace by hostname (possible future enhancement), I think the --path-prefix makes most sense.

Can you please briefly explain this idea as I'd like to consider the implications on this feature.

There are 2 main ways to namespace api's:

use path prefixes, all on the same hostname;
a. http://api.acme.com/service1/somepath
b. http://api.acme.com/service2/somepath
use separate hostnames
a. http://service1.api.acme.com/somepath
b. http://service2.api.acme.com/somepath

This PR enables the namespaces based on path prefixes. An example for namespacing based on hostnames:
consider a route like;
routes:
- name: my route
  paths:
  - /somepath

use deck file namespace --host=service1.api.acme.com and get;
routes:
- name: my route
  hosts:
  - service1.api.acme.com
  paths:
  - /somepath

I can run the command without error selecting a non-route but see no visible change, so the function must be detecting a proper object. The command should fail if a user provides a selector that returns a non-route object, and warn (on STDERR) if the selector returns no object.

selecting non-routes now returns an error. Selecting nothing does not show a warning. It will log a message on level 1 (info). To show it use go-apiops --verbose=1. The log mechanism in this lib has 3 options (for easy integration with deck);

error; will be returned
info; verbosity = 1
debug; verbosity = 2

@rspurgeon all comments addressed, please have another look

selecting non-routes now returns an error. Selecting nothing does not show a warning. It will log a message on level 1 (info). To show it use go-apiops --verbose=1. The log mechanism in this lib has 3 options (for easy integration with deck);

error; will be returned
info; verbosity = 1
debug; verbosity = 2

@Tieske I tried this
./go-apiops namespace -s docs/mock-a-rena-kong.yml --selector "$.services[0].routes" --path-prefix "/123"
2024/01/19 08:38:58 failed to apply the namespace: the selectors returned non-route entities; %!w(<nil>)

The %@w(<nil>) is confusing.  Otherwise the error is helpful.

Here is a test where the input file has only 2 routes, but I select on the 3rd index.
./go-apiops namespace -s docs/mock-a-rena-kong.yml --selector "$.services[0].routes[2]" --path-prefix "/123"
_format_version: "3.0"
services:
- host: mockbin.org
  id: 6f6b4ca6-e7c3-5216-97a4-60eec30f82af
  name: mock-a-rena
  path: /requests
  plugins: []
  port: 443
  protocol: https
  routes:
  - id: b2c7dbfd-8b0f-5858-9568-e51da50c7b93
    methods:
    - GET
    name: mock-a-rena_a-rena
    paths:
    - ~/a-rena$
    plugins: []
    regex_priority: 200
    strip_path: false
    tags: []
  - id: 0f810925-7e7f-5451-b4e0-fcd59fc43606
    methods:
    - GET
    name: mock-a-rena_mock
    paths:
    - ~/mock$
    plugins: []
    regex_priority: 200
    strip_path: false
    tags: []
  tags: []
upstreams: []

This results in no error or warning and no impact on the resulting file.

Here is a test where the input file has only 2 routes, but I select on the 3rd index.

That's not an error, it just selects nothing. afaik that's json path behaviour.
try this instead (added --verbose=1)
./go-apiops namespace -s docs/mock-a-rena-kong.yml --selector "$.services[0].routes[2]" --path-prefix "/123" --verbose=1

Here is a test where the input file has only 2 routes, but I select on the 3rd index.

That's not an error, it just selects nothing. afaik that's json path behaviour.
try this instead (added --verbose=1)
./go-apiops namespace -s docs/mock-a-rena-kong.yml --selector "$.services[0].routes[2]" --path-prefix "/123" --verbose=1

Ok, i see.  However, I would suggest that when a user runs a command and there is no impact on the output, that should by default produce a warning.   So basically I think this warning should be at the default level.   There may be cases where this should not be true (I can't think of one right now),  but the default should be to warn when a command has no impact.   This helps users discover unintentional command syntax errors in pipelines, that are difficult to see.

That's just not how the library works, it cannot on its own start displaying warnings. That's up to the host application, in our case deck.
The way the lib works is like this, deck is the one that controls how to set the log level.
And unix in general should not display those things. If nothing matches, the output indeed is the same as the input. One would not expect; cat "yyyyy" | grep "xxx" to display a warning that "xxx" wasn't found.
Imho in a pipeline I would always set --verbose=1, just interactively it should stay silent.

That's not a message that is a code, which is an entirely different thing.
Long story short:

That's just not how the library works, it cannot on its own start displaying warnings. That's up to the host application, in our case deck.

That's not a message that is a code, which is an entirely different thing.

Yes, it would be preferable if an error was produced.   The continued approach of library of silent non-behavior is a very poor user experience.

That's not a message that is a code, which is an entirely different thing.
Long story short:

That's just not how the library works, it cannot on its own start displaying warnings. That's up to the host application, in our case deck.

If this is something that will be added at deck integration time, that works fine for me and we can move on from this thread of discussion.


Unhandled error

WARN: [BOT]-xdays's value: '60' is above the maximum limit: 30, which will be used instead.
Welcome to Lending Bot on BITFINEX
2017-08-16 00:37:51 Error conversion
Traceback (most recent call last):
File "lendingbot.py", line 80, in
Lending.cancel_all()
File "/media/kamrenov/other/work/poloniexlendingbot/modules/Lending.py", line 182, in cancel_all
available_balances = api.return_available_account_balances('lending')
File "/media/kamrenov/other/work/poloniexlendingbot/modules/Bitfinex.py", line 181, in return_available_account_balances
balances = Bitfinex2Poloniex.convertAccountBalances(bfxResp, account)
File "/media/kamrenov/other/work/poloniexlendingbot/modules/Bitfinex2Poloniex.py", line 109, in convertAccountBalances
if ((account == '' or account == accountMap[balance['type']])
KeyError: u'conversion'
Unhandled error, please open a Github issue so we can fix it!

This seems to be related to special account bitfinex has related to paying users back from the theft. The api always provides this account in the balances. It should be filtered out.

Should be fixed now, please update.


Improve messaging on zero users

...and refactor to separate printers.
My main concern with this change is that I've removed ui.Say()ing from the plugin case. Do plugins want those calls? There are no tests that say so.

I also started iterating over a map, which is going to produce randomised ordering of role groups. Fix under way.


Add basic tests to the rest package.

LGTM, big ty @patrickdappollonio for your contribution!

No problem @wenlock. I just joined the Ft Collins office, and I'm proficient in Go, so I'll be helping on as much as I can here. Let me know if you need something!


[question] unix applications (e.g. Steam games)

I tried to enable "prefer eGPU" for The Talos Principle, a Steam game, using both the installed shortcut and the script, but this has no effect.
When I browse the game files in Steam with Manage -> Show Local Files, and then open Get Info on the actual game executable, it shows as a "unix application" and has no setting for "prefer eGPU".
Is there any way to enable the eGPU for such executables?

Probably this: https://egpu.io/forums/postid/74029/

Will try this, thank you!


WIP: fix narrow type of relax compare

Fixes #24991
This pr adds a new relation called relaxComparableRelation, that compare type in a non strict equal conpare
this is not finished yet, follow item need to fix:

value compare of literal
object type compare
format code and simply logic predicate

Closing for housekeeping. As an aside, I'm not sure we'd want the PR as-is -- new relations are another cache we need to fill. Hopefully there would be another fix.


update feature matrix

I updated the feature matrix to include the new shock capturing capabilities on curved meshes implemented by @andrewwinters5000 in #900. Moreover, I added some "further reading" stuff to the right end of the table so that we can at least view more of it by default.
Current dev docs:

This PR:

My plan was to let auto-merge handle #900 first but since @sloede merged this one now... :shrug:

Sorry! I thought that this would never be merged automatically due to being a doc-only change (and thus the tests wouldn't run at all).


Writing file with relative path is not working correctly

Repro steps:
import Dataframes.Column
import Dataframes.Types
import Dataframes.Table
l1 = [1,2,3,4,5]
l2 = [11,12,13,14,15]
col1 = Column.fromList "col1" Int64Type l1
col2 = Column.fromList "col2" Int64Type l2
table = Table.fromColumns [col1 , col2]
CSVGenerator . writeFile "./data/foo.csv" table

is not saving to ./data folder while giving full path is saving everything correctly
Required behavior:
We should not expand the relative paths magically. We should use the Current Working Directory env variable, which should be set to project root. We need to check if it is set so, or the problem is caused by something else.

Works for me. Please give the full repro steps (actual code and how do you run it).
If you're using Luna Studio remember that Current Working Directory is coming from luna-empire and it might not be what user is expecting.

Please also check if standard library's writeFile work as expected.
Note: for luna-empire the CWD on my machine is C:\Program Files\LunaStudio\1.5\config\windows\

Current directory is set to current package directory during evaluation

@mikusp  Your are right. I just pasted the code as main in Dataframes project and opened it in Luna Studio. The file appeared correctly in the project's subtree.

Ok, I can see now. It is just Atom having delay on refreshing tree view.


[Simple Reminder] Add menu bar list of reminders

Extension
https://www.raycast.com/comoser/simple-reminder
Description
To have a more diversified way to check the reminders set, a menu bar command that lists the reminders you have will be a great way to have redundancy in checking the reminders.
Who will benefit from this feature?
Everyone using the extension and people used to check the calendar in the menu bar
Anything else?
No response

@raycastbot assign me


[BUGFIX] Make loose mode in class properties transform respect Babel settings

Up until recently, loose mode was required to be enabled in class properties if
decorators were also included. This behavior made undecorated class properties
behave unlike the spec, but decorated class properties still did behave like
the spec, counterintuitively. It also meant that we weren't following the user's
settings for loose mode, if they existed.
This PR makes the setting part of the user's standard Babel loose setting.

Looks great, thanks for fixing this upstream! Can you update the description here to make it clearer what happened before your changes, and after? Just so that if folks run into an issue after an ember-cli-babel update they could see what the intended changes here were...

Looks like the appveyor setup is not using yarn, and therefore not getting the pinned resolution we need to support Node 6.


Management of operation types

Following discussion of https://github.com/bnjbvr/kresus/pull/102
Here is the import of operation type inside the DB. I tookes into consideration all your comment.
Method getAllOperationType is not used, but can easily be changed to a method returning ListOperationType (useful to transmit the list of operation types without requesting them to the datasystem as the ListOperationType is created at the start up of the server).
Currently the operation types are not updated if the file containing them is changed. Maybe it should be

Thanks for your PR! I'll merge it, so that it's in the next version.

I'm back, I'll try to merge it this week.

It's now merged in incoming, which means it is going to be in the next released version (probably out in September). Thanks a lot for this contribution!


Messy CLI output

I recently made a change where children that have finished and everything passes are not displayed. This helped a lot with decluttering the output, but means I now get this:

We face messy outputs like this one

because when we output the test execution protocol with logUpdate, every call of any of the console methods messes it up.
In the example above, the Color,js's parse() method does it.
See https://github.com/color-js/color.js/blob/4de8e038ff6dcde6a845714e64a391cf0653f7a6/src/parse.js#L61-L68.
I'll try to figure out whether it's possible to suspend all standard console methods while logUpdate is in charge.

I'll try to figure out whether it's possible to suspend all standard console methods while logUpdate is in charge.

We probably still want to display them, but not in a way that messes up the output. Possibly all before or after the actual test output? One way would be to override the console methods without our own while a test is running, so we can capture the output, and do whatever with it.

We probably still want to display them, but not in a way that messes up the output. Possibly all before or after the actual test output? One way would be to override the console methods without our own while a test is running, so we can capture the output, and do whatever with it.

Makes perfect sense. It was on my list to figure out whether we can override the console methods. Glad to know it wasn't a bad idea. 😅

One way would be to override the console methods without our own while a test is running, so we can capture the output, and do whatever with it.

Something like this?
function interceptConsole (fn) {
	const methods = ["log", "warn", "error", "info"];
	let originalConsole = {};
	let messages = {};

	for (let method of methods) {
		messages[method] = [];

		originalConsole[method] = console[method];
		console[method] = (...params) => messages[method].push(...params);
	}

	fn();

	for (let method of methods) {
		console[method] = originalConsole[method];
	}

	return messages;
}

And later on we can re-play what was intercepted:
for (let method in messages) {
	for (let message of messages[method]) {
		console[method](message);
	}
}

Yup! Only nit is that your code wouldn't replay them in order, since it groups by method. You'd probably want to use a single queue and store objects like {args, method}, then you can replay them entirely in order. Also note that console.trace() will have the same effect, and it's much harder to replay (since it will then trace to our own code).


Added Prajjwal

@HemabhKamboj Added Prajjwal Mehta to the list.

have you deleted the repository after doing PR. This is leading to an error. PLease refork, make appropriate changes and then do PR again and don't delete the repository. Hacktober is finished but your contribution matters.


Remove setUpTestData from PlaywrightTestCase

Remove setUpTestData from PlaywrightTestCase because it doesn't work call this from
setUpClass, because all data will be removed after the first test.
The PlaywrightTestCase used StaticLiveServerTestCase that inherits from TransactionTestCase
that will flush the database after each tests.
The LiveServerTestCase doc string says:
It inherits from TransactionTestCase instead of TestCase because the
threads don't share the same transactions (unless if using in-memory sqlite)
and each thread needs to commit all their transactions so that the other
thread can see the changes.

See also: https://code.djangoproject.com/ticket/23640
We can call setUpTestData from setUp. But the class method setUpTestData originally stands for
initializing test data for the entire test case, so don't do this. It's up to the child class how to
create initial test data.
Raise a warning if there is a setUpTestData to clarify that it's not usable.
Also remove pytest warning by add the marker to [tool.pytest.ini_options]:
PytestUnknownMarkWarning: Unknown pytest.mark.playwright - is this a typo?  You can register custom
marks to avoid this warning - for details, see https://docs.pytest.org/en/stable/how-to/mark.html
    @pytest.mark.playwright

Codecov Report

Merging #67 (38ff7b1) into master (6edc656) will decrease coverage by 0.03%.
The diff coverage is 66.66%.

:exclamation: Current head 38ff7b1 differs from pull request most recent head b652693. Consider uploading reports for the commit b652693 to get more accurate results

@@            Coverage Diff             @@
##           master      #67      +/-   ##
==========================================
- Coverage   94.90%   94.87%   -0.04%
==========================================
  Files         100      100
  Lines        3611     3608       -3
==========================================
- Hits         3427     3423       -4
- Misses        184      185       +1

Impacted Files
Coverage Δ

bx_django_utils/test_utils/playwright.py
58.53% <0.00%> (-2.18%)
:arrow_down:

bx_django_utils/__init__.py
100.00% <100.00%> (ø)

...django_utils_tests/tests/test_playwright_helper.py
67.85% <100.00%> (-1.11%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


[Android] Remove deprecated APIs and fix for a few found issues

This PR mainly addresses and closes #32
Changes:

Replaced deprecated middleware() from Segment Android with suggested useSourceMiddleware()
Removed registerWith() as it is also deprecated and was needed only when Flutter Embedding V1 was used, while the plugin already switched to V2, so register will happen automatically.
A few fixes for lint warnings, like adding correct annotations, switch to lambda in userSourceMiddleware(), etc.
Add a teardown for methodChannel in onDetachFromEngine as it should be done.
Bumped Android Gradle plugin to 7.2.1 as it was a hotfix for 7.2.0
Updated example to not use jcenter.

@vbuberen I tried and on compilation it fails with:
/Users/.../.pub-cache/git/flutter-segment-95ad9e4b3158442f3dd78f6d0dade7b03b8a2875/android/src/main/java/com/example/flutter_segment/FlutterSegmentPlugin.java:90: error: lambda expressions are not supported in -source 7
              chain -> {
                    ^

@vbuberen I tried and on compilation it fails with:
/Users/daniel/.pub-cache/git/flutter-segment-95ad9e4b3158442f3dd78f6d0dade7b03b8a2875/android/src/main/java/com/example/flutter_segment/FlutterSegmentPlugin.java:90: error: lambda expressions are not supported in -source 7
              chain -> {
                    ^
  (use -source 8 or higher to enable lambda expressions)

Looks like I needed to explicitly specify in build.gradle the following block:
compileOptions {
        sourceCompatibility JavaVersion.VERSION_1_8
        targetCompatibility JavaVersion.VERSION_1_8
    }

In latest Android Studio versions it is not an issue as project build fine even without that part I mentioned above.


Spell wrong number format

When I typed 000100.01 or 000100.10. There is no different between these cases.

@Ram4GB Thanks for reporting the issue. I'm trying to fix it as soon as possible.

Temporarily fixed in 2.1.3. We're planning to refactor the core algorithm in the next v3 release, which has better tests as well.


Allow certificate_authority to be a base64 single line string (from Hashicorp Vault)

Is this a BUG REPORT or FEATURE REQUEST?:

feature

What happened:
Tried setting certificate_authority: ((k8s-ca-cert)) to a variable stored in Vault which is base64 encoded (since Vault doesn't appear to like our multiline PEMs.
What you expected to happen:
It would be nice if the resource could detect a one-line string provided for certificate_authority, and base64 decode it (revealing the multi-line base64 encoded PEM).
How to reproduce it (as minimally and precisely as possible):
- name: k8s-cluster
  type: kubernetes
  source:
    server: ((kubernetes_server_url))
    certificate_authority: ((kubernetes_ca_cert))
    namespace: ((kubernetes_namespace))
    token: ((kubernetes_token))
    # We have to fall back to insecure, or run a task to pull in the b64 string as an environment
    # variable and decode it, and locate the file in the following steps.
    #insecure_skip_tls_verify: true

Anything else we need to know?:
No
Environment:

Concourse CI version: (use fly --version): 3.14.1
kubernetes-resource image version: 1.8
Others:

You can write a multiline text into Vault. See https://github.com/hashicorp/vault/issues/1929#issuecomment-249921120.

This issue is inactive, so I'll close it. If you have any problems, please feel free to reopen it.


Dasel don't preserve initial XML content.

Discussion?
While trying to use Dasel as a Go package in a personal project updatecli, I noticed that it drops XML comments, directives, and processes.
Describe the bug
Dasel don't preserve initial XML content.
To Reproduce
The command dasel -f example.xml -p xml
.example.xml
<?xml version="1.0" encoding="UTF-8"?>
<!-- This a commment -->
<name>
    <firstname tag="xx">John</firstname>
    <lastname>Doe</lastname>
</name>

.output
<name>
    <firstname tag="xx">John</firstname>
    <lastname>Doe</lastname>
</name>

.expectedOutput
<?xml version="1.0" encoding="UTF-8"?>
<!-- This a commment -->
<name>
    <firstname tag="xx">John</firstname>
    <lastname>Doe</lastname>
</name>

Another example is the command  dasel put string -p xml -f example.xml .name.firstname Tom on the same example file, generated the following file:
<name>
  <firstname>Tom</firstname>
  <lastname>Doe</lastname>
</name>

Instead of:
.expectedOutput
<?xml version="1.0" encoding="UTF-8"?>
<!-- This a commment -->
<name>
    <firstname tag="xx">John</firstname>
    <lastname>Doe</lastname>
</name>

Expected behavior
I would expect Dasel to preserve all original XML instructions
Screenshots
/
Desktop (please complete the following information):

OS: Linux
Version [1.21.2]

Additional context
After looking at Dasel and mxj code base, It appears that Dasel is manipulating a mxj.Map and could instead use the mxj.MapSeq which seems to preserve everything.  I am still new to the two projects so I may need some guidance to contribute to this issue. It appears that some work is needed here but I may be missing something else.

That file is indeed the one that needs editing.
I have done a quick test and found that simply using mxj.NewMapXmlSeq instead of mxj.NewMapXml doesn't work.
I'll have to do a bit more reading to find out how to correctly use mxj to solve this issue. Please bear with me!

It seems that when using NewMapXmlSeq the XML version and comment information are added as map nodes at the root level causing confusion.

@TomWright Thanks for looking at this, I started looking at this comment https://github.com/clbanning/mxj/issues/17#issuecomment-947056926  but unfortunately, I run out of time so I can't help as much as I would like to.


[Bug]: Web Executor: Read File: permission issue

What happened?
File system permissions do not appear to persist between sessions.
Here's an example:

As you can see, I get an error path not allowed on the configured scope when attempting to read a file.
Here is the project for testing: Access Control Issue.zip
To reproduce the issue:

Open the project
Edit the Read Directory node
Pick a directory (any directory, something with not too many files in it.)
Run the project: this will work fine - you should see the Read File node populating with e.g. "binary (length 123,456)`
Save the project and close Rivet
Open Rivet and open the same project
Run the project: this will fail - you will see an error message on the Read File node.

Best guess:

the Web Executor uses the File System API to select and authorize access to the folder.
access is granted for that browser session, enabling Read File to read a file from that directory.
when reopening the project, permissions do not get restored.

I don't know Tauri, but I would guess it provides a more direct (less restrictive) file system API than the browser provides?
Do you have plans to actually support Tauri on the web? (running in an actual browser?)
If not, you might consider renaming your Web Executor to Tauri Executor and using it's APIs instead?
If you do intend to keep Rivet compatible with the web, you might need another executor, or maybe a shim of sorts, e.g. overriding the File System API prototypes in the Rivet version to remove the web-specific restrictions from the desktop app?
Alternatively, you might want to take a look here:
https://developer.chrome.com/blog/persistent-permissions-for-the-file-system-access-api
it looks like VS Code gets around this issue:

I don't think VS Code was built on Tauri, but this approach might work here as well?
What was the expected functionality?
File system permissions should persists in the project data.
Describe your environment
Win 11 Pro
Relevant log output
No response
Relevant screenshots
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

It doesn't actually use the file system APIs because those aren't present in the default WebViews that Tauri uses, they're too new. It does use the Tauri APIs, but those have special security associated with them too so that the browser can't just read any file on your file system. It's been buggy for a long time though, I'll see what I can do to improve it.

If not, you might consider renaming your Web Executor to Tauri Executor and using it's APIs instead?

I would if Tauri's web APIs supported streaming, but they don't, so I have to use the browser fetch API.


Bug: Builds failing

Lexical version: Current
Not sure how else to report it but the failing builds are obviously blocking all releases including nightlies, any plans to resolve this soon?

npm run build-prod seems to be working fine for me. If you're referring to the CI and E2E tests, we're aware of this, there's some flaky E2E tests that needs to either be addressed/disabled or moved to Unit.

The nightly releases never worked properly in the first place - I am trying to fix that soon. In the meantime, there is nothing blocking releases. The core team just has to do it manually.


[DOCFIX] remove a space

What changes are proposed in this pull request?
Please outline the changes and how this PR fixes the issue.
Why are the changes needed?
Please clarify why the changes are needed. For instance,

If you propose a new API, clarify the use case for a new API.
If you fix a bug, describe the bug.

Does this PR introduce any user facing changes?
Please list the user-facing changes introduced by your change, including

change in user-facing APIs
addition or removal of property keys
webui

remove a space for pr

/check-cla

@thu-david could you please address the comments? thanks

单纯为了提pr


AttributeError: 'NoneType' object has no attribute 'views'

This showed up when I opened a project:
Traceback (most recent call last):
  File "D:\SublimeText\Data\Packages\PackageDev\plugins_\settings\__init__.py", line 174, in do_linting
    and USER_PATH in self.view.file_name()
TypeError: argument of type 'NoneType' is not iterable
Traceback (most recent call last):
  File "D:\SublimeText\Data\Packages\PackageDev\plugins_\settings\__init__.py", line 174, in do_linting
    and USER_PATH in self.view.file_name()
TypeError: argument of type 'NoneType' is not iterable
Traceback (most recent call last):
  File "D:\SublimeText\sublime_plugin.py", line 513, in on_selection_modified_async
    callback.on_selection_modified_async(v)
  File "D:\SublimeText\Data\Packages\SublimeLinter\sublimelinter.py", line 394, in on_selection_modified_async
    view = self.get_focused_view_id(view)
  File "D:\SublimeText\Data\Packages\SublimeLinter\sublimelinter.py", line 384, in get_focused_view_id
    for view in view.window().views():
AttributeError: 'NoneType' object has no attribute 'views'
Finished normally

Related:

https://github.com/SublimeText/PackageDev/issues/129 TypeError: argument of type 'NoneType' is not iterable
https://github.com/SublimeLinter/SublimeLinter3/issues/570 SublimeLinter deamon crashes on fast view changes

Environment

Operating system and version:

Windows 10 build 15063 x64
Mac OS ...
Linux ...

Monitor:

Resolution 1920x1080
dpi_scale used in ST 1.0

Sublime Text:

Build 3142
32 bit

https://github.com/SublimeLinter/SublimeLinter3/blob/a5f6c28ac7d88bfe28d524f6c2a6c2ed6b563cbc/sublimelinter.py#L351-L356
https://github.com/evandrocoan/SublimeLinter3/blob/23581518a17050ca9692cce6ab733f4e081acdcf/sublimelinter.py#L384-L390

Same error for me.

closing in favour of #570


Xfreerdp connection failed

I can't connect anymore with xfreerdp
In a terminal:
xfreerdp /v:server_name /u:my_login /p:my_password /d:domain_name
[11:22:10:675] [21598:21599] [INFO][com.freerdp.client.common.cmdline] - loading channelEx cliprdr
[11:22:11:699] [21598:21599] [ERROR][com.freerdp.core.transport] - BIO_read returned a system error 104: Connection reset by peer
[11:22:11:699] [21598:21599] [ERROR][com.freerdp.core.nego] - Protocol Security Negotiation Failure
[11:22:11:699] [21598:21599] [ERROR][com.freerdp.core] - freerdp_set_last_error ERRCONNECT_SECURITY_NEGO_CONNECT_FAILED [0x0002000C]
[11:22:11:699] [21598:21599] [ERROR][com.freerdp.core.connection] - Error: protocol security negotiation or connection failure
version 2.0.0-dev5 (2693389a+debian)
connect to windows serveur 2016 standard build 1607 64 bits
from Debian Stretch 64 bits

Check your server policy and log entries.
Can connect quite fine to a 2016 server here with the exact version.


Error when using typescript flag on object with animation

I get the following error when running gltjsx -t ./{model}.gltf on any model that has an animation:
TypeError: Cannot read properties of undefined (reading 'name')     at file:///**/.npm/_npx/16b3f312213fced0/node_modules/gltfjsx/src/utils/parser.js:103:60     at Array.map (<anonymous>)     at printTypes (file:///**/.npm/_npx/16b3f312213fced0/node_modules/gltfjsx/src/utils/parser.js:103:34)     at parse (file:///**/.npm/_npx/16b3f312213fced0/node_modules/gltfjsx/src/utils/parser.js:436:27)     at file:///**/.npm/_npx/16b3f312213fced0/node_modules/gltfjsx/src/gltfjsx.js:52:26     at file:///**/.npm/_npx/16b3f312213fced0/node_modules/gltfjsx/src/bin/GLTFLoader.js:1215:7     at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
I tried to do some debugging and it seems the animations array comes in as [ undefined ]. It works fine without the types flag. Attached is a cube with a small rotate animation for reproducibility.
cube.gltf.zip

I believe this was introduced in #3a8063a. Animations are being overridden when we wrap the reassign the gltf parameter to parser/parse

I had debugged that initially and it wasn't hitting that if statement. Instead of an empty array, it'll actually fill the array with a matching number of undefineds as animations in the gltf (ex [undefined, undefined] for 2 animations.
After more diving, I think it is caused by 7b3377a9. Seems the loadAnimation method was completely gutted for some reason.

Hi - whats up with the gutted load animation?


Deploy the model to streamlit or other suitable Deployment sites

Users can easily go through the project if deployed instead of forking the project and then checking the live version . In other words, make it live . Pls assign this task to me and
and assign me the labels gssoc and hacktoberfest-accepted and level3

You have a really nice observation, I was thinking about the same, let's hop on discord and discuss further about this.

Sure :))
On Sun, Oct 6, 2024, 11:09 Devasy Patel @.***> wrote:

You have a really nice observation, I was thinking about the same, let's
hop on discord and discuss further about this.
—
Reply to this email directly, view it on GitHub
https://github.com/Devasy23/FaceRec/issues/54#issuecomment-2395302278,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A33RIC5JUUA2DQWUATURKYLZ2DEILAVCNFSM6AAAAABPLECWBCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOJVGMYDEMRXHA
.
You are receiving this because you authored the thread.Message ID:
@.***>

https://discord.gg/xhVZvsak

hey @Monu2114 - how's the progress?
Let us know if you need help on anything

hey sorry was occupied with exams will start the work now
On Sat, Oct 12, 2024 at 4:44 PM Devansh Shah @.***>
wrote:

hey @Monu2114 https://github.com/Monu2114 - how's the progress?
Let us know if you need help on anything
—
Reply to this email directly, view it on GitHub
https://github.com/Devasy23/FaceRec/issues/54#issuecomment-2408526109,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A33RICYTKXGH7THBOMCOWI3Z3EAAVAVCNFSM6AAAAABPLECWBCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBYGUZDMMJQHE
.
You are receiving this because you were mentioned.Message ID:
@.***>


Fix some stuff broken in the Python 2 to 3 transition

Short Description:
Fixes various bugs from the Python 3 support branch.
Changes:

Force logger.py to use Python 3 types for strings even if running on Python 2.
Move utils.py to bot directory since it doesn't make sense for it to be in cell_workers.

@OpenPoGo/maintainers

:+1:

:+1:


Fix build

The build is currently broken, that's because the fuzzywuzzy lib was not being installed during the build.
Also, there was a error message with a local path in the search notebook, which I think is a bad idea. Therefore, I removed it.

I agree with @Chipe1 on #497 that it would be better if we did not use the fuzzywuzzy library just for this one function, so I don't think we should be adding it to the requirements.

@MrDupin Yes, I agree adding the new lib is not a good idea. However, until we fix that properly, I don't think the build should stay broken. That's the only reason for this MR.

Yes, definitely.

@lucasmoura #501 would fix the dependency issue. As for the error with the local path, there are 4 more in search.ipynb
Would be nice if you removed those errors too.

I fixed the other notebook errors in another PR, #503.

Seems this MR is not necessary anymore.


Stopped truncating AdminEmailHandler message subjects

Refs #26572, #17281. The RFC doesn't limit total length, just the line length
which is already taken care of by Python itself.

I didn't look too deeply, but your analysis seems to make sense.

Release note added.


Auto start NPC menu when shift+right_click

Pls add :)

I figured people would find it annoying when they accidentally do it on NPC's and the huge menu shows up. Im not sure yet, i might make it a config option.

Ya that's the right way mate :)

I am also finished with coding this, so it will also come in v1.1.1

v1.1.1 is released.


Add character class combinators

I'm hoping to write a parser for a programming language that has exceptional unicode support. However, the language's productions for identifiers requires that they be an alternating list of unicode character categories. Specifically, the productions require me to determine if the categories are in the categories Ll, Lu, Lt, Lm, Lo, or Nl, for the first character, and Mn, Mc, Nd, and Pc, for all other characters. (The standard uses ISO/IEC 10646 categories, so it describes these as letter_uppercase, letter_lowercase, letter_titlecase, letter_modifier, letter_other, number_letter, mark_non_spacing, mark_spacing_combining, number_decimal, and punctuation_connector.) I am unsure if the existing combinators will allow me to fully meet the requirements of the productions, as the documentation doesn't specify included general categories for each combinator. Would it be possible for a combinator to retrieve characters of a given general category to be added? Or amI missing something?

This likely needs a few documentation improvements, but at least some of these are already implemented. I'll keep this as an open task until I'm sure all of these are implemented. The following are implemented:

letter_uppercase: is_uppercase
letter_lowercase: is_lowercase
number_letter: is_numeric (I believe, let fully check the implementation)
mark_non_spacing: is_whitespace (negating this, I believe, let fully check the implementation)

The rest to my recollection are not implemented, but should be doable efficiently. I'll also just add a reference to ensure these are fully implemented, or documented, as it should be. I'll add combinators for anything that is missing, if applicable, since this is will within the scope of the intended functionality of the library).
http://www.ada-auth.org/standards/12rm/html/RM-2-1.html

@Alexhuszagh The is_* functions work but I am worried about is_whitespace. Specifically, I am concerned that trying to build a parser using that function would allow invalid identifiers. What does is_whitespace consider as whitespace? I could pull in a unicode crate to check to see if the character is one of the one's I'd like to forbid but that seems like duplication of effort.


Set Y4M pixel range to limited from CLI

Attempt to fix #1341. I don't think the y4m crate is parsing range in the header, so simply use the default value of limited.

Do we have an override for it?

Coverage decreased (-0.006%) to 82.879% when pulling 9297f5fd697ffe42f52b5a18b0febacbe24d6893 on rzumer:y4m_limited_range into de0ff9558ba539035fe6bf7d5b272a797ac6d19a on xiph:master.

I don't think so. I will add an option for it in a bit.
On 2019-06-18, at 12:08, Luca Barbato<EMAIL_ADDRESS>wrote:

Do we have an override for it?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

There is in fact already a --pixel_range option. My approach was wrong though, I will force-push a fix that will correctly allow users to override the default.


Add MetaTables

Still need to add documentation, but the logic is in place already.

I am not sure what this is used for, so I can't really do review for it.

See the docs, it's for registering trait implementations of resources. This will also be used for AnyStorage.

Rebased it. If you don't feel comfortable reviewing this PR, I can just as well wait for others to review it or merge it as-is.

What issue is being addressed here?

There's no specific issue filed, I just talked about it on Gitter a few times.
Here the motivation:
There's sometimes the need to call trait methods of resources where you don't know the specific type. Deleting components using AnyStorage is an example for that.
There are three problems with the current architecture:

the current solution needs an extra field in World, a Vec with raw fat pointers of AnyStorages
the user cannot access that API to add their own custom component storages
for scripting you also want an API like this that allows you to access the trait implementations of arbitrary resources

This PR makes all that consistent allows easy access by the user.

bors r+


[WIP] New feature: Adaptive Lighting support

Implementation for #30
Currently still a draft for CI purposes and transparency.

Basic integration done, but I still need to do more verification to see if the "automatic mode" is suitable and if the plugin still works with older versions of Homebridge.
Other things to do/consider:

Check if Adaptive Lighting is deactivated if the color the color is changed via another source (i.e. directly via MQTT). Not sure if this should also be done if the color temperature is changed.
Add unit tests to test if the Homebridge version is checked and if the controller is added when Brightness and Color Temperature are available.
Add configuration options per device to disable and/or tune Adaptive Lighting.
Maybe add a "global" device configuration so Adaptive Lighting can be turned off/tuned for all supported devices in one go.

It seems that the "automatic mode" of the AdaptiveLightingController triggers an update for each light every minute or so.
On one hand this seems doable, on the other hand, this seems like a lot if you have a lot of lights.
Unfortunately as mentioned in the issue before, I cannot use the transition for this, so I don't think there is a lot I can do about the amount of messages.
Another thing I did notice however, is that it even triggers an update even if the temperature has not changed.
I can implement a caching mechanism to prevent "duplicate" messages while adaptive lighting is active.
This will probably still result in bursts of messages, but the overall number of messages would be reduced.

This is awesome to see!
One thing I dislike about Hue's native adaptive lighting is that it's leans significantly on the colder side than I'd prefer. Unfortunately there's no way to modify this.
I'd definitely consider bringing my Hue bulbs into my Z2M ecosystem if it meant I could customize the upper and lower bounds of color temperatures. Is that something that the Homebridge adaptive lighting controller could allow? From a quick glance at the API it seems doubtful.


ValueError: updates argument is not supported during eager execution. You passed: [<tf.Variable 'UnreadVariable'

Please make sure that this is a bug. As per our
GitHub Policy,
we only address code/doc bugs, performance issues, feature requests and
build/installation issues on GitHub. tag:bug_template
System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow):
OS Platform and Distribution (e.g., Linux Ubuntu 16.04):
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device:
TensorFlow installed from (source or binary):
TensorFlow version (use command below):
Python version:
Bazel version (if compiling from source):
GCC/Compiler version (if compiling from source):
CUDA/cuDNN version:
GPU model and memory:

I am using Python 3.6 with Tensorflow 2.3.0 and Keras 2.3.0 on Windows 10.  NVIDIA-SMI 452.56       Driver Version: 452.56       CUDA Version: 11.0
You can collect some of this information using our environment capture
script
You can also obtain the TensorFlow version with:

TF 1.0: python -c "import tensorflow as tf; print(tf.GIT_VERSION, tf.VERSION)"
TF 2.0: python -c "import tensorflow as tf; print(tf.version.GIT_VERSION, tf.version.VERSION)"

Describe the current behavior
When I run training of a Color-CNN model (https://github.com/beerboaa/Color-Classification-CNN/blob/master/color_net_training.py) I get
Found 1260 images belonging to 3 classes.
Found 420 images belonging to 3 classes.
Traceback (most recent call last):
File "C:/workspace/color_model/color_classification_cnn.py", line 162, in
model.fit_generator(
File "C:\Python3\lib\site-packages\keras\legacy\interfaces.py", line 91, in wrapper
return func(*args, **kwargs)
File "C:\Python38\lib\site-packages\keras\engine\training.py", line 1718, in fit_generator
return training_generator.fit_generator(
File "C:\Python3\lib\site-packages\keras\engine\training_generator.py", line 42, in fit_generator
model._make_train_function()
File "C:\Python3\lib\site-packages\keras\engine\training.py", line 328, in _make_train_function
self.train_function = K.function(
File "C:\Python3\lib\site-packages\keras\backend\tensorflow_backend.py", line 3007, in function
return tf_keras_backend.function(inputs, outputs,
File "C:\Python3\lib\site-packages\tensorflow\python\keras\backend.py", line 3932, in function
raise ValueError('updates argument is not supported during '
ValueError: updates argument is not supported during eager execution. You passed: [<tf.Variable 'UnreadVariable' shape=(48,) dtype=float32, numpy=
array([0., 0., 0., 0., 0., 0., 0., 0., 0., 0., 0., 0., 0., 0., 0., 0., 0.,
0., 0., 0., 0., 0., 0., 0., 0., 0., 0., 0., 0., 0., 0., 0., 0., 0.,
0., 0., 0., 0., 0., 0., 0., 0., 0., 0., 0., 0., 0., 0.],
dtype=float32)>, <tf.Variable 'UnreadVariable' shape=(48,) dtype=float32, numpy=
Describe the expected behavior
This script should train the color-CNN model
Standalone code to reproduce the issue
Provide a reproducible test case that is the bare minimum necessary to generate
the problem. If possible, please share a link to Colab/Jupyter/any notebook.
https://github.com/beerboaa/Color-Classification-CNN/blob/master/color_net_training.py
Other info / logs Include any logs or source code that would be helpful to
diagnose the problem. If including tracebacks, please include the full
traceback. Large logs and files should be attached.

That code is 4 years old. I suggest you to open an issue there if the maintainer is still active. It will need for sure some changes to run in modern TF versions.
@saikumarchalla I think that we can close this.

@SixtyTrees   The code which you have provided using keras  instead of tf.keras and it is very old. Please check the suggestion mentioned above by @bhack .


MNT: compatibility with newer packaging

I dug into this a bit because newer versions of black and conda require packaging>=22.0.
Following recommendations here: https://github.com/pypa/packaging/issues/631#issuecomment-1343479721
The simplest way to support all versions of packaging is to use the Version class directly instead of the parse function.
parse used to return Version or LegacyVersion depending on if it received a valid version string, but now it raises InvalidVersion instead if the version string is invalid. If we add a try/except around parse then you'll be compatible with packaging>=22 but lose compatibility with packaging<22. Instead, switching to the Version class directly has the same exception raising behavior in all versions of packaging, including the latest.
This seemed like an appropriate fix here because this library only uses LegacyVersion as an indicator that something is a branch rather than a version, so its absence doesn't seem like much of a problem.
closes #27

Looks like it should work in principle, and I'd be happy to merge if you can make the tests pass.
You'll also have to pin black < 23.

It's not going to be that easy… There are several other places where parse_version is called, and I really depend on the old behavior. The easiest fix is probably to backport the entire old parse_version function and the LegacyVersion type (or something that behaves equivalently) into the package.

I didn't realize you were using parse_version elsewhere, that's my bad.
Maybe the easiest thing to do is to use https://pypi.org/project/packvers/ which I think is just a forked/vendored version of packaging at 21.3, or backport/vendor it yourself if you prefer.

I'm going to look into this in #32

Thank you for moving ahead with this!


Enable creating Calendar and CommunityList widgets

Works towards #941.
Feature Summary and Justification
This feature provides the methods add_community_list and add_calendar for creating CommunityList and Calendar widgets.
Other changes:

Changed output of pre_push.py slightly to be more clear. Previously, the phrasing made it seem like it was Sphinx output
Modified RedditBase to allow comparison to unicode in Python 2. This was causing the assertion assert self.reddit.subreddit('redesign') in widget to fail in Python 2 because widget contained unicode objects but the RedditBase comparison only checked for str types.
Updated documentation of add_text_area
Fixed TextArea cassette to have proper name

Thanks!


Explicit return from try block

Description
The try-except statement has an else clause for code that should
run only if no exceptions were raised. Using the else clause is more
explicit than using a return statement inside of a try block.
Type of change

[x] Refactor
[ ] New feature
[ ] Bug fix
[ ] CVE fix
[ ] Optimization
[ ] Documentation Update
[ ] Configuration Update
[ ] Bump-up dependent library

Checklist before requesting a review

[x] I have performed a self-review of my code.
[x] PR has passed all pre-merge test jobs.
[ ] If it is a core feature, I have added thorough tests.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (7d1c9ab) 95.07% compared to head (c0b5205) 94.83%.
Report is 12 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #459      +/-   ##
==========================================
- Coverage   95.07%   94.83%   -0.24%
==========================================
  Files          34       36       +2
  Lines        1096     1181      +85
==========================================
+ Hits         1042     1120      +78
- Misses         54       61       +7

Files
Coverage Δ

ols/app/endpoints/ols.py
100.00% <100.00%> (ø)

ols/utils/suid.py
100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

I can't decide if it is better or worse in terms of code readability. I'll let others to lgtm this one.

currently the expected flow of the code would be:

do some work
return some value
if an exception happened in (1), handle it.  This should be unusual.

changing it to:

do some work
check if an exception happened + handle it
return some value from (1)

imho makes it less readable because the return statement is separated from the main logic that setup/computed the return value.  For someone who's reading the code to understand the happy path, they need to recognize that they need to go look at the "else" statement to see what additional steps are going to be executed.
personally when i'm trying to understand code i usually stop reading when i get to the exception handling portion (assuming i don't have a reason to care about it).
all in all it's a bikeshed, but i'm a -1 on this structure.

I guess i'll also add that this change seems to violate the principal of "earliest possible return":
https://www.linkedin.com/pulse/early-return-dip-ghosh/
but again, that's to some degree a personal preference, certainly not a hard+fast rule.

@tisnik do you want to make a case for this or can we close it?

We can close it, won't be relevant anymore.


fix fix be macos ut failure

Proposed changes
Issue Number: close #xxx
Problem summary
Describe your changes.
Checklist(Required)

Does it affect the original behavior:

[ ] Yes
[ ] No
[ ] I don't know

Has unit tests been added:

[ ] Yes
[ ] No
[ ] No Need

Has document been added or modified:

[ ] Yes
[ ] No
[ ] No Need

Does it need to update dependencies:

[ ] Yes
[ ] No

Are there any changes that cannot be rolled back:

[ ] Yes (If Yes, please explain WHY)
[ ] No

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 36.1 seconds
load time: 483 seconds
storage size:<PHONE_NUMBER>6 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221124080948_clickbench_pr_52029.html


GPU installation need to be updated

We need to update GPU installation (including PyTorch2.1 support, Windows installation) in chapter6 and 7, referring to https://bigdl.readthedocs.io/en/latest/doc/LLM/Overview/install_gpu.html

English version was updated. Some changes also need to apply on Chinese version to align.


Rename repository, update documentation & assets

Hi Jan,
This issue is being opened to ask if you would be open to renaming your extension on GitHub via the 'Settings' option to reference Camunda Platform 7 rather than Camunda BPM. (For example: camunda-platform-7-camel) This change will also likely impact any screenshots you have in the README that reference Camunda BPM, and this verbiage will need to also be updated throughout the repo's documentation as a whole if you choose to make these changes. You can also make use of Shields.io badges to indicate which version of Camunda your extension is compatible with.
While it is not a requirement that you rename your extension to align with Camunda Platform 7, we would greatly appreciate it if you could make these changes, and merge them anytime after April 12th, 2022.
if you have any questions or require any assistance, please do not hesitate to reach out to @camunda-community-hub/devrel! :)

@jangalinski @berndruecker are you interested in making these changes? If renaming the entire project is too difficult, I would recommend at least changing the name of Camunda BPM to Camunda Platform 7 in the README.

It might be a bit far fetched, but a great solution would be a generic camunda camel model that can work with either platform 7 or 8 ... so kind of a meta-model ...
options:
a) rename this one and create a new "works with both" camel extension
b) leave this one for now and just flag the readme as "currently platform 7 only"
opinions?

I renamed and add a label for C7 for the moment to make this clear (because everything else will take time anyway).
I did not touch groupId / artifactID so far (@jangalinski: Feel free to take this on if you like :-))
Thinking about it, I think we should go for a new project targeting Camunda 8 - as it will look quite a bit different (especially as it needs to take an endpoint to connect to compared to talk to the engine in-vm.
In general, there we would need a new Camel endpoints, e.g.
camunda-8[somehow the endpoint mus go here]://start in contrast to
camunda-bpm://start (which goes to C7 and I vote for not touching it, even if the naming is not optimal)
And a task worker that subscribes to the task type camel (needs some additional thought).

"if I like" - no sorry, not at the moment, busy with other topics. Let's leave it for now.

If you can remember ... I did the "zeebe-camel-facebam" in Berlin using a zeebe-camel early adopter example ... so at least I have some fragments.
I would prefer having C7 and C8 camel under the same repo as the concepts (correlation, external task, ...) are very similar ...

Let's pick the Camel & C8 topic up again when we see demand for it.
Of course i remember https://github.com/holunda-io/camel-zeebe and https://github.com/holunda-io/zeebe-camel-facebam


Auro design tokens: Oneworld/MP Tier tokens

We have an upcoming 100k tier being added to the Mileage Plan program.
Sometimes I see these tiers with different colors.  Should we add design tokens for these tiers so its easier to implement and is consistent?
@vidalmenAS I'd love to discuss this one with you.
Million miler uses #767676
https://www.alaskaair.com/content/mileage-plan/membership-benefits?lid=mileageplan:mileage-plan-overview:membership-benefits
One world does use colors to denote each tier that we should create tokens for.
https://cdn4.loyaltylobby.com/wp-content/uploads/2014/12/Oneworld-Enhanced-Sapphire-Benefits-Table.png

Added oneworld and AA tier colors: https://www.figma.com/file/TBMhIMVRMkufKnyxqGzrZO/Color-Explorations?node-id=33%3A2629
Waiting for review.

@leeejune Suggestion:  Token name: auro-color-oneworld-tier-ruby
Tier is a child concept of OneWorld.

@blackfalcon Should that apply to auro-color-tier-alaska-mvp-on-light as well?

@braven112 The oneworld link doesn't work for me. Is there another link I can access?

I think it was the blue, green and red from this page:
https://www.oneworld.com/travel-benefits

I would reach out the the designer on the loyalty team to double check the exact hex value.

@leeejune here is what we need to do.
We need to create the baseline token that is these colors. Like we have var(--auro-color-brand-goldcoast-200)
Then those baseline tokens will be aliased to auro-color-oneworld-tier-ruby and auro-color-alaska-tier-mvp
Are there onDark versions of these colors? The OneWorld site doesn't appear to support a dark mode, so my guess is no.

Are there onDark versions of these colors? The OneWorld site doesn't appear to support a dark mode, so my guess is no.

There is no onDark for OneWorld. Alaska has onDark for MVP Gold and MVP.

https://www.figma.com/file/TBMhIMVRMkufKnyxqGzrZO/Color-Explorations?node-id=107%3A1869
Updated with baseline color names and alias color tokens. Please review @blackfalcon!

I will be adding the tokens to the code with Dale's help.


Change config to Size & Performance

Under 'Solution', second bullet point, step 4, I'm thinking 'As soon as the SAS URL is revoked, go to Configuration for the managed disk' should be changed to 'As soon as the SAS URL is revoked, go to Size & Performance for the managed disk'

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 626f4eb0-576e-cc98-6d59-45bb776a222c
Version Independent ID: 5bbbb2c5-10f0-39f4-df8d-da2b0cdce567
Content: Troubleshoot replication of Azure VMs with Azure Site Recovery - Azure Site Recovery
Content Source: articles/site-recovery/azure-to-azure-troubleshoot-replication.md
Service: site-recovery
GitHub Login: @sideeksh
Microsoft Alias: v-ssenthilna

@ianc911 - Thanks again for bringing this to our attention. We have updated the Doc and it will be live once its merged.  We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


ERROR: This video is unavailable.

Please tick all applicable boxes.

[x] I am using Python 3.5.3 or higher (run python --version on the command line)
[x] I have followed the official guides to install the bot for my system
[x] I have updated my dependencies to the latest version using the appropriate update script

Which version are you using?

[x] The latest master version (release-260419)
[ ] The latest review version

What type of issue are you creating?

[x] Bug
[ ] Feature request
[ ] Question

Description of issue
Bot does not play some playlists for some unknown reason. This is the error that pops up:
Error
ERROR: This video is unavailable.
Just-Some-Bots/MusicBot (release-260419)
I've updated all dependencies and even tried uninstalling/reinstalling.
Steps to reproduce

Play a playlist. (https://www.youtube.com/playlist?list=PLWVJCKVGEJYEzKeFXWCooAK5Nl4ALOZVJ) for example.
Wait for bot to queue in songs
Get error mentioned above.
No songs end up being played.

Log file
Please attach your MusicBot log file (located at logs/musicbot.log) to this issue. You can do so by dragging and dropping the file here. If you do not include your log file, you WILL be asked to provide one.
musicbot.log

#1860


Description markdown support

Description
While creating a grant, the user needs to add a description of the grant. It would be great if the description can support markdown to make it look really good. This PR adds markdown support to the description.
This adds a markdown component that can be reused at any time. Along with that, it has 2 tabs, one for writing and the other for previewing the content in markdown.
Screenshots

Write Tab
Preview Tab

Failed to compile.
../tests/grants-program.ts:1:25
Type error: Cannot find module '@project-serum/anchor' or its corresponding type declarations.
> 1 | import * as anchor from "@project-serum/anchor";
    |                         ^
  2 | import { BN, Program } from "@project-serum/anchor";
  3 | import { encode } from "@project-serum/anchor/dist/cjs/utils/bytes/utf8";
  4 | import {
> Build error occurred
Error: Call retries were exceeded
    at ChildProcessWorker.initialize


How to contains header, footer, navigation, sidebar and other similar components to the layout?

Hi,guys! I have a question, In my project, How can I contains header, footer, navigation, sidebar and other similar components to the layout?
Thanks so much!

Not sure if I understand exactly what you're asking but in side the layout you can include components for ,  etc and then just render the children where you want.  For example:
function CoreLayout ({ children }) {
  return (

            {children}

  );
}

CoreLayout.propTypes = {
  children: React.PropTypes.element
};

export default CoreLayout;

What I do is actually wrap my routes in layouts sometimes.  For example I have all my routes that require a Navbar wrapped in a route that includes the navbar like this:
export default (
  <Route path='/' component={CoreLayout}>
    <Route component={NavLayout}>
      <IndexRoute component={HomeView} />
      <Route path='/about' component={AboutView} />
    </Route>
  </Route>
);

Hope this helps!

Not sure if I understand exactly what you're asking but in side the layout you can include components for ,  etc and then just render the children where you want.  For example:
function CoreLayout ({ children }) {
  return (

            {children}

  );
}

CoreLayout.propTypes = {
  children: React.PropTypes.element
};

export default CoreLayout;

What I do is actually wrap my routes in layouts sometimes.  For example I have all my routes that require a Navbar wrapped in a route that includes the navbar like this:
export default (
  <Route path='/' component={CoreLayout}>
    <Route component={NavLayout}>
      <IndexRoute component={HomeView} />
      <Route path='/about' component={AboutView} />
    </Route>
  </Route>
);

Hope this helps!

@SpencerCDixon thanks for the explanation, pretty much exactly what I was planning to say. @GangRock does that clear things up at all?

@SpencerCDixon thanks for the explanation, pretty much exactly what I was planning to say. @GangRock does that clear things up at all?

I'm sorry, I did not express clearly what my intent, but @SpencerCDixon reply is what I need.
thanks @SpencerCDixon and @davezuko


Allow closing the rectangle in the lower right corner of the screen

All I know is I am browsing
https://gdal.org/en/latest/drivers/vector/libkml.html
and in the lower right corner of the screen there is this:

blocking text.

No matter how I clicked, I could only make it bigger. I could not make it go away.
You might think "no big deal", but on my small screen it is blocking text and very annoying.
No I don't know who owns the website, and do not write documentation.
At least let people close it.

Thanks for opening this issue. I'm transferring it to the addons repository since this flyout is generated by Read the Docs Addons.
We will need to discuss this more internally, but I think it's probably a good idea to have a simple way to close the flyout.


Add ocp 4.8.2 cli support for ci against ocp 4.8

What does this PR do?

What's changed? Why were these changes made?
Added cli support for testing against OCP 4.8 by implementing v4.8.2 for the cli. Using older 3.* cli threw exceptions
when describing k8s resources in openshift.

How should the reviewer approach this PR, especially if manual tests are required?

Review pipeline (attached to this PR)
Review pipeline with TEST_OCP_NEXT enabled here
Review changes to CHANGELOG

Are there relevant screenshots you can add to the PR description?
N/A

What ticket does this PR close?
Resolves #[relevant GitHub issues, eg 76]
N/A
Checklists
Change log

[x] The CHANGELOG has been updated, or
[ ] This PR does not include user-facing changes and doesn't require a CHANGELOG update

Test coverage

[x] This PR includes new unit and integration tests to go with the code changes, or
The test against the OCP 4.8 (next) cluster is not new, per se, but has not been passing until these changes.

[ ] The changes in this PR do not require tests

Documentation

[x] Docs (e.g. READMEs) were updated in this PR, and/or there is a follow-on issue to update docs, or
[ ] This PR does not require updating any documentation

This PR stemmed from this JIRA task: ONYX-11430. Essentially, Infra wanted a test file that would test a set of projects against the OCP NEXT cluster.


Comment inference with type inference

Suggestion

🔍 Search Terms

Comment inference, documentation
✅ Viability Checklist

My suggestion meets these guidelines:

[x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
[x] This wouldn't change the runtime behavior of existing JavaScript code
[x] This could be implemented without emitting different JS based on the types of the expressions
[x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
[x] This feature would agree with the rest of TypeScript's Design Goals.

⭐ Suggestion
Infer documentation/comments for inferred types.
📃 Motivating Example
I heavily use functions with dependency injection - this frequently means having a unit version of a function, as well as a convenience version with some of the arguments already applied.
For example, let's say I have a function:
/**
 * Great documentation here!
 */
function cook(food: Food, spices: Spice[], pot: Pot, pan: Pan) {
  // ...
}

I might have lots of functions like these, all of them may have different dependencies.
Somewhere in the top layers of my application, I'm going to bootstrap my function dependencies using functional applications:
function bootstrap(pot: Pot, pan: Pan) {
  return {
    cook: (food: Food, spices: Spice[]) => cook(food, spices, pot, pan),
    cleanUp: () => cleanUp(pot, pans),
    // ...and so on...
  }
}

The problem here is, the documentation for the original function is lost.
I don't want to copy/paste all my documentation and maintain several copies. So I'm left with the choice of leaving the internal unit function undocumented, and explicitly writing out an interface for the bootstrap return-type, giving up the convenience of inference - or leaving the bootstrapped functions undocumented.
There aren't really good choices.
Could we have something like this maybe?
function bootstrap(pot: Pot, pan: Pan) {
  return {
    /** @inferdoc */
    cook: (food: Food, spices: Spice[]) => cook(food, spices, pot, pan),
    /** @inferdoc */
    cleanUp: () => cleanUp(pot, pans),
  }
}

This would follow the inferred type to it's type and infer (copy) the documentation from there.
We have something like this for classes with @inheritdoc, but nothing for functions.
💻 Use Cases

Everything. 😄
I don't know of any work-arounds - I would love to hear of any.
IDE support is crucial here. Not repeating documentation is important. Inference is important - I don't want repeated declarations. I'm already repeating the argument declarations, which isn't great, but I don't think there's any way around that? (It's possible the real issue here is that we need stronger inference for function types? Something that works better for very common patterns like functional applications? Might kill two birds with one stone.)

Related: #32392


wrongly tracing of Messages during production

Hey,
this middleware wrongly traces the producing of messages as well. While doing that it breaks the tracing of the outer request.
(trace) POST request
-> (trace) producing MessageA
-> (trace) producing MessageB
in the end we have traces of MessageA and B but a wrong/missing trace for the HTTP Request.
The middleware should only be active when processing Messages and not when producing them.
I think a safeguard like
if (!$envelope->all(ReceivedStamp::class)) {
    // don't profile sent messages, only received
    return $stack->next()->handle($envelope, $stack);
}

would be enough? If yes, i could provide the PR.

Indeed, in #3 we already added a second middleware to solve this problem https://github.com/tideways/symfony-messenger-middleware/blob/master/src/TidewaysOnlyConsumedByWorkerMiddleware.php - but this is not yet documented.

thanks @beberlei maybe reading the code would have helped ;)


Fixed Issue#111: Connection stays open after FTP upload

Fixed a truncated uploaded file.
・After byte data upload was completed, it was necessary to close the data connection.
・In addition, it was necessary to wait for FTP response code 2xx and discard the data connection.
The flow of FTP uploading is described below.

STOR filepath → (FTP Server)1XX responsed → byte data upload → close data connection → (FTP Server)2XX responsed → discard data connection(deinit)

I checked upload, but not checked download sequence.(I'm sorry, I Don't have much time)

Thanks great work


Implement the Git REPL mode

Fixes #21
Fixes #27

@giordano Want to give the Git REPL mode a try and see what you think?

bors merge

I'm going to merge it into master, but with the version number at a prerelease 0.3.0-DEV.

bors merge

bors merge

bors merge-

bors merge

bors merge

I tried "using GitCommand" and then "," with #b5db541, but nothing seems to happen. Do I need to do anything else to try this?

I tried "using GitCommand" and then "," with b5db541, but nothing seems to happen. Do I need to do anything else to try this?

Step 1: using GitCommand
Step 2: gitrepl()
Step 3: Press , to enter Git REPL mode

Why is CirrusCI refusing to report the FreeBSD JULIA_VERSION:1.3 status? The build passed. And they reported the FreeBSD JULIA_VERSION:nightly status. But I need both to be reported in order for the PR to pass.

bors merge-

bors merge

bors merge

There's clearly some problem with CirrusCI pushing statuses to GitHub.

bors merge

Codecov Report

Merging #26 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master    #26   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           6      7    +1
  Lines          43     37    -6
=====================================
- Hits           43     37    -6

Impacted Files
Coverage Δ

src/GitCommand.jl
100% <ø> (ø)
:arrow_up:

src/git_repl.jl
100% <100%> (ø)

src/public.jl
100% <100%> (ø)
:arrow_up:

src/util.jl
100% <0%> (ø)
:arrow_up:

src/env_mapping.jl
100% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e8a9fd...62a85e2. Read the comment docs.


Simplify Subcommand::run

The Subcommand::run function is a bit messy because it needs to handle the case where fallback is enabled and a missing recipe triggers searching for a new justfile further up the directory tree. This commit attempts to simplify the loop within Subcommand::run and make the logic generally easier to understand.

Won't this lead to double compiling the first justfile, since it's already compiled before we call run?

Won't this lead to double compiling the first justfile, since it's already compiled before we call run?

Whoops, yeah. Added a commit that fixes this.

Nice, this is a great simplification!


[workflow] Group all linters into one workflow

Signed-off-by: Martin Bašti<EMAIL_ADDRESS>Maintainers will complete the following section

[ ] Commit messages are descriptive enough
[ ] Code coverage from testing does not decrease and new code is covered
[ ] JSON/YAML configuration changes are updated in the relevant schema
[ ] Changes to metadata also update the documentation for the metadata
[ ] Pull request has a link to an osbs-docs PR for user documentation updates
[ ] New feature can be disabled from a configuration file

No release notes, CI change only


Bugs,Minor Issues,Fixes Guidelines

Guidelines above mentioned issues goes here

I want to work on this issue. Please assign to me

@Simar05519 This is only guidelines,not a issue..I have to update it,pls claim a unassigned issue


Remotely invoked MapReduce Jobs need to be able to specify additional JARs on classpath

The recommended method to do this is to to put the JARs in HDFS and add them to the Job's classpath.  Most of the work can be done by the invoker, but as the Job objects are being created within the Tool implementations, GeoWave needs an option to add the JARs to the classpath of the Job.

Merge fixes the problem for the KDEJobRunner, but the issue still exists for the other tools.  If they are to be remotely runnable, they should have a similar capability.

Isn't there a hadoop option to do this?  Like HADOOP_CLASSPATH or something?


Newby: undefined function mongo:connect/1

I followed the README and got stuck at trying to connect to my local instance with no auth.
$  erl -pa mongodb/ebin mongodb/deps/bson/ebin
Erlang R15B01 (erts-5.9.1) [source] [64-bit] [smp:4:4] [async-threads:0] [hipe] [kernel-poll:false]

Eshell V5.9.1  (abort with ^G)
1>  application:start (bson).
ok
2>  application:start (mongodb).
ok
3> Database = <<"test">>.
<<"test">>
4> {ok, Connection} = mongo:connect (Database).
** exception error: undefined function mongo:connect/1

the compile went fine, without errors.
Any suggestions?
p.s. i read the issue from 2 years ago that the api may have changed, but I saw the README being updated today, so I assume it correct now...

erl -pa ebin/ deps/bson/ebin/
  Erlang/OTP 17 [erts-6.4] [source] [64-bit] [smp:8:8] [async-threads:10] [hipe] [kernel-poll:false]

  Eshell V6.4  (abort with ^G)
  1> application:start(bson).
  ok
  2> application:start(crypto).
  ok
  3>  application:start(mongodb).
  ok
  4> mongo:connect(<<"test">>).
  {ok,<0.45.0>}

Everything seems to be working.
Did you run make in mongodb-erlang directory?
In the last (tooday commit) version crypto application and one more dependency (pbkdf2) were added. But their lack should not rise exception as you post.

I tried the exact steps again and the result is the same. I'm running it with erleng R15B01 and you run 17. Could that be the issue?

ok, I see. You clone wrong repo.
git://github.com/mongodb/mongodb-erlang.git is old one, not supported.
Use https://github.com/comtihon/mongodb-erlang.git
It is former mongodb's repo, transfered to me (you can see it on mongodb-drivers official page).
Also I advice you to switch to newer erlang, as this driver may not support <16 version.

Yeah, that was it!
I made a PR to correct the readme ;-)
https://github.com/Elexy/mongodb-erlang/pull/1

how to fix this?
sudo ejabberdctl debug
Erlang R16B03 (erts-5.10.4) [source] [64-bit] [async-threads:10] [kernel-poll:true]
Eshell V5.10.4  (abort with ^G)
(ejabberd@localhost)1> Database = <<"test">>.
<<"test">>
(ejabberd@localhost)2> {ok, Connection} = mongo:connect (Database).
** exception error: undefined function mongo:connect/1

Please, check if mongo:connect:1 exists in repo you cloned. May be you cloned wrong repo, as above.
Also check, if source server can load mongo module - may be mondodb-erlang/ebin is not included.
Finally - check if you built mongodb-erlang.


API Add streamable response object

Part 1/2 of fix for https://github.com/silverstripe/silverstripe-framework/issues/5462
Part 2 at https://github.com/silverstripe/silverstripe-assets/pull/18

I've added that assertion; I don't think tests will pass for a while until travis gets better. =(


Fix problem with C++ extractor ernoneous concating of type tokens

When producing text from a stream of token care must be taken, as some concats can change meaning.
For example previously
'Thing' 'const' '*' -> Thingconst*

The change checks consecutive token types and adds a space if needed.

I assume this comes up because the representation of types in the extractor is currently just an unstructured sequence of tokens rather than anything like C++ declarator syntax?

Yes. This is a fairly ad hoc solution. If the complexity gets much higher, just outputting spaces might be ticket.


better communicate transmission of value (tips, supports)

[ ] On file pages
[ ] To creators via notifications

We don't have signed supports (requires https://github.com/lbryio/types/issues/32), but we do have this information on resolves which could help clear up some things in the meantime:
            resolve <urls>... [--wallet_id=<wallet_id>]
                    [--include_purchase_receipt]
                    [--include_is_my_output]
                    [--include_sent_supports]
                    [--include_sent_tips]
                    [--include_received_tips]

        Options:
            --urls=<urls>              : (str, list) one or more urls to resolve
            --wallet_id=<wallet_id>    : (str) wallet to check for claim purchase reciepts
           --include_purchase_receipt  : (bool) lookup and include a receipt if this wallet
                                                has purchased the claim being resolved
            --include_is_my_output     : (bool) lookup and include a boolean indicating
                                                if claim being resolved is yours
            --include_sent_supports    : (bool) lookup and sum the total amount
                                                of supports you've made to this claim
            --include_sent_tips        : (bool) lookup and sum the total amount
                                                of tips you've made to this claim
                                                (only makes sense when claim is not yours)
            --include_received_tips    : (bool) lookup and sum the total amount
                                                of tips you've received to this claim
                                                (only makes sense when claim is yours)```


persian calendar

it's not possible to use Persian dates in kalendar?

@javad0470 Clone the repo and make a custom version of it, it's actually not that hard, but requires some changes to formatting.


DKImage how do i upload it to a url??

i couldnt find a way to upload the picture file to a url. please help

You have to write the picture to Documents directory by using:
public func writeImageToFile(path: String, completeBlock: (success: Bool) -> Void)

or
public func writeAVToFile(path: String, presetName: String, completeBlock: (success: Bool) -> Void)

then upload it to your server.

sorry but i am a bit confuse what i am suppose to put in the completeBlock
here is what i have done
let path = “http://localhost/swift/upload.php”
// when i change the completeBlock to true i got an error. did i do something wrong or do i need to put something else inside {}
public func writeImageToFile(path: path!, completeBlock: true){
}

On Aug 4, 2016, at 1:58 AM, Bannings<EMAIL_ADDRESS>wrote:
You have to write the picture to Documents directory by using:
public func writeImageToFile(path: String, completeBlock: (success: Bool) -> Void)
or
public func writeAVToFile(path: String, presetName: String, completeBlock: (success: Bool) -> Void)
then upload it to your server.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/zhangao0086/DKImagePickerController/issues/162#issuecomment-237459904, or mute the thread https://github.com/notifications/unsubscribe-auth/AS4dPaJzYEBrT-uKoQ-SVq8dvuD31tc_ks5qcX9_gaJpZM4Jb4E-.

Hi @biotechpro7
The path must to be the local path. e.g. Documents or tmp.
You should write the selected picture to the Documents or tmp, then uploading it to your server via AFNetworking or other:
let writePath = (NSTemporaryDirectory() as NSString).stringByAppendingPathComponent("1.png")

assets.first?.writeImageToFile(writePath, completeBlock: { (success) in
    if success {
        // uploading to your server
    } else {
        // ...
    }
})

See also:Creating an Upload Task


MTSDK-75 Deliver State.Closed while Reconnect on Android.

Manually report State.Closed when websocket.close() graceful shutdown was not initiated by this call. (for example: close during reconnection).

Jenkins had a successful build.


⚠ Bofrost.fr has degraded performance

In 9e2f26e, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 868 ms

Resolved: Bofrost.fr performance has improved in d08e890 after 6 minutes.


support for encrypted HTTP upload

Not sure, if this is in the scope of this module. Close for now.


Backmerge/release/november 2024 2024 12 03

:x: There is undocummented changes. Run chronus add to add a changeset or click here.
The following packages have changes but are not documented.

:x:@azure-tools/typespec-client-generator-core

Show changes

You can try these changes here

🛝 Playground
🌐 Website
📚 Next docs


Gate facade missing on composer update

When updating to Laravel 5.1.12 via composer, the Illuminate\Support\Facades\Gate class is missing from vendor.
Works fine when using create-project laravel/laravel , though.

No it's not. https://github.com/laravel/framework/blob/v5.1.12/src/Illuminate/Support/Facades/Gate.php.


Suppress numpy warning during uarray creation

Suppress invalid value warning from numpy during data processing
When handling level one data, DataProcessor would produce a numpy warning about
an invalid value. Briefly, the reason the warning is emitted is that
uncertainties calls numpy.vectorize which calls
uncertainties.core.Variable from within numpy C extension code. Variable
does a std_dev < 0 check and DataProcessor sets std_dev initially to
nan. When the CPU does a floating point comparison with nan, it sets an
exception flag. Python ignores this flag, but numpy emits a warning, so when
Variable is created from within the numpy C code the warning is detected and
emitted. As we know this chain of events will happen, we can simply ignore the
warning for this operation.

This PR will eliminate the remaining warnings issued by sphinx when building the docs in #983 and so allow us to use -W to make future warnings fail the docs build, so that new warnings do not creep in.

This looks good to me but I want @nkanazawa1989 to have the chance to look it over too.


Add sync for grpc-gateway

@unmultimedio looks correct
https://github.com/bufbuild/modules/pull/56


Fix documentation for newline-output option

Documentation says "newline-handling" but the actual option in the code is "newline-output"

Thanks!


Changed max len of cluster name to not hit max len for AWS ELB name

Shortened suffix on ELB to -api (to let cluster names be as long as possible considering the ELB limits).
Fixes: https://github.com/samsung-cnct/kraken-lib/issues/883

@coffeepac should we be handling any backwards compatibility for this change?

oh hey, good point, re: backwards compat.  this change will mean we can't tear down any pre-existing clusters cleanly as terraform will be looking for the old name.
might be easier to leave the name suffix alone and set the cluster name length to be 22  :/  Unless you have an idea for how to handle this transition?

I think that is the cleanest approach. I will amend this. @coffeepac

@coffeepac this passed CI


bug: incorrect table_stats for state table "_dynamicfilterleft"

Describe the bug
No response
Error message/log
No response
To Reproduce
CREATE TABLE t2 (ts timestamptz, v INT);
CREATE MATERIALIZED VIEW mv2 AS SELECT * FROM t2 WHERE ts > now() - INTERVAL '1m';
INSERT INTO t2 VALUES (now(), 1);
...after 2 minutes
SELECT * FROM rw_table_stats; -- size of __internal_mv2_N_dynamicfilterleft_M is expected to be 0, but it's not.
Expected behavior
No response
How did you deploy RisingWave?
No response
The version of RisingWave
No response
Additional context
No response

It should be caused by SkipWatermarkIterator doesn't update table stats upon dropping entries.


[terra-data-grid] Create base FlowsheetDataGrid component

Summary

What was changed:
Added new FlowsheetDataGrid component, using newly created DataGrid component as a base. This component accepts one row header column that is always pinned, and does not allow resizing of columns. Also added FlowsheetDataGrid as an export from the main entrypoint (index.js) of the package.
Why it was changed:
This will serve as the starter component needed to begin implementing an accessible flowsheet-style data grid. More features are to be added in future updates.
Testing

This change was tested using:

[x] WDIO
[x] Jest
[ ] Visual testing (please attach a screenshot or recording)
[ ] Other (please describe below)
[ ] No tests are needed

Reviews
In addition to engineering reviews, this PR needs:

[ ] UX review
[ ] Accessibility review
[ ] Functional review

Additional Details

This PR resolves:
UXPLATFORM-9401

Thank you for contributing to Terra.
@cerner/terra

Not sure if it was introduced in this PR but the cells seem to be clipping a bit of the bottom of the text
I'm noticing this as well with Worklist Data Grid when I make the column small enough

This seems to be because the line-height doesn't evenly fit within the available space to fit in two lines. Would we possibly want to change the default row height of DataGrid to better accommodate two rows of text?

@smason0  Added the Functional Review label, right now looks good but like Eric indicated this is just the beginning with more functionality to be added to it so it definitely an incomplete review at this point. Will perform additional functional reviews on future PR's


Buffer deprecation warning

(node:197482) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
    at showFlaggedDeprecation (buffer.js:192:11)
    at new Buffer (buffer.js:279:3)
    at PDFDocument._write (/node_modules/pdfkit/js/pdfkit.es5.js:6037:1)
    at new PDFDocument (/node_modules/pdfkit/js/pdfkit.es5.js:5890:1)

pdfkit version: 0.11.0
Node version: v14.3.0
Operating System: Ubuntu 20.04

Fixed by commit https://github.com/foliojs/pdfkit/commit/ba62aeff11403012a019b150f065d893fdfbc0c1.


couple feature requests

Some features that would be great to have
Useful:

Keep/remember scroll position when going in and out of albums
Sorting directly on the playlist, newest/last added songs etc (annoying to scroll back to song position constantly
Link to a song/queue directly for sharing music
Sorting/order songs in the queue list by dragging

Not as important

View and or edit file metadata (can only see media type/bitrate when viewing big album cover)
Start radio/mix based on similar songs

Overall great app and cool that it remembers the last state when relaunching.

It would also be a plus if it was easier to tell if a song was favorited or not (cumbersome having to hover or play a song to see that).


Support for Qwen reward model via VLLM

This PR adds the support for Qwen RM in sync with the current reward model support.
Tbh I'm not completely happy with some of the design choices for input_file/dir-output_file/dir specification.
So happy to update the PR as we discuss.

This PR adds the support for Qwen RM in sync with the current reward model support. Tbh I'm not completely happy with some of the design choices for input_file/dir-output_file/dir specification. So happy to update the PR as we discuss.

Can you please add more details on what you'd change / what's not convenient?

Can you please add a test similar to this one https://github.com/NVIDIA/NeMo-Skills/blob/main/tests/gpu-tests/test_generate.py#L31? Here is an example for nemo-inference (fused with training test) https://github.com/NVIDIA/NeMo-Skills/blob/main/tests/gpu-tests/test_train.py#L251

This PR adds the support for Qwen RM in sync with the current reward model support. Tbh I'm not completely happy with some of the design choices for input_file/dir-output_file/dir specification. So happy to update the PR as we discuss.

Can you please add more details on what you'd change / what's not convenient?

The input_dir option is introducing dependency on too many hardcoded things. The file name has to conform to a certain logic. https://github.com/NVIDIA/NeMo-Skills/blob/main/nemo_skills/inference/reward_model.py#L70
I don't think this is a good idea. Also, currently the codebase assumes that without the random_seed specified, the output_file is output.jsonl whereas it is output-greedy.jsonl. But in any case, I don't think this is a good design practice.
The input_file option currently requires the output_file to be specified as well - https://github.com/NVIDIA/NeMo-Skills/blob/main/nemo_skills/inference/reward_model.py#L74
Right now reward model scoring is using the generate pipeline. The generate pipeline requires the output_dir option because of checks like this - https://github.com/NVIDIA/NeMo-Skills/blob/main/nemo_skills/pipeline/generate.py#L136
So with input_file you need to specify output_file and output_dir as well which feels redundant to me.
My suggestion:  I personally like the option of specifying input_files and output_dir.
The output_file would simply use the filename of the input_files with its directory being output_dir

Let's keep this PR without argument changes, and discuss more next week - we can do it in a follow-up PR

Let's keep this PR without argument changes, and discuss more next week - we can do it in a follow-up PR

Sounds good!

@Kipok - Added the test for reward models. Let me know if the prompt construction needs work.

Please update qwen/... prompts as we now need to use \\boxed{{}} in their system message

Merging for now. Most of the PR is reviewed. The only minor unreviewed change is in tests/gpu-tests/test_reward.py


Add License

Would be clearer to the devs contributing to the project as to how their code is being used and how it can be further used. Lmk what you think @rakesh-verma-16 @nemanjaglumac .
Personally, I prefer the MIT LIcense..

100%!
Don't know how I missed it in https://github.com/AaruBama/memestr/issues/52. That's one of the main things every OSS project must have.

@abhay-raizada @nemanjaglumac LMK if it looks good, I'll merge it.
Would also be mergine some other PRs tonight.

Merged the PR. Feel free to reopen if needs any update.


UI issue in calendar picker

UI issue in calendar picker (using chrome latest version): http://screencast.com/t/uZUc4bfxf1b

@wyattsweet this might be a good issue as a first contribution 😄


Support new HPO URL patterns in jax.org

Problem
I noticed this announcement on the website of the HPO ontology website:

We are currently moving our ontology API to https://ontology.jax.org and expect to fully switch by November 31, 2023 (this date is not firm). Please feel free to use this new API, however term annotation endpoints have not yet been moved.

I assume that could break a few things in Sodar, if no adjustments are made, so this issue is meant as a warning or maybe simply a reminder (I'm also really unsure if this fits bug report of feature request better ...)
Solution
References to the current API endpoint need to be identified & updated once HPO actually moves their ontology.

Can you link me to the original announcement? Is there some indication that the ontology will removed from obolibrary.org which we currently link to?
SODAR does not use the API but, instead, imports ontologies locally and uses its own internal Ajax views to search for ontology terems. This saves us the trouble of interfacing with different, potentially unstable APIs.
Unless HPO is removed from obolibrary, this should not affect SODAR.

Ok, so it appears that:

Obolibrary now forwards URLs to jax.org, so "pure" old ololibrary URLs still work
However, bioportal.org doesn't (yet?) support the jax.org URLs
This results in a 404 in bioportal if the new type of URL is used in the term accession

I need to do a workaround to ensure both old and new URLs work. For now, perhaps just omitting the wrapper if a new-style accession URL is used.
The default accession pattern on the production server should probably be also updated to the new jax.org pattern.


Remove support for Oraclelinux

I'm not aware of anyone using it and too annoying to support as there no support for development packages.
Discussed in the opam-repository maintainers meeting (e.g. https://github.com/ocaml/opam-repository/pull/24360)
I think this is probably something we want to remove from ocaml-dockerfile as a whole, as the same failures will happen in OCaml-CI too.

Hi.
This PR also removed support for Centos 7, does the same argument apply to it?


Update RUN statements in Dockerfile.j2

Issue Type

Feature request

Molecule and Ansible details
ansible <IP_ADDRESS>
molecule, version <IP_ADDRESS>rc11

Molecule installation method: pip
Ansible installation method: brew

Desired Behaviour
Multiple RUN statements result in multiple layers created, even though they do not increase image size. I propose to join them into one single RUN as follows:
RUN if [ $(command -v apt-get) ]; then apt-get update && apt-get upgrade -y && apt-get install -y python sudo bash; \
    elif [ $(command -v yum) ]; then yum makecache fast && yum update -y && yum install -y python sudo yum-plugin-ovl bash && sed -i 's/plugins=0/plugins=1/g' /etc/yum.conf && yum clean all; \
    elif [ $(command -v zypper) ]; then zypper refresh && zypper update -y && zypper install -y python sudo bash; \
    elif [ $(command -v apk) ]; then apk update && apk add python sudo bash; \
    elif [ $(command -v pacman) ]; then pacman --sync --noconfirm --refresh python2 bash; \
    elif [ $(command -v dnf) ]; then dnf makecache fast && dnf --assumeyes install python python-devel python2-dnf bash; \
    elif [ $(command -v emerge) ]; then emerge --ask n =dev-lang/python-2\* gentoolkit; fi

Other changes (most are rather cosmetic):

added yum clean all to reduce image size (from 331MB to 244MB for centos 7)
removed touch /var/lib/rpm/* -- wasn't able to found it's purpose
replaced -x "$(command -v yum)" with simple $(command -v yum) -- exit code 0 equals true anyway
removed /bin/sh -c -- seems to me it does not have any visible effect, but increase clutter instead.
replaced ; with && for dnf

I could create PR if needed.

I could create PR if needed.

Please do

PR created: #891

Implemented.