How to get this to match the original theme?

When viewed side-by-side, the same file looks different with this theme compared to GitHub or the VS Code theme (or Helix). Is there a way to fix this? I am not well versed on themes or colors so I cannot override myself.

Are you using the latest version/release of this plugin? And are you using treesitter for highlighting (and have it setup properly)?

I am on the latest release of the theme.  I use treesitter on stock settings. For comparison, below is how the same code looks like on GitHub vs Neovim on GitHub dark default.
GitHub

Neovim

Yes I am on the latest release and treesitter works (default configuration). Although I just did a more thorough comparison and Helix doesn't seem to match GitHub either.
I guess this is caused by the subtle differences in parsing?

The syntax highlights should be quite close for most common langs. Getting them 100% accurate takes alot more work. Which lang are you having issues with? Can you post a screenshot?

hi, here's a comparison of a struct in rust between neovim using this theme (either dark default on v0.0.7 or dark high contrast on master, they look the same) vs. vscode using the original theme. (ignore the black background on neovim, it's tranparent).
neovim:

vscode:

The neovim screenshot looks fine to me.
The goal of this theme should be to recreate Github's themes as closely and accurately as possible (while trying to make good decisions in edge-cases where Github's theme is lacking). The goal is not to follow the vscode version and inherit the inaccuracies of their own recreation. Please compare colors against GitHub's website directly.
According to your vscode screenshot, the vscode version has incorrect highlights for :, as well as struct fields and {} brackets.

Huh, you are right that its actually vscode that doesn't match with GH. That's surprising. Although I still think that vscode has a more natural look so I will look into configuring it myself. Thank you!

The biggest difference on display here is essentially the color/highlights of (struct) fields. When it comes to the current "GitHub theme", fields/props are usually either unhighlighted, or highlighted with a blueish color (the exact color depends on the specific theme/variant), depending upon the language. Idk why a few langs don't have highlighted fields (maybe that's the actual intent of GitHub, or maybe it's simply an accident or due to shortcomings); but for rust, fields do get highlighted.
IMO, there's both pros and cons to having these sort of extra highlights. On one hand, it can make the distinction between syntax elements easier to discern, on the other, too many highlights (or different colors) can quickly become overwhelming or distracting. So it can be sort of a subjective question and catch 22 for what's best.


Update Stable to v6.0.0 on dev

Description

v6.0.0 was released on 04-29-2020
update stable on dev

Issues:
https://github.com/vulk/cncf_ci/issues/343
How has this been tested:

[ ]  Covered by existing integration testing
[ ]  Added integration testing to cover
[ ]  Tested with trigger client against

[ ]  cidev.cncf.ci
[ ]  dev.cncf.ci
[ ]  staging.cncf.ci
[ ]  cncf.ci (production)

[ ]  Browser tested on staging.cncf.ci
[x]  Have not tested

Types of changes:

[ ]  Bug fix (non-breaking change which fixes an issue)
[ ]  New feature (non-breaking change which adds functionality)
[ ]  Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] Version update

Checklist:

[ ]  My change requires a change to the documentation
[ ]  I have updated the documentation accordingly
[x]  No updates required

@lixuna - I am not seeing V6.0.0 in the build pipeline.  Only v6.0.0-rc.1 and v6.0.20200429

@ashleighgregory Vitess has not created a tag for v6.0.0 yet. The latest is v5.0.1

v5.0.1 has been added to dev by will.

Thanks @lixuna.  Please can you provide a link to their correct release page.
I have the two below.  One doesn't list anything and the other I understood at V6.0.0.  I'm obviously looking in the wrong place.

https://github.com/crosscloudci/vitess-configuration/releases
https://github.com/vitessio/vitess/releases

Thanks for sharing so I can update my notes.


Spring handson 5

Metric
Value

alert_status
:white_check_mark: OK

bugs
0

code_smells
2

reliability_rating
A (0 Bugs)Note: A being best, E being worst

security_rating
E (at least 1 Blocker Vulnerability)Note: A being best, E being worst

vulnerabilities
1


Provide display options for columnType

Currently when you want to display a "$" sign or "%" you've got to change the raw data:
 customColumnTypes='[
  {
    "name": "Custom type",
    "customTextProcessing": {
      "changeTextFunc": "(cellText) => `$${Number(cellText.replace(/[^0-9.-]+/g,\"\"))}`",
      "changeStyleFunc": "(cellText) => {
        const moneyNumber = Number(cellText.replace(/[^0-9.-]+/g,\"\"));
        if (moneyNumber < 20) return {backgroundColor: `#ff3232`};
        if (moneyNumber < 100) return {backgroundColor: `#ffff00`};
        return {backgroundColor: `#00ac00`};
      }"
  }}]'

So for example 0.12 should show as 12%. However to get it working you need to change the actual value to 12%. This is bad when when you have to send it back to a server.
Recommendation for a  "changeDisplayFunc" function. It would happen after changeTextFunc (for example cleaning data to only display numbers). In the example 0.12:

customColumnTypes='[
  {
    "name": "Percentage",
    "customTextProcessing": {
      "changeDisplayFunc": (cellText) => `${Number(cellText) * 100 }%`
  }}]'

Love working with the system by the way much easier to use than tanstack tables. Especially for working with simple row data.

Hi @jeffreygaggino.
The changeTextFunc property already serves as a post-processor/cleanup function.
I don't think I fully understand the problem that you are describing, could you elaborate on how does it make it difficult to send data to the server? Or could you perhaps illustrate the step by step process that is causing the difficulty.
Thanks!

Front end wise I want to show 12% to the user. At least from my understanding with using the table it seems like I've got to change the actual data to "12%". I would rather want to keep the data to be 0.12 and show to the user "12%". So have a function that doesn't mutate the original value of 0.12 but allows regex / text transformations to display 0.12 as "12%"

Here's a couple of images to illustrate this:
Editing:

Display when not editing:

Hi,
From what I understand changeTextFunc is only called when the cell value actually changes. Exposing "cell-focus" and "cell-blur" events might allow two way conversion.


[Feature Request] mwc-snackbar configurable position

Current snackbar implementation dosen't allow for any flexibility in terms of positioning. It's either leading or in the middle of the viewport.
If we have UI controls at the bottom of the page, the snackbar will just overlap it, which isn't ideal. The same goes if we have some kind of panel, be it on the right, or left.
Would be nice to have an option for the snackbar to be dependant not only from viewport, but from the parent component. Or at least to be able to control snackbar elevation.

Thanks for the issue!
There are several configurable styles from the MDC snackbar that we should expose a CSS custom properties, such as:

--mdc-snackbar-container-color
--mdc-snackbar-label-color
--mdc-snackbar-z-index
--mdc-snackbar-viewport-margin
--mdc-snackbar-min-width
--mdc-snackbar-max-width

We could also look into splitting viewport-margin into separate mixins/variables to control left/right margin and the bottom margin.

@asyncLiz  any progress on this? Would need at least to set z-index on the snackbar, otherwise the component is quite useless...


Mozilla.Firefox.ESR version 102.6.0

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?

[x] Does your manifest conform to the 1.2 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

A slightly limited (installer types and languages) updated manifest due to security issues in the previous version. My apologies for my limited resources.


[Bug]: Logic error when using trust_account_ids in the config file

Steps to Reproduce
I took a look at the logic, and there seems to be 2 different bugs. One in vpc_endpoint_connections_trust_boundaries.py logic, and one in the is_account_only_allowed_in_condition logic
Disclaimer that I didnt spend that long on this, but took a look at the code, and did some debugging on is_account_only_allowed_in_condition's logic - I might be missing something, but Im fairly confident in my analysis.
Here is the source code for the check: https://github.com/prowler-cloud/prowler/blob/master/prowler/providers/aws/services/vpc/vpc_endpoint_connections_trust_boundaries/vpc_endpoint_connections_trust_boundaries.py#L5
What we are interested in is the check for a condition on line 36, and then invoking is_account_only_allowed_in_condition on line 38 (similar logic on line 71 and 103)
Also worth noting line 14 where trusted_account_ids is obtained from the config file, and the current account is added to the list on line 16
In order to pass the check (access_from_trusted_accounts = True) we would need to have all the account_id values inside trusted_account_ids return true when the condition block and the account_id  is passed to is_account_only_allowed_in_condition
Taking a look at is_account_only_allowed_in_condition  from here: https://github.com/prowler-cloud/prowler/blob/master/prowler/providers/aws/lib/policy_condition_parser/policy_condition_parser.py
The line 21 defines a map between valid condition operators, and valid condition values.
Skipping ahead, the important part that we need to pass is either the for loop on line 60 if the input is a list, or line 70 if its a string
Lets take a look at these 2 cases:
If its a string (we perform the check on line 70)
So in this case, the condition element is not a list. Ie, in python:
condition_statement = {
    "StringLike": {
        "AWS:SourceAccount": "111122223333"
    }
}

is_account_only_allowed_in_condition(condition_statement,"111122223333") returns True
is_account_only_allowed_in_condition(condition_statement,"111122225555") returns False
Seems like everything is working correctly.
But if you go back to vpc_endpoint_connections_trust_boundaries.py, you will see that on line 37 this check needs to pass for ALL trusted_account_ids
This seems to be a logic mistake. If you put the following in the config file:
trusted_account_ids: ["111122223333", "098765432109"]

And have the same condition statement as above, the first iteration of the for loop will pass, but the 2nd iteration of the for loop will fail, access_from_trusted_accounts will be set to False, and the break statement will be hit => we will fail the check when it should pass

If its a list (we perform the check on line 60)
Lets take a look at is_account_only_allowed_in_condition. If the condition statement is like this:
( I know users arnt applicable in this case - I just took the example condition statement from this: https://docs.aws.amazon.com/IAM/latest/UserGuide/reference_policies_condition-logic-multiple-context-keys-or-values.html - but the logic still applies)

condition_statement = {
    "ArnLike": {
        "AWS:PrincipalArn":  [
            "arn:aws:iam::111122223333:user/Ana",
            "arn:aws:iam::111122223333:user/Mary"
        ]
    }
}

is_account_only_allowed_in_condition(condition_statement,"111122223333") will result in a True result
Okay cool, that seems to check out.
But similar to the above issue regarding a string, when the trusted account ids in vpc_endpoint_connections_trust_boundaries.py are being looped through, the next iteration will send<PHONE_NUMBER>09, the result will be false, access_from_trusted_accounts will be set to False, and the break statement will be hit => we will fail the check when it should pass
But there is also an issue with line 60 in is_account_only_allowed_in_condition.
If we have listed<PHONE_NUMBER>09 and<PHONE_NUMBER>33 as trusted accounts (as in the above example config file line), then we should be able to do something like this
condition_statement = {
    "ArnLike": {
        "AWS:PrincipalArn":  [
            "arn:aws:iam::111122223333:user/Ana",
            "arn:aws:iam::098765432109:user/Mary"
        ]
    }
}

But now is_account_only_allowed_in_condition(condition_statement,"111122223333") would fail, because each item in the list needs to pass the check on line 61
is_account_only_allowed_in_condition(condition_statement,"098765432109") would also fail due to the same reasons
Solution: Seems like we need a separate implementation for is_account_only_allowed_in_condition that can take a list of trusted_account_ids in as a param
for 1: check if ANY of the trusted account ids pass the check on line 66
for 2: determine if there are any items in the list that do not fall within the trust account ids - and remove the for loop from line 60 (and 71/103) in vpc_endpoint_connections_trust_boundaries.py
Expected behavior
The check should pass if the condition statement only contains account ids, or principals within accounts, that are listed in the trusted_account_ids list in the config file
Actual Result with Screenshots or Logs
I did not actually run this - just investigated the feedback in the ask-a-question channel in slack.
How did you install Prowler?
From pip package (pip install prowler)
Environment Resource
Other: Did not actually run it. Pulled some logic into individual files for debugging purposes
OS used
Debian
Prowler version
Latest
Pip version
NA
Context
Original response in slack: https://prowler-workspace.slack.com/archives/C0451NDLC4X/p1699276325100359
Original bug report in slack: https://prowler-workspace.slack.com/archives/C0451NDLC4X/p1699268921121009

Hi @Fennerr , thank you so much for all the study and information!
Recently, @mtronrd fixed most of this issues in https://github.com/prowler-cloud/prowler/pull/3006, can you try it again in master?

Hi @Fennerr, could you please test this out again in the master branch and let us know if this is fixed?
Thanks!

I’m closing this issue. Please feel free to reopen it if you notice that behaviour again.
Thanks for using Prowler 🚀


Allow for initialising a pool without starting it

Maybe fixes #123
It's not perfect however: https://youtu.be/Oo_L_MHvEmo. In the video pb.go is:
package main

import (
	"math/rand"
	"os"
	"sync"
	"time"

	"github.com/wjessop/pb"
)

func main() {
	// create bars
	first := pb.New64(1000).Prefix("one ").SetUnits(pb.U_BYTES)
	second := pb.New64(1000).Prefix("two ").SetUnits(pb.U_BYTES)

	first.Output = os.Stderr
	second.Output = os.Stderr

	// start pool
	// pool, err := pb.StartPool(first, second)
	pool := pb.NewPool()
	pool.Output = os.Stderr
	err := pool.Start()
	if err != nil {
		panic(err)
	}

	// update bars
	wg := new(sync.WaitGroup)
	for _, bar := range []*pb.ProgressBar{first, second} {
		wg.Add(1)
		go func(cb *pb.ProgressBar) {
			for n := 0; n < 200; n++ {
				// cb.Increment()
				time.Sleep(time.Millisecond * time.Duration(rand.Intn(100)))
				cb.Add(5)
			}
			cb.Finish()
			wg.Done()
		}(bar)
	}
	wg.Wait()
	// close pool
	pool.Stop()
}

Thank you! Merged
first.Output = os.Stderr
second.Output = os.Stderr

But these lines in example don't make sense. Only pool.Output has an effect in multiple bars case

Any idea why the second run (see video) prints out three lines instead of two? It happens to me when running the example about 50% of the time.

@wjessop how are you stopping the program?
pool waits to Interrupt signal for correct stop (or call pool.Stop() )

I'm running the program with:
go run pb.go

Go version go version go1.10 darwin/amd64
I'm just letting the program exit normally, so pool.Stop() should be getting called on the second to last line of the code above.

Oh, I'm running your code whole and see the same result.
It's the small mistake in your code, you forgot to add bars objects to  pb.NewPool
Just replace to pb.NewPool(first, second).
And I think I found new bug... in go 1.10 pool does not sense stop with ctrl+c (in go 1.9 all ok)

When I add the progress bars to the pool the output it works as expected:
pool := pb.NewPool()
pool.Output = os.Stderr
pool.Add(first)
pool.Add(second)

I also noticed that if I ctrl-c the process nothing happens. If I ctrl-c the process twice it does interrupt.


Add SAML2 support to DefectDojo

Adds a plugin that makes SAML2 authentication setup very similar to the OAuth suite currently in place.
Documentation

[x] Your code is flake8 compliant.
[x] Your code is python 3.5 compliant (specific python >=3.6 syntax is currently not accepted).
[x] If this is a new feature and not a bug fix, you've included the proper documentation in the ReadTheDocs documentation folder. https://github.com/DefectDojo/Documentation/tree/master/docs or provide feature documentation in the PR.
[ ] Model changes must include the necessary migrations in the dojo/db_migrations folder.
[ ] Add applicable tests to the unit tests.
[x] Add the proper label to categorize your PR.

Seem to be the same discussion as in this PR https://github.com/DefectDojo/django-DefectDojo/pull/1363 and this issue https://github.com/DefectDojo/django-DefectDojo/issues/1661.
From my point of view saml is very useful and I am using the implementation from https://github.com/DefectDojo/django-DefectDojo/pull/1363 now over one year in production.

Oh I remember that PR now. Yes, SAML is super useful from an org perspective since it is a little more secure than OAuth. Without any bias, I think this package makes it a little more simple and user friendly at the expense of customization. What do you think?

@cody-m-tibco did you took a look if saml would work with social auth? To be honest, I didn't because I already had a solution which worked for me.

I did not! I was under the impression social-auth was primarily OAuth. Probably best to keep SSO configs consistent. Thanks for steering me in the right direction!

So after trying off and on for a bit, its going to take 3 extra debian packages to get the social-auth SAML backend working. Seems like the one from this PR would be the lightest option.


Plutus nix build:  no index-sha256 was provided

I've followed the instructions here https://docs.plutus-community.com/docs/setup/WindowsWSL.html .
After installing nix, I am trying to build plutus libs:
/plutus$ nix build -f default.nix plutus.haskell.packages.plutus-core --show-trace
error: while evaluating the attribute 'hsPkgs' at /nix/store/732l41i97mm5sln69fbjqkdmmjy3fqai-haskell.nix-src/overlays/haskell.nix:549:15:
while evaluating the attribute 'hsPkgs' at /nix/store/732l41i97mm5sln69fbjqkdmmjy3fqai-haskell.nix-src/overlays/haskell.nix:526:43:
while evaluating anonymous function at /nix/store/732l41i97mm5sln69fbjqkdmmjy3fqai-haskell.nix-src/lib/import-and-filter-project.nix:5:1, called from /nix/store/732l41i97mm5sln69fbjqkdmmjy3fqai-haskell.nix-src/overlays/haskell.nix:504:27:
while evaluating anonymous function at /nix/store/732l41i97mm5sln69fbjqkdmmjy3fqai-haskell.nix-src/lib/call-cabal-project-to-nix.nix:9:1, called from /nix/store/732l41i97mm5sln69fbjqkdmmjy3fqai-haskell.nix-src/overlays/haskell.nix:503:36:
 and no `index-sha256` was provided. 0:00Z

Okay...
so it looks like that one needs to run
nix-shell

first.


Azure Firewall - Policy to deploy diagnostic settings for Firewall to Log Analytics workspace - missing 'Azure Firewall Flow Trace Log' category

Versions
Module: ALZ v2.4.1
terraform-azurerm-caf-enterprise-scale/blob/main/modules/archetypes/lib/policy_definitions/policy_definition_es_deploy_diagnostics_firewall.json
Description
There is missing a category for Azure Firewall diagnostic settings policy. The missing category is Azure Firewall Flow Trace Log
This category needs to be added or replace all with category group allLogs. The Azure Firewall resources which this policy deploys diagnostics settings to will never be compliant due to a mismatch between existenceCondition and what the policy actually deploys.
Screenshots

Working on adding this new category in PR #1119 hopefully will be merged here later today


DirectLake mode needs to be added to this page

Please add whether change detection is supposed to work in Direct Lake mode (Fabric), this should be mentioned in the summary table at the bottom of the page.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: fedb7099-554f-0eed-eaa6-fc13851eb3b1
Version Independent ID: 8beddbbe-5ebc-60e4-ab28-fd130283a8c1
Content: Automatic page refresh in Power BI Desktop - Power BI
Content Source: powerbi-docs/create-reports/desktop-automatic-page-refresh.md
Service: powerbi
Sub-service: pbi-reports-dashboards
GitHub Login: @davidiseminger
Microsoft Alias: davidi

Thanks for your comment, @otravers. This issue has been assigned to the doc author for review.

Thanks for your suggestion, we've forwarded the request to the engineering team and will review adding to that table in an upcoming release.


Use ubuntu-20.04 in build.yml

This should improve the compatibility of the Linux binaries. Otherwise with the current release I currently get the error:
linux-x64/bin/CodeFormat: /usr/lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.33' not found (required by linux-x64/bin/CodeFormat)
linux-x64/bin/CodeFormat: /usr/lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.32' not found (required by linux-x64/bin/CodeFormat)
linux-x64/bin/CodeFormat: /usr/lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.34' not found (required by linux-x64/bin/CodeFormat)

I have already statically compiled libstdc++, but libc cannot be statically compiled. The various versions and unavailability caused by glibc in Linux are really frustrating. However, will directly downgrading the Ubuntu version cause other problems?

Thanks for letting me know. It may be possible to use the musl-gcc wrapper to handle this problem (or some musl strategy in general), but I don't have bandwidth to try right now.


Documentation issue with workday-writeback-tutorial.md

I believe there's a documentation issue within the tutorial for Workday Writeback. Under the Timing the writeback for pre-hires section, item 4 incorrectly describes the logic of the provided expression.
IgnoreFlowIfNullOrEmpty(IIF(DateDiff("d", Now(), CDate([employeeHireDate])) >= 0, "", [userPrincipalName]))
The previous expression uses the DateDiff function to evaluate the difference between employeeHireDate and today's date in UTC obtained using Now function. If employeeHireDate is greater than or equal to today's date, then it updates the UserID. Else it returns an empty value and the IgnoreFlowIfNullOrEmpty function excludes this attribute from Writeback.
The bold highlights above document the inverse of the expression. Per the IIF function documentation, IIF(condition,valueIfTrue,valueIfFalse). Looking at the above expression, true would be "" and false would be [userPrincipalName]. The result of the evaluation is that userPrincipalName is not written back until on the hire date. Assumming the [employeeHireDate] is a date and has no time component, function CDate will return a time of 12:00:00AM. Thus if the function is triggered on [employeeHireDate], the 12AM time component from CDate will evaluate to < Now() and flow the [userPrincipalName].

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: be669f51-5f2a-3e2b-ebd7-b5268e473044
Version Independent ID: ec36c599-5a24-3317-bcd0-3c6f21902fd3
Content: Tutorial: Configure Workday writeback in Microsoft Entra ID - Microsoft Entra ID
Content Source: docs/identity/saas-apps/workday-writeback-tutorial.md
Service: entra-id
Sub-service: saas-apps
GitHub Login: @cmmdesai
Microsoft Alias: chmutali

@FIMTooler
Thanks for your feedback! We will investigate and update as appropriate.

@FIMTooler
Thank you for bringing this to our attention.
I've delegated this to content author @cmmdesai, who will review it and offer their insightful opinions.

@cmmdesai
Could you please review add comments on this, update as appropriate.

Thank you for your feedback. Please note that I transferred this feedback to UUF as we're moving away from GitHub issues and into a unified user feedback mechanism. That feedback will be triaged and an ADO work item opened and added to our queue. Have also notified the feature PMs for follow up. Thank you.
#please-close


[BitSail][Feature] Support more split strategy in Clickhouse Source.

Is your feature request related to a problem? Please describe
Current Clickhouse source only supports simple split strategy, i.e., evenly divide all data into groups.
Describe the solution you'd like
Maybe we can support more split strategies, like user defined split strategy by config options.

Hi @john8628, do you have any progress on this issue?
We can discuss any question or idea here if you have :D


Mdtopappbar crashes packaged app

Hi there,
I am having issue with the mdtopappbar,i encounter this error after I package the py file to apk, the topbar works just fine when a I run it on my pc but after packing, when I start the apk it just shows me a black screen for 1 second and crashes after showing the splash screen, this behaviour is only experienced when I use any of the toolbars be top or bottom.
Thanks.
Os:Win11
Py - - ver: python37

Can use logcat to see what happened.

Can use logcat to see what happened.
Sure, will post once home

logcat.txt

This logcat is cached through adb logcat | findstr /c:"I python"  since I ve packaged it using colab I am unable to use buildozer logcat

https://github.com/kivymd/KivyMD/issues/1352

Thank you so much for helping out, i will recompile the apk


[Question] How to handle logout situation.

How we need to handle logout situation in connection with Firebase notification. I am trying for a solution to stop receiving notification once the user is logout from the app. And again I need to enable the notification once the user is login back.
Also what in case if some other user login the same app?
Please help. I think this information is missing in documentation.

This is what you need to call after a logout
 CrossFirebasePushNotification.Current.UnregisterForPushNotifications();

Hi, depends of your process to register device. If your login process are successful, I guess you are saving that token device associated to that logged user right? If is that your scenario, in logout you should call to api service to disassociate that Token-User.
This situation depends in each case, put this in the documentation I think it's not correct.
Regards!


Refactor DNS check

Fixes #95

Implements a (semi-)recursive iterative lookup mechanism to find all authoritative
nameservers for the zone enclosing the domain.
This is necessary because a direct query for NS records at a recursive DNS server (e.g. Google Public DNS) or at the zone's primary nameserver will often yield an incomplete list of authoritative nameservers or even those of a another zone (e.g.
when the domain is a CNAME pointing to another zone).
All authoritative nameservers are then queried for the TXT record to make
sure that it has been completely propagated.
The waitFor utility function now takes an interval parameter and returns
the last seen error on timeout.

@xenolf Right now we only check the first NS in the record. The MaxRecursion actually limits the recursion depth and protects us from an infinite loop due to misconfigured DNS zones.
I agree we should query all NS in the records!

We also better add a test case before merging this :smile:

Are you going to add that to your PR or should I add it later? :)
Thanks for you hard work on this issue! :clap:

I will update this with the check for all authoritative NS. If you could add a test when thats done? :smirk:

:laughing: Yeah I will. Them bloody tests :stuck_out_tongue_winking_eye:

@xenolf So the changes for querying all authoritative nameservers are in. This is a bit of a rewrite, so please review. Tested with CloudFlare DNS.

Added some unit tests FYI. :bowtie:

@willglynn If you will, please test your scenario against the updated PR. Thanks!

I should be able to check in on this tomorrow. Who knows; I might even be able to contribute tests :smile:

Awesome :ok_hand: :yum:

I don't have immediate feedback, but I have been collecting scenarios for testing.
(CNAMEs make for all sorts of fun.)

The iterative DNS lookup used in this PR proved overkill, since the objective (getting a definite list of authoritative NS for a domain) can actually very well be accomplished by plain old and cheap recursive queries to a public DNS resolver. :grimacing:
Landing this PR would thus introduce unnecessary complexity.
Closed in favor of #116
@willglynn The API has not changed so any tests you might have prepared can be applied to the new PR.


with target object

in the current group() function, it creates the result object in the function.
and it does not allow the user to give the target object.
it is important because at some use case, user does not want to break the reference of the target object.
const targetObj = {};
export const getGroupedValue = ()=> return targetObj;
export const setGroupedValue = (arr) => {
  const grouped = arr.group(val=>val.someId);
  Object.keys(grouped).forEach(key=>{targetObj[key]=grouped[key]}); // <== this is additional part that is needed.
}

if we have a functionality that can get the targetObject as an argument, it will be a lot easier:
...
export const setGroupedValue = (arr) => {
  targetObj = arr.groupToTarget(val=>val.someId, targetObj);
}

Object.keys(grouped).forEach(key=>{targetObj[key]=grouped[key]})

There is a simpler way of writing this, which is Object.assign(target, grouped). I think that's easy enough.

I agree Object.assign is easy but it also will need unnecessary copy process. when you see the .reduce function, we can give the original object as argument, but this function does not have that freedom even though it is similar to this reduce function.
targetObj = arr.reduce((obj, item)=>{ obj[selector(item)]=obj }, targetObj);

@wootra Object.assign mutates its first argument, it doesn't make a copy.

My suggestions is this shouldn't be allowed, because it opens up the algorithm to running userland code (eg, if the param were a Proxy instance. As the others have suggested, using Object.assign seems like a good compromise for implementors to optimize and devs to get the key-values copied to their object.

@jridgewell  make sense. since this is a primitive function, it should not have too much potential black-box - which means it should avoid the possibility of debugging required.
I would accept the method Object.assign after using group. Sounds like a good compromise to me as well.


bumping js-slang

Description
bumping js-slang

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 36.991%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
5730

Relevant Lines:
14577

💛  - Coveralls


k3s-etcd-snapshot configmap should not contain entries without extra metadata

K3s tracking issue for

https://github.com/rancher/rke2/issues/5008

The snapshot controller shouldn't create configmap entries for snapshots that have empty extra metadata; this confuses Rancher.

Validation in v1.28.4-rc1+k3s1
Testing Steps

Install k3s
Run the commands below:

k3s etcd-snapshot save
k3s etcd-snapshot list

Confirm snapshot is listed

kubectl get configmap -n kube-system k3s-etcd-snapshots -o yaml

Confirm empty or does not exist

kubectl create configmap -n kube-system k3s-etcd-snapshot-extra-metadata --from-literal=foo=bar
k3s etcd-snapshot save
k3s etcd-snapshot list

Confirm both snapshots are listed

kubectl get configmap -n kube-system k3s-etcd-snapshots -o yaml

Confirm only second snapshot is listed

Replication Result

$ kubectl get nodes,pods -A -o wide
NAME           STATUS   ROLES                       AGE     VERSION        INTERNAL-IP     EXTERNAL-IP   OS-IMAGE             KERNEL-VERSION    CONTAINER-RUNTIME
node/server1   Ready    control-plane,etcd,master   3m44s   v1.28.3+k3s2   <IP_ADDRESS>   <none>        Ubuntu 22.04.2 LTS   5.15.0-1031-aws   containerd://1.7.7-k3s1

NAMESPACE     NAME                                          READY   STATUS      RESTARTS   AGE     IP          NODE      NOMINATED NODE   READINESS GATES
kube-system   pod/coredns-6799fbcd5-sb865                   1/1     Running     0          3m29s   <IP_ADDRESS>   server1   <none>           <none>
kube-system   pod/helm-install-traefik-bdnnt                0/1     Completed   1          3m29s   <IP_ADDRESS>   server1   <none>           <none>
kube-system   pod/helm-install-traefik-crd-f4njh            0/1     Completed   0          3m29s   <IP_ADDRESS>   server1   <none>           <none>
kube-system   pod/local-path-provisioner-84db5d44d9-v6pz5   1/1     Running     0          3m29s   <IP_ADDRESS>   server1   <none>           <none>
kube-system   pod/metrics-server-67c658944b-nrjpc           1/1     Running     0          3m29s   <IP_ADDRESS>   server1   <none>           <none>
kube-system   pod/svclb-traefik-2e884bcf-wls7b              2/2     Running     0          2m44s   <IP_ADDRESS>   server1   <none>           <none>
kube-system   pod/traefik-f4564c4f4-zqtw9                   1/1     Running     0          2m44s   <IP_ADDRESS>   server1   <none>           <none>

$ k3s -v
k3s version v1.28.3+k3s2 (bbafb86e)
go version go1.20.10

$ sudo k3s etcd-snapshot list
WARN[0000] Unknown flag --write-kubeconfig-mode found in config.yaml, skipping
WARN[0000] Unknown flag --cluster-init found in config.yaml, skipping
WARN[0000] Unknown flag --token found in config.yaml, skipping
Name Location Size Created

$ sudo k3s etcd-snapshot save
WARN[0000] Unknown flag --write-kubeconfig-mode found in config.yaml, skipping
WARN[0000] Unknown flag --cluster-init found in config.yaml, skipping
WARN[0000] Unknown flag --token found in config.yaml, skipping
INFO[0000] Saving etcd snapshot to /var/lib/rancher/k3s/server/db/snapshots/on-demand-server1-1701466447
{"level":"info","ts":"2023-12-01T21:34:06.949343Z","caller":"snapshot/v3_snapshot.go:65","msg":"created temporary db file","path":"/var/lib/rancher/k3s/server/db/snapshots/on-demand-server1-1701466447.part"}
{"level":"info","ts":"2023-12-01T21:34:06.952698Z","logger":"client","caller":"v3@v3.5.9-k3s1/maintenance.go:212","msg":"opened snapshot stream; downloading"}
{"level":"info","ts":"2023-12-01T21:34:06.953123Z","caller":"snapshot/v3_snapshot.go:73","msg":"fetching snapshot","endpoint":"https://<IP_ADDRESS>:2379"}
{"level":"info","ts":"2023-12-01T21:34:06.994839Z","logger":"client","caller":"v3@v3.5.9-k3s1/maintenance.go:220","msg":"completed snapshot read; closing"}
{"level":"info","ts":"2023-12-01T21:34:07.094617Z","caller":"snapshot/v3_snapshot.go:88","msg":"fetched snapshot","endpoint":"https://<IP_ADDRESS>:2379","size":"3.3 MB","took":"now"}
{"level":"info","ts":"2023-12-01T21:34:07.094711Z","caller":"snapshot/v3_snapshot.go:97","msg":"saved","path":"/var/lib/rancher/k3s/server/db/snapshots/on-demand-server1-1701466447"}
INFO[0000] Reconciling ETCDSnapshotFile resources
INFO[0000] Reconciliation of ETCDSnapshotFile resources complete

$ sudo k3s etcd-snapshot list
WARN[0000] Unknown flag --write-kubeconfig-mode found in config.yaml, skipping
WARN[0000] Unknown flag --cluster-init found in config.yaml, skipping
WARN[0000] Unknown flag --token found in config.yaml, skipping
Name                         Location                                                                     Size    Created
on-demand-server1-1701466447 file:///var/lib/rancher/k3s/server/db/snapshots/on-demand-server1-1701466447 3297312 2023-12-01T21:34:07Z

$ kubectl get configmap -n kube-system k3s-etcd-snapshots -o yaml
apiVersion: v1
data:
  local-on-demand-server1-1701466447: '{"name":"on-demand-server1-1701466447","location":"file:///var/lib/rancher/k3s/server/db/snapshots/on-demand-server1-1701466447","nodeName":"server1","createdAt":"2023-12-01T21:34:07Z","size":3297312,"status":"successful","compressed":false}'
kind: ConfigMap
metadata:
  creationTimestamp: "2023-12-01T21:34:07Z"
  name: k3s-etcd-snapshots
  namespace: kube-system
  resourceVersion: "1469"
  uid: feb34dcf-f570-4212-909b-ee4a375e2320

$ kubectl create configmap -n kube-system k3s-etcd-snapshot-extra-metadata --from-literal=foo=bar
configmap/k3s-etcd-snapshot-extra-metadata created

$ sudo k3s etcd-snapshot save
WARN[0000] Unknown flag --write-kubeconfig-mode found in config.yaml, skipping
WARN[0000] Unknown flag --cluster-init found in config.yaml, skipping
WARN[0000] Unknown flag --token found in config.yaml, skipping
INFO[0000] Saving etcd snapshot to /var/lib/rancher/k3s/server/db/snapshots/on-demand-server1-1701466500
{"level":"info","ts":"2023-12-01T21:34:59.576192Z","caller":"snapshot/v3_snapshot.go:65","msg":"created temporary db file","path":"/var/lib/rancher/k3s/server/db/snapshots/on-demand-server1-1701466500.part"}
{"level":"info","ts":"2023-12-01T21:34:59.580915Z","logger":"client","caller":"v3@v3.5.9-k3s1/maintenance.go:212","msg":"opened snapshot stream; downloading"}
{"level":"info","ts":"2023-12-01T21:34:59.580977Z","caller":"snapshot/v3_snapshot.go:73","msg":"fetching snapshot","endpoint":"https://<IP_ADDRESS>:2379"}
{"level":"info","ts":"2023-12-01T21:34:59.622174Z","logger":"client","caller":"v3@v3.5.9-k3s1/maintenance.go:220","msg":"completed snapshot read; closing"}
{"level":"info","ts":"2023-12-01T21:34:59.805673Z","caller":"snapshot/v3_snapshot.go:88","msg":"fetched snapshot","endpoint":"https://<IP_ADDRESS>:2379","size":"3.4 MB","took":"now"}
{"level":"info","ts":"2023-12-01T21:34:59.805762Z","caller":"snapshot/v3_snapshot.go:97","msg":"saved","path":"/var/lib/rancher/k3s/server/db/snapshots/on-demand-server1-1701466500"}
INFO[0000] Saving snapshot metadata to /var/lib/rancher/k3s/server/db/.metadata/on-demand-server1-1701466500
INFO[0000] Reconciling ETCDSnapshotFile resources
INFO[0000] Reconciliation of ETCDSnapshotFile resources complete

$ sudo k3s etcd-snapshot list
WARN[0000] Unknown flag --write-kubeconfig-mode found in config.yaml, skipping
WARN[0000] Unknown flag --cluster-init found in config.yaml, skipping
WARN[0000] Unknown flag --token found in config.yaml, skipping
Name                         Location                                                                     Size    Created
on-demand-server1-1701466447 file:///var/lib/rancher/k3s/server/db/snapshots/on-demand-server1-1701466447 3297312 2023-12-01T21:34:07Z
on-demand-server1-1701466500 file:///var/lib/rancher/k3s/server/db/snapshots/on-demand-server1-1701466500 3416096 2023-12-01T21:35:00Z

$ kubectl get configmap -n kube-system k3s-etcd-snapshots -o yaml
apiVersion: v1
data:
  local-on-demand-server1-1701466447: '{"name":"on-demand-server1-1701466447","location":"file:///var/lib/rancher/k3s/server/db/snapshots/on-demand-server1-1701466447","nodeName":"server1","createdAt":"2023-12-01T21:34:07Z","size":3297312,"status":"successful","compressed":false}'
  local-on-demand-server1-1701466500: '{"name":"on-demand-server1-1701466500","location":"file:///var/lib/rancher/k3s/server/db/snapshots/on-demand-server1-1701466500","metadata":"eyJmb28iOiJiYXIifQ==","nodeName":"server1","createdAt":"2023-12-01T21:35:00Z","size":3416096,"status":"successful","compressed":false}'
kind: ConfigMap
metadata:
  creationTimestamp: "2023-12-01T21:34:07Z"
  name: k3s-etcd-snapshots
  namespace: kube-system
  resourceVersion: "1621"
  uid: feb34dcf-f570-4212-909b-ee4a375e2320

Validation Results

$ kubectl get nodes,pods -A -o wide
NAME           STATUS   ROLES                       AGE     VERSION            INTERNAL-IP     EXTERNAL-IP   OS-IMAGE             KERNEL-VERSION    CONTAINER-RUNTIME
node/server1   Ready    control-plane,etcd,master   3m27s   v1.28.4-rc1+k3s1   <IP_ADDRESS>   <none>        Ubuntu 22.04.2 LTS   5.15.0-1031-aws   containerd://1.7.7-k3s1

NAMESPACE     NAME                                          READY   STATUS      RESTARTS   AGE     IP          NODE      NOMINATED NODE   READINESS GATES
kube-system   pod/coredns-6799fbcd5-pdsqk                   1/1     Running     0          3m12s   <IP_ADDRESS>   server1   <none>           <none>
kube-system   pod/helm-install-traefik-4gn6l                0/1     Completed   1          3m13s   <IP_ADDRESS>   server1   <none>           <none>
kube-system   pod/helm-install-traefik-crd-2kl7t            0/1     Completed   0          3m13s   <IP_ADDRESS>   server1   <none>           <none>
kube-system   pod/local-path-provisioner-84db5d44d9-p68rm   1/1     Running     0          3m12s   <IP_ADDRESS>   server1   <none>           <none>
kube-system   pod/metrics-server-67c658944b-2dn6m           1/1     Running     0          3m12s   <IP_ADDRESS>   server1   <none>           <none>
kube-system   pod/svclb-traefik-7691f47f-q84nl              2/2     Running     0          2m52s   <IP_ADDRESS>   server1   <none>           <none>
kube-system   pod/traefik-f4564c4f4-hs5lk                   1/1     Running     0          2m52s   <IP_ADDRESS>   server1   <none>           <none>

$ k3s -v
k3s version v1.28.4-rc1+k3s1 (3f237230)
go version go1.20.11

$ sudo k3s etcd-snapshot list
WARN[0000] Unknown flag --write-kubeconfig-mode found in config.yaml, skipping
WARN[0000] Unknown flag --cluster-init found in config.yaml, skipping
WARN[0000] Unknown flag --token found in config.yaml, skipping
Name Location Size Created

$ sudo k3s etcd-snapshot save
WARN[0000] Unknown flag --write-kubeconfig-mode found in config.yaml, skipping
WARN[0000] Unknown flag --cluster-init found in config.yaml, skipping
WARN[0000] Unknown flag --token found in config.yaml, skipping
INFO[0000] Saving etcd snapshot to /var/lib/rancher/k3s/server/db/snapshots/on-demand-server1-1701467256
{"level":"info","ts":"2023-12-01T21:47:36.153111Z","caller":"snapshot/v3_snapshot.go:65","msg":"created temporary db file","path":"/var/lib/rancher/k3s/server/db/snapshots/on-demand-server1-1701467256.part"}
{"level":"info","ts":"2023-12-01T21:47:36.157183Z","logger":"client","caller":"v3@v3.5.9-k3s1/maintenance.go:212","msg":"opened snapshot stream; downloading"}
{"level":"info","ts":"2023-12-01T21:47:36.157229Z","caller":"snapshot/v3_snapshot.go:73","msg":"fetching snapshot","endpoint":"https://<IP_ADDRESS>:2379"}
{"level":"info","ts":"2023-12-01T21:47:36.196859Z","logger":"client","caller":"v3@v3.5.9-k3s1/maintenance.go:220","msg":"completed snapshot read; closing"}
{"level":"info","ts":"2023-12-01T21:47:36.296218Z","caller":"snapshot/v3_snapshot.go:88","msg":"fetched snapshot","endpoint":"https://<IP_ADDRESS>:2379","size":"3.2 MB","took":"now"}
{"level":"info","ts":"2023-12-01T21:47:36.296312Z","caller":"snapshot/v3_snapshot.go:97","msg":"saved","path":"/var/lib/rancher/k3s/server/db/snapshots/on-demand-server1-1701467256"}
INFO[0000] Reconciling ETCDSnapshotFile resources
INFO[0000] Reconciliation of ETCDSnapshotFile resources complete

$ sudo k3s etcd-snapshot list
WARN[0000] Unknown flag --write-kubeconfig-mode found in config.yaml, skipping
WARN[0000] Unknown flag --cluster-init found in config.yaml, skipping
WARN[0000] Unknown flag --token found in config.yaml, skipping
Name                         Location                                                                     Size    Created
on-demand-server1-1701467256 file:///var/lib/rancher/k3s/server/db/snapshots/on-demand-server1-1701467256 3153952 2023-12-01T21:47:36Z

$ kubectl get configmap -n kube-system k3s-etcd-snapshots -o yaml
Error from server (NotFound): configmaps "k3s-etcd-snapshots" not found

$ kubectl create configmap -n kube-system k3s-etcd-snapshot-extra-metadata --from-literal=foo=bar
configmap/k3s-etcd-snapshot-extra-metadata created

$ sudo k3s etcd-snapshot save
WARN[0000] Unknown flag --write-kubeconfig-mode found in config.yaml, skipping
WARN[0000] Unknown flag --cluster-init found in config.yaml, skipping
WARN[0000] Unknown flag --token found in config.yaml, skipping
INFO[0000] Saving etcd snapshot to /var/lib/rancher/k3s/server/db/snapshots/on-demand-server1-1701467322
{"level":"info","ts":"2023-12-01T21:48:41.723022Z","caller":"snapshot/v3_snapshot.go:65","msg":"created temporary db file","path":"/var/lib/rancher/k3s/server/db/snapshots/on-demand-server1-1701467322.part"}
{"level":"info","ts":"2023-12-01T21:48:41.726253Z","logger":"client","caller":"v3@v3.5.9-k3s1/maintenance.go:212","msg":"opened snapshot stream; downloading"}
{"level":"info","ts":"2023-12-01T21:48:41.726504Z","caller":"snapshot/v3_snapshot.go:73","msg":"fetching snapshot","endpoint":"https://<IP_ADDRESS>:2379"}
{"level":"info","ts":"2023-12-01T21:48:41.77451Z","logger":"client","caller":"v3@v3.5.9-k3s1/maintenance.go:220","msg":"completed snapshot read; closing"}
{"level":"info","ts":"2023-12-01T21:48:41.857923Z","caller":"snapshot/v3_snapshot.go:88","msg":"fetched snapshot","endpoint":"https://<IP_ADDRESS>:2379","size":"3.3 MB","took":"now"}
{"level":"info","ts":"2023-12-01T21:48:41.85802Z","caller":"snapshot/v3_snapshot.go:97","msg":"saved","path":"/var/lib/rancher/k3s/server/db/snapshots/on-demand-server1-1701467322"}
INFO[0000] Saving snapshot metadata to /var/lib/rancher/k3s/server/db/.metadata/on-demand-server1-1701467322
INFO[0000] Reconciling ETCDSnapshotFile resources
INFO[0000] Reconciliation of ETCDSnapshotFile resources complete

$ sudo k3s etcd-snapshot list
WARN[0000] Unknown flag --write-kubeconfig-mode found in config.yaml, skipping
WARN[0000] Unknown flag --cluster-init found in config.yaml, skipping
WARN[0000] Unknown flag --token found in config.yaml, skipping
Name                         Location                                                                     Size    Created
on-demand-server1-1701467256 file:///var/lib/rancher/k3s/server/db/snapshots/on-demand-server1-1701467256 3153952 2023-12-01T21:47:36Z
on-demand-server1-1701467322 file:///var/lib/rancher/k3s/server/db/snapshots/on-demand-server1-1701467322 3276832 2023-12-01T21:48:42Z

$ kubectl get configmap -n kube-system k3s-etcd-snapshots -o yaml
apiVersion: v1
data:
  local-on-demand-server1-1701467322: '{"name":"on-demand-server1-1701467322","location":"file:///var/lib/rancher/k3s/server/db/snapshots/on-demand-server1-1701467322","metadata":"eyJmb28iOiJiYXIifQ==","nodeName":"server1","createdAt":"2023-12-01T21:48:42Z","size":3276832,"status":"successful","compressed":false}'
kind: ConfigMap
metadata:
  creationTimestamp: "2023-12-01T21:48:41Z"
  name: k3s-etcd-snapshots
  namespace: kube-system
  resourceVersion: "1468"
  uid: 2908469f-1e59-4ac3-a05a-1e602d36a51c


Changelog makes appcast invalid

Error:
netsparkle: Downloading app cast signature data...
netsparkle: Appcast is valid! Parsing...
netsparkle: While parsing app cast item, converted 'Sat, 03 Jun 2023 16:28:52 +02:00' to 6/3/2023 4:28:52 PM.
netsparkle: Found an item in the app cast: version <IP_ADDRESS>00 (8.0.0) -- os = windows
netsparkle: App cast successfully downloaded and parsed. Getting available updates...
netsparkle: Couldn't read/parse the app cast: Value cannot be null. (Parameter 'input')
netsparkle: No version information in app cast found

Command:
netsparkle-generate-appcast -n "ILSpy" -a ./output -e msi -b ./ -o windows -f true -u https://github.com/icsharpcode/ILSpy/releases/tag/v8.0 --description-tag ".NET Decompiler" --key-path ./signingkeys --change-log-path ./
appcast.xml generated:
<?xml version="1.0" encoding="utf-8"?><rss version="2.0" xmlns:sparkle="http://www.andymatuschak.org/xml-namespaces/sparkle"><channel><title>ILSpy</title><description>.NET Decompiler</description><language>en</language><item><title>ILSpy <IP_ADDRESS>00</title><description>* feature 1
* noteable 2
* something 3</description><pubDate>Sat, 03 Jun 2023 16:28:52 +02:00</pubDate><enclosure url="https://github.com/icsharpcode/ILSpy/releases/tag/v8.0/ILSpy_Installer_<IP_ADDRESS>00.msi" sparkle:version="<IP_ADDRESS>00" sparkle:shortVersionString="8.0.0" length="4456448" sparkle:os="windows" type="application/octet-stream" sparkle:signature="921UgLifNi8t3VTJCeMGZtQGPLm+NsmkyY3wr5zdPKPektSEKYxgmIzAev48RcJXw7htOZPD6q7zAYgcjS0HDA==" /></item></channel></rss>

Original md file:
* feature 1
* noteable 2
* something 3

EDIT: Because that might make a difference - I am working on a Windows machine, and of course my changelog md has crlf for line endings.

Hmmm...I'm having a hard time replicating this one on my Windows machine. It doesn't appear to be the app cast itself, as that is parsing OK. Tried it with your app cast that you sent and with using the app cast URL from a previous issue (and did check it with CLRF, thanks for noting that).

Decided to push out a preview version with e.StackTrace going into the log too for easier debugging, so if you can update and try that. If not, can you use one of the sample projects with your app cast URL and stick a breakpoint at line 645 of SparkleUpdater? (The line that starts LogWriter.PrintMessage("Couldn't read/parse...) Need the stack trace to see where this is breaking. I'm wondering if the Configuration object has no version information...?
(The No version information in app cast found is just a red herring; need to refine that error message to be more specific.)

ok, will try asap once the version shows up (I am currently on https://www.nuget.org/packages/NetSparkleUpdater.UI.WPF/2.3.0-preview20230604001)
What version of .NET is your sample for? The ILSpy version I am testing with it .NET 6.0.

I am now getting (didn't get that error when creating the issue)
netsparkle: Downloading app cast signature data...
netsparkle: Signature check of appcast failed
netsparkle: Appcast is not valid
netsparkle: No version information in app cast found

For good measure I re-created the appcast at https://ilspy.net/appcast.xml - my code hasn't really changed:
			string sparkleSettingsPath = Path.Combine(Environment.GetFolderPath(Environment.SpecialFolder.ApplicationData), "ICSharpCode\\ILSpy-sparkle.json");

			_sparkle = new SparkleUpdater(
				"https://ilspy.net/appcast.xml",
				new Ed25519Checker(SecurityMode.Strict, "s2P6MPexSRSjod77aWUjgVKj/gKYYAeqgHY/0Gf8b78=")
			) {
				UIFactory = new NetSparkleUpdater.UI.WPF.UIFactory(null),
				RelaunchAfterUpdate = false,
				CustomInstallerArguments = "",
				Configuration = new JSONConfiguration(null, sparkleSettingsPath)
			};
			_sparkle.StartLoop(true);

I'm wondering if the Configuration object has no version information...?

Were you refering to the JSONConfiguration above?

What version of .NET is your sample for? The ILSpy version I am testing with is .NET 6.0.

.NET 7. Good to know you're testing .NET 6 as that will help debug.

Were you refering to the JSONConfiguration above?

Yeah. At the top of XMLAppCast in GetAvailableUpdates() there is a Version installed = new Version(_config.InstalledVersion); call. I think the fact that you aren't sending an IAssemblyAccessor to your JSONConfiguration is what is breaking things. (Yes, that means the lib should probably throw/show an error if there is no IAssemblyAccessor so that the dev knows what's going on.)
Try new JSONConfiguration(new AssemblyReflectionAccessor(null /* assemblyName is not required and will use the entry assembly by default */), sparkleSettingsPath).
I won't have time to debug/make changes until this evening my time (EDT) at the earliest, so this might get you moving forward before I have more time.

Did you upload the new .signature file for the updated app cast you put up? (Hence the Signature check of appcast failed error.)

I am currently stepping through the calls - there is some strange async code:
https://github.com/christophwille/NetSparkle/blob/0561653b064dc19e9e042530fba5b09794142558/src/NetSparkle/Downloaders/WebRequestAppCastDataDownloader.cs#L116
Everywhere else there seems to be a .Wait() - which isn't great either, it should be GetAwaiter().GetResult(). Even better would be one fully async method public async Task<string> DownloadAndGetAppCastData(string url) that is being GetAwaiter().GetResult()-ed in the existing method.

ok, here is the kicker - I extracted the code for sig validation and ran it directly against the files generated by the tool:
            var signatureVerifier = new Ed25519Checker(SecurityMode.Strict, "s2P6MPexSRSjod77aWUjgVKj/gKYYAeqgHY/0Gf8b78=");

            string appcast = System.IO.File.ReadAllText(@"D:\Demos\NetsparkleTest\output\appcast.xml");
            string signature = System.IO.File.ReadAllText(@"D:\Demos\NetsparkleTest\output\appcast.xml.signature");

            var appcastBytes = Encoding.UTF8.GetBytes(appcast);

            var result = signatureVerifier.VerifySignature(signature, appcastBytes);

result is Valid! Same thing downloaded from the server - no. This started happening with the multi-line changelog I guess (need to verify)

Again, don't have time at the moment, but writing this comment so I can remember later: SecurityMode.Strict checks for change log security hashes. If the change log ends up in the app cast file, perhaps we are looking for a non-existent change log signature that doesn't exist and isn't needed.
(Does SecurityMode.OnlyVerifySoftwareDownloads work?)
Appreciate your willingness to do back and forth, here. Sometimes the only way to grow is to get new eyes on it. I realize it's probably not fun to come and go "things are just broken!!" but I hope that through this we can make this work better for all. :)

Is there some dark mode something going on there? I am guessing the text is there at the top, just invisible/white. I've seen that happen on the Avalonia build before. (Again, sorry, can't pop open a debugger at the moment..is this a windows 11 thing for WPF to go into dark mode?)
To answer your question more directly, https://github.com/NetSparkleUpdater/NetSparkle/blob/develop/src/NetSparkle/Interfaces/IAssemblyAccessor.cs. Basically, name of product, title, and version.

Yes, the theme was the culprit

I switched the theme yesterday to see if/how "off" the dialogs were - and forgot about that today.
So, yes, this is going to be the next issue on how to integrate styles because we don't really do strange things - I pushed my branch now to https://github.com/icsharpcode/ILSpy/tree/netsparkleupdater (MainWindow.xml.cs has the code I was talking about all the time)

Ok, great, glad that you figured out the app cast encoding issue.
RE: Theme switching — we probably need to file a new issue on this repo for that. This lib is not doing anything for styling, basically. Nothing special. I've run into this problem myself before and my "quick fix" was just to copy in the UI files and use my own UIFactory implementation (basically copied from the source code) so that the overall theme switching was picked up.
I honestly am not sure of the best way to solve the problem of "my app switches themes for everything and so should this library's UI code in this external DLL"; perhaps it will require some styling updates on the library's end or something. 🤔

Closing as the original issue has been resolved.

@christophwille What did you end up dokng to fix this?
I'm having the exact same issue and I tried changing the line endings to LF but whenever I generate the appcast with the .md notes, the package update fails on client side.  If I don't include the md file the updates work fine. Same issue you are having but this is not being pushed to me git repo.
I too am on Windows.
I tried converting the crlf to lf in the .md file but when the appcast is created it has the crlf back in there so I converted them to lf but still update fails.

See the thread post about .gitattributes


Missing documentation

The README says:

opam-build and opam-test are two opam plugins that
To install it, simply call:

I found a description in the 0.1.0 release notes, so probably worth copying that to the README.

Fixed by https://github.com/kit-ty-kate/opam-build/commit/f39e5d52b4c83c30c5c9aa6b12d6daa8f4dedf1b. Thanks!


July 10, 2024 ASF Board Report

Is your feature request related to a problem or challenge?
Per https://www.apache.org/foundation/board/reporting, for the first three months of a project it should submit monthly board reports to the ASF board
Subsequently, per  https://whimsy.apache.org/roster/committee/datafusion the DataFusion ASF board report schedule is
March, June, September, December
Describe the solution you'd like
I would like to draft a board report for the ASF board meeting, ideally with community help.
The meetings are typically in the second or third week of the month
Describe alternatives you've considered
I plan to do this in the same style that worked well in Arrow (see an example from @andygrove
here https://lists.apache.org/thread/7w4mgy98qomc6drvj2fo81gvhq6p0boc) -- make a google doc (or issue) that people can add relevant content to and then the chair (me for the time being) submits it to the board
Additional context
No response

Here is the reminder email
---------- Forwarded message ---------
From: Shane Curcuru<EMAIL_ADDRESS>Date: Mon, Jul 1, 2024 at 5:20 PM
Subject: DataFusion Board Report due by Wed Jul 10th - Initial Reminder
To: Andrew Lamb<EMAIL_ADDRESS>Cc<EMAIL_ADDRESS>

Hello,

According to our records, you are listed as the chair of DataFusion,
a committee that is due to submit a report by Wed Jul 10th
for the next ASF board meeting. This is an initial reminder to prepare a
report for DataFusion and submit it as described below.

In the Apache governance model, the ASF board delegates responsibility for
managing projects to PMCs. This allows projects to govern themselves, in
terms of their own development goals, guidelines, and volunteer spirit,
within the scope of our purpose as an open source foundation. The state
allows us to provide an umbrella of corporate protection to our projects
and volunteers, but only to the extent that we retain active and effective
oversight of each project's operation on behalf of the public's interest.

To enable the board to provide oversight across the foundation, each PMC
is tasked with providing the board a quarterly report on the health of
their project. This allows us to hear your heartbeat, to see the project
through your eyes, and to inform the public through our meeting minutes.

Thank you for being a responsible project chair and helping us maintain
oversight over the Apache Software Foundation. If, for whatever reason,
a full report is not possible by the deadline, please report just that.
It's okay to postpone a report by a month.

Please note that we will be reviewing and approving these reports,
asynchronously, during the week prior to our scheduled board meeting.
Reports received after Wed Jul 10th will be postponed to the
next regular meeting. Please try to submit your report early.

Submitting your report
----------------------

Full details about reporting to the board are at

  https://www.apache.org/foundation/board/reporting

Please be aware that the board is looking for your personal observations,
assessment, and ideas, not just raw statistics.

Chairs may use one of several mechanisms to submit or edit their report:

 a) the Apache Reporter Service
    https://reporter.apache.org/

 b) the Whimsy online agenda tool
    https://whimsy.apache.org/board/agenda/2024-07-17/DataFusion

 c) carefully editing and committing changes to the dated agenda in
    https://svn.apache.org/repos/private/foundation/board

 d) or, if none of the above work, send an email to [board<EMAIL_ADDRESS>with
    Subject: [REPORT] DataFusion

If you believe it won't be possible to prepare a report before the deadline,
or if the PMC is aware that the Chair is unavailable, please report that
and we can reschedule or have someone else report on your behalf.

Here is a draft for anyones comments / review: https://docs.google.com/document/d/1lV-cFZGHCSrTiaLW1gyEMDKW-9nf47UW8xK19QCqbVk/edit

Kudos to @andygrove @phillipleblanc @lukekim and @Omega359  for the help
I have submitted the report. Here is the final content
2024-07-10 DataFusion ASF Board Report
https://github.com/apache/datafusion/issues/10282

DataFusion PMC Chair Note: Please add any relevant comments / content to this document. I (Andrew Lamb) will submit to the ASF board on Wed July 10, 2024 (about one week prior to the scheduled board meeting).

New projects submit reports every month for the first three months. This is our last of those three monthly reports. Our next one is due on July 10, 2024

The format of this report and the metrics are from https://reporter.apache.org/wizard/?datafusion

The rationale and process for this report: https://www.apache.org/foundation/board/reporting
Past examples: [2024-06-12 DataFusion ASF Board Report](https://docs.google.com/document/d/1h4yjvomQO0XdzxKuE4aBSWGNliFFmn8GADd8DlPuXBw/edit)

## Description:
The mission of Apache DataFusion is the creation and maintenance of software
related to an extensible query engine

## Project Status:
Current project status: New + Ongoing (high activity)
Issues for the board: None

## Membership Data:
Apache DataFusion was founded 2024-04-16 (3 months ago)
There are currently 33 committers and 13 PMC members in this project.
The Committer-to-PMC ratio is roughly 9:4.

Community changes, past month:
- Mehmet Ozan Kabak was added to the PMC on 2024-06-12
- Ruihang Xia was added to the PMC on 2024-06-12
- Lewis Zhang was added as committer on 2024-06-14

## Project Activity:

The project continues to be quite active with many PRs and issues opened and
closed per day.

We started working on a project blog [1] (previously we used the arrow blog)
and hope to have our first blog post as an independent project later this
month.

There was a well attended face to face meetup in San Francisco, CA USA in June
[2]. We have one planned for Hangzhou, China in July[3]. There appears
 significant interest in these events and there are at least 2 more planned
 for September in New York, NY USA and in Belgrade, Serbia

The community around DataFusion is growing too. For example, Spice AI has made
an initial contribution of TableProviders to datafusion-contrib [4] for
PostgreSQL, MySQL, DuckDB, and SQLite, enabling these data sources to be
easily queried through DataFusion.

[1]: https://datafusion.apache.org/blog/
[2]: https://github.com/apache/datafusion/discussions/10800
[3]: https://github.com/apache/datafusion/discussions/10341
#discussioncomment-9738748
[4]: https://github.com/datafusion-contrib/datafusion-table-providers

### DataFusion core
https://github.com/apache/datafusion

We released version 39.0.0, continuing our schedule of monthly releases and
are on track to release version 40.0.0 in the next day or two.

Some projects we have been working on recently involve adding support for more
flexible use of Parquet files including indexing and extracting statistics. We
are also working with the community to make extending SQL planning[2] easier
and extending file format support[3], as well as fixing bugs found with a SQL
fuzzer[4], and improving performance with StringView[5].

It has been nice to see several good examples of cross contributor/company
collaboration such as [6] and [7].

We have also been making external presentations[1]

[1]: https://github.com/apache/datafusion/issues/10969
[2]: https://github.com/apache/datafusion/issues/10534
[3]: https://github.com/apache/datafusion/pull/11060
[4]: https://github.com/apache/datafusion/issues/11030
[5]: https://github.com/apache/datafusion/issues/10918
[6]: https://github.com/apache/datafusion/pull/11203
[7]: https://github.com/apache/datafusion/issues/10534

### Sub project: DataFusion Python

https://github.com/apache/datafusion-python

The DataFusion Python project continues to receive updates as new versions of
the core DataFusion project are released. There have also been some minor
improvements to improve user experience.

### Sub project: DataFusion Comet

https://github.com/apache/datafusion-comet

The Comet project is very active and is working towards an initial 0.1.0
source release. Initial benchmark results were published to
https://datafusion.apache.org/comet/contributor-guide/benchmarking.html.

### Sub project: DataFusion Ballista
https://github.com/apache/datafusion-ballista
https://github.com/apache/datafusion-ballista-python

The Ballista subproject is not very actively maintained, but there have been
some contributions recently to upgrade to more recent versions of the core
DataFusion project.

### Recent Releases
* PYTHON-39.0.0 was released on 2024-07-02.
* 39.0.0 was released on 2024-06-10.
* PYTHON-38.0.1 was released on 2024-05-30.
* PYTHON-37.1.0 was released on 2024-05-13.
* 38.0.0 was released on 2024-05-10.

## Community Health:
Community health is good -- we recently hit the 600 total contributors mark according to Github. This number is partially inflated from initially being part of the Arrow mono repo but the trend is healthy non the less.

It is hard to keep track of everything going on these days, which is a good thing. While it is always a struggle to get enough code review, the committers keep things going and the community helps each other out with reviews.


Not an issue, just a question

I don't know about audio data / data science, but can this library produce sound from text,
sorry this question is stupid, I'm really already dizzy looking on google

Short answer is probably no.
But what exactly do you mean by producing sound from text?
Like, do you want to input english text and have the program read it out? That's called text-to-speech. There's probably a dart package for that, but idk much about it.


Allow mixed var bindings, let bindings, and binding updates in multi-expression assignment

Currently, only binding updates can occur in multi-expression assignment:
x, y = foo();

It should be possible to create new variables when unpacking a multi-expression:
let x, let y = foo(); // creates two "let" bindings
let x, y = foo(); // a "let" binding for "x" and an update to the var "y"
var x, let y = foo(); // a var binding and a let binding

Multi-expressions have been removed from the language, so this is no longer relevant.


test(kitchen): add ubuntu 18.04

Description
Adds Ubuntu 18.04 to test kitchen
Issues Resolved
none
Check List

[x] All tests pass. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/TESTING.MD
[x] New functionality includes testing.
[x] New functionality has been documented in the README if applicable
[x] All commits have been signed for the Developer Certificate of Origin. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/CONTRIBUTING.MD

This was resolved in #60


Budget progress bars not working again

The progress bars have disappeared again. toolkit v 2.35.1, Chrome browser
Looks like YNAB crew have changed something again to make it break?
Can someone please take a look ?

I confirm. Doesn't work again. Could you please make vertical line through existing YNAB progress bars? That would do just fine!
See screenshot of what I mean

Hey @mopsis73   the fix for this should be in our current release! If you notice the issue still exists and you're definitely running the newest version of the toolkit, please reopen! Thanks!
Please note, all browser can take up to an hour to provide updates to all users. You can force an update if it's available for you by going to chrome://extensions and clicking the "Update" button. Firefox users can go to about:addons, click the setting cog, and click "Check for updates...".


[SNMP] Add general IPsec profile for Cisco devices

What does this PR do?
Add abstract profile for Cisco devices that support IPsec MIBs
Motivation

https://datadoghq.atlassian.net/browse/NDMII-2405
Further context in this document for IPsec MIBs / profile creation

Additional Notes

Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] Changelog entries must be created for modifications to shipped code
[ ] Add the qa/skip-qa label if the PR doesn't need to be tested during QA.

👏 ❓ do we want our ootb cisco profiles to extend this already ?

great q! i'm not sure if all ootb cisco profiles should be extending this - is there any recommended way to know which cisco devices support a specific MIB / some unified docs? i found out about this MIB from this cisco PDF i can't find the link of right now (will keep digging) but it didn't give specific model names which is why i started it as an abstract one (figured many would be extending this anyways)
i found some docs like this as well, but is there some reversal of what devices use which MIBs you know of vs. looking through each device model's docs? 🤔


Php egg not working i put 2nd Start up php index.php

Not working

Can you explain a bit more? Maybe an error message or wings logs?

Feel free to reopen this issue when you have more info.

Like using wordpress it gives me error see the screenshot
On Sat, May 21, 2022, 03:27 Yaj @.***> wrote:

Can you explain a bit more? Maybe an error message or wings logs?
—
Reply to this email directly, view it on GitHub
https://github.com/YajTPG/pterodactyl-eggs/issues/19#issuecomment-1133247551,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AWFEJC72HIU22N5FPFKXLITVK7RSPANCNFSM5WQLTIFA
.
You are receiving this because you authored the thread.Message ID:
@.***>

There is no screenshot, seems like GitHub didn't pick up the screenshot you probably attached with your email reply


Add instructions how to add service dependencies

It is advantageous to ensure the Windows service has the correct dependencies to ensure that once the host machine is rebooted that the Gitea service will only start once the database is ready.

make L-G-T-M work


Firefox Dev compatibility

Hi! How I could make it work in firefox dev edition?

Now theme is working, but blur isn't

Now theme is working, but blur isn't

As I've said on my post and in the README, you need a compositor for the blur. Note that there's a guide in the README for the KDE Plasma users. That's all the help I can give you because I don't use Plasma and cannot test it. Closing this now. Good luck !


Fix nativeimgutil.ConvertToRaw()

Truncate once to wanted size before copying data
Avoid unneeded seeks using WriteAt
Fix zero detection to handle short reads
Fix write to handle short reads

Thanks, this seems to work, but the output is confusing
INFO[0000] Converting "/Users/suda/.lima/alpine/basedisk" (qcow2) to a raw disk "/Users/suda/.lima/alpine/diffdisk"
INFO[0000] Expanding to 100GiB
212.00 MiB / 212.00 MiB [---------------------------------] 100.00% 115.06 MiB/s

It should be like
Expanding ...
Converting ...
[Progress bar:

Thanks, this seems to work, but the output is confusing
INFO[0000] Converting "/Users/suda/.lima/alpine/basedisk" (qcow2) to a raw disk "/Users/suda/.lima/alpine/diffdisk"
INFO[0000] Expanding to 100GiB
212.00 MiB / 212.00 MiB [---------------------------------] 100.00% 115.06 MiB/s

It should be like
Expanding ...
Converting ...
[Progress bar]

But this does not work for the raw-to-raw case, which must expand the image as a second step. I think we should keep the same flow since it is simple, easy to follow, and make it easy to verify that the convert was correct before expanding.
So I plan to do this:

truncate to source size
convert using WriteAt avoiding the seeks
expand

Do you plan to update this PR or open a follow-up PR separately ?

Do you plan to update this PR or open a follow-up PR separately ?

I can update it this weekend.

@AkihiroSuda new version keeps the same user interface:
% limactl create --tty=false --plain
INFO[0000] Terminal is not available, proceeding without opening an editor
INFO[0000] Attempting to download the image              arch=aarch64 digest="sha256:5ecac6447be66a164626744a87a27fd4e6c6606dc683e0a233870af63df4276a" location="https://cloud-images.ubuntu.com/releases/24.04/release-20240821/ubuntu-24.04-server-cloudimg-arm64.img"
Downloading the image (ubuntu-24.04-server-cloudimg-arm64.img)
551.31 MiB / 551.31 MiB [----------------------------------] 100.00% 57.27 MiB/s
INFO[0010] Downloaded the image from "https://cloud-images.ubuntu.com/releases/24.04/release-20240821/ubuntu-24.04-server-cloudimg-arm64.img"
INFO[0010] Converting "/Users/nsoffer/.lima/default/basedisk" (qcow2) to a raw disk "/Users/nsoffer/.lima/default/diffdisk"
3.50 GiB / 3.50 GiB [-------------------------------------] 100.00% 199.27 MiB/s
INFO[0028] Expanding to 100GiB
INFO[0028] Run `limactl start default` to start the instance.


Start Process Action Failing

Processes that are stopped are failing to start again via the start button / action.

Start process action button working:
const validActions = ['restart', 'stop', 'reload', 'start'];

https://github.com/thenickygee/pm2-ui/commit/ae3114276a0223db22864e2502803c5253833087


Solve issue with missing headers for release.

This solves issue #12
The problem was caused by header search paths not including React libraries for release build.

Thanks! Will publish a new version soon.

Thanks for sorting this out so quickly :smiley:


[CardMedia] Add an example with the component property

Initial commit to support img feature in CardMedia.
Closes #11675

@adeelibr Thanks for exploring this path. Looking deeper into the source code, I have realized that the use case was already anticipated in the implementation, it was just a matter of adding an example.

Oh my bad then 😅


Bug scExpression Mouse isnt working

Steps to reproduce:

https://cellxgene.cziscience.com/scExpression
Select mouse in organism drop down
Select urethra (or any tissue)
Add genes

Nothing loads

Mouse works if you select a mouse tissue and a mouse gene - closing this ticket but prioritizing the need for tissues and genes to update based on the organism selected.


📝 Documentation for best practices and design

Design docs include API requests being utilized, and Lessons Learned includes best practices and remaining questions.

@znatty22 just found out it is possible to get this, using the $snapshot search param. It doesn't seem to work for all resources but it does work for most. I can make the doc change and then also make some code changes


[FEATURE] Publish artifacts to Maven

Is your feature request related to a problem?
Publish SDK artifacts to Maven repositories for extension authors to consume

What benefit does publishing our under-development sdk work provide to extension authors?  We still haven't decided on a name!
I'm completely on board with publishing an alpha version once we've got something that the community can build on but I don't think we're there yet.

Generally publishing -SNAPSHOTs is good practice, especially in early stages. Simplifies development of extensions by removing the need to build this repo and publishing to maven local. Automates early.
Because we use aws.oss.sonatype I wouldn't be concerned with naming too much, but would still do #56 first.

As soon as we are at the point where an extension needs to consume content from the SDK, this will be a requirement, and we are probably nearing that point with the AD work.  So yes, let's do the name change and then start publishing.

Issue on OpenSearch build: https://github.com/opensearch-project/opensearch-build/issues/3011


Release drag when pointer get out of element

What I did

Open this example.
Press mouse left button in embla.
Drag out of right pane (browser page)
Release the button.
Move the pointer to right pane.

What I expected
Smooth scroll like keen-slider.
What I got
Embla captures mouse in whole page, and don't reset press status when pointer get out of page.

Hello @jeiea,
Thank you for the clear issue description, I appreciate that 👍.
I'm not sure there are any obvious benefits with mimicking keen-slider here. Here's why in my opinion:

Not tracking the pointer when it has moved outside of the element bounds (assuming the pointer down event happened inside the element), we might miss important changes in how fast the user is dragging the carousel.
Some use cases may be carousels that doesn't take up the full width/height of the window. In these cases only tracking the pointer inside the carousel element would make it hard to drag in a predictable way, if the slightest drag outside the element bounds were to stop tracking the pointer (because the carousel has a small area on the webpage, its draggable area would also be small).
How do we know if dragging the pointer outside of the element was intentional? Please take a look at this video where I'm dragging the carousel with a bit of force, but I don't intend to actually move the cursor outside of the carousel element.

The example CodeSandbox link you mention is sandboxed in an iframe, so I understand that the pointer gets stuck when dragging outside the iframe bounds, but if you open up the same CodeSandbox in full view without the iframe here, you'll see that leaving the browser window with the pointer is working as expected.
To sum up, I don't think this issue should be prioritized among other things that could be improved with Embla Carousel.

Okay, that sounds reasonable. Carousel have the reason that tracking a pointer out of the element.
 I don't think this case is common so I agree that the priority is lower.
Feel free to close this issue.

@jeiea I agree that it feels a bit weird. But at the time of writing I don't see an optimal solution for this. Flickity has been around for some time now and it works the same way as Embla when it comes to tracking the pointer outside of the carousel element (see this CodeSandbox as a Flickity example).
I'm guessing a bit here but if the iframe behavior with the pointer would be considered a serious issue, Flickity would have payed attention to it by now, considering the fact that people actually pay for using it commercially.
Nonetheless, thank you for your suggestion.


Call getShorthandAssignmentValueSymbol rather than getSymbolAtLocation

...for shorthand property assignment names when collecting usages.
Fixes #18188

@amcasey,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@amcasey,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


not output background object

Now only object class > 0 (not background) will be output. It solves problems that not all background pixels are merged into one object. This gives me a improvement from 0.37 to 0.40.
Also rewrite the visualization code so that only objects (not background) will have a mask and be totally transparent on other places.

OK, merging.


windows_firewall_rule: allow for multiple remote addresses

Updated the spec file to account for the change in data types
Signed-off-by: John McCrae<EMAIL_ADDRESS>

Fixes https://github.com/chef/chef/issues/9711

Can we make sure to exercise this new functionality in the kitchen tests


Wrong error log for "offsetParent is not set -- cannot scroll"

Configuration:

Web browser and its version: Chrome (but applies to all)
Operating system and its version: Any
PDF.js version: pdfjs-dist v2.0.943
Is a browser extension: No

Steps to reproduce the problem:
Imagine (e.g. an angular) application with tabs where only the currently visible tab is attached to the DOM tree. When you want to display a large PDF and switching the tab (which will disconnect the current tab from DOM tree) it logs an error.
I am just wondering about the following code:
function scrollIntoView(element, spot, skipOverflowHiddenElements = false) {
// Assuming offsetParent is available (it's not available when viewer is in
  // hidden iframe or object). We have to scroll: if the offsetParent is not set
  // producing the error. See also animationStarted.
  let parent = element.offsetParent;
  if (!parent) {
    console.error('offsetParent is not set -- cannot scroll');
    return;
  }

Why is this logging an error? Imho if element.isConnected === false it should be ok since the view is not visible nor attached to the DOM tree.
What is the expected behavior? (add screenshot)
No error log. It should just ignore it.
What went wrong? (add screenshot)
An error is shwon in debug console.

I think your reasoning makes sense, but I'm not that familiar with the scrolling code. Perhaps @Snuffleupagus can chime in if you have ideas about this?

Perhaps @Snuffleupagus can chime in if you have ideas about this?

Since PDF.js was written primarily for use in Firefox, rather than for use with particular JS frameworks, I fail to see the need for any changes here especially since this isn't a breaking error. Furthermore, having a notification about scrollIntoView not attempting to do any scrolling may also be useful in some cases.
My suggestion would be WONTFIX, or INVALID, as the appropriate resolution here.

Agreed. Moreover, the console log can always be removed in a custom deployment. Closing.

It didn't help me render the rest of the screen, when I get this kinda error, Wat is this exactly meant for??

If I understood Snuffleupagus correctly, this error log message should be changed to a warning.


Rooms and Name not saved

Hello friends,
i've set up homebridge-hue and everything is working good except for the room and Name setup.
Everytime i set rooms and namens to my motion sensors and the rest which is added by homebridge, it gets back to "standard room" after a few seconds. It's not working with different Apps (Apple Home, eve..) and parameters in config.
Does anybody know what could be wrong?
Thank you very much!
Wince

The Rooms and accessory/service names are stored in the HomeKit database, like HomeKit scenes and triggers.  They can only be accessed by HomeKit apps; they're inaccessible to HomeKit accessories, such as homebridge.
I suspect you have multiple iOS devices and/or AppleTVs in your setup?  I experience the same behaviour on occasion, especially when setting up HomeKit triggers.  It would appear the synchronisation of the HomeKit database between iDevices (through iCloud) somehow overrides the changes you just made.  I find that making only a few changes at a time and waiting for them to appear on your other iOS devices tends to solve, or at least workaround, this issue.  If that fails, log out of iCloud from all your iOS devices (including your AppleTV), except one, where you make the changes.  Then re-login to iCloud on each device.

The Rooms and accessory/service names are stored in the HomeKit database, like HomeKit scenes and triggers.  They can only be accessed by HomeKit apps; they're inaccessible to HomeKit accessories, such as homebridge.
I suspect you have multiple iOS devices and/or AppleTVs in your setup?  I experience the same behaviour on occasion, especially when setting up HomeKit triggers.  It would appear the synchronisation of the HomeKit database between iDevices (through iCloud) somehow overrides the changes you just made.  I find that making only a few changes at a time and waiting for them to appear on your other iOS devices tends to solve, or at least workaround, this issue.  If that fails, log out of iCloud from all your iOS devices (including your AppleTV), except one, where you make the changes.  Then re-login to iCloud on each device.

Thank you very much for your quick and helpful reply!
I have my iPad set as the control center, so as you said, this was the problem.
Thanks to your hint, I solved the problem in the following way:
_Updated all included iOS devices to newest iOS-Version
_On all iOS-devices, except the iPad (control center):
Settings > iCloud > In the list, disable iCloud for "Home"
_Set all rooms and names on the iPad
_Enable iCloud for "Home" again on all other devices
Thank you again! I hope that helps for everybody who has the same problem.
Greetings

Thank you very much for your quick and helpful reply!
I have my iPad set as the control center, so as you said, this was the problem.
Thanks to your hint, I solved the problem in the following way:
_Updated all included iOS devices to newest iOS-Version
_On all iOS-devices, except the iPad (control center):
Settings > iCloud > In the list, disable iCloud for "Home"
_Set all rooms and names on the iPad
_Enable iCloud for "Home" again on all other devices
Thank you again! I hope that helps for everybody who has the same problem.
Greetings


Issue #11419 - Added driver/parser/support for the new Neil Brown CTD…

… for AUVs.

Probably have to merge the preload-database changes before the checks will all pass. After that merge, we will need to retrigger the build.


Web -  App focus on compose box even when edit message is present

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Open the app
Open any report
Send any message
Edit the message
Visit any other report
Revisit report opened in step 2

Expected Result:
App should keep the focus on edit message
Actual Result:
App shifts the focus on main compose box even when report has ongoing edit message
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: <IP_ADDRESS>
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/93399543/a22de7a0-3c92-437c-9450-64171707b655
https://github.com/Expensify/App/assets/93399543/17fa5a7c-dc89-4a16-b8dd-ff9166399a2b
Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1693420650403989
View all open jobs on GitHub

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

I think that might be introduced by

https://github.com/Expensify/App/pull/25758

just not sure if its really a deploy blocker?

Yea, I agree this is NAB. Removing the label.

@hannojg should I assign this to you since it's related to that other PR?

I am not sure if this really needs to be fixed?


Unable to add a new paragraph if only static data is present

Hi, created a page with only static data e.g.

Static part

The idea is to be able to enrich this with some 'extra info'
This doesn't seems to be possible.
Checked this also in the online demo : I removed everything until only the small static 'Stack Overflow user flair' is present. Also in this case I was not able to add extra info

Hi @dirkjacobs OK I'll take a look, hopefully not a problem too often for users :) I think I just need to modify the check for empty regions to exclude ContentEdit.StaticElements from the count. Will look at over the weekend :)

Tx.
On 11/03/2016 13:47, Anthony Blackshaw wrote:

Hi @dirkjacobs https://github.com/dirkjacobs OK I'll take a look,
hopefully not a problem too often for users :) I think I just need to
modify the check for empty regions to exclude
|ContentEdit.StaticElements| from the count. Will look at over the
weekend :)
—
Reply to this email directly or view it on GitHub
https://github.com/GetmeUK/ContentTools/issues/156#issuecomment-195351801.

Static elements no longer count when determining if a region is empty and so a paragraph tag will now automatically be added to any region that is empty or contains only static elements.

Great, this works.
To make it perfect it would be nice if it reacts, like other regions, on
pressing the  key.
In this case, if the user is on an image without any other paragraphs,
pressing the enter key would add an new paragraph, now the user needs to
press the 'P' in the toolbox.
On 13/03/2016 1:44, Anthony Blackshaw wrote:

Static elements no longer count when determining if a region is empty
and so a paragraph tag will now automatically be added to any region
that is empty or contains only static elements.
—
Reply to this email directly or view it on GitHub
https://github.com/GetmeUK/ContentTools/issues/156#issuecomment-195842312.


How to get in touch regarding a security concern

Hello 👋
I run a security community that finds and fixes vulnerabilities in OSS. A researcher (@sudheendra17) has found a potential issue, which I would be eager to share with you.
Could you add a SECURITY.md file with an e-mail address for me to send further details to? GitHub recommends a security policy to ensure issues are responsibly disclosed, and it would help direct researchers in the future.
Looking forward to hearing from you 👍
(cc @huntr-helper)

S i will


ci: upgrade deprecated ci actions

:tada: This PR is included in version 0.6.0 :tada:
The release is available on:

0.6.0
GitHub release

Your semantic-release bot :package::rocket:


Focus indicator for all buttons

Add focus indicator (or CSS outline) to all clickable elements and make sure SPACEBAR and ENTER also works.

Dupe in #723.


PG_DATA_DIRECTORY empty

Add variable: PG_DATA_DIRECTORY=/var/lib/pgsql/9.6/data
File: https://github.com/Tedezed/slug-containers/blob/master/pgpool_ha/docker/bin/pgpool/others/postgres_ha.sh

https://github.com/Tedezed/slug-containers/commit/49d35a6d93c64f42eb734925a2815a90f70e4b67


Center and zoom to image selection

When browsing at lower zoom levels and selecting an image, a user is not zoomed in or centered on that image for preview. It could be useful to zoom in and center to enable a quicker preview of the image footprint, thumbnail, and TMS.
This would greatly improve the new TMS work since imagery is not rendered until higher zoom levels. By centering and zooming to an appropriate zoom level for the image, this would improve the experience for viewing the TMS.

Realizing this is a dup of https://github.com/hotosm/oam-browser/issues/151. Closing and keeping convo there.


aws-gamekit-unreal available for linux?

Hello, I would like to use this game kit for a multi player game and have my linux server do some interactions wiht the database.
Is it possible easily to compile all this plugin for lInux or even provide a realease that is compatible with Linux?
Thank you

Hi DevGarou, we haven't tested compiling GameKit for Linux yet. We've only tested for Windows, Mac, iOS, and Android. If you'd like to give it a try yourself, it might "just work" because Linux and Mac are similar.

Hi AMZN-kevmora thank you for that, I will see if I have some time to try that soon.
Otherwise is there a plan to support linux in the near futur?

Hi DevGarou,
We will keep this under consideration for our upcoming feature updates.


Client secret field disappears from UI after clicking cancel in OAuth application edit page

Steps to reproduce

create an oauth app
click edit on oauth inbound auth settings
click cancel

Thank you for your contribution!
We are closing this issue since it has not been prioritized for a long time. Chances are that it has already been solved in more recent versions. If not, we will be re-evaluating this when it becomes a priority.


PLT-5535 (Bug) Not landing on User profile page after signing up

https://input-output.atlassian.net/browse/PLT-5535

Just checked and it works well!

@RSoulatIOHK @bogdan-manole , requesting re-review on the latest branch


Do not ignore swiftmailer.options if present.

Allow configuring Swiftmailer SMTP as stated here https://silex.symfony.com/doc/2.0/providers/swiftmailer.html#parameters

See https://github.com/silexphp/Silex/issues/1486


Skip overlay2 diff tests when using naivediff

Naivediff fails when layers are created directly on top of each other. Other graphdrivers which use naivediff already skip these tests. Until naivediff is fixed, skip with overlay2 when running tests on a kernel which causes naivediff fallback. Fix applydiff to never use the naivediff size when not applying changes with naivediff.
Ping @tonistiigi

LGTM

LGTM


Lots of Raw type sigs should use the proper C type

Lots of the Raw declarations use CInt when they should really be CShort or something like that.

Partly Fixed.
There's still the issue of the WINDOW* type to deal with.


add lapce/lapce,zed-industries/zed repo to text editor collection

Please confirm this pull request meets the following requirements:

[ ] I followed the contributing guidelines: https://github.com/github/explore/blob/main/CONTRIBUTING.md.
[ ] I am not the sole author or employee of a company who created either the topic I am modifying/adding or the collection entry I am modifying/adding.

Which change are you proposing?

[ ] Suggesting edits to an existing topic or collection
[ ] Curating a new topic or collection
[ ] Something that does not neatly fit into the binary options above

Editing an existing topic or collection
I'm suggesting these edits to an existing topic or collection:

[ ] Image (and my file is *.png, square, dimensions 288x288, size <= 75 kB)
[ ] Content (and my changes are in index.md)

Please replace this line with an explanation of why you think these changes should be made.

Curating a new topic or collection

[ ] I've formatted my changes as a new folder directory, named for the topic or collection as it appears in the URL on GitHub (e.g. https://github.com/topics/[NAME] or https://github.com/collections/[NAME])
[ ] My folder contains a *.png image (if applicable) and index.md
[ ] All required fields in my index.md conform to the Style Guide and API docs: https://github.com/github/explore/tree/main/docs

Please replace this line with an explanation of why you think this topic or collection should be curated.

Something that does not neatly fit into the binary options above

[ ] My suggested edits are not about an existing topic or collection, or at least not a single one
[ ] My suggested edits are not about curating a new topic or collection, or at least not a single one
[ ] My suggested edits conform to the Style Guide and API docs: https://github.com/github/explore/tree/main/docs

Please replace this line with an explanation of your proposed changes.

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

Nice

Hi @tk103331 thanks for the contribution. Can you please confirm via the checkboxes that you're not affiliated with the projects you're adding? Per our contribution guidelines, we don't allow self promotion if you are a maintainer of the project:

Maintainers of a project cannot add a topic or collection for their own project. If a topic is popular enough to warrant inclusion, someone else will add or improve it.

We do this so that project get curated if there is enough support/activity in the community. Thank you!


[chore] Add ritikesh to CODEOWNERS

Changelog

Adds @ritikesh to CODEOWNERS fiile.

Checklist:

[x] I have updated the necessary documentation
[ ] I have updated the changelog, if necessary (CHANGELOG.md)
[x] I have signed off all my commits as required by DCO
[x] My build is green

Oops, just noticed there was an explicit request for review from @njbbaer 😅 I jumped the gun with approving to assist with merging, but I guess we'll wait.


Add 'Virtual Participant' support

Add 'Virtual Participant' capability, enabling LMA to join and stream meeting as a separate 'virtual' participant. This enables:

user to join meeting with native desktop app instead of Chrome web browser
LMA to join call before user joins, or stay on after user has dropped, or even join without user (if other participants allow it)

Introduced as 'Preview' in v0.1.9


IoPay import backup phrase shows the wrong wallet

Currently when importing a seed/backup phrase from Trust Wallet or Metamask into IoPay desktop, it unlocks a different private key than the former wallets, therefore the unlocked native wallet is not matching the ERC20 wallet on Trust/Metamask wallets.
While this is not a real “issue”, it would be much better if IoPay generated the private keys from seed phrase in the same sequence than Trust or Metamask

Thanks for opening the issue! This is definitely a user confusing issue. It needs a high level design of mnemonic phrase in IoTeX wallets. Let's put it on roadmap.