ROS# UWP TCP Client

[x] I am at the right place and my issue is directly related to ROS#. General technical questions I would post e.g. at ROS Answers or Stack Overflow. For library-specific questions I would look for help in the corresponding library forums.
[x] I have thoroughly read the Contributing Guideline and writing this issue is the right thing to do in my case.

I have a question!

[x] I searched the Wiki, open and closed issues for an answer. I tried my best to find the answer by myself without success. I believe that the discussion we will have in this issue, and the solutions we might find, will help me, and likely other community members who have a similar problem.

Here is my question:
Hi All,
My team and I have successfully built and deployed the @dwhit fork of the ROS# project for the Hololens. Unfortunately, we have run into some issues with socket communication. The project in Unity uses a subscriber class and prints to a UI element. Ultimately the plan is to view this on the Hololens as a kind of HUD element. Currently, the program functions as expected on the Unity IDE but when compiled and built onto the Hololens (or the Hololens sim), a connection is established to the Rosbridge server but no data is passed through. We believe that this may be because the issues outlined here. Should we consider a custom websocket solution like @jaguar243 metioned here? Does anyone have any advice?

My OS is: Windows 10
My Unity Version is: 2018.3.0f2
My ROS Distribution is: Melodic
My Build Target Platform is: Hololens

Thanks!
Tim

Hi Tim,
I have exactly the same problem as you described. Connection is established, but you can't subscribe to any topic (even when the message type is as simple as standard String). Everything seems to be working fine while testing in the Unity Editor.
Did you come up with any solution to this problem? One of the alternative solutions one could implement could be to use Node-Red with MQTT. There is ros-contrib package you can get for Node-Red which will allow to publish/subscribe (I need to further investigate if it is possible to publish/subscribe topic with complex message types, or just the simple ones). Once the data is captured in Node-Red, I believe it could be broadcasted using MQTT (I previously worked with Hololens and MQTT and the setup is quite efortless, it also work as the opposite to Hololens and ROS).
Regards,
Irek

Hi @tsdavs @Xend1992 please make a development build and check the log file for any concrete error messages that we can work with.
From your reports I did not understand wheter there is no communication because of the incompatiblity of the Websocket Client or because of the  JSON .NET library? For both should be alternatives available that work on your platform.
There are two Websocket Client implementations available in ROS# already. You can add your own by implementing the IProtocol class.
Here is one JSON .NET implemantion to which ROS# is compatible and which might be better suited for our Unity projects than the existing one...
@dwhit do you have any further advice?

Please help me with  your platforms guys. Is this issue a duplicate of #184 ?

Hi @MartinBischoff. I had the exact same issue as described on top and your advice to use JSON .NET implemantion helped.
Short manual to fix the issue:

Delete from RosSharp/Plugins Newtonsoft.Json but keep Newtonsoft.Json.Bson
Import json asset from the asset store.
There will be errors about possible runtime crashes, but in practice it works fine.

Thank your for this info @AsWeSee . It will likely be useful for others having the same problem.
I'm think about replacing replace the official Newtonsoft JSON .NET by the JSON .NET for Unity version.
As the ROS# libraries can also be used for non-Unity projects, I'd prefer keeping the official version. Also using Newtonsoft.BSON and JSON .NET for Unity in parallel is not so nice, since it seems the latter can handle both JSON and BSON...

Hello @tsdavs, @Xend1992, @AsWeSee,
There has been an improvement in ROS# with #292 which adds a new Json serialization tool. You can get rid of Newtonsoft serialization tool and use .NET Json serialization API instead.  Could you please try and see if it works with UWP?
I used to have a chance to work with HoloLens, and I successfully setup a proper two way communication bewteen ROS and HoloLens using this fork of ROS# (and this is my repo). Now I do not have the device, so I cannot do the further tests with the new serialization tool.

Hi @berkayalpcakal, do you mean that #292 could have made the UWP fork obsolete? Unfortunately dwith's fork is not quite up to date and was last changed in May 2019. I'm no expert, so I don't know if there have been any important changes since then.

Hi @dnlwbr, I do not think that #292 made UWP fork obsolete. #292 just provides an additional serialization tool so that you can get rid off the Newtonsoft dependency. As far as I remember the biggest modifications in that fork are related to threading related lines of codes, which are required to get ROS# running on a UWP platform.
Even if the UWP fork is old, you can still take advantage of it. I suggest that you clone UWP fork, then search for the use of preprocessor "WINDOWS_UWP" in the entire library solution. You can compare and see what are the major modifications to get ROS# running on a UWP platform.
I would like to adapt the work in the UWP fork into current ROS#, but I do not have a UWP platform to test it, so it would be nice if you comment your experiences here.

I can't say much about it yet, but it seems that using Reflection is a problem with UWP builds, see https://github.com/dwhit/ros-sharp/issues/3#issuecomment-634006992. There is a fork that works around this problem (luchspeter/ros-sharp@6583bfd29a103111a6480ac321339015e226c1a2). If you plan to integrate UWP functionality into the current ROS#, you may want to pay attention to this.

Hi @berkayalpcakal , I couldn't find your e-mail but we're in Zurich and we can loan you a Hololens 1 device. :) (And would love a solution to the UWP problems!) Could you please get in touch with me by e-mail? eloleyni @ microsoft.com

Thank you @helenol for the offer to loan a Hololens. 😉 Our problem is not purchasing one. 😉
If we decided for officially supporting UWP (or other currently incompatible platforms) here, community would request us to maintain that in the future.
For the UWP, changes are necessary which effectively result in two different ROS# versions. This would effectively double the testing and maintenance effort for all code changes we make from then on.
In case you find a way for us to support UWP without increasing effort or harming the compatibility, performance and ease of use of other platforms, please let us know.
I want to keep ROS# as simple as it is. I hope you understand.
@dwhit kindly provided a ROS# UWP version for some time on his fork.  You, as well as everyone else here is kindly invited to provide platform-specific ROS# forks.

@MartinBischoff
We performed some minor changes to dwhit's fork and had ROS# running on the HoloLens 1. The maintenance should not be too bad I think.  The commit also removes some of the compiler-directives that differentiated between UWP/Editor/Windows platform builds etc.
I can help out if you want to.

@EricVoll I successfully deployed ROS# on HL by using your fork.
But there is a problem with message generation. It seems you modified the messages parts. When I use previous sensor_msgs/PointCloud2 generated by ROS#, it cannot be compiled in your fork. And the "rosbridgeclient" message generation is different. Could you please explain how to generate messages with your fork? Thanks
(Sorry for asking a new question. I was trying to ask it in your fork but there isn't an option for "issue")

@glennliu thanks I'll have a look at it today. Should be a quick fix :)

Here is the link to @EricVoll UWP fork of ROS#: https://github.com/EricVoll/ros-sharp


migrate  MyNativeViewManager to kotlin

Summary:

Migrate MyNativeViewManager to kotlin as part of ☂ #38825
Changelog:

[Internal][Changed]: Migrate MyNativeViewManager to kotlin
Test Plan:

Verify RN Tester runs with yarn android

@mdvacca, do you mind checking what's Facebook Internal Linter warning about? 🙏


[Delivery Session Migration Step 3] - Use delivery session.

What does this pull request do?
Deprecates action_plan_id on the action_plan_session table.
Moves from using action_plan_session table to using a delivery_session view. This will then be followed up by step 4 which will move to using a delivery_session table and removing the view.
What is the intent behind these changes?
To move towards a delivery session table, rather than action plan session.

also i wonder where do we fill in referral ids which that are unset for sessions that were created before 053b291609dae4bfc0de7e68eb1c042f8bfb56a5 was merged ?

also i wonder where do we fill in referral ids which that are unset for sessions that were created before 053b291 was merged ?

There was another pr that was merged (step 1) that backfills the referrals: https://github.com/ministryofjustice/hmpps-interventions-service/pull/568


Store vouchers on external pen drive for persistence

The voucher db should be stored on a external drive to persist in case the entire network goes down.

Has been solved, and should be working ok.


Add NavigationButton

Just thought I'd help you remember to add this snippet.

closed via https://github.com/NathanWalker/nativescript-ng2-vscode-snippets/commit/1840233f2104d8b6476680c8f31f04e2dcf50b8d
Published with 1.2.0, thanks for reminder @kenhowardpdx  👍


Overlay background colour

First of all, let me say a massive THANK YOU for this tool – it's AWESOME!
We are chroma keying the overlay over a live video input using a hardware keyer (HDMI output from a laptop into the keyer), and to do this we have to manually add some CSS via the browser dev tools to set the body background colour a specific chroma key colour (usually green).
It would be really useful if we were able to set this colour in the UI rather than having to hack it every time via the dev tools.  Is it possible to add this as an option along with the existing colour options for primary-text, indicator-highlight, and indicator-text?  So basically a body-background option (that defaults to transparent)?
🙏

I had a branch open where I was intending to add a 'custom css' thing that would be saved into settings.
I'll see if I can't bring that back sometime soon (my time on this project has admittedly stagnated a bit haha)


Refractoring Entities

Refractoring entities to use AdminLayout component.

@PepiPetrov Which entities are going to be included in this task
Please add a list so we can track them individually


fix fix forward parallel fragment instance num, and forward some session by the way

Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.6 seconds
stream load tsv:          557 seconds loaded<PHONE_NUMBER>9 Bytes, about 128 MB/s
stream load json:         20 seconds loaded<PHONE_NUMBER> Bytes, about 112 MB/s
stream load orc:          65 seconds loaded<PHONE_NUMBER> Bytes, about 16 MB/s
stream load parquet:          31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select:          29.5 seconds inserted 10000000 Rows, about 338K ops/s
storage size:<PHONE_NUMBER>4 Bytes

run buildall

run clickbench

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.65 seconds
stream load tsv:          542 seconds loaded<PHONE_NUMBER>9 Bytes, about 131 MB/s
stream load json:         20 seconds loaded<PHONE_NUMBER> Bytes, about 112 MB/s
stream load orc:          65 seconds loaded<PHONE_NUMBER> Bytes, about 16 MB/s
stream load parquet:          31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select:          29.3 seconds inserted 10000000 Rows, about 341K ops/s
storage size:<PHONE_NUMBER>1 Bytes


Incorrect umlaut and ß display

Steps to reproduce
Call up a tab or a detailed view.
Expected behaviour
Proper character set representation
Actual behaviour
Umlauts and ß are displayed incorrectly.
Device: Samsung Galaxy A13 5G (SM-A136B/DSN)
Operating System: Android 14, One UI-Version 6.1
ZAPP: 8.5.2 (72)

As the phenomenon has only been occurring for a few days and the last app update was some time ago, the cause is probably to be found in upstream Mediathekview or ZAPP components or at the broadcasters.
I am trying to find out whether the problem can be narrowed down to certain channels.

ZDF

Das kommt durch diesen Bug: https://github.com/nodejs/node/issues/54543
Habe natürlich genau mit der betroffnen Version zuletzt gebaut. Update ist deployed - sollte also wieder passen.

Phoenix live stream

Will the change only affect new programs or also programs that have already been imported into the database by Mediathekview?

The cause was this bug: https://github.com/nodejs/node/issues/54543

Thanks you very much for the fix!

Phoenix live stream

This is a separate issue.

Phoenix live stream

This is a separate issue.

@cemrich Is there already a bug report on this?


Remove Asana from Luigi users

Asana is no longer using Luigi, so for the sake of accuracy, it was suggested that we should be removed from the list of users.  The blog post that describes our use of Luigi did not include any implementation details or tips that would be useful to the broader community of Luigi users.

Thanks for the update. 👍

There is some problem in CI and we will fix it.


add property definitions

part of #66
adds definitions:

uses: A relation that holds between a continuant and another continuant it requires to function.
has_globalwarmingpotential: A relation between a portion of matter and the global warming potential it has.
is_connected_to: A relation that holds between two nodes in a graph that are connected to each other through an edge.
has_sink: A relation that holds between a directed graph and a node in that graph that has edges ending but not starting there.
has_source: A relation that holds between a directed graph and a node in that graph that has edges starting but not ending there.

as has_model is imported from RO, I added the correct inverse_of relationship to has_role_in_modeling instead of an own definition

I excluded "is_unit_of" for now bc I'm not sure how to work with it


Install coolify as an image dockerfile

Is there an existing issue for this?

[X] I have searched the existing issues

Summary
Install coolify as an image dockerfile。 Instead of using scripts
Why should this be worked on?
Applicable to different environments. And convenient

I'm closing this issue, because tracking features will be moved to GitHub discussions. Github issues will be only for bugs.
Version 4 is in full focus. v3 related issues will be closed, if it is not a critical bug.
Thanks for your understanding.


feature request: add STS endpoint to lakeFS

Since lake is a S3 server, it could be usefull to be compliant to STS endpoint API calls
https://docs.aws.amazon.com/STS/latest/APIReference/API_Operations.html
I particularly use the AssumeRoleWithWebIdentity with my S3 server (not lakeFS)

@Jonathan-Rosenberg @guy-har this might be one way to advance on Delta integration.
Personally I would probably prefer something more JWT-ish and based on the lakeFS API - otherwise we will end up adding the entire AWS IAM catalogue of services one bit at a time in order to support all coming use-cases.

Probably want more user input, use-cases, and stories before we proceed on this.


.side_set N opt is not currently implemented

The optional opt flag for .side_set is not currently implemented in the assembler. This is used in some of the common PIO examples and an example in section 3.5.4 of the RP2040 data sheet.

This may require additional code in the RP2040 CircuitPython code, cf https://github.com/micropython/micropython/blob/046164098337cc79dd0f6c710f49bdf6765aa711/ports/rp2/rp2_pio.c#L511-L522

I just spent a few hours to find this again (with examples the same as #21) - including disassembling. Can we put a notice for this in https://circuitpython.readthedocs.io/en/latest/shared-bindings/rp2pio/index.html?#rp2pio.StateMac?

@dannystaple I don't think the CircuitPython doc should be updated for it because the issue is this library. I think it should work on the CP side. Instead, an error could be thrown by PIOASM if .side_set is in the assembly.

I'm working on this now because it's needed for UART TX.

Ah, that is even better. Let me know if you need a PR tested - I can give it a go.


[Enhancement] handle const column in array_filter

Why I'm doing:
What I'm doing:
The array_filter function needs to unpack all const columns before evaluation. In fact, we can do some special handling on them.
What type of PR is this:

[ ] BugFix
[ ] Feature
[x] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Does this PR entail a change in behavior?

[ ] Yes, this PR will result in a change in behavior.
[x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

[ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
[ ] Parameter changes: default values, similar parameters but with different default values
[ ] Policy changes: use new policy to replace old one, functionality automatically enabled
[ ] Feature removed
[ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

[ ] This is a backport pr

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch

[x] 3.3
[x] 3.2
[ ] 3.1
[ ] 3.0
[ ] 2.5

@mergify backport branch-3.2


Save xmm7 in DyadicBilinearQuarterDownsampler_sse

Static analysis of chrome.dll showed that xmm7 was being used but not preserved in this function. The Windows calling convention requires that xmm7 be preserved so this change adds the necessary "PUSH_XMM 8" and POP_XMM directives to fix this.
This fixes issue #3585. This may fix a bug in Chrome but that is unknown.

Can somebody take a look? Perhaps @huili2 ? This issue may be causing random crashes, and certainly will at some point.

Uggh. I just noticed the failure. Unfortunately I'm not clear on how to analyze it and whether it is possible that my change could have caused it (as opposed to fixing an existing error). Thoughts?

Thinking about this some more - it seems odd that the test failure is on OSX, but the changes are protected by "%ifdef WIN64" (in the PUSH_XMM and POP_XMM macros).
Therefore I believe that the failure is simply a flaky failure, or otherwise unrelated to my change.

The macos tests are known to be flaky: #3563

That's good to know (about the test being flaky). Given that, is there a way to force the checks to run again? Or, more to the point, should I keep waiting or is there something else I should do to get this reviewed and landed?


Enable EventStore integration tests

Automatically download and run a EventStore instance for the integration tests

This provides better testing for #187

Darn

Tests are unstable as they sometimes fail with this exception
EventStore.ClientAPI.Exceptions.CommandNotExpectedException : Expected : ReadStreamEventsForwardCompleted. Actual : ReadStreamEventsForward
I cannot reproduce it locally and it isn't the same test that fails.

It seems like the stability problems in the EventStore integration tests were due to TCP self connects. The simple solution was to use the same EventStore server for all integration tests


[Bug] Stream of the game is flickering

Device name: Sony Bravia KD-55X75K
Device type (phone/TV): Android TV
Android version: Android TV OS 11
Current app version:  Version 0.6.1
Last working app version: N/A
Script version: Updated to latest on settings.

After the rocket animation and xbox logo, every stream of the games flickers. it's like going back and forth on the frames.
Tested games Yakuza 3, Persona 3 and palworld.
https://github.com/redphx/better-xcloud-android/assets/41981287/5c5bfd54-d73f-4992-b58f-8fb2ac0cc83e
https://github.com/redphx/better-xcloud-android/assets/41981287/741e7930-7e36-4d1e-aa37-37409b5235c2

Check #41


Bug: "Compile File" commands take longer than in vanilla Xcode projects

Describe the bug

In projects generated via rules_xcodeproj -- at least with build_mode = "bazel" -- compiling individual files with Product -> Perform Action -> Compile File (or ⌃⌘B) both compiles the file and links the library to which it belongs. In comparison, vanilla Xcode projects never link on ⌃⌘B.  The linking step might take awhile, increasing the length of the feedback loop for certain tasks compared to a vanilla project.
Reproduction steps

Make a semantically relevant change to a file and then press ⌃⌘B. (Certain changes, such as adding text to an existing comment, seem not trigger the issue. You might have to play around with this.)
Expected behavior

Only that file is compiled.
Versions

Bazel: 5.2.0
rules_xcodeproj: fef9f9b89f1c6bd1a9ee63ff9dfdf4776bc831e6
rules_apple: 1.0.1
rules_swift: as installed by rules_xcodeproj

Additional context

The behavior seems to depend on which schema is currently selected in Xcode. I see ⌃⌘B trigger a link when the selected schema is one generated from a cc_test target with a dep on a cc_library that contains the file I was compiling. But if I select the schema corresponding to the cc_library directly, then ⌃⌘B does not trigger a link.

TIL about "Compile File". Thankfully we are already looking at the XCBuildData, which thankfully has this info for us to parse:
  "_buildCommand2" : {
    "action" : "compile",
    "command" : "buildFiles",
    "files" : [
      "/Users/brentley/Developer/rules_xcodeproj/examples/command_line/Tests/SwiftGreetingsTests.swift"
    ]
  },

I should be able to get a fix for this soon.

False conclusion -- turns out in the latter case ⌃⌘B was just not building anything at all.

Part of the change will need to adjust the logic I have in place for selecting targets to build. With this, it can select a dependency target, which isn't listed in the scheme, which breaks the current target selection logic.

Sorry for the delay. Some things needed for the 0.7.1 release popped up, and enough has landed on main that I want to cut that release before adding more to it. I'll start looking into this more soon.

#976 fixes this... mostly. See the PR description, but I couldn't have it not link a merged target reliably. It will only build the dependency target though, which can cut out a lot of time. Since it's Bazel, it will still build the whole target that a file is part of, not just compile a single file.


Desmos WakaTime Support

The Tampermonkey script abandons the proxy!
It would be great if the secret key can be pasted as text in the DesModder context menu.

I'm working on this.

:O
I await eagerly for its arrival!!! Getting my WakaTime subscription prepared :)


@conda-forge-admin, please add user @juftin

Additional comment:
I'm the maintainer of this feedstock but don't have PR merging permissions

@conda-forge/core I don't have permissions to merge PRs for this feedstock


Add peer.service for kafka related instrumentation's Producer spans

Following up on https://github.com/open-telemetry/opentelemetry-ruby/pull/978, we noticed we're missing some detail for our multiple kafka instrumentations
The specification states that peer.service SHOULD be set for kafka producers.
https://github.com/open-telemetry/opentelemetry-specification/blob/a1a8676a43dce6a4e447f65518aef8e98784306c/specification/trace/semantic_conventions/messaging.md#apache-kafka

For Apache Kafka producers, peer.service SHOULD be set to the name of the broker or service the message will be sent to. The service.name of a Consumer's Resource SHOULD match the peer.service of the Producer, when the message is directly passed to another service. If an intermediary broker is present, service.name and peer.service will not be the same.

This should get added across instrumentation's in 1 go

There was some discussion here about the difficulty of figuring out which broker a message will go to in ruby_kafka.


⚠ Bofrost.de has degraded performance

In 9b10bb9, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 989 ms

Resolved: Bofrost.de performance has improved in be1acbc after 6 minutes.


Issue #20 Complete pom for release

Use sonatype parent pom
Add mandatory sections
Use toolchains to force Java 6 compilation
Minor fixes to javadoc

test this please

test this please

test this please

test this please

test this please

test this please

test this please

test this please

test this please

test this please

test this please

test this please

test this please


Sources without a URL scheme get directed to an internal reference

Description

Originally reported by @xolotl on the Make WP Slack.
Presently, the iNaturalist source URL on the production sources page is: https://search-production.openverse.engineering/inaturalist.org

It looks like this is because the API's v1/images/stats response is returning the source_url field without a scheme (e.g. inatrualist.org vs https://inaturalist.org):

We could ensure the scheme is added on the frontend, or perhaps we may even want to change this to a URLField instead of just a text field to ensure a scheme is applied. I'm happy to move the issue if the latter is preferred!
Additional context

I plan on fixing this value in the API's Django admin shortly after filing this issue, so it will (hopefully) not be reproducible in production.

Thanks for sharing this. My feelings are mixed on how to fix it. I suppose I regard it as a typo; perhaps this could just be solved in documentation. I'm not sure we actually have instructions for the steps to manually add and enable a new source in Openverse, which would be an excellent place for this.


https://try.gitea.io/Racheladm/akeib.work.git

We have written the needed data into your clipboard because it was too large to send. Please paste.

Hi @Racheladm, could you please provide some details about the issue you ran into with Live Share? Logs or repro steps would be great!

Hi @Racheladm, could you please provide some details about the issue you ran into with Live Share? Logs or repro steps would be great!

Please re-activate this issue with more context on what the issue might be.  Logs or a description of the issue would be very helpful!

Please re-activate this issue with more context on what the issue might be.  Logs or a description of the issue would be very helpful!


file extension

The file extension checking has been added. When dropping the dtd or annotation files, our tool will check the file extension to avoid reading errors.


DEV: more mods to facilitate new_type intergration

Summary by Sourcery
Integrate new coercion functionality for RNA and DNA sequences by adding coercion functions and updating the MolType class. Refactor sequence creation in parsers to improve clarity and consistency, and add tests to verify the new coercion features.
New Features:

Introduce coercion functions for RNA and DNA sequences to facilitate conversion between these types.

Enhancements:

Add an optional 'coerce_to' attribute to the MolType class to enable automatic sequence conversion for nucleic acid types.
Refactor sequence creation in various parsers to use keyword arguments for clarity and consistency.

Tests:

Add tests for the new coercion functionality in MolType to ensure correct conversion between RNA and DNA sequences.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>5
Details

15 of 15 (100.0%)  changed or added relevant lines in 5 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.001%) to 92.275%

Totals

Change from base Build<PHONE_NUMBER>0:
0.001%

Covered Lines:
34104

Relevant Lines:
36959

💛  - Coveralls


Tweak WebsiteContent permissions

Pre-Flight checklist

[ ] Testing

[ ] Code is tested
[ ] Changes have been manually tested

What are the relevant tickets?
Closes #738
What's this PR do?
Make the API request to  list WebsiteContent objects  viewable to any logged in user, not just collaborators on that associated Website.
How should this be manually tested?

Make a new normal user (not superuser) and add it as an admin collaborator to a Website
Log in as that user, and go to the metadata page for that site.
You should be able to add new instructors from a populated dropdown list.  There should be no 403 API responses.

Codecov Report

Merging #772 (304e796) into master (c17e5ca) will increase coverage by 3.16%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #772      +/-   ##
==========================================
+ Coverage   91.55%   94.71%   +3.16%
==========================================
  Files         185       90      -95
  Lines        6951     2594    -4357
  Branches     1094      564     -530
==========================================
- Hits         6364     2457    -3907
+ Misses        511      135     -376
+ Partials       76        2      -74

Impacted Files
Coverage Δ

websites/permissions.py

content_sync/pipelines/concourse.py

users/admin.py

gdrive_sync/__init__.py

main/views.py

videos/messages.py

videos/apps.py

main/serializers.py

content_sync/serializers.py

videos/constants.py

... and 85 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c17e5ca...304e796. Read the comment docs.


PnP Taxonomy Picker missing Required property, ErrorMessage,onGetErrorMessage,classname,Id,

Category
[x] Enhancement
[ ] Bug
[ ] Question
Version
SPFx: 1.10.0
"@pnp/spfx-controls-react": "1.17.0",
Expected / Desired Behavior
Taxonomy Picker control is missing the following properties. It would be great to have them.

Required
ErrorMessage
onGetErrorMessage
className
Id

Hi @Harshagracy,
Following features are now available:

required
errorMessage
onGetErrorMessage

className & id could be enhancements indeed 🙂
Hope that it helps.


Create a contact info block

Add links to social networks (LinkedIn, Facebook, Instagram), phone number, email, Telegram username, etc.

added location info in left contact block here: c4f396e9f6d316f67150bfdde6770e380819d49b
added LinkedIn info in right contact block here: 28cf16ebbb37c60d959dfa44e66a7b78df1c1661


[DOC] remove ProximityTree from distance classifier notebook results display

addition of the proximity tree classifier broke a notebook only tested on overnights, because we do not have the results for it on TSC.com. Changed the notebook to hard code the ones we do have

Could you double check outputs, seems like an error was introduced for one.

seems the https certificate is still not working properly.


[Not to merge] Enable qt test on travis. Just for testing

Enable iLib QT test (except collation feature) on Travis.  It is to see if it still does not work.

still doesn't work. closing.


Test every aspect of the framework for Version 1.0 - Browser wise, variables wise.

Because this framework will likely get big and have a lot of parts i think it would be really awesome if we could include a way to test that the framework's features are working. I thought about trying Travis CI with it but it doesn't support jinjava. I think we likely will have to create a  .html file we include in a tests folder which we add little tests to. Those of us who want to test on their portal would upload the full crankshaft repo to their portal  and open a preview for said tests html template and we would have a JavaScript file evaluate if the tests pass and output the results. Users of the framework would not use this, only contributors.
If anyone has experience unit testing please share some wisdom. This is not my area of expertise but i figure even if my method isn't the best, something is better than nothing.

I think it might be useful to use quixote a library for css unit testing.
Otherwise we can just use jquery, set a hard width on the page test px values. Print out or console log test results.
https://github.com/jamesshore/quixote

created tests folder tests base file f534168

Scratch that on quixote probably. It was last updated 2 years ago, and seems to require other testing tools to function.
Hand-rolling may be the way to go. Shouldn't be too bad overall.

Mark Ryba found this awesome tool. Seems pretty perfect for what we need.
https://www.cypress.io/


Use the new package access modifier

https://github.com/apple/swift-evolution/blob/main/proposals/0386-package-access-modifier.md
This could allow us to hide symbols that previously had to be public.

It could also solve https://github.com/kiwicom/orbit-swiftui/issues/677

Except with illustrations in a separate target, we would need at least those to still be duplicated. Other stuff though, maybe.


String Extraction doesn't work when using '::' single binding notation

When I do this:
<mydirective somelabel={{::'My Cool Label' | translate}}></mydirective>
The String Extraction part of gettext doesn't find 'My Cool Label'.
When I remove the '::' single binding 'My Cool Label' is in the bundle correctly.
My question is this, isn't it preferable to use the single binding to eliminate excessive bindings in our code?  And shouldn't that be supported by gettext?  OR is Angular smart enough to use single binding in this case anyway?

Try adding quotes:
<mydirective somelabel="{{::'My Cool Label' | translate}}"></mydirective>

Sorry, I do have double quotes... It was just my bad in transcribing it to the ticket.  I'll edit the original.


editable search views

Values and properties, and even the link hierarchy, should be editable in search views.  The only thing which is not editable, in distinction to ordinary tree views, is the collection of links between the search and the search results.

Values and properties are now editable in search views.  The hierarchy is not.

Closing; search views are editable "enough".


[CI] Removes bundler cache.

Possibly fixes CI. We'll see!
Related: https://github.com/artsy/eidolon/issues/576

Nope :disappointed:


pull request for e2e test at 12/07/2016 09:26:02

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


M3-1027 Add SSH key selection to Linode creation flow.

Purpose
Add SSH key selection to the Linode creation flow.
I created a HOC to eliminate duplication. Ill use the same on the rebuild as well.
The creation of the UserSSHKeyObjects is contained in the HOC so the consumers just use whatever is passed down.

Coverage increased (+0.006%) to 26.779% when pulling 72adf7b08e59e468c6565f19fae7526b556b00ca on rjstires:M3-1027 into 6a0fe18824d9541c2e5960ed22f1709fd7b558b2 on linode:feature/ssh-keys.

otherwise, looks good. I tested with multiple users (one restricted and one non-restricted)


TOC items don't show words when they come from components

Have you read the Contributing Guidelines on issues?

[X] I have read the Contributing Guidelines on issues.

Prerequisites

[X] I'm using the latest version of Docusaurus.
[X] I have tried the npm run clear or yarn clear command.
[X] I have tried rm -rf node_modules yarn.lock package-lock.json and re-installing packages.
[X] I have tried creating a repro with https://new.docusaurus.io.
[X] I have read the console error message carefully (if applicable).

Description
The table of contents menu seems to ignore the text of components, though the regular text nodes of the same heading are visible.
There is probably an issue for this already, but I couldn't find it.
Reproducible demo
https://codesandbox.io/p/devbox/reverent-hamilton-m5y9nl
Steps to reproduce

Make a component
Import it
Use it in a heading
See that the text is visible in the heading
Check the table of contents and see that the component's text is not there

Expected behavior
I thought the text of the component that is in the heading would be visible in the table of contents.
Actual behavior
The text of the component is missing from the table of contents, though the other text in the heading is visible.
Your environment

Public source code: https://codesandbox.io/p/devbox/reverent-hamilton-m5y9nl
Public site URL: https://codesandbox.io/p/devbox/reverent-hamilton-m5y9nl
Docusaurus version used: 3.2.0
Environment name and version (e.g. Chrome 89, Node.js 16.4): Chrome 123.0.6312.87, devbox
Operating system and version (e.g. Ubuntu 20.04.2 LTS): OSX 12.6.6

Self-service

[ ] I'd be willing to fix this bug myself.

Similar to #10018. TOC does not handle JSX.


Compilation fixes for macOS

Motivation and Context
We're evaluating Horust as process supervisor for a multi-service application.  While most of our deployments are container based, many of our developers work with macOS and local compilation.
Description
When compiling for macOS, skip Linux specific calls and signals.  In particular, the sub-reaper functionality is not available on macOS, which could cause issues in situations where a process controlled by Horust dies and leaves behind children.  For development purposes, however, this does not seem to be a major issue.
See #37 for a previous conversation on the topic.
How Has This Been Tested?
All tests pass on macOS Ventura 13.5.2 / Apple Silicon
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Performance enhancement (non-breaking change which improves efficiency)
[ ] Code cleanup (non-breaking change which makes code smaller or more readable)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation (a change to man pages or other documentation)

Checklist:

[x] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.

Thanks for this pr! Can you run a cargo fmt? Also as a nice to have, the CI can be updated to compile the mac binary.

I've run cargo fmt and added macOS targets to the binary release list - Not sure if the latter works, as I've decided to split the on-line array into a multi-line array.  Will fix if needed.


Can golang socket support IP_BIND_ADDRESS_NO_PORT ?

Can golang socket support IP_BIND_ADDRESS_NO_PORT ?

The Go project doesn't use the issue tracker for questions. See https://golang.org/wiki/Questions.


Jesse: Watch ^vijaygopal balasa$

Jesse requests the watch of the watch_keyword ^vijaygopal balasa$. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

^vijaygopal balasa$ has been seen in 0 true positives, 0 false positives, and 0 NAAs.

Approved by Jeff Schaller in Charcoal HQ


Missing migrations

Describe the bug
There are missing migrations
To Reproduce
Steps to reproduce the behavior:

Checkout project
poetry install
Goto testproject
Run poetry run manage.py makemigrations
Missing migrations get produced

Expected behavior
No migrations are getting produced
Additional context
Will append PR
Let me know if I shall change e.g. when and how makemigration check will get called, make an extra stage, just call it in one tests or whatever.
Thanks for sharing django-tasks-scheduler.
Kind regards
Raiko

PR against this https://github.com/dsoftwareinc/django-tasks-scheduler/pull/24


WIP: Enable TranslateStreamCloseWebsocketRequests feature to test websockets

This PR enables TranslateStreamCloseWebsocketRequests feature to test on CI system to get signal.

CI Jobs verified that this feature works in OCP;

https://prow.ci.openshift.org/view/gs/test-platform-results/logs/release-openshift-origin-installer-launch-aws-modern/1787363657710047232
https://prow.ci.openshift.org/view/gs/test-platform-results/logs/release-openshift-origin-installer-launch-aws-modern/1787413508749529088


Fix toggle-all input can't be checked

Fix #37 .
When the new-todo input is selected, its z-index is greater than toggle-all input, resulting in the toggle-all input can't be checked.
So I removed changing the z-Index property when an element is selected.

Are you sure it's not needed for the other selectors?

Are you sure it's not needed for the other selectors?

Yes, this is my revised version.
https://codesandbox.io/s/todomvc-changed-2lfs4?file=/index.html
The change of z-index may cause some elements can't be selected. So I used this static page to test all the elements that can be clicked, and they can all be triggered normally.


hg link not available

Hi glbase development team,
I found glbase3 very useful when doing RNA-seq analysis last year. As I just wanted to use it, however, it seems the hg clone link doesn't exit, seen as below:
$ hg clone --debug https://bitbucket.org/oaxiom/glbase2using https://bitbucket.org/oaxiom/glbase2 sending capabilities command abort: HTTP Error 404: Not Found
Could you provide any solution to this?
Your help will be appreciated.

That's right, the mercurial clone is broken as bitbucket no longer supports hg. I ported glbase3 to git, to fix, just reclone from the github repository:
git clone https://github.com/oaxiom/glbase3.git

Then git pull as needed.


PS script is producing the wrong manifest version and incorrect formats

Icebreaker (1).zip
The issue is with the language JSON files
they are all invalid according to the
v1.12
the icons are invalid.
they are smaller than the minimum specified
at least the small one
it should be 32x32

Hi @Yeemonjr,
Thank you for sharing your feedback, we'll check the PS script and the deployment using it.

Any updates?

@Yeemonjr Please update manifest version to V1.5 as the below and it will work fine.
"$schema": "https://developer.microsoft.com/en-us/json-schemas/teams/v1.5/MicrosoftTeams.schema.json",
"manifestVersion": "1.5",

Hi @Yeemonjr, please let us know if you've any updates on the response provided, if not we'll proceed with closing out the issue.


Add Ordinal Games

meta.json and inscriptions.json files follow the example formats.
First collection of playable games, inscribed <70k. Thanks!

error in my file. fixing.


feat(security): Remove Vault's healthy check in Consul

With the Vault's backend being changed from consul to filesystem, Vault's healthy check now becomes superfluous.
The original automatically generated healthy check in Vault now is gone due to Vault's backend storage is not dependent on Consul any more.
This together with edgex-go's change shall remove the dependency of Vault from Consul.
Signed-off-by: Jim Wang<EMAIL_ADDRESS>PR Checklist
Please check if your PR fulfills the following requirements:

[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/docker-edgex-consul/blob/master/.github/Contributing.md.
What is the current behavior?

Vault's healthy check within Consul
Issue Number: edgexfoundry/edgex-go#2882
What is the new behavior?
No Vault's healthy check directly from Consul
Does this PR introduce a breaking change?

[ ] Yes
[X] No

Specific Instructions
Are there any specific instructions or things that should be known prior to reviewing?
Other information
Related to https://github.com/edgexfoundry/edgex-go/issues/2882
Also see PR: https://github.com/edgexfoundry/edgex-go/pull/2886

@lenny-intel or @jpwhitemn or @bnevis-i  if you have the written permission please add @beaufrusetta, @bnevis-i, @lenny-intel, @hutchic as reviewers . I don't have that permission. Thanks.

@lenny-intel or @jpwhitemn or @bnevis-i if you have the written permission please add @beaufrusetta, @bnevis-i, @lenny-intel, @hutchic as reviewers . This is for Ireland scope. I don't have that permission. Thanks.

Yeah @lenny-intel - when do I become "git official" with EdgeX? 😆


Pressing Space in an InputText causes a Enter press (and enter press makes page go back to previous page)

When pressing space or enter on the keyboard in ImGui, the page jumps back once although it shouldn't. This is especially annoying in ImGui.inputText's since I cannot press space without it going back.
Example code;
ImGui.begin("Test");

ImGui.inputText(String, ImString);

ImGui.end();

This issue has already been addressed in the official ImGui repo and marked as fixed but I do not know how to implement their fix in java.
https://github.com/ocornut/imgui/issues/4552
I see that InputTextFlags.EnterReturnsTrue has been added but that does the exact opposite of what I want to see.
If anyone could help me on this one, that'd be great! Thanks!

You will probably have to wait for ImGui-Java to update their included imgui version to get the fix as well

ImGui was not at fault. So, what basically happend is that the button in the background from the Minecraft GUI that opens the ImGui GUI was still focused and whenever you pressed Enter or Space, it got pressed and the ImGui Window opened again thus going back to the first window. I noticed this when I tried if the same thing happens in an actual Minecraft Instance instead of the development environment (where I had sounds turned off) and I heard the typical Minecraft button "click" sound. By then, I knew something was off and I checked the code. Turns out just removing all the children from the Minecraft Screen was not enough and I also had to defocus any focused element to prevent it from being clicked. I've done this by just re-drawing everything so it loses focus and then removing the children. screen.blur(); was not enough apparently.
TL;DR:
ImGui works fine. Minecraft button was still focused, whenever space or enter was pressed, it activated. By re-drawing everything, it loses focus and then works fine.

Oh I see, I was already confused but that makes sense, thanks for clarification and sorry for the long response times.


Dealing with MacOS Catalina Notary Service

We need to figure out how to handle the MacOS notary service that causes our binaries to be untrusted.
some info from how Go is dealing with it: https://github.com/golang/go/issues/34986
Open to suggestions on how we should handle this.

go1.14 will allow us to fix this

still an issue:

still an issue:

influxdata/telegraf#8878 shows how the telegraf team set this up in their project.
Now that we've split up our build process, it should be possible to create a new CI job to sign the mac binary that runs between the mac build and the final package-and-upload step.


Hierarchical visualisation of services based on dependencies tree

The current AYS Services page shows all services for a specific repository.
In addition to showing this in a flat table we need a hierarchical representationbased on the dependencies  tree

@samaradel can you maybe give us ideas on how to do this?

Implemented in https://github.com/Jumpscale/portal9/commit/117769207523bb2ac678ae95b78e460e80f0590e


MINOR; Use underscore for variable initialization in BrokerServer

In Scala its standard practice to use _ whenever you are initializing
variables. In regards to implementation, for object references
_ initialization maps to null so there is no chance in behaviour.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

Thank you for the review. Looks good. One question though (which does not have to be addressed part of this PR), do we have a linter for scala that can enforce such best practices?

Yes there is, its called scalafix. Would just have to integrate it into gradle. There is also scalafix which works on the context free grammar linting fixes, I noticed there is a configuration for this already in Kafka but for some reason Gradle build doesn't use it (or at least it doesn't fail if there is a formatting error).


Default arrayFormat causes arrays of length 1 to be serialised the same as a string

The default arrayFormat value of none is problematic because arrays of length 1 are serialised to the same format as if the value was the string contained within the array.
For example:
qs.parse(qs.stringify({a: 'val'})); // {a: 'val'}
qs.parse(qs.stringify({a: ['val']})); // {a: 'val'} WRONG/UNEXPECTED
qs.parse(qs.stringify({a: ['val', 'val2']})); // {a: ['val', 'val2']}

Perhaps the default arrayFormat should be changed to bracket or index, which do not have this problem. The none option would make more sense IMO if it refused to stringify an array when stringifying, and ignored/crash for duplicate keys when parsing. I don't see how the comma option can be made to handle arrays consistently.

While I agree with you it's not optimal, people have been using this for years without complaining, so it cannot be that big of an issue. Not sure it's worth doing a breaking change to change the default, but we should at least make the "catches" clearer in the docs.
// @zepod @rapzo @yaodingyd Mentioning you in case you have an opinion on this.

I think better documentation would be fine, this is not worth  a code change.

I understand the importance of predictability and wouldn't condone at all any code breaking change.


moment fails to parse '1999-12-4', when new Date() can parse it correctly.

Description of the Issue and Steps to Reproduce:
moment parses '1999-12-4' as '1999-12-1'. From reading the Moment docs, this string is not in ISO 8601 format, so it would be passed to new Date(). However, manually passing the string to new Date() produces the correct parsing, as seen below.
I looked through other existing issues could not find that this case had already been reported.
Reproduction in the Node.js console:
> moment('1999-12-4').toString();
'Wed Dec 01 1999 00:00:00 GMT-0500'
> new Date('1999-12-4');
Sat Dec 04 1999 00:00:00 GMT-0500 (EST)

Please include the values of all variables used.
Environment:
Moment 2.15.1, Node 4.4.4, Ubuntu 16.04
Thu Oct 13 2016 13:31:06 GMT-0400 (EDT)
10/13/2016, 1:31:06 PM
240
2.15.1

You need to specify a format string.
moment('1999-12-4', 'Y-M-D')

To be clear - new Date(string) is only required to parse ISO8601 by the ECMAScript spec, and it does it poorly and inconsistently across different implementations.  Beyond that, it can parse whatever it likes - which again leads to inconsistencies.  We don't like falling back to the Date constructor, and are not looking for feature parity with any particular implementation.

So you are OK with this silent parsing failure? If I need to specify a format string to get a correct result, why isn't it required?
It seems this string is detectably NOT an ISO 8601 string, since it doesn't follow the YYYY-MM-DD format.
Also, bug is clearly not with new Date() in my environment. As my sample demonstrated, new Date() gives the correct result for this string in my environment. It seems moment is somehow transforming the string before it's passed to new Date() and that's the bug.
If Moment can't parse the string correctly, it should pass the unaltered string to new Date()

Also note that the example does not trigger the "Is not ISO" deprecation warning, indicating that date--which is not ISO format-- is being recognized and treated as a ISO date anyway, which is a bug.
From reading the related code here:
https://github.com/moment/moment/blob/develop/src/lib/create/from-string.js
It looks like there may be a problem with one the ISO regexes. As I read them, they anchor matches to the beginning of the input string and as long as they find a match at the beginning, the end of the string is ignored. Here's another example which shows that:
> moment('1999-12-this could be anything').toString();
'Wed Dec 01 1999 00:00:00 GMT-0500'

This could be fixed by making sure the ISO regex is designed to match the entire string, not just content at the beginning of the string. That would prevent this kind of garbage-in-garbage-out bug.

I'm working on a fix now.

Please check out related PR #3502 for my proposed fix and discussion of other non-ISO dates in the test suite which the fix turned up.


Have us run the Promises/A+ via a JavaScript bridge

We have re-implemented the suite as Swift, but this means:

We don't test Guarantee & AnyPromise (though since all the code is now in Thenable this probably is not a big deal).
Any updates to the suite do not come our way.

A JS bridge shouldn’t be a large undertaking and would give us the additional reassurance that we didn't make any mistakes.

Fyi since I had experience with JSC from a past job, I've started working on this here: https://github.com/ldiqual/PromiseKit/tree/lois-jsaplus/Tests/JS-A%2B
Some (most?) of the tests pass but I still have a large amount of debugging to do. Working with JSC is pretty tedious since stacktraces don't have line numbers.

Wow! Amazing work.


Introduce ClusterType

Type of change

[ ] Refactor
[x] New feature
[ ] Bug fix
[ ] Optimization
[ ] Documentation Update

Description
Platforms should be [aws,gcp,azure] (not the full list, just an example.)
ClusterType can be self-managed or rosa/ what is set for red-hat-clustertype
Related Tickets & Documents

Related Issue #
Closes #

Checklist before requesting a review

[ ] I have performed a self-review of my code.
[ ] If it is a core feature, I have added thorough tests.

Testing

Please describe the System Under Test.
Please provide detailed steps to perform tests related to this code change.
How were the fix/results from this change verified? Please provide relevant screenshots or results.

lgtm


Docker containers with --net=host --pid=hosts show up as uncontained

Could you give the example of the container you started, and the gist of /api/report?  Thanks!

I did:
vagrant@ubuntu-14:~$ docker run -dti --pid=host --net=host alpine /bin/sh
cf4afccb976f2849846aae60e2e75346425998287732f0553402527c931a6839

And got a container, as expected:

@errordeveloper do you have any reproduction steps?  I'm going to close this, please reopen if you can reproduce (with master).


Add an option to notify admin when sync breaks

It would be useful if the daemon would somehow notify admin when things go wrong (e.g. database schema has changed, unable to access project) - currently it just silently stops.
Maybe sending an email to the admin would help - or send a notification to slack...

We've added email notifications to our Lutra stack (db-sync and WP's) and it works great for notifying us when things go wrong. would be great if a user could specify email addresses in the config.ini file to receive error notifications

It would be good to receive a notification indicating the name of the project that interrupts synchronisation & work of the db-sync container? Or perhaps it is possible for the notification to include a note about the nature of the error (e.g. schema changed for X project, deletion of containers already in progress, or not enough free space on disk) or sending log file?


docs: grammatical errors fixed

Description
This paragraph in the readme file is updated.

Note: We do check in yarn.lock file. So it's advised to use yarn package manager. If you need to use any other package manager, remove yarn.lock file from the local directory first. Also, do not check in any other lock file.

Fixes #78
Type of change

[x] Change in documentation.

Checklist:

[x] I have performed a self-review of my changes.
[x]  My changes generate no new warnings.

Hey @shashankbhatgs Thanks for improving it. Accepting.

Thank you!


Renderer in built executable cannot find @electron/remote

Found an issue or bug with electron-vue? Tell me all about it!
I am trying to import dialog in the renderer process.
It works fine when serving directly (electron:serve).
It does not work when building an executable and launching that (electron:build).
It is unclear to me if this is a user error.
Describe the issue / bug.
I am importing like this in my Vue project:
const { dialog } = window.require("@electron/remote");

This works when running with npm run electron:serve.
It fails to produce a working application when run with npm run electron:build.
The development console:
internal/modules/cjs/loader.js:887 Uncaught Error: Cannot find module '@electron/remote'
Require stack:
- electron/js2c/renderer_init
    at Module._resolveFilename (internal/modules/cjs/loader.js:887)
    at Function.o._resolveFilename (electron/js2c/renderer_init.js:33)
    at Module._load (internal/modules/cjs/loader.js:732)
    at Function.f._load (electron/js2c/asar_bundle.js:5)
    at Function.o._load (electron/js2c/renderer_init.js:33)
    at Module.require (internal/modules/cjs/loader.js:959)
    at require (internal/modules/cjs/helpers.js:88)
    at Module.cd49 (App.vue:40)
    at o (bootstrap:79)
    at Object.0 (app.4ede792c.js:1)

If relevant, here's how the main window is created:
  const mainWindow = new BrowserWindow({
    // skipping dimensions and title...
    webPreferences: {
      nodeIntegration: true,
      contextIsolation: false,
      enableRemoteModule: true,
    },
  });

How can I reproduce this problem?
Import @electron-remote like this:
const { dialog } = window.require("@electron/remote");

Run npm run electron:build.
Run the executable.
Tell me about your development environment.

Node version: 15.14.0
NPM version: 6.14.8
vue-cli version: (if necessary) 4.5.12
Operating System: Windows 10 x64

Probably an issue with @electron/remote, but I don't see how to bundle it with electron-vue.

@MrManny the same issue with electron-builder package (without vue). maybe the problem is with version of "electron-builder": "^22.10.5" your?
Uncaught Error: Cannot find module '@electron/remote'
Require stack:
- /Applications/TagSpaces.app/Contents/Resources/app.asar/app.html
    at Module._resolveFilename (internal/modules/cjs/loader.js:887)
    at Function.o._resolveFilename (electron/js2c/renderer_init.js:33)
    at Module._load (internal/modules/cjs/loader.js:732)
    at Function.f._load (electron/js2c/asar_bundle.js:5)
    at Function.o._load (electron/js2c/renderer_init.js:33)
    at Module.require (internal/modules/cjs/loader.js:959)
    at require (internal/modules/cjs/helpers.js:88)
    at new electron_io_ElectronIO (electron-io.ts:67)
    at Object.<anonymous> (platform-io.ts:27)
    at __webpack_require__ (bootstrap:63)

@MrManny did you manage to solve this?


Google is shutting down OpenID 2.0

See: https://developers.google.com/accounts/docs/OpenID#shutdown-timetable

I've updated things to theoretically support this, but the results we're getting back from google seem to be inconsistent with what we had stored before. I'm guessing that the tokens returned vary based on the openid.realm parameter that we're passing, but I don't know what the old one was.
One of the main issues I'm running up against here is that I don't have one of the old Google OpenID tokens for my account, so I can't verify things well. If anyone who's signed in to the OSB site with Google OpenID in the past has time to help my debug this, it would be greatly appreciated.


Bug with complex dtype with msgpack.

I need this merge very soon for a demo on Monday. So I do it it now...


After focusing field, weird second scroll adjustments (video showing)

I'm having this weird "second adjustment" delayed behavior, my keyboardOpeningTime is set to 0.

Btw I just managed to avoid this "second adjustment" disabling the scroll if keyboard is opened. Not ideal but for my case doesn't matter

@matheuscouto nice trick, I made a custom component that implements this and it works like a charm :
`const MKeyboardScrollView = (props: MKeyboardScrollViewProps) => {
// States
const [keyboardOpen, setKeyboardOpen] = React.useState(false);
useEffect(() => {
const keyboardDidShowListener = Keyboard.addListener('keyboardDidShow', keyboardDidShow);
const keyboardDidHideListener = Keyboard.addListener('keyboardDidHide', keyboardDidHide);
return () => {
  keyboardDidShowListener.remove();
  keyboardDidHideListener.remove();
};

}, []);
const keyboardDidShow = () => {
console.log('Keyboard Shown');
setKeyboardOpen(true);
};
const keyboardDidHide = () => {
console.log('Keyboard Hidden');
setKeyboardOpen(false);
};
function dismissKeyboard() {
if (Platform.OS != 'web') {
Keyboard.dismiss();
}
}
return (
<KeyboardAwareScrollView
extraScrollHeight={Platform.OS === 'ios' ? 20 : 0}
enableResetScrollToCoords={true}
enableAutomaticScroll={!keyboardOpen}
bounces={false}>
<ScrollView style={{ flexGrow: 1 }}>

{props.children}

);
};`

@alexyca
hello, i'm trying your solution.
On IOS i have a weirds effect on keyboard, it's close and open when i click next (in keyboard pan) between two inputs

i use exact same code you posted.
Did you have this behavior or a fix please ?
thanks

@alexyca hello, i'm trying your solution. On IOS i have a weirds effect on keyboard, it's close and open when i click next (in keyboard pan) between two inputs

i use exact same code you posted.
Did you have this behavior or a fix please ? thanks

I never used "next" button before 😅 !
However, you could add a "trick" from my script by upgrading dismisskeyboard function by checking the type of event that trigger the function, you may be able to differenciate physical touch event and next button event on keyboard ?

@alexyca use autoFocus ={true} on every field u can set it to true on next press of previous field


Would you consider a pull request that adds an Html helper capability?

Hey Matt, would you consider a pull request that added in an HTML helper? That would let us render a bootstrap icon inside of another html helper like a grid.
e.g.
`
@(Html
.Grid(Model.Items)
.Build(columns =>
{
columns.Add(model => Html.BootsrapIcon("AlarmFill", 24, 24, new { data_toggle = "modal", data_target = "#modal", data_content = model.FilamentDescription }));
etc....
`

Hi Neil,
That is an interesting proposal. I've never seen that .Grid() method, is that a library? I ask because I'm wondering if this method is expecting whatever Html.BootstrapIcon() to return a particular type, such as IHtmlContent. I don't think this would be a problem.
One thing to note: The icon names are automatically generated into an enum, so no need to use a string. This wouldn't change your example code that much, but it does provide IntelliSense for the Razor tag helper and would presumably work for this method as well.
Apologies for the delay. I do accept pull requests if you want to give it a shot. I'm working on updating dependencies, including the latest Bootstrap icons v1.10.x


scalameta pickling

given
https://github.com/MasseGuillaume/cats/commit/b5d25c3cd99b05b59df3ea0477d800319051285d
when
sbt ";core/compile;metadocCompilerPlugin/console"
pickling fails with:
fatal error: unpicklee cache is corrupted at 7

The error message is coming from https://github.com/scala/pickling/blob/v0.10.1_2.11/core/src/main/scala/scala/pickling/internal/package.scala#L152-L161 likely some issue in structure sharing.

@eed3si9n is right, it's an issue with structure sharing. You can try to disable structure sharing:
import scala.pickling.shareNothing._

For the next pickling release we should get scalameta pickling working.

@phaller If i disable structure sharing I get a stack overflow. I think this is because in the AST a node has a reference to his parent and vice versa. So there is a loop.

@MasseGuillaume I see. Then, indeed, structure sharing is required. It would be helpful to have a smaller example that exposes this bug, though.

@phaller there you go: https://github.com/MasseGuillaume/scalameta-pickling-issue

@MasseGuillaume Great, thanks! I'll have a look at it.

@MasseGuillaume I'm running into issues building the meta project (plugin builds fine):
[error] 669 errors were encountered during merge
[trace] Stack trace suppressed: run last plugin/*:assembly for the full output.
[error] (plugin/*:assembly) deduplicate: different file contents found in the following:
[error] /Users/phaller/.ivy2/cache/org.scalameta/scalahost_2.11.7/jars/scalahost_2.11.7-0.1.0-SNAPSHOT.jar:org/scalameta/adt/AdtMacros$$anon$1.class
[error] /Users/phaller/.ivy2/cache/org.scalameta/foundation_2.11/jars/foundation_2.11-0.1.0-SNAPSHOT.jar:org/scalameta/adt/AdtMacros$$anon$1.class
[error] deduplicate: different file contents found in the following:
[error] /Users/phaller/.ivy2/cache/org.scalameta/scalahost_2.11.7/jars/scalahost_2.11.7-0.1.0-SNAPSHOT.jar:org/scalameta/adt/AdtMacros$$anon$2.class
[error] /Users/phaller/.ivy2/cache/org.scalameta/foundation_2.11/jars/foundation_2.11-0.1.0-SNAPSHOT.jar:org/scalameta/adt/AdtMacros$$anon$2.class
...

Any hints how to resolve this?

@xeno-by ping
@phaller
delete your ivy cache rm -rf ~/.ivy2/cache/org.scalameta/
and  publishLocal scalameta projects in the following order:

scalameta
interpreter
scalahost

OK, perfect, thanks!

@MasseGuillaume should work now, but I really have no clue how to fix it in the long run unless sbt changes the way they handle compiler plugins.

@MasseGuillaume I can build and run the compiler plugin now, but I couldn't reproduce the bug, yet, unfortunately. I'll keep looking.

@phaller if you need help we can do a Google Hangout. You can send and chat invite to<EMAIL_ADDRESS>

@MasseGuillaume OK, sounds good!

meta/test

@phaller any updates ?

@MasseGuillaume sorry, I had to context-switch to other things. However, I found out that it was trying to use the runtime pickler/unpickler which caused issues. I think we need to try to have picklers generated systematically for all involved classes. If picklers cannot be generated via the Pickler.generate macro, try custom picklers.

@MasseGuillaume I just finsihed a custom pickler tutorial, if you need: https://github.com/scala/pickling/wiki/Writing-custom-Picklers-Unpicklers
Let me know if you need any help getting scala-meta compiled using picklers.

@jsuereth thanks I will try this approach ;-)


chore: migrate from kuttl to chainsaw

Migrate from kuttl to chainsaw.

cc @eljohnson92

Folks, can anyone give a look ?

@eljohnson92 i addressed your comments, can you give it a try ?

@eljohnson92 done

LGTM, working locally. good to merge this in

LGTM, working locally. good to merge this in

Cool, thanks !
I will open another one tomorrow.


How to secure access to the Admin API? [question]

How to secure access to the Admin API?
I run my Kong instance in AWS in a private VPC behind an ELB with a public IP.
The proxy (port 8000) is available to the public via ELB on port 443.
The admin API is also available on the ELB on a different port but a security group policy on the ELB blocks access from the internet. The access is allowed only from my internal network.
I want to add more security to the admin api so even the requests from the internal network will have to be authenticated.
Should I just create a proxy on Kong to its admin API and add a BasicAuth plugin?

yes, route it through kong and add an authentication plugin
see also https://groups.google.com/forum/#!topic/konglayer/veIk6o-UXuY

This subject is worth a documentation section but it has not been written yet. We always suggest various ways of doing so (that also combine together), including the solution you thought of:

Configure a firewall
Looping through Kong (the solution you proposed, maybe combine with firewalling)
Editing the Nginx configuration available in kong.yml (in the Admin API server block) to add directives such as the auth basic module.

All 3 are described in details in the Google groups here and here.

Later this year we'll also release a new product to manage, monitor and secure your Kong cluster.

We have created a web based Kong Admin Manager. And with this manager you could secure your Kong Admin API with one click. You can check details from our blog post https://apiplug.com/blog/web-based-kong-api-gateway-manager/

That Trick to route it through  kong and add an authentication plugin and also add firewall to block 8001 i was wondering if there is a possible way on how we can reduce internal breach even if someone landed into server

@sonicaghi  With reference to the comment around the ability to manage / secure a kong cluster, is there any update as to what that looks like??
Many Thanks
Marty

Hi @marty2bell - I don't have a specific update for you at this time, except to say that this remains a priority here at Mashape, and we look forward to having more to share with you later this year.
Perhaps you have a wish list for me? :)  What would you like

the ability to manage / secure a kong cluster
to look like?

In the near future, it will also be possible to disable the Admin API on given nodes. It might make it easier to secure your cluster if you only have to worry about one or two nodes listening on :8001.
Note that the solution suggested here:

Editing the Nginx configuration available in kong.yml (in the Admin API server block) to add directives such as the auth basic module.

Gets much easier with #2355.

i think this needs to be reopened, adding the admin api to the normal api interface seems like a sub par solution.
I have created a pull request: https://github.com/Mashape/kong/pull/2572 to allow securing the admin api with an acl and/or basic authentication

We have published a doc that highlights some of the best practices we suggest when considering securing the Admin API: https://getkong.org/docs/0.10.x/secure-admin-api/

This subject is worth a documentation section but it has not been written yet. We always suggest various ways of doing so (that also combine together), including the solution you thought of:

Configure a firewall
Looping through Kong (the solution you proposed, maybe combine with firewalling)
Editing the Nginx configuration available in kong.yml (in the Admin API server block) to add directives such as the auth basic module.

All 3 are described in details in the Google groups here and here.

sloved this issue,thanks

Hi all,
A whole section of the documentation has since been written on the topic of securing the Admin API: https://docs.konghq.com/1.0.x/secure-admin-api/
Hope that is helpful to some of you or future readers.
Cheers,


Inject document instead of accessing it directly

Injects the DOCUMENT directly into the directive's constructor.
Possibly we can now remove the if (!isPlatformBrowser(this.platformId)) checks?

have found the origin as https://github.com/arkon/ng-click-outside/pull/18/files
will check if there is some documentation on how document works in that regard


✨ use coro-context-manager

add https://github.com/zschumacher/coro-context-manager as a dep

Codecov Report

Merging #23 (9a69c6e) into main (d824f38) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #23   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           17        17
  Lines          532       521   -11
  Branches        87        72   -15
=========================================
- Hits           532       521   -11

Flag
Coverage Δ

3.10
?

3.7
?

3.8
100.00% <100.00%> (ø)

3.9
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pydapper/utils.py
100.00% <ø> (ø)

pydapper/commands.py
100.00% <100.00%> (ø)

pydapper/main.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d824f38...9a69c6e. Read the comment docs.


mobiruby.org is hacked

WARNING: Do NOT do this at work as it MAY get you a visit from HR
I was looking at the Wiki here  https://github.com/mruby/mruby/wiki and clicked on Mobiruby.org thinking that I would learn about mobiruby and was redirected to a porn site.
Can someone please fix this?

MobiRuby.org domain has been released long ago and now owed by another person.
I edited Wiki's URL.

Thanks! I have emailed @masuidrive and requested him to fix it on his Github repo also.

Sorry, This project was closed. so I leased mobiruby.org domain.


Style Transfer for Custom Images

Deep Learning Simplified Repository (Proposing new issue)
:red_circle: Project Title :  Style Transfer for Custom Images
:red_circle: Aim : To apply the artistic style of one image to the content of another image using various style transfer algorithms and determine the most effective method through comparative analysis.
:red_circle: Dataset :  Custom images collected from diverse sources to ensure a variety of styles and contents for comprehensive testing.
:red_circle: Approach : Perform exploratory data analysis (EDA) to understand the characteristics and distribution of the custom images.
Implement and compare multiple style transfer algorithms:
Neural Style Transfer using VGG-19
Fast Style Transfer
Adaptive Instance Normalization (AdaIN)
StyleGAN-based approach
Evaluate the performance of each algorithm by comparing the visual quality and accuracy scores of the styled images.
Determine the best-fitting algorithm based on the comparative analysis results.

📍 Follow the Guidelines to Contribute in the Project :

You need to create a separate folder named as the Project Title.
Inside that folder, there will be four main components.

Images - To store the required images.
Dataset - To store the dataset or, information/source about the dataset.
Model - To store the machine learning model you've created using the dataset.
requirements.txt - This file will contain the required packages/libraries to run the project in other machines.

Inside the Model folder, the README.md file must be filled up properly, with proper visualizations and conclusions.

:red_circle::yellow_circle: Points to Note :

The issues will be assigned on a first come first serve basis, 1 Issue == 1 PR.
"Issue Title" and "PR Title should be the same. Include issue number along with it.
Follow Contributing Guidelines & Code of Conduct before start Contributing.

:white_check_mark: To be Mentioned while taking the issue :

Full name : Anushka Saxena
GitHub Profile Link : anushkasaxena07
Email ID<EMAIL_ADDRESS>Participant ID (if applicable):
Approach for this Project :Perform exploratory data analysis (EDA) to understand the characteristics and distribution of the custom images.
Implement and compare multiple style transfer algorithms:
Neural Style Transfer using VGG-19
Fast Style Transfer
Adaptive Instance Normalization (AdaIN)
StyleGAN-based approach
Evaluate the performance of each algorithm by comparing the visual quality and accuracy scores of the styled images.
Determine the best-fitting algorithm based on the comparative analysis results.
What is your participant role? (Mention the Open Source program)

Happy Contributing 🚀
All the best. Enjoy your open source journey ahead. 😎

Neural Style Transfer using VGG-19
Fast Style Transfer
Adaptive Instance Normalization (AdaIN)
StyleGAN-based approach

All the four above mentioned models will going to be implemented for the problem statement right?
Also can you ensure the source of the dataset?


Please, add language selection to Powertoys

Description of the new feature / enhancement
I've just downloaded Powertoys 0.76.2 only to find out that there's no language selection in it -- unless I'm too thick to find it, in which case disregard this and please tell me where.
This is bonkers to me.
My computer came with Windows 10 Home in PT-BR, but I installed the EN-US language pack. That created a jumbled mess of the interface in English with many Windows apps (Photos, Calendar, Calculator...) in Portuguese and no way to change that. That's a huge oversight that is unacceptable even if it affects a small number of users.
But I didn't expect that same behavior from Powertoys. That's the tool we download to go beyond the meat and potatoes of Windows and should have some special attention to such details. The entire app is in Portuguese and the settings have nothing about switching languages.
I suspect a registry hack might do the trick, but that's not reasonable to expect even from people installing Powertoys. In any case, I'll immediately look that up after I post this, but, I insist, it should be a native feature.
Ideally, Microsoft would fix this issue system wide, but I believe at least the Powertoys team could add this functionality more easily.
Scenario when this would be used?
If someone is using windows originally in one language but with a language pack installed, Powertoys will display in the base OS language instead of the display language, which can keep the user from understanding which feature is which.
Ex.: A shared computer has Windows originally in German, but one account has English as display language. Powertoys would be displayed in German and the English-speaking user would not be able to use it.
Additionally, users may choose to set the app to a specific language, possibly for support purposes so they can follow instructions.
Supporting information

Note the Powertoys window on the left in Portuguese with no option to change language while the rest of the system is in English.

/dup #7670


Persistant Panel Doesn't Activate

With the new update, the Persistent Panel isn't working. I tried the trick of selecting "none" and then selecting the option to show it, but it isn't working this time.

Oh, thats strange why only this option have trouble. Can you please run this command in terminal and post output?
defaults read com.0804team.KeyClu activationPersistentKeyType

output = 1

Hey CMWalt,
I've identified an issue, and it will be addressed in the upcoming release.

Hey CMWalt,
New released is available now. Please let me know if you encounter any issues.

The persistent panel still doesn't show. Have you tested it using Mission Control?

That's a new factor to check out. Let me investigate it.


Pass source vertex, degree, etc. values from command line as arguments

Modify code in all implementations so that any algorithm parameters are configured through the command line instead of being hard-coded

As of 6e6730e6e89e105b1b1b17bbb89e2282370c7938 this enhancement has been implemented.


Remove USDC transactions from Ethereum coin

@colourfreak please check the latest version and close if complete.

@colourfreak please check the latest version and close if complete.


Improve min and max logic

Currently the min, max, minBy and maxBy use a simple comparison to check which is the greater/smaller value, and returns the value accordingly.
However, in cases where a comparison is not possible (eg comparing undefined or an alphabetic character with a number), it simply returns the second value, since the expression evaluates to false.
This means that the following executed functions return different results:
min(1, 'a')
min('a', 1)

This PR checks whether at least one comparison result is true before returning a value, and throws an error if not.
Additionally, although it could be argued that there is no 'min'/'max' when the function is supplied with two of the same value, since one is not greater/less than the other, practically I believe one would expect a returned value rather than an error in this scenario. Therefore the latter of the two (equal) values is returned.
Note: I notice the trim test failing locally, although this is happening on master too so shouldn't be caused by this PR.

Thank you very much for your well-written and well-considered PR.
While I need a little more time to consider this, I do have some serious objections.
First, Ramda is extremely wary of throwing exceptions.  Functions that throw exceptions do not compose well, and improving functional composition is one of the main themes of the library.  Ramda has mostly subscribed to the Garbage In/Garbage Out philosophy.  If you supply what the function is designed to take, then we'll do what's expected.  If you don't, anything might happen.
Second, I'm not happy with introducing equals here.  These are so far a very efficient function, and they operate on the JS notion of comparison.  But with equals, we're adding a fairly heavy-weight function and we are sometimes precluding the JS comparison.  Moreover, doing this, is a surprising breaking change, and not only for those supplying incompatible types.  For instance:
const max2 = (a, b) => {
  if (equals (a, b)) { return a; }
  if (a > b || b > a) { return b > a ? b : a; }
  throw new TypeError('cannot compare ' + toString(a) + ' with ' + toString(b));
}

const foo = (id, val) => ({  // or a class or constructor function
  id,
  val,
  equals: (that) => that.id == id,
  valueOf: () => val
})

const first = foo ('a', 5)
const second = foo ('a', 7)

console .log (max (first, second))   //=> {id: "a", val: 7}
console .log (max2 (first, second))  //=> {id: "a", val: 5}

(This has to do with the fact that Ramda's equals delegates to an equals method on the objects if they have one.)
So I'm not really happy with this implementation.  But I agree that there is probably something to fix if we can't guarantee that, for instance,  max (a, b) === max (b, a).  So I think something should be done.  I haven't yet tried to think about what that is, though.

@CrossEye thanks for the reply - both points make a lot of sense.
I think based on the Garbage In/Garbage Out philosophy, we could probably simplify the scope of the PR, and just check whether both arguments are defined before making the comparison. This was my original use case, where the function being passed undefined was causing some unpredictable results.
I see it less likely that people will try to compare 'a' to 1, vs 1 to undefined, for example.
That would allow us to remove the equals function, and only throw an error where we really need to - or possibly even treat undefined in the same way as JS treats null, which is to treat it like 0 in terms of the comparison operator.
(Not sure about this one, but could be done if we really don't want to throw an error).

@abrwn:  What if we use the four-part logic resulting from a < b and a > b?  If these differ, return the appropriate value.  If they're both true or both false, then we make a consistent, but arbitrary choice, perhaps the one with the alphabetically earlier "typeof" result, and if that fails, the one with the alphabetically earlier result from R.toString, and only if that fails, choosing the the first one for min and the last one for max.  (This last might involve a minor backward incompatibility, but I think it would help if we wanted to use these in any stable sorting algorithm.)
I thought we might need two isNaN checks in there as well, but for NaN, it simply doesn't matter which value we return.
This would let us avoid ever throwing, and would defer the heavyweight toString call until all other options have been exhausted.

Hi, thanks for contributing, I love seeing this much engagement :)
I don't have strong opinions here,
my 2 cents are that I would not want this (or any other function in this) library to oversee too much how it's used...
There are many functions here that if called the wrong way may lead to unexpected behaviours.
We should simply not call min (etc.) with something that isn't either a number or something that can be lexicographically compared (e.g. dates and strings).
e.g.:
R.min(10, 20); // 10

R.min('a', 'b') // 'a'

R.min(new Date(2021, 10, 10), new Date(1986, 6, 16)) // May 16, 1986

R.min(undefined, null); // invalid function call
R.min({}, []); // invalid function call

for instance, R.map(R.toUpper, null) just leads to a js error... and that is fine imho

@hitmands:

I would not want this (or any other function in this) library to oversee too much how it's used...

Yes, that's generally been Ramda's philosophy.  I don't really want to change that.  But we do avoid throwing errors as much as possible.
And even when we say all bets are off when a function is misused, when we can give guarantees about certain features, it would be nice to do so.
Thus, although we've never really stated them, there are laws that I would expect, say, min to uphold, even with bad data:
for all a, b, c
    min (a, b) = a  or  min (a, b) = b          (closed)
    min (a, b) = min (b, a)                     (commutative)
    min (a, min (b, c)) = min (min (a, b), c)   (transitive)

This PR demonstrates that we're violating commutativity (transitivity as well.)  I think we could reasonably fix these functions to avoid that without too much effort.  It cannot be perfect -- it's JS after all -- but it can become at least more consistent.

@CrossEye @hitmands @customcommander thanks all for input.
So would @CrossEye 's suggested approach, where we choose a max or min based on a set criteria be acceptable, as a balance between making these functions more predictable, and avoiding introducing heavyweight functions and/or throwing errors?
https://github.com/ramda/ramda/pull/3197#issuecomment-964522880
Happy to apply this if so.
@CrossEye by the way, AFAIK a < b and b < a will never both be true, but they can both be false if the expression can't be evaluated. Which may simplify the logic slightly.

@abrwn:

By the way, AFAIK a < b and b < a will never both be true, but they can both be false if the expression can't be evaluated. Which may simplify the logic slightly.

D'oh!   😉
Yes, although I might still implement it with if ((a < b) == (b < a)).  But any implementation that captured the three cases would work.
I think this would be a good compromise between what we really want and what JS will allow us.
-- Scott

@abrwn:
Are you interested in updating this PR in the manner discussed?  If not, do you mind if we close this and open another PR for that?

No problem at all.  We've never been quick around here.  But we are trying to speed up.

@CrossEye I've pushed a new commit based on the above discussion, using the string-based comparisons mentioned.
Ready for re-review.

@abrwn I'm going give it a re-review this weekend with the intention to merge next week at the latest if all is good.

One minor nit. Otherwise this looks great.

Thanks - updated.
Also realised I was using const instead of var so updated that.


Update description for running RISC-V compliance

The RISC-V compliance test system requires an absolute path to the
executable or one which starts at riscv-test-suite/*.
I would be happy if someone could verify that a relative path starting in $RISCV_COMPLIANCE_REPO_BASE does not work.

Yes, it needs to be an absolute path (or a relative path to a base that doesn't seem logical). Thanks for the update!

Yes, finding the starting point of the relative path was not so straightforward as I would have hoped.
And I thought it is easier to just recommend the absolute path.


\Zend\Http\Response mbstring.func_overload + utf8 + transfer encoding chunked = corrupt http response parser.

This issue has been moved from the zendframework repository as part of the bug migration program as outlined here - http://framework.zend.com/blog/2016-04-11-issue-closures.html

Original Issue: https://api.github.com/repos/zendframework/zendframework/issues/7653
User: @olegserov
Created On: 2015-12-19T21:04:21Z
Updated At: 2016-02-13T15:33:40Z
Body
I'm using mbstring with mbstring.func_overload = 6 (http://php.net/manual/en/mbstring.overload.php)
I was using zend http client to make http requests. One of my requests failed. This error disappears when I'm switching from Zend\Http\Client\Adapter\Socket to Zend\Http\Client\Adapter\Curl, but anyway it is a nasty error with popular mbstring module. I've debugged it to this simple test case.
As you can see when you use utf8 you get a longer content than when you are using 8bit encoding.
This is what it forgets to remove "\r\n0\r\n\r\n"
Here is the request: log.txt
$responseRaw = file_get_contents('log.txt');

assert(ini_get('mbstring.func_overload') == 6);

mb_internal_encoding('8bit');
$res = \Zend\Http\Response::fromString($responseRaw);
$_8bit = $res->getBody();

mb_internal_encoding('utf8');
$res = \Zend\Http\Response::fromString($responseRaw);
$_utf8 = $res->getBody();

echo "8bit=" . md5($_8bit), "; len=", mb_strlen($_8bit, "8bit"), "\n";
echo "utf8=" . md5($_utf8), "; len=", mb_strlen($_utf8, "8bit"),"\n";
// Outputs
// 8bit=c4c2fe78e727b96adbb1f4cbd1187ff2; len=35001
// utf8=ec9b49502969cfd63e382014a29c3e5f; len=35008

This repository has been closed and moved to laminas/laminas-http; a new issue has been opened at https://github.com/laminas/laminas-http/issues/17.


Throw invalid_grant when invalid token request with PKCE

When providing an invalid authorization_code in a token request with a PKCE code_verifier, throw invalid_grant, as per RFC 6749. It is consistent with behavior in OAuth2AuthorizationCodeAuthenticationProvider#authenticate
When providing an invalid code_verifier, throw invalid_grant, as per RFC7636.

There is an additional corner-case in OAuth2ClientAuthenticationProvider#authenticatePkceIfAvailable, when there is no code_challenge in the authorization request and the client requires PKCE.

In the "normal" case, that should not be possible because the OAuth2AuthorizationCodeRequestAuthenticationProvider#authenticateAuthorizationRequestwill throw an invalid_request`.
There might be an edge case where the client configuration changes between the time an authorization code is issued and the time it is exchanged for a token.

I am unsure what we should throw in this case, I put invalid_grant for consistency, feel free to change it.

Thanks for this fix @Kehrlann ! This is now in main.


HTTP3 over local mode: Unable to access certain websites using firefox via HTTP3

Problem Description
Firefox fails to access cloudflare-quic.com over HTTP3 while using mitmproxy in local mode. Other websites such as http3.is load up normally using HTTP3
refs #7025
Steps to reproduce the behavior:

Start local mode: mitmdump --mode local:firefox --set experimental_transparent_http3=true
Start firefox and access http3.is to ensure HTTP3 works
Accessing cloudflare-quic.com does not work over HTTP3

Error raised: TLS Error: [('SSL routines', '', '')]
Server QUIC handshake failed. unknown error (0x128)
Client QUIC handshake failed. unknown error (0x179)
System Information
Mitmproxy: 11.0.0.dev (+18, commit 6bb536e)
Python:    3.11.3
OpenSSL:   OpenSSL 3.2.2 4 Jun 2024
Platform:  Windows-10-10.0.22631-SP0

Proxy debug: https://gist.github.com/errorxyz/f0c5cb1fa8c38daa5ac8548add665ff8

Proxy debug: https://gist.github.com/errorxyz/0f81b5d8ef3d1921e1b2deb08c24e990

I can't repro this here - cloudflare-quic.com works just fine both in local and redirect mode. It works just fine for you in reverse mode, only local mode is affected?

I can't repro this here - cloudflare-quic.com works just fine both in local and redirect mode. It works just fine for you in reverse mode, only local mode is affected?

Yes, works fine in reverse mode but doesn't work if we're using local mode


leveldb: fix write pause state

Fix #242

Merged. Thanks!

how's this test?
is there such contention case

found L0 num >= pause num and trigger write pause
compacting L0 and continue to compact L > 0
send a cmd to tcompCmdC
need to wait the not relate compaction finished to resume write


Stream headers and Tracing

This PR:

adds stream headers concept by passing request headers to NewStream function, getting the response headers with Stream.Headers and processing them with protocols Headler function
adds tracing by passing span context with headers
adds an example tracing for pingpong protocol and api
changes signature of NewStream which length of arguments should be addressed in the followup PR
fixes missing address book and discovery driver instances in node package constructor

This PR is tested manually with jaeger server docker run -p 6831:6831/udp -p 16686:16686 jaegertracing/all-in-one:latest and with unit tests in code.
To test tracing manually:

start the jaeger server with docker. access the jaeger web interface at http://localhost:16686/
start locally two bee nodes (different data dirs and ports) and connect them as in https://github.com/ethersphere/bee#usage-experimental-api with --tracing flag provided for both nodes
make a pingpong call over the exposed http api
validate tracing in jaeger web interface

Thanks for reviews, this one was not so trivial.


Added my spelling mistake suggestions from https://github.com/MicrosoftDocs/windows-insider/pull/241

Changed "deskops" to "desktops"
Changed "Exploer" to "Explorer"
Changed "pdated" to "Updated"

@bleblancMSFT - PR is ready for final review. This is just a typo issue.
Thank you.
cc: @kenwith


Add More Tests for Kubernetes Sals

Description
Add more tests for Kubernetes sals
Changes

[x] get_helm_chart_user_values
[x] upgrade_release --> Wait for modifications in the function

Related Issues
#2140
Checklist

[x] Pre-commit hook is installed to do formatting checks before committing code...etc
[x] Tests included
[x] Build pass
[x] Documentation
[x] Code format and docstrings

The whole vdc will deleted

The whole vdc will deleted

The whole vdc will deleted

But it might run out of resources?

The whole vdc will deleted

But it might run out of resources?

The whole vdc will deleted

But it might run out of resources?

If it is a new vdc, it will not

The whole vdc will deleted

But it might run out of resources?


Error on startup

I’m running v1.0.0, and suddenly started getting these errors when starting pokem:
2024-06-10T19:18:56.407766Z ERROR sync_with_result_callback{sync_settings=SyncSettings { filter: FilterDefinition(FilterDefinition { event_fields: None, event_format: "client", presence: Filter { not_types: [], limit: None, senders: None, types: None, not_senders: [] }, account_data: Filter { not_types: [], limit: None, senders: None, types: None, not_senders: [] }, room: RoomFilter { include_leave: false, account_data: RoomEventFilter { not_types: [], not_rooms: [], limit: None, rooms: None, not_senders: [], senders: None, types: None, url_filter: None, lazy_load_options: Disabled, unread_thread_notifications: false }, timeline: RoomEventFilter { not_types: [], not_rooms: [], limit: None, rooms: None, not_senders: [], senders: None, types: None, url_filter: None, lazy_load_options: Disabled, unread_thread_notifications: false }, ephemeral: RoomEventFilter { not_types: [], not_rooms: [], limit: None, rooms: None, not_senders: [], senders: None, types: None, url_filter: None, lazy_load_options: Disabled, unread_thread_notifications: false }, state: RoomEventFilter { not_types: [], not_rooms: [], limit: None, rooms: None, not_senders: [], senders: None, types: None, url_filter: None, lazy_load_options: Enabled { include_redundant_members: false }, unread_thread_notifications: false }, not_rooms: [], rooms: None } }), timeout: 30s, full_state: false, set_presence: "online" }}: matrix_sdk::sync: Received an invalid response: error sending request for url (https://koehn.com/_matrix/client/v3/sync?filter=%7B%22room[redacted]lazy_load_members%22%3Atrue%7D%7D%7D&since=s1441094_165529100_166_2291035_28766_377_11969_3452118_0_28&timeout=30000): connection closed before message completed
Error: error sending request for url (https://koehn.com/_matrix/client/v3/sync?filter=%7B%22room[redacted]lazy_load_members%22%3Atrue%7D%7D%7D&since=s1441094_165529100_166_2291035_28766_377_11969_3452118_0_28&timeout=30000): connection closed before message completed

If I run curl with that URL and the appropriate Authorization header from the same machine, it returns in under a second.

In the synapse logs, I’m seeing this:
2024-06-20 21:16:59,607 - synapse.http.server - 130 - INFO - POST-156585 - <SynapseRequest at 0x7fdc691c9d10 method='POST' uri='/_matrix/client/v3/keys/upload' clientproto='HTTP/1.1' site='8008'> SynapseError: 400 - One time key signed_curve25519:AAAAAAAAAAA already exists. Old key: {"key”:"[redacted]","signatures":{"@pokem:koehn.com":{"[redacted]":"[redacted]"}}}; new key: {'key': '[redacted]', 'signatures': {'@pokem:koehn.com': {'ed25519:[redacted]'}}}

I should mention I’m running Synapse v1.109.0. I can see the sync call completing a few milliseconds after 30 seconds.

We chatted on Matrix and couldn't figure out what was going on. I've tested on matrix.org and my own homeserver without a problem but it broke here for some unknown reason.
I'm transferring this issue to headjack as it's an issue there. I'll track it and see if it shows up again.


Paper bug fixes page

This is the initial page for transferring the Github Issue to an actual page. Let me know any comments you have as You may want more of an explanation to why these were changed. Any maintainers may also have more insight.

Addressed Comments, some I did not use though as it seemed a bit trigger-happy with the commas and didn't seem correct (with a check online to back me up)


[UBS_Prod. Order form] The 'Будинок' dropdown is displayed instead of input field in the 'Нова адреса' popup

Environment: Windows 10, Google Chrome Version 113.0.5672.129 (Official Build) (64-bit).
Reproducible: always.
Build found: 05/06/2023
Preconditions

Log in as User https://www.pick-up.city/#/ubs
The Step 2 'Особисті дані' in the Orders form should be opened.
The '' popup should be opened.

Steps to reproduce

Fill in the 'Область', 'Місто',  and 'Вулиця' fields.
Click on the 'Будинок' field and type e.g. 7.
Pay attention to the 'Будинок' field.

Actual result
The 'Будинок' dropdown is displayed in the 'Нова адреса' popup.  The dropdown  with entered value appears after typing value in this field.
https://github.com/ita-social-projects/GreenCity/assets/120178274/74af324e-eed7-464d-8bf2-7f6dbe11a35b
Expected result
The 'Будинок' input field is displayed in the 'Нова адреса' popup.

Not a bug