futhark-bench: Do not require output validation

It should be possible for futhark-bench to only measure speed, and not verify the output, since we don't have expected-output files for all Futhark benchmarks (even if that is a goal).

I am implementing this now, but it will not solve all your problems, as
futhark-bench cannot at present handle large input values.
--
\  Troels
/\ Henriksen


Release 2.9.0

Now supports Windows. Also re-rendered to get Python 3.6.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


feat(Analysis/Complex/UpperHalfPlane/Topology): Add lemma

Add a lemma about containment of verticalStrips in each other needed for #12456

bors r+


[Triton-MLIR][Backend] Support ConvertLayout blocked->mma

ConvertLayout blocked->shared & mma->blocked hasn't been verified for correctness yet.
Just merge this PR to align with other folks.  The verification for correctness is ongoing right on the moment.

I'll fix the rest of comments and merge this pr later when the correctness of e2e gemm is verified.
Currently we are still working on that, thus mark this CR as wip.


Running waypoint (istio-proxy container) as non root

Describe the feature request
Currently, the waypoint (istio-proxy container) is running as root (securityContext.runAsUser=0). It would be beneficial to run it as a non-root user because it cannot operate in restricted namespaces (https://kubernetes.io/docs/concepts/security/pod-security-standards/#restricted). This is particularly important because the waypoint is supposed to run in the same namespace as the application workloads, posing a significant limitation.
Affected product area (please put an X in all that apply)
[X] Ambient
[ ] Docs
[ ] Dual Stack
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Extensions and Telemetry
[X] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Affected features (please put an X in all that apply)
[ ] Multi Cluster
[ ] Virtual Machine
[ ] Multi Control Plane
Additional context

fixed by https://github.com/istio/istio/pull/51290


self-hosted PoC

Create a super simple example of why self-hosted runners don't work with

microK8s
lightkube client

Aim only for debug and reference purposes

@kimwnasptd are you still working on this PR? If this is for testing purposes only, please convert it to draft or close it if it is nor required anymore.


The fact that cards can be slid sideways is not visible.

What

The fact that cards can be slid sideways is not visible.
Add either a Right arrow on the side of the Welcome card, or an onboarding tooltip or a little animation to be super-clear about this possibility

Part of

#561

I want to suggest an add-on to the above possibilities. Since there isn't any dialog to confirm the removal of the item if the user swipes by mistake, I believe something like this below will help notify the user about it.

Looks good @GowthamGoush

This was not what this bug was about. It was about the scan cards.

What about adding a third "delete" option to the multi select mode, then we have both common ways to delete something covered

I might try and tackle this one (I'm new btw hello).

Heyy and welcome @KeysGilbert 👋🏼
Sure, I've you need any guidence feel free to ask 😄

What exactly did you had in mind for this issue @KeysGilbert

@M123-dev as far as making the user aware that these cards can be slid, maybe adding arrows to the side that kind of blink in and out (like an animated opacity). Or when the user visits the page, show a "slide ->" prompt at the top for a second. When it comes to confirming deletion, I like the example picture above. We could do that or show an alert dialog upon sliding.

I still have to look at there these cards are implemented and displayed in the code.

How do I fix the error:
"Because smooth_app depends on camera from git which depends on camera_platform_interface ^2.1.0, camera_platform_interface from hosted is required.
So, because smooth_app depends on camera_platform_interface from git, version solving failed."
when running a pub get?

Heyy @KeysGilbert that's a common error for people using windows.
What solved it for me was cleaning the pub.dev cache manually in
C:\Users\your_name\AppData\Local\Pub\Cache
Others reported that a full reinstallation of flutter fixed it

@M123-dev cleaning cache didn't seem to work. Really would hate to do the latter. It's that camera_platform_interface expected in hosted causing problems.

Then some other things to consider:

Are you using flutter 3.0.5
Cleaning pub cache using command

I'm on flutter 3.3.10.
I tried cleaning cache twice (first with command, second manually).

Maybe this causes the problem, we are currently using Flutter version 3.0.5 due to some Bugs in flutter itself
flutter downgrade 3.0.5


Trigger order can be significant, UI needs to let me rearrange the triggers

Describe the bug
I need to be able to reorder the trigger definitions.
Version
2.0.0
Browser

[x] Electron distribution
[ ] Chrome
[ ] Safari
[ ] Firefox
[ ] Edge

OS

[ ] macOS
[x] Windows
[ ] Ubuntu

To Reproduce
Steps to reproduce the behavior:

Create multiple intents
Try and change the order, you can't.

Expected behavior
That I can change the order of triggers without having to resort to editing json
Screenshots
Additional context

Seconded!

I tried to change the order of them, but I couldn't. I had to specific dialog to start the trigger with. ( That will make specific trigger popup before)

Yeah this is much needed, changind dialog order would help too


The shared URL on Twitter and TG work incorrectly

It is expected that when the URL is clicked,  it will go to our analytix product page. currently no response. please check this twitter shared from my side: https://twitter.com/hao_web3go/status/1648289315858833409

It works on my env. It could be laggy on Twitter's side or maybe the bandwidth limit caused it to slow responded.
however, I found an issue that caused it to fail to redirect the URL, which I have fixed.


feat: explore the RAG technique, and methods to retain chat history

Refer to the documentation in the pull request to find information on the scripts, how to run them, and the exploration results.

All catches on typos have been fix.
Other than that, when I ran rag.py, there is a deprecation warning about the import of HuggingFaceEmbeddings will be changed in the next langchain version. Fixed it too.

Thanks for capturing the missing step on git-lfs. All comments so far have been addressed.


fix: Update conda instructions in Developer Setup.md

conda create doesn't automatically activate the conda env, so added an instruction to explicitly activate the environment with conda activate

Acrolinx Scorecards
A minimum Acrolinx score of 80 is required.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology.

Article
Acrolinxscore
Word andPhrases Score
CorrectnessScore
Scorecard
Processed

docs/Reference/Developer Setup.md
87
100
60
link
:white_check_mark:

More information about Acrolinx

Install Acrolinx locally for VSCode
False positives or issues
Troubleshooting issues with Acrolinx


Allow retrying when an EndpointGroup is empty.

Related: #1910
Motivation:
A client request to an empty EndpointGroup fails immediately with an
EmptyEndpointGroupException, even if there is a Retrying(Rpc)Client
in the decorator chain. As a result, a user cannot recover from the case
of an empty EndpointGroup.
Modifications:

Make DefaultClientRequestContext handle EmptyEndpointGroupException
specially so that init() does not treat is as failure.
Make AbstractRetryingClient handle EmptyEndpointGroupException
specially so that it can continue retrying.
Modify the signature of ClientFactory.acquireEventLoop() and
EventLoopScheduler.acquire() so that it's possible to acquire an
EventLoop even when Endpoint is not determined yet.

Result:

A user can retry even when the current EndpointGroup is empty.

Discussion items:

Should we make EndpointGroup.select() return null instead of
throwing an EmptyEndpointGroupException? i.e. Instantiate
EmptyEndpointGroupException only when setting responseCause.

/cc @andrey-tpt

Should we make EndpointGroup.select() return null instead of throwing an EmptyEndpointGroupException? i.e. Instantiate EmptyEndpointGroupException only when setting responseCause.

If there's an objection, I'd like to make EndpointGroup.select() to return null instead of raising an exception.

Should we make EndpointGroup.select() return null instead of throwing an EmptyEndpointGroupException? i.e. Instantiate EmptyEndpointGroupException only when setting responseCause.

+1. If a result is empty, null sounds good to me.


fix: don't refetch existing txs

Description

we'd previously keep paginating all tx history until we no longer had any pages to fetch from the backend
this change causes us to always at least fetch the first page of txs per account, which are ordered as newest first.
this means we'll always pick up latest txs on a fresh page load.
we then compare the fetch tx ids to the existing tx ids in the store. if there aren't any new txs, we stop paginating tx history for that accounts.
this means reduced network requests and better render performance for accounts with large tx history.
Notice

[x] Have you followed the guidelines in our Contributing guide?
[x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Pull Request Type

[ ] :bug: Bug fix (Non-breaking Change: Fixes an issue)
[x] :hammer_and_wrench: Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
[ ] :nail_care: New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

n/a
Risk
isolated to tx history

Testing

Engineering

for a given wallet in prod, clear your application storage, then load up a chosen wallet. check the total tx ids length in redux.
clear your application storage locally against this branch. load the same wallet. check the tx ids length match.

Operations

load a wallet in prod, look at the first and last tx's in tx history page, and per account tx history page.
load the same wallet in release, do the same.
clear your local storage, refresh the page and let the wallet history load all txs (as we do now)
reload the page - tx history should be the same, but a bit faster.

Screenshots (if applicable)
no visual changes.

@willyogo this one for you brother


Add env.Load() to load .env file

This replaces a dependency for loading .env files with a custom one. The idea is that this can also be used to load the .env file when deploying the quickfeed server.
Note: this custom env.Load() function will not expand environment variables.

Codecov Report

Merging #698 (1829ba5) into master (ac8b213) will increase coverage by 0.12%.
The diff coverage is 78.26%.

@@            Coverage Diff             @@
##           master     #698      +/-   ##
==========================================
+ Coverage   23.46%   23.58%   +0.12%
==========================================
  Files          73       74       +1
  Lines       10351    10374      +23
==========================================
+ Hits         2429     2447      +18
- Misses       7596     7599       +3
- Partials      326      328       +2

Flag
Coverage Δ

unittests
23.58% <78.26%> (+0.12%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

internal/env/load.go
78.26% <78.26%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

21 of 24 (87.5%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.1%) to 26.16%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

internal/env/load.go
21
24
87.5%

Totals

Change from base Build<PHONE_NUMBER>:
0.1%

Covered Lines:
2820

Relevant Lines:
10780

💛  - Coveralls


added a few features and 1 fix

all separate options, it adds "hide voice search", "old searchbox", "remove ripple" (when you click a video in recommended)
any icons that dont have filled variants like shorts and movies/tv when oldicons=1 have been colored from black to light gray to better fit in with the old icons

The artist icon appears to be impacted by the old icons option, turning red instead of gray.


Fee not updating so Send failing and Send Max crashing

-Post upgrading the app to 175 (the release is live)
-Main app - the fee is still not showing, Send is failing and Send Max is crashing.
-I upgraded my wallet from 1.3.0 to 1.3.1 then I tried restore n it worked.After that I upgradeed it to 1.3.2 n tried recovery on it.Now the fee was 0 and send max was crashing on 1.3.2(175).
-Then I did a fresh install 1.3.0 and fees were high on 1.3.0(i.e 17854).I tried Restore on it n it also worked.Also the send was working.
-Then again I did a fresh install 1.3.2(175) and the fee was 8588 also the send was working.

The fee discrepancy is due to the way 1.3.0 and 1.3.2 syncs the feeRates (1.3.0 does it every half an hour directly from Esplora while 1.3.2 fetches it from Relay which syncs every hour).

@cakesoft-swati - marking it fixed as it needs to be tested in 1.4.0

-Verified this issue on Dev ap version 1.40(180).
-Need to test it on live app with Upgrade and Restore scenarios.

Will this need a patch? If the fee is ‘0’ the. Do something?

Needs to be tested post production

we can test it on the live hexa release

Verified this issue on staging app v1.40(184)

-Verified this issue on live app version 1.4.0(188)


PromQL  field  column has  Upper

What type of bug is this?
Incorrect result
What subsystems are affected?
Query Engine
Minimal reproduce step

I get an error when I query this field
What did you expect to see?

this query will
What did you see instead?
Is it a bug or does it need additional escaping?
What operating system did you use?
Centos7
What version of GreptimeDB did you use?
0.9.3
Relevant log output and stack trace
Internal error during building DataFusion plan: No field named ess_meter_negativeacticet. Valid fields are "snStorageEssMeterYcTopic"."ess_meter_negativeacticeT", "snStorageEssMeterYcTopic"."ess_meter_positiveacticeT", "snStorageEssMeterYcTopic".ess_meter_cos, "snStorageEssMeterYcTopic".ess_meter_f, "snStorageEssMeterYcTopic".ess_meter_ia, "snStorageEssMeterYcTopic".ess_meter_ib, "snStorageEssMeterYcTopic".ess_meter_ic, "snStorageEssMeterYcTopic".ess_meter_negativeacticef, "snStorageEssMeterYcTopic".ess_meter_negativeacticeg, "snStorageEssMeterYcTopic".ess_meter_negativeacticej, "snStorageEssMeterYcTopic".ess_meter_negativeacticep, "snStorageEssMeterYcTopic".ess_meter_p, "snStorageEssMeterYcTopic".ess_meter_positiveacticef, "snStorageEssMeterYcTopic".ess_meter_positiveacticeg, "snStorageEssMeterYcTopic".ess_meter_positiveacticej, "snStorageEssMeterYcTopic".ess_meter_positiveacticep, "snStorageEssMeterYcTopic".ess_meter_q, "snStorageEssMeterYcTopic".ess_meter_ua, "snStorageEssMeterYcTopic".ess_meter_ub, "snStorageEssMeterYcTopic".ess_meter_uc, "snStorageEssMeterYcTopic"."jiancedianID", "snStorageEssMeterYcTopic".ts.

Looks like a bug. Could you also provide the SQL that creates this table?

Could you try use the single quote? 'ess_meger_xxx'.

Looks like a bug. Could you also provide the SQL that creates this table?

CREATE TABLE IF NOT EXISTS "snStorageEssMeterYcTopic" (
"jiancedianID" STRING NULL,
"ess_meter_negativeacticeT" DOUBLE NULL,
"ess_meter_positiveacticeT" DOUBLE NULL,
"ts" TIMESTAMP(9) NOT NULL,
"ess_meter_cos" DOUBLE NULL,
"ess_meter_f" DOUBLE NULL,
"ess_meter_ia" DOUBLE NULL,
"ess_meter_ib" DOUBLE NULL,
"ess_meter_ic" DOUBLE NULL,
"ess_meter_negativeacticef" DOUBLE NULL,
"ess_meter_negativeacticeg" DOUBLE NULL,
"ess_meter_negativeacticej" DOUBLE NULL,
"ess_meter_negativeacticep" DOUBLE NULL,
"ess_meter_p" DOUBLE NULL,
"ess_meter_positiveacticef" DOUBLE NULL,
"ess_meter_positiveacticeg" DOUBLE NULL,
"ess_meter_positiveacticej" DOUBLE NULL,
"ess_meter_positiveacticep" DOUBLE NULL,
"ess_meter_q" DOUBLE NULL,
"ess_meter_ua" DOUBLE NULL,
"ess_meter_ub" DOUBLE NULL,
"ess_meter_uc" DOUBLE NULL,
TIME INDEX ("ts"),
PRIMARY KEY ("jiancedianID")
)
ENGINE=mito
WITH(
merge_mode = 'last_non_null'
)

Could you try use the single quote? 'ess_meger_xxx'.

Could you try use the single quote? 'ess_meger_xxx'.

{
"code": 3000,
"error": "Internal error during building DataFusion plan: No field named filed.


Bump sarama from v1.26.4 to v1.27.0

Proposed Changes

Bump sarama from v1.26.4 to v1.27.0

Let's merge https://github.com/knative-sandbox/eventing-kafka-broker/pull/114 first.
/hold

/lgtm
/approve
/unhold


[Tracking][Image][Polish] Image-related feature request and improvements

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Problem
We have seen a number of issues come up related to images. Uploading them, editing them, making them available offline, copying them to clipboard, etc...
Onyx does have support for images, but AFAIK nobody has utilized that functionality to build any app features that follow our offline-first paradigm for images.
Overall, I think there's a lot of confusion around this topic (speaking for myself here, so feel free to comment if you disagree), and that leads to potentially disparate approaches or complex code surrounding images.
Solution
As these come up, we see the need for a common, unified approach to handling images, presumably using Onyx. This issue is meant to serve as a tracking issue for all image-related feature requests and bug fixes. We should look for commonality between these features, try to come up with a generalized, future-proof solution that's easy to work with, and implement it via the WN/Design Doc process.
Linked issues
Setting up Caching Issue(s)

[ ] https://github.com/Expensify/App/issues/10792
[ ] https://github.com/Expensify/App/issues/12603
[x] https://github.com/Expensify/App/issues/9703

[ ] https://github.com/Expensify/App/issues/12259

[x] https://github.com/Expensify/App/issues/6527

Bugs based off caching [Holding on ^]

[x] https://github.com/Expensify/App/issues/12185
[ ] https://github.com/Expensify/App/issues/11425
[ ] https://github.com/Expensify/App/issues/12707

"Flashing" / Image rerendering [Holding on ^]

[ ] https://github.com/Expensify/App/issues/9402
[ ] https://github.com/Expensify/App/issues/10704
[ ] https://github.com/Expensify/App/issues/11393

New Features

[ ] https://github.com/Expensify/App/issues/4629
[ ] https://github.com/Expensify/App/issues/7862
[ ] https://github.com/Expensify/App/issues/11085
[ ] https://github.com/Expensify/App/issues/11197

Bugs (in progress - not on hold)

[ ] Default avatars: Use SVG asset that we can change the color

FallbackAvatar & FallbackWorkspaceAvatar
Note: Being handled in this issue: https://github.com/Expensify/App/issues/12259

[x] https://github.com/Expensify/App/issues/11063

[ ] https://github.com/Expensify/App/issues/13038

[x] https://github.com/Expensify/App/issues/13006
[ ] https://github.com/Expensify/App/issues/13555
[ ] https://github.com/Expensify/App/issues/13585
[ ] https://github.com/Expensify/App/issues/13962
[ ] https://github.com/Expensify/App/issues/14027

Resolved issues

[x] https://github.com/Expensify/App/issues/10029
[x] https://github.com/Expensify/App/issues/10849
[x] https://github.com/Expensify/App/issues/9418
[x] https://github.com/Expensify/App/issues/9239
[x] https://github.com/Expensify/App/issues/10258
[x] https://github.com/Expensify/App/issues/8846
[x] https://github.com/Expensify/App/issues/11639
[x] https://github.com/Expensify/App/issues/10950
[x] https://github.com/Expensify/App/issues/8235
[x] https://github.com/Expensify/App/issues/10599
[x] https://github.com/Expensify/App/issues/11854
[x] https://github.com/Expensify/App/issues/13300
[x] https://github.com/Expensify/App/issues/11511

Follow-up discussions:

Stop storing full image URLs in the database

Decided this wasn't needed for "WhatsApp Quality" but still useful to do eventually

A project would be fine – historically we've usually just used issues but a project board could be useful. More importantly, we need someone to take this on as a project manager.
One interesting idea could be to engage @thomas-coldwell from Margelo in this project, since @mrousavy told me that Thomas typically works on Video/Audio/Image/Graphics stuff. Thoughts @mrousavy?

@roryabraham yes, this would probably pretty interesting! 😄
I'll talk to Thomas about availability then get back to you here or on Slack :)

Added https://github.com/Expensify/App/issues/9703 to this list.

There was some useful discussion in slack regarding this issue here. Added @kidroca's summary to the OP for context

Added https://github.com/Expensify/App/issues/11425 to the list

Finished looking through existing issues & adding them to this tracker, tomorrow I'll comb through them to figure out what common things we need to implement & some ideas how to do that, before proceeding

Asked a question about next steps in Slack. Feel free to answer here or there. No need to answer in both places, thanks!

:whoohooo: just scored me 17 open issues to BZ! 🏅
Need to develop a process for this and add/update SO.  Will do soon

:whoohooo: just scored me 17 open issues to BZ! 🏅
Need to develop a process for this and add/update SO. Will do soon

Hahaha glad you're happy about this! Lots of work to do 💪

Sent a pre-design recap on Monday here.
Today's goal: Get Web-E to accept encrypted auth token via header (instead of via the image URL query param). Once this is possible, we (hopefully Kidroca or a Margelo dev) can whip up some POCs to make sure the latest plan (here) is possible

Chatted this morn!  We might want to update the list in the OP to bunch issues/themes or if some issues are help on others.

Reorganized the issue list a bit by categorizing open issues - it looks like some of the issues "On hold" (mainly bug fixes) can be taken off hold if they don't have anything to do with image flashing / image caching

It looks like some of the issues "On hold" (mainly bug fixes) can be taken off hold if they don't have anything to do with image flashing / image caching

So... the bottom three here @Beamanator ?

Ya I think all 4 @mallenexpensify - the top one is just about the zoom feature, so probably doesn't need to wait on anything

Updated all issues in the Bugs (in progress - not on hold) section and took off hold which is now reflected in the OP

Added https://github.com/Expensify/App/issues/11854 to Bugs (in progress - not on hold)

Posted in #whatsnext end of last week (here)
Will create implementation issues tomorrow if there's no changes in the solution path!

Co-assigning @trjExpensify as BZ, he'll be taking the BZ lead on this and all related issues til I'm back, hopefully in a month.

Current top priority issues for this proj:

https://github.com/Expensify/App/issues/10792
https://github.com/Expensify/App/issues/12603
https://github.com/Expensify/App/issues/11063

Hugely helpful. Keep these kinds of hit lists coming!

No change to the hit list from EOD Friday, Melv.

Adding new issue to the list: https://github.com/Expensify/App/issues/12707
I think this one should be placed on hold, it should be solved once caching is implemented

Evening, Melvin!

https://github.com/Expensify/App/pull/12648#issuecomment-1317505702 is with @mananjadhav for review
https://github.com/Expensify/App/issues/12603#issuecomment-1314276420 - is with @kidroca to fix react-native-web for web/desktop image caching
https://github.com/Expensify/App/pull/12549 - is on @Beamanator to address @Santhosh-Sellavel's first review comments from earlier today. Alex is out for the rest of the week, so this will slow down now until Monday.

Good progress on all of the above ^ PRs, hoping to get them all knocked out this week (and I'm back so I'll be helping push things forward 🙏 )

Fast Image for native is merged 🎉
RNW Image for web/desktop is now ready to be reviewed?
Allow multiple avatar image type has been reviewed by C+, but awaiting comments to be addressed.

Yep yep thanks for the update 👍  Notes:

Fast Image PR may have caused a regression 🙃 (being investigated here)
RNW caching has been updated and "should work" but will be tested more soon (discussion here)
Allowing more avatar image types - I ran into some potential issues with 3rd party libraries we use, I am thinking about trying to move forward with "what we currently can do" & make follow-up issue for allowing .bmp and .gif images to work in Android & iOS

Allowing more avatar image types - I ran into some potential issues with 3rd party libraries we use, I am thinking about trying to move forward with "what we currently can do" & make follow-up issue for allowing .bmp and .gif images to work in Android & iOS

I like this plan.

Updates for the day:

Fast Image PR (the one that was reverted): was reviewed by @kidroca with some useful comments, looking forward to the follow-up PR from @thomas-coldwell
RNW caching:

Looks like @necolas (maintainer of react-native-web) is responding to the PR - though they might have preferred we talk to them before creating the PR (here)
I'm still not able to see the new header on the backend, meaning I don't see images loading properly on web yet 😭

More image types: Getting real close, still two weird behaviors (one NAB and I thinkkk one caused by a browser setting)

Quick updates:

Fast Image PR: Looks like we're still waiting on Thomas to get better, I haven't seen a draft PR yet
RNW caching: Latest updates here

Basically, kidroca & the react-native-web maintainer look to be pushing toward getting kidroca's PR (https://github.com/necolas/react-native-web/pull/2442) merged!
Not entirely sure how long this will take, but the current plan is hold off on the Fork PR for a bit, hope ^ gets merged, then keep moving

More image types: Down to the last test to see if iOS mWeb (safari) has bugs or is working well -> Investigating if there's a difference between iOS 15.5 (my sim versions) & iOS 16.1 (Santhosh's device version)

Updates:

Fast Image PR: Looks like Thomas is getting round to reviewing comments on his previous PR!
RNW caching:
More image types is merged!

Once this makes it to Production (assuming there's no regressions) I'll take https://github.com/Expensify/App/issues/13038 off hold and move forward there!

Default Avatars: Wanted to start tracking this since it's another main caching issue.

As Cristi mentioned here, Georgia will be continuing this effort since she has been working on default avatar updates a lot lately - she already has some PRs up (see comment) and will modify those to use our latest solution (around here)

Updates:

Fast Image PR: Thomas has a draft (https://github.com/Expensify/App/pull/13304), but we're deciding how to proceed since the regression was actually a bug in a 3rd party lib, and we want to fix upstream if possible
RNW caching: Waiting on convo in 3rd party lib (waiting for maintainer to review upstream PR)
Multiple image types:

Made a new follow-up to look into improving the background in the avatar crop modal, as black background doesn't look so great: https://github.com/Expensify/App/issues/13266
Main PR is in staging, will wait another day or 2 before taking https://github.com/Expensify/App/issues/13038 off hold

Default avatars: no update

RNW caching: Waiting on convo in 3rd party lib (waiting for maintainer to review upstream PR)

@Beamanator mind linking this? Also broadly, what's the latest here?

Was OOO, will add an update here tomorrow for sure 🙏

Updates:

iOS / Android (react-native-fast-image):

Started a convo here to see if we want to implement a small workaround that can unblock his main caching PR, or if we want to wait for an upstream fix (here Thomas said he's starting that PR) before moving forward
His new caching PR (draft) is here: https://github.com/Expensify/App/pull/13304

Web / Desktop (react-native-web):

Kidroca's PR (https://github.com/necolas/react-native-web/pull/2442) is moving pretty slow, the maintainer mentioned here that they're busy working on many other things for the next release
I may start a convo soon about implementing the update in our fork while waiting for upstream progress

Multiple avatar image types:

Next target issue: https://github.com/Expensify/App/issues/13038
A few convos we need to align on (coming soon)
My changed caused this issue: https://github.com/Expensify/App/issues/13555

Default avatars

Update from Georgia here: https://github.com/Expensify/App/issues/12259#issuecomment-1346937345

I may start a convo soon about implementing the update in our fork while waiting for upstream progress

In light of the discussion we had for the process with forks, I wouldn't delay this any longer. This is really holding us up on making further progress with the Image improvements project.

@Beamanator thoughts on the above?

Yes good call, I can definitely start the convo tomorrow - sorry for the delay, today I was cut short due to some personal issues but will get that going tomorrow 💪

Updates:

iOS  / Android:

Upstream PR: https://github.com/DylanVann/react-native-fast-image/pull/953
Plan if it doesn't move along is here: https://github.com/Expensify/App/issues/10792#issuecomment-1358020140

Web / Desktop:

Upstream PR: https://github.com/necolas/react-native-web/pull/2442
Hasn't had updates in a bit, so we have a new plan:

Get the fix merged into our react-native-web fork (PR: https://github.com/Expensify/react-native-web/pull/8)
Get it updated in App, so we can unblock multiple caching issues
Create new Monthly tracking issue to keep up with status of upstream PR

Multiple avatar image types

Posted in expensify-open-source here to align on next steps for https://github.com/Expensify/App/issues/13038#issuecomment-1359504509

Default avatars (https://github.com/Expensify/App/issues/12259):

No updates

Note for next week: Reach out to maintainer for #953 and ask if we have an ETA for potentially merging.

As a heads up, I've removed this issue from the WAQ project and filed it in N7 instead. If you're curious for more context, it's captured in this Slack thread. Summarizing that convo though, this mainly comes down to us moving the big architectural changes into whatever respective projects they block. In the case of images, that's minimally when we get users interacting with their company and sharing receipts and related attachments with their company. I'll treat the related in this issue similarly.

A few updates now that I'm back from OOO :D
Updates:

iOS / Android:

Upstream PR: https://github.com/DylanVann/react-native-fast-image/pull/953

No movement for a few weeks
I reached out to Dylan via email on his GH profile (following copy from this SO)

Draft App PR: https://github.com/Expensify/App/pull/13304

Web / Desktop:

Upstream PR: https://github.com/necolas/react-native-web/pull/2442

Still no movement in upstream PR

Expensify Fork PR: https://github.com/Expensify/react-native-web/pull/8

I did a review, but i'm asking Marc for a review as well & asking if he thinks we want another eng or two to check if out before we proceed, since it's kinda unfamiliar territory

App PR (just a draft / in test state): https://github.com/Expensify/App/pull/13036/files

Multiple avatar image types

https://github.com/Expensify/App/issues/13038 is now on hold for WAQ - though, since WAQ is winding down, I might still try to make progress this week
Bondy gave a nice recap of where we left off in our last slack convo here: https://github.com/Expensify/App/issues/13038#issuecomment-1365292436

Default avatars:

No updates, Georgia has been OOO

New issues I think we want to start tracking here:

https://github.com/Expensify/App/issues/12893

As mentioned here, we are putting this on hold for now since we don't have clear next steps, and there's more high priority issues (above)

https://github.com/Expensify/App/issues/13585
https://github.com/Expensify/App/issues/13910

On these two new ones:

mWeb - Chat - The avatar in the group's welcome message is not displayed correctly #13585

It's specifically in the case of a transparent background PNG, but I don't quite understand how that one is a bug. I've commented in the issue.

Profile images appear in square when gif is uploaded as profile pic #13910
This one won't be an issue after #13038, right?

Arg will send update tomorrow 🙃

mWeb - Chat - The avatar in the group's welcome message is not displayed correctly #13585

It's specifically in the case of a transparent background PNG, but I don't quite understand how that one is a bug. I've commented in the issue.

Agreed, looks like we have a resolution here in the issue

Profile images appear in square when gif is uploaded as profile pic #13910

This one won't be an issue after #13038, right?

It shouldn't be, correct 👍
And here's anotha few image-related issues I added above! Neither of these are on hold since they don't seem to be related to caching:

https://github.com/Expensify/App/issues/13962
https://github.com/Expensify/App/issues/14027

Updates:

iOS / Android:

Upstream PR: https://github.com/DylanVann/react-native-fast-image/pull/953

Still no movement, I reached out last week and didn't hear back

Patch PR: https://github.com/Expensify/App/pull/13304

Has undergone a lot of reviews already, seems we're still trying to nail down the last few little flicker issues then we can merge!

Web / Desktop

Upstream PR: https://github.com/necolas/react-native-web/pull/2442

Still no movement since Dec 2, 2022

Fork PR: https://github.com/Expensify/react-native-web/pull/8

Has had quite a few review comments already, basically trying to limit the amount of changes since this library's codebase is pretty unfamiliar to the reviewers so far.
Kidroca has a second draft PR we will review as it has far fewer code changes: https://github.com/Expensify/react-native-web/pull/11/files

Draft App PR: https://github.com/Expensify/App/pull/13036

Neither of these are on hold since they don't seem to be related to caching:

Seems like https://github.com/Expensify/App/issues/14027 is on hold for the SVG default avatars PR. Should it not be?

@trjExpensify I think it make sense to be on hold for the SVG default avatars - as mentioned here:

this issue only happened with the users that didn't have avatar. Since I changed avatar of the user inside group that flickers, this issue didn't happen anymore.

Okay cool, so I got confused with the "neither of these are on hold" part of the comment.

Oh i see the confusion, that's my bad 😅

All good! Can we get another run down of the latest here for this week? Native caching PR is sooo close, really looking forward to getting that across the line.

Native caching PR has been merged! Default avatars is also veryyyyy close, will update this tomorrow :D

Updates:

iOS / Android

Commented in Upstream PR, tagging maintainer to try to get more attention
Caching PR workaround merged!

_Don't get excited, we had regressions last time so lets wait and see how this goes 🙏 _

Issue created for me to keep track of upstream PR: https://github.com/Expensify/App/issues/14382

Web / Desktop

Multiple avatar image types:

Default avatars

Dang, making some really great progress here! Let's close the loop on default avatars. That's an exciting polish item we want to get in the hands of members.

Soooo close on the caching PRs. Very excited!

Updates:

iOS / Android

No reaction to my comment in Upstream PR.

Will leave further updates in this issue: https://github.com/Expensify/App/issues/14382

Caching PR still looking good!  Has been in production for 4 days now 👍

Web / Desktop

My comment in Upstream PR from last week got the maintainer's attention, which is great 👍
Fork PR is looking great! I gave my 👍 of approval, waiting for maybe 1 more reviewer before merging tomorrow (if there's no additional concerns)

Multiple avatar image types:

Seems like we might go with being "ok" that a few image types don't work on some platforms, and we'll create an issue aimed at the long-term fix in the meantime

Default avatars

PR - looks like Georgia has been ooo a bit, there's a decent amount of conflicts in her PR since there's so many files touched 😬

Quick little update: the React native web fix has been merged! I'm trying to publish our update (following this SO)

Sahweet! So we now need to the App PR to get through review, before we can retest the held issues. Is that correct?

Updates:

iOS / Android

Considering this ✅

Web / Desktop

Upstream PR: Kidroca is working on updating w/ what we merged & some tests, requested by the maintainer
Fork PR is merged!
App PR just needs testing & approval 🙏  - there's some weird CORS issues also being handled at the same time, hopefully that won't hold us up long

Multiple avatar image types:

Made a new issue for gif & bmp fixes: https://github.com/Expensify/App/issues/14751
Planning to repurpose https://github.com/Expensify/App/issues/13038 to fix SVG avatars

Default avatars

PR was merged! 💪

@Beamanator, @trjExpensify Eep! 4 days overdue now. Issues have feelings too...

@trjExpensify I'm trying to figure out if the CORS issue is being handled / discussed elsewhere - I remember a slack convo somewhere but we need to bring this convo to Slack in my opinion, to get more advice from more knowledgable people (at least related to CORS & the issue we're hitting). So I bumped kidroca in the PR 👍

Also I think it makes sense to change this priority to weekly since we don't need daily updates at the minute, right?

Okay, I'm fine with that, as long as the individual bug issues are on daily still as per the process.

Updates:

Web / Desktop

Upstream PR: was updated last week, waiting on maintainer reviews
App PR: looks like we need to resolve some CORS issues (being discussed here) in order to move forward with this

Multiple avatar image types:

I split the gif & bmp fix issue into a new one specifically for bmp fix since the fixes are not related (I should have done that earlier).
So the 3 issues for this are:

https://github.com/Expensify/App/issues/14751
https://github.com/Expensify/App/issues/15035
https://github.com/Expensify/App/issues/13038

How we looking here, @Beamanator? CORS issue linked is closed, so we're unblocked again on that App PR?

Trying to find someone to take over https://github.com/Expensify/App/issues/14991 - posted in Slack

@Beamanator what's the latest?

Looks like the CORS issue is now being discussed here: https://github.com/Expensify/App/issues/15087 so App PR is not unblocked

The linked issue seems to have a PR moving on it again, so is web image caching going to be unblocked by that or still conditional on #14991?

So I'm a bit confused by what each issue is doing then if that's the case. 😕

Bump, @Beamanator?
or perhaps @mountiny can help enlighten me here as the PR linked to #15087 is done. Does that unblock https://github.com/Expensify/App/pull/13036 for web/desktop image caching?

Ya sryyyyy
So I really don't believe THAT change is what we're holding on, it's actually this one: https://github.com/Expensify/App/issues/14991
Which was moving, but as of this whatsnext post, we may have a big upcoming change that could help us a lot

What Alex said, we got a bit blocked with the headers changes but moving to our own servers should help a lot

Alright, so can we update this PR and associated issue to note what it's actually held on, because #14991 has merged and that's not it? https://github.com/Expensify/App/pull/13036

^^ @Beamanator @mountiny bump on the above.

@trjExpensify sorry for the delay!
Sorry but what's "this PR" that you're referring to here?
My understanding is that we're still waiting on moving NewDot web hosting to our servers (mentioned here)

Aahhh ok ok ok cool yeah sorry for not being clear about https://github.com/Expensify/App/issues/14991 being on hold, i justtttt put a hold in the title

So what issue is currently being worked on for this? It's all very confusing.

Is the server migration actively being worked on? Where can I follow that issue/project?

Good question! I just ping'd Amy & Marco so I'll report back when I hear :D

Yeah that's kind of my concern. The WN thread also looks very inconclusive as to whether we agreed it should be worked on.

Looks like Justin just created a tracking issue for the project: https://github.com/Expensify/Expensify/issues/277714

Still pretty on hold based on tracking issue

Should we put this issue on hold for the E/E issue?

@JmillsExpensify done 👍

Works for me!

Justin has the HL doc out for review, but we're still a little while off unholding this.

Still on hold - HL of doc is still in review

Migrating servers to S3 is progressing, but this is still on hold!

No change. Migrating servers to S3 is progressing, but this is still on hold!

Still in the works!

Just noticed that https://github.com/ascoders/react-native-image-zoom, the library we use for native ImageView has been abandoned.

Server migration still in the works.
As for Rory's comment, @Beamanator what are your thoughts on that? The remaining items we have are held on image caching, but replacing the use of an abandoned library seems unrelated. Is that something we need to explore now?

@Beamanator bump on this!

As for Rory's https://github.com/Expensify/App/issues/10894#issuecomment-1603070604, @Beamanator what are your thoughts on that? The remaining items we have are held on image caching, but replacing the use of an abandoned library seems unrelated. Is that something we need to explore now?

Asked in slack about this: https://expensify.slack.com/archives/C01GTK53T8Q/p1689185793050179

Server migration still in the works.
As for the RN image zoom library, seems like something Margelo is working on could allow us to switch it out, but it isn't causing a problem as is.

No change.

no change

Still blocked on the server migration project dependency.

Still blocked on the server migration project dependency.

Still blocked on the server migration project dependency.

Still blocked on the server migration project dependency.

still blocked

Justin is asking for a summary on the blocking issue to validate if there's another path without a server migration.

Checked in on that.

The first step in the dependency for the CORS issue is pretty much over the line (awaiting a confirmation), so we should be able to come back to the image caching issue now to unblock the rest.

Image caching PR is in review. Getting there!

Image caching PR is progressing still!

Super close. PR merged, so after the deploy cycle we should be able to come back here!

Image caching PR was deployed and reverted. Awaiting this now before re-implementing: https://github.com/Expensify/App/issues/32703

same ^

Same, awaiting this now before re-implementing: https://github.com/Expensify/App/issues/32703

https://github.com/Expensify/App/issues/32703 is fixed, should be good to move forward now. Thank you for your patience.

In light of #32703 being fixed, the new image caching PR is in review.

https://github.com/Expensify/App/pull/34505 is in review still!

The image caching PR was reverted again, so we're back to figuring that out in #12603.

New PR for #12603 is up.

Plan being worked on!

https://github.com/Expensify/App/pull/36560 in the works!

We merged it very recently. Looking good so far. So hopefully we can turn to https://github.com/Expensify/App/issues/9402 soon.

Updated title to remove the hold cuz the issue it was held on hit production
https://github.com/Expensify/App/issues/12603
(I have another issue that's held on this one)

What issue is it, @mallenexpensify?

Interesting! I don't think that needs to hold on this issue, it looks like it's being addressed here: https://github.com/Expensify/App/issues/35502
I'm going to go ahead and close this out now. We aren't adding anything new to it or require it for CAP or anything. The two remaining items we have are here and here, so follow along there if anyone is still interested!


Fixed the example spec happy flow

Codecov Report

Merging #138 into master will decrease coverage by 0.11%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #138      +/-   ##
==========================================
- Coverage   84.35%   84.24%   -0.12%
==========================================
  Files         104      104
  Lines        2557     2551       -6
  Branches      129      129
==========================================
- Hits         2157     2149       -8
- Misses        400      402       +2

Impacted Files
Coverage Δ

.../scala/com/ing/baker/recipe/scaladsl/package.scala
100% <ø> (+36.36%)
:arrow_up:

.../main/scala/com/ing/baker/runtime/core/Baker.scala
73.98% <ø> (+0.81%)
:arrow_up:

...r/runtime/event_extractors/MapEventExtractor.scala
12.5% <0%> (-75%)
:arrow_down:

...ime/event_extractors/CompositeEventExtractor.scala
95.23% <0%> (-4.77%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba11131...5de2297. Read the comment docs.


refactor: use esm instead of cjs

Motivation
Migrating from CJS to ESM modules to support importing libp2p which is ESM only
Change Summary
TBD
Merge Checklist

[ ] The title of this PR adheres to the conventional commits standard
[ ] The PR has been tagged with the appropriate change type label(s) (i.e. documentation, feature, bugfix, or chore)
[ ] Changes to the protocol specification have been merged

Codecov Report
Base: 90.65% // Head: 90.65% // No change to project coverage :thumbsup:

Coverage data is based on head (a0d4ffd) compared to base (795f31e).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #97   +/-   ##
=======================================
  Coverage   90.65%   90.65%
=======================================
  Files          22       22
  Lines        1198     1198
  Branches      251      251
=======================================
  Hits         1086     1086
  Misses        105      105
  Partials        7        7

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Integrated Terminal Display Problem

VSCode Version: 1.28.2
OS Version: Windows 10 1809 (OS Build: 17763.55)

Steps to Reproduce:

Open Terminal.
press any words then the leading path will disappear.
When I press "ENTER", it will return to normal.

Does this issue occur when all extensions are disabled?: Yes

same problem ...

https://github.com/Microsoft/vscode/issues/57803


Update EDA Settings Reciprocal Relationship to use Partner and add a Partner row

Critical Changes
Changes

We've updated the reciprocal relationship settings for Husband and Wife to use the existing picklist value Partner instead of Spouse. We've also added a new reciprocal setting for Partner. If you're starting with this version of EDA, these changes are included automatically. If you started with an earlier version, see Keep Up with Relationship Updates.

Issues Closed
New Metadata
Unpackaged Metadata
Deleted Metadata
Testing Notes

QA Passes - Will merge when item clears Merge Conflict @MatthewBlanski

QA Passes - Will merge when item clears Merge Conflict @MatthewBlanski


Vaccination indications?

What are these Vacc. indications of "age","job","medical" and "nursingHome"... what do they say?

thats the reason why they are vaccinated!

thanks!


[Feature] Add GCP KMS signer

Component
providers
Describe the feature you would like
https://github.com/georgewhewell/ethers-gcp-kms-signer
Additional context
https://github.com/alloy-rs/alloy/pull/44#pullrequestreview-1776205022

George @georgewhewell said he'll take it, so let's let him do it when he has time, no rush for it


Hooks api

Coverage increased (+0.2%) to 94.908% when pulling c099a4d8aade545bcc199d6675b6348ff4f44fde on falexandrou:hooks-api into 4f8b64a6d8e4959e2aa95e8bdba3729f34a1134d on hirakiuc:master.

Coverage increased (+0.2%) to 94.866% when pulling 08ba235811f38f1d33642ab1be0811735a29a4d2 on falexandrou:hooks-api into 4f8b64a6d8e4959e2aa95e8bdba3729f34a1134d on hirakiuc:master.

I'll check this after merging #102. 👍

Pushed updates regarding your comments. Feel free to review whenever you can

I created a script to test each hooks API with real test repository on Bitbucket.
And I found these points.
(1) Bitbucket pipeline webhook can fetch via Repository#hooks, but can't fetch via Repository#hook.
Always Tinybucket::Error::NotFound raised when I fetch the hook via Repository#hook API.
I think this may be a Bitbucket API issue... 🤔
(2) I can't create my new hook via Repository#hooks#create.
Always error raised. 😳
# access_token is replaced with "my_access_token"
D, [2017-01-28T10:00:09.787664 #65829] DEBUG -- : [api.bitbucket.org] POST /2.0/repositories/altabjpworks/sandbox/hooks?access_token=my_access_token (0.812 s)
E, [2017-01-28T10:00:09.787773 #65829] ERROR -- : Invalid response code:500
/Users/hirakiuc/repos/src/github.com/hirakiuc/tinybucket/lib/tinybucket/response/handler.rb:18:in `on_complete': POST https://api.bitbucket.org/2.0/repositories/altabjpworks/sandbox/hooks?access_token=my_access_token 500 {"type": "error", "error": {"message": "No JSON object could be decoded", "id": "c66366d84f584274a08d01549ad95cb5"}} (Tinybucket::Error::ServiceError)

It looks like that the format of request parameter is invalid.
Can you create new hook to your Bitbucket repository via new Repository#hooks#create API?

This looks like a bitbucket issue. in the past i managed to avoid these errors by explicitly setting the Content-Type header to application/json. Will check this though


Interpolate typed array folded

This variant of https://github.com/d3/d3-interpolate/pull/65 folds interpolateTypedArray into interpolateArray.
The only part I find weird is in README, where we explain that no defensive copy of the template array is made, nor, in the case of typed array, do we have defensive copies of a and b. Not sure if this is intelligible at all.

My main objection is now the name.
“interpolateTypedArray” will happily interpolate (generic) arrays of numbers; there’s no requirement that the array by a typed array. So I argue that “interpolateNumberArray” is a better name. It’s still fine that d3.interpolate detects typed arrays and uses that to dispatch to interpolateNumberArray instead of interpolateArray; that’s just a heuristic for detecting arrays of numbers. (And one that’s cheaper than walking through the entire array and checking the type of every element.)
Also, interpolateTypedArray doesn’t work with all typed arrays. Specifically: BigInt64Array and BigUint64Array. You’ll get a TypeError: Cannot mix BigInt and other types, use explicit conversions. If we use interpolateNumberArray, this is more reasonable because the typeof is bigint and not number, and we could have an interpolateBigIntArray if we wanted.

Implies interpolateNumberArray will be exposed, so we can call it directly when we know we have only numbers? I'm fine with that (and will start over in a new branch).
I think it would also be nice to detect the situation in which an array contains only numbers and switch to interpolateNumberArray. Checking b.every(i => typeof i == "number") is probably reasonable? A small price when false, and a big gain when true.

Yep, interpolateNumberArray would be exposed.
I dunno, do you think we need to do the type check on elements in the generic interpolate? I feel like if you care about the performance and it’s ambiguous you can just opt-in by calling interpolateNumberArray directly.


Misc updates

Updated to latest coroutines
Resolves #307
Resolves #308

I think this is good to go 👍


Is amazing graphql-genie production ready?

@acoreyj Thanks for creating such an amazing project. This project has a great potential to make developers life easy.  I want to use graphql-genie with sapperjs https://sapper.svelte.technology/ and mongodb for my new project but I have few concerns

Is graphql-genie production ready?
Is there any roadmap for future development?
Graphql has n+1 request problem and fortunejs mongodb adptor is using multiple find statements for related documents which means multiple database roundtrip https://github.com/fortunejs/fortune-mongodb/issues/21#issuecomment-428655260. Performance of Nested queries is my main concern. Other similar projects like https://www.graphile.org/graphile-build/look-ahead/ are using single database query for nested graphql queries. We can try to convince fortunejs author to use single mongodb aggregation pipeline with $lookup operator for finding the related documents to avoid multiple database roundtrips but ideally, a great project like graphql-genie shouldn't be dependent on any third party module for data access. I know its lots of work but I think it will greatly improve query performance. Fortunejs mongodb adapter is also lacking support for transactions and data aggregations.

We should have a project/documentation website for such an amazing project and a discoed server for community support.

Hey!
I wouldn't say it is production ready yet, there has not been a lot of actual use yet since it is so new. Almost to a point where I will share it more widely which will help. I plan on using it in a production (although low risk) project later this year.
There is a bit of a road map in the main Readme
As far as performance that is a concern that genie doesn't attempt to fix at this point, other than making sure the same data isn't requested twice per request. I added a roadmap something I plan to change to make sure if an adapter can optimize a request such as how postgraphile does Genie will properly send it the right  information to do so and will properly handle the response. So in short it will be up to the database adapter to handle keeping requests to a minimum.
I am a big fan of reinventing the wheel, I think fortune is great but do agree some of the adapters could be upgraded for performance and enabling transactions.
Definitely have plans to create a website eventually, Discord is in works


Connect CodeHighlighter with TextEdit without friend-access

Addresses https://github.com/godotengine/godot/pull/81551#discussion_r1328100152.

Thanks!


(null), does not exist!(base)

Hi I am trying to run SLHSD, it seems that the installation is good, but I got this (null), does not exist!(base). maybe I did some wrong.

Hi, please show me your running commend, thanks.

Hi, please show me your running command, thanks.

Hi,
Here it goes.
(base) @.**:~/applications/SLHSD$ ./SLHSD
(null), does not exist!(base) @.**:~/applications/SLHSD$
El sáb, 20 may 2023 a las 4:58, guanttttt @.***>)
escribió:

Hi, please show me your running command, thanks.
—
Reply to this email directly, view it on GitHub
https://github.com/luojunwei/SLHSD/issues/2#issuecomment-1555444771, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AULEKMD4HEU2HN3UEG4A6ZTXHAXMBANCNFSM6AAAAAAYFE2ZUY
.
You are receiving this because you authored the thread.Message ID:
@.***>

--
*Sioly Becerra *
PhD Student
Instituto de Investigación en Agrobiotecnología (CIALE)
Universidad de Salamanca.
Campus de Villamayor, Calle del Duero, 12.
37185, Villamayor, Spain.
Tel: +34 923 294 400. Ext. 5111.
@.***
https://linktr.ee/siolybecerra


Human readable description support

JSON Schema (v3 and v4) allows a human readable description to be associated with each field: http://tools.ietf.org/html/draft-zyp-json-schema-03#section-5.22
It would be good if the @JsonProperty annotation had a description field, which the module respected when creating JSON Schema.

I think that this either has been implemented (for properties), or will be via #88.


Bug: Unable to run tests locally

Bug: Getting Unable to import dspy when trying to run the new tests
Steps to reproduce:

Clone main branch
python -m venv .env
source .env/bin/activate
pip install -r requirements.txt
pytest tests/predict/test_predict.py

Alternate steps to reproduce:

Clone main branch
poetry install
poetry shell
pytest tests/predict/test_predict.py

This throws a ModuleNotFoundError: No module named 'dspy'
Why does this matter?
2 Reasons:

I was going to help Cyrus with part of the backend refactor, but can't test my code locally
We can't integrate the tests into CI

Full trace:
==================================================================================== test session starts ====================================================================================
platform darwin -- Python 3.11.4, pytest-7.4.0, pluggy-1.0.0
rootdir: /Users/isaac/Projects/dspy
plugins: anyio-3.5.0
collected 0 items / 1 error

========================================================================================== ERRORS ===========================================================================================
______________________________________________________________________ ERROR collecting tests/predict/test_predict.py _______________________________________________________________________
ImportError while importing test module '/Users/isaac/Projects/dspy/tests/predict/test_predict.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
../../anaconda3/lib/python3.11/importlib/__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
tests/predict/test_predict.py:1: in <module>
    import dspy
E   ModuleNotFoundError: No module named 'dspy'

This could totally be wrong with how I understand local python builds or some other mistake. Regardless, there should be a little section in the readme about how to run the tests, and get the env setup locally for development

Ahh great catch. Happy to merge any fixes


Render method should be required in a class form react component.

It is very common to come into this error.
TypeError: instance.render is not a function

I need much more context to understand this issue. Where is the error coming from, what is your typescript code, etc.


Pose Landmarks model not working as expected on iOS

Have I written custom code (as opposed to using a stock example script provided in MediaPipe)
None
OS Platform and Distribution
iOS 17.3
Mobile device if the issue happens on mobile device
iPhone 14
Browser and version if the issue happens on browser
No response
Programming Language and version
React Native 0.73.6
MediaPipe version
Latest
Bazel version
No response
Solution
Pose Landmark Detection
Android Studio, NDK, SDK versions (if issue is related to building in Android environment)
No response
Xcode & Tulsi version (if issue is related to building for iOS)
15.3
Describe the actual behavior
Incorrect detection
Describe the expected behaviour
Correct detection of poses in real time
Standalone code/steps you may have used to try to get what you need
Since there's no direct guide for the iOS platform here developers.google.com/mediapipe/solutions/vision/pose_landmarker, I extracted pose_detector.tflite and pose_landmarks_detector.tflite models from pose_landmarker_full.task. Then, I used the vision-camera-fast-tflite library to run pose_landmarks_detector.tflite.

I managed to get some data. It looks like the model can detect some changes in movement, but the output landmarks are mostly totally incorrect. I would like to know if there is any general guide for pose landmark detection on iOS and if is it even possible.

I went through guides for multiple platforms and also tried to examine the MediaPipe framework written in Python to see if some preprocessing or postprocessing is going on. However, I still don't have any reasonable explanation for why the model output is incorrect.

Other info / Complete Logs
Detection example: https://i.stack.imgur.com/0SJNI.jpg

Hi @VasilP202,
We have a new Pose Landmarker iOS example available here. You can find it in the code base. We recommend implementing it based on that for now. We are currently working to integrate it into the Pose Landmarker documentation section, and it will be available soon.
Thank you!!

Thank you for the response.

@kuaashish Yes, will can close the issue.

Hi @VasilP202,
Thank you for confirming. We are now closing this issue and marking it as resolved internally.


regression: can't prerender unicode paths

Describe the bug
Greek character paths can't properly resolve.
There's a regression from https://github.com/sveltejs/kit/pull/1062 when a unicode path is visit'ed because of the following change:
https://github.com/sveltejs/kit/blame/2a1e9795ad9773e04669a7b9d0234caa0b688ade/packages/kit/src/core/adapt/prerender.js#L227
If it's changed, say, to:
await visit(decodeURI(path), parsed.pathname.replace(config.kit.paths.base, ''));

It builds correctly.
Reproduction
Same as: https://github.com/sveltejs/sapper/issues/1174
Logs
No response
System Info
System:
    OS: Linux 5.8 Ubuntu 20.04.2 LTS (Focal Fossa)
    CPU: (24) x64 AMD Ryzen 9 3900X 12-Core Processor
    Memory: 14.31 GB / 31.33 GB
    Container: Yes
    Shell: 5.8 - /usr/bin/zsh
  Browsers:
    Firefox: 90.0
  npmPackages:
    @sveltejs/adapter-node: ^1.0.0-next.35 => 1.0.0-next.35
    @sveltejs/kit: ^1.0.0-next.137 => 1.0.0-next.137
    svelte: ^3.34.0 => 3.40.1

### Severity

blocking all usage of SvelteKit

### Additional Information

_No response_

@datio your solution didn't work for me. See here for a failing example: https://github.com/sveltejs/kit/commit/765527ac0cdd0033c56b04860f261341d29a6f46
If you're able to figure out what's wrong and send a fix, I'd be happy to merge it

@benmccann yes, indeed.
Maybe a solution is to detect the 404 error and simply ignore it, which does the trick: https://github.com/datio/kit/commit/662309fb4ca06d4138e6302ef20e213fa4c570a1
The tests fail though so I haven't sent a pull request..

A better approach might be to add: request.path = decodeURI(request.path); at the start of the resolve function here.

That still fails for me


Use left/right instead of full for terminal overview ruler decorations

Currently we use "full" position for the terminal overview ruler:

Let's change this to use left for success/skipped and right for errors so it's less noisy, more readable and blends in with the editor more:

done in https://github.com/microsoft/vscode/commit/a854e41105496eff1ba0b39e7d61e988cb3a8b9a


distributed

how to ues distributed?

Hi,
Today I was working on distributed configuration , and i have seen if you add new worker to cluster existing worker is being restarted and it causes multiple session on database . Examining on this issue .
Thanks


Getting ERROR: ChatConnector: receive - invalid token. Check bots app ID & Password with every message.

After upgrading to v3.1.1 is tarted getting ERROR: ChatConnector: receive - invalid token. Check bots app ID & Password on every received message.
This started happening with no change in the code or any modification.
#742 claims that the fix is in v3.1.1

This means that you don't have your bot configured with the right Microsoft App Id and Password. As a result we cannot validate JwtTokens sent to your bot. Here is a step by step troubleshoot guide for auth issues.

I had a working bot for several weeks then once I updated the npm package to v.3.1.1 it started happening. I verified a few times that I am using the correct credentials and I also created a second bot with completely new credentials. It still happens.
This is how I add the credentials to the configuration:
var connector = new builder.ChatConnector({
    appId: process.env.MICROSOFT_APP_ID,
    appPassword: process.env.MICROSOFT_APP_PASSWORD
});

Am I doing something wrong?

If everything is definitely configured correctly, be sure to confirm your (or whatever machine your bot is running on) system time is accurate.
Three hours of my life I'll never get back.

I'm also having the same problem. I double checked and triple checked the credentials and the time.
The jwt.verify function in ChatConnector always fails.

@vlttnv I'm assuming you solved this issue, if not please reopen. Thanks!

@Andrea-Orimoto I'm still facing this issue in https://github.com/Microsoft/BotBuilder/issues/710#issuecomment-351025956

@loretoparisi Are you running this in docker? I was experiencing clock drift in my containers. Google for docker clock/time drift and you see some solutions.


Solr committer not working.

I am trying to setup the Norconex collector to push to Solr. I have it connected to and populating Elasticsearch correctly, but I really need Solr working. The crawl will complete,but then error out on one of several issues when trying to commit to Solr. I have tried several example configs from your Github issues pages,but still not working.
Last I tried was the following:
        <!-- Be as nice as you can to sites you crawl. -->
        <delay default="1500" />

        <!-- At a minimum make sure you stay on your domain. -->
        <httpURLFilters>
            <filter class="$urlFilter"
                onMatch="include">http://www.aerospike.com/docs/.*</filter>
            <filter class="$urlFilter"
                onMatch="exclude">.+\.(png|jpg|jpeg|gif|ico|css|js)$</filter>
            <filter class="$urlFilter"
                onMatch="exclude">.+\?.*</filter>
        </httpURLFilters>
        <importer>
            <postParseHandlers>
                <!-- Unless you configured Solr to accept ANY fields, it will fail
                     when you try to add documents.  This "KeepOnlyTagger" ensures
                     to drop every field crawled except those you want. -->
                <tagger class="com.norconex.importer.tagger.impl.KeepOnlyTagger"
                    fields="document.reference,title" />
                <!-- The importer has a lot of config options where you can define
                     constants, rename fields, manipulate your content, etc. -->
            </postParseHandlers>
        </importer>
        <!-- A "committer" dictates where the crawled content goes. -->
        <committer class="com.norconex.committer.solr.SolrCommitter">
            <solrURL>http://localhost:8983/solr/stage_posts</solrURL>
        </committer>

        <!-- When developing or troubleshooting, you can use the filesystem
             committer so you can have a precise look at the content
             that would be sent to Solr. -->
        <!--
        <committer class="com.norconex.committer.impl.FileSystemCommitter">
            <directory>./examples-output/minimum/crawledFiles</directory>
        </committer>
        -->

    </crawler>
</crawlers>

Error this one is generating is:
aused by: org.apache.solr.client.solrj.impl.HttpSolrClient$RemoteSolrException: Error from server at http://localhost:8983/solr/stage_posts: [doc=http://www.aerospike.com/docs/client/perl/install/] missing required field: PI
Is there a known working committer config for Solr I can use? So far all of the example commit configs I have found generate errors and do not complete the commit.

You've probably declared PI as unique (so it's mandatory). Make sure it's always filled otherwise it'll fail. Looks like a Solr usage related instead of Norconex.
Can you log the output with <tagger class="com.norconex.importer.handler.tagger.impl.DebugTagger" logContent="true"/> so you see if's something is missing?
You could also output to a folder and analyze the data there to see why it's failing.

Due to lack of feedback and because, as @dgomesbr pointed out, this is rather a Solr configuration issue, I am closing.  Please open a new ticket under the Solr Committer project if you suspect a problem with it.


fix template additional newline bug

fix: https://github.com/microsoft/BotFramework-Composer/issues/1211

Pull Request Test Coverage Report for Build 90305

23 of 27 (85.19%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.04%) to 84.321%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

libraries/botbuilder-lg/src/lgResource.ts
23
27
85.19%

Totals

Change from base Build 89936:
-0.04%

Covered Lines:
7838

Relevant Lines:
8960

💛  - Coveralls


Support single quotes for values in translate params

I'm submitting a ...  (check one with "x")
[ ] bug report => check the FAQ and search github for a similar issue or PR before submitting
[ ] support request => check the FAQ and search github for a similar issue before submitting
[x] feature request

Current behavior
We are migrating from angular-i18n to ng2-translate
When we use

 it throws an error from https://github.com/ocombe/ng2-translate/blob/master/src/translate.pipe.ts#L98
Expected/desired behavior
Since its not possible to pass double quotes from inside directives like above it would be nice if single quotes can be supported and handled similar to https://github.com/ocombe/ng2-translate/blob/master/src/translate.pipe.ts#L96
Currently the only way to do this is to use

 which is not very nice for readability
What is the motivation / use case for changing the behavior?
Use the pipe from within directives
Please tell us about your environment:

ng2-translate version: latest

Angular version: 2.0.0 final

Browser: all

Language: TypeScript

I can do a PR if required

Hu, that's weird, I think it's more a bug than a feature.
A PR would be nice indeed :)


feat: Added social media links

Title and Issue number

Title :Added social media links
Issue No. : #892
Code Stack :
Close #892

Description

I have added social media links
Video/Screenshots (mandatory)

Type of PR

[ ] Bug fix
[x] Feature enhancement
[ ] Documentation update
[ ] Other (specify): _______________

Checklist:

[x ] I have performed a self-review of my code.
[x ] I have commented my code, particularly in hard-to-understand areas.
[ x] I have tested the changes thoroughly before submitting this pull request.
[ x] I have provided relevant issue numbers, screenshots, and videos after making the changes.
[x ] I have gone through the  contributing.md file before contributing

Additional context:

##Are you contributing under any Open-source programme?

[x ] I am contributing under GSSOC'24
[ ] I am contributing under VSOC'24

@apu52  can you please review soon

@itsekta  can you please review it 🙏🏾

@apu52 Now please go through the pull request

Hey @Saipradyumnagoud, can you also improve the UI a little bit by adding gap between them, keep the icon color to white and on hovering over the icons change the color of the icons to their default icon instead of white only. Suppose Facebook icon color is blue (#1877F2) by default the icons are white only but on hovering over the facebook icon the color should be #1877F2. Similar for all the icons, checkout the colors for other icons as well

Hey @Saipradyumnagoud, can you also improve the UI a little bit by adding gap between them, keep the icon color to white and on hovering over the icons change the color of the icons to their default icon instead of white only. Suppose Facebook icon color is blue (#1877F2) by default the icons are white only but on hovering over the facebook icon the color should be #1877F2. Similar for all the icons, checkout the colors for other icons as well

Yes sure i will work on it

@apu52  @itsekta made the required changes requested

@Saipradyumnagoud, why are the icons getting smaller on hover

@Saipradyumnagoud, why are the icons getting smaller on hover

Should i make icons bigger on hover

Your choice, you can make a little bigger (scale 0.5) or don't just the ui should look nice.

@itsekta yes now i have made please check

Nice

Nice

@itsekta  can you please merge the pull request

@apu52 will be merging it

@apu52 will be merging it

Yes make it soon


Observatory: cpu profile unusable with long method names

Dart2js has a class created with many mixins that the VM names:
Visitor&IrBuilderMixin&SemanticSendResolvedMixin&ErrorBulkMixin&BaseImplementationOfStaticsMixin&BaseImplementationOfLocalsMixin&BaseImplementationOfDynamicsMixin&BaseImplementationOfConstantsMixin&BaseImplementationOfNewMixin&BaseImplementationOfCompoundsMixin&BaseImplementationOfSetIfNullsMixin&BaseImplementationOfIndexCompoundsMixin
It has a constructor called:
Visitor&IrBuilderMixin&SemanticSendResolvedMixin&ErrorBulkMixin&BaseImplementationOfStaticsMixin&BaseImplementationOfLocalsMixin&BaseImplementationOfDynamicsMixin&BaseImplementationOfConstantsMixin&BaseImplementationOfNewMixin&BaseImplementationOfCompoundsMixin&BaseImplementationOfSetIfNullsMixin&BaseImplementationOfIndexCompoundsMixin.Visitor&IrBuilderMixin&SemanticSendResolvedMixin&ErrorBulkMixin&BaseImplementationOfStaticsMixin&BaseImplementationOfLocalsMixin&BaseImplementationOfDynamicsMixin&BaseImplementationOfConstantsMixin&BaseImplementationOfNewMixin&BaseImplementationOfCompoundsMixin&BaseImplementationOfSetIfNullsMixin&BaseImplementationOfIndexCompoundsMixin
When this name is displayed in the cpu profile, the profile becomes too wide to be usable.
It might be an idea to move the columns after the name to before the tree (i.e. from far right to far left).

@rakudrama, could you add a screen shot?  I just want to see how bad this looks.

The UI for the profiler has been changed so that it is usable with long method names.


Support Human Entity

Introduction
When we register a human entity it crashes
Changes
CustomiesEntityFactory->registerEntity has been changed to support human entity

You don't need Customies to register a Human entity, just do it with the native PM API

You don't need Customies to register a Human entity, just do it with the native PM API

So what's the point of registering entities with customies?

This change is actually not necessary to support human entities. You can pass in your own creationfunc to the register function to override customies default behaviour.
registerEntity(CustomHuman::class, "customies:custom_human", static function (World $world, CompoundTag $nbt): Entity {
    return new CustomHuman(EntityDataHelper::parseLocation($nbt, $world), Human::parseSkinNBT($nbt), $nbt);
});

so it's useless to register entities with customies , so delete this function

It's not, because custom entitiy identifiers need to be sent in the AvailableActorIdentifiersPacket. I guess it could be simplified down to a "registerEntityIdentifier", but the current method just makes it slightly easier and more simple for people to register entities. I appreciate the pull request, but like I mentioned it can be done with the current method already

You also need to simplify the registration of human entities.


Update test and code coverage results

File are located in ./test-results and ./test-coverage.

[ ] Update test and code coverage results (develop, or and master).

@swissarmykirpan @isen-ng I think we should create the coverage statistics for each branch (bugfix/*, feature/*, develop and master). With the coverage information in PRs, we have an additional check, if we like.
Should we publish the test results as well? What about static code analysis? Sonarcloud would provide all of these features, should we switch? What do you think?

I think we should create the coverage statistics for each branch (bugfix/, feature/, develop and master)

I don't think we should do the tests for every branch. Only pushes to develop and master branches and PRs only. Testing on bugs and feature branches is a waste of resources IMO because there may be many irrelevant pushes before the actual PR. And since we are going to fork, there shouldn't be any bug & feature branches to test as well.

Should we publish the test results as well?

Yes I think so. let's select a service to use and upload our reports. I used codecov.io in my code. There should also be a check in PRs (although the check may not be required to pass right now).

What about static code analysis? Sonarcloud would provide all of these features, should we switch?

I like sonarcloud as well but I just could not get PR analysis and PR checks to work properly... sigh.

@swissarmykirpan @isen-ng I think we should create the coverage statistics for each branch (bugfix/*, feature/*, develop and master). With the coverage information in PRs, we have an additional check, if we like.

I think it makes sense running tests only for PRs

Should we publish the test results as well? What about static code analysis? Sonarcloud would provide all of these features, should we switch? What do you think?

I've used Sonarcloud in the past and it's good.

If we want this to beneficial, we need to allow for whatever rules and test coverage statistics to be available on the developers local machine, without having to run create a PR.
Test Execution works out of the box, but things like code coverage will need some thought

but things like code coverage will need some thought

If we build each branch, we would at least see the results in Sonarcloud. I have no idea how we can cover everything local.

but things like code coverage will need some thought

If we build each branch, we would at least see the results in Sonarcloud. I have no idea how we can cover everything local.

https://www.sonarlint.org/visualstudio/

but things like code coverage will need some thought

If we build each branch, we would at least see the results in Sonarcloud. I have no idea how we can cover everything local.

https://www.sonarlint.org/visualstudio/

😂 I totally forgot about SonarLint. I didn't know it supported VSC, great!

I've used self hosted sonarqube in the past.
The server isn't doing any analysis but compare results with the quality gate.
All the analysis is still done locally.
Not sure if we could do that on sonarcloud

for code coverage, rider 2019 comes shipped with it out of the box.
I bet it's using dotcover tool, integrates with coverlet as well.
https://medium.com/@DomBurf/performing-code-coverage-for-net-core-2-0-applications-7280dd2af22b

we should just be able to use sonarcloud for it all :)

I have the Cake tasks already prepared after we merged the PR #52, I can add the SonarCloud support.

@swissarmykirpan If you create a SonarCloud account and add following environment variables to AppVeyor SONARQUBE_URL, SONARQUBE_KEY, SONARQUBE_ORGANIZATION and SONARQUBE_TOKEN, I can create the PR to close this issue. SonarCloud will show you the values as soon as you create a project. If you need help to map the values to the environment variables, let me know.
I highly recommend secure variables for API keys.


test issue

just seeing if I can create an issue with an account that is not part of the DDMAL organization...

turns out I can!


Rod's issue: attemptToQueueUploadOfVNAndV0Files

And: Mismatch: At least one of the uploads had an uploadCount different than: 2 on server logs
With more detail, on client log:
2021-03-30 07:42:54.559 [Error] [main] [SettingsScreenModel.swift:100] addAttachments(vc:) > Pending Uploads: UploadObjectTracker: fileGroupUUID: 6C109D5B-AA37-47D5-9F12-FC4578E885D3; v0Upload: Optional(true); batchUUID: FAC7126F-542C-4ABA-8F52-C6CC2ADF677B:
	UploadFileTracker: fileUUID: 20696980-7097-4E3E-BF9C-98BA6DB386D5; fileVersion: nil; uploadIndex: Optional(1); uploadCount: Optional(1)
	UploadFileTracker: fileUUID: 4C02C28E-BA10-46A3-A04B-2D9948DE0844; fileVersion: nil; uploadIndex: Optional(2); uploadCount: Optional(2)
UploadObjectTracker: fileGroupUUID: 0C0A02CF-3C3D-4B32-9635-1C73B7F206FF; v0Upload: Optional(true); batchUUID: AE762D1D-CF39-4C44-B32B-D27FDA3477CA:
	UploadFileTracker: fileUUID: 69A9A362-52DF-4F32-9645-A6C660B61AC0; fileVersion: nil; uploadIndex: Optional(1); uploadCount: Optional(1)
	UploadFileTracker: fileUUID: 10D7705C-2550-4FF4-B270-450307FCBFCD; fileVersion: nil; uploadIndex: Optional(2); uploadCount: Optional(3)
	UploadFileTracker: fileUUID: 93E1D41C-55DF-40F8-880D-7912794F7021; fileVersion: nil; uploadIndex: Optional(3); uploadCount: Optional(3)

The first agenda item: Assign uploadCount/uploadIndex more consistently and in all cases when an upload is queued. From the above logs it's clear this isn't happening.


WinUI Control layout Bug: Number box control with Clear all (X) button overlapping inline SpinButtons

WinUI Toolkit Bug Report

Name of component or part of Toolkit:
Number Box Control with Spin Buttons
Describe the bug:
The NumberBox control in an initially collapsed container has it's Clear All (X) button overlapping with inline Spin Buttons. The issue still exists in the 2.8.2 version.
Version Info:
Microsoft.UI.XAML: 2.8.2

Another concern with the NumberBox control is that setting the Background to Transparent does not make the control transparent.
I tried copying in the NumberBox template from generic.xaml but when I ran it (without modification) I got an exception.


Resolve unit testing failure in Travis console

Resolve unit testing failure reported in Travis console

Related branch Enhancement/travis-setup

After so many hit and trials and spending my whole wifi bandwidth on googling for its resolution, it is finally rectified.
The script which finally worked is stated below:
xcodebuild -scheme Medication -project Medication.xcodeproj -configuration 'Debug' -destination 'platform=iOS Simulator,id=1A6EAD45-0A28-421A-A6D4-AD0866464FAA' clean build test


Don’t rely on working directory during index preparation

Amazon Linux and CentOS don’t support working directory. We can work around this by passing --package-path to swift build.
rdar://128037023

@swift-ci Please test


invalid ID type, the ID must be an int or a string

Setup:
minikube version: v1.31.2
commit: fd7ecd9c4599bef9f04c0986c4a0187f98a4396e

|----------|-----------|---------|--------------|------|---------|---------|-------|--------|
| Profile  | VM Driver | Runtime |      IP      | Port | Version | Status  | Nodes | Active |
|----------|-----------|---------|--------------|------|---------|---------|-------|--------|
| minikube | docker    | docker  | <IP_ADDRESS> | 8443 | v1.27.4 | Running |     1 | *      |
|----------|-----------|---------|--------------|------|---------|---------|-------|--------|

Client: Docker Engine - Community
 Version:    24.0.6

helm install used from https://github.com/kluctl/template-controller/blob/main/docs/install.md

list.yaml
apiVersion: templates.kluctl.io/v1alpha1
kind: ListGitlabMergeRequests
metadata:
  name: list-gl-mrs
  namespace: default
spec:
  interval: 1m
  project: kaiehrhardt/template-controller-issue
  state: opened
  targetBranch: main
  sourceBranch: .*

kubectl describe listgitlabmergerequests.templates.kluctl.io
Name:         list-gl-mrs
Namespace:    default
Labels:       <none>
Annotations:  <none>
API Version:  templates.kluctl.io/v1alpha1
Kind:         ListGitlabMergeRequests
Metadata:
  Creation Timestamp:  2024-02-27T09:23:07Z
  Generation:          1
  Managed Fields:
    API Version:  templates.kluctl.io/v1alpha1
    Fields Type:  FieldsV1
    fieldsV1:
      f:metadata:
        f:annotations:
          .:
          f:kubectl.kubernetes.io/last-applied-configuration:
      f:spec:
        .:
        f:interval:
        f:limit:
        f:project:
        f:sourceBranch:
        f:state:
        f:targetBranch:
    Manager:      kubectl-client-side-apply
    Operation:    Update
    Time:         2024-02-27T09:23:07Z
    API Version:  templates.kluctl.io/v1alpha1
    Fields Type:  FieldsV1
    fieldsV1:
      f:status:
        .:
        f:conditions:
    Manager:         template-controller
    Operation:       Update
    Subresource:     status
    Time:            2024-02-27T09:23:07Z
  Resource Version:  1588
  UID:               7a9c2852-23c0-441b-9be6-e62e45262aea
Spec:
  Interval:       1m
  Limit:          100
  Project:        kaiehrhardt/template-controller-issue
  Source Branch:  .*
  State:          opened
  Target Branch:  main
Status:
  Conditions:
    Last Transition Time:  2024-02-27T09:23:07Z
    Message:               invalid ID type &intstr.IntOrString{Type:1, IntVal:0, StrVal:"kaiehrhardt/template-controller-issue"}, the ID must be an int or a string
    Observed Generation:   1
    Reason:                Error
    Status:                False
    Type:                  Ready
Events:                    <none>

Version 0.2.3 of the helm chart works as expected. It looks like https://github.com/kluctl/template-controller/commit/534f1a499b8a228fe28b943cd59c78d5488fef88 has introduced a bug.

@kaiehrhardt This one slipped through. I fixed it via #87 and will create a release ASAP.
Unfortunately, the project has no proper e2e/unit testing setup yet. I hope that at some point I find time to implement those.


Media Resource

A basic resource for managing uploaded media showing the model each file was uploaded to along with CRUD operations.

Handled by https://github.com/spatie/laravel-medialibrary


Restore User announce post body & first login UI fix

restore User announce post body
fix "no content" popping up before signup wizard
do not switch to '#/setup' during test
all tests passing

Merged magic hash changes, ready for merge to master.

Great, Willy. Some issues:

The tests don't pass - there are "js standard" issues. Run "npm test".
 Commit titles should be limited to 50 chars. If you need to write more, put a blank line after the title, and put the rest of the message below.
See the two inline comments.

Separated UI events to UI specific EventEmitter (iterating towards Flux), and fixed tests.
Also got rid of 2 second delay for UI refresh and replaced it with an event-based solution. Let me know if it needs anything else for merge!

Comments that don't prevent a merge:

Do not merge from master, especially not more than once. This will create a nonlinear history that is difficult to understand. You should be rebasing your PRs on top of master. The only merge commits that exist should be merging into master.
We should be using Redux instead of events. After inquiring with @maraoz, he agrees and argues Redux is better than events :)

Also, your commit messages should be no wider than 80 chars. Your editor should have a way to limit the width to 80 chars. See how this looks non-wrapped when viewing with default settings with 'git log':

I get a test failure when running the tests. This prevents a merge.

  208 passing (15s)
  1 pending
  1 failing

  1) Layout "after all" hook:
     TypeError: Cannot read property 'unmonitorBlockchainAPI' of undefined
      at DattCore. (index.js:177:5)
      at [object Generator].next (native)
      at node_modules/asink/index.js:47:35
      at step (node_modules/asink/index.js:29:16)
      at node_modules/asink/index.js:47:5
      at new Promise (node_modules/karma/node_modules/core-js/modules/es6.promise.js:209:7)
      at spawn (node_modules/asink/index.js:24:10)
      at DattCore.asyncNetworkClose (index.js:176:10)
      at layout.jsx:28:22
      at [object Generator].next (native)
      at node_modules/asink/index.js:47:35
      at step (node_modules/asink/index.js:29:16)
      at node_modules/asink/index.js:47:5
      at new Promise (node_modules/karma/node_modules/core-js/modules/es6.promise.js:209:7)
      at spawn (node_modules/asink/index.js:24:10)
      at Context. (layout.jsx:27:12)

Project has been rearchitected - PR no longer applies.


Theme is Too Dark

My V6 Sapphire theme won't work anymore, so I have to switch back to V5. However, the V5 theme is much darker than I would like it to be.

V5 is no longer in development, and V6 isn't working right now due to a minor bug.
In fact, if you had looked at the ClearVision Discord you would realize that the bug preventing V6 from working can easily be fixed.
Look at the Discord server before submitting bug reports, and please don't complain about an old theme being 'too dark'
Please close this issue.

It's great that you found a solution and all that, but we should not have to join a discord group to sort through the various channels to find the fix.


[mdf] Scrape Moksha + slightly more flexible default pron selector.

Strangely enough some (but not all) Moksha pages are not standard. The pronunciations don't reside under the regular list item elements ("li"), but under the paragraph elements ("p"). For an example, see the page for ала
Please let me know whether you'd prefer a custom extractor for this rather than changing the default template.

[ ] Updated Unreleased in CHANGELOG.md to reflect the changes in code or data.

Whether this should be a custom extractor or not depends on whether this breaks anything. Are you willing to run data/src/./scrape.py for a while and check for any regressions?

Good idea. I'll try that.

I've been running a full scrape for a while now. I presume I can just leave it running and report back the results when done.

Yes indeed. No need to commit it, just check file sizes before and after I
suppose. (The README in data/ explains how to generate the tables.)
On Tue, Dec 29, 2020 at 10:19 AM Alexander Gutkin<EMAIL_ADDRESS>wrote:

I've been running a full scrape for a while now. I presume I can just
leave it running and report back the results when done.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/kylebgorman/wikipron/pull/295#issuecomment-752117724,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABG4OL3DMCJBAYIPL6U4RLSXHXOVANCNFSM4VLRWZMQ
.

Yes, what Jackson said, just curious whether it was obvious to him that anything would break from this. If Sasha says it's okay, we'll roll it out.

@agutkin update please? Scrape go okay so far?

@agutkin update please? Scrape go okay so far?

It was almost ok. Will give an update in a bit.

It was almost ok. Will give an update in a bit.

I ran it all the way up to the Czech at which point the server was rebooted by the administrators.
The diff is provided below. By eyeballing it, it mostly looks ok modulo Armenian. For some reason it is not scraped well with a lot of entries removed.
The diff is provided below. By eyeballing it, it mostly looks ok modulo Armenian. For some reason it is not scraped well with a lot of entries removed.  (I have since solved Armenian and am working
on Cantonese.)
Okay, I think this is go. Any objections?
On Wed, Jan 6, 2021 at 3:40 PM Alexander Gutkin<EMAIL_ADDRESS>wrote:

I ran it all the way up to the Czech at which point the server was
rebooted by the administrators.
The diff is provided below. By eyeballing it, it mostly looks ok modulo
Armenian. For some reason it is not scraped well with a lot of entries
removed.
Reply to this email directly, view it on GitHub
https://github.com/kylebgorman/wikipron/pull/295#issuecomment-755660231,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABG4OOB7RDOMTDJOH3YMKDSYTDDBANCNFSM4VLRWZMQ
.

Those are both known issues. (I have since solved Armenian and am working
on Cantonese.)
Okay, I think this is go. Any objections?
On Wed, Jan 6, 2021 at 3:40 PM Alexander Gutkin<EMAIL_ADDRESS>wrote:

I ran it all the way up to the Czech at which point the server was
rebooted by the administrators.
The diff is provided below. By eyeballing it, it mostly looks ok modulo
Armenian. For some reason it is not scraped well with a lot of entries
removed.
Reply to this email directly, view it on GitHub
https://github.com/kylebgorman/wikipron/pull/295#issuecomment-755660231,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABG4OOB7RDOMTDJOH3YMKDSYTDDBANCNFSM4VLRWZMQ
.

I haz no object. One issue though: I've been wondering whether making these extraction templates more sophisticated may adversely affect the performance. WDYT? No idea how this over-the-network-HTML-thing functions.

I haz no object. One issue though: I've been wondering whether making these extraction templates more sophisticated may adversely affect the performance. WDYT? No idea how this over-the-network-HTML-thing functions.

No idea myself. I don't think this one disjunction is going to be the big
issue. The network IO is the limitation I think.
On Wed, Jan 6, 2021 at 6:27 PM Alexander Gutkin<EMAIL_ADDRESS>wrote:

I haz no object. One issue though: I've been wondering whether making
these extraction templates more sophisticated may adversely affect the
performance. WDYT? No idea how this over-the-network-HTML-thing functions.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/kylebgorman/wikipron/pull/295#issuecomment-755776761,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABG4OLON46CWD4MYNCQ32TSYTWV5ANCNFSM4VLRWZMQ
.

No idea myself. I don't think this one disjunction is going to be the big
issue. The network IO is the limitation I think.
On Wed, Jan 6, 2021 at 6:27 PM Alexander Gutkin<EMAIL_ADDRESS>wrote:

I haz no object. One issue though: I've been wondering whether making
these extraction templates more sophisticated may adversely affect the
performance. WDYT? No idea how this over-the-network-HTML-thing functions.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/kylebgorman/wikipron/pull/295#issuecomment-755776761,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABG4OLON46CWD4MYNCQ32TSYTWV5ANCNFSM4VLRWZMQ
.

Add note to changelog and I'll approve, Sasha.

Add note to changelog and I'll approve, Sasha.

Done.

Done.

Done again.

Done again.


ID legal assistance received:
User feedback: something
(legal_service_representation)

Question ID
legal assistance received

Details
Is it possible to not show this page if the person already responded "No" to the question about whether or not they have a lawyer?

Variable being sought
legal_service_representation

Package version
0.3

Filename
docassemble.FeeWaiverRequest:data/questions/fee_waiver_request.yml

Correct. This is per the current A2J functionality and seems to match the form, which only requires 1 of the 3 boxes to be checked.

Will follow up with Kim to see if it is useful to the courts to see boxes 1 AND 2 checked if both do in fact apply.


GPS info isn't transferred from exif to description when a group of pictures is being uploaded

This picture https://commons.wikimedia.org/wiki/File:United_States_Custom_House_(Baltimore,Maryland)-_24.jpg
And others like it that I uploaded with the mobile app don't have the GPS data that is in the exif data included in the description.

Thanks for opening this issue. That seems quite critical.

Thanks for reporting this @VDK . To clarify, this only happens when you upload by selecting multiple pictures in your gallery, then tapping "Share" and then selecting the Commons app, right?

Affirmative

Would like to take this up if nobody else has.

@Bluesir9 : Feel free, thanks! :-)

Looks like this and #874 are the same.

This one is solved, proviously


fine-tuning

Will this model open source the fine-tuning code?
It will be helpful ,thanks.

@MidsummerHi The fine-tuning scripts can be found in the ./scripts directory. Please check the available tasks and use the corresponding code for your needs. If you’re looking for a specific task that isn’t included in the repository, feel free to reach out, and I’ll be happy to assist.