Unable to restore my Lightning wallet

Background
I was doing a Lightning Torch on reddit when my node suddenly wasn't able to connect anymore. See more about it [here].(https://www.reddit.com/r/Bitcoin/comments/i9lbnp/bored_shall_we_start_a_lightning_torch/g1g5ue6/)
So I deleted every instance of LND to reinstall it again and when I did, I run the command lncli create and went for the option that asked me if I had a 24 word recovery seed, which I do.
And when everything is running as expected, I do lncli walletbalance and I get 0 sats, when I should have 10k.
Plus, when running lncli channelbalance I also get 0 sats, when I should have 111 sats.
The onchain balance is no problem since I was able to recover it with another wallet, but how do I recover my channels?
Your environment

Version of LND: lnd version 0.10.4-beta commit=v0.10.4-beta
Operating System: Raspbian GNU/Linux 10
Version of bitcoind: v0.20.1
Running a Raspberry Pi 3.

Expected behaviour
I should be able to see my onchain balance as well as my channel balance when I enter my 24word seed.
Actual behaviour
All my balances show 0 sats.

To recover your channels, you need the channel.backup file that is created by lnd. The seed isn't enough.
See this chapter: https://github.com/lightningnetwork/lnd/blob/master/docs/safety.md#static-channel-backups-scbs
Also, because restoring from backup involves closing all channels to get the on-chain sats back, your 111 sats would probably go to miner fees because that is too small an amount to be represented on-chain and would be considered dust.
Just deleting everything really is the worst thing you can do in this case. If you made a backup before deleting, try restoring with the channel.backup file so at least the other peer is notified the channel won't become active again.
Closing this as there is nothing to fix in the code. Feel free to comment if you need help with the SCB restore. The document linked above should contain a link to the restore procedure.


Added GHCR CD

Added it the way, there is now a DockerfileLightCaddy which is built by default, but it can be easily changed. Everything should now be in sync of the changes back on upstream, since I couldn't squash it the way I needed to.

As I said in the last PR, there really isn't a need for a different webserver in this container. Nginx is more than good enough for this. If you do want to use a different webserver it would be on the reverse proxy level. Since there is bare minimum features needed (no SSL, etc) in this container, I would much prefer it to be kept as-is, especially with default builds as it removes any possible errors that people may run into off the hop.
Thanks!

Resolved, uses nginx now. Also there were some other errors I fixed. I am thinking about a :caddy tag to have right away, too. Dunno tho rn.


Form templates

Trying to fix form generators! baby bye bye bye

These are required to the form generator:
https://github.com/resolve/refinerycms/blob/master/core/lib/generators/refinery/engine/engine_generator.rb#L9-L10
https://github.com/resolve/refinerycms/blob/master/core/lib/generators/refinery/engine/engine_generator.rb#L14-L52

You will need to insert these lines into the form generator:
https://github.com/resolve/refinerycms/blob/master/core/lib/generators/refinery/engine/engine_generator.rb#L157-L160

Probably will also need code like this in the form generator:
https://github.com/resolve/refinerycms/blob/master/core/lib/generators/refinery/engine/engine_generator.rb#L162-L185

As you can probably see there are a lot of opportunities to DRY up the generators!

Looking heaps better!

Remember to update the specs!

I haven't compared regular engine generator code with this form one but could it be possible to use engine generator and on top of it just add this form stuff?

It actually generates pretty dissimilar engines though

nvm then :)


Add Fee Amount into the output for Normal

Add Fee Amount into the output for Normal.

Added in v0.1.1


Change Windows OS to support default terminal [defterm]

This issue tracks the work required to add "default terminal" support to Windows.
This is not terminal-specific, but Windows Terminal will benefit from it.

original content
This bug-tracker is monitored by Windows Console development team and other technical types.  We like detail!
If you have a feature request, please post to the UserVoice.

Important: When reporting BSODs or security issues, DO NOT attach memory dumps, logs, or traces to Github issues. Instead, send dumps/traces to<EMAIL_ADDRESS>referencing this GitHub issue.

Please use this form and describe your issue, concisely but precisely, with as much detail as possible

Your Windows build number:  Microsoft Windows [Version 10.0.18885.1001]

What you're doing and what's happening: When I type start in a command prompt session in the Windows Terminal, the new command prompt window opens in a new conhost window.

What's wrong / what should be happening instead: The new command prompt should open in a new tab in the existing Terminal window.

This is by design.
We have plans to support setting another application as the "default terminal" on Windows, but those plans are still very rough and in the works.

This will require an OS feature. I'm updating the title to represent the default terminal OS change.

I'm renaming this to add the [defterm] keyword to the end so that we can find it easily in searches. The words "default" and, well, "terminal" come up alarmingly often in this repository. :smile:

I am curious how ConEmu does this. Once installed, every new cmd/ps/bash window opens in ConEmu as a new tab

I am curious how ConEmu does this. Once installed, every new cmd/ps/bash window opens in ConEmu as a new tab

Same here, not sure how but hopefully Windows will be updated to support the terminal fully.

I am curious how ConEmu does this. Once installed, every new cmd/ps/bash window opens in ConEmu as a new tab

ConEmu may be (ab)using the ability to set a custom debugger for a process. I believe Process Explorer does the same to "replace" Task Manager

Process Hacker also supports “replacing” the Task Manager.

I am curious how ConEmu does this. Once installed, every new cmd/ps/bash window opens in ConEmu as a new tab

ConEmu may be (ab)using the ability to set a custom debugger for a process. I believe Process Explorer does the same to "replace" Task Manager

AFAIR, it just changes a registry key.
Whatever, ConEmu manages to do this, so MST should too.

ConEmu injects hooks (DLLs) into specific processes (such as explorer.exe or devenv.exe) to intercept the creation of new console windows under those processes. You can read more about this on the official docs: https://conemu.github.io/en/DefaultTerminal.html
As mentioned in that link, this method is purely a hack. It is most definitely not a viable solution for Windows Terminal.

But… it works. Having an access to whole subsystem simplifies a thing.

The difference is that Windows Terminal is an official Microsoft product, so the expectation here is that the default terminal will not be changed using an uscalable ugly hack, but be natively supported by Windows.

I don't know if this is the appropriate place to mention this however I feel it might be relevant.
For some reason right now, cmd and powershell, seemingly have abritary huge font sizes and window sizes depending on how and from where they are launched. From start menu, via explorer, via Win + R, etc.
When the new terminal becomes the default will it:

Have a consistent font size and window size?
Also be the default terminal from doing "Open Poweshell window here" etc?

Here are some examples to demonstrate what I mean.
In order, launched from a task bar shortcut, launched from "Open Powershell window here", launched from typing "powershell" in File Explorer address input (note how the default prompt seems to be different too).

It would be good if the Terminal unifies all of this. It's quite frustrating.

@lloydjatkinson thanks! It's only slightly appropriate here, but suffice it to say that:

the Console has three (!) (and a half) different places it reads settings from
Terminal has only one (and a half)

To answer your specific numbered points:

Yeah, totally, because there's only one source of truth for settings.
Yeah, that's what this feature is tracking. Redirecting to the Terminal any time a console window is launched for interactive use.

The default prompt just looks like it's representing that you're in a different directory. Starting powershell from the address bar in explorer does so in whatever directory you're currently viewing.

Dear Team, is this still very much down in the backlog? Now with the release of Powershell7, it raises the demand for having easier access to a modern terminal that is able to handle the correct Powershell.
#1421 does only open PS5.1 at the moment and there is no official option to change this
I've spoken with Steve Lee on twitter and of course it would be benefit to promote the use of both products Terminal and Powershell on recent releases / insider releases Windows 10 clients.

@Karl-WE we’re getting v1 out the door before we start looking at the changes necessary to Windows to support the registration, enumeration and launch of alternate console hosts (or the terminals that would use them)

Since this would likely require some API support, it can probably only be done as part of a big Windows release.

Thanks Dustin for your excellent work here. I hope that this inter team effort can be communicated with the Insider and Powershell Teams, Good luck with the 1.0 release schedules. perhaps we can have this achieved for 20H2 which leaves everyone involved 9 months at least.

I hope this gets added sooner rather than later, are there any working unofficial workarounds?

Rest assured that this issue would have had hundreds of community comments making up all sorts of crazy workarounds if there were any ;)

I have a idea for some basic bat file:
run your bat file in background and then close the default cmd window
START /B  wt cmd /c yourfile.bat
exit

Rest assured that this issue would have had hundreds of community comments making up all sorts of crazy workarounds if there were any ;)

I have been starting cmd (and now powershell) from Win+R for decades, but I am painfully retraining myself to type wt instead.  I guess you can teach an old dog new tricks. Slowly. 😁
This works thanks to the app execution alias wt.exe in %userprofile%\AppData\Local\Microsoft\WindowsApps

Hi team, users, since wt has now very good set of options and a preset settings json and a user defineable part which also includes the setting, which console is the default console to be opened when launching wt - I thought it would be sufficient to pick up all the rough plans (https://github.com/microsoft/terminal/issues/492#issuecomment-490092382) to pick up at least the following attempt:
Integration of Win+X.
How can I think you can accomplish this:

connect with Jennifer Gentlemen and team for settings
add a new settings item that is able to replace or update the following setting
update the ADMX file accordingly

Settings > Personalisation > Taskbar
"replace Win+X cmd with powershell"
![replace-command-prompt](https://user-images.githubusercontent.com/45657752/82780689-49c24300-9e58-11ea-8099-9e8d
Maybe it is a naive point of view of a user, yet I cannot imagine that it is possible to switch cmd to Powershell at this point for years now, but not making the small step forward to replace these two items again with wt. And yes it would make sense this way having wt with and without admin rights, as per default it is also unelevated like every other console (with few exceptions)

8e642eef.png)
Can you please elaborate why this is so much work to do? It would be a beginning.
Having the choice of a default terminal application in Settings > Apps and Features > Default app -  I can understand this requires more under the hood work. I double checked with NirSoft ShellExView that this can not be that easily achieved at the moment.
However changing the Win+X setting mentioned above is already something that is there.
Please mind there is even a 3rd party tool that can change the Win+X menu to anyones liking but the download source I would nowadays rather rate untrusted.
You can find the tool here but use at your own risk
Win+X Menu Editor
Created by Sergey "Happy Bulldozer" Tkachenko
http://winaero.com
This software uses the hashlnk tool source code
hashlnk was created by Rafael Rivera
http://www.withinwindows.com/
Hope I am allowed to post this reference otherwise please remove it. If I may upload the app as a zip or Onedrive please let me know. There is no hint that it is not allowed to mirror it elsewhere.

p.s. I've tried myself to Add wt into a new group in Win+X menu but for some unclear reason it fails to do so. Permissions seem about right. I can add any file as a link except things from
%localappdata%Microsoft\WindowsApps (even with full path).

I am curious what prevents this by design.

You can't add wt.exe directly, as it's not a "real file", but if you create a shortcut to wt.exe, the tool will be able to add it and it'll work just fine.
You can read more about it here: https://www.hanselman.com/blog/TotallyUnsupportedHacksAddWindowsTerminalToTheWinXShortcutMenu.aspx

If I understand the function of WinX correctly Windows does not do links by path only, probably to prevent spoofing but also generating a hash of the file. Since all "apps" have zero filesize the "cannot open" might be due to no being able to generate the hash, not like because not being able to access / read it.

@Karl-WE Just wanted to make sure everyone is on the same page here. Windows Terminal is a terminal/console application - not a shell. Cmd and PowerShell are shells. (See also: https://www.hanselman.com/blog/WhatsTheDifferenceBetweenAConsoleATerminalAndAShell.aspx)
So the Win+X setting is (IMHO) irrelevant for this issue (as it just determines the shell, not the terminal application).

I understand your definition. At the end, given the many same requests, WinX does help to make Windows Terminal

more prominent, which can only aid it's success and spread and ultimately honor the work spent.

help users to make their favourite default shell more accessible.
Which might be not cmd or PoSh 5.1 as configurable at the moment.

Seeing it in this light, I still agree with your noted difference but in the end the goal is to help making a shell easier to access while having the better features of terminal compared to default shell.

Its interesting that @DHowett says here that its not possible:
https://github.com/microsoft/terminal/issues/492#issuecomment-630540738
but then last year he says it is possible:
https://github.com/microsoft/terminal/issues/1817#issuecomment-508372244

@nu8 you’ll probably agree that “replacing your system conhost with the version of conhost built out of this repository” and “having Windows launch an instance of Terminal automatically” are vastly different things ;)
This repository hosts both the console host and the Terminal. One builds on the other, but they are certainly not the same.

@nu8 given the vast amount of things @DHowett has to review and triage sometimes there maybe differences. As you quoted it is clear that 492 in timeline came before 1817 and things can change.
it would be more irritating if he posted it other way around. But however:
the good news is: it is on the schedule, no longer in the backlog
see

1
Default terminal
If a command-line application is spawned, it should open in Windows Terminal (if installed) or your preferred terminalIssue: #492Spec: #2080

source: https://github.com/microsoft/terminal/blob/master/doc/terminal-v2-roadmap.md

@DHowett thank you for your work around here, I have a small question:
Do you think we could expect this to roll out in 20h2 or 21h1 windows' update? Are you aware of any internal work (on OS level) going in this direction?
I understand that plans may change, but I'm still curious :)

We're the team that would have to do the OS-level work to enable this feature, so I'd be very surprised if we weren't aware of work being done to enable this.
We're still just getting past the 1.0 release of the Terminal, so we haven't really gotten a start on this quite yet. I'd say it's unlikely to land in 20H2 or 21H1, considering we'd probably have to have the feature done (or at least prototyped) by now to get it in to either of those releases.

i wonder what will come first - defterm setting or full gpu acceleration support in WSL2, at which point we could just use native linux terminals instead, at least for development that can be virtualized

Because this issue has so many subscribers, I'm going to lock it.
If you have something to contribute that will impact the engineering direction for this feature, please e-mail me at the address on my GitHub profile.


PEP544, inheriting Protocol show error: Inheriting 'Protocol', which is not a class.

Environment data

VS Code version: 1.44.2
Extension version (available under the Extensions sidebar): 2020.4.76186
OS and version: Arch
Python version (& distribution if applicable, e.g. Anaconda): python 3.8 (but should produce the same if typing_extensions are installed)
Type of virtual environment used (N/A | venv | virtualenv | conda | ...): pipenv
Relevant/affected Python packages and their versions: typing, mypy, typing_extensions
Relevant/affected Python-related VS Code extensions and their versions: XXX
Jedi or Language Server? (i.e. what is "python.jediEnabled" set to; more info #3977): same result, tried both
Value of the python.languageServer setting: Microsoft

Expected behaviour
No error should be raised since it is defined in PEP Protocol must be used this way
Actual behaviour
error in Problems view:
Inheriting 'Protocol', which is not a class.
Steps to reproduce:
from PEP544
from typing import Protocol

class SupportsClose(Protocol):
    def close(self) -> None:
        ...

[NOTE: Self-contained, minimal reproducing code samples are extremely helpful and will expedite addressing your issue]

Logs

Output for Python in the Output panel (View→Output, change the drop-down the upper-right of the Output panel to Python)

Nothing relevant

Output from Console under the Developer Tools panel (toggle Developer Tools on under Help; turn on source maps to make any tracebacks be useful by running Enable source map support for extension debugging)

Hemmm, coredump opening the devtool under arch, too new kernel or glibc, have to investigate if it's electron side or vscode one (but I guess nothing relevant there either)

Please, if you correct the issue, could you do it that even on python version before 3.8, if using typing_extensions it work also ? (typing extensions were used by mypy before 3.8, I think: https://mypy.readthedocs.io/en/latest/protocols.html#simple-user-defined-protocols)

Those errors you see comes directly from the linters. Please paste the Python output panel mentioned in the issue template. What type of linter are you using?
The output panel should contain the commands linters run that results in those erros.

Hi, I use flake8 and mypy, but the error is given by the plugin, I think (no linter named)

I'm sorry but it seems the code snippet I gave was wrong:
On python 3.8 this has no error:
try:
    from typing import Protocol
except ImportError:
    pass
    # from typing_extensions import Protocol  # to remove for python3.8

class SupportsClose(Protocol):
    def close(self) -> None:
        ...

This has the errors I gave in the screenshot:
try:
    from typing import Protocol
except ImportError:
    from typing_extensions import Protocol  # to remove for python3.8

class SupportsClose(Protocol):
    def close(self) -> None:
        ...

on python 3.7 with typing_extensions (which predates PEP544, so not strictly to be supported since it requires add of typing_extensions package)

So, at the end, the bad behavior is only present when the typing_extensions is in the source code (! not always imported, on python3.8, it is not imported)
If the error come from external linter, sorry for the false report, but I was thinking errors and warning coming with "Python(something)" are from the vscode extension.

For the records, remember that Protocols can not be instantiated, their only reason to be there is to provide to code analyzers and IDE clue about what a class must provide to work with duck typing, if you try to create an instance of it, mypy will complain with:

and running code will crash with:
Traceback (most recent call last):
  File "bad_behaviour.py", line 10, in <module>
    foo = SupportsClose()
  File "/tmp/test2/lib/python3.7/site-packages/typing_extensions.py", line 1545, in _no_init
    raise TypeError('Protocols cannot be instantiated')
TypeError: Protocols cannot be instantiated


[cosmos] Adds v4 samples

Packages impacted by this PR
@azure/cosmos
Issues associated with this PR
Describe the problem that is addressed by this PR
This PR generates v4 samples and removes v4 features from v3 sample folder.
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Are there test cases added in this PR? (If not, why?)
Provide a list of related PRs (if any)
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists

[ ] Added impacted package name to the issue description
[ ] Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
[ ] Added a changelog (if necessary)

API change check
API changes are not detected in this pull request.

For generating v4 samples, we first navigate to dev-tool directory and install it globally.
$ cd common/tools/dev-tool
$ npm install -g

Then, we move to cosmos folder to build and publish samples -
$ rushx build
$ npx dev-tool samples publish

https://github.com/Azure/azure-sdk-for-js/wiki/Samples-v2-Migration-Guide


How to understand that the session has expired?

Hello! Thanks for this great library!
I call .getActiveSessions() - the library shows the active session, but in trust wallet i killed the session.
It turns out that the library stores the local session in sp, but this session is killed in trust wallet
is there any mechanism to check the session is online?

Sessions should be deleted automatically on both ends when deleted.
If they are not, then I am not aware of any way to detect if a session is no longer valid.
Sorry I know that isn't helpful.
If this is happening in trust wallet, then the issue is likely in their court: They might not have the most recent version of the WC repo, and so it isn't automatically deleting it on the dApp end.


Any plan on adding some support for regular expressions to the language?

This has many parts:

a builtin type
the usual methods
special syntax (sigils, ...)
what set of regexps to support
what amount of backtracking should be allowed if at all

One can definitely implement the first 2 with minimum friction, but as I find Starlark's strength to be in its Turing-incompleteness guarantees I am wondering if this was / is being discussed as an addition to the language.

After time and json,
time https://github.com/google/starlark-go/tree/wip-skylark-time
json https://github.com/google/starlark-go/tree/json
regexp is the most requested package for the Starlark "standard library". No-one has sketched a prototype yet, but it shouldn't be hard to come up with a sound Starlark API for regular expressions that can be backed by the Go, Java, and C++ implementations of RE2, which is linear time (non-backtracking; see github.com/google/re2), though we will need to disallow \C.
I imagine the basic API would look something like the Go regexl API:
   load("regexp")
   rx = regexp.compile("b(an)*a")
   rx.matches(str src) # returns bool
   rx.find(str src) # returns text of match
   rx.find_all(str src, int max) # returns list of matches
   rx.replace_all(str src , str or function) # returns replaced text
   rx.find_submatches(str) # returns list of complete match and each subpattern match

We might also want variants that return the indices (not text) of each match.

Any update on this, yet?

Sorry, no.

For what it's worth, I stumbled on https://godoc.org/github.com/qri-io/starlib/re

@b5 What about this one? Ready for it? :-)

I think this would be great to get to attack next given the roll we're on with the time and math packages, but the design & implementation of any regex package or language level support requires more of upfront design discussion:

design an re package? write a proposal for inclusion in the language? both?
If we're designing a package, does it take inspiration from go's regexp or python's re?
What's providing the underlying regex parser in go?

My answers to these questions:

It should be a package. We should avoid introducing overhead into the language, even if it adds parity to python. I'm thinking specifically of the cost of implementing a starlark interpreter in another language  that doesn't have easy support for RE2-style regex syntax. Having it as a package makes it easier to opt out.
Our initial regex implementation follows the python re style, but I think sitting down & working through a minimal design draft is in order.
In my opinion using anything other than go's regexp would be a mistake. But with the choice to use regexp it's important to document any differences for users coming from python.

🤦 I literally hadn't read the comments above where @adonovan  laying out answers to all of my questions. Ok @essobedo I think we can take a stab at implementing the prototype laid out above & get a PR going from there.

I actually implemented this for the Java version using re2. It works really well for our use case. You can see it here:

https://github.com/verygoodsecurity/starlarky/blob/master/larky/src/main/resources/stdlib/re.star
https://github.com/verygoodsecurity/starlarky/blob/master/larky/src/main/java/com/verygood/security/larky/modules/re/RegexMatcher.java
https://github.com/verygoodsecurity/starlarky/blob/master/larky/src/main/java/com/verygood/security/larky/modules/re/RegexPattern.java

It exposed a bug in re2j implementation (PR is coming soon-ish).

I actually implemented this for the Java version using re2. It works really well for our use case. You can see it here: ...

Interesting, thanks.
It's funny, I wrote RE2/J a decade back for use in the regexp package of a Google in-house embedded configuration language that had implementations in multiple languages and needed a consistent regexp interface. That description now applies equally to Starlark, and it's using RE2/J for the same reason.
BTW, although RE2/J is asymptotically faster than j.u.regex, in practice it's usually significantly slower. Not that that really matters here.
It appear that you are using Starlark as a "secure" embedded language within your VGS product. By design, Starlark is hermetic in many ways, but we've never claimed that it is secure for running untrusted code. Scripts can easily cause denial of service by exhausting all memory, or by hash flooding. Also, RE2/J can be induced to run out of stack when parsing a deep expression such as "(((...(((".  (The Go version is somewhat less susceptible to such attacks because Go stacks can grow 100x larger than JVM threads.)

Scripts can easily cause denial of service by exhausting all memory, or by hash flooding

Yes, I'm aware of this (actually noticed this discussion re: hash flooding in the Fnv32 hash function discussions in the bytes PR :D). We've enlisted Trail of Bits for a code audit (and we'll be happy to contribute whatever findings upstream) and what you've mentioned so far was on our roadmap. This isn't in production yet, not until we've checked all the bells and whistles, but it's actually a pretty neat idea if it works for what we want to use it for.

Also, RE2/J can be induced to run out of stack when parsing a deep expression such as "(((...(((". (The Go version is somewhat less susceptible to such attacks because Go stacks can grow 100x larger than JVM threads.)

I was not aware of this problem, that's good to know, thank you!

@b5 please, let me know if you cannot work on this feature because if so, no worries, I can do it alone this time 😄

@essobedo sounds great! I'd be delighted to jump on peer review if you can write the implementation! I think it'll get done much quicker that way 😊

@b5 If so, may I rely on what you have done for https://github.com/qri-io/starlib/commits/master/re?

Some preliminary questions:

What regexp syntax are implementations to use? I think the only sensible answer, for reasons of portability and asymptotic efficiency, is RE2. We should link to the RE2 Syntax page.
We should also make clear that byte-oriented features (i.e. just \C) are not supported, since these are impossible to implement in Java or other languages whose strings are encoded as UTF-16.
Should we offer separate compile/match operations? In a compiled language this is the norm, for reasons of efficiency and early detection of errors, but interpreted languages tend to offer the "convenience" of recompiling the expression every time. (And presumably gaining back the cost by caching.)
Do we need to offer variants of the match function that return indices, not substrings? What does Python do here?
We should offer a function to quote RE metacharacters so that quote(s) is a regexp matching exactly and only s.

@b5 If so, may I rely on what you have done for https://github.com/qri-io/starlib/commits/master/re?

Absolutely I see two ways to get started:

If you'd like to file a PR into github.com/qri-io/starlib I can promise a through review there before we open a PR into this repo.
We can use the same workflow we've been using, I'll open an initial PR that you can take over.

Either works for me, just let me know which you'd prefer @essobedo.
@adonovan:

What regexp syntax are implementations to use? I think the only sensible answer, for reasons of portability and asymptotic efficiency, is RE2. We should link to the RE2 Syntax page.
Very much agreed here. The PR we file should use RE2 syntax and link to current spec in package documentation.

We should also make clear that byte-oriented features (i.e. just \C) are not supported, since these are infeasible to implement in Java or other languages whose strings are encoded as UTF-16.
Noted. Bonus points if we can provide a clear error when a user attempts to construct a regex with \C.

Should we offer separate compile/match operations?
I think we should go the interpreted language route, at least at first. It's a non-breaking change to add regex compilation later.  Python's re package offers compile.

My question for you @adonovan: can we compile expressions on .Freeze()?

Do we need to offer variants of the match function that return indices, not substrings? What does Python do here?
I need to do a little more digging on this & report back. re.Match objects (the result of calling re.match) can be addressed by index. Your initial package API from above in this thread does not spec any kind of Match return type, which may allow us to sidestep the issue at first?

We should offer a function to quote RE metacharacters so that quote(s) is a regexp matching exactly and only s.
Noted!

Another thing to consider long-term is a cache of compiled regular expressions, my question here is more about where that should be stored, and establishing a policy on how packages should handle something like a cache. I'm assuming this should be stored on the starlark thread. I don't think this is needed for an initial implementation, but would be great to get some initial guidance

Absolutely I see two ways to get started:

If you'd like to file a PR into github.com/qri-io/starlib I can promise a through review there before we open a PR into this repo.
We can use the same workflow we've been using, I'll open an initial PR that you can take over.

The way #2 would be great if it is possible for you

can we compile expressions on .Freeze()?

I'm not sure I understand what you're getting at. Patterns are immutable, so their freeze method is a no-op. And compilation can fail, so you need to report the error immediately. Also, you can compile and run a pattern in the same module, before freeze comes into play.

Your confusion answers my question 😄. I was having trouble building a mental model of the point where compilation is happening

Before moving forward, I think we should double check that this is the API we'd like to target for an initial package. This is @adonovan's suggested API, and the one I think we should go with:
load("regexp")
rx = regexp.compile("b(an)*a")
rx.matches(str src)                       # returns bool
rx.find(str src)                          # returns text of match
rx.find_all(str src, int max)             # returns list of matches
rx.replace_all(str src , str or function) # returns replaced text
rx.find_submatches(str)                   # returns list of complete match and each subpattern match

I made a mistake in my earlier comment regarding compile/match. I should have said that I think se can slip the match operations at first, and just use this compile-only API to start with.


[Idea] Is it possible to make gas giants and planets cast shadows on the local planet

This is an idea just to make the experience a bit more realistic, thought you guys may have insight. When the local planet is a moon this would be most effectivly seen when the planet or gas giant is between the sun and the moon

not without major shader programming, the way lighting works in DSP is all faked based on sun direction. Very performant tho


Doesn't work ( Propagation )

[<EMAIL_ADDRESS>global loadsave.cpp:248 cv::findDecoder imread_('./cache/images/32.jpg'): can't open/read file: check file path/integrity
[<EMAIL_ADDRESS>global loadsave.cpp:248 cv::findDecoder imread_('./cache/depths/32.png'): can't open/read file: check file path/integrity
I have only 0-4.jpg in /images and 0.png in /depths

same question!!!

costs.dmb
depths.dmb
normals.dmb

These files should be generated by the Propagation submodule executable if it successfully completes.
graphics_utils.py
        cv2.imwrite(os.path.join(cdata_image_path, str(idx+1)+".jpg"), src_img)
        write_cam_txt(os.path.join(cdata_camera_path, str(idx+1)+".txt"), src_K.detach().cpu().numpy(), src_w2c.detach().cpu().numpy(),
                                                                            [depth_min, (depth_max-depth_min)/192.0, 192.0, depth_max])
    # c++ api for depth propagation
    propagation_command = r'./submodules/Propagation/Propagation ./cache 0 "1 2 3 4" ' + str(patch_size)
    os.system(propagation_command)

def generate_edge_mask(propagated_depth, patch_size):
    # img gradient

The code directly executes an Propagation executable through os.system() without verifying if the utility exists or contemplating the result of this operation.
Here's my hack for compiling the Propagation submodule with MSVC 2022, along with compiled .exe and OpenCV .dll files
https://github.com/nk4517/GaussianPro/tree/propagation_win32

@1
For some reason, when I add this code to main.cpp it starts working without errors

Could you please provide your hardware and environment information? I would like to reproduce the bug and work towards resolving the issue as quickly as possible.

costs.dmb
depths.dmb
normals.dmb

These files should be generated by the Propagation submodule executable if it successfully completes.
graphics_utils.py
        cv2.imwrite(os.path.join(cdata_image_path, str(idx+1)+".jpg"), src_img)
        write_cam_txt(os.path.join(cdata_camera_path, str(idx+1)+".txt"), src_K.detach().cpu().numpy(), src_w2c.detach().cpu().numpy(),
                                                                            [depth_min, (depth_max-depth_min)/192.0, 192.0, depth_max])
    # c++ api for depth propagation
    propagation_command = r'./submodules/Propagation/Propagation ./cache 0 "1 2 3 4" ' + str(patch_size)
    os.system(propagation_command)

def generate_edge_mask(propagated_depth, patch_size):
    # img gradient

The code directly executes an Propagation executable through os.system() without verifying if the utility exists or contemplating the result of this operation.
Here's my hack for compiling the Propagation submodule with MSVC 2022, along with compiled .exe and OpenCV .dll files https://github.com/nk4517/GaussianPro/tree/propagation_win32

Thanks for your explanation! This part will be bound to PyTorch in the next release.

@kcheng1021
windows 10
1050ti
cuda 11.8
opencv 4.9.0
python 3.11.1
no conda

I believe there might be an issue with reading the file names, possibly due to different character settings on different machines. To troubleshoot this, could you please try adding the following code after line 99 in the file "/submodule/Propagation/main.cpp":
ref_id = 0;
src_ids_str = "1 2 3 4";
This will hardcode the values to see if training is successful.

Still errors

Still errors

Please provide me with the error information.

Same as before
PS D:\dasdsa\GaussianPro> .\submodules\Propagation\Propagation.exe ./cache 0 "1 2 3 4" 20
[<EMAIL_ADDRESS>global loadsave.cpp:248 cv::findDecoder imread_('./cache/images/32.jpg'): can't open/read file: check file path/integrity
[<EMAIL_ADDRESS>global loadsave.cpp:248 cv::findDecoder imread_('./cache/depths/32.png'): can't open/read file: check file path/integrity
OpenCV: terminate handler is called! The last OpenCV error is:
OpenCV(4.9.0) Error: Bad argument (Matrix operand is an empty matrix.) in cv::checkOperandsExist, file C:\GHA-OCV-1_work\ci-gha-workflow\ci-gha-workflow\opencv\modules\core\src\matrix_expressions.cpp, line 24
But when i add this on line 104 std::cout << problem.ref_image_id << std::endl; it's starting to work and saves dmb files

Can you please print the problem.ref_image_id at line 425 of Propagation.cpp? Let's see when the number 32 appears. So, if you add something at line 104 and retrain, will it run normally? Additionally, I have a suggestion: the VRAM of a 1050ti might not be sufficient to complete a training session with 30,000 iterations. Similar to 3DGS, which requires 24GB of VRAM, if you want to successfully train on a 1050ti, you may need to reduce the number of training images and increase the value of percent_dense.

PS D:\dasdsa\GaussianPro> .\submodules\Propagation\Propagation.exe ./cache 0 "1 2 3 4" 20
32
[<EMAIL_ADDRESS>global loadsave.cpp:248 cv::findDecoder imread_('./cache/images/32.jpg'): can't open/read file: check file path/integrity
[<EMAIL_ADDRESS>global loadsave.cpp:248 cv::findDecoder imread_('./cache/depths/32.png'): can't open/read file: check file path/integrity
Yes if i run train.py training is complete

And thanks for the advice with percent_dense

You may need to debug further to identify which iteration exactly outputs the number 32, instead of simply using cout to print it. I am also reproducing this bug and provide you with a prompt response as soon as possible.

I changed ref_id >> problem.ref_image_id; to problem.ref_image_id = ref_id; in main.cpp like here
https://github.com/kcheng1021/GaussianPro/issues/8#issuecomment-1976135963
now it's working

I changed ref_id >> problem.ref_image_id; to problem.ref_image_id = ref_id; in main.cpp like here #8 (comment)
now it's working

Yeah! I just found it too. This could be the differences in features between different versions of C++. Thank you very much for your sharing and debuging. So if you found the issue is solved, I will close the issue.

Thank you

Also thanks for your help to improve the project.

Hi, I'm still having this issue, even after applying this fix. Is there any way to find out what's causing this? The docker build seems to be successful.
This is my setup (Docker image on Azure ML):
Python 3.9
Cuda 11.8
Pytorch 2.0.1
GPU: Nvidia A100

Hi, I'm still having this issue, even after applying this fix. Is there any way to find out what's causing this? The docker build seems to be successful.
This is my setup (Docker image on Azure ML):
Python 3.9 Cuda 11.8 Pytorch 2.0.1 GPU: Nvidia A100

Did you use this fix? https://github.com/kcheng1021/GaussianPro/issues/8#issuecomment-1976686681

This is what it looks like (after seeing the fix here I simply pulled in the new changes you made in one of your latest commits):
    Problem problem;
    problem.ref_image_id = ref_id;

@kcheng1021 This is the docker build log, does this indicate any issues?
#13 [ 9/11] RUN cd GaussianPro/submodules/Propagation &&     cmake . &&     make
#13 0.572 CMake Deprecation Warning at CMakeLists.txt:1 (cmake_minimum_required):
#13 0.572   Compatibility with CMake < 3.5 will be removed from a future version of
#13 0.572   CMake.
#13 0.572
#13 0.572   Update the VERSION argument  value or use a ... suffix to tell
#13 0.572   CMake that the project does not need compatibility with older versions.
#13 0.572
#13 0.572
#13 0.788 -- The C compiler identification is GNU 11.4.0
#13 0.866 -- The CXX compiler identification is GNU 11.4.0
#13 0.885 -- Detecting C compiler ABI info
#13 0.954 -- Detecting C compiler ABI info - done
#13 0.967 -- Check for working C compiler: /usr/bin/cc - skipped
#13 0.968 -- Detecting C compile features
#13 0.968 -- Detecting C compile features - done
#13 0.981 -- Detecting CXX compiler ABI info
#13 1.047 -- Detecting CXX compiler ABI info - done
#13 1.057 -- Check for working CXX compiler: /usr/bin/c++ - skipped
#13 1.057 -- Detecting CXX compile features
#13 1.058 -- Detecting CXX compile features - done
#13 1.059 CMake Warning (dev) at CMakeLists.txt:4 (find_package):
#13 1.059   Policy CMP0146 is not set: The FindCUDA module is removed.  Run "cmake
#13 1.059   --help-policy CMP0146" for policy details.  Use the cmake_policy command to
#13 1.059   set the policy and suppress this warning.
#13 1.059
#13 1.059 This warning is for project developers.  Use -Wno-dev to suppress it.
#13 1.059
#13 1.073 -- Performing Test CMAKE_HAVE_LIBC_PTHREAD
#13 1.129 -- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Success
#13 1.131 -- Found Threads: TRUE
#13 1.141 -- Found CUDA: /usr/local/cuda (found suitable version "11.8", minimum required is "6.0")
#13 1.153 -- Found OpenCV: /usr (found version "4.5.4")
#13 1.335 -- Found OpenMP_C: -fopenmp (found version "4.5")
#13 1.400 -- Found OpenMP_CXX: -fopenmp (found version "4.5")
#13 1.400 -- Found OpenMP: TRUE (found version "4.5")
#13 1.405 -- Configuring done (0.8s)
#13 1.412 -- Generating done (0.0s)
#13 1.412 -- Build files have been written to: /app/GaussianPro/submodules/Propagation
#13 1.429 [ 25%] Building NVCC (Device) object CMakeFiles/Propagation.dir/Propagation_generated_Propagation.cu.o
#13 2.664 /app/GaussianPro/submodules/Propagation/Propagation.cu(329): warning #550-D: variable "cost" was set but never used
#13 2.664
#13 5.152 ptxas info    : 218048 bytes gmem, 72 bytes cmem[3]
#13 5.152 ptxas info    : Compiling entry function '_Z14RedPixelFilterPK6CameraP6float4Pf' for 'sm_86'
#13 5.152 ptxas info    : Function properties for _Z14RedPixelFilterPK6CameraP6float4Pf
#13 5.152     88 bytes stack frame, 0 bytes spill stores, 0 bytes spill loads
#13 5.152 ptxas info    : Used 29 registers, 376 bytes cmem[0]
#13 5.152 ptxas info    : Compiling entry function '_Z16BlackPixelFilterPK6CameraP6float4Pf' for 'sm_86'
#13 5.152 ptxas info    : Function properties for _Z16BlackPixelFilterPK6CameraP6float4Pf
#13 5.152     88 bytes stack frame, 0 bytes spill stores, 0 bytes spill loads
#13 5.152 ptxas info    : Used 29 registers, 376 bytes cmem[0]
#13 5.152 ptxas info    : Compiling entry function '_Z17GetDepthandNormalP6CameraP6float416PatchMatchParams' for 'sm_86'
#13 5.152 ptxas info    : Function properties for _Z17GetDepthandNormalP6CameraP6float416PatchMatchParams
#13 5.152     0 bytes stack frame, 0 bytes spill stores, 0 bytes spill loads
#13 5.152 ptxas info    : Used 21 registers, 424 bytes cmem[0]
#13 5.152 ptxas info    : Compiling entry function '_Z14RedPixelUpdateP18cudaTextureObjectsS0_P6CameraP6float4PfP17curandStateXORWOWPj16PatchMatchParamsi' for 'sm_86'
#13 5.152 ptxas info    : Function properties for _Z14RedPixelUpdateP18cudaTextureObjectsS0_P6CameraP6float4PfP17curandStateXORWOWPj16PatchMatchParamsi
#13 5.152     1856 bytes stack frame, 0 bytes spill stores, 0 bytes spill loads
#13 5.152 ptxas info    : Used 111 registers, 468 bytes cmem[0], 16 bytes cmem[2]
#13 5.152 ptxas info    : Compiling entry function '_Z16BlackPixelUpdateP18cudaTextureObjectsS0_P6CameraP6float4PfP17curandStateXORWOWPj16PatchMatchParamsi' for 'sm_86'
#13 5.152 ptxas info    : Function properties for _Z16BlackPixelUpdateP18cudaTextureObjectsS0_P6CameraP6float4PfP17curandStateXORWOWPj16PatchMatchParamsi
#13 5.152     1856 bytes stack frame, 0 bytes spill stores, 0 bytes spill loads
#13 5.152 ptxas info    : Used 111 registers, 468 bytes cmem[0], 16 bytes cmem[2]
#13 5.152 ptxas info    : Compiling entry function 'Z20RandomInitializationP18cudaTextureObjectsP6CameraP6float4PfP17curandStateXORWOWPj16PatchMatchParamsS5' for 'sm_86'
#13 5.152 ptxas info    : Function properties for Z20RandomInitializationP18cudaTextureObjectsP6CameraP6float4PfP17curandStateXORWOWPj16PatchMatchParamsS5
#13 5.152     256 bytes stack frame, 0 bytes spill stores, 0 bytes spill loads
#13 5.152 ptxas info    : Used 76 registers, 464 bytes cmem[0]
#13 7.212 [ 50%] Building CXX object CMakeFiles/Propagation.dir/Propagation.cpp.o
#13 7.865 /app/GaussianPro/submodules/Propagation/Propagation.cpp: In function ‘void StoreColorPlyFileBinaryPointCloud(const string&, const std::vector&)’:
#13 7.865 /app/GaussianPro/submodules/Propagation/Propagation.cpp:354:41: warning: format ‘%d’ expects argument of type ‘int’, but argument 3 has type ‘std::vector::size_type’ {aka ‘long unsigned int’} [-Wformat=]
#13 7.865   354 |     fprintf(outputPly, "element vertex %d\n",pc.size());
#13 7.865       |                                        ~^    ~~~~~~~~~
#13 7.865       |                                         |           |
#13 7.865       |                                         int         std::vector::size_type {aka long unsigned int}
#13 7.865       |                                        %ld
#13 7.872 /app/GaussianPro/submodules/Propagation/Propagation.cpp: In member function ‘void Propagation::CudaSpaceInitialization(const string&, const Problem&)’:
#13 7.872 /app/GaussianPro/submodules/Propagation/Propagation.cpp:503:62: warning: unused parameter ‘dense_folder’ [-Wunused-parameter]
#13 7.872   503 | void Propagation::CudaSpaceInitialization(const std::string &dense_folder, const Problem &problem)
#13 7.872       |                                           ~~~~~~~~~^~
#13 7.872 /app/GaussianPro/submodules/Propagation/Propagation.cpp:503:91: warning: unused parameter ‘problem’ [-Wunused-parameter]
#13 7.872   503 | void Propagation::CudaSpaceInitialization(const std::string &dense_folder, const Problem &problem)
#13 7.872       |                                                                            ~~~~~~~^
#13 8.121 [ 75%] Building CXX object CMakeFiles/Propagation.dir/main.cpp.o
#13 8.797 /app/GaussianPro/submodules/Propagation/main.cpp: In function ‘void ProcessProblem(const string&, const Problem&, bool, int)’:
#13 8.797 /app/GaussianPro/submodules/Propagation/main.cpp:48:9: warning: variable ‘temp’ set but not used [-Wunused-but-set-variable]
#13 8.797    48 |     int temp = pro.GetPatchSize();
#13 8.797       |         ^~
#13 9.017 [100%] Linking CXX executable Propagation
#13 9.455 [100%] Built target Propagation

It seems that there are many warnings and infos appearing that I didn't encounter during compilation. I suggest running it in the environment that we have tested.

Besides, make sure the compiled propagation is located in the path "submodule/Propagation". @rwijmashell

I still have this problem, even I have read #8.
python train.py -s $data_path -m $GP_save_path \
                --eval --flatten_loss --position_lr_init 0.000016 --scaling_lr 0.001 --percent_dense 0.0005 --port 1021 --dataset waymo \
                --sky_seg --normal_loss --depth_loss --propagation_interval 30 --depth_error_min_threshold 0.8 --depth_error_max_threshold 1.0 \
                --propagated_iteration_begin 1000 --propagated_iteration_after 12000 --patch_size 20 --lambda_l1_normal 0.001 --lambda_cos_normal 0.001

Optimizing /home/xxx/3dgs/GaussianPro/output/Waymo/GP
Output folder: /home/xxx/3dgs/GaussianPro/output/Waymo/GP [26/04 20:24:38]
Tensorboard not available: not logging progress [26/04 20:24:38]
Reading camera 198/198 [26/04 20:24:39]
Loading Training Cameras [26/04 20:24:39]
[ INFO ] Encountered quite large input images (>1.6K pixels width), rescaling to 1.6K.
 If this is not desired, please explicitly specify '--resolution/-r' as 1 [26/04 20:24:39]
Loading Test Cameras [26/04 20:25:03]
Number of points at initialisation :  72378 [26/04 20:25:07]
Training progress:   0%|                                                                                | 0/30000 [00:00<?, ?it/s]
[ITER 1] Evaluating test: L1 0.2074004739522934 PSNR 11.672923622131348 [26/04 20:25:08]

[ITER 1] Evaluating train: L1 0.23484502732753754 PSNR 10.758105468750001 [26/04 20:25:08]

[ITER 1] Saving Gaussians [26/04 20:25:08]
Training progress:   3%|███▋                                                                                | 1010/30000 [00:49<22:01, 21.94it/s, Loss=0.4038345]sh: 1: ./submodules/Propagation/Propagation: not found
Traceback (most recent call last):
  File "/home/xxx/3dgs/GaussianPro/train.py", line 372, in <module>
    training(lp.extract(args), op.extract(args), pp.extract(args), args.test_iterations, args.save_iterations, args.checkpoint_iterations, args.start_checkpoint, args.debug_from)
  File "/home/xxx/3dgs/GaussianPro/train.py", line 129, in training
    propagated_depth, cost, normal = read_propagted_depth('./cache/propagated_depth')
  File "/home/xxx/3dgs/GaussianPro/utils/general_utils.py", line 244, in read_propagted_depth
    cost = readDepthDmb(os.path.join(path, 'costs.dmb'))
  File "/home/xxx/3dgs/GaussianPro/utils/general_utils.py", line 192, in readDepthDmb
    inimage = open(file_path, "rb")
FileNotFoundError: [Errno 2] No such file or directory: './cache/propagated_depth/costs.dmb'

I have modified the code according to #8.
    std::string dense_folder = argv[1];
    int ref_id = std::stoi(argv[2]);
    std::string src_ids_str = argv[3];
    int patch_size = std::stoi(argv[4]);

    ref_id = 0;
    src_ids_str = "1 2 3 4";

    Problem problem;
    problem.ref_image_id = ref_id;

    std::stringstream ss(src_ids_str);
    std::string token;

I also notice that there is no costs.dmb.

How do I solve the problem? Thank you so much.


feat: hot change of BF_PROJECT_ID using cli

[ ] I wrote tests for the feature
[ ] I documented the feature if needed

If the feature is a refactor, please explain why your way is better

Actually, this is flawed:
Command should be called from within project dir, since models volume needs to match chosen project too.
In a multiproject set up it feels wrong to do botfront init just to get a new "project", since we only need one DB.
Maybe the solution is to have a single directory for all projects, and have the models dir contain multiple model archives.
Then we need to rejig the instance methods that train and load models.

Actually, this is flawed:
Command should be called from within project dir, since models volume needs to match chosen project too.
In a multiproject set up it feels wrong to do botfront init just to get a new "project", since we only need one DB.
Maybe the solution is to have a single directory for all projects, and have the models dir contain multiple model archives.
Then we need to rejig the instance methods that train and load models.

@znat thoughts?

@znat thoughts?

Instance methods look fine. But boot command for Rasa container makes it load latest model in models folder. Instead we could specify models/model-{BF_PROJECT_ID}.tar.gz.

Instance methods look fine. But boot command for Rasa container makes it load latest model in models folder. Instead we could specify models/model-{BF_PROJECT_ID}.tar.gz.


fix passing settings to Optimizer and add test

This wasn't working due to keyword arguments being symbols and MOI.RawOptimizerAttribute expecting strings, and the variable optimizer wasn't defined in the code.

Thank you for fixing this.


Release @google-cloud/storage v2.3.2

This pull request was generated using releasetool.

Is<EMAIL_ADDRESS>really released? I’m still using 2.3.1 and getting this error
(node:84550) UnhandledPromiseRejectionWarning: TypeError: rawResponseStream.toJSON is not a function
    at onResponse (/mycode/node_modules/@google-cloud/storage/build/src/file.js:415:51)
    at Util.handleResp (/mycode/node_modules/@google-cloud/common/build/src/util.js:123:9)
    at Duplexify.requestStream.on.on.res (/mycode/node_modules/@google-cloud/storage/build/src/file.js:392:31)
    at Duplexify.emit (events.js:182:13)
    at DestroyableTransform.emit (events.js:182:13)
    at onResponse (/mycode/node_modules/retry-request/index.js:194:19)
    at PassThrough.<anonymous> (/mycode/node_modules/retry-request/index.js:149:11)
    at PassThrough.emit (events.js:182:13)
    at /mycode/node_modules/teeny-request/build/src/index.js:186:29
    at process._tickCallback (internal/process/next_tick.js:68:7)
(node:84550) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:84550) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

The cause is that @google-cloud/storage calls the resp.toJSON() function, which was only ported over to<EMAIL_ADDRESS>(fhinkel/teeny-request@a438c7469ff82e54f5ac255b236d001d79e34f9e). The dependency from @google-cloud/storage to teeny-request was finally upgraded from 3.11.0 to 3.11.3 in 186ee32a1728551bca392bd500192c6d1c111aff which is part of<EMAIL_ADDRESS>but it doesn’t appear to be released yet.

To reiterate<EMAIL_ADDRESS>does not appear to be released to the npm registry. When I add "@google-cloud/storage": "^2.3.2", then npm install outputs this error message:
npm ERR! code ETARGET
npm ERR! notarget No matching version found for<EMAIL_ADDRESS>npm ERR! notarget In most cases you or one of your dependencies are requesting
npm ERR! notarget a package version that doesn't exist.
npm ERR! notarget


refactor(bindings): Rename crates

Description:
This is a groundwork for @swc/css and @swc/html.

@Brooooooklyn Does napi support publishing multiple node packages from single repository?

Does napi support publishing multiple node packages from single repository?

Sure, I'll send a pr tomorrow based on yours

Thank you!


Versioning protocol buffer file

We should versioning protocol buffer files

Not sure which is the best way to handle this. @davideimola  @alessandroargentieri do you like to discuss about this?

Sure I'd like to know more about kannon also


⚠ dev-deces.matchid.io search API has degraded performance

In a46e9d3, dev-deces.matchid.io search API (https://dev-deces.matchid.io/deces/api/v1/search?q=pompidou) experienced degraded performance:

HTTP code: 200
Response time: 2516 ms

Resolved: dev-deces.matchid.io search API performance has improved in 5559412.


My Twitter import account disappeared

The sha224 changes seem to have broken my Twitter importer:
...
2018/02/28 10:32:20 Scanned prefix "mediatag": 8 rows, 391.902µs
2018/02/28 10:32:21 Scanned prefix "fileinfo": 273526 rows, 999.861449ms
2018/02/28 10:32:21 Scanned prefix "exifgps": 28311 rows, 1.050391386s
2018/02/28 10:32:21 Scanned prefix "imagesize": 223194 rows, 1.501659725s
2018/02/28 10:32:22 Scanned prefix "filetimes": 248780 rows, 2.265993569s
2018/02/28 10:32:22 Scanned prefix "wholetofile": 248780 rows, 2.769272187s
2018/02/28 10:32:30 Scanned prefix "claim": 1127885 rows, 10.134403613s
2018/02/28 10:32:33 Corpus stats: 1225.628 MiB mem: 4397366 blobs (220.919 GiB) (2072008 schema (170623 permanode, 273526 file (223194 image), ...)
2018/02/28 10:32:33 Corpus scanning CPU usage: 15.708s
2018/02/28 10:32:33 Available on https://camlihouse.bradfitz.com/ui/
2018/02/28 10:32:34 Starting regular periodic import for twitter importer account, sha1-ca0cb1d176c4f4dc7c61e589e9e0edb4845fd12f
2018/02/28 10:32:34 Starting twitter importer account, sha1-ca0cb1d176c4f4dc7c61e589e9e0edb4845fd12f: @bradfitz (Brad Fitzpatrick), twitter id 650013 + zip file
2018/02/28 10:32:34 twitter importer account, sha1-ca0cb1d176c4f4dc7c61e589e9e0edb4845fd12f error: no API credentials: Ambiguous; too many permanodes matched query "attr:camliNodeType:importer attr:importerType:twitter": [[blob: sha224-c5960ec1d722b04de85ec17b1a53d763aa186c5d1d1735e39a7b518c] [blob: sha1-eac8e8b916a178b8b06ee22d2c148a328f8fae46]]
2018/02/28 10:32:34 twitter importer account, sha1-ca0cb1d176c4f4dc7c61e589e9e0edb4845fd12f ran recently enough. Sleeping for 29m59.999813792s.
2018/02/28 10:32:35 failed to long poll twitter importer account, sha1-ca0cb1d176c4f4dc7c61e589e9e0edb4845fd12f: Ambiguous; too many permanodes matched query "attr:camliNodeType:importer attr:importerType:twitter": [[blob: sha224-c5960ec1d722b04de85ec17b1a53d763aa186c5d1d1735e39a7b518c] [blob: sha1-eac8e8b916a178b8b06ee22d2c148a328f8fae46]]

Note the Ambiguous; too many permanodes matched query bit.
If I do that query with camtool:
bard:perkeep.org $ ./bin/camtool search -describe 'attr:camliNodeType:importer attr:importerType:twitter'
{
  "blobs": [
    {
      "blob": "sha224-c5960ec1d722b04de85ec17b1a53d763aa186c5d1d1735e39a7b518c"
    },
    {
      "blob": "sha1-eac8e8b916a178b8b06ee22d2c148a328f8fae46"
    }
  ],
  "description": {
    "meta": {
      "sha1-eac8e8b916a178b8b06ee22d2c148a328f8fae46": {
        "blobRef": "sha1-eac8e8b916a178b8b06ee22d2c148a328f8fae46",
        "camliType": "permanode",
        "size": 562,
        "permanode": {
          "attr": {
            "authClientID": [
              "REDACTEDxxxxxxxx"
            ],
            "authClientSecret": [
              "REDACTEDxxxxxxxx"
            ],
            "camliNodeType": [
              "importer"
            ],
            "importerType": [
              "twitter"
            ],
            "title": [
              "twitter importer"
            ]
          },
          "modtime": "2014-06-13T18:57:20.416952274Z"
        }
      },
      "sha224-c5960ec1d722b04de85ec17b1a53d763aa186c5d1d1735e39a7b518c": {
        "blobRef": "sha224-c5960ec1d722b04de85ec17b1a53d763aa186c5d1d1735e39a7b518c",
        "camliType": "permanode",
        "size": 629,
        "permanode": {
          "attr": {
            "camliNodeType": [
              "importer"
            ],
            "importerType": [
              "twitter"
            ],
            "title": [
              "twitter importer"
            ]
          },
          "modtime": "2018-02-24T04:06:07.309850807Z"
        }
      }
    }
  },
  "LocationArea": null
}

It looks like my old (sha1) one is good, and the sha224 one is not fully populated. Did something auto-create it?
I guess the query code could be changed to not fail with Ambiguous and instead select the best one of N if they're different hash functions and one is populated and the others aren't.
And maybe also fix why it created the sha224 one?

https://camlistore-review.googlesource.com/c/camlistore/+/14546

14546 fixes the problem, but need to figure out how the issue happened before closing it.

Fix for the root cause : https://camlistore-review.googlesource.com/c/camlistore/+/14567


Rename README.md to LocalREADME.md

What the program do ?

In what programming language it is written?

forking hacktoberbest


RFC: Separate typings from node-nats to node-nats-typings?

One issue with the current typings in node-nats and node-nats-streaming is that the projects are setup for Javascript. In most cases the typings definitions have been contributed. I am wondering if it would be a good thing to have a separate repos for the typings definitions. This would allow the repo to be properly setup and have at least minimal tests and samples.
Any comments from the community to this effect?

I am not sure what you mean when you say "would allow the repo to be properly setup and have at least minimal tests". I am not familiar with the node-nats-streaming repo but I was under the impression that it used the node-nats module internally. I am not sure splitting out the typings into its own repo would help with anything.

It would keep each 'language' separate with their own examples etc.

Ah, I see where you are coming from. Typescript, being an extension of javascript, allows me to simply copy and paste the javascript examples into my typescript project. The only difference comes with importing the nats module (import nats = require('nats') vs var nats = require('nats')) but that is a minimal difference. If I use typescript, I will get automatic type inferences because of the incorporated .d.ts file.
If this module were to have been written in typescript to begin with, it would work the same way. It gets a little more complicated with building/publishing but essentially the downloaded package from npm would contain a .js file and a .d.ts file.
I don't see a need for separate tests for the typings definitions.... could possible add a syntax check to the existing build procedure if you wanted to help catch some errors, but I don't think that is very necessary.
The only time where it would be beneficial to break the typings out into its own repo would be the case where the original package owner doesn't want to accept merges of typings into their own repo. This is where the DefinetlyTyped (@types) community comes in and provides alternative packages. I was able to get the owner of this package to accept my pull request of the initial .d.ts so that we didn't have to worry about the @types packages.


TypeError: must use keyword argument for key function

raceback (most recent call last):
File "/home/yutoumanman3/OpenSfM/bin/opensfm", line 34, in
command.run(args)
File "/home/yutoumanman3/OpenSfM/opensfm/commands/match_features.py", line 29, in run
pairs_matches, preport = matching.match_images(data, images, images)
File "/home/yutoumanman3/OpenSfM/opensfm/matching.py", line 41, in match_images
ref_images, cand_images, exifs, data)
File "/home/yutoumanman3/OpenSfM/opensfm/pairs_selection.py", line 209, in match_candidates_from_metadata
pairs = set([tuple(sorted(i, j)) for i in images_ref for j in images_cand])
File "/home/yutoumanman3/OpenSfM/opensfm/pairs_selection.py", line 209, in
pairs = set([tuple(sorted(i, j)) for i in images_ref for j in images_cand])
TypeError: must use keyword argument for key function

Hello,
Tanks for reporting this bug. It has been fixed on latest master.
Please note that the SfM process can possibly be super slow : your data doesn't seem to have any GPS information so the image matching will exhaustively match every possible pair.
Yann


bazzite-flatpak-manager won't work if flathub remote is not present

Describe the bug
If bazzite-flatpak-manager cannot find a flathub system remote, it won't add it automatically.
It's not a bug but maybe a missing feature.
flatpak remote-add --if-not-exists flathub https://flathub.org/repo/flathub.flatpakrepo

Is this a custom image? The other setup scripts should always add that repo.

I'm using kinoite rebased to bazzite.

Just did another test.
Deleted all programs, deleted flathub system remote and deleted flathub user remote.
Tried to run bazzite-flatpak-manager  and got this error:
Flatpak manager v17 has already ran. Exiting ...
Sometimes, I don't even get that error and it prints:
error: Remote "flathub" not found in the system installation```

but the results are the same: No system flathub remote added in both ocassions.

In both ocassions, I don't have any other option than adding flatpak system remote by myself manually.
If by some reason  ```Flatpak manager v17 has already ran. Exiting ...``` is shown: I have to do `$ sudo rm /etc/bazzite/flatpak_manager_version`. And then of course add flathub system remote manually.

Just tested the new commits. Removed all the programs, deleted all remotes (system and user), did a reboot and found out:
Flathub system remote was added and flatpaks were installing automatically. And flathub user remote was also added automatically.
Seems everything is working now. Thank you @KyleGospo

Beat me to notifying you, glad to hear it! No idea why flathub wasn't in /etc for you since we explicitly add it, but that's the nature of writable partitions, so at least those safety checks will keep things going smoothly.


Z-order with line chart

For Line charts, series-a will be rendered first, then series-b etc.
However, this makes line from series-a appear under line from series-b.
Isn't the reasonable assumption that series-a is "the most important" i.e. shouldn't it be on top?
For example, for Bar chart series-a is displayed leftmost.
Thanks!

I know this is an old post, but it's true. This becomes especially apparent when switching back and forth between a chart with a single series and a chart with 2 series (e.g. "this year's sales" / "this year's sales vs last year's sales").
One can't simply reverse the order of series provided to Chartist because then the colors also change.


⚠ ClamAV has degraded performance

In 72ee749, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 197 ms

Resolved: ClamAV performance has improved in 6f97def.


[Automated] Update eventing-kafka-broker-eventing nightly

/assign @knative/delivery-wg-leads
/cc @knative/delivery-wg-leads
Produced via:
for x in eventing-crds.yaml eventing-core.yaml; do
  curl https://storage.googleapis.com/knative-nightly/eventing/latest/$x > ${GITHUB_WORKSPACE}/./third_party/eventing-latest/$x
done

Details:

/test channel-reconciler-tests-ssl_eventing-kafka-broker_main


Mobile map (search and route) sample

Adding the Mobile Map (search and route) sample. @khajra could you please review this? Thank you!

@ryankim86 :+1:


Abdoulla lessen

- Group
- First
- Pull

Will close this PR so it doesn't create confusion. 1 PR is for 1 issue, so you can use this PR as a guide but make sure the PRs are created by the different team members and not by just 1 person :)


AMBARI-26012: Document how to report security issues

What changes were proposed in this pull request?
Add a note to the 'issue tracking' page telling people how to report security issues, so they don't use the public issue tracker for that.
How was this patch tested?
cd docs
mvn site

.. then inspect the generated site.

@raboof Thank you for your contribution.


Kotlin codegen: sealed classes for unions

Idea:
union Union {
  1: i32 Foo;
  2: i64 Bar;
  3: string Baz
}

sealed class Union {
  data class Foo(val value: Int) : Union()
  data class Bar(val value: Long) : Union()
  data class Baz(val value: string) : Union()

  class Builder {
    var foo: Int?
    var bar: Long?
    var baz: String?

    fun Foo(value: Int) = apply {
      this.foo = value
      this.bar = null
      this.baz = null
    }

    // etc

    fun build(): Union = when {
      foo != null -> Foo(foo)
      bar != null -> Bar(bar)
      baz != null -> Baz(baz)
      else -> throw AssertionError("unpossible")
    }
  }
}

Just a thought - it may make more sense to not use data classes for the leaves, and to have our own implementations for equals/hashcode/toString.  It would potentially reduce the method count imposed by this design.

As it turns out, I didn't think of this - hzsweers proposed this a few months ago.  Credit where credit is due!

A significant edge case here turns out to be empty unions.  This is a union with no data members.  As it happens, Apache Thrift supports this nonsensical construct, but Kotlin sealed classes can't represent it.  We might fall back on a regular old data class instead, or even an object, in the case where a union has no fields.

Implemented in #253, including support for empty unions.


@ScalaJSDefined classes constructor pointing to wrong ctor in base/sub classes

Its happening in fullOptJS mode only
fullOptJS :

fastOptJS :

Steps to reproduce :
js code

<script>
    "use strict";

    function _classCallCheck(instance, Constructor) { if (!(instance instanceof Constructor)) { throw new TypeError("Cannot call a class as a function"); } }

    var BaseMutation = (function () {
        function BaseMutation() {
            _classCallCheck(this, BaseMutation);
        }

        BaseMutation.prototype.checkThis = function checkThis() {
            console.log(this.constructor);
            console.log(this.constructor.fragments);
        };

        return BaseMutation;
    })();
</script>

scala code :
@js.native
class BaseMutation extends js.Object {
  def checkThis(): Unit = js.native
}

@ScalaJSDefined
class ScalaMutation extends BaseMutation

new ScalaMutation().checkThis() // check console this is referring to different constructors in two output modes

more context : https://github.com/scala-js/scala-js/issues/1902#issuecomment-146702496
Currently this is a blocker for me , i can't run relay apps in production mode! , I am happy to investigate/work on this with some pointers/guidelines ;)

cool thanks  :+1:  :clap:

yeah that was a successfull relay update(TODO) mutation in production mode :D
hoping for static fields support in 1.0 ;)


[SPARK-29462][SQL] The data type of "array()" should be array

What changes were proposed in this pull request?
This brings https://github.com/apache/spark/pull/26324 back. It was reverted basically because, firstly Hive compatibility, and the lack of investigations in other DBMSes and ANSI.

In case of PostgreSQL seems coercing NULL literal to TEXT type.
Presto seems coercing array() + array(1) -> array of int.
Hive seems  array() + array(1) -> array of strings

Given that, the design choices have been differently made for some reasons. If we pick one of both, seems coercing to array of int makes much more sense.
Another investigation was made offline internally. Seems ANSI SQL 2011, section 6.5 "" states:

If ES is specified, then let ET be the element type determined by the context in which ES appears. The declared type DT of ES is Case:
a) If ES simply contains ARRAY, then ET ARRAY[0].
b) If ES simply contains MULTISET, then ET MULTISET.
ES is effectively replaced by CAST ( ES AS DT )

From reading other related context, doing it to NullType. Given the investigation made, choosing to null seems correct, and we have a reference Presto now. Therefore, this PR proposes to bring it back.
Why are the changes needed?
When empty array is created, it should be declared as array.
Does this PR introduce any user-facing change?
Yes, array() creates array<null>. Now array(1) + array() can correctly create array(1) instead of array("1").
How was this patch tested?
Tested manually

cc @cloud-fan, @maropu, @amanomer , @gengliangwang

Test build #118151 has started for PR 27521 at commit 5b7fad9.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22913/
Test PASSed.

Test build #118153 has started for PR 27521 at commit 130f808.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22915/
Test PASSed.

Test build #118153 has finished for PR 27521 at commit 130f808.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118153/
Test FAILed.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22931/
Test PASSed.

Test build #118170 has started for PR 27521 at commit 130f808.

Test build #118151 has finished for PR 27521 at commit 5b7fad9.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118151/
Test PASSed.

Test build #118170 has finished for PR 27521 at commit 130f808.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118170/
Test PASSed.

Test build #118195 has started for PR 27521 at commit 90b4660.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22957/
Test PASSed.

Test build #118195 has finished for PR 27521 at commit 90b4660.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118195/
Test PASSed.

Thank you @maropu.
Merged to master and branch-3.0.

to be consistent, I think we should do the same thing for map. @Ngone51 can you help with it?

@cloud-fan I will raise PR for map.


pull request for e2e test at 12/20/2016 10:15:24

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Need to update the content after an AJAX call via jQuery/Javascript

Hi, great plugin by the way.
I can't seem to update the content of the editor via JQuery or Javascript, how do I do this please?
Thanks,
Kevin.

Sorry for late reply.
Do you mean that you want to change textarea directly like this?
$("textarea#wysiwyg").val("bold"); // doesn't change WYSIWYG area!

Try dev-event-change branch:
$("textarea#wysiwyg").val("bold").trigger("change"); // trigger "change" event!


Can't share Image,Link and text all together to Facebook Share

I am trying to share Image,text and link to the facebook but only image is sharing to facebook,  link and text were not posted to facebook
I am using below script,
window.plugins.socialsharing.share(
'Message',
'Title',
'https://www.google.nl/images/srpr/logo4w.png',
'http://www.myurl.com');
Please look into it,
Thank you

Dear Sir.. Can you please Look into this at the earliest..


feat(*): bump concerto, metadata versions

Closes
Bump concerto core, analysis, metadata, cto, util to latest version
Related Issues

Issue #https://github.com/accordproject/concerto/issues/643
Pull Request #https://github.com/accordproject/concerto/pull/647

Author Checklist

[x] Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
[ ] Vital features and changes captured in unit and/or integration tests
[ ] Commits messages follow AP format
[ ] Extend the documentation, if necessary
[ ] Merging to main from fork:branchname

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
202

Relevant Lines:
202

💛  - Coveralls


How to create Heads up when app in background?

Hello, I have a problem when use the instructions. I want to create Heads up when app in background but i don't know. I created it in foreground. Please help me!

At this moment the plugin doesn't support this, but you can build support by using a Custom Push Notification Handler as specified in the docs. Is this supported on all Android devices or just specific ones?
If you have any ideas on how to implement this on Android I would be glad to add some support for it on the plugin.

Just released https://www.nuget.org/packages/Plugin.FirebasePushNotification/2.1.3  a new version that supports setting the priority of the notification to achieve heads up. More information on about this and how to change the behaviour here:
https://github.com/CrossGeeks/FirebasePushNotificationPlugin/blob/master/docs/AndroidCustomization.md


Please review Blog Post - MicroProfile JWT with Keycloak

Hi everyone, I added a new blog post on microprofile.io. Could you please review it?
https://microprofile.io/wp-admin/post.php?post=6215&action=edit
Thanks
/Hayri

@cicekhayri great tutorial, you used code to show each steps, nicely done. Published, please tweet, so MP can re-tweet it :)
Can you please start adding page headers to future MP content contributions?
Why? See below, the blog is a crosspost to your website, it looks so bare on the blog header, I know you can take a screen shot of the code and be done with it, do that!
You are beyond awesome about technical knowledge transfer, YOUR MP signature as such is KUDOS! :)

Thanks @aeiras, I will add page headers to future blog posts :)


Fixing get Google default credentials method

This should fix the following error:
Traceback (most recent call last):
  File "watch-namespace.py", line 4, in <module>
    config.load_kube_config()
  File "egg/kubernetes/config/kube_config.py", line 318, in load_kube_config
  File "egg/kubernetes/config/kube_config.py", line 221, in load_and_set
  File "egg/kubernetes/config/kube_config.py", line 160, in _load_authentication
  File "egg/kubernetes/config/kube_config.py", line 176, in _load_gcp_token
  File "egg/kubernetes/config/kube_config.py", line 124, in <lambda>
NameError: global name 'GoogleCredentials' is not defined

Codecov Report

Merging #21 into master will decrease coverage by 0.5%.
The diff coverage is 55.55%.

@@            Coverage Diff             @@
##           master      #21      +/-   ##
==========================================
- Coverage   94.69%   94.19%   -0.51%
==========================================
  Files           9        9
  Lines         698      706       +8
==========================================
+ Hits          661      665       +4
- Misses         37       41       +4

Impacted Files
Coverage Δ

config/kube_config.py
94.53% <55.55%> (-2.04%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1110248...d1b1ea9. Read the comment docs.

Yes, we need to fix this.  The other fix is to run the auth-cmd directly (kubectl is doing that). I am investigating this more.

I think we need to also write token back to kube config file. Can you please fix tests so we can merge this?

I'm trying to fix tests, but I couldn't find what is wrong.
Can you help me on how to run and identify what test has failed?
Running the following:
$:~/git/python-base$ export TOXENV=update-pep8
$:~/git/python-base$ ./run_tox.sh tox
Got:
_____ summary _____
update-pep8: commands succeeded
congratulations :)

run scripts/update-pep8.sh

@gabrielgbim I sent a follow up PR for this to add expiration mechanism as well as persisting config. I will merge it after your PR. When you fixed tests here, can you review that PR?

@gabrielgbim Are you going to fix this PR or I should go ahead with my other PR?

@mbohlool You can go ahead with the other one.

@gabrielgbim then you should probably close this one.
Also it will be gret if you can test and review the other PR.
Thanks for your time.

Closing in favor of #22


First Contribution

Changes Done on Services Page:

Footer Spacing
Text placing in an proper arrangement
Image Icon introduction

All types of updates has been done!

I am Spandan | Contributor of GSSOC'23

@Anupkjha2601 please have a look to the changes

have some conflict in about.html
gallery.html
index.html
services.html
please resolve it.


add claim doesn't accept datetime value

Hello,
add claim doesn't accept any of the combinations of date formats such as 1972-12-15. Tested for P569 (date of birth).
Thanks!

this was fixed in wikidata-edit and should be fixed in wikidata-cli v5.0.0


NEON 65 - Delete by filter

Separated out delete by Id and Filter in the REST endpoints. Both use the same underlying methods other than conversion.
Added tests for all three adapters (MySQL, PostgreSQL, ES). Fixed compatibility with the new whereClause in MutateQuery.
Here are test calls:
ElasticSearch:
{
  "datastoreHost": "elastic:changeme@localhost",
  "datastoreType": "elasticsearch",
  "databaseName": "earthquakes",
  "tableName": "_doc",
  "idFieldName": "testIdField",
  "dataId": "testId",
  "whereClause": {
        "type": "where",
        "lhs": {
            "database": "earthquakes",
            "table": "_doc",
            "field": "mag"
        },
        "operator": "=",
        "rhs": 1.512345678
   }
}

SQL:
{
  "datastoreHost": "user:password@localhost/earthquakes",
  "datastoreType": "postgresql",
  "databaseName": "earthquakes",
  "tableName": "quakedata",
  "idFieldName": "id",
  "dataId": "testId",
  "whereClause": {
        "type": "where",
        "lhs": {
            "database": "earthquakes",
            "table": "quakedata",
            "field": "mag"
        },
        "operator": "=",
        "rhs": 1.512345678
   }
}

Checked deletion of data with PgAdmin and http://localhost:9200/earthquakes/_search?q=mag:1.512345678&pretty

@jacklechnercaci I'm getting build errors on ./gradlew clean build in some of the test classes.  I think it's because we added a property to MutateQuery and so the @AllArgsContructor now has an additional parameter.

@jacklechnercaci I'm getting build errors on ./gradlew clean build in some of the test classes. I think it's because we added a property to MutateQuery and so the @AllArgsContructor now has an additional parameter.

I fixed this.


Feature: job scheduler extension

Description
This is a request for an optional extension to PyWPS to delegate job execution to a batch scheduler system like Slurm, Grid Engine and Torque.
Additional Information
A prototype was already developed in PR #271 ... this PR will be refactored according to the PyWPS contribution guide lines.

Added a PR #278 for this extension. The pull request contains an update of the PyWPS documentation on how to use and enable this extension.
There is docker demo available with a PyWPS and Slurm docker container:
https://github.com/bird-house/birdhouse-playground/tree/master/docker/pywps-scheduler-demo
See also conversation on pywps mailing list:
https://lists.osgeo.org/pipermail/pywps-dev/2017-June/001098.html

I have replaced PR #278 by PR #296, which is an updated version of the scheduler extension and has a unittest for the new processing module.
The docker demo with Slurm is now here:
https://github.com/bird-house/birdhouse-docker-images/tree/master/pywps-scheduler-demo
There is also one for GridEngine:
https://github.com/bird-house/birdhouse-docker-images/tree/master/pywps-gridengine-demo

Cool stuff @cehbrecht.

PR approved and close


Phosphor support?

When you add Phosphor along side with this mod, it no longer is effective.

as per your other issue, i dont reccomend using this, and you were likely running into another issue not the one this terrible fix targets


Display HTLC summary on payment modal

Description:
Display HTLC summary on payment modal
Motivation and Context:
Provide more info about multi part payments
How Has This Been Tested?
Manually
Screenshots (if appropriate):

Types of changes:
Checklist:

[x] My code follows the code style of this project.
[x] I have reviewed and updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes where needed.
[ ] All new and existing tests passed.
[x] My commits have been squashed into a concise set of changes.

Coverage decreased (-0.08%) to 22.158% when pulling 6a828b80c1af48b88a198ece1ac9953688966d8c on mrfelton:feat/htlc-summary into 26aa5215325062e62d7087e0260ea4f2c1c73522 on LN-Zap:master.

Closed via https://github.com/LN-Zap/zap-desktop/pull/3520


Laravel package detected as HTML instead of PHP

Hello Sir, I'm a newbie to GITHUB, so please don't mind if I'm doing something wrong. Today I created an repository "https://github.com/AnandPilania/laravel-docs" and its detected as HTML instead of PHP.

This is happening because the files under resources/views/ are mostly HTML with a few yield() calls and a .php extension. If you want them to be identified as PHP, you'll need to use a manual override.

Thanks a lot


git bash terminal clears terminal on command execution

Issue Type: Bug

set integrated terminal to git bash
run any command, e.g. yarn install
terminal gets cleared, until execution is finished, nothing visible
after the excution input prompt is visible again, but not the execution result

Currently happening on 1.41/1.42-nightly and Windows 10.0.17763, but it's been the same for me since at least Windows 10.1809. Everything is fine on Windows 7 though.
Version: 1.42.0-insider (user setup)
Commit: cba31b819ea99836daf51cee56299348e9c6d20b
Date: 2020-01-08T05:39:25.874Z
Electron: 6.1.6
Chrome: 76.0.3809.146
Node.js: 12.4.0
V8: 7.6.303.31-electron.0
OS: Windows_NT x64 10.0.17763
VS Code version: Code - Insiders 1.42.0-insider (cba31b819ea99836daf51cee56299348e9c6d20b, 2020-01-08T05:39:25.874Z)
OS version: Windows_NT x64 10.0.17763

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-3470 CPU @ 3.20GHz (4 x 3193)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onoop_rasterization: disabled_offprotected_video_decode: unavailable_offrasterization: enabledskia_renderer: disabled_offsurface_control: disabled_offsurface_synchronization: enabled_onvideo_decode: enabledviz_display_compositor: enabled_onviz_hit_test_surface_layer: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
15.89GB (7.11GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions: none

Does this happen when you run the command outside of VS Code's integrated terminal?

Does this happen when you run the command outside of VS Code's integrated terminal?
Um.. Yes, it does (and it's a surprise to me). Seems to be a yarn/bash issue, not a vscode terminal.

Okay, thanks for checking. I'll close the issue as it doesn't seem to be caused by VS Code.


feat(osv): add osv support

Hello @knqyf263 !
I fixed errors after merging main branch, can you check?


Simplified build & run process to npm install and npm start

This change makes it so you only have to run npm install to install everything and npm start to run Sia-UI. This also addresses issue #41.

This is awesome! Nice job!!!!


tvplus.com.tr

Can you add tvplus.com.tr site

Please provide a link to the guide page

Post : https://izmottvsc23.tvplus.com.tr:33207/EPG/JSON/PlayBillList
post data : {"type":"2","channelid":"144","begintime":"20211104000000","endtime":"20211111235959"}
This can be found on webgrabplus site pack

The link no longer works.

POST https://izmottvsc23.tvplus.com.tr:33207/EPG/JSON/Authenticate HTTP/1.1
Accept: application/json, text/plain, /
Content-Type: application/json;charset=UTF-8
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/79.0.3945.130 Safari/537.36 Edg/79.0.309.71
Accept-Encoding: gzip,deflate,br
Host: izmottvsc23.tvplus.com.tr:33207
Content-Length: 227
Expect: 100-continue
{"terminaltype":"WEBTV_WIDEVINE","terminalvendor":"5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/90.0.4430.93 Safari/537.36","osversion":"Win32","userType":"3","utcEnable":"1","timezone":"UTC"}
Then get session id from response to use on epg request like below
POST https://izmottvsc23.tvplus.com.tr:33207/EPG/JSON/PlayBillList HTTP/1.1
Accept: application/json, text/plain, /
Content-Type: application/json;charset=UTF-8
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/79.0.3945.130 Safari/537.36 Edg/79.0.309.71
Accept-Encoding: gzip,deflate,br
Host: izmottvsc23.tvplus.com.tr:33207
Cookie: XSESSIONID=031X1A07FPS8C1RN8GYV6HYRUZU7AE3E; JSESSIONID=031X1A07FPS8C1RN8GYV6HYRUZU7AE3E
Content-Length: 86
Expect: 100-continue
{"type":"2","channelid":"177","begintime":"20211106000000","endtime":"20211113235959"}


Nuitka - issue with cvxpy

Hello,
I am facing an issue with cvxpy:

import cvxpy as cp

y = cp.Variable((1, 106), boolean=False, nonneg=True)
print(y[:1, 0])

gives me
~/sandbox/fleet-scheduling/src$ ./cvxpy_test.dist/cvxpy_test
Traceback (most recent call last):
  File "~/sandbox/fleet-scheduling/src/cvxpy_test.dist/cvxpy_test.py", line 4, in <module>
  File "~/sandbox/fleet-scheduling/src/cvxpy_test.dist/cvxpy/expressions/expression.py", line 424, in __getitem__
  File "~/sandbox/fleet-scheduling/src/cvxpy_test.dist/cvxpy/atoms/affine/index.py", line 54, in __init__
  File "~/sandbox/fleet-scheduling/src/cvxpy_test.dist/cvxpy/atoms/atom.py", line 51, in __init__
  File "~/sandbox/fleet-scheduling/src/cvxpy_test.dist/cvxpy/atoms/affine/index.py", line 80, in shape_from_args
  File "~/sandbox/fleet-scheduling/src/cvxpy_test.dist/cvxpy/utilities/key_utils.py", line 188, in shape
TypeError: unsupported operand type(s) for /: 'int' and 'NoneType'

Please check out if the develop version of Nuitka works better for you.

I am using 0.6.17, because nuitka 0.6.18 is incompatible with hinted compilation utils.

Nuitka version, full Python version and Platform (Windows, OSX, Linux ...)

python -m nuitka --version

0.6.17
Commercial: None
Python: 3.9.9 (main, Nov 16 2021, 03:08:02)
Executable: /usr/bin/python
OS: Linux
Arch: x86_64

How did you install Nuitka and Python
python -m pip install nuitka

The specific PyPI names and versions
It should be taken from this output if there specific packages involved, e.g.
numpy, you are expected to shorten this to the relevant ones.

python -m pip freeze

cvxopt==1.2.7
cvxpy==1.1.17
cylp==0.91.4
Cython==0.29.25

Any help is greatly appreciated. Thank you.

Note: Not using 0.6.18 is not acceptable for non-commercial users to get support. Any fix will be in there only.

That said, I managed to reproduce the issue on 0.6.18 indeed. I didn't find what might be going on there, I suspect there might be some data files missing. With anti-bloat plugin its relatively manageable, and it seems to not pull in too much modules, however, that package seems crapy quality:
>>> import cvxpy.utilities.key_utils
>>> cvxpy.utilities.key_utils
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
AttributeError: module 'cvxpy.reductions.utilities' has no attribute 'key_utils'

Which seems to indicate very bad code. I will defer this one until I manage to manage failed file access detections for standalone. I think by default, standalone should detect failed open, empty listdir, etc. operations and therefore make it easy to debug these, that code is a bit too hard for me to want to debug right now without that tool.

Hi @kayhayen thank you very much for your swift response. Regarding using 0.6.18, are you aware of any plans to make utils compatible with this latest version, Thank you,

There is no such plan, but Nuitka will gain superior functionality called --pgo-python. Due to anti-bloat plugin I do consider it obsolete anyway. Nobody is working on it anymore anyway.

So, I am compiling this without issues, but the runtime problem remains the originally reported one. I am checking for hidden dependencies, some modules fail to import. We got the import tracing from our "lib", that I haven't had to use in a while, but this seems pretty complex. The crash is most probably some type not registered with something numpy.

I repaired the import tracing, such that it actually allows me to compare things between the standalone build and the Python build, but I only found minor line number differences in the import chain, but modules imported and the success of it were the same, so it doesn't appear to be that. I guess, I will have to go back to the data files theory.

It's also not data files or DLLs. I started to trace values, and it's peculiar, but slice object value with a step None is causing the error, and None is the default for a slice step.
So very likely this is caused by this optimization:
        if (
            self.subnode_step.isExpressionConstantNoneRef()
            or self.subnode_step.getIndexValue() == 1
        ):
            return trace_collection.computedExpressionResult(
                wrapExpressionWithSideEffects(
                    old_node=self,
                    new_node=ExpressionBuiltinSlice2(
                        start=self.subnode_start,
                        stop=self.subnode_stop,
                        source_ref=self.source_ref,
                    ),
                    side_effects=self.subnode_step.extractSideEffects(),
                ),
                "new_expression",
                "Reduce 3 argument slice object creation to two argument form.",
            )

Thanks for your report, this is fixed on the factory branch, which is a development version under rapid development. You can try it out by going here: https://nuitka.net/doc/factory.html
Feedback if this is working is very welcome, just please do not share plans of doing it, but rather confirmations or denials of it working.

This is part of the hotfix release 1.7.4 that I just made.


drivers/pipe: Don't use shced_[lock|unlock] to do protection

Summary
since the sched lock can't work in SMP context
Impact
SMP
Testing
adb shell

@xiaoxiang781216 please fix the commit text:
Don't use shced_[lock|unlock] to do protection -> Don't use sched_[lock|unlock] to do protection

@xiaoxiang781216 please fix the commit text: Don't use shced_[lock|unlock] to do protection -> Don't use sched_[lock|unlock] to do protection

@acassis, Done.

@acassis


[Epic] Validation rules for Plugin Generation in Kiota

We need to enhance the plugin generation process in Kiota by implementing validation rules. These validations will ensure that the generated plugins function correctly.
Some of these validations address current limitations that may be resolved in the future. However, it is crucial to ensure that the generated plugins work with the current constraints.
### Tasks
- [ ] https://github.com/microsoft/Microsoft.Plugins.Manifest/issues/255
- [ ] https://github.com/microsoft/kiota/issues/5164
- [ ] https://github.com/microsoft/kiota/issues/5381
- [ ] https://github.com/microsoft/Microsoft.Plugins.Manifest/issues/259
- [ ] https://github.com/microsoft/Microsoft.Plugins.Manifest/issues/256
- [ ] https://github.com/microsoft/Microsoft.Plugins.Manifest/issues/257
- [ ] https://github.com/microsoft/kiota/issues/5380
- [ ] https://github.com/microsoft/Microsoft.Plugins.Manifest/issues/258

Requirements

Requirement 1: Validate all the above rules before generating a plugin and only generate the plugin if there are no issues.
Requirement 2: Warn the user if their OpenAPI is not valid for plugin creation and don't generate the plugin
Requirement 3: Inform the user which selected endpoints are failing validation and the specific reason. For example, one has 10 endpoints selected to create a plugin and just 1 fails due to nested objects in the PUT method; notify of the specific endpoints and the reason for the failure.

Tasks 4 Only authorization code and PKCE are supported as OAuth grant flows and 5 API Key in custom headers, query params or cookies are not supported can be resolved with https://github.com/microsoft/kiota/issues/5071

I do have a bunch of questions about those rules...

Nested objects in response or parameters in API methods are not supported

What qualifies as nested object? an inline object type definition? or are you referring to properties that are of object types in general? (e.g. assigned licenses for user in Graph)

Polymorphic references in open API spec (oneOf, allOf, anyOf) are not supported

This is how we define inheritance (entity<-directory object<- user), which would in effect rule out most API definitions out there. We need to be much more specific here.

Circular references in open API spec are not supported

Likewise we have plenty of those in Microsoft Graph. E.g. a User has a manager property which is a user... Also should we consider multiple degrees of separation? (e.g. user.memberof ->group, group.members -> user)

Only authorization code and PKCE are supported as OAuth grant flows

Providing examples  would help here.

API Key in custom headers, query params or cookies are not supported

Examples please.

Dual authentication flows (OAuth/Entra SSO + http Bearer token) for single API endpoint

Examples please.

OpenAPI descriptions needs to be 3.1.0 or previous versions

Considering 3.1.0 is not supported yet by OAI.net we should revisit this one for our current timelines.

Server url should be an absolute url with https protocol

Or in simple terms "should start with https://, case insensitive"

@maisarissi  Shall we move it from Proposed to Todo? (meaning, is it a must-have for GA?)

After talking to @darrelmiller, I've created some of those validation issues in the validation library. They were linked to this epic.
We should still check in Kiota:

The OpenAPI description version (< 3.1.0)
Circular reference for the selected paths by the user

and throw an error.
For the circular reference we should list all selected paths that are causing the error.
I'm good with moving to Todo @petrhollayms

@sebastienlevert To confirm- OpenAPI version 3.1.0 shall throw an error, given that it is not yet supported in OpenAPI.NET library, right?
Support for 3.1 https://github.com/microsoft/OpenAPI.NET/issues/795 will be released in the upcoming 2.0 version.

Absolutely.

The OpenAPI.NET throws an exception on this

Error shall be shown to the user when using 3.1

Can we have more description for

Circular references in open API spec are not supported

@darrelmiller Do we have any better description or examples? It shall not be too restrictive now, I see some risk in there.

I have no idea what is meant by Circular references are not supported.
I can imagine that if you try to create a plugin with a request payload that has a schema that is self referencing then Semantic Kernel will not be able to call that API.  That is probably because SK cannot support nested objects that contain parameters that have the same property names.  This is a bug they are planning to fix in the next sprint.

Thanks @darrelmiller , so suggesting we keep it for post-GA and re-evaluate later on based on the feedback from users.