✨  Custom Fonts

Hi, @nienow, as I said on https://github.com/nienow/sn-quill/pull/95, I would like to start contributing more to your repositories as I love Standard Notes product. I'm more a CI guy than a software developer, especially when it comes to frontend stuff, but I've hope that, with your help and guidance, I can make some good progresses.
This PR is an attempt to bring custom fonts to your Quill plugin, based on the code that you have already developed. Please take a look when you've the time and let me know what changes I must make to align it more closely with your standards.

Thanks for another contribution. It looks good, but I see one issue, where the font selection doesn't change automatically back to Sans Serif when you select plain text.

Write some text with the default Sans Serif font.
Change some of the text to Monospace
Select some of the original text that you didn't change, and the font selection still says Monospace.

If you try it on the official site, it seems to work correctly:
https://quilljs.com/playground/snow#codeN4Ig9AlgdgJgpgDwHQAsAuBbANiAXCAHhggDcACCGAXgB0Q5i0B7AJzoD4CxiT2ap+BAM4BjFhAAOaMkJYja4aPGQArIRy6jxU9iAA0i2IiRq8IEUyhDpARwCuELFjJUyUOAHcyARQdOAFADkAMQMEMwsgXpkwPxkZBhMMHZYcEK4MXHxZMxMWABGAIYsGQDaWdlkpcBkKHCF8CVVAIzRAEzRAGaFWEJwALpkAL79ehXZpYH5eTBRZIHhPRAic4F2RixY0HCBo+PxkxAYhQDmO9GBFvAAtPlYTCIA1rtjUJUHNYGdlmiBZYMjV6VPZvYZAsgSLCFERwFAzOBNQIAYSYGAkTD6ZEKbzgEmWSAJUSyaDqGDgGUCQigTA8czAYDIrHm+Ts+TuO34QwAlABuEBDIA
This isn't a big deal, so if we can't figure it out, that's ok.
Also, I see you are using Yarn, which is ok, but the "pnpm-lock.yaml" file should be updated before merging. If you don't want to use pnpm, I can update the file before merging.
I'm not too picky on coding, so its usually fine as long as it works, and doesn't mess up anyone's existing notes.

For the package manager. I was using yarn for a while, and I still like it the concept of it, but I had issues with certain projects or libraries using the "pnp" mode. And changing to the "node-modules" mode seemed like it wasn't any better than using "npm". The reason I like "pnpm" is that I have a lot of projects on my computer, and many of them use the same dependencies. pnpm only downloads a dependency once, caches it, and then uses a symbolic link in each project, so it is faster and uses less file space. It also uses the same node_modules format as npm so there is no compatibility issues.
I will look at the code changes later.

I found the default Font whitelist for quill in their code, and it is [false, 'serif', 'monospace'].
So I tried putting false as the default value in a simple example, and it seems like it solves the issue, without any of the other extra code. I was running a simple example here: https://stackblitz.com/edit/stackblitz-starters-zgrzbr?file=index.html
I wish the documentation was better, because this is not easy to figure out!
One more thing, I have the default font set to be whatever the standard notes theme is set to: font-family: var(--sn-stylekit-editor-font-family);. So maybe we make the first option say "Default" instead of "Sans Serif"?

I pushed some changes. I think the main change needed was the removing the [data-value=default] from the css selector. Then we can use "false" as the first font value, and seems to work for me. Let me know if I'm missing something.

I added the code in the enter key handle to make it keep the selected font after pressing enter, and re-upgraded to v2.
I think this is the best way, even though its not perfect.
Can you test one more time?


Switched the startertemplaterepo to enduro_mirror

enduro_mirror just looks better and offers new users better insight on how enduro.js works

Not quite sure on the reason for this failure but I was able to create a new branch and make the change, see #252


Add brief caption indicating filename for local images

I would like to see the filename for the image displayed, when local source is used.
I was able to add it by adding a line to images.push in node_helper.js, so it looks like:
images.push({
  url: `${urlPath}${dirent}`,
  caption: `File: "${dirent}"`,
});

I can do a pull request if desired.

Went ahead and committed with just caption: dirent, is that satisfactory?

Yes, that's excellent, thank you. I do tend to do more than is necessary!

@kolbyjack
Hi there, would it be possible to have the caption only be the filename?
And not as is, the full path.
i.e. Display for example "mypicture" instead of "/home/user/media/mypicture.png"


Row by row streaming

My use case involves reading data frames row by row from C++. From what I have dug so far such functionality would be difficult to build upon feather. There is no support for streaming in flattbuffers and arrow layout is column based which presumably(?) rules out efficient row by row access.
Any thoughts?

You could read (columnar) batches and then iterate through them row by row. Since pandas and R are mostly column oriented it was a reasonable tradeoff for these use cases.

Feather V2 with configurable chunk sizes and batch-based reading is coming in Arrow 0.17.0, so closing this


Add pagination metadata to the API

Create a new /pagedreplays  api to get replays with pagination information. The structure returned is outlined below. It shares the same code as /replays, with the addition of taking in a $page parameter to indicate what page should be retrieved.
{
"page": number,
"page_count": number,
"total": number,
"per_page": number
"Replays": []
}

This hasn't been tested yet, but is approximately what changes need to be made to support this. I'm going through the documentation for testing now to verify before this can be merged.

I suggest moving it to replays/paged and placing metadata in a root element (remove _metadata)
Also move ->orderBy('id') to getQuery() since it is called in both functions.

I see a couple of syntax errors here. Please check locally that this code runs without exceptions.

I haven't been able to get this running locally. I've never done php before, so bare with me if this is obvious. I tried getting running with WSL on Windows (Ubuntu) using the chef options. Highlight of the error and full dump below. I'll try running in a VM with a full Ubuntu installation once I find the time. Is there a way to just compile the PHP to catch errors? I think you can, but that's not a normal use case. A little research shows that it's possible, but I don't know how feasible.

---- Begin output of ./deploy.sh ----
STDOUT: Application is now in maintenance mode.
Already up-to-date.
[Illuminate\Database\QueryException]
SQLSTATE[HY000] [2002] No such file or directory (SQL: select * from inform
ation_schema.tables where table_schema = hotsapi and table_name = migration
s)
[Doctrine\DBAL\Driver\PDOException]
SQLSTATE[HY000] [2002] No such file or directory
[PDOException]
SQLSTATE[HY000] [2002] No such file or directory
STDERR: From https://github.com/poma/hotsapi

branch            master     -> FETCH_HEAD
Loading composer repositories with package information
Installing dependencies (including require-dev) from lock file
Nothing to install or update
Generating optimized autoload files
Illuminate\Foundation\ComposerScripts::postAutoloadDump
---- End output of ./deploy.sh ----
Ran ./deploy.sh returned 1
[2017-09-16T08:39:18+03:00] FATAL: Chef::Exceptions::ChildConvergeError: Chef run process exited unsuccessfully (exit code 1)
[2017-09-16T08:39:18+03:00] FATAL: Chef::Exceptions::ChildConvergeError: Chef run process exited unsuccessfully (exit code 1)

Full output of bootstrap.sh

/mnt/c/Users/ryzng/Source/Repos/hotsapi.chef$ sudo ./bootstrap.sh
Reading package lists... Done
Building dependency tree
Reading state information... Done
curl is already the newest version (7.47.0-1ubuntu2.2).
git is already the newest version (1:2.7.4-0ubuntu1.2).
0 upgraded, 0 newly installed, 0 to remove and 54 not upgraded.
Resolving cookbook dependencies...
Fetching 'hotsapi' from source at .
Using apt (6.1.4)
Using hotsapi (0.1.1) from source at .
Using ssh_authorized_keys (0.4.0)
Using locale (2.0.1)
Using usability (1.0.0) from https://github.com/poma/chef-usability.git (at master)
Vendoring apt (6.1.4) to ./cookbooks/apt
Vendoring hotsapi (0.1.1) to ./cookbooks/hotsapi
Vendoring locale (2.0.1) to ./cookbooks/locale
Vendoring ssh_authorized_keys (0.4.0) to ./cookbooks/ssh_authorized_keys
Vendoring usability (1.0.0) to ./cookbooks/usability
[2017-09-16T08:37:11+03:00] WARN: No config file found or specified on command line, using command line options.
Starting Chef Client, version 13.2.20
[2017-09-16T08:37:52+03:00] WARN: Plugin Network: unable to detect ipaddress
[2017-09-16T08:37:52+03:00] WARN: Plugin Network: unable to detect ipaddress
resolving cookbooks for run list: ["usability", "usability::zsh", "usability::ssh-key", "hotsapi"]
Synchronizing Cookbooks:

usability (1.0.0)
locale (2.0.1)
apt (6.1.4)
hotsapi (0.1.1)
ssh_authorized_keys (0.4.0)
Installing Cookbook Gems:
Compiling Cookbooks...
Converging 61 resources
Recipe: locale::default

execute[Generate locale] action run (skipped due to not_if)

execute[Update locale] action run (skipped due to not_if)
Recipe: apt::default

file[/var/lib/apt/periodic/update-success-stamp] action nothing (skipped due to action :nothing)

apt_update[periodic] action periodic (up to date)

execute[apt-get update] action nothing (skipped due to action :nothing)

execute[apt-get autoremove] action nothing (skipped due to action :nothing)

execute[apt-get autoclean] action nothing (skipped due to action :nothing)

directory[/var/cache/local] action create (up to date)

directory[/var/cache/local/preseeding] action create (up to date)

template[/etc/apt/apt.conf.d/10dpkg-options] action create (up to date)

template[/etc/apt/apt.conf.d/10recommends] action create (up to date)

apt_package[apt-transport-https] action install (up to date)
Recipe: usability::default

apt_package[ne] action install (up to date)

apt_package[tree] action install (up to date)

apt_package[git] action install (up to date)

apt_package[screen] action install (up to date)

apt_package[curl] action install (up to date)

apt_package[man-db] action install (up to date)

apt_package[telnet] action install (up to date)

apt_package[lsof] action install (up to date)

apt_package[zip] action install (up to date)

apt_package[unzip] action install (up to date)

apt_package[bash-completion] action install (up to date)

apt_package[traceroute] action install (up to date)

apt_package[htop] action install (up to date)

link[/etc/localtime] action create (up to date)

cookbook_file[/etc/timezone] action create (up to date)

apt_package[tzdata] action upgrade (up to date)

cookbook_file[/usr/share/ne/syntax/xml.jsf] action create (up to date)

file[/etc/update-motd.d/10-help-text] action delete (up to date)

file[/etc/update-motd.d/51-cloudguest] action delete (up to date)
Recipe: usability::zsh

apt_package[zsh] action install (up to date)

apt_package[git] action install (up to date)

git[/opt/oh-my-zsh] action sync (up to date)

git[/opt/oh-my-zsh/custom/plugins/zsh-autosuggestions] action sync (up to date)

git[/opt/oh-my-zsh/custom/plugins/zsh-syntax-highlighting] action sync (up to date)

git[/opt/oh-my-zsh/custom/plugins/zsh-completions] action sync (up to date)

template[/root/.zshrc] action create (up to date)

cookbook_file[/root/.dircolors] action create (up to date)

bash[Set vagrant's shell to zsh] action run

execute "bash"  "/tmp/chef-script20170916-71-111ncjy"
Recipe: usability::ssh-key

directory[/root/.ssh] action create (up to date)

template[/root/.ssh/authorized_keys] action create (up to date)
Recipe: hotsapi::default

apt_package[php7.0, php7.0-fpm, php7.0-mysql, php7.0-zip, php7.0-gd, mcrypt, php7.0-mcrypt, php7.0-mbstring, php7.0-xml, php7.0-curl, php7.0-json, composer, zip, unzip, nginx, memcached, php-memcached, supervisor, git] action install (up to date)

service[nginx] action nothing (skipped due to action :nothing)

service[php7.0-fpm] action nothing (skipped due to action :nothing)

execute[hotsapi-git] action run (up to date)

cookbook_file[/etc/nginx/sites-available/default] action create (up to date)

cookbook_file[/etc/nginx/nginx.conf] action create (up to date)

cookbook_file[/etc/php/7.0/fpm/pool.d/www.conf] action create (up to date)

cookbook_file[/etc/php/7.0/fpm/php.ini] action create (up to date)

cookbook_file[/etc/cron.d/laravel] action create (up to date)

template[/var/www/hotsapi/.env] action create

update content in file /var/www/hotsapi/.env from fee5b2 to 9b8475
--- /var/www/hotsapi/.env   2017-09-10 22:11:27.484366200 +0300
+++ /var/www/hotsapi/.chef-.env20170916-71-19g3014.env      2017-09-16 08:38:10.621811100 +0300
@@ -3,8 +3,8 @@
APP_ENV=local
APP_DEBUG=true
APP_LOG_LEVEL=debug
-AWS_KEY=
-AWS_SECRET=
+AWS_KEY={redacted}
+AWS_SECRET={redacted}
AWS_REGION=eu-west-1
AWS_BUCKET=hotsapi-test
DB_HOST=localhost

execute[hotsapi-deploy-script] action run
[execute] Application is now in maintenance mode.
From https://github.com/poma/hotsapi
* branch            master     -> FETCH_HEAD
Already up-to-date.
Loading composer repositories with package information
Installing dependencies (including require-dev) from lock file
Nothing to install or update
Generating optimized autoload files
> Illuminate\Foundation\ComposerScripts::postAutoloadDump
        [Illuminate\Database\QueryException]
        SQLSTATE[HY000] [2002] No such file or directory (SQL: select * from inform
        ation_schema.tables where table_schema = hotsapi and table_name = migration
        s)

        [Doctrine\DBAL\Driver\PDOException]
        SQLSTATE[HY000] [2002] No such file or directory

        [PDOException]
        SQLSTATE[HY000] [2002] No such file or directory

================================================================================
Error executing action run on resource 'execute[hotsapi-deploy-script]'
Mixlib::ShellOut::ShellCommandFailed
Expected process to exit with [0], but received '1'
---- Begin output of ./deploy.sh ----
STDOUT: Application is now in maintenance mode.
Already up-to-date.
[Illuminate\Database\QueryException]
SQLSTATE[HY000] [2002] No such file or directory (SQL: select * from inform
ation_schema.tables where table_schema = hotsapi and table_name = migration
s)
[Doctrine\DBAL\Driver\PDOException]
SQLSTATE[HY000] [2002] No such file or directory
[PDOException]
SQLSTATE[HY000] [2002] No such file or directory
STDERR: From https://github.com/poma/hotsapi

branch            master     -> FETCH_HEAD
Loading composer repositories with package information
Installing dependencies (including require-dev) from lock file
Nothing to install or update
Generating optimized autoload files

Illuminate\Foundation\ComposerScripts::postAutoloadDump
---- End output of ./deploy.sh ----
Ran ./deploy.sh returned 1

Resource Declaration:
In /home/ryzngard/.chef/local-mode-cache/cache/cookbooks/hotsapi/recipes/default.rb
44: execute "hotsapi-deploy-script" do
45:   cwd "/var/www/hotsapi"
46:   command "./deploy.sh"
47:   live_stream true
48: end
49:
Compiled Resource:
Declared in /home/ryzngard/.chef/local-mode-cache/cache/cookbooks/hotsapi/recipes/default.rb:44:in `from_file'
execute("hotsapi-deploy-script") do
action [:run]
default_guard_interpreter :execute
command "./deploy.sh"
backup 5
cwd "/var/www/hotsapi"
returns 0
user nil
live_stream true
declared_type :execute
cookbook_name "hotsapi"
recipe_name "default"
domain nil
end
System Info:
chef_version=13.2.20
platform=ubuntu
platform_version=16.04
ruby=ruby 2.4.1p111 (2017-03-22 revision 58053) [x86_64-linux]
program_name=chef-client worker: ppid=66;start=08:37:16;
executable=/opt/chefdk/bin/chef-client

Running handlers:
[2017-09-16T08:39:18+03:00] ERROR: Running exception handlers
[2017-09-16T08:39:18+03:00] ERROR: Running exception handlers
Running handlers complete
[2017-09-16T08:39:18+03:00] ERROR: Exception handlers complete
[2017-09-16T08:39:18+03:00] ERROR: Exception handlers complete
Chef Client failed. 2 resources updated in 02 minutes 01 seconds
[2017-09-16T08:39:18+03:00] FATAL: Stacktrace dumped to /home/ryzngard/.chef/local-mode-cache/cache/chef-stacktrace.out
[2017-09-16T08:39:18+03:00] FATAL: Stacktrace dumped to /home/ryzngard/.chef/local-mode-cache/cache/chef-stacktrace.out
[2017-09-16T08:39:18+03:00] FATAL: Please provide the contents of the stacktrace.out file if you file a bug report
[2017-09-16T08:39:18+03:00] FATAL: Please provide the contents of the stacktrace.out file if you file a bug report
[2017-09-16T08:39:18+03:00] ERROR: execute[hotsapi-deploy-script] (hotsapi::default line 44) had an error: Mixlib::ShellOut::ShellCommandFailed: Expected process to exit with [0], but received '1'
---- Begin output of ./deploy.sh ----
STDOUT: Application is now in maintenance mode.
Already up-to-date.
[Illuminate\Database\QueryException]
SQLSTATE[HY000] [2002] No such file or directory (SQL: select * from inform
ation_schema.tables where table_schema = hotsapi and table_name = migration
s)
[Doctrine\DBAL\Driver\PDOException]
SQLSTATE[HY000] [2002] No such file or directory
[PDOException]
SQLSTATE[HY000] [2002] No such file or directory
STDERR: From https://github.com/poma/hotsapi

branch            master     -> FETCH_HEAD
Loading composer repositories with package information
Installing dependencies (including require-dev) from lock file
Nothing to install or update
Generating optimized autoload files

Illuminate\Foundation\ComposerScripts::postAutoloadDump
---- End output of ./deploy.sh ----
Ran ./deploy.sh returned 1
[2017-09-16T08:39:18+03:00] ERROR: execute[hotsapi-deploy-script] (hotsapi::default line 44) had an error: Mixlib::ShellOut::ShellCommandFailed: Expected process to exit with [0], but received '1'
---- Begin output of ./deploy.sh ----
STDOUT: Application is now in maintenance mode.
Already up-to-date.

[Illuminate\Database\QueryException]
SQLSTATE[HY000] [2002] No such file or directory (SQL: select * from inform
ation_schema.tables where table_schema = hotsapi and table_name = migration
s)
[Doctrine\DBAL\Driver\PDOException]
SQLSTATE[HY000] [2002] No such file or directory
[PDOException]
SQLSTATE[HY000] [2002] No such file or directory
STDERR: From https://github.com/poma/hotsapi

branch            master     -> FETCH_HEAD
Loading composer repositories with package information
Installing dependencies (including require-dev) from lock file
Nothing to install or update
Generating optimized autoload files

Illuminate\Foundation\ComposerScripts::postAutoloadDump
---- End output of ./deploy.sh ----
Ran ./deploy.sh returned 1
[2017-09-16T08:39:18+03:00] FATAL: Chef::Exceptions::ChildConvergeError: Chef run process exited unsuccessfully (exit code 1)
[2017-09-16T08:39:18+03:00] FATAL: Chef::Exceptions::ChildConvergeError: Chef run process exited unsuccessfully (exit code 1)

Looks like you didn't configure mysql db. Chef doesn't do it because DB_is external to the web server. Tro to install mysql-server first and provide credentials in chef.json. Probably I should include an option to install and configure a testing mysql server in chef recipe.

By the way if you use WSL you'll probably have issues with listening on port 80. If that's the case change port in /etc/nginx/sites-available/default

I've updated hotsapi.chef to configure mysql-server and create default DB. It also automatically generates new APP_KEY now.

Thanks for all the help! I have at least the site up and running, after a few hours of figuring out how vagrant/homestead work. As expected, there are errors, but at least I now have the environment set up and can look into them. I'm out for work for a few days, but I'll update the PR when I get back and fix the issues

Manually fixed errors and merged in dfabdef8ef1ea57d97970945e138753f93b48a18


SignalR for Android caused the thread counts increasing when I try to reconnect.

Describe the bug
I used the SignalR in my application , and I find my thread counts keeps increasing if I try to reconnect the server when the signalR is disconnected , it won't go down . It leads to a problem that " java.lang.OutOfMemoryError: pthread_create (1040KB stack) failed: Out of memory"  when the thread counts reaches the max number of thread on the phone.
To Reproduce
//check state
private static void checkSingnalRState() {
new Thread(new Runnable() {
@Override
public void run() {
try {
while (isCheckState) {
String state = hubConnection.getConnectionState().toString();
if (state.equals("CONNECTED")) {
                    } else {
                        if (hubConnection != null) {
                            startConnection();
                        }
                    }
                    Thread.sleep(checkConnectStatemillis);
                }
            } catch (InterruptedException e) {
                e.printStackTrace();
            }
        }
    }).start();
}

private static HandlerThread startConnectionHandlerThread = null;
private static Handler startConnectionHandler = null;
private static boolean isStarting = false;
//connect to the signalR
private static void startConnection() {
    if (isStarting) {
        return;
    }
    isStarting=true;
    if (startConnectionHandlerThread == null) {
        startConnectionHandlerThread = new HandlerThread("startConnection");
        startConnectionHandlerThread.start();
    }
    if (startConnectionHandler == null) {
        startConnectionHandler = new Handler(startConnectionHandlerThread.getLooper()) {
            @Override
            public void handleMessage(Message msg) {
                super.handleMessage(msg);
                if (hubConnection != null) {
                    hubConnection.start().subscribe(new Action() {
                        @Override
                        public void run() throws Exception {
                            isStarting=false;
                        }

                    }, new Consumer<Throwable>() {
                        @Override
                        public void accept(Throwable throwable) throws Exception {
							isStarting=false;
                        }
                    }).dispose();
                }

            }

        };
    }

    startConnectionHandler.sendEmptyMessage(0);

}

Exceptions (if any)
" java.lang.OutOfMemoryError: pthread_create (1040KB stack) failed: Out of memory"
Further technical details

Your Azure SignalR SDK version
Your Server ASPNETCORE version or Assembly version of Microsoft.AspNetCore.SignalR ：<IP_ADDRESS>
Your SignalR Client SDK version : signalr:3.1.5

The hubConnection in this class will always reconnect once it's disconnected.
So if you instantiate the class more and more, you will get more and more connections.
I wonder whether you stop and dispose the unused connections.
Could you double check if you have the pattern described above?

The hubConnection in this class will always reconnect once it's disconnected.
So if you instantiate the class more and more, you will get more and more connections.
I wonder whether you stop and dispose the unused connections.
Could you double check if you have the pattern described above?

Thanks ! I do't find the method of reconnection in HubConnection.java , so I do it  myself . I will have a test without my reconnection code .

The hubConnection in this class will always reconnect once it's disconnected.
So if you instantiate the class more and more, you will get more and more connections.
I wonder whether you stop and dispose the unused connections.
Could you double check if you have the pattern described above?

I had a test without my reconnection code . I received the close event when I closed my internet . I found that it didn't automatically reconnect when I restart my internet .

What about the OutOfMemoryError problem? Is it mitigated?

What about the OutOfMemoryError problem? Is it mitigated

Yes , it's mitigated .

The OutOfMemoryError problem is mitigated  after I  removed my reconnection code . But , I can't get the state "CONNECTED"  again if  I received the close event .  How can I connect to the server again ?

I think you can reconnect, but you need to control the count of total connection. e.g. The simplest way to do it is to stop/dispose the hub connection in the destroctor.

You should just be able to call start on the connection again after it is closed.

Thanks for your solutions .  I will try to record the count of my restart count .Then release and recreate the hubconnection when the count  reaches the preset number .  Hope it works !


proposing myself as an approver and a reviewer to the project

Signed-off-by: Batuhan Apaydın<EMAIL_ADDRESS>
What type of PR is this?

/kind documentation

Any specific area of the project related to this PR?
I'm proposing myself as an approver and a reviewer to the project

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign keisukeyamashita after the PR has been reviewed.
You can assign the PR to them by writing /assign @keisukeyamashita in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@developer-guy: There is not a label identifying the kind of this PR.
Please specify it either using /kind <group> or manually from the side menu.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

The following users are mentioned in OWNERS file(s) but are untrusted for the following reasons. One way to make the user trusted is to add them as members of the falcosecurity org. You can then trigger verification by writing /verify-owners in a comment.

developer-guy

User is not a member of the org. Satisfy at least one of these conditions to make the user trusted.
OWNERS

/assign @Issif

I'm OK for my side. For following our procedures, we need to discuss about this in next community call.

LGTM label has been added.  Git tree hash: 7911e20a5a07b53bbdbb027dd96891d673d0ee15

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: leogr
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

🥳
Welcome 👏

Thank you so much, really appreciate it 🥳

/verify-owners


Compile error in LiteOntologyImporter

Hi,
I get a compile error on line 161 of "public class LiteOntologyImporter" .
Error:
(The method getName() is undefined for the type RDFFormat)
the line in question:
if (parser.getName().equals(format))
I havent had time to look into this....
kind regards,
Black

I cannot reproduce this behavior, gitsharp :(
Can you provide more details?
Also, have you pulled the last commited changes?
Cheers,
JB.

Hi Jesús Barrasa,
Thanks for the code.. I was wasn't building with maven but in eclipse by hand. I missed a few libraries it seems. I have noticed though that in the pom.xml you did not specify "aduna-commons-lang-2.2.jar" and a few more from sesame.rio was needed to compile.
kind regards, Black

Hi Jesús,
Thanks, It works now. I had installed a neo instance on a Linux system. In windows the plugins were just not detected....
kind regards, Black

Great stuff, Black.
I'll close the issue then.
Cheers,
JB.


How do I use this?

Possibly related to #1
This looks very interesting! But I don't see how it's supposed to be used. The example html references js/erdiagram.min.js and #1 mentions it's a generated file, but it's not there on npm: https://www.npmjs.com/package/entity-relationship-diagram?activeTab=code
Maybe the project needs to be bundled before (re-)publishing to npm?
(Also, I noticed npm is listed as a dependency - is that a mistake?)
I imagine the rest wouldn't be too hard to figure out but if there's a guide somewhere I'd be keen to read it (i.e. what happens when we reference the erdiagram.min.js script, what global variables are set, etc.)

I must have made a mistake when publishing to npm, I am definitely not an expert in the Node world. Internally, we pull, compile and publish the project directly from the repository.
I don't think I have a guide yet, but you can take at a real-world setup as an example. The entities and relationships are defined in a separate file, which exports the variable EntityRelationshipGraph . This is the only global variable used.


proposal: CephFS snapshots as shallow RO volumes

This PR adds a proposal document for 'CephFS snapshots as shallow read-only volumes' feature.
Related issue: https://github.com/ceph/ceph-csi/issues/2142

This looks well thought out :+1:
Obviously the reference counting is the most important factor for this. It would be the main part where the complexity needs to be handled. I am not sure the additional complexity is worth the benefits.
Would this be something that will be used a lot in certain type of workloads? The use-cases in the document are very clear, but I would like to know more about the actual applications and increase of performance (why is it needed, or is it just nice to have?) for these.

@nixpanic I'm discussing this proposal with Kubernetes Data Protection WG still. I'll try to give more concrete examples soon.

And just to make it clear, I wouldn't be trying to solve the "multi-master race". At least not as a part of this proposal anyway. There are a few other places in the driver where this is a problem too, no? Or at least I remember reading something along these lines... It would be nice if we could solve it for all these cases at once.

@gman0  The  proposal looks good to me :+1:   the shallow RO volume mount for an export make sense to transfer a backup to external source.  One caveat here is fitting this workflow on  data protection w efforts in general which you already taken into account and figuring out .

@nixpanic after checking with Data Protection WG, @xing-yang, this proposal should fit in nicely with the planned Volume backup feature - which itself is a part of bigger Application backup feature. It's desirable for a CSI driver to be able to create volumes from snapshots efficiently. All the heavy I/O would be done only when copying the data to the backup/archive storage. This is as opposed to having to create a clone of the snapshot just so that it can be read from when transferring to backup storage. Depending on the amount of data and current load on the Ceph cluster, the increase in performance may be significant.
Right now this is usable with Velero/Restic. We're planning to use this for regular volume/app backups for our users. Later, I'd like to propose to Velero folks to include "volume from snapshot" as an intermediate step when performing volume backups using their CSI plugin.

I've squashed commits for fixing markdown linter errors and added a line saying that solving the race condition for when there are multiple controller plugins running concurrently is out of scope for this proposal. Commit lint is still complaining though, something about subject being empty. I'm not sure what's up with that.

@nixpanic does this seem reasonable to you?

Is there anything else needed for this PR? @Madhu-1 @ShyamsundarR @humblec PTAL

commitlint is failing as the commit description is not present. https://github.com/ceph/ceph-csi/blob/devel/docs/development-guide.md#commit-messages

Busy with some work, I will revisit this soon. Thanks, @gman0

@Madhu-1 thanks. I can squash the commits that fix the linter errors with the original commit later when we're done with reviews. That should satisfy commitlint too I hope.

Any updates on reviews on this PR please?

I think I've addressed the comments we had so far, PTAL.

@Madhu-1 thanks! Commits squashed and all CI jobs have passed.

@humblec @nixpanic PTAL

Later, I'd like to propose to Velero folks to include "volume from snapshot" as an intermediate step when performing volume backups using their CSI plugin.

@gman0 I think that proposal exists: https://github.com/vmware-tanzu/velero/issues/3544

@haslersn great, I wasn't aware of this. Thank you for letting us know!

@nixpanic @humblec @ShyamsundarR any updates on this proposal? I guess we can always update it later if we need to.

@nixpanic @humblec @ShyamsundarR any updates on this proposal? I guess we can always update it later if we need to.

@gman0  Apologies. Will take a final look at this tomorrow without fail..

Thanks, @Madhu-1 ! Squashing changes.

@humblec @nixpanic any more comments on this PR? Can we get this merged?


improved text interface client

fixes
This PR kind of fixes #207.
checklist

[ ] Make sure you read and understood the CONTRIBUTING.md.
[ ] Make sure you applied sufficient labels, milestone and assignee.
[ ] Make sure all TODOs are addressed.
[ ] Make sure there is sufficient documentation.
[ ] Make sure there are sufficient tests.
[ ] Make sure all commits are squashed before merging.
[ ] Make sure to delete the feature branch after merging.

Current coverage is 96.43% (diff: 100%)

Merging #209 into master will not change coverage

Powered by Codecov. Last update bbbe689...857f86a

LGTM


Request for Paper Update for 3D generation

Our research group in NUS just released a paper to generate 3D objects from image via proposing a new 3D representation.
Title: X-Ray: A Sequential 3D Representation for Generation
Paper: https://arxiv.org/abs/2404.14329
Project page: https://tau-yihouxiang.github.io/projects/X-Ray/X-Ray.html
Code: https://github.com/tau-yihouxiang/X-Ray
Thank you for updating the list!

added


Add env vars support to Pyfunc ensembler

In PR #164, PR #165, PR #170, PR #171, and PR #174 an automated pyfunc ensembler building feature was introduced for Turing. However, the existing implementation lacked support for passing environment variables specified by the user to the running pyfunc ensembler service in its container.
This PR introduces support for the aforementioned feature, by adding an extra env field to the EnsemblerPyfuncConfig/pyfuncConfig/pyfunc_config struct/model/schema used in Turing API/UI/SDK. Turing API/UI/SDK has also been correspondingly updated to allow users to specify the new field when deploying/viewing routers with pyfunc ensemblers.
Additions

api/api* - Changes to the OpenAPI specs from the addition of the new env field
api/turing/models/ensembler.go - Addition of the new env field to EnsemblerPyfuncConfig
api/turing/service/router_deployment_service.go - Slight changes to the buildEnsemblerServiceImage to store env as part of an EnsemblerDockerConfig
ui/src/router/components/configuration/components/pyfunc_config_section/PyFuncConfigViewGroup.js - Addition of a new field to display environment variables in the configuration details panel
ui/src/router/components/form/components/pyfunc_config/PyFuncConfigFormGroup.js - Addition of a new field for users to input environment variables when configuring Pyfunc ensemblers as part of a router deployment
ui/src/services/ensembler/PyFuncEnsembler.js - Addition of the new env field to PyFuncEnsembler
sdk/turing/generated/model/ensembler_pyfunc_config.py - Changes to the OpenAPI autogenerated class corresponding to the pyfunc ensembler configuration
sdk/turing/router/config/router_ensembler_config.py - Addition of the new env field to pyfunc_config

Thanks for the comments @krithika369 ! FYI, I'm also going to bring in the tiny little refactoring commit from the SDK minor release into this PR :) I'll be merging this if the pipeline passes 🚀


Fix description of exp parameter in JWT token claims

Fix description of exp parameter in JWT token claims

@navyasric,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@priyamohanram Please review these proposed changes. Thanks.

@navyasric - thanks very much for catching this and contributing!
@jmolnar - @priyamohanram is on extended OOF, so I'd like to #sign-off on this one on her behalf.
Thanks,
Bryan

@MicrosoftDocs/apex-docs-pr-reviewers - FYI as jomolnar no longer appears to be in the review team.

Per @BryanLa
#sign-off


Use AJAX to reload Edit and Delete Package pages

Currently the Edit Package and Delete Package pages reload the page each time a new version is selected. It would be better instead to reload the pages' content on the client side using AJAX.

It doesn't reload the page anymore..


Allow stripping "a" tags

Currently it's very difficult (if not impossible) to use djangoembed with
any markup format. I'm using restructured text, with the same goes for
textile, markdown, etc.
The big problem is that in markup rich text all links are enclosed in a "a"
element, so djangoembed never changes those links.
It would be great if I could set OEMBED_STRIP_LINKS=True or something
like that in django settings.
I have played a bit with the code and could send a patch or pull request
for this, but I'm not very confident with my proposal. Maybe there's a
better way to get this working?

Yeah, this is a tricky one... I use markdown on my blog (ew, which i would've used ReST to begin with), so I do blog.entry|markdown|oembed ... but i can see how using something that automatically links things would make this hard.  It might be possible to modify the beautifulsoup parser to, if inside an A tag, go up the DOM and replace out the whole thing.

Yes, in my experiment I do just that, but don't understand the template_dir = 'inline' part of HTMLParser.parse_data, so I'm not very confident with my code.


Fix to the density conversions in the .json file

Thanks!
I double checked the changes and look good, but I also glanced through the rest and found this. Can you check and correct if you agree?
"SingularName": "PoundPerCubicInch",
"PluralName": "PoundsPerCubicInch",
"FromUnitToBaseFunc": "x*27679.904710191",
"FromBaseToUnitFunc": "x/27679.904710191",

Google gives 1 kg / m³ = 3.61273e-5 lb/in³
unitjuggler.com gives 3.6127298147753E-5 lb/in3

1/3.61273e-5 = 27679.904710191. So at that point it is just semantics.

I have updated the density.JSON file to follow consistent conversion styling (e.g. always multiply for FromBaseToUnit and divide for FromUnitToBase). I'm not a computer with Powershell 3, so I couldn't run the code generator.

You are absolutely right, I missed that. I suppose it should go into the guidelines what form is the convention.

Nuget 3.38.1 out.


feat: Fake hook support parameter conn_id and fetch result

support pass parameter conn_id to base hook, and fetch correct the result fetch from parameter

Codecov Report
Patch coverage has no change and project coverage change: -0.97 :warning:

Comparison is base (3f8871b) 60.81% compared to head (58c631d) 59.85%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #78      +/-   ##
==========================================
- Coverage   60.81%   59.85%   -0.97%
==========================================
  Files          18       18
  Lines         684      695      +11
==========================================
  Hits          416      416
- Misses        268      279      +11

Flag
Coverage Δ

unittests
59.85% <0.00%> (-0.97%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

src/air2phin/fake/core/hook.py
0.00% <0.00%> (ø)

src/air2phin/fake/hooks/mysql.py
0.00% <0.00%> (ø)

src/air2phin/fake/hooks/postgres.py
0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


New version: Flatten v0.3.4

Registering package: Flatten
Repository: https://github.com/rafaqz/Flatten.jl
Created by: @rafaqz
Version: v0.3.4
Commit: 0721fa822f18decc01cf648debdf022961e37dee
Reviewed by: @rafaqz
Reference: https://github.com/rafaqz/Flatten.jl/commit/0721fa822f18decc01cf648debdf022961e37dee#commitcomment-39401690

Superseded by #15293


I do not know why

ResourceExhaustedError: OOM when allocating tensor with shape[5776,500002] and type float on /job:localhost/replica:0/task:0/device:GPU:0 by allocator GPU_0_bfc

I also have no idea :(
My setup is:
./native_client/deepspeech -h
Usage: ./native_client/deepspeech --model MODEL --alphabet ALPHABET [--lm LM --trie TRIE] --audio AUDIO [-t]

Running DeepSpeech inference.

	--model MODEL		Path to the model (protocol buffer binary file)
	--alphabet ALPHABET	Path to the configuration file specifying the alphabet used by the network
	--lm LM			Path to the language model binary file
	--trie TRIE		Path to the language model trie file created with native_client/generate_trie
	--audio AUDIO		Path to the audio file to run (WAV format)
	-t			Run in benchmark mode, output mfcc & inference time
	--help			Show help
	--version		Print version and exits
TensorFlow: v1.6.0-18-g5021473
DeepSpeech: v0.2.0-alpha.7-10-gea21010

Your tensor is too large, and the GPU has not enough memory.
I guess 500,002 is your vocab size, it's too large. You can try to reduce the size and try again.

thanks


Showing without pressing button

Hello. How can I show this without pressing a button in the first page? Actually I wrote   self.alertView.show() in viewDidLoad() but it does not work. I would appreciate it if you could help me to do it.

If you want to show the AlertOnboarding view without clicking on the button, put self.alertView.show() in viewWillAppear() or viewDidAppear(). It should work.

Hi. Thank you so much for your helping. It works properly.

I also encountered this issue; thanks for the clarification. However, only calling show() from viewDidAppear worked - presumably because the show() function requires the top view controller to be in the view hierarchy before it can get it?


Can't reproduce XR-Transformer Neurips results

Trying to reproduce XR-Transformer results gives me the following error during training and predicting:
02/17/2023 08:39:04 - INFO - __main__ - Setting random seed 0
Traceback (most recent call last):
  File "/usr/lib/python3.8/runpy.py", line 194, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/usr/lib/python3.8/runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "/home/celso/projects/venvs/pecos/lib/python3.8/site-packages/pecos/xmc/xtransformer/train.py", line 582, in <module>
    do_train(args)
  File "/home/celso/projects/venvs/pecos/lib/python3.8/site-packages/pecos/xmc/xtransformer/train.py", line 495, in do_train
    X_trn = smat_util.load_matrix(args.trn_feat_path, dtype=np.float32)
  File "/home/celso/projects/venvs/pecos/lib/python3.8/site-packages/pecos/utils/smat_util.py", line 117, in load_matrix
    mat = np.load(src)
  File "/home/celso/projects/venvs/pecos/lib/python3.8/site-packages/numpy/lib/npyio.py", line 407, in load
    fid = stack.enter_context(open(os_fspath(file), "rb"))
FileNotFoundError: [Errno 2] No such file or directory: './xmc-base/wiki10-31k//tfidf-attnxml/X.trn.npz'
Traceback (most recent call last):
  File "/usr/lib/python3.8/runpy.py", line 194, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/usr/lib/python3.8/runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "/home/celso/projects/venvs/pecos/lib/python3.8/site-packages/pecos/xmc/xtransformer/predict.py", line 176, in <module>
    do_predict(args)
  File "/home/celso/projects/venvs/pecos/lib/python3.8/site-packages/pecos/xmc/xtransformer/predict.py", line 145, in do_predict
    xtf = XTransformer.load(args.model_folder)
  File "/home/celso/projects/venvs/pecos/lib/python3.8/site-packages/pecos/xmc/xtransformer/model.py", line 195, in load
    text_encoder = TransformerMatcher.load(os.path.join(load_dir, "text_encoder"))
  File "/home/celso/projects/venvs/pecos/lib/python3.8/site-packages/pecos/xmc/xtransformer/matcher.py", line 359, in load
    raise ValueError(f"text_encoder does not exist at {encoder_dir}")
ValueError: text_encoder does not exist at models/wiki10-31k/bert/text_encoder/text_encoder
Traceback (most recent call last):
  File "/usr/lib/python3.8/runpy.py", line 194, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/usr/lib/python3.8/runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "/home/celso/projects/venvs/pecos/lib/python3.8/site-packages/pecos/xmc/xlinear/evaluate.py", line 72, in <module>
    do_evaluation(args)
  File "/home/celso/projects/venvs/pecos/lib/python3.8/site-packages/pecos/xmc/xlinear/evaluate.py", line 62, in do_evaluation
    Y_true = smat_util.load_matrix(args.truth_path).tocsr()
  File "/home/celso/projects/venvs/pecos/lib/python3.8/site-packages/pecos/utils/smat_util.py", line 117, in load_matrix
    mat = np.load(src)
  File "/home/celso/projects/venvs/pecos/lib/python3.8/site-packages/numpy/lib/npyio.py", line 407, in load
    fid = stack.enter_context(open(os_fspath(file), "rb"))
FileNotFoundError: [Errno 2] No such file or directory: './xmc-base/wiki10-31k//Y.tst.npz'
Traceback (most recent call last):
  File "ensemble_evaluate.py", line 58, in <module>
    do_evaluation(args)
  File "ensemble_evaluate.py", line 49, in do_evaluation
    Y_true = sorted_csr(load_matrix(args.truth_path).tocsr())
  File "/home/celso/projects/venvs/pecos/lib/python3.8/site-packages/pecos/utils/smat_util.py", line 117, in load_matrix
    mat = np.load(src)
  File "/home/celso/projects/venvs/pecos/lib/python3.8/site-packages/numpy/lib/npyio.py", line 407, in load
    fid = stack.enter_context(open(os_fspath(file), "rb"))
FileNotFoundError: [Errno 2] No such file or directory: './xmc-base/wiki10-31k//Y.tst.npz'

The error indicates you don't have the dataset ready. Please follow the instructions in the README to download the dataset first.

Sorry, I had already downloaded the dataset, but it was stored on a different server for some reason.


Add option to automatically delete old blog entries

Some users don't want to store all blog entries ever loaded from the blog.
So allow an option to delete older entries after a certain amount of time.

done


spawn-command-with-kill, ps-tree and event-stream is not safe

See:
indexzero/ps-tree#33
dominictarr/event-stream#116
When I run npm audit in my repo I get this message:
Malicious Package : nps > spawn-command-with-kill > ps-tree > event-stream > flatmap-stream

I have opened a pull request: https://github.com/kentcdodds/spawn-command-with-kill/pull/2 in spawn-command-with-kill.

Can someone merge the PR ? pleaseeeee

Merged... Wasn't flatmap-stream removed? The current version range for ps-tree should pick up the latest.... I don't see why this is necessary at all...

But why? The version range that's already been published should include the fixed version. There is no longer a threat.

@kentcdodds You're right, it's not a treat now, but having the updated version of ps-tree is positive anyways. BTW: You may wanna add the range hat back on the version. I did not add it.


Added new authentication database structure

Added new authentication database structure to auth.sql.
You can find a visualisation of the structure here: https://i.imgur.com/A3Hw4qe.png

It's a bit unusual to have table names in plural

It's a bit unusual to have table names in plural

Shouldn't be a problem to change to singular if everyone approves. Would love to hear a second opinion about this before changing it though.

👍 To provide some concrete reasoning:

while accounts might make more sense than account, this is not so obvious for tables that represent relationships instead of objects. even in your example there is an inconsistency between the pluralization in rbac_groups_rights x rbac_role_rights
when you keep table names singular, things can be done mechanically: foreign keys can always be {tablename}_id, for example
point 2 becomes especially relevant when you need to bring in an ORM, or if you want to do code generation or other automated processing

Fair enough.

👍 To provide some concrete reasoning:

while accounts might make more sense than account, this is not so obvious for tables that represent relationships instead of objects. even in your example there is an inconsistency between the pluralization in rbac_groups_rights x rbac_role_rights
when you keep table names singular, things can be done mechanically: foreign keys can always be {tablename}_id, for example
point 2 becomes especially relevant when you need to bring in an ORM, or if you want to do code generation or other automated processing

Done! :)


arch: adjust idle stack offset to reserve space of stack info

Summary
arch: adjust idle stack offset to reserve space of stack info
Impact
idle thread stack usage
Testing
  PID GROUP CPU PRI POLICY   TYPE    NPX STATE    EVENT     SIGMASK   STACK   USED  FILLED    CPU COMMAND
    0     0   0   0 FIFO     Kthread N-- Assigned           00000000<PHONE_NUMBER>80  99.6%!  50.0% CPU0 IDLE

After patch:
  PID GROUP CPU PRI POLICY   TYPE    NPX STATE    EVENT     SIGMASK   STACK   USED  FILLED    CPU COMMAND
    0     0   0   0 FIFO     Kthread N-- Assigned           00000000<PHONE_NUMBER>20  22.5%   50.0% CPU0 IDLE

If the user wants a 4096 stack they will not get the value they set. That seam wrong and confusing.
The TLS size should be added the the allocation So that USER+TLS == stack(USER's STACK) + (tls size) (rounded up for alignment)

Hi @davids5

If the user wants a 4096 stack they will not get the value they set. That seam wrong and confusing.
The TLS size should be added the the allocation So that USER+TLS == stack(USER's STACK) + (tls size) (rounded up for alignment)

Idle thread is special, the stack size of idle thread cannot be round up because the most of boards are used to writing the definition of idle thread stack size in the link script, which is fixed, If the TLS or stack info part is increased by mistake, then Will cause unexpected issues,
Therefore, in the idle thread case, we will deduct the tls part from the current idle thread stack, so that although a part of the proc show is missing, it will not affect the operation of the program.
Seriously, Round up or alignment the TLS size for idle thread is meaningless, this is just for the proc show to the user. Of course, if you insist, I will make similar changes.

@anchao - I think the arguments go something like this:
1 ) "If we change internals, the users configuration should not be broken"
2)  "Be consistent".
That said the call stack penetration on idle has grown a LOT since joining ASF.
I not a fan of not wasting peoples time trying to guess how to size the stacks.  If a user asks for 4096 for the stack it should be 4096 (or rounded up) as it has always been.
So yes I do insist (as I did on the original PR)  but I am open to hearing the counter argument.

If the user wants a 4096 stack they will not get the value they set. That seam wrong and confusing.
The TLS size should be added the the allocation So that USER+TLS == stack(USER's STACK) + (tls size) (rounded up for alignment)

I think the developer should not create this expectation that the defined stack size will be entirely available for usage.
The Linux Kernel seem to do the same thing:
https://elixir.bootlin.com/linux/v4.3/source/include/linux/sched.h#L2400

@anchao - I think the arguments go something like this:
1 ) "If we change internals, the users configuration should not be broken"
2) "Be consistent".
That said the call stack penetration on idle has grown a LOT since joining ASF.
I not a fan of not wasting peoples time trying to guess how to size the stacks. If a user asks for 4096 for the stack it should be 4096 (or rounded up) as it has always been.
So yes I do insist (as I did on the original PR) but I am open to hearing the counter argument.

The additional size cost come from other PR, this PR just try to fix the regression introduced by that PR. Let's dissuss it in a new issue?

The additional size cost come from other PR, this PR just try to fix the regression introduced by that PR. Let's dissuss it in a new issue?

@xiaoxiang781216 So you would like this merged and then you will fix the issue?

No, it's better to move the space reserve to sched/init.

@patacongo @davids5 please review the new code which reserve tls_task_info by up_use_frame for idle task just like normal task. Node: we don't memset here since up_use_frame will do it for us.

@patacongo @davids5 please review the new code which reserve tls_task_info by up_use_frame for idle task just like normal task. Node: we don't memset here since up_use_frame will do it for us.

Since we reverted @no1wudi's PR, memset is the only initialization required, correct?  If we restore that PR, then the call to initialize the task_info_s would also be needed.

@patacongo yes, you are right. @no1wudi please update these two places when you bring back your change again.

@patacongo yes, you are right. @no1wudi please update these two places too when you bring back your change again.

It seems a little wasteful to support this thread-specific data in the IDLE thread (or any other kernel thread) since they do not have pthreads.  Is there a clean way to just omit most of TLS from IDLE and kernel threads?  That would be a more embedded friendly thing to do.
In the past, my eventual goal was to make kernel threads very lightweight.  Task threads have gotten heavier and because of all of shared logic, kernel threads have gotten heavier as well.

At least, TLS is required in the current implementation state. We have found the device can't boot without this because the minor(recoverable) error happen during the initialization will set errno in TLS.


Update Standard Library API docs and Module.md files

Purpose

$subject

Check List

[x] Read the Contributing Guide
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[ ] Added necessary tests

[ ] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[x] Added necessary documentation

[x] API documentation
[x] Module documentation in Module.md files
[ ] Ballerina By Examples

Codecov Report

Merging #22646 into ballerina-1.2.x will not change coverage.
The diff coverage is n/a.

@@               Coverage Diff                @@
##           ballerina-1.2.x   #22646   +/-   ##
================================================
  Coverage            14.59%   14.59%
================================================
  Files                   51       51
  Lines                 1411     1411
  Branches               219      219
================================================
  Hits                   206      206
  Misses                1189     1189
  Partials                16       16

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 033ae02...033ae02. Read the comment docs.


Hearthbeat connection to AMQP proxy

I got a issue when i'm connectiong the  bridge towards a cluster of rabbitmq behind a proxy.
ERROR:amqp::session: Error in reading loop: Protocol("failed to fill whole buffer")
ERROR:amqp::session: Error dispatching closing packet to a channel
This error seems to happen because the connection was closed. I would like to know if the heartbeat system offer by Rabbitmq is implemented https://www.rabbitmq.com/heartbeats.html

There is no heartbeat support in the amqp lib used https://github.com/Antti/rust-amqp
Missing things: No heartbeats support


Permission Popups - Native Implementation

Camera

iOs Native: display the QR popup request on first time user enters any of the QR Scan screens and if we still dont have camera permission
iOS native: if camera permissions have been denied and user enters the QR scan or or the "ok, verify me" screen then show the "please enable camera permissions" popup

Clipboard
Nothing (no permissions needed)
Popups are ready. All we have to do it's implement PermissionsAPI.native.js wrapper
I propose to use https://github.com/react-native-community/react-native-permissions
I've added draft implementation which uses this package.
Also, i've updated NativeClipboard to https://github.com/react-native-community/clipboard - need to merge to react-native & test

On native we have option to open device settings popup from app. Unfortunately on web it's impossible to open browser settings. Even if they're just a web pages with specific addresses (e.g. chrome:settings, about:settings etc) - window.open() call will throw an exception trying to open internal page
So, if we're running native, we could add an additional button 'Open settings' to the "Please/You must enable dialog's" settings.
From other side, if we want keep web/native app features in consistence, we shouldn't add this button on native (because it's impossible to implement on web).
@sirpy once native app becomes prioritized could you please look at this and provide your suggestions about option i've described above ?

@sirpy @serdiukov-o-nordwhale Did you guys reach a decision about adding an "Open settings" button - native only - @MathiasMoralesDixtra  has #2210 open which covers the initial denied permissions popup so if we want to add the button it could be part of the same PR


Render corruption (rare?)

Sometimes you get stuff like this:
http://i.imgur.com/OU484J0.png
http://i.imgur.com/uK7LT3n.png
Could be related to co8 content. Would be good to have a safeguard against this kind of phenomenon.

Do you have that save? Would be good as a starting point. Oh and this is with the radial menu being closed right?

http://wikisend.com/download/486424/corruptRender.zip

Not that rare apparently, but may well be Co8 related:
https://www.youtube.com/watch?v=EbfGeoDZZoU

This is still present:

I managed to trigger this by going in and out of the inn a few times. The log doesn't show anything out of the ordinary. The cause seems to be related to Spugnoir - when I scroll him out of view, the glitch doesn't appear. Might be a particle issue again.

The NPC affected seems random. Next time I got it, it was focused on a generic man in the corner

I think this might be a different bug, but we'll keep it in this issue.
This is probably really model-related while the pervious issue I fixed was
particle system related.
On Fri, Feb 19, 2016 at 12:04 PM, Dude McDude<EMAIL_ADDRESS>wrote:

The NPC affected seems random. Next time I got it, it was focused on a
generic man in the corner
[image: image]
https://cloud.githubusercontent.com/assets/11220053/13173979/558905e0-d709-11e5-9d92-15cb05654e68.png
—
Reply to this email directly or view it on GitHub
https://github.com/GrognardsFromHell/TemplePlus/issues/117#issuecomment-186173229
.

I started working on reverse engineering the AAS model system to find and fix this issue.
My current observation/guess is that this is related to the cloth simulation somehow getting corrupted internal state. This can be reproduced by entering/leaving the inn (via the upper floor for example) a lot (10+ times).


Suggestion: display the help message when pysubs2 is run from CLI without any arguments

Currently, if you type pysubs2 directly into the command line and push enter, the module would load - but do nothing, and not automatically exiting. It would be good if a help message is printed and then the CLI tool exits automatically in this case.
I have the intention to contribute code for this feature, if that is permitted.

Hi @Northurland, if you'd like to send a pull request, you're welcome to do so :)

@tkarabela
A pull request is sent.
Thank you!
#82


JSDocs

Changes index.ts to export symbols by name rather than using export *. This is the pattern used by libraries like rxjs. It has the advantage of allowing you to export something to other modules in the package but still have the chance to hide them by not exporting them from index.
JSDoc everywhere! IntelliSense in VS Code shows the docs.
Tidied up some overloads to make for better IntelliSense

:up: :date: Fixed build issues and retargeted to release/2.1. We want to try and get this and the XML docs in before the other PRs so that we can easily see what we've done so far by diffing without seeing the docs PRs as noise.


Add go.mod, fix quoting of tilde (#1)

Tilde needs to be escaped anywhere in the string if an = sign is part of the string. So we can just as well escape it anywhere.

A gentle ping on this PR.
It also would be nice to add release or tags.

This package concerns itself with the behavior of /bin/sh. The behavior of applying tilde-expansion after the = in arguments to simple commands is a bash-ism and does not occur with /bin/sh. I don't write Go code anymore and haven't for a long time, so I am not inclined to expand this package to handle bash syntax.


StableLM

Hi,
Is this model based on StableLM?
Thanks!

no, the text model was initialized from phi and the vision model from siglip

Thanks!


docs(guide/External Resources): Added a course

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
feature
What is the current behavior? (You can also link to an open issue here)
linked to course
What is the new behavior (if this is a feature change)?
linked to course
Does this PR introduce a breaking change?
Please check if the PR fulfills these requirements

[ ] The commit message follows our guidelines: https://github.com/angular/angular.js/blob/master/CONTRIBUTING.md#commit-message-format
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

Other information:
Added a new course under Paid Onsite

This course is actually "paid online" not "paid onsite". But I will fix up and merge.

Sorry for my ignorance. Thanks @petebacondarwin

@packtpartner, @petebacondarwin fixed that while merging - you don't need to do anything :smile:

@gkalpak thanks a lot. Will it show on https://docs.angularjs.org/guide/external-resources anytime soon?

@packtpartner, it should be visible already.

It is now that our CI server got back up and running

Sorry for the trouble, but I am still unable to see it featured on https://docs.angularjs.org/guide/external-resources @petebacondarwin @gkalpak

Hm...it is listed (as Packt) under Courses > Paid online. (You had originally added it under Courses > Paid on-site).
But looking at it, it looks morw like a book, right?

It is an online course.

It is just packaged as an ebook

Thanks for all your help @petebacondarwin @gkalpak :)


Custom Node mode

The option to configure wallet to use any custom node would be much useful.
Users will be able to use such services as QuikNode.io

This seems like it would solve some other issues, such as #357 by allowing users to configure their geth and ports manually if needed.


Does it support zoom and pan?

No multipointer/gestures support inside graphx, only the basic mouse interactions. All GDisplayObjects have onMouseDown,onMouseUp, etc. So pan can be easily approached manually inside graphx (or use startDrag(),stopDrag()) but for gestures and multitouch you need a GestureDetector wrapping the SceneBuilderWidget and emitting events to be captured inside graphx code.

Is support for gestures planned? If not can this be added to the docs? I am sure this will be frequently asked question :o

No plans for now, is totally doable but is just a layer on top of gesture detector. If u put a GestureDetector on top of the SceneBuilderWidget coordinates will match the stage, and you can emit signals to your Graphx scene to use the data.

@JulianBissekkou if you are working on it, please update any solutions. I also want them. thank you!

@imiskolee I am not working on it, but I am sure that there is an example where you can check the code. Am i right @roipeker ?
I saw a map example a few months ago on twitter. Can you publish that?

I can't publish the map example, but i can add a simple demo that shows pan and zoom.
is just a matter of notify the gesture detector widget callbacks into the Graphx scene

@roipeker  it's also very helpful for US!  please a GIST!

Live demo
Complete gist.
Just made a full sample, might look overcomplicated, but covers Image shader fill (graphics.beginBitmapFill with Matrix transforms), mouse / touch input, and easing.
Hope it makes sense...

Live demo
Complete gist.
Just made a full sample, might look overcomplicated, but covers Image shader fill (graphics.beginBitmapFill with Matrix transforms), mouse / touch input, and easing.
Hope it makes sense...

Sorry, I should have provided a simpler sample.
Here's another gists with much less code.
live demo .
Let me know if the example is clear enough, so i can close this bug report.

@roipeker Can you please add these gists as examples in the repository? It would really help new comers as they would find the examples in one place rather than scattered around in gists.
@roipeker GraphX is extremely useful library. Thank you so much for the precious countless hours and neurons you have spent on making this library possible.

Fixed in https://github.com/roipeker/graphx/tree/dedf6cc8f455e4c6213e62731879b8d1aab381d3


Collected Goggins Comments on Social Currency Metric System

It may be easier to add comments as reviews on this pull request than process each of my issue comments. Its at least consolidated and seems like an easier way to converse about the thoughts I shared. Up to you. I don't expect it to be merged.

Just gonna mention @GeorgLink @samanthavenialogan @valeriocos @ria18405 for their comments. I'm not sure who else worked on the development of this metric, but feel free to include anyone else that might have missed these comments. :+1:

Soooo to start with...
Can we have permission to quote this until everyone's sick of hearing it?
"SCMS has great potential for providing widespread benefit to countless open source communities, and the effort placed into its development to date warrants recognition."
Just wow, that comment blew us away. Anyway, though, we took some time to think about the future of the SCMS with CHAOSS, and we love all of the annotations and changes we're seeing.
While fitting the SCMS into a "metric" rather than the "system" we originally defined it as was shoving it into a square hole, it was also forming the system into something new and we are excited to see where it goes.  Additionally, the social currency metrics we identified to build the system were intended to make concrete measurements out of vague concepts. This new opportunity seems to be the next step in that iterative process and this time we're grateful we have a community to help us do it. Making these more definable was always the goal, and we'd love it if we can follow that process with CHAOSS to make the system more useful.
So, in short, yes, absolutely, we are in alignment with this and in agreement that moving the SCMS from a metric to a group of metrics in a defined system is the way to go.  And we are over the moon excited to hear that has the potential to become a full project in its own right.
Both Dylan and I have been thrilled to see this system we've dedicated so much to, get picked up by a beautiful and brilliant community, and we can't wait to learn more about what this will become and how we can foster the SCMS’ growth in the CHAOSS community.
We do, however, want to ask what this change would mean for the SCMS' current status as a metric?


[#OSF-6351]change the dropzone route

Purpose
Change the dropzone to be based on commits instead of branch.

Changes

Side effects
Have a updated custome version of dropzone rdy to go in. This pr should be merged after https://github.com/CenterForOpenScience/dropzone/pull/2 is merged.

Ticket

https://openscience.atlassian.net/browse/OSF-6351

Well, that didn't go as well as we might hope.


Clarify that a default constructor is needed

If no default constructor is given, calls to jsondb will fail with an ArrayOutOfBoundsException or an InstantiationException somewhere in a java.* package (during the XML serialization and deserialization step).
It would be nice to point out, that those POJOs have to be JavaBeans (and may be to clarify what a JavaBean is). It would be even better to check for a default constructor via reflection and throw a meaningful Exception.

Thanks i will try to fix this soon

I have updated the Jsondb.io website with the information about convention POJO must follow as you suggested.
Thanks

Please review and if this is what you expected mark this closed.

Nice, thank you! That should help :-)


GHO Stability Module Launch

Doesn't really belong to the proposal stage, but are there tests checking 1) the roles that are not touched on the proposal are held by expected addresses (e.g. Executor lvl1 of gov) and complementary 2) no other addresses keep those roles (from deployer for example).

Is the LIQUIDATOR_ROLE set?

Just added tests to check permissions after proposal and fix the typo.

Is the LIQUIDATOR_ROLE set?

LIQUIDATOR_ROLE and TOKEN_RESCUER_ROLE are not set because are not initially needed. Given that the DAO is the DEFAULT_ADMIN of the contracts, it can enroll itself as one of them. Same for SWAP_FREEZER_ROLE, but I enrolled the lvl1 executor as freezer so it's easy to use in case of need.

Just added tests to check permissions after proposal and fix the typo.

Is the LIQUIDATOR_ROLE set?

LIQUIDATOR_ROLE and TOKEN_RESCUER_ROLE are not set because are not initially needed. Given that the DAO is the DEFAULT_ADMIN of the contracts, it can enroll itself as one of them. Same for SWAP_FREEZER_ROLE, but I enrolled the lvl1 executor as freezer so it's easy to use in case of need.


1.5.1 Set User/Group Owner on /etc/grub.conf

the fiel or symlink /etc/grub.conf not exist !
il have /etc/grub2.cfg
TASK [cis : 1.5.1 Set User/Group Owner on /etc/grub.conf (Scored)] *************
fatal: [localhost]: FAILED! => {"changed": false, "failed": true, "msg": "file (/etc/grub.conf) is absent, cannot continue", "path": "/etc/grub.conf", "state": "absent"}
        to retry, use: --limit @webservers.retry

here my OS :
# cat /etc/redhat-release
Red Hat Enterprise Linux Server release 7.2 (Maipo)

**RHEL 7 and CentOS 7 bencharks are coming soon.
**


Feature to export the built servegraph into saved_model.pb

Hi ylongqi. Thanks for the project. I enjoyed playing with the framework.
I have noticed that Recommender object does not have a functionality to export to a saved_model.pb. This is a very important function for me as I want to serve my model via tensorflow serving.
I managed to add the feature myself and would like to contribute to your project. Do you have any CONTRIBUTING.md such that I can follow guidelines if any.

Same issue here for TF2.0. It's hard to save custom Model objects. Is there any plan for this?

The issue is addressed for TF2.0. All the models under openrec.tf2.recommenders are instances of tf.keras.Model and can be saved via save_weights and loaded via load_weights

Sure closing the issue.

Thank you for reply


Implement an API more aligned with Elixir style

Hey, thanks for this great library!
I was wondering if you would consider implementing an API more aligned with Elixir style, such as below:

adding an alias new/2 for new_ok/2
adding an alias ensure_type/2 for ensure_type_ok/2

This would allow to have an API in the shape of function!/1 and function/2 instead of function!/1 and function_ok/2, which I guess would be more aligned with Elixir coding guidelines.
Example : Ecto.insert/2
I can open a PR if you'd like.

Hey, thanks for the feedback.
Yes, these _ok function names can be aligned with the standard notation indeed!
And in case if somebody needs to change a name due to a clash, there is a global config option name_of_new_function.
I think it would be good to drop the _ok postfix to have new and new! function names generated.
It'd be nice if you could make a PR for this.

Updated to new and new! in version 1.4.0
Please, search and replace new_ok( -> new( in all files of the project using Domo to migrate.

Hey, sorry for my late reply, I was off last week.
Thank you for the update!


chore: upgrade go version

Signed-off-by: rishabh625<EMAIL_ADDRESS>What type of PR is this?

Uncomment only one  /kind line, and delete the rest.
For example, > /kind bug would simply become: /kind bug

/kind bug
/kind cleanup
/kind failing-test
/kind enhancement
/kind documentation
/kind code-refactoring

/kind  chore
What does this PR do / why we need it:
updates go version
Have you updated the necessary documentation?

[ ] Documentation update is required by this PR.
[ ] Documentation has been updated.

Which issue(s) this PR fixes:
Fixes #?
Test acceptance criteria:

[ ] Unit Test
[ ] E2E Test

How to test changes / Special notes to the reviewer:

This PR is dependent on this

/assign @jopit

/ok-to-test

/retest

@rishabh625
Just noticed that the replace section still specifies v0.22.z versions for k8s packages
I think these references will need to be updated to v0.23.z to be compatible with the upstream operator
WDYT?

@rishabh625 Just noticed that the replace section still specifies v0.22.z versions for k8s packages I think these references will need to be updated to v0.23.z to be compatible with the upstream operator WDYT?

it should have auto changed when go mod tidy ran at least in this https://github.com/redhat-developer/gitops-operator/pull/309/files when we change upstream operator version

/retest

/retest

/retest

@iam-veeramalla : I had to remove the flaky tests for ci to pass,  as per your suggestion , confirmed that this tests were failing on master branch too

@iam-veeramalla : I had to remove the flaky tests for ci to pass,  as per your suggestion , confirmed that this tests were failing on master branch too

But you later told me that the tests were failing everytime after the go upgrade. If that is the case , we need to fix the tests or code.

@iam-veeramalla : I had to remove the flaky tests for ci to pass,  as per your suggestion , confirmed that this tests were failing on master branch too

But you later told me that the tests were failing everytime after the go upgrade. If that is the case , we need to fix the tests or code.

It's failing on master branch too, so may be it's flaky e2e, had to remove two test cases instead one.

@iam-veeramalla : I had to remove the flaky tests for ci to pass,  as per your suggestion , confirmed that this tests were failing on master branch too

But you later told me that the tests were failing everytime after the go upgrade. If that is the case , we need to fix the tests or code.

It's failing on master branch too, so may be it's flaky e2e, had to remove two test cases instead one.

It's not a good option to remove tests that are not flaky. Please confirm. If it's not flaky let's fix them.

/retest

Verify OIDC Configuration is created test is failing repeatedly even after increasing the timeout. I wonder why the oidc.config is not being set :thinking:

Verify OIDC Configuration is created test is failing repeatedly even after increasing the timeout. I wonder why the oidc.config is not being set 🤔

also keycloak deployment is not getting created

Verify OIDC Configuration is created test is failing repeatedly even after increasing the timeout. I wonder why the oidc.config is not being set 🤔

also keycloak deployment is not getting created

Verify OIDC Configuration is created test is failing repeatedly even after increasing the timeout. I wonder why the oidc.config is not being set 🤔

also keycloak deployment is not getting created

but i wonder, how e2e is passed if i remove Verify OIDC Configuration is created test

/lgtm
/approve

/approve


chore: further automate release process (#462)

PR Type

[x] Build-related changes

Release
What Is the Current Behavior?
Currently charts and the semantic version type are needed for a release release pipeline (e.g. icm-as:minor). This will be changed by using an automatic approach where commits and theire messages deliver the needed information.

Issue Number: Closes #462
What Is the New Behavior?
Chart changes could be released by just starting the github action and selecting the branch to release. Afterwards a PullReqest will be made with the changes.
Does this PR Introduce a Breaking Change?

[x] No

Other Information

the pullrequest also switches from bump2version to bump-my-version
using the label ignore-for-release-notes synchonization PullRequests are ignored for the release notes generation by github

We should also update the PR template to reflect the new guidelines and that following them is mandatory. Maybe we could even require it in some way by a action, but that may be too hard to do (but maybe this already exists).

I also updated the PR template and added a link to the wiki.


Issue with Kubectl not installed due to TLS error

This is a Bug Report

 I am trying to install the kubectl package on ubuntu but throws me an error of url: (60) SSL certificate problem: self signed certificate in certificate chain
More details here: https://curl.haxx.se/docs/sslcerts.html
curl failed to verify the legitimacy of the server and therefore could not
establish a secure connection to it. To learn more about this situation and
how to fix it, please visit the web page mentioned above.
Problem:
Getting issue while installing the kubectl package on ubuntu and shows me ssl cert error which do not authenticate with the remote server.
Proposed Solution:
Page to Update:
https://kubernetes.io/...

/triage support

@harshaltiwariACN, GitHub is not the right place for support requests.
If you're looking for help, check Stack Overflow
You can also post your question on the Kubernetes Slack or the Discuss Kubernetes forum.

/remove-lifecycle stale

This does seem more like a support request. @harshaltiwariACN if you have more details about this issue, please feel free to reopen the issue and add that information.
/close


docs(kubernetes) Migrate KIC documentation

Note: All commits before November 10th are inherited history from the ingress controller repo where these docs originate (https://github.com/Kong/kubernetes-ingress-controller). Please review changes made in the November 10th and onward commits.
Docs issue: https://konghq.atlassian.net/browse/DOCS-1301
Why is this needed?
This is a big, big customer and user ask. With this migration, the hope is to have all the docs in one place for easy access.
Changes
Migrating the /docs directory from kong/kubernetes-ingress-controller/main into kong/docs.konghq.com, and completing the minimal necessary tasks to display a useable doc on the live site. Specifically:

Migrate all content under docs into app/kubernetes-ingress-controller/1.0.x.
Create version and edition metadata for kong-ingress-controller and 1.0.x
Navigation (table of contents) file with icons
Update all relative links to point to this repo (or in a rare case, back to the originating repo)
Create a landing page
Add top-level tab for Kong Ingress Controller to doc site
Remove extraneous "Table of Contents" sections from docs, as the doc site pulls this information from page metadata to create a ToC already
Make sure images aren't broken

Preview
https://deploy-preview-2446--kongdocs.netlify.app/kubernetes-ingress-controller/latest/introduction
Outstanding work

The Plugin Compatibility and Version Compatibility topics/tables don't display very well. Either need to convert the icons into something else, or add a style definition for them (or hide them temporarily and revisit).

Do we want to have these topics in these pages, or would you rather maintain them in the original repo @rainest @hbagdi ?

Didn't touch any content or attempt any cleanup; will look into that in the coming weeks.
Add the kong/charts and kustomize docs (if any) to this doc set, if possible (way out of scope for this PR, but would be ideal eventually).
Add a search index (won't work in preview, has to be live before doing that)
Question for @eskibars and @rezaloo: as with decK, the original plan was to add the docs to a top-level tab on the doc site. After some recent conversations, it sounds like that's probably not the right approach anymore, and instead we want to treat it as any Gateway component. Do I have that right?

Since KIC is an independently-versioned component, it might make sense to treat it like decK as well: no tab, but with its own section of the site: https://docs.konghq.com/deck

From Shane's feedback:

Removed Kong Ingress Controller tab from top nav
Removed landing page
Added it to the Enterprise nav as test, and added Enterprise nav entries to KIC nav

This is a solution to a problem brought up by Shane around doc flows. Unfortunately, because KIC has its own versioning scheme, it can't easily live under /enterprise or CE docs. My attempted (read: hacky) solution is to populate both the Enterprise and Community navs with the KIC topics.

Side comment: I really should've merged the migrated content over first, and then worked on all the details. Reviewers, I apologize for not having that foresight...

Added 2972edf699 as the use of inline code in section headers did not play well with the sidebar:

Otherwise spot checking around for formatting and nav looks fine. The Markdown quotes we used for marking required/optional stuff in deployment.md (e.g. https://deploy-preview-2446--kongdocs.netlify.app/kong-ingress-controller/1.0.x/concepts/deployment/#ingress-controller-deployment) don't look great, but they didn't look that great originally either. Not sure of a great way to handle those, and it's pretty minor, so may as well leave that as-is for now.
Looks generally fine aside from the known issues with the compatibility tables. IMO we do want them here; does the design team provide a set of standard icons we can pull from? I'd guess they have basic stuff for yes/no symbols we can use if so. If not, dunno, Twemoji? CSS stuff to shade the boxes?

IMO we do want them here; does the design team provide a set of standard icons we can pull from? I'd guess they have basic stuff for yes/no symbols we can use if so. If not, dunno, Twemoji? CSS stuff to shade the boxes?

I've used Font Awesome in the past, though for now that means using
html tags (eg here https://docs.konghq.com/hub/plugins/compatibility/). I'll figure out how to make them more user-friendly at some point, but for now, that's probably what we'd go with.

Latest round of edits, hopefully the last for a minimal publish-ready doc:

Added full KIC nav to CE and EE docs as interim solution - single-source CE/EE doc is the goal for next year, so this won't be an issue then.
KIC now picks up the EE nav (Shane and Reza's decision) - it needed to pick up one of the navs for better flow, and the product decision was that EE should be it for exposure's sake.

Maybe we need to add a banner or something across the KIC doc to assure users that it applies to both CE and EE?

Fixed the icons on the version and plugin compatibility topics

@rainest @mflendrich I'm hoping this is pretty much it, fingers crossed.
For Github logistics: I want to squash this PR because there's a mess of my commits in here, but I'm not sure this is the best idea for keeping the history coming from the KIC repo. Any advice?

Icons look good. Nav is pretty much stuck with something imperfect due to the site structure; I don't think there's any great option there and we'll probably just need to answer questions as they come in until future reorganization.
git rebase -i master from CLI to squash yours as desired and git push -f origin doc/kic-documentation after to rewrite which parts of the history you'd like while keeping the rest. It will cancel any existing approval reviews, so someone will need to click past that again after.


Add basic include_runfiles to pkg_files.

Show it working in a mappings tests.
Improve the mapping test to print something a little more useful.
Next step: Make the same code callable from pkg_tar and pkg_zip

@aiuto Now that this has landed, are you planning to start work on the pkg_tar fix, or would you like me to pick that up?

I'll continue for pkg_tar.  I'm going to have to keep importing into
google3 to make sure I don't break everyone.
On Wed, Aug 16, 2023 at 11:06 AM Alex Eagle @.***>
wrote:

@aiuto https://github.com/aiuto Now that this has landed, are you
planning to start work on the pkg_tar fix, or would you like me to pick
that up?
—
Reply to this email directly, view it on GitHub
https://github.com/bazelbuild/rules_pkg/pull/724#issuecomment-1680791537,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAXHHHBVEINU2JXK2HJJSODXVTOXVANCNFSM6AAAAAA3KSRYYU
.
You are receiving this because you were mentioned.Message ID:
@.***>

Hi @aiuto @alexeagle Thanks for this fix! could you update on this pkg_tar work? And will there be a new release soon that includes the new feature in pkg_files?

The first of the PRs for that is out for review.
I expect to be fully finished by end of October.


DB: search for composes for a time period

This commit introduces a new method to search for composes made a by a
user for a given time period. This adresses the first part of the
issue #247

Still marking this as blocked as the app-intf changes need to land beforehand (Just in case someone comes along and merges it).


Usage with angular universal

I recently learned how to use Angular 2 after a long time using React in production with server side rendering and I wondered if I could reproduce the same stack in Angular 2. Server side rendering is important for SEO and performance on client side, bootstrap is a lot quicker when pre-rendered by server. In React I would do this by dumping my Redux state in the HTML and rehydrate on client side using redux-persist or something like this. But I don't know how to start with ngrx to reproduce this behavior. If you could provide an example to start, or some clues to follow, I would be glad to write an example in the documentation.

We're holding off on any documentation on this until the universal migration into angular/core is complete, as APIs are likely to change.
That said, ngrx's initial state parameter was designed for this purpose - generally its just a question of doing the same thing you'd do in react/redux - dump the state into a global variable server side and hydrate ngrx's initial state with that.

Thanks for the advice, i'll dig into this and make some feed back for anyone wanting to do the same

@robwormald Would love to help with this as well, was looking into it on the Universal end and it'd be as easy as how we create the CacheService or Preboot strings on window, but wasn't sure how to access a snapshot of the Store when Angular stabilizes.

@MarkPieszak Subscribing to the Store delivers the last value synchronously:
store.take(1).subscribe(state => {
  // state is available synchronously
});

Is there any special set up that has to be done right now if we are using universal?
For example, I am getting the following errors server side:
TypeError: Cannot read property 'categories' of undefined
In my getProductState function:
getProductState() {
    this.productState.subscribe(res => {
      this.categories = res.categories;
      // this.fetching = res.fetching;
    });
  }

What is your opinion of writing a function that will rehydrate the reducer initial state from a global window variable which holds the state from server?  So instead of dispatching directly from ngOnInit(), use a function to call that which will check if the global variable exists and if so, rehydrate otherwise (on server) call the dispatch and update the initial state.
Thanks

I wonder how to get the current store content after the application is prerendered on the server side, so I can serialize it into the page to send back to the client...
Thanks very much for your help!

I'm rehydrating in my reducer files at the moment.  It is working fine for me.  I check if isBrowser then parse the json in the universal cache

This is in the design for the V3 API, but the basic idea is more or less what @ScaryWolfMan describes - you'd (server-side) add your initial state to a global variable and pick it up on bootstrap.

@robwormald thx i saw design yesterday but do you think it is bad idea to rehydrate in the reducers by checking if the global var exists?  or it will be a service?

thanks very much @ScaryWolfMan and @robwormald for your explanations!

Any updates on this issue?

See https://github.com/ngrx/platform/issues/101

I would like to know how ngrx/store can be used with Angular Universal. If we have a state that is dependent on the cache or localStorage, the PLATFORM_ID token cannot be injected since there is no constructor in our reducer file.


[mgmt] selfhelp release

https://github.com/Azure/sdk-release-request/issues/5110

API change check
APIView has identified API level changes in this PR and created following API reviews.
@azure/arm-selfhelp


Browsing through code, cleaned up some sonarqube warnings.

Hey Guys,
I've never contributed before, but I always wanted to get under the hood of Frostwire and browse through the code. I noticed a few warnings while I was browsing, and thought I would fix them. Hope this helps.

Alex

sorry I didn't see your pull request until now.

It’s all good. Go ahead and merge? It builds okay.
Sent from my iPhone
On Jan 6, 2023, at 18:43, Angel Leon @.***> wrote:

sorry I didn't see your pull request until now.
—
Reply to this email directly, view it on GitHubhttps://github.com/frostwire/frostwire/pull/994#issuecomment-1374267181, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAPC2JEML75E36WAWQ5YLZDWRCU3HANCNFSM6AAAAAARTPDHDE.
You are receiving this because you authored the thread.Message ID: @.***>

yeah, but it needs to run and not break. If you don't want to fix, maybe I'll just clone your branch and selectively merge some of the fixes.
Not a big fan of merging big PRs and then introduce bugs

Can you clone these changes to another branch and submit another PR from that branch please?

This way I can experiment without screwing things up on master

fetched your master and testing it.
it breaks music playback, let's see if I can fix it because there are several things I'd like to merge.

Sorry. Not merging this.
Please submit smaller patches and don't delete our binaries from the repo.


dolphin: Use test driver instead of TiDB driver

Thus removing the dependency on pingcap/tidb. If we need a more advanced
driver, we can always write one ourselves

We also can avoid issues like #594 in the future


Add created at attribute on exercise create

This includes refactoring of index.js, as we want to encourage making new cloud functions in separate files.
The main change here is that before, we were adding the 'createdAt' field to the Exercise document via supplying the 'createdAt' field in the 'apply-admin' Vue app. Now we add 'createdAt' field when the Exercise document onCreate method is triggered.

Need to fix lint errors by running npm run lint locally


Add custom annotations to generated classes

Is it possible to add custom annotations when generating c# server or client classes? I would like the same models when communicating to the backend using RPC.

I'm guessing you could achieve this by providing customised Liquid templates, which add the necessary attributes in addition to, or instead of, the ones that NSwag applies by default.

I have a very similar use-case like @florianh77:
I want to add [ExcludeFromCodeCoverage] to every generated class (as this is the annotation that is understood by our code coverage tool).
@davidkeaveny I find your answer interesting and I have also found some resources which point me one step further:

this seems to be the template for adding Client Annotation: https://github.com/RicoSuter/NSwag/blob/master/src/NSwag.CodeGeneration.CSharp/Templates/Client.Class.Annotations.liquid
this document refers to a TemplateDirectory setting, which I am unsure where to set: https://github.com/RicoSuter/NSwag/wiki/Templates

@Parcley it's probably easiest to use NSwagStudio, which provides a more user-friendly approach to setting up the .nswag configuration file. When configuring the CSharp Client, it's near the bottom of the configuration page, in a section labelled Templating in a field named Template Directory; it should be sufficient to use a path that is relative to your .nswag file.
If you want to edit the .nswag file by hand, then the configuration looks something like this:
{
  "codeGenerators": {
    "openApiToCSharpClient": {
      "templateDirectory": "Templates"
    }
  }
}


Fix multiget socket corruption

Hi @casperisfine - thanks so much for being willing to help out with this. I'd love to help in any way I can, but I don't feel super comfortable engaging on the upstream repo given the level of hostility/unpleasantness I've met there. I also doubt it would be helpful - my concern is that my direct involvement would decrease the chances that any PR is evaluated fairly and merged.
So I figured maybe I could work with you to help polish up an implementation, and then you could carry it over the finish line? Let me know what you think.
Tagging on this PR because it is in some ways similar to what you proposed. As you can see, there's an existing @request_in_progress state flag. The wrinkle is that it is set to false between writing an op to memcached and reading its response. Not entirely sure why it works that way - so maybe it would be best to introduce a new variable. (This PR is not complete in that it only addresses it for multiget, the regular get implementation would need similar treatment.)
Was trying to think where the best place to put the new variable and check it would be. Working backwards, maybe we could do a similar check here https://github.com/petergoldstein/dalli/blob/0483446acf82918636990c2839ca042e0e95c656/lib/dalli/protocol/connection_manager.rb#L101 for a pending read. Then we could set pending read to true after verifying state, similar to how start_request! is called in a few places. The problem then is that for multiget, we verify state halfway through - as we setup reading responses rather than setup writing for the keys. So I think like I did in this PR, that might have to move around a little bit.
Curious what you think, maybe there's a better place to put the logic that would require changing less existing code.

I submitted what I think could be an acceptable patch.

Thanks @casperisfine - looks great mostly. I think there's one missing piece, it seems that moving start_request! before write_noop isn't sufficient to protect the multiget flow.
If the interruption happens after make_getkq_requests but before pipeline_response_setup (i.e. try raising the interrupt right here)  the multiget values will still end up on the socket, but @request_in_prgress will be false.


07.19.2022 v<IP_ADDRESS>37 build check--custom map zoom for static map

Pressed F5 to get fresh start.
click ok through info popup
click create custom map
click load 'final' file
click 2. filtered data
click "filter by state" > removed VA  (to focus only on MD sites)
click apply filters
go to range map
click variable to plot > selected current mean
click auto generate title
click update range map
go to static map
.... at this point all looks good ...

click zoom region > select points
click update range map > got below error

Change from ggplot2::coord_fixed to ggplot2::coord_sf.


[Feature] Undo button

Because I just deleted the wrong wormhole.  It would be amazing to have, both for the map, and for sigs.  So if I paste sigs in the wrong system, I can just undo it.
If this is something that would take time, an edit log help.  Also so you can see if someone is messing with the map.

Seconding this feature request.  Had a few corp users request an undo, due to pasting sigs in the wrong system and overwriting previous ones.

This is needed. Multiple pilots working on multiple connections can at times lead to incorrect data.
Please look at implementation of this for future releases. My sanity thanks you for your consideration/work on this.

Signature table history [beta]
There is now a "semi persistent" history for signature tables available.  Features:

Each change in the table creates a new history record with all signatures on it.

Add/Delete or Update a signatures creates a record of all signatures

Historic signature data is stored in Cache for 2h

If Cache gets cleared, historic data is also cleared

Up to 10 history record can be stored for a table

It is not just an "undo" action, you can choose between the last 10 stats of the table

The "character name" who did the change, is recorded as well
The total number of signatures + timestamp of a record is visible in the UI
There are icons for "add, delete, update" action that triggered the new history record added to UI
If someone undos (load old table state) a table, this can be seen as well in the UI


SAK-29269 Hide non-assignable roles

Non-assignable roles, such as .anon and .auth, are now hidden during
participant addition.

Okay, this makes sense to me....


[GHSA-6h5x-7c5m-7cr7] Exposure of Sensitive Information in eventsource

Updates

Affected products
References

My first PR here. Didn't know how to say "fixed in version 1.1.1 as well as 2.0.2", so I added another product line. Didn't feel quite right, but I hope you understand my intent :slightly_smiling_face:


remove wrong code

The right code is PPMR, already present on the list
related: https://teslascout.com/view.php?vin=5YJ3E7EB6KF222936

Thanks again!