error: ambiguous overload for ‘operator*’  in test_list.cpp

hey i have cudatoolkit 12.2 and cudnn 8.9 installed on ubuntu 22.04 lts
when following the samples build instructions below i encounter the error in the title
 mkdir build; cd build
cmake -DCUDNN_PATH=/usr/lib/x86_64-linux-gnu/ -DCUDAToolkit_ROOT=/usr/local/cuda/bin ..
 cmake --build . -j8

the configure step seems fine

cmake configure output
-- The C compiler identification is GNU 11.3.0
-- The CXX compiler identification is GNU 11.3.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Found CUDAToolkit: /usr/local/cuda/include (found version "12.2.91")
-- Looking for pthread.h
-- Looking for pthread.h - found
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Success
-- Found Threads: TRUE
-- cudnn found at /usr/lib/x86_64-linux-gnu/libcudnn.so.
-- cudnn_adv_infer found at /usr/lib/x86_64-linux-gnu/libcudnn_adv_infer.so.
-- cudnn_adv_train found at /usr/lib/x86_64-linux-gnu/libcudnn_adv_train.so.
-- cudnn_cnn_infer found at /usr/lib/x86_64-linux-gnu/libcudnn_cnn_infer.so.
-- cudnn_cnn_train found at /usr/lib/x86_64-linux-gnu/libcudnn_cnn_train.so.
-- cudnn_ops_infer found at /usr/lib/x86_64-linux-gnu/libcudnn_ops_infer.so.
-- cudnn_ops_train found at /usr/lib/x86_64-linux-gnu/libcudnn_ops_train.so.
-- Found LIBRARY: /usr/include
-- cuDNN: /usr/lib/x86_64-linux-gnu/libcudnn.so
-- cuDNN: /usr/include
-- Configuring done
-- Generating done
-- Build files have been written to: /home/kevin/code/thirdparty/cudnn-frontend/build

then in test_list.cpp there is an overload resolution error of operator * because of the datatypes

nvcc error
/home/kevin/code/thirdparty/cudnn-frontend/samples/test_list.cpp: In function ‘void CATCH2_INTERNAL_TEST_102()’:
/home/kevin/code/thirdparty/cudnn-frontend/samples/test_list.cpp:2127:50: error: ambiguous overload for ‘operator*’ (operand types are ‘half’ and ‘float’)
 2127 |         half globalScaleOutput = afterConvOutput * scale1.hostPtr[0] * scale2.hostPtr[0];
      |                                  ~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~
      |                                  |                                 |
      |                                  half                              float
/home/kevin/code/thirdparty/cudnn-frontend/samples/test_list.cpp:2127:50: note: candidate: ‘operator*(int, float)’ (built-in)
 2127 |         half globalScaleOutput = afterConvOutput * scale1.hostPtr[0] * scale2.hostPtr[0];
      |                                  ~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~
/home/kevin/code/thirdparty/cudnn-frontend/samples/test_list.cpp:2127:50: note: candidate: ‘operator*(long long unsigned int, float)’ (built-in)
/home/kevin/code/thirdparty/cudnn-frontend/samples/test_list.cpp:2127:50: note: candidate: ‘operator*(long long int, float)’ (built-in)
/home/kevin/code/thirdparty/cudnn-frontend/samples/test_list.cpp:2127:50: note: candidate: ‘operator*(long unsigned int, float)’ (built-in)
/home/kevin/code/thirdparty/cudnn-frontend/samples/test_list.cpp:2127:50: note: candidate: ‘operator*(long int, float)’ (built-in)
/home/kevin/code/thirdparty/cudnn-frontend/samples/test_list.cpp:2127:50: note: candidate: ‘operator*(unsigned int, float)’ (built-in)
/home/kevin/code/thirdparty/cudnn-frontend/samples/test_list.cpp:2127:50: note: candidate: ‘operator*(float, float)’ (built-in)
In file included from /usr/local/cuda/include/cuda_fp16.h:4070,
                 from /home/kevin/code/thirdparty/cudnn-frontend/samples/fp16_emu.h:28,
                 from /home/kevin/code/thirdparty/cudnn-frontend/samples/fp16_dev.h:27,
                 from /home/kevin/code/thirdparty/cudnn-frontend/samples/helpers.h:36,
                 from /home/kevin/code/thirdparty/cudnn-frontend/samples/cpu_references.h:25,
                 from /home/kevin/code/thirdparty/cudnn-frontend/samples/test_list.cpp:27:
/usr/local/cuda/include/cuda_fp16.hpp:618:44: note: candidate: ‘__half operator*(const __half&, const __half&)’
  618 | __CUDA_HOSTDEVICE__ __forceinline__ __half operator*(const __half &lh, const __half &rh) { return __hmul(lh, rh); }
      |                                            ^~~~~~~~
In file included from /home/kevin/code/thirdparty/cudnn-frontend/samples/test_list.cpp:27:
/home/kevin/code/thirdparty/cudnn-frontend/samples/cpu_references.h: In instantiation of ‘void scale_and_bias_tensor_cpu(const inputType*, outputType*, const scale_bias_type*, const scale_bias_type*, int64_t, const int64_t*) [with inputType = __half; scale_bias_type = float; outputType = float; int64_t = long int]’:
/home/kevin/code/thirdparty/cudnn-frontend/samples/test_list.cpp:1560:50:   required from here
/home/kevin/code/thirdparty/cudnn-frontend/samples/cpu_references.h:128:38: error: ambiguous overload for ‘operator*’ (operand types are ‘const __half’ and ‘const float’)
  128 |         outputData[i] = inputData[i] * scaleData[c] + biasData[c];
      |                         ~~~~~~~~~~~~~^~~~~~~~~~~~
/home/kevin/code/thirdparty/cudnn-frontend/samples/cpu_references.h:128:38: note: candidate: ‘operator*(int, float)’ (built-in)
/home/kevin/code/thirdparty/cudnn-frontend/samples/cpu_references.h:128:38: note: candidate: ‘operator*(long long unsigned int, float)’ (built-in)
/home/kevin/code/thirdparty/cudnn-frontend/samples/cpu_references.h:128:38: note: candidate: ‘operator*(long long int, float)’ (built-in)
/home/kevin/code/thirdparty/cudnn-frontend/samples/cpu_references.h:128:38: note: candidate: ‘operator*(long unsigned int, float)’ (built-in)
/home/kevin/code/thirdparty/cudnn-frontend/samples/cpu_references.h:128:38: note: candidate: ‘operator*(long int, float)’ (built-in)
/home/kevin/code/thirdparty/cudnn-frontend/samples/cpu_references.h:128:38: note: candidate: ‘operator*(unsigned int, float)’ (built-in)
/home/kevin/code/thirdparty/cudnn-frontend/samples/cpu_references.h:128:38: note: candidate: ‘operator*(float, float)’ (built-in)
In file included from /usr/local/cuda/include/cuda_fp16.h:4070,
                 from /home/kevin/code/thirdparty/cudnn-frontend/samples/fp16_emu.h:28,
                 from /home/kevin/code/thirdparty/cudnn-frontend/samples/fp16_dev.h:27,
                 from /home/kevin/code/thirdparty/cudnn-frontend/samples/helpers.h:36,
                 from /home/kevin/code/thirdparty/cudnn-frontend/samples/cpu_references.h:25,
                 from /home/kevin/code/thirdparty/cudnn-frontend/samples/test_list.cpp:27:
/usr/local/cuda/include/cuda_fp16.hpp:618:44: note: candidate: ‘__half operator*(const __half&, const __half&)’
  618 | __CUDA_HOSTDEVICE__ __forceinline__ __half operator*(const __half &lh, const __half &rh) { return __hmul(lh, rh); }
      |                                            ^~~~~~~~
In file included from /home/kevin/code/thirdparty/cudnn-frontend/samples/test_list.cpp:27:
/home/kevin/code/thirdparty/cudnn-frontend/samples/cpu_references.h: In instantiation of ‘void gen_stats_cpu(const T_ELEM*, std::vector<std::pair<float, float> >&, int64_t, const int64_t*) [with T_ELEM = __half; int64_t = long int]’:
/home/kevin/code/thirdparty/cudnn-frontend/samples/test_list.cpp:1650:24:   required from here
/home/kevin/code/thirdparty/cudnn-frontend/samples/cpu_references.h:169:75: error: ambiguous overload for ‘operator+’ (operand types are ‘float’ and ‘const __half’)
  169 |         outputData[channel_index].first = outputData[channel_index].first + inputData[i];
/home/kevin/code/thirdparty/cudnn-frontend/samples/cpu_references.h:169:75: note: candidate: ‘operator+(float, int)’ (built-in)
/home/kevin/code/thirdparty/cudnn-frontend/samples/cpu_references.h:169:75: note: candidate: ‘operator+(float, long long unsigned int)’ (built-in)
/home/kevin/code/thirdparty/cudnn-frontend/samples/cpu_references.h:169:75: note: candidate: ‘operator+(float, long long int)’ (built-in)
/home/kevin/code/thirdparty/cudnn-frontend/samples/cpu_references.h:169:75: note: candidate: ‘operator+(float, long unsigned int)’ (built-in)
/home/kevin/code/thirdparty/cudnn-frontend/samples/cpu_references.h:169:75: note: candidate: ‘operator+(float, long int)’ (built-in)
/home/kevin/code/thirdparty/cudnn-frontend/samples/cpu_references.h:169:75: note: candidate: ‘operator+(float, unsigned int)’ (built-in)
/home/kevin/code/thirdparty/cudnn-frontend/samples/cpu_references.h:169:75: note: candidate: ‘operator+(float, float)’ (built-in)
In file included from /usr/local/cuda/include/cuda_fp16.h:4070,
                 from /home/kevin/code/thirdparty/cudnn-frontend/samples/fp16_emu.h:28,
                 from /home/kevin/code/thirdparty/cudnn-frontend/samples/fp16_dev.h:27,
                 from /home/kevin/code/thirdparty/cudnn-frontend/samples/helpers.h:36,
                 from /home/kevin/code/thirdparty/cudnn-frontend/samples/cpu_references.h:25,
                 from /home/kevin/code/thirdparty/cudnn-frontend/samples/test_list.cpp:27:
/usr/local/cuda/include/cuda_fp16.hpp:606:44: note: candidate: ‘__half operator+(const __half&, const __half&)’
  606 | __CUDA_HOSTDEVICE__ __forceinline__ __half operator+(const __half &lh, const __half &rh) { return __hadd(lh, rh); }
      |                                            ^~~~~~~~
In file included from /home/kevin/code/thirdparty/cudnn-frontend/samples/test_list.cpp:27:
/home/kevin/code/thirdparty/cudnn-frontend/samples/cpu_references.h:182:37: error: ambiguous overload for ‘operator-’ (operand types are ‘const __half’ and ‘float’)
  182 |         T_ELEM diff = (inputData[i] - outputData[channel_index].first) * (inputData[i] - outputData[channel_index].first);
      |                       ~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/kevin/code/thirdparty/cudnn-frontend/samples/cpu_references.h:182:37: note: candidate: ‘operator-(int, float)’ (built-in)
/home/kevin/code/thirdparty/cudnn-frontend/samples/cpu_references.h:182:37: note: candidate: ‘operator-(long long unsigned int, float)’ (built-in)
/home/kevin/code/thirdparty/cudnn-frontend/samples/cpu_references.h:182:37: note: candidate: ‘operator-(long long int, float)’ (built-in)
/home/kevin/code/thirdparty/cudnn-frontend/samples/cpu_references.h:182:37: note: candidate: ‘operator-(long unsigned int, float)’ (built-in)
/home/kevin/code/thirdparty/cudnn-frontend/samples/cpu_references.h:182:37: note: candidate: ‘operator-(long int, float)’ (built-in)
/home/kevin/code/thirdparty/cudnn-frontend/samples/cpu_references.h:182:37: note: candidate: ‘operator-(unsigned int, float)’ (built-in)
/home/kevin/code/thirdparty/cudnn-frontend/samples/cpu_references.h:182:37: note: candidate: ‘operator-(float, float)’ (built-in)
In file included from /usr/local/cuda/include/cuda_fp16.h:4070,
                 from /home/kevin/code/thirdparty/cudnn-frontend/samples/fp16_emu.h:28,
                 from /home/kevin/code/thirdparty/cudnn-frontend/samples/fp16_dev.h:27,
                 from /home/kevin/code/thirdparty/cudnn-frontend/samples/helpers.h:36,
                 from /home/kevin/code/thirdparty/cudnn-frontend/samples/cpu_references.h:25,
                 from /home/kevin/code/thirdparty/cudnn-frontend/samples/test_list.cpp:27:
/usr/local/cuda/include/cuda_fp16.hpp:612:44: note: candidate: ‘__half operator-(const __half&, const __half&)’
  612 | __CUDA_HOSTDEVICE__ __forceinline__ __half operator-(const __half &lh, const __half &rh) { return __hsub(lh, rh); }
      |                                            ^~~~~~~~
In file included from /home/kevin/code/thirdparty/cudnn-frontend/samples/test_list.cpp:27:
/home/kevin/code/thirdparty/cudnn-frontend/samples/cpu_references.h:182:88: error: ambiguous overload for ‘operator-’ (operand types are ‘const __half’ and ‘float’)
  182 |         T_ELEM diff = (inputData[i] - outputData[channel_index].first) * (inputData[i] - outputData[channel_index].first);
      |                                                                          ~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/kevin/code/thirdparty/cudnn-frontend/samples/cpu_references.h:182:88: note: candidate: ‘operator-(int, float)’ (built-in)
/home/kevin/code/thirdparty/cudnn-frontend/samples/cpu_references.h:182:88: note: candidate: ‘operator-(long long unsigned int, float)’ (built-in)
/home/kevin/code/thirdparty/cudnn-frontend/samples/cpu_references.h:182:88: note: candidate: ‘operator-(long long int, float)’ (built-in)
/home/kevin/code/thirdparty/cudnn-frontend/samples/cpu_references.h:182:88: note: candidate: ‘operator-(long unsigned int, float)’ (built-in)
/home/kevin/code/thirdparty/cudnn-frontend/samples/cpu_references.h:182:88: note: candidate: ‘operator-(long int, float)’ (built-in)
/home/kevin/code/thirdparty/cudnn-frontend/samples/cpu_references.h:182:88: note: candidate: ‘operator-(unsigned int, float)’ (built-in)
/home/kevin/code/thirdparty/cudnn-frontend/samples/cpu_references.h:182:88: note: candidate: ‘operator-(float, float)’ (built-in)
In file included from /usr/local/cuda/include/cuda_fp16.h:4070,
                 from /home/kevin/code/thirdparty/cudnn-frontend/samples/fp16_emu.h:28,
                 from /home/kevin/code/thirdparty/cudnn-frontend/samples/fp16_dev.h:27,
                 from /home/kevin/code/thirdparty/cudnn-frontend/samples/helpers.h:36,
                 from /home/kevin/code/thirdparty/cudnn-frontend/samples/cpu_references.h:25,
                 from /home/kevin/code/thirdparty/cudnn-frontend/samples/test_list.cpp:27:
/usr/local/cuda/include/cuda_fp16.hpp:612:44: note: candidate: ‘__half operator-(const __half&, const __half&)’
  612 | __CUDA_HOSTDEVICE__ __forceinline__ __half operator-(const __half &lh, const __half &rh) { return __hsub(lh, rh); }
      |                                            ^~~~~~~~
In file included from /home/kevin/code/thirdparty/cudnn-frontend/samples/test_list.cpp:27:
/home/kevin/code/thirdparty/cudnn-frontend/samples/cpu_references.h:183:77: error: ambiguous overload for ‘operator+’ (operand types are ‘float’ and ‘__half’)
  183 |         outputData[channel_index].second = outputData[channel_index].second + diff;
/home/kevin/code/thirdparty/cudnn-frontend/samples/cpu_references.h:183:77: note: candidate: ‘operator+(float, int)’ (built-in)
/home/kevin/code/thirdparty/cudnn-frontend/samples/cpu_references.h:183:77: note: candidate: ‘operator+(float, long long unsigned int)’ (built-in)
/home/kevin/code/thirdparty/cudnn-frontend/samples/cpu_references.h:183:77: note: candidate: ‘operator+(float, long long int)’ (built-in)
/home/kevin/code/thirdparty/cudnn-frontend/samples/cpu_references.h:183:77: note: candidate: ‘operator+(float, long unsigned int)’ (built-in)
/home/kevin/code/thirdparty/cudnn-frontend/samples/cpu_references.h:183:77: note: candidate: ‘operator+(float, long int)’ (built-in)
/home/kevin/code/thirdparty/cudnn-frontend/samples/cpu_references.h:183:77: note: candidate: ‘operator+(float, unsigned int)’ (built-in)
/home/kevin/code/thirdparty/cudnn-frontend/samples/cpu_references.h:183:77: note: candidate: ‘operator+(float, float)’ (built-in)
In file included from /usr/local/cuda/include/cuda_fp16.h:4070,
                 from /home/kevin/code/thirdparty/cudnn-frontend/samples/fp16_emu.h:28,
                 from /home/kevin/code/thirdparty/cudnn-frontend/samples/fp16_dev.h:27,
                 from /home/kevin/code/thirdparty/cudnn-frontend/samples/helpers.h:36,
                 from /home/kevin/code/thirdparty/cudnn-frontend/samples/cpu_references.h:25,
                 from /home/kevin/code/thirdparty/cudnn-frontend/samples/test_list.cpp:27:
/usr/local/cuda/include/cuda_fp16.hpp:606:44: note: candidate: ‘__half operator+(const __half&, const __half&)’
  606 | __CUDA_HOSTDEVICE__ __forceinline__ __half operator+(const __half &lh, const __half &rh) { return __hadd(lh, rh); }
      |                                            ^~~~~~~~
In file included from /home/kevin/code/thirdparty/cudnn-frontend/samples/test_list.cpp:27:
/home/kevin/code/thirdparty/cudnn-frontend/samples/cpu_references.h: In instantiation of ‘void batch_normalize(const T_ELEM*, T_ELEM*, const std::vector<std::pair<float, float> >&, int64_t, const int64_t*) [with T_ELEM = __half; int64_t = long int]’:
/home/kevin/code/thirdparty/cudnn-frontend/samples/test_list.cpp:1652:26:   required from here
/home/kevin/code/thirdparty/cudnn-frontend/samples/cpu_references.h:204:39: error: ambiguous overload for ‘operator-’ (operand types are ‘const __half’ and ‘const float’)
  204 |         outputData[i] = (inputData[i] - stats[batch_index].first) / (T_ELEM) std::sqrt(stats[batch_index].second);
      |                         ~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/kevin/code/thirdparty/cudnn-frontend/samples/cpu_references.h:204:39: note: candidate: ‘operator-(int, float)’ (built-in)
/home/kevin/code/thirdparty/cudnn-frontend/samples/cpu_references.h:204:39: note: candidate: ‘operator-(long long unsigned int, float)’ (built-in)
/home/kevin/code/thirdparty/cudnn-frontend/samples/cpu_references.h:204:39: note: candidate: ‘operator-(long long int, float)’ (built-in)
/home/kevin/code/thirdparty/cudnn-frontend/samples/cpu_references.h:204:39: note: candidate: ‘operator-(long unsigned int, float)’ (built-in)
/home/kevin/code/thirdparty/cudnn-frontend/samples/cpu_references.h:204:39: note: candidate: ‘operator-(long int, float)’ (built-in)
/home/kevin/code/thirdparty/cudnn-frontend/samples/cpu_references.h:204:39: note: candidate: ‘operator-(unsigned int, float)’ (built-in)
/home/kevin/code/thirdparty/cudnn-frontend/samples/cpu_references.h:204:39: note: candidate: ‘operator-(float, float)’ (built-in)
In file included from /usr/local/cuda/include/cuda_fp16.h:4070,
                 from /home/kevin/code/thirdparty/cudnn-frontend/samples/fp16_emu.h:28,
                 from /home/kevin/code/thirdparty/cudnn-frontend/samples/fp16_dev.h:27,
                 from /home/kevin/code/thirdparty/cudnn-frontend/samples/helpers.h:36,
                 from /home/kevin/code/thirdparty/cudnn-frontend/samples/cpu_references.h:25,
                 from /home/kevin/code/thirdparty/cudnn-frontend/samples/test_list.cpp:27:
/usr/local/cuda/include/cuda_fp16.hpp:612:44: note: candidate: ‘__half operator-(const __half&, const __half&)’
  612 | __CUDA_HOSTDEVICE__ __forceinline__ __half operator-(const __half &lh, const __half &rh) { return __hsub(lh, rh); }
      |                                            ^~~~~~~~
g

Thanks for raising this.
This has been fixed in v0.9.2 release.
The root cause of the regression, is a nvcc update to how it handles fp16 type.
Let me know if you are still seeing the issue.

the issue is solved! thanks for the quick fix


How to rotate an image around the center with canvas

I am trying to implement image scaling and rotation with flutter canvas api using custom painter. The scale is achieved but unable to rotate the image on its center, the default rotate is on its top left corner.
I have also tried to translate and rotate and translate back but no success.
The same questions is also asked on SO here. here is my try gist

Closing as SO answer is accepted https://stackoverflow.com/a/54336099/12268368


When Linnstrument runs out of power when using a portable battery pack in sleep mode, it requires a firmware update to be fixed

This has happened a couple of times to me. I occasionally power a Linnstrument using a USB 5V power pack. Sometimes, I will put it into sleep mode and walk away.
If the battery pack runs out of power, I'm unable to power the Linnstrument on even when unplugging it and plugging it into another powered source like a computer USB port. However, it is recognized by the firmware updater, and I can update it and recalibrate it to restore functionality.
This is a problem because it means that if I leave my Linnstrument plugged into power and it runs out of battery, I can't use it unless I get to a computer and update its firmware.

We're already doing everything we can to prevent the instrument from booting up when flash gets corrupted. When your battery pack runs out, the required voltage can drop and prevent the instrument from proper operation. We don't recommend powering LinnStrument with an insufficient power source.


Chest luck boosters

This is probably going to be hard to implement, but a system where you can buy certain boosts that up your chance of getting good items from chests, and increases the amount of items you get. This could be added in the boosts section of the store or in a new section.

yeah i have a pretty simple idea for it
basically on how the current boost system works, we can just add some multiplier argument

alright, sounds good


Fix false-positive alert re: unsuccessful traffic

This alert keeps firing and I believe it's a false-positive.  We should clean up the alert, but also the underlying metrics that are causing this to go off - I believe there are many things being reported as error in scrappy unnecessarily.

I updated the alert and I will watch over that!


feat(sbb-icon): introduce sbb-icon component

Preflight Checklist

[x] I have read the Contributing Guidelines for this project.
[x] I agree to follow the Code of Conduct that this project adheres to.
[x] I have searched the pull request tracker for a Pull Request (PR) that matches the one I want to submit, without success.

Issue
This PR Closes #1086
Pull request checklist
Please check if your PR fulfills the following requirements:

[x] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been reviewed and added / updated if needed (for bug fixes / features)
[x] Build (npm run build) was run locally and any changes were pushed
[x] Lint (npm run lint) has passed locally and any fixes were made for failures

Changes
Changes in this pull request:
Introduce icon component
Browsers
I tested the build on the following browsers:

[x] Firefox Desktop
[x] Chrome Desktop
[x] Safari Desktop
[x] Firefox Mobile
[x] Chrome Mobile
[x] Safari Mobile
[x] Opera
[ ] Brave

Pull request type

Please check the type of change your PR introduces:

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

Does this introduce a breaking change?

[ ] Yes
[x] No

Other information

Codecov Report

Merging #1286 (e343c8f) into master (7a0d8d7) will increase coverage by 1.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1286      +/-   ##
==========================================
+ Coverage   53.77%   54.85%   +1.07%
==========================================
  Files          49       49
  Lines        1733     1659      -74
  Branches      490      406      -84
==========================================
- Hits          932      910      -22
+ Misses        708      671      -37
+ Partials       93       78      -15

Impacted Files
Coverage Δ

src/global/core/components/overlay/overlay.tsx
0.00% <0.00%> (ø)

...obal/core/components/overlay/overlay-component.tsx
0.00% <0.00%> (ø)

src/components/lyne-image/lyne-image.tsx

src/components/lyne-text-input/lyne-text-input.tsx

src/components/lyne-image/lyne-image.helper.tsx

src/components/lyne-footer/lyne-footer.tsx

...ble-park-and-rail/lyne-timetable-park-and-rail.tsx

src/components/lyne-button/lyne-button.tsx

src/components/lyne-panel/lyne-panel.tsx

...table-barrier-free/lyne-timetable-barrier-free.tsx

... and 75 more

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more


Schedule GC to bottom priority pool

Schedule GC tasks to bottom priority thread pool so that we can distinguish them from compaction jobs which are in low priority pool.

Codecov Report

Merging #38 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #38      +/-   ##
==========================================
- Coverage   84.12%   84.12%   -0.01%
==========================================
  Files          43       43
  Lines        2577     2576       -1
==========================================
- Hits         2168     2167       -1
  Misses        409      409


Fixed 'Using Secrets' link in Secrets Management > HashiCorp Vault > Overview

Fixes #76
Before:

After:

Closing this PR since it has already been updated in the documentation.


Fix Undefined index: exclude_colors notice/error

Summary
If exclude_colors is not set when using ACF Builder/Composer the admin errors and never loads the ACF Block settings.
Error: Undefined index: exclude_colors
...
plugins/acf-editor-palette/src/Field.php78

It's possible to work around this by adding the exclude config to sage10/acf-composer defaults ie:
# sage/app/config/acf.php

'defaults' => [
    'select'           => ['ui' => 1],
    ...
    'editor_palette'   => ['return_format' => 'slug', 'exclude_colors' => []],
];

Or add it to each field config:
$field->addField('my_color_field', 'editor_palette', [
    'exclude_colors', []
]);

I think it might just be a syntax error on my part. I can't check right now, but try simply changing $field['exclude_colors'] ?: [] to $field['exclude_colors'] ?? []
if that works edit your PR and I'll merge. <3

I think it might just be a syntax error on my part. I can't check right now, but try simply changing $field['exclude_colors'] ?: [] to $field['exclude_colors'] ?? []
if that works edit your PR and I'll merge. <3

yup, that did the trick - nice one!

yup, that did the trick - nice one!

just going to rewind the commits, to neaten this up

just going to rewind the commits, to neaten this up


Ubuntu 18.04 is out of support

The document says that Ubuntu 18.04 is required.  That OS is now out of support.  Will a newer version, like 22, work?

To which article is this question referring?

Fair question.  Enable SQL Insights.  In the Azure Virtual Machine Requirements section, first bullet point.
Sorry about leaving that out.

Thanks for your feedback, @PwshPally.
This issue is related to https://github.com/MicrosoftDocs/azure-docs/issues/110231, so I'm repeating my comments from there below.

Since SQL Insights is a preview feature, it may have "limited or restricted functionality". In this particular case, that is limited to Ubuntu 18.04 support.
As a reminder, preview features aren't meant for production use.
While this is not the answer you were asking for, that is all we can say from a Docs perspective.


Do a New OneSearch Accessibility Review

Coordinate with Mike Williamson. See email "Usability Test of Library Search Page"

Rough draft. Need input from Discovery Pod, CDAR.

Emailed to Mike for review.


[SPARK-21271][SQL] Ensure Unsafe.sizeInBytes is a multiple of 8

What changes were proposed in this pull request?
This PR ensures that Unsafe.sizeInBytes must be a multiple of 8. It it is not satisfied. Unsafe.hashCode causes the assertion violation.
How was this patch tested?
Will add test cases

Test build #79042 has started for PR 18503 at commit eb87c63.

Test build #79042 has finished for PR 18503 at commit eb87c63.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79042/
Test FAILed.

Test build #79048 has started for PR 18503 at commit ccc820f.

Test build #79048 has finished for PR 18503 at commit ccc820f.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79048/
Test FAILed.

@cloud-fan I believe that this failure occurs since the checkpoint file does not have a value record whose size is not a multiple of 8 (i.e. 28).
We can solve this failure by regenerating these files. However, the root issue is that checkpoint files, whose size may not be a multiple of 8, exist in the production environment. Should we resize the value record size for UnsafeRow to a multiple of 8 if it is not a multiple of 8?
What do you think?

Test build #79214 has started for PR 18503 at commit 8a7a948.

Test build #79214 has finished for PR 18503 at commit 8a7a948.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79214/
Test PASSed.

Merged build finished. Test PASSed.

Test build #79583 has started for PR 18503 at commit 7f5a269.

Test build #79583 has finished for PR 18503 at commit 7f5a269.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79583/
Test PASSed.

This PR we changed FixedLengthRowBasedKeyValueBatch, I want to know if it has some external impacts, like checkpoint data, or it's just used internally?

@tdas @marmbrus @zsxwing could you please let us know any impacts by change of FixedLengthRowBasedKeyValueBatch? Can we change this structure?

Test build #79770 has started for PR 18503 at commit 762f02a.

Test build #79770 has finished for PR 18503 at commit 762f02a.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79770/
Test PASSed.

Test build #79924 has started for PR 18503 at commit 0159701.

Test build #79924 has finished for PR 18503 at commit 0159701.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79924/
Test FAILed.

Merged build finished. Test FAILed.

Test build #79929 has started for PR 18503 at commit 54be80e.

Test build #79929 has finished for PR 18503 at commit 54be80e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79929/
Test PASSed.

Merged build finished. Test PASSed.

LGTM, pending tests

Test build #79956 has started for PR 18503 at commit cc467de.

Test build #79956 has finished for PR 18503 at commit cc467de.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79956/
Test FAILed.

retest this please

Test build #79969 has started for PR 18503 at commit cc467de.

@cloud-fan @kiszk thanks for confirming. LGTM pending tests.

Test build #79969 has finished for PR 18503 at commit cc467de.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79969/
Test PASSed.

Merged build finished. Test PASSed.

thanks, merging to master!


Rename colors to be consistent

Naming (0, 255, 0) "Bright Green" is inconsistent with the other primary and secondary colors of Red, Blue, Yellow, Cyan, etc. in the sRGB color space.

That had actually been bothering me too.


3D Cameras

An optical instrument that provices a 3D reading about the environment. I differentiate three types: Depth sensor, Stereo camera and ToF camera. As they have been categorized according the hardware each one as to have its own Specs<device_name>.msg.
Create:

[x] SpecsDepthSensor.msg

[x] SpecsStereoCamera.msg

[x] SpecsToFCamera.msg

Update.


GAT Link prediction for inductive learning

GAT link prediction on unseen nodes
Hi! I am trying to implement link prediction based on GAT and predict unseen nodes (Inductive learning). While I can successfully run a link prediction using GAT on the network with the same number of nodes, when new nodes come, it can not work properly. I am wondering whether this is caused by the GAT link generator (FullBatchLinkGenerator)
The code: (notice train and test networks have different number of nodes)
`                        train_gen = FullBatchLinkGenerator(G_train,method="gat")
test_gen = FullBatchLinkGenerator(G_test,method="gat")
                    gat = GAT(layer_sizes=[8, 4],
                    activations=["elu", "softmax"],
                    attn_heads=8,
                    bias = True,
                    generator=train_gen,
                    in_dropout=0.5,
                    attn_dropout=0.5,
                    normalize=None)

                    x_inp, x_out = gat.in_out_tensors()

                    prediction = LinkEmbedding(activation="relu",method ="ip")(x_out)
                    prediction = keras.layers.Reshape((-1,))(prediction)

                    #Train tf model for classification
                    model = keras.Model(inputs=x_inp, outputs=prediction)

                    model.compile(optimizer=keras.optimizers.Adam(lr=1e-3), loss=keras.losses.binary_crossentropy, metrics=[keras.metrics.AUC()])

                    init_train_metrics = model.evaluate(train_gen.flow(edge_ids_train,edge_labels_train))
                    init_test_metrics = model.evaluate(test_gen.flow(edge_ids_test, edge_labels_test))`

The error occurs when evaluating the model:

Cannot multiply A and B because inner dimension does not match: 387 vs. 403.  Did you forget a transpose?  Dimensions of A: [387, 387).  Dimensions of B: [403,8]

Screenshots:

This problem also occurred when I used the GCN and SAGE models, and it seemed that the internal structure of the function was set up incorrectly...


The hiding of Script Editor when selecting node in Scene Tree

I just discovered a function called can_lose_focus_on_node_selection() in ScriptEditorPlugin class. It returns false for VisualScript editor and true for other script editors. When it's true, clicking a node in Scene Tree will change the viewport to this node's native (i.e. 2D or 3D). Before the function was introduced, Godot would switch away from Script Editor unconditionally.
Now, I've seen an issue where this behavior was labeled as a bug: #14862
There's also #33704, which is related
EDIT: Another old issue: #20676 (this time enhancement)
The question is: is this behavior useful? Many users will probably agree that if you are in the Script Editor, you want to click nodes in Scene Tree without hiding the Script Editor (some people want e.g. to check them in the inspector). Personally I don't see why would we want to switch on click, other than it being maybe faster than clicking the 2D/3D button on the top.
I opened this issue to discuss this problem. We could either:

leave the behavior as it is (which means #14862 should be closed and #33704 fixed properly)
remove this behavior (would close both of these issues, and probably some others)
make it optional editor setting (should be easy, by reading the setting in the can_lose_focus_on_node_selection() method)
change it to switch double-click or something similar

Any thoughts?

I prefer option 2. For me this behaviour was always counter-intuitive and it happens quite frequently. It's maybe one click more, if we want to change the view, but it's a logical click that makes sense, whereas the current behaviour can be quite irritating, because in a lot of scenarios it's just doing additional stuff you did not intent and you find your self fighting with it and having to go back manualy again.
It happend to me both, when I wanted to look at a property or property path of a node or when I tried to drag and drop the node path into the text editor.
I don't think there should be an option for it, as I don't like bloated editor settings. For me the proposed solution ( in #14862) of using a doubleclick for the current behaviour would make more sense.
Fixing this behaviour would be very appreciated. Thanks!

Ah yes, I forgot that there's a 4th option actually.

Then I'm for option 4!

I think the double-click option makes the most sense too.

Isnt double-click triggering node rename?

Could give rename a default keybinding and make double clicking the node show it in the scene in one way or another.  Also, double clicking on the icon to teleport the camera to it is pretty unintuitive and hard to find if you don't know about it already.

Could give rename a default keybinding

This is done by #38201, but it seems some users still prefer double-clicking nodes to rename them instead of pressing F2 (perhaps because they don't know about this shortcut in general).

It may be worth keeping in mind that F2 to rename has very DOS/Windows-centric origins...
Assuming that people using Macs keep the default keyboard settings, F2 will be brightening their screen unless they also hold the fn keys.
I'm definitely in favour of not unintentionally switching away from the Script Editor though. :)

I'm for option 2. If you are in the script editor and you click on a node, I think the behaviour should be to show that node in the inspector and stay in the script editor, because if you are in the script editor... well... you are working on scripts, and thats what you want to do. If you want to see the 2D/3D representation, just click on the 2D/3D buttons at the top to switch. I dont think there should be a shortcut to get there in the scene tree, apart from maybe a right click > go to node in viewport or similar.

Maybe Shift+Click to avoid changing context?

More like Alt+Click, Shift is used for multiselecting. But sounds like a good option.

I think not changing context should be the default. Changing context should require a modifier like Alt instead.

After #55761 was merged, you can now hold Alt while clicking in the scene tree to prevent the viewport from switching. This resolves the issue, but just isn't very discoverable.

@KoBeWi is #40438 obsolete then?

Probably yes. As for the issue, I recently seen someone mention an alternative solution. Instead of using a random modifier, the editor could switch only after release/long press of the button and don't switch when you drag. If that could work then it would be better, as there is no use in only selecting a node without focusing; you always want to drag it.

and don't switch when you drag

Pretty please :)

Maybe a pin/lock can help too (animationplayer has one, for example), for script editor and 2d/3d viewports, sometimes you just want to see an item in the inspector, drag and drop, etc. without changing the main view.

I would really like to stay on the script I'm editing when I hit the Play button. I really have no clue why it would switch to the 2D view.

After #55761 was merged, you can now hold Alt while clicking in the scene tree to prevent the viewport from switching. This resolves the issue, but just isn't very discoverable.

Does not work on macOS on 4.2 beta

It was removed. Editor will automatically detect whether you are dragging or not and switch if not.

It was removed. Editor will automatically detect whether you are dragging or not and switch if not.

my bad, but the issue still persists, if I want to change different inspector values while using the viewport, since in a 3D view the viewport disables the 2D and when the editor toggles you basically get an empty screen

Sure, some explanation - in the video I'm testing if adjusting the scale would work for my indicator, before writing the code and this is when I hit this annoying issue
https://github.com/godotengine/godot/assets/97624560/11c763eb-1522-4531-8f04-44c260668cea

That's another issue, see https://github.com/godotengine/godot-proposals/issues/8150


Contact Form for Reach Out Section

Contact Form for Reach Out Section
Content Requirements:

Heading: "Contact Us"
Name: Input Text field
Message: Large message area.

Completed.


I'm confused. Can't install curl, can't install gflib

Start with vcpkg upgrade (and vcpkg upgrade --no-dry-run).

Start with vcpkg upgrade (and vcpkg upgrade --no-dry-run).

did that

And still there is something outdated here.
vcpkg remove --recurse vcpkg-cmake
git pull
vcpkg install --no-binarycaching vcpkg-cmake

And still there is something outdated here.
vcpkg remove --recurse vcpkg-cmake
git pull
vcpkg install --no-binarycaching vcpkg-cmake

I ran this and still got the error.

Please run the following command:
git pull https://github.com/microsoft/vcpkg.git master
./bootstrap-vcpkg.bat
./vcpkg upgrade --no-dry-run

Please run the following command:
git pull https://github.com/microsoft/vcpkg.git master
./bootstrap-vcpkg.bat
./vcpkg upgrade --no-dry-run

did it

ran the commands and still got the errors:

Hm, why doesn't the upgrade command fix your installation?
vcpkg remove --recurse vcpkg-cmake-config
vcpkg install --no-binarycaching vcpkg-cmake-config

Hm, why doesn't the upgrade command fix your installation?
vcpkg remove --recurse vcpkg-cmake-config
vcpkg install --no-binarycaching vcpkg-cmake-config

ok ok so some progress was made. I think curl worked. But now there is a new error (I have absolutely no clue what is going on)

Well, maybe you removed (some) installed files manually? You can always start with a fresh directory, but you must remove installed completely.

Well, maybe you removed (some) installed files manually? You can always start with a fresh directory, but you must remove installed completely.

how do i do that ?

Delete the installed/ folder under the vcpkg/ directory and try the installation again.
Or re-clone vcpkg and start:
git clone https://github.com/microsoft/vcpkg.git
.\bootstrap-vcpkg.bat
.\vcpkg install ...

Contributor

oh wow. It worked. Thank you all.

This issue will be closed soon.


Implement popfirst!?

Would it be possible to have a popfirst! implementation? This package nearly meets my needs, but I want to pop the oldest value instead of the newest value (more like queue).

@JuliaRegistrator register

Registration pull request created: JuliaRegistries/General/55498
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.1.5 -m "<description of version>" 1eb93874b53dcc62766bd6c42a77e1645ffe52f8
git push origin v0.1.5


New features oriented to improve index procedure efficiency

During indexing, all we need are the node properties from Neo4j directly AND a few on_read_trigger generated ones. But the current GET /entitites/<id> returns ALL trigger generated properties, totally inefficient and unnecessary. And the index procedure has to remove the ones that are not specified in the mapping json with lots of for loops, such repetitive work is a total waste of time and further reduces the efficiency.
To address the above issues in the entity-api,

Introduce a new trigger type: on_index_trigger, which has the same trigger method as regular on_read_trigger.
Add a specialized schema_manager method get_complete_document_result() which is very similar to get_complete_entity_result() (for now do NOT modify this method), but uses on_index_trigger instead.
For caching, use a different prefix on those index data, cache_key = f'{_memcached_prefix}_complete_index_{entity_uuid}'
Introduce a new flag in schema yaml indexed: false (default is true) for indexing purposes. This allows us to remove the use of json mapping in search-api. When exposed: false there's no need to check this indexed: false since it's a field won't be exposed by entity-api. When there's only indexed: false it means this field still gets returned to the regular GET call, but we won't index this field.
Add a specialized schema_manager method normalize_document_result_for_response() based on the current normalize_entity_result_for_response() and integrate with the indexed flag.

Afterwards, create a specialized endpoint (based on the current GET /entities/<id> but with no property filtering needed): GET /documents/<id> which returns a subset of the regular entity json to be used for index, without including the following generated fields (not used by index process):

Donor: None, since no on_read_trigger
Sample: direct_ancestor
Dataset/Publication (including revisions): collections, upload, direct_ancestors, local_directory_rel_path
Publication-specific: associated_collection (still need this field to be indexed)

AFTER the new features get tested, switch to use this new endpoint in search-api: https://github.com/hubmapconsortium/search-api/issues/756
Related HM card: https://github.com/hubmapconsortium/entity-api/issues/630
Related PRs:
https://github.com/hubmapconsortium/entity-api/commit/2b34a0fcc645b9a4e7126684d4e331eaee78a1c4#diff-cd8a3bff2418f86ca995d983b9e0d2ed942f3a2a10b8eb393b15f18f56ea3fb4
https://github.com/hubmapconsortium/entity-api/pull/696/files#diff-04791d82dd15fdd480f084d7ef65a10789fa5012cb7935f76080763444d48a00

This is directly related to #334


How should I get the order from the OrderItem ?

Hi,
I'm trying to get the Order from an OrderItem but I don't see
a belongsTo relation on the OrderItem.
Only orderable and owner.  Maybe we should add it?
Thanks!

Sure, feel free to send in a PR.

#92

#92 Merged into develop. Thanks @larsjanssen6 !


Add numeric nulls to sample data, fix some numeric null handling issues

Fixed #9140
This PR fixes a bug with the LongSumAggregator's comparator, where it did not account for nulls.
It adds three new numeric columns with some null values to the sample TSV files used in TestIndex and a set of 3 tests in TopNQueryRunnerTest.
Additionally:

As the sample data has been updated with new columns, this PR also updates other query-related tests with the NullHandling initialization and other test adjustments.
Updates SearchQueryRunner to call selector.isNull() in its numeric column selectors since the search query tests were failing on the new sample data columns
Refactors ScanQueryRunnerTest so that it reads its sample data from the common resource TSV file instead of replicating the data within the test for its main test data (some tests still use test-specific data)

This PR has:

[x] been self-reviewed.
[x] added unit tests or modified existing tests to cover new code paths.

@clintropolis @jihoonson Pushed a new update with the following:

As the sample data has been updated with new columns, this PR also updates other query-related tests with the NullHandling initialization and other test adjustments.
Updates SearchQueryRunner to call selector.isNull() in its numeric column selectors since the search query tests were failing on the new sample data columns

The latest update to this PR also fixes an issue with the getObject() method for ColumnValueSelector created by the numeric *DimensionIndexer implementations, where the method didn't account for null handling default values.
Update the PR title to reflect that this PR fixes multiple numeric null handling issues.


Race condition with VSpaceCode comma binding (whichkey.triggerKey)

Bug description
It looks like the default , binding of VSpaceCode works by opening vscode-which-key, and then (probably asynchronously) sending the m key to it. However, when typing quickly, this can result in a race condition between what which-key does internally and what the user types.
To Reproduce

Open a .tex file (or presumably, any other file with a x binding for "text")
Press ,
Press x very quickly

(Alternatively, on Linux/X11, run sleep 1; xdotool type ,x and then switch focus to VS Code)
Expected behavior
Ending up in the "Text" menu:

Screenshots
Ending up in the "Merge conflict" menu:

Additional context
The merge conflict menu is bound to SPC x m, so pressing , x ended up being interpreted as SPC x m rather than SPC m x.
Keybindings
Essentially the default recommended in the VSpaceCode readme:
Click to toggle contents of `keybindinds.json`

[
    // https://github.com/VSpaceCode/VSpaceCode/blob/master/src/configuration/keybindings.jsonc

    // Trigger vspacecode in empty editor group
    {
        "key": "space",
        "command": "vspacecode.space",
        "when": "activeEditorGroupEmpty && focusedView == '' && !whichkeyActive && !inputFocus"
    },
    // Trigger vspacecode when sidebar is in focus
    {
        "key": "space",
        "command": "vspacecode.space",
        "when": "sideBarFocus && !inputFocus && !whichkeyActive"
    },
    // Keybindings required for edamagit
    // https://github.com/kahole/edamagit#vim-support-vscodevim
    // Cannot be added to package.json because keybinding replacements
    {
        "key": "tab",
        "command": "extension.vim_tab",
        "when": "editorFocus && vim.active && !inDebugRepl && vim.mode != 'Insert' && editorLangId != 'magit'"
    },
    {
        "key": "tab",
        "command": "-extension.vim_tab",
        "when": "editorFocus && vim.active && !inDebugRepl && vim.mode != 'Insert'"
    },
    {
        "key": "x",
        "command": "magit.discard-at-point",
        "when": "editorTextFocus && editorLangId == 'magit' && vim.mode =~ /^(?!SearchInProgressMode|CommandlineInProgress).*$/"
    },
    {
        "key": "k",
        "command": "-magit.discard-at-point"
    },
    {
        "key": "-",
        "command": "magit.reverse-at-point",
        "when": "editorTextFocus && editorLangId == 'magit' && vim.mode =~ /^(?!SearchInProgressMode|CommandlineInProgress).*$/"
    },
    {
        "key": "v",
        "command": "-magit.reverse-at-point"
    },
    {
        "key": "shift+-",
        "command": "magit.reverting",
        "when": "editorTextFocus && editorLangId == 'magit' && vim.mode =~ /^(?!SearchInProgressMode|CommandlineInProgress).*$/"
    },
    {
        "key": "shift+v",
        "command": "-magit.reverting"
    },
    {
        "key": "shift+o",
        "command": "magit.resetting",
        "when": "editorTextFocus && editorLangId == 'magit' && vim.mode =~ /^(?!SearchInProgressMode|CommandlineInProgress).*$/"
    },
    {
        "key": "shift+x",
        "command": "-magit.resetting"
    },
    {
        "key": "x",
        "command": "-magit.reset-mixed"
    },
    {
        "key": "ctrl+u x",
        "command": "-magit.reset-hard"
    },
    // Extra ref menu support for edamagit with the key "y"
    // Cannot be added to package.json because keybinding replacements
    {
        "key": "y",
        "command": "-magit.show-refs"
    },
    {
        "key": "y",
        "command": "vspacecode.showMagitRefMenu",
        "when": "editorTextFocus && editorLangId == 'magit' && vim.mode == 'Normal'"
    },
    // Easy navigation in quick open/QuickPick
    {
        "key": "ctrl+j",
        "command": "workbench.action.quickOpenSelectNext",
        "when": "inQuickOpen"
    },
    {
        "key": "ctrl+k",
        "command": "workbench.action.quickOpenSelectPrevious",
        "when": "inQuickOpen"
    },
    // Easy navigation in sugesstion/intellisense
    // Cannot be added to package.json because of conflict with vim's default bindings
    {
        "key": "ctrl+j",
        "command": "selectNextSuggestion",
        "when": "suggestWidgetMultipleSuggestions && suggestWidgetVisible && textInputFocus"
    },
    {
        "key": "ctrl+k",
        "command": "selectPrevSuggestion",
        "when": "suggestWidgetMultipleSuggestions && suggestWidgetVisible && textInputFocus"
    },
    {
        "key": "ctrl+l",
        "command": "acceptSelectedSuggestion",
        "when": "suggestWidgetMultipleSuggestions && suggestWidgetVisible && textInputFocus"
    },
    // Easy navigation in parameter hint (i.e. traverse the hints when there's multiple overload for one method)
    // Cannot be added to package.json because of conflict with vim's default bindings
    {
        "key": "ctrl+j",
        "command": "showNextParameterHint",
        "when": "editorFocus && parameterHintsMultipleSignatures && parameterHintsVisible"
    },
    {
        "key": "ctrl+k",
        "command": "showPrevParameterHint",
        "when": "editorFocus && parameterHintsMultipleSignatures && parameterHintsVisible"
    },
    // Add ctrl+h/l to navigate in file browser
    {
        "key": "ctrl+h",
        "command": "file-browser.stepOut",
        "when": "inFileBrowser"
    },
    {
        "key": "ctrl+l",
        "command": "file-browser.stepIn",
        "when": "inFileBrowser"
    }
]

Settings
Click to toggle contents of `settings.json`

{
    /********** VSpaceCode boilerplate **********/
    // https://github.com/VSpaceCode/VSpaceCode/blob/master/src/configuration/settings.jsonc

    "vim.easymotion": true,  // Vim easymotion is required for Jump menu - <SPC> j
    "vim.useSystemClipboard": true,
    // Trigger the main which key menu with in the active editor with vim
    // This cannot be put into keybindings.json because it will
    // create conflict with Vim.
    // https://github.com/stevenguh/spacecode/issues/3
    "vim.normalModeKeyBindingsNonRecursive": [
        {
            "before": ["<space>"],
            "commands": ["vspacecode.space"]
        },
        {
            "before": [","],
            "commands": [
                "vspacecode.space",
                {
                    "command": "whichkey.triggerKey",
                    "args": "m"
                }
            ]
        }
    ],
    "vim.visualModeKeyBindingsNonRecursive": [
        {
            "before": ["<space>"],
            "commands": ["vspacecode.space"]
        },
        {
            "before": [","],
            "commands": [
                "vspacecode.space",
                {
                    "command": "whichkey.triggerKey",
                    "args": "m"
                }
            ]
        }
    ],

    /********** Custom VSpaceCode bindings **********/
    "vspacecode.bindingOverrides": [
        {
            "keys": "g.b",
            "name": "Blame file with GitLens",
            "type" : "command",
            "command": "gitlens.toggleFileBlame",
        },
        {
            "keys": "g.B",
            "name": "Blame file with magit",
            "type" : "command",
            "command": "magit.blame-file",
        },
        {
            "keys": "g.g",
            "name": "GitLens Commands",
            "type" : "command",
            "command": "gitlens.gitCommands",
        },

        {
            "keys": "h.z",
            "name": "Zeal for current text",
            "type" : "command",
            "command": "extension.dash.specific",
        },
        {
            "keys": "h.Z",
            "name": "Open Zeal",
            "type" : "command",
            "command": "extension.dash.emptySyntax",
        },

        {
            "keys": "p.o",
            "name": "Open folder",
            "type" : "command",
            "command": "workbench.action.files.openFolder",
        },
    ],

    /********** Appearance **********/
    "editor.cursorBlinking": "phase",
    "editor.cursorSurroundingLines": 2,
    "editor.fontFamily": "Iosevka",
    "editor.fontLigatures": true,
    "editor.fontSize": 18,
    "editor.inlineHints.fontFamily": "Iosevka",
    "editor.minimap.scale": 2,
    "editor.minimap.showSlider": "always",
    "editor.renderControlCharacters": true,
    "editor.renderLineHighlightOnlyWhenFocus": true,
    "editor.renderWhitespace": "trailing",
    // "editor.cursorSmoothCaretAnimation": true,
    "errorLens.fontFamily": "Iosevka Extralight",
    "errorLens.fontSize": "10pt",
    "search.showLineNumbers": true,
    "vim.showMarksInGutter": true,
    "window.dialogStyle": "custom",
    "window.menuBarVisibility": "toggle",
    "window.zoomLevel": 2,
    "workbench.colorTheme": "Monokai Classic",
    "workbench.editor.highlightModifiedTabs": true,
    "workbench.iconTheme": "Monokai Classic Icons",
    "workbench.tree.indent": 16,

    /********** Behavior **********/
    "debug.console.closeOnEnd": true,
    "editor.find.autoFindInSelection": "multiline",
    "editor.mouseWheelZoom": true,
    "editor.tabCompletion": "on",
    "file-browser.hideIgnoredFiles": true,
    "file-browser.labelIgnoredFiles": true,
    "files.insertFinalNewline": true,
    "files.simpleDialog.enable": true,
    "keyboard.dispatch": "keyCode",  // https://stackoverflow.com/a/50875402/2085149
    "search.smartCase": true,
    "terminal.external.linuxExec": "kitty",
    "vim.camelCaseMotion.enable": true,
    //"vim.textwidth": 88,
    "workbench.startupEditor": "newUntitledFile",

    /********** Privacy **********/
    "update.mode": "none",
    "telemetry.enableCrashReporter": false,
    "telemetry.enableTelemetry": false,
    "workbench.settings.enableNaturalLanguageSearch": false,

    /*********** Git **********/
    "magit.forge-enabled": true,
    "gitlens.hovers.currentLine.over": "line",
    "gitlens.currentLine.enabled": false,
    // "gitlens.codeLens.scopes": [
    //     "document",
    //     "containers",
    //     "blocks"
    // ],
    "gitlens.hovers.currentLine.enabled": false,

    /********** Python **********/
    "python.useIsolation": false,  // for pytest to find qutebrowser package

    /********** LaTeX **********/
	"latex-workshop.latex.tools": [
		{
			"name": "latexmk",
			"command": "latexmk",
			"args": [
                "-shell-escape",  // FIXME do we really want this globally?
				"-synctex=1",
				"-interaction=nonstopmode",
				"-file-line-error",
				"-pdf",
				"-outdir=%OUTDIR%",
				"%DOC%"
			],
			"env": {}
		},
    ],
    // https://github.com/James-Yu/LaTeX-Workshop/wiki/View#using-synctex-with-an-external-viewer
    "latex-workshop.view.pdf.viewer": "external",
    "latex-workshop.view.pdf.external.viewer.command": "zathura",
    "latex-workshop.view.pdf.external.viewer.args": [
        "--synctex-editor-command",
        "code --reuse-window -g \"%{input}:%{line}\"",
        "%PDF%"
    ],
    "latex-workshop.view.pdf.external.synctex.command": "zathura",
    "latex-workshop.view.pdf.external.synctex.args": [
        "--synctex-forward=%LINE%:0:%TEX%",
        "%PDF%"
    ],

    /********** Dash/Zeal **********/
    "dash.languageIdToDocsetMap": {
        "ansible": [
            "ansible"
        ],
        "python": [
            "python",
            "qt",
        ],
    },
    "workbench.editorAssociations": [
        {
            "viewType": "jupyter.notebook.ipynb",
            "filenamePattern": "*.ipynb"
        }
    ],

    /********** Unknown **********/
    // "workbench.editorAssociations": [
    //     {
    //         "viewType": "jupyter.notebook.ipynb",
    //         "filenamePattern": "*.ipynb"
    //     }
    // ],
    // "workbench.colorCustomizations": {
    //     "statusBar.background": "#005f5f",
    //     "statusBar.noFolderBackground": "#005f5f",
    //     "statusBar.debuggingBackground": "#005f5f"
    // },
    // "yaml.customTags": [
    //     "!encrypted/pkcs1-oaep scalar",
    //     "!vault scalar"
    // ],
}

System information

I didn't think user can type faster than the rendering of the QuickPick 😅. This actually was on my mind when deciding different solutions for implementing the shortcut , for major mode.
Anyway, I will implement a solution/fix that won't have this race condition for shortcut to major mode.

Hehe :blush: I guess when already having the keybinding memorized, and when it happens to be on two separate fingers, that doesn't hold true anymore :smile:
Thanks for taking a look, let me know if I can help somehow!

Let me note that this seems like an issue in generic too - not sure if it's fixable though, and if so, whether I should open a separate issue for it.
If I hit SPC p f quickly, I can see pf being entered into the first QuickPick (before the second one gets displayed), then I end up in the +Project menu rather than the +Find file in project one.

To solving the race condition of entering second key right after ,, I am thinking to supply initial value instead of simulating a key press after waiting the menu to open. The race condition for the original issue is that the simulated press comes after the key x.

If I hit SPC p f quickly, I can see pf being entered into the first QuickPick (before the second one gets displayed), then I end up in the +Project menu rather than the +Find file in project one.

For this case, it can be adjacent to original issue. But let's open another issue to track it. I think the cause of this is probably because multiple onDidChangeValue events are called before the pervious one has a chance to complete, and the time to finish onDidChangeValue probably also increased by https://github.com/VSpaceCode/vscode-which-key/issues/34. Two attempts in my heads are

Have a queue to batch the onDidChangeValue to handle event in sequence. However, probably won't work by itself for the upcoming 1.57 (#34) due to how we modify the input.
Change the input handling completely to eliminate modification of the input field.

indeed it gets much better when I set whichkey.delay to 1 instead of 0. Maybe that logic should be active in some way even without a delay

The difference is that https://github.com/VSpaceCode/vscode-which-key/blob/9c6ad3ab8ed229a5f40a23d2bb7b2af330bf7edf/src/menu/menu.ts#L239-L245 is running on asynchronously when delay is 1. The might be due to us needing to have a workaround to await for set value for #34.
@The-Compiler Wondering what's the version of vscode you are running? Can you also try which-key version v0.8.4 to see if it's any better?

FWIW I can still reproduce this one even after downgrading to v0.8.4, using sleep 2 && xdotool type ',x'.

This in some sense is easier to fix than #39. We just need to build a proper support to pass in initial keys instead of "simulating" keys pressed with consecutively commands.

On a second thought, this might be solved with approach outlined in #39 with better input handling (queue).

Released in v0.10.0. The new implementation should be faster and more robust as it uses a processing queue to handle input change.
It is tested with
sleep 1; xdotool type ,; sleep 0.01; xdotool type x;
# or
sleep 1; xdotool type " "; sleep 0.01; xdotool type mx;

We have to wait for at least 10ms for the UI input to be shown before we can type. That's the limit of what we can do.

Seems to work beautifully now, at least from what I can see so far. Thanks! :+1:


[utility] fix failed to create servicer

Adds servicer pk to validator1 docker compose deployment
Fixes failed to create servicer in the utility module for validator1 deployment.
There are probably more places this needs to be fixed, but this unblocked me after rebasing off main.

@0xBigBoss I put up a similar patch last week, so please see https://github.com/pokt-network/pocket/pull/968.
Also fixes the corresponding test.


Automatic Jupyter Notebooks not working

I wanted to open an automatically generated Jupyter Notebook from one of the tutorials with this option, but got the following error:
File Load Error for single-cell-scrna-case_monocle3-rstudio.ipynb Unreadable Notebook: /data/jwd01/pulsar_staging/60901074/working/jupyter/single-cell-scrna-case_monocle3-rstudio.ipynb NotJSONError('Notebook does not appear to be JSON: \'{\\n "metadata": {\\n "kernelspec": {...')
I also checked notebooks from other tutorials (Scanpy TI, pangeo) and they also don't work. It was not the case some time ago.

ah shoot, that should've been caught, we have a linter for exactly that. I'll look into it

Fixed now, thanks!


Support function score weight parameter

Closes olivere/elastic#74

Note that first commit's build failed only on one node for a reason unrelated to this PR

Should be achieved with this commit.


Update ParentRef wording

What type of PR is this?
/kind cleanup
/kind documentation
What this PR does / why we need it:
Notes that ParentRefs that cross namespace boundaries must have some way for the referent to accept/allow the routes.
Which issue(s) this PR fixes:

Fixes #973
Does this PR introduce a user-facing change?:
Clarified that AllowedRoutes or ReferenceGrant must be used by a parent in a cross-namespace ParentRef.

I didn't update the v1alpha2 docs; happy to if we think that's worthwhile for this change.

Thanks @youngnick! LGTM once tests pass.


Update Erlang to 18.0

Is it possible to see an error message about the build failure?

@vidarkongsli Not sure why it failed. Can you try rebasing to resolve the merge conflicts?

@deevus Fixed it.

@vidarkongsli Looks like you have reverted some changes to other files. You might need to start again if you can't work it out.


WebAlign version number

Assign a version number to WebAlign (important for reporting purposes)

v0.7, added to Help box.


[Question] When the hive engine is scheduled to execute, the following error is reported: operation failed NullPointerException

Before asking

[X] I have read the How to ask for help (我已阅读如何寻求帮助指引文档).

Your environment

Linkis version used: 1.1.2
Environment name and version:

cdh-5.14.2
hdp-3.1.5
hive-2.1.1
spark-3.2.1
scala-2.12.2
jdk 1.8.0_121
....

Describe your questions
When the hive engine is scheduled to execute, the following error is reported: operation failed NullPointerException, and the environment variable HIVE_CONF_DIR required for error information does not exist
hive引擎调度执行时，报错如下opertion failed NullPointerException，且有错误信息必须的环境变量HIVE_CONF_DIR不存在

Eureka service list

eg:
Some logs info or acctch file

linkis-xxx.log:

<!--日志文字贴到这里-->

log file:

linkis-xxx.log

The server lacks environment variables, and /etc/profile adds export HIVE_CONF_DIR=/etc/hive/conf;
服务器缺少环境变量，/etc/profile增加export HIVE_CONF_DIR=/etc/hive/conf;


Remove Thread#run to avoid unexpected interruption.

Thread#run causes unexpected interruption and it affects
the behaviour of some libraries, e.g. DataError in zlib.
Use condition variable instead to handle thread execution.
This change is based on jl2005's #1984 patch.
Ref https://github.com/fluent/fluentd/issues/1847 / https://github.com/fluent/fluentd/issues/1903
Signed-off-by: Masahiro Nakagawa<EMAIL_ADDRESS>

@cosmo0920 ji2005's test case is passed with old implementation because the problem is rare timing issue with ruby's VM and C extension implementation.
So writing test is hard. We need feedback from users with fluentd v1.3.


hyprland: 0.46.1 -> 0.46.2; hyprland-qtutils: init at 0.1.1

Looking for a fix for https://github.com/hyprwm/Hyprland/issues/8776 I've run the update script and included the updated version in my configuration.nix.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Sure. @kolaente do you mind creating the package in a new commit (nix file can be adapted from upstream) and adding me as a maintainer (along with yourself, if you want)? After that, add hyprland-qtutils to hyprland's buildInputs.

@fufexan Added the package but I'm unsure about the missing build inputs. Can you check what's missing?
I've added a few and now it still fails with
CMake Error at /nix/store/4k2h9qsps52n1v56zq03yi67dwmxa81i-cmake-3.30.5/share/cmake-3.30/Modules/FindPkgConfig.cmake:645 (message):
  The following required packages were not found:

   - wayland-protocols
   - cairo
   - pango
   - pangocairo
   - pixman-1
   - xcursor
   - libinput
   - gbm
   - re2

@kolaente In the hyprland flake hyprland-qtutils are added not to buildInputs or runtimeInputs but directly to path in postInstall
https://github.com/hyprwm/Hyprland/blob/main/nix/default.nix#L174
here is the same line in the current nixpkg
https://github.com/NixOS/nixpkgs/blob/nixos-unstable/pkgs/by-name/hy/hyprland/package.nix#L199
@fufexan I don't really understand what is the difference between runtimeInputs and adding things to path with a wrapper like in examples above. Is it better to do it the way hyprland flake does?

I haven't seen runtimeInputs mentioned anywhere except writeShellApplication. A quick rg through Nixpkgs reveals its only usages are in that context.
I'm happy to be proven wrong, but I don't see special handling of it in stdenv.

@JohnRTitor you mean the @TAG@? This should not even be there, since we're now passing the appropriate tag from the info file.

I know maybe something broke from the source side.

Looks like you still need to add hyprland-qtutils to the buildInputs of hyprland.

yeah I thought getting the package to build first would be better.

Thanks for all of your suggestions! I've added them all, but the build still fails with complaining about missing gbm. As far as I understood it, that is a protocol and xboost is an implementation of it. Adding xboost to the build inputs does not seem to work though.
Full error log

Running phase: qtPreHook
@nix { "action": "setPhase", "phase": "qtPreHook" }
Running phase: unpackPhase
@nix { "action": "setPhase", "phase": "unpackPhase" }
unpacking source archive /nix/store/dd837lga6pq6rrqaq8n8in4z1pah6via-source
source root is source
Running phase: patchPhase
@nix { "action": "setPhase", "phase": "patchPhase" }
Running phase: updateAutotoolsGnuConfigScriptsPhase
@nix { "action": "setPhase", "phase": "updateAutotoolsGnuConfigScriptsPhase" }
Running phase: configurePhase
@nix { "action": "setPhase", "phase": "configurePhase" }
fixing cmake files...
cmake flags: -DCMAKE_FIND_USE_SYSTEM_PACKAGE_REGISTRY=OFF -DCMAKE_FIND_USE_PACKAGE_REGISTRY=OFF -DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON -DCMAKE_BUILD_TYPE=Release -DBUILD_TESTING=OFF -DCMAKE_INSTALL_LOCALEDIR=/nix/store/p591qpiacq7j5a82vw7l3m8sxzyfgdga-hyprland-qtutils-0.1.1/share/locale -DCMAKE_INSTALL_LIBEXECDIR=/nix/store/p591qpiacq7j5a82vw7l3m8sxzyfgdga-hyprland-qtutils-0.1.1/libexec -DCMAKE_INSTALL_LIBDIR=/nix/store/p591qpiacq7j5a82vw7l3m8sxzyfgdga-hyprland-qtutils-0.1.1/lib -DCMAKE_INSTALL_DOCDIR=/nix/store/p591qpiacq7j5a82vw7l3m8sxzyfgdga-hyprland-qtutils-0.1.1/share/doc/hyprland-qtutils -DCMAKE_INSTALL_INFODIR=/nix/store/p591qpiacq7j5a82vw7l3m8sxzyfgdga-hyprland-qtutils-0.1.1/share/info -DCMAKE_INSTALL_MANDIR=/nix/store/p591qpiacq7j5a82vw7l3m8sxzyfgdga-hyprland-qtutils-0.1.1/share/man -DCMAKE_INSTALL_OLDINCLUDEDIR=/nix/store/p591qpiacq7j5a82vw7l3m8sxzyfgdga-hyprland-qtutils-0.1.1/include -DCMAKE_INSTALL_INCLUDEDIR=/nix/store/p591qpiacq7j5a82vw7l3m8sxzyfgdga-hyprland-qtutils-0.1.1/include -DCMAKE_INSTALL_SBINDIR=/nix/store/p591qpiacq7j5a82vw7l3m8sxzyfgdga-hyprland-qtutils-0.1.1/sbin -DCMAKE_INSTALL_BINDIR=/nix/store/p591qpiacq7j5a82vw7l3m8sxzyfgdga-hyprland-qtutils-0.1.1/bin -DCMAKE_INSTALL_NAME_DIR=/nix/store/p591qpiacq7j5a82vw7l3m8sxzyfgdga-hyprland-qtutils-0.1.1/lib -DCMAKE_POLICY_DEFAULT_CMP0025=NEW -DCMAKE_FIND_FRAMEWORK=LAST -DCMAKE_STRIP=/nix/store/4apajimszc47rxwcpvc3g3rj2icinl71-gcc-wrapper-13.3.0/bin/strip -DCMAKE_RANLIB=/nix/store/4apajimszc47rxwcpvc3g3rj2icinl71-gcc-wrapper-13.3.0/bin/ranlib -DCMAKE_AR=/nix/store/4apajimszc47rxwcpvc3g3rj2icinl71-gcc-wrapper-13.3.0/bin/ar -DCMAKE_C_COMPILER=gcc -DCMAKE_CXX_COMPILER=g++ -DCMAKE_INSTALL_PREFIX=/nix/store/p591qpiacq7j5a82vw7l3m8sxzyfgdga-hyprland-qtutils-0.1.1
-- The C compiler identification is GNU 13.3.0
-- The CXX compiler identification is GNU 13.3.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /nix/store/4apajimszc47rxwcpvc3g3rj2icinl71-gcc-wrapper-13.3.0/bin/gcc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /nix/store/4apajimszc47rxwcpvc3g3rj2icinl71-gcc-wrapper-13.3.0/bin/g++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Gathering git info
./scripts/generateVersion.sh: line 4: git: not found
./scripts/generateVersion.sh: line 5: git: not found
./scripts/generateVersion.sh: line 6: git: not found
./scripts/generateVersion.sh: line 7: git: not found
./scripts/generateVersion.sh: line 8: git: not found
./scripts/generateVersion.sh: line 9: git: not found
./scripts/generateVersion.sh: line 10: git: not found
-- Found PkgConfig: /nix/store/16h31npnbgpkhxp1041dsifiklbw4mpr-pkg-config-wrapper-0.29.2/bin/pkg-config (found version "0.29.2")
-- Checking for module 'udis86>=1.7.2'
--   No package 'udis86' found
-- Could NOT find Python3 (missing: Python3_EXECUTABLE Interpreter)
Building itab.c/itab.h...
-- udis86 dependency not found, falling back to subproject
-- Found wayland-protocols at //nix/store/dxdbkrpc5gphjn0alqzkc8yvxbcy914v-wayland-protocols-1.38/share/wayland-protocols
-- Found wayland-scanner pkgdatadir at //nix/store/dx6m26y25y5z5f2mndinp7bp5vcjsb8w-wayland-scanner-1.23.1/share/wayland
-- Configuring Hyprland in Release with CMake
-- Checking deps...
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Success
-- Found Threads: TRUE
-- Found OpenGL: /nix/store/ri85b3kn22dmr4yiimfsgd6r5x7zgk4z-libglvnd-1.7.0/lib/libOpenGL.so  found components: GLES3
-- Checking for module 'aquamarine>=0.4.5'
--   Found aquamarine, version 0.5.0
-- Checking for module 'hyprlang>=0.3.2'
--   Found hyprlang, version 0.6.0
-- Checking for module 'hyprcursor>=0.1.7'
--   Found hyprcursor, version 0.1.10
-- Checking for module 'hyprutils>=0.2.3'
--   Found hyprutils, version 0.2.6
-- Checking for module 'hyprgraphics>=0.1.1'
--   Found hyprgraphics, version 0.1.1
-- Checking for modules 'xkbcommon;uuid;wayland-server>=1.22.90;wayland-protocols;cairo;pango;pangocairo;pixman-1;xcursor;libdrm;libinput;gbm;gio-2.0;re2'
--   No package 'gbm' found
CMake Error at /nix/store/4k2h9qsps52n1v56zq03yi67dwmxa81i-cmake-3.30.5/share/cmake-3.30/Modules/FindPkgConfig.cmake:645 (message):
  The following required packages were not found:

   - gbm

Call Stack (most recent call first):
  /nix/store/4k2h9qsps52n1v56zq03yi67dwmxa81i-cmake-3.30.5/share/cmake-3.30/Modules/FindPkgConfig.cmake:873 (_pkg_check_modules_internal)
  CMakeLists.txt:116 (pkg_check_modules)

-- Configuring incomplete, errors occurred!

@kolaente you seem to have disabled maintainer access to your fork, so here are the patches

qtutils fix
commit 47ad1ef537d44fab7bca52a468325655e0a2ae93
Author: Mihai Fufezan<EMAIL_ADDRESS>Date:   Mon Dec 23 18:24:07 2024 +0200

    hyprland-qtutils: fix build

diff --git a/pkgs/by-name/hy/hyprland-qtutils/package.nix b/pkgs/by-name/hy/hyprland-qtutils/package.nix
index 64f674234e04..e9a6d8d29e6a 100644
--- a/pkgs/by-name/hy/hyprland-qtutils/package.nix
+++ b/pkgs/by-name/hy/hyprland-qtutils/package.nix
@@ -1,30 +1,17 @@
 {
   lib,
-  stdenv,
-  aquamarine,
-  cairo,
-  cmake,
+  gcc14Stdenv,
   fetchFromGitHub,
-  hyprcursor,
-  hyprgraphics,
-  hyprlang,
+  cmake,
+  pkg-config,
   hyprutils,
-  libinput,
-  pango,
   pciutils,
-  pixman,
-  pkg-config,
   qt6,
-  re2,
-  wayland-protocols,
-  xgboost,
-  xorg,
 }:
 let
-  inherit (lib.sources) cleanSource cleanSourceWith;
-  inherit (lib.strings) hasSuffix makeBinPath;
+  inherit (lib.strings) makeBinPath;
 in
-stdenv.mkDerivation (finalAttrs: {
+gcc14Stdenv.mkDerivation (finalAttrs: {
   pname = "hyprland-qtutils";
   version = "0.1.1";

@@ -32,7 +19,7 @@ stdenv.mkDerivation (finalAttrs: {
     owner = "hyprwm";
     repo = "hyprland-qtutils";
     tag = "v${finalAttrs.version}";
-    hash = "sha256-dj9dpVwpyTmUyVu4jtaIU39bHgVkoZjv6cgYfWyHc9E=";
+    hash = "sha256-Zp2cQOo1D7WH7ml5nV7mLyto0l19gTaWnbDb6zty1Qs=";
   };

   nativeBuildInputs = [
@@ -42,22 +29,10 @@ stdenv.mkDerivation (finalAttrs: {
   ];

   buildInputs = [
-    aquamarine
-    cairo
-    hyprcursor
-    hyprgraphics
-    hyprlang
     hyprutils
-    libinput
-    pango
-    pixman
     qt6.qtbase
     qt6.qtsvg
     qt6.qtwayland
-    re2
-    wayland-protocols
-    xgboost
-    xorg.libXcursor
   ];

   preFixup = ''

Adding qtutils to hyprland
commit c88de3ba4f6c9bd0ceb55bd231cea9516c87f2f8
Author: Mihai Fufezan<EMAIL_ADDRESS>Date:   Mon Dec 23 18:29:37 2024 +0200

    hyprland: add hyprland-qtutils to runtime

diff --git a/pkgs/by-name/hy/hyprland/package.nix b/pkgs/by-name/hy/hyprland/package.nix
index 303063b06493..8df4e6eebb39 100644
--- a/pkgs/by-name/hy/hyprland/package.nix
+++ b/pkgs/by-name/hy/hyprland/package.nix
@@ -15,6 +15,7 @@
   git,
   hyprcursor,
   hyprgraphics,
+  hyprland-qtutils,
   hyprlang,
   hyprutils,
   hyprwayland-scanner,
@@ -197,6 +198,7 @@ customStdenv.mkDerivation (finalAttrs: {
         --suffix PATH : ${
           makeBinPath [
             binutils
+            hyprland-qtutils
             pciutils
             pkgconf
           ]

you seem to have disabled maintainer access to your fork,

Pushing to a contributor branch is only allowed from a user with write access afaik (nixpkgs-commiters)

@fufexan applied the patches, please check again.

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 367113

x86_64-linux

:fast_forward: 1 package marked as broken and skipped:

hyprlandPlugins.hycov

:x: 1 package failed to build:

hyprlandPlugins.hyprfocus

:white_check_mark: 25 packages built:

grimblast
hdrop
hyprland
hyprland-qtutils
hyprland.dev
hyprland.man
hyprlandPlugins.borders-plus-plus
hyprlandPlugins.csgo-vulkan-fix
hyprlandPlugins.hy3
hyprlandPlugins.hypr-dynamic-cursors
hyprlandPlugins.hyprbars
hyprlandPlugins.hyprexpo
hyprlandPlugins.hyprgrass
hyprlandPlugins.hyprscroller
hyprlandPlugins.hyprspace
hyprlandPlugins.hyprsplit
hyprlandPlugins.hyprtrails
hyprlandPlugins.hyprwinwrap
hyprshade
hyprshade.dist
hyprshot
nwg-panel
nwg-panel.dist
waybar
xdg-desktop-portal-hyprland

aarch64-linux

:fast_forward: 1 package marked as broken and skipped:

hyprlandPlugins.hycov

:x: 1 package failed to build:

hyprlandPlugins.hyprfocus

:white_check_mark: 25 packages built:

grimblast
hdrop
hyprland
hyprland-qtutils
hyprland.dev
hyprland.man
hyprlandPlugins.borders-plus-plus
hyprlandPlugins.csgo-vulkan-fix
hyprlandPlugins.hy3
hyprlandPlugins.hypr-dynamic-cursors
hyprlandPlugins.hyprbars
hyprlandPlugins.hyprexpo
hyprlandPlugins.hyprgrass
hyprlandPlugins.hyprscroller
hyprlandPlugins.hyprspace
hyprlandPlugins.hyprsplit
hyprlandPlugins.hyprtrails
hyprlandPlugins.hyprwinwrap
hyprshade
hyprshade.dist
hyprshot
nwg-panel
nwg-panel.dist
waybar
xdg-desktop-portal-hyprland

I think the hyprland update and addition of qtutils to its path can be one commit.

I think the hyprland update and addition of qtutils to its path can be one commit.

Ah, yes. Didn't see that. Have qtutils init first commit, then the bump including the new dependency.

@JohnRTitor I can reproduce that issue on the flake version as well. I'll see what I can find out about it, so please don't merge this in the meantime.

@JohnRTitor I can reproduce that issue on the flake version as well. I'll see what I can find out about it, so please don't merge this in the meantime.

Is this issue introduced in 0.46.2? Or was it in 0.46.1?

This is not a hyprland issue at all, it's a Nix string issue. builtins.readFile ./VERSION reads the \n as well, which breaks sed's invocation, as can be seen by prepending set -x to the generateVersion.sh script:
Running command: /nix/store/p6k7xp1lsfmbdd731mlglrdj2d66mr82-bash-5.2p37/bin/sh -c scripts/generateVersion.sh
--- stdout ---

--- stderr ---
+ cp -fr ./src/version.h.in ./src/version.h
+ HASH=
+ git branch --show-current
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
+ BRANCH=
+ git show
+ head -n 5
+ tail -n 1
+ sed -e 's/#//g' -e 's/\"//g'
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
+ MESSAGE=
+ DATE=2024-12-22
+ DIRTY=dirty
+ TAG='v0.46.0
'
+ COMMITS=
+ sed -i -e 's#@HASH@##' ./src/version.h
+ sed -i -e 's#@BRANCH@##' ./src/version.h
+ sed -i -e 's#@MESSAGE@##' ./src/version.h
+ sed -i -e 's#@DATE@#2024-12-22#' ./src/version.h
+ sed -i -e 's#@DIRTY@#dirty#' ./src/version.h
+ sed -i -e 's#<EMAIL_ADDRESS>#' ./src/version.h
sed: -e expression #1, char 15: unterminated `s' command
+ sed -i -e 's#@COMMITS@##' ./src/version.h

This makes sense in the flake, since we do use builtins.readFile, but here it doesn't, since info.tag does not contain \n.

I'm not on my computer right now, will reorder the commits later tonight. If someone with write permissions wants to reorder them before that, please go ahead.

@JohnRTitor Are you using the flake or this version from nixpkgs?

As you can see I got Hyprland (which includes hyprctl) in a nix shell, so this PR's Hyprland package should take precedence.

nix shell github:nixos/nixpkgs/refs/pull/367113/merge#hyprland

As you can see I got Hyprland (which includes hyprctl) in a nix shell, so this PR's Hyprland package should take precedence.

nix shell github:nixos/nixpkgs/refs/pull/367113/merge#hyprland

That's not how it works. Hyprctl, no matter where you got it from, will always get the version of the currently running Hyprland. Even if the one you shelled is newer. So I would recheck that.
Besides, running trying the same set -x in this PR yields this log
Running command: /nix/store/p6k7xp1lsfmbdd731mlglrdj2d66mr82-bash-5.2p37/bin/sh -c scripts/generateVersion.sh
--- stdout ---

--- stderr ---
+ cp -fr ./src/version.h.in ./src/version.h
+ HASH=0bd541f2fd902dbfa04c3ea2ccf679395e316887
+ BRANCH=v0.46.2-b
+ MESSAGE='version: bump to 0.46.2'
+ DATE=2024-12-19
+ DIRTY=
+ TAG=v0.46.2
+ COMMITS=0bd541f2fd902dbfa04c3ea2ccf679395e316887
+ sed -i -e 's#@HASH@#0bd541f2fd902dbfa04c3ea2ccf679395e316887#' ./src/version.h
+ sed -i -e 's#<EMAIL_ADDRESS>./src/version.h
+ sed -i -e 's#@MESSAGE@#version: bump to 0.46.2#' ./src/version.h
+ sed -i -e 's#@DATE@#2024-12-19#' ./src/version.h
+ sed -i -e 's#@DIRTY@##' ./src/version.h
+ sed -i -e 's#<EMAIL_ADDRESS>./src/version.h
+ sed -i -e 's#@COMMITS@#0bd541f2fd902dbfa04c3ea2ccf679395e316887#' ./src/version.h

and the resulting src/version.h file:
#pragma once
#define GIT_COMMIT_HASH    "0bd541f2fd902dbfa04c3ea2ccf679395e316887"
#define GIT_BRANCH         "v0.46.2-b"
#define GIT_COMMIT_MESSAGE "version: bump to 0.46.2"
#define GIT_COMMIT_DATE    "2024-12-19"
#define GIT_DIRTY          ""
#define GIT_TAG            "v0.46.2"
#define GIT_COMMITS        "0bd541f2fd902dbfa04c3ea2ccf679395e316887"

@fufexan everything look good to you now?

Thanks everyone!

@fufexan can/will this be backported to 24.11?

Yes, will PR shortly.

@leiserfg backport PR https://github.com/NixOS/nixpkgs/pull/369101


Unable to Activate Json.py config

Issue Type: Bug
I click on the gear on the top in the debug column.
There is not option to select python.
Additionally, after installing the python extension, I am unable to see it on my column selection.
Extension version: 2019.10.44104
VS Code version: Code 1.39.2 (6ab598523be7a800d7f3eb4d92d7ab9a66069390, 2019-10-15T15:35:18.241Z)
OS version: Windows_NT x64 10.0.18362

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-8250U CPU @ 1.60GHz (8 x 1800)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: disabled_softwareoop_rasterization: disabled_offprotected_video_decode: enabledrasterization: enabledskia_deferred_display_list: disabled_offskia_renderer: disabled_offsurface_synchronization: enabled_onvideo_decode: enabledviz_display_compositor: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
7.91GB (2.97GB free)

Process Argv

Screen Reader
no

VM
0%

Was the Python extension loaded before you clicked on the Gear icon?
And what do you mean by "unable to see it on my column selection"? We're not sure what you mean by "column" here.

Because we have not heard back with the information we requested, we are closing this issue for now. If you are able to provide the info later on then we will be happy to re-open this issue to pick up where we left off.


Abstracting NLP client

What
I've added NLP client to dp-api-clients-go, point is to abstract the client so that it may be reused,
I've added new tests to test each call to a specific api
I've added mocks to mock the servers
How to review

[ ] Run tests - in nlp dir goconvey
[ ] Consistency
[ ] Typos
[ ] Comments
[ ] Syntax order
[ ] Should the config live here?

Who can review
Linden

As per our review discussions
I've fixed comments on the original PR to ONS repos
I've removed the common NLP client
I've created a separate Berlin client
I've created a separate Categories client
I've ran tests, created options and reusable interfaces


Bluetooth: Mesh: Shell: Split out mdl shell feat

This commit splits out the model related commands from mesh shell to
separate shell modules. The purpose of this alteration is to make model
commands more flexible by letting the application itself define the
model instances.

Move Health Client commands to separate shell module.
Move Config Client commands to separate shell module.
Remove Health Client instance from shell.c.
Add Health Client instance to mesh_shell test application.
Add util library for Mesh shell.
Some refactoring of shell menu layout.
Update Mesh shell documentation.

Signed-off-by: Anders Storrø<EMAIL_ADDRESS>

Generally looks good. There is one thing I would like to propose. I would suggest to replace SHELL_STATIC_SUBCMD_SET_CREATE with SHELL_SUBCMD_SET_CREATE for mesh_cmds. With that change, it would let us move the health and client commands under mesh command. It would also allow to extended mesh command from any other source file. This would be beneficial for us in nRF Connect SDK as we would be able to move client's commands under mesh command. There is one downside for this. Commands consisted several words added directly to mesh_cmds will have to use underscore instead of dash. But this could be potentially be solved be converting them into nested commands.
You can see the proposal here: https://github.com/Andrewpini/zephyr/compare/align_mesh_shell...PavelVPV:zephyr:mesh_shell_subcmd_proposal?expand=1

Yes, I think that is a good idea 👍

Could you add a bit more explanation to subject line of the second commit, e.g.:
Bluetooth: Mesh: Move shell.c -> Blietooth: Mesh: Move shell.c to shell/ subfolder.


Added primary_id functionality to the many to many relationship

The referencing column name can be set using the primary_id tag in the struct.
The reason for this change is that I have two structs that read from the same DB column that have different concerns.

You will probably also need to update the tests for this.

Also, use a topic branch.


Any way to access HTML.Assets() from model?

Is it possible to insert into HTML.Assets from the model code?
And I find it hard to believe that this hack appears to be the recommended approach to insert tags in the header or footer from within a Partial View or ViewComponent -- any other clean approach that works reliably in 2019?
It could also be modified to allow other types of content, such as inserting Facebook-specific tags in the header.

It could also be modified to allow other types of content, such as inserting Facebook-specific tags in the header.

This seems to be already possible: https://github.com/speier/mvcassetshelper/blob/455b0b2e815a864b19fa429c58546da33f7af1e0/AssetsHelper.cs#L92


ContourNext USB implementation

We are publishing the bayer contour next USB implementation for your consideration.

When testing this on Windows 8.1, it seems that I cannot get data from the Bayer Contour Next (not the Bayer Contour Next USB) anymore - receivePacket times out. Is it happening for you as well?

We've done some tests on windows 8.1 but nothing happened.

Just to be sure, you've been able to upload from the Bayer Contour Next on Windows 8.1 as well, not only the Bayer Contour Next USB?
If it's not a Windows version issue, I wonder if it could be a Chrome version issue. What version of Chrome are you running on the Windows 8.1 machine?

We've done upload data from the BayerContourNext, we are using the chrome v 44.0.2403.155, no problems

I'm using Chrome v 44.0.2403.130, so it's probably not that then. It seems that the device disconnects and reconnects after the first packet is sent (based on the Windows sounds), which is why receivePacket then gets an empty packet until timeout.

it probably could be a device issue, we've done more tests specially on Windows 8.1, and we can't get these message errors, we have a normal workflow (we are restored the 4 bytes, and we not have a disconnect/reconect problem)

Thanks for the screenshot. I can confirm that I'm using exactly the same meter (Bayer7350) with the same firmware versions (01.14\01.03\04.18). Can you have a look in Device Manager to check what driver you're using on Windows 8.1?

yeah, we are using the default HID driver for Windows, no specyfic driver needed to work

I can confirm that I'm also using the default HID driver for Windows. There does seem to be a small difference in the version number, i.e., 6.3.9600.17041 instead of 6.3.9600.16384. Does your Windows 8.1 installation have all the newest updates?
Sorry for all the hassle, it's just that it's driving me crazy that we seem to have the exact same setup, but that it doesn't work this side. I've tried various fixes (e.g. changing the USB report header) but nothing seems to work for the Bayer Contour Next (although it works fine on OS X). The Bayer Contour Next USB works fine on both. I'm just worried that if I have this issue on Windows 8.1, someone else is going to have the same problem.

no problem :smile: , we are using two versions of Windows 8.1, one with all updates, and the other with a clean installation (no updates), in both we have no problems, and we are using a Windows 8 machine (no 8.1) all are working fine.
I'm also worried but we can't get the error, if you determine the origin of the issue please notify us to help fixing it

OK, as the Windows 8.1 error is an issue with the Bayer Contour Next, and not the Bayer Contour Next USB, it should not stop us from merging this pull request.
I've made some changes after testing the Bayer Contour Next USB:

If there's a lot of data stored on the device, abortTimer times out before all the data is received. I've changed abortTimer so that it re-sets after every packet.
I've added more error handling, so that if a device disconnects, we correctly handle the chrome.runtime.lastError that is thrown

I tried submitting these changes to your PR, but GitHub created a separate branch at:
https://github.com/tidepool-org/chrome-uploader/tree/pr/136
I'd rather merge this PR than create a new PR for the pr/136 branch, so I'm hoping you can merge that branch into your PR, check that you agree with my changes and verify that everything is still working?

yeah, we've done merging the pr/136 branch into this PR, we've done some tests in Win, Linux and Mac.
All working fine :smile:

We've recently merged a lot of changes into the uploader to make it UTC timezone-aware. As such I've merged this into a new PR (#144) with the required changes to make it timezone-aware. I've tested it against the development server on both Windows and Mac and everything looks good. @gralmurdok, please check that it works for you as well against the latest version of the server, and comment in the new PR if there are issues.


allow using docker for builds instead of bubblewrap

This adds an alternate container running strategy, DockerRunner, which starts a build container, does the build in it, and then terminates the container.
From a design point of view, Melange treats this build container similarly to a kubernetes pod: it is a collection of tasks which must complete, for the build to be successful.
This brings us ~80% of the way to supporting Kubernetes directly.

We need to add the ability to force GitHub Actions to use bubblewrap instead of Docker because they do funky things to the Docker setup on GHA.


Revert "Add Intoto Signable Target support in Chains using strings in results."

Reverts tektoncd/chains#465 since the commits are not squashed

/assign wlynch

/close