Imrpove transport::smtp::Error docs to clarify is_transient/is_permanent

I expected is_transient and is_permanent to be the inverse of each other, which seems not to be the case. I'd appreciate more thorough documentation on what the differences are between the different types of errors.

Could you elaborate on what were your expectations and which kind of documentation would have helped you?


test: Add test-issue label to issues created by tests

Description:
Adds a label to issues created by pre-submit tests so that they can be more easily be filtered.
Related Issues:
N/A
Checklist:

[x] Review the CONTRIBUTING.md documentation.
[x] Add a reference to a related issue in the repository.
[x] Add a description of the changes proposed in the pull request.
[x] Add unit tests if applicable.
[x] Update documentation if applicable.
[x] Add a note in the CHANGELOG.md if applicable.
[x] Sign the Google CLA.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (d610949) 98.32% compared to head (e7c486f) 98.32%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #505   +/-   ##
=======================================
  Coverage   98.32%   98.32%
=======================================
  Files           4        4
  Lines         179      179
  Branches       19       19
=======================================
  Hits          176      176
  Partials        3        3


Incorrect types for Object.assign

Bug Report
Current types in 4.2 of Object.assign accept undefined as first arguments, but in fact it gives runtime error Cannot convert undefined or null to object
🔎 Search Terms
Object.assign

🕗 Version & Regression Information
4.2
⏯ Playground Link

Playground link with relevant code
💻 Code

Object.assign(undefined, {});

🙁 Actual behavior
It gives runtime error Cannot convert undefined or null to object

🙂 Expected behavior
TS throw type error on undefined as first argument in Object.assign

Aaaand this is a duplicate of https://github.com/microsoft/TypeScript/pull/40909/files
Sorry


Could not get unknown property 'android' for project ':camera_android' of type org.gradle.api.Project.

Steps to reproduce
1 Update camera plugin to 0.10.5+9
2 Build fail
Expected results
Im uneable to run app
Actual results
FAILURE: Build failed with an exception.

What went wrong:

Could not load compiled classes for build file 'C:\Users\christian\AppData\Local\Pub\Cache\hosted\pub.dev\camera_android-0.10.8+16\android\build.gradle' from cache.
Failed to notify project evaluation listener.
Could not get unknown property 'android' for project ':camera_android' of type org.gradle.api.Project.
Could not find method implementation() for arguments [project ':flutter_plugin_android_lifecycle'] on object of type org.gradle.api.internal.artifacts.dsl.dependencies.DefaultDependencyHandler.
Could not get unknown property 'android' for project ':camera_android' of type org.gradle.api.Project.

Try:

Run with --stacktrace option to get the stack trace.
Run with --info or --debug option to get more log output.
Run with --scan to get full insights.

Get more help at https://help.gradle.org

BUILD FAILED in 27s
Running Gradle task 'assembleDebug'...                             29,5s
Exception: Gradle task assembleDebug failed with exit code 1
Code sample
Code sample
pubspect.yaml
name: mushing
description: "A new Flutter project."
publish_to: 'none' # Remove this line if you wish to publish to pub.dev

version: 1.0.0+1

environment:
  sdk: '>=3.2.3 <4.0.0'

dependency_overrides:
  http: ^0.13.1

dependencies:
  flutter:
    sdk: flutter

  flutter_riverpod: ^2.4.0
  riverpod_annotation: ^2.1.5

  flutter_localizations:
    sdk: flutter
  intl: any

  cupertino_icons: ^1.0.5
  font_awesome_flutter: ^10.4.0
  video_player: ^2.8.2
  visibility_detector: ^0.4.0+2
  google_fonts: ^6.1.0
  go_router: ^13.0.1
  permission_handler: ^11.1.0
  #gallery_saver: ^2.3.2
  image_picker: ^1.0.4
  provider: ^6.0.5
  shared_preferences: ^2.1.1
  firebase_core: ^2.24.2
  firebase_auth: ^4.16.0
  firebase_messaging: ^14.7.10
  firebase_database: ^10.2.5
  cached_network_image: ^3.2.3
  cloud_functions: ^4.3.1

  transparent_image: ^2.0.1
  google_sign_in: ^6.1.5
  flutter_facebook_auth: ^6.0.3
  dio: ^5.3.3
  connectivity: ^3.0.6
  universal_io: ^2.2.2
  carousel_slider: ^4.2.1
  like_button: ^2.0.5
  video_compress: ^3.1.2
  video_thumbnail: ^0.5.3
  file_picker: ^6.1.1
  #cached_video_player: ^2.0.4

  exif: ^3.2.1
  flutter_map: ^6.1.0
  location: ^5.0.0
  latlong2: ^0.9.0
  image_stack: ^2.1.1
  flutter_form_builder: ^9.1.1
  form_builder_validators: ^9.0.0
  mercadopago_sdk: ^1.3.0
  awesome_card: ^1.1.7
  expandable_bottom_sheet: ^1.1.1+1
  flutter_native_splash: ^2.3.4
  flutter_svg: ^2.0.8
  animate_do: ^3.1.2
  flutter_launcher_icons: ^0.13.1
  crypto: ^3.0.3
  swipe_to: ^1.0.2

  #file_saver: ^0.2.6

  syncfusion_flutter_pdfviewer: ^24.1.44
  flutter_downloader: ^1.11.5
  device_info_plus: ^9.1.1
  widgets_to_image: ^0.0.2
  flutter_chat_ui: ^1.6.10
  record: ^5.0.4
  flutter_audio_waveforms: ^1.2.1+8
  just_audio: ^0.9.34
  marquee: ^2.2.3
  localstorage: ^4.0.1+4
  flutter_chat_types: ^3.6.2
  path_provider: ^2.1.1
  camera: ^0.10.5+9

flutter_launcher_icons:
  android: "launcher_icon"
  ios: true
  image_path: "assets/logo/mushing_image_gradient.png"
  min_sdk_android: 21 # android min sdk min:16, default 21
  adaptive_icon_foreground: "assets/logo/mushing_image_gradient.png"
  adaptive_icon_background: "#77202f"
  web:
    generate: true
    image_path: "assets/logo/mushing_image_gradient.png"
    background_color: "#77202f"
    theme_color: "#77202f"
  windows:
    generate: true
    image_path: "assets/logo/mushing_image_gradient.png"
    icon_size: 48 # min:48, max:256, default: 48
  macos:
    generate: true
    image_path: "assets/logo/mushing_image_gradient.png"

dev_dependencies:
  build_runner:
  riverpod_generator: ^2.3.2

  flutter_test:
    sdk: flutter

  integration_test:
    sdk: flutter

  flutter_lints: ^3.0.1

flutter:
  generate: true
  uses-material-design: true

  assets:
    - assets/images/
    - assets/logo/

flutter_intl:
  enabled: true

Screenshots or Video

Screenshots / Video demonstration
[Upload media here]

Logs
Logs
FAILURE: Build failed with an exception.

* What went wrong:
> Could not load compiled classes for build file 'C:\Users\christian\AppData\Local\Pub\Cache\hosted\pub.dev\camera_android-0.10.8+16\android\build.gradle' from cache.
> Failed to notify project evaluation listener.
   > Could not get unknown property 'android' for project ':camera_android' of type org.gradle.api.Project.
   > Could not find method implementation() for arguments [project ':flutter_plugin_android_lifecycle'] on object of type org.gradle.api.internal.artifacts.dsl.dependencies.DefaultDependencyHandler.
   > Could not get unknown property 'android' for project ':camera_android' of type org.gradle.api.Project.

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 27s```

</details>

### Flutter Doctor output

<details open><summary>Doctor output</summary>

```console
[√] Flutter (Channel stable, 3.16.5, on Microsoft Windows [Versi¢n 10.0.19045.3803], locale es-AR)
    • Flutter version 3.16.5 on channel stable at C:\src\flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 78666c8dc5 (3 weeks ago), 2023-12-19 16:14:14 -0800
    • Engine revision 3f3e560236
    • Dart version 3.2.3
    • DevTools version 2.28.4

[√] Windows Version (Installed version of Windows is version 10 or higher)

[√] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at C:\Users\christian\AppData\Local\Android\sdk
    • Platform android-34, build-tools 30.0.3
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 11.0.12+7-b1504.28-7817840)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[√] Visual Studio - develop Windows apps (Visual Studio Community 2022 17.3.1)
    • Visual Studio at C:\Program Files\Microsoft Visual Studio\2022\Community
    • Visual Studio Community 2022 version 17.3.32811.315
    • Windows 10 SDK version 10.0.19041.0

[√] Android Studio (version 2021.2)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.12+7-b1504.28-7817840)

[√] VS Code (version 1.85.1)
    • VS Code at C:\Users\christian\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.80.0

[√] Connected device (4 available)
    • 5048A (mobile)    • 7P55V8NFFE59SSA6 • android-arm64  • Android 9 (API 28)
    • Windows (desktop) • windows          • windows-x64    • Microsoft Windows [Versi¢n 10.0.19045.3803]
    • Chrome (web)      • chrome           • web-javascript • Google Chrome 120.0.6099.131
    • Edge (web)        • edge             • web-javascript • Microsoft Edge 120.0.2210.121

[√] Network resources
    • All expected network resources are available.

• No issues found!

Hello @christianfunginet.
I added camera: ^0.10.5+9 to my pubspec.yaml file and ran the sample here https://pub.dev/packages/camera/example both on Android and iOS but can't reproduce any issue on my end as it runs fine.
This might be similar to:
https://github.com/flutter/flutter/issues/43247
https://github.com/flutter/flutter/issues/24389
Can you check the comments under these threads to see if any works in your case?

Thanks for your response. Per your last comment, I believe this is working fine now.
Closing this from here, if you disagree, kindly comment and I'll reopen this.


Extremely slow due to the Nuxt Modules!!! I even can not bear that!

Environment
Nuxt project info:                                                                                6:37:53 PM

Operating System: Linux
Node Version:     v20.15.1
Nuxt Version:     3.14.159
CLI Version:      3.15.0
Nitro Version:    2.10.4
Package Manager<EMAIL_ADDRESS>Builder:          -
User Config:      default
Runtime Modules<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>Build Modules:    -

Reproduction
This is my nuxt.config.js:
export default defineNuxtConfig({
	devtools: { enabled: true },
	ssr:true,
	devServer:{
		host:"<IP_ADDRESS>",
		port:8001,
	},
	modules: ["@nuxt/ui", "nuxt-monaco-editor", '@element-plus/nuxt'],
	plugins:[{
		src:"~/plugins/router.js",
		ssr:false,
	}],
	alias: {
		'css':"/assets/css",
		'font':"/assets/font",
		"comps":"/components",
		"pages":"/pages"
	},
	css:["css/index.css"],
	compatibilityDate: "2024-08-05",
})

Very simple, but I found that in the DEV mode, devServer will load the modules' file (in the node_modules) for many times repeatly!
These 3 modules generated about 2k js files needing to load, which spend about 2minutes to load a page, but when I just modify a little bit part of my code(or just wait for some time without doing anything), the version of the js files changed, so I need to load them again!

Only the js files for the 3 modules would be loaded for many times, others wouldn't.
Describe the bug
Like the above, in the loading time, I could do nothing but waiting.There is no response after clicking the link, button or other item.
Additional context
No response
Logs

Hey! This is normal in dev mode due to Vite serving everything unbundled.
It might be worth figuring out which module is causing issues you encounter (+ using Nuxt UI and Element Plus might not be the best idea) & check out https://github.com/nuxt/nuxt/issues/26211 as well.
As this is not a Nuxt issue per sé, I'll close this issue.


[b16] [Compatibility] Adding/altering NBT tags causes aspect lookup failures (fix found?)

Horse armor (iron, gold, diamond) appears to lose all aspects when it gains any additional NBT compound tags, and regain its aspects when removing the tags with an external editor.
This was observed due to an interaction with the "QualityTools" mod, which adds additional random quality modifiers to weapons/armor/baubles, specifically when an item enters the player's inventory for the first time. I noticed that horse armors appeared to have no aspects once picked up, but appeared to have aspects when initially found in dungeon loot chests. With a bit of experimentation, I found that the addition of the "tags/Quality" compound tag to a horse armor (even an empty "Quality" tag) when it was looted from a chest was what triggered the loss of aspects - replacing the item in a chest and deleting the "tags" NBT compound tag tree (with MCEdit) caused the horse armor to regain its aspects (until picked up again, causing it to regain its extra NBT tags).
This issue does not appear to affect any other types of armor/weapons/baubles - only horse armor, in all three materials.
EDIT: A variation of this issue affects Crimson Cult armor/robes. When viewed with JEI, Crimson Cult armor/robes possess a combination of Alienis, Praemunio, and either Metallum or Bestia+Praecantatio aspects. Once a piece of Cultist-wear acquires NBT tags (e.g. through the method described above), it loses most but not all of its aspects, retaining only Praemunio. Hopefully, this slight difference in symptoms between the two categories of item will make it easier to track down the source of the problem.
EDIT EDIT: This issue also affects chain armor and shields - but shields are a little different. I'll try to summarize the results so far:
If there is a compound NBT tag named "tag" (even with no subtags):

Horse armor (all types) loses all aspects (both Praemunio and Bestia);
Crimson Cult armor loses its Metallum and Alienis aspects, retaining only Praemunio;
Crimson Cult robes lose their Alienis, Bestia, and Praecantatio aspects, retaining only Praemunio;
Chain Armor loses its Metallum aspect, retaining only Praemunio.
Shields are unaffected only if there are no subtags inside the "tag" tag.

If there is a compound NBT tag named "tag" which contains any subtags:

Shields lose their Praemunio aspect, and retain Herba and Metallum.

Shields seem to be the "odd one out" so far. Their symptoms are different than the other three armor types - they are unaffected by an empty "tag" tag, unlike the other three categories above, as well as keeping everything but Praemunio. It should be noted that if a shield is customized with any patterns, the information is stored in "tags/BlockEntityTag/", which is sufficient to trigger the loss of Praemunio.
The other difference is that shields are craftable, while horse/Crimson/chain armor is uncraftable (without additional mods). Since (AFAIK) Thaumcraft calculates the aspects for unknown items based on their recipes when possible,  there may be some aspect of the recipe-aspect-calculation algorithm which may either affect or help pinpoint the bug.
EDIT EDIT EDIT: Peeking inside the JAR, I think I'm starting to understand what's going on. It's difficult to interpret code with obfuscated references, but here's what I think is happening:

Calculated aspects for an item are stored in a cache, indexed by a hash of the NBT value list, based on an undamaged stack of one of the item in question. If an item gains/changes NBT tags other than damage or quantity, this changes the hash value, causing a "cache miss" and triggering the generation of a new cache entry for the altered item, and a re-calculation of aspects.
When aspects are being calculated for an item, they can come from two sources: the aspects of the items used from a crafting recipe for that item, and "bonus aspects" based on the type of an item (e.g. Praemunio for armors, Instrumentum for tools, etc.)
The cache is "pre-loaded" with aspects for a baseline set of items, so that the recipe-aspect-calculation has some starting values to work with. Also, aspects for (normally) uncraftable items are pre-loaded in the cache, along with aspects for items which have recipes but need special treatment or some kind of override (e.g. Salis Mundus).
When an uncraftable item is queried for its aspects, altering the NBT tags changes its hash, causing a "cache miss" - the item no longer matches the predefined cache entry. The item recipe is looked up to find baseline aspects, which obviously fails, resulting in the item having only the bonus aspects for its type (e.g. Praemunio for armors).
Horse armor appears to not be recognized as "armor" by the bonus aspect code, so it gains no bonus Praemunio. Since it is also uncraftable, altering the NBT data results in both aspect sources failing, and no aspects at all.
The method for searching for a recipe matching an item appears to ignore NBT tags. A shield with modified NBT tags (from applied patterns or another reason) successfully inherits Herba and Metallum from its recipe. However, shields are also "not armor", so modified shields do not gain bonus Praemunio. The Praemunio in plain shields is from a predefined cache entry, which a modified shield no longer matches, triggering the recalculation and resulting failure to apply bonus Praemunio.

These solutions might work:

Given how the recipe search is unaffected by altered NBT tags, and how it uses getItem() to compare the recipe results with the target item, it may be that the aspect cache lookup also needs to filter its hashes/queries through getItem() (e.g. getStack(getItem(TargetItemStack),1) ), either as its primary lookup or as a secondary lookup if the primary lookup fails.
Horse armor and shields might need to be added to the bonus aspect calculation code. However, this might not be necessary if they can be successfully matched to the cache even with altered NBT tags, using the getItem() filter above.

Hmmm, this is a tough one causing all manner of chicken or egg type situations. I will see if I can figure something out.


Add device address to "device card"

Is your feature request related to a problem? Please describe.
When looking at the device an entity belongs to, I'd also like to see the devices address (MEQ..., 001122...), not just the type and firmware. Now that names are used I'd first have to look into the CCU to get the real address.
Describe the solution you'd like
Add the device address to the card where we also see the firmware.
Additional context
Screenshot of where I would expect the address.:

I don't think this is possible. See
You can see the channel address at every entities attributes.

identifiers
Set of (DOMAIN, identifier) tuples. Identifiers identify the device in the outside world. An example is a serial number.

Wouldn't this be the correct property? I guess it then would be filled with ('hahm', '12345'). I don't know if that would be displayed in the UI though. 🤔

This property is not displayed.
This is what is used :
@property
def device_info(self) -> dict[str, Any]:
    """Return device specific attributes."""
    return {
        "identifiers": {
            (
                self._central.domain,
                f"{self._device_address}{IDENTIFIERS_SEPARATOR}{self._interface_id}",
            )
        },
        "name": self.name,
        "manufacturer": MANUFACTURER,
        "model": self.device_type,
        "sw_version": self.firmware,
        "suggested_area": self.room,
        "via_device": (self._central.domain, self._central.instance_name),
    }

So I guess what I'm seeing with my bulbs is specific to the MQTT integration, not a standard. Ok, then we probably should not put it address there.

Any further ideas to display the SN?
What we not should do is to abuse existing fields like model.

I think as long as HA does not provide an appropriate field for this, we should not hack around this. My suggestion is to label this as wontfix and keep it open. This allows others to see we are aware of this, and why it is not implemented yet. At least I think from time to time someone else could have the same idea and ask for this.

I agree, this would be nice to have.
Did you look at further integrations? ZHA for example:

No, i don't. This is a custom UI for ZHA and not the default one.


how to write code for delayed mailhopper

Hi guys, after some configuration follow read me, I want to ask you question about how to write code for delayed mailhopper?
I write these code for active mailer :
#define mailer class
class CandidateMailer < ActionMailer::Base
default from<EMAIL_ADDRESS>def registration_confirmation(candidate)
@candidate = candidate
mail(:to => candidate.email, :subject => "xxx")
end
end
#send email
CandidateMailer.registration_confirmation(candidate).deliver
and I wonder what kind of code do I need if I use delayed mailhopper?
Thanks for reply.

Did you follow the Mailhopper configuration process too? You'll need to define mailhopper as the delivery method either for your whole app:
MyApp::Application.configure do
  config.action_mailer.delivery_method = :mailhopper
end

Or for individual mailers:
class MyMailer < ActionMailer::Base
  ActionMailer::Base.delivery_method = :mailhopper
end

For a working example see the test app in delayed_mailhopper/test/dummy. Here's its mailer class:
https://github.com/cerebris/delayed_mailhopper/blob/master/test/dummy/app/mailers/sample_mailer.rb

Dan, I'm sorry I miss something. I have following config in my app.
MyApp::Application.configure do
config.action_mailer.delivery_method = :mailhopper
end
And I found that in my db, email table has a lot of data, but there is no data in delayed_jobs table. It seems that I miss some configuration for DelayedMailhopper.

Sounds like a good start. Also,  DelayedMailhopper::Email needs to be configured as the email class for Mailhopper. This should be done by default (with no additional settings), so perhaps you're overriding it in your initializer?
You should be able to either remove this setting from your initializer or set it explicitly, like so:
Mailhopper::Base.setup do |config|
  # The base email class used by Mailhopper
  config.email_class =  DelayedMailhopper::Email
end

If that's set correctly, please let me know your version of ruby, rails, delayed_job and delayed_job_active_record so I can try to reproduce this problem.

I have follow your suggestion and it works. Thanks so much, Dan.
Your guess was right, I have override  config.email_class = Mailhopper::Email in development.rb. It's total wrong.
After I recreate db and follow your steps, finally I got my email. Thanks Dan, thanks your awesome gem.

You're quite welcome - glad it's working well for you now!


Background boppers showing up as an error

Describe your problem here.
I'm trying to add extra background boppers similar to week 5 with the latest build and am using code similar to what I had previously used. This is what it looks like in game:

And this is the code for it:

Using that code for pretty much all the background entities and works fine for everything else except the ones I'm trying to add now.
Are you modding a build from source or with Lua?
Lua
What is your build target?
Windows x64
Did you edit anything in this build? If so, mention or summarize your changes.
No response

make sure the image is called "eh(.png/.xml)" and that it is in mods/images

Ah thanks, I forgot that the second variable was supposed to be the name of the files. Thank you!


[XPathAbstract] Refactor xpath abstract

Yesterday when working on #4038 I was a bit too quick and later I got the idea how to structure the code cleaner and nicer. So I refactored the changes, keeping all existing functionality intact.
While refactoring I also stumbled accross #3672 and wondered if it makes sense to skip calling htmlspecialchars on the feed item contents in special cases. At least for the Atom format it does not seem to make any difference (I get escaped html tags no matter how I set this setting). Any thoughts about that? @User123698745

feed readers escape for html context anyways. And the atom/xml formats escape for xml contect. So i think it's best to include raw unescaped html in feed items indeed.

I added the optional raw_content parameter to the XPathBridge to allow e.g. concat('<b>', .//p/text(), '</b>') to produce html which in this example results in bold text. Without raw_content enabled, <b> and </b> would get escaped / it would have no effect.
 Currently on master it behaves like raw_content is always on (before the default was off). However with this PR it seems you will (accidentally?) repair it. Your current PR commit 062d66ce1e19eb372b9ee5304c6beeef0a3fc664 behaves like it used to after I added raw_content back then.
How raw_content = off (default) should look like:

(currently broken on master, therefore this link will look like on)
https://rss-bridge.org/bridge01/?action=display&bridge=XPathBridge&url=https%3A%2F%2Ftomorrowcorporation.com%2F&item=%2F%2Fdiv[%40class%3D"entryMain"]&title=.%2Fh2&content=concat('<b>'%2C+.%2F%2Fp%2Ftext()%2C+'<%2Fb>')&raw_content=off&uri=.%2F%2Fa%2F%40href&author=&timestamp=&enclosures=&categories=&format=Html
How raw_content = on should look like:

https://rss-bridge.org/bridge01/?action=display&bridge=XPathBridge&url=https%3A%2F%2Ftomorrowcorporation.com%2F&item=%2F%2Fdiv[%40class%3D"entryMain"]&title=.%2Fh2&content=concat('<b>'%2C+.%2F%2Fp%2Ftext()%2C+'<%2Fb>')&raw_content=on&uri=.%2F%2Fa%2F%40href&author=&timestamp=&enclosures=&categories=&format=Html

@dvikan @User123698745 Thank you for your feedbacks. So if I understand you both correct, there is almost no use case for automatically escaping html tags in item contents, right?
So I made a new commit changing the defautl value for that setting, so that html tags won't get escaped unless you manually overwrite that setting.
I suggest to leave it in for know in case there not so obvious are use cases and people want to turn it on for their feeds. In the long run we shoud remove that setting and omit escaping feed item contents by invoking htmlspecialchars.
Do you both agree?

yes i think i agree. anyways i trust you on this one since im not vell versed with xpath bridge,
will merge unless noted otherwise

I agree, too


Incorrect status reported for incomplete logs

In latest master branch, if a MIP log is incomplete (i.e. cut off with no termination message for whatever reason), we might report optimal status incorrectly. For example:
Variable types: 23522 continuous, 2343 integer (0 binary)

Root barrier log...

Barrier solved model in 50 iterations and 72.71 seconds (53.24 work units)
Optimal objective -1.76339641e+08

Solved with barrier

Root relaxation: objective -1.763396e+08, 104343 iterations, 108.23 seconds (79.42 work units)

    Nodes    |    Current Node    |     Objective Bounds      |     Work
 Expl Unexpl |  Obj  Depth IntInf | Incumbent    BestBd   Gap | It/Node Time

here we get 'OPTIMAL' status from ContinuousParser, but no termination message from NodeLogParser.
grblogtoolsv1 would give an 'incomplete log' warning in this situation (and report unknown status? I'm not sure).
We should check for this with some custom logic for Status and Runtime, something like:

If the model is continuous, we can get Runtime and Status from ContinuousParser
If the model is (a) a MIP or (b) a continuous model solved as a MIP, we should ignore Runtime and Status from ContinuousParser

(a) We can check using model type in SingleLogParser
(b) Look for the message Solving as a MIP in header or presolve

If TerminationParser reports runtime or status, it should take precedence (this already happens)

I like the option (a) better. Specifically, we need to change the method SingleLogParser().get_summary() such that:

The model type needs to be determined before adding the continuous parser summary result
If the model type is not continuous, we can set the fields Status and Runtime to None
If there is legit Status and Runtime for non-continuous models, the correct values will be overwritten when adding the termination and nodelog parser summary results

Is it possible for a model to be solved as a MIP while the model type is determined to be continuous?

Yes, Gurobi may solve nonlinear nonconvex but still continuous models as MIPs. But also in this case, we should detect the actual model type either by checking it explicitly (option a) or by scanning for Solving as MIP (option b). I'd prefer option a as well, though.
Another thought: we also don't store the Continuous status for MIPs, right? The Status that was collected is just overwritten later when parsing the final MIP status. So maybe we could keep the ContinuousStatus and only copy it to the Status if the model type is indeed continuous?


Update configure-endpoints-vdi.md

Updated the document as You no longer need to create and seal golden images on a periodic basis, as updates are expanded into their component bits on the host server and then downloaded directly to the VM when it's turned on.

@JohanFreelancer9 Please copy review

Issue#https://github.com/MicrosoftDocs/microsoft-365-docs/issues/8233

@mjcaparas Please merge this PR. Thanks


support for other resolutions

So it seems outputs are always 256x256 - is this a limitation of the model, or is that just a choice based on vram requirements? Would it be easy to enable other resolutions?

Hi, thank you for your interest in our approach. We are currently working on the V2 version, which will support 16:9 video output and higher resolutions. We will release further updates in the future.


Sort repositories by watch status

TL;DR
This PR is a feature addition to sort user repositories by their star/favourite status.
Why?
Many times, I find myself with over 20-ish repositories cluttering up my main page when I am only actively maintaining 2-3 repositories. I have always wanted a simple way to sort them thus I decided to code a quick fix to sort the repositories according to whether I starred them.
Note that this PR does not sort repositories based on number of stars but rather if you, the creator, have starred them yourself.

Please reopen against master.

LGTM (where's the automatic labels addition by lgtm gone ?)

@LefsFlarey there are file conflicts.

Current coverage is 3.13% (diff: 0.00%)

Merging #19 into master will decrease coverage by <.01%

@@            master       #19   diff @@
========================================
  Files           33        33
  Lines         7823      7836    +13
  Methods          0         0
  Messages         0         0
  Branches         0         0
========================================
  Hits           246       246
- Misses        7557      7570    +13
  Partials        20        20

Powered by Codecov. Last update f6d53ec...0eea5f5

They are file conflicts since all raw query has been refactored to use XORM in a previous PR

@LefsFlarey why have you closed this?


How to process very large image matrix example : 100000X100000X3

I try to process TIFF image for GEE, but it cant work, if I want to modify the source code to be multi-process, what parts need to be modified?

One can assume that two sufficiently distance superpixels do not affect each other (- depending on the value range in the image the distance term of the metric will always dominate after some point). So I think a reasonable approach is to split the image into multiple patches and process them independently. Afterwards you would need to handle the superpixels at the patch borders. Depending on your application it may be okay to just leave them as they are.
Otherwise you would need to remove all superpixels that touch the patch borders and reapply the algorithm:
1.) Select a border between two patches.
2.) snic.py, line 95: Initialize the label_map with the superpixelation, but set all labels of superpixels that touch the borders to "-1".
3.) snic.py, line 129: Start new seed indices with NUM_SEEDS_ALREADY_USED+k instead of k
4.) Make sure to place the starting seeds within the cleared area.
After processing the borders, you want to repeat these steps also for all edges where four patches meet.
Due to the sequential nature (=internal use of a priority queue) it is a bit tricky to adapt SNIC to parallel processing and the things I described are just a quick workaround. Depending on your application you may want to have look at other superpixelation algorithms like e.g. SLIC which should be easier to parallelize. If you are planning to process large amounts of data you may also want to consider using the original C++ code which is significantly faster (https://www.epfl.ch/labs/ivrl/research/snic-superpixels/)

Thank you very much for your reply


Secondary button hover broken

Looks like this was changed recently in https://github.com/microsoft/vscode/pull/121779

@misolori I'm wondering how to test this change? Does this change affect the terminal tabs + button with the dropdown?


Update oauth-proxy version in compatiblity table for 2.8

The oauth-proxy version was bumped to v4.14 in https://github.com/opendatahub-io/data-science-pipelines-operator/pull/725

/lgtm
/approve
thanks!


mrudulamanoj's file

No description provided

No description provided

created a branch, created a file and made a commit, and opened a pull request

created a branch, created a file and made a commit, and opened a pull request

created


06/18/2018 01:00 : Create Pull Request for branch prTesting_2018061800 -> master

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

split/updateTestCon.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


ACME - action to push a cert to Ruckus ZoneDirector or Unleashed

I'd like to see this capability added which is similar to other Acme actions, here's an example of a working method in pfSense: https://ms264556.net/pages/PfSenseLetsEncryptToRuckus
Tried doing this myself, but don't have the cycles to come up to speed on PHP, MVC, ...

@alaricljs the initial step would be to add a deploy hook to acme.sh.
If you add a feature request to the acme.sh issues, and ping me the details, then I can look at doing a PR if I have some spare time.

@alaricljs the initial step would be to add a deploy hook to acme.sh.
If you add a feature request to the acme.sh issues, and ping me the details, then I can look at doing a PR if I have some spare time.

https://github.com/acmesh-official/acme.sh/issues/5035

There's an open PR which adds support for deploying to Ruckus Unleashed. I tested it by hand on my OPNsense deployment and it worked perfectly. I posted a comment over there with the details.
Unfortunately the PR has been open for quite some time with no response, so I'm not really hopeful for forward progress, other than what I've already done!

Good news -- the upstream PR is merged into the acme.sh dev branch. I'm not totally familiar with how their dev branch changes flow into a release, but I guess it'll happen soon enough. After that's in, then this plugin can get updated to include the deploy hook option?

@ms264556 That's correct. 👍 When the functionality was added to acme.sh, just ping me here and I'll reopen this issue (it will most likely be closed due to timeout).

Hi @fraenki. The ruckus deploy book has landed in acme.sh master now, so you can re-open this issue. Thanks!

The ruckus deploy hook has landed in acme.sh master now

Great! Unfortunately it did not make it into the acme.sh 3.1.0 release. So we'll have to wait for the next release of acme.sh, which will most likely include the "ruckus" deploy hook.
Note to myself: link to the hook documentation.


Prometheus v2.2.0 deadlocked loading targets page

Heres the stack trace: https://gist.github.com/tomwilkie/af4ffa4c8f50f723b55f8d4fd82f7c9c
I'm diagnosing...

Looks like its blocked here: https://github.com/prometheus/prometheus/blob/master/scrape/manager.go#L120

@krasi-georgiev that has good odds of being a regression from the scrape refactoring. Over the years we had more deadlocks caused by loading target page than I can count – and they all came somewhere from there :)

Sorry I didn't add more background:

I think I hit the targets page very quickly after the instance came up.
I was debugging something else so I got the stacks and then threw the instance away, and it didn't reoccur.
This was with the v2.2.0 docker release image.
The instance was around for about 5mins and other endpoints worked, but couldn't load the targets page for the entire time.
It didn't look like it had managed to find any targets though, as there was no data in it.

I will have a look when I get bored poking with tsdb  :+1:

There are a bunch of goroutines all blocked at roughly the same point - goroutine 1114, 1293, 1118.  Goroutine 1118 is holding m.mtx write lock, and blocked on the getting the scrape pool read lock.  The scrape pool write lock is being held by scrapePool.Sync (goroutine 183) which is waiting for scrapers to stop.  The scrapers in turn are blocked on remote write, which is blocked on resharding, which is blocked on the remote write bug I was trying to fix (#3809).

As 3809 is fixed, looks like nothing to fix here.


Add adjustments

@mnaichuk We have discussed adjustments with Business Analyst.
We don't need UPDATE of adjustments for now. So you can remove all related code

Also add description & co-authors


add cve field in twistlock scan

Please submit your pull requests to the 'dev' branch.
When submitting a pull request, please make sure you have completed the following checklist:

[x] Your code is flake8 compliant (DefectDojo's code isn't currently flake8 compliant, but we're trying to correct that.)
[ ] If this is a new feature and not a bug fix, you've included the proper documentation in the ReadTheDocs documentation folder. https://github.com/DefectDojo/Documentation/tree/master/docs or provide feature documentation in the PR.
[ ] Model changes should include the necessary migrations in the dojo/dd_migrations folder.
[ ] Add applicable tests to the unit tests.

why PostgreSQL Travis test is failing?


Spells from talents no longer working on era

After a recent patch, the library no longer checks for range of spells learned from talents on era. For example, the library can not check for 24yd with a shadow reached mind flay.

What is a "shadow reached" mind flay?

What is a "shadow reached" mind flay?

https://www.wowhead.com/classic/spell=17323/shadow-reach buffs the range

Oh that requires level 25, that's not something I can reasonable do.
Looking at the spell list "Mind Flay" is not in there, are you saying that adding a line: tinsert(HarmSpells.PRIEST, 15407) -- Mind Flay (20-24 yards) would allow the library to check more ranges?

I've had the line: tinsert(HarmSpells.PRIEST, 15407) -- Mind Flay
added in my local file since forever (or equivalent line in 2.0 of the library). It was working until a wow patch broke it during 1.0.16 of the library, and got quickly fixed in 1.0.17. Now it is broken again in 1.0.17 after another wow patch.


Timer handler

Hello and thank you for this code.
However I wonder if I can call the timer in any other rakwireless code, like this one:
https://docs.rakwireless.com/Product-Categories/WisBlock/RAK12034/Quickstart/
Because I want a timer to be called every 20 mi.
The "usual" Timer1 library did not work, probably because it's actually a stm32  doing the job. But I don't think I can use regular cube IDE commands as well.
Any suggestions?
Kind regards Dom

For sure you can adapt it to use the RAK12034.
Why do you say "Timer1 library did not work", can you give more details? Why do you need to call the timer every 20 milliseconds (I guess that's what you mean with "20 mi")?

html,body{background-color:#fff;color:#333;line-height:1.4;font-family:sans-serif,Arial,Verdana,Trebuchet MS;}Hello Bernd,
TimerOne is a arduino library (https://www.arduino.cc/reference/en/libraries/timerone/) at my first try it did not work at all, if it should work I will analyse it further.
20mi means every 20 Minutes. That is becuase of the use case. In short: if the interrupt is not triggered within 20 minutes it should be triggerd by the timer externally.
Kind regards Dominik
Bernd Giesecke schrieb am 22.08.2023 03:07 (GMT +02:00):
For sure you can adapt it to use the RAK12034.Why do you say "Timer1 library did not work", can you give more details? Why do you need to call the timer every 20 milliseconds (I guess that's what you mean with "20 mi")?
—Reply to this email directly,  view it on GitHub, or  unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

Why do you want to use a timer library when RUI3 has already a timer function?
Just setup the timer with a callback function as shown in our documentation

You are right but at the beginning I did not think about the Rui3 functions. I will use the implemented functions of course 😊
Btw. Do you know how to flash the 3172 directly with the STM link? The reference tells me to use the pins. Do this mean directly, like soldering to the pins , or is there a break out?
Kind regards Dominik
Am 22. August 2023 07:09:02 MESZ schrieb Bernd Giesecke @.***>:

Why do you want to use a timer library when RUI3 has already a timer function?
Just setup the timer with a callback function as shown in our documentation
--
Reply to this email directly or view it on GitHub:
https://github.com/beegee-tokyo/RUI3-LowPower-Example/issues/1#issuecomment-1687437459
You are receiving this because you authored the thread.
Message ID: @.***>

I don't have the STM Link. I am using sometimes the STM32CubeProgrammer but using the UART port of the RAK3172.
But usually I am using a JLink adapter:

I guess the connections to a STM Link adapter are similar, but I have no connection diagram for it.

html,body{background-color:#fff;color:#333;line-height:1.4;font-family:sans-serif,Arial,Verdana,Trebuchet MS;}Ahh Ok this was my fault because I actually ment the RAK3372, which is obvisouly using the RAK 3172 and already has breakout pins at P1:
.So now I am going to try out the timer for Rui3 :-)
Bernd Giesecke schrieb am 22.08.2023 08:47 (GMT +02:00):
I don't have the STM Link. I am using sometimes the STM32CubeProgrammer but using the UART port of the RAK3172.But usually I am using a JLink adapter:
I guess the connections to a STM Link adapter are similar, but I have no connection diagram for it.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

I got it working. Thanks.


ARROW-8844: [C++] Transfer bitmap in words

Copy/Invert bitmap in words improves performance significantly.
Partial aligned case jumps from 914M/s to 6.6G/s, and non aligned
case from 82M/s to 3.8G/s on my test machine.

Tested on AMD Zen1 with gcc-7.5
before (CopyBitmapWithOffsetBoth is added by this patch)
CopyBitmapWithoutOffset/8192                  190 ns          190 ns      3678223 bytes_per_second=40.0804G/s
CopyBitmapWithOffset/8192                    8548 ns         8548 ns        81846 bytes_per_second=914.007M/s
CopyBitmapWithOffsetBoth/8192               95447 ns        95445 ns         7334 bytes_per_second=81.8531M/s

after
CopyBitmapWithoutOffset/8192                  191 ns          191 ns      3670699 bytes_per_second=39.9939G/s
CopyBitmapWithOffset/8192                    1151 ns         1151 ns       600632 bytes_per_second=6.62768G/s
CopyBitmapWithOffsetBoth/8192                2018 ns         2018 ns       346761 bytes_per_second=3.78089G/s

There are similar codes in my three recent patches optimizing unaligned bitmap operations (logical, compare, copy). I opened a new jira to refine. https://issues.apache.org/jira/browse/ARROW-8979

@ursabot benchmark --suite-filter=arrow-bit-util-benchmark --benchmark-filter=CopyBitmapWithOffset

AMD64 Ubuntu 18.04 C++ Benchmark (#108408) builder has been succeeded.
Revision: ef4d77c
  =============================  ===========  ===========  ============
  benchmark                         baseline    contender        change
  =============================  ===========  ===========  ============
  CopyBitmapWithOffsetBoth/8192  2.48133e+09  2.48132e+09  -3.12173e-06
  CopyBitmapWithOffset/8192      4.14268e+09  4.14273e+09   1.20158e-05

I'll need to fix this, tried to address this last time, weirdly it was fixed locally...

Is there a JIRA about fixing the legibility of the benchmark diff?

@ursabot benchmark --suite-filter=arrow-bit-util-benchmark --benchmark-filter=CopyBitmapWithOffset origin/master

@ursabot --help

@ursabot build

@ursabot benchmark

@ursabot benchmark --suite-filter=arrow-bit-util-benchmark --benchmark-filter=CopyBitmapWithOffset origin/master

@ursabot build

@ursabot benchmark --help

@ursabot benchmark --suite-filter=arrow-bit-util-benchmark --benchmark-filter=CopyBitmapWithOffset origin/master

once https://github.com/ursa-labs/ursabot/pull/197 is merged, we shouldn't need to specify origin/master as a baseline.

Needs rebase

The RTools 4.0 build was hanging so I triggered a new build


Localize web3modal with new languages

Is your feature request related to a problem? Please describe.
Web3modal usage is global, but the modal is english only.
Describe the solution you'd like
Add more languages.
Additional context
WalletConnect modal supports several languages.

any update on this ?

Just a thought : Can use a translation api to convert ui texts on the fly and present the user with the translated text

Any updates?

Any updates?


[WIP]: non-admin branch rebased onto master

Rebased the non-admin branch onto the master branch. The
next step is to see if I can cherry-pick commits and group
them logically in smaller PRs to make reviews faster and easier.

\test

\test

Related to #388

@alaypatel07 not sure if it'll make sense to create this quite yet, but since this PR changes mig-operator CRs as well, we'll need a corresponding PR linked from over there for eventual merge.

I successfully ran a migration using this today :)
spec:
  migPlanRef:
    name: migplan-3110-44
    namespace: test-user
  stage: false
status:
  conditions:
  - category: Advisory
    durable: true
    lastTransitionTime: "2020-06-22T21:50:46Z"
    message: The migration has completed successfully.
    reason: Completed
    status: "True"
    type: Succeeded
  itenerary: Final
  observedDigest: 0e5c50c035148cf79ee93d0fc5d443204bc19a42b0c822d90bb72695c3f386a8
  phase: Completed
  startTimestamp: "2020-06-22T21:43:54Z"

We'll need to rebase this PR and change logging to use common logger and wrapped error system (https://github.com/konveyor/mig-controller/pull/595) before 1.4.0 release


Create sample.workbook

added a sample work book
PR Checklist

[ ] Explain your changes, so people looking at the PR know what and why, the code changes are the how.

If adding or updating templates:

[ ] post a screenshot of templates and/or gallery changes
[ ] ensure your template has a corresponding gallery entry in the gallery folder
[ ] If you are adding a new template, add your team and template/gallery file(s) to the CODEOWNERS file. CODEOWNERS entries should be teams, not individuals
[ ] ensure all steps have meaningful names
[ ] ensure all parameters and grid columns have display names set so they can be localized
[ ] ensure that parameters id values are unique or they will fail PR validation (parameter ids are used for localization)
[ ] ensure that steps names are unique or they will fail PR validation (step names are used for localization)
[ ] grep /subscription/ and ensure that your parameters don't have any hardcoded resourceIds or they will fail PR validation
[ ] remove fallbackResourceIds and fromTemplateId fields from your template workbook or they will fail PR validation

@mohammadhussain689 this PR is almost a year old and not merged.  closing it.


Configurable WIP label

WIP issue handling has been removed so no need to add it back - it's not the focus of this bot.


Unable to see content in subfolders?

It seems that Pico Editor doesn’t get content pages that are in ‘categories’ i.e. in a subfolder of /content.
For instance /content/projects/project1.md is not displayed in the editor. There’s an ‘Untitled’ line which may be this, but the content is said to be ‘unvalid’.

Bump on this issue.
Any plans to fix the 'Error: invalid file' issue for files in subfolders of 'content' folder?

Fix for bug: https://github.com/gilbitron/Pico-Editor-Plugin/pull/20

Change line 292
$file = basename(strip_tags($file_url));

into
$file = substr(strip_tags($file_url), 1);

basename()was removing the sub-folder, aditionaly, the urls where being requested with double slash (example.com//page), that might have security implications according to this stackoverflow answer.


Output table

This PR adds a function to produce a table of macro output.  In addition, updates are made to parameter and output plotting functions.

Codecov Report

Merging #483 into master will increase coverage by 3.32%.
The diff coverage is 70%.

@@            Coverage Diff             @@
##           master     #483      +/-   ##
==========================================
+ Coverage   59.65%   62.97%   +3.32%
==========================================
  Files          40       45       +5
  Lines        5316     5470     +154
==========================================
+ Hits         3171     3445     +274
+ Misses       2145     2025     -120

Impacted Files
Coverage Δ

ogusa/tests/test_SS.py
83.03% <ø> (-0.07%)
:arrow_down:

ogusa/tests/test_output_tables.py
100% <100%> (ø)

ogusa/constants.py
100% <100%> (ø)
:arrow_up:

ogusa/tests/test_parameter_plots.py
100% <100%> (ø)

ogusa/tests/test_parameter_tables.py
100% <100%> (ø)

ogusa/tests/test_output_plots.py
100% <100%> (ø)

ogusa/output_plots.py
55.49% <22.72%> (+47.51%)
:arrow_up:

ogusa/output_tables.py
55.22% <55.22%> (ø)

ogusa/parameter_plots.py
78.12% <80%> (+66.29%)
:arrow_up:

... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ba038d...dc971ba. Read the comment docs.

@jdebacker Is this ready to be merged? It looks good to me.

@rickecon - yes this is ready to go.  Thanks.


feat: rewrite wordWrap function

😮💨😮💨😮💨
yarn bench
Running "Word Wrap" suite...
Progress: 50%

  hexo-util-rs:
    46 864 ops/s, ±0.87%
Progress: 100%

  hexo-util-rs:
    46 864 ops/s, ±0.87%    | slowest, 79.49% slower

  hexo-util:
    228 459 ops/s, ±1.77%   | fastest

Finished 2 cases!
  Fastest: hexo-util
  Slowest: hexo-util-rs

Completed in https://github.com/liby/hexo-util-rs/commit/5a8a034cb2ec503de4538a652bbbb6a2e0de70cf


[AutoPR alertsmanagement/resource-manager] Changed the descriptions of multiple items to bring more clarity for users.

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/4365

(message created by the CI based on PR content)

This PR has been merged into https://github.com/Azure/azure-sdk-for-python/pull/3723


WinMD: make the tables publicly visible

Expose the table schema and fields publicly.  This allows iteration of
the tables outside of the module.  This is intended to support
separation of the parsing/processing of the metadata and generation of
the bindings.

Codecov Report

Merging #85 (d484945) into main (4c6588c) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main     #85   +/-   ##
=====================================
  Coverage   9.80%   9.80%
=====================================
  Files         53      53
  Lines       1152    1152
=====================================
  Hits         113     113
  Misses      1039    1039

Impacted Files
Coverage Δ

Sources/WinMD/CILTables.swift
0.00% <ø> (ø)

Sources/WinMD/Tables/Assembly.swift
0.00% <ø> (ø)

Sources/WinMD/Tables/AssemblyOS.swift
0.00% <ø> (ø)

Sources/WinMD/Tables/AssemblyProcessor.swift
0.00% <ø> (ø)

Sources/WinMD/Tables/AssemblyRef.swift
0.00% <ø> (ø)

Sources/WinMD/Tables/AssemblyRefOS.swift
0.00% <ø> (ø)

Sources/WinMD/Tables/AssemblyRefProcessor.swift
0.00% <ø> (ø)

Sources/WinMD/Tables/ClassLayout.swift
0.00% <ø> (ø)

Sources/WinMD/Tables/Constant.swift
0.00% <ø> (ø)

Sources/WinMD/Tables/CustomAttribute.swift
0.00% <ø> (ø)

... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c6588c...d484945. Read the comment docs.


[Mobile] Filter tooltip on mobile overlays filter check boxes

Filter tooltip on mobile overlays filter check boxes -> bug

Expected result: seems that on mobile we can skip the tooltip, don't show it. Please check also the same filter in prompts.

Verified on iPhone XS on staging successfully


classdiagram not works in mermaid live_editor

I sorry if the question is  stupid but it does make me confused.
==========     Problem Description    ==========
I copyed  your demo about  the classdiagram to the mermaid live editor,  but it happen to failed with promotion " Invalid syntax".

I also found that the live editor docs lack the usage introduction about classdiagram.

Does the live editor not support  classdiagram ?  Is there any other way to  make the code work  ?

I am trying to access the same via R programming DiagrammeR but it is not working for me too....
What should We do please document.

Class diagram is experimental feature and it is not officially announced.

Now it support class diagram: https://mermaidjs.github.io/mermaid-live-editor/#/edit/Y2xhc3NEaWFncmFtCkNsYXNzMDEgPHwtLSBBdmVyeUxvbmdDbGFzcyA6IENvb2wKQ2xhc3MwMyAqLS0gQ2xhc3MwNApDbGFzczA1IG8tLSBDbGFzczA2CkNsYXNzMDcgLi4gQ2xhc3MwOApDbGFzczA5IC0tPiBDMiA6IFdoZXJlIGFtIGk_CkNsYXNzMDkgLS0qIEMzCkNsYXNzMDkgLS18PiBDbGFzczA3CkNsYXNzMDcgOiBlcXVhbHMoKQpDbGFzczA3IDogT2JqZWN0W10gZWxlbWVudERhdGEKQ2xhc3MwMSA6IHNpemUoKQpDbGFzczAxIDogaW50IGNoaW1wCkNsYXNzMDEgOiBpbnQgZ29yaWxsYQpDbGFzczA4IDwtLT4gQzI6IENvb2wgbGFiZWw
But it is still an experimental feature and there are known bugs.


Allow non-custom Warnings to have thier Titles edited, opt-in

@Xon Is this same as this?

@ticktackk yup.
My thoughts are UI wise is that a) the text box only shows up under the selected radio control. b) change the text label into a textbox if that radio control is selected

I think the first one would be better with the slide Up and slide down animations

Note; please test this in radio & select menu modes, being a bit buggy w.r.t to setting the title.

@Xon

What do you think?

@ticktackk LGTM, how about the select-view?

Wanted to make sure if you were okay with how this was working first :)

@Xon added the same effect for select view as well with this commit : https://github.com/Xon/XenForo2-WarningImprovements/pull/43/commits/eeed3046570adb9ebcd5d9528c976b44c10a3de6

This results in a default being added to the custom warning option:

This isn't desirable as a custom warning should require them to enter a title without any default.

@Xon should be fixed with this commit : https://github.com/Xon/XenForo2-WarningImprovements/pull/43/commits/d89c96468628169ddd2c0fcca0c9ad3dfc7030a6

In select-menu it doesn't populate for non-custom warnings now.
Works fine for radio boxes

@Xon fixed with commit : https://github.com/Xon/XenForo2-WarningImprovements/pull/45/commits/744ddba8cbe994c061b33f3cdc3ab390b1a3a6f1


Add a disclaimer on taker startup

Display a modal pop-up that goes away when it gets acknowledged.

can you add a screenshot please?

screenshot:

bors r+

bors r+

bors r+

somehow bors was asleep yesterday :|


https://tms2.jrgp.org/index.php?action=maps | missing game modes

Any shows up twice and DOM and DM are missing

Removed the duplicated ANY. DOM and DM will appear once there are maps using those game modes.


Add optional GZIP compression to proxy /metrics endpoint

Closes #598.
According to the Prometheus documentation, metrics export endpoints should support serving metrics compressed using GZIP. I wrote a quick library for gluing together flate2 and hyper, and used it to add support for serving GZIP-encoded metrics to the proxy.
I've also added a new unit test that attempts to get the proxy's metrics endpoint as GZIP, and asserts that the metrics are decompressed successfully.

Would you mind merging master when you get a moment?

@olix0r done!

I didn't review the code in detail. The main concern I have with this is the memory allocation. Are we allocating a buffer that holds the huge uncompressed data and then allocating new buffers for the smaller-but-hard-to-reason-about compressed variants, causing quite a lot of memory allocation? It would be bad to be potentially using our entire memory allocation budget just to serve the metrics.

@seanmonstar and @briansmith, I've made some significant changes in ac264c8b15238717b31ae2dfb3d52995cc14fe39 based on your suggestions. In particular, the metrics server no longer spawns a new task for compressing the metrics, and should now only allocate one Vec rather than several.
I'd still like to be able to do this without buffering at all but that doesn't seem possible with the currently available APIs in hyper and deflate-rs, so hopefully the current approach will at least cut down on allocations. It's certainly much simpler!

This functionality could (and probably should) live in tower-http.
Moving it over is not a blocker, of course.

@carllerche I totally agree, that's why my first pass at implementing this was in a small library, so that it could eventually become part of tower. I'd be happy to work on adding a more generalized implementation to tower-http when more time-critical work is out of the way :)

Looks like the build failure for d080479eaa91e890030ae819a6823df8db3157d2 is due to an unrelated flaky telemetry test. I've opened #831 to track that issue and am restarting the build.

@olix0r I'd like to get your approval on this before merging (as @briansmith has now approved it).


Documentation suggestion

When using the Universal Render Pipeline, add a Render Im Gui Feature render feature to the renderer asset. Assign it to the render feature field of the DearImGui component.
This line is confusing, I spent some time trying to add a "render feature" and then add that "render feature" to the imgui component. But in reality i needed to update the "renderer asset".
I know that's what the docs say, but it was worded confusing. If i'm the only person who has the issue just close this, but being a little more clear might help folks trying to get started. <3
thanks for putting this project together, i appreciate the effort.

Hey, I don't understand this either.
There is no "renderer asset", I guess you mean the "pipeline asset"? And I don't see any "render feature" in the pipeline asset (at least in HDRP), or anywhere else. I also don't see the "render feature" field of the DearImGui component.

Same here, i tried to add all those things, but still confused on how to achieve the needed result. Can someone give us some insight on how to achieve that

I had the same issue and here is what you need to do (what the doc says but with pictures):
You have this issue because you created a Universal Render Pipeline (URP) Asset, and it's set it in your project settings:

In this URP Asset, you have set a Forward Renderer Data:

(Optional)
If you didn't set a Forward Renderer Data, create your own:

(End of Optional)
In this Forward Renderer Data, you need to click "Add Renderer Feature" and select the ImGui Feature.

 I hope this helps.

Many thanks @millonf - Really appreciated and save me a headache or two.


Reduce canvas margin

Description
This is a minor esthetic PR increasing the canvas size by reducing the canvas margin. Space is rare on a Windows FullHD screen (1920x1080) with zoom level 150%, which is default after operating system installation. The screenshots below show napari in full screen mode.
The margins around the canvas appear quite wide. Especially the thick margin on top of the canvas appears not reasonable.

This PR reduces the margins, makes them more symmetric around the "..." buttons and increases space to look at images :-)

Type of change

[x] Minor layout change

References

How has this been tested?

[x] I tested manually, on Windows only

Final checklist:

[x] My PR is the minimum possible work for the desired functionality
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] If I included new strings, I have used trans. to make them localizable.
For more information see our translations guide.

Great! Do you know what's preventing the dock widgets from actually being symmetric and being at the same distance from the ...?

Great! Do you know what's preventing the dock widgets from actually being symmetric and being at the same distance from the ...?

Not sure what you mean. It looks quite symmetric to me. If you think fine tuning is necessary, feel free to make suggestions for other margin numbers. I don't insist in these precise numbers. And it might be a good idea if a non-Windows user tried it anyway 😉

I just don't know where these numbers are set

The inner (shorter) width is set here in my PR. The outer (longer) width depend on the dock widget.

Yeah as Nick says I am super anti-margins!!! :joy: :tada: thanks @haesleinhuepf!
For everyone's benefit, my vision for the eventual look was for all the panels to be floating within the canvas, which would be the whole window. I think that would be pretty sweet, though it would make things like centering trickier. So in the meantime this is way better. :joy:


Design Layout for Home Page

Create the layout for the home page first section

Do I need to initialize Vite first?

please assign me this issue. I want to contribute in this issue

I have created the project set-up and designed the home page, please check


CORGI-558, CORGI-559: Add missing filters

@jasinner Let's discuss the approach since I'm not sure this is possible. We want to filter for only go-package or gomod type components, using the go_component_type key we set in the meta_attr. But it looks like this key isn't present if:

We're creating a golang component as a source of some container
We're creating a golang component discovered by Syft
Maybe other cases as well

As a side-effect of how I implemented the filter, setting the filter to "YES" means only showing gomod components. go-packages and golang components with an unknown type will be hidden.
Setting the filter to "NO" means only showing go-package components. gomod components and golang components with an unknown type will be hidden.
The golang components with an unknown type will only be shown when the user doesn't click anything in the filters box, or when the user gives a URI like ?type=GOLANG&gomod_components= with an empty gomod_components parameter.
I could adjust this to always treat a golang component with unknown type as a gomod component (or a go-package). Is this worth pursuing further, or should we close this as CANTDO? Or maybe you know of some way to determine whether these unknown golang components are really gomod components or go-packages.

I think it's safe to assume that a container source is always a go module. Also, Syft doesn't support detection of go packages, so we could improve the Syft collector to always set the type to that.
However, most of the GOLANG components without go-component-type meta_attr field set are from rpm spectfiles:
{code}

m.Component.objects.filter(type="GOLANG",meta_attr__contains={"source":["specfile"]}).exclude(meta_attr__has_key="go_component_type").count()
12182
m.Component.objects.filter(type="GOLANG").exclude(meta_attr__has_key="go_component_type").count()
12469
{code}

I'm not sure if we're ever going to be able to tell for sure if they are modules or packages. Perhaps we should guess and set them to modules if the len of path elements is 2, as in 'k8s.io/metrics/', versus 'k8s.io/metrics/pkg' for a package. However, given the low number of these, and the poor data quality of go packages detected by specfiles I would suggest we just exclude them from the results.


Explore Data Page: Sort Buttons Issues (visibility, a11y)

[ ] Explore relationships between x and y in z	SR	[A11Y - Health Equity Tracker]: Screen reader announces hidden content in Explore relationships page_Web_1.16(c)	"ENVIRONMENT:
macOS 11.3 | Chrome Version 90.0.4430.212 (Official Build) (x86_64) | Voiceover
Chrome OS Version 91.0.4472.60 (Official Build) beta (64-bit) | Chromevox
PRE REQUISITES:
Turn on the respective screen reader
STEPS TO REPRODUCE:
1). Open https://healthequitytracker.org/exploredata
2). Perform action on next button to reach the final sub page
3). Verify the options are selected as such, the page is 'Explore relationships between Diabetes and Covid-19 in United States.
4). Navigate to 'Diabetes cases per 100K' & 'Total Covid-19 cases per 100K' section on the page
5). Navigate through the section
6). Observe the announcement.
EXPECTED RESULT:
Screen reader should announce content available on the page and it shouldn't announce hidden content.
OBSERVED RESULT:
Screen reader announces content not visible on the page. Content under the Highest/Lowest rates is announced by screen reader even when the section is in collapsed state.
Replication vide attached"		Same issue is observed on Compare rates page.

[ ] Explore relationships between x and y in z	SR	[A11Y - Health Equity Tracker]: Sort button on table column header doesn't have a label_Web_1.1	"ENVIRONMENT:
macOS 11.3 | Chrome Version 90.0.4430.212 (Official Build) (x86_64) | Voiceover
Chrome OS Version 91.0.4472.60 (Official Build) beta (64-bit) | Chromevox
PRE REQUISITES:
Turn on the respective screen reader
STEPS TO REPRODUCE:
1). Open https://healthequitytracker.org/exploredata
2). Perform action on next button to reach the final sub page
3). Verify the options are selected as such, the page is 'Explore relationships between Diabetes and Covid-19 in United States.
4). Navigate to 'Diabetes cases by Race & Ethnicity' & 'Total Covid-19 cases by Race & Ethnicity' section on the page
5). Navigate through the table under the section
6). Observe the announcement.
EXPECTED RESULT:
Button should a label and it should be properly announced by screen reader.
OBSERVED RESULT:
Sort button on table column header doesn't have a label. Screen reader announces the sort button only as button.
Replication video attached"	https://drive.google.com/file/d/1bieRiaR6NvleRlem692b8qpgKVQOI6Cr/view?usp=sharing	"Same issue is observed on Compare rates page.
Issue isreplicable in the following Android environment:
Device: Pixel 4
Android Version: 11
Chrome Browser Version: 91.0.4472.101

[ ] Explore relationships between x and y in z	SR	[A11Y - Health Equity Tracker]: Improper focus and announcement when user performs action on sort button_Web_1.3	"ENVIRONMENT:
macOS 11.3 | Chrome Version 90.0.4430.212 (Official Build) (x86_64) | Voiceover
Chrome OS Version 91.0.4472.60 (Official Build) beta (64-bit) | Chromevox
PRE REQUISITES:
Turn on the respective screen reader
STEPS TO REPRODUCE:
1). Open https://healthequitytracker.org/exploredata
2). Perform action on next button to reach the final sub page
3). Verify the options are selected as such, the page is 'Explore relationships between Diabetes and Covid-19 in United States.
4). Navigate to 'Diabetes cases by Race & Ethnicity' & 'Total Covid-19 cases by Race & Ethnicity' section on the page
5). Navigate to the sort button on table column header and activate
6). Observe the behavior & announcement.
EXPECTED RESULT:
Screen reader focus shouldn't reset when user performs action on sort button and the screen reader should announce the successful completion of sort in a proper manner.
OBSERVED RESULT:
When user performs action on sort button using chromevox, screen reader focus resets to the top of the page. User has to renavigate the whole page content to reach the table which can be cumbersome for the user. When user performs action on sort button using voiceover, screen reader announces dimmed, which can be confusing for the user.
Replication video attached"	https://drive.google.com/file/d/1CUBGgkCCQ1omPi8brISJM_-W_QkgVrET/view?usp=sharing	Same issue is observed on Compare rates page.

https://user-images.githubusercontent.com/41567007/129074786-5d5dba20-7626-4daf-93f2-5b5d8fa86892.mov


Ignoring http pages depending on their content-type

When I run the download of long pdf article it often get failed by timeout on my application side.
Change:

PDFs are ignored by default
It's possible to add other content types for the ignoring list
It's possible to switch off this ignoring by passing configuration ignored_content_types_defaults value

Final request: can you also add instructions on how to add content-type filters to our library's users in the README or/and in the docs?
Here is an example of adding changes to our docs: https://github.com/codelucas/newspaper/pull/302/files
Here is a link to our docs: https://newspaper.readthedocs.io/en/latest/

Also, as a follow up TODO after this is merged it would be amazing if we added a guide (and suggestion for people on how to ignore PDFs or other big files) in the readme tutorial on doing this

Excellent work @ekaterinasmarp! merging 💯


Allow html in the alert message

On this line:
https://github.com/matowens/ng-notify/blob/master/src/scripts/ng-notify.js#L67
if you change "ng-bind" to "ng-bind-html" you can pass html into the alert. This was a change I needed to make on my project.
Not sure if that's worth creating a fork and pull request for or not. Figured I'd post it in case anyone wanted to do the same thing.

Ha! I just saw that this was specifically removed from the code in a previous commit. Sorry, I should have looked into it more before posting.


Adding a filter for custom error respnse codes to be added as CE extensions

Signed-off-by: Matthias Wessendorf<EMAIL_ADDRESS>Fixes #2376

Proposed Changes

adding custom header prefix for enhancing failed couldevents when sent to dead letter sink

Release Note

If a fail response contains a custom http header that starts with `kne-`, the prefix will be removed and the rest of the header will be used as the CE extension on the CloudEvent delivered to the dead letter sink.

Docs

TODO: will add test(s)

/cherry-pick release-1.7

/cherry-pick release-1.6

/retest

/retest

/test integration-tests

/test reconciler-tests-namespaced-broker

/test channel-integration-tests-sasl-plain


UML diagrams and API documentation

Verifying, and updating if necessary, UML diagrams and API documentation.
Checking the API respects Richardson Maturity Levels 1, 2 and 3.
Time estimate : 2 days.

The API and it's App are now done. Maybe a few things left to correct but i can close this issue.
Done in : 2 days.


Breaking changes in latest version

In #16, I rewrote the entire code base to both streamline configuration and enable more flexibility. As a result, I made the following breaking changes to the plugin:

Removed visual customization options index_format, padding, and icons, all of which are now available under the new tab_format option (see the README for more info)
Removed map options kill_maps, custom_command, and custom_command_prefix in favor of a new helper, buftabline.map(), which makes it easier to write custom commands targeting buffers in the bufferline (again, please see the README)
Completely removed options modifier, show_no_name_buffers, and next_indicator, which I deemed unnecessary

Other non-breaking changes:

icon_colors is set to true by default, which is in line with other plugins that integrate with nvim-web-devicons (e.g. telescope.nvim)
hlgroups is now a table and allows for further customization of buffer colors, but (for now) the old config options hlgroup_current and hlgroup_normal are still valid

Thank you for your patience! If I removed an option you relied on, broke something, or otherwise did something you are unhappy about, please let me know in this issue or open up another.

I don't know if this is related, but the wrong characters seem to be highlighted with the devicon colours:

My config:
require('buftabline').setup {
    tab_format = ' #{n}: #{b}#{f} #{i} ',
}

Definitely related, and I see the same problem on my end with that same format. Will look into it – thanks for reporting.

@p00f Multibyte characters are a pain, but I think 7d82600f8a49e657120f714011bfd51783707d7d should take care of it, so let me know!

Yes :partying_face:

show_no_name_buffers is still useful for when you first open nvim. Instead of seeing a completely empty, single-colored bar at the top, you at least get one buffer called [No Name]. Maybe I'm weird, but I sorta like having that when I first open nvim as opposed to a blank line at the top. It disappears as soon as a file is actually opened.

Update: in the interest of keeping the plugin as simple as possible, I've removed tabpage handling (it's not really compatible with the idea of a buffer tabline, anyways) and reinstated most of the changes from #23. Sorry again for any trouble – this is likely to be the last significant update to the plugin.


chore(deps): upgrade dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-main" workflow

Codecov Report

Merging #730 (aaa4e8a) into main (e924f17) will not change coverage.
The diff coverage is n/a.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@           Coverage Diff           @@
##             main     #730   +/-   ##
=======================================
  Coverage   95.69%   95.69%
=======================================
  Files           1        1
  Lines         395      395
  Branches       53       53
=======================================
  Hits          378      378
  Misses         17       17


feat(HACBS-2405): add a setup script for tekton task testing

The new tekton dir will be used for storing init scripts for tekton task testing in the release-service-bundles repo.
This change is needed by
https://github.com/redhat-appstudio/release-service-bundles/pull/159

Closing this. We decided to go with Solution 2: https://github.com/redhat-appstudio/release-service-bundles/pull/162


Incompatible with datasette-write-ui and datasette-comments

Because of this code: https://github.com/datasette/datasette-checkbox/blob/c028ac7197c77393166e4bec9fb6e74cb808ede9/datasette_checkbox/init.py#L42-L43
Those plugins add extra stuff to that <td> which interferes there.

Ideally Datasette would make the primary key available in a data- attribute, maybe on the <tr> for the row.
Temporary fix is to strip anything in a <span> before trying to read the primary key.

let copy = td.cloneNode(true)
Array.from(copy.querySelectorAll('span')).forEach(span => span.parentNode.removeChild(span));
let pk = copy.textContent;


Plugin crashes when blacklisting a device.

I want to blacklist a device because I want to update a THB device by nodered.
I blacklisted the device by "0x00158d00022cbcad_.*"
Immediately after the restart of Domoticz it crashed directly after the zigbee plugin thread is crashed.
When I remove the blacklisted device Domoticz run as normal.
I also test on a test system with only the zigbee devices. No crash so far, but have to wait. Devices are update when the are created, despite the fact that the device is blacklisted. If I do the blacklisting at the start of the hardware creation then the blacklisted devices are not created.
B.t.w. Domoticz crashes every other day also by a crash of the zigbee plugin thread. I think that has to do with some of the remaining errors in the plugin.
Additional information
Zigbee2MQTT version: 1.18.3-dev commit: 5195f5f2
Python version: 3.7.3
Domoticz version: 2021.1 (build 13243)
Plugin version: latest.

The idea of blacklist is just to avoid plugin to create specific device, if device is already created most likely it'll keep updating


Error parsing JSON from getData()

The code I'm running looks like
  const schema = `
    name: string @index(fulltext) .
    email: string @index(exact) .
  `;
  const op = new dgraph.Operation();
  op.setSchema(schema);
  const result = await dgraphClient.alter(op);
  return result.getData();

However, the getData() call is reporting a JSON parse error:
SyntaxError: Unexpected end of JSON input
    at JSON.parse (<anonymous>)
    at Payload.getData (/home/aryzing/workspace/anccre-server/node_modules/dgraph-js/lib/types.js:30:21)

Just ran result.getData_asB64() and it produced an empty string, so perhaps the issue is that getData() is not checking whether it's receiving an empty string.


Adding Myself as contributor by using all contributor bot

@allcontributors add @viveksharmaui for test , code , doc , infrastructure and bug

@allcontributors add @viveksharmaui for infrastructure , code , test

@allcontributors add @viveksharmaui for doc , bug


ng-packagr

Description
Would it be possible to make it work with ng-packgr? (in watch mode?)
Kind regards
Describe the solution you'd like
No response
Describe alternatives you've considered
No response

Good question! Unfortunately this approach wouldn't work for libraries, to build an angular library requires the angular compiler, which is built on top of typescript. But this implementation is fast due to it not using typescript, so by association we also cannot use the angular compiler. Given the tools we have available today,ng-packagr is probably about as fast as it could be.
But you may have some luck, by changing the compilationMode in your libraries tsconfig to experimental-local, which may allow faster builds. I haven't tried this myself though so it may not work, and is still considered experimental.


Add linear_gradient config spec

Overview
Adds the configuration spec of the new linear_gradient effect. See the mpf-mc pr for more details.
Related PRs

mpf-mc #435
mpf-docs #432

awesome, thanks for this and for adding docs! :)


Best way to combine nested files

Hey, was wondering what's the best/recommended way to combine a directory with nested folders and files into a single ts file. Currently I do something like the following with protobufjs for bundling:
pbjs -t static-module -w commonjs -o source/proto/nested.js proto/nested/**/*.proto && pbts -o source/proto/nested.d.ts source/proto/nested.js

Would there be an equivalent command for this with this lib? Something along the lines of protoc --ts_out source/proto --proto_path proto/nested/**/*.proto maybe.

Hey Brian, can you elaborate on the purpose of protobufjs bundling, and what exactly it does?
It is not clear to me what you mean with nested files. A reproducible example would be helpful.

I have a directory structure like the following:
tendermint
├── abci
│   └── types.proto
├── blocksync
│   └── types.proto
├── consensus
│   ├── types.proto
│   └── wal.proto
├── crypto
│   ├── keys.proto
│   └── proof.proto
├── libs
│   └── bits
│       └── types.proto
├── mempool
│   └── types.proto
├── p2p
│   ├── conn.proto
│   ├── pex.proto
│   └── types.proto
├── privval
│   ├── service.proto
│   └── types.proto
├── rpc
│   └── grpc
│       └── types.proto
├── state
│   └── types.proto
├── statesync
│   └── types.proto
├── types
│   ├── block.proto
│   ├── canonical.proto
│   ├── events.proto
│   ├── evidence.proto
│   ├── params.proto
│   ├── types.proto
│   └── validator.proto
└── version
    └── types.proto

Running pbjs -t static-module -w commonjs -o source/proto/nested.js proto/nested/**/*.proto && pbts -o source/proto/nested.d.ts source/proto/nested.js will result in the files source/proto/nested.d.ts and source/proto/nested.js being created. The source/proto/nested.js file contains all of the proto files combined instead of having a separate js file for each proto file and source/proto/nested.d.ts contains all of the TypeScript types.

Thanks Brian, purpose and details are still a bit unclear to me, unfortunately.
protobuf-ts will generate a tree similar to the input tree, not just two files. Since two messages could have the same name, you can't just export * in a single file. Types would have to be exposed with an interface of some kind. But that negates the advantages of ECMAScript modules, meaning that a website bundle would have to include all types, not just the used ones.
Not sure what protobuf.js does in this case, and whether it cares about bundle size. I'm also not sure why it offers bundling in the first place, and what problem it solves. I would expect users to simply run one of the many bundlers available on their entire frontend web application.
If this is about distributing types, the BSR offers the best convenience at the moment. It is also an option to craft an NPM package from the generated code. I think that can be (mostly) automated, and protobuf-ts gives you the building blocks, but it's not an out-of-the-box solution.


M3U files containing apostrophes cause formatting errors

Please first read the documentation. Problems affecting the client, e.g. Plex or Emby should be reported there in the forum.
Describe the bug
channels in m3u with apostrophes before the final comma causes formatting error.
i believe what is happening is everything after the apostrophe is removed as it is no longer a properly formatted string encapsulated by quatations.
Here is an example from a Pluto M3U (everything after tvg-name="Let is removed, in fact this entire name is removed since its not formatted properly)
#EXTINF:-1 channel-id="20188" tvg-id="20188" tvg-chno="20188" tvg-logo="https://images.pluto.tv/channels/6267352efcf21c0007c76642/colorLogoPNG.png" tvc-guide-stationid="6267352efcf21c0007c76642" tvg-name="Let's Make A Deal" group-title="HD",Let's Make A Deal
Server (please complete the following information):

OS Windows 11
Arch Intel 64 bit
Threadfin Version and Build 1.0 (22)

To Reproduce
Steps to reproduce the behavior:

have an m3u containing apostrophes before the final comma
import it
see channels with no names

Expected behavior
for m3u files that contain apostrophes in plain text and not coded should still be passed through in my opinion. i do not believe m3u has a spec and removing the text must be a parsing bug in threadfin when processing the line as a string.

Having this issue too, an ' in my ppv channel name causes the channel name to go bank in Threadfin's filter/mapping.

I have also observed the same problem with apostrophes/single quotes in the m3u file causing the channel name and the stream URL to be blank. As it is not reading in the details it means the urls.json file in the configuration folder is missing these details (as shown below):
"89fe4846ad9396adc4a743c1c4057eab": {
"channelNumber": "1795",
"name": "",
"playlistID": "M9DUIMP063EH2V66BY6F",
"url": "",
"backup_channel_1_url": "",
"backup_channel_2_url": "",
"backup_channel_3_url": "",
"urlID": "89fe4846ad9396adc4a743c1c4057eab"
The problem can be tracked back to /src/internal/m3u-parser/xteve_m3uParser.go
Line 139 has the following:
	`content = strings.Replace(content, "'", "\"", -1)`

What this is doing is replacing the apostrophe/single quote with a double-quote, which is causing the read of the #EXTINF line in the m3u to be terminated and not get parsed. Also it means the following line containing the stream URL is Laos not being parsed.
To test that this is the cause, I removed the entire line from the source file and recompiled. Now channels with apostrophes/single quotes are parsed properly and the stream URL is also parsed.


Make scrollbar only react to touches on knob

Currently touching anywhere on the scrollbar gutter will move the scrollbar under your finger, making pressing back on phones with gesture navigation mess up the scroll position.
I feel like the scrollbar should only react to touch events when the knob is visible and when the initiating gesture starts on the knob itself

67a83c1c2dee26b2f97b53561c976b6ea1ed7c9e

Hm I don't think this is working unless I misunderstood what it's supposed to do. Setting selection mode to thumb still scrolls my column when I touch on the gutter outside the thumb

Yes, I missed that case, sorry. I did it too fast without looking at all the edge cases.

677be1cb3dc4202d5109d60d20b77b7e7a37bb0d this should fix it.
Feel free to close this issue when you are satisfied with the results.

This fixes it! thanks for the quick updates, it's greatly appreciated


New mobile ranges for MQ

Country: Martinique (MQ)
Example number(s) and/or range(s): +596697
Number type ("fixed-line", "mobile", "short code", etc.): mobile
For short codes, cost and dialing restrictions: n/a
Where or whom did you get the number(s) from: synthesized from correct format
Authoritative evidence (e.g. national numbering plan, operator announcement): National Numbering Plan https://www.arcep.fr/uploads/tx_gsavis/05-1085.pdf  (see table on page 23)
Link from demo (http://libphonenumber.appspot.com) showing error: http://libphonenumber.appspot.com/phonenumberparser?number=%2B596697000000

@jice,
Thank you for taking the time to improve libphonenumber!
We are already supporting 69727 based on XL sheet given in ITU doc https://www.itu.int/dms_pub/itu-t/oth/02/02/T02020000860002PDFE.pdf. The XL sheet is also from arcep.fr which is the official numbering authority.
The evidence provided by you is very generic. If you want us to support remaining sub ranges, we request you to provide online working numbers or official evidence. Please see our guidelines.

@kkeshava
Sorry, I didn't realize this library was keeping track of every allocation made to operators.
If you are already tracking the spreadsheet you referred to for changes, then it's all good. You are correct about the fact that 69727 is the only allocated sub-range allocated in the 697 range at this time.

@jice,
I'll close this as it's not an issue with the library. Please consider joining the discussion group if you'd like to discuss this further.


fix: GPU bootstrap (and component refresh)

Fixes #
Description
How was this change tested?

Does this change impact docs?

[ ] Yes, PR includes docs updates
[ ] Yes, issue opened: #
[ ] No

Release Note

Pull Request Test Coverage Report for Build<PHONE_NUMBER>0
Details

11 of 11 (100.0%)  changed or added relevant lines in 3 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.004%) to 94.23%

Files with Coverage Reduction
New Missed Lines
%

pkg/cache/unavailableofferings.go
2
95.45%

Totals

Change from base Build<PHONE_NUMBER>7:
-0.004%

Covered Lines:
37154

Relevant Lines:
39429

💛  - Coveralls

GPUNeedsFabricManager and related changes can be split into a separate PR since karpenter doesn't have MIG support today right? https://learn.microsoft.com/en-us/azure/aks/gpu-multi-instance?tabs=azure-cli

Yeah seems weird to add this support now.


3D graphormer model on PCQM4M-v2

Hi.
It seems like 3D graphormer code now is only for the oc20 dataset. Am I right?
If I am right, do you have a plan to upload 3D graphormer model code for PCQM4M-v2 dataset?
Thank you.

Hi! As for 3D pretrained models, we only released a model pretrained on the oc20 dataset. But the Graphormer 3D model we provided (in graphormer/models/graphormer_3d.py) can be trained on any 3D molecular datasets, including PCQM4M-v2 dataset. You can train it using a training script similar to examples/oc20/oc20.sh.

I see, then where can I find a preprocess code to convert PCQM4M-v2 dataset into a format which fits graphormer_3d.py?
def forward(self, atoms: Tensor, tags: Tensor, pos: Tensor, real_mask: Tensor):
padding_mask = atoms.eq(0)
Code above seems like dataset needs features like atoms / tags / pos. Right?
I only could find preprocess code that deals with oc20 dataset in Graphormer/graphormer/tasks/is2re.py.

Yes, if you want to train a Graphormer 3d model, you'll need position information for sure. Atoms or tags information is optional, but it's suggested to include atom type information if you expect a good result.


Material Selection Menu Position

The Material text selection menu position was updated in https://github.com/flutter/flutter/pull/36974 to include a small amount of padding above the selected text in order to match native.  This PR updates the one golden that features the Material text selection menu above the text.

Before
After

@Piinks Fixed!  Thanks.


Playback using link with t=0 does not work

Describe the bug
Video URLs can include a time parameter from which the video will start, e.g. https://live.rbg.tum.de/w/foo/123456?t=42
Setting t=0 does not work but instead resumes the video from the previous playback position.
Not sure if this is intended though.
To Reproduce

Open a video
Use a time code link for accessing this video.

t>0 works
t=0 continues the video from the last playback position instead of playing the video from the beginning.

Expected behavior
Start the video at t=0
Desktop (please complete the following information):

OS: Linux
Browser: Firefox
Version: 118.0.2

I am trying to solve the problem. Alternatively, argument "t=-1" should set the starting time at 00:00, does it?


Is the project still maintained

Hi,
is this project still maintained and stable?
It would be nice to clarify that in the readme.
Thanks!

I'd like to know this too. There are open pull requests that have been sitting around without activity since Feb 4, 2015.

Thanks for the interest. I maintain this project when I get the time free from other commitments. I hope to have more time for maintaining it in the future but as with all side projects I can't commit to this.
On a general point I think that there is a slight conflict with this plugin between adding more and more support for features and keeping it simple and doing the most common tasks well. Though this could be spelt out better!
So some plans to improve things:

Pull requests are always welcome - sometimes they don't come up to the standard to merge and require significant effort to fix up. Sometimes the submitters help with this but often they are "drive by pull requests" where the person has fixed their particular problem and stops responding.
I'm more than happy to share the workload with others. Ideally a group of committers/reviewers. If some has a few pull requests that are sensible I'd be more than happy to add them as a committer to the project.
I think a triage of issues/PRs would help too and a roadmap would help too.  @bflopez @kalouantonis @numbnut are you guys willing to help with this?

So in short, any help gratefully received!

Thanks for the reply! I'm sorry, but I can't contribute or help to maintain this project.
Good luck anyway!

Thanks for clarifying. I can't commit to maintaining this project, but I will contribute pull requests for issues that crop up or features that align with my company's needs as we're using it on production.

I would love to help! It will take me a little while getting to know the library a little better. We can talk more about a roadmap/plan. We might find out that there are other ways to make the library great for everyone.

@bflopez++

It would be better if the roadmap/plan is drafted and updated in readme. It would be Ideal to get the chartconfig object same as highcharts so as to avoid all confusion and problems that are specific to highchars ng


Added google captcha

Added google captcha in the login page. Attaching ss for demo.
Fixes #232
###Screenshot:

@2001asjad Please resolve the conflicts.

@2001asjad Any updates?

@2001asjad Any updates?

Yeah I made a PR with the changes but it seemed a lot of codebase has changed since I last forked. So I think I'm gonna make a new fork and work on this issue again.