PDF Viewer cannot open URI link with space in URI (" ")

OpenUI5 version: 1.52
Browser/version (+device/version): all browser
URL (minimal example if possible): sapui5 sample
Steps to reproduce the problem:

Use PDF Viewer to open a URL containing space --> didn't work as expected
I have encoded the URL to using encodeURI() to avoid the above issue.
But still didn't work.

What is the expected result?
The PDF Viewer should render the PDF.
What happens instead?
Error: the URI gets encoded 2 times: one by me, one by the library; which make the URI incorrect & cannot get the PDF file.

Any other information? (attach a screenshot if possible)

As you can see in the screenshot above. it's the library code.
After the URL validation, if the URL is valid, there's still another encodeURI, which create the error in this issue.
What I don't understand is that: if we already check for the URL validity, why need we encode the URL again?
For now, in my code, I'm intended to remove the encodeURI after we had the validation. (I'm using custom control based on the PDF Viewer). Is there a better solution for this?
Another option is that make sure the URL has no space, but it's not a really good option because the naming is done by our end user, who has no idea about this technical challenges.
Looking for your discussion.
Thank you,
Victor!

Hello @strawherotk ,
Thank you for sharing this finding. I've created an internal incident<PHONE_NUMBER>. The status of the issue will be updated here in GitHub.
Regards,
Gery

Dear @strawherotk ,
I am sap suite controls team responsible for sap.m.PDFViewer control.
I had went through your issue description.
Actually you can avoid the encodeURI check in control by white-listing your URL.
Only if the Source URI is not white listed control do's the econdeURI.
For white-listing your URL.
Please see document.
URL_WhiteList.docx .
Regards,
Dhanwin.
SAP Suite Controls.

Hello @dhanwin89,
I've gone through the Whitelist.docx and made some experiment with my project.
As my current understanding. the Whitelist will make the jQuery.sap.validate() return 'true' to some specified URL pattern.
However, how can I define the pattern to ignore space inside the URL?
My PDF file URL is dynamic so I cannot define the exact URL into the Whitelist.
example URL:
https://myDomain.com/documents/show space PDF.pdf
Is there any way to ignore the space inside the URL using the while list?
After checking with the API:

When a whitelist has been configured using addUrlWhitelist, any URL that passes the syntactic checks above additionally will be tested against the content of the whitelist.

I guess there's no solution for my above question. As the Whitelist is used for adding more validation, not remove the validation (what I want).
Hence, I think I have to use my current customization. :(
Thanks.

btw, here's my customization in the library:
sParametrizedSource += "#view=FitH";
if (!jQuery.sap.validateUrl(sParametrizedSource)) {
sParametrizedSource = encodeURI(sParametrizedSource);
}

I remove the encodeURL() since I've already encoded it in my formatting function:
urlFormatter: function(sURL) { return encodeURI(sURL); }

Hi again,
I've just checked the PDFViewer with sapui5 version 1.54.4.
The issue seem to be fixed:
sParametrizedSource += "#view=FitH";
				if (!jQuery.sap.validateUrl(sParametrizedSource)) {
					sParametrizedSource = encodeURI(sParametrizedSource);
				}

				if (jQuery.sap.validateUrl(sParametrizedSource)) {
					oIframeElement.attr("src", sParametrizedSource);
				} else {
					this._fireErrorEvent();
				}

2 new line of code has been added: if the url is not validate, encode the url, before checking whether to fire the error or not.
Hence, I think you can close this issue, and noted this it has been fixed in version 1.54.4 (or earlier version) i'm not sure.
Thanks.

Hi @strawherotk ,
Yes from version 1.52 onwards the above 2 new line were added to avoid encodeURL check if the domain is white listed.
So this fix is available from version 1.52 onwards :-).
Since your query is resolved I will close the issue.
Thanks & Regards,
Dhanwin.
Suite Controls.


Swarm Docs - How to use a FQDN

I managed to follow and get working the rc2 docs for running in a docker swarm cluster, after figuring out that while we are in release I need to pull/use traefik:v1.1.0-rc1  instead of just traefik because traefik:v1.1.0-rc2 doesn't seem to exist yet.
However, I can't figure out how to get this working with a FQDN such as my-site.programster.org. The docs simply show testing with curl -H Host:whoami0.traefik http://$(docker-machine ip worker1). I make sure to update my /etc/hosts file to point my-site.programster.org to any of the swarm nodes, but I just get a 404 page not found message.
Is this a simple configuration change, such as changing:
docker service create \
    --name whoami0 \
    --label traefik.port=80 \
    --network traefik-net \
    emilevauge/whoami

...which could be clarified in an update to the docs or is it just not possible? I tried changing --name and --label values with no success.

Try this:
docker service create \
    --name whoami0 \
    --label traefik.port=80 \
    --network traefik-net \
    --label traefik.frontend.rule=Host:my-site.programster.org \
    emilevauge/whoami

Brilliant! I just tested it and that's exactly what I needed!

If your issue is solved, can you close it? Thanks @programster :)

I'm closing this thread, but I do suggest the documentation is updated to include this example because I won't be the only one. Thanks for the help.


Fix compilation issue with non-SIMD platforms (#114)

Solves compilation-issue for non-SSE processor (#114 )

Thank you!


Jest Coverage All Files

When Jest performs code coverage, it seems to only cover the files that were tested instead of all files in my source directory. This gives a skewed percentage of files tested.
For example, if I have 10 source files and I only test one of them, the coverage report will not include all the files. It would be nice if there's a way to specify which files should be covered. collectCoverageOnlyFrom does not seem to serve this purpose.

I'm also looking for this functionality. Our code coverage reports would be much more useful if they reported on all the files we're targeting for coverage.

we're working on it right now, so probably in a few weeks that should be implemented

@calclavia my hacky way around this was to generate a jest test before running code coverage that requires every file that I'm interested in instrumenting.
Not ideal but works for my CI for now.
var fs = require('fs');
var glob = require('glob');
var path = require('path');

var ROOT_PATH = path.resolve(__dirname, '..', 'app');

// NOTE: These are matched against absolute paths of files
var EXCLUDE_LIST = [
    '__mocks__', // Don't instrument testing files
    'jest.js', // Don't instrument testing files
];
var files = glob.sync(`${ROOT_PATH}/**/*.js`);

var out = 'jest.disableAutomock();\n';
for (var i = 0; i < files.length; i++) {
    var filePath = files[i];
    var modulePath = `./${path.relative(ROOT_PATH, filePath)}`.slice(0, -3);
    var regex = new RegExp(`(${EXCLUDE_LIST.join('|')})`);
    if (!regex.test(filePath)) {
        out += `
            try {
                require('${modulePath}');\n
            } catch(e) {
                console.log('"${modulePath},"');
                console.log(e);
            }
        `
    }
}

out += `

it('Requires all the files in order to instrument them for code coverage', () => {
    expect(1).toEqual(1);
});

`;

fs.writeFileSync(`${ROOT_PATH}/requireAll.jest.js`, out);

See #1354. This will be in the next major release of Jest. Woohooo!

yay!

This is now part of the latest Jest pre-release and will be in Jest 15. @dmitriiabramov rewrote Jest's code coverage support. Please try with jest@test or<EMAIL_ADDRESS>to see if this issue still persists. If it does, we'll reopen this issue.
The new option is collectCoverageFrom and it takes glob patterns. @dmitriiabramov can you make sure this is part of the API documentation before 15 comes out?

The collectCoverageFrom seems to be still missing from the API documentation. Also I can't get this working.
For e.g. given the following source files:
src
├── helpers
│   ├── array-from-mask.ts
│   └── index.ts
├── logger.ts
├── reporter.ts
└── server.ts

and tests:
test
├── helpers
│   └── array-from-mask.spec.ts
├── logger.spec.ts
└── reporter.spec.ts

If i set the collectCoverageFrom to "collectCoverage": ["src/**/*.{ts,js}"], the server.ts file is still missing from the coverage report.
<EMAIL_ADDRESS>

@jsynowiec do you have an example project that i can look at?
we have an integration test for .ts coverage that seems to be working https://github.com/facebook/jest/blob/master/integration_tests/typescript-coverage/package.json
and what does your full config look like?

@dmitriiabramov yes, you can check my jsynowiec/node-typescript-boilerplate. In my current project Jest configuration is the same.
You can clone that repository and add a new file (cp src/main.ts src/another.ts), then add "collectCoverageFrom": ["src/**/*.{ts,js}"], to jest config in package.json. After this run npm run t:c.
I'm getting following output
 PASS  test/main.spec.ts
  main module
    ✓ should export greeter function (3ms)
    greeter function
      ✓ should greet a user (1ms)

----------|----------|----------|----------|----------|----------------|
File      |  % Stmts | % Branch |  % Funcs |  % Lines |Uncovered Lines |
----------|----------|----------|----------|----------|----------------|
All files |      100 |      100 |      100 |      100 |                |
 main.ts  |      100 |      100 |      100 |      100 |                |
----------|----------|----------|----------|----------|----------------|
Test Summary
 › Ran all tests.
 › 2 tests passed (2 total in 1 test suite, run time 2.854s)

but I expected to also see
 another.ts  |          0 |          0 |          0 |          0 |                |

@jsynowiec i could reproduce the issue and was able to fix it by removing
    "testPathDirs": ["<rootDir>/test"],

from the config.
@cpojer if we have testPathDirs in package.json, hast-map doesn't seem to have any files outised of the test directory, is that intentional?

testPathDirs is unfortunately the worst name someone gave to this field ever. It simply means roots, ie. that Jest will only look into folders specified in testPathDirs. The default is rootDir.

@cpojer @dmitriiabramov thanks for clarifying this. API documentation is currently a bit misleading.

A list of paths to directories that Jest should use to search for tests in.

hi @jsynowiec Were you able to find a fix ? My jest configuration is  -
"jest": {
    "moduleNameMapper": {
      "^.*[.](jpg|JPG|gif|GIF|png|PNG|svg|SVG|scss|SCSS|sass|SASS|less|LESS|css|CSS)$": "tests/empty_module"
     },
    "modulePaths" : ["./"],
	"bail": true,
    "coverageDirectory": "coverage",
	"collectCoverageFrom" : ["app\/.*\\.js"],
    "collectCoverage": "true",
    "coverageThreshold": {
      "global": {
        "branches": 50,
        "functions": 50,
        "lines": 50,
        "statements": 50
      }
    },
	"testRegex": "tests/.*(test)\\.js$"
  },

app has a folder main and lots of folder inside. And tests folder follow the same structure.
I have written test case for just one file and I get this report.
`PASS  tests/main/components/PrimaryNav.test.js
✓ Renders PrimaryNav with user prop (9ms)
----------|----------|----------|----------|----------|----------------|

File
% Stmts
% Branch
% Funcs
% Lines
Uncovered Lines

All files
Unknown
Unknown
Unknown
Unknown

----------
----------
----------
----------
----------
----------------

Test Summary

› Ran all tests.

› 1 test passed (1 total in 1 test suite, run time 1.49s)`

hey @umgupta
collectCoverageFrom accepts a list of globs, and not regular expersions
so in your config instead of
"collectCoverageFrom" : ["app\/.*\\.js"],

you should have
"collectCoverageFrom" : ["app/**/*.js"],

you can find globs documentation here https://github.com/sindresorhus/multimatch

Thanks, that worked :)

oh, I'm so lucky to find that solution today! "collectCoverageFrom" : ["app/**/*.js"], worked for me! I thought it's a design limitation of jest and was very upset, but now I can proceed and setup KPIs for test coverage.

When I use the Press p to filter by a filename regex pattern. feature in watch mode, is it default behavior to run coverage for all untested files? When I'm filtering in watch mode, I only want to see the coverage for the one test file I'm running, not my whole codebase.
How do I change this?

I think that should work due to #5601?

In case anyone still having issues. I am working in Vue and was also getting empty code coverage reports.
I changed the pattern to find the files and it works now. Here is my setup.
  collectCoverageFrom: [
    'src/**/*.{js,vue}',
    '!**/node_modules/**',
    '!**/vendor/**',
  ],


Web access

Can't get past the username/password stage. Is Tigo/$olar always the right user/pass or can be smth else? Does installer of the inverter maybe set this?

Yes. Tried to, but seems passwords in my case dont work. Oh well.

If you're getting the 'Done' screen after calling cgi-bin/shell, then you should be able to SSH in using the local IP.
I would double-check the basics like IP address, firewall, network connectivity.
Also doublecheck that you're using this CCA: https://www.tigoenergy.com/product/cloud-connect-advanced

See the post here - https://diysolarforum.com/threads/getting-data-directly-from-a-tigo-tap-is-it-possible.37414/post-1133295
You may have older fw where the user:tigo1 credentials are used and old ssh cipher may need to be enabled.

With the last firmware (3.7.7) it seems Tigo changed something. Probably there is already a solution, but they guys don't want to publish it yet: https://www.photovoltaikforum.com/thread/149592-details-protokolle-zugang-auf-tigo-cca/?postID=3829812#post3829812

I just got my system up and running, hopefully the root method is shared soon!


HF_TOKEN is not propagated to the podman command

And hence mixtral download fails
Downloading model failed with the following Hugging Face Hub error: 401 Client Error. (Request ID: Root=1-6637576e-28a8c5cb049f1dbb35d46d83;86121860-3ce0-419b-aed0-4fc79c440da7)
Cannot access gated repo for url https://huggingface.co/api/models/mistralai/Mixtral-8x7B-Instruct-v0.1/tree/main?recursive=True&expand=False. Access to model mistralai/Mixtral-8x7B-Instruct-v0.1 is restricted. You must be authenticated to access it.

LGTM but need to repush with  a commit —amend -s to pass DCO


Implement 3D analytic model of thermal saturation and compare with FEniCS simulations

Compare also with Innocenzi’s 2D model

Some duplication with #73. @dtabell has done these comparisons. @dtabell -- please post a link to the relevant notebook(s)

The analytic 3D model is written up in the IPAC proceedings paper.
Agreement, if easily achieved, could be noted in the upcoming AAC proceedings paper.
This is lower priority for that paper.

@dtabell --
If the notebook exists, please move it to rslaser-examples/
If not, then please create a new issue in rslaser-examples/ to create the notebook.
After doing the above, please close this issue here.


Version 2.2

We going to have a 2.2 release?

Just added the 2.2.0 release. I have to upgrade to PHP 7.0.24 first to install the new 2.2.0 release.

The master branch is now 2.2.0. A new branch 2.2 is also created.


Dashboard should request log streams only when the user gestures to display them

Change the AppHost to only subscribe to DCP's logs when there is a subscriber for the logs.
Fix #2789
Microsoft Reviewers: Open in CodeFlow

What happens to historical logs? For example, will requesting the console logs for an app show all longs since the app started? (if less than the limit)

What happens to historical logs? For example, will requesting the console logs for an app show all longs since the app started? (if less than the limit)

The "backlog" gets cleared after the last subscriber to a resource leaves. Later, when a "new" subscriber comes along, they are all replayed from DCP because we call StartLogStream(executable); again.
So even if no one was subscribed for a while, the whole logs come back once someone does.

One small race is that starting logs before the container is ready, it won’t show up. Super tight race and I don’t know if it’ll be worth complicating the code but I thought I’d let you know

One small race is that starting logs before the container is ready, it won’t show up.

Can you describe this a bit more? When what is starting the logs before the container is ready?

One small race is that starting logs before the container is ready, it won’t show up. Super tight race and I don’t know if it’ll be worth complicating the code but I thought I’d let you know

This didn't turn out to be too bad. I added another loop that joined the "has subscribers" and "logs available" information, and only starts the logs once both are true.


[Flaky Test] Fixes flaky TensorRT Test

Description
Experienced TensorRT test suite failure:
======================================================================
FAIL: Run LeNet-5 inference comparison between MXNet and TensorRT.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/nose/case.py", line 198, in runTest
    self.test(*self.arg)
  File "/work/mxnet/tests/python/tensorrt/test_tensorrt_lenet5.py", line 100, in test_tensorrt_inference
    MXNet = %f, TensorRT = %f""" % (mx_pct, trt_pct)
AssertionError: Diff. between MXNet & TensorRT accuracy too high:
           MXNet = 99.050000, TensorRT = 99.060000

See logs for full details.
I've decreased the sensitivity of the test slightly and modified the error message a little for clarity.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.

[x] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
[x] Changes are complete (i.e. I finished coding on this PR)
[x] All changes have test coverage:
Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
[x] Code is well-documented:
For user-facing API changes, API doc string has been updated.
For new C++ functions in header files, their functionalities and arguments are documented.
For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
[x] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@mxnet-label-bot add [Python, Test, pr-awaiting-review]

I've executed the test 10k times and didn't see it happen.

Merged. Thank you for the fix!


Add ability to export 3D field plots to 3D pdfs

Description of the feature
For Icepak FieldPlots, include the ability to export to a 3D PDF, rather than just a 2D image.  This would allow for more concise and more usable reports.  Rather than generating multiple images from multiple angles, the end user would be able to spin the model in the PDF to see all sides, rather than using a variety of 2D views to attempt to show all features.
Steps for implementing the feature
Convert plot data to U3D or PRC formats for embedding in PDF.
Useful links and references
https://www.ecma-international.org/wp-content/uploads/ECMA-363_4th_edition_june_2007.pdf
https://web.archive.org/web/20081202034541/http://livedocs.adobe.com/acrobat_sdk/9/Acrobat9_HTMLHelp/API_References/PRCReference/PRC_Format_Specification/index.html

@lorenzovecchietti What is the status of this issue?

@Samuelopez-ansys it is not trivial, unfortunately. One possible way is to render the plot to pyvista, export it to vtk and then use a wrapper of this class https://vtk.org/doc/nightly/html/classvtkGL2PSExporter.html.

@lorenzovecchietti I think we can close this issue because PyAEDT is not intended to create advanced reporting, the pyvista and obj plots can be easily exported using PyAEDT, then users can implement their way to add these 3D formats into a PDF or powerpoint. If you agree, please close the issue.

@Samuelopez-ansys agreed.
@s-benter If you want to implement this yourself, you might want to check this discussion https://web.archive.org/web/20170207211224/http://vtk.1045678.n5.nabble.com/colored-surface-model-as-a-3D-PDF-td5077778.html


Apply fixes from StyleCI

This pull request applies code style fixes from an analysis carried out by StyleCI.

For more information, click here.

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@b120781). Click here to learn what that means.
The diff coverage is 100%.

@@           Coverage Diff           @@
##             master     #1   +/-   ##
=======================================
  Coverage          ?   100%
  Complexity        ?      8
=======================================
  Files             ?      1
  Lines             ?     22
  Branches          ?      0
=======================================
  Hits              ?     22
  Misses            ?      0
  Partials          ?      0

Impacted Files
Coverage Δ
Complexity Δ

src/HttpRobot.php
100% <100%> (ø)
8 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b120781...8b45db5. Read the comment docs.


[gui] Player Overview: Improve layout

[x] Margin around daily challenge/alignment of text
[x] Maybe explicitly write above daily challenge that it is a daily challenge (else users might be wondering what this means)
[x] Mysterious zeros (I suppose that are points, but it's not clear for an inexperienced user)
[ ] (might be addressed separately) The rules of a game are not clear, e.g., in MatrixSelect, how many features have to be selected (can be found out by trial and error, but showing it would be nicer). Plus, the termination criterion might also be interesting to see for players.

#129 opend new issue for user information matrix select


x-www-form-urlencoded data is encoded using URL encoding

This almost certainly isn't a real problem but as I was debugging my queries I noticed that space characters in form data are encoded as %20 rather than +
http://stackoverflow.com/questions/1211229/in-a-url-should-spaces-be-encoded-using-20-or
Before I discovered popsicle I was using my own hacked up promised web session code and I ended up using the form-urlencoded package for my encoding.  But my decision was based on using the first package I found rather than any careful analysis.

Wow, it sounds like you are working with some legacy systems! Do you mind if I ask what isn't accepting this? Encoding it yourself instead of the internal is very straightforward, thankfully, but I'll do an analysis of what it would take to do + instead.

Some initial research: It seems other libraries like request and superagent don't do this - https://github.com/request/request/blob/9f702bf4b5d075035c28eea55dda44d3a0235926/lib/querystring.js and https://github.com/ljharb/qs/blob/8aa9c26f90335b5483a4f456dea9acbada8a881c/lib/utils.js#L86 are the methods that get invoked, neither are handling the space correctly. I'll look at formatting according to https://url.spec.whatwg.org/#urlencoded-serializing when I get the chance, if there's minimal overhead to doing so.

Sorry I should have made it more clear.  This hasn't actually caused me an issue.  It was just that when debugging I noticed the difference between my node code and my browser.
I don't know enough about the http specs to know if this is likely to ever cause a real problem but I thought I would point it out and leave it to your judgement.

Sounds good. I don't think it'll hurt to try and follow the spec though, so I'll check it out.


Maui: improve pan and zoom behavior

In response to https://github.com/ScottPlot/ScottPlot/issues/4416#issuecomment-2458604698. This version should work. I hope a single pixel doesn't disrupt the other controls 😅. MAUI has its quirks, but this should make it more stable now.

Thanks for this fix @KosmosWerner! (and thanks @King-Taz for reporting this in #4416)
I'm excited to give this a try in the next release 🚀


[Bug] Video player: "Improper value supplied for aspect ratio. The format should be width:height, for example 16:9. - video.js" when omitting aspectRatio prop

Bug Report
Describe the bug
Upgraded from 5.18.0 to >=6.5.0, and the error appears from video.js when using the video player component.
Is this a regression?
Yes, worked previously.
Steps To Reproduce the error
<CldVideoPlayer
  config={{ cloud: { cloudName: '...' } }}
  id={id ? id?.concat(uuid) : uuid}
  key={src}
  src={src}
/>

However, if I pass an aspect ratio, e.g aspectRatio="16:9" the error goes away. But the prop has an optional type (and I see no good reason to enforce aspect ratio?), so something's clearly wrong.

Alright I think I found the issue: https://github.com/cloudinary-community/next-cloudinary/pull/461/files
I added the aspectRatio property to the options to help support a fix where the player would jump in sizing when it was loaded, but i hadnt considered the scenario that someone may not be applying a width and a height, which to be honest I didn't remember wasn't required props for the player
That's going to be a fix in Cloudinary Util now as I moved the logic to a helper function to be shared between the different framework libraries, so I'll address it over there and get the fix updated here
In the meantime, do you have a use case where you can't or dont want to use a width and height on the player? Mostly just curious to see how people are using it so i can consider it for future dev

hey @PhilipAngelinNE this should be going out in the next release, let me know if this resolves it for you!


Bumping golang version to v1.20.3 and making golint happy

What this PR does / why we need it:
Bumping go to 1.20.3 from 1.19.6 to fix the CVE's in go 1.19.6
Which issue(s) this PR fixes:

Fixes #
Does this PR introduce a user-facing change?

Additional Notes for your reviewer:
Review Checklist:

[ ] Follows the developer guidelines
[ ] Relevant tests are added or updated
[ ] Relevant docs in this repo added or updated
[ ] Relevant carvel.dev docs added or updated in a separate PR and there's
a link to that PR
[ ] Code is at least as readable and maintainable as it was before this
change

Additional documentation e.g., Proposal, usage docs, etc.:

/cherry-pick v0.44.x


Proposal regarding Plugins, their structure and the AssetLib

I was initially just going to file an issue over at godot-docs regarding the missing plugin submission guidelines, but the more I've worked on a plugin the more I realized there are wider issues than the missing documentation, like the current recommended structure for the plugins (addons/author.pluginname/).
If you have a demo project for your plugin, it's tempting as I did to just put this all in one repo, except as I was told, a plugin can't be a project, which okay, makes sense. So I separated the plugin demo project/test scenes into another repo (because custom actions set in the project.godot file were needed for the demos to work). The problem now becomes working on the addon from within the plugin's demo repo. I cannot for example, add the plugin as a git submodule because of the root addon folder. The only work around I've found is to symlink the plugin's folder. But then this means that I have to somehow keep track of which commit corresponds to which plugin version (since the godot project doesn't keep track of this).
My proposal is a plugin should just be a repo's root (e.g. Blender plugins are like this). The author's name should not factor in1 (though the plugin.cfg could contain info regarding the author, repo, demo repo, etc which Godot could present to the user if necessary). Readme's, licenses, etc should always be there right along with the plugin. Demos should always be separated. There should only be a finite number of places a plugin can be installed (addons, assets, etc), and this could be set when submitting to the asset lib (it could be determined by it's category/type?), or maybe it could be in the plugin.cfg file.
This all excludes templates, of course, which can remain as they are.

The reason I think the author name should not factor in is just because it's cleaner since the default name for clones/submodules is just the repo's name.

This has several benefits:

Easier development. Plugin can be cloned directly inside a project or set up as a git submodule.
Things that are not project templates/demos more obviously cannot be projects.
Godot could eventually manage the placement of the plugins. If placement is set from within the plugin, this could be known regardless of where the addon came from (it could be dragged/dropped or imported from a zip like Blender).
Where different types of addons go would be standardized and it would be the developer's responsibility to set it correctly.
The user would usually not have to bother unticking any extra downloads, etc.

More benefits (edits):

Documentation and licenses would always be clearly attached to the plugins. This will be especially useful if/when the editor can open other files.
It would be easier to change/improve other people's plugins. Even if they were gotten from the AssetLib or a zip. I's still possible to init a repo, fetch changes, and keep your changes. From there you could do a pull request or even just keep pulling new updates over your changes.

Of course, this is just an idea. I don't know if there are situations where this might cause problems.
The only issue I can see is that demo repos with submodules would not contain their plugins unless git cloned recursively, but this could be fixed when some kind of plugin management is implemented. If the project kept track of it's plugins and their versions, it could auto-install plugins when the files are missing. This would also make it easy to reuse projects as templates, including it's plugins.

The only problem with this solution (which was discussed in some other issues, BTW), is that all paths in Godot's scenes and scripts are scoped to the project, and are not relative. That would mean that if the plugin is put in the wrong folder, bad things would happen.
On the other hand, we might enforce a "path" field in the plugin.cfg file, which would be checked for mismatches. Going further, we can make it a asset.godot file, so it can be used for non-addons as well.

which was discussed in some other issues, BTW

Has it, I didn't find anything, can you link? I found discussions on global plugins (which as I mentioned only gets rid of some problems. I'm not to fond of it as a solution), but nothing similar to what I'm proposing.

The only problem with this solution [...] is that all paths in Godot's scenes and scripts are scoped to the project, and are not relative. That would mean that if the plugin is put in the wrong folder, bad things would happen.

I'm not sure what you mean? Plugins would remain relative to the project. Paths would be set by the developer somewhere (I mentioned the plugin.cfg because I knew about that, but it could be an asset.godot if that's better, anything really). That file would tell Godot ALL the info regarding the plugin, including where to put it. If it's in the wrong place on startup (e.g. you clone it into the project root instead of the addons folder) it could either be moved (since it is just a folder, there's little danger in assuming a folder containing a plugin.cfg is in fact a plugin and contains everything needed for it to work) or it can just not register (if it's not registered can it do any harm?)
Would there be any problems with this?

@AlansCodeLog Well, I can't think of potential problems, so I'm going to discuss it with the other devs. Having the readme, etc. of the addon inside addons/xx/ is going to solve a lot of headaches.

I was thinking about the following, let me know what you guys think. Of course, this breaks compatibility but it may be worth it.
When a user creates a project in Godot project manager, user can choose between creating a project or a add-on
If creating an add-on, the following will happen:

In the project root, instead of "project.godot" a file named "addon.godot" is created instead.
When editing an add-on, all processes for saving scenes, resources, etc. will operate using relative paths. Godot could automatically detect that it's saving into an add-on folder and save paths as relative.
Alternatively, instead of saving paths as relative, we could add a new type of path: addon:// which is still absolute, but refers to an add-on. This needs to be discussed to see what solution is better (probably this one, as relative paths can be tricky from my experience).

Now, when you install Godot into a project, the following might happen:

You can choose where to put the addon, no need to be any longer restricted by the addons folder or using unique paths
No files will be stepped/overwriten
Addons NEED to be enabled somehow, so there should be a setting in project.godot pointing to the list of addons enabled.
ProjectSettings editor will lift data from the enabled add-ons folders and it will keep track of which settings come from where, so settings that come from an addon are not saved in project.godot
On export, all settings are combined and the addon configs are skipped.

This would allow you to add stuff like new input bindings, translations, etc. that come from add-ons. Of course one problem with this is that I'm not sure if all meaningful settings right now are saved in individual properties. It will work for input bindings, but It may not be the case with translations, or translation remaps, which is a problem, this will need to be looked at.
What do you think?

Continued here: #19178

Referenced similar topic earlier: #12153

Closing in favor of https://github.com/godotengine/godot-proposals/issues/554, as feature proposals are now tracked in the Godot proposals repository.


Fix tsc for frontend

Describe the bug
Unable to build with typescript compiler tsc.
To Reproduce
npm run vite tsc
Expected behavior
No errors

Fixed on main branch.


docs(searchParameters): Add more explicit example

do not merge yet
I had a question on support about the usage of searchParameters.
I updated the doc to make it more explicit.
But I cannot regenerate the doc website from the jsdoc, npm run docs:jsdoc fails (see #743)

Most of the time we try to link to https://community.algolia.com/algoliasearch-helper-js/docs/SearchParameters.html, what do you think?

Oh yes, makes sense. Will update.

I'm a little afraid of accepting this PR knowing that #743 is not fixed, but we have been having support questions about searchParameters that could have been avoided with the proper doc.
Does anyone know why #743 is failing?

@pixelastic Can you just comment the {...} from lib/InstantSearch.js, check that the doc is well generated and then we merge this until I fix the jsdoc thing (which is a bug un jsdoc)

Nice workaround. I've just pushed again with the new generated HTML, but I also have a new currentRefinedValues.md added to the log, but not present in the HTML doc. Is this widget officially released?

Is this widget officially released?

Since it's not in the html docs no but I believe the widget is done and can be used. We need to add it thought

Ok let's merge this and mode on

@Jerskouille is working on the "official" release of the currentRefinedValues I think.


Decrement number of measurements only once when deleting the last series from a measurement

Fixes #7152.

👍


specify table name with Table("presentcard") don't work with where()

gorm version:  github.com/jinzhu/gorm v1.9.15
go version: go1.14.6
here is my struct:
type PresentCardModel struct {
	ID           int32  `gorm:"primary_key"`
	SeriesNumber string `gorm:"column:series_number;type:varchar(12);unique_index:series_number"`
	Balance      int32  `gorm:"column:balance;type:smallint(5);not null"`
}

here is my code:
if err = db.Table("presentcard").Where(conditionModel).Find(&presentCardIns).Error; err != nil {
		return nil, err
	}

conditionModel is an instance of PresentCardModel that include the search condition such as PresentCardModel{ID:1};
So my problem is, when I use db.Table("presentcard").Where(conditionModel).Find(&presentCardIns), it return  an error message: "Error 1054: Unknown column 'present_card_models.series_number' in 'where clause'", So, the Table("presentcard") didn't work.
When I use :
gorm.DefaultTableNameHandler = func(db *gorm.DB, defaultTableName string) string {
                // default model name is present_card_models, so I pick first two word to get "presentcard", that's my table name.
		departs := strings.Split(defaultTableName, "_")
		return departs[0] + departs[1]
	}

It works.
OR when I only change the code to db.Table("presentcard").Where("id=?", "1").Find(&presentCardIns), It works, too.
So I wonder to know why db.Table("presentcard").Where(conditionModel).Find(&presentCardIns) won't work...

Can't make a playground pull request link because I don't know how to change the default table name in playground/main_test.go.
It always been users as default table name.


Segmentations Settings UI

Ongoing work on the segmentation UI. For this issue we should address global segmentation settings.. This ticket is addressing part of this comment:

It would be nice to have buttons that control segment visibility (overlay, contour, both, opacity), similar to what we have in Slicer (see you already have plans for this in the figma sketch).

The per-segment settings (color/alpha/visibility) part of the request is not in the scope of this issue, and will be implemented later.
This Figma template shows how the UI should look.

Add a gear icon to the top right of the segmentation panel.

Clicking a Gear icon changes the contents of the side panel to be a settings menu.

Render segment outline: Checkbox, default Checked

When checked, a horizontal slider appears for Outline Opacity with values 0 - 1.0 increments of 0.05
When checked a horizontal slider appears for Outline Width with values 1-5, increment 1 px.

Render segment fill: Checkbox, default Checked

When checked, a horizontal slider appears for Fill Opacity with values 0 - 1.0, increments of 0.05

Render inactive segmentations: Default off

When checked a horizontal slider appears for Opacity of inactive segmentations with values 0 - 1.0 increments of 0.05.

Clicking the back button should go back to the segmentation menu. When the segmentation menu is hidden and then reopened, the view should default to the segmentation menu, not the settings menu.
The UI should alter these settings which are consumed by the viewer components: https://github.com/cornerstonejs/cornerstoneTools/blob/master/src/store/modules/segmentationModule/defaultConfiguration.js

I see #1392 has been merged, and IDC sandbox is at the latest 3.8.0 release of OHIF Viewer, but it does not work for me.
Here are the issues:

maybe this is expected, but if I open TCIA QIN-HEADNECK collection, I do not see a single study that shows SEG in the Modality column; if I search for SEG in the Modality column, I get 0 studies
if I open a study that includes SR modality (since I expect those should have SEG as well for this specific collection), I do not see any SEG in the left column (which perhaps is expected, although confusing), but if I toggle the "Segmentations" "thingy" in the upper-right corner, the list is empty.

Here's example study: https://idc-sandbox-000.firebaseapp.com/projects/chc-tcia/locations/us-central1/datasets/qin-headneck/dicomStores/qin-headneck/study/<IP_ADDRESS>.4.1.145<IP_ADDRESS>.2744.7002.780384232736549650569052637489

I agree, it's still quite confusing.  It partly works (in some cases).  Only the segs for the selected series are shown.
If you select the CT (at the bottom of the series list) you can see the seg that is defined on it.

And same with the PET.

It's cool that they show up in the MPR!  (Changing the selected segmentation doesn't seem to update the view though.

Hopefully, once https://github.com/ImagingDataCommons/IDC-WebApp/issues/49 is resolved, we would be able to try to use the IDC portal for subsetting the content to be viewed, and it should be easier to test the latest features.

@pieper how can I identify studies that have segmentations? Or this is something that can't be done with the Study List interface at all?

@pieper how can I identify studies that have segmentations? Or this is something that can't be done with the Study List interface at all?

I don't think you can tell currently.

I was playing with the interface, and I realized there are some hick-ups with displaying segmentations. It is basically not clear whether segmentations are available for a given study. Segmentations list shows as empty, and looks like one needs to load imaging series that has segmentations first before segmentations list is populated. And even after that there seems to be a delay in that list being populated. See screencast here:
https://www.screencast.com/t/g6wzeltT
The URL for that screencast is here: https://idc-sandbox-000.firebaseapp.com/projects/idc-tcia/locations/us-central1/datasets/lidc-idri-seg-sr-dcm/dicomStores/lidc-idri-seg-sr-dcm/study/<IP_ADDRESS>.4.1.145<IP_ADDRESS>.6279.6001.131383203689189807643685075952&sa=D&ust=1586369794567000&usg=AFQjCNHVY4eaLmveYQCRHA98Hwr7lOXIVA
@pieper this is the LIDC issue we discussed elsewhere.

As discussed with @JamesAPetts today, this will continue in #1458. I will copy the comment above to that issue.


docs: add the Indonesia translation of README.md

PR Checklist
Please check if your PR fulfills the following requirements:

Put "x" to check

[x] The commit message follows our Contributing Guidelines
[ ] Tests for the changes have been added (optional, for bug fixes or features)
[x] Docs have been added / updated (optional, for bug fixes or features)

PR Type
What kind of change does this PR introduce?

Please check any kind of changes that applies to this PR using "x"

[ ] Bug fix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Docs

What is the current behavior?

Please describe the current behavior that you are modifying, or link to a relevant issue.

Issue Number: #95
What is the new behavior?
Add Indonesia translation of README.md file
Other information
Please kindly to reviewing my pull request
Thank you

Oke thank you udah di review.
Akan segera diupdate

Hi @fityannugroho , saya sudah menyesuaikan kembali readme-nya Tolong di review kembali, Thank you

Sepertinya masih ada yang terlewat dari review sebelumnya. Tolong dicek kembali ya. Klik "Resolve conversation" kalau memang sudah di-fix.


Make page title editable from the editor

Duplicates

[X] I have searched the existing issues

Latest version

[X] I have tested the latest version

Summary 💡
Currently, our page title is not editable from the editor. (Employees from the below screenshots)
A user can edit it from the page.yaml. This task is about editing it from the Toolpad UI.

Examples 🌈
No response
Motivation 🔦
No response

Hello, I'd like to work on this issue.

I believe we can add a textfield to update the title here:

When you create a page, initially the page title is based on page-Node name. Creating a text field could mean that they may not match.

I could make the title to match the Node name. Meaning that when you change the Node name, the title could will match as well. This is the default when you first create a page.
Create a text field so the user can customize the page title.

Just so we are clear, you want 2 over 1.

For me, Employees (in the screenshot above) as another concept only brings more confusion.  I agree with solution 1. shared by @Kirera-Wainaina.
Maybe later we can remove the title field from the .yaml, unless it needs to be there.

Cool,
I'll work on the text field.


 to clear watch mode pattern prompt

🚀 Feature Proposal
Currently, pressing Ctrl+u in a watch mode pattern prompt inserts an invisible character that also somewhat breaks searching because the files/tests searched for do not contain the character.
In most terminal environments, Ctrl+u clears the whole line. I think this should happen in the watch mode pattern prompt as well.
Motivation
Many users will expect Ctrl+u to behave as elsewhere in their terminal environment.
The workaround requires pressing backspace a lot to clear the line manually.
Pitch
Why does this feature belong in the Jest core platform?
Since jest-watchers Prompt is reused in third-party packages like jest-watch-typeahead, making the improvement here would benefit those as well as users of plain Jest watch mode prompts.

This is a Bash thing, but it probably works in most shell emulators (it does in zsh which I use at least).
If we add ctrl+b, we should also do others, like meta/ctrl+b and meta/ctrl+f. Feels like a somewhat slippery slope, but perhaps there's some library we can use which parses the input and returns a "command" of some sort that's easier to understand?

This is a Bash thing, but it probably works in most shell emulators (it does in zsh which I use at least).

Yeah, but it's also supported in many non-shell places in "the terminal", like in Vim insert mode, when editing a tmux command line, ..., hence why I phrased it more generally as "terminal environments".
Not sure how much of a slippery slope it is, I don't think there are many common commands that would be meaningful in the pattern prompt, and especially none that are as ubiquitous across different applications as .

We should definitely have moving backwards and forwards (plus deleting words) if we start adding support for "commands". That might be it, though?

Yeah, but it's also supported in many non-shell places in "the terminal"

Oh, and perhaps notably  is supported in the login prompt on Linux as well, before you even get a shell.

We should definitely have moving backwards and forwards (plus deleting words) if we start adding support for "commands". That might be it, though?

Yeah it seems moving forward and backward is about as ubiquitous. Would be nice if a library gives us everything for free - I've edited the description to say this should be checked - but I wouldn't mind introducing one without the other if it's easier since it's better than nothing.
Deleting words with  also seems useful and almost as common (not supported in login prompt, where I guess it wouldn't be very helpful anyway, but just about anywhere else).

Hi @jeysal @SimenB  could I work on this issue? I think I can implement the CTRL + U functionality.
Here is what I have in mind:

add CONTROL_U in the KEYS map in constants.ts
in the put method in the Prompt class whenever CONTROL_U is pressed set this._value = "", this._offset = -1, this._selection = null & call this._onChange()

@parthsharma2 sounds about right yeah :)

@jeysal I've committed the changes I mentioned in the previous message
https://github.com/parthsharma2/jest/commit/ad78494d046eacf5e2550a8e4d165d5dc1a398dc
I've added a test case along with it & it is passing. I also tried to run
it manually by yarn build & then yarn test --watch but it seems like I
can't get it to run the latest changes.
Is it possible for you to test it at your end or could you let me know how
I should test these changes?
On Sun, Apr 25, 2021 at 1:24 AM Tim Seckinger @.***>
wrote:

@parthsharma2 https://github.com/parthsharma2 sounds about right yeah :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/facebook/jest/issues/11296#issuecomment-826145168,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFJ2UQ6C4LPSY3EJ6A3OCYTTKMOZFANCNFSM425FSMZA
.

Hi @parthsharma2 and thanks a lot for doing this!
The changes from the commit look good to me, open a PR and we can let others review if they want and merge :)
The reason why you're not seeing the changes in manual testing is that we have jest-watch-typeahead plugins installed (see jest.config.js). These rely on the currently published version of jest-watcher and its Prompt. Once your changes are published, when jest-watcher is imported by jest-watch-typeahead the Prompt changes will also be available there. For now, you can see the changes in action by temporarily removing the relevant lines from out jest.config.js.

@jeysal @SimenB opened the PR #11358

@SimenB I could add support for ctrl + j & ctrl + k. Will create a PR soon


Question about CPL

I have a question about CPL, in the code:models/flexmatch/flexmatch_utils.py line 44~46.
44 mask = max_probs.ge(p_cutoff * (class_acc[max_idx] / (2. - class_acc[max_idx]))).float()  # convex
45 # mask = max_probs.ge(p_cutoff * (torch.log(class_acc[max_idx] + 1.) + 0.5)/(math.log(2) + 0.5)).float()  # concave
46 select = max_probs.ge(p_cutoff).long()

I understand in the article is that in different iterations, the multiplied coefficients of thresholds are different, so as to achieve the purpose of filtering better samples. But in actual code
46 select = max_probs.ge(p_cutoff).long()

But I see that select is used for the calculation of class_acc[] in the next iteration for the data selection of unlabed, that is, it plays the role of filtering data in the next iteration.
In other words, the thresholds for screening for each class are not multiplied by coefficients. Here, the class_acc[] I understand is the coefficient that thresholds needs to be multiplied by.
More specifically, I don't quite understand whether the adjustment of the learning parameters in different iterations is done by adjusting the threshold coefficient in flexmatch? Or is the value optimized by adjusting the loss to optimize the model parameters?

i have the same qi have the same question with you.uestion with you.the flex threshold  is only used for loss ,not for  Pseudo Labeling.


Implement Ctx for Context for resolving Foreign

The ir::Context structure is the only thing that can resolve Foreign indices since we need both the component and the underlying index type. Providing convenience get methods for all the various Foreign in the IR would be useful. However, the current Ctx trait is not amenable to this change since we need to implement add as well. It might be useful to separate the trait out so that we can implement get methods.

We should change the Ctx stuff to use a IdxLike instead of an Idx, implement IdxLike for Foreign, and use that to implement Ctx methods for Context.

Could we not have the add function insert the held key into the relevant component as well? Maybe this would be weird behavior, I'm not sure.

Nevermind, I forgot add only takes T so would not specify what component to insert into.


fix AudioFile offline import

move to global import, since it is required with OfflineBackend().get_stt()
Unluckily i haven't saved the exception, but should be self-explanatory.

this was on purpose, ovos-backend-client almost never requires this dep, only if you are running offline and some code manually calls STTApi for compat. this is optional and should not be top level as the import will fail 99% of the time and that is fine


Fix empty HostConfig Links key leads to error.


[FR] Per-chat Notification Settings

No content

Issue created by BlueBubbles Bot in the BlueBubbles commnity on behalf of @zach in #requests.

This is native to android. Closing


Highlight limitations earlier in doc

Our team recently hit an issue where the Trigger didn't fire or would fire but after 10-15mins in some cases.
When reviewing the doc I found the limitations listed but currently at the very bottom! This PR simply moves these to the top to make it more apparent to users that this, in some cases, may not trigger.

@lawrencegripper : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Makes sense. Thanks, @lawrencegripper!
#sign-off


Add localization

Currently all displayed texts on the Live Map are in German. As we should aim for the biggest audience possible we must consider adding some kind of localization.

Switching to english would be enough for me in the first place.


i want to ignore my custom imageview, but Glide throws Exception

i am sorry my poor english.
i know glide don`t set tag to image view, what should i do?
   java.lang.IllegalArgumentException: You must not call setTag() on a view Glide is targeting
                                                                       at com.bumptech.glide.request.target.ViewTarget.getRequest(ViewTarget.java:133)
                                                                       at com.bumptech.glide.RequestBuilder.into(RequestBuilder.java:367)
                                                                       at com.bumptech.glide.RequestBuilder.into(RequestBuilder.java:432)

Set the tag either before Glide starts loading the image, or wait until it's finished

thanks ,  i made my custom image view extends aes image view and solved the problem

can you close this issue then?

if i use mikepenzs [MaterialDrawer](https://github.com/mikepenz/MaterialDrawer) ,what should i do ?  it throws exception not found resource id, it cant set tag


[Enhancement] It would be good if we can see more mail's message body in preview

Hi,
Thanks for the workflow. I have a small enhancement request.
Currently, we see about some 100 characters of email body as preview. It would be good if there is some way of extending it (May be showing preview in multiple lines). 100 characters is too less.

Hi @rajeshksv,
Thanks for your feedback. I will look into this as soon as I can.
Regards,
Fabio

Can't wait to see it live! And thank you for this awesome workflow.


minor formatting

Rename title for clustering and added it to nav and realigned nav for widgets

These changes look good to me.
More general question here: What is the order of this list? Should we convert it to be alphabetical?

@gavinr I was trying to organizing it by categories.


Zoom in messed up the layout and that look stretched

Describe the bug
In any of the read grid layout demo, if we try to zoom in, every grid item height will start to decrease and width will start increasing. this will look like it is stretched out
Your Example Website or App
https://codesandbox.io/s/staging-bush-3lvt7?file=/src/ShowcaseLayout.js
Steps to Reproduce the Bug or Issue

Go to https://react-grid-layout.github.io/react-grid-layout/examples/0-showcase.html
Zoom in

Expected behavior
If we try to zoom in, the width and height should not look like they are stretched out. something similar to what I am seeing in this code pen which is using gridster - https://codepen.io/tkimm/pen/wxwpej
react-grid-layout library version
1.3.4
Operating System Version
macOS
Browser
Chrome
Additional context
To me, it look like zooming in roughly means, watching the grid in big monitor so that means that the grid will look like that in the bigger monitors.
Screenshots or Videos

Hi RGL, I am facing the same issue, as I am using this wonderful library to a canvas element in the middle, like in the image given, it would create lot of space below as I zoom in, Any I idea on how to use this as a card element with canvas element as Image.


Failed to build iOS app - Could not build the precompiled application for the device.

Steps to Reproduce
app work at android but not at iOS
I'm try to run
flutter clean
flutter pub get
flutter pub cache repair

then
flutter create .
flutter pub get
flutter run -v

this is the output from flutter run -v
output.txt
I attached flutter doctor -v
doctor_out.txt

@mahmoudElgohary
The main error seems to be :
build/ios/Debug-iphoneos/TOCropViewController/TOCropViewController.framework/TOCropViewController
           ld: file not found: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/arc/libarclite_iphoneos.a

And may be related to https://github.com/CocoaPods/CocoaPods/issues/11808, so try to upgrade your cocoapods version and try again to see if it helps or not.

@mahmoudElgohary The main error seems to be :
build/ios/Debug-iphoneos/TOCropViewController/TOCropViewController.framework/TOCropViewController
           ld: file not found: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/arc/libarclite_iphoneos.a

And may be related to CocoaPods/CocoaPods#11808, so try to upgrade your cocoapods version and try again to see if it helps or not.

Same problem

The same issue, and upgrading to the latest version still doesn't work

Can confirm this works after https://stackoverflow.com/a/75729977/856088

worked with me after remove cocopods
https://stackoverflow.com/a/35316717
and install it again
https://guides.cocoapods.org/using/getting-started.html
thanks @darshankawar  @aj-ed

This is a duplicate of https://github.com/flutter/flutter/issues/124340 caused by a change of behavior in Xcode 14.3.  Please upgrade to Flutter 3.7.11 and remove any changes you made to your Podfile to work around the issue.
If you are still seeing issues, please file a new GitHub issue and completely fill out the template.


add enemy armor to weapon rolls

Changes / Comments

Adds an enemy armor function to weapon rolls

Needs to be verified, I am not a PLUS subscriber
Roll20 Requests
Comments are very helpful for reviewing the code changes. Please answer the relevant questions below in your comment.

[ ] Does the pull request title have the sheet name(s)? Include each sheet name.
[ ] Is this a bug fix?
[x] Does this add functional enhancements (new features or extending existing features) ?
[ ] Does this add or change functional aesthetics (such as layout or color scheme) ?
[ ] If changing or removing attributes, what steps have you taken, if any, to preserve player data ?
[ ] If this is a new sheet, did you follow Building Character Sheets standards ?

If you do not know English. Please leave a comment in your native language.

Character Sheet Info Roll20 Internal Use only.


Test suite: Hidden dependencies on native objects/functions/methods

So, as I've documented comprehensively in #940, for some broken JS katas it's caused by Test suite implicitly depending on some JS native functions, which doesn't make any sense. Here is a list of hidden dependencies from what I can remember:

Test methods depends on Array.isArray and String.prototype.toUpperCase
Test.assertEquals depends on Object.assign and JSON.stringify
Test.randomNumber depends on Math.floor

and who knows how many more dependencies exists. They cause problems with writing handicap katas because in the process of removing native objects/functions/methods, the test suite will malfunction, resulting in a sad, broken kata.
I think there are two ways to remove the dependency:

Store the native dependencies internally first, then call the stored instances instead (assuming Test suite is initialized before preloaded code).
Polyfill. Too big of an effort, and not always possible, but will work even if test suite is initialized after user code.

(I'm not sure if other languages have similar problems; haven't dug into those languages deeply to stumble on these kind of problems.)

I just discovered a very bad usage of this issue:
If any kata uses Test.assertSimilar for the tests, because for some reasons it uses JSON.stringify even for primitive data types e.g strings, I can always override JSON.stringify so anything would be equal to each other:
JSON.stringify=()=>''; //bad bad bad

I've read the cli framework codebase somewhat yesterday, and since Test methods are already cached and defined before any code, why not things that these methods depend on too?

why not things that these methods depend on too?

Because resources are limited and there's no end to this.  Most languages have some ways to cheat.

They cause problems with writing handicap katas because in the process of removing native objects/functions/methods, the test suite will malfunction, resulting in a sad, broken kata.

/home/codewarrior/solution.txt (or /workspace/solution.txt) should be read instead of messing with the builtins. The problem is lack of documentation and inability to edit broken kata. I can't do anything about the latter, but the new documentation contains this info.

Because resources are limited and there's no end to this.

I was thinking along the line of how lodash handles native method references, e.g _.random still works the same even if Math.random is hacked before or after the require. That line was referring to the fact that cw-2 is also a require in cli, so it can as well make local references to native methods to prevent native method overrides changing its behaviour.
relevant source code for lodash's random method

Just to be clear, by "resources are limited" I meant only few people actively contributes to that project and we can't do everything. It's just not realistic to keep patching for every cheat/workaround found. Anyone can open a PR suggesting fixes though.
Injecting at the fixture sounds like a good idea and should be possible by refactoring parts of cw-2.js. Note that cw-2.js is really old and full of legacy code. It's not even a proper module :(
I've been wanting to do something about cw-2.js, but it hasn't been my priority.

Closing as wontfix


HTTP/2 not mentioned

It seems to me that any page discussing bundling and minification should mention HTTP/2. It is not clear to me why bundling is necessary in the modern world with HTTP/2 and HTTPS becoming pretty much standard.
Also, this page does not seem to mention the fact that all JS minifiers will eventually fall behind the fast moving languages of JS and CSS. This is a concern because compilation errors are most likely not detected by the minifier in the same way you can expect from a C# compiler and will result in hard to diagnose production errors.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 36f55e9a-cd3f-83a0-f142-969dc10d3ceb
Version Independent ID: f6845f70-1ac6-2036-f213-a3b665b3d8bf
Content: Bundle and minify static assets in ASP.NET Core
Content Source: aspnetcore/client-side/bundling-and-minification.md
Product: aspnet-core
GitHub Login: @scottaddie
Microsoft Alias: scaddie

@danroth27 can we retire this high issue doc?

@Rick-Anderson I don't think so. We need to have some public statement about what our bundling and minification story is for ASP.NET Core. But we can try to simplify or correct it if there are particular sections that are problematic.

it isn't use webpack when building?

Migrated to Bundle and minify master issue #18523


Fix functional tests failure

Functional tests are failing randomly in CI setup when running all the tests together.
But tests are not failing when running them in groups (Splitting the tests in 2 or 3 sets and run them in parallel). Need to investigate and troubleshoot to figure out the root cause and fix the failure.

@luckyj5 - is this still issue. Update and close accordingly.

Yes, functional tests were failing randomly and hence were not included as part of the CI pipelines. This needs to be looked at and could be a part of CI migration to CircleCI process.
@gp510 Can you take a look at this when you work on CircleCI stuff?

@dtregonning @luckyj5 - Yes I am looking into this


Test issue 3

Another issue for label testing

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e2473c12-0d72-4437-dcd7-ca85ca28ee95
Version Independent ID: d809e109-bed8-876a-c455-ed230f5a9bb5
Content: Evaluating a Control Method Without Input Arguments - Windows drivers
Content Source: windows-driver-docs-pr/acpi/evaluating-a-control-method-without-input-arguments.md
Product: windows-hardware
Technology: windows-devices
GitHub Login: @barrygolden
Microsoft Alias: bagold

#please-close

Closing


[DOCFIX]docfix for docs/cn/Running-Hive-with-Alluxio.md

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/14185/
Test PASSed.


Poll failure on Fridge1

Describe The Bug:
I'm getting status errors from my 2023 Samsung Bespoke fridge, shortly after most of the temperature accessories disappear.
To Reproduce:
The plugin is installed and in child bridge mode.
Expected behavior:
All the temperature accessories should remain and not disappear.
Logs:
[8/25/2023, 12:33:20 PM] [Smartthings Plugin] Fridge1 returned bad value for status
[8/25/2023, 12:33:20 PM] [Smartthings Plugin] Bad status from Fridge1.  Ignoring for now.
[8/25/2023, 12:33:20 PM] [Smartthings Plugin] Poll failure on Fridge1
[8/25/2023, 12:33:26 PM] [Smartthings Plugin] Fridge1 returned bad value for status
[8/25/2023, 12:33:26 PM] [Smartthings Plugin] Bad status from Fridge1.  Ignoring for now.
[8/25/2023, 12:33:26 PM] [Smartthings Plugin] Poll failure on Fridge1
[8/25/2023, 12:33:30 PM] [Smartthings Plugin] Fridge1 returned bad value for status
[8/25/2023, 12:33:30 PM] [Smartthings Plugin] Bad status from Fridge1.  Ignoring for now.
[8/25/2023, 12:33:30 PM] [Smartthings Plugin] Poll failure on Fridge1
[8/25/2023, 12:33:35 PM] [Smartthings Plugin] Fridge1 returned bad value for status
[8/25/2023, 12:33:35 PM] [Smartthings Plugin] Bad status from Fridge1.  Removing this service.
[8/25/2023, 12:33:35 PM] [Smartthings Plugin] Poll failure on Fridge1

i have teh same problem
[29/09/2023, 21:22:33] Homebridge v1.6.1 (HAP v0.11.1) (Homebridge A64D) is running on port 51102.
[29/09/2023, 21:22:33] [Smartthings Plug (IK)] Restoring existing accessory from cache: Refri
[29/09/2023, 21:22:35] [Smartthings Plug (IK)] Refri returned bad value for status
[29/09/2023, 21:22:35] [Smartthings Plug (IK)] Bad status from Refri.  Ignoring for now.
[29/09/2023, 21:22:35] [Smartthings Plug (IK)] Refri returned bad value for status
[29/09/2023, 21:22:35] [Smartthings Plug (IK)] Bad status from Refri.  Ignoring for now.
[29/09/2023, 21:22:35] [Smartthings Plug (IK)] Refri returned bad value for status
[29/09/2023, 21:22:35] [Smartthings Plug (IK)] Bad status from Refri.  Ignoring for now.
[29/09/2023, 21:22:35] [Smartthings Plug (IK)] Refri returned bad value for status
[29/09/2023, 21:22:35] [Smartthings Plug (IK)] Bad status from Refri.  Ignoring for now.
[29/09/2023, 21:22:38] [Smartthings Plug (IK)] Refri returned bad value for status
[29/09/2023, 21:22:38] [Smartthings Plug (IK)] Bad status from Refri.  Ignoring for now.
[29/09/2023, 21:22:38] [Smartthings Plug (IK)] Poll failure on Refri
[29/09/2023, 21:22:38] [Smartthings Plug (IK)] Refri returned bad value for status
[29/09/2023, 21:22:38] [Smartthings Plug (IK)] Bad status from Refri.  Ignoring for now.
[29/09/2023, 21:22:38] [Smartthings Plug (IK)] Poll failure on Refri
[29/09/2023, 21:22:39] [Smartthings Plug (IK)] Refri returned bad value for status
[29/09/2023, 21:22:39] [Smartthings Plug (IK)] Bad status from Refri.  Ignoring for now.
[29/09/2023, 21:22:39] [Smartthings Plug (IK)] Poll failure on Refri
[29/09/2023, 21:22:39] [Smartthings Plug (IK)] Refri returned bad value for status
[29/09/2023, 21:22:39] [Smartthings Plug (IK)] Bad status from Refri.  Ignoring for now.
[29/09/2023, 21:22:39] [Smartthings Plug (IK)] Poll failure on Refri
[29/09/2023, 21:22:39] [Smartthings Plug (IK)] Refri returned bad value for status
[29/09/2023, 21:22:39] [Smartthings Plug (IK)] Bad status from Refri.  Ignoring for now.
[29/09/2023, 21:22:39] [Smartthings Plug (IK)] Poll failure on Refri
[29/09/2023, 21:22:44] [Smartthings Plug (IK)] Refri returned bad value for status
[29/09/2023, 21:22:44] [Smartthings Plug (IK)] Bad status from Refri.  Ignoring for now.
[29/09/2023, 21:22:44] [Smartthings Plug (IK)] Poll failure on Refri
[29/09/2023, 21:22:44] [Smartthings Plug (IK)] Refri returned bad value for status
[29/09/2023, 21:22:44] [Smartthings Plug (IK)] Bad status from Refri.  Ignoring for now.
[29/09/2023, 21:22:44] [Smartthings Plug (IK)] Poll failure on Refri
[29/09/2023, 21:22:44] [Smartthings Plug (IK)] Refri returned bad value for status
[29/09/2023, 21:22:44] [Smartthings Plug (IK)] Bad status from Refri.  Ignoring for now.
[29/09/2023, 21:22:44] [Smartthings Plug (IK)] Poll failure on Refri
[29/09/2023, 21:22:45] [Smartthings Plug (IK)] Refri returned bad value for status
[29/09/2023, 21:22:45] [Smartthings Plug (IK)] Bad status from Refri.  Ignoring for now.
[29/09/2023, 21:22:45] [Smartthings Plug (IK)] Poll failure on Refri
[29/09/2023, 21:22:45] [Smartthings Plug (IK)] Refri returned bad value for status
[29/09/2023, 21:22:45] [Smartthings Plug (IK)] Bad status from Refri.  Ignoring for now.
[29/09/2023, 21:22:45] [Smartthings Plug (IK)] Poll failure on Refri
[29/09/2023, 21:22:49] [Smartthings Plug (IK)] Refri returned bad value for status
[29/09/2023, 21:22:49] [Smartthings Plug (IK)] Bad status from Refri.  Ignoring for now.
[29/09/2023, 21:22:49] [Smartthings Plug (IK)] Poll failure on Refri
[29/09/2023, 21:22:49] [Smartthings Plug (IK)] Refri returned bad value for status
[29/09/2023, 21:22:49] [Smartthings Plug (IK)] Bad status from Refri.  Ignoring for now.
[29/09/2023, 21:22:49] [Smartthings Plug (IK)] Poll failure on Refri
[29/09/2023, 21:22:50] [Smartthings Plug (IK)] Refri returned bad value for status
[29/09/2023, 21:22:50] [Smartthings Plug (IK)] Bad status from Refri.  Ignoring for now.
[29/09/2023, 21:22:50] [Smartthings Plug (IK)] Poll failure on Refri
[29/09/2023, 21:22:51] [Smartthings Plug (IK)] Refri returned bad value for status
[29/09/2023, 21:22:51] [Smartthings Plug (IK)] Bad status from Refri.  Ignoring for now.
[29/09/2023, 21:22:51] [Smartthings Plug (IK)] Poll failure on Refri
[29/09/2023, 21:22:51] [Smartthings Plug (IK)] Refri returned bad value for status
[29/09/2023, 21:22:51] [Smartthings Plug (IK)] Bad status from Refri.  Ignoring for now.
[29/09/2023, 21:22:51] [Smartthings Plug (IK)] Poll failure on Refri
[29/09/2023, 21:22:54] [Smartthings Plug (IK)] Refri returned bad value for status
[29/09/2023, 21:22:54] [Smartthings Plug (IK)] Bad status from Refri.  Ignoring for now.
[29/09/2023, 21:22:54] [Smartthings Plug (IK)] Poll failure on Refri
[29/09/2023, 21:22:54] [Smartthings Plug (IK)] Refri returned bad value for status
[29/09/2023, 21:22:54] [Smartthings Plug (IK)] Bad status from Refri.  Ignoring for now.
[29/09/2023, 21:22:54] [Smartthings Plug (IK)] Poll failure on Refri
[29/09/2023, 21:22:56] [Smartthings Plug (IK)] Refri returned bad value for status
[29/09/2023, 21:22:56] [Smartthings Plug (IK)] Bad status from Refri.  Ignoring for now.
[29/09/2023, 21:22:56] [Smartthings Plug (IK)] Poll failure on Refri
[29/09/2023, 21:22:57] [Smartthings Plug (IK)] Refri returned bad value for status
[29/09/2023, 21:22:57] [Smartthings Plug (IK)] Bad status from Refri.  Ignoring for now.
[29/09/2023, 21:22:57] [Smartthings Plug (IK)] Poll failure on Refri
[29/09/2023, 21:22:57] [Smartthings Plug (IK)] Refri returned bad value for status
[29/09/2023, 21:22:57] [Smartthings Plug (IK)] Bad status from Refri.  Ignoring for now.
[29/09/2023, 21:22:57] [Smartthings Plug (IK)] Poll failure on Refri
[29/09/2023, 21:22:59] [Smartthings Plug (IK)] Refri returned bad value for status
[29/09/2023, 21:22:59] [Smartthings Plug (IK)] Bad status from Refri.  Removing this service.
[29/09/2023, 21:22:59] [Smartthings Plug (IK)] Poll failure on Refri
[29/09/2023, 21:23:00] [Smartthings Plug (IK)] Refri returned bad value for status
[29/09/2023, 21:23:00] [Smartthings Plug (IK)] Bad status from Refri.  Ignoring for now.
[29/09/2023, 21:23:00] [Smartthings Plug (IK)] Poll failure on Refri
[29/09/2023, 21:23:01] [Smartthings Plug (IK)] Refri returned bad value for status
[29/09/2023, 21:23:01] [Smartthings Plug (IK)] Bad status from Refri.  Removing this service.
[29/09/2023, 21:23:01] [Smartthings Plug (IK)] Poll failure on Refri
[29/09/2023, 21:23:03] [Smartthings Plug (IK)] Refri returned bad value for status
[29/09/2023, 21:23:03] [Smartthings Plug (IK)] Bad status from Refri.  Removing this service.
[29/09/2023, 21:23:03] [Smartthings Plug (IK)] Poll failure on Refri
[29/09/2023, 21:23:03] [Smartthings Plug (IK)] Refri returned bad value for status
[29/09/2023, 21:23:03] [Smartthings Plug (IK)] Bad status from Refri.  Removing this service.
[29/09/2023, 21:23:03] [Smartthings Plug (IK)] Poll failure on Refri
[29/09/2023, 21:23:05] [Smartthings Plug (IK)] Refri returned bad value for status
[29/09/2023, 21:23:05] [Smartthings Plug (IK)] Bad status from Refri.  Removing this service.
[29/09/2023, 21:23:05] [Smartthings Plug (IK)] Poll failure on Refri

Where can I get info on setting my fridge up with the smart things plug?


Usage should only be shown when usage is incorrect

I ran iam project list command (following the instructions here). The command appears to have failed due to mongocli receiving an error response from atlas api. mongocli then output this api error and printed usage information:

carbon% mongocli iam project list
Error: GET https://cloud.mongodb.com/api/atlas/v1.0/groups: 404 (request "Not Found") Atlas group 5ea35ecf445d921efae0e86b is in an invalid state and cannot be loaded.
Usage:
  mongocli iam projects list [flags]

Aliases:
  list, ls

Flags:
  -h, --help           help for list
      --orgId string   Organization ID to use. Overrides configuration file or environment variable settings.

Global Flags:
  -P, --profile string   Profile to use from your configuration file. (default "default")

2020/05/29 22:24:30 GET https://cloud.mongodb.com/api/atlas/v1.0/groups: 404 (request "Not Found") Atlas group 5ea35ecf445d921efae0e86b is in an invalid state and cannot be loaded.

As a user of mongocli, I would like mongocli to only print usage information when 1) usage was incorrect or 2) when explicitly requested via help. If usage was correct and operation failed for another reason, I would like mongocli to provide relevant error information which seems like it would not be usage text.

This was done by #141 and released on v0.5.0


Insert wiki-links instead of linking to id

Bear version 2 now has backlinks, which is great.
Unfortunately, the backlink panel won't generate backlinks based on id-links. Bear support said that they have no plans to implement support for building backlinks from 2hard links". They suggested I'd try to get the workflow author to change the links to wiki links.
This is how a "drgib" link looks like after inserting via shift-enter:

This is how a wiki link looks like after draging one note into another.

I would love to have access to the backlink list, but I cannot work without the superb drgrib-workflow.

Is there a way for you personally to create a backlink purely with markdown without using mouse gestures? I'm afraid mouse gestures are beyond the scope of the workflow.

I see that you can use [[<note title>]] but I'm not seeing a way to add the &new_window=yes parameter, which would be an unacceptable alteration to the default behavior for my personal workflow since I very rarely use the main window. I could consider it for a new modifier key other than <shift> if there is enough interest for this. Probably displacing <shift-cmd> for table of contents and changing table of contents to <alt-cmd>.

I'm not sure what you mean. The links you create are shown in my first screen shot. I don't see any new_window parameter in this link.
If I create a link manually, by typing [[title of another note]], I can then cmd-click on this link to open the linked note in a separate window.

Here is a link that I will paste directly from the workflow by holding shift when selecting it and pressing enter:

[cron / crontab](bear://x-callback-url/open-note?id=7DC7E782-AE71-47BE-BD89-6ABFA0B8C7A6-14789-00000CA27EBD6C4C&show_window=yes&new_window=yes)
Notice the &new_window=yes.
Are you saying it isn't functioning like this for you? On reflection, I'm a little confused what the problem is unless you just don't like how the shift-cmd links look.

I see. I was misunderstanding what you meant by backlinks (may have been helpful to explain this in your original post):
https://beta.bear.app/t/bear-2-beta-happy-holidays-update-10084-aka-backlinks/6606
That is a pretty useful feature but it does really suck that you have to cmd-click links to open them in a new window. I'll have to think about whether this is worth overwriting the base shift link or have it displace the current shift-cmd for ToC paste. Either way, I will implement it though since it is a core feature.

I'm sorry for being more clear.
Fwiw, backlinks are out of beta as of Bear V2 a couple of months ago:
https://bear.app/faq/how-to-use-the-info-panel-table-of-contents-and-backlinks-in-bear/
I also like to open links in new windows. IMO this should not be hard coded into the link, but a setting in Bear. I'll file a feature request with Bear and see how it goes.

Bear support said they will consider this setting, "open links in new window", for future releaes. This would be the best solution IMO.

Completely agree. Thanks for making the feature request.

Implemented in #67. Looking forward to Bear adding that global setting.


Screen goes to sleep on android

Expected behaviour
Full screen on android will remove the screen buttons (homescreen, go back and all apps), and won't go to sleep until the end of the video.
Actual behaviour
The screen buttons appear, so the video can't play on the entire screen and moves sideways. Wide videos will have black bars. Also, after 30 seconds the screen goes to sleep and it pasues the video.
Steps to reproduce
Open the video in full screen on an android device
Environment

Browser: Google chrome for android
Version: latest
Operating System: Android on Samsung s8
Version:  Android 9

Link to where the bug is happening
https://plyr.io/

I’m not even sure the browser has control over this behavior?

That’s what I was going to say. I’m pretty sure all mobile browsers use their native player for full screen mode so Plyr would not be the reason for this behavior.
Sounds like something wrong with the OS and/or browser.

Is there a way to disable plyr in fullscreen automatically so it will show the native player? Because I'm pretty sure a lot of users have the bug.

I just tested this out with a 7 minute HLS video and didn't have the screen turn off during the video. The on-screen buttons do appear as the OP pointed out, but I'm not sure about  whether they should/shouldn't.
Regardless, It sounds like you're using it for simple mp4/webm videos. You can override the fullscreen listener and run your own logic. That way, you could add the default controls when entering fullscreen and remove them when exiting.

I see this bug is still here in 2021 on https://plyr.io/.
Did anyone find a solution?


Extend AAD groups support to Org level

AAD Groups are currently supported at distribution groups within individual apps. Consider extending this to the distribution groups at the org level.

Hello! Glad you ask that. We are currently working on adding AAD to organizations and then we'll he adding AAD to distribution groups in Orgs. Stay tuned!

integration with AAD is really limiting if you have to invite users via email and only have the integration as a DG.  Seems like this could be an easy integration.


Display the amount of new announcements as on the tab icon

@SourbaevaJanaraJ, @azackmatoff, @Malixxa am I correct that we don't have this icon if we display all the messages on the homepage?
If yes, please close this issue.


Async await

Some help with https://github.com/OpenAPITools/openapi-generator/pull/4210
This may take a while. The next issue has something to do with async_trait:
42 | #[async_trait]
   | ^^^^^^^^^^^^^^ `std::rc::Rc<apis::configuration::Configuration>` cannot be shared between threads safely
   |
   = help: within `apis::tenant_api::TenantApiClient`, the trait `std::marker::Sync` is not implemented for `std::rc::Rc<apis::configuration::Configuration>`

I'll probably investigate more tomorrow. This can be merged as is if you want.

Looks like @srenauld solved this already in https://github.com/OpenAPITools/openapi-generator/pull/4175
https://github.com/OpenAPITools/openapi-generator/pull/4175/files#diff-7e03999fbf48b029588e3a360f6a27abR39

Due to the requirement that all futures should be Send, the reference-counting pointer is now an Arc

I'll port that change and try it out tomorrow.


Upgraded Phinx to 0.9.2

This PR upgrades Phinx to 0.9.2. The main difference for us is that the new release is compatible with Symfony 4.
Related to #618.

Thank you, @derrabus!


added collapsible categories

added ability to collapse a category with a chevron icon  to make navigation easier on mobile

added a state to category.tsx to toggle subcategory.tsx
added a new prop to subcategory.tsx to reflect changes

feedback is apricated

Thanks Buddy, great work I will merge it and add some updates to it like adding duration to the toggle button I will share the commit.

@vCiKv You can check here


Bring README up to date after #489

What does this do / why do we need it?
README was out of date after merging of #489
What should your reviewer look out for in this PR?
My big question would be whether the diagram is sufficiently helpful to be justified.
Other than that, making sure that I haven't been too cryptic 😄
Fixes #565 😄 😄 😄

@carolynvs are you good with this now, then?

Doh! I need to learn to not reply to comments that have been hidden due to new commits...
I was hoping we could tweak the recommendation for adding a dependency:

Since this is the quickstart/readme, how about telling people only the best practice:

Run dep ensure -add github.com/foo/bar. This adds a constraint for the latest version to your Gopkg.toml, then updates the lock and vendor directory.
Import and use the package in your code. ✨

Sparkles optional, but highly recommended.

It's not a huge deal, and we can merge without it, but I think it will help avoid confusion for new users.

ahh ok - yeah, that's fair, i had a similar thought while writing that. yeah, can tweak.

@carolynvs how dat?


Pull Request Catalog My Things - 03 add music album and genre classes

In this Pull Request Team Member #2 has created the music album and genre classes, all its properties, methods, and tests. It included also a create_musicalbum method and adjustment of the menu options.

status: APPROVED :green_circle: :100:
Hi, @jcmunav63 ,
Good job so far 👍 Your project is complete!  There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉
Highlights ⚡
✅ Descriptive PR 👍
✅ Great attempt adding the classes 🔥
✅ Good commit messages 👍
Optional suggestions
N/A
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Please: take into account that I am aproving this pull request even though linters are not passing because we will merge your version with mine and after solving conflict and we will create a pull request in which all linters and tests must pass.


⚡ Add code for JavaScript

Be it React, Angular, Vue.js, Next.js, or simple JavaScript.
Javascript is the heartthrob of every web developer.
Do contribute more and more in JavaScript.

I want to work on this issue .Can you assign me this

Sure thing. I am assigning you this issue. Please make sure to submit QUALITY codes.

I wanna Contribute to this, hope the Codes will be useful for others.

Sure thing @DevAffan I am assinging you this issye.


Add support for a cross namespace ClusterClass access

As a ClusterClass user I’d like to reuse existing template from a single namespace with multiple Clusters.
It is required to provide customizable restrictions on a cross-namespace access, which can be achieved in k/k 1.30+ by using https://kubernetes.io/docs/reference/access-authn-authz/validating-admission-policy/
This change needs to be implemented upstream and have sufficient e2e test coverage.

https://github.com/kubernetes-sigs/cluster-api/pull/11361
https://github.com/kubernetes-sigs/cluster-api/pull/11352


remove the SWS create worker locks

allow all these jobs to run as they shouldn't be enqueued multiple times.
If they are let the db unique index control state vs swamping redis with lock structures
Review checklist

[ ] First, the most important one: is this PR small enough that you can actually review it? Feel free to just reject a branch if the changes are hard to review due to the length of the diff.
[ ] If there are any migrations, will they the previous version of the app work correctly after they've been run (e.g. the don't remove columns still known about by ActiveRecord).
[ ] If anything changed with regards to the public API, are those changes also documented in the apiary.apib file?
[ ] Are all the changes covered by tests? Think about any possible edge cases that might be left untested.

So this just moves any potential locking from the job (via unique args) in redis to SubjectWorkflowStatus.create postgres? I wasn't around for whatever problem this is solving by lgtm on principal.

If there is a large spike in the number of these enqueued in redis, i.e. large subject set linkage / upload of lots of data happens, then these add lock structures to the redis store. We had ~7million enqueued jobs yesterday morning (not all these jobs but lots were) that caused a spike in redis db size. That in turn caused errors when redis tried to flush the db to disk for persistence, eventually filling the disk. https://redis.io/topics/persistence#how-it-works
Reducing the number of locks keeps the redis db size small, fast to persist and easy to manage.

So this just moves any potential locking from the job (via unique args) in redis to SubjectWorkflowStatus.create postgres?

Instead we check if the SWS exists via index query (fast) and then attempt to make it via the create! method. That is backed by a uniq index so will fail if we have duplicate jobs running at the same time.
So yeah, a little more db pressure in postgres vs redis if that duplicate case happens (and we should see those non-uniq index errors report).


fix(clerk-js): Match alignment of Set username & Set password buttons with the designs

Description
This PR fixes the misalignment of Set username & Set password so we can match the designs.
Before
Set Username

Set password

After
Set Username

Set password

Checklist

[ ] npm test runs as expected.
[ ] npm run build runs as expected.
[ ] (If applicable) JSDoc comments have been added or updated for any package exports
[ ] (If applicable) Documentation has been updated

Type of change

[ ] 🐛 Bug fix
[ ] 🌟 New feature
[ ] 🔨 Breaking change
[ ] 📖 Refactoring / dependency upgrade / documentation
[ ] other:

!preview

Hey @anagstef, your preview is currently deploying and should be available shortly.

Status
Preview
Updated (UTC)

:cook: Deploying...
Inspect
Mar 01, 2024 11:26 AM

💅🏻


Codeunit 90 Purch.-Post - Redesign Publisher

A publisher has been added for option 3 of the purchase line so that developers can react to it. Unfortunately this publisher is dead, because it is simply unusable. The publisher has no reference to any global parameter used in the codeunit. No Gen Jnl Line, no document no., no srccode, only PO Header an Line. The Property GlobalVarAccess is also deactivated.
Publisher OnBeforePostResourceLine(PurchaseHeader,PurchaseLine,IsHandled);
What's that supposed to do?
If you have developed a posting routine for resources as a partner, you cannot use the Publisher.
Please change.
Example
PostResourceLineGOB(PurchLine,PurchHeader,GenJnlLineDocNo,GenJnlLineExtDocNo,SrcCode);

We have a plan here, this is just step 1.


Bump release to update graphviz pin

@conda-forge-admin rerender

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

cc @satra

@jschueller - would you like to add yourself to the maintainer list?


Toggle Scheduled and Reconciled Transaction Buttons

Completed scheduled and reconciled transaction toggle feature. Includes
options for two different button styles.

Thank you!


Docstrings: non-standard WMS parameters as L.TileLayer.WMS options

In order to decrease user confusion, see https://gis.stackexchange.com/questions/192118/adding-wms-layer-with-cql-filter/192132#192132

:+1:


Creating a personal access token with all dropdowns set to "no access" results in a token with all privileges

Looks like if you set every dropdown to "no access" the Manager sends the account/tokens POST request with no scopes parameter, which the API interprets as "all scopes."

The API doesn't actually allow you to create a Personal Access Token that says NO to every scope level. Bumping it to them for now.


Accessing Nuxt composables inside useAsyncData after awaiting some other promise throws error: "A composable that requires access to the Nuxt instance was called outside of a plugin, Nuxt hook, Nuxt middleware, or Vue setup function."

Environment

Operating System: Linux
Node Version:     v16.17.0
Nuxt Version:     3.7.4
CLI Version:      3.9.0
Nitro Version:    2.6.3
Package Manager<EMAIL_ADDRESS>Builder:          -
User Config:      telemetry, ssr
Runtime Modules:  -
Build Modules:    -

Reproduction
https://codesandbox.io/p/sandbox/elated-orla-cd8gl2?file=%2Fapp.vue%3A8%2C18
Describe the bug
<script lang="ts" setup>
// ~/app.vue
import { testUtilFunc } from "~/utils/someUtils";

const { error, data } = useAsyncData(
  "some-id",
  async () => {
    // It has to await an async function
    const message = await testUtilFunc(); /* returns Promise<"ok"> */

    // Using any nuxt composable hereafter shall throw the error
    useServerSeoMeta({
      title: message,
    });

    return message;
  },
  {
    // uncomment this to make it work again
    // server: false
  },
);

// ~/utils/someUtils.ts
export async function testUtilFunc() {
  return "ok";
}

Additional context
All Nuxt composables are inaccessible after awaiting a promise from a function in a util file (that doesn't have access to a Nuxt instance), including useServerSeoMeta, etc..
NOTE: This is ONLY occurring if the page is rendered on the server. If it renders on the client, it works ok.
Logs
No response

See https://nuxt.com/docs/api/composables/use-nuxt-app#runwithcontext. This will hopefully explain why you're getting the message and help you resolve it.
I would not call useServerSeoMeta within useAsyncData however. It's meant to be called in your setup function, and in general calling things with side-effects inside useAsyncData will cause bugs in your app as the fetcher function is meant to be pure - just return a value.

Thanks for the reply! runWithContext worked, but I'm a little confused as to how to do this properly now. What is the safe way of using data fetched asynchronously in meta tags in the served page?

Something like this should work:
import { testUtilFunc } from "~/utils/someUtils";

const { error, data } = useAsyncData(
  "some-id",
  async () => {
    // It has to await an async function
    const message = await testUtilFunc(); /* returns Promise<"ok"> */

    return message;
  },
  {
    // uncomment this to make it work again
    // server: false
  },
);

// using a computed getter here but you can also await `useAsyncData` above
useServerSeoMeta({
  title: () => data.value,
});

Hi @danielroe , I tired this but whenever I use useServerSeoMeat, the tags are empty when I use useSeoMeta, the tags in the head are populated but web crawlers do not find them. if I inspect the page, I can see the tags. ```

{{ data?.title }}

.

@gee-whiz It seems this is an upstream bug with useSeoMeta that is being looked into.

@danielroe Thanks, I guess I have to wait then

Thanks, @danielroe let's wait and see how it works.
Also facing the same error
[Vue Router warn]: uncaught error during route navigation: Error: [nuxt] A composable that requires access to the Nuxt instance was called outside of a plugin, Nuxt hook, Nuxt middleware, or Vue setup function. This is probably not a Nuxt bug.

This is still an issue even after running yarn upgrade

@Foddie2 Would you open a new issue with a reproduction? 🙏

@danielroe  FYI #24277

@danielroe I try to use  navigateTo and useCookie in composables which using useFetch wrapped like axios library, but caught error [nuxt] A composable that requires access to the Nuxt instance was called outside of a plugin, Nuxt hook, Nuxt middleware, or Vue setup function. This is probably not a Nuxt bug.


Change logging module artifact id to reflect that it is a log4j plugin

Description:
Change logging module artifact id to reflect that it is a log4j plugin

Closing since the impact of the change is low.


Wiki: cyclic dependencies copy

https://github.com/google/guice/wiki/CyclicDependencies
Probably not ideal to refer to customers as "suckers" in a public repo. Appears several times in snippets.

These are hypothetical customers in hypothetical stores with hypothetical clerks.  I don't really see the problem.