HDFS-16931. Observer nn delete blocks asynchronously when tail OP_DEL…

In our HDFS cluster that holds hundreds of millions of metadata, all of which is EC data. When Observer NN replays the OP_DELETE operation which deletes a large directory, involving tens of millions of metadata. Because the operation is synchronous, the Observer NN is stuck for nearly 50 minutes. HDFS-16043 has solved the asynchronous deletion on the active NN. This is to solve the asynchronous deletion on the Observer NN.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m 21s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  2s

codespell was not available.

+0 :ok:
detsecrets
0m  2s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
52m 12s

trunk passed

+1 :green_heart:
compile
1m 38s

trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
compile
1m 22s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
checkstyle
1m 10s

trunk passed

+1 :green_heart:
mvnsite
1m 40s

trunk passed

+1 :green_heart:
javadoc
1m 12s

trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javadoc
1m 34s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
3m 42s

trunk passed

+1 :green_heart:
shadedclient
29m 47s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 36s

the patch passed

+1 :green_heart:
compile
1m 30s

the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javac
1m 30s

the patch passed

+1 :green_heart:
compile
1m 21s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
javac
1m 21s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 55s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 7 new + 118 unchanged - 0 fixed = 125 total (was 118)

+1 :green_heart:
mvnsite
1m 26s

the patch passed

-1 :x:
javadoc
0m 58s
/patch-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt
hadoop-hdfs in the patch failed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.

+1 :green_heart:
javadoc
1m 28s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
3m 45s

the patch passed

+1 :green_heart:
shadedclient
30m 17s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
269m  3s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 50s

The patch does not generate ASF License warnings.

406m 21s

Reason
Tests

Failed junit tests
hadoop.hdfs.TestRollingUpgrade

hadoop.hdfs.server.namenode.TestNameEditsConfigs

hadoop.fs.TestHDFSFileContextMainOperations

hadoop.hdfs.TestAclsEndToEnd

hadoop.hdfs.server.namenode.snapshot.TestRandomOpsWithSnapshots

hadoop.hdfs.server.namenode.snapshot.TestSnapshot

hadoop.hdfs.server.blockmanagement.TestPendingInvalidateBlock

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5424/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5424

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 75cbd5d6c85e 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 9ad5612ab9d30eda3ec16a49f3462775341e1f0a

Default Java
Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5424/1/testReport/

Max. process+thread count
2352 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5424/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m 15s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
41m 59s

trunk passed

+1 :green_heart:
compile
1m 28s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
1m 23s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
checkstyle
1m  7s

trunk passed

+1 :green_heart:
mvnsite
1m 30s

trunk passed

+1 :green_heart:
javadoc
1m  8s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 30s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
3m 36s

trunk passed

+1 :green_heart:
shadedclient
25m 55s

branch has no errors when building and testing our client artifacts.

-0 :warning:
patch
26m 13s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 22s

the patch passed

+1 :green_heart:
compile
1m 22s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
1m 22s

the patch passed

+1 :green_heart:
compile
1m 15s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
javac
1m 15s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 53s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 7 new + 118 unchanged - 0 fixed = 125 total (was 118)

+1 :green_heart:
mvnsite
1m 23s

the patch passed

-1 :x:
javadoc
0m 53s
/patch-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdkUbuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1.txt
hadoop-hdfs in the patch failed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1.

+1 :green_heart:
javadoc
1m 26s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
3m 27s

the patch passed

+1 :green_heart:
shadedclient
26m 18s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
283m 54s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 48s

The patch does not generate ASF License warnings.

401m 19s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.namenode.TestNameEditsConfigs

hadoop.fs.TestHDFSFileContextMainOperations

hadoop.hdfs.TestAclsEndToEnd

hadoop.hdfs.server.namenode.snapshot.TestRandomOpsWithSnapshots

hadoop.hdfs.server.namenode.snapshot.TestSnapshot

hadoop.hdfs.server.blockmanagement.TestPendingInvalidateBlock

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5424/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5424

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux cdab8a3cac01 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 8cd1ba1ad5f9bbee0c2cdb6cac738d2d582206d2

Default Java
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5424/2/testReport/

Max. process+thread count
2212 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5424/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.


Re-enables venafi e2e tests

NONE

/hold

Still failing 😬 I know we heard back that errors here are caused by the common name being invalid - I can see here it is being set to:
  Common Name:  test-common-name
Can we maybe try adding a . in there? i.e. test-common-name.com? If this works, we've at least got an idea what's up 😄

/area venafi

/retest

Closed in favour of #2575


Help getting access to custom tile data

Hi. Apologies for the noob question but I'm coming up against a brick wall here.
I have a tileset "Ground" which has custom data for each tile using the following schema...
{
  "movementSpeed": 0.8
}

I've imported the world into unity and put the level in the scene. In code I can get the tile under the player's current position...
public class PlayerController : MonoBehaviour
{

    Rigidbody2D body;
    Tilemap ground;
    private float horizontal, vertical;
    private readonly float runSpeed = 1.0f, moveLimiter = 0.7f;

    void Start()
    {
        body = GetComponent<Rigidbody2D>();
        ground = GameObject.Find("Ground").GetComponentInChildren<Tilemap>();
    }

    private void FixedUpdate()
    {
        Vector3Int position = Vector3Int.RoundToInt(body.position);
        TileBase tile = ground.GetTile(position);
    }
}

But from here I am drawing a blank on how to access the custom data associated with this tile. Any help is much appreciated. Thanks for the excellent project so far it has been very useful.

Hi, there is indeed a way to get the custom data defined from the importer. I have plans to make this experience easier, but for now, you can access the tile data by deserializing the json data, then traversing through it until you can access the CustomData from the TilesetDefinition:

You can access and deserialize the data from this scriptableobject asset from the imported project with the function FromJson():

Let me know if this solution can work for you 🙂

My LDTK project saves levels as separate files and as such I'm struggling to find a way to access this JSON object in code. I can see it in the assets in the project explorer but when I drop the LDTK project file into the scene in the hierarchy it does not show these children. Is it possible for you to show a simple code example as to how I would access this? Sorry for the noob question, I'm new to Unity and LDTK. Many thanks.

This function in particular will be useful for your situation, where you can traverse the project json to access definitions and additionally levels and their used tilesets in that way.
And you can check here to understand how the LDtk postprocessing works.
Also feel free to join the Discord server where I can provide quicker answers. I didn't realize you had responded here recently after my previous post 😅

Another significantly easier option is defining intgrid values to describe where your character should change it's speed. then you can make your character check for an IntGridTile existing at a position, and check if it matches a reference you are checking for. And voila :)
Let me know if that can work out for you.

Custom tile data is now available in the newest update! You get a tileset tile from the tilemap, which will contain both the custom data and enum values.


Help with new profile

Hi guys,
Someone can help me create a profile for make a equaliser wave only when I start listing music with specific program? Like Media Player for Ex.
Thanks,
Cheers.

In the future, you will be able to set layer's visibility based on various user-defined logic steps. So, in your case, if "itunes.exe" or "vlc.exe" is running. There is no way to isolate audio from a specific program, so it will always use entire system audio.

So you are tell me if i create a layer for some specific program will work but if i get another sound from a external program like youtube meanwhile i listing music will be a mess wave sound because they will mix music from youtube with a program that i choose?

In simple terms. Equalizer layer will always examine entire system sound. You will be able to turn the layer automatically on/off if a specific process is running.

So can you help me to make this turn on/off to a specific process?

It will be a feature in a later version.

So for now I only can go at Aurora and check the box to turn on/off


Vehicle connected sensor, bug fix & deprecation resolution

Hi!
This pull request adds a new sensor, fixes a pre-existing bug and resolves some deprecation warnings.

Adds a new sensor to indicate if a vehicle is connected to the charger (Using the same logic as the app, as a session is started when a vehicle is connected)
Fixes a bug where some entities would become 'unavailable' and the integration needed to be reloaded (Resolves #16), this was due to the charging_time sensor being set to a state_class of 'total_increasing' while also defining 'last_reset', (this is unsupported in HA).
Resolves a number of deprecation warnings for recent versions of home assistant

I've been running this branch for a while, happy to answer any questions.

Need to fix the tests, will re PR this once ready


Where is tyler-sommer/nice-bench ?

The package tyler-sommer/nice-bench used in this benchmark does not seem to exist anymore.

OK, I found nice/bench which looks like a replacement.


Changes to allow pmap-of-sharded_jit to run on multi-host platforms.

Checks that we're running on all local devices after tracing, so we
have the full shard count instead of just the axis size.

Makes sure the device assignment is always the right shape (we
currently generate 1D default device assignments for multi-host)

@trevorcai any chance you wanna review this?

BTW, I'm gonna wait for your approval before submitting. In particular, I added an error if no global_axis_size is specified for inner pmaps but I'm not 100% sure about that :)

Thanks again for the review!


Exception and Error Handling in Python

Article checklist
Attention
Our Peer Reviewer and Content Moderator teams do NOT provide any revisions services. All revisions and edits should be completed on your own forked repo (as to not take up room in the queue) in order for our team to review them all in a timely manner.
ANY ARTICLE SUBMITTED WITH GLARING ERRORS WILL BE IMMEDIATELY CLOSED.

As a rule of thumb - please be sure to only submit articles (pull requests) that are fully polished and ready to be published. Be sure to go through our resources documents for extra and 3rd party (vetted) resources to help improve overall technical writing.

Pre-submission checks

Please ensure that you have only one open topic suggestion (issue) + in-review article (linked pull request) at a time. This will ensure that we complete the review process in a timely manner from inception to publishing

If you have not already, please go over our Resources Page for more tips and tricks on how to improve your overall technical writing so reviews are swifter, increase the chance of a payout and provide more value to our readers.

For first-time contributors and for more details on our submission guidelines, see our Contributing Guidelines.

Formatting and structure checks

[x] Have you used the correct folder and file structure? - see Contribution Guidelines

[x] Is your article properly formatted in Markdown? - see Github Markdown guide

[x] Have you used our preferred heading structure? - H3 (###) and up

[x] Does your article follow any of the suggested structure formats? - see example formats

[x] Is your article over 750 words? - Tool: Wordcounter.net

[x] Is the article you are submitting an in-depth and unique article? Does it go beyond what is in the official docs and what is covered in other blog sites. See these articles as examples.

[x] Does your article provide enough value and detail about your topic? - Articles should be clear, accurate, and fully explained.

[x] Can your article be understood by beginners? - Assume the audience is smart but has no prior exposure to the common terminology in your article.

[x] Have you included a hero image that is 600x400 pixels, under 300KB in size, and have the copyright to use it? - Tools: Pixlr Image Editor for resizing and Unsplash for Creative Commons images

Grammar & plagiarism checks

[x] Have you spellchecked and grammar checked your article? - Tools: Write&Improve - ProWritingAid - Grammarly
[x] Please place your article through a 3rd party plagiarism checker. We suggest using Quetext, this tool is free and has a daily limit. We typically accept articles with 10% or less.
[x] Have you checked your article for readability? - Tool: Hemmingway
[x] Have you added sources for quotes and images that aren't yours?

Technical checks

[x] Are your code snippets properly formatted for syntax highlighting - see Syntax guide
[x] Have you checked your code runs correctly and you've highlighted all necessary dependencies for installation?
[x] Are the software programs and packages you're highlighting in your article up to date, using current versions and not deprecated?

Topic suggestion this closes

Remove the backticks and add the issue number below to link and close your Topic Suggestion (issue) when your article has been published (PR has been merged). See this video for more details.

This closes #4788

Finally, delete the article checklist notes in blockquotes and submit your PR. We look forward to reviewing your article.

Plagiarism check done.

@jerimkaura I  have effected the changes you requested

"Provide snippet identifiers to your code snippets." @jerimkaura I don't understand what you meant by this.

jumping on this one

@raboba2re Please review our resources to improve overall grammar (& readability) of future articles.
This article had various areas that were difficult to read, understand, or words missing!!
We actually should have closed this PR.
cc @jerimkaura  - please do the same as pull requests of this caliber should NOT be pushed for a final review.
If this level of review continues we will need to stop future reviews.


Integrate the JLink workflow and scripts into the Ubi9 container sources

Initial implementation of adding the jlink scripts to the openjdk container sources.

Adds a Jlink module containing the scripts and an installation script along the lines of the other modules
Adds the jlink module as a dependency of the S2I bash module
Invokes the jlink workflow following the maven s2i build, once the artifacts are build we're good to go to perform the dependency analysis and create the JRE.

Related JIRA: https://issues.redhat.com/browse/OPENJDK-2024

As of 4adca3fd57649e468bb81e3c6a1a5cb8026a25a6, s2i build fails. Log excerpt:
...
I1025 13:56:05.972669  215353 sti.go:715] + source /opt/jboss/container/java/jlink/mkjreimage.sh
I1025 13:56:05.972709  215353 sti.go:715] ++ set -euo pipefail
I1025 13:56:05.972737  215353 sti.go:715] ++ outdir=spring-boot-jre
I1025 13:56:05.972745  215353 sti.go:715] ++ depsfile=module-deps.txt
I1025 13:56:05.972759  215353 sti.go:715] ++ test -f module-deps.txt
...

I think this is line 8 in mkjredeps.sh
https://github.com/jboss-container-images/openjdk/pull/401/files#diff-94057b4d12f8fe7edf547630e56e2dba5a4005043a5c1b46ca859ae0ea00950bR8

Great stuff, all my comments addressed!
As of 0812d30, the S2I build fails (at a later stage to last time):
I1101 10:51:13.890717  615424 sti.go:715] /opt/jboss/container/java/jlink/mkdeps.sh: line 21: JAVA_APP_JAR: unbound variable

Fixing this properly will take a bit of thought: JAVA_APP_JAR is currently undocumented, and otherwise only referenced in the run-java.sh script, and there is (almost) no scripts/shell libraries in common between the S2I assemble and the run script. I'll talk about that in more detail on our call. For now, I'm going to explicitly define it the environment during testing.


Why should I invest in a technology when one of the most crucial part (the WEB UI) is not open source?

I'm submitting a ...  (check one with "x")
[] bug report => search github for a similar issue or PR before submitting
[] feature request
[] support request
[X] general question

Current behavior (how does the issue manifest):
Expected behavior:
Open Source the WEB UI to fulfill your marketing statements (fully open source & visual creation)
Minimal steps to reproduce the problem (not required if feature enhancement):
What is the motivation / use case for changing the behavior?
Otherwise the project is no really a open source project.
Please tell us about your environment (Operating system, docker version, browser & web ui version, etc):
Flogo version (CLI & contrib/lib. If unknown, leave empty or state unknown): 0.X.X
Additional information you deem important (e.g. issue happens only occasionally):

Thanks @volkrass for the question. Flogo is much more than just a web-based dev environment. In fact, I would say Flogo is absolutely not a web-based dev platform, Flogo is truly an event driven framework. All of the framework code, such as the process engine, activity and trigger contributions, etc are all available as open source.
The web development environment is essentially just an app that is only used to visual model the application JSON. The application JSON is then compiled using the open source cli against the open source flogo-lib & flogo-contrib repos.
I hope that helps answer your question.

I have the same issue - ideally the web ui would be open-sourced, too. Are there any plans to do this?

Hi @hansamann, Yes we do have plans to open source the UI.

@mellistibco are there any updates on this?

Hi @SvenDowideit thanks for checking in on the status. We're targeting first or 2nd week of March to open up the web ui repo. I'll keep you posted.

Ok, that is awesome news!

Looking forward to checking it out as well. Is the plan still to open source the UI in the next week or two?

@vinodc it sure is, we're just working through a few last bugs, etc and we'll open source it along with the latest release of the core.

Hi all, the flogo web-ui has been open sources! Check out the source here: http://github.com/TIBCOSoftware/flogo-web


User guide: intro to the catalogue

https://github.com/ministryofjustice/data-catalogue-user-guide/pull/7


StrictExtends is laxer than Extends

Hi, I was trying to use the Extends types (see https://github.com/mmkal/expect-type/issues/36) and ran into some unexpected behavior with StrictExtends.
My understanding is strict extension should be a subset of normal extension. That is to say, there should be no cases where a type strict extends another type, but does not traditionally extend it. If that is not the case, I would greatly appreciate some explanation on what these edge cases are.
Example:
type A = (args: string) => 5;
type B = (args: string | number) => number;

type doesExtend = A extends B ? true : false;
// doesExtend = false
// A cannot extend B because the parameters are too strict

expectTypeOf<
    Extends<A, B>
>().toEqualTypeOf<false>(); // Correct / expected

expectTypeOf<
    StrictExtends<A, B>
>().toEqualTypeOf<true>(); // Incorrect / unexpected?

My understanding is that is caused by this line: https://github.com/mmkal/expect-type/blob/main/src/index.ts#L43C11
It spreads the params + return equally.
extends of methods is a bit counter intuitive.
In order for method A to extend B:

A's return type must be "stricter" than B's (ReturnType<A> extends ReturnType<B>)

This is handled correctly (as far as I can tell)

A's parameters must be "laxer" than B's (Parameters<B> extends Parameters<A>)

This is not handled correctly

I agree. The logic is a little fuzzy when it comes to functions - this was initially conceived more as a checker for plain objects and performs best with those, but I would like to cover as many edge cases as possible. It might require some careful thought and design though. I am maintaining this library in bursts, and I am a forgetful person, so would you mind opening up a PR containing a failing test to illustrate this point unambiguously (and more importantly - permanently, since the test can remain in the git history once it's made to pass)?

Having said that, it's beyond the scope of this library to provide a carefully-designed utility type library. I'll be adding a note to the docs warning about this in #16 to close this issue. That PR also renames StrictExtends to more accurately reflect what it does. But there may well be a "real" bug that corresponds to this problem which surfaces through the official API (the .toBe... methods). If you find it please feel free to open a new issue framed that way @JacobLey.


New lines not converted on output

I'd like to be able to print a multiline string, but even when changing the multiline setting, awesome_print prints a literal "\n" rather than issuing a new line.  Here's a pry session illustrating what I mean:
[2] pry(main)> ap "a\nb", multiline: false
"a\nb"
=> nil

[3] pry(main)> ap "a\nb", multiline: true
"a\nb"

[4] pry(main)> puts "a\nb"
a
b

Is there a way to get it to do the new line instead of '\n'?

:+1: -- I've been banging my head against a wall trying to figure out how to get this to work.

Here's a method that would kind of work around it, except that it puts quotes around every line, and you'd have to monkey patch Kernel.ai:
 def apx(obj)
  obj.is_a?(String) ? puts(obj.split("\n").map(&:ai).join("\n")) : ap obj
end

# apx("a\b") =>
"a"
"b"


Invariant Violation: [React Intl] Could not find required intl object.  needs to exist in the component ancestry.

Side note: the links on Bug and Feature in the template are 404.

[X] Bug (https://github.com/react-boilerplate/react-boilerplate/blob/master/.github/CONTRIBUTING.md#bug-reports)
[X] Feature (https://github.com/react-boilerplate/react-boilerplate/blob/master/.github/CONTRIBUTING.md#feature-requests)

Description
I think this is actually a bug because the boilerplate features should be compatible, but the fix is likely a feature request. As far as I can gather, Enzyme's render and React-Intl don't play well together, resulting in the error in the title. I found corroboration, discussion, and workarounds here:
https://stackoverflow.com/questions/36866363/testing-react-intl-components-with-enzyme
and here:
https://gist.github.com/mirague/c05f4da0d781a9b339b501f1d5d33c37
It would be great if this (or another) workaround could be part of the boilerplate so that enzyme rendering of components with FormattedMessage elements will succeed without having to choose between partially-tested workarounds found on the web.
Steps to reproduce
This is trivial to repro. Just use 'render' instead of 'shallow' in any component with FormattedMessages. I was very surprised not to find an issue with this, but perhaps everyone who hits it is just using one of the workarounds at the links above? Is there a better solution?

Clone react-boilerplate, setup, clean, etc.
In containers/HomePage/tests/index.test.js, replace 'shallow' with 'render' (or copy/paste from here)

import React from 'react';
import { FormattedMessage } from 'react-intl';
import { render } from 'enzyme';

import HomePage from '../index';
import messages from '../messages';

describe('<HomePage />', () => {
  it('should render the page message', () => {
    const renderedComponent = render(<HomePage />);
    expect(
      renderedComponent.contains(<FormattedMessage {...messages.header} />)
    ).toEqual(true);
  });
});

yarn test

result:
FAIL  app/containers/HomePage/tests/index.test.js
  ● <HomePage /> › should render the page message

    Invariant Violation: [React Intl] Could not find required `intl` object. <IntlProvider> needs to exist in the component ancestry.

      at invariant (node_modules/invariant/invariant.js:42:15)
      at invariantIntlContext (node_modules/react-intl/lib/index.js:357:5)
      at new FormattedMessage (node_modules/react-intl/lib/index.js:1409:9)
      at node_modules/react-dom/lib/ReactCompositeComponent.js:294:18
      at measureLifeCyclePerf (node_modules/react-dom/lib/ReactCompositeComponent.js:75:12)
      at ReactCompositeComponentWrapper._constructComponentWithoutOwner (node_modules/react-dom/lib/ReactCompositeComponent.js:293:16)
      at ReactCompositeComponentWrapper._constructComponent (node_modules/react-dom/lib/ReactCompositeComponent.js:279:21)
      at ReactCompositeComponentWrapper.mountComponent (node_modules/react-dom/lib/ReactCompositeComponent.js:187:21)
      at Object.mountComponent (node_modules/react-dom/lib/ReactReconciler.js:45:35)
      at ReactDOMComponent.mountChildren (node_modules/react-dom/lib/ReactMultiChild.js:236:44)
      at ReactDOMComponent._createContentMarkup (node_modules/react-dom/lib/ReactDOMComponent.js:659:32)
      at ReactDOMComponent.mountComponent (node_modules/react-dom/lib/ReactDOMComponent.js:526:29)
      at Object.mountComponent (node_modules/react-dom/lib/ReactReconciler.js:45:35)
      at ReactCompositeComponentWrapper.performInitialMount (node_modules/react-dom/lib/ReactCompositeComponent.js:370:34)
      at ReactCompositeComponentWrapper.mountComponent (node_modules/react-dom/lib/ReactCompositeComponent.js:257:21)
      at Object.mountComponent (node_modules/react-dom/lib/ReactReconciler.js:45:35)
      at node_modules/react-dom/lib/ReactServerRendering.js:45:36
      at ReactServerRenderingTransaction.perform (node_modules/react-dom/lib/Transaction.js:143:20)
      at renderToStringImpl (node_modules/react-dom/lib/ReactServerRendering.js:43:24)
      at renderToStaticMarkup (node_modules/react-dom/lib/ReactServerRendering.js:83:10)
      at render (node_modules/enzyme/build/render.js:91:52)
      at Object.<anonymous> (app/containers/HomePage/tests/index.test.js:10:48)
      at Promise.resolve.then.el (node_modules/p-map/index.js:42:16)
      at process._tickCallback (internal/process/next_tick.js:109:7)

Versions

React-Boilerplate (see package.json): 3.5.0
Node/NPM: 5.6.0
Browser: N/A (but Version 65.0.3325.181 (Official Build) (64-bit))

I see now that this is documented on react-intl's github. Would be nice to at least add a link and brief description of the workaround to react-boilerplate's troubleshooting page, since anyone writing interesting tests is likely to hit it.
https://github.com/yahoo/react-intl/wiki/Testing-with-React-Intl#enzyme
https://medium.com/@sapegin/testing-react-intl-components-with-jest-and-enzyme-f9d43d9c923e

I see also that the sample app uses , which works for mount but does not appear to work for render.

I came across one more solution: enzyme-react-intl. Not sure whether it does anything more than <IntlProvider>.
https://github.com/joetidee/enzyme-react-intl


"Mar 3" > 3/3/2018 (current year-good!) BUT... "Mar-3" > 3/3/2001 (bug)

Love sugar! We are using it on TeamworkIQ.com. Our users love it too.
However, our users found a bug... and I verified the bug this morning using https://sugarjs.com/docs/#/DateParsing
If you parse the date phrase "Mar 3" you'll get March 3 of 2018, the current year. That's good!
Same is true for "3 Mar"
However...
If you use the date phrase "Mar-3" ( with a - dash ) you'll get March 3 of 2001. That's a bug.
Same bug is true for "3-Mar".
Seems for the format "dd-mmm" and mmm-dd" return the wrong year. Seems they should behave the same as other phrases which omit a declared year ... and in that case by default the parser returns the current year (unless other SugarJS configs instruct SugarJS to do otherwise).
Thanks. Let us know if there's any way we can help further with the resolution of this bug.

Thanks for this! I'll have a look into it but at first glance this looks like a case of Sugar not recognizing the format and falling back to native date parsing. For the next version I'm considering not doing this as I get a fair number of tickets where this is unexpected. This in fact may be a Sugar bug and I'll look into it as such, but what do you think about the idea of not falling back to native Date parsing?

I'm not sure of the impact of NOT falling back to native date parsing. SugarJS covers so many cases, I'm unsure which would fail if you did that and as such an not well prepared to offer an opinion.
However, you could... add a flag to the returned result when native date parsing IS used. This at least could let your users know, and if desired, take action to double check accuracy.

I think the impact of not falling back would essentially be minimal for English, however other locales may be more affected where I'm not as confident in the format coverage.
In any case, thanks for the feedback! Will be thinking about it.


Race condition in project system

Sometimes all projects are stuck in the "not yet loaded" status. Solved by the reloading the window

Fixed by 58c14ebcd0ff02256aa67aa4a75b0d1c4f59ae65

I don't understand the fix

It look like it would break clearLoadedProjects as the emptyProjectsMap dictionary isn't empty once mutated
It doesn't look like it would change anything, javascript being single threaded the code before/after should be equivalent

It's been a while since I done this change... but as far as I remember there were some impactful differences in JS code.  /shrug


Add multixact test reproducing the problem with duplicates caused by incorrect opffset calculation

Problem
See #4774
Summary of changes
Checklist before requesting a review

[ ] I have performed a self-review of my code.
[ ] If it is a core feature, I have added thorough tests.
[ ] Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
[ ] If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

[ ] Do not forget to reformat commit message to not include the above checklist

Thanks! At a quick glance, this seems pretty redundant with the test we have. This does multiple UPDATEs in parallel, from multiple threads, so that might uncover some Postgres bugs.
I don't think we need this, but I'm also not going to say no to having more tests, assuming this test runs fairly quickly. :-)

Thanks! At a quick glance, this seems pretty redundant with the test we have. This does multiple UPDATEs in parallel, from multiple threads, so that might uncover some Postgres bugs.
I don't think we need this, but I'm also not going to say no to having more tests, assuming this test runs fairly quickly. :-)

+1
Actually it was one more mishit from my side: trying to reproduce there problem I quite soo get this error (content of restored database doesn't match with the original database), but I incorrectly interpret it - I just thought that multixacts were  not correctly saved.


Get Security Group in public command output

The public command returns the following details for each EC2/ELB instance:

account
arn
hostname
ports
type

It would be great if the SG affecting the instance was also included, in order to aid in remediation.

This is resolved in #140
The output will now look like this:
{
    "account": "demo",
    "arn": "arn:aws:ec2:us-east-1:000000000000:instance/webalb/subnet-00000002",
    "hostname": "webalb",
    "ports": "443",
    "public_sgs": [
        "sg-00000003"
    ],
    "type": "elb"
}

where public_sgs is an array of all of the security groups making the ports public.  Unfortunately, it does not associate which Security Group is allowing which port range.

thanks Scott, this will be quite useful!


Update status.sh

Adding ETA (countdown to full sync) functionality, I did it for myself and I submit it for review in case you want to integrate the functionality in the official scripts. Also made a few consistency changes here and there.

@hauni97 Could you take a look?

Is it still valuable to merge? @hauni97

Is it still valuable to merge? @hauni97

Currently not. Let me know if I can close this PR @h4x3rotab for now.


Teeworlds.game version 0.7.5

[ ] Have you signed the Contributor License Agreement?
[ ] Have you checked that there aren't other open pull requests for the same manifest update/change?
[ ] This PR only modifies one (1) manifest
[ ] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.4 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

Hi @Twig6943,
The application installed normally, but the client gave an error instead of launching:

[2023-03-27 13:50:27][console]: failed to open 'autoexec.cfg'

Is there a command to generate this file?


Missing include when compiling with MSVC 2022

I made a small fix for a missing include when compiling with MSVC 2022 (at line 56 there is assert(innerOsqpPosition == numberOfNonZeroCoeff); which requires <cassert> header).

Thanks @enricodetoma, this is indeed a usual fix on other platforms to "include what you use". fyi @GiulioRomualdi

This will fix https://github.com/robotology/osqp-eigen/issues/141 .
@S-Dafarra @GiulioRomualdi can we merge this?


Enforce UI Version on Route Change

Related Issue or Background Info

Resolves #1785

Changes Proposed

Adds a VersionEnforcer component and sibling VersionService, to enforce that the UI is up to date with the latest SHA on page navigation
Updates the CDN settings to bypass caching for index.html and commit.txt. This will need to be configured in Akamai when we migrate there from from Azure CDN, but this is important for now

Additional Information

In order to avoid the caching reload loop of death, we also store the Date of the last reload in localStorage, and won't even bother trying to fetch the remote SHA if we've done so within the last 15 minutes.

Reviewer notes

@jdorothy Will you confirm that my CDN rule & Terraform make sense? I added this to resolve the caching comment from Nick Scialli on my previous PR for this issue
@nathancrtr General review pls!
@emmastephenson We've got a bunch of folks on vaca, so I'm just pinging you for extra eyes 🙏

Checklist for Author and Reviewer
UI

[x] Any changes to the UI/UX are approved by design
[x] Any new or updated content (e.g. error messages) are approved by design

Testing

[x] Includes a summary of what a code reviewer should verify

Changes are Backwards Compatible

[x] Database changes are submitted as a separate PR

[x] Any new tables that do not contain PII are accompanied by a GRANT SELECT to the no-PHI user
[x] Any changes to tables that have custom no-PHI views are accompanied by changes to those views
(including re-granting permission to the no-PHI user if need be)
[x] Liquibase rollback has been tested locally using ./gradlew liquibaseRollbackSQL or liquibaseRollback

[x] GraphQL schema changes are backward compatible with older version of the front-end

Security

[x] Changes with security implications have been approved by a security engineer (changes to  authentication, encryption, handling of PII, etc.)
[x] Any dependencies introduced have been vetted and discussed

Cloud

[x] DevOps team has been notified if PR requires ops support
[x] If there are changes that cannot be tested locally, this has been deployed to our Azure test environment for verification

@ronaldheft-usds

Updates the CDN settings to bypass caching for index.html and commit.txt. This will need to be configured in Akamai when we migrate there from from Azure CDN, but this is important for now


remove stray apostrophe 🤓

See https://english.stackexchange.com/questions/22603/why-doesnt-its-have-an-apostrophe

oops! i know the rules :)


Sharing two taobao-pkg, including one from @LadyHack which I believe quite elegant

Hi, I managed to get two pkg files from TaoBao, I think the one from @LadyHack is quite elegant and well-designed. You could surely get my point from this picture.

I have uploaded these to DropBox
Hope it could help you guys. But I must be clear, @LadyHack sell her service at taobao.com for about 1500RMB，I do not have her permission for reverse-engineering, and I don't even need to ask because it will certainly be a waste of time.
Others might want to explore some eink-friendly app, aslo from @LadyHack. I feel a little guilty but I think she have earned herself a great deal already.

This is actually a very neat thing to have: one button for a customized app launcher rather than modifying the official launcher, one button for setting, and finally one button for file management
I like this.

Anyway to unpack the pkg? it says encrypted.

@xiyuemu   good job !!!   thanks for your sharing,      did you flashed the pkg ?    if i flash the pkg into dpt-rp1  ,  it  will need i input the verify code ,   in other words   the pkg is protected    ?

@xiyuemu good job !!! thanks for your sharing, did you flashed the pkg ? if i flash the pkg into dpt-rp1 , it will need i input the verify code , in other words the pkg is protected ?

 She is probably selling this as a job, got every reason to protect the profit.

@xiyuemu could u just dump the whole system image? boot.img&system.img, thx.

@xiyuemu could u just dump the whole system image? boot.img&system.img, thx.
seckkit#gmail#com

sorry, you may wait for someone else, because I have flashed back to the official firmware.

close this to not mislead users to flash these
they did have online tracking to validate if you bought their services
study purpose only


DR-HTF001S in Homebridge  switches don't give context

I was able to get my dreo fan added to Home Assistant as well as get it added to homekit using the built-in home assistant bridge. However when I view the fan entity in Apple Home it shows the fan itself but also four additional switches. These switches appear to correlate with the different fan modes as flipping a switch does change the fan mode on the actual fan itself, but there's not indication on what mode the switch is applied to.

Is there a way to fix this within in dreo application on how these modes are supported or is this an issue with Homebridge or a limitation with fans on homekit?

I went ahead and also open an issue with homebridge as well. https://github.com/zyonse/homebridge-dreo/issues/51

you probably need to open an issue with the HA HomeKit integration.


Fix Spacing in GitHub Token Scope Descriptions

Why:
This adds a missing space in an example
Closes:
None
What's being changed (if available, include any code snippets, screenshots, or gifs):
It adds a space
Check off the following:

[x] I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).

For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.

[x] For content changes, I have completed the self-review checklist.

@George-lewis Thanks so much for opening a PR with this fix! I'll get this merged 🍏


Add Fluid_Remain for DAB Esybox Diver

Is your feature request related to a problem? Please describe.
I have an Diver and the fluid add-on
https://www.completepumpsupplies.co.uk/dab-nfc-water-level-sensor-for-e-sybox-diver
Describe the solution you'd like
Get the sensor for that.
Describe alternatives you've considered
./.
Additional context
here is the JSON-Output for the Fluid_Remain...
Maybe there are more sensors missing. You said something about usind installation.json in the other issue, I am not sure if it will fix this.
"res": "OK",
"result": "OK",
"status_validity": 15,
"statusts": "2023-12-23T18:47:41.808Z",
"lastreceived": "2023-12-23T18:47:41.812Z",
"refresh": 2000,
"servertime":<PHONE_NUMBER>332,
"status": "{"AE_AntiLock":"1","AF_AntiFreeze":"1","AY_AntiCycling":"1","Actual_Period_Energy_Counter":"55","Actual_Period_Flow_Counter":"3142","Actual_Period_Flow_Counter_Gall":"h","C1_PumpPhaseCurrent":"0","Error1":"0","Error2":"0","Error3":"0","Error4":"0","Error5":"0","Error6":"0","Error7":"0","Error8":"0","ErrorTime1":"0","ErrorTime2":"0","ErrorTime3":"0","ErrorTime4":"0","ErrorTime5":"0","ErrorTime6":"0","ErrorTime7":"0","ErrorTime8":"0","FirmwareStatus":"1","FloatEnable":"0","FloatSwitchStatus":"255","FluidLevel":"1058","Fluid_Remain":"6052","Fluid_Remain_inch":"h","ForceDownload":"0","GI_IntegralGainElasticPlant":"h","GI_IntegralGainRigidPlant":"11","GP_ProportionalGainElasticPlant":"h","GP_ProportionalGainRigidPlant":"5","HO_PowerOnHours":"21458","HO_PumpRunHours":"452","HvBoardId":"8","HvFwVersion":"1.0.4","Last_Period_Energy_Counter":"21","Last_Period_Flow_Counter":"2294","Last_Period_Flow_Counter_Gall":"h","LvFwVersion":"1.4.29","OD_PlantType":"1","PO_InputPower":"0","PowerShowerBoost":"20","PowerShowerCommand":"0","PowerShowerCountdown":"h","PowerShowerDuration":"1800","PowerShowerPressureBar":"48","PowerShowerPressurePsi":"h","PressureTarget":"h","ProductType":"101","PumpDisable":"0","PumpStatus":"0","PumpStatusTime":"1703354414","RM_MaximumSpeed":"5200","RP_PressureFallToRestartBar":"10","RP_PressureFallToRestartPsi":"h","RS_RotatingSpeed":"0","SP_SetpointPressureBar":"40","SP_SetpointPressurePsi":"h","SV_SupplyVoltage":"236","Saving":"55","SleepModeCountdown":"h","SleepModeDuration":"25200","SleepModeEnable":"0","SleepModePressureBar":"28","SleepModePressurePsi":"h","SleepModeReduction":"30","SleepModeStartTime":"82800","StartNumber":"41822","SystemStatus":"0","T2_SwitchOffDelay":"8","TB_DryRunDetectTime":"30","TE_HeatsinkTemperatureC":"14","TankFill":"62","TankMinLev":"15","TankMinLev_inch":"h","Tank_L1_D1":"270","Tank_L1_D1_inch":"h","Tank_L2":"0","Tank_L2_inch":"h","UpdateFirmware":"h","UpdateProgress":"h","UpdateType":"0","VF_FlowGall":"h","VF_FlowLiter":"0","VP_PressureBar":"33","VP_PressurePsi":"h","FluidLevel_inch":"h"}"
}

Thank you for sending in this request, It is very helpfull for me to receive input from owners of pumps other than the one I have myself (a regular Esybox). Very motivating that the integration now seems to be working (mostly) fine for Esybox, Esybox.mini and Esybox.diver.
In your attached json I spot some more values I hadn't seen before in other pumps:

FloatEnable: 0
FloatSwitchStatus: 255
FluidLevel: 1058
FluidLevel_inch: 'h'   (<-- means not applicable for your pump)
Fluid_Remain: 6052
Fluid_Remain_inch: 'h'
TankFill: 62
TankMinLev: 15
TankMinLev_inch: 'h'
Tank_L1_D1: 270
Tank_L1_D1_inch: 'h'
Tank_L2: 0
Tank_L2_inch: 'h'

In order for me to add these properties I would need to know what unit of measurement (millimeters, meters, percentage) these values are in and what factor (i.e. divide by 10 or 1000) I need to apply.
Would it be possible for you to either:

open your DConnect webite or app, lookup how all of these values are presented there (or take a few screenshots) and report that back to me?

Or run the following script in a Home Assistant terminal window:

#!bash
data_usr='username=<dab portal username>'
data_pwd='password=<dab portal password'
login_htm=$(curl -j -c data/dab_cookie1.txt -k -s -L 'https://dconnect.dabpumps.com/')
login_url=$(echo "$login_htm" | grep -E -o 'action=(.*) method=' | sed -e 's/^.*action="//g' -e 's/" method=$//g' -e 's/&/\&/g')

login_res=$(curl -b data/dab_cookie1.txt -c data/dab_cookie1.txt -k -s -L $login_url -H 'Content-Type: application/x-www-form-urlencoded' --data-urlencode $data_usr --data-urlencode $data_pwd)
data_inst=$(curl -b data/dab_cookie1.txt -c data/dab_cookie1.txt -k -s -L 'https://dconnect.dabpumps.com/api/v1/gui/installation/list?lang=en')

echo "$data_inst" | jq 'walk(if type=="string" and test("^{.*}$") then .|fromjson else . end)' > /config/dab_dconnect_installations.json

And then send the resulting dab_dconnect_installations.json to me (either as attachment to this change request, or via direct message)

I was not able to execute your script...
But I was able to download the "list?lang=en"-file with my browser and posted it here:
https://pastebin.com/JbNY7Z70

Perfect, that is indeed exactly the installations.json that I needed!
I've added all the sensors for the Diver Fluid add-on to the integration, will publish it as a new release v.2023.12.5 tomorrow.
Let me know it you find any issues/inconsistencies with it.

Great to hear! I will try it after you published the new version.

Release v2023.12.5 is now published.
And thank you for your kind donation via BuyMeACoffee!

You are welcome!
tried the new version, restarted HA, but the sensors are not showing up…
Removed the integration, added it again and logged on, still no change…

After another restart it worked...
I will check the sensors in the next hours...

It checked it now.
Abnormalities:

The sensor Actual period flow counter is in "L" vs. Previous month flow counter is in m³. They should have the same.
Sensor Saving is 0.55 and not 55%
Sensor Dry run detect time (TB) and Switch off delay (T2) are in seconds
for the new sensors: the sensor remaining water/fluid or "Fluid_Remain" is missing (must be > 3000 l). Could you add it?

Nothing more to report. Everything else worked the way it should.
Sebastian

Was able to fix the misisng Fluid_Remain.
The other three items already seem to be set to the correct unit in code. It is possible that your HA is just refusing to start using the new units because it already has historic values for the sensor in the old unit.
To resolve this:

Go to 'Developer Tools' and select the 'Statistics' tab.
I suspect there will be messages there stating something like 'The unit of this entity changed from x to y'.
Press the 'Fix Issue' button
Choose between the options 'Update the unit without converting' or 'Delete all old statistic data for this entry' and press 'Fix issue'
Probably use the second option since the integration has not yet been running long and there is not much statistic data yet.

Grat! Fluid_Remain is showing up!
I changed the unit code of the other sensors.


Add change routing profile worker

I've added a ChangeRoutingProfileWorker.

Closing this refactoring PR as we've discussed that we will create a single refactoring PR that will be reviewed as a whole.


Relay Integration

Has anyone tried using this with relay projects?

Hi Clie,
We use Apollo @ OVRSEA, but since we wrote this plugin, I think https://the-guild.dev/graphql/eslint/rules/no-unused-fields can be a good option aswell :)

Thanks ill give that a shot. I tried this plugin and it correctly plucked out all the fragments and queries but still got some false positives. Will dig deeper if I dont have luck with the unsed fields plugin


修改了自动化测试用例，删除了无用的encryptData

Coverage decreased (-0.006%) to 98.919% when pulling a000cb56d09c212857e9c1d361b488043d8b6ecb on liamhuang into dbbadefb37f9d432cfa16c0f0e8ad331b2e249b6 on master.

Coverage decreased (-0.006%) to 98.919% when pulling b2c20fbd91cd3d8d7512612c41245e6eadd19b04 on liamhuang into dbbadefb37f9d432cfa16c0f0e8ad331b2e249b6 on master.

https://github.com/tencentyun/weapp-client-sdk/pull/2


Add @nrwl/web:package

Added ability to release react lib

Thanks for your contribution @czaplej  - this is published in version 1.18.0


Propose a mechanism to remove/block users from a group

Propose a mechanism that allows for user removal or blocking within a group.

For the 'indexing blocked users' solution, who can report and who can moderate?
With NFT groups it seems like we have two sets of people: the creator of the NFT contract and holders of the NFT. If the contract or NFT collection is created through Mintbase, Paras, etc then the creator of the collection may not have access to the contract.

The Moderation features work along similar lines. They could probably be updated to handle groups, there's even a group field already for organizing reports and decisions.
https://near.org/dataplatform.near/widget/QueryApi.App?selectedIndexerPath=dataplatform.near/moderation

@gabehamilton Thank you for the feedback. As far as I understand only the owner can access the contract according to the Mintbase docs: https://docs.mintbase.xyz/creator/faq#what-is-a-mintbase-contract. However, the way this contract/account could be accessed (and if it can be accessed directly) should be investigated further - if it's possible to access a private key or whether the access is limited to Mintbase UI only.
Using moderation sounds very reasonable. Is it possible to set a moderator for a given account?


Added Tags From Serilog Log Event Properties

Added Tags for Each Property on LogEvent
Upgraded NuGet Packages to latest releases

Hi John - looks like some kind of merge conflict going on? Cheers!

Closing this one as stale


"Servicer.lvclass:Start Server.vi" returns error 1097 when proto file contains "Empty" message

"Servicer.lvclass:Start Server.vi" returns error 1097 when proto file contains "Empty" message.

Steps to reproduce:

Generate the test project with the following proto file:

syntax = "proto3";

package adas;

service TestService {
  rpc Funtion1 (Empty) returns (Empty) {}
  rpc Funtion2 (Empty) returns (Empty) {}
}

message Empty {
}

Execute "Run Service.vi" in the server lib and you will get an error 1097.

This issue has been fixed in the #134 and has been picked up by the <IP_ADDRESS> release.


Add support for team id

Add support for vercel team id
Update API endpoint
Wait 1 second on every poll to avoid rate limit

If your vercel project is created under a team account and your vercel api key is also authorized under a team scope, the deployment api will not return any result unless you explicitly add a team id parameter in the querystring.
Related docs: https://vercel.com/docs/rest-api#endpoints/deployments/get-a-deployment-by-id-or-url

Thanks for the feedback! I added some explanation on the top.

Thanks! I reviewed it, and besides keeping the v11 API version I don't see anything else to change.
Although you haven't explained the most important thing 😄 :

Could you explain your use case and how that PR allows you to do something you couldn't before? I would like to understand better what this new feature unlocks.

I've been using this action with my team for more than a year and we never needed this option, so I'm kind of lost about the "why" you need it. Maybe I missed something obvious?


How will you save the data of dataframe on Excel?

This is Tony Qu from NPOI team. NPOI is one of the major Office read/write library and it's open source and free to use.
I'm somewhat worrying about this feature as I mentioned in a discussion. I'd like to know how you will save the data of a dataframe on Excel. Will there be a cache of dataframe on local? If so, is there any data size limitation for this case?

Hey Tony and thanks for your work on NPOI!
We do not persist the dataframe into the Excel workbook; it is treated as transient data in the container. Only values explicitly returned to the grid by value are persisted into the workbook, i.e., you could "spill" your dataframe into the workbook subject to existing workbook limits.

you could "spill" your dataframe into the workbook subject to existing workbook limits.
Can you explain this in detail? It sounds it's users' choice to spill the dataframe into a sheet. And according to xlsx specification, there is almost no limitation for the row number. (For xls, it's 65535 for each sheet).

Does it mean there will be a potential risk of huge data in Excel? I totally understand python is very strong in big data area since I used to be a big data architect. But frankly speaking, I don't think xlsx file is a good container for big data because of the file format design (xml+zip). I prefer parquet format as the intermediate data transfer format because the format is more easy to read and can somewhat avoid OOM.
You know it's a bit annoying that a few developers are complaining that NPOI (or EPPlus) will be out of memory while they are putting thousounds of rows with at least 10-20 columns into a Excel sheet. It's always a nightmare for any Excel library.

There are two ways to return data to the grid - one is "by reference" which is the default where no data is marshaled to the grid. The other is "by value" where all the values in the object (e.g., DataFrame) are copied to the grid.
We anticipate that most data is returned by reference with only the "end result" being returned by value. I don't think users will typically be dumping giant amounts of data (doesn't mean they won't though ...) into the grid as it's not really useful to manually examine tons of data in the grid.

Sounds not too bad. Thank you for the detailed explanation.


Cake argument changes

This is just a preliminary PR related to some changes we'd like to make to the ICakeArguments interface. Feedback/better ideas are very much welcome.
Summary:

CakeArguments.HasArgument and CakeArguments.GetArgument both now String.Trim() their name parameter. This helps avoid difficult-to-spot bugs with using something like Argument<bool>("foo ", true);

Exposes an ICakeArguments.AsDictionary property as mentioned in #315

Adds ICakeArguments.DefinedArgumentNames and ICakeArgumetns.UnrecognizedArgumentNames to facilitate "throw on unrecognized arguments" input validation / safe-guard against typos at the command line

A couple of small doc string typos/updates

The impetus for these changes is the following Setup we've been using in one of our cake scripts:
var knownArgs = new HashSet<string>(StringComparer.OrdinalIgnoreCase);

private T Arg<T>(string argumentName)
{
    argumentName = argumentName.Trim();
    knownArgs.Add(argumentName);
    return Argument<T>(argumentName);
}

private T Arg<T>(string argumentName, T defaultValue)
{
    argumentName = argumentName.Trim();
    knownArgs.Add(argumentName);
    return Argument<T>(argumentName, defaultValue);
}

var target        = Arg<string>("target", "Default");
var cakeToolsPath = Arg<string>("cakeToolsPath");
var nugetSource   = Arg<string>("nugetSource");

// moar arguments...

Setup(cakeContext => {
    var builtInArguments = new [] { "verbosity" };
    var rawArguments = (IReadOnlyDictionary<string, string>)cakeContext.Arguments.GetType().GetProperty("Arguments").GetValue(cakeContext.Arguments);
    var unrecognizedArguments = rawArguments.Keys.Except(knownArgs.Concat(builtInArguments), StringComparer.OrdinalIgnoreCase).ToList();

    if (unrecognizedArguments.Any())
    {
        unrecognizedArguments.ForEach(arg => Error("'{0}' is not a recognized argument", arg));
        throw new InvalidOperationException("Unrecognized arguments!");
    }
});

If something like this PR were to land upstream, we could reduce that to something more like the following:
var target        = Argument<string>("target", "Default");
var cakeToolsPath = Argument<string>("cakeToolsPath");
var nugetSource   = Argument<string>("nugetSource");

// moar arguments...

Setup(cakeContext => {
    if (cakeContext.Arguments.UnrecognizedArgumentNames.Any())
    {
        cakeContext.Arguments.UnrecognizedArgumentNames.ForEach(arg => Error("'{0}' is not a recognized argument", arg));
        throw new InvalidOperationException("Unrecognized arguments!");
    }
});

If something like our "throw on unrecognized arguments" were a popular/useful feature, that could potentially be rolled into Cake's configuration as an option or possibly even be exposed via a method like ICakeArguments.ThrowIfUnrecognizedArgumentsPresent()

Hi @dbertram, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla2.dotnetfoundation.org.

TTYL, DNFBOT;

@dbertram, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.
Thanks, DNFBOT;

@dbertram just wanted to touch base on this one.  It hasn't been forgotten about, just that there are quite a few changes happening to Cake just now, i.e. porting to CoreClr.  When that happens, I think we might be in a position to look at this one.  Thanks!

@dbertram are you in a position to revisit this PR?

@dbertram we've discussed internally and unfortunately don't think this is something we at this time would can to pull into core.
I'm truly sorry for the late feedback and regardless we appreciate your time, effort and contribution to the project.

@devlead Is it the idea of exposing the defined/undefined arguments entirely, or just the approach taken in this PR that's not in line with core?
FWIW, I'm totally ok with coming at this from a different angle. We were just seeing a fair number of fat-fingered errors related to argument parsing (both in code and at the command line) that we wanted to try and avoid.
As outlined in my initial comment for this PR, if this isn't something that makes sense to fold into core, we've got a reasonable workaround in place.


surface thermo state calculation

The way to compute surface density, and thus thermo state needs to be fixed. See the recent PR in ClimaAtmos.

in fact, may not be a problem once the SurfaceFluxes calculation is fixed here


Axeman is only pulling from one log

Hi I have set up Axeman on a Google Compute Engine machine running Ubuntu 16.04 LTS server. When I run the program:
axeman -c 16
The program downloads 32GB of data from https://ct.googleapis.com/logs/argon2019/ct/v1 and haults.
If I try to download a specific log:
Axeman -c 16 -u ‘https://ct.googleapis.com/logs/argon2019/ct/v1‘
The program outputs
[INFO:root] - the current time - Starting...
Although no files are downloaded and the console allows input as if the program didn’t begin properly.

Hey sorry for the delay here, I don't have time to check into this, but if you wanted to submit a PR to remedy that'd be great!

Hey @hailnick, it looks like the format must match the one returned by the CTL list (-l)
> python3 -m axeman.core -l
Found 48 CTLs...
Google 'Argon2019' log
    \- URL:            ct.googleapis.com/logs/argon2019
    \- Owner:          Google
    \- Cert Count:     854,510,771
    \- Max Block Size: 128
...

So passing ct.googleapis.com/logs/argon2019 will do the job.
> python3 -m axeman.core -u ct.googleapis.com/logs/argon2019
[INFO:root] 2019-11-05 21:34:13,495 - Starting...
[INFO:root] 2019-11-05 21:34:13,614 - Downloading certificates for Google 'Argon2019' log
...


Download stops

Udeler | Udemy Course Downloader
1.11.04
Running as Business Account

[ ] Yes

Steps to reproduce
My download with Udeler stops after a while even though the course is not completed and it shows the download speed as 0.00 KB. When I close and open the program, 1 video downloads again and the download stops again. There is no continuity.
✔ Expected Behavior
No response
❌ Actual Behavior
No response

Can you tell me which course?


update categories and domains for task181-199

Looks like the PR is failing @ghlai9665

Looks like the PR is failing @ghlai9665

yes. Expecting to consolidate and merging #593 before fixing this one.

Looks like the PR is failing @ghlai9665

yes. Expecting to consolidate and merging #593 before fixing this one.

done now @ghlai9665


Fixes#588 popper --parallel for HostRunner

Fixes popper run --parallel for HostRunner .

@ivotron Please have a look

@ivotron Please have a look.

Hello @JayjeetAtGithub! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file cli/popper/gha.py:

Line 618:80: E501 line too long (80 > 79 characters)

@ivotron Fixed the bug for python3.7 but couldn't understand what to do for python2.7. #589 has to be solved before.

@ivotron Modified interrupt tests for --parallel to run in only python3.7 and the build passes now. Please check the approach in fixing the --parallel for HostRunner.

awesome, thanks a lot! Can we add a check for the version of python in cmd_run and, if --parallel is passed, we show a message like --parallel is only supported on Python 3 and exit?

ya sure

@ivotron Made the changes

thanks a lot @JayjeetAtGithub !


Manual install docker environment

From my understanding in manual home assistant docker environement this addon wont run.
Even if I setup a docker container next to home assistant - I have no way of calling the service, correct? at least I do not see the hassio.addon_stdin service in my installation-
Do you know of any custom component which has the same ability as your addon?

Got it to run with local config and some changes to the run.sh script.
However I know get this:
20:21:56.216            pjsua_acc.c  ...SIP registration failed, status=408 (Request Timeout)
20:21:56.216            pjsua_acc.c  ...Scheduling re-registration retry for acc 0 in 304 seconds..
| 20:21:56.217729 [1] OnRegState: 408 Request Timeout
I am trying to connect to a fritz.box. Network of the container is set to host. Softphone within the fritz.box with the name homeassistant. Not sure what I am doing wrong here.

You mixed up the SIP1_ID_URI and SIP1_REGISTRAR_URI:
SIP1_ENABLED = "True"
SIP1_ID_URI =<EMAIL_ADDRESS>SIP1_REGISTRAR_URI = "sip:fritz.box"
SIP1_REALM = "fritz.box"
SIP1_USER_NAME = "homeassistant"
SIP1_ANSWER_MODE = "LISTEN"
SIP1_PASSWORD = "password"
SIP1_SETTLE_TIME = "1"
SIP1_INCOMING_CALL_FILE = ""

🤦 - it works! 😅 Thx, for the heads up and sorry about bothering.... was able to make a call to my phone!


Operator support for HA deployments

Problem
We are currently working on making knative controllers able to do leader-elected HA
Persona:
People using the operator to deploy serving (and possibly other parts of the project if we unify the operators), who are making decisions about how they want their knative deployment configured.
Exit Criteria
I should be able to indicate via the operator's CR that I want:

Leader election disabled / enabled
Number of replicas for controllers that scale horizontally
Possibly anti-affinity
Possibly disruption budgets

Time Estimate (optional):
Probably more dependent on design consensus than implementation time.

@pmorie
Can we resolve this ticket as following PRs are all merged, or is there anything missing?
https://github.com/knative/serving-operator/pull/321
https://github.com/knative/serving-operator/pull/326
https://github.com/knative/serving-operator/pull/337


Update Go version to 1.21 from 1.19

Changes in this PR

Update Go version to 1.21 from 1.19.
Replace IsExtensionExcluded with slices.Contains
Update go versions in workflow and Dockerfile

resolves #36

Merged! Thank you @sandyydk for the contribution 💯


Unable to retreive compute result in C2D flow

Describe the bug
Using ocean.py 0.8.5

Above error appears in last step in C2D-flow.
To Reproduce
Steps to reproduce the behavior:

Go to https://github.com/oceanprotocol/ocean.py/blob/main/READMEs/c2d-flow.md
Follow all the steps.
See error at last step.

Expected behavior
No error
Screenshots
Already provided
Other References

https://github.com/akshay-ap/ocean.py-playground/blob/main/5.C2D.ipynb
https://github.com/AlgoveraAI/generative-art/blob/main/notebooks/3-C2D-flow-ocean.ipynb

As described here: https://oceanprotocol.slack.com/archives/C01PJ00QE2V/p1638791410261800
Summary:
This problem occurs in the test environments (using the stable operator environment: https://nextv.operator.oceanprotocol.com//api/v1/operator/getResult ) but not locally with barge. This problem will be solved once we deploy the latest cluster of C2D in the production environment but before this issue needs to be fixed: https://github.com/oceanprotocol/market/issues/853
Explanation:
The ocean.compute.result_file(DATA_did, job_id, 0, bob_wallet) is implicitly calling through provider the operator service enpoint get_config().operator_service_url + "/api/v1/operator/getResult" and getResult is only deployed in https://c2d-dev.operator.oceanprotocol.com//api/v1/operator/getResult  (https://github.com/oceanprotocol/provider/blob/main/tox.ini#L18)
Before the operator updates are merged to the production environment, this issue needs to be solved: https://github.com/oceanprotocol/market/issues/853

@maldo-ctrl thanks for the update. We have our own operator service defined here which is giving the error: https://gpu01.dataunion.app/
May I know what version of operator service should be used to fix this error?


Include django-clite, a CLI for Django projects

This is a CLI tool built to help manage Django projects. It can automate lots of repetitive tasks like generating new models, test cases, working with DRF. It also does add some other miscellaneous features like configuring the project to run on Docker, exporting environment variables into example environment files and more.
Here's a link to the documentation.
Hope you find it useful as much as I do.
Cheers!

Hi @oleoneto , Thanks for the PR! Looks like a very interesting package but I'm going to wait until it has a little more usage before adding. Best, Will


nested paths should trigger default path from upstream

actual
When a child router fails and no default path is set, it throws an error.
expected
When a child router fails, and no default path is set, it triggers the parent's default path.

Becomes possible once #27 is merged.


Add Haxe Programming language with official website in README

Please, get the last version of code before to make your contribution.

Oh my mistake sorry, I will do it


Apps Script Connectivity

Build out some tooling for pushing and pulling scripts.

Not clear whether you'd prefer to leave this issue open, to potentially incorporate the Martin Hawksey stuff and/or Bruce McPherson's gasgit stuff, or whether you'd like me to close it.

I was hoping you would implement anything that needed doing.

  I've taken at least two, and perhaps three, runs at it and haven't met with success.  But we can leave it open and assigned only to me, if you want.  Or I can close it.

But we can leave it open and assigned only to me, if you want.

Yeah let's not lose it. But no milestone assigned.


Feat ct dockets updates

Unretired scripts on Remove_CT_ODS_Duplicates
Updated CT_Dockets scipts by removing the ODS_Logs insert from all relevant scripts

@NewtonMutugi, I see the change is on a lot of files. Maybe you can give a bit more context on the PR description to enable the reviewers have better context when reviewing.

@nobert-mumo here is a more detailed explanation of what the PR is changing:

Moving ODS/CT_DOCKET/Remove_CT_ODS_Duplicates/Retired scripts from Retired directory to the Remove_CT_ODS_Duplicates director above it.
Removed the ODS_Logs insert statements from the CT_Dockets since they are redundant

I hope this is clearer, though @DennisGibz can provide any further clarification

@nobert-mumo we had enhanced the ODS scripts specifically the C&T ones to be prone of fetching duplicates and then retiring the scripts that remove duplicates just to improve on the ETL runtime.
However, I noted the following, we have some duplicates as a result on running the data cleaning and standardizing scripts.
So the script is just rolling back the previously made changes that we will always have the script to remove duplicates from ODS.


Should PCNT undue GPIO_MODE_INPUT_OUTPUT??? (IDFGH-11314)

Answers checklist.

[X] I have read the documentation ESP-IDF Programming Guide and the issue is not addressed there.
[X] I have updated my IDF branch (master or release) to the latest version and checked that the issue is present there.
[X] I have searched the issue tracker for a similar issue and not found a similar issue.

General issue report
I have a possibly unique need. I'm trying to control a stepper motor and I want automatic pulse counting. So, I've set the STEP and DIR pins for the stepper motor to GPIO_MODE_INPUT_OUTPUT so that I can also direct those signals internally to the pulse counter.
But when I create the pulse counter it automatically sets the pins to JUST GPIO_MODE_INPUT.
I think the logic should not change the OUTPUT status, at best it should only add INPUT capability.
The RMT channel creation does the same thing.
I wasn't happy to have my settings for GPIO direction automatically changed. I would rather have the devices not function correctly and leave the pin direction to myself.

You may want to enable the io_loop_back flag in the driver configuration. Same for the RMT driver.
https://docs.espressif.com/projects/esp-idf/en/latest/esp32/api-reference/peripherals/pcnt.html#_CPPv4N18pcnt_chan_config_t12io_loop_backE


Add entries to MapBuilder to return both key and value array builders

Which issue does this PR close?

Closes #.
Rationale for this change

MapBuilder provides keys and values functions to get key and value array builders of map separately. As it is mutable borrow of the map builder, when we want to set keys and values in a loop like:
let key_builder = builder.keys();
let value_builder = builder.values();

let keys = ...;
let values = ...;

for idx in 0..keys.get_num_elements() {
    let key = keys.get(idx);
    let value = values.get(idx);

    key_builder.append_value(key);
    value_builder.append_value(value);
}

The compiler will complain error[E0499]: cannot borrow *builder as mutable more than once at a time.
Although there is workaround that is to get key and value builders inside the loop, no sure if it is efficient. More, especially we can have Box<dyn ArrayBuilder> as key and value builders now, it means that we need to downcast both key and value builders for each iteration in the loop.
This patch adds entries  API to MapBuilder that can get both key and value builders in one mutable borrow.
What changes are included in this PR?

Are there any user-facing changes?

Thank you @tustvold


Fix: set FEATURE_TESTS in debug linux test presets

Test presets not find the tests. enable_testing() is added when the FEATURE_TESTS is set.  After that,  when the test preset is run, the tests are found and run correctly.

@aminya If you think, it is good to enable tests for release build too, then I can add that.
Other option is to create presets with and without the variable FEATURE_TESTS, and test presets are linked to the presets with a flag on. What do you think?

I don't use the CMake presets personally. I use Taskfile.yml. If adding a new entry for the release builds with tests helps, feel free to make a PR.


fixup! Move Fleksy Engineering to company category

I also should have checked! I usually notice when they appear in the wrong section of my RSS reader and fix it up.
Thanks for the amendment!


Per-release mailing list report

TBD

@vinniefalco Should email content be copied over into the boost django DB?  Or just meta data about the email (who sent it, when, in what thread, mailinglist...)?

Since the db that contains the original mailman content is available, and in fact on the same db server where it can be queried, then content would not need to be copied over.    Even metadata about each and every email would be too much, and unneeded. Since a report should ultimately be "how many emails?"  perhaps "top posters", "top libraries".   Whatever the metrics are.
In all those cases, the original data can remain in the hyperkitty database.  Query that. By any metrics that are required. Store the interesting statistics in the boost.io db.

I can do it the way @sdarwin is describing, I would just need to know exactly what metrics we would like to store.
There are also stub views already in the repo for a MailingListView and a MailingListDetailView which seem to intend to display email threads directly on boost.  If that's the case, it may be easier to just copy the data into the boost database for this purpose?  Or should those views just be removed entirely.


Translate this repository into Persian

Hello,
We translated this repository into Persian so that the Persian-speaking community can use it.
I added the translated link to your repository, please check it .
Best regard

Hello,
can you check my pull request
thank you so much

hi, ok, thank you very much.

Hello,
can you check my pull request
thank you so much


chore: upgrade Cypress to 6.2.1

SUMMARY
Upgrade Cypress to 6.2.1 with some required refactoring:

Remove readResponseBlob since the new cy.intercept(..) API already reads JSON responses automatically.
Remove verifyResponseCodes since it's very unlikely that we get an incorrect status code yet still receive the correct response.
Add a FormData parser since request.body is no longer a native FormData object
Replace a couple of .should('not.visible') to .should('not.exist') because Cypress will now throw errors for elements that do not exist.

Upgrading since I wanted to add more tests for time-series table and box plot viz.
Reference: Cypress's official migration guide
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TEST PLAN
CI must pass
ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Changes UI
[ ] Requires DB Migration.
[ ] Confirm DB Migration upgrade and downgrade tested.
[ ] Introduces new feature or API
[ ] Removes existing feature or API

Codecov Report

Merging #12605 (5a731af) into master (dd4256a) will decrease coverage by 3.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #12605      +/-   ##
==========================================
- Coverage   66.24%   63.18%   -3.06%
==========================================
  Files        1015      486     -529
  Lines       49652    29982   -19670
  Branches     4839        0    -4839
==========================================
- Hits        32893    18945   -13948
+ Misses      16632    11037    -5595
+ Partials      127        0     -127

Flag
Coverage Δ

cypress
?

javascript
?

python
63.18% <ø> (-0.81%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

superset/db_engines/hive.py
0.00% <0.00%> (-85.72%)
:arrow_down:

superset/sql_validators/postgres.py
50.00% <0.00%> (-50.00%)
:arrow_down:

superset/db_engine_specs/hive.py
54.61% <0.00%> (-29.24%)
:arrow_down:

superset/db_engine_specs/sqlite.py
65.62% <0.00%> (-9.38%)
:arrow_down:

superset/databases/commands/create.py
83.67% <0.00%> (-8.17%)
:arrow_down:

superset/databases/commands/update.py
85.71% <0.00%> (-8.17%)
:arrow_down:

superset/connectors/sqla/models.py
84.31% <0.00%> (-6.28%)
:arrow_down:

superset/databases/commands/test_connection.py
84.78% <0.00%> (-4.35%)
:arrow_down:

superset/utils/celery.py
96.42% <0.00%> (-3.58%)
:arrow_down:

superset/models/core.py
85.59% <0.00%> (-3.27%)
:arrow_down:

... and 540 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd4256a...5a731af. Read the comment docs.

Codecov Report

Merging #12605 (5a731af) into master (dd4256a) will decrease coverage by 3.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #12605      +/-   ##
==========================================
- Coverage   66.24%   63.18%   -3.06%
==========================================
  Files        1015      486     -529
  Lines       49652    29982   -19670
  Branches     4839        0    -4839
==========================================
- Hits        32893    18945   -13948
+ Misses      16632    11037    -5595
+ Partials      127        0     -127

Flag
Coverage Δ

cypress
?

javascript
?

python
63.18% <ø> (-0.81%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

superset/db_engines/hive.py
0.00% <0.00%> (-85.72%)
:arrow_down:

superset/sql_validators/postgres.py
50.00% <0.00%> (-50.00%)
:arrow_down:

superset/db_engine_specs/hive.py
54.61% <0.00%> (-29.24%)
:arrow_down:

superset/db_engine_specs/sqlite.py
65.62% <0.00%> (-9.38%)
:arrow_down:

superset/databases/commands/create.py
83.67% <0.00%> (-8.17%)
:arrow_down:

superset/databases/commands/update.py
85.71% <0.00%> (-8.17%)
:arrow_down:

superset/connectors/sqla/models.py
84.31% <0.00%> (-6.28%)
:arrow_down:

superset/databases/commands/test_connection.py
84.78% <0.00%> (-4.35%)
:arrow_down:

superset/utils/celery.py
96.42% <0.00%> (-3.58%)
:arrow_down:

superset/models/core.py
85.59% <0.00%> (-3.27%)
:arrow_down:

... and 540 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd4256a...5a731af. Read the comment docs.

Thank

Thank


404 page update

What should this PR do?
Resolves DEVED-217 by revamping our 404 page a bit.
Why are we making this change?

Even if you don't find what you want, you should still have a delightful experience.

What are the acceptance criteria?

Style and text updates look good and make sense in light/ dark mode.
Links work.

How should this PR be tested?

Check out the branch, start your server & hit a url that doesn't exist.

Pull request process
Reviewers:

Test functionality using the criteria above.
Offer tips for efficiency, feedback on best practices, and possible alternative approaches and things that may not have been considered.
For shorter, "quick" PRs, use your best judgement on #2.
Use a collaborative approach and provide resources and/or context where appropriate.
Provide screenshots/grabs where appropriate to show findings during review.

Reviewees:

Prefer incremental and appropriately-scoped changes.
Leave a comment on things you want explicit feedback on.
Respond clearly to comments and questions.

Idk @ltagliaferri I feel like it needs something else — what do you think? I like the robots, but text-wise maybe?


Failed to find a default file in the app artifacts folder. Valid default files: index.html,Index.html.

Describe the bug
I'm receiving the following error: Failed to find a default file in the app artifacts folder (dist/kidztownwebapp.client). Valid default files: index.html,Index.html.
I'm trying to deploy an Angular 18 application with a .NET Core 8 backend, so my project is set up like this: I have a client app folder that holds the Angular application (kidztownwebapp.client) and an API folder for the backend (KidzTownWebApp.Server).
I noticed my dist folder actually pushes the index.html file to dist/kidztownwebapp.client/browser. I changed my angular.json outputPath to "dist/kidztownwebapp.client/browser" and updated my .yml foloder output_location to match it "dist/kidztownwebapp.client/browser" but I still get the same error.
I also tried leaving the output_location empty and putting skip_app_build: true and skip_api_build: true, but it still didn't work.

staticwebapp.config.json file
{
"platform": {
"apiRuntime": "node:18"
}

}
YML File:
name: Azure Static Web Apps CI/CD
on:
push:
branches:
- master
pull_request:
types: [opened, synchronize, reopened, closed]
branches:
- master
YML file:
jobs:
build_and_deploy_job:
if: github.event_name == 'push' || (github.event_name == 'pull_request' && github.event.action != 'closed')
runs-on: ubuntu-latest
name: Build and Deploy Job
steps:
- uses: actions/checkout@v3
with:
submodules: true
lfs: false
- name: Set up Node.js
uses: actions/setup-node@v3
with:
node-version: '20.x'
###### check-latest: true ---will download latest, has performance issues
- name: Build And Deploy
id: builddeploy
uses: Azure/static-web-apps-deploy@v1
with:
azure_static_web_apps_api_token: ${{ my secret here }}
repo_token: ${{ secrets.GITHUB_TOKEN }} # Used for Github integrations (i.e. PR comments)
action: "upload"
###### Repository/Build Configurations - These values can be configured to match your app requirements. ######
# For more information regarding Static Web App workflow configurations, please visit: https://aka.ms/swaworkflowconfig
app_location: "kidztownwebapp.client/" # App source code path
api_location: "api" # Api source code path - optional
output_location: "dist/kidztownwebapp.client/browser" # Built app content directory - optional
#skip_api_build: true #AML remove if needed to be built through yml
#skip_app_build: true #AML remove if needed to be built through yml
###### End of Repository/Build Configurations ######
close_pull_request_job:
if: github.event_name == 'pull_request' && github.event.action == 'closed'
runs-on: ubuntu-latest
name: Close Pull Request Job
steps:
- name: Close Pull Request
id: closepullrequest
uses: Azure/static-web-apps-deploy@v1
with:
azure_static_web_apps_api_token: ${{ [REMOVED]}}
action: "close"
Expected behavior
This part of the build step should clear.
Screenshots

Hi, did you resolve the problem?


Added SwiftSortedList

Project URL
https://github.com/bemindinteractive/SwiftSortedList
Description
SwiftSortedList is a sorted list implementation in Swift. This is a generic list that is always sorted.
Every time that an element is added, the list is sorted automatically. This is the first public version with basic features. More features (e.g. lazy approach) will be added in the future. CI integration will be added soon.
Checklist

[x] Only one project is in the request
[x] Addition in chronological order (bottom of category)
[x] Travis CI pass
[x] Supports iOS 7 and later
[x] Has a commit from less than 2 years ago
[x] Has a clear README in English

SwiftSortedList is a sorted list implementation written in Swift.
It uses the Comparable protocol to keep the implementation generic.

I feel like there must be another category better than /Utilities.
Some libraries on our Issues are some kind similar:
#739
#672

@dkhamsing any thoughts?

Maybe a "Data structures/Algorithms" category?

Yea something like a Data structure category. JSON and XML could go there too as sub section

@lfarah is this ok to merge, we can move it later?

@dkhamsing makes sense. Let's merge this and then discuss in #765

@lfarah @lifeisfoo thx


linter: bail unmatched rules

https://github.com/oxc-project/oxc/blob/1691cab507cd22e0e32f80d6fcb2911df82669f1/crates/oxc_linter/src/config/rules.rs#L129-L142
Should we bail unmatched rules?

@Boshen do you mean we should panic or return an error exit code when there are unmatched rules?

Return an error exit code when there are unmatched rules.

Side note: should probably exit 1 if no rules are applied.

@Boshen Does it feel like returning an error is still the right move here? I feel like it's good that we are warning users about useless/broken configuration, but I feel bad that we're breaking existing configs with the next oxlint version.

@Boshen Does it feel like returning an error is still the right move here? I feel like it's good that we are warning users about useless/broken configuration, but I feel bad that we're breaking existing configs with the next oxlint version.

I'm also conflicted, let me think about the long term consequences.

I'm working on fixing the language server integration so that it doesn't completely fail and integrates with editors correctly.
https://github.com/oxc-project/oxc/pull/7085 is the VS Code side of the changes.
IntelliJ already works without any additional changes.
Working on another PR that makes some changes so that the language server doesn't crash when there are unknown rules and properly emits a message to the editor.  It's mostly rust code and I'm not really familiar with rust, so it'll need some cleanup before merging.

@Boshen I thought about this some more and I have a small proposal here:

https://github.com/oxc-project/oxc/discussions/7086


\n new lines logged in console

If I save the content of a textarea (which includes \n for new lines) I can see in my console that bun is logging those new lines.
I think this didn't happen with go-pg and I don't think it's either useful or safe anyway.
Do you agree @vmihailenco?

Yes, I guess we could strip leading/trailing whitespaces.

And in the middle?

Ideally yes, but that requires some care to not strip newlines in string values so you can copy-paste query and execute it manually.


Can I use "-profile"  parameter in Start-Sefirefox ?

First Thanks your selenium with powershell, Because I love to use powershell for automation.
I had a website of self-signed, and I didn't find  accept_untrusted_certs of property for firefox driver.
Can anyone give me some advice?

This is the current code:
function Start-SeFirefox {
    param([Switch]$Profile)

    if ($Profile) {
        #Doesn't work....

Apparently it is a known issue.

It looks like this works to make a FireFox driver which ignores SSL certificate checks:
$firefoxOptions = [OpenQA.Selenium.Firefox.FirefoxOptions]::new()
$firefoxOptions.AddAdditionalCapability('acceptInsecureCerts', $true, $true)
$Driver = New-Object -TypeName "OpenQA.Selenium.Firefox.FirefoxDriver" -ArgumentList @($firefoxOptions)

From here:https://github.com/mozilla/geckodriver/issues/563#issuecomment-288711235

For those that want to run this for Chrome, here's the command for that:
$ChromeOptions = [OpenQA.Selenium.Chrome.ChromeOptions]::new()
$ChromeOptions.AcceptInsecureCertificates = $true
$driver = New-Object -TypeName "OpenQA.Selenium.Chrome.ChromeDriver" -ArgumentList @($ChromeOptions)
I also wanted my script to not wait for the page to finish loading before going to the next command in PS, so you can also add this line to the options:
$ChromeOptions.PageLoadStrategy = "None"

There is something fishy with Selenium.Firefox.WebDriver 0.25.0/0.26.0 and profiles. seems like the FirefoxProfile object is readonly:
$prof = New-Object OpenQA.Selenium.Firefox.FirefoxProfile($profilePath)
PS > $prof.ProfileDirectory
PS > $prof.ProfileDirectory = $profilePath
'ProfileDirectory' is a ReadOnly property.
At line:1 char:1
+ $prof.ProfileDirectory = $profilePath
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : InvalidOperation: (:) [], RuntimeException
    + FullyQualifiedErrorId : PropertyAssignmentException

It looks like this works to make a FireFox driver which ignores SSL certificate checks:
$firefoxOptions = [OpenQA.Selenium.Firefox.FirefoxOptions]::new()
$firefoxOptions.AddAdditionalCapability('acceptInsecureCerts', $true, $true)
$Driver = New-Object -TypeName "OpenQA.Selenium.Firefox.FirefoxDriver" -ArgumentList @($firefoxOptions)

From here:mozilla/geckodriver#563 (comment)
If people are interested in this we can add it as a flag to Start-SeFirefox.
Let me know if you are interested in that .

-DM


Conditional if clause not consistent and poorly documented

Microsoft documentation does not clearly mention how to use the if clause with multiple conditions and scarily enough logic cannot be applied when it comes to what Microsoft has implemented.
If I use the following clause it does not use it as an OR condition. It just evaluate to false. But if I use the same in a 'task condition' it works. Microsoft, please, let me use some logic instead of pure randomness just like how it is in Microsoft VB. Could someone please let me know why it won't evaluate to true if the parameters.environment is 'production'. I just cannot figure it out how Microsoft evaluates it as false. If this is not the way Microsoft wants it, it will be great if Microsoft can document that in this page with an example.
- ${{ if or(eq('${{ parameters.environment }}', 'production'), eq('${{ parameters.environment }}', 'acceptance')) }}:

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 77c58a78-a567-e99a-9eb7-62dddd1b90b6
Version Independent ID: 680a79bc-11de-39fc-43e3-e07dc762db18
Content: Expressions - Azure Pipelines
Content Source: docs/pipelines/process/expressions.md
Product: devops
Technology: devops-cicd-process
GitHub Login: @juliakm
Microsoft Alias: jukullam

@sijucm Thanks for your question. While we look into the documentation, consider these additional resources:

Azure DevOps Services
Azure DevOps Support Bot
Azure DevOps on Stack Overflow

@sijucm I think that the problem you are running into is that you're using template syntax inside of template syntax. In this example, the first step evaluates as true.
parameters:
- name: environment
  type: string
  default: 'acceptance'

steps:
  - ${{ if or(eq(parameters.environment, 'production'), eq(parameters.environment, 'acceptance')) }}:
    - script: echo "Are you there param?"
  - ${{ if eq(parameters.environment, 'production') }}:
    - script: echo "Are you there param?"

If you have suggestions for how the product should work or concerns about possible bugs, please reach out to the product team in the Developer Community.


pegasus pom files no more available from linkedin bintray

during gradlew build for 4.0.0 version, we got this error:

What went wrong:
Execution failed for task ':azkaban-web-server:restliTemplateGenerator'.

Could not resolve all files for configuration ':azkaban-web-server:generateRestli'.
Could not resolve com.linkedin.pegasus:generator:28.3.11.
Required by:
project :azkaban-web-server
Could not resolve com.linkedin.pegasus:generator:28.3.11.
Could not get resource 'https://linkedin.bintray.com/maven/com/linkedin/pegasus/generator/28.3.11/generator-28.3.11.pom'.
Could not GET 'https://linkedin.bintray.com/maven/com/linkedin/pegasus/generator/28.3.11/generator-28.3.11.pom'. Received status code 403 from server: Forbidden
Could not resolve com.linkedin.pegasus:restli-tools:28.3.11.
Required by:
project :azkaban-web-server
Could not resolve com.linkedin.pegasus:restli-tools:28.3.11.
Could not get resource 'https://linkedin.bintray.com/maven/com/linkedin/pegasus/restli-tools/28.3.11/restli-tools-28.3.11.pom'.
Could not GET 'https://linkedin.bintray.com/maven/com/linkedin/pegasus/restli-tools/28.3.11/restli-tools-28.3.11.pom'. Received status code 403 from server: Forbidden

As the files are available on linkedin.jfrog.io i'lll propose a fix

already done, the code is ok, but the tar given in releases>4.0.0 is an old one, please update it => https://github.com/azkaban/azkaban/archive/refs/tags/4.0.0.tar.gz

https://github.com/azkaban/azkaban/blob/09fc3b2debfdc4a5a9623421006bb389fc878d34/build.gradle#L57
https://github.com/azkaban/azkaban/blob/9018fa2c4afb71b8b86cb8d5092d50d8bcf9c7e1/build.gradle#L57
https://linkedin.bintray.com/maven
is no longer valid and needs to be replaced with
https://linkedin.jfrog.io/artifactory/open-source/

when  'https://linkedin.bintray.com/maven’ replaced with 'https://linkedin.jfrog.io/artifactory/open-source/'
it occurs
`* What went wrong:
Execution failed for task ':azkaban-web-server:restliTemplateGenerator'.

Could not resolve all files for configuration ':azkaban-web-server:generateRestli'.
Could not find com.linkedin.pegasus:generator:28.3.11.
Searched in the following locations:
https://repo.maven.apache.org/maven2/com/linkedin/pegasus/generator/28.3.11/generator-28.3.11.pom
https://repo.maven.apache.org/maven2/com/linkedin/pegasus/generator/28.3.11/generator-28.3.11.jar
file:/home/ring/.m2/repository/com/linkedin/pegasus/generator/28.3.11/generator-28.3.11.pom
file:/home/ring/.m2/repository/com/linkedin/pegasus/generator/28.3.11/generator-28.3.11.jar
https://linkedin.jfrog.io/artifactory/open-sorce/com/linkedin/pegasus/generator/28.3.11/generator-28.3.11.
https://linkedin.jfrog.io/artifactory/open-sorce/com/linkedin/pegasus/generator/28.3.11/generator-28.3.11.
https://repo.maven.apache.org/maven2/com/linkedin/pegasus/generator/28.3.11/generator-28.3.11.pom
https://repo.maven.apache.org/maven2/com/linkedin/pegasus/generator/28.3.11/generator-28.3.11.jar
Required by:
project :azkaban-web-server
Could not find com.linkedin.pegasus:restli-tools:28.3.11.
Searched in the following locations:
https://repo.maven.apache.org/maven2/com/linkedin/pegasus/restli-tools/28.3.11/restli-tools-28.3.11.pom
https://repo.maven.apache.org/maven2/com/linkedin/pegasus/restli-tools/28.3.11/restli-tools-28.3.11.jar
file:/home/ring/.m2/repository/com/linkedin/pegasus/restli-tools/28.3.11/restli-tools-28.3.11.pom
file:/home/ring/.m2/repository/com/linkedin/pegasus/restli-tools/28.3.11/restli-tools-28.3.11.jar
https://linkedin.jfrog.io/artifactory/open-sorce/com/linkedin/pegasus/restli-tools/28.3.11/restli-tools-28
https://linkedin.jfrog.io/artifactory/open-sorce/com/linkedin/pegasus/restli-tools/28.3.11/restli-tools-28
https://repo.maven.apache.org/maven2/com/linkedin/pegasus/restli-tools/28.3.11/restli-tools-28.3.11.pom
https://repo.maven.apache.org/maven2/com/linkedin/pegasus/restli-tools/28.3.11/restli-tools-28.3.11.jar
Required by:
project :azkaban-web-server
`

I tried this psotgres branch .
He has some bugs.
For example, when useExecutor is specified
The error report is shown in the figure below

sql needs to be compatible

it seems that linkedin repo is stopped service?


Get Associated Data Files (Fetch a Package from EDI) not working for edi.836.1

Clicking the Get Associated Data Files button causes and error (Email<EMAIL_ADDRESS>message) for edi.836.1. Continue without getting data files option works without error

A data file contains illegal characters that cause a UnicodeDecodeError exception. Now it will bring up a page that identifies the illegal characters, rather than going to the generic error screen. Fixed in release 2022.05.02.


Feature Request: Allow for faster refresh times in cm-rgb-monitor

I would like to set a faster refresh time in cm-rgb-monitor.
The only change required for this is:
@click.option('--interval', type=click.FloatRange(0.01, 60, clamp=True), default=3)
Set interval as a FloatRange instead of IntRange. time.sleep does not care.

Sounds reasonable 👍
I will take this opportunity to finally add few missing features to the CLI
I will release whole thing around weekend.

Yes, works for me, just looks sightly flickery at currently 10 Hz.

Please see https://github.com/gfduszynski/cm-rgb/pull/25

Thanks


change speed per user via admin portal

change user profile speed per user gamit lang ang admin portal ni juanfi
almost complete na din

This feature is much better to do in MT like doing per profile, its much flexible since theres many way to implement speed in mt like queue tree