Configure dnsRefreshRate in bootstrap config

We previously added configuration for dns_refresh_rate, which applies to
STRICT_DNS clusters for ServiceEntries. However, this didn't get passed
through to the bootstrap config. This is especially critical as we plan
to change the default dns_refresh_rate, so we need to also have this
apply to the bootstrap.
A part of https://github.com/istio/istio/issues/13710

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: howardjohn
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: rshriram
If they are not already assigned, you can assign the PR to them by writing /assign @rshriram in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@howardjohn: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
69f84158f84b138edef7b06428c59b6e8b379801
link
/test istio-unit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
69f84158f84b138edef7b06428c59b6e8b379801
link
/test istio-unit-tests-master

prow/e2e-mixer-no_auth.sh
69f84158f84b138edef7b06428c59b6e8b379801
link
/test e2e-mixer-no_auth-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
69f84158f84b138edef7b06428c59b6e8b379801
link
/test istio-unit-tests-master

prow/e2e-mixer-no_auth.sh
69f84158f84b138edef7b06428c59b6e8b379801
link
/test e2e-mixer-no_auth-master

prow/e2e-dashboard.sh
69f84158f84b138edef7b06428c59b6e8b379801
link
/test e2e-dashboard-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
69f84158f84b138edef7b06428c59b6e8b379801
link
/test istio-unit-tests-master

prow/e2e-mixer-no_auth.sh
69f84158f84b138edef7b06428c59b6e8b379801
link
/test e2e-mixer-no_auth-master

prow/e2e-dashboard.sh
69f84158f84b138edef7b06428c59b6e8b379801
link
/test e2e-dashboard-master

prow/e2e-bookInfoTests-trustdomain.sh
69f84158f84b138edef7b06428c59b6e8b379801
link
/test e2e-bookInfoTests-trustdomain-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
69f84158f84b138edef7b06428c59b6e8b379801
link
/test istio-unit-tests-master

prow/e2e-mixer-no_auth.sh
69f84158f84b138edef7b06428c59b6e8b379801
link
/test e2e-mixer-no_auth-master

prow/e2e-dashboard.sh
69f84158f84b138edef7b06428c59b6e8b379801
link
/test e2e-dashboard-master

prow/e2e-bookInfoTests-trustdomain.sh
69f84158f84b138edef7b06428c59b6e8b379801
link
/test e2e-bookInfoTests-trustdomain-master

prow/e2e-simpleTests-cni.sh
69f84158f84b138edef7b06428c59b6e8b379801
link
/test e2e-simpleTests-cni-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
69f84158f84b138edef7b06428c59b6e8b379801
link
/test istio-unit-tests-master

prow/e2e-mixer-no_auth.sh
69f84158f84b138edef7b06428c59b6e8b379801
link
/test e2e-mixer-no_auth-master

prow/e2e-dashboard.sh
69f84158f84b138edef7b06428c59b6e8b379801
link
/test e2e-dashboard-master

prow/e2e-bookInfoTests-trustdomain.sh
69f84158f84b138edef7b06428c59b6e8b379801
link
/test e2e-bookInfoTests-trustdomain-master

prow/e2e-simpleTests-cni.sh
69f84158f84b138edef7b06428c59b6e8b379801
link
/test e2e-simpleTests-cni-master

prow/e2e-simpleTests.sh
69f84158f84b138edef7b06428c59b6e8b379801
link
/test e2e-simpleTests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
69f84158f84b138edef7b06428c59b6e8b379801
link
/test istio-unit-tests-master

prow/e2e-mixer-no_auth.sh
69f84158f84b138edef7b06428c59b6e8b379801
link
/test e2e-mixer-no_auth-master

prow/e2e-dashboard.sh
69f84158f84b138edef7b06428c59b6e8b379801
link
/test e2e-dashboard-master

prow/e2e-bookInfoTests-trustdomain.sh
69f84158f84b138edef7b06428c59b6e8b379801
link
/test e2e-bookInfoTests-trustdomain-master

prow/e2e-simpleTests-cni.sh
69f84158f84b138edef7b06428c59b6e8b379801
link
/test e2e-simpleTests-cni-master

prow/e2e-simpleTests.sh
69f84158f84b138edef7b06428c59b6e8b379801
link
/test e2e-simpleTests-master

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
69f84158f84b138edef7b06428c59b6e8b379801
link
/test istio-pilot-e2e-envoyv2-v1alpha3-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
69f84158f84b138edef7b06428c59b6e8b379801
link
/test istio-unit-tests-master

prow/e2e-mixer-no_auth.sh
69f84158f84b138edef7b06428c59b6e8b379801
link
/test e2e-mixer-no_auth-master

prow/e2e-dashboard.sh
69f84158f84b138edef7b06428c59b6e8b379801
link
/test e2e-dashboard-master

prow/e2e-bookInfoTests-trustdomain.sh
69f84158f84b138edef7b06428c59b6e8b379801
link
/test e2e-bookInfoTests-trustdomain-master

prow/e2e-simpleTests-cni.sh
69f84158f84b138edef7b06428c59b6e8b379801
link
/test e2e-simpleTests-cni-master

prow/e2e-simpleTests.sh
69f84158f84b138edef7b06428c59b6e8b379801
link
/test e2e-simpleTests-master

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
69f84158f84b138edef7b06428c59b6e8b379801
link
/test istio-pilot-e2e-envoyv2-v1alpha3-master

prow/e2e-bookInfoTests-v1alpha3.sh
69f84158f84b138edef7b06428c59b6e8b379801
link
/test e2e-bookInfoTests-envoyv2-v1alpha3-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
69f84158f84b138edef7b06428c59b6e8b379801
link
/test istio-unit-tests-master

prow/e2e-mixer-no_auth.sh
69f84158f84b138edef7b06428c59b6e8b379801
link
/test e2e-mixer-no_auth-master

prow/e2e-dashboard.sh
69f84158f84b138edef7b06428c59b6e8b379801
link
/test e2e-dashboard-master

prow/e2e-bookInfoTests-trustdomain.sh
69f84158f84b138edef7b06428c59b6e8b379801
link
/test e2e-bookInfoTests-trustdomain-master

prow/e2e-simpleTests-cni.sh
69f84158f84b138edef7b06428c59b6e8b379801
link
/test e2e-simpleTests-cni-master

prow/e2e-simpleTests.sh
69f84158f84b138edef7b06428c59b6e8b379801
link
/test e2e-simpleTests-master

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
69f84158f84b138edef7b06428c59b6e8b379801
link
/test istio-pilot-e2e-envoyv2-v1alpha3-master

prow/e2e-bookInfoTests-v1alpha3.sh
69f84158f84b138edef7b06428c59b6e8b379801
link
/test e2e-bookInfoTests-envoyv2-v1alpha3-master

prow/istio-pilot-multicluster-e2e.sh
69f84158f84b138edef7b06428c59b6e8b379801
link
/test istio-pilot-multicluster-e2e-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
69f84158f84b138edef7b06428c59b6e8b379801
link
/test istio-unit-tests-master

prow/e2e-mixer-no_auth.sh
69f84158f84b138edef7b06428c59b6e8b379801
link
/test e2e-mixer-no_auth-master

prow/e2e-dashboard.sh
69f84158f84b138edef7b06428c59b6e8b379801
link
/test e2e-dashboard-master

prow/e2e-bookInfoTests-trustdomain.sh
69f84158f84b138edef7b06428c59b6e8b379801
link
/test e2e-bookInfoTests-trustdomain-master

prow/e2e-simpleTests-cni.sh
69f84158f84b138edef7b06428c59b6e8b379801
link
/test e2e-simpleTests-cni-master

prow/e2e-simpleTests.sh
69f84158f84b138edef7b06428c59b6e8b379801
link
/test e2e-simpleTests-master

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
69f84158f84b138edef7b06428c59b6e8b379801
link
/test istio-pilot-e2e-envoyv2-v1alpha3-master

prow/e2e-bookInfoTests-v1alpha3.sh
69f84158f84b138edef7b06428c59b6e8b379801
link
/test e2e-bookInfoTests-envoyv2-v1alpha3-master

prow/istio-pilot-multicluster-e2e.sh
69f84158f84b138edef7b06428c59b6e8b379801
link
/test istio-pilot-multicluster-e2e-master

prow/e2e_pilotv2_auth_sds.sh
69f84158f84b138edef7b06428c59b6e8b379801
link
/test istio_auth_sds_e2e-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
69f84158f84b138edef7b06428c59b6e8b379801
link
/test istio-unit-tests-master

prow/e2e-mixer-no_auth.sh
69f84158f84b138edef7b06428c59b6e8b379801
link
/test e2e-mixer-no_auth-master

prow/e2e-dashboard.sh
69f84158f84b138edef7b06428c59b6e8b379801
link
/test e2e-dashboard-master

prow/e2e-bookInfoTests-trustdomain.sh
69f84158f84b138edef7b06428c59b6e8b379801
link
/test e2e-bookInfoTests-trustdomain-master

prow/e2e-simpleTests.sh
69f84158f84b138edef7b06428c59b6e8b379801
link
/test e2e-simpleTests-master

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
69f84158f84b138edef7b06428c59b6e8b379801
link
/test istio-pilot-e2e-envoyv2-v1alpha3-master

prow/e2e-bookInfoTests-v1alpha3.sh
69f84158f84b138edef7b06428c59b6e8b379801
link
/test e2e-bookInfoTests-envoyv2-v1alpha3-master

prow/istio-pilot-multicluster-e2e.sh
69f84158f84b138edef7b06428c59b6e8b379801
link
/test istio-pilot-multicluster-e2e-master

prow/e2e_pilotv2_auth_sds.sh
69f84158f84b138edef7b06428c59b6e8b379801
link
/test istio_auth_sds_e2e-master

prow/e2e-simpleTests-cni.sh
d24cd03d8d300462f9562347a3a390f28016b504
link
/test e2e-simpleTests-cni-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
69f84158f84b138edef7b06428c59b6e8b379801
link
/test istio-unit-tests-master

prow/e2e-mixer-no_auth.sh
69f84158f84b138edef7b06428c59b6e8b379801
link
/test e2e-mixer-no_auth-master

prow/e2e-dashboard.sh
69f84158f84b138edef7b06428c59b6e8b379801
link
/test e2e-dashboard-master

prow/e2e-bookInfoTests-trustdomain.sh
69f84158f84b138edef7b06428c59b6e8b379801
link
/test e2e-bookInfoTests-trustdomain-master

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
69f84158f84b138edef7b06428c59b6e8b379801
link
/test istio-pilot-e2e-envoyv2-v1alpha3-master

prow/e2e-bookInfoTests-v1alpha3.sh
69f84158f84b138edef7b06428c59b6e8b379801
link
/test e2e-bookInfoTests-envoyv2-v1alpha3-master

prow/istio-pilot-multicluster-e2e.sh
69f84158f84b138edef7b06428c59b6e8b379801
link
/test istio-pilot-multicluster-e2e-master

prow/e2e_pilotv2_auth_sds.sh
69f84158f84b138edef7b06428c59b6e8b379801
link
/test istio_auth_sds_e2e-master

prow/e2e-simpleTests-cni.sh
d24cd03d8d300462f9562347a3a390f28016b504
link
/test e2e-simpleTests-cni-master

prow/e2e-simpleTests.sh
d24cd03d8d300462f9562347a3a390f28016b504
link
/test e2e-simpleTests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
69f84158f84b138edef7b06428c59b6e8b379801
link
/test istio-unit-tests-master

prow/e2e-mixer-no_auth.sh
69f84158f84b138edef7b06428c59b6e8b379801
link
/test e2e-mixer-no_auth-master

prow/e2e-dashboard.sh
69f84158f84b138edef7b06428c59b6e8b379801
link
/test e2e-dashboard-master

prow/e2e-bookInfoTests-trustdomain.sh
69f84158f84b138edef7b06428c59b6e8b379801
link
/test e2e-bookInfoTests-trustdomain-master

prow/e2e-bookInfoTests-v1alpha3.sh
69f84158f84b138edef7b06428c59b6e8b379801
link
/test e2e-bookInfoTests-envoyv2-v1alpha3-master

prow/istio-pilot-multicluster-e2e.sh
69f84158f84b138edef7b06428c59b6e8b379801
link
/test istio-pilot-multicluster-e2e-master

prow/e2e_pilotv2_auth_sds.sh
69f84158f84b138edef7b06428c59b6e8b379801
link
/test istio_auth_sds_e2e-master

prow/e2e-simpleTests-cni.sh
d24cd03d8d300462f9562347a3a390f28016b504
link
/test e2e-simpleTests-cni-master

prow/e2e-simpleTests.sh
d24cd03d8d300462f9562347a3a390f28016b504
link
/test e2e-simpleTests-master

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
d24cd03d8d300462f9562347a3a390f28016b504
link
/test istio-pilot-e2e-envoyv2-v1alpha3-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
69f84158f84b138edef7b06428c59b6e8b379801
link
/test istio-unit-tests-master

prow/e2e-mixer-no_auth.sh
69f84158f84b138edef7b06428c59b6e8b379801
link
/test e2e-mixer-no_auth-master

prow/e2e-bookInfoTests-trustdomain.sh
69f84158f84b138edef7b06428c59b6e8b379801
link
/test e2e-bookInfoTests-trustdomain-master

prow/e2e-bookInfoTests-v1alpha3.sh
69f84158f84b138edef7b06428c59b6e8b379801
link
/test e2e-bookInfoTests-envoyv2-v1alpha3-master

prow/istio-pilot-multicluster-e2e.sh
69f84158f84b138edef7b06428c59b6e8b379801
link
/test istio-pilot-multicluster-e2e-master

prow/e2e_pilotv2_auth_sds.sh
69f84158f84b138edef7b06428c59b6e8b379801
link
/test istio_auth_sds_e2e-master

prow/e2e-simpleTests-cni.sh
d24cd03d8d300462f9562347a3a390f28016b504
link
/test e2e-simpleTests-cni-master

prow/e2e-simpleTests.sh
d24cd03d8d300462f9562347a3a390f28016b504
link
/test e2e-simpleTests-master

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
d24cd03d8d300462f9562347a3a390f28016b504
link
/test istio-pilot-e2e-envoyv2-v1alpha3-master

prow/e2e-dashboard.sh
d24cd03d8d300462f9562347a3a390f28016b504
link
/test e2e-dashboard-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
69f84158f84b138edef7b06428c59b6e8b379801
link
/test istio-unit-tests-master

prow/e2e-mixer-no_auth.sh
69f84158f84b138edef7b06428c59b6e8b379801
link
/test e2e-mixer-no_auth-master

prow/e2e-bookInfoTests-trustdomain.sh
69f84158f84b138edef7b06428c59b6e8b379801
link
/test e2e-bookInfoTests-trustdomain-master

prow/istio-pilot-multicluster-e2e.sh
69f84158f84b138edef7b06428c59b6e8b379801
link
/test istio-pilot-multicluster-e2e-master

prow/e2e_pilotv2_auth_sds.sh
69f84158f84b138edef7b06428c59b6e8b379801
link
/test istio_auth_sds_e2e-master

prow/e2e-simpleTests-cni.sh
d24cd03d8d300462f9562347a3a390f28016b504
link
/test e2e-simpleTests-cni-master

prow/e2e-simpleTests.sh
d24cd03d8d300462f9562347a3a390f28016b504
link
/test e2e-simpleTests-master

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
d24cd03d8d300462f9562347a3a390f28016b504
link
/test istio-pilot-e2e-envoyv2-v1alpha3-master

prow/e2e-dashboard.sh
d24cd03d8d300462f9562347a3a390f28016b504
link
/test e2e-dashboard-master

prow/e2e-bookInfoTests-v1alpha3.sh
d24cd03d8d300462f9562347a3a390f28016b504
link
/test e2e-bookInfoTests-envoyv2-v1alpha3-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
69f84158f84b138edef7b06428c59b6e8b379801
link
/test istio-unit-tests-master

prow/e2e-mixer-no_auth.sh
69f84158f84b138edef7b06428c59b6e8b379801
link
/test e2e-mixer-no_auth-master

prow/e2e-bookInfoTests-trustdomain.sh
69f84158f84b138edef7b06428c59b6e8b379801
link
/test e2e-bookInfoTests-trustdomain-master

prow/istio-pilot-multicluster-e2e.sh
69f84158f84b138edef7b06428c59b6e8b379801
link
/test istio-pilot-multicluster-e2e-master

prow/e2e-simpleTests-cni.sh
d24cd03d8d300462f9562347a3a390f28016b504
link
/test e2e-simpleTests-cni-master

prow/e2e-simpleTests.sh
d24cd03d8d300462f9562347a3a390f28016b504
link
/test e2e-simpleTests-master

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
d24cd03d8d300462f9562347a3a390f28016b504
link
/test istio-pilot-e2e-envoyv2-v1alpha3-master

prow/e2e-dashboard.sh
d24cd03d8d300462f9562347a3a390f28016b504
link
/test e2e-dashboard-master

prow/e2e-bookInfoTests-v1alpha3.sh
d24cd03d8d300462f9562347a3a390f28016b504
link
/test e2e-bookInfoTests-envoyv2-v1alpha3-master

prow/e2e_pilotv2_auth_sds.sh
d24cd03d8d300462f9562347a3a390f28016b504
link
/test istio_auth_sds_e2e-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
69f84158f84b138edef7b06428c59b6e8b379801
link
/test istio-unit-tests-master

prow/e2e-mixer-no_auth.sh
69f84158f84b138edef7b06428c59b6e8b379801
link
/test e2e-mixer-no_auth-master

prow/e2e-bookInfoTests-trustdomain.sh
69f84158f84b138edef7b06428c59b6e8b379801
link
/test e2e-bookInfoTests-trustdomain-master

prow/e2e-simpleTests-cni.sh
d24cd03d8d300462f9562347a3a390f28016b504
link
/test e2e-simpleTests-cni-master

prow/e2e-simpleTests.sh
d24cd03d8d300462f9562347a3a390f28016b504
link
/test e2e-simpleTests-master

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
d24cd03d8d300462f9562347a3a390f28016b504
link
/test istio-pilot-e2e-envoyv2-v1alpha3-master

prow/e2e-dashboard.sh
d24cd03d8d300462f9562347a3a390f28016b504
link
/test e2e-dashboard-master

prow/e2e-bookInfoTests-v1alpha3.sh
d24cd03d8d300462f9562347a3a390f28016b504
link
/test e2e-bookInfoTests-envoyv2-v1alpha3-master

prow/e2e_pilotv2_auth_sds.sh
d24cd03d8d300462f9562347a3a390f28016b504
link
/test istio_auth_sds_e2e-master

prow/istio-pilot-multicluster-e2e.sh
d24cd03d8d300462f9562347a3a390f28016b504
link
/test istio-pilot-multicluster-e2e-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
69f84158f84b138edef7b06428c59b6e8b379801
link
/test istio-unit-tests-master

prow/e2e-mixer-no_auth.sh
69f84158f84b138edef7b06428c59b6e8b379801
link
/test e2e-mixer-no_auth-master

prow/e2e-simpleTests-cni.sh
d24cd03d8d300462f9562347a3a390f28016b504
link
/test e2e-simpleTests-cni-master

prow/e2e-simpleTests.sh
d24cd03d8d300462f9562347a3a390f28016b504
link
/test e2e-simpleTests-master

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
d24cd03d8d300462f9562347a3a390f28016b504
link
/test istio-pilot-e2e-envoyv2-v1alpha3-master

prow/e2e-dashboard.sh
d24cd03d8d300462f9562347a3a390f28016b504
link
/test e2e-dashboard-master

prow/e2e-bookInfoTests-v1alpha3.sh
d24cd03d8d300462f9562347a3a390f28016b504
link
/test e2e-bookInfoTests-envoyv2-v1alpha3-master

prow/e2e_pilotv2_auth_sds.sh
d24cd03d8d300462f9562347a3a390f28016b504
link
/test istio_auth_sds_e2e-master

prow/istio-pilot-multicluster-e2e.sh
d24cd03d8d300462f9562347a3a390f28016b504
link
/test istio-pilot-multicluster-e2e-master

prow/e2e-bookInfoTests-trustdomain.sh
d24cd03d8d300462f9562347a3a390f28016b504
link
/test e2e-bookInfoTests-trustdomain-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
69f84158f84b138edef7b06428c59b6e8b379801
link
/test istio-unit-tests-master

prow/e2e-simpleTests-cni.sh
d24cd03d8d300462f9562347a3a390f28016b504
link
/test e2e-simpleTests-cni-master

prow/e2e-simpleTests.sh
d24cd03d8d300462f9562347a3a390f28016b504
link
/test e2e-simpleTests-master

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
d24cd03d8d300462f9562347a3a390f28016b504
link
/test istio-pilot-e2e-envoyv2-v1alpha3-master

prow/e2e-dashboard.sh
d24cd03d8d300462f9562347a3a390f28016b504
link
/test e2e-dashboard-master

prow/e2e-bookInfoTests-v1alpha3.sh
d24cd03d8d300462f9562347a3a390f28016b504
link
/test e2e-bookInfoTests-envoyv2-v1alpha3-master

prow/e2e_pilotv2_auth_sds.sh
d24cd03d8d300462f9562347a3a390f28016b504
link
/test istio_auth_sds_e2e-master

prow/istio-pilot-multicluster-e2e.sh
d24cd03d8d300462f9562347a3a390f28016b504
link
/test istio-pilot-multicluster-e2e-master

prow/e2e-bookInfoTests-trustdomain.sh
d24cd03d8d300462f9562347a3a390f28016b504
link
/test e2e-bookInfoTests-trustdomain-master

prow/e2e-mixer-no_auth.sh
d24cd03d8d300462f9562347a3a390f28016b504
link
/test e2e-mixer-no_auth-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests-cni.sh
d24cd03d8d300462f9562347a3a390f28016b504
link
/test e2e-simpleTests-cni-master

prow/e2e-simpleTests.sh
d24cd03d8d300462f9562347a3a390f28016b504
link
/test e2e-simpleTests-master

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
d24cd03d8d300462f9562347a3a390f28016b504
link
/test istio-pilot-e2e-envoyv2-v1alpha3-master

prow/e2e-dashboard.sh
d24cd03d8d300462f9562347a3a390f28016b504
link
/test e2e-dashboard-master

prow/e2e-bookInfoTests-v1alpha3.sh
d24cd03d8d300462f9562347a3a390f28016b504
link
/test e2e-bookInfoTests-envoyv2-v1alpha3-master

prow/e2e_pilotv2_auth_sds.sh
d24cd03d8d300462f9562347a3a390f28016b504
link
/test istio_auth_sds_e2e-master

prow/istio-pilot-multicluster-e2e.sh
d24cd03d8d300462f9562347a3a390f28016b504
link
/test istio-pilot-multicluster-e2e-master

prow/e2e-bookInfoTests-trustdomain.sh
d24cd03d8d300462f9562347a3a390f28016b504
link
/test e2e-bookInfoTests-trustdomain-master

prow/e2e-mixer-no_auth.sh
d24cd03d8d300462f9562347a3a390f28016b504
link
/test e2e-mixer-no_auth-master

prow/istio-unit-tests.sh
a04365cadf7cc4a692e1efba05ab296d223c4e70
link
/test istio-unit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
d24cd03d8d300462f9562347a3a390f28016b504
link
/test istio-pilot-multicluster-e2e-master

prow/istio-unit-tests.sh
a04365cadf7cc4a692e1efba05ab296d223c4e70
link
/test istio-unit-tests-master

prow/integ-security-k8s-presubmit-tests.sh
a04365cadf7cc4a692e1efba05ab296d223c4e70
link
/test integ-security-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
a04365cadf7cc4a692e1efba05ab296d223c4e70
link
/test istio-unit-tests-master

prow/integ-security-k8s-presubmit-tests.sh
a04365cadf7cc4a692e1efba05ab296d223c4e70
link
/test integ-security-k8s-presubmit-tests-master

prow/istio-integ-k8s-tests.sh
a04365cadf7cc4a692e1efba05ab296d223c4e70
link
/test istio-integ-k8s-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-security-k8s-presubmit-tests.sh
a04365cadf7cc4a692e1efba05ab296d223c4e70
link
/test integ-security-k8s-presubmit-tests-master

prow/istio-integ-k8s-tests.sh
a04365cadf7cc4a692e1efba05ab296d223c4e70
link
/test istio-integ-k8s-tests-master

prow/istio-unit-tests.sh
6f783596120e6f96048958c7df88fab951c8a5b9
link
/test istio-unit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-security-k8s-presubmit-tests.sh
a04365cadf7cc4a692e1efba05ab296d223c4e70
link
/test integ-security-k8s-presubmit-tests-master

prow/istio-integ-k8s-tests.sh
a04365cadf7cc4a692e1efba05ab296d223c4e70
link
/test istio-integ-k8s-tests-master

prow/istio-unit-tests.sh
6f783596120e6f96048958c7df88fab951c8a5b9
link
/test istio-unit-tests-master

prow/integ-pilot-k8s-presubmit-tests.sh
6f783596120e6f96048958c7df88fab951c8a5b9
link
/test integ-pilot-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
a04365cadf7cc4a692e1efba05ab296d223c4e70
link
/test istio-integ-k8s-tests-master

prow/istio-unit-tests.sh
6f783596120e6f96048958c7df88fab951c8a5b9
link
/test istio-unit-tests-master

prow/integ-pilot-k8s-presubmit-tests.sh
6f783596120e6f96048958c7df88fab951c8a5b9
link
/test integ-pilot-k8s-presubmit-tests-master

prow/integ-security-k8s-presubmit-tests.sh
6f783596120e6f96048958c7df88fab951c8a5b9
link
/test integ-security-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
a04365cadf7cc4a692e1efba05ab296d223c4e70
link
/test istio-integ-k8s-tests-master

prow/integ-security-k8s-presubmit-tests.sh
3a6e99beccfa97ffe704f236081623425be71262
link
/test integ-security-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/assign @fpesce @duderino @costinm @GregHanson @rshriram

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: howardjohn
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: costinm
If they are not already assigned, you can assign the PR to them by writing /assign @costinm in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
a04365cadf7cc4a692e1efba05ab296d223c4e70
link
/test istio-integ-k8s-tests-master

prow/istio-pilot-multicluster-e2e.sh
e934be3bea2eb04e12a0319b803fb38dcd763c50
link
/test istio-pilot-multicluster-e2e-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test istio-pilot-multicluster-e2e-master

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: howardjohn, rshriram
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [rshriram]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
a04365cadf7cc4a692e1efba05ab296d223c4e70
link
/test istio-integ-k8s-tests-master

prow/e2e-mixer-no_auth.sh
e934be3bea2eb04e12a0319b803fb38dcd763c50
link
/test e2e-mixer-no_auth-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test e2e-mixer-no_auth-master


Node EFI image doesn't boot on some real hardware

@msgctl and @lorenz have been doing some troubleshooting of Metropolis on real hardware.
The symptoms are that after the firmware boots into the image, we get a blank screen. This might be our EFI stub, this might be the Linux EFI stub we then launch, it might be some Linux configuration. It probably doesn't come back after calling ExitBootServices.
@lorenz has just got some hardware to debug this (LPC bus sniffing for outb() tombstone debugging)

At least on my hardware platform (an AOpen i67QMX-DV) our kernel boots just fine, except we don't have any output. We need to configure the kernel console for dual-output on the EFI framebuffer and serial.

We think the original issue is now fixed. The following issues contributed to this:
a) We didn't have EFI console driver so we had no output
b) The installer failed because the USB drive could not be found for lack of a USB driver
c) The installer actually needs to wait for block devices because for example USB devices might show up late
These are all fixed as of current main.

With the above issues fixed, we can now boot on an HP Z420 workstation (which was one of the platforms that didn't work before).

It now works on all machines it originally didn't so closing this. We can open new platform-specific issues if they aries.


[Feature Request] Better DoT Analysis/Feedback

I don't know how feasible this doing all of this would be, but it would be nice if the following changes to various DoT tracking happened:

Be raid buff aware (some early rewrites are a gain if snapshotting an expiring raid buff/pot)
Express loss of potency around the actual loss (alternative instant/ at most 2 GCDs lost by early rewrite (there + if the fight timing would require an additional refresh as a result)
Be movement aware for jobs where DoTs are a potential movement option (likely the hardest since this requires per-fight knowledge of which sections are movement heavy and accounting for alternative movement options which might be available)

Two examples specific to healers that I'm aware
Scholar: Rewriting Bio early isn't a loss of Bio time, but a loss of either ruin II and/or 1-2 broils (iv) depending on if it needed to be used for movement or not. An early rewrite where the rewrite is less than 13s early but snapshots a soon to be expiring raid buff/pot is a gain. (This 13s amount is an estimate, not accounting for which raid buffs and specific to lv 90 potencies)
WHM: rewriting Dia early for movement isn't a loss of Dia potency, but glare potency, and may still sometimes be correct for movement sections depending on the amount rewritten, raid buff snapshotting, and availability of misery (the last one covered in #602 )
I'm sure there are many other examples, but I'm hesitant to point to anything without more concrete knowledge. If this should be handled strictly per job and not be generalized, it may be worth turning this into a tracking issue for each job that should need this sort of scrutiny on DoTs but idk how much of this makes sense to generalize/not as that's a question of maintainability tradeoffs and how much of the logic would actually be shared.

We usually operate in a vacuum for job analysis so it's more nobody has bothered writing anything for raid buffs. This would likely be highly job dependent as well since potency isn't static, and neither are the tradeoffs.
The core dots module that most jobs use tracks average clips per second so we have no context as to the GCD, which is only verifiably accurate for the player actually parsing. Movement isn't something we have any visibility on though, and is also highly job dependent not to mention fight specific.  As we analyse for the general case, this is our usual response to niche optimisations but super common ones (ie over 50% of players) are often supported.
Interesting request but I'm not sure what we can do about it. Leaving open since some parts are possibly viable.


Add twitter card metadata

This fixes #432.
Summary

Added an og:type property.
From https://developer.twitter.com/en/docs/twitter-for-websites/cards/overview/markup,

A Twitter Summary card can be rendered if an og:type, og:title and og:description exist but not twitter:card, but I ended up also adding required Twitter meta tags for robustness.
added Twitter meta tags required to render a Summary Card w/ Image

Testing Requirements?
I am going to run the generated preview against the Twitter Card Validator.
I hope the validator can test the preview website

In a follow-up, I'd like to see us take a screenshot of the final message, and upload that along with the chat when we share, and we could use it as our image.  For now, no image is fine.

Tested Twitter meta tags in shared chat, https://rjwignar-issue-432.console-overthinker-dev.pages.dev/api/share/chatcraft_dev/BD3ThijHaa5gfs51H0JEN, against Twitter Card validator and it passes:

Here's what it looks like in the Tweet Composer (using summary_large_image):

In a follow-up, I'd like to see us take a screenshot of the final message, and upload that along with the chat when we share, and we could use it as our image. For now, no image is fine.

TODO in followup: Modify twitter:image meta tags to use screenshot of final message.


Cleanup: Moving files from src/Microsoft.AspNet.Mvc.Razor/Razor/PreCompi...

...leViews ->
src/Microsoft.AspNet.Mvc.Razor/Precompilation

Should the namespaces be updated to reflect the path? Namespaces are supposed to match paths (they didn't before the file move, but they should match if we're cleaning this up).

They are all in the same namespace Microsoft.AspNet.Mvc.Razor and don't use the folder hierarchy for namespacing. I could change that too - although we have precedence against having folder based namespaces in other code in Mvc \ Razor.
The primary motivation for doing this change was to remove things that were nested two layers deep.

These should use folder hierarchy as namespace hierarchy. Why would we make an exception here? If it's too many files in a folder, then it's too many files in the namespace.

We've been using folders to keep projects logically segmented without actually namespacing them accordingly. For instance:

https://github.com/aspnet/Mvc/blob/dev/src/Microsoft.AspNet.Mvc.Core/ActionConstraints/ActionConstraintContext.cs#L7
https://github.com/aspnet/Mvc/blob/dev/src/Microsoft.AspNet.Mvc.ModelBinding/Binders/ArrayModelBinder.cs#L8
https://github.com/aspnet/Mvc/blob/dev/src/Microsoft.AspNet.Mvc.Razor/Compilation/CompilationResult.cs#L8

Should I file a separate bug to update all of these \ move them to the root directory if we don't want to namespace based on folder hierarchy?

Just fix the one at hand now. The other ones are also just wrong :smile: Can file a bug on the other ones and we'll deal with it later.

:ok:

Updated.

:shipit:


Web: provide a user data provider through API

Today the user data provider in web is added from within the workbench. With the new src/vs/code/browser/workbench/web.main.ts it should rather be provided through the official API, in the same way as url callback provider and credentials provider are in there already.

I think this can be closed now?


Update localization modal & FAQ text + increase info icon size

Context/Issue Link
https://github.com/participedia/api/issues/924

looks great!


Media uploads

This issue is reserved for saving any media used in this repo (avoids committing any large files or binaries)


Fix create_bucket tests as per new bucket naming conventions

As per amazon s3 spec -
https://docs.aws.amazon.com/awscloudtrail/latest/userguide/cloudtrail-s3-bucket-naming-requirements.html
The s3 bucket names should not contain upper case letters or underscore.
Name cannot end with dash or have consecutive periods, or dashes adjacent to periods
Name length shouldn't exceed 63 characters.
These rules are being enforced via

https://github.com/ceph/ceph/pull/26787

This patch is to update the respective testcases as well.
Signed-off-by: Soumya Koduri<EMAIL_ADDRESS>

@cbodley @alimaredia .. kindly review the changes.


Add ssl to server

Coverage decreased (-0.3%) to 61.785% when pulling bc01a674189365b53f5329a9f1a9079a311f6ef4 on cpacia:master into a464fa10e07c266da12443883679893e5a3ecb87 on OpenBazaar:master.


Using multithreading from tutorial doesnt seem to work

General information:

emcee version: 3.1.6
platform: Windows/VS code/Jupyter Notebook
installation method (pip/conda/source/other?): pip install

Problem description:
Expected behavior:
Should run mcmc sampler and make run-time shorter
Actual behavior:
Code cell continues running and does not seem to make sampler run-time any shorter
What have you tried so far?:
changing threads/core/nwalkers
Minimal example:
with Pool() as pool:
sampler2 = mc.EnsembleSampler(nwalkers=10, ndim=4, log_prob_fn=ln_pdf2, args = [], pool = pool)
sampler2.run_mcmc(starts2, 1000, progress = True)
14m 20.3s and counting...

import emcee

# sample code goes here...

with Pool() as pool:
    sampler2 = mc.EnsembleSampler(nwalkers=10, ndim=4, log_prob_fn=ln_pdf2, args = [], pool = pool)
    sampler2.run_mcmc(starts2, 1000, progress = True)

Not needed anymore.


Restrict shader compilation error lines range and remove unnecessary files output

Closes #85419
This PR restricts shader compilation error lines to limited amount of lines and remove unnecessary files output(usually .gdshaderinc files which not related to the error line) instead of just throw all of the lines in shader files, which is annoying when writing shaders with several large .gdshaderinc files included.
↓↓↓↓↓↓↓↓↓ [Before] 29k+ log output just because of a single simple redefinition of function name

↓↓↓↓↓↓↓↓↓ [After] limited range to only lines near the error line, and removed unrelated included files output

Fixed some issue and rebased, now it should pass the checks.


Support popular benchmarks

Currently, users of deepeval can only create their own evaluation dataset/test cases. The support more users fine-tuning their model, deepeval should be able to import standard benchmarks such as MMLU, hellaswag, TruthfulQA, Big Bench, etc.
Comment or DM on discord to discuss more: https://discord.com/invite/a3K9c8GRGt

+1. A paved path for generating metrics/scores covered by Open LLM Leaderboard and LLM Safety Leaderboard (and maybe a few others) can be a great bonus for the framework

@rohinish404 We're trying to support multiple popular benchmarks for users to have instant access to through deepeval. TruthfulQA is a popular and also extremely easy to integrate: https://github.com/sylinrl/TruthfulQA/blob/main/data/v0/TruthfulQA.csv
If users can just have access to truthfulQA like this:
from deepeval.benchmarks import TruthfulQA

truthful_qa = TruthfulQA()
truthful_qa.evaluate(...)

In .benchmarks:
from deepeval.dataset import EvaluationDataset

class TruthfulQA(EvaluationDataset):
    pass

Does this make sense to you?

@rohinish404 We're trying to support multiple popular benchmarks for users to have instant access to through deepeval. TruthfulQA is a popular and also extremely easy to integrate: https://github.com/sylinrl/TruthfulQA/blob/main/data/v0/TruthfulQA.csv
If users can just have access to truthfulQA like this:
from deepeval.benchmarks import TruthfulQA

truthful_qa = TruthfulQA()
truthful_qa.evaluate(...)

In .benchmarks:
from deepeval.dataset import EvaluationDataset

class TruthfulQA(EvaluationDataset):
    pass

Does this make sense to you?

Yup let me have a look at the codebase and then will ask further in discord.


Client is not Send

Is it intentional that coremidi::Client is not Send?
    = help: within `common::MidiInput`, the trait `std::marker::Send` is not implemented for `*mut std::boxed::Box<(dyn for<'r> std::ops::FnMut(&'r backend::coremidi::coremidi::Notification) + 'static)>`
    = note: required because it appears within the type `backend::coremidi::coremidi::BoxedCallback<backend::coremidi::coremidi::Notification>`
    = note: required because it appears within the type `backend::coremidi::coremidi::Client`
    = note: required because it appears within the type `backend::coremidi::MidiInput`

I was not able to find any information regarding the thread safety of MIDIClientRef, but I also don't know about thread-safety in the macOS APIs in general ...
I had users of midir complain that some structs are not Send, so I'm trying to implement Send for everything, but of course I want to know whether it's actually safe ...

Hi @Boddlnagg, when I implemented this lib for the first time, I was just onboarding that side of rust. I think that it would require a re-visit. I might look at how PortAudio handles this case and also read about thread safety for the CoreMIDI SDK.
As you can see, my response time is quite sparse, so please let me know what your expectations would be around this work, and whether you could help me or not, so I can plan myself accordingly ;-)

Hi @chris-zen, thanks for your reply, and I understand that you don't have a lot of spare time for this project. It's fine.
I think the implementation would be trivial once it's clear whether marking Client as Send is actually safe. From my own (limited) understanding, I would guess that it would be safe, because Send just means that you would be able to use a MIDIClientRef from a different thread than the one you created it on. This is a much weaker guarantee than saying that it's safe to use from multiple threads at the same time concurrently.
I haven't been able to find documentation about this so far. I only found this, which claims that the CoreMIDI API is not thread-safe at all, and any call to a CoreMIDI API needs to be synchronized by the caller. But I can't really believe that (I would expect that separate MIDIClientRefs could at least be used concurrently within the respective thread that created them). If that statement were true, then this crate would already be unsafe because no one prevents the user from calling coremidi::Client::new from different threads concurrently.
It would be great to find someone who knows more about all this ... the public documentation doesn't really help much, unfortunately.
It probably won't help much to look into other CoreMIDI wrappers (such as PortMidi), because the guarantee that Send makes is one that is usually not made explicit anywhere (in other languages apart from Rust). It might just be that we find that this guarantee is implicitly relied upon in some library code, which would strengthen my confidence that it's safe/correct.

Hi @Boddlnagg, after reading the CoreMIDI documentation from Apple, I found this sentence here that makes me think that we are safe to use Send:

The Core MIDI framework uses IPC (interprocess communication) to communicate with a server process, the MIDI server. The server process in turn loads, and manages all communication with, the MIDI driver.
I interpret it as the clients just getting opaque handlers to objects created and managed in a central process (the CoreMIDI server), where every call from the client translates into IPC messages to it. My assumption is that it doesn't matter from what process or thread do the messages come from, as the server will take care of their ordering and dispatching.
So I personally don't see any problem to use Send.
Now the question is what changes are required in this crate. Do you have a clear idea ? are you willing to prepare a PR ? or at least to tell me which objects require Send ?

This sounds great!
The specific errors that I get are this:
error[E0277]: `*mut std::boxed::Box<(dyn for<'r> std::ops::FnMut(&'r backend::coremidi::coremidi::Notification) + 'static)>` cannot be sent between threads safely
   --> src/common.rs:242:9
    |
242 |         is_send::<MidiInput>();
    |         ^^^^^^^^^^^^^^^^^^^^ `*mut std::boxed::Box<(dyn for<'r> std::ops::FnMut(&'r backend::coremidi::coremidi::Notification) + 'static)>` cannot be sent between threads safely
    |
    = help: within `common::MidiInput`, the trait `std::marker::Send` is not implemented for `*mut std::boxed::Box<(dyn for<'r> std::ops::FnMut(&'r backend::coremidi::coremidi::Notification) + 'static)>`
    = note: required because it appears within the type `backend::coremidi::coremidi::BoxedCallback<backend::coremidi::coremidi::Notification>`
    = note: required because it appears within the type `backend::coremidi::coremidi::Client`
    = note: required because it appears within the type `backend::coremidi::MidiInput`
    = note: required because it appears within the type `common::MidiInput`
note: required by `common::tests::test_trait_impls::is_send`
   --> src/common.rs:240:9
    |
240 |         fn is_send<T: Send>() {}
    |         ^^^^^^^^^^^^^^^^^^^^^

error[E0277]: `*mut std::boxed::Box<(dyn for<'r> std::ops::FnMut(&'r backend::coremidi::coremidi::Notification) + 'static)>` cannot be sent between threads safely
   --> src/common.rs:243:9
    |
243 |         is_send::<MidiInputConnection<()>>();
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ `*mut std::boxed::Box<(dyn for<'r> std::ops::FnMut(&'r backend::coremidi::coremidi::Notification) + 'static)>` cannot be sent between threads safely
    |
    = help: within `common::MidiInputConnection<()>`, the trait `std::marker::Send` is not implemented for `*mut std::boxed::Box<(dyn for<'r> std::ops::FnMut(&'r backend::coremidi::coremidi::Notification) + 'static)>`
    = note: required because it appears within the type `backend::coremidi::coremidi::BoxedCallback<backend::coremidi::coremidi::Notification>`
    = note: required because it appears within the type `backend::coremidi::coremidi::Client`
    = note: required because it appears within the type `backend::coremidi::MidiInputConnection<()>`
    = note: required because it appears within the type `common::MidiInputConnection<()>`
note: required by `common::tests::test_trait_impls::is_send`
   --> src/common.rs:240:9
    |
240 |         fn is_send<T: Send>() {}
    |         ^^^^^^^^^^^^^^^^^^^^^

error[E0277]: `*mut std::boxed::Box<(dyn for<'r> std::ops::FnMut(&'r backend::coremidi::coremidi::PacketList) + 'static)>` cannot be sent between threads safely
   --> src/common.rs:243:9
    |
243 |         is_send::<MidiInputConnection<()>>();
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ `*mut std::boxed::Box<(dyn for<'r> std::ops::FnMut(&'r backend::coremidi::coremidi::PacketList) + 'static)>` cannot be sent between threads safely
    |
    = help: within `common::MidiInputConnection<()>`, the trait `std::marker::Send` is not implemented for `*mut std::boxed::Box<(dyn for<'r> std::ops::FnMut(&'r backend::coremidi::coremidi::PacketList) + 'static)>`
    = note: required because it appears within the type `backend::coremidi::coremidi::BoxedCallback<backend::coremidi::coremidi::PacketList>`
    = note: required because it appears within the type `backend::coremidi::coremidi::InputPort`
    = note: required because it appears within the type `backend::coremidi::InputConnectionDetails`
    = note: required because it appears within the type `backend::coremidi::MidiInputConnection<()>`
    = note: required because it appears within the type `common::MidiInputConnection<()>`
note: required by `common::tests::test_trait_impls::is_send`
   --> src/common.rs:240:9
    |
240 |         fn is_send<T: Send>() {}
    |         ^^^^^^^^^^^^^^^^^^^^^

error[E0277]: `*mut std::boxed::Box<(dyn for<'r> std::ops::FnMut(&'r backend::coremidi::coremidi::Notification) + 'static)>` cannot be sent between threads safely
   --> src/common.rs:245:9
    |
245 |         is_send::<MidiOutput>();
    |         ^^^^^^^^^^^^^^^^^^^^^ `*mut std::boxed::Box<(dyn for<'r> std::ops::FnMut(&'r backend::coremidi::coremidi::Notification) + 'static)>` cannot be sent between threads safely
    |
    = help: within `common::MidiOutput`, the trait `std::marker::Send` is not implemented for `*mut std::boxed::Box<(dyn for<'r> std::ops::FnMut(&'r backend::coremidi::coremidi::Notification) + 'static)>`
    = note: required because it appears within the type `backend::coremidi::coremidi::BoxedCallback<backend::coremidi::coremidi::Notification>`
    = note: required because it appears within the type `backend::coremidi::coremidi::Client`
    = note: required because it appears within the type `backend::coremidi::MidiOutput`
    = note: required because it appears within the type `common::MidiOutput`
note: required by `common::tests::test_trait_impls::is_send`
   --> src/common.rs:240:9
    |
240 |         fn is_send<T: Send>() {}
    |         ^^^^^^^^^^^^^^^^^^^^^

error: aborting due to 4 previous errors

This means that coremidi::Client and coremidi::InputPort need to be Send.
You can easily test this by just defining a simple function and calling it:
fn is_send<T: Send>() {}
is_send::<Client>();
is_send::<InputPort>();

However, after looking at the above errors again, I realize that the problem might not actually be the Core MIDI types, but the BoxedCallback. Since the callback function in BoxedCallback::new requires a Send bound, I think that BoxedCallback itself can also be made Send, simply by unsafe impl<T> Send for BoxedCallback<T> {}, but I'm not 100% sure ...

I see you are available now. I also have some time available now. Would you like we to pair and try to implement this together ? or else could you tell me what code are you compiling so I can reproduce those errors ?

I'm not really available, but I can point you to the code:
The build that's failing is this Pull Request: https://github.com/Boddlnagg/midir/pull/38 (see also https://dev.azure.com/Boddlnagg/b5ee628a-e54a-4a1c-90af-0a24d4ecd7d6/_build/results?buildId=25)
It's just asserting that midir::MidiInput is Send, which currently fails for the coremidi backend.

Looking into this again, because I'm still bitten by it ... (https://github.com/Boddlnagg/midir/pull/38 fails to build)
I think my previous assesment is correct: All that's needed is a
unsafe impl<T> Send for BoxedCallback<T> {}

in lib.rs (which is safe because there's a F: Send bound on the boxed function).
I would open a pull request if I had a macOS machine to try it ...

@Boddlnagg please, could you review ?
Please note that Travis takes care of the build for MacOS, so you don't need to have a MacOS to test things ;-)

@Boddlnagg
coremidi = "0.4.0"
😉


puppet 4 support

I just noticed that #36 also proposes to fix the lint warnings.  However, I'd claim that using control comments is a slightly better approach.

:bow:

:raised_hands:


Ion-option-button, swipe left-right?

How can i use "Share" button with left-right swipe
< ion-option-button class="button-positive">Share'
and "Edit" button for right-left swipe
< ion-option-button class="button-assertive">Edit
?

is there any answer / clue for this issue?


View statement support

Thank you for your great PR ! I'll see this later .

I only commented on one point, but the others look good. Awesome !!

thanks for reviewing @goccy, I've pushed https://github.com/goccy/go-zetasqlite/pull/85/commits/65985ff19e0e010f0389bedc0aa08b08d29e57aa with the function rename.
Regards,

LGTM !


New version: ImageMagick.ImageMagick.Q8 version <IP_ADDRESS>

Created by 🥟 Dumplings in workflow run #6901.

Log
Updated: <IP_ADDRESS> → <IP_ADDRESS>
No ReleaseTime and ReleaseNotes (en-US) for version <IP_ADDRESS>
Submitting WinGet manifests
Creating manifests
Uploading manifests and making commits
The manifests for the last version <IP_ADDRESS> will be removed. Reason: This task is configured to remove the last version
Creating a pull request

Microsoft Reviewers: Open in CodeFlow

/azp run

@stephengillie Could you approve this PR?

https://github.com/microsoft/winget-pkgs/issues/142854

Sorry for so much trouble with these.


Format error in JSON body: data did not match any variant of untagged enum VectorStruct

python lib qdrant-client raises an error when upserting sparse vector
Current Behavior
the traceback is like the following
UnexpectedResponse                        Traceback (most recent call last)
Cell In[17], line 1
----> 1 qclient.upsert(
2     collection_name=collection_name,
3     points=[
4         models.PointStruct(
5             id=1,
6             payload={'metadata': 'metadata'},
7             vector={
8                 # 'default_dense': [1.] * 1024,
9                 'text': models.SparseVector(
10                     indices=[],
11                     values=[],
12                 ),
13             },
14         )
15         # for text, sparse_dict, dense_vec in zip(
16         #     hypo_answers_original[:100],
17         #     # sparse_emb_answers['lexical_weights'],
18         #     dense_emb_answers['dense_vecs'][:100],
19         #     dense_emb_answers['dense_vecs'][:100],
20         # )
21     ]
22 )
File ~/miniconda3/envs/general/lib/python3.8/site-packages/qdrant_client/qdrant_client.py:1349, in QdrantClient.upsert(self, collection_name, points, wait, ordering, shard_key_selector, **kwargs)
1321 """
1322 Update or insert a new point into the collection.
1323
(...)
1345     Operation Result(UpdateResult)
1346 """
1347 assert len(kwargs) == 0, f"Unknown arguments: {list(kwargs.keys())}"
-> 1349 return self._client.upsert(
1350     collection_name=collection_name,
1351     points=points,
1352     wait=wait,
1353     ordering=ordering,
1354     shard_key_selector=shard_key_selector,
1355     **kwargs,
1356 )
File ~/miniconda3/envs/general/lib/python3.8/site-packages/qdrant_client/qdrant_remote.py:1756, in QdrantRemote.upsert(self, collection_name, points, wait, ordering, shard_key_selector, **kwargs)
1753 if isinstance(points, models.Batch):
1754     points = models.PointsBatch(batch=points, shard_key=shard_key_selector)
-> 1756 http_result = self.openapi_client.points_api.upsert_points(
1757     collection_name=collection_name,
1758     wait=wait,
1759     point_insert_operations=points,
1760     ordering=ordering,
1761 ).result
1762 assert http_result is not None, "Upsert returned None result"
1763 return http_result
File ~/miniconda3/envs/general/lib/python3.8/site-packages/qdrant_client/http/api/points_api.py:1667, in SyncPointsApi.upsert_points(self, collection_name, wait, ordering, point_insert_operations)
1657 def upsert_points(
1658     self,
1659     collection_name: str,
(...)
1662     point_insert_operations: m.PointInsertOperations = None,
1663 ) -> m.InlineResponse2006:
1664     """
1665     Perform insert + updates on points. If point with given ID already exists - it will be overwritten.
1666     """
-> 1667     return self._build_for_upsert_points(
1668         collection_name=collection_name,
1669         wait=wait,
1670         ordering=ordering,
1671         point_insert_operations=point_insert_operations,
1672     )
File ~/miniconda3/envs/general/lib/python3.8/site-packages/qdrant_client/http/api/points_api.py:852, in _PointsApi.build_for_upsert_points(self, collection_name, wait, ordering, point_insert_operations)
850 if "Content-Type" not in headers:
851     headers["Content-Type"] = "application/json"
--> 852 return self.api_client.request(
853     type=m.InlineResponse2006,
854     method="PUT",
855     url="/collections/{collection_name}/points",
856     headers=headers if headers else None,
857     path_params=path_params,
858     params=query_params,
859     content=body,
860 )
File ~/miniconda3/envs/general/lib/python3.8/site-packages/qdrant_client/http/api_client.py:79, in ApiClient.request(self, type_, method, url, path_params, **kwargs)
77     kwargs["timeout"] = int(kwargs["params"]["timeout"])
78 request = self.client.build_request(method, url, **kwargs)
---> 79 return self.send(request, type)
File ~/miniconda3/envs/general/lib/python3.8/site-packages/qdrant_client/http/api_client.py:102, in ApiClient.send(self, request, type_)
100     except ValidationError as e:
101         raise ResponseHandlingException(e)
--> 102 raise UnexpectedResponse.for_response(response)
UnexpectedResponse: Unexpected Response: 400 (Bad Request)
Raw response content:
b'{"status":{"error":"Format error in JSON body: data did not match any variant of untagged enum VectorStruct at line 1 column 63"},"time":0.0}'
Steps to Reproduce

Setup conda env with python 3.8 or 3.10 (both tried and error found), qdrant clinet version 1.7 and 1.10 and 1.11 tried (all failed)
Setup qdrant docker container with sudo docker run -d -p 6333:6333 -v qdrant_data:/qdrant/storage:z qdrant/qdrant
Create a qdrant collection with the following code

qclient = QdrantClient(url="http://localhost:6333")
collection_name = 'test_multiple_vectors'
qclient.recreate_collection(
    collection_name=collection_name,
    vectors_config={
        'default_dense': models.VectorParams(size=1024, distance=models.Distance.COSINE)
    },
    sparse_vectors_config={
        "text": models.SparseVectorParams(index=models.SparseIndexParams(on_disk=False))
    },
)

upsert with the following code

qclient.upsert(
    collection_name=collection_name,
    points=[
        models.PointStruct(
            id=1,
            vector={
                'text': models.SparseVector(
                    indices=[1, 3, ],
                    values=[0.1 0.3, ],
                ),
            },
        )

Possible Solution
Tried making a new conda env but still got an error

Update: with the qdrant clinet created like the following:
client = QdrantClient(':memory'), all the things works

hi @achillesliu,
could you please tell us which qdrant version you are using?
unfortunately, we could not reproduce the issue

@DhavalArGEP hi, could you please try out qdrant-client 1.11.1 and qdrant at least 1.10 (better 1.11.1)
Unfortunately, we could not reproduce it ourselves

@joein with qdrant-client 1.11.1 also I am facing the same issue.

@DhavalArGEP is it reproducible with the code provided in the issue, or could you maybe provide your own?

@joein I am not able to provide code as it is used in my organization. But the same code is working on windows platform but not on Linux (I am using Docker).

@DhavalArGEP can you create a minimal reproducible example? Not exactly the same code you use, but the one which is enough for pinpointing the issue
Could you also tell us the version of qdrant you are using?

This issue got resolved by upgrading qdrant-client and sentence-transformer packages to a latest version. Thank you.


Added python implementation for GeLU

Refer #1114

Pardon my noob mistakes here. I'll try to be more careful.

Pardon my noob mistakes here. I'll try to be more careful.

No worries, it won't appear in the master branch because we squash the commits before merging.
If you want to know how to open multiple pull requests in a clean way, you can refer to the document we mention in the CONTRIBUTING: https://github.com/gabrieldemarmiesse/getting_started_open_source


README - keep them in app/reflexes

Tiny tweak to readme about recommended location of reflex class files.

CI failed for unrelated reasons. Could you kick it to start again plz?


[BUG] KHMS servers will give a 404 error after sending too many requests—this will cause map tiles to not load properly during a long flight.

I definitely appreciate and find usefulness with the patch you implemented to help with load-bearing between the servers—thank you!
The servers will respond with an empty request if you send too many requests to the KHMS map servers within a short period of time. They seem to be happening to those servers only, because they do not happen virtually at all if MT(№) servers are used in lieu. Perhaps using MT servers should work better at the moment until a workaround is issued?

Thanks for feedback. I will let user still select servers and add a feature to load from random server to do load balance.

Sounds great for now, thanks for your work on this mod!

I got this today also mid flight through somewhere in the african sahara (I think thats where I was )
Downloading from: https://khms2.google.com/kh/v=908?x=282272&y=230679&z=19 {'https': ''}
<IP_ADDRESS> - - [10/Dec/2021 23:29:27] "GET /tiles/akh1222100131210120222.jpeg?n=z&g=9590 HTTP/1.0" 404 -
Does it mean google doesn't have that particular tile, should the proxy revert to bing in that case or? On screen I could see some strange squares for sure, so I guess it was these tiles that showed the 404.

I got this today also mid flight through somewhere in the african sahara (I think thats where I was )
Downloading from: https://khms2.google.com/kh/v=908?x=282272&y=230679&z=19 {'https': ''} <IP_ADDRESS> - - [10/Dec/2021 23:29:27] "GET /tiles/akh1222100131210120222.jpeg?n=z&g=9590 HTTP/1.0" 404 -
Does it mean google doesn't have that particular tile, should the proxy revert to bing in that case or? On screen I could see some strange squares for sure, so I guess it was these tiles that showed the 404.

IIRC, Google should use an upscaled tile of the same source, even though there is no native resolution for the zoom level. Since you were also using the KHMS servers (the ones where the bug only happens), I believe you did get rate-limited. If you have the latest version, you can select the MT servers from the Map Server tab.

Ah great, the latest version / release, doesn't seem to have a Map Server tab, so I guess when thats released I will try that. Is that server not rate limited or is it the tool swapping between different servers to avoid the rate limit?

Ah great, the latest version / release, doesn't seem to have a Map Server tab, so I guess when thats released I will try that. Is that server not rate limited or is it the tool swapping between different servers to avoid the rate limit?

The MT servers don't have the rate limiting issue since it's more lenient on the number of requests. Funnily, from what I have tried from before, even using a singular MT server didn't trigger any rate-limiting measures on my part.
The latest version should have the tab, are you sure you're using the 2.3.4 version from 2021-12-04? (You may need to delete your entire old directory and reinstall with the new version.)

Ahh, I kept overwriting my old dir contents with the latest release to keep things like the cache, obviously this doesn't work so well. A clean directory works great. I'll try the mt server. Should it be the default, as its currently not?

Ahh, I kept overwriting my old dir contents with the latest release to keep things like the cache, obviously this doesn't work so well. A clean directory works great. I'll try the mt server. Should it be the default, as its currently not?

At the moment, the app uses the KHMS servers by default (you'll have to go to the tab to change it to MT first), probably for performance reasons so the MT servers serve as a backup. I'm not the dev, so it's possible the default selection would change in a future release :>
By the way, the newest version no longer uses the built-in caching function, since MSFS's built-in rolling cache feature already serves the same purpose and having a separate one would already be redundant.

Ah OK so we should turn back on the msfs rolling cache, and it would be caching the google maps I guess as thats whats coming into it via the proxy, great.


Benchmark

from http://mollyrocket.com/meowhash:

It’s the fastest hash function we know of by a factor of at least 3.

ok that is great - but what are we comparing it against
would be nice to see what the competitors are and/or what the methodology was
thanks

@pjanx Meow is a Non-cryptographic hash function, so SipHash is not comparable
http://wikipedia.org/wiki/List_of_hash_functions#Non-cryptographic_hash_functions

@cup It is still a hash function and up for comparison, if only for curiosity reasons.

@pjanx no, its not. a sensible list would include non-crypto functions, and popular crypto functions - SipHash is neither.

SipHash is not a fast hash function, so it's not a particularly useful datapoint.  Their "faster version of SipHash" is HighwayHash and it is only 4 bytes per cycle.  Meow hash is 16 bytes per cycle, or roughly 4 times faster in cache.  Out of cache, Meow still wins, but it gets slowed down to memory throughput speed, which varies per CPU so it's hard to quote a particular number.  Modern CPUs can usually deliver memory faster than 4 bytes per cycle, though, so Meow typically still beats 4bpc hashes like Highway et al.

here are some that might be worth comparing

http://github.com/google/highwayhash
http://github.com/jandrewrogers/MetroHash
http://github.com/lemire/rollinghashcpp
http://github.com/leo-yuriev/t1ha

https://github.com/jandrewrogers/MetroHash/issues/7

https://github.com/lemire/rollinghashcpp/issues/9

https://github.com/cmuratori/meow_hash/issues/1
https://github.com/jandrewrogers/MetroHash/issues/7
https://github.com/lemire/rollinghashcpp/issues/9

Really not sure what you're asking for here, because all of these hashes post statistics, as does Meow.  But to summarize, Meow is much faster than everything you posted, and it generates larger hashes as well.  In most cases you can tell that just from reading the web pages you posted :)  Again, Meow is 16 bytes/cycle for up to 512-bit hash.  The hashes you posted all generate smaller hashes at less bytes per cycle.  How much slower they are depends on how big of a hash you ask them to make, because most of them get slower for larger hash outputs, while Meow does not (it is the same speed for any hash size up to 512 bits).

https://github.com/rurban/smhasher/issues/28


support gRPC Wait For Ready

There should be a gax.CallOption called WaitForReady, such that WaitForReady(true) is grpc.FailFast(false), and vice versa.
See https://github.com/grpc/grpc/blob/master/doc/wait-for-ready.md.

Fixed by addition to gax.CallOption


When migrating from version 1.7.* to 1.8.* of getdown

you need to account for the fact that getdown has been refactored into various
modules. For clarity on the subject, see https://github.com/threerings/getdown/wiki/Migrating-from-1.7-to-1.8
Updating to version 1.8.2 of getdown in the pom.
Copying the correct artifact: 'com.threerings.getdown:getdown-launcher' instead of 'com.threerings:getdown'

#7


Add stencil guide holes

No-cost way to ensure stencil is aligned for reflow soldering. 2.6mm diameter holes that accept 2.5mm metal dowels near opposite ends of the board and set as paste layer. Would align to 10mm hole grid drilled in some flat frame.

Added


[bug] unified_inventory / 3d_armor crash

This started happening about 1 hour ago or so, but I'm in the process of updating all 181 mods in the "worldmods" directory (in alphabetic order), so maybe its a mismatch between 3d_armor and unified_inventory?
2022-01-15 00:02:15: ERROR[Main]: ServerError: AsyncErr: ServerThread::run Lua: Runtime error from mod 'unified_inventory' in callback on_playerReceiveFields(): ...worlds/world/wor
ldmods/3d_armor/3d_armor_ui/init.lua:41: attempt to call field 'make_inv_img_grid' (a nil value)
2022-01-15 00:02:15: ERROR[Main]: stack traceback:
2022-01-15 00:02:15: ERROR[Main]:       ...worlds/world/worldmods/3d_armor/3d_armor_ui/init.lua:41: in function 'get_formspec'
2022-01-15 00:02:15: ERROR[Main]:       ...orlds/world/worldmods/unified_inventory/internal.lua:84: in function 'get_formspec'
2022-01-15 00:02:15: ERROR[Main]:       ...orlds/world/worldmods/unified_inventory/internal.lua:269: in function 'set_inventory_formspec'
2022-01-15 00:02:15: ERROR[Main]:       .../../worlds/world/worldmods/unified_inventory/api.lua:298: in function 'action'
2022-01-15 00:02:15: ERROR[Main]:       ...rlds/world/worldmods/unified_inventory/callbacks.lua:74: in function '?'
2022-01-15 00:02:15: ERROR[Main]:       /home/container/bin/../builtin/game/register.lua:449: in function </home/container/bin/../builtin/game/register.lua:433>

I found a forum post about this exact problem. sfan5 said that the solution was to update Unified Inventory.
But then OP said that grabbing both mods from https://github.com/pandorabox-io/pandorabox-mods fixed the issue for him.

Both mods are current as of ~14 hours ago.  I'll close this issue in a few days if there are no further crashes similar to it.

Based on @Bituvo's research and the lack of any further crashing with these sypmtoms, I'm declaring this issue resolved.  @Bituvo thank you for your time!


changed quick sort

I am creating a pull request for...

[ ] New algorithm
[ ] Update to an algorithm
[ ] Fix an error
[ ] Other - Describe below

This PR adds no value.


SBT 1.1.0-M1 compatibility issues

I tried out the SBT 1.1.0-M1 and they are enforcing that all AttributteKey(key:string,description:String)'s key need to start with a lowercase letter.
There is a offending attribute declaration at https://github.com/Tapad/sbt-docker-compose/blob/8a8fa066da94cbf686164a72387deab5fcfd7be5/src/main/scala/com/tapad/docker/DockerComposeKeys.scala#L28
Could you take a look at this?

Hi @andrezimmermann - Thanks for reporting this compatibility issue with SBT 1.1.0-M1.
I believe that I have fixed the root cause and have released a 1.0.30-SNAPSHOT version with the update. Please try it out and let me know if it works for you so that I can get the changes into the master branch and included in the next official release.
resolvers += "Sonatype Snapshots" at "https://oss.sonatype.org/content/repositories/snapshots/"
addSbtPlugin("com.tapad" % "sbt-docker-compose" % "1.0.30-SNAPSHOT")

Sorry for the late reply, is working fine with the SNAPSHOP, thanks!

Hi @andrezimmermann - I've included the fix in an official release:
addSbtPlugin("com.tapad" % "sbt-docker-compose" % "1.0.30")
Thanks again for using the plugin and reporting this issue!


Supporting oracle database 19c EE on linux arm64 platforms

This PR is for supporting oracle database 19c EE on linux arm64 platforms.

does this mean we're going to se an aarch64 image on container-registry.oracle.com?  Because that would really be the bees knees.

@lscoughlin
it is already available
container-registry.oracle.com/database/enterprise:<IP_ADDRESS>

is there any plan to support this on RAC? OracleDatabase/RAC/*/dockerfiles/buildContainerImage.sh

@yunus-qureshi is there also anything for the express/free edition?


limitation

Need to let users know this limitation
the code is using datavolume 4 which is 5,000 data points. However, due to the shape of the data, and whether there are blank intersections, the data limit can be lower. Also, the datasource may not have statistics or dynamic limits may not be enabled, which does lead to lower actual counts in some cases.

Hi @phobag - is there a particular article you had in mind when making this suggestion? Thanks!

Hi @mgblythe these docs below. This limitation is for shape maps
https://docs.microsoft.com/en-us/power-bi/visuals/desktop-shape-map
https://docs.microsoft.com/en-us/power-bi/visuals/power-bi-data-points
just need to let user know that the Point is 5,000 and that depending on the datasoure and shape this can lower the limitation for the points

Thanks @phobag, I assigned to the author for review.

Hi @phobag ,
I've checked with the shape map PM. The maximum, for now, is 1,500 data points.  The visual is still in Preview and this limitation may increase when the visual comes out of Preview.
Thank you for your question.


Delegate for when the menu is dismissed

I want to be able to do something in my implementation when the menu is dismissed. In my particular scenario, I'm changing the background color of a row when the button to display the menu is clicked and reverting the color when the menu is dismissed by tapping anywhere (seems to be the 'SingleTap' event). It's possible that this functionality is already available and maybe I'm missing something so let me know.

You can use the notification on dismiss!

Hi,
You can use the notification on dismiss!
Can you please detail a bit on how to do this ?
Thanks


How can I show sub command help?

    desc 'Describe test here'
    arg_name 'Describe arguments to test here'
    command :test do |c|
      c.action do |global_options,options,args|
        puts "test command ran"
      end

      c.desc 'Test sub command t1'
      c.command :t1 do |t1|
        t1.action do |global_options,options,args|
          puts "t1 ran"
        end
      end

      c.desc 'Test sub command t2'
      c.command :t2 do |t2|
        t2.action do |global_options,options,args|
          puts "t2 ran"
        end
      end
    end

How can I show help for Test?

> my_app help test # should show help for the test commands
> my_app help test t2 # should show help for the t2 command

Ok, I get it. Thank you!

So my_app help test --help displays the help for the test command.
Why doesn't my_app help test t2 --help show help for test t2?

The intention was that my_app help test t2 would be sufficient.  --help in that second context would be interpreted as a command line flag for the t2 subcommand which, if not implemented, may result in an error.


[Bug] Bar3D: Axis labels are not displaying correctly if label text is lengthy.

Version
5.5.1
Link to Minimal Reproduction
https://echarts.apache.org/examples/en/editor.html?c=bar3d-dataset&gl=1&code=CQOg5gpgLgFAUAAgQJQPKoCoH0AKBBDACQQGoEByAegBMBDKWy2gZ2ehvsYBsBLAMwgBaCAA8ADhADGDAHaSAnoIYAjLhBAArZgHsZ5ADSIEfAK5yoPXQhh0GASgQBvI0lu0EAXgQBtON_IAknLaALYQBhQAMvwQCACi4lKyChHkONpiJlz0lnr6FADC2mZQAE7yqQCaELSl5AC6ht4AHACMAKz5AMwALCAADJ0IXe2t_a09-eR4JsxltLzugghQABaxksUyZfIIAO6rPJKr-1YBBQUIkqVHANbQp6Vc1IKSJmLG2qXGPABusRYwswIq1mv1-o0_K0uhNugBOfIANh67XaACZEVMgtQeEsVusrlsdvtDsdTjIEOdLtc7g89l9nq93p9vlB6SseECQWCIU04c0hl00d00a1EQB2drjLpTOIyMDZGTUBDLNYbInlElHE70ilUq43ST3KCPRlvD58L4IXQAznhfKg8H1OD1ADcLmtYgsVi8ziQ_oQYBu1C6ABEAFxOAC-hgDSCg2m0XAsYkjjhjHqQIjwIh4zDDacz_qg8gkkfIknoEDAXwqRYzcYQ8hzeYLTiL8dLEHLlag1dr5HrsbjAC8W_mI9HhwHfnmTAsALK0VPtxtIEK0ESR1oQZrTuM4sIyZi5cvpTLZb16IdFtxsKCFtcIQ8QY-5ZiR3xPpCBYJhAwdv65DRAI8SJNItByBU-6NmkGRZDkugAd-hQatBgFII4CAyLQYTltUtQRCWZYUF8OI4Vw5AIFGgGQk-OgmKUkjds-nA3o2bA3BAH4-IBfrfsRLHkMotRhsh36UJQCDMPIITKEmADKPAjixMlyYpykQDBcbMKstDkWA5bZHJEClFA4lPq-mzUCx_EoVuFAEXU2mNvI5ZFCU5QWd-I7liBsQJBIEFQd5T4JkmKafv0Dr5MKwz5D0zooTRT4pXGSX-lG7oBiE8gFHpZkgPeqBerkMAZFedjZdRcBVUAA
Steps to Reproduce
I have created a bar3D chart which has scope axis labels as lengthy (as available in attached link), axis labels are not showing completely and after certain display of text it is shown as enlarged format.

Current Behavior
After certain length of the text it is shown in enlarged form.
Expected Behavior
Axis label text should show completely.
Environment
- OS: Windows
- Browser: Chrome (Version 131.0.6778.140 (Official Build) (64-bit))
- Framework:Angular

Any additional comments?
No response

in latest v.5.6.0 long, truncated axis labels support tooltips.
Demo.      Alas, this does not apply to 3D axes...


NetUtil should be able to handle -Djava.net.preferIPv6Addresses=syste…

…m without logging an error
Motivation:
Since java11 its supported to use "system" as a value for -Djava.net.preferIPv6Addresses.
Modifications:
Just fallback to "false" if -Djava.net.preferIPv6Addresses is not "true" without logging an error
Result:
Fixes https://github.com/netty/netty/issues/13300

@chrisvest maybe I just missed this but why is "system" == true ?

That's what it looked like here, but I could also be misunderstanding: https://github.com/openjdk/jdk11/blob/master/src/java.base/share/classes/java/net/Inet6AddressImpl.java#L107
I haven't analyzed the full scope of how that is used, so maybe just ignore me.

@chrisvest I think this is a different use-case. Let me just merge it as it is


investigate and fix correlation id was not found

Interactsh version:

main | dev
Current Behavior:

interactsh client randomly exits with fatal error

  [FTL] The correlation id was not found (probably evicted due to inactivity)

https://github.com/projectdiscovery/interactsh/pull/524 temporarily fixes the issue by not exiting and only printing but the actual error is different . This is not reproducible in local machines but almost always visible in gh actions . probably something related to runners ?
Ref: https://github.com/projectdiscovery/nuclei/actions/runs/4600751855/jobs/8127749422

Expected Behavior:

no error + no fatal exit

Anything else:

https://github.com/projectdiscovery/nuclei/issues/3507

Hi there, I received this issue this morning when using Nuclei Action. Do we have a rough idea when this issue will be resolved? Thanks

@hakrishi  , are you able to reproduce this with latest nuclei version https://github.com/projectdiscovery/nuclei/releases/tag/v2.9.2 .  partial fix is already included in latest release of nuclei and it will be fully resolved with https://github.com/projectdiscovery/interactsh/pull/531

Hey @tarunKoyalwar I ran an a scan and did not encounter this issue. I'll do some further testing over the next few weeks. Thanks!

the error is still thrown

After some further testing I am receiving this issue for all scans. (see screenshot attached)

Hi team, unfortunately I am still encountering this issue:
[ERR] The correlation id was not found (probably evicted due to inactivity): could not get correlation-id from cache

I am currently running v1.2.2 and my setup is through Docker:
sudo docker run -d projectdiscovery/interactsh-client:latest -token "XXX"

I am running Nuclei version 3.3.0.


Merge: Patch TaskExtensions bug in Azure.Messaging.EventHubs (#14333)

Contributes: https://github.com/Azure/azure-sdk-for-net/issues/14304

/check-enforcer override


Configurable events

Inspired by the closing of #9 yesterday (and particularly the mention that recently Google seems to have fixed API support for non-birthday events), I checked that the API had in fact been fixed (it has!), and then I did a big refactor to configurably handle birthdays and anniversaries, and custom events (potentially more than one per contact, which required looping) with added labels per custom event. It has been running nicely for me under various test-runs (in English and Greek). I am very aware that @GioBonvi said

...I want to keep this project focused on birthdays only to avoid unnecessary complications for inexperienced users.

but I wanted this functionality for my own use anyway (even more than the birthday functionality). Therefore - now that the API handles it - I did these changes and made them as non-invasive as possible from the user-perspective (if users don't edit the default eventTypes array under OPTIONAL CUSTOMIZATION then it should behave the same as before, with the exception of some more generic wording in titles, to make sense for more than just birthdays). @GioBonvi I am posting the changes in this PR because:

When you see how nice (and non-invasive for users) it is you might change your mind :-)
I did a few other unrelated commits along the way which you will probably want either way. If you want them but not the non-birthday refactor commits then let me know which ones you want and I will rebase and PR them separately - I didn't wan't to spend time on that though until I was sure you don't want to just use all my commits as is.

If you want to include these changes then perhaps the repo could afford another rename (e.g. GoogleBirthdayNotifier -> GoogleContactsEventsNotifier) at some point, but before that maybe the changes should stay in a non-master ("devel"?) branch for a while until other translators have caught up with rewordings. If you don't want to include the non-birthday functionality I will maintain my changes as a patch-fork in my own repo, called GoogleContactsEventsNotifier.

Hello @rowanthorpe, it's nice to hear from you again!
I've rapidly skimmed over your code and from what I could see you've done an oustdanding work - as usual ;-)
However, in these days I don't have the time to thoroughly analyze it and don't want to take hasty decisions, so I'll have to park this PR for now.
I will get back to you as soon as I manage to finish my exams, which should mean a week or so.
Thank you again!

OK, no rush. Good luck with the exams.

Hi, I was away from internet for a few days, but am back now, so will get a chance to look at this and make changes hopefully tomorrow, or the day after at the latest :-)

I just rebased the branch to address all the changes you suggested. For the naming of the calendar in the comments I used a wording which I think strikes a balance between "most likely default name" and "making it clear it might have a non-default name anyway". Of course if I missed something, made any presumptions you don't like, or need to do more changes, let me know.

Does GitHub let you change the target branch for this PR form master to my repository's/configurable-events?
Otherwise I'll merge manually.

Yes, I just changed the target branch as requested.


Array.ConstrainedCopy() fails on copying Int32Enum[] to int[].

Works on CoreCLR.

https://github.com/dotnet/corert/pull/3400


Site has been made converted to PWA (Fixes issue #312)

I have made the website into a PWA now you can install the site on your mobile or laptop and can see it along with other applications. Now, the site can even run offline.
Fixes issue #312
Screenshot

@ShivanshAr97 Do the following:

Fix merge conflicts
Delete the .vscode folder

__        Summary: 🛠 This code needs a fix

Done


Initial release

This is the first release of the vscode extension.
Functionality-wise the plugins offers references, definitions and folding ranges.
Development-wise there are linting rules, unit tests and documentation in place.

I've tried, super-cool! Great job!
Some notes:

[ ] The %, @ are not ctrl-clickable. This makes it hard to navigate through %5 (you can only click on the 5).
[ ] The underlying when you press Ctrl seems wrong, it splits over . while it shouldn't.

Ctrl+click works properly though!

I've fixed all the issued outline in this comment

If I click on "Find references" for %0 on handle_sigsegv' I get *all* the references of all the %0s instead of only those in handle_sigsegv`.
All the other limitations seem fixed.

References are now fixed, there was a badly-expressed condition that caused all the variables to be put in the global namespace.

Merged in 392422f. Thanks!
Great job.


[Improvement][Datasource]clear warning

Purpose of the pull request
clear idea warning
Brief change log
add @Override
Verify this pull request
This pull request is code cleanup without any test coverage.

Codecov Report

Merging #9200 (2402ae8) into dev (e00727c) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev    #9200      +/-   ##
============================================
- Coverage     40.21%   40.20%   -0.01%
+ Complexity     4375     4374       -1
============================================
  Files           817      817
  Lines         32676    32676
  Branches       3637     3637
============================================
- Hits          13140    13139       -1
  Misses        18306    18306
- Partials       1230     1231       +1

Impacted Files
Coverage Δ

...ugin/datasource/oracle/OracleDataSourceClient.java
0.00% <ø> (ø)

...er/master/dispatch/host/assign/RandomSelector.java
77.77% <0.00%> (-5.56%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e00727c...2402ae8. Read the comment docs.


Change default JLink protocol to SWD

LGTM! Thanks!

This fails now on my JLink (onboard Hifive Revision B board), which only supports JTAG:
Error processing command: An error with the usage of the probe occured: An error specific to a  probe type occured: device is missing capabilities (SELECT_IF) for operation

Maybe we should just not change the protocol, if nothing is specified? Meaning if self.protocol is none.

Never mind, it's broken on master as well. If this improves things for you, we can merge this.

It definitely improves, thanks!


test: use new browser context for every page test

What does this win us?

What does this win us?

this drastically reduces chances of tests collapsing when running parallel
dogfoods browsercontexts the way we want them to be used
simplifies the dance around service workers / cookies setting up and tiering down .

How does it effect tests running in parallel? Weren't parallel tests always in their own browser?

How does it effect tests running in parallel? Weren't parallel tests always in their own browser?

Ah, you're right. Cross-out the first bullet then

Accidentally closed this; re-opened as #3010.


Add support to PT (portuguese) language

@naldomadeira  if you have a moment, could you review document?

@pedrovgs Revised document without comments.

Sorry for the delay @tiagobarreto. A friend of mine has been reviewing the translation :) As the translation seems to be correct I'm merging this PR.

@pedrovgs no problem, @pedrovgs. thanks ;)


Fix absolute local image check

Images and other local resources referenced by absolute paths such as /images/bg.jpg are being reported as missing.

I think this might address issue 130.


[config] remove "project"; add "name" and "description"

The top-level config directive project is unused. It is also confusing because its name suggests that other directives (e.g. targets) should be nested beneath it.
Let's kill it and add the top-level directives name and description:-

add Project.name and Project.description to droid-model
parse the directives and set the Project properties, in YamlLoader
display the name and description in the output of the config command

👍 makes total sense


Dev

Example of adding two arbitrary text boxes to the connection dialog and using the values in the connection builder.

Just for clarity's sake on my part, this sample using existing text boxes in new ways, correct?

Yes.

Service is a great example of an arbitrary extension point in the dialog.  Warehouse gets a little trickier longer term.  We likely in the future will want to allow HasWarehouses to be true in the tcd as a part of more flexible metadata enumeration, potentially giving that attribute meaning more globally in the platform.  No objections though.


feat: [DEV-2586] Add frontend package

Task linked: DEV-2584 Credential Service: Setup frontend and LogTo flows for client authentication

Task linked: DEV-2586 Create APIs for managing customer authorisation and remembering the user via a bearer token


Fix calc error from Lexer "Unrecognized text"

This fixes compile error because variables in calc is expected to be wrapped in #{}

This is not a reasonable solution, can check this issue:
https://github.com/NightCatSama/vue-slider-component/issues/640

This issue was fixed in the latest version by removing the calculation.


Developed React Front End with Authentication Per User

I've forked the latest version of the master branch as of today (11/02/2016) and integrated with the serverless-react-boilerplate. Features are:

Writes user data to user table.
Authenticates per user so that one user cannot modify another's data.
Authenticates user before responding with auth token to prevent hacking.

Working demo here: http://sls-react-auth.s3-website-us-east-1.amazonaws.com/ (facebook login only).
See: https://github.com/jcummins54/serverless-react-boilerplate
and https://github.com/jcummins54/serverless-authentication-boilerplate
Would be happy to collaborate to make this a branch here.

Yes, absolutely, I quickly went though the code and these are good changes.
I was thinking to create the users table and then I thought that maybe developers want to choose between different databases, but I guess it is good to create that table, least as an example.

I've made quite a few changes to localize all environment settings into one file, so different deployments can be easily configured and tested. My latest is this branch: https://github.com/jcummins54/serverless-authentication-boilerplate/tree/react-authenticate
which is set up to work with the front end React client from this branch:
https://github.com/99xt/serverless-react-boilerplate/tree/react-authenticate
Changes include:

All environment variables set in authentication/env.yml
Everything pulls its settings from this file including the test suite and the test-token
Modified specs-docker.sh to remove env variables which are no longer needed there. Also, docker was looking for a .env in the root folder, so it creates a blank one and deletes it just to keep docker happy. All environment variables are loaded from authentication/env.yml

Happy to get your feedback.

@jcummins54 Nice, I'll check this later today, could you open a PR? I took a quick look to changes and those would be great additions.

Sure, but take a look at line 19 on the authorizeHandler.js
https://github.com/jcummins54/serverless-authentication-boilerplate/blob/react-authenticate/authentication/lib/handlers/authorizeHandler.js
It's set up to parse a method arn structured specifically like this:
arn:aws:execute-api::://///
I was thinking it would be a good idea to templatize this somehow so it can be configured in the env.yml instead of editing the code.

Is there any plan to collapse these two repositories into a single code base?  Even without the react part but just the other enhancements.
The other thing I'm wondering, my use case is a bit different, I don't want to authenticate users to access API endpoints but I want to do the authentication to fetch the access_token to access the APIs.  As example, getting the access_token from the google authentication so I can access the google apis.
Thanks!


New accounts dont have phone numbers, _is_phone_number receives null and fails

After recent updates, account may not have phone number, sending message to it causes error " Error: Cannot resolve receiver."
INFO:root:[Raw Message] {"envelope":{"source":"d251b237-xxx-xxxx-xxxx-xxxxxxxxxxxx","sourceNumber":null,"sourceUuid":"d251b237-xxx-xxxx-xxxx-xxxxxxxxxxxx","sourceName":"<REDACTED>","sourceDevice":1,"timestamp":1711474552863,"dataMessage":{"timestamp":1711474552863,"message":"Test","expiresInSeconds":0,"viewOnce":false}},"account":"+184xxxxxxxx"}
INFO:root:[Bot] Consumer #1 got new job in 0.00005 seconds
ERROR:root:[PingCommand] Error: Cannot resolve receiver.

Probable fix: adjust function _resolve_receiver with:
def is_valid_uuid(val):
    try:
        uuid.UUID(str(val))
        return True
    except ValueError:
        return False

def _resolve_receiver(self, receiver: str) -> str:
    if is_valid_uuid(receiver):
        return receiver

    if self._is_phone_number(receiver):
        ...

But some other additional in changes bot.py might be needed

This does happen when the user is added through the new "username" feature - ether manually or by QR code.
Which is awesome for a "public" bot service.
have successfully tested this:
diff --git a/signalbot/bot.py b/signalbot/bot.py
index e8c8013..5011119 100644
--- a/signalbot/bot.py
+++ b/signalbot/bot.py
@@ -7,6 +7,7 @@ import traceback
 from typing import Optional, Union, List, Callable
 import re
 import phonenumbers
+import uuid

 from .api import SignalAPI, ReceiveMessagesError
 from .command import Command
@@ -238,6 +239,9 @@ class SignalBot:
         logging.info(f"[Bot] {len(self.groups)} groups detected")

     def _resolve_receiver(self, receiver: str) -> str:
+        if self._is_valid_uuid(receiver):
+            return receiver
+
         if self._is_phone_number(receiver):
             return receiver

@@ -251,6 +255,13 @@ class SignalBot:
         except Exception:
             raise SignalBotError(f"Cannot resolve receiver.")

+    def _is_valid_uuid(self, val):
+        try:
+            uuid.UUID(str(val))
+            return True
+        except ValueError:
+            return False
+
     def _is_phone_number(self, phone_number: str) -> bool:
         try:
             parsed_number = phonenumbers.parse(phone_number, None)

when a message is received via number the UUID is not used.
so maybe it is cleaner as second _resolve_receiver()
@filipre any chance to get this feature any time soon? <3

Hey! Thanks for looking into this. Do you want to open a PR? Then I can create a pre-release for you to test, too.

I can create a PR.
but a pre-release will not help me because i depend on the reid.sadd() feature. ;)
but i can create the PR anyway.
and ill fix my quiet messy and mixed PR for redis.sadd() / redis.smember() as well as phonenumbers functionality.
then ull have it atomic in 4 different PRs.
maybe later this evening.


Begin type parsing

The beginning of type parsing.

cc @ilonatommy

cc @AaronRobinsonMSFT . I succeeded in fixing yesterday's PR (https://github.com/pavelsavara/jsco/pull/24) and now we pass the tests. It does not mean that all the parsing job is done for "type". There's a bunch of paths that I did not cover but I can see that you started implementing them in this PR, e.g. parseAlias. You can continue till this section parser covers all the scenarios or merge the current state with main and choose another section.


Searching for account using Account Number

Don't search whether an account exists or not using the name as there are chances that more than 2 people would be there with the same name.
Try to use an account number as for every new user a new value of the account number would be assigned which would help them to uniquely identify the user.
=>SRAND() can be used to achieve this.

thank you for your suggestion.
I have added account number using randomisation, Now each user will be assigned an 7-digit random and different account number whenever an account is created.
Issue Fixed in #22
Thank You ! Do Star the Repo if you liked it
and Please do share your views and issues on the project your PR's are most welcomed


use<EMAIL_ADDRESS>

🚀 Deployed on https://6500fddfacba6d0e2c292858--cozy-fox-0defec.netlify.app