Add a nuspec and build script to create the package

Note: command-line build doesn't fully work yet, not sure why. MSBuild direct of the sln file fails too.
So to use, build in Release in VS, then you can run the .\build.ps1 script to create the package. It will download nuget for you too, so no need to check that in.
Right now, it's set as Win81 as that's the only thing that'll work for UWP apps.

I've merged your changes into a nuget branch. Because this isn't an UWP package yet, but will show up for 8.1 apps as well, I'm not too keen on publishing this just yet. But this is however an awesome start, so much appreciated!


feat: open modal for the whole page

Modal window state stretched to full page, no mardin, no border radius.  Useful on mobile.

@iapolya Hi, Modal is not supposed to be open in fullscreen by design. It has no "close" element except its overlay. So it won't be possible to close the Modal on mobile device in such scenario. There is a dedicated component for mobile cases - Sheet, which should be used instead


Putting the same resource that already exists should not result in a change

OADA should compute the difference between the put body and the existing result.  Empty diffs should translate into a no-op, not update rev, nor create a change. This would make writing data sync microservices much easier / correct.

I think that would add a decent amount of overhead, especially for larger documents for which you are only updating a small portion.  Maybe it could compare the current body with the current rev's change document instead?  i.e. if it is an exact repeat of the previous change, then it is most likely a duplicate to be discarded?

I think getting the resource and saving a smaller patch is likely to be an overall save on processing as compared to committing an unnecessarily large change document (and, as currently written, committing the same document to the resource node too). It is also much smaller than many watchers GETting the full resource as the result of a small change.  Finally, it seems too early to be worrying about performance over function. As is a common function is quite unfriendly and significantly complicates syncer services.
This should be somewhat "easy" to implement if we use what is already existing. They could be some issues around concurrency. Something like: https://www.npmjs.com/package/fast-json-patch


use the JAVA_BIN environmental variable to allow overriding the jdk at runtime

Similar to the java_binary script we should allow users to override the version of java based on the environment rather than using the runfiles version.

In regards tests i'll try figure that out -- i think we can refer to the extra outputs/override it to be broken as you said and assert that it fails to run with nonsense in the env. The non-set case i think should be covered in the current tests.

@johnynek I think you'll need to do the merge since i don't have the bits. But i've pushed another change you should look at. The action_should_fail tests were actually all broken from the tests i just did locally. the bazel subprocess was invoked as $(bazel ...) not assigning the output of the subprocess to a variable, so bash evaluates it. Since the stdout isn't really a command it always fails with exit code 127 on my mac anyway

Happily i think those tests still worked -- the error in the broken build here looks like a transient download failure from what i can see.

I'm now looking into these lines of code and I'm not sure this was the best choice. This sounds like you get less hemeticity.
Why not use different java_toolchain when running remote builds?

@ittaiz the remote execution bit is special to some experiments(happy to elaborate on these if your interested, but the content of the PR is more general). This change in general is aligning the scala rules to the java rules. The hermetic nature of the build in general won't be effected since that mostly comes via the sandbox we are running in. (And given the java rules obey these env vars if your proxying them one would expect them to effect everything the same?)


Reduce API "point" consumption by only requesting necessary fields

Hello,
With the new PurpleAir API, your account has a balance of 'points' (you start off with 1 million points for free, and have to pay for more after that), and each API request costs a certain number of them.  For example, a request to the https://api.purpleair.com/v1/sensors/[sensor ID here] endpoint costs 1 point for the request, and then 0-2 points per field returned, depending on the fields.  In the request parameters you can specify a list of fields you want returned, otherwise it returns all fields (see API docs).  Since the plugin currently doesn't limit which fields are returned, each request costs 155 points.  That means you can retrieve the data from a sensor only ~6,451 times before you've used all your free points and have to start paying for API usage.  Checking one sensor at the default 5 minute interval, your points would last you less than 23 days.
You can see the request costs in points when you're signed into the PurpleAir developer portal here:
https://develop.purpleair.com/pricing
However by specifying which fields you want returned using the field parameter, the point cost can be reduced substantially.  For example from a quick look through the code I think this plugin only uses pm2.5_10minute, pm2.5_30minute, pm2.5_60minute, pm2.5, pm2.5_cf_1, humidity, and voc, so if you only requested those fields then each request would only cost 15 points.  At that rate the million 'free' would last 10X as long, more than 231 days.
And you could reduce it even further by only requesting the fields necessary for the conversion the configured for the specific sensor.  So for example if you used no conversion, I think only the pm2.5 field is needed, bringing the point cost down to 3 and then your million free points would last <1,157 days.  Quite an improvement from 23!
If I have a chance I'll try to put together a pull request with the necessary changes, but I may have difficulty as I've never worked on a homebridge plugin before.
Thanks,
Ian

Great ideas, will look into this, thanks!

@jmkk Do you have an update on this? With the cost of API calls now, this plugin is almost useless for anyhing besides local IP unless you implement the changes suggested by @mrweir

@mrweir @arcticfoxwpg  Released version 2.1.0 with the change, please verify, thanks!


EVPLs should have a higher priority by default to also support an EPL in the same UNI

This is for an use case in production that @jab1982 was mentioning, currently mef_eline supports an EVPL (vlan-based) and EPL (port-based) in the UNI. However, since the priority of the FlowMods installed via flow_manager isn't being set, they'd have the same priority, which can lead to undefined behavior when the switch will match a flow based on the OpenFlow spec. To support this use case, an initial idea is to have all EVPLs by default using a higher priority by default (500?) that could also be overwritten in the settings, that way regardless of the order an EPL and EVPL is installed, the EVPL will have higher priority flow entries.

@viniarck I think this is already possible through mef_eline's parameter priority. Check the sequence below:

Run kytos using the docker image amlight/kytos:latest
Starts mininet with a basic topology such as tmux new-session -d -s mn mn --topo=linear,3 --controller=remote,ip=<IP_ADDRESS>
Create an EPL between the NNI ports of switch 2, but using priority 1000 for instance.

curl -H 'Content-type: application/json' -X POST http://<IP_ADDRESS>:8181/api/kytos/mef_eline/v2/evc -d '{"name": "my evc1", "dynamic_backup_path": true, "enabled": true, "uni_z": {"interface_id": "00:00:00:00:00:00:00:02:2"}, "uni_a": {"interface_id": "00:00:00:00:00:00:00:02:3"}, "priority": 1000}'

Create two EVPL to connect UNIs Switch1:1 and Switch2:1 using for instance priority 1500:

curl -H 'Content-type: application/json' -X POST http://<IP_ADDRESS>:8181/api/kytos/mef_eline/v2/evc -d '{"name": "my evc1", "dynamic_backup_path": true, "enabled": true, "uni_z": {"tag": {"value": 198, "tag_type": 1}, "interface_id": "00:00:00:00:00:00:00:01:2"}, "uni_a": {"tag": {"value": 198, "tag_type": 1}, "interface_id": "00:00:00:00:00:00:00:01:1"}, "priority": 1500}'
curl -H 'Content-type: application/json' -X POST http://<IP_ADDRESS>:8181/api/kytos/mef_eline/v2/evc -d '{"name": "my evc1", "dynamic_backup_path": true, "enabled": true, "uni_z": {"tag": {"value": 198, "tag_type": 1}, "interface_id": "00:00:00:00:00:00:00:02:2"}, "uni_a": {"tag": {"value": 198, "tag_type": 1}, "interface_id": "00:00:00:00:00:00:00:02:1"}, "priority": 1500}'

Test out connectivity between h1 and h2 (it will work despite the EPL being created first, due to the priorities) and also check the resulting flows.

This will give you what you need from the use case described above. I mean, we can work on having default values for certain types of EVCs, but maybe it is worth discussing again with @jab1982 to use what we already have (especially considering all the effort that this change may require)

@italovalcy, thanks for your comment. Although it's good to know we have this flexibility now and we could use it in the short term, we need a solution that does not rely on users to set the flows' priorities. This will lead to issues in the future. I don't believe users should be allowed to manipulate the low level details of the southbound. In the future, we plan to open the API to the user community and it will lead to confusion. Also, the priority field in the EVC was suppose to describe administrative/business priority (gold, silver, best effort), not substrate priority. MEF E-Line should not accept that a EVPL has a lower priority than a EPL. It will be a lot of effort to fix this but we must do it. @viniarck , another issue to create/discuss is defining/documenting/enforcing the use of substrate priorities just as we did in the BGP Policy for BGP Local Preference.

thanks @italovalcy and @jab1982, sounds like it'll need more refinement, so the original intention is that priority should be related to associating to a QoS queue, right? If it's related to QoS, in addition to refine the requirements, we might also need to try out OFPAT_SET_QUEUE (I haven't found unit tests on python-openflow covering this action yet), and map which queues would be in place and if they haven't been configured yet what the expected behavior would be, ignore the priority or reject, lots of details on this topic. I think we can further refine it on this issue #152 and also map the expected values for priority in the API, and on this current issue here, we only deal with fixing having higher priority flow entries for EVPLs by default, wdyt?

Following up on this thread, I've collected more feedback from Italo and Jeronimo, it would be OK to introduce on settings two default priorities values for EPL and EVPL that should only be used if sb_priority isn't set in the request. The default value could be 1000 for EVPL and 500 for EPL, these variables could be called EPL_SB_PRIORITY and EVPL_SB_PRIORITY or something similar. We also need validations that EVPL_SB_PRIORITY > EPL_SB_PRIORITY during the NApp constructor.


Null exception in deserialize

Hi,
I create a List (150,000 objects) ;
I try to serialize and deserialize but there is a NULL EXCEPTION
            var datas = Trade.Generate(150000);
            var serializer = new CerasSerializer();
            var serialize = serializer.Serialize(datas);
            var deserialize = serializer.Deserialize<List<Trade>>(serialize);

public class Trade
{
    public string Ticker;
    public bool IsValid;
    public DateTime DateAndTime;
    public float Price;
    public uint Size;
    public EExchange Exchange;
    public ETradeCondition Condition;
    public bool HasQuotes;
    public Nbbo Nbbo;

    public Trade() { }
}

public class Quote
{
    public string Ticker;
    public DateTime DateAndTime;
    public float Bid;
    public uint BidSize;
    public EExchange BidExchange;
    public float Ask;
    public uint AskSize;
    public EExchange AskExchange;

    public Quote() { }
}

The serialialization is OK, but in deserialize there is an exception NULL
	public void Deserialize(byte[] buffer, ref int offset, ref TCollection value)
	{
		// How many items?
		var itemCount = SerializerBinary.ReadUInt32(buffer, ref offset);

/////------------------------------------   EXCEPTION, VALUE IS NULL
value.Clear();
/////------------------------------------   EXCEPTION
		for (int i = 0; i < itemCount; i++)
		{
			TItem item = default(TItem);
			_itemFormatter.Deserialize(buffer, ref offset, ref item);
			value.Add(item);
		}
	}

Try the latest commit.
I fixed a issue related to that a few hours ago.
Let me know if it still happens then

Check the nested types. From your earlier post it looks like you also have an EExchange type.
Does that one have a parameterless constructor?
In the meantime I will improve the message so it says what type it is trying to instantiate.

EExchange and ETradeCondition are ENUM

I uploaded a commit for better error messages, it now includes the type name. Try it and let me know what type it cannot construct. :)

System.Exception : 'Cannot create an instance of type 'System.Linq.Enumerable+d__25`1[[TestSerialisation.Trade, TestSerialisation, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null]]''

my bad.
After the first error on the deserializer I decreased the number of objects in the list to be sure it did not come from here.
I forgot to put the ToList ()
Now it's perfect.


Dying in a Create crushing wheel causes softlock crashing

The crash seems to occur when Create mod attempts to crush the gravestone.
Steps to reproduce the behavior:

Set up crushing wheels
Fall in and die

Expected behavior
Game should not crash

OS: Windows
Minecraft Version: 1.18.2
Version: Fabric, 1.3.11

Additional context
Can use another application to delete the grave, so you can load in to your world again. It became a generic grave when I tried to move it, but '/yigd restore' works to restore items.
This may be more of a compatibility thing for create to deal with but I figured I would leave this here, as well as ask if there's something I can do to prevent this from crashing my world again.

Do you have a crash log?

crash-2022-11-15_23.57.02-client.txt
crash-2022-11-15_23.51.53-client.txt
51 is the first crash, 57 was relaunch

Lol I actually think this is for some reason inventory tabs. I've had this reported before but I have no idea where it comes from or why it's thrown. Mighgt look into it at some point if inventory tabs doesn't fix it

Alright figured it out. So inventory tabs tries to add all block entities as inventory tabs, including graves. The mod dev of inventory tabs actually thought of this and added a tag for mod devs to add block entities to that should not be used when generating the tabs.
In other words I've managed to fix this on my end. I'll update the mod in a few days. In the meantime you can add graves to the inventory tabs exclude config if you want to, but I'll let you know as soon as I update

Alright I've updated the mod and now the game should no longer crash when you die, and when using both inventory tabs and yigd. Thanks for reporting this!


Permission error messages should include the name of the model that is invalid

What is the current behavior?
Lets say I have a type name "Item" and I add a permission rule in my graphcool.yml file like this: - operation: Item.*.
Trying to deploy will print an error like this: ✖ unhandled error: Wrong operation defined for ModelPermission. You supplied: '*' since that rule is for relationships, not types.
The error message doesnt really help with debugging since it doesnt say which part of the configuration is failing. If you have a large schema trying to find the invalid rule will mean having to remove rules one by one until the error disappears.
What is the expected behavior?
If the error message would reference the name of the model that is failing, debugging would be a lot easier. Something like this:
✖ unhandled error: Wrong operation defined for ModelPermission. You supplied: 'Item.*'

Great point @joarwilk
Just to add that in the future we will support the wildcard permission for models. We just haven't gotten around to it yet :-)

I'm getting the "Wrong operation defined for ModelPermission" even though the * is only on relations. Any idea what could be going wrong? I know some others on the forums were having this same problem.

can you share a service definition that leads to that error?

We changed the error messages to now return the full operation definition. As proposed we now return Item.* instead of just *. For relations we included the check as well.

Yay, thanks @do4gr


[Backport staging-22.05] pulseaudioFull: fix wrapGApp wrapping, fix vm tests

Description of changes
Backport of #180976.
Backport necessary as it fixes a regression introduced in the 22.05 release (pacmd not working).
I manually tested that core pulseaudio features are still working on my system (audio plyback, bluetooth, pacmd).

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg build pulseaudioFull

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-already-reviewed/2617/596

As the 22.11 release is due soon, no need to backport this anymore.


Switch the tests to mocha

Looks great, except the following is spewing on every test run. Fix that, and it'll be good to merge. Nice work!
npm WARN package.json<EMAIL_ADDRESS>No description
npm WARN package.json<EMAIL_ADDRESS>No repository field.
npm WARN package.json<EMAIL_ADDRESS>No README data

Oh, and squash please.


Add license file for helm-charts

Add license file for helm-charts

cc @yaron2 @msfussell

Closed by #15


[No ticket] Remove unused component

This component is not used.

Need to remove integration test for this as well


Configure the hardware watchdog

Fixed in https://github.com/EdgeNet-project/hardware/commit/22977a60bb839564f5a6f157c56adeb4a961a9b2


Travis CI: Switch to "language: generic"

Switches awway from the default, which is actually "language: ruby". See
https://docs.travis-ci.com/user/languages/minimal-and-generic/
From some testing this looks like it shaves 4 minutes off the total
build, from 1h51m to 1h47m.  Not amazing, but still net positive.
Also drop the "sudo: required" that now is a no-op.

When I last tried removing sudo: required there was a massive performance overhead - like 2x in some cases. But that was many years ago, I'll give it a whirl.
I also see language: minimal that looks like enough for my projects? With these more general CI changes I usually test them on my neil project (https://github.com/ndmitchell/neil) and then roll them out to everyone, so I'll do that first. The changes look like a great idea, and while times vary quite a bit, using the morally right thing in generic/minimal makes me happy.

Yeah the sudo: required and sudo: false thing (aka Virtual-Machine-Based vs. Container-Based Builds), died last year: https://blog.travis-ci.com/2018-11-19-required-linux-infrastructure-migration.    I believe it was on the npm call in the repo-local travis.hs... but now I see an apt-get install` just above it, which has me confused.
I'll push that diff so we can see the failure together here.

I'm debugging this on top of your patch against the server.

Looks like either add:
sudo apt-get install npm
sudo ln -s /usr/bin/nodejs /usr/bin/node

(from https://www.hostingadvice.com/how-to/install-nodejs-ubuntu-14-04/#ubuntu-package-manager)
Or, alternatively (and looks like more officially?): https://nodejs.org/en/download/package-manager/#debian-and-ubuntu-based-linux-distributions-enterprise-linux-fedora-and-snap-packages

I added both of those lines you suggested and then minimal works (I also switched the rest of my Travis files to minimal with great success). There was some fallout in that tslint stopped working (see #717) but that's not a big deal (tslint is useful when I'm actively hacking on the profile stuff, but that's sporadic).
I am unconvinced there are any measurable speed benefits (the times across all my builds are roughly the same), but it's still good hygiene. Thanks!


chore: add codecov

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@63c6bde). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #36   +/-   ##
=========================================
  Coverage          ?   41.76%
=========================================
  Files             ?        3
  Lines             ?      170
  Branches          ?        0
=========================================
  Hits              ?       71
  Misses            ?       76
  Partials          ?       23

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63c6bde...e2ed244. Read the comment docs.

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@63c6bde). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #36   +/-   ##
=========================================
  Coverage          ?   41.76%
=========================================
  Files             ?        3
  Lines             ?      170
  Branches          ?        0
=========================================
  Hits              ?       71
  Misses            ?       76
  Partials          ?       23

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63c6bde...e2ed244. Read the comment docs.


Question on the metric of AUC

It seems to be a little bit confused that the evaluation on classification tasks uses the probabilities output directly in calculating the AUC.
For example, in 6-xgboost.R#L39,
Will it be better to do that with (phat>0.5)?

To calculate AUC you need the probability predictions.


Use layout-independent keycodes where available

Fixes #112
Unlike #113, this is compatible with Edge.

Coverage remained the same at 100.0% when pulling da4f9426c687533a9d54179861348ae73ce889df on depp:keycode2 into 1dd2c5b1a25e2e603016bcd0bb967bf1dc1b6b49 on straker:master.


Version mismatch

The following, although file name says 10.1.0.tar.gz, actually downloads and installs ng-file-upload version 10.0.4:
bower install ng-file-upload -f
bower ng-file-upload#*         resolve git://github.com/danialfarid/angular-file-upload-bower.git#*
bower ng-file-upload#*        download https://github.com/danialfarid/angular-file-upload-bower/archive/10.1.0.tar.gz

@danialfarid, is that some Github cache issue or an incorrect version was built into these archives?

It seems fine on the githuhb: https://github.com/danialfarid/ng-file-upload-bower/releases

Fixed at 10.1.2


[WIP] Apollo 2 SSR

See https://github.com/VulcanJS/Vulcan/issues/2081

Merged as I can now have the example-forms to work as expected.


Could not build the tvOS target (Missing Bitcode)

I added ObjectMapper using Carthage.
The command carthage build --platform tvOS doesn't work because the tvOS target doesn't have ENABLE_BITCODE defined
Other targets build fine.

I am not experiencing this issue. Also, I do not see the "Enable Bitcode" flag in the tvOS target. Let me know if this is still a problem for you.


ERROR rendering  PNGs in parralel for dash

I just made an Test-dashboard, which only contains a Text-Panel. Exporting it to PDF gives me a blank page with the following error:
error rendering PNGs in parralel for dash {Title:test Description: VariableValues: Rows:[] Panels:[{Id:1 Type:text Title:Panel Title GridPos:{H:8 W:12 X:0 Y:0}}]}: error getting panel {Id:1 Type:text Title:Panel Title GridPos:{H:8 W:12 X:0 Y:0}}: Error obtaining render: 500 Internal Server Error
Is this a known issue? Or are there any fixes already?
grafana version: 9.5.3

Is it possible that the reporter is not compatible with Grafana Version 9.5.x ?
I still couldnt find a fix. Some panels just cant get rendered.
Error obtaining render for panel {Id:18 Type:stat Title: date - time GridPos: {H:2 W:6 X:7 Y:8}}, Status: 500, Retrying after 10s...
Error obtaining render for panel {Id:15 Type:volkov-echarts-panel Title: diameter GridPos: {H:8 W:13 X:0 Y:10}}, Status: 500, Retrying after 10s...
Error obtaining render for panel {Id:9 Type:gauge Title: GridPos: {H:7 W:4 X:0 Y:18}}, Status: 500, Retrying after 10s...
Error obtaining render for panel {Id:11 Type:gauge Title: GridPos: {H:7 W:4 X:4 Y:18}}, Status: 500, Retrying after 10s...
Error obtaining render for panel {Id:6 Type:histogram Title: GridPos: {H:7 W:5 X:8 Y:18}}, Status: 500, Retrying after 10s...

Hey @fruchtee, I'm observing the same issue with Grafana 9.x. Did you manage to solve this?

No I did not find any solution for this. Did you find a fix?

@fruchtee yeah, in my case it was related with my machine, some missing libraries. You could check your logs (Grafana logs) for more information, it helped me a lot.

Hi @markoshorro I am actually not finding any missing libraries. Which do you had to add?

here is the solution: https://github.com/grafana/grafana-image-renderer/issues/159

HI everyone I've found the solution
error come from this problem

check  Grafana log
you may seen error from plugin.grafana-image-renderer like this

logger=plugin.grafana-image-renderer t=2024-04-09T06:11:56.802277104Z level=error msg="Render request failed" url="http://localhost:3000/d-solo/{you dash board uid}/_?from=now-1h&height=500&panelId=29&theme=light&to=now&width=1000&render=1" error="Error: Failed to launch the browser process!\n/var/lib/grafana/plugins/grafana-image-renderer/chrome/linux-124.0.6351.0/chrome-linux64/chrome: error while loading shared libraries: libgbm.so.1: cannot open shared object file: No such file or directory\n\n\nTROUBLESHOOTING: https://pptr.dev/troubleshooting\n"

The log told you that you need mechanism for allocating buffers for graphics rendering.

Install libgbm
Following this command

sudo apt-get update
sudo apt-get install -y libgbm-dev

Restart grafana service and grafana-report then try again.


Automated Package Upgrade

:tada: This PR is included in version 2.2.124 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Fix 31 issues

I have been studying this repository for a long time, and whenever I come across a typo, I fix it.
I discovered 31 typos in a total of 29 files. Then I merged them together.
The code quality is exceptionally high, so sincerely hope my PR can help make this repository more standardized.

We don't accept typo fixes directly, but thank you for your contribution.


feat: support code actions

This is some tweaks to the seemingly stagnant PR: #253
Depends on flix/flix#6134
Fixes #233

@sockmaster27 Looks reasonable to me. Does it work with your compiler extension?
(Once everything works, I will have to do the following: Create a new Flix release, then I can merge this PR, and then I can create a new VSCode release).

@magnus-madsen
Yes, I've superficially tested it with the sample in CodeActionProvider.scala (inserting text at the start), multiple code actions and zero code actions.


Get rid of RemoteSessionFactory

Please review only

Restarted the build, as the failure was in a test with a 60 SECONDS timeout. The author at least had the decency to use caps lock for the time unit ;)
 QueueBoundsTest.requireThatFullIntermediateQueueBlocksAndUnblocks:183->assertResultQueueSize:274 Queue never reached size 4 before timeout of 60 SECONDS. Size now: 0


Fix memory leaks

This PR addresses: https://github.com/reactivestack/cookies/issues/191
I refactored the withCookies component to fire this.listen on componentDidMount and componentDidUpdate instead of in the render and I moved the Cookie consumer to wrap the whole component

Finished the refactor

Awesome! Will be in v3.0.7


Explore more training and tutorials link broken

I'm getting a 404 error when clicking the "more training and tutorials" link in step 4.
Thanks!
[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d8177d07-3c8a-00df-8d8e-36dd2e1b1f1b
Version Independent ID: 7f07f6f0-819a-a78d-33f3-9dba1e8e1a88
Content: Understand calling in Microsoft Teams - Microsoft Teams
Content Source: Teams/Tutorial-Calling-in-Teams.yml
Service: msteams
GitHub Login: @LolaJacobsen
Microsoft Alias: tbinder

@ryanhelmer thank you for pointing this out and helping to improve Microsoft Docs. Would it be helpful to replace the current link with this one - https://docs.microsoft.com/microsoftteams/itadmin-readiness#technical-training ?


Discriminated union type in order to be able to write exception free code in f#

In order to be able to write code that you can easily consume that does not throw an exception. @wastaz mentioned that chessie declares:
type Result<'TSuccess, 'TMessage> =
    | Ok of 'TSuccess * 'TMessage list
    | Bad of 'TMessage list

hi @wallymathieu, the requests of new features are tracked in https://fslang.uservoice.com/ not the github repo, can you open a new suggestion there? /cc @dsyme
Btw this repo is for cross platform packaging, the contributions to f# library/tools/compiler are managed in https://github.com/Microsoft/visualfsharp

@enricosada the signature of the Result type looks better. I've added the suggestion: https://fslang.uservoice.com/forums/245727-f-language/suggestions/9484395-discriminated-union-type-in-order-to-be-able-to-wr


Cannot Update My Packages

I've logged into the new system to try to update one of my packages. It shows that I am logged in and that these are my packages, but there is no menu or interface to administer them. What's happening here?

Even worse, while updating through the legacy site I get a I/O error (send request) error, and from setup.py, I get error: Upload failed (410): Gone (This API has been deprecated and removed from legacy PyPI in favor of using the APIs available in the new PyPI.org implementation of PyPI (located at https://pypi.org/). For more information about migrating your use of this API to PyPI.org, please see https://packaging.python.org/guides/migrating-to-pypi-org/#uploading. For more information about the sunsetting of this API, please see https://mail.python.org/pipermail/distutils-sig/2017-June/030766.html)
This is a small nightmare.

Can anybody explain to me what's happening with these issues? I need to update a package that a lot of people depend on and right now I can't.

I've logged into the new system to try to update one of my packages. It shows that I am logged in and that these are my packages, but there is no menu or interface to administer them. What's happening here?

The index at https://pypi.org/ is a pre-production deployment of Warehouse. Work on making Warehouse have feature-parity with the legacy index is currently in progress, and thus it is essentially view-only, so any "administrative" edits still need to be done through the legacy index here: https://pypi.python.org/

Even worse, while updating through the legacy site I get a I/O error (send request) error

I'm assuming here you mean the index at https://pypi.python.org/. I'm not as familiar with the legacy code base, the right place to report a specific issue with it is here: https://github.com/pypa/pypi-legacy

and from setup.py, I get error: Upload failed (410): Gone

I'm not exactly sure what command you ran to produce this, but I'm guessing it was python setup.py upload. You should take a look at the links the error messages provide, which describe that uploading to the legacy API (powered by pypi-legacy) has been sunsetted, and you should migrate to using the new API (powered by warehouse):

How to migrate to the new API: https://packaging.python.org/guides/migrating-to-pypi-org/#uploading
More information about the sunset: https://mail.python.org/pipermail/distutils-sig/2017-June/030766.html

I'm going to close this issue as it seems to simply be a case of confusion, and there doesn't seem to be anything more actionable on it beyond what @di has already mentioned.


[Dashboard] Fix: MAU date range

Fixes CNCT-2185

PR-Codex overview
This PR focuses on updating the date range for fetching in-app wallet usage statistics from the start of the current month to the last 30 days, improving the relevance of the data displayed.
Detailed summary

In layout.tsx:

Changed from date in getInAppWalletUsage from the start of the current month to 30 days ago using subDays.

In header.tsx:

Updated from date in getInAppWalletUsage similarly to 30 days ago with subDays.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Merge activity

Nov 1, 9:14 PM EDT: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.


Make background color the same over whole page

I'm submitting a...

[ ] Bug report
[X] Feature request/enhancement
[ ] Documentation issue or request

Current behavior
Background color of body element is slightly different from the div with class jumbotron.
Expected behavior
If background color of body and jumbotron are the same, the site may look more visually appealing.
Minimal reproduction of the problem with instructions
Visible when viewed in browser.
If this is a feature request please fill out the following:

As a user:
I want: The site to have the same background color throughout.
So that: The site may look even better!

## Environment

Browser:
- [X] Chrome (desktop) version 69.0
- [ ] Chrome (Android) version XX
- [ ] Chrome (iOS) version XX
- [X] Firefox version 62.0
- [X] Safari (desktop) version 12.0
- [ ] Safari (iOS) version XX
- [ ] IE version XX
- [ ] Edge version XX

I will be submitting a PR for this shortly!

I'm realizing now that the dual colors are probably intentional, so feel free to ignore this issue and associated PR if that's the case!

Looked through closed PRs and saw that the dual-colors was an intentional design decision.  Closing this issue and associated PR!


Update Mesos interface install

Update the Mesos interface install in the Scale Dockerfile:
Install mesos.interface >=0.28,<0.29 in the dev_win.txt, build_linux.txt, and prod_linux.txt requirement files
Build Mesos egg for 0.28 (need to figure out how we get these, do we build them ourselves?)
Make sure that the final built image connects to Mesos and runs correctly (perform a full integration test) before creating a PR.

OBE... We don't need native interface anymore.


Buttons fro split panel

What feature or improvement do you think would benefit Files?
Hotkeys for split panel is not usable and we cannot remove split by hotkeys - need buttons on a panel
Requirements
2 Buttons:
split\unsplit vertically
split\unsplit horizontally
Files Version
<IP_ADDRESS>
Windows Version
10.0.22631.3958
Comments
No response

Thanks for the feedback.
There're buttons for it at the top right of tabs. Can you check if those are what you're looking for?

Cannot yfind any suitable button for show\hide this

alt+shift+v only show second panel\view - and cannot hide it

You can only hide active pane via Ctrl+Shift+W and you can switch focus via Ctrl+Shift+Right Arrow or Left arrow

Will be usefull if it will be like in KDE's show\hide button + hotkey

Hotkeys for split panel is not usable

You can customize the key bindings from the Actions page in Settings, have you tried this yet?

hotkey didnot hide, if panel already shows.
it's not about bad keys - it's about user experience.
pressing hotkey - it's good, but visible button for pressing with mouse with one hand - more usable.

Got it! We don’t have plans for that at the moment, but we’re always keeping an eye on feedback and might adjust our plans in the future. In the meantime, could you help us out by confirming if you were able to assign a custom key binding?

yes - i can. binding works,

Thanks! And as I mentioned, we'll be watching for further feedback on this topic and will adjust our plans if/when interest picks up.

Does the Close Pane button, not do what you are asking?

@mdtauk I'm sure that it does, but it sounds like they wanted an easier to access button.

I'll work on adding the option to the context menu.

https://github.com/user-attachments/assets/a52bc075-5f8f-4b5b-b621-bf0ec1268421
So - from 1 button with 2 functions - hard to realise ?

2_func_button.mp4
So - from 1 button with 2 functions - hard to realise ?

Same as the button to display the information panel of a file?

So - from 1 button with 2 functions - hard to realize ?

Unfortunately it's not as simple as it sounds. The toolbar in Files already has a lot of options, and adding more would make it quite crowded. We’re considering the possibility of allowing users to customize which options are shown on the toolbar, but we don’t have anything to share on that publicly just yet.

2_func_button.mp4
So - from 1 button with 2 functions - hard to realise ?

Same as the button to display the information panel of a file?

On a video - not information. On a video ONE button.
For SHOW and for HIDE second panel.
Instead of holding in memory TWO separate hotkeys.

The context menu with the option to close the panel should also appear when you right-click on the home page, because currently, right-clicking on the home page does nothing.

We're tracking a similar in #14426.


changed page routing so that the landing page renders first

Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
When the page loaded you saw the sign up page first. This change makes it so the landing page is displayed first.
Loom Video
Please paste a link here of a quick loom video walking through what you did in your PR .
https://www.loom.com/share/4d454d7a18cb453f98177f8d85c61ae8
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] This change requires a documentation update

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have removed unnecessary comments/console logs from my code
[x] I have made corresponding changes to the documentation if necessary (optional)
[x] My changes generate no new warnings
[x] I have checked my code and corrected any misspellings
[x] No duplicate code left within changed files
[x] Size of pull request kept to a minimum
[ ] Pull request description clearly describes changes made & motivations for said changes

This change was very important, the first thing the user should see is the landing page. Awesome job


chore: move hash inside user operation

This PR refactors user operation structs into three structs:

UserOperation (hash + canonical user operation)
UserOperationSigned (canonical user operation)
UserOperationRequest (user operation with some optional fields, used for RPC estimateUserOperationGas)

@zsluedem Addressed the comment


Add size checker when replication messages return

What changed?
Add size checker when replication messages return

Why?
If the size is above the grpc config, drop some messages.

How did you test it?

Potential risks

Release notes

Documentation Changes

Pull Request Test Coverage Report for Build 4de1c475-d193-4db5-88e0-b1a5c1d000e9

13 of 35 (37.14%)  changed or added relevant lines in 3 files are covered.
46 unchanged lines in 8 files lost coverage.
Overall coverage increased (+0.05%) to 56.548%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

common/rpc/factory.go
5
6
83.33%

client/history/client.go
6
27
22.22%

Files with Coverage Reduction
New Missed Lines
%

client/history/client.go
1
40.56%

service/history/execution/mutable_state_task_refresher.go
1
73.82%

common/task/fifoTaskScheduler.go
2
87.63%

common/task/weightedRoundRobinTaskScheduler.go
2
88.6%

common/cache/lru.go
3
90.73%

common/rpc/factory.go
7
80.0%

common/persistence/nosql/nosqlplugin/cassandra/tasks.go
14
72.8%

common/persistence/nosql/nosqlTaskStore.go
16
58.37%

Totals

Change from base Build 313b222e-f7f9-4814-9e60-f1fab1a88a6c:
0.05%

Covered Lines:
80572

Relevant Lines:
142484

💛  - Coveralls


Call on /register on startup

Is your feature request related to a problem? Please describe.
As per the specification, this project should trigger a POST API call to the /register endpoint of the DBS. After testing using my docker-compose file, it does not do so
Describe the solution you'd like
Upon start-up of the project, the first thing should be to execute the registration call for the storage service to be known and identified.
We should make sure that the call is also triggered every x minutes.

Thanks for pointing out your observations, we  would make the update swiftly

Closing as solved by the last PR


pass hash of event out of ansible event stream

passing just plain old hashes around is less error prone for future
use. E.g. if an event does not have a object1 property it will not
crash the parser.
it also makes it easier to test other parts (e.g. the event parser)
added specs for the event stream
@miq-bot assign @lfu
@miq-bot add_labels refactoring, tests, providers/ansible_tower

@miq-bot add_label test

👍 LGTM
cc @gmcculloug @blomquisg

@miq-bot assign @blomquisg

@durandom this makes it inconsistent with the other providers.  I'm not hugely worried about that because all of the changes are contained within the provider code.

this makes it inconsistent with the other providers.

you mean converting the event to a hash?
At least Amazon and Azure do it too.
This is in preparation to write some specs for the EventParser. Without this, I'd have to craft those Ansible::Model objects coming from the ansible ruby client... but I can also mock those.
And given our latest trouble https://github.com/ManageIQ/manageiq/pull/14297 with them it might be good to confine them 👮 😷


add CI

Add CI with cle-roboto for automatically updating kernels based on CLIc release
Behave identically as the one for pyclesperanto
The CI must be manually trigger for now (as a security)

This PR require to solve the issue:

#23


Add file label for vendor_boot_a/b partitions

This is needed by update_engine during OTA process.
Tracked-On: OAM-112787

Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web  for more details.

Android CI has completed Engineering Build for this issue, build is SUCCESS.To merge the changes please click on APPROVE FOR MERGE button in Android CI WEB


x/website/go.dev: playground snippets in blog posts fail to run

What is the URL of the page with the issue?
The issue seems to appear on  playground code snippets of any article on The Go Blog,  like Strings, bytes, runes and characters in Go
What is your user agent?

Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Firefox/91.0

OS

Linux 5.13.12_1 #1 SMP Wed Aug 18 11:48:14 UTC 2021

What did you expect to see?
Code results output from playground remote server.
What did you see instead?

Error communicating with remote server.
Program exited.

Screenshot

@dmitshur The changes you mentioned can indeed solve the problem
But I found that the problem is：playground.Proxy()
mux.Handle("/compile", playground.Proxy())
(Source:  #cmd/golangorg/server.go#193)
After I debugged with a breakpoint, I found that the expected content could not be obtained through req.Body
So I modified:
r, err := post(ctx, url, req.Header.Get("Content-Type"), req.Body)   ->  r, err := post(ctx, url, req.Header.Get("Content-Type"), strings.NewReader(req.Form.Encode()))
Then it can work normally

I think this issue can be fixed by changing go.dev's playground.js script as follows:
-$.ajax('/compile', {
+$.ajax('https://play.golang.org/compile', {

(Source: go.dev/_content/js/playground.js#L126.)
And adding https://play.golang.org to go.dev Content Security Policy's connect-src field:
 "connect-src": {
 	"'self'",
	"https://golang.org",
+	"https://play.golang.org", // For running playground snippets on the blog.

(Source: cmd/golangorg/csp.go#L44.)

Hi @dmitshur The changes you mentioned can indeed solve the problem, my solution is to solve the problem of the playground.Proxy method


ERROR: cannot find the connection layer fn

Hi, thank you for your great work! However, when I'm trying to train the mesh-vq-vae following README, I get this error message in the terminal: ERROR: cannot find the connection layer fn
I found that in the default config config_autoencoder/config_medium, in modelconv.connection_layer_lst there's pool0-6, unpool0-6, while in the download link here, only pool0-3, unpool0-3 is provided. Could you please check the exact mesh convolutional network config you use in the experiment? Thanks!

Hello,
Thanks a lot for your interest in our work!
There is an error in the link: here is the right data to download for the connections. I will update the README accordingly; thank you for noticing this!


Add browser field to reduce bundle sizes

Set the browser field in the package.json as described here: https://github.com/defunctzombie/package-browser-field-spec to help web targeted builds find the correct version of js-yaml.
Currently when using js-yaml with webpack + prod build, js-yaml takes up 384 KB, 282 of which are due to esprima.

The issue here is that webpack will use index.js as the entry point as default. Similar to #435 this will help webpack find the web version of js-yaml. The difference being that the browser field will not interfere with non web related builds.
See https://webpack.js.org/configuration/resolve/#resolve-mainfields and https://github.com/defunctzombie/package-browser-field-spec for more info.
Here's what js-yaml looks like after setting this in my bundle:

Down to 105 KB.

Adding this would also make CDNs handle the package better. CDNs by default serve the file marked in the browser field of package.json. It would help a lot to make easier for loading dependencies from CDN based on a package's dependency field.

@puzrin I really don't understand your antipathy to such an innocuous change that would greatly help many users of this package. What is the "maintenance burden" here really? It's a single primitive property in the package.json that has only positive effects.

Close in favor of #592


chore: bump heapless and smoltcp

Updates smoltcp, embedded-svc, and heapless to their latest versions (since smoltcp no longer uses heapless 0.7 either)
Note that I have had to add the portable-atomics feature to heapless but that it is also selected on portable_atomic_enum so I assume that this is OK
edit: This needs a new release of embedded-svc. I will update when I get that merged.

Thanks! I think the new release of embedded-svc is scheduled for later this week (or maybe early next week)

These changes have been reflected in the main branch, and subsequently the 0.3 release. Thank you for the PR :).


feat(llms): support ernie chat

Description: support ernie (文心一言) chat model
Related issue: #7990
Dependencies: None
Tag maintainer: @baskaryan

@axiangcoding feel free to ping when it's ready for review!

@baskaryan hi there! PR is ready now. Please review.

looks great, thanks @axiangcoding!


Adding GA API version for Provisioning Services

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information

[x] The title of the PR is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
[x] Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
[x] If applicable, the PR references the bug/issue that it fixes.
[x] Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

[x] I have read the contribution guidelines.
[x] My spec meets the review criteria:

[x] The spec conforms to the Swagger 2.0 specification.
[x] The spec follows the guidelines described in the Swagger checklist document.
[x] Validation tools were run on swagger spec(s) and have all been fixed in this PR.

Looking for review follow up

Note on the following linter errors:
{
"type": "Error",
"code": "DefinitionsPropertiesNamesCamelCase",
"message": "Property named: 'Code', for definition: 'ErrorDetails' must follow camelCase style. Example: 'code'.",
"id": "R3016",
"validationCategory": "RPCViolation",
"providerNamespace": null,
"resourceType": null,
"sources": [
"file:///home/travis/build/Azure/azure-rest-api-specs/specification/provisioningservices/resource-manager/Microsoft.Devices/2017-11-15/iotdps.json:1687:10 ($.definitions.ErrorDetails.properties.Code)"
]
}
{
"type": "Error",
"code": "DefinitionsPropertiesNamesCamelCase",
"message": "Property named: 'HttpStatusCode', for definition: 'ErrorDetails' must follow camelCase style. Example: 'httpStatusCode'.",
"id": "R3016",
"validationCategory": "RPCViolation",
"providerNamespace": null,
"resourceType": null,
"sources": [
"file:///home/travis/build/Azure/azure-rest-api-specs/specification/provisioningservices/resource-manager/Microsoft.Devices/2017-11-15/iotdps.json:1692:10 ($.definitions.ErrorDetails.properties.HttpStatusCode)"
]
}
{
"type": "Error",
"code": "DefinitionsPropertiesNamesCamelCase",
"message": "Property named: 'Message', for definition: 'ErrorDetails' must follow camelCase style. Example: 'message'.",
"id": "R3016",
"validationCategory": "RPCViolation",
"providerNamespace": null,
"resourceType": null,
"sources": [
"file:///home/travis/build/Azure/azure-rest-api-specs/specification/provisioningservices/resource-manager/Microsoft.Devices/2017-11-15/iotdps.json:1697:10 ($.definitions.ErrorDetails.properties.Message)"
]
}
{
"type": "Error",
"code": "DefinitionsPropertiesNamesCamelCase",
"message": "Property named: 'Details', for definition: 'ErrorDetails' must follow camelCase style. Example: 'details'.",
"id": "R3016",
"validationCategory": "RPCViolation",
"providerNamespace": null,
"resourceType": null,
"sources": [
"file:///home/travis/build/Azure/azure-rest-api-specs/specification/provisioningservices/resource-manager/Microsoft.Devices/2017-11-15/iotdps.json:1702:10 ($.definitions.ErrorDetails.properties.Details)"
]
our Resource Provisioning Services is currently tied to out other resource Iot Hubs which uses this casing. We have a backlog item to update this casing across all our resources

No modification for AutorestCI/azure-sdk-for-ruby

No modification for AutorestCI/azure-sdk-for-python

No modification for AutorestCI/azure-sdk-for-node


numbox~

add 'load' to properties
revise the properties tcl/tk code and make lots of comments
hitting enter doesn't work in the properties dialog
add log/power
add sensitivity (when there is a range), make it like a slider
in edit mode, I'd like to have a double arrow in the right edge to set the box width, maybe a corner bottom right diagonal arrow to also set font size.
option to suppress the preceding tilde character
add receive symbol,  show and hide inlet/outlet when in/out of edit mode
calculating the width is not the best thing, it's a wild guess, but seems better than iemguis' nightmare

loads 0 even if out of range

should always set to 'lower' value, but we got 'load', so load should just clip to range


[AutoScheduler] [Docs] [EZ] Update AutoScheduler Docs -- Units for cooldown_interval

I was wondering what unit cooldown interval was so looked it up and wrote it in the docs.

Just re-triggered the CI

Thanks @AndrewZhaoLuo! It’s merged


No Extension Icon on Shelf (Pixel Slate)

name: bionic
encrypted: no
Entering /mnt/stateful_partition/crouton/chroots/bionic...
crouton: version 1-20190902190258~master:9a594a66
release: bionic
architecture: amd64
xmethod: xiwi
targets: xfce,touch,cli-extra,xiwi,audio,keyboard,core
host: version 12607.58.0 (Official Build) stable-channel nocturne
kernel: Linux localhost 4.4.196-16940-geab5e6346fdb #1 SMP PREEMPT Thu Dec 12 22:55:39 PST 2019 x86_64 x86_64 x86_64 GNU/Linux
freon: yes
A minor issue... but when my bionic chroot is running in a chrome window (xiwi) on my Pixel Slate there is no 'C' icon on the shelf. Where it should be there is a small underline to indicate there is something there and the area is clickable but there is no icon. On my old Samsung chromebook there is an icon.
As I say... a minor issue. All else works great, but it would be nice to have the icon back.
(I have removed and reinstalled the extension without success)

I have the same thing on my Samsung CBP running stable Version 79.0.3945.86 (Official Build) (64-bit) Crouton extension version 2.5.2


@sky-mavis/tanto-connect dependency missing in example app

Hey team, the example app is not working at the moment, because @sky-mavis/tanto-connect is missing in package.json.
Steps to reproduce

fork this repo
cd tanto-kit/apps/example/
yarn install
yarn dev
Module not found: Can't resolve '@sky-mavis/tanto-connect'

Steps to fix

yarn add @sky-mavis/tanto-connect

Thanks for reporting this. You can resolve the issue by either:

yarn build at the root of the repo to install the necessary packages.
yarn add @sky-mavis/tanto-connect in the example directory to add the missing package manually.

We’ll update the repo soon. Let us know if you encounter any other issues!


Initialize card component with prefill value

Is your feature request related to a problem? Please describe.
After the user submits invalid card info (wrong expiry date/security code, etc) and the card component gets re-initiazlied, the previous inputs get lost. We want to be able to retain that info so that the user won't need to input everything again.
So basically we need to have a method to listen for the changes of the input data, and also to initialize the card component with prefill values.
Describe the solution you'd like
Describe alternatives you've considered
Additional context

Hi @aJIEw, thanks for the enhancement suggestion. We will discuss this internally but I have the feeling that we cannot offer this functionality. The card component does not provide raw card data because it is not recommended to retain/store card data due to security and compliance reasons.
Maybe tokenization might help you to improve the checkout experience of your customers. The Flutter SDK supports stored (tokenized) cards.

Hello @aJIEw,
after discussing this feature, we cannot offer a method for exposing input data. This would violate compliance policies.
As mentioned and to reduce customer friction, you can use stored cards. For that, please have a look at tokenization for the stored card component.

after discussing this feature, we cannot offer a method for exposing input data. This would violate compliance policies.
As mentioned and to reduce customer friction, you can use stored cards. For that, please have a look at tokenization for the stored card component.

Thanks for the info, we have already implemented the tokenized card payment, this is just a UX improvement we want to have for new card payments, but again thanks for your reply.


Some Problem With Pause Menu

Describe your bug here.
I cant pause when i enter a song with a event "startVideo".
Command Prompt/Terminal logs (if existing)
No response
Are you modding a build from source or with Lua?
Lua
What is your build target?
Windows
Did you edit anything in this build? If so, mention or summarize your changes.
No

in pe 1.0 pre-release


Update pgx/v4 version

This PR is intended to solve the problem that when using pgx/v5 for ent connections, an error occurs when external modules using pgx/v4 library are mixed together.
On the pgx side, this problem has been resolved in v5.3.1 and v4.18.1.
refer:

https://github.com/jackc/pgx/issues/1480
https://github.com/jackc/pgx/compare/v4.18.0...v4.18.1#diff-32dbcc70c656d819ec542b81ab30702bb835f38d8db8c0574c6da16b7ce04b35R88
https://github.com/jackc/pgx/compare/v5.3.0...v5.3.1#diff-32dbcc70c656d819ec542b81ab30702bb835f38d8db8c0574c6da16b7ce04b35R89

I also verified that we could use pgx/v5, but I didn't know the extent of the impact, so I only updated minor version of pgx/v4.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Feature/cax portal@cplp 590 email templates

[x] Move html templates into Mailing.Template project
[x] Rework TemplateSettings and TemplateManager to allow using templates via descriptors (EmailTemplateType enum)
[x] Remove html templates from dependent services' appsettings
[x] Test locally

@fatihayyildiz adding, so that you're informed that mail templates will be managed differently now, templates are moved to the mailing template service and referenced in appsettings.

everything looks good


Export option CSV is missing

Hello,
thank you for this great library,
I tried to add the Exporter option for CSV using the demo code shown at https://apexcharts.github.io/Blazor-ApexCharts/features/export
But it doesn't appear. The only difference is that i am not using YAggregate but YValue instead.
How can I get the CSV Export work?

Hello,
What do you mean by it doesn't appear? Is the toolbar not vivsible or?
Easiest for me to help if you provide a minium repo that shows the problem.


Fix a panic when matching on a specific type of regular expression

Fixes #10069.

During a run of megacheck the following issues were discovered:

@jsternberg don't we want this to appear in the 1.6.1 CHANGELOG rather than the 1.7 CHANGELOG? Should the kind/bug label be on the backport PR?

It should be in both sections so this is fine. The kind/bug label should be on the backport PR and I forgot so I added that before merging.


concatTx function has wrong signature

The clartiy function contactTx only accepts buff types but the the js function expectes TupleCV<TxDataCV> that contains uintCV types.
concatTx function is used in catamaranswap: https://github.com/boomcrypto/clarity-mainnet-contracts/blob/main/contracts/SP2PABAF9FTAJYNFZH93XENAJ8FVY99RRM50D2JG9/btc-stx-swap-v1.clar#L58
It is an important function because parseTx was too expensive to execute on-chain. Is this still the case after Stacks 2.05?

Hmm. Interesting. It is working when called on testnet, but I haven't really been paying attention to the gas cost.

The signature of the concat-tx function is as follows here: https://github.com/friedger/clarity-catamaranswaps/blob/bb552b99ac7abf78c3b4f53b3516e27024595dc9/contracts/clarity-bitcoin.clar#L772
    (concat-tx
        (tx {
            version: (buff 4),
            ins: (list 8 {
                outpoint: {
                    hash: (buff 32), index: (buff 4)
                },
                scriptSig: (buff 127),
                sequence: (buff 4
            )}),
            outs: (list 8 {
                value: (buff 8),
                scriptPubKey: (buff 127)
            }),
            locktime: (buff 4)
        })
    )

The function to call it from JS is dead code in the test directory, so it may not matter. Since you requested that the ClarityBitcoinClient.js be moved from the test directory into the API in issue #12, I will re-evaluate when addressing that issue.
Regarding the execution cost of parse-tx, I will address with issue #8.


User guard infinite loop via DB access

@slpopejoy found a different avenue (vs #378). unfortunately this one is going to be harder to address -- from what I understand, we can't detect it via static analysis
(begin-tx)

(env-data { "kadmin": { "keys": ["admin"], "pred": "=" } })
(env-keys ["admin"])
(define-keyset 'kadmin)

(module infinite 'kadmin
  (defschema sch g:guard)
  (deftable  tab:{sch})

  (defun get:guard (key:string)
    (at 'g (read tab key)))

  (defun create (key:string)
    (create-user-guard key "enforce-db-guard"))

  (defun install! (key:string)
    (insert tab key {"g": (create key)}))

  (defun enforce-db-guard (key:string)
    (enforce-guard (get key)))
  )
(create-table tab)
(commit-tx)

(use infinite)
(install! "x")
(enforce-db-guard "x")
; ^C<interactive>:1:0:Interrupt

You could probably find a whole bunch of these because we're not doing polarity analysis at any point in the eval lifecycle. This will probably have to happen at some point just to get around errors like this instead of relying just on a top sort of our connected components.

@emilypi FWIW I believe that we did not have any looping (at least that I was aware of) until user guards were added

Interesting. Then we're not including them in the cycle analysis?

Correct -- not yet including them in the cycle analysis. We'd be able to incorporate them in the cycle analysis to prevent https://github.com/kadena-io/pact/issues/378 (basically only allow static strings; or better: change the syntax to take a function bareword there), but this DB case I think we'd only be able to catch via a runtime check (or SMT, but I don't think we'd want to do that) with the current user guard design.

Great then we have a way forward on half of it 😄
In the case of DB's... i'm not sure. Part of me is screaming "positivity checks and real function types!". But then, if Guards are cached, only having to do it once in a kind of lazy analysis-ish way wouldn't be too devastating.

I think positivity checks would prevent nastiness in a future system where we had function types that we could put in e.g. defschema, but with the language as-is, we don't have any place in the system where we model consumption (with negative types) of first-class values -- only production (i.e. positive types).
From what I understand, the thing that's biting us here is more of a matter of effects rather than polarity -- from the combination of aliasing (i.e. naming things, via DB keys) and mutation that we achieve via DB reads and writes. We are affected here by the fact that we can put a guard in the DB, and then that guard in-turn can refer to its own location in the DB.
Re: guard caching, it seems like this re-entrancy would still be an issue? We would need a runtime check to see whether we had already entered a guard (and not yet finished evaluating!) while potentially entering it a second time.

Copying @bts 's example from #378 which I closed as a dupe of this:
(env-data { "kadmin": { "keys": ["admin"], "pred": "=" } })
(env-keys ["admin"])
(define-keyset 'kadmin)
(module infinite 'kadmin
  (defun loop (x:integer)
    (enforce-guard (create-user-guard x "loop")))
  )
(commit-tx)

(use infinite)
(loop 1)
; ^C<interactive>:1:0:Interrupt```

As I said in #378, the use of JSON in keyset creation means we have the same kind of problem as a DB read, in that there will never be a "load time" check of these things like we do with modules. Thus the problem has to be solved in runtime for Pact at least, not sure about analyze. Here are the proposals AFAIK. (A general note is we don't have to worry about perf impact for keyset predicates as the vast majority will use keys-all et al which are optimized/hardcoded as natives, and user guards are wonky so they can be a little slow.)

General reentrancy check for user functions. A simple solution but too expensive, given that non-eval apps are already safe.

Cyclic dep check at application of user guard/custom keyset pred. Not sure how easy/performant this is, requires a traverse on the bound Scope. Given that most well-behaved guards should have very shallow ASTs this could be fine though.

Specific/triggered reentrancy check only when running stacks with eval'd guards/custom keysets. Would probably rather do option 2.

Actually keysets cannot infinite loop atm but for a dumb reason, enforce-keyset switches into a 100% pure context and keysets are read from the database, so a nested enforce fails.
tests/pact/keysets.repl:59:0: : Failure: Illegal database access in pure context
 at tests/pact/keysets.repl:35:4: : Failure: Illegal database access in pure context
 at tests/pact/keysets.repl:35:4: (enforce-keyset LString {_lString = "loop"})
 at tests/pact/keysets.repl:59:0: (loop LInteger {_lInteger = 1} LInteger {_lInteger = 1})
 at tests/pact/keysets.repl:59:0: (enforce-keyset LString {_lString = "loop"})
hspec: user error (tests/pact/keysets.repl:35:4: : Failure: Illegal database access in pure context)```


New package: PhaseOptimizedComponentAnalysis v0.0.1

Registering package: PhaseOptimizedComponentAnalysis
Repository: https://github.com/GunnarFarneback/PhaseOptimizedComponentAnalysis.jl
Created by: @GunnarFarneback
Version: v0.0.1
Commit: ae52b4de19a19916e5e8a0a38515e0261dc93384
Git reference: master

This is a test of the dependency confusion detection and not should not be merged.

Detection successful, please close.


CLI can't decompile vmdl_c to glTF - Invalid KV3 signature

Describe the bug
Can't cli decompile to glTF many models after update Dota2 in Nov
Throw error: "Invalid KV3 signature<PHONE_NUMBER> on resource type vmdl_c, extracting as-is"
Reference file in a Valve game
game/dota/pak01_dir/models/heroes/batrider/batrider.vmdl_c
game/dota/pak01_dir/models/heroes/life_stealer/life_stealer.vmdl
game/dota/pak01_dir/models/heroes/sven/sven.vmdl
etc.
Expected behavior
An exported glTF file
Version info
VRF Decompiler <IP_ADDRESS>3, Win7
Additional context
console output:

Use latest unstable build.


Charts[Network Node]: Expose prometheus metrics from Envoy Proxy

:tada: This issue has been resolved in version 0.8.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


i18n sanitization strategy warning

So we cannot use sanitization strategy  because

//.useSanitizeValueStrategy('escape') // using this makes it impossible to use HTML (links, tooltips, etc.) in variable replacements

are there other options to deal with this than turning off this security feature? (the to_trusted filter or similar maybe?). If my understanding of the matter is correct, then for an application that basically displays only publicly available data, having XSS vulnerability is not the end of the world. Still it would be nice to not have it if possible.

I am also concerned by this. It is planned to extend SQID for remote editing of Wikidata (OAUTH based), so XSS could be a real issue then.
I do not know what would be needed to exploit this potential issue. Can anyone do this without having write access to our message files? I have tested what happens with HTML characters in, e.g., item labels, but I could not produce any problems there.
OTOH, I have not found any way to have HTML variable replacements with any form of sanitization. It seems that this feature is not well developed in angular translate, since there is no advanced sanitization that can allow restricted (or custom) HTML. I also don't know of any other hook to inject values before display.
In any case, it would be nice if we could at least switch off the public advertisement of this possible security issue in the console.


Moved the metadata into setup.cfg.

Also version is now got from git tags.

No thanks, I'm not interested in switching to the pyproject format at this time.


Fix docker run --expose with an invalid port does not error out

Signed-off-by: Lei Jitang<EMAIL_ADDRESS>Fixes #10836
when docker run --expose  with an invalid port, there is no error out.
This patch fix this and have some refactor to previous code to make the code
more simplified. Since function parsers.ParsePortRange will do
strings.Contains(e, "-") and if the port is not a range but a specified one, the return
start port  and  end port  are the same. So there is no need to do if strings.Contains(e, "-")
in parse.go

Shoud I add test for this?

Nice simplification! A test to validate error on invalid port would be great.

We :heart: tests :D

update, add a test for expose a invalid port @jfrazelle

@cpuguy83  @jfrazelle  the test has updated

LGTM after nits with the test.

thanks for the test! looks good ping me after the changes for the merge :D

update the test, ping @jfrazelle

LGTM

thanks @coolljt0725


fix: 支持aws rds sync

这个 PR 实现什么功能/修复什么问题:
支持aws rds sync
是否需要 backport 到之前的 release 分支:

release/3.0

/area region
/cc @swordqiu

Codecov Report

Merging #5343 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #5343      +/-   ##
==========================================
- Coverage    6.99%    6.99%   -0.01%
==========================================
  Files         596      596
  Lines      101054   101055       +1
==========================================
  Hits         7073     7073
- Misses      93412    93413       +1
  Partials      569      569

Flag
Coverage Δ

#aFlag
6.99% <0%> (-0.01%)
:arrow_down:

Impacted Files
Coverage Δ

pkg/multicloud/aws/aws.go
0% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ece5524...aac2b83. Read the comment docs.

/lgtm

/approve


Add Pipeline Hook

Add Pipeline Hook to be notified if a pipeline either fails or succeeds.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

hi @Flipez, can you please sign the Contributor License Agreement?

@engelgabriel , done ;)


The aopalliance rule is only valid starting from spring-aop v4.3.0

This is a merge request for issue #58.

Good catch! Thanks for the PR and for adding a dedicated test.

Released in 1.4


Incorrect Total Duration Display for some Stereo Audio Files

The audio player incorrectly displays the total duration for some audio files with 2 channels (stereo). The issue seems to depend on the sample rate and total duration of the audio file.
Here's a table showing the actual total duration and the displayed total duration for various audio files:

Channels
Sample Rate (Hz)
Actual Total Duration (s)
Displayed Total Duration (s)

1
44100
32
32

2
8000
16
16

2
44100
32
7.65 ⚠

2
8000
32
32

2
44100
16
16

2
44100
64
15.30 ⚠

As highlighted in the table, when the audio file has 2 channels and a sample rate of 44100 Hz, the displayed total length is significantly shorter than the actual duration. However, for stereo files with a sample rate of 8000 Hz, the total length is displayed correctly. An excemption seems to be the just 16 seconds long audio file with 44100 Hz.
To reproduce the test files, the following command was used:
sox -n -R -r [sample rate] -b 16 -c [channels] [file name] synth [duration] whitenoise

I will have a look at this and also #3. I suspect they have the same underlying issue. Having access to the audio files that lead to these results would be helpful. Maybe you can provide them somehow.

I might have found the problem. It was an integer overflow in some variables representing millisecond timestamps. I changed the variables bit widths to 64 with this commit. Please have a look if it work for you now.

Thanks for the fast reaction. I can confirm that your recent commit indeed fixes this issue and all total play times are correctly displayed now. Upon taking a further look I think the only place that was prone to an overflow problem was actually this calculation due to the left-to-right integer arithmetic in C:
_self->riffData.audioLength = _self->riffData.dataSize
        * MICROSECONDS_PER_MILLISECOND
        / _self->riffData.byteRate;

In my local tests changing only this line to:
_self->riffData.audioLength = (_self->riffData.dataSize
        / _self->riffData.byteRate)
        * MICROSECONDS_PER_MILLISECOND;

fixes all problems related to incorrectly displayed total play times so unless you have plans on supporting audio files larger than  4 GB changing this calculation would allow you to return to 32-bit variables.
However I'm afraid to say that the recent switch to 64-bit width did not solve #3 which still occurs in exactly the same way as before.
Regarding your question in https://github.com/CR1337/rl-audio-player/issues/4#issuecomment-2106199467 if generarting the test files locally is not possible for you I can find a way to share the files I've used, otherwise you should be able to reproduce the audio files that lead to these results with the command I provided in my first comment like this:
sox -n -R -r 44100 -b 16 -c 1 audio_44100Hz_1ch_32s.wav synth 32 whitenoise
sox -n -R -r 8000 -b 16 -c 2 audio_8000Hz_2ch_16s.wav synth 16 whitenoise
sox -n -R -r 44100 -b 16 -c 2 audio_44100Hz_2ch_32s.wav synth 32 whitenoise
sox -n -R -r 8000 -b 16 -c 2 audio_8000Hz_2ch_32s.wav synth 32 whitenoise
sox -n -R -r 44100 -b 16 -c 2 audio_44100Hz_2ch_16s.wav synth 16 whitenoise
sox -n -R -r 44100 -b 16 -c 2 audio_44100Hz_2ch_64s.wav synth 64 whitenoise

As the increase of used memory due to the increased bit witdh of timestamps doesn't really matter on modern hardware I decided to stay with the 64 bit width.
In case a user wants to play music using a 7.1 sound system, 32 bit timestamps would only allow for about 90 minutes of playback time given a bit depth 0f 16 and a sample rate of 44.1 kHz.
Regarding #3 there indeed was another issue. It should be fixed with this commit.

In case you are interested in playing around with different sample rates, bit depths and channel amounts to see how large the file would get, I can recommend this tool:
https://www.colincrawley.com/audio-file-size-calculator/

Thanks for providing the fast fix for both issues and recommending the tool - it's pretty handy indeed.
I agree that users of 7.1 sound systems playing more than 90 minutes of playback on a Raspberry Pi shouldn't feel left out - although they probably would anyway, since the FMT chunk size is currently hard-coded to 16 bytes, and surround wav files are usually encoded with a 40-byte FMT chunk.
This seems to apply to most non-mono/stereo files btw as even a simple 2.1 configuration tends to use the WAVE_FORMAT_EXTENSIBLE format code leading to an error when loading the file. I.e.:
sox -n -R -r 44100 -b 16 -c 3 audio_44100Hz_3ch_32s.wav synth 32 whitenoise
I didn't open an issue on that topic yet, because I wasn't sure if this might be out-of-scope for this project but I think this should either be mentioned as a limitation or be fixed.

I didn't open an issue on that topic yet, because I wasn't sure if this might be out-of-scope for this project but I think this should either be mentioned as a limitation or be fixed.

Well now it is in-scope. See #10

#10 is now merged.


ClientMiddleware: document the caveats

ClientMiddleware could be tricky and doesn't always meet expectations.
val client: Client[IO] = ClientMiddleware.default[IO].build(...)
client.run(request).use(response => Tracer[IO].currentSpanContext.debug()) // prints None

I'm almost sure that most people would expect Tracer[IO].currentSpanContext.debug() to print an active span context there.
However, it does not work that way due to limitations: 1, 2.
What can we do?

Document why it doesn't work
Provide a workaround

A workaround could be the following:

A text map propagator (e.g. W3CContextPropagator) must be enabled to make this work
Add (if needed) tracing headers to the response: resp.withHeaders(traceHeaders ++ resp.headers)
A user must explicitly join the active span via Tracer[F].joinOrRoot:

client.run(request).use { response =>
  Tracer[IO].joinOrRoot(response.headers)(
    tracer.currentSpanContext.debug() // prints an active span context, all good
  )
}

This is not the case with the ServerMiddleware because HttpRoutes isn't described as a Resource but as Kleisli.

Here is another workaround: https://github.com/typelevel/otel4s/issues/194#issuecomment-2257899601

@rossabaker @NthPortal how can we mitigate this limitation in your opinion?

I'm not convinced this is a bug. the tracing from the middleware is around the client making the request, and using the resource of the response is not part of that

It's not a bug, but it may be an unexpected behavior for newcomers.

the tracing from the middleware is around the client making the request

You are right. That makes sense.


Add Button at bottom with a link on story show

I am using zuck js for stories functionality in Django and it is working fine. I want to add a button at the bottom of story view so that i can attach link with each story. I have tried to search online but could not find any tutorial related to it.
I have added following code in Django Template for viewing stories.

``
I have tried to look at the zuch.js/src to look how we can add custom template but find it very confusing. Can you please help me in adding button at the bottom of each story.

Also, I want to show story upload time in hours. I have added time variable but the template only shows number of hours like '1', '2' ... I don't how to make it '1 hour ago', '2 hour ago', etc.
The item data that I am receiving looks like this:
[{"id": "1", "photo": "/media/escort_galleries/logo.png", "name": "danish", "link": "", "lastUpdated": "", "items": [{"id": 24, "type": "", "length": 3, "src": "/media/escort_stories/Chinese_WpZqgLa.jpeg", "preview": "/media/escort_stories/Chinese_WpZqgLa.jpeg", "link": "", "linkText": "", "time": 3, "seen": ""}]}]

@ramonszo can you please help.


Fluent - Show PublishedInLocale State in Backend-ElementalArea

Hi,
We're using the fluent module in most of our projects, especially when it comes to use it in combination with elemental there is one  feature which would just be great to have -> a "Visible in Locale" column / flag something which shows if a current Block is visible in a Locale or not in the Backend-ElementalArea.
Maybe like this:

There is a GridField Extension which comes together with the fluent-module itself. Maybe this is a inspiration.
VisibleLocalesColum - Fluent Module
We would love to integrate it by ourselfs, but as this part is managed by react-only and to be honest, we don't have an idea on how to do do it. So we decide to write this feature-request.
Thanks in advance

Thanks for suggesting this - however as this is a feature we aren't likely to implement any time soon I will close this issue.
If you find someone who is willing to implement this for you, feel free to reopen a PR - though note that if it is specifically for the fluent module, it should be raised there. If it's for making the react component more flexible, that's fine to raise here.


Error seen on using flogo build command

Example Recipe Link: https://github.com/project-flogo/microgateway/tree/master/examples/json/basic-gateway
Steps to produce:
1)Clone the microgateway Repository:
git clone https://github.com/project-flogo/microgateway
cd microgateway/examples/json/basic-gateway
2)Create the flogo App:
flogo create -f flogo.json
cd MyProxy
3)Try the build command:
flogo build
Below error is seen:
Error in building /home/mashling/micro/src
Error: # github.com/project-flogo/flow/definition
../../go/pkg/mod/github.com/project-flogo/flow@v0.9.0-alpha.3/definition/definition_ser.go:87:52: not enough arguments in call to mapper.ConvertLegacyMappings
have (*mapper.LegacyMappings)
want (*mapper.LegacyMappings, resolve.CompositeResolver)

fixed

Working fine.


Fix Windows process job handle leak

this fixes https://github.com/sensu/sensu/issues/1057

Wrong remote ;)


Update version to 0.0.7 (drop "-alpha") and draft release notes

This PR is the first step towards releasing AgentOS v0.0.7 per the current release process.
Release manager: @andyk
Draft of release notes for v0.0.7

Expand and improve docs

Add API docs (#95)
Fixes docs/website search (#99)
Add programming guide (#66), overview of example agents (#27)
Fix quickstart (#88, #89, #90)
Restructure docs/website to keep previous versions of docs (#23, #74)
Reconcile readme & documentation to keep them in sync (#26, #37, #100)

Consolidate various utility scripts into scripts directory, and improve them (#34)

Add black and lint (#43)

Fix & Expand tests

Run Github tests on windows (#38, #39) and MacOS
Fix flakey tests  (#53)

Improve example agents (#9, #10)

See all Issues completed in the 0.0.7 work sprint here.
After this PR is merged, as release manager I will then complete the remaining steps (bump version to 0.1.0-alpha, publish the docs, push to PyPI, etc.)...

LGTM!
Just to check--I'm supposed to give the thumbs up as part of the release process, right?

Yep!

LGTM!


GPMDP leaves process after exiting via window close or taskbar icon quit.

OS: Windows 10 Pro (1909)
GPMDP Version: 4.7.1
Issue Descriptions: Closing a window or exiting using taskbar context menu Quit leaves GPMDP process running using around 8% of CPU (according to task manager). Using Quit from application menu quits completely. Tray (except for quit test) was disabled.
Steps to Reproduce:

Start GPMDP, close window (without tray enabled), process will be there without way to interact with it.
Same, with tray enabled, select Quit from the context menu, process is still there.
Quit from within application window menu, no processes are left running.

I can confirm this issue, I always have one process left running that is maxing out one virtual core on my machine. The process needs to be killed with task manager.
Also running Windows 10 Pro.

Looking into this further, for me, the process that is left open is the initial/primary process, not the child processes and it only happens if I exit using the the X in the window. If I select Quit from the taskbar, all processes close.
My guess about the CPU usage spiking is that the process is attempting to communicate with the now closed child processes?
I have Minimize to Tray turned off in the desktop settings.


General comments in XML format page

Widgets will be introduced in Windows App SDK 1.2 Preview 2
Element Hierarchy could be shown in a diagram or through some other means, as it's hard to read. Having empty lines and tabs makes it prone to get "&nbsp" showing up as next to "Size"

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: e9395d81-bd55-f476-fd05-736a13583111
Version Independent ID: e9395d81-bd55-f476-fd05-736a13583111
Content: Widget provider package manifest XML format - Windows apps
Content Source: hub/apps/develop/widgets/widget-provider-manifest.md
Product: reunion
Technology: apps
GitHub Login: @drewbatgit
Microsoft Alias: drewbat

I have fixed the &nspb; typo and updated the boilerplate to refer to App SDK 1.2 Preview 2. The formatting for the element hierarchy is not ideal, but it is the current standard across the Windows schema docs. It looks bad in those docs as well, but because the hierarchies are smaller, it's not as bad. There are a lot of considerations here such as accessibility and standards across our docs content (we used to format these with html tags that are no longer allowed in the docs). I have escalated this issue and will update this content when we have a resolution, but I'm going to close this issue for now as it's not a ship-stopper.


Update Home Assistant and Playwright docker images

This pull request updates the Home Assistant and Playwright docker images used for the end-to-end tests to version 2024.2.0 and version v1.41.2-jammy respectively.

coverage: 100.0%. remained the same
when pulling 9d3a9b0e38b1303b8b6c873c1cde0985ba54b955 on update_home_assistant_and_playwright
into b9106b3949c30c00dceda521b22c56e859da9e9f on master.


NetAppFiler.find seems useless

In order to fix accidental use of rails3/4 syntax in #1422 since NetAppFiler isn't not an ActiveRecord model, I dug into NetAppFiler.find.
It looks like it was implemented where we would provide a config/net_app_filers.yml and the handcrafted finders would always use this yml to provide the results of the find.  I dug through git history back to the creation of the file (7c7a75f729d76 Feb 2011) and could not find that this yml file ever existed.  This would mean that users/customers would have had to create this by themselves not knowing the format and manage distributing this file to all appliances that would run NetAppFiler's finders.
  YAML_FILE = File.join(Rails.root, "config/net_app_filers.yml")

  def self.find(*args)
    count = args.first
    raise "Only :all is supported for find" unless count == :all

    self.all_filers
  end

  def self.find_by_name(name)
    h = self.load_from_yaml.detect {|f| f[:name] == name}
    h ? self.new(h) : nil
  end

  def self.all_filers
    h = self.load_from_yaml.collect {|f| self.new(f)}
  end
  class << self; alias :all :all_filers; end

  # ....

  def self.load_from_yaml
    return [] unless File.exist?(YAML_FILE)

    YAML.load_file(YAML_FILE)
  end

With this yml not existing, NetAppFiler.find(:all), .all, .all_filers will always return [] and NetAppFiler.find_by_name will always return nil.
This makes the callers of find below nearly useless (including the code changed in #1422):
app/models/miq_provision_vmware/placement/net_app.rb:24:      filer = NetAppFiler.find_by_name(ds_controller)
app/models/miq_provision_workflow.rb:778:    NetAppFiler.pluck(:name).index_by { |n| n }
app/models/miq_provision_workflow.rb:785:    naf = NetAppFiler.find_by_name(controller)
app/models/storage.rb:709:      naf = NetAppFiler.find_by_name(ss.element_name)

This feature seems to be half complete.  Is this used?  Is this needed?  Am I misunderstanding?

cc @gmcculloug @chessbyte @Fryguy

@roliveri this looks like one for you

cc @tenderlove  (thanks for helping me look at this yesterday)

Again, unless I'm not understanding...
NetAppFiler#create_datastore seems only useful if you manually create a NetAppFiler if find will never return a NetAppFiler to call the method on.
Finally, MiqProvisionVmware::Placement::Netapp create_netapp_datastore will never be able to call NetAppFiler#create_datastore because the above line will never find a Filer to call the method on.

I'm not familiar with this class. It looks like it was add primarily for provisioning, but I'm at a loss as to the intent of the methods in question.

There is NetApp RCU support in provisioning.  Looks like that is a good candidate for code to delete.

@gmcculloug If you know it, can you delete it?  I'm pretty lost as to the purpose of this area of code.  I believe the finders completely useless since they always return [] or nil, I don't know if they can be removed or need to be fixed.

Sure, let me see what I can do with it.

See also #1634

@gmcculloug bump. Any news on this?

git rm is my vote but I don't know the details

git rm is my vote too. I think it was added for a demo many years ago and has been unused since.

I'll send a PR that rm's it.  @gmcculloug can :+1: or :-1: there. :smile:


[$250] Mac/Safari - Users list in money request flow do not fit correctly in some zoom levels

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Login to the NewDot via Mac/Safari
Open global menu (it's important) and click on the Request money
Enter money amount and click on the next button
Observe users list
Repeat 2-3 with different browsers Zoom levels (cmd + / cmd -)

Expected Result:
The user should be able to use money request flow without any issues
Actual Result:
Users list in money request flow do not fit correctly in some zoom levels
Workaround:
Unknown
Platform:

Where is this issue occurring?

Web

Version Number: <IP_ADDRESS>
Reproducible in staging?: Yes
Reproducible in production?: Yes
Email or phone of affected tester (no customers): any
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://user-images.githubusercontent.com/93399543/186982733-92ff0624-0700-4687-b457-3dfa60b6ed79.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub

Was able to repro on Safari, this is buggy and should be fixed. Posted to Upwork: https://www.upwork.com/jobs/~013abb27ed5da559c8

I see a blank page when clicking Next after filling in the money amount.
Someone also experiences the same:
https://expensify.slack.com/archives/C01GTK53T8Q/p1661708190183589
This bug will be dependent on the above bug.

Yeah the page is blank at safari, I have tested this on iPad and mac

Proposal
Root cause
The issue here is Safari ignores element that have overflow: hidden when said element is transitioning. In this case, it's the sectionList that's being rendered inside the IOUParticipantsPage:
https://github.com/Expensify/App/blob/0825a4e001df6ac5b19ac89ca3ab216ee4450400/src/pages/iou/IOUModal.js#L422-L433
Solution
Adding the following styles to the component.
    <AnimatedStep
-      style={[styles.flex1]}
+      style={[styles.flex1,{position: 'fixed', width:"100%"}]}
       direction={this.getDirection()}
    >

No breaking changes observed with said change.
https://user-images.githubusercontent.com/23414844/189647138-79582391-eb24-48fc-9070-3229e2c55402.mov
https://user-images.githubusercontent.com/23414844/189647231-7cafbb50-506f-4ade-ae70-7cf8cbdadce6.mov
https://user-images.githubusercontent.com/23414844/189647289-b991482d-cfc9-4c10-8002-0c865792e38a.mov

Issue not reproducible during KI retests. (First week)

I'm still able to produce this in Safari on prod. I'm not able to repro the blank page described in the linked Slack post though 🤔, I'm using Mac/Safari
@wildan-m, are you suggesting that this issue and the blank screen issue probably have the same cause? Or are you just saying that the blank screen issue will need to be solved first?

I feel the blank page and the zoom levels are related. Here's a screencast from my Mac Safari browser on staging.
https://user-images.githubusercontent.com/3069065/189988051-e12fbc41-a927-4c98-bf0e-8014a9be1468.mp4

@stephanieelliott
Have you tried it in Staging? I think we have to resolve the blank page issue first.

Weird, I'm still not able to repro the blank screen behavior -- tried both Chrome and Safari on staging and prod, multiple zoom levels. Either way, I agree these are very likely related! I updated this issue to include both the blank screen and the distorted display and raised it to $500.

PROPOSAL
Root Cause
In the AnimatedStep component, the component being animated does not stay in view in Safari if said components children is a sectionList. In this case it happens during the participants selection step. Not sure why exactly it's failing but I found a similar issue on the react-animated repo https://github.com/oblador/react-native-animatable/issues/262.
Solution
Applying the animation directly rather than passing the animation type i.e "slideInright" fixes the issue. You can also notice that the animation looks smoother(videos attached to show the comparison) which I suggest fixes this issue too https://github.com/Expensify/App/issues/10610
Changes made are in the AnimatedStep component that is currently only being used in the IOUModal page.
diff --git a/src/components/AnimatedStep.js b/src/components/AnimatedStep.js
index b876f9c26..9cae58af6 100644
--- a/src/components/AnimatedStep.js
+++ b/src/components/AnimatedStep.js
@@ -21,13 +21,25 @@ const defaultProps = {
 };

 const AnimatedStep = (props) => {
+    function makeSlideInTranslation(translationType, fromValue) {
+        return {
+          from: {
+            [translationType]: fromValue,
+          },
+          to: {
+            [translationType]: 0,
+          },
+        };
+    }
     function getAnimationStyle(direction) {
         let animationStyle;
+        const slideInLeft = makeSlideInTranslation('translateX', -100); //100 is the default value used by react-animatable
+        const slideInRight = makeSlideInTranslation('translateX', 100);

         if (direction === 'in') {
-            animationStyle = 'slideInRight';
+            animationStyle = slideInRight;
         } else if (direction === 'out') {
-            animationStyle = 'slideInLeft';
+            animationStyle = slideInLeft;
         }
         return animationStyle;
     }

Test
https://user-images.githubusercontent.com/23414844/190865816-6b4da369-44d6-4276-8c1f-860c45b8dfc8.mov
https://user-images.githubusercontent.com/23414844/190865860-f698e3f3-1f25-4c7d-872e-bdab3d012bef.mov
https://user-images.githubusercontent.com/23414844/190865924-2c701d75-6da2-460a-b840-66b09306eeb8.mov
https://user-images.githubusercontent.com/23414844/190866227-81f225f8-0206-4d84-844e-f0712f3cbb55.mp4

Missed the proposal here from @oogushikun. Please allow me a day to confirm. I am trying to check if this is a regression because this should've been working earlier!

Issue not reproducible during KI retests. (Second week)

Hey @mananjadhav have you had a chance to review this one?

I couldn't find any regression. @oogushikun  I did check your proposal and this is exactly what react-native-animatable uses underneath for sliderInRight and sliderInLeft. Could you explain why is it not working in the library and why the same function works when used in AnimatedStep component?

Issue not reproducible during KI retests. (Third week)

@mvtglobally I am not sure when you say its not reproducible. Screenshots I took from staging few mins back.

Apologies @mananjadhav for the late reply. As you've mentioned the values I passed in my previous comment are defined by react-native-animatable. The reason it's not working is because currently when passing the animation type as a string i.e 'slideInRight', the transition value is 1920 instead of 100.
https://user-images.githubusercontent.com/23414844/193454744-5b3d3ff1-3514-4511-b82e-edd83fddd871.mov
This is being caused by react-native-modal which also uses react-native-animatable as a depedency. React-native-modal declares it's own custom animations like this:

As you can see the transition value being passed is using the devices window width, hence why we're getting 1920 i.e the window width on my monitor. Hope that clarifies things 😅

Thanks for the clarification @oogushikun. Yes you're right that the transitions are getting overwritten with react-native-modal.
@oogushikun's proposal here https://github.com/Expensify/App/issues/10608#issuecomment-1250098928 looks fine to be. Just that I would want to move 100 to CONST.js
🎀 👀 🎀
C+ reviewed
@AndrewGable Up for your review.

Applied on upwork. It'll take me a day(after being approved) to create the PR.
Thanks 😃

@oogushikun Do you have an update for us on the PR?

Hi @mananjadhav. I'm still waiting to be approved for the job on upwork.

Ohh okay, @stephanieelliott Can you please approve the hire on Upwork?
fyi, @oogushikun it is okay for you to wait for the Upwork hire, but if you're assigned a job here on Github like this, it is as goo as being hired on Upwork.

my bad on my part then, I figured I'm only supposed to create the PR once you've been approved. Let me create it and I'll be update you shortly.

Oops sorry @oogushikun, I didn’t realize that was you on Upwork! You’ve been hired there.
@mananjadhav please also grab the job for C+ when you get a chance! 😀

Thanks @stephanieelliott 😄

Hi @stephanieelliott Is it possible to get a reevaluation of the budget for this task? Taking into consideration the effort put into debugging the issue and also the effects of the bug being more than what was reported, i.e., transitons weren't working correctly on all platforms, not just on Safari.

@oogushikun I agree that the scope of the issue may have extended a little bit beyond what was described in the issue body. I can see increasing this to $750 total -- does that sound fair to you?

works for me @stephanieelliott, thanks a lot 😃.

Issue not reproducible during KI retests. (First week)

All paid up!

@stephanieelliott, I think reporting compensation is pending on this one. Can you please look into it?

Oop, thanks @thesahindia! I invited you to the job on Upwork to pay out the reporting bonus https://www.upwork.com/jobs/~013abb27ed5da559c8

I have already submitted the proposal.

Thanks, all paid now!