"There were problems importing some of your data" - What problems?

Hi. I tried to import a file and got error "There were problems importing some of your data". How can I see what the errors were?

There can be loads of reasons for this but it’s most likely that some of your data doesn’t pass some of your field’s validation rules.
If you can provide a sample of the Nova Resource class that you tried to import to and a sampling of the data you tried to import, I can test locally and see what’s going wrong.
I will try to work on better error messages.
While you’re here, please consider sponsoring as this helps me to keep working on Open Source projects.

Thanks for your reply.
I decided to import directly to the database.
On Wed, 9 Sep 2020 at 20:23, Simon Hamp<EMAIL_ADDRESS>wrote:

There can be loads of reasons for this but it’s most likely that some of
your data doesn’t pass some of your field’s validation rules.
If you can provide a sample of the Nova Resource class that you tried to
import to and a sampling of the data you tried to import, I can test
locally and see what’s going wrong.
I will try to work on better error messages.
While you’re here, please consider sponsoring
https://github.com/sponsors/simonhamp as this helps me to keep working
on Open Source projects.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/simonhamp/laravel-nova-csv-import/issues/26#issuecomment-689736383,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABIIJT7XFTIWZ3UQUYYNW4LSE7B3HANCNFSM4RCPV2YA
.

--
Christopher Alexander
<EMAIL_ADDRESS>

Hi,
I'm encountering the same issue.
Nova Resource Class: https://gist.github.com/theimaginaire/be72fdb5c160f7ef7f896f59ecad937f
Import data (Download > As CSV): https://docs.google.com/spreadsheets/d/17tBxiCHcGay-Q1D3keMb1Mg20V_pFS7r_utybp9rQlI/edit?usp=sharing
Would be great to work out where we're going wrong so that we can reuse the tool for other areas of our software.

Hi @theimaginaire. If you're using this tool for commercial means, I'd really appreciate your support.
Sorry for the very late response. I will try to get some time to look into your issue if you've not been able to find a solution.

Having the same issue. Field names and Excel column names are identical. The .CSV file was reduced to 16 rows and there are no empty rows/fields.

You can see the details of the error in the AJAX request in Chrome.
In my case, renaming the column from country_id to country and filling in the empty columns helped.


fix(cp) do a pcall for all calls to export_deflated_reconfigure_payload

We are already wrapping some calls to
export_deflated_reconfigure_payload() inside a pcall in the
control_plane.lua file. This change is doing a pcall in all the
remaining calls to export_deflated_reconfigure_payload() in this file
to avoid the CP crash whenever we find errors during initialization of
modules for example.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

it's missing similar calls in wrpc_control_plane.lua

@javierguerragiraldez @fffonion
Tests are green 🟢 https://github.com/Kong/kong/runs/6009975751

@javierguerragiraldez @fffonion is this PR good to merge?

I don't have merge permissions


[SPARK-48778][SQL][TESTS] Improve collation support testing - add unit tests for string expressions

What changes were proposed in this pull request?
Add unit tests at Spark expression level.
Why are the changes needed?
Enhance collation testing for both code gen and interpreted code path.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
New tests in CollationStringExpressionsSuite.scala
Was this patch authored or co-authored using generative AI tooling?
Yes.

@cloud-fan, @MaxGekk and I have discussed this offline, so here's a quick rundown:
over the past few months, we've had many untested and mishandled cases for collation support in various expressions - so to avoid things like this, I propose that we should stay on the conservative side of testing with collations (at least for now)
given that this suite takes ~10s total to run on my machine locally, I think this is not too bad and that benefits outweight the extra computation load - to recap, CollationStringExpressionsSuite.scala currently handles two types of tests:

Spark expression-level unit tests, that are used to test both code paths (interpreted and genCode)
e2e SQL tests with literals, that are used to conveniently verify only the basic test case results

the other stuff, such as:

e2e SQL tests with explicit collate expressions
e2e SQL tests that verify collation type coercion & collation mismatches
e2e SQL tests with table columns instead of literals
will be moved to the golden file collations.sql

+1, LGTM. Merging to master.
Thank you, @uros-db and @cloud-fan for review.


Workaround to issue Error on Safari and Firefox (Can't find variable:…

… TouchEvent) - https://github.com/piotrdz/ng5-slider/issues/4.
It is not the definitive solution, but it allows to run without problems in other browsers.

I fixed this problem in a different way in 1582c2f. Closing.


Does nothing for me -- but why?

It does not run my build task.  I don't know why.  I can run the build task from the command pallette. Further, this plugin logs this when I change a .ts file:
5:55:24 PM Document /home/nando/py/jobs/fairsplit/fair/fair/ui/.vscode/tasks.json saved in workspace ui
5:55:24 PM {}

I think part of the problem is I cannot find a complete example of a tasks.json file with this.  The documentation is too terse!
Here's my current file:
{
	// See https://go.microsoft.com/fwlink/?LinkId=733558
	// for the documentation about the tasks.json format
	"version": "2.0.0",
	"tasks": [
		{
			"label": "build",
			"type": "npm",
			"script": "build",
			"group": "build",
			"problemMatcher": [
				"$eslint-stylish"
			]
		}
	],
	"triggerTaskOnSave.tasks": {
		"build": [
			"src/*",
		],
	},
	"triggerTaskOnSave.showNotifications": true,
	"triggerTaskOnSave.on": true,
}

The "triggerTaskOnSave" settings are extension settings, so should be in your settings.json. They won't do anything in the tasks.json.

Suggestion: Add that piece of information to the README.
Would you like a pull request?

By the way, I must thank you profusely for your speedy reply.  That was awesome!

A pull request would be great - I don't have much time at the moment to work on my extensions (and I stupidly published too many of them!).

Done.  Thank you for the code and the support!


parent item is not shown in context when it's on the first line

Thanks for the awesome plugin!
I found some strange behavior and I'm not sure where this is coming from.
A function item that is the first line will not be shown in the context.
I tested this with rust and python examples.
So in a file like this:
def test():
    print("A")
    # [...] more content so the function definition is outside the screen
    print("A) # cursor here

The function will not be shown in the context.
Slightly changed like this:
# empty line here
def test():
    print("A")
    # [...] more content so the function definition is outside the screen
    print("A) # cursor here

I will see the function in the context.
I'm happy to provide more input when needed.

( I probably will give a shot at debugging this another day, only wanted to put it here first)

I found the problem in the code to get parent matches. It skip the first while querying parent.
https://github.com/romgrk/nvim-treesitter-context/blob/b7d7aba81683c1cd76141e090ff335bb55332cba/lua/treesitter-context.lua#L354
I think it shoud be row >= 0 to get the first line too.


Fix issue with marker showing blank screen on slow network connection.

Fixes #381
Proposed Changes

Marker will now show spinner indicator up until all the slices are loaded.

Additional comment (optional)
Before, downloadScanInProgress was set to False immediately after first slice was loaded. So, spinner indicator disappeared, but no scan was shown because middle slice was not loaded at that point. Now, downloadScanInProgress is set to False only after all the slices, including middle slice, were loaded, making slice appear immediately after spinner indicator disappears.

Looks fine for me!💪
@kolszewska - could you take a look at it?


Format release name according to timezone.

Q
A

Bug fix?
Yes

New feature?
No

BC breaks?
Yes

Deprecations?
No

Fixed tickets
649

The timezone environment variable was not used when generating release folder name, which could cause the build to break.
This can however be considered a breaking change, because users from a timezone that is ahead of UTC, who move towards consistently using UTC instead of their own timezone, and who already deployed enough releases in the last few hours, might see their release folder instantly removed on deploy.

👍

Sorry about the first two check-breaking commits. 🙇
As mentioned above, this change can be considered breaking, in at least two ways:

users located in a timezone ahead of UTC and who deploy enough times (keep_releases times between their timezone and UTC) will potentially delete the folder being release during deploy (just like described in #649, in reverse). To circumvent this problem, it could be a possibility to postfix release names with a Z, and treat them differently in sort (this would require chiming in the discussion in #641).
since timezone becomes a global (not environment) variable, it might break deploys of users who use env('timezone') in their custom tasks. Not sure how to prevent this, though…

Thank you for your PR.
But i think why not breck BC?
env('release_name', function () {
    // Set the deployment timezone
    if (!date_default_timezone_set(env('timezone'))) {
        date_default_timezone_set('UTC');
    }
    return date('YmdHis');
}); // name of folder in releases

Please see #338 #357 #585

About possible breaking changes. Every think will be okay. Only order of releases may be broken. But we can add some sort of check: is new release name a last one?
is_last(env('releases'), $releaseName)

Thank you @oanhnn.
In the light of the additional context described in the issues that you mentioned, I believe that indeed, your proposed solution of moving the date_default_timezone_set bit inside the release_name function makes the most sense.

Also, good idea @elfet. Indeed there could still be a side effect as described in #649. Let me explore this…

Actually, a check on whether the release currently being deployed is indeed the last one would fix the release order bug on deploy, but could potentially screw up other tasks… Which might be worse, actually (picture the effect on rollback).
Currently, all tasks depending on releases_list assume that the list is ordered (from last to oldest). So this is the expected contract for this function.
However, the list is rsorted by file name, which only really works when release names are consistent, and is subject to breaking (timezone mix, user names their releases by git hash…).
Wouldn't it be safer to have release_list sort the list by release directory create time? Concurrency issues aside, wouldn't solve all potential breakages mentioned here so far?

@coox
I created PR #656 , you can review and confirm "Is bug fixed ?"

@oanhnn — donc, looks 👍  to me.

@oanhnn, @elfet:
Regarding the discussion on releases_list order, I suppose that it goes beyond the scope of current issue: deployer could not entirely rely on filesystem data to ensure sorting, it would be too brittle. deployer would have to store releases metadata next to the releases themselves, that's quite a bit of work.
Is this a feature that you have envisioned for an upcoming release? What are the plans regarding release metadata on the server? I'm asking because I noticed in #641 that there could be plans for a dep releases command, which I think is related, as release metadata storing would be inevitable.

@coox This feature may be available in Deployer 4.x
@elfet Can you make a feature issue about this feature.
I think it may be:
$bin/dep releases
Realease       | Time                        | Reversion
---------------|-----------------------------|-----------
20160501100000 | 10:00:00 May 01, 2016 (UTC) | 56abc52
20160501100513 | 10:05:13 May 01, 2016 (UTC) | dde123f


H5054 bluetooth water sensors

Govee Device SKU
H5054
Govee2MQTT Version
2024.01.12-ff6087e2
Describe the issue
I have three water Govee water sensors connected with a gateway.  Gateway model is H5040_E0E8
It appears based on the logs, the service is identifying them but its not getting added to HA due to "Unknown device type."
Startup Diagnostics
s6-rc: info: service s6rc-oneshot-runner: starting
s6-rc: info: service s6rc-oneshot-runner successfully started
s6-rc: info: service fix-attrs: starting
s6-rc: info: service fix-attrs successfully started
s6-rc: info: service legacy-cont-init: starting
s6-rc: info: service legacy-cont-init successfully started
s6-rc: info: service legacy-services: starting
s6-rc: info: service legacy-services successfully started
GOVEE_API_KEY=REDACTED
GOVEE_MQTT_HOST=core-mosquitto
GOVEE_EMAIL=REDACTED
GOVEE_PASSWORD=REDACTED
GOVEE_MQTT_PASSWORD=REDACTED
GOVEE_MQTT_USER=addons
GOVEE_LAN_NO_MULTICAST=false
GOVEE_MQTT_PORT=1883
++ cd /app
++ exec /app/govee serve
[2024-01-12T23:23:56 INFO  govee::commands::serve] Starting service. version 2024.01.12-ff6087e2
[2024-01-12T23:23:56 INFO  govee::commands::serve] Querying platform API for device list
[2024-01-12T23:23:57 INFO  govee::commands::serve] Querying undocumented API for device + room list
[2024-01-12T23:23:57 INFO  govee::service::iot] Connected to IoT: CONNACK code 0: Connection Accepted.
[2024-01-12T23:23:57 INFO  govee::service::iot] IoT (re)connected with status CONNACK code 0: Connection Accepted.
[2024-01-12T23:23:57 INFO  govee::commands::serve] Devices returned from Govee's APIs
[2024-01-12T23:23:57 INFO  govee::commands::serve] H5054_9569 (0A3A8DD7E0E8009569 H5054)
[2024-01-12T23:23:57 INFO  govee::commands::serve]   Undoc: room=Some("Basement") supports_iot=false ble_only=true
[2024-01-12T23:23:57 WARN  govee::commands::serve]   Unknown device type. Cannot map to Home Assistant.
[2024-01-12T23:23:57 INFO  govee::commands::serve]
[2024-01-12T23:23:57 INFO  govee::commands::serve] H5054_93CB (0A3A8DD7E0E80093CB H5054)
[2024-01-12T23:23:57 INFO  govee::commands::serve]   Undoc: room=Some("bathroom down") supports_iot=false ble_only=true
[2024-01-12T23:23:57 WARN  govee::commands::serve]   Unknown device type. Cannot map to Home Assistant.
[2024-01-12T23:23:57 INFO  govee::commands::serve]
[2024-01-12T23:23:57 INFO  govee::commands::serve] H5054_0186 (0A3A8DD7E0E8000186 H5054)
[2024-01-12T23:23:57 INFO  govee::commands::serve]   Undoc: room=Some("Basement") supports_iot=false ble_only=true
[2024-01-12T23:23:57 WARN  govee::commands::serve]   Unknown device type. Cannot map to Home Assistant.
[2024-01-12T23:23:57 INFO  govee::commands::serve]
[2024-01-12T23:23:57 INFO  govee::service::http] http server addr is <IP_ADDRESS>:8056
[2024-01-12T23:24:02 INFO  govee::service::hass] Wait 100ms for hass to settle on 2 entity configs
[2024-01-12T23:24:02 INFO  govee::service::hass] MQTT connected with status=CONNACK code 0: Connection Accepted.
Additional Logs
No response
Home Assistant Logs
No response
Anything else?
No response

Those particular devices operate only via BLE, and there is no BLE support in Govee2MQTT at this time.
In the meantime, you might find that the built-in home assistant improve-ble is able to automatically detect and do something useful with those devices.

hmmm I was hopeful it would pull in via the API (as it does on Homebridge for me)

This device doesn't show up in the Govee Platform API, which is why it shows as unknown.

Not that I would be technically capable of answering, how might it work with homrbridge (as I read govee2mqtt leverages the homebridge govee plugin)
connecting via Bluetooth to the Apple TV on homebridge?

Perhaps you have enabled bluetooth in homebridge and it is using that?

Interesting. homebridge is running via docker on a laptop that has Bluetooth but currently running HA OS on a VM on Mac Mini M2 (couldn’t wait for my raspberry pi 4 4gb to arrive. Will eventually migrate to dedicated pi once it arrives)

I have these sensors as well and am hoping for BLE support in Govee2MQTT.


store_object exception messaging is unclear

When store_object fails, the calling methods log the relevant errors as expected, but when the exception reaches store_object, the actual cause/message is lost (only the exception type is displayed at this time). Even though the appropriate exceptions/errors are logged, this is a bit confusing (and cause misunderstanding).
Revise exception messaging (minimize amount of errors shown via logging levels to reduce confusion?) and ensure store_object shows an appropriate exception message when an object fails to be stored.
Example:
2024-05-21 17:34:59 - ERROR - FileHashStore - _verify_object_information: Hex digest and checksum do not match - file not stored for pid: urn:uuid:018c0136-e22f-4319-b109-140c99afd7c7. Algorithm: md5. Checksum provided: null != HexDigest: 2fc94682032f18f380d042e5f88a517c. Tmp file (/home/mok/testing/knbvm_hashstorecp/objects/tmp/tmpdzxb37pq) deleted.
2024-05-21 17:34:59 - ERROR - FileHashStore - _move_and_get_checksums: Object exists but cannot be verified (validation error): /home/mok/testing/knbvm_hashstorecp/objects/ef/23/eb/20185a54a5dc3e5b5b96d97f158aa5f639b52598cdcc8feaf5df508e15, deleting temporary file. Error: FileHashStore - _verify_object_information: Hex digest and checksum do not match - file not stored for pid: urn:uuid:018c0136-e22f-4319-b109-140c99afd7c7. Algorithm: md5. Checksum provided: null != HexDigest: 2fc94682032f18f380d042e5f88a517c. Tmp file (/home/mok/testing/knbvm_hashstorecp/objects/tmp/tmpdzxb37pq) deleted.
2024-05-21 17:34:59 - ERROR - FileHashStore - store_object: failed to store object for pid: urn:uuid:018c0136-e22f-4319-b109-140c99afd7c7. Unexpected err=ValueError(), type(err)=<class 'ValueError'>

This has been completed via Feature-90: store_object Exceptions & Logging


[Issue] the function is_email_valid is too permissive

Hi everyone!
Here a few cases, I've tested:

<EMAIL_ADDRESS>=> TRUE
<EMAIL_ADDRESS>=> TRUE
<EMAIL_ADDRESS>=> TRUE

To be honest, I don't see how we can solve this. This should be done at application level before being stored in BQ.

Hi @mickaelandrieu,
According to Wikipedia, these emails seem valid, no?
At least, * and ! seem valid characters in the first part of the email.
https://en.wikipedia.org/wiki/Email_address#Local-part
Or maybe it is forbidden to have only these characters?


fix(meta): avoid meta duplication

#70

I'd recommend not using hid or key for deduping. All meta tags will be deduped automatically for you. This also allows users to override them easily.

You can read further about the logic here: https://unhead.harlanzw.com/guide/guides/handling-duplicates

Useful to note that the key usage on <link> entries should stay

Useful to note that the key usage on  entries should stay

Indeed, this is very important (see e.g. #61) so they can be deduped the right way 👍🏻
LGTM


FR: Allow other filetypes besides markdown

Filetypes other than markdown make use of fenced code blocks such as Quarto and Rmarkdown. It would be nice to have a config option to select what filetypes to apply highlighting to.

Filetypes other than markdown make use of fenced code blocks such as Quarto and Rmarkdown. It would be nice to have a config option to select what filetypes to apply highlighting to.

yes, see it. It is the first version, I will keep upgrade it.


Crash in Fabric 1.21

Just installed 1.11.0 on my modpack, but when i tried to boot the game i got this crash.

can you provide me the pack?

Hi,
I am getting the same error it seems, here is the error log:
https://gist.github.com/flippnfadoodle/d5a43a6859ce7c7f1b705b53f4a047e9
Here is a download link to my modpack with all of the mods hosted on the server:
https://www.mediafire.com/file/94ayp1jmos7p670/SERVERMods.zip/file

Hi,
I am getting the same error it seems, here is the error log: https://gist.github.com/flippnfadoodle/d5a43a6859ce7c7f1b705b53f4a047e9
Here is a download link to my modpack with all of the mods hosted on the server: https://www.mediafire.com/file/94ayp1jmos7p670/SERVERMods.zip/file

I'm having any mod in that pack giving errors with mixins... what's going on? XD
The method related to the crash is there, without anything else the mod run fine both client and server side...

I am running a few data packs on my world too, would that have any effect?

can you provide me the pack?

Sure. Do you have Discord? I can zip it and send the link to you on there.

Yep, my username is the same as here: flippnfadoodle

Is a problem with architectury or loom in general, is injecting the refMap file with the wrong name. I'm going to manually fix it  with the correct name

Awesome, thank you!

Yep, my username is the same as here: flippnfadoodle

oh i meant for @Slexom rs. But i'm glad the issue was identified


64 unittest ci

close #64
@SebastianSchildt We still need to fix some testcases. I disabled executing test cases in jenkins

pls merge https://github.com/eclipse/kuksa.val/pull/63 at first

#63 is merged, but this looks weird in the diff. Can you rebase it? https://github.com/boschresearch/kuksa.val/tree/64_unittest_ci is "6 ahead, 1 behind", that does not seem right


Version 050

Version 0.5.0 is finished.

Just got to figure out these failing tests on older python versions...

The new version looks excellent, with some great new features. Thank you for all of your hard work, mate.

It's done but not on PyPI yet, because PyPI seems to be down for uploads this morning.
Sods law eh? I'll check throughout the day to see if it gets fixed.

...And it's back up. build should be live on PyPI now so you can pip install pygame_gui -U it. Or however people are grabbing their modules these days.


[RFC] Add policy to check for scratch images running privileged

The policy for scratch container images includes the check for RunAsNonRoot and does not consider the privileged setting in the container project. This PR is about to introduce a scratch container image policy to consider running privileged containers.
This PR arises from discussions on the RH support case 03250672 which triggered issue #766.
Testing the latest preflight (main branch) with issue #766 corrected, solved the parsing problem but introduced the RunAsNonRoot check again as part of the scratch policy. In preflight v1.4.0, the check has been skipped based on the project setting. This behavior might have been introduced by PR #776 which correctly detects scratch images.
Signed-off-by: Hendrik Brueckner<EMAIL_ADDRESS>

/ok-to-test
Thanks @hbrueckner! I'll start tests here for now, I have a few nits I'll throw into a review soon.

I don't think we have ever supported this use case, we'll check with the business to see if we should support it going forward.

/ok-to-test

/ok-to-test

We very much appreciate the contributions here, but we've not heard any confirmation from the Certification policy makers that this combination needs to be handled within Preflight. For now, we'll mark this closed. If the policy stance changes, we'll revisit then.

/reopen
Rebased my branch to latest main: https://github.com/hbrueckner/openshift-preflight/tree/pr-scratch-privileged

I'd absolutely like to see this moved forward. Preflight needs  to properly handle the situation where a container is privileged but is also 'scratch'.


Register the DApp on ENS

To be included in status the DApp must be available via an ENS name. This way updates will be picked up seamlessly. The name should use eth domain.
Status will follow this EIP to map to an IPFS hash: https://ethereum-magicians.org/t/eip-1062-formalize-ipfs-hash-into-ens-ethereum-name-service-resolver/281

As far as I know we don't own statusnames.eth.
The highest bid for statusnames.eth was from this account: https://etherscan.io/address/0x5b655eda7d101f98934392cc3610bcb25b633789
Here is the transaction: https://etherscan.io/tx/0x302c3c1862249f317967671cd825b6e1cef3fd1eab5ecddd574969db7e39fc37

Since we have names.stateofus.eth is this considered done?


Issue with k8s.io/cn/docs/tutorials/kubernetes-basics/cluster-intro/

This is a...

[x] Feature Request
[x] Bug Report

Problem:
Proposed Solution:
Page to Update:
https://kubernetes.io/...

opened by mistake?
/close


SVG files from vue files are not loading after building (how to disable svg extraction?)

Laravel Mix Version: 5.0.7

Description:
SVG files are being extracted from Vue files and going to /dist/images folder, however it's not loading after building everything.
Is there a way to keep loading these svg files from the original path? (src/vue/svg/*.svg) or disable extracting the files from the html?
Thanks.
Michel.

You can disable CSS url processing to stop the files from being moved. Can you provide more details (possibly a reproduction repo) about how the Vue component + SVG files are used / structured?
mix.options({
  processCssUrls: false,
})

Hi. Thanks for replying.
Actually I am not using CSS there. And this option processCssUrls is already set to false.
This is how I am importing svg files into vue component.
<template>
  <component :is="'icon-' + this.name" class="bricks-builder-icon icon"></component>
</template>

<script>
// Toolbar
import iconStructure from 'svgPath/structure.svg'
import iconHover from 'svgPath/cursor.svg'
import iconPage from 'svgPath/page.svg'
...

Laravel mix is extracting these files but actually I want it to be into the html as normal:
`

`


Shapes (Canvas) on Chrome Issues

Latest Chrome does not allow appending shapes

Thank you! I will check this out.

I should probably be more specific; I am using Ubuntu 18.04LT with Chrome:
Version 65.0.3325.181 (Official Build) (64-bit)

There's likely a better way. Users shouldn't have to disable 2D acceleration but that narrows down the problem. Thanks!


Intermediate stops are 37 instead of 42 for this connection

For this connection (Marin Epagnier - Cormondreche Grand Rue at 19:06)  we get 37 intermediate stops.

But on Hafas or sbb.ch we get 42.

Can you please have a look?
Best regards.

@terencebls I checked the connection for 14.10. and 21.10. and compared to sbb.ch and Hafas. There were all identical. Did you do send the request mit date = today or for the future?
If for today, it might be that the VDV454-REFAUS or AUS data had an impact.

kein Feedback mehr erhalten, wird werden den Issue heute schliessen


footer styling

@smaranjitghose Kindly check

Nice work @shreyakapoor08

Please fix the mobile responsiveness

Remove the line "Enter your email to get our news and updates"

@smaranjitghose Done

Awesome!


Windows 2022 20230314.1 curl no longer uploads builds

Description
curl in updated image of windows-latest no longer uploads builds correctly.
Failing upload: https://github.com/OpenRCT2/OpenRCT2/actions/runs/4494171893/jobs/7906342484#step:10:28
Successful upload: https://github.com/OpenRCT2/OpenRCT2/actions/runs/4434792917/jobs/7781167528#step:10:22
Script which executes curl: https://github.com/OpenRCT2/OpenRCT2/blob/826fa4769cf4a1bef4f0743921247faab6c8bb35/scripts/upload-build#L36
There were no changes in our backend or other parts of infrastructure. I am still able to upload builds from local machine.
The receiving end of those uploads can be found here: https://github.com/Limetric/OpenRCT2.org/blob/1826c89f96b80a9b55edce4276a19bdb7a2d64ea/src/http/routes/altapi.js#L276-L277
Platforms affected

[ ] Azure DevOps
[X] GitHub Actions - Standard Runners
[ ] GitHub Actions - Larger Runners

Runner images affected

[ ] Ubuntu 18.04
[ ] Ubuntu 20.04
[ ] Ubuntu 22.04
[ ] macOS 11
[ ] macOS 12
[ ] Windows Server 2019
[X] Windows Server 2022

Image version and build link
https://github.com/actions/runner-images/blob/win22/20230314.1/images/win/Windows2022-Readme.md
Is it regression?
win22/20230307.2
Expected behavior
Curl uploads correctly
Actual behavior
Curl fails to upload
Repro steps
Try uploading openrct2 build to openrct2.org. To aid reproduction, I can provide some way for you to upload a build to our live backend.

Hello, @janisozaur !
you are uploading files to https://openrct2.org which is served by CloudFlare.
your successful download objects are near to 100mb.
might be hitting upload limits  here ?

No, the artifacts are around 33MB. Again - I can upload them without any issues from my local machine.

Hello @janisozaur . Can you please tell which version of curl do you use on your local machine? You can just send output of curl --version command.

$ curl --version
curl 7.81.0 (x86_64-pc-linux-gnu) libcurl/7.81.0 OpenSSL/3.0.2 zlib/1.2.11 brotli/1.0.9 zstd/1.4.8 libidn2/2.3.2 libpsl/0.21.0 (+libidn2/2.3.2) libssh/0.9.6/openssl/zlib nghttp2/1.43.0 librtmp/2.3 OpenLDAP/2.5.13
Release-Date: 2022-01-05
Protocols: dict file ftp ftps gopher gophers http https imap imaps ldap ldaps mqtt pop3 pop3s rtmp rtsp scp sftp smb smbs smtp smtps telnet tftp
Features: alt-svc AsynchDNS brotli GSS-API HSTS HTTP2 HTTPS-proxy IDN IPv6 Kerberos Largefile libz NTLM NTLM_WB PSL SPNEGO SSL TLS-SRP UnixSockets zstd

I can confirm adding --http1.1 made curl successfully upload in our case. I understand this is a workaround, so feel free to close as you see fit.

@janisozaur . Thanks for your report. We close this issue for now, but if you have additional questions, feel free to ask.


As a speaker, I should be able to click the menu to access application functions.

This should be fixed now —


Please update compute-runtime

Issue copied from https://github.com/intel/compute-runtime/issues/319

Beta07 containers now have opencl 20.16.16582


METRON-500: fix assembly id

The build on current master fails because  is empty.
In previous versions of maven (before 2.2 final), leaving off the assembly id and leaving the classifier unconfigured resulted in the assembly being used as the project's main artifact. With the 2.2 release, this configuration results in a validation error.

+1 on inspection.
Just to clarify for the community, this is specifically an issue with the Maven assembly plugin version, not Maven core. Here's the reference doc - http://maven.apache.org/plugins/maven-assembly-plugin/faq.html#required-classifiers
We might want to consider specifying plugin versions explicitly to avoid this type of problem with other plugins in the future.

Agreed, while I think the rest of the assembly manifests do specify an ID, it's a good practice to specify the version explicitly to avoid this kind of issue in the future.


Space between two colons

Hi, I'm using your library for formatting SQL queries.
It works perfectly, thank you for your job.
There was discovered a minor issue with Postgresql queries though https://github.com/sasha-alias/sqltabs/issues/100
The two colons in Postgresql are used for casting a value to a certain type.
For example SELECT '1'::int will cast a string to an integer.
sql-formatter makes such queries not valid by inserting a space in between of two colons:
SELECT
  '1': :int

Hi,
I'm using the library for formatting PostgreSQL queries and the formatter inserts spaces between PGSQL specific operators like
meter -> '0' becomes meter - > '0'
meter ->> '0' becomes meter - > > '0'
etc.
I'm kinda new to these things so do let me know how I can help, say if I could contribute by writing a language support for PGSQL, etc.
Cheers!

Issue should be fixed with https://github.com/zeroturnaround/sql-formatter/releases/tag/v1.2.1.


WIP: Additional feedback for failed Octokit calls

LGTM.

LGTM.

@benbalter Please don't forget entry in History.markdown


Opening window in a subprocess from Spyder

I asked the question there:
https://stackoverflow.com/questions/55511541/subprocess-in-spyder-matplotlib-and-prints-do-not-work
Running this on a regular console works well, but from Spyder the window does not show up. Prints neither btw.
main.py:
import subprocess

subprocess.Popen("test.py", shell=True)

test.py:
import matplotlib.pyplot as plt

plt.plot([1,3,2])
plt.show()

I am using Spyder 3.3.3, python 3.7.3 on windows 10

Thanks for reporting @baudoux! We'll fix this in our next release (3.3.5).

@dalthviz, please work on this one. The idea is to add an option to Preferences > IPython Console > Advanced Settings, in a new section called Windows adjustments, that allows users to decide if they want to show or not subprocess cmd windows.


[v2.23.0] Google SCC notifier doesn't work, 500 error

Terraform module v5.0.0 + Forseti v2.23.0 on GCE.
My notifier run fails every time ~4 hours after start according to the log:
2019-10-27 18:50:47,859 INFO [forseti-security][2.23.0] google.cloud.forseti.notifier.notifiers.cscc_notifier(run): Running Cloud Security Command Center notification module.
2019-10-27 22:54:53,175 ERROR [forseti-security][2.23.0] google.cloud.forseti.services.notifier.service(_run_notifier): <HttpError 500 when requesting https://securitycenter.googleapis.com/v1/organization
s/123456789000/sources/1234567890001112223/findings?alt=json&pageToken=CusC3cy7qgAx8QqflqlfsMwLpOnD9w5itomdonX0K1oIF9Brwj8Uztlw9lYqWvw9airRnWuQUWwnucxru6Mm1ydP3pxRVGEUuePu6mj4WTsZuhYEYXO94-KsIMJdvCOyGy-QG
hY9b1EZHoFwdD-_8gAwFcoWCLafn0DCBBg8L8ICJDhItQuBASTNtQEL8J3TUi0ocpjKmt3gwsI9f0aygXMTxsT5OSmdca0-OJaoFcOPLVaXZbXjMjugvBSWlxxLVb3q-X3ZbzXe3-AhfWTRht3LLtF8d644ywr5BTKQ_8qhAIIyjKCtaSDStoimQEGw5LFd6cW4ZSF6pgIM9
CbYJGjt-vkNhMmmuOwP8JuZDFRxestHXhFw0ZDZ0xmVF6hu4i3quvoFjlUZ4_EHI8vgaD2gE_behgFt-kgbj1daMIlE5hoZaaUQujRxKBULa4NgIXTQwxWU89aV8I-E38SyZMvwm5B1QUWwvvtDON5J returned "Internal error encountered.">
Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/forseti_security-2.23.0-py3.6.egg/google/cloud/forseti/services/notifier/service.py", line 129, in _run_notifier
    self.service_config)
  File "/usr/local/lib/python3.6/dist-packages/forseti_security-2.23.0-py3.6.egg/google/cloud/forseti/notifier/notifier.py", line 187, in run
    .run(violations_as_dict, source_id=source_id))
  File "/usr/local/lib/python3.6/dist-packages/forseti_security-2.23.0-py3.6.egg/google/cloud/forseti/notifier/notifiers/cscc_notifier.py", line 285, in run
    self._send_findings_to_cscc(violations, source_id=source_id)
  File "/usr/local/lib/python3.6/dist-packages/forseti_security-2.23.0-py3.6.egg/google/cloud/forseti/notifier/notifiers/cscc_notifier.py", line 229, in _send_findings_to_cscc
    for page in paged_findings_in_cscc:
  File "/usr/local/lib/python3.6/dist-packages/forseti_security-2.23.0-py3.6.egg/google/cloud/forseti/common/gcp_api/repository_mixins.py", line 55, in list
    verb_arguments=arguments):
  File "/usr/local/lib/python3.6/dist-packages/forseti_security-2.23.0-py3.6.egg/google/cloud/forseti/common/gcp_api/_base_repository.py", line 467, in execute_paged_query
    response = self._execute(request)
  File "/usr/local/lib/python3.6/dist-packages/forseti_security-2.23.0-py3.6.egg/google/cloud/forseti/common/util/replay.py", line 169, in replay_wrapper
    return f(self, request, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/forseti_security-2.23.0-py3.6.egg/google/cloud/forseti/common/util/replay.py", line 82, in record_wrapper
    return f(self, request, *args, **kwargs)
  File "/home/ubuntu/forseti-security/.eggs/retrying-1.3.3-py3.6.egg/retrying.py", line 49, in wrapped_f
    return Retrying(*dargs, **dkw).call(f, *args, **kw)
  File "/home/ubuntu/forseti-security/.eggs/retrying-1.3.3-py3.6.egg/retrying.py", line 206, in call
    return attempt.get(self._wrap_exception)
  File "/home/ubuntu/forseti-security/.eggs/retrying-1.3.3-py3.6.egg/retrying.py", line 247, in get
    six.reraise(self.value[0], self.value[1], self.value[2])
  File "/usr/local/lib/python3.6/dist-packages/six.py", line 693, in reraise
    raise value
  File "/home/ubuntu/forseti-security/.eggs/retrying-1.3.3-py3.6.egg/retrying.py", line 200, in call
    attempt = Attempt(fn(*args, **kwargs), attempt_number, False)
  File "/usr/local/lib/python3.6/dist-packages/forseti_security-2.23.0-py3.6.egg/google/cloud/forseti/common/gcp_api/_base_repository.py", line 541, in _execute
    num_retries=self._num_retries)
  File "/home/ubuntu/forseti-security/.eggs/google_api_python_client-1.7.10-py3.6.egg/googleapiclient/_helpers.py", line 130, in positional_wrapper
    return wrapped(*args, **kwargs)
  File "/home/ubuntu/forseti-security/.eggs/google_api_python_client-1.7.10-py3.6.egg/googleapiclient/http.py", line 855, in execute
    raise HttpError(resp, content, uri=self.uri)
googleapiclient.errors.HttpError: <HttpError 500 when requesting https://securitycenter.googleapis.com/v1/organizations/123456789000/sources/1234567890001112223/findings?alt=json&pageToken=CusC3cy7qgAx8Qq
flqlfsMwLpOnD9w5itomdonX0K1oIF9Brwj8Uztlw9lYqWvw9airRnWuQUWwnucxru6Mm1ydP3pxRVGEUuePu6mj4WTsZuhYEYXO94-KsIMJdvCOyGy-QGhY9b1EZHoFwdD-_8gAwFcoWCLafn0DCBBg8L8ICJDhItQuBASTNtQEL8J3TUi0ocpjKmt3gwsI9f0aygXMTxsT
5OSmdca0-OJaoFcOPLVaXZbXjMjugvBSWlxxLVb3q-X3ZbzXe3-AhfWTRht3LLtF8d644ywr5BTKQ_8qhAIIyjKCtaSDStoimQEGw5LFd6cW4ZSF6pgIM9CbYJGjt-vkNhMmmuOwP8JuZDFRxestHXhFw0ZDZ0xmVF6hu4i3quvoFjlUZ4_EHI8vgaD2gE_behgFt-kgbj1d
aMIlE5hoZaaUQujRxKBULa4NgIXTQwxWU89aV8I-E38SyZMvwm5B1QUWwvvtDON5J returned "Internal error encountered.">

As a result I never see any event updates in Google SCC.
As per @hshin-g suggestion, I've decreased the number of calls for securitycenter_max_calls to 10  in the notifier section (https://github.com/forseti-security/terraform-google-forseti/blob/e3ed110e80ee42b87f6ede1fa348c139d479dd1f/modules/server_config/templates/configs/forseti_conf_server.yaml.tpl#L277) and re-run the notifier, I'll report if that will help.

Original issue.  https://github.com/forseti-security/terraform-google-forseti/issues/360

@red2k18 Can you please look into this to understand what the root cause is? Is this effecting everyone?

@hshin-g should have some background too

Since the report findings were uploaded to SCC at least once (on November 19), no logs, unfortunately.

@paskal Sorry to hear that. Thanks for your patience! Could you provide me an estimate of the number of violations in your environment?

Around 1000 at current moment, and historically at some point in time there were 40k of them.

Thanks @paskal! Are those 1000 violations ACTIVE? You can double check by running select count(*) from violations;. You have mentioned that findings were uploaded to CSCC on November 19th. Are you still seeing this issue or findings are being uploaded to CSCC regularly?

Hi @paskal, let's retrieve the number of ACTIVE violations in your organization as follows:

Retrieve the latest scanner_index_id by running SELECT DISTINCT created_at_datetime, scanner_index_id FROM forseti_security.violations order by created_at_datetime DESC;. You want to grab the scanner_index_id from row 1 as that corresponds to your latest scan.

Plug in the scanner_index_id retrieved in the above step in the following query to find out the number of ACTIVE violations.
select count(*) from violations where scanner_index_id=<SCANNER_INDEX_ID>;

Looking forward to hearing from you.
Thanks,
Rehana

@red2k18 I've had around 1000 ACTIVE violations after November 19th: no updates since then, Forseti hasn't been able to update security findings in SCC since then.
Where should I run these queries?

@paskal Thanks for your response. Since 1000 active violations were sent to CSCC once, let's
figure out why it's not being updated. Below are the two ways in which you can connect to MySQL to run the queries provided.

Forseti stores data in Cloud SQL database. You can connect to the Cloud SQL instance by using Cloud SQL proxy by following the instructions here, and if you choose to use MySQL Workbench you can run these queries there.

Alternatively, you can SSH into your server VM, install MySQL client by running sudo apt-get install mysql-client and connect to MySQL through localhost by running mysql -u root --host <IP_ADDRESS> --database forseti_security.  You can then run the queries provided earlier.

Could you also enable debug logs by running forseti server log_level set debug and reload the config by running forseti server configuration reload?
Please run scanner again, grab the index id and run forseti notifier run --scanner_index_id<SCANNER_INDEX_ID>. Check the logs for error messages or relevant info.
If you do not wish to run the scanner again, please plug in the latest scanner index retrieved from the queries provided earlier and run forseti notifier run --scanner_index_id<SCANNER_INDEX_ID> and share the results.
Let me know if you have any questions.
Thanks,
Rehana

Now I found out that Forseti is stuck on November, 21. I'll kill the current run and re-start it with debug logging.
ubuntu@forseti-server-vm:~$ ps auxf | grep forseti -C1
root     19259  0.0  0.0  59220  3072 ?        S    Nov21   0:00  \_ /usr/sbin/CRON -f
ubuntu   19260  0.0  0.0   4624   916 ?        Ss   Nov21   0:00      \_ /bin/sh -c (/usr/bin/flock -n /home/ubuntu/forseti-security/forseti_cron_runner.lock /home/ubuntu/forseti-security/install/gcp/scripts/run_forseti.sh -b forseti-server-6e43eb0 || echo '[forseti-security] Warning: New Forseti cron job will not be started, because previous Forseti job is still running.') 2>&1 | logger
ubuntu   19261  0.0  0.0   4624    88 ?        S    Nov21   0:00          \_ /bin/sh -c (/usr/bin/flock -n /home/ubuntu/forseti-security/forseti_cron_runner.lock /home/ubuntu/forseti-security/install/gcp/scripts/run_forseti.sh -b forseti-server-6e43eb0 || echo '[forseti-security] Warning: New Forseti cron job will not be started, because previous Forseti job is still running.') 2>&1 | logger
ubuntu   19263  0.0  0.0  12180   888 ?        S    Nov21   0:00          |   \_ /usr/bin/flock -n /home/ubuntu/forseti-security/forseti_cron_runner.lock /home/ubuntu/forseti-security/install/gcp/scripts/run_forseti.sh -b forseti-server-6e43eb0
ubuntu   19264  0.0  0.0  13308  3232 ?        S    Nov21   0:00          |       \_ /bin/bash /home/ubuntu/forseti-security/install/gcp/scripts/run_forseti.sh -b forseti-server-6e43eb0
ubuntu   19876  0.0  0.1<PHONE_NUMBER>8 ?        Sl   Nov21   9:41          |           \_ /usr/bin/python3 /usr/local/bin/forseti inventory create --import_as 20191121T165908
ubuntu   19262  0.0  0.0  34968  3192 ?        S    Nov21   0:28          \_ logger
--
ubuntu   17348  0.0  0.0  37948  3476 pts/0    R+   15:01   0:00                          \_ ps auxf
ubuntu   17349  0.0  0.0  14852  1068 pts/0    S+   15:01   0:00                          \_ grep --color=auto forseti -C1
_chrony   2542  0.0  0.0 101328  2620 ?        S    Nov19   0:00 /usr/sbin/chronyd
--
root     11273  1.8  0.4 8388732 133984 ?      Sl   Nov19 562:07  \_ /opt/google-fluentd/embedded/bin/ruby -Eascii-8bit:ascii-8bit /usr/sbin/google-fluentd --log /var/log/google-fluentd/google-fluentd.log --daemon /var/run/google-fluentd/google-fluentd.pid --under-supervisor
root     11997  0.3  0.0<PHONE_NUMBER>4 ?        Ssl  Nov19  93:10 /usr/local/bin/cloud_sql_proxy -instances=forseti-security-tool:europe-west1:forseti-server-db-6e43eb0=tcp:3306
ubuntu   12108  1.6 53.0 22010672 16383268 ?   Ssl  Nov19 497:57 /usr/bin/python3 /usr/local/bin/forseti_server --endpoint [::]:50051 --forseti_db mysql+pymysql://root@<IP_ADDRESS>:3306/forseti_security?charset=utf8 --config_file_path /home/ubuntu/forseti-security/configs/forseti_conf_server.yaml --services explain inventory model scanner notifier
root     19678  0.0  0.0 1744152 24932 ?       Ssl  Dec04   0:36 /usr/lib/snapd/snapd

ubuntu@forseti-server-vm:~$ ll /var/log/forseti*
-rw-r----- 1 ubuntu root         0 Nov 22 06:25 /var/log/forseti.log
-rw-r----- 1 ubuntu root 237972855 Nov 21 19:51 /var/log/forseti.log.1
-rw-r----- 1 ubuntu root 455198846 Nov 21 05:03 /var/log/forseti.log.2
-rw-r--r-- 1 ubuntu root 227623498 Nov 20 05:03 /var/log/forseti.log.3

Along latest log entries in /var/log/forseti.log.1 I see following:
2019-11-21 18:04:22,975 ERROR [forseti-security][2.24.0] google.cloud.forseti.services.inventory.base.resources(accept): Exception raised processing GsuiteGroup<data="{"adminCreated": true, "description":
Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/urllib3/connection.py", line 157, in _new_conn
    (self._dns_host, self.port), self.timeout, **extra_kw
  File "/usr/local/lib/python3.6/dist-packages/urllib3/util/connection.py", line 61, in create_connection
    for res in socket.getaddrinfo(host, port, family, socket.SOCK_STREAM):
  File "/usr/lib/python3.6/socket.py", line 745, in getaddrinfo
    for res in _socket.getaddrinfo(host, port, family, type, proto, flags):
OSError: [Errno 24] Too many open files

<...>
oogle.auth.exceptions.TransportError: HTTPSConnectionPool(host='iam.googleapis.com', port=443): Max retries exceeded with url: /v1/projects/-/serviceAccounts/forseti-server-gcp@forseti-security-tool.iam.gserviceaccount.com:signBlob?alt=json (Caused by NewConnectionError('<urllib3.connection.VerifiedHTTPSConnection object at 0x7f6bd3959358>: Failed to establish a new connection: [Errno 24] Too many open files',))

1. Retrieve the latest `scanner_index_id` by running `SELECT DISTINCT created_at_datetime, scanner_index_id FROM forseti_security.violations order by created_at_datetime DESC;`. You want to grab the `scanner_index_id` from row 1 as that corresponds to your latest scan.

2. Plug in the `scanner_index_id` retrieved in the above step in the following query to find out the number of ACTIVE violations.
   `select count(*) from violations where scanner_index_id=<SCANNER_INDEX_ID>;`

mysql> SELECT DISTINCT created_at_datetime, scanner_index_id FROM forseti_security.violations order by created_at_datetime DESC limit 1;
+---------------------+------------------+
| created_at_datetime | scanner_index_id |
+---------------------+------------------+
| 2019-11-19 07:13:12 |<PHONE_NUMBER>195091 |
+---------------------+------------------+
mysql> select count(*) from violations where scanner_index_id=1574147188195091;
+----------+
| count(*) |
+----------+
|     1110 |
+----------+

Hi @paskal , thanks for updates.  I'm Henry on the Forseti team at Google.  I think there are a few things happening here.  Would it be possible for you to share the /var/log/forseti.log.1 file that has the  [Errno 24] Too many open files errors?  Perhaps upload it to a GCS bucket.  Please direct message me and I can tell you my email.  Are you also on our slack?  If yes, please slack me (Henry Chang) on the #general channel.
Thanks!

@red2k18 still error 500, what I see in the log:
2019-12-10 15:36:03,414 DEBUG [forseti-security][2.24.0] google.cloud.forseti.common.gcp_api.securitycenter(__init__): Initializing SecurityCenterRepositoryClient
2019-12-10 15:36:04,126 DEBUG [forseti-security][2.24.0] google.cloud.forseti.common.gcp_api.securitycenter(__init__): Creating _SecurityCenterOrganizationsFindingsRepositoryClient
2019-12-10 15:36:07,380 DEBUG [forseti-security][2.24.0] google.cloud.forseti.common.gcp_api._base_repository(execute_paged_query): Executing paged request # 1
2019-12-10 15:36:12,383 DEBUG [forseti-security][2.24.0] google.cloud.forseti.common.gcp_api._base_repository(execute_paged_query): Executing paged request # 2
2019-12-10 15:36:17,808 DEBUG [forseti-security][2.24.0] google.cloud.forseti.common.gcp_api._base_repository(execute_paged_query): Executing paged request # 3
2019-12-10 15:36:24,238 DEBUG [forseti-security][2.24.0] google.cloud.forseti.common.gcp_api._base_repository(execute_paged_query): Executing paged request # 4
2019-12-10 15:36:30,971 DEBUG [forseti-security][2.24.0] google.cloud.forseti.common.gcp_api._base_repository(execute_paged_query): Executing paged request # 5
<...>
2019-12-10 19:41:12,577 DEBUG [forseti-security][2.24.0] google.cloud.forseti.common.gcp_api._base_repository(execute_paged_query): Executing paged request # 2625
2019-12-10 19:41:18,245 DEBUG [forseti-security][2.24.0] google.cloud.forseti.common.gcp_api._base_repository(execute_paged_query): Executing paged request # 2626
2019-12-10 19:41:22,893 DEBUG [forseti-security][2.24.0] google.cloud.forseti.common.gcp_api._base_repository(execute_paged_query): Executing paged request # 2627
2019-12-10 19:41:27,869 DEBUG [forseti-security][2.24.0] google.cloud.forseti.common.gcp_api._base_repository(execute_paged_query): Executing paged request # 2628
2019-12-10 19:41:32,749 DEBUG [forseti-security][2.24.0] google.cloud.forseti.common.gcp_api._base_repository(execute_paged_query): Executing paged request # 2629
2019-12-10 19:42:32,619 ERROR [forseti-security][2.24.0] google.cloud.forseti.services.notifier.service(_run_notifier): <HttpError 500 when requesting https://securitycenter.googleapis.com/v1/organizations/123456789000/sources/1234567890001112223/findings?alt=json&pageToken=CvQC3cy7qgAx8QqfMdJr1gDB6aDPhGuzg-KcruNII3D4hTuCevSG7RcL95APW9U8ElKGrn9AaTbBvIg4WhqfM4D9K4g3HvMaI6BjD6N5-uYCB7ojL6jnR8raXzVbKj3bdenBcLJ1_y9rQuhQ1BS8Zr_jMlFw0UDmXlNPY_c2G3P9EOHH-91JrdPxE5mt0G468vIwU7x6GE092zueXfUrGzacg0lYmaqqKm7FWBzzotajfNmml17A9gtRMdTPT84v1CtRyMiUP129f6Ocmg_ZxpuTYdC5bDtElCi23-faOqVtib3qgd3wUDswJnF3aAmuG841tIw26FyRvSOS2Ih7T0hQAMLY27-5tilRyBiDr--W8MJlilTBLttCy6iObTRW6rrhBFux1meIdCbtg2zSmqpm1X5qCSCP4mm4tNsGOZRWz3DZVZh3fUpd50mx0Y6nbBd9K-EVh__dFY55Hodm1QsRnAj1AqhAXKtM51NbrNpNLagnXwCn returned "Internal error encountered.">

As I mentioned before, there is around 40k inactive findings from the same source.
If the issue is with what I think it is (requesting too many old findings to make sure to reopen ones that were already seen) then the quick fix solution would be request old findings only with latest event date newer than X (30 days, for example).

@blueandgold please drop me a message at<EMAIL_ADDRESS>

Hi @paskal, thanks again for your help to troubleshoot this issue. The findings generated in the last Forseti run will be checked to see if it is still active. Inactive findings will not be pulled every time you run scanner and notifier. So, if there are 1k active findings in your environment then the violations generated in the next run will be checked against 1k findings only. It is up to you to clear the old 40k inactive findings. I will look more into this and circle back. Thanks for your patience.

Hi @paskal, thanks for sharing the log file. I wanted to let you know that I'm looking into it. Based on the logs, it seems that after processing 2628 pages, there is an authentication error due to which Notifier did not complete successfully.
Is it possible for you to clear out INACTIVE findings by deleting all the violations from the database and start afresh by running scanner and notifier again?
Even though it says authentication error, I'm pretty sure it is not due to Forseti-CSCC misconfiguration in your environment because 2628 pages were processed.
Looking forward to hearing from you.
Thanks,
Rehana

Hi @paskal, I'm working on a code fix that would retrieve only ACTIVE findings. That should fix this issue as we will not be retrieving 40k findings which are INACTIVE. I will let you when the fix is in. Please let me know if you have any questions.
Thanks,
Rehana

Regarding the OSError: [Errno 24] Too many open files, I can reproduce with a low ulimit of 10 on the ubuntu user that runs Forseti.  Current ulimit for the ubuntu user is 1024, which seems low; we will raise this to be higher.

@blueandgold I've tried to re-start stuck command, but it became stuck without writing anything to logs.
I've killed it and re-enabled cron, I will wait for the first stuck run and then will apply ulimit change, kill stuck run and see if it will repeat.

@blueandgold sorry but I can't get Forseti work (or fail) without the ulimit fix so far: it is stuck without any log messages. My environment doesn't seem to be reliable at this moment to test the fix.

Hi @paskal, there should be some logs.  Can you please check stackdriver, focusing on the Forseti VM as in the screenshot below?  Can you also please reset the VM, let's double-check it setup correctly.  Please let me know what you see.

Thank you

I've re-set it few hours ago with Terraform module v5.2.0 and Forseti v2.25.0 and deleted DB to have a relatively fresh start, I will write as soon as I would be able to reproduce the issue and re-start my installation with higher ulimit.

This issue will be closed only after the fix is released, and the issue is resolved in user's environment.

Closing this issue as the fix is merged in the codebase.


"Tudor Vladimirescu" is listed in the drop-down menu

Description:
"Tudor Vladimirescu" is listed in the drop-down menu alongside its corresponding county and commune, according to the law
Precondition:
The website is up an running.

Step 1
Type "Tudor Vladimirescu" in the search bar.

Expected results
The location is listed in the drop-down menu as "Sat Tudor Vladimirescu, GALAȚI (Tudor Vladimirescu)" and "Comuna Tudor Vladimirescu, GALAȚI".


Summary - Conductor Server

Link

https://netflix.github.io/conductor/server/

Installing
Requirements

Database: Dynomite
Indexing Backend: Elasticsearch 2.x
Servlet Container: Tomcat, Jetty, or similar running JDK 1.8 or higher

Configuration

Conductor server uses a property file based configuration.
The property file is passed to the Main class as a command line argument.

java -jar conductor-server-all-VERSION.jar [PATH TO PROPERTY FILE] [log4j.properties file path]

High Availability Configuration

Using Standalone Redis / ElastiCache

Check it

How to replace database to mysql or others?
Indexing backend ES2? or ES5? or others?

how to choose it?
how to install or configure it?
operation

High Availability Configuration

Conductor servers are stateless and can be deployed on multiple servers to handle scale and availability needs.
The scalability of the server is achieved by scaling the Dynomite cluster along with dyno-queues which is used for queues.
Clients connects to the server via HTTP load balancer or using Discovery (on NetflixOSS stack).


Azure Service Bus bulk support documentation

What content needs to be created or modified?
TODO - add more details.
Describe the solution you'd like

Where should the new material be placed?

The associated pull request from dapr/dapr, dapr/components-contrib, or other Dapr code repos

Additional context

/assign

Resolved


LanceDB as vectordb support

lancedb is Developer-friendly, serverless vector database for AI applications. Easily add long-term memory to your LLM apps!
please add support for this

https://github.com/SylphAI-Inc/AdalFlow/pull/236


[BUG] Smushed Blockquotes

Describe the bug
A clear and concise description of what the bug is.
Sanctum isn't recognizing my double-spaced blockquotes
To Reproduce
Make a blockquote with two paragraphs and put a blank line blockquote in between them.
Expected behavior
The space should render in preview. It doesn't.
Screenshots
Here it is on base theme:

Here it is on Sanctum:

Version [Desktop or Mobile]:
Desktop

I've identified the issue. To fix it while I don't push out a fix (I'm restructuring everything). Simply use this snippet:
blockquote p {
    display: block;
 }

That should make it act like default

(clicked wrong button to submit comment, sorry 😅 )

Please confirm if the issue has been fixed! :)


Bugfix/1484 doxygen cfg

Thanks for submitting a pull request! Please remove this text when submitting.
Summary
Remove unneeded doxygen config file directives for EXCLUDE paths and patterns because:

the source directory stan doesn't contain any such paths and patterns
on Mac OSX, these patterns seem to match everything (?) - when present, the stan source files aren't processed at all and the result is a documentation page which only information found in top-level markdown file and files in the doxygen directory.

Tests
this only affects the API docs
Side Effects
?
Checklist

[x] Math issue #(issue number)

[x] Copyright holder: (fill in copyright holder information)
The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:  Columbia University
- Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
- Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

[x] the basic tests are passing

docs build, (make doxygen)

more comments here: https://github.com/stan-dev/math/issues/1484

commented out #DOT_PATH and it builds; pushed change.
note that doxygen is still giving this warning:

/Users/mitzi/github/stan-dev/cmdstan/stan/lib/stan_math/stan/math/opencl/copy.hpp:184:
warning: argument 'src' from the argument list of stan::math::copy_cl has
multiple @param documentation sections

and everything shows up twice in the docs:
[image: Untitled.png]
On Thu, Dec 5, 2019 at 2:49 PM Steve Bronder<EMAIL_ADDRESS>wrote:

@SteveBronder approved this pull request.
I think the DOT_PATH should be commented out, but blank may also be
fine. If making the dot_path empty works on your comp (it works on mine)
then this is good to go!
In doxygen/doxygen.cfg
https://github.com/stan-dev/math/pull/1487#discussion_r354513687:

@@ -2353,7 +2350,7 @@ INTERACTIVE_SVG        = YES

found. If left blank, it is assumed the dot tool can be found in the path.
This tag requires that the tag HAVE_DOT is set to YES.
-DOT_PATH               = /usr/bin/dot
+DOT_PATH               =
Here it may be good to comment out the dot path so it knows it's not an
option we want to set
⬇ Suggested change
-DOT_PATH               =
+#DOT_PATH               =
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/stan-dev/math/pull/1487?email_source=notifications&email_token=ABJWT5HRMONJQZIDHZN52BLQXFLLDA5CNFSM4JV7C7X2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCOE7KUA#pullrequestreview-327808336,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABJWT5CH4EYQEF6JUZJLD5LQXFLLDANCNFSM4JV7C7XQ
.

pattern-matching like a monkey - this makes error go away - but is it
correct?

/** \ingroup opencl
 * Copies the source matrix to the
 * destination matrix. Both matrices
 * are stored on the OpenCL device.
 *
 * @tparam T An arithmetic type to pass the value from the OpenCL matrix to.
 * @param src the source matrix
 * @return matrix_cl with copies of values in the source matrix
 * @throw std::invalid_argument if the
 * matrices do not have matching dimensions
 */
template <typename T, typename = require_arithmetic_t<T>>
inline matrix_cl<T> copy_cl(const matrix_cl<T>&& src) {
  return matrix_cl<T>(std::forward<T>(src));
}

[image: Untitled.png]
On Thu, Dec 5, 2019 at 3:24 PM Mitzi Morris<EMAIL_ADDRESS>wrote:

commented out #DOT_PATH and it builds; pushed change.
note that doxygen is still giving this warning:

/Users/mitzi/github/stan-dev/cmdstan/stan/lib/stan_math/stan/math/opencl/copy.hpp:184:
warning: argument 'src' from the argument list of stan::math::copy_cl has
multiple @param documentation sections

and everything shows up twice in the docs:
[image: Untitled.png]
On Thu, Dec 5, 2019 at 2:49 PM Steve Bronder<EMAIL_ADDRESS>wrote:

@SteveBronder approved this pull request.
I think the DOT_PATH should be commented out, but blank may also be
fine. If making the dot_path empty works on your comp (it works on mine)
then this is good to go!
In doxygen/doxygen.cfg
https://github.com/stan-dev/math/pull/1487#discussion_r354513687:

@@ -2353,7 +2350,7 @@ INTERACTIVE_SVG        = YES

found. If left blank, it is assumed the dot tool can be found in the path.
This tag requires that the tag HAVE_DOT is set to YES.
-DOT_PATH               = /usr/bin/dot
+DOT_PATH               =
Here it may be good to comment out the dot path so it knows it's not an
option we want to set
⬇ Suggested change
-DOT_PATH               =
+#DOT_PATH               =
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/stan-dev/math/pull/1487?email_source=notifications&email_token=ABJWT5HRMONJQZIDHZN52BLQXFLLDA5CNFSM4JV7C7X2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCOE7KUA#pullrequestreview-327808336,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABJWT5CH4EYQEF6JUZJLD5LQXFLLDANCNFSM4JV7C7XQ
.

Replacing copy_cl's docs in both opencl/copy.hpp and opencl/rev/copy.hpp with the above
/** \ingroup opencl
 * Copies the source matrix to the
 * destination matrix. Both matrices
 * are stored on the OpenCL device.
 *
 * @tparam T An arithmetic type to pass the value from the OpenCL matrix to.
 * @param src the source matrix
 * @return matrix_cl with copies of values in the source matrix
 * @throw std::invalid_argument if the
 * matrices do not have matching dimensions
 */

did the trick for me!

OK - do you want that doc fix to go in with this PR?

Yeah I think its appropriate if you dont mind. Then no warnings on doxygen

ready for re-review and re-approval.


Updated badge component

Updated the badge component so that  now it is more easy to edit the data

Done with the suggested changes


Stop using tslint

Turns out we are still running tslint as part of CI and have it specified. It's a deprecated tool, so we should shift over to eslint.

@brettcannon @kimadeline Is it possible to just have the ESlint check running for new code? We'll still need to keep running TSlint for old code, correct?

Why would we need to keep TSLint?

We can't run ESLint on old code, as for now.

It's not that we can't, it's that we disabled it for now. Once we remove all files from the .eslintignore I don't see any reason for us to keep TSLint around.

@kimadeline Yes eventually, but it'll take a while to correct ESLint errors for all files so that we can remove all files from .eslintignore, and this is marked as a P1.

@brettcannon can we close this?

@brettcannon can we close this?


make release script compatible with forks

Describe the bug
The current lerna release script was written assuming that the origin branch is the primary apache-superset/superset-ui repo, as opposed to a fork. This is problematic because

forks may not be up to date with apache-superset/superset-ui
publishing pushes tags and package version number changes to the fork instead of apache-superset/superset-ui, requiring a second PR to update the main repo.

cc @kristw @soboko @xtinec @conglei

The codebase on this repo has been moved to the main Apache Superset repo, and consequently the repo is in the process of being archived. See the Superset Improvement Proposal for details: https://github.com/apache/superset/issues/13013 . While all currently open issues and PRs will be closed, we encourage you to reopen this issue on the main repo if it is still relevant.


Support 1.7.10 and 1.12.2.

Title.
While Essential exists on 1.12.2, this mod isn't adding all the cosmetics/chat functionality and such that they do, so porting shouldn't be that hard. I hope.

due to... internal issues, backports aren't planned.


qt5 plugins: follow meta-qt5 changes

meta-qt5 commit b716195f6 dropped the qt5 directory from the path to
the plugins directory.
Signed-off-by: Max Krummenacher<EMAIL_ADDRESS>

Hi Andreas
I believe that this change is backward compatible, i.e. it should pick up the /qt5/ path element from meta-qt5 before commit b716195f6. I did not actually try that though.
I runtime tested lxqt-qtplugin in a running installation.
I only build marble but I did not check if it actually runs.
Max

Thanks


Add/remove service env commands

This PR adds kontena service add-env and kontena service remove-env subcommands for easier service env variable manipulation.

looking awesome!


add chinese bank account

this my first time,i never do work for a open source project.i will do my best

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@27a216c). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #2023   +/-   ##
=========================================
  Coverage          ?   70.49%
  Complexity        ?     1600
=========================================
  Files             ?      287
  Lines             ?     3864
  Branches          ?        0
=========================================
  Hits              ?     2724
  Misses            ?     1140
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27a216c...b3edb95. Read the comment docs.


Global Badge show descriptions view does not provide access to self report button

Viewing a Global Badge in the client-display or My Badges view does not provide access to the self report "I did it" button when enabling show descriptions for the Global Badge's skills.

obe


Add contributor credits to Readme

After discussions following #130, it was decided that Envato alumni that have contributed to this gem should be recognised for their work in the Readme file, while only current employees should be retained in the gemspec authors array, due to the permissions granted by being included in that list.

@asellitt - updated hopefully one last time!

brilliant!


Why years not change?

Hi, Boss
I set locale to 'th' already coz i need Thai language calendar
but why when i will return to select  others years
thats years is not Thai locale. i need to show Thai years locale
How to fix it? Help me Bossss ToT
*i am junior programmer
**Thai years = normal years + 543

Thank You.

I guess thai year is not supported in javascript.
This is not an issue from the picker. I would close this.


Run bm-bridge and bm-server as a service

This will allow to install a service to run bm-server or bm-bridge automatically.
It will also use now a config file for bm-bridge and add support to run bm-bridge in your own organization, this way you can host your own mailgateway! account  to translate BitMaelum messages to email addresses on your own organization.

let's merge


SNS BroadcastReceiver not found

Registration works fine. However when receiving a simple text message from SNS, android crashes the app stating it cannot find BroadcastReceiver at neither my appname path or the com.amazonaws.unity path. Latest sdk downloaded from the read me. Included google play services jar and support v4.jar.
Manifest attached:
AndroidManifest.xml.zip

Can you share sample code that demonstrates the issue and details on the SDK/version you are using?

It's pretty much the latest everything. The scene im building is the default test scene included in the unity package. SDK is aws-sdk-unity_<IP_ADDRESS>

The GCM registration bit is outdated in the sdk. you could take a look at code in this package https://github.com/awslabs/aws-sdk-unity-samples/tree/master/SNS/gcmhelper-src and try to implement the mechanism using the latest google play services.


python_examples: Validate error responses.

This PR is a follow-up of #30115. It adds assert statements to validate the error response for the "400" error code. The current validation using validate_against_openapi_schema doesn't correctly validate "400" responses.

Fixes:

Screenshots and screen captures:

Self-review checklist

[x] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[x] Explains differences from previous plans (e.g., issue description).
[x] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[x] Each commit is a coherent idea.
[x] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[ ] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

@laurynmm can you review this?

The current validation using validate_against_openapi_schema doesn't correctly validate "400" responses.

In what way is that validation not correct? It's not obvious to me why the remedy should be to remove that vs., for example, checking both.

As explained here, validate_against_openapi_schema will always return True for 400 responses. I can keep both checks for responses but this function will not currently validate the 400 ones.

I think it's better to keep the validate_against_openapi_schema statements even if they always succeed with the current OpenAPI spec; that may not be the case for the future as the spec changes, and I can easily see us forgetting to re-add validation.

My one concern is that it then looks like these documented error responses are being validated as part of this test, when we're really just skipping any validation for 4xx responses.

My view is we should probably open an issue to track removing https://github.com/zulip/zulip/pull/30115#discussion_r1608151616, rather than removing infrastructure in other places; that seems like the simpler path to having complete validation down the line.

Okay. Makes sense.
@Vector73 - For this PR, the consensus is to not remove validate_against_openapi_schema for these error tests, but to add the new check on the error code returned.
We most recently talked about documenting error responses on CZO here: https://chat.zulip.org/#narrow/stream/412-api-documentation/topic/documenting.20error.20responses/near/1644535. It's a bit more complicated than the code comment in zerver/openapi/openapi.validate_test_response implies in that we've not yet updated our documentation generators to handle examples fields in the API documentation.

@laurynmm I have updated this PR.

Looks great, merged, thanks @Vector73!


Ensure DOM is settled

Issue #217
Proposed change
Get rid of setTimeout brute force
Why
Ineffective (see why in the issue)
Outcome / numbers:
Process that took as a 1s to perform now takes about 1-5 ms (that's how much it actually takes for DOMContentLoaded event to be emitted)
However, since the pages Shortest navigates through may experience DOM mutations even after the initial page load (e.g., when modals are opened), we continue to wait until all DOM mutations are completed using MutationObserver

@slavingia FYI Currently, implementing such functionality without Playwright will be challenging and time-consuming as Playwright has its own internal lifecycle events that it emits / consumes
When trying to do this natively I receive:
Failed to wait for stable DOM: page.evaluate: Error: Timed out after 1000ms waiting for the DOM to stabilize.
at eval (eval at evaluate (:234:30), <anonymous>:5:15)

See how Playwright listens to events
See how Playwright emits events
I think we could always start with Playwright and then deprecated it with .evaluate and other deps altogether

Sounds good, we can keep playwright for now!


Zowe Charter

Can we look at creating a better way for people to view/consume the Zowe charter? i.e. how to propose a new project, how to become a committer, how to become a leader, etc.

John volunteered to take the PDF for the project and ready it for publishing on the website.

Items have been posted to the Zowe website.  for additional changes they will be track individually going forward.


Fix attachment send

Gets rid of our placeholder message when the service replies with the real one. r? @keybase/react-hackers

only added comment since CI, merging


what is /protobuf/GeneratedMessageLite ?

Hi,
I am using the hand tracking for mobile on Android. I have already built the app on my phone and all works fine.
Now I am trying to make a native android plugin with hand tracking in order to use it in Unity. I am struggling with this error when i use the plugin i have created :
 E/Unity: AndroidJavaException: java.lang.NoClassDefFoundError: Failed resolution of: Lcom/google/protobuf/GeneratedMessageLite;

Indeed, in the aar created with mediapipe there is no class com.google.mediapipe.protobuf ....
Any idea to solve this issue ?
Thanks

@romaindebraize Did you ever figure this out?


Build failure: feishu

Steps To Reproduce
Steps to reproduce the behavior:
NIXPKGS_ALLOW_UNFREE=1 nix-shell -p feishu

Build log
these 2 derivations will be built:
  /nix/store/kwknr3bqjk2lbjz8k8iin105q2i6qzsp-Feishu-linux_x64-6.9.20.deb.drv
  /nix/store/cp7d3758ax7kg7vs6xppkd728ak0gqpb-feishu-6.9.20.drv
building '/nix/store/kwknr3bqjk2lbjz8k8iin105q2i6qzsp-Feishu-linux_x64-6.9.20.deb.drv'...

trying https://sf3-cn.feishucdn.com/obj/ee-appcenter/6085d1c4/Feishu-linux_x64-6.9.20.deb
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0   238    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (56) The requested URL returned error: 403
error: cannot download Feishu-linux_x64-6.9.20.deb from any mirror
error: builder for '/nix/store/kwknr3bqjk2lbjz8k8iin105q2i6qzsp-Feishu-linux_x64-6.9.20.deb.drv' failed with exit code 1;
       last 7 log lines:
       >
       > trying https://sf3-cn.feishucdn.com/obj/ee-appcenter/6085d1c4/Feishu-linux_x64-6.9.20.deb
       >   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
       >                                  Dload  Upload   Total   Spent    Left  Speed
       >   0   238    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
       > curl: (56) The requested URL returned error: 403
       > error: cannot download Feishu-linux_x64-6.9.20.deb from any mirror
       For full logs, run 'nix log /nix/store/kwknr3bqjk2lbjz8k8iin105q2i6qzsp-Feishu-linux_x64-6.9.20.deb.drv'.
error: 1 dependencies of derivation '/nix/store/cp7d3758ax7kg7vs6xppkd728ak0gqpb-feishu-6.9.20.drv' failed to build

Additional context
Looks like previous URL is now invalid / offline:
https://sf3-cn.feishucdn.com/obj/ee-appcenter/6085d1c4/Feishu-linux_x64-6.9.20.deb
and new URL has a signature / expiration date:
https://lf6-ug-sign.feishucdn.com/ee-appcenter/ec62a2df/Feishu-linux_x64-7.11.9.deb?lk3s=fb957577&x-expires=1715609237&x-signature=ZCPomgDbIhivceMDBZxXXqfOs4E%3D
Notify maintainers

@BillHuang2001
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 6.6.30, NixOS, 24.05 (Uakari), 24.05.20240509.f1010e0`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.18.2`
 - channels(root): `"nixos-23.11"`
 - nixpkgs: `/nix/store/asymc3nsl739p1wwr0w6xbjnqs3qb94p-source`

Add a :+1: reaction to issues you find important.

Yes, they changed the download link, and what's worse is that the x-expire and x-signature are dynamically generated.
To generate a new link, we first need to access https://www.feishu.cn/api/package_info?platform=12, which returns a json that contains the download link.
{"code":0,"message":"ok","data":{"download_link":"https://lf9-ug-sign.feishucdn.com/ee-appcenter/923be831/Feishu-linux_arm64-7.11.9.deb?lk3s=fb957577\u0026x-expires=1715613509\u0026x-signature=n7%2Bve50z6IrfliFGhhrFfYKB69U%3D","qr_link":"","version_number":"Linux-arm64-deb@V7.11.9","weight":701100920000,"hash":"8d3ac85e628a0a6ac61e07e6b281bf08","release_time":"1711505186"}}

But since this link is impure, we cannot really use that. Unless the original link is restored, I'm afraid there's no viable solution to this issue.😢

If upstream's CDN decides that people can only have a temporary link to their resources, there's nothing we can really do. Maybe tell people to download the .deb themselves via requireFile.

I don't think requireFile is sufficient. The current download server only provides the latest version of feishu, which means the hash will change with each update, causing the package to break.

Perhaps one of you could reach out to them. I tried, but I think they didn't understand what I meant and kept asking me to go to their website and click on the Linux download icon....

They replied me this:
你好，可以用构造的这个版本试下，链接我下载两次查看时一样的 根据设备芯片版本选择下载
https://voffline.byted.org/download/tos/schedule/mybucket/2c813f40/Feishu-linux_x64-7.11.0-dev.d9221687.zip
https://voffline.byted.org/download/tos/schedule/mybucket/2c813f40/Feishu-linux_x64-7.11.0-dev.d9221687.uos.deb
https://voffline.byted.org/download/tos/schedule/mybucket/2c813f40/Feishu-linux_x64-7.11.0-dev.d9221687.deb
https://voffline.byted.org/download/tos/schedule/mybucket/2c813f40/Feishu-linux_x64-7.11.0-dev.d9221687.rpm
Is it of any use?

It would be of great use. But the link doesn't to work for me, voffline.byted.org seems to be an internal address.

They replied me this:
你好，可以用构造的这个版本试下，链接我下载两次查看时一样的 根据设备芯片版本选择下载
voffline.byted.org/download/tos/schedule/mybucket/2c813f40/Feishu-linux_x64-7.11.0-dev.d9221687.zip
voffline.byted.org/download/tos/schedule/mybucket/2c813f40/Feishu-linux_x64-7.11.0-dev.d9221687.uos.deb
voffline.byted.org/download/tos/schedule/mybucket/2c813f40/Feishu-linux_x64-7.11.0-dev.d9221687.deb
voffline.byted.org/download/tos/schedule/mybucket/2c813f40/Feishu-linux_x64-7.11.0-dev.d9221687.rpm
Is it of any use? (the mybucket on the url looks sus)

Domain's unknown on my end. Might be internal or exclusive to China

Well yeah I also cant download it... I told them and they sent be back to their download page.. hard to talk with them.. meanwhile I found this:
https://sf3-cn.feishucdn.com/obj/ee-appcenter/ec62a2df/Feishu-linux_x64-7.11.9.deb
https://sf3-cn.feishucdn.com/obj/ee-appcenter/923be831/Feishu-linux_arm64-7.11.9.deb
These links are working...

Well yeah I also cant download it... I told them and they sent be back to their download page.. hard to talk with them.. meanwhile I found this:
sf3-cn.feishucdn.com/obj/ee-appcenter/ec62a2df/Feishu-linux_x64-7.11.9.deb sf3-cn.feishucdn.com/obj/ee-appcenter/923be831/Feishu-linux_arm64-7.11.9.deb
These links are working...

I do speak Chinese, so if you're encountering some language difficulties, I can provide some language aid :D

Oh I found the secret sause!
if you take the original link from here: https://www.feishu.cn/api/package_info?platform=12
{
  "code": 0,
  "message": "ok",
  "data": {
    "download_link": "https://lf9-ug-sign.feishucdn.com/ee-appcenter/923be831/Feishu-linux_arm64-7.11.9.deb?lk3s=fb957577\u0026x-expires=1715688830\u0026x-signature=3HVuuydL6wI7nYdhbHUHwpeeRgk%3D",
    "qr_link": "",
    "version_number"<EMAIL_ADDRESS>    "weight":<PHONE_NUMBER>00,
    "hash": "8d3ac85e628a0a6ac61e07e6b281bf08",
    "release_time": "1711505186"
  }
}

and replace the domain:
https://lf9-ug-sign.feishucdn.com/ee-appcenter/923be831/Feishu-linux_arm64-7.11.9.deb
with
https://sf3-cn.feishucdn.com/obj/ee-appcenter/923be831/Feishu-linux_arm64-7.11.9.deb
It works \o/

Oh I found the secret sause!
if you take the original link from here: feishu.cn/api/package_info?platform=12
{
  "code": 0,
  "message": "ok",
  "data": {
    "download_link": "https://lf9-ug-sign.feishucdn.com/ee-appcenter/923be831/Feishu-linux_arm64-7.11.9.deb?lk3s=fb957577\u0026x-expires=1715688830\u0026x-signature=3HVuuydL6wI7nYdhbHUHwpeeRgk%3D",
    "qr_link": "",
    "version_number"<EMAIL_ADDRESS>    "weight":<PHONE_NUMBER>00,
    "hash": "8d3ac85e628a0a6ac61e07e6b281bf08",
    "release_time": "1711505186"
  }
}

and replace the domain:
lf9-ug-sign.feishucdn.com/ee-appcenter/923be831/Feishu-linux_arm64-7.11.9.deb
with
sf3-cn.feishucdn.com/obj/ee-appcenter/923be831/Feishu-linux_arm64-7.11.9.deb
It works \o/

IIIIIInteresting! That means we can easily automate the update logic into an update script and put that in passthru.updateScript! Huzzah!

Looks like x86_64-linux is platform 10 and aarch64-linux is platform 12. If we ever decide to support this on macOS, x86_64-darwin is platform 6 and aarch64-darwin is platform 9.

This seems to work pretty well:
$ curl -sf "https://www.feishu.cn/api/package_info?platform=12" | jq -r '.data.download_link' | sed 's/lf9-ug-sign/sf3-cn/;s/?.*$//'
https://sf3-cn.feishucdn.com/ee-appcenter/923be831/Feishu-linux_arm64-7.11.9.deb

It gives 404 to me without the /obj/

It gives 404 to me without the /obj/

Oops! Try curl -sf "https://www.feishu.cn/api/package_info?platform=12" | jq -r '.data.download_link' | sed 's/lf[0-9]*-ug-sign.feishucdn.com/sf3-cn.feishucdn.com\/obj/;s/?.*$//' instead :sweat_smile:

Welp, I tried to package the most recent version but I'm completely slumped by this mysterious SIGTRAP deep inside the code itself.
                #0  0x00007d6c09fb1f3d n/a (libframe.so + 0x81b1f3d)
                #1  0x00007d6c08eba6db n/a (libframe.so + 0x70ba6db)
                #2  0x00007d6c0e8d7975 n/a (libframe.so + 0xcad7975)
                #3  0x00007d6c0e992992 n/a (libframe.so + 0xcb92992)
                #4  0x00007d6c07d7dd85 n/a (libframe.so + 0x5f7dd85)
                #5  0x00007d6c0acd5bff n/a (libframe.so + 0x8ed5bff)
                #6  0x00007d6c07a30c4e n/a (libframe.so + 0x5c30c4e)
                #7  0x00007d6c07a227a3 n/a (libframe.so + 0x5c227a3)
                #8  0x00007d6c07f197e3 n/a (libframe.so + 0x61197e3)
                #9  0x00007d6c0e80aa31 n/a (libframe.so + 0xca0aa31)
                #10 0x00007d6c08eac86c n/a (libframe.so + 0x70ac86c)
                #11 0x00007d6c08ec1faf LarkMain (libframe.so + 0x70c1faf)
                #12 0x000056cc7f3920b4 n/a (.feishu-wrapped + 0x270b4)
                #13 0x00007d6c1394110e __libc_start_call_main (libc.so.6 + 0x2a10e)
                #14 0x00007d6c139411c9 __libc_start_main@@GLIBC_2.34 (libc.so.6 + 0x2a1c9)
                #15 0x000056cc7f38a32a _start (.feishu-wrapped + 0x1f32a)

libframe.so is a vendored dependency and it's completely devoid of any debug symbols, which makes this very annoying to debug. The fact that getting GDB to work with two layers of wrappers is also very annoying and I'm feeling like I need some outside help.
@BillHuang2001 Any insights?

Could you please test my latest PR? I've been unable to reproduce the error you're experiencing. Additionally, it would be greatly appreciated if someone could verify the ARM build to ensure it's working as expected.


Is is possible to change the key inside of a page property which is also an object?

Look at https://github.com/ariya/phantomjs/blob/master/examples/netsniff.js:
            page.onResourceReceived = function (res) {
                if (res.stage === 'start') {
                    page.resources[res.id].startReply = res;
                }
                if (res.stage === 'end') {
                    page.resources[res.id].endReply = res;
                }l
            };

How to change page.resources[res.id] using page.property()?

You can use property but I am not sure if it would work in onResourceReceived. Maybe someone else can help because I am not sure what you are trying to do.

Try this:
page.on('onResourceReceived', true, function (res) {
    if (res.stage === 'start') {
        this.resources[res.id].startReply = res;
    }
    if (res.stage === 'end') {
        this.resources[res.id].endReply = res;
    }
});

@elias-winberg Thank you! I believe your way is working, and this should appear in docs example.
But here is what I find. Have a look at https://github.com/ariya/phantomjs/blob/master/examples/netsniff.js#L129
    page.open(page.address, function (status) {
        var har;
        if (status !== 'success') {
            console.log('FAIL to load the address');
            phantom.exit(1);
        } else {
            page.endTime = new Date();
            page.title = page.evaluate(function () {
                return document.title;
            });
            har = createHAR(page.address, page.title, page.startTime, page.resources);
            console.log(JSON.stringify(har, undefined, 4));
            phantom.exit();
        }
    });

If we change to phantom-node, the code should be like this:
        .then(page => {
            /* do something  */

            return page.open('http://www.yahoo.com')
        })
        .then(function(status) {
            var har;
            if (status !== 'success') {
                console.log('FAIL to load the address');
                phInstance.exit(1);
            } else {
                this.endTime = new Date();
                this.title = this.evaluate(function () {
                    return document.title;
                });
                har = createHAR(this.address, this.title, this.startTime, this.resources);
                console.log(JSON.stringify(har, undefined, 4));
                phInstance.exit();
            }
        })

However, in page#open, there is no reference to WebPage at all, this is undefined.

@legendtang, #on methods are bounded to page objects and that's why this.resouces work. But other methods are not bounded to page. That's why open doesn't work. It wouldn't be hard to add it but I wonder if it makes sense to do that because in vanilla phantomjs, it is also not bounded to this.
Either way, we should figure out what you think should be done so that I can close or keep this ticket open.

@amir20 Thank your for the explanation. I migrate to child_process with vanilla phantomjs eventually. I think phantomjs-node should find a proper way to fully support vanilla usage.

The goal of this module is not to support 100% vanilla phantomjs. That would be replicating every single phantomjs functionality which would be very difficult. That would be recreating phantomjs which isn't the goal. If you can get away using child_process then you should. But the goal of this module is to allow people communicate back and fourth between phantomjs and node easy. An example could be if you are trying to show a progressbar and you need to have hooks in nodejs to update the status. You can't do that with child_process.

@amir20 That's excactly why I use phantomjs-node as a first choice before. I know a fully integration is not your goal. Like that example, my aim is to collect and to deal with the output with the property of page, and maybe to send back to phantomjs. Now using child_process I have to listen on process output add cut those strings down to what I want. And sometimes, you know, child_process would give half or two-combined lines (\r\n) which are very difficult to deal with that case. Well, I still like the ticket to be open with title changes. At least I think page should be bounded to more use cases

It sounds like you are trying to solve a lot of problems that were solved in this module. I spend at least a couple hours fixing \r\n in pipe. Could I somehow excited you to fix the problem in this module instead? It sounds like you are investing a lot of time in a solution that you are going to use, but giving back to an open source project could improve this for others and yourself in the future.
Regardless of what you end up doing, thanks for the feedback. If there was an easy way to just support all vanilla features in regards to this particular ticket then I would gladly take a PR and help you merge it.


imp: add a check for the client status in CreateClient

Description
closes: #186
Commit Message / Changelog Entry
imp: add a check for the client status in CreateClient

see the guidelines for commit messages. (view raw markdown for examples)

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

[x] Targeted PR against correct branch (see CONTRIBUTING.md).
[x] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
[ ] Code follows the module structure standards and Go style guide.
[x] Wrote unit and integration tests.
[ ] Updated relevant documentation (docs/) or specification (x/<module>/spec/).
[ ] Added relevant godoc comments.
[x] Provide a commit message to be used for the changelog entry in the PR description for review.
[x] Re-reviewed Files changed in the Github PR explorer.
[ ] Review Codecov Report in the comment section below once CI passes.

Codecov Report

Merging #3514 (522257b) into main (7987251) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3514   +/-   ##
=======================================
  Coverage   78.78%   78.78%
=======================================
  Files         182      182
  Lines       12687    12690    +3
=======================================
+ Hits         9995     9998    +3
  Misses       2261     2261
  Partials      431      431

Impacted Files
Coverage Δ

modules/core/02-client/keeper/client.go
91.89% <100.00%> (+0.22%)
:arrow_up:


[OTHER] delete gitigore file in server husky

What would you like to share?
https://github.com/Dun-sin/Whisper/blob/main/server/.husky/.gitignore
Are you willing to work on this issue ?
None

I am willing to work on this issue. Please assign it to me.

I am willing to work on this issue. Please assign it to me.

Definitely, thanks for wanting to contribute, make sure you follow the rules 👉🏽here👈🏽, else your PR will not be accepted and will be closed. Good Luck.

I can solve this issue immediately .If it's okay with @sohamtembhurne , could @Dun-sin assign it to me?

I have no issues. @Dun-sin, please unassign me and assign this to @ParthMakode

Then let me resolve this issue. Thanks for the quick response

Then let me resolve this issue. Thanks for the quick response

You already gave it up lol

Then let me resolve this issue. Thanks for the quick response

You already gave it up lol

I was only giving someone else a chance. Didn't knew he had worked on another issue. Anyway, it's upto you

Hi, can I work on this issue?

Hi @Dun-sin , can I work on this issue?

Definitely, thanks for wanting to contribute, make sure you follow the rules 👉🏽here👈🏽, else your PR will not be accepted and will be closed. Good Luck.

Then let me resolve this issue. Thanks for the quick response

You already gave it up lol

I was only giving someone else a chance. Didn't knew he had worked on another issue. Anyway, it's upto you

@sohamtembhurne that's good of you but yeah you gave someone else a chance, if I assign it to you again and someone asks again and you give them, would just be a never ending circle😆
If you truly don't want to work on anything don't ask for it or if you want to but also want to give someone a chance, try a collaboration instead.
In this case giving it up or a collaboration doesn't make sense😆 but hey up to you