UK not accepted as a CountryCode

I know the official alpha-2 code is GB and UK is part of the "exceptional reservations" list of iso3166-1 alpha-2, but frankly, all addresses in Great Britain have a post code of UK.
I think it could be useful to include UK as well, in cases where one wants to use e.g. country: CountryCode for address validation or the like.

@flaeppe I don't think I agree with this.
Your proposal completely changes the meaning of the CountryCode type, and I think it'd be very hard to convince me a non standards confirming type is more useful.
An alternative would be to introduce a new type, but I'm not sure what that type should be to fit your usecase. Doesn't addresses usually just have the full name of the country? E.g. "United Kingdom" in your case?
FWIW I believe french is the official international postal language so, technically "La Suède" is as correct as "Sweden" on a parcel sent to Sweden. What I'm trying to get at is that I don't think that it makes sense for the CountryCode type to have the ability to determine whether or not an address country is correct, and I'm not confident such ability fits here. Wdyt? I'm open to further discussion!

Any additional type feels a bit off.
Think I opened this issue a bit hastily, and indeed one could perhaps go for a verbose value of the code GB to be UK.
What I initially got in trouble with was aligning with other parties. But so, if they claim to follow the iso3166-1 alpha 2 standard there shouldn't really be any problem one have to overcome.


No validation of FunctionName

Description:
When deploying an AWS::Serverless::Function with an explicit FunctionName property set, there's no validation that this meets the AWS Lambda function name rules.
Steps to reproduce the issue:

Deploy the following sam template (note that FunctionName includes a forward slash, which is not allowed for function names):

AWSTemplateFormatVersion : '2010-09-09'
Transform: AWS::Serverless-2016-10-31
Description: A hello world application.

Resources:
  HelloWorldFunction:
    Type: AWS::Serverless::Function
    Properties:
      Handler: index.handler
      FunctionName: test/function
      Runtime: nodejs6.10
      CodeUri: src/

Check Cloudformation for errors

Observed result:
Cloudformation returns:
CREATE_FAILED | nullnull (Service: AWSLambdaInternal; Status Code: 400; Error Code: null; Request ID: null)

Expected result:
A validation error that clearly identifies that FunctionName can contain only letters, numbers, hyphens, and underscores.

Hi @hwatts, we don't plan on replicating server side validation on the client side.

There has been a ticket raised internally 😀


Initialise logging earlier

So that the logging for the socket setup is captured.

The logging initialisation is deliberately quite late, because I had trouble with ordering of initialisation as  this happens so early in program startup. The socket code logging is generally not interesting because it's the same thing every time, and if you need to debug it then you can either make this change locally or attach a debugger to the process from startup and see the logging that way. Is there a reason why this should be changed for all builds?

Ah I see. If this is deliberate, that's fine. Just had an issue with using the wrong port for target control.


Link in sidebar should go to github.io not github.com

Hi, the link in the sidebar should go to https://ebassi.github.io/graphene/ instead of https://ebassi.github.com/graphene/.

Apologies for the superfluous ticket, I figured that was the quickest way to get in contact.
Have a nice day! :wave:

Indeed! Thanks for reporting the issue.


finished code challenge 5

Code Challenge 05 - Linked List Implementation

[x] Create a Node class that has properties for the value stored in the Node, and a pointer to the next Node.

[x] Within your LinkedList class, include a head property. Upon instantiation, an empty Linked List should be created.

[x] Define a method called insert which takes any value as an argument and adds a new node with that value to the head of the list with an O(1) Time performance.

[x] Define a method called includes which takes any value as an argument and returns a Boolean result depending on whether that value exists as a Node’s value somewhere within the list.

[x] Define a method called toString which takes in no arguments and returns a string representing all the values in the Linked List, formatted as: "{ a } -> { b } -> { c } -> NULL"

[x] Any exceptions or errors that come from your code should be semantic, capturable errors. For example, rather than a default error thrown by your language, your code should raise/throw a custom, semantic error that describes what went wrong in calling the methods you wrote for this lab.

[x] Be sure to follow your language/frameworks standard naming conventions.


Relative paths break cquery

My build output is parsed relative to a build directory. The output of the build is of the form ../../../src/MyFile.cpp.
If I open a file from the problems tab vs code seems to open it as <full_path_to_build_dir>/../../../src/MyFile.cpp
In this case i get errors
Message: Unable to find file <full_path_to_build_dir>/../../../src/MyFile.cpp
If I close the file and re-open it it is opened without ../../../ and cquery is happy
I believe the following diff resolves the issue for me (although I haven't given it thorough testing and I doubt it's a cross platform fix)
diff --git a/src/language_server_api.cc b/src/language_server_api.cc
index 9c1471c..e6b38b6 100644
--- a/src/language_server_api.cc
+++ b/src/language_server_api.cc
@@ -1,5 +1,8 @@
 #include "language_server_api.h"

+#include <climits>
+#include <cstdlib>
+
 #include <doctest/doctest.h>
 #include <loguru.hpp>

@@ -260,6 +263,10 @@ std::string lsDocumentUri::GetPath() const {
   // std::transform(result.begin(), result.end(), result.begin(), ::tolower);
 #endif

+  char* newresult = realpath(result.c_str(), NULL);
+  result = std::string(newresult);
+  free(newresult);
+
   return result;
 }

is this with the newest master branch? we got a fix for something with relative paths yesterday i think

I did my initial test on d5b0ffa067f9, however I just pulled and i have the same issue. Applying my fix on master still solves it.

i dont remember if cquery uses boost, but i believe boost::filesystem::canonical would do the trick in a cross-platform manner

GetPath should be audited to make sure it is not called in any performance critical places otherwise this fix SGTM if GetPath is renamed to GetCanonicalPath

Also there is no boost, but there is a per-platform NormalizePath function which does this.

We should find some replacement for realpath. It resolves symlinks and when a source file in a project is a symlink, we actually do not want to resolve it.

@MaskRay I definitely think realpath is not the way to go here. I was not trying to suggest that this should be the fix. I just wanted to give an example of something that made the problem better in my specific use case to illustrate the area where the problem could be.


CRDB: detect draining nodes on connection acquisition

At higher scales, creating new connections against CRDB dominates SpiceDB latency.
We currently follow best-practices around connection draining by ensuring that our connection max lifetimes are <5m, which ensures all connections are drained properly during node drains in Cockroach Dedicated.
As we add more SpiceDB nodes and CRDB nodes, we increase the number of connections to take advantage of the extra capacity. CRDB connection latency increases as connection rate increases.
This PR checks the connection when we acquire it from the pool. If the node is draining, the connection is closed and we grab a new one instead. This allows us to extend lifetimes past 5m and still handle node drains.
This has a negative performance impact on CRDB at low scales - detecting when a node is draining requires another roundtrip, and this comes through in the benchmarks:
goos: darwin
goarch: arm64
pkg: github.com/authzed/spicedb/internal/datastore/benchmark
                                                                       │   old.txt    │                new.txt                 │
                                                                       │    sec/op    │    sec/op      vs base                 │
DatastoreDriver/cockroachdb-overlap-static/TestTuple/SnapshotRead-10     866.3µ ± 12%   1720.0µ ±  9%   +98.56% (p=0.000 n=10)
DatastoreDriver/cockroachdb-overlap-static/TestTuple/Touch-10            11.93m ±  7%    11.56m ±  6%         ~ (p=0.165 n=10)
DatastoreDriver/cockroachdb-overlap-static/TestTuple/Create-10           13.10m ± 12%    12.89m ±  5%         ~ (p=0.353 n=10)
DatastoreDriver/cockroachdb-overlap-insecure/TestTuple/SnapshotRead-10   876.6µ ±  9%   1807.8µ ±  7%  +106.23% (p=0.000 n=10)
DatastoreDriver/cockroachdb-overlap-insecure/TestTuple/Touch-10          4.223m ± 10%    5.215m ±  9%   +23.49% (p=0.000 n=10)
DatastoreDriver/cockroachdb-overlap-insecure/TestTuple/Create-10         3.834m ±  9%    4.699m ± 15%   +22.56% (p=0.000 n=10)
geomean                                                                  3.526m          4.741m         +34.47%

                                                                       │   old.txt    │               new.txt                │
                                                                       │     B/op     │     B/op      vs base                │
DatastoreDriver/cockroachdb-overlap-static/TestTuple/SnapshotRead-10     12.96Ki ± 0%   14.29Ki ± 0%  +10.30% (p=0.000 n=10)
DatastoreDriver/cockroachdb-overlap-static/TestTuple/Touch-10            16.51Ki ± 2%   17.48Ki ± 0%   +5.87% (p=0.001 n=10)
DatastoreDriver/cockroachdb-overlap-static/TestTuple/Create-10           14.51Ki ± 3%   15.85Ki ± 2%   +9.21% (p=0.000 n=10)
DatastoreDriver/cockroachdb-overlap-insecure/TestTuple/SnapshotRead-10   12.96Ki ± 0%   14.29Ki ± 0%  +10.29% (p=0.000 n=10)
DatastoreDriver/cockroachdb-overlap-insecure/TestTuple/Touch-10          14.52Ki ± 1%   15.95Ki ± 1%   +9.88% (p=0.000 n=10)
DatastoreDriver/cockroachdb-overlap-insecure/TestTuple/Create-10         12.93Ki ± 1%   14.29Ki ± 1%  +10.55% (p=0.000 n=10)
geomean                                                                  14.01Ki        15.31Ki        +9.34%

                                                                       │  old.txt   │              new.txt              │
                                                                       │ allocs/op  │ allocs/op   vs base               │
DatastoreDriver/cockroachdb-overlap-static/TestTuple/SnapshotRead-10     230.0 ± 0%   246.0 ± 0%  +6.96% (p=0.000 n=10)
DatastoreDriver/cockroachdb-overlap-static/TestTuple/Touch-10            237.0 ± 0%   253.0 ± 0%  +6.75% (p=0.000 n=10)
DatastoreDriver/cockroachdb-overlap-static/TestTuple/Create-10           232.0 ± 0%   248.0 ± 0%  +6.90% (p=0.000 n=10)
DatastoreDriver/cockroachdb-overlap-insecure/TestTuple/SnapshotRead-10   230.0 ± 0%   246.0 ± 0%  +6.96% (p=0.000 n=10)
DatastoreDriver/cockroachdb-overlap-insecure/TestTuple/Touch-10          221.0 ± 0%   237.0 ± 0%  +7.24% (p=0.000 n=10)
DatastoreDriver/cockroachdb-overlap-insecure/TestTuple/Create-10         216.0 ± 0%   232.0 ± 0%  +7.41% (p=0.000 n=10)
geomean

I have another branch exploring ways to remove the overhead, but so far haven't been able to show it survive node drains completely in the way that this PR does.
Note that this requires admin permission on the cockroach database.

Closing in favor of #1294
This approach was effective, but requires admin permission. We may revisit it as an option in the future, but for now it's better to just have one way to handle node drains.


Menu callback on edges (in addition to nodes)

Menu callback on edges (in addition to nodes) . Maybe simply clicking on an edge is
enough to trigger a callback.
Callbacks can be passed to the configuration object that will handle them.

Users of hierarchical visualizations needs to add a new subclass to define a new action with the mouse click

Done


🐛 Fixed settings overriden when updated from multiple tabs

closes #15470
When multiple browser tabs are open, each manipulate a different copy of ember data model, changes to the model in one tab are not reflected in the model of the other tab. When updating some settings, all current settings were sent to the API. As a result, when updating two different categories of settings (navigation/code inspection) in different tabs, the second update was overriding the first one. From a user perspective, this is not a natural behaviour. Only settings visible on-screen when clicking save should be modified.

This PR should get the job done but is not ideal.
Relying on change detection is risky as it will not work on non-trivial model attributes (such as NavigationItem). The workaround put in place (force a change in the controller) will have to be done for new similar settings. Failure to do so will not be detected in the tests and the issue will come back).
But there are no "easy" solution I think

Syncing ember data RAM cache with local storage would be a big change and we can expect weird browser-specific issues
Using embedded record would require an id
ember-data-model-fragments could work but is in beta and adding a dependency for that specific use case is a bit overkill

The cleanest solution I could think of would be to have a separate model for each setting screen, but this seems a big refactoring that needs to be discussed.

Heads up that I've pushed a rebase as some other changes in main caused conflicts with the PR

Hi @jbenezech thanks so much for this PR! Apologies for the delay - we had a bit of an influx - but it has now been merged 🎉 and will appear in the next release of Ghost - usually Fridays.
I'm not sure if you found this through hacktoberfest, but I've added the accepted label to this PR to make sure it counts. I see you have another PR open which I'll take a look at next!

@ErisDS
No worries, thanls for merging that and the others :)
Nothing to do with hacktoberfest, more the automatic PR message you add. Working on it ;)


jdk_security failed with 3 testcases but TEST TARGETS SUMMARY didn't grab it correctly and tap file is not correctly generated.

https://ci.adoptopenjdk.net/job/Test_openjdk8_hs_extended.openjdk_x86-64_solaris_testList_0/33
jdk_security3_0 failed with 3 testcases but TEST TARGETS SUMMARY didn't grab it correctly. It's not in the skipped test, passed test nor failed test. Hence the tap file is not correctly generated. https://ci.adoptopenjdk.net/job/Test_openjdk8_hs_extended.openjdk_x86-64_solaris_testList_0/33/artifact/aqa-tests/TKG/output_16555710233694/Test_openjdk8_hs_extended.openjdk_x86-64_solaris_testList_0.tap/view/
15:21:40  Test results: passed: 612; failed: 3
15:21:41  Report written to /export/home/jenkins/workspace/Test_openjdk8_hs_extended.openjdk_x86-64_solaris_testList_0/jvmtest/openjdk/report/html/report.html
15:21:41  Results written to /export/home/jenkins/workspace/Test_openjdk8_hs_extended.openjdk_x86-64_solaris_testList_0/aqa-tests/TKG/output_16555710233694/jdk_security3_0/work
15:21:41  Error: Some tests failed or other problems occurred.
15:21:41
15:21:41  jdk_security3_0_FAILED
15:21:41
15:21:41  Nothing to be done for teardown.
15:21:41  jdk_security3_0 Finish Time: Sat Jun 18 20:21:41 2022 Epoch Time (ms):<PHONE_NUMBER>527
15:21:41
...
16:49:31  PASSED test targets:
16:49:31  	jdk_custom_0
16:49:31  	langtools_custom_0
16:49:31  	hotspot_custom_0
16:49:31  	hotspot_compiler_0
16:49:31  	hotspot_gc_0
16:49:31  	hotspot_runtime_0
16:49:31  	hotspot_serviceability_0
16:49:31  	jdk_beans_0
16:49:31  	jdk_io_0
16:49:31  	jdk_other_0
16:49:31  	jdk_net_0
16:49:31  	jdk_nio_0
16:49:31  	jdk_security1_0
16:49:31  	jdk_security2_0
16:49:31  	jdk_security4_0
16:49:31  	jdk_text_0
16:49:31  	jdk_time_0
16:49:31  	jdk_management_0
16:49:31  	jdk_jmx_0
16:49:31  	jdk_rmi_0
16:49:31  	jdk_instrument_0
16:49:31  	jdk_imageio_0
16:49:31
16:49:31  FAILED test targets:
16:49:31  	hotspot_jre_0
16:49:31  	jdk_tools_0

The junit test result can correctly show the failed three tests.
https://ci.adoptopenjdk.net/job/Test_openjdk8_hs_extended.openjdk_x86-64_solaris_testList_0/33/testReport/

@renfeiw can you take a look at this? Thanks

To avoid this happening again, I would suggest changing our keywords in the test output. Instead of Running test <test tareget>, could we output a more specific string - i.e., Running AQAvit test target <test tareget> in TKG?
@smlambert what do you think?

@renfeiw and I had the discussion, instead of changing the header string, we will match multiple lines. In this case, TRSS will match the following:
===============================================
Running test <test target> ...

For details, please see TRSS PR https://github.com/adoptium/aqa-test-tools/pull/713
@renfeiw please update TKG parser as well. Thanks


Reattach events when rerendering

Hello,
I just noticed that when changing the options or the settings (filling the condition in ngDoCheck()), this.render() was called and apparently changing the reference of the element, thus preventing the events to be fired.
My use case was the following:
2 datepickers (single for that matter), the first one changing the minDate of the second one.
When I selected a date for the first one, the minDate worked perfectly, but the (applyDaterangepicker) event wasn't firing anymore, leading to issues in my side.
By calling attachEvents() after render() it works perfectly :)
I hope it makes sense.
Thanks.

Thanks. I have merged the feature

Hello @evansmwendwa, I'm trying the 2.0.9 version, but it doesn't seem to include the pull request on the npm release, could you check on your side please?
Thanks!

Noticed I forgot to build before publishing. Please try 2.0.10 and let me know if that works as intended

That's perfect, thanks!


feat(ytyp): Add ability to create GTA/RDR ytyp with BaseArchetype sup…

…port
small cleanup for bounds
"  bound.current_game = current_game " was unused i guess because current_game its also defined by BoundFile and BoundRDRFile
tweak

bound.current_game = current_game is used the set the state of current_game variable in bound module instance since it is not always necessary that current_game will be same as the game which is being exported as it's changed everytime a new XML is read.
So anywhere you see some_filename.current_game = game, it's used to set the current_game value in that file before calling any functions from that file

In that case its usless because few line below we use BoundFile or RDRBoundFile which change current_game in bound.py

Just checked the code and it's fine to remove it at that place, I thought you made multiple changes in other files too.


Can't delete accounts with active providers

Seems like there's a lock preventing deleting accounts with an active, syncing provider:
iex(web@web-lkt6.us-east1-d.c.firezone-prod.internal)1> Domain.Ops.delete_disabled_account("7c76c08b-9a27-4d7c-8203-b0e4465fa6d1")

04:39:23.342 [debug] QUERY OK source="accounts" db=1.6ms idle=1321.0ms
SELECT a0."id", a0."name", a0."slug", a0."legal_name", a0."features", a0."limits", a0."config", a0."metadata", a0."warning", a0."warning_delivery_attempts", a0."warning_last_sent_at", a0."disabled_reason", a0."disabled_at", a0."deleted_at", a0."inserted_at", a0."updated_at" FROM "accounts" AS a0 WHERE (a0."deleted_at" IS NULL) AND (NOT (a0."disabled_at" IS NULL)) AND (a0."id" = $1) ["7c76c08b-9a27-4d7c-8203-b0e4465fa6d1"]

04:39:38.347 [debug] QUERY ERROR source="accounts" db=15002.2ms queue=2.1ms idle=1323.4ms
DELETE FROM "accounts" WHERE "id" = $1 ["7c76c08b-9a27-4d7c-8203-b0e4465fa6d1"]
** (Postgrex.Error) ERROR 57014 (query_canceled) canceling statement due to user request
    (ecto_sql 3.11.1) lib/ecto/adapters/sql.ex:1054: Ecto.Adapters.SQL.raise_sql_call_error/1
    (ecto 3.11.2) lib/ecto/repo/schema.ex:775: Ecto.Repo.Schema.apply/4
    (ecto 3.11.2) lib/ecto/repo/schema.ex:571: anonymous fn/13 in Ecto.Repo.Schema.do_delete/4
    (domain 1.0.6) lib/domain/ops.ex:95: Domain.Ops.delete_disabled_account/1
    iex:1: (file)

Poked around a bit, but didn't want to break anything so I'll leave this one up to @AndrewDryga  :-). Probably needs a fix in the Domain.Ops.delete_disabled_account/1


Leaking memory through RingBuffer?

I have a million dollar question - what releases an object from RingBuffer after it was handled by the appender? That is what nulls the entry in the ring buffer after we done with it?
I have a very bad feeling that it is not done so all these objects keep hanging in the memory until the current item pointer wraps and starts overwriting old items. Quick look at heap dumps confirms that but we did not dig deeper.
It it is the case, it can be really a catastrophic thing for any application. LogEntry objects can be HUGE as they contain not just a text message but also stack traces and all the parameters passed to log.debug() or log.warn(). And 3rd party libs can pass anything they like there expecting that toString() will be invoked on it. For example Hector (Cassandra client) passes entire connection object there so if that object sits in the ring buffer for a long time it prevents a significant amount of memory (megabytes) from being collected by GC.

Hey @dimas,
Nice find.  Yes, references were being kept around until they were overwritten the next time around.  I've fixed this for version 4.4, to be released soon.

4.4 has been released with this fix


Update Electron peer dependency to 1.8

yarn check complains that electron-widevinecdm requires Electron 1.7:
error<EMAIL_ADDRESS>doesn't satisfy found match of<EMAIL_ADDRESS>
but it seems to work correctly with Electron 1.8.
Would it be possible to update peerDependencies to accept 1.8 as well?

@Rudloff I'll try to update that soon. But actually, we would need a newer version of WidevineCDM. (Electron 1.7 uses Chrome 58, Electron 1.8 uses Chrome 59). Still, I can't find a good place to download extractable Chrome 59 setup file for Windows.
Currently, I'm using https://www.slimjet.com/chrome/google-chrome-old-version.php but the files only work with 7zip up to Chrome 58 :(

The old versions of Chrome before V58 are packed as 7zip self-extracting executable. Just run the executable and extract the files under any folder on your hard drive. Then launch Google chrome with chrome.exe under the extraction folder. After V59, the archived chrome old version files are official Chrome offline installers. Just uninstall any current version of Chrome first and then run the downloaded installer. It's a one-click installer without any interactive UI.

I may drop win32 support. Certainly, the current binaries may work with Electron 1.8 but it's too risky. Considering this statement:

Note: The major version of Chrome browser has to be the same with the Chrome version used by Electron, otherwise the plugin will not work even though navigator.plugins would show it has been loaded. https://electronjs.org/docs/tutorial/using-widevine-cdm-plugin

https://github.com/quanglam2807/electron-widevinecdm/releases/tag/v6.0.0

That was quick, thanks!


Snake related facts

a simple feature which gets facts about snakes.
This feature can also provide something like:
-deadly snakes around the world
-endangered snakes
-Festivals where snakes are a part of
etc etc
Implementation details
List the changes required for the implementation here.

[x] A bot command to get a snake fact.
[ ] A bot command to get top ten 'something'
example : Top ten deadly snakes. top ten endangered snakes, etc
[ ] Any other command related to this can be done.

I think this might be implemented already .snake card command.


[tests] unstable Cert_5_6_9

Describe the bug
Cert_5_6_9 fails for https://github.com/openthread/openthread/pull/5690 unexpectedly, rerun could pass.
Expected behavior
Consistently pass if no bugs newly introduced in the PR.
Console/log output
https://github.com/openthread/openthread/pull/5690/checks?check_run_id=1306518328

The pcap files were deleted by the second run, will try to reproduce locally.

It can not be reproduced after running locally for 1500 times, suggest closing the issue first. If found in the future, please upload the packets files and reopen the issue. Thanks!


[FLINK-19689][yarn][test] Fix TaskExecutorProcessSpecContainerResourcePriorityAdapterTest for Hadoop 2.10+.

What is the purpose of the change
This PR fixes the test failure of TaskExecutorProcessSpecContainerResourcePriorityAdapterTest when running with Hadoop 2.10+.
Verifying this change
Verified with Hadoop 2.4.1, 2.10.0, 3.1.3 and 3.3.0.

@KarmaGYZ Could you help take a look?

@flinkbot run azure


Output is bugged when i do "to.json()"

Describe the bug
basically i want to jsonify to "PrettyPrint" it, and it seems to not working
To Reproduce
    entries = get_history().histories
    obj = generic.Outputs('history')
    obj.entries = entries
    data = json.loads(obj.to_json())
    mwssage = '====================================================\n'
    for item in data["history"]:
        mwssage += "Visited-date:", str(item["Timestamp"])+'\n'
        mwssage += "URL:", str(item["URL"])+'\n'
        mwssage += '====================================================\n'
    with open('outy\\History.txt', 'w+') as file:
        file.write(mwssage)
        print('History Saved to "outy" directory')

output:
====================================================
but entries:
all my history

This is definitely a bug, I can reproduce it. But it's easy to workaround it by simplifying it. get_history() returns an Outputs object already, you do not need to make a new one.
entries = get_history()
data = json.loads(entries.to_json())

Also, you have a bug in this line: mwssage += "Visited-date:", str(item["Timestamp"])+'\n'. You have used a comma in place of a +.
Here's a working version of your code:
entries = get_history()
data = json.loads(entries.to_json())
mwssage = '====================================================\n'
for item in data["history"]:
    mwssage += "Visited-date:" + str(item["Timestamp"]) + '\n'
    mwssage += "URL:" + str(item["URL"]) + '\n'
    mwssage += '====================================================\n'
with open('outy\\History.txt', 'w+') as file:
    file.write(mwssage)
    print('History Saved to "outy" directory')

Should be fixed by #266


Displaying all announcement objects

:tada: This PR is included in version 1.2.16 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[Refactoring] Introduce CTFE::isGotoExp to make conditions more readable (mirrors isCantExp)

Auto-merge toggled on


HDR dosn't seem to tag with 10-bit files

After all that work we did a few months back, I have found that 10-bit media don't seem to copy over the HDR tagging, I am not sure if its a setting in the autoprocess.ini i need to set or what, any media in HDR that is NOT 10-bit worked perfect every time

Please provide examples and logs and your current settings

And please provide one full conversion with DEBUG logging enabled
https://github.com/mdhiggins/sickbeard_mp4_automator/wiki/Debug-Level-Logging

Heres a log from a file that just finished, cos I am using software encoding a debug log will be about 2 days https://pastebin.com/fkiF42W5

You can try and make a test video using -t, 10 in post opts to make a sample clip

Looks like FFProbe isn't returning the framedata and so its not getting added
Try running the following command on the file and posting the output here
ffprobe -hide_banner -loglevel warning -select_streams v -print_format json -show_frames -read_intervals %+#1 -show_entries frame=color_space,color_primaries,color_transfer,side_data_list,pix_fmt -i filename.mkv

You may also want to try running an updated build of ffprobe to see if that fixes it

D:\Downloads\To Convert>ffprobe -hide_banner -loglevel warning -select_streams v -print_format json -show_frames -read_intervals %+#1 -show_entries frame=color_space,color_primaries,color_transfer,side_data_list,pix_fmt -i Chernobyl.S01E<IP_ADDRESS>.2160p.UHD.BluRay.x265.10bit.HDR.DTS-HD.MA.5.1-SWTYBLZ.mkv
{
[matroska,webm @ 0000015b39d74b00] Could not find codec parameters for stream 4 (Subtitle: hdmv_pgs_subtitle (pgssub)): unspecified size
Consider increasing the value for the 'analyzeduration' (0) and 'probesize' (5000000) options
[matroska,webm @ 0000015b39d74b00] Could not find codec parameters for stream 5 (Subtitle: hdmv_pgs_subtitle (pgssub)): unspecified size
Consider increasing the value for the 'analyzeduration' (0) and 'probesize' (5000000) options
[matroska,webm @ 0000015b39d74b00] Could not find codec parameters for stream 6 (Subtitle: hdmv_pgs_subtitle (pgssub)): unspecified size
Consider increasing the value for the 'analyzeduration' (0) and 'probesize' (5000000) options
[matroska,webm @ 0000015b39d74b00] Could not find codec parameters for stream 7 (Subtitle: hdmv_pgs_subtitle (pgssub)): unspecified size
Consider increasing the value for the 'analyzeduration' (0) and 'probesize' (5000000) options
[matroska,webm @ 0000015b39d74b00] Could not find codec parameters for stream 8 (Subtitle: hdmv_pgs_subtitle (pgssub)): unspecified size
Consider increasing the value for the 'analyzeduration' (0) and 'probesize' (5000000) options
[matroska,webm @ 0000015b39d74b00] Could not find codec parameters for stream 9 (Subtitle: hdmv_pgs_subtitle (pgssub)): unspecified size
Consider increasing the value for the 'analyzeduration' (0) and 'probesize' (5000000) options
[matroska,webm @ 0000015b39d74b00] Could not find codec parameters for stream 10 (Subtitle: hdmv_pgs_subtitle (pgssub)): unspecified size
Consider increasing the value for the 'analyzeduration' (0) and 'probesize' (5000000) options
[matroska,webm @ 0000015b39d74b00] Could not find codec parameters for stream 11 (Subtitle: hdmv_pgs_subtitle (pgssub)): unspecified size
Consider increasing the value for the 'analyzeduration' (0) and 'probesize' (5000000) options
[matroska,webm @ 0000015b39d74b00] Could not find codec parameters for stream 12 (Subtitle: hdmv_pgs_subtitle (pgssub)): unspecified size
Consider increasing the value for the 'analyzeduration' (0) and 'probesize' (5000000) options
[matroska,webm @ 0000015b39d74b00] Could not find codec parameters for stream 13 (Subtitle: hdmv_pgs_subtitle (pgssub)): unspecified size
Consider increasing the value for the 'analyzeduration' (0) and 'probesize' (5000000) options
[matroska,webm @ 0000015b39d74b00] Could not find codec parameters for stream 14 (Subtitle: hdmv_pgs_subtitle (pgssub)): unspecified size
Consider increasing the value for the 'analyzeduration' (0) and 'probesize' (5000000) options
[matroska,webm @ 0000015b39d74b00] Could not find codec parameters for stream 15 (Subtitle: hdmv_pgs_subtitle (pgssub)): unspecified size
Consider increasing the value for the 'analyzeduration' (0) and 'probesize' (5000000) options
[matroska,webm @ 0000015b39d74b00] Could not find codec parameters for stream 16 (Subtitle: hdmv_pgs_subtitle (pgssub)): unspecified size
Consider increasing the value for the 'analyzeduration' (0) and 'probesize' (5000000) options
[matroska,webm @ 0000015b39d74b00] Could not find codec parameters for stream 17 (Subtitle: hdmv_pgs_subtitle (pgssub)): unspecified size
Consider increasing the value for the 'analyzeduration' (0) and 'probesize' (5000000) options
[matroska,webm @ 0000015b39d74b00] Could not find codec parameters for stream 18 (Subtitle: hdmv_pgs_subtitle (pgssub)): unspecified size
Consider increasing the value for the 'analyzeduration' (0) and 'probesize' (5000000) options
[matroska,webm @ 0000015b39d74b00] Could not find codec parameters for stream 19 (Subtitle: hdmv_pgs_subtitle (pgssub)): unspecified size
Consider increasing the value for the 'analyzeduration' (0) and 'probesize' (5000000) options
[matroska,webm @ 0000015b39d74b00] Could not find codec parameters for stream 20 (Subtitle: hdmv_pgs_subtitle (pgssub)): unspecified size
Consider increasing the value for the 'analyzeduration' (0) and 'probesize' (5000000) options
"frames": [
{
"pix_fmt": "yuvj444p",
"color_space": "bt470bg",
"side_data_list": [
{
"side_data_type": "QP table data"
},
{
"side_data_type": "QP table properties"
}
]
}
]
}

https://drive.google.com/file/d/1aoyX1i2Lr6_3Rm3O63DgE0mh5ZDXb4kc/view?usp=sharing
Here's the output file from the 10 second test

Does adding -probesize 50M -analyzeduration 100M to ffprobe change the output?
ffprobe -hide_banner -loglevel warning -select_streams v -print_format json -show_frames -read_intervals %+#1 -show_entries frame=color_space,color_primaries,color_transfer,side_data_list,pix_fmt -probesize 50M -analyzeduration 100M -i filename.mkv

Nope exact same output ```
D:\Downloads\To Convert>ffprobe -hide_banner -loglevel warning -select_streams v -print_format json -show_frames -read_intervals %+#1 -show_entries frame=color_space,color_primaries,color_transfer,side_data_list,pix_fmt -probesize 50M -analyzeduration 100M -i Chernobyl.S01E<IP_ADDRESS>.2160p.UHD.BluRay.x265.10bit.HDR.DTS-HD.MA.5.1-SWTYBLZ.mkv
{
"frames": [
{
"pix_fmt": "yuvj444p",
"color_space": "bt470bg",
"side_data_list": [
{
"side_data_type": "QP table data"
},
{
"side_data_type": "QP table properties"
}
]
}
]
}
D:\Downloads\To Convert>
also if its a help heres the media info os the source file https://pastebin.com/u1xKxNBt and of the output file https://pastebin.com/Vfdj1Jrx

Sorry forgot debug log https://pastebin.com/2b7T64MD

Yeah the ffprobe output is messed up for some reason. Try a different build

{
    "frames": [
        {
            "pix_fmt": "yuv420p10le",
            "color_space": "bt2020nc",
            "color_primaries": "bt2020",
            "color_transfer": "smpte2084",
            "side_data_list": [
                {
                    "side_data_type": "Mastering display metadata",
                    "red_x": "34000/50000",
                    "red_y": "16000/50000",
                    "green_x": "13250/50000",
                    "green_y": "34500/50000",
                    "blue_x": "7500/50000",
                    "blue_y": "3000/50000",
                    "white_point_x": "15635/50000",
                    "white_point_y": "16450/50000",
                    "min_luminance": "10/10000",
                    "max_luminance": "10000000/10000"
                },
                {
                    "side_data_type": "Content light level metadata",
                    "max_content": 0,
                    "max_average": 0
                }
            ]
        }
    ]
}

It should look like this

Im using a build that was complied yesterday

Ok out of curiosity I ran the same command on a 8-bit file and got
D:\Downloads\To Convert>ffprobe -hide_banner -loglevel warning -select_streams v -print_format json -show_frames -read_intervals %+#1 -show_entries frame=color_space,color_primaries,color_transfer,side_data_list,pix_fmt -probesize 50M -analyzeduration 100M -i Star.Wars.Episode.VII.The.Force.Awakens.2015.2160p.UHD.BluRay.x265-DEPTH.mkv
{
    "frames": [
        {
            "pix_fmt": "yuv420p10le",
            "color_space": "bt2020nc",
            "color_primaries": "bt2020",
            "color_transfer": "smpte2084",
            "side_data_list": [
                {
                    "side_data_type": "Mastering display metadata",
                    "red_x": "34000/50000",
                    "red_y": "16000/50000",
                    "green_x": "13250/50000",
                    "green_y": "34500/50000",
                    "blue_x": "7500/50000",
                    "blue_y": "3000/50000",
                    "white_point_x": "15635/50000",
                    "white_point_y": "16450/50000",
                    "min_luminance": "1/10000",
                    "max_luminance": "10000000/10000"
                },
                {
                    "side_data_type": "Content light level metadata",
                    "max_content": 0,
                    "max_average": 0
                },
                {
                    "side_data_type": "H.26[45] User Data Unregistered SEI message"
                },
                {
                    "side_data_type": "H.26[45] User Data Unregistered SEI message"
                }
            ]
        }
    ]
}

D:\Downloads\To Convert>

How ever ALL 10-bit files no matter what it is give me
{
   "frames": [
       {
           "pix_fmt": "yuvj444p",
           "color_space": "bt470bg",
           "side_data_list": [
               {
                   "side_data_type": "QP table data"
               },
               {
                   "side_data_type": "QP table properties"
               }
           ]
       }
   ]
}

So I think this is a ffmpeg problem with 10-bit files

Yeah I'm seeing the same thing on my end, not sure how to get that data without FFProbe returning it

It might just be that the source files you're using are lacking this metadata
http://media.developer.dolby.com/DolbyVision_Atmos/mp4/P81_GlassBlowing2_1920x1080%4059.94fps_15200kbps_fmp4.mp4
Here is a sample file of a 10 bit HDR video that reports that information fine

That's a lot of source files then lol

If they're all coming from the same release groups it may be a problem with how they are creating their releases though, the sample file above shows its not a 10 bit issue

good shout lol

Did you find any evidence that MediaInfo is reading those parameters? I didn't see anything on what you posted or on my end

Which Parameters?

All of the color data that's missing (R, G, B, WP, luminance)

Oh yeah I have never seen that in mediainfo not sure if it actually displays it

Here was a response from Chris Griffith who wrote the article that I used to include all this metadata info regarding your issue
Glad it has helped!

Dolby Vision profile levels are confusing as they come with different information. Profile 5 only comes with Dolby Vision, whereas 8.1 comes with DV + HDR10 information. There is also 8.2 and 8.4 that do not,

https://dolby.force.com/professionalsupport/s/article/What-is-Dolby-Vision-Profile?language=en_US.

The file in that issue is reporting it is a “bt.470bg” color space in uncompressed 4:4:4 chroma (yuvj444p), so it does not have HDR10 information (which is for bt.2020 + yuv420p10le). 4:4:4 chroma is usually reserved for content developers, so odd to see it outside that realm, and I do not personally have experience converting that to it’s HDR10 equivalent.

Its a bit beyond me as well but if the data isn't there then I certainly can't extract it
Also I just noticed a small bug in the code which I've fixed when going over this that the R and G color parameters had been switched so make sure you update

Ok cool, thank you sounds like its just a dodgy release then will find new source and try again 👍

https://codecalamity.com/encoding-uhd-4k-hdr10-videos-with-ffmpeg/
Here's the article for reference

Awesome thank you :D

Hi, as a reminder, I'm using your alternate codecs to encode via GPU for non HDR files and using CPU for HDR files.
Detection of HDR seems to be working fine but for some unknown reasons, some resulting files are getting wrong HDR metadata.
Original file mediainfo:
Vidéo
ID                                       : 1
OriginalSourceMedium_ID/String           : 4113 (0x1011)
Format                                   : HEVC
Format/Info                              : High Efficiency Video Coding
Nom commercial                           : HDR10
Profil du format                         : Main 10@L5.1@High
Identifiant du codec                     : V_MPEGH/ISO/HEVC
Durée                                    : 2 h 30 min
Débit                                    : 57,5 Mb/s
Largeur                                  : 3 840 pixels
Hauteur                                  : 2 160 pixels
Format à l'écran                         : 16/9
Type d'images/s                          : Constant
Images par seconde                       : 23,976 (24000/1001) Im/s
Espace de couleurs                       : YUV
Sous-échantillonnage de la chrominance   : 4:2:0 (Type 2)
Profondeur des couleurs                  : 10 bits
Bits/(Pixel*Image)                       : 0.289
Taille du flux                           : 60,3 Gio (79%)
Titre                                    : Tenet.2020.IMAX.2160p.BluRay.REMUX.HEVC.DTS-HD.MA.5.1-FGT
Langue                                   : Anglais
Default                                  : Non
Forced                                   : Non
Gamme de couleurs                        : Limited
Coordonnées de chromaticité              : BT.2020
Caractéristiques du transfert            : PQ
Coefficients de la matrice               : BT.2020 non-constant
Support d'origine                        : Blu-ray
MasteringDisplay_ColorPrimaries          : Display P3
MasteringDisplay_Luminance               : min: 0.0050 cd/m2, max: 4000 cd/m2
MaxCLL                                   : 349 cd/m2
MaxFALL                                  : 86 cd/m2
Here is the resulting mp4 mediainfo:
Vidéo
ID                                       : 1
Format                                   : HEVC
Format/Info                              : High Efficiency Video Coding
Profil du format                         : Main 10@L5@High
Identifiant du codec                     : hvc1
Identifiant du codec/Info                : High Efficiency Video Coding
Durée                                    : 1 min 0s
Débit                                    : 31,5 Mb/s
Largeur                                  : 3 840 pixels
Hauteur                                  : 2 160 pixels
Format à l'écran                         : 16/9
Type d'images/s                          : Constant
Images par seconde                       : 23,976 (24000/1001) Im/s
Espace de couleurs                       : YUV
Sous-échantillonnage de la chrominance   : 4:2:0
Profondeur des couleurs                  : 10 bits
Type de balayage                         : Progressif
Bits/(Pixel*Image)                       : 0.158
Taille du flux                           : 226 Mio (76%)
Titre                                    : 4K HDR / 4K HDR
Bibliothèque utilisée                    : x265 3.2+35-acc5d16999e2:[Windows][GCC 9.2.1][64 bit] 10bit
Paramètres d'encodage                    : cpuid=1111039 / frame-threads=3 / numa-pools=8 / wpp / no-pmode / no-pme / no-psnr / no-ssim / log-level=2 / input-csp=1 / input-res=3840x2160 / interlace=0 / total-frames=0 / level-idc=0 / high-tier=1 / uhd-bd=0 / ref=1 / no-allow-non-conformance / repeat-headers / annexb / no-aud / no-hrd / info / hash=0 / no-temporal-layers / open-gop / min-keyint=23 / keyint=250 / gop-lookahead=0 / bframes=3 / b-adapt=0 / b-pyramid / bframe-bias=0 / rc-lookahead=5 / lookahead-slices=8 / scenecut=0 / hist-scenecut=0 / radl=0 / no-splice / no-intra-refresh / ctu=32 / min-cu-size=16 / no-rect / no-amp / max-tu-size=32 / tu-inter-depth=1 / tu-intra-depth=1 / limit-tu=0 / rdoq-level=0 / dynamic-rd=0.00 / no-ssim-rd / no-signhide / no-tskip / nr-intra=0 / nr-inter=0 / no-constrained-intra / strong-intra-smoothing / max-merge=2 / limit-refs=0 / no-limit-modes / me=0 / subme=0 / merange=57 / temporal-mvp / no-frame-dup / no-hme / no-weightp / no-weightb / no-analyze-src-pics / deblock=0:0 / no-sao / no-sao-non-deblock / rd=2 / selective-sao=0 / early-skip / rskip / fast-intra / no-tskip-fast / no-cu-lossless / no-b-intra / no-splitrd-skip / rdpenalty=0 / psy-rd=2.00 / psy-rdoq=0.00 / no-rd-refine / no-lossless / cbqpoffs=0 / crqpoffs=0 / rc=abr / bitrate=30000 / qcomp=0.60 / qpstep=4 / stats-write=0 / stats-read=0 / ipratio=1.40 / pbratio=1.30 / aq-mode=1 / aq-strength=0.00 / cutree / zone-count=0 / no-strict-cbr / qg-size=32 / no-rc-grain / qpmax=69 / qpmin=0 / no-const-vbv / sar=1 / overscan=0 / videoformat=5 / range=0 / colorprim=2 / transfer=2 / colormatrix=5 / chromaloc=0 / display-window=0 / cll=0,0 / min-luma=0 / max-luma=1023 / log2-max-poc-lsb=8 / vui-timing-info / vui-hrd-info / slices=1 / no-opt-qp-pps / no-opt-ref-list-length-pps / no-multi-pass-opt-rps / scenecut-bias=0.05 / hist-threshold=0.01 / no-opt-cu-delta-qp / no-aq-motion / no-hdr10 / no-hdr10-opt / no-dhdr10-opt / no-idr-recovery-sei / analysis-reuse-level=0 / analysis-save-reuse-level=0 / analysis-load-reuse-level=0 / scale-factor=0 / refine-intra=0 / refine-inter=0 / refine-mv=1 / refine-ctu-distortion=0 / no-limit-sao / ctu-info=0 / no-lowpass-dct / refine-analysis-type=0 / copy-pic=1 / max-ausize-factor=1.0 / no-dynamic-refine / no-single-sei / no-hevc-aq / no-svt / no-field / qp-adaptation-range=1.00 / no-scenecut-aware-qpconformance-window-offsets / right=0 / bottom=0
Langue                                   : Anglais
Gamme de couleurs                        : Limited
Coefficients de la matrice               : BT.470 System B/G
Menus                                    : 12
This test was done with the 9/12/2020 FFMPEG release and with the latests version of your script. I was wondering if this is realted to the above discussion ? Is this also an issue with the source file not being properly HDR tagged ? I'm having this issue with multiple files from different releases.
Sometimes HDR metadata are properly transfered and if I compare Mediainfo for files that did work, I see no difference ?

MediaInfo isn't helpful because it doesn't display the frame data. Can you post the logs of the conversion and the ffprobe frame data from the command provided above?

Hi,
Here is the result of the FFPROB command on one of the file:
{     "frames": [         {             "pix_fmt": "yuvj444p",             "color_space": "bt470bg",             "side_data_list": [                 {                     "side_data_type": "QP table data"                 },                 {                     "side_data_type": "QP table properties"                 }             ]         }     ] }

Nah that's enough info. That ffprobe output is missing the color data so that's why you're not getting it, your source doesn't have the metadata

Ok thanks ! I got it.
I'm manually testing every file before import with the ffprobe command line, but this is manual......
Could you implement, something like an HDR section option maybe, which would kind of check if HDR metadata are really there. If not you could cancel the HDR codec previsouly detected and as a consequence, get back to original codec ?
Or maybe just skip this file and move forward to next item in queue. You could Aldo create an empty text file with the movie name and adding BAD.HDR to it si we know why the file was skipped....
Or any other idea ?
It's such a waste of time to encode via cpu a file for nothing........thanks anyway

Yeah I'll see if I can come up with something. Wish there was a better solution and I'm open to suggestions
Challenging to solve this one

I have just resorted to skipping all 10bit media as this is the only play I have a problem, if its 8bit it seems to work perfectly fine and keep HDR stuff

I would say that recommendation isn't great since the whole conclusion of this post is that its not a 10-bit problem but a specific format and metadata problem
I'm gonna add a method that returns a boolean value for if metadata is present or not and then people can choose to use that to skip files I think

👍  Cool

I can be your guinea pig !

09e9b320eaa0ebcfbe237eddf1e2f1cd886aa8be
https://github.com/mdhiggins/sickbeard_mp4_automator/wiki/Custom-Source-Validation
Alright here's an update that should help
Big change with this update is that the isValidSource method of MediaProcessor now has a custom code check. If you add a custom.py file to your config folder with a method validation that returns True or False that method will be included to allow users to run custom code to determine if a file should be considered valid. That wiki page shows the parameters
I also added a sample to the setup folder called config.py.sample which should allow you to exclude HDR files if they're missing valid color info. You can modify this however you like but that should get you started

Just tested it on a manual conversion and it worked as expected ! File without proper HDR metadata was skipped:
C:\Git>python C:\Script\PrePROD\manual.py -a -i c:\test.mkv
Manual processor started.
Python 64-bit 3.8.2 (tags/v3.8.2:7b3ab59, Feb 25 2020, 23:03:10) [MSC v.1916 64 bit (AMD64)].
Guessit version: 3.1.0.
C:\Program Files\Python38\python.exe
Loading config file C:\Script\PrePROD\config\autoProcess.ini.
Initiating custom validation method.
HDR video stream detected for 0.
ValidFrameData is False
File c:\test.mkv is not in a valid format
I still need to test this on an automatic batch but sounds promising !!!!!! Will let you know if I find out anything.
Thanks !!!!!!!


[BUG] Can not list mounted directory

df -h |grep data
/dev/longhorn/pvc-0d84e661-14f1-428c-8ce7-02357e910fe5  9.8G   37M  9.8G   1% /data

ls /data
ls: reading directory /data: Input/output error

any advice?

@hillbun Do you have a liveness probe on this pod that checks ls /data?
This might have happened in the case where no liveness probe is setup and the longhorn-engine responsible for that volume crashed.
Then the mount might no longer be valid after reattachment of the longhorn volume.
In that case a (restart, recreation, scale down/scale up) of the pod should fix the issue?
Hard to diagnose with this amount of information.

@joshimoo
restart solved this problem.
How to get pvc attached stablely?   if pvc attached crashed, pod auto restart?

@hillbun In the case of a liveness probe failure, the pod will be restarted. You you add a liveness probe to the workload pod, that will evaluate whether the volume is available and working. You can find an example in the documentation here

@joshimoo
How to setup multiple livenessProbe if I mount 2 pvc with a pod?

@hillbun kubernetes allows for 1 liveness probe per container, a pod can have multiple containers.
Now in the case where you have a single pod = single container with multiple pvc's mounted.
The most simplest liveness probe example could be implemented like this:
ls /mnt/vol1 && ls /mnt/vol2
Here is a thread on stackoverflow with some additional details and approaches (dedicated script, dedicated side car container, etc)


[IOTDB-2580] Fix DirectByteBuffer and thread leak when deleting storage group

stop scheduler pool when deleting storage group.

Coverage decreased (-0.02%) to 67.788% when pulling dfbf1d9dc5c77a19e32a097c3ea1ae34c1614bfd on HeimingZ:IOTDB-2580 into efa14ecf97c7b9fec523088fd7db58e7999ac961 on apache:master.


CC0029 should not be reported for structs

Currently CC0029 is reported for struct types. This is not correct, because these types cannot have user-defined finalizers.
This is a sub-task of #95.

Bug confirmed.


iPad mouse scroll

Is it possible to support probable scrolling on iPads safari in config?

What is "probable scrolling"? Google didn't help me find something related to iPad devices.

I will record my screen later

On 27 Jun 2020, at 01:30, oznu<EMAIL_ADDRESS>wrote:

What is "probable scrolling"? Google didn't help me find something related to iPad devices.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

Is this the same problem raised in #755?

No - i mean this behavior in the config tab.
https://share.icloud.com/photos/0R4Da45BtW0wGSvAU1xjnVChQ


Fix extension loading for Android versions < 14

If we are on Android 14 or higher, the final jar file's name is based on the name of the extension.
Older versions just name it classes.jar
Change-Id: I4295815718eaeb91d504b478c6e44f695dcac488

General items:

[ ] I have updated the relevant documentation files under docs/
[ ] My code follows the:

[ ] Google Java style guide (for .java files)
[ ] Google JavaScript style guide (for .js files)

[ ] ant tests passes on my machine

If your code changes how something works on the device (i.e., it affects the companion):

[x] I branched from ucr
[x] My pull request has ucr as the base

Further, if you've changed the blocks language or another user-facing designer/blocks API (added a SimpleProperty, etc.):

[ ] I have updated the corresponding version number in YaVersion.java
[ ] I have updated the corresponding upgrader in YoungAndroidFormUpgrader.java (components only)
[ ] I have updated the corresponding entries in versioning.js

For all other changes:

[ ] I branched from master
[ ] My pull request has master as the base

What does this PR accomplish?

Description

Fixes # .

Resolves # .

Note: before merging, I'll remove the extra debug logging.


Where are the doc links for triggers?

Describe the bug
Triggers have no doc link.
Version
Version:  1.4.0-nightly.237625.d1378c6
Electron: 8.2.4
Chrome: 80.0.3987.165
NodeJS: 12.13.0
V8: 8.0.426.27-electron.0
To Reproduce
Steps to reproduce the behavior:

Create a trigger

Expected behavior
There should be doc links for every composer action or trigger.
Screenshots

@chrimc62 see the tooltip on the Trigger phrases element.
cc @sangwoohaan for comment

Here's the list of triggers and associated documentations :
https://microsoft-my.sharepoint-df.com/:x:/g/personal/sahan_microsoft_com1/EVGYu5w-FrpBsGoHWcZcTXQBbepwYVUMc7I13YornmTbTA?e=VBhym2
Let's add Learn more buttons to Triggers, and link to these docs.

Please follow the guidelines outlined in this spec:
https://microsoft.sharepoint.com/:w:/r/teams/ConversationalAI785/_layouts/15/Doc.aspx?sourcedoc={C52BBE6D-42E3-4B35-BC6F-B94704C047BF}&file=R11 Spec - Tooltips and Help Links.docx&action=default&mobileredirect=true
When links to documentation is needed, add instructional copy in the modal, page or properties panel where the concept or label is introduced. If a tooltip needs a 'learn more' link, this means that the/a tooltip is not sufficient and either needs to contain more informative copy, or the instruction needs to be elevated and visible at all times vs in a tooltip.
< copy pasted from the document above >

Content type
Source
Guidelines

Tooltip
SDK / Code comment
Provide the user with information about a UX element or label (example: Hover over highlighter icon, tooltip shows label: Highlighter') Do not replace, nor should be used as instructional copy. Tooltip is short: Less than 2 short sentences in English. Text in the tooltip shall not repeat the label or name of the element it is intended to describe or the watermark text inside an entry field/edit box. Meets accessibility guidelines (including how they are invoked and presented) Meets Fluent design guidelines May include visuals or diagrams Cannot be clicked

Help link | UI schema/Documentation | Help links should be contextual to the user experience. A “learn more” link is usually placed at the end of a string or a UI card or as curated collection of documentation links on a blade. Context sensitive – should point to the specific section in documentation that pertains to the context/topic of the help link. Link to the specific section of an article if necessary Determine the best link text to use, considering accessibility requirements Where possible, the help link is specific about the content it will link to (vs ‘Learn more’) Create a fwlink and reference it in code
Instructional copy | UI schema | Instructional text provides the user with information about what to DO/how to use the UX. (not: provide information about the product) Instructional text is created with specific context in mind to best help the user with the specific task at hand. Instructional text shall not repeat the label, name of the element it is intended to describe or the watermark text inside an entry field/edit box. Where more information is needed than 1 or 2 sentences (in English) a link for more information is included. This link must go to the specific section or paragraph (vs the top of an article that covers multiple topics) Meet accessibility guidelines (including how they are invoked and presented) Meet Fluent design guidelines Instructional text may be accompanied  by illustrations or diagrams, below or next to the copy.
Watermark copy | UI schema | Text that lives inside an edit box/entry field Single word or short sentence to show an example of what information is expected to be filled out in this box,
Error messages | Composer code |


tests fail - ubuntu and win10

@pfrazee
Can you confirm, that all tests pass with latest master on macOS? ... So I do have a reference point :)

@pfrazee ... Any info on the macOS tests. Do they pass? .. I think, I did find some problems with windows already, but I need to be sure, that tests are ok with macOS. Otherwise it doesn't make sense to dig deeper.

No something's gone wrong, I just get infinite windows opening. I'm going to burnthemall and retry just to be sure

Yeah something's gone wrong in mine. I'll have to debug when I get home today.

Yeah this is all issues with the update to Electron 1.5. I needed to bump the Spectron version, and now it looks like Buffers are not transferring like they used to

Oooook, that was a PITA but we're updated. The bkr fork test fails for me, but it has for a while and I've got a TODO to figure out why. Everything else is passing in OSX on master.

cool. thx. I'll have a look and report back.


important problem

How to make a progress bar when the progress bar shows that it can be operation interface, because when a progress bar pops up, now he can only wait for, and can't do any operation, thank you

Doesn't really seem like an "important problem" to me. And I don't get what you're trying to do. You should check the Examples project, it contains multiple implementations of determinate and indeterminate progress.

Thank you for your reply, I have a look at it


Use partner-provided subscription for cosmos live tests

This PR changes the cosmos live tests to target a subscription billed to and owned by the cosmos partner team.

For some reason the live tests aren't getting linked: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=875276&view=results


Releases for packaging

Hi! I would like to package this project for Arch Linux.
Do you have plans for creating releases for this project? This would be a requirement for allowing us to use verifiable tarballs and create system packages from them.

Sorry, I don't have plans for this atm. Could you provide some example repos?

https://archlinux.org/packages/?sort=&q=neovim-


Nested  support

Hi, in a nested Draggable components (see example), who can I prevent moving the parent when dragging the child?
Thanks!

Found it! https://github.com/mzabriskie/react-draggable/issues/11


[BUG] Potential kernel issue relating to v4l2 with kernel, which I believe affects picamera2

I've just edited the following bug report sorry, as I realised I'd only grepped recent journalctl info, it looks like the issue has occurred sporadically since last December at least.
Describe the bug
I noticed I didn't seem to be getting many videos from my Raspberry Pi camera running capture_circular_stream.py.
After looking in my journal, I found interesting kernel messages (listed later).
To Reproduce
Leave capture_circular_stream.py running over long time period and monitor journalctl.
Expected behaviour
No kernel issue.
Console Output, Screenshots
Mar 15 23:42:31 pi2 kernel: vc_sm_cma_vchi_rx_ack: received response 2476813, throw away...
Mar 15 23:42:31 pi2 kernel: INFO: task capture_circula:817 blocked for more than 120 seconds.
Mar 15 23:42:31 pi2 kernel:       Tainted: G         C         6.6.20+rpt-rpi-v8 #1 Debian 1:6.6.20-1+rpt1
Mar 15 23:42:31 pi2 kernel: "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message.
Mar 15 23:42:31 pi2 kernel: task:capture_circula state:D stack:0     pid:817   ppid:1      flags:0x00000004
Mar 15 23:42:31 pi2 kernel: Call trace:
Mar 15 23:42:31 pi2 kernel:  __switch_to+0xe8/0x168
Mar 15 23:42:31 pi2 kernel:  __schedule+0x380/0xd70
Mar 15 23:42:31 pi2 kernel:  schedule+0x64/0x108
Mar 15 23:42:31 pi2 kernel:  schedule_preempt_disabled+0x2c/0x50
Mar 15 23:42:31 pi2 kernel:  __mutex_lock.constprop.0+0x2ac/0x608
Mar 15 23:42:31 pi2 kernel:  __mutex_lock_slowpath+0x1c/0x30
Mar 15 23:42:31 pi2 kernel:  mutex_lock+0x50/0x68
Mar 15 23:42:31 pi2 kernel:  v4l2_m2m_fop_poll+0x38/0x80 [v4l2_mem2mem]
Mar 15 23:42:31 pi2 kernel:  v4l2_poll+0x54/0xc8 [videodev]
Mar 15 23:42:31 pi2 kernel:  do_sys_poll+0x2a4/0x5b8
Mar 15 23:42:31 pi2 kernel:  __arm64_sys_ppoll+0xb0/0x140
Mar 15 23:42:31 pi2 kernel:  invoke_syscall+0x50/0x128
Mar 15 23:42:31 pi2 kernel:  el0_svc_common.constprop.0+0x48/0xf0
Mar 15 23:42:31 pi2 kernel:  do_el0_svc+0x24/0x38
Mar 15 23:42:31 pi2 kernel:  el0_svc+0x40/0xe8
Mar 15 23:42:31 pi2 kernel:  el0t_64_sync_handler+0x100/0x130
Mar 15 23:42:31 pi2 kernel:  el0t_64_sync+0x190/0x198

Hardware :
Pi 4 and Raspberry Pi Auto Focus Camera
Many thanks!

Hi Chris, thanks for the report. Any idea how long it needs to be running, is several days enough do you think? Do you think it's also still an issue in the latest 6.6 kernel which was generally released at the end of last week?
@lurch Andrew, I don't suppose I could tempt you into giving this one a try (pretty please)?

@chrisruk I'm having a similar issue (#986). How many days did your script run? Mine ran for about 250 hours. Do you know how many files were written before it started to write 0 bytes? I'm wondering if it's a number of files or a length of time. I've started a counter in my script to collect that information.

Hi David,
I'm fairly sure the first time I noticed this was with the latest kernel (6.6.20+rpt-rpi-v8).
I've grepped the logs for 'blocked for', alas it seems to occur very infrequently for me, so it may be extremely hard to replicate.
It seems to occur a number of times in a row, but it looks like I've only seen it on Dec 09, Feb 14, Mar 15, Mar 16.
Note that my script starts/stops each day via cron, running the script for around 13hrs a day.
@ajkelsey I'm not running the same process continuously I'm a afraid and I don't think I've seen 0 byte files unless I'm mistaken.

Well, let's put this on the list of things to try and reproduce - that's usually always the first thing to try and do!

I've now been running the capture_circular_stream.py script continuously for a whole week, and haven't seen any errors.
@chrisruk Is there still plenty of free disk-space on your SD card? (I'm just guessing, but I wonder if a lack of disk-space might cause a hung_task_timeout? :shrug: )

It seems quite suspicious to me that the vchi error message has also been observed now in issue https://github.com/raspberrypi/picamera2/issues/986. So I do believe there's something going on here, just it's proving very difficult to provoke at our end.
On that other issue, the following suggestion has been made:

Running with start_debug=1 in config.txt, and using sudo vclog -m and sudo vclog -a after it goes wrong would be useful.

Chris, would you be able to give that a try, then maybe we can learn something more if it happens to you again?

@6by9 Could you perhaps answer Chris's question, re. whether sudo vclog -a should be run immediately? Thanks!

There should be relatively few asserts in the firmware on a normal system, so timing shouldn't be critical.
(If you're getting lots of asserts logged under normal situations, then let us know as they ought to be fixed).
By default there is relatively little logging enabled on the firmware, so whilst there will be more churning through the vclog -m buffer, it again shouldn't be too verbose.

Thanks for that information!  Will post an update if the issue occurs again, with more log info.

Hi Chris, and thanks for the update. I've been running the other case we have showing these vc_sm_cma_vchi_rx_ack errors (https://github.com/raspberrypi/picamera2/issues/986), so far for about 10 days without any problems. Given my failure to provoke any errors, and the fact that I'm on the latest OS and kernel (which is 6.6), I wonder if it might be worth everyone making sure they're fully up to date (usual caveats about backing stuff up apply!), just to be sure that I'm chasing something that is still there! But the SD card tip is probably a good one, it's always something to try (like dodgy power supplies or long cables!).

Hi David, replacing the SD card has meant videos are now recorded throughout the time period my script runs :) (Before it seemed to be stopping receiving new frames after a period of time)
Feel free to close this issue now.  I'm thinking the hanging task error might have been related to issues with the SD card.

Cool, thanks for the update! If it comes back... you know where we are :)


Handle Canvas.raster subpixel condition

When Canvas.raster is requested to downsample a plot to subpixel range all kinds of errors can occur due to negative dimensions and inverted ranges, additionally the padding code can get confused due to zero sized padding arrays. This ensures that the src_window always has a non-zero shape and that the padding is robust to issues like these.

[ ] Add a number of unit tests

I'm a bit confused by why these changes are necessary.  In all cases where I have investigated, the lines being changed here should never be reached, because a negative or zero plot_width or plot_height is being requested.  Are there cases where this code will be activated for some valid plot_width or plot_height?  Perhaps some case where the overall plot widths and heights are fine, but the plot ends up consisting entirely of padding?
In any case I think we should be guarding against plot_width and plot_height ever being set to a value that's less than 1, which is trivial if we make those into Parameters, but meanwhile could be an assertion.

If the x_range or y_range defines a region that is smaller than 1 pixel three kinds of issue occur:

The integer slices into the data array invert due to half pixel offsets
The shape allocated to resampled region is 0
The shape allocated to the padding region is 0

This is independent of any plot_width or plot_height issues

On Mar 15, 2018, at 6:07 PM, James A. Bednar<EMAIL_ADDRESS>wrote:
I'm a bit confused by why these changes are necessary. In all cases where I have investigated, the lines being changed here should never be reached, because a negative or zero plot_width or plot_height is being requested. Are there cases where this code will be activated for some valid plot_width or plot_height? Perhaps some case where the overall plot widths and heights are fine, but the plot ends up consisting entirely of padding?
In any case I think we should be guarding against plot_width and plot_height ever being set to a value that's less than 1, which is trivial if we make those into Parameters, but meanwhile could be an assertion.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/bokeh/datashader/pull/573#issuecomment-373471406, or mute the thread https://github.com/notifications/unsubscribe-auth/ABepsyXJrcOiUdSnAE8SVy-Xt9qfG8jvks5teq3TgaJpZM4Ssnay.

It sounds to me like you've uncovered issues semantically related to the ones we've been encountering today, but strictly independent of them.  Sometimes it is very helpful to give a vague bug report to someone, so that they discover the problems nearby those that were discovered. :-)

Sounds like a good debugging strategy.  But when the requested plot_width or plot_height is 0 or negative, there is no image to render at all, so no datashader code (other than perhaps an assertion) should ever be executed.  The fixes listed here would address different (but equally bad) conditions that arise when the supplied plot_width and plot_height are valid, yet the rendered array would still have been calculated to be smaller than one pixel in x or y because of padding.

But when the requested plot_width or plot_height is 0 or negative, there is no image to render at all, so no datashader code (other than perhaps an assertion) should ever be executed.

That's a sensible thing to do in future, but I'm not aware of any code in datashader or holoviews that would have stopped datashader code from executing in this case.

That's right.  HoloViews shouldn't be requesting a zero or negative size, and Datshader should complain when it is asked for one.

Added some unit tests and simplified the changes. The validation of input parameters can be followed up on as part of https://github.com/bokeh/datashader/issues/574.

Tests passing, merging.


lis-autocontent: Read timed out error

When I ran "make jbrowse" on jekyll-soybase lis-autocontent branch, I encountered the following errors:
See detailed message:
Traceback (most recent call last):
File "/Users/weihuang/Project/jekyll-soybase/venv/lib/python3.9/site-packages/urllib3/response.py", line 441, in _error_catcher
yield
File "/Users/weihuang/Project/jekyll-soybase/venv/lib/python3.9/site-packages/urllib3/response.py", line 522, in read
data = self._fp.read(amt) if not fp_closed else b""
File "/Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/3.9/lib/python3.9/http/client.py", line 459, in read
n = self.readinto(b)
File "/Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/3.9/lib/python3.9/http/client.py", line 503, in readinto
n = self.fp.readinto(b)
File "/Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/3.9/lib/python3.9/socket.py", line 704, in readinto
return self._sock.recv_into(b)
File "/Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/3.9/lib/python3.9/ssl.py", line 1241, in recv_into
return self.read(nbytes, buffer)
File "/Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/3.9/lib/python3.9/ssl.py", line 1099, in read
return self._sslobj.read(len, buffer)
socket.timeout: The read operation timed out
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/Users/weihuang/Project/jekyll-soybase/venv/lib/python3.9/site-packages/requests/models.py", line 760, in generate
for chunk in self.raw.stream(chunk_size, decode_content=True):
File "/Users/weihuang/Project/jekyll-soybase/venv/lib/python3.9/site-packages/urllib3/response.py", line 579, in stream
data = self.read(amt=amt, decode_content=decode_content)
File "/Users/weihuang/Project/jekyll-soybase/venv/lib/python3.9/site-packages/urllib3/response.py", line 544, in read
raise IncompleteRead(self._fp_bytes_read, self.length_remaining)
File "/Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/3.9/lib/python3.9/contextlib.py", line 135, in exit
self.gen.throw(type, value, traceback)
File "/Users/weihuang/Project/jekyll-soybase/venv/lib/python3.9/site-packages/urllib3/response.py", line 446, in _error_catcher
raise ReadTimeoutError(self._pool, None, "Read timed out.")
urllib3.exceptions.ReadTimeoutError: HTTPSConnectionPool(host='data.legumeinfo.org', port=443): Read timed out.
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/Users/weihuang/Project/jekyll-soybase/venv/bin/lis-autocontent", line 8, in
sys.exit(cli_entry_point())
File "/Users/weihuang/Project/jekyll-soybase/venv/bin/lis_autocontent.py", line 19, in cli_entry_point
cli()  # invoke cli
File "/Users/weihuang/Project/jekyll-soybase/venv/lib/python3.9/site-packages/click/core.py", line 1130, in call
return self.main(*args, **kwargs)
File "/Users/weihuang/Project/jekyll-soybase/venv/lib/python3.9/site-packages/click/core.py", line 1055, in main
rv = self.invoke(ctx)
File "/Users/weihuang/Project/jekyll-soybase/venv/lib/python3.9/site-packages/click/core.py", line 1657, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "/Users/weihuang/Project/jekyll-soybase/venv/lib/python3.9/site-packages/click/core.py", line 1404, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "/Users/weihuang/Project/jekyll-soybase/venv/lib/python3.9/site-packages/click/core.py", line 760, in invoke
return __callback(*args, **kwargs)
File "/Users/weihuang/Project/jekyll-soybase/venv/bin/lis_cli.py", line 123, in populate_jbrowse2
parser.parse_collections(taxa_list)  # parse_collections
File "/Users/weihuang/Project/jekyll-soybase/venv/bin/process_collections.py", line 549, in parse_collections
self.process_taxon(taxon)  # process taxon object
File "/Users/weihuang/Project/jekyll-soybase/venv/bin/process_collections.py", line 527, in process_taxon
self.process_species(
File "/Users/weihuang/Project/jekyll-soybase/venv/bin/process_collections.py", line 440, in process_species
self.add_collections(collection_type, genus, species)
File "/Users/weihuang/Project/jekyll-soybase/venv/bin/process_collections.py", line 329, in add_collections
protein_response = self.get_remote(protein_url)
File "/Users/weihuang/Project/jekyll-soybase/venv/bin/process_collections.py", line 65, in get_remote
response = requests.get(url, timeout=5)  # get remote object
File "/Users/weihuang/Project/jekyll-soybase/venv/lib/python3.9/site-packages/requests/api.py", line 75, in get
return request('get', url, params=params, **kwargs)
File "/Users/weihuang/Project/jekyll-soybase/venv/lib/python3.9/site-packages/requests/api.py", line 61, in request
return session.request(method=method, url=url, **kwargs)
File "/Users/weihuang/Project/jekyll-soybase/venv/lib/python3.9/site-packages/requests/sessions.py", line 529, in request
resp = self.send(prep, **send_kwargs)
File "/Users/weihuang/Project/jekyll-soybase/venv/lib/python3.9/site-packages/requests/sessions.py", line 687, in send
r.content
File "/Users/weihuang/Project/jekyll-soybase/venv/lib/python3.9/site-packages/requests/models.py", line 838, in content
self._content = b''.join(self.iter_content(CONTENT_CHUNK_SIZE)) or b''
File "/Users/weihuang/Project/jekyll-soybase/venv/lib/python3.9/site-packages/requests/models.py", line 767, in generate
raise ConnectionError(e)
requests.exceptions.ConnectionError: HTTPSConnectionPool(host='data.legumeinfo.org', port=443): Read timed out.
make: *** [jbrowse] Error 1

moved this to the LIS-autocontent repo, @ctcncgr will see it now...

Hey @weihuang12. Apologies, I see this now. Will look into it thank you!

After Connor's recent update (a legumeinfo/lis-autocontent that reads from a local _data/datastore-metadata git submodule instead of the public data store HTTP site) and Nathan updated Soybase/jekyll-soybase@lis-autocontent branch to use the version from that PR ), the Read timed out error seems solved.

Please let me know if things look off in the future. Thank you. Closing


hack/jenkins: add conformance tests

This PR adds a Jenkins job to run conformance tests with sonobuoy. The job will be triggered nightly. The results of the tests get generated as tar ball in the Jenkins build artifacts. I have already tested this on the Jenkins setup (https://jenkins-kube-upstream.prod.coreos.systems/job/tku-bootkube-conformance-cncf/)
NOTES:

The image used in the Jenkins pipeline is the bootkube-e2e-builder image, since they both have the same dependencies.
Currently there is no result analysis or slack trigger. Once we observe the behavior for a while we can add this in as a next step.
Instead of pulling in from cncf/k8s-conformance/master everytime, the sonobuoy-conformance.yaml is hard coded into the scripts/conformance.sh script since the k8s-conformance/master branch is subject to change at anytime.

Will add some docs explaining how to analyze the test results manually.


ImportError: cannot import name 'Markup' from 'flask'

First I want to apologize if I've done anything wrong with this bug report, I'm still new to development and any mistakes made are unintentional.

Environment:

Python version: 3.11.3
Flask version: 2.3.0

Duplicate of https://github.com/pallets/flask/issues/5084


Code simplification

Description
Code simplification
(it is also faster, but in this case we don't care)
Type of change

[x] Refactor
[ ] New feature
[ ] Bug fix
[ ] CVE fix
[ ] Optimization
[ ] Documentation Update
[ ] Configuration Update
[ ] Bump-up dependent library
[ ] Bump-up library or tool used for development (does not change the final image)

/lgtm


Order by lost if where is set

Hello,  and thanks for this tool is very helpful,
Now i cant figure out whats wrong.
$Z = $database->select("Vorgaenge", ["ID","Pos","btext"], ["Verwendung" => "Geldzaehler"], ["ORDER" => "Pos"]);
echo $database->last_query();
SELECT "ID","Pos","Buchungstext" FROM "Vorgaenge" WHERE "Verwendung" = 'Geldzaehler'
The Order by is lost.
if i use without where ORDER works.
$Z = $database->select(["Vorgaenge", ["ID","Pos","btext"], ["ORDER" => "Pos"]]);
echo $database->last_query();
SELECT "ID","Pos","Buchungstext" FROM "Vorgaenge" ORDER BY "Pos"

There are no 4th parameter for the method call in this case.
The condition for value and ORDER are together.
$database->select("Vorgaenge", [
	"ID",
	"Pos",
	"btext"
], [
	"Verwendung" => "Geldzaehler",
	"ORDER" => "Pos"
]);

There are no 4th parameter for the method call in this case.
The condition for value and ORDER are together.
$database->select("Vorgaenge", [
	"ID",
	"Pos",
	"btext"
], [
	"Verwendung" => "Geldzaehler",
	"ORDER" => "Pos"
]);


in what file format we should keep sentinel images inside sentinel_path

i am facing problem in processing the satelite images using process satellite images notebook, please help

I am also facing the same problem


Problem with special input data

Hi, I have implemented the code successfully with the data provided by make_blobs.
However, when I change the input data with the array [[0],[0]....[0],[20]] which are a set of 0 and a 20(noise), the output (cluster.labels_) is a set of -1 which means that the input data are all noises.
I am wondering if there is any problem.

Did you allow a single cluster ? By default, HDBSCAN will always consider there are at least two clusters in your data : the stability of the root of the condensed tree is not calculated at all.
But i asked recently for the option to allow the case of one single cluster : add allow_single_cluster==True in the constructor of the class HDBSCAN and it should be ok (with last version of the master branch)

Thank you very much!  Anyway, thanks very much

I think this is good now?


Add query string parsing guide

Since there's been some discussion around it in https://github.com/ReactTraining/react-router/issues/4410 I made a quick guide to help other users and to develop a best-practice for the community.
It's based on the result of the discussion, mainly on comments by @pshrmn and @v1kku.
I'm happy about any feedback, especially regarding the language (since I'm not a native english speaker).

Closing since it has been six months with no fixes. This could be reopened if the changes are made, but I'm not sure this guide is really necessary (query string parsing came up a lot when v4 was first released, but it has been a while since I've seen an issue opened up about it ).


Personal/movegitops

Try this in preview

:star: PR built and available in a preview environment mailming-pyweb-pr-7 here

:star: PR built and available in a preview environment mailming-pyweb-pr-7 here

This is right


Plugin is not compatible with IntelliJ IDE 2022.3

Description
UnitTestBot cannot be installed into the latest IDE: IDEA, PyCharm, WebStorm, because it has limitation up to 222.* version.
Latest PyCharm 2022.3 has 223.7571.203 version (came out on Dec 1)
Same for latest WebStorm 2022.3 (Nov 28)
Same for IDEA (Nov 30)
To Reproduce

Download and install latest PyCharm Community
Download one of the latest plugin builds from main
File > Settings > Plugins > Install from disk > select downloaded UnitTestBot

Expected behavior
UnitTestBot is supposed to be installed.
Actual behavior
Error message that UnitTestBot is not compatible with this IDE version
Visual proofs (screenshots, logs, images)

Plugin 'UnitTestBot' (version '2022.12.576.') is not compatible with the current version of the IDE, because it requires build 222.* or older but the current build is PC-223.7571.203
Environment
Windows 10 Pro
IntelliJ PyCharm Community 2022.3 / IDEA / WebStorm

There is no kotlin distributable that we can use for the latest version. Will wait for the next release.

Unfortunately, the last abailable version is 222-1.7.21-release-272-IJ4167.29

After this bug is fixed - also check rendering custom Java docs in newest IDE.

I've tried to install plugin built from today's main - the same error:

Kotlin plugin last released version is still 222.
There is only EAP version compatible with IDEA 2022.3: https://plugins.jetbrains.com/plugin/6954-kotlin/versions/eap

But in IDEA Ultimate 2022.3.2 there is bundled Kotlin plugin version 223-*


Bridge Two Clusters

Hi,
I'm running a vernemq cluster and was thinking of setting up another one and bridging the two clusters.
What would be the best way to go about this?
Also, I'm not just considering adding them to the same cluster because they are servers at two geographically separated locations.
Thanks in advance.

I can only ambivalently answer this:
To implement full cluster replication for a multi site setup, MQTT bridges are not an optimal instrument. But we have nothing better currently.
MQTT bridges are basically a way of hooking a MQTT topic tree into another, so they are great to shovel some messages to the other cluster (taking 2 respective cluster nodes).


question and bug

Hello, I would like to use the file 'view_1stm2.py' as my backbone to extract features (I don't need its final head layer for classification). I encountered a keyword mismatch or non-existent issue while loading the weight file. How can I modify the code to use your 'view_1stm/vil2.base16-e400_in1k. th' weight file

If you could reply, I would greatly appreciate it!

VisionLSTM2 is a cleaned version of what we used to train our models. The names of the weights were changed and blocks were merged to be block pairs for easier compatibility with ViT pipelines. Therefore you need to rename weights. This is done in the hubconf.py and automatically done if you load the model as it is instructed in the README via torch.hub.load.

VisionLSTM2 是我们用来训练模型的简化版本。权重的名称被更改，区块被合并为区块对，以便更容易地与 ViT 管道兼容。因此，您需要重命名权重。此操作在 hubconf.py 中完成，如果您按照 README 中的指示加载模型，则会自动完成。torch.hub.load

Thank you, my issue has been resolved!


Migrated Travis CI to Github Actions

Questions
Answers

Description?
Migrated Travis CI to Github Actions

Type?
improvement

BC breaks?
no

Deprecations?
no

Fixed ticket?
N/A

How to test?
Github Actions are :green_circle: https://github.com/Progi1984/ps_wirepayment/actions

Thanks guys for review.


Model changes color with auto-rotate enabled

Hi, i have noticed that when auto-rotate is enabled when interacting with the model the same keeps the lighting of that particular rotation position instead of the initial lighting settings. Please have a look at the image provided.

@joaoibsilva True, but this is intentional. It will be more clear why if you set a skybox-image. I have heard complaints about the backside of the default environment being too dim. Is this what you would like changed, or do you have a different feature request?

I would love to see an option to lock the position of the environment/skybox. Ability to define starting position of the environment/skybox would be great as well.
I have a lot of models with reflective screens, and the default position of the lighting causes a lot of glare. Once it locks to the rotated image it gets better:
default load:

spinning it back, after rotation has started (because the position of the lights is now locked to the side where they were when I rotated):

@mrwobttom No problem, just use resetTurntableRotation(theta): https://modelviewer.dev/docs/#entrydocs-stagingandcameras-methods-resetTurntableRotation. The environment is in fact locked, it's the model that rotates when using auto-rotate. You may also be interested in our more even neutral lighting: https://modelviewer.dev/examples/lightingandenv/#neutralLighting


Cannot connect to mongodb

social-network svc/social-graph-service:
[2021-may-25 07:06:50.186128] <error>: (utils_mongodb.h:68:createindex) error in createindexes: no suitable servers found: `serverselectiontimeoutms` expired: [connection timeout calling ismaster on 'social-graph-mongodb:27017']
[2021-may-25 07:06:50.186221] <error>: (socialgraphservice.cpp:63:main) failed to create mongodb index, try again
[2021-may-25 07:06:51.486131] <error>: (utils_mongodb.h:68:createindex) error in createindexes: no suitable servers found: `serverselectiontimeoutms` expired: [connection timeout calling ismaster on 'social-graph-mongodb:27017']
[2021-may-25 07:06:51.486221] <error>: (socialgraphservice.cpp:63:main) failed to create mongodb index, try again
[2021-may-25 07:06:52.786186] <error>: (utils_mongodb.h:68:createindex) error in createindexes: no suitable servers found: `serverselectiontimeoutms` expired: [connection timeout calling ismaster on 'social-graph-mongodb:27017']
[2021-may-25 07:06:52.786422] <error>: (socialgraphservice.cpp:63:main) failed to create mongodb index, try again
[2021-may-25 07:06:54.086204] <error>: (utils_mongodb.h:68:createindex) error in createindexes: no suitable servers found: `serverselectiontimeoutms` expired: [connection timeout calling ismaster on 'social-graph-mongodb:27017']
[2021-may-25 07:06:54.086345] <error>: (socialgraphservice.cpp:63:main) failed to create mongodb index, try again
[2021-may-25 07:06:55.386129] <error>: (utils_mongodb.h:68:createindex) error in createindexes: no suitable servers found: `serverselectiontimeoutms` expired: [connection timeout calling ismaster on 'social-graph-mongodb:27017']
[2021-may-25 07:06:55.386207] <error>: (socialgraphservice.cpp:63:main) failed to create mongodb index, try again

Hello,
I am getting the exact same error while running the init graph script. Did you ever find what was at fault for it?
Thank you

Same here

The issue for me was that the latest mongo docker-hub image could not run on my AMD cpu. It may also not run on several intel CPUs.
Here are some steps that helped me:
1. Run docker-compose without -d
In the DeathStarBench/socialNetwork folder
docker-compose up

2. Check if you have the same mongo image issue
If you see something like the following, you have the same issue:
user-mongodb_1            |
user-mongodb_1            | WARNING: MongoDB 5.0+ requires a CPU with AVX support, and your current system does not appear to have that!
user-mongodb_1            |   see https://jira.mongodb.org/browse/SERVER-54407
user-mongodb_1            |   see also https://www.mongodb.com/community/forums/t/mongodb-5-0-cpu-intel-g4650-compatibility/116610/2
user-mongodb_1            |   see also https://github.com/docker-library/mongo/issues/485#issuecomment-891991814
user-mongodb_1            |
...
user-service_1            | [2022-Feb-05 00:44:18.439453] <error>: (utils_mongodb.h:76:CreateIndex) Error in createIndexes: No suitable servers found: `serverSelectionTimeoutMS` expired: [Failed to resolve 'user-mongodb']
user-service_1            | [2022-Feb-05 00:44:18.442059] <error>: (UserService.cpp:80:main) Failed to create mongodb index, try again

3. If you have the same issue, change the docker-compose.yml to use mongo:4.4.6
Replace all:
"image: mongo" => "image: mongo:4.4.6"

Optionally, remove all restart: always arguments in the docker-compose.yml file to explicitly see failed images.

Hello,
I am getting the exact same error while running the init graph script. Did you ever find what was at fault for it?
Thank you

Same here

Hello,
Did you ever find what was at fault for it?

Same here

Hello, Did you ever find what was at fault for it?

Finally I use Train-Ticket instead :(
https://github.com/lizeyan/train-ticket


Added automatic linting to the repository

Fixed the linting issues in all files of this repo
enabled auto linting for all new files on commit

Can you please check why when some test cases fail locally and work fine in the CI pipeline? I am using the same chain(agd container) we use in the CI, on my local. There is a conflict in finding the selector Agoric localhost and Agoric local.

Can you please check why when some test cases fail locally and work fine in the CI pipeline? I am using the same chain(agd container) we use in the CI, on my local. There is a conflict in finding the selector Agoric localhost and Agoric local.

@rabi-siddique  lets discuss in a separate thread. its not related to this PR

Can you please check why when some test cases fail locally and work fine in the CI pipeline? I am using the same chain(agd container) we use in the CI, on my local. There is a conflict in finding the selector Agoric localhost and Agoric local.

@rabi-siddique lets discuss in a separate thread. its not related to this PR

Sure. But please inspect what's causing this.


Compiled to arangodb 3.1 for windows.

environments:
Qt5.8
Arangodb 3.1
windows7 x64
problem:
Running "D:\cmake-3.8.0-rc1-win64-x64\bin\cmake.exe E:/arangodb-3.1 "-GCodeBlocks - MinGW    Makefiles" "-DCMAKE_CXX_COMPILER:STRING=D:/Qt/Qt5.8/Tools/mingw530_32/bin/g++.exe" "-DCMAKE_C_COMPILER:STRING=D:/Qt/Qt5.8/Tools/mingw530_32/bin/gcc.exe" "-DCMAKE_PREFIX_PATH:STRING=D:/Qt/Qt5.8/5.8/mingw53_32" "-DQT_QMAKE_EXECUTABLE:STRING=D:/Qt/Qt5.8/5.8/mingw53_32/bin/qmake.exe"" in C:\Users\Administrator\AppData\Local\Temp\qtc-cmake-piLz0c.
-- The CXX compiler identification is GNU 5.3.0
-- The C compiler identification is GNU 5.3.0
-- Check for working CXX compiler: D:/Qt/Qt5.8/Tools/mingw530_32/bin/g++.exe
-- Check for working CXX compiler: D:/Qt/Qt5.8/Tools/mingw530_32/bin/g++.exe -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Check for working C compiler: D:/Qt/Qt5.8/Tools/mingw530_32/bin/gcc.exe
-- Check for working C compiler: D:/Qt/Qt5.8/Tools/mingw530_32/bin/gcc.exe -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Found PythonInterp: C:/Python27/python2.exe (found suitable exact version "2.7.10")
-- Performing Test _HAS_CXX11_FLAG
-- Performing Test _HAS_CXX11_FLAG - Success
-- Checking C++11 support for "func"
-- Checking C++11 support for "func": works
-- Checking C++11 support for "auto"
-- Checking C++11 support for "auto": works
-- Checking C++11 support for "auto_ret_type"
-- Checking C++11 support for "auto_ret_type": works
-- Checking C++11 support for "class_override_final"
-- Checking C++11 support for "class_override_final": works
-- Checking C++11 support for "constexpr"
-- Checking C++11 support for "constexpr": works
-- Checking C++11 support for "conditional"
-- Checking C++11 support for "conditional": works
-- Checking C++11 support for "decltype"
-- Checking C++11 support for "decltype": works
-- Checking C++11 support for "initializer_list"
-- Checking C++11 support for "initializer_list": works
-- Checking C++11 support for "lambda"
-- Checking C++11 support for "lambda": works
-- Checking C++11 support for "range_based_for_loop"
-- Checking C++11 support for "range_based_for_loop": works
-- Checking C++11 support for "nullptr"
-- Checking C++11 support for "nullptr": works
-- Checking C++11 support for "tuple"
-- Checking C++11 support for "tuple": works
-- Checking C++11 support for "regex"
-- Checking C++11 support for "regex": works
-- Checking C++11 support for "rvalue-references"
-- Checking C++11 support for "rvalue-references": works
-- Checking C++11 support for "sizeof_member"
-- Checking C++11 support for "sizeof_member": works
-- Checking C++11 support for "static_assert"
-- Checking C++11 support for "static_assert": works
-- Checking C++11 support for "variadic_templates"
-- Checking C++11 support for "variadic_templates": works
-- Checking C++11 support for "shared_ptr"
-- Checking C++11 support for "shared_ptr": works
-- Checking C++11 support for "unique_ptr"
-- Checking C++11 support for "unique_ptr": works
-- Checking C++11 support for "weak_ptr"
-- Checking C++11 support for "weak_ptr": works
-- Checking C++11 support for "thread"
-- Checking C++11 support for "thread": works
-- Checking C++11 support for "mutex"
-- Checking C++11 support for "mutex": works
-- Checking C++11 support for "noexcept"
-- Checking C++11 support for "noexcept": works
-- Looking for pthread.h
-- Looking for pthread.h - found
-- Looking for pthread_create
-- Looking for pthread_create - found
-- Found Threads: TRUE
-- Could NOT find jemalloc (missing:  JEMALLOC_INCLUDE_DIR JEMALLOC_LIBRARIES)
-- using 3rdParty BOOST
-- Check if the system is big endian
-- Searching 16 bit integer
-- Looking for sys/types.h
-- Looking for sys/types.h - not found
-- Looking for stdint.h
-- Looking for stdint.h - not found
-- Looking for stddef.h
-- Looking for stddef.h - not found
-- Check size of unsigned short
-- Check size of unsigned short - failed
-- Check size of unsigned int
-- Check size of unsigned int - failed
-- Check size of unsigned long
-- Check size of unsigned long - failed
CMake Error at D:/cmake-3.8.0-rc1-win64-x64/share/cmake-3.8/Modules/TestBigEndian.cmake:41 (message):
no suitable type found
Call Stack (most recent call first):
3rdParty/V8/CMakeLists.txt:26 (TEST_BIG_ENDIAN)
-- Configuring incomplete, errors occurred!
See also "C:/Users/Administrator/AppData/Local/Temp/qtc-cmake-piLz0c/CMakeFiles/CMakeOutput.log".
See also "C:/Users/Administrator/AppData/Local/Temp/qtc-cmake-piLz0c/CMakeFiles/CMakeError.log".
*** cmake process exited with exit code 1.

It seems that you are using "CodeBlocks" as the cmake generator.
From the cmake output it seems like the c++ compiler environment is not properly set up:
-- Looking for stdint.h
-- Looking for stdint.h - not found
-- Looking for stddef.h
-- Looking for stddef.h - not found
-- Check size of unsigned short
-- Check size of unsigned short - failed
-- Check size of unsigned int
-- Check size of unsigned int - failed
-- Check size of unsigned long
-- Check size of unsigned long - failed

We have never the "CodeBlocks" generator, but have always used the Visual Studio 14 generator (i.e. cmake -G "Visual Studio 14 Win64" ..). It should work with that. Can you try switching to MSVC 14 for compilation?

ok, thanks.

I guess you got it working? So I'll close this now.


Refactor AWS CLI script

[x] Refactor AWS CLI into bash script
[x] Provide env var examples for AWS CLI requirements
[x] Set our env vars for AWS using gp env

[x] Refactor AWS CLI into bash script
[x] Provide env var examples for AWS CLI requirements
[x] Set our env vars for AWS using gp env


⚠ SpeakUpConference.com has degraded performance

In fcae18a, SpeakUpConference.com (https://www.speakupconference.com) experienced degraded performance:

HTTP code: 200
Response time: 16178 ms

Resolved: SpeakUpConference.com performance has improved in fb6040a after 11 minutes.


MINOR: [C++] Use alphabetical ordering

Appveyor failure seems unrelated S3FS directory deletion error.

Thanks for doing this - would you mind creating a JIRA for this, though? I believe a refactoring like this goes beyond what we consider a minor change, even if it doesn't affect functionality.

FYI: Our "minor" definition is described at https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes

Grammar, usage and spelling fixes that affect no more than 2 files
Documentation updates affecting no more than 2 files and not more than 500 words.

The URL is linked in the auto comment https://github.com/apache/arrow/pull/11785#issuecomment-981114425 .

Thanks. Created ticket https://issues.apache.org/jira/browse/ARROW-14920

Thanks


Implement polygon editor for primitives

Jimmy, test all editing polygon graphics making sure to test both Polygon primitives and Polygon MIL-STD-2525 symbols such as FFA, Assembly Area etc.  Primitives and Polygons use different threads of code so verify for both the edit events are being raised through the addEventListener (FeatureEditEvent), and that the callbacks are being raised (the toasters that pop up during editing).  Verify the updates show all the coordinates, verify the callbacks all have the correct parameters according to our documentation.

Reintegrate. All polygons (Primitive and Mil-Std) had no issues editing and all listener messages fired correctly (Start, Update, Cancel, and Complete)


Tests: simplify test condition (NFCI)

Rather than iterating over all the jobs (even if there are only two) to
find a matching job, extract the module emission job and verify that the
assertions hold over the job.

@swift-ci please test


Argo server issue, breaking intermittently

Hi,
We deployed argo 2.6.2 and its working fine. But we have to run "argo server" command in the background in order to see the argo server UI. sometimes the background process is breaking and its causing issues with argo servers and we are unable to access the UI as well as our job submission is getting crippled. I  deployed argo server using the following instruction from official argo github:
https://github.com/argoproj/argo/tree/master/manifests/base/argo-server
Is there anyway I can have "argo server" service running continuously without initiating it manually through command line "argo server"?
argo: v2.6.2
BuildDate: 2020-03-12T16:04:25Z
GitCommit: be0a0bb46ba50ed4d48ab2fd74c81216d
GitTreeState: clean
GitTag: v2.6.2
GoVersion: go1.13.4
Compiler: gc
Platform: linux/amd64
Thank you and appreciate any help or inputs with this issue?
Regards,
CS

This would be hard to diagnose without any logs. Can you get logs for the Argo Server that cover when the server restarts? kubectl logs deploy/argo-server

This would be hard to diagnose without any logs. Can you get logs for the Argo Server that cover when the server restarts? kubectl logs deploy/argo-server

Thank you for the reply. I am looking something with in Argo to run the argo server service continuously instead of firing "argo server" command line? do we have any option from Argo side?

You're looking to host the server in hosted mode.
In short, you need a deployment that essentially runs the argo server command in the cluster:
apiVersion: apps/v1
kind: Deployment
metadata:
  name: argo-server
spec:
  selector:
    matchLabels:
      app: argo-server
  template:
    metadata:
      labels:
        app: argo-server
    spec:
      serviceAccountName: argo-server
      containers:
        - name: argo-server
          image: argoproj/argocli:latest
          args: [server]
          ports:
            - name: web
              containerPort: 2746
          readinessProbe:
            httpGet:
              port: 2746
              scheme: HTTP
              path: /
            initialDelaySeconds: 10
            periodSeconds: 20
      nodeSelector:
        kubernetes.io/os: linux

thank you so much for providing argo server deployment. worked like charm. thank you sir

Glad to hear!


validating checksums

This is a pull to implement #46, validating assorted checksums are all hexadecimal digits, and of suitable length.

Good point.  The bug report was for the checksum being too short, and somehow that stuck in my head...