Improve core credits in readme

Previous discussion was at #1 .
Thank you for your feedback and pull request @birdybro. I am more than happy to highlight the original developer Hrvoje Čavrak (@hrvach) and link to the MiSTer platform.
The only point that I disagree with is labelling this core as a port. While @hrvach's core was a starting point in implementation, the end result differs in a number of significant ways. These include:

Added adjustable color LUT - memory.v
Added config based game setup - core_top.v
Added new CRT renderer - pdp1_vga_crt.v
Added a tape loader - tape_drive.v
Added sleep/wake and memories compatibility for openFPGA (CPU halt and state saving)

For full transparency, these are the parts of the codebase which are still used and not significantly modified from their original state.

cpu.v was slightly modified to run faster
definitions.v

For these reasons, I would consider this a re-implementation and not a port.

Hey @spacemen3, I appreciate the credit. It's obvious that your work is very original and creative, it took a lot of time and effort - kudos on the core! It's really exciting to see somebody else doing pdp-1, especially if my own work helped the end result somehow. I'm excited to see what you do next :-)

I agree with all the reasonings stated for why you wouldn't call it a port, that's fair. Language is pretty subjective anyways, maybe I'm too liberal in my use of the term. :)


Update HowFuzzilliWorks.md to fix broken link

Update HowFuzzilliWorks.md to fix broken link

Closing this for now since it seems inactive, but feel free to reopen!


Incompatible protocol version: client=3.26 vm=4.0 Failed to connect to the VM observatory service at: ws://<IP_ADDRESS>:59555/wENc2Z63E2A=/ws java.io.IOException: Incompatible protocol version: client=3.26 vm=4.0

Cant Run application neither on the physical device nor in Emulator...the below error comes always
Incompatible protocol version: client=3.26 vm=4.0
Failed to connect to the VM observatory service at: ws://<IP_ADDRESS>:59555/wENc2Z63E2A=/ws
java.io.IOException: Incompatible protocol version: client=3.26 vm=4.0

Hi @Ashbuhrz
Could you please provide your flutter doctor -v logs? Are you facing this issue when running from Android Studio and can you run just fine from terminal?
Thank you

i didn't try that...i was in hurry...so that i changed my flutter channel to stable from master...
stable works fine👍

Incompatible protocol version: client=3.15 vm=4.0
Failed to connect to the VM observatory service at: ws://<IP_ADDRESS>:1024/e6DqD4GwtjE=/ws
java.io.IOException: Incompatible protocol version: client=3.15 vm=4.0

I switched to the Stable version

(base) ➜  flutter_demo_learning flutter doctor -v
Flutter assets will be downloaded from https://storage.flutter-io.cn. Make sure you trust this source!
Downloading android-arm-profile/darwin-x64 tools...                 3.1s
Downloading android-arm-release/darwin-x64 tools...                 1.9s
Downloading android-arm64-profile/darwin-x64 tools...               2.1s
Downloading android-arm64-release/darwin-x64 tools...               1.9s
Downloading android-x64-profile/darwin-x64 tools...                 2.7s
Downloading android-x64-release/darwin-x64 tools...                 1.8s
[✓] Flutter (Channel stable, v1.12.13+hotfix.9, on Mac OS X 10.15.6 19G2021, locale zh-Hans-CN)
• Flutter version 1.12.13+hotfix.9 at /Users/xxxxxx/Documents/flutter
• Framework revision f139b11009 (5 months ago), 2020-03-30 13:57:30 -0700
• Engine revision af51afceb8
• Dart version 2.7.2
[✓] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
• Android SDK at /Users/xxxxxx/Library/Android/sdk
• Android NDK location not configured (optional; useful for native profiling support)
• Platform android-28, build-tools 28.0.3
• Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1343-b01)
• All Android licenses accepted.
[✓] Xcode - develop for iOS and macOS (Xcode 11.3)
• Xcode at /Applications/Xcode.app/Contents/Developer
• Xcode 11.3, Build version 11C29
• CocoaPods version 1.9.3
[✓] Android Studio (version 3.4)
• Android Studio at /Applications/Android Studio.app/Contents
• Flutter plugin version 37.1.1
• Dart plugin version 183.6270
• Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1343-b01)

Hi @Ashbuhrz
I see there is a newer open issue with more details,  its regression on the latest master
Please follow up on that issue, I'm closing the current one as a duplicate.
If you disagree, please write in the comments and I will reopen it.
Thank you

Happened to me today after running flutter upgrade.
But it only happens in Android Studio (Windows 10).
When I run flutter run from CMD it works. When pressing "Run" button in AndroidStudio the app launches but it only shows a white screen and the error is displayed:
Incompatible protocol version: client=3.26 vm=4.0
Failed to connect to the VM observatory service at: ws://<IP_ADDRESS>:49939/Fsgksz_QDE0=/ws
java.io.IOException: Incompatible protocol version: client=3.26 vm=4.0

Flutter doctor:
[√] Flutter (Channel master, 1.22.0-10.0.pre.121, on Microsoft Windows [Version 10.0.18363.1082], locale en-DE)
    • Flutter version 1.22.0-10.0.pre.121 at D:\dev\flutter\sdk
    • Framework revision 6c1a29e54c (13 hours ago), 2020-09-09 20:05:05 -0400
    • Engine revision 564367b297
    • Dart version 2.10.0 (build 2.10.0-107.0.dev)

[!] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
    • Android SDK at C:\Users\User\AppData\Local\Android\sdk
    • Platform android-29, build-tools 29.0.3
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
    X Android license status unknown.
      Run `flutter doctor --android-licenses` to accept the SDK licenses.
      See https://flutter.dev/docs/get-started/install/windows#android-setup for more details.

[√] Android Studio (version 4.0)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin version 49.0.2
    • Dart plugin version 193.7547
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)

[!] VS Code (version 1.48.2)
    • VS Code at C:\Users\User\AppData\Local\Programs\Microsoft VS Code
    X Flutter extension not installed; install from
      https://marketplace.visualstudio.com/items?itemName=Dart-Code.flutter

[√] Connected device (1 available)
    • Pixel 4 (mobile) • xxxxxxxxxx • android-arm64 • Android 10 (API 29)

! Doctor found issues in 2 categories.


add resnet model

Fix pylint error
Make docstrings format and content as close to those of LinkeNet and UNet as close as possible.

Merged into conv branch


[FR] Support Ubuntu 24.04

Proposal Summary
Support Ubuntu 24.04.
Motivation
For all users eager to work with the latest Ubuntu release, they would see Fiftyone fail because MongoDB could not be installed on your system. MongoDB does not support Ubuntu 24.04 yet, but it would be very nice to have Fiftyone working again out-of-the-box when MongoDB is ready!
What areas of FiftyOne does this feature affect?

[ ] App: FiftyOne application
[x] Core: Core fiftyone Python library
[ ] Server: FiftyOne server

Details
We don't know how long it takes for MongoDB to support Ubuntu 24.04.
Willingness to contribute
The FiftyOne Community welcomes contributions! Would you or another member of your organization be willing to contribute an implementation of this feature?

[ ] Yes. I can contribute this feature independently
[ ] Yes. I would be willing to contribute this feature with guidance from the FiftyOne community
[x] No. I cannot contribute this feature at this time

Hi @TvdrBurgt. A MongoDB can be configured for systems without a compatible fiftyone-db binary.
If you are able to confirm MongoDB 22.04 works on 24.04 we can add built-in support for Ubuntu 22.04

Seems like mongo db isn't officially supported on 24.04 yet. I was able to install it using
echo "deb [ arch=amd64,arm64 signed-by=/usr/share/keyrings/mongodb-server-7.0.gpg ] https://repo.mongodb.org/apt/ubuntu jammy/mongodb-org/7.0 multiverse" | sudo tee /etc/apt/sources.list.d/mongodb-org-7.0.list
sudo apt install -y mongodb-org

Fiftyone work as expected after that

Hi @TvdrBurgt. A MongoDB URI can be configured for systems without a compatible built-in fiftyone-db binary.
If you are able to confirm MongoDB 22.04 works on 24.04 we can add built-in support for Ubuntu 22.04

Like @CourchesneA suggested, you can install MongoDB with a workaround and configure Fiftyone with the database URI. That works like a charm.


fixed routing example description

@TravisCragg-MSFT : Thanks for your contribution! The author, @malopMSFT, has been notified to review your proposed change.

based on #30652

@malopMSFT  Please can you add the "#sign-off" comment if you approve this change. Thanks!

@KumudD: I'm sorry - only the author of this article, @malopMSFT, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.

#sign-off


Insert image dimensions

Thanks for the excellent plugin! How do I get the image dimension declarations in there too? I don't see the value in referencing a sprite sheet w/o also including width and height for the image within the sprite sheet. Am I missing something?

Is there a version bump coming for this one?


Enable ssh Password Authentication when using cloud-init

cloud-init disables password authentication. This PR updates the cloud-init config file at image construction, via the kickstart, to allow password authentication
https://bugzilla.redhat.com/show_bug.cgi?id=1211730

@jrafanie Please review and merge if appropriate.

Looks good, let's see how the nightly build likes it.


[BugFix] Change the statistics table to non-static to prevent CreateAnalyzer from modifying ColumnDef

What type of PR is this：

[x] bug
[ ] feature
[ ] enhancement
[ ] refactor
[ ] others

Which issues of this PR fixes ：

Fixes #9390
Problem Summary(Required) ：

[FE PR Coverage Check]
:heart_eyes: pass : 41 / 42 (97.62%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/statistic/StatisticUtils.java
38
39
97.44%
[191]

:large_blue_circle:
com/starrocks/statistic/StatisticsMetaManager.java
3
3
100.00%
[]

Don't  get why need to change to non-static.

Don't get why need to change to non-static.

Because the actual value of defaultValueDef will be modified in ColumnDef analyze. When using it for the second time, it will check whether the defaultValue is assigned, which will cause the Analysis to fail and the table to fail.

[FE PR Coverage Check]
:heart_eyes: pass : 45 / 46 (97.83%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/statistic/StatisticUtils.java
42
43
97.67%
[196]

:large_blue_circle:
com/starrocks/statistic/StatisticsMetaManager.java
3
3
100.00%
[]

run starrocks_admit_test


Risky testMoveToStream()

PHPUnit marks the following test as risky (no asserts). Could that be removed?
https://github.com/slimphp/Slim/blob/203dd4e768cb0c1cf634e01e2521a95699017c8d/tests/Http/UploadedFilesTest.php#L217

Instead of removing it, we should implement it.

This would be tricky.
Currently the test case uses the stream php://temp. But the documentation states in example 5 of https://www.php.net/manual/en/wrappers.php.php

php://memory and php://temp are not reusable

So we can't use this stream to check if \Slim\Http\UploadedFile::moveTo() worked as expected, can we?
A possible solution would be to write a custom stream wrapper or to use the stream php://output. So for example:
    public function testMoveToStream()
    {
        $uploadedFile = $this->generateNewTmpFile();
        $contents = file_get_contents($uploadedFile->file);

        ob_start();
        $uploadedFile->moveTo('php://output');
        $movedFileContents = ob_get_clean();

        $this->assertEquals($contents, $movedFileContents);
        $this->assertFileNotExists($uploadedFile->file);
    }

Is it okay to use output buffering in a PHPUnit test case?

It's totally fine to use output buffering in a test case. That test looks good to me, not sure why it was never implemented in the first place.

Alright, I will create a pull request.


Pop out player enabled on cold open + certain urls

Open https://open.lbry.com/video-games-influence-us-for-better-or%23ef85b2e7e73a200bc378715f13fae01faea08772?utm_source=subscriptions&utm_medium=email when the app is closed - you'll notice you get a pop out player + thumbnail on file page.
https://open.lbry.com/video-games-influence-us-for-better-or?utm_source=subscriptions&utm_medium=email and https://open.lbry.com/@Lunduke#e/video-games-influence-us-for-better-or#e work

Also affects LBRY.tv: https://beta.lbry.tv/google-s-quantum-computer-beats#91534bbd4106234d165b675d79146aafbcafa974?utm_medium=email&utm_source=newcontent

No longer an issue since the URLs we use have a : and it doesn't break then.


chore(main): release 0.4.0

:robot: I have created a release beep boop
0.4.0 (2024-10-18)
Features

config supports setting mqtt username/password (#23) (73b8388)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

v0.4.0
:sunflower:


CIF-965 - Implement client side cart & checkout for CIF

Clean-up the linting errors: update props validation and remove left-over console.log messages.

Description
Clean-up all the linting errors by updating props and removing console.log messages. We allowed warning and error messages as a very crude form of error reporting.
Related Issue
CIF-965

Motivation and Context

How Has This Been Tested?
npm run lint reports no errors or warnings.

Screenshots (if appropriate):
Types of changes

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[X] I have signed the Adobe Open Source CLA.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[X] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes and the overall coverage did not decrease.
[ ] All unit tests pass on CircleCi.
[ ] I ran all tests locally and they pass.

Codecov Report

Merging #108 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #108   +/-   ##
=========================================
  Coverage     82.63%   82.63%
  Complexity      336      336
=========================================
  Files            38       38
  Lines          1307     1307
  Branches        102      102
=========================================
  Hits           1080     1080
  Misses          158      158
  Partials         69       69

Flag
Coverage Δ
Complexity Δ

#karma
93.61% <ø> (ø)
0 <ø> (ø)
:arrow_down:

#unittests
79.6% <ø> (ø)
336 <ø> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e3f585...472eb0c. Read the comment docs.


ui: show driver camera in popup on demand

The driver camera has been removed from the MainWindow's static layout. It now initializes and displays only when the "Preview Driver View" button is clicked, showing up in a separate popup window.
This change simplifies the MainWindow layout, removes signal/slot chains for the driver view, reduces UI resource usage, and eases migration to Raylib.

This PR was closed because of a git history rewrite.
Please read https://github.com/commaai/openpilot/issues/33399 for what to do with your fork and your PRs.


version 1.1 update

Please include answers to these questions as part of your pull request
In the GitHub webUI, use the Write tab to modify the Markdown text that is part of the pull request. For each question simply place an X inside the square brackets, [X], that represents your answer. Using the Preview tab you can see the formatted/rendered version of the message.

Q1: Confirm that you have the right to submit the code that is being contributed. Please consider the origin of your code and confirm you have the appropriate rights to make the submission subject to the Apache 2.0 license that applies to everything in this repository of custom steps. If so, follow the instructions for the Contributor Agreement (which is based on the industry-standard Developer Certificate of Origin (DCO)).

[X ] Yes, I have the right to submit the contributed code on behalf of myself, my company, or any other owner of the code. I have also attached my signed copy of the DCO to this message.
[ ] No

Q2: Confirm that your contribution does not include any personally identifiable information (PII), for example, in any examples used in your README file.

[X ] My contribution does NOT include PII data
[ ] My contribution includes PII data

Q3: Confirm your contribution does not include any encryption or other export-controlled technology.

[X ] My contribution does NOT contain encryption or other export-controlled technology
[ ] My contribution includes encryption or other export-controlled technology

Contributor-Agreement-MKQueen.txt

This pull request fixes a bug in the Anonymize and Mask Data custom step. It makes the name of the new column to create, a required field in the UI.

SAS Internal Due Diligence Review - COMPLETED on 27SEP2022


Reselect dependency version on selector removal during resolution

As shown in this test, Gradle does not downgrade a version when the selector that caused the upgrade is removed from the graph.
Doing so would improve graph resolution by pruning no longer applicable upgrades.

This problem persists. There are a number of test cases now showing the effect of the issue and how dependency ordering can change the resolution result because of this:
https://github.com/gradle/gradle/blob/219e20add087290b9016a7de382dd5723da316e7/subprojects/dependency-management/src/integTest/groovy/org/gradle/integtests/resolve/VersionConflictResolutionIntegrationTest.groovy#L1548-L1649

Have to clarify if https://github.com/gradle/gradle/pull/6562 can be revived or how else we can fix this.

The fix for this issue is the most likely culprit for #11789 so it will be pulled from Gradle 6.1.
A better fix will be worked on for Gradle 6.2.

Follow up:

Locally revert https://github.com/gradle/gradle/commit/71f39806164a2741d9d95fe6e6b2e4666f2c704c and reproduce issue reported here https://github.com/gradle/gradle/issues/11789#issuecomment-572777215
Test in the making: https://github.com/gradle/gradle/tree/jjohannes/reselection-issue
Once test is ready, find a better solution for the re-selection to fix the problems. Maybe something like queuing the re-selection (in a separate re-selection queue) instead of performing it directly.


Building a static dataset at relaton-data-iso via ISO RSS

Due to the slow retrieval from ISO's site we have to build a static dataset.
The method to build the static dataset is through ISO's RSS feeds.
For each ICS code, they have an RSS feed:

e.g. https://www.iso.org/contents/data/ics/01.rss
There are less than 100 ICS codes, and hence less than 100 URLs to load from.

An ICS RSS feed provides a list of standards like this:
<item>
  <title><![CDATA[ISO/R 860:1968 - International unification of concepts and terms]]></title>
  <link>https://www.iso.org/cms/render/live/en/sites/isoorg/contents/data/standard/00/52/5239.html</link>
  <guid>https://www.iso.org/cms/render/live/en/sites/isoorg/contents/data/standard/00/52/5239.html</guid>
  <description>
    <![CDATA[This document reached stage 95.99 on 1996-06-20, TC/SC: ISO/TC 37, ICS: 01.020]]>
  </description>
  <pubDate>1996-06-20</pubDate>
</item><item>
  <title><![CDATA[ISO/R 1087:1969 - Vocabulary of terminology]]></title>
  <link>https://www.iso.org/cms/render/live/en/sites/isoorg/contents/data/standard/00/55/5590.html</link>
  <guid>https://www.iso.org/cms/render/live/en/sites/isoorg/contents/data/standard/00/55/5590.html</guid>
  <description>
    <![CDATA[This document reached stage 95.99 on 1990-04-01, TC/SC: ISO/TC 37, ICS: 01.020; 01.040.01]]>
  </description>
  <pubDate>1990-04-01</pubDate>
</item>

Steps to retrieve standards

Use the top-level ICS RSS feeds to obtain a full listing of all published standards
For each published standard, parse the individual pages individually for stages and stage dates.

This way we can enumerate all published standards and the latest stages/dates.
Detecting updates
From the daily retrieval of ICS RSS feeds, we can detect if there are any changes to the documents as the RSS feeds provide the latest publication/stage dates. For items that have been updated, we can update using their individual page links.

@ronaldtse I've tried all the codes from 00 to 99
responds = (0..99).map do |n|
  resp = Faraday.get "https://www.iso.org/contents/data/ics/#{n.to_s.rjust(2,'0')}.rss"
  n if resp.status == 200
end

responds.compact
=> [1, 3, 7, 11, 13, 17, 19, 21, 23, 25, 27, 29, 31, 33, 35, 37, 39, 43, 45, 47, 49, 53, 55, 59, 61, 65, 67, 71, 73, 75, 77, 79, 81, 83, 85, 87, 91, 93, 95, 97]

responds.compact.size
=> 40

How do you think, can we use these ICS codes only to obtain the full list of published standards? Or the RSS's responses can vary from time to time?

If ISO publishes in a new category, there will be new codes used. So we need to enumerate from all ICS codes.

@ronaldtse the pubid-iso is unable to convert some ISO identifiers to URN, so I'm going to drop URN in such cases. Is it ok?

@andrew2net then that is a bug in pubid-iso — can you please help list the problematic ones? Thanks.

@ronaldtse I don't think this is a pubid-iso issue. The issue is that some ISO amendments have no edition in their identifiers, and without an edition, there cannot be an amendment URN. https://github.com/metanorma/pubid-iso/issues/102#issuecomment-1250556415
I'll try to ad an edition scraped from the document page.

Thanks for the clarification, by any chance those are “approved but not yet published” documents (60.00)?
Yes without an edition there cannot be a URN according to RFC 5141.

@ronaldtse I got only 6853 documents with the RSS. The iso.org/search.html shows that it has 56147 records. What do you think about it?
BTW I found an issue that slows down the ISO documents fetching significantly. A long time ago I found out that iso.org fails to render documents from time to time. So I added a test if a certain HTML element is exist in the response. If it doesn't then the scraper tries to get it again several times. It worked well until the site template was updated one day. I've updated the HTML element so the relaton-iso works much faster now. I'm, going to implement an error raising in case it will happen again.

@andrew2net according to ISO:

ISO has developed over 24638 International Standards and all are included in the ISO Standards catalogue.

I know they have around ~30,000 deliverables (IS, TR, TS, etc).
It seems that the 56147 records include the staged documents:

  <title><![CDATA[ISO 10096:1997 - Aerospace — Nuts, hexagonal, slotted (castellated), reduced height, reduced across flats, with MJ threads, classifications: 450 MPa (at ambient temperature)/425 degrees C, 600 MPa (at ambient temperature)/235 degrees C, 600 MPa (at ambient temperature)/315 degrees C, 600 MPa (at ambient temperature)/650 degrees C, 900 MPa (at ambient temperature)/235 degrees C, 900 MPa (at ambient temperature)/730 degrees C and 1 100 MPa (at ambient temperature)/600 degrees C — Dimensions]]></title>
  <link>https://www.iso.org/cms/render/live/en/sites/isoorg/contents/data/standard/01/80/18070.html</link>
  <guid>https://www.iso.org/cms/render/live/en/sites/isoorg/contents/data/standard/01/80/18070.html</guid>
  <description>
    <![CDATA[This document reached stage 90.93 on 2021-06-04, TC/SC: ISO/TC 20/SC 4, ICS: 49.030.30]]>
  </description>
  <pubDate>2021-06-04</pubDate>
</item><item>
  <title><![CDATA[ISO/DIS 10096 - Aerospace — Nuts, hexagonal, slotted (castellated), reduced height, reduced across flats, with MJ threads, classifications: 450 MPa (at ambient temperature)/425 degrees C, 600 MPa (at ambient temperature)/235 degrees C, 600 MPa (at ambient temperature)/315 degrees C, 600 MPa (at ambient temperature)/650 degrees C, 900 MPa (at ambient temperature)/235 degrees C, 900 MPa (at ambient temperature)/730 degrees C and 1 100 MPa (at ambient temperature)/600 degrees C — Dimensions]]></title>
  <link>https://www.iso.org/cms/render/live/en/sites/isoorg/contents/data/standard/07/71/77130.html</link>
  <guid>https://www.iso.org/cms/render/live/en/sites/isoorg/contents/data/standard/07/71/77130.html</guid>
  <description>
    <![CDATA[This document reached stage 40.98 on 2021-06-04, TC/SC: ISO/TC 20/SC 4, ICS: 49.030.30]]>
  </description>
  <pubDate>2021-06-04</pubDate>
</item><item>

It looks like the RSS feed has a length limit.
The top-level ICS code RSS feed does not provide the full list of items:

https://www.iso.org/contents/data/ics/49.rss does not contain "ISO 10096:1997"
https://www.iso.org/contents/data/ics/49.030.rss does not contain "ISO 10096:1997"
https://www.iso.org/contents/data/ics/49.030.30.rss does contain it.

$ curl https://www.iso.org/contents/data/ics/01.rss > 01.rss; grep title 01.rss | wc -l
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  106k    0  106k    0     0  54163      0 --:--:--  0:00:02 --:--:-- 54349
     202
$ curl https://www.iso.org/contents/data/ics/03.rss > 03.rss; grep title 03.rss | wc -l
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  109k    0  109k    0     0  27365      0 --:--:--  0:00:04 --:--:-- 27398
     202

The limit seems to be 202.
I wonder if the proper way to do it is to loop through all ICS codes to obtain a list?
Example 1:

1: https://www.iso.org/ics/01/x/
2: https://www.iso.org/ics/01.020/x/ (with deleted and withdrawn: https://www.iso.org/ics/01.020/x/p/1/u/1/w/1/d/1)
NOTE: I don't know if there will be an ICS subgroup that has more then 202 entries, but it seems likely.

Example 2:

1: https://www.iso.org/ics/49/x/
2: https://www.iso.org/ics/49.030/x/
3: https://www.iso.org/ics/49.030.30/x/p/1/u/1/w/1/d/1
NOTE: Notice Example 1 has documents under the 2nd level ICS code, but here we need 3 levels.

Pubid::Iso fails to parse these identifiers:
ISO 1942:1983/Add 1:1983/Add 6:1985
ISO 1942:1983/Add 1:1983
ISO 1942:1983/Add 1:1983/Add 3:1983
ISO 1942:1983/Add 1:1983/Add 2:1983
ISO 1942:1983/Add 1:1983/Add 5:1985
ISO 1942:1983/Add 1:1983/Add 4:1984
ISO 5742:1982/Add 1:1985
ISO/TR 8373:1988/Add 1:1990

@ronaldtse I've tried to fetch all ISO standards from the https://www.iso.org/standards-catalogue/browse-by-ics.html ICS list.
It taked 6 hours and I got 51243 documents. There are some errors and duplications, so the script needs to be implroved.
The only issue is that the ICS pages doesn't provide updated date, so we need to fetch all the documents every time.

Re: updated date. How about this information that comes in the description?
<![CDATA[This document reached stage 50.00 on 2023-01-30, TC/SC: ISO/TC 46/SC 10, ICS: 01.140.20]]>
<!-- ... -->
<![CDATA[This document reached stage 40.99 on 2023-01-28, TC/SC: ISO/TC 321, ICS: 01.040.03; 01.040.35; 03.080.30; 35.240.63]]>

@ronaldtse with parsing the ICS pages we can get only information from document pages that we scrape now. For example https://www.iso.org/standard/18070.html

@ronaldtse I've checked all ICS codes from https://www.iso.org/standards-catalogue/browse-by-ics.html.
There are 750 ICS codes on the browse-by-ics  pages. The RSS service returns it's maximun 200 records for 65 ICS codes.
We can get up to 46417 documents with the RSS channels, but some documents aren't available due to the 200 items limitation.
ICS doc numbers

'01.020': 96
01.040.01: 40
01.040.03: 55
01.040.07: 30
01.040.11: 90
01.040.13: 108
01.040.17: 54
01.040.19: 18
01.040.21: 67
01.040.23: 41
01.040.25: 117
01.040.27: 51
01.040.31: 19
01.040.33: 1
01.040.35: 133
01.040.37: 64
01.040.39: 9
01.040.43: 83
01.040.45: 2
01.040.47: 25
01.040.49: 33
01.040.53: 91
01.040.55: 20
01.040.59: 103
01.040.61: 8
01.040.65: 64
01.040.67: 42
01.040.71: 43
01.040.73: 27
01.040.75: 21
01.040.77: 57
01.040.79: 68
01.040.81: 14
01.040.83: 75
01.040.85: 18
01.040.87: 28
01.040.91: 57
01.040.93: 12
01.040.97: 32
'01.060': 128
'01.070': 38
'01.075': 4
01.080.01: 19
01.080.10: 122
01.080.20: 196
01.080.30: 83
01.080.40: 4
01.080.50: 44
01.080.99: 16
01.100.01: 68
01.100.20: 124
01.100.30: 44
01.100.40: 41
01.100.99: 8
'01.110': 60
'01.120': 79
'01.140': 199
'03.020': 5
'03.060': 150
03.080.01: 11
03.080.10: 11
03.080.20: 5
03.080.30: 115
03.080.99: 41
03.100.01: 159
03.100.02: 13
03.100.10: 2
03.100.20: 6
03.100.30: 194
03.100.40: 18
03.100.70: 187
03.120.10: 113
03.120.20: 131
03.120.30: 200
'03.140': 8
'03.160': 5
'03.180': 20
03.200.01: 19
03.200.10: 8
03.200.99: 31
03.220.01: 200
03.220.20: 200
03.220.30: 4
03.220.40: 2
'03.240': 1
'07.030': 32
'07.040': 5
'07.060': 40
'07.080': 52
'07.100': 200
'07.120': 132
'07.140': 6
'11.020': 37
11.040.01: 77
11.040.10: 200
11.040.20: 168
11.040.25: 139
11.040.30: 18
11.040.40: 200
11.040.50: 3
11.040.55: 49
11.040.60: 6
11.040.70: 200
11.040.99: 29
11.060.01: 52
11.060.10: 200
11.060.15: 23
11.060.20: 200
11.060.25: 20
11.080.01: 126
11.080.10: 14
11.080.30: 15
'11.100': 176
11.120.10: 66
11.120.99: 23
'11.140': 28
'11.160': 1
'11.180': 200
'11.200': 69
13.020.01: 22
13.020.10: 72
13.020.20: 100
13.020.30: 7
13.020.40: 81
13.020.50: 15
13.020.60: 28
13.020.99: 33
13.030.01: 1
13.030.10: 1
13.030.20: 16
13.030.30: 29
13.030.40: 10
13.030.50: 11
13.040.01: 47
13.040.20: 107
13.040.30: 80
13.040.35: 28
13.040.40: 56
13.040.50: 99
13.040.99: 2
'13.060': 200
13.080.01: 42
13.080.05: 59
13.080.10: 93
13.080.20: 64
13.080.30: 88
13.080.40: 14
13.080.99: 9
'13.100': 61
'13.110': 149
'13.120': 2
'13.140': 82
'13.160': 132
'13.180': 200
'13.200': 4
13.220.01: 113
13.220.10: 132
13.220.20: 129
13.220.40: 157
13.220.50: 170
13.220.99: 19
'13.230': 4
'13.240': 31
'13.280': 161
'13.300': 12
'13.310': 17
'13.320': 8
13.340.01: 3
13.340.10: 158
13.340.20: 70
13.340.30: 64
13.340.40: 30
13.340.50: 78
13.340.60: 12
13.340.70: 31
13.340.99: 10
'17.020': 69
17.040.01: 23
17.040.10: 45
17.040.20: 99
17.040.30: 80
17.040.40: 48
'17.060': 79
'17.080': 1
17.120.01: 1
17.120.10: 91
17.120.20: 168
17.140.01: 102
17.140.20: 200
17.140.30: 94
17.140.50: 1
'17.160': 200
17.180.01: 20
17.180.20: 32
17.180.30: 35
17.200.20: 17
'17.240': 200
'19.020': 13
'19.040': 1
'19.060': 3
'19.080': 1
'19.100': 161
'19.120': 106
'21.020': 13
21.040.01: 7
21.040.10: 41
21.040.20: 8
21.040.30: 16
'21.060': 200
21.100.01: 2
21.100.10: 197
21.100.20: 200
21.120.10: 4
21.120.20: 1
21.120.30: 20
21.120.40: 45
'21.140': 9
'21.160': 15
'21.200': 141
21.220.01: 1
21.220.10: 86
21.220.30: 32
'21.240': 2
23.020.30: 7
23.020.35: 200
23.020.40: 49
'23.040': 200
23.060.01: 68
23.060.10: 3
23.060.20: 7
23.060.30: 6
23.060.40: 9
23.060.50: 3
23.060.99: 7
'23.080': 35
23.100.01: 66
23.100.10: 36
23.100.20: 103
23.100.40: 140
23.100.50: 74
23.100.60: 133
23.100.99: 25
'23.120': 93
'23.140': 39
'23.160': 57
'25.030': 65
25.040.01: 70
25.040.10: 21
25.040.20: 71
25.040.30: 57
25.040.40: 200
25.040.99: 1
25.060.01: 2
25.060.10: 21
25.060.20: 127
25.060.99: 13
25.080.01: 65
25.080.10: 12
25.080.20: 36
25.080.30: 9
25.080.40: 11
25.080.50: 25
25.080.99: 2
'25.100': 200
25.120.10: 117
25.120.20: 6
25.120.30: 49
25.120.40: 4
25.140.01: 50
25.140.10: 77
25.140.30: 125
25.160.01: 104
25.160.10: 170
25.160.20: 143
25.160.30: 146
25.160.40: 198
25.160.50: 62
25.180.01: 17
'25.200': 11
25.220.01: 5
25.220.10: 127
25.220.20: 177
25.220.40: 178
25.220.50: 90
25.220.60: 2
25.220.99: 4
'27.010': 11
'27.015': 25
'27.020': 198
'27.040': 48
27.060.10: 14
27.060.20: 31
27.060.30: 23
'27.075': 4
'27.080': 56
'27.100': 6
27.120.01: 12
27.120.10: 23
27.120.20: 32
27.120.30: 119
27.120.99: 1
'27.140': 5
'27.160': 38
'27.180': 6
'27.190': 76
'27.200': 29
'27.220': 22
'29.020': 2
'29.030': 1
29.035.50: 1
29.040.10: 2
29.130.20: 1
29.140.20: 2
29.160.01: 6
29.160.20: 3
29.160.30: 2
29.160.40: 43
29.160.99: 5
'29.180': 10
'29.220': 8
29.240.10: 1
29.260.20: 12
'29.280': 1
'31.020': 2
31.080.01: 6
'31.120': 1
'31.200': 1
'31.260': 103
'33.020': 3
33.040.35: 139
33.040.40: 1
33.050.30: 2
33.100.01: 19
33.100.20: 56
33.120.30: 2
33.160.50: 1
'35.020': 200
'35.030': 200
35.040.01: 1
35.040.10: 135
35.040.30: 196
35.040.40: 200
35.040.50: 200
35.040.99: 15
'35.060': 200
'35.080': 200
'35.100': 200
'35.110': 200
'35.140': 154
'35.160': 36
'35.180': 150
'35.200': 200
'35.210': 38
35.220.01: 3
35.220.10: 8
35.220.20: 22
35.220.21: 48
35.220.22: 31
35.220.23: 44
35.220.30: 122
35.240.01: 12
35.240.10: 19
35.240.15: 200
35.240.20: 200
35.240.30: 200
35.240.40: 110
35.240.50: 76
35.240.60: 200
35.240.63: 77
35.240.67: 70
35.240.68: 1
35.240.70: 169
35.240.80: 200
35.240.90: 79
35.240.99: 154
'35.260': 33
'37.020': 200
37.040.01: 18
37.040.10: 122
37.040.20: 198
37.040.25: 20
37.040.30: 85
37.040.99: 51
'37.060': 200
'37.080': 145
37.100.01: 102
37.100.10: 117
37.100.20: 14
37.100.99: 96
39.040.01: 19
39.040.10: 55
39.040.20: 4
39.040.99: 2
'39.060': 49
'43.020': 200
43.040.01: 9
43.040.10: 200
43.040.15: 200
43.040.20: 38
43.040.30: 34
43.040.40: 135
43.040.50: 63
43.040.60: 31
43.040.65: 33
43.040.70: 59
43.040.80: 77
43.040.99: 4
'43.060': 200
'43.080': 46
'43.100': 68
'43.120': 77
'43.140': 158
'43.150': 75
'43.160': 14
'43.180': 159
'45.020': 24
'45.060': 30
'45.080': 28
47.020.01: 120
47.020.05: 14
47.020.10: 65
47.020.20: 22
47.020.30: 50
47.020.40: 28
47.020.50: 112
47.020.60: 8
47.020.70: 95
47.020.80: 11
47.020.85: 1
47.020.90: 22
47.020.99: 122
'47.040': 38
'47.060': 67
'47.080': 200
'49.020': 143
49.025.01: 14
49.025.20: 1
49.030.01: 4
49.030.10: 21
49.030.20: 59
49.030.30: 69
49.030.50: 5
49.030.60: 19
49.030.99: 10
'49.035': 63
'49.040': 10
'49.045': 2
'49.050': 4
'49.060': 198
'49.080': 168
'49.090': 10
'49.095': 1
'49.100': 128
'49.120': 43
'49.140': 200
53.020.01: 6
53.020.20: 188
53.020.30: 60
53.020.99: 16
'53.040': 200
'53.060': 177
'53.080': 3
'53.100': 200
'55.020': 94
'55.040': 2
'55.080': 21
'55.100': 75
'55.120': 35
'55.130': 4
'55.140': 9
55.180.01: 9
55.180.10: 121
55.180.20: 42
55.180.30: 35
55.180.40: 42
55.180.99: 4
'59.020': 5
'59.060': 149
59.080.01: 200
59.080.20: 28
59.080.30: 153
59.080.40: 96
59.080.50: 60
59.080.70: 95
59.100.01: 17
59.100.10: 81
59.100.20: 17
'59.120': 200
59.140.01: 1
59.140.20: 20
59.140.30: 200
59.140.99: 2
'61.020': 45
'61.040': 2
'61.060': 150
'61.080': 9
65.020.01: 6
65.020.20: 16
65.020.30: 16
65.040.10: 15
65.040.20: 3
65.040.99: 18
'65.060': 200
'65.080': 82
65.100.01: 32
'65.120': 80
'65.140': 3
'65.145': 2
'65.150': 22
'65.160': 197
'67.020': 30
'67.040': 10
'67.050': 71
'67.060': 154
67.080.01: 66
67.080.10: 57
67.080.20: 39
67.100.01: 96
67.100.10: 145
67.100.20: 21
67.100.30: 55
67.100.40: 7
67.100.99: 34
67.120.10: 40
67.120.20: 1
67.120.30: 10
67.140.10: 53
67.140.20: 46
67.140.30: 11
67.160.20: 5
67.180.10: 1
67.180.20: 32
'67.190': 3
67.200.10: 194
67.200.20: 74
67.220.10: 126
67.220.20: 17
'67.240': 85
'67.250': 31
'67.260': 29
'71.020': 8
71.040.10: 6
71.040.20: 60
71.040.30: 42
71.040.40: 200
71.040.50: 28
71.040.99: 21
'71.060': 200
71.080.10: 27
71.080.15: 15
71.080.20: 27
71.080.30: 19
71.080.40: 43
71.080.50: 19
71.080.60: 62
71.080.70: 15
71.080.80: 32
71.080.90: 16
71.100.01: 2
71.100.10: 132
71.100.20: 74
71.100.30: 27
71.100.40: 122
71.100.45: 8
71.100.50: 1
71.100.60: 200
71.100.70: 34
71.120.30: 1
71.120.99: 14
'73.020': 32
'73.040': 191
'73.060': 200
'73.080': 53
73.100.30: 36
73.100.40: 18
73.100.99: 1
'73.120': 32
'75.020': 59
'75.040': 8
'75.060': 118
'75.080': 192
'75.100': 120
'75.120': 49
'75.140': 7
75.160.10: 130
75.160.20: 99
75.160.30: 27
75.160.40: 85
75.180.01: 32
75.180.10: 200
75.180.20: 67
75.180.30: 99
'75.200': 200
'77.020': 3
77.040.10: 200
77.040.20: 77
77.040.30: 2
77.040.99: 52
'77.080': 157
'77.100': 59
77.120.01: 5
77.120.10: 38
77.120.20: 42
77.120.30: 40
77.120.40: 51
77.120.50: 12
77.120.60: 34
'77.140': 200
77.150.01: 11
77.150.10: 90
77.150.20: 11
77.150.30: 52
77.150.40: 10
77.150.50: 3
77.150.60: 2
'77.160': 170
'77.180': 9
'79.020': 5
'79.040': 87
79.060.01: 35
79.060.10: 32
79.060.20: 29
79.060.99: 8
'79.080': 28
'79.100': 124
79.120.10: 72
79.120.20: 9
81.040.01: 36
81.040.10: 14
81.040.20: 92
81.040.30: 37
81.060.01: 5
81.060.10: 2
81.060.20: 9
81.060.30: 193
'81.080': 118
'83.020': 2
83.040.01: 6
83.040.10: 200
83.040.20: 138
83.040.30: 10
'83.060': 200
'83.080': 200
'83.100': 136
'83.120': 116
'83.140': 200
83.160.01: 66
83.160.10: 91
83.160.20: 11
83.160.30: 51
83.160.99: 30
'83.180': 151
'83.200': 14
'85.020': 7
'85.040': 200
'85.060': 200
'85.080': 57
'85.100': 3
'87.020': 24
'87.040': 200
87.060.01: 4
87.060.10: 160
87.060.20: 78
87.060.30: 5
87.060.99: 6
'87.080': 43
'87.100': 4
91.010.01: 35
91.010.20: 20
91.010.30: 19
91.040.01: 131
91.040.10: 16
91.060.01: 12
91.060.10: 13
91.060.20: 5
91.060.30: 17
91.060.40: 1
91.060.50: 65
91.060.99: 5
91.080.01: 59
91.080.10: 3
91.080.13: 8
91.080.20: 65
91.080.30: 3
91.080.40: 90
'91.090': 2
91.100.01: 18
91.100.10: 48
91.100.23: 66
91.100.30: 90
91.100.40: 55
91.100.50: 83
91.100.60: 110
91.120.10: 138
91.120.20: 125
91.120.25: 33
91.140.01: 14
91.140.10: 1
91.140.30: 62
91.140.40: 14
91.140.60: 200
91.140.70: 2
91.140.80: 102
91.140.90: 97
91.160.01: 3
91.160.10: 12
'91.200': 28
'91.220': 40
'93.010': 17
'93.020': 102
'93.025': 66
'93.030': 60
'93.040': 12
'93.060': 4
93.080.10: 28
93.080.20: 13
93.080.30: 6
'93.100': 1
'95.020': 10
'97.020': 12
97.040.01: 5
97.040.10: 1
97.040.20: 9
97.040.30: 17
97.040.40: 5
97.040.60: 32
'97.060': 32
97.100.01: 5
97.100.30: 1
97.100.99: 8
'97.120': 1
97.130.20: 23
'97.140': 76
'97.150': 162
'97.160': 6
'97.170': 30
'97.180': 35
'97.190': 13
'97.195': 1
97.200.10: 3
97.200.30: 26
97.200.40: 10
97.200.50: 44
97.200.99: 3
97.220.01: 18
97.220.10: 16
97.220.20: 146
97.220.30: 31
97.220.40: 24
97.220.99: 2

Thank you @andrew2net for the experimentation. It is unfortunate that we cannot obtain all the documents via RSS, which is much faster and presents less load on iso.org.
What is the alternative to obtain the index of all documents? Does Algolia provide some options here?

@ronaldtse I don't see any other way but scrape all the pages https://www.iso.org/standards-catalogue/browse-by-ics.html
It may take too much time to parse all the documents. However, I think we can get all the documents from ICS once and then use RSS to update our dataset. What do you think?

@andrew2net I agree, let's:

Scrape all pages of https://www.iso.org/standards-catalogue/browse-by-ics.html
Scrape all documents via RSS links.

Thanks!

@ronaldtse there is a document with ISO/CIE TR 21783:2022 | ISO/CIE TR 21783 ID. Guess we should use just ISO/CIE TR 21783:2022, right?

ISO/CIE TR 21783:2022 | ISO/CIE TR 21783 ID. Guess we should use just ISO/CIE TR 21783:2022, right?

I believe so. However this is an ISO problem, we should report it.

I believe so. However this is an ISO problem, we should report it.

I didn't mean we should report the problem. It concerns what we should store in our dataset.

I believe so. However this is an ISO problem, we should report it.

I didn't mean we should report the problem. It concerns what we should store in our dataset.

I agree with your proposed solution, but I’m hesitant to make a single hard coded exception… any other issues you’ve found?

I agree with your proposed solution, but I’m hesitant to make a single hard coded exception… any other issues you’ve found?

@ronaldtse I've tried to fetch only 10k docs of 60k. We'll see all issues in GHA log. For now:

There are a couple docs ISO/DATA 3:1977 and ISO/DATA 1:1978 with IDs that Pubid::Iso unable to parse.
There are deleted documents like ISO/CD 19135 and ISO/CD 19135. Meanwhile there is a document with an identical ID ISO/CD 19135 which is under development. Do we need to keep the deleted documents? If yes then we need to distinct their IDs somehow.
There are withdrawn docs with identical IDs, for example ISO/IEC 17344:2005 and ISO/IEC 17344:2005. Do we need to keep these docs? If yes then we need to distinct their IDs somehow.
There IEC documents here. For ISO we use doctype international-standard by default. What default doctype should we use for IEC?
There is a doc ISO/IEC ISP 15126-2:1999 with ISP type abbreviation, but it seems we don't have such kind of type in the Relaton model.

agree with your proposed solution, but I’m hesitant to make a single hard coded exception… any other issues you’ve found?

@ronaldtse I have only parsed 10k of 60k docs. For now I found:

There are docs with DATA type like ISO/DATA 3:1977 that Pubid::Iso unable to parse. I'll create a ticket for @mico.
There are wiwdrawn docs with identical IDs, for example https://www.iso.org/standard/50371.html and https://www.iso.org/standard/54006.html. How shole we handle these duplications?
There are IEC docs, for example IEC/IEEE 80005-1:2019. For ISO docs we use default doctype international-standard. Should we use the default doctype for IEC docs?

@ronaldtse I haven't parsed all the ISO documents yet, only 10k of about 60k. For now, the issues are:

We use a default doctype international-standard for ISO docs, but there are IEC docs like IEC/IEEE 80005-1:2019. Should we use the same default doctype for the IEC docs?
There are ISO/DATA docs like ISO/DATA 3:1977 that Pubi::Iso fails to parse. I'll create an issue for @mico
There are duplicated IDs like ISO/IEC 8825-6:2008. How should we handle them?

Default document type: yes.
DATA document types. Yes we can fix them later.
Duplicated IDs. This instance is when the project was cancelled and then re-started, which was then withdrawn. I think for “status: deleted” items we just ignore them for now.

@ronaldtse in the static dataset there are docs with ISO/IEC DIR relation. The Pubi::Iso fails to parse ISO/IEC DIR ID and there isn't ISO/IEC DIR doc in the dataset. Is the relation correct? If the relation correct then we need to fix Pubid::Iso.

The Pubi::Iso fails to parse ISO/IEC DIR ID and there isn't ISO/IEC DIR doc in the dataset. Is the relation correct? If the relation correct then we need to fix Pubid::Iso.

In this case let's remove the ISO/IEC DIR relation, because ISO/IEC DIR is analogous to ISO/IEC TR which doesn't quite make sense as a citation target.

@ronaldtse At least one document isn't listed on the ICS pages https://www.iso.org/standard/77374.html
The doc has deleted status, so I think we can ignore it, right?

@andrew2net I think we can ignore it, but it does contain ICS:

@ronaldtse yes, it contains ICS. I've opened the 43.020 and 17.140.30 ICS pages and didn't find the doc there, so we are unable to get the doc from the ICS pages.

@andrew2net then probably because it was out of range. There is a page limit for ICS pages, right?
In any case, we probably should keep a list of all the project numbers (the 5-digit IDs) because ISO does not re-use them.

@ronaldtse we can extract all the project numbers that we have in the relaton-data-iso repo from index

@andrew2net then probably because it was out of range. There is a page limit for ICS pages, right?

@ronaldtse I don't think there is a page limit. The page 43.020 has 220 docs, but 17.140.30 has only 92.

Then is the problem because this project was "deleted" that's why it's not shown in the ICS pages?

implemented in v1.18.2


ci: add windows/macos to clippy to reproduce compilation error on windows

this PR adds windows and macos to the clippy job to reproduce the compilation failure in #186
also fixes some clippy warns/errs

I will remove the clippy commit

closing for https://github.com/BlockstreamResearch/simplicity/pull/211

Is it worth having this change in CI to check macos/windows compilation?

rebased

Depends on #191. Let's merge this PR once CI runs.

@delta1 Feel free to rebase

@uncomputable rebased. windows ci failure is fixed upstream and in #192

Let's rebase on top of the merged #192 to fix CI.

@uncomputable done. macos failure looks spurious

@uncomputable this crate currently doesn't build with the elements feature and apparently our CI doesn't check this. It was broken in #189.
I can't run my local CI, or even cargo test, until this is fixed.

@apoelstra I thought our CI would catch this, but apparently it doesn't. master doesn't build on my machine :/
Fix master in a separate PR.


UUID format error when connecting

Hi,
When I try to make a nYnabClient object I get a failure here:
https://github.com/rienafairefr/nYNABapi/blob/master/pynYNAB/schema/Entity.py#L230
ValueError: badly formed hexadecimal UUID string
entityDict = {
    u'entities_scheduled_transaction_id': u'7d5d35d1-00b8-7630-fb4c-2c4f50bd4633',
    u'imported_date': None,
    u'credit_amount': 0,
    u'cleared': u'Uncleared',
    u'transfer_transaction_id': None,
    u'id': u'7d5d35d1-00b8-7630-fb4c-2c4f50bd4633_2016-11-03',
    u'entities_account_id': u'ac962d11-e408-e5f3-13e3-2c4f4ffa2e70',
    u'imported_payee': None,
    u'transfer_subtransaction_id': None,
    u'entities_subcategory_id': None,
    u'subcategory_credit_amount_preceding': None,
    u'source': u'Scheduler',
    u'date_entered_from_schedule': u'2016-11-03',
    u'memo': u'DMC14',
    u'flag': None,
    u'is_tombstone': True,
    u'date': u'2016-11-03',
    u'entities_payee_id': u'c620cba5-2794-60c6-5d3e-2c4f5008f48d',
    u'accepted': True,
    u'check_number': None,
    u'cash_amount': 0,
    u'transfer_account_id': None,
    u'amount': 3600000,
    u'matched_transaction_id': None,
    u'ynab_id': None
}

column.name = 'id'

# so it's trying to do this
UUID("7d5d35d1-00b8-7630-fb4c-2c4f50bd4633_2016-11-03".split('/')[-1])

I'll try to fix myself but might take me a while. Any ideas...?!
I found the transaction itself and it's actually on 2016-11-08. From the blob above looks like it was a scheduled transaction..? If I take the date off the end of the id then UUID doesn't fail

Hmm,
looks like ids for the api are a mess ! Sometimes it's standard
7d5d35d1-00b8-7630-fb4c-2c4f50bd463
Sometimes
bla/foo/7d5d35d1-00b8-7630-fb4c-2c4f50bd463
Sometimes
dcdfd/7d5d35d1-00b8-7630-fb4c-2c4f50bd463
Apparently also sometimes
7d5d35d1-00b8-7630-fb4c-2c4f50bd463_YYY-MM-DD,
I think I'll switch to a regex like
[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}
Thanks for the bug report!

Yeah looks all over the place! Nothing like an inconsistent id.
I'll test again whenever you get to make the change 😎
Also good work with this lib!
On Thu, 19 Jan 2017, 12:04 rienafairefr<EMAIL_ADDRESS>wrote:

Hmm,
looks like ids for the api are a mess ! Sometimes it's standard
7d5d35d1-00b8-7630-fb4c-2c4f50bd463
Sometimes
bla/foo/7d5d35d1-00b8-7630-fb4c-2c4f50bd463
Sometimes
dcdfd/7d5d35d1-00b8-7630-fb4c-2c4f50bd463
Apparently also sometimes
7d5d35d1-00b8-7630-fb4c-2c4f50bd463_YYY-MM-DD,
I think I'll switch to a regex like
[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}
Thanks for the bug report!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/rienafairefr/nYNABapi/issues/27#issuecomment-273759811,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAOkRvW2Rm-qUbwoETWectFWm93k2YAEks5rT1FVgaJpZM4Lnawn
.

827be01fb19fd1e4e2357bd65309302d4e7e78ee seems to solve the problem, test it with your data and see how it goes :-)
Cheers

That error is fixed yes... but now there is something else :'(
I'll make an issue for the other one. Something to do with dates now.


NameError: 'DplyFrame' is not defined

I'm a recent Python convert from R, so this is great to see.  I have what could be a simple file I/O error when I run your example, but not sure:
/anaconda/bin/python /Users/myusername/code/dplyr_example1.py Traceback (most recent call last):   File "/Users/myusername/code/dplyr_example1.py", line 1, in <module>     from dplython import *   File "/anaconda/lib/python3.4/site-packages/dplython/__init__.py", line 4, in <module>     diamonds = DplyFrame(diamonds) NameError: name 'DplyFrame' is not defined
Any ideas what's wrong?

This could be a few things: 1) an issue with anaconda, 2) caused by using
python 3 (this is unfortunately only python 2 compatible right now) or 3)
something else.
If you can try this outside of anaconda and with python 2.7, that'd be a
help! If it's still broken I'll have some more debugging to do.
On Mon, Mar 21, 2016, 11:52 PM BarcaDad<EMAIL_ADDRESS>wrote:

I'm a recent Python convert from R, so this is great to see. I have what
could be a simple file I/O error when I run your example, but not sure:
/anaconda/bin/python /Users/myusername/code/dplyr_example1.py
Traceback (most recent call last):
File "/Users/myusername/code/dplyr_example1.py", line 1, in
from dplython import *
File "/anaconda/lib/python3.4/site-packages/dplython/init.py", line 4,
in
diamonds = DplyFrame(diamonds)
NameError: name 'DplyFrame' is not defined
Any ideas what's wrong?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
https://github.com/dodger487/dplython/issues/1

The issue caused by using python 3 (due to implicit relative import in the code, which is not allowed in python 3). It was fixed in e751ae1f41762e93bcb1e237f0f9633048eb448b, and overall python 3 compatibility was added in b2229250a08668f63762079cc503f0b6a284e8a5. Please reinstall and try again.

It sounds like this issue most likely fixed with the Python 3 compatibility upgrade. @barcadad, can you take a look in the next few days and close this if so?


Warning running server

Hi
I've installed the latest and generated the project with sequalize (no mongodb). When I run server I get this warning. I can't figure out why. There is no new code on my side. Just the generated scaffold.
GET /api/things 304 9.731 ms - -
Warning: a promise was created in a handler but was not returned from it
at executeSql (/Users/speedingdeer/code/lucy/node_modules/sequelize/lib/dialects/sqlite/query.js:96:19)
From previous event:
at Promise.then (/Users/speedingdeer/code/lucy/node_modules/sequelize/lib/promise.js:21:17)
at Database. (/Users/speedingdeer/code/lucy/node_modules/sequelize/lib/dialects/sqlite/query.js:258:14)
at /Users/speedingdeer/code/lucy/node_modules/sequelize/lib/dialects/sqlite/query.js:91:19
From previous event:
at [object Object].Query.run (/Users/speedingdeer/code/lucy/node_modules/sequelize/lib/dialects/sqlite/query.js:89:13)
at /Users/speedingdeer/code/lucy/node_modules/sequelize/lib/sequelize.js:798:18
From previous event:
at Promise.then (/Users/speedingdeer/code/lucy/node_modules/sequelize/lib/promise.js:21:17)
at [object Object].Model.findAll (/Users/speedingdeer/code/lucy/node_modules/sequelize/lib/model.js:1369:6)
at [object Object].Model.findOne (/Users/speedingdeer/code/lucy/node_modules/sequelize/lib/model.js:1490:34)
at E4Store.get (/Users/speedingdeer/code/lucy/node_modules/express-sequelize-session/lib/e4store.js:51:29)
at session (/Users/speedingdeer/code/lucy/node_modules/express-session/index.js:408:11)
at Layer.handle [as handle_request] (/Users/speedingdeer/code/lucy/node_modules/express/lib/router/layer.js:95:5)
at trim_prefix (/Users/speedingdeer/code/lucy/node_modules/express/lib/router/index.js:312:13)
at /Users/speedingdeer/code/lucy/node_modules/express/lib/router/index.js:280:7
at Function.process_params (/Users/speedingdeer/code/lucy/node_modules/express/lib/router/index.js:330:12)
at next (/Users/speedingdeer/code/lucy/node_modules/express/lib/router/index.js:271:10)
at initialize (/Users/speedingdeer/code/lucy/node_modules/passport/lib/middleware/initialize.js:53:5)
at Layer.handle [as handle_request] (/Users/speedingdeer/code/lucy/node_modules/express/lib/router/layer.js:95:5)
at trim_prefix (/Users/speedingdeer/code/lucy/node_modules/express/lib/router/index.js:312:13)
at /Users/speedingdeer/code/lucy/node_modules/express/lib/router/index.js:280:7
at Function.process_params (/Users/speedingdeer/code/lucy/node_modules/express/lib/router/index.js:330:12)
at next (/Users/speedingdeer/code/lucy/node_modules/express/lib/router/index.js:271:10)
at cookieParser (/Users/speedingdeer/code/lucy/node_modules/cookie-parser/index.js:68:5)
at Layer.handle [as handle_request] (/Users/speedingdeer/code/lucy/node_modules/express/lib/router/layer.js:95:5)
at trim_prefix (/Users/speedingdeer/code/lucy/node_modules/express/lib/router/index.js:312:13)

Hi, same issue.

@mickhansen please advise. Why do you need the new Promise here? https://github.com/sequelize/sequelize/blob/master/lib/dialects/sqlite/query.js#L96
Nesting new Promise is almost never a great idea in my opinion but I'm not sure I understand the use case very well.

Here for example:
https://github.com/sequelize/sequelize/blob/master/lib/dialects/sqlite/query.js#L252-L265
Couldn't it be an array map?

new Promise is not strictly, i don't recall the conversion exactly but we simply wanted to get away from event emitter quickly.
Ideally the code should be promisified yes. Why would new Promise trigger the return handler warning though?

I'm not sure - @petkaantonov  ?

The warning is triggered by being in a handler and not returning anything while at the same time a promise is created anywhere in same turn

Hm alright, i'll have to test out changing stuff to promisification.
Eitherway this issue should be closed, not a bluebird issue.


chore(deps): remove ignored packages

:tada: This PR is included in version 1.8.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Send mail in Command

Hi,
I want to send an email within a Command, and it doesn't seem to work.
Don't know why.
Did I miss something ?
It works perfectly in a controller.
Thanks.

we can't help you if you don't provide code lines, errors, logs, ...

I have no error.
Here's my code, nothing special:
$em = $this->getContainer()->get('doctrine')->getManager();
$contactsAmount = $em->getRepository('ContactUsBundle:Contact')->getTodaysContactsAmount();
$ordersInformation = $em->getRepository('ShopBundle:SalesOrder')->getOrdersInformation();

$currentDate = new \DateTime('now');

$message = (new \Swift_Message('[Web] Statistiques du '.$currentDate->format('d/m/Y')))
	->setFrom($this->getContainer()->getParameter('mailer_sender'))
<EMAIL_ADDRESS>	->setBody($this->getContainer()->get('templating')->render('AppBundle:Emails:stats.html.twig', array(
		'contactsAmount' => $contactsAmount,
		'ordersInformation' => $ordersInformation
	)), 'text/html');

$emailsSent = $this->getContainer()->get('mailer')->send($message);

$output->writeln($emailsSent.' emails envoyés');

$emailsSent returns 0

verify the symfony env you use when you send your command, also check your spool configuration

When I use this command :
php bin/console stats:send
It seems that it is launched in the dev env.
My config for dev env is :
swiftmailer:
    disable_delivery: true

And $emailsSent returns 1.
But when I use this command :
php bin/console stats:send --env=prod
And $emailsSent returns 0.
My config is:
swiftmailer:
    transport: mailjet

So no spool is configured.

put some var_dump everywhere, it can be a problem with your payload and Mailjet API reject your request that's why it failed.

OK I removed a try...catch in the bundle.
And it gives me an error that I don't have when I send an email in a controller:
In CurlFactory.php line 187:
  cURL error 60: SSL certificate problem: unable to get local issuer certificate (see: http://curl.haxx.se/libcurl/c/libcurl-errors.html)

I tried to update my cacert.pem with no result.

You are on Windows environment? it's a common issue, ask Google for it:

https://stackoverflow.com/questions/21114371/php-curl-error-code-60
https://stackoverflow.com/questions/24611640/curl-60-ssl-certificate-unable-to-get-local-issuer-certificate
https://sdujancourt.me/2017/02/28/windows-php-curl-error-60-ssl-certificate-problem-unable-to-get-local-issuer-certificate/

But I think we could catch runtime error (other than API error) and throw them in order to get error when there is actual error (like here).


No debug adapter found on termination of the debug session after update 1.42

When trying to stop an already started debug session of DAP the session is stopped normally, also there are no errors reported in the debug console, but an error message is popping up in "no debug adapter found". This started directly after the VSCode updated to v. 1.42

VSCode Version: 1.42
OS Version: Win 10

Steps to Reproduce:

Start a debug session
Stop the debug session

Does this issue occur when all extensions are disabled?: Yes

/needsMoreInfo including what language you are debugging, and what extensions you are using.

I updated the description, hoping it will suffice.

The problem appears when we are trying to terminate the debug session. We first use the "exited" method with the expected ExitedEventArguments and directly after that, the "terminated" method with the expected TerminatedEventArguments. The error comes from the terminated method. I repeat that the problem appeared directly when the version of VSCode was updated to 1.42. By the way this problem doesn't appear on Theia.

@isidorn please investigate

Let's close as duplicate of https://github.com/microsoft/vscode/issues/89658
And continue the investigation there


[WIP] Memory machine: Assert that the first memory access is a bootloader write

Also done in https://github.com/powdr-labs/powdr/pull/1599


Allow OP to mark comment as spoiler

This is particularly for games-posts, it happens that people possibly inadvertently spoils the entire game. In the example that triggered this issue (https://ldjam.com/events/ludum-dare/44/utsvulten) the spoiler is in the form of an image.
Problems

The spoiler mark down, doesn't work with hiding images.
The chance that the one can manage to get a hold of the one who spoiled to fix the issue is extremely slight.
Spoiler markdown (!>) isn't documented anywhere. https://ldjam.com/markdown should explain it since it is not part of standard github markdown.

Solution
The author of the post may flag a comment as spoiler, this will add an overlay over the entire post that needs clicking to view.
After author marked a comment as spolier, it could look something like this:

(Keep space of comment, but have minimum space needed for spoils text)
The author could have a 🏴 icon next to the heart icons on all comments that would popup a dialogue asking if the author is sure they want to flag the comment as spoiling.
My idea is that spoiling is a property of the comment sent with the comment. No filtering is done by the API on getting comments. This is only a display property client-side. The post request from the author to set or unset the spoiler flag is of course authenticated against being the author of the original post.
Misuse
Someone might find it fun to flag non-spoiling comments as spoiling, but the data is still sent to the user and visible after clicking.
Further thoughts
This could of course be extended to not only flag something as spoiling, but also adult, abusive and so on, but those might be more sensitive areas whereas spoiling should be rather benign.

Good idea. :+1:

@mikekasprzak you implied before that after this LD you'd have more time again so we could perhaps deal with the old PRs and then work on this one? If probably need help with the backend API changes that would be needed.

Yeah I have some personal stuff to take care of over the next couple
weekends, but yes I'd like to start getting some momentum on the website
going again. I'll have more to say soon, but I'd like to do a bit of a
postmortem of what does and doesn't work well about the website, the
codebase, and so on, and get your and everyone else feedback. This past
year I've done a lot of work with scalable servers, and I want to do a
better job here, but that's topic all its own.
On Tue, 30 Apr 2019 at 04:02, Martin Zackrisson<EMAIL_ADDRESS>wrote:

@mikekasprzak https://github.com/mikekasprzak you implied before that
after this LD you'd have more time again so we could perhaps deal with the
old PRs and then work on this one? If probably need help with the backend
API changes that would be needed.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ludumdare/ludumdare/issues/1801#issuecomment-487854405,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAL7MCMV7CCR6LIJOKYIACLPS74JRANCNFSM4HJC4BFA
.

For pt3 above, I guess it's an update needed in the database text for that special page or? I had to teach another participant today the !>.
For getting started again on site-dev, perhaps it be good do a discord voice meeting or similar to sort out what we all need and want.


Helm upgrade does not recreate pod with latest image even if imagePullPolicy is set to Always

It seems that helm upgrade will roll out changes to kubernetes objects only if there are changes to roll out. i.e when the object is changed in the helm chart files. It will not recreate the pods just because the image is update. To be able to recreate the pod you will need to update the chart and specify some tag to the image in the chart which refers to the latest image and the tag should be new every time.
While this can be done there is one maintenance headache with this approach. We will need to update our charts every time the new image is created.
There is an alternative though. We can provide a dynamic label to the pod deployment metadata (something like timestamp) which will be new every time and will cause helm to recreate the pod because the pod object is different than previous.
Reference: https://stackoverflow.com/a/71016950/814548

Done


Added portfolio website

A portfolio website made using HTML , CSS and js.
closes #233

Please merge @pranjay-poddar


All of Trino's select statements about tidb cannot be used

My Trino version is 391

The interface of the select method was modified in 391, so it is impossible to query. I modified the source code to solve this problem


Fix common voice

This PR contains #1070 and deprecates the url/download arguments and add language argument.

[Cherry-picked from #1070] Revert #1018
[Cherry-picked from #1070] Disallow download=True
Add deprecation warnings to download and url arguments
Add language argument to replace url.

Closing as #1070 has been significantly changed and will be followed up according #1077


removed warnings on Linux and Mac

Hi @dnbaker and thank you for this great library!
Consider this little fix that avoids warnings on both Linux and Mac.
Best,
-Giulio

Hey @dnbaker, any chance to merge this?
Please, let me know.
Cheers,
-Giulio

Hi Giulio,
Thanks for the PR! Sorry, I've been at bandwidth lately but I appreciate the fixes.
I'll merge it in.
Best,
Daniel

Hi Daniel,
no worries -- I understand being buys :)
Thanks for the merge.
Best,
-Giulio


deprecate the C API

Reasons:

We are spread too thin between the Python and C APIs. This is slowing down development and features, like being able to use fastpt or adjust integration parameters. Most CCL developers don't have a ton of time.

We don't gain that much from the C API in terms of speed. Most of our code is passing data into C and then letting the C code do its thing. We don't need a C API to do this.

We loose too much in terms of being able to catch and handle errors, especially when using the library from Python. This is imperative for long running computations.

Centralizing to a single interface for CCL will let us simplify documentation, tests, tutorials, etc.

I agree with this, but it's a pretty major shift so of course we need a proper discussion about it and a final decision from the project lead, which I think is @elisachisari .

Turns out GitHub issues are a great place to discuss things. ;p

Absolutely; just encouraging everyone to contribute.

@beckermr What would "deprecating C" look like in terms of refactoring the code? Are you thinking of an "on paper" deprecation, where we just release ourselves from certain obligations (like keeping C <-> Python feature parity), or are you thinking of fundamentally changing the way certain things are done (like error handling)?

A bit of both. First it would be "on paper." Then as we develop the code it would get more serious.

I like the idea of dropping the requirement on feature parity -- if a feature is much easier to implement in Python than in C, then C is probably not the right tool for the downstream applications neither.
I would still suggest some informal separation between the very low level routines in C and the higher level logic, which can be implemented either via Python C-API, or python.

Here are some things we could do as part of a phased deprecation (just ideas):

Remove C<->Python feature parity requirement. All C features must be present in the Python API, but not all Python features need to be available through C.
Remove unnecessary bits of user-facing C API (e.g. multiple ways of constructing ccl_cosmology objects)
Convert all precision validation tests to Python-only
Remove C unit tests (Python only)
Simplify INSTALL and CONTRIBUTORS files (and other docs) to relax C-related requirements
Simplify C code examples (but do not remove yet)

Y’all are way overthinking this.

Deprecating the public C API doesn’t mean we can’t have internal APIs. In fact we should have those. It simply means we are free to change those as we see fit with no warning.

We don’t have to fully move every example or benchmark to python right now.

We don’t have to refactor existing code. All of this kind of work can be done in the future.

All we have to do now is mark it deprecated in hr changelog and update the main documentation to indicate python as the only user interface.

@beckermr I agree, but the point is to highlight the implications of this decision for what might change in the future as a result.

Definitely no need to remove unit tests in the C code if we deprecate.  Regression tests maybe, but not unit tests, those would still be useful.

Yup. Tests of the c code make a lot of sense in some cases though we could be hitting the same code paths with a test from python.
My point here @philbull is that we don’t actually have to do most of the things on that list. Marking the C api as deprecated is simply letting other people know that we are not maintaining it for anyone but ourselves for use inside CCL.
There are probably good reasons to not move a lot of code from C to python.

Cross-reference with previous discussion with #227. (I don't think we needed both open at this point though)

Whoops. Thanks for fixing!


Add missing camera f/w for COROLLA_TSS2

Discord: Crazy Poor Asian#5858 / 2021 Toyota Corolla
3b36d4053d4641dd|2021-03-12--19-37-59

Oh my, this was already done.

I edited the fingerprint page on the wiki to suggest possibly trying master first. 😓


Saving a trained model

How to save the model after training it with PaDim on our custom dataset

If you use the default config with the custom dataset, the model should be saved in the ./results/padim/name_of_custom_dataset/run/weights/model.ckpt.


Handling failed runs

I'm doing something where I'm running N spawn to see if a command is available in an environment. I want to collect results of only those spawned processes that return an exit code of 0. I don't want to let the error bubble up, so I end up doing the whole catch -> Observable.empty thing.
function ipyKernelCheck(env) {
  const executable = path.join(env.prefix, 'bin', 'python');
  return spawn(executable, ['-m', 'ipykernel', '--version'], { split: true })
    .filter(x => x.source && x.source === 'stdout')
    .mapTo(env)
    .catch(err => Rx.Observable.empty());
}

If I could use the return code and squash the error I could. Should I fix something with my approach here or is there something worth exposing in spawn-rx?

If you wanted to aggregate it you could do something like:
commandsToExecute
  .map({cmd, params} => spawn(cmd, params)
    .reduce((acc,x) => acc += x, '')
    .catch(() => Observable.empty())
  .mergeAll(4 /* at a time */);


fix: filepath.Clean

I think this might help with https://github.com/goreleaser/goreleaser/discussions/1935

LGTM, but would the CI actually run successfully if it wasn't for the golangci-lint issues? We should also just run the basic (non-acceptance) tests in Windows (and maybe macOS) CI workers.

superseeded by #12


Python Wheels for Python 3.11 and 3.12 are missing

See https://pypi.org/project/breez-sdk-lib/#files
There are only wheels for Python 3.8, 3.9 and 3.10.
Please make wheels for Python 3.11 and 3.12 available too. Always make sure you submit wheels for all supported Python versions.

ISTM all you need to change is this line:
https://github.com/breez/breez-sdk/blob/main/.github/workflows/publish-python.yml#L32
to read: python: ["3.8", "3.9", "3.10", "3.11", "3.12"] and re-run the build.
And then also changing the README.md here: https://github.com/breez/breez-sdk/blob/f5fac7e7713002df2b60532ba740776ec475ce3c/libs/sdk-bindings/bindings-python/README.md#L26

Hey @prusnak, thanks for raising this. I'll get back to you on this tomorrow.

@prusnak I've added 3.11. and 3.12 support to our release pipeline. Once merged, we'll create a new release on PyPi (likely 0.2.9.post1) which should then include wheels for those Python versions. I'll keep you posted here.

Hey @prusnak we just published 0.2.9.post3 which includes wheels for Python 3.11 and 3.12. Please let me know if that solves your issue. You can install this version using:
pip install breez-sdk==0.2.9.post3

Thanks. It works!


Update Composer dependencies (2023-12-09-00-10)

Visual regression test passed!
View the visual regression test report


DRILL-4664: ScanBatch.isNewSchema() returns wrong result for map datatype

creating a separate SchemaChangeCallBack for new MapVecor in MapTransferPair,
RepeatedMapTransferPair and SingleMapTransferPair .

@hnfgns Could you please review?

looks good to me +1
@parthchandra can we run regression and merge?


Update README with deployment info, etc

Description
Updating the README.
Link to issue

[x] Add Deployment instructions for Vercel and Cloudflare Pages
[x] Add "experimental software warning"
[x] Add supported node versions.

Closes #9.

@bgins @therealjeffg could one of you review before pod planning today?

One thing I noticed is the links to the Vercel and Cloudflare Pages previews are 404.

Whoops! One is a bad link, and the other (Cloudflare Pages) had to be deleted because it couldn't be "transferred" to the corporate Cloudflare account. They'll be fixed in a few minutes. 🤦♂


Switch servo not works

I have made this Useless-box but switch servo rotate only 45 degrees. If in config.h I change 145 with other value servo rotate always 45degrees

Same problem for me. Did you solve it?
Servo rotate max 90 degrees if i change 145 to 180 in config.h

I have the same problem.  I am not an expert but I think it is do with the pulse width (in milliseconds) that is used for the servos.
I created a script to move the servo and found that I had to use the following for a full 180 movement.
void setup() {
myservo.attach(0, 500, 2500);
0=pin, 500=min pulse width, 2500=max pulse width
Now I just have to figure out how to do it with the code supplied.
Any ideas?

Unfortunately I don't know the programming language that well, however I have other sketches that move the same servo 180 degrees so I agree with you that it is definitely a code configuration problem, not an hardware problem.

Sorry for my bad english, but i think, the follow steps will solve your Problem @TillMoss and @Fullmetal11
you have to calibrate the min and max pulsewidth in servo.h, located in \AppData\Local\Arduino15\packages\esp8266\hardware\esp8266\3.0.1\libraries\Servo\src\
#define DEFAULT_MIN_PULSE_WIDTH      1000 // uncalibrated default, the shortest duty cycle sent to a servo #define DEFAULT_MAX_PULSE_WIDTH      2000 // uncalibrated default, the longest duty cycle sent to a servo  #define DEFAULT_NEUTRAL_PULSE_WIDTH  1500 // default duty cycle when servo is attached
in my case i have set to 500 and 2500, like  @chips32

@Doka85 Thak you!!!
As you suggested, I change the value:
#define DEFAULT_MIN_PULSE_WIDTH      500 // uncalibrated default, the shortest duty cycle sent to a servo
#define DEFAULT_MAX_PULSE_WIDTH      2500 // uncalibrated default, the longest duty cycle sent to a servo
in the file servo.h located in \AppData\Local\Arduino15\packages\esp8266\hardware\esp8266\3.0.1\libraries\Servo\src\ and I solved the problem, now it work good!!!!!
So happy now!!! :-)


TIM-315 Refactor hover effect of buttons on footer

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#50  👈
#49
#48
#47
#46
#45
#44
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @tamrivera05 and the rest of your teammates on  Graphite


Keep track of the best model's path saved by ModelCheckpoint

Before submitting

[ ] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
[x] Did you read the contributor guideline, Pull Request section?
[ ] Did you make sure to update the docs?
[ ] Did you write any new necessary tests?
[ ] If you made a notable change (that affects users), did you update the CHANGELOG?

What does this PR do?
Add an additional attribute to ModelCheckpoint to keep track of the best model's path. Currently, only the best metric value is directly tracked.
When training finishes, if we want to know where the best model is, we need to either do:
op = min if checkpoint_callback.mode == 'min' else max
best_model_path = op(
    checkpoint_callback.best_k_models,
    key=checkpoint_callback.best_k_models.get
)

or
best_model_path = [
    path
    for path, metric in checkpoint_callback.best_k_models.items()
    if metric == checkpoint_callback.best
][0]

which are both somewhat cumbersome.
Since the best value is already tracked, this PR simply tracks the saved path as well.
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Glad to make PTL even more practical.

@kepler nice!
Can you add to the docs?

Thanks, @williamFalcon.
Not sure where to add any documentation, though. None of the attributes in ModelCheckpoint, like best and best_k_models, are documented. Should I simply add a note in the class' docstring, right before Args?

Hello @kepler! Thanks for updating this PR.

In the file pytorch_lightning/callbacks/model_checkpoint.py:

Line 24:1: W293 blank line contains whitespace
Line 85:1: W293 blank line contains whitespace

@williamFalcon let me know if this is enough.

@kepler that's great!
However, can you do a new PR with the changes?

@williamFalcon are you sure this is already merged to master? I can't see the changes there (hence creating a new PR based on this branch seems convoluted to me).

@kepler you're right! sorry about that. let's merge this PR then :)

@williamFalcon no problem.
I have to say I don't understand why the tests failed (for Ubuntu and MacOS but passed for Windows). Could you please rerun them, just in case? Otherwise, I'll trigger it with a small commit (in about two hours).

https://github.com/PyTorchLightning/pytorch-lightning/pull/1799/checks?check_run_id=712909136 they don't pass on windows. For windows this is just not correctly indicated.
On linux and macos, you have a print statement in your doctests which produce some output although no output is expected and thus the tests fail

So it was indeed a problem with the doctest (totally missed it). Thanks, @justusschock.

I have to say I don't understand why the tests failed (for Ubuntu and MacOS but passed for Windows). Could you please rerun them, just in case? Otherwise, I'll trigger it with a small commit (in about two hours).

Win is pure and not have implemented all functions properly...

@Borda This should be ready now.


Fix conflict with now-stable method Iterator::find_map

To quick fix this without changing rust version, rename our local
extension methods to use an ex_ prefix.
Fixes #223

travis: test compile is broken on Rust 1.12 but not the plain build, shipping.


Fix create external table example query

Based on my experimentation the example query to create external table isn't correct. The correct syntax is to have the DATA_SOURCE in WITH section.
See here

Docs Build status updates of commit 86cd042:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

azure-sql/database/elastic-query-vertical-partitioning.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

#sign-off


[PDI-19627] - Add a checksum：When "Compatibility Mode" is checked and "Type" set to SHA-256, transformation errors out.

@bcostahitachivantara
@smmribeiro
@renato-s

:white_check_mark: Build finished in 7m 59s
Build command:
mvn clean verify -B -e -Daudit -amd -pl plugins/core/impl

:ok_hand: All tests passed!
Tests run: 78, Failures: 0, Skipped: 1    Test Results

:information_source:  This is an automatic message


safetensors_rust.SafetensorError: Error while deserializing header: HeaderTooLarge

Traceback (most recent call last):
File "/home/mlp/anaconda3/envs/echomimic2/lib/python3.10/site-packages/diffusers/models/model_loading_utils.py", line 142, in load_state_dict
return safetensors.torch.load_file(checkpoint_file, device="cpu")
File "/home/mlp/anaconda3/envs/echomimic2/lib/python3.10/site-packages/safetensors/torch.py", line 313, in load_file
with safe_open(filename, framework="pt", device=device) as f:
safetensors_rust.SafetensorError: Error while deserializing header: HeaderTooLarge
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/home/mlp/anaconda3/envs/echomimic2/lib/python3.10/site-packages/gradio/queueing.py", line 624, in process_events
response = await route_utils.call_process_api(
File "/home/mlp/anaconda3/envs/echomimic2/lib/python3.10/site-packages/gradio/route_utils.py", line 323, in call_process_api
output = await app.get_blocks().process_api(
File "/home/mlp/anaconda3/envs/echomimic2/lib/python3.10/site-packages/gradio/blocks.py", line 2015, in process_api
result = await self.call_function(
File "/home/mlp/anaconda3/envs/echomimic2/lib/python3.10/site-packages/gradio/blocks.py", line 1562, in call_function
prediction = await anyio.to_thread.run_sync(  # type: ignore
File "/home/mlp/anaconda3/envs/echomimic2/lib/python3.10/site-packages/anyio/to_thread.py", line 56, in run_sync
return await get_async_backend().run_sync_in_worker_thread(
File "/home/mlp/anaconda3/envs/echomimic2/lib/python3.10/site-packages/anyio/_backends/_asyncio.py", line 2505, in run_sync_in_worker_thread
return await future
File "/home/mlp/anaconda3/envs/echomimic2/lib/python3.10/site-packages/anyio/_backends/_asyncio.py", line 1005, in run
result = context.run(func, *args)
File "/home/mlp/anaconda3/envs/echomimic2/lib/python3.10/site-packages/gradio/utils.py", line 865, in wrapper
response = f(*args, **kwargs)
File "/home/mlp/echomimic_v2-main/app.py", line 53, in generate
vae = AutoencoderKL.from_pretrained("./pretrained_weights/sd-vae-ft-mse").to(device, dtype=dtype)
File "/home/mlp/anaconda3/envs/echomimic2/lib/python3.10/site-packages/huggingface_hub/utils/_validators.py", line 114, in _inner_fn
return fn(*args, **kwargs)
File "/home/mlp/anaconda3/envs/echomimic2/lib/python3.10/site-packages/diffusers/models/modeling_utils.py", line 840, in from_pretrained
state_dict = load_state_dict(model_file, variant=variant)
File "/home/mlp/anaconda3/envs/echomimic2/lib/python3.10/site-packages/diffusers/models/model_loading_utils.py", line 154, in load_state_dict
raise OSError(
OSError: You seem to have cloned a repository without having git-lfs installed. Please install git-lfs and run git lfs install followed by git lfs pull in the folder you cloned.
Traceback (most recent call last):
File "/home/mlp/anaconda3/envs/echomimic2/lib/python3.10/site-packages/diffusers/models/model_loading_utils.py", line 142, in load_state_dict
return safetensors.torch.load_file(checkpoint_file, device="cpu")
File "/home/mlp/anaconda3/envs/echomimic2/lib/python3.10/site-packages/safetensors/torch.py", line 313, in load_file
with safe_open(filename, framework="pt", device=device) as f:
safetensors_rust.SafetensorError: Error while deserializing header: HeaderTooLarge
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/home/mlp/anaconda3/envs/echomimic2/lib/python3.10/site-packages/gradio/queueing.py", line 624, in process_events
response = await route_utils.call_process_api(
File "/home/mlp/anaconda3/envs/echomimic2/lib/python3.10/site-packages/gradio/route_utils.py", line 323, in call_process_api
output = await app.get_blocks().process_api(
File "/home/mlp/anaconda3/envs/echomimic2/lib/python3.10/site-packages/gradio/blocks.py", line 2015, in process_api
result = await self.call_function(
File "/home/mlp/anaconda3/envs/echomimic2/lib/python3.10/site-packages/gradio/blocks.py", line 1562, in call_function
prediction = await anyio.to_thread.run_sync(  # type: ignore
File "/home/mlp/anaconda3/envs/echomimic2/lib/python3.10/site-packages/anyio/to_thread.py", line 56, in run_sync
return await get_async_backend().run_sync_in_worker_thread(
File "/home/mlp/anaconda3/envs/echomimic2/lib/python3.10/site-packages/anyio/_backends/_asyncio.py", line 2505, in run_sync_in_worker_thread
return await future
File "/home/mlp/anaconda3/envs/echomimic2/lib/python3.10/site-packages/anyio/_backends/_asyncio.py", line 1005, in run
result = context.run(func, *args)
File "/home/mlp/anaconda3/envs/echomimic2/lib/python3.10/site-packages/gradio/utils.py", line 865, in wrapper
response = f(*args, **kwargs)
File "/home/mlp/echomimic_v2-main/app.py", line 53, in generate
vae = AutoencoderKL.from_pretrained("./pretrained_weights/sd-vae-ft-mse").to(device, dtype=dtype)
File "/home/mlp/anaconda3/envs/echomimic2/lib/python3.10/site-packages/huggingface_hub/utils/_validators.py", line 114, in _inner_fn
return fn(*args, **kwargs)
File "/home/mlp/anaconda3/envs/echomimic2/lib/python3.10/site-packages/diffusers/models/modeling_utils.py", line 840, in from_pretrained
state_dict = load_state_dict(model_file, variant=variant)
File "/home/mlp/anaconda3/envs/echomimic2/lib/python3.10/site-packages/diffusers/models/model_loading_utils.py", line 154, in load_state_dict
raise OSError(
OSError: You seem to have cloned a repository without having git-lfs installed. Please install git-lfs and run git lfs install followed by git lfs pull in the folder you cloned.

I have solved this problem. This problem derives from broken weight models downloaded using huggingface_cli command. I redownload the weight models using 'git clone' command and it can run well now.


Barking manifesto indices

Description
Implementation of various importers for the Barking manifesto indices. Some tweeks in the codebase when neccessary
Checklist

[ ] Created new test(s) (if applicable)
[ ] Updated the README / documentation (if applicable)

Closing this PR as it will be addressed by splitting it in smaller PR easier to review and test.


Android: add preference to auto-open first unread story.

From https://getsatisfaction.com/newsblur/topics/android-app-directly-open-the-first-story-by-opening-a-folder
We have this on the web, so why not have it on Android?

Should this only work in folders or also in individual feeds?

Works on both (as well as on blurblogs). Obviously it only finds the first unread if there is one and doesn't kick you out if it doesn't find one.

So if you tap into a feed with no unreads, does it stay on the story list or does it open the first (already-read) story?

It stays on the story list. You can double check this behavior on the web.

Sounds good.  Implementation incoming.

Done in #795


Screenshot

Could a screenshot of what the metrics look like be added to the docs or GitHub? Apologies if I missed it.

That's a great idea!


Feature request: operation (and keybind) to download a full article

Hello,
first of all, thanks for the great piece of software! However, I'm really missing an operation to download the single full article while in article view, even if a description is present (some Android RSS readers implement this per tap). Does it make sense and look possible/plausible for you?
Thanks and regards

Any feedback?

Sounds like a good idea. This would let users apply download-full-page` on a case-by-case basis. I think the implementation should be shared, i.e. the keybind should do exactly what the setting does (but to an article rather than the whole feed).

I removed "and keybind" from the subject line because I don't yet know if there'll be a default keybind for this. Creating an operation is a good first step though.

@Minoru I will try to implement this

A lot of work was done in https://github.com/newsboat/newsboat/pull/2609, but then we ran into some corner cases and the discussion kind of died. If someone wants to work on this, please see that PR to get a better picture of that's involved.


Support loading limited context for stub runner tests

#473 - @marcingrzejszczak , this is still Work in progress, but I wanted to send you a PR to see if this directionally looks okay. Can you please review when you get a chance.

This looks very good! I'd only add @since 2.0.0 in the javadocs and add some documentation. Anything you would add @dsyer ?

We prefer test classes to be called *Tests. That should be easy to change.

I don't really understand the problem this solves, so some documentation will be helpful as well. Otherwise there will be a lot of confusion about why this is needed in addition to @AutoConfigureStubRunner (is it, actually, needed?).

My understanding is that you don't need the full Spring Boot context to use StubRunner thanks to this, am I correct @bijukunjummen ?

Is there a way to just use @AutoconfigureStubRunner in a normal (existing) test slice?

@marcingrzejszczak , @dsyer , I have now removed the slice test for stub runner and instead modified like you suggested @AutoConfigureStubRunner to load only the relevant auto-configurations, this way it works in combination with any other test slice.

Codecov Report

Merging #496 into master will increase coverage by 1.27%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master     #496      +/-   ##
============================================
+ Coverage     60.27%   61.54%   +1.27%
- Complexity     1627     1683      +56
============================================
  Files           191      204      +13
  Lines          6266     6551     +285
  Branches        871      895      +24
============================================
+ Hits           3777     4032     +255
- Misses         1996     2002       +6
- Partials        493      517      +24

Impacted Files
Coverage Δ
Complexity Δ

...StubRunnerStreamsIntegrationAutoConfiguration.java
100% <100%> (ø)
1 <1> (?)

...contract/verifier/builder/MethodBodyBuilder.groovy
80.21% <0%> (-0.11%)
88% <0%> (+1%)

.../StubRunnerSpringCloudEurekaAutoConfiguration.java
0% <0%> (ø)
0% <0%> (ø)
:arrow_down:

...nner/spring/cloud/eureka/EurekaStubsRegistrar.java
0% <0%> (ø)
0% <0%> (ø)
:arrow_down:

...loud/contract/stubrunner/AetherStubDownloader.java
52.41% <0%> (ø)
23% <0%> (+1%)
:arrow_up:

...ontract/verifier/plugin/OutputFolderBuilder.groovy
100% <0%> (ø)
1% <0%> (?)

...unner/messaging/amqp/AmqpMessagingApplication.java
92.85% <0%> (ø)
3% <0%> (?)

...act/verifier/plugin/GenerateServerTestsTask.groovy
67.85% <0%> (ø)
1% <0%> (?)

...oud/contract/stubrunner/messaging/amqp/Person.java
85.71% <0%> (ø)
4% <0%> (?)

...t/stubrunner/messaging/amqp/MessageSubscriber.java
100% <0%> (ø)
2% <0%> (?)

... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de12c4a...a982251. Read the comment docs.

Thanks a lot @bijukunjummen !


Documentation about docker images unclear

I would like to run the MySQL Docker image, but I'm getting the following error when running the image:
yarn run v1.22.19
$ npm-run-all check-db update-tracker start-server
$ node scripts/check-db.js
✗ DATABASE_URL is not defined.

I can't find anywhere in the documentation what I should specify for the DATABASE_URL for MySQL? It's running inside the container, so should be a localhost URL.
For Postgres, I can figure it out by checking the docker-compose.yml.
The documentation is not clear about this.

An example of a mysql connection string can be found on the installation page, https://umami.is/docs/install.

Thanks @briancao . I got confused a little bit as I was assuming the docker image had MySQL built in... My bad!
It took me some time, but I now have it running on Azure using a PostgresDB Single Server. Loving it!
If you want, I can share the bicep code to deploy this.


the Requester should allow issue SET_CERTIFICATE outside of a secure session for slots 1-7

the Requester should allow issue SET_CERTIFICATE outside of a secure session for slots 1-7.

The current code behavior is The Requester shall issue SET_CERTIFICATE inside a secure session for slot 1-7 provisioning.
https://github.com/DMTF/libspdm/blob/aa51e293809194e601af7db7c96f5e855d4d78cb/library/spdm_requester_lib/libspdm_req_set_certificate.c#L58-L62
Refer to the paragraph 675 in DSP0274_1.2.1.pdf.

Base on the above specification, "should" ("recommended"), I think:
For slots 1-7, if the provisioning happens in a trusted environment, the Requester should allow issue SET_CERTIFICATE outside of a secure session.

From 5-Jun-2023 meeting: we could add a bit to the spdm_context or require a function (in secretlib) that says whether the Responder is in a trusted environment or not.


Add label to embedding in JSON formatter

Summary

embed function in Cucumber:Formatter:Json takes 3 parameters(src, mime_type and label). However, only mime_type and data encoded from src are embedded to result json file. It would be better if also label is embedded to result.
Possible Solution
I don't see into inner code of formatters but all what need to be done is change line:
test_step_embeddings << { mime_type: mime_type, data: data }
to
test_step_embeddings << { mime_type: mime_type, data: data, label: label }
Context & Motivation
I'm using reporter which transforms json to html report and it would be nice if i could get embeding label to know what screenshot belongs to what browser.

Cucumber-Ruby currently lives in the cucumber/cucumber-ruby repo. Could you please reopen this issue there?


[Typo?] problem with the contains() method

I have a Many to Many relation between User and Role. For some strange reason when I do User::find(1)->roles->contains(2) it just won't work, always throws false (I've checked in the db and indeed user with id 1 has role with id 2).
I'm using it just as the Laravel docs: http://laravel.com/docs/5.0/eloquent#collections
I dug the contains() method and found it in Illuminate\Database\Eloquent\Collecion.php, here it is:
    /**
	 * Determine if a key exists in the collection.
	 *
	 * @param  mixed  $key
	 * @param  mixed  $value
	 * @return bool
	 */
	public function contains($key, $value = null)
	{
		if (func_num_args() == 1 && ! $key instanceof Closure)
		{
			$key = $key instanceof Model ? $key->getKey() : $key;

			return $this->filter(function($m) use ($key)
			{
				return $m->getKey() === $key;

			})->count() > 0;
		}
		elseif (func_num_args() == 2)
		{
			return $this->where($key, $value)->count() > 0;
		}

		return parent::contains($key);
	}

Right in the middle of the method, if I change return $m->getKey() === $key; for == it suddenly works. Is this a typo? Should I report it in the repository or make a pull request?
P.S. It will never enter the parent::contains(), or at least in my case.

Thanks for reporting. :)


feat: list contact type codes

Description
Add endpoint to list contact type codes
Fixes # (issue)
Checklist

[x] I have read the CONTRIBUTING doc
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have already been accepted and merged

Thanks for the PR!
Any successful deployments (not always required) will be available below.
Backend available
Frontend available
Legacy available
Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

Just marking @DerekRoberts to notify him that there are no significant changes to the workflow. I've added the tests to the main workflow to report it back to sonar on main branch. All projects are reporting as no info/coverage for the main branch and we are unable to use it as a reference branch for comparison.


Change of the datasets

I noticed openai/webgpt_comparisons and stanfordnlp/SHP have been removed from step 1 & 2, and for step 3, only Dahoas/rm-static is remained. I thought more data should be better for training the model capacity. May I ask whether there is any specific concerns for this change? Will openai/webgpt_comparisons and stanfordnlp/SHP decrease the performance of the model? Thanks : )

And also I noticed the default number of training epochs for step 1 increases from 2 to 16. Is this number beneficial for the whole RLHF procedure? Thanks : )

@SenZHANG-GitHub The dataset choices in our example scripts reflect what we actually tested during the development of DeepSpeed-Chat. Initially we only use a single dataset Dahoas/rm-static. Then after enabling data blending feature, our preliminary study on step 1 & 2 with OPT-1.3B shows that from 1 dataset to 4 datasets, the model quality increases, while the quality is rather similar between 4 and 6 datasets (example comparisons for step 1 are at DeepSpeedExamples/README.md at master · microsoft/DeepSpeedExamples · GitHub). Due to time and resource limitation, we still used 1 dataset for step 3 experiments, and we didn't further test whether more datasets are beneficial for larger/different models. This is why we used 4 datasets in step 1 & 2 example scripts, and only Dahoas/rm-static in step 3. For the number of training epochs, in some of our step 1 example scripts we put 16 simply because that's what InstructGPT used ("Training language models to follow instructions with human feedback").
On the other hand, we would like to clarify that: what DeepSpeed-Chat provides is a framework for efficiently training any ChatGPT-like model, and a set of example scripts that we tested in terms of system performance and whether the result model produces meaningful responses using the specific pretrained models/datasets/hyperparameters. However, we do not provide any guideline of "which pretrained models/datasets/hyperparameters to use in order to train the best ChatGPT-like model". Such guideline is impossible to provide given the rapidly evolving AI research: new models/datasets/techniques are invented every day. Users would need to explore themselves about how to train a better model for their situations.


fix neon example readme instruction to match package.json

i tried running migrate from the example - and got the following error, /node_modules/.pnpm/drizzle-orm@0.23.2_@cloudflare+workers-types@4.20230215.0_@neondatabase+serverless@0.1.13_postgres@3.3.3/node_modules/drizzle-orm/migrator.js:29
throw Error(Can't find meta/_journal.json file)
it looks like part of the files from the old version? Is there an easy way to run the example with the latest version?
Thanks in advance


Question : Disable submit button

Is there a way to disable the submit button onSubmit to give the form time to process and prevent duplicate calls?  If not, is the feature being considered?  Is this example in tips and tricks the recommended method? https://jsfiddle.net/spacebaboon/g5a1re63/

I don't know where "this.form" and "this.form.submitButton" come from in this example.
And I didn't see any props called submitButton in Form component. This makes me confuse.
`class Container extends React.Component {
constructor(props) {
super(props);
this.submitForm = this.submitForm.bind(this);

}
submitForm() {
this.form.submitButton.click();

}
render() {
return (

<MyForm ref={(form) => {this.form=form;}}/>

);
}
};`

You can use https://github.com/mozilla-services/react-jsonschema-form#disabled-fields.


feat: add DefaultPlugin

Add DefaultPlugin so that we don't need to reimplement all the methods.

Codecov Report

Merging #92 (d9c48f5) into master (d283ba2) will increase coverage by 0.36%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #92      +/-   ##
==========================================
+ Coverage   82.01%   82.38%   +0.36%
==========================================
  Files          14       14
  Lines         901      897       -4
==========================================
  Hits          739      739
+ Misses        117      113       -4
  Partials       45       45

Impacted Files
Coverage Δ

cmd/go-runner/plugins/fault_injection.go
61.29% <ø> (+1.91%)
:arrow_up:

cmd/go-runner/plugins/limit_req.go
81.81% <ø> (+3.55%)
:arrow_up:

cmd/go-runner/plugins/response_rewrite.go
82.60% <ø> (+3.44%)
:arrow_up:

cmd/go-runner/plugins/say.go
77.77% <ø> (+4.09%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d283ba2...d9c48f5. Read the comment docs.