Understanding your project / AirWatch MDM integration

Hello,
I recently was pointed to your project and I am just wanting to learn a little more.  Unfortunately your readme file just doesn't have the details I am looking for.
I am currently implementing an integration with the AirWatch SDK to provide MDM(ish) functions for our native app.  Is react-native-mdm meant to be a generic interface for any MDM library?  I am thinking it might be based on the code I just looked at.
For example, in my current implementation I have two main areas of development.  First, I have a new react-native native-module named AirWatchReactNative.  This module basically provides a dispatchEvent function that is used to notify the app when something happens as well as the list of supported events.  Its implementation looks like this:
#import "AirWatchReactNative.h"
#if __has_include(<React/RCTEventDispatcher.h>)
#import <React/RCTEventDispatcher.h>
#else
#import "RCTEventDispatcher.h"
#endif

@implementation AirWatchReactNative
@synthesize sharedInstance;

+ (BOOL)requiresMainQueueSetup
{
  return NO;
}

- (instancetype)init
{
  self = [super init];
  self.sharedInstance = self;
  return self;
}

- (dispatch_queue_t)methodQueue
{
  return dispatch_get_main_queue();
}

- (void)dispatchEvent:(NSString *)name withBody: (NSDictionary *)body {
  NSLog(@"Calling dispatch: %@", name);
  [self sendEventWithName:name body:body];
}

- (NSArray<NSString *> *)supportedEvents
{
  return @[
           @"AWreceivedProfiles",
           @"AWenrollmentStatus",
           @"AWinitialCheck",
           @"AWwipe",
           @"AWlock",
           @"AWunlock",
           @"AWstopNetwork",
           @"AWresumeNetwork"
           ];
}

RCT_EXPORT_MODULE();

@end

I think call these methods when the AirWatch SDK functions are called.  In my AppDelegate.swift file (yes, we had to use swift because AirWatch SDK is only available in swift now) we do this (just one example):
  func controllerDidReceive(profiles: [Profile]) {
    AWLogVerbose("SDK recieved \(profiles.count) profiles.")

    guard profiles.count > 0 else {
      AWLogError("No profile received")
      AirWatchReactNative().sharedInstance.dispatchEvent("AWreceivedProfiles", withBody: [
        "count": profiles.count,
        "profiles": []
        ]
      )
      return
    }
    AWLogInfo("Now printing profiles received: \n")
    profiles.forEach { AWLogInfo("\(String(describing: $0))") }
    AirWatchReactNative().sharedInstance.dispatchEvent("AWreceivedProfiles", withBody: [
      "count": profiles.count,
      "profiles": profiles
      ]
    )
  }

What I am wondering is if react-native-mdm is meant to replace my AirWatchReactNative module and if so, what your roadmap for features looks like as there are numerous events beyond app_config that need to be supported.  If this is your intended purpose, I'd gladly lend effort to extend react-native-mdm to support our needs, but if it is not, I just need to know so that I don't waste the effort.

@DaKaZ could you please share your AirWatch integration because we need same feature ?

Hi , is react-native-mdm just for Airwatch or supported other providers ? is there any list of supported MDM providers ?
Thanks

@DaKaZ  Hey there, could you share if you had success with Airwatch or didnt and some feedback?
trying to evaluate it . Thanks

We did have success with the integration.  I'm worked with Kaz.  We can't share the code unfortunately because of restrictions from our client.

Short question: I've integrated AWS-SDK into my App. Now I've one small problem. When the Task Switch is activated a BlockerView should be shown. AWS logs that the View is shown but it is not?
2020-10-01 10:59:02.579528+0200 zeusMobile[475:24568] 2020-10-01 10:59:02:576 zeusMobile[475:24182] +[AWSDKPresentation showBlockerView] [Line:410][I]: Showing blocker view.


Fix conditional for overrideCommandForWebview

For #101946
These command should be active if:

We are on mac
or we are not using custom title bars

The previous code was incorrectly disabling these commands entirely on Mac (due to the check for window.titleBarStyle)
(for testing, make sure you do not have iframe based webviews enabled)

Thanks @deepak1556!


Feature: Add support for loadEnvFromConfigMaps

Could someone help me fix the CI?

Could someone help me fix the CI?

Could someone help me fix the CI?

You need to ensure the version in chart.yaml is bumped.

Could someone help me fix the CI?

You need to ensure the version in chart.yaml is bumped.

@lkysow thx for the tip. CI passes :confetti_ball:

@lkysow thx for the tip. CI passes :confetti_ball:

@lkysow fine from Your side to merge this PR?

@lkysow fine from Your side to merge this PR?


More relaxed dependence: Silverstripe Admin instead Silverstripe CMS

This module should require Silverstripe Admin and not Silverstripe CMS

Replaced by https://github.com/silverstripe-terraformers/gridfield-rich-filter-header/pull/11
Thanks @alessandromarotta  for pointing this out. I checked the dependencies and it seems that the SilverStripe CMS is not needed at all. All dependencies should be covered by the framework only.


AbstractPsrAutoloadingFixer - fix edge case of halting compiler for PHP 5.3

cc @SpacePossum

nice :)
thanks!
are we in the clear with the other keywords and magic constants? I guess since the test are green :)

yep, we have hack for halting compiler in other places too for 5.3


Make all implants unable to be implanted more than once

About the PR
This PR makes mind shields unable to be implanted more than once.
Why / Balance

PJB complained and people waste implants by injecting already injected people.
Technical details

Adds a new datafield to the Implanter component which is checked in implanter system.
Media

[x] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

N/A
Changelog

:cl: Simyon

tweak: All implants are now unable to be implanted more than once.

Wonderful PR

Test fail is cargo spesos related, so not my fault.

Test fail is (again) cargo arbitrage.

Test fail is (again) cargo arbitrage.

Is this branch up to date with master?

Deny multiple implants for fun implants too.

Change PR title?

Done

Wouldn't this sorta prevent people from having multiple emp or multiple scram implants? They're limited-use too

Yes. This PR would prevent that.

This takes away my coveted 10-bikehorn-implant-hotbar strategy. No more sounding like a Cluwne.
Probably a good thing.


[MINOR] example: Add example docker compose Uniffle/Spark cluster

What changes were proposed in this pull request?
Adds code to spin up an example Uniffle/Spark docker cluster using docker compose. This is used by the CI to test the example cluster setup.
Why are the changes needed?
This setup has a smaller footprint than the existing kubernetes example in deploy/kubernetes/integration-test/e2e/README.md, which is not trivial to setup. The new example only requires Docker to be installed, and can be spun up via
./deploy/docker-compose/build.sh
docker compose -f deploy/docker-compose/docker-compose.yml up

The Uniffle and Spark cluster can be used to interactively test Spark with Uniffle.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Manually and CI tested.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (866f5ff) 54.20% compared to head (b06b48e) 55.46%.
Report is 13 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1532      +/-   ##
============================================
+ Coverage     54.20%   55.46%   +1.25%
+ Complexity     2808     2428     -380
============================================
  Files           430      373      -57
  Lines         24410    17172    -7238
  Branches       2082     1563     -519
============================================
- Hits          13231     9524    -3707
+ Misses        10349     7099    -3250
+ Partials        830      549     -281

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

CI is blocking @EnricoMi

@zuston CI fixed, not pretty but stable.

@zuston Rust ci is so flaky. Could you fix it?

@zuston Rust ci is so flaky. Could you fix it?

Yes. I will


Paligemma Support

This PR is for implementing Paligemma support within Ollama using GGML. Paligemma is a one-shot image-text to text model from Google.
The main features of this PR are the pre-processing of image-text prompts to Paligemma, incorporating non-causal attention on prompt processing, and merging image features to input features within llama.cpp for combined decoding. This modifies /examples/llava to adapt to the missing projector in Paligemma. No changes were made to clip.cpp for image embeddings.

server.cpp
server.cpp now checks for images and determines which prompt-processing path to take depending on model architecture. Paligemma utilizes image placeholder tokens <image> as substitutes to image embeddings prepended to the text prompt. The input to the model should be in the format <image>...<image><bos> + text + \n. The text with the placeholders is then embedded. We include the image embeddings previously retrieved from the image encoder as part of the model context, which is the swapped with the placeholder embeddings within the building of the compute graph.

llama.cpp
The patch to llama.cpp utilizes the text inputs (including the placeholders) to embed the entire input. The image placeholder tokens then have their data exchanged with the correct image embeddings passed in within the model context. Checks are now also made to ensure that logits are reserved within non-causal decodes if the decode includes images as well.

USAGE:
To run Paligemma, you need to first create GGUF files for both the vision encoder and language model. This can be done using this surgery file here. Create a Modelfile referencing both GGUF files without a template to run.
Pull this model directly from ollama using ollama pull jyan1/paligemma-mix-224. Take a look at the model here
Build and run this PR
If you do not have a clone of this repository already
git clone https://github.com/ollama/ollama.git

Build and serve
cd ollama
git fetch -a
git checkout paligemma-support
go generate ./...
go build .
./ollama serve

You can now query Paligemma either from the CLI or via HTTP request.
CLI Example
Using another terminal window
./ollama run jyan1/paligemma-mix-224

Input
>>> What is in this image? /path/to/my/puppy.jpg

Output
Added image '/path/to/my/puppy.jpg'
A brown dog wearing a floral shirt and lei stands proudly next to a clear blue
pool. The dog's mouth is open, its paw rests on the edge of the water, and its
eyes are focused on the horizon. The pool water is crystal clear, and the palm
trees in the distance provide shade for the dog.  The dog's fur is brown,
and its nose is black. The tree behind the pool is tall and slender, and the
fence surrounding the pool is made of metal posts.

/path/to/my/puppy.jpg for reference :)
This PR includes support for a one-shot one-image image-text prompt to Ollama. The supported models include Paligemma models with the -224 suffix, referencing the rescaled image size that they use.
TODO:

[ ] Include multi-image prompt processing, which involves appending additional image tokens to the start of the text input, as well as including an array of image embeddings to the model context
[ ] Utilizing model configurations to append the right number of placeholder tokens in server.cpp and set-up correct dimensions
[ ] Ensure that prompt is not truncated due to batch size as Paligemma wants the entire input, including all text and images, to be provided as a single batch. Note for Paligemma-...-448 and Paligemma-...-896 models, there are 1024 and 4096 image tokens per image in the input which is already larger than the batch_size set in llama.cpp

Thanks everyone,
Josh and Roy

I get this error when I run this model:
ollama run jyan1/paligemma-mix-224
Error: llama runner process has terminated: signal: segmentation fault (core dumped)

Hi @royjhan - thanks for this contribution. I wanted to give it a try (running on MacBook M2 Pro 2023), but I am getting stuck with the following error at the go generate ./... stage. Any ideas?
-- Build files have been written to: /Users/matthiasbaetens/code/ollama/llm/build/darwin/arm64_static
+ cmake --build ../build/darwin/arm64_static --target llama --target ggml -j8
[  9%] Building C object ggml/src/CMakeFiles/ggml.dir/ggml-metal.m.o
[ 18%] Building CXX object ggml/src/CMakeFiles/ggml.dir/ggml-blas.cpp.o
/Users/matthiasbaetens/code/ollama/llm/llama.cpp/ggml/src/ggml-blas.cpp:4:10: fatal error: 'future' file not found
    4 | #include <future>
      |          ^~~~~~~~
1 error generated.


Bump zetasql version to 2024.08.1

In preparation of upcoming GCP-BOM update
Please add a meaningful description for your change here

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

ZetaSQL 2022.08 release already had multiple breaking change due to removed public APIs:
Task :sdks:java:extensions:sql:hcatalog:buildDependents
/runner/_work/beam/beam/sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/translation/ExpressionConverter.java:500: error: cannot find symbol

> Task :sdks:java:extensions:sql:zetasql:compileJava
                                fixedOutputSchemaTVF.getOutputSchema().getColumns());
                                                    ^
  symbol:   method getOutputSchema()
  location: variable fixedOutputSchemaTVF of type FixedOutputSchemaTVF
/runner/_work/beam/beam/sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/translation/TVFScanConverter.java:74: error: cannot find symbol
            .containsKey(zetaNode.getTvf().getNamePath())) {
                                          ^
  symbol:   method getNamePath()
  location: class TableValuedFunction
/runner/_work/beam/beam/sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/translation/TVFScanConverter.java:75: error: cannot find symbol
      inputs.add(context.getUserDefinedTableValuedFunctions().get(zetaNode.getTvf().getNamePath()));
                                                                                ^
  symbol:   method getNamePath()
  location: class TableValuedFunction
/runner/_work/beam/beam/sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/translation/AggregateScanConverter.java:97: error: incompatible types: ResolvedComputedColumnBase cannot be converted to ResolvedComputedColumn
      for (ResolvedComputedColumn computedColumn : zetaNode.getAggregateList()) {
                                                                            ^
/runner/_work/beam/beam/sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/translation/AggregateScanConverter.java:147: error: incompatible types: ResolvedComputedColumnBase cannot be converted to ResolvedComputedColumn
    for (ResolvedComputedColumn resolvedComputedColumn : node.getAggregateList()) {
                                                                              ^

Found internally that these code were removed by bot as "dead code". Upgrading ZetaSQL is no longer not attempted as more similar breaking change may be seen if we choose this route.

Run Java PreCommit

assign set of reviewers


Sire timer broken in 1.6.25

I was doing sire on the old RL version and updated when the new version came I noticed the timer displays incorrectly.
Describe the bug
When you "wake" sire the timer appears counting down from ~30 seconds, but once you stun sire to attack his respiroators the timer disapears.
To Reproduce
Attack sire (you can attack sire with anything first, spell or ranged this does not matter i've tried both),
See timer appear
Stun sire with shadow spell
See timer disapear
Expected behavior
Only once you stun sire with a shadow spell should the timer appear counting down how much time he is stunned.
Screenshots
After the first attack

After the stun

Environment (please complete the following information):

OS: win 10
RuneLite version: 1.6.25
Launcher version: 2.1.3

It looks like the id of the stunned phase is now 5888, and 5887 is it's awoken state

Mikearche our savior


no longer support encoder(prompt) + decoder computation(like ORCA)?

Hi vllm team.
In v0.1.0, There is an implementation of the functionality that when a new prompt comes during decoding, operations except attention are processed in a same batch.
https://github.com/vllm-project/vllm/blob/67d96c29fba9b72cb4c4edbc26211c208a00ebdd/vllm/model_executor/layers/attention.py#L121
in v0.2.7, It seems like the prompt and decoing computation are separated.
https://github.com/vllm-project/vllm/blob/2e0b6e775756345aa1d39f772c186e00f8c29e92/vllm/model_executor/layers/attention.py#L101
Is this feature no longer supported?
Thanks!

I have the same query, it means I need to pause my generation when I get a new request. The longer the prompt, the longer the pause time.


Update CONTRIBUTING.md

test 1

🐙 This pull request conflicts with the target branch and needs rebase.
Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a "draft".


Implement LRU caching for CheckAws methods

Implement LRU caching for CheckAWS methods.

Implemented in 1.2.2


Build instructions

Addresses #1
@orbeckst does this look fine?

Please directly add the equivalent section to the other repos:

becksteinlab/conda-gromacs-4.6.7#1
becksteinlab/conda-gromacs-5.1.2#7

Directly submit to master, no need for PR.


[webview_flutter] WebView content flash(partly disappeared) when use gesture to pop page on iOS when AppBar's elevation set to 0

WebView content flash(partly disappeared) when use gesture to pop page on iOS when AppBar's elevation set to 0 like this:

Please note the first operation， the content party disappear when i start to swipe.
flutter doctor:
± flutter doctor -v
[✓] Flutter (Channel stable, 2.0.3, on macOS 11.2.3 20D91 darwin-arm, locale
    zh-Hans)
    • Flutter version 2.0.3 at /Users/tianshuxin/Library/flutter
    • Framework revision 4d7946a68d (5 weeks ago), 2021-03-18 17:24:33 -0700
    • Engine revision 3459eb2436
    • Dart version 2.12.2

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /Users/tianshuxin/Library/Android/sdk
    • Platform android-30, build-tools 30.0.3
    • ANDROID_SDK_ROOT = /Users/tianshuxin/Library/Android/sdk
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.4, Build version 12D4e
    • CocoaPods version 1.10.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio
    • Android Studio at /Applications/Android Studio Preview.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build <IP_ADDRESS>+0-b77-7246554)

[✓] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6915495)

[✓] VS Code (version 1.55.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.21.0

[✓] Connected device (2 available)
    • iPad (mobile) • 6879fa01e4fbb49887932bd0ec3ddc582ac74aa6 • ios
      • iOS 14.4.2
    • Chrome (web)  • chrome                                   • web-javascript
      • Google Chrome 90.0.4430.85

• No issues found!

my code :
void main() {
  runApp(MaterialApp(
    home: TestPage(),
  ));
}

class TestPage extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text("TestPage"),
        elevation: 0,
      ),
      body: Column(
        children: [
          Expanded(
            child: WebView(
              initialUrl: "https://flutter-io.cn/",
              javascriptMode: JavascriptMode.unrestricted,
            ),
          ),
          GestureDetector(
            child: Container(
              color: Colors.blue,
              height: 60,
            ),
            onTap: () {
              Navigator.of(context).push(
                CupertinoPageRoute(
                  builder: (_) {
                    return TestPage();
                  },
                ),
              );
            },
          )
        ],
      ),
    );
  }
}

@tsx1453
What exactly are we looking at in this issue ? I couldn't notice the issue from the video you posted.

@darshankawar
This is the slow-motion video recorded on the screen above. You can see that one frame of the screen is missing.

flutter doctor -v
[✓] Flutter (Channel master, 2.3.0-1.0.pre.143, on Mac OS X 10.15.4 19E2269
    darwin-x64, locale en-GB)
    • Flutter version 2.3.0-1.0.pre.143 at
      /Users/dhs/documents/fluttersdk/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision aecd5e0302 (2 days ago), 2021-04-28 00:53:57 -0300
    • Engine revision 92ef7b59c8
    • Dart version 2.14.0 (build 2.14.0-48.0.dev)

[!] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.3, Build version 12C33
    ! CocoaPods 1.9.3 out of date (1.10.0 is recommended).
        CocoaPods is used to retrieve the iOS and macOS platform side's plugin
        code that responds to your plugin usage on the Dart side.
        Without CocoaPods, plugins will not work on iOS or macOS.
        For more info, see https://flutter.dev/platform-plugins
      To upgrade see
      https://guides.cocoapods.org/using/getting-started.html#installation for
      instructions.

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] VS Code (version 1.55.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.21.0

[✓] Connected device (4 available)
    • Darshan's iphone (mobile)  • 21150b119064aecc249dfcfe05e259197461ce23 •
      ios            • iOS 14.4.1
    • iPhone 12 Pro Max (mobile) • A5473606-0213-4FD8-BA16-553433949729     •
      ios            • com.apple.CoreSimulator.SimRuntime.iOS-14-3 (simulator)
    • macOS (desktop)            • macos                                    •
      darwin-x64     • Mac OS X 10.15.4 19E2269 darwin-x64
    • Chrome (web)               • chrome                                   •
      web-javascript • Google Chrome 90.0.4430.93

! Doctor found issues in 1 category.

Without additional information, we are unfortunately not sure how to resolve this issue.
We are therefore reluctantly going to close this bug for now.
Please don't hesitate to comment on the bug if you have any more information for us; we will reopen it right away!
Thanks for your contribution.
Could everyone who still has this problem please file a new issue with the exact description of what happens, logs, and the output of flutter doctor -v.
All system setups can be slightly different, so it's always better to open new issues and reference related issues.


Form doesn't respect colCount property and always shows one column.

Issue Type

bug report
Description

The issue is related to Form
Steps to Reproduce

See demo and issue title
Current Behavior
Expected Behavior
Demo

https://stackblitz.com/edit/devextreme-react-1ubd9e?file=index.js
Environment Details

devextreme version: 18.1.6-pre-18220
devextreme-react version: 18.1.5-alpha.9
react version: 16.4.1

Hi,
It's expected behavior. You can use the colCountByScreen option to define colCount for the xs screen size. Another solution is to check that a screenByWidth callback doesn't return the xs screen size.
I've modified your demo to demonstrate a possible solution.


Revisit map config builder method naming

See https://github.com/ably/ably-asset-tracking-android/pull/43#discussion_r531263014.
┆Issue is synchronized with this Jira Task by Unito

We've never moved this issue forwards, so I think this API is now baked in.


npm build failed with nodejs >=12

Hi,
ttyx seems not compatible to nodejs >= v12:
gyp ERR! node -v v12.13.0
gyp ERR! node-gyp -v v5.0.5

and drops errors:
/home/nuts/.cache/node-gyp/12.13.0/include/node/v8config.h:311:3: note: in definition of macro ‘V8_DEPRECATED’
  311 |   declarator __attribute__((deprecated(message)))
      |   ^~~~~~~~~~
make: *** [binding.target.mk:105: Release/obj.target/binding/src/binding.o] Error 1
make: Leaving directory '/home/nuts/ttyx/node_modules/ref/build'
gyp ERR! build error
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/usr/lib64/node_modules/npm/node_modules/node-gyp/lib/build.js:194:23)
gyp ERR! stack     at ChildProcess.emit (events.js:210:5)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:272:12)
gyp ERR! System Linux 4.19.44-gentoo
gyp ERR! command "/usr/bin/node" "/usr/lib64/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /home/nuts/ttyx/node_modules/ref
gyp ERR! node -v v12.13.0
gyp ERR! node-gyp -v v5.0.5
gyp ERR! not ok
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>install: `node-gyp rebuild`
npm ERR! Exit status 1

Working with node 20, so closing this.  'ref' and 'ffi' were problematic and are no longer needed.


Creating code block in editor using Chrome browser corrupts document

When editing a document in the Ghost editor using Chrome on Ubuntu 18.04 and macOS, inserting a code block (```), and then deleting text, the document becomes corrupted and ctrl+z doesn't work to undo the damage.
This does NOT occur for me when doing the exact operation in Firefox on Ubuntu 18.04. See the screencast video linked below for an example (the only step that can't be seen is my hitting Del right before the end).
http://ghostdemo2.s3-website-us-east-1.amazonaws.com

When editing a document in the Ghost editor using Chrome on Ubuntu 18.04 and macOS, inserting a code block (```), and then deleting text, the document becomes corrupted and ctrl+z doesn't work to undo the damage.
This does NOT occur for me when doing the exact operation in Firefox on Ubuntu 18.04. See the screencast video linked below for an example (the only step that can't be seen is my hitting Del right before the end).
http://ghostdemo2.s3-website-us-east-1.amazonaws.com

@dbclinton unfortunately I'm not able to reproduce following the same steps shown in your screencast video when using Chrome on macOS. When the problem occurs do you see any errors in the web inspector console?

@dbclinton unfortunately I'm not able to reproduce following the same steps shown in your screencast video when using Chrome on macOS. When the problem occurs do you see any errors in the web inspector console?

I just tried it again (on Ubuntu 18.04 - Quincy is the one who encountered it on macOS) with two different documents and got the same error. Nothing showed up in the dev console. This time it happened after selecting a paragraph below the code block and hitting Del.


Add pending pods metrics for kube_scheduler

What does this PR do?
This PR adds the scheduler_pending_pods metric as pending_pods
Motivation
This metric was added in Kubernetes 1.15  but this was never added to the integration.
Changelog entry: https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.15.md#added-metrics
Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] PR title must be written as a CHANGELOG entry (see why)
[ ] Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
[ ] PR must have changelog/ and integration/ labels attached

@L3n41c Hey! Thanks for the review. I had to resolve some conflicts before merging, can you ✅  again, please? Thanks!


Add tpdp.SpellEntry.spellRangeType to evaluate spell's range

Can I add this code to tpdp or is it already implemented elsewhere? I need to check whether spell is within a range or should enemy NPC approach.
	py::class_<SpellEntry>(m, "SpellEntry")
		...
		.def_readwrite("spellRange", &SpellEntry::spellRange)
		.def_readwrite("spellRangeType", &SpellEntry::spellRangeType)
		.def("get_spell_range_exact", [](SpellEntry &spEntry, int casterLevel, objHndl &caster)->int
		{
			return spellSys.GetSpellRangeExact(spEntry.spellRangeType, casterLevel, caster);
		})
		;

You can add it, but note that spellRangeType has an enum type, so I think you'd also have to expose the enum values to be able to use it in python.


Show if a package is archived

The repo API tells us if a repo has been marked as archived/read-only by the repo owner.
https://github.com/Ch0uti/ChouTi is a known archived repo in our index.
In a discussion with Dave we believe it's best that we don't completely exclude these from the index, but is important that we highlight this information to users of the site to make a more informed decision.
Changes:

[ ] Record a archived field in the repositories table and populate it from the GitHub API call.
[ ] Reduce the package's search score (-5) if it's archived (?? - I've made this requirement up)
[ ] Display whether a repository is archived on the Package page.

This does likely link up to the "extra package metadata" conversations which are ongoing (#435) as people may wish to label their repo as archived from there too. I believe this is an acceptable interim solution which can be evolved to include that at a later date.

In a discussion with Dave we believe it's best that we don't completely exclude these from the index, but is important that we highlight this information to users of the site to make a more informed decision.

Just to clarify my position on this a little. I think it's certainly something we could highlight on the package page, but I don't think it's a particularly pressing issue. It's good to log it and I agree it should be done at some point, but I don't think we're trying to completely replicate every bit of metadata on Package pages, just the highest value bits.
If it's the case that someone gets to the GitHub page for this package and realises it's archived, that's OK. Especially while there's only a small number of archived packages in the index.

@daveverwer - is this still something you're not fussed about including at this moment in time? or would you be happy for me to pick it up?
I think now that the GraphQL work is all done this should be fairly easy 🙏  (If not slightly frustrating when I have to request yet another db dump from you 😛)

I think it's still a fairly low priority, but if you'd like to pick it up then it'd be great to have!
In terms of the front end, I think we should load this into the first bullet point on the package page. Where it currently says:

In development for 5 years, with 680 commits and 10 releases.

It should say something like this for archived packages:

No longer in active development. The package author has archived this package and the repository is read-only. It had 680 commits and 10 releases before being archived.

@finestructure do you have any implementation guidance?

With respect to implementation, pulling in the data is hopefully easy as it should be just another field in the GraphQL query (there's a link to the explorer near the query method to check it out beforehand). It'd be good to fetch an updated json for the fixture in the test.
Then routing it through to the db and PackageShow+Model should hopefully be quite straightforward. I believe you mentioned having trouble running ingestion locally, @Sherlouk , so please give a shout if that remains to be an issue. I fixed an issue yesterday where the absence of the metrics push gateway led to an error being thrown, so perhaps that was what derailed you.

Thanks Sven - aye I managed to get past the metrics issue (just commented out that part of the troublesome code) but ran into issues further downstream but will give you a shout with specifics if I can't get past it this time!


ROUND_HALF_TO_EVEN and ROUND_HALF_TO_ODD not working properly

Describe the bug
Seems that when it comes to negative values rounding mode ROUND_HALF_TO_EVEN and ROUND_HALF_TO_ODD works
just by rounding half to negative infinite -1.005 to -1.01, -1.015 to -1.02 and so on.
To Reproduce
val stringNum = "-1.005"
val bd1 = stringNum.toBigDecimal()
println("number is: $bd1")
println(
    "kotlin BD: " + BigDecimal.fromBigDecimal(
        bd1,
        DecimalMode(20, roundingMode = RoundingMode.ROUND_HALF_TO_EVEN, scale = 2)
    )
)
println("java BD: " + java.math.BigDecimal(stringNum, MathContext(3, java.math.RoundingMode.HALF_EVEN)))

Expected behavior
RoundingMode.ROUND_HALF_TO_EVEN, scale 2
In my understading in this mode
-1.005 should round to -1.00 because 0 is closer even number
but in this case the result is -1.01
-1.015 should round to -1.02 because 2 is closer even number and the result is correct
1.005 should round to 1.00 because 0 is closer even number and the result is correct
1.015 should round to 1.02 because 2 is closer even number and the result is correct
Platform

JVM

Additional context
I belive this is a bug because java java.math.RoundingMode.HALF_EVEN works as expected.
This seems not to be the case with positive values.

Thanks for reporting, a pull request with a fix would be highly appreciated!

I created a pull request with some tests. Please check if everything is correct,

Fixed in #270


Add rules to support for ECMA-402

I would like rules that reports the features added in ECMA-402.
For example, Intl.Segmenter is not available in versions prior to Node.js v16. It may be worth to report them.

The specifications for 2017 and beyond appear to be listed in the following markdown
https://github.com/tc39/proposals/blob/main/ecma402/finished-proposals.md
However, for earlier specifications, we would need to check the respective specifications.

I checked specs up to es2016.
It looks to me that the only change before es2017 was the addition of Intl.getCanonicalLocales in es2016.


How to deactivate zoom?

Greetings,
How can I deactivate the zoom for images in the gallery?

Hi, no options out of the box allows you to do that, but you could specify a full screen transparent overlay with the overlay attribute on each images, it will block touch input on every screen without blocking swiping.

Can you please give me an example?

Something like :
class YourGalleryComponent extends Component {
  render() {
    const data = [
      {
        id: 'first image',
        image: require('./yourImage.jpg'),
        thumb: require('./yourImageThumb.jpg'),
        overlay: <Overlay />
      },
    ];

    return <Gallery data={data} />;
  }
}

const Overlay = () => (
  <View style={{ position: 'absolute', top: 0, left: 0, width: Dimensions.get('window').width, height: Dimensions.get('window').height }} />
);

Thanks, I managed with:
            <View
			style={{
				position: 'absolute',
				bottom: 0,
				left: 0,
				right: 0,
				top: 0,
				backgroundColor: '#00000000'
			}}
		/>


Tenant domain and environment name are mixed up

Hi,
It seems that <your tenant domain> and <environment name> are mixed up in the section: https://docs.microsoft.com/en-gb/dynamics365/business-central/dev-itpro/developer/devenv-develop-connect-apps#exploring-the-apis-with-postman-and-basic-authentication
It says this: https://api.businesscentral.dynamics.com/v2.0/<environment name>/<your tenant domain>/api/v1.0
It should be this: https://api.businesscentral.dynamics.com/v2.0/<your tenant domain>/<environment name>/api/v1.0
Issue originally solved by: https://stackoverflow.com/a/59563728/12768536

Document details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e026c87e-6bbe-9e7c-5ecc-e6f2943e2655
Version Independent ID: 81cb7f00-6d48-4d29-b47c-b9bc36ad87d8
Content: Getting Started Developing Connect Apps for Dynamics 365 Business Central - Business Central
Content Source: dev-itpro/developer/devenv-develop-connect-apps.md
Service: dynamics365-business-central
GitHub Login: @SusanneWindfeldPedersen
Microsoft Alias: solsen

Yup, indeed. I had the same issue today... Can this be fixed since this is a minor change and this issue is already open for 3 months now

Thanks for the feedback and for your patience, this will be fixed with the next refresh of the docs.


block non-public pages until profile is loaded

I think this fixes #1237
In trying to reproduce that, I found an issue where the page breaks if the profile hasn't finished loading by the time it mounts. This fixes that issue, which I suspect was responsible for the original bug report.

I'm a little confused on how this PR deals with the email notification problem outlined in #1237
is this actually for #1344 ?

@elizzhao I believe this is related to the linked issue (see the original PR comment)

Ah I get it--thanks for clarifying!


Create odml.jsonld

@apdavison OR @jagru20 I think it is enough if one of you reviews this PR. whoever is faster ;)

@jagru20 feel free to merge (@apdavison that's okay, no?)

one more thing that I just noticed: shouldn't this PR go against the v4 branch?


[Docs] Add common mistakes page

I observed that newcomers (based on this repo issues and difficulties that people in my team have) tend to encounter the same 4/5 issue. Perhaps a "common mistakes", troubleshooting or something like that could be helpful. So here is a simple proposition :)
I divided this section in two parts, firstly, the problems that people have by not understanding enough Flow's type system, and secondly, flow current limitations.
I struggle to understand how the website is built, so I just added the page, feel free to show me the right direction to make this change work!
Lastly, I saw that there is a "tips" folder in the docs, perhaps this page would better belong there, however, I don't think it's published, so I preferred to add it to the more common lang folder.

IMO this is a great idea, sad it didn't get more eyes before. I'll try to import once the CI lets me

Thanks @mrkev, I do think that a lot of PR for doc improvements flight under the radar, which is quite sad, the community being pretty motivated on that!
Regarding this PR, be wary, I created a page, without importing it in anywhere (or perhaps it's automatic?), so you might have to do it yourself, or point me to the right direction!

I'll be completely honest, I'm well acquainted with how the website works. I think it's automatic though?

Hey @mrkev, is there anything you'd like me to do to make this happen? :)

I pushed again! Sorry, git didn't get it when I renamed the file :'( I added examples about closures, and switched all the titles to questions. It should be better, and more beginner friendly!

Thanks for the PR! And sorry for the delay in my review!

I'm going to land this diff tomorrow! I expect to make minimal edits, but I like what you have here!

@AugustinLF: I ended up making it into it's own guide, so you can find it at flow.org/en/docs/ and click FAQ!

Thanks a lot, pretty excited that we got this merged 😃


Prerenderd HTML dosen't get invalidated

After deployment pretended HTML doesn't get invalidated. I checked the invalidation in CloudFront, only assets (/Icons, /fonts) get invalidated.

Thanks for reporting, I will try to reproduce this behaviour with some of our examples later today.
Assets served from the prefix _next/static/* should not be part of any invalidation.

Thanks for sharing!
The invalidations seem intentional here because these are assets uploaded from the public/folder I guess.
While it is a valid use case to serve assets from the public folder, I recommend importing assets from the code, so that Next.js can optimize (append a hash to the filename) them for usage together with a CDN.
// Icon.js
import noEntryIcon from './assets/icons8-no-entry.svg`

export default function MyIconComponent() {
  return <img src={noEntryIcon} />
}

Doing it this way, Next.js will output the asset as something like _next/static/.../icons8-no-entry.2fdhad82.svg which is an immutable route thanks to the unique hash 2fdhad82 appended to the filename.
So when the file changes, Next.js will append a new hash, which also produces a new route on the CDN.

However what is bad here, is that we don't check if the content of the file has actually changed when doing a deployment.
So when I have a file public/favicon.ico and I don't change the file between two deployments I would expect that no invalidation is issued for this file.

Looking at the screenshot, the only actual route that gets invalidated is /404.
Are the other routes served by Lambdas (SSR) is that the bug you are describing here?

Thanks for your detailed reply. The point with the assets is fair. We definitely gonna change that.  However, the problem that we're facing is that the pre-rendered Html doesn't get invalidated, which results in no changes apply on our website until I manually trigger an invalidation for all directories in CloudFront.

I've just been having a brief look into your code. In the create-invalidation.js you limit the paths to 15 per invalidation and then invalidate in batches. Unfortunately, for me, there is always just one invalidation happening. Could this be a possible issue?

Yes, that's my assumption what is happening here 👍
I also left a todo in the code, because we never actually checked a case with more than 15 invalidations.
https://github.com/dealmore/terraform-aws-next-js/blob/ad7047c94fa5025e448056361de8fa5cd65b42f4/packages/deploy-trigger/src/create-invalidation.ts#L9

Ok. So, just to clarify (I'm new to next-js), is it considered best practice to load all assets from the code via webpack? I played around with a few libraries, tried next-images which seems to work but didn't find any for fonts. Also, will this be working with nextjs 10 image objects?

As for all in software it depends 😄
Loading assets via webpack is recommended for assets that you know your application needs at build time, Things like icons, css-background-images or webfonts fall into this category.
Importing them is not limited to JavaScript code. For example you can also load webfonts directly from your CSS:
@font-face {
    font-family: 'Montserrat';
    font-style: normal;
    font-weight: 500;
    src: local(''),
      url('./fonts/montserrat-v15-latin-500.woff2') format('woff2')
}

I think you don't need any additional configuration, since loading assets is already built-in in Next.js (and the underlaying webpack configuration). The important thing here is to use relative paths (./fonts/montserrat-v15-latin-500.woff2) instead of absolute paths (/fonts/montserrat-v15-latin-500.woff2) so that webpack can check for the referenced files on your local filesystem at build time.

Well, for sure it always "depends", however, when you're using a framework it is usually opinionated and there are best practices. The next.js documentation explicitly advises  to put build time assets in the public folder:
https://nextjs.org/docs/basic-features/static-file-serving
As far as I read it from the documentation the next-jst10 next/image component also relies on images are stored in the public folder, however, I might be wrong here, I'm not a frontend dev.


Document example for node and machine annotations

Signed-off-by: Waleed Malik<EMAIL_ADDRESS>
What type of PR is this?

/kind documentation
What this PR does / why we need it:
Document example for node and machine annotations in output.tf for all the providers. This helps us stay consistent.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

NONE

/approve
/lgtm


Feature Request: Native macOS notifications with song information

OS: macOS Sierra 10.12.6
Maybe this is already a feature that I just need to enable but it would be nice to get a notification whenever a new song comes on. Or at least have an option to trigger a notification displaying Artist and Track, would be extra nice to display thumbnail of album artwork but thats just eye candy. I frequently use the skip and pause/play keys on my keyboard and it would be nice to see name/artist of song coming on while cycling through music this way.

You can enable notification in your Google play music settings

@MarshallOfSound are you sure? If so can you point me where this setting is at? I'm looking at the desktop settings for the macOS client and don't see this anywhere.

Desktop notifications are under standard Google Play settings, not desktop settings.

@jostrander Thank you, for some reason I figured the functionality was added by this project, not a part of Google Music itself. Thanks!


support specifying both image and code in wsk CLI

In some cases it is useful to augment the standard runtime image (e.g., openwhisk/nodejs6action) with additional binaries (e.g., installation of a certain library, such as opencv). In order to do so and still take advantage of 'standard' lifecycle management of the action code itself, it is possible today to use the REST API, specifying kind=blackbox with custom image as well as code (plain text or 'binary' -- base64-encoded zip).
It would be great to enable this option in the CLI too, e.g.:
$ wsk action create --image mydockerhubaccount/mynodejsactionimage myaction.zip

(Note: can consider reusing the "--docker" flag)
related to #1927

Closed by https://github.com/apache/incubator-openwhisk/commit/9c1f77fdb1e4a7339634434dc90c45026d6a43d2.


Add Numeric rule

Closes #55.

It seems isnumeric() is not what we really need. There is new commit in the master branch which includes util functions in vlidator/utils.py it can be helpful for this task :)

Hey @bsoyka , are you still up for this?

You can take it if you'd like, @iko1133. If you want it I'll close up this PR.

If you are not going to finish it, I'll take it :)

Go for it! Closing this now.


Enable/Disable Bluetooth connection

I don't know if the API already supports it, but it would be nice to have the ability to enable/disable the bluetooth connection via the API.

@JellevdK Yes we will do that. Thank you for the request!


Jsonable is dead, long live Jsonable!

This is the same change as draft #5681, slightly scaled back to reduce noise, plus incorporating some feedback from @anthony-murphy.
The changes are:

The flawed Jsonable and Serializable types are removed.
The useful AsJsonable and AsSerializable types have been renamed Jsonable and Serializable.

Separately, I went ahead and converted Map's get/set/wait to Serializable.  Doing so uncovered a second place we were passing storing non-serializable types in a SharedMap.  With two legit bugs and zero false positives, I'm pretty sold on the new Serializable at this point.
(However, if I'm wrong, we can always go with plan B of using 'any', since making the API more permissive is a non-breaking change.)
@CraigMacomber - FYI.

Thanks @ChumpChief !

Happy to see this merged!


"Mănești" is listed in the drop-down menu

Description:
"Mănești" is listed in the drop-down menu alongside its corresponding county and commune, according to the law
Precondition:
The website is up an running.

Step 1
Type "Mănești" in the search bar.

Expected results
The location is listed in the drop-down menu as "Mănești, Argeș (Cuca)".


[feat] Adding context propagation to net/http server instrumentation

Hi,
This PR attempts to add context propagation to the net/http server instrumentation.
We do it by iterating over the buckets of the incoming request header map and trying to find the "traceparent" header.
This was tested with Go versions 1.12-1.19.
Our test environment consisted of instrumented Python application that sends a request to instrumented Go http server.
The produced trace looks like the following:

We would love to get your feedback on this.
Thanks!

also the redundant empty span removed is due to the removal of the net/http.(*ServeMux).ServeHTTP symbol from the functions to instrument as also mentioned by https://github.com/open-telemetry/opentelemetry-go-instrumentation/pull/86

Ah I see. Is that necessary for context propagation to work in this change?

also the redundant empty span removed is due to the removal of the net/http.(*ServeMux).ServeHTTP symbol from the functions to instrument as also mentioned by #86

Ah I see. Is that necessary for context propagation to work in this change?

Is it cleaner to keep both function names in this PR so the output of the test remains the same, and I can update the other PR after this is merged in? That way we separate concerns, because I don't think the extra empty span has an impact on this one (though I could be mistaken, I've been working on a few different branches of branches lately).

Is it cleaner to keep both function names in this PR so the output of the test remains the same, and I can update the other PR after this is merged in? That way we separate concerns

Yeah that's what I was wondering. if it's relevant to this PR, we can keep it, but otherwise @oxeye-gal can you remove that change so we don't duplicate the work?

Hey @oxeye-gal - this PR needs rebasing after we merged ARM support on #82. I’m happy to help do that if you would like us to.

@MikeGoldsmith seems like the build fails again due to the added Request.Header offset, what is the correct way to do it? thanks again for the help!

After you've updated the offsets, you'll need to update the offsets.json. This can be done using make docker-offsets.

I have added the new field to offsets-tracker, I hope this fixes it @MikeGoldsmith

We're having hard time with this one 👎🏻  I'll give it a go too

@open-telemetry/go-instrumentation-approvers this is ready for another review 👍🏻


Fails to parse with 2-3 queens. Move "Qe1f2"

Fails to parse with 2-3 queens. The problem string is "Qe1f2".
Here is the move: https://lichess.org/pz8W3CdJ#118
To debug:

set breakpoint here: https://github.com/freeeve/pgn/blob/v1/pgn.go#L187
for condition: black == "Qe1f2"

The problem seems to be at the bottom of your findAttackingQueen method. Returns error ErrAmbiguousMove (pgn: ambiguous algebraic move).
Captures of length 5 seem to work fine:

Q3xh2
Qexg3
Qde3+

Thanks for the report!


DATAJDBC-260 - Fix links in the jdbc documentation

This fixes some links in the documentation.
Jira Link

Merged. Thanks.


build bootstrap in esm

I continue my todo list for v5.
Our main dist file will be available as a module ~and next step we'll have to build our plugins in ESM too~.
Not sure about building our modules in ESM too because they are available separately.
What's add for our users ?
use Bootstrap as a module in their browser
<script type="module">
  import { Tooltip } from './bootstrap.esm.min.js';

  window.addEventListener('load', () => {
    Array.from(document.querySelectorAll('[data-toggle="tooltip"]'))
      .map((tooltipNode) => new Tooltip(tooltipNode))
  })
</script>

And bundlers will load the ESM version because we added module in our package.json

Made a few tweaks and rebased this.
How about the docs? We need to list this and have a recipe for its use.


⚠ Bofrost.de has degraded performance

In 54cbc0c, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 721 ms

Resolved: Bofrost.de performance has improved in f0bcd64 after 9 minutes.


require C99 for header tests

See: https://github.com/KhronosGroup/OpenCL-SDK/issues/58#issuecomment-1259355455
Would requiring C99 explicitly help to resolve this issue?
If it does, should we require C99 for all parts of this project, or only for the tests?  Currently, this PR only requires C99 for the tests.

My only question here derives from my lack of knowledge of cmake, and how projects including other cmake project (like the sdk or the loader) would react if they are build with other versions of the standards, but include this which specifies a precise version. @MathiasMagnus would know I assume.

@Kerilk

...how projects including other cmake project (like the sdk or the loader) would react if they are build with other versions of the standards...

It depends... (but I don't see a scenario where this could ever bite.) In the spirit of teaching to fish, here's a full answer.
<on_cmake_variable_scoping>
The change proposed here sets the global defaults for language standards for targets that don't explicitly state what they should be using. It sets variables, and thus follows ordinary CMake variable scoping. (Functions and directories (meaning add_subdirectory()) introduce new scopes. Much like taking an arg by value in a function, even if something was set outside, changes to these global variables are only visible to things inside the directory and under. Setting it in the tests folder means that the change effects only the OpenCL Headers tests. It won't leak to consumers, no matter if they consume it through a package config file (an installation of the headers/SDK) or via making it a part of the their build (recursing into the source tree using add_subdirectory()). The OpenCL::Headers target was defined in one folder up.
<on_cmake_variable_scoping/>
<self_proclaimed_pro_tip>
If you don't like reasoning about global variables in C/C++ code, you probably don't like it in CMake either. It's possible to get it right (like here), but it's easy to get it wrong. Without going into a rant on all the occurences in the wild, I generally advise against "messing with the defaults". Modern CMake however favors using targets instead of variables. I personally would bump cmake_minimum_required(VERSION 3.0) to 3.1 (we already have that for the Loader, so it's hard to get around it anyway) and instead of setting the default for all targets, inside add_header_test add it to the targets we intend to:
set_target_properties(${TEST_EXE}
  PROPERTIES
    C_STANDARD 99
    C_STANDARD_REQUIRED ON
    CXX_STANDARD 11
    CXX_STANDARD_REQUIRED ON
)

These properties take their defaults from the similarly named CMAKE_ prepended variables. If there is a convenient way to set the properties, I'd always go that way. I'd reserve using the variable form when targets are scattered throughout a multitude of folders. (And even then, I'd use an INTERFACE target, OpenCLHeadersTestsCommon and hook the property on that and link to it where needed.)
The rule of thumb I read from others, was that "anything starting with CMAKE_ is for the user to set, not the project." In cases like lists, such as CMAKE_PREFIX_PATH and CMAKE_MODULE_PATH one may get away with appending/prepending to it, but it's a slippery slope.
<self_proclaimed_pro_tip/>
At the end of the day it's preference, and the proposed change given the strict relation to the properties it sets is equivalent to what I'd do.

Is this PR ready for review @bashbaug ?

@MathiasMagnus Thanks a lot for the great answer!

I found this one looking through old PRs.  Is this something we should pursue?  If not, I'll just close it.  @MathiasMagnus

@MathiasMagnus heads up, I made one change to your suggested fix, since I think it had a copy-paste error.  Otherwise, I think this one is ready to go.


Bare domain won't resolve

Tried visiting - http://7fmjpcuuzf54hw18bsgi3zihzyh4awseeuq5tmojefaezjbd64cy/ from Firefox and Chromium but the browser wants to add .home and .lan respectively.
http://pknames.p2p.7fmjpcuuzf54hw18bsgi3zihzyh4awseeuq5tmojefaezjbd64cy/ did work from both however so I'm proposing to put that URL first in the docs.

I tried it on Windows, too. Set a custom DNS to my Proton VPN settings.
But It works only if you add a . at the end of the domain:
http://7fmjpcuuzf54hw18bsgi3zihzyh4awseeuq5tmojefaezjbd64cy./
The subdomain http://pknames.p2p.7fmjpcuuzf54hw18bsgi3zihzyh4awseeuq5tmojefaezjbd64cy/ works also for me.
I tried to add the explicit absolute domain root to my A entry, But no change. Still need . at the end of the root domain on Windows.
On Linux everything is fine.

I tried it on Windows, too. Set a custom DNS to my Proton VPN settings.
But It works only if you add a . at the end of the domain:
http://7fmjpcuuzf54hw18bsgi3zihzyh4awseeuq5tmojefaezjbd64cy./
The subdomain http://pknames.p2p.7fmjpcuuzf54hw18bsgi3zihzyh4awseeuq5tmojefaezjbd64cy/ works also for me.
I tried to add the explicit absolute domain root to my A entry, But no change. Still need . at the end of the root domain on Windows.
On Linux everything is fine.

I can confirm this on my Windows VM. Browsers only open http://7fmjpcuuzf54hw18bsgi3zihzyh4awseeuq5tmojefaezjbd64cy./ on Windows.

Browser resolution is tricky. http://7fmjpcuuzf54hw18bsgi3zihzyh4awseeuq5tmojefaezjbd64cy./ feels like the best way forward to make it compatible. @weex this should work for you too, doesn't it?

Merged the fix. Closing this. Let me know if you have any other issues.


Echoregions functionality notebook

A notebook describing the different attributes and methods of the objects in echoregions (regions & lines).

[ ] UML diagram
[ ] regions functionality
[ ] lines functionality

Geared toward technical people who would want to modify it/extend it.

Closing this issue since it has been captured in other issues. We will eventually need comprehensive documentation type notebooks.


[VS Code] Only the 'http' scheme is allowed for proxies.

Error:
Only the 'http' scheme is allowed for proxies.
Steps to Reproduce:

Version Data

extensionName
VSLS

extensionVersion
0.3.577

protocolVersion
2.2

applicationName
VSCode

applicationVersion
1.26.1

platformName
Linux

platformVersion
4.15.0-33-generic

@mfsirilo , are you seeing any error?

@mfsirilo Yeah, currently we support only http proxies, since we use .NET Core, and .NET Core doesn't support https proxies yet, my understanding was this is not a widely used scenario, even browsers dont support it yet.. What is your specific use-case?

@Priya91 Shoukd we consider updating this error message to clarify that users need to update their environment variable to use “http” instead of “https”?

@lostintangent, The user mentions that they want https, and not http, it doesn't seem to be a case of incorrectly using https. Although i agree that we can throw an error message that the env variable should have http scheme..

I'm seeing this error even though I am using http :
http://www-proxy-uk.mycompany.com:80

@adamh128 Can you attach your logs..

I'm wanting to use Crawelra and it seems as though they use HTTPS. :(

@adamh128 Can you attach your logs..

Where do I find the logs?

I figured it out :)
livesharelogs.zip

@adamh128 Hey! thank you for attaching the logs. @Priya91 would you take look?

Any progress on this defect I also found error on my CentOS 7 server and cannot use it to shared as server-based live share session :(

@pombuppa if you used an url like "https://ip-address:port" for proxy, it will not connect. .NET Core and many browsers only support http proxies, https proxies are not yet widely supported.

#1602

Not able to find this error message anymore. Closing as fixed.


Correctly format typed self in function arguments

This closes https://github.com/nrc/rustfmt/issues/153.

@marcusklaas thanks for all the patches! You've done a tonne of good work recently :-) Heads up that I'll be travelling next week, so might be a bit slower with reviews and merging.

Updated!

Wait, may be there is no need to skip it once we fix the span... Why do we need min_args = 2 for the other cases?

Should we consider merging this? It's not ideal, but at least fixes the underlying bug. To do it the proper way would be to address https://github.com/rust-lang/rust/issues/27522, which isn't trivial.
Until that happens, the comment for the self type is dropped. We could open a separate issue for that.

Yes, we should! (Sorry it took a while to get to).
@marcusklaas could you add a fixme comment referencing #27522 please? Then you can push this.


Bug fix 3.7/fix logger issues

Scope & Purpose
(Backport of https://github.com/arangodb/arangodb/pull/12140)

fix UB in syslog logger, with ident string going out of scope after openlog was called.
fix infinite recursion when printing error messages about invalid logger configuration.
fix sporadic use-after-free issue in logger shutdown

Enterprise companion PR: https://github.com/arangodb/enterprise/pull/499
Likely supersedes PR https://github.com/arangodb/arangodb/pull/12109.
Likely fixes https://arangodb.atlassian.net/browse/AR-60.

[x] Bug-Fix for devel-branch (i.e. no need for backports?)
[ ] Bug-Fix for a released version (did you remember to port this to all relevant release branches?)
[x] The behavior in this PR can be (and was) manually tested (support / qa / customers can test it)

Related Information

[x] There is a JIRA Ticket number: https://arangodb.atlassian.net/browse/AR-60

Testing & Verification
Unfortunately this needs manual testing.
http://<IP_ADDRESS>:8080/view/PR/job/arangodb-matrix-pr/10927/

http://<IP_ADDRESS>:8080/view/PR/job/arangodb-matrix-pr/10932/

Tests blue


HELP: display version numbers in builds

Closes #1043

@cosmos/cosmos-ui could use some help with the tests here. not sure how to properly mock electron.remote.app.getVersion() which i think is the issue.

Checkout https://github.com/cosmos/voyager/blob/develop/test/unit/helpers/electron_mock.js where we already mock several other properties of electron.


style: Reformat code & Apply spotless

Apply Spotless plugin to check and reformat style, check tasks will be exected when building.
Maybe we can add more custom rules.

For these larger PRs, it would help if the commits for the build script changes were isolated from the actual styling changes. You could also do like

build: xxx
style: xxx

As a pattern of commit messages to make it even easier to see. I have not gotten a chance to review this yet.

I run spotlessJavaApply once, only reformated by spotless with less changes.

Am I correct that running build now with a syntax violating will be stopped? So you must fix the error or run apply to resolve?

Build will be stoped if there is a syntax violation, you must correct it or just apply.


Fix draw_multiline_colors usage

In #74883, I fixed an inconsistency in draw_multiline_colors() for width < 0: if you passed the number of colors equal to the number of lines, then this did not work, unlike width > 0. But I did not pay attention to the fact that this worked when passing the number of colors equal to the number of points. The documentation says the following:

Draws multiple disconnected lines with a uniform width and segment-by-segment coloring. Colors assigned to line segments match by index between points and colors. When drawing large amounts of lines, this is faster than using individual draw_line() calls. To draw interconnected lines, use draw_polyline_colors() instead.

Since this works for width > 0 and draw_multiline* is analogous to draw_line, I suggest that the old behavior for width < 0 is wrong, the number of colors should be equal to the number of lines (or 1), not the number of points.
Note that this is inconsistent with draw_polyline*, in these methods the colors correspond to points, not segments (and you can use gradients).

An idea

multiline:
  colors.size() == 1 -- One color
  colors.size() == points.size() -- Points
  colors.size() * 2 == points.size() -- Lines

polyline:
  colors.size() == 1 -- One color
  colors.size() == points.size() -- Points
  colors.size() == points.size() - 1 -- Segments

I had an idea to allow the number of colors to be equal to the number of points to avoid breaking compatibility, but it's hard to do for width > 0 as there is a call to canvas_item_add_line in the loop in that case.
https://github.com/godotengine/godot/blob/fd4a06c51555904104b18494d0224f450d74fe2a/servers/rendering/renderer_canvas_cull.cpp#L1205-L1222
Closes #76973.

The documentation says the following:

Draws multiple disconnected lines with a uniform width and segment-by-segment coloring. Colors assigned to line segments match by index between points and colors. When drawing large amounts of lines, this is faster than using individual draw_line() calls. To draw interconnected lines, use draw_polyline_colors() instead.

Since this works for width > 0 and draw_multiline* is analogous to draw_line, I suggest that the old behavior for width < 0 is wrong, the number of colors should be equal to the number of lines (or 1), not the number of points.

Then these docs should be fixed / clarified. E.g. by changing:

Colors assigned to line segments match by index between points and colors.

to something like:

Each segment is defined by two consecutive points from [param points] array and a corresponding color from [param colors] array, i.e. i-th segment consists of [code]points[2 * i][/code], [code]points[2 * i + 1][/code] endpoints and has [code]colors[i][/code] color.

(more or less, rewording welcomed)

An idea
polyline:
colors.size() == points.size() - 1 -- Segments

Note this would require duplicating inner points so it would kinda end up being a multiline (a specific one, where each subsequent line starts at the end of the preceding one). In such case it might make more sense to draw it as actual multiline instead of a polyline with nearly half of its segments being zero-length. Anyway, seems of out scope of this PR. :upside_down_face:

Thanks!


build instruction for android 11

I found this ROM build for rpi4, https://github.com/omnirom/android_device_brcm_rpi4  from omnirom.org
can we have a similar build on jetson nano?

The instructions are targeting more or less a vanilla AOSP (Android Open Source Project) 10.
We might update it to Android 11 some day, but nothing we plan to do near-term.


Missing keyboard/input event on BACKSPACE

Hey there,
this keyboard works really nice in one of our applications but we are missing one thing:
When backspace is hit, there is no keyboard events (keydown, keyup, keypress) or a change event on the input element which makes it hard to detect changes in a underlying model value. We are using AngularJS and this breaks the databinding and forces to check the value of the input field on intervals. I would do the change and submit a pull-request if you welcome contributions.

Can you please try again?  Did some changes in the keyboard events.


Find a way to implement page trim in latex.

@elbotho https://mike42.me/blog/2016-01-how-to-arrange-pages-for-printing-and-cutting-in-latex is this part of what you are looking for?

This is quite a bit more complex than what we need I think.
We just need "3mm more" on each side of the page. (3mm is a guess until we know the printers requirements)
Answer should hide somewhere here:
https://tex.stackexchange.com/questions/181078/crop-and-bleed-marks
https://tex.stackexchange.com/questions/65170/what-is-bleed-and-how-do-i-achieve-it/65199#65199
https://tex.stackexchange.com/questions/19497/how-do-you-setup-a-tex-document-to-self-publish-a-book-online/130843#130843

This seems to work, so we can close it?

I think you are the one to decide that ;)

I remove page trim again for now.
Does not make sense for the downloadable version, will add manually for print-export or enable export with different settings like discussed in #120
(see 0a4c677fa92df2ead25e2eab9af9f47aeb579455)

@elbotho what is the status for the LMU wide print?

done as far as I can tell


Update displaynames-en.json

Changes are not visible in beta 8.
Was the request merged after building beta 8?

Yes, correct - I'll include this in the next beta.


chore(toast): update toast UI to use border instead of shadow

Description
We decided to refrain from using shadows with toasts because shadows don't give enough contrast with the underlying app surface for toast to stand out.
It is also challenging to replicate designer-proposed shadows consistently in iOS and Android due to platform differences in rendering shadows.
A border with 50% opaque primary color is used instead.
Designs: https://www.figma.com/file/erFfzHvSTm5g1sjK6jWyEH/Working-Design-System-Components?type=design&node-id=1287-1599&mode=design&t=FfkYhPWuxiEi75yJ-0
Context: https://valora-app.slack.com/archives/C0684TXDR3K/p1710432893238009?thread_ts=1708337311.090779&cid=C0684TXDR3K
Examples:

With border
With shadow (deprecated)

Test plan
CI
Related issues

Related to RET-1004

Backwards compatibility
Y
Network scalability
NA

I had the same feeling when Apple went from skeuomorphism to flat back in the days. But in the end, it went well. Let wait and see if this one could make it.


Hubot Spamming

So I had been doing some testing with a Hubot on a slack private message.  Now everytime I start hubot, it responds to the old conversations as though it were hearing the messages for the first time.
To reproduce use hubot with a slack adapter.  Set up some robot.hear and robot.respond statements.  Engage with hubot in a private chat, and get it to respond to your messages.
Now stop and restart hubot.  You will see that on restart everything it responded to in your previous chat will be responded to again.  This happens no matter how many times you start and stop hubot, even if you send it no further messages.

I think this issue should be directed to hubot-slack project at https://github.com/slackapi/hubot-slack

this can be about brain? i don't know how this brain works...
you try disable that?


Ethan: Watch moneyprotects.com

Ethan requests the watch of the watch_keyword moneyprotects\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

moneyprotects\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Spevacus in Charcoal HQ


Remove case studies from the home page

The case studies cards from the home page are no longer useful given that we have a more elaborate section in the book.


database/sql: data race on rows.releaseConn

Race builder says:
WARNING: DATA RACE
Write by goroutine 71:
database/sql.(*Stmt).Query()
go/src/database/sql/sql.go:1436 +0x6f3
database/sql.func·039()
go/src/database/sql/sql_test.go:1957 +0x1ea
testing.func·002()
go/src/testing/benchmark.go:418 +0x18f
Previous read by goroutine 61:
database/sql.(*Stmt).Query()
go/src/database/sql/sql.go:1435 +0x51f
database/sql.func·039()
go/src/database/sql/sql_test.go:1957 +0x1ea
testing.func·002()
go/src/testing/benchmark.go:418 +0x18f
runtime.goexit()
go/src/runtime/asm_amd64.s:2430 +0x0
reflect.ValueOf()
go/src/reflect/value.go:2081 +0xfc
database/sql/driver.int32Type.ConvertValue()
go/src/database/sql/driver/types.go:108 +0x80
database/sql/driver.(*int32Type).ConvertValue()
:12 +0xf9
database/sql.driverArgs()
go/src/database/sql/convert.go:68 +0xb3d
database/sql.resultFromStatement()
go/src/database/sql/sql.go:1310 +0x372
database/sql.(*Stmt).Exec()
go/src/database/sql/sql.go:1289 +0x31c
database/sql.(*concurrentTxStmtExecTest).test()
go/src/database/sql/sql_test.go:1689 +0x1a0
database/sql.func·035()
go/src/database/sql/sql_test.go:1750 +0xe2
Goroutine 71 (running) created at:
testing.(*B).RunParallel()
go/src/testing/benchmark.go:410 +0x46e
database/sql.BenchmarkManyConcurrentQueries()
go/src/database/sql/sql_test.go:1964 +0x496
testing.(*B).runN()
go/src/testing/benchmark.go:124 +0xf2
testing.(*B).launch()
go/src/testing/benchmark.go:216 +0x1d0
Goroutine 61 (running) created at:
testing.(*B).RunParallel()
go/src/testing/benchmark.go:410 +0x46e
database/sql.BenchmarkManyConcurrentQueries()
go/src/database/sql/sql_test.go:1964 +0x496
testing.(*B).runN()
go/src/testing/benchmark.go:124 +0xf2
testing.(*B).launch()
go/src/testing/benchmark.go:216 +0x1d0
http://build.golang.org/log/bfca7707a0ccb2dd15e8228eb5b97434c33d1143
There is a runtime error after that, but the race still can be true.

May be related to:
https://go-review.googlesource.com/#/c/2207/
It is the only recent change to database/sql.

Is there something I'm missing w.r.t. the line numbers in the race report?  They seem completely bogus.  E.g:
database/sql.func·039()
      /tmp/buildlet-scatch184358971/go/src/database/sql/sql_test.go:1957 +0x1ea

my line 1957 looks like this: loses0 := drv.closeCount

Is there something I'm missing w.r.t. the line numbers in the race report? They seem completely bogus.

Oh, my bad.  It was my tree that was completely bogus.  Please ignore that.

It's very strange.
goroutine 61 runs database/sql.(concurrentTxStmtExecTest).test()
But goroutine 61 was created from database/sql.BenchmarkManyConcurrentQueries()

It looks like another incarnation of a bug fixed upstream by:
http://llvm.org/viewvc/llvm-project?view=revision&revision=224702
Just ignore everything below runtime.goexit in stack of goroutine 61. Then it looks pretty consistent.

so it's time to update the race runtime again? or are you waiting until
it's closer to 1.5 release? Do you want me to file an issue to remind
us to update the race runtime?

I can't imagine why line 1435 and 1436 make race condition.
1426       rowsi, err = rowsiFromStatement(driverStmt{dc, si}, args...)
1427       if err == nil {
1428          // Note: ownership of ci passes to the *Rows, to be freed
1429          // with releaseConn.
1430          rows := &Rows{
1431             dc:    dc,
1432             rowsi: rowsi,
1433             // releaseConn set below
1434          }
1435          s.db.addDep(s, rows)
1436          rows.releaseConn = func(err error) {
1437             releaseConn(err)
1438             s.db.removeDep(s, rows)
1439          }
1440          return rows, nil
1441       }

minux, you may file an issue if you wish
updating race runtimes is difficult, I need to figure out what I want to do for race detector in this release cycle and then update the race runtime once

methane, does not make sense to me either
if it does not repeat on builders, let's assume that it is due to the heap corruption that caused the crash later

Here is another crash in the same place. Starts looking alarming.
fatal error: all goroutines are asleep - deadlock!
goroutine 1 [chan receive]:
testing.(*B).run(0xc20807a200, 0x0, 0x0, 0x0, 0x0, 0x0)
src/testing/benchmark.go:180 +0x91
testing.RunBenchmarks(0x6d2698, 0x785cc0, 0x9, 0x9)
src/testing/benchmark.go:312 +0x7ec
testing.(*M).Run(0xc20800a140, 0x7ade40)
src/testing/testing.go:495 +0x286
main.main()
database/sql/_test/_testmain.go:158 +0x28d
goroutine 295 [semacquire]:
sync.runtime_Semacquire(0xc2082dfca0)
src/runtime/sema.go:43 +0x2d
sync.(*WaitGroup).Wait(0xc2080445a0)
src/sync/waitgroup.go:132 +0x1e8
testing.(*B).RunParallel(0xc20807a200, 0xc208044580)
src/testing/benchmark.go:421 +0x497
database/sql.BenchmarkManyConcurrentQueries(0xc20807a200)
src/database/sql/sql_test.go:1964 +0x497
testing.(*B).runN(0xc20807a200, 0x3e8)
src/testing/benchmark.go:124 +0xf3
testing.(*B).launch(0xc20807a200)
src/testing/benchmark.go:216 +0x1d1
created by testing.(*B).run
src/testing/benchmark.go:179 +0x57
goroutine 487 [semacquire]:
sync.runtime_Semacquire(0xc208516cdc)
src/runtime/sema.go:43 +0x2d
sync.(*Mutex).Lock(0xc208516cd8)
src/sync/mutex.go:66 +0xfd
database/sql.(*DB).addDep(0xc208516cb0, 0x8007e7a80, 0xc20819b298, 0x63cf60, 0xc208502ba0)
src/database/sql/sql.go:370 +0x46
database/sql.(*Stmt).Query(0xc20829a000, 0xc2081b5f68, 0x2, 0x2, 0x0, 0x0, 0x0)
src/database/sql/sql.go:1435 +0x5f3
database/sql.func·039(0xc2082e6620)
src/database/sql/sql_test.go:1957 +0x1eb
testing.func·002()
src/testing/benchmark.go:418 +0x190
created by testing.(*B).RunParallel
src/testing/benchmark.go:419 +0x46e
goroutine 478 [chan receive]:
database/sql.(*DB).connectionOpener(0xc20800dd60)
src/database/sql/sql.go:595 +0x6d
created by database/sql.Open
src/database/sql/sql.go:458 +0x41e
http://build.golang.org/log/045696ee3a83e4bc4055222ffc905f1c5e4d8086

That suggests that either db.mu is leaked, or there's something terribly wrong with the compiler or runtime.  Given the volume of problems lately I'd be inclined to think that the latter is more likely.

There's a lot of skepticism here and there are no later reports, so assuming this is some kind of corruption that has been fixed.


old folder or existing folder detect by watcher when node application restart

is there any way when node application restart the watcher could not detect the old folder and only detect new folder in given path?????

ignoreInitial: true

thanks sir.....


[Docs-2] Show opening tags.

Needs #5722.
[x] Show opening tags for php examples and closing tags for mixed html.

This will be reset after the other PRs, please do not review yet 😄

Sorry for the mess, cannot squash on mobile 😂
Maybe squash when merging.

Thanks @kenjis for the thorough reviews. The next PR for syntax fixes will take some days.

@sfadschm Okay, have a nice weekend!


Discovery Document requestVersions/responseVersions V.S. CDS spec endpoint versions

Are requestVersions and responseVersions supposed to reflect the endpoint versions? Or the request / response model versions? Because endpoint versions and request / response model versions are not always aligned, i.e. endpoint version may be bumped up without bumping up request / response model version.
For example, "Get Products" endpoint (GET /banking/products) have 3 endpoint versions, and the latest version is 3. But the newest response model is ResponseBankingProductListV2. If a data holder only supports "Get Products" endpoint version 3, should cds.endpoint.listBankingProducts.responseVersions be ["V3"] or ["V2"]? Similarly, "Get Scheduled Payments For Specific Accounts" newest version is version 2, but the request model is same as  version 1 (RequestAccountIds), should cds.endpoint.listScheduledPaymentsSpecificAccounts.requestVersions be ["V2"] or ["V1"]?

The intent is that responseVersions be used for x-v with a prefix of V to maintain consistency. I've updated the draft through https://github.com/datarightplus/datarightplus-discovery/pull/1 to specifically spell that out in spec. Might be worth revisiting it again if it's still disliked but closing this for now.


Make additional changes for Schools Admissions

Link to JIRA ticket
https://hackney.atlassian.net/browse/DOC-809
Describe this PR
What is the problem we're trying to solve
School's Admissions has requested that we make a change to the search feature. They would like to filter on evidence requests that contain documents that need to be approved.
What changes have we introduced
We've added in changes to the FE that call the API for evidence requests based on the state of the request (e.g. PENDING, IN REVIEW, etc).
Checklist

[x]  Added end-to-end (i.e. integration) tests where necessary e.g to test complete functionality of a newly added feature
[x]  Added tests to cover all new production code
[ ]  Added comments to the README or updated relevant documentation (add link to documentation), where necessary.
[x]  Checked all code for possible refactoring
[x]  Code pipeline builds correctly

Andy's changes can be found in this PR: https://github.com/LBHackney-IT/document-evidence-store-frontend/pull/221


In DevTools,the reading of the splice attribute can be detected

When the developer tool opens, it automatically reads the 'splice' property of most object types on the console and triggers the getter.
This feature can be used for interference with developer tools and can not be prevented by scripting.
For example:
console.log({
   get splice(){
     location.replace('about:blank')
     //If the console is already open, the splice property of this object will be read and redirected to an empty page.

   }
})

A similar problem exists with the code debugger:
!function(){
  var o={get splice(){location.replace('about:blank')}};
  debugger //When you debug here, redirection is triggered by reading the splice property to the object in scope.
}()

(There is no such bug in Firefox.)
AB#47199348

Thanks a lot!

Thanks for reporting! This bug is now fixed in V8, so the fix should be available in the upcoming version 121 of Edge and Chrome.

Pre-emptively closing this issue based on Seth's message (otherwise I'll forget and it will remain open forever 😄).
But feel free to re-open if the problem persists.


CVE-2017-5124

My Setup

Operating System: MacOS Sierra
App Version: Rocket.Chat+ Version 2.10.1

[x] I have tested with the latest version
[x] I can simulate the issue easily

Description
Google Chrome was updated recently to version 62. This version fixed CVE-2017-5124 , which is a Universal XSS (UXSS) https://chromereleases.googleblog.com/2017/10/stable-channel-update-for-desktop.html
There is a public PoC for CVE-2017-5124 on Github https://github.com/Bo0oM/CVE-2017-5124
On 2017-11-15 I emailed<EMAIL_ADDRESS>like they wrote on both of these URLs,
but I had no PoC, that this vulnerability is also in Electron.

https://github.com/electron/electron/blob/master/SECURITY.md
https://github.com/electron/electron/blob/master/docs/tutorial/security.md

I found a way to reproduce it easily in the Rocket.Chat+ Electron app

Current Behavior

Click the Github icon

search for CVE-2017-5124 (backspace for search across all of github)

You'll find the PoC source code

and a link to the demo of the PoC

click it and it says, it's location is google.com

Expected Behavior

what do you think?

Thanks for the report, will update asap.


Improve search performance for numeric sort queries

Numeric sorting is one of the key query mechanisms used across multiple OpenSearch clusters. It is critical to understand performance characteristics of numeric sorting queries and identify mechanisms to reduce query latency and reduce performance overhead.
To understand query characteristics of numeric sorting, a simple performance testing was performed with below settings:
Benchmark tool: opensearch-benchmark
Workload: geonames
Task: desc_sort_population
Nodes: 1 node
JVM size: 4 GB
Benchmark result:

Metric
Value
Unit

Min Throughput
70.09
ops/s

Mean Throughput
74.27
ops/s

Median Throughput
74.59
ops/s

Max Throughput
74.79
ops/s

50th percentile latency
6.32264
ms

90th percentile latency
6.81483
ms

99th percentile latency
7.45008
ms

99.9th percentile latency
15.4041
ms

100th percentile latency
16.5634
ms

50th percentile service time
5.55759
ms

90th percentile service time
5.73615
ms

99th percentile service time
6.43827
ms

99.9th   percentile service time
14.8174
ms

100th percentile service time
15.4417
ms

error rate
0
%

CPU profile:

As expected most CPU cycles for numeric sorting is spent in Long comparator to do perform sorting operation. CPU cycles are equally distributed between PointValues operations estimatePointCount and intersect
Opening this issue to brainstorm and identify potential improvements to numeric sorting.

I was brainstorming with @harshavamsi on this one briefly last week.
I think there might be some trickery that we can do especially for the special case where a segment has no deletes.
Specifically, I'm wondering if we can inspect the BKD tree to find the leftmost/rightmost (depending on sort order) smallest range with at least N hits, where N is the size parameter (or the track_total_hits limit). Then we could implicitly attach a range query filter.
I don't know if it would ultimately help, or if it's essentially what happens in the the PointValues estimate/intersect methods anyway.

@msfroh thanks for the inputs. Tagging @rishabhmaurya here as well.
@rishabhmaurya had the idea of essentially trying to help match_all queries that use a descending sort on a numeric field. Rather than going through the entire BKD tree like you mentioned, we could essentially look through the min/max value that makes the most sense for us and then attach a range filter on that node assuming other attributes like the number of hits and the number of docs to be returned are all taken care of first.
I don't think I did a great job of explaining, but I will put up an RFC with my thought process and how we could prune the tree.

I have working version of it in lucene and details of optimization are mentioned here - https://github.com/apache/lucene/issues/12534. I had a discussion around it with @msfroh and we agreed upon its utility.
Thanks @harshavamsi for working on it, lets open a github issue. As discussed offline, I started making changes in opensearch as well because lucene community may not accept it as it works for cases with MatchAllQuery with desc sort and no deletions on numeric field. You can find the opensearch changes here, its still workin in progress - https://github.com/rishabhmaurya/OpenSearch/commit/f261cb380dce345c4ce3671a814a12e67258fff5

Should we pull this in https://github.com/rishabhmaurya/OpenSearch/commit/f261cb380dce345c4ce3671a814a12e67258fff5 and run a benchmark along with profile to identify the early improvements
cc: @sandeshkr419

https://github.com/rishabhmaurya/OpenSearch/commit/f261cb380dce345c4ce3671a814a12e67258fff5 is still work in progress. We can build custom lucene jar using - https://github.com/apache/lucene/issues/12534 and check for the estimates on gains. We may have to tweak with entry condition here - https://github.com/rishabhmaurya/lucene/pull/2/files#diff-79c6a57519ecd1ef504629e62e13d17859a4ffedc58f4602e583ce758a15adc8R294 to find the sweet spot for optimization.

Current steps on this:

Build a custom lucene jar with https://github.com/apache/lucene/issues/12534 changes
Run a custom benchmark on match all query with a numeric desc sort and compare performance with current and new implementation to get a baseline on perf improvement

Preliminary benchmarking results:
Without optimization

Metric
Value
Unit

Min Throughput
1.5
ops/s

Mean Throughput
1.51
ops/s

Median Throughput
1.51
ops/s

Max Throughput
1.51
ops/s

50th percentile latency
6.23599
ms

90th percentile latency
6.81445
ms

99th percentile latency
7.21335
ms

100th percentile latency
7.22365
ms

50th percentile service time
4.63105
ms

90th percentile service time
5.02198
ms

99th percentile service time
5.20355
ms

100th percentile service time
5.24069
ms

error rate
0
%

With optimization

Metric
Value
Unit

Min Throughput
1.5
ops/s

Mean Throughput
1.5
ops/s

Median Throughput
1.5
ops/s

Max Throughput
1.5
ops/s

50th percentile latency
8.20805
ms

90th percentile latency
8.61225
ms

99th percentile latency
8.91156
ms

100th percentile latency
9.02062
ms

50th percentile service time
6.5675
ms

90th percentile service time
6.76763
ms

99th percentile service time
7.00944
ms

100th percentile service time
7.10608
ms

error rate
0
%

thanks @harshavamsi for running the benchmark. Could you provide more details on the workload and queries you ran?

@rishabhmaurya
I ran this workload and this task:
Workload: geonames
Task: desc_sort_population
I used an r5.2xlarge cluster for both benchmarks. The non optimized run was a regular cluster I had set up to run keyword benchmarking. The optimized cluster was running a custom build of OS with a patched lucene version that included the optimization.

Re-running the benchmark on the optimized cluster:
|                                                 Min Throughput | desc_sort_population |         1.5 |  ops/s |
|                                                Mean Throughput | desc_sort_population |         1.5 |  ops/s |
|                                              Median Throughput | desc_sort_population |         1.5 |  ops/s |
|                                                 Max Throughput | desc_sort_population |         1.5 |  ops/s |
|                                        50th percentile latency | desc_sort_population |     6.71526 |     ms |
|                                        90th percentile latency | desc_sort_population |     7.17203 |     ms |
|                                        99th percentile latency | desc_sort_population |     7.40734 |     ms |
|                                       100th percentile latency | desc_sort_population |     7.46786 |     ms |
|                                   50th percentile service time | desc_sort_population |     5.15482 |     ms |
|                                   90th percentile service time | desc_sort_population |     5.38515 |     ms |
|                                   99th percentile service time | desc_sort_population |     5.79006 |     ms |
|                                  100th percentile service time | desc_sort_population |     5.89911 |     ms |
|                                                     error rate | desc_sort_population |           0 |      % |

can you also post the segment stats here and overall index size.   I did try exactly same thing couple of months back, but matchallDocs query along with sorting (vanilla) has rare usage IMP, hence I skipped prototyping it.

+1 on @gashutos point. @rishabhmaurya - Do you have a specific use case where this will be useful?

@gashutos thanks for looking. Yes, I have mentioned only for MatchAllQuery with no doc deletions.
This will be helpful in 2 cases -

Desc numeric sort on any numeric field - This will make the iteration on bigger segments fast assuming there is no index sort on this numeric field and the lucene index size is significant (in GBs). I think this is a common use case and we capture this query type in most of benchmark.
Desc sort on @timestamp field with merge policy as LogByteSize - After force merge, the smallest segment could be big enough to make the desc sort query slow. This will be helpful for such cases too.

Can you point me to your poc/issue and also why do you think its a rare case. Thank you

@rishabhmaurya
This problem can be divided in two parts why desc order sort is slower compare to asc order.

For timeseries indices, they are in nearly sort in asc. ( which will be the case for logbytesizemerge policy as well )
RFC in Lucene ->

For non-timeseries workload where our docIdBased disjoint iterator with bkd based competitive iterator works only in asc order of docIds.
Reverse BKD based iteration ->

The reason we think it is rare scenario because generally in production, we dont see just sort on single field  without any filtering clause wrapping it. Again this is observation based on my seen user usecases.

Posting some more number here, same workload and instance but this time with force merging into 1 large segment to see if it could have any impact as well as running on a single primary shard:
Non optimized cluster:
|                                        50th percentile latency |     desc_sort_population |     9.38135 |     ms |
|                                        90th percentile latency |     desc_sort_population |     10.1048 |     ms |
|                                        99th percentile latency |     desc_sort_population |     10.3617 |     ms |
|                                       100th percentile latency |     desc_sort_population |     10.7949 |     ms |
|                                   50th percentile service time |     desc_sort_population |     7.83975 |     ms |
|                                   90th percentile service time |     desc_sort_population |     8.14815 |     ms |
|                                   99th percentile service time |     desc_sort_population |     8.64486 |     ms |
|                                  100th percentile service time |     desc_sort_population |     8.80505 |     ms |
|                                                     error rate |     desc_sort_population |           0 |      % |

Optimized cluster:
|                                        50th percentile latency |     desc_sort_population |     13.4777 |     ms |
|                                        90th percentile latency |     desc_sort_population |     14.0544 |     ms |
|                                        99th percentile latency |     desc_sort_population |      14.372 |     ms |
|                                       100th percentile latency |     desc_sort_population |     15.1146 |     ms |
|                                   50th percentile service time |     desc_sort_population |     11.8186 |     ms |
|                                   90th percentile service time |     desc_sort_population |      12.006 |     ms |
|                                   99th percentile service time |     desc_sort_population |     12.4779 |     ms |
|                                  100th percentile service time |     desc_sort_population |       12.48 |     ms |
|                                                     error rate |     desc_sort_population |           0 |      % |

Will dive into lucene code path to understand where we're spending time when running this workload.

Hi @harshavamsi - will documentation be required for this feature in 2.12?

will documentation be required for this feature in 2.12?

This is purely an internal optimization task. It should not require any documentation.

Hi, are we on track for this to be released in 2.12 ?

Pushing this out to v2.13, since this optimization is still in the investigation stage. Although the benchmarks numbers looks promising, it requires further deep dive into the lucene code path to understand where we're spending time and coming up with the improvement opportunities.

Moved it to 2.14.0 as per the discussion with @harshavamsi

We should try benchmarking numeric sort queries with https://github.com/apache/lucene/pull/13149.
Based on the explanation at https://blunders.io/posts/es-benchmark-4-inlining, we may see significant improvement to numeric sorting..

Tagging @opensearch-project/benchmark-core team


[BUG] Create Index with auto_refresh=true failed, but index is created, metadata in active state

What is the bug?
Create Index with auto_refresh=true failed, but index is created, metadata in active state
How can one reproduce the bug?
Steps to reproduce the behavior:

create skipping index without checkpoint location.

CREATE SKIPPING INDEX on glue.default.status_partitioned (status VALUE_SET)
with (auto_refresh=true)

Related to https://github.com/opensearch-project/opensearch-spark/issues/65


The original data is invalidated

Hi , I'm interested in your work, but the original data is invalidated. Could you provide it for me.

Hi , I'm interested in your work, but the original data is invalidated. Could you provide it for me.


Speed up code generation ("make codegen")

Running "make codegen" only takes 5 minutes in CI, but it takes upwards of 20 minutes locally on macOS. This is because the code generation is disk I/O heavy, and the bind mount of the Antrea source code into the Docker container is very slow on non-Linux hosts (using Docker Desktop or Colima).
To speed up code generation, we implement the following 2 changes:

Before generating any code, we make a copy of the source tree from the bind
mount to a local directory on the container's writable layer. After that, all
reads and writes happen in the copy, which is much faster than the bind
mount. When we are done with code generation, we copy generated files from
the copy back to the original repository as needed.
We mount gopkgmod and the gocache as volumes into the container, which
persist across runs. This speeds up the code generation process at the cost
of a few GBs of storage on the local host.

Change 1) uses "git clone" to make a copy of the source tree, which is the most efficient and simple solution. However, it requires that developers first commit all their changes before running "make codegen". Otherwise, uncommitted changes will be ignored, which can impact code generation. However, I have found that it is always a good idea to commit changes beforehand anyway: it makes it easier to check the generated code changes with "git diff" and it makes it easier to rollback changes if needed. Running "make codegen" with committing local changes will result in an error from now on.
We also simplify code vendoring (used to include Protobuf dependencies) in hack/update-codegen-dockerized.sh.
Before this change, running "make codegen" would take 22 minutes on my macOS laptop. After this change, the first run of "make codegen" takes 9-10 minutes, and subsequent runs take 3-4 minutes.

/skip-all