Lib Version for native html

This editor is so cool, kudos!
I'm not too familiar with svelte, but how hard would it be to compile this into JS and have a pure JS api to bind it to an element.
carta = new Cart()
render(carta, document.getElementById("editor"))

That way it can be used in a react or vanilla project as well?

Hi @pnegahdar!
It would be really cool to be able to use the editor with other frameworks such as React and Vue. Honestly, I don't have experience with compiling Svelte and using in other frameworks, but quickly looking online seems tricky but possible. For example, I saw that bytemd, another popular markdown editor, already does so.
I currently do not have time to dedicate to this, but I'll leave the issue open: I may come back to this in the future, or maybe you or some other developer may help 😄

Hi @BearToCode ,
I know that currently you don't have time to dedicate to this,
I was just wondering if it is possible to sponsor you financially or for you to take a commission (Not soon maybe 1 to 2 months from now when Svelte 5 is stable?) to do the following:

to create a new version that ports this to  Svelte 5 (including plugins, use Runes and remove deprecated features that will be removed in Svelte 6)

to do some research and write from guiding instructions on how to theoretically use the Carta object and build our the vanilla js components for the following:

[X] MarkdownEditor
[X] Markdown
[X] Toolbar
[X] Input
[X] Renderer

I can imagine this library being used in a lot of projects, and frameworks, and I'm willing to put work to port this to vanilla JS (and possibly Vue and React as well)... But I need some guidance (I haven't used Svelte 4 before and I'm quite confused about the architecture system design decisions and responsibilities of the components... ),
I'm imagining it will be something like quill mention or Niivue
Where we can create our own components like (Just throwing initial ideas around)
const carta = new Carta({ extensions: [hashtag()] });

const new MarkdownEditor(
  { carta,
    debounce: 500,
    onDebouncedChange: () => {
      // maybe get the AST here
      // carta.ASTRepresentation
      // so we can save it on our server
      // or plug it in on our own previewer
    },
    onDispatchEvent: (eventType, payload) => {
      // maybe do something given eventType and payload
    }
  }).attachToId("carta-markdown-editor-container")

<div id="carta-markdown-editor-container" />

I know these tasks are quite involved, but I think you have done incredible work..

[X]  striking a good balance between simplicity, and extensibility (I feel like milkdown is quite bloated with builtin prose mirror)...
[X] I love that you have build awesome plugins as well...  (which can serve
as as a good starting point to build our own plugins)...
[X] awesome documentation on how to create advance extensions...
[X] I can go on and on on how amazing this project is. 🤩 ❤

I'm willing to put my money where my mouth by personally sponsoring you for the two tasks if I can afford it...
Again.. amazing project. Hopefully you can give me a number (in USD, we can talk about this privately through email), and I'll save up 🙂.
Looking forward to hear back from you 😀

Hi @mithi,
I appreciate very much your comment 😄 . I don't think I'll be able to work on this for at least a couple of months, due to my enrollment in university, but I should be able to do something then.
I think you asked for two very different modifications in your comment in terms of work required: migrating to Svelte 5 and creating a vanilla JS version of the library.
For the first one, even thought Svelte 5 is not yet definitive and I've not worked directly with it, I'm quite confident not too much work will be needed. This project does not make extensive use of Svelte components, so migrating shoud be straightforward. I'd still wait for a stable release before doing so(as you said).
Providing a vanilla version of the library is a lot more tricky and requires planning. There are several points that need to be adressed to make it viable, as Svelte(Kit) does not provide a simple universal way to do so:

Should we provide web components (<markdown-editor>) or a class-component to be mounted (new MarkdownEditor)? I've personally compiled another project of mine to web components and it was no easy task. I'd prefer to use a vanilla class, but I'll have to check out how to do that...
How are embedded Svelte styles handled?
Will custom elements provided by plugins, which are embedded in the editor (e.g. the search features of the Slash and Emoji plugins) still work? Probably all options that offer SvelteComponents won't be available.
Make sure all the plugins will still work.
Will SSR work?
Hope that everything will work fine with Svelte 5 🤞

There are probably other things that I forgot/will discover during developing.
Regarding the commission: I've created this project because I needed an editor myself, and I decided to share it. I don't see developing OSS as a job. For this reason, I don't quite like the idea of a commision.
Still, if you find this project valuable and plan to make a donation, based on how much value it has provided you, I'll highly appreciate it ❤ .
If you need the previously mentioned support to be able to use the editor, maybe wait until it has been implemented. I might look into setting up a GitHub sponsor page.
If in the meantime I hopefully get time to dedicate to this, you'd like to start working on it yourself, start making some other changes or have any question regarding the project, feel free to ask.

Hi @BearToCode
I really appreciate your detailed response to my query.
Sorry I think I did not word the second request properly,
I didn't mean to ask you do create a vanilla JS version of the library, that would be so too much work for you!
It's more like I noticed that the Carta class is purely written  in typescript and I thought that it would be possible for for me
the use that Carta instance and build my own Markdown editor to use this class instead (in any framework I prefer).
I was just hoping I could commision you to write more detailed documentation on how the svelte component MarkdownEditor (and other surrounding components like Input) uses the Carta instance under the hood...
A more detailed documentation to help provide some direction and guidance so I can write my own MarkdownEditor in other frameworks  - a MarkdownEditor Component (in React and/or Vue) that uses the Carta instance you have written.
I tried to read your MarkdownEditor component (and the other components surrounding it like the InputEnhancer and Renderer) but it's quite difficult for me to grasp (partially because I haven't played around with Svelte 4 syntax as much as I should), and also unfortunately I'm also a bit overwhelmed since I have very little understanding on the system design of this library.
I can try to spend a bit more time to try to explore and play around but then I thought maybe it's more efficient to just ask you directly for help since you know this library inside out (since you wrote it!)
I also see as you've mentioned that this library does not make extensive use of Svelte components, so I was thinking that maybe I can actually migrate it myself (I understand you're very busy), as Svelte 5 is now on Release Candidate phase (https://svelte.dev/blog/svelte-5-release-candidate)
I quote from there blog post:

It doesn't mean that it's ready for production, or that nothing will change between now and 5.0. But if you've held off on dabbling with Svelte 5 during the public beta phase, now is a great time to try it out...

So TLDR, I was wondering if you can I can ask you to write more detailed documentation on how the Svelte 5 components you wrote utilizes the Carta object so I can rewrite components in other frameworks to use the Carta object (and Carta plugins and extensions). The documentation would also help me migrate your existing components (including some of your plugins like the Slash one), from Svelte 4 to Svelte 5, if you don't have time to do so. And if so, it would be nice to discuss this privately on how maybe I can provide some compensation for this effort to write this documentation.
Again, thank you so much for creating this library and making it open source.. It's the most awesome extendable markdown editor I've seen ever! 🥳 🥳  👏  👏

Hi @BearToCode
I really appreciate your detailed response to my query.
Sorry I think I did not word the second request properly, I didn't mean to ask you do create a vanilla JS version of the library, that would be so too much work for you!
It's more like I noticed that the Carta class is purely written  in typescript and I thought that it would be possible for for me
the use that Carta instance and build my own Markdown editor to use this class instead (in any framework I prefer).
I was just hoping I could request to you to write more detailed documentation on how the svelte component MarkdownEditor (and other surrounding components like Input) uses the Carta instance under the hood...
I understand that you don't quite like the idea of commision, then I'd gladly make a donation (Maybe through Paypal or Buy me a Coffee (Like https://ko-fi.com/minimithi) if you do have time to write it.
A more detailed documentation to help provide some direction and guidance so I can write my own MarkdownEditor in other frameworks  - a MarkdownEditor Component (in React and/or Vue) that uses the Carta instance you have written.
I tried to read your MarkdownEditor component (and the other components surrounding it like the InputEnhancer and Renderer) but it's quite difficult for me to grasp (partially because I haven't played around with Svelte 4 syntax as much as I should), and also unfortunately I'm also a bit overwhelmed since I have very little understanding on the system design of this library.
I can try to spend a bit more time to try to explore and play around but then I thought maybe it's more efficient to just ask you directly for help since you know this library inside out (since you wrote it!)
I also see as you've mentioned that this library does not make extensive use of Svelte components, so I was thinking that maybe I can actually migrate it myself (I understand you're very busy), as Svelte 5 is now on Release Candidate phase (https://svelte.dev/blog/svelte-5-release-candidate)
I quote from there blog post:

It doesn't mean that it's ready for production, or that nothing will change between now and 5.0. But if you've held off on dabbling with Svelte 5 during the public beta phase, now is a great time to try it out...

So TLDR, I was wondering if you can I can ask you to write more detailed documentation on how the Svelte 5 components you wrote utilizes the Carta object so I can rewrite components in other frameworks to use the Carta object (and Carta plugins and extensions). The documentation would also help me migrate your existing components (including some of your plugins like the Slash one), from Svelte 4 to Svelte 5, if you don't have time to do so. I understand that you don't quite like the idea of commission, then I'd gladly make a donation  if you do have time to write it.
Again, thank you so much for creating this library and making it open source.. It's the most awesome extendable markdown editor I've seen ever! 🥳 🥳  👏  👏

Hi @BearToCode
I really appreciate your detailed response to my query.
I'm sorry I think I did not word the second request properly, I didn't mean to ask you do create a vanilla JS version of the library, that would be too much work for you!
It's more like I noticed that the Carta class is purely written in Typescript and I think that it would be possible for for me
to use that Carta instance and build my own Markdown editor on top of it instead (can be in Svelte 5 or VueJS or React).
I was just hoping I could request to you to write more detailed documentation on how the svelte 4 component MarkdownEditor (and other surrounding components like Input) uses the Carta instance under the hood...
I believe that a documentation will help provide some direction and guidance so I can write my own MarkdownEditor in other frameworks  - a MarkdownEditor Component (in React and/or Vue) that uses the Carta instance you have written.
I also see as you've mentioned that this library does not make extensive use of Svelte components, so I was thinking that maybe I can actually migrate it myself, if you don't have time to do so. Svelte 5 is now on Release Candidate phase (https://svelte.dev/blog/svelte-5-release-candidate)
I quote from there blog post:

It doesn't mean that it's ready for production, or that nothing will change between now and 5.0. But if you've held off on dabbling with Svelte 5 during the public beta phase, now is a great time to try it out...

I understand that you don't quite like the idea of commission, then I'd gladly make a donation (Maybe through PayPal or Buy me a Coffee (Like https://ko-fi.com/minimithi) if you do have time to write this.
I tried to read your MarkdownEditor component (and the other components surrounding it like the Input and Renderer) but it's quite difficult for me to grasp (partially because I haven't played around with Svelte 4 as much as I should), and also unfortunately I'm also a bit overwhelmed since I have very little understanding on the system design of this library, and the reasonings behind design decisions.
I can try to spend a bit more time to try to explore and play around but then I thought maybe it's more efficient to just ask you directly for help since you know this library inside out (you wrote it!)
TLDR

I was wondering if you can I can ask you to write more detailed documentation on how the Svelte 4 components you wrote utilizes the Carta object so I can build a custom markdown editor
in other frameworks to use the Carta object. The documentation would also help me migrate your existing components (including some of your plugins like the Slash one), from Svelte 4 to Svelte 5, if you don't have time to do so. I understand that you don't quite like the idea of commission, then I'd gladly make a donation if you do have time to write it.

Again, thank you so much for creating this library and making it open source.. It's the most awesome extendable markdown editor I've seen ever! 🥳 🥳  👏  👏

Hi  @BearToCode
I really appreciate your detailed response to my query.
I'm sorry I think I did not word the second request properly, I didn't mean to ask you do create a vanilla JS version of the library, that would be too much work for you!
It's more like I noticed that the Carta class is purely written in Typescript and I think that it would be possible for for me
to use that Carta instance and build my own Markdown editor on top of it instead (can be in Svelte 5 or VueJS or React).
I was just hoping I could request to you to write more detailed documentation on how the svelte 4 component MarkdownEditor (and other surrounding components like Input) uses the Carta instance under the hood...
I believe that a documentation will help provide some direction and guidance so I can write my own MarkdownEditor in other frameworks  - a MarkdownEditor Component (in React and/or Vue) that uses the Carta instance you have written.
As you've mentioned that this library does not make extensive use of Svelte components, so I was thinking that maybe I can actually migrate it myself, if you don't have time to do so. Svelte 5 is now on Release Candidate phase (https://svelte.dev/blog/svelte-5-release-candidate)
I quote from there blog post:

It doesn't mean that it's ready for production, or that nothing will change between now and 5.0. But if you've held off on dabbling with Svelte 5 during the public beta phase, now is a great time to try it out...

I understand that you don't quite like the idea of commission, I'd gladly make a donation (Maybe through PayPal or Buy me a Coffee (Like https://ko-fi.com/minimithi) as an appreciation of your time and effort into writing this.
I tried to read your MarkdownEditor component (and the other components surrounding it like the Input and Renderer) but it's quite difficult for me to grasp (partially because I haven't played around with Svelte 4 as much as I should), and also unfortunately I'm also a bit overwhelmed since I have very little understanding on the system design of this library, and the reasonings behind design decisions.
I can try to spend a bit more time to try to explore and play around but then I thought maybe it's more efficient to just ask you directly for help since you know this library inside out (naturally because you wrote it!)
TLDR

I was wondering if you can I can ask you to write more detailed documentation on how the Svelte 4 components you wrote utilizes the Carta object under the hood so I can build my custom markdown editor
in other frameworks (and in Svelte 5) to use the Carta object. The documentation would also help me migrate your existing components (including some of your plugins like the Slash one), from Svelte 4 to Svelte 5, if you don't have time to do so. I understand that you don't quite like the idea of commission, I'd gladly make a donation as an appreciation of your time and effort into writing this.

Again, thank you so much for creating this library and making it open source... It's the most awesome extendable markdown editor I've seen ever! 🥳 🥳 👏 👏

Hi again,
USING the Carta inside to build "components" for a vanilla version or other framerworks seems like a great idea! It probably has some limitations, but overall it is much easier and more robust than just compiling the components.
If you just need me to explain the roles of the components and how they work, I can do that easily. I think I could add an header to the various components explaining them, and add descriptions to their functions and properties:
<!--
	@description A description of the what the component does and how it does that
-->
<script lang="ts">
  /**
   * A description of the property.
   */
  export let prop: Something;

  /**
   * What the function does
   * @param a What is a
   * @param b What is b
   */
  function fn(a, b) {

  }
</script>

Let me know if something like this would be enough, or if you had another idea in mind. You could obviously contact for any question.
Following your suggestion I create a ko-fi page.

I think I could add an header to the various components explaining them, and add descriptions to their functions and properties

Yes that would be really cool! But if you're doing this just for me, and if it will take too much time from more important things, then please don't prioritize this! After familiarizing myself with Svelte more the past few hours I think
I can read and understand the code a bit better and I'll message you if I have any questions or clarifications.
I'm hoping to contribute more to this project in the near future when I'm no longer swamped with work... So no hurry really...

Following your suggestion I created a ko-fi page.

I have made a little donation on your Ko-Fi page, and I'll be making more donations in the future once I get to spend more time playing with this library.
Again, thank you so much for entertaining all my questions! 🙂
I will message you again in the next couple of months 🙂

Thanks a lot for your donation! Looking forward to working with you 😄

just a quick drive-by comment regarding this issue..
comparison of this project to another project that uses Svelte and publishes a vanilla JS library:

carta-md

jsdelivr: carta-md
jsdelivr: carta-md/dist
jsdelivr: carta-md/dist/index.js

npm package includes raw .svelte files

github: package.json/scripts.build

npm run build calls: node scripts/build.js

github: scripts/build.js

foreach directory in packages, call: npm run build

github: packages/carta-md/package.json/scripts.build

npm run build calls: svelte-kit sync && svelte-package

bigger-picture

github: README#install
jsdelivr: bigger-picture
jsdelivr: bigger-picture/dist
jsdelivr: bigger-picture/dist/bigger-picture.min.js

npm package only includes transpiled javascript

github: package.json/scripts.build

build scripts use rollup (and sass)

github: package.json/devDependencies

dev dependencies include several rollup plugins, including one specifically for Svelte

summary:

bigger-picture is a front-end library written in Svelte that compiles to vanilla JS using rollup as a build tool

assertion:

the same could be done for carta-md
if the @cartamd/ plugins don't include any Svelte components, their current npm packages could probably be used as-is

just for fun.. I spent a little time this evening attempting to make a browser build.
early days, but the results are looking pretty successful.
links..

github: directory
github: test build
github: html demo
githack: html demo

using githack CDN to view the page since my branch isn't configured to use Github Pages

refreshed browser build..

from commit 088274f

even with tag @cartamd/plugin-tikz-v4.1.6
using builds

github: html demo code

githack: html demo


2023-01-13: Allow to execute individual node commands on specified node versions (nvm exec)

Is your feature request related to a problem? Please describe.
Yes. I have to run two different projects at the same time. One project must use node 14 and the other one must use node 18. Unless I'm mistaken, nvm-windows doesn't have the ability to run node commands on specific node versions so because of this I can't run both projects at the same time and I'm limited to running only one project. The original nvm package seems to have functionality for this - the nvm exec command.
Describe the solution you'd like
I propose to add nvm exec command which would work identical to the original nvm package - you could run node commands on specified node versions using nvm-windows without the need to switch the node version by using nvm use - this would allow to run things with different node versions at the same time. For example it could be used like this:

nvm exec 12 node --version - checks node version by running node 12
nvm exec 14 npm run dev - runs project by using node 14
nvm exec 18 npm run dev - runs project by using node 18

Describe alternatives you've considered
WSL on windows and virtual machines but it seems very inconvenient.

Please use the reactions to cast a vote in favor of or against this feature suggestion »

This has been requested before (many times), but it requires an entirely different approach. This can only be achieved with a shim, which (unlike Linux) can cause many edge cases/problems on Windows. So, this will not be added to NVM4W, but it is on the roadmap for Runtime.


Archiver generates one GetReader requests per directory

When walking the file tree, the archiver generates one LoadJSONPack call per directory, each of which generates a GetReader request on the backend with a length and an offset. These requests seems to usually occur on a small number of pack files that contain blobs of type pack.Tree. When dealing with remote backends, it may be more efficient to load and cache these files.

Thanks for reporting this!
Indeed, good point. It's on my (internal) todo list to cache this. I suspect that this is the reason why an "incremental" backup takes a bit longer than a full backup for me :)

This will be solved by #1040.


⚠ ClamAV has degraded performance

In ce0a77a, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 187 ms

Resolved: ClamAV performance has improved in 8f49823.


List item for empty line

Tried this here (https://facebook.github.io/draft-js/)
Steps to reproduce:-

Type/Paste something like the following

abcdef

xyz

Select everything
Click on OL

Observation:-
xyz will be assigned number 3, whereas it should be number 2.
(Tested the same in Microsoft Word 2013)

With an empty line in between, I disagree that xyz should be assigned number 2.


Redesigned saved forms screen

With new layout and icons.

@dcluna Please lint your XML files, make the syntactical recommended changes, and maybe consider some of the other warnings.

The result of this PR is beautiful, nice work!
Good to go after you respond to my comments.
Three things to consider for the future:

when you press back during the form archive view it returns you to the archived form listing, not the prompt selection view.
the title on the prompt selection view doesn't give any context about the current form you are looking at, it simply says "Saved Forms"
There is some strange white on grey background on the listings while in the prompt selection view.

Should be good to go now. I'll adress the UI errors in another PR.


Fix shouldCancelWhenOutside with iOS PanGestureHandler

This ended up only being an issue on iOS. I found that a cancelled PanGestureHandler doesn't automatically make the ScrollView the responder. This seems like default behavior as it's the same on Android. Having the cancelled state come through though is what's important and that is taking place now.
Ref: #30

Protip: if you write Fixes #30 in you description the issue will auto close when this gets merged ;)

@wmcbain thanks so much for sending this.
I've left a few inline comments, would be great if you could find some time to respond to those. Also would you mind getting rid of package lock files? I decided for this project to use yarn, maintaining two lock files overtime seems like an unnecessary hassle to me.
Thanks!

Responded and will address the comments.

This looks good. Just added two final comments and when these are fixed this is ready to be merged.
Thanks again @wmcbain for working on this!

Should be good to go!


PNG Plot window view does not refresh

Describe the bug
The plot window does not refresh when new plot is generated. However, if the plot.png viewer is closed, generation of the new plot opens it again with new plot.
To Reproduce
Start R terminal.
Create a plot, e.g. curve(sin,0,10). The plot.png view panel appears.
Issue new plot command, e.g. curve(cos,0,10) -- nothing changes.
I use the default potting, not httpgd.

Same bug here. Tried rolling back to vscode-R versions 2.3.6 and 2.2.0, with no improvement.
OS: Mac OS Monterey
VSCode Version: 1.64.1
R Version: 4.0.3
vscode-R version: 2.3.8

Same bug here.
os: LInux
VSCode Version: 1.64.1
R Version: 4.0.5
vscode-R version: 2.3.8

I could reproduce it. Looks like it should be an upstream issue where vscode does not refresh editor tab on file changes in the recent releases.

Reported as an upstream issue https://github.com/microsoft/vscode/issues/143291.

Fixed upstream. Should be working in a recent insider and the next release.

Thanks, @renkun-ken, for following up with the vscode team and for your fantastic extension!!

The fix is already included in the latest vscode insider.

Fixed in the latest release.


ARROW-4235: [GLib] Use "column_builder" in GArrowRecordBatchBuilder

Codecov Report

Merging #3540 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3540      +/-   ##
==========================================
+ Coverage   87.76%   87.77%   +<.01%
==========================================
  Files         659      659
  Lines       82113    82113
  Branches     1069     1069
==========================================
+ Hits        72069    72073       +4
  Misses       9929     9929
+ Partials      115      111       -4

Impacted Files
Coverage Δ

go/arrow/math/uint64_sse4_amd64.go
0% <0%> (-100%)
:arrow_down:

go/arrow/math/float64_sse4_amd64.go
0% <0%> (-100%)
:arrow_down:

go/arrow/memory/memory_sse4_amd64.go
0% <0%> (-100%)
:arrow_down:

go/arrow/math/int64_sse4_amd64.go
0% <0%> (-100%)
:arrow_down:

js/src/ipc/metadata/json.ts
92.39% <0%> (-4.35%)
:arrow_down:

js/src/schema.ts
84.61% <0%> (-1.93%)
:arrow_down:

js/src/ipc/metadata/message.ts
90.12% <0%> (-1.28%)
:arrow_down:

go/arrow/math/float64_amd64.go
33.33% <0%> (ø)
:arrow_up:

go/arrow/math/int64_amd64.go
33.33% <0%> (ø)
:arrow_up:

go/arrow/math/uint64_amd64.go
33.33% <0%> (ø)
:arrow_up:

... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update caa3a92...6092875. Read the comment docs.


[web] String.fromCharCodes is very slow on some inputs.

The following program produces results like these when compiled with dart2js:
List                         1ms
UnmodifiableListView         14606ms
Uint8List                    2ms
UnmodifiableUint8ListView    30169ms
List                         1ms
UnmodifiableListView         29174ms
Uint8List                    0ms
UnmodifiableUint8ListView    30096ms
...

The code is calling String.fromCharCodes with a large start: index.
It appears that the instances of  List other than JSArray and Uint8List are treated like arbitrary Iterables, using an Iterator to scan over the ~1M elements before the slice.
It would be better to use something like List.of(charCode.skip(start).take(end - start)), since List implementations usually use some kind of SubListIterable that can skip efficiently. The downside is that if the captured list is too short it is not easy to diagnose whether start or end is at fault.

import 'dart:collection';
import 'dart:typed_data';

void main() {
  final list1 = List.filled(1000000, 32);
  final list2 = UnmodifiableListView(list1);
  final list3 = Uint8List.fromList(list1);
  final list4 = UnmodifiableUint8ListView(list3);

  for (int i = 0; i < 10; i++) {
    time('List                       ', use(list1));
    time('UnmodifiableListView       ', use(list2));
    time('Uint8List                  ', use(list3));
    time('UnmodifiableUint8ListView  ', use(list4));
  }
  print('result: "$result"');
}

void time(String name, String Function() work) {
  final sw = Stopwatch()..start();
  for (int i = 0; i < 1000; i++) {
    result = work();
  }
  print('$name  ${sw.elapsedMilliseconds}ms');
  if (result != ' ' * 10) throw 'Unexpected "$result"';
}

late String result;

String Function() use(List<int> list) =>
    () => String.fromCharCodes(list, list.length - 20, list.length - 10);

Other issues noticed when stepping through the dart2js generated code

is NativeUint8List does not seem to be efficient
The "is JSIndexable" test in the accelerator code for J.$index$asx finds a interceptor dispatch record without the JSIndexable slot initialized. It might be that TypedArrayOfInt should explicitly implement JSIndexable, or something else is wrong with the mechanism.
The normal path for String.fromCharCodes for JSArray could be modernized to use JavaScript's String.fromCodePoints. This method rejects input elements that cannot be converted to an integer in the Unicode range, so it would avoid the need for the loop we currently use to validate the inputs. The downside is that the browsers all differ in the format of the error.

The code is indeed:
  factory String.fromCharCodes(Iterable<int> charCodes,
      [int start = 0, int? end]) {
    if (charCodes is JSArray) {
      // Type promotion doesn't work unless the check is `is JSArray<int>`,
      // which is more expensive.
      // TODO(41383): Optimize `is JSArray<int>` rather than do weird 'casts'.
      JSArray array = JS('JSArray', '#', charCodes);
      return _stringFromJSArray(array, start, end);
    }
    if (charCodes is NativeUint8List) {
      return _stringFromUint8List(charCodes, start, end);
    }
    return _stringFromIterable(charCodes, start, end);
  }

The special cases are exactly what you'd expect.
We could probably accept NativeUint16List too, without needing any validation.
Using a JS native operation which does the right thing, even if it throws a different error, should be fine. The String.fromCharCodes method doesn't specify which error it throws, and we do not consider it a breaking change to change the behavior of code which throws an Error.

@lrhn You present some interesting ideas for how to deal with the truncation-happy skip and take methods.
It is not quite right since start can be equal to charCodes.length, resulting in an empty string - example String.fromCharCodes(UnmodifiableListView([1]), 1) - would erroneously signal an error due to list.isEmpty.
This might be better expressed as finding a sublist of a general Iterable.

Hmm, good point. If start == charCodes.length && end == start, then it's valid.
It should probably just be var count = charCodes.take(start).length;. If that is actually == start, we're OK.

I had come to a similar conclusion for end == start.
What I am struggling with is the path where start == charCodes.length and end == null.
This should return an empty string.
Then you get an empty list which is indistinguishable from start > charCodes.length.
We can handle start == 0 && end == null specially, leaving start > 0 && end == null.
   if (end == null) {
     if (start == 0) {
       var list = charCodes.toList();
       if (list is! JSArray) list = [...list]; // Should never happen, but just to be sure.
        return Primitives.stringFromCharCodes(list); // Takes an entire JSArray
     }
     // start > 0
     sliceIterable = sliceIterable.skip(start - 1);
     var list = sliceIterable.toList();
     if (list is! JSArray) list = [...list]; // Should never happen, but just to be sure.
     if (list.isEmpty) {
       // Second iteration here is bad!
       throw RangeError.range(start, 0, charCodes.length, "start");
     }
     list.removeAt(0);
     return Primitives.stringFromCharCodes(list); // Takes an entire JSArray
   }
 }

As written above, a MappedListIterable will call the map function for an extra element, which we have to remove.
(The low-level API takes an entire list for efficiency reasons, and we prefer not to create a sublist copy of our local copy).
I think I would prefer this:
     // start > 0
     sliceIterable = sliceIterable.skip(start - 1);
     if (sliceIterable.isEmpty) {
       // Second iteration here is bad! Is there a less-specific version of RangeError that is appropriate?
       throw RangeError.range(start, 0, charCodes.length, "start");
     }
     var list = sliceIterable.skip(1).toList();
     if (list is! JSArray) list = [...list]; // Should never happen, but just to be sure.
     rreturn Primitives.stringFromCharCodes(list); // Takes an entire JSArray

If we change the test to sliceIterable.isEmpty, a WhereIterable might scan the predicate over the same region to answer .isEmpty and then .skip(1). But we create a JSArray of the correct size.


Unable to build project and missing files

Prerequisites

[X] I have written a descriptive issue title
[X] I have searched existing issues to ensure the bug has not already been reported

Fastify version
^4.24.3
Plugin version
^6.0.3
Node.js version
21.6.1
Operating system
Windows
Operating system version (i.e. 20.04, 11.3, 10)
22H2 19045.4291
Description
Hello, I wanted to try Fastify with vue.js out but I directly came into issues. I followed the instructions on the Guide Page
npm install giget
giget gh:fastify/fastify-vite/starters/vue-base#dev your-app
npm i
Everything was fine until now. Now if I type npm run build I get the following issues:
└─Δ npm run build

> build
> npm run build:client && npm run build:server

> build:client
> vite build --outDir dist/client --ssrManifest

vite v5.2.9 building for production...
✓ 16 modules transformed.
error during build:
RollupError: Could not resolve "./Users//OneDrive/Dokumente//C:/Users//OneDrive/Dokumente//client/pa
ges/index.vue" from "../../../../../../:routes.js"
file: /:routes.js
    at getRollupError (file:///C:/Users//OneDrive/Dokumente//node_modules/rollup/dist/es/shared/parseAst.js:392:41)
    at error (file:///C://slush/OneDrive/Dokumente//node_modules/rollup/dist/es/shared/parseAst.js:388:42)
    at ModuleLoader.handleInvalidResolvedId (file:///C:/Users//OneDrive/Dokumente//node_modules/rollup/dist/es/shared/node-entry.js:189
39:24)
    at file:///C:/Users//OneDrive/Dokumente/node_modules/rollup/dist/es/shared/node-entry.js:18899:26

and the thing that is weird too that the files routes.js, create.js and context.js does not exist and in the root.vue I had to remove the / from export { default } from '/:router.vue'  to get the router.vue issue away. But there are then still other errors I get:
Error: [vite]: Rollup failed to resolve import ":router.vue" from "C:\Users\\OneDrive\Dokumente\\client\root.vue".
This is most likely unintended because it can break your application at runtime.
If you do want to externalize this module explicitly add it to
`build.rollupOptions.external`

Steps to Reproduce
npm install -g giget
npm install -g vite
giget gh:fastify/fastify-vite/starters/vue-base#dev your-app
npm i
npm run build
Expected Behavior
That it compiles all files into their Directories

Also discussed in Discord: https://discord.com/channels/725613461949906985/1268863878209470505
Without any insight into the issue it does look like an issue with using this setup with the Windows file system, a quite classic issue for Node.js projects and not necessarily something that’s supported by all Node.js projects
Can you try it on a nix-style file system? (Using eg GitHub Codespaces, CodeSandbox, Stackblitz or similar)


use numbers for input check in roi_{average|max}_{pooling|align}_2d.py

~Merge after #5634 and #5635.~
use numpy.issubdtype instead of isinstance to check function args.
numpy.issubdtype supports int, float and numpy.integer, numpy.floating.

waiting for #5635, not stale

@knorth55 Could you fix the conflicts?

I merged master branch and travis passed.

Jenkins, test this please

Jenkins CI test (for commit 3cd5e4823371a2f7bb999bc585b44bce15a5d644, target branch master) failed with status FAILURE.
(For contributors, please wait until the reviewer confirms the details of the error.)

Jenkins CI test (for commit ae7d9ca5d5e8882e68dafc5eaa76fe8e902630d4, target branch master) succeeded!

@mitmul can you review this again ?

@Hakuyume kindly ping.

numbers.Integral can do similar thing and I think it is more simple.
import numbers
import numpy as np

isinstance(int(0), numbers.Integral)  # True
isinstance(np.int32(0), numbers.Integral)  # True
isinstance(float(0), numbers.Integral)  # False

@Hakuyume i update to use numbers.

ChainerCI, test this please

Jenkins CI test (for commit 8c9021450d77d61eed3a5c837177677ade3186ef, target branch master) failed with status FAILURE.

LGTM
It would be better to check float input causes exception.

@mitmul I'm sorry for my slow review. Could you check and merge this PR?

@mitmul can you check and merge this PR?

Jenkins, test this please

Jenkins CI test (for commit 095a94d42cd7770027301eb7ae17300044cb455f, target branch master) failed with status FAILURE.

Jenkins, test this please

Jenkins CI test (for commit 095a94d42cd7770027301eb7ae17300044cb455f, target branch master) succeeded!

@knorth55 I'm very sorry for late reaction to your PRs... Could you fix the conflicts? Then I'll re-run the tests and merge this.

@mitmul No problem. I resolved the conflict.

@mitmul This pull-request is marked as st:test-and-merge, but there were no activities for the last 3 days. Could you check?

Jenkins, test this please

Jenkins CI test (for commit ccc62934d5e9611aca88d51d8f4a16738638b95c, target branch master) failed with status FAILURE.

The test exceeds in Python2.7.
Should I make the test ligheter?

@mitmul This pull-request is marked as st:test-and-merge, but there were no activities for the last 3 days. Could you check?

@mitmul This pull-request is marked as st:test-and-merge, but there were no activities for the last 3 days. Could you check?

@mitmul This pull-request is marked as st:test-and-merge, but there were no activities for the last 3 days. Could you check?

@mitmul This pull-request is marked as st:test-and-merge, but there were no activities for the last 3 days. Could you check?

I'll rerun tests because the last two commits LGTM.
Jenkins, test this please.

Jenkins CI test (for commit 89e90b4175379e191bb7ffec872e308c0abcfaf5, target branch master) failed with status FAILURE.

 Forward computation of erf in CPU can be slow without SciPy.
17:35:22     chainer.warnings.PerformanceWarning)
17:35:22
17:35:22 -- Docs: https://docs.pytest.org/en/latest/warnings.html
17:35:22 =========================== short test summary info ============================
17:35:22 FAIL ../../../repo/tests/chainerx_tests/unit_tests/routines_tests/test_creation.py::test_TrilTriu_param_4_{k=1, shape=(4, 3)}[float16-cuda:0]
17:35:22 = 1 failed, 165337 passed, 5907 skipped, 41 xfailed, 1 warnings in 2079.43 seconds =
17:35:38 Build step 'Execute shell' marked build as failure

@mitmul This pull-request is marked as st:test-and-merge, but there were no activities for the last 3 days. Could you check?

Jenkins, test this please.

Jenkins CI test (for commit 89e90b4175379e191bb7ffec872e308c0abcfaf5, target branch master) succeeded!

Jenkins CI test (for commit 89e90b4175379e191bb7ffec872e308c0abcfaf5, target branch master) failed with status FAILURE.


Kip 476 add java admin client interface

KIP-476
Adds a Admin interface.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

Weird commit history... should only be one commit. Closing. Will reopen..


"Resuming incomplete job" when it shouldn't

Snakemake version
5.31.1
Describe the bug
Often for snakemake runs with 10's of 1000's of jobs, snakemake will try to resume jobs such as:
Resuming incomplete job 10715 with external jobid '2320242'.

... but the snakemake pipeline was started from the beginning, so there should be nothing to resume. It appears that "resuming" results in that snakemake child process stalling. For instance, I recently ran snakemake with --jobs 80, and the pipeline fully stalled out this morning after running for a few days. I grep'd the log for Resuming incomplete job and got 80 hits of the following:
Resuming incomplete job XXX with external jobid 'XXX'.

... so it appears that each of the 80 snakemake jobs stalled at various points during the run.
For a long time (2-3 years), I've noticed that snakemake will start with the correct number of concurrent jobs, but over the course of hours/days, the number of cluster jobs drops (eg., starting at 50 jobs and drops to 10-20). Usually, the pipeline will complete since some jobs never stall, but it appears that this Resuming incomplete job has been occurring across many versions of snakemake.
The jobs are running on a cluster using this SGE profile.
The log for the snakemake run that I've been referring to: screenlog.txt.zip

The "external jobid" numbers listed for each of the 80 Resuming incomplete job messages do not exist outside of that message. For instance:
Resuming incomplete job 11607 with external jobid '2321224'.

The id 2321224 is not found anywhere else in the log, and that job does not correspond to any cluster job:
$ qacct -j 2321224
error: job id 2321224 not found

$ qstat -j 2321224
Following jobs do not exist:
2321224

It appears that snakemake is creating random external jobs to resume, but it can't resume them because they do not exist.

This seems to be a duplicate of https://github.com/snakemake/snakemake/issues/759
I'll check my job status script


Update README.md

Catalan language added

Oh, apologies. When you added a thumbs up to my comment I assumed you wanted me to add it to the readme. :sweat_smile:
I just added it a few minutes ago, closing this PR.
Thanks again for the translation!


feat: enforce/require/allow multiple container image signers for cosign

a container image can be signed by multiple signers using different keys. this feature enables validation against all, a threshold number of or specific required trust roots of a validator.
Fixes #375
Description

a container image can be signed by multiple signers using different keys
this feature enables validation against all, a threshold number of or specific required trust roots of a validator

:warning: WIP notes:

check with cosign progress
concurrent processing of signatures is currently blocked by an asyncio bug

https://stackoverflow.com/questions/70624413/how-to-read-from-dev-stdin-with-asyncio-create-subprocess-exec
https://bugs.python.org/issue46364
https://github.com/python/cpython/actions/runs/1697339783

Checklist

[ ] PR is rebased to/aimed at branch develop
[x] PR follows Contributing Guide
[x] Added tests (if necessary)
[x] Extended README/Documentation (if necessary)
[x] Adjusted versions of image and Helm chart in values.yaml and Chart.yaml (if necessary)

Codecov Report

Merging #428 (ca5a084) into feat/key-interface (74e2542) will increase coverage by 0.19%.
The diff coverage is 100.00%.

@@                  Coverage Diff                   @@
##           feat/key-interface     #428      +/-   ##
======================================================
+ Coverage               94.30%   94.49%   +0.19%
======================================================
  Files                      22       22
  Lines                    1193     1236      +43
======================================================
+ Hits                     1125     1168      +43
  Misses                     68       68

Impacted Files
Coverage Δ

connaisseur/validators/cosign/cosign_validator.py
99.19% <100.00%> (+0.42%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74e2542...ca5a084. Read the comment docs.


GEODE-3637: Reimplement client queue initialization. Adding shutdown …

…logic
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

[ ] Has your PR been rebased against the latest commit within the target branch (typically develop)?

[ ] Is your initial contribution a single, squashed commit?

[ ] Does gradlew build run cleanly?

[ ] Have you written or updated unit tests to verify your changes?

[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to<EMAIL_ADDRESS>@PivotalSarge
@WireBaron

If memory serves, the original intention was to prevent the handshaking from blocking the acceptor thread by moving it to its own thread. Clients should still need to follow the same initialization sequence as before.
Sarge

On 4 Dec, 2017, at 13:36, Jason Huynh<EMAIL_ADDRESS>wrote:
@jhuynh1 commented on this pull request.
Does this change mean a client can connect and send puts before it's queues are ready?
In geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/AcceptorImplClientQueueDUnitTest.java https://github.com/apache/geode/pull/1117#discussion_r154781394:

@Before

public void setup() throws Exception {
blackboard = DistributedLockBlackboardImpl.getInstance();
}

@After
public void tearDown() throws RemoteException {
blackboard.initCount();
host.getAllVMs().forEach((vm) -> vm.invoke(() -> {

 InitialImageOperation.slowImageProcessing = 0;

 System.getProperties().remove("BridgeServer.HANDSHAKE_POOL_SIZE");

}));
}

@Test
public void testClientSubscriptionQueueBlockingConnectionInitialization() throws Exception {
Is this test making sure our queues block during initialization?

Just had a hard time figuring out what the test was actually doing
In geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/AcceptorImplClientQueueDUnitTest.java https://github.com/apache/geode/pull/1117#discussion_r154781830:

       public void afterUpdate(EntryEvent event) {

         eventCount.incrementAndGet();

       }

     }).create("subscriptionRegion");

     region.registerInterestRegex(".*", InterestResultPolicy.NONE, true);

     cache.readyForEvents();

     Awaitility.await().atMost(10, TimeUnit.SECONDS).pollInterval(1, TimeUnit.SECONDS)

         .until(() -> eventCount.get() == numberOfEntries);

     cache.close();

     return eventCount.get() == numberOfEntries;

   });

vm3.invokeAsync("Start Client2 to add entries to region", () -> {

 while (true) {

   Thread.sleep(100);

Possible timing issue?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/apache/geode/pull/1117#pullrequestreview-80996412, or mute the thread https://github.com/notifications/unsubscribe-auth/ATlz4gQZZSfWl_1NvHQYGZyLbZ5vzohEks5s9GXAgaJpZM4Q1U66.

@jhuynh1 - I think a client could connect and do puts before it's queue was ready with or without these changes. Puts go over a different connection.


Develop branch 404

I’d like to possibly contribute to the framework as I build out an app to monitor and interact with my nodes. Which branch should I be pulling from? Documentation says to pull from the develop branch, but the link leads to a 404 error and the develop branch does not exist (at least for the public).

You can base your PR on the master branch, for now I've deleted dev branch as there is only one developer actively working on 0.4


Arc 776 arc 777 add timeouts for sqs processing and error handling

Added timeouts and error handling to SQS Listener

The reason I was adding to the test:
if(context.payload.msg !== testPayload.msg) {
					//discard message if it is not our test message
					return;
				}

not because they add garbage on the queue when they work.
It is for the case of a test failure. If a test fails on assertion then the message will be retried.
However, probably it is an overkill to optimise for that case, so I removed the checks


executor::spawn() in futures-preview 0.3

I noticed that futures-preview 0.3.0 provides its own default global threadpool, similar to tokio 0.1, exposed through the executor::block_on() and executor::block_on_stream() functions. Would it be possible to add an executor::spawn() function for spawning futures on the pool as well?

I've just thrown together a basic generic TLS based spawner just to make sure the idea works, I'll try and polish this up and put it onto crates.io sometime soon: https://github.com/Nemo157/futures-global-spawner/blob/master/tests/smoke.rs


fix: unable closing modal by click mask

Code quality needs improvement:

An unrelated diff.
Useless commits.


test: fix user_name retrieval for CI

Woops. Sorry that my suggestion was faulty

No worries. I think it was my already fried brain 😄


inpoly -> inpolygon

I'm guessing this is just a leftover typo?

Still doesn't really work for me though:
julia> pts
24395-element Vector{Tuple{Float64, Float64}}:
<PHONE_NUMBER>9999999, 14.113560000000001)
<PHONE_NUMBER>9999999, 14.113560000000001)
 ⋮
 (25.217, 0.6)

julia> a[1]
Polygon(137 Points)

julia> inpolygon(pts, a[1])
24395×2 BitMatrix:
 0  0
 0  0
 ⋮
 0  0

I think the result is supposed to be a BitVector, right?

Ahhg yes this needs testing. The matrix is the output of PolygonInbounds.jl. I guess it should return the first column


Fix AbstractStringFieldDataTestCase tests to account for TotalHits lower bound

Signed-off-by: Daniel Widdis<EMAIL_ADDRESS>Description
From Lucene's IndexSearcher javaDoc:

NOTE: The search(org.apache.lucene.search.Query, int) and searchAfter(org.apache.lucene.search.ScoreDoc, org.apache.lucene.search.Query, int) methods are configured to only count top hits accurately up to 1,000 and may return a lower bound of the hit count if the hit count is greater than or equal to 1,000. On queries that match lots of documents, counting the number of hits may take much longer than computing the top hits so this trade-off allows to get some minimal information about the hit count without slowing down search too much.

The AbstractStringFieldDataTestCase assumed the totalHits value was exact.
This fixes the test to test for either exact accuracy or lower bound, as appropriate.
Issues Resolved
Fixes #4238
Check List

[x] New functionality includes testing.

[x] All tests pass

[x] New functionality has been documented.

[x] New functionality has javadoc added

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Pre-commit failing because of the usual Spotless
Execution failed for task ':server:spotlessJavaCheck'.
> The following files had format violations:
      src/test/java/org/opensearch/index/fielddata/AbstractStringFieldDataTestCase.java
          @@ -343,9 +343,9 @@
           ········);
           ········//·As·of·Lucene·9.0.0,·totalHits·may·be·a·lower·bound
           ········if·(topDocs.totalHits.relation·==·TotalHits.Relation.EQUAL_TO)·{
          -············assertEquals(numDocs,·topDocs.totalHits.value);············
          +············assertEquals(numDocs,·topDocs.totalHits.value);
           ········}·else·{
          -············assertTrue(numDocs·>=·topDocs.totalHits.value);························
          +············assertTrue(numDocs·>=·topDocs.totalHits.value);
           ········}
           ········BytesRef·previousValue·=·first·?·null·:·reverse·?·UnicodeUtil.BIG_TERM·:·new·BytesRef();
           ········for·(int·i·=·0;·i·<·topDocs.scoreDocs.length;·++i)·{

Shouldn't we back port this PR to 2.x branch?

I labeled it to backport, let's see.

@dbwiddis Looking at the implementation here: not in love with conditions in specs. When is it one or the other?

@dbwiddis Looking at the implementation here: not in love with conditions in specs. When is it one or the other?

@dblock answering nearly two years later, sorry.  The initial PR comment javadoc explains the difference.  Lucene can comute the hit count and if it's > 1000 it makes it an approximate bound, indicated by the enum used for the conditional.


Shared context between main process and dev worker

Dev server uses isolated worker threads. This prevents having shared cache that is preserved across reloads

Thinking more we can now rely on /cache storage now. Only watching remains a question but we can find better ways to not expose a whole context.


[Request for External] Report 20 "Calc. and Post VAT Settlement" - Protected variables

Describe the request
Could you please change the scope of the global variables "EntrdStartDate" and  "EnteredEndDate" to protected in Report 20 "Calc. and Post VAT Settlement"?
Current
var
    EntrdStartDate: Date;
    EnteredEndDate: Date;

Requested
protected var
    EntrdStartDate: Date;
    EnteredEndDate: Date;

Additional context
We need to access the global variables "EntrdStartDate" and "EnteredEndDate" from the Report Extension.
Internal work item: AB#538706

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 21326.

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 21326.


[PYTHON][PY3] Remove decorator dep

Use stdlib functools.wraps instead which
preserves the function signature in python3.

After more careful inspection, seems decorator package does more than what functools.wraps provides.  In particular, decorator also preserves the default argument in the decorated package, while the functools.wraps does not.
Seems like we will need to keep the decorator dep, close this PR of now


Delete icon should be disabled when story only contains a single page

Bug Description
Having a one-page story and deleting its only page has no effect.
Expected Behaviour
We can go multiple ways about this. Pressing the button should either:

Empty out the page and reset its background/properties
Actually delete the page and show an empty state
Not delete the page and show a snackbar ("Can't delete the only page left")

Steps to Reproduce

Press the delete page button on a story that only has one page

Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance Criteria
QA Instructions

See also the previous conversation here on the same topic with the conclusion that last page can't be deleted: https://xwp.slack.com/archives/CCCAUAH6F/p1576261754010100

We do not allow deleting the last page. We should gray out the delete page icon.

@barklund Perhaps this could be done within #6204 since the icon needs to be adjusted anyway? Or is that issue just an icon swap and better to keep it separately?


Set important flag?

Hello!
Thanks for this bundle.
How do I mark the message as important?
Here's the API:
https://mandrillapp.com/api/docs/messages.JSON.html#method=send-template

you can now use $message->isImportant();

Nice, thank you! )


LDD Not Calculating Correctly After On-Hold

Describe the bug in current situation
While testing the start date bug, it was noticed that the request being on hold for a day did not change the Legislated Due Date.
When a request goes on hold - the days it is on hold do not count against the legislated due date. Both the day the request goes on hold AND the day the request goes off hold, do not count against the timeline of the file.
Link bug to the User Story
Impact of this bug
Will lead to confusion if not caught, applicant may also not be properly informed of correct due date on confirmation of payment.
Chance of Occurring (high/medium/low/very low)
High
Pre Conditions: which Env, any pre-requesites or assumptions to execute steps?
Use TEST-Marshall environment
Steps to Reproduce
Steps to reproduce the behavior:

Go to a general request - note the due date
Put on hold for fees
Take request off hold after one day
Look at legislated due date

Actual/ observed behaviour/ results
Legislated due date should be updated based on number of days request was on hold - both the day the request is on hold, and the day it is taken off hold, do not count against the timeline.
Expected behaviour
A clear and concise description of what you expected to happen. Use the gherking language.
See in Test-Marshall - EDU-2022-113355 - request was on hold for one day, but LDD remained the same.

Not able to reproduce.


Text readability MailSpring issue

I found that some mails have dark text and that because of this the readability is very low.

Where the normal dark theme makes the text stand out more in the reading panel:

Even when there's a white background

Even when there's a white background

has been declared the control variable dark and light, but the mailspring is not working as it should, needs to debug to identify the problem

has been declared the control variable dark and light, but the mailspring is not working as it should, needs to debug to identify the problem

@bengotow help this issue pls

@bengotow help this issue pls

I've tried other dark themes and they kind of have the same issue. But it would be good to figure out how to solve it.

@CodeMouse92 help this issue pls
https://community.getmailspring.com/t/custom-theme-dark-does-not-inject-css-into-the-email-body-iframe/1547

@avelino I'm only the community manager. Also, tagging people in multiple places does not increase your chances of a response; it only clogs up notifications unnecessarily, and frustrates people. I'd have seen it on Discourse later today. :(

I found that the easiest way to deal with this was to use the default Mailspring UI Dark theme with Dracula colors, which is why I made Mailspring UI Dark Dracula.
I didn't really have time to dig in and figure out everything that the default UI Dark theme does differently so as to render decent dark theme emails but I hope this helps.

@lemonnuggets do you want to send pull request of your implementation for the official dracula theme?
I look forward to your contribution


Sails websocket leave and join the same room makes duplicates

Sails version:0.12.1
Node version:5.3.0
NPM version:3.5.3
Operating system:Windows

Hi!
I have a table with lot of rows. Each row is a page with unique context id.
By entering a page, I join to this unique context id.
By leaving this page, I make a call to leave this room.
When I leave the page and enter another, I really get only the current notification for this context.
The problem is when I enter and join to the previous context id again, then I get the notifications doubled, and each time I leave and enter the page the number of notifications I get increases by one.
The flow:
join(123) -> leave(123) -> join(222) -> leave(222) -> join(123)
Im using angular in the client side, so I dont have refreshes (which works - guess because it restarts the connection).
Thanks!

Hi @talbe1992, would you mind setting up a repo that reproduces this in a new sails app real quick? I think that'd be the easiest way to see what's going on.
e.g.:
sails new sails-issue-3712
cd sails-issue-3712
# Now make whichever are the simplest/quickest changes which reproduce the issue,
# and when you for sure have the issue isolated, run:
git init
hub create  # or use the GitHub UI to create the repo and `git remote add` it manually
git add .
git commit -am 'Reproduces https://github.com/balderdashy/sails/issues/3712'
git push -u origin master
hub browse # or open the repo in your browser manually
# Then copy the URL of the new repo and paste it as a comment on this issue.
# We'll check it out, and since this way we'll be able to experience the problem
# ourselves, we should have no problem getting to the bottom of it.

Thanks man!


"generate documentation template" code action

It would be nice to be able to generate a docstring based on the type signature. I think in general this can help encourage people to write docstrings.
Previous work:

in rust analyzer: generate_documentation_template. example: https://rust-analyzer.github.io/thisweek/2021/12/13/changelog-107.html#new-features
in pycharm: https://www.jetbrains.com/help/pycharm/creating-documentation-comments.html#b1406e21

Thanks for the suggestion

Moving this issue to discussion as an enhancement request for comments and upvotes.


Directives hook parameters bindings.instance Is not the current component instance

Version
3.0.0-beta.19
Steps to reproduce
<template>
    <custom-comp  v-foo />
</template>

<script>
  import {h} from 'vue';

  const fooDirective = {
    mounted(el, {instance}) {
      console.log(instance); // instance -> App
    }
  };

  const customComp = ( props )=>{
    return h('div' , ` hello custom-comp `);
  }

  export default {
        name: 'App',
        components : {customComp },
        directives : {foo:fooDirective }
  }
</script>

What is expected?
In the directive hook event, instance is expected to point to the currently used (customComp)
What is actually happening?
but it always points to (App)

This is expected behavior. binding.instance points to the instance whose template the directive is used in.
e.g.
<template>
  <comp v-foo/>
  <div v-foo/>
</template>

binding.instance should point to the same instance in both cases (i.e. App)

So I want an entry to get the current binding instance, and now I need to
<template>
  <comp v-foo/>
  <div v-foo/>
</template>

const fooDirective  = {
    mounted(el, {instance}, vNode) {
        const childNode = instance.$.subTree.dynamicChildren.find(child => child.el === el);
        const hostInstance = childNode.component;   // hostInstance -> comp
    }
};

expected
const fooDirective  = {
    mounted(el, {instance , hostInstance}, vNode) {
         // hostInstance -> comp
    }
};


For nomic-ai/nomic-embed-text-v1 8192 context length

Question
As per document: https://huggingface.co/nomic-ai/nomic-embed-text-v1
Model supports 8192 context length, however, in transformers.js model_max_length: 512.
Any guidance how to use full context (8192) instead of 512?

I'd also love to know, since this model was recommended for browser-based summarization at: https://www.reddit.com/r/LocalLLaMA/comments/1bs84cj/best_way_to_summarize_text_in_the_browser_any/

Apologies for the late reply @faizulhaque - I somehow didn't see this until @flatsiedatsie's comment. Could you provide the code you are using? The original repo has the model_max_length correctly set to 8192 (see here), and that repo is compatible with transformers.js. See example code (which can be found in the README):
import { pipeline } from '@xenova/transformers';

// Create a feature extraction pipeline
const extractor = await pipeline('feature-extraction', 'nomic-ai/nomic-embed-text-v1', {
    quantized: false, // Comment out this line to use the quantized version
});

// Compute sentence embeddings
const texts = ['search_query: What is TSNE?', 'search_query: Who is Laurens van der Maaten?'];
const embeddings = await extractor(texts, { pooling: 'mean', normalize: true });
console.log(embeddings);

@flatsiedatsie Indeed, it does work in-browser! :)

@xenova Library have 512 model_max_length at Xenova/nomic-embed-text-v1 which I believe override the orignal model_max_length: 8192

@faizulhaque Updated :) But you don't need to use that version anymore. You can use the official model repo


[Kontakt 7] Kontakt 7 crashes after installing dxvk.

I had Kontakt 7 working properly before I installed DXVK.
Here's the backtrace that I saved After the crash.
backtrace.txt
Software information
Native Instruments Kontakt 7
Crashes on both standalone and Yabridge/LinVst modes
Currently, it's the only app that crashes with dxvk installed
System information

GPU: Intel(R) HD Graphics 520 (SKL GT2
Driver: Intel open-source Mesa driver 24.0.2
Wine version: wine-9.3
DXVK version: v2.3

Log files
kontakt7.log

Not our bug:
03e4:fixme:vulkan:X11DRV_vkCreateWin32SurfaceKHR Application requires child window rendering, which is not implemented yet!
err:   D3D11SwapChain: Failed to recreate surface: VK_ERROR_INCOMPATIBLE_DRIVER
err:   DXGI: CreateSwapChainForHwnd: Failed to create swap chain, hr -2147467259

You'll need a wine build with child window rendering patches from Proton.

Thank you @doitsujin. After waiting for it to build the wine-tkg build, it finally works. Took a long time to build because of my PC but it was worth it :)


Add lint rules

There are several options to add lint rules.
We can use a community package lint.  It is customizable and so we can edit any rule as we like.

I'd like to work on this issue under GSSOC'21 if it's okay.

Hey @Saransh-cpp, I've opened a PR for this issue. After adding lint rules, there are a lot of warnings and info.
Since GitHub Action that I added checks these lint rules, the PR test will fail.
Should I resolve all the lint errors in the same PR or create a new issue for this? And how should I proceed with PR #158 ?

@nicks101 this most probably is due to the new flutter update, I was thinking of migrating the app to null safety but I am pre-occupied with my internal examinations :"). You can maybe open an issue for this and discuss with @anushbhatia about the migration. There are official video guides available on YouTube for the same.

@Saransh-cpp I'll create a new issue for this.
All the best for your exams!

@nicks101 this most probably is due to the new flutter update, I was thinking of migrating the app to null safety but I am pre-occupied with my internal examinations :"). You can maybe open an issue for this and discuss with @anushbhatia about the migration. There are official video guides available on YouTube for the same.

Due to null safety parameters, these are errors are detected


Feature Requests Enter key

Hey, great work on this plugin!
Here are some ideas that would improve usability for data entry
Enter key
I would love to be able to disable making newline characters on Enter key input.
In the meantime I solved it by wrapping the active table element in this div:
<div on:keydown={handleInput}>
</div>

with the following javascript
function handleInput(event) {
    if (event.keyCode == 13){
    event.preventDefault(); }}

Additionally what would be great user experience are following customizable settings on what to do on Enter key:

Confirm your changes after input with Enter or revert back to the original cell value otherwise
Being able to hop into the next row in the same column on Enter key, analogous to what Tab does in a row.
As far as I've seen there is no function to set the cursor to a specific cell, so I don't know how difficult that would be.

See example for the result of all 3 features.

Hey @stefandanzl!
Thankyou very much for your great suggestions!
Currently I am doing my best to fix all the minor bugs within the table + add a couple of other features I have been working on (as well as maintaining other projects), hence I will only be able to pick these up at the moment.
Nonetheless being able to focus a cell is something I have in the roadmap (Pick mode) and controlling the behaviour of the 'Enter' key is something I have considered for a while so I am very eager to implement this when I can. In regards to confirming input - it would be quite a big change, hence I will only consider this once I have all other features implemented.
Thankyou very much for the great suggestions once again, I will be closing this story for now and will re-open it once I start working on the features listed here.
If you experience any issues/bugs or have other suggestions, feel free to create a new issue. Thanks!

Hi, the Enter key behaviour to move down to row below has is now available in version 1.1.2.


[dv/shadow_reg] fix precedence error

In shadow_reg base sequence, there are some precedence error that causes
testbench to trigger false alarm for storage error. This PR fixed the
logic.
bitwise & has a higher precedence than bitwise ^
bitwise + or - has a higher precedence than <<.
Thanks @rasmus-madsen for reporting this issue in https://github.com/lowRISC/opentitan/issues/3885
Signed-off-by: Cindy Chen<EMAIL_ADDRESS>

This patch passed CI and can be merged:

https://dev.azure.com/lowrisc/opentitan/_build/results?buildId=24560&view=results
https://dev.azure.com/lowrisc/opentitan-private/_build/results?buildId=24559&view=results


PLEASE DELETE THE URL OF UBS

Hi naleeha,
I hope all goes well.
I am a member of Cyber Threat Intelligence Team of UBS. Some weeks ago we recieved that a URL of UBS was exposed in this Github account.
We have tried to discover who are you and your position to request if you can remove the URL , since it is an internal URL of UBS.  Without success.
In that case, we raise our request by here.  Please could you remove any information of UBS of your Github account?
Thank you very much,
Kind regards,
Raf
### Tasks

The url on https://github.com/finos/vuu/issues/1053 has been removed. Thanks


How to cache retrieved access token

In the docs you state:

Acquires access tokens via one of the supported grant types (code, client credentials, user credentials, refresh token). Or you can set an access token yourself.

// Use $client->getAccessToken(); and $client->getRefreshToken() to get tokens
// that can be persisted for subsequent requests.

What would be the correct implementation of how to cache a acquired access token (say via client credentials grant) and then use that, until the access token is not valid anymore (it could be expired e.g.)?

The reason I ask is I cannot find the right 'hook' or approach how to know the used access token is somehow rejected by the server. When a token is rejected it should be removed from cache, a new token acquired and stored in cache for further use.

I had the same question when I first found this library. The answer I came up with is to add your own middleware that reads the token from persistence layer (e.g. DB) and sets it with Oauth2Client::setAccessToken. If you use refresh tokens, store them and do the same. When fetched token is stale, this library will do magic with asking for new token or using refresh token. Anyway, after the new token is used for the resource call, you can get it by Oauth2Client::getAccessToken and persist it once again.

Thanks @mirfilip !
The part about setting the access token yourself I understand. For now I set the token right after creating the Oauth2Client.
My question about how to know when the access token is not accepted by the server; you have pointed me in the right direction I think...
The thing is, after storing the access token how would you know the token must be updated in storage? Because this plugin fetches a new token automatically and - as far as I can tell - there is no implementation to check there is a new token. Or do I miss something?
What I perhaps could do is

create a new stack handler
this handler checks with the same criteria as Oauth2Client handler does, and
if necessary remove or update the old access token

Going to work you think?

For now I just always cache the token after the call has been made. And before making the call I set the token from cache.
This means if no token was needed, the call to oauth/token is made anyway. This is the only efficiency drawback I see... But it's not that big a problem.

Late to the party, @ametad, but:
Assuming you have a long running PHP process (not request based), the flow is:

Create a client
Access token is not set - ask for one and store it in Oauth2Client:: setAccessToken.
As long as the client object lives, the access token is going to be used.
When PHP process lives longer than token expiry, eventually you'll run into "invalid token error" when performing "main request" with token stored in Oauth2Client private member. That's also the place to hook into (main handler of Oauth2Client) to get the idea whether request failed with that exact error. Depending on your approach, you can invalidate/remove previosly persisted token here, or do nothing.
Ask for a fresh token, store it in Oauth2Client:: setAccessToken and redo a main request.

So, that's the basic flow of this lib and more verbose version of what I wrote before. It doesn't matter whether it's a long running PHP process that has a client instance alive for long time (and token stored in a private member) or a standard PHP app (request-based) where you need to persist a token to reuse it between requests.
What you do now is correct - get the token from cache before making a request. When it's stale, you'll have to go back to persistence layer and update it. I'm not sure I understand

This means if no token was needed, the call to oauth/token is made anyway.
the whole point of our discussion is to avoid it. You store it in some persistence layer and fetch that before creating a client instance - this way you can set the token before making a call.


Prevents console warnings from disabled waypoints

In reference to trek/ember-api#11. Resolves #364.

Tests are passing locally, so I'm unsure about the 50 failures on Travis. Rebuild?

Perfect, thanks.
The Travis thing is throwing me for a loop. Tests also work for me locally. I suspect there is a timing issue that only presents on the slower Travis boxes, but so far I can't identify anything that would break the Inview tests outside of Jasmine (or at least the version I'm using) botching the order of things. If you happen to see anything, let me know. I'm working to simplify and speed up the tests in general + upgrade to using Jasmine 2.

Thanks, Caleb! In reference to the ember-api issue, how could I go about getting a new version published to bower?
Also, I'm not sure how debug.js would be accounted for by semver. Feels like it should be exempt, so this could just warrant 3.0.2?

For bower I need to git tag the new version. Bower should pick up the tag automatically.
I have API additions that I merged into master before this fix came along, so I'm going to bump to 3.1.0. I'm still learning/putting-into-practice the finer points of semver, such as in times like this putting all bug fixes into a patch version bump, then separating the API additions out to be the only changes in the minor bump. Next time. For now, this will all go into 3.1.0. I'll post here again when the tag is pushed.

@lsthornt 3.1.0 cut. Happy coding.

:+1: :confetti_ball: thanks man


refactor: add esmodule & use react.createRef & update dev env

Netlify BOT
Built with commit e91f1c2feeab32699da181eec79da699a4c39390
https://app.netlify.com/sites/react-input-files/deploys/5c0dc57b40e2a456259f9a7f


failed to create directory "/opt/rustwide/cargo-home/registry/index/github.com-1ecc6299db9ec823"

"docker" "start" cannot create directory in "/opt"
Caused by : Read-only file system

Ok, Just change the "READONLY" to "READWRITE"

Ok, Just change the "READONLY" to "READWRITE"

I have the same problem, can you tell me how to solve it？
by the way, I met it in Qrates，a tool which uses the rustwide library


Move external module to a separate repo under gearpump group

The repo has been set up at https://github.com/gearpump/gearpump-externals. This is blocked by https://github.com/gearpump/gearpump/issues/2091, https://github.com/gearpump/gearpump/issues/2092 and https://github.com/gearpump/gearpump/issues/2093 since they depend on external modules as depicted by https://github.com/gearpump/gearpump/issues/2089#issuecomment-439678535

The blocking issues have been resolved.


Remove exception use in the WebAssembly VM.

Signed-off-by: John Plevyak<EMAIL_ADDRESS>For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
[Optional Fixes #Issue]
[Optional Deprecated:]

See https://github.com/envoyproxy/envoy-wasm/issues/9 for discussion.

Thanks for doing this @jplevyak.  Note to self: once it's merged, the wat/wasm files introduced in https://github.com/envoyproxy/envoy-wasm/pull/72 need to be rebuilt

/lgtm

@duderino please also indicate a GitHub “lgtm” not the bot stuff.
@jplevyak this is ready for you to merge.


Fixed unexpected scroll behavior if the menu has multiple scrollable …

…ancestors.
When moving the selection down to the last visble item or up to the first one and the container of the input is scrollable, the autocomplete popup menu scrolls all scrollable ancestors, not only the the nearest one.

Codecov Report

Merging #15 into master will increase coverage by 1.43%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master      #15      +/-   ##
==========================================
+ Coverage   93.18%   94.61%   +1.43%
==========================================
  Files           5        5
  Lines         132      130       -2
  Branches       19       18       -1
==========================================
  Hits          123      123
+ Misses          2        1       -1
+ Partials        7        6       -1

Impacted Files
Coverage Δ

src/text-input-autocomplete-menu.component.ts
88.88% <0%> (+4.67%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d08da11...34c601d. Read the comment docs.


tests/generic: Fix energy threshold for RampUp

The energy thresholds of several tests have been tweaked to account of
caveats of specific use-cases. In particular, the RampDown test has been
granted a 15% threshold to avoid too many issues with the capacity
margin. However, the RampUp test which has similar issues has been left
untouched.
Fix this.
Fixes: a31e7b99a942 ("tests/eas/generic: Tweak criteria for passing tests")
Signed-off-by: Quentin Perret<EMAIL_ADDRESS>

LGTM, let's wait for @douglas-raillard-arm feedback... if he has tests passing with this in, it can be merged for me.


Sudoku sieve, efficient caching

The reduction matrix could be built into the regular data structures used to track the sieve items. No need to build it from scratch each time it's needed. I.e., tracking items by cell number instead of m-value.
Similarly look at the internal puzzle tracking.

The new caching could also allow faster testing for derivative puzzles if categorized by cell index.


Feature: Allow closing clipboard & re-paste data

Requested by user Pavelicii on discord.
To add a way to close the automatic clipboard capture & allows paste to deck tracker
https://media.discordapp.net/attachments/912236099743649862/934174331347550298/unknown.png?width=888&height=593


Not working on OS X 10.12.4 (beta)

Hi there
Maybe this is because I'm running on a beta version? When I try and install I get errors saying that backups cannot be written because a filesystem is readonly.
Then once I try and reboot the system just hangs and in verbose mode I get a busy timeout[0] (60s) kexts wait(0) error that loops.
If I disable SIPP I can log in but can't uninstall, and don't have access to wifi: no hardware.
The only solution is then to reinstall OSX.
Any suggestions!?

I Replaced my old Card with an New bcm94331pciebt4cax WLAN Ac works out of the Box
SysProfile Shows No Bluetooth Hardware
what Kind of Kext do i need on my MBP Early 2011 ?


replace closure with Queryable trait

 Zeitreihen-Kombinator

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

60 of 64 (93.75%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.1%) to 85.261%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

operators/src/adapters/raster_time.rs
60
64
93.75%

Totals

Change from base Build<PHONE_NUMBER>:
0.1%

Covered Lines:
30359

Relevant Lines:
35607

💛  - Coveralls

bors merge


UI Plugin: Deployment progress - missed last two stages

During end-to-end testing (with Sean) the (AWS) management cluster was successfully deployed. However, the UI did not recognize the last two steps (so looking only at the UI's step display, the cluster looked like it wasn't completely created).
This may be due to some wording changes on the backend messages (that we're trying to recognize in a fragile way).

I did a little digging on the progress updates that are sent.
The different steps that we have in the UI are based on status sent from the backend (Go) code. The values are defined here:
https://github.com/vmware-tanzu/tanzu-framework/blob/v0.11.4/pkg/v1/tkg/client/init.go#L46-L53
The steps are defined as part of the management cluster creation progression here:
https://github.com/vmware-tanzu/tanzu-framework/blob/v0.11.4/pkg/v1/tkg/client/init.go#L62-L70
One of the things we noticed during our testing was the last two steps of StepInstallProvidersOnRegionalCluster and StepMoveClusterAPIObjects were never marked as completed. I think the completion of the step is performed once the update for the following step is sent, notifying the next step is now running. The final step gets the update sent on start here:
https://github.com/vmware-tanzu/tanzu-framework/blob/v0.11.4/pkg/v1/tkg/client/init.go#L292
And we did see the following console log message being sent from:
https://github.com/vmware-tanzu/tanzu-framework/blob/v0.11.4/pkg/v1/tkg/client/init.go#L293
That makes me wonder if it's possible that we're dropping some of those notifications.

The SendProgressUpdates call is here:
https://github.com/vmware-tanzu/tanzu-framework/blob/a9b8f3a7fc2ea45863a46a077be784e79ead0110/pkg/v1/tkg/log/writer.go#L122
That checks for our channel and sends the JSON update. Since we are receiving the other step updates, I would assume this data flow is working, but maybe possible something is getting messed up with our channel.

Note, this is likely a duplicate of https://github.com/vmware-tanzu/community-edition/issues/4906


Fix created_at field always null in subscriptions/domain-model endpoint

Codecov Report

Merging #136 (7a9babf) into main (ff2026e) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #136      +/-   ##
==========================================
- Coverage   82.70%   82.62%   -0.09%
==========================================
  Files          88       88
  Lines        5168     5167       -1
  Branches      849      834      -15
==========================================
- Hits         4274     4269       -5
- Misses        741      747       +6
+ Partials      153      151       -2

Impacted Files
Coverage Δ

orchestrator/domain/base.py
83.93% <100.00%> (-0.47%)
:arrow_down:

...tor/websocket/managers/memory_websocket_manager.py
54.34% <0.00%> (-0.98%)
:arrow_down:

orchestrator/types.py
95.49% <0.00%> (-0.91%)
:arrow_down:

orchestrator/cli/scheduler.py
69.69% <0.00%> (-0.90%)
:arrow_down:

...rator/distlock/managers/memory_distlock_manager.py
82.60% <0.00%> (-0.38%)
:arrow_down:

.../websocket/managers/broadcast_websocket_manager.py
34.69% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff2026e...7a9babf. Read the comment docs.


Better 64-bit Windows vs. 32-bit Windows detection

Description
Please improve 64-bit over 32-bit detection under Windows.
How to reproduce
Run Chrome 64-bit under Windows 64-bit and visit http://user-agent.herokuapp.com/
Observe that x64 is not set to true.
What do you expect
Common browsers should be detected if running 32-bit or 64-bit.
I like this: http://stackoverflow.com/a/13709431/278842
return browser.ua =~ /x86_64|x86-64|Win64|x64;|amd64|AMD64|WOW64|x64_64/
Gem version:
Browser version: 0.8.0
Report
Mozilla/5.0 (Windows NT 6.3; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/42.0.2311.135 Safari/537.36

Was anything improved in this regard?


[YUNIKORN-2531] Create unit tests for AsyncRMCallback

What is this PR for?
AsyncRMCallback has absolutely no unit test coverage, it's tested only indirectly.
This PR adds unit tests to ensure 100% line coverage.
What type of PR is it?

[ ] - Bug Fix
[x] - Improvement
[ ] - Feature
[ ] - Documentation
[ ] - Hot Fix
[ ] - Refactoring

Todos

[ ] - Task

What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-2531
How should this be tested?
Screenshots (if appropriate)
Questions:

[ ] - The licenses files need update.
[ ] - There is breaking changes for older versions.
[ ] - It needs documentation.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (master@d884f19). Click here to learn what that means.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #832   +/-   ##
=========================================
  Coverage          ?   69.38%
=========================================
  Files             ?       69
  Lines             ?     7539
  Branches          ?        0
=========================================
  Hits              ?     5231
  Misses            ?     2091
  Partials          ?      217

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

@pbacsko Could you please fix conflicts?


Error on login

Issue Summary
After signing in via Github, an error occurred and the login failed
Invalid prisma.account.create() invocation:
Steps to Reproduce

Logged In via Github
Error in Auth.js on Callback

{
data: {
provider: "github",
type: "oauth",
providerAccountId: "xxxxxx",
access_token: "ghu_xxxxx",
expires_at:<PHONE_NUMBER>,
refresh_token: "ghr_xxxxxx",
refresh_token_expires_in: 15724800,
~~~~~~~~~~~~~~~~~~~~~~~~
token_type: "bearer",
scope: "",
userId: "xxxx",
?   id?: String,
?   id_token?: String | Null,
?   session_state?: String | Null,
?   createdAt?: DateTime,
?   updatedAt?: DateTime
}
}
Unknown argument refresh_token_expires_in. Available options are marked with ?.
Expected behavior
Expected login redirect
Other information
Interestingly, after trying to log in a second time, I was redirected to the dashboard successfully ...
Screenshots
No response
Desktop (please complete the following information)
- Browser: Safari 17.2.1

Hey @nathanclevenger thanks for flagging this! We'll take a look right away 💪🏼 And keep you posted

Hey, we have fixed it! It was an app misconfiguration issue as we had enabled the Optional Refresh Token functionality!
Thanks again 🚀


Updating SDK version for 5.3.0 release

@sjahr They don't need to match it's just nice if they do. I'll do the another for 6.0 as well.


Fluentd config file format changes automatically

What kind of request is this (question/bug/enhancement/feature request): bug
Rancher version: rancher/rancher:master 02/28
Steps to reproduce (least amount of steps as possible):
Enter the following configuration in the advanced mode of the fluentd logging target
<match  * >
    @type forward
    compress gzip
    tls_allow_self_signed_cert true
    tls_verify_hostname true
    client_cert_auth true
    <security>
      self_hostname "#{Socket.gethostname}"
      shared_key true
    </security>
    <server>
      name xxx.xx.xcom
      host xxx.xxx.com
      port 24224
      shared_key mypass
      username  user1
      password  password
      weight  100
    </server>
</match>

Then enter the key and certificate in Client Private Key and Client Certificate and CA Certificate PEM. At this point, the fluentd file config has changed, like the following,  and  disappeared
<match *>
  @type forward
  compress gzip
  tls_allow_self_signed_cert true
  tls_verify_hostname true
  client_cert_auth true
  name xxx.xxx.com
  host xxx.xxx.com
  port 24224
  shared_key true
  username user1
  password password
  weight 100
  self_hostname "#{Socket.gethostname}"
  tls_client_private_key_path /fluentd/etc/config/ssl/project_c-d9k8s_p-5l954_client-key.pem
  tls_client_cert_path /fluentd/etc/config/ssl/project_c-d9k8s_p-5l954_client-cert.pem
  tls_cert_path /fluentd/etc/config/ssl/project_c-d9k8s_p-5l954_ca.pem
</match>

Note: The format of the fragranced config file changes each time you enter a value for a key or certificate.

@n313893254 Reproducible in other logging targets

Version: Master 2.2 (3/1/19)
Confirmed issue. I tested per the steps and now the tls_* content is added before the first  found. I also tested this with the other logging targets.
You can see the placement is corrected now and even if I make changes add/remove and try to break it it still works as expected:
<match *>
  @type forward
  compress gzip
  tls_allow_self_signed_cert true
  tls_verify_hostname true
  client_cert_auth true
  tls_client_private_key_path /fluentd/etc/config/ssl/cluster_c-qvvrr_client-key.pem
  tls_client_cert_path /fluentd/etc/config/ssl/cluster_c-qvvrr_client-cert.pem
  tls_cert_path /fluentd/etc/config/ssl/cluster_c-qvvrr_ca.pem
  <security>
      self_hostname "#{Socket.gethostname}"
      shared_key true
    </security>
    <server>
      name xxx.xx.xcom
      host xxx.xxx.com
      port 24224
      shared_key mypass
      username  user1
      password  password
      weight  100
    </server>
</match>

Issue still exist under Rancher Version 2.4.8. Fluentd config are changing automatically.

This Issue still exists under Rancher v2.4.8 with Fluentd v1.0


If the image source changes, then the image is not updated in the grid

HI,
I have a custom cell render, an img tag. The issue I have is that the 'ng-src' changes and it is not reflected in the grid. When inspecting the scope of the row I can see that the model is updated, but the grid is not.

Demo plz?

well this is the closest to my situation: http://codepen.io/anon/pen/vNozNE

Interesting.
I wonder if its specific to the cell renderer, the expressive columns have a demo changing row values on a button click and them being updated. https://github.com/Swimlane/angular-data-table/blob/master/demos/expressive.html

fixed in 0.4.11


figure 10 plot lineages

In this PR:
Figure 10 is added for plotting the lineage trees with their states shown in different colors.
There was a problem with the plotLineage() function that could not plot some those lineages with censoring. The length of cell's lifetime used to be handled by cell.time.endT and cell.time.startT. As I checked, it turned out that for some cells the endT was NaN and this was passed to the plotting function resulting in error.
I believe there is a problem with the way that endT is being calculated, but I wasn't sure where I should add a  few lines to make sure they won't become nan. I changed the code in the plotting function and set a couple of checks. Now it works.
I can spend some time in another branch and figure out where to fix the endT calculation.
For now, figure 10 shows 4 lineages of each drug.

Codecov Report

Merging #573 into master will decrease coverage by 0.77%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #573      +/-   ##
==========================================
- Coverage   92.97%   92.20%   -0.78%
==========================================
  Files          21       21
  Lines        1524     1539      +15
==========================================
+ Hits         1417     1419       +2
- Misses        107      120      +13

Flag
Coverage Δ

#unittests
92.20% <0.00%> (-0.78%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

lineage/plotTree.py
0.00% <0.00%> (ø)

lineage/states/stateCommon.py
91.89% <0.00%> (-2.56%)
:arrow_down:

lineage/tHMM.py
100.00% <0.00%> (ø)

lineage/states/StateDistributionGaPhs.py
83.48% <0.00%> (ø)

lineage/states/StateDistributionGamma.py
98.92% <0.00%> (ø)

lineage/Analyze.py
83.33% <0.00%> (+0.17%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2a31e5...dd315ff. Read the comment docs.

Yes sorry, just realized. I’m working on it in my local.

@aarmey it builds now.


[FIXES JENKINS-28787]: Fixes number format exception

When JMeter parser is used and a csv file contains header line, a number format exception is thrown.
Fix is to check if the first line is a header and skip the line if it is a header.
Note: Noticed that if there was a test for the constructor with glob only, this issue
would have been caught in testing.
Test added and refactored for cleanup.

Current coverage is 47.39% (diff: 100%)

Merging #71 into master will increase coverage by 0.08%

@@             master        #71   diff @@
==========================================
  Files            36         36
  Lines          3006       3011     +5
  Methods           0          0
  Messages          0          0
  Branches        492        492
==========================================
+ Hits           1422       1427     +5
  Misses         1466       1466
  Partials        118        118

Powered by Codecov. Last update 453cc84...f3c780f

Thank you very much

HI @hitesh22
i am a new student for jenkins .  i also met this issue.  how i can fixed it  by your request  ?
update the Performance plugin ? ><
Thanks for you help.
David

@DavidTian123 , just install latest version of the plugin, it should have fixed this issue

@undera   i have updated performance plugin to 2.0 version . but there is also throw out the format error in parse csv jmeter result.
the error as below :
Performance: Failed to parse file 'C:\Users\dtian.jenkins\jobs\Performance Mock with Jmeter\builds\11\performance-reports\JMeterCSV\result.csv': For input string: "2017/02/16 05:58:20.068"
java.lang.NumberFormatException: For input string: "2017/02/16 05:58:20.068"
at java.lang.NumberFormatException.forInputString(Unknown Source)

Same here. Using 2.0 from https://wiki.jenkins-ci.org/display/JENKINS/Performance+Plugin
java.lang.NumberFormatException: For input string: "2017-02-21T14:27:26.359+0100"

It was fixed by #83


Unable to start stream analytics job

Module: Explore Stream Analytics
Lab/Demo: 05
Task: 01
Description of issue
Lab 5 - Explore Azure Stream Analytics
"Start job" button produces error. Happens after following the steps in the guide.

While I had the same warning message about diagnostic settings, there were no errors and I was able to start the job normally. @LewisGoDeploy did you get any error messages in Cloud Shell after running setup.sh ?

Closing it as no repro.


As a social worker, I can view overdue visits

... so that I know I need to clear them up.

[ ] Implement marking the overdue Person Card as red colour in the GUI