Add Database Provider Env Var

Description

Linked Issues
Additional context

Nice addition! That way we can use sqlite as database provider, right?

Nice addition! That way we can use sqlite as database provider, right?

Yeah you could more easily set that option now 👍

Unfortunately I'll have to revert this. Prisma explicitly doesn't support this apparently :(

See: https://github.com/prisma/prisma/issues/998


Command aliases

Ronin supports aliases for options, but not for commands. This would be a nice feature, since it can save a lot of typing for power users (e.g. npm i vs npm install). The convention used for options could be used (alias: 'foo' and aliases: [ 'foo', 'bar' ]).

Good suggestion ;)

:+1: :D

:+1:

Looked into implementing this tonight.  From my understanding a program stores commands as a name => path.js set and then lazy loads the command from the path if it matches.  The lazy loading prevents reading in any command props like command.aliases: ['myalias', 'other alias'] etc.
To keep lazy loading of commands it would either require:
a) command aliases to be defined at a program level e.g.:
var ronin = require('ronin');
var program = ronin({
  path: __dirname,
  aliases: {'alias': 'command'},
  desc: 'Sample for implementing command aliases'
});
program.run();

b) default to loading all commands and then unwinding aliases if the lazy loading technique fails.

Don't worry guys, I will get to it ASAP. Ronin needs a complete rewrite anyway.


hot-fix: limit max texture size on firefox windows to 70% of the maxi…

…mum texture size
See https://github.com/dungeon-revealer/dungeon-revealer/issues/786

I also got a hint for trying out splitting the texture into multiple textures on the three.js discord. I will try this tomorrow.

For the sake of having a workaround for this, I will merge this now. I hope that I have enough time for an atlas solution soon!


Darwin: Tidy up Xcode project file and header naming

Add missing header files to the project file and sort groups
Align group names / paths better with the file system
Consistently use "_Internal.h" for internal slice of a header (but only if the base header exists)

I do wish it were clearer which are public headers and which are not, but this is definitely a step forward!

Yeah, I guess in Xcode you see that in the side bar... Maybe we could add add a header comment like // INTERNAL HEADER to in internal ones. I can do that as a separate PR if we want to do something like that.

Fast-tracking platform specific change with platform owner review.


⚠ gorzdrav.org has degraded performance

In 76f9a57, gorzdrav.org (https://gorzdrav.org) experienced degraded performance:

HTTP code: 200
Response time: 6576 ms

Resolved: gorzdrav.org performance has improved in 594a811.


Feature Request: Longer unavailability timeout

My mug's data go into "unavailable" quite often, as I'm usually at the edge of my Bluetooth range with it, and the coffee maker is even further out. However, this makes automating anything based on a state change next to impossible as half the time the state change is to or from "unavailable". On my first try, it turned the coffee maker off in the middle of making a cup of coffee (unavailable->empty); on the second try, it wouldn't turn off at all as it went "Heating->unavailable->Empty".
As such, I'd request a setting to keep the state for a longer time—either a configurable timeout or a toggle to keep the cached state (as this is primarily an issue for the enumeration) even if the device goes unavailable. I'd much prefer the state update to be delayed due to bad reception over not being able to trigger from it.
The latter could even be the default; as long as there's one property that goes to "unavailable", people could still use their travel mug as a beacon.
PS: Same for "Power" to automate "Charging->Unplugged => Turn on Coffee Maker".
Edit: Note that adding more Bluetooth proxies wouldn't help me as the mug is paired to one that cannot cover my kitchen and living room. For a non-paired BLE device, this certainly would work, but sadly, not for the Ember Mug.

Hi! I understand how that would be an issue and I will look into this, but I'm not sure it's a real solution, but simply a workaround to poor signal strength. You will likely get fairly unreliable results even if we fake staying connected for longer. For example it might skip over a state and go straight from Off to Heating or something.
I'm curious about why proxies would not help. It is possible to pair the mug with multiple proxies, but might need pair them individually. You can do this by turning off other proxies and putting the mug into pairing mode. Why would proxies not help with the mug?

About multiple proxies, to my understanding, the mug will only pair to one of them. I mean, it's in the name, a "pair" are two. It's fairly rare that any BT client device can pair to multiple controllers; there are some speaker-type devices that can do that and even those are usually limited to 2 or 4 hosts.
On the other hand, I can test that easily. (I'd say "give me a sec", but that doesn't work while writing a post... ;) )
Ok, at first, it seemed my assumption was right. I pulled the proxy I knew I had paired it with after I had put the proxy I had paired it with second to last in range. It went into "unavailable", as I expected. However, then the doorbell rang and a package with more ESP32s arrived (pure coincidence, I hope...). When I came back, it was online again. I tested some more and found that it takes between 2 and 3 minutes of "unavailable" until it reconnects to another proxy. Reconnecting to the same proxy after being out of range only takes a couple of seconds.
So, adding more proxies doesn't help with automation, but it would extend the area the mug can be used in as long as it stays within one proxy's range.
 That unobstructed-10-metre range is so useless. Sure, it is better than the IrDA's range of 0.2 metres "line-of-sight while not in direct sunlight", but they could have upped it in any of the newer specs...)

It depends on the device. "Pairing" establishes a link and trust level between two devices and allows for future connections and is not limited to a single device unless the device is. Bluetooth proxies support up to 4 active connections. As for the mug, we have no way of knowing as its undocumented and closed source, however, it seems to remember at least a few paired as you can switch between home assistant and your phone for example and if you don't disable your phone fight with home assistant and cause connection issues. That is why it's mentioned in the docs.
I'm not sure I follow. If you can extend the range, how does this not help with the issue? If it is within range and with a good signal you should not get unavailable. It may indeed take a moment to switch between devices. It probably depends on the overlap. If there is a zone where the first proxy is still connected slightly, it might maintain that weak connection it may either keep that weak connection or alternate between the two proxies. You might want to lower the strength of the proxies to make the switch more obvious.
(I agree, Bluetooth quite frustrating to work with. It's not for nothing like 80% of the issues I get here are connection issues...)

This is from my test. I put two paired proxies within arm's reach of the mug, then pulled the power plug out of the proxy it was connected to. It took about 2 minutes for the mug to decide that I couldn't talk to one proxy anymore and would connect to the other one. Then, I powered the first proxy again and pulled the power from the second one. Again, two minutes until the mug switched over.  And those gaps show in HA as "unavailable".
For the temperature, those gaps are of no concern; triggering on temperature still works when there's a gap and it suddenly jumps up/down. For triggering on state changes, things become an issue as HA sees, for example, "unplugged->unavailable->unplugged" as 2 valid changes and would trigger on those.
I've now dialled in my automation for turning on and off the coffee maker finely enough that it works, but that took a whole couple of extra triggers to account for those extra state changes. And it really only works because turning it on or off twice in a row doesn't matter.
I understand this boils down to a core HA issue, as treating "no idea what the current value is" as a valid value in the state change triggering logic is a fundamental design decision in HA. Still, it can be alleviated by keeping the state up during the expected timespan it takes for a good connection switchover, especially when the information on the connection loss is still available, e.g., by looking if the current temperature is "unavailable". (It would be so much nicer if HA kept the last known value for states and just made "unavailable" a property of it, but we won't ever get that. Funnily enough, the Inkbird temperature sensor has the opposite problem. The only way to know if that one is offline is to look at the last_change timestamp, as the integration keeps the last value indefinitely.)


DBContext reusing object from previous requests

I have a linq query which inside select creates a complex object as a part of result:
    var addresses = (from customer in _db.Customers
        join address in _db.CustomerAddresses on customer.CustomerId equals address.CustomerId
    where customer.CustomerId == customerId
    select new
    {
        Address = new MainAddress
        {
            CustomerId = customer.CustomerId,
            CountryIso3Code = address.CountryIso3Code,
            City = address.City,
            Contacts = new CustomerContact()  // <<-- HERE is the problem
        }
    }).ToList();

Please notice Contacts = new CustomerContact()...
It seems like only first query gets a new object while others are reusing that object somehow even when there are different requests. I do not use or add caching here.
Expected result: new empty object after each execution.
Steps to reproduce
I have created a solution which is reproducing behavior.
efcoredbcontext.zip
DBContext, Repository and Service are scoped instances. However it does not matter if I create them per scope, transient or simply using new statements - result is the same.
Solution consists of 4 projects:
ASP.NET Core 2.0, entry point CustomersController.GetMainAddress method (after start, just hit refresh and watch "contacts" property).
.NET Core 2.0 unit test project with tests using DbContext in various ways.
.NET Core 1.1 unit test project with tests using DbContext in various ways.
.NET 4.6.1 with Entity Framework 6, which generates exception during execution:
The entity or complex type 'EFCoreDBContext.Tests.Net461.Database.CustomerContact' cannot be constructed in a LINQ to Entities query.
Further technical details
EF Core version: 1.x, 2.x
Database Provider: Microsoft.EntityFrameworkCore.SqlServer, Microsoft.EntityFrameworkCore.InMemory
Operating system: Windows 10 Pro
IDE: Visual Studio 2017

Duplicate of #7983


Transition option to keep the route for a default module

It's often the case that there's already an exporter in place, and one might want to add another. exporter_exporter has the nice property of listing all the exporters it reverse proxies, listen on a single port, etc.
But at scale, changing the address of all targets from /metrics to /proxy?module=previous-exporter at the same time is often not feasible. It might be desirable to keep the existing route working during a transition.
Would you be review to a pull request for this ? The goal would be add an option for overriding the /metrics and maybe / route by the route of a module that is being replaced.

I'm not quite sure I understand the suggestion (the last sentence isn't quite adding up). Could you show an example config, and what the behaviour would be (how it differs from the current setup).

The goal would be to replace exporter_exporter's /metrics with a given module. My use case would be to replace an exporter endpoint in-place, transparently, on the same port, before adding more modules.
Before:

exporter X (let's say node_exporter), listens on port *:9100

After:

exporter X listens on <IP_ADDRESS> port 9100
exporter_exporter listens on port 9100. All requests to /metrics are treated as if they were requests to /proxy?module=node

The config would look like this:
modules:
    node:
    method: http
    http:
       address: <IP_ADDRESS>
       port: 9100
transition_module: node

Now in my case it's a collectd's write_prometheus that I want to replace. Unfortunately this exporter has no router replies with the metrics on any path (!). To be safe I wanted to also replace the / route, but this might be erring too much on the side of caution.
I don't know yet what to do with exporter_exporter's own /metrics route. Maybe make it available at some other path during the transition.

TBH this seems very niche. Why not:

leave existing exporter you are already scraping at a given port /metrics in place
add exporter_exporter on a different port
switch scrapes to new port
once scrapes are all migrated, disable public access to the old default scrape port.

Perhaps a better options would be for exporter_exporter to allow a default module to be configured, then you could set the --web.proxy-path=metrics --web.telemetry-path=/expexp_metrics, and I think you'd get what you want

v0.5.0 includes the support for a defaultModule configuration option. I think that, in combination with the configuration for alternate paths for proxy and telemetry metrics would be enough to achieve your original request.


[web][regression] Image.network doesn't render in debug mode & throws Expected a value of type 'Future', but got one of type '_Future<Codec?>'

Steps to Reproduce

Create a new project flutter create master_flutter on the latest master channel
Use Image.network in the web app

code sample
import 'package:flutter/material.dart';

void main() => runApp(MyApp());

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Material App',
      theme: ThemeData.dark(),
      home: Home(),
    );
  }
}

class Home extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text('Material App Bar'),
      ),
      body: Center(
        child: Image.network('https://i.imgur.com/QCNbOAo.png'),
      ),
      floatingActionButton: FloatingActionButton(
        child: Icon(Icons.add),
        onPressed: () {},
      ),
    );
  }
}

Execute flutter run -d chrome

(no issue with flutter run --release chrome)

Expected Results
Actual Results

Additional context:

Image.network renders in release mode
Doesn't reproduce on the dev channel
The issue is reproducible on the master channels since Sunday
Reproduce on the web on mac and windows too, haven't tested on Linux

logs
Running "flutter pub get" in master_flutter...
Launching lib/main.dart on Chrome in debug mode...
 lib/main.dart
Debug service listening on ws://<IP_ADDRESS>:61945/nvvdZzPpjGM=/ws
Connecting to VM Service at ws://<IP_ADDRESS>:61945/nvvdZzPpjGM=/ws

════════ Exception caught by image resource service ════════════════════════════
The following TypeErrorImpl was thrown while resolving an image:
Expected a value of type 'Future<Codec>', but got one of type '_Future<Codec?>'

When the exception was thrown, this was the stack
dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/errors.dart 216:49      throw_
dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/errors.dart 64:3        castError
dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/operations.dart 442:10  cast
dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/classes.dart 571:14     as_C
packages/flutter/src/painting/_network_image_web.dart 95:8                        [_loadAsync]
...
Image provider: ScrollAwareImageProvider<Object>()
Image configuration: ImageConfiguration(bundle: PlatformAssetBundle#44d7e(), devicePixelRatio: 2.0, locale: en_US, textDirection: TextDirection.ltr, platform: macOS)
Image key: NetworkImage("https://i.imgur.com/QCNbOAo.png", scale: 1)
════════════════════════════════════════════════════════════════════════════════

════════ Exception caught by image resource service ════════════════════════════
Expected a value of type 'Future<Codec>', but got one of type '_Future<Codec?>'
════════════════════════════════════════════════════════════════════════════════

════════ Exception caught by image resource service ════════════════════════════
Expected a value of type 'Future<Codec>', but got one of type '_Future<Codec?>'
════════════════════════════════════════════════════════════════════════════════

════════ Exception caught by image resource service ════════════════════════════
Expected a value of type 'Future<Codec>', but got one of type '_Future<Codec?>'
════════════════════════════════════════════════════════════════════════════════

════════ Exception caught by image resource service ════════════════════════════
Expected a value of type 'Future<Codec>', but got one of type '_Future<Codec?>'
════════════════════════════════════════════════════════════════════════════════

════════ Exception caught by image resource service ════════════════════════════
Expected a value of type 'Future<Codec>', but got one of type '_Future<Codec?>'
════════════════════════════════════════════════════════════════════════════════

════════ Exception caught by image resource service ════════════════════════════
Expected a value of type 'Future<Codec>', but got one of type '_Future<Codec?>'
════════════════════════════════════════════════════════════════════════════════

════════ Exception caught by image resource service ════════════════════════════
Expected a value of type 'Future<Codec>', but got one of type '_Future<Codec?>'
════════════════════════════════════════════════════════════════════════════════

════════ Exception caught by image resource service ════════════════════════════
Expected a value of type 'Future<Codec>', but got one of type '_Future<Codec?>'
════════════════════════════════════════════════════════════════════════════════

════════ Exception caught by image resource service ════════════════════════════
Expected a value of type 'Future<Codec>', but got one of type '_Future<Codec?>'
════════════════════════════════════════════════════════════════════════════════

════════ Exception caught by image resource service ════════════════════════════
Expected a value of type 'Future<Codec>', but got one of type '_Future<Codec?>'
════════════════════════════════════════════════════════════════════════════════

════════ Exception caught by image resource service ════════════════════════════
Expected a value of type 'Future<Codec>', but got one of type '_Future<Codec?>'
════════════════════════════════════════════════════════════════════════════════

════════ Exception caught by image resource service ════════════════════════════
Expected a value of type 'Future<Codec>', but got one of type '_Future<Codec?>'
════════════════════════════════════════════════════════════════════════════════

════════ Exception caught by image resource service ════════════════════════════
Expected a value of type 'Future<Codec>', but got one of type '_Future<Codec?>'
════════════════════════════════════════════════════════════════════════════════

════════ Exception caught by image resource service ════════════════════════════
Expected a value of type 'Future<Codec>', but got one of type '_Future<Codec?>'
════════════════════════════════════════════════════════════════════════════════

════════ Exception caught by image resource service ════════════════════════════
Expected a value of type 'Future<Codec>', but got one of type '_Future<Codec?>'
════════════════════════════════════════════════════════════════════════════════

════════ Exception caught by image resource service ════════════════════════════
Expected a value of type 'Future<Codec>', but got one of type '_Future<Codec?>'
════════════════════════════════════════════════════════════════════════════════

════════ Exception caught by image resource service ════════════════════════════
Expected a value of type 'Future<Codec>', but got one of type '_Future<Codec?>'
════════════════════════════════════════════════════════════════════════════════

════════ Exception caught by image resource service ════════════════════════════
Expected a value of type 'Future<Codec>', but got one of type '_Future<Codec?>'
════════════════════════════════════════════════════════════════════════════════

════════ Exception caught by image resource service ════════════════════════════
Expected a value of type 'Future<Codec>', but got one of type '_Future<Codec?>'
════════════════════════════════════════════════════════════════════════════════

════════ Exception caught by image resource service ════════════════════════════
Expected a value of type 'Future<Codec>', but got one of type '_Future<Codec?>'
════════════════════════════════════════════════════════════════════════════════

════════ Exception caught by image resource service ════════════════════════════
Expected a value of type 'Future<Codec>', but got one of type '_Future<Codec?>'
════════════════════════════════════════════════════════════════════════════════

════════ Exception caught by image resource service ════════════════════════════
Expected a value of type 'Future<Codec>', but got one of type '_Future<Codec?>'
════════════════════════════════════════════════════════════════════════════════

════════ Exception caught by image resource service ════════════════════════════
Expected a value of type 'Future<Codec>', but got one of type '_Future<Codec?>'
════════════════════════════════════════════════════════════════════════════════

════════ Exception caught by image resource service ════════════════════════════
Expected a value of type 'Future<Codec>', but got one of type '_Future<Codec?>'
════════════════════════════════════════════════════════════════════════════════

════════ Exception caught by image resource service ════════════════════════════
Expected a value of type 'Future<Codec>', but got one of type '_Future<Codec?>'
════════════════════════════════════════════════════════════════════════════════

════════ Exception caught by image resource service ════════════════════════════
Expected a value of type 'Future<Codec>', but got one of type '_Future<Codec?>'
════════════════════════════════════════════════════════════════════════════════

════════ Exception caught by image resource service ════════════════════════════
Expected a value of type 'Future<Codec>', but got one of type '_Future<Codec?>'
════════════════════════════════════════════════════════════════════════════════

════════ Exception caught by image resource service ════════════════════════════
Expected a value of type 'Future<Codec>', but got one of type '_Future<Codec?>'
════════════════════════════════════════════════════════════════════════════════

flutter doctor -v
[✓] Flutter (Channel master, 1.24.0-7.0.pre.51, on Mac OS X 10.15.7 19H2
    darwin-x64, locale en-GB)
    • Flutter version 1.24.0-7.0.pre.51 at /Users/tahatesser/Code/flutter_master
    • Framework revision 734d2a22fe (2 hours ago), 2020-11-02 15:23:02 +0530
    • Engine revision<PHONE_NUMBER>
    • Dart version 2.12.0 (build 2.12.0-3.0.dev)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
    • Android SDK at /Users/tahatesser/Code/sdk
    • Platform android-30, build-tools 30.0.2
    • ANDROID_HOME = /Users/tahatesser/Code/sdk
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 12.1)
    • Xcode at /Volumes/Extreme/Xcode.app/Contents/Developer
    • Xcode 12.1, Build version 12A7403
    • CocoaPods version 1.10.0.rc.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)

[✓] VS Code (version 1.50.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.16.0

[✓] Connected device (4 available)
    • Taha’s iPad (mobile) • 00008020-000255113EE8402E • ios            • iOS
      14.1
    • macOS (desktop)      • macos                     • darwin-x64     • Mac OS
      X 10.15.7 19H2 darwin-x64
    • Web Server (web)     • web-server                • web-javascript •
      Flutter Tools
    • Chrome (web)         • chrome                    • web-javascript • Google
      Chrome 86.0.4240.111

• No issues found!

Reproducible on master.
Logs
Running "flutter pub get" in flutter_example...                  1,726ms
Launching lib/main.dart on Chrome in debug mode...
Syncing files to device Chrome...                                  21.6s
Debug service listening on ws://<IP_ADDRESS>:64308/LBgfz-zud44=/ws

Warning: Flutter's support for web development is not stable yet and hasn't
been thoroughly tested in production environments.
For more information see https://flutter.dev/web

🔥  To hot restart changes while running, press "r" or "R".
For a more detailed help message, press "h".
Process finished with exit code 0

same issue

Should land in flutter master shortly. Closing.

I am too facing the same issue , network images aren't loading in flutter for web , didn't try in flutter for desktop or mobile
I am running Ubuntu 20.04 Lts with following flutter config :
[✓] Flutter (Channel master, 1.24.0-7.0.pre.47, on Linux, locale en_IN)
    • Flutter version 1.24.0-7.0.pre.47 at
      /home/captain-america/snap/flutter/common/flutter
    • Framework revision 2f18e0b23d (2 days ago), 2020-11-01 20:58:04 +0530
    • Engine revision<PHONE_NUMBER>
    • Dart version 2.12.0 (build 2.12.0-3.0.dev)
    • Pub download mirror https://pub.dev

[!] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
    • Android SDK at /home/captain-america/Android/Sdk
    • Platform android-30, build-tools 29.0.3
    • Java binary at: /usr/bin/java
    • Java version OpenJDK Runtime Environment (build
      11.0.9+11-Ubuntu-0ubuntu1.20.04)
    ✗ Android license status unknown.
      Run `flutter doctor --android-licenses` to accept the SDK licenses.
      See https://flutter.dev/docs/get-started/install/linux#android-setup for
      more details.

[✓] Chrome - develop for the web
    • Chrome at google-chrome

[✓] Linux toolchain - develop for Linux desktop
    • clang version 6.0.0-1ubuntu2 (tags/RELEASE_600/final)
    • cmake version 3.10.2
    • ninja version 1.8.2
    • pkg-config version 0.29.1

[!] Android Studio (not installed)
    • Android Studio not found; download from
      https://developer.android.com/studio/index.html
      (or visit https://flutter.dev/docs/get-started/install/linux#android-setup
      for detailed instructions).

[✓] Connected device (3 available)
    • Linux (desktop)  • linux      • linux-x64      • Linux
    • Web Server (web) • web-server • web-javascript • Flutter Tools
    • Chrome (web)     • chrome     • web-javascript • Google Chrome
      85.0.4183.102

! Doctor found issues in 2 categories.

Is there any temporary work around available?

Team is working on rolling engine into flutter. Hope it will get in shortly. The only workaround is to build your own flutter/engine and using flutter run -d chrome --local-engine=host_debug_unopt. It would be worth your time if you are considering contributing to code base in the future. Sorry for the breakage, we are changing e2e tests to run using developer mode as well as release to prevent this in the future.

you can use cached Network image Plugin https://pub.dev/packages/cached_network_image instead of rendering directly.

you can use cached Network image Plugin https://pub.dev/packages/cached_network_image instead of rendering directly.


Vertical line in editing field

Hi team,
I have a vertical line in the editing field on my 5k Mac (see screenshot). It has no effect on anything but it bothers me. Had the same issue in older versions and actual in 1.0.19. Is it a bug or can I change something in Atom to hid it?
Cheers,
Enrico

Need to disable the wrap-guide package. Sorry found it to late.
See also https://discuss.atom.io/t/what-is-this-line-on-the-right-in-the-editor-view/18477


Move (or remove) Org ID numbers

Is your feature request related to a problem? Please describe.
Non-IATI-expert user feedback:
Would be preferable to not have the coding appear before the organization name, or at all (e.g. “NL-KVK-40530953: Amnesty International The Netherlands”). Is there a reason why it needs to be visible to the user?
Describe the solution you'd like
Some options, not necessarily mutually exclusive:

Put the ID number after the name
Hide the ID number, enable user to see the number if desired (e.g. a checkbox "show ID number")
Provide an explanation of purpose of ID number

In the QB the org listing in Step 1 is
NL-KVK-40530953: Amnesty International The Netherlands
ORG-ID: Nice name
Lets revert to :
Nice name (ORG-ID) in alphabetical order.


Triplet loss model regression experiments

Proposed changes:

...

Status (please check what you already did):

[ ] added some tests for the functionality
[ ] updated the documentation
[ ] updated the changelog (please check changelog for instructions)
[ ] reformat files using black (please check Readme for instructions)

/modeltest
dataset_branch: "triplet"
include:
 - dataset: ["all"]
   config: ["all"]

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Daksh seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


python310Packages.tika: 1.24 -> 2.6.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python310Packages.tika is: A Python binding to the Apache Tika™ REST services
meta.homepage for python310Packages.tika is: https://github.com/chrismattmann/tika-python
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 2.6.0 with grep in /nix/store/qx7jfbf46hff6pn0cp4qs8z8hrj96p76-python3.10-tika-2.6.0
found 2.6.0 in filename of file in /nix/store/qx7jfbf46hff6pn0cp4qs8z8hrj96p76-python3.10-tika-2.6.0

Rebuild report (if merged into master) (click to expand)

3 total rebuild path(s)

3 package rebuild(s)

First fifty rebuilds by attrpath
paperless-ngx
python310Packages.tika
python39Packages.tika

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/qx7jfbf46hff6pn0cp4qs8z8hrj96p76-python3.10-tika-2.6.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python310Packages.tika https://github.com/r-ryantm/nixpkgs/archive/3592793ebfa628c412f9c3b6bac3a5897a8bfbac.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/qx7jfbf46hff6pn0cp4qs8z8hrj96p76-python3.10-tika-2.6.0
ls -la /nix/store/qx7jfbf46hff6pn0cp4qs8z8hrj96p76-python3.10-tika-2.6.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

3 packages built:

paperless-ngx
python310Packages.tika
python39Packages.tika

Maintainer pings
cc @Flakebi for testing.

@ofborg build python39Packages.tika python310Packages.tika paperless-ngx


[DO_NOT_MERGE] Vision Product Search - GA

Vision Product Search beta - > GA

@nnegrey Please review


The main language of Stream Analytics is SQL

The flavor of SQL is "Stream Analytics query language", but the top level description is SQL.

@Fleid : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#label:"aq-pr-triaged"

Thanks, Florian!
#Sign-Off


Deployment error

Getting this error while trying to mup deploy :
Meteor Up: Production Quality Meteor Deployments
------------------------------------------------

Building Started: ../

Started TaskList: Deploy app 'emp-manager' (linux)
[<IP_ADDRESS>] - Uploading bundle
[<IP_ADDRESS>] ✔ Uploading bundle: SUCCESS
[<IP_ADDRESS>] - Setting up Environment Variables
[<IP_ADDRESS>] ✔ Setting up Environment Variables: SUCCESS
[<IP_ADDRESS>] - Invoking deployment process
[<IP_ADDRESS>] ✘ Invoking deployment process: FAILED

	-----------------------------------STDERR-----------------------------------
	Warning: Permanently added '<IP_ADDRESS>' (RSA) to the list of known hosts.
	npm WARN package.json<EMAIL_ADDRESS>No description
	npm WARN package.json<EMAIL_ADDRESS>No repository field.
	npm WARN package.json<EMAIL_ADDRESS>No README data
	  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
	                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0curl: (7) Failed to connect to localhost port 80: Connection refused
	Latest deployment failed! Reverted back to the previous version.
	-----------------------------------STDOUT-----------------------------------

	><EMAIL_ADDRESS>install /opt/emp-manager/tmp/bundle/programs/server/node_modules/fibers
	> node ./build.js

	`linux-x64-v8-3.14` exists; testing
	Binary is fine; exiting
<EMAIL_ADDRESS>node_modules/underscore

<EMAIL_ADDRESS>node_modules/eachline
	└──<EMAIL_ADDRESS>
<EMAIL_ADDRESS>node_modules/semver

<EMAIL_ADDRESS>node_modules/chalk
	├──<EMAIL_ADDRESS>	├──<EMAIL_ADDRESS>	├──<EMAIL_ADDRESS>	├──<EMAIL_ADDRESS><EMAIL_ADDRESS>	└──<EMAIL_ADDRESS><EMAIL_ADDRESS>
<EMAIL_ADDRESS>node_modules/fibers

<EMAIL_ADDRESS>node_modules/source-map-support
	└──<EMAIL_ADDRESS><EMAIL_ADDRESS>	Waiting for MongoDB to initialize. (5 minutes)
	connected
	emp-manager stop/waiting
	emp-manager start/running, process 24618
	Waiting for 30 seconds while app is booting up
	Checking is app booted or not?
	emp-manager stop/waiting
	emp-manager start/running, process 24716
	----------------------------------------------------------------------------
Completed TaskList: Deploy app 'emp-manager' (linux)

Any idea how to resolve this?

Check your app logs.
do mup logs -n 300
On Fri, Apr 24, 2015 at 9:32 PM Romain de Wolff<EMAIL_ADDRESS>wrote:

Getting this error while trying to mup deploy :
Meteor Up: Production Quality Meteor Deployments
Building Started: ../
Started TaskList: Deploy app 'emp-manager' (linux)
[<IP_ADDRESS>] - Uploading bundle
[<IP_ADDRESS>] ✔ Uploading bundle: SUCCESS
[<IP_ADDRESS>] - Setting up Environment Variables
[<IP_ADDRESS>] ✔ Setting up Environment Variables: SUCCESS
[<IP_ADDRESS>] - Invoking deployment process
[<IP_ADDRESS>] ✘ Invoking deployment process: FAILED
-----------------------------------STDERR-----------------------------------
Warning: Permanently added '<IP_ADDRESS>' (RSA) to the list of known hosts.
npm WARN package.json<EMAIL_ADDRESS>No description
npm WARN package.json<EMAIL_ADDRESS>No repository field.
npm WARN package.json<EMAIL_ADDRESS>No README data
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0curl: (7) Failed to connect to localhost port 80: Connection refused
Latest deployment failed! Reverted back to the previous version.
-----------------------------------STDOUT-----------------------------------
><EMAIL_ADDRESS>install /opt/emp-manager/tmp/bundle/programs/server/node_modules/fibers
> node ./build.js

`linux-x64-v8-3.14` exists; testing
Binary is fine; exiting
<EMAIL_ADDRESS>node_modules/underscore

<EMAIL_ADDRESS>node_modules/eachline
└──<EMAIL_ADDRESS>
<EMAIL_ADDRESS>node_modules/semver

<EMAIL_ADDRESS>node_modules/chalk
├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS><EMAIL_ADDRESS>└──<EMAIL_ADDRESS><EMAIL_ADDRESS>
<EMAIL_ADDRESS>node_modules/fibers

<EMAIL_ADDRESS>node_modules/source-map-support
└──<EMAIL_ADDRESS><EMAIL_ADDRESS>Waiting for MongoDB to initialize. (5 minutes)
connected
emp-manager stop/waiting
emp-manager start/running, process 24618
Waiting for 30 seconds while app is booting up
Checking is app booted or not?
emp-manager stop/waiting
emp-manager start/running, process 24716
----------------------------------------------------------------------------

Completed TaskList: Deploy app 'emp-manager' (linux)
—
Reply to this email directly or view it on GitHub
https://github.com/arunoda/meteor-up/issues/391.

Same issue, my log says:
Log says:
root@zorro-HP-ProBook-4540s:/home/zorro/Dropbox/dev/apps/meteor/wiejoo-deployment# Failed to connect to localhost port 80: Connection timed out
Failed: command not found
root@zorro-HP-ProBook-4540s:/home/zorro/Dropbox/dev/apps/meteor/wiejoo-deployment# Latest deployment failed! Reverted back to the previous version.
No command 'Latest' found, did you mean:
Command 'aatest' from package 'libaa-bin' (universe)
Latest: command not found
root@zorro-HP-ProBook-4540s:/home/zorro/Dropbox/dev/apps/meteor/wiejoo-deployment# -----------------------------------STDOUT-----------------------------------
-----------------------------------STDOUT-----------------------------------: command not founds
How can I fix this "command 'Latest' not found" error?
Thx
Benny

I'm getting a similar error with latest version, and also v0.97.  But in my case I can't even run 'mup logs' - there is no such folder as '/var/log/upstart' created on the server, even though the 'configuring upstart' process succeeded

OK, i've switched to a new Google Cloud instance using Ubuntu (previously trying to run on Debian) and now I get the identical error as @rdewolff ... but still no log file to check

@edwardupton Then try to do mup logs -n 300

@arunoda There doesn’t seem to be an upstart logs file:
[<IP_ADDRESS>] tail: [<IP_ADDRESS>] cannot open ‘/var/log/upstart/ld-news.log’ for reading[<IP_ADDRESS>] : No such file or directory[<IP_ADDRESS>]
On 27 Apr 2015, at 17:19, Arunoda Susiripala<EMAIL_ADDRESS>wrote:
@edwardupton https://github.com/edwardupton Then try to do mup logs -n 300
—
Reply to this email directly or view it on GitHub https://github.com/arunoda/meteor-up/issues/391#issuecomment-96729497.

Hmm. Weird.

Give me couple of weeks. I'm porting mup to use docker and all these issues will get fixed by that.
Currently, mup setup and mup deploy works. It's in the mup2 branch.

So, the deployment finally worked on 'Ubuntu 14.04 x64 vmlinuz-3.13.0-43-generic' instance on DigitalOcean.  It seems there is some network security problem when deploying to Google Cloud Compute instance, using both 'ubuntu-1504-vivid-v20150422' and 'backports-debian-7-wheezy-v20150325' setups.
But there's no clue from the error handling exactly what the issue is.  Hopefully better error handling can follow after the docker port.  Good luck

Ubuntu 15.04 default to systemd instead of upstart. That might cause the problem. Encounter this problem when upgrading from Ubuntu 14.10.

Oh yes. I now noticed 1504. Yes, that was the one reason we are moving to docker. I don't need build init scripts for both systemd and upstart. Not a hard task but better if we can avoid it.

Logs are the following :
Connected
Ready
Connected
Ready
Ready
Stream error: Error: write after end
Stream error: Error: write after end
Stream error: Error: write after end
Stream error: Error: write after end
Closed
Timeout error: emp-web-47.zetcom.ch: Command timed out after 2 seconds
Closed
Timeout error: emp-web-47.zetcom.ch: Command timed out after 2 seconds
Closed
Meteor requires Node v0.10.36 or later.
error: Forever detected script exited with code: 1
error: Script restart attempt #1
Meteor requires Node v0.10.36 or later.
error: Forever detected script exited with code: 1
error: Script restart attempt #2
Meteor requires Node v0.10.36 or later.
error: Forever detected script exited with code: 1
error: Script restart attempt #3
Meteor requires Node v0.10.36 or later.
error: Forever detected script exited with code: 1
error: Script restart attempt #4
Meteor requires Node v0.10.36 or later.
error: Forever detected script exited with code: 1
error: Script restart attempt #5
Meteor requires Node v0.10.36 or later.
error: Forever detected script exited with code: 1
error: Script restart attempt #6
Meteor requires Node v0.10.36 or later.
error: Forever detected script exited with code: 1
error: Script restart attempt #7
Meteor requires Node v0.10.36 or later.
error: Forever detected script exited with code: 1
error: Script restart attempt #8
Meteor requires Node v0.10.36 or later.
error: Forever detected script exited with code: 1
error: Script restart attempt #9
Meteor requires Node v0.10.36 or later.
error: Forever detected script exited with code: 1
error: Script restart attempt #10
Meteor requires Node v0.10.36 or later.
error: Forever detected script exited with code: 1
error: Script restart attempt #11
Meteor requires Node v0.10.36 or later.
error: Forever detected script exited with code: 1
error: Script restart attempt #12
Meteor requires Node v0.10.36 or later.
error: Forever detected script exited with code: 1
error: Script restart attempt #13
Meteor requires Node v0.10.36 or later.
error: Forever detected script exited with code: 1
error: Script restart attempt #14
Meteor requires Node v0.10.36 or later.
error: Forever detected script exited with code: 1
error: Script restart attempt #15
Meteor requires Node v0.10.36 or later.
error: Forever detected script exited with code: 1
error: Script restart attempt #16
Meteor requires Node v0.10.36 or later.
error: Forever detected script exited with code: 1
error: Script restart attempt #17
Meteor requires Node v0.10.36 or later.
error: Forever detected script exited with code: 1
error: Script restart attempt #18
Meteor requires Node v0.10.36 or later.
error: Forever detected script exited with code: 1
error: Script restart attempt #19
Meteor requires Node v0.10.36 or later.
error: Forever detected script exited with code: 1
error: Script restart attempt #20
Meteor requires Node v0.10.36 or later.
error: Forever detected script exited with code: 1
error: Script restart attempt #21
Meteor requires Node v0.10.36 or later.
error: Forever detected script exited with code: 1
error: Script restart attempt #22
Meteor requires Node v0.10.36 or later.
error: Forever detected script exited with code: 1
error: Script restart attempt #23
Meteor requires Node v0.10.36 or later.
error: Forever detected script exited with code: 1
error: Script restart attempt #24
Meteor requires Node v0.10.36 or later.
error: Forever detected script exited with code: 1
Kadira: completed instrumenting the app
 >> stepping down to gid: meteoruser
 >> stepping down to uid: meteoruser
Kadira: successfully authenticated

Still not working. Any idea? Last time I did the deployment it worked.

Logs are the following :
Connected
Ready
Connected
Ready
Ready
Stream error: Error: write after end
Stream error: Error: write after end
Stream error: Error: write after end
Stream error: Error: write after end
Closed
Timeout error: emp-web-47.zetcom.ch: Command timed out after 2 seconds
Closed
Timeout error: emp-web-47.zetcom.ch: Command timed out after 2 seconds
Closed
Meteor requires Node v0.10.36 or later.
error: Forever detected script exited with code: 1
error: Script restart attempt #1
Meteor requires Node v0.10.36 or later.
error: Forever detected script exited with code: 1
error: Script restart attempt #2
Meteor requires Node v0.10.36 or later.
error: Forever detected script exited with code: 1
error: Script restart attempt #3
Meteor requires Node v0.10.36 or later.
error: Forever detected script exited with code: 1
error: Script restart attempt #4
Meteor requires Node v0.10.36 or later.
error: Forever detected script exited with code: 1
error: Script restart attempt #5
Meteor requires Node v0.10.36 or later.
error: Forever detected script exited with code: 1
error: Script restart attempt #6
Meteor requires Node v0.10.36 or later.
error: Forever detected script exited with code: 1
error: Script restart attempt #7
Meteor requires Node v0.10.36 or later.
error: Forever detected script exited with code: 1
error: Script restart attempt #8
Meteor requires Node v0.10.36 or later.
error: Forever detected script exited with code: 1
error: Script restart attempt #9
Meteor requires Node v0.10.36 or later.
error: Forever detected script exited with code: 1
error: Script restart attempt #10
Meteor requires Node v0.10.36 or later.
error: Forever detected script exited with code: 1
error: Script restart attempt #11
Meteor requires Node v0.10.36 or later.
error: Forever detected script exited with code: 1
error: Script restart attempt #12
Meteor requires Node v0.10.36 or later.
error: Forever detected script exited with code: 1
error: Script restart attempt #13
Meteor requires Node v0.10.36 or later.
error: Forever detected script exited with code: 1
error: Script restart attempt #14
Meteor requires Node v0.10.36 or later.
error: Forever detected script exited with code: 1
error: Script restart attempt #15
Meteor requires Node v0.10.36 or later.
error: Forever detected script exited with code: 1
error: Script restart attempt #16
Meteor requires Node v0.10.36 or later.
error: Forever detected script exited with code: 1
error: Script restart attempt #17
Meteor requires Node v0.10.36 or later.
error: Forever detected script exited with code: 1
error: Script restart attempt #18
Meteor requires Node v0.10.36 or later.
error: Forever detected script exited with code: 1
error: Script restart attempt #19
Meteor requires Node v0.10.36 or later.
error: Forever detected script exited with code: 1
error: Script restart attempt #20
Meteor requires Node v0.10.36 or later.
error: Forever detected script exited with code: 1
error: Script restart attempt #21
Meteor requires Node v0.10.36 or later.
error: Forever detected script exited with code: 1
error: Script restart attempt #22
Meteor requires Node v0.10.36 or later.
error: Forever detected script exited with code: 1
error: Script restart attempt #23
Meteor requires Node v0.10.36 or later.
error: Forever detected script exited with code: 1
error: Script restart attempt #24
Meteor requires Node v0.10.36 or later.
error: Forever detected script exited with code: 1
Kadira: completed instrumenting the app
 >> stepping down to gid: meteoruser
 >> stepping down to uid: meteoruser
Kadira: successfully authenticated

What's the proper way to fix the node version?

Am trying to update the node version in the mup.json to node v0.12.2 and see if this works.

Same error :(

Am trying a mup setup command now to update node.

Having previously updated the nodeVersion to 0.12.2 in the mup.json file and running mup setup did not work.
I had to ssh to the box and update manually update node via npm with the following commands :
sudo npm cache clean -f
sudo npm install -g n
sudo n stable

After that, running :
mup deploy
Worked like a charm!

Hey,
i have also problem with mup deploy. Any idea what to fix here?
-----------------------------------STDERR-----------------------------------
t_dir=/root/.node-gyp/0.10.36',
gyp info spawn args   '-Dmodule_root_dir=/opt/hashtagteachers/tmp/bundle/programs/server/npm/npm-bcrypt/node_modules/bcrypt',
gyp info spawn args   '--depth=.',
gyp info spawn args   '--no-parallel',
gyp info spawn args   '--generator-output',
gyp info spawn args   'build',
gyp info spawn args   '-Goutput_dir=.' ]
gyp info spawn make
gyp info spawn args [ 'BUILDTYPE=Release', '-C', 'build' ]
gyp info ok
npm WARN package.json<EMAIL_ADDRESS>No description
npm WARN package.json<EMAIL_ADDRESS>No repository field.
npm WARN package.json<EMAIL_ADDRESS>No README data
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0curl: (7) Failed to connect to localhost port 80: Connection refused
Latest deployment failed! Reverted back to the previous version.
-----------------------------------STDOUT-----------------------------------
ctory `/opt/hashtagteachers/tmp/bundle/programs/server/npm/npm-bcrypt/node_modules/bcrypt/build'
><EMAIL_ADDRESS>install /opt/hashtagteachers/tmp/bundle/programs/server/node_modules/fibers
> node ./build.js

`linux-x64-v8-3.14` exists; testing
Binary is fine; exiting
<EMAIL_ADDRESS>node_modules/underscore

<EMAIL_ADDRESS>node_modules/semver

<EMAIL_ADDRESS>node_modules/chalk
├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS><EMAIL_ADDRESS>└──<EMAIL_ADDRESS><EMAIL_ADDRESS>
<EMAIL_ADDRESS>node_modules/eachline
└──<EMAIL_ADDRESS>
<EMAIL_ADDRESS>node_modules/fibers

<EMAIL_ADDRESS>node_modules/source-map-support
└──<EMAIL_ADDRESS><EMAIL_ADDRESS>Waiting for MongoDB to initialize. (5 minutes)
connected
hashtagteachers stop/waiting
hashtagteachers start/running, process 2750
Waiting for 250 seconds while app is booting up
Checking is app booted or not?
hashtagteachers stop/waiting
hashtagteachers start/running, process 3218
----------------------------------------------------------------------------


Split the travis build and run a second build, validating S2I

Split up the travis build into two jobs, running in parallel.
The first job is the existing configuration, and the second job runs the S2I builder to ensure "buildability" on the sources.
The job split is done in order to reduce the chance to run into the 50 minute job limit of travis.

This should successfully compile now that #2356 was merged

This is currently blocked by sundrio/sundrio#129 …

Raised PR: sundrio/sundrio#131

Well, it is not testing this, but checking "buildability", current the issue is, that the build with S2I later on fails, due to the sundrio issue. Adding this to the travis build ensure that no code gets merged which later on breaks the build.
And it doesn't impact the main build, as this is a second build job and thus doesn't count towards the 50 minute build timeout.

Wdyt @kornys

LGTM


⚠ AGEG website (prod) has degraded performance

In 2a3c7cc, AGEG website (prod) (https://www.ageg.ca/) experienced degraded performance:

HTTP code: 200
Response time: 4618 ms

Resolved: AGEG website (prod) performance has improved in f92500a.


right nav toc gives no visual indication its scrollable

What version of starlight are you using?
0.21.5
What version of astro are you using?
4.6.0
What package manager are you using?
pnpm
What operating system are you using?
Linux
What browser are you using?
Chrome, Edge, FIrefox
Describe the Bug
In desktop mode, the toc appears on the right side of the screen.  When the number of items in the list exceeds the viewport height, a couple of issues arise:

There is no visual indication that the element is scrollable.
If the number of items in the list exceeds the page content, when scrolled to the bottom of the window, the bottom of the nav is not visible and you must scroll the nav to get to the bottom of it.

Steps to reproduce:

Open Overrides Page in desktop mode on a screen larger than 72rem and ensuring the height of the window is smaller than the amount of items in the toc
Using the window vertical scrollbar, scroll down to bottom of the page

Expected Result:

The toc should give some visual indication that it separately scrollable; OR
The toc should scroll with the window

Actual Result:
The toc does not move when scrolling, the bottom of the toc is not visible and there is no visual clue that it can be scrolled separately.
Proposed Solutions:

Add a vertical scroll (e.g., https://react.dev/reference/react-dom/components/common)
Make it sticky (e.g., https://vuejs.org/glossary/)
Add scroll listener to keep main-pane & starlight-toc always in sync (e.g., https://vercel.com/docs/projects/overview)
Some combination of the above

Link to Minimal Reproducible Example
https://starlight.astro.build/reference/overrides/
Participation

[X] I am willing to submit a pull request for this issue.

Thanks for the detailed issue @techfg! I agree, we should improve this.
I think to start with, the table of contents should have a scroll bar respecting user preferences in cases where it overflows. That’s important for accessibility.
A scroll listener keeping it in sync could also be an option, but it would be a follow-up/complement to a proper scrollbar, because even if it keeps things in sync, users may want to use the scrollbar to explore the table of contents.

Started experimenting a bit with this.
This is not as easy as removing the scrollbar-width: none; in the .right-sidebar class as the width of the fixed element is way larger than the actual right sidebar.
One decision that would also need to be made is the position of this scrollbar. For example, after experimenting with a sticky approach rather than fixed, the scrollbar would be on the right side of the screen next to the global page scrollbar (maybe too close?):

I guess another valid approach would be to have the scrollbar closer to the actual table of contents. For example, here the Docusaurus approach:

Not sure if there are any recommendations on this, I'll have to research a bit more.

@HiDeoo - Appreciate you looking in to this, funny, I was working on this last night and had some ideas/questions as well for final  implementation :)  Should have a POC to share some thoughts later today!

@HiDeoo @delucis -
I was able to finish the POC, details below.  As @HiDeoo mentions, there are some open questions that would need to be answered prior to finalizing.  Apologize in the advance for the lengthy post, lots to cover 😄
Disclaimer

I am not a css expert so if there are better ways to approach this, I'm all ears
The POC is intended for demonstration purposes only, it is not fully tested nor approach finalized

POC Details
The POC is available at https://stackblitz.com/edit/withastro-starlight-5ct6eh.
How to use

Open https://stackblitz.com/edit/withastro-starlight-5ct6eh in a browser - this will open /reference/example page initially which has a longer toc
Ensure your browser window is wide enough and make the preview pane wide enough (> 72rem) to ensure the right sidebar is visible
Near the top of the page, there is a Select list (green background), use this to toggle across the six (6) style options and see how the right sidebar style changes.  Make sure to scroll the window top to bottom using browser scrollbar and when right sidebar is visible, scroll top to bottom there as well to see how everything plays together
Click Getting Started in left nav to see a page with a shorter toc

TOC sidebar styles

original - This is the current style of Starlight 0.21.5
sticky - TOC is sticky and will scroll with the window, similar to VueJS.
sticky scroll scrollbar standard - TOC contains its own standard styled scrollbar but does not scroll with window, similar to React.dev.
sticky scroll scrollbar webkit - Same as above but using legacy webkit scrollbar styling which offers more control of styling options (e.g., no top/bottom buttons, different hover color, etc.)
sticky scroll listener scrollbar standard - TOC contains its own scrollbar and will scroll with window, similar to Vercel and nextra.
sticky scroll listener scrollbar webkit - Same as above but using legacy webkit scrollbar styling which offers more control of styling options (e.g., no top/bottom buttons, different hover color, etc.)

Changes required
TL;DR - Very little.  For Style 1, 2, 3 & 4, the only change required was to right-sidebar class.  For 6 & 7, the only addition change was in starlight-toc.js.
Each change made, is annotated in the code with the following:
/* POC Start */
// ...
/* POC End */

The POC has several files from Starlight but only a few were modified from original.  In order to make it all work on StackBlitz without grabbing the entire repo, I had to pull in a few files that went unmodified.  Here's the breakdown:

./src/components/starlight/TableOfContents/starlight-toc.ts

import 'scroll-into-view-if-needed' dependency
obtain sidebar & detect if mobile
add logic for scrolling (if applicable)

./src/components/starlight/TableOfContents/TableOfContentsList.astro

Unmodified

./src/components/starlight/MobileTableOfContents.astro

add data-is-mobile attribute to mobile-starlight-toc element

./src/components/starlight/TableOfContents.astro

Unmodified

./src/components/starlight/TwoColumnContent.astro

add data-sidebar-style to div.right-sidebar to support POC style selector
add/adjust styles for .right-sidebar

./src/components/starlight/SidebarStyleSelect.astro

select to support POC only

Why all this information, why didn't you just pick something and submit a PR? 🙋
Well, as @HiDeoo mentioned, there are questions to be answered and based on the input from @delucis previously, I wasn't sure where exactly to take this so wanted to gather some input/feedback 😃
Background/Thoughts
@delucis had mentioned implementing a scrollbar (POC sticky scroll scrollbar [standard|webkit]) as a first step for accessibility, however my thoughts were that if we start simple, a sticky (POC sticky) solution may be preferred as I felt the most common usage would be the window scrolling up/down and when doing so with a separate toc scrollbar, you can't see the bottom of the toc.  For example, I felt the VueJS experience is preferrable to the React.dev experience.  I did some research on accessibility of sidebars and couldn't find anything definitive stated.  With that said, w3c's own website uses the sticky approach without any scrollbar (granted, they don't have long toc's) as does USWDS.  The WCAG spec, also on the w3c site, however, does use sticky scroll scrollbar for its left navigation.
Open Questions

Which approach is preferred OR should we add a new style option to tableOfContents Configuration and let the user choose?

If not a new config option, which approach is preferred?
If add a new config option:
1. What should it be named?
2. Of the five (5) new styles, which should be supported?

If option involves a scrollbar (Option 3, 4, 5, 6 from POC):

Scrollbar Width

Should scrollbar extend to right most portion of screen; OR should it be narrowed?
If narrowed width, what width should it be - width required by content vs. fixed and if fixed, what width?

Scrollbar Style - I believe the only place Starlight has customized scrollbars is in the expressive code integration which is represented in the webkit POC options.

Should the scrollbar be consistent with expressive code (when browser supports webkit falling back to standard if not); OR;
Should scrollbar always be standard

If option involves scroll listener (Option 4 & 6 from POC), is it OK to take an external dependency on scroll-into-view-if-needed or should I roll my own implementation?

My $0.02

Which Option - I would recommend sticky scroll listener scrollbar webkit (Option 6) as it blends everything together, is rather straightforward to implement and consistent with expressive code scrollbars.  I think having a new config option would be ideal (and easy enough to implement) but it might be overkill (would be nice though and happy to include it!)
Scrollbar -

Width - I would recommend fixed width of 300px (fairly common) to ensure the scrollbar always appears in the same place from page to page regardless of width of content
Style - I would recommend being consistent with expressive code and preferring webkit style when available

Scrollbar Listener - Assuming taking an external dependency is OK, I would recommend this.  If taking an external dependency is not desirable, I would recommend postponing this part of the feature and going with sticky (Option 2) to start with since I believe having the toc move with the window is more desirable than sticky scrollbar scrollbar [standard|webkit] as described above in background/thoughts section, while still supporting accessibility.

@HiDeoo @delucis & others - Look forward to your thoughts/input!

Thanks a lot for your very thorough experimentations and explanations. Definitely way better than my small experiment just adding a sidebar without modifying any behavior or exploring more options. Super appreciated!
I'll try to give my thoughts about the different options and questions you raised, but of course, this is just my opinion and would love to hear more thoughts from others (and also more people experimenting with this).

I am personally in favor, at least to begin with, to not add any option and just fix the initial accessibility issue. Not sure that for this specific case, a lot of customization is required, people could still manually override this if they really want and supporting more than 1 behavior would definitely add a maintenance cost.
i. I personally lean towards the option 3 (sticky scroll scrollbar standard).
Option 2 (sticky) is pretty annoying to me when I cannot scroll to the bottom of the right sidebar without scrolling to the bottom of the page.
Option 4 (sticky scroll scrollbar webkit) feels a bit weird as this would introduce a different scrollbar compared to the left sidebar and the main content.
Option 5 (sticky scroll listener scrollbar standard) and 6 (sticky scroll listener scrollbar webkit) feels very distracting to me visually (and I guess this could be toned down but still not sure it's worth it).

Scrollbar:
i. I'm still unsure personally about this one yet, but it's really nice you went with the opposite approach compared to my screenshot from the previous post as we can clearly see the difference.
ii. I am personally leaning towards standard scrollbar to match the left sidebar and the main content.

You can find a list of supported browsers and their versions using this browserslist query (only referenced in the contributing guide at the moment).

The first tests close to what you're describing are being implemented in #640 at the moment with Playwright, so there is indeed nothing yet available for this. When we get more feedback and get closer to a solution, something that really helps this kind of PR is using Astro Talking & Doc'ing sessions to have people joining the sessions to actually test and play with it using their various devices and browsers. I think this change would be a great candidate for this kind of session too.

I'll still continue to think about this and play more with the amazing playground you provided but if anyone else has any thoughts, please share them!

Regarding above, after reviewing the code more, I found several places that have scrollbars beyond left & (soon to be) right nav (e.g., dropdowns) so going to shelve the thin style and stick to standard style to remain consistent.  I do think implementing a proper thin style makes sense but it should be across the board and only on devices that support pointer: fine so will leave that for a separate PR on its own if there is an appetite from the team to introduce that.
For now, going with:

Left & Right nav scrollbars styled the same
Standard scrollbar width
Do not sync right scrollbar with window scroll
Width of right side of 18.75rem (--sl-sidebar-width) - Note that this will need to adjust dynamically based on screen width as otherwise the main content section shrinks more than current.

Look forward to any additional input, thanks!

May I add my 2 cents to this discussion:
I know that accessibility is very important and I really REALLY appreciate that you (@techfg) want to improve it even further. Thanks a lot for the whole effort you already put into this.

I think that adding another feature would be the golden middle path for accessibility and subtleness to Starlight:

The toc should automatically scroll down and up if the current section of the page is below / outside the viewport.

I would really like to provide an example but unfortunately, this cool feature is not something that many companies have implemented (cause it's also rather hard to implement) and I can't currently think of any... If anyone understands what I mean and could provide an example website or StackBlitz I would be very grateful...

@trueberryless - Thanks for the input and for resurfacing this issue!
I do agree, I and I think others have as well in prior comments, that adding a scrollbar isn't ideal but from ascetics perspective :)  That said, I think the direction from the Starlight team, at least for a first step, was to add it over some of the other options I had proposed with the idea that more could be done as things evolve.
If I'm understanding your idea correctly, I think it's the 3rd option from my OP ("Add scroll listener to keep main-pane & starlight-toc always in sync").  Unfortunately, it looks like Vercel has actually changed their right side nav to no longer "sync" as the page scrolls so it no longer captures the idea represented in my 3rd option.
In my post where I expanded on my POC, I made mention of nextra as an example of a site that keeps the nav scroll in-sync with the window scroll and they still do this (although it's very temperamental from what I can tell currently).  Also, the POC I developed offers an example of this, see the Sync w/ Window Scroll instructions.
Again, this is assuming I'm understanding what you are thinking :)
All that said, I think underlying issue(s) here and going back to the title I put on this issue is that there is no current way for a user to even know the right nav is scrollable.  I think this is a usability issue and then dovetails in to an accessibility issue because there needs to be an accessible way to scroll (once the user knows they can).
Given that, I think possibly stepping back from the solution and instead shifting to defining what the goal of the right nav is in the first place, might make the decision clear(er).  I do think that regardless of solution, it must be accessible, that is a given, so from a user story perspective on functionality, as a user, I need to be able to:

identify, quickly, where I am on a page in relation to the overall page
navigate to any primary or secondary section on the page as "quickly" as possible

Curious what the SL team believes the goal(s) are for the right nav, in short, why is it even there?
Assuming the goals are similar to what I've outlined above, my opinion is still the same as it was from the My $0.02 comment I made previously.  While I'm not an accessibility expert, the reason I believe that a scrollbar is required (in addition to scrolling the nav to keep "context" with window scroll) is that it's one thing to give the user an indication that it can scroll and a way to allow scroll, but the method to scroll itself must be accessible and hence why the scrollbar is needed (a visual item) vs. mouse wheel or some other form of event handler.  In this case, assuming a scrollbar is needed for accessibility reasons (not for any other), then having the scrollbar "thin" helps minimize the ascetics concerns we all believe exist with having it there.
All that said, happy to take this whatever direction the SL team would like.
Look forward to hearing yours and other thoughts, thanks!

Thank you very much for providing an example. Nextra Docs is exactly what I meant and mean with the feature that needs to be added. As I said I agree very much with your opinion, but I would rather not see a scrollbar although you reasoned the accessibility very well. I just love good design, my bad, so I think they should at least add an option to disable the scrollbar if the add it in the first place imho...
Let's see what the SL team brings to our future!

Glad I was understanding what you were after correctly :)  The POC I put together is able to demonstrate the Nextra concept.  If you go to https://stackblitz.com/edit/withastro-starlight-5ct6eh and in the "Right Nav" section set "Style" to "scrollbar" and ""Sync w/ Window Scroll" to "yes". You can also set the "Scrollbar" section "Type" to "standard" and "Width" to "thin" to obtain the thin style scrollbar.
I think it really comes down to what the goals of the right nav are to baseline and then from there, whether or not a "scrollbar" is required to meet accessibility guidelines.  Ideally, SL config provides a toggle for all of the "options" although I'm not sure how much configuration bloat the SL team ideally would want to take on maintenance wise.
Either way, look forward to hearing what the SL team thinks!

My suggestion is to listen for changes in the aria-current attribute in the right sidebar and scroll the current heading to a fixed position at the top of the screen. This way, the TOC headings automatically follow the scroll, always staying within the visible area of the screen. I find this more convenient, especially for long documents where manually scrolling through the TOC can sometimes be a hassle.


Splintered traces in video-bench with multi-threading

Describe the bug
Splintered traces in video-bench with multi-threading
Expected behavior
All the spans should have a common trace ID.
Logs

Notes
Tried multi-processing too (like this. This fixes the issue in docker compose, but when using knative, the traces get splintered.

Update: the issue seems to root in the fact that we do not pass the context when invoking many functions at once. It is not very clear how to do that in Python.


Unescaped apostrophes

Please ensure you have given all the following requested information in your report.
Please select the affected platforms

[x ] Android Studio
[ ] IntelliJ IDEA

Version of Plugin and IDE

Plugin Version:1.3
IDE Version:Android Studio 3.5
Build #AI-191.8<IP_ADDRESS>91312, built on August 9, 2019
JRE: 1.8.0_202-release-1483-b49-5587405 amd64
JVM: OpenJDK 64-Bit Server VM by JetBrains s.r.o
Linux 5.0.0-27-generic

Issue details
Following on from #18 the apostrophes in the translated text are not escaped and Android Studio marks them as an error.

Hi, you can update to V1.4 and set the xliff: g tag to ignore characters or text you don't want to translate.


Why  the file "MetadataChangeEvent.avsc"  is not exist

[root@localhost kafka-etl]# python3 metadata-ingestion/mce-cli/mce_cli.py produce -l metadata-events/mxe-schemas/src/renamed/avro/com/linkedin/mxe/MetadataChangeEvent.avsc -d metadata-ingestion/mce-cli/bootstrap_mce.dat
python3: can't open file 'metadata-ingestion/mce-cli/mce_cli.py': [Errno 2] No such file or directory
[root@localhost kafka-etl]# pwd
/root/datahub-0.4.3/metadata-ingestion/kafka-etl
[root@localhost kafka-etl]# ls
kafka_etl.py  requirements.txt
In fact, it's the file that doesn't exist，as follows:
/root/datahub-0.4.3/metadata-events/mxe-schemas
[root@localhost mxe-schemas]# ls
build.gradle  rename-namespace.sh
I know the file "metadata-events/mxe-schemas/src/renamed/avro/com/linkedin/mxe/MetadataChangeEvent.avsc " is not exist.
this file does not exist now. Do I want to know if this file is temporary?  Will the data be cleaned up after  loading  data？

The file is generated as part of the build and hence the step 2 in https://github.com/linkedin/datahub/tree/master/metadata-ingestion

#step-1
cd ~/datahub
#step-2
./gradlew :metadata-events:mxe-schemas:build

Assuming this has been answered. Feel free to reopen otherwise.


HFSaveCheckpoint does not work with deepspeed

🐛 Bug
HFSaveCheckpoint does not save a HuggingFace checkpoint when the model is trained with deepspeed. No message or warning appears to indicate that the HF checkpoint did not save.
To Reproduce
Use the HFSaveCheckpoint callback when training with deepspeed. I encountered this on both a multinode (Azure) and a single node (local) environment.
Code sample
import os
from typing import Any, List, Optional, Dict
from pytorch_lightning.utilities.types import _PATH

from pytorch_lightning import Trainer
from transformers import AutoTokenizer
from pytorch_lightning import seed_everything

from lightning_transformers.task.nlp.text_classification import (
    TextClassificationDataModule,
    TextClassificationTransformer,
)
from lightning_transformers.plugins.checkpoint import HFSaveCheckpoint
from pytorch_lightning.callbacks import ModelCheckpoint

model_arch="prajjwal1/bert-tiny"

seed_everything(102938, workers = True)
tokenizer = AutoTokenizer.from_pretrained(model_arch)

dm = TextClassificationDataModule(
        tokenizer = tokenizer,
        train_val_split = 0.01, # Split used for creating a validation set out of the training set
        dataset_name = "glue",
        dataset_config_name = "cola",
        batch_size=1,
        num_workers=os.cpu_count(),
        padding="max_length",
        truncation=True,
        max_length=512
    )

model = TextClassificationTransformer(
    pretrained_model_name_or_path=model_arch
    )

checkpoint_callback = ModelCheckpoint(save_top_k=1,monitor="val_loss")

trainer = Trainer(
accelerator='gpu',
plugins=HFSaveCheckpoint(model=model),
callbacks=[checkpoint_callback],
logger=False,
enable_checkpointing=True,
log_every_n_steps=10,
limit_train_batches=30,
limit_val_batches=10,
max_epochs=2,
strategy='deepspeed_stage_3'
)

trainer.fit(model,dm)

print(f"Best model path: {checkpoint_callback.best_model_path}")

Expected behavior
Either a warning is thrown or the HF model saves properly.
Environment
Lightning transformers 0.2.1
* CUDA:
        - GPU:
                - Quadro T2000 with Max-Q Design
        - available:         True
        - version:           11.3
* Packages:
        - numpy:             1.22.3
        - pyTorch_debug:     False
        - pyTorch_version:   1.11.0
        - pytorch-lightning: 1.6.4
        - tqdm:              4.64.0
* System:
        - OS:                Linux
        - architecture:
                - 64bit
                - ELF
        - processor:         x86_64
        - python:            3.8.13
        - version:           #44-Ubuntu SMP Wed Jun 22 14:20:53 UTC 2022

Thanks for the report!
This is tricky as when using deepspeed stage 3, checkpoints are saved as shards as opposed to a single checkpoint.
One thing you might benefit from is saving normally using lightning, then using https://github.com/Lightning-AI/lightning/blob/master/src/pytorch_lightning/utilities/deepspeed.py#L52 to combine the checkpoints into one. After this, load the checkpoints into theTextClassificationTransformer and call the save_hf_checkpoint function.
It would be nice to have an automated system to do this, but I'm worried that adding too much automation will cause overhead. Let me know if this solution works for you in the meantime!

@SeanNaren, thanks that solution worked nicely. I added this code to the end of the script in the original post:
aggregated_checkpoint_path="checkpoints/aggregated"
hf_checkpoint_path="checkpoints/hf_checkpoint"

# Convert sharded checkpoint files into a single checkpoint file
#https://github.com/Lightning-AI/lightning/blob/master/src/pytorch_lightning/utilities/deepspeed.py#L52
convert_zero_checkpoint_to_fp32_state_dict(
    checkpoint_callback.best_model_path,
    aggregated_checkpoint_path
 )

# Load best model from aggregated checkpoint file
best_model = TextClassificationTransformer.load_from_checkpoint(
    aggregated_checkpoint_path
)

# Save model and tokenizer to HF checkpoint
best_model.model.save_pretrained(hf_checkpoint_path)
tokenizer.save_pretrained(hf_checkpoint_path)

@SeanNaren one follow up on this - although the code above worked for a local environment (1 gpu on 1 node), I run into this error when convert_zero_checkpoint_to_fp32_state_dict runs on a 2 node, 2 gpu per node setup on Azure:
ValueError: Expected 4 of '*_optim_states.pt' under '/mnt/batch/tasks/shared/LS_root/jobs/abcinc-stg-amls/azureml/lightning_logs_1658428572_624ce516/wd/azureml/lightning_logs_1658428572_624ce516/checkpoints/best.ckpt/checkpoint' but found 2 files. Possibly due to an overwrite of an old checkpoint, or a checkpoint didn't get saved by one or more processes.
total 36

It looks like it is only seeing the checkpoint files from one of the two nodes. I tried inserting trainer.strategy.barrier()   immediately after trainer.fit() and only running the checkpoint conversion code on the root process (trainer.is_global_zero == True), but this didn't fix the issue.
Is there a way to run the checkpoint convert function on a multinode environment or should I just be running it in a separate script/process?

There is probably a more elegant solution, but what ended up working for me was to have the root process of each node upload the files to Azure immediately after trainer.fit():
# Run one upload process per node to make sure we capture all the sharded checkpoint files
if os.environ.get("LOCAL_RANK") == "0":
    print(f"Uploading best model checkpoints (sharded) to {checkpoints_upload_path}")
    datastore.upload(
                    src_dir=checkpoint_callback.best_model_path,
                    target_path=checkpoints_upload_path,
                    overwrite=True
                    )

In a separate process I can then download all these sharded checkpoint files from Azure and run the code above to convert them to a single checkpoint file.

getting this error while loading a language model
RuntimeError: Error(s) in loading state_dict for LanguageModelingTransformer:
Missing key(s) in state_dict: "model.lm_head.weight".
any leads?


[utils] Add --{cc,cxx} options to build-script

Make it a bit easier to use a custom compiler or shim script to build swift & co.
Address review comments: drop the "with" prefix, only grab host_clang when it's needed.
This is an updated version of an earlier PR: https://github.com/apple/swift/pull/1037#issuecomment-173693840. I should have reused the PR but accidentally deleted my branch.

Regarding Jordan's comment about inferring cc from cxx or vice versa: would we have to ask the user if the build-script's guess is ok?

I'd suggest that we don't try to infer, since it is not obvious where to insert the '++' if the 'cc' name is not 'clang'.  Some distributions append version numbers in different formats, or platform names, or variant names or add prefixes.

I would certainly allow overriding, but in the simple case where we have just --cc passed, and doing one of the following transformations resolves to an executable, I'd prefer to have that executable chosen.

CC
CXX

gcc
g++

cc
c++

clang
clang++

If not that, can we at least give a warning for providing one but not the other? That's probably never intended.

Addressed review comments.
This version uses CompilerExecutable to avoid constructing host_clang twice, and to provide 'smart' suggestions when either CC or CXX are missing. It's done in a longest-suffix-first way which should address Dmitri's concern.

Ah, I was suggesting also checking that there is an executable file on disk by that name. Otherwise, it's probably an error.

Sure, but IMO that's what configure is for.

@jrose-apple CMake will fail with a good enough error if the compiler does not exist.

After thinking about this a bit more, I don't think build-script should make guesses about which host compiler the user wants. It's a bit messy and a minor convenience at best.
Stepping back even further, ISTM the best way to get this functionality is to append "-- --host-cc CC --host-cxx CXX" to the build-script invocation. Maybe we can revisit this with SR-237 later.


[WFCORE-639] : ManagementPermissionAuthorizer is limited to the standard roles for its authorizeJmxOperation impl

Removing the JmxPermissionFactory as it has no real value.
Adding tests in domain mode.
Jira: https://issues.jboss.org/browse/WFCORE-639
https://github.com/wildfly/wildfly/pull/7401 is required for full integration

Windows Build 1301 is now running using a merge of 601179d7783f0f7599df9a2e24af96a1e4940093

Core - Full Integration Build 893 is now running using a merge of 601179d7783f0f7599df9a2e24af96a1e4940093

Linux Build 1736 is now running using a merge of 601179d7783f0f7599df9a2e24af96a1e4940093

Core - Full Integration Build 893 outcome was FAILURE using a merge of 601179d7783f0f7599df9a2e24af96a1e4940093
Summary: Tests passed: 573, ignored: 229; exit code 1 (new) Build time: 0:04:25
Build problems:
Process exited with code 1

Windows Build 1301 outcome was SUCCESS using a merge of 601179d7783f0f7599df9a2e24af96a1e4940093
Summary: Tests passed: 3115, ignored: 66 Build time: 0:20:31

Linux Build 1736 outcome was SUCCESS using a merge of 601179d7783f0f7599df9a2e24af96a1e4940093
Summary: Tests passed: 3115, ignored: 66 Build time: 0:22:41

Linux Build 1738 is now running using a merge of da11caa09b41629d9ed8b4703a448f3f11d78f49

Core - Full Integration Build 895 is now running using a merge of da11caa09b41629d9ed8b4703a448f3f11d78f49

Windows Build 1303 is now running using a merge of da11caa09b41629d9ed8b4703a448f3f11d78f49

Core - Full Integration Build 895 outcome was FAILURE using a merge of da11caa09b41629d9ed8b4703a448f3f11d78f49
Summary: Tests passed: 573, ignored: 229; exit code 1 Build time: 0:04:10
Build problems:
Process exited with code 1

Windows Build 1303 outcome was SUCCESS using a merge of da11caa09b41629d9ed8b4703a448f3f11d78f49
Summary: Tests passed: 3107, ignored: 66 Build time: 0:20:29

Linux Build 1738 outcome was SUCCESS using a merge of da11caa09b41629d9ed8b4703a448f3f11d78f49
Summary: Tests passed: 3107, ignored: 66 Build time: 0:22:37

Windows Build 1309 is now running using a merge of b129d5ca8e3565ae99a142a176df6753081cfb93

Core - Full Integration Build 901 is now running using a merge of b129d5ca8e3565ae99a142a176df6753081cfb93

Linux Build 1745 is now running using a merge of b129d5ca8e3565ae99a142a176df6753081cfb93

Core - Full Integration Build 901 outcome was FAILURE using a merge of b129d5ca8e3565ae99a142a176df6753081cfb93
Summary: Tests passed: 572, ignored: 202; exit code 1 Build time: 0:04:09
Build problems:
Process exited with code 1

Windows Build 1309 outcome was SUCCESS using a merge of b129d5ca8e3565ae99a142a176df6753081cfb93
Summary: Tests passed: 3107, ignored: 66 Build time: 0:20:18

Linux Build 1745 outcome was SUCCESS using a merge of b129d5ca8e3565ae99a142a176df6753081cfb93
Summary: Tests passed: 3107, ignored: 66 Build time: 0:22:52

Windows Build 1352 is now running using a merge of f76e17f52dfd15780775ffe72fbc7721bc668632

Core - Full Integration Build 945 is now running using a merge of f76e17f52dfd15780775ffe72fbc7721bc668632

Linux Build 1793 is now running using a merge of f76e17f52dfd15780775ffe72fbc7721bc668632

Core - Full Integration Build 945 outcome was FAILURE using a merge of f76e17f52dfd15780775ffe72fbc7721bc668632
Summary: Tests passed: 572, ignored: 202; exit code 1 Build time: 0:04:34
Build problems:
Process exited with code 1

Windows Build 1352 outcome was SUCCESS using a merge of f76e17f52dfd15780775ffe72fbc7721bc668632
Summary: Tests passed: 3110, ignored: 66 Build time: 0:21:02

Linux Build 1793 outcome was SUCCESS using a merge of f76e17f52dfd15780775ffe72fbc7721bc668632
Summary: Tests passed: 3110, ignored: 66 Build time: 0:23:03

Core - Full Integration Build 947 is now running using a merge of 35fde871fbddf2c4a02fbf6566996853b556a8c9

Windows Build 1354 is now running using a merge of 35fde871fbddf2c4a02fbf6566996853b556a8c9

Linux Build 1796 is now running using a merge of 35fde871fbddf2c4a02fbf6566996853b556a8c9

Core - Full Integration Build 947 outcome was FAILURE using a merge of 35fde871fbddf2c4a02fbf6566996853b556a8c9
Summary: Tests passed: 572, ignored: 202; exit code 1 Build time: 0:04:15
Build problems:
Process exited with code 1

Windows Build 1354 outcome was SUCCESS using a merge of 35fde871fbddf2c4a02fbf6566996853b556a8c9
Summary: Tests passed: 3111, ignored: 66 Build time: 0:20:50

Linux Build 1796 outcome was SUCCESS using a merge of 35fde871fbddf2c4a02fbf6566996853b556a8c9
Summary: Tests passed: 3111, ignored: 66 Build time: 0:22:35

Linux Build 1800 is now running using a merge of a113c598b2f8c82140e2a693af9966d07ec3757a

Core - Full Integration Build 950 is now running using a merge of a113c598b2f8c82140e2a693af9966d07ec3757a

Windows Build 1357 is now running using a merge of a113c598b2f8c82140e2a693af9966d07ec3757a

Core - Full Integration Build 950 outcome was FAILURE using a merge of a113c598b2f8c82140e2a693af9966d07ec3757a
Summary: Tests passed: 572, ignored: 202; exit code 1 Build time: 0:04:44
Build problems:
Process exited with code 1

Windows Build 1357 outcome was SUCCESS using a merge of a113c598b2f8c82140e2a693af9966d07ec3757a
Summary: Tests passed: 3111, ignored: 69 Build time: 0:21:12

Linux Build 1800 outcome was SUCCESS using a merge of a113c598b2f8c82140e2a693af9966d07ec3757a
Summary: Tests passed: 3111, ignored: 69 Build time: 0:23:00

Linux Build 1839 is now running using a merge of 9f24031ab9093a44c451342ec418a04f8bb188ad

Windows Build 1389 is now running using a merge of 9f24031ab9093a44c451342ec418a04f8bb188ad

Core - Full Integration Build 985 is now running using a merge of 9f24031ab9093a44c451342ec418a04f8bb188ad

Core - Full Integration Build 985 outcome was FAILURE using a merge of 9f24031ab9093a44c451342ec418a04f8bb188ad
Summary: Tests passed: 572, ignored: 202; exit code 1 Build time: 0:04:20
Build problems:
Process exited with code 1

Windows Build 1389 outcome was SUCCESS using a merge of 9f24031ab9093a44c451342ec418a04f8bb188ad
Summary: Tests passed: 3115, ignored: 69 Build time: 0:20:54

Linux Build 1839 outcome was SUCCESS using a merge of 9f24031ab9093a44c451342ec418a04f8bb188ad
Summary: Tests passed: 3115, ignored: 69 Build time: 0:22:21

Core - Full Integration Build 993 is now running using a merge of 1f563eb18d10ac0f1110254d4f656f97f5f2e72c

Linux Build 1847 is now running using a merge of 1f563eb18d10ac0f1110254d4f656f97f5f2e72c

Windows Build 1397 is now running using a merge of 1f563eb18d10ac0f1110254d4f656f97f5f2e72c

Core - Full Integration Build 993 outcome was FAILURE using a merge of 1f563eb18d10ac0f1110254d4f656f97f5f2e72c
Summary: Tests passed: 572, ignored: 202; exit code 1 Build time: 0:04:30
Build problems:
Process exited with code 1

Windows Build 1397 outcome was SUCCESS using a merge of 1f563eb18d10ac0f1110254d4f656f97f5f2e72c
Summary: Tests passed: 3115, ignored: 69 Build time: 0:20:33

Linux Build 1847 outcome was SUCCESS using a merge of 1f563eb18d10ac0f1110254d4f656f97f5f2e72c
Summary: Tests passed: 3115, ignored: 69 Build time: 0:22:36

Windows Build 1398 is now running using a merge of a5ccacc3f1f7259ca9200238a21eaf909cad2ca6

Linux Build 1848 is now running using a merge of a5ccacc3f1f7259ca9200238a21eaf909cad2ca6

Core - Full Integration Build 994 is now running using a merge of a5ccacc3f1f7259ca9200238a21eaf909cad2ca6

Windows Build 1398 outcome was SUCCESS using a merge of a5ccacc3f1f7259ca9200238a21eaf909cad2ca6
Summary: Tests passed: 3117, ignored: 69 Build time: 0:20:41

Linux Build 1848 outcome was SUCCESS using a merge of a5ccacc3f1f7259ca9200238a21eaf909cad2ca6
Summary: Tests passed: 3117, ignored: 69 Build time: 0:22:37

Core - Full Integration Build 994 outcome was SUCCESS using a merge of a5ccacc3f1f7259ca9200238a21eaf909cad2ca6
Summary: Tests passed: 2862, ignored: 374, muted: 1 Build time: 0:50:01

This looks good; just needs a JmxRBACProviderHostScopedRolesTestCase.

Core - Full Integration Build 1006 is now running using a merge of 4d3e1480932e46556d49f24027eee21899cc6734

Linux Build 1861 is now running using a merge of 4d3e1480932e46556d49f24027eee21899cc6734

Windows Build 1410 is now running using a merge of 4d3e1480932e46556d49f24027eee21899cc6734

Windows Build 1410 outcome was SUCCESS using a merge of 4d3e1480932e46556d49f24027eee21899cc6734
Summary: Tests passed: 3119, ignored: 69 Build time: 0:20:57

Linux Build 1861 outcome was SUCCESS using a merge of 4d3e1480932e46556d49f24027eee21899cc6734
Summary: Tests passed: 3119, ignored: 69 Build time: 0:23:07

Core - Full Integration Build 1006 outcome was SUCCESS using a merge of 4d3e1480932e46556d49f24027eee21899cc6734
Summary: Tests passed: 2863, ignored: 374 Build time: 0:50:55

Core - Full Integration Build 1007 is now running using a merge of 9a5ab29aeca4cc175e4ec7afa11af746e040f375

Windows Build 1411 is now running using a merge of 9a5ab29aeca4cc175e4ec7afa11af746e040f375

Linux Build 1862 is now running using a merge of 9a5ab29aeca4cc175e4ec7afa11af746e040f375

Windows Build 1411 outcome was FAILURE using a merge of 9a5ab29aeca4cc175e4ec7afa11af746e040f375
Summary: Tests failed: 7 (7 new), passed: 3110, ignored: 69 Build time: 0:20:55
Build problems:
Failed tests detected
Failed tests
org.jboss.as.test.manualmode.management.cli.CustomVaultInCLITestCase.testWrongVaultPassword: <no details avaliable>

org.jboss.as.test.manualmode.management.cli.CustomVaultInCLITestCase.testNonExistingVaultPassword: <no details avaliable>

org.jboss.as.test.manualmode.management.cli.CustomVaultInCLITestCase.testRightVaultPassword: <no details avaliable>

org.jboss.as.test.manualmode.vault.CustomVaultInModuleTestCase: <no details avaliable>

org.jboss.as.test.manualmode.vault.VaultPasswordsInCLITestCase.testWrongVaultPassword: <no details avaliable>

org.jboss.as.test.manualmode.vault.VaultPasswordsInCLITestCase.testRightVaultPassword: <no details avaliable>

org.wildfly.core.test.standalone.mgmt.HTTPSConnectionWithCLITestCase.testTrustedCLICertificate: <no details avaliable>

Linux Build 1862 outcome was SUCCESS using a merge of 9a5ab29aeca4cc175e4ec7afa11af746e040f375
Summary: Tests passed: 3117, ignored: 69 Build time: 0:23:08

Core - Full Integration Build 1007 outcome was SUCCESS using a merge of 9a5ab29aeca4cc175e4ec7afa11af746e040f375
Summary: Tests passed: 2862, ignored: 374, muted: 1 Build time: 0:50:16

Core - Full Integration Build 1027 is now running using a merge of dcc5347790857fb5029c350431cf10c20b258cc8

Linux Build 1883 is now running using a merge of dcc5347790857fb5029c350431cf10c20b258cc8

Windows Build 1438 is now running using a merge of dcc5347790857fb5029c350431cf10c20b258cc8

Windows Build 1438 outcome was SUCCESS using a merge of dcc5347790857fb5029c350431cf10c20b258cc8
Summary: Tests passed: 3117, ignored: 69 Build time: 0:21:21

Linux Build 1883 outcome was SUCCESS using a merge of dcc5347790857fb5029c350431cf10c20b258cc8
Summary: Tests passed: 3117, ignored: 69 Build time: 0:22:53

Core - Full Integration Build 1027 outcome was SUCCESS using a merge of dcc5347790857fb5029c350431cf10c20b258cc8
Summary: Tests passed: 2867, ignored: 374 Build time: 0:48:03

Core - Full Integration Build 1028 is now running using a merge of 466abd1769d96cbf9fab98fe398803da4b2beb64

Linux Build 1884 is now running using a merge of 466abd1769d96cbf9fab98fe398803da4b2beb64

Windows Build 1439 is now running using a merge of 466abd1769d96cbf9fab98fe398803da4b2beb64

Windows Build 1439 outcome was SUCCESS using a merge of 466abd1769d96cbf9fab98fe398803da4b2beb64
Summary: Tests passed: 3122, ignored: 71 Build time: 0:20:22

Linux Build 1884 outcome was SUCCESS using a merge of 466abd1769d96cbf9fab98fe398803da4b2beb64
Summary: Tests passed: 3122, ignored: 71 Build time: 0:23:01

Core - Full Integration Build 1028 outcome was SUCCESS using a merge of 466abd1769d96cbf9fab98fe398803da4b2beb64
Summary: Tests passed: 2866, ignored: 374, muted: 1 Build time: 0:48:50


DispatchHttpCall from OnTick() results in runtime.nilPanic

PLEASE FILL IN THE FOLLOWINGS for EVERY ISSUE you make.
Describe the bug / error
I have a filter that processes HTTP requests and caches data about the request/response OnHttpStreamDone(). Then OnTick(); we process the data and POST it to an external endpoint.
func (ctx *rootContext) OnTick() {
	length := len(buffer)
	if length == 0 {
		return
	}

	gatewayLoggerReqHeaders := [][2]string{
		{":method", "POST"}, {":path", "/foobar"}, {":authority", cfg.GetExternalEndpointDNSName()}, {":scheme", "https"},
	}
	for i:=0; i < length; i++ {
		if _, err := proxywasm.DispatchHttpCall(
			cfg.GetUpstreamClusterName(), ReqHeaders, buffer[i], [][2]string{}, 5000, httpCallResponseCallback);
		err != nil {
			proxywasm.LogCriticalf("Failed to dispatch http call", err)
		} else {
			proxywasm.LogInfo("Successfully dispatched HTTP POST")
		}
	}
	// Remove elements we have consumed
	buffer = buffer[length:]
}

This results in the following error
2021-07-20T06:31:38.974139Z	error	envoy wasm	Function: proxy_on_tick failed: Uncaught RuntimeError: unreachable
Proxy-Wasm plugin in-VM backtrace:
  0:  0x3fe9 - runtime.runtimePanic
  1:  0x19ba - runtime.nilPanic
  2:  0x16676 - proxy_on_tick

What is your Envoy/Istio version?
$ istioctl version
istiod version: 1.9.5
data plane version:  1.9.5
What is the SDK version?
0.3.0
What is your TinyGo version?
$ tinygo version
tinygo version 0.18.0 darwin/amd64 (using go version go1.16.5 and LLVM version 11.0.0)
URL or snippet of your code including Envoy configuration
Additional context (Optional)

@abhide thanks for reporting this, and this looks like a bug of SDK. Do you have any small reproducer I can use to investigate?

@mathetake Thanks for getting back promptly.
I don't have a small repro. You could modify the examples to actually make a POST call
https://github.com/tetratelabs/proxy-wasm-go-sdk/blob/v0.13.0/examples/dispatch_call_on_tick/main.go

Another data point; I can see the first POST HTTP request from OnTick() is making to the external endpoint but then its failing in the plugin. Something that's evident from trace level logs.
2021-07-20T07:13:19.044286Z     trace   envoy wasm      [vm<-host] env.proxy_log return: 0
2021-07-20T07:13:19.044296Z     trace   envoy wasm      [vm->host] env.proxy_http_call(79600, 73, 99844, 176, 94436, 434, 100020, 4, 5000, 65348)
2021-07-20T07:13:19.044580Z     trace   envoy wasm      [vm<-host] env.proxy_http_call return: 0
2021-07-20T07:13:19.044603Z     trace   envoy wasm      [vm->host] wasi_snapshot_preview1.fd_write(1, 74060, 1, 78400)
2021-07-20T07:13:19.044608Z     info    envoy wasm      wasm log gateway-logger-filter-root-id: panic: runtime error: nil pointer dereference
2021-07-20T07:13:19.044612Z     trace   envoy wasm      [vm<-host] wasi_snapshot_preview1.fd_write return: 0
2021-07-20T07:13:19.044763Z     error   envoy wasm      Function: proxy_on_tick failed: Uncaught RuntimeError: unreachable
Proxy-Wasm plugin in-VM backtrace:
  0:  0x3fe7 - runtime.runtimePanic
  1:  0x19b8 - runtime.nilPanic
  2:  0x16416 - proxy_on_tick

I found a bug around on_tick and fixed in https://github.com/tetratelabs/proxy-wasm-go-sdk/pull/202 but not sure this fixes your crash. Could you try this out by the followings? (the API has changed since your version but I hope the necessary change to your code is not big).
$ go mod edit -require=github.com/tetratelabs/proxy-wasm-go-sdk@main
$ go mod download github.com/tetratelabs/proxy-wasm-go-sdk

Thanks @mathetake. Your fix is working and I don't see nilPanic as before.
When do we expect this to be part of an official release?
Adding my teammate @bvandewalle

OK just released v0.14.0 https://github.com/tetratelabs/proxy-wasm-go-sdk/releases/tag/v0.14.0 - thanks for reporting and testing the patch! Now closing issue.

Amazing! Thanks for your fix @mathetake.
:+1: :100:


$ inside PageObject should search elements inside SelenideDriver in…

… which PageObject was created #1048
Proposed changes
This is very rough PoC of driver for PageObject instance.
Key changes:

Javassist dependency to create sub-class proxies of PageObject classes
DriverOrchestrator bridge from driver to static facade required
Proxy can be create only for public and non-final classes
PageObject created in context of the driver, fields set with correct driver
On each method invocation of PageObject proxy correct driver set to main ThreadLocal

Only illustrates the general idea and should not be merged.

@asolntsev We are going crazy here

It's not just crazy.  :)

It's not just crazy.  :)

Jokes aside I believe that Selenide should provide convenient base class for Page classes with driver passed to constructor and with all Selenide $ / $$ methods in this base class. That would be easier and cleaner solution.

Sorry, but it seems to be over-complicated. Let's think about a simpler solution, or leave it unsolved at all. The problem itself was not too big.


Update documentation

Updated the "man page" section starting at line 414 to make the documentation more accurate, readable, and useful.
Fixed some grammar issues

Ticket
DOC-50
Type of PR

[ ] Bugfix
[ ] New feature
[x] Minor changes

Changes introduced

Put commands in alpha order (because the old order seemed random).
Fixed grammar issues.
Parsed the code to get and add more details re: arguments, parameters, options, etc.
Changed the doc link on line 74 to the main documentation page.

Test and review
Compare to the previous version.

@Daniel Sousa @.***>, I'll leave this to you for now.
Let me know when you're ready for me to re-review the contents of the file.
On Mon, Apr 15, 2024 at 12:28 PM Cody Redmond @.***>
wrote:

@.**** commented on this pull request.
In index.js
https://github.com/crowdbotics/cli/pull/74#discussion_r1566085911:

Arguments:

   --source: (Optional) Specifies the source directory for modules (defaults to the Crowdbotics modules directory based on package location).

   --project: (Optional) Specifies the project directory to install modules into (defaults to the git root of the current working directory).

Parameters:

   <module1> <module2>: Names of the modules to install (required).

Example: cb add module1 module2

@danielsousaio https://github.com/danielsousaio I totally agree, I
think your suggestion is great: a short and concise cb --help and then
each subcommand has it's own --help with more detail and example. Thanks
for following up on this.
—
Reply to this email directly, view it on GitHub
https://github.com/crowdbotics/cli/pull/74#discussion_r1566085911, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/BFW5LB3GLQOSWYOSST7VFJ3Y5P5ZXAVCNFSM6AAAAABF5DUTPCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDAMBRGU4DSMJRGI
.
You are receiving this because you were mentioned.Message ID:
@.***>