Improve decorator typing

See also https://github.com/pallets/quart/commit/7f9e9e25d1d2d6823673b286ad981d6089a26e3b
Checklist:

[x] Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
[x] Add or update relevant docs, in the docs folder and in code.
[ ] Add an entry in CHANGES.rst summarizing the change and linking to the issue.
[x] Add .. versionchanged:: entries in any relevant code docs.
[x] Run pre-commit hooks and fix any issues.
[x] Run pytest and tox, no tests failed.

Can you add some tests to test/typing? See the routes for an example, it doesn't have to represent a real application, just lots of stuff that should each pass these type checks.


[hotfix-#1553][jdbc] Fixed endlocation not being set  bug for 1.12_release

… the amount of readable data was 0

Purpose of this pull request

Fixed the same issue for 1.12_release
Which issue you fix
Fixes # (issue).
#1553
Checklist:

[ ] I have executed the 'mvn spotless:apply' command to format my code.
[ ] I have a meaningful commit message (including the issue id, the template of commit message is '[label-type-#issue-id][fixed-module] a meaningful commit message.')
[ ] I have performed a self-review of my own code.
[ ] I have commented my code, particularly in hard-to-understand areas.
[ ] I have made corresponding changes to the documentation.
[ ] I have added tests that prove my fix is effective or that my feature works.
[ ] New and existing unit tests pass locally with my changes.
[ ] I have checked my code and corrected any misspellings.
[ ] My commit is only one. (If there are multiple commits, you can use 'git squash' to compress multiple commits into one.)

https://github.com/DTStack/chunjun/pull/1555


Update DG for vfind command

As per stated

udw to add design considerations ah? like alternative implementations for different aspects of the command

aight good idea


Store output Type information for each ScanSpec node

This PR incorporates outputType_ as output type information into ScanSpec nodes recursively to all its children. This type information is essential for determining the appropriate Parquet Column Reader. This particular reader is then utilized to generate a Flat Vector that matches the outputType_. This update is one of the modifications necessary for issue #5770.

@srinivasst This is nice to have (for debug) but not necessarily needed as these types should already be available in the corresponding column readers.  Is there a particular reason you cannot get it from the column reader?

Thanks for the review @Yuhta.
The requestedType, which is available in ParquetColumnReader.cpp, are set based on the schema present in the parquet file. The outputType, being set in ScanSpec, is based on the TableScan's expected output type.
The issue occurs when the expected output of the TableScan differs from the schema of the parquet file. Spark's data format for some types differs from Parquet's format. Similar to schema evolution, when the type differs, Spark performs an implicit conversion. The conversions that Spark performs can be seen in ParquetVectorUpdaterFactory.java.

@srinivasst requestedType should be fixed to use the table schema type

For IntegerColumnReader, both requestedType and dataType are initialized with the same dataType in ParquetColumnReader.cpp
return std::make_unique<IntegerColumnReader>(
          dataType, dataType, params, scanSpec);

dataType comes from the parquet file's metadata when initializing the schema here.
We need readerOutputType_ for each column which comes from TableScan.
I could not find a way to access readerOutputType_ for each column in the column readers without this change.

@srinivasst We need to find a way to pass down the table schema somehow.  The schema is stored in RowReaderOptions::getSelector().  DWRF already uses that to populate requestedType_ and Parquet should do the same.

@srinivasst We need to find a way to pass down the table schema somehow. The schema is stored in RowReaderOptions::getSelector(). DWRF already uses that to populate requestedType_ and Parquet should do the same.

hey @Yuhta  thank you for your comments, sriniva doesn't own this part change anymore with new job position. I will continue this part of work. I will send another PR to address your comments.

@Yuhta can you help review my PR https://github.com/facebookincubator/velox/pull/6404 to address the requestDataType issue of parquet column reader


Suddenly a Frameworks dir is being created even though nothing uses it.

[x] are reporting a bug others will be able to reproduce and not asking a question. If you're not sure or want to ask a question do so on our Discourse: https://discourse.brew.sh
[x] ran a brew command and reproduced the problem with multiple formulae? If it's a problem with a single, official formula (not cask) please file this issue at Homebrew/homebrew-core: https://github.com/Homebrew/homebrew-core/issues/new/choose. If it's a brew cask problem please file this issue at https://github.com/Homebrew/homebrew-cask/issues/new/choose. If it's a tap (e.g. Homebrew/homebrew-php) problem please file this issue at the tap.
[x] ran brew update and can still reproduce the problem?
[x] ran brew doctor, fixed all issues and can still reproduce the problem?
[x] ran brew config and brew doctor and included their output with your issue?

To my surprise, my HOMEBREW_PREFIX now contains a Frameworks dir, even though it's empty and nothing I brew (or ever have brewed) uses such a thing.  This dir should only be created if it's needed.
If I delete it, it comes back sometime later automatically during some install step---even if the installed thing does not and could not use such a dir (e.g., markdown).  But if I first run doctor, I get the following:
Warning: The following directories do not exist:
/usr/local/Frameworks

You should create these directories and change their ownership to your account.
  sudo mkdir -p /usr/local/Frameworks
  sudo chown -R $(whoami) /usr/local/Frameworks

No, I should not.  The dir's absence is not a problem, its presence is irritating, and that dir should not be auto-created by install (unless the formula I'm installing needs it).
That doctor check should only complain if I already have a Frameworks dir but it has the wrong permissions.
brew config
HOMEBREW_VERSION: 1.7.4-8-ga1fd93a
ORIGIN: https://github.com/Homebrew/brew
HEAD: a1fd93aacea37bbc234d347e3e5089f22846be18
Last commit: 26 minutes ago
Core tap ORIGIN: https://github.com/Homebrew/homebrew-core
Core tap HEAD: 969f49df56e2749badf92d913a1ea79fa04dab2e
Core tap last commit: 2 hours ago
HOMEBREW_PREFIX: /usr/local
HOMEBREW_REPOSITORY: /usr/local/hb
HOMEBREW_CACHE: /stuff/brache
HOMEBREW_TEMP: /Users/chdiza/.tmp/tmpdir
HOMEBREW_DEV_CMD_RUN: 1
HOMEBREW_GIT: git
HOMEBREW_LOGS: /Users/chdiza/Library/Homebrew
HOMEBREW_NO_ANALYTICS: 1
HOMEBREW_NO_AUTO_UPDATE: 1
HOMEBREW_NO_EMOJI: 1
HOMEBREW_NO_GITHUB_API: 1
CPU: quad-core 64-bit ivybridge
Homebrew Ruby: 2.3.7 => /System/Library/Frameworks/Ruby.framework/Versions/2.3/usr/bin/ruby
Clang: 9.1 build 902
Git: 2.19.0 => /usr/local/bin/git
Curl: 7.54.0 => /usr/bin/curl
Java: N/A
macOS: 10.13.6-x86_64
CLT: <IP_ADDRESS>.1.1528165917
Xcode: 9.4.1
XQuartz: N/A

$ brew doctor
Your system is ready to brew.

Bisection reveals:
7615d3a8121a251dc747ddcbe3e040ddf64963d6 is the first bad commit
commit 7615d3a8121a251dc747ddcbe3e040ddf64963d6
Author: Mike McQuaid<EMAIL_ADDRESS>Date:   Thu Sep 6 18:38:43 2018 +0100

    Improve writable directory handling

    Consolidate the handling of which directories need to exist and which
    need to be writable. Additionally, add a fatal check for formula
    installations to ensure that any directories that need to be writable
    are so before attempting an installation.

    Fixes #4626.

Fair enough.  I still think the doctor is being overzealous here: why tell me to create the dir, when brew is going to automatically create it the instant I try to install anything?  There is thus zero danger that the dir will fail to exist before it's needed, and there no need for me to do anything.


bug when running createTabularData for indicators

Describe the bug
When running createTabularData(dataDir =  processingFilePath, type = "indicators", bucket = bucket) I get the following error:
Error in strsplit(rawData$habitat, split = "|", fixed = TRUE) :
non-character argument

To Reproduce

Steps to reproduce the behavior:
Go to 'inbo/aspbo/src/upload_processing_to_uat.R
Run 'L13 - L23'
Scroll down to 'L66' & run
See error

Expected behavior
"data_input_checklist_indicators_processed.RData" is updated correctly.
Additional context
I'm using the alienSpecies v0.0.5

I've added the column habitat to data_input_checklist_indicators.tsv but now I get the following error:
Error in createTabularData(dataDir = processingFilePath, type = "indicators",  :
  New habitats detected. Add relevant columns in loadTabularData()

can you guide me to where I need to add these columns ?

Can you put data_input_checklist_indicators.tsv on bucket (just tried the current one, cannot reproduce the error), so I can look into this issue.

I downloaded data from bucket and ran createTabularData( type = "indicators"), but I cannot reproduce the error. The error message will be shown if in habitat there is something else than "marine", "freshwater", "terrestrial", NA. Is data_input_checklist_indicators.tsv on bucket?

I cannot reproduce this error, can you instruct me where the data_input_checklist_indicators.tsv file in your test is located?

I've updated the file at data/output/UAT_processing/ on the 55-[bug]
habitat column missing from griis checklist - branch.
Op ma 18 dec. 2023 16:02 schreef Yingjie Zhang @.***>:

I cannot reproduce this error, can you instruct me where the
data_input_checklist_indicators.tsv file in your test is located?
—
Reply to this email directly, view it on GitHub
https://github.com/inbo/alien-species-portal/issues/66#issuecomment-1860739151,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEAAQOGRPAYJC34BYP6AEZTYKBLKBAVCNFSM6AAAAABAJH65YOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRQG4ZTSMJVGE
.
You are receiving this because you authored the thread.Message ID:
@.***>

commit 22650bc solves the issue
@mvarewyck  loadTabularData() doesn't do any data manipulation anymore, we should change the message accordingly.

@mvarewyck loadTabularData() doesn't do any data manipulation anymore, we should change the message accordingly.

Done https://github.com/inbo/alien-species-portal/commit/295d8f261ce2f97890955e2c169d1ce82229df66


Add better defaults and documentation

So I've been trying to get started with using this plugin...but I have no idea what keymappings are available or how to run a cell or anything...
Can you  help?

@Hooregi are you planning to add such support?
Would be pretty usefull to run and edit cells just as in jupyter

@Hooregi are you planning to add such support?
Would be pretty usefull to run and edit cells just as in jupyter

Check out magma-nvim

@Hooregi are you planning to add such support? Would be pretty useful to run and edit cells just as in jupyter

I'm not a maintainer, just a guy that read the docs haha.

@Hooregi are you planning to add such support? Would be pretty useful to run and edit cells just as in jupyter

I'm not a maintainer, just a guy that read the docs haha.

my bad! :o

@Hooregi are you planning to add such support?
Would be pretty usefull to run and edit cells just as in jupyter

Check out magma-nvim

yep, just discovered this a few hours later!
thanks, i'll investigate that plugin.


README update

The README documentation says for installation to utilize .upToNextMinor(from: "1.0.0") in a Swift Package, but we're clearly past that. I'd recommend updating the docs to utilize branch: "main"

Actually it should be upToNextMajor thanks for calling that out.
100% not main since that's not always release-ready and wouldn't work well for other people's dep etc.


registry preview keyboard shortcut option

Description of the new feature / enhancement
i would like to see an option to have a keyboard shortcut for opening the new registry editor as i feel like this'll benefit the entire user base. i hope this will help you enhance this really cool feature.
Scenario when this would be used?
it will enhance productivity and allow quicker access to the feature.
Supporting information
No response

I agree!  ...that's why I put one in there: Ctrl+R
Should show up as a tooltip when you hover over the toolbar button; please let me know if it's not because that's a bug.


amend: polish RuleMode/RuleChain

Codecov Report

Merging #186 (87d6761) into master (3b7bf03) will decrease coverage by 0.368%.
The diff coverage is 90.000%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files

@@               Coverage Diff               @@
##              master      #186       +/-   ##
===============================================
- Coverage     47.861%   47.493%   -0.368%
+ Complexity      1117      1108        -9
===============================================
  Files            183       183
  Lines           9116      9073       -43
  Branches        2061      2054        -7
===============================================
- Hits            4363      4309       -54
- Misses          3967      3986       +19
+ Partials         786       778        -8

Flag
Coverage Δ

unittests
47.493% <90.000%> (-0.368%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

.../main/kotlin/com/itangcent/common/utils/Streams.kt
14.545% <0.000%> (+0.260%)
:arrow_up:

...in/com/itangcent/intellij/context/ActionContext.kt
45.581% <ø> (-2.170%)
:arrow_down:

...ngcent/intellij/config/rule/DefaultRuleComputer.kt
71.429% <ø> (-3.571%)
:arrow_down:

.../itangcent/intellij/config/AbstractConfigReader.kt
57.576% <66.667%> (-0.256%)
:arrow_down:

.../main/kotlin/com/itangcent/common/utils/IDUtils.kt
97.500% <100.000%> (+0.064%)
:arrow_up:

...in/com/itangcent/intellij/config/rule/RuleChain.kt
100.000% <100.000%> (ø)

...lin/com/itangcent/intellij/config/rule/RuleMode.kt
95.238% <100.000%> (-0.111%)
:arrow_down:

... and 1 file with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b7bf03...87d6761. Read the comment docs.


TigerVNC: .vncserver-wrapped: couldn't find "xinit" on your PATH.

tigervnc does not start due to ".vncserver-wrapped: couldn't find "xinit" on your PATH."
I have this in my NixOS configuration.nix:
   systemd.services."tigervnc-server" =
   { description = "TigerVNC Server";

     wantedBy = [ "multi-user.target" ];

     serviceConfig =
     { StandardError = "journal";
       ExecStart = ''
         ${pkgs.bash}/bin/bash -c 'source ${config.system.build.setEnvironment} ; \
                   exec $SHELL --login -c "exec ${pkgs.tigervnc}/bin/vncserver :5"'
       '';
       Type = "forking";
       User = "milan";
       Restart = "always";
       RestartSec = "10s";
     };
   };

I have xorg enabled:
# Enable the X11 windowing system.
  services.xserver.enable = true;
  services.xserver.layout = "us";
  services.xserver.windowManager.i3.enable = true;

It is server without monitor connected.
Worked good until last update. I am on channel: nixos https://nixos.org/channels/nixos-20.09
It doesn't start even from command line if I install it with nix-shell -p tigervnc

Probably connected with upgrade to 1.10...
From Arch forum:
You probably have an old /etc/pam.d/tigervnc, you need to delete that and rename the newest tigervnc.pacnew to tigervnc, otherwise vncsession-start fails ("Failure daemonizing"/"pam_open_session failed: 28 (Module is unknown)")
I tried to run vncsession and for this failure deamonizing error. There is no /etc/pam.d/tigervnc in my system.

Probably connected with upgrade to 1.10...
From Arch forum:
You probably have an old /etc/pam.d/tigervnc, you need to delete that and rename the newest tigervnc.pacnew to tigervnc, otherwise vncsession-start fails ("Failure daemonizing"/"pam_open_session failed: 28 (Module is unknown)")
I tried to run vncsession and for this failure deamonizing error. There is no /etc/pam.d/tigervnc in my system.

Also from Arch forum (https://bbs.archlinux.org/viewtopic.php?pid=1925998#p1925998)

Delete your previous own created unit (likely is like the wiki instructed here), package has one on its own now and that's the one that works and doesn't use vncserver directly like before but vncsession-start. Don't forget to systemctl daemon-reload, /etc/systemd/system has priority so systemd should be using that instead of the package supplied one in /usr/lib/systemd/system
You need a display manager, xorg-xdm DOESN'T work so lightdm must be used. I didn't use one before at all (headless machine, connecting to VNC via SSH tunnel) so I installed lightdm, otherwise TigerVNC can't start (No Xsession file available, vncsession-start just exits with status 0). Just install it, you don't need to configure it with a greeter or something else. I tried starting lightdm out of curiosity and it failed (status 1/FAILURE) but it doesn't matter for TigerVNC.
Add your user and display on /etc/tigervnc/vncserver.users, otherwise the unit doesn't know which display and user to use ("No user configured for display :1")

Also from Arch forum (https://bbs.archlinux.org/viewtopic.php?pid=1925998#p1925998)

Delete your previous own created unit (likely is like the wiki instructed here), package has one on its own now and that's the one that works and doesn't use vncserver directly like before but vncsession-start. Don't forget to systemctl daemon-reload, /etc/systemd/system has priority so systemd should be using that instead of the package supplied one in /usr/lib/systemd/system
You need a display manager, xorg-xdm DOESN'T work so lightdm must be used. I didn't use one before at all (headless machine, connecting to VNC via SSH tunnel) so I installed lightdm, otherwise TigerVNC can't start (No Xsession file available, vncsession-start just exits with status 0). Just install it, you don't need to configure it with a greeter or something else. I tried starting lightdm out of curiosity and it failed (status 1/FAILURE) but it doesn't matter for TigerVNC.
Add your user and display on /etc/tigervnc/vncserver.users, otherwise the unit doesn't know which display and user to use ("No user configured for display :1")

Anyone have a service already created for this?

Anyone have a service already created for this?

In [pkgs/tools/admin/tigervnc/default.nix], we list a couple of required packages in the PATH. At the time of writing, these are xterm twm xsetroot xauth. The error you pointed out is fixed by adding xinit to this list.
However. It appears that the current version of tigervnc expects an Xsession file in /etc/X11. Hence tigervnc won't work even with this fix. Our tests would have caught this problem -- but unfortunately, I never got around to work on them again, the tests only exist as a pull request (#85214).
I might look into this later, but won't promise anything.

In [pkgs/tools/admin/tigervnc/default.nix], we list a couple of required packages in the PATH. At the time of writing, these are xterm twm xsetroot xauth. The error you pointed out is fixed by adding xinit to this list.
However. It appears that the current version of tigervnc expects an Xsession file in /etc/X11. Hence tigervnc won't work even with this fix. Our tests would have caught this problem -- but unfortunately, I never got around to work on them again, the tests only exist as a pull request (#85214).
I might look into this later, but won't promise anything.

It is only a poor workaround, but you can use
xinit /home/user/.vnc/xstartup -- $(realpath $(which Xvnc)) :1 PasswordFile=/home/user/.vnc/passwd

to get a vncserver running similarly as before.

@typetetris could you explain how to use that? would it be used in ExecStart for the service proposed above?

You probably could make it work.
I never bothered. I start the vncserver when I need it, from the command line. An always running vncserver makes me uncomfortable.

As a workaround, you should be able to add the xorg.xinit package to the list of packages required in PATH of the systemd service using systemd.services.<name>.path (source).
The proper fix would probably be adding xorg.xinit to the list of dependencies for tigervnc

@michaelCTS Unfortunately I'm afraid I think this will not work, as I alluded to here.
Personally, I have no use for the modern Xsession infrastructure and just use the following simple custom replacement script for booting up a VNC session:
#!/usr/bin/env bash

# prepare Xauthority file
cookie=$(mcookie)
xauth -f $HOME/.Xauthority source - <<EOF
add $HOSTNAME:1 . $cookie
add $HOSTNAME/unix:1 . $cookie
EOF

# logic lifted from sx
trap 'DISPLAY=:1 exec xterm & wait "$!"' USR1
(trap "" USR1 && exec Xvnc :1 -auth $HOME/.Xauthority -desktop $HOSTNAME:1) & pid=$!
wait "$pid"

Perhaps we should include a version of this in our package?

I just created a systemd service based on the workaround of @typetetris.
{ pkgs, ... }:
let
  home = "/home/user";
in
{
  environment.systemPackages = [pkgs.xorg.xinit];

  systemd.services.vncserver = {
    enable = true;
    environment = {
      PATH = pkgs.lib.mkForce "/run/wrappers/bin:${home}/.nix-profile/bin:/nix/profile/bin:${home}/.local/state/nix/profile/bin:/etc/profiles/per-user/user/bin:/nix/var/nix/profiles/default/bin:/run/current-system/sw/bin";
    };
    unitConfig = {
      Description = "Remote desktop service (VNC)";
      After = "syslog.target network.target";
    };

    serviceConfig = {
      Type = "simple";
      User = "user";
      WorkingDirectory = "${home}";

      ExecStartPre = "/bin/sh -c '${pkgs.tigervnc}/bin/vncserver -kill :1 > /dev/null 2>&1 || :'";
      ExecStart = "${pkgs.xorg.xinit}/bin/xinit ${home}/.vnc/xstartup -- ${pkgs.tigervnc}/bin/Xvnc :1 -interface <IP_ADDRESS> -rfbauth ${home}/.vnc/passwd";
      ExecStop = "${pkgs.tigervnc}/bin/vncserver -kill :1";

    };

    wantedBy = ["multi-user.target"];

  };
}

xstartup
#!/bin/sh

exec $(realpath $(which i3))

Just hard-coded the PATH variable to get it working, not sure if there is a better way.


Add message event listener when skipWaiting: false

Library Affected:
workbox-build
When developers use the Workbox build tools in generateSWmode, and they set skipWaiting: false, we should consider adding in some boilerplate to the generated service worker that will listen to a message event and call skipWaiting() in response to a specific command that could be sent from the client page.
This would allow developers to follow recipes like https://developers.google.com/web/tools/workbox/guides/advanced-recipes#offer_a_page_reload_for_users while still using generateSW (instead of injectManifest) mode if they prefer.
The change could be added to https://github.com/GoogleChrome/workbox/blob/b146d8d3c2db89fa51afc322049b9795894bb4f2/packages/workbox-build/src/templates/sw-template.js#L42
with an else clause that would look like:
self.addEventListener('message', (event) => {
  // What should this check for?
  if (event.data === '...') {
    self.skipWaiting();
  }
});

The main thing to decide is what the event.data check should look like. This should presumably be coordinated with the work being done on the workbox-window library by @philipwalton.

We're going to go ahead and implement this ahead of the full workbox-messages package, and just add an explicit message listener and use event.data.type === 'SKIP_WAITING' as the check. That should end up being compatible with the format we have planned for workbox-messages


Mod log matrix partially loads in multireddits

Simular to #625 , the mod log matrix doesn't fully load in multireddits like https://www.reddit.com/user/amici_ursi/m/imagesofnetwork

It actually had absolutely nothing to do with #625. :stuck_out_tongue_winking_eye:

<3 @TheEnigmaBlade

:+1:


listview example gives ImportError

The file examples/list_view.enaml contains the line:
from atom.api import Atom, Unicode, List, Bool

However, the Unicode definition has been removed from atom.api after being deprecated, so this code no longer runs.
I think it needs to be replaced with Str.
This may be a wider issue than this one file.

Yeah the whole project needs a find and replace of Unicode with Str

Done


accelerate launch uses additional VRAM?

When I start my lora finetuning script to run on a single 24GB VRAM GPU using accelerate
accelerate launch --num_processes 1 finetune.py

it uses a few GiB more VRAM than if I were to run it without accelerate launch
python finetune.py

And my process will OOM after the first step is completed. It does not OOM if I start it without accelerate launch. Before running the script, nvidia-smi reports 0 GiB VRAM usage on all GPUs.
Some other memory related configs in my script include:
    max_memory = "24GiB"
    device_map = "auto"

    model = AutoModelForCausalLM.from_pretrained(
        model_id,
        quantization_config=nf4_config,
        load_in_4bit=True,
        torch_dtype=torch.bfloat16,
        device_map=device_map,
        max_memory=max_memory,
    )
    model.gradient_checkpointing_enable()
    model.config.use_cache = False
    model.resize_token_embeddings(len(tokenizer))

Is it normal for accelerate launch to use this additional amount of VRAM? Is there any way to reduce the amount of VRAM used by accelerate?

Your model is loaded on all the processes on the CPU before being moved to each device, so yes, this is normal.

@sgugger Mind helping me understand how loading the model on all processes on the CPU can lead to an increase in VRAM usage on the GPU?
I can only understand how this will increase RAM usage by the CPU, not the VRAM usage on the GPU.

For the RAM on the GPU, DDP will use slightly more space than non-DDP as there are some buffers created on GPU 0 for the backward pass and the grad sync at the end of each training step. If your script used almost all the GPU RAM on one process, this might be why you get OOM using DDP.


Set Emitter's threads name for easier debugging

Add a ThreadFactory to the Emitter executor service to set
a custom name for threads that are created when calling execute().
Set a name for the buffer consumer thread in the BatchEmitter.
Naming these threads can be useful when investigating a thread dump, or
for monitoring purpose.

Would be great to have this feature merged in.
We just spent some time tracking down a bug in our app where repeated newing up of an Emitter was causing a lot of threads to be created.
Threads including 'snowplow' in the name would have saved a chunk of investigation time :)
(I found this PR as I was checking that an open one didn't exist already before submitting one myself)

Hey @andy-may-at
Thanks for the feedback. It's on our roadmap to spend some time on the Java tracker soonish and this will definitely be part of it. Realistically it'll probably be August before the next release happens.


[Feature Request] Recognize 509.gif on ExHentai as a error

Why/User Benefit/User Problem
Exh/Eh serves a gif acting like a normal chapter page, this should be considered a error as its not a real chapter
What/Requirements
Each download from ExHentai should stop with an error.
Other details
Debug log:
<img id="img" src="https://exhentai.org/img/509.gif"

and
1606040157153|D|||EH-NETWORK|<-- 200 OK https://exhentai.org/img/509.gif (555ms)

1606040157156|D|||EH-NETWORK|Content-Type: image/gif
1606040157157|D|||EH-NETWORK|Content-Length: 28658
1606040157158|D|||EH-NETWORK|Last-Modified: Sun, 19 Oct 2008 20:16:57 GMT

Added in https://github.com/jobobby04/TachiyomiSY/commit/f1a6218a4b21d02114177b664abe052525236124


Add useful buttons to top of panel

The panel header currently has two unused "dummy" buttons. These could be replaced with working "save comments" and "refresh comments" buttons to be less misleading and more useful.

Closed by PR #127


Shadowing a variable gives no warning

It took me a while to realise my mistake; it boiled down to this:
main :: proc() {
    x := 1;
    for i in 1..5 {
        x := x + 1; // Shadows the outer `x`
    }
    assert(x == 5);
}

P.S: Damn copy-pasta... >)

This isn't necessary a bad thing nor an error. It could be argued that you should name your variables better but that's not for me to decide.
As an end goal, I personally want little to no warnings in the compiler and just have errors.

Variable names aren't relevant - this was small reproduction of the problem to demonstrate the issue clearly and is not the verbatim code I was working on when I encountered the problem, so I'll ignore that.
In the original code, I copied the declaration of a variable to the several locations throughout its enclosing procedure, where it was to be mutated, and then forgot to change them into reassigments.

This isn't necessary a bad thing nor an error.

Care to name a few examples? :p
I'll also note that this need not be the default behaviour of the compiler; could have a switch that you can give the compiler if you want it to catch these sorts of things if you didn't want to emit even this sort of warning.
I do however, generally agree that the fewer warning a compiler issues, the better. :)

I'm curious why you need to shadow iteration variables; that's literally
the main place where I get bugs from this.
On Tue, 16 Oct 2018 at 16:24 Chris Heyes<EMAIL_ADDRESS>wrote:

I personally like variable shadowing and mistakes are quickly found.
@Tetralux https://github.com/Tetralux one example of where variable
shadowing is a good thing is using, fr example, x y z i j k as variable
names in nested scopes.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/odin-lang/Odin/issues/155#issuecomment-430303741, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABST0Bg2UlSTiWj6QJAQiA1TqxH8yp-9ks5ulghQgaJpZM4QrLAO
.

--

Dwight.

This sort of warning seems like a job for external tools (eg a linter).

Odin supports the -vet flag which does extra vetting such as variable shadowing and unused entities.

Niiice ... :smirk: send it to the vet to get it "fixed".
On a practical note. Many warnings exist because of required language facilities that might lead to bugs if used poorly.  Assuming (like shadowing) the false positive rate is reasonably low they should, IMO, be turned on by default with an in-code tag to turn off the warning for just this instance. (Sometimes called an "excuse comment").
The specific facility would be that any warning can be specifically suppressed by a tag mentioning that particular warning on the line or in the basic block of the code that causes the warning; this tells the compiler that the issue is known and that it shouldn't mention it.

Warnings usually exist because the language is either ill-defined or ambiguities are common. I am trying to make Odin not have any warnings whatsoever, only errors.
I don't see shadowing as an issue. I actually see it as a feature, because it is due to the properties of scoping/namespacing. This is the reason for -vet existing -- -vet is a linter (basic at the moment but will have a lot more features soon).
I like to think locally about problems and as a consequence, I commonly do this:
for i in ... {
    ...
    ...
    // many scopes later
    for i in ... {
    }
}

And even though this is a form of "shadowing", that is the intent.

Warnings CAN exist because of the reasons you mention. But there are other reasons, the shadowing example is because some people (especially "cheap" programmers) don't notice the overlap or forget it's there (eg: 18 months after writing it). Though in the OP's case they may be suffering from the issue that := is usually the assignment operator in ADA/Pascal derived languages so it "looks fine".
But that's not important.
The important thing is that I want to do exactly what you're doing and sometimes ignore the warning. But I still want to be able to use the warnings if I'm "cleaning up" code (read as: looking for latent bugs). The classic method is to literally put a comment at the site of the warning to say you've "double-checked" this one and it's not a problem. A external linter will often use comments in a particular format (for example shellcheck ) so it can notice this state automatically and not waste your time telling you about something you've already checked.
I've never liked the "special comment" syntax used for this much, but I don't suppose that's a bad problem, just a result of it being an after-thought. To me it feels more like a cast (an optional one like in C) where you're adding a small piece of syntax to confirm to the compiler that you mean to use a construct which is completely defined by the language but some people, some times, get wrong.
PS: "accumulator = accumulator++ + 1;" compiles in Odin. :grin:

Shadowing detection is now available with -vet


Add fossa to the github actions workflow

Previously fossa was integrated with the logging operator through a webhook, which has a few shortcomings. It's hard to find and I was unable to properly configure. Let's set up an explicit github action to perform fossa checks.

we will use snyk as part of the cncf onboarding


Setup.py Cryptography PYPI Module Does not Properly Install

Setup fails on cryptography module.  The use case, is on initial install of executing python setup.py install is an error thrown of failing to install the cryptography pypi module.  User is required to perform a pip install cryptography prior to running python setup.py install.

Fixed in PR #24 . Solution was moving cryptography to requirements.txt and adding an extra step to the install process.


Incorrect Typeform types for onSubmit

Are the the typescript types wrong here?
https://github.com/Typeform/embed/blob/e58cd98e0086bd8c2fd6c602875472b8d52fbe94/packages/embed/src/base/actionable-options.ts#L6-L12
The JSDoc states a payload with only a responseId but on the documentation site it states you will get responseId and formId - see https://www.typeform.com/developers/embed/callbacks/#on-submit
createPopup('<form-id>', {
  onSubmit: ({ formId, responseId }) => {
    console.log(`Form ${formId} submitted, response id: ${responseId}`)
  },
})

In VSCode the TypeScript intellisense overlay also suggests you will only get the responseId

Upon my testing, this is clearly not the case as I get the below from the props when the onSubmit is called
{
  response_id: 'gzpqhq1so2obvheegzpqhieczjbh82qm',
  responseId: 'gzpqhq1so2obvheegzpqhieczjbh82qm',
  formId: 'MmvHZJQV'
}

Just to note, it would be really useful to get a copy of the questions and answers that have been submitted here along with the reponseId - not only will this save me having to call off to the Response API it will allow me to take actions for the user straight away - Another issue I am sure

Hello @AaronLayton
You are right, the types are incorrect. Correct type should be:
interface Payload {
  responseId: string
  formId: string
}

The response_id is present for backward compatibility, has the same value as responseId. I am not sure if we can break the backward compatibility but I will look into it, I agree it is a bit confusing.
Unfortunately we are unable to pass the response to onSubmit callback because submissions are processed asynchronously and might not be saved at the time the form is submitted.

:tada: This issue has been resolved in version @typeform/embed-v2.13.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Javascript APi on Tabris.js

Hello i have a question
Can i use
Web Workers
Service Workers
Server Sent Event
IndexedDb
with Tabris.js?

Supported browser-inspired API documentaion is here - Persistent Storage one of them
Since stable version 1.10 Tabris.js supports WebSocket, so it's up to you which 3rd party plugin to use or you can recieve push notifications with plugin or even use FireBase plugin
Eventually, you can use any cordova plugins with some notes
Also search for issues labeled with cordova compatibility to find info about cordova plugins that work with Tabris.js

@sand123 is absolutltly correct in his answer.
One more comment on Service Workers. At the moment they are not supported. If you need to do asynch/background work you should rely on a cordova plugin for that.
IndexDB is not supported but both iOS and Android support SQLite for which multiple cordova plugins exist.

thank you very much


Ability to disable side panel button

I don't use it at all. So its just cluttering up my side panel for no reason. Thanks.

Plugin has been moved to https://github.com/wise-old-man/wiseoldman-runelite-plugin


Hello in the middle of a dialogue doesn't work

Fails with "Sorry, I had an error processing your command: expected empty history for greet."

Fixed by #465


[Feature Request] dlopen integration

Hi! I noticed this project has been going well underway, however there's one thing I'm wondering about, and that's dlopen.
I'm not an expert on how you envision RVM working, but the ability to load and call external libraries would open the entire project up to near limitless possibilities.
I have a simple idea for how this could be done(written in some pseudo-assembler thing):
.CODE ; This is just me coming from ca65 assembler

push libc_name ; We push the external binary name

; ldexl pops a location from stack, reads as string, loads the library and stores
; the library handle in the location specified via argument 1
ldexl libc_handle

; We push the libc library handle
push libc_handle
push libc_malloc_name
; ldexf is like ldexl but it loads a function from the library.
; Top of the stack is the function name string pointer, 2nd in stack is
; the library which we're loading from.
ldexf libc_malloc_handle

; We push argument #1 to malloc
push 16
; We call malloc via ldexc, which is like call, but for external methods.
ldexc libc_malloc_handle
; Then we get our pointer as a return value on the stack or smth
pop ; I guess we need an argument or smth?

.RODATA ; Read-only data or smth idk

; libc_name would just be a label with the location of the string "libc.so"
libc_name: .str "libc.so"
; This is just 4 bytes for storing a handle(could just be a pointer value from C code)
libc_handle: .bytes 4
; Just like above but for the malloc function
libc_malloc_name: .str "malloc"
libc_malloc_handle: .bytes 4

It'd be phenomenal if ldex* handles rvm libraries too(if possible).
I don't know your plans, but y'know...


Drop of 2.7 in symfony.com/versions.json after 2.8 release

I dont which project is responsible for this file. so a try ;)
installable of http://symfony.com/versions.json is used by PhpStorm Plugin for building a list of installable symfony-installer projects. Since 2.8 release 2.7 is missing in json.
issue:
https://github.com/Haehnchen/idea-php-symfony2-plugin/issues/643

Yep this is strange... ping @lyrixx or @javiereguiluz maybe?

@Haehnchen thanks for reporting this issue. Originally we used this versions.json to check if a Symfony version was able to be installed via the Installer. Now that all newer versions are installable, we lost interest in installable option (only non_installable option is useful for the installer).
In any case, your message has made me realize about other use cases. So this error is now fixed and it will be available after the next server deploy. Thanks!

:thumbsup:

@javiereguiluz Do you know how often there are deploys?

This issue should be fixed by now. http://symfony.com/versions.json now displays all the installable and non-installable versions.

@javiereguiluz I'm surprised to see no reference about the 2.5 branche in either installable and non_installable... Is 2.5 an installable version or not?

@Pierstoval Looks like installable does not list unmaintained branches.
In any case, there is strictly no reason to create a new project based on 2.5.

@Pierstoval nice catch! This is indeed a bug. the installable option should display all the Symfony versions which are installable by the Symfony Installer, no matter if they are maintained or not.
This issue has been fixed and it will be available soon.

@javiereguiluz would it make sense to expose the list of maintained versions in versions.json too ? IDE integrations should only allow creating new projects based on maintained versions for instance IMO.

My question is: maintained versions are only the most recent patch version of the maintained branches? E.g. 2.3.35 is maintained but 2.3.34 is not?  This may be confusing because strictly speaking 2.3.35 is not maintained. If we find and error, it will be fixed in the (non-existent) future 2.3.36 version.

@javiereguiluz I would not give release versions, but branches (e.g. 2.3, 2.7). The installer already allows specifying a branch rather than an exact release, and the versions endpoint allows IDEs to do the same if they bypass the installer (as they give the latest release for each branch).
Users should only specify a minor version all the time IMO. It does not make sense to ask them to choose which patch release they want to use for their new project (they should always use the latest one)


Users who are retaking their third year are automatically set to first grade

What kind of an issue is this?

Bug report
Feature request

What is the expected behaviour?
Users who are retaking their third year and apply for an extended membership should be put in the third grade. This should happen when using the dataporten application.
What is the current behaviour?
Users who are retaking their third year are automatically set to first grade when using the automatic application system.

How do you reproduce this problem?

Be doing extra year of informatikk after third year.
Use automatic membership application to extend your membership.
Cry.

Other information

When this was implemented it was intentionally left out to require manual intervention for people who are on their "3+" year(s). If this is not the desired behavior, however, feel free to change it.

As long as the students are still students at BIT they should automatically be approved.


Fix typos and error in temperature distribution graph.

Fixes issue https://github.com/poliastro/poliastro/issues/1406.


Handle inotify isdir flag

This PR adds a field toFileEvent which holds the value of the inotify IN_ISDIR flag.
This fixes errors when working with directories like
Error: invalid eventStr: <isdir>, </path/to/,"CREATE,ISDIR",dir>

https://github.com/pablodz/inotifywaitgo/releases/tag/v0.0.7

Thanks for the PR


Create integration test based on block-on-spring example app

As described in #35, we are going to be using simple turboPy apps as integration tests.
The block-on-spring example app would be a nice one to use for an integration test.
ToDo:

[ ] Use "block_on_spring" as the fixture "long_name" and "bos" as the "short_name"
[ ] Save 'good' outputs in tests/fixtures in a sub-folder using the "block_on_spring" name
[ ] At a minimum, create at least one fixture (bos_run) to run the app and generate output for comparison to 'good' output

Would it be alright if I changed the ForwardEuler to BlockFowardEuler and ParticleForwardEuler to fix the registry issue?

Do you mean that you get an error trying to register "ForwardEuler" as a compute tool? If so, then yes, it makes sense to call it something like "BlockForwardEuler" instead. I don't think there's any need to change the name of the other compute tool.

Closed with PR #88
Thanks @gracetangg 🎉


Logpoints to show which line they came from

When using the logpoints feature it is unclear where they came from and there is no way to search which line caused it to happen. It would be nice to see which line they came from as a clickable link in the terminal. Or at least a list of logpoints that can be toggled without having to go to every file and search for them

This works for me perfectly fine for Node debugging.
I suspect that you are not debugging Node but using another debug extension. If that is the case please file this issue against that extension and tell them that for LogPoints they need to send source objects and that VSCode will render the link as clickable (just like it works for node in my picture).
If you are debugging node let me know and provide exact repro steps and I can reopen this. Thanks


Clarify inclusion criteria

It would be nice to more explicitly clarify the inclusion criteria for programming languages.
Specifically, I had the following questions:

What is the policy on languages where development has stopped? Should they be submitted for inclusion? Should already listed languages be removed if develpment has stopped?
What is considered a 'programming language'? I notice that Typst, Melody and MarkovJunior, which are fairly specialized languages, are included, so I assume the definition is quite broad.

Thanks for your questions. Good points, but I don't sure I have answers to them.

What is the policy on languages where development has stopped? Should they be submitted for inclusion?

I think it should depend on language itself. Is there a value in adding this language to the list? If the answer it yes, then you are welcome to submit it.

Should already listed languages be removed if develpment has stopped?

The answer is partially the same as in the previous question. Also, I think to add some kind of tag, so it would be possible to mark the language without explicitly removing it.

What is considered a 'programming language'?

It's also difficult to answer to this question. It seems that languages like Typst, Melody and MarkovJunior should be marked with DSL tag? Or something. So you will be able to filter out languages like these if you are not interested in them.
If you have any suggestions, I'm all ears. Thanks in advance.


import "phonenumbers" could not be resolved Pylance

how do I fix this?

What python version are you using ?

3.10.11


Visual studio fails to format with error InvalidUtf8

On windows when trying to format a file I get the following log
[Info  - 1:01:28 AM] [info-main] zls initialized
[Info  - 1:01:28 AM] [info-main] ClientCapabilities{ .supports_snippets = true, .supports_semantic_tokens = true, .hover_supports_md = true, .completion_doc_supports_md = true, .label_details_support = true, .supports_configuration = true }
[Info  - 1:01:28 AM] [info-main] Using offset encoding: utf16
[Info  - 1:01:28 AM] [info-main] Requesting configuration!
[Info  - 1:01:28 AM] [info-doc_store] builtin config not found, falling back to default: <file>
[Info  - 1:01:34 AM] [info-doc_store] builtin config not found, falling back to default: <file>
[Warn  - 1:01:34 AM] [warn-doc_store] Failed to load packages of build file <file>
[Info  - 1:01:34 AM] [info-main] Setting configuration...
[Warn  - 1:01:52 AM] [warn-main] Failed to spawn zig fmt process, error: error.InvalidUtf8

It seems like it is using utf16 for some reason, but i dont see a config related to this

Found the problem; zls config options weren't properly being duped.


make binder directory visible

use 'binder' instead of hidden '.binder'
cf https://github.com/jupyterhub/binderhub/issues/157

woohooo (shall merge once CI passes)


Many relics - GK's big list of text improvements (big thanks to Discord's gkjzhgffjh#4772 for all this!)

So, I asked GK, the patron of Simplicity and Less Text, to test this mod and he went to read all relics. These are the things he found that need improvement that I agreed need changes:
qcfpunch:Black_Training_Shirt - OK
at combat start -> At the start of combat
Once per combat -> The first time each combat
qcfpunch:Broken_Tusk - OK
hit for your -> hit to your?
qcfpunch:Cattail - OK
gain -> obtain
Cattail will vanish after giving the second Smoke Bomb.
qcfpunch:Combat_Fatigues - OK
Pumps you??? change to a more clear word.
qcfpunch:Fighting_Gloves - OK
#yUpgrade #b1 chosen deck's card per charge -> Upgrade 1/a card
qcfpunch:Green_Leotard - OK
to move around -> for moving around
qcfpunch:Red_Headband - OK
then randomly draw one card that is in the draw pile. Are you kidding me? Make this just draw 1 card, please.
qcfpunch:Red_Gi - OK
prefix Attack with #y and numbers with #b
qcfpunch:Special_Ops_Insignia - OK
#ycards by effects in a turn, add both #bSetup and #bForethought to your hand, with #yEthereal and #yExhaust. draw after the start of your turn, ... X and y with exhaust and ethereal to your hand
qcfpunch:Spiky_Bracers - OK
less at that combat. -> less.
gramatically correct would be during instead of at but you don't need to specify
qcfpunch:Unceasing_Flame - Not needed.
Attack's single target -> single target attack's target
qcfpunch:White_Boots
I won't even try to comprehend this (this one will be reworked and simplified. Maybe just do a set amount of damage after X attack cards.
qcfpunch:Wild_Herbs_Ointment
Seems overcomplicated (like many of your relics), maybe make it simpler, similar to meat on the bone? <- Rework relic.
qcfpunch:Wrestler's_Cloak
presentation in flavor text is the wrong word
At Elite/Boss rooms, gain -> At the start of Elite and Boss fights, gain

Ok, and now, time to do the relic code changes, which will need their own issues.


Amending documentation link

Updating documentation with the current access_control.py link.

Codecov Report

Merging #5491 (52936a9) into master (72db853) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5491      +/-   ##
==========================================
+ Coverage   96.10%   96.12%   +0.01%
==========================================
  Files         726      723       -3
  Lines       72197    71992     -205
==========================================
- Hits        69388    69201     -187
+ Misses       2809     2791      -18

Flag
Coverage Δ

servertests
36.95% <ø> (-0.15%)
:arrow_down:

unittests
96.06% <ø> (+0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

moto/settings.py

moto/ec2/__init__.py

moto/__init__.py

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Chrome sometimes opens the file

Great small script for creating a dropzone.  Thank you.
I have an intermittent problem.
When I drag a file from my desktop, Chrome sometimes opens the file instead of dropping it in the zone (file input).
Any ideas?

Hello and thanks,
No. I don't have this problem on Chrome.
So no idea.

I have the same problem, but the thing is that just my client have the problem. On all my computers works fine, so i have no idea what to do.
He has W7 and Chrome, I´m using W8.1 but Chrome too.
Thanks anyway, good job!


selected attribute is not updated properly

The repo where this bug happens is https://github.com/cideM/tinyfinancial on the details branch (https://github.com/cideM/tinyfinancial/blob/details/src/client/views/Details/index.js). But it requires MongoDB and one would have to remove the facebook authentication. But maybe I'll be able to explain my issue through code examples as well.
I have a controlled <select> and onchange a choo state variable is updated, the view function is rerendered and the newly selected <option> should now be selected. The actual behavior is very confusing though:
When the function renders the first time the DOM looks like this
<select value="2017">
   <option value="2017" selected="selected">2017</option>
   <option value="2016">2016</option>
</select>

If the user select 2016, the DOM looks like this
<select value="2016">
  <option value="2017" selected="">2017</option>
  <option value="2016" selected="selected">2016</option>
</select>

Note the leftover selected="".
Now here are a few console.log statements that I put in updateAttribute of morphdom
function updateAttribute (newNode, oldNode, name) {
  console.log(newNode)
  console.log(newNode.selected)
  console.log(oldNode)
  console.log(oldNode.selected)

When the user chooses 2016, the log statements evaluate to this:
<option value="2017">2017</option>
true why? :[
<option value="2017" selected="">2017</option>
false Seems okay I guess
and
<option value="2016" selected="selected">2016</option>
false O_o
<option value="2016" selected="selected">2016</option>
false Ó_ò
It's late and it's been confusing, so maybe this is totally expected, but I don't it. The booleans seem off though. My intuition says something is mutating the nodes in between other actions but that doesn't sound right. And that getAttribute and properties are not always the same is known but that it would cause such a bug also sounds odd. Lastly, maybe I am just making a grave mistake here somewhere?
I was actually able to fix this by changing updateAttributes to
function updateAttribute (newNode, oldNode, name) {
  if (newNode.getAttribute(name) !== oldNode.getAttribute(name)) {
    oldNode.setAttribute(name, newNode.getAttribute(name))
    if (newNode.getAttribute(name)) {
      oldNode.setAttribute(name, '')
    } else {
      oldNode.removeAttribute(name, '')
    }
  }
}

Note that I replaced the calls to node.selected with node.getAttribute('selected'). I didn't fork and run tests and I didn't manually check anything else because I really need to sleep now. But please let me know
a) if my bug is known and there's a workaround I couldn't find
b) my "discoveries" are expected behavior and I just don't it

Should have been fixed by #60

Memo to myself: check pull requests not just issues. Sorry for the redundant post! It did indeed fix my problem.


networking: Add flags to specify net config and net plugin binary dirs.

Add --net-config for net config dir.
Add --net-plugin for net plugin binary dir.
Also did minor refactoring that groups networking related flags together.
cc @iaguis @alban @jonboulle

So for the tests, I am trying to copy some plugin binary to a random directory, change its name, and use --net-plugin to point to that directory, to see if rkt can find the binary as expected.
So where should I copy the plugin binary from?  ctx.rktBin()/../tools/macvlan ?

@yifan-gu: My idea was to split stage0 and stage1 config as per #2013. So, stage1 config could allow user to specify net plugins paths and CNI config (in a bit different, but consistent format). This, together with passing user config to stage1 should fix your issue too.
I'm not fond of the --net-config flag - my aim was to actually have net plugins config to be in the same format as other config we have (with rktKind and rktVersion fields). I was working on this several weeks ago, but it started to burn me out, so I switched to something else. Of course, this might not be enough for you, if you wanted to have this quickly.

For the record - my work is here - https://github.com/kinvolk/rkt/tree/krnowak/config-split-backward-compatible

For the record - my work is here - https://github.com/kinvolk/rkt/tree/krnowak/config-split-backward-compatible

So are we going to get that in for 1.2 or next release?

@yifan-gu: For the next one.

Here is the preliminary PR that implements the feature - https://github.com/coreos/rkt/pull/2312

Should this be closed in favour of #2312?

Yes.


Bug: $value is always null when validating single values with validation shortcut

Description
I am facing some issues when it comes to validating single values and I couldn't
tell where to place this, whether if it's under bug or support. Looking at the
documentation, to use the validation library, we need to load it as a service:
$validation = \Config\Services::validation();

We can then validate  a single value against a set of rules(not sure about this) or a rule:
$validation->check($value, 'required|number');

This seems to work fine and is expected to return true or false. Now, there is a shortcut
just in case you don't want to load the Validation service and want to quickly validate
something(within a controller):
$this->validator->check($value, 'required|number');

I am assuming that they should work the same way and provide the same results
but I keep getting the error:
Call to a member function check() on null

even after providing a value and confirming that the value is actually there with
dd($value).
CodeIgniter 4 version
CodeIgniter v4.1.3
Affected module(s)
Validation
Expected behavior, and steps to reproduce if appropriate
Inside a controller:
/**
* Actual Behavior
*/
$value = 3;
$this->validator->check($value, 'required|is_natural_no_zero');
// Error: Call to a member function check() on null

$value = '';
$this->validator->check($value, 'required|is_natural_no_zero');
// Error: Call to a member function check() on null

$value = 'abc';
$this->validator->check($value, 'required|is_natural_no_zero');
// Error: Call to a member function check() on null

/**
* Expected Behavior
*/
$value = 3;
$this->validator->check($value, 'required|is_natural_no_zero'); // returns TRUE

$value = '';
$this->validator->check($value, 'required|is_natural_no_zero'); // returns FALSE

$value = 'abc';
$this->validator->check($value, 'required|is_natural_no_zero'); // returns FALSE

Context

OS: Ubuntu 18.04.5
Web server: Apache 2.4.43]
PHP version: 7.4.8

Call to a member function check() on null
this means that the $this->validation property is undefined.
By default, the property is determined when the $this->validate() method is called in the controller.

@iRedds is correct.
The property is filled with the validation object when you used the $this->validate() method of the controller. https://github.com/codeigniter4/CodeIgniter4/blob/4ab9d66b530ec798f2b06a551a2cab8797161f5d/system/Controller.php#L139
In your case, you are accessing $this->validator outside the scope of the method so the property is not initialized with the needed validation service. Since you are doing validations, I suggest to use the $this->validate() method instead as it does the same thing as what you want to achieve.
If you, however, would still want to access $this->validator in other methods of the controller (or in your controller perhaps), you can send a PR moving the instantiation to the constructor instead. Thanks.

Thank you! I think I get the picture now. I should have researched more on this.


Direct Line Web chat doesn´t render cards controls.

I was trying to use the Direct Line as an embedded web chat as the follow, https://directline.botframework.com/embed/BOTNAME?s=KEYAPP_FORDIRECTLINE, and it works but when the bot reply options into buttons control it only returns a choose list (Strings), There is any option that I have to enable to render this controls?.
Thanks you in advance.

@jrom20 have you configured your bot to use the new Webchat preview?  If when you edit your bot's "Webchat" control you choose "enable preview" you should see the new features, including card support.

@jameslew Thank you for reply.
Yes, I have configured the 3.0 Preview, and still I'm getting the options as bullet points,
using https://directline.botframework.com/embed/.......

if I use https://webchat.botframework.com/embed/.....
I get the nice card render

Any other idea to solve this.

Hi @jrom20, the URL you are using is not supported. I'm surprised it works.
The correct URL would look like this: https://webchat.botframework.com/embed/BOTNAME?s=KEYAPP_FORWEBCHAT
You can get keys from the Web Chat configuration page within the Bot Framework dev portal.

The correct fix for this issue is to update your endpoint. Closing this issue. Please at-mention or open a new issue if you'd like to discuss further.


Override format used for X axis labels on navigator

By default 12 hour format seems to be used for the hours on both the X axis of the chart and navigator.
I'd like to use 24 hour format to match how I have configured the register first time format.
Perhaps this is already available but I can't see anything obvious in the docs or code.

Hello,
you can use the "tickFormat" property on "xAxisConfig". This property uses the d3 time format or d3 format and is very flexible.

To follow up, unfortunately, the navigator is not currently configurable. Another pending change for v1.x

I notice that when the default tick format is used for the x axis as you zoom in the tick labels change as appropriate to the zoom level.
However, when I set the format myself that format is used no matter the zoom level.
Is it possible to set your own format but also maintain the behaviour of changing the labels as you zoom?

Unfortunately, not that I know of; that is native d3 functionality and I do not know of an easy way to do this. You can try searching on d3 forums and let me know if you do find a way.
The hard way is you would have to do it manually, passing in different formats at different zoom levels.

Using the example for a multi-scale time format here I was able to configure the x axis formatting and maintain the behaviour on zoom.
 var formatMillisecond = Px.d3.timeFormat(".%L"),
    formatSecond = Px.d3.timeFormat(":%S"),
    formatMinute = Px.d3.timeFormat("%H:%M"),
    formatHour = Px.d3.timeFormat("%H"),
    formatDay = Px.d3.timeFormat("%a %d"),
    formatWeek = Px.d3.timeFormat("%b %d"),
    formatMonth = Px.d3.timeFormat("%B"),
    formatYear = Px.d3.timeFormat("%Y");

 function multiFormat(date) {
     return (Px.d3.timeSecond(date) < date ? formatMillisecond
          : Px.d3.timeMinute(date) < date ? formatSecond
          : Px.d3.timeHour(date) < date ? formatMinute
          : Px.d3.timeDay(date) < date ? formatHour
          : Px.d3.timeMonth(date) < date ? (Px.d3.timeWeek(date) < date ? formatDay : formatWeek)
          : Px.d3.timeYear(date) < date ? formatMonth
          : formatYear)(date);
  }
  var config = {};
  config.tickFormat = multiFormat;
  return config;`

I'll update the issue description to reference overriding the x axis configuration for the navigator.

the navigator x axis config can now be changed in navigatorConfig in 1.0.0


install on archlinux

how I can install unetlab on archlinux or from source code?
I didn't found it in yaourt.

this is not forum/support


[Beta] "Ctrl + Enter" hotkey not working for Projects

Issue Description
The Project sections mentioned below run tests/submit on pressing enter not on ctrl + enter:

[ ] Front End Libraries Projects
[ ] Data Visualization Projects
[ ] Information Security and Quality Assurance Projects
[ ] Coding Interview Take-home Projects

Browser Information

Browser Name, Version: Chrome(64.0.3282.186)
Operating System: Windows 10 Pro 32 Bit.
Mobile, Desktop, or Tablet: Desktop.

I'd like to take a crack at this when it's ready!

Thanks for reporting this @vkWeb. This may be related to #16773 /cc @Bouncey

@vkWeb the project challenge is a form, pressing enter on a form generally submits the form. The issue that's Timo referenced is that the project challenges do not display a completion modal once the challenge has been submitted.
Is it that Ctrl + Enter does not submit the challenge, but that was the expectation?

@Bouncey Yes, that was the expectation as its written on the button.

Can't reproduce.
Browser: Vivaldi | 1.14.1077.55 (Stable channel) (64-bit) (Chrome/64.0.3282.189)
OS: Windows 10 Pro 64-bit

@vkWeb, I don't think there is an easy fix for stopping the form from submitting on pressing enter, It would require us to modify the redux-form package.
I cannot reproduce the not submitting on crtl + enter issue you mention.

@Bouncey I think you're using Firefox? This isn't reproducible in Firefox.

@Bouncey Also, entering https://example.com passes the test. Is this behaviour expected?

We have no test suite for projects, so yes. This is the same as the current production site also.

@Bouncey Okay.

I'm closing this issue as stale since it hasn't been active lately. If you think this is still relevant to the newly updated platform, please explain why, then reopen it.


R.__ missing

Hey,
The definition for R.__ (http://ramdajs.com/docs/#__) is missing, is this intentional?
I've tried merging the Static interface with a local definition but it doesn't want to play nice :(
declare namespace R {
    interface Static {
        __(): any;
    }
}

Update 1
After some more adventures I'm not sure what the type should be either. I modified the index.d.ts in my node_modules/@types/ramda to include __ like the following:
interface Static {
        __(): any;
        ...

But I then couldn't do R.gt(R.__, 0) as R.gt is (a: number, b:number) => boolean.
This lead to me just defining R.__ as just any (not a function at all) in the interface.
Update 2
const R__ = (R as any).__ works.

I can take a PR for that. We hadn't managed to get it to play nice for type inference either though. For arity-2 functions, hopefully R.flip would work better...

Sorry, checked into this again but I realize why donnut had taken this out. Even if you put in any, it'll screw up the rest of the typings as it won't understand what happened. With that, the placeholder is essentially pretty harmful to use with typescript-ramda, hence the README note recommending R.flip instead when possible (binary functions).
I can foresee a 'proper' solution -- handling every possible combination on the level of the CurriedFunction interfaces, which would prevent having to do this for every single function (as if just the currying wasn't bad enough). However, that kind of requires being able to have all functions go through that interface in the first place, which is something I tried to do (added commented versions) but hadn't quite managed to make work yet, see #122. So I fear at the moment I'm not able to fix this yet.


adding Ain Shams University in Egypt

@sohah I am sorry, the domain cis.asu.edu.eg is removed from our trusted domains list because it was abused in the past. If you are the student of this school, please enroll to GitHub Student Developer Program. Then apply for JetBrains educational subscription with your GitHub account (GitHub tab at https://www.jetbrains.com/shop/eform/students).

Thanks @philipto , for your reply. I am actually an Assitant Professor there. How do you propose I'd apply for the educational subscription, given that I am not a student?


Migrated prevent full disk in PostgreSQL

What changed, and why it matters
Migrated https://help.aiven.io/en/articles/2990664-preventing-postgresql-full-disk-issues
Fix #293

Apart from the two comments above, this reads well and I think is good.


0.20 Release notes

We need to update the 0.20 release notes.

@slinkydeveloper can you please run the release notes workflow?

@slinkydeveloper can you please run the release notes workflow?

Done!
/close

Done!
/close


Adafruit Crikit Hardware and makecode.adafruit.org  version 1.1.21

Greetings;
I am a newbie. Is this the location to post the following statement,
I have a Adafruit Circuit playground Express and Adafruit Crickit hardware. When I go to makecode.adafruit.org using Google Chromium on a Raspberry Pi , I receive this error.  "Cnnot load package: Package Crickit requires target version 1.1.21 (you are running 1.1.9).
When I go to makecode.adafruit.org using Google Chrome on a Windows 7 i7 Dell computer, I receive this error.  "Cnnot load package: Package Crickit requires target version 1.1.21 (you are running 1.1.9).
Do I use Microsoft Edge or IE? Or how can I update makecode.adafruit.org  from 1.1.9 to 1.1.21 ?

Use https://MakeCode.adafruit.com/beta for now...

From: victorgithubvv<EMAIL_ADDRESS>Sent: Saturday, June 2, 2018 4:11 PM
Subject: [Microsoft/pxt] Adafruit Crikit Hardware and makecode.adafruit.org version 1.1.21 (#4407)
To: Microsoft/pxt<EMAIL_ADDRESS>Cc: Subscribed<EMAIL_ADDRESS>Greetings;
I am a newbie. Is this the location to post the following statement,
I have a Adafruit Circuit playground Express and Adafruit Crickit hardware. When I go to makecode.adafruit.org using Google Chromium on a Raspberry Pi , I receive this error. "Cnnot load package: Package Crickit requires target version 1.1.21 (you are running 1.1.9).
When I go to makecode.adafruit.org using Google Chrome on a Windows 7 i7 Dell computer, I receive this error. "Cnnot load package: Package Crickit requires target version 1.1.21 (you are running 1.1.9).
Do I use Microsoft Edge or IE? Or how can I update makecode.adafruit.org from 1.1.9 to 1.1.21 ?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2Fpxt%2Fissues%2F4407&data=02|01|jhalleux%40microsoft.com|c2da4ece92f64be39a6c08d5c8de3a28|72f988bf86f141af91ab2d7cd011db47|1|0|636635779144762013&sdata=1hSbinotswPRvxkEhYz2t%2FL4tf6yg9CM7WegRZd3Olg%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAD-4KeXytvG2mDj77IqgUflBqOod0YF0ks5t4xu4gaJpZM4UX4HM&data=02|01|jhalleux%40microsoft.com|c2da4ece92f64be39a6c08d5c8de3a28|72f988bf86f141af91ab2d7cd011db47|1|0|636635779144762013&sdata=373tUb0gpvftL%2BH32WRzyq6IUSpln9NMUso%2FCIAWt0M%3D&reserved=0.

Beta will be released to live soon


Error drawing muscle paths with Arm26 model

Steps to reproduce

load arm26.osim
set shoulder elevation to 170degs
set final time on running dude to 1.0
simulate

Expected result

model simulates and muscle paths are drawn correctly

Actual result

TRILong muscle has mysterious muscle path point on/near ground

Environment and GUI version
Windows OpenSim e07981e0-2018-05-15

Debug build runs only to 0.674, muscle is intact. Message in messages window:
ForwardTool::run() caught exception
SimTK Exception thrown at MassProperties.h:525:
Error detected by Simbody method Inertia::Inertia(SymMat33): Inertia matrix contains a NaN.
(Required condition '!isNaN()' was not met.)
The check is enabled only in Debug mode. In release mode it continues quietly causing senseless results downstream.

@aseth1 How do you want to handle this (exception thrown that stops integration is fired by Simbody in Debug mode only)

Visualization is a downstream effect of senseless simulation that continued incorrectly. I don't think there's a visualization issue to address here.

@aseth1 Will report the callstack throwing exception in release (with debug info) then will investigate GUI workflow to reproduce. Either mishandling of exceptions or differences in simbody headers.

@aymanhab there is still a GUI issue. Even in the case that values are NaN, the muscle should not draw. It should not default to some location in ground.
This issues is related to #221 and core #2141. While agree that the API should not produce NaNs and whatever Tool should terminate immediately, there is no way to guarantee that NaNs won't be generated due to unexpected parameter values and the GUI must handle NaNs appropriately by not drawing the geometry of the related transform.

Even in the case that values are NaN, the muscle should not draw. It should not default to some location in ground.

I agree: it's a case of treating NaN as a number. The behavior could potentially be very confusing if the muscle path happens to be close to wherever the NaN gets drawn.

I verified that same simulation behavior occurs in 3.3. That is to say 3.3 also simulates for the complete 1.0s, but upon replay it only plays for states with numeric values. Loading that model and states file in 4.0 also only played the motion for numeric values.

The error in drawing the path only occurs in the model where I set the default shoulder angle to 170degs. That is the only difference between the two models below. Both are given the same states file and synced. I can play the model individually and get the same behavior (so it rules out syncing).

I also use the scripting shell to check that the models compute the same TRILong muscle length at the state where the drawing error occurs. I can only conclude then, that this is purely visualization related.

Further confirming that this is unrelated to forward simulation and the API, is that you can just load the model with the default value set to 170degs and set the shoulder coordinate anywhere between 83 and 131 degs after loading the model and get the TRILong-P2 to draw incorrectly. Again verified that the pathpoint location both in the humerus and in ground are correct.

Wild! I had to try that myself.

opened arm26.osim in text editor
changed default_value of "r_shoulder_elev" Coordinate (L311) to 2.967 (approx. 170°) -> arm26-newDefault.osim.txt
opened model (OpenSim-cedd8d22-2018-05-31-win64.exe)
in Coordinates panel, changed "r_shoulder_elev" to 83

This was caused by wrapping returning 1 point which was treated as error condition in the past. Made more lenient now.

This was caused by wrapping returning 1 point which was treated as error condition in the past. Made more lenient now.

Wrapping should not return 1 point unless it is perfectly tangent to the wrap object.  If it was treated as an error condition in the past, how does making it more lenient supposed to fix this problem?

Confirmed on Windows OpenSim_cea85df3-2018-07-18 that setting the default value to 170degs and reposing to 83degs does not have the above issue.
However, the original issue (following the steps at the top of this issue) and simulating does cause similar problems in drawing muscles at 0.760s at which time the states become NaN:

You can see that the states have no values beyond 0.760 but the muscle paths are still attempting to be drawn. In this case the distal (undefined) points are being set to (0,0,0) in ground which is incorrect behavior.

@aseth1 thanks for checking. The key question is how to stop the simulation when the state contains NaNs.  The only mechanism the GUI knows to stop accumulating data and using NaNs is an Exception being thrown. This happens in debug mode by Simbody and not in release for efficiency purposes. Does the state have a way to quick check if it contains NaNs?

how to stop the simulation when the state contains NaNs

Not sure the simulation should stop if NaNs are encountered. Is there a way to prevent the visualizer from changing NaNs to zeros? A user could potentially load results from the API or an old version of OpenSim, so it seems like there needs to be a strategy for handling NaNs in the visualizer regardless.

There is an inconsistency here as well. The bones correctly do not display because the transforms are NaN. The fact that muscle paths still attempt to draw is a bug. In 3.3 the arm (downstream of NaN coordinates) disappears, which I believe is the correct behavior.


Transform.rotate rendering issue when angle is -pi

Steps to reproduce
It seems that as of 3.24, the Transform.rotate widget has some sort of rounding problem when using a negative pi value.
See the code sample below for an example.
I have also provided a workaround that basically just cuts off the decimal places before the problem occurs.
Expected results
180° rotated arrow
Actual results
Misplaced and non-rotated arrow
Code sample
Code sample
import 'dart:math' as math;

import 'package:flutter/material.dart';

class DirectionArrow extends StatelessWidget {
  final int direction;
  final Color arrowColor;
  final double size;
  final bool invert;

  const DirectionArrow({
    super.key,
    required this.direction,
    required this.size,
    required this.arrowColor,
    this.invert = true,
  });

  @override
  Widget build(BuildContext context) {
    final arrowAngle = (direction - (invert ? 180 : 0)) * math.pi / 180;
    return Transform.rotate(
      angle: arrowAngle,
      child: Icon(
        Icons.navigation,
        size: size,
        color: arrowColor,
      ),
    );
  }
}

Workaround
import 'dart:math' as math;

import 'package:flutter/material.dart';

class DirectionArrow extends StatelessWidget {
  final int direction;
  final Color arrowColor;
  final double size;
  final bool invert;

  const DirectionArrow({
    super.key,
    required this.direction,
    required this.size,
    required this.arrowColor,
    this.invert = true,
  });

  double _normalizeAngle(double angle) {
    var normalizedAngle = angle;

    const boundary = 3.1415926; // seems to be a rounding issue

    if (angle > boundary) {
      normalizedAngle = boundary;
    } else if (angle < -boundary) {
      normalizedAngle = -boundary;
    }

    return normalizedAngle;
  }

  @override
  Widget build(BuildContext context) {
    final rawAngle = (direction - (invert ? 180 : 0)) * math.pi / 180;

    final arrowAngle = _normalizeAngle(rawAngle);

    return Transform.rotate(
      angle: arrowAngle,
      child: Icon(
        Icons.navigation,
        size: size,
        color: arrowColor,
      ),
    );
  }
}

Screenshots or Video

Screenshots / Video demonstration
Before workaround:

With workaround:

Flutter Doctor output
Doctor output
[✓] Flutter (Channel stable, 3.24.0, on macOS 14.5 23F79 darwin-arm64, locale en-DE)
[✓] Android toolchain - develop for Android devices (Android SDK version 35.0.0)
[✓] Xcode - develop for iOS and macOS (Xcode 15.4)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2024.1)
[✓] VS Code (version 1.92.1)
[✓] Connected device (5 available)
[✓] Network resources

• No issues found!

Hi @flocbit
I checked this on Android and iOS and saw different results as below. It behaves correctly on Android and issue appears on iOS only.

iOS
Android

If I disable Impeller on iOS, it will output same to Android (correctly). I think this is similar to https://github.com/flutter/flutter/issues/153078 and https://github.com/flutter/flutter/issues/153036.
Closing this as a duplicate of https://github.com/flutter/flutter/issues/153036. Please follow that issue for updates. Thanks!


spark timestamp issue  help!!!

For hudi timestamp type, if bulksert is used for initialization and upsert is used for stream processing, this field will become 1970-01-19 09:54:26.763497 during query. As long as there is an update operation, this field in that file will become 1970-01-19 09:54:26.763497, files that have not been updated will not be affected; use bulksert stream processing during initialization, and the problem will not occur.
This field is correct after initialization, but after stream processing it becomes 1970-01-19 09:54:26.763497
Spark scala used for initialization, spark structed streaming used for stream processing
spark, hive, parquet types and values are below
parquet: int64<PHONE_NUMBER>497
spark:  timestamp 1970-01-19 09:54:26.763497
hive:  bigint<PHONE_NUMBER>497
Environment Description

Hudi version :0.11.1

Spark version :spark3.0.2`

@leoyy0316 can you provide script and config for reproducing?

set spark.sql.legacy.parquet.datetimeRebaseModeInRead=LEGACY and  set spark.sql.legacy.parquet.datetimeRebaseModeInWrite=LEGACY may help u


Add HashMap.adjustWithKey.

This function is present in the container's Map interface, this brings more
consistency to the HashMap interface so that it can more easily be used as a
drop in replacement for Data.Map if desired.
This partially addresses https://github.com/tibbe/unordered-containers/issues/172.

Not adding adjustWithKey; alterF was added in #181.


feat(fdc): Add GMP header

@maneesht seems the e2e test needs to be updated as well for this change.


Update homework-15

Hi anh @duykhanhrc  , This is my homework-15. Pls help me review it. :))

Hi,
Your homework 15 has been reviewed, thank you for your effort.
Great! Keep up the good work!
Best wishes from Automation Test Pro,
Khanh


Tweens and Trigger areas don't work together

If I use a Tween and a Trigger Area form the utils library on a same entity, I can't get the trigger area to work, it doesn't detect that the player stands inside it.
Probably it's something to do with how the trigger area works and how it calculates the current position of the entity.

tackled at https://github.com/decentraland/unity-renderer/pull/6037, will reach production with next explorer's release and subsequent SDK release

Fix released with<EMAIL_ADDRESS>


Reverse Futility Pruning

Score of svart-rfp vs svart-master: 209 - 125 - 105  [0.596] 439
...      svart-rfp playing White: 99 - 61 - 60  [0.586] 220
...      svart-rfp playing Black: 110 - 64 - 45  [0.605] 219
...      White vs Black: 163 - 171 - 105  [0.491] 439
Elo difference: 67.3 +/- 28.7, LOS: 100.0 %, DrawRatio: 23.9 %
SPRT: llr 2.98 (101.2%), lbound -2.94, ubound 2.94 - H1 was accepted

Played around with 40, 50, 60 and 100 margins but none seem too conclusive, might look into running longer test in the future but at the moment I am not interested in fine tuning these values too much.


While npm run build; The input-h1 class does not exist. If input-h1 is a custom class, make sure it is defined within a @layer directive.

I have created multiple utilities classes and used it in svelte files as styles, but when ever I try to build the app to deploy it on my VPS. I am getting the issue of
The "custom-class" class does not exist.  If "custom-class" is a custom class, make sure it is defined within a `@layer` directive.

Help me fix it...
File app.postcss:
..
@layer utilities {
    .input-h1 {
        @apply text-4xl font-extrabold;
        @apply font-play-fair mx-auto text-center;
        @apply text-gray-800 dark:text-gray-100;
    }
}
..

File form.svelte
<style>
    h1 {
        @apply input-h1;
    }
</style>

is there anyone available?


'<#> in Stock' should be displayed in green if adequate stock

Description:  ‘On the PDP, the number of in stock items should be displayed in green if there is adequate stock to cover the quantity and red if there is not. Currently the user may not enter a quantity higher than the available stock number.
How to duplicate: Go to PDP and enter a quantity greater that the available in stock.

I don't know if this is relevant, but when the user goes over the min/max, the input goes to the min/max. This is a feature that was created somewhere in January by someone before.
Therefore, not needing to put the stock in red if it goes over. Maybe if you want to keep this feature, have the stocks be green?


Add obsmode optional input

This PR adds "obsmode" as an optional input. It can be entered via config file, or as a parameter on the command line "--obsmode".
This allows the user to specify the type of data to search for (e.g. "image", "wfss").
The modes entered by the user are checked against the list of valid mode names (from MAST). The user is alerted to any entered modes that are not included in the list of valid modes, but the query is not stopped. Invalid modes are simply ignored by MAST. If no modes are entered, then MAST is queried with the instrument name followed by a wildcard, which will get data from all modes.
NOTE: until MAST finishes reprocessing all of its data, specifying modes may not return all matching data. For example, querying using NIRCAM/WFSS will only find data that have been reprocessed to update the instrument value. Old WFSS data will still have an instrument name of NIRCAM (rather than NIRCAM/WFSS) and therefore the search will not find it. So until reprocessing is complete, it's safer to omit mode names. This will result in a MAST query using an instrument name of, e.g. NIRCAM*,  which will return all (reprocessed and not reprocessed) nircam data.

Ok @arminrest, I think this is what we want. Users can now enter, e.g. --obsmode ['image', 'wfss'] in order to get back data from only those two modes. I've left the default for obsmode to be empty. Until the MAST data reprocessing is finished, users need to be really careful when specifying obsmode. Data that have not been reprocessed won't be found since they won't have their mode set yet in the database.

Review done offline.


[1.3] The implementation of the Device Energy Management Cluster is required in Sample app

Reproduction steps
Executed the below mentioned command to put DUT into a commissionable state
./chip-all-clusters-app
Once DUT reach the commissionable state sent below mentioned command on TH.
./chip-tool pairing onnetwork 1 20202021
After the successful commissioning, I attempted to validate the  Device energy management Cluster  , but it is not implemented in sample app
./chip-tool deviceenergymanagement read cluster-revision 1 1

[1702963615.351626][6400:6402] CHIP:EM: Rxd Ack; Removing MessageCounter:217823681 from Retrans Table on exchange 12502i
[1702963615.351727][6400:6402] CHIP:DMG: ReportDataMessage =
[1702963615.351775][6400:6402] CHIP:DMG: {
[1702963615.351813][6400:6402] CHIP:DMG: 	AttributeReportIBs =
[1702963615.351872][6400:6402] CHIP:DMG: 	[
[1702963615.351916][6400:6402] CHIP:DMG: 		AttributeReportIB =
[1702963615.351977][6400:6402] CHIP:DMG: 		{
[1702963615.352023][6400:6402] CHIP:DMG: 			AttributeStatusIB =
[1702963615.352078][6400:6402] CHIP:DMG: 			{
[1702963615.352129][6400:6402] CHIP:DMG: 				AttributePathIB =
[1702963615.352186][6400:6402] CHIP:DMG: 				{
[1702963615.352243][6400:6402] CHIP:DMG: 					Endpoint = 0x1,
[1702963615.352305][6400:6402] CHIP:DMG: 					Cluster = 0x98,
[1702963615.352367][6400:6402] CHIP:DMG: 					Attribute = 0x0000_FFFD,
[1702963615.352424][6400:6402] CHIP:DMG: 				}
[1702963615.352487][6400:6402] CHIP:DMG:
[1702963615.352540][6400:6402] CHIP:DMG: 				StatusIB =
[1702963615.352596][6400:6402] CHIP:DMG: 				{
[1702963615.352653][6400:6402] CHIP:DMG: 					status = 0xc3 (UNSUPPORTED_CLUSTER),
[1702963615.352711][6400:6402] CHIP:DMG: 				},
[1702963615.352769][6400:6402] CHIP:DMG:
[1702963615.352819][6400:6402] CHIP:DMG: 			},
[1702963615.352876][6400:6402] CHIP:DMG:
[1702963615.352921][6400:6402] CHIP:DMG: 		},
[1702963615.352974][6400:6402] CHIP:DMG:
[1702963615.353015][6400:6402] CHIP:DMG: 	],
[1702963615.353068][6400:6402] CHIP:DMG:
[1702963615.353111][6400:6402] CHIP:DMG: 	SuppressResponse = true,
[1702963615.353156][6400:6402] CHIP:DMG: 	InteractionModelRevision = 11
[1702963615.353197][6400:6402] CHIP:DMG: }
[1702963615.353467][6400:6402] CHIP:TOO: Response Failure: IM Error 0x000005C3: General error: 0xc3 (UNSUPPORTED_CLUSTER)
[1702963615.353832][6400:6402] CHIP:EM: <<< [E:12502i S:53276 M:217823682 (Ack:84559124)] (S) Msg TX to 1:0000000000000001 [FFC7] [UDP:[fe80::e65f:1ff:fe49:ae1a%wlan0]:5540] --- Type 0000:10 (SecureChannel:StandaloneAck)

Bug prevalence
whenever I do
GitHub hash of the SDK that was being used
7cbac9130d2b10d6bfdba873129dfbffa294cf8d
Platform
raspi
Platform Version(s)
No response
Type
Test Improvement
Anything else?
No response

@Survensa Device Energy Management and DRLC are not the same thing.  Which one is this issue about?

@bzbarsky-apple The issue is related to Device Energy management cluster.

In that case, https://github.com/project-chip/connectedhomeip/pull/30957 will fix.


[Enhancement]: Styling options for Table column headers

Is there an existing issue for this?

[X] I have searched the existing issues

Summary
Today, only the alignment options affect the table headers. It would be nice to be able to  apply other available styles to the table column headers. Eg: Text Size, Emphasis, Cell Background, Text Color, etc.
Why should this be worked on?
Column headers should support styling. https://discord.com/channels/725602949748752515/1051899061197873204/1051899061197873204
 Front conversations

@sathishvenkataraman right now we are working on a major re-haul of widget to adhear better to theming so that they look good out of the box. Our approach is to make it good look out of the box, rather than give that control to the users.
Does this sound good to you? Do you have any use cases where you would rather control this your self.
cc @ichik @jsartisan @KelvinOm

Styling out of the box would be better, at the end I prefer maximum control. Main issue now is the sizing, I having quite a lot of columns in a table, therefor I styled the rows to smalle size, but the titles does not size with the content, so it's getting unclear for my users what column they are looking at.


NullReferenceException

when opening a pdf file with JBIG2 image:
System.NullReferenceException occurred
  HResult=0x80004003
  Message=Object reference not set to an instance of an object.
  Source=JBig2Decoder
  StackTrace:
   at JBig2Decoder.TextRegionSegment.readSegment()
   at JBig2Decoder.JBIG2StreamDecoder.readSegments()
   at JBig2Decoder.JBIG2StreamDecoder.decodeJBIG2(Byte[] data, ImageFormat format, Int32 NewWidth, Int32 NewHeight)

according to this https://issues.apache.org/jira/browse/PDFBOX-1067 it has something to do with JBIG2Globals.

the pdf attached to this issue is somehow special. It's datastream is somehow splitted, it contains a global segment (JBIG2Globals) I didn't understand yet what that really means ...
There's a comment here about dealing with embedded data, where JBIG2Globals are separate: http://code.google.com/p/jbig2-imageio/wiki/Usage here that Does that help?

attached are some files from the ticket: https://issues.apache.org/jira/browse/PDFBOX-1067
ItDoesntWorkScan.jbig2.zip
ItDoesntWorkScan.pdf
sakelley_pdf_rendering_problem.zip

same issue with file: https://issues.apache.org/jira/secure/attachment/12865265/jbig2.pdf

I just see same issue, can you help take a look this issue? thanks.

well it is a nullreferenceexception, can be fixed easily but you need to know the root cause. Hope the developer reads this?


(fix) Resolver: list CatSrc using client, instead of referring to registry-server cache

Using "available CatalogSources" information from the registry-client cache was causing cache inconsistency problems.
This has showed up multiple times in production environments over the years, manifesting itself in the form of the all subscriptions in a namespace being transitioned into an error state when a Catalogsource that the cache claims to exist, has actually been deleted from the cluster, but the cache was not updated.
The Subscriptions are transitioned to an error state because of the deleted catalogsource with the follwing error message:
"message": "failed to populate resolver cache from source : failed to list
bundles: rpc error: code = Unavailable desc = connection error: desc = "transport:
Error while dialing dial tcp: lookup ..svc on 172.....: no such host"",
"reason": "ErrorPreventedResolution",
"status": "True",
"type": "ResolutionFailed"
This PR switches the information lookup from the cache, to using a client to list the CatalogSources present in the cluster.

Description of the change:
Motivation for the change:
Architectural changes:

Testing remarks:

Reviewer Checklist

[ ] Implementation matches the proposed design, or proposal is updated to match implementation
[ ] Sufficient unit test coverage
[ ] Sufficient end-to-end test coverage
[ ] Bug fixes are accompanied by regression test(s)
[ ] e2e tests and flake fixes are accompanied evidence of flake testing, e.g. executing the test 100(0) times
[ ] tech debt/todo is accompanied by issue link(s) in comments in the surrounding code
[ ] Tests are comprehensible, e.g. Ginkgo DSL is being used appropriately
[ ] Docs updated or added to /doc
[ ] Commit messages sensible and descriptive
[ ] Tests marked as [FLAKE] are truly flaky and have an issue
[ ] Code is properly formatted

Picking up https://github.com/operator-framework/operator-lifecycle-manager/pull/2779

/hold
I want to test this a little more before I open it up for reviews.

This PR switches the information lookup from the cache, to using a client to list the CatalogSources present in the cluster.

Bolded to emphasize that the list of available catalogs is coming from a cache of registry-server clients, not a cache of CatalogSources. In other words, it wasn't reading stale cache entries, it was reading the wrong cache. Fixing this to actually be based on CatalogSources is a huge improvement.

@benluddy thanks for chiming in! It's been a fun read for a few days, but I think I have a clearer understanding of what's going on now. Many different caches at play here. I'm thinking it's probably a good idea to revisit https://github.com/operator-framework/operator-lifecycle-manager/pull/2337 and the efforts around it (probably https://github.com/operator-framework/operator-lifecycle-manager/pull/2632 too ). Will behoove us to devote some effort in reeling down the code base, for ease of maintenance going forward.
A very simple: 1. list all the resources needed from the cluster, 2. convert them to the desired formats (Installables, or whatever the latest term is), 3. "Solve", without too many caches at play sounds much more maintainable.
That's not for this PR though 😬
Opening up the PR for reviews.
/hold cancel

/approve /lgtm


tensorflow keras random seeds not working

Hello,
I am using Tensorflow 1.5 and its embedded Keras on CPU.
The following simple program does not produce the same results at every run despite setting the random seeds for keras and TF
import numpy as np
np.random.seed(123)

import tensorflow as tf
tf.set_random_seed(123)
from tensorflow.python.keras.models import Sequential
from tensorflow.python.keras.layers import Dense

def create_model(input_dim, output_dim, training=True):
    from tensorflow.python.keras.models import Sequential
    from tensorflow.python.keras.layers import Dense
    hidden_dim = 8
    model = Sequential()
    model.add(Dense(input_dim=input_dim, units=hidden_dim))
    model.add(Dense(units=output_dim, activation='linear'))
    model.compile(loss='mse', optimizer='adam')
    return model

N = 100000
X = np.random.normal(loc=0.0, scale=1.0, size=(N, 20))
Y = np.random.normal(loc=0.0, scale=1.0, size=(N, 2))
input_dim = X.shape[1]
output_dim = Y.shape[1]

tf.reset_default_graph()
tf.set_random_seed(123)
model = create_model(input_dim, output_dim)
model.fit(X, Y, batch_size=100, epochs=1, verbose=1)

Y_pred = model.predict(X, batch_size=1)

print Y_pred[0:5]

Try with plain random seed first at the top of the file with 1.
from random import seed
seed(1)

Btw, what is your python version?

What if you use random as a class?
from random import Random

random = Random(123)
print random.random()

This is working perfectly every time for me, with the same random values.

I think the problem is with the initialisation of random values inside Keras and Tensorflow. Please take the code I put, you will see that you do not reproduce same values

@volvador Hi, can you try with tf-nightly and see if you are running into the same problem.

@volvador  Is this still an issue ?  tf-nightly didn't work ?

Automatically closing due to lack of recent activity. Please update the issue when new information becomes available, and we will reopen the issue. Thanks!


Show a download progress bar when downloading a photo

*Open for suggestions how it should look like

On it.