Add OLM-specific generator configs for each service and the service template

Is your feature request related to a problem?
No
Describe the solution you'd like
To simplify the automated creation of Operator Lifecycle Manager ("OLM") bundles for a given controller release, the controller repos need a base configuration added.
As an initial goal, I figure it makes sense to contribute one for each repo for which an e2e test exists (referring to: https://github.com/aws-controllers-k8s/community/tree/main/test/e2e). That said, I see S3 is missing here and I've done most testing against S3 so I'll throw that in as well:

dynamodb https://github.com/aws-controllers-k8s/dynamodb-controller
ecr https://github.com/aws-controllers-k8s/ecr-controller
kms https://github.com/aws-controllers-k8s/kms-controller
mq https://github.com/aws-controllers-k8s/mq-controller
sfn https://github.com/aws-controllers-k8s/sfn-controller
sns https://github.com/aws-controllers-k8s/sns-controller
sqs https://github.com/aws-controllers-k8s/sqs-controller
sqs https://github.com/aws-controllers-k8s/s3-controller

We can also add a generic config for the template

template https://github.com/aws-controllers-k8s/template-controller

I expect these configs to live at this path: {SERVICE}-controller/olm/olmconfig.yaml to align with the default location being used by build scripts.
Alternatively, what services would you prefer to see? I can add those as well.
Describe alternatives you've considered
The alternative is to have these configs hosted elsewhere as a relatively-static asset that can be pulled down at build-time. This alternate would require an additional step either in build automation or in the scripts that call ack-generate olm.

Actually each of the repositories you've listed in this are using the old-style bash e2e resources. All of the other repositories have transferred to the new Python e2e resources, and I'd say those are more suitable for this enhancement. A full list of those repositories is in this issue: https://github.com/aws-controllers-k8s/community/issues/735

Ah, thanks @RedbackThomson! I'll check out the list and target that instead.

With that in mind, here are the new targets:

[ ] apigatewayv2 - aws-controllers-k8s/apigatewayv2-controller
[ ] applicationautoscaling - aws-controllers-k8s/applicationautoscaling-controller
[ ] elasticache - aws-controllers-k8s/elasticache-controller
[ ] mq - aws-controllers-k8s/mq-controller
[ ] rds - aws-controllers-k8s/rds-controller
[ ] sagemaker - aws-controllers-k8s/sagemaker-controller
[ ] s3 - aws-controllers-k8s/s3-controller#11

I'll update with PR links as they come through.

@RedbackThomson I've historically been using a configuration that looked like this.
---
annotations:
  capabilityLevel: basic install
  shortDescription: AWS S3 Controller is a Service Controller for Managing AWS S3 Buckets
    in Kubernetes
displayName: AWS Simple Storage Service (S3) for Kubernetes
description: Manage AWS S3 Buckets from within your OpenShift cluster.
  This controller is a component of the [AWS Controller for Kubernetes](https://github.com/aws/aws-controllers-k8s)
  project. This project is currently in **developer preview**.
samples:
- kind: Bucket
  spec: |
    name: "example-bucket-created-by-ack"
- kind: MultipartUpload
  spec: |
    bucket: "example-bucket-created-by-ack"
      key: "some-key"
maintainers:
- name: "The ACK Team"
  email<EMAIL_ADDRESS>
A few questions:
Display Names:
I used this format for testing but it's up for adjustment.
displayName: AWS Simple Storage Service (S3) for Kubernetes

Would you prefer this instead use the format as written in the service controller READMEs? E.g.:

displayName: "ACK service controller for Amazon Simple Storage Service (S3)"

Maintainers
What contact information should I put in the maintainer slot? I'm thinking this might vary per service?
maintainers:
- name: "The ACK Team"
  email<EMAIL_ADDRESS>

Are these display names going to be shown on a website as a browsable list? I think that the full names we provide in the README would be unsuitably long for that. Although a reference to them being ACK controllers in the display name is probably a requirement.

They would be be posted in a tile in a layout similar to these:

https://operatorhub.io/
https://catalog.redhat.com/software/operators/explore

@komish I hate to be a stickler, but we're trying to keep ACK agnostic to any underlying Kubernetes platform, whether that is OpenShift or EKS. Can you change the description from this:
description: Manage AWS S3 Buckets from within your OpenShift cluster.

to this?
description: Manage AWS S3 Buckets from within your Kubernetes cluster.

Thank you! :)
-jay

@komish I hate to be a stickler, but we're trying to keep ACK agnostic to any underlying Kubernetes platform, whether that is OpenShift or EKS. Can you change the description from this:

@jaypipes  Sure thing! The configuration above had just been what I used for demo purposes. I've already made the switch locally.
I'm pending feedback on https://github.com/aws-controllers-k8s/community/issues/744#issuecomment-827859644 whenever folks have a moment. I'll keep staging things out in the meantime.

Is it possible to have the ACK folks provide sample/minimal CR specs for each of the service controller CRDs that be included in the olmconfigs? I want to capture a minimum viable spec for the CRD to include. Looking at SageMaker, for example, It has quite a few CRDs with quite a few parameters each.
I'm not familiar enough today with each resource's expected values to be able determine a bare minimum CR spec that a user can use as a starting point.
Just a YAML manifest per-service and per-resource would be sufficient. If they exist somewhere already, I can go pull those in.
Thanks!

Unfortunately we don't have any generated examples/samples for each resource type. We are aware that this is missing from documentation, and have a tracking issue for it - https://github.com/aws-controllers-k8s/community/issues/171
At the minimum we could produce a sample spec with placeholder string/int/bool values, but to have samples with contextually acceptable values (like a correctly formatted path, for example) we'd need to ask each service team to produce those.

@RedbackThomson @jaypipes
SageMaker has been a good "next controller" to test with, as it's uncovering some interesting scenarios that I hadn't accounted for. I'll be working on accounting for these in the olm generator with future patches. Apologies for the oversight!
With that said, a couple of questions (in bullets at the end of each contextual section):

If I take a look at the config/crd for SageMaker, I see 12 CRD bases. https://github.com/aws-controllers-k8s/sagemaker-controller/tree/main/config/crd/bases
The olm generator sees a lot more CRDs than bases, and is laying those down in the CSV base.
$ yq r config/manifests/bases/ack-sagemaker-controller.clusterserviceversion.yaml spec.customresourcedefinitions.owned.*.kind
- Algorithm
- App
- AutoMLJob
- CodeRepository
- CompilationJob
- Domain
- Endpoint
- EndpointConfig
- Experiment
- FlowDefinition
- HumanTaskUi
- HyperParameterTuningJob
- LabelingJob
- Model
- ModelPackage
- MonitoringSchedule
- NotebookInstance
- NotebookInstanceLifecycleConfig
- PresignedDomainURL
- PresignedNotebookInstanceURL
- ProcessingJob
- TrainingJob
- TransformJob
- Trial
- TrialComponent
- UserProfile
- Workforce
- Workteam

So I'm understanding that there's an ignore mechanism when generating CRDs, and if I had to make an educated guess, that's being defined here:
https://github.com/aws-controllers-k8s/sagemaker-controller/blob/main/generator.yaml#L450-L495

Is that correct?
Is this ignore section influencing the crds target such that more CRDs exist than bases?
Are the additional kinds things that exist in the upstream source of truth APIDefinitions, but aren't reflected in the api definitions for the controller itself?**

An additional problem here that I'm seeing; if I look at the list at that link, I see 12 ignored items commented out. I would parse that as "not ignored", which makes sense - and since I have 12 CRDs in config/crd/, I would assume that these that are no longer being ignored align with those.
I seem to be missing a few of those, though:

ModelBiasJobDefinition
ModelExplainabilityJobDefinition
ModelQualityJobDefinition
DataQualityJobDefinition

These seem to exist in config/crd but don't appear to be showing up in my CRDs. I drew that conclusion because I'm not getting entries for them in my CSV base. The end result is that operator-sdk adds them back to the final CSV on disk, but with missing metadata which means they don't represent well in the console.
The template is pulling these from the CRDs variable in the struct passed to the template - https://github.com/aws-controllers-k8s/code-generator/blob/main/templates/config/manifests/bases/clusterserviceversion.yaml.tpl#L20-L27
The CRDs seems to come from the generator
https://github.com/aws-controllers-k8s/code-generator/blob/58c5ed93f998b817c69dfbeb49db3df75dc1d3e8/pkg/generate/olm/olm.go#L56-L59
https://github.com/aws-controllers-k8s/code-generator/blob/58c5ed93f998b817c69dfbeb49db3df75dc1d3e8/pkg/generate/olm/olm.go#L91-L98

Am I using the generator incorrectly here?
Any Idea why I might be missing some things that otherwise shouldn't be ignored according to the generator.yaml?

Thanks a ton! I'll circle back to this tinkering with this on Monday.

I believe I have the above figured out. The build script for OLM does not explicitly set a generator configuration path. PR incoming to resolve!

Following up here - the mentioned PR should resolve a majority of my issues, but I still have the below issue.
I'm missing these resources for SageMaker that exist as CRDs in config/crd/bases/
    ModelBiasJobDefinition
    ModelExplainabilityJobDefinition
    ModelQualityJobDefinition
    DataQualityJobDefinition

The end result is that the necessary metadata is not making it into the operator-sdk bundle.
I add some debug lines to my local ack-generate, and when calling ack-generate olm ..., here's what I'm seeing is ignored vs. what's included.
I'm seeing that the resources from above are not ignored but also not included, and I'm not sure why.
DEBUG CRD is ignored-Workteam
DEBUG CRD is ignored-TrialComponent
DEBUG CRD is ignored-CodeRepository
DEBUG CRD is ignored-LabelingJob
DEBUG CRD is ignored-Algorithm
DEBUG CRD is ignored-FlowDefinition
DEBUG CRD is ignored-Domain
DEBUG CRD is ignored-NotebookInstanceLifecycleConfig
DEBUG CRD is ignored-PresignedDomainUrl
DEBUG CRD is ignored-Experiment
DEBUG CRD is ignored-NotebookInstance
DEBUG CRD is ignored-Trial
DEBUG CRD is ignored-AutoMLJob
DEBUG CRD is ignored-CompilationJob
DEBUG CRD is ignored-ModelPackage
DEBUG CRD is ignored-PresignedNotebookInstanceUrl
DEBUG CRD is ignored-App
DEBUG CRD is ignored-Workforce
DEBUG CRD is ignored-UserProfile
DEBUG CRD is ignored-HumanTaskUi
CRD is included Endpoint
CRD is included EndpointConfig
CRD is included HyperParameterTuningJob
CRD is included Model
CRD is included MonitoringSchedule
CRD is included ProcessingJob
CRD is included TrainingJob
CRD is included TransformJob

I wonder if you are referencing an older version of the SDK without those models in it? They were only added fairly recently.

@RedbackThomson How would I go about confirming? I could purge the cache and have it get pulled down again.. but I think the current tag is what's hard-coded in the release scripts.
16:26:49 ~/.go/src/github.com/aws-controllers-k8s/community/~/.cache/aws-controllers-k8s/src/aws-sdk-go ≪ branch=(no branch) ≫
$ git describe --tags
v1.35.5

16:28:03 ~/.go/src/github.com/aws-controllers-k8s/community ≪ branch=add-generator-to-olm-build ≫
$ grep -R 'v1.35.5' .
./scripts/build-controller-release.sh:ag_args="$SERVICE $RELEASE_VERSION -o $SERVICE_CONTROLLER_SOURCE_PATH --template-dirs $TEMPLATES_DIR --aws-sdk-go-version v1.35.5"
./scripts/build-controller-release.sh:    ag_olm_args="$SERVICE $olm_version -o $SERVICE_CONTROLLER_SOURCE_PATH --template-dirs $TEMPLATES_DIR --olm-config $ACK_GENERATE_OLMCONFIG_PATH --aws-sdk-go-version v1.35.5"

Yeah I think that's our issue, then. I knew that hardcoded version would come back to bite us.
https://github.com/aws/aws-sdk-go/blame/fc28b08d9ce0ff3789ef225511f62ebddd12f056/service/sagemaker/sagemakeriface/interface.go#L171
You can see the CreateModelBiasJobDefinition was not a part of the Go SDK until 1.36.4. Therefore it's not even in the models that you are attempting to generate.
@A-Hilaly I think was the one that set these versions as hardcoded - he probably has more context about them.

Yeah I think that's our issue, then. I knew that hardcoded version would come back to bite us.

For sure. I think, logistically, the problem I have is that CRD bases exist in the sagemaker-controller repository under config/crd/bases for these APIs that don't exist in the hard-coded API version. The discrepancy between version of the Go SDK that we're expected to use and the assets in the repo is what causes things to render incorrectly when passing it operator-sdk.
At any rate, I'll be on the lookout for more information. If there's anything I can do to help, let me know.

@RedbackThomson @komish thanks you for pointing this out! this was a temporary solution (introduced in https://github.com/aws-controllers-k8s/community/commit/3bd821e1377e41166ab253b352b08d4379775e66) when we just moved moved/split all the projects under the Github aws-controllers-k8s org.
Ideally we should be able to set the SDK version using a AWS_SDK_GO_VERSION environment variable (like we currently do in build-controller.sh). I will send a fix in few minutes!

PRs have been submitted that should close this issue Once they've all merged, I'll update the checkboxes in previous comments and then it should be good to close out.


P15 tier update?

The P15 tier (256GB \ 1,100 IOPs \  125 MB/s) is missing (has not yet been updated) in this article.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4ea00c3f-e389-9258-45a5-395247555f75
Version Independent ID: f01af29d-f543-077a-3d71-6b6b437758cd
Content: High-performance Premium Storage and Azure managed disks for Windows VMs
Content Source: articles/virtual-machines/windows/premium-storage.md
Service: virtual-machines-windows
GitHub Login: @ramankumarlive
Microsoft Alias: ramankum

@bryhall Thanks for the feedback! I have assigned the issue to the content author to evaluate and update as appropriate.

@Adam-Smith-MSFT  I'll be taking this particular one, feel free to assign to me.
@bryhall  Thanks for pointing this out! I'll be updating the article and will let you know via this issue when the change has been merged.

@bryhall  The change has been merged and should be live in a few hours. Thank you again for pointing this out.
#please-close


[Feature]: Add Authentication

Describe the feature
Want to add authentication using next auth and saves the data to prisma
Add ScreenShots
No response
Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

/assign-me


Support SSH Keys with Passphrase

Hello,
currently I can not use SSH Keys with passphrases. There is no way to enter the passphrase in the connections manager or in a separate popup for a saved connection.
None the less awsome project!

@Simsch the app should ask you for the passphrase during connection, isn't this the case?

@Eugeny sorry for the late answer. I got the problem right now. I have selected the ppk Key which is not working. Selecting the id_rsa file is working fine and I am asked for the key.
So this bug is not a bug anymore. Thanks!

Sorry, just reviewed the thread, and converted ppk to rsa. Now it's ok.

Let's add PPK support, shall we?


v2.2.0 breaks previous URL map logic for url-encoded path segments containing %2F

Version 2.2.0 seems to change the way url-encoded path segments (specifically paths which contain the escape sequence for /, %2F) are handled in rules/maps in the routing module.
Here's a self-contained example demonstrating the difference in routing behavior, save this in werkzeug_test.py for example:
from werkzeug.routing import Map, Rule
from werkzeug.wrappers import Request, Response

class PathTester:

    URL_MAP = Map(
        [
            Rule(
                "/<path:some_path>/some_route",
                endpoint="simple_route",
            ),
            Rule(
                "/<path:some_path>/<segment_a>/<segment_b>",
                endpoint="complex_route",
            ),
        ]
    )

    def on_simple_route(self, request, some_path):
        return Response("Matched simple route")

    def on_complex_route(self, request, some_path, segment_a, segment_b):
        return Response("Matched complex route")

    def dispatch_request(self, request):
        adapter = self.URL_MAP.bind_to_environ(request.environ)
        endpoint, values = adapter.match()
        return getattr(self, f"on_{endpoint}")(request, **values)

    def wsgi_app(self, environ, start_response):
        request = Request(environ)
        response = self.dispatch_request(request)
        return response(environ, start_response)

    def __call__(self, environ, start_response):
        return self.wsgi_app(environ, start_response)

if __name__ == "__main__":
    from werkzeug.serving import run_simple
    run_simple("<IP_ADDRESS>", 5000, PathTester())

Running this example using werkzeug 2.1.2:
$ pip install --upgrade Werkzeug==2.1.2
$ python werkzeug_test.py

# … in another terminal

$ curl http://localhost:5000/my%2Fpath/some_route
Matched simple route

Now, running this example using werkzeug 2.2.0:
$ pip install --upgrade Werkzeug==2.2.0
$ python werkzeug_test.py

# … in another terminal

$ curl http://localhost:5000/my%2Fpath/some_route
Matched complex route

Environment:

Python version: 3.9.13
Werkzeug version: 2.2.0

We're experiencing a similar issue with a change of behavior in the routing where a trailing slash triggers a 404 in Flask, while before an url ending at '/' was correctly redirected to the canonical URL for the endpoint.
I believe the issue is related, we did some troubleshooting and it seems the issue started after the commit at https://github.com/pallets/werkzeug/commit/88125beebc6463e571cef3ca84eccfad0c818ae3

Having this same issue as well. When starting the process, it hangs with 100% of usage dedicated to the function parse_rules.

@elfosardo & @jonathan-s I think your issues are different. Could you open a new issue each with a code snippet that reproduces the problem and I can use to track it down.
@elfosardo could you confirm that your issue is different to #1074? As fixing that bug could result in the change you have seen.

@pgjones the issue seems the same as in #1074 and probably the fix caused the change we're seeing. Would you  still suggest to open a different issue?

@elfosardo given what you know about #1074 do you consider it a bug still? If so please open a new issue.

@pgjones after having a look at the issue/fix you pointed out, we've gone into the direction of changing the code on our side.
Thanks!


Create a Calculator Fabric sample

Suggestion
It's probably worth having a version of the Calculator sample that uses the new experimental fabric template. Not necessarily because we're going to advertise "use fabric now!" but just to start a baseline that gests some upgrade coverage.
Platforms
Windows
Sample code
No response

@TatianaKapos Can you create this new sample when the other samples are updated for 0.75? Just put it next to the existing Calculator cppwinrt and csharp folders (fabric?) so we have something to monitor and update as we move on to 0.76.


Toyota: Only use gas interceptor under 19 mph, convert accel to gas when needed

steerRatio and minSpeedCan changes explanation: #20152

Previously I changed the compute_gb function in the Toyota interface dynamically if a pedal was detected, but I realized that the clip in longcontrol was for accel not gas, so if it clipped it to 0.5, it's not 50% of max accel, it's 50% max gas percentage which is wrong. Now, accel is clipped as usual to 50%, and the gas percentage is clipped from 0 to 100%.
How the transition works from accel to gas: I have a simple function that's based off data of coasting at various speeds from 0 to 19 mph, and it switches between sending accel and gas based off if the desired accel is greater than what the coast acceleration would be at that speed.
So for example since coast accel is positive from 0 to ~2.5 m/s, if des accel is less than that (0.2 m/s/s is less than 0.5 m/s/s let's say) we send accel letting the car coast up, applying a small amount of brake to keep us lower than the positive coast accel at those speeds. At above 2.5 m/s it's the opposite with negative coast accel.
It might be car specific though, since I know some hybrids slow down much quicker when you're coasting, so I'm not sure how to handle that.
Todos:

[x] Fix braking momentarily when engaging at low speeds.
[ ] Test briskspirit's new long tune (braking is still a bit jerky even though we're using acc and stock non-pedal tuning)

Let me know when some people have tested this.
Also I can't easily check the values for coast_accel, but think it's a little weird that the highest speed has less decel than the second to highest speed.

@pd0wm Here's the data I gathered where I just let it coast at various speeds (this is offsetting a_ego, bringing it forward in time by about half a second to account for delay). Low speed could be a bit higher, I don't know why it's not in the middle.

New function is smoother at low speed but incorrectly ramps down gas as accel raises above ~1m/s/s or so, making 5-20 mph times way too slow. I'll try to fix that with the final function

Latest coast function and the logic to always send offsetted brake under the min acc speed almost completely fixes it braking for a second when engaging at low speed for me

Almost ready, just need to solve the car not releasing brakes soon enough causing a spike of gas. In data, I've seen the desired speed at a constant low value but the car just doesn't release brakes (it's below the coast accel at that speed). Multiplying the des accel for the car at a standstill might be the only way to release brakes quicker.

This relies on the removed brakeLights signal, I'll have to figure something else out to get the car to release brakes sooner (previously was multiplying accel when car was braking). Could just define the minimum desired acceleration that gets the car to release brakes partially or fully, and send it when we're stopped and want to resume.

Closing, will be revisited in the future


There may be problems with the introduction method in the document

Reproduction
N/A
Steps to reproduce the bug
In the https://pinia.vuejs.org/zh/core-concepts/plugins.html documentation
import debounce from 'lodash/debounce'
In some projects there may be problems, in production there will be Canot read properties of undefined (reading 'now')
It is proposed instead:
import { debounce } from 'lodash';
Expected behavior
You should not prompt Canot read properties of undefined (reading 'now')
Actual behavior
Page throws exception: Canot read properties of undefined (reading 'now')
Additional information
No response

This depends on your project but it's unrelated to pinia. As of today, the lodash docs still show examples of importing like that, so this might be an issue in your project. I personally use https://github.com/chodorowicz/ts-debounce or write my own debounce


feat: Support table headers in formatted text (DEV-3473)

Pull Request Checklist
Task Description/Number

Issue Number: DEV-
PR Type

[ ] build/chore: maintenance tasks (no production code change)
[ ] docs: documentation changes (no production code change)
[ ] feat: represents new features
[ ] fix: represents bug fixes
[ ] perf: performance improvements
[ ] refactor: represents production code refactoring
[ ] test: adding or refactoring tests (no production code change)
[ ] deprecated: Deprecation warning (ideally referencing a migration guide)

Basic requirements for bug fixes and features

[ ] Tests for the changes have been added
[ ] Docs have been added / updated

Does this PR introduce a breaking change?

[ ] Yes

Does this PR change client-test-data?

[ ] Yes

question: As far as I understand the colspan tag is the problem in the bug report, isn't it?
"or merged cell in table leads to error""

question: As far as I understand the colspan tag is the problem in the bug report, isn't it?
or merged cell in table leads to error

the merge cell feature has been deactivated in the frontend, so there was no immediate need to add that for now. We could re-enable it and add it too, but this was more immediately an issue, and I think it would make sense to ensure that this works first. But I'm open for discussion, if you think that should be done in one go


Can't apply label with empty values not applied on nodes

HI all,
I'm trying to create a policy to install automatically ODF on an openshift cluster.
For that, I need to label some nodes with cluster.ocs.openshift.io/openshift-storage: ""
My policy says:

notification - nodes [worker1.pink.edu.ihost.com] found as specified, therefore this Object template is compliant

But the label is not there :/
Here is the ComplicancePolicy used:
 apiVersion: policy.open-cluster-management.io/v1
  kind: ConfigurationPolicy
  metadata:
    name: odf-label-nodes
  spec:
    object-templates:
      - complianceType: musthave
        objectDefinition:
          apiVersion: v1
          kind: Node
          metadata:
            name: worker1.pink.edu.ihost.com
            labels:
              cluster.ocs.openshift.io/openshift-storage: ""

I've seen some other policies in this repo that are doing the same thing; but it doesn't seem to work.
community/CM-Configuration-Management/policy-label-worker-nodes.yaml
I'm using openshift 4.13 an ACM 2.8.0
Any Idea ?

Well, I'm using UPI installation mode for on premise cluster on ppc64le CPU arch servers... So for the moment, machineSet is not an option.
I notice it does not apply the label with empty value when the label does not exist.
But if the label is set with another value, the policy works and it can set the label to the "" value.... (very strange)
So I made it work with the following ugly workaround :/
    - objectDefinition:
        apiVersion: policy.open-cluster-management.io/v1
        kind: ConfigurationPolicy
        metadata:
          name: odf-label-nodes
        spec:
          pruneObjectBehavior: None
          remediationAction: inform
          severity: high
          object-templates-raw: |
            {{- range $item, $value := (lookup "v1" "Node" "default" "").items}}
              {{- if lt $item 3}}
             - complianceType: musthave
               objectDefinition:
                 apiVersion: v1
                 kind: Node
                 metadata:
                   name: {{ .metadata.name }}
                   labels:
                   {{ $label := index .metadata.labels "cluster.ocs.openshift.io/openshift-storage"}}
                   {{- if $label }}
                      cluster.ocs.openshift.io/openshift-storage: ''
                   {{- else}}
                    {{- if ne $label "" }}
                      cluster.ocs.openshift.io/openshift-storage: none
                     {{- end }}
                   {{- end }}
              {{- end }}
             {{- end }}

Yes, that's what I just noticed.  You can add any "extra" label or annotation with a value set and then you will get your labels with "" values.

This is a bit complicated and seems to be a bug. 🤔

I did create a bug for this. I was thinking it would automatically link to this issue

https://issues.redhat.com/browse/ACM-6760

I found out a bug already existed for this: https://issues.redhat.com/browse/ACM-5398
That bug is being worked on now (this sprint).

The fix was delivered in ACM 2.8.2.  I think it's been available for about a month but I forgot to follow up here.  Let me know if we can close this issue.

Please re-open this issue if you find that the problem is not fixed in ACM 2.8 or 2.9.  Thanks


first event no callback

after subscribed channel, the first event not callback.

Which event are you looking for?

I think the channel doesn't subscribe for some reason, @danielrhodes. If so, I have the same issue many times

First of all, did you retain the channel somewhere? I kind of want to change the design of the library somewhat to make this not necessary as I used another realtime library and was unhappy with having a separate channel object.

@danielrhodes Actually having a separate Channel object is great. In our app we have Websocket object as a singleton at all times, and create Channel's on demand, whenever user needs them. This flow makes sense also because Starscream library seems to fail to cleanup properly, and crash when we recreate Websocket object =)

I am not, @danielrhodes. I have it like

    var webSocketsRoomChannel: Channel {
        let channelIdPayload = ["channel_id" : viewModel.channel?.identifier]
        let channel = SocketRouter.shared.client.create(WebSocketEventsChannel.channel, identifier: channelIdPayload, autoSubscribe: true, bufferActions: true)
        return channel
    }

Server-side to send the event changed to asynchronous, it is solved.


replace IpList with CidrRange

CidrRange seems to support both IPv4 and IPv6. Is the intention to replace IpList with CidrRange?

Yes, IIRC IpList is only used now in the client SSL auth filter (not sure where else). Anywhere we have a list of IP ranges and subnet masks, we should support both v4 and v6.

Yes, CidrRange was added expressly to support generalizing the support in
envoy for lists of IP addresses of either type.
On Jun 5, 2017 3:44 PM, "Matt Klein"<EMAIL_ADDRESS>wrote:

Yes, IIRC IpList is only used now in the client SSL auth filter (not sure
where else). Anywhere we have a list of IP ranges and subnet masks, we
should support both v4 and v6.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/lyft/envoy/issues/1045#issuecomment-306331412, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABYmUwWezRGEL7qOL9KJDh9ssh825JnMks5sBITbgaJpZM4NwNmw
.

Question about two input cases:

Currently, IpList does not allow the input IP address to set bits that are set in the mask. For example: <IP_ADDRESS>/24 will throw. The current functionality of CidrRange allows this input behavior and will return a truncated address. For example <IP_ADDRESS> without error. Which is preferred?
Similarly, IpList doesn't allow mask lengths > 32 for Ipv4 addresses. CidrRange currently will return with the mask length = 32. Which is preferred?

@hennna re: (1) and (2) above, I don't have a strong opinion and would need to refresh my memory on the different call sites. Can you take a look at where things are used and make a proposal based on what makes the most sense? As long as the behavior is well documented I don't think it matters that much. (I would probably go with more permissive as long as the result is the same).

Seems to be instantiated in three places

TcpProxy source_ip
TcpProxy destination_ip
SSL ip_white_list


Create Stacks.java

Check code again Not working the main function

Check the code again Not working the main function

Check online compiler
maybe some regions do not read file in online compiler

Rename the file only to Stacks.java
The T is for Generic , like The stack can be of any data type

Add a snapshot of the running code when you send pull-request
Then easy to check the correct code
I already mention adding a snapshot of the running code in the code of conduct

Add a snapshot of the running code when you send pull-request Then easy to check the correct code
I already mention adding a snapshot of the running code in the code of conduct

sure


TrafficFlow branch - Stream Analytics job degrades after several days

SA job degrades after several days running, with no apparent cause.

Stale


Merge axes names after contraction

As discussed in https://github.com/google/TensorNetwork/issues/179, we should merge axes names after contraction and throw an error if the user tries to access an ambiguous name.

I can sure give this a try! One thing I'm immediately wondering is whether we should exploit a node's name to introduce uniqueness. I tend to reuse a name like "physical_index" for multiple MPS nodes, but I would give the nodes different names.
For instance, a Node Awith axis names [a, b, c]and another node B with the same axis names. After contracting the a axis we can return a Node with axis names [A_b, A_c, B_b, B_c] ... What do you think?

That might get messy once you start contracting multiple nodes together. Also, unless you specify a node name, the new node created after contraction will have a default name "__Node_X".

Yes, you are right. I always specify node names, but unless we make this a required property (which we should not I think), we can't assume the user will do this and than it can become a complete jungle very quickly.

Should we throw an error immediately when a contraction is done that leaves unambiguous axis, or delay this as long as possible (only for instance when user makes explicit reference to such axis name?)

I think when the user does it explicitly.

Currently we are throwing that error at Node creation time (see add_axis_names method)? Should we change this also and only throw errors when axis is requested not when names are added? Or treat nodes added and nodes created from contraction differently. The latter feels awkward to me.

@Thenerdstation You want it when user does it explicitly? See my remake above :)

Sorry for the late response.
I see what you mean by the latter feeling awkward, but right now I think it's the best compromise we can do. It makes sense to throw an error when a user writes it, as it can be easily fixed, but it's the best compromise we could come up with when the axis names collide after contraction.

If this issue is still needed to be solved I would like to work it.

was it fixed in the main package? how do I use the fixed version?


incorrect behavior in c parser with forward declaration

Describe the bug
Incorrect parsing forward declaration structs
To Reproduce
Steps to reproduce the behavior:

test_case.zip
Open any binary (eg. helloworld)
Import types from test_case.h by "Create New Types..." button
See unexpected __offset(0x8) field

Expected behavior
__offset (0x8) field does not exist
Screenshots

Additional context
Binary Ninja Version: 2.3.2787-dev Personal, 2e6e0ce9

The __offset(0x8) keyword means the next field starts at 0x8, which is smaller than the address that is already occupied by the last member, in this case 0x18.
This looks bizarre since on the one hand, it seems we know the size of LIST_ENTRY so we can correct calculate the end of it, i.e., 0x18. On the other hand, the reason we put Action at offset 0x8 is we think the size of LIST_ENTRY is 0. There must be something wrong in the type parser, or the surrounding code.

Forward declared structure types are now handled and resolved upon parsing, as of 3.0.3413-dev (both clang and core parsers).

There appears to be a regression related to this issue. 3.0.3457-dev correctly parses these definitions:
typedef struct _LIST_ENTRY LIST_ENTRY;
struct _LIST_ENTRY {
LIST_ENTRY *ForwardLink;
LIST_ENTRY *BackwardLink;
};
However, 3.0.3459-dev and the latest build from today (3.1.3470-dev) both fail with this error:
error: : sources.hpp:1: error: type '_LIST_ENTRY' is not defined

Which type parser setting are you using?

I hadn't changed that setting, but it looks like the default in 3.0.3457-dev was ClangTypeParser and starting with 3.0.3459-dev. the default is CoreTypeParser again.
It works correctly with ClangTypeParser.

We switched it back just for the stable as there were some unintended side effects and are switching it right back to clang post 3.1 stable so it naturally may result in a little confusion, but in short if what you want isn't working in one, manually change to the other! Sorry about that!

No worries, it didn't occur to me to go look for that setting until you mentioned it since it had been working great for my use case with the new type parser.  Thanks!


Ingress name validation is failing

What kind of request is this (question/bug/enhancement/feature request):
bug
Steps to reproduce (least amount of steps as possible):

On a fresh Rancher 2.2.1 installation, rollout a helm chart (eg. rabbitmq in my case)
Try to add ingress with name my-name
Result:
Error:

Validation failed in API: Ingress.extensions "rabbit-mq" is invalid: spec.rules[0].http.backend.serviceName: Invalid value: "rabbitmq:rabbitmq-staging": a DNS-1035 label must consist of lower case alphanumeric characters or '-', start with an alphabetic character, and end with an alphanumeric character (e.g. 'my-name', or 'abc-123', regex used for validation is '[a-z]([-a-z0-9]*[a-z0-9])?')

Other details that may be helpful:
Environment information

Rancher version (rancher/rancher/rancher/server image tag or shown bottom left in the UI): 2.2.1
Installation option (single install/HA):
single install

Cluster information

Cluster type (Hosted/Infrastructure Provider/Custom/Imported): Custom
Machine type (cloud/VM/metal) and specifications (CPU/memory): metal
Kubernetes version (use kubectl version):

1.13.5

Docker version (use docker version):

Client:
 Version:           18.09.0
 API version:       1.39
 Go version:        go1.10.4
 Git commit:        4d60db4
 Built:             Wed Nov  7 00:49:01 2018
 OS/Arch:           linux/amd64
 Experimental:      false

@matfiz - I am unable to reproduce this behavior, can you tell me:

What is the name of the namespace of your helm chart
According to the error, it looks like the ingress service you are creating is name rabbitmq, are you sure it's my-name?
Are you attaching it to the rabbitmq workload or service?
What type of custom cluster?  Who is the provider, type of vms?

I will continue to try and reproduce, but if you can give me a bit more information, maybe we can track this down.

Hello,
I'm experiencing the same issue with my Rancher v2.2.4 when adding to a new ingress.
I'm not sure what I'm doing wrong, I already remove the project and tried again with no success.
Validation failed in API: Ingress.extensions "my-name" is invalid: spec.rules[0].http.backend.serviceName: Invalid value: "smsup:jsg": a DNS-1035 label must consist of lower case alphanumeric characters or '-', start with an alphabetic character, and end with an alphanumeric character (e.g. 'my-name', or 'abc-123', regex used for validation is '[a-z]([-a-z0-9]*[a-z0-9])?') This is the error message Im getting

Progress, it worked when I only have 1 port.


python3Packages.py-opensonic: 5.2.0 -> 5.2.1

https://github.com/khers/py-opensonic/compare/v5.2.0...v5.2.1
Fixes a syntax error in 5.2.0. Tested with my music-assistant setup, where the update fixes the ability to load the subsonic provider.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 354131

x86_64-linux

:white_check_mark: 2 packages built:

python311Packages.py-opensonic
python312Packages.py-opensonic

aarch64-linux

:white_check_mark: 2 packages built:

python311Packages.py-opensonic
python312Packages.py-opensonic

x86_64-darwin

:white_check_mark: 2 packages built:

python311Packages.py-opensonic
python312Packages.py-opensonic

aarch64-darwin

:white_check_mark: 2 packages built:

python311Packages.py-opensonic
python312Packages.py-opensonic


Web app should have a link to download the desktop app

In the web app, there should be a visible link to download the desktop app.
This could be a banner at the top of the screen and if so, the user should be able to dismiss (hide) the banner.
When clicked, a link to the distributions web site will be opened in a new tab.

Anyone currently working on this enhancement? If not I would like to go ahead and assist if possible.

@haadcode @qservando can i work on this if no one is ?

@vaibhavchellani definitely.

Go for it @vaibhavchellani!

@haadcode @qservando on it ! let me know the contributing guidelines

@haadcode @qservando i am unable to find the link to desktop app , as far i can see we have to generate a binary . What link should i redirect the user to ?

@vaibhavchellani when I was looking into it I was using the documentation here https://github.com/orbitdb/orbit-electron. Has a nice walk through of how to set it up locally. I believe it is running on Linux and OS X currently.

As we don't have the binary distribution packages yet, I would say we should point to the Electron version Github @vaibhavchellani. What do you think?

@haadcode we can do that , is anyone working on creating the binary distribution packages?


Replace URLProtocol.properties by access to the property functions

@swift-ci please smoke test

@swift-ci please test

@millenomi Do you have anything to say about this PR?

The Swift project moved the default branch to main and deleted master branch, so GitHub automatically closed the PR. Please re-create pull request with main branch.
More detail about the branch update - https://forums.swift.org/t/updating-branch-names/40412


[Plot] Add a masking tools panel

Closes #98
Implemented functions :

Multiple level of exclusive masks or a single level (as an option)
Operation on the whole mask:

Clear
Inversion
Reset all mask levels

Drawing tools:

Brush (with settable width in image pixels), which provides a way to draw circle
Rectangle
Polygon
Each draw tool can either paint or erase

Thresholding:

Above threshold
Below threshold
Within range
Range can be loaded from current colormap range

10 levels of undo/redo
load/save mask

Related issues: #104, #105

It looks very nice. Some feedback:

The transparency of the mask is too low (at least on my screen).
Colormap dialog is modal. Is it intended?
In my opinion, the mask should not disappear. You have masked the image, the image has a mask and it is drawn.
The polygonal mask tooltip icon should explain the usage (left button to add points, right button to finish)

Colormap dialog is modal because it does not sync with image changes (colormap dialog needs rework).
Addressed 3 comments.
Leaving the mask displayed when closing the mask tool can lead to inconsistencies if one change the image or remove it, the mask will stay...

The main root of the problem is that the mask is totally dissociated of the image used to define it. If the mask is totally dissociated from the image, as it seems to be your choice, you can design a mask at a much higher resolution than the image below it. So, you may think a pixel is selected when it is not.
To me, an image can potentially have data, representation and masks. Of course any of those on its own lead to a visual representation and the actual visualization does not care because it only needs to draw pixmaps. Keeping the simple concept of "legend", one can pack together items and choose to make them disappear if the "image legend" does so.
The analogue in 1D is a curve that has its data (positive and negative values) and its representation (without negative values with log scales). If one totally decouples both, bugs like #100 happen.

@srio
Manolo's proposal: Provide the possibility to show all masks, a particular mask or none.

Mask visibility toggling would be nice, but I'd keep that for later.
It's in the list of mask tools enhancements: See #105.


Use a sturdier headless check

I noticed that a type check was being used, whereas checking the provided SystemInfo class should be more future-proof if something changes.

Hold up, made an oopsie

There we are, StandaloneSystemInfo should avoid the headless reference before we check if we're on a headless.

StandaloneSystemInfo will always return Headless, it's the headless specific ISystemInfo class
This could be properly implemented here by checking Engine.SystemInfo after "on engine init" but I won't be doing that right now


[Enhancement] Gulp task to build demo-site.css

demo-site.css seems to be updated manually. I'd suggest a gulp task to build this file and the min version.

Closing since you just need to add the @import of the class to the cssgram.scss :)


Add a Gitter chat badge to README.md

jenkinsci/lockable-resources-plugin now has a Chat Room on Gitter
@mPokornyETM has just created a chat room. You can visit it here: https://gitter.im/jenkinsci/lockable-resources.
This pull-request adds this badge to your README.md:

If my aim is a little off, please let me know.
Happy chatting.
PS: Click here if you would prefer not to receive automatic pull-requests from Gitter in future.

LGTM bur I will wait for other contributors. Just be sure the team is fine with gitter chat.


Windows seems to not be always working

Sperf core schema is not finding schema files on windows (probably pathing issue)

this was all a bit of a surprise and had nothing to do with pathing as it's just a recursive search for all files beginning with schema:

was getting tripped up sometimes by encoutering the schema.xml from solr
wasn't correctly logging which file it was reading for schema

Because of ticket volume quickly threw this in with the #28 fixes


Implement public add and remove measurement consumer owners.

This change is

src/main/kotlin/org/wfanet/measurement/kingdom/service/api/v2alpha/MeasurementConsumersService.kt, line 103 at r1 (raw file):
Previously, SanjayVas (Sanjay Vasandani) wrote…
Shouldn't there be a check for Account principal from context?

Added that, and the ownership check I forgot as well.


Fix hex.pm integration

Sorry for the delay in replying! Could you please add a test for this to ensure it doesn't break in the future? See https://github.com/badges/shields/tree/master/service-tests for documentation on how to add a test.

It seems the issue was an API change on their side, which has been fixed in the meantime, so I just added the tests.

Thanks for the test!


@workspace not working properly

VS Code Version: 1.85.1
OS Version: macOS 10.15.7 (19H2026)
Logs: Encountered an error while deciding what workspace information to collect: failed

Starting from today, it only throws this error, all the time.
No matter whether it is a simple question or a complex log, only errors are happened.

@mjbvz what error logs can we collect currently for this?

I am also seeing this error for every question I ask with @workspace.

Duplicate of https://github.com/microsoft/vscode-copilot-release/issues/618#issuecomment-1904843603


indicate required in overall RT prop list

Currently asterisks indicating PTs which are required appear in the PT details, but do not appear in the overall PT list for the RT.

🎉 🎉 🎉 thank you!


CMake improvements

Description
Some of the initial CMake list settings have no effect, this is corrected.
Motivation and Context
The existing CMakeLists.txt makes settings that have no effect
How Has This Been Tested?
By inspection of compiler flags, from documentation of Cmake
Types of changes

[x ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Trivial change (affects only documentation or cleanup)

Checklist:

[ ] I have tested this change with a run of GEOSgcm (if non-trivial)
[ ] I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
[ ] I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

This did seem to work for me too. And CI is happy.


Restructure Ballerina resource path parameters to OAS module

Description:
Need to restructure the code base of resource path parameter mapping from Ballerina to OpenAPI specification.
Parent: #5055
When the code is properly restructured, the resource path parameters are reflected in the OpenAPI specification as follows,
Sample Ballerina code:
# Description of the function.
#
# + title - Title of the album
# + return - Return description
resource function get albums/[string title]() {}

OpenAPI specification:
paths:
  /albums/{title}:
      get:
        summary: Description of the function
        operationId: getSongsAlbumId
        parameters:
        - name: title
          in: path
          description: Title of the album
          required: true
          schema:
            type: string

Rest parameters in the resource path:
Ballerina supports rest parameters. There cannot be another parameter after a rest parameter in the resource path.
Utilizing rest parameters in the path of a resource function acts as a list. For example:
resource function get users/[int... id]() {}

This allows us to send a request like:
GET users/id1/id2/id3
In the resulting URL, these parameters are concatenated with %2F (encoded value for /), and it looks like:
http://{hostName}:{port}/users/id1%2Fid2%2Fid3
Parameter serialization is used in OpenAPI specification to support arrays and objects in operation parameters (path, query, header, and cookie) and lets you specify how these parameters should be serialized. The serialization method is defined by the style and explode keywords.
After having some discussions, we decided to omit the mapping of the entire operation for now if there is a rest parameter in the resource path and provide users with a warning since we cannot properly reflect rest parameters in the OpenAPI specification!

Note: we can map the operation without path parameters when there is a rest parameter in the resource path, but then the OpenAPI spec will show incorrect information regarding that operation.

Meeting date: 27/11/2023
Attendees: @shafreenAnfar @lnash94 @SachinAkash01
Had a discussion on the above concerns regarding rest parameters in the resource path and came up with the following decisions:
Ballerina service to OAS

Maps string type rest parameters in resource paths to wildcard paths in OpenAPI specification.
Skips mapping operations with non-string rest parameters in the resource path to OAS.

OAS to Ballerina service

Converts wildcard paths in OpenAPI to Ballerina service with a resource featuring a string rest parameter in its path.

OAS3 does not have a notion of "wildcard path" for PathItems, so this description document will not work for anything outside of ballerina.
Why not just serialize (string) array parameters in a OAS3 standardized way instead?
Using . would do for simple encoding.

I'm with the client side of the OpenAPI ecosystem, and I really encourage you to design ballerina REST encoding compliant to the OAI specification.
Non compliant will result in "can not be used with any existing tooling and requires manual intervention for data serialization/validation".
There is no alternative to OAI, not being compatible as a web/rest framework begs many questions wrt. to the design decisions and the relevance of the framework.

Fixed via https://github.com/ballerina-platform/openapi-tools/pull/1564


[fix][broker]Sync topicPublishRateLimiter update

Motivation
Synchronized update topicPublishRateLimiter in case of race condtion.
There is a race condtion when two threads update topicPublishRateLimiter concurrency：

topicPublishRateLimiter is null at the beginning
Thread1 update it with both publishThrottlingRateInByte < 0 and publishThrottlingRateInMsg < 0
Then thread1 stop at https://github.com/apache/pulsar/blob/7bdfa3a3e5e71c44a174b28d0a843fb6730865fa/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/AbstractTopic.java#L1170
Thread2 update it with publishThrottlingRateInByte > 0 or publishThrottlingRateInMsg > 0
And thread2 will set topicPublishRateLimiter a new limiter.
Then Thread1 resume, and  set  it  to PublishRateLimiter.DISABLED_RATE_LIMITER. Then the new limiter setted by thread2 will never be accessed, which will produce resource leakages

Modifications
Synchronized  method updatePublishDispatcher
Verifying this change

[x] Make sure that the change passes the CI checks.


Fixed duplicate metrics collector registration issue

Coverage decreased (-0.006%) to 62.619% when pulling bad532f265e355fad9b20067c7611f2e6c891bf0 on savitaashture:metric_test_fix into 1bad961ffae7ee8f67d33f42b53009eb414662fb on ServiceComb:master.


Limitations not very clear

Do not delete snapshots created by Azure Backup. Deleting snapshots can result in loss of recovery points and/or restore failures.
Do not delete file shares that are protected by Azure Backup. The current solution will delete all snapshots taken by Azure Backup once the file share is deleted and hence lose all restore points.

Concerns:

Which snapshots? Where are they located/stored?
"Do not delete file shares". Isn't that the whole purpose of backups? In case a customer removes a files share but if there are backups it can recovered, correct?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 58c8b337-ecc4-2031-e182-a311d1ad8ee0
Version Independent ID: bb81eff9-cd8a-4b61-ede3-f5182527f2f1
Content: Back up Azure Files file shares with the Azure Backup Service
Content Source: articles/backup/tutorial-backup-azure-files.md
Service: backup
GitHub Login: @dcurwin
Microsoft Alias: dacurwin

Thanks for your comment. The feedback has been shared with the content owner for further review. Thanks for your patience.

@saurabhsensharma Any insights?

@marroema , thanks for the questions.

Which snapshots? Where are they located/stored?
Azure Backup orchestrates the creation of file share snapshots (the snapshots capability is native to Azure Files) and these snapshots are stored in the Azure File Share itself.
"Do not delete file shares". Isn't that the whole purpose of backups? In case a customer removes a files share but if there are backups it can recovered, correct?
The current solution relies wholly on snapshots which are stored as part of the file share. This provides the ability to go back point in time to a desired state of the file share. Currently, deleting a file share also leads to snapshot loss. At Ignite 2019, we announced a key update that would prevent the accidental deletion of file shares thereby protecting the snapshots from permanent deletion.

We do have a planned roadmap item to move these snapshots to the recovery services vault. this is expected in H1CY2020.

#please-close


Added instance type configuration for DEFAULT instance

Added instance type configuration for DEFAULT instance

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 57.219%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1181

Relevant Lines:
2064

💛  - Coveralls

Google internal confirmation in b/267783676

/gcbrun


Add more pages about our programs

Looks good to me. Thanks for working on that. @xmnlab

thanks for the review @EverVino !


[SPARK-49395] Add 8081 port to Worker resource spec

What changes were proposed in this pull request?
This PR aims to add 8081 port to Worker resource spec.
Why are the changes needed?
Like Master's 8080 port, we can expose it for users.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Manual review.
$ gradle build buildDockerImage spark-operator-api:relocateGeneratedCRD -x check
$ helm install spark-kubernetes-operator -f build-tools/helm/spark-kubernetes-operator/values.yaml build-tools/helm/spark-kubernetes-operator/
$ kubectl apply -f examples/qa-cluster-with-one-worker.yaml
$ kubectl get pod -l spark-role=worker -oyaml | yq '.items[0].spec.containers[0].ports'
- containerPort: 8081
  name: web
  protocol: TCP

Was this patch authored or co-authored using generative AI tooling?
No.

Thank you, @viirya . Merged to main.


Summernote field: add link modal is behind overlay

Bug report
Hello, this is the first time I'm reporting an issue, so let me know if I have to change anything :)
What I did
I've added a summernote field to an entity with a "add link" button. When I'm on the edit page and I click the "add link" button, the modal appears, but "behind" the overlay. This causes the whole page to be unusable and a refresh is needed (since you cannot close the modal because of it).
I checked if it also happens on the demo of Backpack, and also there it happens
What I've already tried to fix it
I saw that adding dialogsInBody: true as an option to the summernote initialization solved my issue. I was thinking - since all summernote fields will have to have this option - to add the dialogsInBody: true as a default.
If I'll figure out how to create a Pull Request I will create one if it's appreciated.
According to my composer.lock file I'm running backpack/crud version 4.0.41
These screenshots are from the Backpack demo itself:

@megatommy - don't worry about it, this is one of the best issue reports I've seen all year 😄 Excellent! 🎈 🎉 Thank you!
I can confirm the problem, and the solution. No need for a PR this time - I've pushed the hot fix in https://github.com/Laravel-Backpack/CRUD/commit/192eb8c833b30f2fbedd7705f13ad888b4b02f30 . It's already on the master branch, it'll be tagged and available with a composer update later today, as Backpack\CRUD 4.0.42 (patch release).
Thanks again for taking the time to report this, and to craft such a good issue - it really helps in pushing fixes faster. For reference, this issue was probably caused by Bootstrap 4, where they require the modals to be directly inside the <body> element. Details here https://github.com/Laravel-Backpack/CRUD/commit/192eb8c833b30f2fbedd7705f13ad888b4b02f30 .

@tabacitu thank you for the compliment! If I find anything else I'll let you know! I only recently started usng Backpack and I already like it a lot! Keep up the good work!


Reduce the scope of the Angular UI Bootstrap dependency to only the $modal service

Only require the modal module to use with this component to prevent conflicts with AngularStrap

You're welcome! Thanks for the great component!


Expose CanvasItemEditor and SpatialEditor to GDScript

It would be great to have access to CanvasItemEditor and SpatialEditor from GDScript.
The main usage example I can think of is creating plugins that need to draw to the CanvasItemEditor's viewport (like a TileMapEditor plugin) or to the SpatialEditorViewport (like this grass plugin).
In C++ you would access these viewports this way:
CanvasItemEditor::get_singleton()->get_viewport_control();
SpatialEditor::get_singleton()->get_editor_viewport(0);

But there is no way to access them from GDScript unless you use some crazy tricks like this (which could stop working if the editors child structure changes):

CanvasItemEditor
SpatialEditor

Not critical for the upcoming 2.1, so moving to the next milestone.

@akien-mga I was actually going to try adding this before releasing 2.1 if I had some time. Leaving it like this for now. I will check later :)

Never mind. Exposing the canvas editor viewport is easy, but SpatialEditorViewport may need a better strategy. It may also be good to expose some information about the two editors, like the selected tool mode, etc.
Leaving this for 2.2.

It is really simple to get access to the viewport BTW (works at least for canvas):
var viewport = get_tree().get_edited_scene_root().get_parent()

:smile:

Is this still being worked on?

I'm closing this issue as I'm no longer interested in this feature right now. If anyone is still interested, feel free to open a more detailed proposal in godotengine/godot-proposals. I may make one myself in the future if I regain interest.


modify view

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: babbabb2-6b2b-b436-f312-5e912688e447
Version Independent ID: 33c2333f-9f28-68c3-acb9-17e5df03a0e0
Content: Modify Views - SQL Server
Content Source: docs/relational-databases/views/modify-views.md
Product: sql
Technology: table-view-index
GitHub Login: @stevestein
Microsoft Alias: sstein

@BarisKocaman55 -- thank you for your feedback.  Please provide more context around your issue and task.


filter test failing for --disable-shared builds

On current master, --disable-shared does not seem to turn off filter testing, as it should:
FAIL: tst_filter.sh

+1 Thanks, simple fix, I've got a handful of small assorted sand in the gears to take care of, I'll add this to it.


Size Limit when installing on TFS 2018 Server

Copied from VSMarketplace:
Jeffrey Rempel: How do you install this on a TFS 2018 on-premise server? I try to upload the extension however I get an error stating "The files being added total 35.7 MB which exceeds the maximum total size allowed to be uploaded (25 MB)."

Jeff - great question. I'm not sure how this works for on-premise servers. We had to request an increase in the package size from the marketplace support team in order to publish the extension. They would probably be the best resource to reach out to.

Jeffrey Rempel: I have opened a support case with the Azure DevOps / TFS team. I'll post back here if I get a resolution from them.

SOLVED:
The support team at Microsoft came back with a query that I needed to run on my TFS SQL server in the configuration database. After I ran this I was able to upload the extension.
EXEC dbo.prc_SetRegistryValue @partitionId = 1, @key = '#\Configuration\Service\Gallery\LargeExtensionUpload\MaxPackageSizeMB\', @value = 128, @identityName = null

UPDATE: We were able to update the registry value with the same query mentioned above but this time we did the actual query by logging into the server. The extension is now installed - version <IP_ADDRESS>.
Side note: Before we ran the query we searched for the _key_ parameter (#\Configuration\Service\Gallery\LargeExtensionUpload\MaxPackageSizeMB\) in the configuration DB but it did not show up in the RegistryItems table until after we actually ran the query.

Was a reboot of Azure Devops server required after the configuration change
I have not rebooted and cannot until the weekend, the changes do not seem to have taken effect


Add IE test coverage, make tests portable

Hi @kafene !
This PR brings the following content:

let Git homogenize line endings to make tests portable
add test coverage for MS IE 11 bookmark export

Cheers,
VirtualTam

Thanks again


App Crash on capture

Bug Report
Problem
What is expected to happen?
The camera should open, capture a high-quality photo, and return the captured image URI to the application without causing an out-of-memory (OOM) crash.
What does actually happen?
On a Redmi 9A device, the application crashes right after pressing the capture button in the camera interface, before reaching onActivityResult. The crash log indicates an OOM error.
Information

The crash happens before onActivityResult,, right after pressing the capture button

Log Output:
2024-11-06 11:21:18.432 29632-29784 cr_ChildProcessConn     [APP_NAME]                   W  onServiceDisconnected (crash or killed by oom): pid=29786 bindings:W  S
2024-11-06 11:21:18.671 29632-29632 chromium                [APP_NAME]                   E  [ERROR:aw_browser_terminator.cc(165)] Renderer process (29786) crash detected (code -1).

Command or Code
return new Promise((resolve, reject) => {
            navigator.camera.getPicture(path => {
                Filesystem.resolveUrl(path).then(resolve, reject);
            }, error => {

                if (error === 'No Image Selected'){ return resolve(null); }

                reject(error);
            }, {
                destinationType: Camera.DestinationType.FILE_URI,
                sourceType: Camera.PictureSourceType.CAMERA,
                quality: 100,
                allowEdit: false,
                correctOrientation: true,
                saveToPhotoAlbum: true,
                encodingType: Camera.EncodingType.JPEG,
                mediaType: Camera.MediaType.PICTURE
            });
        }) as unknown as Promise<Entry>;

Environment, Platform, Device

Device: Redmi 9A
Android Version: 10 (MIUI 12.0.17)
Cordova Plugins:

cordova-plugin-camera: ^8.0.0
cordova-plugin-file: ^8.0.1

Platform: Android

Version information

cordova-android: ^13.0.0

Checklist

[x] I searched for existing GitHub issues
[x] I updated all Cordova tooling to most recent version
[x] I included all the necessary information above

Can you share a full stacktrace or logcat logs for your app starting approximately from the getPicture call?
Are you sure that the activity simply isn't being closed (which is an documented behaviour and should be expected)? If this the case, the camera app should work properly and it will write the result to disk. When the camera activity closes and returns to your app, the app's activity needs to be recreated, which means the webview needs to be recreated and reloaded. When this happen the result will be supplied in the resume event.
2024-11-06 11:21:18.432 29632-29784 cr_ChildProcessConn     [APP_NAME]                   W  onServiceDisconnected (crash or killed by oom): pid=29786 bindings:W  S
2024-11-06 11:21:18.671 29632-29632 chromium                [APP_NAME]                   E  [ERROR:aw_browser_terminator.cc(165)] Renderer process (29786) crash detected (code -1).

Could just be a side effect of the activity closing.

Thank you for your response !
I’ve added some extra logging to track the process more closely, especially around the getPicture call. I’m sharing the exported log file as an attachment so you can see the full trace of what’s happening from that point onward. It appears that the activity might indeed be closing, as you mentioned, potentially due to memory constraints.
Xiaomi-M2006C3LG-Android-10_2024-11-07_152402.txt
Let me know if there’s anything specific you’d like me to test or if there’s further information needed.

I'm pretty confident the "crash" is a red herring. It might be triggering the crash callback from the OS killing the activity, even though that's an expected behaviour when working with intents.
While using an intent it's not guaranteed for the app to stop but the OS reserves the right to kill it if it deems it necessary. If you enable the developer options on Android, you can enable the Don't Keep Activities option which will skip whatever logic Android has and always kill the activity when the OS switches to another activity. In android, activity basically refers to an application.
I glanced through the logs and I see:
{
      "header": {
        "logLevel": "DEBUG",
        "pid": 17356,
        "tid": 17356,
        "applicationId": "com.xxx.xxx",
        "processName": "com.xxx.xxx",
        "tag": "CordovaActivity",
        "timestamp": {
          "seconds":<PHONE_NUMBER>,
          "nanos": 918000000
        }
      },
      "message": "Stopped the activity."
    },

Note the timestamp:<PHONE_NUMBER>
Few seconds later:
{
      "header": {
        "logLevel": "ERROR",
        "pid": 17356,
        "tid": 17356,
        "applicationId": "com.xxx.xxx",
        "processName": "com.xxx.xxx",
        "tag": "WebviewCrashesHandler",
        "timestamp": {
          "seconds":<PHONE_NUMBER>,
          "nanos": 360000000
        }
      },
      "message": "La Webview a été tuée par le système"
    },

We see this, but this is to be expected since the activity is stopped and/or stopping.
Fast forward a bit:
{
      "header": {
        "logLevel": "DEBUG",
        "pid": 17356,
        "tid": 17530,
        "applicationId": "com.xxx.xxx",
        "processName": "com.xxx.xxx",
        "tag": "SERVER",
        "timestamp": {
          "seconds":<PHONE_NUMBER>,
          "nanos": 477000000
        }
      },
      "message": "Handling local request: https://kwap/index.html#/home"
    },

here the activity has restarted, since the webview is requesting presumably your home/content src page.
It's a bit hard to visualise what the app is doing from the logcat logs but I suspect that after the picture is taken and accepted, the app does come back to the Cordova webview view, just that perhaps your state has been reset? If so then that's the activity being killed and recreated when the camera's activity is done, and the resume event should have the camera result stored in the resume event.
window.document.addEventListener('resume', (e) => {
    console.log(e.pendingResult);
});

Again this flow can be tested when using the "Don't Keep Activities" developer option in the Android developer settings


Allow to defer removeChild

Currently, there is no way to stop a node from being automatically removed. The motivation to allow to defer this is to make efficient remove animations easier.
I think that the mutator function may return any non-undefined value to prevent removeChild, but I'm not sure what is the best interface to do this.

Decided against this, I don't think it would be good design to allow anything to be asynchronous here. The alternative approach is to clone the node before removing it, which has the side benefit of removing event listeners on the cloned node.

Still undecided. Should leave this open until there is a solution.

Implemented in commit https://github.com/0x8890/simulacra/commit/af32ceeea2ccc7da560f2c51cd8b8f7f4a742355.


Add support for psd and psb files

This support is based on the PSD specification here: http://www.adobe.com/devnet-apps/photoshop/fileformatashtml/

Bump. Would be nice to get off our fork in BC3.

Can I do anything to help this get merged @sstephenson?


Create ufzg.txt

Institution/School Name
The Faculty of Teacher Education
Instiution/School Website
www.ufzg.hr
Email Users
Please place an x between the square brackets if yes

[ *] Students
[*] Academic/Teaching Staff
[ ] Other/Support Staff
[ ] Alumni

Education Levels
Please place an x between the square brackets if yes

[ ] Post-graduate research
[ ] Graduate School
[* ] College (University) or Undergraduate School or equivalent
[*] Community College or equivalent
[ ] High School or equivalent
[ ] Elementary School or equivalent

ufzg.txt

Please add my school


Assembly error after expectEmit

Component
Forge
Have you ensured that all of these are up to date?

[X] Foundry
[X] Foundryup

What version of Foundry are you on?
forge 0.2.0 (56dc746 2022-08-26T00:05:24.870934Z)
What command(s) is the bug in?
forge test
Operating System
macOS (Apple Silicon)
Describe the bug
Assembly operation will fail if they are put after expectEmit while before expectEmit will succeed.

I'm using solidity 0.6.4

Technically it is also before/after CONTRACT.foo() - can you please try removing vm.expectEmit alltogether without moving the assembly block, such that the code is roughly
CONTRACT.foo();
<assembly block>

vm.expectEmit does not modify the bytecode or anything about the EVM in particular, so it is unlikely to be the cause.

Can you provide a minimally runable example? I cannot reproduce this with other assembly blocks, so my guess is still that the assembly block/call is at fault

Hello @onbjerg. I tried to give you a minimally example. But I find when I change the test target contract, this error doesn't show up. I will do more test and reply to you later.

pragma solidity ^0.8.10;

import "forge-std/Test.sol";

contract AssemblyTest is Test {
  address public constant SOME_CONTRACT_ADDR = 0x0000000000000000000000000000000000002001;

  function setUp() public {}

  function testAssembly() public {
    address deployAddr = deployCode("MyContract.sol");
    vm.etch(SOME_CONTRACT_ADDR, deployAddr.code);

    address addr = address(this);
    bytes memory b;
    assembly {
      let m := mload(0x40)
      mstore(add(m, 20), xor(0x140000000000000000000000000000000000000000, addr))
      mstore(0x40, add(m, 52))
      b := m
    }
    emit log_bytes(b);
  }
}

@onbjerg I got the wrong case here

And my foundry version is forge 0.2.0 (084ef3d 2022-09-19T00:04:35.98318Z)

Can you post a call trace/what the error is? That code snippet does not use expectEmit, so my best guess is that it's still something in the assembly block at fault, but it's not immediately clear what you are trying to do.

The error is:
[FAIL. Reason: EvmError: OutOfGas] testAssembly() (gas:<PHONE_NUMBER>854754743)

Yes there's no expectEmit. I misunderstand what cause the error at first.
I'm tying to do here is RLP encoding a address type variable.
Now I think the error is, (maybe) operate the address type in assembly will cause this error(not always, but above is a example).

@onbjerg any idea?><

Now I'm sure the problem lies in vm.etch(). After vm.etch(), the assembly code will fail.

It's not, it's still your assembly block. Commenting out b := m also makes the test pass. The error is that you are assigning to a variable with type bytes, but the layout in memory for this type is [len, item a, item b, ...], and since you are just setting a single slot in memory, it reads the result of your xor as the length of the bytes type. This works:
pragma solidity ^0.8.10;

import "forge-std/Test.sol";

contract AssemblyTest is Test {
  address public constant SOME_CONTRACT_ADDR = 0x0000000000000000000000000000000000002001;

  function setUp() public {}

  function testAssembly() public {
    address deployAddr = deployCode("MyContract.sol");
    vm.etch(SOME_CONTRACT_ADDR, deployAddr.code);

    address addr = address(this);
    bytes memory b;
    assembly {
      // Retrieve memory pointer, assign to `b`
      b := mload(0x40)
      // Store the size in memory of `b` (32 bytes)
      mstore(b, 0x20)
      // Store value
      mstore(add(b, 0x20), xor(0x140000000000000000000000000000000000000000, addr))
      // Increase free memory pointer
      mstore(0x40, add(b, 0x40))
    }
    emit log_bytes(b);
  }
}


Provide a "quit" button

Probably quit with error and quit without error.  Good for testing out restart policy.

Hi all, I think is an Issue I can work on, Any progress on this?

Hello! Any help here would be great!
Between me and you and everyone with access at Github we are looking at doing a second edition of the book at some point and so I'll probably be doing some updates to this.


Calendar DayEventCollection Colors

I want to show on my calendar the 3 dots with this colors:
Colors = [Colors.Orange, Colors.Green, Colors.Red]
but is showing every time on the calendar the first dot as purple, how can i remove the purple one?
My Code:
var threeEventsTommorrow = GenerateEvents(3, "Simple3").ToArray();
var dayEventCollection = new DayEventCollection<EventModel>
{
    Colors = [Colors.Orange, Colors.Green, Colors.Red],
};

foreach (var eventItem in threeEventsTommorrow)
{
    dayEventCollection.Add(eventItem);

}

Events.Add(DateTime.Now.AddDays(1), dayEventCollection);
}

private static IEnumerable<EventModel> GenerateEvents(int count, string name)
{
    return Enumerable.Range(1, count).Select(x => new EventModel
    {
        Description = $"This is {name} event{x}'s description!",
    });
}

Photo:

The color from the first event of a day, right now, is taken from the event itself.
We could add EventColors != null && EventColors.Count >= 1 ? EventColors[ 0 ] :  to DayModel.EventColor to make Colors take precedence if present.


Shortcut conflict

Default shortcuts for control pane is ctrl+space and cmd+space(on Mac) which are both used for IME switch system wide. Could this be changed or at least add a menu for control pane?

If you'd like to map the command bar to a different key in your user.keymap:
;; alt-space can be whatever keybinding
[:app "alt-space" :show-commandbar-transient]

The command bar is available in the menu under View > Commands

@cldwalker  Thanks, I got it!


Pull latest bug fixes from Jet

There are some important bug fixes that were merged to Jet framework recently (Transform bug, for instance). Please take a look at the latest PRs from Jet and pull the fixes if they also exist in this project.

Thanks. I'll check it.

Completed! Thanks! :+1:


TCK: How to test Entity

This issue builds off of https://github.com/jakartaee/data/issues/112
Description
Since we've decided that the API for Entity will remain in the Persistence and NoSQL specs where they will be developed separately.
We still need to figure out a way to write TCK tests that use entities.
This is tricky since we want to be able to test jakarta.nosql.Entity or jakarta.persistence.Entity or both during a single run of the TCK.  I've been trying to think of a few ways to do this with the least amount of duplication possible:
Main roadblock
The main roadblock here is that Entity is an annotation that needs to exist on an object at compile time.
Possible Solutions
Here are some possible solutions that I have thought of, but don't have a complete solution and need help choosing/refining one.
Dual Annotated Entities
Add both Entity annotations for example:
@jakarta.nosql.Entity
@jakarta.persistence.Entity
public class Student {

  @jakarta.nosql.Id
  @jakarta.persistence.Id
  Long id;
}

@Repository
public interface StudentDirectory extends DataRepository<Student, Long> {
    void save(Student student);
    int countByAgeGreaterThanEqual(Integer age);
}

For a standalone repository provider or a Jakarta EE profile that only has a single repository provider, this will work.
However, what happens when studentDirectory.save() is run on a Jakarta EE profile that has both providers?
How can we run the same test against both providers?
Duplicate code
This is a messy but straightforward solution by just duplicating code. For example:
public class Student {
  @jakarta.persistence.Entity
  public static class Persistence { ...  }

  @jakarta.nosql.Entity
  public static class NoSQL { ... }
}

public interface StudentDirectory {
    @Repository
    public interface Persistence extends DataRepository<Student.Persistence, Long> { ... }

	@Repository
	public interface NoSQL extends DataRepository<Student.NoSQL, Long> { ... }

With this solution, we would have to be told by the runner of the TCK which repository(ies) are supported and run based on that input.  This will likely require some more complex Arquillan/Junit logic but should be doable.
Generated source code
Use a pre-compile tool that will automatically generate source code, compile it, and include it in the TCK.
This will require some sort of parser to search for a mock Entity/Id annotations and use that class as a template, for example:
@ee.jakarta.tck.data.anno.Entity
public class Student {

  @@ee.jakarta.tck.data.anno.Id
  Long id;
}

Once parsed two files are created:
@jakarta.nosql.Entity
public class StudentNoSQL { ... }

@jakarta.persistence.Entity
public class StudentPersistance { ... }

The issues with this solution are that it is complicated to implement, it adds complexity that needs to be maintained, and we will have to generate both Entity and Repository classes.  Additionally, at runtime, we will still need to have some method for generating separate applications for both repositories.  Basically, a complex approach to avoid duplicated code.

The last one with the generator sounds a little ickie,
Dual annotated feels a little cleaner.
I recall we used multi-annotations (3 or more) on entities that could be persisted via JPA, JSON (before the Jakarta JSON spec but similar) and through POI even as an Excel sheet.
The approach with two or more embedded entities under the actual object feels rather weird, too.
So IMO 1. sounds best.

My preference would be that we make the TCK look as close to customer code as possible.  I'm fine with duplicating the same entities for Jakarta Persistence and NoSQL.
@jakarta.persistence.Entity
public class Student {
  ...
}

@Repository
public interface StudentDirectory extends DataRepository<Student, Long> {
  ...
}

// Do we need a separate package for these, or can we use the same package but compile 2 separate artifacts, one for NoSQL and one for JPA?
@jakarta.nosql.Entity
public class Student {
  ...
}

@Repository
public interface StudentDirectory extends DataRepository<Student, Long> {
  ...
}

When running the TCK, you would just specify a mode for NoSQL or JPA to tell it which artifact to include in the application so that there is no runtime dependency on the one you aren't using.  The main issue would be over whether we can have both entities and both repositories have the same class and package name (which would be easier for writing the rest of the tests), or whether they will need to be in separate packages to distinguish.

Let's increase the challenge a little more:

It would be fantastic if we could test injecting different DI engine
We must remember that SQL has features that must be clarified to NoSQL.

Maybe the JPA TCK has inspiration for us on this point.

I've been doing some testing:
@keilw - Dual annotation will work for both the Jakarta Profile and Standalone tests.  I've confirmed with the IBM Java team that when Class#getAnnotations()  and Class#getDeclaredAnnotations() are called only annotations that are available to the classloader are returned.  However, we still have the problem of not having a way to ensure a certain repository provider when both are available.
@njr-11 - I looked more into your suggestion of having copies of the entities and a single repository provider.
The problem I've run into is the compilation.  Compilation of these classes will have to happen prior to the distribution of the TCK and there is no way to compile two classes with the same name in the same package.
Therefore these classes need to come from different packages which will have a cascading effect of duplication:

If the entities are in different packages, then we need to duplicate the Repositories.
If the entities are in different packages, then we also need to duplicate tests since we will need to create instances of the entity for testing.
If we duplicate the repositories, we need to figure out a mechanism for looking up the correct repository at runtime.

@otaviojava - Not sure what you mean by  injecting different DI engine.  For Jakarta EE platforms the dependency injection API will be CDI the implementation used is up to the platform, not the TCK.  For the standalone case, we have not defined a provider method for standalone implementations.  Until that is decided we cannot create tests for the standalone case.

I created example PRs for the two leading solutions.
dual annotations vs. duplicate entities

Kyle, thanks for putting together the two examples - it is very helpful. Duplicate entities without the ability to compile two copies of the same class certainly ends up being messy and no longer matches how a customer would write code.  Dual annotations is much cleaner.  If you've solved the concern there about unavailablility of classes at runtime, the other issue that will come up is that the TCK becomes vulnerable to challenges that its entities (and thus tests that use them) aren't valid because they have both sets of annotations on them and the spec doesn't require providers to support that.  If we are going to write the TCK to depend on do dual annotations, we need to be willing to put language explicitly into the Jakarta Data specification stating that dual annotations must be allowed to ensure the TCK is valid.  We should discuss this topic more on tomorrow's call.

This has been resolved with the merge of #120


website blocker using python

Pull Request Template
script name - website blocker
What have you Changed
what you changed in the codebase.write here
Issue no.(must) - #333
Self Check(Tick After Making pull Request)

[ ] This issue was assigned to me.
[x] One Change in one Pull Request
[x] My file is in proper folder
[x] I am following clean code and Documentation and my code is well linted with flake8.
[ ] I have added README.md and requirements.txt with my script

If issue was not assigned to you Please don't make a PR. It will marked as invalid.
Join Us on Discord:- https://discord.gg/JfbK3bS
acknowledgement

[x] I have tested the script and distributing it under MIT license.

why it is getting failed remark

correct your code according to flake8 standards. Check flake8 documentation.
you can check error by clicking on details or you can download flake8 via pip locally.

Alright, your codes passed the flake8 standards. But still, you have to change some basic things.

[ ] your script should be in the separate folder not in the root directory.
[ ] there should be a README for the script introduction and usages.

You can check all the steps here
thanks for having patience

inactive PR. It will be close in 2 days if there will be no response.
@Mr-Mishraji


scala 2.12 artifact

To make this project alive it is required to have build for scala 2.12
Thanks.

I've created a release from my fork: https://github.com/Philippus/base64
I'd recommend to just migrate to the Java 8 encoder available in java.util.Base64 though.


account for default value of @colspan and @rowspan attributes

The LegalDocML schema specifies a default value for a table cell's @colspan and @rowspan attributes. (That default value is 1, of course.) See line 1630 of the schema:
<xsd:attribute name="colspan" type="xsd:integer" default="1"/>

Now that we have associated documents with the schema, MarkLogic effectively adds attributes with this value at the time the XSLTs are run. Therefore, if a cell has no @colspan attribute in the XML, a test in an XSLT for the absence of this attribute will now be false, although it would have been true before the schema association. The transform had not accounted for this, but with this fix it now does.
Our XML contains no @colspan or @rolspan attribute when their value would be 1. The test in the current transform for the absence of these attributes is replaced with a new function, which returns true if any of the following is true: the attribute is missing, the attribute is empty, the attribute has a value of 1.

Thank you for the detailed message :)
Yet again, having a schema changes the interpretation of the XML in minor, subtle ways...


Deprecate do_send

This causes the integration tests to run against quicksend (wrapped by send).   I get 26 test fails.  I am looking into them now.

This now deletes do_send and do_shield.


Randoms HTTP errors : 504 Gateway timeout

Whatever i'm doing, there is no way to fix thoses errors ...
Traceback (most recent call last):
File "/usr/local/lib/python3.5/site-packages/discord/client.py", line 307, in _run_event
yield from getattr(self, event)(*args, **kwargs)
File "UsoDiscord.py", line 325, in on_ready
update_stats.update_all_stats(conn, cursor)
File "/root/UsoBot/update_stats.py", line 107, in update_all_stats
update_stats(0, conn, api, osuId = osu_id[0])
File "/root/UsoBot/update_stats.py", line 51, in update_stats
apiResults = api.get_user_best(osuId, limit = scores)
File "/usr/local/lib/python3.5/site-packages/osuapi-0.0.15-py3.5.egg/osuapi/osu.py", line 71, in get_user_best
), JsonList(SoloScore))
File "/usr/local/lib/python3.5/site-packages/osuapi-0.0.15-py3.5.egg/osuapi/osu.py", line 34, in _make_req
return self.connector.processrequest(endpoint, {k: v for k, v in data.items() if v is not None}, type)
File "/usr/local/lib/python3.5/site-packages/osuapi-0.0.15-py3.5.egg/osuapi/connectors.py", line 77, in process_request
raise HTTPError(resp.status_code, resp.reason, resp.text)
osuapi.errors.HTTPError: (504, 'Gateway Time-out',

This error means that the osu api is down/not responding.
I was thinking of adding some retry logic, since this can be annoying. Not how often retrying on 504 is successful or not, but worth a shot.

Testing a change for this on my bot, which sees 504s 2-4 times a day on average, then I'll push a release.

Added in 0.0.19, we will now retry up to 5 times (by default) when we get 504.


RecordedFutureConnectorV2 Update

Required items, please complete
Change(s):

Updated all RecordedFuture playbooks to use new recordedfutureV2 powerplatform connector
Added new individual and solution playbook for Russia/Ukraine conflict Threat detection.
Improved documentation about dependencies between playbooks.

Reason for Change(s):

Updated to use V2 of PowerPlatform connector
Addition of Russia/Ukraine playbooks

Version Updated:

Solution 2.1.0

Testing Completed:

Yes, Solution mainTemplate custom deployment and UISandbox tested. Individual playbooks tested as custom deployment.

Checked that the validations are passing and have addressed any issues that are present:

Yes

Hi @devikamehra
Can you please review playbooks and provide your feedback.
Thanks

Hi @manishkumar1991,
Could you please review the playbook changes and provide your feedback.
Thanks

The playbooks that are updated in this release were created in 2020 well before the generator existed. I'll give the tool a try and regenerate all playbooks and solution

Hi @RecordedFutureOskbo,
Thanks for the prompt response. Please try generating with tool and let us know if you need any help over there.
Thanks

Hi @RecordedFutureOskbo,
I hope you have started working on it. Please let us know if you need any kind of help in the Playbook preparation and packaging.
Thanks

Yes Im halfway in, I have to diff each Playbook and manual apply lots of small things like in this file.
RecordedFuture_Generic_Detection_IndicatorProcessor.json

We have Logic apps calling other logic apps. The generated json contains hardcoded TenantID and id contains hardcoded subscriptionId. That I have to exchange to variabler like this
"id": "/subscriptions/{GUID}/resourceGroups/OskarFree/providers/Microsoft.Logic/workflows/RecordedFuture_Generic_Detection_ImportToSentinel"
to
"id": "[concat('/subscriptions/', subscription().subscriptionId, '/resourceGroups/', resourceGroup().name, '/providers/Microsoft.Logic/workflows/', parameters('PlaybookNameBatching'))]"

Also the parameter parameters('PlaybookNameBatching')  is removed in the generated result.

Hi @RecordedFutureOskbo,
Let us know if you need any help over there.
Thanks

@microsoft-github-policy-service agree [company="Recorded Future"]

@microsoft-github-policy-service agree company="Recorded Future"

@v-mchatla @manishkumar1991 We are ready for review again. I have regenerated the playbooks using the e generator tool and retested them again.

@RecordedFutureOskbo - Thanks for the update.
@manishkumar1991 - Author has addressed your comments. can you please review and provide your feedback.
Thanks

Hi @manishkumar1991,
Can you please review the changes and provide your feedback.
Thanks

Hi @manishkumar1991,
It would be great if you can review and provide your sign off.
Thanks

@RecordedFutureOskbo I can see that there are playbooks outside the solution and inside the solution as well, any specific reason on this ?

We kept the once outside the solution for legacy purposes. We have customers that installed playbooks one by one from GitHub. Do you advise us to go forward with solution playbooks only? Since it's possible to install them one by one also, we can do that as a separate PR.

Hi @manishkumar1991,
Can you please review the changes and provide your feedback.
Thanks

Hi @manishkumar1991,
Can you please review and provide your feedback.
Thanks

@rahul0216, I would like to do the move/delete of playbooks from playbook folder to solution as a separate PR if that is ok?
I have done an overhauled of all prerequisitesDeployTemplateFile and postDeployment and added correct entities to all enrichment playbooks.

@RecordedFutureOskbo
Looks like you already created a separate PR for removal of playbooks from Playbook folder. Let me know one it is ready for review.

@rahul0216 I will tag you in a PR for moving/removing playbooks into solutions.

Hi @rahul0216,
We can only close this PR once the other draft PR merged or can we merge it?

Hi @rahul0216,
We can only close this PR once the other draft PR merged or can we merge it?

@rahul0216, @v-mchatla please merge this PR first to avoid merge conflicts. It will make testing on our side easier. Otherwise we have to update and retest this PR again.


Rename warp mouse functions to warp_mouse

Implements https://github.com/godotengine/godot/issues/54161#issuecomment-1079743838

For consistency, I'd suggest renaming to/p_to to position/p_position.

Good idea, I have changed that.

Thanks!


Always keep EEG data in Volts instead of converting to mV

PR Description
This PR removes a bunch of unnecessary conversions back and forth between Volts and mV, likewise changing the units for a few user-facing EEG attributes (e.g. self.EEG_before_interpolation) in PrepPipeline from the EEGLAB standard of mV to the MNE standard of volts.
This should make the API less confusing for people used to working in the MNE world, avoid a bunch of unnecessary large matrix multiplication, and makes some other proposed API changes in #99 easier to implement.
Merge Checklist

[x] the PR has been reviewed and all comments are resolved
[x] all CI checks pass
[ ] (if applicable): the PR description includes the phrase closes #<issue-number> to automatically close an issue
[ ] (if applicable): bug fixes, new features, or API changes are documented in whats_new.rst

Codecov Report

Merging #102 (8fe116a) into master (7ad292c) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #102      +/-   ##
==========================================
- Coverage   99.04%   99.04%   -0.01%
==========================================
  Files           7        7
  Lines         736      734       -2
==========================================
- Hits          729      727       -2
  Misses          7        7

Impacted Files
Coverage Δ

pyprep/prep_pipeline.py
100.00% <100.00%> (ø)

pyprep/reference.py
99.18% <100.00%> (-0.02%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ad292c...8fe116a. Read the comment docs.

Thanks @a-hurst!


TFLITE does not compile with CMake in Visual Studio 2019

Issue type
Bug
Have you reproduced the bug with TensorFlow Nightly?
Yes
Source
source
TensorFlow version
tf-master
Custom code
Yes
OS platform and distribution
Windows 7 SP1 x64
Mobile device
No response
Python version
3.11
Bazel version
No response
GCC/compiler version
No response
CUDA/cuDNN version
No response
GPU model and memory
NVIDIA GeForce 1660 SUPER 6 GB
Current behavior?
Cannot find #include <sys/mman.h> in "tensorflow/lite/kernels/internal/optimized/fully_connected_4bit.h"
Expected successful build.
P.S. There's TFLITE_MMAP_DISABLED condition in this file, but I didn't find it in CMakeLists.txt or anywhere else (except Bazel config files that are not used while building with CMake).
Standalone code to reproduce the issue
1. Open latest VS 2019 on 64-bit Windows 7 (maybe newer versions too).
2. Download tensorflow-master as zip, unpack.
3. Open tensoflow/lite as CMake project.
4. Right click on root CMakeLists.txt and choose "Build".

Relevant log output
Cannot find #include <sys/mman.h> in "tensorflow/lite/kernels/internal/optimized/fully_connected_4bit.h"

Just hit same issue.
You can try injecting the pre-processor defn straight through by putting it in the cxx flags default value...
cmake -E env CXXFLAGS="/DTFLITE_MMAP_DISABLED" cmake ..

Just hit same issue.
You can try injecting the pre-processor defn straight through by putting it in the cxx flags default value...
cmake -E env CXXFLAGS="/DTFLITE_MMAP_DISABLED" cmake ..

Hello! Thank you very much, but I hope this case will be handled automatically once the bug is fixed)

Hi, @MVoloshin
Thanks for raising this issue. Are you aware of the migration to LiteRT? This transition is aimed at enhancing our project's capabilities and providing improved support and focus for our users. As we believe this issue is still relevant to LiteRT we are moving your issue there. Please follow progress here: https://github.com/google-ai-edge/LiteRT/issues/101
Let us know if you have any questions. Thanks.