Multiarch image spitting error on ppc64le

Issues and Contributing
Please note that only issues related to this Docker image will be addressed here.

If you have Docker related issues, please ask in the Docker user mailing list.
If you have Jenkins related issues, please ask in the Jenkins mailing lists.
If you are not sure, then this is probably not the place to create an issue and you should use any of the previously mentioned mailing lists.

If after going through the previous checklist you still think you should create an issue here please provide:
Docker commands that you execute
docker pull jenkins/jenkins:lts
docker run -p 8080:8080 -p 50000:50000 jenkins/jenkins:lts
This is on a ppc64le machine
Actual result
panic: standard_init_linux.go:178: exec user process caused "exec format error" [recovered]
panic: standard_init_linux.go:178: exec user process caused "exec format error"
goroutine 1 [running, locked to thread]:
panic(0x103ebf80, 0xc820165d50)
/usr/lib/go-1.6/src/runtime/panic.go:481 +0x3a0
github.com/opencontainers/runc/vendor/github.com/urfave/cli.HandleAction.func1(0xc820113278)
/build/runc-F1mGRW/runc-1.0.0~rc2+docker1.12.6/_build/src/github.com/opencontainers/runc/vendor/github.com/urfave/cli/app.go:478 +0x364
panic(0x103ebf80, 0xc820165d50)
/usr/lib/go-1.6/src/runtime/panic.go:443 +0x4c4
github.com/opencontainers/runc/libcontainer.(*LinuxFactory).StartInitialization.func1(0xc820112af8, 0xc82001a088, 0xc820112c20)
/build/runc-F1mGRW/runc-1.0.0~rc2+docker1.12.6/_build/src/github.com/opencontainers/runc/libcontainer/factory_linux.go:259 +0x184
github.com/opencontainers/runc/libcontainer.(*LinuxFactory).StartInitialization(0xc8200587d0, 0x3fffa93454b8, 0xc820165d50)
/build/runc-F1mGRW/runc-1.0.0~rc2+docker1.12.6/_build/src/github.com/opencontainers/runc/libcontainer/factory_linux.go:277 +0x504
main.glob.func8(0xc820078780, 0x0, 0x0)
/build/runc-F1mGRW/runc-1.0.0~rc2+docker1.12.6/_build/src/github.com/opencontainers/runc/main_unix.go:26 +0x68
reflect.Value.call(0x10351560, 0x10501ea0, 0x13, 0x104486c8, 0x4, 0xc8201131e0, 0x1, 0x1, 0x0, 0x0, ...)
/usr/lib/go-1.6/src/reflect/value.go:435 +0xe54
reflect.Value.Call(0x10351560, 0x10501ea0, 0x13, 0xc8201131e0, 0x1, 0x1, 0x0, 0x0, 0x0)
/usr/lib/go-1.6/src/reflect/value.go:303 +0x94
github.com/opencontainers/runc/vendor/github.com/urfave/cli.HandleAction(0x10351560, 0x10501ea0, 0xc820078780, 0x0, 0x0)
/build/runc-F1mGRW/runc-1.0.0~rc2+docker1.12.6/_build/src/github.com/opencontainers/runc/vendor/github.com/urfave/cli/app.go:487 +0x268
github.com/opencontainers/runc/vendor/github.com/urfave/cli.Command.Run(0x1044b4d8, 0x4, 0x0, 0x0, 0x0, 0x0, 0x0, 0x104e0b40, 0x51, 0x0, ...)
/build/runc-F1mGRW/runc-1.0.0~rc2+docker1.12.6/_build/src/github.com/opencontainers/runc/vendor/github.com/urfave/cli/command.go:191 +0xdf0
github.com/opencontainers/runc/vendor/github.com/urfave/cli.(*App).Run(0xc820001980, 0xc82000a100, 0x2, 0x2, 0x0, 0x0)
/build/runc-F1mGRW/runc-1.0.0~rc2+docker1.12.6/_build/src/github.com/opencontainers/runc/vendor/github.com/urfave/cli/app.go:240 +0x968
main.main()
/build/runc-F1mGRW/runc-1.0.0~rc2+docker1.12.6/_build/src/github.com/opencontainers/runc/main.go:137 +0xca0
Expected outcome
The docker image starts jenkins on specified port
Have you tried a non-dockerized Jenkins and get the expected outcome?

I don't have access to a ppc, can you try these commands from the container?
docker run -ti --rm --entrypoint /bin/bash jenkins/jenkins:latest
/bin/tini
/sbin/tini
/usr/local/bin/jenkins.sh

The first command fails (ie starting the container), it gives the "exec format error" (same as the detailed message above in the issue description)

test@pts00449-vm9:~/vaibhav/breakpad/src$ docker run -ti --rm --entrypoint /bin/bash jenkins/jenkins:latest /bin/tini

panic: standard_init_linux.go:178: exec user process caused "exec format error" [recovered]
panic: standard_init_linux.go:178: exec user process caused "exec format error"
goroutine 1 [running, locked to thread]:
panic(0x103ebf80, 0xc82015c000)
/usr/lib/go-1.6/src/runtime/panic.go:481 +0x3a0
github.com/opencontainers/runc/vendor/github.com/urfave/cli.HandleAction.func1(0xc8200f7278)
/build/runc-F1mGRW/runc-1.0.0~rc2+docker1.12.6/_build/src/github.com/opencontainers/runc/vendor/github.com/urfave/cli/app.go:478 +0x364
panic(0x103ebf80, 0xc82015c000)
/usr/lib/go-1.6/src/runtime/panic.go:443 +0x4c4
github.com/opencontainers/runc/libcontainer.(*LinuxFactory).StartInitialization.func1(0xc8200f6af8, 0xc82001a0b8, 0xc8200f6c20)
/build/runc-F1mGRW/runc-1.0.0~rc2+docker1.12.6/_build/src/github.com/opencontainers/runc/libcontainer/factory_linux.go:259 +0x184
github.com/opencontainers/runc/libcontainer.(*LinuxFactory).StartInitialization(0xc820059590, 0x3fff843756e0, 0xc82015c000)
/build/runc-F1mGRW/runc-1.0.0~rc2+docker1.12.6/_build/src/github.com/opencontainers/runc/libcontainer/factory_linux.go:277 +0x504
main.glob.func8(0xc820078a00, 0x0, 0x0)
/build/runc-F1mGRW/runc-1.0.0~rc2+docker1.12.6/_build/src/github.com/opencontainers/runc/main_unix.go:26 +0x68
reflect.Value.call(0x10351560, 0x10501ea0, 0x13, 0x104486c8, 0x4, 0xc8200f71e0, 0x1, 0x1, 0x0, 0x0, ...)
/usr/lib/go-1.6/src/reflect/value.go:435 +0xe54
reflect.Value.Call(0x10351560, 0x10501ea0, 0x13, 0xc8200f71e0, 0x1, 0x1, 0x0, 0x0, 0x0)
/usr/lib/go-1.6/src/reflect/value.go:303 +0x94
github.com/opencontainers/runc/vendor/github.com/urfave/cli.HandleAction(0x10351560, 0x10501ea0, 0xc820078a00, 0x0, 0x0)
/build/runc-F1mGRW/runc-1.0.0~rc2+docker1.12.6/_build/src/github.com/opencontainers/runc/vendor/github.com/urfave/cli/app.go:487 +0x268
github.com/opencontainers/runc/vendor/github.com/urfave/cli.Command.Run(0x1044b4d8, 0x4, 0x0, 0x0, 0x0, 0x0, 0x0, 0x104e0b40, 0x51, 0x0, ...)
/build/runc-F1mGRW/runc-1.0.0~rc2+docker1.12.6/_build/src/github.com/opencontainers/runc/vendor/github.com/urfave/cli/command.go:191 +0xdf0
github.com/opencontainers/runc/vendor/github.com/urfave/cli.(*App).Run(0xc820001800, 0xc82000a100, 0x2, 0x2, 0x0, 0x0)
/build/runc-F1mGRW/runc-1.0.0~rc2+docker1.12.6/_build/src/github.com/opencontainers/runc/vendor/github.com/urfave/cli/app.go:240 +0x968
main.main()
/build/runc-F1mGRW/runc-1.0.0~rc2+docker1.12.6/_build/src/github.com/opencontainers/runc/main.go:137 +0xca0

are you running them in the same line?
 I ran the /bin/tini etc commands inside them, all of them give 'command not found' as below:
test@pts00449-vm9:~/Downloads/idea-IC-173.4548.28$ docker run -ti --rm --entrypoint /bin/sh openjdk:8-jdk-slim
Unable to find image 'openjdk:8-jdk-slim' locally
8-jdk-slim: Pulling from library/openjdk
07a374cd4a95: Pull complete
6db1eeca3bf1: Pull complete
ffa77403ca9a: Pull complete
3cfac90f183e: Pull complete
1db0b5c0c56a: Pull complete
6d4fb7130a5c: Pull complete
Digest: sha256:bd394fdc76e8aa73adba2a7547fcb6cde3281f70d6b3cae6fa62ef1fbde327e3
Status: Downloaded newer image for openjdk:8-jdk-slim
/bin/tini
/bin/sh: 1: /bin/tini: not found
/sbin/tini
/bin/sh: 2: /sbin/tini: not found
/usr/local/bin/jenkins.sh
/bin/sh: 4: /usr/local/bin/jenkins.sh: not found`

doh! sorry, I was confusing this image with another one I maintain maven
The jenkins/jenkins image published to dockerhub has no support for multiarch, you can build your image in ppc and it should work, that's what #579 enabled. But the jenkins project is not building/publishing those

no prob, thanks for the update!
A quick ques, are there any future plans to publish jenkins multi-arch images to dockerhub?
we plan to use the jenkins docker image on ppc64le and so it would be nice if it was directly available via a 'docker pull'
I believe docker has the official images program which can help to do that as you might be aware but i also see that the official jenkins image has been deprecated there & hosted under jenkins/jenkins, so would like to know whats the plan for this going forward? thanks!

No plans yet. Official images have other problems because require manual intervention to publish, that's why it was deprecated

@carlossg I am interested in building an image for ppc64le. However, simply building an image locally using the Dockerfile in this repo. gives me version 2.60.3, how can I build an image for LTS release?
Any pointers would be of great help ..!!

you need to pass the docker build args JENKINS_VERSION and JENKINS_SHA

PR #750 is created to add multi-arch docker image publish in the job so that it runs as part of trusted CI process.

We're now publishing arm64, ppc64le and s390x images
See tags on dockerhub:
https://hub.docker.com/r/jenkins/jenkins/tags?page=1&ordering=last_updated
Please raise a new issue if any problems with it


[WIP] Mutable closures for anonymous functions

Note: This is not ready for merging. I keep actively working on this feature, but would like to share a work-in-progress to hear some feedback, and to keep you in touch with the code changes since the final PR going to be quite large.
I will sync my branch with original master from time to time, so you don't need to care about my changes until they merged to upstream. But if the original master would be not too breakable that would save me time of rebasing/merging conflicts resolutions in my branch  :)
Summary
Collecting all variable access attempts in anonymous function body during parsing for variables that are not explicitly declared(through the let keyword) considering that they are "closures" candidates and prepend them to the function's argument list(implicitly). Then implicitly curry these arguments in place in the parent context with the parent's context scope propagating this arguments the same way to the ancestors contexts recursively. In the end turn all let declarations affected by curried closures to become runtime-sharable Dynamic instances(through Arc<RwLock<Dynamic>>/Rc<RefCell<Dynamic>> depending on the sync feature).
The final goal is having a syntax like this:
let x = 100;

let func_1 = |z| {
  let y = 200;

  let func2 = || x + y + z;

  return func2.call();
};

|| {x = 50}.call();

func_1.call(30); // returns 280

Implementation details

[x] Implement collecting of the closure candidates inside anon function body and curry them in place in the parent's context. This is done through extending of the ParseState object. The object is now holding a externals: &'s mut Vec<String> field that is enriching every time the parser detects variable access expression. I replaced ParserState::find_var with ParserState::access_var function that does the work of collecting under the hood. Once the parser finishes Parser::parse_anon_fn work it optionally enriches function's parameters and turns resulting expression(FnCall) to curry call expression depending on the current ParserState::externals list. And then propagates curried arguments to the parent context through the ParserState::access_var. This feature can be opted-out completely using a new no_closures feature.
[x] Introduce a new Dynamic's Union variant called Shared that holds Arc<RwLock<Dynamic>> or Rc<RefCell> (depending on the sync feature enabled). This variant can be created through the new Dynamic::into_shared function that ensures that the end-user doesn't wrap Shared into Shared multiple times. Since we need transparent interoperability between all Dynamic instances, but the RwLock/RefCell normally requiring read-write lock guards(RwLockReadGuard/Ref and RwLockWriteGuard/RefMut) instead of a normal & &mut references I had to change the Dynamic access interface by turning downcast_ref and downcast_mut to private and providing two new methods Dynamic::read_lock and Dynamic::write_lock that return DynamicReadLock and DynamicWriteLock lifetime-bound instances accordingly with impl Deref/impl DeefMut implementations for transparent access of underlying references. For normal Dynamic instances these objects just hold the same references as downcast_ref and downcast_mut would normally return and don't produce much overhead in contrast to prior API version. For Shared Dynamic they hold underlying appropriate RwLock/RefCell guards and return a result of downcast_ref/downcast_mut applying on underlying Dynamic once deref()/deref_mut is called. This item is a breakable change.
[x] Replace all downcast_ref/downcast_mut occurrences with the read_lock/write_lock functions accordingly including fn_register macros.
[x] Introduce a new shared built-in Rhai-script function that turns any expression's result into Shared Dynamic. This is done by introducing a new KEYWORD_SHARED. This feature can be opted out with the new feature no_shared, so the user will not be able to create Shared Dynamic explicitly.
[ ] Improve Engine such that it can interpret Shared Dynamic operands in left-hand-side properly by mutating underlying data instead of introducing copies to the current scope Scope. This is partially done, but I still have difficulties with call-chains and indexing-access syntax due to issues in introducing of DynamicReadLock and DynamicWriteLock to the Target variant since these instances are lifetime-bound to original Shared Dynamic. Perhaps, it will require a lot of work inside the Engine's expression interpreter.
[ ] Use ParserState::externals information to implicitly turn all let x = expr; occurrences into let x = shared(expr); so that implicitly curry-ed variables will become mutable closures transparently for the script user. Difficulties: The information required for this turning is already gathering by the Parser, but I'm not quite sure how to change already constructed AST nodes. Perhaps, I can put a mutable bool flag(how? through the Mutext/RefCell?) to each Stmt::Let node to change it afterwards that the Engine will use to apply Dynamic::into_shared.
[ ] Provide appropriate tests and put according changes to the Rhai Book. Rust-doc comments already provided for the new API functions.

@schungx Would like to hear your opinion. Maybe it would be reasonable to split this work into two PRs? The base infrastructure neede for this feature is already provided in this PR. If I fix tests(some of them are currently broken for a reason) we can merge it first, and then I will implement the rest of the work in separate PR. What do you think?

Thanks for the work!
Why don't I open up a new branch for you in my repo https://github.com/schungx/rhai and you can sync to that instead.
This way, I can make sure that I keep that branch in sync whenever I do some house cleaning on the master branch, and you won't get a godzillion merge conflicts.

Use ParserState::externals information to implicitly turn all let x = expr; occurrences into let x = shared(expr); so that implicitly curry-ed variables will become mutable closures transparently for the script user. Difficulties: The information required for this turning is already gathering by the Parser, but I'm not quite sure how to change already constructed AST nodes. Perhaps, I can put a mutable bool flag(how? through the Mutext/RefCell?) to each Stmt::Let node to change it afterwards that the Engine will use to apply Dynamic::into_shared.

Well, the parser keeps a state, which contains a stack of variable names.  It uses this to turn named variable access into a straight offset index.  For what you want to do, you might maintain a link between this variables stack and the corresponding Stmt::Let or Stmt::Const.  Then at the end of parsing, we run an extra pass over all the statements and fix up all the statements.  This can be done before the optimization pass, which does things in essentially the same manner.

Alternatively, we just handle this in a different manner:
We introduce a new keyword, shared, that directly declares a variable as shared.  E.g.:
let shared x = 42;
let y = 123;

let f = |z| x += z;    // captures 'x'
let f = |z| y += z;    // 'y' is not captured

Then we can just add a Arc<RwLock<T>> / Rc<RefCell<T>> variant to Dynamic which will also solve the problem @jhwgh1968 is having in his plugins work.  See this PR https://github.com/schungx/rhai/pull/14

@schungx Thank you for review!
Honestly, in the beginning I thought it would be easier to implement shareable scope state then it appears to be when I start digging deeper inside the code.
The primary problem with wrapping Arc<RwLock<?>>/``Rc<RefCell<?>>inside Dynamic is interoperability with other variants ofDynamic, and that issue lies down the Rust inconsistency between RwLock/RefCell access that is happening in runtime and the normal Rust static types borrowing that is checking in compile time. This issue raises a lot of questions when we are dealing with downcast_ref/downcast_mut which are strongly depend on the static lifetimes checking. We can't just leak the references of inner data laying inside RwLock or RefCell. They require to create explicit access guards creation(Ref/RefMutandRwLockReadGuard/RwLockWriteGuard` accordingly) that mimic rust's borrowing rules in runtime. So there is actually no way to simply deference these containers inside downcast_ref/mut and return a reference to it, because the references that we are obtaining from their guard objects are depending to the lifetime of the guards themselves that we have to crate somewhere to do this dereference.
That was the primary reason to alter the public API of Dynamic object. Otherwise we will not be able to work with RwLock/RefCell data transparently in Rhai scripts. The following code wouldn't be possible without guards<->static-references interoperability:
let x = shared(100);
x = 200;

Because for Rhai the object created within shared would be different to the usual Dynamic<Unit<INT>>.

@schungx To sum up, I'm not sure if it's a good time for such API alteration, but sooner or later we will have to do something like this if we want to introduce shareable state into Rhai. Maybe there is a better approach, not I don't know :)
Anyway... For now I can propose a smaller scope of this Pull Request that will just automatically grab closures from the outer context without the way of mutating them in the anon function body. That is something I actually already done in the current PR, so I can create a separate PR with the smaller scope. And we will decide what to do with the Shared Dynamics later. What do you think?

Well, I wouldn't suggest giving up so easily...
There may not be too many places in the code that requires deferencing a &mut to a Dynamic.  And if you look at the Target type, it is there for exactly that reason.
For example, Target can hold a reference to a character inside a string.  They way it does that is to hold both the string itself, the character, and the index.  Target takes the place of a normal &mut reference to the object that is mutable.  For everything else, values are passed as copies so just cloning the Rc/Arc is just fine.
The attack plan is to:

Add Dynamic(Union::Shared(x)) variant.
Dynamic::downcast_ref and Dynamic::downcast_mut will only succeed on the lock guard object types.
Or, we redirect all calls to Dynamic::downcast_ref and Dynamic::downcast_mut to lock_read/lock_write when it is a shared.
Make a variant of Target that internally holds a lock guard.

This way, you can splice in a reference-counted, locked object just like it is another data type.

Anyway... For now I can propose a smaller scope of this Pull Request that will just automatically grab closures from the outer context without the way of mutating them in the anon function body. That is something I actually already done in the current PR, so I can create a separate PR with the smaller scope. And we will decide what to do with the Shared Dynamics later. What do you think?

Yeah, I think that might be a good idea.
You want me to create a new branch closures for you in my repo?  I diligently make sure these branches are synced with master as much as possible.

You want me to create a new branch closures for you in my repo?

Yes, please create a new branch, I will cherry-pick all stuff from my branch related to Parser changes only and prepare a few tests, so we can merge it separately. And then I will try to work on a Shared Dynamics in more proper way as you suggested.
Thanks!

BTW, after some more thoughts, I realize that Dynamic::downcast_ref and Dynamic::downcast_mut are not used anywhere in the Engine - they are mostly used when interfacing with external functions.
Therefore, it may not be too bad to replace them with lock_read and lock_write.
The only think I would suggest change is to make the wrapped value a simple dyn Any, instead of having it be yet another Dynamic.  Yes, it would be an additional redirection for simple primary types, but with the overhead of reference counting and locks, I believe this is acceptable.  This should simplify the the type much more, and you don't get into recursive chains of locks within locks etc.

OK there is now a closures branch in my repo.

Per discussion above I'm closing this PR and moving it's commits to separated PRs:
https://github.com/schungx/rhai/pull/19
https://github.com/schungx/rhai/pull/20


Always use playstore url.

The previous check and logic would crash on emulators with google APIs.

Can you provide more context about the crash? What's the stacktrace?
Using a http url means that the user gets a prompt between Chrome and Play Store, right? That's not great.

Here is the stack trace:
                  Process: com.example.hellocharge, PID: 2589
                  android.content.ActivityNotFoundException: No Activity found to handle Intent { act=android.intent.action.VIEW dat=market://details?id=com.squareup flg=0x10080000 }
                      at android.app.Instrumentation.checkStartActivityResult(Instrumentation.java:1809)
                      at android.app.Instrumentation.execStartActivity(Instrumentation.java:1523)
                      at android.app.ContextImpl.startActivity(ContextImpl.java:791)
                      at android.app.ContextImpl.startActivity(ContextImpl.java:768)
                      at android.content.ContextWrapper.startActivity(ContextWrapper.java:356)
                      at com.squareup.sdk.register.RealRegisterClient.openRegisterPlayStoreListing(RealRegisterClient.java:98)
                      at com.example.hellocharge.HelloChargeActivity$2.onClick(HelloChargeActivity.java:97)
                      at android.support.v7.app.AlertController$ButtonHandler.handleMessage(AlertController.java:157)
                      at android.os.Handler.dispatchMessage(Handler.java:102)
                      at android.os.Looper.loop(Looper.java:154)
                      at android.app.ActivityThread.main(ActivityThread.java:6119)
                      at java.lang.reflect.Method.invoke(Native Method)
                      at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:886)
                      at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:776)

Woudl it be better to catch the ActivityNotFoundException and then send them to chrome?

Cool. We definitely don't want to get rid of the market URL, but instead we can add an extra "can I use this intent" check.

The Play Store intercepts urls so there's no reason to use the market://
URI first.
On Thu, Dec 22, 2016 at 10:04 AM Pierre-Yves Ricau<EMAIL_ADDRESS>wrote:
Cool. We definitely don't want to get rid of the market URL, but instead we
can add an extra "can I use this intent" check.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/square/register-android-sdk/pull/21#issuecomment-268817748,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAEEEbD6UO8VE30fLRQEIzKWR7I-UA_7ks5rKpGHgaJpZM4LIkt5
.

AFAIK all http schemes trigger a chooser intent between the browser and registered apps. This might have changed in recent Android versions (especially with App Link), but we're supporting down to 15 here, so I'm not sure if that's safe.

FWIW, I always Intent.setPackage("com.android.vending") to be safe when directing to the Play Store.


Fix/add qr and agreements to db seed

I did the following things:

Qr-Codes pictures in the Boxtribute repo should work
add transfer Agreement Data to the seeds to have data to show in AgreementsOverview
add shipment data to the seed  to have data to show in ShipmentOverview
add users to each user group in boxcare to more easily test transfer agreement/shipment actions

 align db seed of dropapp and v2. Qr-Codes pictures in the repo are not in the db seed in the new app #sprint-jan-30

@HaGuesto Also I'd like to understand how these new values were generated and whether one must be careful in the future when creating a dump from the staging DB and using it as the seed for the dev DB.

@pylipp This is ready to review again.


Have you ever tried self-supervised training

Hi,I also graduated from xjtu.Nice to meet you here.
Have you ever tried self-supervised training and how about the results.
Thank you.
If convenient, can I get your wechat?
Here is my<EMAIL_ADDRESS>

Hi, @yinhanxi，nice to meet you too!
I haven't tried self-supervised learning on the KITTI dataset.
One of the other works, Self-Supervised Depth Completion via Adaptive Sampling and Relative Consistency, explores self-supervised training on some indoor datasets, which is also based on our MSG-CHN architecture.
However, the pattern of the sparse depth for indoor data is quite different from that of KITTI Lidar data. So I am not very sure about the self-supervised results on KITTI.

Hi, @yinhanxi，nice to meet you too! I haven't tried self-supervised learning on the KITTI dataset. One of the other works, Self-Supervised Depth Completion via Adaptive Sampling and Relative Consistency, explores self-supervised training on some indoor datasets, which is also based on our MSG-CHN architecture. However, the pattern of the sparse depth for indoor data is quite different from that of KITTI Lidar data. So I am not very sure about the self-supervised results on KITTI.

Thank you for sharing! I find it also works in disparity completion with minor adjustments and i want to use it in my project. Thank you again.


ffmsindex not detecting track 0 video causing d2v to not be found

Describe the bug or Issue
Opening a mkv of a MPG codec video wont discover track 0 for use with mkvextract, resulting in it not extracting the video for some odd reason. This Leads to MPEG2Source being unusable as it cant find the .d2v as it cant be created as the .mpg wasnt extracted.
Step To Reproduce the Problem

Set MPEG2Source
Load a mkv file (Seemingly only specific mkvs have issues)
It will run it but fails

------------------ Demux MKV using mkvextract 26.0.0 ------------------

C:\Users\x\Downloads\<IP_ADDRESS>.x64\Apps\MKVToolNix\mkvextract.exe "D:\Video\THE_LITTLES 2\title_t00 (1)-021.mkv" tracks 1:"D:\Video\THE_LITTLES 2\title_t00 (1)-021_temp\title_t00 (1)-021 ID1 3ms English.mka" --ui-language en

As you can see here, the issue is fairly strange
Desktop (please complete the following information):

OS: Windows 10 Build 1803
Version: <IP_ADDRESS>
FrameServer Being Used: AviSynth
Version of External Application / Filter Being Used: N/A?
List of Filters Being Used: MPEG2Source

Nothing I can do about ffindex, Since that software hasn't been updated in ages. You can also try new or older versions of MediaInfo since it's know to create problems with certain formats.
Try updating your Build, Since 1.9 is old.


Livestreaming with raw ByteArray

Hi @pedroSG94,
Is there a way to livestream with raw ByteArray (data source from camera preview) using your library?

This library is doing it here:
https://github.com/pedroSG94/rtmp-rtsp-stream-client-java/blob/master/encoder/src/main/java/com/pedro/encoder/input/video/Camera1ApiManager.java#L315
And send to VideoEncoder here:
https://github.com/pedroSG94/rtmp-rtsp-stream-client-java/blob/master/rtplibrary/src/main/java/com/pedro/rtplibrary/base/Camera1Base.java#L895

@pedroSG94  I tried send byte[] through inputYUVData() but I received these logs. It seems that it can not encode video frames.
I/VideoEncoder: frame discarded
D/RtmpConnection: wrote packet: RTMP Audio, size: 258
I/VideoEncoder: frame discarded
I/VideoEncoder: frame discarded
D/RtmpConnection: wrote packet: RTMP Audio, size: 248
I/VideoEncoder: frame discarded
D/RtmpConnection: wrote packet: RTMP Audio, size: 245
D/RtmpConnection: wrote packet: RTMP Audio, size: 263
I/VideoEncoder: frame discarded
D/RtmpConnection: wrote packet: RTMP Audio, size: 264
D/RtmpConnection: wrote packet: RTMP Audio, size: 252
I/VideoEncoder: frame discarded
I/VideoEncoder: frame discarded
D/RtmpConnection: wrote packet: RTMP Audio, size: 265
I/VideoEncoder: frame discarded
D/RtmpConnection: wrote packet: RTMP Audio, size: 295
D/RtmpConnection: wrote packet: RTMP Audio, size: 260
I/VideoEncoder: frame discarded
I/VideoEncoder: frame discarded
D/RtmpConnection: wrote packet: RTMP Audio, size: 258
I/VideoEncoder: frame discarded
D/RtmpConnection: wrote packet: RTMP Audio, size: 245
I/VideoEncoder: frame discarded
D/RtmpConnection: wrote packet: RTMP Audio, size: 255
D/RtmpConnection: wrote packet: RTMP Audio, size: 264
D/RtmpConnection: wrote packet: RTMP Audio, size: 283
I/VideoEncoder: frame discarded
I/VideoEncoder: frame discarded
D/RtmpConnection: wrote packet: RTMP Audio, size: 257
I/VideoEncoder: frame discarded
D/RtmpConnection: wrote packet: RTMP Audio, size: 253
I/VideoEncoder: frame discarded

I also get these logs:
W/VideoCapabilities: Unsupported mime video/divx
W/VideoCapabilities: Unsupported mime video/divx311
W/VideoCapabilities: Unsupported mime video/divx4
W/VideoCapabilities: Unrecognized profile 4 for video/hevc
W/VideoCapabilities: Unrecognized profile/level 0/3 for video/mpeg2
W/VideoCapabilities: Unrecognized profile/level 0/3 for video/mpeg2
I/VideoCapabilities: Unsupported profile 4 for video/mp4v-es
W/Utils: could not parse long range '175-174'
I/OMXClient: IOmx service obtained
W/ExtendedACodec: Failed to get extension for extradata parameter
I/AudioEncoder: prepared
E/RtmpFUCameraBase: Streaming or preview stopped, ignored
I/VideoEncoder: VideoEncoder OMX.qcom.video.encoder.avc
Color supported:<PHONE_NUMBER>
I/VideoEncoder: Color supported:<PHONE_NUMBER>
Color supported:<PHONE_NUMBER>
Color supported: 21
I/OMXClient: IOmx service obtained
I/VideoEncoder: Prepare video info: YUV420SEMIPLANAR, 480x640
bitrate mode CBR not supported using default mode
I/ExtendedACodec: setupVideoEncoder()
W/OMXUtils: do not know color format 0x7fa30c04 =<PHONE_NUMBER>
do not know color format 0x7f000789 =<PHONE_NUMBER>
I/ACodec: setupAVCEncoderParameters with [profile: High] [level: Level3]
I/ACodec: [OMX.qcom.video.encoder.avc] cannot encode HDR static metadata. Ignoring.
setupVideoEncoder succeeded
I/ExtendedACodec: [OMX.qcom.video.encoder.avc] configure, AMessage : AMessage(what = 'conf', target = 4) = {
int32_t color-format = 21
int32_t i-frame-interval = 2
string mime = "video/avc"
int32_t width = 480
int32_t bitrate = 1228800
int32_t max-input-size = 0
int32_t frame-rate = 30
int32_t height = 640
int32_t encoder = 1
}
W/ExtendedACodec: Failed to get extension for extradata parameter
I/VideoEncoder: prepared
started
-----------------------------------------

I/BaseEncoder: Encoding error
java.lang.IndexOutOfBoundsException: off=0, len=512000 out of bounds (size=460800)
    at java.nio.Buffer.checkBounds(Buffer.java:587)
    at java.nio.DirectByteBuffer.put(DirectByteBuffer.java:285)
    at com.pedro.encoder.BaseEncoder.processInput(BaseEncoder.java:156)
    at com.pedro.encoder.BaseEncoder.inputAvailable(BaseEncoder.java:196)
    at com.pedro.encoder.BaseEncoder$2.onInputBufferAvailable(BaseEncoder.java:217)
    at android.media.MediaCodec$EventHandler.handleCallback(MediaCodec.java:1688)
    at android.media.MediaCodec$EventHandler.handleMessage(MediaCodec.java:1646)
    at android.os.Handler.dispatchMessage(Handler.java:106)
    at android.os.Looper.loop(Looper.java:201)
    at android.os.HandlerThread.run(HandlerThread.java:65)

I/chatty: uid=10220(com.botbanhang.botlive) BaseEncoder identical 2 lines
I/BaseEncoder: Encoding error
java.lang.IndexOutOfBoundsException: off=0, len=512000 out of bounds (size=460800)
at java.nio.Buffer.checkBounds(Buffer.java:587)
at java.nio.DirectByteBuffer.put(DirectByteBuffer.java:285)
at com.pedro.encoder.BaseEncoder.processInput(BaseEncoder.java:156)
at com.pedro.encoder.BaseEncoder.inputAvailable(BaseEncoder.java:196)
at com.pedro.encoder.BaseEncoder$2.onInputBufferAvailable(BaseEncoder.java:217)
at android.media.MediaCodec$EventHandler.handleCallback(MediaCodec.java:1688)
at android.media.MediaCodec$EventHandler.handleMessage(MediaCodec.java:1646)
at android.os.Handler.dispatchMessage(Handler.java:106)
at android.os.Looper.loop(Looper.java:201)
at android.os.HandlerThread.run(HandlerThread.java:65)

Which resolution are you using?

I'm using default resolution (640 x 480).
More details: I'm using a face AR library, which is using GLSurfaceView to rendering images. After rendering, that library has a callback returning NV21 frames in byte[]. I'm editing Camera1Base & RtmpCamera1. Instead of sending frames to VideoEncoder at onPreviewFrame() as default, I send them whenever that library return a frame. Then I have the error above.
What can I do to fix this error?

VideoEncoder only support YUV images using byte[]
YUV image size is = width * height * 3 / 2. In your case 460800 but you set an image with size 512000.
Are you sure that your image is YUV format?

@pedroSG94 Thank you! I did realize my mistake. While output video resolution for streaming is 640x480, input video resolution is still 1280x720.
I will close this issue here.

Hi @pedroSG94,
I want to add watermark (text, image) to YUV frame before sending to RTMP stream. Could you help me how to do this?

I don't know how to implement it using YUV byte array.
Maybe mix both images using canvas and convert RGB image provided by convas to YUV is a solution but the performance is really bad

I see. Which method do you recommend when I have to add water mark to livestream using GLSurfaceView?

You can create an external texture with opengl and add it to your shader. I'm doing it with ImageObjectFilter:
https://github.com/pedroSG94/rtmp-rtsp-stream-client-java/blob/master/encoder/src/main/java/com/pedro/encoder/input/gl/render/filters/object/ImageObjectFilterRender.java
Parent class:
https://github.com/pedroSG94/rtmp-rtsp-stream-client-java/blob/master/encoder/src/main/java/com/pedro/encoder/input/gl/render/filters/object/BaseObjectFilterRender.java
You can check result using my app example OpenGl RTMP/RTSP, open top-right menu and select image.

I tried this method using ImageObjectFilter and it worked but I lost camera preview on GLSurfaceView.
Before using ImageObjectFilter:

After using ImageObjectFilter:

Here is my code:
`@Override
public void onSurfaceCreated(GL10 gl, EGLConfig config) {
Log.d(TAG, "onSurfaceCreated. thread:" + Thread.currentThread().getName());
GlUtil.logVersionInfo();
mProgramTexture2d = new ProgramTexture2d();
mProgramTextureOES = new ProgramTextureOES();
mProgramLandmarks = new ProgramLandmarks();
    imageObjectFilterRender = new ImageObjectFilterRender();
    imageObjectFilterRender.initGl(720, 1280, mActivity, 720, 1280);
    imageObjectFilterRender.setImage(
            BitmapFactory.decodeResource(mActivity.getResources(), R.drawable.anhs));
    imageObjectFilterRender.setDefaultScale(720,
            1280);
    imageObjectFilterRender.setPosition(TranslateTo.RIGHT);

    mCameraTexId = GlUtil.createTextureObject(GLES11Ext.GL_TEXTURE_EXTERNAL_OES);
    mBackgroundHandler.post(new Runnable() {
        @Override
        public void run() {
            openCamera(mCameraFacing);
            startPreview();
        }
    });
    LimitFpsUtil.setTargetFps(LimitFpsUtil.DEFAULT_FPS);
    mOnRendererStatusListener.onSurfaceCreated();
}`

`@Override
public void onDrawFrame(GL10 gl) {
.....................................
    imageObjectFilterRender.draw();

    ........................................
}`

You aren't rendering camera data in your view. You can use my OpenGlView instead of your view:
https://github.com/pedroSG94/rtmp-rtsp-stream-client-java/blob/master/rtplibrary/src/main/java/com/pedro/rtplibrary/view/OpenGlView.java

Closing as inactive


Support Vue SFC syntax

Currently, it doesn't seem like Prism (or any other syntax highlighting library) supports the Vue Single File Components syntax.
I'd like to request support for this syntax.

Would love support for this

I really love this library and would be great to have Vue SFC support

I actually think this may be supportable without a custom syntax. If you load JavaScript & CSS then markup, you should be able to render Vue SFCs in the markup language and have everything highlighted properly.

@mAAdhaTTah That won't work. Ignoring the templating syntax, there still is the issue that the style and script tags do not have to contain JS and CSS (an example with Stylus). Markup might be a good starting point but there is no avoiding a new language.

I actually think this may be supportable without a custom syntax. If you load JavaScript & CSS then markup, you should be able to render Vue SFCs in the markup language and have everything highlighted properly.

html also works nicely in my experience – thanks for the suggestion 👍

Which version will support this?
v1.22.0 is still not cool enough when parsing v-bind attributes

Driving by with a +1 for this issue. I'm very happy with Prism on https://codeapprove.com but this is one of the main sticking points.

+1 for Vue syntax highlighting

typescript in vue3 work failed:
<template>{{ num }}</template>

<script lang="ts" setup>
const num: number = 123;
</script>

num: number syntax cannot highlight

Which version will support this? v1.22.0 is still not cool enough when parsing v-bind attributes

Most likely v2, since v1 is feature frozen.


[BUG] - cardano-cli misses to show some utxo transactions

External
Summary
Some transactions I can see from Daedalus are not displayed using cardano-cli command.
I created a new wallet in Daedalus and I transferred some ada twice using cardano-cli. The first transaction for an amount of 1,000 ada and the second one for 1,000,000 ada.
From Daedalus I can see both of them:
tx id: 0ef30491368e9a08e2aaf5130393687b56daf58c7dc440ed0ab5aaee3cd5db52 for the one of 1,000 ada
tx id: 7ee23af59b3cdece2f6b0dda0c9bf29ff853c80ff03f934e662c47f42af7a436 for the one of 1M ada.
When I inquiry the address through cardano-cli I see only the latest one:
cardano-cli shelley query utxo --address 0055d9d2d0470227be40f6ace0686f35f37a8f2fe63023bee318f1a4fc920f36e134a790ce3202f6e18b3e753eb250c8340421dd2bed8e4c12 --testnet-magic 42
                       TxHash                                 TxIx        Lovelace

7ee23af59b3cdece2f6b0dda0c9bf29ff853c80ff03f934e662c47f42af7a436     0<PHONE_NUMBER>000
I noticed the same behavior in cardano-graphql using the preinstalled view utxo_view filtering by the address value. Even if both transactions are present in table tx with tx_id 1536394 and 1536275 the view displays only the first one (same behavior of cardano-cli).
Expected behavior
Both transactions should be displayed
System info (please complete the following information):

OS: Ubuntu
Version 20.04
cardano-node 1.4.2
cardano-db-sync 2.1.0
cardano-graphql 1.0.0-rc14

We will investigate this

Note that the CLI UTxO command gives the current UTxO rather than the history.   What is being shown is consistent with one of the txs output being unspent, and the other already spent.  So we believe there is no problem here, in fact, and the information is being reported correctly.


Enable decode of timedelta pandas dtype

Thank you so much!  This looks correct, but it would be really nice if we could have a unit test to make sure that it works correctly, and to make sure that we don't break this functionality in the future.
Sorry for the delay in responding to the PRs -- I have some more time now.  BTW, there is a change brewing in #338 that would be great to test in tandem with these changes.  Could you maybe test that branch with these change to verify that they're all good?
Maybe we can come up with the test case together, in case you're having trouble running the tests.  The tests/pandas_test.py is probably the best place to add the new tests.
Let's try to get this tested and then we'll merge this right in.  Thanks again!

Thank you so much!  This looks correct, but it would be really nice if we could have a unit test to make sure that it works correctly, and to make sure that we don't break this functionality in the future.
Sorry for the delay in responding to the PRs -- I have some more time now.  BTW, there is a change brewing in #338 that would be great to test in tandem with these changes.  Could you maybe test that branch with these change to verify that they're all good?
Maybe we can come up with the test case together, in case you're having trouble running the tests.  The tests/pandas_test.py is probably the best place to add the new tests.
Let's try to get this tested and then we'll merge this right in.  Thanks again!

Ah, sorry I missed your note in #331 -- I can try to rearrange recipe you provided there into a test case as well since you mentioned you're new.  Let me know if you were able to run the test suite, that's usually the first step to writing new tests since it's easier to do once it's up and running.
If I'm able to write a test that fails without these changes and then passes with them present then I'll merge this shortly thereafter.  Thanks again.

Ah, sorry I missed your note in #331 -- I can try to rearrange recipe you provided there into a test case as well since you mentioned you're new.  Let me know if you were able to run the test suite, that's usually the first step to writing new tests since it's easier to do once it's up and running.
If I'm able to write a test that fails without these changes and then passes with them present then I'll merge this shortly thereafter.  Thanks again.

I added a test case to tests/pandas_test.py (near the bottom) with your recipe from #331.  It worked great, thanks again!

I added a test case to tests/pandas_test.py (near the bottom) with your recipe from #331.  It worked great, thanks again!


Cocoon GitHub labeler is incorrectly applying package integration_test label to normal integration tests

The integration_test label is for issues related to the integration_test plugin.

However, the cocoon labeler is applying it to any changes to a file containing "integration_test", for example dev/integration_tests/flutter_gallery/.
This test should fail:
https://github.com/flutter/cocoon/blob/e3290e2fa83adfb1ea51f1ade68abbd1f28b51c6/app_dart/test/request_handlers/github_webhook_test.dart#L408-L410
Introduced in https://github.com/flutter/cocoon/pull/1351

/cc @Piinks

Ah thanks! Apologies for the overly eager labels. Fix is in https://github.com/flutter/cocoon/pull/1463


MacOS: can't run Explore here action

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior:
On MacOS I can't run the Explore here action to open the directory using Finder. Looks like it tries to use the folder entity path as the executable which is weird.
Expected Behavior:
It should open the Finder application (used on MacOS).
Version
1.0.0
What platform you are running on?
MacOS
Steps To Reproduce:

Open the launcher
Click on any folder
Click the Explore here action

Are there any labels you wish to add?

[X] I have added the relevant labels to the bug report.

Relevant log output:
The application /Volumes/projets/TEST_PIPE/sequences/sq01/sh01/work/layout
cannot be opened for an unexpected reason,
error=Error Domain=NSOSStatusErrorDomain Code=-10827 "kLSNoExecutableErr: The executable is missing"
UserInfo={_LSLine=4129, _LSFunction=_LSOpenStuffCallLocal}

Additional context:
No response

It should be running open -na {path}, see here.
I wonder if it should be open -R {path} as mentioned here.
@johhnry do you happen to know?

@BigRoy I just tested open -R {path} on MacOS and it works perfectly whereas open -na raise the above error!


VK "No JSON object could be decoded" error

Checklist

[X] I'm reporting a broken site support
[X] I've verified that I'm running youtube-dl version 2021.12.17
[X] I've checked that all provided URLs are alive and playable in a browser
[X] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[X] I've searched the bugtracker for similar issues including closed ones

Verbose log
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: [u'--verbose', u'https://vk.com/video222127078_456240791']
[debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2021.12.17
[debug] Python version 2.7.18 (CPython) - Linux-5.4.72-microsoft-standard-WSL2-x86_64-with-debian-11.3
[debug] exe versions: ffmpeg 4.3.4-0, ffprobe 4.3.4-0, rtmpdump 2.4
[debug] Proxy map: {}
[vk] 222127078_456240791: Downloading JSON metadata
ERROR: 222127078_456240791: Failed to parse JSON  (caused by ValueError('No JSON object could be decoded',)); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 906, in _parse_json
    return json.loads(json_string)
  File "/usr/lib/python2.7/json/__init__.py", line 339, in loads
    return _default_decoder.decode(s)
  File "/usr/lib/python2.7/json/decoder.py", line 364, in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
  File "/usr/lib/python2.7/json/decoder.py", line 382, in raw_decode
    raise ValueError("No JSON object could be decoded")
ValueError: No JSON object could be decoded
Traceback (most recent call last):
  File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 815, in wrapper
    return func(self, *args, **kwargs)
  File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 836, in __extract_info
    ie_result = ie.extract(url)
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 534, in extract
    ie_result = self._real_extract(url)
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/vk.py", line 325, in _real_extract
    payload = self._download_payload('al_video', video_id, data)
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/vk.py", line 70, in _download_payload
    headers={'X-Requested-With': 'XMLHttpRequest'})['payload']
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 899, in _download_json
    expected_status=expected_status)
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 883, in _download_json_handle
    fatal=fatal), urlh
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 910, in _parse_json
    raise ExtractorError(errmsg, cause=ve)
ExtractorError: 222127078_456240791: Failed to parse JSON  (caused by ValueError('No JSON object could be decoded',)); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.

Description
I'm currently unable to download videos from VK. I'm getting a Failed to parse JSON  (caused by ValueError('No JSON object could be decoded') error. Although I'm unable to donwnload it with yt-dlp too but with a different error Failed to parse JSON (caused by JSONDecodeError('Expecting value: line 1 column 1 (char 0)) so it could be linked to issue #30972, but I'm not sure.

Apparently when you send the sort of request that the extractor uses, you get a "429 Too many requests" error page with a 200 code.
The initial solution was in [#31035]. Unfortunately it now doesn't seem to be working any better than the original code.

Continued in #31035.


Add to support restricted API keys

Add to support calling Google APIs when the API key is restricted to iOS or Android apps.
Related issues: #28 #85

Closing this as this will introduce flutter as a dependency. Will create a new PR instead.


Problem when $inject is already defined twice

I'm using gulp-ng-annotate.  I had some silly code that defined $inject for a directive's controller twice (oops!).  The only behavior I saw, though, was that when I added ngAnnotate() to my gulpfile suddenly everything stopped working, without any error message.  I added/removed files from my build process to narrow it down, then comment/uncomment code until I found the issue.
I'm guessing "silently fail" is not the desired behavior.  My first guess is that the issue is here in ng-annotate, but I will happily move this report over to gulp-ng-annotate if everything is OK on your end.
Here is a small example that will trigger the issue:
myApp.directive('myDirective', myDirective);
function myDirective() {
	controller.$inject = ['$scope', '$element', '$attrs'];
	function controller($scope, $element, $attrs) {
		// important stuff here
	}
	controller.$inject = ['$scope', '$element', '$attrs'];
	return {controller: controller,};
}

ng-annotate doesn't like that you declare the array twice but it does report an helpful error:
~/projects/ng-annotate/tests-issues % ng-annotate -a issue192.js
error: conflicting inject arrays at line 3 and 7

If you don't see this error message when using gulp then that's a bug so then please open an issue on gulp-ng-annotate.
If you need to have the duplicate arrays then just tell ng-annotate that you don't want it to annotate the controller function:
    function controller($scope, $element, $attrs) {
        "ngNoInject";
        // important stuff here
    }


Documentation for text layer is same as documentation of solid layer

In documentation of text layer bodymovin/docs/json/layers/text.json
"description": "Type of layer: Solid. Value 1.",
"extendedName": "Type",
"name": "ty",
"type": "number"
this is same as solid layer.  Please help with documentation of text layer

thanks! Fixed in version 4.5.5


feat: i18n

Resolves #61.
Setup local translation using i18next. This is the part that syncs the code with translation files.
New translations go into src/locales/<lang>/translation.json files and need to be added to the i18n.js script. I added a dummy German translation file is just to document how adding new languages would work. The source language and fallback for any keys that are not found in the current language will be the English translation.
What's still missing of course is syncing the translation files with Transifex.
I only added translations for the Wallet component for now. I can add more right now or do it gradually in separate PRs. Thoughts?

:muscle:
The setup looks super tidy and is a good preparation for translating the app step by step. Really nice.
When I tried to add another language, the settings screen could not be rendered, but it worked the second time - do not really know what was wrong.

I only added translations for the Wallet component for now. I can add more right now or do it gradually in separate PRs. Thoughts?
Perfect.

Option 2. seems to be the most straight forward solution. It does require us to give the Transifex GitHub app write access to the repo though. That's my only concern. Any thoughts on what option we should go with?
Let's see how Transifex works out in the long run. It seems it can be replaced rather easily. As you mentioned somewhere, it cannot merge to master and every change needs approval.. so it should be okay.

When I tried to add another language, the settings screen could not be rendered, but it worked the second time - do not really know what was wrong.

Ok that's strange. What did you do to add the new language?


Apply ROCm size optimization from github.com/tiran/instructlab-containers

Description

How Has This Been Tested?

Merge criteria:

[ ] The commits are squashed in a cohesive manner and have meaningful messages.
[ ] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[ ] The developer has manually tested the changes and verified that the changes work

/test akll

/test all

/test images
/test rocm-notebooks-e2e-tests

/test images
/test rocm-notebooks-e2e-tests

Installing:
 rccl                           x86_64  <IP_ADDRESS>100-82.el9         ROCm                      16 M
 rocm-device-libs               x86_64  <IP_ADDRESS>100-82.el9          ROCm                     625 k
 rocm-smi-lib                   x86_64  <IP_ADDRESS>100-82.el9          ROCm                     688 k
 rocm-utils                     x86_64  <IP_ADDRESS>100-82.el9          ROCm                     7.1 k

Install  191 Packages
Total download size: 348 M
Installed size: 1.2 G

Installing:
 rocm-hip-runtime           x86_64     <IP_ADDRESS>100-82.el9        ROCm      10 k
 rocm-language-runtime      x86_64     <IP_ADDRESS>100-82.el9        ROCm     7.2 k
 rocm-opencl-runtime        x86_64     <IP_ADDRESS>100-82.el9        ROCm      10 k

Install  6 Packages
Total download size: 131 M
Installed size: 414 M

Installing:
 rocblas             x86_64       <IP_ADDRESS>100-82.el9           ROCm       252 M
 rocblas-devel       x86_64       <IP_ADDRESS>100-82.el9           ROCm       133 k
 rocsolver           x86_64       <IP_ADDRESS>100-82.el9          ROCm       168 M
 rocsparse           x86_64       <IP_ADDRESS>100-82.el9           ROCm        76 M

Install  4 Packages
Total download size: 497 M
Installed size: 7.0 G

Installing:
 hipblas               x86_64       <IP_ADDRESS>100-82.el9         ROCm       193 k
 hipblaslt             x86_64       <IP_ADDRESS>100-82.el9         ROCm       1.3 M
 hipblaslt-devel       x86_64       <IP_ADDRESS>100-82.el9         ROCm       395 M
 hiprand               x86_64       <IP_ADDRESS>100-82.el9       ROCm        13 k
 hipsparse             x86_64       <IP_ADDRESS>100-82.el9         ROCm        84 k

Install  5 Packages
Total download size: 396 M
Installed size: 5.5 G

Installing:
 hipfft            x86_64  <IP_ADDRESS>100-82.el9      ROCm                   33 k
 hipfft-devel      x86_64  <IP_ADDRESS>100-82.el9      ROCm                   20 k
 hipsolver         x86_64  <IP_ADDRESS>100-82.el9       ROCm                   91 k
 miopen-hip        x86_64  <IP_ADDRESS>100-82.el9       ROCm                  176 M
 miopen-hip-devel  x86_64  <IP_ADDRESS>100-82.el9       ROCm                   52 k
 rocrand           x86_64  <IP_ADDRESS>100-82.el9       ROCm                   24 M
 rocrand-devel     x86_64  <IP_ADDRESS>100-82.el9       ROCm                  661 k
 roctracer         x86_64  4.1.60100.60100-82.el9   ROCm                  362 k

Install  14 Packages
Total download size: 370 M
Installed size: 3.8 G

Installing:
 rocm                     x86_64  <IP_ADDRESS>100-82.el9          ROCm                   10 k

Install  57 Packages
Total download size: 519 M
Installed size: 6.6 G

/retitle Apply ROCm size optimization from github.com/tiran/instructlab-containers

/test ci/prow/notebook-rocm-jupyter-tf-ubi9-python-3-11-pr-image-mirror

/test notebook-rocm-jupyter-tf-ubi9-python-3-11-pr-image-mirror

/test images

/test rocm-notebooks-e2e-tests

/test rocm-notebooks-e2e-tests

/test rocm-notebooks-e2e-tests

/retest

/override ci/prow/rocm-notebooks-e2e-tests

/hold
I don't remember whether I tested fully. Possibly not because I got to think we don't gonna bother with this.

I don't remember whether I tested fully. Possibly not because I got to think we don't gonna bother with this.

Ack, in that case
let close this and the other PR.
incase , we would like to investigate more,we can bring these back in future
What do you say ?

/remove-approve
/remove-lgtm
Wait for the reply.

not planned for now


Routes only work in namespace

Hey there :)
I'm still using<EMAIL_ADDRESS>or so, I hope you still remember how that version worked ;)
I want to move my app into packages as I think I will get a better structure then. I will not have my global App namespace anymore then, so before doing that, I tried to remove it.
All I did was changing this
@injector.map('PatientsNewController').toSingleton App.PatientsNewController
# to
@injector.map('PatientsNewController').toSingleton PatientsNewController

and
class App.PatientsNewController
# to
class @PatientsNewController

I don't know why, but it just stopped working. I get my "not found" page, and the url changes to undefined. Do you have an idea what might be wrong?
I can access PatientsIndexController from the console and when I log it before mapping it, I can get it there, too. Really strange :)

In your first code snippet you use PatientsNewController instead of PatientsIndexController.

Oh, I see. But that's just because I rejected my changed and copied the wrong code over as an example :)

Hey @zimt28, when you start splitting up your application into packages (which i highly recommend) then you can start using a Space.Module for each package which publishes itself into the global Space environment where it can be required by the main Space.Application. Here is some example code:
Space.Module.extend(function() {
      this.publish(this, 'FirstModule'); # publishes this module into global space environment
      return {
        configure: function() {
          this.injector.map('testValue').toStaticValue(testValue); # application injector
        }
      }
    });

    Space.Application.create({
      RequiredModules: ['FirstModule'], # require your modules which might live in packages
      Dependencies: { testValue: 'testValue' }, # you can also use mapped values from modules
      configure: function () { testResult = this.testValue; }
    });

This topic is actually not really related to space:ui as the dependency injection and application infrastructure comes from the package space:base and you can read through the integration tests to get a rough feeling how applications and modules work together.
Long story short: Space.Application extends Space.Module and has a very similar api. The biggest difference is: There is only a single Space.Application in your app with a single Space.Injector instance that is automatically shared with all required modules. So you can map dependencies within your modules like you did in your application before and access them from anywhere. One way to organize the dependencies is to namespace them based on the package name, e.g: @injector.map('MyModule.AwesomeServiceClass').asSingleton()

Ok cool, thanks for your response :) I have different plans at the moment: Put everything into packages and move to the newest version of space-ui. Maybe switch to meteorhacks flow router and layout as well. The way I'm doing this is to move things into packages without space-ui. Things need to keep working and it's much easier for me to move the code without. And I need to rewrite most things for the new space-ui anyway :) However, do you think there's a way I can keep the stores? Like drop space-ui -> move into packages with stores only -> add new space-ui? Enjoy your weekend!

@zimt28 ok, I am not sure if I could follow but you could also just split up your code into packages and work with a single Space.Application that maps everything for you. The reason why I split packages up into Space.Module is that you can have integration tests for each individual package and check if they are doing the right thing when sending commands and publishing events into the system :wink:

Now that's cool! Great, the find().fetch()[0] solution was kinda ugly :) I'll try to ask my question differently: What I want to know is just, if it's possible to just use the store from space-ui. The rest was just explanation. Migration to the newest iron:router, space-ui, and moving into packages at once is too much. So I want to put my code into packages without space-ui, but keep the store. So that I can, after all, implement the new version of space-ui :) Makes sense?

Ah ok, now I understand – you mean like just using the store class within your packages? It is possible, but you have to extract the code manually from this Github repository. And of course you would also have to extract parts of the other stuff for the flux messaging etc. so I am not sure what the benefit of that would be?
And to come back to your original question, actually I don't know why it doesn't work – it should! Did you require the package from the main app in .meteor/packages?

@zimt28 any updates on that?

Yes :) I'm still busy moving everything into packages, already took some time as I've never created packages before .. Wish I had started with packages :D
I just dropped the old space-ui and copied the old store class so that I don't have to change my stores:
class Store

  state: new ReactiveVar()

  ready: ->
    @state.set @setInitialState()

  setInitialState: -> {}

  getState: (path) ->
    path = if path? then path.split "." else []
    state = @state.get()
    state = state[key] for key in path
    return state

  setState: (path, value) ->

    # Changes the whole state at once if no path is given
    if arguments.length < 2
      value = path
      @state.set value
      return

    # Sets nested property at path
    existingState = @state.get()
    newState = _.clone existingState

    path = path.split "."
    property = newState

    for name, index in path

      if index + 1 < path.length
        # build up missing object path
        property[name] ?= {}
        property = property[name]
      else
        property[name] = value

    @state.set newState

Store::get = Store::getState
Store::set = Store::setState

Works great :) I'm also moving to the newest iron:router, and can then get my head around the current space-ui :)

Should I close this thread? :wink: I guess this is no "real issue" anymore


Compilation Error : Missing js.jquery on hashlink compile

Hi,
After the latest update, I'm getting "Element.hx:3: characters 19-35 : Type not found : js.jquery.JQuery" when I compile my heaps project that uses the hide libs. It seems the hide portion of the library is being included somehow in the heaps project, not just the l3d parts.
Am I missing a define or something I need to do to exclude the IDE parts?
Do I need to add these my project?
--remap hide:notAllowed
--macro include("hrt")

That was it.  Never mind.


[WIP] Introducing Status Pollers for Bosh Based Restore

Pull Request Test Coverage Report for Build 3003

35 of 38 (92.11%)  changed or added relevant lines in 1 file are covered.
8 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.07%) to 89.982%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

operators/bosh-restore-operator/BoshRestoreService.js
35
38
92.11%

Files with Coverage Reduction
New Missed Lines
%

operators/bosh-restore-operator/BoshRestoreService.js
8
83.4%

Totals

Change from base Build 2985:
-0.07%

Covered Lines:
9203

Relevant Lines:
9882

💛  - Coveralls


[HOLD #44269] HIGH: [API] Multiple redundant ReconnectApp calls upon waking client

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: v1.4.82-4
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @quinthar
Slack conversation: https://expensify.slack.com/archives/C05LX9D6E07/p1718128174597309
Action Performed:
Break down in numbered steps

Open NewDot in a chat or in a room
Open the Network console
Close your laptop lid
Wait for 10-15 seconds
Open the lid

Expected Result:

Describe what you think should've happened

There should be one ReconnectApp call upon waking the client
Actual Result:

Describe what actually happened

The client queues multiple, successive ReconnectApp calls
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
N/A
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

View all open jobs on GitHub

I believe this will be handled in https://github.com/Expensify/App/issues/43089

Will be able to start investigating next week - I have a suspicious this is related to the useNetwork hook. When I open my laptop lid from sleep, I consistently see the offline indicator for a moment and and then will see that it resolves

I've experienced this as well @thienlnam!

Been testing a few things that haven't been successful - I still think the issue is around how waking up after sleep the network is temporarily unstable and we shoot off the duplicated call in the beginning

@thienlnam is there anything that external contributors can help with here? I'm guessing no at the moment

This is actually likely a problem that can be solved externally.
We call ReconnectApp because the network on wake is unstable, but it doesn't seem like we have a mechanism to prevent calling this again even if the passed initialLastUpdateIDAppliedToClient is the same.
I'm not too familiar with the SequentialQueue, so this is perhaps something we could get a contributor to look into in #newdot-quality

Discussion here, this likely has the same root cause as this so we'll hold for that

Still on hold!

https://github.com/Expensify/App/issues/44269 is still in progress

https://github.com/Expensify/App/issues/44269 is still in progress

I think let's close this for focus as the linked issue is the stated root cause.


Fixes #999, hanlde UTF16 surrogate charactors properly.

Change-Id: I19e77cf5a8282bea901434041806eb102549ec0f
Description
Brief description of what this PR is about

If this change is a backward incompatible change, why must this change be made?
Interesting edge cases to note here

Codecov Report

Merging #1003 (6436574) into master (8286930) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1003      +/-   ##
============================================
- Coverage     70.02%   69.98%   -0.04%
+ Complexity     5105     5104       -1
============================================
  Files           504      504
  Lines         22582    22582
  Branches       2366     2366
============================================
- Hits          15812    15804       -8
- Misses         5503     5516      +13
+ Partials       1267     1262       -5

Impacted Files
Coverage Δ

...gine/src/main/java/ai/djl/dlr/engine/DlrModel.java
53.12% <0.00%> (-3.13%)
:arrow_down:

...ain/java/ai/djl/tensorflow/engine/TfNDManager.java
88.49% <0.00%> (-2.66%)
:arrow_down:

api/src/main/java/ai/djl/util/Platform.java
43.47% <0.00%> (-2.18%)
:arrow_down:

...g/src/main/java/ai/djl/serving/util/Connector.java
55.40% <0.00%> (-1.36%)
:arrow_down:

...ngine/src/main/java/ai/djl/mxnet/jna/LibUtils.java
42.23% <0.00%> (-1.25%)
:arrow_down:

...rc/main/java/ai/djl/paddlepaddle/jni/LibUtils.java
51.14% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8286930...6436574. Read the comment docs.


Select not translateble

I've added a formfield to my block which I would assume would allow me to select a field based on the selected language. But select fields do not seem to be translatable.
@formField('select', [
    'name' => 'icon',
    'label' => 'Select an icon',
    'placeholder' => 'Icons',
    'translated' => true,
    'options' => [
        [
            'value' => 'markets',
            'label' => 'Markets'
        ],
        [
            'value' => 'support',
            'label' => 'Support'
        ],
        [
            'value' => 'career',
            'label' => 'Career'
        ],
        [
            'value' => 'recycle',
            'label' => 'Recycle'
        ],
        [
            'value' => 'sla',
            'label' => 'SLA'
        ],
        [
            'value' => 'spareparts',
            'label' => 'Gears'
        ]
    ]
])

Did you managed to translate select type?

Doesn't make sense to me to have a translatable/editable select field, I would suggest using Laravel's Translation String instead.
Closing this issue now, feel free to reopen it if further discussion is needed.

Kind of make sense if the select is a modifier. Let's say it's a video source selector the source and the video in French is hosted on Youtube, but the same video in English was somehow hosted on Vimeo. Not only the Video ID and the Caption are translatable, but we also need the type of source to be stored according to the language.

how to save the select fields value in table (value is not saved in table ) after submitting the form


Assign blend_order to styles

Styles should be drawn as follows:

ground, landuse, roads, buildings, etc.
route line
labels + icons
search results + route icon (app chrome)

where n+1 is drawn above n.
Tested this in eraser-map app.

cc. @nvkelso, Can you have a look at this and merge if this looks good.
This will make sure, route line is drawn below labels and icons, and search results and route icons (icon, start, stop) are drawn above everything else.

Having a look...

Working for me in app for routing. Search is crashing the app so can't confirm there. Time for a drive test :)


Give organizations fetch_members field for fetching members

Closes #5.

Could you please add some consolidation-con.yaml which we test only for reading (not really for running -- not worth torturing CI), would cover con organization, would exclude  con-bot member, add vmdocua as an external member.  This then we could go as some prototypical example since now all those additions without any documentation/example would be lost.

@yarikoptic Do you mean that this file would only serve as a form of documentation (which I'd rather do through filling out the README) or that it should be used for testing somehow?

@yarikoptic Ping.


Spike for static offline 2fa code functionality

This PR creates a new view to enter an offline 2fa code.  The 2fa offline code creation can only be done at this point through the admin interface.  Waiting on designs to implement user creation flow.
Temporary translations have been put into place while awaiting final designs/content
Admin panel 2fa creation flow

User login using 2fa emergency code

Closing because functionality is being duplicated in other PRs


username and password hash is stored in the client.prefs file

The client stores the hash of the password in the client.prefs text file.
The file stores configuration related info mainly and may be requested for troubleshooting which causes the user unwillingly share his/her password.
I think it would be better to store the password hash in a separate file, in a gziped binary file even along with the username for better safety when Automatic login is requested.

Maybe we just encrypt it with idk his cpu name, something that stays the same on his system. I mean ppl should still not give out that info but if they so it is not completely exposed

I mean in the long run we wanna have a jwt token stored there. Tho the sever does not yet accept that


Replace Dialog preview bug

Ubuntu 64-bit
The Preview shows two "ok" buttons.
At runntime is all fine.
Steps to reproduce:

Create a AcceptDialog.(Resize to see something)
Turn/Replace this AcceptDiolog into a ConfirmationDialog.(Resize to see something)

UPDATE:
Also happens with EditorFileDialog.
Steps to reproduce:

Create a EditorFileDialog.(Resize to see something)
Turn/Replace this EditorFileDialog into a FileDialog.(Resize to see something)

#4128


Docs: Fix code block formatting HA auth service

Type of change

Documentation

Description

Docs: Fix code block formatting HA auth service
Checklist

[ ] Update/write design documentation in ./documentation/design
[ ] Write tests and make sure they pass
[x] Update documentation
[ ] Check RBAC rights for Kubernetes / OpenShift roles
[ ] Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
[ ] Reference relevant issue(s) and close them after merging
[ ] Update CHANGELOG.md

Can one of the admins verify this patch?


Feat: Add ability to generate files in folders

Adding a new feature flag prefix_schema_files_with_package which results in the schema files being generated in folders based on the package of the message.

@dorner Do you have any interesting in accepting feature requests to this repo or should we just permanently fork?
We have a few additions which we needed for our use case if you would like to add more feature flags.

@ikstewa so sorry! I didn't have this repo as watched on my settings so I didn't see the original PR. I'm coming back from vacation but will take a look at these today.

@ikstewa tests are failing - can you rebase off main and make sure you rerun tests? You can use UPDATE_SNAPSHOTS=1to automatically update the fixtures.


[BUG] column using data.name replaced with top-level name field in Telemetry Viewer

Description/Screenshot
When using this config with the Telemetry Viewer, the "Name" column sometimes falls back to the data.name field. I expect this value to appear in the display, but the top-level name field is what actually displays.

Steps to Reproduce

OS/Browser: W10 v22000.348, Edge v97.0.1072.13
SDK Version [e.g. 22]: N/A
How you initialized the SDK: Telemetry Viewer extension v0.2.0

Expected behavior
data.name field properly displayed instead of top-level name.
Additional context
Add any other context about the problem here.

Might make sense to change the order in this line:
const value = _.get(dataEvent.data, names[lp]) || _.get(dataEvent, names[lp]);

@KevBrown-MSFT does this change make sense from your historical perspective?

If we made that change, how would you specify you want to display the name field in the root of the event?  Today you can specify name and it'll check name and fall back to data.name, or you can specify data.name and it'll find it when it checks the root of the event.
From: Nev @.>
Sent: Tuesday, January 18, 2022 1:40 PM
To: microsoft/ApplicationInsights-JS @.>
Cc: Kevin Brown (OMG) @.>; Mention @.>
Subject: Re: [microsoft/ApplicationInsights-JS] [BUG] column using data.name replaced with top-level name field in Telemetry Viewer (Issue #1734)
@KevBrown-MSFThttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FKevBrown-MSFT&data=04|01|Kevin.Brown%40microsoft.com|3625d0dfd72c4607361f08d9dacb10bc|72f988bf86f141af91ab2d7cd011db47|0|0|637781387977888385|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=KvUaFsoAEn0ru96rVUbpBKhadJfa5HeH4Zd7Pc%2FdhgM%3D&reserved=0 does this change make sense from your historical perspective?

Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FApplicationInsights-JS%2Fissues%2F1734%23issuecomment-1015858534&data=04|01|Kevin.Brown%40microsoft.com|3625d0dfd72c4607361f08d9dacb10bc|72f988bf86f141af91ab2d7cd011db47|0|0|637781387977888385|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=5llPkcp27TY%2BK5N6PxFYYqC6RXxZ4olATcfMIhZtqp0%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAMMGYFCF5MELH2L6MWO3JQLUWXM2VANCNFSM5JRYBADA&data=04|01|Kevin.Brown%40microsoft.com|3625d0dfd72c4607361f08d9dacb10bc|72f988bf86f141af91ab2d7cd011db47|0|0|637781387977888385|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=k2dp7t6V3q%2BIvZ%2Bpnvsll2u5vmm3K2ziyLi1ubtF7Gc%3D&reserved=0.
Triage notifications on the go with GitHub Mobile for iOShttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04|01|Kevin.Brown%40microsoft.com|3625d0dfd72c4607361f08d9dacb10bc|72f988bf86f141af91ab2d7cd011db47|0|0|637781387977888385|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=JEiMYlEZws3K6LXQfZyN8V%2B118t1LokNGtDngjCu3hQ%3D&reserved=0 or Androidhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04|01|Kevin.Brown%40microsoft.com|3625d0dfd72c4607361f08d9dacb10bc|72f988bf86f141af91ab2d7cd011db47|0|0|637781387977888385|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=B%2BxBhk3mC1oghliOEE04%2F6TEcDH1K7%2FVri1qPsNpjos%3D&reserved=0.
You are receiving this because you were mentioned.Message ID<EMAIL_ADDRESS>

@techtor If this won't be fixed, we need to change the config to use data.data.name instead of just data.name.

@mbest Sure. If Nev and Kevin decide to close out this issue, please feel free to open an internal bug directly against me, and I'll update our stored config.

I'm going to let Kevin make the call on this as we inherited this from the original version, so based on.
But the current order "feels" right based on the usage, ie. try on the passed object directly and if it's not there try accessing the "data" sub object (if present)


Missing LogLevel directive in configuration

When trying to run social-pipe, I got the following error message :
Traceback (most recent call last):
  File "social-pipe.py", line 61, in <module>
    LogLevel = int(conf['OPTIONS']['LogLevel'])
  File "/opt/pkg/lib/python3.6/configparser.py", line 1233, in __getitem__
    raise KeyError(key)
KeyError: 'LogLevel'

It turns out the LogLevel directive is missing from the social-pipe.conf file. I also noticed it is also missing in the social-pipe.conf.tpl file.
This was tested with the following platform :

OS : macOS Mojave 10.14.5 (18F132)
Python 3.6.9 from pkgsrc
py36-virtualenv-16.6.1 (from pkgsrc)
py36-setuptools-41.0.1 (from pkgsrc)
requirements installed from requirements.txt

Hey,
this is fixed in the following commit :
https://github.com/DvdChe/social-pipe/commit/7a156e2a31a5cf8d9fbcf149334ee0ce923432c5


feature: better buy/sell command

Is your feature request related to a problem? Please describe.
Newer bots currently have new buy commands which goes: buy_item or sell_item which makes it easier to just double click and paste for easy use.
Describe the feature you'd like
Implement same function and use it as a module.

You can already change the buy and sell commands in the options.json file I believe.
for more info see here.
But if you mean by adding a new command for changing it without having to manually do it, then I think it could still be something to be implemented into the bot.


swift build fails compiling DangerDSL.swift

I'm attempting to following the getting started guide by running swift build and it fails with following output:
/.build/checkouts/swift/Sources/Danger/DangerDSL.swift:61:24:
error: immutable value 'self.github' may only be initialized once
            github.api = Octokit(config)
                       ^
/.build/checkouts/swift/Sources/Danger/DangerDSL.swift:16:12:
note: change 'let' to 'var' to make it mutable
    public let github: GitHub!
           ^~~
           var

About me
swift -version
Apple Swift version 5.0 (swiftlang-1<IP_ADDRESS> clang-1<IP_ADDRESS>)

swift package tools-version
5.0.0

System Version: macOS 10.14.4

Package.swift
// swift-tools-version:5.0

import PackageDescription

let package = Package(
    name: "Eigen",
    dependencies: [
        .package(url: "https://github.com/danger/swift.git", from: "0.8.0")
    ],
    targets: [
        // This is just an arbitrary Swift file in our app, that has
        // no dependencies outside of Foundation, the dependencies section
        // ensures that the library for Danger gets build also.
        .target(name: "eigen", dependencies: ["Danger"], path: "", sources: ["DangerRequiresThis.swift"]),
    ]
)

DangerRequiresThis.swift
import Foundation

I hand-edited DangerDSL.swift to make github a var, which let swift build complete with output
[3/3] Compiling Swift Module 'eigen' (1 sources)

but swift run danger edit now yields error: no executable product named 'danger'
Any ideas?

I see there are apparently newer instructions in the README https://github.com/danger/swift/blob/master/README.md#swift-package-manager-more-performant
I then tried Package.swift
// swift-tools-version:5.0

import PackageDescription

let package = Package(
    name: "Stopwatch",
    products: [
        .library(name: "DangerDeps[Product name (optional)]", type: .dynamic, targets: ["DangerDependencies"]),
    ],
    dependencies: [
        .package(url: "https://github.com/danger/swift.git", from: "1.5.2"),
    ],
    targets: [
        .target(name: "DangerDependencies", dependencies: ["Danger", "DangerPlugin"], path: ""),
    ]
)

with this config, swift build creates output
error: target at `MyTarget' contains mixed language source files; feature not supported

Unfortunately the last thing is a marathon issue :(

Ps I think the reason of the first crash was you were using an old version of Danger that was not supporting swift 5.0 :)

I think the reason of the first crash was you were using an old version of Danger that was not supporting swift 5.0 :)

Right, the problem there is that the [getting started guide] says to do that https://danger.systems/swift/guides/getting_started.html#swift-pm

Unfortunately the last thing is a marathon issue :(

Looks like the fix is in their master https://github.com/JohnSundell/Marathon/commit/128e7387b82168c1d3fe86b85ba4bf891387a47f

The swift 5.0 initial support (just to make it compile) was introduced in the version 1.3.0 if I remember correctly.
https://github.com/danger/swift/pull/191
But yes the documentation is still at before we moved to 1.0.0, then the max version you can get with the README config is one before 1.0.0 😁

Looks like the fix is in their master JohnSundell/Marathon@128e738

Nice, but I think he didn't release it yet, because on my branch I updated the dependencies few days ago and didn't see any new Marathon version.
Best option for me would be ask him if is possible to get a marathon release, otherwise I can point master, or better the commit, but I would like to avoid it

I'll just come back and try again once John cuts a Marathon release with the fix in it 👍
thank you!

Anyway I went to update the README and I realised that the README is actually correct, it says from: "1.0.0", but you had from: 0.8.0

Was there any additional thing you had to change to make it work that I should add to the README?

Anyway I went to update the README and I realised that the README is actually correct, it says from: "1.0.0", but you had from: 0.8.0

0.8.0 is in https://danger.systems/swift/guides/getting_started.html#swift-pm

Oh ok we need to update the website then!
Thank you :)

Was there any additional thing you had to change to make it work that I should add to the README?

Grant write permissions on the Cache directory
Delete
         // Danger Plugins
        .package(url: "https://github.com/username/DangerPlugin.git", from: "0.1.0") // dev
        ...

Add a name property to Package.swift
Add sources to the .target in Package.swift
I'd recommend providing a Package.swift file that works verbatim.

mmmm few notes
if I delete
.package(url: "https://github.com/username/DangerPlugin.git", from: "0.1.0") // dev

It actually removes the example on how import an external SPM plugin on Danger.
I can add some links to example Dangerfiles, like the one you found.
The cache directory should be on your ~ folder, then you should have access to it

Closing because Marathon is updated and the doc in the website was updated ad well


How can I identify which PCR bank is being used?

Hi,
I try to find out, which PCR Banks are use on some of our computer (Windows 10 Enterprise with 1909 update).  The registry field TPMActivePCRBanks have the following values:
Computer 1 value: 1 (hex)
Computer 2 value: 3 (hex)
The article goes on with:

Defines which PCR banks are currently active. (This value should be interpreted as a bitmap for which the bits are defined in the TCG Algorithm Registry Table 21 of Revision 1.27.).

When I look at table 21 in the linked document, I see the followin information:

6.10 Hash Algorithms Bit Field
This table defines a bit field to concisely convey a set of hash algorithms. An example of where
this could be useful is a parameter returning the set of hash algorithms an interface supports.
Table 21 — Definition of (UINT32) TPMA_HASH_ALGS Bits
Bit Name Action
0 hashAlgSHA1 SET (1): indicates the SHA1 hash algorithm
CLEAR (0): does not indicate SHA1
1 hashAlgSHA256 SET (1): indicates the SHA256 hash algorithm
CLEAR (0): does not indicate SHA256
2 hashAlgSHA384 SET (1): indicates the SHA384 hash algorithm
CLEAR (0): does not indicate SHA384
3 hashAlgSHA512 SET (1): indicates the SHA512 hash algorithm
CLEAR (0): does not indicate SHA512
4 hashAlgSM3_256 SET (1): indicates the SM3_256 hash algorithm
CLEAR (0): does not indicate SM3_256
31:5 Reserved Shall be zero

I don't know how this table help me to find out which PCR bank is being used?
Or is it so simple that I convert the HEX value into a binary number and use the bits to read which PCR Bank is active?
Example:
HEX 3 =  0011 = PCR Bank 0 and 1 active?
Best regards
Ingo Weidner
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e3ef76ba-7de8-11f1-f5aa-fc8b35d2c83e
Version Independent ID: 27cc94ab-ee9d-39e0-c11b-dc32e576a0aa
Content: Understanding PCR banks on TPM 2.0 devices (Windows 10) - Microsoft 365 Security
Content Source: windows/security/information-protection/tpm/switch-pcr-banks-on-tpm-2-0-devices.md
Product: w10
Technology: windows
GitHub Login: @DulceMontemayor
Microsoft Alias: dansimp

Hello, @-
The issue is under investigation and you will be notified with any changes on the way.
Thank you for providing feedback.

@iweidner Hello Ingo, you are correct with your reasoning. In my case the HEX Value is 2 so i only have PCR Bank 1 active, meaning hashAlgSHA256.
This is confirmed also by looking at the value of "TPMDigestAlgID" which is in my case 0x0000000b which translates to "the SHA 256 algorithm" according to the TCG_Algorithm_Registry_Rev_1.27_FinalPublication.

The issue is being closed as the original question have been answered via the above comment. Thank you.


Imanee 33 unexpected results test

Detected some unexpected return values detected
1) Imanee\Tests\GDResourceTest::testLoadColourFailsWithBadInput with data set #0 ('AABBCCDD')
Imanee\Exception\InvalidColorException: Color 'AABBCCDD' is not supported use a HEX color or the name of a common color

/vagrant/imanee/src/ImageResource/GDPixel.php:65
/vagrant/imanee/src/ImageResource/GDPixel.php:41
/vagrant/imanee/src/ImageResource/GDResource.php:104
/vagrant/imanee/tests/ImageResource/GDResourceTest.php:80

2) Imanee\Tests\GDResourceTest::testLoadColourFailsWithBadInput with data set #1 ('foobar')
Imanee\Exception\InvalidColorException: Color 'foobar' is not supported use a HEX color or the name of a common color

/vagrant/imanee/src/ImageResource/GDPixel.php:65
/vagrant/imanee/src/ImageResource/GDPixel.php:41
/vagrant/imanee/src/ImageResource/GDResource.php:104
/vagrant/imanee/tests/ImageResource/GDResourceTest.php:80

3) Imanee\Tests\GDResourceTest::testLoadColourFailsWithBadInput with data set #2 ('#1234567')
Imanee\Exception\InvalidColorException: Color '1234567' is not supported use a HEX color or the name of a common color

/vagrant/imanee/src/ImageResource/GDPixel.php:65
/vagrant/imanee/src/ImageResource/GDPixel.php:41
/vagrant/imanee/src/ImageResource/GDResource.php:104
/vagrant/imanee/tests/ImageResource/GDResourceTest.php:80

Missed the exception during the raffle


Add test coverage

Add analysis and reporting of our test coverage, so we can identify code which isn't being exercised by the test suite.

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@3e92f02). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #571   +/-   ##
=======================================
  Coverage        ?   67.89%
=======================================
  Files           ?       13
  Lines           ?      788
  Branches        ?       71
=======================================
  Hits            ?      535
  Misses          ?      244
  Partials        ?        9

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Refactor reconciler container to use controller-runtime framework

The reconciler container has a parser running in the main thread, a remeidator running in a separate goroutine, and a Kubernetes controller manager for the finalizer running in another goroutine.
This commit refactors it to use the controller-runtime framework. After the change, the main process just starts the Kubernetes controller manager. Three controllers are registered to the manager:

Syncer: read, parse, validate, apply source configs to the cluster, and start a watcher for the GKNN of each declared resources.
Remediator: watch for the remediate event and correct dirft.
Finalizer: manage the lifycycle of R*Sync's finalizer and finalizing condition, and garbage-collect the managed resources.

We decided to punt on the refactor after 1.17.0.


Update gitlab to the latest version

Thank you for wanting to submit a Pull Request to the Civo Kubernetes Marketplace repository!
If your pull request concerns an existing Marketplace application, please make sure you have:

[ ] Notified the Maintainer of the application in this pull request so that they are aware of your proposal.
[x] Outlined the changes you are proposing, and the reasons these are required (e.g. stability, compatibility with new versions of Kubernetes implementations, etc).
[x] Tested that the application works with the proposed updates applied.
[x] Updated the version number of the app if that has changed.

Im approving, Do test this in production


Adding support for Umbraco version 8

Updated cache clear composer to use v8 syntaax
Updated extensions to use v8 syntax
Updated content provider (had to reference Umbraco.Web here to get access to IUmbracoContextFactory, need v8.1.0 to get access to UrlMode enum)
Upgraded UmbracoSample project to Umbraco version 8.1.0 and updated Sitemapify setup
Updated dependencies to Umbraco >= v8.1.0 and <= 9.0.0
Updated docs to show new Umbraco 8 implementation

@alanwthom - will this update remove support for Umbraco v7? - I assume this isnt able to be backwards compatible?
If this is the case then we should clearly bump the major version and indicate via docs which package version will be needed for each Umbraco version

Hi @Philo
Yes, this would be a breaking change which would only support Umbraco v8.1+. The existing 0.5.2 version would be required to support Umbraco v7.0-7.15.
I'll update the docs an push an update later on today.


Improve igsn-ev-json-ld REST API performance

IGSN-EV-JSON-LD rest api takes more 5s. We need to improve the performance for interoperability.

Done. Confirmed by the user.


Add a ECMAScript-2024 strem parser

We need to start the project with a stream, SAX-like parser in a crate.parser.rules module.

Edit: flatter crate.stream_parser instead of crate.parser.rules will look better in the documentation.

Another edit: crate.parser instead of crate.stream_parser.


Mapping Entrance Pupil Position from ARRI camera files

This is delayed because ARRI has not yet made available a command-line tool that extracts metadata info from MXF files conformant to RDD 55. Pre-RDD 55-conformant ARRI camera output does not carry either Entrance Pupil Offset or Effective Focal Length. As soon as a capable tool is available on the ARRI site I will post a link in this Issue thread.


Update Favicon and Add Icon as a splash screen to Project

Task

Update the favicon and site/app icon using the existing assets in the project.
Implement a splash screen for the application.

Implement a Splash Screen

Create a splash screen that utilizes the existing icon.
Ensure it is displayed when the app is launched, enhancing user experience.
Update the appropriate configuration or code to implement the splash screen.

Hey @MUDITJAINN
im interested to work on this issue but have some doubts first
are we supposed to make a new icon and use it for the favicon
or you'll be providing the icon?

Hey @MUDITJAINN can you assign this issue to me,I have a potential solution in my mind to solve this issue.

@prashantrai-30 icon and favicon are already included in the project.

@MUDITJAINN i asked for the issue first?
Shouldn't i be assigned to it?

@hemangtk, you can also work on the same task. The person who completes the task correctly and on time will be accepted.

Hey @MUDITJAINN just a quick question should the favicon be this ayurveda-gpt-favicon-black.png or favicon.ico
please cralify.
thank you!!

Heyyy @MUDITJAINN , I saw that this issue has been open since three weeks; if it is still fixable, may I be provided the opportunity to implement the required changes?


".input-group-addon" results in thick border when used between two inputs

Take this piece of code, for example. The width of the right and left border on the input-group-addon are two pixels, while they should be one.

  <input type="text" class="form-control" >
  Hello
  <input type="text" class="form-control" >

I know this was discussed some time ago, but I'm posting here to avoid opening unnecessary new issue since it's just curiosity: why the decision to not support multiple controls in input groups?

@heruan Hey man, I just stumbled in this thread. Here's why I think it was designed this way with some pseudo code it took me about 10 minutes to write. [codepen]
It can be markup heavy sure, but you can write that stuff pretty quick. It also deals with a lot of specific needs while being generally useful for common use cases. You can set up server side templates of this pretty easily too in my experience.
Let me know if you have a difference in opinion, i'd love to hear you out.

Hi @zackmorgs!
You appear to have posted a live example (http://codepen.io/zmorgenthaler14/pen/KzojOo.html), which is always a good first step. However, according to the HTML5 validator, your example has some validation errors, which might potentially be causing your issue:

line 15, column 7 thru column 51: Duplicate attribute type.
line 20, column 7 thru column 51: Duplicate attribute type.
line 25, column 7 thru column 51: Duplicate attribute type.
line 14, column 7 thru column 45: The for attribute of the label element must refer to a non-hidden form control.
line 19, column 7 thru column 45: The for attribute of the label element must refer to a non-hidden form control.
line 24, column 7 thru column 45: The for attribute of the label element must refer to a non-hidden form control.

You'll need to fix these errors and post a revised example before we can proceed further.
Thanks!
(Please note that this is a fully automated comment.)


NOISSUE - Add provisioning scrip

Signed-off-by: drasko<EMAIL_ADDRESS>

@jduranf whoops, I saw the review just now, sorry I missed it. I'll amuse myself with it over the weekend ;). Thanks!


[KeyVault-Certificates] Tweaks on CertificateIssuer

Fixes #6257

I might need to re-record some tests.

Ideally, hopefully not 🙂 - unless you were sending created and updated dates back. The model shapes might've changed, but the REST body shouldn't have.

@heaths yup I think I was sending these properties by mistake!

@heaths oh, it wasn't that, I was checking the value of the provider at the root level of the issuer :p oops.

@heaths I had to re-record, we were sending unnecessary properties!


[DOCS 📄] Page link to icon

Description

Currently on clicking the icon of README.md, it opens the icon itself.
The link tag must be fixed to redirect to the original deployed Nike website.

Screenshots

Additional information
No response

@warmachine028 @AdityaAB4 @vaqueraoscar0 @ayushichoudhary-19 @Sky-De  can I work on this issue? Assign me

Sure, you can work on it.

@warmachine028 can I work on this issue? Assign me

@Anirudha0702 someone is already working on this issue, see if you can find other ways to contribute. Then raise a new issue

I have assigned you both


Hold mode during landing leads to the vehicle dropping down

When flying a mission during land mode I tried to put the vehicle in hold mode. That lead to the vehicle falling down by about 5 meters and after that recovering back to the alt it should have been. Almost felt like throttle integrator was to zero.
Explanation: The altitude setpoint during landing is way off the current altitude (because descend velocity is limited). Once we switch into hold the altitude setpoint is not reset but has to come up again first.

Log: http://logs.uaventure.com/view/s7Lnr8CYrvuRk887Qki876

So entering hold should reset the alt SP immediately?

@LorenzMeier Yeah, I would say so.

@LorenzMeier I think this should be reproducible in SITL.

@tumbili Can you look into this tomorrow?

@tumbili This is fixed on master. Please re-test outdoors, SITL looked good.