Question: getting vbucket partition map

Is there a way to get the Map of pindex -> vbucket from cbgt?
Is that static?  When does that change?

If you know the name of the PIndex (with that hash suffix), then you can call...
http://godoc.org/github.com/couchbaselabs/cbgt#Manager.GetPIndex

Or, if you want all PIndexes, you can call...
http://godoc.org/github.com/couchbaselabs/cbgt#Manager.GetPlanPIndexes

Either way will eventually get you to a PIndex struct or a PlanPIndex struct that has a SourcePartitions field.  The SourcePartitions is a string that's a comma-separated list of vbucket ID's for that PIndex.
The PIndex struct is pretty much static, where an index is split or partitioned into multiple PIndexes at the creation/definition time of the index.
The PlanPIndex is dynamic, and represents the assignment of a PIndex to nodes.  It changes whenever the node topology changes and the planner decides to move or reassign a PIndex amonst nodes.

It changes whenever the node topology changes and the planner decides to move or reassign a PIndex amonst nodes.

In our testing, we've been able to add Sync Gateway nodes and have have the Pindexes spread to the new node.  What about removing Sync Gateway nodes?  Is there a way we can tell CBGT "Hey, we're going to go away, reassign my Pindexes to other nodes"?

In our testing, we've been able to add Sync Gateway nodes and have have the Pindexes spread to the newly added node.

Very cool!  Exciting!

What about removing Sync Gateway nodes? Is there a way we can tell CBGT "Hey, we're going to go away, reassign my Pindexes to other nodes"?

Yep, please see response on other issue here: https://github.com/couchbaselabs/cbgt/issues/22

I'll give it a shot, thanks!


feature(linear-progress): add component

Closes #411

Codecov Report

Merging #425 into master will increase coverage by 0.13%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #425      +/-   ##
==========================================
+ Coverage   96.09%   96.22%   +0.13%
==========================================
  Files          53       54       +1
  Lines        1819     1883      +64
  Branches      214      222       +8
==========================================
+ Hits         1748     1812      +64
  Misses         71       71

Impacted Files
Coverage Δ

packages/linear-progress/index.js
100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a468f02...b1536bb. Read the comment docs.

Nice! I'll take a look in a bit.

When you let me know which branch the actual target branch is (I am assuming it's not master) then I will rebase and sort out this package-lock.json conflict.

@hvolschenk it should be rc7.0. We're targeting November 20

@hvolschenk I think I may have figured out how to do the screenshot tests. There is a CSS property that can pause animations. Please see:
Pausing CSS animations for screenshot tests:

https://github.com/material-components/material-components-web/blob/7b3942b350c31a303fe30f73a86afbe153b437f3/test/screenshot/spec/fixture.scss#L161-L169
https://github.com/material-components/material-components-web/blob/7b3942b350c31a303fe30f73a86afbe153b437f3/test/screenshot/spec/mdc-linear-progress/classes/baseline.html#L43

I think you'll be able to copy what MDC Web has implemented, and get a similar screenshot test suite for linear progress.

@moog16 I have addressed the comments. Thanks for the feedback, always appreciated. Please have a look when you get a chance.

100% coverage! nice!

Please sign the PR

I signed it

#443 tests passing. Merging!

Thanks @hvolschenk!!


Better documentation

Inline code documentation could benefit users, including you, to help read understand and use your code.
I suggest to use JSDoc
https://github.com/jsdoc3/jsdoc
Also the tutorials / demos need more example codes.
eg. couldn't find the usage code for Track Section Demo
Thank you for this nice plugin.
Previously I played with jQuery.inView and Waypoints with Inview plugin.

Currently this project uses Docular (http://grunt-docular.com/) for documentation generation - but I am slightly annoyed by it. I may consider switching to jsdoc - thanks for the suggestion.
You are absolutely right - the tutorial needs better descriptions and more code examples.
The thing is, the examples are all very simple and basically the "Track Section Demo" is the same as "Draggable Element Demo" - but I will definitely add more stuff when I have time.
One thing though:
"Inline code documentation could benefit users, including you, to help read understand and use your code." -> do you think the documentation is still unsufficient?
Nonetheless, thanks for your comment.

Yes, for first time users needs the basic documentation.
And by experience you will need a refresh if you dont touch the code after a while.
Took some time to figure out public events, functions, passed arguments to callbacks.
from the non-minified source code.
Your demos are excellent, shows what's possible to achieve with the project.
Glad to help if I can. Good luck with the documentation to help new users replicate your demos.
I liked Waypoints documentation, it was easy and didn't had to look into their source code.
http://imakewebthings.com/waypoints/
http://imakewebthings.com/waypoints/shortcuts/inview/

Waypoints web docs are pretty nice - I'll consider it as a role model for the demo page. Thank you.
Anyway, if you have time and resources I'd be happy to invite you to fork https://github.com/vissense/vissense-demo and add some examples or missing pieces yourself.
This, of course, should not mean that you are obligated to do so, but I'd really love to see what other devs are creating with it. Maybe it's something I never had in mind!

Thanks for your invitation:) forked


Can't figure out how to test using Enzyme.

Is it possible to test React-Responsive components with Enzyme.
the key parts of my code look like this:
export default class AppContainer extends React.Component {
  render(){
    return(
      <MediaQuery minDeviceWidth={750}>
         <Header />
      </MediaQuery>
    );
  }
}

describe("App", () => {
  let App;
  let wrapper;
  beforeEach(() => {
    wrapper = mount(<Provider store={store}><AppContainer location={location} /></Provider>);
    App = wrapper.find(AppContainer);

  });
  it('to have a <Header /> component', () => {
    console.log(App.debug());
    expect(App.find(Header)).to.have.length(1);
  });
}

The test result is:
1) AppContainer to have a <Header /> component:
AssertionError: expected { Object (component, root, ...) } to have a length of 1 but got 0

The relevant part of the output of the console.log is:
<MediaQuery minDeviceWidth={750} values={{...}} />
Indicating that Header is indeed not appearing in the render tree.  However if I remove the MediaQuery and make Header a direct child of AppContainer the test passes.
I imagine this is not a bug as I'm very new to Enzyme and testing components in general.  Any help or examples would be appreciated.

Not familiar with Enzyme so have a few questions:

Is this actually being executed in a browser?
Is the device width >= 750?

That's a really good question.  I'm using jsdom.  The value of window.innerWidth is 1024.  I'm not sure if MediaQuery is picking that up though.

What does window.matchMedia say in jsdom?

It's returning undefined

@domhede So yeah, since your test environment isn't a real browser I guess this won't work. It's really doing serverside rendering with a fake DOM, so you would have to follow the instructions for serverside rendering in the README.

@contra Thank you so much for your help.  I did not know about matchMedia.
I now have this:
<MediaQuery minWidth={mediumViewMinWidth} values={{width: window.innerWidth}}>
Not sure if this is a good idea though.  The README says I need to use a static value.

I was informed that by using window.innerWidth that would not be consistent with MediaMatch.
New method is in the test setup, set a global variable: testMediaQueryValues.
ie.
window.testMediaQueryValues = {width:740};
Then
<MediaQuery maxWidth={smallViewMaxWidth} values={window.testMediaQueryValues}>
Seems to be working well with the tests.
When not running as test env (in real browser) the global is not there so it just runs with it's regular responsive goodness.

Great! Glad I could help.

Maybe someone will find it useful, I'm doing it with Rewire:
import MediaQuery from 'react-responsive';

const rewireMediaQuery = props => {
  MediaQuery.defaultProps = props;
  Layout.__Rewire__('MediaQuery', MediaQuery);
};

Then use as:
rewireMediaQuery({
    values: { width: 800 },
});

Each test has afterEach
afterEach(() => {
     Component.__ResetDependency__('MediaQuery');
});

Try mocking the react-responsive dependency in you unit test. Working with Webpack, I'm using "inject-loader" for injecting test dependencies to modules. You can import your component using "inject-loader" and pass it which dependencies you want to overwrite.
Example:
import YourComponentInjector from 'inject-loader!../YourComponent.jsx';

and then
class MediaQueryDesktopMock extends React.Component {
    render() {
      const {minDeviceWidth, children} = this.props;
      if(minDeviceWidth === 765) {
        return (<div>{children}</div>)
      }
      return <span/>;
    }
  }
  let YourComponentMock = YourComponentInjector({
    'react-responsive': MediaQueryDesktopMock
  });

you can then test for specific media queries


Skip freeze_time tests in server mode

Skip tests that use freeze_time when testing server mode. This is because freeze_time is unable to affect the time on the external server process, which makes the tests fragile and liable to incorrectly fail on a time comparison

Coverage decreased (-0.2%) to 92.206% when pulling 5db512cfa0e2b009ba2e2e17e2dc751f826f2fe5 on garyd203:skip-freeze-time into 2e5e7e7f5ea7347da632eb7dcab3c588fec25a9e on spulec:master.

Coverage decreased (-0.2%) to 92.206% when pulling 5db512cfa0e2b009ba2e2e17e2dc751f826f2fe5 on garyd203:skip-freeze-time into 2e5e7e7f5ea7347da632eb7dcab3c588fec25a9e on spulec:master.

Other than those changes, this looks good. @JackDanger 2nd opinion

Thanks @terrycain, I have stripped out those duplicate checks now

hi @terrycain, is there anything else we need to do to get this change accepted? Ta!

Hi @terrycain Are we able to merge this PR now?

I'm a little worried about this. There are legitimate differences between server-mode and non-server mode and I'm worried about the loss of coverage here.
Is there another approach? Setting the time to freeze as an environment variable or something?

There have been a lot of updates to the codebase since this was opened, including a move from nosetests (upon which this new @skip_in_server_mode decorator had been based) to pytest.  Most of the tests that use @freeze_time have had explicit TEST_SERVER_MODE checks added over the years, which obviates the need to try to bring this PR up-to-date and fix the long list of now-conflicting files.

Thanks @bpandola 👍


Distance from hash

What's Changing and Why
Calculate distanceFromHash
closes #299
What else might be affected
nothing
Tasks

[x] Add tests
[x] Update Documentation
[x] Update jimp.d.ts
[x] Add SemVer Label

I think this API could be made even more reusable by allowing to pass two arguments :
something like this :
const hash1 = image1.pHash();
const hash2 = image2.pHash();
compareHashes(hash1, hash2);

This way, if for example you have 100 images and you want to compare them "all together" to remove duplicate or similar images, you have to compute the hashes only once.
Does this make sense ?
I don't know exactly how we can expose this.

@edi9999 that makes sense. I have added the compareHashes function/


rename monokai to monokai-pro, add mariana and monokai from Sublime

the monokai color scheme has had many derivites and changes over the years.
Renamed the monokai to monokai-pro
Added Monokai and Mariana themes from Sublime Text 4
styles are from this commit https://github.com/Jan200101/lite-lime/commit/ba8c5fa0438f110db6e962e8b94c128a6b53ec71
Comparions to their Sublime counterparts
Mariana

Monokai

Monokai-Pro

The theme you call monokai-pro looks to me like Monokai Pro's "Classic" variant, which isn't the same as Monokai Pro's default variant. See: https://monokai.pro/vscode

The theme you call monokai-pro looks to me like Monokai Pro's "Classic" variant, which isn't the same as Monokai Pro's default variant. See: https://monokai.pro/vscode

I am aware, but what do you suggest?
Renaming it to monokai-pro-classic?

That would make the most sense to me, but I see why you want the name to be monokai-pro – we don't have any of the other Monokai Pro variants available.
In my opinion we should keep the theme names in line with what they are called by their authors, such that they're easily discoverable and don't confuse users (eg. if they'd expect our monokai-pro to be the Monokai Pro, which it isn't.)

An alternative would be to add a Notes column to the table of themes, that could include additional info like a link to the original theme, as well as differences like this one if we choose to keep the monokai-pro name.


Provide a list of previously-used contexts, with ability to choose one

Would be nice to not need to copy and paste the context from a previous thread (if you want to use the same context, but in a different thread).
Maybe SlickGPT could provide a library of context "templates".

Great idea. As a workaround you can:

create a chat
just add the context
Share the chat
open then Share link
import the shared chat.

It will create a copy with the old name and settings (like the model, so this is also a workaround for #25).
We should definitely make this easier and better, though.

Great idea, thanks!


Adding new language Hungarian Beta

Adding a new translation Hungarian (beta)

Hello @ctlaltdieliet,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

Building app in separate branch.

Thanks!
@ctlaltdieliet could we use this same approach for English-Australian? https://github.com/mattermost/mattermost-mobile/pull/5237/files

No, the same approach cannot be used.


simplifying member param check in Member::canDelete

the member param check in Member::canDelete seemed overly complicated.

In some older parts of the code, can* methods sometimes allow the member ID to be passed in. We can't remove this behaviour except on the master branch.
Want to open it there instead?

You could proabably even use instanceof if you wanted to avoid the literal classname. :D

Sorry @sunnysideup :D I'm always finding a way to make things hard eh? :P

No, sorry, I forgot to choose the right branch.
In any case...
I am having a look at the canDelete (and canEdit / canView, etc...) for Member and DataObject.
There are a couple of things that I reckon need attention:

there seems to be a lot of repeat of code

Member:

DataObject:

as you can see, this is basically the same thing.  There are two issues:
a. if it is exactly the same thing, we should just rely on DataObject::extendedCan for both classes.
b. if it is not exactly the same thing, then it is confusing and messy.
I notice that The extendedCan method in the DataObject only use a member if a one if provided, while the canMethod extensions in Member use the Member::currentMember() and pass that to the extended canMethod methods (ha ha ha ha... ok, I hope that sentence makes sense).

in Member, canDelete relies on canEdit, and canEdit relies on canView - is this standard? It seems dangerous, because, for example, if you extend the canView method in a DataExtension then this has a direct influence on the canDelete method for the member.

All in all, it seems to me that these canMethods need to be simplified and/or standardised to improve Security of any code that interacts with or extends these methods.

@tractorcow what do you think about comments above?

a. if it is exactly the same thing, we should just rely on DataObject::extendedCan for both classes.

Right, let's do this then. :dancer:

in Member, canDelete relies on canEdit, and canEdit relies on canView - is this standard? It seems dangerous, because, for example, if you extend the canView method in a DataExtension then this has a direct influence on the canDelete method for the member.

I think it's a risk, yes. We probably shouldn't fall back to canView(). Maybe change it in 4.x?


I put my Closing Tags but in the objectives it says I am not doing it

Challenge Nest Many Elements within a Single Div Element has an issue.
User Agent is: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/58.0.3029.110 Safari/537.36.
Please describe how to reproduce this issue, and include links to screenshots if possible.
My code:

<link href="https://fonts.googleapis.com/css?family=Lobster" rel="stylesheet" type="text/css">

CatPhotoApp

Click here for cat photos.

Things cats love:

cat nip

laser pointers

lasagna

Top 3 things cats hate:

flea treatment

thunder

other cats

</Div
<form action="/submit-cat-photo">
  <input type="radio" name="indoor-outdoor" checked> Indoor
  <input type="radio" name="indoor-outdoor"> Outdoor
  <input type="checkbox" name="personality" checked> Loving
  <input type="checkbox" name="personality"> Lazy
  <input type="checkbox" name="personality"> Energetic
  <input type="text" placeholder="cat photo URL" required>
  <button type="submit">Submit</button>
</form>

Check your closing "/DIV" tag.

@Pistonsfan101 Thank you for reporting this issue. Check your closing
 tag as it was hinted above.
This is a standard message notifying you that this issue seems to be a request for help. Instead of asking for help here, please click the "help" button on the challenge on freeCodeCamp, which will take you to the help chatroom for that specific challenge. You can also view our full list of official chatrooms.
If you think I'm wrong in closing this issue, please reopen it and add further clarification. Thank you, and happy coding!


Question: How to use K3s with NAT and host only network in Virtualbox

Hello, I tried to set up K3s + Rancher in a VirtualBox VM. The Guest is a Debian 10 OS and I have NAT as first network adapter and host only as second. But if I start K3s it uses only the NAT interface by default and its not possible to access traefik or use any port mapping like host port or node port. The services are not accessible even from inside the VM or any other network assigned to it. I see the following behavior:
Opening IP of VM in browser (to connect to traefik): tries to connect until it times out
Curl inside VM with localhost and port 80: same
Curl with NAT IP and port 80 inside of VM: works.
I tried the different IP related parameters as described in the K3s server docs, but it doesn't help. I can set up Rancher and see the host only IP in the UI used as the default node IP, but port mappings for services still seem to use anything else. The weird thing is that I can reach the services from inside the VM with its host only IP, but not with any other (even localhost?!) and not from outside (host). Is there anything I have to change in my install parameters or if not is there any good workaround for that?

It looks that you assigned a wrong type of network interface for this VM. What you are looking for is "bridge" type. Nothing to do with k3s. NAT behaves exactly the same way as your router NAT. It is only one-way access, and I don't know enough of VirtualBox to know if  there is a "port forwarding" feature in it. Try bridge.  Of course, I could be wrong, as it happens once a year.
https://www.virtualbox.org/manual/ch06.html#:~:text=Use the VM's Settings dialog,down list of networking modes.

Yes, you cannot access pods from outside the cluster when using flannel - they're on virtual interfaces with private addresses. This is normal.

@bodzio4749 Yes, VirtualBox has port forwarding for NAT. But I never used it before. And bride network isn't a solution in my case because of restrictions in my workplaces network.

@brandond Sorry, I edited my question because it was not clear what I mean. I don't mean that I can't access the pods with its cluster IP. The problem is that all mapped ports like mode port or host port can only be accessed from within the VM by using the NAT interface IP.

The best way to do this would be to use a single adapter in bridged mode. If you can't do that, I would use a single adapter in nat mode, and go into the advanced settings in the VM network configuration and set up port forwards to the ports you're using in k3s.

Or you could have a router vm which does nat and provide an internal network to the k3s vms...

Hmm, I tried following on Debian 10: NAT Network with port Forwarding for 22 and 80. I tried to connect to ssh - no problem. But traefik and K3s stuff is still not accessible from any IP. Even in the VM itself. Is this an expected behaviour for K3s? Or could this be a possible bug? It seems like something unexpected because all Kubernetes services seems to be bound ONLY to the IP used for NAT.

Sorry, I didn't saw that Debian Buster isn't supported because of nftables.

Even with a router vm you still need to forward ports from the host if all you can do is NAT due to corp network restrictions...

Thank you very much for your advices! On Ubuntu everything works fine, even with host only network.


Consider removing class constraint for IVectorizer

Hi.
So I have some types which have their own precomputed embeddings, for example, a PDQ hash. I have implemented these data structures using structs in my code. I have no facility however to be able to use Redis OM for these types.
I tried implementing a custom Vector (and re-implement Vector<T>) without the class constraint but there is an internal prop which I can't override due to it's accessibility.
If I could re-use the existing Vector<T> without the class constraint, I can then build my own vectorizer attributes to extract the relevant embeddings as needed.

Hi @abbottdev,
You're really supposed to have a IVectorizer<T> actually do the work of embedding the T in your Vector<T>, so I'm not entirely sure why you would need a non-generic version of Vector, if you really did though, you could always just implement the abstract class and ignore the object, dropping your embedding directly into it's place.

@slorello89  - It doesn't need to be non-generic, what I'm saying is that I'm working with structs due to performance reasons I can keep allocations on the heap to a minimum that way - unfortunately as the type constraint on Vector<T> has a class constraint I'm unable to use it:
https://github.com/redis/redis-om-dotnet/blob/cd8919a9052affdf60cf22504864b3cdd4d8f708/src/Redis.OM/Vector.cs#L55C1-L56C20
I tried to implement the base abstract class, but unfortunately there is aObj variable that's defined internally that I'm unable to override, which means I can't implement the base abstract class:
https://github.com/redis/redis-om-dotnet/blob/cd8919a9052affdf60cf22504864b3cdd4d8f708/src/Redis.OM/Vector.cs#L26C1-L30C1


AdditionZ seems to be incompatible with connector

Mod Name
AdditionZ
Mod Homepage
https://modrinth.com/mod/additionz
Describe the bug
Game crashing before main menu
Steps to reproduce
No response
Logs
https://gist.github.com/Its-Just-Luci/25d69f64040dea549e412c277a93a112
Additional context
No response

It also crashes with Dehydration mod and Environment Mod

Crashes on beta 28


Can't get file to play

I'm very new to Xcode and react-native. I'm pretty curtain I followed the installation instructions correctly. I'm using a simulator to test the plugin. Here is my code.
import {
Player,
Recorder,
MediaStates
} from 'react-native-audio-toolkit';
import React, { Component } from 'react';
import {
AppRegistry,
StyleSheet,
Text,
View,
TouchableHighlight
} from 'react-native';
class nusiqcom extends Component {
_onPress() {
  new Player("https://mdn.mozillademos.org/files/2587/AudioTest%20(1).mp3").play()

}
render() {
return (
  <View style={styles.basic}>
  <TouchableHighlight onPress={() => this._onPress()}>
    <Text>
      Press me!
    </Text>
  </TouchableHighlight>
  </View>
);

}
}
var styles = {
basic: {
flex: 1,
justifyContent: 'center',
alignItems: 'center'
}
}
AppRegistry.registerComponent('nusiqcom', () => nusiqcom);
I'm not sure where I'm going wrong. I'm using react-native 0.39.0 if that matters. Any help is appreciated. Thank you.

Have you tried other media files, particularly other file formats than mp3?


Wrong env variable

The docs say to use MSSQL_SA_PASSWORD but this is incorrect.  The real variable is SA_PASSWORD.  This is compounded by the container not providing any message about the password being unset.  Instead, you are unable to login as you would expect.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3dc2ec36-4915-f7ab-3104-282acc9321e6
Version Independent ID: fc98af17-f3c5-adff-69ca-593f985e7882
Content: Configuration options for SQL Server on Docker - SQL Server
Content Source: docs/linux/sql-server-linux-configure-docker.md
Product: sql
Technology: linux
GitHub Login: @vin-yu
Microsoft Alias: vinsonyu

@olyoberdorf -- Oliver, thank you for your feedback.  I am looking into this article.

@vin-yu -- Vin, please review private PR 15497.

Hi @olyoberdorf! Thanks for letting us know! We really appreciate it. I have refreshed this article, and the changes should take place next week.
@WilliamAntonRohm - Sorry about the delay. I just saw this issue. Please go ahead and close your PR as my refresh will take care of this.


Attempting GHA release workflow #2

Following #488
Addressing #487

@knaaptime I have implemented your changelog solution, and will simply update the root CHANGELOG.md manually from the release notes in order to keep an easily accessible running history of the project.

Currently failing on my fork due to syntax issues.

@knaaptime I'm banging my head against the wall over here trying to figure out how to properly authenticate the PyPI upload. Can't seem to get to __token__/password/secret format correct as described in the pypi and pypa docs. Here is the current failure from tag v1.5.0.rc10 in jGaboardi/spaghetti. Any help would be awesome.

that token part wasnt online when I set things up so didnt encounter that particular hurdle. Looks like you arent using it in this pr though...
so secrets.PYPI_PASSWORD is case sensitive, so PYPI_PASSWORD needs to be all caps in the spaghetti setttings. Droping that api token stuff means PYPI_PASSWORD should be your password with no prefix or anything. is that how you have it setup now?

that token part wasnt online when I set things up so didnt encounter that particular hurdle. Looks like you arent using it in this pr though...

Maybe I am not understanding tags correctly. I have been tagging my commits and pushing them to origin (git push origin [tag name]) and they are running directly on jGaboardi/spaghetti. The __token__ parameter is in the .yml there. Should I also be pushing the tags to upstream?

so secrets.PYPI_PASSWORD is case sensitive, so PYPI_PASSWORD needs to be all caps in the spaghetti setttings. Droping that api token stuff means PYPI_PASSWORD should be your password with no prefix or anything. is that how you have it setup now?

I believe this is how I have it set up, but GitHub won't allow the editing of secrets (just removal). So the __token__ parameter must be super new. I wonder if the current workflow for geosnap will still work?
At any rate, here is what I will try:

with __token__

remove/reset both secrets in pysal/spaghetti and jGaboardi/spaghetti to make sure they are identical (with the pypi- prefix in the password)
push

drop the api token from .yml

remove/reset both secrets in pysal/spaghetti and jGaboardi/spaghetti to make sure they are identical (without the pypi- prefix in the password)
push

keep in mind i think if you're using option 1

with token
remove/reset both secrets in pysal/spaghetti and jGaboardi/spaghetti to make sure they are identical (with the pypi- prefix in the password)
push

then the PYPI_PASSWORD should be set to the value of the api token (which presumably includes a pypi- prefix)
but if option 2, then PYPI_PASSWORD should be your pypi password

keep in mind i think if you're using option 1

with token
remove/reset both secrets in pysal/spaghetti and jGaboardi/spaghetti to make sure they are identical (with the pypi- prefix in the password)
push

then the PYPI_PASSWORD should be set to the value of the api token (which presumably includes a pypi- prefix)
but if option 2, then PYPI_PASSWORD should be your pypi password

I think this is what I tried first. I will do this again.

@knaaptime This seems to be working for my fork's release workflow now (see pypi version here). It was only successful after generating the PyPI API token, so you may need to update the geosnap workflow for the next release.
After merging this PR, is the next step pushing a tag directly to upstream?

i havent fully tested, but i think yes. Merge this, then push a tag directly upstream. Otherwise, the package will build on your account and push to pypi and this workflow will fail upsream because pypi will reject the package as already existing (which is what happend last on geosnap)


Task output files should be able to change during task execution

When wrapping tools that, given a configuration file, it will output a set of files that aren't known ahead of time but won't change for the same input.
Expected Behavior

A task should be able to change the output file collection. The change should be considered during the snapshot after execution.
Current Behavior

Gradle saves the output file collection result before execution (most likely during output overlapping calculation) and snapshot this saved file collection after execution. It effectively makes the task out-of-date at least once after an execution.
Context

A concrete example is yarn install. Assuming the package.json resolve to fixed dependency version, all the files present in node_modules after a clean yarn install are the output of the task in question. Any change to this baseline of files will require a new install. However, any new files (because of in directory build/file generation) won't require a new install and the task should be considered up-to-date. The output files can be tracked via a snapshot file generated at the end of the task execution that lists all the files present after a fresh install. The snapshot file is not of interest but the content of the files listed in that snapshot file is.
Steps to Reproduce (for bugs)

Here is a patch of an integration test showing this behaviour:
diff --git a/subprojects/core/src/integTest/groovy/org/gradle/api/internal/changedetection/state/UpToDateIntegTest.groovy b/subprojects/core/src/integTest/groovy/org/gradle/api/internal/changedetection/state/UpToDateIntegTest.groovy
index a700fc19ec1..20db0cecfcb 100644
--- a/subprojects/core/src/integTest/groovy/org/gradle/api/internal/changedetection/state/UpToDateIntegTest.groovy
+++ b/subprojects/core/src/integTest/groovy/org/gradle/api/internal/changedetection/state/UpToDateIntegTest.groovy
@@ -16,6 +16,7 @@

 package org.gradle.api.internal.changedetection.state

+
 import org.gradle.integtests.fixtures.AbstractIntegrationSpec
 import spock.lang.Issue

@@ -123,4 +124,102 @@ public class CreateEmptyDirectory extends DefaultTask {
         skipped customTask
         result.output =~ /Skipping task '${customTask}' as it is up-to-date\./
     }
+
+    def "can modify the output files listing during execution"() {
+        buildFile << '''
+            task customTask(type: CustomTask) {
+                dependencies.put("foo", "foo")
+                dependencies.put("bar", "bar")
+            }
+
+            class CustomTask extends DefaultTask {
+                @OutputFiles
+                FileCollection outputFiles = project.files(project.provider {
+                    if (!project.file("$temporaryDir/snapshot.txt").exists()) {
+                        return []
+                    }
+                    return project.file("$temporaryDir/snapshot.txt").readLines().collect {
+                        new File(it)
+                    }
+                });
+
+                @Input
+                Map<String, String> dependencies = [:]
+
+                @TaskAction
+                void doStuff() {
+                    def s = project.file("$temporaryDir/snapshot.txt")
+                    s.delete()
+                    project.file("$temporaryDir/node_modules").delete()
+
+                    dependencies.entrySet().each { e ->
+                        project.file("$temporaryDir/node_modules/${e.key}.txt").with {
+                            it.parentFile.mkdirs()
+                            it.text = e.value
+                            s << it.absolutePath + "\\n"
+                        }
+                    }
+                }
+            }
+        '''
+        def customTask = ":customTask"
+
+        // TEST 1
+        when:
+        println("TEST #1: Clean execution")
+        run customTask, "--info"
+        then:
+        executedAndNotSkipped(customTask)
+
+        when:
+        // HACK: Needs to run the task another time to make it up-to-date
+//        run customTask, "-i"
+        println("ENSURE UP-TO-DATE")
+        run customTask, "-i"
+        then:
+        skipped(customTask)
+
+        when:
+        println("TEST #2: Mess around with known outputs")
+        file("build/tmp/customTask/node_modules/foo.txt").delete()
+        run customTask, "-i"
+        then:
+        executedAndNotSkipped(customTask)
+
+        when:
+        println("ENSURE UP-TO-DATE")
+        run customTask, "-i"
+        then:
+        skipped(customTask)
+
+        when:
+        println("TEST #3: Change input which cause more output")
+        buildFile << '''customTask.dependencies.put("g", "g")\n'''
+        run customTask, "-i"
+        then:
+        executedAndNotSkipped(customTask)
+
+        when:
+        // HACK: Needs to run the task another time to make it up-to-date
+//        run customTask, "-i"
+        println("ENSURE UP-TO-DATE")
+        run customTask, "-i"
+        then:
+        skipped(customTask)
+
+        when:
+        println("TEST #4: Change input which cause less output")
+        buildFile << '''customTask.dependencies.remove("foo")\n'''
+        run customTask, "-i"
+        then:
+        executedAndNotSkipped(customTask)
+
+        when:
+        // HACK: Needs to run the task another time to make it up-to-date
+//        run customTask, "-i"
+        println("ENSURE UP-TO-DATE")
+        run customTask, "-i"
+        then:
+        skipped(customTask)
+    }
 }

Your Environment

Build scan URL:

@lacasseio Gradle assumes that the location of the output files is fixed when the task starts to execute. The location of the output files is the configuration of the task. So these locations should not change during task execution and Gradle fixes the locations when it takes a snapshot of the outputs before execution.
Regarding your use-case of taking a snapshot of a directory and then considering only the new/changed files as outputs of the task: This is already done automatically by Gradle, so there is no need to add some custom code. More precisely, before the task starts executing its actions, Gradle takes a snapshot of the output directories/files. Then, after the task finished executing, it takes another snapshot and compares the snapshot before task execution to the snapshot after task execution. Only the files which changed between the two snapshots (or which are already considered an output of the task) will be considered a part of the task's output and considered for up-to-date checks. That is exactly the behaviour you want to model, right?

I can confirm this is working as expected. My bad for the noise.


Support Search Trace

Currently, we couldn't search traces by traceID.

Version 1.0.6 introduces the ability to filter traces by Root Service Name, Root Span Name, and Trace ID.

Hi @apetruhin and @def is there a way for searching traces by Attributes.
I saw Compare Attributes page, but it doesn't allow me to sort all traces by attribute; it only displays related single traces.
For instance, filters of this type would be ideal for my situation:
On the Application Traces page.
Attribute Query = custom_ip_attr is <IP_ADDRESS>
Attribute Query = custom_attr has alue or bearer_token_attr is token

I suggest we begin by developing the equal filter first and subsequently implement the others one at a time.
If there is no existing way or development in progress for trace search by attribute queries and this feature is desired, I could attempt to implement it in my free time with some help i believe. Additionally, if development is already underway, I would love to review it.


feat: Dex Trades per Token

Description
resolves #522
Demo

Checklist:

[x] I have read and followed the Contributing Guide
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.

first https://github.com/aeternity/aescan/pull/875 needs to be merged as this PR is based on it

In general LGTM.
But I have a question regarding test tokens. For example if nobody was trading token there would be no trade activity. When I open Trades tab the page will be in endless loading: https://pr-876-aescan-testnet.stg.service.aepps.com/tokens/ct_25e9fYcVxp8qHhiHE3ZZKv1qsRZ8knvJefcUmTchZi33WANgt7?type=trades
2024-11-<IP_ADDRESS>.mov

@Liubov-crypto good catch! Finally got it fixed.

EDIT: I just noticed that the button "Newer" seems to always be disabled? https://pr-876-aescan.stg.service.aepps.com/tokens/ct_2U1usf3A8ZNUcZLkZe5rEoBTxk7eJvk9fcbRDNqmRiwXCHAYN?type=trades
dex-trades.mov

Good catch, ser. There was FE wrong implementation + its a blocking MDW issue.


[Bug]: BTD6 crashing when i try to use any mod with custom models

All of the following criteria must be met

[X] All Requirements must be installed.
[X] Changed the title so that it doesn't just says "[Bug]: "
[X] I have searched the GitHub issues for my bug, even in the closed issues.

All of the following are optional to answer

[X] Tried reinstalling the Game.
[X] Tried reinstalling MelonLoader.
[X] Tried restarting PC.
[X] Was able to see the Start Screen.

Describe the issue.
so when i instal mod like sun god village everything is fine, but when i try to place it game is just freezing and crashing
Latest.log
Did you attach your log file?
Yes, I attached my log file to the text box above.

Forgot to mention that it happens with every mod with their own model

Don't use pirated versions of games.

i have same issue but im using steam version :(


train dreambooth on model inpainting runwayml

It would be good to train dreambooth on the inpainting model, I could generate incredible art with inpainting and dreambooth
here a user apparently achieved it
https://github.com/huggingface/diffusers/pull/1091

Looking forward to this!

wow, did not imagine its even possible. it would be great!

@TheLastBen looking forward to it!


fix pullTimeOut unit

according the config rocketmq.consumer.pullTimeOut = 3000 in runtime.properties, the unit should be millisecond

Welcome to join us through DingTalk scan code:


Release retained resources from layers/dispose pictures

WIP

Gold has detected about 2 new digest(s) on patchset 1.
View them at https://flutter-gold.skia.org/cl/github/84740

Gold has detected about 2 new digest(s) on patchset 1.
View them at https://flutter-gold.skia.org/cl/github/84740

/cc @ds84182 - this breaks a render object you created internally. I'll likely have to introduce an intermediate step here with some changes to the Layer interface that don't do/assert anything yet, fix up _FocusOverlay, and then re-introduce the asserts - but happy to discuss further with you if you have a better idea.

This patch now passes internally.

Thanks @yjbanov - addressed all the nits.


Openstack

This card is about having a packer template for Openstack
Additional context
Part of #208
Requirements

[ ] Check if it's possible to create a packer template that leverages https://github.com/rancher-sandbox/cos-toolkit-docs/pull/59 for installation, before attempting to create specific images
[ ] packer templates for Openstack
[ ] docs explaining how to use the packer templates

We will revisit cloud-images in the future, closing this.


How to process images of different sizes?

This repository processes the fixed-size images, however, I need to input and output images of different sizes and make sure that the images remain the same sizes as its original ones.
So can it be modified to support this need? And how to modify it?
Thank you very much.

https://github.com/vanhuyz/CycleGAN-TensorFlow/issues/42

Thank you.
It said the input images need to be squared, however, my images are not.
How to process it or modify the code?

Yes, seem that they need to be square images. Not sure if it is an easy modification to change the source to support non-square images. I may try later. In the meantime, maybe scaling or padding could work but that may depend on your application.

Thank you. I will try it too.

Have u guys got some results on the non-squared images? I'm working on it too.. @Kongsea @ngeorgis

Have you achieved it? @xymeng16

Well, I try to apply padding and resize the picture before the input but sadly neither showed a good performance(my application is car license plate generation, which has a fixed size and aspect ratio). So I traverse the code and find I need to modify the implementation of some layers in ops.py. I think I will open a PR after finishing it. @Kongsea

Look forward to it.

Just to be clear, is this discussion about "training" on various/bigger image sizes like 512x512 or "evaluating" a model on different sized inputs?

@xymeng16 I try to apply the code on PR data generation,too! You can modify the code to process different W and H size plate images.

Hello! Is there anyone solve the problem :input image size over 256 ?such as 512 or higher


pleroma: 2.4.0 -> 2.4.1

There was no changes needed in terms of dependencies, mix.nix stays untouched.
I use that on my homeserver ATM, it seems to fix the sync issues I had with the Mastodon instances lately.
Changelog:
Changed
- Make mix pleroma.database set_text_search_config run concurrently
  and indefinitely

Added
- AdminAPI: Missing configuration description for StealEmojiPolicy

Fixed
- MastodonAPI: Stream out Create activities
- MRF ObjectAgePolicy: Fix pattern matching on "published"
- TwitterAPI: Make change_password and change_email require params on
  body instead of query
- Subscription(Bell) Notifications: Don't create from Pipeline
  Ingested replies
- AdminAPI: Fix rendering reports containing a nil object
- Mastodon API: Activity Search fallbacks on status fetching after a
  DB Timeout/Error
- Mastodon API: Fix crash in Streamer related to reblogging
- AdminAPI: List available frontends when static/frontends folder is missing
- Make activity search properly use language-aware GIN indexes
- AdminAPI: Fix suggestions for MRF Policies

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

cc @yu-re-ka @happysalada @Duponin

@GrahamcOfBorg test pleroma

Result of nixpkgs-review pr 138275 run on x86_64-linux 1

1 package blacklisted:

tests.nixos-functions.nixos-test

1 package failed to build:

nixos-install-tools

1 package built:

pleroma

Result of nixpkgs-review pr 138275 run on x86_64-darwin 1

tests pass, there were some fixes added, It seems to me this is good to merge.

Thanks!


MAINT: bump minimal supported NumPy version to 1.22.4

Preparing for SciPy 1.12 where we would bump NumPy to be at least 1.22.4.
This follows NEP29: NumPy 1.24 would just become the minimal supported version, so as before we are setting to the immediate previous stable release which is 1.22.4.
If I got this right this time, I think we can clean a bit the pyproject.toml.

How shall we proceed here? I don't understand that either and I hoped you would know were to look 😅

How shall we proceed here? I don't understand that either and I hoped you would know were to look 😅

It seems to fall back to building numpy from source rather than using a wheel:
Building wheels for collected packages: numpy
  Building wheel for numpy (pyproject.toml): started
  Building wheel for numpy (pyproject.toml): still running...
  Building wheel for numpy (pyproject.toml): still running...
  Building wheel for numpy (pyproject.toml): still running...
  Building wheel for numpy (pyproject.toml): still running...
  Building wheel for numpy (pyproject.toml): finished with status 'done'
  Created wheel for numpy: filename=numpy-1.22.4-cp39-cp39-linux_i686.whl size=18054224 sha256=3abd224b35dc086fed86526b82f1a4ec2c5dab2e71dfc220fe05bd5b081d22e7
  Stored in directory: /root/.cache/pip/wheels/0c/d9/9a/77347b280a48a1f03093a70653680ad66d622df0f4111d34cf
Successfully built numpy

I doubt that's the intention... And indeed numpy has stopped publishing 32-bit wheels as of 1.22.0 (compare with 1.21.6). The release notes specifically mention this:

Note that 32 bit wheels are only provided for Python 3.8 and 3.9 on Windows, all other wheels are 64 bits on account of Ubuntu, Fedora, and other Linux distributions dropping 32 bit support.

In light of many discussions around this, I'd be fine with dropping 32bit completely, but I guess that makes it a bigger discussion than just a routine NEP29-bump...

So the bump of NumPy did not work to make it build on 32 bits. What should we do?
Also for the flaky tests, I could update the tols here.

I've seen the (non-32-bit) test failures elsewhere, so they aren't related to the version bump.
The 32-bit support is the only issue then I guess, I'll see if I can dig a little on that, I see the error message is the same on 1.25.0 as 1.22.4 when we build NumPy from source.

I didn't encounter the problem in i386/python:3.10.12-slim-bullseye with NumPy 1.22.4 built from source locally. I'll see if I can try a few more things.

I can reproduce if I use a different 32-bit container (the same 32-bit manylinux one used in the CI here), and follow the CI steps almost exactly with Docker locally. Amazingly, the problem goes away after I do yum install vim and yum install less, which is crazy, but reproducible in my hands.
The problem seems to come down to the fact that when you build NumPy 1.22.4 from source on 32-bit here, you can't actually import it because it has a problem finding OpenBLAS shared library, so obviously the np.get_include() logic isn't working.
I can work around that locally using export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:/usr/local/lib. We already do this in the line below for testing with LD_LIBRARY_PATH=/usr/local/lib python dev.py test, so I propose that we try doing the same for python dev.py build here now too, though I suspect we may be just delaying the inevitable demise of 32-bit support.

Ok, I pushed that shim in for 32-bit, we'll see what happens.

The 4 remaining 32-bit test failures look like tractable tolerance issues, if we decide to maintain the support.

Thanks Tyler 🙇 I propose we just xfail them on 32 bits. I think I would not want to tweak too much the tols just to please 32 bits if the tests are good everywhere else.

All right, CI is happy now. Anything else? (I will let the person merging take care of @h-vetinari's comments, the link is to update in any case OC.)

Merged with the following notes:

the remaining CI failures are unrelated and seen elsewhere
the 32-bit Linux job is still 10-20 minutes faster than the Windows CI jobs, even with 32-bit NumPy built from source
I applied the simple pyproject.toml link fix from @h-vetinari, but I didn't apply the PyPy adjustment--this is simply because I wanted to avoid having to analyze that change and Ralf was happy with the initial state of the changes (maybe for a quick follow-up simplification PR?)
I think this was blocking some array API adoption stuff, so wanted to get it in

Thanks Tyler! 😃

I've been following up on the oldest-supported-numpy side, and I can update here later. While it'd be nice to have, I don't think it's relevant for the release.


Combine the play and play_from commands

Hi! This is a first-timers-only issue.
This means it's aimed towards people who haven't contributed to open source before, or are just starting to. As such, it is a relatively simple issue, so people can focus more on the process of contributing rather than the complexity of the issue.
If that's you, keep reading to find more about the problem, the expected solution, and any proposed steps towards that solution.
The problem
Currently there are two commands to start playing music: play and play_from. play takes a query (name of an artist, of a song, etc) as an argument and searches YouTube to get a result, while play_from takes a URL directly. For ease of use, only one command should be needed to deal with both cases.
The solution
As it turns out, the feature is almost there: play can already handle both cases! Searching a video's URL in YouTube returns the same video (as it should!).
So an easy solution is to combine both commands into play, and use it to search both queries and URLs.
A better solution would be to detect whether the provided argument is a URL. That way, we could pass it directly to the function that actually gets the song instead of searching YouTube to get the same URL first.
How to implement it
Basically, the steps to do this are:

Claim this issue by commenting below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!
Take a look at CONTRIBUTING for guidelines, and at README for some context.
Clone the repo if you haven't already.
Create a new branch, preferably with a descriptive such as combine_play.
Go to cogs/music.py.
Currently the play command starts at line 206 and play_from starts at line 246. These are the two functions to modify.
Combine the two:

The new play function should have three parameters: the two necessary ones, self and ctx, and a query parameter.
It should use the code from the current play function to perform the search, and the code from play_from to use the new URL as it currently does: in other words, copy the code from play and paste it after the await msg.edit(suppress=True) at line 267.

That should be it! You can create a pull request and wait for review. If you can test the changes beforehand, please do it.

In the meantime, there are a couple of bonus points you can tackle (no pressure!):

Update the docstring, type-hints and command help to match the new function.
Now that you should have only one play function, people that were using play_from (if any) might wonder why the bot suddenly doesn't recognize the command. To avoid this, create a new play_from function. This new function should be quite short:

It should notify the user that the command is now deprecated. You can send a message with await ctx.send(message).
You can also add a notification by changing the help text above the function.
It should still take a URL as argument, but pass it immediatly to play with await self.play(ctx, url) instead of processing it first.
That way the play_from command still exists and works, but users are made aware it will go away in a future version.

Finally, you can try to implement the better solution mentionned above: instead of blindly searching for whatever query it gets, play should try to recognize if the argument is a URL. If it is one, it can pass it directly to YTDLSource.from_url instead of searching for a result first.

That's it. :)
I said it is a simple issue, but it can be fairly overwhelming if you don't have much or any experience with git, discord.py, or even the asyncio library. Feel free to ask for help at any point, even (or specially) at the beginning. Remember, the idea of this issue is to help people get the hang of contributing to projects; the problem itself is just an entertaining mean to that end. As mentionned, there's also no pressure on doing the bonus points.
One last thing: I'd appreciate to have some update on your progress, at most a week after making the claim, even if it's to say you're still working on it. That way I can know whether to maintain your assignment or if I should assign it to someone else.

Hi, I think I have done the first part but I am unable to create a pull request. Do I have to be assigned?

Hey, I want to work on these issue.

Hi @SURAJITSHAW,
Unfortunately, someone has already submitted a pull request (#2), even though they didn't claim the issue first. I'm going through their code to see if they've completed all additional tasks. If you're still interested in contributing to this repo, I'll let you know what part to work on, or if the pull request closes this issue, I'll create a new first-timers-only issue and notify you.

Sure thing, I will looking forward to it. And one thing I actually appreciate the way you explain the problem and also how to solve it. This was really great work thanks for that :)

Ok! I'll keep you posted then.
And I'm very glad to read that! This is my first open source project so I took some time reading how other projects presented their beginner-friendly issues. I'll try to present the next one in the same way. :)


Bluetooth: Mesh: Add database for managing nodes and keys

This PR relates to issue https://github.com/zephyrproject-rtos/zephyr/issues/20259.
This is currently somewhat of a PoC but it's easier to discuss with some real code.
I have moved the the storage of nodes from struct bt_mesh_net, which is used for the local node, into a new struct bt_mesh_mgmt_net.
One thing I have thought about is that it might be a good option to not have this as part of the stack, i.e. in subsys/bluetooth/mesh but rather make it into some kind of lib. The question then is how the stack would interact with the lib.
The database is needed by by stack in the following cases:

When provisioning a new node (local and remote device)
When using the cfg_cli or any other model that needs device keys

There are probably more but those are the ones used right now I believe.
So the question is how the stack should interact with the database. Should it be that the stack calls the lib directly or should there maybe be a way to "hook" the database into the stack?

It looks pretty good, but I'm thinking if it is necessary to add a description structure for each node, so that after the configuration is completed, a comp-get request is made to get some information about the node and the currently supported features, and nrf-mesh  similar.  After all, for a mesh network, each node participates in network maintenance and has a certain effect on network robustness.

It looks pretty good, but I'm thinking if it is necessary to add a description structure for each node, so that after the configuration is completed, a comp-get request is made to get some information about the node and the currently supported features, and nrf-mesh similar. After all, for a mesh network, each node participates in network maintenance and has a certain effect on network robustness.

That's sounds like a good thing to have but I believe it might be best to do the more "fancy" things in another module. @trond-snekvik also has some ideas in https://github.com/zephyrproject-rtos/zephyr/issues/20259. My main purpose of this PR is to just get rid of the more network related things from the local node. For example the nodes in struct bt_mesh_net.
I think I'll rename this to something like db rather than mgmt. A more "user"-focused management module could then be done which of course can use the database from this PR but maybe create a more powerful and user-friendly API.
Do you guys think this makes sense?

@jhedberg @trond-snekvik What do you think about putting this in bluetooth/mesh? Does it make sense to make it into more of a lib that bluetooth/mesh uses?
I think settings.c gets a bit messy when also mixing in this database stuff so maybe that should at least be in its own file and also have its own settings "namespace".

@trond-snekvik can you take another look?


Add scala3-migrate tool

Also people will want to know why they cannot migrate their tests. So you should probably add a warning saying that it is not yet supported.

I see that some content is replicated, so I would like to extend the comments that I made on https://gist.github.com/mlachkar/5b7edbc59c16fc5e67b09d71ab4781bb to this PR


Incorrect alpha 500 results

The alpha 500 results on COROS watches (and the app) read higher than they should because the proximity rule is not being enforced.
The impact of this issue can be significant with one session reporting 27.64 knots on the watch (and app) whilst the reality was a best alpha of 21.15 knots.
An algorithm allowing alpha results to be calculated in realtime with minimal CPU usage has been written with COROS in mind.
The project also includes clearly annotated Python code which should be easy to port to the COROS firmware.
Note: This algorithm has now being implemented by the maker of the Motion (u-blox) and author of GPSTC V4 (Garmin data field).
Link to my article with Python code: https://logiqx.github.io/gps-wizard/alpha-racing/

U[pdated comment to provide links to Motion GPS and GPSTC datafields which have both been using my algorithm for several months now.


[3pt]  - Add comments counter - Student B

Even if the API gives you the number of comments you will create a specific function to calculate it.
Make sure that the correct number is displayed on the Comments pop up.

Pull request for this task


"No results found" message is missing when there're no search results for New Chat/New Group/Main Search

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Login to e.cash
Open Main Search / New Chat / New Group
Type random word so that there're no search results

Expected Result:

Actual Result:

Workaround:
Visual Issue
Platform:

[:heavy_check_mark:  ] Web
[ :heavy_check_mark: ] iOS
[:heavy_check_mark:  ] Android
[:heavy_check_mark:  ] Desktop App
[:heavy_check_mark: ] Mobile Web

Version Number:
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
View all open jobs on Upwork

Triggered auto assignment to @NicMendonca (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

Proposal :
https://github.com/Expensify/App/blob/683bcf408fce0bfa7551f8d4498c818b13170778/src/components/OptionsList.js#L212-L214

Need to use  {this.props.translate('common.noResultsFound')}  instead of      {this.props.headerMessage}
Import required files

Triggered auto assignment to @Beamanator (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

Thanks @aman-atg but this is technically working as expected. The search is waiting until you type a valid email address, then it will allow you to start a new chat with the email address you typed. We're working on some improvements in https://github.com/Expensify/App/issues/2936 which should cover this case. When that solution gets merged, please feel free to test and let us know if it looks good or if you think it should change 👍 I'll close this for now.

@Beamanator
Maybe we can open this issue now. And close the dupe: https://github.com/Expensify/App/issues/4677
I'll update the proposal.

Good idea @aman-atg 👍

Triggered auto assignment to @puneetlath (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

Proposal :
https://github.com/Expensify/App/blob/9b1ea35eca45885dd0168971b93fdecd5501e34e/src/libs/OptionsListUtils.js#L667-L685

We're returning searchValue on line 681 instead of that we can use a different message like:

No results found
No users found
Please enter a valid email address
or any other message

I like this proposal, it is nice and easy and makes sense 👍 please go ahead and submit a PR when you have a chance @aman-atg and @puneetlath please hire aman when you make the Upwork issue :)

@aman-atg  do you really want to edit your (https://github.com/Expensify/App/issues/4163#issuecomment-884253066) older proposal with what I proposed here   https://github.com/Expensify/App/issues/4677#issuecomment-899701600 yesterday.

Wow I didn't notice that, thanks for bringing that to my attention @Santhosh-Sellavel

@Santhosh-Sellavel will you please add your original proposal to this issue so we can move forward with your idea? 👍

@Beamanator Can we just close this move it forward there #4677

Here it is @Beamanator
Proposal
Simple returning searchValue is the problem here, if we remove it problem solved.

Instead, we could return the appropriate message if needed.

@Santhosh-Sellavel Sorry, If you felt that way but I didn't really saw your proposal before updating mine.
The problem was already known to me and it was a simple fix.
@Beamanator you can check the proposal history and the issue description that solution was already there. Only the location changed as new PRs were merged.

Thanks for the discussion @aman-atg and @Santhosh-Sellavel , let's remember to keep our conversations respectful at all times :)
@aman-atg Thanks for explaining your situation. I am going to move forward with another proposal. Your previous proposed solution may have been best at the time it was proposed, but we didn't move forward fixing the issue at the time. Your new proposal is good, but since it was very similar to a proposal that someone posted ~ 3 to 4 hours before you, I believe it's only fair to move forward with the other proposal. Please feel free to reach out to me in NewDot if you have questions.
@Santhosh-Sellavel Let's move forward with your proposal. I think we should work from this issue since this is the original reporting of the issue, can you please let me know why you prefer to move forward in the other issue?

@Beamanator

I am going to move forward with another proposal

That's fine. But I just wanted to clarify that the proposed solution a different message was already posted here days ago.

@Beamanator @Santhosh-Sellavel FYI I closed the other issue as this was the original

First @aman-atg - Sorry, we do have an unexpected situation here.
@Beamanator I felt the issue already had a recently active slack thread and no other special reasons. But now it was already closed, we can proceed here.
What message to show in the header?

What message to show in the header?

As @isagoico  suggested in this slack thread, I'd say we go with "No results found"

Thanks, @Beamanator I'll open up a PR shortly!

@Beamanator Draft PR is Ready.

@Santhosh-Sellavel is it a draft or is it ready for review? :D

@Beamanator distracted by a new issue while drafting PR for this issue! Now it's ready for review.

Merged today 👍 (Sorry for the delay, @Santhosh-Sellavel )

@Beamanator  is there an Upwork job for this?

Looks like not yet 🤔  I'll ask for help internally! Someone should get to it today 👍 again... Sorry for the delay!

Working on this now!

Job posted!

Internal: https://www.upwork.com/ab/applicants/1428718283504664576/job-details
External: https://www.upwork.com/jobs/~0186891d4078a90470

Thanks @dylanexpensify ! Just to quickly catch you up - this job has already been finished 😅 I merged @Santhosh-Sellavel 's code this morning, so @Santhosh-Sellavel can you let @dylanexpensify know when you apply so he can hire you?

Applied! @dylanexpensify

Hird @Santhosh-Sellavel ! 😄

Putting on hold for payment so it's clear what the current status is & so it's clear on my todo list :D

@dylanexpensify assigning you since Puneet unassigned himself - seems your takeover is official! 😅

Good question @aman-atg - as @mallenexpensify posted in #expensify-open-source here:

This change is in effect as of yesterday and the bonus for independently reporting an issue is only valid from yesterday forward. If there are existing, open, GH issues that you believe you should be compensated for reporting a bug, please comment in the issue.

Thanks for clarifying.

Actually... since this issue is still open and because @aman-atg has contributed to the issue, I think they should be paid. @aman-atg can you apply for the job here https://www.upwork.com/jobs/~0186891d4078a90470
@dylanexpensify when you pay @Santhosh-Sellavel for the job can you also pay @aman-atg $250 for reporting the issue, and confirm with a post in this issue that both have been paid? Thx

@Santhosh-Sellavel this is paid, thanks :)
@aman-atg once you accept the offer in Upwork, I'll issue the bonus payment.

Paid Aman, closing this out.


ML Vision Barcode Detector - VisionBarcode.dispayValue is always nil

I faced with that issue in my own project but noticed that quickstart-ios/mlvision has the same issue:
When you're trying to detect a barcode on one of the embedded images (barcode_128.jpg or qr_code.jpg) displayValue is always nil.
(FirebaseMLVision (0.10.0), FirebaseMLVisionBarcodeModel (0.10.0))

I'm unable to reproduce this, running the sample gives me nonnull displayValues for both the images specified. What version of MLKit are you using?

All FirebaseML~ modules have 0.10.0 version.
Here's what I'm getting:

Disregard my last comment, I've been able to reproduce this with the sample images.
I'll let the MLKit team know and keep this ticket updated.

b/110845379

Fix up at cr/204789160

This is fixed and will be out in the next MLKit update.

Hi @morganchen12 . Just wanted to clarify:
I've updated to the latest FirebaseMLVisionBarcodeModel 0.11.0 version and, unfortunately, the issue is still there. So, it there any approximate date when the fix will be released?

Sorry for the confusion. The bug is part of GoogleMobileVision, which isn't part of the normal Firebase release cycle, so the fix wasn't pushed with the last Firebase release. It should be out in the next week or two.

Hi @morganchen12. Sorry for disturbing you again. I'm still waiting for this fix to be released but it still not there. Is there any updated ETA for it?

I've asked the GMV team and will let you know. Apologies for the delay.


docker-compose pull with constraint on swarm cluster?

Does docker-compose pull command support pull with constraint on swarm cluster?
I created issue on docker-compose but I'm not sure docker-compose or docker-swarm that responsibility for this.
https://github.com/docker/compose/issues/2764
For example
$ docker info
Containers: 29
Images: 56
Role: primary
Strategy: spread
Filters: health, port, dependency, affinity, constraint
Nodes: 3
 pre-01: pre-01:2376
  └ Status: Healthy
  └ Containers: 4
  └ Reserved CPUs: 0 / 2
  └ Reserved Memory: 0 B / 2.044 GiB
  └ Labels: preproduction=true, executiondriver=native-0.2, kernelversion=3.19.0-47-generic, operatingsystem=Ubuntu 14.04.3 LTS, provider=generic, storagedriver=overlay
 prd-01: prd-01:2376
  └ Status: Healthy
  └ Containers: 5
  └ Reserved CPUs: 0 / 4
  └ Reserved Memory: 0 B / 8.179 GiB
  └ Labels: production=true, executiondriver=native-0.2, kernelversion=3.19.0-47-generic, operatingsystem=Ubuntu 14.04.3 LTS, provider=generic, storagedriver=overlay
 prd-02: prd-02:2376
  └ Status: Healthy
  └ Containers: 4
  └ Reserved CPUs: 0 / 4
  └ Reserved Memory: 0 B / 8.179 GiB
  └ Labels: production=true, executiondriver=native-0.2, kernelversion=3.19.0-47-generic, operatingsystem=Ubuntu 14.04.3 LTS, provider=generic, storagedriver=overlay

$ cat docker-compose.yml
nginx:
    image: nginx
    environment:
        - "constraint:label==production=true"

But when I did docker-compose pull it still pull to whole swarm cluster.
$ docker-compose pull
Pulling nginx (nginx:latest)...
pre-01: Pulling nginx:latest... : downloaded
prd-01: Pulling nginx:latest... : downloaded
prd-02: Pulling nginx:latest... : downloaded

@winggundamth Sorry no. It's always pulling the whole cluster.
Please note that constraints and affinities apply only when you're doing docker run.

Can I ask this as a feature request?

@winggundamth it's a limitation of the docker client. You'd better request for this at the Engine repo.
It is known that there were similar requests like this for docker build with environment variables.
I personally think that it's a cool feature if we can selectively pull images to a zone of cluster.
@vieux @aluzzardi @thaJeztah WDYT about this?
cc @docker/swarm-maintainers

A side note.
Maybe docker build --build-arg="constraint:node==node-1" can be a workaround for pulling to a specific node. Compose also supports this feature.

I created issue on docker engine here https://github.com/docker/docker/issues/19785
@chanwit I'll try that but I'm not sure that it will support constraint by label or not.

Same problem here.
@chanwit, should I build an empty image from the image what I actually want for a workaround?

@heycalmdown Yep I think you can do that. At least it will pull your base image to the correct node.

I submitted a PR for this at #2302, that covers swarm but it'll need another PR in docker engine to add it to the CLI.

Any progress on this? Especially in combination with docker-compose. We've some small proxy-nodes which actually only need a few images.
We have to constantly delete images, which then get pulled again, and so on...


Add support for github style tables

I'm use Add support for github style tables @kevin-montrose for view tables.
Is use for close issue #42

No answer from the PR author 😦


Feat/docker support ollama improvements + minor flexibility tweaks

This PR adds

Docker support
Ollama improvements
.gitignore for python artifacts, vscode settings
excludes config.yaml from source control as it contains secrets
add example template for config.yaml
Add LLM_SERVER env var to config.yaml to select the inference endpoint and remove hardcoding
Readme updates to reflect this

Tested on windows, should work everywhere

Thanks for your PR. I forked your PR, it was good but I had to make some tweaks to ensure that it was working correctly with the latest version of Jar3d which has knoweldge graph retrieval. Jar3d is now Dockerized. Thanks for the help.


Move queue to gpu when resuming checkpoint - SWAV self supervised model

What does this PR do?

Fixes # (issue)
Before submitting

[ ] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
[X] Did you read the contributor guideline, Pull Request section?
[X] Did you make sure your PR does only one thing, instead of bundling different changes together?
[ ] Did you make sure to update the documentation with your changes?
[ ] Did you write any new necessary tests? [not needed for typos/docs]
[X] Did you verify new and existing tests pass locally with your changes?
[ ] If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

[x] Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃

@thiyagu145 good catch. thanks for the PR.

@thiyagu145 @ananyahjha93 mind check the failing tests?

hi @Borda
TypeError: transfer_batch_to_device() missing 1 required positional argument: 'dataloader_idx'
I'm not sure if this error is coming up because of the usage of self.queue.to(device).


Update to align with current Red Hat Insights starter app

Description
Update everything to align with current Red Hat Insights starter app
Checklist (Definition of Done)

[ ] Unit and integration tests added
[ ] Added test description under Test manual
[ ] Documentation added if necessary
[ ] CI and all relevant tests are passing
[ ] Add the ticket number to the PR title if available, i.e. ROX-12345: ...
[ ] Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.

Test manual
TODO:

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@0de63b4). Click here to learn what that means.
 Consider uploading reports for the commit 07438dc to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #72   +/-   ##
=======================================
  Coverage        ?   11.89%
=======================================
  Files           ?       26
  Lines           ?      395
  Branches        ?       84
=======================================
  Hits            ?       47
  Misses          ?      322
  Partials        ?       26

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Add Webhook HTTP basic authentication

/* 20160128 - W. GRIM: Added code for Webhook authentication via HTTP basic auth.
* Please be aware that unless you use https to access your webhook, this is
* not a secure authentication because everything is transmitted in
* plaintext */

Thanks! Would it be possible that you merge your patch-2 and patch-3 branches into patch-1 on your side? This would allow to review this as a single pull request.

I tried but I don't know how to do this. It's the first time I work with github. Can you help?


Output CSV without header

How do I output CSV without a header, if I make the header None, no data is rendered.
I've tried:
class HeaderlessRenderer(csvrenderer.CSVRenderer):
    header = None

@api_view(['GET'])
@renderer_classes((HeaderlessRenderer))
def infosheet(request, analysisid, **kwargs):
    ....

@VidJa There's no configuration options right now to omit the header entirely. I'd be willing to discuss design and perhaps accept a pull request for such a thing, but is stripping out the header row something you can handle on the client side?


[HOLD for payment 2022-01-11] [Network] No error messages shown to user when setpassword gets an error from the API

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:
sign up as a new user and click the link. Delete the last character of the url and navigate.
Expected Result:
An error should be shown to the user explaining why the request didn't work.
In this case say the key has likely expired and a new one will be waiting in their emails.
I would also expect the email from expensify to be another link to new.expensify.com to finish the set password flow
Actual Result:
https://user-images.githubusercontent.com/47184118/129949187-00c5b590-ca4e-4a7a-abee-54b49ece9952.mp4
the second email has a link to the old expensify password reset flow, not to the new.expensify.com/setpassword/.../...
Workaround:
User would have to guess what went wrong (I'm simulating an expired token).
User would have to check emails finish the flow in the old site and then navigate to the new site.
Platform:

Web
iOS
Android
Desktop App
Mobile Web

View all open jobs on GitHub

Triggered auto assignment to @tjferriss (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

should I made another issue for the API not sending the correct link out or will that get one made internally somewhere else?

I reported a duplicate issue it seems. I am proposing the following solution.
Proposed Solution
Add a catch block to setPassword API:
function setPassword(password, validateCode, accountID) {
  Onyx.merge(ONYXKEYS.ACCOUNT, {...CONST.DEFAULT_ACCOUNT_DATA, loading: true});

  API.SetPassword({
    password,
    validateCode,
    accountID,
  })
    .then((response) => {
         /// existing code
    })
    .catch((err) => {
        Onyx.merge(ONYXKEYS.ACCOUNT, {error: err.message});
    })
   // existing code
}

@tjferriss Huh... This is 4 days overdue. Who can take care of this?

I would modify:
https://github.com/Expensify/App/blob/8a5cf2d190e8e259a1bcb4090fcb437e42f78dbe/src/libs/actions/Session.js#L261-L281
To resemble:
https://github.com/Expensify/App/blob/8a5cf2d190e8e259a1bcb4090fcb437e42f78dbe/src/libs/actions/Session.js#L229-L231
Where the error handling would be in a catch block.
I'm not familiar with translateLocal yet. I would look at using this on the error as well.

I had a look at how API.js handles it and we have a bunch of swithc cases to cover off giving the right translated strings in the Errors to give to translateLocal:
https://github.com/Expensify/App/blob/8a5cf2d190e8e259a1bcb4090fcb437e42f78dbe/src/libs/API.js#L222-L251
Do we have such sophistication of HTTP codes for this API call?
For a simple fix I can just use the message in the API response to display. But to bring this upto standard with the rest of the app with translations I need a mapping of the different HTTP error codes to copy.

@akshayasalvi can you link to the duplicate issue you previously mentioned? If you're working on a solution there then can we close this issue?

@tjferriss the issue is #4745 . I am not working on it at the moment. One of your team member asked me to apply to this issue and closed the other one .
here’s my proposal for the same https://github.com/Expensify/App/issues/4737#issuecomment-903034853

Thanks for referencing it and sorry for the delay here. I'm going to tag engineering so someone can take a look and remove my assignment.

Triggered auto assignment to @chiragsalian (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@akshayasalvi, nice i like that direction. Few suggestions:

I don't see the need for hasValidationCodeError boolean when we already have this.props.account.validated that we can reuse. This would clean up the logic of validAccount and not need hasValidationCodeError.
With the changes from above if we don't pass hasValidationCodeError we can instead pass a string validationFailedMessage (maybe check if you can reuse account.error first before this new key). This can be reused in the future too if needed and cleans up some of the current logic. So with those changes, i would suggest doing,

Onyx.merge(ONYXKEYS.ACCOUNT, { validated: false, validationFailedMessage: 'resendValidationForm.validationCodeExpired'});

Next the welcomeText variable is not very readable in my opinion. Having double ternary operator in a single line is not very readable so if we pass resendValidationForm.validationCodeExpired as validationFailedMessage then we can clean this up like so,

const welcomeText = this.props.translate(this.props.account.validationFailedMessage ?? (`welcomeText.${showPasswordForm ? 'phrase4' : 'phrase1'}`));

But while we can clean that up as I think about this, we shouldn't be editing the welcomeText. In fact i think welcomeText should be blank and we should instead update the code here to display resendValidationForm.validationCodeExpired instead of resendValidationForm.weSentYouMagicSignInLink when validationFailedMessage contains a value i.e.,

this.props.account.validationFailedMessage ?? 'resendValidationForm.weSentYouMagicSignInLink'

To answer "One suggestion is that the text message looks too big. Can we shorten it a bit?" I think its pretty small. Once we've got the PR up we can revisit the copy if it still looks too long in the UI.

Thoughts on these changes @akshayasalvi?

Good points overall. I wasn't sure if we allow adding translation keys in Onyx. Agree with points 1, 2, 3, and 5.
Point 4, I feel without the title this page will look off compared to other pages. But let's try and see how it shows up. Sounds okay?

Yup all those sounds good with me.
@kadiealexander, can you hire @akshayasalvi in upwork.
@akshayasalvi, feel free to go ahead and work on the PR.

@chiragsalian Can you help how I can test this flow in Mobile App and Desktop App? Clicking on the link redirects to mobile website and the website.

Begone, Melvinbot. @chiragsalian should be back after Labor Day to help with this @akshayasalvi, sorry for the delay!

Okay thanks.

Sorry for the delay. I was on vacation for a few days.

Clicking on the link redirects to mobile website and the website.

when you say mobile website and the website do you mean the old expensify.com webpage and not new.expensify.com? Thats odd. I'll test later today and see if there is a bug or something. Either way, for your testing feel free to change the URL such that it points to new.expensify.com instead of expensify.com and you should be able to test what you need right?

No no. I meant I am able to test on the website and mobile website. Here I manually hit the URL for an expired validation code.
How do I test the same redirect for Desktop and the mobile app?

@chiragsalian One other weird behavior I've noticed is, there are three flags - showLoginForm, showPasswordForm and showResendValidationLinkForm. After the redirect, I can see in the console that only showResendValidationLinkForm is true yet it doesn't show the MagicLink page.  It shows the Password page only. Once I do a refresh from the address bar it shows the magic link page.
Any idea what could be the reason? Are we using any pure component and the rerender not happening?

I don't think you can test this for Desktop so its okay to skip that.
As for the mobile app, I'm unsure if you can test deep links locally too. I would just give an invalid URL like so so that QA can test on the App https://new.expensify.com/setpassword/10584032/DWGZCFRKT to confirm the error message shown is the same as the one on mobile browser.
As for this,

I can see in the console that only showResendValidationLinkForm is true yet it doesn't show the MagicLink page

Thats weird. Well, the link begins with the password page. Perhaps you have some race condition to figure out. Are you facing this issue on a specific environment or facing it everywhere? I can test your PR later today.

Tested your PR. Moved its discussion to within your PR.

@kadiealexander I've applied on Upwork too but haven't been assigned on Upwork yet

Hired you in Upwork @akshayasalvi, sorry for the oversight there!

Thanks a lot @kadiealexander. No worries :)

Hi @akshayasalvi, I've placed this issue on hold as per this update, as we are prioritising issues related to a feature release scheduled for 9/24. As an apology for the delay, we will add a $100 bonus as a thank you for waiting.

@chiragsalian, @akshayasalvi, @kadiealexander Whoops! This issue is 2 days overdue. Let's get this updated quick!

On n-6 hold melvin. Shoo.

Hold has been removed, please go for gold @akshayasalvi!!

This issue has not been updated in over 15 days. @chiragsalian, @akshayasalvi, @kadiealexander eroding to Monthly issue.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.1.24-19 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/5150

If no regressions arise, payment will be issued on 2022-01-11. :confetti_ball:

Paid, thanks @akshayasalvi!!

@kadiealexander This PR was on n6-hold and company offsite hold. Bonus for the same wasn’t added

Oops, sorry for missing that one! Have issued the bonus now. :)

Thanks a lot, @kadiealexander for helping here.

@kadiealexander  Should I have had a reporting bonus for this issue?

Hey Anthony! The reporting bonus came into effect in September last year, a few weeks after this issue was raised. (Link to Slack post). The post is clear about issues raised before this date not qualifying for the reporting bonus, but if you think this should be reassessed for this issue please raise the question in #expensify-open-source to have the team review this. :)

no worries! thanks for the info :)


Update README to link to coinbase-pro-node deprecation comment

This seems like a pedantic change, but when I first found this package I had to do some hunting to check if the official coinbase-pro-node package had been deprecated, or only coinbase-node.
The README currently links to a comment on a PR for coinbase-node - the package for the "normal" Coinbase API. But this package is for Coinbase Pro (formerly Gdax) so that's not relevant. I saw on the coinbase-pro-node repo all those PRs are also closed for the same reason: https://github.com/coinbase/coinbase-pro-node/issues?q=is%3Aissue+is%3Aclosed
So I've just updated the README here to reference the coinbase-pro-node package instead of coinbase-node.

Thanks for catching this @antriver! 👍


Add new rule to enforce headers matched by regexp

Checks for comments at the very beginning of files
Matches comment contents with header regexp
Ignores #! at the beginning of files

Relates to #155
cc: @alexeagle

overall looks pretty good, just left minor comments. @JKillian can you also take a look?

Looks fine to me, thanks @ScottSWu!


chore: bmx assets

Please review the following token assets:
📑 Description

Tokens for BMX, GMX fork on Base

✅ Checks

[x] I created a new folder with the token address, all in lowercase
[x] I added the token's logo as a 32x32 PNG file, named logo-32.png
[x] I added the token's logo as a 128x128 PNG file, named logo-128.png
[x] I added the token's logo as a SVG file, named logo.svg
[x] All the tests have passed

not using checksummed addresses pained me greatly but I did it 😢


Test graphite

PR-Codex overview
The focus of this PR is to add a basic Express server with a hardcoded activity feed endpoint.
Detailed summary

Added Express server setup
Defined a hardcoded activity feed data
Created a route to fetch activity feed
Server listens on port 3000

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

#2622  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @jnsdls and the rest of your teammates on  Graphite


Investigate minification of js/css/html during deployment

Mangling names would be hard due to the js-interop, but we should be able to save a lot of space by just removing comments and collapsing whitespace. We should do this for html/css/js

Whatever solution we use here should also be applied to https://github.com/dart-lang/paper-elements

Be nice if there is any way to apply tree shaking to the elements. Remove unused elements etc

I agree, but we can't really do that until we have global transformers (see http://dartbug.com/17306). The application is the only thing that knows what it could delete, but it can't delete files in this package.

Shouldn't it be possible to just run vulcanize or some other JavaScript minification after pub build to achive this?

Yes, but it would be nice if we could integrate that into the transformation process, eliminating any extra steps and standardizing how its done.


Failed to await device.setOrientation() on android

Look like a synchronization issue. Reproducing when trying to setOrientation multiple times.

Doesn't turning animations off solve it?

No it doesn't :(

await device.setOrientation('landscape');
await expect(element(by.id(testIDs.LANDSCAPE_ELEMENT))).toBeVisible();
(async () => { // Somehow invoking this part inside an anonymous function fix this test
  await device.setOrientation('portrait');
  await expect(element(by.id(testIDs.PORTRAIT_ELEMENT))).toBeVisible();
})

Maybe this will give you a clue about what happening..

@yogevbd
Hey, just a heads up, I tried using an anonymous function in one of my tests and I found out that it simply ignores the code inside the function and passes the relevant test, so this might not actually be passing your test. The relevant code I ran was:
async () => {       await expect(element(by.text('Helvlo!!!'))).toExist();     };
It simply passes the test, even though no such text exists on the screen.

Closing old issues. If this is still relevant, please open a new issue with the relevant logs from a modern version of Detox. Thanks.


Support mixing classes & classDirs on RoutingControllerOptions

This change allows us to mix between imported classes & classDirs on:

RoutingContollerOptions.controllers
RoutingContollerOptions. middlewares
RoutingContollerOptions. interceptors

This change also adds package-lock.json introduced by npm 5.

@pleerock node:latest build is failing on all builds.
This PR should not affect lib flow by any means.

The proposal seems solid, however, it'll be a breaking change for existing codebases.
While the move to index files is easy enough (hack, it can be automated), #255 is not shipped yet.
I suggest merging my PR as bug-fix, as it is valuable to allow mixing.

But it's not a bug, it works as designed. And as I said, merging this will make mixing dirs and classes official and I think we (as a developers team) can't support this kind of bad practices.
You can easily do now a workaround by yourself with as any type casting.

#255 is not shipped yet.

But you can do Object.values(middlewares) now, this proposal just make it a official way as a way to depreciate importing from dirs.

👍 thanks

dude stop using "depreciate importing from dirs" expression 😆


[MXNET-1260] Float64 DType computation support in Scala

Description
This PR introduces Float64/Double data type support in NDArrays in Scala. Currently we only allow precision upto Float32 in Scala as a result of which there are issues when one tries to load a model trained using float64 (in another language binding).
This also fixes two long standing issues : fixes https://github.com/apache/incubator-mxnet/issues/11315 & fixes https://github.com/apache/incubator-mxnet/issues/10338
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.

[x] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
[x] All changes have test coverage:
Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
[x] Code is well-documented:
For user-facing API changes, API doc string has been updated.
For new C++ functions in header files, their functionalities and arguments are documented.
For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
[x] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Comments

Interesting edge cases to note here
Need to complete the F64 support in other classes as well, and then test out and compare training of a model using float32 and float64. The comparison would be in terms of the precision of the loss, accuracy of the trained model, memory occupied by the model during training process.

@andrewfayres @lanking520 @zachgk

@lanking520 I have already added the Scala tests in NDArraySuite.scala class. It's in this commit : https://github.com/apache/incubator-mxnet/pull/13678/commits/5529f94796269d3ba94d74e24c0f98c4dd43b0df

@mxnet-label-bot remove [pr-work-in-progress]

@mxnet-label-bot Add [pr-awaiting-review]


[RDBMS] Support Private Endpoint Connections

Bump the azure-mgmt-rdbms SDK version to 2.0.0
Add two command groups:
az postgres private-endpoint: manage postgres private endpoint connections.
az postgres private-link-resource: manage postgres private link resources.
az mysql private-endpoint: manage mysql private endpoint connections.
az mysql private-link-resource: manage mysql private link resources.
az mariadb private-endpoint: manage mariadb private endpoint connections.
az mariadb private-link-resource: manage mariadb private link resources.

This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] The PR title and description has followed the guideline in Submitting Pull Requests.

[ ] I adhere to the Command Guidelines.

add to S166.

Could you please take a look those error in CI?
ERROR: {'load_commands': ModuleNotFoundError("No module named 'azure.mgmt.rdbms.mysql.operations.servers_operations'")}


docs(headless): added automatic documentation for actions

https://coveord.atlassian.net/browse/KIT-543
Follow-up to https://github.com/coveo/ui-kit/pull/659.
In this PR, I enabled resolving analytics actions.
This is not intended to be merged.

Closed because we're going to let go of namespaces after all.


chore: single atsdk export with a bunch of targets

- What I did

Redo of the package management
cmake/ folder contains the cmake code for the preferred way to fetch dependencies & build packages

Made it so we always use fetchcontent (no find_package) so that dependencies are coming from a consistent, pinned source & builds are reproducible (or as close as possible) across environments and runs

added a root CMakeLists.txt which builds the atsdk project and exports all of our packages and dependencies:

atsdk::atclient
atsdk::atchops
atsdk::atlogger
atsdk::uuid4-static
atsdk::cjson
atsdk::mbedtls
atsdk::mbedcrypto
atsdk::mbedx509
atsdk::everest (transitive dependency of mbedtls)
atsdk::p256m (transitive dependency of mbedtls)

Changed the "cjson/cJSON.h" to "cJSON.h" so that we can include straight from the build interface without directory manipulation

The ideal workflow is now:

build atsdk using the root cmake
use find_package or fetch content to link it in your application (as we do with our examples)

- How I did it
- How to verify it
- Description for the changelog
chore: single atsdk export with a bunch of targets

Tests need to be updated to work with this change. Essentially whatever we expect other folk to do when using the SDK, we need to do ourselves in the tests.

The reason that tests fail, is because most of us already have cjson installed on our local, so this enhancement I made fixes finding cjson based on the normal way of building.
GitHub actions runner doesn't have cjson installed, so when we try to build it, it seems that files are ending up in abnormal places. I'll have to redo the cjson build steps.

@realvarx commit https://github.com/atsign-foundation/at_c/pull/196/commits/115c966bb8f1575f95e436b2964b09950bb756ad should disable install / exports on the desktop which are not needed when building for espidf.

Okay, this is properly ready for review.

I can improve and start working on CI for using the SDK as a dependency


feat: remove treesitter integration

As discussed earlier, I'm moving treesitter out of the plugin, to another plugin, which will implement other less completion-related features.
I'll continue working on the completion framework, especially custom source integration.

Just figured that I forgot the ftplugin part. You can remove it if you want.

Ok that's fine, I can remove it.


Added datasource,dashboards as configmap & grafana dependency

Below changes are needed

Add grafana chart as dependency
Inject sidecar for grafana to load dashboard and datastore.
Move the grafana into helm-repo-tools
Incase grafana enabled true also deploy the dashboards & datastore.


When closing window with window X control, promise doesn't ends

Promise doesnt call nor succes, nor error, nor notify callbacks.

Yes, this I know and I am looking for a way to resolve this. But you can use kendo default close event to capture all closing events but then you have no access to the result.

I think, that when somebody closes window by X, result isn't needed at all. But it would be more consistent, if you can handle these events in single place,  something like:
windowPromise.then(function(result){//pressedok}, function(){ //window closed by dismiss or X});
If I remember right, bootstrap solved similar problem: X control is like regular button, which you can wire to any function. Maybe you can also expose some property to this close event? Or when press X, promise would return dismiss with null result?
P.S.: it is not a big problem for me - almost in all cases I can live without window close event handling.

ok thanks for the info. I will let you know what I come up with.

Any luck with this? I am basically using this window and have a Yes/No buttons in my view but would like a X button press or an ESC key press to also act as a "No" answer. Allowing a user to back out of this can lead to some data tracking issues for me.

Fixed with #30