chore(Mathlib/Algebra): minimize imports

rebasing, because !bench was broken, so has nothing to compare against.

!bench

!bench

!bench

Great! It looks like not only are imports being reduced, but they also seem to be sorted as well? I was going to suggest that, but from a quick glance, it appears it's already being handled simultaneously.

Yeah, I saw https://github.com/leanprover-community/mathlib4/pull/16419, which is great!
I hope that lands soon, so we can just have sorted imports to start with.
Many of the unsorted ones come from a time before we fixed how sorting is done in min_imports, I suspect.

!bench


Glossary / list of abbreviations and acronyms

As recommended by several tech reviewers
started in https://docs.google.com/document/d/1nutQVvmUbu0p82J69Opn90bm3agWm165xiWdbmHhBro/edit#

will have to be good enough, bit half assed but it will have to do. V2 will be better.


Create localization_vi.properties

Add Vietnamese language

Thank you for your contribution! Will add it to the next release soon!


Fixing total entries error for group by on field other than id with

count or sum in select
With https://github.com/drewolson/scrivener_ecto/pull/39, I partially
fixed the issue with grouping by field other than id, but then I
realized that it would still not work if there was a count or sum in the
select.
The is a more complete solution. If there is a group by clause, it
uses the first column in the group by clause for the total entries
select.
Fixes #35
Fixes #39

When working on this, I did not find a public function in Ecto that exposed the group by fields, so I ended up pattern matching/reaching into Ecto's interal modeling.
The main places looked were:

https://github.com/elixir-ecto/ecto/blob/master/lib/ecto/repo/queryable.ex
https://github.com/elixir-ecto/ecto/blob/master/lib/ecto/query/builder/group_by.ex
https://github.com/elixir-ecto/ecto/blob/master/test/ecto/query/builder/group_by_test.exs
https://github.com/elixir-ecto/ecto/blob/master/lib/ecto/query.ex
https://github.com/elixir-ecto/ecto/blob/master/test/ecto/query_test.exs

It seems like how scrivener_ecto used to handle this was always exclude the select clause, then Ecto will add a default SELECT id. This works for most cases, but not for queries that GROUP BY something that does not include id. I then went with an approach of excluding select if there is not GROUP BY, else leave the select. Later I realized this would work, unless the select caluse included things that Ecto subquery are not allowed to have (fragments, counts, sums, etc).
Ecto's Subquery is pretty restricitve in what can be in select. Would be nice if we could just do:
SELECT COUNT(*)
FROM (
  SELECT 1
  <user provided query exclude select>
)

but if we try to use a fragment to do SELECT 1, we get an error like:
** (Ecto.QueryError) subquery must select a source (t), a field (t.field) or a map

That is when I got the idea to just use the first part of the group by for the select.
I do not know of a way to accomplish this without reaching so directly into Ecto's internal modeling, but maybe there is a way I am not seeing. Any ideas?

Thanks again for the PR. I've merged it an released a new version of the library.


chore: update stylelint packages

Applies major version upgrades to stylelint, stylelint-config-standard & stylelint-config-standard-scss.

license_finder raised query over BlueOak-1.0.0 licenses for jackspeak and path-scurry. Provisional approval to use packages with these licenses given by Suzanne Hamilton in this slack thread.


updated fix for controlling depth.

Picks up a fix for controlling depth of parsing.

Since we fork newtonsoft do we normally pull in their tests too are do we assume we'd catch a regression here another way --OR-- are we simply saying that since since we don't intend to touch this code we're relying on the newtonsoft tests running in their repo?
Other than that LGTM. I think generally if we have the code in our repo we should have the tests in our repo too.

@TimHannMSFT i didn't see any test code for NewtonSoft in our branch.


Token Contract - Should it be possible to burn when frozen?

Closed because we decided that it should be possible to for the admin to clawback (formerly called burn) a deauthorized (formerly called frozen) balance. This has been implemented.


strange setter/getter behaviors

Consider the following code:
  import { deepSignal }  from<EMAIL_ADDRESS>
  class TestClass {
    _Prop = 0

    get Prop () { return this._Prop }
    set Prop (newValue) {
      this._Prop = newValue
      this.logIt()
    }

    logIt () {
      console.log('internal report: Prop was just set to',this.Prop)
    }
  }

  let Test = deepSignal(new TestClass())

/**** now run some tests ****/

  console.log('observe "Test.Prop"')
  effect(() => {
    console.log('>>>> external effect: current "Prop" is now',Test.Prop)
  })

  console.log('\nsetting Test.Prop to 1\n\n')
  Test.Prop = 1

  console.log('\nsetting Test.Prop to 2\n\n')
  Test.Prop = 2

(mind the import statement which imports your published module without any of my modifications!)
This code produces the following output:
observe "Test.Prop"
>>>> external effect: current "Prop" is now 0

setting Test.Prop to 1

>>>> external effect: current "Prop" is now 0
internal report: Prop was just set to 0
>>>> external effect: current "Prop" is now 1

setting Test.Prop to 2

>>>> external effect: current "Prop" is now 1
internal report: Prop was just set to 1
>>>> external effect: current "Prop" is now 2

I don't really worry about the useless effect callback invocations for already set values (although they are a bit ugly), but I worry about getter invocations following a set operation which still deliver an old value!
Do you have any idea?

I'm currently trying to find the underlying reason for the described (mis)behavior - right now by placing additional log statements. The current output
setting Test.Prop to 1

set TestClass {_Prop: 0} Prop 1
set TestClass {_Prop: 0} _Prop 1
defineProperty TestClass {_Prop: 0} _Prop {value: 1}
get TestClass {_Prop: 1} Prop Proxy(TestClass) {_Prop: 1}
get TestClass {_Prop: 1} _Prop Proxy(TestClass) {_Prop: 1}
get returns: false 1
get returns: false 0

indicates that - given the Getter from TestClass
get Prop () { return this._Prop }

the expression this._Prop evaluates properly, but the getter itself returns an outdated value instead...

Ok, here is my current hypothesis:
in file core/src/index.ts, after line 78, shouldn't there be an additional line like
signals.get(key).value = value

perhaps within an else clause?

my first tests were successful, at least

Hey @rozek, I think I'm going to prevent the use of classes and only allow plain JS objects. Even if the current fix seems to be just 1-2 lines long, I don't want to start supporting them because that would mean fixing bugs and dealing with edge cases in the future.
Related PR:

https://github.com/luisherranz/deepsignal/pull/46

oh, that's bad because the use of classes is mandatory for me (e.g., because of custom web components)

What prevents you from using a deepsignal prop inside the class? like this.state for example.

because users of my classes will only see getters and setters - and these should be reactive

And what prevents you from using regular objects instead of classes for that purpose?

inheritance?

I see. Well, I'm afraid that you will need to keep maintaining your own fork for the time being as supporting class instances is out of my scope at the moment. I'm sorry about that. I may reconsider it in the future, though.

under the hood, JavaScript classes are nothing but constructor functions and property chains - therefore I guess you see problems with these chains...

yes, I was thinking about implementing my own variant of nested signals anyway - given the amount of resources I already spent evaluating and tweaking "deepsignals" and "preact-observables" (the latter fails with a very subtle and, thus, extremely nasty race condiction...)

but, nevertheless, thank you very much for your work!

No problem, thanks to you for your contributions to this library @rozek 🙂


[stable/sonarqube] ./bin/run.sh: line 24: exec: java: not found

Simple that, no work.

Same error here for v1.1.1. I was able to make it work downgrading to chart version v1.1.0.
helm install stable/sonarqube --version 1.1.0


Copy and Pasting Cell Doesn't work in deployed Blazor Server site but works locally

At this time, I am using the BlazorDataSheet in a Blazor Server project.  I noticed that while the Copy and Paste functionality works when I debug locally in VS 2022, if I deploy the code to the IIS server and do a Control+C to copy, I see the following error in the Developer Tools Window:
blazor.server.js:1  Uncaught (in promise) Error: There was an exception invoking 'HandleWindowKeyEvent'. For more details turn on detailed exceptions in 'CircuitOptions.DetailedErrors'
    at y.endInvokeDotNetFromJS (blazor.server.js:1:3305)
    at Xt._invokeClientMethod (blazor.server.js:1:60890)
    at Xt._processIncomingData (blazor.server.js:1:58279)
    at Xt.connection.onreceive (blazor.server.js:1:51920)
    at hn._poll (blazor.server.js:1:75044)

I am also seeing this
blazor.server.js:1
 Uncaught (in promise) Error: Microsoft.JSInterop.JSException: Cannot read properties of undefined (reading 'writeText')
TypeError: Cannot read properties of undefined (reading 'writeText')
    at window.writeTextToClipboard (blazor-datasheet.js:2:38)
    at blazor.server.js:1:3047
    at new Promise (<anonymous>)
    at y.beginInvokeJSFromDotNet (blazor.server.js:1:3004)
    at Xt._invokeClientMethod (blazor.server.js:1:60890)
    at Xt._processIncomingData (blazor.server.js:1:58279)
    at Xt.connection.onreceive (blazor.server.js:1:51920)
    at :82/hn._poll (http:/…server.js:1:75044)
   at :82/Microsoft.JSInte…er, Object[] args)
   at :82/Microsoft.JSInte…er, Object[] args)
   at :82/BlazorDatasheet.…ipboard.cs:line 27
   at :82/BlazorDatasheet.….razor.cs:line 859
   at :82/BlazorDatasheet.….razor.cs:line 618
   at :82/BlazorDatasheet.…anager.cs:line 115
   at :82/BlazorDatasheet.….razor.cs:line 597
   at :82/BlazorDatasheet.….razor.cs:line 718
   at :82/BlazorDatasheet.…Service.cs:line 117
    at window.writeTextToClipboard (blazor-datasheet.js:2:38)
    at blazor.server.js:1:3047
    at new Promise (<anonymous>)
    at y.beginInvokeJSFromDotNet (blazor.server.js:1:3004)
    at Xt._invokeClientMethod (blazor.server.js:1:60890)
    at Xt._processIncomingData (blazor.server.js:1:58279)
    at Xt.connection.onreceive (blazor.server.js:1:51920)
    at :82/hn._poll (http:/…server.js:1:75044)
   at :82/Microsoft.JSInte…er, Object[] args)
   at :82/Microsoft.JSInte…er, Object[] args)
   at :82/BlazorDatasheet.…ipboard.cs:line 27
   at :82/BlazorDatasheet.….razor.cs:line 859
   at :82/BlazorDatasheet.….razor.cs:line 618
   at :82/BlazorDatasheet.…anager.cs:line 115
   at :82/BlazorDatasheet.….razor.cs:line 597
   at :82/BlazorDatasheet.….razor.cs:line 718
   at :82/BlazorDatasheet.…Service.cs:line 117
    at y.endInvokeDotNetFromJS (blazor.server.js:1:3305)
    at Xt._invokeClientMethod (blazor.server.js:1:60890)
    at Xt._processIncomingData (blazor.server.js:1:58279)
    at Xt.connection.onreceive (blazor.server.js:1:51920)
    at hn._poll (blazor.server.js:1:75044)

Are you serving over https? I'm using the clipboard API which requires a secure context: https://developer.mozilla.org/en-US/docs/Web/Security/Secure_Contexts
I should add a check to the datasheet that the user is in a secure context before using the clipboard.

I confirmed that adding an SSL certificate to the site solved the issue and now copy (Control + C) works. Thank you for your response.


LibGfx: Let Painter care about TinyVG transforms

This helps us with non-uniform scales, and makes things simple

Rebased on master just in case


Adds parameter 'msg' to tf.TensorFlowTestCase.

This commit adds a msg parameter that defaults to None to the following
functions:

assertProtoEquals
assertArrayNear
assertNDArrayNear
assertAllClose
assertAllEqual
assertShapeEqual
assertDeviceEqual

Closes #15729.

Thanks for reviewing :)
Did the matrix_triangular_solve_op_test time out? It took 177.3 seconds and I don't spot a failure log.


XMLHttpRequest override conflicts with InboxSDK

I'm using an old version of gmailjs which attaches the xhr watcher the same way as the newest src and the xhr watchers do not watch anymore when an extension using the newest InboxSDK is in gmail as well.
AnyPerk extension that fails xhr_watch:
https://chrome.google.com/webstore/detail/anyperk-extension/hibhcpjgdocamgallhmphmmjeahifgof?hl=en-US
EDIT: This is wrong, not sure why it's failing->
It has to do with monkey patching on js_frame versus some other way of monkey patching that InboxSDK uses which seems to override ours instead of monkey patching it.

Do you have a link to the InboxSDK or example usage of it? Right now I'm lacking a bit context.

Testing it some more it might not be InboxSDK itself. But the anyperk extension uses inboxSDK (gmail extension framework https://www.inboxsdk.com/) and it's not triggering the xhr watcher for my app. Not sure if it will also break the newest version of gmailjs.
here's the link to the extension. If the xhr trigger still works on send when this is installed after reloading gmail then it's my app specific.
https://chrome.google.com/webstore/detail/anyperk-extension/hibhcpjgdocamgallhmphmmjeahifgof?hl=en-US

I think it's actually just any perk or a different library. Uses some js file called gmail_main.js


Decide

Reading the project requirement thoroughly
Reading the two research papers related to QSAR for better understanding
Going through the dataset manually
Deciding on the techniques that need to be used: logging, linting, data version control, MLOPS, deployment, etc.

Done
Done
Done
logging --> python logging library, linting --> not using, data version control --> using to automate the code running, deployment, and front-end --> Python streamlit library


Update marketing-cloud-cohort-v2.md

Amplitude Developer Docs PR
Description
Describe your changes.
Deadline
When do these changes need to be live on the site?
Change type

[ ] Doc bug fix. Fixes #[insert issue number]. Amplitude contributors include Jira issue number.
[ ] Doc update.
[ ] New documentation.
[ ] Non-documentation related fix or update.

PR checklist:

[ ] My documentation follows the style guidelines of this project.
[ ] I previewed my documentation on a local server using mkdocs serve.
[ ] Running mkdocs serve didn't generate any failures.
[ ] I have performed a self-review of my own documentation.

@amplitude-dev-docs

re-opened in #802

Sorry I am trying to get AWS to work. Still might be due to some current downtime in AWS services


Why don't you have any unit tests?

I want to use this boilerplate to FULL SPEC VUE DEVELOPMENT (with tests).

Thanks.
I intend to add an example for unit testing with Karma + avoriaz + mocha.
I'm gonna use avoriaz until Vue.js official team publishes vue-test-utils beta.

I added a unit test☺
Changes: #15


List of top 10 algorithms in Interview Questions

Description
Description
Here is a list of top 10 algorithms that one should prepare for an Interview.
Domain
Interview Prep
Type of Contribution
Documentation
Code of Conduct

[X] I follow Contributing Guidelines & Code of conduct of this project.

/assign


[BUG] The fuse pod not be created when a nfs pvc mount

What is your environment(Kubernetes version, Fluid version, etc.)
Kubernetes version: 1.21
Fluid version: v1.0.2
Runtime type：AlluxioRuntime
Describe the bug
I created the pv/pvc use nfs, and mount the pvc in dataset，Then I created a test task to verify the acceleration functionality, but after the task ended, the data was not loaded into the worker's memory, and the fuse-pod was not created as well.
so, I want to know if the fuse-pod is necessary when I use an NFS PVC.
What you expect to happen:
use kubectl get dataset  can see the process of  CACHED  or in dir /mnt/dev ··· of worker I can see the block file cached
How to reproduce it
Additional Information

I think I've identified the cause of the problem. When I using PVC, Fluid creates PVC/PV of the Fluid type. In my testing task, I should have used a new PVC instead of the old one."


Add minimal Docker image build instructions

Update README to include instructions for building from source a minimal Docker image containing only ctop.

looks good; thanks!


Improve the documentation

Make it more elaborate for new contributors to understand how to go about with the github commands

I would like to work on this issue undergssoc'23

i would like to work on this

@debdutta04 The issue has already been wrapped up, please explore other issues to contribute to


Fix URLs for TA lib

Hello @khiemdoan,
If you want to check over the development branch, that would be great. Fixes and all flow through it.
KJ

Updated! Thanks


undefined method `change_row_font_size' - rails 52 ?

i'm fighting an issue with a very strange class loading issue as it seems. somehow the convenience methods are not loaded correctly under rails 5.2? somehow with version 3.3.33 the issue doesn't exist.

I recommend that you read the documentation, specifically the Convenience methods section.


M05-Unit 4 Deploy Azure Application Gateway - Azure UI has changed

Module: 05
Unit: 04
Task: 01
Step: 05
Description of issue
Azure UI for Application Gateway has apparently changed since instructions were written: the option to create a new subnet right from the dialog referenced no longer appears:

Currently, a valid workaround is to create the 'BackendSubnet' in 'ContosoVNet' virtual network once the Application Gateway has successfully been created by Azure in Step 27.

A note has been added to the exercise. Not all UI have updated to this format.


Documentation for env vars

We use BUILD_CONFIG and process.env.TEST, and maybe others -- we should have documentation of what information can be provided, what the values mean, and when and why to use either. This is useful for myself, new contributors, and probably others on the team.

Ok


add character on FNF spy engine

Describe your bug here.
heya, i try to create an custom characters for my own mods FNF, but when i try to load it i have this error

someone can help me please :,(((((
Command Prompt/Terminal logs (if existing)
No response
Are you modding a build from source or with Lua?
Source
What is your build target?
Windows
Did you edit anything in this build? If so, mention or summarize your changes.
i change different assets and add custom notes

this is Psych Engine not Spy Engine

not a bug check the xml or send it over

this is the xlm file

it's supposed to be this

didn't you use adobe animate or this software https://github.com/UncertainProd/FnF-Spritesheet-and-XML-Maker


DataCloneError: FormData object could not be cloned

Trying to add FormData to IDB using Dexie on Angular results in the above error. This is the case even if FormData is empty so it has nothing to do with contained items.
The MDN structured clone docs mention that FormData cloning is supported. Is this due to Angular messing with FormData objects then? console.log(formData) displays an empty object which seems weird. Iterating over formData's properties won't show anything accordingly.

Hard to tell. You're right FormData should be clonable and storable in IDB according to spec, but I have no explicit test for it. I think you need to find out whether the formdata is an actual FormData instance or an NG-specific FormData.

Seems like it's native FormData we're talking about.
Created a stackblitz showing the issue: https://stackblitz.com/edit/angular-issue-repro2-k5dtnx
Chrome 75: "FormData object could not be cloned"
FF 67: same
Since a native IDB call results in the same error, it's probably not a bug in Dexie but MDN/specs.

I think I was wrong about FormData. It's not part of the structured cloning algorithm: https://github.com/whatwg/html/issues/633 so behavior is expected in IndexedDB.

MDN is wrong then, see the FormData entry in Supported types table (in row Object) at https://developer.mozilla.org/en-US/docs/Web/API/Web_Workers_API/Structured_clone_algorithm

Any news on this? Suffering the same issue. Thought FormData should be cloneable?

Any news on this? Suffering the same issue. FormData doesn't seam to be cloneable The structured clone algorithm. Guess it should get supported, it's nothing but a {[key: string]: File | string } where File is almost a Blob.

This is a limitation in the W3C standard and nothing that dexie should work around IMHO.

Yeah, your totally right! Just wanted to take part in this discussion. Here my solution right now:
    if (serializedRequest.body instanceof FormData) {
        serializedRequest.body = Array.from(request.body.entries());
        serializedRequest.bodySerializationType = 'form';
    }

    switch (request.bodySerializationType) {
        case 'form': {
            const formData = new FormData();
            for (const e of <[string, FormDataEntryValue][]>body) { formData.append(e[0], e[1]); }
            body = formData;
        } break;
    }

and put this object in the store.
@dfahlander, where to bring up the idea to natively support FormData by W3C? Do you have an idea?


Automated testing framework

[x] Setup Ava
[x] test command
[x] Add to README

https://github.com/itsjoekent/mr.ringer/commit/8fd35179f0e63db9533ba414fd44bdc76d6c6653


AirEquipment

Existing definitions for the WireEquipment have to be complemented by definitions for the AirEquipment.

Proposal to the 5G-xhaul call on 11th of January 2023:

A new example should be added to paragraph 7 for AirInterface very similar to WireInterface.
The following text should be added as Example 12 after Existing example 11:

Example ??: As soon as an ExpectedEquipment object representing a radio has been instantiated, the device shall automatically instantiate a related LTP(AirInterface)[foodnote-below1]. In addition the LTP(PureEthernetStructure)[7] or the LTP(HybirdMwStructure)[foodnote-below2] shall be instantiated including the client/server relationships based on the device capabilities.

The following 2 footnotes should be added to explain the meaning of LTP(AirInterface) and LTP(HybirdMwStructure).

[footnote-below1]
LTP(AirInterface) = LogicalTerminationPoint and LayerProtocol object, which are augmented by technology
specific information about a AirInterface and the value of its layerProtocolName attribute =
“LAYER_PROTOCOL_NAME_TYPE_AIR_LAYER”.

[footnote-below2]
LTP(HybirdMwStructure) = LogicalTerminationPoint and LayerProtocol object, which are augmented by technology
specific information about a HybirdMwStructure and the value of its layerProtocolName attribute =
LAYER_PROTOCOL_NAME_TYPE_HYBRID_MW_STRUCTURE_LAYER”.

Starting from TransmitterEquipment_i.j.k-tsp.231213.1100+spec.1 changed as decided.

Has been updated and published in TransmitterEquipment_1.0.0-tsp.200715.1225+spec.1.doc


Prettier Layout

Current layout should be updated to more eye-catching UI

Layout has been fine-tuned and general design has been completed.
It took 5 hours to complete the final touches of the project.


Middleware provider: Filtering out all the host controllers (except t…

there are 2 changes in the code:

The first one (middleware_manager.rb) changes the way how the domains are fetched from the provider. We basically count, how many domain controllers are in the hawkular-inventory. Not every host controller is also a domain controller so this needs to be assured, this information is in the resource configuration.
The second change is about how the domain servers are fetched. Before we asked about all the children resources of the host/domain controller. This was we obtained the information about which host has which server, but domain is an abstract concept (not dealing with where is each server running) so now we just asked the feed about all the resources of type Domain WildFly Server. This is faster then filtering all the child resources in memory based on the type, but it assumes that there is only 1 domain per feed which is always true, afaik.

@pilhuhn could you please correct me if I am wrong with my assumption?
for QA: see reproduction steps in the issue description.
@miq-bot add_label providers/hawkular, bug, euwe/yes

I think the assumption is correct as the agent (=the feed) is sitting inside the DC and will no talk to remote DC or standalone servers.
@Jiri-Kremser Looks like you need to (re-) record a cassette:
https://travis-ci.org/ManageIQ/manageiq/jobs/169501661#L1175

@josejulio could you please look?

@Jiri-Kremser
I might be missing something, but I guess that you can have more than one domain/standalone per feed by configuring remote-dmr types

feed 9d31... is the hawkular-services server with embedded agent and feed master.Un... is a DC with an agent, with the default local-dmr and remote-dmr to talk with another DC.

// cc @pilhuhn

I've tested this PR on my local.
With only one DC/feed it works well but with 2 DC in one feed (one local and one remote) I get the following error:
EmsRefresh::Refreshers::EmsRefresherMixin::PartialRefreshError: unknown attribute '_object' for MiddlewareServerGroup.
 (43.6ms)  COMMIT
	from /home/josejulio/Documentos/redhat/manageiq/app/models/ems_refresh/refreshers/ems_refresher_mixin.rb:50:in `refresh'
	from /home/josejulio/Documentos/redhat/manageiq/app/models/manageiq/providers/base_manager/refresher.rb:10:in `refresh'
	from /home/josejulio/Documentos/redhat/manageiq/app/models/ems_refresh.rb:91:in `block in refresh'
	from /home/josejulio/Documentos/redhat/manageiq/app/models/ems_refresh.rb:90:in `each'
	from /home/josejulio/Documentos/redhat/manageiq/app/models/ems_refresh.rb:90:in `refresh'
	from (irb):5
	from /home/josejulio/.gem/ruby/2.3.1/gems/railties-<IP_ADDRESS>/lib/rails/commands/console.rb:65:in `start'
	from /home/josejulio/.gem/ruby/2.3.1/gems/railties-<IP_ADDRESS>/lib/rails/commands/console_helper.rb:9:in `start'
	from /home/josejulio/.gem/ruby/2.3.1/gems/railties-<IP_ADDRESS>/lib/rails/commands/commands_tasks.rb:78:in `console'
	from /home/josejulio/.gem/ruby/2.3.1/gems/railties-<IP_ADDRESS>/lib/rails/commands/commands_tasks.rb:49:in `run_command!'
	from /home/josejulio/.gem/ruby/2.3.1/gems/railties-<IP_ADDRESS>/lib/rails/commands.rb:18:in `<top (required)>'
	from /home/josejulio/Documentos/redhat/manageiq/bin/rails:4:in `require'
	from /home/josejulio/Documentos/redhat/manageiq/bin/rails:4:in `<top (required)>'
	from /home/josejulio/.gem/ruby/2.3.1/gems/ruby-debug-ide-0.6.0/lib/ruby-debug-ide.rb:88:in `debug_load'
	from /home/josejulio/.gem/ruby/2.3.1/gems/ruby-debug-ide-0.6.0/lib/ruby-debug-ide.rb:88:in `debug_program'
	from /home/josejulio/.gem/ruby/2.3.1/gems/ruby-debug-ide-0.6.0/bin/rdebug-ide:130:in `<top (required)>'
	from -e:1:in `load'
	from -e:1:in `<main>'

2 DC in one feed (one local and one remote)

Hmm, isn't this actually 2 feeds, not sure if we support such a hybrid case.
I think, that you hit the scenario when 2 DC have the same name. Now, the feed_id is obtained from the name of the domain controller and concatenated with the name of the domain
host.xml:
<host xmlns=".." name="master"

domain.xml:
<domain xmlns=".." name="whatever"

If there is nothing in the domain.xml the "Unnamed domain" is used. I'd bet, there will be a different ways to set the feed id, but this is the implicit one.

I setup it like this:

EAP+Hawkular Agent I set in the domain.xml the name to using_local.
Remote EAP I wrote in the domain.xml the name to using_remote .

and got the following feeds:

fef31b18-... is the hawkular-services.

So I guess that you can have two DC (or more) on the same feed, unless I'm doing something really wrong.
@jmazzitelli could you please help us here?

Anyway, this LGTM if multiple DC on the same feeds are not supported.

LGTM. @blomquisg - review/merge?

@miq-bot assign @blomquisg

@Jiri-Kremser do you have a BZ link for this one?

@blomquisg there is no BZ for it, but it should go into euwe, do you want me to create one?

@Jiri-Kremser will be great if you can create a BZ for this PR.


multipart with fields without content type won't pass validation

In #44 support for multipart request was improved. If you send fields with files (which have content-type), it works ok. But if a field without content type is included, an exception will be thrown:
Message: preg_match() expects parameter 2 to be string, null given
File: /app/vendor/lezhnev74/openapi-psr7-validator/src/PSR7/Validators/BodyValidator/MultipartValidator.php
Line: 178

Added a quick fix in fork

Would you mind open a PR?


[Bug]: Editing Workbench Does Not Respect Zero GPUs

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
When we are in edit mode of an existing workbench within a DS Project -- setting zero GPUs is actually considered not doing anything with GPUs... whereas if the workbench ever had GPUs enabled, it would then never be able to remove the GPU setting from the value it was last set to zero.
Expected Behavior
We should look to clear the GPU setting when GPUs are set to zero if they are already on a workbench.
Steps To Reproduce

Have a Workbench with a configured GPU setting
Edit the Workbench in the DS Project UI
Set the GPU value to 0
Save the Workbench with no other changes

-- we should have zero configured at this point on this workbench --
Workaround (if any)
No response
What browsers are you seeing the problem on?
No response
Open Data Hub Version
2.5.2

Anything else
For development clusters without GPUs, you could possibly use the gpuSetting value in the DashboardConfig to fake GPUs -- your pod likely won't start, but it should be an effective test (which we will need to verify on cluster at some point).

where gpuSetting must be set? I tried setting it in odh-dashboard-config under spec.dashboardConfig or under spec but it gets automatically deleted (operator was scaled down to 0 before doing that).
Plus, would the syntax be: gpuSetting: <number_of_gpus>?


chore: add docker push step in GH action for CI

Add docker push step in GH action for CI

Codecov Report

Merging #24 into main will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #24   +/-   ##
=======================================
  Coverage   43.55%   43.55%
=======================================
  Files           6        6
  Lines         326      326
=======================================
  Hits          142      142
  Misses        159      159
  Partials       25       25

Flag
Coverage Δ

#unittests
43.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9eb8b3...a3e1fdf. Read the comment docs.


Dacpac - Showing error message to user if operation fails

Pull Request Test Coverage Report for Build 426861263

20 of 20 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 43.116%

Totals

Change from base Build 426825454:
0.02%

Covered Lines:
24131

Relevant Lines:
51284

💛  - Coveralls


Update the Github templates for pull requests and issues

What problem does the pull request solve?
It updates the pull request and issue templates, in an attempt to encourage their usage - and to provide structure to the issues raised and pull requests opened for GOV.UK elements.
What does it do?

uses smaller headings
removes the checkboxes, as these imply that a choice is a set of things to be completed
requests that lines that don't apply are deleted

What type of change is it?

New feature (non-breaking change which adds functionality)

Put an x in all the boxes that apply

I have read the CONTRIBUTING document.

Much better!


✨ Add reset_metadata parameter to .load()

Fix for https://github.com/owid/etl/issues/3724#issuecomment-2546229678
ds.load(reset_metadata=True) lets you load a dataset and reset all its metadata (origins, titles, etc.). This is especially useful when working with population table. Division by population could propagate unwanted metadata such as presentation.title_public.

Nice!
Would it be possible to preserve the origins? I've had a go in this PR. I was thinking we probably still want to record in the origins when we've used population (etc) to create a new variable, but it's the other parts of the VariableMeta() that we would want to be rid of.

Closing in favour of https://github.com/owid/etl/pull/3731#pullrequestreview-2511498649


Issue with note and footnote

I'm trying to make some changes to my https://homebrewery.naturalcrit.com/share/BysI7Osof PDF and ran into a few issues:

̶A̶l̶t̶h̶o̶u̶g̶h̶ ̶t̶h̶e̶ ̶N̶O̶T̶E̶ ̶c̶o̶d̶e̶ ̶i̶s̶ ̶w̶o̶r̶k̶i̶n̶g̶ ̶p̶e̶r̶f̶e̶c̶t̶l̶y̶ ̶o̶n̶ ̶p̶a̶g̶e̶s̶ ̶3̶ ̶a̶n̶d̶ ̶5̶,̶ ̶i̶t̶'̶s̶ ̶n̶o̶t̶ ̶w̶o̶r̶k̶i̶n̶g̶ ̶a̶s̶ ̶i̶n̶t̶e̶n̶d̶e̶d̶ ̶o̶n̶ ̶p̶a̶g̶e̶ ̶4̶:̶ ̶y̶o̶u̶ ̶c̶a̶n̶ ̶s̶e̶e̶ ̶t̶h̶e̶ ̶>̶ ̶i̶c̶o̶n̶ ̶t̶h̶a̶t̶ ̶b̶r̶i̶n̶g̶s̶ ̶u̶p̶ ̶t̶h̶e̶ ̶n̶o̶t̶e̶ ̶c̶o̶d̶e̶ ̶a̶n̶d̶ ̶t̶h̶e̶ ̶g̶r̶e̶e̶n̶ ̶b̶a̶c̶k̶g̶r̶o̶u̶n̶d̶ ̶r̶i̶b̶b̶o̶n̶ ̶w̶o̶n̶'̶t̶ ̶a̶p̶p̶e̶a̶r̶ ̶a̶s̶ ̶i̶t̶ ̶s̶h̶o̶u̶l̶d̶.̶ ̶I̶ ̶d̶o̶n̶'̶t̶ ̶k̶n̶o̶w̶ ̶h̶o̶w̶ ̶t̶o̶ ̶f̶i̶x̶ ̶i̶t̶ ̶s̶i̶n̶c̶e̶ ̶I̶'̶v̶e̶ ̶u̶s̶e̶d̶ ̶t̶h̶e̶ ̶e̶x̶a̶c̶t̶ ̶c̶o̶d̶e̶ ̶e̶v̶e̶r̶y̶ ̶t̶i̶m̶e̶ ̶a̶n̶d̶ ̶i̶t̶ ̶o̶n̶l̶y̶ ̶a̶p̶p̶e̶a̶r̶s̶ ̶t̶o̶ ̶b̶e̶ ̶w̶o̶r̶k̶i̶n̶g̶ ̶3̶/̶4̶ ̶t̶i̶m̶e̶s̶.̶ > seems to be working normally again

̶I̶ ̶c̶h̶a̶n̶g̶e̶d̶ ̶m̶y̶ ̶f̶o̶o̶t̶n̶o̶t̶e̶ ̶f̶r̶o̶m̶ ̶"̶C̶r̶e̶a̶t̶e̶d̶ ̶b̶y̶ ̶M̶i̶n̶a̶k̶i̶e̶"̶ ̶t̶o̶ ̶"̶N̶o̶t̶ ̶f̶o̶r̶ ̶r̶e̶s̶a̶l̶e̶.̶ ̶P̶e̶r̶m̶i̶s̶s̶i̶o̶n̶ ̶g̶r̶a̶n̶t̶e̶d̶ ̶t̶o̶ ̶p̶r̶i̶n̶t̶ ̶o̶r̶ ̶p̶h̶o̶t̶o̶c̶o̶p̶y̶ ̶t̶h̶i̶s̶ ̶d̶o̶c̶u̶m̶e̶n̶t̶ ̶f̶o̶r̶ ̶p̶e̶r̶s̶o̶n̶a̶l̶ ̶u̶s̶e̶ ̶o̶n̶l̶y̶.̶"̶ ̶a̶n̶d̶,̶ ̶a̶l̶t̶h̶o̶u̶g̶h̶ ̶i̶t̶ ̶w̶o̶r̶k̶e̶d̶ ̶a̶s̶ ̶i̶n̶t̶e̶n̶d̶e̶d̶ ̶o̶n̶ ̶m̶o̶s̶t̶ ̶p̶a̶g̶e̶s̶,̶ ̶o̶n̶ ̶p̶a̶g̶e̶s̶ ̶4̶ ̶a̶n̶d̶ ̶7̶ ̶t̶h̶e̶ ̶o̶l̶d̶ ̶o̶n̶e̶ ̶i̶s̶ ̶s̶t̶i̶l̶l̶ ̶s̶h̶o̶w̶i̶n̶g̶ ̶b̶e̶l̶o̶w̶ ̶t̶h̶e̶ ̶n̶e̶w̶ ̶o̶n̶e̶.̶ ̶I̶ ̶h̶a̶v̶e̶ ̶n̶o̶ ̶i̶d̶e̶a̶ ̶h̶o̶w̶ ̶t̶o̶ ̶d̶e̶l̶e̶t̶e̶ ̶i̶t̶ ̶s̶i̶n̶c̶e̶ ̶t̶h̶e̶ ̶o̶l̶d̶ ̶f̶o̶o̶t̶n̶o̶t̶e̶ ̶i̶s̶ ̶n̶o̶t̶ ̶e̶v̶e̶n̶ ̶w̶r̶i̶t̶t̶e̶n̶ ̶i̶n̶ ̶t̶h̶e̶ ̶c̶o̶d̶e̶ ̶a̶n̶y̶m̶o̶r̶e̶.̶ > seems to be working normally again

Also, I'd like to know how to make the footnote go all across the page instead of following the 2 columns by page pattern. I've seen it in other people's PDF's but have no idea how to do it.

On that note, I'd like to know if there's a way to make the text automatically jump to the 2nd column other than just filling the code with endless br codes like I've been doing so far.

The link so you can take a look at the coding is here: https://homebrewery.naturalcrit.com/edit/r1gj87dosf
Many thanks.

I'm not seeing your issues. All notes look fine and your footnote looks the same throughout.  I don't know what would have happened but it's gone now. Let us know if it happens again.
You can change the format (position, width, color, etc.) of the footnote by editing the HTML a bit. It's just normal HTML.  So something like:

 Not for resale. Permission granted to print or photocopy this document for personal use only.

You can start a new column by inserting a "column break", the first item listed under the "Edit" menu.

Also, you should be sharing the 'share' link not your 'edit' link. the edit link lets anyone edit your copy. with the share link your stuff is safe(r) from evildoers. People can look at your source code from the share link just fine by clicking the "source" button on the top right.

Don't worry about that, I've been on the internet long enough. The edit link I shared is a copy of my main edit link, which is private. I just copied the entire coding to a new document into a new one. ;)
Also, I have a code on my cover page to remove the yellow border on the bottom of the page, but that code only seems to work on the 1st page. Is there a way to make that code work on the counter-cover as well?

The automatic column break code seems to be working on some pages but not others. It worked normally on the Contents page but not on the Feedback page: https://homebrewery.naturalcrit.com/share/BysI7Osof
It's as if that code is not even there.

Don't worry about that, I've been on the internet long enough. The edit link I shared is a copy of my main edit link. I just copied the entire coding to a new document into a new one. ;)

The share link is still preferred, because clicking on your edit link adds any viewer as an author, and now they have your document showing up in their personal profile; the only way for that person to get rid of it is to delete it, which will delete your copy too. Even if it's a backup copy, I don't need my own homebrew list cluttered with other people's work. As I said, we can see your code easily from just the share link. ;)
In any case, I don't see any problem on your page 10 with the Volcanic elves. It looks like the text properly flows into the next column. Perhaps you could post a screenshot of the issue?

In any case, I don't see any problem on your page 10 with the Volcanic elves. It looks like the text properly flows into the next column. Perhaps you could post a screenshot of the issue?

It's page 11 now. The page count keeps changing, sorry.

Ahhhhh.... I see it now. I have isolated the problem down to a minimal piece of code, but I can't tell why it's doing that; you are right, the code looks fine.
For now, you can try adding some blank lines immediately after your
s, because in the past that has been known to garble the resulting page, and it seems to solve your problem as well.

Closing since there hasn't been a reply from the user for a while and it is assumed the problem was solved.
If you are still experiencing this issue, feel free to reopen and provide information, @Minakie


Better Name

We still didn't come up with the proper name. Leave your suggestions in the comments. The name should be short ('cause we don't wanna type to much in the terminal to start the editor) and memorable.

Maybe Gramo because it will be lighter and powerful than Kilo?

I like the current one: te. It reminds me of tea.

It could be called tsode or tsoed

te - tsode editor

Kod Editor
Kot Editor
© Coopert1n0 from Twitch chat

After the last PR #8 there was a suggestion to call the editor dred:

yoda_droid: Lets rename this dred for DRamatic EDitor

I like the name JANE (Just ANother Editor), it sounds good and is self describing enough

To me, as it's a Graphical Text Editor it should have g in the name. So I think gtee should be cool. gtee stands for Graphical TExt Editor

tte (abbr. Tsoding text editor)
voidf (Because the background is dark like void)

none: non editor

txte pronounced (te-x-te)

tscode

4tsoder (the https://www.4coder.net/ evil twin)

Maybe “txtea” pronounced texty.  Because of text and tea. Very paug in my opinion.

Thanks everyone for suggesting the name! I decided to call it ded for Dramatic EDitor as discussed on the stream.


Move license option CC-PDDC to lower on the list

This license has some very specific use cases, like for government documents, and I'm afraid if we have it at the top of the list that will get chosen inappropriately on a regular basis. Those who know what it is and need it will find it still if it is farther down the list.
I'd like to see it moved to below the ODC set of licenses. Please see the reordered list in the Design Doc: https://docs.google.com/document/d/1fcr2DYo7OrX-qTdeUOTWKSS1rlq_47sehESmbvgUsrk/edit#

@jcoyne I'm not seeing this change. Could you check on this? And you just redeployed, so it should be there. Thanks.

@amyehodge @jcoyne I wonder if the PR that closed this issue did not have the desired effect, and if we need changes to one or both of these hashes: https://github.com/sul-dlss/happy-heron/blob/8e32cdbf3b06ecf703d1b7db395045b6b50e80be/app/models/license.rb#L55-L96

@mjgiarlo @jcoyne Does this need a new ticket made for it?

@amyehodge Yeah, I think so. Thanks!


add missing work in docs/oauth2.md

I guess the missing word is "use".
Signed-off-by: Bruno Bigras<EMAIL_ADDRESS>

thanks!


Read environment var for max body size

Im not sure what the default max body size is, but it seems to be around 250kb, which was to small for some of the geometries im using, so I made it configureable, with a default of 500kb

Wow, that's a pretty massive GeoJSON! But yeah, this makes sense. :+1:


(Accessibility) With "High Contrast - White" theme, some error boxes are difficult for colorblind users to see

Preflight Checklist

[X] I have installed the latest version of Storage Explorer.
[X] I have checked existing resources, including the troubleshooting guide and the release notes.
[X] I have searched for similar issues.

Storage Explorer Version
1.23.0
Regression From
No response
Architecture
x64
Storage Explorer Build Number
20220223.14
Platform
Windows
OS Version
Windows 11
Bug Description
With the "High Contrast - White" theme, certain error box highlights are hard to see (screenshot below will explain better)
Steps to Reproduce

Turn on "High Contrast - White" theme
Edit blob properties
Add three Metadata tags
Set one of the tags to be a duplicate name of the other

Actual Experience

For colorblind users, it can be difficult to distinguish the thin red outline of the top two boxes from the black outline of the lower box. I spoke to a colorblind user with deuteranomaly, who said that it would be easier to distinguish if the red outline was thicker.
Expected Experience
No response
Additional Context
No response

Speak to some accessibility experts to see if there's a standard way to handle this.


Let Choice take a dict, and if so, return the value associated with the chosen key.

It would be nice if I could do something like:
crypto = Choice({ 'md5': hashlib.md5, 'sha256': hashlib.sha256 })

and then
@click.option("--hashalg", type=crypto, default='md5')
....
    hash = hashalg(content)

...otherwise I have to set up the mappings manually, and make sure they're a list:
crypto_map = { 'md5': hashlib.md5, 'sha256': hashlib.sha256}
crypto = Choice(list(crypto_map.keys()))

@click.option("--hashalg", type=crypto, default='md5')
....
    hash = crypto_map[hashalg](content)

..which is a bit of extra complexity that it seems would be commonly needed.

It's a good idea, but I'd like to avoid adding more complexity to this. This is something that can be done with a custom type without any changes to Click.
class MappedChoice(click.Choice):
    def convert(self, value, param, ctx):
        value = super().convert(value, param, ctx)
        return self.choices[value]

@click.command()
@click.argument("value", type=MappedChoice({"a": 1, "b": 2}))
def show(value):
    click.echo(value)

Note that like the example above, you don't need to call list(keys) in your example either, passing a dict should work fine.
Leaving it up to the user to implement this also means they can do other things like attribute access or function calls. Your example could be implemented in a reusable type:
class HashContent(click.Choice):
    def convert(self, value, param, ctx):
        value = super().convert(value, param, ctx)
        f = getattr(hashlib, value)
        return f(ctx.params["content"].encode()).hexdigest()

@click.command()
@click.argument("content")
@click.option("hashed", "--hash", type=HashContent(("md5", "sha1")), default="sha1")
def show(content, hashed):
    click.echo(hashed)


Add att.rotating

This moves rotation from rend into a new class att.rotating to be used in other elements, starting with hairpin.

If you close an open PR could you please leave a note as to why?

Solved with #1041

Solved with #1021

Thank you!


Add sous_vide component and Anova platform

Description:
Add a basic component for smart sous-vide cookers along with Google Assistant and Alexa support.
First platform is for the Anova Precision Cooker using BTLE.
Related issue (if applicable):
No issues, some people have created workarounds in the community like here:  https://community.home-assistant.io/t/anova-sous-vide-control-over-mqtt/48146
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#TODO
Example entry for configuration.yaml (if applicable):

alexa:
  smart_home:
    filter:
      include_domains:
        - sous_vide

google_assistant:
  exposed_domains:
    - sous_vide

sous_vide:
 - platform: anova
   name: Big Blue
   mac: 11:22:33:44:55:66

Checklist:

[x] The code change is tested and works locally.
[x] Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated in home-assistant.github.io

If the code communicates with devices, web services, or third-party tools:

[x] New dependencies have been added to the REQUIREMENTS variable (example).
[x] New dependencies are only imported inside functions that use them (example).
[x] New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
[x] New files were added to .coveragerc.

If the code does not interact with devices:

[ ] Tests have been added to verify that the new code works.

@arbreng You might want to take a look at the actual files that are affected by your commits/this PR. Seems like a lot more (none related) files are touched.

@arbreng If those where your intentions, then please leave it so. A developer will review this (I'm not an HA developer, I was just noticing this while scanning for missing docs).

As @frenck mentioned above, you should not put refactoring and new component in one PR.
But more important, you need rethink your design. sous_vide is a brand, or think about it a collection of devices, likes nest or hue, it provides a communication infrastructure to all of its devices, such as Anova Precision Cooker.
Then, what is Anova Precision Cooker? a sensor you can get temperature, a switch you can turn on/off, or multiple type of entity mapped in HA.
In home-assistant, it is normal one devices may have multiple entity, each represent one of its feature. We also have very strict limit to add new type of entity, for example, if you really feel that you need a cooker to better present that subclass of kitchen appliance, you have to first make a proposal in https://github.com/home-assistant/architecture.

@awarecan I'll split the climate refactoring into a different PR.
As to your second paragraphs, I'm not sure what you mean.  My intention was to provide a cooker type of entity, definitely.  Sous-Vide is the type of device.  Anova is the brand; there are others including Joule that would have their own platforms.  This is very similar to how the vacuum component works.

Then the right structure of your code should like
components
  +---sous_vide
        +---__init__.py
  +--- cooker (a new type of entity, and you need to make an architecture PR first)
        +---__init__.py
        +---anova.py
        +---demo.py

In case your proposal got approved, you need split it to two PR, first includes only cooker/init and cooker/demo, the second includes sous_vide and anova.

Refactoring CL removed, now its stripped down to the basics

@frenck I added docs now

Please break off the Alexa and Google assistant code into another PR and the Anova platform into a third PR.
This PR should only add the sous vide base component, the demo platform and tests for that.

I'm going to close this PR, @MartinHjelmare is right and there has not been any follow up since end of July.


Cannot find npm 4.0.5 on Windows

Please, see the description here, as I'm not sure if it's spawn-wrap or npm fault
https://github.com/npm/npm/issues/15231

Confirmed that this issue appeared in 1.2.4

We ran in to this same thing today as well.
nyc uses spawn-wrap and after adding david to our project nyc began reporting issues finding npm-cli.js.
Turns out david installs its own version of npm which spawn-wrap then tries to use.

Can anyone suggest a workaround for this.  I have the same issue and can't run nyc on my windows box.


Support OAuth2 Token Introspection.

This PR solves issue #281.
Note: This PR needs personium/personium-lib-common#42.

In the discussion yesterday, we concluded not to necessitate the Bearer Token in the Authorization header. but we may need to think further since the RFC7662 says;

To prevent token scanning attacks, the endpoint MUST also require
some form of authorization to access this endpoint, such as client
authentication as described in OAuth 2.0 [RFC6749] or a separate
OAuth 2.0 access token such as the bearer token described in OAuth
2.0 Bearer Token Usage [RFC6750].

https://tools.ietf.org/html/rfc7662#section-2.1


Explicit backend use in case of LOCAL run

When we run MODIN in local whitout providing any dask or .. cluster does it run with the multiprocessing  package of the lib python?  This could be explicited in the documentation and README.md
At first I was looking how and why would modin run  a "fake" dask cluster in local.
What do you think about it ? Thank you

Hi @raphaelauv, we do not currently have support for a Python multiprocessing engine. Did you see that in the documentation? Is that something you want?
Modin doesn't use a "fake" dask cluster, it creates a Dask Client which uses a worker per CPU core. Does that make sense?
Please let me know if I didn't answer your question!

Thank for your answer
I made this assumption from the diagram on this page https://modin.readthedocs.io/en/latest/developer/architecture.html , I throught by PYTHON package this mean using the  multiprocessing package.
So it create a local dask cluster.
Should the documentation talk about a fake simulated dask cluster in case of local run ?

I see, the Python backend is a pure python engine with no parallelism. We use it for mostly debugging, and it is not very fast at larger datasets.
The video you link has added some future work plans, but not labeled them. MPI and Python multiprocessing are plans for future work.

Should the documentation talk about a ~fake~ simulated dask cluster in case of local run ?

Yes! Our documentation needs updating, and we have had many outside contributors add improvements to the documentation during our recent Pydata Global sprint. Would you like to contribute this to the documentation?


[Feature request] Per-page CSP configuration

The clickjacking protection supports applying a different configuration for different paths. It would be great if CSP could do it as well.
See https://github.blog/2016-04-12-githubs-csp-journey/#connect-src which describes a use case that Github has for this (which is also what gave me the idea to request it here. My own CSP journey is not yet at the point where I would need it, but it might come).

We have another example: Sonata Admin uses inline JS. Enabling this for the whole site would be really irresponsible.

Another example would be allowing data: in img-src and unsafe-inline in style-src for googlemaps api.
I dont need the api on every page


v0.30.0

Description

https://github.com/axe-api/axe-api/issues/152
https://github.com/axe-api/axe-api/issues/151
https://github.com/axe-api/axe-api/issues/125
https://github.com/axe-api/axe-api/issues/146
https://github.com/axe-api/axe-api/issues/137
https://github.com/axe-api/axe-api/issues/38
https://github.com/axe-api/axe-api/issues/140

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[ ] Changelog
[ ] Version
[x] My changes requires documentation change.
[x] The changes have been documented in the axe-api/docs repository. (https://github.com/axe-api/docs/pull/51)
[x] I added integration tests properly.
[x] The changes require axe-api-template changes. (https://github.com/axe-api/axe-api-template/pull/8)

Bugs

[ ] per_page doesn't work when we set fields query value


Flicker in spout receiver

I am using Resolume 6 to send video onto geometry using spout receiver and it is strobing inside unity.  I thought was an issue with HDRP but also getting in standard.  Any ideas how to fix this?
Also it used to work, I am currently using unity 2018.3.of2
Thanks so much (:

Please check if it reproduces with a simple project, like the sample scene in this repository.

I've tested it in a basic startup 3d project with no additions besides spout.  I have installed a few different version of unity and the issue persists, however I can't find sample scene in the project

I tried installing resolume and unity on a new computer and the issue is still there.  I tried disabling v-sync and a few other graphics and changing the frame rate etc

I had (probably) the same problem and I think I got it.
To reproduce all you need is a receiver with targetRenderer but WITHOUT targetTexture.
I tested on Unity 2018.2 and 2019.1, it happened only on 2019.1.
A warning is logged a lot saying Releasing render texture that is set to be RenderTexture.active!.
I found 2 workarounds:
Either change this line (looks familiar? ;) to
Util.Destroy(_receivedTexture); _receivedTexture = null;
Or delete lines 16-18 in Utility.cs so that Utils.Destroy() always executes DestroyImmediate
Both solutions work but I opted for the first since it has less side-effects, I don't know what's different in 2019 that makes this not work, but I think it has something to do with when Destroy actually destroys objects.

I also just tried a third solution which is to modify Utils.Destroy() like this:
internal static void Destroy<T>(ref T obj)
    where T : Object
{
    if (obj == null) return;

    if (Application.isPlaying)
        Object.Destroy(obj);
    else
        Object.DestroyImmediate(obj);

    obj = null;
}

and then adding the keyword ref to every call.

Hi,
similiar behaviour in
Unity_2019_1_14f1
and
Unity_2019_2_1f1
with
Klak_Spout  v0.2.4
on a simple sender and receiver scene.
The Flicker from high frequence only happens in PlayMode.

Thanks for the fixes.
Is there a recommendation for one of the 3 methods
and could one ofthem be integrated in an new release?

Thank you very much for suggesting the fix. I applied it in 7eb9fd5


Tests:  Remove redundant container disk tests

What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

[ ] Design: A design document was considered and is present (link) or not required
[ ] PR: The PR description is expressive enough and will help future contributors
[ ] Code: Write code that humans can understand and Keep it simple
[ ] Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
[ ] Upgrade: Impact of this change on upgrade flows was considered and addressed if required
[ ] Testing: New code requires new unit tests. New features and bug fixes require at least on e2e test
[ ] Documentation: A user-guide update was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change.
[ ] Community: Announcement to kubevirt-dev was considered

Release note:

NONE

/test pull-kubevirt-e2e-k8s-1.28-sig-compute
/test pull-kubevirt-e2e-k8s-1.27-sig-compute
/test pull-kubevirt-e2e-k8s-1.26-sig-compute

Hello, does kubevirt's e2e support testing for a particular method now? If yes, what should I do.  I didn't find a way @xpivarc

Hello, does kubevirt's e2e support testing for a particular method now? If yes, what should I do. I didn't find a way @xpivarc

Hi, I am not quite sure what you mean by "support testing for a particular method now?". Can you elaborate?

Hello, does kubevirt's e2e support testing for a particular method now? If yes, what should I do. I didn't find a way @xpivarc

Hi, I am not quite sure what you mean by "support testing for a particular method now?". Can you elaborate?

Hi,  my mean test a method or test a file， not all ut

Hello, does kubevirt's e2e support testing for a particular method now? If yes, what should I do. I didn't find a way @xpivarc

Hi, I am not quite sure what you mean by "support testing for a particular method now?". Can you elaborate?

Hi, my mean test a method or test a file， not all ut

@xpivarc

Hello, does kubevirt's e2e support testing for a particular method now? If yes, what should I do. I didn't find a way @xpivarc

Hi, I am not quite sure what you mean by "support testing for a particular method now?". Can you elaborate?

Hi, my mean test a method or test a file， not all ut

We have a unit tests for testing just a method/function.

Hello, does kubevirt's e2e support testing for a particular method now? If yes, what should I do. I didn't find a way @xpivarc

Hi, I am not quite sure what you mean by "support testing for a particular method now?". Can you elaborate?

Hi, my mean test a method or test a file， not all ut

We have a unit tests for testing just a method/function.

Ok, thanks, I already found it

/reopen
/remove-lifecycle rotten

@jean-edouard PTAL

@fossedihelm Would you have time to have a look?

/lgtm
Thank you!


pro::proxy obj may reconstruct class when it's a function return value unless using make_proxy.

For example:
pro::proxy<Drawable> CreateRectangleAsDrawable(int width, int height) {
  Rectangle<int> rect;
  rect.SetWidth(width);
  rect.SetHeight(height);
  pro::proxy<Drawable> p = ▭
  return std::move(p);
}

Unless use
return pro::make_proxy<Drawable>(rect)

Isn't that a little unfriendly?

Your example is incorrect. proxy holds any pointer you create with, i.e., if you create a proxy with a raw pointer, it just behaves like a raw pointer and does not take ownership of the object. In your example, p holds a raw pointer to a temporary, and becomes dangling after the function returns.
make_proxy behaves like std::unique_ptr but more powerful (can be copied / avoid heap allocation). It takes ownership of the object. If you want to avoid copy when calling make_proxy, it is encouraged to use in-place construction instead, e.g.,make_proxy<Drawable, Rectangle>(width, height) (given that Rectangle has an applicable constructor).

Thanks for your reply

@mingxwa  How can I forward the constructing method implementation to another container if I want a deferring class. creation?

How can I forward the constructing method implementation to another container if I want a deferring class creation?

This looks like a design question. I guess you might want something like a "factory":
PRO_DEF_MEM_DISPATCH(MemCreate, Create);

template <class F, class... Args>
struct Factory : pro::facade_builder
    ::add_convention<MemCreate, pro::proxy<F>(Args...)>
    ::build {};

how to access SetWidth(width) through proxy after make_proxy<Drawable, Rectangle>(width, height) created? Only add_convention?

It depends on when the SetWidth is called. If it is called before type erasure, the facade does not need the knowledge. With the Factory defined above, implementations can do anything in a Create function, not limited to SetWidth. For example:
struct Printable : pro::facade_builder
    ::add_convention<pro::operator_dispatch<"<<", true>, std::ostream&(std::ostream& out) const>
    ::build {};

class MyIntFactory {
 public:
  explicit MyIntFactory(int val) : val_(val) {}
  pro::proxy<Printable> Create() { return pro::make_proxy<Printable>(val_++); }

 private:
  int val_;
};

int main() {
  pro::proxy<Factory<Printable>> factory = pro::make_proxy<Factory<Printable>, MyIntFactory>(3);
  pro::proxy<Printable> p1 = factory->Create();
  pro::proxy<Printable> p2 = factory->Create();
  std::cout << *p1 << "\n";  // Prints: "3"
  std::cout << *p2 << "\n";  // Prints: "4"
}


DocsArchive-1.0.21078.2Auto archive content

Auto archive content from https://github.com/opstestprod2/E2E_DocsArchive_Prod.git

Docs Build status updates of commit c9e42a5:
:warning: Validation status: warnings

File
Status
Preview URL
Details

e2e_archiveDocs_Prod_20210503220103/fallback.md
:warning:Warning
View
Details

.openpublishing.publish.config.json
:white_check_mark:Succeeded

.openpublishing.redirection.json
:white_check_mark:Succeeded

e2e_archiveDocs_Prod_20210503220103/TOC.yml
:white_check_mark:Succeeded
View

e2e_archiveDocs_Prod_20210503220103/breadcrumb/e2e_archiveDocs_Prod_20210503220103/toc.yml
:white_check_mark:Succeeded

e2e_archiveDocs_Prod_20210503220103/docfx.json
:white_check_mark:Succeeded

e2e_archiveDocs_Prod_20210503220103/fallback.md

Line 2, Column 1: [Warning-ms-author-missing] Missing required attribute: 'ms.author'. Add the current author's Microsoft alias.
Line 2, Column 1: [Warning-ms-prod-or-service-missing] One of the following attributes is required: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Crash application when reading specific gif

I don't know if other gifs do that too, but when I read this it crashes

Hi @DIMBD-AKE,
I didn't reproduce the crash, but I can see that the image takes a very long time before it starts rendering, and uses huge amounts of RAM (4GB!!!).
It's a known problem that WpfAnimatedGif uses a lot of memory. This is because it prepares all frames in memory (uncompressed) before rendering anything. This image has 675 frames with a resolution of 1280x720, so... you can see where this is going. WpfAnimatedGif works fine for small GIFs with not too many frames, but it's definitely not suitable for large GIFs.
I suggest you try my other animated GIF library, which decodes frames on the fly: XamlAnimatedGif. It should work much better with this GIF.
(BTW, given the size and the number of frames, maybe you should consider converting the GIF to a video and play it with MediaElement)


[FR] Why not suport .heif and .hevc ?

I have a lot of images in heif format, but that format does not appear in your plugin . Is it a deficiency from your add-on or Obsidian itself?

Those formats are not listed as supported by obsidian at this time and I don't have any files of that type to test with.


Simplify gitignores by including whole dir and add caches

Proposed change

Simplify gitignores by including whole dir and add caches
Additional information

Checklist

[x] The changes are tested and work correctly
[x] pre-commit checks pass / the code has been formatted using Black
[ ] Tests have been added to verify that the new code works

Thx


Unable to use the marching cubes algorithm.

I made a simple program to try out the marching cubes algorithm.
    ImgOpener imgOpener = new ImgOpener();
    Img<UnsignedByteType> img = (Img<UnsignedByteType>) imgOpener.openImgs(
            new File(args[0]).getAbsolutePath() ).get(0);
    Cursor<UnsignedByteType> curse = Views.flatIterable(img).cursor();
    Mesh mesh = MarchingCubesRealType.calculate(img, 3);

On the call to 'calculate I get a no such method exception.

Exception in thread "main" java.lang.NoSuchMethodError: 'net.imglib2.RandomAccessibleInterval net.imglib2.view.Views.flatIterable(net.imglib2.RandomAccessibleInterval)'
at net.imglib2.mesh.alg.MarchingCubesRealType.mask(MarchingCubesRealType.java:77)
at net.imglib2.mesh.alg.MarchingCubesRealType.compute(MarchingCubesRealType.java:135)
at net.imglib2.mesh.alg.MarchingCubesRealType.calculate(MarchingCubesRealType.java:123)
at deformablemesh.experimental.Imglib2Mesh.main(Imglib2Mesh.java:23)

On line 77 it is getting a cursor object. I included that in my code. It works in my main method, but it doesn't work in the MarchingCubes algorithm.

I was playing around with a minimal pom to reproduce the issue.
I changed this:
          <dependency>
		<groupId>net.imglib2</groupId>
		<artifactId>imglib2-mesh</artifactId>
		<version>1.1.0</version>
	</dependency>

To:
            <dependency>
		<groupId>net.imglib2</groupId>
		<artifactId>imglib2-mesh</artifactId>
	</dependency>

That caused version 1.0.0 to be downloaded. It seems like some sort of version conflict with the parent pom scijava 38.0.1


Completely broken

Sorry for the terrible title but I couldn't think of a better one :(
I had developed a site and it was working really well but something happened and it now no longer works.  In order to identify the issue I have started again with absolute minimum
`from fastapi import FastAPI
import uvicorn
app = FastAPI()
@app.get("/")
async def read_root():
return {"Hello": "World"}
if name == "main":
uvicorn.run(app, host="<IP_ADDRESS>", port=8000)`
Python 3.8.4 -- Is this the problem? Something I did asked me to go from .3 to .4 ???
uvicorn --version
Running uvicorn 0.11.5 with CPython 3.8.3 on Windows
It does not work or return anything, the arrow just spins.
In my more complex site, it not only does not work it folds up into a 'none existent' default endpoint.
Try this site:
https://rdshwys.azurewebsites.net/docs# to demonstrate the issue

@niko1a I understand your confusion, thus the title!
But there is an update!  I changed the python version, way back to 3.6.9 (it was one I have available) and it worked fine.
From this I think it is due to Python 3.8.4

Ok I have solved my issue.
I just uninstalled pytest and it works again.  Pytest was the thing that asked for the upgrade from 3.8.3 to 3.8.4

It shouldn't have broken it but Pytest was the problem.
I even downgraded back to 3.8.3 and still didn't work.

Duplicate of #1770.

Thanks for the help here @phy25 ! :clap: :bow:
Thanks for reporting back and closing the issue :+1:


Support to put styles in head of doc and write to js files in bundle (like styled-jsx)

One of the awesome features that styled-jsx gave us is the ability to create a js bundle for each page with css embedded and next-sass only allows for a global css file for the whole site rather than per page js.
Is there any way to import sass files and still write to one js file per page and put styles in the head of the document?

Any way to bundle css into pages would be amazing. Really a big feature thats missing here.

@afzal273 @aequasi  did you found a workaround?

Hi, thanks for creating an issue. We currently recommend using https://nextjs.org/docs/basic-features/built-in-css-support as the plugins have been deprecated in favor of the built-in support.


Updated the powershell command

People copy the commands literally, so updated the PS commands to reflect vEthernet (VmNat) from ethernet

#sign-off

#sign-off

sign-off

HELP @mattbriggs has this merged?

@BarbaraSelden yes. Thanks

mattbriggs merged commit 467655d into MicrosoftDocs:live 2 hours ago


ET Powerfactor

Great addition of the power factor fields:
et.py:

...
Integer("meter_power_factor1", 20, "Meter Power Factor L1"),
Integer("meter_power_factor2", 22, "Meter Power Factor L2"),
Integer("meter_power_factor3", 24, "Meter Power Factor L3"),
...

But the values should range from -1 to 1. I think a division by 100 would be correct (not a integer value).

Introduced new Decimal sensor type and switched power factors to.
Will get into next release (0.8.6)


gigasecond: fix use of deprecated package

Apparently System.Locale get deprecated on haskell 7.10 and moved to the package old-locale-<IP_ADDRESS>.
And this change will use reuse the function provided by Data.Time.Format
Ref: https://github.com/exercism/xhaskell/issues/85#issuecomment-191382840

Thanks for catching this!


Create a master branch for AWS Distro Development

Background
Current development process being followed for AWS-Kubeflow-distro-1.3.1 was to take a release branch from the manifest repository as the base (a.k.a upstream) and make AWS distribution specific changes on the same branch. This approach presented the fastest way to get development going considering the timeline, kfctl tool getting deprecated and vendors requiring to setup their own repository to host distribution specific manifests.
Problem
However, the above approach presents several issues:

Working on a new release:

Every release requires a developer to create a copy of upstream KF release branch and copying/cherry-picking changes from the awslabs previous release branch (e.g. v1.3-branch) to new branch (e.g. v1.4-branch) which is cumbersome and error prone (e.g. #75)
These release branches on upstream are not frozen because they are used for any patch releases. Let’s take an example for v1.4.0 and v1.4.1. Every patch release will require us to either:

Create a new branch(e.g. v1.4.1-branch) from the tag/v1.4.1 from upstream and repeat the process in 1.a.
Cherry pick commits related to patch release from upstream and create a PR to awslabs repo
Rebase the awslabs/v1.4-branch from upstream/v1.4-branch and force push which is unacceptable

Maintenance issues unrelated to the code owned by the team

Security vulnerabilities for test dependencies coming from upstream
Modifying the root pkg READMEs on each release branch (e.g. see README changes)

AWS release version is coupled with Kubeflow version

With this approach, we need to maintain 2 release versions one from Kubeflow and another from aws because we may have to do patch releases or feature enhancements e.g. aws-manifests-1.x-Kubeflow-1.3.1

Other issues:

PR build and test infra(when we have one) will need to be constantly be updated to point to different branches instead of one master branch. Similarly Github issue templates need to be ported
Default branch on the repository will keep changing
Might loose the history related to the PRs between releases if changes are copied instead of cherry-picking

Suggested Approach
Majority of the overlays do not change unless there are major changes in the upstream component. Create a base with AWS overlays that does not change between versions and work only on the delta per release.
Development - Build and Test
Create a master branch to host only AWS specific overlays, tests and docs. e.g.
ubuntu@ip-172-31-0-119:~/kubeflow-manifests$ tree -L 3
.
├── README.md
├── awsconfig
│   ├── apps
│   │   ├── jupyter
│   │   ├── katib
│   │   └── pipelines
│   ├── common
│   │   ├── alb-controller
│   │   ├── istio-envoy-filter
│   │   └── istio-ingress
│   └── infra_configs
├── docs
│   ├── cognito
│   ├── rds
│   ├── s3
│   └── storage
├── tests
│   ├── canary
│   ├── e2e
│   └── unit

(Customer experience) This will introduce one additional step for users after cloning the awslabs repo.
export KUBEFLOW_RELEASE_VERSION=v1.4.1
git clone --branch ${KUBEFLOW_RELEASE_VERSION} https://github.com/kubeflow/manifests.git upstream

Once user has cloned a tagged branch from upstream manifests(kubeflow/manifests repo), they will continue with setting up aws resources or running kustomize build and apply just like today.
For this, we need to isolate the aws specific changes in form of overlays to a separate directory.

I have already completed a POC for jupyter, cognito, rds and s3 in the v1.4-branch as a POC. There should be no changes for EFS and FSx since the changes are self contained. The only piece left is secrets-manager integration which is also doable

Releases
New releases (major and patch from upstream): Cut a release once a Kubeflow release has been validated with updated README.
Patch for an old release(depends on support policy) where latest overlays are incompatible: Use the existing release tag branch to do a patch release or backport features for older releases.

Follow up: Will this base become outdated between several releases?

The intent of this development strategy is not to support multiple versions using the latest build. Making changes to a previous release will take the same amount of time i.e. go to release branch and make the changes.

How does this solve the problems stated earlier?
We take out the problems related to PR build/test, copying changes over from old release branches and modifying parent READMEs etc by creating this base package with only AWS manifests instead of using a Kubeflow released branch as base. The contributors only needs to work on the delta per release. Problems related to security vulnerabilities because of unrelated packages are handled by only cloning the upstream during build time.
Patch releases just become a small PR with changing a version in a config file and re-running the tests using the PR build infra.
The problem for release version is not completely solved since a it also depends on the upstream but we are able to cut a new release for this package independently which talks about the compatible version of Kubeflow (TBD - see below)
Next steps/TODOs

How to document/convery the supported upstream version to users?
What is the release versioning for this package?
Use the main branch to get started with this

Please comment your thoughts/feedback

Hello @surajkota , this approach is very reasonable.
On our side, we came up to a solution that is pretty similar to isolate the files we needed to change for pre-install (files that are applied during the install) and post-install (yaml that must be applied after kubeflow is installed). This way when a new release comes, we can easily diff our pre and post-install files with the new version and overwrite the new version files with ours if everything is fine (this can be done in minutes).

Therefore I think your proposal makes total sense.
We are on board with your proposal as is and we're eager to install kubeflow 1.4.x when this proposal will be in place.

Branch is setup, documentation required for release versioning


No encode, decode in createLocation

Removes the automatic encoding of pathnames, leaving that up to the browser.
Moves the decoding to createLocation because 1) that is now used by the getDOMLocation calls to create a location and 2) we should ensure that if a user pushes a location whose pathname is encoded, we decode it for consistency.

Updated to just throw in createLocation when a pathname cannot be decoded. I believe that this makes the most sense to do, although it can be easily changed if you think otherwise @mjackson.
Internally, createPath is always passed a location object that was created by createLocation, so just having createLocation throw should be good enough. Having said that, createPath is exported by history, so maybe it should throw on its own?

The obvious issue with history throwing when it encounters a malformed URI is that developers will need to try...catch their code if they want to recover from bad percent-encoding. This would make it difficult to display an error page that looks like it is in their website.
try {
  ReactDOM.render((
    <BrowserRouter>
      <App />
    </BrowserRouter
  ), holder)
} catch (e) {
  ReactDOM.render((
    <MalformedURIMessage />
  ), holder)
}

I still think that history should throw and we can point to the RFC 3986 path parser rules to justify that, but there will still probably be people who want to use malformed URIs for some reason. I don't necessarily like the idea of automatically using the encoded pathname if the decode fails, but I think that it might be useful in the future to add an explicit "no decode" mode.

I still think that history should throw and we can point to the RFC 3986 path parser rules to justify that, but there will still probably be people who want to use malformed URIs for some reason

@pshrmn I think this is the right approach; an app using an invalid/malformed path can always be fixed to encode correctly. Thank you for fixing this.

Just bumping this since it has been a while. Whether or not this is the best approach, something definitely should be done here since the current implementation (made by myself :frowning_face:) breaks things.

@pshrmn I would love to see this added. 👍

This looks good to me. Thanks, @pshrmn!

Seems like this should probably be a patch release since we're just fixing a bug we introduced in 4.6.1. Would you agree?

I agree. More of a bug fix than "added functionality", so I don't think that it would warrant a minor bump.

As a minor addendum, the next release would also include #459, but that is also pretty much just a bug fix, so I don't think that it warrants a minor bump.

One more thing I just remembered is that #485 needs to be addressed before the next release.

OK, just got that one in for you.
@mjackson Did you want to push out a 4.6.2 release or add me to npm so I can take care of that for you? (you probably should add Ryan, BTW 😄)

Thanks, @timdorr. I'll go ahead and cut the release :)


Create azure-webapps-node.yml

Summary by Sourcery
CI:

Add a GitHub Actions workflow to build and deploy the application on push to the "master" branch or on manual dispatch.

Create azure-webapps-node.yml #4


Replaces @SuperBuilder with constructor @Builder

fixes https://github.com/semi-technologies/weaviate-java-client/issues/144

other approach was selected to fix the issue (https://github.com/semi-technologies/weaviate-java-client/pull/148)


Fix passing of args intended for node/iojs.

The recent commit 1430c2b5102e9d355119a643e9b2be2e76e91d1f inadvertently broke the ability pass arguments to node/iojs before running mocha -- note that arguments intended for the executable are prepended to args; the previous commit assumes that args[0] will be the executable, but that is only correct if no args intended for the executable have been unshifted onto args.
So, if you try, for instance:
mocha --harmony ...
... you'll get an ENOENT error as spawn tries to execute a file named --harmony.
See #1548 for the origin of this issue.

@travisjeffery This seems to work :)
iojs
$ node --version
v1.4.3

$ cat example.js
it('test', function(done) {
  setTimeout(() => done(), 0);
});

// Before PR
$ ./bin/mocha --harmony_arrow_functions example.js
events.js:141
      throw er; // Unhandled 'error' event
            ^
Error: spawn --harmony_arrow_functions ENOENT
    at exports._errnoException (util.js:734:11)
    at Process.ChildProcess._handle.onexit (child_process.js:1022:32)
    at child_process.js:1114:20
    at process._tickCallback (node.js:350:11)
    at Function.Module.runMain (module.js:487:11)
    at startup (node.js:112:16)
    at node.js:863:3

// After PR
$ ./bin/mocha --harmony_arrow_functions example.js

  ․

  1 passing (8ms)

node
$ node --version
v0.12.0
danielstjules:~/git/mocha (master =)
$ cat example.js
it('test', function(done) {
  var fn = function*() {};
  done();
});

// Before PR
$ ./bin/mocha --harmony-generators example.js
events.js:85
      throw er; // Unhandled 'error' event
            ^
Error: spawn --harmony-generators ENOENT
    at exports._errnoException (util.js:746:11)
    at Process.ChildProcess._handle.onexit (child_process.js:1046:32)
    at child_process.js:1137:20
    at process._tickCallback (node.js:355:11)
    at Function.Module.runMain (module.js:503:11)
    at startup (node.js:129:16)
    at node.js:814:3
// After PR
$ ./bin/mocha --harmony-generators example.js

  ․

  1 passing (5ms)

+1
1430c2b break all tests with --harmony flags enable...

ping @travisjeffery

+1 from me :)

This is also related to https://github.com/mochajs/mocha/issues/1583

@tawdle Any chance you could add a regression test for this? If not, I can fork this PR and add one.

+1 from me, rolling back.

@travisjeffery Think we could merge this in and do a quick patch release? I'll see if I can write an acceptance/regression test for this afterward.

Awesome, thanks. Published 2.2.1 with this


"Please install shell program" with both Expect and pexpect

My issue is similar to #56, for whatever reason I can't get the plugin to connect with my git repos. I've verified that my git/ssh servers are able to accept incoming connections, and even though I've installed both expect as well as pexpect (globally as well as for the www-data user with virtualenv), I keep running into the "please install shell program" error. Is there a way that I can get some additional logging info to see what it's doing? Thanks again for the plugin!

OS: Ubuntu 16.04
Expect version: 5.45-7
pexpect version: 4.3.0
git version: 2.7.4-0ubuntu1.3
OpenSSH version: 7.2p2-4ubuntu2.2

Actually, I just figured this out, it turns out that my php.ini was too restrictive. I had the shell_exec function in disable_functions in my php.ini for security, I will do some testing to see what other security-sensitive functions it depends on. Then I can enable these one by one in a .user.ini file just for this application.


Request for the addition of the DirectStorage headers (dstorage.h/dstorageerr.h).

It'd be great if the DirectStorage API headers were included in this repository and under the same license. Today they seem to only be available via nuget and the headers themselves aren't listed in distributable_files.txt so using them from git submodule dependencies (vs needing to use nuget) is tricky.
Specifically native/include/dstorage.h and native/include/dstorageerr.h from
https://nuget.info/packages/Microsoft.Direct3D.DirectStorage/1.2.2

Hi!  The header files included in that package are licensed under the MIT license, as described by LICENSE-CODE.txt and the text at the beginning of those files.  This was explicitly set up this way to allow you to check the headers into source control.
The distributable_files.txt refers to the executable, binary code, that are covered by LICENSE.txt.

Oh, neat! I hadn't noticed LICENSE-CODE.txt as covering those. Would still be cool to have them here so there's a one-stop submodule for users but this at least makes it easier to have our own submodule containing them.

This issue should be taken to https://github.com/microsoft/DirectStorage rather than this repo which is focused on Direct3D 12 and related technologies.

@walbourn in that case, does it make sense to (re)close this issue as "not planned", instead of "completed" to signify this?


[WIP] Gem with config

Things done:

[ ] Tested using sandboxing (nix-build --option build-use-chroot true or nix.useChroot on NixOS)
Built on platform(s)

[ ] NixOS
[ ] OS X
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

The goal of this PR was to move the application of the gemConfig inside of buildRubyGem so we can also benefit from those patches if buildRubyGem is used directly.
The implementation is not entirely satisfying and I'm looking for feedback if it's possible to make it any shorter.
The last commit is a different project and is WIP but I used it to test my changes.

I don't know if this work is still in progress, but I don't feel bad closing old PRs of people with commit access

(even if commit access was given after the PR in question, yes)


WIP: Fix deletion issue and add userdata secret creation for bmh

Get annotations from BaremetalMachine instead of Machine for deletion
Copy userdata from Machine into a secret referenced in
baremetalMachine and BaremetalHost

/retest

/lgtm


Sign helm chart artifact in ghcr.io

Problem Statement

The container images of the project are signed, the helm chart isn’t signed.

Related Issue
Fixes #3755
Proposed Changes

The helm chart artifact stored in the OCI registry is signed using Cosign
Signed artifact is verified after signing to ensure that the artifact is signed
Build attestations are added for the same artifact which can be found at https://github.com/<repo-owner>/external-secrets/attestations

Testing workflow
The workflow was tested by running it in the forked repository.

Sample workflow run
Sample attestation

Checklist

[x] I have read the contribution guidelines
[x] All commits are signed with git commit --signoff
[x] My changes have reasonable test coverage
[x] All tests pass with make test
[x] I ensured my PR is ready for review with make reviewable

It's a bummer that we can't really test this. :D

@moolen I need a second pair of eyes please 👀


Rewrite cond-expand implementation

Support (else ...).

Raise an error if no clause matches, important for detecting
unsupported environments. A blank (else) can be used to omit this.

Forbid non-symbol, non-pair objects like #t and #f in requirements.
The old implementation allowed #t and #f as a convenience to the
implementer, but the spirit of SRFI 0 is to have symbols only.

Stop evaluating requirements inside (and ...) and (or ...) as soon
as the requirement can no longer match. This is important so we can
do (cond-expand ((and r7rs (library (srfi 123))) 'yes) (else 'no))
without crashing in Scheme implementations that don't support
the (library ...) requirements from R7RS.

Add the (features) procedure from R7RS to match other Schemes.

Incorporated as a patch, so closing the PR.


syncset: support templates in patches

HIVE-1748 / #2192 added the ability to flip a switch in a [Selector]SyncSet that causes hive to process golang text/templates in leaf values of objects in the [S]SS's resources section.
This does a similar thing for JSON patch strings in the patches section. For example:
apiVersion: hive.openshift.io/v1
kind: SyncSet
metadata:
  name: paramss
spec:
  ...
  enablePatchTemplates: true
  ...

  patches:
  - apiVersion: v1
    kind: ConfigMap
    name: foo
    namespace: default
    patch: |-
      {"metadata": {"annotations": {"test": "{{ fromCDLabel "hive.openshift.io/cluster-platform" }}" }}}
    patchType: merge

Note that the data type of patches[].patch is string, so internal quotes must be escaped somehow (in the above example, it's via |-). But the value of the patch once the template is rendered must be valid JSON, e.g. with double quotes surrounding string values. This can make the quoting in the unrendered patch look syntactically odd.
Enables OSD-26538 by allowing (almost)
this to work.
HIVE-2669

/lgtm

/override "Red Hat Konflux / hive-mce-27-on-pull-request" "Red Hat Konflux / hive-on-pull-request"


[Bug] Text Encoding in ProjectScanner

ProjectScanner line 255
IntArrayList tokens = ENCODING.encode(text);
java.lang.UnsupportedOperationException: Encoding special tokens is not supported. at
com.knuddels.jtokkit.SpecialEncoder.checkForSpecialTokens(SpecialEncoder.java:34) at
com.knuddels.jtokkit.GptBytePairEncoding.encodeInternal(GptBytePairEncoding.java:51) at
com.knuddels.jtokkit.GptBytePairEncoding.encode(GptBytePairEncoding.java:43) at
com.knuddels.jtokkit.GptBytePairEncoding.encode(GptBytePairEncoding.java:38) at
com.devoxx.genie.service.projectscanner.ProjectScannerService.truncateToTokens(ProjectScannerService.java:255) at
com.devoxx.genie.service.projectscanner.ProjectScannerService.lambda$scanProject$0(ProjectScannerService.java:74)

LLM suggestion:
The error message you're encountering, java.lang.UnsupportedOperationException: Encoding special tokens is not supported, comes from the jtokkit library. It indicates that the text you're trying to encode contains special tokens that the library's default encoder doesn't support.
Here's a breakdown of the issue and how to fix it in your ProjectScannerService.java file:
Understanding the Problem

Special Tokens:  Large Language Models (LLMs) often use special tokens to represent specific instructions or formatting within the text. Examples include tokens for the start of a sequence, the end of a sequence, padding, or unknown words.
jtokkit's encode(): The jtokkit library's encode() method, by default, is designed for encoding regular text and doesn't handle these special tokens.
Your Use Case: Your truncateToTokens() method is likely encountering text that, after processing, contains characters or sequences interpreted as special tokens by the LLM you're interacting with.

Solution
You need to use a different encoding method from jtokkit that is specifically designed to handle text without special tokens. The library provides encodeOrdinary() for this purpose.
Modified Code
Replace the problematic line in your truncateToTokens() method:
IntArrayList tokens = ENCODING.encode(text);

with:
IntArrayList tokens = ENCODING.encodeOrdinary(text);

Complete Updated truncateToTokens() Method
private String truncateToTokens(String text,
                                int windowContext,
                                boolean isTokenCalculation) {
    IntArrayList tokens = ENCODING.encodeOrdinary(text); // Use encodeOrdinary()
    if (tokens.size() <= windowContext) {
        return text;
    }

    IntArrayList truncatedTokens = new IntArrayList(windowContext);
    for (int i = 0; i < windowContext; i++) {
        truncatedTokens.add(tokens.get(i));
    }

    String truncatedContent = ENCODING.decode(truncatedTokens);
    return isTokenCalculation ? truncatedContent :
            truncatedContent + "\n--- Project context truncated due to token limit ---\n";
}

Explanation of the Fix

encodeOrdinary(): This method encodes the text without considering any special tokens. It's suitable for situations where you're dealing with plain text that shouldn't have LLM-specific control sequences.

Additional Considerations

Where are the special tokens coming from?

Your processing: Review your processFileContent() and removeJavadoc() methods. It's possible that after removing comments or making other modifications, the resulting text might inadvertently contain sequences that resemble special tokens.
Original source code: In rare cases, the source code itself might contain unusual characters that are misinterpreted. If you suspect this, you might need to add more robust text cleaning or sanitization to your processFileContent() method.

Token Limit: Ensure that your windowContextMaxTokens is set to an appropriate value for the LLM you're using.

Example of Text Cleaning (if needed)
If you find that you need to perform more aggressive text cleaning, here's an example of how you could modify processFileContent():
private String processFileContent(String content) {
    if (Boolean.TRUE.equals(DevoxxGenieStateService.getInstance().getExcludeJavaDoc())) {
        content = removeJavadoc(content);
    }
    // Additional cleaning to remove potentially problematic characters
    content = content.replaceAll("[^\\p{L}\\p{N}\\p{P}\\p{Z}]", ""); // Keep only letters, numbers, punctuation, and spaces
    return content;
}

Important: This is just an example. The specific cleaning you need will depend on the nature of the problematic characters you're encountering.
By using encodeOrdinary() and potentially adding text cleaning, you should be able to resolve the UnsupportedOperationException and successfully truncate your project context based on token count. Remember to thoroughly test your changes to ensure they work as expected.


Windows server2019 problem

I've wrote some simple project using SimpleWebAuthn that does registration and auth. It works great on localhost (running Windows 11), but fails when deployed at server env (running Windows Server 2019) with an error:
react_devtools_backend.js:4012 Error: Invalid key for curve: "Public key is not a point"
at t.exports (async-vendor.js:91:329050)
at t.exports (async-vendor.js:91:327623)
at e.convertPublicKeyToPEM (async-vendor.js:91:326888)
at e.verifySignature (async-vendor.js:73:28917)
at e.verifyAuthenticationResponse (async-v
Could you please share any ideas what could be the reason?

Can you share more about how you're calling @simplewebauthn/server's methods? Code samples, ideally.

async-vendor.js

Are you bundling @simplewebauthn/server into a front end project? It's not often you see vendoring like this in Node projects. If you are then that's part of the problem, Node is the only supported runtime for @simplewebauthn/server right now.

Hello, Matthew.
Thank you for your response, you are right, I'm bundling server into a
front end project as a part of a demo project. I'll change it then. Thank
you very much.
Best regards,
iLona Karpova
On Wed, Dec 28, 2022, 08:48 Matthew Miller @.***> wrote:

Can you share more about how you're calling @simplewebauthn/server's
methods? Code samples, ideally.
async-vendor.js
Are you bundling @.**/server into a front end project? It's
not often you see vendoring like this in Node projects. If you are then
that's part of the problem, Node is the only supported runtime for
@simplewebauthn/server right now.
—
Reply to this email directly, view it on GitHub
https://github.com/MasterKale/SimpleWebAuthn/issues/319#issuecomment-1366386512,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AZ5BO4F6PW5CGCYNMTEVD5LWPPID5ANCNFSM6AAAAAATJWUCZA
.
You are receiving this because you authored the thread.Message ID:
@.***>

If you're the adventurous type, the master branch currently has #299 in it which did a huge refactor to try and make it possible for server to run on more platforms. This includes using WebCrypto and Uint8Array everywhere, which means it's feasible to include server in a front end project as there's no longer going to be anything tightly coupling server to Node.
The catch is that you'd have to figure out how to get your project to work with CommonJS modules. I wouldn't spend a whole lot of time on that if you did decide to experiment with what will be released as SimpleWebAuthn v7.0.0 early next year, though, as in my experiments getting server running in a vite project I had to abandon CommonJS completely to get server running in the browser.
After v7.0.0 debuts I plan on taking another look at how I might make it possible for server to run in more browser-like environments, including browsers for those interested in building fully-contained demo sites. If you're interested I can tag you in a follow-up issue or discussion in the future when I have something for you to properly test with.

Hello, Matthew.
Great plans! I'm very interested in your project cause it looks like future
of authentication, so please tag me. Also I talked to our system
administrator, he is certain that the project is working locally because
I'm logged as windows administrator and don't have special permissions set
up. I'm not sure why it influences key generation procedure, what can be
forbidden there. Perhaps I'll investigate in that direction while you are
preparing new release. Happy New Year and thank you again for your work and
help!
Have a good weekend,
iLona Karpova
On Wed, Dec 28, 2022, 18:12 Matthew Miller @.***> wrote:

If you're the adventurous type, the master branch currently has #299
https://github.com/MasterKale/SimpleWebAuthn/pull/299 in it which did a
huge refactor to try and make it possible for server to run on more
platforms. This includes using WebCrypto and Uint8Array everywhere, which
means it's feasible to include server in a front end project as there's no
longer going to be anything tightly coupling server to Node.
The catch is that you'd have to figure out how to get your project to work
with CommonJS modules. I wouldn't spend a whole lot of time on that if you
did decide to experiment with what will be released as SimpleWebAuthn
v7.0.0 early next year, though, as in my experiments getting server
running in a vite project I had to abandon CommonJS completely to get
server running in the browser.
After v7.0.0 debuts I plan on taking another look at how I might make it
possible for server to run in more browser-like environments, including
browsers for those interested in building fully-contained demo sites. If
you're interested I can tag you in a follow-up issue or discussion in the
future when I have something for you to properly test with.
—
Reply to this email directly, view it on GitHub
https://github.com/MasterKale/SimpleWebAuthn/issues/319#issuecomment-1366721811,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AZ5BO4EYNBAUENWDIIQPCOLWPRKHRANCNFSM6AAAAAATJWUCZA
.
You are receiving this because you authored the thread.Message ID:
@.***>


[ENH] Schema changes related to BEP032

BIDS BEP032 Proposal
Contributes to #1705
Related issue about age #1634
[ ] Clarify if columns can have arrays as value, if not, how do we handle the surgery_date
[x] Add columns for _probes.tsv
[x] Add tabular_data rules for _probes.tsv
[x] Add columns for _electrodes.tsv
[x] Add tabular_data rules for _electrodes.tsv
[x] Add columns for _channels.tsv
[x] Add tabular_data rules for _channels.tsv
[ ] Add columns for _scans.tsv
[ ] Add tabular_data rules for _scans.tsv
[ ] Add columns for _events.tsv
[ ] Add tabular_data rules for _events.tsv
[ ] Add sidecars rule for _coordsystem.json
[ ] Add sidecars rule for _ephys.json
[ ] Fix language conventions, such as for e.g. -> for example,
[ ] Discuss and clear TODOs commented out in the schema
[ ] Add file naming and other modality-specific rules
[ ] Fix schema validation errors

@bids-standard/bep032

@ree-gupta Thanks again for working on this!  Could you please "enable" pre-commit for you locally -- pre-commit install so then it would check/address problems before you even make/push a commit?

@ree-gupta Thanks again for working on this! Could you please "enable" pre-commit for you locally -- pre-commit install so then it would check/address problems before you even make/push a commit?

Sure thing! Thank you for the suggestion.

Took me awhile, even sent complimentary #1963 to see the obvious gotcha! ;)   pushed the fix -- hopefully gets green now @ree-gupta ! Thanks again for working on this!!!

Took me awhile, even sent complimentary #1963 to see the obvious gotcha! ;) pushed the fix -- hopefully gets green now @ree-gupta ! Thanks again for working on this!!!
edit: CI is green where we care.

Thank you for spotting and fixing this @yarikoptic! 🙏🏽  the schema validation check passes now.


Test coverage Codec

Added isolated tests for Codecs
added @covers annotations on these and all of the existing isolated tests I've worked on so far
small test clean up of duplicated tear down methods on other test files

Coverage remained the same at 96.694% when pulling 53e4bfe2317a7c75ea1f71387b157da677baeed6 on jmauerhan:test-coverage-codec into 3c1e3ebeed7676071164ee553c8388d0b576fce2 on ramsey:master.

Coverage remained the same at 96.694% when pulling 53e4bfe2317a7c75ea1f71387b157da677baeed6 on jmauerhan:test-coverage-codec into 3c1e3ebeed7676071164ee553c8388d0b576fce2 on ramsey:master.