Layout doesn't show on Haml file

I have a dashboard in Haml, and while I can see the rendering from that file, the layout isn't rendered. I wonder what #354 was thinking...

This is kind of a side note, and probably not all that helpful... But does it work in ERB? As in is it to do with it being a HAML dashboard as opposed to just ERB?
I don't know if this would help, but I'd find the answer interesting :P

Yep, confirming that the same exact file converted to ERB will make the layout work.

I don't know about the roadmap for Dashing, or about #354 in particular, but if you're using HAML for stylistic reasons and switching to ERB fixes your problem - maybe ERB is the way to go?

Safest way to ski? Don't ski.

Toucè, I watched a keynote from the Dashing guys earlier and they clearly stated that HAML should work
Can you include your HAML for me to look at?

I converted the sample dashboard to Haml.
- content_for :title do
  My super sweet dashboard
.gridster
  %ul
    %li{"data-col" => "1", "data-row" => "1", "data-sizex" => "1", "data-sizey" => "1"}
      %div{"data-id" => "status", "data-moreinfo" => "Protip: You can drag the widgets around!", "data-text" => "", "data-title" => "Uniprix-Printemps", "data-view" => "Text"}
    %li{"data-col" => "1", "data-row" => "1", "data-sizex" => "1", "data-sizey" => "1"}
      %div{"data-id" => "participant_count", "data-title" => "Participants", "data-view" => "Number"}
    %li{"data-col" => "1", "data-row" => "1", "data-sizex" => "1", "data-sizey" => "1"}
      %div{"data-id" => "prize_sum", "data-max" => "20000", "data-min" => "0", "data-title" => "Total des prix", "data-view" => "Meter"}
    %li{"data-col" => "1", "data-row" => "1", "data-sizex" => "1", "data-sizey" => "1"}
      /

    /

      \!
  /
Try this: curl -d '{ "auth_token": "YOUR_AUTH_TOKEN", "text": "Hey, Look what I can do!" }' \http://<haml_loud>request.host</haml_loud>:<haml_loud>request.port</haml_loud>/widgets/welcome

I've had a look at your haml and added an extra DIV element to the last LI tag
Working HAML Example
The HAML in this gist is working for me - can you test it and let me know?

Any updates on this? :ski:

Haml in the Gist is not working.

Also, have you tried re-installing dashing & re-creating a project?

Let me reboot my computer, see if it works.

I had problems with layout and dashboards when using HAML. I had to use HAML for both layout and dashboard to get it to work properly.


Set up release drafter

https://github.com/marketplace/actions/release-drafter

I was missing this, thanks 😄


Failed to activate the format package

[Enter steps to reproduce:]

...
...

Atom: 1.38.2 x64
Electron: 2.0.18
OS: Ubuntu 18.04.2
Thrown From: 'format' package vundefined
Stack Trace
Failed to activate the format package
At Cannot register a command with a null listener.

Error: Cannot register a command with a null listener.
    at CommandRegistry.add (/snap/atom/232/usr/share/atom/resources/app/static/<embedded>:11:345262)
    at Object.activate (/packages/format/src/main.js:11:35)
    at Package.activateNow (/snap/atom/232/usr/share/atom/resources/app/static/<embedded>:11:3416677)
    at measure (/snap/atom/232/usr/share/atom/resources/app/static/<embedded>:11:3416089)
    at Package.measure (/snap/atom/232/usr/share/atom/resources/app/static/<embedded>:11:3413720)
    at activationPromise.activationPromise.Promise (/snap/atom/232/usr/share/atom/resources/app/static/<embedded>:11:3415949)
    at new Promise (<anonymous>)
    at Package.activate (/snap/atom/232/usr/share/atom/resources/app/static/<embedded>:11:3415892)
    at PackageManager.activatePackage (/snap/atom/232/usr/share/atom/resources/app/static/<embedded>:11:381112)
    at /snap/atom/232/usr/share/atom/resources/app/static/<embedded>:11:934678
    at r (/snap/atom/232/usr/share/atom/resources/app/static/<embedded>:11:929284)
    at n (/snap/atom/232/usr/share/atom/resources/app/static/<embedded>:14:1119363)
    at t.bufferStream (/snap/atom/232/usr/share/atom/resources/app/static/<embedded>:14:1119517)
    at Socket.e.on (/snap/atom/232/usr/share/atom/resources/app/static/<embedded>:14:1118119)
    at emitOne (events.js:121:20)
    at Socket.emit (events.js:211:7)
    at Pipe._handle.close [as _onclose] (net.js:554:12)

Commands

Non-Core Packages
atom-beautify 0.33.4
atom-clock 0.1.17
esformatter 3.0.0
formatter 2.12.4
formatter-json 1.0.1
Hydrogen 2.10.3
language-terra 0.1.0
language-terraform 0.8.1
linter-terraform-syntax 1.3.1
terraform-fmt 0.3.0
terraform-lookup 1.0.0
xml-formatter 0.13.0

Thanks for contributing!
It appears that this is being caused by the https://atom.io/packages/format package, not Atom itself. It may be that there is still a bug in Atom. If so, we'll need the maintainer of the package that is causing the problem to help track that down. You should file this issue on their repository so they can either fix the problem or tell us where the problem is coming from. The Atom FAQ has information on how to contact the maintainers of any Atom community package or theme.
Additionally, it looks like you're using the Snap install of Atom - the Snap install is unofficial and not supported by us; we recommend using an official installation method: https://flight-manual.atom.io/getting-started/sections/installing-atom/


removed what is seems as redundant PIPENV_ACTIVE when running pipenv shell

pipenv shell do not respect VIRTUAL_ENV env var because PIPENV_ACTIVE is set before accessing project.virtualenv_location method

This is not intended and will surely break things. Thanks for that tho.


Attempting AWS ERC integration

Hi Guys,
Thanks for your help over on https://github.com/NVIDIA/pyxis/issues/34.
Im attempting to configure enroot on an EC2 instance within my VPC to point to our ECR but am running into an issue Im struggling to debug. Im assuming it is something I have misconfigured but cannot see what...
I have confirmed the following:

the aws-cli is installed.
that the instance has sufficient IAM Role privileges to access our registry and the.
that aws ecr get-login-password returns a token.
that I can pull an image via the docker cli using the ecr-credential-helper.

(Note: I have obfuscated the ECR url)
I have created a readable credentials file at /etc/enroot/.credentials:
machine 1234.dkr.ecr.eu-west-2.amazonaws.com login AWS password $(aws ecr get-login-password)

when I call the following command I get a 404 not found error:
ENROOT_CONFIG_PATH=/etc/enroot enroot import --output bob.sqsh 'docker://1234.dkr.ecr.eu-west-2.amazonaws.com/my-repo'
[INFO] Querying registry for permission grant
[INFO] Authenticating with user: AWS
[ERROR] URL https://1234.dkr.ecr.eu-west-2.amazonaws.com/ returned error code: 404 Not Found

I hacked in a bit of additional logging to see what was going on:
docker::_authenticate() {
    local -r user="$1" registry="$2" url="$3"
    local realm= token= req_params=() resp_headers=

    # Query the registry to see if we're authorized.
    common::log INFO "Querying registry for permission grant"

    resp_headers=$(CURL_IGNORE=401 common::curl "${curl_opts[@]}" -I ${req_params[@]+"${req_params[@]}"} -- "${url}")
    common::log INFO "curl command opts: ${curl_opts[*]} ${url}"
    common::log INFO "resp_headers: ${resp_headers}"

    # If we don't need to authenticate, we're done.
    if ! grep -qi '^www-authenticate:' <<< "${resp_headers}"; then
        common::log INFO "Permission granted"
        return
    fi

    # Otherwise, craft a new token request from the WWW-Authenticate header.
    printf "%s" "${resp_headers}" | awk -F '="|",' '(tolower($1) ~ "^www-authenticate:"){
        sub(/"\r/, "", $0)
        print $2
        for (i=3; i<=NF; i+=2) print "--data-urlencode\n" $i"="$(i+1)
    }' | { common::read -r realm; readarray -t req_params; }

    if [ -z "${realm}" ]; then
        common::err "Could not parse authentication realm from ${url}"
    fi

    # If a user was specified, lookup his credentials.
    common::log INFO "Authenticating with user: ${user:-<anonymous>}"
    if [ -n "${user}" ]; then
        if grep -qs "machine[[:space:]]\+${registry}[[:space:]]\+login[[:space:]]\+${user}" "${creds_file}"; then
            common::log INFO "Using credentials from file: ${creds_file}"
            exec {fd}< <(common::evalnetrc "${creds_file}" 2> /dev/null)
            req_params+=("--netrc-file" "/proc/self/fd/${fd}")
        else
            req_params+=("-u" "${user}")
        fi
    fi

    # Request a new token.
    common::log INFO "Fetching new token"
    common::curl "${curl_opts[@]}" -G ${req_params[@]+"${req_params[@]}"} -- "${realm}" \
      | common::jq -r '.token? // .access_token? // empty' \
      | common::read -r token
    common::log INFO "Fetching new token - complete"

    [ -v fd ] && exec {fd}>&-

    # Store the new token.
    if [ -n "${token}" ]; then
        mkdir -m 0700 -p "${token_dir}"
        (umask 077 && printf 'header "Authorization: Bearer %s"' "${token}" > "${token_dir}/${registry}.$$")
        common::log INFO "Authentication succeeded"
    fi
}

and got the following output:
[INFO] Querying registry for permission grant
[INFO] curl command opts: --proto =https --retry 0 --connect-timeout 30 --max-time 0 -SsL https://1234.dkr.ecr.eu-west-2.amazonaws.com/v2/my-repo/manifests/latest
[INFO] resp_headers: HTTP/1.1 401 Unauthorized
Docker-Distribution-Api-Version: registry/2.0
Www-Authenticate: Basic realm="https://1234.dkr.ecr.eu-west-2.amazonaws.com/",service="ecr.amazonaws.com"
Date: Wed, 17 Feb 2021 14:14:11 GMT
Content-Length: 15
Content-Type: text/plain; charset=utf-8

[INFO] Authenticating with user: AWS
[INFO] Using credentials from file: /etc/enroot/.credentials
[INFO] Fetching new token
[ERROR] Could not process JSON input -r .token? // .access_token? // empty
[ERROR] URL --proto =https --retry 0 --connect-timeout 30 --max-time 0 -SsL -G --data-urlencode service=ecr.amazonaws.com --netrc-file /proc/self/fd/10 -- https://1234.dkr.ecr.eu-west-2.amazonaws.com/ returned error code: 404 Not Found

If I attempt to use the doker daemon, the following command does works as expected:
enroot import --output bob.sqsh 'dockerd://1234.dkr.ecr.eu-west-2.amazonaws.com/my-repo'

I feel like I am missing something simple...
I appreciate that AWS is not your primary target but any suggestions would be well received!
Best
Jon

Actually I looked into it a little more, and it's kind of a mess.
It looks like ECR doesn't follow the same spec as Docker (and other registries).
I tried to hack it quickly, see if the patch below works for you.
I'm not exactly sure how to handle this cleanly yet, so this will have to do for the time being.
--- docker.sh   2021-02-18 03:04:09.439331125 -0800
+++ /usr/lib/enroot/docker.sh   2021-02-18 03:07:30.389338296 -0800
@@ -62,17 +62,26 @@ docker::_authenticate() {
         fi
     fi

-    # Request a new token.
-    common::curl "${curl_opts[@]}" -G ${req_params[@]+"${req_params[@]}"} -- "${realm}" \
-      | common::jq -r '.token? // .access_token? // empty' \
-      | common::read -r token
+    if [[ "${registry}" =~ \.amazonaws\.com$ ]] && [ -v fd ]; then
+        grep "machine[[:space:]]\+${registry}[[:space:]]\+login[[:space:]]\+${user}" <&${fd} \
+         | awk '{print "AWS:"$6}' \
+         | base64 -w 0 \
+         | common::read -r token
+       auth="Basic"
+    else
+        # Request a new token.
+        common::curl "${curl_opts[@]}" -G ${req_params[@]+"${req_params[@]}"} -- "${realm}" \
+          | common::jq -r '.token? // .access_token? // empty' \
+          | common::read -r token
+       auth="Bearer"
+    fi

     [ -v fd ] && exec {fd}>&-

     # Store the new token.
     if [ -n "${token}" ]; then
         mkdir -m 0700 -p "${token_dir}"
-        (umask 077 && printf 'header "Authorization: Bearer %s"' "${token}" > "${token_dir}/${registry}.$$")
+        (umask 077 && printf 'header "Authorization: %s %s"' "${auth}" "${token}" > "${token_dir}/${registry}.$$")
         common::log INFO "Authentication succeeded"
     fi
 }
@@ -111,7 +120,7 @@ docker::_download() {
     local -r user="$1" registry="${2:-registry-1.docker.io}" tag="${4:-latest}" arch="$5"
     local image="$3"

-    if  [[ "${image}" != */* ]]; then
+    if  [[ "${image}" != */* ]] && [[ ! "${registry}" =~ \.amazonaws\.com$ ]]; then
         image="library/${image}"
     fi

Hi @3XX0
Many thanks for the patch - I have successfully applied the patch and can confirm that this appears to successfully authenticate against out ECR.
Im assuming that the .credentials file should look like:
machine 1234.dkr.ecr.eu-west-2.amazonaws.com login AWS password $(aws ecr get-login-password --region eu-west-2)

and not have enroot start in the login command??
srun --container-image=debian grep PRETTY /etc/os-release
pyxis: importing docker image ...
PRETTY_NAME="Debian GNU/Linux 10 (buster)"

srun --container-image=1234.dkr.ecr.eu-west-2.amazonaws.com/baseimages/python:3.7 grep PRETTY /etc/os-release
pyxis: importing docker image ...
PRETTY_NAME="Ubuntu 18.04.4 LTS"

Frustratingly, I did come up against another issue for a few of our images:
srun --container-image=1234.dkr.ecr.eu-west-2.amazonaws.com/my/repo:2.2 grep PRETTY /etc/os-release
pyxis: importing docker image ...
slurmstepd: error: pyxis: child 410888 failed with error code: 1
slurmstepd: error: pyxis: failed to import docker image
slurmstepd: error: pyxis: printing contents of log file ...
slurmstepd: error: pyxis:     [INFO] Querying registry for permission grant
slurmstepd: error: pyxis:     [INFO] Authenticating with user: AWS
slurmstepd: error: pyxis:     [INFO] Using credentials from file: /etc/enroot/.credentials
slurmstepd: error: pyxis:     [INFO] Authentication succeeded
slurmstepd: error: pyxis:     [INFO] Fetching image manifest list
slurmstepd: error: pyxis:     [INFO] Fetching image manifest
slurmstepd: error: pyxis:     [INFO] Found all layers in cache
slurmstepd: error: pyxis:     [INFO] Extracting image layers...
slurmstepd: error: pyxis:     tar: ./dev/full: Cannot mknod: Operation not permitted
slurmstepd: error: pyxis:     tar: ./dev/zero: Cannot mknod: Operation not permitted
slurmstepd: error: pyxis:     tar: ./dev/tty: Cannot mknod: Operation not permitted
slurmstepd: error: pyxis:     tar: ./dev/null: Cannot mknod: Operation not permitted
slurmstepd: error: pyxis:     tar: ./dev/random: Cannot mknod: Operation not permitted
slurmstepd: error: pyxis:     tar: ./dev/urandom: Cannot mknod: Operation not permitted
slurmstepd: error: pyxis: couldn't start container
slurmstepd: error: pyxis: if the image has an unusual entrypoint, try using --no-container-entrypoint
slurmstepd: error: spank: required plugin spank_pyxis.so: task_init() failed with rc=-1
slurmstepd: error: Failed to invoke spank plugin stack

However I think this is probably enroot configuration related and Im still digging into that...
Thanks again.

Good to know, I will clean up the patch and merge it when I have time.
Regarding your error, /dev should be excluded, see here. Somehow the --exclude regex doesn't trigger on your image, you can try tweaking it and let me know what did the trick.

Thanks @3XX0
I had a quick look and hacked in the following line:
parallel --plain ${TTY_ON+--bar} -j "${ENROOT_MAX_PROCESSORS}" mkdir {\#}\; tar -C {\#} --warning=no-timestamp --anchored --exclude='dev/*' --exclude='./dev/*' \

This is working for me tho I will be honest Im not 100% sure there will be no side effects!!
I had a look at the following serverfault post which suggests a convoluted work around - I assumed you could supply tar with multiple patterns.
https://serverfault.com/questions/803831/tar-extract-a-member-reliably-with-possible-leading-dot-slash
Let me know if this seems appropriate
Best,
Jon


feat: fix order of layers + add chrome CSS parts

This change adds the correct order of the chrome containers so a11y tab order improves going from the top chrome elements to the center chrome elements and then to the bottom chrome elements.
Before it went from top -> bottom -> center
This change makes use of disabling the CSS display: contents property on some <slot> elements essentially making them visible containers.
In addition some CSS parts were added for the different chrome sections which we'll be able to use in Mux Player.

I discovered a little issue with user-inactive not working correctly on pointermove. working on a fix


Collective slugs ending in - can't receive manual transfers or send emails

Mailgun can't send emails if the collective slug ends with -.
This will fail silently if we don't check mailgun logs.
We need to either remove collective slugs from address emails or beef-up validation.
5.7.1 [<IP_ADDRESS> 11] Our system has detected that this message is not
5.7.1 RFC 5322 compliant: 5.7.1 'From' header has non compliant domain name.
5.7.1 To reduce the amount of spam sent to Gmail, this message has been
5.7.1 blocked. Please visit
5.7.1 https://support.google.com/mail/?p=RfcMessageNonCompliant
5.7.1 and review RFC 5322 specifications for more information. q14si193947jat.81 - gsmtp

These were the parameters in this example:
"to"<EMAIL_ADDRESS>"message-id"<EMAIL_ADDRESS>"from": "Ghetto Research Lab<EMAIL_ADDRESS>"subject": "ACTION REQUIRED: your $20 donation to Ghetto Research Lab is pending"

We should prevent such slugs and migrate existing one.

@znarf, I just noticed some people were using hyphens to avoid collisions.
How should we deal with migrating these slugs?


NNI for Object detection Task

Can i use NNI for NAS for object detection task which is possible with models like YOLOV5 . If yes.. How can it be achieved ?

You need to have a search space based on YOLOv5 in hand. Then you can implement the search space in Retiarii, and explore the space with our search strategy.


Incorrect mask operation when deleting the value set through "value", "val", "setvalue".

Describe the bug:

Mask example: '+7 (999) 999-99-99' and any similar, for example: '+\972 (999) 999-99-99'
The input mask behaves differently when printing a value from the keyboard and setting the value through the "value" attribute of the "input" tag, through "$ ('input'). Val ('...')", through "$ ('input' ) .inputmask ('setvalue', '...') ".
When setting the value in any way listed above, except for keyboard input, the mask does not disappear when the focus is lost after deleting the set value. And also the removal of the backspace button with the button does not occur on the placeholder of the mask, but on each literal.

Add a link to a codepen, jsfiddle or other example page which shows the problem:

Detailed description with an example: https://jsfiddle.net/SinFx/d3zhv4nq/

OS: Windows 10
Browser: Chrome, Opera, IE and all
Inputmask version: 5.0.3 - 5.0.4-beta.21

... Sorry for google translate.

@KryukovDS ,
Thx for the detailed issue.  I will see why the unmaskedvalue isn't handled the same and also the backspaces.  The masktemplates gets cleared on lost focus for me.

@RobinHerbots, thanks for your work!
When I was compiling the example, the plugin version 5.0.4-beta.21 was connected, because the plugin is connected to the latest version (5.x) from via rawgit.com, now version 5.0.4-beta.22 is connected in the example.
Now I observe the problem only with the fourth input, where the value was set via the input attribute "value =", the second and third inputs are working correctly. Also, all inputs, including the fourth, no longer have problems with the number of clicks on backspace.
After entering numbers: http://joxi.ru/p273L4LcWNVvD2.jpg
After deleting the numbers: http://joxi.ru/n2YVzXzCZeK4EA.jpg

@KryukovDS ,
Can you have a try with the latest beta version.

@RobinHerbots, Thanks, it works!


How about working with active cases instead of total cases?

I believe, ploting active cases instead of total confirmed cases would allow better comparison of effective measures against spread of covid-19 in different countries.
Because recovered people are not infectious, the current graph is biased towards countries with a greater fraction of healed (and died) people among total cases, like China and Korea. Bigger amount of closed cases actually makes the denominator bigger, but it is not government measure for containment, making countries that first got it look better than they actually are.
Working with active cases would also help  with the second waves, otherwise invisible on the current chart.

A few issues I see with this:

Currently JHU doesn't provide active cases. They do provide recovered cases, so we can subtract these from the total number of cases. But I'm skeptical of how consistently these numbers are reported across countries. If there are large differences in reporting of recovered numbers across countries, we'd end up with misleading results.

This change would cause the trajectories on the graph to move forwards and backwards (i.e. to traverse a loop. The end = zero active cases is the same as the beginning). This could be visually confusing or distracting for most people and difficult to quickly interpret / understand.

Since this can only be done for cases (not deaths) the graph style would change when switching from confirmed cases <-> deaths, which may also be confusing.

Fair points, Aatish. I think, I should withdraw my proposal.

I think this view would be immensely valuable.
To quote Henry in his video: "But the spread of the disease only cares about two things: how many cases there are today and how many new cases there will be today." (accompanied by the illustration labeled "current # of infections".
As you say, this means the chart would move backwards, but I think that's perfect for visualizing the (possibly) cyclic nature of the pandemic:

There are a few cases
Few cases turns to many cases
Many cases spur action
Action reduces number of cases
Go to 1.

When we visualize this, then we can demonstrate to the public when we go back to square 1 and, and provide a warning to not repeat step 2.

I put together a quick demo (code here):
http://htmlpreview.github.io/?https://raw.githubusercontent.com/exclipy/covidtrends/active-cases/index.html
What do you think?

To address the understandability problem, perhaps we could ask Henry to make a followup video explaining the phase diagram.
Something like https://youtu.be/p_di4Zn4wz4?t=662

I really like the demo from @exclipy (and the explanation why it would be useful), although I think it would be better to see with active cases proposed by @alexeev instead of the last 3 weeks new cases.
I don't see an issue with the reliability of these numbers as the recovered+diseased numbers are as consistent as the total numbers (not worse or better).
Although I think there should be an option to choose between different values on X axis (total <-> actual).
The current chart has the advantage that it shows the first wave very clearly but it won't show the second wave - as pointed out by @exclipy

Tx exclipy, I was looking for this view!
To argument 2) from aatishb: When we improve the diagram based on the valuable suggestion from alexeev, and points start to move back from right to left, we should not withdraw all, only because it does not look “nice”, or because people might be too stupid to understand it. I think it is opposite: The demo view from exclipy shows the reality even better than before, as any country hit by a wave will be “after the wave” like “before the wave”, no difference, and as long as there are still too many not immune yet...

Even if I must say so myself...
Wow, I'm looking at the latest data on my view today and there are some very interesting insights comparing the paths of different countries.

I like @exclipy 's feature very much!
I came here to make this same suggestion. It's the most important view these days, because of 2nd waves and the role of visualisations to help the public understand that. without it, or something similar, this visualisation is no longer "the place to be" as it was for me in the past weeks, because all it is showing now is a continuation of the same win...
The best example IMO is China's Heilongjiang area from the end of March:
The original chart shows an increase rate which seems to be way higher than the 2-d doubling helper-line, but ofc the actual total number doesn't actually double so quickly. That helper line is relevant to total cases doubling only when the active and total cases are close...
In any case, it's not possible to assess the second wave at all.
But the same case using @exclipy 's feature and Wow! you can really see how the first wave died, and then nothing for a while, and then a second wave on that doubling-pr-2d line... almost copying the first wave. It's visually cyclic and enables early assessment of the second wave as such.
Regarding @aatishb 's valid concern about the line going backwards: that is valid. Same is a stagnant state (see the US last few days). But I think it's a plus. Winning here is just bringing this graph backwards, but nothing guarantees it doesn't change again. i strongly feel the people who come to look at a logarithmic chart of new on total, and have been discussing Covid data for so long, are ready for the next step :)
@exclipy is it simple to arrange that the lines created have some kind of visual "expiration date", e.g. that they only show the past few weeks of data, or maybe the older the data the less prominent it becomes (being greyed our gradually). I think that would do 2 things:
(a) make the whole thing easier on the eyes
(b) reflect the reality of the infection rates (assuming no significant natural immunisation rates) which aren't very affected by the past but rather only of current rates X human behaviour. That, IMO, was the best advantage of the original graph, not caring about "days from" but focussing on infection rate.

I like the "visual expiration date" style solution. I think that could help against the crowded lines.
Another suggestion. If the mouse hovers a given country it lights up. Which is good. Little arrows could be added to help to see the direction. If that is possible easily in this framework.
I also think that we should use the active cases. This bigger average window for the confirmed cases is just a workaround, to "estimate" the real active cases. If we could compare the the two solutions we could see if the active cases data source does behaves well enough to be displayed or not.

I have downloaded the original CSV-s to be able to have quick plot, and test the graph with active cases. First I validated that I have the same graph when using "confirmed cases" on the X axis.
This is the result:

Should be the same as here:
https://aatishb.com/covidtrends/?location=Austria&location=Germany&location=Hungary&location=Italy&location=South+Korea&location=Spain&location=US&location=United+Kingdom
After that I have modified the X axis to show "active cases" only. Which was calculated based on the CSV in the following way:
active cases = confirmed cases - recovered - deadth
I got the following plot:

I think it helps to evaluate if a country has many confirmed cases, but we want to see how well it gets those numbers down.
South Korea is on the first just a dip, but on the second you actually see, how they bring down the active cases, and how many new cases are still there (in the last week).

Moving on the graph left means, there are more who recover than who get ill.
Moving down means there are less and less new cases.

I think the waves of a disease will plot circles on this graph, which would also make them comparable...is the second wave bigger...was it faster under control?
I also think that you can draw "safe regions" on the graph where the virus is under control...
What do you think?
PS: Sorry did not bothered too much with the plot coloring...no fading effect either...just a quick and dirty, how it would look like.

As for another aspect. I have normalized the X axis with the countries population. As big countries have bigger infrastructure and should be able to handle bigger confirmed/active cases.
The data for the population is coming from here (there might be better sources)
https://www.worldometers.info/world-population/population-by-country/
As the US is above every other country on the diagonal, where is it really, when normalized with population size?
The first plot is the classic one with the "confirmed cases" X axis, normalized to case/100000 people:

As it can be seen on this plot, the US is not that different from other countries. The only problem is that its plot is not going down at the moment.
The second plot is one with the "active cases" X axis, also normalized to case/100000 people:

I think that with the normalization to population, the waves of each country can be better compared to each other. It would show how well the US compared to the UK, or Germany does...etc.
What do you think?
Would it make sense to update the webpage with the possibility to choose

Active cases on the X axis instead of confirmed cases
Being able to normalize via population, to make it more comparable?

I really like the charts (could have chosen a bit more different colours maybe?)
I think the problem comes from the code: it assumes that only 1 source arrives and an asynchronous function is written on that sole source. So it's not trivial to rewrite to use both confirmed cases and deaths together. At least it would require the rewriting of the main chart code.

I have taken a look on the code. It seems so as you say. It does have some inner data model, but is not prepared for: taking all the input data, building a data model, modifying the data model, creating the plots. It is more a one go script...which needs some refactoring to modify...and also some sw architectural change...to make it work.
Yes with the colors it is dificult. Especially when you put 8-10 countries on the plot. The interactive web UI would help a lot I think, with hover event, highlight, and such stuff.
However since the above plots I have added title, axis title, spaced a little the colors out, zoomed in on the important part (like leaving the noise on the bottom left corner out of the plot).
But it is of course just a simple script that produces static plots.

Thanks for pointing me here Robert
Yours are exactly the graphs I´m looking for. It would be really nice if they were in the live version, a shame it isn´t easy to do.

I like the active-case attempt by @robertgalambos very much. I still think that having the simpler "confirmed cases in the last 3 weeks" as the X-axis is better from a data-relevance point of view.

As mentioned above, the active-case data will heavily depend on each country's case-closing criteria, as well as death rate (because one dies from Corona faster than one recovers from it), whereas the confirmed-3-week data will have the same noise-factor of the 1-w y axis, i.e. just each country's different testing regiment, scope etc.

IMO the main objective of the visualisation, and the reason I like it so much, is the almost direct visualisation of R, infection rate, itself. But for a 2nd it fails to do so, and so the question here is whether 3w or active case as x-axis does that better for a second wave. @robertgalambos Would you create your graph for the Heilongjiang Region of China, where a 2nd wave occurred? Then we can clearly see whether thee visualisation helps discover and make sense of a 2nd wave.

@exclipy 's 3w x-axis nicely visualised (see gif in my comment above)  how R was very much the same for a 2nd wave as it is for the 1st wave, until measures were taken. That IMO is a super important message which is unintuitive to so many of us (the "how can it be the same after we've already suffered so much...." argument).

@aatishb I'd like again to upvote the 3w x-axis. I've been using @exclipy 's version to see Israel's 2nd wave unfolds. In the original graph one can see cases going up again, but no idea about the rate of infection. Whereas it look like Israel is approaching Wave 1 infection rate but maybe a little less, when looking at:

@aatishb an alternative idea, possibly super simple, is to have Total Cases since YYYY-MM-DD, where default is as it is now, since the start, but any date can be inserted. That would enable me to e.g. assess Israel's 2nd wave rate of infection aganist 10d doubling, by putting 2020-05-20 as start date for "Total Confirmed Cases"

@UriGrod The viruse does not cares about the confirmed cases in the last 3 weeks. It only cares about the active cases.

Each country's "case-closing criteria" is as diverse and unknown as each country's confirmed case criteria. We do not know what is better to use on the X axis. And this can also change from country to country. Our best guess is in my opinion the active cases number.
Yes I will create a graph for that too. Sorry for the slow answer but did not had that much time, in the past week.

"how can it be the same after we've already suffered so much....". One needs only to check how much of the population got the virus. It is not that big of percentage. Every sanity check calculation which I did for my country got it under 10%...And even with the current representative testing (where we do not have the final results yet) we still got under 10%. Even if check the death from New York with a death rate from 2%, it is under 10%. So heard immunity is quite far.

@robertgalambos
technically, I think the real number that matters to assess infection rate is "active and not yet in isolation". Example: In country A people are in isolation between being tested and getting the result. In country B they are "assumed innocent" so not in isolation unless tested positive. If everything else is equal, infection rate will be higher in country B.
So whereas Confirmed Last 3w isn't at all this, it might approximate it better than Active Cases, especially in countries where ppl get iso quickly. But I don't know this. I'm just saying it's an option. That's why it would be interesting to compare the Heilongjiang data with the 2 graphs. Because which one of thee metrics approximates better the number-of-actively-infecting-cases, is an empirical question.

@UriGrod I made a graph from Heilongjiang. It has not that much data as a bigger country, so I made normal and logarithmic plots. On the logarithmic plot the 0 will not be shown. That would need to be solved...but I did not bothered first.
This is the normal plot:

This is the logarithmic plot:

And this is the script, with hard coded data from today (to make it quick and dirty):
plotterspec.txt
This is an Octave file (.m) I could only attach it if it is TXT.
It seems that 3 weeks average at least in this plot does not shows the 2. wave that good as the active cases plot.
I create one with Israel as well...

@UriGrod For Israel it looks like this.
Normal plot:

And the logarithmic plot (zoomed in a little):

And the hard coded .m script as txt file:
plotterspec2.txt
I think if the active cases are on the X axis then we see better if the 2nd wave starts. It is more stretched in the Y direction.
Also in this case you can not go above the diagonal, as with the last 3 weeks data on the X axis you can, as we can see in the above Heilongjiang plots. That makes it to interpret also "difficult" as that should not happen on a log-log plot...
What do you think?

@UriGrod Made some plots for Heilongjiang. However this has quite few data, and so it is harder to see. I made normal and log-log plots. On the log-log plot the 0 is not handled, it is just missing as point. Did not bother with that.
Normal plot:

Log-log plot:

The script as .m (matlab/octave) hard-coded script renamed as .txt:
plotterspec.txt
I also made a plot for Israel because it has more data, and we might see better which is better from the two plots.
Normal plot:

Log-log plot (a little zoomed in):

The script as .m (matlab/octave) hard-coded script renamed as .txt:
plotterspec2.txt
They are similar...however the 3 week confirmed on the X axis pulls the data in the left direction, which could mislead that the situation is better, than it really is. That might could be a problem if comparing countries.
What do you think?

I think we can all agree that whether or not the total number of active cases is accurate, it is far better to approximate the total number of active cases than it is to plot the new cases versus the total number of confirmed cases. This is because with the total number of confirmed cases on the X-axis the graph will always be misleading and will always underestimate the growth rate of the epidemic. This underestimation was not much of a problem at the start of the pandemic, as the difference between the total number of confirmed cases and the total number of active cases was small.
We have to acknowledge that the graph of aatishb as it is, is inherently misleading and can lead to dangerous underestimations. It has to go. Either we take some kind of measure to estimate the number of active cases, e.g. the total number of confirmed cases in the past X weeks (which implicitly assumes there is some kind of meaningful average to be put on the contagious period of a patient and does not assume that a confirmed case can't be infected again, which I consider to be justifiable assumptions) or we hold off on publishing a more accurate graph when more accurate data is available.


Amplify configured for next.js is not removing always removing all services

Before opening, please confirm:

[X] I have checked to see if my question is addressed in the FAQ.
[X] I have searched for duplicate or closed issues.
[X] I have read the guide for submitting bug reports.
[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.

App Id
d28nwgksusfkk0
Region
eu-west-1
Amplify Hosting feature
Not applicable
Describe the bug
We have issues using Amplify configured as Next.js. We had an app with ID d28nwgksusfkk0 than now is deleted. I noticed that some PRs and branches after being closed still had cloudfront, s3 buckets, Lambda functions and cloudwatch log groups. This is a big problem because at some point the buckets are more than 100 and we are over quota. Also I'm not sure if we are paying more for things that we are not using. We have other apps using Amplify and we don't even see all their infrastructure(cloudfront, S3...). I think there's a bug somewhere in Amplify for Next.js and Bitbucket. Now they are 3 cloudfronts and buckets even after deleting the app. Cloudfront IDS: E3CDR1ZN4TVPC, E3VT9FDUFW0OQN, EEYQSHDEE3LX5. Let me know if you need more information.
Expected behavior
We were expecting not seeing the infrastructure services in our account, as Amplify does with other kind of apps. At least we were expecting to some of them to be deleted after branches/PRs are closed.
Reproduction steps

Make a next.js app
Connect previews
Connect branches
Close PRs
Close branches

Build Settings
version: 1
frontend:
  phases:
    preBuild:
      commands:
        - rm -rf serverles.yml
        - rm -rf .serverless
        - printf "//`node -p \"require('url').parse(process.env.NPM_REGISTRY_URL || 'https://registry.npmjs.org').host\"`/:_authToken=${NPM_TOKEN}\nregistry=${NPM_REGISTRY_URL:-https://registry.npmjs.org}\n" >> ~/.npmrc
        - npm ci
    build:
      commands:
        - npm run build
  artifacts:
    baseDirectory: .next
    files:
      - '**/*'
  cache:
    paths:
      - node_modules/**/*
test:
  artifacts:
    baseDirectory: cypress
    configFilePath: '**/mochawesome.json'
    files:
      - '**/*.png'
      - '**/*.mp4'
  phases:
    preTest:
      commands:
        - npm install
        - npm install start-server-and-test cypress mocha mochawesome mochawesome-merge mochawesome-report-generator --save-dev
    test:
      commands:
        - npm run build
        - >-
          npx start-test 'npm start' 3000 'npx cypress run --reporter mochawesome --reporter-options
          "reportDir=cypress/report/mochawesome-report,overwrite=false,html=false,json=true,timestamp=mmddyyyy_HHMMss"'
    postTest:
      commands:
        - npx mochawesome-merge cypress/report/mochawesome-report/mochawesome*.json > cypress/report/mochawesome.json

Additional information
We use our own serverless infrastructure for production, this is why we have a serverless.yml in our repository. I don't know if this can affect.

Hi @fnavarrodev 👋🏽 we apologize for this inconvenience. The team is root causing this behavior and we will respond with next steps once we have done some further investigation.

@fnavarrodev following up here, this issue was recently resolved and I can confirm that the resources created for the previews should be getting deleted as well. I'll go ahead and close out this issue for now.
Thanks!


🔥(backend) does not create contract definition for all product

Purpose
Currently, the ProductFactory always create a ContractDefinition. This is relation is not mandatory, so we should not create one on each Product but only when it is expected.
Proposal

[x] Generate Contract Definition only when needed
[x] Fix all related tests

The ci test fail indicates that create_dev_demo should be modified too.

Yup, this will be fixed by #482


⚠ HopeAlley Ecards has degraded performance

In 7bbcefc, HopeAlley Ecards (https://hopealley.com/ecards) experienced degraded performance:

HTTP code: 200
Response time: 6101 ms

Resolved: HopeAlley Ecards performance has improved in 3197058.


cwd option not working properly

I have a build.js script and then my elm files are in a subdirectory called "elm" so I set cwd to 'elm'.
The problem is that cwd is applied twice. Esbuild-plugin-elm appends the cwd to the "source-directories" from elm.json, but then the cwd is also set in the compileOptions. Which leads to the following compile error because the compiler already starts looking in the "elm" subdirectory:
I cannot find this file:

    elm/src/Main.elm

However, if I modify the esbuild-plugin-elm script to just return dir instead of path.join(cwd, dir) it all works.

Hey @norpan, can you test the pr out and confirm if it works for you?
yarn add "phenax/esbuild-plugin-elm#fix/source-directories-cwd"

That does seem to work!


View.Delta on items does not work for OneDrive for Business

https://{tenant}-my.sharepoint.com/_api/v2.0/drive/items/{id}/view.delta
returns
{
    "error": {
        "code": "notSupported",
        "message": "view.delta can only be called on the root."
    }
}

But https://dev.onedrive.com/items/view_delta.htm#remarks states that it support ODBiz, except for a few properties.
If would be nice if somebody can confirm this.

Hi @Mertsch, thanks for the heads up. We will update the docs. Currently, view.delta is only supported at the root on OneDrive for Business. So you'll need to make your call against /drive/root.

@daspek Thanks for the confirmation. The call against drive/root works fine. Can you give me any hint on how to actually get the details about the delta. As I see it now, I know that there are changes, but I actually have no chance of knowing who made what change and when. Is that correct?

That's basically correct. The delta response doesn't currently return lastModifiedBy but you should be able to know when a change was made by looking at lastModifiedDateTime.

Closing out the issue as the docs have been updated to reflect the expected behavior. Please keep an eye out for updates as we resolve the known differences between OneDrive and OneDrive for Business.


F#2243 show null as missing

Description
Null values will be treated as missing on the Histogram bar.
Related Issue : https://github.com/metatron-app/metatron-discovery/issues/2243
How Has This Been Tested?
Run locally.
Need additional checks?
Yes. Let's use one of testbeds.
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] I have read the CONTRIBUTING document.
[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have added tests to cover my changes.

Additional context:
For string type, I'd like to keep showing (null) for null values. (One of the famous data preparation tools works the same way).
(null) might be removed for non-string types, later. (It makes the page messy!)
But now, all null values are shown as (null).

run build
deploy to 1


why does y term get negated in cross  in vec.h

Because that's the definition of cross product: https://en.m.wikipedia.org/wiki/Cross_product#Coordinate_notation


APPS-752 dxApi utility to clone file, APPS-754 dxApi utility to clone applet.

Please update the function name to cloneDataObject. "Data object" is platform terminology for any object that exists within the context of a project (e.g. file, record, applet, workflow).

Please update the function name to cloneDataObject. "Data object" is platform terminology for any object that exists within the context of a project (e.g. file, record, applet, workflow).

Done.


Counld you publish the hyperparameters you used in experiment?Contain distance threshold and number of centroids used for classification.

Counld you publish the hyperparameters you used in experiment?Contain distance threshold and number of centroids used for classification.I can't reproduce your experimental results.

sorry, i alerady find the hyperparameters in paper


Add support for v1.3.{0..3}

Add support for

v1.3.0
v1.3.1
v1.3.2
v1.3.3

thx!

@all-contributors please add @zerosum for code


Bonus: attempt to reduce file size of uploads if too big

On JPG or PDF uploads, try to reduce the file size if too big.
Technically might be possible with JPGs, just lower the JPG quality a bit. If it's > twice the limit, shouldn't try to.
For PDFs, not sure how to go about shrinking it, probably shouldn't try.
Could also try to attach one version of the document, but still link out to a larger version of the doc? Not sure how that would for "what goes on the court's record". Would need to be very careful handling the things and making sure we don't make things not-visible.

There are some techniques to reduce pdf filesize we're already doing in one of the appeals court repos, I can try to dig up some example code if you haven't seen it already.


Create tests for Init actor

:link: zboto Link

Closing issue as it is repeated https://github.com/Zondax/filecoin-solidity-api/issues/71.


Real housing - some fixes when a tech that adds housing is boosted

Here we update all cities real housing when a tech that adds housing is boosted and research is completed during player's turn. Also made some code improvements to simplify it.
Upd: also fixed pillaged improvements were calculated for real housing.
Upd2: Reworked main function to calculate contaminated tiles correctly and to calculate real housing a bit faster. Also added some conditions to 'citypanel' and 'OnTileImproved' function to recalculate housing only for improvements with housing or when improvements are removed and to don't recalculate it when remove features or resources for examle. Improved housing updates when tile added or lost to a culture bomb. Added fix for Hot Seat games.

I just want to let you know that I have seen you're pull request and I'm sorry I didn't answer faster.
I'll review and merge it as soon as we'll be close to an updated version of cqui for the latest patch (which is taking more time that I thought).
As always thank you very much for you contributions with real housing, it's really appreciated 👍

Thank you 🎉  ! I've merged it manually, because there were some conflict as I merged the your R&F pull request first ;)

:)
@Azurency and what me to do with this bug in R&F? Should I also add it to the mod until it will be fixed? The code is ready but I want to ask what you think of it before opening pull request.


Move "connect-history-api-fallback" to devDependencies

Move "connect-history-api-fallback" to devDependencies

Great point. Thanks!


Mistral AI: Support fill-in-the-middle API for code completion models

Issue

#1523
Change

General checklist

[X] There are no breaking changes
[X] I have added unit and integration tests for my change
[X] I have manually run all the unit and integration tests in the module I have added/changed, and they are all green
[ ] I have manually run all the unit and integration tests in the core and main modules, and they are all green

[X] I have added/updated the documentation
[ ] I have added an example in the examples repo (only for "big" features)
[ ] I have added/updated Spring Boot starter(s) (if applicable)

Checklist for adding new model integration

[ ] I have added my new module in the BOM

Checklist for adding new embedding store integration

[ ] I have added a {NameOfIntegration}EmbeddingStoreIT that extends from either EmbeddingStoreIT or EmbeddingStoreWithFilteringIT
[ ] I have added my new module in the BOM

Checklist for changing existing embedding store integration

[ ] I have manually verified that the {NameOfIntegration}EmbeddingStore works correctly with the data persisted using the latest released version of LangChain4j

This PR will be in draft until this PR is merged.
@langchain4j  I think the bot has incorrectly tagged this PR with Azure and Gemini 😅

@czelabueno could you please help with review of that PR to unblock this one faster? 🙏


MapView onPress not precise when clicking next to Marker

I am setting the marker and changing its position when onPressing on the MapView.
However when I am close to a marker and want to change the position right next to it, the MapView onPress doesn't give me the right latitude and longitude. Only when I onPress a few more inches next to the Marker it works. (see the attached video)
This is quite annoying, because I can't really set the marker position properly when I want to change my position just slightly.
Is there a way to deactivate the "invisible radius" around the Marker?
const Home = () => {
  const [location, setLocation] = useState({ lat: 48, lng: 10 });

  const newPosition = ({ nativeEvent }) => {
    if (nativeEvent.coordinate) {
      const { latitude, longitude } = nativeEvent.coordinate;
      alert(`pressed: lat:${latitude}, lng:${longitude}`);
      setLocation({
        lat: latitude,
        lng: longitude,
      });
    }
  };

  return (
    <View style={styles.container}>
      <MapView style={styles.map} onPress={newPosition}>
        <Marker
          coordinate={{ latitude: location.lat, longitude: location.lng }}
        ></Marker>
      </MapView>
    </View>
  );
};

https://user-images.githubusercontent.com/86783532/127149349-dcc85e43-9c1d-4412-832f-68d875822534.mov

same, any solution mate?

Unfortunately this is the native behaviour of Apple Maps. And there's a simular "issue" on google maps. See (https://issuetracker.google.com/issues/35823783). I'm going to close this for now, as there's not a lot to do.


[Feature] Add page for Buyer detail

Description
I want to add page for buy. When the user click buy button it needs to be direct to the page where the users can give their details for their order.
Please assign this to me under GSSoC'24.
Screenshots

Checklist

[X] I have checked the existing issues
[X] I have read the Contributing Guidelines
[X] I am willing to work on this issue (optional)

Congratulations, @MuraliDharan7! 🎉 Thank you for creating your issue. Your contribution is greatly appreciated and we look forward to working with you to resolve the issue. Keep up the great work!We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

Hello @pooranjoyb I would like to work on this issue under gssoc'24

But user has a profile for their information right?
Or do you mean address?

I meant the Checkout page, where we give all the details to place an order.

@MuraliDharan7 the checkout page already exists can you brief us what exactly do you want to add in the checkout page, please share the design file before working

Let's take the above image, When I click the Buy button it is redirecting me to this page, and I am able to order easily not going to card and placing order.

@Mahitej28 @AjayAsnani Please have a look and suggest a workflow :)

Give your detail workflow @MuraliDharan7

Give the detail workflow of the process

1.Customer proceeds to checkout, enters billing and shipping information, selects a preferred shipping method.
2. Customer chooses a payment method (credit card, etc.), reviews order details and total cost, confirms purchase.
3. Order is processed, payment is verified, customer receives confirmation email with order details and estimated delivery timeframe.

Hey @MuraliDharan7 can we do these steps in a modal?

closing as no updates.


fix(libsinsp): race condition in async event

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area API-version

/area build

/area CI

/area driver-kmod

/area driver-bpf

/area driver-modern-bpf

/area libscap-engine-bpf

/area libscap-engine-gvisor

/area libscap-engine-kmod

/area libscap-engine-modern-bpf

/area libscap-engine-nodriver

/area libscap-engine-noop

/area libscap-engine-source-plugin

/area libscap-engine-savefile

/area libscap-engine-udig

/area libscap

/area libpman

/area libsinsp
/area tests

/area proposals

Does this PR require a change in the driver versions?

/version driver-API-version-major

/version driver-API-version-minor

/version driver-API-version-patch

/version driver-SCHEMA-version-major

/version driver-SCHEMA-version-minor

/version driver-SCHEMA-version-patch

What this PR does / why we need it:
Up until now, when dealing with the scenario of receiving multiple asynchronous events, there was a possibility of encountering a race condition involving the event timestamps. This could lead to inconsistent timestamps for events that are sequential. This resolves the issue.
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

NONE

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: therealbobo
Once this PR has been reviewed and has the lgtm label, please assign molter73 for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Great catch!
/milestone 0.13.0

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: FedeDP, therealbobo
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [FedeDP]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: 72543a7eb90af0d7d0dc58b87de6c9b3b87e2340

@jasondellaluce

/hold

New changes are detected. LGTM label has been removed.

So let me recap here. From now on:

all async events will be crafted with ts == -1 (container, user, group, plugin async).
the timestamp is then assigned in 2 cases:

when the async event is popped from the async queue
when the event is dumped to a scap-file during initialization

the timestamp for async events is:

the current system time when the async event is the first event we processed
the timestamp of the previous event if we already received some events

could you confirm this?

Yes, I think that a perfect summary!

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: FedeDP, jasondellaluce, therealbobo
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [FedeDP,jasondellaluce]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: c2009ccb2036bb51fcd6f3df53916d44150b114a

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: FedeDP, therealbobo
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [FedeDP]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

New changes are detected. LGTM label has been removed.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: FedeDP, therealbobo
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [FedeDP]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: 600547335dcba61577da19b33f336154a5fafd62

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Andreagit97, FedeDP, therealbobo
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Andreagit97,FedeDP]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Andreagit97, FedeDP, jasondellaluce, therealbobo
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Andreagit97,FedeDP,jasondellaluce]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

merged manually because tide is dead :skull:


add more multithreading to code

utilize thread_local and optimize usage of std::execution::par to fix perf bottlenecks

done


Merge dev to main

Fixed

Closes Issue #3

The app now reads the contents of the target file to determine what its name should be.

Added

New CLI features for a more friendly and robust experience

Try cargo run -- --help from the project directory to see the new instructions.

Nice. The way you parse together the filename might worry some people, since it almost looks like an obfuscation attempt.
No worries though. Good work


header colors

IMO the h4 and h5s are kinda drab with a black font. I'd vote for making these match the h3 font color, or giving them another color so they stand out better.

Actually, this is weird. Locally the h4 and h5s do have the same color as h3s. Its just on donejs.com that they don't. This implies there's something weird going on with CSS in production, or my setup is messed up somehow.

Looking back at this, it looks like they used to be the same as the h3 color, and this was recently changed to black. Was this intentional?

Hi @Moschel
It was an intentional change. The link colors are also blue, so in many sections the headings looked like clickable links, that are not. So, we adjusted them as they are now.


Gemini 0.17.2 does not import vep_LoF

Hi, With gemini 0.17.2 the vep_LoF column is always NULL, even though the input vcf contains many HC (high confidence) entries for this field.
It is unlikely caused by the VEP version, since with the same VEP (v79) and an older version of gemini, the import of vep_LoF worked correctly.
This is how I load the database: gemini load -v $vcf -t VEP --cores 16 out.db
This is my query: gemini query -q "select * from variants where (vep_LoF = 'HC' ) " --header out.db
I would be grateful for any assistance in this matter.

Hi, we have fixed some vep-related bugs since 0.17.2 that will be released soon in 0.18, could you try out master and let us know if that fixes this for you?
And/or if you have a VCF with a couple of records, it'd be good to add it as a test.

Thank you for the fix! I updated to master using "gemini update --devel". Column vep_LoF gets now populated.

great. I'm going to close this. please reopen if you see any more problems.


[edge] build context properties

Version
edge
Reproduction link
https://medium.com/nuxt/nuxt-2-is-coming-oh-yeah-212c1a9e1a67
Steps to reproduce
In the Nuxt 2.0 "upcoming" post on Medium it is written:

Removed context.isServer and context.isClient (Use context.client and context.server)
Removed options.dev in build.extend() (Use options.isDev)

But when I run
 extend (config, ctx) {
      console.log(ctx)
      // ...
}

it returns:

{ isDev: false, isServer: true }
{ isDev: false, isClient: true }

So either statement one or statement two from the post is false
What is expected ?
.
What is actually happening?
.

This bug report is available on Nuxt.js community (#c6786)

Yes, you are right 👍 I've published the changes.
PS: Your feedbacks on v2 are really nice. I appreciate your help  ❤

Thanks a lot, @pi0! :heart:
I'm happy that I can help to improve Nuxt and the community modules :relaxed:


Sort requirements.txt

Lets sort requirements.txt since the order doesn't really matter as discussed in #1982 .

@nwns nice seeing you here! Are you still thinking about fixing the stuff needed for Kubernetes? Would be a great addition for the project!

Thanks @matmair


refactor(GUI): remove analytics angular dependency

We rename AnalyticsService to analytics and remove its dependency on
Angular.
Changelog-Entry: Rename and de-angularise AnalyticsService to analytics

What do you guys think of this one?

From a quick glance, looks fine to me and all the code-changes seem fairly self-explanatory. Does this tie up to @stefan-mihaila 's stuff? I guess either him or @jviotti should approve ;-)

Awesome stuff @Shou , thanks a lot for handling this! Just a minor request: can we keep analytics.js to lib/gui, until we manage the move the settings model to shared?

This should be good to go now.

Forgot to remove an AnalyticsService injection from the tests. That's gone now, and the tests should pass again.


invalid_grant invalid credentials

[safari-downloader] StatusCodeError: 400 - {"error":"invalid_grant","error_description":"Invalid credentials given."}

i'm having the same issue. Is someone working on this?


feat: install tests

#8

mocha
mongodb-memory-server

:tada: This PR is included in version 1.2.0 :tada:
The release is available on:

GitHub release
v1.2.0

Your semantic-release bot :package::rocket:


Proposal: Use CFSSL for Certificates (CloudFlare SSL Toolkit)

CloudFlare has put together an awesome utility to manage an internal CA, it too is written in go. It would be really nice to see docker-machine leverage cfssl for local certificate generation and/or allow using a remote cfssl api for certificate generation so that there can easily be a common CA shared amongst many systems and developers.
https://github.com/cloudflare/cfssl
https://blog.cloudflare.com/introducing-cfssl/

Ah, very interesting.  I certainly would like to make managing that easier and/or enable teams to use Machine effectively in this manner.

@nathanleclaire I opened two other tickets with respect to making paths relative to the storage paths in each machine's config, so that the machines storage path could be moved or shared more easily.
For sharing I'm looking at using https://github.com/progrium/envy once shared environments are setup, this will allow users to commonly login to an environment and use the same machine data.
However back to the SSL stuff, the reason why I like CFSSL is that it will allow people to use centralized (if they choose to use the remote option) CA authority.

After having a chat with @ehazlett in #docker-machine, I think it is important to note that this does not have to be a replacement for the default system that is already in place.
The best idea is to require the cfssl binary to be available locally and just make it an options. Here are some ideas ...

-certificates=(default|cfssl) (could be named -pki)
-cfssl-remote=hostname CFSSL_REMOTE=hostname
-cfssl-config= CFSSL_CONFIG=filename
-cfssl-profile= CFSSL_PROFILE=profile_name
-cfssl-label= CFSSL_LABEL= (only useful on the remote cfssl implementation)
-cfssl-ca=ca.pem CFSSL_CA= (only useful on the local cfssl implementation)
-cfssl-ca-key=ca-key.pem CFSSL_CA_KEY= (only useful on local cfssl implementation)

docker-machine would need to call one of the following commands based on the above options.

cfssl sign -ca $CFSSL_CA -ca-key $CFSSL_CA_KEY -config $CFSSL_CONFIG -profile $CFSSL_PROFILE <CSR_FILE>
cfssl sign -remote $CFSSL_REMOTE -config $CFSSL_CONFIG -profile $CFSSL_PROFILE -label $CFSSL_LABEL <CSR_FILE>


mkjail update -all tries to update jail within a jail

This is an edge case. It affects only jails which are within a jail. For example:

running poudriere in a jail
FreshPorts running a freshports jail within its ingress jail

I hope few users will encounter this.
Example:
[aws-1 dan ~] % sudo mkjail update -all
Updating all jails...

Updating ingress01 jail...
...

/usr/share/zoneinfo/Pacific/Fiji
Installing updates...Scanning /jails/ingress01/usr/share/certs/blacklisted for certificates...
Scanning /jails/ingress01/usr/share/certs/trusted for certificates...
Scanning /jails/ingress01/usr/local/share/certs for certificates...
 done.

Updating ingress01.freshports jail...

cannot open 'data01/jails/ingress01.freshports': dataset does not exist
File does not exist or is not readable: /jails/ingress01.freshports/etc/freebsd-update.conf

That's because ingress01.freshports is part of the ingress01 jail.
This is the jls output on the jail host:
[aws-1 dan ~] % jls
   JID  IP Address      Hostname                      Path
    10  <IP_ADDRESS>    aws-1-ingress01.vpn.unixathom /jails/ingress01
    11  <IP_ADDRESS>    freshports                    /jails/ingress01/jails/freshports
    14  <IP_ADDRESS>    aws-1-nginx01.vpn.unixathome. /jails/nginx01
[aws-1 dan ~] %

My workaround: run mkjail in the place it was created.
We could add a list of jails to ignore.
We could find out if jls can tell us the jail owner.

jls -na indicates parent. If parent = 0, the jail is owned by this "host", be it a jail or a host proper.


any_popup_open() remains true even when there are no popups

Describe the bug

Memory::any_popup_open() can return true even when there are no popups open. This is because Memory::popup keeps its value even if a popup stops being rendered for other reasons.
Proposed solution: clear Memory::popup after a frame if is_popup_open was not called with the id of the current one (assume the popup is not showing anymore)
To Reproduce
Steps to reproduce the behavior:

Open a popup (e.g. color picker, drop-down, etc)
Without manually closing the popup, stop rendering it (i.e. don't hit that code path at all)
Memory::any_popup_open() is true

Expected behavior

Memory::any_popup_open() is false
Screenshots

Desktop (please complete the following information):

Version 0.23.0

The reason I would like any_popup_open to accurately reflect the state of popups is because I want to prevent some interactions while popups or menus are open. Users expect to click anywhere to close a popup.


Improve index page code

This commit addresses the comments in The initial index page PR
It includes some refactoring as describe in each commit message

 (5) Index page: show 100 first content items (EPIC 5)


dirs settings cannot import automatically

Describe the bug
In v0.9.2 it works fine, but when I upgrade to v0.10.0, it doesn't work. You can use vitesse to test, just upgrade unplugin-auto-import to v0.10.0 and run it, you will see:

Reproduction
/
System Info
/

Used Package Manager
pnpm
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guide.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A, please open a GitHub Discussion instead.
[X] The provided reproduction is a minimal reproducible of the bug.

Seems to work fine for me https://github.com/antfu/vitesse/commit/0d5a777f14094bec73e58a3965e8352cffe1b8f6
Please provide a minimal reproduction

@antfu Used current version of vitesse (degit + install + run dev) and got same error.
auto-imports.d.ts got overwritten and is missing const isDark: typeof import('./composables/dark')['isDark']
Maybe problem is I'm running it on Windows (10) ?

@antfu  This can be confirmed on Windows machine(Windows 11 on my use case), reverting to 0.9.5 solves the error. Although it works fine under Linux environment.

Fixed in v0.10.1
Thanks!


Unable to compile mxnet R package.

Description
Since few last commits, I'm having a problem with compiling and installing mxnet for R in Docker image.
Nothing changed in the command that previously worked.
Error Message
make: R-package/Makefile: No such file or directory
make: *** No rule to make target 'R-package/Makefile'.  Stop.

It happens on both CPU and GPU-based version.
Steps to reproduce
(Paste the commands you ran that produced the error.)
For CPU-based version:
/bin/sh -c pip install --upgrade cmake && cd / && git clone --recursive https://github.com/apache/incubator-mxnet.git && cd /incubator-mxnet && mkdir build && cd build && cmake -DUSE_CUDA=OFF -DUSE_MKL_IF_AVAILABLE=ON -DUSE_MKLDNN=OFF -DUSE_OPENMP=ON -DUSE_OPENCV=ON .. && make -j $(nproc) USE_OPENCV=1 USE_BLAS=openblas && make install && cp -a . .. && cp -a . ../lib && cd /incubator-mxnet/ && make -f R-package/Makefile rpkg

For GPU-based version:
RUN pip install --upgrade cmake && cd / && git clone --recursive https://github.com/apache/incubator-mxnet.git && cd /incubator-mxnet && mkdir build && cd build && cmake -DUSE_CUDA=ON -DUSE_MKL_IF_AVAILABLE=ON -DUSE_MKLDNN=OFF -DUSE_OPENMP=ON -DUSE_OPENCV=ON .. && make -j $(nproc) USE_OPENCV=1 USE_BLAS=openblas && make install && cp -a . .. && cp -a . ../lib && cd /incubator-mxnet/ && make -f R-package/Makefile rpkg

What have you tried to solve it?

Check documentation on any updates about compiling R package - none found.

Environment
Ubuntu-based docker images, Dockerfiles: https://github.com/kstawiski/miRNAselector/blob/master/Dockerfile.gpu and https://github.com/kstawiski/miRNAselector/blob/master/Dockerfile

Hi @kstawiski, we have temporarily removed the R package from the master branch due to C-API changes. For now, please make sure that you use git clone --recursive https://github.com/apache/incubator-mxnet.git -b v1.x when checking out the code base.

Thank you @szha for the quick response. Closing the issue.


Enforce quorum when it is set via cmdline (for small and test networks)

High Level Overview of Change

Context of Change

Type of Change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Refactor (non-breaking change that only restructures code)
[ ] Tests (You added tests for code that already exists, or your new feature included in this PR)
[ ] Documentation Updates
[ ] Release

closed in favour of https://github.com/XRPLF/rippled/pull/4489

Sorry for the churn - thanks @RichardAH for being first to address this issue! If you don't mind, could you submit a code review on #4489?

Sorry for the churn - thanks @RichardAH for being first to address this issue! If you don't mind, could you submit a code review on #4489?

Code authors shouldn’t be reviewers on their own code — even if it has been rewritten (uncredited) by someone else

Would you like to be credited? Happy to add your name on it, of course.


It doesn't show the name of the last person of each XP leaderboard page

doesn't look right. works fine for me. Can anyone else reproduce?

Server 2.3.2 Linux Docker cannot repoduce

That usually means that person left your server and you have no other servers with that person.

The mention below the leaderboard was to test that if that person is still in the server or not. But apperantely, those guys were not in the server. And with coincidence, they were at the bottom of first 2 pages. Thought this is a bug. Sorry for bothering you all. Closing the issue now.


Fix the HerroBanner's heading and reduce the height of the main header

You can merge this @thamudi since I am including the enhancements in another PR instead.


[BugFix] Fix type of exprs is not match slot

Why I'm doing:
Previously, expressions with different types were treated as the same expression resulting in query errors. Here's a fix for that
What I'm doing:
Fixes #40871
What type of PR is this:

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Does this PR entail a change in behavior?

[ ] Yes, this PR will result in a change in behavior.
[x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

[ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
[ ] Parameter changes: default values, similar parameters but with different default values
[ ] Policy changes: use new policy to replace old one, functionality automatically enabled
[ ] Feature removed
[ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

[ ] This is a backport pr

Bugfix cherry-pick branch check:

[ ] I have checked the version labels which the pr will be auto-backported to the target branch

[ ] 3.2
[ ] 3.1
[ ] 3.0
[ ] 2.5

@qian0817 It's recommended  to optimize the error msg to let users and RDs kown the error reason easily and clearly.

It issue should be fix by https://github.com/StarRocks/starrocks/pull/41969 by another way, you can check this.


tag a version

I think a version should be tagged so it will be easier to install via composer.  I recommend following symver
I am open to either one of these versions (depending on what your thoughts of the stability of the package is):

0.1.0 - if you think there still might be major changed / API changes
1.0.0 - if you are are pretty set on the packages public API.

Argeed. If we can get the KDF stuff handled quickly (viz. #5 and #11) and bump CryptoKey to k1|..., I’d say version 1.0.0. I’d accept a PR for 0.1.0 at any time; I’m actually reasonably pleased with the API as it stands.

I am almost done with #5, and was going to try to work on #11 at the same time (in the PR) so the key only has to be bumped up to k1 instead of k1 and k2.


[MRG] Change calcium conductance in L5 Pyr soma

I noticed a tiny mistake in the calcium model: calcium conductance in the soma should be 10., but it's still at the default value for the Jones model (60.).  We're still tuning the model so it's not too critical yet.

Thanks for catching this!! I'll hold off merging for more as we should make a plan about naming/tuning the models to distribute

is this a fix or tweak to the model? If it's a fix, I'd suggest merging it ...


Document how to enable a feature flag during installation

It would be great to list our feature flags on the docs site and demonstrate how to install/upgrade service catalog to enable a flag:
e.g. helm upgrade --name catalog svc-cat/catalog --set namespacedServiceBrokerEnabled=true

#dibs


Refactor structured config tests

Replace import pytest with from pytest import fixture, mark, raises.
Factor out a fixture for importing from the correct module:
@fixture(
    params=[
        "tests.structured_conf.data.dataclasses",
        "tests.structured_conf.data.attr_classes",
    ],
    ]
)
def module(request: Any) -> Any:
    return import_module(request.param)

marking as a draft because there are some merge conflicts with master


PostgreSQL 10+ sequence show in tree fix

For PostgreSQL version 10+, it's impossible to get sequence properties from sequence directly. Catalog pg_sequence view must be used. Version check and SQL select for model was added.

Thank you.
However it is the fix of Generic driver, main PostgreSQL driver already contains this improvements.
Is there any specific reason why do you use Generic driver? We plan to remove it in some future version.

Thanks for explanation. It was not obvious for me that i can use JDBC from https://jdbc.postgresql.org/download/postgresql-42.2.2.jar and and use other type than Generic.
I've just tested your suggestion - it works fine. Modern features like multilevel partitions and identity columns are also OK.
Thanks a lot.


feat: Switch build/pr jobs to shared actions

What does this PR do / why we need it
Start using shared actions introduced in https://github.com/janus-idp/.github/pull/9. Also move the setup workflow to the same shared location.
Which issue(s) does this PR fix
Fixes none
How to test changes / Special notes to the reviewer
As you can see the images still get built/push fine along with the additional manifests: https://quay.io/repository/skopecky/janus-backstage-test?tab=tags

Don't merge yet please. The PR job is failing.


googletest.h used in open source project

Please make sure that this is a build/installation issue. As per our GitHub Policy, we only address code/doc bugs, performance issues, feature requests and build/installation issues on GitHub. tag:build_template
System information

OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Ubuntu 18.04.1 LTS
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device:
TensorFlow installed from (source or binary): source
TensorFlow version: commit 6583b83dc9393118c60a9c11f15453c650fab89f
Python version: 2.7.15rc1
Installed using virtualenv? pip? conda?: sources
Bazel version (if compiling from source): 0.20.0
GCC/Compiler version (if compiling from source): gcc (Ubuntu 7.3.0-27ubuntu1~18.04) 7.3.0
CUDA/cuDNN version: -
GPU model and memory: -

Describe the problem
During compilation I get an error:
ERROR: /local/people/kamil_herba/tensorflow-x86/tensorflow/lite/testing/kernel_test/BUILD:81:1: Couldn't build file tensorflow/lite/testing/kernel_test/_objs/input_generator_test/input_generator_test.o: C++ comp
ilation of rule '//tensorflow/lite/testing/kernel_test:input_generator_test' failed (Exit 1)
tensorflow/lite/testing/kernel_test/input_generator_test.cc:21:44: fatal error: testing/base/public/googletest.h: No such file or directory
compilation terminated.

I guess that googletest.h is some internal Google header file which shouldn't be use in open source projects.
Provide the exact sequence of commands / steps that you executed before running into the problem
bazel test tensorflow/lite/testing/kernel_test:input_generator_test
Any other info / logs
@liyunlu0618 could you take a look on that?
Other similar problems from the same commit

tensorflow/lite/testing/kernel_test/generate_diff_report.cc:

tensorflow/lite/testing/kernel_test/generate_diff_report.cc:22:3: error: 'string' was not declared in this scope
   string base, test, output;

tensorflow/lite/testing/kernel_test/util_test.cc

testing/base/public/googletest.h: No such file or directory

tensorflow/lite/testing/kernel_test/diff_analyzer_test.cc:
googletest.h is not used but FLAGS_test_tmpdir which probably comes from this header is used so it should be removed as well.

I have met the same problem when running the test for tensorflow/lite/testing/kernel_test/util_test.cc.

Google Test is a publicly released open source library that can be used by any other open source project. I see it is included as depenency in the util_test.cc target: https://github.com/tensorflow/tensorflow/blob/656e7a55387fac2df1b786013adbde79cdc95fd5/tensorflow/lite/testing/kernel_test/BUILD#L33-L49
Can you recompile from scratch and attach the log? Most likely the download of googletest archive didn't succeed and you missed that in the rest of the compilation log.

@mihaimaruseac I think the error is caused by #include "testing/base/public/googletest.h". The error message is as below:
ERROR: /home/abc/tensorflow/tensorflow/lite/testing/kernel_test/BUILD:33:1: C++ compilation of rule '//tensorflow/lite/testing/kernel_test:util_test' failed (Exit 1)
tensorflow/lite/testing/kernel_test/util_test.cc:21:10: fatal error: testing/base/public/googletest.h: No such file or directory
 #include "testing/base/public/googletest.h"
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
Target //tensorflow/lite/testing/kernel_test:util_test failed to build

This PR #33123 is submitted to fix it. Could you please take a look?

Confirmed that I cannot compile tensorflow/lite/testing/kernel_test:input_generator_test although I can compile other targets using Google test. Assigning to lite/ code owners for review.

Hi @herbakamil, Looks like this issue has been fixed.
Triage Note*
As this issue has been fixed by @nairb774 via (https://github.com/tensorflow/tensorflow/commit/1c88fff548acb048f2fe64fd2564e885759def12, https://github.com/tensorflow/tensorflow/commit/c9c0e70d0b1d6d4fd618c5ebdebd859dbe59848f, https://github.com/tensorflow/tensorflow/commit/db5816707ab0fc4ae6d3959a313d67dd871a8d9d)
Please take a look at this comment. Kindly move this to closed status, if you think its resolved. Thanks!


userDidSignificantEvent not working

In AppDelegate.swift i added:
 func application(_ application: UIApplication, didFinishLaunchingWithOptions launchOptions: [UIApplicationLaunchOptionsKey: Any]?) -> Bool {
        // Override point for customization after application launch.

        Armchair.appID(APP_ID)
        Armchair.significantEventsUntilPrompt(1)

}

Then in my ViewController:
override func viewDidAppear(_ animated: Bool) {
        Armchair.userDidSignificantEvent(true)
    }

But pop up window never shown. What is wrong ? I'm using swift 3 version

Please place a debugger call and step through to determine at which point the plugin has determined your app is not ready for displaying a rating prompt.

Any update on this? I am having the same issue with swift3 branch

If you step through the logic, you will be able to see at which point the plugin determined the rating criteria have not been met.

I had the same issue and found why is it:
Reason is because even you're not using some of the flags, they're set and have default values already, which means you have to set it as your convenience in order to make it work properly. I set my own values for these flags and got it working.
Look at this function and you will understand it better:
Hope it helps!
        if debugEnabled {
            return true
        }

        if appID.isEmpty {
            return false
        }

        // check if the app has been used long enough
        let timeIntervalOfFirstLaunch = userDefaultsObject?.doubleForKey(keyForArmchairKeyType(ArmchairKey.FirstUseDate))
        if let timeInterval = timeIntervalOfFirstLaunch {
            let dateOfFirstLaunch = Date(timeIntervalSince1970: timeInterval)
            let timeSinceFirstLaunch = Date().timeIntervalSince(dateOfFirstLaunch)
            let timeUntilRate: TimeInterval = 60 * 60 * 24 * Double(daysUntilPrompt)
            if timeSinceFirstLaunch < timeUntilRate {
                return false
            }
        } else {
            return false
        }

        // check if the app has been used enough times
        let useCount = userDefaultsObject?.integerForKey(keyForArmchairKeyType(ArmchairKey.UseCount))
        if let count = useCount {
            if UInt(count) <= usesUntilPrompt {
                return false
            }
        } else {
            return false
        }

        // check if the user has done enough significant events
        let significantEventCount = userDefaultsObject?.integerForKey(keyForArmchairKeyType(ArmchairKey.SignificantEventCount))
        if let count = significantEventCount {
            if UInt(count) < significantEventsUntilPrompt {
                return false
            }
        } else {
            return false
        }

        // Check if the user previously has declined to rate this version of the app
        if userHasDeclinedToRate() {
            return false
        }

        // Check if the user has already rated the app?
        if userHasRatedCurrentVersion() {
            return false
        }

        // If the user wanted to be reminded later, has enough time passed?
        let timeIntervalOfReminder = userDefaultsObject?.doubleForKey(keyForArmchairKeyType(ArmchairKey.ReminderRequestDate))
        if let timeInterval = timeIntervalOfReminder {
            let reminderRequestDate = Date(timeIntervalSince1970: timeInterval)
            let timeSinceReminderRequest = Date().timeIntervalSince(reminderRequestDate)
            let timeUntilReminder: TimeInterval = 60 * 60 * 24 * Double(daysBeforeReminding)
            if timeSinceReminderRequest < timeUntilReminder {
                return false
            }
        } else {
            return false
        }

        // if we have a global set to not show if the end-user has already rated once, and the developer has not opted out of displaying on minor updates
        let ratedAnyVersion = userDefaultsObject?.boolForKey(keyForArmchairKeyType(ArmchairKey.RatedAnyVersion))
        if let ratedAlready = ratedAnyVersion {
            if (!shouldPromptIfRated && ratedAlready) {
                return false
            }
        }

        return true
    }```


Simulate sandbox execution of bash code or python code.

I'm trying to build an agent  to execute some shell and python code locally as follows
from langchain import OpenAI, LLMBashChain

llm = OpenAI(temperature=0)
llm_bash_chain = LLMBashChain(llm=llm, verbose=True)
print(llm_bash_chain.prompt)

tools = load_tools(["python_repl", "terminal"])
agent = initialize_agent(tools, llm, agent="zero-shot-react-description", verbose=True)
agent.run("Delete a file in the local path.")

During the process, I find that there is still some possibility that it could generate erroneous code.And running this erroneous code directly on the local machine could pose risks and vulnerabilities.Therefore, I thought of setting up a sandbox environment based on Docker locally, to execute users' agent code, so as to avoid damage to local files or the system.
I tried to set up a web service in Docker to execute python code and provide feedback. The following is a simple demo operation process.
Before starting the operation, I have installed Docker and pulled the Python 3.10 image.
Create Dockerfile
FROM python:3.10

RUN pip install -i https://pypi.tuna.tsinghua.edu.cn/simple pip -U \
    && pip config set global.index-url https://pypi.tuna.tsinghua.edu.cn/simple

RUN pip install fastapi
RUN pip install uvicorn

COPY main.py /app/
WORKDIR /app

EXPOSE 8000
CMD ["uvicorn", "main:app", "--host", "<IP_ADDRESS>", "--port", "8000"]

and I have set up a service in my project folder that can accept and execute code.
main.py
import sys
from fastapi import FastAPI, HTTPException
from pydantic import BaseModel
from typing import Any, Dict
import subprocess

app = FastAPI()

class CodeData(BaseModel):
    code: str
    code_type: str

@app.post("/execute", response_model=Dict[str, Any])
async def execute_code(code_data: CodeData):
    if code_data.code_type == "python":
        try:
            buffer = io.StringIO()
            sys.stdout = buffer
            exec(code_data.code)
            sys.stdout = sys.__stdout__
            exec_result = buffer.getvalue()

            return {"output": exec_result} if exec_result else {"message": "OK"}
        except Exception as e:
            raise HTTPException(status_code=400, detail=str(e))
    elif code_data.code_type == "shell":
        try:
            output = subprocess.check_output(code_data.code, stderr=subprocess.STDOUT, shell=True, text=True)
            return {"output": output.strip()} if output.strip() else {"message": "OK"}
        except subprocess.CalledProcessError as e:
            raise HTTPException(status_code=400, detail=str(e.output))

    else:
        raise HTTPException(status_code=400, detail="Invalid code_type")

if __name__ == "__main__":
    import uvicorn

    uvicorn.run("remote:app", host="localhost", port=8000)

then I've started it using Docker on a local port,and I can use the Langchain Agent to execute code in the sandbox and return results to avoid damage to the local environment.
the agent as follows

from langchain.llms import OpenAI
from langchain.agents import initialize_agent
from langchain.tools.base import BaseTool
import requests

class SandboxTool(BaseTool):
    name = "SandboxTool"
    description = '''Useful for when you need to execute python code or install library by pip for python code.
    The input to this tool should be a comma separated list of numbers of length two,
    the first value is code_type(type:String), the second value is code(type:String) needed to execute.
    For example:
    ["python", "print(1+2)"], ["shell", "pip install langchain"], ["shell", "ls"] ... '''

    def _run(self, query: str) -> str:
        return self.remote_request(query)

    async def _arun(self, tool_input: str) -> str:
        raise NotImplementedError("PythonRemoteReplTool does not support async")

    def remote_request(self, query: str) -> str:
        list = ast.literal_eval(query)
        url = "http://localhost:8000/execute"
        headers = {
            "Content-Type": "application/json",
        }
        json_data = {
            "code_type": list[0],
            "code": list[1]
        }
        response = requests.post(url, headers=headers, json=json_data)

        if response.status_code == 200:
            data = response.json()
            return data
        else:
            return f"Request failed, status code：{response.status_code}"

llm = OpenAI(temperature=0)
tool =SandboxTool()
tools = [tool]
sandboxagent = initialize_agent(tools, llm, agent="zero-shot-react-description", verbose=True)
sandboxagent.run("print result from 5 + 5")

Could this be a feasible sandbox solution?

Would another approach to sandboxing be to use a WASM solution, such as pyodide for executing Python code? There is some limitation on the installable packages, but it would work for testing simple python usage. eg https://til.simonwillison.net/webassembly/python-in-a-wasm-sandbox

I was researching the possibility to use glot.io (open source) as custom Langchain tool to remotely execute Python (or other languages). Let me know what you think.
Glot.io: http api for running untrusted code inside transient docker containers. For every run request a new container is started and deleted. The payload is passed to the container by attaching to it and writing it to stdin. The result is read from stdout. The communication with the docker daemon happens via it's api over the unix socket. This is used to run code on [glot.io](https://glot.io/).

https://glot.io/
https://github.com/glotcode/glot/blob/master/api_docs/run/run.md

Have a Wasm Sandboxed interpreter PR in progress that should support running the code locally in a safe manner: #6354

Sorry for the commit spam...
I've been working off of @cangcang-zcr 's above code to set up a bash sandbox to allow persistent command line interactions within a linux container. This way the agent can install and access third-party clients across a chain's action sequences.
Example:
> Entering new  chain...
 I need to install numpy and then use it to sample a number.
Action: terminal
Action Input: pip install numpy
Observation: pip install numpy
Collecting numpy
  Downloading numpy-1.25.0-cp310-cp310-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (17.6 MB)
     ━╺━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 0.5/17.6 MB 8.0 MB/s eta 0:00:03ning pip as the 'root' user can result in broken permissions and conflicting behaviour with the system package manager. It is recommended to use a virtual environment instead: https://pip.pypa.io/warnings/venv

[notice] A new release of pip is available: 23.0.1 -> 23.1.2
[notice] To update, run: pip install --upgrade pip
root@sandbox:/app#
Thought: I now need to use numpy to sample a number.
Action: terminal
Action Input: python
Observation: python
Python 3.10.12 (main, Jun 14 2023, 18:40:54) [GCC 12.2.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>>
Thought: I can now use numpy to sample a number.
Action: terminal
Action Input: import numpy as np
Observation: import numpy as np
>>>
Thought: I can now use numpy to sample a number.
Action: terminal
Action Input: np.random.randint(0, 10)
Observation: np.random.randint(0, 10)
4
>>>
Thought: I now know the final answer.
Final Answer: The sampled number is 4.

> Finished chain.
Spent a total of 4004 tokens

It requires standing up a local docker image with the API to receive and run commands so probably overkill for one-off calls to repl().
Open to any feedback/collaboration!


Adding a label element inside a component. AceEditor.setLabel()

Hello, we really like your component and it works great in our project!
Faced a problem adding the label for the editor.
We would like to be able to add a label inside the component, so as not to create a wrapper div with a label and an editor inside.
Vaadin's core components implement the HasLabel interface with default getLabel()/setLabel() methods.
We tried to use this interface to extend the methods of the AceEditor class, but it did not work. It looks like it needs some extra interaction with the label property on the client side.
We are currently using version 2.3.1 for vaadin 14.
Thanks in advance for your response!

Hi @Flekon :)
First of all thanks for the feedback, I really appreciate it.
Unfortunately I don't have the time to focus on my open source Vaadin components. Especially the version v2.3.1 with Vaadin 14 has no use case anymore and has not been updated for a long time (while v3.x has got some updates over the time).
As for your feature request, I don't think it's that easy/simple to add a label inside the editor div. I'd have to add functionality to lit-ace (the pure frontend part) to add a slot that can be accessed by the Java backend.
I think the best "workaround" would be to use a wrapper div that adds the label (as far as I know, this is what I do).
But if you want, you could create an implementation that I could merge for the v2.x version of the component.
Have a great week 💯

Thanks a lot for your quick reply!
We solved the issue by simply wrapping the component in a container with a label when the editor's attach event fires.
In any case, we are very grateful for the excellent implementation of the component and the quick feedback!


Update README & add CONTRIBUTING.md

Adds a new CONTRIBUTING doc to the repository with focused content for maintainers. I've moved the Bazel 5.x discussion to there to not overwhelm new users.
I've also reformatted the README a bit and broke it down into a "Getting started" section. Let me know your thoughts.
This depends on #687

@thiagohmcruz Fixed the below comment should be correct now


set default to 512, remove Computed

Change description
make ephemeral_storage Default to 512 if not provided
Type of change

[ ] Bug fix (fixes an issue)
[ ] New feature (adds functionality)

Checklists
Development

[ ] Pull requests may not be submitted to the master branch (use develop instead) - or they will be closed.
[ ] Lint rules pass locally
[ ] Application changes have been tested thoroughly
[ ] Automated tests covering modified code pass

Security

[ ] Security impact of change has been considered
[ ] Code follows company security practices and guidelines

Code review

[ ] Pull request has a descriptive title and context useful to a reviewer.
[ ] "Ready for review" label attached and reviewers assigned
[ ] Changes have been reviewed by at least one other contributor
[ ] Pull request linked to task tracker where applicable

Task linked: DUPLO-11537 Latest TF provider broken for new duplocloud_aws_lambda_function


New look

What do you think about this layout?

The differences with the current are:

Site name - "Manjaro Linux" uses font Comfortaa, to adhere original logo
Hyperlinks in green color
Green strip bellow the header, just for a complementary color to the black&white current layout

No additional files needed, only some code tweaks.

Well, please open a merge request for these changes. Don't change any font as those might not be installed on non-Manjaro systems. Everything else is fine with me.

OK, sure. I haven't made any fork yet :) I just wanted an opinion first. Don't worry about the font, it will be linked from Google API as it is current Lato font. The user experience will not be affected.

Ah ok. Then go for it.

If you on it, maybe you can also create a nice Download-Page for our install medias. Currently they are located here:
http://sourceforge.net/projects/manjarotest/files/
http://sourceforge.net/projects/manjarolinux/files/
Maybe just for latest release and current development versions. For other we can link still to sourceforge ...

I will try to. :)

Damn, I think I pressed wrong button