Fix template-x breadcrumbs

MWPW-134241
The breadcrumbs on stage branch is done a long time ago as an experiment, so one of the issues is the single quotes not being removed. I've moved the breadcrumbs used in template-list-v2 here and hopefully it can handle most issues already.
Test URLs:

Before: https://stage--express--adobecom.hlx.page/express/templates/search?tasks=flyer&phformat=2:3&topics=christmas lights&lighthouse=on
After: https://template-x-fix-breadcrumbs--express--adobecom.hlx.page/express/templates/search?tasks=flyer&phformat=2:3&topics=christmas lights&lighthouse=on

Codecov Report

Merging #123 (7688154) into stage (ed03c5b) will decrease coverage by 4.88%.
Report is 10 commits behind head on stage.
The diff coverage is n/a.

@@            Coverage Diff             @@
##            stage     #123      +/-   ##
==========================================
- Coverage   39.20%   34.33%   -4.88%
==========================================
  Files           9       24      +15
  Lines        5009     9295    +4286
==========================================
+ Hits         1964     3191    +1227
- Misses       3045     6104    +3059

see 16 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Still need to test the synergy with search-marquee once https://github.com/adobecom/express/pull/117 is in stage


Update set-password-expiration-policy.md

Added content under the heading "Prevent last password from being used"
This relates to the following https://github.com/MicrosoftDocs/OfficeDocs-O365ITPro/issues/58

@kwekuako I have created the PR and would like you to review and confirm, please.

@kwekuako - I would like to follow up on this. Can you please assist to check, approve and merge the content for this PR based on issue https://github.com/MicrosoftDocs/OfficeDocs-O365ITPro/issues/58?
Thank you.


Fix children types

This fixes the following:

children are accepted as spread arguments, like in the readme examples.
children may be nested infinitely.

This uses recursive types, which is supported as of TypeScript 3.7.
I was able to determine from the code that arrays of nested children are supported. A test was added to assert this behaviour.

Thanks Remco, released in 2.0.1!


cmd/compile: make available as a library

It would be nice if there was an interface to the gc. I had extreme difficulty reading through the source code (maybe due to the fact it was transpiled from C), but I've come to the conclusion that it is pretty unrealistic to use the gc for anything, barring use of the go tool. How difficult would it be to give it an API and/or add it to the stdlib?

What do you want to use gc for?
We definitely don't want to add gc to standard package because we don't
want to commit to a certain API for cmd/compile.

Well my specific usecase is for a personal project in which I have a set of *ast.Packages that I transform given some directives. Currently codegen is the way to go but I would like to be able to feed my ast to gc directly if possible.

This is too big for the standard library. See https://golang.org/doc/faq#x_in_std
We're still trying to clean up the compiler after the transition from C. Turning it into a library is quite a long way away yet.

what about just giving a very high level API so one can embed the whole go gc compiler into someone's pure-go binary?
we wouldn't commit to any gc API, just this very high-level API.
something along the lines of:
package toolchain // golang.org/x/exp/go/toolchain

type Toolchain interface {
   Compile(pkg *go/build.Package) (ofile string, err error)
   Name() string // name of this toolchain (e.g. "gc", "gccgo")
}

// open a registered toolchain (a-la database/sql)
func Open(name string) (Toolchain , error)

Serious question: what is the real advantage of a high level API over simply exec.Command("go", "build", "x.go")?

it's all in the same binary, so you can scp my-binary fresh-box:/usr/bin/. w/o any Go installation.
well, at least that's what I'd envision.

But unless we have VFS system in cmd/compile (and make it part of the API),
you will still need files in $GOROOT/pkg for it to function. Single file
deployment with the compiler won't work at this moment.

"Compiler as a library" is intriguing and I have brought this idea up internally very early on in the Go project. That said, we're far off from such a reality as @bradfitz pointed out already, and there's a lot of details (many more then meets the eye at this point) that would have to be solved.
Let's consider this as what it is, a long-term vision. No need to expand this into a long-running thread that doesn't go anywhere.

I think this should be reconsidered in light of the new WASM architecture being introduced in 1.11. This kind of work would allow things like the Go playground to be built using WASM, and other cool stuff detailed in #26384 (package-level splitting of payloads, like https://jsgo.io).

It looks like this isn't going to happen any time soon, so for the last few days I've been working on a project to automatically modify the compiler codebase to turn it into a library.
The idea is that it'll wrap up all package level variables in a state object, and replace all filesystem os calls with a virtualisation layer. All these changes to the codebase will be performed by the tool, so as the compiler codebase is changed we can re-run the tool to update the output.
This is a huge project, but I've made some progress... and I haven't come across any terminal blockers yet. It should be noted that the output code won't be of a quality required to merge back into the Go compiler codebase, so further discussion in this issue probably isn't relevant.
I've summarized my progress so far: https://github.com/dave/forky/issues/1 - best to post over there if you want to chat about it. I would love some help with the open issues!

This kind of work would allow things like the Go playground to be built using WASM

That's actually what https://github.com/ccbrown/go-web-gc is. And yes, it could be a lot less hacky if cmd/compile were a library, even if the "API" was just a version of gc.Main with alternatives to all the globals gc uses (i.e. no os.Args, objabi.GOARCH, flags, etc.).

go-interpreter/wagon is also using a fork of gc for JIT-ing WASM bytecode:
https://github.com/go-interpreter/wagon/blob/e49671cadc735db68fd1e18ea58ea7e40175257d/go.mod#L5
ie: https://github.com/twitchyliquid64/golang-asm

I imagine this would be a prerequisite for this: https://github.com/golang/go/issues/28570

https://github.com/dotnet/roslyn is a working example of this idea that makes posible writing go code analysis tools in go and using go as an embeddable scripting lang. I am currently looking into goja and tengo for the second use case but would be nice to use go for both the container and the scripting glue.


Activation prompt shows wrong path on windows and nushell

When creating an environment in nushell (uv venv) it tells me how to activate:

Activate with: overlay use .venv\bin\activate.nu

Since I am on windows, the subfolder containing the activation files is called Scripts.
When creating the environment within powershell the prompt points to the right folder:

Activate with: .venv\Scripts\activate

What's the "correct" invocation on nushell on Windows?


Be able to match OpenID Connect groups case insensitive

Need to add a flag to moon-auth allowing to do this.

Fixed in aerokube/moon-src#441.


Encoding structs with nil values

I have a struct which and I do not want keys to be included in the encoded payload when the associated value is nil. Is this possible? Maybe there should be an option for this?

Possibly a duplicate of https://github.com/devinus/poison/issues/55

Indeed, duplicate of #55.


adding unstash of artifacts to RergressionStage

Merge Checklist

[X] Have you linked this Pull Request to an Issue?
[ ] Have you updated any relevant README files, to explain how this new feature works (with examples)?
[ ] Have you added relevant test cases for your change?
[X] Do all tests and code style checks pass with ./gradlew check --info?
[x] Have you successfully run your change in a pipeline in a Jenkins instance?
[X] Have you updated the CHANGELOG?

Description
Adding functionality to unstash build artifacts for any RegressionStage jobs
This addresses Issue #448
Testing
This was tested on an internal facing Jenkins instance using a GHE repo. Not posting those details here since this public facing.
./gradlew check --info output
CAI-P039022K7M:terraform-pipeline jared.bloomer$ ./gradlew check --info
Initialized native services in: /Users/jared.bloomer/.gradle/native
Found daemon DaemonInfo{pid=45180, address=[ec8f26e4-b13a-47a6-9045-714f5d11d15b port:50459, addresses:[/0:0:0:0:0:0:0:1, /<IP_ADDRESS>]], state=Idle, lastBusy=1697466009965, context=DefaultDaemonContext[uid=46cf1275-30b9-49a6-87b3-7041f935b5db,javaHome=/opt/homebrew/Cellar/openjdk/21/libexec/openjdk.jdk/Contents/Home,daemonRegistryDir=/Users/jared.bloomer/.gradle/daemon,pid=45180,idleTimeout=10800000,priority=NORMAL,daemonOpts=--add-opens,java.base/java.util=ALL-UNNAMED,--add-opens,java.base/java.lang=ALL-UNNAMED,--add-opens,java.base/java.lang.invoke=ALL-UNNAMED,--add-opens,java.prefs/java.util.prefs=ALL-UNNAMED,-XX:MaxMetaspaceSize=256m,-XX:+HeapDumpOnOutOfMemoryError,-Xmx512m,-Dfile.encoding=UTF-8,-Duser.country=US,-Duser.language=en,-Duser.variant]} however its context does not match the desired criteria.
Java home is different.
Wanted: DefaultDaemonContext[uid=null,javaHome=/opt/homebrew/Cellar/openjdk@11/<IP_ADDRESS>/libexec/openjdk.jdk/Contents/Home,daemonRegistryDir=/Users/jared.bloomer/.gradle/daemon,pid=50769,idleTimeout=null,priority=NORMAL,daemonOpts=--add-opens,java.base/java.util=ALL-UNNAMED,--add-opens,java.base/java.lang=ALL-UNNAMED,--add-opens,java.base/java.lang.invoke=ALL-UNNAMED,--add-opens,java.prefs/java.util.prefs=ALL-UNNAMED,-XX:MaxMetaspaceSize=256m,-XX:+HeapDumpOnOutOfMemoryError,-Xmx512m,-Dfile.encoding=UTF-8,-Duser.country=US,-Duser.language=en,-Duser.variant]
Actual: DefaultDaemonContext[uid=46cf1275-30b9-49a6-87b3-7041f935b5db,javaHome=/opt/homebrew/Cellar/openjdk/21/libexec/openjdk.jdk/Contents/Home,daemonRegistryDir=/Users/jared.bloomer/.gradle/daemon,pid=45180,idleTimeout=10800000,priority=NORMAL,daemonOpts=--add-opens,java.base/java.util=ALL-UNNAMED,--add-opens,java.base/java.lang=ALL-UNNAMED,--add-opens,java.base/java.lang.invoke=ALL-UNNAMED,--add-opens,java.prefs/java.util.prefs=ALL-UNNAMED,-XX:MaxMetaspaceSize=256m,-XX:+HeapDumpOnOutOfMemoryError,-Xmx512m,-Dfile.encoding=UTF-8,-Duser.country=US,-Duser.language=en,-Duser.variant]

  Looking for a different daemon...
The client will now receive all logging from the daemon (pid: 50280). The daemon log file: /Users/jared.bloomer/.gradle/daemon/5.0/daemon-50280.out.log
Starting 5th build in daemon [uptime: 17 mins 55.067 secs, performance: 99%]
Using 10 worker leases.
Starting Build
Settings evaluated using settings file '/Users/jared.bloomer/git/github.com/terraform-pipeline/settings.gradle'.
Projects loaded. Root project using build file '/Users/jared.bloomer/git/github.com/terraform-pipeline/build.gradle'.
Included projects: [root project 'terraform-pipeline']

> Configure project :
Evaluating root project 'terraform-pipeline' using build file '/Users/jared.bloomer/git/github.com/terraform-pipeline/build.gradle'.
All projects evaluated.
Selected primary task 'check' from project :
Tasks to be executed: [task ':codenarcMain', task ':codenarcTest', task ':compileJava', task ':compileGroovy', task ':processResources', task ':classes', task ':compileTestJava', task ':compileTestGroovy', task ':processTestResources', task ':testClasses', task ':test', task ':jacocoTestReport', task ':check']
:codenarcMain (Thread[Execution worker for ':',5,main]) started.

> Task :codenarcMain
Task ':codenarcMain' is not up-to-date because:
  Input property 'source' file /Users/jared.bloomer/git/github.com/terraform-pipeline/src/BuildStage.groovy has changed.
Loaded properties file in 4ms; 362 rules
Loading ruleset from [file:/Users/jared.bloomer/git/github.com/terraform-pipeline/config/codenarc/codenarc.xml]
Loading ruleset from [rulesets/groovyism.xml]
Loading ruleset from [rulesets/basic.xml]
Loading ruleset from [rulesets/braces.xml]
Loading ruleset from [rulesets/imports.xml]
Loading ruleset from [rulesets/formatting.xml]
RuleSet configuration properties file [codenarc.properties] not found.
Analysis time=370ms
No custom message bundle found for [codenarc-messages]. Using default messages.
Report file [/Users/jared.bloomer/git/github.com/terraform-pipeline/build/reports/codenarc/main.html] created.
[ant:codenarc] CodeNarc completed: (p1=0; p2=0; p3=0) 648ms
:codenarcMain (Thread[Execution worker for ':',5,main]) completed. Took 1.062 secs.
:codenarcTest (Thread[Execution worker for ':',5,main]) started.

> Task :codenarcTest UP-TO-DATE
Skipping task ':codenarcTest' as it is up-to-date.
:codenarcTest (Thread[Execution worker for ':',5,main]) completed. Took 0.001 secs.
:compileJava (Thread[Execution worker for ':',5,main]) started.

> Task :compileJava NO-SOURCE
file or directory '/Users/jared.bloomer/git/github.com/terraform-pipeline/src/main/java', not found
Skipping task ':compileJava' as it has no source files and no previous output files.
:compileJava (Thread[Execution worker for ':',5,main]) completed. Took 0.0 secs.
:compileGroovy (Thread[Execution worker for ':',5,main]) started.
This JVM does not support getting OS memory, so no OS memory status updates will be broadcast
Initialized native services in: /Users/jared.bloomer/.gradle/native

> Task :compileGroovy
Task ':compileGroovy' is not up-to-date because:
  Task has failed previously.
Starting process 'Gradle Worker Daemon 3'. Working directory: /Users/jared.bloomer/.gradle/workers Command<EMAIL_ADDRESS>--add-opens java.base/java.lang=ALL-UNNAMED --add-opens java.base/java.lang.invoke=ALL-UNNAMED --add-opens java.prefs/java.util.prefs=ALL-UNNAMED @/private/var/folders/vs/v_tzptl970j59nq31x397vbr0000gq/T/gradle-worker-classpath13177837337760146237txt -Xmx512m -Dfile.encoding=UTF-8 -Duser.country=US -Duser.language=en -Duser.variant worker.org.gradle.process.internal.worker.GradleWorkerMain 'Gradle Worker Daemon 3'
Successfully started process 'Gradle Worker Daemon 3'
Started Gradle worker daemon (0.234 secs) with fork options<EMAIL_ADDRESS>minHeapSize=null, maxHeapSize=null, jvmArgs=[--add-opens, java.base/java.lang=ALL-UNNAMED, --add-opens, java.base/java.lang.invoke=ALL-UNNAMED, --add-opens, java.prefs/java.util.prefs=ALL-UNNAMED], classpath=[/Users/jared.bloomer/.gradle/caches/modules-2/files-2.1/org.codehaus.groovy/groovy-all/2.4.12/760afc568cbd94c09d78f801ce51aed1326710af/groovy-all-2.4.12.jar, /Users/jared.bloomer/.gradle/wrapper/dists/gradle-5.0-bin/pu5208521seraqlersebvqk/gradle-5.0/lib/ant-1.9.13.jar, /Users/jared.bloomer/.gradle/wrapper/dists/gradle-5.0-bin/pu5208521seraqlersebvqk/gradle-5.0/lib/ant-launcher-1.9.13.jar], keepAliveMode=SESSION}.
:compileGroovy (Thread[Execution worker for ':',5,main]) completed. Took 1.25 secs.
:processResources (Thread[Execution worker for ':',5,main]) started.

> Task :processResources NO-SOURCE
file or directory '/Users/jared.bloomer/git/github.com/terraform-pipeline/src/main/resources', not found
Skipping task ':processResources' as it has no source files and no previous output files.
:processResources (Thread[Execution worker for ':',5,main]) completed. Took 0.0 secs.
:classes (Thread[Execution worker for ':',5,main]) started.

> Task :classes
Skipping task ':classes' as it has no actions.
:classes (Thread[Execution worker for ':',5,main]) completed. Took 0.0 secs.
:compileTestJava (Thread[Execution worker for ':',5,main]) started.

> Task :compileTestJava NO-SOURCE
file or directory '/Users/jared.bloomer/git/github.com/terraform-pipeline/src/test/java', not found
Skipping task ':compileTestJava' as it has no source files and no previous output files.
:compileTestJava (Thread[Execution worker for ':',5,main]) completed. Took 0.0 secs.
:compileTestGroovy (Thread[Execution worker for ':',5,main]) started.

> Task :compileTestGroovy
Task ':compileTestGroovy' is not up-to-date because:
  No history is available.
:compileTestGroovy (Thread[Execution worker for ':',5,main]) completed. Took 2.283 secs.
:processTestResources (Thread[Execution worker for ':',5,main]) started.

> Task :processTestResources NO-SOURCE
file or directory '/Users/jared.bloomer/git/github.com/terraform-pipeline/src/test/resources', not found
Skipping task ':processTestResources' as it has no source files and no previous output files.
:processTestResources (Thread[Execution worker for ':',5,main]) completed. Took 0.0 secs.
:testClasses (Thread[Execution worker for ':',5,main]) started.

> Task :testClasses
Skipping task ':testClasses' as it has no actions.
:testClasses (Thread[Execution worker for ':',5,main]) completed. Took 0.0 secs.
:test (Thread[Execution worker for ':',5,main]) started.
Gradle Test Executor 4 started executing tests.

> Task :test
Task ':test' is not up-to-date because:
  No history is available.
Starting process 'Gradle Test Executor 4'. Working directory: /Users/jared.bloomer/git/github.com/terraform-pipeline Command<EMAIL_ADDRESS>-Dorg.gradle.native=false -javaagent:build/tmp/expandedArchives/org.jacoco.agent-0.8.2.jar_2aca8b620b19ecd063f63feff8caaa38/jacocoagent.jar=destfile=build/jacoco/test.exec,append=true,inclnolocationclasses=false,dumponexit=true,output=file,jmx=false @/private/var/folders/vs/v_tzptl970j59nq31x397vbr0000gq/T/gradle-worker-classpath16353838387270912434txt -Xmx512m -Dfile.encoding=UTF-8 -Duser.country=US -Duser.language=en -Duser.variant -ea worker.org.gradle.process.internal.worker.GradleWorkerMain 'Gradle Test Executor 4'
Successfully started process 'Gradle Test Executor 4'
WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by org.codehaus.groovy.reflection.CachedClass (file:/Users/jared.bloomer/.gradle/caches/modules-2/files-2.1/org.codehaus.groovy/groovy-all/2.4.12/760afc568cbd94c09d78f801ce51aed1326710af/groovy-all-2.4.12.jar) to method java.lang.Object.finalize()
WARNING: Please consider reporting this to the maintainers of org.codehaus.groovy.reflection.CachedClass
WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
WARNING: All illegal access operations will be denied in a future release

PassPlanFilePluginTest > PassPlanFilePluginTest$StashPlan.runsStashPlan() STANDARD_OUT
    MockWorkflowScript.echo Stashing tfplan-dev file
    MockWorkflowScript.dir(./)
    MockWorkflowScript.stash([name:tfplan-dev, includes:tfplan-dev])

PassPlanFilePluginTest > PassPlanFilePluginTest$UnstashPlan.runsUnstashPlan() STANDARD_OUT
    MockWorkflowScript.echo Unstashing tfplan-dev file
    MockWorkflowScript.dir(./)
    MockWorkflowScript.unstash(tfplan-dev)

TerraformImportPluginTest > TerraformImportPluginTest$RunTerraformImport.callsImportIfResource() STANDARD_OUT
    MockWorkflowScript.echo Running 'terraform import bar foo'. TerraformImportPlugin is enabled.
    MockWorkflowScript.sh: terraform import bar foo

TerraformPluginTest > TerraformPluginTest$CheckVersion.doesNotError() STANDARD_OUT
    MockWorkflowScript.ApplyJenkinsfileClosure
    MockWorkflowScript.node { }
    MockWorkflowScript.deleteDir
    MockWorkflowScript.checkout(null)

TerraformFormatCommandTest > TerraformFormatCommandTest$ToString.includesTerraformFormatCommand() STANDARD_OUT
    recursive is default in Terraform 0.11.x  - this is an unsupported option

TerraformFormatCommandTest > TerraformFormatCommandTest$ToString$WithCheck.doesNotAddCheckOptionWhenFalse() STANDARD_OUT
    recursive is default in Terraform 0.11.x  - this is an unsupported option

TerraformFormatCommandTest > TerraformFormatCommandTest$ToString$WithCheck.addsCheckOptionByDefault() STANDARD_OUT
    recursive is default in Terraform 0.11.x  - this is an unsupported option

TerraformFormatCommandTest > TerraformFormatCommandTest$ToString$WithCheck$WithPatternOverride.usesThePatternWhenCheckIsFalse() STANDARD_OUT
    recursive is default in Terraform 0.11.x  - this is an unsupported option

TerraformFormatCommandTest > TerraformFormatCommandTest$ToString$WithCheck$WithPatternOverride.usesThePatternWhenCheckIsTrue() STANDARD_OUT
    recursive is default in Terraform 0.11.x  - this is an unsupported option

TerraformFormatCommandTest > TerraformFormatCommandTest$ToString$WithRecursive.doesNothingByDefaultUnsupportedByTerraformm11() STANDARD_OUT
    recursive is default in Terraform 0.11.x  - this is an unsupported option

TerraformFormatCommandTest > TerraformFormatCommandTest$ToString$WithDiff.doesNotAddDiffOptionWhenFalse() STANDARD_OUT
    recursive is default in Terraform 0.11.x  - this is an unsupported option

TerraformFormatCommandTest > TerraformFormatCommandTest$ToString$WithDiff.addsDiffOptionByDefault() STANDARD_OUT
    recursive is default in Terraform 0.11.x  - this is an unsupported option

TerraformFormatCommandTest > TerraformFormatCommandTest$ToString$WithDiff$WithPatternOverride.usesThePatternWhenCheckIsFalse() STANDARD_OUT
    recursive is default in Terraform 0.11.x  - this is an unsupported option

TerraformFormatCommandTest > TerraformFormatCommandTest$ToString$WithDiff$WithPatternOverride.usesThePatternWhenCheckIsTrue() STANDARD_OUT
    recursive is default in Terraform 0.11.x  - this is an unsupported option

BuildWithParametersPluginTest > BuildWithParametersPluginTest$AddParameterToFirstStageOnly$WithParameters.addParametersOnlyOnceAfterMultipleCalls() STANDARD_OUT
    MockWorkflowScript.parameters: [myparams]
    MockWorkflowScript.properties: [null]

BuildWithParametersPluginTest > BuildWithParametersPluginTest$AddParameterToFirstStageOnly$WithParameters.addsTheParameters() STANDARD_OUT
    MockWorkflowScript.parameters: [myparams]
    MockWorkflowScript.properties: [null]

BuildWithParametersPluginTest > BuildWithParametersPluginTest$AddParameterToFirstStageOnly$WithParameters.runsTheInnerClosure() STANDARD_OUT
    MockWorkflowScript.parameters: []
    MockWorkflowScript.properties: [null]

AnsiColorPluginTest > AnsiColorPluginTest$AddColor.executesTheInnerClosure() STANDARD_OUT
    MockWorkflowScript.ansiColor(xterm)

AnsiColorPluginTest > AnsiColorPluginTest$AddColor.callsAnsiColorWithXTermArgument() STANDARD_OUT
    MockWorkflowScript.ansiColor(xterm)

S3BackendPluginTest > S3BackendPluginTest$Apply.addsDynamoDbTableAsBackendParameter() STANDARD_OUT
    No S3_BACKEND_BUCKET found - checking for environment-specific bucket
    No MYENV_S3_BACKEND_BUCKET found either.
    No S3_BACKEND_REGION found - checking for environment-specific region
    MYENV_S3_BACKEND_DYNAMO_TABLE_LOCK is deprecated - please use MYENV_S3_BACKEND_DYNAMODB_TABLE instead
    No S3 backend bucket found
    No S3 backend region found
    No S3 backend encrypt found
    No S3 backend kms_key_id found

S3BackendPluginTest > S3BackendPluginTest$Apply.addsEnvironmentSpecificKeyAsBackendParameter() STANDARD_OUT
    No S3_BACKEND_BUCKET found - checking for environment-specific bucket
    No MYENV_S3_BACKEND_BUCKET found either.
    No S3_BACKEND_REGION found - checking for environment-specific region
    No S3 backend bucket found
    No S3 backend region found
    No S3 backend dynamodb_table found
    No S3 backend encrypt found
    No S3 backend kms_key_id found

S3BackendPluginTest > S3BackendPluginTest$Apply.isAddedAndUsesCustomizedPatternFolderKeyAsBackendParameter() STANDARD_OUT
    No S3_BACKEND_BUCKET found - checking for environment-specific bucket
    No MYENV_S3_BACKEND_BUCKET found either.
    No S3_BACKEND_REGION found - checking for environment-specific region
    No S3 backend bucket found
    No S3 backend region found
    No S3 backend dynamodb_table found
    No S3 backend encrypt found
    No S3 backend kms_key_id found

S3BackendPluginTest > S3BackendPluginTest$Apply.addsBucketRegionUsingPreDefinedEnvironmentVariableAsBackendParameter() STANDARD_OUT
    No S3_BACKEND_BUCKET found - checking for environment-specific bucket
    No MYENV_S3_BACKEND_BUCKET found either.
    No S3_BACKEND_REGION found - checking for environment-specific region
    WARNING: DEFAULT_S3_BACKEND_REGION is deprecated, please use S3_BACKEND_REGION or MYENV_S3_BACKEND_REGION
    No S3 backend bucket found
    No S3 backend dynamodb_table found
    No S3 backend encrypt found
    No S3 backend kms_key_id found

S3BackendPluginTest > S3BackendPluginTest$Apply.skipsDynamoDbTableAsBackendParameterWhenNoneSpecified() STANDARD_OUT
    No S3_BACKEND_BUCKET found - checking for environment-specific bucket
    No MYENV_S3_BACKEND_BUCKET found either.
    No S3_BACKEND_REGION found - checking for environment-specific region
    No S3 backend bucket found
    No S3 backend region found
    No S3 backend dynamodb_table found
    No S3 backend encrypt found
    No S3 backend kms_key_id found

S3BackendPluginTest > S3BackendPluginTest$Apply.addsBucketPreDefinedByEnvironmentAsBackendParameter() STANDARD_OUT
    No S3_BACKEND_BUCKET found - checking for environment-specific bucket
    No S3_BACKEND_REGION found - checking for environment-specific region
    No S3 backend region found
    No S3 backend dynamodb_table found
    No S3 backend encrypt found
    No S3 backend kms_key_id found

S3BackendPluginTest > S3BackendPluginTest$GetBackend.shouldReturnTheValueOfTheEnvironmentSpecificS3BackendBucket() STANDARD_OUT
    No S3_BACKEND_BUCKET found - checking for environment-specific bucket

S3BackendPluginTest > S3BackendPluginTest$GetBackend.shouldReturnTheValueOfTheEnvironmentSpecificS3BackendBucketCaseInsensitive() STANDARD_OUT
    No S3_BACKEND_BUCKET found - checking for environment-specific bucket

S3BackendPluginTest > S3BackendPluginTest$GetRegion.shouldReturnTheValueOfEnvironmentSpecificS3BackendRegionCaseInsensitive() STANDARD_OUT
    No S3_BACKEND_REGION found - checking for environment-specific region

S3BackendPluginTest > S3BackendPluginTest$GetRegion.shouldReturnTheValueOfEnvironmentSpecificS3BackendRegion() STANDARD_OUT
    No S3_BACKEND_REGION found - checking for environment-specific region

S3BackendPluginTest > S3BackendPluginTest$GetRegion.shouldReturnTheValueOfDefaultS3BackendRegion() STANDARD_OUT
    No S3_BACKEND_REGION found - checking for environment-specific region
    WARNING: DEFAULT_S3_BACKEND_REGION is deprecated, please use S3_BACKEND_REGION or MYENV_S3_BACKEND_REGION

S3BackendPluginTest > S3BackendPluginTest$GetRegion.shouldPreferEnvironmentSpecificRegionOverDeprecatedDefaultS3BackendRegion() STANDARD_OUT
    No S3_BACKEND_REGION found - checking for environment-specific region

S3BackendPluginTest > S3BackendPluginTest$GetDynamoTable.shouldReturnDeprecatedS3BackendDynamoTableLockValue() STANDARD_OUT
    MYENV_S3_BACKEND_DYNAMO_TABLE_LOCK is deprecated - please use MYENV_S3_BACKEND_DYNAMODB_TABLE instead

ValidateFormatPluginTest > ValidateFormatPluginTest$FormatClosure.runsTheGivenInnerClosure() STANDARD_OUT
    recursive is default in Terraform 0.11.x  - this is an unsupported option
    MockWorkflowScript.sh: terraform fmt

ValidateFormatPluginTest > ValidateFormatPluginTest$FormatClosure.runsTerraformFormatCommandInAShell() STANDARD_OUT
    recursive is default in Terraform 0.11.x  - this is an unsupported option
    MockWorkflowScript.sh: terraform fmt

CredentialsPluginTest > CredentialsPluginTest$AddBuildCredentials.runsTheInnerClosure() STANDARD_OUT
    MockworkflowScript.withCredentials([])

CredentialsPluginTest > CredentialsPluginTest$AddBuildCredentials.callsWithCredentialsOnWorkflowScript() STANDARD_OUT
    MockworkflowScript.withCredentials([])

AwssumePluginTest > AwssumePluginTest$Apply$WithoutRoleProvided.skipsAwssumeForTerraformApply() STANDARD_OUT
    No AWS_ROLE_ARN is set, so awssume will not be used for terraform in the myEnv environment.

AwssumePluginTest > AwssumePluginTest$Apply$WithoutRoleProvided.skipsAwssumeForTerraformInit() STANDARD_OUT
    No AWS_ROLE_ARN is set, so awssume will not be used for terraform in the myEnv environment.

AwssumePluginTest > AwssumePluginTest$Apply$WithoutRoleProvided.skipsAwssumeForTerraformPlan() STANDARD_OUT
    No AWS_ROLE_ARN is set, so awssume will not be used for terraform in the myEnv environment.

GithubPRPlanPluginTest > GithubPRPlanPluginTest$AddComment$AndNotPullRequest.throwsErrorWhenInnerClosureFails() STANDARD_OUT
    MockWorkflowScript.echo terraform plan failed:
    MockWorkflowScript.sh: cat plan.err

GithubPRPlanPluginTest > GithubPRPlanPluginTest$AddComment$AndPullRequest.throwsErrorWhenInnerClosureFails() STANDARD_OUT
    MockWorkflowScript.echo terraform plan failed:
    MockWorkflowScript.sh: cat plan.err

GithubPRPlanPluginTest > GithubPRPlanPluginTest$PostPullRequestComment$doesNotBlowUp.forHttp1_1() STANDARD_OUT
    MockWorkflowScript.echo Creating comment in GitHub
    MockWorkflowScript.writeFile: [file:/MockWorkflowScript/currentDir/body.txt, text:{"body":"myPrComment"}]
    MockWorkflowScript.echo Created comment someId - some_url

TerraformEnvironmentStageTest > TerraformEnvironmentStageTest$PipelineConfigurations.doesNotBlowUpWhenRunningClosure() STANDARD_OUT
    MockWorkflowScript.node(foo)
    MockWorkflowScript.deleteDir
    MockWorkflowScript.checkout(null)
    MockWorkflowScript.withEnv([TF_VAR_environment=foo])
    MockWorkflowScript.stage(plan-foo)
    MockWorkflowScript.sh: terraform init -input=false
    MockWorkflowScript.sh: terraform plan -input=false
    Current branch is null - you're probably using a single-branch job which doesn't make your branch name available.  Assume that apply should be enabled.
    MockWorkflowScript.stage(confirm-foo)
    MockWorkflowScript.timeout([time:15, unit:MINUTES])
    MockWorkflowScript.input([message:DANGER! Your foo environment will be IMMEDIATELY DESTROYED via "terraform destroy".  Review your plan to see all the resources that will be destroyed, and confirm.   Assume that apply should be enabled.
    MockWorkflowScript.stage(apply-foo)
    MockWorkflowScript.sh: terraform init -input=false
    MockWorkflowScript.sh: terraform apply -input=false -auto-approve

FlywayCommandTest > FlywayCommandTest$WithAdditionalParameter.isFluent() STANDARD_OUT
    withAdditionalParameter: -someParam=someValue, [-someParam=someValue]

FlywayCommandTest > FlywayCommandTest$ToString$WithAdditionalParameters.addsMultipleAdditionalParameters() STANDARD_OUT
    withAdditionalParameter: -param1=value1, [-param1=value1]
    withAdditionalParameter: -param2=value2, [-param1=value1, -param2=value2]

FlywayCommandTest > FlywayCommandTest$ToString$WithAdditionalParameters.addsTheAdditionalParameter() STANDARD_OUT
    withAdditionalParameter: -someParam=someValue, [-someParam=someValue]

TerraformValidateStageTest > TerraformValidateStageTest$PipelineConfiguration.justExerciseClosureNoAssertions() STANDARD_OUT
    MockWorkflowScript.node(null)
    MockWorkflowScript.deleteDir
    MockWorkflowScript.checkout(null)
    MockWorkflowScript.stage(validate)
    MockWorkflowScript.sh: terraform validate

TerraformValidateStageTest > TerraformValidateStageTest$Build.justExerciseNoAssertions() STANDARD_OUT
    MockWorkflowScript.ApplyJenkinsfileClosure
    MockWorkflowScript.node(null)
    MockWorkflowScript.deleteDir
    MockWorkflowScript.checkout(null)
    MockWorkflowScript.stage(validate)
    MockWorkflowScript.sh: terraform validate

ConditionalApplyPluginTest > ConditionalApplyPluginTest$ShouldApply.returnsTrueForMainByDefault() STANDARD_OUT
    Current branch 'main' matches expected branches '[main, master]', stage branch-condition is met and will run.

ConditionalApplyPluginTest > ConditionalApplyPluginTest$ShouldApply.returnsTrueWhenBranchIsUnknown() STANDARD_OUT
    Current branch is null - you're probably using a single-branch job which doesn't make your branch name available.  Assume that apply should be enabled.

ConditionalApplyPluginTest > ConditionalApplyPluginTest$ShouldApply$WithApplyOnBranchEnabled.returnsTrueForFirstConfiguredBranch() STANDARD_OUT
    Current branch 'qa' matches expected branches '[qa, someOtherBranch]', stage branch-condition is met and will run.

ConditionalApplyPluginTest > ConditionalApplyPluginTest$ShouldApply$WithApplyOnBranchEnabled.returnsTrueForOtherConfiguredBranches() STANDARD_OUT
    Current branch 'someOtherBranch' matches expected branches '[qa, someOtherBranch]', stage branch-condition is met and will run.

ConditionalApplyPluginTest > ConditionalApplyPluginTest$ShouldApply$WithApplyOnEnvironmentEnabled$OnMainBranch.returnsTrueForOtherEnvironments() STANDARD_OUT
    Current branch 'main' matches expected branches '[main, master]', stage branch-condition is met and will run.

RegressionStageTest > RegressionStageTest$AutomationRepo.automationRepoAndAppRepoSpecifiedSuccessfullyCallApply() STANDARD_OUT
    MockWorkflowScript.ApplyJenkinsfileClosure
    MockWorkflowScript.node(null)
    MockWorkflowScript.stage(test)
    MockWorkflowScript.dir(someRepo)
    MockWorkflowScript.resolveScm([source:[$class:GitSCMSource, remote:git:someHost:someUser/someRepo.git, traits:[[$class:jenkins.plugins.git.traits.BranchDiscoveryTrait], [$class:LocalBranchTrait]]], targets:[null, main]])
    MockWorkflowScript.checkout(null)
    MockWorkflowScript.dir(someOtherRepo)
    MockWorkflowScript.resolveScm([source:[$class:GitSCMSource, remote:git:someHost:someUser/someOtherRepo.git, traits:[[$class:jenkins.plugins.git.traits.BranchDiscoveryTrait], [$class:LocalBranchTrait]]], targets:[null, main]])
    MockWorkflowScript.checkout(null)
    MockWorkflowScript.sh: ./bin/test.sh

RegressionStageTest > RegressionStageTest$AutomationRepo.automationRepoSpecifiedSuccessfullyCallApply() STANDARD_OUT
    MockWorkflowScript.ApplyJenkinsfileClosure
    MockWorkflowScript.node(null)
    MockWorkflowScript.stage(test)
    MockWorkflowScript.resolveScm([source:[$class:GitSCMSource, remote:git:someHost:someUser/someRepo.git, traits:[[$class:jenkins.plugins.git.traits.BranchDiscoveryTrait], [$class:LocalBranchTrait]]], targets:[null, main]])
    MockWorkflowScript.checkout(null)
    MockWorkflowScript.sh: ./bin/test.sh

RegressionStageTest > RegressionStageTest$AutomationRepo.noAutomationRepoSpecifiedSuccessfullyCallApply() STANDARD_OUT
    MockWorkflowScript.ApplyJenkinsfileClosure
    MockWorkflowScript.node(null)
    MockWorkflowScript.stage(test)
    MockWorkflowScript.checkout(null)
    MockWorkflowScript.sh: ./bin/test.sh

RegressionStageTest > RegressionStageTest$AutomationRepo.automationRepoAndAppRepoWithChangeDirectorySpecifiedSuccessfullyCallApply() STANDARD_OUT
    MockWorkflowScript.ApplyJenkinsfileClosure
    MockWorkflowScript.node(null)
    MockWorkflowScript.stage(test)
    MockWorkflowScript.dir(someRepo)
    MockWorkflowScript.resolveScm([source:[$class:GitSCMSource, remote:git:someHost:someUser/someRepo.git, traits:[[$class:jenkins.plugins.git.traits.BranchDiscoveryTrait], [$class:LocalBranchTrait]]], targets:[null, main]])
    MockWorkflowScript.checkout(null)
    MockWorkflowScript.dir(someOtherRepo)
    MockWorkflowScript.resolveScm([source:[$class:GitSCMSource, remote:git:someHost:someUser/someOtherRepo.git, traits:[[$class:jenkins.plugins.git.traits.BranchDiscoveryTrait], [$class:LocalBranchTrait]]], targets:[null, main]])
    MockWorkflowScript.checkout(null)
    MockWorkflowScript.dir(someDir)
    MockWorkflowScript.sh: ./bin/test.sh

TerraformPluginVersion12Test > TerraformPluginVersion12Test$AddInitBefore.runsTheInnerClosure() STANDARD_OUT
    MockWorkflowScript.sh: terraform init -input=false -backend=false

TerraformStartDirectoryPluginTest > TerraformStartDirectoryPluginTest$AddDirectory$WithDirectory.useDirectory() STANDARD_OUT
    MockWorkflowScript.dir(./customDirectory/)

TerraformStartDirectoryPluginTest > TerraformStartDirectoryPluginTest$AddDirectory$WithDirectory.runsTheNestedClosure() STANDARD_OUT
    MockWorkflowScript.dir(./customDirectory/)

BuildStageTest > BuildStageTest$Build.buildsWithoutError() STANDARD_OUT
    MockWorkflowScript.ApplyJenkinsfileClosure

ParameterStoreBuildWrapperPluginTest > ParameterStoreBuildWrapperPluginTest$withGlobalParameter.addGlobalParameterWithNoOptions() STANDARD_OUT
    class ParameterStoreBuildWrapperPlugin

FlywayMigrationPluginTest > FlywayMigrationPluginTest$FlywayInfoClosure.setsTheListOfOptionalEnvironmentVariables() STANDARD_OUT
    MockWorkflowScript.withEnv([KEY=value])
    MockWorkflowScript.sh: set +x
    set -o pipefail
    flyway info| tee flyway_output.txt
    set -x

FlywayMigrationPluginTest > FlywayMigrationPluginTest$FlywayInfoClosure.runsTheNestedClosure() STANDARD_OUT
    MockWorkflowScript.withEnv([])
    MockWorkflowScript.sh: set +x
    set -o pipefail
    flyway info| tee flyway_output.txt
    set -x

FlywayMigrationPluginTest > FlywayMigrationPluginTest$FlywayMigrateClosure.doesNotRunConfirmMigrationIfConfirmBeforeApplyAndDoesNotHavePendingMigration() STANDARD_OUT
    MockWorkflowScript.withEnv([])
    MockWorkflowScript.sh: set +x
    set -o pipefail
    flyway migrate| tee flyway_output.txt
    set -x

FlywayMigrationPluginTest > FlywayMigrationPluginTest$FlywayMigrateClosure.doesNotRunConfirmMigrationIfNotConfirmBeforeApplyAndHasPendingMigration() STANDARD_OUT
    MockWorkflowScript.withEnv([])
    MockWorkflowScript.sh: set +x
    flyway migrate
    set -x

FlywayMigrationPluginTest > FlywayMigrationPluginTest$FlywayMigrateClosure.runsConfirmMigrationIfConfirmBeforeApplyAndHasPendingMigration() STANDARD_OUT
    MockWorkflowScript.timeout([time:1, unit:MINUTES])
    MockWorkflowScript.input(One or more pending migrations will be applied immediately if you continue - please review the flyway info output.  Are you sure you want to continue?)
    MockWorkflowScript.withEnv([])
    MockWorkflowScript.sh: set +x
    set -o pipefail
    flyway migrate| tee flyway_output.txt
    set -x

FlywayMigrationPluginTest > FlywayMigrationPluginTest$FlywayMigrateClosure.setsTheListOfOptionalEnvironmentVariables() STANDARD_OUT
    MockWorkflowScript.sh: [script:set +e; grep Pending flyway_output.txt > /dev/null; if [ $? -eq 0 ]; then echo true; else echo false; fi, returnStdout:true]
    MockWorkflowScript.withEnv([KEY=value])
    MockWorkflowScript.sh: set +x
    set -o pipefail
    flyway migrate| tee flyway_output.txt
    set -x

FlywayMigrationPluginTest > FlywayMigrationPluginTest$FlywayMigrateClosure.runsTheNestedClosure() STANDARD_OUT
    MockWorkflowScript.sh: [script:set +e; grep Pending flyway_output.txt > /dev/null; if [ $? -eq 0 ]; then echo true; else echo false; fi, returnStdout:true]
    MockWorkflowScript.withEnv([])
    MockWorkflowScript.sh: set +x
    set -o pipefail
    flyway migrate| tee flyway_output.txt
    set -x

Gradle Test Executor 4 finished executing tests.

> Task :test
Finished generating test XML results (0.035 secs) into: /Users/jared.bloomer/git/github.com/terraform-pipeline/build/test-results/test
Generating HTML test report...
Finished generating test html results (0.069 secs) into: /Users/jared.bloomer/git/github.com/terraform-pipeline/build/reports/tests/test
:test (Thread[Execution worker for ':',5,main]) completed. Took 8.723 secs.
:jacocoTestReport (Thread[Execution worker for ':',5,main]) started.

> Task :jacocoTestReport
Task ':jacocoTestReport' is not up-to-date because:
  No history is available.
[ant:jacocoReport] Loading execution data file /Users/jared.bloomer/git/github.com/terraform-pipeline/build/jacoco/test.exec
[ant:jacocoReport] Writing bundle 'terraform-pipeline' with 197 classes
:jacocoTestReport (Thread[Execution worker for ':',5,main]) completed. Took 1.338 secs.
:check (Thread[Execution worker for ':',5,main]) started.

> Task :check
Skipping task ':check' as it has no actions.
:check (Thread[Execution worker for ':',5,main]) completed. Took 0.0 secs.

BUILD SUCCESSFUL in 17s
6 actionable tasks: 5 executed, 1 up-to-date
Stopped 1 worker daemon(s).

/
/


Add highest sequenceId for CommandSendReceipt.

Motivation
Since #5491 merged, while user use new pulsar client to produce batch messages to older version broker(e.g. 2.4.0), send ack error will occur:
[pulsar-client-io-8-2] WARN  org.apache.pulsar.client.impl.ProducerImpl - [persistent://sandbox/pressure-test/test-A-partition-11] [pulsar-cluster-test-13-294] Got ack for msg. expecting: 13 - got: 224 - queue-size: 9

The problem is client use highest sequence id to match the response sequence id, but in old version broker can not return the highest id.
So, this pr is try to fix the problem of produce batch message with new version client and old version broker.
Modifications
Add highest sequence id to CommandSendReceipt. If the response highest sequence id of send receipt > lowest sequence id, it means broker is a new version broker, so we need to verify the highest sequence id, otherwise we only verify the lowest sequence id.
Verifying this change
I have test on my mac book, use new version client to produce batch messages to new version broker passed and use new version client to produce batch messages to old version broker (2.4.0)passed.
Does this pull request potentially affect one of the following parts:
If yes was chosen, please highlight the changes

Dependencies (does it add or upgrade a dependency): (no)
The public API: (no)
The schema: (no)
The default values of configurations: (no)
The wire protocol: (yes)
The rest endpoints: (no)
The admin cli options: (no)
Anything that affects deployment: (no)

Documentation

Does this pull request introduce a new feature? (no)

integration tests will added

run cpp tests
run java8 tests

backward compatibility(for 2.2.0, 2.3.0, 2.40) check is added, please help review this PR.

run java8 tests

run java8 tests

run java8 tests


Lax @nuxt/kit requirement version

The module currently wants @nuxt/kit-edge@latest as a runtime dependency:
https://github.com/cpsoinos/nuxt-svgo/blob/b30c65b5e3d034a1cb198bf351355de34d02ac92/package.json#L48
Is there a specific reason to do so? This leads to duplicate @nuxt/kit pulled for no apparent reason.
Will the module not work with "@nuxt/kit": "^3.4.0"?

I am not aware of the reason
@cpsoinos is there any specific reason ?

I quickly tested with package.json overrides in my project:
{
  "pnpm": {
    "overrides": {
      "@nuxt/kit": "~3.6.2"
    }
  }
}

and it worked just fine, both dev and prod build. I think it should also work with ^3.4.0 so if possible please lax it to that semver (I am stuck at Nuxt 3.4 at some other project due to multiple suspense issues in 3.5+).

Okay, I'll downgrade and run tests, if it works without any problem, sure

It seems this is the way https://github.com/nuxt/module-builder recommends setting it up
I tried to use ^3.4.0 but latest module-builder requires at least 3.5.0

resolved by #141


kawpow-stratum-pool module integration

How to use with the kawpow-stratum-pool module?

You would have to work out how to program it in. I'm not familiar with the kawpow-stratum-pool but shouldn't it already have built-in kawpow verification?

I'm not programmer and I dont how to. I need help how to built in that validator. My raven daemon shows that kind of errors:
ERROR: ProcessNewBlock: AcceptBlock FAILED (proof of work failed)
ERROR: CheckBlock: Consensus::CheckBlockHeader: high-hash, proof of work failed (code 16)
Someone said that kawpowd validator do the trick but not mention how.


Improve layout of landing page

The layout of the landing page is way too tall. It takes a fair bit of scrolling to see all the major features of the product. Someone in a hurry wouldn't even notice it doesn't more than L7 load balancing. We need to reorganize the landing page to bring key info above the fold.

I don't think this is a webpage layout HTML/CSS/JS thing. I think this is a presales/copywriting issue.
Typically with a landing page you want to summarize the product and make your initial "presales" pitch above the fold -- i.e. without requiring the user to scroll...
The bands we have are four features but there should be a top introduction with maybe an image or video that introduces istio and makes the reader want to scroll for more.

Related to issue #278


Support person entities

Looks like all person entities are always reported as unknown.

Could you share a snippet of a YAML file with the person declaration so we can troubleshoot this issue? Thanks!

Lovelace dashboard:
type: entities
entities:
  - entity: person.name_surname
    secondary_info: last-updated
  - entity: person.another_name_surname
    secondary_info: last-updated
  - entity: person.another_other_name_surname
    secondary_info: last-updated
title: Presença
state_color: false
show_header_toggle: true

Will be fixed in 0.6.4


Replace std's HashMap to tikv_util's HashMap

What have you changed? (mandatory)

Replace std's HashMap to tikv_util's HashMap

What are the type of changes? (mandatory)

Engineering (engineering change which doesn't change any feature or fix any issue)

How has this PR been tested? (mandatory)
make dev
Does this PR affect documentation (docs) or release note? (mandatory)
No.
Does this PR affect tidb-ansible update? (mandatory)
No.

/run-all-test

@sticnarf PTAL.

/run-auto-merge


solved-delete-quote-bug #15

For more details #15

Not solve

Ok what is needed

Ok what is needed

First qutoes are deleting on the refresh
And second issue is you can't delete of other user qutoes.. only when you post then you can delete your qutoes and this functionality work on without login...


feat: [ADD]-Sub Category- Automation Tools #2345

closes #2345
Add Sub Category
Adding a sub category named Automation Tools where, insert various tools in this category.
Screenshots

Links I have posted

Ansible Automation- view
Terraform Infrastructure- View
GitLab CI/CD- View
Configuration Management with Puppet and Chef- View

@Anmol-Baranwal Anmol, is this correct, or should I post a link to another website? Please let me know if there are any issues with the tools.

@CBID2
@Anmol-Baranwal
@rupali-codes
Someone reply to my pull request, if I need to change anything then please tell me.

@CBID2
@Anmol-Baranwal
@rupali-codes
Someone reply to my pull request, if I need to change anything then please tell me.

Sure, I will review it till evening and let you know if there are any changes required.

@rupali-codes
Please deploy this.
@mdazfar2
Please link the issue to the PR so that when it merges, the issue would be automatically closed.
Read it here. I've done it this time for you.

@Anmol-Baranwal, did you approve this PR?
@rupali-codes, can you approve it too?


Error when using ob-fsharp

Description:
Hello people, hope you're good. I'm currently facing a problem with the package ob-fsharp. The configuration I'm using is this:
;; Code evaluation in org-mode
(use-package ob-fsharp
  :straight (ob-fsharp
             :type git
             :host github
             :repo "juergenhoetzel/ob-fsharp"
             :branch master))

Then, during the initialization, I get this error:

Error (use-package): org/:config: Cannot open load file: No such file or directory, ob-fsharp

My org configuration, for the concerning part:
(use-package org
  :straight t
  ;; ...
  :config
  (org-babel-do-load-languages
   'org-babel-load-languages
   '((sql      . t)
     (latex    . t)
     (shell    . t)
     (python   . t)
     (js       . t)
     (plantuml . t)
     (ditaa    . t)
     (C        . t)
     (org      . t)
     (fsharp   . t))))

Am I missing something?

I'm not sure if it could be related, but the ob-fsharp configuration appears after the org package configuration in my .emacs file.

https://github.com/64J0/Emacs-config/blob/master/src/org-mode.el

Also, I noticed that we don't have a receipt for the ob-fsharp package. How can I add it?

Everything appears to install correctly with the following test case.

Test Case
(straight-bug-report
  :user-dir "straight.ob-fsharp"
  :preserve t
  :post-bootstrap
  (straight-use-package 'use-package)
  (use-package ob-fsharp :straight
    (ob-fsharp :host github :repo "juergenhoetzel/ob-fsharp")))

Test run at: 2023-02-04 11:49:26
system-type: gnu/linux
straight-version: prerelease (HEAD -> refactor/straight-get-recipe, fork/refactor/straight-get-recipe) 3525d4c 2023-01-29
emacs-version: GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.36, cairo version 1.17.6) of 2023-01-23

Output
Bootstrapping straight.el...
Bootstrapping straight.el...done
Looking for gnu-elpa-mirror recipe → Cloning melpa...
Looking for gnu-elpa-mirror recipe → Cloning melpa...done
Looking for nongnu-elpa recipe → Cloning gnu-elpa-mirror...
Looking for nongnu-elpa recipe → Cloning gnu-elpa-mirror...done
Looking for emacsmirror-mirror recipe → Cloning nongnu-elpa...
Looking for emacsmirror-mirror recipe → Cloning nongnu-elpa...done
Looking for emacsmirror-mirror recipe → Cloning el-get...
Looking for emacsmirror-mirror recipe → Cloning el-get...done
Looking for straight recipe → Cloning emacsmirror-mirror...
Looking for straight recipe → Cloning emacsmirror-mirror...done
Building straight...
Building straight...done

Test run with version: prerelease (HEAD -> develop, origin/develop) 3fa415c 2023-01-20
Cloning use-package...
Cloning use-package...done
Building use-package...
Building use-package → Building bind-key...
Building use-package → Building bind-key...done
Building use-package...
Building use-package...done
Cloning ob-fsharp...
Cloning ob-fsharp...done
Building ob-fsharp...
Building ob-fsharp → Cloning emacs-fsharp-mode...
Building ob-fsharp → Cloning emacs-fsharp-mode...done
Building ob-fsharp → Building fsharp-mode...
Building ob-fsharp → Building fsharp-mode...done
Building ob-fsharp...

  (set-default-toplevel-value sym value)
  (dolist (pair org-babel-load-languages)
    (let ((active (cdr pair)) (lang (symbol-name (car pair))))
      (if active
	  (require (intern (concat "ob-" lang)))
	(fmakunbound
	 (intern (concat "org-babel-execute:" lang)))
	(fmakunbound
	 (intern (concat "org-babel-expand-body:" lang)))))))

You'll need to add ob-fsharp to that list and org-babel-do-load-languages /after/ it has been installed/activated. You should be able to do so in the :config section of your use-package declaration for ob-fsharp. e.g.
(add-to-list 'org-babel-load-languages (cons fsharp . t))

Does that help?

@progfolio Thank you very much for this detailed answer, it definitely clarifies many parts of the error I'm facing. I'll test the approach you mentioned in my local setup! 🙌🏼 🚀

You'll need to add ob-fsharp to that list and org-babel-do-load-languages after it has been installed/activated. You should be able to do so in the :config section of your use-package declaration for ob-fsharp. e.g.
(add-to-list 'org-babel-load-languages '(fsharp . t))

Confirming that this configuration worked in my local setup!

Thanks for the help @progfolio, I'm going to close this issue now. Also, related to the recipe, thanks for the clarification!


Add download links to Projects

Fixes #157
Adds new optional storeUrl property to add link to Windows Apps preview store. I choose this one, because it's accesible from every platform.

I also updated the Gemfile, because it didn't build on my environement, but I can undo it if you think I should do it.
cc: @jeffwilcox @emmairwin

I love it, but we do need to think about the accessibility piece. We failed an accessibility review previously where the text was very generic, "Visit project" vs "Visit PowerShell", for example. I think it was something about a screen reading providing the most-specific and helpful content.
So as long as we take that into account, I think that's worth doing.

I love it, but we do need to think about the accessibility piece. We failed an accessibility review previously where the text was very generic, "Visit project" vs "Visit PowerShell", for example. I think it was something about a screen reading providing the most-specific and helpful content.
So as long as we take that into account, I think that's worth doing.

Would a title argument with something like Download "projectname" from Microsoft Store on the link be ok?

Removed changes from lockfile. I first didn't get how it worked

@jeffwilcox I changed the link text:

@jeffwilcox does this address your concern about accessiblity, or is there other guidance to be shared to support this PRs success?

Sounds good, thanks all.


Add Korean translation

Adding .po files for Korean translation.

We should probably find a way to have community help with translation. The other day I stumbled upon crowdin which is a little overkill I think for the current scale but worth checking out. Other than that @dongbum I think having some documentation on how to help contribute with languages would be awesome.


Create and delete point in time for processing an index

Description
Create and delete point in time for an index to process it

Note: The deletePit request does not work when enable_sigv4 is set to true. I have not been able to debug, but it works properly when enable_sigv4 is false. I will create a separate issue to work on this bug in the future.

Issues Resolved
related to #1985
Check List

[x] New functionality includes testing.
[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[x] Commits are signed with a real name per the DCO

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Please comment out the failing tests, if they are failing because of sigv4

Please comment out the failing tests, if they are failing because of sigv4

A couple were failing from an unnecessary mock. I fixed those. No unit tests are failing from sigv4 issues. Manual testing was done to see the issue.


Undefined Control Sequence \begingroup \chapter

) [1{/var/lib/texmf/fonts/map/pdftex/updmap/pdftex.map}] [2] [3] (./bib.tex
! Undefined control sequence.
\\env@litbib@process ...#2-> \begingroup \chapter
                                                  {#1}\par #2 \par \renewcom...
l.61 \end{litbib}

Happens when \documentclass does not define chapter.
Simply replace \chapter with \section in litbib.sty


Add antomor to Contributors list

Hi  @antomor, I'm quite elated about your pull request. I wanna evolve this project to addresses various problems faced by first-time contributors. I'd love to learn about your journey in open source community, the problems, pain points you had etc.
Could you explain how you felt when you went through the tutorial, made a pull request and learned that I merged it?
We’ve recently added social share  to our web app. Could you please go to https://roshanjossey.github.io/first-contributions/#social-share and share your first contribution to open source?
Also, check out projects with easy issues while you’re there.

Hi @Roshanjossey thank you for your tuturoial. It is very easy to be followed, so I haven't any problem during the execution.
Anyway it would be great if the tutorial would have included also some minimal investigation, to let the learner understand what really means find a solution to a problem.
In any case, I am going to look for some project which I can contribute to.
Thank you very much!

I’d urge you to continue contributing to other open source projects.
We also have a slack team to help/mentor people trying to contribute to open source projects.
You can join the team by going to https://goo.gl/PM1Jdh


C++14

Build is here:
https://rsjenkins.iil.intel.com/view/LRS/job/LRS_release_flow_pipeline/4731/
LibCI has less warnings in Linux & Jetson.
Note that only the library internals (anything using concurrency etc.) need 14 -- all the rest (that depend on rs2, top of the hourglass) can stay on 11. I therefore left all the tools & examples on 11. We can adjust later as needed, but should start heeding compiler warnings now.
Note that the solution name changes in this, for the same reason we did the same in the dds branch -- there was a mismatch between the project name (librealsense2) and LRS_TARGET (realsense2). The solution shows realsense2 as the project name under Library. Now everything matches.
I ran the Viewer, seems to be working OK.
But no extensive testing...
Tracked on [LRS-620]

Don't we need to go on each tool/example and note C++14?


[stable/prometheus] Add option for defining strategy for server

We have a usecase of defining deployment strategy as "Recreate" instead of the default "RollingUpdate". Added a section for defining strategy now. Default remains the same as before.
cc @mgoodness

/ok-to-test


#team15-ukvemelana

comment

Please rebase onto the correct branch i.e. team/#16-ukuvumelana so that you are not trying to merge this into master, and then I will merge it.


nfd_operator_deploy_custom_commit: fix build error when 'as' is in lower case

Fixes this nightly failure (OCP 4.8 and 4.9):
2022-04-10 00:53:12,696 p=710 u=psap-ci-runner n=ansible | <stdout> + sed -i 's|FROM registry.ci.openshift.org/ocp/builder:rhel-.*-golang-\(.*\)-openshift-.* AS|FROM docker.io/library/golang:\1 AS|' Dockerfile
2022-04-10 00:53:12,696 p=710 u=psap-ci-runner n=ansible | <stdout> + sed -i '10s|.*|FROM registry.access.redhat.com/ubi8/ubi|' Dockerfile
2022-04-10 00:53:12,696 p=710 u=psap-ci-runner n=ansible | <stdout> + IMAGE_NAME=nfd-operator-ci:latest
2022-04-10 00:53:12,697 p=710 u=psap-ci-runner n=ansible | <stdout> + make image IMAGE_TAG=nfd-operator-ci:latest
2022-04-10 00:53:12,697 p=710 u=psap-ci-runner n=ansible | <stdout> make: go: No such file or directory
2022-04-10 00:53:12,697 p=710 u=psap-ci-runner n=ansible | <stdout> docker build -t nfd-operator-ci:latest \
2022-04-10 00:53:12,697 p=710 u=psap-ci-runner n=ansible | <stdout> 	 \
2022-04-10 00:53:12,697 p=710 u=psap-ci-runner n=ansible | <stdout> 	 ./
2022-04-10 00:53:12,697 p=710 u=psap-ci-runner n=ansible | <stdout> [1/2] STEP 1/4: FROM registry.ci.openshift.org/ocp/builder:rhel-8-golang-1.16-openshift-4.9 AS builder
2022-04-10 00:53:12,697 p=710 u=psap-ci-runner n=ansible | <stdout> Trying to pull registry.ci.openshift.org/ocp/builder:rhel-8-golang-1.16-openshift-4.9...
2022-04-10 00:53:12,697 p=710 u=psap-ci-runner n=ansible | <stdout> [2/2] STEP 1/10: FROM registry.access.redhat.com/ubi8/ubi
2022-04-10 00:53:12,697 p=710 u=psap-ci-runner n=ansible | <stdout> Error: error creating build container: initializing source docker://registry.ci.openshift.org/ocp/builder:rhel-8-golang-1.16-openshift-4.9: reading manifest rhel-8-golang-1.16-openshift-4.9 in registry.ci.openshift.org/ocp/builder: unauthorized: authentication required

caused by the AS directive of the old Dockerfile written in lower case, eg:

master
4.9

/test ?

/test 4.9-test-commit
this ^^^^ should execute the test that failed, by running this command on 4.9:
test-path: prow nfd-operator test_branch

and let's make sure that master/4.10 will works:
/test nfd-operator-e2e-master

test-path: prow nfd-operator test_branch

and nfd-operator-e2e-master
passed, LGTM
/approve

Thank you Kevin, makes sense.
/lgtm


Correct typo

In the Chinese .po file, I came across the following string:
"Welcome to the Sign Search section of the %(langauge)s SignBank. Here\n you can search for a sign using a Dutch translation in the search box\n above, or browse words starting with any letter below.”

Change langauge to language
Then also correct in cn/nl translations

I found a second similar typo by searching for langau :). Both were mistakes in the templates, so I fixed them there; fixes should now be visible on the live website.
I also regenerated the .po for Dutch and Chinese, so potential translators don't have to continue looking at ugly typos while they were fixed on the website already :)

:-)


Containerise gcp-filestore-backups script and add to chartpress specification

fixes https://github.com/2i2c-org/infrastructure/issues/4394

I actually don't think the entrypoint added here is needed. Will remove in a future PR relating to this work.


minor update makefile

ensure go-bindata installed

awesome thanks

Codecov Report

Merging #109 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #109   +/-   ##
=====================================
  Coverage       0%     0%
=====================================
  Files          12     12
  Lines         681    681
=====================================
  Misses        681    681

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7dee858...bcad6a7. Read the comment docs.


在gitbash 和 windows自带的命令行执行 vue init webpack  vue-demo需优化

    在gitbash 和 windows自带的命令行执行 vue init webpack  vue-demo，Vue build和Pick an ESLint preset时选择不准确，例如我想选Airbnb实际结果却无意中选了其他。

It's nothing to do with vue-cli. Maybe you should pose this question on SO.

Are you saying that picking airbnb in eslint config still yields another preset?

@posva yes, windows7 with DOS CLI has problem abount "vue build"，gitbash has more problems during "vue init webpack vue-demo"


Test binaries should dynamically link their dependencies

Current test binaries come out to 50+ MB, because they are statically linking (some? most? all?) their dependencies. We should be dynamically linking where possible to save on incremental build time, disk space used, etc., especially considering our actual Python package dynamically links the same thing (so it's a better test case to link the same way the Python process will).

Reverted PR #984 due to issue #979. Reopening since this is now an issue again.

This is now fixed in master with #1413.


Question: is Edge browser supported?

I have a Win10 Pro (Version 1511 and OS build 10586.494) with Edge browser version 25.10586.00 and EdgeHTML 13.10586. When I try to load  http://www.videogular.com/examples/simplest-videogular-player/ and I got a message saying "This type of video file isn't supported", and http://www.videogular.com/examples/creating-an-audio-player/ doesn't work either.
Does videogular work with Edge browser?

It works on Microsoft Edge, it's just the demo doesn't have a file that works on IE.


Write base docker-compose skeleton

Result
Gorilla-auth we be able to start all containers using docker-compose for production and development
Implantation
Write docker file for server
Write docker-compose file
Comments
Reference other implantation that were discussed previously.

Completed with Docker Skeleton


PATCH baseUnitOfMeasure on Item

When I try to patch item with different baseMeasure it doesn't work.
With doesn't work I mean I sent BaseUnitOfMeasureId with the patch.
For example I patch with the following payload
PATCH
https://api.businesscentral.dynamics.com/v1.0/api/v1.0/companies(<redacted>)/items(<redacted>)

{"baseUnitOfMeasureId":"32c97035-91a7-4e3a-b845-9b30c7d488b5","number":"GA400028","displayName":"Displayname  Hulst","type":"0","blocked":false,"gtin":"8888847598151","unitPrice":54.95,"priceIncludesTax":true,"itemCategoryId":"<ItemCategoryID"}

I get a 200 OK with the following payload back, BaseMeasureOfUnit isn't changed, it returns the old GUID. Am I missing something in the Payload?
{
<EMAIL_ADDRESS>"https://api.businesscentral.dynamics.com/v1.0/api/v1.0/$metadata#companies()/items/$entity",
<EMAIL_ADDRESS>"W/"J"",
"id": "",
"number": "GA400028",
"displayName": "DisplayName",
"type": "Inventory",
"itemCategoryId": "5fba219d-c16e-4520-b75e-7cf9fd82d1ff",
"itemCategoryCode": "286",
"blocked": false,
"baseUnitOfMeasureId": "532f9d10-4d1e-4cea-a3f2-b58e5edf29bd",
"gtin": "8718247598151",
"inventory": 0,
"unitPrice": 54.95,
"priceIncludesTax": true,
"unitCost": 0,
"taxGroupId": "00000000-0000-0000-0000-000000000000",
"taxGroupCode": "",
"lastModifiedDateTime": "2019-07-17T12:28:02.33Z",
"baseUnitOfMeasure": {
"code": "ST",
"displayName": "Stuks",
"symbol": null,
"unitConversion": null
}
}

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d4928f81-a6fd-b80b-de8d-cd8e3e170c3d
Version Independent ID: 120c6f3e-88cd-2037-e84d-f6e5588c53b2
Content: Update items - Dynamics NAV
Content Source: dynamics-nav/api-reference/v1.0/api/dynamics_item_update.md
Service: dynamics365-financials
GitHub Login: @SusanneWindfeldPedersen
Microsoft Alias: solsen

Any update?

Hello, sorry for the long wait. I hope you found a solution. This is more of a product question, that we're not able to help with, please use your usual support channel. Thanks for your understanding.


No icon for workspaces in polybar i3 module, wrong ws name %name% for unfocused and wrong ws order

Hi!
First, great job with your themes for i3, it's really nice !
I have issues with i3 module of polybar (see details in the title).
Here is a screenshot.

Thanks for your support!

Can post a screenshot of the terminal output when running polybar.  I'm running this i3 it's amazing @szorfein makes awesome themes.
What app or program are you trying to run.
This is what he told me.
open a terminal in each workspaces to see the name in polybar, my config of polybar only display workspace occupied.
Make sure you have these fonts installed.
1. $ wget https://aur.archlinux.org/cgit/aur.git/snapshot/nerd-fonts-noto-sans-regular-complete.tar.gz
2. $ tar xvf nerd-fonts-noto-sans-regular-complete.tar.gz
3. $ cd nerd-fonts-noto-sans-regular-complete
4. $ makepkg -si

1. $ wget https://aur.archlinux.org/cgit/aur.git/snapshot/ttf-material-icons-git.tar.gz
2. $ tar xvf ttf-material-icons-git.tar.gz
3. $ cd ttf-material-icons-git
4. $ makepkg -si

hi,  i read the i3 config, can you edit the file ~/.config/polybar/i3-name and change the line:
8 label-visible = "%icon% %name"

by this:
8 label-visible = %icon% %name%"

and restart i3 to see if it change something

glad your back @szorfein  :D

Hi!
Sorry for the late answer. The icons are working now that I've installed the fonts package.
I still have an issue with the non-focused/visible workspaces, but it must be due to the fact that I'm using an extended desktop, right?

Nice.

but it must be due to the fact that I'm using an extended desktop, right?
Yep possible, unfortunately, i can't test this, you can see this issue to configure polybar with multiple screen.

Also, don't hesitate to see the doc at https://github.com/polybar/polybar/wiki/Module:-i3 , you can configure this theme with your need.
They are the option index-sort = true for i3 who can be interesting for u :)


[WIP] bazel: Shift ASAN flags to .bazelrc

This is a first step towards removing bazel/setup_clang.sh - it just removes the flags that have no reason to be there

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

/retest

/retest


Initialize cache in our recipes before compile

In the full_finetune_distributed (https://github.com/pytorch/torchtune/blob/d31649e75e51cf15dbdca004288c32550e8f7f8d/recipes/full_finetune_distributed.py#L428C32-L428C41), we call init_cache before training starts. I imagine that we should do it in all of our recipes. @ebsmothers , can you confirm?
cc: @joecummings

Oh you mean rope_init? I need to check but I believe it only needs to be explicitly called when we init the model on meta device. So in the distributed recipes we need to do it after sharding the model, but for single-device recipes where we init directly on the GPU it should be taken care of already by the RoPE module's init.

but for single-device recipes where we init directly on the GPU it should be taken care of already by the RoPE module's init.

We call init only in the forward. So I imagine that this is not super compile friendly? I can test it and check compile time


Enable GroundPrimitives to render without the fragment depth extension.

Fixes #4899.

Because we can't write depth to clamp fragments to the far plane, there is an artifact when any of the far planes of the multi-frustum intersect terrain and the volume.

Update CHANGES.md (for 1.31, not 1.30) and the reference doc.

@pjcozzi Updated.

This is awesome!  Extremely preferable to what we had before.  Hopefully users will think so too. While there are definitely some artifacts, they are way less common than I thought and I think will not even be a problem in most casas.
@pjcozzi approved this for merge offline and it will have a whole month to stew in master if there are unforeseen problems


Opening secret entry freezes up vscode

I have some secrets with entries containing configuration files up to 100 lines.
Opening them through the browser, only 10 to 30 lines were displayed.
Trying to create an example to reproduce the problem, vscode is actually freezing up.
Extension version: 1.0.1
How to reproduce:

Create secret with big entry

wget https://github.com/prometheus/prometheus/blob/master/documentation/examples/prometheus-kubernetes.yml
kubectl create secret generic test-prometheus-config --from-file prometheus-kubernetes.yml

Open the entry prometheus-kubernetes.yml from the sidebar

Expected outcome: Contents are displayed
Actual outcome: vscode freezes up

I'll try to reproduce this...


Update to Go 1.9.2

Since there was security updates in Go, we will issue a new release.
We have decided also to ship executables and Docker images with
the latest Go release.

Coverage decreased (-0.2%) to 91.711% when pulling 9305d1814b8d27b0b528b6bbeae235ae9b6fdc2a on prepare_next_release into c19527c03f2dac7c7433880c020eca3bcf676df5 on master.

Go 1.9.2 was released today, so will update this PR...

Coverage increased (+0.05%) to 91.992% when pulling 82b4bb8a43bfd448f4b8337e187a67bf3cc36811 on prepare_next_release into c19527c03f2dac7c7433880c020eca3bcf676df5 on master.

Coverage increased (+0.08%) to 92.024% when pulling 9bf4f7bb6a1e4d0efd3b103a8e98124b8eb805b9 on prepare_next_release into c19527c03f2dac7c7433880c020eca3bcf676df5 on master.


Neopixel demo

A basic demo of Web + Arduino control of an Adafruit Neopixel feather shield

A few screenshots of the demo.

looks pretty slick, I like the web preview.

Maybe you can rename the -web subfolder to just www or  web and add intruction to deploy the site with https://www.firebase.com/docs/hosting/quickstart.html
Maybe also add a README with the same description than this pull request.

Just some nits, but LGTM.

LGTM


Use ref asms in more places

These look like good places to use ref assemblies if present--but we need to track down owners for the various tools here and confirm that they're correct.
@jcouv

Updated with a fix for #2165 and removal of the UpToDateCheckInputs items (which should be an extremely minor perf boost).

Per conversation with @AndyGerlicher, we're going to postpone the non-GenerateResources part of this fix until we can confirm that using ref assemblies is correct with tool owners.
The risks are that if it's wrong, we might break all consumers of the winmdexp and lc targets. If we continue with the current state, reference assemblies are less effective in some scenarios. That seems like a good tradeoff at this stage of 15.3.

Makes sense. Let's keep an open issue?

@jcouv Already had the commit so I just opened #2181 to take the changes that I noticed when inspecting common.targets.


Issue 491: Removal of errant concept owl:ontologyIRI

This Pull Request resolves all requirements of Issue #491 .
Coordination

[x] Pull Request is against correct branch
[x] Pull Request is in, or reverted to, Draft status before Solutions Approval vote has passed.
[x] CI passes in UCO feature branch
[x] CI passes in UCO current unstable branch (9857f65)
[x] CI passes in CASE current unstable branch tracking UCO's unstable as submodule (3ac5480)
[x] Impact on SHACL validation reviewed for CASE-Examples
[x] Impact on SHACL validation remediated for CASE-Examples (N/A)
[x] Impact on SHACL validation reviewed for casework.github.io
[x] Impact on SHACL validation remediated for casework.github.io (N/A)
[x] Milestone linked
[x] Solutions Approval vote logged on corresponding Issue (once logged, can be taken out of Draft PR status)

The reviewer(s) should double-check the log message and changed lines in 35753f7.
Otherwise, once CI passes, I'm fine with this merging.


dockerRegistryMap has field enum instead of _enum

Describe the bug
The variable dockstoreRegistryMap from register-tool.service.ts should be type of Array which has a field called '_enum'. However, swagger returns the field 'enum' instead from the endpoint '/metadata/dockerRegistryList'.
Expected behavior
Swagger should be returning the field '_enum' instead of 'enum' since dockstoreRegistryMap is of type Array from line 71 of register-tool.service.ts
Screenshots

┆Issue is synchronized with this Jira Bug
┆Fix Versions: Dockstore 1.11
┆Issue Number: DOCK-1469
┆Sprint: Backlog
┆Issue Type: Bug

This is probably intentional since enum is a keyword. https://www.typescriptlang.org/docs/handbook/enums.html

I think there's still an issue here. The generated Swagger client code doesn't take the enum field from the response and put it into the _enum field of the object; _enum ends up as undefined. And since you can only refer to _enum from the Typescript code, the value is not accessible.
This is why we don't have type specified here; we treat it as any and access enum directly.
Andy ran into this in his efforts to get rid of any.

Ok, sounds like a swagger issue. Might be worth bumping the swagger generation code on the UI side and/or seeing what configuration options are. But I'd argue that in the narrow, we should not do  Swagger should be returning the field '_enum' instead of 'enum' since dockstoreRegistryMap is of type Array from line 71 of register-tool.service.ts


I have a question about grpc

Please forgive me for asking questions here, because I cannot find other places to ask questions
My question:
I know that kong can add grpc microservices,
Therefore, Kong can convert http into rpc and pass it to microservices.
However, my microservice returns rpc,
How does kong pass the rpc returned by the microservice to the http client?
Drawing:
Request:
HTTP Client    ==(http)==>     Kong     ==(rpc)==>     Grpc Microservices
Response:
Grpc Microservices    ==(rpc)==>     Kong     == ??( I do not know what to do, kong support??  )??==>     HTTP Client

hi @AP0rPi7uQ9
Yes, Kong can bridge between HTTP and gRPC systems, but to do that you have to specify exactly how to translate.  Remember that gRPC is a procedure call protocol and HTTP is a data transfer protocol.  Even if you use REST to manage services, you'll find that most REST "gurus" will emphatically tell that "REST is not RPC"
So, in order to interoperate, you need a full description of the protocol and API on both sides.  For gPRC, you need the ".proto" file that describes the structures and methods of your services.   For the HTTP side there's a lot more variation.  We have two main solutions:

Encapsulate the gRPC protocol inside HTTP requests.  That's how gRPC-Web works to allow Javascript browser apps to access gRPC services.   Take a look at the gRPC-Web plugin.  You'll proabably need the JS gRPC-Web library.

Add "annotations" to the ".proto" file to describe REST-like URLs for each gRPC method.  This approach is used by Google, and we support it via the gRPC-gateway plugin

thank you very much! You made me understand kong better


After invoke contract, there are some difference in api eth_getTransactionByHash and eth_getTransctionReceipt.

Describe the bug
After invoke contract, there are some difference in api eth_getTransactionByHash and eth_getTransctionReceipt.
To Reproduce
The nonce of eth_getTransactionByHash is 0x0, the transactionIndex is 0x0; in ethereum, the nonce is 0x02, the transactionIndex is 0x00.
The logs of eth_getTransactionReceipt is null, the logsBloom is AA...; in ethereum, the logs is [ ], the logsBloom is 0x00...

eth_getTransactionByHash

{
    "jsonrpc": "2.0",
    "id": 1,
    "result": {
        "blockHash": "0xa96da9fe7c7aff95a5661e3a173c1bf9a1de94afd59a34b3d7afa2c293081e6c",
        "blockNumber": "0x94",
        "from": "0xa94f5374fce5edbc8e2a8697c15331677e6ebf0b",
        "gas": "0x6412333",
        "gasPrice": "0x1",
        "hash": "0xf0e2075863239ad9ef0baddf9e7b0c737fa5cd1d99191704091fd2da408a1503",
        "input": "0xa413686200000000000000000000000000000000000000000000000000000000000000200000000000000000000000000000000000000000000000000000000000000000",
        "nonce": "0x0",
        "to": "0x6295ee1b4f6dd65047762f924ecd367c17eabf8f",
        "transactionIndex": "0x0",
        "value": "0x0",
        "v": "0x1c",
        "r": "0x10ed862bdd2566557ad39191bfa95128396d24c47d19e8f757fd0d47e5327bdb",
        "s": "0x161f6548503f505e08a8f8c7544a07208e700f4c1a3fd74a4e60f1b1e885f2ca"
    }
}

eth_getTransactionReceipt

{
    "jsonrpc": "2.0",
    "id": 1,
    "result": {
        "blockHash": "0xa96da9fe7c7aff95a5661e3a173c1bf9a1de94afd59a34b3d7afa2c293081e6c",
        "blockNumber": "0x94",
        "transactionHash": "0xf0e2075863239ad9ef0baddf9e7b0c737fa5cd1d99191704091fd2da408a1503",
        "transactionIndex": "0x0",
        "from": "0xa94f5374fce5edbc8e2a8697c15331677e6ebf0b",
        "to": "0x6295ee1b4f6dd65047762f924ecd367c17eabf8f",
        "root": "bH14Z/hKL7UwTngJt1RCr+c4uZ69Ybd9FmRNnrBjYmw=",
        "status": "0x1",
        "gasUsed": "0x2a3c",
        "cumulativeGasUsed": "0x2a3c",
        "logsBloom": "AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA==",
        "logs": null,
        "contractAddress": "0x0000000000000000000000000000000000000000"
    }
}

But in ethereum:

eth_getTransactionByHash

{
    "id": 1,
    "jsonrpc": "2.0",
    "result": {
        "hash": "0x251744a12505f22f15f6768014850fb4a2a638ecbde74f7e4772e9f5746c1584",
        "nonce": "0x02",
        "blockHash": "0xaf0abff91f3051602d221afa0cd83791570e44339ad17d9a44e576f05fadb01d",
        "blockNumber": "0x03",
        "transactionIndex": "0x00",
        "from": "0xda3ace329e94a9f726769dd06d86553b3293d9db",
        "to": "0x79a89c17bd24d8c5b8ee3fff70091cf416089b52",
        "value": "0x0",
        "gas": "0x7f29",
        "gasPrice": "0x01e240",
        "input": "0xa413686200000000000000000000000000000000000000000000000000000000000000200000000000000000000000000000000000000000000000000000000000000000"
    }
}

eth_getTransactionReceipt

{
    "id": 1,
    "jsonrpc": "2.0",
    "result": {
        "transactionHash": "0x251744a12505f22f15f6768014850fb4a2a638ecbde74f7e4772e9f5746c1584",
        "transactionIndex": "0x0",
        "blockHash": "0xaf0abff91f3051602d221afa0cd83791570e44339ad17d9a44e576f05fadb01d",
        "blockNumber": "0x3",
        "gasUsed": "0x6b68",
        "cumulativeGasUsed": "0x6b68",
        "contractAddress": null,
        "logs": [],
        "status": "0x1",
        "logsBloom": "0x00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000"
    }
}

logs and logsBloom have fixed


nvcc.exe console popping up while running cupy code which have been cythonized

Description
I have a python code that uses cupy. This code is being cythonized and built during deployment. After that while running the deployed code whenever cupy needs to compile .cu files (and make use of nvvc.exe), nvvc.exe keep opening and closing in a console on it's own. This is an undesired behavior for a desktop application with an user interface.
To Reproduce
It is difficult to reproduce since I do not know which cupy functions needs just-in-time compilation of cu files. If you know a function, I can make a small python package, which will be cythonized so we have an example.
Installation
Wheel (pip install cupy-***)
Environment
OS                           : Windows-10-10.0.19045-SP0
Python Version               : 3.8.10
CuPy Version                 : 12.3.0
CuPy Platform                : NVIDIA CUDA
NumPy Version                : 1.24.4
SciPy Version                : 1.10.1
Cython Build Version         : 0.29.36
Cython Runtime Version       : 0.29.23
CUDA Root                    : C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v11.6
nvcc PATH                    : C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v11.6\bin\nvcc.EXE
CUDA Build Version           : 11080
CUDA Driver Version          : 11080
CUDA Runtime Version         : 11060
cuBLAS Version               : (available)
cuFFT Version                : 10600
cuRAND Version               : 10209
cuSOLVER Version             : (11, 3, 2)
cuSPARSE Version             : (available)
NVRTC Version                : (11, 6)
Thrust Version               : 101501
CUB Build Version            : 101501
Jitify Build Version         : 4a37de0
cuDNN Build Version          : (not loaded; try `import cupy.cuda.cudnn` first)
cuDNN Version                : (not loaded; try `import cupy.cuda.cudnn` first)
NCCL Build Version           : None
NCCL Runtime Version         : None
cuTENSOR Version             : None
cuSPARSELt Build Version     : None
Device 0 Name                : NVIDIA T500
Device 0 Compute Capability  : 75
Device 0 PCI Bus ID          : 0000:01:00.0

Additional Information
To solve this problem I have added the argument creationflags=subprocess.CREATE_NO_WINDOW in the subprocess.check_output function in "\cupy\cuda\compiler.py" (https://github.com/cupy/cupy/blob/dd37c98701e57d305ab6f1794201dceb91010f53/cupy/cuda/compiler.py#L62).
Since then, the console nvcc.exe does not pop up anymore. Can someone verify this?

Note here: for cupy versions < 9.6.0 and cuda toolkit < 11.0 I did not face the problem with the nvcc.exe console...

If you want to avoid to the maximal extent the invocation of nvcc on Windows, I suggest you to update your Python to at least 3.9 (you're using 3.8) and CuPy to at least v13.0.0 (you're using v12.3.0). This issue is a duplicate of #8380 and has been resolved.
However, normally nvcc should not open a new console.. something is still odd on your system 😅

Ok - I will try python 3.9 and cupy >= v13 and give a report of this issue. Thank you for the feedback.

I have installed python 3.9 with cupy v13.2.0. The cythonized code works without the nvcc.exe console popping up.
v13 works like a charm and we see performance improvements - a really great job by the cupy developers. big thanks!
This nvcc.exe issue exists for cupy versions v10, v11, v12 and it was the reason for us to stay at v9.
I guess I can close the PR #8432 because it is resolved since v13?

Thanks for giving it a try and sharing your feedback, @monzelr! Glad to know it works better now.

I guess I can close the PR #8432 because it is resolved since v13?

I'd suggest to wait for the CuPy team for final decision. Maybe @kmaehashi can make a call. Strictly speaking It's not really "resolved" in v13, just that the chance of having to call nvcc is significantly reduced for many use cases, but if nvcc is called (saying using RawKernel or RawModule with backend="nvcc") you should still see a console popping out without your change. Feel free to give it a shot and confirm it's the case 🙂

It's nice to have! Let's proceed to merge 😃

Closed by #8432.


Tutorial for LOJ-1056: Olympics

This problem is missing tutorial. I would like to be assigned to this problem. I think I can finish the editorial in about 2 weeks.
problem link: Olympics

@sakib3201 Hello dear, you have been assigned.


Revert "[SPARK-35746][UI] Fix taskid in the stage page task event tim…

What changes were proposed in this pull request?
This reverts commit 450b415028c3b00f3a002126cd11318d3932e28f.
Why are the changes needed?
In #32888, @shahidki31 change taskInfo.index to taskInfo.taskId. However, we generally use index.attempt or taskId to distinguish tasks within a stage, not taskId.attempt.
Thus #32888 was a wrong fix issue, we should revert it.
Does this PR introduce any user-facing change?
no
How was this patch tested?
origin test suites

Sure, I can create a new JIRA and PR for this.


Bf16

Currently working with everything but partitioning checkpointed activations + pipeline parallel - but those fixes will be in deepspeed anyway, so imo this should mostly be ready to merge.

gets bf16 working for data parallel + model parallel training
adds new layernorm from https://github.com/NVIDIA/Megatron-LM that works with bf16
adds bf16 support for fused attention kernels

All nccl communication for bf16 now happens in fp32. So it's a little slower if you're communication bound. Untested with zero optimizer as of right now.
Will need to install https://github.com/EleutherAI/DeeperSpeed/tree/bf16 for it to work, currently.
TODO:

[ ] merge deeperspeed bf16 branch to main
[ ] test with zero optimizer
[ ] get partition activations working

Update: It doesn't work with zero :laughing:

Ok, now working for zero 1 + 2.

aaand now pipeline parallel + activation checkpointing too!
Aside from Zero 3, everything works. I'll wait till we have zero 3 working in our codebase to take a look at that anyway, since i suspect it will be a fair bit of work.


update ros launch files and nodes for update of rotors_simulator

this also removes the duplicated joy node.
rotors_simulator PR: https://github.com/PX4/euroc_simulator/pull/9
mav_comm PR: https://github.com/PX4/mav_comm/pull/1
supersedes #1852  (is the same but against master)

@AndreasAntener a test would be very much appreciated

I can wait #1847 on this if it makes sense to respect the new NS arg for the mavros include too. I'm not so sure anymore if mavros has to be in root necessarily. Could there be multiple mavros nodes?

Actually I did not update mavros_sitl.launch because of #1847. Well yes there could be multiple mavros nodes. One for each onboard computers (e.g. if you simulate multiple on one system). If me move it to ardrone/mavros (instead of /mavros or /px4_multicopter/mavros) this scenario becomes feasible.

@AndreasAntener @thomasgubler Can this go in now?

@AndreasAntener could you have a quick look here? I updated the namespaces and some parameters. If I run the tests locally on my machine I get a 'Success'

I should have time tonight to have a look. I already tried to change all the launch files and scripts this week, but I'm running in the same issue as SITL CI currently has (that's why I haven't sent you a PR for it..).
Should I also do a test with
rotors_simulator PR: PX4/euroc_simulator#9
mav_comm PR: PX4/mav_comm#1
?

Should I also do a test with
rotors_simulator PR: PX4/euroc_simulator#9
mav_comm PR: PX4/mav_comm#1

ah of course that's the problem: CI is not using these branches which are required. As soon as the simulator is open source we need submodules to get the dependencies under control. Or we could even do one now: a new repo px4ros with the submodules: Firmware, rotors-simulator, mav-comm, ...

A new repo might make sense. For CI anyway. I believe catkin cannot resolve nested packages. So submodules might make things difficult there.

the rotors_simulator is nested as well. The question is if more than one
level is supported.
On Sun, Mar 8, 2015 at 4:50 PM, Andreas Daniel Antener <
<EMAIL_ADDRESS>wrote:

A new repo might make sense. For CI anyway. I believe catkin cannot
resolve nested packages. So submodules might make things difficult there.
—
Reply to this email directly or view it on GitHub
https://github.com/PX4/Firmware/pull/1853#issuecomment-77756830.

euroc has multiple adjacent packages, but not nested ones. Nested would mean that the top-level folder has CMakeLists.txt and package.xml too

@AndreasAntener ok yes nested as in packages does not work:
http://wiki.ros.org/ROS/Tutorials/catkin/CreatingPackage#What_makes_up_a_catkin_Package.3F
@LorenzMeier, we might need to reconsider the :umbrella: repository solution. Still I don't know if multiple levels of directory nesting will work (I guess so...)

I just tested the umbrella repository approach to make sure the setup with multiple nested directories works. (It does)
This was the layout:

px4ros :umbrella:

Firmware
euroc_simulator

rotors_control
rotors_...
...

mav_comm
catkin_simple
glog_catkin

mavros
...

@AndreasAntener this PR is waiting for your ok to merge

:+1: works for me! I was only wondering about maybe adding default namespace for the mavros include.
If you do an umbrella project, "containers" should also be in there (for CI)

thanks for the test!
rebased, merging


Threat found on version 3.0.5553

Brief description of your issue
I downloaded nightly version 3.0.5553 today, but Kaspersky detected thread when extracted from the archive.
To confirm that Kaspersky is not reporting false alert, I searched using archive sha2 value in TotalVirus, similar issue was reported.
48C869FF4CCEA0EA0D4E9A23E5BFBBA640B5F092BD69E779F320262BCCE0A491
I didn't test the setup file.
Is something wrong here, or Kaspersky and TotalVirus reporting false alert?
Steps to reproduce (optional)
No response
Expected behavior (optional)
No response
Actual behavior (optional)
No response
Environment (optional)
Nightly version 3.0.5553
Windows 10, Kaspersky Total security 21

False positives.


Some remote peers remain connected even after calling close on TcpDuplexConnection

Expected Behavior
Remote peer is disconnected when calling this.socket.end() in TcpDuplexConnection.close().
Actual Behavior
Some remote peers (clients) do not respect the end() call and are able to still transmit data to the server, which results in NPEs and other undefined behavior.
This behavior was experienced from a .Net TCP Client in Unity RSocket.
Steps to Reproduce
Not available.
Possible Solution
TcpDuplexConnection may need to additionally, or in lieu of end(), call destroy() on this.socket when close is called.
Your Environment

RSocket version(s) used: 1.0.0-alpha.1
Other relevant libraries versions (eg. netty, ...): n/a
Platform (eg. JVM version (javar -version) or Node version (node --version)): node: v16.13.1
OS and version (eg uname -a): n/a

@viglucci I believe WebsocketDuplexConnection has the same issue. Connection can not be closed from client side manually by calling rsocket.close(),  session still exist on server side (resume feature is enabled).
Environment
## client side (Frontend):
rsocket-js: 1.0.0-alpha.1
react js: 18

## server side:
spring-boot-starter-rsocket: 3.0.0-M3

var transport = new WebsocketClientTransport({
    debug: true,
    url: serverUrl,
    wsCreator: (url) => {
        var ws = new WebSocket(url)
        ws.onopen = (ev) => {
            console.log("WebSocket onopen");
        }
        ws.onmessage = (ev) => {
            console.log("WebSocket onmessage");
        }
        ws.onclose = (ev) => {
            console.log("WebSocket onclose");
        }
        ws.onerror = (ev) => {
            console.log("WebSocket onerror");
        }
        return ws
    },
})

web browser console log output and server side log looks like below when call rsocket.close():
WebSocket onclose
WebSocket onopen
WebSocket onmessage

13:22:10.819 [default] [reactor-http-epoll-2] DEBUG i.r.r.InMemoryResumableFramesStore - Side[server]|Session[1]. Paused at position[0]
13:22:10.819 [default] [reactor-http-epoll-2] DEBUG i.r.r.InMemoryResumableFramesStore - Side[server]|Session[1]. Disconnected at Position[0] and ImpliedPosition[0]
13:22:10.820 [default] [reactor-http-epoll-2] DEBUG i.r.resume.ResumableDuplexConnection - Side[server]|Session[1]|DuplexConnection[1]. Disconnected
13:22:10.820 [default] [reactor-http-epoll-2] DEBUG i.r.resume.ServerRSocketSession - Side[server]|Session[1]. Connection is lost. Trying to timeout the active session
13:22:16.558 [default] [reactor-http-epoll-3] DEBUG io.rsocket.FrameLogger - receiving ->
Frame => Stream ID: 0 Type: RESUME Flags: 0b0 Length: 29
Data:

13:22:16.558 [default] [reactor-http-epoll-3] DEBUG i.r.resume.ServerRSocketSession - Side[server]|Session[1]. New DuplexConnection received.
13:22:16.559 [default] [reactor-http-epoll-3] DEBUG i.r.resume.ServerRSocketSession - Side[server]|Session[1]. Resume FRAME received. ServerResumeState[impliedPosition[0], position[0]]. ClientResumeState[remoteImpliedPosition[310], remotePosition[0]]
13:22:16.559 [default] [reactor-http-epoll-3] DEBUG i.r.r.InMemoryResumableFramesStore - Side[server]|Session[1]. Removed frames from cache to position[310]. CacheSize[0]
13:22:16.559 [default] [reactor-http-epoll-3] DEBUG io.rsocket.FrameLogger - sending ->
Frame => Stream ID: 0 Type: RESUME_OK Flags: 0b0 Length: 14
Data:

13:22:16.559 [default] [reactor-http-epoll-3] DEBUG i.r.resume.ServerRSocketSession - Side[server]|Session[1]. ResumeOKFrame[impliedPosition[0]] has been sent
13:22:16.559 [default] [reactor-http-epoll-3] DEBUG i.r.resume.ServerRSocketSession - Side[server]|Session[1]. Session has been resumed successfully
13:22:16.559 [default] [reactor-http-epoll-3] DEBUG i.r.resume.ResumableDuplexConnection - Side[server]|Session[1]|DuplexConnection[2]. Connecting
13:22:16.559 [default] [reactor-http-epoll-3] DEBUG i.r.r.InMemoryResumableFramesStore - Side[server]|Session[1]. Resumed at position[0]
13:22:16.559 [default] [reactor-http-epoll-3] DEBUG i.r.r.InMemoryResumableFramesStore - Side[server]|Session[1]. Connected at Position[310] and ImpliedPosition[0]
13:23:16.560 [default] [parallel-8] DEBUG io.rsocket.FrameLogger - sending ->
Frame => Stream ID: 0 Type: KEEPALIVE Flags: 0b10000000 Length: 14
Data:

13:23:16.610 [default] [reactor-http-epoll-3] DEBUG io.rsocket.FrameLogger - receiving ->
Frame => Stream ID: 0 Type: KEEPALIVE Flags: 0b0 Length: 14
Data:


⚠ ClamAV has degraded performance

In fd9e023, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 68 ms

Resolved: ClamAV performance has improved in 9b9785e after 5 minutes.


[MNT] simplify test CI and remove conda

Simplifies test CI matrix and removes conda.

Codecov Report
All modified lines are covered by tests :white_check_mark:

Comparison is base (b8b483e) 83.60% compared to head (cca92b1) 83.57%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #224      +/-   ##
==========================================
- Coverage   83.60%   83.57%   -0.04%
==========================================
  Files          43       43
  Lines        2843     2843
==========================================
- Hits         2377     2376       -1
- Misses        466      467       +1

see 1 file with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


EPIC-00: Setup Development & Test Environment

Tasks:

Setup Eclipse Velocitas tooling
Setup Eclipse Leda environment onhardware platform

Teck Stack:

Container.d
Eclipse Kanto
VS Code
Yocto

#1


Add a removeRobot method to World

This pull request aims to add a removeRobot method to remove a given robot from the world, as this would be a nice feature for the upcoming H02 exercise.
Issue #39 should be properly addressed, though it should be noted that robotCount is currently unused, so it might not be needed.
There are also some minor javadoc improvements.
Robots that have been removed from the world can still be accessed and, for example, moved, this can lead to crashes. How to deal with this is up for discussion as I am unsure what the ideal solution for this is.

Robots that have been removed from the world can still be accessed and, for example, moved, this can lead to crashes.
I think robot.turnOff() should do

Superseeded by #65


NextPath is broken on Postgres

Description
https://discourse.cayley.io/t/path-save-lost-some-data-when-using-sql-backends/1192
Steps to reproduce the issue:

Initialize a clean PG instance
Load test data
Execute the query:

g.V("<dani>", "<bob>").Save("<follows>", "target").All()

Received results:
{"id":"bob","target":"fred"}
{"id":"dani","target":"greg"}

Expected results:
{"id":"bob","target":"fred"}
{"id":"dani","target":"bob"}
{"id":"dani","target":"greg"}

Environment details:
Backend database: postgres

Related to a new optimizer that flattens NodesFrom. Because of this, NextPath stops working - it's not implemented for the base Select iterator.


fix(ui): nodes table display issues

Fixes #766

Pull Request Test Coverage Report for Build 610164577

0 of 35 (0.0%)  changed or added relevant lines in 2 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.005%) to 18.803%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/store/mutations.js
0
7
0.0%

src/components/nodes-table/nodes-table.js
0
28
0.0%

Files with Coverage Reduction
New Missed Lines
%

src/components/nodes-table/nodes-table.js
1
0%

Totals

Change from base Build 610163793:
0.005%

Covered Lines:
2004

Relevant Lines:
10939

💛  - Coveralls


left align

Hi, I'm wondering how you perform left align to normalize the vcf files, GATK or bcftools.
For example, in GATK, there are two options to split and trim.
--splitMultiallelics / -split
Split multiallelic records and left-align individual alleles
If this argument is set, split multiallelic records and left-align individual alleles. If this argument is not set, multiallelic records are not attempted to left-align and will be copied as is.
--trimAlleles / -trim
Trim alleles to remove bases common to all of them
If this argument is set, bases common to all alleles will be removed, leaving only their minimal representation.
Thank you very much!
Best

Thanks for the question. We use vt normalize to normalize and left align calls:
http://genome.sph.umich.edu/wiki/Variant_Normalization
http://genome.sph.umich.edu/wiki/Vt#Normalization
Some callers, like GATK HaplotypeCallers do this internally as part of the process but we apply it for those that don't. Hope this helps.

Thanks!
On Thu, Oct 22, 2015 at 1:35 PM, Brad Chapman<EMAIL_ADDRESS>wrote:

Thanks for the question. We use vt normalize to normalize and left align
calls:
http://genome.sph.umich.edu/wiki/Variant_Normalization
http://genome.sph.umich.edu/wiki/Vt#Normalization
Some callers, like GATK HaplotypeCallers do this internally as part of the
process but we apply it for those that don't. Hope this helps.
—
Reply to this email directly or view it on GitHub
https://github.com/chapmanb/bcbio-nextgen/issues/1072#issuecomment-150332318
.

--
Junfei Zhu