PHP 8.0 | PHP/NoSilencedErrors: review function list

PHP 8 changes the behaviour of the error silence operator @ : where previously it would silence all notices, warnings and errors, it will now only silence notices and warnings, but will not prevent fatal errors/catchable exceptions anymore.
PHP 8 also contains another relevant change, which is that the error level for a number of notices/warnings has been elevated to fatal error/catchable exception.
It would be very helpful if someone would review if any of the functions in the $function_whitelist are affected by these changes and need to be removed from the list.
Note: yes, the name of the property should also be changed, but there's a separate open ticket for that.
This was also discussed in the #core-php Slack channel: https://wordpress.slack.com/archives/C60K3MP2Q/p1611678080004700

Hi @jrfnl 👋🏽 .
I have started investigating this issue by setting up a test environment and reviewing the relevant code, particularly the $allowedFunctionsList in NoSilencedErrorsSniff.php.
I notice that in the following file NoSilencedErrorsUnitTest.inc, there are tests for a few I/O functions, e.g. file_get_contents, file_exists. Am I understanding it correctly that the goal is to add the missing functions of the $allowedFunctionsList array to this file, and compare their behaviour when executing under php7 and php8, and note any differences?

Hi @d-alleyne Lovely to hear that you are looking into this.

Am I understanding it correctly that the goal is to add the missing functions of the $allowedFunctionsList array to this file, and compare their behaviour when executing under php7 and php8, and note any differences?

No, the goal is not to add functions to the list, but to remove them (where relevant).
As things were in PHP 5/7, a number of functions existed in PHP where no amount of error checking ahead of running the function would prevent a PHP notice/warning.
Those functions are the functions listed in the $allowedFunctionsList, as for those, it could be justified that the silence @ operator was being used.
However, as of PHP 8.0, a number of PHP notices/warnings have been elevated to fatal errors and/or catchable exceptions.
If this has happened to the notice/warning for a function listed in the $allowedFunctionsList, the silence operator is now useless (when running code on PHP 8.0 or higher) and should not be used anymore.
Depending on the specific PHP 8.0 change affecting the function, the function call should be wrapped in a try-catch` or handled in a different way.
So basically, all functions in that list need to be checked to see if they are affected by the higher error levels and if so, they should likely be removed from the list to prevent giving people a false sense of security "oh, I've silenced the warning", when the code on which the silence operator is being used will no longer have a silenced notice on PHP 8.0+.
Does that make it clearer ?

P.s.: as you mentioned setting up a test environment... in case you are not aware, http://3v4l.org/ with the "+ include eol" option selected in the dropdown is an awesome way to test this kind of behavioral change across different PHP versions.

@jrfnl Do you mean something like this, but documented for all functions in $allowedFunctionsList?

@d-alleyne Not sure what you were trying to demonstrate with the code sample - here is a simplified version which shows the behaviour has not changed for that function: https://3v4l.org/l3jFs#veol

@jrfnl My plan is to run these functions in both on PHP7 and PHP8, and document any differences, if any. In our existing example, it'd look like this.
e.g.

Function
PHP7
PHP8

chdir
Same Behaviour
Same Behaviour

@d-alleyne Sounds good. To document, I'm not sure the PHP 7/8 columns are needed as the code sample can be run against both in one go with 3v4l (using the "+ include eol" option selected in the dropdown). You can make links go straight to the results including EOL PHP versions by adding #veol to the link.

Great idea, will do!

Function
Link
Remarks

chdir
https://3v4l.org/l3jFs#veol
Behaviour unchanged

opendir
https://3v4l.org/DoMVG#veol
Behaviour unchanged

scandir
https://3v4l.org/vf62L#veol
Behaviour unchanged

file_exists
https://3v4l.org/G8C5L#veol
Behaviour unchanged

file_get_contents
https://3v4l.org/b0CaJ#veol
Behaviour unchanged

file
https://3v4l.org/9EpXo#veol
Behaviour unchanged

fileatime
https://3v4l.org/V6LJ6#veol
Behaviour unchanged

filectime
https://3v4l.org/RVIJG#veol
Behaviour unchanged

filegroup
https://3v4l.org/SZlZ9#veol
Behaviour unchanged

fileinode
https://3v4l.org/N5O7I#veol
Behaviour unchanged

filemtime
https://3v4l.org/UZBYF#veol
Behaviour unchanged

fileowner
https://3v4l.org/ObITj#veol
Behaviour unchanged

fileperms
https://3v4l.org/oOttL#veol
Behaviour unchanged

filesize
https://3v4l.org/3L2Qd#veol
Behaviour unchanged

filetype
https://3v4l.org/mPfKV#veol
Behaviour unchanged

fopen
https://3v4l.org/hKUGL#veol
Behaviour unchanged

is_dir
https://3v4l.org/gQbqO#veol
Behaviour unchanged

is_executable
https://3v4l.org/WWppK1#veol
Behaviour unchanged

is_file
https://3v4l.org/SerMJ#veol
Behaviour unchanged

is_link
https://3v4l.org/X691s#veol
Behaviour unchanged

is_readable
https://3v4l.org/AlnoG#veol
Behaviour unchanged

is_writable
https://3v4l.org/5I6s3#veol
Behaviour unchanged

is_writeable
https://3v4l.org/gp5Yl#veol
Behaviour unchanged

lstat
https://3v4l.org/4CcKp#veol
Behaviour unchanged

@jrfnl I've observed that PHP 8.0 throws errors when there's a type mismatch in function arguments, for instance, passing an array where a string is expected. Should we classify these occurrences as behavioural changes?


Fix for notification drawer open/close styling

@dlabrecq @dtaylor113 Please review
The previous fix for open/close styling for Angular Bootstrap accordions had the potential to break the styling for any non-Angular Bootstrap accordions. Modified the selectors such that they only effect angular bootstrap accordions.

LGTM

LGTM


Json does not include path to image

Hi,
Not really an issue, but the json doesn't store the path to the chosen picture (stored locally on my computer).
So when i love the json, th picture is (obviously) not loaded.
Could it be possible to add this feature?

Hello. Apologies for the late response.
Paths to local files are actually faked out for privacy reasons, so it is impossible to add this feature.
I will add a duplicate cover image field in the next release to make loading for convenient.


Update the repo release, actions and add codeowners

Description
To avoid release failures and so that we get tagged in renovatebot PRs
Changes

ci: add codeowners
ci(release): use open turo config
ci: update actions versions

🚀 PR created with fotingo

action-docs is failing probably because of the node version. need to investigate


How to run it offline?

How to run it offline without accessing to HuggingFace.co?

You can download embeddings in advance and run locally, there is a parameter for this in Hugging Face API, check their docs.


Documentation breadcrumb trail for bootstrap, link is not working

Describe the problem
I'm using the docs way to use the breadcrumb_trail to display the breadcrumb using bootstrap v4.1, breadcrumb is displaying but links are not useful and current link is not with the class= "active" like it should be
Steps to reproduce the problem

The actual workaround using link_to_unless_current instead crumb.current?
```<%= link_to_unless_current crumb.name, crumb.url, (crumb.current? ? {'aria-current' => 'page'} : {}) %>

That worked for me and thanks for providing this gem.

### Describe your environment

* OS version:  MacOs High Sierra
* Ruby version: 2.4.1
* Loaf version:  0.8.0

Thanks for using the gem!
The bootstrap examples where provided by other contributors that used this gem. However, the usage of boostrap is accidental. The logic should work with any styling framework.
 This seems like you're masking some underlying issue in your code.
Please bear in mind when you use link_to_unless_current you're essentially skipping behaviour of the loaf gem and letting Rails decide what is the current link! There is a :match parameter that may help you set expected behaviour as to what is the current breadcrumb.
Hope this helps!


Core(Gtk): implemented navigation page and toolbar

Implemented NavigationViewHandler for Gtk.
Made changes so that NavigationViewHandler is used for
NavigationPage in Gtk, instead of generic Page handler.
It is incomplete at the moment.

Implement MauiToolbar to use in NavigationView.
Mapped properties like Visibility and Implemented BackButton
to be able to use HasNavigationBar and be able to navigate
properly between pages.

@jsuarezruiz please take a look

Thanks for the contribution!


Added support for float in index expressions

There are some float computations in index expressions, for example for resize where the new size is defined as
(int)  ((float) input size * scale).
Thus I added support for float expressions in IndexExpr and IndexExprBuilder.
Floats can be found in literals, question marks (just for sanity checks), affine expr (but only as literals), and non-affine (as runtime  values).
Support was added for all relevant IndexExpr, but currently only a subset is used (multiply). Was easier to do it in one go. Every computations verify that there is never an illegal mix of float and int/index/predicate, again to make sure that values are used properly. There are 2 conversion operation in IndexExpr, from float to index integers, and back. Some operations don't support float (for example the ceil/floor divisions), others that don't support int (floor/ceil). It's all labeled in the header files.
There are new methods to read 1D arrays of values as float: getFloatFromArrayAsNonAffine and variants found in IndexExprBuilders, which automatically detect literal values.
Implement features requested in #1958

Jenkins Linux s390x Build #9440 [push] Added support for float ... started at 12:44

Jenkins Linux amd64 Build #9422 [push] Added support for float ... started at 11:44

Jenkins Linux amd64 Build #9422 [push] Added support for float ... passed after 1 hr 34 min

Jenkins Linux s390x Build #9440 [push] Added support for float ... passed after 1 hr 56 min

Jenkins Linux ppc64le Build #8486 [push] Added support for float ... passed after 2 hr 57 min


[CI][Packaging][Java] Mac aarch64 C++ libraries fail to build

Describe the bug, including details regarding any error messages, version, and platform.
Error trying to build java-jars from main:
-- Found Java<EMAIL_ADDRESS>(found version "11.0.20")
xcode-select: error: tool 'xcodebuild' requires Xcode, but active developer directory '/Library/Developer/CommandLineTools' is a command line tools instance
CMake Error at /opt/homebrew/Cellar/cmake/3.27.2/share/cmake/Modules/FindJNI.cmake:394 (string):
  string sub-command REGEX, mode REPLACE needs at least 6 arguments total to
  command.
Call Stack (most recent call first):
  CMakeLists.txt:61 (find_package)

Example CI job triggered here: https://github.com/apache/arrow/pull/37158
Crossbow job results here: https://github.com/ursacomputing/crossbow/actions/runs/5859024890/job/15884200629
Component(s)
Java

It seems that this is a CMake 3.27.2 problem:

https://gitlab.kitware.com/cmake/cmake/-/issues/25181
https://gitlab.kitware.com/cmake/cmake/-/merge_requests/8707

Great find! That was fixed quickly 😄


feat(lidar_transfusion): intensity as uint8 and tests

Description
This PR updates intensity field as it's considered in new Autoware point clouds format. New unit tests cover this change.
Related links
Parent Issue:

https://github.com/autowarefoundation/autoware.universe/pull/6996 - PR dependency

How was this PR tested?

Rosbag input --> no behavior changes observed
Unit tests

Notes for reviewers
None.
Interface changes
Now the input point cloud has to contain uint8 intensity field.

Effects on system behavior
None.

Now that we use more pointer algebra for the preprocessing, we are very prone to make mistakes with the data layout.
I am going to do something similar in centerpoint, but can you add some static_assert to make sure that the point steps and offsets match the autoware defined ones?
I did something similar here:
https://github.com/knzo25/cuda_pointcloud_preprocessor/blob/23642f53e8136f45d0ee17ac25dbae05921f79da/include/cuda_pointcloud_preprocessor/cuda_pointcloud_preprocessor_node.hpp#L28-L55
(no need to so exactly the same)

Note:
This PR should only be merged after (or together) with
https://github.com/autowarefoundation/autoware.universe/pull/6996

@amadeuszsz Now that we use more pointer algebra for the preprocessing, we are very prone to make mistakes with the data layout. I am going to do something similar in centerpoint, but can you add some static_assert to make sure that the point steps and offsets match the autoware defined ones?
I did something similar here: https://github.com/knzo25/cuda_pointcloud_preprocessor/blob/23642f53e8136f45d0ee17ac25dbae05921f79da/include/cuda_pointcloud_preprocessor/cuda_pointcloud_preprocessor_node.hpp#L28-L55 (no need to so exactly the same)

FYI we already checking first input cloud and comparing with the reference.
The difference is in Transfusion we compare input cloud with structure which is assumed further by kernels. Centerpoint, as I noticed in your provided code, compares autoware point types with structure. I think we should do first to inform unaware user about wrong input and second option as well to track API changes. I will add proposed change for sure, thanks!
We are slowly going towards necessity of perception_common package 😄

:see_no_evil:
I understand that you are comparing it with the reference, which looks perfect. However, the reference itself has magic numbers and would be prone to errors.
For example,
https://github.com/autowarefoundation/autoware.universe/blob/36e54e0b5210aed913ae1a7dd463128c700bd1ba/perception/lidar_transfusion/include/lidar_transfusion/utils.hpp#L56C1-L72C4
Uses datatype=7. In this case sensor_msgs::msg::PointField::FLOAT32 would be better IMO

@amadeuszsz
The branch is not compiling due to the use of PointXYZIRCAEDT that will be introduced in the before-mentioned PR.
Should we leave this as a draft for now? Or do you have other way you would like to proceed with?

@amadeuszsz The branch is not compiling due to the use of PointXYZIRCAEDT that will be introduced in the before-mentioned PR. Should we leave this as a draft for now? Or do you have other way you would like to proceed with?

Removing tag:run-build-and-test-differential should be enough for now. I suggest to continue review this PR (my near fixes) before merging parent PR. Then this PR will be already reviewed and ready to merge alongside with parent PR.

@amadeuszsz The branch is not compiling due to the use of PointXYZIRCAEDT that will be introduced in the before-mentioned PR. Should we leave this as a draft for now? Or do you have other way you would like to proceed with?

Removing tag:run-build-and-test-differential should be enough for now. I suggest to continue review this PR (my near fixes) before merging parent PR. Then this PR will be already reviewed and ready to merge alongside with parent PR.

Sorry, I did not understand what you meant. Btw, what failed to compile was a local build in my PC
‘PointXYZIRADRT’?
   53 |     autoware_point_types::PointXYZIRCAEDT, autoware_point_types::PointXYZIRCAEDTGenerator>
      |                           ^~~~~~~~~~~~~~~
      |                           PointXYZIRADRT
autoware/universe/perception/lidar_transfusion/test/test_voxel_generator.cpp:53:66: error: ‘PointXYZIRCAEDTGenerator’ is not a member of ‘autoware_point_types’; did you mean ‘PointXYZIRADRTGenerator’?
   53 |     autoware_point_types::PointXYZIRCAEDT, autoware_point_types::PointXYZIRCAEDTGenerator>
      |                                                                  ^~~~~~~~~~~~~~~~~~~~~~~~
      |                                                                  PointXYZIRADRTGenerator

@amadeuszsz The branch is not compiling due to the use of PointXYZIRCAEDT that will be introduced in the before-mentioned PR. Should we leave this as a draft for now? Or do you have other way you would like to proceed with?

Removing tag:run-build-and-test-differential should be enough for now. I suggest to continue review this PR (my near fixes) before merging parent PR. Then this PR will be already reviewed and ready to merge alongside with parent PR.

Sorry, I did not understand what you meant.

If we switch this PR to draft, the review will take place after merge of parent PR.
If we keep this PR open and review it before merge parent PR, we will merge both PR at the same time.

Btw, what failed to compile was a local build in my PC
‘PointXYZIRADRT’?
   53 |     autoware_point_types::PointXYZIRCAEDT, autoware_point_types::PointXYZIRCAEDTGenerator>
      |                           ^~~~~~~~~~~~~~~
      |                           PointXYZIRADRT
autoware/universe/perception/lidar_transfusion/test/test_voxel_generator.cpp:53:66: error: ‘PointXYZIRCAEDTGenerator’ is not a member of ‘autoware_point_types’; did you mean ‘PointXYZIRADRTGenerator’?
   53 |     autoware_point_types::PointXYZIRCAEDT, autoware_point_types::PointXYZIRCAEDTGenerator>
      |                                                                  ^~~~~~~~~~~~~~~~~~~~~~~~
      |                                                                  PointXYZIRADRTGenerator

My fault, I should leave a note that this PR required changes from parent PR. Required changes are not included since parent PR is still under development. For time being I'm using autoware_point_types and pointcloud_preprocessor from parent PR.


Version Bump (1.0.4) on npm?

This is a:

[ ] Bug Report
[ ] Feature Request
[X] General Query

My version of UI-Router is: 1.0.4
I've tried to include ui-router 1.04 from npm as I'm running into the "Possibly unhandled rejection" error (which was fixed with the latest version). Unfortunately 1.0.4 isn't available on npm yet. Any plans on "bumping the Version" anytime soon?

+1

+1

+1

@felixwahner
Try switching to @uirouter/angularjs

Okay. I'll do!


Version 3.22.0 release

Changed

Added support for version v2.1-<IP_ADDRESS> of the DocuSign ESignature API.
Updated the SDK release version.

LGTM


Remove OS specific files and improve .gitignore

desktop.ini and _DS_Store are OS specific files and should not be pushed. With this PR I have removed them and added the rules to the .gitignore so that they will not be pushed again in the future.

Thanks. This makes sense.


Guinea Pig here.

Wanting to test RimModelled on windows 11.
Side note tried building it myself but the window was blank. I know enough to clone and build it but not enough to know how to find the issue.

Image

Hey! Glad to hear it! I'm super excited to get a Windows version of this working!
So, everything that has to do with talking to RimWorld lives in loadRimworld. Presently it's hard-coded to look for Mac paths, because... I don't know what they should be on Windows!
There's 4 paths that we need to locate:

The RimWorld core mods folder (probably called Data, but not sure where it lives).
The RimWorld manual mods folder (probably called Mods in the same place as Data).
The Steam Workshop mods folder (it's gonna be in some folder for steam, and then from there inside steamapps/workshop/content/294100).
data is the folder where Config/ModsConfig.xml lives. Probably somewhere under documents and settings?
lib is the folder where Version.txt lives. This is probably the folder you get when you say "Browse local files" from Steam.

Once I get these for your system, I can make them generic for Windows (hopefully). Then I'll add a bit of extra error handling so you don't just get a blank window, and then we should have working Windows support!

This is my current setup for rimworld,
    paths: {
      mods: [
        path.join(
          process.env["HOME"]!,
          "C:/Gaming/Games/Steam/steamapps/common/RimWorld/Data"
        ),
        path.join(
          process.env["HOME"]!,
          "C:/Gaming/Games/Steam/steamapps/common/RimWorld/Mods"
        ),
        path.join(
          process.env["HOME"]!,
          "C:/Gaming/Games/Steam/steamapps/workshop/content/294100"
        ),
      ],
      data: path.join(
        process.env["HOME"]!,
        "C:/Users/bradl/AppData/LocalLow/Ludeon Studios/RimWorld by Ludeon Studios"
      ),
      lib: path.join(
        process.env["HOME"]!,
        "C:/Gaming/Games/Steam/steamapps/common/RimWorld"
      ),
    },

The default for windows steam is the following
    paths: {
      mods: [
        path.join(
          process.env["HOME"]!,
          "C:/Program Files (x86)/Steam/steamapps/common/RimWorld/Data"
        ),
        path.join(
          process.env["HOME"]!,
          "C:/Program Files (x86)/Steam/steamapps/common/RimWorld/Mods"
        ),
        path.join(
          process.env["HOME"]!,
          "C:/Program Files (x86)/Steam/steamapps/workshop/content/294100"
        ),
      ],
      data: path.join(
        process.env["HOME"]!,
        "C:/Users/USERNAME/AppData/LocalLow/Ludeon Studios/RimWorld by Ludeon Studios"
      ),
      lib: path.join(
        process.env["HOME"]!,
        "C:/Program Files (x86)/Steam/steamapps/common/RimWorld"
      ),
    },

Changing the rimworld.ts file myself did not change the result of npm install && npm start Loaded into a blank screen.
Hopefully you'll have better luck.

Thanks for this info! I’m going to try and take a look into why you’re
getting a blank screen on Saturday, and add some better error checking for
you.
On Wed, Mar 2, 2022 at 04:01 Drunkender @.***> wrote:

This is my current setup for rimworld,
paths: {
  mods: [
    path.join(
      process.env["HOME"]!,
      "C:/Gaming/Games/Steam/steamapps/common/RimWorld/Data"
    ),
    path.join(
      process.env["HOME"]!,
      "C:/Gaming/Games/Steam/steamapps/common/RimWorld/Mods"
    ),
    path.join(
      process.env["HOME"]!,
      "C:/Gaming/Games/Steam/steamapps/workshop/content/294100"
    ),
  ],
  data: path.join(
    process.env["HOME"]!,
    "C:/Users/bradl/AppData/LocalLow/Ludeon Studios/RimWorld by Ludeon Studios"
  ),
  lib: path.join(
    process.env["HOME"]!,
    "C:/Gaming/Games/Steam/steamapps/common/RimWorld"
  ),
},

The default for windows steam is the following
paths: {
  mods: [
    path.join(
      process.env["HOME"]!,
      "C:/Program Files (x86)/Steam/steamapps/common/RimWorld/Data"
    ),
    path.join(
      process.env["HOME"]!,
      "C:/Program Files (x86)/Steam/steamapps/common/RimWorld/Mods"
    ),
    path.join(
      process.env["HOME"]!,
      "C:/Program Files (x86)/Steam/steamapps/workshop/content/294100"
    ),
  ],
  data: path.join(
    process.env["HOME"]!,
    "C:/Users/USERNAME/AppData/LocalLow/Ludeon Studios/RimWorld by Ludeon Studios"
  ),
  lib: path.join(
    process.env["HOME"]!,
    "C:/Program Files (x86)/Steam/steamapps/common/RimWorld"
  ),
},

Changing the rimworld.ts file myself did not change the result of npm
install && npm start Loaded into a blank screen.
Hopefully you'll have better luck.
—
Reply to this email directly, view it on GitHub
https://github.com/CGamesPlay/RimModelled/issues/1#issuecomment-1056618882,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAJJA4ULFSGFD5SL6E5W2WDU54U6ZANCNFSM5PRMY46A
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you commented.Message ID:
@.***>

--
~ry

OK, thanks again for being willing to test out RimModelled. I've made a bunch of changes to help out, but we still need to figure out the underlying reason for the error. Now when you get an error, instead of a blank screen, you'll see an error page explaining it.
I've also added support for your paths to the program. For your custom Steam directory, you'll need to use set STEAMAPPS=C:/Gaming/Games/Steam/steamapps; npm start to run, but you shouldn't need any changes to the source code now.
I'm hoping that the error is still a simple path thing and nothing complex to fix, and with the extra error handling it should be possible to figure it out. If these changes don't fix it for you, please use View -> Toggle Developer Tools in the error window, and then send over the output in the "Console" tab.

useRimworld.tsx?4d83:175 Error: [
  {
    "code": "custom",
    "message": "Directory does not exist",
    "path": [
      "mods",
      0
    ]
  },
  {
    "code": "custom",
    "message": "Directory does not exist",
    "path": [
      "mods",
      1
    ]
  },
  {
    "code": "custom",
    "message": "Directory does not exist",
    "path": [
      "mods",
      2
    ]
  },
  {
    "code": "custom",
    "message": "Directory does not exist",
    "path": [
      "lib"
    ]
  }
]

Got it. So the problem, based on these, is that despite you configuring the paths, RimModelled can't figure out the correct files. Actually, based on this, it looks like the steam directory is either not configured or wrong on my part.
I've pushed some changes again that should greatly improve the logging, which should nail the problem down pretty quickly. This won't fix it, but it should give me the information I need to fix it. Once you run the code, you'll get a shorter error message on the screen but you should have a lot more detail in the console. I also am writing to a log file now, which should be in C:\Users\USERNAME\AppData\Local\RimModelled\Log\RimModelled.log. It should have all of the information I need to fix the issue.
Thanks again for helping with this. If you want to email your contact information to<EMAIL_ADDRESS>we can maybe use discord/email/steam to work through the issues a bit quicker.

RimModelled.log
Seems like set STEAMAPPS=C:/Gaming/Games/Steam/steamapps is not working. After copying rimworld and mods into the directories its actually looking in I got it to boot!

STEAMAPPS Is in my environment tables but doesn't stay between reboots.

Great! The good news is that since the RimWorld data is in the right place, everything should work normally except for noticing when you install/uninstall new mods. Does the app seem to work for you now that it's booting? I'd appreciate any feedback you have about  the app.
My next project will be to add a real GUI for choosing the Steam directory, so we don't have to worry about this environment variable junk, then I'll publish a Windows version. If you report that everything is currently working properly, that should be all that's needed!

Hi @CGamesPlay,
just wanted to add that you really should add a way to change the directory, because even on MacOS I cannot use the build, because I run the GOG version which neatly sits in /Applications/Rimworld.app
Apart from that I think this project has potential!


Wallcheck

whenever i turn on wall check in the game operation siege in roblox the aimbot just stops working what should I do

also when i export the settings they don't save

If Wall Check is enabled, the aimbot will not respond to players who are behind a wall or other obstacle. It is recommended to enable it to reduce the risk of detection.
If the settings are not saved when exporting, delete your code executor and download a normal one that has adequate IO Library implementation.

Open Aimbot does not have any bugs directly related to it at the moment. If you have any problems, then refer to our documentation to find out the subtleties, or just install a normal code executor that does not fake the UNC test.
https://moderka.org/Open-Aimbot/about.html


Changing default of parameter and localparam names to ALL_CAPS

Codecov Report

Merging #6 (ad9874a) into main (10c2bab) will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main       #6      +/-   ##
==========================================
+ Coverage   92.89%   92.92%   +0.03%
==========================================
  Files         342      342
  Lines       23738    23731       -7
==========================================
+ Hits        22051    22053       +2
+ Misses       1687     1678       -9

Impacted Files
Coverage Δ

...log/analysis/checkers/parameter_name_style_rule.cc
100.00% <ø> (ø)

common/formatting/token_partition_tree.cc
98.09% <0.00%> (-0.24%)
:arrow_down:

verilog/analysis/verilog_linter.cc
92.43% <0.00%> (-0.05%)
:arrow_down:

common/util/vector_tree.h
98.66% <0.00%> (ø)

common/analysis/citation.cc
100.00% <0.00%> (ø)

common/analysis/line_linter.cc
100.00% <0.00%> (ø)

common/analysis/lint_rule_status.h
100.00% <0.00%> (ø)

common/formatting/tree_unwrapper.h
91.66% <0.00%> (ø)

common/util/expandable_tree_view.h
100.00% <0.00%> (ø)

...ilog/analysis/checkers/uvm_macro_semicolon_rule.cc
97.14% <0.00%> (ø)

... and 6 more

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

LGTM


provide non-redundant human dataset in AmiGO

Currently we have 29081 human proteins
It seems  possibly Intact are submitting Trembl entries?
Is there an easy way to check where the duplicates are coming from and stop it happening?
@bmeldal

Thanks, Val. I've emailed the team.

Sandra confirms, we export TrEMBL entries. It's up to GO to decide if they still want them, provide a ref proteome DS or let users do the filtering according to their needs (e.g. minus PE=5).

I don't think it is possible to leave this to users. They will not be able to distinguish between a UniProt or Trembl entry, and for the most part they won't know that they need to ...otherwise the question would have arisen before (or not because we don't have a helpdesk).
Although previously we worked on the principle that Trembl entries only contain inferred, and hence redundant information?  Isn't this the case? Or do Intact annotate both the UniPROT entry and the Trembl entry with the same information ? (which would still be redundant but I thought that manual curation only happened  to  the reference proteome entry) ?

We use TrEMBL entries if the seq used in the expt doesn't match anything in SwissProt. We are picky about using the best match as interactions can be disrupted by small changes. (That doesn't apply to mutations, we annotate them as features of the canonical protein)

Goa releases the gcrp for human. The number is due to hgnc ids leaking in
from the paint pipeline. Can someone mark this ticket as a dupe of the
issue Antonia reported on helpdesk? I'm on my phone
On Feb 22, 2018 6:58 AM, "Birgit Meldal"<EMAIL_ADDRESS>wrote:

We use TrEMBL entries if the seq used in the expt doesn't match anything
in SwissProt. We are picky about using the best match as interactions can
be disrupted by small changes. (That doesn't apply to mutations, we
annotate them as features of the canonical protein)
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/geneontology/amigo/issues/470#issuecomment-367707007,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AADGOZtvPktz9r9dFjGavf57EyH1hT3bks5tXYCigaJpZM4SPZm9
.

duplicate of https://github.com/geneontology/helpdesk/issues/99


Update README.md

ok

I received your email ;however, i could not access the message. I am unsure what the email was concerning. Please do not hesitate to try again. Thank you your github. Buddy QWN. Victoria Ashley-Nicole Bailey.


Bump to support Django 2.0

A couple of small changes to support Django 2.0.
A few notes regarding testing:

The test_subquery_lookup function had to be modified to specify values in the subquery queryset; I'm not sure if this is a new behavior in Django 2.0 or not, but it was the only version that complained about it. All other versions tested fine via Tox. I hate modifying tests as part of a version bump, but it seemed necessary here.
Tox complains when trying to install Django 2.0 on Python 2.7 -- Django 2.0 is the first version to release with no support for Python 2.x, so this isn't surprising. I'm not very familiar with Tox, so I wasn't sure how to modify tox.ini to tell it not to test Python 2.x / Django 2.0 in its test matrix.

Please let me know if you need any further adjustments -- this is working great in my Django 2.0 project. Thank you for open sourcing this library :heart:

Ah, I just realized I didn't modify the Travis config either -- it's going to have the same problem trying to build Django 2.0 on Python 2.x... Not sure the best course of action there, as I'm not a Travis or Tox user.


chore(CPlusPlus): add number system

PR Checklist:

[x] My submission is formatted according to the guidelines in the contributing guide
[ ] My addition is on refer on the language README.md file
[ ] My addition does not have a spelling problem
[ ] My submission has a proper and user-friendly description of the algorithm
[ ] My submission has the time complexity of the algorithm
[ ] My submission has sample input-output of the program (NOT FOR PYTHON)

What kind of change does this PR introduce? (check at least one)

[ ] Bugfix
[x] New algorithm
[ ] Optimization in previous algorithms
[ ] Code style update
[ ] Refactor
[ ] Documentation
[ ] Other, please describe:

Briefly describe the changes in this PR

Other information:

now the only thing left is updating the proper readme and this should be good to go


K8SPXC-365 run version detection on image change if SmartUpdate disabled

we should refetch version information from PXC if the user manually changed the PXC image.
we should take the version from Version Service if SmartUpdate enabled

Test name
Status

recreate
passed

big-data
passed

init-deploy
passed

scaling
passed

storage
passed

scaling-proxysql
passed

self-healing
passed

limits
passed

monitoring
passed

restore-to-encrypted-cluster
passed

upgrade
passed

monitoring-2-0
passed

self-healing-advanced
passed

upgrade-consistency
passed

security-context
passed

affinity
passed

operator-self-healing
passed

demand-backup
passed

one-pod
passed

auto-tuning
passed

scheduled-backup
failed

proxysql-sidecar-res-limits
passed

demand-backup-encrypted-with-tls
failed

Test name
Status

big-data
passed

storage
passed

init-deploy
passed

recreate
passed

scaling
passed

scaling-proxysql
passed

self-healing
passed

limits
passed

restore-to-encrypted-cluster
failed

monitoring
passed

upgrade
passed

demand-backup
failed

monitoring-2-0
passed

self-healing-advanced
failed

upgrade-consistency
passed

security-context
passed

scheduled-backup
failed

affinity
passed

operator-self-healing
failed

one-pod
passed

auto-tuning
passed

proxysql-sidecar-res-limits
passed

demand-backup-encrypted-with-tls
passed

Test name
Status

big-data
passed

storage
passed

scaling
passed

recreate
passed

init-deploy
passed

scaling-proxysql
passed

self-healing
passed

limits
passed

monitoring
passed

restore-to-encrypted-cluster
passed

upgrade
passed

monitoring-2-0
passed

self-healing-advanced
failed

upgrade-consistency
passed

affinity
passed

security-context
passed

one-pod
failed

demand-backup
passed

operator-self-healing
passed

auto-tuning
passed

proxysql-sidecar-res-limits
passed

scheduled-backup
failed

demand-backup-encrypted-with-tls
passed

Test name
Status

Test name
Status

recreate
passed

scaling
passed

init-deploy
passed

storage
passed

big-data
passed

self-healing
passed

scaling-proxysql
passed

limits
passed

upgrade
passed

restore-to-encrypted-cluster
failed

monitoring
passed

self-healing-advanced
passed

upgrade-consistency
passed

security-context
passed

demand-backup
passed

operator-self-healing
passed

monitoring-2-0
passed

affinity
passed

scheduled-backup
failed

one-pod
failed

auto-tuning
passed

proxysql-sidecar-res-limits
passed

demand-backup-encrypted-with-tls
passed


Way to take access console message of android application

Hi,
Is there a way so that I can get the console output of the developer tools so that i can automate the same.
I am opening the webview in my app and some errors will be encountered due to network issue in my app and it will be displayed in console. I want to get this console message in my framework of expresso to test this feature in android. Is there a way to get the console message of the developer tools in framework, or should i use any other framework to get the same. Is there any API also available to identify the messages for the same.

Hey @tusharaina92 this repo is used for content of WebFundamentals site.
I suggest posting questions on stack overflow with google-chrome-devtools tag ✨


Swarm Service: connection from Slave to Spark Master fails when a port is exposed.

Description
Exposing a port of a Spark Master running as a Swarm Service prevents the connections from the Spark Slaves (also running as a Service) to that Spark Master.
Steps to reproduce the issue:
> docker service create --name spark-master -e SERVICE_NAME=spark-master --network spark-net -p 8080:8080  gettyimages/spark:1.6.2-hadoop-2.6
> docker service create --name spark-slave -e SERVICE_NAME=spark-slave --network spark-net --replicas=2  gettyimages/spark:1.6.2-hadoop-2.6 bin/spark-class org.apache.spark.deploy.worker.Worker spark://spark-master:7077

Describe the results you received:
The connection from the Slave to the Master fails:
> docker ps
> docker logs spark-slave.1.xxxxxxxxxx
16/10/11 16:26:45 INFO worker.Worker: Registered signal handlers for [TERM, HUP, INT]
16/10/11 16:26:46 WARN util.NativeCodeLoader: Unable to load native-hadoop library for your platform... using builtin-java classes where applicable
16/10/11 16:26:46 INFO spark.SecurityManager: Changing view acls to: root
16/10/11 16:26:46 INFO spark.SecurityManager: Changing modify acls to: root
16/10/11 16:26:46 INFO spark.SecurityManager: SecurityManager: authentication disabled; ui acls disabled; users with view permissions: Set(root); users with modify permissions: Set(root)
16/10/11 16:26:46 INFO util.Utils: Successfully started service 'sparkWorker' on port 33463.
16/10/11 16:26:47 INFO worker.Worker: Starting Spark worker <IP_ADDRESS>:33463 with 4 cores, 6.8 GB RAM
16/10/11 16:26:47 INFO worker.Worker: Running Spark version 1.6.2
16/10/11 16:26:47 INFO worker.Worker: Spark home: /usr/spark-1.6.2
16/10/11 16:26:47 INFO server.Server: jetty-8.y.z-SNAPSHOT
16/10/11 16:26:47 INFO server.AbstractConnector: Started SelectChannelConnector@<IP_ADDRESS>:8081
16/10/11 16:26:47 INFO util.Utils: Successfully started service 'WorkerUI' on port 8081.
16/10/11 16:26:47 INFO ui.WorkerWebUI: Started WorkerWebUI at http://<IP_ADDRESS>:8081
16/10/11 16:26:47 INFO worker.Worker: Connecting to master spark-master:7077...
16/10/11 16:26:47 WARN worker.Worker: Failed to connect to master spark-master:7077
java.io.IOException: Failed to connect to spark-master/<IP_ADDRESS>:7077
	at org.apache.spark.network.client.TransportClientFactory.createClient(TransportClientFactory.java:216)
	at org.apache.spark.network.client.TransportClientFactory.createClient(TransportClientFactory.java:167)
	at org.apache.spark.rpc.netty.NettyRpcEnv.createClient(NettyRpcEnv.scala:200)
	at org.apache.spark.rpc.netty.Outbox$$anon$1.call(Outbox.scala:187)
	at org.apache.spark.rpc.netty.Outbox$$anon$1.call(Outbox.scala:183)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
	at java.lang.Thread.run(Thread.java:745)
Caused by: java.net.ConnectException: Connection refused: spark-master/<IP_ADDRESS>:7077
	at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
	at sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:717)
	at io.netty.channel.socket.nio.NioSocketChannel.doFinishConnect(NioSocketChannel.java:224)
	at io.netty.channel.nio.AbstractNioChannel$AbstractNioUnsafe.finishConnect(AbstractNioChannel.java:289)
	at io.netty.channel.nio.NioEventLoop.processSelectedKey(NioEventLoop.java:528)
	at io.netty.channel.nio.NioEventLoop.processSelectedKeysOptimized(NioEventLoop.java:468)
	at io.netty.channel.nio.NioEventLoop.processSelectedKeys(NioEventLoop.java:382)
	at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:354)
	at io.netty.util.concurrent.SingleThreadEventExecutor$2.run(SingleThreadEventExecutor.java:111)
	... 1 more
16/10/11 16:26:58 INFO worker.Worker: Retrying connection to master (attempt # 1)

Describe the results you expected:
> docker service create --name spark-master -e SERVICE_NAME=spark-master --network spark-net  gettyimages/spark:1.6.2-hadoop-2.6
> docker service create --name spark-slave -e SERVICE_NAME=spark-slave --network spark-net --replicas=2  gettyimages/spark:1.6.2-hadoop-2.6 bin/spark-class org.apache.spark.deploy.worker.Worker spark://spark-master:7077
> docker logs spark-slave.1.xxxxxxxxxxx
16/10/11 12:48:02 INFO worker.Worker: Registered signal handlers for [TERM, HUP, INT]
16/10/11 12:48:03 WARN util.NativeCodeLoader: Unable to load native-hadoop library for your platform... using builtin-java classes where applicable
16/10/11 12:48:03 INFO spark.SecurityManager: Changing view acls to: root
16/10/11 12:48:03 INFO spark.SecurityManager: Changing modify acls to: root
16/10/11 12:48:03 INFO spark.SecurityManager: SecurityManager: authentication disabled; ui acls disabled; users with view permissions: Set(root); users with modify permissions: Set(root)
16/10/11 12:48:04 INFO util.Utils: Successfully started service 'sparkWorker' on port 45899.
16/10/11 12:48:05 INFO worker.Worker: Starting Spark worker <IP_ADDRESS>:45899 with 4 cores, 6.8 GB RAM
16/10/11 12:48:05 INFO worker.Worker: Running Spark version 1.6.2
16/10/11 12:48:05 INFO worker.Worker: Spark home: /usr/spark-1.6.2
16/10/11 12:48:05 INFO server.Server: jetty-8.y.z-SNAPSHOT
16/10/11 12:48:05 INFO server.AbstractConnector: Started SelectChannelConnector@<IP_ADDRESS>:8081
16/10/11 12:48:05 INFO util.Utils: Successfully started service 'WorkerUI' on port 8081.
16/10/11 12:48:05 INFO ui.WorkerWebUI: Started WorkerWebUI at http://<IP_ADDRESS>:8081
16/10/11 12:48:05 INFO worker.Worker: Connecting to master spark-master:7077...
16/10/11 12:48:06 INFO worker.Worker: Successfully registered with master spark://<IP_ADDRESS>:7077

Additional information you deem important (e.g. issue happens only occasionally):
That kind of cluster with the Spark Master's 8080 port exposed works fine when based on Docker-Compose.
The Docker Image's Dockerfile used is gettyimages/spark:1.6.2-hadoop-2.6 (which contains no EXPOSE).
Output of docker version:
Client:
 Version:      1.12.2-rc1
 API version:  1.24
 Go version:   go1.6.3
 Git commit:   45bed2c
 Built:        Tue Sep 27 23:38:15 2016
 OS/Arch:      darwin/amd64
 Experimental: true

Server:
 Version:      1.12.2-rc1
 API version:  1.24
 Go version:   go1.6.3
 Git commit:   45bed2c
 Built:        Tue Sep 27 23:38:15 2016
 OS/Arch:      linux/amd64
 Experimental: true

Output of docker info:
Containers: 9
 Running: 3
 Paused: 0
 Stopped: 6
Images: 7
Server Version: 1.12.2-rc1
Storage Driver: aufs
 Root Dir: /var/lib/docker/aufs
 Backing Filesystem: extfs
 Dirs: 41
 Dirperm1 Supported: true
Logging Driver: json-file
Cgroup Driver: cgroupfs
Plugins:
 Volume: local
 Network: host null overlay bridge
Swarm: active
 NodeID: diok2cmz0j2qnik4qz7vfsagu
 Is Manager: true
 ClusterID: 41p013kakqt5265t6safu1x5e
 Managers: 1
 Nodes: 1
 Orchestration:
  Task History Retention Limit: 5
 Raft:
  Snapshot Interval: 10000
  Heartbeat Tick: 1
  Election Tick: 3
 Dispatcher:
  Heartbeat Period: 5 seconds
 CA Configuration:
  Expiry Duration: 3 months
 Node Address: <IP_ADDRESS>
Runtimes: runc
Default Runtime: runc
Security Options: seccomp
Kernel Version: 4.4.22-moby
Operating System: Alpine Linux v3.4
OSType: linux
Architecture: x86_64
CPUs: 4
Total Memory: 7.787 GiB
Name: moby
ID: KCCS:H6PI:SQMH:NWJ4:NYGF:FI2E:SWGC:YVG5:HJGE:D6ZQ:LXFQ:MWPX
Docker Root Dir: /var/lib/docker
Debug Mode (client): false
Debug Mode (server): true
 File Descriptors: 56
 Goroutines: 164
 System Time: 2016-10-11T16:40:59.448187411Z
 EventsListeners: 4
No Proxy: *.local, 169.254/16
Username: lmagnin
Registry: https://index.docker.io/v1/
Experimental: true
Insecure Registries:
 <IP_ADDRESS>/8

Additional environment details (AWS, VirtualBox, physical, etc.):

I think it is related to #24637
The master is actually listening on 10.255.x.x:7077

Can reproduce the issue with latest master:
16/10/11 21:43:33 INFO worker.Worker: Retrying connection to master (attempt # 1)
16/10/11 21:43:33 INFO worker.Worker: Connecting to master spark-master:7077...
16/10/11 21:43:33 WARN worker.Worker: Failed to connect to master spark-master:7077
java.io.IOException: Failed to connect to spark-master/<IP_ADDRESS>:7077
	at org.apache.spark.network.client.TransportClientFactory.createClient(TransportClientFactory.java:216)
	at org.apache.spark.network.client.TransportClientFactory.createClient(TransportClientFactory.java:167)
	at org.apache.spark.rpc.netty.NettyRpcEnv.createClient(NettyRpcEnv.scala:200)
	at org.apache.spark.rpc.netty.Outbox$$anon$1.call(Outbox.scala:187)
	at org.apache.spark.rpc.netty.Outbox$$anon$1.call(Outbox.scala:183)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
	at java.lang.Thread.run(Thread.java:745)
Caused by: java.net.ConnectException: Connection refused: spark-master/<IP_ADDRESS>:7077
	at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
	at sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:717)
	at io.netty.channel.socket.nio.NioSocketChannel.doFinishConnect(NioSocketChannel.java:224)
	at io.netty.channel.nio.AbstractNioChannel$AbstractNioUnsafe.finishConnect(AbstractNioChannel.java:289)
	at io.netty.channel.nio.NioEventLoop.processSelectedKey(NioEventLoop.java:528)
	at io.netty.channel.nio.NioEventLoop.processSelectedKeysOptimized(NioEventLoop.java:468)
	at io.netty.channel.nio.NioEventLoop.processSelectedKeys(NioEventLoop.java:382)
	at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:354)
	at io.netty.util.concurrent.SingleThreadEventExecutor$2.run(SingleThreadEventExecutor.java:111)
	... 1 more

Confirmed the master was binding to the ingress network interface address 10.255.x.x
Verified the change in https://github.com/docker/libnetwork/pull/1494 (although not complete yet) fixes the issue:
16/10/11 21:53:29 INFO worker.Worker: Registered signal handlers for [TERM, HUP, INT]
16/10/11 21:53:30 WARN util.NativeCodeLoader: Unable to load native-hadoop library for your platform... using builtin-java classes where applicable
16/10/11 21:53:30 INFO spark.SecurityManager: Changing view acls to: root
16/10/11 21:53:30 INFO spark.SecurityManager: Changing modify acls to: root
16/10/11 21:53:30 INFO spark.SecurityManager: SecurityManager: authentication disabled; ui acls disabled; users with view permissions: Set(root); users with modify permissions: Set(root)
16/10/11 21:53:31 INFO util.Utils: Successfully started service 'sparkWorker' on port 37855.
16/10/11 21:53:31 INFO worker.Worker: Starting Spark worker <IP_ADDRESS>:37855 with 4 cores, 6.4 GB RAM
16/10/11 21:53:31 INFO worker.Worker: Running Spark version 1.6.2
16/10/11 21:53:31 INFO worker.Worker: Spark home: /usr/spark-1.6.2
16/10/11 21:53:32 INFO server.Server: jetty-8.y.z-SNAPSHOT
16/10/11 21:53:32 INFO server.AbstractConnector: Started SelectChannelConnector@<IP_ADDRESS>:8081
16/10/11 21:53:32 INFO util.Utils: Successfully started service 'WorkerUI' on port 8081.
16/10/11 21:53:32 INFO ui.WorkerWebUI: Started WorkerWebUI at http://<IP_ADDRESS>:8081
16/10/11 21:53:32 INFO worker.Worker: Connecting to master spark-master:7077...
16/10/11 21:53:37 INFO worker.Worker: Retrying connection to master (attempt # 1)
16/10/11 21:53:37 INFO worker.Worker: Connecting to master spark-master:7077...
16/10/11 21:53:37 INFO worker.Worker: Successfully registered with master spark://<IP_ADDRESS>:7077

I think we should close this issue as duplicate of  #24637

Thanks for checking @aboch, let's close this one, as we're tracking the issue through https://github.com/docker/docker/issues/24637
Thanks for reporting @laugimethods