Treat missing values as NA rather than the empty string ""

Currently missing values in the dataset are being imported as empty strings "". Would be useful to treat them as NAs instead. Wasn't able to figure out how to do this with arrow.

good call.  Yeah, arrow's docs are unclear to me too.  Looking at https://cran.r-project.org/web/packages/arrow/arrow.pdf, the argument might be null_strings = "" in our open_dataset() calls?  But from https://arrow.apache.org/docs/r/reference/read_delim_arrow.html, it looks like the argument is called na (like in readr), and already defaults to na=c("", "NA").  How are missing values coded in the original  .txt.gz dump file?  as empty characters like ""?

The text files stores them as empty, unquote strings. I did try null_strings = "", but had no luck. Using na = "" in arrow::open_dataset() gives the following interesting error:
Error: The following option is supported in "read_delim_arrow" functions but not yet supported here: "na"

suggesting that maybe the intention is to implement this in future versions.


Adding udev rule for ZTE 3630

Customer ( Michelin) would like the following commands to be run during boot at OS level for their LTE modem:

modprobe option
echo 0x19d2 0x1476 > /sys/bus/usb-serial/drivers/option1/new_id

Tested on 2.13.6
 Front conversations

@joehounsham guess this can be closed now as we allow people to add their own udev rules.
Confirm?


Mark messages as read

How can I mark messages as read to add the 👁🗨 below them? I don't think if it's possible but it would be very useful... And, I don't if it's possible too, how to set the bot status to online?

There's DirectThreadEntity.markItemAsSeen(itemId) which should satisfy your needs.

Thank you!
And, do you know how to set the account status to online?

You'll have to use the realtime client for this.


can only paste once

VSCode Version: Code 1.13.1 (379d2efb5539b09112c793d3d9a413017d736f89, 2017-06-14T18:18:03.540Z)
OS Version: Linux x64 4.10.0-28-generic
Extensions:

Extension
Author
Version

vscode-stylesheet-beautify
n23
0.0.1

Steps to Reproduce:

right click on a file
click "copy"
click the folder
click "paste"
click the folder
no "paste" available

Can you try to reproduce with our nightly insider builds? You can give our preview releases a try from: http://code.visualstudio.com/Download#insiders


doc: fix name

I'm pretty sure namespace is the correct word to use here.
Relevant reading:
https://github.com/entropic-dev/entropic/tree/master/docs

Ok, I agree.
What cleared it up is
"name" - the canonical name of the package, as a string, including its namespace. e.g<EMAIL_ADDRESS>
on https://github.com/entropic-dev/entropic/blob/master/docs/rfcs/0002-manifest-toml.md


Release/element-lib-0.1.2

This is a bit of a mess, lots of things here.

Implemented and tested in both web and server and ipfs manager pattern to avoid gateway errors from infura

Tried to get rid of firestore, succeeded, but performance hit was not worth it:
I was able to prove that replication works: https://github.com/pubkey/rxdb/blob/master/docs-src/replication.md
However, cloud functions require some different behavior, we need a better pattern for handling mobile, cloud  function, and server sidetree database abstractions, see https://github.com/decentralized-identity/element/issues/87

Fixed storybook ui

fixed various dependency and linting issues

fixed various documentation issues

fixed a batch processing error that was caused by newer versions of firebase functions.

Codecov Report

Merging #88 into development will decrease coverage by 0.94%.
The diff coverage is 41.26%.

@@               Coverage Diff               @@
##           development      #88      +/-   ##
===============================================
- Coverage        34.41%   33.47%   -0.95%
===============================================
  Files              246      242       -4
  Lines             3185     3167      -18
  Branches           224      227       +3
===============================================
- Hits              1096     1060      -36
- Misses            1977     1991      +14
- Partials           112      116       +4

Impacted Files
Coverage Δ

...ackages/element-lib/src/adapters/database/index.js
100% <ø> (ø)
:arrow_up:

packages/element-lib/src/sidetree/getNodeInfo.js
50% <ø> (+10%)
:arrow_up:

...nts/SidetreeBatchFile/SidetreeBatchFile.stories.js
0% <0%> (ø)
:arrow_up:

...nts/SidetreeOperation/SidetreeOperation.stories.js
0% <0%> (ø)
:arrow_up:

packages/element-app/src/services/sidetree.js
0% <0%> (ø)
:arrow_up:

...s/SidetreeAnchorFile/SidetreeAnchorFile.stories.js
0% <0%> (ø)
:arrow_up:

...ckages/element-lib/src/sidetree/getTransactions.js
100% <100%> (ø)
:arrow_up:

...s/element-api/src/express/routes/sidetree/index.js
65.57% <100%> (ø)
:arrow_up:

...nt-lib/src/adapters/database/ElementRXDBAdapter.js
68.29% <40%> (-17.92%)
:arrow_down:

...lement-lib/src/adapters/storage/storage-manager.js
58.69% <60%> (-26.68%)
:arrow_down:

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1a0418...465799f. Read the comment docs.


build error

Before firing issue, make sure you figured out the following common questions.
PLEASE DO SEARCH FIRST.

Check your -key xxx for at least 3 times, MAKE SURE both sides share the same secret.
-nocomp, -datashard, -parityshard,  -key, -crypt must be the same on both side.
Did you correctly set the -target on the server side?
MAKE SURE telnet target port on your server successful(don't ask me why couldn't).
Does your firewall allows UDP communications? (including your ISP Cable-Modem)
Are you using the same version for both client & server

yes

Are you using the latest release?

yes

Which OS do you use?

windows 10 64 bit

Which end for this issue related to, client or server?

yes
github.com/xtaci/kcptun/server
.\main.go:393: kcp.DefaultSnmp.Header undefined (type *kcp.Snmp has no field or method Header)
.\main.go:397: kcp.DefaultSnmp.ToSlice undefined (type *kcp.Snmp has no field or method ToSlice)
.\main.go:400: kcp.DefaultSnmp.Reset undefined (type *kcp.Snmp has no field or method Reset)
github.com/xtaci/kcptun/client
.\main.go:475: kcp.DefaultSnmp.Header undefined (type *kcp.Snmp has no field or method Header)
.\main.go:479: kcp.DefaultSnmp.ToSlice undefined (type *kcp.Snmp has no field or method ToSlice)
.\main.go:482: kcp.DefaultSnmp.Reset undefined (type *kcp.Snmp has no field or method Reset)

go get -u github.com/xtaci/kcptun/client     to update dependency

thank fixed


MDTextField not showing left icon when both icons are defined

Description of the Bug
MDTextField not showing left icon when both icons are defined
Code and Logs
from kivymd.app import MDApp
from kivy.lang import Builder

kv = '''
MDTextField:
	icon_left: 'lock'
	icon_right: 'eye-off'
'''

class MainApp(MDApp):
    def build(self):
        self.root = Builder.load_string(kv)

MainApp().run()

Screenshots

Versions

OS: Debian 12.0
Python: 3.11.2
Kivy: 2.2.1
KivyMD: 1.1.1

The issue is deprecated due to the new API of the KivyMD library 2.0.0 version


Clean up governing_method and method in CandidateSpaces

Codecov Report
Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (f9a06d4) 57.58% compared to head (37f9723) 57.90%.

Files
Patch %
Lines

petab_select/candidate_space.py
80.00%
2 Missing :warning:

Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #73      +/-   ##
===========================================
+ Coverage    57.58%   57.90%   +0.32%
===========================================
  Files           14       14
  Lines         1490     1480      -10
===========================================
- Hits           858      857       -1
+ Misses         632      623       -9

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Use onlyRole instead of only member

https://github.com/EBOGDAO/og-dapp/blob/0a2e2ecfae21dc4677f6c4cc6a17992286c2f362/contracts/Agreement.sol#L43-L46
You should use the onlyRole() modifier from OZ access control, rather than implementing your own onlyMember() modifier.
Use onlyRole("OG") anywhere that you have used onlyMember().

Issue is addressed in PR: https://github.com/EBOGDAO/og-dapp/pull/12
Tested on Rinkeby:
0xab5cAA579410Dd0eCfbB7dd11759350BE2d01A93
won't close until merged


sbclPackages.nyxt-gtk: 3.11.2 -> 3.11.3

Description of changes
Release note: https://nyxt-browser.com/article/release-3.11.3.org

Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 290404 run on x86_64-linux 1

2 packages built:

nyxt
sbclPackages.nyxt


Test for the download endpoint

Requires: https://github.com/SUSE/spacewalk/pull/401 because it uses simple signed tokens using the server secret directly without any extra key derivation.

otherwise this looks good to me :+1:


GDScript: enable type checks on release mode

Also make builtin GDScript functions report return type as Variant in release so type is converted when needed.
This might have a small performance impact on release for loading times (since now it needs to type-check during parsing) and in some assignment cases (since it might need to convert values to the correct type).
I think this is safe but it would be good to do some heavy testing with release builds to make sure nothing breaks.
Fix #24035

Let's merge to have some broad testing as early as possible.

Thanks!


test: reduce variety on node sku

az vm create uses --size=Standard_DS1_v2 by default.
We use Standard_D16ds_v5 in node image build.
This should reduce required node family variety.  Hopefully reducing likelihood of capacity issues.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>0
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 71.021%

Totals

Change from base Build<PHONE_NUMBER>4:
0.0%

Covered Lines:
2566

Relevant Lines:
3613

💛  - Coveralls


[ISSUE #2678] [Enhancement] Method appears to call the same method on the same object [redundantly[AsyncHTTPPushRequest]

Fixes #2678 .
Motivation

This pr will fix the ISSUE #2678

Modifications
Describe the modifications you've done.
IPUtils.getLocalAddress() were being called multiple time in same method
i have  assign the response to the local variable and used it .
Documentation

@dilraj-vyas please fix the ci check error


Makefile: Do not rely on git in bpf build

Tarball builds file in the daaemon/Makefile::go-bindata target because
it relies on git ls-files. This replaces that invocation with a find | sort to avoid this. It also makes the bpf sha slightly more stable.
This is definitely less nice than the ls-files, since if we introduce a new file we also need to add it to this list. Still, I don't anticipate that happening too often.

I remember that we moved from find to git ls-files but I'm struggling to remember why we did that.

So we wanted to remove the bindata pollution from the git logs previously, but to still be able to track the changes we kept the checksum in the sha file. We are using git ls because that way we are only including what has already been checked in to the version control which should reduce the mismatch between developer environment. IMHO this patch should be dropped and we should continue using git ls and people building should cover the required dependencies. The version number claimed to be unstable here is not an issue because we are not enforcing it. If someone ends up checking in with a wrong version we can still catch it during the review which is the point with the version number.
@borkmann what do you think?

@aanm I don't see any other comments from you.
@scanf Yeah, all schemes I can think of to get that list are more onerous than simply checking a file into git. The lowest touch change I can think of would be to generate the file list as part of building the apply-bindata Make target. This would keep the git usage, but decouples the build from git (at least here). What do you think?
This was motivated by someone following our build-from-source instructions and failing. I can update those instead although it does mean we cannot distribute source tarballs anymore, since they're unusable. I think the change for that is simply to tell @tgraf to stop producing them :)

I've rebased this (which was trivial). I tried to build in the file list as a manifest in bpf.sha and it became quite frustrating to read/manage. Still, a manifest in bpf.sha, generated during apply-bindata and used directly by go-bindata would solve the issue of the tarball builds being broken, but keep the property we have today.
I can do that but I'll wait on @borkmann to opine.

I think it would be good to have the following workflow: contributors to the project will use git to make changes to the repo. When they make changes to bpf/ then git ls-filescould include all the files that are included in the sha into daemon/bpf.sha. Then the sha is calculated from walking/processing this list of files.
Once we ship tarballs and we're in a non-git environment, then we can double check bindata by walking that list in bpf.sha again and generating the top level hash from it. This way we can support also non-git users and make sure to cover all files in both cases.
It's also a more robust workflow to not accidentally include untracked files by accident when we update bindata, so it might be a good compromise to support both.

Righto, fixed up. The manifest variable in bpf.sha is a little unwieldy, but this is the simplest scheme. The SHA is not changed, since it was over the bindata.go file and that doesn't change.
@scanf @borkmann what do you think of this?


Updating index policy via Azure portal no longer works?

The screenshot for guidance about Azure Portal needs to be updated : https://docs.microsoft.com/en-us/azure/cosmos-db/how-to-manage-indexing-policy#use-the-azure-portal

Main issue is that when I change the policy, it seems like it is saving but then it reverts back to what it was.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f1c7d0e0-b932-085e-6816-0b2219a1f37b
Version Independent ID: b463dc0b-313c-d90a-b8aa-c2b64004f812
Content: Manage indexing policies in Azure Cosmos DB
Content Source: articles/cosmos-db/how-to-manage-indexing-policy.md
Service: cosmos-db
GitHub Login: @ThomasWeiss
Microsoft Alias: thweiss

@aschip Thank you for bringing this to our attention. We will work with the content team to update the documentation as necessary.

Hi @aschip. The reason you didn't see a change in the indexing policy is because the original and updated indexing policy in the video are the same. The original indexing policy uses our new indexing layout and the updated indexing policy uses our old indexing layout (but the behavior is equivalent so we don't change anything). Properties such as kind, dataType, and precision are no longer required to be explicitly set and you can omit them from your indexing policy entirely. This is documented here: https://docs.microsoft.com/en-us/azure/cosmos-db/how-to-manage-indexing-policy#indexing-policy-examples

@timsander1 aah interesting, sorry I missed that  😄

@aschip looks like this issue is resolved. we will close it now.
#please-close


Update documents

Update Vim version to 8.2 (or 82).
Remove description about old Windows. (We have already dropped support
for Windows 2000 or earlier.)
Update some parts from #5397:

gui_w32.txt: "short form" means "MS-DOS form", not "MS-Windows form".
BTW, it seems that it is not applicable to the recent Windows
version.
insert.txt: add "On non-Win32 systems" back.
options.txt: remove 2k/XP.
printer.txt: add "previewer" back.
term.txt:

Remove about pc_term. It is for MS-DOS only.
:mode with argument doesn't work anymore.
Add "MS-Windows" back for 'mousetime'.

options.txt:

Use cmd.exe instead of command.com.
Update the default value of 'shellpipe' on Windows.

usr_44.txt: remove description about compatibility with Vim 5.  Such
codes have been removed from runtime files.
usr_90.txt:

We don't have separate source archives anymore.
Recent GNU tar automatically detects the archive type, so normally
tar xf filename is enough.
MSVC is not expensive now.

vi_diff.txt:

Remove MS-DOS, Windows 3.1/95, OS/2 and Risc OS.
No need to mention long file names nowadays.

I'll include it, thanks.


Assembly versioning has regressed in 4.1.2

Using NLog 4.1.0 the assembly version was <IP_ADDRESS>.  In 4.1.2 the assembly version has reverted to <IP_ADDRESS>.  This causes runtime binding failures when you have different projects referencing 4.1.0 and 4.1.2. It should just work but because the assembly version regressed back the assembly binding doesn't work properly.

Yes we did that on purpose. See #921 and latest news post.
It's only trouble if you upgrade from 4.1.0.
We don't think there is an easier way without breaking other libs build on 4.0 :(

PS:
If the assembly version of 4.1.2 was <IP_ADDRESS>, you had the same problems. The only solution is to keep the assembly version the same in NLog.

How would this work in web.config with NLog 4.1.2?

and

How would this work in web.config for NLog 4.1.2?
 <common>
   <logging>
     <factoryAdapter type="Common.Logging.NLog.NLogLoggerFactoryAdapter, Common.Logging.NLog40">
       <arg key="configType" value="INLINE" />
     </factoryAdapter>
   </logging>
 </common>

and
 <runtime>
   <assemblyBinding xmlns="urn:schemas-microsoft-com:asm.v1">
     <dependentAssembly>
       <assemblyIdentity name="Common.Logging" publicKeyToken="af08829b84f0328e" culture="neutral" />
       <bindingRedirect oldVersion="<IP_ADDRESS>-<IP_ADDRESS>" newVersion="<IP_ADDRESS>" />
     </dependentAssembly>
     <dependentAssembly>
       <assemblyIdentity name="NLog" publicKeyToken="5120e14c03d0593c" culture="neutral" />
       <bindingRedirect oldVersion="<IP_ADDRESS>-<IP_ADDRESS>" newVersion="<IP_ADDRESS>" />
     </dependentAssembly>
 </runtime>

Just change old version <IP_ADDRESS> to <IP_ADDRESS>
So
<runtime>
   <assemblyBinding xmlns="urn:schemas-microsoft-com:asm.v1">
     <dependentAssembly>
       <assemblyIdentity name="Common.Logging" publicKeyToken="af08829b84f0328e" culture="neutral" />
       <bindingRedirect oldVersion="<IP_ADDRESS>-<IP_ADDRESS>" newVersion="<IP_ADDRESS>" />
     </dependentAssembly>
     <dependentAssembly>
       <assemblyIdentity name="NLog" publicKeyToken="5120e14c03d0593c" culture="neutral" />
       <bindingRedirect oldVersion="<IP_ADDRESS>-<IP_ADDRESS>" newVersion="<IP_ADDRESS>" />
     </dependentAssembly>
 </runtime>

That's it!

Closing this dup


Add chat tab

I've been wanting to see a chat interface in nat.dev for a while and decided to try to push this over the line. Big thanks to @max for the excellent scaffolding.
This adds a chat tab to open-playground integrated with AI completions. It also integrates with the history sidebar so that you can refer back to old conversations.
I'm not a frontend expert so the css might be a bit rough around the edges. I also didn't fully flush out the typescript typings that max had started. I figured a minimally working chat tab was better than none, but let me know if there's anything you'd like to see added/changed as a part of this PR.
In the future it might be cool to add:

A "new chat" button in the history sidebar(for now, just refresh the page).
A button to show/hide the chat history.
The ability to edit a previous message and rerun the completion on an old prompt.
Logos/Avatars for the AI models and the user.
Syntax Highlighting for markdown rendered code.
Threads to allow multiple models to answer the same question.
Some type of recursive summarization in case the conversation goes on past the context window.

@max would love your feedback and blessing if you get a chance to take a look

@csaroff Would you mind coming on Discord?


Resolution is always reset to 100%

When I change the resolution on the server side to s.th. different from 100% ("Video" tab) , it is always reset to 100% when I restart ALVR or reboot the server. All other setting changes (e.g. encoding bandwith or encoder) are preserved when I reboot. Is this intended behavior or a bug?

It is a bug. I will fix it.

I think I have a fix for that, but cannot test it (I have no working VS 2015 environment). Shall I still send a pull request?

Thank you. But I could fix that.
The fix will be included in next release.

@polygraphene
awsome!

any news about this fix?

When I change the resolution on the server side to s.th. different from 100% ("Video" tab) , it is always reset to 100% when I restart ALVR or reboot the server. All other setting changes (e.g. encoding bandwith or encoder) are preserved when I reboot. Is this intended behavior or a bug?

hey man. iguess it was never fixed but thx anyways. Have anyone of you guys figured it out yet. Please leave a link (if any for solution) below. Thanks man.

Thank you. But I could fix that.
The fix will be included in next release.
we r missing u


support multiple usernames / emails

Why

I have usernames (or a guess of usernames) from multiple sources github, twitter, etc ... I want to pass them all to unavatar because I may not know which are real
I have multiple emails for a user, unavatar may find some matches for some but not others

How
use comma separated list of names to find first match
<img src="https://unavatar.now.sh/:username1,:username2,:username3,email1,email2" />

this could also apply to emails!

I added at v1.2.0 the ability to disable fallback avatar.
Now have the right avatar from a list of usernames or emails is so easy 🙂
'use strict'

const got = require('got')
const pAny = require('p-any')

const unavatar = async username =>
  got(`http://localhost:3000/twitter/${username}?json&fallback=false`, {
    json: true
  }).then(res => res.body)

const usernames = ['oadsopadk', 'oaksdpoksadpokaopd', 'kikobeats']
const promises = usernames.map(username => unavatar(username))
pAny(promises).then(json => console.log('done', json.url))

nice 👏


OpenAPI 3.0 Callbacks are no longer shown

Callbacks are not shown anymore as it was in previous versions.
Even with parameter:
show-components="true"
They're not longer shown

I can see it working here https://mrin9.github.io/RapiDoc/examples/callback.html


Bug: Ingress with TLS

Dear maintainers,
First of all, thanks for this library, it's very helpful to reduce the helm boilerplate. It seems there is a small issue with ingress templating.
The hosts section is not correctly rendered. The following snippet is the input
objects:
    ingress:
      frontend:
        enabled: true
        rules:
          frontend:
            host: _HT*hull.config.specific.ingress.host
            http:
              paths:
                standard:
                  path: /
                  pathType: Prefix
                  backend:
                    service:
                      name: frontend
                      port:
                        name: http
        tls:
          frontend:
            hosts:
              - _HT*hull.config.specific.ingress.host

the output is then
...
 spec:
  rules:
  - host: workspace.qualicoat.test
    http:
      paths:
      - backend:
          service:
            name: release-name-workspace-frontend
            port:
              name: http
        path: /
        pathType: Prefix
  tls:
  - hosts: foo.com
    secretName: release-name-workspace-foo.com

however, the tls section of the output should be
  tls:
  - hosts:
     - foo.com
    secretName: release-name-workspace-foo.com

Or am I overlooking something?

Hi @snowping,

First of all, thanks for this library, it's very helpful to reduce the helm boilerplate.

Thank you for using it!

I am sorry, it seems it's only an issue when I use a reference like _HT*hull.config.specific.ingress.host as a host.

No worries, please feel free to raise an issue even if it resolves itself, helps me understand problems users face.

After some digging I could solve the issue using: ...

Great that you found a working approach to solve your problem! Tells me there is at least some flexibility in case something doesn't work out directly or intuitively.
Concerning the initial problem I think there are a couple of valid ways to solve your case of filling up the hosts list with one (or multiple) referenced entries from hull.config.specific - your solution being one of them.
Here is some explanations:
First of, your solution which is to put a _HT-prefixed transformation as first array element to hosts:
              hosts:
                - _HT ...

is by now eqivalent to directly using _HT ... as value:
              hosts: _HT ...

Any value to a key (below hull.config or any hull.object instance key) is scanned for being a HULL transformation (starts with _HT) and processed accordingly if this is detected.
If you don't have a string starting with _HT as a value but an array type instead (as in your solution), you hit the case where we check whether exactly the first item of an array matches a transformation (again starts with _HT). If yes the transformation is also done and it is expected to deliver the full array as a result same as above.
The checking of the first array item for transformation signifier is by now more a compatibility mode that only applies if the value type in your spec is an array. Reason is that initially the HULL schema did not allow to have _HT-prefixed strings used everywhere and hence where the schema demanded an array type value you would have used the "array-way" of triggering the transformation as described above. There exists a similar compatibility mode for dictionaries as described here.
These days this limitation is gone, you can put _HT-prefixed transformations almost anywhere directly as a string value and it should work given your used transformation provides a valid result of the expected type.
So regarding the transformation result type, since here you need to create an array as a value of hosts: you need to make sure your transformation returns an array too,  With _HT![{{ (index . "$").Values.hull.config.specific.ingress.host }}] you did that nicely by wrapping the single referenced entry  to an array by putting the [ and ] around it. Works.
If you had multiple individual entries you wanted to combine you need to seperate them with , like this:
            hosts: _HT!
            [
                {{ (index . "$").Values.hull.config.specific.ingress.host_one }},
                {{ (index . "$").Values.hull.config.specific.ingress.host_two }},
              ]

A potential modeling alternative could be to reference an array of hosts like this:
hull:
 config:
   specific:
     ingress:
       hosts:
         - foo.com
         - bar.com

in which case the _HT* way of referencing the array directly maintaining its type would work:
            hosts: _HT*hull.config.specific.ingress.hosts

or again in compatibility mode:
            hosts:
              - _HT*hull.config.specific.ingress.hosts

_HT* can be very helpful because it detects the source fields type (string, int, bool, array, dictionary) and takes the required steps to copy the source fields value maintaining the correct source type. This can be more complicated using _HT! where more flexiblity exists but the handling is more complex, e.g. to correctly reference and copy the value of an array or dictionary field you need to employ a range command  and copy the values from the source as shown above.
Whether that modeling suggestion is an better or worse alternative to have an array as source depends on your preference and chart design.
Last remark:
With arrays in HULL it is only possible to transform an array with something returning the arrays full value, not the values of individual items. Deep nesting of transforming arrays that may be children of other arrays or similar is unfortunately out of scope for what can be technically done with HULL.  In my experience it was however always sufficient to be able to transform an array completely and create the desired result within your transformation.

Here is a test values.yaml covering the various approaches mentioned. It makes no sense functionally and just denonstrates the discussed cases.
You can test it out by downloading latest hull-demo and running helm template -f <saved-snippet> hull-demo-1.28.1.tgz against it:

hull:
  config:
    specific:
      ingress:
        host_one: foobar.com
        host_two: barfoo.com
        hosts:
         - foo.com
         - bar.com
  objects:
    ingress:
      frontend:
        enabled: true
        rules:
          frontend:
            host: _HT*hull.config.specific.ingress.host_one
            http:
              paths:
                standard:
                  path: /
                  pathType: Prefix
                  backend:
                    service:
                      name: frontend
                      port:
                        name: http
        tls:
          test1: # create array with single entry in compatibility way
            hosts:
              - _HT![{{ (index . "$").Values.hull.config.specific.ingress.host_one }}]
          test2: # create array with single entry in standard way
            hosts: _HT![{{ (index . "$").Values.hull.config.specific.ingress.host_one }}]
          test3: # reference array with two entries in compatibility way
            hosts:
              - _HT*hull.config.specific.ingress.hosts
          test4: # reference array with two entries in standard way
            hosts: _HT*hull.config.specific.ingress.hosts
          test5: # reference array with two entries by copying entries one by one
            hosts: _HT!
              [
              {{ range $item := (index . "$").Values.hull.config.specific.ingress.hosts }}
              {{ $item }},
              {{ end }}
              ]
          test6: # combine all fields from array and individual items
            hosts: _HT!
              [
              {{ range $item := (index . "$").Values.hull.config.specific.ingress.hosts }}
              {{ $item }},
              {{ end }}
              {{ (index . "$").Values.hull.config.specific.ingress.host_one }},
              {{ (index . "$").Values.hull.config.specific.ingress.host_two }}
              ]

Hi @gre9ory
Awesome! thank you for the explanation and further examples.  That helps me a lot.


Crash EXC_BAD_ACCESS KERN_INVALID_ADDRESS

Just got this crash from Crashlytics, unfortunately I don't know how to reproduce it, and the stack trace doesn't seem so useful. Any idea?
Crashed: com.vluxe.starscream.websocket
EXC_BAD_ACCESS KERN_INVALID_ADDRESS 0x61746572809a57f1

0  libobjc.A.dylib                0x181c49b9c objc_msgSend + 28
1  CoreFoundation                 0x18257a25c _inputStreamCallbackFunc + 56
2  CoreFoundation                 0x182521bc0 _signalEventSync + 192
3  CoreFoundation                 0x1825960a4 ___signalEventQueue_block_invoke + 24
4  libdispatch.dylib              0x18201d4bc _dispatch_call_block_and_release + 24
5  libdispatch.dylib              0x18201d47c _dispatch_client_callout + 16
6  libdispatch.dylib              0x1820294c0 _dispatch_queue_drain + 864
7  libdispatch.dylib              0x182020f80 _dispatch_queue_invoke + 464
8  libdispatch.dylib              0x18202b390 _dispatch_root_queue_drain + 728
9  libdispatch.dylib              0x18202b0b0 _dispatch_worker_thread3 + 112
10 libsystem_pthread.dylib        0x182235470 _pthread_wqthread + 1092
11 libsystem_pthread.dylib        0x182235020 start_wqthread + 4

Yeah that is pretty ambiguous 😞. It appears to be a crash when the dispatch callback is run by NSStream. It really could be anything crashing the application and the WebSocket object is causing the crash because it thinks the WebSocket object is valid and it isn't. I would check for race conditions to the WebSocket object as Starscream isn't "thread safe" and shouldn't be called from multiple threads. Also I would check and ensure the WebSocket isn't getting over released and a zombie as that could cause this too. I know those are pretty broad suggestions, but unfortunately we don't have much to go off. Best of luck!


Added backup and restore instructions

In reference to https://github.com/inventree/InvenTree/issues/1281

Ta


Lightshouse Accessibility Test Fails due to meta viewport attribute

What is the motivation for adding / enhancing this feature?

in the current 1.12 branch the lighthouse test for accessibility has a problem with the viewport attribute in relation to zooming:

What are the acceptance criteria

maximum-scale should be set to 5

[ ] Run lighthouse test on demo site and 100% accessibilty score

Can you complete this feature request by yourself?

[ ] YES
[ ] NO

Which Release Cycle state this refers to? Info for developer.
Pick one option.

[x] This is a normal feature request. This should be available on https://test.storefrontcloud.io and then after tests this can be added to next Vue Storefront version. In this case Developer should create branch from develop branch and create Pull Request 2. Feature / Improvement back to develop.
[ ] (Pick this option only if you're sure) This is an important improvement request for current Release Candidate version on https://next.storefrontcloud.io and should be placed in next RC version. In this case Developer should create branch from release branch and create Pull Request 3. Stabilisation fix back to release.
[ ] (Pick this option only if you're sure) This is a critical improvement request for current Stable version on https://demo.storefrontcloud.io and should be placed in next stable version. In this case Developer should create branch from hotfix or master branch and create Pull Request 4. Hotfix back to hotfix.

Additional information

actually i think its the bug in the meta package: https://github.com/dequelabs/axe-core/pull/2238

@simonmaass can you create a PR with a fix please?

Marking this as closed since 6.1 has shipped with these fixes in https://github.com/GoogleChrome/lighthouse/pull/10986
as soon as 6.1 is release on web.dev the accessibility score should work again


feat:  Add new client parameters: encoding

If there are non-ASCII characters in openapi (eg: https://v1.api.tttt.one/openapi.json)
Garbled characters may appear in the generated client file.

To this end, add encoding parameter to cli，Similar problems can be ended by --encoding=utf-8

maybe utf-8 should be our default encoding anyways?

Agreed.

Using an enum of choices would be better than an arbitrary string here

I don't think there is any built in enum with available encodings, and it's probably possible to register different codecs somehow. I don't think we want to be in the business of trying to maintain or restrict a list, we support whatever Python supports.
We could, however, add some validation here using something like codecs.getencoder to provide a useful error message to the user instead of just crashing when writing if the encoding is not supported.

In general, we only use UTF-8, but we don't know whether users will use other codes，

if encoding is not specified the encoding used is platform dependent

May user want the operating system to decide codecs, need pass a None to encoding,
What bothers me is that I haven't found a way to use the default value to gracefully deliver  None
Maybe my idea is wrong,  user need not use the None

May user want the operating system to decide codecs, need pass a None to encoding,

I think the more obvious behavior to the user is to explicitly set an encoding default (UTF-8). I can't think of a scenario where having the system decide the codec is sustainable or reproducible. At least for me, I tend to generate clients in CI after testing locally. If CI and local had different system codecs it would be failing without me knowing why which could be frustrating.

Hi, @dbanty , I know where our differences are.
Now, my way of using it is to move the generated folder directly into the existing test project.
So I want the client's file code to be consistent with the original file code of the test project -- determined by the operating system
Is the right way to use it is to think of the client as a separate Python package? Only import and call, should not be modified
If so, then UTF-8 is very appropriate.

Hi, @dbanty , I know where our differences are.
Now, my way of using it is to move the generated folder directly into the existing test project.
So I want the client's file code to be consistent with the original file code of the test project -- determined by the operating system
Is the right way to use it is to think of the client as a separate Python package? Only import and call, should not be modified
If so, then UTF-8 is very appropriate.

@dongfangtianyu there isn't necessarily a right or wrong way to use the package, however if I had to guess I would think most people use the client as a standalone python package and don't edit it much. That being said, obviously you are free to use it how you please and we aim to support all ways of using the project.
I do think utf-8 encoding makes sense as a default - it is incredibly common and will work in 99% of use cases + fixes issues such as yours without any consequence for users who don't explicitly need utf-8. Worst come to worst a user can specify their own encoding if necessary thanks to this PR you've made!


xdg-open is not working as expected

When using tmux-fingers to open files it does not open the correct application. I have setup xdg-open to open vim for plaintext files and this works correctly when I run xdg-open somefile.txt, but when I try to open the same file from tmux-fingers it opens in the browser. I see that the actual command executed by tmux-fingers is printf "somefile.txt" | MODIFIER=ctrl HINT=v  xargs xdg-open. This command also does what it is supposed to when I run it on the command line manually, but apparently not when tmux-fingers runs it.

can you try in latest version? 🤔


Add how to play in README

Added how to play in readme. Let me know if any changes or corrections needed. :)

With pleasure, I'll do today.
Alexandria @.***>, 7 Eki 2021 Per, 06:11 tarihinde şunu
yazdı:

@.**** commented on this pull request.
Looks good!
Can you add one more line that says something like "Click the timer box to
stop it from bouncing" ?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Alexandria/match-three-game/pull/30#pullrequestreview-773399762,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALOW5DG2PEFCRY3K47RAA6LUFUFU7ANCNFSM5FP2XWZA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

I've added "Click the timer box to stop it from bouncing." to how to play instructions.


Props not rendering in (view:source)

In my application on the localhost server: 3001. cra-universal do not render my data that I get from the server. I need to fix this for SEO.

You might take a look at https://github.com/antonybudianto/cra-universal/tree/master/packages/%40cra-express/redux-prefetcher

The demo https://github.com/antonybudianto/cra-universal/tree/master/packages/demo

I do not use the redux what to do in this case?

Right now I only have solution for redux + react-router, I'm open for PR if you have any unopinionated solution

I found https://github.com/jaredpalmer/react-router-nextjs-like-data-fetching, I think this is good, not using Redux

Right now I'm developing the new router-prefetcher https://github.com/antonybudianto/cra-universal/tree/new-router-prefetcher, but will release much later...
For now you can follow Jared's repo, I've tried and it works well.

For this demonstration there is no need to install the framework razzle? I did not really understand how to use it in my project. Maybe your have example for this plugin?

I'll use the react without the redux and I'll be very grateful for the example)

The example is within https://github.com/antonybudianto/cra-universal/tree/new-router-prefetcher branch, you can check the packages/demo


[FLINK-3569] fix test cases that expect a different working directory

All the IT cases executed after shading now have the target directory as working directory.

I think it is fixed now. The YARN test run in test scope and are not shaded...

Looks good, merging this...

This has been merged into master (1.1.x) and release-1.0 (1.0.x).
@mxm Can you close this? (was not autoclosed)

Sure. Thanks for merging!


readBlock fix to work with hic version 6

Changed struct.unpack params to work with older hic versions. Also, some whitespace changes were automatically made by my py linter.
python/straw.py lines 323-325.

Thanks!


Updated README with clearer instructions

Pull Request Description
Changes Made

Revamped the README for the incredible GOBARD Go package to elevate its user-friendliness, clarity, and overall swagger.
Unveiled a sleek new format with a Table of Contents, showcasing distinct sections that celebrate the features, installation, configuration, and more.

Motivation and Context

With great joy and admiration for the GOBARD project, these changes aim to amplify the coolness factor of its documentation. The goal is to make it not just informative but downright delightful for anyone diving into the exciting world of GOBARD.

How to Test

This is more of a documentation shine-up rather than an under-the-hood tweak. Reviewers, put on your virtual sunglasses and bask in the improved readability and swagger of the updated README.

Screenshots

No paparazzi moments needed here. The README shines on its own.
Only terminal outputs to showcase the strength of this package

Related Issues

None, just felt the urge to give GOBARD's documentation a VIP treatment.

Checklist

[x] Conducted the README concert with local testing.
[x] The documentation is the rockstar it deserves to be.
[x] The code hits all the right notes, following the project's style guide.
[x] Left backstage passes (comments) for clarity.

Additional Comments

GOBARD is not just a project; it's an experience. These README tweaks are my humble contribution to making that experience even more enjoyable. Rock on!

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Hi There,

Hi There,
Can you please help me. Thank-you
Originally posted by @Er-Developer in https://github.com/BohdanNikoletti/SFaceCompare/issues/10#issuecomment-501561892

Hi. answered here


Create DC/OS package for httpbin

This would be another option for easily deploying httpbin - to a Mesosphere DC/OS cluster, by simply doing dcos package install httpbin.
I've already submitted a PR this - https://github.com/mesosphere/universe/pull/1003, though it's not merged yet.
I thought folks who follow this repo might be interested to know.

thanks for letting us know!

once it's deployed, we can add it to the official deployments list


Include tags.atomic_guid and tags.required_fields into ESCU

Is your feature request related to a problem? Please describe.
Could the team expose tags.atomic_guid and tags.required_fields in ESCU please?  That would help a lot track this important information into other apps that "augment" ES or directly via REST.
Describe the solution you'd like
For those fields to be included in the savedsearches.conf information in ESCU.
Describe alternatives you've considered
N/A
Additional context

We no longer maintain required fields, please refer to the data_source yaml file to find more information about the event!
atomic guid is now shipped in ss.conf : Example:
action.escu.atomic_red_team_guids = ["7e47ee60-9dd1-4269-9c4f-97953b183268"]


Blogifier Analytics

Improve the current analytics with a better design and a little more reports.
TODO:

[x] Add the list of pages with visits and visitors
[x] Change the chart to show data based on date

Renamed the "BarChartComponent.razor" to "AnalyticsComponent.razor".
Added some HTML for the list of pages for Analytics Widget on the dashboard.
Also, I've added comments to the AnalyticsComponent.razor file which explains how it should work.

I was working on this but @rxtur has finished it off.  on which branch you have merged, I would like to check out.

I was working on this but @rxtur has finished it off. on which branch you have merged, I would like to check out.

All development is done on dev branch, and later merged into main. Here is corresponding commit.

On the chart, an admin wants to know how many visits they had per day. not per post.
This is the same example but It's per month:
https://www.chartjs.org/docs/latest/samples/line/line.html

and if they want to see which page or post had more visits they can switch to the list. which we have it already.

On the chart, an admin wants to know how many visits they had per day. not per post.
This is the same example but It's per month:
https://www.chartjs.org/docs/latest/samples/line/line.html
and if they want to see which page or post had more visits they can switch to the list. which we have it already.

this visits still going to be counted on per post visits or when a customer opens any blogifier page, this will count in?
@farzindev

I wonder if a better option would be to add Google Analytics (can do this today) and the devs focus on other features?


Sentry

I'm good to merge this whenever you are.
You want some help putting that JS into the asset pipeline with your gem sometime in the future?

@schneems I've been thinking about it for sure.


Added alembic migration to include 'is_archived' attribute

Reviewer: @suzinyou
Estimate: ~10 minutes

Ticket
Fixes: N/A
Description
Goal
Previously approved PR (#297) was merged pre-maturely and caused a multi-head issue with alembic. The previous PR was reverted (#300 ), changes in main merged, and this new PR contains the updated main branch.
Changes

Added new alembic migration for is_archived attribute.
Updated ContentDB ORM for is_archived attribute.

Future Tasks (optional)
How has this been tested?

Manually by running upgrade/downgrade
Manually running make tests in core_backend before submitting PR

To-do before merge (optional)
Checklist
Fill with x for completed.

[X] My code follows the style guidelines of this project
[X] I have reviewed my own code to ensure good quality
[X] I have tested the functionality of my code to ensure it works as intended
[X] I have resolved merge conflicts

Will reopen with archive functionalities in backend API and updated tests.


@Alvarito050506 How's the SEO going?

Also at this point, we should just merge this since by the time it gets merged once everything is added, the info will be outdated lol

How's the SEO going?

Didn't continue it, it's usable and has better Discord integration though.

Also at this point, we should just merge this since by the time it gets merged once everything is added, the info will be outdated lol

I would say no, since we would confuse people (MCPIL vs MCPIL-R vs gMCPIL/MCPIL.java/MCPIL in HTML).

I would say no, since we would confuse people (MCPIL vs MCPIL-R vs gMCPIL/MCPIL.java/MCPIL in HTML).

Still if we don’t complete this soon it won’t be current.

Ok, should we merge?


Release 0.14.3

Signed-off-by: Adrien Gentil<EMAIL_ADDRESS>

Coverage decreased (-0.05%) to 82.193% when pulling fd2c47f9d05ee9bb6136e70620656702c2493182 on adriengentil:master into bad0c47c5bd1f9cc151041ab83cfd0d5c8bc82ce on criteo:master.


series.lines.label.backgroundColor stop working after setting lineHeight

Version
4.5.0
Steps to reproduce
see this
https://gallery.echartsjs.com/editor.html?c=x0318RjWm&v=1
What is expected?
lines label has yellow background
What is actually happening?
lines label has transparent background

This is not a bug, because lineHeight's value you have set was too small.  Try bigger number like 10 or 20.


Potential Future of Extensions

This is an idea for what the future of extensions could be like.
Scratch Children Properties
Scratch.blocks
Scratch.blocks could be an object containing functions that can be called to execute blocks. Vanilla Scratch blocks can be executed here (except motion, sound, and music blocks, as that could be annoying and unwanted to the user.)
Some blocks with large power over sprites or simply blocks that could do unwanted actions to the user could require permission from the user. Whether that be a simple confirm prompt or a custom popup, that part does not matter.
Scratch.extensions
Scratch.extensions.register
A class reference should be passed to this function, to load an extension into Turbowarp.
Main class's getInfo() configuration properties
Main Class's getInfo().allowExternal
The allowExternal is a boolean value that can control whether other extensions can use them via Scratch.blocks. If it is not specified, or is undefined, than it will default to true. If it is changed after the class is first called, then the changes are to be ignored.
Main Class's getInfo().visible
This property allows an extension to specify if it is visible to the user. This is useful for extensions meant to be used as dependencies for other blocks. Turbowarp is to check if it has changed every frame, and if it has, then the block's visibility is to be updated. If it is changed, it will not affect the blocks the user has already placed, but become invisible from the toolbar. If it is not specified, or is undefined, than it will default to true.
Main Class's getInfo().dependencies
This is an array full of URLs to extensions that this one depends on to function. For built-in extensions, it is simply the extension's name, with the first letter capitalized. If it is not specified, is undefined, or it is not an array-like object, it defaults to an empty array. If this extension has any dependencies, the user must be notified of the dependencies that will be installed with the extension they originally intended to install. Not only the name of this extension must be specified, but the URL must also be specified to the user so that a misleading name does not trick the user into installing a potentially unwanted extension. If it is a built-in extension, one that you might include in a project using the built-in "Choose an extension" menu, then the URL is not provided, and simply the name, with a note telling the user this is the legitimate scratch extension and not a misleadingly named one.

I think the extension system is borrowed directly from Scratch 3's unimplemented in vanilla experimental extensions system so there probably won't be new features exclusive to it.

It's still possible that it could be extended on just like many things have in turbowarp.

The most important thing to address is finding a safe way to execute arbitrary untrusted JS in the main thread. That's what needs to happen before there will be other improvements

The most important thing to address is finding a safe way to execute arbitrary untrusted JS in the main thread. That's what needs to happen before there will be other improvements

Okay.

Follow https://github.com/TurboWarp/scratch-gui/issues/633

Unsandboxed extensions are ready for testing https://extensions.turbowarp.org/
We currently want custom extensions to be fully self-contained, so one extension depending on another is not going to happen at this time.
Scratch.blocks is an interesting proposal, but unsandboxed extensions have complete access to Scratch internals anyways so that isn't necessary


feat(oracle11g):DBSchemaAccessor adapt to native oracle11g

What type of PR is this?
type-feature
module- object visual management
What this PR does / why we need it:
DBSchemaAccessor adapt to native oracle11g.
All Oracle ut tests have been supplemented, but they have been skipped in the github environment. Currently, Oracle only has a localut test environment, and there is no ut test environment on Github.
Which issue(s) this PR fixes:

Fixes #396
Special notes for your reviewer:

Additional documentation e.g., usage docs, etc.:

title of this pr may be 'feat(db-browser): make db-browser module adapt to oracle11g'

title of this pr may be 'feat(db-browser): make db-browser module adapt to oracle11g'

but this pr only make DBSchemaAccessor adapt to oralce11g, other jave classes like DBObjectEditor have not yet been adapted to oralce11g yet

title of this pr may be 'feat(db-browser): make db-browser module adapt to oracle11g'

but this pr only make DBSchemaAccessor adapt to oralce11g, other jave classes like DBObjectEditor have not yet been adapted to oralce11g yet

okay, current name is fine


[11.x] Fixes auto-discovery for commands outside of app's namespace

The goal of this PR is to fix the hardcoded app namespace in the Console Kernel.
At the moment adding paths from outside the app/ folder doesn't work at all.
        $this->load([
            __DIR__ . '/Commands',
            base_path('src/Modules'),
        ]);

The reason for that is that the Kernel assumes the namespace for the class to start with App.
I'm not sure if this should target 11.x or master.
For my selfish reasons, I'd want it out as soon as possible, but the "getAvailableNamespaces" command is a slightly modified version of a method copied from Application.
Preferably Application interface would be extended to allow listing of all available namespaces alongside the primary one. Lemme know which path is desirable and I'll adjust it.
I'll add tests after this gets green lighted.

Thanks for your pull request to Laravel!
Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.
If possible, please consider releasing your code as a package so that the community can still take advantage of your contributions!
If you feel absolutely certain that this code corrects a bug in the framework, please "@" mention me in a follow-up comment with further explanation so that GitHub will send me a notification of your response.


bug:

ERROR in node_modules/@angular/common/http/http.d.ts:81:22 - error NG6002: Appears in the NgModule.imports of AppModule, but could not be resolved to an NgModule class.
This likely means that the library (@angular/common/http) which declares HttpClient has not been processed correctly by ngcc, or
is not compatible with Angular Ivy. Check if a newer version of the library is available, and update if so. Also consider checking with the library's authors to see if the library is expected to be compatible with Ivy.
81 export declare class HttpClient {
Help

Can you delete node_modules and re-run npm install


right-click triggers ng-mouseleave?

Hi,
Looks like angular has an issue with Chrome 41.x.x firing ng-mouseleave on right-clicking the div that's involve. In the angular example https://docs.angularjs.org/api/ng/directive/ngMouseleave ... try to right click the button and see how the mouse-leave counter increment even if the mouse is inside the button.
This made a critical bug on divs/layers that's been hidden/shown using ng-mouseleave/ng-mouseenter ..

same behavior on Firefox 35.0.1.
Note that this bug was fine with Chrome 40.x.x

I think this is related to this:
https://code.google.com/p/chromium/issues/detail?id=450138
quote from a comment on the said link:
using http://www.rbyers.net/eventTest.html by right-clicking on the purple box.
Previously we'd get:
mousedown, mouseup, contextmenu, mousemove, mousemove (hover still active)
Now we get:
mousedown, mouseup, contextmenu, mousemove, mouseleave, mouseout (no hover)
This reproduces only on Windows for me (not Mac) which makes sense because Windows is the only platform where the context menu is shown on mouseup (the others show it on mousedown).

This looks like a Chrome bug. Hopefully it gets fixed soon.
@dgtlmonk The behavior is correct on Firefox as far as I can see.

Works now in Version 45.0.2429.0 canary


Postgres: Can not create role with migrate dev

Bug description
I need to create an additional database user root2 in my first migration. When I do the steps that I think are necessary, I get an Error querying the database: db error: ERROR: role "root2" already exists error.
How to reproduce

Create new Prisma project
Update connection string to valid URL
npx prisma migrate dev --create-only
Add CREATE ROLE root2 WITH LOGIN SUPERUSER PASSWORD 'prisma'; to migrations.sql and safe file
Run migration with npm migrate dev
Observe error:

PS C:\Users\piotr\throwaway\migrateRoleRepro> npx prisma migrate dev
Environment variables loaded from .env
Prisma schema loaded from prisma\schema.prisma
Datasource "db": PostgreSQL database "mydb", schema "public" at "localhost:5432"

Error: Database error
Error querying the database: db error: ERROR: role "root2" already exists
   0: migration_core::api::ApplyMigrations
             at migration-engine\core\src\api.rs:73

When running again, I get the same error for the shadow database:
PS C:\Users\piotr\throwaway\migrateRoleRepro> npx prisma migrate dev
Environment variables loaded from .env
Prisma schema loaded from prisma\schema.prisma
Datasource "db": PostgreSQL database "mydb", schema "public" at "localhost:5432"

Error: P3006

Migration `20210414183137_init` failed to apply cleanly to the shadow database.
Error:
Database error
Error querying the database: db error: ERROR: role "root2" already exists
   0: sql_migration_connector::flavour::postgres::sql_schema_from_migration_history
             at migration-engine\connectors\sql-migration-connector\src\flavour\postgres.rs:279
   1: sql_migration_connector::sql_database_migration_inferrer::validate_migrations
             at migration-engine\connectors\sql-migration-connector\src\sql_database_migration_inferrer.rs:88
   2: migration_core::api::DevDiagnostic
             at migration-engine\core\src\api.rs:95

Expected behavior
No error.
Prisma information
Environment variables loaded from .env
prisma               : 2.21.1
@prisma/client       : 2.21.1
Current platform     : windows
Query Engine         : query-engine e421996c87d5f3c8f7eeadd502d4ad402c89464d (at<EMAIL_ADDRESS>Migration Engine     : migration-engine-cli e421996c87d5f3c8f7eeadd502d4ad402c89464d (at<EMAIL_ADDRESS>Introspection Engine : introspection-core e421996c87d5f3c8f7eeadd502d4ad402c89464d (at<EMAIL_ADDRESS>Format Binary        : prisma-fmt e421996c87d5f3c8f7eeadd502d4ad402c89464d (at<EMAIL_ADDRESS>Default Engines Hash : e421996c87d5f3c8f7eeadd502d4ad402c89464d
Studio               : 0.371.0

Realized this also blocks me from further migrations :/

We probably want to document how to do this — technical solutions seem out of reach at the moment.

Marking it as a feature for now.

is there any update on fixing this, or adding workaround docs?

Also running into this issue. Although the new migration failed running \du shows the role exists.

I've got the same problem. Is there any workaround for that ?

We probably want to document how to do this — technical solutions seem out of reach at the moment.

Any documentation you can point to for this? Running into the exact same issue

In my understanding the problem is that a role is a global object - and when running migrate dev we test the migration history by applying it to a "shadow database". When that shadow database lives on the same server, the role also already exists and there is not IF NOT EXISTS or anything that could tell SQL to only create the role if it does not already exist.
Going from that, there are multiple possible workarounds:

DROP ROLE IF EXISTS the role first, then create it in your migration. (Not 100% sure this has no undesirable side effects)
Use a separate database for your shadow databases, similar to how described here: https://www.prisma.io/docs/concepts/components/prisma-migrate/shadow-database#cloud-hosted-shadow-databases-must-be-created-manually (Not 100% sure this really works long term)

Let us know if you try one of thees options and they actually work for you.

DROP ROLE IF EXISTS the role first, then create it in your migration. (Not 100% sure this has no undesirable side effects)

FWIW: I've attempted this, and it works until you actually use the role (e.g. grant anything to it). Then the DROP ROLE statement will fail: db error: ERROR: role "app_priviledged" cannot be dropped because some objects depend on it.

@tobilg TY. That'll do.
@janpio I have also attempted to run a separate shadow database and the same error occurs (I have checked that the shadow database is actually in use by listing the roles and seeing my new one added).


Direct support for Wiiware titles

I think we've talked about this but figured I'd make a proper issue.  Wiiware titles currently require manually extracting using a separate tool and then running this tool.  It'd be nice if we had direct support since even Dolphin can't extract files.

It's high on my list. ;)


Update README.md WIth my name

Related issue

What changes does this PR do?
Screenshots (If any)
Questions

closing due to inactivity


(With Iris/Indium/Starlight) - Game crashes when player takes damage from mobs

When taking damage from a cave spider, the game will stop moving, wait a bit, then crash. Removing Damage tilt did fix the issue, so I'm at least moderately sure it's a damage tilt issue.
EDIT: iirc the majority of 1.19.4 was performance updates, right? so maybe it's a ticking error because it's the wrong version (from my little knowledge the logs seem to hint at this), but I'm just surprised that if it's such a game-breaking error it wouldn't crash on launch.
On fabric loader 0.14.19
Mod List-
Damagetilt 0.1.2
Continuity 3.0 beta2
DistantHorizons 1.6.11a
FabricAPI 0.79.0
Indium 1.0.15
Iris 1.6.1
Journeymap 5.9.5
Lithium-fabric 0.11.1
modmenu 6.2.1
smooth swapping 0.8.1
sodium-fabric 0.4.10 build24
starlight 1.1.1
Log:
dtilitcrashlog.txt
Vid:
https://user-images.githubusercontent.com/49455179/234623926-b5c0316d-7439-4d25-b256-5168f75e6e88.mp4

If I'm not mistaken, damage tilt is re-added to 1.19.4 on its own, so you don't need the mod anymore!
Try removing the mod and seeing if damage is tilting your camera in the direction like it should

Ah, i'll try it right now, give me a moment.

That's strange, I just tested those 11 other mods on my end by themselves on 1.19.4, and it seems to be working.
Try spawning in a skeleton and having it hit you with an arrow, they're the best for testing it.
Also check the accessibility setting 'Damage Tilt', make sure it's 100%
If that still doesn't work then maybe something weird happened with the 1.19.4 install?

yeah, the install might be borked. I orignally had this issue on my laptop, and when I tried to transfer the mods and their settings over to a desktop, the quilt launcher just kept saying there was like no java executable that it could find, even when I literally put in in the folder with java lol. Eventually it simply decided it could find a javaw.exe it liked, because it began working,(Just copying the quilt-whateverlauncher.jar version always errored out, so it seems like it actually did work) but I hadn't readded damagetilt to that list as it broke other things in the past. I'll try this on my desktop tomorrow. Maybe on my laptop, through some stroke of luck it manages to launch, but might still be broken somehow. (I'll DEFINITELY make a copy cuz I don't want to deal with the installer bs again tho lmao) TLDR will attempt to verify game files, but quilt is weird lol.

Actually, If you want to try to recreate my issue, I've happened to already upload the directory to google drive, so I'll jus post it here.
Game DIR: https://drive.google.com/drive/folders/1VwpVkYdgvTk73pqwX_QhnKAtIz31_G3z?usp=sharing
DIR JVM ARGS :https://docs.google.com/document/d/175DQIjlSBfdoET1nLN83528O1riQLhOMGsrfC6dlFh0/edit?usp=sharing

same problem, how fix it?


CM3D2 part

I noticed "EngExtract.dll " didnt extract from CM3D2 part(経営切替).
Can u make it extrcact from cm3d2?
I tried CM3D2.SubtitleDumper.exe
But I got some different result that voice file name was added.

Greetings!
Could you perhaps elaborate a bit on what you want to try to achieve?
EngExtract (and i18nEx) is a tool that is intended for COM3D2. If you have CM3D2 linked to your game, EngExtract will also extract the CM3D2 scripts.
As for UI elements, extracting all of item descriptions, event names and yotogi skills requires looking through the game's .nei files and converting the Japanese listings into the ones the localisation manager can understand. There is already some info on how to translate part names and descriptions on the wiki, but I have plans on making some tools to do that as well.

Sorry too late..
When I played cm3d2 part in com3d2
I checked console log.
This files, D_QUE_0045.txt and M_ETC_0001 didnt exist script folder.
EngExtract didnt extract D_QUE_0045.ks from  CM3D2\Gamedata\script_personal001_2.arc.
Additionally I cant find GP2 UI key from console log like private mode.


Single 0a (line feed) logical selection crashes the extension

Reproduction: Load a file that has \r\n in it like package.json, then in the logical view, select just a single line feed (0a, decimal 10).  This crashes the extension.

@scholarsmate I haven't seen the extension crash anymore. Do we want to delete this ticket and create another for cleaning up some of the issues for representing 0x0a?


shade/lev fails to repeat same levels, after shade/line

Reported by Andrew Wittenberg on 18 Jun 2004 04:03 UTC
let a = {1,1} * ysequence({-.29,1.09})
can v
set v ul; shade/key a
set v ur; shade/lev a
set v ll; shade/line/key a
set v lr; shade/lev a
! first 3 plots have lev=(-.3,1.1,.1)
! last plot has lev=(-.3,1.2,.1)
Migrated-From: http://dunkel.pmel.noaa.gov/trac/ferret/ticket/904

Comment by<EMAIL_ADDRESS>on 14 May 2007 17:22 UTC
Fixed by setting the line overlay call in xeq_shade.F. When SHADE/LINE is called
this just makes a CONTOUR/OVERLAY call, but it was not set to re-use the contour
levels.  Here set IAUTOC = 0 and NLEV = NLEV2, and add code in PLOTZ so that
when levels are to be re-used we compute the line characteristics and # digits
to use in contour-lables, as these would not have been called by the previous
SHADE call.
Do the same setup in xeq_contour.F, setting IAUTOC = 0 and NLEV = NLEV2 for a
FILL/LINE call, even though the bug will not appear here as the same exact code
would be used to re-compute the contour levels. Might as well not repeat the
calculation however.
Fix in
fer/xeq/xeq_contour.F
fer/xeq/xeq_shade.F
ppl/plot/plotz.F

Attachment from<EMAIL_ADDRESS>on 18 Jun 2004 04:05 UTC
plot
REPLACE THIS TEXT WITH UPLOADED FILE ./attachments/TRAC_904_GIT_418/plot.gif


Provide details about missing packages when pulling from Central

If dependencies are missing in Central when pushing a package, it gives an error saying the package could not be pushed because dependencies were missing. Will it be possible to improve this error message to include which packages are missing as well? Then it'll be easy to identify the missing packages.
ballerina: unable to push package as there are dependencies of the package missing in the registry

Closing as this is fixed with https://github.com/wso2-enterprise/ballerina-registry/issues/1891


[Executor] Send error to app logs if starting a container fails

Send error to app logs if starting a container fails
Summary
Recently we noticed that when a container fails to start because it exceeds the env var size limit, the error is not logged in the app logs.
Staging app and tracing logs...
    This is not ideal, because you cannot know what went wrong until you go digging trough the rep and garden logs for the container. So having a more informative error sent to the app logs would help.
Diego repo
https://github.com/cloudfoundry/executor
Describe alternatives you've considered (optional)
PR

@klapkov Thanks for this proposal. I've deployed your changes, but not seeing the error show up in cf logs. Are you seeing an error show up? Can you please shared your reproduction steps?

Hello @winkingturtle-vmw, sorry for the late response. What I did is take one sample app and I generated a large file, larger than the limitation. I attached it to the app as an env variable and did cf push.

That's what I did too, but didn't see any errors. Can you please provide detailed step-by-step instruction with output snippet for what to expect instead.
Additionally, my understanding from @PlamenDoychev's comment is that this change will not make any difference regardless. Please correct me if that's wrong.

Hello @winkingturtle-vmw,
Again, sorry for the delayed response. Maybe there are some differences between our setups. If the SuppressLogOutput property is set to true, the log will not be sent. From what I understand, this is being set in the RunStep in the cloud_controller, but I am not sure when it is set to true and to false.
Here is how I reproduce the issue.

Take a sample application.
Add env variable in the manifest - I generated a very large string that is larger than 131kb and directly added it to the manifest.
 Maybe it is worth discussing if it should be like this anyway.

Hello @winkingturtle-vmw,
Do you have any feedback on this? Did you manage to reproduce it?

@PlamenDoychev @klapkov This is the command head -c 45000 <(base64 /dev/urandom ) I am running for generating a large text. I've noticed that when I bump the number from 45000 to 50000, the application is not getting pushed. I am not getting a staging error, this is failing for me at CF API/cloud_controller level.
My follow up questions:

Even 45000 bytes feels like a big number here. How are we surpassing this number in real life? what type of environment variables fits in this category?
Are you running a different command to generate this value? if so, can you please share that?
What is different about your setup than what we are testing with that that will allow this to proceed to a larger number?

Hello @winkingturtle-vmw,
I generate a large string with this script:
import random
import string

# Define the desired size in bytes (1 KB = 1024 bytes)
desired_size_kb = 140
desired_size_bytes = desired_size_kb * 1024

# Generate random letters to form the string
random_string = ''.join(random.choice(string.ascii_letters) for _ in range(desired_size_bytes))

# Print the length of the string to verify its size
print("Length of the random string (in bytes):", len(random_string))

# Write the random string to a file
with open('random_string.txt', 'w') as file:
    file.write(random_string)

print("Random string saved to 'random_string.txt'.")

Regarding the real life reason for this, we have received quite a lot of cases where someone exceeds this limit. I do not remember what exactly were those env variables.  Debugging this was harder, since there was no app log that indicated that the limit was exceeded. So you would need to dive in the logs of the hosting cell and find the error from the rep.
I wonder if step.model.SuppressLogOutput is set to true on your side. As I mentioned, this is set by the cloud controller and I am not sure when is it set to true and when to false. On our side, seems lime it is aways set to false. This is the only potential thing I see that could cause the error to be hidden.

Hi @winkingturtle-vmw,
The use case for this improvement is the following. On our platform we have applications which consumes ~30 services provided by the platform as well. Last year we had an initiative to secure the communication between the provided applications and services using best option possible. Some services implemented mTLS, some regular credential rotation with "blue-green" credentials, etc., hence a lot of x509 certificates and other credentials appeared in the VCAP_SERVICES env var as service credentials are injected there.
The problem is that sometimeс we receive requests from customers saying that their apps stop working (not being able to stage) out of the sudden without any changes into the code. While debugging such requests we noticed that actually some sort of cred rotation has happened or a new certificate has appeared which lead to exhaustion of the VCAP_SERVICE env var limit (which is by the way documented here: https://docs.cloudfoundry.org/devguide/deploy-apps/environment-variable.html#VCAP-SERVICES).
We have an idea and already working on RFC for long term solution for this problem, but until we trigger a discussion about the future we would like at lest to make the app developers live easier by providing them a meaningful error message.

@PlamenDoychev thanks for explanation of how this issue has come about. It makes more sense now why we are talking about this issue.
As for reproduction, since we seems to have different setup for our load-balancers and CF, I decided to shortcut CF and instead write a diego task to see how this will fix the issue.
I used @klapkov's script to generate a long string (140Kb) and created the following task.json
{
  "task_guid": "sleeping-beauty",
  "domain": "my-tasks",
  "rootfs": "preloaded:cflinuxfs4",
  "action": {
    "run": {
      "path": "/bin/bash",
      "args": [
        "-c",
        "echo sleeping-beauty.starting; sleep 60; echo sleeping-beauty.finished | tee /tmp/result"
      ],
      "user": "vcap",
      "suppress_log_output": false
    }
  },
  "env": [
    {
      "name": "MY_VAR",
      "value": "<my long string>"
    }
  ],
  "disk_mb": 128,
  "memory_mb": 1024,
  "cpu_weight": 50,
  "privileged": false,
  "log_source": "sleeping-beauty",
  "log_guid": "abc-123",
  "result_file": "/tmp/result",
  "legacy_download_user": "vcap"
}

I then installed log-cache-cli and ran cf tail "abc-123" -f. I am still not seeing failed-creating-process when I fetch the logs. Can you please modify or change the above task.json into something that will produce your expected error message.

Hello @winkingturtle-vmw
I tried running the same task as you on our side, but something in garden and silk brakes and I do not even reach the point where we start the container. I have attached a staging task that resulted in the error. I hope you can see something useful there.

@klapkov I went ahead and modified a staging task with the same long environment variable instead and seeing the argument list too long error regardless of this change. Are you seeing the same thing?

Merged executor PR. It will be released in the next version of diego-release.


[Bug]: InternVL2-26B infer error:Attempted to assign 7 x 256 = 1792 multimodal tokens to 506 placeholders

Your current environment

The output of `python collect_env.py`
Network isolation, unable to download

Python3.8
8*A10 GPU
Model:InternVL2-26B
vllm                              0.5.5
vllm-flash-attn                   2.6.1
torch                             2.4.0
torchvision                       0.19.0

🐛 Describe the bug
from dataclasses import dataclass
from typing import Literal

import torch
from PIL import Image

VLM_IMAGES_DIR = "vision_model_images"

@dataclass(frozen=True)
class ImageAsset:
    name: Literal["stop_sign", "cherry_blossom"]

    @property
    def pil_image(self) -> Image.Image:

        image_path = "image.jpg"
        return Image.open(image_path)

"""
This example shows how to use vLLM for running offline inference
with the correct prompt format on vision language models.

For most models, the prompt format should follow corresponding examples
on HuggingFace model repository.
"""
from transformers import AutoTokenizer

from vllm import LLM, SamplingParams

# Input image and question
image = ImageAsset("cherry_blossom").pil_image.convert("RGB")
question = "What is the content of this image?"

# InternVL
def run_internvl(question):
    model_name = "/home/tdj/model/InternVL2-26B"

    llm = LLM(
        model=model_name,trust_remote_code=True,
        gpu_memory_utilization=0.9,tensor_parallel_size=8
    )

    tokenizer = AutoTokenizer.from_pretrained(model_name, trust_remote_code=True)
    messages = [{"role": "user", "content": f"<image>\n{question}"}]
    prompt = tokenizer.apply_chat_template(
        messages, tokenize=False, add_generation_prompt=True
    )

    # Stop tokens for InternVL
    # models variants may have different stop tokens
    # please refer to the model card for the correct "stop words":
    # https://huggingface.co/OpenGVLab/InternVL2-2B#service
    stop_tokens = ["<|endoftext|>", "<|im_start|>", "<|im_end|>", "<|end|>"]
    stop_token_ids = [tokenizer.convert_tokens_to_ids(i) for i in stop_tokens]
    return llm, prompt, stop_token_ids

model_example_map = {
    "internvl_chat": run_internvl,
}

def main():
    model = "internvl_chat"
    if model not in model_example_map:
        raise ValueError(f"Model type {model} is not supported.")

    llm, prompt, stop_token_ids = model_example_map[model](question)

    # We set temperature to 0.2 so that outputs can be different
    # even when all prompts are identical when running batch inference.
    sampling_params = SamplingParams(
        temperature=0.2, max_tokens=64, stop_token_ids=stop_token_ids
    )

    # Single inference
    inputs = {
        "prompt": prompt,
        "multi_modal_data": {"image": image},
    }
    outputs = llm.generate(inputs, sampling_params=sampling_params)

    for o in outputs:
        generated_text = o.outputs[0].text
        print(generated_text)

if __name__ == "__main__":
    main()

here is my error stack trace
(VllmWorkerProcess pid=85388) ERROR 08-29 21:27:26 multiproc_worker_utils.py:226]   File "/root/anaconda3/envs/py3/lib/python3.8/site-packages/vllm/model_executor/models/utils.py", line 77, in merge_multimodal_embeddings
(VllmWorkerProcess pid=85386) ERROR 08-29 21:27:26 multiproc_worker_utils.py:226]   File "/root/anaconda3/envs/py3/lib/python3.8/site-packages/vllm/executor/multiproc_worker_utils.py", line 223, in _run_worker_process
(VllmWorkerProcess pid=85388) ERROR 08-29 21:27:26 multiproc_worker_utils.py:226]     raise ValueError(
(VllmWorkerProcess pid=85386) ERROR 08-29 21:27:26 multiproc_worker_utils.py:226]     output = executor(*args, **kwargs)
(VllmWorkerProcess pid=85388) ERROR 08-29 21:27:26 multiproc_worker_utils.py:226] ValueError: Attempted to assign 7 x 256 = 1792 multimodal tokens to 506 placeholders
(VllmWorkerProcess pid=85386) ERROR 08-29 21:27:26 multiproc_worker_utils.py:226]   File "/root/anaconda3/envs/py3/lib/python3.8/site-packages/torch/utils/_contextlib.py", line 116, in decorate_context
(VllmWorkerProcess pid=85388) ERROR 08-29 21:27:26 multiproc_worker_utils.py:226]
(VllmWorkerProcess pid=85386) ERROR 08-29 21:27:26 multiproc_worker_utils.py:226]     return func(*args, **kwargs)
(VllmWorkerProcess pid=85386) ERROR 08-29 21:27:26 multiproc_worker_utils.py:226]   File "/root/anaconda3/envs/py3/lib/python3.8/site-packages/vllm/worker/worker_base.py", line 69, in start_worker_execution_loop
(VllmWorkerProcess pid=85386) ERROR 08-29 21:27:26 multiproc_worker_utils.py:226]     output = self.execute_model(execute_model_req=None)
(VllmWorkerProcess pid=85386) ERROR 08-29 21:27:26 multiproc_worker_utils.py:226]   File "/root/anaconda3/envs/py3/lib/python3.8/site-packages/vllm/worker/worker_base.py", line 322, in execute_model
(VllmWorkerProcess pid=85386) ERROR 08-29 21:27:26 multiproc_worker_utils.py:226]     output = self.model_runner.execute_model(
(VllmWorkerProcess pid=85386) ERROR 08-29 21:27:26 multiproc_worker_utils.py:226]   File "/root/anaconda3/envs/py3/lib/python3.8/site-packages/torch/utils/_contextlib.py", line 116, in decorate_context
(VllmWorkerProcess pid=85386) ERROR 08-29 21:27:26 multiproc_worker_utils.py:226]     return func(*args, **kwargs)
(VllmWorkerProcess pid=85386) ERROR 08-29 21:27:26 multiproc_worker_utils.py:226]   File "/root/anaconda3/envs/py3/lib/python3.8/site-packages/vllm/worker/model_runner.py", line 1415, in execute_model
(VllmWorkerProcess pid=85386) ERROR 08-29 21:27:26 multiproc_worker_utils.py:226]     hidden_or_intermediate_states = model_executable(
(VllmWorkerProcess pid=85386) ERROR 08-29 21:27:26 multiproc_worker_utils.py:226]   File "/root/anaconda3/envs/py3/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1553, in _wrapped_call_impl
(VllmWorkerProcess pid=85386) ERROR 08-29 21:27:26 multiproc_worker_utils.py:226]     return self._call_impl(*args, **kwargs)
(VllmWorkerProcess pid=85386) ERROR 08-29 21:27:26 multiproc_worker_utils.py:226]   File "/root/anaconda3/envs/py3/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1562, in _call_impl
(VllmWorkerProcess pid=85386) ERROR 08-29 21:27:26 multiproc_worker_utils.py:226]     return forward_call(*args, **kwargs)
(VllmWorkerProcess pid=85386) ERROR 08-29 21:27:26 multiproc_worker_utils.py:226]   File "/root/anaconda3/envs/py3/lib/python3.8/site-packages/vllm/model_executor/models/internvl.py", line 459, in forward
(VllmWorkerProcess pid=85386) ERROR 08-29 21:27:26 multiproc_worker_utils.py:226]     inputs_embeds = merge_multimodal_embeddings(
(VllmWorkerProcess pid=85386) ERROR 08-29 21:27:26 multiproc_worker_utils.py:226]   File "/root/anaconda3/envs/py3/lib/python3.8/site-packages/vllm/model_executor/models/utils.py", line 77, in merge_multimodal_embeddings
(VllmWorkerProcess pid=85386) ERROR 08-29 21:27:26 multiproc_worker_utils.py:226]     raise ValueError(
(VllmWorkerProcess pid=85386) ERROR 08-29 21:27:26 multiproc_worker_utils.py:226] ValueError: Attempted to assign 7 x 256 = 1792 multimodal tokens to 506 placeholders
(VllmWorkerProcess pid=85386) ERROR 08-29 21:27:26 multiproc_worker_utils.py:226]
(VllmWorkerProcess pid=85392) ERROR 08-29 21:27:26 multiproc_worker_utils.py:226] Exception in worker VllmWorkerProcess while processing method start_worker_execution_loop: Attempted to assign 7 x 256 = 1792 multimodal tokens to 506 placeholders, Traceback (most recent call last):

If you have any questions, please feel free to contact me. I will run it exactly according to the official demo. The pictures are from my local
https://github.com/vllm-project/vllm/issues/6321
Is only 2B supported?
Before submitting a new issue...

[X] Make sure you already searched for relevant issues, and asked the chatbot living at the bottom right corner of the documentation page, which can answer lots of frequently asked questions.

Try setting a larger context length (--max-model-len should be greater than the number of multimodal tokens).

Also, make sure your InternVL2 is up-to-date.

I can actually repro this error - it seems to me that there's something changed about this model that introduced this bug.
@Isotr0py do you have bandwidth to take a look at this issue?

Try setting a larger context length (--max-model-len should be greater than the number of multimodal tokens plus text tokens).

Also, make sure your InternVL2 is up-to-date.

@DarkLight1337
Thank you for your reply. It is already the latest model and the parameter max-model-len=81920 is set. It seems to be the same error so far.

OK, I will take a look at this later today.

OK, I will take a look at this later today.

I encountered the similar problem on the InternVL2-8B
Error message：

Python3.8
1*A100 GPU
vllm                              0.5.5
vllm-flash-attn                   2.6.1
torch                             2.4.0
torchvision                       0.19.0

@SovereignRemedy @MasterJanus This may be caused by the chunked prefill. You can set --enable-chunked-prefill=False or enable_chunked_prefill=False to fix this issue.
WARNING 08-30 16:43:54 arg_utils.py:850] Chunked prefill is enabled by default for models with max_model_len > 32K. Currently, chunked prefill might not work with some features or models. If you encounter any issues, please disable chunked prefill by setting --enable-chunked-prefill=False.
INFO 08-30 16:43:54 config.py:970] Chunked prefill is enabled with max_num_batched_tokens=512.

@SovereignRemedy @MasterJanus This may be caused by the chunked prefill. You can set --enable-chunked-prefill=False or enable_chunked_prefill=False to fix this issue.
WARNING 08-30 16:43:54 arg_utils.py:850] Chunked prefill is enabled by default for models with max_model_len > 32K. Currently, chunked prefill might not work with some features or models. If you encounter any issues, please disable chunked prefill by setting --enable-chunked-prefill=False.
INFO 08-30 16:43:54 config.py:970] Chunked prefill is enabled with max_num_batched_tokens=512.

BTW, inference with max_model_len=4096 works for me because chunked prefill is disabled by default at small model_len.

@Isotr0py Thanks for the investigation! I guess we never ran into this issue previously since most models have small context window. We should definitely make a change to make sure chunked-prefill is disabled when serving a VLM (until we figure out how to make it compatible with chunked prefill)

@ywang96 After deeper investigation, seems that chunked-prefill has no conflicts between VLM. When I increase max_num_batched_tokens=4096, the model also works.
In fact, the root issue is the default max_num_batched_tokens=512 for chunked-prefill too small for VLM. So I think a proper solution is increasing the default max_num_batched_tokens when serving a VLM.

I keep forgetting about chunked prefill. Indeed, we should handle this case.

@ywang96 After deeper investigation, seems that chunked-prefill has no conflicts between VLM. When I increase max_num_batched_tokens=4096, the model also works.
In fact, the root issue is the default max_num_batched_tokens=512 for chunked-prefill too small for VLM. So I think a proper solution is increasing the default max_num_batched_tokens when serving a VLM.

Let me open a quick PR to increase the default value for VLM.

In fact, the root issue is the default max_num_batched_tokens=512 for chunked-prefill too small for VLM. So I think a proper solution is increasing the default max_num_batched_tokens when serving a VLM.

I think the tricky part is how to dynamically properly set this number - I'm okay with setting an arbitrary default value for VLMs

@ywang96 After deeper investigation, seems that chunked-prefill has no conflicts between VLM. When I increase max_num_batched_tokens=4096, the model also works.经过更深入的调查，似乎 chunked-prefill 与 VLM 之间没有冲突。当我增加max_num_batched_tokens=4096时，该模型也可以工作。
In fact, the root issue is the default max_num_batched_tokens=512 for chunked-prefill too small for VLM. So I think a proper solution is increasing the default max_num_batched_tokens when serving a VLM.事实上，根本问题是分块预填充的默认max_num_batched_tokens=512对于 VLM 来说太小。所以我认为正确的解决方案是在服务 VLM 时增加默认的 max_num_batched_tokens 。

@Isotr0py @DarkLight1337
Thank you for your answers. I referred to the above startup parameters, and the inference will not report an error, but there will be similar garbled characters, which I find strange. Is it a problem with my pictures?

My code runs on four A10GPU
from dataclasses import dataclass
from typing import Literal

from PIL import Image

VLM_IMAGES_DIR = "vision_model_images"

@dataclass(frozen=True)
class ImageAsset:
    name: Literal["stop_sign", "cherry_blossom"]

    @property
    def pil_image(self) -> Image.Image:

        # image_path = "/home/tdj/model/InternVL2-26B/examples/image1.jpg"
        image_path = "image.jpg"
        return Image.open(image_path)

from transformers import AutoTokenizer

from vllm import LLM, SamplingParams

# Input image and question
image = ImageAsset("cherry_blossom").pil_image.convert("RGB")
question = "这个照片是什么内容?"

# InternVL
def run_internvl(question):
    model_name = "/home/tdj/model/InternVL2-26B"

    llm = LLM(
        model=model_name,
        trust_remote_code=True,
        gpu_memory_utilization=0.9,
        tensor_parallel_size=4,
        max_num_batched_tokens=8192,
        max_model_len=4096,
    )

    tokenizer = AutoTokenizer.from_pretrained(model_name, trust_remote_code=True)
    messages = [{"role": "user", "content": f"<image>\n{question}"}]
    prompt = tokenizer.apply_chat_template(
        messages, tokenize=False, add_generation_prompt=True
    )

    stop_tokens = ["<|endoftext|>", "<|im_start|>", "<|im_end|>", "<|end|>"]
    stop_token_ids = [tokenizer.convert_tokens_to_ids(i) for i in stop_tokens]
    return llm, prompt, stop_token_ids

model_example_map = {
    "internvl_chat": run_internvl,
}

def main():
    model = "internvl_chat"
    if model not in model_example_map:
        raise ValueError(f"Model type {model} is not supported.")

    llm, prompt, stop_token_ids = model_example_map[model](question)

    sampling_params = SamplingParams(
        temperature=0.2, max_tokens=64, stop_token_ids=stop_token_ids
    )

    # Single inference
    inputs = {
        "prompt": prompt,
        "multi_modal_data": {"image": image},
    }
    print("!!!loaded model successfully!!!")
    outputs = llm.generate(inputs, sampling_params=sampling_params)
    print("!!!start generate output!!!")
    for o in outputs:
        generated_text = o.outputs[0].text
        print(generated_text)

if __name__ == "__main__":
    main()

Thank you for your answers. I referred to the above startup parameters, and the inference will not report an error, but there will be similar garbled characters, which I find strange. Is it a problem with my pictures?

No, this is a bug about the internlm2 backbone with tensor parallel. I'm working on fixing this. (You can see #8017 for tracking)

I met a strange issue. I want to use the InternVL2-8B,  I increased the --max_num_batched_tokens to 4096. And I use the tensor_parallel_size=2 to enable tensor parallel. But I got the completely different results from single GPU deployment.

single GPU deployment
python -m vllm.entrypoints.openai.api_server --model OpenGVLab/InternVL2-8B --port 9005 --trust-remote-code -tp 2 --max_num_batched_tokens 4096

two GPU deployment
python -m vllm.entrypoints.openai.api_server --model OpenGVLab/InternVL2-8B --port 9005 --trust-remote-code --max-model-len 10000

@Root970103 I have created #8055 to fix this. Please take a look :)

Facing something similar for https://huggingface.co/llava-hf/llava-v1.6-mistral-7b-hf/ on 4 H100s (vllm installed from source today):
[rank0]: ValueError: Attempted to assign 2340 + 2144 + 1850 + 2160 + 2832 + 2438 + 2340 + 2830 + 2536 + 1948 = 23418 multimodal tokens to 23516 placeholders

Facing something similar for https://huggingface.co/llava-hf/llava-v1.6-mistral-7b-hf/ on 4 H100s (vllm installed from source today):
[rank0]: ValueError: Attempted to assign 2340 + 2144 + 1850 + 2160 + 2832 + 2438 + 2340 + 2830 + 2536 + 1948 = 23418 multimodal tokens to 23516 placeholders

Can you open a separate issue for this since it's for a different model?

https://github.com/vllm-project/vllm/issues/8421

4*A6000 (48G), it works
python -m vllm.entrypoints.openai.api_server --model /remote-home/share/models/InternVL2-26B/ --host <IP_ADDRESS> --port 8000 --served-model-name InternVL2-26B --tensor_parallel_size=4 --trust-remote-code  --max_num_batched_tokens=8192

Can I do this with offline code?

4*A6000 (48G), it works
python -m vllm.entrypoints.openai.api_server --model /remote-home/share/models/InternVL2-26B/  \n
--host <IP_ADDRESS> --port 8000 --served-model-name InternVL2-26B  \n
--tensor_parallel_size=4 --trust-remote-code  \n
-- max_num_batched_tokens=8192


Send Mobile data : Added package (data)  to send mobile data 🥤

This branch contains a feature to send mobile data through the Africa's talking API

@Daniel-Sogbey Thank you for your contribution. The feature looks great. Just a few comment on logging and it will be ready for merge

Looks good! Thanks for taking your time to contribute :rocket:


feat: handle consolidated configuration change event

This PR

Handles the consolidated configuration change event.
Related Issues

Fixes #64
Release in conjunction with https://github.com/open-feature/flagd/pull/241
Notes

Follow-up Tasks

How to test

A linting issue has been flagged in the actions, but otherwise LGTM

ill look into why this hasn't caused a failure on the action


Touch screen malfunctioning cal reset does not work.

I have been using my FTD for a few days now, and it has been working great, but today I tried to use it and the touch screen would work a little but seemed to be making its own touches. I ran cal reset a couple times, but it seemed to just touch each corner on its own without me touching it at all. I am at a loss. Thoughts?

Hi @Lucero-delcielo, my first guess is a bad connection to the touch controller. Are you using a breadboard? Or the combiner PCB? Or a prototype board? Anyway, I would check the T_DO, T_CS, and T_CLK for a bad connection or a short. Maybe even reflow the pins if you are using the combiner board or a prototype board.

Thank you for the advice Dustin. It seems my soldering was a bit shoddy on those pins. Reflowing them solved the issue. Thanks so much for your help!

Good to hear! :D


Intermittent chunk load errors in Firefox

Bug report

What is the current behavior?
Intermittently, Firefox users of our Angular site (with lazy loading of chunks) will get ChunkLoadErrors that prevent our site from loading properly. This has been maddeningly intermittent and I have not been able to reproduce it, but I've collected some HAR files from users with details that may point in the right direction. This may be an issue with Firefox itself, or possibly plugins/add-ons/extension (although from the list of plugins users have reported, there is no plugin in common between them all, I believe, and some have said they have seen the issue when they run vanilla Firefox.)
I'm not super adept at decoding HAR files, but it is interesting is that when chunks fail to load, there appears to be something odd with the Protocol.
First, a chunk that loaded properly (it seems):

Now, from the same HAR, a chunk that did not load properly (notice status code 0, -1 B transferred). Notice also that the GET line in the raw Request omits HTTP/2. I believe that this file was the missing chunk that broke the page:

But also from the same HAR, there is this request, that seems to have loaded properly, but for some reason has status code 0? This one could just be loading from Cache or something, but I'm not sure.

In all cases, it seem that users are able to fix the problem by clearing their caches and reloading the page. From the HAR files, I've seen that the filenames after reload are the same as those that failed to load previously, so we aren't dealing new code being deployed resulting in missing old chunks.
For a bit more background with some additional HAR files, see this StackOverflow question. This has also been discussed at length on our site's forums, here and here.
If the current behavior is a bug, please provide the steps to reproduce.
I suppose, load one of the threads linked to our site above and cross your fingers, but I've never been able to reproduce the issue myself.

What is the expected behavior?
Chunks should all load.
Other relevant information:
webpack version:  5.67.0
Node.js version: 14.18.1
Operating System:
Additional tools: Angular-CLI
I have quite a few more HAR files, but I want to be careful how I share the data from them, because they contain some sensitive information.

it looks like it is some network problems, not sure how this related to webpack..


http_server.sync_response.headers is case sensitive

Type = Minor Bug
The header field names are case insensitive ref: https://www.w3.org/Protocols/rfc2616/rfc2616-sec4.html#sec4.2
However, http_server.sync_response.headers seems to be case sensitive i.e.
While,
input:
  label: "in_http_server"
  http_server:
    path: /post
    sync_response:
      headers:
        Content-Type: "application/json"

works,
input:
  label: "in_http_server"
  http_server:
    path: /post
    sync_response:
      headers:
        content-type: "application/json"

doesn't (and it should!).

Thanks for raising this @mannharleen, fixed in: https://github.com/Jeffail/benthos/commit/9ed999621a7750acede5e3150ce0e0a0da568a5c

Thanks for raising this @mannharleen, fixed in: 9ed9996

Cheers!


Reduce filter options based on the current dataset

I don't believe this is a bug, so I'm opening this issue as a feature request.
DBeaver has the feature of easily filtering a dataset using the filter icon on the "Results" tab. See below:

Given the dataset on the previous picture, if I open the filter for the column ADDRESS_CITY, I am presented with all the distinct values for this column. Then, I can select some options as shown in picture below:

After applying the first filter, you can clearly see in the dataset that it reduced the values of the column ADDRESS_STATE to only 2 possible values: SC and RS.

Now, if I click on the filter icon for column ADDRESS_STATE, what I expect to see is the distinct values that are being shown on the dataset SC and RS. But it shows all the values. See below:

So, my request is to make the filters show only the values currently present on the dataset.
I understand that many users are used to the default behavior, so you could implement this as a customizable behavior. Maybe a toggle button near the refresh button (see picture below), that allows you to toggle between the two behaviors with just one click.

thanks for suggestion
closed as a duplicate of #10549


Animate ScaleType

Is there a way to animate the scale when setScaleType(...)?
For example:
If PhotoView currently has ScaleType.CENTER_INSIDE, doing setScaleType(ScaleType.CENTER_CROP) would animate the scale.
The API might look something like:
setScaleType(ScaleType scaleType, boolean animate)

I think this goes beyond the scope of this library