Remove the support for legacy templates

It has been more than 10 months since the plugins first version was released. I think we can safely remove the support for legacy templates now. (https://github.com/joplin/plugin-templates#importing-legacy-templates)
What do you guys think? @laurent22 @CalebJohn

10 months is not that much actually, some people run very old versions, for example when they disable the auto updates. And the day they do update it'd be nice if things work well.
So unless it becomes a burden to maintain this part of the code, I'd suggest keeping it for now.

Thanks for the suggestions. Yes it makes sense to support the legacy templates to the point where its not a burden to maintain and doesn't affect the rest of the plugin. Closing the issue.


Generate ActiveRecord::Migration[VERSION]

https://github.com/bsm/grape-app/blob/5101278d6fd27d98d95e9f7a5237e6cc8f4e4bfd/lib/grape/app/tasks/databases.rake#L36
Any concerns to focus on AR 5.2?

you can just use [ActiveRecord::VERSION::MAJOR, ActiveRecord::VERSION::MINOR].join('.')

So you'll accept such PR?

any time


mbedtls compile options are not longer given to external modules

Describe the bug
In current main branch there is a regression regarding mbedtls.
In 3.5 branch the -DMBEDTLS_CONFIG_FILE=\"config-tls-generic.h\" and -I/home/zephyrproject/modules/crypto/mbedtls/include were given to external modules but that is no longer the case in current main.
To Reproduce
Steps to reproduce the behavior:

build the project with external module using mbedtls
see errors about include files

Expected behavior
External project has the required compile options.

I have a similar issue after updating from Zephyr v3.5.0 to v3.6.0.
I have an external module using mbedtls. After the update to Zephyr v3.6.0 the mbedtls include files in /modules/crypto/mbedtls/include are not found anymore.
Is there any workaround or fix in progress? I cannot update to v3.6.0.

@tejlmand  can you please take a look?

@tejlmand or @nordicjm , @57300 can you please take a look at this?

@xhpohanka can you provide a bit more information on this ?
The mbedtls flags are passed to the Zephyr mbedTLS module, https://github.com/zephyrproject-rtos/mbedtls, which can be seen if building the tests/crypto/crypto_hash test sample.
Output when building main, but same result on Zephyr v3.6.0:
$ cmake -GNinja -Bbuild -DBOARD=nrf52840dk/nrf52840 tests/crypto/crypto_hash
$ ninja -Cbuild -v
...
[207/236] ccache /opt/zephyr-sdk-0.16.1/arm-zephyr-eabi/bin/arm-zephyr-eabi-gcc ...
 -DMBEDTLS_CONFIG_FILE=\"config-tls-generic.h\" -DNRF52840_XXAA
...
 -I/projects/github/ncs/modules/crypto/mbedtls/include
 -I/projects/github/ncs/zephyr/modules/mbedtls/configs
 -I/projects/github/ncs/zephyr/modules/mbedtls/include
...
 -o modules/mbedtls/CMakeFiles/modules__mbedtls.dir/projects/github/ncs/modules/crypto/mbedtls/library/ssl_tls.c.obj
 -c /projects/github/ncs/modules/crypto/mbedtls/library/ssl_tls.c
...

or are you talking about other external modules, and which modules ?
Is it modules hosted by Zephyr, or downstream only modules ?

To Reproduce
Steps to reproduce the behavior:

build the project with external module using mbedtls
see errors about include files

Which project are you building, and for which board ?
Please provide as many details possible in order for us to investigate.

Hi,
just a very quick update now.

I'm building a project for stm32h743 west build -b nucleo_h743zi.
I noticed it first when merged the commit 5b4c927c50eb032730767808b0304bf1043e2e91 if February
I'm afraid your test is not trying to reproduce my issue, it checkes only the zephyr itself, not external modules
check the compile command I get for different files, for external ones the include paths of mbedtls are missing

main.c - internal project file
pb_decode.c - external module, supported
civetweb.c - external module (currently unsupported but it is the one where mbedtls is used for me`

arm-zephyr-eabi-gcc
-DCORE_CM7
-DHSE_VALUE=8000000
-DKERNEL
-DK_HEAP_MEM_POOL_SIZE=1024
-DMBEDTLS_CONFIG_FILE=\"config-tls-generic.h\"
-DPB_MAX_REQUIRED_FIELDS=64
-DSTM32H743xx
-DUSE_FULL_LL_DRIVER
-DUSE_HAL_DRIVER
-D__PROGRAM_START
-D__ZEPHYR__=1
-I/home/honza/dev/zephyrproject2/poemodule/src
-I/home/honza/dev/zephyrproject2/zephyr/include
-I/home/honza/dev/zephyrproject2/poemodule/build/zephyr/include/generated
-I/home/honza/dev/zephyrproject2/zephyr/soc/arm/st_stm32/stm32h7
-I/home/honza/dev/zephyrproject2/zephyr/include/zephyr/posix
-I/home/honza/dev/zephyrproject2/zephyr/lib/posix/options/getopt/.
-I/home/honza/dev/zephyrproject2/zephyr/drivers
-I/home/honza/dev/zephyrproject2/zephyr/soc/arm/st_stm32/common
-I/home/honza/dev/zephyrproject2/zephyr/subsys/net/l2
-I/home/honza/dev/zephyrproject2/zephyr/subsys/net/lib/dns/.
-I/home/honza/dev/zephyrproject2/modules/lib/civetweb/include
-I/home/honza/dev/zephyrproject2/modules/lib/nanopb
-I/home/honza/dev/zephyrproject2/modules/hal/cmsis/CMSIS/Core/Include
-I/home/honza/dev/zephyrproject2/zephyr/modules/cmsis/.

-I/home/honza/dev/zephyrproject2/zephyr/drivers
-I/home/honza/dev/zephyrproject2/zephyr/soc/arm/st_stm32/common
-I/home/honza/dev/zephyrproject2/zephyr/subsys/net/l2
-I/home/honza/dev/zephyrproject2/zephyr/subsys/net/lib/dns/.
-I/home/honza/dev/zephyrproject2/modules/lib/civetweb/include
-I/home/honza/dev/zephyrproject2/modules/lib/nanopb
-I/home/honza/dev/zephyrproject2/modules/hal/cmsis/CMSIS/Core/Include
-I/home/honza/dev/zephyrproject2/zephyr/modules/cmsis/.
-I/home/honza/dev/zephyrproject2/modules/hal/stm32/stm32cube/stm32h7xx/soc
-I/home/honza/dev/zephyrproject2/modules/hal/stm32/stm32cube/stm32h7xx/drivers/include
-I/home/honza/dev/zephyrproject2/modules/hal/stm32/stm32cube/stm32h7xx/drivers/include/Legacy
-I/home/honza/dev/zephyrproject2/modules/hal/stm32/stm32cube/common_ll/include
-I/home/honza/dev/zephyrproject2/modules/lib/civetweb/src
-I/home/honza/dev/zephyrproject2/poemodule/src
-isystem /home/honza/dev/zephyrproject2/zephyr/lib/libc/minimal/include
-isystem /home/honza/dev/zephyrproject2/zephyr/lib/libc/common/include
-isystem /home/honza/zephyr-sdk-0.16.4/arm-zephyr-eabi/bin/../lib/gcc/arm-zephyr-eabi/12.2.0/include
-isystem /home/honza/zephyr-sdk-0.16.4/arm-zephyr-eabi/bin/../lib/gcc/arm-zephyr-eabi/12.2.0/include-fixed
-std=c11
-fno-strict-aliasing
-Os
-imacros /home/honza/dev/zephyrproject2/poemodule/build/zephyr/include/generated/autoconf.h
-ffreestanding
-fno-common
-g
-gdwarf-4
-fdiagnostics-color=always
-mcpu=cortex-m7
-mthumb
-mabi=aapcs
-mfp16-format=ieee
--sysroot=/home/honza/zephyr-sdk-0.16.4/arm-zephyr-eabi/arm-zephyr-eabi
-imacros /home/honza/dev/zephyrproject2/zephyr/include/zephyr/toolchain/zephyr_stdint.h
-Wall
-Wformat
-Wformat-security
-Wno-format-zero-length
-Wdouble-promotion
-Wno-pointer-sign
-Wpointer-arith
-Wexpansion-to-defined
-Wno-unused-but-set-variable
-Werror=implicit-int
-fno-pic
-fno-pie
-fno-asynchronous-unwind-tables
-Werror-implicit-function-declaration
-fno-reorder-functions
--param=min-pagesize=0
-fno-defer-pop
-fmacro-prefix-map=/home/honza/dev/zephyrproject2/poemodule=CMAKE_SOURCE_DIR
-fmacro-prefix-map=/home/honza/dev/zephyrproject2/zephyr=ZEPHYR_BASE
-fmacro-prefix-map=/home/honza/dev/zephyrproject2=WEST_TOPDIR
-ffunction-sections
-fdata-sections
-D_POSIX_THREADS
-std=c99
-nostdinc
-MD
-MT modules/civetweb/CMakeFiles/..__modules__lib__civetweb.dir/src/civetweb.c.obj
-MF modules/civetweb/CMakeFiles/..__modules__lib__civetweb.dir/src/civetweb.c.obj.d
-o modules/civetweb/CMakeFiles/..__modules__lib__civetweb.dir/src/civetweb.c.obj
-c /home/honza/dev/zephyrproject2/modules/lib/civetweb/src/civetweb.c

arm-zephyr-eabi-gcc
-DCORE_CM7
-DHSE_VALUE=8000000
-DKERNEL
-DK_HEAP_MEM_POOL_SIZE=1024
-DPB_MAX_REQUIRED_FIELDS=64
-DSTM32H743xx
-DUSE_FULL_LL_DRIVER
-DUSE_HAL_DRIVER
-D__PROGRAM_START
-D__ZEPHYR__=1
-I/home/honza/dev/zephyrproject2/zephyr/include
-I/home/honza/dev/zephyrproject2/poemodule/build/zephyr/include/generated
-I/home/honza/dev/zephyrproject2/zephyr/soc/arm/st_stm32/stm32h7
-I/home/honza/dev/zephyrproject2/zephyr/include/zephyr/posix
-I/home/honza/dev/zephyrproject2/zephyr/lib/posix/options/getopt/.
-I/home/honza/dev/zephyrproject2/zephyr/drivers
-I/home/honza/dev/zephyrproject2/zephyr/soc/arm/st_stm32/common
-I/home/honza/dev/zephyrproject2/zephyr/subsys/net/l2
-I/home/honza/dev/zephyrproject2/zephyr/subsys/net/lib/dns/.
-I/home/honza/dev/zephyrproject2/modules/lib/civetweb/include
-I/home/honza/dev/zephyrproject2/modules/lib/nanopb
-I/home/honza/dev/zephyrproject2/modules/hal/cmsis/CMSIS/Core/Include
-I/home/honza/dev/zephyrproject2/zephyr/modules/cmsis/.
-I/home/honza/dev/zephyrproject2/modules/hal/stm32/stm32cube/stm32h7xx/soc
-I/home/honza/dev/zephyrproject2/modules/hal/stm32/stm32cube/stm32h7xx/drivers/include
-I/home/honza/dev/zephyrproject2/modules/hal/stm32/stm32cube/stm32h7xx/drivers/include/Legacy
-I/home/honza/dev/zephyrproject2/modules/hal/stm32/stm32cube/common_ll/include
-isystem /home/honza/dev/zephyrproject2/zephyr/lib/libc/minimal/include
-isystem /home/honza/dev/zephyrproject2/zephyr/lib/libc/common/include
-isystem /home/honza/zephyr-sdk-0.16.4/arm-zephyr-eabi/bin/../lib/gcc/arm-zephyr-eabi/12.2.0/include
-isystem /home/honza/zephyr-sdk-0.16.4/arm-zephyr-eabi/bin/../lib/gcc/arm-zephyr-eabi/12.2.0/include-fixed
-fno-strict-aliasing
-Os
-imacros /home/honza/dev/zephyrproject2/poemodule/build/zephyr/include/generated/autoconf.h
-ffreestanding
-fno-common
-g
-gdwarf-4
-fdiagnostics-color=always
-mcpu=cortex-m7
-mthumb
-mabi=aapcs
-mfp16-format=ieee
--sysroot=/home/honza/zephyr-sdk-0.16.4/arm-zephyr-eabi/arm-zephyr-eabi
-imacros /home/honza/dev/zephyrproject2/zephyr/include/zephyr/toolchain/zephyr_stdint.h
-Wall
-Wformat
-Wformat-security
-Wno-format-zero-length
-Wdouble-promotion
-Wno-pointer-sign
-Wpointer-arith
-Wexpansion-to-defined
-Wno-unused-but-set-variable
-Werror=implicit-int
-fno-pic
-fno-pie
-fno-asynchronous-unwind-tables
-Werror-implicit-function-declaration
-fno-reorder-functions
--param=min-pagesize=0
-fno-defer-pop
-fmacro-prefix-map=/home/honza/dev/zephyrproject2/poemodule=CMAKE_SOURCE_DIR
-fmacro-prefix-map=/home/honza/dev/zephyrproject2/zephyr=ZEPHYR_BASE
-fmacro-prefix-map=/home/honza/dev/zephyrproject2=WEST_TOPDIR
-ffunction-sections
-fdata-sections
-D_POSIX_THREADS
-std=c99
-nostdinc
-MD
-MT modules/nanopb/CMakeFiles/modules__nanopb.dir/home/honza/dev/zephyrproject2/modules/lib/nanopb/pb_decode.c.obj
-MF modules/nanopb/CMakeFiles/modules__nanopb.dir/home/honza/dev/zephyrproject2/modules/lib/nanopb/pb_decode.c.obj.d
-o modules/nanopb/CMakeFiles/modules__nanopb.dir/home/honza/dev/zephyrproject2/modules/lib/nanopb/pb_decode.c.obj
-c /home/honza/dev/zephyrproject2/modules/lib/nanopb/pb_decode.c

Reproduced in native_posix build as well...
ninja: Entering directory `buildp'
[1/2] ccache /usr/lib/ccache/bin/gcc -DKERNEL -DK_HEAP_MEM_POOL_SIZE=1024 -DMBEDTLS_CONFIG_FILE=\"config-tls-generic.h\" -DPB_MAX_REQUIRED_FIELDS=64 -D__ZEPHYR__=1 -I/zephyrproject2/poemodule/src -I/zephyrproject2/zephyr/include -I/zephyrproject2/poemodule/buildp/zephyr/include/generated -I/zephyrproject2/zephyr/soc/posix/inf_clock -I/zephyrproject2/zephyr/boards/posix/native_posix -I/zephyrproject2/zephyr/arch/posix/core/nsi_compat -I/zephyrproject2/zephyr/subsys/net/l2 -I/zephyrproject2/zephyr/subsys/net/lib/dns/.  -I/zephyrproject2/modules/lib/nanopb -fno-strict-aliasing -Os -imacros /zephyrproject2/poemodule/buildp/zephyr/include/generated/autoconf.h -fno-common -g -gdwarf-4 -fdiagnostics-color=always -Wall -Wformat -Wformat-security -Wno-format-zero-length -Wdouble-promotion -Wno-pointer-sign -Wpointer-arith -Wexpansion-to-defined -Wno-unused-but-set-variable -Werror=implicit-int -fno-pic -fno-pie -fno-asynchronous-unwind-tables -Werror-implicit-function-declaration -fno-reorder-functions --param=min-pagesize=0 -fno-defer-pop -fmacro-prefix-map=/zephyrproject2/poemodule=CMAKE_SOURCE_DIR -fmacro-prefix-map=/zephyrproject2/zephyr=ZEPHYR_BASE -fmacro-prefix-map=/zephyrproject2=WEST_TOPDIR -ffunction-sections -fdata-sections -m32 -msse2 -mfpmath=sse -include /zephyrproject2/zephyr/arch/posix/include/posix_cheats.h -fno-freestanding -std=c11 -MD -MT modules/nanopb/CMakeFiles/modules__nanopb.dir/zephyrproject2/modules/lib/nanopb/pb_common.c.obj -MF modules/nanopb/CMakeFiles/modules__nanopb.dir/zephyrproject2/modules/lib/nanopb/pb_common.c.obj.d -o modules/nanopb/CMakeFiles/modules__nanopb.dir/zephyrproject2/modules/lib/nanopb/pb_common.c.obj -c /zephyrproject2/modules/lib/nanopb/pb_common.c
[2/2] : && ccache /usr/bin/cmake -E rm -f modules/nanopb/libmodules__nanopb.a && ccache /usr/bin/ar qc modules/nanopb/libmodules__nanopb.a  modules/nanopb/CMakeFiles/modules__nanopb.dir/

again build params
-DMBEDTLS_CONFIG_FILE=\"config-tls-generic.h\"
-I/zephyrproject2/modules/crypto/mbedtls/include
-I/zephyrproject2/zephyr/modules/mbedtls/configs
-I/zephyrproject2/zephyr/modules/mbedtls/include

are missing in external module build.
They was there in older zephyr.

just a very quick update now.

Thanks.

* I'm building a project for stm32h743 `west build -b nucleo_h743zi`.

Important information when having to reproduce.
Such information should always be part of the issue reporting.

* I noticed it first when merged the commit [5b4c927](https://github.com/zephyrproject-rtos/zephyr/commit/5b4c927c50eb032730767808b0304bf1043e2e91) if February

Thanks, always helpful as it can help tracing back.
But in this case this specific commit seems unrelated, but still helpful to reduce the commits to investigate during a bisect.

* I'm afraid your test is not trying to reproduce my issue, it checkes only the zephyr itself, not external modules

Then you must clarify what you mean by an external module, because mbedtls itself is an external module, and you can see the file from my investigation is located in a Zephyr module:
 -c /projects/github/ncs/modules/crypto/mbedtls/library/ssl_tls.c
    west workspace --^^^   ^^^            ^^^
       Zephyr modules ------|              |
                      mbedTLS module ----- |

and that file is being compiled with the expected flags.

* check the compile command I get for different files, for external ones the include paths of mbedtls are missing

  * `main.c` - internal project file
  * `pb_decode.c` - external module, supported

because the protobuf-nanopb-static is not a Zephyr library.
If the protobuf-nanopb-static should be build as a Zephyr library, then such request should actually go to the maintainer of the module.
FYI: @pdgendt
Question, why does pb_decode.c require mbedTLS headers ?

  * `civetweb.c` - external module (currently unsupported but it is the one where mbedtls is used for me`

As you say, support for civetweb was removed long ago: https://github.com/zephyrproject-rtos/zephyr/pull/46746
If you're using a new civetweb release which doesn't build the library as Zephyr libraries, then that's the reason those include paths are not part of civetweb.
The civetweb build code must ensure that include folders and flags from Zephyr is applied, either by creating a zephyr_library() or linking the civetweb library with zephyr_interface.
So you would need something like this:
https://github.com/zephyrproject-rtos/civetweb/blob/094aeb41bb93e9199d24d665ee43e9e05d6d7b1c/CMakeLists.txt#L401
https://github.com/zephyrproject-rtos/civetweb/blob/094aeb41bb93e9199d24d665ee43e9e05d6d7b1c/CMakeLists.txt#L427
https://github.com/zephyrproject-rtos/civetweb/blob/094aeb41bb93e9199d24d665ee43e9e05d6d7b1c/CMakeLists.txt#L462-L467
So far there doesn't seem to be any flaws in the build system.
What I can conclude is the following:

Libraries which requires include path defined by Zephyr must do one of the following:

Use zephyr_library for library creation, or
Link the CMake library with zephyr_interface.

So the reported issue is related to the library itself and it's glue code, and not related to Zephyr's mbedTLS intergration.

The nanopb sources are normally built as a library and compile options are added, see:
https://github.com/zephyrproject-rtos/zephyr/blob/8c8e2f6243f147953ce3fadb999c4e2a5faf4f5e/modules/nanopb/CMakeLists.txt#L9-L49

The nanopb sources are normally built as a library and compile options are added, see:

Sorry, my bad, I was looking here:
https://github.com/zephyrproject-rtos/nanopb/blob/7f88274070afa5edfaf608f4d8e32f3d3c1de139/CMakeLists.txt#L156

Hi @tejlmand,
I'm afraid we do not understand each other.

nanopb indeed does not need mbedtls, I used it just as an example of supported external module
I'm not aware of any external module requiring mbedtls now
I use civetweb with the same definitions of zephyr_library as you show in linked example
the issue is that mbedtls options were passed to the civetweb (or any other module as nanopb) build in older zephyr, now they are not

The zephyr build system is really really complex (that's one of the reason why many of my colleagues hate Zephyr) so I don't know if I'm fighting with issue of the module integration or the system itself.

if I use a module defining a zephyr_library() should the library be accessible for other modules?
should other modules do some work to access the other library module?

The situation has changed in time. For me before I merged the mentioned commit from master branch, build of external modules (even the nanopb) was given the options eg. -I/zephyrproject/modules/crypto/mbedtls/include.

Ok,
I have started to be curious what's going on and done the bisect.
The commit bringing the issue to me is the 7c72d4a2d6335ba0a37babfba34abad363b0932d.
From what I see there it seems to me that zephyr_library_link_libraries_ifdef(CONFIG_MBEDTLS mbedTLS) is important. If I understand it correctly, if library wants to use mbedtls (or any other library) it has to state this in its CMakeLists.txt. The original implementation of tls sockets made it available for whole build but probably it was just an unwanted coincidence.
@tejlmand please, can you confirm my finding is correct?

The zephyr build system is really really complex

I agree, but considering the amount of boards, modules, integration with 3rd party modules which are all having their own way of doing things, etc. then things due become complex.
That's why we do try to keep some consistency in how things works in Zephyr

I don't know if I'm fighting with issue of the module integration or the system itself.

and that is what i'm trying to investigate, thus the reasons for my followup questions.

if I use a module defining a zephyr_library() should the library be accessible by other modules?

Depends on what you mean by accessible by other modules ?
But if a library provides headers which should be available to all Zephyr modules, then the module should call:
zephyr_include_directories(<dir>)

and then libraries defined with zephyr_library() will inherit those include paths.
Thus the reason I try to narrow down exactly where / how the libs where you see this issue is created.

should other modules do some work to access the other library module?

If a library provides some public includes / compile flags which are not shared through zephyr_interface(), then an explicit link to the needed library is required.
For example using:
zephyr_library_link_libraries(<needed-lib>)

I have started to be curious what's going on and done the bisect.
The commit bringing the issue to me is the https://github.com/zephyrproject-rtos/zephyr/commit/7c72d4a2d6335ba0a37babfba34abad363b0932d.
From what I see there it seems to me that zephyr_library_link_libraries_ifdef(CONFIG_MBEDTLS mbedTLS) is important. If I understand it correctly, if library wants to use mbedtls (or any other library) it has to state this in its CMakeLists.txt. The original implementation of tls sockets made it available for whole build but probably it was just an unwanted coincidence.

Great. Thanks for finding.
And you're absolutely correct, the old use of zephyr_link_libraries_ifdef(CONFIG_MBEDTLS mbedTLS) would exactly make mbedTLS available to all libraries, which probably was unintended.
But going a step deeper, then this would only happen when CONFIG_NET_SOCKETS=y, because sockets code (and thus old use of zephyr_link_libraries()) is included here:
https://github.com/zephyrproject-rtos/zephyr/blob/7c72d4a2d6335ba0a37babfba34abad363b0932d/subsys/net/lib/CMakeLists.txt#L12
This is exactly why it's important to have as detailed info as possible when strating an investigation.

@tejlmand please, can you confirm my finding is correct?

yes, the change of zephyr_link_libraries_ifdef() to zephyr_library_link_libraries_ifdef() would explain your observed change in behavior when CONFIG_NET_SOCKETS=y and CONFIG_MBEDTLS=y are set.
Now the question is if there are libraries which relies on mbedTLS but is not linking to it, simply because the library got it for "free".
From earlier comment, I take you're using civetweb, in which case your inclusion of civetweb should also link to mbedTLS.

Thank you for explanation.
The correct way then is to use zephyr_library_link_libraries(MbedTLS) in mbedtls enabled civetweb CMakeLists.txt

The zephyr build system is really really complex

I agree, but considering the amount of boards, modules, integration with 3rd party modules which are all having their > > own way of doing things, etc. then things due become complex.
That's why we do try to keep some consistency in how things works in Zephyr

I agree too, but the truth is that eg. such issue with include files we met here is a show stopper for a most of my team :) Unfortunately there is no documentation or example of using zephyr_library_link_libraries() just the source code itself (well maybe zephyr/cmake/modules/extensions.cmake but I have found it only because I knew what to search for :) ).


Research need for Kaltura and replace/remove

Kaltura is under a GPL license. Eliminate or find alternative.

Can we make this item a pluggable component somehow?  Hide it behind a "pluggable, interface-based abstraction?"  (And simply not provide the Kaltura impl, if we're not legally allowed.)

@bjagg to continue to look into this one.
It is already a pluggable component.

Remove it and provide instructions to go download it.

https://www.apache.org/legal/resolved.html#optional

Confirmed removing the Equella/Source/Plugins/Kaltura folder, and the Kaltura dependency from Equella/Source/equellaserver/build.sbt will build Equella without Kaltura.
Using the test TestEnablingKaltura.html as a guide, I confirmed that starting with 6.4-QA3 with Kaltura configs / attachments, then upgrading to the open source version without Kaltura and using Equella didn't throw any errors, though there are some things to watch for.
I then confirmed upgrading to the open source version built with Kaltura 'brought back' Kaltura as expected.  I did find one error, but I think it's more of Equella admins being aware, then something we should fix in the code:

Save a collection that originally had kaltura configured via the code base without Kaltura.
After enabling Kaltura in the code, try to delete the Kaltura attachment on an item that was originally setup with a Kaltura attachment.  It throws an AJAX error, and there's a NPE in the logs.
Edit the collection to enable Kaltura as an attachment type, and you can delete / add Kaltura attachments now without errors.

Need to confirm with @doolse / @drewwills where the Plugins/Kaltura code should live.

Note:  Running Equella without Kaltura, a previously configured Kaltura widget gives a polite message "No resource types have been configured for this control. Please contact your system administrator ".

Opened pull request #81 .  Working with Drew to create a new repo to push the removed Equella Kaltura code into.

https://github.com/equella/Equella-Kaltura

Moved over the code and updated the docs.


vscode.Diagnostic.relatedInformation is stale (incorrectly cached?) after it's updated with the relatedInformation removed

Does this issue occur when all extensions are disabled?: Yes (but my repro is with the C/C++ extension)

VS Code Version: 1.67.2 or
Version: 1.68.0-insider (user setup)
Commit: 87630a9122f88f5062fe9964839a92116c274a86
Date: 2022-06-06T17:09:26.575Z
Electron: 17.4.7
Chromium: 98.0.4758.141
Node.js: 16.13.0
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.22000
OS Version: Windows (I suspect it repros with all OS's)

Steps to Reproduce:

Do something to cause a vscode.Diagnostic object to be created that has a relatedInformation set.
Do something to cause the same diagnostic to be set but with the relatedInformation not set (either missing or set to undefined).

Bug: The VS Code UI doesn't remove the relatedInformation from the diagnostic in the Problems windows. If the Problems tab is switched to another tab and then back, the child disappears, but the parent UI node still renders with an empty child expansion widget on the left. See the screenshot (top half is before a refresh is triggered, and the bottom half is after the UI refreshes):

Repro details for the C/C++ extension are:

Install the C/C++ extension version 1.10.4 (pre-release) or later (1.9.8 is not sufficient).
Add setting

"C_Cpp.codeAnalysis.clangTidy.checks.enabled": [
        "*"
    ]

Create a test.cpp with

#include <algorithm>
#include <cstdlib>
#include <numeric>
#include <atomic>
#include <cassert>
#include <cctype>
#include <cerrno>
#include <cfenv>
#include <cfloat>
#include <cinttypes>
#include <ciso646>
#include <climits>
#include <clocale>
#include <cmath>
#include <csetjmp>
#include <csignal>
#include <cstdarg>
#include <cstddef>
#include <cstdint>
#include <cstdio>
#include <cstdlib>

NOTE: It's possible this step may require Windows with VS 2022 C++ build tools installed, not sure. I could look into a Linux/Mac repro if you want.
3. Use the "C/C++: Run Code Analysis on Active File" command.
4. Select the "Fix..." code action for the "duplicate include" problem. See the screenshot:

5. Save the document and then wait for the flame icon in the status bar to disappear, which indicates the Problem window has been updated with a diagnostic that has the relatedInformation removed -- the correctness of this code has been verified via debugging our TypeScript code, and the fact that the child object disappears after the UI is "refreshed" (but with an empty child) also reinforces the conclusion that it's a VS Code UI issue, because our extension code is not involved at that point.

This seems to be fixed. Please retry with latest VS Code and confirm. If you are still seeing the issue please provide the new steps to reproduce.

Yeah, the related info is removed now. The UI is still incorrect and shows a collapse icon on the left even though there are no more children, but that is low priority.


[SUGGESTION] Add new type of lines which their visibility depends on something

Hello,
It would be amazing if you could add a new type of line to the API. This new type will only be visible if a condition is met.
I don't mean a line that would just be an empty space and then when the condition is met, some text appears, but rather a line that does not exist visually in the scoreboard, and when it appears, the scoreboard would be made bigger, and when it disappears, the scoreboard would be made smaller again.
Thank you in advance.

Sounds good. I'll implement it in spare time. Thank you for the suggestion.


perf: change js_helpers gather_* utils to accept list, not depset

In almost all use cases these are lists, or for gather_runfiles always depsets. rules_ts seems to follow this pattern already
Depends on https://github.com/aspect-build/rules_js/pull/1788

Changes are visible to end-users: yes

Breaking change (forces users to change their own code or config): yes

Test plan

Covered by existing test cases

This would be great! It saves around 1.5s of analysis time for us (close to 10%)


[DM] [SASS-1216] Updated regex

Description
Updating the regex for the name input on the interest taxed and untaxed new account pages.
Add a link to the relevant story in Jira
SASS-1216
Checklist PR Reviewer
Before Reviewing

[x]  Have you pulled the branch down?
[x]  Have you assigned yourself to the PR?
[x]  Have you moved the task to “in review” on JIRA?
[x]  Have you checked to ensure all dependencies are up to date?
[x]  Have you checked to ensure its been rebased against the current version of master?

Whilst Reviewing

[x]  Have you run the tests?

[x]  Have you looked at the JIRA story to make sure all Acceptance Criteria has been met?

After Reviewing

[ ]  Have you checked for merge conflicts or any changes in the current master that may affect the current pull request? i.e. does it need another rebase?
[ ]  Have you checked to make sure there are no builds in the pipeline before you merge?
[ ]  Have you moved the task to “in pipeline” on Jira?

[x]  Have you rebased against the current version of master?
[x]  Have you checked code coverage isn’t lower than previously?

After PRs been raised

[x]  Have you checked the PR Builder passes?

Do we need to change the content in the error message to reflect these changes?
Removed the '/' from the messages


Additional API for clearing the last error message from server

Feature Request
The Java library doesn't have the ability to clear the last error message from the server. It only has an API to retrieve the last error. If a user needs to check the last error message after each publish this will cause an error message to be there indefinitely until the connection is re-established.
Use Case:
Checking the getLastError() after each publish to ensure the Nats server didn't respond with an error.
Proposed Change:
Additional API to the Connection interface -- clearLastError()
Who Benefits From The Change(s)?
Anyone that is checking the getLastError() after each publish
Alternative Approaches
Last error message has a TTL and is cleared within a specified time.

https://github.com/nats-io/nats.java/pull/750


Fail fast approach when running multiple test functions in a test package

Provide a flag during test execution to  exit execution on the occurrence of first test failure.
Example : If the test package had 5 test functions, and the 3rd test function were to fail, the flag would allow the execution to exit at this point without running the remaining tests.

@Madzee I think this is similar to issue #98
This is definitely something that would be useful.

xref: #112

/remove-lifecycle stale

I think this can be closed.

Yes. We should close this one. The --fail-fast takes are of the ask from this one.


Can't roundtrip fixed shape tensors to Lance

We can write them, but it seems we aren't storing the schema metadata correctly because we an error when trying to load the schema:
pyarrow.lib.ArrowInvalid: Invalid serialized JSON data:

Reproduction:
import pyarrow as pa
import lance

tensor_type = pa.fixed_shape_tensor(pa.float32(), [2, 3])
inner = pa.array([float(x) for x in range(1, 7)], pa.float32())
storage = pa.FixedSizeListArray.from_arrays(inner, 6)
f32_array = pa.ExtensionArray.from_storage(tensor_type, storage)

tab = pa.table({'x': f32_array})

dataset = lance.write_dataset(tab, "test_dataset")

>>> dataset.schema()
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Users/willjones/Documents/lance/python/python/lance/dataset.py", line 199, in schema
    return self._ds.schema
  File "pyarrow/types.pxi", line 3054, in pyarrow.lib.Schema._import_from_c
  File "pyarrow/error.pxi", line 144, in pyarrow.lib.pyarrow_internal_check_status
  File "pyarrow/error.pxi", line 100, in pyarrow.lib.check_status
pyarrow.lib.ArrowInvalid: Invalid serialized JSON data:

>>> dataset.to_table()
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Users/willjones/Documents/lance/python/python/lance/dataset.py", line 269, in to_table
    ).to_table()
  File "/Users/willjones/Documents/lance/python/python/lance/dataset.py", line 871, in to_table
    return self.to_reader().read_all()
  File "/Users/willjones/Documents/lance/python/python/lance/dataset.py", line 874, in to_reader
ExecNode(Projection): channel closed
    return self._scanner.to_pyarrow()
  File "pyarrow/ipc.pxi", line 806, in pyarrow.lib.RecordBatchReader._import_from_c
ExecNode(Projection): channel closed
  File "pyarrow/error.pxi", line 144, in pyarrow.lib.pyarrow_internal_check_status
  File "pyarrow/error.pxi", line 100, in pyarrow.lib.check_status
pyarrow.lib.ArrowInvalid: Invalid serialized JSON data:

Fixed by https://github.com/lancedb/lance/pull/1173


Get the namespace that a socket is connected to?

I cannot seem to be able to figure out how to get the namespace that a socket is connected to from a Socket object. Is this possible? Thank you very much.

Its just socket.nsp. Sorry.


Replaced 0 references to assets

Hi,
I can not seem to work this one out.
Grunt task:
        useminPrepare: {
            html: 'index.html',
            options: {
                dest: '.'
            }
        },
        usemin: {
            html: ['build/development/index.html']
        },

Grunt register task:
grunt.registerTask('deploy-development', [
    'clean:cleanDevelopment',
    'copy:buildDevelopment',
    'useminPrepare:html',
    'cssmin:stylesDevelopment',
    'cssmin:bootstrapDevelopment',
    'uglify:mainDevelopment',
    'usemin'
]);

HTML file
<!-- build:css css/bootstrap.min.css -->
  <link rel="stylesheet" type="text/css" href="css/bootstrap.css" media="screen" />
<!-- endbuild -->

CLI output:
Running "copy:buildDevelopment" (copy) task
Created 13 directories, copied 137 files

Running "useminPrepare:html" (useminPrepare) task
Configuration changed for concat, uglify, cssmin

Running "cssmin:stylesDevelopment" (cssmin) task

Running "cssmin:bootstrapDevelopment" (cssmin) task

Running "uglify:mainDevelopment" (uglify) task
>> 1 file created.

Running "usemin:html" (usemin) task
Replaced 0 references to assets

Dos anybody see what could be the issue?

@be-codified what usemin version are you using ?
If you can share your project or at least something to reproduce your use case it will be better.

@stephanebachelier thank you for your reply. I am using version 3.0
You can take a look here: https://github.com/be-codified/personal-presentation-site/tree/development
Please let me know if you need some additional files or folders. Not all of them are pushed on GitHub.

@stephanebachelier please note that I have changed block as follows:
    <!-- build:css css/somefile.min.css -->
        <link rel="stylesheet" type="text/css" href="css/somefile.css" media="screen" />
    <!-- endbuild -->

@stephanebachelier did you have any time to look at it? Thank you in advance.

I have exactly the same problem. I don't know if I screwed up my Gruntfile configuration or is it some issue with grunt-usemin. I use version 3.0.0 and here's my:
Gruntfile:
https://gist.github.com/sqal/d00f6808b571825cf57a.
app/index.html
https://gist.github.com/sqal/340c6b0509236966c6aa
In the output build/index.html, grunt-usemin replaced my CSS/JS blocks, like so:
<link rel="stylesheet" href="assets/css/app.css">
<script src="assets/js/app.js"></script>
but I don't see in my build folder any concatenated css/js files, just index.html. Any ideas?


Test crashes when applying tta

I tried to test with multiscale tta(MultiScaleFlipAug), but the test seemed to crash.
Is there any examples to run ttas? Thank you!

nevermind, this was due to memory oom. Reducing the img size solved the problem.


Update PT locale

Update Portuguese translation for 4.7.10.
I just read #735, so just tell me when to generate the locales again, and I will update the translation for 4.8. :)

Thank you!
I have however recently closed development on the 4.7.x branch, and work on 4.8.x has now started. As a result, more strings change are expected to happen before the next release. I'll keep this PR open, and ping you before the release so you can update the translation.

Perfect!


Do not set ego vehicle as autopilot after replay ends

Hi CARLA team:
The current replay API client.replay_file("recording01.log", start, duration, camera) will set all vehicles to autopilot after duration. However, sometimes I might do not want to set the ego vehicle as autopilot. Is it possible to provide an API with one more argument such as "id", and the vehicle with the provided id will not be autopilot after the duration ends?

Hi, yes, we will add an option to ignore the hero vehicle from the replayed session. That way all other actors will be reproduced but the ego vehicle will be free to drive every time in the same conditions. That means also that the hero vehicle will not continue in autopilot at end of the replay session, and that part is what you request. Sounds that good?

Yes that's perfect, thanks for the update!


replacing depricated API with newer one for mysql helm chart

Change Overview
Deployment extensions/v1beta1 is depricated since 1.16
Pull request type
Please check the type of change your PR introduces:

[x] :bug: Bugfix

Test Plan

[x] :muscle: Manual

helm install examples/helm/kanister/kanister-mysql/ --dry-run --debug

---
# Source: kanister-mysql/templates/deployment.yaml
apiVersion: apps/v1
kind: Deployment
metadata:
  name: named-porcupine-kanister-mysql
  labels:
    app: named-porcupine-kanister-mysql
    chart: "kanister-mysql-0.26.0"
    release: "named-porcupine"
    heritage: "Tiller"
  annotations:

@tdmanv we are killing these examples soon, right?


AQL WINDOW keyword

Scope & Purpose
Add a WINDOW keyword to AQL to allow for features equivalent to SQL window functions

[x] :pizza: New feature
[x] :computer: The behavior change can be verified via automatic tests

Backports:

[x] No backports required
[ ] Backports required for: (Please specify versions)

Related Information

[x] Design documents:

https://docs.google.com/document/d/1bgJNA0MecGmV40VU1tgk13gbiMuFnYNHKgUPctat-ag
https://docs.google.com/document/u/1/d/1pAPHmRSi-pj8fxMY9FZtBt9COM5xegC43HCj2CTBSjk/edit?usp=sharing_eip&ts=5f6c9ba9
Testing & Verification
(Please pick either of the following options)

[ ] This change is a trivial rework / code cleanup without any test coverage.
[ ] This change is already covered by existing tests, such as (please describe tests).
[x] This PR adds tests that were used to verify all changes:

[ ] Added Regression Tests
[ ] Added new C++ Unit Tests
[x] Added new integration tests (i.e. in shell_server / shell_server_aql)
[ ] Added new resilience tests (only if the feature is impacted by failovers)

http://jenkins01.arangodb.biz:8080/view/PR/job/arangodb-matrix-pr/12370/
Documentation

[x] Added a new section in the Manual: https://github.com/arangodb/docs/compare/feature/window-aql?expand=1

http://jenkins01.arangodb.biz:8080/view/PR/job/arangodb-matrix-pr/12379/

tests blue

http://jenkins01.arangodb.biz:8080/job/arangodb-matrix-pr/12440/

http://jenkins01.arangodb.biz:8080/job/arangodb-matrix-pr/12452/

http://jenkins01.arangodb.biz:8080/job/arangodb-matrix-pr/12458/

why? it literally just fetches rows from above

Same is true for other nodes as well, but that doesn't mean we have to avoid testing more complex scenarios.
E.g. at some point views suddenly stopped working with spliced subqueries.

http://jenkins01.arangodb.biz:8080/job/arangodb-matrix-pr/12470/

http://jenkins01.arangodb.biz:8080/job/arangodb-matrix-pr/12471/

http://jenkins01.arangodb.biz:8080/job/arangodb-matrix-pr/12475/


[ART-5986] Allow URL filtering for build status page

Enhanced the BUILD_HISTORY_HOME component to support URL filtering. This update enables the users to filter the build status page based on various parameters directly through the URL. For instance, navigating to art-dash.engineering.redhat.com/dashboard/build/history?group=openshift-4.11 (you can try this by going to my hackspace url: https://art-dash-hackspace-martin.apps.artc2023.pc3z.p1.openshiftapps.com/dashboard/build/history?group=openshift-4.11, it will automatically apply the respective filters on the page.
The changes also ensure that any filters applied on the page are reflected in the URL, which provides a more interactive and user-friendly experience.
This was achieved by:

Importing and utilizing the useRouter hook from next/router to listen for route changes.
Creating a function to update the URL with the applied filters.
Utilizing useEffect hooks to initialize filter states from the URL and re-fetch data when search parameters change.

🎉
/approve
(very much so)
Gonna leave lgtm to humans who might be more opiniated about the react code :)


Add native_diox_adapter plugin

This is the code from my native_dio_client package, but adapted to diox.
I've changed the name from client to adapter to better reflect the dio terms.
The code unfortunately isn't really tested, but it's tested in production. native_dio_client has a popularity of about 80%.
The plugin works like this:
The main logic is within the ConversionLayerAdapter class. That class basically converts all diox requests to requests compatible with the http lib. Both cupertino_http and cronet_http provide http compatible clients. This keeps the maintenance effort low as we don't need to implement individual adapter for both libraries.
Because of the way cupertino_http and cronet_http work, the plugin has a dependency on Flutter and http.
New Pull Request Checklist

[x] I have read the Documentation
[x] I have searched for a similar pull request in the project and found none
[x] I have updated this branch with the latest main branch to avoid conflicts (via merge from master or rebase)
[x] I have added the required tests to prove the fix/feature I'm adding
[x] I have updated the documentation (if necessary)
[x] I have run the tests without failures

We'll use the CFUG publisher to publish the plugin in the next workflow running Is that fine for you?

Yes, that's fine


Running open-rpc-generator generate -c overwrites package.json

Describe the bug
Running open-rpc-generator generate removes all custom scripts from package.json.
To Reproduce
Steps to reproduce the behavior:
add custom script to package.json
run open-rpc-generator generate -c open-rpc-generator-config.json
and all custom scripts will be deleted from package.json
Expected behavior
All custom scripts stay intact

:tada: This issue has been resolved in version 1.22.1 :tada:
The release is available on:

GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:


chore(main): release 0.0.2

:robot: I have created a release beep boop
0.0.2 (2024-06-24)
Features

add support custom IAM role rules (#50) (912c0f3)

Other

remove vsphere palette oriented resources (#34) (9213c76)

Docs

update README (#58) (38b469e)

Dependency Updates

deps: update github.com/spectrocloud-labs/prompts-tui digest to 3f0e83e (#51) (1aa0810)
deps: update module gopkg.in/yaml.v2 to v3 (#41) (210f63e)
deps: update module gopkg.in/yaml.v2 to v3 (#55) (a0a13c0)
deps: update module gopkg.in/yaml.v2 to v3 (#56) (8dc9ab2)
deps: update softprops/action-gh-release digest to a74c6b7 (#43) (432891a)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

v0.0.2
:sunflower:


Cache CI dependencies for exact Python versions

Pull request checklist:

[ ] CHANGELOG.md was updated, if applicable
[ ] Documentation in docs/ or install-docs/ was updated, if applicable
[ ] I have tested all changes

Looks good to me!


Make ModuleInfo private

The ModuleInfo class is a public class to support the GetModuleContext() function. With recent changes, it should now be possible to not rely on this class in the GetModuleContext() function and maybe remove / refactor it.
See also jeffdiclemente#4.

This class has been removed when working on issue #25 .


Poller terminates on {:error, "Bad Gateway"}

It has now happened twice that one of my bots terminates due to an unhandled error condition when starting polling from the Telegram API:
09:53:56.481 [info] Running in polling mode
09:53:56.502 [error] Task #PID<0.1914.0> started from Telegram.Poller terminating
** (MatchError) no match of right hand side value: {:error, "Bad Gateway"}
   (telegram 0.22.3) lib/poller.ex:113: Telegram.Poller.Task.set_polling/1
   (telegram 0.22.3) lib/poller.ex:101: Telegram.Poller.Task.run/2
   (elixir 1.14.2) lib/task/supervised.ex:89: Task.Supervised.invoke_mfa/2
   (stdlib 4.1.1) proc_lib.erl:240: :proc_lib.init_p_do_apply/3
Function: &Telegram.Poller.Task.run/2
   Args: [D2rBot.Telegram.Bot, "<token>"]

09:53:56.511 [notice] Application d2r_bot exited: shutdown
{"Kernel pid terminated",application_controller,"{application_terminated,d2r_bot,shutdown}"}
Kernel pid terminated (application_controller) ({application_terminated,d2r_bot,shutdown})
Crash dump is being written to: erl_crash.dump...done

I'm not sure what is happening. Maybe network connection is lost on my side. But I also have no idea how I should tolerate that on my side. I would expect the bot to just stay alive until the network connectivity is back or the Telegram API answers correctly. What do you think?

Yes @MLNW you are right.
I see where the issue is, I'll fix it Friday evening.
Thank you for the report

@MLNW check out release 0.22.4.

Thank you very much @visciang, I have updated my bot. If it happens again I'll let you know.


Guard artisan clear-optimize against failure

Composer updated on a CI server Laravel from 5.2.7 to 5.2.45, then tried to regenerate the compiled cache:
Fatal error:
Declaration of Illuminate\Auth\SessionGuard::basic() must be compatible with Illuminate\Contracts\Auth\SupportsBasicAuth::basic($field = 'email',
$extraConditions = Array)
in /home/app/workspace/test-notifications-php/bootstrap/cache/compiled.php on line 462
Same issue here: http://stackoverflow.com/questions/34798659/l5-2-php-fatal-error-declaration-of-illuminate-auth-sessionguardbasic.
It's a little annoying clear-optimize needs Laravel in good standing to be able to work. In such cases, if it I wonder if we shouldn't try/catch such error, and force deletion of the compiled file.

This was fixed in v5.2.25 by the introduction of ComposerScripts, the new approach runs the scripts without having to initialise the whole application. However you need to update your composer.json file for the new update to work, check the difference here:
https://github.com/laravel/laravel/pull/3699/files


PHP7: Fix some bugs, generally add more compatibility

More work towards  the development branch.
Just merge it after about a week when there are several commits piled up,
so i don't have to create loads of PRs

Thanks. I'm wondering if we should freeze master branch

@andresgutierrez
That would atleast reduce the amount of possible merge conflicts, right?

It's not needed to freeze master,
For example I can merge master to develop....

@andresgutierrez
Maybe it's time to give write access to @steffengy ?
He can works in development branch

@ovr +1

@ovr
Of course it's not needed and works without, but the main reasons I think would be to

keep master stable
reduce the amount of merges, by introducing all changes in development (insteadof master)
and then merging one time, once it's deemed stable

I also wouldn't mind write access, but that is also no requirement :)

@steffengy
Write access is needed
You can push PHP 7 changes directly to development branch

@ovr
I agree that if I had those rights, it would make some stuff much easier.
But until then I guess I'll have to create some PRs regularily.


Decouple QuantConnect.Views build configuration

The purpose of this pull request is to decouple the QuantConnect.Views build configuration from the rest of the solution. This is achieved by changing QuantConnect.Views 'Output Type' to 'Console Application' and removing the QuantConnect.Views reference in the QuantConnect.Launcher project.
This will enable QuantConnect.Views to run as a separate 32 bit process (which it must because of its dependency on GeckoFX) and allow the rest of the solution to run as a 64 bit process.
The interprocess communication between Lean and the UI is achieved over tcp sockets and leverages the NetMQ library - a 100% native C# implementation of ZeroMQ for .NET. NetMQ was chosen because of it’s ability to asynchronously send messages over tcp, while preserving the message order.
A new message handler, StreamingMessageHandler, is added which processes the messages in-line using a NetMQ Push Socket. This is now the default message handler for the desktop environments.  The port on which the NetMQ communicates, as well as the location of the UI executable, is now configurable in config.json.
The UI uses a NetMQ Pull Socket in a new class called DesktopClient.cs.  The desktop client uses an instance of a new interface, IDesktopMessageHandler, to push messages to the UI.  LeanWinForms.cs now implements this interface.

Replacement for PR: https://github.com/QuantConnect/Lean/pull/494

So glad this was completed. I had made some progress with a version running over http but this is a much better approach. One of the things that will be possible now the UI is a separate process is switching to a chromium based browser engine that may play nicely in linux, or perform better in backtest.
@andrewhart098 I'm interested in NetMQ. How does this compare to RabbitMQ and MSMQ? How do you think it will scale in an enterprise?

@jameschch - One interesting option for building a cross-platform, desktop client is electron.  There are already zeromq bindings for  node.  It would be great if the client could be connected to multiple instances of Lean and have different tabs for each backtest.
Compared to other messaging queues, ZeroMQ is unique because it is a broker-less model which means that unlike most other products, you don’t need to install and run a message queuing server/broker. Simply reference the NetMQ library on NuGet.
The performance numbers for zeromq can be found here. I don't know what your standards for perf are, but I think a throughput of over 9000 Mb/s for 1Mb messages with just over 1 millisecond in latency is really good.  From what I've read, brokerless is generally way faster than brokered (e.g. RabbitMQ, MSMQ). Brokerless is really the only messaging queue option in this situation anyways.
That being said, without a broker – it’s up to the application to handle things when they go wrong.  I’m not entirely clear what the requirements for Lean are in an enterprise setting, but I think that with the flexibility a separate client process provides, there is a simple solution to make a really robust desktop client using zeromq for messaging.

I love the fact that zeromq is brokerless. This aligns well with the deployability of a microservice architecture, which is the main reason for reignited interest in messaging.
In terms of the desktop client I was trying to think of a way to provide a ui service to local or remote lean instances for monitoring and alerting. As you say it's conceptually tied to something in particular. I'd like it if it listened to whoever was talking. Standing it up as a service can be straightforward, tabbing multiple input streams sounds more laborious.


modules: programs: rofi: init

TODO: themes. As home-manager's rofi module provides a theme option, I decided to leave that for another PR, once we really implement the theming system.

Were you able to make it work with rofi's plugins without the configuration part?

I haven't :/ I pushed what I began to do in the WIP commit. I won't have a lot of free time in the next few days to investigate how to make a rofi plugin though :/

I put the enable option for i3 support inside an i3 attribute for future support of i3 keybindings.

I put the enable option for i3 support inside an i3 attribute for future support of i3 keybindings.


Do you persist /etc/nixos?

In ephemeral setups, you're supposed to persist /etc/nixos (or wherever your config is located) somewhere right? I looked through your config:
https://github.com/Misterio77/nix-config/blob/68939a161c97bb875fb1ead17c172c36de24bd01/hosts/common/global/optin-persistence.nix#L11-L20
But I can't find where are you persisting your config directory. Do you even persist it at all?

If I had to guess, its persisted in their home directory and then they use main/deploy.sh to deploy the changes. The script specifies the --flake arg so it is assumed to be in the current directory.

Ah right, that makes sense. I guess he is putting his config in one of his persisted directories.


Pioneer NFT: This account was not participated in Robonomics Crowdloan 1st wave

When trying to retrieve the Pioneer NFT, I get the message: This account was not participated in Robonomics Crowdloan 1st wave. I definitely did participate. Also, the youtube video is different from the actual redemption page. Please advise.

@vol4tim any updates?


Fix installing extras of module dependencies

Description
closes #3443
Self Check:
Strike through any lines that are not applicable (~~line~~) then check the box

[x] Attached issue to pull request
[x] Changelog entry
[x] Type annotations are present
[x] Code is clear and sufficiently documented
[x] No (preventable) type errors (check using make mypy or make mypy-diff)
[x] Sufficient test cases (reproduces the bug/tests the requested feature)
[x] Correct, in line with design
[x] ~End user documentation is included or an issue is created for end-user documentation (add ref to issue here: )~

Reviewer Checklist:

[ ] Sufficient test cases (reproduces the bug/tests the requested feature)
[ ] Code is clear and sufficiently documented
[ ] Correct, in line with design

Processing this pull request

Failed to merge changes into iso4 due to merge conflict.Please open a pull request for these branches separately.

Merged into branches master in 8646e6d1bd533c7963f2baed4936eacd565d4d97

Not closing this pull request due to previously commented issues for some of the destination branches. Please open a separate pull request for those branches. You can safely close this pull request and delete the source branch.

This branch was not deleted as it seems to still be in use.

Processing #4232.


Fix vector search doc score query bugs

This commit fixes one major bug and has two minor performance improvements.
In a pure disjunction case within the BoolQuery (and probably other times), the maximum score up to NO_MORE_DOCS is calculated.
AbstractKnnVectorQuery.DocAndScoreQuery was consistently adding the current leaf-context's docBase to the passed in parameter. This would cause int to rollover and DocAndScoreQuery would return 0 for its highest score in the segment when it obviously wasn't.
The two minor performance improvements are around count and Weight#scorer.
segmentStarts is a monotonically increasing start for each scored document indexed by leaf-segment ordinal. Consequently, if the upper and lower segments are equivalent, that means no docs match for this segment.
Count is similarly calculated by the difference between upper and lower segmentStarts according to the segment ordinal.

I see that the maxScore was fixed within: https://github.com/apache/lucene/pull/12146
Will revert that part and simply add the tests && minor optimizations :)


fix: merge config doesn't work when user configs as a function.

Description

Additional context

What is the purpose of this pull request?

[x] Bug fix
[ ] New Feature
[ ] Documentation update
[ ] Other

Before submitting the PR, please make sure you do the following

[x] Read the Contributing Guidelines.
[x] Read the Pull Request Guidelines and follow the PR Title Convention.
[ ] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
[ ] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
[ ] Ideally, include relevant tests that fail without this PR but pass with it.

The types already forbid passing a function as an argument, so I don't think we need this?

The types already forbid passing a function as an argument, so I don't think we need this?

Hi, thank u for your response. The reason I made this change was because I was having some issues.
I try to split vite.config.ts into vite.config.base.ts and vite.config.dev.ts and merge the two via mergeConfig
code here
When the defineConfig in vite.config.ts is passed in an object, everything is normal, but when it is passed in a function, the configuration in vite.config.base.ts seems to be invalid.
I try to look at the source code of defineConfig and mergeConfig, I think the problem is in mergeConfig, because defineConfig can accept an object and a function, and export it directly. After I made this modification, it seemed to fix the issue.
Is there a better solution for this?😭

You can call the function before passing it to mergeConfig. I don't think this needs to be changed in Vite.

You can call the function before passing it to mergeConfig. I don't think this needs to be changed in Vite.

OK, thank u for your advices, much appreciate. 👍

@bluwy

The types already forbid passing a function as an argument, so I don't think we need this?

Not really. mergeConfig now accepts records.
export function mergeConfig(
  defaults: Record<string, any>,
  overrides: Record<string, any>,
  isRoot = true,
): Record<string, any> {
  return mergeConfigRecursively(defaults, overrides, isRoot ? '' : '.')
}

But from TS point of view function is assignable to
records https://github.com/microsoft/TypeScript/issues/53484
So code below is valid  but  not working
mergeConfig(
  defineConfig(() => ({})),
  {},
);

I'm agreed that it is better to avoid calling functions automatically because in that case we can have unobvious behaviour with initialization order. But we need to forbid passing functions in mergeConfig types.

That's a strange TS behaviour, I'm not sure how we can forbid passing functions strictly though, the Record<string, any> doesn't represent the root Vite config only, it could represent a sub-config and there's not nice way to type it.

Interesting. I think we'd still need the return type to be Record<string, any> to not break the ecosystem, but for the inputs that could be fine.


Conflict with Midi

Getting this error with new version of ATV:

FTC tracked down to a conflict with Midi.
Versions:
Foundry 11.308
Dnd5e 2.3.1
ATV: 0.5.4
Midi: 11.0.18

Can you give me steps you are taking to make the error appear? And what cover settings are you using in Alternative Token Visibility? (I tried but cannot make that error appear using midi.)

I'm still getting this error even with just ATV, midi, libwrapper and socketlib activated.

I still cannot replicate this. Maybe it is something specific to the midi combat? Can you give me an example attack that makes this happen? (For example, target a token with a shortbow when it has half-cover...)

Also, can you send me a JSON file with your midiqol settings? (In midiqol settings, click the Workflow Settings button, go to the Misc. tab, and then click "Export midi-qol settings to json file." Send me the JSON file.) You will probably need to zip the file to upload it to Git. Alternatively, if you can open the JSON in a text editor, you can just copy/paste the contents into a Git comment.

Closed as not replicable.


The docs example in the README is broken

https://www.tomhoule.com/docs/example_module/ resolves to a 404 :)

Thanks for reporting this. PR: https://github.com/graphql-rust/graphql-client/pull/388


refactor(QueryClientProvider): validation for context being overwritten

I had an issue within our application which basically meant we were overwriting our ReactQueryClientContext with the default because of some unexpected rerendering. This meant even having set <QueryClientProvider> at basically root we were still getting the error No Query set... error. I think it would be great to supply a correct error message in this scenario as I'm sure I won't be the only one to come across this in the future.
First time contributing here, let me know if I need to change anything :)

Please have a look at this issue: https://github.com/tannerlinsley/react-query/issues/1764
i fear this PR might worsen the situation if you mount two independent microfrontends, since the second one will just get the Error :/

I’m working on a fix for all of this right now. Stay tuned.
Tanner Linsley
On Feb 15, 2021, 11:34 AM -0700, Dominik Dorfmeister<EMAIL_ADDRESS>wrote:

Please have a look at this issue: #1764
i fear this PR might worsen the situation if you mount two independent microfrontends, since the second one will just get the Error :/
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

I've got a separate fix which also addresses a few other related concerns in #1805

Awesome. Cheers @tannerlinsley 👍


Progress icon misplaced

The progress icon is misplaced when uploading offline products.
A nice improvement would be to indicate progress directly by turning the red cross icon on the product line into a progress indicator.

@teolemon I'm also thinking to replace listView by RecyclerView can I do that?

I also want to confirm what are all parameters about any product which are necessary to upload it.
On analyzing the code I found out the following code:
 if (isEmpty(product.getBarcode()) || isEmpty(product.getImgupload_front())
                        || isEmpty(product.getBrands()) || isEmpty(product.getWeight()) || isEmpty(product.getName())) {
                    imageIcon = R.drawable.ic_no_red_24dp;
                }

which shows that if any of product.getBarcode() , product.getImgupload_front() , product.getBrands() , product.getWeight() , product.getName() is empty than only the red cross icon will be shown otherwise there is also a green right icon which is shown.
And while uploading the data online it only checks product.getBarcode() and  product.getImgupload_front() is not empty and if it is not then products get uploaded.
So I want to confirm that don't we need to check other parameters like brand, name etc is before uploading a product.
Also as mentioned in the issue that red icon should be replaced with progressBar while uploading products is it also the case with green tick icon.

@teolemon please look into it :).

@itchix Can I have your opinion ?

Hie @teolemon, I would like to work on this issue.

You can go ahead. During a test, I couldn't see the spinner on latest trunk though.

Yes, exactly, me too. I will go through the code and will try to fix that.


Add frontendApi to type NextClerkProviderProps

This prop is currently missing.
Type of change

[x] 🐛 Bug fix
[ ] 🌟 New feature
[ ] 🔨 Breaking change
[ ] 📖 Refactoring / dependency upgrade / documentation
[ ] other:

Packages affected

[ ] @clerk/clerk-js
[ ] @clerk/clerk-react
[x] @clerk/nextjs
[ ] @clerk/types
[ ] @clerk/clerk-expo
[ ] @clerk/backend-core
[ ] @clerk/clerk-sdk-node
[ ] @clerk/edge
[ ] build/tooling/chore

Description

[x] npm test runs as expected.
[x] npm run build runs as expected.

@igneel64 Hi! I only found the feature because you currently have it listed in the docs, albeit the generic react variant. I thought it was simply a mistake it was left out.
I'm using it because I manage my env var naming differently than nextjs recommends. I have a monorepo with apps on a few different platforms, shared libraries between them, and a centralized way of managing secrets so that they all line up.
That said, I discovered later yesterday that you develop on next, not main, and now I'm also running the alpha, so if you are open to this PR, I can recreate it against the right branch.
Thanks!


API's dead?

looks like the API's are dead, any chance to update to new API's?

The cryptonator.com API is now dead so I would have to update the project to use a new API to make it work. If you or anyone has the time or HW to do so Pull Requests are welcome


add osm tag converter utility

fix #1102

hi @myarjunar
could you move the utilities in here?
https://github.com/healthsites/healthsites/blob/v2/django_project/localities_osm/utilities.py
because it is specifically for osm

could you move the utilities in here?
https://github.com/healthsites/healthsites/blob/v2/django_project/localities_osm/utilities.py
because it is specifically for osm

Hi @meomancer , thanks for reviewing and giving feedback! This tag converter tools has nothing to do with the LocalityOSM model and so far will only be used inside the api module. Isn't it better to keep it in this module? Or maybe it's even better to create common utilities that decoupled from any kind of django app, because my intention was to make this generic too. What do you think?
*would like to get this PR merged first so I can push another PR asap

please see new PR here https://github.com/healthsites/healthsites/pull/1142


FIX doc related to README and the bm install

Hi @Noreen21 : Thanks for the hint. I changed the text to your suggestion and submitted a new PR.


[feature] Filter comments by commit

🧩 Feature
Description
When we are reviewing multiple branches of a same project at the same time, the comments get mixed (in the tree-view, in the export), making it difficult to distinguish them and to communicate with the rest of the team.
The capability of filtering the comments based on the current commit ID would solve this issue.
In filtered mode:

Only the wanted comments will be displayed in the tree-view.
Only the wanted comments will be exported.

Switching from one commit to another with automatically refresh the list.
It will be possible to switch back to an all comments view at any time.
A pull request dedicated to this feature is coming soon.

@michelcaradec thanks for your contribution. I just published Version 1.22.0 🎉

@michelcaradec thanks for your contribution. I just published Version 1.22.0 🎉


[FEATURE] UI Theming

Allow the user to change the theme and colors of the admin console
Requested by

lazysoph

This issue has been moved to https://github.com/rGunti/FloppyBot-AdminConsole/issues/7


Fixed common CSS style GET request timeout [9020]

Signed-off-by: RaulSanchez<EMAIL_ADDRESS>

Build status:


Tasks: [OSX] Task no longer executes in correct user environment

VSCode Version: Insiders June 28th 2016.
OS Version: Capitan 10.11.5

Steps to Reproduce:

Define a task that executes a shell script. In this shell script invoke an npm command
Result: ./build.sh: line 2: npm: command not found

This works fine in VSCode v. 1.2.1

@wallverb this looks very much like a dup of #8434. #7342 talks about debugger only.

Whoops! Totally looked for dupes but with that title, I'm not surprised I couldn't find it! The workaround of starting Code from the shell worked great.


Customizing the view

Hello there,
I would like to customize the bar chart screen by adding some detail information (labels) under the generated bar chart.
I couldnt manage to customize the generated scrollview.
Any clues?

I couldnt manage to customize the generated scrollview.

I do not understand what you mean in this sentence

Ok, there are 3 problems in my project whenever i want to use bar chart. i added the screenshot of my app.1- i dont want the bar chart part of the screen to be scrollable 2- i want to make the whole screen scrollable 3- i want to modify - add / remove ui elements - to the lower part where i circled with red markerSo, can you provide an example for those?  30.07.2019, 04:29, "An An" notifications@github.com:I couldnt manage to customize the generated scrollview.I do not understand what you mean in this sentence—You are receiving this because you authored the thread.Reply to this email directly, view it on GitHub, or mute the thread.

My bad, found the answer in documantation.


[Feature] Implement programs.fish.enableCompletion

Issue description
There already exists programs.bash.enableCompletion and 	programs.zsh.enableCompletion options, however, there is no such option for the fish shell. I think this could be very useful. Right now, there's no auto-completion in fish shell when trying to use commands like nix-env -iA.

Fish already has completions enabled by default. It is just that nobody created one for nix-env. There is fish_update_completions tool that can generate completions files from manpages, which the module runs on environment.systemPackages but, obviously, it cannot figure out how to suggest attribute names.

Oh, ok, thanks for explaining. Is there perhaps another way to implement completions for attribute names?

You can take the generated completions (run the fish_update_completions and look into ~/.local/share/fish/generated_completions) and add the attributes manually. It should not be that hard, something like this https://github.com/fish-shell/fish-shell/blob/ac2eed2ffa71aa6db08dad2ea6f6b0dd89f815d6/share/completions/composer.fish#L223, only replacing the function with one that returns list of attributes. Try looking at bash completion how they do it.

So, I guess I want to have better all-around completions for nix shell commands. fish_update_completions doesn't work that well, e.g., there's no auto-completion for subcommands and the documentation for the options is poorly extracted.
I think it would be best to extend, improve and package fish-nix-completions. Similarly to bash-nix-completions and zsh-nix-completions.

I just saw this ticket, and it is important to me enough that I wouldn't want a bot to kill it as stale.  I just transitioned from ZSH to Fish, so haven't dug too deep into how I might be able to help.

Given the last comments workaround-related comments are from over a year ago, can someone share or confirm the currently working solution/workaround for this?

I'd like a programs.fish.enableCompletion too !

There seems also no fish completion for nixos-rebuild sub command : (

I'm rather new to Nix and Fish.
I would expect that something like (https://discourse.nixos.org/t/how-to-use-completion-fish-with-home-manager/23356/4)
xdg.configFile."fish/completions/nix.fish".source = "${pkgs.nix}/share/fish/vendor_completions.d/nix.fish";

would be executed for every added package when
programs.fish.vendor.completions.enable is true (which should be true by default when fish is installed) and ${pkgs.xxx}/share/fish/vendor_completions.d/xxx.fish exists.


Store declined bundle installations in settings

Fixes #989
For imports in application code, we can use the VisTrails configuration; this is done for IPython.
For optional imports in packages, I would like to use the package's configuration, however there doesn't seem to be a way for the package to change its configuration. Needed for tabledata and URL packages.

How about using an "ignoredPackages" global configuration option containing a comma-separated list of imports to ignore? This would work cross-packages and that seems to make sense for optional imports. You would probably not want to use an import in one package but not in another. Users would be able to undo this by editing the list (or just clear it). Required packages should not use ignored packages.

I guess having this global makes sense. I will go for this.


RTM Head

Why do I get this error when i try to run my own fisher prunning template :
Traceback (most recent call last):
File "/content/mmrazor/mmpose/tools/train.py", line 162, in
main()
File "/content/mmrazor/mmpose/tools/train.py", line 155, in main
runner = Runner.from_cfg(cfg)
File "/usr/local/lib/python3.10/dist-packages/mmengine/runner/runner.py", line 462, in from_cfg
runner = cls(
File "/usr/local/lib/python3.10/dist-packages/mmengine/runner/runner.py", line 429, in init
self.model = self.build_model(model)
File "/usr/local/lib/python3.10/dist-packages/mmengine/runner/runner.py", line 836, in build_model
model = MODELS.build(model)
File "/usr/local/lib/python3.10/dist-packages/mmengine/registry/registry.py", line 570, in build
return self.build_func(cfg, *args, **kwargs, registry=self)
File "/usr/local/lib/python3.10/dist-packages/mmengine/registry/build_functions.py", line 232, in build_model_from_cfg
return build_from_cfg(cfg, registry, default_args)
File "/usr/local/lib/python3.10/dist-packages/mmengine/registry/build_functions.py", line 121, in build_from_cfg
obj = obj_cls(**args)  # type: ignore
File "/content/mmrazor/mmrazor/implementations/pruning/group_fisher/algorithm.py", line 57, in init
self.mutator.prepare_from_supernet(self.architecture)
File "/content/mmrazor/mmrazor/models/mutators/channel_mutator/channel_mutator.py", line 113, in prepare_from_supernet
units = self._prepare_from_tracer(supernet, self.parse_cfg)
File "/content/mmrazor/mmrazor/models/mutators/channel_mutator/channel_mutator.py", line 311, in _prepare_from_tracer
unit_configs = tracer.analyze(model)
File "/content/mmrazor/mmrazor/models/task_modules/tracer/channel_analyzer.py", line 107, in analyze
fx_graph = self._fx_trace(model)
File "/content/mmrazor/mmrazor/models/task_modules/tracer/channel_analyzer.py", line 132, in _fx_trace
args = self.demo_input.get_data(model)
File "/content/mmrazor/mmrazor/models/task_modules/demo_inputs/demo_inputs.py", line 34, in get_data
data = self._get_data(model, input_shape, training)
File "/content/mmrazor/mmrazor/models/task_modules/demo_inputs/default_demo_inputs.py", line 108, in _get_data
return defaul_demo_inputs(model, input_shape, training, self.scope)
File "/content/mmrazor/mmrazor/models/task_modules/demo_inputs/default_demo_inputs.py", line 79, in defaul_demo_inputs
return demo_input().get_data(model, input_shape, training)
File "/content/mmrazor/mmrazor/models/task_modules/demo_inputs/demo_inputs.py", line 34, in get_data
data = self._get_data(model, input_shape, training)
File "/content/mmrazor/mmrazor/models/task_modules/demo_inputs/demo_inputs.py", line 57, in _get_data
data = self._get_mm_data(model, input_shape, training)
File "/content/mmrazor/mmrazor/models/task_modules/demo_inputs/demo_inputs.py", line 147, in _get_mm_data
data = demo_mmpose_inputs(model, input_shape)
File "/content/mmrazor/mmrazor/models/task_modules/demo_inputs/mmpose_demo_input.py", line 32, in demo_mmpose_inputs
from mmpose.models.heads import RTMHead
ImportError: cannot import name 'RTMHead' from 'mmpose.models.heads' (/content/mmrazor/mmpose/mmpose/models/heads/init.py)
Thank you fro the attention

Please show your versions of mmpose, mmrazor and so on. It seems you are using latest mmpose which may be not supported by mmrazor.

Same issue.

Fixed by changing
https://github.com/open-mmlab/mmrazor/blob/90c7af1fdf35a606a2fceaaeb4b6be2f0dac4eb7/mmrazor/models/task_modules/demo_inputs/mmpose_demo_input.py#L32
to
from mmpose.models.heads import RTMCCHead as RTMHead


Add a backend to Parse the R package DESCRIPTION files

Spec is here: https://r-pkgs.org/description.html

Testing bonus:
It would be cool if we had some tests to test this backend all by itself running on a bunch of different files that purport to be DESCRIPTION files.
It would be especially cool if you could just drop new ones into a folder somewhere in the backend directory and the test would pick them up.
I recommend first describing how you'd want to build such a test case.
This is a more complex challenge, but it's well within your skill set. If you're interested, please try it out. Try and write up your rough design here before you write the code for it.

Testing bonus:
It would be cool if we had some tests to test this backend all by itself running on a bunch of different files that purport to be DESCRIPTION files.
It would be especially cool if you could just drop new ones into a folder somewhere in the backend directory and the test would pick them up.
I recommend first describing how you'd want to build such a test case.
This is a more complex challenge, but it's well within your skill set. If you're interested, please try it out. Try and write up your rough design here before you write the code for it.

The way to purport other files to be DESCRIPTION files would be if they had the fs.FileInfo of a DESCRIPTION file since we use the Name() method of fs.FileInfo to check wether a file is a DESCRIPTION file.  So a rough design would be make a folder in backend to put files in and then I would need a method to get the contents of the files which are in bytes[] and get an fs.FileInfo of the DESCRIPTIONfile in the folder. Then we initialize a context.Context and a cran backend variable for using the ScanData method and then we run the ScanData method with the context.Context variable, contents of the file in bytes[] and the fixed fs.FileInfo in a loop for each file. Then we compare the outputs to determine if the test is successful, for starters I am thinking of just comparing the licenses and errors in the output.

Implemented in git main!


Create a CLI wrapper in Rust

The compiled executable works fine, when put in the parent folder of bin.
It can be found here: cli_wrapper.zip
Things that still need to be discussed:

Do we prefer a single source of truth in Rust over two scripts, one in bash one in cmd?
If we go with Rust, do we want to offload more work to it than setting env vars and passing on arguments?

The compiled executable works fine.
It can be found here: cli_wrapper.zip
Things that still need to be discussed:

Do we prefer a single source of truth in Rust over two scripts, one in bash one in cmd?
If we go with Rust, do we want to offload more work to it than setting env vars and passing on arguments?

Two more things that came to mind:

Do we actually have to modify the PATH on Windows? I think I remember that's not necessary if DLLs are in the same directory as the executable
Does PackageCompiler.jl modify the RPATH of the ribasim executable on Linux? If yes, we don't need a wrapper at all.

Do we prefer a single source of truth in Rust over two scripts, one in bash one in cmd?

This would mainly depend on the complexity of the two scripts versus Rust. If the bash and cmd scripts are simple and all they do is to call an exe in a subdir, perhaps not.
If however we could more easily do model validation in Rust before starting the Julia process, in a way that JSON Schemas can be validated, it could be more interesting. Perhaps it could even be an option to have Python also use the Rust code for this, or for other things that it would benefit from.
You answered you Windows PATH question in #92, and about RPATH, it looks like it, though the best approach would probably to try it out using the Linux build.

I think this can be closed for now


Clean Up of lxatac Machine Config

Cleans up and moves configurations that should be set in other locations.

Hi,
I think the commit message for the second commit was the wrong way around:
DISTRO_FEATURES should be defined in the machine, rather than in the distro.

I've turned it around to:
DISTRO_FEATURES should be defined in the distro, rather than in the machine.


[JENKINS-55663] Extend the Jenkinsfile Runner user documentation

See JENKINS-55663
Update the README.md and DOCKER.md to reflect the latest changes

The error in CI
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-install-plugin:2.5.2:install (default-install) on project parent: Failed to install artifact io.jenkins.jenkinsfile-runner:parent:pom:1.0-beta-8-SNAPSHOT: /home/jenkins/.m2/repository/io/jenkins/jenkinsfile-runner/parent/1.0-beta-8-SNAPSHOT/parent-1.0-beta-8-SNAPSHOT.pom (No such file or directory) -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException

so no related to this PR, which is updating only documentation

Merge conflict


Updated Intercom Metric Collector to set the signed-up date

@clicktravel-basharat The changes seem to be fine


Update config to enable docfx v3

AB#294688
This Pull Request is for docfxv3 migration, after the Pull Request merged, the repository will be built with docfxv3 instead of docfxv2.

Docs Build status updates of commit 0e46ecd:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error-PullRequestMergeConflict] Cannot sync git repo to specified state. Please make sure the pull request is mergeable.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Fix minsizes for all windows that needed it

About the PR
Fixes #3376
Just tweaks minsizes for most windows in the game so that they open correctly scaled
Vendors modified to have custom minsize depending on their contents (there's almost certainly a better way to do this)
Screenshots

Changelog

:cl:

fix: Fixes default window sizes for vendors, chemistry machines, etc.

I'd prefer that SetSize is set so that the window can be resized smaller.

I'd prefer that only SetSize is set so that the window can be resized smaller.

ill do this for some like the vendors but there are a couple where being able to resize it smaller would be extremely useless


LLVM Targets

In order to build Zig, it is required that LLVM is built with all default targets enabled. Is it possible that the LLVM package build script could be changed to do this?

Related https://github.com/kisslinux/community/issues/1623

Thank you for pointing me to that!

I'm reopening this because, reading through the issue you showed me, I've a different problem. After packaging LLD, and omitting the line which disables default targets from the LLVM build script, I have Zig building easily. All that should need to be done is to make this modification to the LLVM build script.

What are the size and compile-time differences between llvm the way we currently build it and the way we would need to build it?

I'm measuring them now for you :)

My compile time test won't be too accurate since these are done on my personal computer which is running other things, but should give a ballpark indication. This is done on an AMD Ryzen 1600X in a chroot.

Metric
Before
After

Compile Time (real) (s)
1109.3
1009.77

Cached Bin Size (M)
76.1
98.2

As you can see, the target change bizarrely decreased the compile time. I would interpret that as the difference in compile time being within margin of error. I'm not sure what you would think, but the 22M sacrifice is worth it for me to be able to build for different targets.

On my machine with -O2 -pipe -march=native an installed llvm built with -DLLVM_TARGETS_TO_BUILD="host" takes up 239MB, and the one with all targets enabled takes up 361MB.

Ah, I was measuring the tarballs.

That's quite the substantial size increase.
I don't think this change should be made (unfortunately), and here is my reasoning:

100MB is a lot of space to take up on someone's drive, almost especially for a package they will probably never end up using. Certainly they could fork llvm, but that seems like burdening the many for the benefit of very few.
llvm exists for precisely two things - mesa and firefox (+ clang & rust). If this distribution only targeted Intel graphics and used chromium instead of firefox, llvm probably wouldn't even be in the main repo afaik.  To implement this change for something in community sets an... unruly precedent for how much the main repository should accommodate community.
adding something like llvm-zig to community was a possible idea, but it creates a clash with things which require llvm, requiring zig users to fork packages just to ensure they don't have two llvms. This is also an undo burden for users. Having the correct llvm for zig in community is also an option, but it creates a clash with the main repo that I'm not interested in creating.

Ultimately, having zig in community would be a great +1. But I can't find a tractable solution that doesn't inconvenience some number of users, when the most friction-less option is to simply create something like $/Ominitay/kiss-zig that houses llvm, zig, and whatever other fun ziglang projects exist. The maintenance for you doesn't change, and the headache for users doesn't increase.
If you can come up with a better option than this, I'm 100% for it. Otherwise, I look forward to a new repo entering the kiss-repo topic, and I'll be mentioning it in April's This Month in KISS :)

I opened an issue with the zig development team and the issue was upstreamed to be fixed in the next release 0.8.0.
With how long llvm takes to build, adding more weight to an already heavy package to only be used by one package would set a bad precedent like @dilyn-corner has pointed out.

I'll make my own repo for this then. Thank you very much for the feedback!

How about a switch set through en environment variable? ZIG=1 kiss b llvm
https://github.com/kiss-community/repo-community/blob/main/community/webkit2gtk/build#L4
Other packages do it by checking if foois available. Unfortunately this could not be done for llvm beforehand.
This would be the first package controlled through a variable. Not the cleanest solution.

It isn't exactly a KISS solution. I think just repackaging LLVM in my kiss-zig repo is the best way to go.

I think I found a workaround for this situation.
I think for KISS, we should enable -DZIG_PREFER_CLANG_CPP_DYLIB=ON in the Zig CMake config, so that the cross-compiler (in case one doesn't really bother with cross-compiling feature of Zig) feature is up to the user. So if there's a Zig in community, one can choose between having the feature enabled or not (by choosing the LLVM provider, KISS-provided or not). Either way, you'll need to rebuild Zig anyway, but (using ninja, at least), building Zig is actually pleasant, compared to Go, Nim, or Rust.
Note: I believe a provides-like system would shine nicely here.  That works, provided that /usr/bin/ld is linked to lld. I will reopen my Zig PR, with the necessary modifications. I should probably be able to patch things to use lld without the symlink too. It is of course, an unsupported configuration, but I think it is worth the sacrifice. When Zig goes self-hosted, we shouldn't have to depend on LLVM at all.

The kiss-zig repository will remain alongside the community package I think, as it would still be wanted for cross-compilation support. Thank you all again for your help with getting this packaged!


Cedric's path image not showing up for some users in "challenge-question" objective "ducktypium-helm"

I'm not sure the root cause of this issue based on the reports. It does not seem to be happening to everyone.
There are two reports of this issue in Discord:

https://discord.com/channels/570292611215130634/804374967714054144/98307497214045389

https://discord.com/channels/570292611215130634/900321423422271529/984589686217531403

Based on the filenames the users uploaded, it seems likely they're both using MacOS. The second user definitely is since the image path in their screenshot includes "Application Support". That might be some common ground worth investigating. I would've only tested MacOS on my dev machine. This could result in an imperfect test environment.
Worryingly, both users seem to have different paths that are not working. So this might be two separate issues! (On further inspection, the first user may have just intentionally cropped their home system path out of the screenshot)

I've tried reproducing this in the dev environment and production on both MacOS and Windows across several versions of TwilioQuest with no luck. I'm wondering if this could be an issue with showdown? Based on this discussion, it makes me think the image path may be stirring things up because of the combined use of periods, dashes, and underscores. That being said, without a sure fire way to reproduce this it makes it hard to pinpoint the culprit.

Another report in Discord:
https://discord.com/channels/570292611215130634/804374967714054144/996200710549028864

Hey there, at the end of the Dark Ducktypium Forge challenge the image in the objective screen (of what I'm guessing is a map) doesn't seem to load.  The path listed doesn't seem to exist - ![Path for cedric to walk to the temple](/Users/me/Library/Application Support/_cache/releases/3.2_main/3.6.3/public/node_modules/twilioquest-base/images/challenge-questions/turtle_x4.png)

Another report:
https://discord.com/channels/570292611215130634/992456601371938818/999763190302920825

Also, not able to find the image needed to complete the Ducktypium Helm on my computer either. Is there a workaround for this? I’m on a Mac


feat: adding SKUUnavailable and NicReservedForAnotherVM

What Does this PR add
This pr adds    SKUUnavailable and NicReservedForAnotherVm errors to the sdk

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (52a003e) 84.49% compared to head (c03ed00) 84.84%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #44      +/-   ##
==========================================
+ Coverage   84.49%   84.84%   +0.35%
==========================================
  Files           6        6
  Lines         258      264       +6
==========================================
+ Hits          218      224       +6
  Misses         34       34
  Partials        6        6

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

/LGTM with minor comments


Fix/fix the cpp build on windows

This PR adds the usage of the cmake-maven-plugin back as well as addresses some code-level changes needed in order to compile TsFile CPP on Windows systems.
Manually tested with mvnw -P with-cpp clean install on:

Windows aarch64
Windows intel
Linux aarch64
Linux intel
MacOS aarch64
MacOS intel

Thanks Chris! Consider enabling the CI on windows then?
https://github.com/apache/tsfile/blob/e17e373f3e0e6354e8fe39d437086bf78bc521e3/.github/workflows/unit-test.yml#L94-L98

Excellent job!

I guess the probably most important part is to either ask the author of the code snippet to flag his repo as Apache licensed, or to send us a copy of it with an apache license header ... right now it's technically under the GitHub default license and that's not quite compatible with the Apache one.

Ok ... Windows GitHub Action builds enabled and working (Had to do a minor addition to one of the functions in order to make it work however)

Ok... I manged to reach the author of the patch and he just set the license of his repo to apache 2.0, so I guess we're good to merge the pr

So? We good to merge?

So? We good to merge?

@jt2594838


Seems like flatbuffers and cap'n proto, are there any comparasion to these projects?

You can find some answers here https://bitproto.readthedocs.io/en/latest/#scenario

Thank you, I will read the doc later.


Repurpose signinSilent for a signinIFrame method

I'd like to use the signinSilent logic to present the login screen as an IFrame in my application.  My intent is to show the IFrame in full screen when the user needs to login.  This will allow me to preserve my page state when I need to renew the server cookie.
I've gotten it to work by changing: https://github.com/IdentityModel/oidc-client-js/blob/dev/src/UserManager.js#L116 to:
args.prompt = args.prompt || "none";

and then calling signinSilent as:
signinSilent({ prompt: 'login' })

I would also need to make changes here: https://github.com/IdentityModel/oidc-client-js/blob/dev/src/IFrameWindow.js#L22 to allow for a different display type and perhaps passing in a css class.
Let me know if you think this would be worthwhile and I can create a PR, thanks.

this is a topic that has been discussed several times.
Identity server does not support signin from an iFrame due to security issues that are present with an iFrame that has UI elements.  the iFrame for data to deal with token refresh / renew has no UI.
https://github.com/IdentityServer/IdentityServer3/issues/2442
https://github.com/IdentityServer/IdentityServer3/issues/288
https://github.com/IdentityServer/IdentityServer3/issues/2808
home that answers your question.

@figuerres Thank your for the explanation.


Global leaks

I am using YUI3 on node.js but I get this when running the test:
0) SDK should convert xml into json with yql
  1) SDK should convert xml into json with yql

  ✖ 2 of 2 tests failed:

  0) SDK should convert xml into json with yql:
     Error: global leaks detected: encoding, parseQueryString

  at Runner.checkGlobals (/usr/local/lib/node_modules/mocha/lib/runner.js:78:21)
      at Runner.<anonymous> (/usr/local/lib/node_modules/mocha/lib/runner.js:40:44)
      at Runner.emit (events.js:88:20)
      at next (/usr/local/lib/node_modules/mocha/lib/runner.js:268:12)
      at /usr/local/lib/node_modules/mocha/lib/runner.js:291:25
      at done (/usr/local/lib/node_modules/mocha/lib/runnable.js:97:5)
      at Object.<anonymous> (/usr/local/lib/node_modules/mocha/lib/runnable.js:80:7)
      at Timer.ontimeout (timers.js:84:39)

  1) SDK should convert xml into json with yql:
     Error: global leaks detected: encoding, parseQueryString

  at Runner.checkGlobals (/usr/local/lib/node_modules/mocha/lib/runner.js:78:21)
      at Runner.<anonymous> (/usr/local/lib/node_modules/mocha/lib/runner.js:40:44)
      at Runner.emit (events.js:88:20)
      at next (/usr/local/lib/node_modules/mocha/lib/runner.js:268:12)
      at /usr/local/lib/node_modules/mocha/lib/runner.js:291:25
      at done (/usr/local/lib/node_modules/mocha/lib/runnable.js:97:5)
      at Object.<anonymous> (/usr/local/lib/node_modules/mocha/lib/runnable.js:80:7)
      at Timer.ontimeout (timers.js:84:39)

It comes from Mocha. The YUI3 code doesn't run into any problem when I run it without Mocha.
YUI = require("yui3").YUI

YUI().use "yql", (Y) ->

  Y.YQL 'select title from rss where url="http://rss.news.yahoo.com/rss/topstories"', (r) ->
    console.log r

Any clue?

mocha definitely doesn't have these, I think what we should do is add --global name,name,name for accepted globals

use mocha.opts or a makefile

Worked great!

awesome, was having this same problem just now... let's see if I know the name of what's leaking on purpose...


Run ica genesis/types tests.

Description
They weren't executing.
closes: #XXXX
Commit Message / Changelog Entry
nit: Run ica genesis/types tests.

see the guidelines for commit messages. (view raw markdown for examples)

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

[ ] Targeted PR against correct branch (see CONTRIBUTING.md).
[ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
[ ] Code follows the module structure standards and Go style guide.
[ ] Wrote unit and integration tests.
[ ] Updated relevant documentation (docs/) or specification (x/<module>/spec/).
[ ] Added relevant godoc comments.
[ ] Provide a commit message to be used for the changelog entry in the PR description for review.
[ ] Re-reviewed Files changed in the Github PR explorer.
[ ] Review Codecov Report in the comment section below once CI passes.

Codecov Report

Merging #4193 (e4c688f) into main (585e56b) will increase coverage by 0.59%.
The diff coverage is n/a.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4193      +/-   ##
==========================================
+ Coverage   78.86%   79.45%   +0.59%
==========================================
  Files         188      188
  Lines       12994    12994
==========================================
+ Hits        10248    10325      +77
+ Misses       2317     2240      -77
  Partials      429      429

see 1 file with indirect coverage changes

glad they pass 😅

you'd see a DM and not a PR if they didn't :smile:


Dependency doesn't exist

Hi,
The dependency is not available on maven anymore

Hi Thomas,
Unfortunately this project is not part of maven repository
however you can find the packaging here https://github.com/eBay/json-comparison/packages/68314
let me know if this answers your questions
Thanks,
Ahmad


Design Participant Query Component + Functionality

Capturing what has been said in mtgs about a user feature-flag assignment "participant query" feature that Steve says he'd like to see used for feature-flags.
Potential Requirements:

As an UI admin, I want a new root-level feature that will allow me to provide a userId and context and receive a list of all feature flags keys and experiment assignments that the user would be receiving in that environment, so that I can easily test to see if my feature-flags design setup is correct and I get expected keys from the browser.

For example, on root page, I may see a nav item that will nav to a page with a form with a "userId" text input and a app-context dropdown. When I submit these two pieces of information, I will see some kind of display of the flag keys and assignments.

Essentially this would be the exact same kind of behavior as the client call to /featureflags or /assign by userIdandcontext`, but would want it to be a new UI admin endpoint that does not produce any side-effects like marking an exposure.

Q: It would require that a flag / experiment be set to enrolling in order to simulate the "real-time" assignment... but I think the user will often want to use this feature to actually test what the user WOULD get if the flag was enabled, or the experiment was enrolling, so they can be more confident before clicking that ON switch. That may be a slightly different requirement if so.

If this is not implemented at root level, it could be a common component that could be reusable in both the feature-flags and experiments feature.

Yeah - I'm thinking this might also be useful for customer support (and, more generally, bug tracking). The "enrolling" issue is interesting, but for version 1, I'd just treat this as a feature that works when things are "live" (so it really does duplicate what "assign" would do).