Fix cfn-lint issues in CFN templates

The cloudformation templates provided by this project have a number of failures from cfn-lint that could be addressed.
W3005 Obsolete DependsOn on resource (WAFWhitelistSet), dependency already enforced by a "Ref" at Resources/WAFWhitelistRule/Properties/Predicates/0/DataId/Ref/WAFWhitelistSet
aws-waf-security-automations-alb.template:378:7

W3005 Obsolete DependsOn on resource (WAFBlacklistSet), dependency already enforced by a "Ref" at Resources/WAFBlacklistRule/Properties/Predicates/0/DataId/Ref/WAFBlacklistSet
aws-waf-security-automations-alb.template:398:7

W3005 Obsolete DependsOn on resource (WAFScansProbesSet), dependency already enforced by a "Ref" at Resources/WAFScansProbesRule/Properties/Predicates/0/DataId/Ref/WAFScansProbesSet
aws-waf-security-automations-alb.template:418:7

W3005 Obsolete DependsOn on resource (WAFReputationListsSet1), dependency already enforced by a "Ref" at Resources/WAFIPReputationListsRule1/Properties/Predicates/0/DataId/Ref/WAFReputationListsSet1
aws-waf-security-automations-alb.template:438:7

E3012 Property Resources/WAFIPReputationListsRule1/Properties/Predicates/0/Negated should be of type Boolean
aws-waf-security-automations-alb.template:451:11

W3005 Obsolete DependsOn on resource (WAFReputationListsSet2), dependency already enforced by a "Ref" at Resources/WAFIPReputationListsRule2/Properties/Predicates/0/DataId/Ref/WAFReputationListsSet2
aws-waf-security-automations-alb.template:458:7

E3012 Property Resources/WAFIPReputationListsRule2/Properties/Predicates/0/Negated should be of type Boolean
aws-waf-security-automations-alb.template:471:11

W3005 Obsolete DependsOn on resource (WAFBadBotSet), dependency already enforced by a "Ref" at Resources/WAFBadBotRule/Properties/Predicates/0/DataId/Ref/WAFBadBotSet
aws-waf-security-automations-alb.template:478:7

E3012 Property Resources/WAFBadBotRule/Properties/Predicates/0/Negated should be of type Boolean
aws-waf-security-automations-alb.template:491:11

W3005 Obsolete DependsOn on resource (WAFSqlInjectionDetection), dependency already enforced by a "Ref" at Resources/WAFSqlInjectionRule/Properties/Predicates/0/DataId/Ref/WAFSqlInjectionDetection
aws-waf-security-automations-alb.template:498:7

W3005 Obsolete DependsOn on resource (WAFXssDetection), dependency already enforced by a "Ref" at Resources/WAFXssRule/Properties/Predicates/0/DataId/Ref/WAFXssDetection
aws-waf-security-automations-alb.template:518:7

W3005 Obsolete DependsOn on resource (WAFWhitelistRule), dependency already enforced by a "Ref" at Resources/WAFWebACL/Properties/Rules/0/RuleId/Ref/WAFWhitelistRule
aws-waf-security-automations-alb.template:538:7

W3005 Obsolete DependsOn on resource (LambdaRoleLogParser), dependency already enforced by a "Fn:GetAtt" at Resources/LambdaWAFLogParserFunction/Properties/Role/Fn::GetAtt/['LambdaRoleLogParser', 'Arn']
aws-waf-security-automations-alb.template:680:7

W3005 Obsolete DependsOn on resource (WAFBlacklistSet), dependency already enforced by a "Ref" at Resources/LambdaWAFLogParserFunction/Properties/Environment/Variables/IP_SET_ID_BLACKLIST/Ref/WAFBlacklistSet
aws-waf-security-automations-alb.template:680:7

W3005 Obsolete DependsOn on resource (WAFScansProbesSet), dependency already enforced by a "Ref" at Resources/LambdaWAFLogParserFunction/Properties/Environment/Variables/IP_SET_ID_AUTO_BLOCK/Ref/WAFScansProbesSet
aws-waf-security-automations-alb.template:680:7

E3012 Property Resources/LambdaWAFLogParserFunction/Properties/MemorySize should be of type Integer
aws-waf-security-automations-alb.template:739:9

E3012 Property Resources/LambdaWAFLogParserFunction/Properties/Timeout should be of type Integer
aws-waf-security-automations-alb.template:740:9

W3005 Obsolete DependsOn on resource (LambdaWAFLogParserFunction), dependency already enforced by a "Fn:GetAtt" at Resources/LambdaInvokePermissionLogParser/Properties/FunctionName/Fn::GetAtt/['LambdaWAFLogParserFunction', 'Arn']
aws-waf-security-automations-alb.template:746:7

W3005 Obsolete DependsOn on resource (LambdaRoleReputationListsParser), dependency already enforced by a "Fn:GetAtt" at Resources/LambdaWAFReputationListsParserFunction/Properties/Role/Fn::GetAtt/['LambdaRoleReputationListsParser', 'Arn']
aws-waf-security-automations-alb.template:876:7

E3012 Property Resources/LambdaWAFReputationListsParserFunction/Properties/MemorySize should be of type Integer
aws-waf-security-automations-alb.template:897:9

E3012 Property Resources/LambdaWAFReputationListsParserFunction/Properties/Timeout should be of type Integer
aws-waf-security-automations-alb.template:898:9

W3005 Obsolete DependsOn on resource (LambdaWAFReputationListsParserFunction), dependency already enforced by a "Fn:GetAtt" at Resources/LambdaWAFReputationListsParserEventsRule/Properties/Targets/0/Arn/Fn::GetAtt/['LambdaWAFReputationListsParserFunction', 'Arn']
aws-waf-security-automations-alb.template:914:7

W3005 Obsolete DependsOn on resource (WAFReputationListsSet1), dependency already enforced by a "Ref" at Resources/LambdaWAFReputationListsParserEventsRule/Properties/Targets/0/Input/Fn::Join/1/8/Ref/WAFReputationListsSet1
aws-waf-security-automations-alb.template:914:7

W3005 Obsolete DependsOn on resource (WAFReputationListsSet2), dependency already enforced by a "Ref" at Resources/LambdaWAFReputationListsParserEventsRule/Properties/Targets/0/Input/Fn::Join/1/11/Ref/WAFReputationListsSet2
aws-waf-security-automations-alb.template:914:7

W3005 Obsolete DependsOn on resource (LambdaWAFReputationListsParserFunction), dependency already enforced by a "Ref" at Resources/LambdaInvokePermissionReputationListsParser/Properties/FunctionName/Ref/LambdaWAFReputationListsParserFunction
aws-waf-security-automations-alb.template:954:7

W3005 Obsolete DependsOn on resource (LambdaWAFReputationListsParserEventsRule), dependency already enforced by a "Fn:GetAtt" at Resources/LambdaInvokePermissionReputationListsParser/Properties/SourceArn/Fn::GetAtt/['LambdaWAFReputationListsParserEventsRule', 'Arn']
aws-waf-security-automations-alb.template:954:7

W3005 Obsolete DependsOn on resource (LambdaRoleBadBot), dependency already enforced by a "Fn:GetAtt" at Resources/LambdaWAFBadBotParserFunction/Properties/Role/Fn::GetAtt/['LambdaRoleBadBot', 'Arn']
aws-waf-security-automations-alb.template:1075:7

E3012 Property Resources/LambdaWAFBadBotParserFunction/Properties/MemorySize should be of type Integer
aws-waf-security-automations-alb.template:1110:9

E3012 Property Resources/LambdaWAFBadBotParserFunction/Properties/Timeout should be of type Integer
aws-waf-security-automations-alb.template:1111:9

W3005 Obsolete DependsOn on resource (LambdaWAFBadBotParserFunction), dependency already enforced by a "Fn:GetAtt" at Resources/LambdaInvokePermissionBadBot/Properties/FunctionName/Fn::GetAtt/['LambdaWAFBadBotParserFunction', 'Arn']
aws-waf-security-automations-alb.template:1117:7

W3005 Obsolete DependsOn on resource (LambdaWAFBadBotParserFunction), dependency already enforced by a "Fn:GetAtt" at Resources/ApiGatewayBadBotMethodRoot/Properties/Integration/Uri/Fn::Join/1/3/Fn::GetAtt/['LambdaWAFBadBotParserFunction', 'Arn']
aws-waf-security-automations-alb.template:1150:7

W3005 Obsolete DependsOn on resource (ApiGatewayBadBot), dependency already enforced by a "Ref" at Resources/ApiGatewayBadBotMethodRoot/Properties/RestApiId/Ref/ApiGatewayBadBot
aws-waf-security-automations-alb.template:1150:7

W3005 Obsolete DependsOn on resource (ApiGatewayBadBot), dependency already enforced by a "Fn:GetAtt" at Resources/ApiGatewayBadBotMethodRoot/Properties/ResourceId/Fn::GetAtt/['ApiGatewayBadBot', 'RootResourceId']
aws-waf-security-automations-alb.template:1150:7

W3005 Obsolete DependsOn on resource (LambdaWAFBadBotParserFunction), dependency already enforced by a "Fn:GetAtt" at Resources/ApiGatewayBadBotMethod/Properties/Integration/Uri/Fn::Join/1/3/Fn::GetAtt/['LambdaWAFBadBotParserFunction', 'Arn']
aws-waf-security-automations-alb.template:1183:7

W3005 Obsolete DependsOn on resource (ApiGatewayBadBot), dependency already enforced by a "Ref" at Resources/ApiGatewayBadBotMethod/Properties/RestApiId/Ref/ApiGatewayBadBot
aws-waf-security-automations-alb.template:1183:7

W3005 Obsolete DependsOn on resource (ApiGatewayBadBotDeployment), dependency already enforced by a "Ref" at Resources/ApiGatewayBadBotStage/Properties/DeploymentId/Ref/ApiGatewayBadBotDeployment
aws-waf-security-automations-alb.template:1228:7

W3005 Obsolete DependsOn on resource (WAFWebACL), dependency already enforced by a "Ref" at Resources/LambdaRoleCustomResource/Properties/Policies/2/PolicyDocument/Statement/0/Resource/Fn::Join/1/5/Ref/WAFWebACL
aws-waf-security-automations-alb.template:1243:7

W3005 Obsolete DependsOn on resource (LambdaRoleCustomResource), dependency already enforced by a "Fn:GetAtt" at Resources/LambdaWAFCustomResourceFunction/Properties/Role/Fn::GetAtt/['LambdaRoleCustomResource', 'Arn']
aws-waf-security-automations-alb.template:1440:7

E3012 Property Resources/LambdaWAFCustomResourceFunction/Properties/MemorySize should be of type Integer
aws-waf-security-automations-alb.template:1458:9

E3012 Property Resources/LambdaWAFCustomResourceFunction/Properties/Timeout should be of type Integer
aws-waf-security-automations-alb.template:1459:9

W3005 Obsolete DependsOn on resource (LambdaWAFCustomResourceFunction), dependency already enforced by a "Fn:GetAtt" at Resources/WafWebAclRuleControler/Properties/ServiceToken/Fn::GetAtt/['LambdaWAFCustomResourceFunction', 'Arn']
aws-waf-security-automations-alb.template:1465:7

W3005 Obsolete DependsOn on resource (WAFWebACL), dependency already enforced by a "Ref" at Resources/WafWebAclRuleControler/Properties/WAFWebACL/Ref/WAFWebACL
aws-waf-security-automations-alb.template:1465:7

W3005 Obsolete DependsOn on resource (SolutionHelperRole), dependency already enforced by a "Fn:GetAtt" at Resources/SolutionHelper/Properties/Role/Fn::GetAtt/['SolutionHelperRole', 'Arn']
aws-waf-security-automations-alb.template:1665:7

E3012 Property Resources/SolutionHelper/Properties/Timeout should be of type Integer
aws-waf-security-automations-alb.template:1688:9

W3005 Obsolete DependsOn on resource (SolutionHelper), dependency already enforced by a "Fn:GetAtt" at Resources/CreateUniqueID/Properties/ServiceToken/Fn::GetAtt/['SolutionHelper', 'Arn']
aws-waf-security-automations-alb.template:1693:7

Hi @1davidmichael
Thanks for your feedback. We've just pushed a new version and cfn-lint was used to help clean-up those warnings you've mentioned.
Regards,

Awesome, thanks!

which dependency and which version solved this problem ?


Roll Packages from 551bde53f6ea to f330ca3c2fa3 (11 revisions)

https://github.com/flutter/packages/compare/551bde53f6ea...f330ca3c2fa3
2024-08-07<EMAIL_ADDRESS>Roll Flutter (stable) from b0850beeb25f to 80c2e84975bb (1397 revisions) (flutter/packages#7322)
2024-08-07<EMAIL_ADDRESS>Bump actions/upload-artifact from 4.3.5 to 4.3.6 (flutter/packages#7330)
2024-08-07<EMAIL_ADDRESS>[pigeon]: Bump io.mockk:mockk from 1.13.7 to 1.13.12 in /packages/pigeon/platform_tests/test_plugin/android (flutter/packages#7189)
2024-08-07<EMAIL_ADDRESS>[google_maps_flutter] Marker clustering support (flutter/packages#4319)
2024-08-07<EMAIL_ADDRESS>Bump github/codeql-action from 3.25.15 to 3.26.0 (flutter/packages#7329)
2024-08-07<EMAIL_ADDRESS>Manual roll Flutter from 1dd71413f4ad to 0a7f8af6d146 (23 revisions) (flutter/packages#7328)
2024-08-06<EMAIL_ADDRESS>[image_picker_ios] Update image picker UI test query for iOS 18 (flutter/packages#7325)
2024-08-06<EMAIL_ADDRESS>[google_maps_flutter] Add marker clustering support - iOS implementation (flutter/packages#6186)
2024-08-06<EMAIL_ADDRESS>[url_launcher] launchUrl always returns true for valid schemes on the web. (flutter/packages#7229)
2024-08-06<EMAIL_ADDRESS>[google_maps_flutter] Add heatmap support (flutter/packages#3257)
2024-08-06<EMAIL_ADDRESS>[local_auth] Endorse macOS (flutter/packages#7274)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


Add config option to control SSL validation

Currently newsbeuter performs no validation on SSL certificates. Until a better solution is implemented (per feed SSL control) a global setting is better than doing no validation at all.

Coverage increased (+0.005%) to 28.16% when pulling d3c3e9f3ea6c6ef545787751bd4dd67381b39b1d on tsipinakis:feature/ssl-verify into e6f8e752c660123d750263435d662699e011b84c on akrennmair:master.

I apologize for the delay.
JFTR: this PR makes SSL verification enabled by default, which is backwards incompatible. But I view this more like "setting things right" rather than "breaking what we already have", so I'll merge this as it is once that little nitpick I found gets resolved :)

Coverage increased (+0.005%) to 28.16% when pulling 52d86c5b49933f57a1783f653be353de9e7c051c on tsipinakis:feature/ssl-verify into dd29b1cdd83847231e12986501901b4f673c48f1 on akrennmair:master.

Merged. Thank you!


Some Image loading faild

@transitive-bullshit Having the same issue and I find out that it works well in Safari but failed in Chromium such as:

Chrome (99.0.4844.84)
Brave(1.36.122 Chromium: 99.0.4844.88)。

Redeploy or refresh the page、clear the cookies and cache of the browser still can fix the problem.

@chiperman what OS are you using? I'm having trouble reproducing the issue with the same version of chrome.

Take a screen recording, I found that all the IMG in my blog just can't show. When I fresh the page, it shows shortly and just disappears. Including the avatar in the Head and icon we add in the notion page
View this site.

I can get a log from the chrome console.
GET https://notion.chiperman.tk/_next/image?url=https%3A%2F%2Fwww.notion.so%2Fimage%2Fhttps%253A%252F%252Fghchart.rshah.org%252Fchiperman%3Ftable%3Dblock%26id%3D5355f4b9-c825-4eb9-8c94-767b0f5fbd84%26cache%3Dv2&w=1920&q=75 400

@chiperman the images that aren't loading for you are svgs.
This is a next.js setting that disables next/image working with svgs by default. To fix it, merge the latest into your code, specifically a9f4bb3

@allinu I'm pretty sure the issues @chiperman is talking about are separate from what you are seeing.
When you get a chance, can you let me know if you're still seeing the image issues on https://transitivebullsh.it, and if so more info about the browser / OS so I can try to reproduce the issue?

@transitive-bullshit still can't see your avatar and little icon on the header which is the same problem I have.

@transitive-bullshit
OS: Mac OS M1 Monterey 12.3.1 (21E258)
Browser: Chrome 版本 99.0.4844.84（正式版本） (arm64)
Safari display okay 😊 but chrome is not

Hmmmm, maybe I'm having a hard time understanding or reproducing this issue.
Would one of you guys mind taking a screenshot of the devtools network tab after a refresh (with caching disabled)? Like this one:

Also, are there any errors printed to the console?
I want to get more of an understanding of whether it's a format issue, a network issue, or a rendering issue.
Thanks!

@allinu Do you have a chrome-extension named: SimpleRead, I think this extension cause this problem. Can you try to disabled it and refresh the website to see everthing is fine?

@chiperman YES!!! You are right!!! But I don't know why, hhha. Thank You

Okay, if SimpleRead's problem, I think find the way to solve it. Thanks @chiperman!!
I will close this issue.
Thanks everyone. ❤


Add support for functions that change column data types

Thanks @endink!
Resolves #197

Coverage remained the same at 100.0% when pulling 4e25f1462949c6685ab20463072a371275ae65b9 on jeffgbutler:gh_197 into ba7dc5d4933bcf530dbafdc4e3f020c5b659859a on mybatis:master.


Rails 3.2.rc1: Deprecation warnings related to ActiveSupport::Concern

Every now and then I get the following deprecation warning when running my (controller) specs:
WARNING: The InstanceMethods module inside ActiveSupport::Concern will be no longer included
automatically. Please define instance methods directly in #<Class:0x9e8ef78> instead. (called from
<top (required)> at /home/gmile/experiments/project/spec/controllers/events_controller_spec.rb:3)

It seems that something like this should be applied to rspec-rails, which affects pretty much files inside the gem.
P.S. using 2.7.0 version of the gem

Thanks for reporting this, but it's actually already been fixed.  The next release will include this fix.


chore: consolidate isort configuration

While setting up my editor to better integrating the linter environment, me and my co-workers noticed that the linter settings for isort was not applied consistently. This PR attempts to fix it.
Description
isort makes a point about not merging configs which seems to happen in Saleor
due to having configuration in .isort.cfg, setup.cfg and finally through pre-commit configuration.
Solve this by moving all configs into the first existing config file.
Also, as part of the 5.x upgrade guide:

remove a deprecated setting for not skipping __init__.py which is now scanned by default
update the pre-commit step to remove seed-isort-config and use the newer version for pre-commit

Impact

[ ] New migrations
[ ] New/Updated API fields or mutations
[ ] Deprecated API fields or mutations
[ ] Removed API types, fields, or mutations
[ ] Documentation needs to be updated

Pull Request Checklist

[ ] Privileged queries and mutations are guarded by proper permission checks
[ ] Database queries are optimized and the number of queries is constant
[ ] Database migration files are up to date
[ ] The changes are tested
[ ] GraphQL schema and type definitions are up to date
[ ] Changes are mentioned in the changelog

Cool, thanks for opening a PR @jbergstroem !


Migrate to CSS --theme variables

See: https://github.com/microsoft/vscode/issues/107985. The --vscode-prefixed CSS variables will be removed in the next insiders

Thanks @connor4312! Completed in a release a day or 2 ago


IP Ranges

[Working with a customer today, they commented that they would like the fact that ranges need to be entered in CIDR format called out more.]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a994dabc-b468-b3b3-91a4-c9db4af026bc
Version Independent ID: e2f04ce5-20c4-d9f8-aaed-fce4f356dbd0
Content: Configure IP restriction WAF rule for Azure Front Door
Content Source: articles/web-application-firewall/afds/waf-front-door-configure-ip-restriction.md
Service: web-application-firewall
GitHub Login: @vhorne
Microsoft Alias: victorh

Thank you for your feedback! We will review and update as appropriate.

Hello @F1AMG,
The documentation already consists of the statement below.

It does this by specifying a list of IP addresses or IP address ranges in Classless Inter-Domain Routing (CIDR) format

Is there any other way you have in mind which will be better to call this out?

Hello @F1AMG, since we have not heard back from you. We will now proceed to close this issue out. Please tag me in your response if you have any additional questions. Thank you!


[CARBONDATA-3855]support carbon SDK to load data from different files

Why is this PR needed?
TO support carbon SDK to load data from different files.
What changes were proposed in this PR?
Now user can load a single file or all files under a given directory or selected files under given directory.
Please go through the design document for better understanding-
https://issues.apache.org/jira/browse/CARBONDATA-3855
Does this PR introduce any user interface change?

No

Is any new test case added?

Yes

Build Failed  with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.5/1519/

Build Failed  with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/3249/

Build Failed  with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/3254/

Build Failed  with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/3259/

Build Failed  with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.5/1523/

@nihal0107 please elobrate the PR description as it a requirement, check some old requirement PR such as 3478

Build Failed  with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.5/1542/

Build Failed  with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/3279/


Redis only - scan and map records based on a max num

This is iffy, not sure if it's a good idea to support and if it is, should it be done as a map for table vs columns?

Sample PR code
The code for this is ready here, but will not merge until we can find a better UX.
https://github.com/synle/sqlui-native/pull/331/files
Sample code used to scan the iterator
for await (const key of client.scanIterator(iteratorParams)) {
        res.push({
          name: key,
          columns: [],
        })

        if(res.length === 15){
          // top it off at max records
          break;
        }
      }

There can be many records inside of Redis. So it's not a good idea to scan it all just to infer the schema.


Update aggregate

https://docs.mongodb.org/manual/reference/command/aggregate/

bypassDocumentValidation:
readConcern

Any target release date for 0.12.0?

I hope this to be included in the next minor release or snapshot, before 0.12.0.


allow creating onchain privacy groups during test setup

Signed-off-by: Taccat Isid<EMAIL_ADDRESS>
Checklist

A link to the issue/user story that the pull request relates to
[x]  How to recreate the problem without the fix
[x]  Design of the fix
[x]  How to prove that the fix works
[x]  Automated tests that prove the fix keeps on working
[ ]  Documentation - any JSDoc, website, or Stackoverflow answers?

Issue/User story

When using caliper with onchain privacy the user currently has to create privacy groups outside of caliper and then record the privacyGroupId in the caliper network config. The id itself is created randomly. Having a fixed value in the caliper network config would require to also have a lot of ossified smart contract state the besu genesis file.
Existing issues

[x] Stack Overflow issues
[x] GitHub Issues
[x] Rocket Chat history

Design of the fix
The setup phase of the ethereum connector was extended to allow creation of privacy groups. The generated group ids are injected into the configuration and passed to individual workers via prepareWorkerArguments and getContext.

Validation of the fix

The PR has been tested by using both the existing and the extended (see below) integration tests.
Automated Tests

The existing privacy integration tests have been modified to use onchain privacy with dynamically generated groups. It would be preferable to test onchain and legacy privacy groups at the same time. But a single besu instance only supports one or the other and using onchain allows for far more coverage.
What documentation has been provided for this pull request

None so far.

@taccatisid Could you please rebase your PR to resolve the current conflict?


Running the model

Hi, thanks you for sharing your work. I tried to run. But facing error described below:
OSError: qihoo360/iaa-14-hf is not a local folder and is not a valid model identifier listed on 'https://huggingface.co/models'
I downloaded locally from github following the install steps. Could you please share the checkpoint?
Thank you.

We have updated the name of the model in the readme to qihoo360/Inner-Adaptor-Architecture, the model has been uploaded to the huggingface community, you can download it to use locally or pull it automatically.

Thank you!


Two problems about paper

In the paper, Figure 6,  the only difference between (c) and (d) is that (d) is much more flat than (c), and the test error of (d) is smaller than (c),
so if a loss surface, which we use Filter-Wise Normalization to get,  is flatter, it will have a better Generalization?  is there any explanation or math proof?
In final part of section6, paper use (min eigenvalues of  the Hessian / max eigenvalues of  the Hessian) to represent convex, larger value indicate a more non-convex region,  smaller value indicate a more convex region, why?
Thank you for sharing results of your work.
This is a really impressive paper and your response is appreciated.

I have the same query after reading the paper.
Can the authors please comment?

I also don't understand the first question. : (
For the second one, I think the key is to prove that convex-looking regions in projected surface is relatively convex in original surface. A small absolute ratio means that the max eigenvalue is big enough compared to min eigenvalue which may be a negative value, that is the postive eigenvalue is dominant, so a convex-looking region in projected surface which has a small absolute ratio is a relatively convex region in original surface.

Not affiliated with the paper, but in non-convex optimization it is generally believed that wider minima should generalize better than sharp minima. This clip from Leo Dirac (start at 16:30) conveys the intuition here. The paper result capture it empirically.


Fastify example with SSE

Is your feature request related to a problem? Please describe.
Hi there - I'm looking to use SSE along with Fastify which appears to not work out of the box with the basic Fastify example that's already provided.
Describe the solution you'd like
I'd like to see a Fastify example utilizing SSE.
Describe alternatives you've considered
I've considered using other graphql server libraries like graphql-helix.
Additional context
Thanks!

Our fastify example has subscriptions so it uses SSE;
https://github.com/dotansimha/graphql-yoga/blob/master/examples/fastify/src/app.ts#L21
And here is the test;
https://github.com/dotansimha/graphql-yoga/blob/master/examples/fastify/__tests__/fastify.spec.ts#L130

Thanks! When running the example code with Fastify 4.0.1, got "stream closed prematurely". (In v3 everything great!).

Which can be fixed by just adding a "return reply" in the handler. This is new in v4.

@mebrein Thanks for the tip!
I updated the version of Fastify to v4 and the docs by adding return reply in this PR

You're welcome. I just noticed a problem, when I refresh the subscription query while the counter is still running. De fastify server halts with this message:  Error [ERR_HTTP_HEADERS_SENT]: Cannot set headers after they are sent to the client. Still investigating. Need to do more testing but not sure if this is v3 or v4 related.

I just tested with fastify 3.2.9, there this behavior does not occur. When I do a full refresh when running in the GraphiQL client, at the server side I get a 200  "request completed" and a 200 "stream closed prematurely". And when I subscribe again, the counter restarts. The server doesn't halt, which happens with fastify 4.

@ardatan You got it! https://github.com/dotansimha/graphql-yoga/issues/1288#issue-1269838663


Fix add translation form, as AddPageForm expects cms_page parameter

Summary
Fixes #
Links to related discussion
Proposed changes in this pull request
Documentation checklist

[ ] I have updated CHANGELOG.txt if appropriate
[ ] I have updated the release notes document if appropriate, with:

[ ] general notes
[ ] bug-fixes
[ ] improvements/new features
[ ] backwards-incompatible changes
[ ] required upgrade steps
[ ] names of contributors

[ ] I have updated other documentation
[ ] I have added my name to the AUTHORS file
[ ] This PR's documentation has been approved by Daniele Procida

Coverage remained the same at 77.665% when pulling f1b1d04d311f130319e73502081dc5a4c14d0023 on chaosk:bugfix/page-translation-creation into 4307e1b8c2e2d0459868133aaa5bdc4d59d7ca81 on divio:release/4.0.x.


Problem with installation

Hello. I can't install a version higher tha 1.2.0. Wih pip I got the error it can't build wheels.
There is also a problem to install from github link:

You need not to build on windows, install prebuilt binaries from PYPI.

I wrote I can't install with pip. I got the error. And I don't know why it shows that there is no pybind11 when it is installed. What a version of python is required?

@Allamaris0
What is the python version you are using?
What version of windows you are using?

Windows 10, Python 3.8. You wrote somewhere that is required Python 3.9


Callaghan parkrun's Cancellation Note

I have temporarily removed the cancellation note for Callaghan parkrun following a discussion with the Event Director. I will add it back once the English events have restarted.

Moved to https://github.com/josh-justjosh/parkrun-Cancellations/issues/2


Send headers with context menu download

When right-clicking a link and selecting "Download with Aria2", it should launch the download with the same HTTP headers as the session the context menu is activated from.
This is needed to support downloads utilising HTTP authorisation fields.

This Add-on interrupts and records the request that Firefox sends, so it cannot get the headers from context menu.
But if I have time, I will use another way to implement this.

Hi Ross,
Thanks for your latest commit!
However, it doesn't handle the Authorization header.
Cheers.

I am sorry for that. I guessed you were talking about the "cookie" field, but it was not.
In the latest  commit, I added the 'Authorization' header support for the auto observer, but it cannot handle the 'Authorization' header for the download request from the context menu because of the reason I talk before.
I have not figured out the good method to handle the 'Authorization' header for the download request from the context menu. If you have any good idea, please tell me.


[Bug] Re-creating opened account causes file deletion

Open any account file
Don't close it, open account menu, start new account creation
Select the file of opened account, agree for it to be overwritten

Result: the account is still opened in the app window and not cleared. The file is deleted and not re-created. If you try to modify a transaction or a group, the app will crash.

Should be fixed in https://github.com/nlogozzo/NickvisionMoney/commit/1338b4ba8719d15b6dc48d4b94abc21702e8ac15

@fsobolev Can you confirm that this was fixed?

I confirm, it's fixed.


Add zs2.sanok.pl

@alwojcicka First stage of verification passed, official domain for Zespół Szkół nr 2 im. Grzegorza z Sanoka w Sanoku is zs2.sanok.pl as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.

@alwojcicka Thank you for your patience while waiting for a review and processing your request. Pull request merged.
Please start requesting the licenses in about an hour, to let the changes to propagate through our system.


@IdClass support

Provide support for user defined ID classes to capture composite keys as an annotation on top of the actual fields in the POJO.
This would be supported beyond the existing @PrimaryKey annotation as an alternative way to map composite keys. Similar to @IdClass  annotation in JPA.

I tried to implement this today and ran into an issue with the PartTree queries. However, all of our other unit and integration tests worked fine.
The reason is that the PartTree query is built from the the TypeInformation of the domain type, and NOT the PersistentEntity of the domain type.
For example, if we have domain type Parent with an embedded object of type Child and Child has a field called idvalue, if we define the parttree method named countByIdvalue, then PartTree gets a TypeInformation based on Parent.class, and then crashes because Parent doesn't have a property named idvalue. I don't think we can alter that behavior.
Fortunately all of our code otherwise depends on SpannerPersistentEntity so I can route access to idvalue through to the embedded object. We could support embedded objects but just tell people it will not work with Parttree? @balopat

I think you started implementing the @EmbeddedId - not the @IdClass support...
I'd think the query method would be countByChild (assuming the field's name is child) and you'd pass in a Child object as an argument for filtering - not referring directly to the underlying column...

eeek then we had different things in mind I'm afraid. I'll release this back to the backburner

I read that link and it looks like this is just a check that another class given in the @IdClass annotation contains exactly the ID columns of the annotated class...
Unless there are some good examples of how this could be really useful I think we should wait until people ask for this.


reverse proxy to get https instead of http in manifest

https://cantaloupe-project.github.io/manual/3.4/deployment.html#Reverse-Proxying
e.g. https://specialcollections.du.edu/iiif/72b8963c-8a3b-4483-9eb2-ad45878fcd3c/manifest remove all http links replace with https

can be closed, links to https now and the http resolves to https


deployed site missing docsy theme elements

The deployed site is missing theme elements, possibly CSS/JS files aren't correctly bundled for deployment. Investigate and correct repository content and/or github action deployment.

5 different CSS/JS resources are not found.


Add OPAM control files for easier installation

Especially when edn will hit OPAM, this will reduce from two commands to just one command, no cloning required, just works.

Pushed a fixed commit.

Thanks! I'm learning a lot from these PRs. Much appreciated!


Deploy fails with multiplexing enabled

Deployer version: 6.8.0
Deployment OS: Debian 9.13

export APP_ENV='stage' APP_DEBUG='0'; if [ -f /var/www/*************/.dep/deploy.lock ]; then echo 'true'; fi
< ssh multiplexing initialization
< Warning: Permanently added '**************,***.***.***.**' (ECDSA) to the list of known hosts.
< unix_listener: cannot bind to path<EMAIL_ADDRESS>No such file or directory

deploy example:
host('**************')
    ->stage('stage')
    ->set('deploy_path', '/var/www/stage-{{application}}')
    ->multiplexing(true)
    ->addSshOption('UserKnownHostsFile', '/dev/null')
    ->addSshOption('StrictHostKeyChecking', 'no')
    ->user('deployer');

when i disable multiplexing it works again

unix_listener: cannot bind to path<EMAIL_ADDRESS>No such file or directory

Looks like a problem on your side.

Isn't it a socket that deployer is creating?
It worked before like a charm, and only recently for some reason stopped, not sure maybe some OS update broke it

Try to run with dep -vvv, there will be ssh commands. Get failing one and try to debug it. Also with -v.

that's all ssh commands i already posted it fails on initial connection, there are no more command and it's already run with -vvv
it probably fails on ssh multiplexing initialization it's not visible what it tries to do there
APP_VERSION=$CI_COMMIT_SHORT_SHA php dep.phar deploy -vvv stage
➤ Executing task deploy:lock
[*******] > export APP_ENV='stage' APP_DEBUG='0'; if [ -f /var/www/stage-*******/.dep/deploy.lock ]; then echo 'true'; fi
[*******] < ssh multiplexing initialization
[*******] < Warning: Permanently added '*******,<IP_ADDRESS>' (ECDSA) to the list of known hosts.
[*******] < unix_listener: cannot bind to path<EMAIL_ADDRESS>No such file or directory
➤ Executing task deploy:failed
• done on [*******]
✔ Ok [0ms]

I see. Try to use v7 beta, it has much more debug output for -vvv.

it's not compatible with v6.8 config, for example:
Call to undefined method Deployer\Host\Host::stage()
it seems stage method got renamed or removed, not sure. so can't run it without an upgrade guide to update my deploy.php file

It is here: https://github.com/deployphp/deployer/blob/master/docs/UPGRADE.md

It is here: https://github.com/deployphp/deployer/blob/master/docs/UPGRADE.md

oh, was looking for it in the tagged revision of v7. Will give it another shot, thanks

so i see:
[********] ssh -O check '-o' 'StrictHostKeyChecking=no' '-A' '-o' 'ControlMaster=auto' '-o' 'ControlPersist=60' '-o' 'ControlPath=/dev/shm/%C' echo 2>&1
[********] Control socket connect(/dev/shm/c23391cf8ed674d30387b9b151b3b49b1fd01b37): No such file or directory
[********] ssh multiplexing initialization
[********] ssh -N '-o' 'StrictHostKeyChecking=no' '-A' '-o' 'ControlMaster=auto' '-o' 'ControlPersist=60' '-o' 'ControlPath=/dev/shm/%C' deployer@********
[********] Control socket connect(/dev/shm/c23391cf8ed674d30387b9b151b3b49b1fd01b37): No such file or directory

dir for the socket seems to have changed, but no idea why it doesn't work

Try to tun it
ssh -N '-o' 'StrictHostKeyChecking=no' '-A' '-o' 'ControlMaster=auto' '-o' 'ControlPersist=60' '-o' 'ControlPath=/dev/shm/%C' deployer@********
[

Authenticated to ****************** ([****************]:22).
debug1: setting up multiplex master socket
debug3: muxserver_listen: temporary control path /dev/shm/c3af3e3b12dac4cae54c9f980f01b8eddd1f5ae8.DuxhauuFGI7k1sjq
unix_listener: cannot bind to path /dev/shm/c3af3e3b12dac4cae54c9f980f01b8eddd1f5ae8.DuxhauuFGI7k1sjq: No such file or directory

does not seem to show anything useful, will try restarting server tonight

I think problem with a path for socket  /dev/shm/
Try changing it. Don’t remember if it possible.

yes if i change the path to /tmp it works without issues
debug1: setting up multiplex master socket
debug3: muxserver_listen: temporary control path /tmp/c3af3e3b12dac4cae54c9f980f01b8eddd1f5ae8.x6yIunMRwJs0XfSQ

so i guess one can't just create a socket anywhere he pleases

-o ControlPath=~/.ssh/control-%h-%p-%r also works fine, maybe the filename it creates with %C is too long, read about it somewhere

ControlPath
Specify the path to the control socket used for connection sharing as described in the ControlMaster section above or the string none to disable connection
sharing.  Arguments to ControlPath may use the tilde syntax to refer to a user's home directory or the tokens described in the TOKENS section.  It is recom-
mended that any ControlPath used for opportunistic connection sharing include at least %h, %p, and %r (or alternatively %C) and be placed in a directory that
is not writable by other users.  This ensures that shared connections are uniquely identified.

it's written in the manual that socket should be placed in the directory not writable by other users, so is it a good idea to use /dev/shm by default?
and in v6 it tried to place it in a path /root/.ssh/ but deployer is not root, so it can't , why would it even attempt to use root

If I remember correctly, /dev/shm used as fallback for CI systems.

not sure what do you mean, socket is created on the server we're deploying to, not on CI we're deploying from. Why should it be /dev/shm when deploying from CI
found this
* Return SSH multiplexing control path
     *
     * When ControlPath is longer than 104 chars we can get:
     *
     *     SSH Error: unix_listener: too long for Unix domain socket
     *
     * So try to get as descriptive path as possible.
     * %C is for creating hash out of connection attributes.
     */
    private static function generateControlPath(Host $host): string
    {
        // In case of CI environment, lets use shared memory.
        if (getenv('CI') && is_writable('/dev/shm')) {
            return '/dev/shm/%C';
        }

so it doesn't look like a length issue:
/dev/shm/c3af3e3b12dac4cae54c9f980f01b8eddd1f5ae8.DuxhauuFGI7k1sjq is 66 chars long, but somehow it passes is_writable check but fails in the end

hey there, is there any fix for this? i update my deployer to the latest beta, and error below is showed

Authenticated to ****************** ([****************]:22).
debug1: setting up multiplex master socket
debug3: muxserver_listen: temporary control path /dev/shm/c3af3e3b12dac4cae54c9f980f01b8eddd1f5ae8.DuxhauuFGI7k1sjq
unix_listener: cannot bind to path /dev/shm/c3af3e3b12dac4cae54c9f980f01b8eddd1f5ae8.DuxhauuFGI7k1sjq: No such file or directory

does not seem to show anything useful, will try restarting server tonight

Let's keep track in #2680

Hi there IMO this can be assimilated to a bug? As the deployer in v6 is trying to use /root/.ssh for no apparent reason? As mentioned by @Gamesh. Also he proposed a PR @antonmedv why not simply accept the free help? As nothing seems to be going on in #2680 ...
Regards

Yes, we can try to fix the issue. As this issue not wide spread it’s difficult propose a fix.
Let’s create a pr with a fix?

Thanks for the speedy response.
I just found out why the deployer is try the /root/.ssh.
The deployer already does try to get the current remote user see here.
But, unfortunately, if RemoteUser is not set in the ~/.ssh/config file or if the remote_user is not in the config of the deployer, the code replaces it with the current os username (i.e the host running the deployer). In our case because we run the deployer from github-actions the root user gets picked up instead of the ssh actual remote user. So a workaround would be to fill one of the config files.

@antonmedv i've just migrated from v6 to v7. This issue is fixed in that version. So i think  #2680 is no longer relevant.
Thanks for this project and even the others 🙏

Awesome!


fix fix the be coredump caused by type conversion

Proposed changes

1、problem
fix the be coredump caused by type conversion
2、be stack
0# doris::signal::(anonymous namespace)::FailureSignalHandler(int, siginfo_t*, void*) in /usr/local/service/doris/lib/be/doris_be
 1# 0x00007EFFC433C400 in /lib64/libc.so.6
 2# __GI_raise in /lib64/libc.so.6
 3# abort in /lib64/libc.so.6
 4# __gnu_cxx::__verbose_terminate_handler() [clone .cold] in /usr/local/service/doris/lib/be/doris_be
 5# __cxxabiv1::__terminate(void (*)()) in /usr/local/service/doris/lib/be/doris_be
 6# 0x000055F054E53B61 in /usr/local/service/doris/lib/be/doris_be
 7# 0x000055F054E53CB4 in /usr/local/service/doris/lib/be/doris_be
 8# __cxa_bad_typeid in /usr/local/service/doris/lib/be/doris_be
 9# doris::vectorized::ColumnVector<int>::insert_range_from(doris::vectorized::IColumn const&, unsigned long, unsigned long) in /usr/local/service/doris/lib/be/doris_be
10# doris::vectorized::ColumnNullable::insert_range_from(doris::vectorized::IColumn const&, unsigned long, unsigned long) in /usr/local/service/doris/lib/be/doris_be
11# doris::ExecNode::do_projections(doris::vectorized::Block*, doris::vectorized::Block*) in /usr/local/service/doris/lib/be/doris_be
12# doris::ExecNode::get_next_after_projects(doris::RuntimeState*, doris::vectorized::Block*, bool*) in /usr/local/service/doris/lib/be/doris_be
13# doris::vectorized::AggregationNode::get_next(doris::RuntimeState*, doris::vectorized::Block*, bool*) in /usr/local/service/doris/lib/be/doris_be
14# doris::ExecNode::get_next_after_projects(doris::RuntimeState*, doris::vectorized::Block*, bool*) in /usr/local/service/doris/lib/be/doris_be
15# doris::PlanFragmentExecutor::get_vectorized_internal(doris::vectorized::Block**) in /usr/local/service/doris/lib/be/doris_be
16# doris::PlanFragmentExecutor::open_vectorized_internal() in /usr/local/service/doris/lib/be/doris_be
17# doris::PlanFragmentExecutor::open() in /usr/local/service/doris/lib/be/doris_be
18# doris::FragmentExecState::execute() in /usr/local/service/doris/lib/be/doris_be
19# doris::FragmentMgr::_exec_actual(std::shared_ptr<doris::FragmentExecState>, std::function<void (doris::PlanFragmentExecutor*)>) in /usr/local/service/doris/lib/be/doris_be
20# std::_Function_handler<void (), doris::FragmentMgr::exec_plan_fragment(doris::TExecPlanFragmentParams const&, std::function<void (doris::PlanFragmentExecutor*)>)::{lambda()#1}>::_M_invoke(std::_Any_data const&) in /usr/local/service/doris/lib/be/doris_be
21# doris::ThreadPool::dispatch_thread() in /usr/local/service/doris/lib/be/doris_be
22# doris::Thread::supervise_thread(void*) in /usr/local/service/doris/lib/be/doris_be
23# start_thread in /lib64/libpthread.so.0
24# __clone in /lib64/libc.so.6

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

same as pr: https://github.com/apache/doris/pull/15326 on branch-2.0


fix(trinket): Style "beta" text

🔧 What does this fix? 🔧
this

🗒 Checklist 🗒

[X] I have read and followed Catppuccin's contributing guidelines.
[X] I have updated the version appropriately in the ==UserStyle== header of the catppuccin.user.css file.

well (from experience) the only person who semi-actively maintains it is the founder so it makes sense


karma-browserify coverage reports contain file include paths instead of source code

Using karma-browserify to do unit tests with Jasmine. The tests correctly run but the coverage reports show file include paths instead of source code. You can reproduce this by installing the following project and run 'gulp unit':
https://github.com/bshack/shackstack
Here is an example of the coverage report contents:
typeof require === "function" && require("/xxx/xxx/xxx/shackstack/app/media/script/service/utilities.js");

Here is my karma.config:
module.exports = function(karma) {
    'use strict';
    karma.set({
        basePath: '',
        frameworks: [
            'jasmine',
            'browserify'
        ],
        files: [{
            pattern: 'app/media/script/service/*.js',
            included: true
        },
        {
            pattern: 'app/media/test/spec/*Spec.js',
            included: true

        }],
        reporters: [
            'progress',
            'coverage'
        ],
        preprocessors: {
            'app/media/script/service/*.js': [
                'browserify',
                'coverage'
            ],
            'app/media/test/spec/*Spec.js': [
                'browserify'
            ]
        },
        browsers: [
            //'Chrome',
            //'Firefox',
            //'Safari',
            'PhantomJS'
        ],
        singleRun: false,
        autoWatch: false,
        // browserify configuration
        browserify: {
            debug: true,
            transform: [
                'brfs',
                'browserify-shim'
            ]
        },
        coverageReporter: {
            type: 'html',
            dir: 'app/report/istanbul/',
            subdir: '.'
        },
        // If browser does not capture in given timeout [ms], kill it
        captureTimeout: 60000
    });
};

any thoughts?
Asked this on stackoverflow too:
http://stackoverflow.com/questions/35122592/karma-browserify-coverage-reports-contain-file-include-paths-instead-of-source-c

Do not include your app files, include only your test files instead.
Use a browserify transform for coverage instrumentation (i.e. browserify-istanbul) and not a Karma plug-in.

@nikku FYI I could not get it working by only including test files.
This blog suggests doing the opposite, and its made my Karma output valid coverage. In it @tongrhj includes test- and src-files separately, and transforms browserify via the browserify-istanbul library you also linked.


server/shadow: Completely decouple subsystem implementations and shad…

…ow framework internal details.
It will be completely possible to implement subsystem with only include/freerdp/server/shadow.h and libfreerdp-shadow.
Details as following:

Exported surface structure as subsystem implementations deeply depend on it to send image update
Export capture APIs. They are actually indepent APIs to help compare and calculate image difference.
Introduce API to trigger client frame update. Conceal details in subsystem->updateEvent
Pass client to client callbacks. Subsystem implementation may need to know 'which client' send the interaction event as well as the authentication request.
Add this support in callback definition before anyone really use shadow framework APIs to implement a custom subsystem.
Also added callback for client capability exchange
Remove X11_ShadowSubsystem Mac_ShadowSubsystem Win_ShadowSubsystem from libfreerdp-shadow.
Discard FREERDP_API mark on ShadowSubsystemEntry functions and make them be compiled together with shadow.c in CMakeLists.txt.
This is required from PR #2751.
Now subsystem implementations and shadow.c could be regarded as an example for shadow framework.

+1
@realjiangms sorry for the long delay. Your changes look good to me could you rebase them on the current master?

It LGTM too, anyway as @bmiklautz said it needs rebasing.

Sorry for late. I didn't have chance to check my github account these days. I would rebase all the pending PR soon

@realjiangms thanks


Models

updated models.py

@roychowd @sandysaji The backend app wasn't installed - I pushed a change that installs it. Try running python manage.py makemigrations to run it again. There seem to be some errors in code.


Incorrect Zodiac Dates

Description
The stored start/end dates of zodiac signs are mostly incorrect, resulting in dates given on the .zodiac command being incorrect, as well as the wrong zodiac sign being given in certain scenarios for the .zodiac date command.
Steps to Reproduce
Perform the .zodiac command (e.g. .zodiac scorpio / .zodiac date 22 november)
Expected Behaviour
The correct dates / zodiac sign should be shown
Actual Behaviour
Incorrect date / sign are shown:

Should have end date as november 22:

Should show Scorpio:

Known Impacted Platforms

[x] Web
[x] Desktop
[x] Android App
[x] iOS App

Possible Solutions
Correct the dates in the JSON file storing information on the different zodiac signs.
Would you like to implement a fix?
Note: For high-priority or critical bugs, fixes may be implemented by staff.

[x] I'd like to implement the bug fix
[ ] Anyone can implement the bug fix

Greetings @TrizzySaurus, I have checked out a couple websites (attaching link for the same) and according to them, the date entered here are correct.
https://www.britannica.com/topic/zodiac
https://www.cosmopolitan.com/uk/entertainment/horoscopes-monthly/a29383721/star-sign-dates/

I have checked more websites, and the dates do indeed seem correct.


Consider OG title and OG description changes

Is there situation where
Title / OG Title and Description / OG Description
are different? Or are there different character limits?
Maybe they should be merged so editors don't have to fill everything twice.

Good point! When we first started developing the plugin we had one description and one title field that would automatically be used for OG Title and OG description.
Then two of our clients requested more flexibility when sharing content on Facebook but not at the expense of altered page titles and descriptions that would show up in their search listings. That's when I decided to add the dedicated OG Title and OG description fields in the blueprint.
I agree that it creates a lot of redundant work for editors on sites that don't require this flexibility. I'll note it as a feature request for version 1.1. Maybe we can create a "full-auto" version of the blueprint + snippets that keep duplicate fields to a minimum and a "full-flexibility" version that continues to allow for manual entry of values into each field.

I've just release version 1.1 which solves this issue by using page title and description as automatic fallbacks for Twitter and Open Graph fields.


Pls Help Bro!

Bro I am Not A Programmer Can You Pls Atleast Tell Me The Steps To How Install And Make It work on Replit Pls Its A Humble Request😓
Pls Respond As Fast as Possible
Respectfully Abel

You can find the installation/usage instructions in the README.md file.


Highchart6 issue28

Coverage remained the same at 65.191% when pulling f473acb22bf0723409b8021e615a79e8a988fcca on highchart6-import-issue28 into c9b4696ffb59e060cbeedcc7e275e4118abc276b on highchart6-import.

Coverage decreased (-4.5%) to 60.647% when pulling be537ba7aff06ba0500f850147ce9837de903c48 on highchart6-import-issue28 into c9b4696ffb59e060cbeedcc7e275e4118abc276b on highchart6-import.

Coverage decreased (-4.5%) to 60.647% when pulling be537ba7aff06ba0500f850147ce9837de903c48 on highchart6-import-issue28 into c9b4696ffb59e060cbeedcc7e275e4118abc276b on highchart6-import.


WIP: converts to armeria server

This is mostly a shotgun attempt. The integration tests are likely
failing as the spring boot runner likely wants to open a tomcat port
which armeria would conflict with. Not sure about it actually. Anyway,
this is a rough start.
cc @trustin @anuraaga @huydx

yeah this is for the zipkin http collector endpoints POST /api/v2/spans for
example
On Sun, Feb 10, 2019, 6:23 PM Anuraag Agrawal<EMAIL_ADDRESS>wrote:

@anuraaga commented on this pull request.
In
zipkin-server/src/main/java/zipkin2/server/internal/actuate/TolerantPathMapping.java
https://github.com/openzipkin/zipkin/pull/2348#discussion_r255331516:

the License.

*/
+package zipkin2.server.internal.actuate;

+import com.linecorp.armeria.common.HttpMethod;
+import com.linecorp.armeria.common.MediaType;
+import com.linecorp.armeria.server.PathMapping;
+import com.linecorp.armeria.server.PathMappingContext;
+import com.linecorp.armeria.server.PathMappingResult;
+import com.linecorp.armeria.server.VirtualHost;
+import java.util.List;
+import java.util.Optional;
+import java.util.Set;
+import javax.annotation.Nullable;
+
+final class TolerantPathMapping implements PathMapping {
Thanks, will check it. Wouldn't have figured that out since from what I
can tell, /loggers is the only default endpoint that sets consumes!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/openzipkin/zipkin/pull/2348#discussion_r255331516,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAD611e36mPSDys7XmjJs7AF-zSJwUOMks5vL_MLgaJpZM4Z8be3
.

Ah - in that case I suspect it's not needed. That API is using annotated service, not actuator. From what I can tell from these docs, actuator requires content type header so the default path mapping probably works
https://docs.spring.io/spring-boot/docs/current/actuator-api/html/#loggers-single

dunno probably something must have failed else I wouldnt have written this.
the version of me that knew was force pushed
On Sun, Feb 10, 2019, 6:35 PM Anuraag Agrawal<EMAIL_ADDRESS>wrote:

Ah - in that case I suspect it's not needed. That API is using annotated
service, not actuator. From what I can tell from these docs, actuator
requires content type header so the default path mapping probably works
https://docs.spring.io/spring-boot/docs/current/actuator-api/html/#loggers-single
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/openzipkin/zipkin/pull/2348#issuecomment-462121112,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAD613sEt_RNRBpPwEEXqH9em9goOOpJks5vL_XpgaJpZM4Z8be3
.

@anuraaga I played with building from your branch of armeria, but I get a mysterious NPE in the exploratory commit
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-invoker-plugin:3.2.0:install (integration-test) on project zipkin-server: Failed to install project dependencies: MavenProject: io.zipkin.java:zipkin-server:2.12.2-SNAPSHOT @ /Users/acole/oss/zipkin/zipkin-server/pom.xml: Failed to install project artifacts: null: Failed to install POM: null: NullPointerException -> [Help 1]

Updated this branch and CircleCI passes now. I made one behavior change in that when collector is disabled, it returns 404 instead of 405 - the latter seemed complicated and also surprised me, if the API isn't on shouldn't it be 404? Anyways, hopefully it's a small enough change.
I think there are some more code cleanups possible but at least things are merged and probably working - Travis seems to get stuck on not being able to connect to Cassandra but I'm hoping that's not related to armeria.

will take a look. thanks!
On Sun, Mar 3, 2019 at 5:43 PM Anuraag Agrawal<EMAIL_ADDRESS>wrote:

Updated this branch and CircleCI passes now. I made one behavior change in
that when collector is disabled, it returns 404 instead of 405 - the latter
seemed complicated and also surprised me, if the API isn't on shouldn't it
be 404? Anyways, hopefully it's a small enough change.
I think there are some more code cleanups possible but at least things are
merged and probably working - Travis seems to get stuck on not being able
to connect to Cassandra but I'm hoping that's not related to armeria.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/openzipkin/zipkin/pull/2348#issuecomment-469005757,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAD61xahZ3pTx2SdsBoxxDX4ZlhOXhLvks5vS5lHgaJpZM4Z8be3
.

quick look noticed we drifted you. if you dont have time to adjust for the
new dual mounted ui stuff, I can take a look later maybe Tuesday.
have a presentation to write then a family visit meanwhile
thanks for the continued swing on this. I also want this merged asap
On Sun, Mar 3, 2019, 7:47 AM Adrian Cole<EMAIL_ADDRESS>wrote:

will take a look. thanks!
On Sun, Mar 3, 2019 at 5:43 PM Anuraag Agrawal<EMAIL_ADDRESS>wrote:

Updated this branch and CircleCI passes now. I made one behavior change
in that when collector is disabled, it returns 404 instead of 405 - the
latter seemed complicated and also surprised me, if the API isn't on
shouldn't it be 404? Anyways, hopefully it's a small enough change.
I think there are some more code cleanups possible but at least things
are merged and probably working - Travis seems to get stuck on not being
able to connect to Cassandra but I'm hoping that's not related to armeria.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/openzipkin/zipkin/pull/2348#issuecomment-469005757,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAD61xahZ3pTx2SdsBoxxDX4ZlhOXhLvks5vS5lHgaJpZM4Z8be3
.

While going through my github.com/pulls, I found this blast from the past!
https://github.com/anuraaga/zipkin-java/pull/2
@trustin remember those old APIs? :D

@adriancole I noticed the drift, I think I merged it ok and the integration tests run (admittedly only running the tests, not the UI itself) but did you notice something that doesn't look right related to the dual mounted? Anyways, in no rush so could wait until Tuesday or whenever

@trustin remember those old APIs? :D

Ohh, that's a very long time ago. :rofl: Never knew you tried to replace Spring Web at that time! I hope we are getting better and better in terms of API usability and user happiness. :crossed_fingers:

I'll try to figure out what this is tonight.
[ERROR]   ITZipkinMetricsHealth.writeSpans_updatesPrometheusMetrics:165 NullPointer

actually ITZipkinMetricsHealth is an unrelated flake. there's no reason it should pass or not pass based on this code change.

using in mem and the script here one request bombed like this. not critical but after merge possibly interesting to folks maybe @trustin
https://github.com/openzipkin/zipkin/pull/1806#issue-153649052
2019-03-06 17:15:58.938  WARN 69546 --- [worker-nio-2-15] c.l.a.s.HttpServerHandler                : [id: 0xba9745a4, L:<IP_ADDRESS>/<IP_ADDRESS>:9411 ! R:/0:0:0:0:0:0:0:1:62432][h1c] Unexpected exception:

java.io.IOException: Protocol wrong type for socket
	at sun.nio.ch.FileDispatcherImpl.write0(Native Method) ~[?:?]
	at sun.nio.ch.SocketDispatcher.write(SocketDispatcher.java:47) ~[?:?]
	at sun.nio.ch.IOUtil.writeFromNativeBuffer(IOUtil.java:113) ~[?:?]
	at sun.nio.ch.IOUtil.write(IOUtil.java:58) ~[?:?]
	at sun.nio.ch.IOUtil.write(IOUtil.java:50) ~[?:?]
	at sun.nio.ch.SocketChannelImpl.write(SocketChannelImpl.java:466) ~[?:?]
	at io.netty.channel.socket.nio.NioSocketChannel.doWrite(NioSocketChannel.java:405) ~[netty-transport-4.1.33.Final.jar!/:4.1.33.Final]
	at io.netty.channel.AbstractChannel$AbstractUnsafe.flush0(AbstractChannel.java:938) [netty-transport-4.1.33.Final.jar!/:4.1.33.Final]
	at io.netty.channel.nio.AbstractNioChannel$AbstractNioUnsafe.flush0(AbstractNioChannel.java:360) [netty-transport-4.1.33.Final.jar!/:4.1.33.Final]
	at io.netty.channel.AbstractChannel$AbstractUnsafe.flush(AbstractChannel.java:905) [netty-transport-4.1.33.Final.jar!/:4.1.33.Final]
	at io.netty.channel.DefaultChannelPipeline$HeadContext.flush(DefaultChannelPipeline.java:1370) [netty-transport-4.1.33.Final.jar!/:4.1.33.Final]
	at io.netty.channel.AbstractChannelHandlerContext.invokeFlush0(AbstractChannelHandlerContext.java:776) [netty-transport-4.1.33.Final.jar!/:4.1.33.Final]
	at io.netty.channel.AbstractChannelHandlerContext.invokeFlush(AbstractChannelHandlerContext.java:768) [netty-transport-4.1.33.Final.jar!/:4.1.33.Final]
	at io.netty.channel.AbstractChannelHandlerContext.flush(AbstractChannelHandlerContext.java:749) [netty-transport-4.1.33.Final.jar!/:4.1.33.Final]
	at io.netty.channel.ChannelDuplexHandler.flush(ChannelDuplexHandler.java:117) [netty-transport-4.1.33.Final.jar!/:4.1.33.Final]
	at io.netty.channel.AbstractChannelHandlerContext.invokeFlush0(AbstractChannelHandlerContext.java:776) [netty-transport-4.1.33.Final.jar!/:4.1.33.Final]
	at io.netty.channel.AbstractChannelHandlerContext.invokeFlush(AbstractChannelHandlerContext.java:768) [netty-transport-4.1.33.Final.jar!/:4.1.33.Final]
	at io.netty.channel.AbstractChannelHandlerContext.flush(AbstractChannelHandlerContext.java:749) [netty-transport-4.1.33.Final.jar!/:4.1.33.Final]
	at io.netty.handler.flush.FlushConsolidationHandler.flushNow(FlushConsolidationHandler.java:206) [netty-handler-4.1.33.Final.jar!/:4.1.33.Final]
	at io.netty.handler.flush.FlushConsolidationHandler.flushIfNeeded(FlushConsolidationHandler.java:199) [netty-handler-4.1.33.Final.jar!/:4.1.33.Final]
	at io.netty.handler.flush.FlushConsolidationHandler.resetReadAndFlushIfNeeded(FlushConsolidationHandler.java:194) [netty-handler-4.1.33.Final.jar!/:4.1.33.Final]
	at io.netty.handler.flush.FlushConsolidationHandler.channelReadComplete(FlushConsolidationHandler.java:147) [netty-handler-4.1.33.Final.jar!/:4.1.33.Final]
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelReadComplete(AbstractChannelHandlerContext.java:398) [netty-transport-4.1.33.Final.jar!/:4.1.33.Final]
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelReadComplete(AbstractChannelHandlerContext.java:380) [netty-transport-4.1.33.Final.jar!/:4.1.33.Final]
	at io.netty.channel.AbstractChannelHandlerContext.fireChannelReadComplete(AbstractChannelHandlerContext.java:373) [netty-transport-4.1.33.Final.jar!/:4.1.33.Final]
	at io.netty.handler.timeout.IdleStateHandler.channelReadComplete(IdleStateHandler.java:295) [netty-handler-4.1.33.Final.jar!/:4.1.33.Final]
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelReadComplete(AbstractChannelHandlerContext.java:398) [netty-transport-4.1.33.Final.jar!/:4.1.33.Final]
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelReadComplete(AbstractChannelHandlerContext.java:380) [netty-transport-4.1.33.Final.jar!/:4.1.33.Final]
	at io.netty.channel.AbstractChannelHandlerContext.fireChannelReadComplete(AbstractChannelHandlerContext.java:373) [netty-transport-4.1.33.Final.jar!/:4.1.33.Final]
	at io.netty.channel.DefaultChannelPipeline$HeadContext.channelReadComplete(DefaultChannelPipeline.java:1413) [netty-transport-4.1.33.Final.jar!/:4.1.33.Final]
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelReadComplete(AbstractChannelHandlerContext.java:398) [netty-transport-4.1.33.Final.jar!/:4.1.33.Final]
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelReadComplete(AbstractChannelHandlerContext.java:380) [netty-transport-4.1.33.Final.jar!/:4.1.33.Final]
	at io.netty.channel.DefaultChannelPipeline.fireChannelReadComplete(DefaultChannelPipeline.java:936) [netty-transport-4.1.33.Final.jar!/:4.1.33.Final]
	at io.netty.channel.nio.AbstractNioByteChannel$NioByteUnsafe.read(AbstractNioByteChannel.java:168) [netty-transport-4.1.33.Final.jar!/:4.1.33.Final]
	at io.netty.channel.nio.NioEventLoop.processSelectedKey(NioEventLoop.java:677) [netty-transport-4.1.33.Final.jar!/:4.1.33.Final]
	at io.netty.channel.nio.NioEventLoop.processSelectedKeysOptimized(NioEventLoop.java:612) [netty-transport-4.1.33.Final.jar!/:4.1.33.Final]
	at io.netty.channel.nio.NioEventLoop.processSelectedKeys(NioEventLoop.java:529) [netty-transport-4.1.33.Final.jar!/:4.1.33.Final]
	at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:491) [netty-transport-4.1.33.Final.jar!/:4.1.33.Final]
	at io.netty.util.concurrent.SingleThreadEventExecutor$5.run(SingleThreadEventExecutor.java:905) [netty-common-4.1.33.Final.jar!/:4.1.33.Final]
	at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30) [netty-common-4.1.33.Final.jar!/:4.1.33.Final]
	at java.lang.Thread.run(Thread.java:834) [?:?]

ps above is not a problem as it was one of hundreds of thousands of requests

I'm very happy with this change. I ran wrk and found that this results in far more consistent latency, which is great for apps
BEFORE
  Thread Stats   Avg      Stdev     Max   +/- Stdev
    Latency     9.03ms   27.60ms 275.16ms   92.96%
    Req/Sec    16.09k     4.18k   23.37k    82.48%
  Latency Distribution
     50%    1.78ms
     75%    2.01ms
     90%    3.92ms
     99%  148.75ms
  1874690 requests in 30.03s, 212.75MB read
Requests/sec:  62421.95
Transfer/sec:      7.08MB

AFTER
  Thread Stats   Avg      Stdev     Max   +/- Stdev
    Latency     4.92ms    5.08ms  63.50ms   95.37%
    Req/Sec     7.62k     1.29k   10.95k    70.99%
  Latency Distribution
     50%    3.46ms
     75%    4.07ms
     90%    6.93ms
     99%   32.97ms
  909271 requests in 30.00s, 84.98MB read
Requests/sec:  30304.72
Transfer/sec:      2.83MB

@anuraaga you are the hero of this change. thank you so much

I'm curious why we have half the original throughput. Is this expected? I'd like to do some profiling later. Would you mind letting me know how to reproduce the benchmark, e.g. how to set up and what wrk command to run.

@trustin
so here's the thing.. build the and start the server per the bottom of zipkin-server/README.md
Make zipkin-json.lua
wrk.method = "POST"
wrk.headers["Content-Type"] = "application/json"
wrk.body   = '[{"traceId":"4d1e00c0db9010db86154a4ba6e91385","parentId":"86154a4ba6e91385","id":"4d1e00c0db9010db","kind":"CLIENT","name":"get","timestamp":1472470996199000,"duration":207000,"localEndpoint":{"serviceName":"frontend","ipv6":"7::<IP_ADDRESS>"},"remoteEndpoint":{"serviceName":"backend","ipv4":"<IP_ADDRESS>","port":9000},"annotations":[{"timestamp":1472470996238000,"value":"foo"},{"timestamp":1472470996403000,"value":"bar"}],"tags":{"http.path":"/api","clnt/finagle.version":"6.45.0"}}]'

run it 5 times picking best
wrk -t4 -c128 -d30s http://localhost:9411/api/v2/spans -s zipkin-json.lua --latency

you can compare this vs the previous commit

@trustin ps I think the previous had better throughput as the P<=50 was faster

Just curious, in your performance numbers above there are less than half the req/sec in the after compared with the before

@jcarres-mdsol yes though the >90% latency is much better which is indicative of what zipkin would be under load. Also, this is a dummy request.. I doubt most real servers were servicing 60k requests/second in real life with the resources of my laptop.

reason I'm less concerned about the raw throughput difference iotw, is that usually storage falls over faster than this.

for those watching from home, a more realistic test would be to load up a megabyte of bundled span data per POST message as opposed to a single tiny span. Then see about 240MB/s (peak throughput site like netflix)/ however many servers that site uses. Also consider non-peak. Also consider that most high throughput sites don't even use http (for example most use kafka). That's how I end up not terribly concerned about the amount of requests per second even if this "hello span" might seem damning if looking mostly at the raw throughput.
That plus there's likely some optimizations to follow. make sense?

here's another datapoint.. my laptop before this change with docker and mysql attached as opposed to in-memory
    Latency    27.29ms   17.77ms 164.65ms   80.97%
    Req/Sec     1.24k   430.38     2.42k    75.96%
  Latency Distribution
     50%   23.40ms
     75%   33.27ms
     90%   47.81ms
     99%   94.82ms
  12846 requests in 2.60s, 1.46MB read
  Socket errors: connect 0, read 75, write 0, timeout 0
Requests/sec:   4931.43
Transfer/sec:    573.09KB

basically we can isolate some things about http, but all-in this "wrk" test is not accurate for measuring integrated actual usage unless you are hitting your own install.

a cooler test is also to hit one of the -example apps, like https://github.com/openzipkin/zipkin-ruby-example. This will make more realistic span data although definitely unrealistic to most sites as only 2 services.
ex wrk -t4 -c128 -d30s http://localhost:8081  --latency
then look at prometheus stats on the zipkin server instead of wrk stats (which will only tell you about the example app). anyway this is fun.

Ruby will definitely be the bottleneck.
Thanks for the details!

@adriancole Thanks. Will take a look to find out what we can do to make it perform better.
@anuraaga Great job!

Now that we support http/2, I was able to make a few runs to show some differences, using the same test json, against the same server. While this is laptop, it is an interesting thing we can now use.
http 1 (text framing)
$ h2load -n100000 -c100 -m10 http://localhost:9411/api/v2/spans -d fooooo.json --h1
starting benchmark...
spawning thread #0: 100 total client(s). 100000 total requests
Application protocol: http/1.1
progress: 10% done
progress: 20% done
progress: 30% done
progress: 40% done
progress: 50% done
progress: 60% done
progress: 70% done
progress: 80% done
progress: 90% done
progress: 100% done

finished in 3.07s, 32558.26 req/s, 3.04MB/s
requests: 100000 total, 100000 started, 100000 done, 100000 succeeded, 0 failed, 0 errored, 0 timeout
status codes: 100000 2xx, 0 3xx, 0 4xx, 0 5xx
traffic: 9.35MB (9800000) total, 5.05MB (5300000) headers (space savings 0.00%), 1.14MB (1200000) data
                     min         max         mean         sd        +/- sd
time for request:      107us    341.96ms      2.96ms     12.15ms    99.32%
time for connect:      215us      6.37ms      2.58ms      1.61ms    64.00%
time to 1st byte:     7.42ms     17.79ms     12.71ms      2.53ms    63.00%
req/s           :     325.86      363.59      337.85        8.32    70.00%

http 2 (binary framing)
$ h2load -n100000 -c100 -m10 http://localhost:9411/api/v2/spans -d fooooo.json
starting benchmark...
spawning thread #0: 100 total client(s). 100000 total requests
Application protocol: h2c
progress: 10% done
progress: 20% done
progress: 30% done
progress: 40% done
progress: 50% done
progress: 60% done
progress: 70% done
progress: 80% done
progress: 90% done
progress: 100% done

finished in 2.01s, 49772.07 req/s, 2.24MB/s
requests: 100000 total, 100000 started, 100000 done, 100000 succeeded, 0 failed, 0 errored, 0 timeout
status codes: 100000 2xx, 0 3xx, 0 4xx, 0 5xx
traffic: 4.50MB (4713900) total, 295.41KB (302500) headers (space savings 95.20%), 1.14MB (1200000) data
                     min         max         mean         sd        +/- sd
time for request:      550us    231.94ms     19.42ms     26.36ms    95.22%
time for connect:      457us      7.64ms      4.09ms      2.11ms    58.00%
time to 1st byte:    16.73ms    105.63ms     31.54ms     14.78ms    89.00%
req/s           :     498.31      537.56      511.34        9.70    70.00%

For those using okhttp sender, you can use http/2 like below, but make sure you are using the latest zipkin server as prior to that, it didn't accept http/2 requests!
  @Bean Sender sender() {
    OkHttpSender.Builder senderBuilder = OkHttpSender.newBuilder();
    senderBuilder.clientBuilder().protocols(Collections.singletonList(Protocol.H2_PRIOR_KNOWLEDGE));
    return senderBuilder.endpoint("http://<IP_ADDRESS>:9411/api/v2/spans").build();
  }


Don't swallow result of Kafka consumer offset commit

Also don't recover if we failed to commit the offset

This PR was successfully deployed to production by CircleCI build 54 at 2017-01-11 14:42 GMT.


Specify that you can pass a -1

The docs say...

you need to provide a non-zero positive number

However, you can pass -1 too. In this PR, I make this more clear.

@Marco-Santoni : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#label:"aq-pr-triaged"

@Marco-Santoni Thank you for the suggestion! @markjbrown Mark, could you help me verify the change in this PR? If correct, I'll sign off and merge it. #assign:markjbrown

Thanks @Marco-Santoni for your suggestion.
Yes, a user could update a document to include "ttl: -1" and the effect would be for the document to not TTL off.
However, why would a user do this when they could more easily do nothing for the same result? I'm struggling to come up with a scenario where a user would do this.

@markjbrown  thanks for the feedback. Maybe the following scenario could be a case.
Consider a container with default_ttl=20. You may want to write an item that does not expire. In that case, you would set ttl=-1.

Yeah ok. Makes sense. Sure, I'll sign off on this change.
thanks again for your suggestion.

#sign-off


fixing file size to account for plevinterp changes

In latest tests we get a too small file size as output file size is calculated based on 70 model levels of input variable, rather than the 3 pressure levels of the output. Need to include size correction in check_calculation function in mop_setup.py

fixed in 189ad2a3743464a77c1c45103d3b89172d2a5f27


Version 0.2.x seems to be broken

Workaround is to continue to use version 0.1.0
failed to unmarshal manifest: error converting YAML to JSON: yaml: mapping values are not allowed in this context
There seems to be an issue with some yaml marshaling somewhere

I think this version is broken specifically in cases where the argocd-repo-server doesn't run as argocd. In our situation, this is in Openshift 4 using the random uid assigned via the restricted SCC.
On a vanilla cluster using argocd user in the repo-server pod, this is the result after running the plugin:
argocd@argocd-repo-server-7dc6c547c5-xswgw:~$ ls -lra .
total 36
drwxr-xr-x 7 argocd argocd 4096 Jan 13 21:08 ibm-object-storage-plugin
drwx------ 2 argocd argocd 4096 Jan 25 17:59 .ssh
drwxr-xr-x 3 argocd argocd 4096 Jan 13 21:08 .local
drwxr-xr-x 3 argocd argocd 4096 Jan 13 21:08 .config
drwxr-xr-x 3 argocd argocd 4096 Jan 13 21:08 .cache
drwxr-xr-x 2 argocd argocd 4096 Jan 25 17:59 .avp
drwxr-xr-x 1 root   root   4096 Jan 10 05:32 ..
drwxrwxr-x 1 argocd root   4096 Jan 25 17:59 .
argocd@argocd-repo-server-7dc6c547c5-xswgw:~$

The logic to create the cached copy of the Vault token in the .avp folder works fine, but notice it's owned by argocd user and group.
I simulated OCP4 locally via
securityContext:
   runAsUser: 1001

and ended up with the error described above.
The weird thing is that I tried using the plugin from #41 which specifically adds error messages for this kind of situation, but I didn't see anything. Need to dig deeper there.

I think this version is broken specifically in cases where the argocd-repo-server doesn't run as argocd. In our situation, this is in Openshift 4 using the random uid assigned via the restricted SCC.
On a vanilla cluster using argocd user in the repo-server pod, this is the result after running the plugin:
argocd@argocd-repo-server-7dc6c547c5-xswgw:~$ ls -lra .
total 36
drwxr-xr-x 7 argocd argocd 4096 Jan 13 21:08 ibm-object-storage-plugin
drwx------ 2 argocd argocd 4096 Jan 25 17:59 .ssh
drwxr-xr-x 3 argocd argocd 4096 Jan 13 21:08 .local
drwxr-xr-x 3 argocd argocd 4096 Jan 13 21:08 .config
drwxr-xr-x 3 argocd argocd 4096 Jan 13 21:08 .cache
drwxr-xr-x 2 argocd argocd 4096 Jan 25 17:59 .avp
drwxr-xr-x 1 root   root   4096 Jan 10 05:32 ..
drwxrwxr-x 1 argocd root   4096 Jan 25 17:59 .
argocd@argocd-repo-server-7dc6c547c5-xswgw:~$

The logic to create the cached copy of the Vault token in the .avp folder works fine, but notice it's owned by argocd user and group.
I simulated OCP4 locally via
securityContext:
   runAsUser: 1001

and ended up with the error described above.
The weird thing is that I tried using the plugin from #41 which specifically adds error messages for this kind of situation, but I didn't see anything. Need to dig deeper there.

Indeed, I confirm that by setting the SCC for the namespace ArgoCD runs in to anyuid so that the argocd-repo-server runs as argocd, the plugin version 0.2.0 works fine. Since I imagine most of Argo is written to run as it's specified non-root user, I don't think we should put effort in allowing the plugin to work with a random uid (nonroot, restricted SCC's).

Indeed, I confirm that by setting the SCC for the namespace ArgoCD runs in to anyuid so that the argocd-repo-server runs as argocd, the plugin version 0.2.0 works fine. Since I imagine most of Argo is written to run as it's specified non-root user, I don't think we should put effort in allowing the plugin to work with a random uid (nonroot, restricted SCC's).

After a bit more debugging, all is clear:
v0.2.0 works only with argocd user since in that code,  the token is written to the file after login. Subsequent attempts to read the token to actually perform the work fail unless you are the right user.
v0.2.2 works only with argocd user because it won't trigger an error trying to write the token to disk, which causes the error in this issue yaml: mapping values are not allowed in this context since Argo is now trying to interpret the string error: somet error as YAML
#41 has been amended to fix this, and to make a note on the README about the user requirements for getting the token caching to work. We can't emit "warning messages" to appear in Argo's UI unf, and we decided it would be better for the plugin to work via logging into Vault every time than not work because it couldn't cache the token.

After a bit more debugging, all is clear:
v0.2.0 works only with argocd user since in that code,  the token is written to the file after login. Subsequent attempts to read the token to actually perform the work fail unless you are the right user.
v0.2.2 works only with argocd user because it won't trigger an error trying to write the token to disk, which causes the error in this issue yaml: mapping values are not allowed in this context since Argo is now trying to interpret the string error: somet error as YAML
#41 has been amended to fix this, and to make a note on the README about the user requirements for getting the token caching to work. We can't emit "warning messages" to appear in Argo's UI unf, and we decided it would be better for the plugin to work via logging into Vault every time than not work because it couldn't cache the token.

This fix has been published in 0.2.2

This fix has been published in 0.2.2


Extension host has with "ENOENT: no such file or directory"

I noticed several errors in extension host log, so used extension bisect command to find the issue is caused by this extension.
Looks like path concatenation gone wrong:
2024-01-16 17:15:29.827 [error] ENOENT: no such file or directory, realpath 'C:\d:\git\myrepo\main\output.log': Error: ENOENT: no such file or directory, realpath 'C:\d:\git\myrepo\main\output.log'

Maybe my "workspace" is a contributing factor. I work in several repos and multiple branches in each, so I use a folder structure with git worktrees, e.g.:

d:\git\repo-name    root for all worktrees
+- \dev             folder for "dev" branch
+- \main            folder for "main" branch
etc.

Then I open the root folder in VS Code.

Same here, plus some 2024-02-15 10:21:12.204 [error] ENOENT: no such file or directory, realpath 'C:\Users\mail\AppData\Local\Programs\Microsoft VS Code\rendererLog': Error: ENOENT: no such file or directory, realpath 'C:\Users\mail\AppData\Local\Programs\Microsoft VS Code\rendererLog' if you select text in the output window.

so used extension bisect command to find the issue is caused by this extension.

ugh, why are there no extension IDs provided in the host log?!
But I do understand both of you correct that you have not experienced any issues with the extension itself, only noticed the output errors, right?
If that is so, then I'm quite confident I have fixed these problems now with d50729e (technical explanation there) and v0.1.14. I'll close this, please let me know if it happens again! Any details on how/when exactly this happens would be great too.
As to why there was a C:\d:, I have no idea


Trafficserver cache error

My server uses 1TBSSD*4, raid0, and the cache is stored in the /home directory. If there are too many accesses, the hard disk will not be recognized. The log error is: cache disk operation failed WRITE -1 28

Can you please share your storage.config?

storage.config
/home/ats/cache 3500G

[Errno 28] No space left on device

Shouldn't new cache data automatically replace out-of-date cache data?

We highly discourage people from using the on-filesystem cache. it's intended for development / testing. You really should carve off that 3.5TB off /home, and make a RAW device for ATS to use IMO.
That much said, not sure what is going on here.

Maybe we should write a byte at the end of the file when we initiate the file.

@SolidWallOfCode is going to look at this

There are two issues that could be going wrong here, none of which come up if a raw partition is used.

When the cache reads "3500G" it interprets that as "3500 * 2^30" which is 3.75 * 10^12 which makes it possible there is really not that much space on the disk.
ATS will create a file of the appropriate size, but many operating systems will not actually allocate the space until required. This means disk space can run out due to too many accesses as the cache size grows, but ATS thinks it's already reserved the space. See here - the content is at the end of the storage.

We could try tweaking ATS to write the last byte for the storage file, which should force the file to exist. This could lead to very long start up times the first time ATS is started with that storage config.


wip topics extraction

Issue #, if available:
Description of changes:
wip topics extraction
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Closing the PR since we've decided not to extract sensor topics


Automated Splunk TA Update 99

This PR contains updates to Splunk TAs made by GitHub Actions workflow.

Closed in favor of duplicate PR https://github.com/splunk/security_content/pull/3220


Divided requirements for setup

Now basic requirements.txt contains only those libs that are mandatory for common ML usage whilst extra requirements in requirements_extra.txt contains libs for DNN, image and text processing.

Тут не перестанут падать тесты, пока не вынесем import cv2 из fedot.core.data.data.py, т.к. OpenCV отнесена к опциональным зависимостям.

В data.py действительно нужен фикс чтобы сделать cv2 необязательным.

Hello @IIaKyJIuH! Thanks for updating this PR.


[BEAM-13521] flink pvr batch precommit

Please add a meaningful description for your change here

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

run seed job

run Java_PVR_Flink_Batch precommit

no different than the state of the cron job: https://ci-beam.apache.org/job/beam_PreCommit_Java_PVR_Flink_Batch_cron/7233/

no different than the state of the cron job: https://ci-beam.apache.org/job/beam_PreCommit_Java_PVR_Flink_Batch_cron/7233/

Where is this job defined? I can't find it though it says it comes from the seed job

no different than the state of the cron job: https://ci-beam.apache.org/job/beam_PreCommit_Java_PVR_Flink_Batch_cron/7233/

Where is this job defined? I can't find it though it says it comes from the seed job. Double checking so we don't define this job twice.

It's defined in this PR. beam_PostCommit_Java_PVR_Flink_Batch was renamed when I ran the seed job. Apparently it keeps the history under the new job name.

Got it. That makes sense


fix(ama-sdk-schematics): update sdk template readme and fix typedoc generation

Proposed change
As discussed with @cpaulve-1A, this PR updates the SDK template README file to replace Swagger by OpenAPI and to improve the readability of the example.
This PR also fixes the generation of typedoc documentation of the generated SDK so that the API files are no longer excluded.

@matthieu-crouzet @fpaul-1A Thank you for your review!


update .env for nginx vars

This should allow you to configure nginx timeouts via .env

Hi @rbos, we discussed this in the tech call today and it looks good. Would you mind adding the default values from buildkit to sample.env?
So instead of the commented out options, it should look like this:
NGINX_FASTCGI_READ_TIMEOUT=60s
NGINX_FASTCGI_SEND_TIMEOUT=60s
NGINX_FASTCGI_CONNECT_TIMEOUT=60s
NGINX_PROXY_READ_TIMEOUT=60s
NGINX_PROXY_SEND_TIMEOUT=60s
NGINX_SEND_TIMEOUT=60s


MultiSource Collector using config yaml

Multiple sources can be handled with yaml config's credentials
Issue: ManageIQ/topological_inventory-orchestrator#27

[x] depends on ManageIQ/topological_inventory-ingress_api-client-ruby#42

@agrare pls review


Asynchronous DNS

Hi,
I'm trying to build a composable I/O framework on top of mio, and no wonder that I want DNS support for it. Would you like to join the effort?
What I'm thinking of, is having separate creates for the following things:

system_files: Reads system files (nsswitch.conf, hosts, resolv.conf)
dns_proto: Parses and constructs DNS packets

And probably few different implementations of the real address resolution:

Synchronous one based on stdlib types
Async one based on rotor
May be async one based on raw mio that is designed to be put to another thread

Probably some common parts of different implementations may be put to dns_proto too.
What to do you think?

If you want to use the resolve crate, I think it could potentially fulfill your needs, but it does need some work before it can be considered fully featured.
The public API of resolve includes facilities for encoding and decoding messages. These operate on individual messages and can be used with any UDP socket implementation. If you want to handle crafting and transport of messages in your own code, Message::decode and Message::encode may be all you need.
resolv.conf support is indeed woefully inadequate and support for other DNS-related configuration files is nonexistent. If you'd prefer to implement system configuration in your own code, you could certainly use resolve only for message decoding and encoding. It's also possible that support for these configuration files could be improved within resolve and a mechanism could be created to craft and/or modify incoming and outgoing messages according to a DnsConfig instance (which exists now, but is quite simple).
I don't see the advantage to making a separate crate for parsing system files unless you intend to implement the logic of these configurations in your own code. Personally, I'd prefer a complete "resolver" abstraction provided by a crate, which resolve could provide with some more work.

I don't see the advantage to making a separate crate for parsing system files unless you intend to implement the logic of these configurations in your own code.

Well, my gut feeling says that it would be nice to have as a separate crate for clarity. But in fact, yes, I need to get logic from the resolv.conf, in particular "options" setting.
And as I see your code has very limited parsing of resolv.conf I'd like to make it better from the start (in particular ignoring domain and search options would be super-surprising for many users).
From skimming the code I also have the following questions:

Why don't you use gethostname from either nix or libc? (I'm not sure, does it work on windows?)
I believe that idna encoding/decoding should also be in separate crate, because encoding/decoding can be used on it's own without any DNS implementation (or using libc implementation), for example in GUI for displaying names
I'm using stable rust, are there any features that it's hard to get rid of?

Why don't you use gethostname

gethostname is very restrictive in its functionality. It performs only name resolution (A and AAAA records) and cannot be used asynchronously. (Unless you count running the function in another thread and delivering the result through a channel, but that's not a good plan for applications which may be making many concurrent DNS requests).

idna encoding/decoding should also be in separate crate

There are punycode implementations in other crates that didn't quite meet my requirements. If that's the only functionality one needs, it is otherwise available.

I'm using stable rust, are there any features that it's hard to get rid of?

It appears that all features could be removed by putting the resolver module behind a crate feature, defining our own IpAddr type, and some other insignificant changes.
I happen to have some free time right now, so I'll see about making a few of these changes.

gethostname is very restrictive in its functionality. It performs only name resolution (A and AAAA records) and cannot be used asynchronously

Sorry AFAIK, it does no name resolution, it's simple system call that fetches a name known by system. And there is ffi definition in "libc" crate, and a safe wrapper in "nix" crate, it's probably simpler to use one if them instead of your own ffi definition.

There are punycode implementations in other crates that didn't quite meet my requirements. If that's the only functionality one needs, it is otherwise available.

Found only one in "url" crate. Can you be a little bit more specific what's wrong with it? (so I could chose one for my needs too :)  )

Oh, my mistake. I was thinking of gethostbyname. I don't see a declaration for gethostname in libc. A quick Google search shows that gethostname does exist in libc on Windows and with the same signature as POSIX. It seems pretty harmless to me to declare one FFI function.
I don't remember the issue I had with rust-url's punycode implementation. It may have been something very petty.

I was mistaken about being able to remove the ip_addr feature gate. I gave it a shot, but it's just too deeply embedded in the code right now.

It hasn't been thoroughly tested, but I've implemented a few more features of resolv.conf into DnsResolver. Unfortunately, that API is stuck being synchronous. I'm unsure how to build an API with these features that performs asynchronous requests and can be used from any possible event loop. I'll have to give this some further thought.

@tailhook: there are a couple of crates available offering asynchronous DNS.  Both are wrappers around C libraries:

c-ares (this one is mine)
unbound (this one is not mine)

Depending on what your goals are, these may or may not be interesting to you...

@dimbleby, sure, my goal is to write pure-rust inplementation.
Anyway probably this issue may be closed now.


Refactor BucketMetadata code.

I am about to create an ObjectMetadata class, as part of the fixes
for #553. I do not think we want to keep basically two copies of
the same code to parse the common parts of the metadata.

@houglum PTAL.