I18n

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.0 out of 2 committers have signed the CLA.:x: rtsao:x: tajoYou have signed the CLA already but the status is still pending? Let us recheck it.


[WIP][curl][Android] Fix compile curl with zlib from vcpkg

Force curl to compile with zlib from vcpkg when exist other zlib in the system
Fix #18015

Missing proper explanation why zlib from the android NDK is found. This is not a single port problem but a wider problem in my opinion.

@Neumann-A Explanation and prof found in the issue. If you still not find, please write here again.

Also the fix is general, not just for android.

The fix is not general..... If other ports depend on zlib the same issue appears again. Have you tried set(CMAKE_FIND_USE_PACKAGE_ROOT_PATH FALSE) (or ZLIB_ROOT) in your toolchain file?
Also if you don't want to use zlib from your NDK then your toolchain is wrong because it explicitly is setup in a way that finds the dependencies there. If you don't want that you have to setup your own toolchain instead.

@Neumann-A
I can do many things. Like you say it more general then this port.
Please read this comment:
https://github.com/microsoft/vcpkg/issues/18015#issuecomment-847041378

I think more people agree with me that vcpkg first need to find the things from the vcpkg. For example like lib curl that depend on zlib and compile vcpkg zlib because of it.  Also you want your library will be up to date for security issues and bug fixing.
So it a problem for a lot of people and Like you suggested, vcpkg need to fix it in more global way.
I give hear an humble suggestion how to fix only lib curl.
I hope more people will see my PR and have a suggestion how vcpkg should solve it in the general case. (for all ports).

Don't merge yet.
There is a general fix for this:
https://github.com/microsoft/vcpkg/pull/17336

Please run  vcpkg x-add-version curl to update version files after you complete all works.

@NancyLi1013 I am freezing this PR until I will find out the result of this PR #17336.
If they cancel it out, I will increase up the version inside the json file.
Thank you for your time and review.

Why do you close this PR?

Because they merge this PR https://github.com/microsoft/vcpkg/pull/17336 that fix my problem.


drivers: bluetooth: da1469x: Fix deferred buffer allocation

If rx buffer allocation has to be deferred to rx_thread, we need to stop isr reading from mailbox as otherwise rx_thread won't be able to process other buffers.
Since CMAC2SYS irq is cleared before data is read from mailbox, in case rx buffer allocation was deferred we also need to trigger irq manually to make sure all pending data is processed.

this was triggered by https://github.com/zephyrproject-rtos/zephyr/pull/73178 as number of completed packets events were queued in mailbox due to disabled interrupt...


Communication Obj-C unit tests fail on CI

Currently the Obj-C test are disabled.
The Obj-C unit tests seem to run fine locally via Xcode and command line. However when CI executes the unit tests the Obj-C tests don't pass reliably.

@bsiegel Closing this task since we now have a duplicate: https://github.com/Azure/azure-sdk-for-ios/issues/662
It seems to slowly be effecting more test cases not just the Obj-C ones so I think we should bump up the severity of this

@bsiegel Closing this task since we now have a duplicate: https://github.com/Azure/azure-sdk-for-ios/issues/662
It seems to slowly be effecting more test cases not just the Obj-C ones so I think we should bump up the severity of this


Not possible to publish a post with a photo until attached image URL returns successful response

Micro.blog iOS 3.3 (319)

Open new post screen
Click photo icon
Select photo
Photo shown to be uploading, with progress bar above thumbnail
One photo uploaded, thumbnail turns white
Enter text
Click ‘Post’
Error message: ‘Something went wrong. Please try again later’
Wait for photo to appear at location returned by media endpoint
Thumbnail shows photo again.
Click ‘Post’ again
Post is published

(…or at least it was the first time. Second time I tried this, I kept getting the same error message, but turns out each time I clicked ‘Post’, another version of the post was saved to my database. This might be a combination of bugs in both Micro.blog and Indiekit!)
Background
When a photo is uploaded to Indiekit, it returns a URL for where the image will be published. As that typically involves committing the file to a git repo, and then a service like Netlify publishing the file to a public URL, it can take ~1 minute for the file to appear at the location specified. I believe my media endpoint returns a 202 Accepted response alongside the Location header, I can’t remember.
Either way, I’m not sure if Micro.blog should care if an image location returns 404 initially… or at least for the case of third-party Micropub endpoints.

each time I clicked ‘Post’, another version of the post was saved to my database. This might be a combination of bugs in both Micro.blog and Indiekit!

Turns out this part of the bug is entirely Indiekit ☺


chore: set nats connection flush timeout

fixes #826

@yhl25 could you please test this out?

@yhl25 could you please test this out?

yes, the fix is working. I don't see the issue now.


Can't emit an array of obligations formed from an array of values

Bug Report 🐛
I need to emit multiple events based on the list of vendors, specified in my contract.
Here is how I envision that:
My grammar.tem.md:
[...]
{{#ulist vendors}}
{{businessName}}
{{/ulist}}
[...]

My model.cto:
event VendorNotification {
        o String code
        o String description
        o Vendor vendor
}

transaction NotifyVendorsReq extends Request {
  o String detectionCode
  o String description
}

transaction NotifyVendorsRes extends Response {
  o String output
}

participant Vendor identified by businessName {
  o String businessName
}
asset MyContract extends Contract {
  o Vendor[] vendors
}

And logic.ergo:
contract MyContractLogic over MyContract state State {

  //Iterate through an array of vendors and emit an event for each of them
  clause notifyVendors(request : NotifyVendorsReq) : NotifyVendorsRes emits VendorNotification[] {

    emit foreach vendor in contract.vendors
    return VendorNotification {
        code: request.notificationCode,
        description: request.description,
        vendor: vendor
     };

    return NotifyVendorsRes{ output: "Received " ++ request.notificationCode ++ " " ++ request.description ++ " and sent notification to vendors " ++ toString(contract.vendors) }
  }
}

cicero trigger throws “ERROR: Cannot read property ‘$coll’ of undefined”
Expected Behavior

The contract should emit an array of events
Current Behavior

Throws an error: “ERROR: Cannot read property ‘$coll’ of undefined”
Possible Solution

Would be good to make emit function compatible with an array of events.
Steps to Reproduce
Please see the bug report section.
Context (Environment)

Desktop

OS: macOS
Browser: NodeJS v10.18.1
Version: "cicero": "^0.22.1"

Detailed Description

The emit function can receive an array of events and emit them one-by-one to address the situation when multiple events need to be emitted in one go.
Possible Implementation

@frbrkoala Thanks for the bug report / feature request.
Just a quick update:

I was able to reproduce the issue. See the archive attached based on your example.
<EMAIL_ADDRESS>

The $coll exception is a runtime error which comes from an inconsistency between the Ergo type checker and the compiler. I think the intended behavior is for the suggested logic to fail type checking (with an error that the emit should be a singleton object).

This is a perfectly valid and useful requirement imho. I think there might be two ways to support this. First being your suggestion i.e., allow emit to take either a single item or an array (which would make it polymorphic). Second might be to keep emit over single items but generalize where emit is allowed and notably allow it use inside foreach. This would look something as follows (both options probably need work):

contract MyContractLogic over MyContract state State {

  //Iterate through an array of vendors and emit an event for each of them
  clause notifyVendors(request : NotifyVendorsReq) : NotifyVendorsRes emits VendorNotification[] {

    foreach vendor in contract.vendors
    return
       emit  VendorNotification {
          code: request.notificationCode,
          description: request.description,
          vendor: vendor
       };

    return NotifyVendorsRes{ output: "Received " ++ request.notificationCode ++ " " ++ request.description ++ " and sent notification to vendors " ++ toString(contract.vendors) }
  }
}


[DatePickerIOS] Warnings failed propType unexpected

I'm currently trying out the DatePickerIOS and this simple example throws two warnings :

constructor(props) {
  super(props);

  this.state = {
    timeZoneOffsetInHours: (-1) * (new Date()).getTimezoneOffset() / 60,
    date: new Date(),
    color: '#007AFF',
    minimumDate: this.props.minimumDate,
  }
}

onDateChange = (date) => {
  this.setState({date: date});
};

render () {
  return (
    <View style={styles.basicContainer}>
      <DatePickerIOS
        date={this.state.date}
        mode="datetime"
        timeZoneOffsetInMinutes={this.state.timeZoneOffsetInHours}
        onDateChange={() => this.onDateChange}
        minimumDate={this.state.minimumDate}
       />
    </View>
  );
};

I'm getting these warnings :
2016-03-03 09:32:58.829 [warn][tid:com.facebook.React.JavaScript] Warning: Failed propType: Invalid prop `date` of type `Number` supplied to `RCTDatePicker`, expected instance of `Date`. Check the render method of `DatePickerIOS`.
2016-03-03 09:32:58.830 [warn][tid:com.facebook.React.JavaScript] Warning: Failed propType: Required prop `onDateChange` was not specified in `RCTDatePicker`. Check the render method of `DatePickerIOS`.

I did a console.log(this.props) in react-native's file DatePickerIOS.ios.js in Libraries/Components and the output is the following :
{ date: Thu Mar 03 2016 09:32:58 GMT+0100 (CET),
  mode: 'datetime',
  timeZoneOffsetInMinutes: 1,
  onDateChange: [Function],
  minimumDate: undefined }

Any chances I'm doing this wrongly ?

+1 Getting the same error.

@facebook-github-bot label iOS

@ghamaide - seems like a bug! if someone can investigate this it would be appreciated. It's worth trying the DatePickerIOS example in UIExplorer and ensuring that works as expected without warnings, if not then use that as the test case to fix.

because of requireNativeComponent,  the RCTDatePickerIOS will be verify props base on the DatePickerIOS.propTypes.
but using RCTDatePickerIOS in the DatePickerIOS#render() was wrong, the date is number, undefined the onChange

Good discovery @epooren - that makes a lot of sense.

i fixed it at my branch

Would you mind opening a Pull Request with your changes? It'd be great to introduce a solution to this!

I'm still having the warning. Why is the pull request closed?

I implemented the pull request changes in my DatePickerIOS.ios.js and it didn't solve the problem. I now get:
JSON value '2016-05-17 20:24:59 +0000' of type NSDate cannot be converted to a date
Any other ideas how to make the DatePickerIOS component work?

@brentvatne If I make a pr so that datePicker can accept both a Number or a Date object and check the date to see if it can getTime would that be fine? This way the verification at the native level will be fine with the number

+1

Just started using the picker and also having the warning.

Hi there! This issue is being closed because it has been inactive for a while.
But don't worry, it will live on with ProductPains! Check out its new home: https://productpains.com/post/react-native/datepickerios-warnings-failed-proptype-unexpected
Product Pains has been very useful in highlighting the top bugs and feature requests:
https://productpains.com/product/react-native?tab=top
Also, if this issue is a bug, please consider sending a pull request with a fix.


developer strategy: ActionController::InvalidAuthenticityToken in SessionsController#create

Please complete all sections.
Configuration

Provider Gem: omniauth*     #.lock shows omniauth (1.9.0)
Ruby Version: 2.4.0
Framework: 'rails', '4.2.10'
Platform: ubuntu   #on cloud 9 ide

Expected Behavior
Using develper strategy, callback should be provided with valid token
Actual Behavior
Goes to auth/developer login  form correctly, but then raises following error instead of returning to auth/developer/callback which routes to sessions#create:
ActionController::InvalidAuthenticityToken in SessionsController#create
ActionController::InvalidAuthenticityToken
Steps to Reproduce
Register or Log In with Developer
Click on above link which is on login page.
Register or Log In with GitHub
Register or Log In with Facebook
Other links work normally, also passes Cucumber tests in test mode.
Only problem is that I need to do an end run on actual authentication while I'm in develper mode so actual providers aren't abused.
Let me know which files I should include.

I found this in another section of the Wiki:
Rails session is clobbered after callback on Developer strategy
The developer strategy callback is sent using POST request. Disable forgery protection for given action, otherwise session will be clobbered by rails.
skip_before_action :verify_authenticity_token, only: :create
Is this before_action being handled by omniauth itself, or should I add it to my controllers when NOT in developer mode?
It looks as though this scheme works by just adding that line in developer mode, and deleting it in production, which seems pretty unreliable.  Is there a way to enforce it automatically instead?


avoid putting null into segment download uri

If one of the segmentUriPrefix/Suffix config fields in PushJobSpec is not set, its value is null and 'null' is put in the segment uri like ....tar.gznull.

Codecov Report

Merging #8693 (99ad7f9) into master (f9e55ce) will decrease coverage by 3.41%.
The diff coverage is 50.00%.

@@             Coverage Diff              @@
##             master    #8693      +/-   ##
============================================
- Coverage     69.61%   66.19%   -3.42%
+ Complexity     4571     4388     -183
============================================
  Files          1722     1277     -445
  Lines         89849    64431   -25418
  Branches      13324    10015    -3309
============================================
- Hits          62548    42653   -19895
+ Misses        22959    18767    -4192
+ Partials       4342     3011    -1331

Flag
Coverage Δ

integration1
?

integration2
?

unittests1
66.19% <50.00%> (+0.04%)
:arrow_up:

unittests2
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...he/pinot/segment/local/utils/SegmentPushUtils.java
13.40% <50.00%> (-0.08%)
:arrow_down:

...va/org/apache/pinot/core/routing/RoutingTable.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...va/org/apache/pinot/common/config/NettyConfig.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...a/org/apache/pinot/common/metrics/MinionMeter.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...g/apache/pinot/common/metrics/ControllerMeter.java
0.00% <0.00%> (-100.00%)
:arrow_down:

.../apache/pinot/common/metrics/BrokerQueryPhase.java
0.00% <0.00%> (-100.00%)
:arrow_down:

.../apache/pinot/common/metrics/MinionQueryPhase.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...apache/pinot/common/helix/ExtraInstanceConfig.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...ache/pinot/server/access/AccessControlFactory.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...he/pinot/common/messages/SegmentReloadMessage.java
0.00% <0.00%> (-100.00%)
:arrow_down:

... and 681 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9e55ce...99ad7f9. Read the comment docs.


Console Errors When Developing

Describe the bug
A new icon was added to the settings page and doesn't have the correct attributes naming conventions that are used in other icons.
To Reproduce
Steps to reproduce the behavior:

Start development server
Go to the settings page (make sure to have your console open in your browser dev tools)
See the errors appear (image pasted below)

Expected behavior
Expected behavior is to not have console error that are preventable while developing gym tracker.
Screenshots

If you haven't committed anything to the branch you made, I can take this off your hands. 😄


Create load function for Dataset

Currently there is is functionality to optionally save the fetched tickers data, but no way to check for saved data and load it if it exists.
DOD: upon fetch attempt, looks locally for saved tickers and loads them instead of fetching them if they were previously saved.

I'm picking this up


Added quickstart link

As this was assigned to me, I didn't see this, pushed link directly to master.


Update documentation to reflect current procedure

Context
It's been a while since we've needed to generate a CSV to e-mail to CC; changes are now shown in the service UI for
CC users
Changes proposed in this pull request
Remove outdated text and make some parts clearer
Guidance to review

Still unsure what correct procedure is


Hygiene webapp improvements

My goals for this round of test improvement was >50% coverage across project and at least 20 tests.

Nice! good start

@ssmails, thanks for taking a look. yes, I should have indicated in my description that I haven't really built out testing yet for: MenuBar, Graph, Notifier, Results
But full app level "smoke tests" including routing and then good coverage in GraphContainer queryActions is what I've invested in, so far.

@arkxu, thanks for taking a look... please merge when you're able
it's true that entity API/graph component data is being requested out of an action dispatch, that's because that component hasn't been updated to use redux store yet
the data request to the query API, however, is being triggered in the queryActions and this is the pattern we'll continue to use moving forward


Fix activatableClass warning during build

This happens during the build:
##[warning]WindowsTerminal.manifest(0,0): Warning 81010002: Unrecognized Element "activatableClass" in namespace "urn:schemas-microsoft-com:winrt.v1".
    51>WindowsTerminal.manifest : manifest authoring warning 81010002: Unrecognized Element "activatableClass" in namespace "urn:schemas-microsoft-com:winrt.v1". [d:\a\1\s\src\cascadia\WindowsTerminal\WindowsTerminal.vcxproj]

I don't want this to happen because it will get in the way of seeing other more valid errors.
I think @zadjii-msft knows something about this. Hopefully we can find a way around it (suppressing this one, using the right schema, etc.)

In the absence of a warning suppression flag for mt, the quickest way around this one is to use the 10.0.18362.0 SDK. The manifest tool there supports these new entries.

Wonder if these are in the managed agents yet given this is like a bleeding edge/just released SDK. Maybe someone can figure this out...

This fixed itself with the 18362 SDK.


Shroud misaligned after loading a vessel already in orbit

Pic:

Log and stuff:
https://www.dropbox.com/s/tupilrxxt3s7j8o/output_log.txt and stuff 2019-06-18-01.zip?dl=1

I did not use a "go to" feature from KAC or Kerbalism, I loaded the vessel from tracking station.

I've not been able to reconstruct this. Do you have a way to reconstruct this issue (with stock parts if possible)? Does this always happen if you load this vessel? If you launch the same vessel again, does it happen too?

The last two times I launched this (slightly edited but with same decoupler + shroud) it did not happen.
I will close this for now.


system/libuv: Include nuttx/tls.h to call task local storage api

Summary
follow up the change in https://github.com/apache/incubator-nuttx/pull/6337
Impact
It's always good to include the header file explicitly
Testing
Pass CI

@pkarashchenko could you merge this simple change? Other patch depends on this patch.


Parent issue: Add assay1 vs assay2 correlation plugin

This issue tracks the backend and frontend tasks for adding a new flavor of correlation plugin. This flavor will take one type of assay (for example, pathway abundance) and correlate it with another chosen assay (for example, taxa abundance). The resulting viz will be a bipartite network, just like we have for the current correlation plugin.
Backend:

[x] https://github.com/VEuPathDB/microbiomeComputations/issues/61
[x] https://github.com/VEuPathDB/service-eda-compute/issues/76
[x] https://github.com/VEuPathDB/EdaDataService/issues/333

Frontend:

[x] #666

wow this is done!


ORSSerialPortManager's kIOPublishNotification not firing in sandboxed app

I'm working with an Arduino board connected via USB. When I run the example project ORSSerialPortDemo, the list of available ports is automatically updated when I plug in the board (while the app is already running). However, when I use the same technique in my own sandboxed app (an NSArrayController bound to ORSSerialPortManager.availablePorts) the list is never updated.
I put an NSLog in -ORSSerialPortManager's serialPortsWerePublished: and in the sandboxed app it never gets called when I plug in the board while the app is running, in ORSSerialPortDemo it shows up in the log.
My conclusion is that IOKit's kIOPublishNotification does not fire in a sandboxed app. I'm compiling and running ORSSerialPort as a framework.
The framework has its own entitlements:

com.apple.security.app-sandbox
com.apple.security.inherit

The app has the following entitlements:

com.apple.security.app-sandbox
com.apple.security.device.serial
com.apple.security.device.usb

The app builds the ORSSerialPort framework as a dependent target, then embeds it. Any ideas on how to deal with this?

The console shows no sandboxd messages when the sandboxed app is run, unlike ORSSerialPortDemo

Hi Elise,
This isn't something I've seen before. I've used ORSSerialPort in a couple sandboxed apps, including the latest version of Aether, the app it was originally developed for, and haven't had this issue. For fun, just now, I turned on sandboxing for ORSSerialPortDemo and confirmed that the ports list correctly updated when plugging in a USB to serial adapter.
A few questions to get started troubleshooting:

Does the behavior change if you plug in a USB to serial device? In other words, is it specific to your Arduino board?

What kind of Arduino is it? (I have a few around here, and could test with them if I have the same type and it makes sense to do so.)

Does the problem persist if you turn sandboxing off for your app?

Thanks for the troubleshooting tips, I just now got it working. I first verified that sandboxing worked with your ORSSerialPortDemo. When it did, I went back, turned off the sandboxing and cleaned and rebuilt first the dependent targets and then the main target. When the notifications came through, I turned on sandboxing and now it is working. I had done the cleaning & rebuilding last week (more times than I care to remember), but that was before I realized that each target should have its own entitlements file with the com.apple.security.inherit setting.
Also, yesterday I did some spring-cleaning in my developer certificates and keychain app. Anyway, somehow I stumbled upon the solution.


added verdi job worker pod/deployment

re-arranged ordering of deploy.sh and destroy.sh
moved factotum's Dockerfile to verdi/

will wait to merge #39 first

@LucaCinquini  i was trying to use the hysds/verdi docker image but for some reason the virtual environment wouldn't be activated when starting up as a k8 pod/deployment
the supervisord command & the python libraries weren't found
hysds/verdi would run normally when using docker so it looks the image was built to work in docker only (for now)
i chose to use our existing image because it already worked and not sure if hysds/verdi to work properly
it's not the same as the standard deployment because it wasn't originally designed to be containerized


Update config.toml

Add a config for the new CP patch.

I moved the new combat power script into the original combat power scripts file making this change unnecessary. Thanks though.


chore: mine 100 blocks to make output spendable

Unfortunately I was not able to reproduce the flakyness in CI. An assumption I have is that we either did not pick up the funds yet or the output was not yet spendable. By mining 100 blocks and ensuring the balance we will learn more

Did not help :( https://github.com/get10101/10101/actions/runs/6122039627/job/16616987266
"02000000000101ab9a1b08dedb24ed615ea47794ccfe3c0e537b5b9e280397f66a658193bacc320000000000c1d3b6800279a50000000000001600143db575e0be6c909e8c99e9b7f1ad4823f5de202877ac000000000000220020b602e28d6857a3d3b0ed2c8237f45bd72a8c56236a592efafd4c04511c72f56604004730440220614c05c9f8854b0d674671d56dafbc3d901366006e48af1b7cf9f458da4e7b540220424a064ee209c8d21fce373a67f2a7f4517bd1756f70ee990503bdc7a574d214014730440220557ce213c0c79e16be4476adfa66328ceb5611bcf845a6155da0bc72b7e22b17022069096fe4c9b3b2351cfd301df3cd892308106645d5a6df3b9756cf9607b1b9500147522103617a97d6d47b315ef4374b42cff06751eb2b36805c9cebd3c621df00b47120f22103e2f9cecb5bc5a0a6988de83c7ea8b7654297897df1d3d0956285a7c4c319be1052aea8731020" }
2023-09-08T13:12:31.840977Z ERROR ln_dlc_node::ln_dlc_wallet: Error when broadcasting transaction: Failed to broadcast transaction e3783fc0c7349bcf0ca7cfb980e25f97b2f546bd6eca6ed9a0e07c4060f53dfd: Esplora client error: HttpResponse(400) txid=e3783fc0c7349bcf0ca7cfb980e25f97b2f546bd6eca6ed9a0e07c4060f53dfd


Created Karatsuba algo

can you please update the PR with following links:

https://www.microsoft.com/en-us/research/wp-content/uploads/2016/02/fpl10_gary.pdf
https://cse.iitkgp.ac.in/~debdeep/osscrypto/eccpweb/pubs/vdat2007.pdf
If you have any other papers/resources to share, please add them as well :)

closing due to inactivity.


Add config option to disable ShowTitle option.

If a template doesn't include a title option (i.e displays just an image) then the show title checkbox can confuse CMS authors

Looks good
Before

After


Evaluation - Popularity-bias/novelty metric

Metrics that computes the popularity bias of the top-n recommended items.
A common choice for this metric is novelty as -log(norm_prob_item), where norm_prob_item = item_count / total_items_count, or just the average normalized popularity of top-k items like in here.
The popularity-bias metric is also computed based on item popularities. It is describe in the end of page 15 of this paper. That paper implementation of this metric is available here

solved by https://github.com/NVIDIA-Merlin/models/pull/371


Typo error: BRIT

Hi,
On page 64/101 of the 7.0.5 GEDCOM specification, the tag BIRT is misspelled as BRIT
I think this should be corrected to avoid confusion.
Regards,
Zurga

@ZurgaAnc Thanks for reporting this!   I just filed a pull request that will fix this.


Mwpw 129909

Resolves: MWPW-129909
Test URLs:

Before: https://main--milo--adobecom.hlx.page/drafts/sonja/tab-icon-inline-3-up?martech=off
After: https://mwpw-129909--milo--sonjapopovic.hlx.page/drafts/sonja/tab-icon-inline-3-up?martech=off

Thanks for the contribution! Please read the PR contribution guidelines when you get a moment. Following these guidelines will help get your PR approved faster.

closed since moved to other pr (https://github.com/adobecom/milo/pull/790), in order to reduce number of commits, based on contribution guidelines.


databases/redis: add reset db button

Add button to reset db.
My only problem is the scaling of the button, any idea how to put it on the correct place? :)

Now its this:

I can fix this post-merge if you want. Not sure what's going on in the CSS.

Would be awesome! :)

Merged, thanks!


feat(cli): add support for subsystems in writeAccess to LibDeploy

Depends on #265. Technically doesn't depend on #268, they can be merged in any order.
Allows subsystems to be used in writeAccess of deploy.json
Backwards-compatible

Closing for now until we agreed on a solution to the root issue of making systems more modular (discussion in #319), see https://github.com/latticexyz/mud/pull/268#issuecomment-1372252545


[move-prover] dedicated syntax for loop invariants

With the fine-grained separation of ConditionKind::Invariant, we can
finally use the invariant keyword to mark loop invariants.
The prior approach is to use assert to mark a loop invariant and
subsequently check whether this assert appears in a loop header
block. If an assert is in the loop header block, it is considered as
a loop invariant. Otherwise, it is considered as a normal assert.
The difference between a loop invariant and a normal assert is that
a loop invariant will be translated into three statements:

an assert in the beginning of the header block
an assume after havoc-ing loop induction variables,
an assert in the induction case checking block

While a normal assert will only be translated as an assert towards
the end of the loop header block.
It is better to review this PR commit by commit,

the first commit contains the core logic,
the subsequent fixup! commits are either mechanical changes
of assert -> invariant or auto-updated .md files
the last commit is a test case on invalid declarations of
invariant in the code.

Motivation
Separate the loop invariants and normal asserts in the code.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan

CI
new tests added

@mengxu-fb : Can asserts in the loop header block still be used as an invariant?  For example, what happens if the programmer wrote a sequence of invariants followed by a sequence of asserts?

Can asserts in the loop header block still be used as an invariant?

No, the asserts are just normal asserts, they will not be considered as loop invariants, i.e.,

they will not be checked on the loop base case
they will not be assumed after havoc
they will not be checked on the induction case.

what happens if the programmer wrote a sequence of invariants followed by a sequence of asserts?

invariant I1;
...
invariant In;

assert P;

Will be translated to
assert I1 ... In;
havoc;
assume I1 ... In;

assert P;

So, this is essentially saying, whether I1 & ... & In & (other conditions) ==> P. This can be viewed as a debugging tool to see whether we have put strong enough invariants to prove some property with the invariants.

/land


3 Errors After Importing Unity Package

Assets\PumkinsAvatarTools\Scripts\Editor\Data\PumkinsAvatarInfo.cs(8,19): error CS0234: The type or namespace name 'Validation' does not exist in the namespace 'VRC.SDKBase' (are you missing an assembly reference?)
Assets\PumkinsAvatarTools\Scripts\Editor\Data\PumkinsAvatarInfo.cs(9,19): error CS0234: The type or namespace name 'Validation' does not exist in the namespace 'VRC.SDKBase' (are you missing an assembly reference?)
Assets\PumkinsAvatarTools\Scripts\Editor\Data\PumkinsAvatarInfo.cs(17,9): error CS0246: The type or namespace name 'AvatarPerformanceStats' could not be found (are you missing a using directive or an assembly reference?)
Not sure what any of this means, but its keeping me from finishing an avatar, upon importing an older, most likely depreciated version it crashes after exiting PlayMode.

Make sure you're on the latest SDK and unity Unity 2019.4.29f1.

I get this issue with latest unity 2019.4.30f1

Getting these same 3 errors. using the latest sdk downloaded today. not sure what's causing it.

Should have been fixed by now


Forced Email Confirmation

Browser Version
Chrome
Exension Version
1.5.4
Actual behaviour
The extension works fine when getting rid of the paywall, but the page always blocks my access with a
"We've sent an email to<EMAIL_ADDRESS>and demands that a link in that gmail account be clicked to continue.
Reproduction steps

Using it normally

Expected behaviour
No response

Can you send me a screenshot of the page and the console's network tab?

dont know if this is what youre asking for. lmk.

Yes, it looks something like this.
On Wed, Dec 20, 2023 at 10:20 PM grogyy @.***> wrote:

Screenshot3.png (view on web)
https://github.com/rospino74/Quizlet-Bypass/assets/106680844/0fc0e87c-7054-4b5e-8d14-a27d9215825e
Screenshot2.png (view on web)
https://github.com/rospino74/Quizlet-Bypass/assets/106680844/38ac21c7-2fb6-43ac-babc-aa948bc197c9
Screenshot.2023-12-20.230739.png (view on web)
https://github.com/rospino74/Quizlet-Bypass/assets/106680844/969897b7-33d2-49d0-8ae2-0d0719c5513d
dont know if this is what youre asking for. lmk.
—
Reply to this email directly, view it on GitHub
https://github.com/rospino74/Quizlet-Bypass/issues/487#issuecomment-1865584280,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AOUABIQY53GL7UYKFAMNBYTYKPILDAVCNFSM6AAAAABA5FHO46VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRVGU4DIMRYGA
.
You are receiving this because you authored the thread.Message ID:
@.***>


Sample File Update

Information

Fixes some cehrt id examples and a mips file sample fix.

Checklist

[x] All JUnit tests pass (mvn clean verify).
[n/a] New unit tests written to cover new functionality.
[n/a] Added and updated JavaDocs for non-test classes and methods.
[n/a] No local design debt. Do you feel that something is "ugly" after your changes?
[n/a] Updated documentation (README.md, etc.) depending if the changes require it.

This is just a sample file update. I will merge this as it doesn't change much.


Add projects and ticked problems filters

Problems could be saved as projects or ticked, but the associated filters were missing.
This commit implements them.
The "Projects" and "Ticked" filters are mutually exclusive, but can be used in combination with all the other previously implemented filters, as shown in this screen recording:
https://github.com/boolder-org/boolder-android/assets/8343416/b544e882-b860-4e32-a069-1f90c79e06a9

No projects saved
No ticked problems

This works great 👍
One possible improvement: when the tick filter is activated but not visible (see screenshot below) it would be great if the user could deactivate the filter in one tap.
Solution idea: make the "clear" button always visible on the left when a filter is activated. The button should stay visible even as the user scrolls right. What do you think?

Solution idea: make the "clear" button always visible on the left when a filter is activated. The button should stay visible even as the user scrolls right. What do you think?

@nmondollot Here is what I could come up with:
https://github.com/boolder-org/boolder-android/assets/8343416/3ada5cab-b767-4cbd-a9ae-718300ab03e1
I did not have any idea to avoid the "cut" to the left of the scrolling content, is it ok for you?

Great!

I did not have any idea to avoid the "cut" to the left of the scrolling content, is it ok for you?

One idea: use an opacity gradient
a bit like this (from boolder's website):

One idea: use an opacity gradient

As the map content can vary behind the filters bar, I cannot apply a gradient with a fixed color like on the website (with the solid white background color). I will have to deal with the rendering of the filters bar itself to make its bound fading to transparency or not, which is way less trivial

Here is an alternative proposal, with a separator that appears when the filters bar is scrolled to the right:
https://github.com/boolder-org/boolder-android/assets/8343416/07a4bc7b-eb4a-4ab7-954a-2a2d601d5bb7
What do you think about it?

It looks nice!
Good job 👍
Let's ship it 🚢


[BSO] Pressing y to continue when doing one kill per trip at Vasa sends a full trip.

Fixed in next update.


feat: refactor CoreMemory to support generalized memory fields and memory editing functions

Please describe the purpose of this pull request.
This PR refactors the code to allow for customizable memory modules and deprecates usage of presets for agent creation. I also implemented functionality to match the LocalClient and RESTClient to make testing easier.
Generalized Memory Class
This PR introduces to create custom memory classes that have custom fields (must be either a str of List[str]) and custom memory editing functions, inspired by work in #895.
Sections of core memory are defined by a MemoryModule class (corresponds to sections of the in-context memory)
class MemoryModule(BaseModel):
    """Base class for memory modules"""

    description: Optional[str] = None
    limit: int = 2000
    value: Optional[Union[List[str], str]] = None

The default memory class is implemented on top of a base BaseMemory class:
class ChatMemory(BaseMemory):

    def __init__(self, persona: str, human: str, limit: int = 2000):
        self.memory = {
            "persona": MemoryModule(name="persona", value=persona, limit=limit),
            "human": MemoryModule(name="human", value=human, limit=limit),
        }

    def core_memory_append(self, name: str, content: str) -> Optional[str]:
        """
        Append to the contents of core memory.

        Args:
            name (str): Section of the memory to be edited (persona or human).
            content (str): Content to write to the memory. All unicode (including emojis) are supported.

        Returns:
            Optional[str]: None is always returned as this function does not produce a response.
        """
        self.memory[name].value += "\n" + content
        return None

    def core_memory_replace(self, name: str, old_content: str, new_content: str) -> Optional[str]:
        """
        Replace the contents of core memory. To delete memories, use an empty string for new_content.

        Args:
            name (str): Section of the memory to be edited (persona or human).
            old_content (str): String to replace. Must be an exact match.
            new_content (str): Content to write to the memory. All unicode (including emojis) are supported.

        Returns:
            Optional[str]: None is always returned as this function does not produce a response.
        """
        self.memory[name].value.replace(old_content, new_content)
        return None

Improve Agent Creation
Agent creation is modified to take in a memory class instead of human/persona/preset:
    def create_agent(
        self,
        name: Optional[str] = None,
        # model configs
        embedding_config: Optional[EmbeddingConfig] = None,
        llm_config: Optional[LLMConfig] = None,
        # memory
        memory: BaseMemory = ChatMemory(human=get_human_text(DEFAULT_HUMAN), persona=get_human_text(DEFAULT_PERSONA)),
        # tools
        tools: Optional[List[str]] = None,
        include_base_tools: Optional[bool] = True,
        # metadata
        metadata: Optional[Dict] = {"human:": DEFAULT_HUMAN, "persona": DEFAULT_PERSONA},
    ) -> AgentState:

Deprecated

Deprecation of human, persona and preset fields from agent creation
Deprecation of creating agents from preset

How to test
poetry run pytest -s tests/test_memory.py
Have you tested this PR?
Yes
Related issues or PRs
#895

Hi, I just wanted to show you @sarahwooders what I did in my MemGPT version to make the system prompt generation customizable. Similar to your MemoryModule, I introduced the SystemPromptModules, which are basically sections added to the system prompt.
memory_prompt = """1. Core Memory - Stores essential context about the user, your persona and your current scratchpad, it is divided into a user section, a persona section and your scratchpad section. You can use the scratchpad to plan your next actions. You can edit the core memory by calling the functions: 'core_memory_append', 'core_memory_remove' and 'core_memory_replace'.

2. Archival Memory - Archive to store and retrieve general information and events about the user and your interactions with it. Can be used by calling the functions: 'archival_memory_search' and 'archival_memory_insert'.

3. Conversation History - Since you are only seeing the latest conversation history, you can search the rest of the conversation history. Search it by using: 'conversation_search' and 'conversation_search_date'.

Always remember that the user can't see your memory or your interactions with it!"""

memory_intro_section = SystemPromptModule(section_name="memory_intro",
                                          prefix="To support you in your task as a AI assistant and to help you remembering things, you have access to 3 different types of memory.",
                                          position=SystemPromptModulePosition.after_system_instructions)
memory_intro_section.set_content(memory_prompt)

You can modify the content at runtime.

Thanks for sharing this! We're planning to also modularize the system prompt sections of the context as well, but will do it in another PR to try to control the scope of this one.

Also should we be adding a migration script for this pre-release?
VALIDATE None {'description': None, 'limit': 2000}
VALIDATE First name: Chad {'description': None, 'limit': 2000}
VALIDATE None {'description': None, 'limit': 2000}
VALIDATE First name: Chad {'description': None, 'limit': 2000}
Traceback (most recent call last):
  File "/Users/loaner/Library/Caches/pypoetry/virtualenvs/pymemgpt-JSsUGnlY-py3.10/lib/python3.10/site-packages/sqlalchemy/engine/base.py", line 1967, in _exec_single_context
    self.dialect.do_execute(
  File "/Users/loaner/Library/Caches/pypoetry/virtualenvs/pymemgpt-JSsUGnlY-py3.10/lib/python3.10/site-packages/sqlalchemy/engine/default.py", line 924, in do_execute
    cursor.execute(statement, parameters)
sqlite3.OperationalError: no such column: agents._metadata

  File "/Users/loaner/dev/MemGPT-fresh/memgpt/metadata.py", line 613, in list_agents
    results = session.query(AgentModel).filter(AgentModel.user_id == user_id).all()
...
sqlalchemy.exc.OperationalError: (sqlite3.OperationalError) no such column: agents._metadata
[SQL: SELECT agents.id AS agents_id, agents.user_id AS agents_user_id, agents.name AS agents_name, agents.system AS agents_system, agents.created_at AS agents_created_at, agents.llm_config AS agents_llm_config, agents.embedding_config AS agents_embedding_config, agents.state AS agents_state, agents._metadata AS agents__metadata, agents.tools AS agents_tools
FROM agents
WHERE agents.user_id = ?]

Thank you @Maximilian-Winter ! <3


[feat]: Dynamic index.html Message

Prerequisites

[X] I have searched for existing issues that already suggest this feature, without success.

Describe the Feature Request
Upon initial boot after a build, a loading screen appears and "Please wait several minutes and refresh the page." is displayed on the screen. This was updated  in https://github.com/Start9Labs/embassy-os/pull/1419/files/f948d4d0fa7246eb17b095744bb4ea2023e5ff9b#diff-0eb547304658805aad788d320f10bf1f292797b5e6d745a3bf617584da017051 since the previous message was much too short for an initial boot. Devices that have been booted before do not "load" on this screen for long. A dynamic message based on whether eOS has been booted before or not would be a "better" solution.
Describe the Use Case
Enabling a dynamic "loading" message can be useful in a number of situations. A couple are listed here but please comment with any more.

When building from source, the initial boot can take ~30min or so. A message detecting an initial boot can inform the user of this time.
The "loading" screen is up for too long. This might be indicative of a number of issues, but detecting the context of a boot and timing of a boot can help influence user action (or inaction in the case of initial boot)

Describe Preferred Solution
No response
Describe Alternatives
No response
Anything else?
No response

@elvece Happy for direction for implementation or suggestions.

the process of initialization after building from source is a difficult thing to measure and predict. it may be less effort to get an emulated raspberry pi environment running in qemu and perform this work during the build than to implement this

Will be obviated by init UI


Replace Path.open().read() with Path.read_text()

Path.read_text() returns the decoded contents of the pointed-to file as a string, and also handles closing the file after reading which previously wasn't being done.

Ah nice, thanks!


Panel user guide shows import panel as pn; pyviz shows import panel as pp

Which one is preferred?

pn is preferred; we need to update pyviz.


Support for MongoDB as an additional database in openFGA

Checklist

[X] I agree to the terms within the OpenFGA Code of Conduct.

Describe the problem you'd like to have solved
I've identified a crucial feature that's currently missing & might increase productivity, which became apparent due to my production app utilizing MongoDB Atlas as its database. Currently, only MySQL and PostgreSQL are supported. As a result, I had to provision a separate cloud server specifically for MySQL, which is my preferred current choice for openFGA. This not only increases the complexity of managing the database server but also consumes additional time optimizing both the databases.
Describe the ideal solution
I would like to suggest the addition of MongoDB as an add-on to OpenFGA. Ideally, this would include straightforward data migration options via the OpenFGA CLI. Thanks.
Alternatives and current workarounds
No response
Additional context
No response

Hi @S4nfs, we are discussing internally within the team how to make the addition of new supported databases a smoother and faster experience, both for the community and the maintainers. Sadly, we don't have a specific date for when the design will be finalized, but I'll post here when we have updates. Stay tuned :)

I imagine it'll be possible, and the right time to revisit this if/when https://github.com/openfga/roadmap/issues/49 makes some traction. In principle if you can support DynamoDB, MongoDB isn't a huge leap from there.

The issue isn't storing the json/tuples per se, it's more the query patterns are quite SQL friendly and not very NoSQL friendly at a guess.


Requesting pokemon theme

I would love to see a pokemon related theme ( actually pokegirl centric)
I don't have much knowledge of js, but could help you by supplying photos or gifs. Kindly give it a thought.

Hey!
Thanks for the interest. I've already got my hands full with 88 themes, however submitting a theme request is free.
You can always customize your VSCode with the custom assets feature of the plugin.
For inspiration, you can check out this existing Pokemon theme for hyper.js https://github.com/klaussinani/hyper-pokemon#--hyper-pokemon
Thanks for the interest!


[#159] script-generator

What ?
Generate a Kotlin script from an existing YAML workflow
export URL=https://raw.githubusercontent.com/jmfayard/refreshVersions/main/.github/workflows/publish-mkdocs-website.yml
./gradlew :script-generator:run --args $URL

See script-generator/README.md
Why ?
When lots of suffering has been put into making a YAML workflow to work, people are reluctant to start over from scratch with a library they have yet to know. Better the devil you know... And we don't really plan to change the YAML workflow a lot anyway, what's the point ?
 Collection.joinToCode() utility
I try to re-use when possible code that was made for generating the YAML inside the library module, using then the new annotation @InternalGithubActionsApi
The integration tests from the folder yaml-input cover a lots, in my experience the smallest mistake is detected soon with them. And we can add new integration tests easily if we have interesting existing YAML workflows

I added the CODEOWNERS file, please add this line there:
/script-generator/ @jmfayard

@krzema12 Can you have a look at the doc? https://github.com/krzema12/github-actions-kotlin-dsl/blob/7f4724343b47f4f02c6935ea63b802a585dd6306/docs/user-guide/script-generator.md
I'm done with the rest.

Thank you for this awesome piece of work :) Kudos!

thanks a lot :)


Store deleted (soft-delete) fields as a date instead of a boolean

Just a suggestion - It would be nice to store this so as to know the time record was soft-deleted.

Assuming that you can't modify a deleted item wouldn't that just be the same updatedAt?

https://github.com/feathersjs/feathers-hooks-common/issues/130 makes the same point. however, as daffl points out, i don't know if its worthwhile enough to force existing users to rebuild existing tables.


settings_users: Convert module to TypeScript.

Very skeptical about the position of the functions. I also gave a second thought on making a class, but I've kept it simple for now. Would love to hear feedback on this.

Self-review checklist

[x] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[x] Explains differences from previous plans (e.g., issue description).
[x] Highlights technical choices and bugs encountered.
[x] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[x] Each commit is a coherent idea.
[x] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[ ] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

You’ve changed so much code that Git doesn’t recognize it as a file rename. This is a good sign that you need to split your change into a number of smaller logical commits.

@afeefuddin is this ready for another review?

Not yet.

Ready for another look! Failing tests seem unrelated to me.

Addressed all the feedbacks, assert bot_info to never return undefined.

Closing in favor of #32239, but it's probably worth @afeefuddin checking if any of his refactor would be good improvements on top of that. Thanks for the effort @afeefuddin and @LaPulgaaa!


Fix example call to Compress.init_app

Should be "Compress". Also, converted tabs to spaces to conform to rest of doc

Fixed in prior PR. Also compress call was correct.

You sending this pull request made me realize there was two outstanding requests. So thank you!
I merged in the issue with tab/spaces issue.


Add ar rest reviews

added restaurants reviews in Arabic for sentiment analysis tasks

Copy-pasted from the Slack discussion:
the annotation and language creators should be found , not unknown
the example should go under the "Data Instances" paragraph, not "Data fields"
can you remove the abstract from the citation and add it to the dataset description? More people will see that

@yjernite done! thanks for the feedback

@lhoestq not sure why it's failing tests now, I only changed cosmetics

You can ignores these errors

=========================== short test summary info ===========================
FAILED tests/test_dataset_common.py::LocalDatasetTest::test_load_dataset_ajgt_twitter_ar
FAILED tests/test_dataset_common.py::LocalDatasetTest::test_load_dataset_chr_en
FAILED tests/test_dataset_common.py::RemoteDatasetTest::test_load_dataset_ajgt_twitter_ar
FAILED tests/test_dataset_common.py::RemoteDatasetTest::test_load_dataset_chr_en
FAILED tests/test_dataset_common.py::RemoteDatasetTest::test_load_dataset_great_code

they're fixed on master

Feel free to ping me for the final review once you managed to change to ClassLabel :)

Hey @lhoestq I was able to fix it !!

Nice thanks :)
I left a few comments.
Also it looks like in this PR there are files about the opus_sardware dataset in this PR, can you remove them ? We're doing one PR = one dataset

Hey, just FYI I didn't add any files under opus_sardware nor change any. I will remove the folder

@lhoestq done! thanks for your review

merging since the CI is fixed on master


Update for 8u382, 11.0.20, 17.0.8, 20.0.2

Update for latest Corretto releases

This missed updating atleast the 8/jdk/al2-generic. let me investigate.

also also 8/jre/al2/Dockerfile is missing the update


⚠ Jenkins Plugins Artifactory has degraded performance

In f4425f7, Jenkins Plugins Artifactory (https://get.jenkins.io/plugins/artifactory/) experienced degraded performance:

HTTP code: 200
Response time: 1201 ms

Resolved: Jenkins Plugins Artifactory performance has improved in 79a8399 after 51 minutes.


Bug in lexer's read_jsx_child function

Sorry not to be more specific in the issue description, but I don't really understand what I'm looking at, except to know it doesn't look right.
From read_jsx_child:
https://github.com/oxc-project/oxc/blob/a36813405b386815c1b4076885a0df07e605a6d9/crates/oxc_parser/src/lexer/mod.rs#L955-L971
I can see 3 problems here:

push_matching() is called with the 1st char twice.
push_matching() is a no-op as force_allocation_without_current_ascii_char() is never called.
builder is discarded without using it anyway.

I'm unclear whether the problem is that there's some code missing to handle escapes, or whether all it needs to do is consume the JSX Text, so builder serves no purpose and can be removed.
I'm further confused because the comment here doesn't match the code it accompanies. Are the characters in question > and } (as in the comment) or < and { (as in the code)?
https://github.com/oxc-project/oxc/blob/a36813405b386815c1b4076885a0df07e605a6d9/crates/oxc_parser/src/lexer/mod.rs#L959-L963

I removed the string builder in https://github.com/oxc-project/oxc/pull/2096, it felt like I thought I had to store the escaped jsx string, but realized it's not needed but I forgot to remove the code.

Here's the git history before open sourcing:
-                    if matches!(self.peek(), '{' | '<' | '>' | '}') {
+                    // `>` and `}` are errors in TypeScript but not Babel
+                    // let's make this less strict so we can parse more code
+                    if matches!(self.peek(), '{' | '<') {

Here's one of the test that shows up if you revert the change:
+  × Unexpected token
+    ╭─[conformance/jsx/jsxEsprimaFbTestSuite.tsx:40:1]
+ 40 │
+ 41 │ <LeftRight left=<a /> right=<b>monkeys /> gorillas</b> />;
+    ·                                         ─
+ 42 │
+    ╰────
+

This test passes in babel but fails in TypeScript.

I'll improve the comment.

Thank you. All makes sense now!


move node tree to bottom

Moved the node switching tree to the bottom right.
Next thing should be to make update rates from screenio.py dynamic.

I noticed that these values in screenio.py seem to work ok.
# Update rate of simulation info messages [Hz]
siminfo_rate = 0.5

# Update rate of aircraft update messages [Hz]
acupdate_rate = 0.5

Also at some point the variables watched by the tui should be optimized.


attach="body" need fixed position

Is your feature request related to a problem? Please describe.
I want to attach the modal to the body element, so I add attach="body". The problem is modal overlay is not fit to page, there is a gap on the left, because it use absolute position
Describe the solution you'd like
so the solution, when we add attach="body", use class 'vfm--fixed' instead. Because attach to body is different with attach to other element, it is like 'put this modal to the whole page'.
https://github.com/vue-final/vue-final-modal/blob/65edad5d39410a8b8e6fa5a9cc53142cc4de09f0/lib/VueFinalModal.vue#L7
Additional context

sandbox:
https://codesandbox.io/s/mystifying-sutherland-n1l0q?file=/src/App.vue
sorry for my bad English and thanks for your hardwork in this project..

@sinau123
I thought you can reset the default style in body with reset.css or normalize.css.
The gap is actually the default margin in body element.

Checkout the example: https://codesandbox.io/s/fancy-violet-rxcc8
body {
  position: relative;
  margin: 0;
}

You can re-open this issue if your problem is not resolved


Update travis-deploy to support multiple develop branches

pre-work for the upcoming develop-1.2.0 branch

@sebady fyi


[8.x] Use user provided url in AwsTemporaryUrl method

The getAwsUrl method allows overriding the base domain by a custom value set in the config, which is particulary useful for the Digital Ocean Spaces CDN. With this CDN, you can access files via a provided CDN endpoint or even use a custom subdomain; with the custom url option this can be easily setup in Laravel config.
However, the getAwsTemporaryUrl does not do the same things, hence only publicly visible files can profit from this. In this PR, the same behavior is added to this method.
I am not sure wether this is considered a breaking change; currently the behavior seems inconsistent and if your getAwsUrl is working with a custom set config url, I think nothing should break.

Were you able to test this with an actual DigitalOcean Spaces account? I thought the HMAC signature in the URL contained the signature of the entire URL - so changing the base portion of the URL seems like it would break that signature?

You seem to be right about the URL somehow being incorporated into the signature; if I generate a temporary URL through the DO Spaces UI it generates both a "path-style" and "virtual-hosted" style file url, which have different signatures.
However, the second one allows replacing the base domain with either the DO CDN domain or even my custom subdomain, so somehow they seem to allow for that on their side.
All URL patterns working with same signature:
https://.ams3.digitaloceanspaces.com/<file&signature>
https://.ams3.cdn.digitaloceanspaces.com/<file&signature>
https:///<file&signature>
Path-style URL which has a different signature
https://ams3.digitaloceanspaces.com//<file&different signature>

Note: I found Digital Ocean advertises this method in their documentation:

You can use presigned URLs with the Spaces CDN. To do so, configure your SDK or S3 tool to use the non-CDN endpoint, generate a presigned URL for a GetObject request, then modify the hostname in the URL to be the CDN hostname (<space-name>.<region>.cdn.digitaloceanspaces.com, unless the Space uses a custom hostname).

But this does raise the question wether or not this will work for other providers.

I believe this change has broken my implementation in production, so I've rolled back to Laravel 8.31.0.
I'm using AWS S3 and my configuration includes a url so that my public content is stored my subdomain instead of a bucket URL. Previously generating a link to a file directly would use my custom url, but generating a temporary link would use {$bucket}.s3.ap-southest-2.amazonaws.com/*.
Now, the generated link is using my custom URL and resulting in a SignatureDoesNotMatch error being returned from AWS - the referenced file cannot be downloaded (omitted some details from the screenshot):

My assumption is that AWS's presigned URL includes the host in the signing, so swapping the host out breaks the signature. Alternatively the custom host may need to be passed into the presign request (if that's an option?).

Ping @jnoordsij

@dwightwatson are you rolling your own custom implementation or are you just using Laravel's base implementation? If you look at @jnoordsij's examples then this should cover subdomains?

@dwightwatson can you tell a little more about your setup? Is your subdomain just something that has a CNAME to the bucket (similar to custom subdomains DO Spaces) and if yes, can you point me to the Amazon docs how you set this up?
If you store public content on another filesystem, you might be better off using two different drivers instead of overriding parts of the s3 adapter.

Using Laravel's base code, nothing on top.
I'm using a subdomain of my main app. Looking at it now in Route 53 I realise it's actually aliased to a CloudFront CDN in front of the bucket, not aliased to the bucket itself. This was so anything served publicly would be cached. Reading above it doesn't sound like this should matter though - if the signature is the same regardless of the host?
Previously this worked both technically, but also because the temporary URL pointed directly to S3 and not through my subdomain I had confidence it wasn't being cached by my CDN (because this is private content that I only want available on-demand).

I appreciate the intention of the PR, but find it odd that it broke the way it did.

Reading through it - if the signature is only covering the host it really shouldn't have made a difference here (regardless of the exact set up of my subdomain). I was under the same assumption as Taylor above that the signature covers the entire URL. I wonder if this is a subtle difference between AWS's and DO's signing methods?

This broke my production site as well. I have had to update my env file and comment out AWS_URL to fix the issue.
I have an Attachment.php model and use this to generate a redirect url
return Storage::temporaryUrl($this->file_name, now()->addMinutes(5), [
            'ResponseContentType' => $this->original_mime_type,
            'ResponseContentDisposition' => 'attachment; filename="' . utf8_encode($this->original_name) . '"',
        ]);

My generated url was {subdomain}/{bucketname}/{path}, it is now {awsdomain}/{bucketname}/{path}

The more I look into this I think this change is incompatible with AWS S3 - it's presigned URL expects to be the AWS URL. This should probably be removed from the S3 driver and moved to a DO driver or the end-user's app as needed.

Hmmm I fear then that actually the host is (or rather should be) used in signing for AWS S3, and swapping the host afterwards should break things. But DO probably has something in their backend replacing the actual host (wether it is the normal endpoint, default cdn or custom subdomain) with the default endpoint.
If I try presigning the url for DO with the actual host I'm using (the custom subdomain), the generated URL doesn't actually work. I think the best course of action would be changing the config key used for replacing host in temporary URLs, so that by default it doesn't override existing setups.


Tidied up pod documentation for sub frequency.

Hi @rehsack
During the live session with Lance Wicks doing the weekly challenge, we found out the documentation for sub frequency was not very explicit as far as example in the doc.
https://www.youtube.com/watch?v=uM0TTQZaZ2Q
In this PR, I propose a verbose example usage of sub frequency.
Please review the PR when you get time.
I don't expect you to push a new release just for this but I would appreciate if you could please accept and merge the PR.
Many Thanks.
Best Regards,
Mohammad

While I appreciate an improved example, all other given examples a way more compact.
An example with some strings and not only numbers is likely preferred, either.


Add a demo of a cut-down homepage type of landing-page

⚠ This repo is Continuously Deployed: make sure you follow the guidance ⚠
What
Build a demo page for a cut-down homepage variant of a landing page type to demo a potential arrangement of blocks. Uses dummy content.
Why
Trello card
How
Renamed the original demo to preserve it before removing the navigation and chart blocks.
Screenshots

No longer needed.


Add Service[Offering|Instance]Node tables and model

point 6 from https://github.com/RedHatInsights/topological_inventory-core/issues/168
cc @slemrmartin

@miq-bot assign @slemrmartin


Batch delete does not work for keyless tables

Description
This request is similar to #557.
For keyless entities it is not possible to do a DeleteFromQuery. Once you have a keyless entity with .HasNoKey() and you attempt to delete it via query you will run into an exception.
await context.KeyLess.Where(k => k.CreationTime < threshold).DeleteFromQueryAsync();

I assume the default generation of SQL is something like
DELETE FROM {table} WHERE PK in (SELECT PK FROM <query>)

and therefore a PK is needed. Makes sense, but for simple queries like above not really a PK is needed and it would be great if it can be supported. I would be fine with having a await context.KeyLess.DeleteByConditionAsync(k=>k.CreationTime < threshold) to avoid potential unexpected side effects.
Exception
Exception message: Oops! No key has been found. A keyless entity is not supported.

Stack trace:
   at Z.EntityFramework.Extensions.BatchDelete.Execute[T](IQueryable`1 query)
   at BatchDeleteExtensions.DeleteFromQuery[T](IQueryable`1 query, Action`1 batchDeleteBuilder)
   at BatchDeleteExtensions.?`1.?()
   at System.Threading.Tasks.Task`1.InnerInvoke()
   at System.Threading.Tasks.Task.Execute()
--- End of stack trace from previous location where exception was thrown ---

Fiddle or Project
Unfortunately DotNetFiddle is blocked by our IT but here a gist reproducing the issue.
https://gist.github.com/Danielku15/8c3ddc0edd0dd39046650544e9e3a9ce
Further technical details

EF version: 3.1.6
EF Plus version: 3.0.63
Database Provider: SQL Server

Hello @Danielku15 ,
Unfortunately, nothing will be done in the short term.
However, when we will re-write that feature to allows the query directly to be executed without requiring the primary key (so the condition directly is done on the table), we will for sure look at it.
Best Regards,
Jon

Performance Libraries
context.BulkInsert(list, options => options.BatchSize = 1000);
Entity Framework Extensions • Entity Framework Classic • Bulk Operations •  Dapper Plus
Runtime Evaluation
Eval.Execute("x + y", new {x = 1, y = 2}); // return 3
C# Eval Function • SQL Eval Function

Hmm...
Have the same issue right now with UpdateAsync().
Is there a solution right now?

Hello @kevinvenclovas ,
Unfortunately, there is no solution right now.
We hope one day to get enough time to do a request like this one but time is always missing ;(


Pagination

Hello
I am responding to this post https://github.com/toranb/ember-data-django-rest-adapter/issues/58
Did you make any progress on this issue? I think we really need a pagination for production usage of Django REST Adapter + Ember.
I tried to look into code by myself, but i don't think i have enough knowledge of Ember to implement it, yet.
Thank you for answer.
Gary

So, was this fixed on the new ember-cli addon?

We're still working on it.
https://github.com/dustinfarris/ember-django-adapter/pull/45


Unwanted Code ?

Is there a reason why Interpolator.LINEAR is mentioned in multiple places like JFXSpinner, JFXRippler etc. ?
The default Interpolator of  KeyFrame is Interpolator.LINEAR. If there isn't a reason for its existence, we can remove the noise from the code. I will be more than happy to raise a PR.

It's fine, I'd rather keep it in code in case the default interpolator has been changed.
Regards,


Added the dependencies key since it's now needed with SPM

This is related to this issue #1544   I'm using swift for Ubuntu with Perfect.org

@cyberdude This looks fine. Is there someplace where changes like this are tracked? I'm not seeing anything in the SPM docs about it being required now.


Fix singular associations

Correctly spoof singular associations.

Should not return an array of one element, just the element.
Added relevant tests.

:+1: Looks good to me.


feat: Add support for NG2+

@brianpkelley Hey, I was thinking into porting this library into NG2+, since I've need it several times and the available libraries are not as good as this one.
That is OK?
The license is MIT and is abandoned since 2016, so I think that this is not an issue, but wanted to ask anyways.


cmd/go: flow for easy upstream contributions

We often find ourselves using an upstream package which does most of what we need but not quite, so we decide to add a new feature to it and contribute the code upstream.
Before we can write any code we need to do some boring work:
• copy package path
• open browser
• paste URL
• fork package
• copy forked path
• go get fork path
• open go.mod
• add replace package path with canonical fork path
• now we can start editing
Would be nice to know if anyone found a smoother approach to easily contribute to upstream packages used in their codebase.

I don't think opening the browser, pasting a URL and pressing the fork button needs to be split into separate bullet points. Those are minuscule tasks. The real task is to edit the go.mod. You don't need to open go.mod and add the replace path manually. Just use go mod edit -replace=old=new for that.
The set of tasks basically are -

fork the package
go mod edit -replace=old=new
Start building. (The updated go.mod will automatically fetch the new package)

To update your package, you need to git clone it obviously, but that is a separate workflow.
If/when your patch has been accepted upstream, just use go mod edit -dropreplace. I think this is smooth and simple. If you have any specific suggestions to improve this further, please feel free to open separate issues for those.
cc @bcmills @jayconrod in case I have missed something.

Thank you very much @agnivade, the go mod edit -replace=old=new / go mod edit -dropreplace workflow is  perfect.


Revert CI Update

Something broke our benchmarking scripts, and I think it was this. If this solves the problem, I will merge.

I have no idea why this is happening. Also cannot reproduce locally.

Closing as this doesn't solve the problem.


Suggestion: Character Development (2-Page Sheet Modification)

Hey. I love your App, it's very useful.
However, it only works with creating new characters or ships. I know you can modify the sheet manually after creation if you have Character Development, but on the two-page TNG Character Sheet, the second page only shows the information on the original Talents you selected.
Could you add a function to your app to allow someone to load in an existing sheet and make adjustments to the Talents so that the new Talents show up on that second page instead of the old ones? Or at least make that section form-fillable like the rest of the sheet?

There was some  conversation on the Modiphius forums about supporting character development. Those ideas are referenced in #33.
I think that extracting the data from a previously-created PDF is pretty hard. But let me keep it in the back of my mind.

I wonder if perhaps a temporary workaround would be an editable blank character sheet? So rather than going through the creator, a user can just pull up a blank sheet and pop in whatever stats and talents they have, and then modify them. That sheet could then be transferred from entry-UI to pdf. It would be missing a lot of the creation process in the data, but would perhaps be a way to get a character development change on a new sheet in the same format.

My main issue is the ability to change the Role, Talents, and Flavor/Mechanical text on page 2 of a two-page sheet.
If those segments were form-fillable, it would be as helpful as if they could be changed in the app.


DocsArchive-<IP_ADDRESS>Auto archive content

Auto archive content from https://github.com/VSC-Service-Account/docs-archive-test-source.git

Docs Build status updates of commit a3a13b9:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error-RepositoryUnauthorizedWithSourceCommit] Git data access to 'https://github.com/VSC-Service-Account/docs-archive-test-target' (branch: Release_Archive_master_2020-06-01-01-56-16) is not authorized.. It looks like this might be the first time you’ve submitted a pull request to this repo. Before you can run builds in a pull request, you have to enable your GitHub account in Docs by visiting https://opportal-sandbox.azurewebsites.net. After you enable your account, close and then reopen this pull request to start another build.

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


[Bare Metal] Workload cluster scale out CLI validations fails with generated ssh keys

What happened:
I have a running workload cluster with 1 node in total. 1 control plane. When I create this cluster i did not define an SSH public key. As such, EKS Anywhere created one for me. When scaling up this workload cluster from 1 control plane node to 1 control plane by adding the following to the cluster yaml for the workload the eksctl anywhere cluster upgrade command fails.
The following was added to my successful 1 node cluster cluster.yaml:
workerNodeGroupConfigurations:
  - count: 1
    machineGroupRef:
      kind: TinkerbellMachineConfig
      name: workload-test-worker
    name: md-0

AND
apiVersion: anywhere.eks.amazonaws.com/v1alpha1
kind: TinkerbellMachineConfig
metadata:
  name: workload-test-worker
spec:
  hardwareSelector:
    type: worker-wl
  osFamily: ubuntu
  templateRef: {}
  users:
  - name: ec2-user

I get the following error:
V0	❌ Validation failed	{"validation": "SSH Keys present", "error": "[workload-test-cp TinkerbellMachineConfig is invalid: it should contain at least one SSH key, workload-test-worker TinkerbellMachineConfig is invalid: it should contain at least one SSH key]", "remediation": "Please include at least one SSH key per machine config. If your keys were autogenerated during the create cluster operation, make sure you include them in your cluster config for all lifecycle operations"}
.
.
.
V0	❌ Validation failed	{"validation": "validate immutable fields", "error": "spec.Users[0].SshAuthorizedKeys[0] is immutable. Previous value ssh-rsa ... ,   New value ssh-rsa ... ", "remediation": ""}

What you expected to happen:
Once an SSH public key has been provided to a cluster, either by the user or auto-generated by EKSA, the CLI should not require me to provide them. The cluster already has them/knows about them. Just use them.
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?:
Environment:

EKS Anywhere Release: cli version v0.19.2
EKS Distro Release:

Synced up with author of the issue (Jacob) and confirmed that these validations are valid and it is working as expected. It is required to provide ssh keys in the upgrade cluster case.


Teams App SSO and SharePoint SSO

I created Teams  Tab App that configured SSO as below Microsoft documentations and App work as expected
tab-sso-register-aad
tab-sso-manifest
now I need to redirect user to their SharePoint site URL using teamslogon.aspx .
https://{tenant}.sharepoint.com/_layouts/15/teamslogon.aspx?spfx=true&dest=/sites/{mysite}
but according to the current Teams app manifest webApplicationInfo settings,  SharePoint redirection is not working.  It gives following error while redirecting to the SharePoint site

is there possible configuration/way to solve this SharePoint authentication issue ?
some  manifest data
{
...
...

   "staticTabs": [
       {
           "entityId": "d1117518-2222-1111-bbbb-56c7eaaaaaaa",
           "name": "Home",
           "contentUrl": "https://my-teams-app-my.azurewebsites.net/Tabs/Tab?loginHint={loginHint}&userObjectId={userObjectId}&userPrincipalName={userPrincipalName}&tenantId={tid}&locale={locale}&theme={theme}&userPrincipalName={userPrincipalName}",
           "scopes": [
               "personal"
           ]
       }
   ],
   "permissions": [
       "identity",
       "messageTeamMembers"
   ],
   "validDomains": [
       "{teamSiteDomain}",
       "my-teams-app-my.azurewebsites.net",
       "*.login.microsoftonline.com",
       "*.sharepoint.com",
       "resourceseng.blob.core.windows.net"
   ],
   "webApplicationInfo": {
       "resource": "api://my-teams-app-my.azurewebsites.net/123d3381-5e04-1234-1234-12350bef0123",
       "id": "123d3381-5e04-1234-1234-12350bef0123"
   },
   "isFullScreen": true
}

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 39428da3-d8be-43eb-80df-2b1f26ef6524
Version Independent ID: 39428da3-d8be-43eb-80df-2b1f26ef6524
Content: Update manifest for enabling SSO for tabs - Teams
Content Source: msteams-platform/tabs/how-to/authentication/tab-sso-manifest.md
Service: msteams
GitHub Login: @surbhigupta
Microsoft Alias: lajanuar

@asith-w - Please verify the contents of webApplicationInfo section:
"webApplicationInfo": {
    "id": "{AAD App client id}",
    "resource": "api://{Your tab app domain}/{AAD App client id}"
  }

Please make sure the domain in webApplicationInfo is same as your tab app's domain, otherwise Teams will return error.

@Nivedipa-MSFT  It is same. as in above manifest , staticTabs.contentUrl and _webApplicationInfo.resource domain are same.

@ChetanSharma-msft here is manifest( some urls & names are changed to avoid real names)
{
    "$schema": "https://developer.microsoft.com/en-us/json-schemas/teams/v1.8/MicrosoftTeams.schema.json",
    "manifestVersion": "1.8",
    "version": "1.0.0",
    "id": "52fdc0ca-8aa9-4522-a17e-8725fe614aba",
    "packageName": "APP_NAME",
    "developer": {
        "name": "COMPANY_NAME GmbH",
        "websiteUrl": "https://www.COMPANY_NAME.com",
        "privacyUrl": "https://www.COMPANY_NAME.com/privacy-policy-services",
        "termsOfUseUrl": "https://www.COMPANY_NAME.com/terms-and-conditions-services",
        "mpnId": ""
    },
    "icons": {
        "color": "color.png",
        "outline": "outline.png"
    },
    "name": {
        "short": "APP_NAME",
        "full": "APP_NAME by COMPANY_NAME"
    },
    "description": {
        "short": "APP_NAME - description",
        "full": "APP_NAME - full description."
    },
    "accentColor": "#d03808",
    "configurableTabs": [
        {
            "configurationUrl": "https://my-teams-app-my.azurewebsites.net/TeamTabs/TabConfiguration?loginHint={loginHint}&userObjectId={userObjectId}&userPrincipalName={userPrincipalName}&tenantId={tid}&locale={locale}&theme={theme}&userPrincipalName={userPrincipalName}",
            "canUpdateConfiguration": false,
            "scopes": [
                "team"
            ]
        }
    ],
    "staticTabs": [
        {
            "entityId": "d12c7518-3b2a-4a1f-a39b-56c7edad4a3a",
            "name": "Home",
            "contentUrl": "https://my-teams-app-my.azurewebsites.net/StaticTabs/MainTab?loginHint={loginHint}&userObjectId={userObjectId}&userPrincipalName={userPrincipalName}&tenantId={tid}&locale={locale}&theme={theme}&userPrincipalName={userPrincipalName}",
            "scopes": [
                "personal"
            ]
        }
    ],
    "permissions": [
        "identity",
        "messageTeamMembers"
    ],
    "validDomains": [
	    "{teamSiteDomain}",
        "my-teams-app-my.azurewebsites.net",
        "*.login.microsoftonline.com",
        "*.sharepoint.com",
        "*.sharepoint-df.com",
        "spoppe-a.akamaihd.net",
        "spoprod-a.akamaihd.net",
        "resourceseng.blob.core.windows.net",
        "msft.spoppe.com"
    ],
    "webApplicationInfo": {
		"id": "25a08858-151f-477d-8fff-e72c9254ac95",
        "resource": "api://my-teams-app-my.azurewebsites.net/25a08858-151f-477d-8fff-e72c9254ac95"

    },
    "isFullScreen": true
}

@asith-w - We are checking this internally. We will update you soon.

@Nivedipa-MSFT this is  redirection to a SharePoint site from the app as below
 const { hostname, pathname } = new URL(siteUrl);
 const url = `https://${hostname}/_layouts/15/teamslogon.aspx?spfx=true&dest=${pathname}`;
 window.location.assign(url);

URL will be like 'https://{tenant}.sharepoint.com/_layouts/15/teamslogon.aspx?spfx=true&dest=/sites/{mysite}'

@asith-w - We are checking this internally. We will update you soon.

@Nivedipa-MSFT it can be either static or configurable tab,
for example, when this Team tab app is loading, app get valid SharePoint url from a DB for the current user and tenant  based on some logic
after that,  it  redirects to SP site.
Tap page do something similar to below functionality
const siteUrl = getSPSiteUrlForUser( userId, tenantId ) //custom api call
redirectToSharePoint( siteUrl )

@asith-w - Are you displaying Sign In form in that SharePoint URL?

@asith-w - Could you please add the URL in validDomains section which you are getting in siteUrl?
Could you please confirm is this a same tenant sharepoint Url where your app is uploaded?


patch for prov-master homogeneity constraint

Description
A minor patch to let user choose heterogeneous prov+master nodes within a cloud, now prov can be a non-telco class server.
Works for all model except SM 1029U due to different interface name for TRTP and TN10RT types so masters and prov should be the same unless there is a way to differentiate these models based on FQDN.
Type of change
Please select the appropiate options:

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Testing
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[x] Tested in scale lab

Test Configuration:

Versions: OCP 4.7
Hardware: Prov - SM 1029P  and Master 3 Dell FC640

Checklist

[x] I have performed a self-review of my own code
[ ] If a change is adding a feature, it should require a change to the README.md and the review should catch this.
[ ] If the change is a fix, it should have an issue. The review should make sure the comments state the issue (not just the number) and it should use the keywords that will close the issue on merge.
[ ] A change should not being merged unless it passes CI or there is a comment/update saying what testing was passed.
[ ] PRs should not be merged unless positively reviewed.

Need to add masters_prov_nic in set-deployment-facts role.
No, Its coming from inventory file - https://github.com/redhat-performance/JetSki/blob/master/ansible-ipi-install/inventory/jetski/hosts#L125

@smalleni tested in cloud04.
[kni@f04-h20-b04-5039ms ~]$ oc get nodes
NAME              STATUS   ROLES    AGE   VERSION
master-0          Ready    master   61m   v1.19.0+9f84db3
master-1          Ready    master   60m   v1.19.0+9f84db3
master-2          Ready    master   60m   v1.19.0+9f84db3
worker000-fc640   Ready    worker   18m   v1.19.0+9f84db3
worker001-1029u   Ready    worker   22m   v1.19.0+9f84db3
worker002-r640    Ready    worker   18m   v1.19.0+9f84db3


Missing dependency: xml2

Hi, it looks like xml2 needs to be added to Suggests, or alternatively test conditionally on requireNamespace("xml2"). I spotted this while running revdep checks on my matrixStats package.  Here is what I get:
* using log directory ‘/c4/home/henrik/repositories/matrixStats/revdep/checks/Gviz/new/Gviz.Rcheck’
* using R version 4.1.0 (2021-05-18)
* using platform: x86_64-pc-linux-gnu (64-bit)
* using session charset: UTF-8
* using options ‘--no-manual --no-build-vignettes’
* checking for file ‘Gviz/DESCRIPTION’ ... OK
* this is package ‘Gviz’ version ‘1.36.0’
* package encoding: UTF-8
* checking package namespace information ... OK
* checking package dependencies ... OK
* checking if this is a source package ... OK
* checking if there is a namespace ... OK
* checking for executable files ... OK
* checking for hidden files and directories ... OK
* checking for portable file names ... OK
* checking for sufficient/correct file permissions ... OK
* checking whether package ‘Gviz’ can be installed ... OK
* checking installed package size ... NOTE
  installed size is 10.3Mb
  sub-directories of 1Mb or more:
    R         1.7Mb
    doc       4.7Mb
    extdata   2.5Mb
* checking package directory ... OK
* checking ‘build’ directory ... OK
* checking DESCRIPTION meta-information ... OK
* checking top-level files ... OK
* checking for left-over files ... OK
* checking index information ... OK
* checking package subdirectories ... OK
* checking R files for non-ASCII characters ... OK
* checking R files for syntax errors ... OK
* checking whether the package can be loaded ... OK
* checking whether the package can be loaded with stated dependencies ... OK
* checking whether the package can be unloaded cleanly ... OK
* checking whether the namespace can be loaded with stated dependencies ... OK
* checking whether the namespace can be unloaded cleanly ... OK
* checking loading without being on the library search path ... OK
* checking dependencies in R code ... OK
* checking S3 generic/method consistency ... OK
* checking replacement functions ... OK
* checking foreign function calls ... OK
* checking R code for possible problems ... OK
* checking Rd metadata ... OK
* checking Rd cross-references ... OK
* checking for missing documentation entries ... OK
* checking for code/documentation mismatches ... OK
* checking Rd \usage sections ... OK
* checking Rd contents ... OK
* checking for unstated dependencies in examples ... OK
* checking contents of ‘data’ directory ... OK
* checking data for non-ASCII characters ... OK
* checking data for ASCII and uncompressed saves ... OK
* checking installed files from ‘inst/doc’ ... OK
* checking examples ... OK
* checking for unstated dependencies in ‘tests’ ... OK
* checking tests ... ERROR
  Running ‘testthat.R’
Running the tests in ‘tests/testthat.R’ failed.
Last 50 lines of output:
  Attaching package: 'S4Vectors'

  The following objects are masked from 'package:base':

      I, expand.grid, unname

  Loading required package: IRanges
  Loading required package: GenomicRanges
  Loading required package: GenomeInfoDb
  Loading required package: grid
  >
  > test_check("Gviz")
  Loading required package: BSgenome
  Loading required package: Biostrings
  Loading required package: XVector

  Attaching package: 'Biostrings'

  The following object is masked from 'package:grid':
      pattern

  The following object is masked from 'package:base':

      strsplit

  Loading required package: rtracklayer
  ══ Failed tests ════════════════════════════════════════════════════════════════
  ── Error (test_AllClasses.R:168:5): interaction with biomart works ─────────────
  Error: Please install xml2 package
  Backtrace:
       █
    1. └─Gviz::BiomartGeneRegionTrack(...) test_AllClasses.R:168:4
    2.   └─methods::new(...)
    3.     ├─methods::initialize(value, ...)
    4.     └─Gviz::initialize(value, ...)
    5.       └─Gviz:::.local(.Object, ...)
    6.         └─Gviz:::.cacheMartData(.Object, chromosome, staged)
    7.           └─Gviz:::.fetchBMData(bmtrack, chromosome, staged)
    8.             └─biomaRt::getBM(...)
    9.               └─biomaRt:::.createHash(...)
   10.                 └─biomaRt::listEnsemblArchives()
   11.                   └─biomaRt:::.listEnsemblArchives(https = https, httr_config = list())
   12.                     ├─XML::htmlParse(content(html))
   13.                     └─httr::content(html)
   14.                       └─httr:::parse_auto(raw, type, encoding, ...)
   15.                         └─httr:::parser(...)
   16.                           └─httr:::need_package("xml2")

  [ FAIL 1 | WARN 0 | SKIP 0 | PASS 293 ]
  Error: Test failures
  Execution halted
* checking for unstated dependencies in vignettes ... OK
* checking package vignettes in ‘inst/doc’ ... OK
* checking running R code from vignettes ... NONE
  ‘Gviz.Rmd’ using ‘UTF-8’... OK
* checking re-building of vignette outputs ... SKIPPED
* DONE
Status: 1 ERROR, 1 NOTE

Hi @HenrikBengtsson,
Thank you for your suggestion, I have added xml2 to suggested packages in both release and devel version.
Best, Robert


simple script with yolact : size mismatch issues

Hi,
I am trying to write a simple script using YOLACT, loading the weights gives me a bunch of issues
from models.yolact.yolact import Yolact
import torch
from models.yolact.utils.augmentations import BaseTransform, FastBaseTransform, Resize
import cv2
from models.yolact.data.config import set_cfg

net = Yolact()
model_path = '/yolact_plus_base_54_800000.pth'
config = 'yolact_plus_base'+ '_config'
set_cfg(config)
torch.set_default_tensor_type('torch.cuda.FloatTensor')

net.load_weights(model_path)
net.eval()

image = "/home/huynhanh/ros_ws/src/halodi_segmentation/images/person_bike.jpg"

net = net.cuda()

frame = torch.from_numpy(cv2.imread(image)).cuda().float()
batch = FastBaseTransform()(frame.unsqueeze(0))
preds = net(batch)

# img_numpy = prep_display(preds, frame, None, None, undo_transform=False)

# if save_path is None:
#     img_numpy = img_numpy[:, :, (2, 1, 0)]
# cv2.imwrite(save_path, img_numpy)

Error(s) in loading state_dict for Yolact:
	Unexpected key(s) in state_dict: "maskiou_net.maskiou_net.0.weight", "maskiou_net.maskiou_net.0.bias", "maskiou_net.maskiou_net.2.weight", "maskiou_net.maskiou_net.2.bias", "maskiou_net.maskiou_net.4.weight", "maskiou_net.maskiou_net.4.bias", "maskiou_net.maskiou_net.6.weight", "maskiou_net.maskiou_net.6.bias", "maskiou_net.maskiou_net.8.weight", "maskiou_net.maskiou_net.8.bias", "maskiou_net.maskiou_net.10.weight", "maskiou_net.maskiou_net.10.bias", "backbone.layers.1.0.conv2.bias", "backbone.layers.1.0.conv2.conv_offset_mask.weight", "backbone.layers.1.0.conv2.conv_offset_mask.bias", "backbone.layers.1.3.conv2.bias", "backbone.layers.1.3.conv2.conv_offset_mask.weight", "backbone.layers.1.3.conv2.conv_offset_mask.bias", "backbone.layers.2.0.conv2.bias", "backbone.layers.2.0.conv2.conv_offset_mask.weight", "backbone.layers.2.0.conv2.conv_offset_mask.bias", "backbone.layers.2.3.conv2.bias", "backbone.layers.2.3.conv2.conv_offset_mask.weight", "backbone.layers.2.3.conv2.conv_offset_mask.bias", "backbone.layers.2.6.conv2.bias", "backbone.layers.2.6.conv2.conv_offset_mask.weight", "backbone.layers.2.6.conv2.conv_offset_mask.bias", "backbone.layers.2.9.conv2.bias", "backbone.layers.2.9.conv2.conv_offset_mask.weight", "backbone.layers.2.9.conv2.conv_offset_mask.bias", "backbone.layers.2.12.conv2.bias", "backbone.layers.2.12.conv2.conv_offset_mask.weight", "backbone.layers.2.12.conv2.conv_offset_mask.bias", "backbone.layers.2.15.conv2.bias", "backbone.layers.2.15.conv2.conv_offset_mask.weight", "backbone.layers.2.15.conv2.conv_offset_mask.bias", "backbone.layers.2.18.conv2.bias", "backbone.layers.2.18.conv2.conv_offset_mask.weight", "backbone.layers.2.18.conv2.conv_offset_mask.bias", "backbone.layers.2.21.conv2.bias", "backbone.layers.2.21.conv2.conv_offset_mask.weight", "backbone.layers.2.21.conv2.conv_offset_mask.bias", "backbone.layers.3.0.conv2.bias", "backbone.layers.3.0.conv2.conv_offset_mask.weight", "backbone.layers.3.0.conv2.conv_offset_mask.bias".
	size mismatch for prediction_layers.0.bbox_layer.weight: copying a param with shape torch.Size([36, 256, 3, 3]) from checkpoint, the shape in current model is torch.Size([12, 256, 3, 3]).
	size mismatch for prediction_layers.0.bbox_layer.bias: copying a param with shape torch.Size([36]) from checkpoint, the shape in current model is torch.Size([12]).
	size mismatch for prediction_layers.0.conf_layer.weight: copying a param with shape torch.Size([729, 256, 3, 3]) from checkpoint, the shape in current model is torch.Size([243, 256, 3, 3]).
	size mismatch for prediction_layers.0.conf_layer.bias: copying a param with shape torch.Size([729]) from checkpoint, the shape in current model is torch.Size([243]).
	size mismatch for prediction_layers.0.mask_layer.weight: copying a param with shape torch.Size([288, 256, 3, 3]) from checkpoint, the shape in current model is torch.Size([96, 256, 3, 3]).
	size mismatch for prediction_layers.0.mask_layer.bias: copying a param with shape torch.Size([288]) from checkpoint, the shape in current model is torch.Size([96])

This must be caused by something with setting up the config,
Can someone explain or show me how to set it up properly ?
thank you

i have the same problem, do you have solved it?


Failed to login to Google Account.

While trying to log in to google account, it fails to log in with an error for unsupported/not secured browser.

Added a change in 1.2.0 . See if it fixes this issue for you.

Still doesn't work. If you use Discord, add me
Error#0003

Same issue as of today

please tell how to fix

I have a potential solution, Have the login Page either report to google as an IOS device or the latest version of Google chrome.

I have a potential solution, Have the login Page either report to google as an IOS device or the latest version of Google chrome.


could not be complied. Try Rebuilding from Source manually

I'm using plugin version: UnrealEnginePython_20190508_4_22_python36_embedded_win64
Unreal Engine: 4.21.1
I'm getting the following error when I add the plugin to the project directories:
Log file open, 05/22/19 17:03:16
LogWindows: Failed to load 'aqProf.dll' (GetLastError=126)
LogWindows: File 'aqProf.dll' does not exist
LogWindows: Failed to load 'VtuneApi.dll' (GetLastError=126)
LogWindows: File 'VtuneApi.dll' does not exist
LogWindows: Failed to load 'VtuneApi32e.dll' (GetLastError=126)
LogWindows: File 'VtuneApi32e.dll' does not exist
LogConsoleResponse: Display: Failed to find resolution value strings in scalability ini. Falling back to default.
LogInit: Display: Running engine for game: Project
LogPakFile: Registered encryption key '00000000000000000000000000000000': 0 pak files mounted, 0 remain pending
LogPlatformFile: Not using cached read wrapper
LogTaskGraph: Started task graph with 5 named threads and 23 total threads with 3 sets of task threads.

LogInit: Warning: Incompatible or missing module: UnrealEnginePython
LogInit: Warning: Incompatible or missing module: PythonAutomation
LogInit: Warning: Incompatible or missing module: PythonConsole
LogInit: Warning: Incompatible or missing module: PythonEditor
Running C:/Program Files/Epic Games/UE_4.21/Engine/Binaries/DotNET/UnrealBuildTool.exe Development Win64 -Project="F:/Unreal_Projects/Project/Project.uproject" -TargetType=Editor -Progress -NoHotReloadFromIDE
Creating makefile for StudioEditor (no existing makefile)
Performing full C++ include scan (no include cache file)
Using Visual Studio 2017 14.16.27023 toolchain (C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.16.27023) and Windows 10.0.16299.0 SDK (C:\Program Files (x86)\Windows Kits\10).
@progress push 5%
Parsing headers for StudioEditor
Running UnrealHeaderTool "F:\Unreal_Projects\Project\Project.uproject" "F:\Unreal_Projects\Project\Intermediate\Build\Win64\StudioEditor\Development\StudioEditor.uhtmanifest" -LogCmds="loginit warning, logexit warning, logdatabase error" -Unattended -WarningsAsErrors -installed
Reflection code generated for StudioEditor in 8.8026826 seconds
@progress pop
Writing dependency list to F:\Unreal_Projects\Project\Intermediate\DependencyLists\StudioEditor\Development\Win64\DependencyList.txt
No buildable actions for this target. Makefile will not be saved.
Target is up to date
Total build time: 17.12 seconds (NoActionsToExecute executor: 0.00 seconds)
LogInit: Warning: Still incompatible or missing module: UnrealEnginePython
LogInit: Warning: Still incompatible or missing module: PythonAutomation
LogInit: Warning: Still incompatible or missing module: PythonConsole
LogInit: Warning: Still incompatible or missing module: PythonEditor
LogExit: Preparing to exit.

Log file closed, 05/22/19 17:05:06

this plugin fork has a few changes which may make incompatible with parent fork releases, I recommend you use https://github.com/getnamo/UnrealEnginePython/releases/tag/1.8.0

That worked!  Thank you and thank you for this plug in!!!


[PE-D][Tester C] Some info in the developer guide is yet to be updated.

Some info in the developer guide is yet to be updated.

Labels: severity.VeryLow type.DocumentationBug
original: arnav-goel10/ped#6

Honestly can just remove this section if no time to do lol

Honestly can just remove this section if no time to do lol

Yes


Import of example trajectory causes app to crash

As found out in https://github.com/sitcomlab/simport-learning-app/issues/156, re-importing the example trajectory causes the app to crash.
Since this is a rather unusual case, I'd say we fix it if it's something small.

I wasn't able to reproduce this error when using the #170 new example trajectory. Don't know if this could be related to the trajectory itself.
When I try to reproduce the same from the develop branch, I don't get the same error, just that after a couple of minutes importing, I simply can't see the Nepal trajectory on the map.


How LNNotificationBannerWindow show?

There isn't method call 'makeKeyAndVisible'

I don't understand what the problem is here. UIWindow has a hidden property, which controls if a window is shown or hidden.