[#4102] Fix BootstrapClassLoader search

Codecov Report

Merging #4103 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #4103      +/-   ##
==========================================
+ Coverage   41.24%   41.26%   +0.01%
==========================================
  Files        2341     2341
  Lines       73804    73806       +2
  Branches     9985     9984       -1
==========================================
+ Hits        30442    30455      +13
+ Misses      40554    40547       -7
+ Partials     2808     2804       -4

Impacted Files
Coverage Δ

...vercorp/pinpoint/common/util/ClassLoaderUtils.java
87.8% <100%> (+10.88%)
:arrow_up:

...vercorp/pinpoint/rpc/packet/ClientClosePacket.java
55.55% <0%> (-11.12%)
:arrow_down:

...tor/metric/datasource/DefaultDataSourceMetric.java
75.75% <0%> (-3.04%)
:arrow_down:

...orp/pinpoint/rpc/server/DefaultPinpointServer.java
80.2% <0%> (-0.35%)
:arrow_down:

...cluster/zookeeper/ZookeeperClusterDataManager.java
65.3% <0%> (+0.68%)
:arrow_up:

...point/rpc/client/DefaultPinpointClientHandler.java
72.34% <0%> (+0.96%)
:arrow_up:

...pinpoint/profiler/monitor/DeadlockMonitorTask.java
19.76% <0%> (+1.16%)
:arrow_up:

...m/navercorp/pinpoint/test/OrderedSpanRecorder.java
74.03% <0%> (+1.92%)
:arrow_up:

...navercorp/pinpoint/rpc/common/SocketStateCode.java
85.36% <0%> (+2.43%)
:arrow_up:

...npoint/rpc/server/SimpleServerMessageListener.java
100% <0%> (+20%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b69117...a29261d. Read the comment docs.


Read [host-os].config.yml if available

Toyed around with an idea and thought I'd post it for feedback or future reference. This would try and load a host os specific config file so that teams could provide a windows.config.yml with
vagrant_synced_folder_default_type: "smb"
vagrant_synced_folders:
  - local_path: .
    destination: /var/www/drupal
    type: smb
    create: true

Very untested.

I'll close this as it's never even been requested and didn't get any reactions since posted.


Add worker harness container scaffolding and worker event loop scaffolding

As mentioned, here's some work I had lying around for the harness code.
I had to fix up the proto crate build on my end, not sure if this was broken on your end? We can drop that commit if's irrelevant.
The container directory adds adds some build scaffolding, a harness boot script and a container build script.
The worker_main file adds a main function (managed by tokio) to use in pipeline execution mode as well as an init function to switch between pipeline construction and pipeline execution modes.
The sdk_worker file has some changes related to finer grained locking, an event loop for BeamFnControl.control and some stubs for the instructions which can be sent to the worker.

Thanks @sjvanrossum!
The proto crate relied on a placeholder build that I was using just to speed things up, but I very recently commited a change that should make it work without requiring any additional setup. Sorry for the confusion, and please let me know if it's still acting up.


Feature/fbp 152 close anchors

Fixes: #152

Codecov Report

Merging #156 into master will increase coverage by 0.13%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #156      +/-   ##
============================================
+ Coverage     62.69%   62.82%   +0.13%
- Complexity      829      832       +3
============================================
  Files            85       85
  Lines          3656     3664       +8
  Branches        677      678       +1
============================================
+ Hits           2292     2302      +10
+ Misses         1120     1118       -2
  Partials        244      244

Flag
Coverage Δ
Complexity Δ

#unittests
62.82% <100.00%> (+0.13%)
832.00 <1.00> (+3.00)

Impacted Files
Coverage Δ
Complexity Δ

...lb3r/bpmn/intellij/plugin/render/AreaWithZindex.kt
100.00% <ø> (ø)
8.00 <0.00> (ø)

...n/kotlin/com/valb3r/bpmn/intellij/plugin/Colors.kt
100.00% <100.00%> (ø)
2.00 <0.00> (ø)

...n/com/valb3r/bpmn/intellij/plugin/render/Canvas.kt
70.51% <100.00%> (+0.59%)
85.00 <0.00> (+2.00)

...tellij/plugin/render/DefaultBpmnProcessRenderer.kt
58.44% <100.00%> (+0.54%)
25.00 <0.00> (ø)

...ntellij/plugin/render/ElementInteractionContext.kt
100.00% <100.00%> (ø)
9.00 <0.00> (ø)

...ender/elements/shapes/AnyShapeNestableIconShape.kt
70.83% <100.00%> (ø)
8.00 <1.00> (ø)

...plugin/render/elements/BaseDiagramRenderElement.kt
89.04% <0.00%> (+2.73%)
40.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3dd3bf8...cd537f2. Read the comment docs.


Pull Tweets of Server

Pull tweet information off server and populate UI
Related #63

Tweets are now being pulled from the server and being pushed to the UI


Visualizations: mosaic 2x2 RxC plots should not expect stats table when facet variable is active and showMissingness==true

Client needs to be aware of this and the io-ts validators should be lenient
See also
https://github.com/VEuPathDB/plot.data/issues/109

@d-callan  - what's the name of the test(s) done for 2x2 and RxC? I think the UI should say what the p-value is from!

While fixing this I took an executive decision to move the statistics table into the tabbed area.  This is that it can handle faceting too (when showMissing is not checked).
It now looks like this, when faceting is active

(note that the width isn't correct, but I didn't want to get into layout issues in this PR)
With showMissing toggle on:

And with no faceting at all:

This is working well in mosaic rxc plot.
However, I am unable to QA this right now in mosaic 2x2 plots because of bugs. Both of these were in GEMS1. Faceting in 2x2 is not working for me. Also, if I toggle compatible variables=ON, the list also shows numeric vars which it should not.

Thank you @nkittur-uga - I got slightly different error messages on my dev instance but there was definitely a bug which is now fixed.  I'd be grateful if you can test again when it is deployed.

Re-tested and it works as expected in 2x2 table. Statistics are not calculated when the "include no data" option is selected  when facet variable is active and showMissingness==true. QA is complete.


feat(service): Add Instagram service

Add support for Instagram service.
I would be happy to add unit tests, but I skimmed through #1 and it seems like the decision on testing is still pending.

Hey @alankan886, thanks for your contribution and thanks for alerting me to the fact that ahmdrz/goinsta currently seems pretty inactive. I will try to contact the developer. If I can't reach him, I really only see three solutions:

We fork the repo and maintain it ourselves (can't do it myself atm too short on time)
We don't support Instagram for the time being
We use the inactive library, but clearly advise in the documentation not to use the Instagram service

I would like to know your opinion on this @j-wil @KrishanBhalla.
Until we make a decision, I'm leaving the PR open. Really, I appreciate your contribution and would love to merge it right now but we need to decide this first; sorry!

@nikoksr, thanks for letting me know, that's unfortunate.
I think with option 1, we will still be relying on  ahmdrz/goinsta's private API (official Instagram API doesn't seem to allow DMs), so I don't think it's beneficial to go with option 1. I feel like it comes down to how long the private API's DM feature will last, it works fine atm, but I would definitely ask the developers if they expect the API to work with Instagram's future updates.

@alankan886 I have already contacted the developer and am now waiting for his response.
Just gave this a quick Google search and found this.

@nikoksr ah good find, so perhaps just wait until Facebook publishes the updated API.

@alankan886 yes, then possibly our best choice. We are now waiting for the answer from the developer and then decide. Again, I'm really sorry for the inconvenience. I was very busy the days, otherwise I would have answered earlier that we must first contact the developer.

@nikoksr I think you're on the right track here we have to imagine notify running in production environments where people may rely on the notifications produced by our work here.
+1 waiting for messenger insta integration

Closing this for now. Will update the Facebook-Messenger issue (#4).


Team Member's Page

Longer titles do not align - https://chapmancommunities.spacepirateproductions.com/our-team/

:tada: This issue has been resolved in version 0.0.4 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Regex Highlighting

Regular expressions are not being highlighted properly. I am using a regular expression that contains both the ' and characters. Currently it is intepreting the as the beginning of a template string.
This is the regular expression that I am using.
/^[a-zA-Z0-9.!#$%&'+/=?^_`{|}~-]+@a-zA-Z0-9?(?:.a-zA-Z0-9?)$/
Let me know if I can give any more information. Love this plugin by the way. The es6 support is superb.

/^[a-zA-Z0-9.!#$%&'+/=?^_`{|}~-]+@a-zA-Z0-9?(?:.a-zA-Z0-9?)$/
I apologize. The regex above was the actual expression. It have verified that it is legal. However, anything after the backtick is highlighted incorrectly.

The full expression is not being shown because part of it is being rendered as markdown. I'll try to figure out how to send the full expression.

Use 4 space or ` to quote the expression?

Is this what you expect?

Yes, this is what I get.

Do you update to latest reversion (just commit hours ago)?

I have not, but I'll do so now. Thank you for your quick response.

This is much better. However, the highlighting is still a little off. However, this is still major improvement. Thank you.

Could you install thins plugin https://github.com/kergoth/vim-hilinks
And use HLT command to see the highlight trace before, between and after the white part?

The HLT command doesn't seem to do anything. Can you explain this more in depth?

You can try another command :HLT! then move cursor and see statusbar

That worked.
Before: SynStack:  javascriptFuncCallArg->javascriptObjectLiteral->javascriptObjectLiteral->javascriptRegexpString->javascriptRegexpSet  HltTrace: T:javascriptRegexpSet->javascriptRegexpStr
ing->String->Constant fg<130> bg<-1>
During: SynStack:  javascriptFuncCallArg->javascriptObjectLiteral->javascriptObjectLiteral->javascriptRegexpString->javascriptRegexpSet  HltTrace: javascriptObjectLiteral             fg<-1>
bg<-1>
After: SynStack:  javascriptFuncCallArg->javascriptObjectLiteral->javascriptObjectLiteral->javascriptRegexpString  HltTrace: javascriptRegexpString->String->Constant fg<130> bg<-1>

Not sure why the first two have same SynStack but HltTrace is different.

@Bipsy
Is it ok to apply some change on your machine to see if bug fixed?
I can't reproduce your issue here.


Per-node daemon processes launched as part of the workflow

Kubernetes has this notion of DaemonSets where you can say you want some task to run on every node, for the duration of that node's lifetime - https://kubernetes.io/docs/concepts/workloads/controllers/daemonset/
That fits in with some experience from the imsim project where I've wanted to run monitoring code on all nodes, that is not part of the "real" work being done on that node.
In imsim, I implemented something like it by putting shell code into the overrides section of long lived worker jobs - although that is not entirely the same.

I have done a little bit of work running processes per-node (for monitoring) alongside WQ/HTEX workers with David Adams in the context of LSST DESC.


Fix maven coordinates

The readme is not correct.
@szabowexler

Discussed in Slack – this isn't quite right.


Setting to move or hide toolbar

The nav header takes a lot of vertical space and I don't use it,
having an option to either move it to the bottom after all tabs or hide completely would be nice.

Hi! An easy way to do this is using the following CSS snippet:
.vertical-tabs .nav-header {
    display: none;
}

Here's the official guide for adding CSS snippets.
As a reminder, I strongly advise you NOT to do so. This toolbar is a part of Obsidian UI. You will see the same kind of toolbars in build-in views, such as Files, Bookmarks and Tags. In the near future, several important buttons will be added here and hiding them will break the UI and its functionality.
As I said, hiding the toolbar will completely break the UX, therefore, I am afraid that this option will not be added to the settings. As an alternative, you may want to reduce the space between toolbar and vertical tabs by using the following snippet:
.obsidian-vertical-tabs-container {
    padding-top: 0;
}

move it to the bottom after all tabs

Some themes offer this feature. If you see the toolbar on the top, it means that your theme designer decided this way. Vertical Tabs will show the toolbar at the same location as all the remaining parts of Obsidian to offer users a consistent UI. You may manually overwrite this with this snippet:
.vertical-tabs {
    flex-direction: column-reverse !important;
}

I'll close this issue now. If you need further help, please comment below. Thank you for your appreciation!

Hi @Mercencium , I updated the CSS snippet for putting the toolbar at the bottom. This is more recommended than the previous version.


Add informers and listers for the advanced usages

Changes
In future, the Shipwright Build may be used by other clients, or we will have more advanced usages by leveraging the lister.
Let us add the informers and listers as a complete open-source controller
What I did in the PR:

Change the generate-codegen.sh to a common name update-codegen.sh
add informer and lister in the update-codegen.sh
Reran the update-codegen.sh, the clientset code is updated because the api change (Also compare with how Tekton and Knative do: https://github.com/tektoncd/pipeline/tree/master/hack and https://github.com/knative/serving/tree/master/hack)
Simplify the generated clientset folder from pkg/client/build to pkg/client directly
Add the verify-codegen.sh and verify if it is correct now (Of course, this verify-codegen.sh can be executed in each PR verification, but we can do that in future PR):

➜  build git:(add_informer) ✗ ./hack/verify-codegen.sh

Using code-generator package version, as instructed in the go.mod file
The code-generator package is imported via the pkg/kubecodegen dir
To modify the current version, please modify this in the go.mod

Generating deepcopy funcs
Generating clientset for build:v1alpha1 at github.com/shipwright-io/build/pkg/client/clientset
Generating listers for build:v1alpha1 at github.com/shipwright-io/build/pkg/client/listers
Generating informers for build:v1alpha1 at github.com/shipwright-io/build/pkg/client/informers
Diffing /Users/jordan/gopath/src/github.com/shipwright-io/build against freshly generated codegen
/Users/jordan/gopath/src/github.com/shipwright-io/build up to date.

Add a README.md in the hack folder to introduce all scripts.
Refine the test code the use the correct generated clientset package

Submitter Checklist

[ y ] Includes tests if functionality changed/was added
[ y ] Includes docs if changes are user-facing
[ y ] Set a kind label on this PR
[ y ] Release notes block has been filled in, or marked NONE

/kind enhancement
Release Notes
Add informers and listers for the advanced usages

@zhangtbj is not "Simplify the generated clientset folder from pkg/client/build to pkg/client directly" a breaking change that needs special consideration in the release note?

/approve

Thank you @SaschaSchwarze0 , yes, I added the package change in the release note.

Reviewing later today, xiexie


PHP: fix qps benchmark failure by updating composer protobuf

Running grpc_full_performance_master test.

Adhoc Performance (ignore for now) - #15589


[Bug]: OOM when loading packages from ballerina user home

Description
When we're using the below .ballerina folder, the LS crashes and we get an OOM.
https://drive.google.com/file/d/1-ciZUGjsR4kaTssyA1FV0X2NxeBqW4oG/view?usp=sharing

Steps to Reproduce
No response
Affected Version(s)
No response
OS, DB, other environment details and versions
No response
Related area
-> Compilation
Related issue(s) (optional)
No response
Suggested label(s) (optional)
No response
Suggested assignee(s) (optional)
No response

This OOM occurs when loading packages from the Ballerina user home. From what I have noticed, this occurs when pulling health.hl7v2.utils.v2tofhirr4, version 2.2.2. The .ballerina folder contains the following versions of health.hl7v2.utils.v2tofhirr4.

@mindula We are pulling these modules to provide code actions or any other suggestions, Right? After pulling the modules, we need to compile them. Are we keeping all pulled modules in memory?
One thing to clarify: after deleting the 2.2.2 module from the cache, it is working, right?

As shown in the image above, the health.hl7v2.utils.v2tofhirr4 package gets pulled after pulling health.hl7v231. I tried deleting the health.hl7v231 package, and we no longer encountered the OOM issue.
In the LSPackageLoader, we're loading all the packages in the Ballerina user home and storing the information in a List. I think this is causing an OOM due to to the high memory consumption from storing all the module information in a list.

@chiranSachintha We are not keeping internal symbol details about each module. Just a simple set of module information.

I changed the package loading logic to only load the newer versions of each package, but we still encountered the OOM issue. Additionally, I noticed that if I delete any one of the 15 packages shown in the image below, the OOM issue no longer occurs which means that one package has the other 14 packages as its dependencies. I think this is happening because when we delete any package from those 15, the dependent package doesn't get compiled due to a missing dependency. Hence, we no longer get the OOM.
The size of the ballerinax folder with the 15 packages in their new versions is 47.1 MB.
WDYT? @MaryamZi @azinneera

This will be fixed with https://github.com/ballerina-platform/ballerina-lang/issues/43172


Feature: Fetch footprint from Remote Account when running with auth mode ECS-METADATA in AWS account

Feature Suggestion
I am trying to host the client and api in a different AWS account than the one that I am trying to get the footprint from. i.e. Running client and api in AWS Account A using two fargate containers and I would like to fetch the footprint from a different Account, Account B.
Describe the solution you'd like
It would be ideal if we could run the queries using an assume role from Account A to Account B when running through either a fargate container or a lambda function.
Describe alternatives you've considered
Additional context
Currently using this credential provider I don't have an ability to assume a role as a container in order to run the calc on a different account.
Possible Implementation
We need an additional config with an assume role where we can pass it and do all the fetching.

I guess we have the same problem. Our CCF application is deployed on account A, and need to assume to the account B to do the Athena queries.
You can try to set the authMode to AWS and set the targetAccountRoleName, the role you want to assume to in account B. It works in our case.
The IAM roles and policies can refer to this artical: How do I configure my Amazon ECS task to assume an IAM role in another AWS account?. Hope this helps.


Random advice API

Description
Please include the details of the API used in this PR.
Screenshot
Optional

Checklist

[x] API used in this PR was not used in just-calling-random-api before.
[x] API used in this PR is Public or I have permission to use it.
[x] My contribution is working.
[x] My changes don't generate any new warnings.
[x] My changes don't affect any work done by other developers.

To tick a box, replace [ ] with [x].

Awesome contribution. Thank you!

Hey @vedangj044 looks like there's a typo in the label


IE creating a new session id on each request

Sails version: 0.12.3
Node version: 4.3.1
NPM version: 2.14.6
Operating system: OSX 10.11.3

Sorry if this isn't the right place to post this but I'm at my wits end trying to find out why it's happening and how to resolve it and not got any response from Stack Overflow.
Basically the issue is only in IE when the Advanced Privacy Setting are set to Block 1st Party Cookies but allow session cookies. My understanding is this should allow the session cookie to be saved but this doesn't happen meaning every request creates a new session id and is leading to issues such as CSRF Mismatch.
I'm using the connect-mongo option for sessions. Please let me know if you need any extra info but as I don't really understand where the issue lies I don't know what to provide you at this point.

ok fixed

ok fixed

ok fixed

@dottodot Looks like IE's concept of "session cookies" is cookies with a zero/past ttl:

From https://www.microsoft.com/resources/documentation/windows/xp/all/proddocs/en-us/set_priv_custom.mspx?mfr=true
If you want Internet Explorer to always allow session cookies (cookies that will be deleted from your computer when you close Internet Explorer) to be saved on your computer, click Always allow session cookies.

So in other words, IE doesn't know that sails.sid happens to relate to user sessions in your app-- and I don't believe that's what they mean (I think they'd call sails.sid an "authentication cookie").  When they say "session cookie" they mean something different: like a "transient cookie".  That is, if a user's IE settings are configured to only allow 1st party cookies if they are "session cookies", it means that IE will only allow cookies that self-destruct when the user closes their web browser.

tldr; you need to make cookies transient for IE users with this particular use case.  To do so, you could set a past expiry date for your session cookie (e.g. something like this vanilla express example).  Or you could do so globally in your app by changing your sails.config.session settings.
But I think what you want to do is this:
req.session.cookie.expires = false;

From https://github.com/expressjs/session#reqsessioncookie:
Each session has a unique cookie object accompany it. This allows you to alter the session cookie per visitor. For example we can set req.session.cookie.expires to false to enable the cookie to remain for only the duration of the user-agent.

Thanks for the information I will have a play and see what I can work out and report back.
One piece of information I missed out was the other reason this is an issue is because if you are trying to detect if cookies are enabled or not, these IE setting are reporting that they are.

Ok so I have the following which works great, not sure if it the best way of doing it but as it works I'm happy.
Basically your example was fine but meant that users of IE that had normal settings would lose their session once they closed the browser so would lose things such as their cart so I found that by trying to set a cookie and checking to see if it exists allows me to target users we these silly settings.
var parser = require('ua-parser-js');

module.exports = function(sails) {
  return {

    initialize: function(done) {
      // Only relevant if the session hook is in use (refuse to continue lifting otherwise)
      if (!sails.hooks.session) {
        return done(new Error('In order for this `transient-sessions` hook to be meaningful, the `session` hook must be enabled.'));
      }
      return done();
    },

    routes: {
      before: {
        '/*': function(req, res, next) {
          res.cookie('tryset',true, { maxAge: 900000, httpOnly: true });
          var ua = parser(req.headers['user-agent']);
          var isUserAgentSuspiciousOfTheWholeWorld;
          if (ua.browser.name === 'IE' && !req.cookies.tryset) {
            isUserAgentSuspiciousOfTheWholeWorld = true;
          } else if (ua.browser.name === 'IE' && req.cookies.tryset) {
            req.session.cookie.expires = 24 * 60 * 60 * 1000 * 30;
          }

          if (isUserAgentSuspiciousOfTheWholeWorld) {
            req.session.cookie.expires = false;
          }
          return next();
        }
      }
    }
  };
};


Link trash management to artifact.delete()

Otherwise, it's hard to guess how to find things in the trash.
https://lamin.ai/docs/lamindb.artifact#lamindb.Artifact.delete

Also clarify storage parameter more: for key_is_virtual false it's really important to know whether you want to keep the file or not.
The dialogue can hint to the parameter: https://lamin.ai/docs/lamindb.artifact#lamindb.Artifact.delete


EncodingAttr to track type of source op

This is to get encoding ready for ops other than MATMUL.
Resolves https://github.com/iree-org/iree/issues/17604

Cant we use the indexing maps to deduce that this is a matmul?

I think it is possible. We can use linalg::inferContractionDims(maps) to see if it is a contraction op.

@hanhanW @MaheshRavishankar if we can figure out by simply looking at the source op type, then we probably don't need this change?

@hanhanW @MaheshRavishankar if we can figure out by simply looking at the source op type, then we probably don't need this change?

I was talking to Benoit about this. I think he clarified something. A linalg op is characterized with three things, iterator types, indexing maps and region. We dont care about iterator types here for now in the encoding, and we are considering how to represent the indexing maps. We might need to represent the region in the attribute though. So saying MATMUL is OK I think. This plus "element types" gives us description of the body. of the op...


in Gemfile, :branch => "master" isn't working

This could be me.... but
If I use this in my Gemfile
gem 'spree_static_content',
        :git => 'git://github.com/spree/spree_static_content',
        :branch => 'master'

running 'bundle install' gives me:
Updating git://github.com/spree/spree_static_content
fatal: Could not parse object 'b853a62c7cdf67973661af8391aa8e1a3f68966f'.
Git error: command git reset --hard b853a62c7cdf67973661af8391aa8e1a3f68966f in directory /Users/steve/.rvm/gems/ruby-1.9.3-p0@rkbbspree/bundler/gems/spree_static_content-b853a62c7cdf has failed.
If this error persists you could try removing the cache directory '/Users/steve/.rvm/gems/ruby-1.9.3-p0@rkbbspree/cache/bundler/git/spree_static_content-ecb33487986dcb19dba1425cbbb89a27abdbde7a'
however, if I have this in my Gemfile:
gem 'spree_static_content',
        :git => 'git://github.com/spree/spree_static_content',
        :branch => 'namespace'

Then everything works.

We / I will address all the issues this week during SpreeConf.. Make it ready for 1.0.0
Peter Berkenbosch
--------—-------—---------—
Wat niet kan, is nog nooit gebeurd.
-------—--------—-----------—
Verstuurd vanaf mijn iPhone.
On 12 feb. 2012, at 17:10, "Steve Root"<EMAIL_ADDRESS>wrote:

This could be me.... but
If I use this in my Gemfile
gem 'spree_static_content',
       :git => 'git://github.com/spree/spree_static_content',
       :branch => 'master'

running 'bundle install' gives me:
Updating git://github.com/spree/spree_static_content
fatal: Could not parse object 'b853a62c7cdf67973661af8391aa8e1a3f68966f'.
Git error: command git reset --hard b853a62c7cdf67973661af8391aa8e1a3f68966f in directory /Users/steve/.rvm/gems/ruby-1.9.3-p0@rkbbspree/bundler/gems/spree_static_content-b853a62c7cdf has failed.
If this error persists you could try removing the cache directory '/Users/steve/.rvm/gems/ruby-1.9.3-p0@rkbbspree/cache/bundler/git/spree_static_content-ecb33487986dcb19dba1425cbbb89a27abdbde7a'
however, if I have this in my Gemfile:
gem 'spree_static_content',
       :git => 'git://github.com/spree/spree_static_content',
       :branch => 'namespace'

Then everything works.

Reply to this email directly or view it on GitHub:
https://github.com/spree/spree_static_content/issues/32

Strange - it works for me now too.  Must have been something I've done.
Thanks for looking into it
Steve


Team / environment level environment variables (secrets)

[ ] #118
[ ] Runner sets environment variables inside the container when spinning it up to run the tasking
[ ] UI for managing the environment variables

Q&A on the implementation:

Add a variables section to package.yaml to declare which ones you need

Yes, I agree. In addition to letting us limit which environment variables we pass through during tasking (which probably doesn't buy us a ton, but we may as well do if we have the info), it allows us to warn if there's a situation where a function requires a certain variable that isn't set for the environment.

Masking may be complicated - gitlab has a bunch of restrictions/qualifications (Secret qualifications from initial implementation: https://gitlab.com/gitlab-org/gitlab-foss/-/issues/13784/#note_106756757)

We don't necessarily have to bog ourselves down with trying to figure out the masking out of the gate. But we can talk about a simple-ish approach and if it buys us to implement such a thing early on or not.

Are variables associated with a team or an environment or both? Should an environment inherit all team variables?

Both. Environments inherit the Team level variables, but can override.

Should we allow overriding a variable on the tasking form?

That could be a valid requirement, not going to implement for this set of tickets

Have a config setting for variables you can't set(don't override PATH?)

Having a set of "reserved" environment variables that can't be set probably makes sense, but feels less important if we're making people declare in the package.yaml what environment variables to pass through. Meaning, with the explicit declaration it's not like someone settings a PATH variable at the team level is just going to break every package. Only packages that declare that variable would actually get it, so a proper warning in the developer docs should be sufficient.


Added ADX in CA supported app list

Azure Data Explorer now supports AAD Conditional access

@anshulsharmas : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#label:"aq-pr-triaged"

#sign-off

@Court72 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@Court72 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@Court72 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@Court72 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@MicrosoftGuyJFlo
Would you mind checking the new link after these changes go live? It won't resolve for me in the GitHub view, but it does look correct.
Thanks! Merging now.


Print out a plain text tree with prettier output

This is cool: https://gist.github.com/jashmenn/1152505

Cool but no time 🤪


Ensure integration will appear in UI

@philbrookes @maleck13 Would you mind taking a look?
This basically adds enough information to the secret so that it will be displayed in the UI. This is what the resulting secret looks like.
name: 3scale,
type: apicast-configuration-url-secret,
uri: my-url-admin.3scale.net,
password: <apassword>

The way this displays is shown in the linked PR.


[UI] UI change for Show/View Page

Description
Improve the UI of View/Show Campgrounds page to be more attractive.
Current Behavior
The current UI is minimalist.
If you're going to work on this issue, create a new issue explaining your changes and mention this issue.

I want to work on this issue. Please assign this issue to me.

Hey @BinaryBhakti , Create a new issue stating all the changes you want to make and mention this issue like (issue #4). I'll review it and assign it to you.

What will be the working space for this?

https://campx-f9sv.onrender.com/campgrounds/66c88dbd51e889011ae94479 is the working space for this issue.
You can access it by clicking the "View {Campground-name}" button under each campground.
If you have any further questions or need assistance, please let me know!


Amazon S3

Thanks for the great module!  Is there a way to use this to pre-process external images, say from Amazon S3?

I'll do it in a fork soon, will keep you guys posted.


fix pseudo random behaviour in pool selection

Description
This PR fixes the issue where the same pool is selected when multiple volumes are attached to a VM when only two pools are available. The list is shuffled but due to a bug in Random this does not result to a different one being selected each time. By using SecureRandom with a seed. this is fixed.

Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[x] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale

[ ] Major
[x] Minor

Bug Severity

[ ] BLOCKER
[ ] Critical
[x] Major
[ ] Minor
[ ] Trivial

Screenshots (if appropriate):
How Has This Been Tested?

manually tested.

@blueorangutan package

@nvazquez a Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3279

@blueorangutan test

@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@DaanHoogland
from what I understand, the issue can be fixed by https://github.com/apache/cloudstack/pull/6307/commits/65d557ed62a2520d376ce8410e247257d331dcd6
in another word, by following change, right ?
diff --git a/engine/storage/src/main/java/org/apache/cloudstack/storage/allocator/AbstractStoragePoolAllocator.java b/engine/storage/src/main/java/org/apache/cloudstack/storage/allocator/AbstractStoragePoolAllocator.java
index 41a8325558..237d016e97 100644
--- a/engine/storage/src/main/java/org/apache/cloudstack/storage/allocator/AbstractStoragePoolAllocator.java
+++ b/engine/storage/src/main/java/org/apache/cloudstack/storage/allocator/AbstractStoragePoolAllocator.java
@@ -17,6 +17,7 @@
 package org.apache.cloudstack.storage.allocator;

 import java.math.BigDecimal;
+import java.security.SecureRandom;
 import java.util.ArrayList;
 import java.util.Collections;
 import java.util.HashMap;
@@ -74,6 +75,11 @@ public abstract class AbstractStoragePoolAllocator extends AdapterBase implement
     @Inject private StorageUtil storageUtil;
     @Inject private StoragePoolDetailsDao storagePoolDetailsDao;

+    /**
+     * make sure shuffled lists of Pools are really shuffled
+     */
+    private SecureRandom secureRandom = new SecureRandom();
+
     @Override
     public boolean configure(String name, Map<String, Object> params) throws ConfigurationException {
         super.configure(name, params);
@@ -179,7 +185,7 @@ public abstract class AbstractStoragePoolAllocator extends AdapterBase implement

         if (allocationAlgorithm.equals("random") || allocationAlgorithm.equals("userconcentratedpod_random") || (account == null)) {
             // Shuffle this so that we don't check the pools in the same order.
-            Collections.shuffle(pools);
+            Collections.shuffle(pools, secureRandom);
         } else if (allocationAlgorithm.equals("userdispersing")) {
             pools = reorderPoolsByNumberOfVolumes(plan, pools, account);
         } else if(allocationAlgorithm.equals("firstfitleastconsumed")){

Yes @weizhouapache , there rest is refactoring and traces to make the code more understandable. And there is a little fix to remove a redundant variable as well.

Yes @weizhouapache , there rest is refactoring and traces to make the code more understandable. And there is a little fix to remove a redundant variable as well.

@DaanHoogland can you create a PR for the change, so we can merge next Monday (<IP_ADDRESS> code freeze date) ?

This is it. Why not merge as it. It contains no other functionality

Trillian test result (tid-3998)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 33608 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6307-t3998-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6307 (SL-JID-1466)

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6307 (SL-JID-1471)

UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6307 (SL-JID-1472)

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6307 (SL-JID-1497)

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6307 (SL-JID-1511)

@blueorangutan package

@nvazquez a Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3349

@blueorangutan test

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6307 (SL-JID-1550)

@blueorangutan package

@DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3387

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

Trillian test result (tid-4163)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 34643 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6307-t4163-kvm-centos7.zip
Smoke tests completed. 88 look OK, 1 have errors
Only failed tests results shown below:

Test
Result
Time (s)
Test File

test_01_add_primary_storage_disabled_host
Error
34.44
test_primary_storage.py

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6307 (SL-JID-1563)

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6307 (SL-JID-1663)

@blueorangutan package

@blueorangutan package

@DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3520

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

Trillian test result (tid-4295)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 39155 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6307-t4295-kvm-centos7.zip
Smoke tests completed. 94 look OK, 4 have errors
Only failed tests results shown below:

Test
Result
Time (s)
Test File

test_01_add_primary_storage_disabled_host
Error
0.80
test_primary_storage.py

test_01_primary_storage_nfs
Error
0.10
test_primary_storage.py

ContextSuite context=TestStorageTags>:setup
Error
0.18
test_primary_storage.py

test_03_deploy_and_scale_kubernetes_cluster
Failure
30.81
test_kubernetes_clusters.py

test_07_deploy_kubernetes_ha_cluster
Failure
57.35
test_kubernetes_clusters.py

test_08_upgrade_kubernetes_ha_cluster
Failure
37.95
test_kubernetes_clusters.py

test_09_delete_kubernetes_ha_cluster
Failure
0.04
test_kubernetes_clusters.py

ContextSuite context=TestKubernetesCluster>:teardown
Error
71.70
test_kubernetes_clusters.py

test_01_secure_vm_migration
Error
148.94
test_vm_life_cycle.py

test_02_unsecure_vm_migration
Error
266.14
test_vm_life_cycle.py

test_03_secured_to_nonsecured_vm_migration
Error
140.68
test_vm_life_cycle.py

test_08_migrate_vm
Error
43.91
test_vm_life_cycle.py

test_hostha_enable_ha_when_host_in_maintenance
Error
301.73
test_hostha_kvm.py

@blueorangutan package

UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6307 (SL-JID-1686)

@blueorangutan package

@DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3536

@blueorangutan test

@blueorangutan package

@nvazquez a Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@nvazquez a Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_multiplication_x: suse15. SL-JID 3546

@nvazquez a Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan test

Trillian test result (tid-4317)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 36288 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6307-t4317-kvm-centos7.zip
Smoke tests completed. 98 look OK, 0 have errors
Only failed tests results shown below:

Test
Result
Time (s)
Test File


what's the best practice of saving energy with ens160

We are considering upgrade to ens161, but we still have stocks of sensor board with ens160 installed.
Currently our operation procedure is:
1 wake up mcu from deep sleep
2 put ens160 into standard op_mode
3 deep sleep mcu again for 3 minutes, while ens160 is working in standard op_mode
4 collect datas, and then again put everything including ens160 to deep sleep for an hour.
This procedure ens160 alone will consume around 1.45 ma per hour, need a 10,000 mah battery to work for a year.
are there any suggestion about how to balance the energy consumption and accuracy.

that's sad, but thanks


[IA-4526] run-analysis-azure end to end test

Jira Ticket: https://broadworkbench.atlassian.net/IA-4526

Summary of changes:

An end-to-end test for Azure analysis creation, interaction, deletion. Also strengthens some shared testing helpers and adds some v2 resource support to terra-ui's integration test harness.
[x] I need static billing projects for dev, staging, and alpha.

Mostly looks good, but would like to talk a bit more about the runtime not being cleaned up failure case (perhaps in parking lot) tomorrow.
Also agree that we should run this a few times and make sure we're ok with the success timing and the pass %

The runtime is cleaned up in the failure case, since withAzureWorkspace deletes the workspace and its children when the test ends, even on fail. App deletion failure (delete while still Provisioning) may block workspace deletion, but even in that case I think I see runtimes cleaned up regardless.

Run passed: https://app.circleci.com/pipelines/github/DataBiosphere/terra-ui/20154/workflows/ccf9398e-9df6-4f82-9922-1426e0708344/jobs/71824/artifacts

Rerunning: https://app.circleci.com/pipelines/github/DataBiosphere/terra-ui/20154/workflows/24a28ca7-f646-42ee-a164-64468c324cfc

Mostly looks good, but would like to talk a bit more about the runtime not being cleaned up failure case (perhaps in parking lot) tomorrow.
Also agree that we should run this a few times and make sure we're ok with the success timing and the pass %

The runtime is cleaned up in the failure case, since withAzureWorkspace deletes the workspace and its children when the test ends, even on fail. App deletion failure (delete while still Provisioning) may block workspace deletion, but even in that case I think I see runtimes cleaned up regardless.

Hmm, does this mean the workspace is leaked as well in this case?
It sounds like we need a strategy to clean these up. Something along the lines of a cron job that cleans up anything created by Scarlett? We discussed in slack and determined that a (fast) follow-on ticket to examine this once its in the wild to see how often this type of leak occurs (and a strategy to clean up in an automated fashion if it does)

@jdcanas @mlilynolting regarding workspace deletion, we do have a "janitor" integration test that deletes workspaces that start with a specific prefix if they are older than 2 days old. This is calling the v1 (synchronous) workspace deletion API, so it may not work for the Azure workspaces reliably… the v1 API will retry after 2 minutes, which causes issues. It probably would be best to change the janitor cleanup to use the v2 API.

We're back to passing (in 12.5min), with workarounds for the two staging issues: https://app.circleci.com/pipelines/github/DataBiosphere/terra-ui/20239/workflows/80c030e9-2ce7-461b-af4a-e0986d70467a
I'll kick off another set of 10 tests to run tonight and we can see where we are in the morning.

Believe it or not 8 out of 10 of these test runs are green for run-analysis-azure - most of the failures are register-user, with one run-rstudio fail.
Of the two where run-analysis-azure did not pass, one is a "genuine failure" - the notebook took more than 4 minutes to open - and the other was a failure on the build step.


[DRAFT] Support for MPI apps

Description
Parsl currently has very limited support for certain MPI use-cases. The current pilot job model assumes that workers need to be launched onto cores to which the worker is bound for its walltime. However, MPI applications generally need to bind to a subset of nodes (nodes>1) from the batch job. Since the pilot job model fails here, we end up recommending using the executor+provider without a launcher, so that the workers can then use an multi-node launcher such as mpiexec/mpirun/srun/aprun to then launch MPI apps. This gets us into these new issues:
*  Apps end up hardcoding launcher prefixes into bash_apps which means apps are now machine specific. Ideally apps are machine agnostic
*  Apps might have varying resource requirements that are not easy to support. If the machine uses `mpiexec`, the hosts to launch the MPI apps need to be specified, which means the runtime has to known all available nodes, the apps needs, and do some internal resource bookkeeping to avoid overlapping placements.

The solution here is to have a combination of:

Support for MPI-specific resource specifications at the app level and the worker level
Identifying available resources at the manager level and allowing workers to share them based on resource requirements
Generate MPI launcher prefixes from 2. that specify appropriate resources and make this available via env vars.

Fixes # (issue)
Type of change
Choose which options apply, and delete the ones which do not apply.

New feature (non-breaking change that adds functionality)

Nice! This has the general functionality I'm looking for, and I can see being able to work with the Parsl-generated mpirun invocations.
Would you also mind storing the nodelist in an environment variable so I can still build my own mpirun?
I think I understand how things work on the internals and from a user perspective, but would you mind writing those docs before I dig more into reviewing?

@WardLT from my perspective, I'm mostly interested in trying to use this branch for something like a real application - it's hard, at least for me, to understand the usability/unusability without concrete applications.

@yadudoc , do you have any prototype applications sketched out?

Would you also mind storing the nodelist in an environment variable so I can still build my own mpirun? I'm think that's necessary, in general, because we haven't enumerated "all" of the possible launchers and some codes (e.g., deepspeed, Gaussian) use their own.

I don't understand from a brief read of the code what makes the code that tries launch commands in order fail over from the first one - the failure conditions aren't really clear to me: for example, what makes compose_aprun_launch_cmd, the first launcher to try, fail?
Launchers in parsl so far have been plugin-style configurable (i.e. you can supply arbitrary out-of-parsl codebase Launcher objects), and I feel like they should be here too: both because I think users should be able to plug in their own (that they wrote themselves or that someone else supplied) and because I think trying to do magic autodetect is probably wrong here.

@WardLT You're right, I should've started with the docs. I copied over the current MPI apps doc and updated it. Here's a quick link -> https://github.com/Parsl/parsl/blob/mpi_experimental_1/docs/userguide/mpi_apps_updated.rst
I do not have any real apps to test with, I've basically been doing mpiexec ... <hostname> and using a very bare bones mpi app that prints out how the ranks are distributed to confirm that the launcher prefix is working properly.
Here are things I think we need to confirm :

Right now we are only really using NUM_NODES and RANKS_PER_NODE which are the absolute bare minimum that every launcher supports. I do not yet know what other features we'd like. I'm copying over the same model that Balsam uses from here : https://balsam.readthedocs.io/en/latest/user-guide/jobs/#defining-compute-resources, but just enough for a MVP.
The new capability is to run multiple MPI apps with different node requirements. I do not have a good test-case for this beyond my toy app.
Handling of failures at the launcher step is untested. Assume we'll lose nodes.
There are likely unexpected interactions from default scheduler options in the provider that will set ranks per node to 1

@benclifford You are right about real applications, I could really use a real-ish application to test with.
Without a good data model for resource_specification and validation, the prefix being composed can be junk if the resource_specification is incorrect. The alternative was to propagate the KeyError exceptions back to the user, maybe that is a better approach here until there's some validation.

This Draft is now obsolete with most of the MPI work happening over on #3016


support detect selector when there are animation-name defined already

support detect selector when the DOM element has css animation-name defined #4

Hi @lxjwlt - can you explain this feature in more detail? It looks similar to the custom animation-name feature explained here:
https://github.com/muicss/sentineljs#on---add-a-watch-for-new-dom-nodes

thanks for review.
i want to make it possible to detect element by selector, even if animation-name generated by sentineljs has been overridden. XD
i don't think it is a elegant solution to detect element by custom animation-name node-inserted, it means we should add that name everywhere inner css and make sure we don't miss one.
and it also mess up all selectors：
sentinel.on('!node-inserted', function(el) {
    if (el.matches('.my-div')) {
         // do something...
    } else if (el.matches('.my-div2')) {
        // do something...
    }
});

Can you give an example of how to use your proposed changes?

On Oct 7, 2017, at 11:12 PM, lxjwlt<EMAIL_ADDRESS>wrote:
thanks for review.
i want to make it possible to detect element by selector, even if animation-name generated by sentineljs has been overridden. XD
i don't think it is a elegant solution to detect element by custom animation-name node-inserted, it means we should add that name everywhere inner css and make sure we don't miss one.
and it also mess up all selectors：
sentinel.on('!node-inserted', function(el) {
if (el.matches('.my-div')) {
// do something...
} else if (el.matches('.my-div2')) {
// do something...
}
});
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

:laughing:as additional test, the changes would not affect the original feature of sentineljs, but it just add watch for all new element. when element animationstart, it would look for the matched selector contained in selectorToAnimationMap, and invokes all callbacks.
example is like this:
<style>
     @keyframes slidein { /*...*/ }
     .my-div { animation-name: slide-in; }
</style>
<script>
     /* no matter the element has animation-name defined or not,
         we can wacth it by selector  */
     sentinel.on('.my-div', function(el) {
         // ...
     });
</script>

If I understand the code correctly, it looks like this pull request iterates through all CSS selectors on every animationstart event. Is there a way to implement this without iterating through all events?


feat: 4041 - now displaying user lists in "List" nav tab

What

When the user clicked on the "select the other product lists" button, the user lists were not present.
Now the user lists are present, and the user can create new user lists.

Screenshot

Part of

#4041

Files
New file:

all_product_list_page.dart: Page that lists all product lists.

Impacted files:

all_user_product_list_page.dart: simplified thanks to a new not async getter of all user product lists
dao_product_list.dart: split the "get user lists" method in two - one not async, one async with barcode checks
new_product_page.dart: minor refactoring
product_list_page.dart: now using new page AllProductListPage in order to list all product lists
product_list_popup_items.dart: fixed a label; removed a class we don't use anymore as we put lists and actions in different buttons
product_list_user_dialog_helper.dart: minor refactoring

Hi @g123k!
I added the feature ("user lists") with a simple interface. I know you have more ambitious UI expectations, but at least the feature is implemented.

It seems you also have an issue with a missing const constructor.

Thank you @g123k for your review!

indeed a StatelessWidget is enough - I copied a code that used setState once but in a part that I did not copy
I've localized the label - after you implicitly agreed that the UI was decent enough
I don't understand itemExtent so I don't use it, and I always chose code maintainability over hypothetical minor performance improvement

Thank you @g123k for your review!

indeed a StatelessWidget is enough - I copied a code that used setState once but in a part that I did not copy
I've localized the label - after you implicitly agreed that the UI was decent enough
I don't understand itemExtent so I don't use it, and I always chose code maintainability over hypothetical minor performance improvement

Perfect!
For ListView.builder, the idea is Flutter tries to guess the number of items to draw on screen.
By giving an itemExtent, we explicitly say that an item has the following height.
In our case, since all items have the same height, giving this info will help to reduce the number of items in cache.
For that, just try a print() with and without it and you will see a difference, which can sometimes be +/-10 celles.
For the UI, what I propose is to validate your implementation with the screen and I will do some tests to potentially include it in a bottom sheet, but later in another PR. The idea is not to block this PR.

@g123k For the record I will not add itemExtent. I understand the purpose and I have a personal interest in performances,  but in general and specifically in that case (user lists) it will add confusion in the code and potentially problem with accessibility, for a non detectable performance improvement.
Especially if you plan to implement another UI later.
Feel free to approve now so that the PR can be merged.


i want specific text from a given image

Hello!
sir i have implemented your package and it's working well but i have faced some difficulty to extract specific text from image like i scan a ID Card and i want only first name and last name from that then how is this possible?

If the location is fixed, it seems to be a way to cut and recognize ocr.

If the location is fixed, it seems to be a way to cut and recognize ocr.

sorry i didn't understand can you elaborate this little bit more?

https://github.com/brendan-duncan/image/blob/main/doc/transform.md
If the name and location are always the same on the id card, why not cut the name part?


Helm does not update files based on the actual configmap values , similar to #833

What did you do?
In helm/kube-prometheus, I have created a values override file for kube-prometheus to add a custom rule using prometheusRules. I can see my rule under the rules tab, but when I change something on my values.yaml, I don't see my change being propagated. For instance, I changed the "for:10m" to "for:5m" , I can see my change on the Configmap kube-prometheus-rules, but not on the file inside the pod  prometheus-kube-prometheus-0 on /etc/prometheus/rules/monitoring-kube-prometheus-rules-test1a.yaml
Similarly deleting the rule or removing the prometheusRules config from my values file does not result in the removal of rule that was previously specified.
I have also tried to delete the pod and that did not worked.
I have also tried this in 2 other clusters and I have found the same behaviour.
What did you expect to see?
I expected to see my changes after the configmap was updated.
What did you see instead? Under which circumstances?
No changes
** Environment
    Image:         quay.io/prometheus/alertmanager:v0.14.0
    Image:         quay.io/coreos/configmap-reload:v0.0.1
    Image:          gcr.io/google_containers/kube-state-metrics:v1.2.0
    Image:         gcr.io/google_containers/addon-resizer:1.7
    Image:         quay.io/prometheus/node-exporter:v0.15.2
    Image:          grafana/grafana:5.0.0
    Image:         quay.io/coreos/grafana-watcher:v0.0.8
    Image:         quay.io/prometheus/prometheus:v2.2.1
    Image:         quay.io/coreos/prometheus-config-reloader:v0.20.0
    Image:         quay.io/coreos/configmap-reload:v0.0.1
    Image:         quay.io/coreos/prometheus-operator:v0.20.0

Kubernetes version information:

Client Version: version.Info{Major:"1", Minor:"10", GitVersion:"v1.10.1", GitCommit:"d4ab47518836c750f9949b9e0d387f20fb92260b", GitTreeState:"clean", BuildDate:"2018-04-13T22:27:55Z", GoVersion:"go1.9.5", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"9", GitVersion:"v1.9.6", GitCommit:"9f8ebd171479bec0ada837d7ee641dec2f8c6dd1", GitTreeState:"clean", BuildDate:"2018-03-21T15:13:31Z", GoVersion:"go1.9.3", Compiler:"gc", Platform:"linux/amd64"}

Kubernetes cluster kind:

AKS

Manifests:

prometheus:
    # default rules are in templates/general.rules.yaml
    prometheusRules:
      test1a: |-
        groups:
        - name: test1a.rules
          rules:
          - alert: test1alert
            expr: prometheus_config_last_reload_successful == 0
            for: 5m
            labels:
              severity: warning
            annotations:
              description: Something{{$labels.namespace}}/{{$labels.pod}}
              summary: Testing alerts.

Prometheus Operator Logs:

insert Prometheus Operator logs relevant to the issue here
...
level=info ts=2018-06-25T15:00:53.014598909Z caller=operator.go:731 component=prometheusoperator msg="sync prometheus" key=monitoring/kube-prometheus
...

The logs are with the same content as above.

This seems to be working now for alerts, but dashboards are still not being updated.


Add indexRandomForConcurrentSearch for tests:

MultiSearchIT.java
SimpleNestedIT.java
SearchPreferenceIT.java
SimpleQueryStringIT.java
ScriptQuerySearchIT.java

Description
Follow-up to #11065
Muted tests related to nested sorting that are flaky
Check List

[x] New functionality includes testing.

[x] All tests pass

[x] New functionality has been documented.

[x] New functionality has javadoc added

[x] Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
[x] Commits are signed per the DCO using --signoff
[x] Commit changes are listed out in CHANGELOG.md file (See: Changelog)
[x] Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@neetikasinghal can you please take a look? Thanks!

Will backport this manually with https://github.com/opensearch-project/OpenSearch/pull/11118

Tracking the bugfix for the muted flaky tests here:

https://github.com/opensearch-project/OpenSearch/issues/11187

@reta @andrross @sohami could you help review + merge this one too? Thanks!


Cannot use the hl group override feature

config.lua:
require("github-theme").setup({
  groups = {
    all = {
      StatusLine = { link = "Error" },
    },
  },
})

vim.cmd.colorscheme("github_dark_dimmed")

Now running neovim with
$ nvim --noplugin -u config.lua config.lua

It seems that overrides work fine with github_dark and github_dark_colorblind colorscheme but are broken with github_dark_dimmed, github_dark_high_contrast.

Seems like I can reproduce this, and it appears to be a bug having to do with the compiler/cache (stale cache, false/incorrect cache hit, etc.) (i.e. if you delete the cache first and then run this it works fine or as expected). This requires debugging and further investigation. Thank you for the bug report.

Closing due to inactivity. Can reopen later.

Was facing a similar issue, and :GithubThemeCompile resolved it. Is there a way to automatically run that on config changes? Is that the expected behavior?

This appears to be resolved as of the latest HEAD (4f44a5c930372c85483d02700f332d34417e50b2), and should be included in v1.0.2 as well.

Was facing a similar issue (configured styles not being applied), and :GithubThemeCompile resolved it. Is there a way to automatically run that on config changes?

@wadefletch Yes, you could always define a VimEnter autocmd or something similar, but it should be fixed now. Just update your plugin and you should be all good. 👍

Is that the expected behavior?

No, it was due to a bug in the compiler code. The compiler relies on a custom hash function and compiles your config together with theme settings from the plugin to a lua bytecode file. Its purpose is to improve nvim's startup time when loading plugins during startup (which it does).

Please open a new issue and/or respond here with a comment if you face any similar issues in the future.


goreleaser: 0.148.0 -> 0.149.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/goreleaser/goreleaser/releases.
meta.description for goreleaser is: "Deliver Go binaries as fast and easily as possible"
meta.homepage for goreleaser is: "https://goreleaser.com"
meta.changelog for goreleaser is: ""
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 0.149.0 with grep in /nix/store/j9g0dc6k3zbza4ikh3zzdvzwb1ml9arc-goreleaser-0.149.0

directory tree listing: https://gist.github.com/f583d74e7d53e923c71621ab21267a84

du listing: https://gist.github.com/bd924b248383f71817fce089b556c239

Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
1 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
goreleaser

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/j9g0dc6k3zbza4ikh3zzdvzwb1ml9arc-goreleaser-0.149.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A goreleaser https://github.com/r-ryantm/nixpkgs/archive/e64ccd15bd3608418e185fca1842ed04df3e6ec8.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/j9g0dc6k3zbza4ikh3zzdvzwb1ml9arc-goreleaser-0.149.0
ls -la /nix/store/j9g0dc6k3zbza4ikh3zzdvzwb1ml9arc-goreleaser-0.149.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review 1

1 package built:

goreleaser

Maintainer pings
cc @c0deaddict @endocrimes @sarcasticadmin @kalbasit for testing.

Result of nixpkgs-review pr 105876 run on x86_64-linux 1

1 package built:

goreleaser

Result of nixpkgs-review pr 105876 1

1 package built:

goreleaser


Binary operations on Series + DataFrame doesn't work

System information

OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Any
Modin version (modin.__version__): 4ec7f63
Python version: 3.8.10
Code we can use to reproduce:

import modin.pandas as pd

df = pd.DataFrame({"a": [1, 2, 3]}).T
sr = pd.Series([10, 20, 30])

print(f"Pandas:\n{sr._to_pandas() + df._to_pandas()}")
print(f"Modin:\n{sr + df}")

Output
Pandas:
    0   1   2
a  11  22  33
Traceback (most recent call last):
  File "t3.py", line 8, in <module>
    print(f"Modin:\n{sr + df}")
  File "C:\Users\rp-re\OneDrive\Desktop\rep\modin\modin\logging\logger_metaclass.py", line 68, in log_wrap
    return method(*args, **kwargs)
  File "C:\Users\rp-re\OneDrive\Desktop\rep\modin\modin\pandas\series.py", line 163, in __add__
    return self.add(right)
  File "C:\Users\rp-re\OneDrive\Desktop\rep\modin\modin\logging\logger_metaclass.py", line 68, in log_wrap
    return method(*args, **kwargs)
  File "C:\Users\rp-re\OneDrive\Desktop\rep\modin\modin\pandas\series.py", line 514, in add
    return super(Series, new_self).add(
  File "C:\Users\rp-re\OneDrive\Desktop\rep\modin\modin\logging\logger_metaclass.py", line 68, in log_wrap
    return method(*args, **kwargs)
  File "C:\Users\rp-re\OneDrive\Desktop\rep\modin\modin\pandas\base.py", line 593, in add
    return self._binary_op(
  File "C:\Users\rp-re\OneDrive\Desktop\rep\modin\modin\logging\logger_metaclass.py", line 68, in log_wrap
    return method(*args, **kwargs)
  File "C:\Users\rp-re\OneDrive\Desktop\rep\modin\modin\pandas\base.py", line 431, in _binary_op
    new_query_compiler = getattr(self._query_compiler, op)(other, **kwargs)
  File "C:\Users\rp-re\OneDrive\Desktop\rep\modin\modin\logging\logger_metaclass.py", line 68, in log_wrap
    return method(*args, **kwargs)
  File "C:\Users\rp-re\OneDrive\Desktop\rep\modin\modin\core\dataframe\algebra\binary.py", line 92, in caller
    query_compiler._modin_frame.binary_op(
  File "C:\Users\rp-re\OneDrive\Desktop\rep\modin\modin\logging\logger_metaclass.py", line 68, in log_wrap
    return method(*args, **kwargs)
  File "C:\Users\rp-re\OneDrive\Desktop\rep\modin\modin\core\dataframe\pandas\dataframe\dataframe.py", line 115, in run_f_on_minimally_updated_metadata
    result = f(self, *args, **kwargs)
  File "C:\Users\rp-re\OneDrive\Desktop\rep\modin\modin\core\dataframe\pandas\dataframe\dataframe.py", line 2516, in binary_op
    return self.__constructor__(
  File "C:\Users\rp-re\OneDrive\Desktop\rep\modin\modin\logging\logger_metaclass.py", line 68, in log_wrap
    return method(*args, **kwargs)
  File "C:\Users\rp-re\OneDrive\Desktop\rep\modin\modin\core\dataframe\pandas\dataframe\dataframe.py", line 210, in __init__
    ErrorMessage.catch_bugs_and_request_email(
  File "C:\Users\rp-re\OneDrive\Desktop\rep\modin\modin\error_message.py", line 70, in catch_bugs_and_request_email
    raise Exception(
Exception: Internal Error. Please visit https://github.com/modin-project/modin/issues to file an issue with the traceback and the command that caused this error. If you can't file a GitHub issue, please email<EMAIL_ADDRESS>Column widths: 1 != 4

Describe the problem
The code fails on the column widths check when constructing the binary operation result.
The problem is that the binary_op is designed for df + df operations only. The handling of mixin a frame and a series has to be done via broadcasting a series to every column of the frame instead of attempting to align the shapes of two operands. We already have the broadcasting logic inside Binary operator, the logic is triggered when broadcast parameter is True (happens in cases of df + series), however, the parameter appears to be False when series + df.

We don't fail with exception anymore, but the output is wrong anyway:
>>> print(f"Pandas:\n{sr._to_pandas() + df._to_pandas()}")
Pandas:
    0   1   2
a  11  22  33
>>> print(f"Modin:\n{sr + df}")
Modin:
   __reduced__   0   1   2
0          NaN NaN NaN NaN
1          NaN NaN NaN NaN
2          NaN NaN NaN NaN
a          NaN NaN NaN NaN


Feature/report video

Working video for chome with play and stop buttons.

Updated html report to show slideshow button instead of video.  Meta detail report page was also displaying the button in error.  this has been corrected.


create-react-app my-app

Describe the bug
(Write your answer here.)
Did you try recovering your dependencies?

(Write your answer here.)
Which terms did you search for in User Guide?

(Write your answer here if relevant.)
Environment

(paste the output of the command here.)
Steps to reproduce

(Write your steps here:)

Expected behavior

(Write what you thought would happen.)
Actual behavior

(Write what happened. Please add screenshots!)
Reproducible demo

(Paste the link to an example project and exact instructions to reproduce the issue.)

create-react-app my-app


CreateJS Consortium

Might we propose a CreateJS Consortium that helps with CreateJS updates?  I suppose that is what GitHub and Open Source are all about.  Perhaps if we recognize the need and the commitment it will help organize things.
I am committed to using CreateJS - if you have not seen ZIM yet, please have a look - it extends CreateJS with many conveniences, components and controls.  Personally, I treat CreateJS as complete otherwise, growth would go in the direction of ZIM ;-)  As a complete project, the focus would be on maintenance for example adjusting for various Browser and device changes - bug fixes, etc.   A secondary focus might be improvements to existing elements - but in general, I think what we have is working great!  There may be different visions?
@owendwyer @willkara @jedateach @djipco @dijitaletkinlikler and I am sure a bunch of others might be interested?  Of course it would be nice to know @gskinner and team are on board.  Not even sure exactly what we would be doing differently... but it would be good if we could get to know one another a little better and help each other out with issues, etc.

@danzen That is a great idea. Unfortunately, in my case, it might come a bit too late. I have been using CreateJS in class for a few years. However, seeing that development basically halted, it was becoming increasingly hard to sell its usage to my students (and fellow teachers).
That's too bad because I really liked the fact that it wasn't a gaming engine per se but more of an all-purpose engine. I also liked that it was based on the scene-graph approach which made it simpler to use (in various use cases) than other projects such as p5.js. Having said that, when we look at it objectively, many things now found in other engines never made it inside CreateJS.
Grant Skinner and his team have done great work with CreateJS but they seemed to have moved on... An example of that is the fact that the CDN version has been stuck on v1.0 even if many important fixes have been available in the NEXT version for a long time.
In any case, I really hope that you can find a group of talented people to move this project forward. Good luck!
Cheers!

Hi @djipco Jean-Philippe - thanks for your input.  I feel the same way about CreateJS because it is not a gaming engine like PhaserJS and not as set in its ways as P5js and is more commercial facing.  What we did when we wanted something extra is we built a library of extra code that extends CreateJS.   Over five years, this became ZIM.  We now have a CodePen Topic page which nicely demonstrates perhaps what you are looking for https://codepen.io/topic/zim please have a close look and hopefully, you might be able to stay in the family!
Yes... I have been seeing the gSkinner team working on Flutter.  At first glance, I was concerned as it seems very hot and well supported, etc.  Then I got looking into it... there is a lot of structure and perhaps more for power-coders.  Certainly less free-form creation.  So I concluded it was more for the Web Development community to make information apps which was never particularly what the canvas is for.  I think we still need a general Interactive Media framework and as far as I can tell... that would be ZIM powered by CreateJS much like Phaser is powered by PixiJS.  We just need to grow community and user-base.
Of course, Flash was a general Interactive Media platform... and Animate and CreateJS still work together for many. ZIM works with that too see https://zimjs.com/animate/ but personally... I prefer just coding without Animate.  However, the tie between Animate and CreateJS is certainly helpful.   Showing some action here might help that connection.
It is tricky when libraries/frameworks/platforms reach maturity.  People see the lack of change as stagnation - it is really unfair.  That is one of the things in my mind that caused the "death" of Flash.  It was mature.  The changes announced at conferences were minimal and beyond the immediate need of the audience, etc.  I think the same to some degree has happened with CreateJS - it was built so well... that there was less of a need for new things.  If you want new... that's what we did with ZIM... and now... we are reaching maturity... dum dum dum.  We will probably stay at ZIM TEN.
I don't mean to go on about ZIM... it just might put things in perspective about the direction of CreateJS as to where it might have gone or help identify what CreateJS is and is not.  At the moment, CreateJS minified is 240K and ZIM minified is 600K.  ZIM has distill that lets you tree-shake to often somewhere around 100k.  These numbers are probably pretty similar to Pixi and Phaser.
Anyway - blah blah - sorry for the essay.

It is tricky when libraries/frameworks/platforms reach maturity. People see the lack of change as stagnation - it is really unfair.

I'm not sure that's the case here. Maturity and stability are good things. However, with CreateJS many issues have been left unfixed in the "official", CDN-released version. Here's an example (among others). There are many outstanding (and verified) bugs still listed on GitHub, some of which are many years old.
If maturity was the goal, many little changes would also have been made over the years. For instance, why is it still necessary to cache shapes and texts displayed on StageGL? I don't really see why the engine forces us to do that manually instead of automatically caching these elements with sensible defaults. This is not in the bells and whistles department. Another example is the fact that addEventListener() does not work like the current living standard (no support for the options parameter). These are examples of small things that should have been ironed out in a mature version.
Just to be clear, I am not throwing blame here. I'm thankful @gskinner et al. brought this project to the open source community. But, obviously, they have moved on. To me, CreateJS is not currently in a "mature" state, it is in a "sunset" state.
Hopefully, if your consortium idea takes off, this could change and I would be happy to somehow participate!
P.S. Are you going to FITC Toronto this year? Maybe we can grab a beer and chat about all this! Cheers.

I'm happy to commit to this.  I have content built with CreateJS that I'll need to maintain for at least 5 years.  For me, the focus should be on maintenance and organization with the aim to keep the library working on all devices and browsers.  It would be good to have a current version that is checked and tested by a range of people.

@djipco an FITC meet sounds nice.  I may not officially attend, but would love to meet for lunch.  We can work out details - give me a message at<EMAIL_ADDRESS>- anyone else, I am sure would be welcome - the dates are April 19-21https://fitc.ca/event/to20/

A list of issues that folks have on their minds might be good to compile with links to the issues here if on GitHub.  I mean, that's GitHub issues in general... but as Jean-Philippe says, there are many.  Unfortunately, I suck at pull requests... but I guess I can learn.  Then we need some idea from @gskinner and team as to what to expect on their side or how we might deal with things.  I have had a promising e-mail about a month ago - I will see if I can rekindle this.  In the mean time - initial thoughts from some others would be great.

BTW - I mentioned Grant and team working on Flutter... I saw a tweet of theirs pointing to https://blog.gskinner.com/archives/2020/02/flutter-creating-a-flippable-card-with-tweenanimationbuilder.html - so rebuilt something like it in CreateJS and ZIM at https://codepen.io/danzen/pen/gOpwWbY - the Flutter code is commented at the bottom of the Pen and aside from it being TWICE as much code... I really do get the sense of complex structure (and some complex words).  Probably it is easier to just use out of the box things...  but even the ones I was looking at can quickly get complex - I went through about 60 short tutorial videos.
With respect to the Flippable Card example, it will be nice when the Canvas adds a row and col to the matrix to get perspective... will that happen?  That actually brings up another point here...  where is the "marketing" from the HTML world for the canvas?  It was all buzz buzz buzz for a year and then almost total silence from Browsers companies, etc.  Am I wrong?

hello, because files published with adobe animate use version 1. pressmove will not work on windows touch screens. it is very interesting not to notice this. Either users do not use windows touch screen or do not care about adobe. Someone with little knowledge of javascript like me is trying to find solutions to createjs problems. as if there is trouble. If I can see the problems, it is impossible for Grant and his team to not see the problems. But with the decision I see, Dan works. Great things can be done with Zim.

My use case is building a web-based designer tool: text + shapes + images. I'm investing a bit of time in txtjs, which another abandoned createjs based project to try and ensure cross-browser font rendering consistency. I've also been working on a free transform tool. I need node (server rendering) support.
I've put all my efforts under a new org, thinking along the lines of a consortium: https://github.com/ReCreateJS
I'm trying to configure the projects with good tests, and CI/CD via Travis.
I'm for bringing new life to CreateJs and related projects, as long as it is governed with quality standards, and could be brought back in line with gskinner, should they re-emerge.
I'm moving off Raphael.js, which is based on svg. I have assessed fabric.js, and pixi.js as options. Fabric is reasonably featured, but stuck on a non-esmodules class system. Pixi seems too geared to games.
The lack of maintenance/ownership of createjs does concern me. I'm prepared to move to a better tool, if I am convinced something is more suitable, but I need to start settling down.

So - here we are after a few days... perhaps we are a Fellowship?   While we wait for a few others to comment... let me try contacting Grant and see if he has any suggestions for us.  Will let you know how it goes.

CreateJS was considered an open source project, but it was completely under the stewardship of gskinner and PRs were only accepted if they chose so. Any form of a roadmap was completely managed and controlled by them. Moving this project to community development would require some considerable changes to strategy and stewardship. Before considering this Fellowship idea any further we really need to hear from someone who currently maintains the control over this repo over what they see the future is or should be. Maybe gskinner has plans and scrubbed them or postponed them or just all together moved on. We need to understand that first before we can determine where this is going.
@lannymcnie @gskinner - any comments?

Hi everyone
Apologies for not chiming in sooner.
I am very interested in supporting this movement. I have absolutely loved building CreateJS, and really want it to have a long and healthy life. Unfortunately, with the lack of any (direct or indirect) monetization model, and little to no support from Adobe, we've never found a way to justify it from a business perspective.
That means updates happen only when appropriate members of our team are sitting idle. In the past year, we've been keeping super busy - good for gskinner, but bad for CreateJS.
We are all too aware of this. It has been super frustrating to be sit on a bunch of updates that have yet to make it into a released build. As a result, I reached out to Dan in December to get him thinking about how the community could become full participants in the library's future, and was thrilled to see him start this thread.
It probably goes without saying that I have never managed a transition like this, so I'd appreciate any thoughts or idea on how this might go.
Me, and our team would continue to contribute as possible - we would likely be a lot more active, without being weighed down by the sense that the "next big release" seems like too large of a mountain to climb given our fragmented availability. If we can get some community momentum, I'll work to free up our dev time to be more active where possible as well.
Let me know whatever I can do to help, encourage, and support. I'd be proud to be a member of a thriving CreateJS community, instead of a founding dictator. :)
Best,
Grant.

Adobe is currently using version 1. pressjs is not working on createjs 1.0 windows touch screens.

@gskinner  - Thanks so much for the update, we use createJS in some capacity and it's so nice to hear something other than silence! 👏

@gskinner
The best moments of the web was when you were creating wonderful Actionscript 2/3 classes and I'm the one who discovered your nice work, then google inc. demons with unlimited money and steve jobs killed everything.... Well, not everything since webassembly is coming and a lot of rebirth will happen (check ruffle) and javascrap will be the worst language to develop for the web.

Thanks Grant - that response brought tears to my eyes... the eyes that see code 80% of my waking life.  I would propose that we start a Slack channel to help organize this.  I have been running ZIM community on Slack as well as our Sheridan Interactive Media... and am a member of CodeCamp Hamilton and 100DaysOfCode - it is really easy to set up and use.   If this post gets a few thumbs up, I will create the workspace and provide an invite link here.

Thanks for popping in @gskinner. Great to hear something official. I've have had very high hopes for CreateJS / EaselJS since Pirates Love Daisies. Really enjoyed playing that too.
It's a real shame that Adobe (the company, not the Animate dev team) hasn't taken CreateJS, Animate, or its users seriously in a very long time. With Flash Player finally being phased out in all the browsers this could have been a HUGE opportunity to flaunt the powers of Animate + CreateJS.
Regardless of the current state of CreateJS and Adobe's lack of concern, I still believe the Animate + CreateJS + GSAP combo gives people an amazing toolset for generative art, scripted animation and interactive gizmos. There's nothing else like it.
It's absolutely amazing what @danzen has been able to do with ZIM. Adobe should be stumbling over itself to throw money at that project, especially with its focus on kids / education / creativity. ZIM really makes CreateJS shine and I'm glad to see it being taken to the next level.
I totally understand that it isn't practical to maintain CreateJS without time or funding. Hopefully the community can find a solution that allows it to be enhanced, documented and supported. Thanks for doing all you did to give us old Flash guys hope for a second life.

A slack sounds useful, and worth setting up. I'd be less able to contribute in real time, but rather in stops and starts, given my timezone and available time.
An RFC process will help for making clear, collective decisions. Here's Emberjs' one https://emberjs.github.io/rfcs

Has anyone here got experience setting up governance of an open source project. I read https://producingoss.com a while back, which may have some good guidance.

Hi folks, here is an invite to a CreateJS Slack Workspace.  Please join here: http://shorturl.at/lISY9 and make an avatar for yourself ;-).  I have added a few channels and a couple posts under planning.  For the most part, discussion should happen there rather than here.  Any new folks to the issue, are welcome to post here to say hi... or just come on in to Slack.  At this point, the more the merrier.

That short url doesn't appear to work?

I had a read through the book recommended by jedateach and made some notes on things that would be good to think about.  Note, I'm not looking for answers to these questions here now; rather, just stating that they would be good to consider.
How will this consortium be organized?  The word consortium implies more of a 'consensus based' approach than 'benevolent dictator model'.  But then, will voting be necessary as a last resort?  And how would that work?  Would it be best to have someone from GrantSkinner have a final say?
How would a future release be managed/owned?  How would release candidates be tested?  Would it be good to have an overall project lead?  Would someone from Grant Skinner take responsibility for formal releases?
In terms of a distribution mechanism, how would a future release be made available?  What about maintaining and updating https://createjs.com/ ? Same question for the tutorials and documentation.
I think a development status page would be useful too.  It could show the current status of the project, releases, how to participate, bug fixes, etc.
The book also talks about setting the tone early and how it is important to get good social norms at the start, so that you set precedents and expectations for the future.  'Foster a collaborative mood' was a key takeaway for me.

Okay - here is a long URL https://join.slack.com/t/createjs/shared_invite/enQtOTY5NDM1Mzk5OTM2LWE1NzZhMzA3Yjk3YWQxMmY2MDI1MjA5YTU2Y2EwMThhNTVjMWU2NmE1ZGQ5MTMzMDU1OWY0OGZmMTUxYzg3Mjg - the short url works for me... strange.  Let me know if this works for you.  If not I can send out invites to e-mail addresses.

@owendwyer - let's move those excellent thoughts in to the Slack assuming we can get in!  Is a dictator tone good for collaborative mood ;-).

Hi!
Thanks, danzen, gskinner, and everybody else for providing all this useful information.
I was worried about the future of this suite but now I'm glad to know that CreateJS will keep moving forward.
And I want to contribute in some way.
Going now to Slack!
Thanks!

UP ! I am a developper who uses Create JS  for my project. I have chosen this Library because it was recommended by Adobe and Microsoft. Is it finished now ??? What about  the future ??? I see another alternatives as FabricJS or Konva but there is not a big team...  So ??? What about CreateJS ?

Hi Nicholas,
I'm in a similar position to you - lots of CreateJS projects that need to be maintained.
Unless I'm mistaken, support from Adobe has been non-existent for a long time now, and that is the main reason for the lack of work/updates.  However, CreateJS is still useful and generally a solid library to use.
My plan for the future is to monitor the Github and stay engaged with maintenance and fixes, so that my stuff keeps working on all browsers.  This is not something I'm all that worried or concerned about.  From time to time, issues will arise, but they will get fixed because the need for them to be fixed exists.  My guess/expectation is that CreateJS content will continue to work well for at least the foreseeable future (5+ years).
For future projects, I'm working with Pixi.js and want to try out Konva too.

Hi Nicholas,
I'm in a similar position to you - lots of CreateJS projects that need to be maintained.
Unless I'm mistaken, support from Adobe has been non-existent for a long time now, and that is the main reason for the lack of work/updates. However, CreateJS is still useful and generally a solid library to use.
My plan for the future is to monitor the Github and stay engaged with maintenance and fixes, so that my stuff keeps working on all browsers. This is not something I'm all that worried or concerned about. From time to time, issues will arise, but they will get fixed because the need for them to be fixed exists. My guess/expectation is that CreateJS content will continue to work well for at least the foreseeable future (5+ years).
For future projects, I'm working with Pixi.js and want to try out Konva too.

I didn't now Pixi, I think it should be a good alternative because some functionalities are similar (hit area, primitives)  and there is a big team. Some people talk about D3.JS too... Sorry I am French my English is not good

@nicolasgoudard - my interpretation of CreateJS is that it is complete.  It was built to provide a base to developers that improved the canvas.  If you are looking for advancements in the CreateJS world, please have a look at ZIM https://zimjs.com where hundred if not thousands of features have been added on top of CreateJS.  Over the five years of development, we have only had a couple issues with CreateJS and these have been solved.  In other words, CreateJS is very solid.  Please do not mistake lack of new things as a weakness.  In general, you do not want to keep adding to a base.  The base should be stable.  However, it does need to be maintained to make sure that it keeps working and there can be improvements as new technologies get introduced to the browsers or the canvas.  We have a large investment in CreateJS and have offered to help maintain it.  The organization of this has started already and updates will start happening over the summer.  We are working things out.

@danzen I'm interested in joining the CreateJS Slack you have setup. If it is still active, could you provide an updated invitation link? Thanks in advance.

Hi @masandoval here is an invite link - say hi in the #general section!  https://join.slack.com/t/createjs/shared_invite/zt-geomglro-4v3x4817xVRe61A~JvTjMw

Hi @masandoval here is an invite link - say hi in the #general section! https://join.slack.com/t/createjs/shared_invite/zt-geomglro-4v3x4817xVRe61A~JvTjMw

the link is not available.

Hi @masandoval - here is a new link (they expire after about three weeks) https://join.slack.com/t/createjs/shared_invite/zt-hibqyfrn-4a9_9V_xITRtLJ8d_63ALA See you there!

UP. If nothing is done to improve Bootstrap JS I think I will migrate to PhaserJS or Pixi

Hi @nicolasgoudard - would you like to join us on Slack and perhaps we can work together with the others there to solve the BootStrap JS issue you are mentioning.   https://join.slack.com/t/createjs/shared_invite/zt-kpw8ejsw-3IM6cKCaKUiugK__zdJnSQ

@danzen, would you be so kind as to open another invite link?  I'm interested to see if there's been any movement with regards to community support or stewardship.  Thanks.

@dblrsk sorry for the delay - missed this message.  Have adjusted this link to not expire!  https://join.slack.com/t/createjs/shared_invite/zt-ob9c68wy-zC_Gp5LAm3DS0r6ZjiEl6g

Was the "Consortium" or "ownership" question resolved?
What is the current plan for governance, maintenance, contributions?
(Sadly, Slack has hidden all the historical information... are we all getting a Pro license there?)

Thanks for re-upping the ping.
I have a few PRs for easeljs:

fix old reference in BitmapCache.getCacheDataURL()
tweaks to make ESM module recreate easy
tweaks so it works without 'window' in node.js

If you tell me the PRs are wanted and can be pulled, I'll expedite putting
them up.
On Wed, Nov 6, 2024 at 12:24 PM Dr Abstract @.***>
wrote:

Hi @jpeckj https://github.com/jpeckj - nothing new in the CreateJS
management. Slack is a pain that way and pretty expensive. At ZIM, we have
moved to Discourse at https://forum.zimjs.com - so anyone is welcome to
come there and ask about CreateJS or request things. We will see what can
be done. We are humming along fine at ZIM just launching ZIM 017 with Rive
support. CreateJS remains a very stable base.
—
Reply to this email directly, view it on GitHub
https://github.com/CreateJS/EaselJS/issues/1040#issuecomment-2460707268,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ATTAV2JBRBBDJG3YIZMYBT3Z7J3HVAVCNFSM6AAAAABMWXYU5WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINRQG4YDOMRWHA
.
You are receiving this because you were mentioned.Message ID:
@.***>

Thanks for re-upping the ping.
I have a few PRs for easeljs:

fix old reference in BitmapCache.getCacheDataURL()
tweaks to make ESM module recreate easy
tweaks so it works without 'window' in node.js

If you tell me the PRs are wanted and can be pulled, I'll expedite putting
them up.
On Wed, Nov 6, 2024 at 12:24 PM Dr Abstract @.***>
wrote:

Hi @jpeckj https://github.com/jpeckj - nothing new in the CreateJS
management. Slack is a pain that way and pretty expensive. At ZIM, we have
moved to Discourse at https://forum.zimjs.com - so anyone is welcome to
come there and ask about CreateJS or request things. We will see what can
be done. We are humming along fine at ZIM just launching ZIM 017 with Rive
support. CreateJS remains a very stable base.
—
Reply to this email directly, view it on GitHub
https://github.com/CreateJS/EaselJS/issues/1040#issuecomment-2460707268,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ATTAV2JBRBBDJG3YIZMYBT3Z7J3HVAVCNFSM6AAAAABMWXYU5WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINRQG4YDOMRWHA
.
You are receiving this because you were mentioned.Message ID:
@.***>


add little delay to allow sockets to be cleaned up after the launcher specs

Issue Number

Overview

[ ] I have added little delay to allow sockets to be cleaned up after the launcher specs

Comments

Hope this will do :man_shrugging:. Solved our problem in other test, as it seems that CI can be a bit slow at freeing up sockets after we cancel a worker. One second seems enough in other places.

I remember https://travis-ci.org/input-output-hk/cardano-wallet/jobs/535892104#L303, but that was jormungandr

Well, that's actually the same idea. I ran into this again with the bridge and did a bit of debugging. It appears that this little delay might solve the issue. At least, it doesn't cost much to try :man_shrugging:


Toward vs. towars

Just a consistency issue...
Sometimes we use toward:
aggression toward inanimate objects
increased aggression toward humans
Sometimes towards:
decreased aggression towards males
decreased aggression towards mice
increased aggression towards females
increased aggression towards males
increased aggression towards males in competition for females
increased aggression towards mice
submission towards male mice
My understanding is that American English favors toward while British English favors towards (see http://www.quickanddirtytips.com/education/grammar/toward-versus-towards)

As all but one MP term used "towards" I changed "increased aggression toward humans" to "increased aggression towards humans"


adds built-in support for anti-forgery tokens

Codecov Report

Merging #238 (6e980f0) into main (2c6b613) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              main      #238    +/-   ##
==========================================
  Coverage   100.00%   100.00%
==========================================
  Files           56        58     +2
  Lines         5377      5544   +167
==========================================
+ Hits          5377      5544   +167

Impacted Files
Coverage Δ

blacksheep/testing/messages.py
100.00% <ø> (ø)

blacksheep/server/application.py
100.00% <100.00%> (ø)

blacksheep/server/controllers.py
100.00% <100.00%> (ø)

blacksheep/server/csrf.py
100.00% <100.00%> (ø)

blacksheep/server/security.py
100.00% <100.00%> (ø)

blacksheep/server/templating.py
100.00% <100.00%> (ø)

blacksheep/server/websocket.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c6b613...6e980f0. Read the comment docs.