[BUG] Doesn't work with multiple remotes

Is there an existing issue for this?

[X] I have searched the existing issues

Describe the bug?
We're hosting our app on Heroku, to which we deploy using git. Therefore our local environments have an origin remote pointing to Github and a second heroku remote for deployments.
This heroku only has one branch, which is not our main/develop branch) and this creates issues when I try to fix migrations on my local machine.
To Reproduce

Have a remote with multiple origins, without the main branch existing on one of the origins.
Run ./manage.py makemigrations --fix -b develop (Though I suspect -b is not necessary)
Watch it fail

What OS are you seeing the problem on?
linux
Expected behavior?
I expected the command to just work.

DEBUG:git.remote:info lines: [' = [up to date]        develop    -> develop', ' = [up to date]        develop    -> origin/develop']
DEBUG:git.remote:head info : ["fb17c22cd7c51a81166749ce165d7c3a8433ae6d\t\tbranch 'develop' of github.com:hvntravel/hvn\n"]
DEBUG:git.cmd:Popen(["git", "fetch", "-v", "heroku", "develop:develop"], cwd=/home/jonas/Projects/hvn/hvn, universal_newlines=True, shell=null, istream=None)
DEBUG:git.cmd:AutoInterrupt wait stderr: b''
Traceback (most recent call last):
  File "/home/jonas/Projects/hvn/hvn/.venv/lib/python3.8/site-packages/migration_fixer/management/commands/makemigrations.py", line 60, in handle
    super().handle(*app_labels, **options)
  File "/home/jonas/Projects/hvn/hvn/.venv/lib/python3.8/site-packages/django/core/management/base.py", line 83, in wrapped
    res = handle_func(*args, **kwargs)
  File "/home/jonas/Projects/hvn/hvn/.venv/lib/python3.8/site-packages/django/core/management/commands/makemigrations.py", line 119, in handle
    raise CommandError(
django.core.management.base.CommandError: Conflicting migrations detected; multiple leaf nodes in the migration graph: (0306_delete_vrmsurvey, 0306_reservation_email_comms_force_active in vr).
To fix them run 'python manage.py makemigrations --merge'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "./manage.py", line 50, in <module>
    execute_from_command_line(sys.argv)
  File "/home/jonas/Projects/hvn/hvn/.venv/lib/python3.8/site-packages/django/core/management/__init__.py", line 381, in execute_from_command_line
    utility.execute()
  File "/home/jonas/Projects/hvn/hvn/.venv/lib/python3.8/site-packages/django/core/management/__init__.py", line 375, in execute
    self.fetch_command(subcommand).run_from_argv(self.argv)
  File "/home/jonas/Projects/hvn/hvn/.venv/lib/python3.8/site-packages/django/core/management/base.py", line 323, in run_from_argv
    self.execute(*args, **cmd_options)
  File "/home/jonas/Projects/hvn/hvn/.venv/lib/python3.8/site-packages/django/core/management/base.py", line 364, in execute
    output = self.handle(*args, **options)
  File "/home/jonas/Projects/hvn/hvn/.venv/lib/python3.8/site-packages/migration_fixer/utils.py", line 118, in wrapped
    res = handle_func(*args, **kwargs)
  File "/home/jonas/Projects/hvn/hvn/.venv/lib/python3.8/site-packages/migration_fixer/management/commands/makemigrations.py", line 109, in handle
    remote.fetch(
  File "/home/jonas/Projects/hvn/hvn/.venv/lib/python3.8/site-packages/git/remote.py", line 828, in fetch
    res = self._get_fetch_info_from_stderr(proc, progress)
  File "/home/jonas/Projects/hvn/hvn/.venv/lib/python3.8/site-packages/git/remote.py", line 702, in _get_fetch_info_from_stderr
    proc.wait(stderr=stderr_text)
  File "/home/jonas/Projects/hvn/hvn/.venv/lib/python3.8/site-packages/git/cmd.py", line 447, in wait
    raise GitCommandError(remove_password_if_present(self.args), status, errstr)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(1)
  cmdline: git fetch -v heroku develop:develop

Anything else?
Heroku Documentation: https://devcenter.heroku.com/articles/git#creating-a-heroku-remote
Code of Conduct

[X] I agree to follow this project's Code of Conduct

@jghyllebert This should be resolved in the latest release.

@jackton1 Thanks for the quick resolution!


How do you add text at the center of a doughnut chart?

Describe your question
How do you add text at the center of a doughnut chart?
Which Blazor project type is your question related to?

Client-Side

Which charts is this question related to?

Doughnut Chart

JavaScript equivalent
{
        ...
        var text = "75%",
        textX = Math.round((width - ctx.measureText(text).width) / 2),
        textY = height / 2;
        ctx.fillText(text, textX, textY);
        ctx.save();
        ...
}

Additional context
https://jsfiddle.net/cmyker/ooxdL2vj/

This response might be kinda late since I just recently got into ChartJS, my apologies.
I kinda had the same problem and was searching for a solution around here. At the end, I have found a solution.
I solved this by adding a negative padding on the Title (which puts the Title of the chart in the center), maybe this works for you as well.
Example:
CutoutPercentage = 95,
and
Title = new OptionsTitle { 	Display = true, 	Text = "title", 	Padding = -130,         FontSize = 40, }
Cheers

Hey, thanks for your reply! I actually asked this when I was interning at a company last year haha. Good to know that you were able to solve it. As far as I remember I had used CSS (absolute) positioning to center a regular span tag over the component. That worked since our app's usage was limited to laptop devices.


Make Default File Manager

Description
I've just had to rebuild my system and on reinstalling Files, I can no longer find the option to make Files the default file explorer. Has this feature be moved or removed?
Steps To Reproduce
No response
Expected behavior
Go to Settings / Experimental
Find the 'Make default' option
Files Version
Version: <IP_ADDRESS>
Windows Version
Windows 11 Home, 21H2, 22000.556
Relevant Assets/Logs
N/A

At Microsoft request the option was removed from the Store version. It's available for the sideloaded version.

Dickheads! Thanks for the info will try sideloading. Does the sideloaded
version update? Or will I just need to keep an eye out for updates?
Thanks again.
Chay MacTavish
+61 (0)419 461 632
chaymactavish.com https://www.chaymactavish.com
On Fri, 8 Apr 2022 at 16:04, Marco Gavelli @.***> wrote:

At Microsoft request the option was removed from the Store version. It's
available for the sideloaded version
http://files.community/download/preview.
—
Reply to this email directly, view it on GitHub
https://github.com/files-community/Files/issues/8880#issuecomment-1092471615,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ANHJ73UUUZ5FEWCEMORMO2LVD7D57ANCNFSM5S3K7EDQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

Sideloaded version has auto update 👍.
The link above is for the beta/preview version. On files.community you can also find the "stable" sideloaded package but it currently has a bug for setting Files as default.


Update default branch in documentation to 'main'.

Fixes #4092

Thank you for this PR and the raised issue! :confetti_ball:
Indeed, we ( i, me and myself) forgot to update the documentation when I changed the default branch.
As usual in this repository, I won't directly merge your contribution.
But can you sign our CLA as I will be able to cherry-pick your contribution?
(Note that I will add other places where I missed the update as well)

@reftel gentle ping regarding the CLA. We have a release coming vey soon and would like to merge your contribution.

CLA signed.

Thank you!
Merged with ea97af02f5ba6d46f61937269a83cd2866f74292


JSON Schema consistency

Summary
Playing with https://quicktype.io/ we discovered a couple of inconsistencies in the JSON schema docs
Details

ParameterType required fields listed id twice
ParameterType required fields listen children but it was not defined
TestCaseFinished required fields listed testSteps but it's not needed on that message

Motivation and Context
Cleaning up the JSON schema so other tools could understand and use it.
How Has This Been Tested?
Using npx quickcheck messages/jsonschema/*.json tmp.rb
Types of changes

[x] Bug fix (non-breaking change which fixes an issue).
[ ] New feature (non-breaking change which adds functionality).
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected).

Schema validation
In order to have continuous validation of the schema consistency, ajv-cli as been added and a validation target has been added to messages Makefile. That way json-schema consistency can be checked easily and is now part of the CI.

Since generated code is added to git, you have to run ˋmakeˋ from the ˋmessagesˋ directory and commit the modified files (if any).

I've also added a new Markdown code generator, so our messages/messages.md is updated automatically.


checkpoint of SLEGAN models

Is implemented the way to save the chekpoints of the models in SLEGAN? The train.py need a --model-load-path but dont work with the GenIter.h5  file generated. There is a solution?

If you run train.py all the way through, then it will save the checkpoints by default. I'm not sure why model-load-path is happening in your second question. Could you post the error message here?

Which are the checkpoint file and  how I load its on the train.py? In general, there is no error, but the train start from scratch each time, even if I set some model-load-path

I see. It actually looks like train.py is missing a part for loading checkpoints. We will update it asap.
In the mean time, you can do the following:
Add the following lines after Line 68 of train.py,
    gen_param_path = args.model_load_path
    with nn.parameter_scope(scope_gen):
        nn.load_parameters(gen_param_path)

okok, I'll add it, thanks.


Fragment meta

Resolves #751

Description
Current approach to metadata is to replace the field component of a fragment with the metadata at transform time, this has been a headache.

Field has different shape depending on serialized or unserialized which is confusing
transforms don't give access to all information needed to get ahold of the metadata so work arounds are needed.

Proposed Changes
Request V2 will have the following approach to metadata

Metadata moved onto a lazy fetched property on the base fragment.
lazy based fetch will fetch from metadata service looking up info from the parent request v2 model if available.
Factories are provided to attach meta to newly created fragments that are not part of a request yet.

Note: this PR contains typescript rebase from master.
License
I confirm that this contribution is made under an MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.

Yeah, it'll require a rebase. Once we merge this in, I can rebase the feature branch and then I'll clean that up.


Suggest a library to parse string commands

In execa it allows users to use a single string as command, like execa.command('foo bar -m "message with space"')
I understand that tinyexec is trying to be as lightweight as possible, while string commands can be easily migrated if it's hard coded, but it would be tricky when you have the command from user input.
A straightforward solution is that people might do:
const args = command.split(' ')
const process = x(args[0], args.slice(1))

But this would be an extremely dangerous approach as it didn't handle many cases well - while a huge amount of developers might not even realize this when writing such code.
I would suggest documenting a few recommended tiny libraries that will parse shell args safely to cover this missing feature when migrating execa to tinyexec, for example.

What I found was https://www.npmjs.com/package/shell-quote
Or maybe tinyexec could have that feature as a tree-shakable export or so directly?

a lot of the bloat in other exec packages is to support stuff like this, so I think it belongs in another package for sure
I'm not sure there's any already established package to do it though. may be a good opportunity to create a new tiny alternative if so 👀

Hey, I just built small tokenizer for commands and arguments
https://github.com/TrySound/args-tokenizer
import { tokenizeArgs } from "args-tokenizer";
import { x } from "tinyexec";

const [command, ...args] = tokenizeArgs("ls -la");
const result = await x(command, args);
console.log(result.stdout);

@43081j Good to close?


Normalize volume of drift reports

As volume of current and reference data is always gonna be different, need to customize the preset such that, plot uses different y-scale for reference and current data.
Tried creating a custom metric for drift reports, but there is not much information regarding how to implement plotly in the code.
Also why evidently is only using bar graphs, i would like to plot histogram

trying to create plots like this.

Hi @VaishnaviMendhe,
You can use the "percentage" switch on the plot to switch from absolute values to % - this will help align the distributions when the reference and current datasets have different sizes. Basically, you can switch from:
Absolute values:

To percentage values:

Evidently, a bar chart represents a distribution, so it works like a histogram but is faster.
If you do not see this switch "button" on your plots, make sure you are using the latest Evidently version.
Does this solve an issue for you?

Thats awesome, Thanks @elenasamuylova
Updating evidently version will resolve my problem, hope this won't break anything else.

Hi @elenasamuylova , could I set the data distribution default to "percentage"? Thanks a lot!

Hi @dehiker - there is no such parameter, I am afraid. Both visualizations are always available, and you can manually switch between them when viewing the plots.


create_keychain broken

New Regression Checklist

[x] Updated fastlane to the latest version
[x] I read the Contribution Guidelines
[x] I read docs.fastlane.tools
[x] I searched for existing GitHub issues

Regression Information

Breaking version: [2.185.1 ]
Last working version: [2.185.10]

Regression Description
The change in the version changed the options from:

is_string is slowly being replaced by type to make the docs clearer, options safer, and Swift generation more correct.

How ever in create_keychain this affected the timeout value, as per the DOCS:

timeout
timeout interval in seconds. Set false if you want to specify "no time-out"
300

How ever timeout is now an Int NOT a Bool so you CANNOT set it to "false" anymore
Complete output when running fastlane, including the stack trace and command used
Environment
✅ fastlane environment ✅
Stack

Key
Value

OS
11.4

Ruby
2.6.3

Bundler?
false

Git
git version 2.31.1

Installation Source
/usr/local/bin/fastlane

Host
macOS 11.4 (20F71)

Ruby Lib Dir
/System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/lib

OpenSSL Version
LibreSSL 2.8.3

Is contained
false

Is homebrew
false

Is installed via Fabric.app
false

Xcode Path
/Applications/Xcode.app/Contents/Developer/

Xcode Version
12.5

Swift Version
5.4

System Locale

Variable
Value

LANG
en_GB.UTF-8
✅

LC_ALL

LANGUAGE

setting the timeout to an Int (3600) etc fixed the issue how ever that's not what the documentation says you can do

Hello @bukira
I think, I broke it in the last release...working on it right away 👍

Yes you did, no problem, for now im sending an Int that's big enough for my use (Bitrise)  :-)

Yes you did, no problem, for now im sending an Int that's big enough for my use (Bitrise) :-)

Nice, so we already have workaround <--> passing a big enough integer number for the timeout param.
btw, just now, open the PR to fix this regression issue: https://github.com/fastlane/fastlane/pull/18894
Thank you very much for reporting this issue! 🙏


100% coverage

coverage is called across all the builds to enable coverage for python version dependant code.
also fixed a few issues and redundancies related to untested code

Coverage increased (+4.4%) to 100.0% when pulling 678e70a50685fc86ead04a1781f9dfaba7deac4e on test-coverage-possibilities into 222c94fbac47147f987b254be3819c8729f06db4 on master.


When memcache is enabled, all queries result same values

I have a Model ImplementingAgency.php
ImplementingAgency extends ActiveRecord\Model {
static $cache = TRUE;
function Targets() {
$count = Model1::find_by_sql("select count(id) as total where implementing_agency_id = {$this->id}");
return $ocunt[0]->total;
}
function Assignments() {
$count = Model2::find_by_sql("select count(id) as total where implementing_agency_id = {$this->id}");
return $ocunt[0]->total;
}
}
Now the problem is, when i call these two functions on same page, both return same result when cache is set to TRUE and when i set it to FALSE, both starts returning correct result.
Can you please tell why?

$this->id evaluates to the same value in both cases? Then I think queries are cached over all models and not model independent..

Yes they refer to the current ImplementingAgency class instance from database. But i couldn't understand your explanation here. If you could please tell me how's it working?


Assignmentpoll slide

Ready for review and merge.

Fixed remarks. Rebased.

ready for review

One last comment.

All done


binary: Add tests for invalid inputs

alphabetic characters at beginning, middle, end
invalid digits

Test version is added (was previously unversioned)
Tested by ensuring that a solution that never errors gets a test
failure:
--- FAIL: TestParseBinary (0.00s)
        binary_test.go:50: ParseBinary(foo101) returned 5 and no error.  Expected an error.

Tested by ensuring that a solution that always errors gets a test
failure:
--- FAIL: TestParseBinary (0.00s)
        binary_test.go:46: ParseBinary(1) returned error "hard drive on fire, cannot convert to binary right now".  Error not expected.

Closes #271

Don't merge this yet; we shouldn't check the binary output value if the input was invalid (only check that there's an error).

OK, it's good now.

Looks good.


Inquiry Regarding Resource Utilization and Associated Costs for GPT-4 and GPT-3.5

Dear Team,
First and foremost, I'd like to express my deep appreciation for the excellent work you have accomplished in this project. The level of professionalism and detail in your work is truly commendable.
As I'm looking forward to running your code, I am trying to estimate the associated costs. I was wondering if you could provide a rough estimation for the computational cost of running, for instance, 150 prompting iterations on both the GPT-4 and GPT-3.5 models?
This information would be highly beneficial in planning for my resource allocation. I understand the cost might vary based on several factors, however, any approximation or range would be greatly appreciated.
Thank you for your attention and assistance with this matter.
Best Regards.

For me, the cost of 160 iterations, was ~$40
The training took about 6 hours on default settings.
In my repo I posted a checkpoint of 160 iterations

For me, the cost of 160 iterations, was ~$40 The training took about 6 hours on default settings.
In my repo I posted a checkpoint of 160 iterations

Thanks for your response!


NavigationView with Android

I want to create custom NavigationView with (android.support.design.widget.NavigationView).I created it with ViewGroupManager.However,there was something strange with menu checked mark,the menu item with show the checked mark after double click,no the single click.

Please use Stack Overflow and tag your question with react-native for asking these kinds of questions: http://stackoverflow.com/questions/tagged/react-native
Many people from the community hang out on Stack Overflow and will be able to see and likely also answer your question. Using Stack Overflow for questions also helps us use Github issues to keep track of bugs that need to be fixed.


Prevent sending of 0 Fiat transaction

Go to Send activity, switch to fiat send using up/down arrow control:

Leave the amount blank and press send. App will allow you to send zero amount.
Fix: App shouldn't allow you to send zero fiat amount.

PR merged. Closing the issue.


Fix/26669 lhn logic for paid reports

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/26669
PROPOSAL: https://github.com/Expensify/App/issues/26669#issuecomment-1723148268
Tests

Log in as a workspace member in one tab (or device) and as a workspace owner in another.
As the member request money from the workspace
As the owner pay for the request
As a member you should see policy expense chat lie this ([workspace name] paind [amount] [payment method])

Verify that there are no other changes in the other list items' secondary texts.

[x] Verify that no errors appear in the JS console

Offline tests

n/a
QA Steps

Log in as a workspace member in one tab (or device) and as a workspace owner in another.
As the member request money from the workspace
As the owner pay for the request
As a member you should see policy expense chat lie this ([workspace name] paind [amount] [payment method])

Verify that there are no other changes in the other list items' secondary texts.

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

for policy admin:

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

bump @mananjadhav to review!

@koko57 @mountiny I was testing this on Web. While the workspace change is fine, I can see Unavailable Workspace paid xxx elsewhere. This was 1:1 IOU. Attaching the screenshot.

@mananjadhav thanks! I'll check it today

@mananjadhav @mountiny @JmillsExpensify I see now that this line is now passing the payer's name (not sure which commit introduced this change exactly, but in the commit history I see many applying this change or then revert it back). While I was working on the issue it wasn't passed https://github.com/Expensify/App/blob/95c9e4743f44ca42ece2c6ac56259b911d5feafc/src/libs/ReportUtils.js#L1459
So for now I will remove this logic https://github.com/koko57/App/blob/2421b63e7c830234af8a405d1f53eba90a26837f/src/libs/OptionsListUtils.js#L401-L403 because it introduces this regression  and now after merging with main I see doubled workspace name.

@mananjadhav ready for re-review 🙂

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

@mountiny All yours.

🚀 Deployed to staging by https://github.com/mountiny in version: 1.3.75-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.75-12 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/mountiny in version: 1.3.76-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.76-6 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅


Add a security Post Voter

Implement https://github.com/symfony/symfony-demo/issues/440 feature.

[x] Add more code comments and doc references

Following some references and recommendations in:

https://symfony.com/doc/current/components/security/authorization.html
http://symfony.com/doc/current/security/voters.html
https://stovepipe.systems/post/symfony-security-roles-vs-voters (@iltar blog)

Any suggestion is welcome!

Rebase with master!

@yceruto I wanted to add a security voter since day one. Thanks for making it happen!


Figure out how to avoid shipping fauxhai with chef

Right now we're shipping fauxhai with the chef package because we use it for testing chef-utils. It's 8 megs on disk and it would be great to avoid shipping it since it's not used on the customer side of things.
Possible solution:
Create a fauxhai-slim gem that doesn't include the actual dump files or the binary since fauxhai the library will reach out the github to download any dump files it needs. This way we could still test chef/chef, but avoid shipping 8 megs of ohai dumps.

We did this


fix: update repo and image urls

@rarkins Looks like the pipeline does not have permission to create the ghcr.io repository, could you do the follwing for me, please?:

Log in into ghcr.io: https://docs.github.com/en/packages/working-with-a-github-packages-registry/working-with-the-container-registry#authenticating-to-the-container-registry
Install regctl, either:
a. Run go install github.com/regclient/regclient/cmd/regctl
b. Or download a pre-built binary: https://github.com/regclient/regclient/releases/tag/v0.3.9
Run:

regctl image copy \
  ghcr.io/maxbrunet/renovate-approve-bot:1.0.0 \
  ghcr.io/renovatebot/renovate-approve-bot-bitbucket-cloud:1.0.0

Since you are owner of the org, you should have permission to create this repository on push, this will copy the image (including all the architecture), then I should be able to do the others.

Nervermind, the next release past
https://github.com/orgs/renovatebot/packages?repo_name=renovate-approve-bot-bitbucket-cloud


Browse notes by directory structure

Hi,
Noteless is nice and sleek, but for the purpose of interoperability with other Markdown editors (e.g. desktop apps like Obsidian), I'd love to have it center around a standard directory structure and be able to just read Markdown files with links and tags. The current structure just makes it very unnatural to use Noteless as the mobile front for an existing Markdown repo.

You can currently already enable "Show virtual tags" in the settings to browse notes by subdirectory. As far as I understand you also want to create new notes in a subdirectory, right?

Yes, in essence what I want (and I'm sure many users will appreciate) is
interoperability with desktop Markdown editors, and most of these (at least
the standard ones) are based on a directory view.
On Sat, Nov 28, 2020, 17:08 redsolver<EMAIL_ADDRESS>wrote:

You can currently already enable "Show virtual tags" in the settings to
browse notes by subdirectory. As far as I understand you also want to
create new notes in a subdirectory, right?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/redsolver/noteless/issues/64#issuecomment-735242277,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACRZ2YDUKALCXSXLQJDHHYLSSEHAPANCNFSM4UDQFDWA
.

Noteless aims to be compatible with Notable (https://notable.app/) which uses a flat directory structure. Maybe I will add support for interoperability with other directory structures of other desktop apps in the future.

I just published Version 1.4.6 (https://github.com/redsolver/noteless/releases/tag/v1.4.6) which contains a new experimental "Dendron" mode which can be enabled in the settings. This mode improves compatibility with other Markdown-based note-taking tools which save all Markdown files directly in one root folder together with attachments (images, ...) and have filenames which are different from the Markdown title. With this mode you can basically just select a folder in the settings and Noteless then loads all Markdown files in that folder. In addition, it shows the filename and path in the note list and editor.


Added rotation support

With this change, the canvas transform is update properly for viewport rotation.
It also makes this plugin not conflict with jQuery, and cleans up a few white space things (I hope you don't mind).

Thanks for the merge! Let me know if you find any problems with these changes :)


Logical bug in simulator.js

Bug Description
There is a logical bug in simulator.js file:
https://github.com/louislefevre/node-red-contrib-quantum/blob/21a1393ac98cc28d84ef915ddeedb23a655b8ee7/quantum/nodes/simulator/simulator.js#L39-L49
if (node.qubits.length == 0) node.qreg = {};
else if (Object.keys(node.qreg).includes(msg.payload.registerVar))

should be changed to
if (node.qubits.length == 0) node.qreg = {};
if (Object.keys(node.qreg).includes(msg.payload.registerVar))

otherwise it won't properly count the first qubit in first quantum register.
Additional Information
sample console log output:
{}
{ qr1: { total: 2, count: 1 } }
{ qr1: { total: 2, count: 1 }, qr0: { total: 2, count: 1 } }
{ qr1: { total: 2, count: 2 }, qr0: { total: 2, count: 1 } }

there are 4 valid inputs, 2 quantum registers with 2 qubits each, but the first qubit in the first quantum register didn't get counted.
System Information

Node.js Version: v16.5.0
Operating System: WSL2 (Ubuntu 20.04)

Thank you for noticing this, I could not test the code for registers since the shell was not working with registers at this time.
The code for qubits only was tested but not using registers.
I'll look into it, thank you.

Thank you for noticing this, I could not test the code for registers since the shell was not working with registers at this time.
The code for qubits only was tested but not using registers.
I'll look into it, thank you.

don't worry, I have fixed it on my local branch where I also fixed the registers issue, I will open a PR later today and apply all fixes together.


CAS-331: mayastor-tests: Remove ini file usage

Legacy INI style configuration was been deprecated in SPDK 20.04 and
will be removed in a future release.
Remove use of ini style configuration when starting Mayastor by
converting them to yaml format Mayastor config (test_nexus) or
dropping it altogether (test_rebuild, as it was actually unused).
Change the first argument to common.startMayastor to take a Mayastor
config instead.
Note that test_nexus still has a standalone instance of SPDK that uses an ini file, this will be addressed in CAS-430.

bors merge


File system public routes & rewrites

Hi!
First of all, we love Zeit and all the great stuff you are doing. 👏
We're currently expirementing with custom routes (https://github.com/zeit/next.js/issues/9081), which we want to use for intl. We're experiencing inconsistencies between local development and when deployed to now.
Here's our demo repo: https://github.com/Corjen/next-custom-routes and deployment url: https://test-dynamic-routing.now.sh/en/test
Locally, url's like / /test and /collection give a 404, which is expected as we have set useFileSystemPublicRoutes to false in next.config.js. Once deployed though, the urls are available, although the rewrites are also working.
Is this intentional, a bug or are we missing something? Thanks for looking into to it!

Hi, we don't currently support disabling useFileSystemPublicRoutes when deploying and was originally meant for usage with a custom-server which is not ideal with serverless environments. If you would like to only rewrite to these pages you could prefix the pages with __ and then rewrite to that e.g. __home.js or another value so that they are less likely to be visited but to rewrite to them they need to have be available at some endpoint.

Hi, we don't currently support disabling useFileSystemPublicRoutes when deploying and was originally meant for usage with a custom-server which is not ideal with serverless environments. If you would like to only rewrite to these pages you could prefix the pages with __ and then rewrite to that e.g. __home.js or another value so that they are less likely to be visited but to rewrite to them they need to have be available at some endpoint.

Makes sense 😃 Thanks for the reply!


Circles as paths

Fixes #119. This all worked perfectly fine for me. I just uncommented the code that Alison had written before and then added the tricks for rescaling the radii on zoom. I tried to limit the number of times the paths were being recalculated, so I never overwrote the national view radii. I only recalculated the paths for the current category when you zoom, or if you are not in the national view when you change categories. I don't think it takes much to recalculate, but just wanted to limit it as much as possible.
I did look into the weird flashing that David mentioned on Slack (and Laura has mentioned before). Comments captured here #271 (I don't want this issue to be held up by that discussion).
I was not able to locally test this on mobile. Need a mac to do that.

The code looks solid to me, and yes, it's snappier and I wish we could use it...it's just that I'm still seeing blank maps here and there, most often for Total.
I guess I'll go with tentative approval & merge, knowing that we know how to revert this, so that we can test on more devices on dev. But I'm going to keep #119 open because we need to test and decide whether we can keep this.

Man, that's so bizarre. I hope that's the only issue, but then I also want to know why in the world that's the case!

So this still does that to you on dev?


Dev/origin/september

First testimonial on index, cohort 4 teachers and teaching assistants updated on instructors page

@ariellouise  - this deploy failed. you can look at the logs here: https://app.netlify.com/sites/careersincode/deploys/6337338d6e61770008f3afe1

Closing this to use v4 branch instead


perf: Upload DAG branch only on putPath

Description
Pins only the new nodes along a branch on putPath. Also updates @geo-web/content to not download entire CAR on getPath.
Issue
closes #356
Checklist:

[x] My commit message follows the Conventional Commits specification
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have tested my code
[x] My changes generate no new warnings
[x] My PR is rebased off the most recent develop branch
[x] My PR is opened against the develop branch

Alert Reviewers
@tnrdd @gravenp

@codynhat I'm having issues getting this to build.


Any plans on supporting osx-arm64

Hi,
Do you have any plans on supporting osx-arm64 builds?
Thanks!

i can't tell, currently i am running macos on VirtualBox, and it's 10x slower then the real machine without graphics card, i can try setting up the corss-build environment these days, and will let you know if there is any progress.

osx-arm64 has been supported in v<IP_ADDRESS>
to test if it works

download .net sdk 6.0.418(must exactly this version, only v6.0.26 hostfxr for testing)
create a simple console project
install NetBeauty2 v<IP_ADDRESS>
build with dotnet publish -r osx-arm64
run the app on a apple silicon machine

let me know if it works


OpenSSH 7.2p2 no longer installs slogin command

Unable to find /usr/local/bin/slogin symlink or /usr/local/Cellar/openssh/7.2p2/bin/slogin anymore.
Tested on OS X 10.11.4.

Upstream killed it, but I'm sympathetic to re-adding it temporarily if there's demand to do so I guess.

@DomT4 so the upstream maintainer now mandates use of ssh instead of slogin? Wow. Kinda surprised.

Looks like it. It was yanked from a couple of the portable specs as well. Debian's Changelog acknowledges the removal as well here:

Restore slogin symlinks for compatibility, although they were removed
upstream.

@DomT4 OK I understand your explanation. I don't mind if you ditch slogin altogether.

I might put the symlink back for a release cycle for Homebrew, given upstream seem to have barely announced its removal and that might surprise others as it did you.

@DomT4 I also think the upstream people should have more publicly announced the removal. I will follow your decision.

Fixed by https://github.com/Homebrew/homebrew-dupes/commit/77cd263de1feec45b6874023d36e770c6b917379.
You'll need to brew reinstall openssh if you want the symlink back urgently, otherwise it'll re-appear the next time the version/revision is bumped. Thanks for the report!

@domT4 Thx for reviewing and explaining this! :+1:


Select query scopes

Hi, As we talked in the #1409 pull, I add the scope options on the selects, in both, dropdown and multiple.
I do not know if it is the best way to do it, but I found it practice.
This also serves for dynamic scopes.
On the bread you can put
{
    "relationship": {
        "key": "id",
        "label": "name",
        "scopes": [
            "currency"
        ]
    }
}

or, if you want to use dynamic scope,
{
    "relationship": {
        "key": "id",
        "label": "name",
        "scopes": [
            "currency,5"
        ]
    }
}

where currency is the name of the scope and 5 is the parameter.
The query may be
relationshipClass::currency(5)...
You can also pass more than 1 scope
{
    "relationship": {
        "key": "id",
        "label": "name",
        "scopes": [
            "currency,5",
            "active"
        ]
    }
}

and again your query:
relationshipClass::currency(5)->active()...
I hope it is useful
Regards!.

I like this. Great job!

Thanks for this @gabrieljaime! @akazorg, do you have a few minutes to test this? I'm going to be really busy over the next couple weeks.

Hey There,
Thanks for this. I can still merge it in, but the way of doing relationships in 1.0 will be new. Checkout this quick video: https://www.youtube.com/watch?v=gnSJ0Z2Fmso&t=53s
Thanks. Talk to you soon.

Actually I was going to close this out since the old way of adding relationships are going to be obsolete soon.
Feel free to open this as another PR for 0.11.4, if you still want to use it and I can look at merging it in there.
Also, checkout the new way that relationships are being created in the dev-master and see if you can implement this in there :)
Thanks a ton! Talk to you soon.


headerview, footerview, emptyview doesn't work

In my project, I add headerview, footerview and emptyview, but it's seem to not work.
Here is my code:
        mListView = (StickyListHeadersListView) view.findViewById(R.id.sticky_list_view);
        mListView.addHeaderView(new View(getActivity()));
        mListView.addFooterView(new View(getActivity()));
        View emptyView = View.inflate(getActivity(), R.layout.empty_view, null);
        ((ViewGroup) mListView.getParent()).addView(emptyView);
        mListView.setEmptyView(emptyView);

In my project emptyview seems not work. My code is similar to "msdx",
View emptyView = inflater.inflate(R.layout.empty_view, (ViewGroup)rootView, true);
mStickyList.setEmptyView(emptyView);
mStickyList.setAdapter((StickyListHeadersAdapter) mListAdapter);

My layout empty_view has  as root dom.
Thanks in advance.

The same issue for me, setEmptyView doesn't work and no empty view shown


[Question] Unity ios cloud message with image

What is your question?
I have android and ios build from unity 2021.3.24. And i want to send push notification with image. In Android it works fine

but on ios its dont work. Image missing

Can you help with this. Maybe i made some mistake
I use this variant for sending messages

Firebase Unity SDK Version
12.1.0
Unity editor version
2021.3.24
Installation Method
.unitypackage
Problematic Firebase Component(s)
Messaging
Other Firebase Component(s) in use
Analytics, Crashlytics, Messaging, Remote Config
Additional SDKs you are using
No response
Targeted Platform(s)
Apple Platforms, Android
Unity editor platform
Mac
Scripting Runtime
IL2CPP
Release Distribution Type
Pre-built SDK from https://firebase.google.com/download/unity

any updates?

Hey @jedai7, sorry this took a while. Upon testing, it seems that this also happens on native iOS. Could you file an issue to the Firebase iOS SDK?
For context, the Firebase Unity SDK acts as a wrapper, and if the underlying SDK encounters the issue, then the fix would likely be applied on the native SDK.
That said, I'll go ahead and close this thread. Feel free to reply back here in case of any updates. Thanks!

Hi @jedai7, our colleagues informed me that it could be an issue specifically with our Unity SDK. Let me investigate this further and reply back once I have updates to share with you.


Make LLVM 11 compile under Ubuntu 20.04+

This should be a non-invasive patch that fixes this: https://github.com/llvm/llvm-project/commit/b498303066a63a203d24f739b2d2e0e56dca70d1 (it just adds #include <limits>)
With this patch LLVM 11 compiles under (at least) Ubuntu 20.04, 22.04, and 23.04. (without, LLVM will not compile with newer Ubuntu/gcc versions)

Verified under ubuntu 22.04. Compilation fails with
[1923/1947] Building CXX object utils/benchmark/src/CMakeFiles/benchmark.dir/benchmark_register.cc.o
FAILED: utils/benchmark/src/CMakeFiles/benchmark.dir/benchmark_register.cc.o
/usr/bin/c++ -DHAVE_POSIX_REGEX -DHAVE_STD_REGEX -DHAVE_STEADY_CLOCK -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/root/build/utils/benchmark/src -I/root/llvm/utils/benchmark/src -I/root/build/include -I/root/llvm/include -I/root/llvm/utils/benchmark/include -I/root/llvm/utils/benchmark/src/../include -fPIC -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-maybe-uninitialized -Wno-class-memaccess -Wno-redundant-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wno-comment -fdiagnostics-color -ffunction-sections -fdata-sections  -std=c++11  -Wall  -Wextra  -Wshadow  -pedantic  -pedantic-errors  -Wfloat-equal  -fstrict-aliasing  -fno-exceptions  -Wstrict-aliasing -O3 -DNDEBUG -std=c++14 -MD -MT utils/benchmark/src/CMakeFiles/benchmark.dir/benchmark_register.cc.o -MF utils/benchmark/src/CMakeFiles/benchmark.dir/benchmark_register.cc.o.d -o utils/benchmark/src/CMakeFiles/benchmark.dir/benchmark_register.cc.o -c /root/llvm/utils/benchmark/src/benchmark_register.cc
In file included from /root/llvm/utils/benchmark/src/benchmark_register.cc:15:
/root/llvm/utils/benchmark/src/benchmark_register.h: In function 'void AddRange(std::vector<T>*, T, T, int)':
/root/llvm/utils/benchmark/src/benchmark_register.h:17:30: error: 'numeric_limits' is not a member of 'std'
   17 |   static const T kmax = std::numeric_limits<T>::max();
      |                              ^~~~~~~~~~~~~~
/root/llvm/utils/benchmark/src/benchmark_register.h:17:46: error: expected primary-expression before '>' token
   17 |   static const T kmax = std::numeric_limits<T>::max();
      |                                              ^
/root/llvm/utils/benchmark/src/benchmark_register.h:17:49: error: '::max' has not been declared; did you mean 'std::max'?
   17 |   static const T kmax = std::numeric_limits<T>::max();
      |                                                 ^~~
      |                                                 std::max
In file included from /usr/include/c++/11/algorithm:62,
                 from /root/llvm/utils/benchmark/include/benchmark/benchmark.h:175,
                 from /root/llvm/utils/benchmark/src/internal_macros.h:4,
                 from /root/llvm/utils/benchmark/src/check.h:8,
                 from /root/llvm/utils/benchmark/src/benchmark_register.h:6,
                 from /root/llvm/utils/benchmark/src/benchmark_register.cc:15:
/usr/include/c++/11/bits/stl_algo.h:3467:5: note: 'std::max' declared here
 3467 |     max(initializer_list<_Tp> __l, _Compare __comp)
      |     ^~~

But applying patch to LLVM source tree directly looks somewhat aggressive, IMO.
Replacing defined variables for cmake as
cmake -G "Ninja" \
      -DCMAKE_BUILD_TYPE=Release \
      -DLLVM_TARGETS_TO_BUILD="X86" \
      -DLLVM_BINUTILS_INCDIR=/usr/include \
      -DLLVM_ENABLE_PROJECTS="clang;compiler-rt" \
      -DLLVM_BUILD_TESTS=OFF \
      -DLLVM_INCLUDE_TESTS=OFF \
      -DLLVM_BUILD_BENCHMARKS=OFF \
      -DLLVM_INCLUDE_BENCHMARKS=OFF \
      ../llvm

may be better. It disables the tests and benchmark, and thus fixes the issue.

Hey!
Thanks for looking at this PR.
This is interesting... The error you get is exactly the error that the patch fixes! Are you sure that the patch was applied correctly?
If your solution works as well you could also use that. The goal would be achieved as well :)
Thanks!

Sorry for the misunderstanding caused by my comment...
Your patch does work, and I just want to provide the error msg for reference and suggest a less aggressive solution😂

Thank you all.

@mboehme sorry my bad :)


Fix race condition for Node reboot issue

Module controller needs to be scheduled in case node has been rebooted and becomes ready. Module controller get the target nodes for the modules based on the selector and the NonSchedulable taint of the node. Sometimes node's Ready condition is set while the taint is not being removed, which causes the reconcilation loop to skip DS generation, and we have not addition event  scheduled. This PR changes the condition for reconciliation kick-off: now we are waiting for node to become scheduled, instead of just ready
/cc @yevgeny-shnaidman @bthurber

/lgtm


Avoid using JVM HashCode on Http 2 DefaultStream

Motivation:
relying on DefaultStream's hashCode forces calling into JVM's strategy for identity hash code
Modifications:
Use the stream's id to identify DefaultStream
Result:
Faster active stream insertion, saving producing JVM's hashcode

This has been detected on the http 2 hello world-like benchmarking, see (in violet)

I'm not sure is correct, still, so feel free to drop it in case.

The stream id is a peer controlled value we read off the network. I'm hesitant to use it here, in case it opens us op to session hijacking vulnerabilities. I'd rather we pulled a hashcode off an atomic counter, and retained object identity for equality.

@chrisvest looking at the code paths where it is used, it shouldn't happen (because we check upfront the expected next id to create, and removal happen from within the stream itself), said that, better be safe then sorry, and we can skip using an atomic counter here, given that the default stream code path is single threaded (you can verify it by checking the stream id check before, which uses thread unsafe fields)

Just fyi, @chrisvest I'm recently receiving hints from users which wrongly compare http 1.1 Vs 2 (very wrongly, cause the power of http 2 is beyond hello world use cases), but effectively there are few low hanging (and some not so low) which could reduce a lot the stream management cost (creation and notification), plus other improvements related known header name lookups (addresses elsewhere, in another pr), and I am trusty, we can get very similar performance by fixing everything, assuming code won't suffer too much from this effort.

@chrisvest I've added a commit which is leaving equals as it is and allowing ConnectionStream (which extends DefaultStream, but is not placed in the same linked hash set)  to behave as it is now.

@franz1981 thanks a lot!


[EVM-Equivalence-YUL] Optimize opcodes

What ❔
This PR optimizes opcodes by:

Moving loop processing in a function and marking it as noinline. This removes a lot of unneeded spills and reloads generated by the compiler.
Combining checks for pop and push. LLVM will optimize these checks into a single comparison.
Adding always inline to warmAddress address function. This forces LLVM to inline warmAddress function in all places.

Why ❔

Checklist

[x] PR title corresponds to the body of PR (we generate changelog entries from PRs).
[ ] Tests for the changes have been added / updated.
[ ] Documentation comments have been added / updated.

@jrchatruc PTAL. Improvements can be seen here (please note that this PR contains one pending LLVM optimization that is mostly related to ADD opcode, so we can get 44.750 instead of 46.750).

This looks really good, wouldn't it be worth it to also force the no inline on the constructor simulate function?

Currently in the constructor simulate function that is inlined, LLVM doesn't generate unneeded spills and reloads. In case we see that this happens in a future, we will add noinline attribute. Is this OK with you?

@jrchatruc Thanks for the review!
Please note that I added one more commit to add always inline to warmAddress function. I saw that in one place it is not inlined, so I added always inline attribute to force inlining in all places.

@jrchatruc PTAL. Improvements can be seen here (please note that this PR contains one pending LLVM optimization that is mostly related to ADD opcode, so we can get 44.750 instead of 46.750).

This looks really good, wouldn't it be worth it to also force the no inline on the constructor simulate function?

Currently in the constructor simulate function that is inlined, LLVM doesn't generate unneeded spills and reloads. In case we see that this happens in a future, we will add noinline attribute. Is this OK with you?

Yep, totally ok, was just curious about it


[20.09] Linux kernel 5.11

Motivation for this change
Update to latest Linux kernel
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

@ofborg test kernel-latest kernel-lts latestKernel.login kernel-latest-ath-user-regd latestKernel.hardened

@ofborg test kernel-latest kernel-lts latestKernel.login kernel-latest-ath-user-regd latestKernel.hardened zfs.unstable zfs.installer zfs.stable

@ofborg test kernel-latest kernel-lts latestKernel.login kernel-latest-ath-user-regd latestKernel.hardened zfs.unstable zfs.installer zfs.stable


Update IoT Agent for JSON to 1.25.0

Proposed changes
This PR  updates IoT Agent for JSON to 1.25.0.
Types of changes
What types of changes does your code introduce to the project: Put an x in the boxes that apply

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Update only documentation, not any source code.

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of
them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.

[X] I have read the CONTRIBUTING doc
[ ] I have signed the CLA
[X] I have updated the change log (CHANGELOG.md)
[X] I send this pull request to the v0.17.0-next branch.
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)
[ ] Any dependent changes have been merged and published in downstream modules

Further comments
N/A

Codecov Report
Base: 100.00% // Head: 100.00% // No change to project coverage :thumbsup:

Coverage data is based on head (acda50e) compared to base (bb74e10).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@              Coverage Diff               @@
##           v0.17.0-next      #204   +/-   ##
==============================================
  Coverage        100.00%   100.00%
==============================================
  Files                 2         2
  Lines              1746      1746
==============================================
  Hits               1746      1746

Impacted Files
Coverage Δ

config.sh
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


gcc/cuda used for training

In your tutorial on llama-2 (below) would you mind sharing what versions of gcc and cuda you're using?
https://github.com/philschmid/deep-learning-pytorch-huggingface/blob/main/training/instruction-tune-llama-2-int4.ipynb

Sure.
>> nvcc --version
nvcc: NVIDIA (R) Cuda compiler driver
Copyright (c) 2005-2022 NVIDIA Corporation
Built on Wed_Jun__8_16:49:14_PDT_2022
Cuda compilation tools, release 11.7, V11.7.99
Build cuda_11.7.r11.7/compiler.31442593_0

and
>> gcc --version
gcc (Ubuntu 9.4.0-1ubuntu1~20.04.1) 9.4.0
Copyright (C) 2019 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

I am using this AMI Deep Learning AMI GPU PyTorch 1.13.1 (Ubuntu 20.04) 20230309 with ami id ami-078afdc6b93b6177f in us-east-1


fix(core): fixed edit permission for user

fixed displaying the "edit" button for user himself, if he doesn't have the global permission to edit stuff

:tada: This PR is included in version 1.0.7 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


feat(gwyneth): add reth-based private network , and L1 contract deployment

A modified SGX verifier (MockSgxVerifier) is added, so that no need to create 3 proofs for verification but rather deployed 3 MockSgxVerifier and those are always accepting the proofs for now. The reason for this is the currently required 3 proofs to be able to verify, and not to change the protocol, but rather have at least 3 verifiers, accepting everything.

@Brechtpd merging it in to our base, as it contains no other things than deployment scripts + howto shoot up a private network + the already accepted "Bring over from taiko-mono" PR (which is merged in to this).


What does “32x4d” mean?

A littile question , What does “32x4d” mean?(faster_rcnn_x101_32x4d_fpn_1x_coco)
I know the meaning of the other parts of the name but I don’t know the meaning of this part(32x4d)
I will be very grateful if you can reply

"x101_32x4d": ResNeXt-101 (32x4d)


docs: broken link on Self-hosted subscriptions page

Summary
This PR will fix one/some broken links on the general documentation.

Hello @ftonato,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.
Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project.
Please help complete the Mattermost contribution license agreement?
Once you have signed the CLA, please comment with /check-cla and confirm that the CLA check is green.
This is a standard procedure for many open source projects.
Please let us know if you have any questions.
We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.


De duplication

added to code to check if transactions payment ref has already been served by server for certain transaction types. If it has return the original transaction response

:+1:


add a parameterized command helper with a canExecute hook

Well that was easy. The Explicit module had the exact function I needed.

Thank you @baronfel !


Using only one face detected from video feed

I don't want to get face_encodings from all faces detected. Is there way to choose one 'best' face from all those detected and get it's encodings?

Im not certain on this but in @ageitgey 's original article he mentioned that you are supposed to run a simple SVM on the encodings.
Check out the article here: https://medium.com/@ageitgey/machine-learning-is-fun-part-4-modern-face-recognition-with-deep-learning-c3cffc121d78

What do you mean by "best" face? The biggest face in the picture?
If so, you could just check the size of each face bounding box returned by .face_locations() and then pass only the ones you want to .face_encodings(img, face_locations=[just-the-biggest-face]).

@ageitgey I believe the question was something like "Why was it that your face encoding is only using 1 image instead of multiple"? What if you want to use multiple images to help improve face identification?
Am I right to assume that you will have to use SVM in combination with your face_encodings results if we want to use multiple images of 1 person?

Sure, you can use an SVM classifier if you want to use multiple face encodings of each single person.

@ageitgey have you consider provide support for a classifier, similar to OpenFace, which support multiple faces for each person, multiple-person classification (SVM) included. I think that would be very much helpful here

I don't really want to complicate the API of the library with classifier functions since they often aren't needed (and also because how you use a classifier will depend on what exactly you want to do).  But maybe when I have some spare time I can add a new example program that shows how to use a basic classifier with scikit-learn.

I was referring to scenarios where in a video/picture will have more than 1 face detected and you only want to perform the facial recognition on one face out of the many detected).

use this
face_locations = face_recognition.face_locations(small_frame)
face_encodings = face_recognition.face_encodings(small_frame, face_locations)

and then face_encodings[0] for the first face you find
You can ofc do further conditioning based on the location of the face.

that's exactly what I need, thanks!


blog: Windows Operational Readiness

As per recent communication from the Communications Team, this PR adds a placeholder for an upcoming blog article.
KEP: https://github.com/kubernetes/enhancements/tree/master/keps/sig-windows/2578-windows-conformance
Project: https://github.com/kubernetes-sigs/windows-operational-readiness
/sig windows
cc @knabben @jayunit100

/hold
pending assignment of publication date

/hold
pending assignment of publication date

@sftim for the publication date, are we good to propose any day of our choosing? We are tentatively targeting next week for publication.

@sftim Set date for 2024-03-18

Hi. I'm going to prioritize other articles that are earlier in the review queue.
We ask for more notice than you'd need for a 2024-03-18 publication date. I can see you asked about choosing a date; you can request one, but giving plenty of notice (multiple weeks) is ideal. This was marked as WIP until the 13th and, with that marker set, won't have been a priority to check up on.
As it's the week before KubeCon, it happens to be an especially busy time for reviewers, me included. What was the thinking behind requesting that publication date?

@sftim We understand the constraints, especially with the upcoming KubeCon. There was no specific reason for choosing that date other than aiming for an early article publish date to share our progress with the community sooner. To accommodate the SIG docs team and give more time to review, how about April 3rd?

I have two areas of further concern:

The article isn't following the way we format Markdown source for the blog.

Wrap source lines at around 100 characters
Use headings at level 2 or above (not level 1; that's the title)
Write headings in sentence case

These are important but all are fixable.

https://github.com/kubernetes/enhancements/blob/d60c6149551b7f852c16842fb952a499c2cc4315/keps/sig-windows/2578-windows-conformance/kep.yaml shows that the KEP is alpha; does thaat need to change?
Is the specification that people would follow really part of a closed KEP? It looks hard for people to work out which bits they need to follow.

These are trickier concerns. I don't think we should announce this specification as anything other than a work-in-progress.

I'd expect to see mention of this Windows operational readiness idea within https://k8s.io/docs/ - and before we announce it via a blog article.

I have two areas of further concern:

The article isn't following the way we format Markdown source for the blog.

Wrap source lines at around 100 characters
Use headings at level 2 or above (not level 1; that's the title)
Write headings in sentence case

These are important but all are fixable.

https://github.com/kubernetes/enhancements/blob/d60c6149551b7f852c16842fb952a499c2cc4315/keps/sig-windows/2578-windows-conformance/kep.yaml shows that the KEP is alpha; does thaat need to change?
Is the specification that people would follow really part of a closed KEP? It looks hard for people to work out which bits they need to follow.

These are trickier concerns. I don't think we should announce this specification as anything other than a work-in-progress.

I'd expect to see mention of this Windows operational readiness idea within https://k8s.io/docs/ - and before we announce it via a blog article.

The main audience is external users and cloud providers wanting to validate features of the Windows cluster in production. I don't mind publishing it in the Kubernetes Contributor blog instead (what should be the procedure?)
The KEP has existed for two years. Since then, we have been working on the tool as a subproject of SIG-Windows (Kubernetes-sigs/windows-operational-readiness) within the specification; this is the project and implementation of the KEP with a release and already presented on KubeCon.  I will update the KEP status and milestones.

Can we document the Windows Operational Readiness spec ahead of the blog article? That's the normal order for things: implement, document, announce.

@sftim formatted the article, opened #45612 for documetation (ptal) and fixed the open comments.

@tzifudzi moved the publish date to 2024-04-03

@sftim We understand the constraints, especially with the upcoming KubeCon. There was no specific reason for choosing that date other than aiming for an early article publish date to share our progress with the community sooner. To accommodate the SIG docs team and give more time to review, how about April 3rd?

Let's aim for that.
/hold cancel

As per recent communication from the Communications Team, this PR adds a placeholder for an upcoming blog article.

If that team is Release Comms, I recommend checking with them as well about a publication date.

This is not a post-release blog article. Ready for review.

/lgtm
/approve

Ah yeah please do address remaining changes thanks folks

LGTM from me!
/lgtm

/approve


Fix / usermenu item count & correct html structure

This change announced the correct amount of list items in the user menu. I also improved wrapped the sidebar menu items in a list, so a screen reader user knows how may items there are in the menu.
Originally I wanted to go for a border-bottom styling instead of the suggested

, but it took too much time to get the styling identical.
I chosen a h2 for the heading because, we should limit the h1 to one. And using a h3 is illogical (because it is missing the h2). I could not find an better solution within the time. I'm open for ideas, if you disagree with the approach.
Ticket: https://videodock.atlassian.net/browse/OTT-842

axe devools complains about  though... that is really unfortunate because that is the only issue it complains about. I guess I have to spend some time on the border-bottom....

Fixed the above axe validation error by replacing

 with CSS

Oh, snapshots are failing I think


support tag updates for DBSubnetGroup resources

Adds support for tagging and updating DBSubnetGroup resources.
Issue aws-controllers-k8s/community#1276
Signed-off-by: Jay Pipes<EMAIL_ADDRESS>By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.

/retest

/lgtm


Function completion snippets are broken in Query and expression editors

snippets are being pasted in as values and not snippets so Ace treats them as plain text and you can't tab over them.

Fixed in > 7.4-beta.12


Don't use named argument key names as parameters for method_missing calls

Resolves #10381 through https://github.com/crystal-lang/crystal/issues/10381#issuecomment-778487629.
method_missing is used in the standard library only by forward_missing_to, which in turn is used only by HTTP::Headers. The specs for it don't exercise this capability beyond calling HTTP::Headers#same?, which can be rewritten without any implicit delegation, and which doesn't have named arguments anyway (it uses #object_id). So the standard library most certainly won't break, but external libraries that refer to call arguments using {{ call.named_args[...].name }} will.

Thank you! ❤
If it isn't too much work... could you briefly explain what does this change and why? I didn't have time to follow the entire conversation in #10381 which covers a lot of topics.
I guess this is also a breaking change?
From the description I still don't understand why one would need to change name to value when name was working fine before.

The PR makes the named parameters of method_missing's generated defs use _named_arg#{i} instead of copying them from the key names.
The main reasons are:

A named parameter's external name doesn't need to be a valid identifier, but its internal one must be:def foo(*, "a b" a b); end         # unusable inside `method_missing`
def foo(*, "a b" _named_arg0); end # okay

foo("a b": 0)

Allowing implicit access to the named arguments by name can potentially shadow other calls:class Foo
  def to
    1
  end

  forward_missing_to to
end

Foo.new.upto(to: 3).to_a # => [3]
Foo.new.upto(3).to_a     # => [1, 2, 3]

If the internal parameter names for the generated def start with an underscore, as the positional and block parameters already do, then the chances of collision are greatly reduced because these names are reserved by Crystal.
Ruby's method_missing also accesses the call's named arguments through a double splat parameter, and that parameter's values, not keys, are the actual arguments.

@HertzDevil Thank you again! 💙


ClassVar with specified value raises "Fields without default values cannot appear after fields with default values"

Environment data

Pylance version: v2024.9.2
OS and version: ubuntu (WSL2)
Python version (& distribution if applicable, e.g. Anaconda): 3.12

Code Snippet

from dataclasses import dataclass

@dataclass
class MyClass:
    float_number: ClassVar[float] = 0.3
    int_number: int

MyClass(int_number=4)

# result: MyClass(int_number=4)

screenshot:

Should this be an issue? It seems like since float_number is a class variable the concept of a "default value" doesn't apply? It's also conceptually not treated as a field at run-time: https://peps.python.org/pep-0557/#class-variables.

It appears from your snippet that you're not importing ClassVar. If you aadd from typing import ClassVar to the top of your file, it should work as you expect. By default, you should see a separate error telling you that ClassVar is undefined, but perhaps you've disabled the reportUndefinedVariable check.


Template "Console Application" could not be created.

OS- Windows 10 Home version 1909
About Visual Studio Code-
Version: 1.40.2 (system setup)
Commit: f359dd69833dd8800b54d458f6d37ab7c78df520
Date: 2019-11-25T14:54:45.096Z
Electron: 6.1.5
Chrome: 76.0.3809.146
Node.js: 12.4.0
V8: 7.6.303.31-electron.0
OS: Windows_NT x64 10.0.18363
Command Prompt-
PS C:\Program Files\Microsoft VS Code\Project folders\HelloWorld> dotnet new console
Error Message-
Template "Console Application" could not be created.
Error while processing file /content/ConsoleApplication-CSharp/Company.ConsoleApplication1.csproj
System.UnauthorizedAccessException: Access to the path 'C:\Program Files\Microsoft VS Code\Project fole
rs\HelloWorld\HelloWorld.csproj' is denied.
at System.IO.FileStream.ValidateFileHandle(SafeFileHandle fileHandle)
at System.IO.FileStream.CreateFileOpenHandle(FileMode mode, FileShare share, FileOptions options)
at System.IO.FileStream..ctor(String path, FileMode mode, FileAccess access, FileShare share, Int32 bufferSize, FileOptions options)
at System.IO.FileStream..ctor(String path, FileMode mode, FileAccess access, FileShare share, Int32 bufferSize)
at System.IO.File.Create(String path)
at Microsoft.TemplateEngine.Utils.PhysicalFileSystem.CreateFile(String path)
at Microsoft.TemplateEngine.Core.Util.Orchestrator.ProcessFile(IFile sourceFile, String sourceRel, String targetDir, IGlobalRunSpec spec, IProcessor fallback, IEnumerable1 fileGlobProcessors, IReadOnlyList1 locOperations)

You're trying to create files within "C:\Program Files\Microsoft VS Code", but your user does not have privileges to that directory.
I'd suggest using a different directory, as Program Files is intended to hold installed apps, not user documents.


[Regression] MANIAC-V2/ZAK-V2 are broken in ScummTR 0.5.0

Summary
Trying to extract the text of MANIAC-V2-FR (from my DOTT CD) with the officia: ScummTR 0.5.0 release unfortunately shows a late regression :(
$ scummtr -g maniacv2 -c -l fr -of tmp.txt
ERROR: Bad OIv2 offset

A bit of git bisect shows that this regression appeared with the extra "safety" I added in commit 8322e6da739a82dd4511474f152679ee303a0bd7. Looks like I was wrong...
Impacted games
Maniac Mansion
ScummTR versions
v0.5.0
I own a legitimate game

[X] I promise that my game does NOT come from an illegal source, such as "abandonware" websites

Also fixes the same problem in Zak V2 (from GOG).

Closing, since 0.5.1 was released with this fix on 2022-02-27.


Have a setup.py entry point for more reliable pipx installations

Hey there,
currently this tool cannot be invoked via pipx, if pipx bases its virtual environments in a path that contains spaces, which is the default on mac, as per the mac documentation. This is the case since pipx 1.3.
The solution is to provde a entry point, see the pipx docs.
As you recommend installing this tool via pipx, it would be great if you could update your package accordingly.
Thanks!
based on https://github.com/pypa/pipx/issues/1212

I guess this would practically mean adding the following to your setup.cfg (see the setuptools documentation):
[options.entry_points]
console_scripts =
    executable-name = pass2csv:main

I'm a notorious pass user, too, by the way, so thanks for developing this tool!

I've refactored how pass2csv does packaging including setting an entry point in https://github.com/reinefjord/pass2csv/commit/44d82c5a54de8415b88acfd60c844bbfa868c7e5 and pushed a new version to pypi. Installation into paths with spaces now seems to work, at least on Linux:
$ which pass2csv | xargs readlink
/home/spaces are fun!/.local/share/pipx/venvs/pass2csv/bin/pass2csv
$ pass2csv --version
pass2csv 1.1.1

Thank you for the heads-up and thanks for pipx!

Thanks for resolving so rapidly!


NBS Onboarding - Go Live Coordination

Acceptance Criteria

[ ] Confirmed with STLT when they want to start receiving (date)
[ ] Removed quality filter in prod settings = allowNone()
[ ] Removed quality filter in staging settings = allowNone()
[ ] Set Customer status = active

To Do

[ ] RS engineer: update this ticket with comments with every interaction with receiver
[ ] RS team member who originates this ticket: add any dependencies, as needed
[ ] RS team member who originates this ticket: complete the following when creating this Issue.

[ ] Pipelines: Onboarding & Operations (New)
[ ] Labels: "Onboarding-ops" and "Receiver" and state label
[ ] Epics: [select the epic for this API onboarding sender]

NBS only need staging/test/debug to go live.  This will be deploy Tuesday 8/29/2023

Go live.  They only want a staging environment for now.  Done.


Add italian resources

What does this PR do?
Add 3 resources in Italian book
For resources
Description
HTML course
CSS course
jQuery course
Why is this valuable (or not)?
These are courseware I use in my open courses
How do we know it's really free?
All documents are published in GitHub repository and are frequently updated
For book lists, is it a book? For course lists, is it a course? etc.
Are 3 courses
Checklist:

[x] Read our contributing guidelines.
[x] Search for duplicates.
[x] Include author(s) and platform where appropriate.
[x] Put lists in alphabetical order, correct spacing.
[x] Add needed indications (PDF, access notes, under construction).
[x] Used an informative name for this pull request.

Follow-up

Check the status of GitHub Actions and resolve any reported warnings!

these are not books


notify when the figher gets destroyed

log message:
{
    "timestamp": "2022-03-07T14:51:41Z",
    "event": "FighterDestroyed",
    "ID": 35
}

how we can include this information?

Hi @EdAzurz, you cannot at the moment, unless you're asking how to write new code to add this feature to the software.
But if you set fighter=true in the config file, you can now get a notification when the fighter's hull is damaged (which is, more or less, the same info since at that point the fighter will probably be soon destroyed)


Add benchmark for fulfillment warehouse

I want to merge this change because I want to add benchmark for fulfillment warehouse resolvers

Impact

[ ] New migrations
[ ] New/Updated API fields or mutations
[ ] Deprecated API fields or mutations
[ ] Removed API types, fields, or mutations
[ ] Documentation needs to be updated

Pull Request Checklist

[ ] Privileged queries and mutations are guarded by proper permission checks
[ ] Database queries are optimized and the number of queries is constant
[ ] Database migration files are up to date
[ ] The changes are tested
[ ] GraphQL schema and type definitions are up to date
[ ] Changes are mentioned in the changelog

Task linked: SALEOR-3729 Optimize Fulfillment type resolvers

@IKarbowiak we actually do, the resolver fires for each order so in this case query count will drop anyway as the old resolver added up to 3 extra queries for each. But I agree, more objects is better when it comes to benchmarks, we should add some.

@tomaszszymanski129 I checked locally the test that uses this query and there was only one warehouse instance.


chore: during dkg generate peer-ids by peer name ordering

QoL thing.

@douglaz fyi

Will this be backported?

Successfully created backport PR for releases/v0.2:

#4286


Remove special characters in name / emails

Need to remove special characters in Names / Emails to help prevent errors while trying to display.

Added in new function to remove special characters. Will be included in minor version 640


resizeMode applies to Image.defaultSource

resizeMode applies to Image.defaultSource, because depending on screen resolution sometimes we see padding around defaultSource image while source loading. Now we can control scale of both source and defaultSource.
Changelog:
Help reviewers and the release process by writing your own changelog entry. When the change doesn't impact React Native developers, it may be ommitted from the changelog for brevity. See below for an example.
[Android] [Fixed] - Image.resizeMode will apply to defaultSource, enhanced user experience. Previously, resizeMode didn't applied to defaultSource, therefore depending on screen resolution sometimes we see padding around defaultSource image while source loading.

just dug a little bit, and found proper solution 👍

You should ask release notes (look into new PR template).

Hey @dulmandakh can you add the release notes to the post - then I'll try to trigger the import.

@kelset done


reporting-dispute-markets throws error on load

Steps to reproduce

Start local dev environment using geth pop docker image
open (http://localhost:8080/#/reporting-dispute-markets)
It should blow up with an error like this:

VM19761 react-dom.development.js:15749 The above error occurred in the <Connect(withRouter(ReportingDisputeMarkets))> component:
    in Connect(withRouter(ReportingDisputeMarkets)) (created by Route)
    in Route (created by ReportingView)
    in Switch (created by ReportingView)
    in section (created by ReportingView)
    in ReportingView (created by AsyncComponent)
    in AsyncComponent (created by Route)
    in Route (created by Routes)
    in Switch (created by Routes)
    in Routes (created by AppView)
    in section (created by AppView)
    in section (created by AppView)
    in section (created by AppView)
    in div (created by AppView)
    in main (created by AppView)
    in AppView (created by Connect(AppView))
    in Connect(AppView) (created by WrapperCmp)
    in WrapperCmp (created by Route)
    in Route (created by withRouter(WrapperCmp))
    in withRouter(WrapperCmp)
    in MainErrorBoundary
    in Router (created by HashRouter)
    in HashRouter
    in Provider

This was recently fixed by merge over from augur-ui. not seeing the error.


docs: Missed Middleware information

Without middleware request model is empy :(

@rustamwin How WrapperFactory should be used here?

@rustamwin How WrapperFactory should be used here?

The WrapperFactoryInterface should be used here.

Thanks.


Update all headings levels in designs

The headings levels do not currently follow a logic order in the designs. We should also review whether we should remove headings from inside components (e.g. Links list) - we did this in the website.

@inesdgomes I made all changes to the design templates and now we are using the correct styles within it. Also I realised we do use all text styles within the typography stylesheet.
H1 - Main Headings, Hero Cards, etc
H2 - Promo Card, Stats Card
H3 & H4 - All other main card components
So I don't think we need to remove any text style at the moment. If we remove the H2 and make the Promo Card and Stats Card use the H3, there wouldn't be any hierarchy defined and everything would look the same sizing, so I feel like it's better not to change it. I know we don't use those components that often but when we do, they need to have a bigger hierarchy because they are important.

@beatrizmartinmartins Let's review this one together. I think because the section divider is still H3, the headings still do not follow a sequential order. See for example the homepage: we're jumping from H1 to H3.
Also, as for removing headings from within components, I think this can still be done, but let's look at it together.

@inesdgomes Shall we make a fusion between H2 and H3 and only have one heading instead of 2?

Agreed that we'll merge H2 and H3 and we'll have only 4 heading levels.

Just made this change. Also applied it to the Promo Card and Stats Card component. Remember that all components that used to have H3, now have H2. @inesdgomes

Thanks @beatrizmartinmartins Closing this ticket.


Is there a way to control Segmentation length of recognized result ?

Hello,
Is there a way like speech config parameter to control recognized result text length ? i didn't find such config in sdk doc.
The reason and scenario of this asking is that, some time the output recognized text is too long to render friendly, e.g. mobile app with recognized text limit of 2 lines each max 20-char (or less).
E.g.

Utterance: I will go to bookstore this afternoon to check if any new arrivals. After that Jack will pick up me there to gym for practice. We need to prepare a match in two weeks. Dinner will be taken in gym to save commute overhead. I will arrive home around 8:30 in the evening.

Current result from speech sdk:
RECOGNIZED: Text=I will go to a bookstore this afternoon to check if any new arrivals after that Jack will pick up me there to gym for practice.
RECOGNIZED: Text=We need to prepare a match in two weeks.
RECOGNIZED: Text=Dinner will be taken in gym to save commute overhead. I will arrive home around 8:30 in the evening.

Expect result: There shall be a control of segmentation length level (or even better, value) like short, middle or long. E.g. for middle segmentation length, below is expectation:
RECOGNIZED: Text=I will go to a bookstore this afternoon to check if any new arrivals.
RECOGNIZED: Text = After that Jack will pick up me there to gym for practice.
RECOGNIZED: Text=We need to prepare a match in two weeks.
RECOGNIZED: Text=Dinner will be taken in gym to save commute overhead.
RECOGNIZED: Text=I will arrive home around 8:30 in the evening.

Thank you.

Currently we dont  have this feature. I will recommend you to split the string based on your need. Do let me know if that works.

If you think it is an important feature for you, please create a feature request here https://cognitive.uservoice.com/forums/912208-speech-service.
Thanks a lot

Me too need this feature


Add support for redirect/visit

While not technically a DOM operation, allowing the server to initiate page visits on the client may prove helpful.

Will revisit when the need arises.

Related to https://github.com/hopsoft/stimulus_reflex/issues/64


⚠ Bofrost.at has degraded performance

In 64259cb, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1021 ms

Resolved: Bofrost.at performance has improved in 758befa after 13 minutes.


First PatrolPoint hasDropZone

Can I make the suggestion that the first monument (or 2 or maybe configurable?) it goes to does not have a drop zone? I understand the nature of RNG, but from my understanding when it goes to a monument with a dropzone it does? I've seen it come in, fly right to airfield, drop, and leave.
Looking forward to being able to place dropzones with MonumentAddons. Love your work, thanks big time!

Thanks for the suggestion! The way you proposed this is reasonable because it can done when the patrol path is calculated, so it doesn't require overriding the chinook AI states.


Use 8.9.0-dev for Satellite testing.

@mrproliu It seems the latest image makes the test failing. Please recheck. Others are correct, only ALS cases fail.


Expose Ship Data to templates

There is additional information that may be of use to template designers in regards to individual ships.  Need to expose the data via a variable called allships.

This is now implemented.  Use the allships variable which returns a List of Ship objects.  See the data model section of the wiki for available fields.


Add nyc for coverage reports

Add nyc (Istanbul command-line interface) to generate coverage reports. With the minimal integration, coverage information will be logged after running tests. This helps to visualize current coverage and areas in need of tests.
$ npm test

Maybe I need to enable coverage service, so could you complete the configuration first?

Additional configuration would include adding an lcov reporter so that coverage data could be sent somewhere like coveralls.io. Are you interested in this?

abandoned


Add an optional input field to the resource form to add a unit of measurement to an input.

As an example: If you want to track apples, and you'd want the value to be measured in kilograms, you could add "kg" as unit of measurement and the dashboard would display "Apples: 10 kg".

I'll be closing this for now, it's just easier to add the unit to the resource's label, and there's other features that would have more impact.


[Bug]: 2.0 Continuous Crash

What happened?
Upgraded to 2.0 when released. Has been fine up until today. Noticed my Homebase2s were not responding in HomeKit. Launched Homebridge and saw plugin was continuously crashing now as a child bridge.
Device Type
Station (Supported)
Plugin Version
v2.0.x (Supported)
HomeBridge Version
v1.4.x (Supported)
NodeJS Version
v16 (Supported)
Operating System
Docker (UnSupported)
Relevant log output
[6/1/2022, 7:36:04 PM] [homebridge-eufy-security] Restarting Process...
[6/1/2022, 7:36:05 PM] [homebridge-eufy-security] Launched child bridge with PID 7540
[6/1/2022, 7:36:05 PM] Registering platform 'homebridge-eufy-security.EufySecurity'
[6/1/2022, 7:36:05 PM] [homebridge-eufy-security] Loaded homebridge-eufy-security v2.0.0 child bridge successfully
[6/1/2022, 7:36:05 PM] Loaded 2 cached accessories from cachedAccessories.0E4AC36F389B.
[6/1/2022, 7:36:05 PM] [EufySecurity-2.0.0] WARN:  warning: planned changes, see https://github.com/homebridge-eufy-security/plugin/issues/1
[6/1/2022, 7:36:05 PM] [EufySecurity-2.0.0] ERROR: Error cleaning config: Error: EACCES: permission denied, open '/homebridge/config.json'
    at Object.openSync (node:fs:585:3)
    at Object.writeFileSync (node:fs:2170:35)
    at EufySecurityPlatform.clean_config (/homebridge/node_modules/homebridge-eufy-security/src/platform.ts:519:10)
    at new EufySecurityPlatform (/homebridge/node_modules/homebridge-eufy-security/src/platform.ts:110:10)
    at ChildBridgeFork.startBridge (/usr/local/lib/node_modules/homebridge/src/childBridgeFork.ts:134:42) {
  errno: -13,
  syscall: 'open',
  code: 'EACCES',
  path: '/homebridge/config.json'
}
[6/1/2022, 7:36:05 PM] [EufySecurity-2.0.0] INFO:  Country set: US
[6/1/2022, 7:36:05 PM] [EufySecurity-2.0.0] INFO:  Finished initializing!
[6/1/2022, 7:36:05 PM] Homebridge v1.4.1 (HAP v0.10.2) (homebridge-eufy-security) is running on port 46605.
TypeError: The first argument must be of type string or an instance of Buffer, ArrayBuffer, or Array or an Array-like Object. Received undefined
    at new NodeError (node:internal/errors:372:5)
    at Function.from (node:buffer:323:9)
    at stringWithLength (/homebridge/node_modules/homebridge-eufy-security/node_modules/eufy-security-client/src/p2p/utils.ts:27:35)
    at p2pDidToBuffer (/homebridge/node_modules/homebridge-eufy-security/node_modules/eufy-security-client/src/p2p/utils.ts:55:18)
    at buildLookupWithKeyPayload (/homebridge/node_modules/homebridge-eufy-security/node_modules/eufy-security-client/src/p2p/utils.ts:60:26)
    at P2PClientProtocol.lookupByAddress (/homebridge/node_modules/homebridge-eufy-security/node_modules/eufy-security-client/src/p2p/session.ts:304:50)
    at /homebridge/node_modules/homebridge-eufy-security/node_modules/eufy-security-client/src/p2p/session.ts:284:51
    at Array.map (<anonymous>)
    at P2PClientProtocol.lookup (/homebridge/node_modules/homebridge-eufy-security/node_modules/eufy-security-client/src/p2p/session.ts:284:29)
    at Socket.<anonymous> (/homebridge/node_modules/homebridge-eufy-security/node_modules/eufy-security-client/src/p2p/session.ts:361:26)
[6/1/2022, 7:36:07 PM] [homebridge-eufy-security] Child bridge process ended
[6/1/2022, 7:36:07 PM] [homebridge-eufy-security] Process Ended. Code: 1, Signal: null
[6/1/2022, 7:36:14 PM] [homebridge-eufy-security] Restarting Process...

I think I know what happened. My Smart Lock also stopped responding today and I think it is dead. The plugin was trying to get status unsuccessfully causing it to crash.
Removing the dead lock solved my continuous reboot.