[BetterTransformer] Let's make the transformation invertible

This PR adds the inverse_transform support for BT-transformed models.
In the future, PyTorch will support BetterTransformer for training. Therefore a user would want to first convert a model, train it with BetterTransformer as backend and save the trained model afterwards. Before this PR the keys of the model's state dict are changed, therefore saving the model out of the box would break the model architecture and support with transformers. This PR adds a new transformation invert_transform that will let users convert back the BT model in its original format so that they can push/save their model.
TODOs:

[ ] stronger API regarding saving-related methods (block save_pretrained, push_to_hub etc for converted models)
[ ] leverage copy mechanism (# Copied from ...)
[ ] more tests?

cc @fxmarty @michaelbenayoun @HamidShojanazeri

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

Would be keen to have the opinion of @michaelbenayoun , but personally, I am not in favor of

leverage copy mechanism (# Copied from ...)

I would rather prefer something like having a map
bettertransformer_attrs = {
    "linear1_weight": "fc1.weight"
    ...
    "norm1_eps": "self_attn_layer_norm.eps"
    "norm1_weight": "self_attn_layer_norm.weight"
}

and use this with recursive getattr/setattr/delattr if you need to access several times the items, for example in _replace_to_original_module.
It's just a matter of taste, but I think it has the advantage of normalizing everything. And you could write a single _replace_to_original_module for all architectures.

Would be keen to have the opinion of @michaelbenayoun , but personally, I am not in favor of

leverage copy mechanism (# Copied from ...)

I would rather prefer something like having a map
bettertransformer_attrs = {
    "linear1_weight": "fc1.weight"
    ...
    "norm1_eps": "self_attn_layer_norm.eps"
    "norm1_weight": "self_attn_layer_norm.weight"
}

and use this with recursive getattr/setattr/delattr if you need to access several times the items, for example in _replace_to_original_module.
It's just a matter of taste, but I think it has the advantage of normalizing everything. And you could write a single _replace_to_original_module for all architectures.

I agree!

Indeed using dict recusrively is much better @fxmarty @michaelbenayoun and has been addressed in the latest commits to support all models
I propose to change the whole transformation logic (hf_model to bt_model) by that in a follow up PR and keep the reverse transformation as it is now (recusive + dict)

Thanks for your comments @fxmarty , @michaelbenayoun !
Making this PR as ready for review now 💪

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


⚠ OVPN 🇦🇪 United Arab Emirates AEM 1 has degraded performance

In 408ca46, OVPN 🇦🇪 United Arab Emirates AEM 1 (http://aeo-1.opensvr.net:5555/) experienced degraded performance:

HTTP code: 503
Response time: 15958 ms

Resolved: OVPN 🇦🇪 United Arab Emirates AEM 1 performance has improved in 7e62d4c.


fix(NODE-6407): use conversationId returned by the server instead of hardcoded integer in SASL implementation for MONGODB-AWS.

Description
MONGODB-AWS authentication mechanism should follow SASL spec. Current implementation ignores the conversationId sent by the server and uses a hardcoded integer for all saslContinue messages across all conversations.
What is changing?
Changing the hardcoded integer for conversationId to utilize the one that gets returned in the saslStart response.
Is there new documentation needed for these changes?
No. This change brings the implementation to spec.
What is the motivation for this change?
This is a bug. MONGODB-AWS authentication failed on database emulating MongoDB.
Release Highlight
Fixes SASL implementation for MONGODB-AWS to use conversationId returned by the server instead of hardcoded integer.
Double check the following

[x] Ran npm run check:lint script
[x] Self-review completed using the steps outlined here
[x] PR title follows the correct format: type(NODE-xxxx)[!]: description

Example: feat(NODE-1234)!: rewriting everything in coffeescript

[ ] Changes are covered by tests
[x] New TODOs have a related JIRA ticket

Hey @kggau, thanks for sharing this patch. Our team will give it a once over to validate it addresses the problem (it looks like it does on a quick inspection).

This is a bug. MONGODB-AWS authentication failed on database emulating MongoDB.

Can you clarify which emulating database this issue occurred in?

Thanks @alexbevi!

Can you clarify which emulating database this issue occurred in?

This issue happened when using MONGODB-AWS auth mechanism with Amazon DocumentDB. Given loss of conversationId information, I am not sure why it is functional with MongoDB (assuming it works).

Given loss of conversationId information, I am not sure why it is functional with MongoDB (assuming it works).

@kggau just to clarify, this does work with the MONGODB-AWS authentication mechanism within the MongoDB server.

Would anyone be able to provide an update on when this might get released? We're eagerly awaiting this functionality.

@todd Thanks for reaching out. We're currently at capacity with our end-of-year wrap-up, but we plan to look into this early next year. The changes here are pending further testing. We appreciate your patience and you'll be notified here or on the JIRA ticket NODE-6407 of our progress.


Compilation errors in svg,css, and csv models on kali linux

Pcre2.h no such file or directory

This is an issue with your development environment, and not the project.
We detailed this in the README: https://github.com/ad-995/bluffy/blob/main/README.md#pcre28
Closing the issue.


pointing two instances to the same file, should it work?

 var Datastore = require('nedb');
 var dbClient = new Datastore({ filename: '...', autoload: true });

I'm doing this twice in my application (create 2 clients pointing to the same file), but under one process. The data that comes back seems to be very inconsistent. I run update and then get the record without the update from the other client.
I know I should be re-using one object, but I'm just wondering what causes these inconsistencies. There's no race condition here, the update and the query are seconds apart (as well as the instantiation of the db objects).
Is this just not supported?
Thanks

I believe NeDB runs primarily in memory then updates the store.  If that's the case, then you would have to figure out a way to pass messages between the instances to sync up the memory.


it has error when running npm start

it has many nom ERROR! when auto-running npm start. how to resolve it?

it says sh: functions: command not found


Remove common Micro.blog elements from head and use new partial instead

Hey! 👋 This pull request introduces the new partial that is provided by the Micro.blog environment. With that, we know that all the necessary Micro.blog head elements are present, with the added bonus of making this theme compatible with Hugo 0.117.
 Is there anything I need to change outside of adding this partial, such as modifying/deleting any other files?

Well, I can't tell you with 100% certainty. In theory, you could have JavaScript or some other external thing that depends on how stuff was organized in the head before this change. But I think that's highly unlikely. And I have tested the theme on my machine with the changes introduced in this pull request, and it worked okay.
But, as with any change, it's probably a good idea for you to test my changes as well before merging.


Remove redundant metadata section in client

Description
Remove redundant metadata collection from uperf client. If metadata is set to true we will already gather it when server pods launch.
Fixes

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@f296081). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #740   +/-   ##
=========================================
  Coverage          ?   53.82%
=========================================
  Files             ?        8
  Lines             ?      327
  Branches          ?        0
=========================================
  Hits              ?      176
  Misses            ?      151
  Partials          ?        0

Flag
Coverage Δ

gha
53.82% <0.00%> (?)

python-3.9
53.82% <0.00%> (?)

unit
53.82% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f296081...4651193. Read the comment docs.

/rerun all

Let's ignore fs-drift issues for now -> https://github.com/cloud-bulldozer/benchmark-operator/issues/741
Merging!


Do I have to learn livewire and filamentphp to use tomatophp?

Hi,
Do I have to learn livewire and filamentphp to use tomatophp?
thanks you

no you need to know about splade
https://splade.dev


Suggest: Create a validation-framework

To easily extend the validation and autoformatting capabilities of the backend in the future, we should implement some kind of framework. It should take a list of functions as input and execute them all on a suggestion.

If the functions want to change a suggestion, the framework should commit the changes per function, but push them all at once.

If the functions can not change the data, but wants to "comment", e.g. validation results, the framework could bundle these comments and post them as a GitHub-Comment in the PR.

I like the idea of commenting about formatting problems etc. But maybe we should instead implement that in the CI handler of datenanfragen/data? That way, we don't restrict this feature only to PRs submitted via the suggest site.

Good point 👍


[major] "Add client tunnel" button sometimes doesn't react to clicks meaningfully

not reproducible


Add the functionality to read Word documents

This would be an improved functionality.
Users can upload their resume document files, and this program reads and generates the data file for faster html build.

I'm actually interested in researching this and hopefully work on it as the project goes.
Could you expand on this functionality a bit more?

I found one package, called dotnet-mammoth. This package enables us to convert .docx file to html file or raw text file, running on C# .NET. Maybe we can use this to get all contents from user's resume and generate html file.


feat(repository): Add support for Azure ransomware protection

Adds support for containers that have policies + ImmutableStorageWithVersioning enabled (recommended combination for ransomware protection). It will also work without a policy, with ImmutableStorageWithVersioning enabled, but with slightly less protection (on the delete marker version until the first full maintenance, unless the policy and kopia set values match).
It's not possible to work with policies without ImmutableStorageWithVersioning enabled with kopia since at least one of the kopia. files is overwritten (and now also all other files).
On DeleteBlob, if a policy prevents deletion then create a new version with an unlocked policy then immediately remove the policy & the blob.
Doc updates would be a separate PR

Closed in favour of https://github.com/kopia/kopia/pull/3394


Did not remeasure list after deleting an item

From your example if i want to delete an item from list it did not remeasure. For example if i rearrange index 2 and delete it index 3 start drag from 1 step back from its previous offset. i also have added layoutInvalidationKey and tried extraData={this.state.data.length} and extraData={this.state}. Please help
Check this what i am trying to do

and here is code
`import React, { Component } from "react";
import { View, TouchableOpacity, Text } from "react-native";
import DraggableFlatList from "react-native-draggable-flatlist";
const exampleData = [...Array(20)].map((d, index) => ({
key: item-${index}, // For example only -- don't use index as your key!
label: index,
backgroundColor: rgb(${Math.floor(Math.random() * 255)}, ${index *         5}, ${132})
}));
class Example extends Component {
state = {
data: exampleData,
changecounter: 1
};
removeWidget(id) {
var statedata = this.state.data
var index = statedata.findIndex(x => x.key == item-${id})
if (index != -1) {
statedata.splice(index, 1)
}
this.setState({ data: statedata, changecounter: this.state.changecounter + 1 })
}
renderItem = ({ item, index, drag, isActive }) => {
return (
<TouchableOpacity
style={{
height: 150,
marginVertical: 20,
marginHorizontal: 20,
backgroundColor: isActive ? "blue" : item.backgroundColor,
alignItems: "center",
justifyContent: "center"
}}
activeOpacity={0.9}
onLongPress={drag}
>
<Text
style={{
fontWeight: "bold",
color: "white",
fontSize: 32
}}
>
{item.label}

<TouchableOpacity activeOpacity={0.9} onPress={() => { this.removeWidget(index) }}>X

);
};
render() {
    return (
        <View style={{ flex: 1 }}>
            <DraggableFlatList
                data={this.state.data}
                renderItem={this.renderItem}
                layoutInvalidationKey={this.state.changecounter}
                keyExtractor={(item, index) => `draggable-item-${item.key}`}
                onDragEnd={({ data }) => this.setState({ data })}
            />
        </View>
    );
}

}
export default Example;`

i have installed react-native-draggable-dynamic-flatlist and it is working fine thank you


Analyzer Supported Managers

The Analyzer source code shows support for CocoaPods but it is not listed under the Analyzer supported package managers in the documentation.
From the documentation point of view there are no references to Glide and dep (only Godep) in the Analyzer source code.
Could you please clarify which package managers are currently supported by ORT?

CocaoPods is not (yet) supported, see this code and this open issue.
Glide and dep support are listed as part of the README.md.

If the support for CocoaPods will be successful without the macOS requirement, will its implementation can be used in a similar way to support Carthage or is Carthage a whole different story?

Carthage support is a separate issue.


No such filter: 'v360

2021-07-08 23:26:17 Pixeluntu funscript_editor.ui.funscript_editor_window[2442334] INFO Stop at Frame -1
[AVFilterGraph @ 0x556c5f67fe80] '
Error reinitializing filters!
Failed to inject frame into filter network: Invalid argument
Error while processing the decoded data for stream #0:0
Traceback (most recent call last):
  File "/home/ethanfel/Python-Funscript-Editor/funscript_editor/algorithms/funscriptgenerator.py", line 955, in run
    status = self.tracking()
  File "/home/ethanfel/Python-Funscript-Editor/funscript_editor/algorithms/funscriptgenerator.py", line 621, in tracking
    projection_config = self.get_vr_projection_config(first_frame)
  File "/home/ethanfel/Python-Funscript-Editor/funscript_editor/algorithms/funscriptgenerator.py", line 503, in get_vr_projection_config
    preview = FFmpegStream.get_projection(image, config)
  File "/home/ethanfel/Python-Funscript-Editor/funscript_editor/data/ffmpegstream.py", line 151, in get_projection
    projection = np.frombuffer(
ValueError: cannot reshape array of size 0 into shape (720,1240,3)

doesn't seems to be able to track

resolved : Ubuntu 20.04 ffmpeg is too old
using this ppa resolved the issue
https://launchpad.net/~savoury1/+archive/ubuntu/ffmpeg4


Rename Shiny app and Repo to "MNcalc"

Is your feature request related to a problem? Please describe.
RedLake(s) should be RedLake.
And is more than RedLake as it is all of MN.
Hence the rename.
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

https://github.com/leppott/MNcalc/commit/9b0df6782bf3be7a9d77ad2df57647b9f2cbe90a
v<IP_ADDRESS>17


Users can differentiate between qualifying and display name

This issue is stale because it has been open for 30 days with no activity. Please remove stale label or add any comment to keep this open. Otherwise this will be closed in 5 days.

This issue was closed because it has been inactive for 35 days. Please re-open if this issue is still relevant.


Reject overrides with incompatible visibility

Closes #5522

Hi there, this is my first contribution and I don't usually write c++ so I'm very open to feedback and happy to make any changes. I picked this because it seemed like a good place to learn more about contributing to sorbet. Thanks!

We have a policy of testing changes to Sorbet against Stripe's codebase before
merging them. I've kicked off a test run for the current PR.  When the build
finishes, I'll share with you whether or how it failed. Thanks!
Stripe employees can see the build results here:
→ https://go/builds/bui_LcEsKhxOsmTz9B
→ https://go/builds/bui_LcEsAfyqZTqPNq

One thing that would make it easier for us to migrate Stripe's codebase (which will be required before we can land this change) as well as make it easier for others to adopt this Sorbet version would be if there was an autocorrect for this error.
One quick-and-dirty way to build such an autocorrect suggestion would be to check whether
methodData->loc().adjustLen(ctx, -8, 8).source(ctx) == "private "

and then using that with e.replaceWith (you should be able to grep to find examples of using replaceWith)
You might also want to add a couple more cases for e.g. private_class_method. It's honestly likely fine to ignore protected for the sake of autocorrects? (it's rarely used), but up to you.
It's unfortunately tricky to do this in a more principled way (e.g., by looking for the private in the AST) because at the point where definition_validator runs, the private method call has been moved somewhere else, and the method definition stands on its own. We also don't store any location information on the methodData that would point to where the private modifier lives in the source tree.

But building a 95% solution for autocorrects like this is almost always fine, and goes a long way towards making the sorbet upgrade process smoother.

To give you a sense of what these error messages look like on Stripe's codebase:
ops/lib/visa/clearing/clearing_generator/transaction_clearing_generator.rb:257: Override of Opus::Ops::Visa::Clearing::AbstractClearingGenerator#compute_authorization_date must be public but Opus::Ops::Visa::Clearing::TransactionClearingGenerator#compute_authorization_date is private. Alternatively, Opus::Ops::Visa::Clearing::AbstractClearingGenerator#compute_authorization_date can be made private http://go/e/5035
     257 |      private def compute_authorization_date
                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    ops/lib/visa/clearing/clearing_generator/abstract_clearing_generator.rb:357: Base method defined here
     357 |      def compute_authorization_date; end
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

I'd love if we could change these messages to make the error shorter and put the most relevant information in the beginning:
ops/lib/visa/clearing/clearing_generator/transaction_clearing_generator.rb:257: Method `compute_authorization_date` is private in `Opus::Ops::Visa::Clearing::TransactionClearingGenerator` but not in `Opus::Ops::Visa::Clearing::AbstractClearingGenerator` http://go/e/5035
     257 |      private def compute_authorization_date
                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    ops/lib/visa/clearing/clearing_generator/abstract_clearing_generator.rb:357: Base method defined here
     357 |      def compute_authorization_date; end
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

This:

mentions the specific method early, not after the class name
only mentions the method once, not once per parent / child class
mentions private before the potentially-long class name

Incidentally, this more closely matches the error message TypeScript would generate

One thing that would make it easier for us to migrate Stripe's codebase (which will be required before we can land this change) as well as make it easier for others to adopt this Sorbet version would be if there was an autocorrect for this error.
One quick-and-dirty way to build such an autocorrect suggestion would be to check whether
methodData->loc().adjustLen(ctx, -8, 8).source(ctx) == "private "

and then using that with e.replaceWith (you should be able to grep to find examples of using replaceWith)

I can take a look at this when I update the wording if desired, though I am a bit hesitant to be outside of the AST/metadata. In particular, it seems like this would only work if you use inline access modifiers. Most ruby codebases I've worked on use region-based private/proected/etc. and also separate private_class_method :name style declarations. I am happy to take a pass at this to help get it shipped but it wouldn't help my use case and I'm not sure what fraction of ruby code it would help.

I am happy to take a pass at this to help get it shipped but it wouldn't help my use case and I'm not sure what fraction of ruby code it would help.

Makes sense, though I still think that any autocorrect, even if it doesn't always trigger, is better than no autocorrect.
Stripe's codebase exclusively uses the private def foo; end syntax, so I suggested that one as if it existed, it would mean getting this PR merged sooner, but again, up to you whether/how much time you want to spend building autocorrects.


Referencing a header value in proxy

Hi,
We're currently using Azure Functions Proxy in following scenario:

Client sends a request with a following header: Authorization: TOKEN
Proxy should rewrite a request from Authorization header to x-functions-key:

Is this possible with the current implementation of Proxy? I haven't found any way to do so and I don't know how it'd possible to reference  to use it in the rewrite.
Any help is much appreciated.
Best regards,
Kamil

@mattchenderson Is this possible?

Please see this documentation for how to leverage variables from within a proxy.
For your particular case, I'd expect something like:
"requestOverrides" : {
    "backend.request.headers.x-functions-key" : "{request.headers.Authorization}",
    "backend.request.headers.Authorization" : ""
}

@mattchenderson Thank you for the response! Unfortunately I think I have a bit more complicated scenario.
I have following Authorization header: TOKEN <this_is_a_function_key>
I would like to rewrite to x-function-keys: <this_is_a_function_key> - without TOKEN
I would like to reference it in the same manner as referencing a value from e.g. application settings, let's say:
 "requestHeader": {    "Authorization": "TOKEN <function_key>" }, "requestOverrides" : {     "backend.request.headers.x-functions-key" : "{function_key}",     "backend.request.headers.Authorization" : "" }
something like that but I'm afraid it's not supported now(and would it be supported in the near future?)

This issue was moved to Azure/Azure-Functions#331


DCERPC Runtime Error: code: 0x5 - rpc_s_access_denied

The target os is win7 just installed.
root@kali:~# ranger -u test -p test -t <IP_ADDRESS> --smbexec -q -v -vv -vvv
[*] Attempting to access the system <IP_ADDRESS> with, user: test pwd: test domain: WORKGROUP at: 2016-02-29-22:47:25
[*] Trying protocol 445/SMB...
[*] Creating service BTOBTO...
[*] Creating tmp directory
[-] [Errno 17] File exists: '__tmp'
[*] Setting up SMB Server
[*] Config file parsed
[*] Ready to listen...
[-] DCERPC Runtime Error: code: 0x5 - rpc_s_access_denied

It looks like the problem is with the target not the attack you are using.  The protocol response suggests that either the Administrative Shares are disabled or there is a permission problem with the account.

You are also telling ranger to be quiet and then using varying levels of verbosity.  This will not cause the attack to fail, but it will not provide the results in the way you are expecting.  Use one of the following:
-q
-v
-vv
-vvv

The account could have access to WMIC disabled as well.  Since it's not
a login_failure it indicates the creds are valid.
On Tuesday, March 1, 2016, chrisduffy<EMAIL_ADDRESS>wrote:

It looks like the problem is with the target not the attack you are using.
The protocol response suggests that either the Administrative Shares are
disabled or there is a permission problem with the account.
—
Reply to this email directly or view it on GitHub
https://github.com/funkandwagnalls/ranger/issues/4#issuecomment-190687673
.

--
Sent from my iPhone


Simplify a few patterns in the move prover

More usage of Option/Result combinators and ?

Thanks!

@bors-libra r=sblackshear

@huitseeker: :key: Insufficient privileges: Collaborator required

@bors-libra r+

:pushpin: Commit f2e1c31 has been approved by wqfish

:hourglass: Testing commit f2e1c3144ab8804413d6bf32eca113b647217421 with merge 04cc830afd456ac42a4417052e6dd44e91f99426...

:sunny: Test successful - checks-actions_land_blocking_test, checks-circle_commit_workflow
Approved by: wqfish
Pushing 04cc830afd456ac42a4417052e6dd44e91f99426 to master...


Feedback fails if logs folder is missing

I have not "installed" the service so I do not have the LogsFolder on my machine. This causes the app to crash here:

Fixed in 1.0.5 release


org.jetbrains.kotlin.util.KotlinFrontEndException: Front-end Internal error: Failed to analyze declaration

We try to use "mvi" in our project, when we use inner classes to define Store, we will encounter this problem. #339
Is there any update on this error?

See #339 for updates. Closing this as a duplicate.


Cannot set HTML maxlength attribute to input field

I need to limit the amount of characters user is able to type/copy into  when adding new tag, however it seems impossible to edit that template.

Any solution?


Question: How to get the value of the input when it's an invalid value?

Hi there, any suggestions on how to disable manual entry on the input fields?
Thank you :)

That would not be accessible, nor gracefully degrade when JS breaks or fails to load. Why would you want that?

Hmm I see. Rephrasing my question, is there a way for me to get the value of the input even if it is not a valid value? Right now, onDateChange(), if the date is invalid, all I see is a null value. Basically, I'm needing to validate the value of the input field.

That's a different question indeed :-) can you give an example value, and explain a bit about what validation you'd want to perform?

Cool, example values would be:

1/1/2017 - basically any invalid formats (react-dates wants a MM/DD/YYYY format)
1/1/2017! - if inputs have invalid characters
date that is out of the acceptable range.

I'll change the title of this question :) Lol.

Thank - what validation would you want to perform?

Basically if the value in the input field is a valid date, which it could be a moment object or in proper format of MM/DD/YYYY.
I can handle the validation outside of react-dates, I just need to be able to have access to the actual value of the input field :)

Right - but moment does the validation for you, that's why I'm wondering what kind of validation you want to perform yourself.
I do think it makes sense for react-dates to expose the actual input value, fwiw.

Yeah, having access to the actual input value would be nice. I'd like to be able to show a proper error message according to the validation.
Curious what kind of validation does Moment have and maybe we can expose that instead?
I appreciate your time and answering my questions, @ljharb.

I will look into how best to accomplish this.

Is there any updates for gaining access to the actual value of the input field ?

I got my manual input validation working, so ill leave it here.
All i use is the propagation of events. Therefore i use a container element, which gets the onChange event of the input propagated. The onChange Event is not fired for onDateChange.
<div onChange={::this.onChange}>
<SingleDatePicker .../>
</div>

If all that's wanted is the value from the input field, passing some callback al the way down to DateInput and running it on the partial string might be the way to go.
For more customizable validation, would it work to allow customFormat to be an array of formats instead of just a string? And concat the formats in toMomentObject() instead of using just the one.

@passi246 I'm also trying to get the value of the input so I can validate them. The moment validation isn't very useful because when you click on the first date the endDate is null but that dosen't mean it's invalid because the user hasn't ended selecting dates. I can't get the onChange event working for me on a wrapper div. Did you try on a DataRange component?

@majapw any updates on this, I've had to adopt @passi246 approach above, but it feels hacky.
The UX rationale behind this is that a user selects a date, then they realise they need to time travel about 10 years, so instead of clicking like a maniac, they select the input and manually type their year. But let's say they mistyped the year or broke the formatting, we need to have a way to tell them about their error and the only real way to do this is through the value of the real input behind datepicker.
Let me know if I can help in anyway with a PR

currently I am using the id and get the value of the input by that  id
<SingleDatePicker
  ...
  id="your_unique_id" // PropTypes.string.isRequired,
/>

Similar issue here. I am trying to implement a feature which auto corrects users' input.
1/01/2019 => 01/01/2019
Right now with @passi246 approach, I could only read the input change but not set its state.
  onChange(e) {
    const { onChange, onKeyDownQuestionMark } = this.props;
    const dateString = e.target.value;

    // In Safari, onKeyDown does not consistently fire ahead of onChange. As a result, we need to
    // special case the `?` key so that it always triggers the appropriate callback, instead of
    // modifying the input value
    if (dateString[dateString.length - 1] === '?') {
      onKeyDownQuestionMark(e);
    } else {
      this.setState({ dateString }, () => onChange(dateString));
    }
  }

The is the onChange function from DateInput.jsx. I am thinking an optional callback prop could be allowed to be passed down which can parse the "dateString" at setState?
  ...
  } else {
    this.setState({ this.props.callback(dateString) }), () => onChange(this.props.callback(dateString)));
  }
  ...

Obtaining the raw value via the DOM worked for me, but it's hacky. The component should definitely expose the raw value, and allow some control for those who need to validate externally. document.getElementById(this.props.input.name).value

Is there a reason events aren't passed up the chain? In most cases, allowing developers to have access to the event object so they can get data and/or call functions on the event is very helpful and would solve this problem.
onChange(e) {
    const { onChange, onKeyDownQuestionMark } = this.props;
    const dateString = e.target.value;

    // In Safari, onKeyDown does not consistently fire ahead of onChange. As a result, we need to
    // special case the `?` key so that it always triggers the appropriate callback, instead of
    // modifying the input value
    if (dateString[dateString.length - 1] === '?') {
      onKeyDownQuestionMark(e);
    } else {
      this.setState({ dateString }, () => onChange(dateString, e)); <-- would have to do this for backwards compat...
    }
  }

Are there any plans to implement it?


The SQlite3 backend gives "create pin: database is locked" when attempting to create a pin

./sips -dbdriver sqlite3 -db 'database.sqlite3?_fk=1' -addr ':8051' &
sleep 5
./sipsctl users add --dbdriver sqlite3 --db 'database.sqlite3?_fk=1' user-name
./sipsctl tokens add --dbdriver sqlite3 --db 'database.sqlite3?_fk=1' --user user-name

ipfs pin remote service add mysips http://my_domain:8051 TOKEN
echo 'Hi' > /tmp/hello
h=$(ipfs add --pin=false -Q /tmp/hello)
ipfs pin remote add --service=mysips --name=hi-example "$h"

2023/04/15 23:48:23 [INFO] (cmd/sips/sips.go:63) database opened at "database.sqlite3?_fk=1"
2023/04/15 23:48:23 [INFO] (cmd/sips/sips.go:66) running database migration
2023/04/15 23:48:23 [INFO] (cmd/sips/sips.go:105) starting server on ":8051"
2023/04/15 23:50:19 [ERROR] (cmd/sips/pinhandler.go:119) create pin: database is locked

This is expected behavior, unfortunately, and one of the main reasons why the Postgres backend was added as well. SQLite3 doesn't allow multiple processes to access the same database file simultaneously. In order to run sipsctl, sips can't also be running.

The pin remote add action is done way after sipsctl exited, do you mean that if sipsctl is executed while sips is running, sips needs to be restarted otherwise its connection is broken? :thinking:
I tried:
# Do the database init/migration and kill the sips server
./sips -dbdriver sqlite3 -db 'database.sqlite3?_fk=1' -addr ':8051' & PID=$!
sleep 5
kill $PID

# add the user and create its token
./sipsctl users add --dbdriver sqlite3 --db 'database.sqlite3?_fk=1' user-name
./sipsctl tokens add --dbdriver sqlite3 --db 'database.sqlite3?_fk=1' --user user-name

# Sstart sips again, now that sipsctl has finished working
./sips -dbdriver sqlite3 -db 'database.sqlite3?_fk=1' -addr ':8051' &

ipfs pin remote service add mysips http://my_domain:8051 TOKEN
echo 'Hi' > /tmp/hello
h=$(ipfs add --pin=false -Q /tmp/hello)
ipfs pin remote add --service=mysips --name=hi-example "$h"

and get the same error

The pin remote add action is done way after sipsctl exited, do you mean that if sipsctl is executed while sips is running, sips needs to be restarted otherwise its connection is broken?

No, it definitely shouldn't need to be.  Strange. I'll take a look when I get a chance.


youtube-dl: 2019.09.28 -> 2019.10.16

Motivation for this change
Update youtube-dl to the latest release.

https://github.com/ytdl-org/youtube-dl/releases/tag/2019.10.16

NOTE: Updates to youtube-dl should be backported, thanks!
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Notify maintainers
cc @bluescreen303 @phreedom @AndersonTorres @fuuzetsu @fpletz @enzime

@jonringer Thank you!!


Gh129 stairs array arithmetic ops

[ ] closes #xxxx
[ ] tests added / passed
[ ] ensure all linting tests pass
[ ] changelog entry

Codecov Report

Merging #130 (6420530) into master (0efdb40) will decrease coverage by 0.24%.
The diff coverage is 94.28%.

@@            Coverage Diff             @@
##           master     #130      +/-   ##
==========================================
- Coverage   95.89%   95.64%   -0.25%
==========================================
  Files          34       34
  Lines        1925     1953      +28
==========================================
+ Hits         1846     1868      +22
- Misses         79       85       +6

Impacted Files
Coverage Δ

staircase/core/arrays/extension.py
95.55% <88.88%> (-0.90%)
:arrow_down:

staircase/core/arrays/docstrings.py
98.30% <100.00%> (+0.18%)
:arrow_up:

staircase/__init__.py
78.26% <0.00%> (-17.40%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0efdb40...6420530. Read the comment docs.


update website

Sooooo. My initial goal was to set up some sort of routing that would redirect us to Vercel.com if the user wants to open the landing page, but that task turned out to be less than trivial.
After much consulting with Sean, and a bit of trial and error, I decided to just take the plunge, and move every route currently handled by website to a new website-next project, which is a Next.js app hosting the landing page, projects page and other misc. things.
The main upside is the following:
create-react-app generated a static html for us that was just an empty white page, and it contained a js bundle that would load and draw the page. This was probably fine for the projects page and preview page, but pretty ugly for the main landing page.
Next.js can generate a static html for every route we have, that will contain either the full content (for the landing page) or a placeholder/empty content (for the projects page, this is not as important). I think I am beyond 80% completing this task, the only remaining main thing is that I need to change the haskell server so if you load something like utopia.app/projects it tries to serve public/projects.html instead of always resolving to always serving public/index.html. Sean told me it should be fine and there's no sharks waiting for me.
TODO:

[x] Bump create-react-app
[x] Realize create-react-app can never generate contentful static html, also that it is not too much effort to just kill it and replace it with Next.js
[x] bring the utopia-landing-page code in to website-next, this is the home of our new next.js project
[x] move all routes over from website. as far as I can tell, these all work in next.js too
[x] verify I didn't accidentally bloat the initial js bundle for the landing page
[x] make it so that the Haskell server can load projects.html for routes such as utopia.app/projects (I think this will be a fallback-type behavior, I'll nag @seanparsons  about how to do it
[x] for some reason localhost:8000/login stopped working, I need to figure this out
[x] website would refuse to build without a UTOPIA_SHA, I probably need to replicate this in Next
[x] delete the old website project
[x] change the editor src/common symlink to point to website-next/components/common
[ ] profit
[x] CDN!?!

there's also a corresponding change to the deploy project here: https://github.com/concrete-utopia/utopia-deploy/pull/20

move every route currently handled by website to a new website-next project

Since the old website project is being completely deleted, please can you revert the name of the new one to website

move every route currently handled by website to a new website-next project

Since the old website project is being completely deleted, please can you revert the name of the new one to website

my thinking was that this will make it clear if some script wants to cd into cd website and it makes our lives easier fixing those.
plus this PR I think would be much harder to read if the next files, moved files, and the deleted website files would be all intermixed


Web browser caching (Firefox) causes DOWNLOAD ZIP to download the zip file from a previous session

Web browser caching (Firefox) causes DOWNLOAD ZIP to download the zip file from a previous session

Could you try again with the version deployed over at https://t2wml.isi.edu/?
(I've set the cache setting to be no-store for the download file requests)

Fixed


Ask for a GraphFrame release for Spark 2.4 and Scala 2.12

All GraphFrame releases for 2.4 are build against Scala 2.11. Many dependencies of the connector require Scala 2.12, so we cannot compile it against 2.11. Therefore, we cannot support GraphFrames for Spark 2.4.
If they would provide a 2.12 release for Spark 2.4, then we could support GraphFrames for 2.4 as well. Spark provides both Scala 2.11 and 2.12.

Hm, is this likely to happen given Spark 3.0's recent release?  It seems like the community is mostly focused on pushing forward.

I am sure Spark 2.4 will be around for a while. I'll raise it with them and see what they say.

Looks like many users are looking for this: https://github.com/graphframes/graphframes/issues/364

They have released Graphframes 0.8.1 for Spark 2.4 and Scala 2.12. Integrated into our 2.4 branch, tests are green. Will go out in next connector release.


[FATAL] Velocity compatibility

When I use the command that EasyCommandBlocker is trying to block, I get the following error
[06:23:32 FATAL]: A plugin tried to deny a command with signable component(s). This is not supported. Disconnecting player Username.
Velocity Details:

[06:26:32 INFO]: Velocity 3.1.2-SNAPSHOT (git-7d77bfb5-b184)
[06:26:32 INFO]: Copyright 2018-2021 Velocity Contributors. Velocity is licensed under the terms of the GNU General Public License v3.
[06:26:32 INFO]: velocitypowered.com - GitHub

config.yml:
tab:
  default:
    priority: 0
    commands: []
blocked_command_default_actions:
  - "message: &8&l〘&c&nCЕРВЕР&8&l〙&7Команда не найдена или у вас нету доступа для выполнения этой команды."
use_commands_as_whitelist: false
commands:
  - "/velocity"
  - "/server"
  - "/lpv"
custom_commands_actions:
  example:
    commands: []
    actions: []

I am not very familiar with the new chat system of 1.19 but it seems there should be an option on velocity for that, and prevent the signed chat.

Are you talking about being able to configure this inside velocity?


18.2.4

There was a major bug fixed in DevEx 18.2.4. Do you know when eXpand 18.2.4 will be available? I have to get to production asap. THANKS!

Found another question on this. I am closing this one. Sorry for the duplicate!

just a few more hours

Also wainting for this. Thanks for your contribution Tolis. It helps really a lot.


add_comp_health.R - should be ind_healthcare_ everywhere not ind_health_care

Discussed in https://github.com/impact-initiatives-hppu/humind/discussions/412

Originally posted by lanawwas July  5, 2024
In the add_com_health.R#L62, 61 and 51 > We need to change the current code from "ind_health_care_" to "ind_healthcare_"
The changes will be updated in the unit-test branch @gnoblet

solved in 59efc98


Send more providers to the Apply service

Context
Follows prior art. Also https://github.com/DFE-Digital/find-teacher-training/pull/44
Changes proposed in this pull request
I am determined to make the longest if statement you have ever seen.
Guidance to review
:shipit:

 Send more providers to Apply

 Send more providers to Apply


Is there an option to create hardlink?

Is there an option to create hardlink?

no, hardlinks are only possible with files. Hard links do not support directories

Got it, thanks


login with root

Hello Sr.
I want to login ssh use root, not use standard user, I'v changed sshd_config (PermitEmptyPasswords no to yes) after the  script  installation， But also can't  login with  root account.
Please tell me how to chang it. I want to use root account in WinWCP, Please help me, Thanks!

See the wiki ssh page, there are instructions there - https://github.com/arakasi72/rtinst/wiki/SSH


gccgo: export data linked into binary

With gccgo,
$ go version
go version go1.10.3 gccgo (GCC) 9.0.0 20180622 (experimental) linux/amd64
$ gccgo --version
gccgo (GCC) 9.0.0 20180622 (experimental)
Copyright (C) 2018 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

$ go build -gccgoflags="-static-libgo" hello.go
$ objdump -h hello

hello:     file format elf64-x86-64

Sections:
Idx Name          Size      VMA               LMA               File off  Algn
...
 31 .go_export    000363b8<PHONE_NUMBER>000000<PHONE_NUMBER>000000  002b460b  2**0
                  CONTENTS, READONLY
...

Dumping out the .go_export section, it looks like indeed export data. I think it is not needed at run time. It probably should not be linked into the binary.
-static-libgo is just for demonstration. The export data also present in the default dynamically linked binary, or completely -static binary, though the size varies.
With some big binaries, like kubernetes, the export data can be quite big (over 40% of the binary size).
cc @ianlancetaylor

cc @aclements

We use the system linker.  We want the export data to be present in a shared library, but not in an executable.  I don't know of a way to tell the linker to do that.
Perhaps we could have the go tool run objcopy --remove-section .go_export EXECUTABLE.

Does a shared library produced by gollvm have the export data?

I'm wondering how important it is to support this use case -- do people actually rely on this behavior?

My preference would be to keep the current behavior (not incorporate the export data when linking) -- perhaps as a fallback we could add a command line flag to enable it (in case someone really needs this)?

I guess a command line option would be consistent with the general GCC approach to these matters.


Face descriptors question

Hi there, sorry about my question but im kinda new in that area yet.
Im trying figure how works and what represents each point of face descriptors, i mean, i know the  landmarks are just [x,y] positions of the face points that we detected using the framework, but when it is transformed to Face descriptors i just see an array of decimals that not sure if they are represnetable in any graffic? or how i can know what face descriptor correspond to what face landmark point?
I would like to can know what face descriptor corresponds with a concrete point of the face, and i what format?
If anyone can assist me would be great.
Thx you all in advance and again sorry about my english.

it's a calculated value in  format.

Computes a 128 entry vector (face descriptor / face embeddings) from the face shown in an image,
which uniquely represents the features of that persons face. The computed face descriptor can
be used to measure the similarity between faces, by computing the euclidean distance of two
face descriptors.


kvstore: clean up casting around kvstore.Encode

Replace []byte with *string. In go, string is in effect a read-only slice of
bytes https://blog.golang.org/strings. The only semantic difference would be
that a byte[] can be nil, but a string can't, so use *string.
Fixes: #8630
Signed-off-by: Boran Car<EMAIL_ADDRESS>

This change is

Coverage increased (+0.007%) to 44.039% when pulling 0cea0143583e6618082c5bd373d84c1a4d588821 on borancar:clean/kvstore-encode-casting into 88f3fd5f08c3ca5671cf401744f4f3c0ee56d7ba on cilium:master.

test-me-please

I can't reproduce the Ginkgo test failure locally on k8s 1.15 (and 1.11) and I don't get any "Key allocation attempt failed" in the cilium-test.log.
$ ginkgo --focus="Istio Bookinfo Demo Tests" -- -cilium.testScope k8s
level=info msg="environment variable \"K8S_VERSION\" was not set; setting to default value \"1.15\""
User specified the scope:  "k8s"
Running Suite: Suite-k8s-1.15
=============================
Random Seed:<PHONE_NUMBER>
Will run 1 of 366 specs

Spinning up vagrant VMs... ●SSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSS

------------------------------
• [SLOW TEST:1533.397 seconds]
K8sIstioTest
/home/boran/go/src/github.com/cilium/cilium/test/ginkgo-ext/scopes.go:385
  Istio Bookinfo Demo
  /home/boran/go/src/github.com/cilium/cilium/test/ginkgo-ext/scopes.go:385
    Tests bookinfo inter-service connectivity
    /home/boran/go/src/github.com/cilium/cilium/test/ginkgo-ext/scopes.go:420
------------------------------
SSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSS
Ran 1 of 366 Specs in 1533.399 seconds
SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 365 Skipped
PASS

Ginkgo ran 1 suite in 25m36.312180374s
Test Suite Passed

Can we rerun the the tests please?

test-me-please

@borancar can you rebase against master instead? (We try to avoid merge commits)
I'll trigger a test-me-please in the meanwhile

test-me-please

Rebased. This is the link to the previous tests, before the rebase - https://jenkins.cilium.io/job/Cilium-PR-Ginkgo-Tests-Validated/14913/. There was an issue provisioning the VMs, it seems:
03:08:28  VBoxManage: error: Machine 'a38c7b8c-bf31-4439-bd75-8ef7a9f32f84' is not currently running
03:08:28  0%...10%...20%...30%...40%...
03:08:28  Progress state: VBOX_E_INVALID_OBJECT_STATE
03:08:28  VBoxManage: error: Machine delete failed
03:08:28  VBoxManage: error: Medium '/root/VirtualBox VMs/ubuntu-18.04.3-amd64-32_1568076335632_91690/ubuntu-18.04.3-amd64-32-disk001.vmdk' is locked for reading by another task
03:08:28  VBoxManage: error: Details: code VBOX_E_INVALID_OBJECT_STATE (0x80bb0007), component MediumWrap, interface IMedium
03:08:28  VBoxManage: error: Context: "RTEXITCODE handleUnregisterVM(HandlerArg*)" at line 162 of file VBoxManageMisc.cpp

Could we rerun tests, please? :)

For merging, if tests are successful, could you Squash and rebase please, since the 2nd commit deals solely with fixing Hound issues?


DOC change master to main in file workflow.md

This is a PR to change master to main in contributing/workflow.md.

Thanks @marenwestermann


panic: couldn't find task

panic: couldn't find task

goroutine 12 [running]:
honnef.co/go/gotraceui/trace/ptrace.(*Trace).Task(0x140007c19e0, 0x30?)
        /Users/treilly/go/pkg/mod/honnef.co/go/gotraceui@v0.2.0/trace/ptrace/ptrace.go:1037 +0x88
main.userRegionSpanTooltip(0x14000098100, {{{0xea2, 0x9ac}, {0xea2, 0x9ac}}, {0x40000000, 0x40000000}, {0x10087cbd8, 0x140007b86d0}, {0xc11b4a51f7e16b80, ...}, ...}, ...)
        /Users/treilly/go/pkg/mod/honnef.co/go/gotraceui@v0.2.0/cmd/gotraceui/goroutine.go:1135 +0xf8
main.(*Track).Layout.func2.1(0x140000b2750?, {{{0xea2, 0x9ac}, {0xea2, 0x9ac}}, {0x40000000, 0x40000000}, {0x10087cbd8, 0x140007b86d0}, {0xc11b4a51f7e16b80, ...}, ...})
        /Users/treilly/go/pkg/mod/honnef.co/go/gotraceui@v0.2.0/cmd/gotraceui/timeline.go:751 +0xc4
honnef.co/go/gotraceui/theme.(*Window).Render(0x14000098100, 0x14001a46790?, {{0xc11b4a51f7e16b80, 0x19164e89c01, 0x100c75ee0}, {0x40000000, 0x40000000}, {0xea2, 0x9ac}, {0x0, ...}, ...}, ...)
        /Users/treilly/go/pkg/mod/honnef.co/go/gotraceui@v0.2.0/theme/window.go:87 +0x788
main.(*MainWindow).Run(0x140007c4000, 0x140007b8600)
        /Users/treilly/go/pkg/mod/honnef.co/go/gotraceui@v0.2.0/cmd/gotraceui/main.go:696 +0x520
main.main.func3()
        /Users/treilly/go/pkg/mod/honnef.co/go/gotraceui@v0.2.0/cmd/gotraceui/main.go:1301 +0x9c
created by main.main
        /Users/treilly/go/pkg/mod/honnef.co/go/gotraceui@v0.2.0/cmd/gotraceui/main.go:1299 +0x4f8

Playing with runtime/trace API, I have a trace file that has a trace.Task that may or not start in the trace and may or may not end in the trace which I'm guessing trips this code up.   It happens when I focus on the goroutine that created the Task.   I can share trace file if needed but its large (22mb/11mb zipped).

I hit this bug previously and it is already fixed on the master branch. I don't think a release has come out that includes it yet though.

whereswaldon is correct.


Remove storybooks

Fixes #925
Changes:

Removed Storybooks and related code
Added regular snapshot tests for some components:

[x] Follow
[x] Action
[x] Topic
[x] Topics
[x] InterestingPeople
[x] LatestComments
[x] UserMenu
[x] TopicSelector

This looks fine to me, but I noticed that you named your test files the same as the component names. For my tests that I added for wallet page I named them with a .test.js as the file extension, so for UserWalletSummary, I had it as UserWalletSummary.test.js. Do you think we should name them with file extension like .test.js  or -test.js? Or keep it same as component name?

Jest watches files that are inside __tests__ or __specs__ or files that have .test.js or .spec.js.
Adding this suffix to files already inside __tests__ folder seems a bit too verbose.

The reason why I added those file extensions, is when I do a quick search for filename it doesn't display directory path, and only file names in WebStorm. :(

But I guess it's fine without them


how can I dump a bevfusion model to onnx?

I try to dump a detection model to onnx by following command, but failed
python tools/export.py configs/nuscenes/det/transfusion/secfpn/camera+lidar/swint_v0p075/convfuser.yaml pretrained/bevfusion-det.pth

error

after fix the config problem, another error occurred

Hi @hych2020,
It might be hard to export BEVFusion to onnx currently. The input problem you met with can be solved by manually passing these arguments into the forward function instead of relying on the containers in mmcv. However, our model is composed of SparseConv layers and customized CUDA ops (such as BEV pooling). Exporting them to onnx will require significant work and we haven't started trying that.
Best,
Haotian

Hi @kentang-mit
Thank you.
I got it.
So How do you measure FPS on Specific hardware， using the pytorch model directly?
I thought it was converting to onnx first，then deployed with TensorRT。

Hi @hych2020,
You can check out this issue. TensorRT is not used in latency measurement. With that being said, I expect the latency to be lower than what is reported in the paper if we eventually have the pipeline you mentioned.
Best,
Haotian

OK! Thank you very much!

I try to dump a detection model to onnx by following command, but failed
python tools/export.py configs/nuscenes/det/transfusion/secfpn/camera+lidar/swint_v0p075/convfuser.yaml pretrained/bevfusion-det.pth

error
after fix the config problem, another error occurred

Hi hych, do you exported the model to onnx.?


Avoiding runtime error

Avoiding the following runtime error when runnig the code.
RuntimeError: a view of a leaf Variable that requires grad is being used in an in-place operation.

in which case this error will occur? Do you train img_projection or img_processor?

This error happend for me when training on one GPU (export WORLD_SIZE=1). Implementing this patch fixed the issue for me!

This error happend for me when training on one GPU (export WORLD_SIZE=1). Implementing this patch fixed the issue for me!

Hi, do you set to train img_projection or img_processor?
May you uncomment https://github.com/GaiZhenbiao/Phi3V-Finetuning/blob/ad9c3fe4cfd83fecf51f39484a1f29ce0f2cdd95/train_phi3v.py#L288 in train_phi3v.py to check the status of parameters? In my experiments on multiple GPUs, requires_grad of img_projection and img_processor are all False. In  this case, I cannot understand why this error occurs.

Hi,
I had the same error when try to finetune with my own jupyter notebook and fixed it in the same way.

in which case this error will occur? Do you train img_projection or img_processor?

Got this error using just train.sh.
I don't know exactly why I got this error too.

Hi, @2U1 @ayylemao @shlyahin Can you give me the results of following code (after uncommenting)?
https://github.com/GaiZhenbiao/Phi3V-Finetuning/blob/ad9c3fe4cfd83fecf51f39484a1f29ce0f2cdd95/train_phi3v.py#L288-L290
And can you try to add model.requires_grad_(False) right after the model is loaded by from_pretrained? Does the error still occur in this case?

@ParadoxZW I've just uncommented the codes I fixed, and run your code.
Here are the txt files
debug_0.txt
debug_0.txt
debug_1.txt
debug_1.txt
debug_2.txt
debug_2.txt
debug_3.txt
debug_3.txt

Hi, @2U1 @ayylemao @shlyahin Can you give me the results of following code (after uncommenting)?
https://github.com/GaiZhenbiao/Phi3V-Finetuning/blob/ad9c3fe4cfd83fecf51f39484a1f29ce0f2cdd95/train_phi3v.py#L288-L290
And can you try to add model.requires_grad_(False) right after the model is loaded by from_pretrained? Does the error still occur in this case?

Hi, @2U1 @ayylemao @shlyahin Can you give me the results of following code (after uncommenting)?
https://github.com/GaiZhenbiao/Phi3V-Finetuning/blob/ad9c3fe4cfd83fecf51f39484a1f29ce0f2cdd95/train_phi3v.py#L288-L290
And can you try to add model.requires_grad_(False) right after the model is loaded by from_pretrained? Does the error still occur in this case?

Traceback (most recent call last):   File "/home/workspace/Phi3V-Finetuning/train_phi3v.py", line 360, in <module>     train()   File "/home/workspace/Phi3V-Finetuning/train_phi3v.py", line 351, in train     trainer.train()   File "/opt/conda/envs/travl/lib/python3.10/site-packages/trl/trainer/sft_trainer.py", line 361, in train     output = super().train(*args, **kwargs)   File "/opt/conda/envs/travl/lib/python3.10/site-packages/transformers/trainer.py", line 1885, in train     return inner_training_loop(   File "/opt/conda/envs/travl/lib/python3.10/site-packages/transformers/trainer.py", line 2216, in _inner_training_loop     tr_loss_step = self.training_step(model, inputs)   File "/opt/conda/envs/travl/lib/python3.10/site-packages/transformers/trainer.py", line 3238, in training_step     loss = self.compute_loss(model, inputs)   File "/opt/conda/envs/travl/lib/python3.10/site-packages/transformers/trainer.py", line 3264, in compute_loss     outputs = model(**inputs)   File "/opt/conda/envs/travl/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1511, in _wrapped_call_impl     return self._call_impl(*args, **kwargs)   File "/opt/conda/envs/travl/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1520, in _call_impl     return forward_call(*args, **kwargs)   File "/opt/conda/envs/travl/lib/python3.10/site-packages/deepspeed/utils/nvtx.py", line 15, in wrapped_fn     ret_val = func(*args, **kwargs)   File "/opt/conda/envs/travl/lib/python3.10/site-packages/deepspeed/runtime/engine.py", line 1852, in forward     loss = self.module(*inputs, **kwargs)   File "/opt/conda/envs/travl/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1511, in _wrapped_call_impl     return self._call_impl(*args, **kwargs)   File "/opt/conda/envs/travl/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1520, in _call_impl     return forward_call(*args, **kwargs)   File "/opt/conda/envs/travl/lib/python3.10/site-packages/peft/peft_model.py", line 1129, in forward     return self.base_model(   File "/opt/conda/envs/travl/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1511, in _wrapped_call_impl     return self._call_impl(*args, **kwargs)   File "/opt/conda/envs/travl/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1520, in _call_impl     return forward_call(*args, **kwargs)   File "/opt/conda/envs/travl/lib/python3.10/site-packages/peft/tuners/tuners_utils.py", line 161, in forward     return self.model.forward(*args, **kwargs)   File "/opt/conda/envs/travl/lib/python3.10/site-packages/accelerate/hooks.py", line 166, in new_forward     output = module._old_forward(*args, **kwargs)   File "/home/workspace/Phi3V-Finetuning/model/modeling_phi3_v.py", line 1301, in forward     outputs = self.model(   File "/opt/conda/envs/travl/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1511, in _wrapped_call_impl     return self._call_impl(*args, **kwargs)   File "/opt/conda/envs/travl/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1520, in _call_impl     return forward_call(*args, **kwargs)   File "/opt/conda/envs/travl/lib/python3.10/site-packages/accelerate/hooks.py", line 166, in new_forward     output = module._old_forward(*args, **kwargs)   File "/home/workspace/Phi3V-Finetuning/model/modeling_phi3_v.py", line 1128, in forward     inputs_embeds = self.vision_embed_tokens(input_ids, pixel_values=pixel_values, image_sizes=image_sizes)   File "/opt/conda/envs/travl/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1511, in _wrapped_call_impl     return self._call_impl(*args, **kwargs)   File "/opt/conda/envs/travl/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1520, in _call_impl     return forward_call(*args, **kwargs)   File "/opt/conda/envs/travl/lib/python3.10/site-packages/accelerate/hooks.py", line 166, in new_forward     output = module._old_forward(*args, **kwargs)   File "/home/workspace/Phi3V-Finetuning/model/image_embedding_phi3_v.py", line 280, in forward     hidden_states[positions[idx, 0], positions[idx, 1] : positions[idx, 1] + cnt] = ( RuntimeError: a view of a leaf Variable that requires grad is being used in an in-place operation.
It gives the same error when running with the suggenestions you gave me.

I’m investigating whether this is caused by vram capacity reasons. Maybe deepspeed’s behavior varies with that.

2024年6月5日 12:57，Yu-won Lee @.***> 写道：
Hi, @2U1 https://github.com/2U1 @ayylemao https://github.com/ayylemao @shlyahin https://github.com/shlyahin Can you give me the results of following code (after uncommenting)?
https://github.com/GaiZhenbiao/Phi3V-Finetuning/blob/ad9c3fe4cfd83fecf51f39484a1f29ce0f2cdd95/train_phi3v.py#L288-L290
And can you try to add model.requires_grad_(False) right after the model is loaded by from_pretrained? Does the error still occur in this case?
Hi, @2U1 https://github.com/2U1 @ayylemao https://github.com/ayylemao @shlyahin https://github.com/shlyahin Can you give me the results of following code (after uncommenting)?
https://github.com/GaiZhenbiao/Phi3V-Finetuning/blob/ad9c3fe4cfd83fecf51f39484a1f29ce0f2cdd95/train_phi3v.py#L288-L290
And can you try to add model.requires_grad_(False) right after the model is loaded by from_pretrained? Does the error still occur in this case?
Traceback (most recent call last): File "/home/workspace/Phi3V-Finetuning/train_phi3v.py", line 360, in  train() File "/home/workspace/Phi3V-Finetuning/train_phi3v.py", line 351, in train trainer.train() File "/opt/conda/envs/travl/lib/python3.10/site-packages/trl/trainer/sft_trainer.py", line 361, in train output = super().train(*args, **kwargs) File "/opt/conda/envs/travl/lib/python3.10/site-packages/transformers/trainer.py", line 1885, in train return inner_training_loop( File "/opt/conda/envs/travl/lib/python3.10/site-packages/transformers/trainer.py", line 2216, in _inner_training_loop tr_loss_step = self.training_step(model, inputs) File "/opt/conda/envs/travl/lib/python3.10/site-packages/transformers/trainer.py", line 3238, in training_step loss = self.compute_loss(model, inputs) File "/opt/conda/envs/travl/lib/python3.10/site-packages/transformers/trainer.py", line 3264, in compute_loss outputs = model(**inputs) File "/opt/conda/envs/travl/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1511, in _wrapped_call_impl return self._call_impl(*args, **kwargs) File "/opt/conda/envs/travl/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1520, in _call_impl return forward_call(*args, **kwargs) File "/opt/conda/envs/travl/lib/python3.10/site-packages/deepspeed/utils/nvtx.py", line 15, in wrapped_fn ret_val = func(*args, **kwargs) File "/opt/conda/envs/travl/lib/python3.10/site-packages/deepspeed/runtime/engine.py", line 1852, in forward loss = self.module(*inputs, **kwargs) File "/opt/conda/envs/travl/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1511, in _wrapped_call_impl return self._call_impl(*args, **kwargs) File "/opt/conda/envs/travl/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1520, in _call_impl return forward_call(*args, **kwargs) File "/opt/conda/envs/travl/lib/python3.10/site-packages/peft/peft_model.py", line 1129, in forward return self.base_model( File "/opt/conda/envs/travl/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1511, in _wrapped_call_impl return self._call_impl(*args, **kwargs) File "/opt/conda/envs/travl/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1520, in _call_impl return forward_call(*args, **kwargs) File "/opt/conda/envs/travl/lib/python3.10/site-packages/peft/tuners/tuners_utils.py", line 161, in forward return self.model.forward(*args, **kwargs) File "/opt/conda/envs/travl/lib/python3.10/site-packages/accelerate/hooks.py", line 166, in new_forward output = module._old_forward(*args, **kwargs) File "/home/workspace/Phi3V-Finetuning/model/modeling_phi3_v.py", line 1301, in forward outputs = self.model( File "/opt/conda/envs/travl/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1511, in _wrapped_call_impl return self._call_impl(*args, **kwargs) File "/opt/conda/envs/travl/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1520, in _call_impl return forward_call(*args, **kwargs) File "/opt/conda/envs/travl/lib/python3.10/site-packages/accelerate/hooks.py", line 166, in new_forward output = module._old_forward(*args, **kwargs) File "/home/workspace/Phi3V-Finetuning/model/modeling_phi3_v.py", line 1128, in forward inputs_embeds = self.vision_embed_tokens(input_ids, pixel_values=pixel_values, image_sizes=image_sizes) File "/opt/conda/envs/travl/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1511, in _wrapped_call_impl return self._call_impl(*args, **kwargs) File "/opt/conda/envs/travl/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1520, in _call_impl return forward_call(*args, **kwargs) File "/opt/conda/envs/travl/lib/python3.10/site-packages/accelerate/hooks.py", line 166, in new_forward output = module._old_forward(*args, **kwargs) File "/home/workspace/Phi3V-Finetuning/model/image_embedding_phi3_v.py", line 280, in forward hidden_states[positions[idx, 0], positions[idx, 1] : positions[idx, 1] + cnt] = ( RuntimeError: a view of a leaf Variable that requires grad is being used in an in-place operation.
It gives the same error when running with the suggenestions you gave me.
—
Reply to this email directly, view it on GitHub https://github.com/GaiZhenbiao/Phi3V-Finetuning/pull/5#issuecomment-2148855748, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMFM4AJH53755SLCG2HE3SDZF2LERAVCNFSM6AAAAABIXSUG5OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBYHA2TKNZUHA.
You are receiving this because your review was requested.

First, may you paste the train.sh you run and the package versions of your pytorch, transformers, accelerator and deepspeed?
Second, what if comment following code
https://github.com/GaiZhenbiao/Phi3V-Finetuning/blob/ad9c3fe4cfd83fecf51f39484a1f29ce0f2cdd95/train_phi3v.py#L275

2024年6月5日 13:43，Tree Diagram @.***> 写道：
I’m investigating whether this is caused by vram capacity reasons. Maybe deepspeed’s behavior varies with that.

2024年6月5日 12:57，Yu-won Lee @.***> 写道：
Hi, @2U1 https://github.com/2U1 @ayylemao https://github.com/ayylemao @shlyahin https://github.com/shlyahin Can you give me the results of following code (after uncommenting)?
https://github.com/GaiZhenbiao/Phi3V-Finetuning/blob/ad9c3fe4cfd83fecf51f39484a1f29ce0f2cdd95/train_phi3v.py#L288-L290
And can you try to add model.requires_grad_(False) right after the model is loaded by from_pretrained? Does the error still occur in this case?
Hi, @2U1 https://github.com/2U1 @ayylemao https://github.com/ayylemao @shlyahin https://github.com/shlyahin Can you give me the results of following code (after uncommenting)?
https://github.com/GaiZhenbiao/Phi3V-Finetuning/blob/ad9c3fe4cfd83fecf51f39484a1f29ce0f2cdd95/train_phi3v.py#L288-L290
And can you try to add model.requires_grad_(False) right after the model is loaded by from_pretrained? Does the error still occur in this case?
Traceback (most recent call last): File "/home/workspace/Phi3V-Finetuning/train_phi3v.py", line 360, in  train() File "/home/workspace/Phi3V-Finetuning/train_phi3v.py", line 351, in train trainer.train() File "/opt/conda/envs/travl/lib/python3.10/site-packages/trl/trainer/sft_trainer.py", line 361, in train output = super().train(*args, **kwargs) File "/opt/conda/envs/travl/lib/python3.10/site-packages/transformers/trainer.py", line 1885, in train return inner_training_loop( File "/opt/conda/envs/travl/lib/python3.10/site-packages/transformers/trainer.py", line 2216, in _inner_training_loop tr_loss_step = self.training_step(model, inputs) File "/opt/conda/envs/travl/lib/python3.10/site-packages/transformers/trainer.py", line 3238, in training_step loss = self.compute_loss(model, inputs) File "/opt/conda/envs/travl/lib/python3.10/site-packages/transformers/trainer.py", line 3264, in compute_loss outputs = model(**inputs) File "/opt/conda/envs/travl/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1511, in _wrapped_call_impl return self._call_impl(*args, **kwargs) File "/opt/conda/envs/travl/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1520, in _call_impl return forward_call(*args, **kwargs) File "/opt/conda/envs/travl/lib/python3.10/site-packages/deepspeed/utils/nvtx.py", line 15, in wrapped_fn ret_val = func(*args, **kwargs) File "/opt/conda/envs/travl/lib/python3.10/site-packages/deepspeed/runtime/engine.py", line 1852, in forward loss = self.module(*inputs, **kwargs) File "/opt/conda/envs/travl/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1511, in _wrapped_call_impl return self._call_impl(*args, **kwargs) File "/opt/conda/envs/travl/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1520, in _call_impl return forward_call(*args, **kwargs) File "/opt/conda/envs/travl/lib/python3.10/site-packages/peft/peft_model.py", line 1129, in forward return self.base_model( File "/opt/conda/envs/travl/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1511, in _wrapped_call_impl return self._call_impl(*args, **kwargs) File "/opt/conda/envs/travl/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1520, in _call_impl return forward_call(*args, **kwargs) File "/opt/conda/envs/travl/lib/python3.10/site-packages/peft/tuners/tuners_utils.py", line 161, in forward return self.model.forward(*args, **kwargs) File "/opt/conda/envs/travl/lib/python3.10/site-packages/accelerate/hooks.py", line 166, in new_forward output = module._old_forward(*args, **kwargs) File "/home/workspace/Phi3V-Finetuning/model/modeling_phi3_v.py", line 1301, in forward outputs = self.model( File "/opt/conda/envs/travl/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1511, in _wrapped_call_impl return self._call_impl(*args, **kwargs) File "/opt/conda/envs/travl/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1520, in _call_impl return forward_call(*args, **kwargs) File "/opt/conda/envs/travl/lib/python3.10/site-packages/accelerate/hooks.py", line 166, in new_forward output = module._old_forward(*args, **kwargs) File "/home/workspace/Phi3V-Finetuning/model/modeling_phi3_v.py", line 1128, in forward inputs_embeds = self.vision_embed_tokens(input_ids, pixel_values=pixel_values, image_sizes=image_sizes) File "/opt/conda/envs/travl/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1511, in _wrapped_call_impl return self._call_impl(*args, **kwargs) File "/opt/conda/envs/travl/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1520, in _call_impl return forward_call(*args, **kwargs) File "/opt/conda/envs/travl/lib/python3.10/site-packages/accelerate/hooks.py", line 166, in new_forward output = module._old_forward(*args, **kwargs) File "/home/workspace/Phi3V-Finetuning/model/image_embedding_phi3_v.py", line 280, in forward hidden_states[positions[idx, 0], positions[idx, 1] : positions[idx, 1] + cnt] = ( RuntimeError: a view of a leaf Variable that requires grad is being used in an in-place operation.
It gives the same error when running with the suggenestions you gave me.
—
Reply to this email directly, view it on GitHub https://github.com/GaiZhenbiao/Phi3V-Finetuning/pull/5#issuecomment-2148855748, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMFM4AJH53755SLCG2HE3SDZF2LERAVCNFSM6AAAAABIXSUG5OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBYHA2TKNZUHA.
You are receiving this because your review was requested.

 Second, what if comment following code https://github.com/GaiZhenbiao/Phi3V-Finetuning/blob/ad9c3fe4cfd83fecf51f39484a1f29ce0f2cdd95/train_phi3v.py#L275
…
2024年6月5日 13:43，Tree Diagram @.> 写道： I’m investigating whether this is caused by vram capacity reasons. Maybe deepspeed’s behavior varies with that. > 2024年6月5日 12:57，Yu-won Lee @.> 写道： > > > Hi, @2U1 https://github.com/2U1 @ayylemao https://github.com/ayylemao @shlyahin https://github.com/shlyahin Can you give me the results of following code (after uncommenting)? > > https://github.com/GaiZhenbiao/Phi3V-Finetuning/blob/ad9c3fe4cfd83fecf51f39484a1f29ce0f2cdd95/train_phi3v.py#L288-L290 > > And can you try to add model.requires_grad_(False) right after the model is loaded by from_pretrained? Does the error still occur in this case? > > Hi, @2U1 https://github.com/2U1 @ayylemao https://github.com/ayylemao @shlyahin https://github.com/shlyahin Can you give me the results of following code (after uncommenting)? > > https://github.com/GaiZhenbiao/Phi3V-Finetuning/blob/ad9c3fe4cfd83fecf51f39484a1f29ce0f2cdd95/train_phi3v.py#L288-L290 > > And can you try to add model.requires_grad_(False) right after the model is loaded by from_pretrained? Does the error still occur in this case? > > Traceback (most recent call last): File "/home/workspace/Phi3V-Finetuning/train_phi3v.py", line 360, in  train() File "/home/workspace/Phi3V-Finetuning/train_phi3v.py", line 351, in train trainer.train() File "/opt/conda/envs/travl/lib/python3.10/site-packages/trl/trainer/sft_trainer.py", line 361, in train output = super().train(*args, **kwargs) File "/opt/conda/envs/travl/lib/python3.10/site-packages/transformers/trainer.py", line 1885, in train return inner_training_loop( File "/opt/conda/envs/travl/lib/python3.10/site-packages/transformers/trainer.py", line 2216, in _inner_training_loop tr_loss_step = self.training_step(model, inputs) File "/opt/conda/envs/travl/lib/python3.10/site-packages/transformers/trainer.py", line 3238, in training_step loss = self.compute_loss(model, inputs) File "/opt/conda/envs/travl/lib/python3.10/site-packages/transformers/trainer.py", line 3264, in compute_loss outputs = model(**inputs) File "/opt/conda/envs/travl/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1511, in _wrapped_call_impl return self._call_impl(*args, **kwargs) File "/opt/conda/envs/travl/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1520, in _call_impl return forward_call(*args, **kwargs) File "/opt/conda/envs/travl/lib/python3.10/site-packages/deepspeed/utils/nvtx.py", line 15, in wrapped_fn ret_val = func(*args, **kwargs) File "/opt/conda/envs/travl/lib/python3.10/site-packages/deepspeed/runtime/engine.py", line 1852, in forward loss = self.module(*inputs, **kwargs) File "/opt/conda/envs/travl/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1511, in _wrapped_call_impl return self._call_impl(*args, **kwargs) File "/opt/conda/envs/travl/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1520, in _call_impl return forward_call(*args, **kwargs) File "/opt/conda/envs/travl/lib/python3.10/site-packages/peft/peft_model.py", line 1129, in forward return self.base_model( File "/opt/conda/envs/travl/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1511, in _wrapped_call_impl return self._call_impl(*args, **kwargs) File "/opt/conda/envs/travl/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1520, in _call_impl return forward_call(*args, **kwargs) File "/opt/conda/envs/travl/lib/python3.10/site-packages/peft/tuners/tuners_utils.py", line 161, in forward return self.model.forward(*args, **kwargs) File "/opt/conda/envs/travl/lib/python3.10/site-packages/accelerate/hooks.py", line 166, in new_forward output = module._old_forward(*args, **kwargs) File "/home/workspace/Phi3V-Finetuning/model/modeling_phi3_v.py", line 1301, in forward outputs = self.model( File "/opt/conda/envs/travl/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1511, in _wrapped_call_impl return self._call_impl(*args, **kwargs) File "/opt/conda/envs/travl/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1520, in _call_impl return forward_call(*args, **kwargs) File "/opt/conda/envs/travl/lib/python3.10/site-packages/accelerate/hooks.py", line 166, in new_forward output = module._old_forward(*args, **kwargs) File "/home/workspace/Phi3V-Finetuning/model/modeling_phi3_v.py", line 1128, in forward inputs_embeds = self.vision_embed_tokens(input_ids, pixel_values=pixel_values, image_sizes=image_sizes) File "/opt/conda/envs/travl/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1511, in _wrapped_call_impl return self._call_impl(*args, **kwargs) File "/opt/conda/envs/travl/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1520, in _call_impl return forward_call(*args, **kwargs) File "/opt/conda/envs/travl/lib/python3.10/site-packages/accelerate/hooks.py", line 166, in new_forward output = module._old_forward(*args, **kwargs) File "/home/workspace/Phi3V-Finetuning/model/image_embedding_phi3_v.py", line 280, in forward hidden_states[positions[idx, 0], positions[idx, 1] : positions[idx, 1] + cnt] = ( RuntimeError: a view of a leaf Variable that requires grad is being used in an in-place operation. > > It gives the same error when running with the suggenestions you gave me. > > — > Reply to this email directly, view it on GitHub <#5 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMFM4AJH53755SLCG2HE3SDZF2LERAVCNFSM6AAAAABIXSUG5OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBYHA2TKNZUHA. > You are receiving this because your review was requested. >

Actually commenting the requires_grad in the highlited line, solved the problem. But I still don't get it why it happens.

It turns out that I use zero3 so far, so everything works well. But when I change back to zero2, this error occurs. To avoid this error, we disable gradient_checkpointing for zero2 by default. And we recommend you to use zero3 (with gradient_checkpointing) in your experiments.


Build folder capital letter

One thing that just came to mind that stumps me every now and again, is moving the Build folder to Anvil will fail until you set the Build name to lowercase. After that it works - but a bit of a hidden "gotcha".

@elliottkember: looking at the code it seems like if the 'Build' folder was capitalized it would work, but if it was lowercase or spelled any other way it would fail. Anvil will now lowercase the build folder when checking for it. See PR (https://github.com/beachio/anvilformac/pull/15)


Unittest

Codecov Report

Merging #2 into develop will increase coverage by 1.65%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop       #2      +/-   ##
===========================================
+ Coverage    20.38%   22.04%   +1.65%
===========================================
  Files          165      165
  Lines        10371    10371
===========================================
+ Hits          2114     2286     +172
+ Misses        8257     8085     -172

Impacted Files
Coverage Δ

...yTorch/components/networks/feature/shapedmlpnet.py
68.9% <0%> (-6.73%)
:arrow_down:

autoPyTorch/components/networks/feature/mlpnet.py
98% <0%> (-2%)
:arrow_down:

autoPyTorch/components/optimizer/optimizer.py
72.22% <0%> (-1.86%)
:arrow_down:

...toPyTorch/components/lr_scheduler/lr_schedulers.py
36.66% <0%> (-0.48%)
:arrow_down:

...toPyTorch/components/networks/feature/embedding.py
35.61% <0%> (+5.47%)
:arrow_up:

autoPyTorch/pipeline/nodes/create_dataset_info.py
81.57% <0%> (+21.05%)
:arrow_up:

.../preprocessing/feature_preprocessing/kernel_pca.py
26% <0%> (+26%)
:arrow_up:

autoPyTorch/pipeline/nodes/create_dataloader.py
71.11% <0%> (+28.88%)
:arrow_up:

...utoPyTorch/pipeline/nodes/preprocessor_selector.py
66.66% <0%> (+31.37%)
:arrow_up:

...ts/preprocessing/feature_preprocessing/nystroem.py
32.43% <0%> (+32.43%)
:arrow_up:

... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98ce3c3...406d41c. Read the comment docs.


scala_2_11: 2.11.8 -> 2.11.9

Motivation for this change
Things done

[x] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] Linux

[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

lol, I was literally about to do the same thing :D Beat me by two minutes xD

scala 2.11.9 removed from download section of scala-lang.org due to bug https://github.com/scala/scala/pull/5821


Feature request: Set readOnly values programmatically

Replicate
Consider:
$("#sheet").jexcel({
      colHeaders: [ 'Day', 'Began', 'Ended', 'Shift', 'Total', 'Description' ],
      columns: [
        { type: 'calendar', options: { format: 'DD' }, readOnly: true },
        { type: 'text' },
        { type: 'text' },
        { type: 'numeric', readOnly: true },
        { type: 'numeric', readOnly: true },
        { type: 'text' }
      ]
    });

This prevents the user from setting the value, which is desired. However, it appears to prevent setting the value programmatically:
$('#sheet').jexcel( 'setValue', 'D2', 10 );

Expected Results
Calling setValue programmatically should always set the result, even if the cell is read-only. (Read-only fields are mean to prevent humans from changing the value, but a program can change the value, which is useful for showing the result of calculations.)
Actual Results
Calling setValue programmatically does not set the result.
Additional Information
I think this is because of the following line:
https://github.com/paulhodel/jexcel/blob/master/dist/js/jquery.jexcel.js#L1847
 $(this).jexcel('updateCells', records);

The call is passing force as false by default, which means the following line prevents the field from being set:
 } else if ($(v.cell).hasClass('readonly') == true && force == false) {

Work Around
It may be possible to work around the issue by calling removeClass, setting the value, then calling addClass to reinstate the readonly class, but this has its own disadvantages.
Addendum
As a side note:
https://bossanova.uk/jexcel/docs/programmatically-changes
The example for setValue does not show passing in a new value.

To perform this action, update your repository from the master.
// This will force the change:
$('#my').jexcel('setValue', 'D2', 10, true);

There's a good chance I'm doing something wrong, but I'm unable to get this to work when adding the readonly class to specific cells using updateTable.
updateTable: function(el, cell, x, y, source, value, id) {
if (x == 4 && y <= 10) {
cell.classList.add('readonly');
}
}
The line below only sets the value successfully when my updateTable readonly code is disabled
$('#spreadsheet').jexcel('setValue', 'E1', 100, true)
I tried removing the updateTable code and setting the column property to readonly:true instead as a test, but got the same results.


I can not connect to ssh server

Version of Warden
in-dev
Operating System and Installation Method
Linux ubuntu 22
Describe the Bug
I can not connect php storm to the database.
The issue is that It can not connect to tunnel server and I receive "Authentication error"
I have check the tunnel server :
ssh<EMAIL_ADDRESS>and it returns :
<EMAIL_ADDRESS>Permission denied (publickey,keyboard-interactive).
I have access to the database from my browser it means the I am sure that the database has been imported correctly.
Would you please give me a way to regenerate the tunnel keys of warden?
To Reproduce
I can not reproduce
Expected Behavior
No response
Additional context
No response

Hello @iranimij , you must first connect to port 2222 and use the credentials (id_rsa) of warden .warden/tunnel
Please check the page https://docs.warden.dev/configuration/database.html


Updated batcher tests; added channel transfer with batcher test

Batcher tests updated with using TestSuite.
New test for channel transfer with batcher added.
TestSuite extended with execute tasks methods.

@AtapinDmitry need your review.

Approved


Mismatch information regarding Automated Patching

Hi,
There is a mismatch information within the documentation regarding the Automated Patching for Azure SQL VM.
From https://docs.microsoft.com/en-us/azure/virtual-machines/windows/sql/virtual-machines-windows-sql-automated-patching within the IMPORTANT section at the beginning it is stated that :  "Only Windows updates marked Important are installed. Other SQL Server updates, such as Cumulative Updates, must be installed manually."
Whereas  From https://docs.microsoft.com/en-us/azure/virtual-machines/windows/sql/virtual-machines-windows-sql-server-iaas-faq#updating-and-patching at the question "How are updates and service packs applied on a SQL Server VM?" it is written : "Automated Patching installs any updates that are marked important, including SQL Server updates in that category."
Could you please update the documentation so that it matches ?
Thank you in advance.
Regards,
Adriano

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d86e3c45-59a4-c483-5b14-380981d25c50
Version Independent ID: a9c023c3-6478-dbc2-0717-45b2f90008aa
Content: SQL Server on Windows Virtual Machines in Azure FAQ - Azure SQL Server VM
Content Source: articles/virtual-machines/windows/sql/virtual-machines-windows-sql-server-iaas-faq.md
Service: virtual-machines-sql
GitHub Login: @MashaMSFT
Microsoft Alias: mathoma

@Zingonead
Thanks for your feedback! We will investigate and update as appropriate.

Thanks @Zingonead
We have updated the documentation to clear any confusion.
I have created a PR with the update, changes will be live in few hours. Thank you for bringing it to our attention.
The correct information is shared below:

Only Windows and SQL Server updates marked as Important are installed. Other SQL Server updates, such as Cumulative Updates, must be installed manually.


v2 keep element-cursor offset consistent when drop-adding elements to canvas

Is: No matter how an element was add-dropped on the the canvas, the upper left corner is always below the mouse cursor
Should The upper left corner of the element that is added should have the same distance from the cursor as the upper left corner of the element that was dropped on canvas.

Solves with this commit


Broken Settings Icon

Describe the bug
The settings icon is broken.
To Reproduce
Steps to reproduce the behavior:

Start answerdev/answer:latest in docker.
Log in as admin
Look at the settings icon in the top right corner of the screen.

Expected behavior
A proper image should be displayed.
Screenshots

Platform (please complete the following information):

Device: Desktop
OS: Windows 11
Chrome
Version 114.0.5735.110 (Official Build) (64-bit)

Sounds good! Thanks.


Search for Nasdaq-100 index quote

I am AlphaVantage free version with an API key. ISIN search does not return any satisfactory result.
https://www.alphavantage.co/query?function=SYMBOL_SEARCH&keywords=US6311011026&apikey={key}
https://www.alphavantage.co/query?function=SYMBOL_SEARCH&keywords=nasdaq100&apikey={key}
Appreciate if anyone can point me in the right direction.
(Similar challenges with other indicies, is there a repository to look up?)

Indicies are currently not supported with the Alpha Vantage API. You can get a list of the index's constituents and pull them to generate the index yourself if interested.
Your use of the search endpoint is correct.

This is interesting Patrick,
Your statement is written all over the chat groups, etc.....
I draw myself from time to time 3 distinct index quotes from the website. It works and matches Bloomberg quotes. These indicies are equivalent or less popular to the Nasdaq-100 index.
(is there a repository to look up what is possible?)
Does the paid service offer more response, help to understand the possibilities?


Add back arg I took out that was actually necessary

This adds back the variable to specify which database to query. It upsets codeclimate but is a necessary variable.

@ddbruce take a look at my additions and please review.

Added envs to prod server.


Update manual.txt with Nginx specific instructions

We discovered this issue the hard way :)

Could you clarify? I'm curious about the need to encode_keep_buffer = false.
Looking at the code, it is safe to leave it as is, as long as you don't access a Lua VM concurrently from multiple threads.

The problem is cjson's encode_buf. Specifically, it's because it is being shared between Lua VM instances on workers. nginx IS single threaded, but evented, and workers share the same lua_State object. This is all fine, so long as worker never yields. From the nginx lua docs:

You can also share changeable data among all the concurrent requests of each nginx worker process as long as there is no nonblocking I/O operations (including ngx.sleep) in the middle of your calculations. As long as you do not give the control back to the nginx event loop and ngx_lua's light thread scheduler (even implicitly), there can never be any race conditions in between. For this reason, always be very careful when you want to share changeable data on the worker level. Buggy optimizations can easily lead to hard-to-debug race conditions under load.

http://wiki.nginx.org/HttpLuaModule#Data_Sharing_within_an_Nginx_Worker
This is exactly what we we saw when testing this in out staging and ran Apache Benchmark while generating a high load. The beginning of the section:

To globally share data among all the requests handled by the same nginx worker process, encapsulate the shared data into a Lua module, use the Lua require builtin to import the module, and then manipulate the shared data in Lua. This works because required Lua modules are loaded only once and all coroutines will share the same copy of the module (both its code and data).

Because cjson is being required in by our lua module, the module state is being shared across the worker. This means if the running coroutine yields for any reason, another coroutine will resume execution and potentially change the state of the module while it's in use. If the coroutine completes execution without yielding, everything is fine. But we do yield. Any blocking socket operation, sleep, or timeout will cause the calling coroutine to yield.
I copied this explanation from our internal ticket, many thanks to csfrancis for providing this explanation.
So that's also why I did not change the code but added it as a note to the manual.txt as I can imagine that other people might run into the same issue.

Thanks for the detailed explanation. So if I understood correctly, you have multiple coroutines running within a Lua VM.
I still don't understand how yielding can become a problem, since the buffer is used fully in json_encode. There can't be any concurrent access. You can't have two calls to encode at the same time.
Could it be that disabling buffer reuse just made the actual problem harder to reproduce?

Yeah I am back tracking on that explanation as well and going to dig more. We are using lua-cjson in combination with the lua-nginx-module and wrapping the json_encode call in a pcall.

False alarm, the bug was very subtle (buffer overrun of 1 byte) in our own code.

Good! I'm glad you found the actual bug, and thanks for updating this PR.


Adding speed and charge alerts.

Nice, currently working on getting the charging state and cleaning up the BLE stuff, data binding etc is a mess.

cleaning up the BLE stuff
Make sure to see the branch bluetooth-mock.


Data record should be of key, value, source format

Currently a record is Dict[str, Any] so we get the payload of either the key or value. What we really need is to have the both:
{
	key: {
		field1: xx,
		field2: zz
	},
	value:{
		field3: aa,
		field4: bb
	}
}

So it should be something like:
Dict[Literal["key", "value"], Dict[str, Any]]

In addition, when defining a step in the job, a new flag should be introduced specifying if the data transformation should be processed the key or the value (default if omitted).

@zalmane I think this is irrelevant anymore, please confirm.


Show unread chats first on Ctrl+K

Today when someone talk to you and you do ctrl+k you have to write the chat name, would be easily just do ctrl+k and down arrow or tab
PS: tab also doesn't move to next chat

Thanks @augustnmonteiro for the feedback!
Would you like to upvote a related feature request so it can be discussed, upvoted and considered for a help wanted ticket?
If you're interested in implementing, please say so and we'll prioritize the review.
You get 10 votes in the feature idea forum, and each one influences the future of the project.

Thanks again @augustnmonteiro!
I'll close this one for now and track the feature request in our uservoice forum.
PS: You can also switch to the next/previous unread channel on your left sidebar by using the shortcuts ALT+SHIFT+UP/DOWN


add math module

closes #78.
cc @dustmop, @adonovan, & @essobedo

@b5 I take it over

@googlebot I consent.

@adonovan I believe that I have made all the requested changes except Let's call this abs, and overload it for int and float.. I tried something regarding this remark, but I don't like it, could you please tell me what you had in mind exactly?

@adonovan Fixed, please check again

@adonovan all fixed, please check again

It sounds that there is an issue with the build, the status is never reported

@adonovan done, please check it again

@adonovan Done, I also added some new functions

Hi! Sorry to barge in a little late.
I see the type floatOrInt float64 was introduced to Unpack arguments of all builtins.
Are we not loosing precision here? We seem to be discarding anything that doesn't fit in float64 (so big.Ints).
But I don't see this mentioned. Did I miss it?
Am I correct in assuming that Unpacking a litteral bigint into float64 returns an error?
abs(9007199254740992+1) # = abs(1+2^53) does this fail?

I see the type floatOrInt float64 was introduced to Unpack arguments of all builtins.
Are we not loosing precision here? We seem to be discarding anything that doesn't fit in float64 (so big.Ints).

An int of any magnitude is converted to a float. This will fail if the magnitude is bigger than about 1e308. However, the result is always a floating-point number, even if the argument was an integer.
This is consistent with Python3, but it does argue in favor of renaming math.abs to math.fabs, both for consistency with Python, and to indicate that the result is a float. I'm not aware of how to compute abs of a big int in Python.

I manually kicked off the travis build, and it finally worked.
But now it seems we are missing the google cla check from one of the authors.
@essobedo and @b5 - please see googlebot's comment above-791891376 - you would need to make a comment with the literal words @googlebot I consent. to agree to the cla.

Never mind, googlebot is now happy :)

Thanks for taking care of the merge<EMAIL_ADDRESS>


Does not work with pnpm

It seems like the patching doesn't work properly when using pnpm as the package manager.
Should be fairly easy to re-produce - take one of the samples you have (we're using mantine).
Steps to reproduce:

Remove node_modules folder
Install pnpm globally
Run pnpm install

I also reproduced the problem in this repo: https://github.com/eshaham/remix-esbuild-override-pnpm

I'm also having issues with pnpm, I tried the mantine example with the Buffer polyfill but I still get ReferenceError: Buffer is not defined when I run miniflare

@eshaham
In the repository you shared, the problem was resolved by either deleting the esbuild in package.json or matching the version with @remix-run/dev's (v0.14.22).
"devDependencies": {
    "@cloudflare/workers-types": "^3.10.0",
    "@esbuild-plugins/node-globals-polyfill": "^0.1.1",
    "@remix-run/dev": "^1.6.0",
    "@remix-run/eslint-config": "^1.6.0",
    "@types/react": "^17.0.45",
    "@types/react-dom": "^17.0.17",
    "esbuild": "0.14.22", // or remove
    "eslint": "^8.15.0",
    "npm-run-all": "^4.1.5",
    "remix-esbuild-override": "^3.0.4",
    "typescript": "^4.6.4",
    "wrangler": "beta"
  },

@tedbyron If you share your repository with me, I may be able to help you solve your problem.

@aiji42 I have remix-esbuild-override "building" ok with pnpm but our issue still persists.
Using this as a guide does not work for us.
https://mortenbarklund.com/blog/styled-components-remix/


'Resources still in use at exit' error

When launching and quitting the game from the Windows command line, we get a "Resources still in use at exit" error.
This occurs in both v0.7000 and v0.8101.
Leaked instance: GDScript:1267 - Resource path: res://src/main/utils/string-utils.gd
Leaked instance: GDScript:1841 - Resource path: res://src/main/puzzle/critter/shark.gd
Leaked instance: GDScriptNativeClass:653
Leaked instance: GDScript:1790 - Resource path: res://src/main/utils/state-machine.gd
Leaked instance: GDScript:1782 - Resource path: res://src/main/utils/state.gd
Leaked instance: GDScriptNativeClass:765
Leaked instance: GDScriptNativeClass:1022
Leaked instance: GDScript:1260 - Resource path: res://src/main/utils/utils.gd
Leaked instance: GDScript:1384 - Resource path: res://src/main/puzzle/critter/shark-config.gd
Leaked instance: GDScriptNativeClass:609
Leaked instance: GDScript:1829 - Resource path: res://src/main/puzzle/critter/poof-sprite.gd
Hint: Leaked instances typically happen when nodes are removed from the scene tree (with `remove_child()`) but not freed (with `free()` or `queue_free()`).
Resource still in use: res://src/main/puzzle/critter/poof-sprite.gd (GDScript)
Resource still in use: res://src/main/utils/string-utils.gd (GDScript)
Resource still in use: res://src/main/puzzle/critter/shark.gd (GDScript)
Resource still in use: res://src/main/utils/state.gd (GDScript)
Resource still in use: res://src/main/puzzle/critter/shark-config.gd (GDScript)
Resource still in use: res://src/main/utils/utils.gd (GDScript)
Resource still in use: res://src/main/utils/state-machine.gd (GDScript)

I've launched 1.0005-steam build with the --verbose flag, but cannot duplicate this issue. It appears to have been resolved.
Given that it appears specific to sharks -- I wouldn't be surprised if it was resolved by #2837 which initializes sharks differently, sidestepping Godot #34752