Azure Key Vault creation fails when enable soft delete is set to false

Describe the bug
Azure Key Vault creation using az keyvault gives an error when soft delete is disabled and does not create the key vault.
To Reproduce
Running the following command
az keyvault create --resource-group myrg --name mykv \
  --location westeurope --sku standard --enable-soft-delete false

returns
The property "enableSoftDelete" must be set to true.

Expected Behavior
Should create the key vault with soft delete disabled.
Environment summary
OS Name:                   Microsoft Windows 10 Pro
OS Version:                10.0.17763 N/A Build 17763
az --version
azure-cli                          2.5.0

command-modules-nspkg              2.0.3
core                               2.5.0
nspkg                              3.0.4
telemetry                          1.0.4

Same error also in Cloud Shell environment.
$ lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description:    Ubuntu 16.04.6 LTS
Release:        16.04
Codename:       xenial

$ az --version
azure-cli                          2.4.0 *

command-modules-nspkg              2.0.3
core                               2.4.0 *
nspkg                              3.0.4
telemetry                          1.0.4

Extensions:
application-insights               0.1.6
resource-graph                     1.0.0
azure-devops                      0.18.0

Additional Context
The reason seems to be the property softDeleteRetentionInDays in the JSON payload the az keyvault command sends to the REST API.
{
    "location": "westeurope",
    "properties": {
        "tenantId": "<removed>",
        "sku": {
            "family": "A",
            "name": "standard"
        },
        "accessPolicies": [],
        "enableSoftDelete": false,
        "softDeleteRetentionInDays": 90

      // rest of the properties removed
    }
}

Everything seems to work correctly if the key vault creation is invoked directly using the az rest command and without the property softDeleteRetentionInDays in the JSON payload.
{
    "location": "westeurope",
    "properties": {
        "tenantId": "<removed>",
        "sku": {
            "family": "A",
            "name": "standard"
        },
        "accessPolicies": [],
        "enableSoftDelete": false,
        "enableRbacAuthorization": false
    }
}

az rest \
    --method PUT \
    --uri "https://management.azure.com/subscriptions/<removed>/resourceGroups/my-resource-group/providers/Microsoft.KeyVault/vaults/my-keyvault?api-version=2019-09-01"
    --header Content-Type=application/json \
    --body <the json playload above>

hi @bim-msft could you pls have a look

we are also facing this same issue.
Is azure CLI updated in the background?

have the same problem
$ az --version
azure-cli                          2.3.1 *
command-modules-nspkg              2.0.3
core                               2.3.1 *
nspkg                              3.0.4
telemetry                          1.0.4
Extensions:
azure-firewall                     0.3.0
aks-preview                       0.4.42
azure-devops                      0.12.0

Same here.
KeyVault creation without this option is also not possible.

+1 same issue: running an ARM deployment with the following template fails with the same error, if the value provided to the enableKeyVaultSoftDelete parameter is set to false:
{
    "$schema": "https://schema.management.azure.com/schemas/2015-01-01/deploymentTemplate.json#",
    "contentVersion": "<IP_ADDRESS>",
    "parameters": {
        "keyVaultName": {
            "type": "String"
        },
        "enableKeyVaultSoftDelete": {
            "defaultValue": true,
            "type": "Bool"
        }
    },
    "variables": {
        "keyVaultApiVersion": "2019-09-01"
    },
    "resources": [
        {
            "type": "Microsoft.KeyVault/vaults",
            "apiVersion": "[variables('keyVaultApiVersion')]",
            "name": "[parameters('keyVaultName')]",
            "location": "[resourceGroup().location]",
            "properties": {
                "tenantId": "[subscription().tenantId]",
                "sku": {
                    "family": "A",
                    "name": "standard"
                },
                "enabledForDeployment": false,
                "enabledForDiskEncryption": false,
                "enabledForTemplateDeployment": false,
                "enableSoftDelete": "[parameters('enableKeyVaultSoftDelete')]",
                "createMode": "default",
                "enablePurgeProtection": true,
                "accessPolicies": []
            }
        }
    ]
}

Worth noting that the latest available Microsoft.KeyVaults/vauls API version (2019-09-01) specifies:

enableSoftDelete: Property to specify whether the 'soft delete' functionality is enabled for this key vault. If it's not set to any value(true or false) when creating new key vault, it will be set to true by default. Once set to true, it cannot be reverted to false.

Whereas if you check the same property definition for an older API version (such as 2018-02-14) you can see:

enableSoftDelete: Property to specify whether the 'soft delete' functionality is enabled for this key vault. It does not accept false value.

In both API version definitions, you can also see that:

enablePurgeProtection: Property specifying whether protection against purge is enabled for this vault. Setting this property to true activates protection against purge for this vault and its content - only the Key Vault service may initiate a hard, irrecoverable deletion. The setting is effective only if soft delete is also enabled. Enabling this functionality is irreversible - that is, the property does not accept false as its value.

Out of curiosity, from the above ARM template I tried to remove the "enablePurgeProtection": true, line and the deployment succeeded: the KV got created with soft delete disabled.
Deployment doesn't work if I set enablePurgeProtection to false:
message '{
  "error": {
    "code": "BadRequest",
    "message": "The property \"enablePurgeProtection\" cannot be set to false. Enabling the purge protection for a
vault is an irreversible action."
  }
}'

It still looks like there's some clear inconsistency between what the API definitions say and what the actual behavior of the deployment is.

i am getting the same error but without setting the flag (so the default true should be used):
# the rg is set as a config default (so rg and location are defaulted)
> az keyvault create -n test-key-vault
The property "enableSoftDelete" must be set to true.

it fails to create. this was working as of yesterday afternoon but from last night to today is failing.

to follow up. the keyvault never gets created but i am getting a "The name 'test-key-vault' is already in use."
nothing appears under az keyvault list nor az keyvault list-deleted. it also does not exist on the azure console so this is not a CLI-only issue. idk if this is related but something odd is happening with az keyvault.

I also got this error when trying to use the set-policy command for a MSI on the keyvault.
az keyvault set-policy -n mirms-usw-user-kv --object-id <GUID> --subscription <Sub GUID> --key-permissions encrypt decrypt wrapKey unwrapKey sign verify get list create update import delete backup restore recover purge  --output json The property "enableSoftDelete" must be set to true.

to follow up. the keyvault never gets created but i am getting a "The name 'test-key-vault' is already in use."
nothing appears under az keyvault list nor az keyvault list-deleted. it also does not exist on the azure console so this is not a CLI-only issue. idk if this is related but something odd is happening with az keyvault.

The KeyVault name must be global unique, therefore you can assume that the name is already used by other users.

I am getting the same error 'The property "enableSoftDelete" must be set to true.' with Azure CLI 2.5.1
If i remove --enable-soft-delete from the command I still get the error even tho it is suppose to default to true.
If i specifically set it to true I can continue with my deployment. "--enable-soft-delete true"

I am getting the same error 'The property "enableSoftDelete" must be set to true.' with Azure CLI 2.5.1
If i remove --enable-soft-delete from the command I still get the error even tho it is suppose to default to true.
If i specifically set it to true I can continue with my deployment. "--enable-soft-delete true"

Same for me

I am getting the same error 'The property "enableSoftDelete" must be set to true.' with Azure CLI 2.5.1
If i remove --enable-soft-delete from the command I still get the error even tho it is suppose to default to true.
If i specifically set it to true I can continue with my deployment. "--enable-soft-delete true"

If you run the az keyvaylt create command with --debug, you can see that the JSON payload that the command send to the REST API does not contain the property enableSoftDelete and it does contain the property softDeleteRetentionInDays.
It actually might be that the REST API does not respect the contract anymore. According to the the REST API documentation, enableSoftDelete should be defaulted to true in the API itself. And I would think that softDeleteRetentionInDays wouldn't matter at all if the enableSoftDelete is set to false.

Same issue here.
Had to change some of my Terraform (local-exec provisioners) that uses this CLI to --enable-soft-delete true because all my pipelines were starting to fail :( because the false value did not allow the CLI to execute with error "The property "enableSoftDelete" must be set to true."
This is an issue for me because I create and destroy lots of keyvaults (sometimes with the same name hence soft delete is not required) now I have to incorporate a purge in addition to my code base to accommodate this value being set to true

to follow up. the keyvault never gets created but i am getting a "The name 'test-key-vault' is already in use."
nothing appears under az keyvault list nor az keyvault list-deleted. it also does not exist on the azure console so this is not a CLI-only issue. idk if this is related but something odd is happening with az keyvault.

The KeyVault name must be global unique, therefore you can assume that the name is already used by other users.

ah thank you. i thought it was just unique within a subscription but that makes sense now that i look at it given that it is used as a subdomain.

I'm seeing the same failures when running the azure-cli docker image (which az --version resolves as 2.5.1).
I'm not seeing the errors on older versions of the CLI (specifically 2.0.80 was tested). The vault gets created correctly, and the enableSoftDelete flag is set appropriately based on the command line parameter.

I've gone back through all the versions of the az cli release. The az keyvault create command works correctly under the azure-cli:2.2.0 image, but fails under azure-cli:2.3.0 and later.

6 days and this bug which essentially stops people from creating keyvaults with the cli is not fixed...

@gregorybleiker You can create a key vault if you include --enable-soft-delete true. That gives the same result as omitting that parameter used to do.

This looks suspiciously similar to #13100. Is there something systemic that happened in the latest release?

@gregorybleiker You can create a key vault if you include --enable-soft-delete true. That gives the same result as omitting that parameter used to do.

but it is not working for --enable-soft-delete false so it is not a solution / workaround.

@einko exactly... soft delete is a very intrusive feature (and certainly not wished for in my scenario), that's why I want to create a keyvault without soft delete (which I can't via cli atm).

Some regions are broken:

@kooditoni This is due to a service side error, all CLI versions/platforms are affected, they are fixing this. No big change on CLI side around soft-delete parameter recently.

@bim-msft How to workaround this issue? I am working with westeurope mainly. Change region for current my deployment is not an option for me.

@bim-msft How to workaround this issue? I am working with westeurope mainly. Change region for current my deployment is not an option for me.

It should work now. I just tested in this region.

It works for westeurope, but it doesn't for eastus for example.

@bim-msft How to workaround this issue? I am working with westeurope mainly. Change region for current my deployment is not an option for me.

It should work now. I just tested in this region.

It works for westeurope, but it doesn't for eastus for example.

Thanks @jlichwa. I've just verified westeurope and it works.

#please-close

I still get this error for northeurope.


[CHALLENGE SUBMISSION] - challenge 24

Please provide the following information for your submission:
What is your name? (First, Last)
Pawel Haracz
Where is your GitHub Repo ?(With your challenge solution)
https://github.com/PawelHaracz/25daysofserverless/tree/master/Day24
What Challenge is this for? (Challenge number between 1 and 25)
24
(Optional) Anything else we should know? e.g., language used, location, blog post?
Azure KeyVault, Facebook Authentication

The unthinkable has happened: after weeks of community members all over the globe chipping in to help solve people's problems with serverless technology, the evil grinch's heart is starting to soften! He's still not quite ready to give up his server-stealing plot, but our whole Azure Cloud Advocacy team is flying up to the grinch's lair to help convince him to change his ways.
As such, the team behind 25 Days of Serverless is OOF (Out Of Facility/Office) between Dec 24, 2019 and January 1, 2020. We'll not review Issues in this period of time, but encourage you to catch up on any challenges you haven't had the time to work on yet. 😄 Our Discord Server is a perfect place to reach out to for community support during this time. After our return, we'll add contributors who submitted a working solution as an Issue to CONTRIBUTORS.md file until January 15, 2020.

@iennae  Thanks for your input, I've just added ReadMe there described there I used to improve security on Azure function and how to do it.
I hope, it will be enough

@PawelHaracz This is fantastic! Thanks for the update. Congratulations for completing this challenge.


reppoints_moment_x101_dcn_fpn_2x_mt，load pretrained model error

I loaded the pretraining model of reppoints_moment_x101_dcn_fpn_2x_mt.py to train my dataset. Why can't I train DCN without type= 'DCN' in config, and can't I load DCN part of the pretrained model with type= 'DCN'

Hi @237014845 ,
Thanks for your bug report, this is because a recent PR that refactors the DCN module, but I forget to change the configs consistently in the RepPoints configs.
To quick fix the bug, you need to change the dcn config  as this line.
We will also create a PR to fix it ASAP.

@ZwwWayne thank you for your reply!

@ZwwWayne 我按照您被你所说的做了，但是仍然出现错误，如下：unexpected key in source state_dict: backbone.layer2.0.conv2_offset.weight, backbone.layer2.0.conv2_offset.bias, backbone.layer2.1.conv2_offset.weight, backbone.layer2.1.conv2_offset.bias, backbone.layer2.2.conv2_offset.weight, backbone.layer2.2.conv2_offset.bias, backbone.layer2.3.conv2_offset.weight, backbone.layer2.3.conv2_offset.bias, backbone.layer3.0.conv2_offset.weight, backbone.layer3.0.conv2_offset.bias, backbone.layer3.1.conv2_offset.weight, backbone.layer3.1.conv2_offset.bias, backbone.layer3.2.conv2_offset.weight, backbone.layer3.2.conv2_offset.bias, backbone.layer3.3.conv2_offset.weight, backbone.layer3.3.conv2_offset.bias, backbone.layer3.4.conv2_offset.weight, backbone.layer3.4.conv2_offset.bias, backbone.layer3.5.conv2_offset.weight, backbone.layer3.5.conv2_offset.bias, backbone.layer3.6.conv2_offset.weight, backbone.layer3.6.conv2_offset.bias, backbone.layer3.7.conv2_offset.weight, backbone.layer3.7.conv2_offset.bias, backbone.layer3.8.conv2_offset.weight, backbone.layer3.8.conv2_offset.bias, backbone.layer3.9.conv2_offset.weight, backbone.layer3.9.conv2_offset.bias, backbone.layer3.10.conv2_offset.weight, backbone.layer3.10.conv2_offset.bias, backbone.layer3.11.conv2_offset.weight, backbone.layer3.11.conv2_offset.bias, backbone.layer3.12.conv2_offset.weight, backbone.layer3.12.conv2_offset.bias, backbone.layer3.13.conv2_offset.weight, backbone.layer3.13.conv2_offset.bias, backbone.layer3.14.conv2_offset.weight, backbone.layer3.14.conv2_offset.bias, backbone.layer3.15.conv2_offset.weight, backbone.layer3.15.conv2_offset.bias, backbone.layer3.16.conv2_offset.weight, backbone.layer3.16.conv2_offset.bias, backbone.layer3.17.conv2_offset.weight, backbone.layer3.17.conv2_offset.bias, backbone.layer3.18.conv2_offset.weight, backbone.layer3.18.conv2_offset.bias, backbone.layer3.19.conv2_offset.weight, backbone.layer3.19.conv2_offset.bias, backbone.layer3.20.conv2_offset.weight, backbone.layer3.20.conv2_offset.bias, backbone.layer3.21.conv2_offset.weight, backbone.layer3.21.conv2_offset.bias, backbone.layer3.22.conv2_offset.weight, backbone.layer3.22.conv2_offset.bias, backbone.layer4.0.conv2_offset.weight, backbone.layer4.0.conv2_offset.bias, backbone.layer4.1.conv2_offset.weight, backbone.layer4.1.conv2_offset.bias, backbone.layer4.2.conv2_offset.weight, backbone.layer4.2.conv2_offset.bias

@ZwwWayne I did what you were told, but still got errors, as follows: unexpected key in source state_dict: backbone.layer2.0.conv2_offset.weight, backbone.layer2.0.conv2_offset.bias, backbone.layer2.1. conv2_offset.weight, backbone.layer2.1.conv2_offset.bias, backbone.layer2.2.conv2_offset.weight, backbone.layer2.2.conv2_offset.bias, backbone.layer2.3.conv2_offset.weight, backbone.layer2.3. conv2_offset.bias, backbone.layer3.0.conv2_offset.weight, backbone.layer3.0.conv2_offset.bias, backbone.layer3.1.conv2_offset.weight, backbone.layer3.1.conv2_offset.bias, backbone.layer3.2. conv2_offset.weight, backbone.layer3.2.conv2_offset.bias, backbone.layer3.3.conv2_offset.weight, backbone.layer3.3.conv2_offset.bias, backbone.layer3.4.conv2_offset.weight, backbone.layer3.4. conv2_offset.bias, backbone.layer3.5.conv2_offset.weight, backbone.layer3.5.conv2_offset.bias, backbone.layer3.6.conv2_offset.weight, backbone.layer3.6.conv2_offset.bias, backbone.layer3.7. conv2_offset.weight, backbone.layer 3. 7.conv2_offset.bias, backbone.layer3.8.conv2_offset.weight, backbone.layer3.8.conv2_offset.bias, backbone.layer3.9.conv2_offset.weight, backbone.layer3.9.conv2_offset.bias, backbone.layer 3. 10.conv2_offset.weight, backbone.layer3.10.conv2_offset.bias, backbone.layer3.11.conv2_offset.weight, backbone.layer3.11.conv2_offset.bias, backbone.layer3.12.conv2_offset.weight, backbone.layer3. 12.conv2_offset.bias, backbone.layer3.13.conv2_offset.weight, backbone.layer3.13.conv2_offset.bias, backbone.layer3.14.conv2_offset.weight, backbone.layer3.14.conv2_offset.bias, backbone.layer3. 15.conv2_offset.weight, backbone.layer3.15.conv2_offset.bias, backbone.layer3.16.conv2_offset.weight, backbone.layer3.16.conv2_offset.bias, backbone.layer3.17.conv2_offset.weight, backbone.layer3. 17.conv2_offset.bias, backbone.layer3.18.conv2_offset.weight, backbone.layer3.18.conv2_offset.bias, backbone.layer3.19.conv2_offset.weight, backbone.layer3.19.conv2_offset.bias, backbone.layer3. 20.conv2_offset.weight, backbon e.layer3.20.conv2_offset.bias, backbone.layer3.21.conv2_offset.weight, backbone.layer3.21.conv2_offset.bias, backbone.layer3.22.conv2_offset.weight, backbone.layer3.22.conv2_offset.bias, backbone.layer4.0.conv2_offset.weight, backbone.layer4.0.conv2_offset.bias, backbone.layer4.1.conv2_offset.weight, backbone.layer4.1.conv2_offset.bias, backbone.layer4.2.conv2_offset.weight, backbone.layer4.2.conv2_offset.bias

@ZwwWayne @237014845 I get a similar error while trying to load pretrained weights for htc_dconv_c3-c5_mstrain_x101_64x4d_fpn_20e.py I'm assuming its due to the recent changes with the implementation of DCN. Did you have any luck fixing it?
This is what i get:
The model and loaded state dict do not match exactly
unexpected key in source state_dict: backbone.layer2.0.conv2_offset.weight, backbone.layer2.0.conv2_offset.bias, backbone.layer2.1.conv2_of
fset.weight, backbone.layer2.1.conv2_offset.bias, backbone.layer2.2.conv2_offset.weight, backbone.layer2.2.conv2_offset.bias, backbone.laye
r2.3.conv2_offset.weight, backbone.layer2.3.conv2_offset.bias, backbone.layer3.0.conv2_offset.weight, backbone.layer3.0.conv2_offset.bias,
backbone.layer3.1.conv2_offset.weight, backbone.layer3.1.conv2_offset.bias, backbone.layer3.2.conv2_offset.weight, backbone.layer3.2.conv2_
offset.bias, backbone.layer3.3.conv2_offset.weight, backbone.layer3.3.conv2_offset.bias, backbone.layer3.4.conv2_offset.weight, backbone.la
yer3.4.conv2_offset.bias, backbone.layer3.5.conv2_offset.weight, backbone.layer3.5.conv2_offset.bias, backbone.layer3.6.conv2_offset.weight
, backbone.layer3.6.conv2_offset.bias, backbone.layer3.7.conv2_offset.weight, backbone.layer3.7.conv2_offset.bias, backbone.layer3.8.conv2_
offset.weight, backbone.layer3.8.conv2_offset.bias, backbone.layer3.9.conv2_offset.weight, backbone.layer3.9.conv2_offset.bias, backbone.la
yer3.10.conv2_offset.weight, backbone.layer3.10.conv2_offset.bias, backbone.layer3.11.conv2_offset.weight, backbone.layer3.11.conv2_offset.
bias, backbone.layer3.12.conv2_offset.weight, backbone.layer3.12.conv2_offset.bias, backbone.layer3.13.conv2_offset.weight, backbone.layer3
.13.conv2_offset.bias, backbone.layer3.14.conv2_offset.weight, backbone.layer3.14.conv2_offset.bias, backbone.layer3.15.conv2_offset.weight
, backbone.layer3.15.conv2_offset.bias, backbone.layer3.16.conv2_offset.weight, backbone.layer3.16.conv2_offset.bias, backbone.layer3.17.co
nv2_offset.weight, backbone.layer3.17.conv2_offset.bias, backbone.layer3.18.conv2_offset.weight, backbone.layer3.18.conv2_offset.bias, back
bone.layer3.19.conv2_offset.weight, backbone.layer3.19.conv2_offset.bias, backbone.layer3.20.conv2_offset.weight, backbone.layer3.20.conv2_
offset.bias, backbone.layer3.21.conv2_offset.weight, backbone.layer3.21.conv2_offset.bias, backbone.layer3.22.conv2_offset.weight, backbone
.layer3.22.conv2_offset.bias, backbone.layer4.0.conv2_offset.weight, backbone.layer4.0.conv2_offset.bias, backbone.layer4.1.conv2_offset.we
ight, backbone.layer4.1.conv2_offset.bias, backbone.layer4.2.conv2_offset.weight, backbone.layer4.2.conv2_offset.bias

Hi @237014845 & @shraddhaamohan ,
The unexpected key shows up because their names are changed in the new DCN module and they are loaded in another name. Therefore, as long as the necessary key is not missing, i.e., there is no warning about missing keys, the checkpoint is loaded successfully and the results should be the same.
We will release all the new models after the BC-breaking refactoring, in about two weeks. After then those warning will be fixed.

@ZwwWayne thanks for that clarification, just ran inference and can comfirm it works just the same. Thanks a lot!

Hi @shraddhaamohan ,
Thanks for your report. Feel free to reopen this issue if the performance of the pre-trained models does not match.


Change SemanticdbInfo.plugin_jar from string to File

Description
Changed SemanticdbInfo.plugin_jar from path string to File
Motivation
This keeps the File object available for users of SemanticdbInfo.
Addresses #1527
(Note, this does change the public interface a bit, but should be fine since SemanicDBInfo is very new.)

build failure has been fixed.


Follow the template guidelines

Is your feature request related to a problem? Please describe.
The list is not on the template recommended by the awesome
Describe the solution you'd like
Use the template mentioned by awesome
Additional context
Use the guidelines at https://github.com/sindresorhus/awesome/blob/main/create-list.md

Fixed at https://github.com/michelpereira/awesome-gamesofcoding/commit/0649c1dafccd14d9c5f5bb0acc09efcb2193c238


Future Enhancements / WIP / Roadmap?

As I mentioned in my previous issue, I'm really enjoying this crate.
I'd like to more about what upcoming enhancements or new features are on the way, and maybe contribute where I can. What is currently in development for the near future? Would it be possible to get these listed as issues on this board for others to contribute and discuss?

I close it since there are issues have been created with this info


Fix image infowindows

(opened for discussion)
This PR fixes #1970. The way I have been able to reproduce the problem was:

Open a visualization where you have some image field.
Open the infowindow pane and disable all fields.
Reorder some fields and make sure that the field with the image url is at the top.
Select all fields using the "All" switch.

The Infowindow will say that the image url is invalid, even if you have a valid url and the field with the image is at the top. The reason is that we're getting the columns from the table and adding them as fields in the wrong order. More specifically, we're just iterating through the names of the columns, without considering the position they are currently in.
I've introduced this method that gets the column names from the view, which is the only place where the order is right. But it doesn't feel right to ask the view for that.
@xavijam @javisantana @viddo @javierarce Any ideas on how to do it better?

Frontend tests were OK :+1: (details)

the thing here: in the infowindow we save the order of the fields, we don't we use that?

If I remember, there is an attribute called order or index, isn't there?

From my understanding, in cdb.admin.mod.InfowindowFieldsPane, the model is a cdb.geo.ui.InfowindowModel, which is a "collection" that contains the fields we're displaying in the pane with right position. When we use the "All" switch, we first clear the fields (loosing the order) and then re-add all of them in no particular order. That's the problem.
I guess, instead of relying on the subviews to get the names of the fields in the right order, we could save the state of the model before clearing the fields, so that we can remember it after we select all. I'm not sure I explained myself clearly... what do you guys think? thx!

I'm adding a test first to replicate the bug.

I prefer this last idea than use view items order.

I'd do the thing using the model, the way we try to work is:

all the things you need to change are done through the model
the views only respond to model changes

Also I think that logic of keeping the order should be in the model, right?

Makes total sense @javisantana and @xavijam. Thanks for your feedback.
The order is being kept in the model, the thing is that we are "clearing" that model when we select/unselect all. But I can keep a copy of that in that situation :+1:

for the record:
the infowindow model has a problem, the fields are managed internally as an array instead of using a Backbone.Collection. That makes the logic to control the views is harder because we can't control each view item, we need to deal with fields list as a whole. That makes that a single change in a field redraw the whole list.
For reference take a look to all the field related methods we added to infowindow (https://github.com/CartoDB/cartodb.js/blob/develop/src/geo/ui/infowindow.js#L38). Those could be replaced with a Backbone.Collection method easily. Nobody had the time or was brave enough to do that :D

@javisantana I saw those. There's also another problem with the "sort" function. We basically sort the fields based on its position, but in some cases (when user drags&drop) positions can be duplicated.
I can give a try to using Backbone.Collection after I'm done with solving the actual issue.

Go pablo go! :)

Frontend tests were OK :+1: (details)

I've been able to replicate the bug with this test. I'm now trying to use a Backbone.Collection to internally store the position of each field, even when the model is cleared.

:) :dancer:

@xavijam @javisantana please take a look at this commit. I'm now using an internal Backbone.Collection to keep track of how the fields are ordered in the view. When the panel is rendered, we store how things are ordered, and we update the order whenever there's a drag and drop. If this is not "The Backbone Way", I'm happy to change it again... thx

Frontend tests were OK :+1: (details)

InfoWindows (and the panels to manage them) are now using cdb.geo.ui.InfowindowModel that holds the fields that are currently enabled. These fields contains the name, position and index. Another solution would be to:

Modify cdb.geo.ui.InfowindowModel to be a Backbone.Collection, as suggested by @javisantana.
Instead of adding and removing fields from cdb.geo.ui.InfowindowModel when fields are enabled/disabled in the panel, make that model contain all fields and have an extra attribute per field to store wether it's enabled or disabled.

@javisantana @xavijam what do you guys think about this? thx

It's likely that another field could give us more headaches. I'd try with the first one, with a pair of *****.

We're going to leave the refactor for later (although I'm kind of eager to do it). So let's focus on the current fix for #1970. What do you guys think? thx!

Tested in staging and works good :)

@javisantana unless you have something to say, I'm going to merge this.

:es:

Frontend tests were OK :+1: (details)


Consider adding basic example projects

This repo is really helpful.  Nice & clean & to the point.
Have you considered expanding beyond command lists into some basic project setups?  I'd love to see a project with 1-2 front ends talking to a back end with a few services & a database, sharing secrets, etc.  Maybe a job that daily backs up the database file to a volume, keeping a week worth of backups.  The actual project could be little more than "hello world" passed around, but understanding how to piece all of these components together from scratch would be great.

Thank you for your kind words @benjaminapetersen! I've not thought about this sort of end-to-end scenario but it sounds useful to me, yes. I think I've got an idea how to go about it and will include it in the upcoming 1.7 revamp.

Awesome! I've been looking for a good resource on this for a long time.


Where Expression not translated with optional navigation property

The issue
Where Expression is lost in SQL when using optional Navigation Property...
Steps to reproduce
public class TestDbContext : IDataDbContext
{
    public DbSet<Master> Masters { get; set; }
    public DbSet<Child> Childs { get; set; }
}

public class Master
{
    public int Id { get; set; }
    public string Name { get; set; }
}

public class Child
{
    public int Id { get; set; }
    public string Name { get; set; }

    public int? MasterId { get; set; }   // nullable
    public Master Master { get; set; }
}

var dc = new TestDbContext();

var childs = dc.Childs
    .Where(c => c.Master.Name == "xxx")
    .ToList();

SELECT [c].[Id], [c].[MasterId], [c].[Name], [c.Master].[Id], [c.Master].[Name]
FROM [Childs] AS [c]
LEFT JOIN [Masters] AS [c.Master] ON [c].[MasterId] = [c.Master].[Id]
ORDER BY [c].[MasterId]

(Only LEFT JOIN and Where missing)
After changing the Property [MasterId] to not-nullable it works:
public class Child
{
    public int Id { get; set; }
    public string Name { get; set; }

    public int MasterId { get; set; } // not nullable
    public Master Master { get; set; }
}

SELECT [c].[Id], [c].[MasterId], [c].[Name]
FROM [Childs] AS [c]
INNER JOIN [Masters] AS [c.Master] ON [c].[MasterId] = [c.Master].[Id]
WHERE [c.Master].[Name] = N'xxx'

Further technical details
EF Core version:1.0.0-rc2-final
Operating system: Windows 10 x64
Visual Studio version: VS 2015
SQL Version: 2014

duplicate of https://github.com/aspnet/EntityFramework/issues/4588


Feature: Identify endpoint based on line number

Goal: Given a line number and file as input, identify the associated endpoint.

@prabhu I really like the idea of achieving the end goal for this issue by offering filtering.
Rather than adding so many options to the convert command itself, I would prefer to introduce a filter command that can then take in other commands - like atom-tools filter [args] convert [args]. This has the advantage of making the filter command line arguments reusable and avoiding cluttering up any commands in which filtering may be desired.

@prabhu I tend to think command-line arguments are probably the way to go as I can see how a config file would not be particularly helpful for fwdsec's use case. I could always do both, though, and just prioritize the command line arguments if they are present.


Look like authManager->update() not working

What steps will reproduce the problem?
i'm want to change type of  role to permission
Exp. from permission to role case
$auth = Yii::$app->authManager;
$roleName = $auth->getRole($model->name);
$permission = $auth->createPermission($model->name);
$permission->description = $model->description;
$auth->update($roleName,$permission);

don't error but data not change.

Q
A

Yii version
2.0.11

Yii MongoDB version
^2.1

MongoDB server version
3.4.1

PHP version
7.0.15

Operating system
macOs 10.12.3

Unable to reproduce.
Update is covered by unit test, which passes successfully:
https://github.com/yiisoft/yii2-mongodb/blob/master/tests/rbac/MongoDbManagerTest.php#L115


RSS Feed per OS

Taking a first stab at getting an RSS feed generated while building the structured data feed. Let me know what you all think and if it's the right direction here. This created two separate feeds based on OS type. Wondering if maybe one is better with all data imported from the json files, then create an icon at the top right for RSS.
Feedback is welcome!
Description
This RSS feed will consist of all Security Releases from each version of the OS. build-sofa-feed.py will take the feed_structure data and sort it out by creating a new list that just consists of SecurityReleases and sorts them by ReleaseDate but ignoring entries inside that have a string Preinstalled as the ReleaseData. In this case, macOS 12.
It then uses feedgen module to create the XML that will be used as the RSS feed within the write_data_to_rss function. RSS feed entries usually get sorted by publish dates, so in this case - we use the ReleaseDate as the publish date.
Changes
build-sofa-feed.py
sort_by_release_date

Regenerating a new list with just SecurityReleases
Sorting by ReleaseDate while ignoring Preinstalled string
Returning list of all OS SecurityReleases or empty if error

write_data_to_rss

Using feedgen python module
Escape if empty list given
Generate new RSS file with sorted list given
Pretty the description just like the site has
If Preinstall string, set old date. This is just accounting for old entry but might need tweaking if we see this often. Hoping not.
Create feed and export to xml file

index.html

Added link below the machine readable data one
I noticed @headmin created a function here to load last checked date. Will it be a standard to create functions for load to handle error checking?

README.md
Updated to account for RSS Feed
docker workflows

Accounting for new files generated and copied over

requirements.txt

Adding the feedgen module

Tests
We ran the following lines to create the new xml files along with json files. Copied them into the v1 directory for the webserver to pick up in testing.
python3 ./build-sofa-feed.py iOS
python3 ./build-sofa-feed.py macOS

Established a webserver to view changes.
➜  sofa git:(rss_feed) ✗ sudo python3 -m http.server 80
[sudo] password for jramos:
Serving HTTP on <IP_ADDRESS> port 80 (http://<IP_ADDRESS>:80/) ...
<IP_ADDRESS> - - [07/May/2024 00:21:55] "GET / HTTP/1.1" 304 -
<IP_ADDRESS> - - [07/May/2024 00:21:55] "GET /config.json HTTP/1.1" 304 -
<IP_ADDRESS> - - [07/May/2024 00:21:55] "GET /v1/timestamp.json HTTP/1.1" 200 -
<IP_ADDRESS> - - [07/May/2024 00:21:58] "GET /v1/macos_rss_feed.xml HTTP/1.1" 200 -
<IP_ADDRESS> - - [07/May/2024 00:22:02] "GET /v1/timestamp.json HTTP/1.1" 304 -
<IP_ADDRESS> - - [07/May/2024 00:22:03] "GET /v1/ios_rss_feed.xml HTTP/1.1" 200 -

Docker build of image/
➜  sofa git:(main) ✗ docker build -t sofa_jramos .
[+] Building 15.8s (20/20) FINISHED                                                                                docker:default
 => [internal] load build definition from dockerfile                                                                                0.0s
 => => transferring dockerfile: 1.19kB                                                                                0.0s
 => [internal] load metadata for docker.io/library/python:3.12-alpine                                                                                2.1s
 => [internal] load .dockerignore                                                                                0.0s
 => => transferring context: 2B                                                                                0.0s
 => [internal] load build context                                                                                0.0s
 => => transferring context: 56.57kB                                                                                0.0s
 => [ 1/15] FROM docker.io/library/python:3.12-alpine@sha256:ef097620baf1272e38264207003b0982285da3236a20ed829bf6bbf1e85fe3cb                                                       3.6s
 => => resolve docker.io/library/python:3.12-alpine@sha256:ef097620baf1272e38264207003b0982285da3236a20ed829bf6bbf1e85fe3cb                                                         0.0s
 => => sha256:ef097620baf1272e38264207003b0982285da3236a20ed829bf6bbf1e85fe3cb 1.65kB / 1.65kB                                                                                0.0s
 => => sha256:c583b8590a197db1f6efece2dd244b0259cb6f82c4acc654bfbe48e00e20a7b9 1.37kB / 1.37kB                                                                                0.0s
 => => sha256:f44387b482817f41bdac1892c45711adaedb3a7dd381844cdc3f360e66314d7a 6.02kB / 6.02kB                                                                                0.0s
 => => sha256:4abcf20661432fb2d719aaf90656f55c287f8ca915dc1c92ec14ff61e67fbaf8 3.41MB / 3.41MB                                                                                0.8s
 => => sha256:c3cdf40b8bda8e4ca4be0f5fa7f1d128907271efcbc72cbfc7c8b0f939ec25ea 619.60kB / 619.60kB                                                                                0.3s
 => => sha256:3a6cecfe70039fd21206783553d33ea4753700f031a2490428311619801d02f7 13.96MB / 13.96MB                                                                                2.5s
 => => sha256:60d2faee92e78fe7518f0ff1645cd7320bf6b140ff885fdec2a1ea1d878f0dca 239B / 239B                                                                                0.6s
 => => sha256:b62713ed4827911d38bb5a9ac322efa0408b4bb135863b4b15c4bc383e59918b 2.70MB / 2.70MB                                                                                1.9s
 => => extracting sha256:4abcf20661432fb2d719aaf90656f55c287f8ca915dc1c92ec14ff61e67fbaf8                                                                                0.2s
 => => extracting sha256:c3cdf40b8bda8e4ca4be0f5fa7f1d128907271efcbc72cbfc7c8b0f939ec25ea                                                                                0.4s
 => => extracting sha256:3a6cecfe70039fd21206783553d33ea4753700f031a2490428311619801d02f7                                                                                0.7s
 => => extracting sha256:60d2faee92e78fe7518f0ff1645cd7320bf6b140ff885fdec2a1ea1d878f0dca                                                                                0.0s
 => => extracting sha256:b62713ed4827911d38bb5a9ac322efa0408b4bb135863b4b15c4bc383e59918b                                                                                0.3s
 => [ 2/15] WORKDIR /app                                                                                0.1s
 => [ 3/15] COPY build-sofa-feed.py /app/                                                                                0.0s
 => [ 4/15] COPY process_uma.py /app/                                                                                0.0s
 => [ 5/15] COPY config.json /app/                                                                                0.0s
 => [ 6/15] COPY feed_structure_template_v1.yaml /app/                                                                                0.0s
 => [ 7/15] COPY forked_builds.json /app/                                                                                0.0s
 => [ 8/15] COPY sofa-time-series.py /app/                                                                                0.0s
 => [ 9/15] COPY requirements.txt /app/                                                                                0.0s
 => [10/15] RUN touch time-series.csv || true                                                                                0.3s
 => [11/15] COPY time-series.csv /app/                                                                                0.0s
 => [12/15] COPY model_identifier_*.json /app/                                                                                0.0s
 => [13/15] RUN pip install --no-cache-dir -r requirements.txt                                                                                8.6s
 => [14/15] COPY entrypoint.sh /app/                                                                                0.0s
 => [15/15] RUN chmod +x /app/entrypoint.sh                                                                                0.4s
 => exporting to image                                                                                0.3s
 => => exporting layers                                                                                0.3s
 => => writing image sha256:24ce704610bd4a391bcdfe013a3ec855f4c9ee7b25c5a1cfabe19f3177df1a5a                                                                                0.0s
 => => naming to docker.io/library/sofa_jramos

Visuals

@johnnyramos As discussed the merge #80 is now live. We keep create two separate feed files based on OS type, but do so in a single run. Hopefully this is making RSS feed creation easier.

@headmin ok, should be up to date now and tested locally for create 2 feeds in a run. Give it a whirl.

@headmin - fixed the structure of the feed in 8f2f226.
As for reducing the details, I'm torn.

I agree with you if we were able to link to the tab and details of the feed item. Example, https://sofa.macadmins.io/macOS14#guid_goes_here or similar.
For now, we are able to provide the details in which can be digested immediately within a persons RSS app or Slack.

If we want to just keep it to the basics, I would need to submit a commit to link back to the initial page (https://sofa.macadmins.io/) for every item until we can link to specific div's. I'm open to either or but just wanted to pass my opinion by you.


add university: Hanoi University of Science and Technology

@NguyenDinhHieu16 I am sorry, the domain sis.hust.edu.vn is removed from our trusted domains list because it was abused in the past. If you are the student of this school, please enroll to GitHub Student Developer Program. Then apply for JetBrains educational subscription with your GitHub account (GitHub tab at https://www.jetbrains.com/shop/eform/students).


Bump to Kubernetes 1.15 will kill all OpenShift 3.11/4.2 activities

A bump of +4! versions from Kubernetes 1.11 to 1.15 to fix one! bug (#1113) will kill all OpenShift 3.11/4.2 activities.

@disposab1e thanks for the issue. The bump was not to fix one bug (#1113) ; that bug happened to get fixed at the same time. The bump was to be able to bump knative.dev/pkg, to benefit enhancements on that, and prepare the use of conversion webhook (that are beta in 1.15).
This indeed mean that starting from 0.11, Tekton Pipeline won't work on anything lower than OpenShift 4.2 (The same way Knative does not). OpenShift 3.11 was never really supported either (to have a working webhook you needed to enable some configuration on you cluster, that are not there by default).
I understand this can be frustrating but as a project, we also have to, sometimes make hard choice, keep being up-to-date.
/kind question

OpenShift 3.11 never was properly tested so it may just be by luck that it was working previously.
As 4.2 drop we (tekton upstream) are supporting kubernetes releases minus two which maps to the not yet released openshift 4.4 and the current openshift 4.3.
Having said that our (as red hat) downstream product openshift-pipelines is not yet GA and we are still working out on our support matrices on how to best support different versions.
(and just fyi, it is not just for this only one bug that we updated knative/pkg)

(sorry for duplication between vincent and my comment, but basically we are both saying the same thing :) )

@chmouel @vdemeester Thanks for clarification!
BUT: Have a look at your own documentation at install.md
Headline: Installing Tekton Pipelines on OpenShift/MiniShift
Minishift NEVER was OpenShift 4 ;-)

@disposab1e yeah… this needs to go :sweat: This was there on the early days (when it was still knative/build-pipeline :sweat_smile:)

@vdemeester times change.. quickly :-)

Btw.. I was able to install latest tekton release in OpenShift 3.11, everything was fine... but than the workspace in the tasks (pvc) was missing... I think this is because of the different handling with sidecars... so I failed late :-(


[.dev] footer not sticking to bottom of pages

There's extra space below the footer when the content isn't tall enough...

I thought we fixed this https://github.com/freeCodeCamp/freeCodeCamp/issues/35950.

the above-mentioned pr has a fix.


feat: additional field to workflow description

Right now, the entire workflow and what has been done so far are shared between agents. The idea is to separate a part of the workflow context, which is shared with agents. Otherwise, the agents use this workflow information to plan their own steps, which sometimes leads to performing tasks that were already executed or duplicating work.
Example:
const researchTripWorkflow = workflow({
  members: [personalizedActivityPlanner, restaurantScout, landmarkScout, itineraryCompiler],
  description: `
    Research and find cool things to do in Wrocław, Poland.

    Focus:
      - activities and events that match the traveler's interests and age group.
      - highly-rated restaurants and dining experiences.
      - landmarks with historic context.
      - picturesque and entertaining locations.

    Traveler's information:
      - Origin: New York, USA
      - Destination: Wrocław, Poland
      - Age of the traveler: 30
      - Hotel location: Main Square, Wrocław
      - Flight information: Flight AA123, arriving on 2023-12-15
      - How long is the trip: 7 days
  `,
  output: `
    Comprehensive day-by-day itinerary for the trip to Wrocław, Poland.
    Ensure the itinerary integrates flights, hotel information, and all planned activities and dining experiences.
  `,
  snapshot: logger,
})

after refactor:
const researchTripWorkflow = workflow({
  members: [personalizedActivityPlanner, restaurantScout, landmarkScout, itineraryCompiler],
  description: `
    Research and find cool things to do in Wrocław, Poland.

    Focus:
      - activities and events that match the traveler's interests and age group.
      - highly-rated restaurants and dining experiences.
      - landmarks with historic context.
      - picturesque and entertaining locations.
  `,
  output: `
    Comprehensive day-by-day itinerary for the trip to Wrocław, Poland.
    Ensure the itinerary integrates flights, hotel information, and all planned activities and dining experiences.
  `,
  knowledge: `
    Traveler's information:
      - Origin: New York, USA
      - Destination: Wrocław, Poland
      - Age of the traveler: 30
      - Hotel location: Main Square, Wrocław
      - Flight information: Flight AA123, arriving on 2023-12-15
      - How long is the trip: 7 days
      `
  snapshot: logger,
})

not sure if knowledge is the best name however context could be a little bit confusing as it appears in other places

... and only knowledge is being shared with each agent

Somehow related to #95

I think that’s good name to start with!

Eventually closed with #111


Fix Fork link

https://github.com/pallets/jinja/fork -> https://github.com/pallets/flask/fork

Just for future contributions: You should always create a branch for your PRs and not use the default branches for them.
Because there's a good chance we as maintainers add or amend commits and (force-)push them to your branch. And if we then use GitHub's Squash/Rebase+Merge option your branch is out of sync with upstream afterwards. And if we change the upstream target branch of the PR it's even worse because then we'd have to forcepush e.g. a branch based on 2.0.x to your main branch...

Thanks!
P.S. Since your new branch fix-fork-link is base on 2.0.x, you can just select it when creating the PR, and target it to the pallets:2.0.x branch.

Thanks!
P.S. Since your new branch oleksis: fix-fork-link is base on 2.0.x, you can just select it when creating the PR, and target it to the pallets: 2.0.x branch.

Get the note 📝 🙏🏾


Default methods on managed model interfaces cannot be called on Java 9

Related to https://issues.apache.org/jira/browse/GROOVY-7879 we seem to do something wrong when generating the proxies for the @Managed model. The test InterfaceBackedManagedTypeIntegrationTest fails on Java 9 with
java.lang.IncompatibleClassChangeError: Method Person.getName()Ljava/lang/String; must be InterfaceMethodref constant

I believe this is a groovy bug. The groovy team seemed to have fixed something when calling static methods, which are defined on interfaces:

https://issues.apache.org/jira/browse/GROOVY-7879
https://issues.apache.org/jira/browse/GROOVY-8164

However, something has changed on Java 9. I have created a simple example that reproduces the error shown above.
Other projects seems to be having the same problem:

https://github.com/palantir/gradle-docker/issues/96
The jshell gradle plugin I am trying to contribute to

Not sure what is the best approach here. Should this be raised as an issue in the Groovy project github?

According to the state of the linked Groovy issue 7879 it should be resolved since Groovy 2.4.11.
But, using
------------------------------------------------------------
Gradle 4.6
------------------------------------------------------------

Build time:   2018-02-28 13:36:36 UTC
Revision:     8fa6ce7945b640e6168488e4417f9bb96e4ab46c

Groovy:       2.4.12
Ant:          Apache Ant(TM) version 1.9.9 compiled on February 2 2017
JVM:          10-ea ("Oracle Corporation" 10-ea+42)
OS:           Windows 10 10.0 amd64

R:\dev\github\junit-team\junit5>gradlew build

with this Java 9 code:
java.util.spi.ToolProvider.findFirst('jar').get()

...it still fails with Method java.util.spi.ToolProvider.findFirst(Ljava/lang/String;)Ljava/util/Optional; must be InterfaceMethodref constant

Happens with Gradle 4.7 (Groovy 2.4.12) as well.
Seems to be fixed with Groovy 3.0-alpha-2, though:
groovy "java.util.spi.ToolProvider.findFirst('jar').get().run(System.out, System.err, '--version')"
WARNING: Using incubator modules: jdk.incubator.httpclient

WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by org.codehaus.groovy.vmplugin.v7.Java7$1 (file:/../lib/groovy-3.0.0-alpha-2.jar) to constructor java.lang.invoke.MethodHandles$Lookup(java.lang.Class,int)
WARNING: Please consider reporting this to the maintainers of org.codehaus.groovy.vmplugin.v7.Java7$1
WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
WARNING: All illegal access operations will be denied in a future release

jar 10

Seems to be fixed in 2.4.16: https://issues.apache.org/jira/browse/GROOVY-8528

This works fine with Groovy 2.4.15


tikv_util: fix panic when there are multiple cgroup2 mountinfos

Signed-off-by: tabokie<EMAIL_ADDRESS>What is changed and how it works?
Issue Number: Close #13660
What's Changed:
fix panic when there are multiple cgroup2 mountinfos

Related changes

Need to cherry-pick to the release branch

Check List
Tests

Unit test

Release note
fix panic when there are multiple cgroup2 mountinfos

/merge


fix: re-enable color prop for the badge component

Question
Response

Version?
master

Devices tested?
iPhone 7, Android Nexus 5

Bug fix?
yes

New feature?
no

Includes tests?
no

All Tests pass?
yes

Related ticket?
#581

Screenshots

Before
After

Description
#535 seems to have lost the color prop for the badge text, making it always black (the default).
This fixed the style be reading from that prop again when it's available.

Coverage decreased (-0.08%) to 39.784% when pulling 7998ee8c69ead5ae0854675838eab353646012ed on machour:fix-notifications-color into 7fc068129f9c653c5e34db9c6b96c9a2c56e4c06 on gitpoint:master.

Coverage increased (+0.0009%) to 39.861% when pulling 3f9cab51b77191dc7215b45cee2ee4c96ecfb0d3 on machour:fix-notifications-color into 7fc068129f9c653c5e34db9c6b96c9a2c56e4c06 on gitpoint:master.


Port plotting function about information content to python

The plotting function gives a great overview about the information content present in each bit of a variable.
The port of the function to python should be straight forward and should be preferred over a further call of to Julia.

The port of the function to python should be straight forward and should be preferred over a further call of to Julia.

I agree, especially given that I've written it with PyPlot. Only very few changes should be necessary for direct matplotlib syntax

Figure 2 is now supported. The ability to reproduce Fig. S1 would be still cool of course.

I have the code for fig s1 somewhere also


[Actions Failure] GNOME on Flatpak fails

I noticed that your github workflow action for flatpak has been failing for at least the last 4 months. with the following errors.
GNOME on Flatpak (x86_64)
Build failed: Error: The process '/usr/bin/xvfb-run' failed with exit code 1
https://github.com/NickvisionApps/Cavalier/actions/runs/8491918705
@DaPigGuy

It's due to not updating the nuget dependencies.
Cavalier is on my list to be rewritten from C# to C++ so that will all be fixed once that happens.


Fix #2605 Create new client side entity for wielded item

Contains
Fixes #2605
This fixes 2605 by creating a new entity (client-side) for the wielded items.
This pull request creates a client side entity for first person view display instead of reusing the entity from the inventory. This makes reasoning easier and fixes the bug where the host held item spawns at (0, 0, 0) for the clients.
How to test
Create a listen server, join with a new client. Pick up an item as host and see how the client will not see the host wielded item at (0, 0, 0). Also dropping items and placing blocks should still work.

Can one of the admins please verify this patch?

@GooeyHub: ok to test
Sorry for the late response - things here are a little hectic because of Google Code-In. I'll review this within a few hours 🙂

Hooray Jenkins reported success with all tests good!

Sorry that this one got forgotten, tested and merged it.

For reference: reverted in #2806 due to other issues. Fix might still be viable but needs some additional work and testing before being put back in :-)
Removed from the Alpha 7 milestone and re-opened #2605


The request model: iic/speech_kantts_ttsfrd does not exist!

snapshot_download('iic/speech_kantts_ttsfrd', local_dir='pretrained_models/speech_kantts_ttsfrd')
2024-10-21 06:05:40,912 - modelscope - ERROR - The request model: iic/speech_kantts_ttsfrd does not exist!
Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

不需要这个，看最新的readme


Add Cyber Security team overview

Add information about the Cyber Security team at GDS, what they do and how you can contact them.

I am from Cyber Security. I can confirm that this change can be approved.


Zipkin flask

Motivation and Context
Currently there's no way to trace the requests through the application.
What Changed
This will add the tracing headers to any request that comes through this
application onto another service, or preserve existing headers allowing
the user to follow requests through the application as a whole.
There are also new configuration settings:
| ZIPKIN_DISABLE                  | Totally disable Zipkin (including tracing headers)            | False
| ZIPKIN_DSN                      | Zipkin Sample API URL (e.g. http://zipkin:9411/api/v1/spans)  | None
| ZIPKIN_SAMPLE_RATE              | Percentage of requests to send to zipkin span API             | 0

By default this will add the tracing headers, but make no requests to
Zipkin's neat little UI.
How to test
No visible functional changes, check to see if downstream services are
receiving the headers:

'X-B3-TraceId'
'X-B3-SpanId'
'X-B3-ParentSpanId'
'X-B3-Flags'
'X-B3-Sampled'

You can also set the environment variables
To see the spans go to zipkin:

Set the environment variable ZIPKIN_DSN to a locally running zipkin
server
Set the environment variable ZIPKIN_SAMPLE_RATE to 100

Then run the acceptance tests.
Links

Add Call time metrics into Splunk for Python Services (3d)
https://github.com/ONSdigital/ras-collection-instrument/pull/126
https://github.com/ONSdigital/ras-party/pull/151
https://github.com/ONSdigital/ras-secure-message/pull/227
https://github.com/ONSdigital/response-operations-ui/pull/219
https://github.com/ONSdigital/ras-frontstage/pull/383
https://github.com/ONSdigital/rm-collection-exercise-service/pull/114
https://github.com/ONSdigital/rm-case-service/pull/71
https://github.com/ONSdigital/rm-actionexporter-service/pull/46
https://github.com/ONSdigital/iac-service/pull/20
https://github.com/ONSdigital/rm-sample-service/pull/74
https://github.com/ONSdigital/rm-notify-gateway/pull/44
https://github.com/ONSdigital/rm-sdx-gateway/pull/20
https://github.com/ONSdigital/ras-party/pull/155
https://github.com/ONSdigital/ras-rm-docker-dev/pull/80

 Add Call time metrics into Splunk for Python Services (3d)


Document verification responsibilities of calling applications in USAGE.md

Looks good though github checks do not seem happy.

Yeah clippy and codecov haven't been happy for a bit, will fix in a later PR since this change needs to be cherry picked to the audit branch 8.0.


wallet-type: only "indy" creates DB and tables; "askar" missing

using version 0.10.4 we noticed that new Agents are force into in-memory wallets, not postgres.
Leaving out wallet-type: in our config.yml results in an in-memory wallet, not the postgres wallet that we need.
setting wallet-type: indy gives us our storage but then dumps out a deprecation note:
2023-11-20 16:42:14 ::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::
2023-11-20 16:42:14 ::                             ⚠ DEPRECATION NOTICE: ⚠                              ::
2023-11-20 16:42:14 :: -------------------------------------------------------------------------------- ::
2023-11-20 16:42:14 :: The Indy wallet type is deprecated, use Askar instead; see: https://aca-         ::
2023-11-20 16:42:14 :: py.org/main/deploying/IndySDKtoAskarMigration/                                   ::
2023-11-20 16:42:14 ::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::

At one point there was a wallet-type: askar option but that has vanished it seems. Only basic (default) and indy are supported as options from what I can see:
--wallet-type <wallet-type>
                        Specifies the type of Indy wallet provider to use. Supported internal storage types are 'basic' (memory) and 'indy'. The default (if not specified)
                        is 'basic'. [env var: ACAPY_WALLET_TYPE]

is it possible that the wallet-storage-type: basic has been confused with wallet-type: askar somehow?

--wallet-type askar will work; the help text is just out of date. I'll submit a quick update for that.

If you've attempted to use the askar wallet type and are seeing errors, feel free to post them here. A common issue I've seen is that the postgres version is older than askar requires so I'd keep an eye out for that.

@dbluhm i thought that we had tried wallet-type: askar and saw immediate failures but a clean start shows that was incorrect. I have an agent running with Askar now. Many thanks!
We had definitely seen the older postgres issues (I somehow ended up with postgres v10 on one machine???). I think the cause of our issues was re-using the wallet-name value. More here...
For those that are interested, if you create a wallet of type indy and then use the same wallet-name: but flip to wallet-type: askar things fail out immediately:
2023-11-21 06:23:33 2023-11-21 14:23:33,653 aries_cloudagent.commands.start ERROR Exception during startup:
2023-11-21 06:23:33 Traceback (most recent call last):
2023-11-21 06:23:33   File "/home/indy/.local/lib/python3.9/site-packages/aries_cloudagent/askar/store.py", line 157, in open_store
2023-11-21 06:23:33     store = await Store.open(
2023-11-21 06:23:33   File "/home/indy/.local/lib/python3.9/site-packages/aries_askar/store.py", line 326, in open
2023-11-21 06:23:33     return Store(await bindings.store_open(uri, key_method, pass_key, profile), uri)
2023-11-21 06:23:33   File "/home/indy/.local/lib/python3.9/site-packages/aries_askar/bindings/init.py", line 83, in store_open
2023-11-21 06:23:33     return await invoke_async(
2023-11-21 06:23:33   File "/home/indy/.local/lib/python3.9/site-packages/aries_askar/bindings/lib.py", line 358, in invoke_async
2023-11-21 06:23:33     return await self.loaded.invoke_async(
2023-11-21 06:23:33   File "/usr/local/lib/python3.9/asyncio/futures.py", line 284, in await
2023-11-21 06:23:33     yield self  # This tells Task to wait for completion.
2023-11-21 06:23:33   File "/usr/local/lib/python3.9/asyncio/tasks.py", line 328, in __wakeup
2023-11-21 06:23:33     future.result()
2023-11-21 06:23:33   File "/usr/local/lib/python3.9/asyncio/futures.py", line 201, in result
2023-11-21 06:23:33     raise self._exception
2023-11-21 06:23:33 aries_askar.error.AskarError: Backend error
2023-11-21 06:23:33 Caused by: error returned from database: relation "config" does not exist

To add to @darrellodonnell 's comment.  Switching from indy to askar requires a migration.  Scripts can be found here; https://github.com/hyperledger/aries-acapy-tools


Cannot assign null value into backOffFunction when using kotlin

Affects Version(s): over 2.6.x

Can't put null value to FailedRecordProcessor#setBackOffFunction
This is a similar issue with #1988
It is a nullable field because there is a logic like below
https://github.com/spring-projects/spring-kafka/blob/676a5ad667839b1b96240e1a87e8876d300479e2/spring-kafka/src/main/java/org/springframework/kafka/listener/FailedRecordTracker.java#L215-L221
Versions

kotlin: 1.5.31
spring boot: 2.5.x
spring kafka: 2.7.9

Why do you need to explicitly set it to null? It is already null by default.

@garyrussell
I implemented my error handler inheriting SeekToCurrentErrorHandler which has default BackOff.
(DEFAULT_FIXED_BACKOFF: FixedBackOff(0, 1))
And I want to have other BackOff Function for some exceptions, so I call setBackOffFunction in handle method like this.
// example of setBackOffFunction method
when (exception) {
    is SomeException-> super.setBackOffFunction { _, _ ->
        FixedBackOff(exception.intervalMillis, exception.maxAttempts)
    }
    ...
    else -> ...
}

The backOffFunction will be used for next error handling if I don't set to null. So I want to clear this backOffFunction.
It can be null in Java and I think it also should be able in kotlin.
// whole code samples

setBackOffFunction()

try {
    SeekUtils.recover(...)
} finally {
    clearBackOffFunction()
}

private fun clearBackOffFunction() {
    super.setBackOffFunction(DEFAULT_BACKOFF_FUNCTION)
}

I implemented like this and I set backOffFunction which has sample value with default (passed value on constructor)

I agree the change is correct, but I just needed to understand your use case.
That said, it is not really best practice to change the function at runtime; why not just create a function that returns that returns null when you want the default BackOff to be used. See the javadocs.
	/**
	 * Set a function to dynamically determine the {@link BackOff} to use, based on the
	 * consumer record and/or exception. If null is returned, the default BackOff will be
	 * used.
	 * @param backOffFunction the function.
	 * @since 2.6
	 */
	public void setBackOffFunction(BiFunction<ConsumerRecord<?, ?>, Exception, BackOff> backOffFunction) {

Thanks.

why not just create a function that returns that returns null when you want the default BackOff to be used.

I couldn't think about that. Thank you for your answer


Upload to an existing porjects dataset or merge completed tasks within project.

Feature Request
When managing your projects it would be nice to upload images to an existing train/test/validation dataset. If you want to use the same project and every time you add new images to the dataset there is going to be a new task entry for every one. If there was a way to either merge completed tasks in the project or the ability to add data to existing tasks within the project that would be great. Also being able to view the images within the dataset in a gallery like view would be nice as well.

Hi @BaileyHelfer
We are not going to implement adding new data to existing tasks. It would be a breaking change, our model considers new tasks if you need more data in a dataset.
You can push completed task to a project subset if you want.


[BUG]: Tailwind CSS tooltip opens up framer motion link

Description 📝
Tailwind CSS tooltip inside ComponentPreview opens up framer motion link
Link 🔗
https://syntaxui.com/docs/components/features
Steps to Reproduce 🔄
.
Screenshots 📸

Expected Behavior 🤔
should open https://tailwindcss.com/
Actual Behavior 😱
.
Environment 🌍
.
Additional Information ℹ
No response

@epoll31 let's keep this one for beginners or first contributor hence tagged it as Good First Issue

fixed in 149055c


Function to pull neso forecast #2

Pull Request
Description
This pull request adds a Python script to fetch data from the NESO API. It introduces two main functions:

API fetch function: A simple method to retrieve data directly from the NESO API.
SQL query-based fetch function: An alternative method to retrieve data using SQL queries.

In addition to the core functionality, this PR includes a test suite with the following test functions:

test_fetch_data_api(): Verifies that the fetch_data function correctly fetches and processes data from the API, including proper column renaming.
test_fetch_data_sql(): Ensures that the fetch_data_using_sql function works correctly with SQL queries, processes the data, and renames the columns as expected.
test_data_consistency(): Validates that the data fetched from both methods (fetch_data and fetch_data_using_sql) is consistent.

The code has been formatted using Black to ensure consistency and adhere to coding style guidelines.
Motivation
This script simplifies the process of fetching data from the NESO API, making it easier for users to retrieve and process data in two ways: directly via API calls or through SQL queries. The flexibility of these methods allows for use in a variety of data-fetching scenarios, facilitating analysis and further processing.
Dependencies

pytest: For testing the functionality of the fetch methods.
No additional dependencies beyond the standard Python libraries (urllib, json, and pandas) are required.

How Has This Been Tested?
The functionality of the fetch_data and fetch_data_using_sql functions has been validated through the following test cases:

test_fetch_data_api(): Ensures correct functionality of the API fetch method.
test_fetch_data_sql(): Confirms the proper operation of the SQL fetch method.
test_data_consistency(): Verifies that the data fetched by both methods is consistent in terms of structure and content.

To reproduce the tests:

Run the test functions provided in the script.
Ensure internet connectivity and valid access to the NESO API.

Checklist:

[x] My code follows OCF's coding style guidelines.
[x] I have performed a self-review of my own code.
[ ] I have updated the documentation to include details about the new script.
[x] I have added tests that validate the correctness of my code.
[x] I have checked my code and corrected any misspellings.

Alright. I'll create a separate test file with two separate tests.

@peterdudfield I have made a separate tests folder and am now using pytest to test the functions. I hope that is fine. Have converted the single test function into 3 separate functions as well.

@peterdudfield Hey, should I start working on #4? Is this issue resolved fully or need some other improvements?

@all-contributors please add @peterdudfield  for ideas


Microsoft.AzureSphere TypeSpec Conversion

ARM (Control Plane) API Specification Update Pull Request

[!TIP]
Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

[!NOTE]
As of January 2024 there is no PR assignee. This is expected. See https://aka.ms/azsdk/pr-arm-review.

PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

Click here to see the details of Step 1, Breaking Changes review
If you are in purview of Step 1 of the diagram, follow the Breaking Changes review process.
IMPORTANT! This applies even if you believe your PR was mislabeled, for any reason, including tool failure.

Click here to see the details of Step 2, ARM review
See https://aka.ms/azsdk/pr-arm-review.

 Click here to see the diagram footnotes
Diagram footnotes
[1] See ARM review queue (for PR merge queues, see [2]).
[2] public repo merge queue, private repo merge queue (for ARM review queue, [1])
The ARM reviewer on-call engineer visits the merge queue twice a day, so the approximate ETA for merges is 12 - 24 hours.

Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!

[ ] New resource provider.
[ ] New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been generated using OpenAPI Hub).
[ ] Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
[ ] Update existing version to fix OpenAPI spec quality issues in S360.
[ ] Other, please clarify:

edit this with your clarification

Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

[ ] I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
[ ] I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

 Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
For help with PR workflow diagram Step 2 (ARM review), see https://aka.ms/azsdk/pr-arm-review.
If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

@allenjzhang I think all remaining breaking changes and lint diff are all false alert. Could you review and add suppression label? @allegradomel We have helped to refining your TypeSpec definition to using the standard template. The change will not impact both service side and client side. Could you please have a review and we could merge and continue the GA SDK release tomorrow?

Yes, please go ahead and merge this, thanks!

Approved lint diff and breaking changes since they are all false alerts.


Legends inside and outside of the plot

Common feature request for Plots.jl. It should be planned for early.

Could be implemented by making the legend a subplot in itself that can be placed either next to or superimposed to existing subplots - would be great for a shared legend for multi-subplot figures.

You can place the legend wherever you want already: http://makie.juliaplots.org/stable/legends.html

It might be nice in the simple functions to make that an attribute.

(offtopic - I can't see the video on that page on my mac - firefox/safari)

The link http://makie.juliaplots.org/stable/legends.html no longer works.
I'm trying to figure out how to add a legend to explain the colours for a 2D contour (mesh) plot.

Sorry, I just added examples from home, but didn't push them :D will push them this evening!

Ah, just found one of the examples on my work PC:
using Makie
scene = Scene(resolution = (500, 500))
x = map([:dot, :dash, :dashdot], [2, 3, 4]) do ls, lw
    linesegments!(
        range(1, stop = 5, length = 100), rand(100), rand(100),
        linestyle = ls, linewidth = lw,
        color = rand(RGBAf0)
    )[end]
end
x = [x..., scatter!(range(1, stop=5, length=100), rand(100), rand(100))[end]]
center!(scene)
ls = Makie.legend(x, ["attribute $i" for i in 1:4], camera = campixel!, raw = true)
vbox(scene, ls)

Cool, thanks! That works for me : )

Just a follow up, how would I go about creating a legend inside an existing plot? What I have attempted so far is to initially place the legend and plot side-by-side using the code above, and then using Makie.translate! on the plot to move it inside the plot. I encountered two issues with this. One is that the legend moves behind the plot instead, and the second is that the bounding box does not seem to update to reflect the fact that the legend has moved. Is there a recommended way of placing the legend inside the plot? Thanks!

-> MakieLayout


Two competing showcases with @id autocomplete

Since the new black hole showcase is using the same @id autocomplete as the old Lotka-Volterra showcase, the @ref autocomplete in the showcases overview can not be resolved and the corresponding link is broken at https://docs.sciml.ai/Overview/stable/showcase/showcase/ .

Thanks! Fixed in the next build


Added slice type

Codecov Report

Merging #305 into master will decrease coverage by 0.04%.
The diff coverage is 89.65%.

@@            Coverage Diff             @@
##           master     #305      +/-   ##
==========================================
- Coverage   91.87%   91.82%   -0.05%
==========================================
  Files           9        9
  Lines        2215     2239      +24
==========================================
+ Hits         2035     2056      +21
- Misses        117      119       +2
- Partials       63       64       +1

Impacted Files
Coverage Δ

vm/vmLetExpr.go
85.08% <100%> (ø)
:arrow_up:

vm/vmExpr.go
95.86% <88.88%> (-0.47%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ab1f7f...c8e036d. Read the comment docs.

@mattn Good to go

Thank you


Off-screen columns not autosizing

I took the auto sizing code right off of this example:
function autoSizeAll() {
    var allColumnIds = [];
    columnDefs.forEach( function(columnDef) {
        allColumnIds.push(columnDef.field);
    });
    gridOptions.columnApi.autoSizeColumns(allColumnIds);
}

However, unlike the example, which has only 10 columns, my grid has 30 columns - so there is a horizontal scrollbar. What I am finding is that the code above autosizes the columns that are on the screen, but the columns that are off-screen are not autosized. Am I missing something?

same issue

The docs need updating.  I think the least we can all do is search the issues before opening new questions:
https://github.com/ceolter/ag-grid/issues/1020

@tystol, I did a search before logging the issue, but missed #1020 - my bad. Will be more careful in the future. Really appreciate your help on this. Thanks.

All good in the hood :)


What's full name of LSMT?

Would like to know the full name of LSMT, thanks.

At the very beginning of the time the OverlayBD idea comes out, it once comes with LSM-Tree, because of the processing creating OverlayBD image.
Now, the whole implementation is simplified as a read-only linear sparse index, so we just called it as a short form of Linear Segment Merge Table.


Update documentation-government-ase-disa-cap.md

fixing formatting

@kyle-hoyer : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Looks good/verified; thanks.


added function to append reporter and get output of generic reporters…

… because it's more intuitive to find than just accessing variables.
I only found out how to use reporters by looking how they were used in the test cases, so I added functions which are easier to find, but basically do the same thing (with some hopefully appropriately implemented checks)

Hm. I generally agree with you that these should be easier to find but I am generally against adding code that does nothing because it can clutter a program if you do it regularly.
Moreover, the way you have written the check hurts the flexibility of the code. You usually don't want this type of fine grained error handling in Python. For example, if somebody writes his own reporter (outside lettuce, just some class that has a call function), it would not be able to pass through your add_reporter function. Also, if somebody adds a reporter to lettuce, he would have to modify this function as well.
As an alternative, you could add documentation (the documentation is currently in bad shape anyway). For example, reporters could be added in the "Attributes" section of the documentation like this
class Simulation:
    """High-level API for simulations.

    Attributes
    ----------
    reporters : list
        A list of reporters. Their call functions are invoked after every simulation step.

    """

The same applies for the get_data() function. However, you could actually make that function useful by reading the data from the file and returning the data if out is a data file.


Add .rotate-* utilities

Added
"rotate": (
      property: transform,
      class: rotate,
      values: (
        0: rotate(0deg),
        45: rotate(45deg),
        90: rotate(90deg),
        135: rotate(135deg),
        180: rotate(180deg),
        225: rotate(225deg),
        270: rotate(270deg),
        315: rotate(315deg),
      )
)

This one also needs some docs.

Going to leave this open for feedback before we think about merging. From my own experience, rotations aren't as common as many other property-value pairs.

Okay thanks, Where can I find any example of that?

Going to leave this open for feedback before we think about merging. From my own experience, rotations aren't as common as many other property-value pairs.

Accordions usually have them, our own docs sidebar have them too. I have also used them for dropdowns lately.
Not sure for the 45deg (and other "diagonals") transforms yet here.

@MartijnCuppens I can dig that. What are we thinking for values then? 0, 90, 180, 270?

@mdo, Yeah, that might have been a better way to explain my thoughts 😄

Just a sidenote here: we should mention in the docs that it'll prevent to add other transform functions alongside rotate().
I'm very used to define several transform functions altogether, so I'm pretty sure this will get back to us as an issue if this PR gets merged.

Indeed, @ffoodd. This PR will need some documentation to go with these new utilities and we'll need to make a mention of conflicting transforms.

Punting on these for now. Thanks though!


TCP reassembly packets getting dropped in Azure Firewall

Observed that TCP reassembly packets are getting dropped by Azure Firewall.
Is this a known behavior ?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 474ba3cb-afa1-4ec5-37df-6553a5523dbb
Version Independent ID: 56096558-1943-3f6b-9609-7722200272fb
Content: What is Azure Firewall?
Content Source: articles/firewall/overview.md
Service: firewall
GitHub Login: @vhorne
Microsoft Alias: victorh

@MukundMurali-M , We are looking into this query and will update you as soon as possible.

@MukundMurali-M , Could you please elaborate your ask? What are you trying to achieve and where it is getting failed for better assistance.

@MukundMurali-M , Since we have not heard back from you we will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly reopen the issue and continue the discussion.


raise ValueError w/ helpful message when library not found

Modify the process for downloading parquet files from S3 by:

adding response.raise_for_status() to _download_file
catching exceptions in download_embeddings and raising a ValueError with a helpful error message: library `{library_name}` not found. See https://fleet.so/context for a list of all 1200+.

Without this modification, calling download_embeddings with an unsupported library results in the following exception (or fastparquet equivalent):
pyarrow.lib.ArrowInvalid: Could not open Parquet input source '<Buffer>': Parquet magic bytes not found in footer. Either the file is corrupted or this is not a parquet file.
This PR expands the docstring for download_embeddings to reflect these changes.

LGTM, thank you for contributing 🙌


Bannerlord 1.6.1 Crash on start

The mod no longer works on its own (without MCM + BUTR + Harmony)
Theres a crash on desktop due to MCMv4 not being loaded, looks like a type check done before the game starts.

I've tested this in both 1.6.0 and 1.6.1, so its a pretty recent patch
Looks like Bannerlord uses reflection to figure out the types a submodule needs, then tries to load the associated DLLs.
This means that you cant have a build which soft supports both having MCM and not having it, if its type is used, it needs to have the dll loaded or it will crash in the opening screen.
I've decided therefore to remove MCM support from the main branch of this for now.
I will look into creating a separate DLL file that supports MCM, so that this mod has the option of using MCM or not using MCM

#10 Is the PR that removes MCM (for now!)


Sectionizer refactor

Includes a lot of changes:

Unrelated to sectionizer, moved regex_matcher.py to common and updated references in context, target matcher, and testing code.
Sectionizer now uses the MedspacyMatcher to handle matching mechanisms and SectionRule has been created to hold and serialize sectionizer rules.
Sectionizer now creates sections with three core components. This should help clarify ambiguity between previous naming conventions.
--category the normalized type of the whole section, formerly section_title
--title the actual covered text and span matched with the rules, formerly section_header
--body the text in between sections, formerly section_span or section_text
Sectionizer now stores results in a Section class to avoid storing non-serializable elements like spaCy's Span. The Section object has a variety of properties that can be accessed from Token, Span and Doc levels.
parenting algorithm works the same but now stores the Section of the parent rather than just the name.
Some sectionizer tests remain commented out. These tests no longer apply to the current API and need some reworking at a later date to develop tests for the same concepts. These mostly have to do with the new method of storing and creating rules, which may involve more sophisticated testing of the MedspacyMatcher in general
Updated visualizer to reflect use of Section objects
Updated jupyter notebooks with working examples using the adjusted API for Section objects.

Awesome work! These are great additions! 🎉


Use Django's builtin version of six

Removes direct dependency on six

Merged in 6ad0d5f99a931c7629f9acb805d4db5c03a01fa3 - thanks!


Buttons on the right side of the main screens are aligned to the right and do not wrap when the screen set to smaller size

Screen-size dependent, not easy to make it look well on each device.
Should work for common screen sizes, though (e.g. 1366x768, 1920x1080).

Should be relatively fine now, though screen resolution should be at least around 1280x768. 1024x768 will have issues.
Also, I updated login/signup/changepassword screens, so the controls are of a reasonable length for smaller resolutions. But for 1920x1080 they are quite wide.
Anyway, the point is, it is quite hard to make it look well for each screen resolution (also tedious).


consistent quoting, more readable interpolation

via http://refactorcop.com/rspec/rspec-rails

Thanks.


Made the 'title' attribute optional & made 'title' the fallback for 'data-content'

Using 'title' as the fallback for 'data-content' lets one easily upgrade tooltips to popovers.
Thanks!

Hm.. don't think we want to do this - seems to be a bit confusing for the average implementation.


REVIEW mb/image2pulsetrain

Transforms an image into a pulse train.

Coverage increased (+0.7%) to 88.091% when pulling feea5529a40d924f961a869a2e71e88b469d7cbe on mbeyeler:mb/image2pulsetrain into db7802b648308a10ba1f1bcaa458d4eb531dcea2 on uwescience:master.

Coverage increased (+0.7%) to 88.071% when pulling ae7f28f81ea744359466b5c05d8701f66614898b on mbeyeler:mb/image2pulsetrain into db7802b648308a10ba1f1bcaa458d4eb531dcea2 on uwescience:master.

Coverage increased (+0.7%) to 88.071% when pulling ae7f28f81ea744359466b5c05d8701f66614898b on mbeyeler:mb/image2pulsetrain into db7802b648308a10ba1f1bcaa458d4eb531dcea2 on uwescience:master.

I think this is ready to merge. Anything more you want to do here?


[firebase_auth] Email Link sign in just shows default page

Describe the bug
I tried to set up the email sign-in feature of firebase using this package.
First of all, it used domain.com instead of our URL-Prefix we set up in dynamic links, then I read that URL prefixes aren't supported by firebase_auth yet so I deleted the URL prefixes and used a page.link domain this worked but when you open the email in chrome you get redirected to the play store instead of the app even if the app is installed

Hi @DRSchlaubi
This seems more like Stackoverflow type of question or do you think this is a bug?
can you please provide your flutter doctor -v and flutter run --verbose?
Also, to better address the issue, would be helpful if you could post a minimal code sample to reproduce the problem
Thank you

It's probbably a FR since the Android client seems to have an option to specify the dynamic links domain for the sign in link. The app doesn't actually do anything since chrome does directly redirect in the playstore so there is no output in flutter run but here's flutter doctor
C:\Users\micha>flutter doctor -v                                                                                [√] Flutter (Channel stable, v1.12.13+hotfix.9, on Microsoft Windows [Version 10.0.18363.752], locale de-DE)                • Flutter version 1.12.13+hotfix.9 at C:\Users\micha\flutter                                                            • Framework revision f139b11009 (2 weeks ago), 2020-03-30 13:57:30 -0700                                                • Engine revision af51afceb8                                                                                • Dart version 2.7.2                                                                                [!] Android toolchain - develop for Android devices (Android SDK version 29.0.3)                                            • Android SDK at C:\Users\micha\AppData\Local\Android\Sdk                                                               • Android NDK location not configured (optional; useful for native profiling support)                                   • Platform android-29, build-tools 29.0.3                                                                               • ANDROID_HOME = C:\Users\micha\AppData\Local\Android\Sdk                                                               • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java                                                  • Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b04)                                           X Android license status unknown.                                                                                Try re-installing or updating your Android SDK Manager.                                                                 See https://developer.android.com/studio/#downloads or visit https://flutter.dev/setup/#android-setup for detailed      instructions.                                                                                [√] Android Studio (version 3.6)                                                                                • Android Studio at C:\Program Files\Android\Android Studio                                                             • Flutter plugin version 45.0.1                                                                                • Dart plugin version 192.7761                                                                                • Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b04)                                                                                [√] VS Code, 64-bit edition (version 1.44.0)                                                                                • VS Code at C:\Program Files\Microsoft VS Code                                                                         • Flutter extension version 3.9.1                                                                                [!] Connected device                                                                                ! No devices available                                                                                ! Doctor found issues in 2 categories.

Hey 👋
Our rework of the firebase_auth plugin as part of the FlutterFire roadmap was published over a week ago with a ton of fixes and new features.
Please could you update to the new version which now supports specifying the dynamic links domain as part of action code settings. If you have any problems with this feature or the updated plugins please raise a new GitHub issue.
See:

https://pub.dev/documentation/firebase_auth_platform_interface/latest/firebase_auth_platform_interface/ActionCodeSettings-class.html
https://pub.dev/documentation/firebase_auth/latest/firebase_auth/FirebaseAuth/sendSignInLinkToEmail.html

For help migrating to the new plugins please see the new migration guide: https://firebase.flutter.dev/docs/migration


Merge pull request #1 from docker/master

- What I did
- How I did it
- How to verify it
- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)
update to origin

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "master" git@github.com:icaoweiwei/docker.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Ammending updates the existing PR. You DO NOT need to open a new one.

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "master" git@github.com:icaoweiwei/docker.git somewhere
$ cd somewhere
$ git rebase -i HEAD~2
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Ammending updates the existing PR. You DO NOT need to open a new one.

I'm sorry, this is a wrong operation.


Fix "window is undefined" bug on node.js

Node.Js will throw an error if you check for "window" directly. This is a workaround for that problem.

Thanks :)


Need YAML support for List  fields constraints check

Summary:
As per testplan need to check the lists fields constraints check need YAML support for list element fileds constraints check
Testplan:

This issue was created by me using a account that i had to delete due to access issues, I will continue to follow these issues with my current id.


Picking loaded script via quick open doesn't work

Testing #31327
I keep getting Could not retrieve content. when picking scripts from my app which are indeed loaded, using the quick open action. It happens with all the scripts.
Possibly duplicate of #31327 ?

Seems to happen on both protocols.

I cannot reproduce this with this VS Code:
Version 1.15.0-insider
Commit 0e7546c978fa1b62dbf36f07a77d1b9a4241d6f7
Date 2017-07-28T11:16:26.188Z


Ability to change the icon of the FAB

It would be nice we we had a little customisability when it came to the icon and the color of the FAB

Will target it this week.

Resolved in version 0.3.2.