bitbucket integration not working

Not sure where the problem lies but I've setup brigade and the brigade-bitbucket-gateway and I'm getting the following errors after I push to my repo and the worker starts up.
λ kubectl -n brigade logs brigade-worker-01cbnkkskkwgm1gshd88pcgjdh
Error from server (BadRequest): container "brigade-runner" in pod "brigade-worker-01cbnkkskkwgm1gshd88pcgjdh" is waiting to start: PodInitializing

λ kubectl -n brigade logs brigade-worker-01cbnkkskkwgm1gshd88pcgjdh vcs-sidecar
/clone.sh: line 10: BRIGADE_COMMIT_REF: parameter not set or null

The secret that is generated for this worker has an empty value for commit_ref:
apiVersion: v1
data:
  build_id: YnJpZ2FkZS13b3JrZXItMDFjYm5ra3Nra3dnbTFnc2hkODhwY2dqZGg=
  build_name: YnJpZ2FkZS13b3JrZXItMDFjYm5ra3Nra3dnbTFnc2hkODhwY2dqZGg=
  commit_id: MTFmNTQ0NDE3MWQxYjhmOGEwNGEwYjVkNWUwNzcyMmYzODJiZWUwYQ==
  commit_ref: ""
  event_provider: Yml0YnVja2V0
  event_type: cHVzaA==
  payload: [encoded data, 4420 characters]
  project_id: YnJpZ2FkZS1mNzQ3YWRmNGFiZTIzNGZlN2Q3YTM5OWRmMzNlZTJjZmZlN2Y2NmI3NjQzNDM4YmJkMzJkNzI=
  script: null
kind: Secret
metadata:
  creationTimestamp: 2018-04-22T02:41:03Z
  labels:
    build: 01cbnkkskkwgm1gshd88pcgjdh
    component: build
    heritage: brigade
    project: brigade-f747adf4abe234fe7d7a399df33ee2cffe7f66b7643438bbd32d72
  name: brigade-worker-01cbnkkskkwgm1gshd88pcgjdh
  namespace: brigade
  resourceVersion: "29755253"
  selfLink: /api/v1/namespaces/brigade/secrets/brigade-worker-01cbnkkskkwgm1gshd88pcgjdh
  uid: 993cbc18-45d6-11e8-bf32-000d3a755dcb
type: brigade.sh/build

Any ideas on what the issue is? Seems like a parsing issue with the payload sent by bitbucket.

@Strandedpirate Hi. Thanks for trying brigade. Let me give some time to understand what's going on here..
Firstly you can skip git-cloning at all by setting vcsSidecar: NONE in your project's values.yml. But probably that's not what you wanted. You do want brigade to checkout the commit for use by brigade jobs, right?
@technosophos Hi. I'm a bit confused here.
clone.sh does require a git ref for cloning. Otherwise  it should just fail like this. So, there's nothing seems wrong to me in brigade.
But can we say that it is just an issue in bitbucket gateway that it misses setting refs in several cases?
What makes me uncertain is that, the github gateway is also in a similar state - it misses setting refs in several cases.
Did we by any chance miss thoese in our migration from commit sha to refs two months ago?

@mumoshu Yes, I need brigade to checkout my repo so the sidecar is enabled.
Looking at the source for the gateway it looks like a few of the switches are not setting the Ref. In paticular this one:
https://github.com/lukepatrick/brigade-bitbucket-gateway/blob/180d5d53cce708505f53f68c7ee010446d713e18/brigade-bitbucket-gateway/cmd/brigade-bitbucket-gateway/server.go#L107
should have rev.Ref = release.Push.Changes[0].New.Name

Man, who wrote that bitbucket code... 😉
I was thinking one of two fields in the rev (commit or ref) had to be set. Perhaps not. I can test more with the bitbucket gateway, thought I had it working before.

We're fixing the few GitHub events that don't yet have refs.

Sweet! Eagerly awaiting the new bits. I'm evaluating if we can move our shiny new monorepo to brigade instead of using bitbucket pipelines.

I've released an update to the BitBucket gateway that should better support the events and revisions.
Let me know if they don't align with your expected uses.

@lukepatrick, thanks for the new bits. I think I'm almost there but the sidecar fails to clone the repo. (it's a private repo)
Looks like the RSA key is never used? I can't tell.
Do my values look correct or any suggestions on what to change?
project: "buildasign/designer"
repository: "bitbucket.org/buildasign/designer"
cloneURL: "git@bitbucket.org:buildasign/designer.git" // i tried plain old https://bitbucket.org/buildasign/designer.git as well
sharedSecret: "3a3a6d73-2ce4-4035-9f65-f76af6d2fea2"

github:
 sshKey: |-
  -----BEGIN RSA PRIVATE KEY-----
  <my rsa key here/>
  -----END RSA PRIVATE KEY-----

<the rest are defaults/>

λ kubectl -n brigade logs brigade-worker-01cc2jpdsk6fbnw35sk6mrqb99 vcs-sidecar
+ : dev
+ : 643809f45cb5fdf84b6e6bd69e7cbe2661540395
+ : /vcs
+ refspec=dev
+ git ls-remote --exit-code https://bitbucket.org/buildasign/designer.git dev
+ cut -f2
remote: Unauthorized
fatal: Authentication failed for 'https://bitbucket.org/buildasign/designer.git/'
+ full_ref=
+ git init -q /vcs
+ cd /vcs
+ git fetch -q --force --update-head-ok https://bitbucket.org/buildasign/designer.git dev
remote: Unauthorized
fatal: Authentication failed for 'https://bitbucket.org/buildasign/designer.git/'

Good eye! It's working now. Thanks!


sort constructors first again

Fixed #149
Fixes

sort constructors first

Also there were some Merged conflicts because of my previous PRs and Commits.

Please format your code. flutter format .

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

169 of 173 (97.69%)  changed or added relevant lines in 35 files are covered.
14 unchanged lines in 13 files lost coverage.
Overall coverage decreased (-0.02%) to 73.525%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

lib/ui/views/about/about_privacy_policy_view.dart
1
2
50.0%

lib/ui/views/ib/components/ib_pop_quiz.dart
0
1
0.0%

lib/ui/views/projects/edit_project_view.dart
0
1
0.0%

lib/ui/views/projects/project_preview_fullscreen_view.dart
0
1
0.0%

Files with Coverage Reduction
New Missed Lines
%

lib/models/dialog_models.dart
1
50.0%

lib/ui/components/cv_add_icon_button.dart
1
0%

lib/ui/views/ib/builders/ib_chapter_contents_builder.dart
1
33.33%

lib/ui/views/ib/builders/ib_interaction_builder.dart
1
4.55%

lib/ui/views/ib/builders/ib_pop_quiz_builder.dart
1
16.67%

lib/ui/views/ib/builders/ib_subscript_builder.dart
1
10.0%

lib/ui/views/ib/builders/ib_superscript_builder.dart
1
10.0%

lib/ui/views/ib/components/ib_pop_quiz_button.dart
1
0%

lib/ui/views/ib/components/ib_pop_quiz.dart
1
0%

lib/ui/views/projects/edit_project_view.dart
1
0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.02%

Covered Lines:
3852

Relevant Lines:
5239

💛  - Coveralls


Can more than one filter be applied to a variable?

I have been using the filter code to explore new compression filters. It's very nice! Thank you @DennisHeimbigner
It seems as though nc_def_var_filter() and associated code is written to handle just one filter on the var. Yet the filter concept, as described by the HDF5 team, is that multiple filters can be applied.
The one use case for this is the proposed quantization filter (or "bit grooming" to use Charlie's term). The bit grooming filter only makes sense when combined with a compression filter. Other use cases can be imagined, but the bit grooming one is the most important.
So can more than one filter be applied?

Concrete example is that h5repack supports sequential filter chains:
h5repack -i in.nc -o out.h5 --filter=var:UD=32017,1,3 --filter=var:UD=32015,1,5
Think of first as lossy and second as lossless. By including szip it is possible to imagine useful chains of up to three filters. An API that permits multiple filters would be helpful. The current workaround would seem to be a filter that takes the arguments for itself and a second filter, and the glue code parses that and calls both filters. That is my current plan for quantization, though it is an untested idea at this point.


Add width & height function with ASDimension parameter

What
Adding width & height specifier that accepts ASDimension as parameter
Background
Currently, TextureSwiftSupport only supports hardcoded value if we want to set our node to a certain size, which might not be the solution in some cases such as setting full width, or half of another node’s height, etc. This PR is going to add another capability to set the width & height using ASDimension parameter directly so we can utilize the ASDimension class, for example we can use ASDimensionWithFraction directly to set our width/height relative to its parent, without guessing the exact value

instead,
height(_ height: CGFloat, unit = .points)
could be better? just I thought

@JohnEstropia thanks, how about my idea?

Thanks for your contribution!


initialOpenNodes is not working as expected

Hey,
I stumbled upon issue #36 and tried to use your solution for my issue. Unfortuantely, initialOpenNodes is not working for me when using version 1.1.2. I am able to control the open nodes using the property openNodes instead of initialOpenNodes, but the user is not able to interact with the tree in this case. I want the user to be able to interact with the tree and to control the open/collapsed items from my code.
Below you can find the code for my tree menu component.
class GraphPropertyView extends React.Component {
  handleClick = (key, label, ...properties) => {};

  render() {
    const { classes } = this.props;

    const properties = this.processProperties(this.props.properties, {
      index: 0,
    });
    const openNodeKeys = this.determineOpenNodes(properties, {
      currentLevel: 0,
    });
    console.log(openNodeKeys);
    return (
      <div className={classes.graphPropertyContainer}>
        <TreeMenu
          data={properties}
          initialOpenNodes={openNodeKeys}
          onClickItem={this.handleClick}
          hasSearch={false}
        />
      </div>
    );
  }

  // emulate call by reference by using a context object
  processProperties(properties, context) {
    let treeData = [];
    for (let property of properties) {
      let addedProperty = {
        key: context.index.toString(),
        label: property.name,
        nodes: []
      };
      ++context.index;
      if (typeof property === "object" && property.children) {
        addedProperty.nodes = this.processProperties(
          property.children,
          context
        );
      }
      treeData.push(addedProperty);
    }
    return treeData;
  }

  // emulate call by reference by using a context object
  determineOpenNodes(properties, context) {
    let openNodeKeys = [];
    for (let property of properties) {
      if (this.props.currentLevel > context.currentLevel) {
        openNodeKeys.push(property.key);
      }
      if ((property.nodes) && (property.nodes.length > 0)) {
        ++context.currentLevel;
        openNodeKeys.push(...this.determineOpenNodes(property.nodes, context));
        --context.currentLevel;
      }
    }
    return openNodeKeys;
  }
}

Btw, thank you so much for your great work!

Hello,
Please refer to the storybook demo and this story. The issue you encountered is not caused by the component itself.
Your render function execute 2 recursions, and each render takes lots of resources for even rendering a small set of data. Usually you shouldn't put compute-intensive jobs inside of your render function.
I'd suggest extract your data processing part out, and only feed clean data into your React components.

I found the issue. initialOpenNodes is only executed when the component is mounted. However, I need expand and collapse certain levels from my code. Is there any way to set the open nodes while still allowing the user to interact with the tree menu?
I also moved the recursion out of the render method. Thank you for the hint!

It would be easier if you could share your code via codesandbox.

I created a demo codesandbox application. Expanding the tree programatically using the button does not work. However, when I set initiallyOpenProperties on creating the state in the constructor, the tree is expanded.

Exactly. The first render will pick up initial state from your Component, which should set in the constructor, which is then assigned to initialOpenNodes.
The handleExpandTree function is not needed, unless you want it take full control over the TreeMenu. Setting the initial value is usually handled in the constructor or componentDidMount (sometimes comoonentDidUpdate), depending on your use case.

Okay, let me explain the bigger picture. Your tree menu view is part of a bigger view. I basically have a graph which has nodes and each of these nodes has a tree hierarchy of properties. When I click a node, I want to display the tree of properties. Therefore, the tree view is updated with new data quite frequently. I also want the user to be able to expand and collapse the entire tree or certain levels programatically. In order to achieve the latter functionality I need a way to change the expanded items in the tree menu while still allowing the user to manually expand and collapse items. The button in my example should expand the entire tree when clicked. Is there any way to do accomplish this with your library? Thank you so much for your answer!

Now it's clearer to me. So you want a way to "reset" the openNodes. Currently the library doesn't have an easy way to achieve this. But it's a valid use case. Thanks! Please track this issue #78 instead.


why

legitimately curious ¯\(ツ)/¯

Why not ¯\(ツ)/¯ I would use this in a personal project.

Someone else asked "why" and got a response on Reddit here:

The emoji UUIDs are just a few of the modes I wound up adding - the initial concept was to create UUID-like identifiers that incorporated 1337 words for the novelty of it.

In that spirit, the default mode of cuteuid returns something like 3xampl3a-boy1-goa1-5ucc33dd3p7h - since it's not truly a UUID and isn't limited to the character space of A-F + 0-9, a large number of potential variations can be generated despite being comprised entirely of (1337 translated) words.

The next mode I added was an optional hex_only parameter, which produces fewer variations (therefore a higher chance of collision) but looks more similar to an actual UUID (e.g. 0ff1c1a1-50f7-f33d-43517a73b3d1)

Emojis were added due to 1) the simplicity of adding them to the existing generator, 2) their larger character space leading to even more possible combinations than conventional UUIDs, and 3) their (subjective) adherence to the "cute" directive in the name I'd chosen, "CuteUID."

Which is legitimate, so enjoy c:


ocw_import_course_sites: sync to github by default

Pre-Flight checklist

[x] Testing

[x] Code is tested
[ ] Changes have been manually tested

What are the relevant tickets?
N/A
What's this PR do?
Changes the ocw_import_course_sites command to sync content to github by default (formerly did so only if --sync_backend was passed as an option).
How should this be manually tested?
Run manage.py import_ocw_course_sites  --bucket ocw-to-hugo-output-qa --limit 2
After completing the import, you should see another task start (and finish): "Syncing all unsynced courses to the designated backend"

Codecov Report

Merging #921 (828c022) into master (9edba6a) will increase coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #921      +/-   ##
==========================================
+ Coverage   91.63%   91.64%   +0.01%
==========================================
  Files         188      188
  Lines        7015     7014       -1
  Branches     1251     1251
==========================================
  Hits         6428     6428
+ Misses        511      510       -1
  Partials       76       76

Impacted Files
Coverage Δ

...ort/management/commands/import_ocw_course_sites.py
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9edba6a...828c022. Read the comment docs.


Improve documentation

I didn't find any proper documentation of the project.

+1 on this. I'm evaluating eCommerce options and I'm tempted to choose Saleor but I just can't jump in with such limited documentation.

What kind of documentation would be the best for you? Some developer docs, like "where should I put my custom code, to achieve it", or something like out of the box feature list with short description?

I find example code the most helpful, so the first option I guess.
There are 2 use cases for product design that stand out in my mind:

A single complex product with many attributes/variations i.e. each attribute combination gives a different price/image/SKUs etc
Many simple products each with their own set of attributes i.e. a department store with thousands of different products i.e. too many to create individual class definitions for so mass importing is desirable.

Also, complex pricing is always difficult to model i.e. different prices for different user groups, taxes for different countries, multiple currencies, discounts, sales etc.
Product attributes/variants and pricing structure are the two most challenging parts of shopping cart design i have found.

In my mind, the four key elements of good documentation are:

A conceptual overview. Many users who come to Saleor will have never used an eCommerce system before. The docs should clearly explain (in plain English) all of the key things the framework does. Then it should clearly lay out what the key pieces are and what they do.
Example code / tutorials. Users who have standard use cases should by-and-large be able to get up and running just by using default code and following a tutorial.
A recipe book: clear instructions on how to make the most common customizations
API docs laying out the classes and explaining what they do and how to use them

I'm currently evaluating eCommerce frameworks and so I'm looking at Django Oscar which has very clear and extensive documentation. I'm not sure if it's actually better for my use case but the documentation makes me feel like at least I'll be able to understand what's going on while I figure it out (without having to read a mountain of source code).

Yeah, I was looking at Django Oscar but the code is a nightmare:

weird "forking" which is what they call inheritance overriding of their basic apps. Lots of non-standard Django stuff and the payoff doesn't seem to be there?
Products are defined in the Catalogue app which means you can't leave the Oscar catalogue organisation behind and come up with your own.
Prices are grouped into Strategy's (good but...) which couple stock and pricing information (bad for digital products) and are, of course, kept in the Partner app (and Products are in the Catalogue app?)?

and a bunch of other things (attributes + options which appear to be the same thing, you get a ton of apps when you install half of which you don't need). Documentation is more but dated and filled with many holes and light on examples.
Saleor seems simpler and they have broken their design down into separate projects (satchless, django-payments etc) so coupling is nice and lose and modular. Seems like design is first.

Yeah, I was looking at Django Oscar but the code is a nightmare:

weird "forking" which is what they call inheritance overriding of their basic apps. Lots of non-standard Django stuff and the payoff doesn't seem to be there?
Products are defined in the Catalogue app which means you can't leave the Oscar catalogue organisation behind and come up with your own.
Prices are grouped into Strategy's (good but...) which couple stock and pricing information (bad for digital products) and are, of course, kept in the Partner app (and Products are in the Catalogue app?)?

and a bunch of other things (attributes + options which appear to be the same thing, you get a ton of apps when you install half of which you don't need). Documentation is more but dated and filled with many holes and light on examples.
Saleor seems simpler and they have broken their design down into separate projects (satchless, django-payments etc) so coupling is nice and lose and modular. Seems like design is first.

django project itself is a standard for doc and drf

We are not talking tech standards, we're talking content

I wan intending to point to the contents of django docs actually

So I suggest to focus on following steps:

[ ] Create basic description of saleor project concepts
[ ] Create out of the box features list
[ ] Improve code documentation (create docstrings for important classes and methods)
[ ] Collect some common recipes in one place

Initial version of project documentation was deployed on readthedocs: http://saleor.readthedocs.org/en/latest/
For now, it's only content from project's wiki, but I think it's a good start for documentation.

I expected to install saleor as an app to my existing django project.
Upon reading Install instruction, I suspect it's not the case and saleor runs as a separate server.
Am I correct on this?
Is there a way to integrate saleor into an existing django project?

Saleor is a project template that is meant to be customized for your needs. You can integrate it into your project by copying the saleor app to your project directory. Just make sure your settings file has all of the relevant values defined.

I'm new to whole e-commerce concept, so bear with me please.
A bit of explanation on difference among product - product_variant - product_attribute - attribute_choice_value would be helpful.
There's also ProductVariant's attributes
product: starwars episode1
product_variant: paperbook /kindle
product_attributes: umm? shouldn't this be product_variant_attributes?
I guess the structure could change based on intention.
It would be helpful to see an intended usage example though.
I guess it could be on the random_data.py or documentation.
Attribute can have many AttributeChoiceValue and I don't understand the reasoning behind this either.

You have products, and product variants, so your product could be Star Wars Episode 1 and it will have format attribute.
Now you have two ProductVariants with different format attribute values paperbook and kindle.
Attributes in product are possible options for variants (format, color, size etc) and AttributeChoiceValue are values for particular variants (paperbook, red, XXL, etc)

Like @artursmet says, product_attributes let you decide what kinds of attributes that particular product's variants can have. If you sell shoes and books you don't want your staff to wonder how to calculate number of pages for a pair of sneakers or to enter "size 36" for a book. :wink: Hope this helps.

Thank you. helps immensely
So ProductVariant's attributes(jsonfield) indicates what options(product_attributes) are available for it.
paperbook and kindle would be AttributeChoiceValue 's `display
and AttributeChoiceValue's color and image are kind of a meta field (it doesn't mean color of a product)

color and image fields were meant to improve displaying particular attributes on product page. For example when attached image to attribute value, you can display it on variant selector on product page.
When you set color (hex value), you can display colored box on product page.

yes. Thank you. cleared all my questions except one.
Am I correct on
ProductVariant's attributes(jsonfield) indicates what options(product_attributes) it chooses to support.
@patrys ' comment
product_attributes let you decide what kinds of attributes that particular product's variants can have.
confuses me.
It's the ProductVariant.attributes which let you decide  what kinds of attributes that particular product's variants can have. right?
Actually another question is..
There's no ordering of variant and attribute, right?
i.e. If I wanted to, I could let user to select variant first and then attribute, and vice-versa?
@artursmet 's sentence you can display it on variant selector on product page. suggest the idea. (I'm trying to understand the sentence)

Closing this in favour of #157


[API Bug] arrowUp and arrowDown shortcuts do nothing

Raycast version: 1.25.3
Description
Using arrowUp or arrowDown as an only key in shortcut doesn't call linked action. Using any other key works fine. Checked only with Detail view.
Steps To Reproduce

Use shortcut={{ modifiers: [], key: "arrowUp" }} in ActionList.Item
Run your extension
Click arrowUp on your keyboard

The current behavior
Nothing happens
The expected behavior
Clicking arrowUp calls the linked action

The up and down arrows in an action panel are used to navigate in the actions list up and down so they cannot be assigned as custom shortcut.


Please provide a non-homebrew solution for linux

Hi Auth0 team
Describe the problem you'd like to have solved
Homebrew is not a common tool on Linux systems.  It is very heavy handed, doesn't work well, and interferes with many other parts of the OS in clobbering harmful ways!   Overall Homebrew's implementation for Linux is an afterthought and it shouldn't be encouraged/promoted.
Describe the ideal solution
There are other package managers available - apt, yum, flatpak, snapcraft, pip,  - and if there is no motivation to use a package manager, even a regular set of instructions to manually install the binary would be preferable. Or maybe even a curl ... | bash statement.
Alternatives and current work-arounds
Users should follow the manual  steps.

Hey @mendhak thanks for opening this issue. I do reflect your sentiment regarding Homebrew on Linux, however we currently provide instructions on how to manually install the binary on Linux as well: https://github.com/auth0/auth0-cli#manually-2. Please let us know if you had any issues with that.
Meanwhile I'll leave this issue open so we can investigate using curl to read a bash script that installs the binary automatically.

Hello.  We're trying out Auth0, and the Linux instructions for installing the cli weren't quite working out-of-the-box. Rather than dig in, we're trying the Homebrew solution, and it too is less than ideal. As pointed out above, there are native, idiomatic Linux package managers which would make the installation process less painful. This is just feedback that requiring the download of a whole other MacOS package-manager does not leave a good first impression.

Hey @rendall 👋🏻 appreciate the feedback. 🙇🏻
We acknowledged this issue on linux and aimed at improving it in our https://github.com/auth0/auth0-cli/tree/v1 branch.
The new advised way of installing the binary on linux is by curling and executing our install script.
You could already take advantage of it by running:
# Binary will be downloaded to "./auth0".
curl -sSfL https://raw.githubusercontent.com/auth0/auth0-cli/v1/install.sh | sh -s -- -b .

This however does not export it on the PATH env var. I'm a bit hesitant to tweak the install script to already download the binary to a place like $HOME/bin/auth0 as that might not be intended for all use cases. But adding a note about how to export it makes sense, wdyt? 🤔

As pointed out above, there are native, idiomatic Linux package managers which would make the installation process less painful. This is just feedback that the choice between incomplete manual instructions and requiring the download of a whole other MacOS package-manager does not leave a good first impression.

👍🏻 Completely agreed, even tho the install script is a good step in the right direction, support for Linux package managers will come later on this year.

Edit: After looking into the manual instructions further, I'm sure they would not work anyway. For instance, /etc/bash_completion.d/auth0 is not automatically run when bash starts.

Thanks, I'll look into this as well!

But adding a note about how to export it makes sense, wdyt?

I think this would really help. I for one never remember exactly what to do, so I have to look it up every time 🙈

Completely agreed, even tho the install script is a good step in the right direction, support for Linux package managers will come later on this year.

Great news. I'm glad the feedback was accepted so well.

And, I do have to say, once Homebrew was downloaded and installed, installation worked out of the box.  👍🏻

Some really good discourse here, it's all been noted. Per the spirit of this ticket, we've updated the readme to include non-homebrew linux instructions. As such, I'm going to close this issue. If anyone has any additional feedback, feel empowered to open a dedicated issue. Thanks!

Thanks for that, it is appreciated.


New Deployment Type: NuGet

I have an idea for a new deployment type that would deploy the given module into the PSGallery or to any other NuGet-based repository. This would basically be a wrapper around Publish-Module.
I'll gladly create this deployment type if people think it makes sense.
Deploy MyModuleToPSGallery {
    By NuGet {
        FromSource '.\MyModule'
        To 'PSGallery'
        Tagged Prod
        WithOptions @{
            ApiKey = '<my_api_key>'
            IconUri = ''
            LicenseUri = ''
            Name = ''
            ProjectUri = ''
            ReleaseNotes = ''
            Version = ''
            Tags = @{}
        }
    }
}

Definitely makes sense, particularly with tools like the Nuget resource from @JasonMorgan and PSPrivateGallery.

100% would use this deployment option in my env, giving everyone a Known Good Source for latest modules in our org.

Hi! I'm wondering if it would be worth breaking this out into a few buckets:

Nuget - generic Nuget deployments
PSGalleryModule - PowerShell gallery module deployments
PSGalleryScript - PowerShell script deployments

Potential benefits:

I'm assuming generic nuget deployment parameters would not be like-for-like with parameters for publishing to the PowerShell Gallery. This would avoid parameterset fun.
Clearer. It will be easy to see if this is deploying a module, script, or... anything nuget.
Laziness. Planning a quick and dirty PSDeploy inception blog post (deploy PSDeploy with PSDeploy), writing a PowerShellGallery specific deployment would be a bit easier than trying to dig into the various options a nuget deployment would need.

Downsides:

More deployment types... but is that bad?
Naming. I don't like naming things. The examples I gave are a bit long

Will draft up a POC for the module and script deployments, but not married to the idea or to the names, just opening this up for discussion.

I think that makes sense for NuGet vs PSGallery. I have not messed with generic NuGet deployments but I assume the parameter options will be different that deploying to PSGallery.
I started a initial deployment type that you may want to look at here: https://github.com/devblackops/PSDeploy/blob/nuget/PSDeploy/PSDeployScripts/NuGet.ps1
The deployment type NuGet should be renamed to PSGalleryModule or PSGalleryScript like you mentions above. I'm open to whatever name makes sense.
This is just a wrapper around Publish-Module and it expects you are publishing to a pre-registered repository by name. You can see the registered repositories with Get-PSRepository and register a new one with Register-PSRepository.
It would be easy enough to modify this to support scripts as well but that would probably require an option to be specified in WithOptions to differentiate between modules and scripts.

I think specifically with regard to "Will we end up with too many deployment types" the answer is "No."
I'd like to have specific, well tested, well documented, independently updated and modified deployment types. I think it makes sense to avoid monolithic deployment types in this situation.
It might make sense to leave deployment names as long if they're still specific and sensible - shortening "PSGalleryModule" to "PSGModule" doesn't seem worth it, especially since we want the PSDeploy.ps1 files to remain readable by humans.

+1 to adding this deployment type.

Going to close this and add an issue for PSGalleryScript.  I haven't worked with nuget much - if we're missing a deployment type (e.g. generic nuget), feel free to open an issue for that.
Cheers!


Made structural pattern matching practicable...

...by reducing the amount of generated method (per unapply method) from 11^n to 1.
Now, object trees of arbitrary(!) depth can be matched but the decomposition takes place in the first level of the object tree (the given object is level 0).
Before we could select arbitrary nodes of the object tree. That is not possible any more because it requires the patterns to return the actual arity using tuples - and therefore all possible return combinations had to be generated. This is simply not possible resp. practicable in a real-world application and soon exceeds the class file size. However, this is solved with this PR!!!

Current coverage is 95.82%

Merging #1167 into master will decrease coverage by -0.17% as of 52b01b9

@@            master   #1167   diff @@
======================================
  Files           78      77     -1
  Stmts         9063    9125    +62
  Branches      1712    1716     +4
  Methods          0       0
======================================
+ Hit           8700    8744    +44
- Partial         90      93     +3
- Missed         273     288    +15

Review entire Coverage Diff as of 52b01b9

Powered by Codecov. Updated on successful CI builds.

Towards #1087


W/kg evolution in firness chart?

Could the fitness trend chart include a line showing the evolution of W/kg?

would be really nice to have. but you would need to take a given time into focus. would be nice for the different power profiles: 5sec / 1min / 5min / 20min / 60min.
but that would also rely on a power profile feature like: https://www.trainingpeaks.com/blog/power-profiling/
that would require the power profile calculation on every ride. max power over different duration


boostrap files copied on every run?

First of all - thanks for this!
When i run gulp dev and then change files I noticed it copies the bootstrap files over every time.
This means reload times can take seconds.
I patched it by running a separate css:minify task for dev and this task calls a separate scss task.
gulp.task('css:minify-dev', gulp.series('scss-dev', function cssMinify() {
  return ...
}));

The scss-dev task does not have the gulp.series('bootstrap:scss' ... in it
but there's probably a more elegant way.

Thanks for using, I can make changes to conditionally run the bootstrap:scss task based on argv.
// Compile SCSS(SASS) files
gulp.task('scss', gulp.series(process.argv[process.argv.length-1] !== '--skipbscopy' ? 'bootstrap:scss': function(done){done()}, function compileScss() {
.....
}

and in command line you have option of skipping bootstrap copy.
gulp dev --skipbscopy


will u be trying to take advantage of the oculus link software later this year

because of oculus making the oculus link that comes out in November will be able to take advantage of the oculus link software and improve alvr ? also will you keep working on alvr

Currently, I have no idea if we could tap into the link software from oculus to improve ALVR. They only announced the tethered solution with the cable, so no wireless streaming. ALVR still has its usage.
Some of the optimizations they talked about at OC6 to make the streaming work are already implemented in ALVR. The distorting of the image to reduce the video resolution is exactly how our FFR works.
Only time will tell if there will be a wireless solution from oculus. Rumor has it, that John Carmack is very interested in this topic. That's probably why they make the 6 month old Rift S obsolete over night.

Beside FFR there is one more important technical trick in Carmack's solution: not sending the whole frame, but slicing it to parts.
You can see this here around 4:40
https://www.youtube.com/watch?v=qcvGYD5sb-I

Carmack had some more details in his own talk. He was able to remove some layers you normally have to talk to the video processor. I guess this is used to do the rendering of the slices on the quest.
Encoding the slices should be possible in ALVR, but as far as I know, the android decoder takes a full frame to decode and present it. I'm no expert on this and if someone has some insights and expertise in this, don't be shy :)

Sadly I find the code related to frame decoding and rendering not easy to read. But since v7 it seems that you do some work on the Client between decoding the frame and rendering it.
Correct me if I'm wrong, but in v7 with the sliced ffr the received encoded frames are actually rescaled on the client after being decoded, and before being rendered.
So would it be possible to do something like :
On the server side :

apply the sliced ffr
split the resulting frame in 3 (or more) parts
encode each part and send them separately

On the client side :

receive first part, decode and store it
receive second part, decode and store it
receive third part, decode and store it
reconstruct the frame from the 3 parts
apply reverse sliced ffr to rescale the frame
render the resulting frame

It seems something similiar has already been realized in another project:
Tiled streaming
Some more Information/analyses:
Multi Tile Streaming
In my Opinion this could reduce the latency (encode-transfer-decode) nearby to the transfer latency only...

Its not a matter on how to do it. The concept is quite clear. The question is who and when.
Implementing this is a huge task and takes a lot of time I currently don't have.


[TC-MC-3.12]Media Input Cluster--DUT Fails to hide an input from the Input list.

#### Problem
As per the Test-Plan, TH sends HideInputStatus command to DUT to hide an input from the Input list, currently DUT fails to hide input from the Input list.

expected behavior:-Need to verify successful response (Value 0) on TH, and the Input hidden in Step 3 is not present in the list.

actual behavior:- successful response (Value 0) on TH, and all input from the Input list displayed.

steps to reproduce
./chip-tool mediainput read input-list 1 1
./chip-tool mediainput show-input-status 1 1
./chip-tool mediainput hide-input-status 1 1
./chip-tool mediainput read input-list 1 1

system configuration:-
Chip-Tool: RPI(chip-tool)
DUT: RPI(tv-app)
Platform : IP
Commit-ID: https://github.com/project-chip/connectedhomeip/commit/7afd35229da424a139642e4ebbe68bb4d71554cf
Platform:-Linux platform
Spec Reference:-
https://github.com/CHIP-Specifications/connectedhomeip-spec/blob/master/src/app_clusters/media/MediaInput.adoc#hideinputstatus-command
Test-Plan screenshot:-

PFA log below:-
[TC-MC-3.12].txt

Fixed test case, and test plan. These commands are a simple show/hide of the input list.


fix the way of building url with login token for reward tab webview

This PR closes #455, bug with wrong url generation for webview

fix the way of building source string for webview in case of opening reward tab

https://github.com/GoodDollar/GoodDAPP/issues/455#issuecomment-532376916


bug(INVT-CPC-757): Update build.gradle jacoco test requirements/lombok.config file

JIRA: link to jira ticket
https://champlainsaintlambert.atlassian.net/browse/CPC-798
Context:
This ticket is about updating the lombok,config in the root (which was empty) and updating our jacoco requirements
Changes

Updated the lombok.config file with the required code
Updated the inventory-service build.gradle jacoco requirements
This change will affect our jacoco test reports

looks good


FDP-47 ~ Updates low voltage measurement message definition.

It does not seem to me that the code supports both versions. Version 2 is supported but how is version 1 still supported?


Error when using fitToCoordinates

I tried different way of using this function and i always get an error : "owner.getName is not a function"
I reproduced exactly the exemple : https://github.com/airbnb/react-native-maps/blob/master/example/examples/FitToCoordinates.js
But still get an error.
this._map.fitToCoordinates([MARKERS[2], MARKERS[3]], {
         edgePadding: { top: 100, right: 100, bottom: 100, left: 100 },
         animated: true,
      });

With MARKERS[2] & MARKERS[3] an object with key latitude & longitude

@QQizi are you following the exact example in the FitToCoordinates.js file?

I have the same problem with you.  "owner.getName is not a function" .

@rborn I tried to clean all my code and use the exact same example, still got the error.
I feel like the function is expecting markers instead of simple coordinate.


Fix for Bazel upcoming change --incompatible_string_join_requires_strings

The argument of string.join should be a list of strings. In the future,
Bazel won't perform this implicit conversion.

filed #749 as it looks like our windows CI is flaky.


Add Per-Repository Options

It would be good to look into a more robust way of defining per-repository configs. The current practice of using a . to denote a private repository could use the new system instead, as well as any other options.
The current repositories block:
repositories [
  releases
  snapshots
  .private
]

Might look like:
repositories [
  releases --no-redeploy
  snapshots
  private --private
]

I'm not entirely sure how you'd want to format it, given that there's no precedent for any kind of "object" in your config file, but I wanted to open the conversation.

We can convert repositories into objects or maps:
repositories {
  releases {
    redeploy: false
    public: true
  }
  private {
    redeploy: false
    public: false
  }
}

CDN will perform conversion automatically, so it is not a problem, but I kinda like your proposal with flags, just because it looks cleaner.

Gotcha. I hadn't seen your CDN repository, so I wasn't entirely sure what the config format was. Either flag-style or objects should work fine. I have a hard time thinking of any options that couldn't be represented as either --flag or --flag [data], which would both be acceptable. Objects are going to be more familiar to a lot of people though, so it's probably worth using objects for that reason alone.

I think it might be even harder to declare repositories in the configuration through objects tbh. I think we should stay with flags at this moment and in case of any further issues, it could be migrated to standalone file (just like tokens), where some kind of a new command set would properly manage them.

There is a proposal for per-repository configuration of proxy (#448) that brings the topic of properties like lists:
https://github.com/dzikoysk/reposilite/blob/daa7d05c133f03d6e7b32d224e62b08dae138784/reposilite-backend/src/main/java/org/panda_lang/reposilite/config/Configuration.java#L80
Summing up various related issues we'd get sth like:
repositories [
  releases --no-redeploy --quota 1GB
  snapshots --cleanups --quota 1GB
  mirror --quota 1GB --cleanups --store-proxied --proxied https://repo1.maven.org/maven2;https://repo1.maven.org/maven3;https://repo1.maven.org/maven4
  anonymous --hidden
  private --private
]

I wonder if we want to keep it that way or we want to a little modify it. Some possible variants:
repositories [
  # v1
  releases [
    --no-redeploy
    --quota 1GB
  ]
  # v2
  snapshots [
    cleanups
    quota 1GB
  ]
  # v3
  mirror {
    quota: 1GB
    cleanups: true
    store-proxied: true
    proxied [
      https://repo1.maven.org/maven2
      https://repo1.maven.org/maven3
      https://repo1.maven.org/maven4
   }
  # v4 (current)
  anonymous --hidden
  private --private
]

I kinda like v1/v2/v4, but that's just my preference and I'd like to know what's your opinion.

I've already gone ahead and implemented a system very similar to v4, but I'd be happy to change it. More parsing will be required, but that shouldn't be a large issue if you think it would be worth it.

I'm pretty sure we shouldn't parse and load it that way 🤔 I think we should keep configuration as a static piece of information. In v4 case, the repository domain configuration should get a parameters string for each repo from configuration and load it with picocli (it's probably the best option for clean load of v1, v2 and v4). I may try to implement omitting default values in CDN entities, so we could simplify a little v3.


Popup UX issues in 0.3

With today's update release, I've found a number of issues with the UI:

If api_token is missing from local storage, the api token field gets set to the literal value 'undefined', thus resulting in summary requests failing, even when the user was authed with a Kagi session.
With the update to manifest v3, the host_permissions for https://kagi.com were not guaranteed to be granted on install. That's causing the automatic session retrieval to fail, as the webRequest handler is never triggered. (fixes #14)
When the session is automatically retrieved after clicking Let's go!, the popup does not reflect that unless closed and re-opened manually.
Clearing the session token field causes the popup to reset back to the no_session view, but the settings icon remains set to the close button, resulting in a confusing two X's:

I've addressed all of these in this PR. I hope this will make for a smoother onboarding experience for users :)

@hmnd @kepstin All merged and submitted to Firefox store, should be up shortly.
Thank you both.
For some reasons these issues were missed in user testing and we do not use Firefox/Chrome internally so we missed them too.
Very happy to have such responsive, knowledgeable and supportive community members.

Amazing work, thanks for catching and fixing these!


Add a transcode option.

Because all the videos from screenscraper.fr are too heavy for the poor
raspberry pi, I've added an option to the scraper to transcode them on
download. This will save me lots of time when scraping as I won't have
to manually transcode the videos. Note that this requires HandBrakeCLI
to be installed and it's probably not the best idea to do it on the Pi
itself as it's pretty CPU intensive.

Actually I'll go ahead and merge this in. Thanks!

I meant to ask but forgot. Does this work on windows? I know the program is available there but wasn't sure if the PATH was set up correctly to find it automatically. If you don't know, I can pull out my VM with an old copy of windows XP and see.

I have not tested it on Windows, I don't run Windows myself so I couldn't test it on that platform. Although, assuming that HandBrakeCLI takes the same flags, it should work as long as it's in the PATH.


Plot overhaul

Follow scanpy's plotting conventions more closely.
Supersedes #193.

[ ] Possible to build a common plotting library for the scanpy ecosystem?
[ ] deal with coloring of non-categorical pandas columns

Maybe always return the figure instead of the axes? Seems to work well with jupyter (doesn't show anything similar to "<Axes: title={'center': 'Number of cells in airr:receptor_subtype by gex:source'}, xlabel='airr:receptor_subtype', ylabel='Number of cells'>".

Accompany with "plotting cookbook",

how to make figures of a certain dimension
how to combine figures into one
how to save figures in high quality

Something like
def plot_mpl():
    with plt.ioff():
        fig, ax = plt.subplots()
        ax.plot(range(10))
        return fig

works well in Jupyter. It shows the figure and one can use the figure object for saving etc. if one wants to.
If someone works in ipython, they'd need to manually call .show() -- but I think this would be ok.

Holoviews abstracts different plotting backends:
https://holoviews.org/index.html


How can I set CSS rule in vscode-jupyter?

As is known to all, the number of characters in a line is limited.
I refer to this issue on so, it said I can modify the css rule, however, I don't understand how can I edit this file on vscode.
There has another answer, use magic command while it doesn't work on vscode-jupyter. This works on web jupyter well.
%%html
<style>
div.output_area pre {
    white-space: pre;
}
</style>

Is there any way to set the limitation of line characters or change the css file on vscode?
Thank you for any help.

Any help?

can you explain the limitation more, I'm not sure what character limit you are referring to within the vscode.

I have a similar issue.

@ulysse06 - that should be addressed in the next release, and you can install insiders to see it today. The notebook.output.wordWrap setting has also been introduced to configure word wrapping in the output


Get a 100 on lighthouse for accessibility

Is your feature request related to a problem? Please describe.
There are parts of the website that can use improvements in increasing the accessibility of the website.

Describe the solution you'd like
Open website in chrome, use lighthouse under "Audit" in developer tools and it'll tell you where we can improve the website under the accessibility section.
Additional context
This is for the light mode version of the website, the dark mode will need some more eyes regarding contrast color palettes, hence it will be worked on a little later.

I'm leaving this open for first-time contributors, so please be mindful before claiming :)
/available

I'm new to react and a first time contributor. I have another issue open though. #1604
However would like to work on this.
/claim

/claim

Hi @jeremyphilemon
I have brought it up to 96 on home page alone and is available at mkesavan13:covid19-react/HUNDRED_ON_LIGHTHOUSE.  Working on other page lighthouse issues. However I have a doubt.
The pending 4 points are related background and foreground colours. Bringing that one up to 100 requires minor colour changes. Shall proceed with changing the colours as per dev tool guidelines or is there any project specific guidelines that I should follow?

@mkesavan13 Hey thanks for working on this!
Between which colors and which components is the tool suggesting the contrast issue?

Hi @jeremyphilemon
I'm glad to work on this. If you look at the screenshot below you'll know. It points out most of the elements. The tool mentions that the four colours for "Confirmed", "Active", "Recovered" & "Deceased" itself needs contrast adjustment. Do you need me note down and share, specifically which elements or which colours need a change?

Hi @jeremyphilemon
There's a problem with material select w.r.t accessibility labels. I'm working on it as well. Other than that one and these Background and foreground colour changes, every other page is complete.
Please let me know about these colour changes alone. Looking forward and thank you.

Hi @jeremyphilemon
There's an update. I also found what the problem was with the Select native and fixed the accessibility issues. Have opened a Draft PR #1715
Kindly let me know how do we proceed about this. Thank you.

Hi again,
https://covid19india-react-git-fork-mkesavan13-hundredonlighthouse.covid19india.now.sh/state/DL
In the state page, there's a hidden "Visit state page" link. Since this is hidden, I think there's no point providing an accessibility label to a hidden button. Kindly let me know your thoughts. Thank you.

Hi @jeremyphilemon,
I am still waiting for an update from you. Please let me know how to proceed about this.
Thank you.

/claim

I'm new to react and a first-time contributor
How can I claim the project

/claim
1st time contributor. What has to be done reply please @jeremyphilemon

This issue is available for contribution.
Please reply "/claim" (without quotes) if you wish to work on this issue.

/claim

I'm new to react and a first time contributor. I have another issue open though. #1604
However would like to work on this.
/claim

Hi, i would like to work on this :)
/claim

This issue is available for contribution.
Please reply "/claim" (without quotes) if you wish to work on this issue.

Hi, i would like to work on this :)
/claim

Hi, i would like to work on this :)
/claim

/claim

/claim

@jeremyphilemon  /claim

/claim

/claim


NIFI-8036: Adding es.failure.reason to PutHttpProcessor

Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
NIFI-8036: Adds flow file attribute with failure reason in PutElasticsearchHttp processor.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[X] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[X] Has your PR been rebased against the latest commit within the target branch (typically main)?

[X] Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

[X] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
[ ] Have you written or updated unit tests to verify your changes?
[X] Have you verified that the full build is successful on JDK 8?
[ ] Have you verified that the full build is successful on JDK 11?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
[ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
[ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.

This is OBE, as the "reason" attribute already puts the failure reason in a flowfile attribute.


How do I get constituents from a tree annotation?

In this example it shows the ability to extract constituents from a tree annotation:
    // get tree
    Tree tree =
        annotation.get(CoreAnnotations.SentencesAnnotation.class).get(0).get(TreeCoreAnnotations.TreeAnnotation.class);
    System.out.println(tree);
    Set<Constituent> treeConstituents = tree.constituents(new LabeledScoredConstituentFactory());
    for (Constituent constituent : treeConstituents) {
      if (constituent.label() != null &&
          (constituent.label().toString().equals("VP") || constituent.label().toString().equals("NP"))) {
        System.err.println("found constituent: "+constituent.toString());
        System.err.println(tree.getLeaves().subList(constituent.start(), constituent.end()+1));
      }
    }

I took the above code from the
Stanford CoreNLP Website
(https://stanfordnlp.github.io/CoreNLP/parse.html#examples).
I attempted to do this but
the constituents() method does not exist:
var sentences = annotation.get(typeof(CoreAnnotations.SentencesAnnotation));

foreach(CoreMap sentence in sentences as ArrayList){

    var tree = sentence.get(typeof(TreeCoreAnnotations.TreeAnnotation));

    tree.constituents(); // Here the constituents() method does not exist
}

most probably you cannot use  typeof you need java.lang.Class
public static java.lang.Class GetAnnotationClass<T>()
            =><EMAIL_ADDRESS>// or = new T().getClass()

var sentences = annotation.get(GetAnnotationClass<CoreAnnotations.SentencesAnnotation>);
foreach(CoreMap sentence in sentences as ArrayList){
    var tree = sentence.get(GetAnnotationClass<TreeCoreAnnotations.TreeAnnotation>) as Tree;
    tree.constituents(); // most likely Tree is edu.stanford.nlp.trees.Tree
}

Thank you for the quick response!

I get the error " cannot convert from 'method group' to 'Class' " on these two lines:
GetAnnotationClass<CoreAnnotations.SentencesAnnotation>
GetAnnotationClass<TreeCoreAnnotations.TreeAnnotation>

Sorry, I forgot  brackets, GetAnnotationClass is a method that that  we should call, so GetAnnotationClass<T>()
var sentences = annotation.get(GetAnnotationClass<CoreAnnotations.SentencesAnnotation>());

Thank you so much it worked! I am just still new with C# so I don't understand why I'm getting "Object reference not set to an instance of an object." when using "java.util.ArrayList":
            var sentences = annotation.get(GetAnnotationClass<CoreAnnotations.SentencesAnnotation>());
            foreach (CoreMap sentence in sentences as java.util.ArrayList)
            {
                Tree tree = sentence.get(GetAnnotationClass<TreeCoreAnnotations.TreeAnnotation>()) as Tree;
                var treeConstituents = tree.constituents(new LabeledScoredConstituentFactory());
                foreach (Constituent constituent in treeConstituents as java.util.ArrayList) // I get the error here
                {
                    if (constituent.label().toString().Equals("NP"))
                    {
                        Console.WriteLine(constituent.toString());
                        Console.WriteLine(tree.getLeaves().subList(constituent.start(), constituent.end() + 1));
                    }
                }

            }

As compared with the example I showed previously by the CoreNLP website, I cannot use "Set" so I used "var" instead but still get the error.

I think I might have solved it by using "java.util.AbstractSet" instead of "java.util.ArrayList".

interior with Java/IKVM types is not very intuitive.
If you not sure what exact type is returned from annotation, you can take a look in debugger it Console.WriteLine(obj.GetType())

Oh I see now, thank you. Perhaps this is out of your area of expertise but, I have been using CoreNLP within Unity and since adding the lines:
    public static java.lang.Class GetAnnotationClass<T>()
        	=><EMAIL_ADDRESS>
I have been getting an error about not being able to load the file "IKVM.OpenJDK.Core, Version 8.1". I was wondering if you could think of any DLL that I could be missing which could add the "GetAnnotationClass()" functionality within Unity? The full error within the console is this:

Error: Could not load signature of NLP:GetAnnotationClass due to: Could not load file or assembly 'IKVM.OpenJDK.Core, Version=8.1.5717.0, Culture=neutral, PublicKeyToken=13235d27fcbfff58' or one of its dependencies. assembly:IKVM.OpenJDK.Core, Version=8.1.5717.0, Culture=neutral, PublicKeyToken=13235d27fcbfff58 type: member:(null) signature:

I greatly appreciate any feedback.

I would check that IKVM.OpenJDK.Core is actually present near you exe or
If you are on Windows you use Fuslogvw.exe to log all assembly resolution requests and result to find out what file was no resolved.
you can try to replace GetAnnotationClass<T>() call by new T().getClass() and compare results

new T().getClass() worked perfectly. Thanks again.

Hey, I know I'm kinda late to the party. I'm pretty new to programming but have in my hands a project that's a bit difficult. Part of it is connect Unity with Stanford CoreNLP. What I've done so far is using IKVM tu turn the core .jar (using the original files and not the .NET port mainly because I don't know the difference, maybe that's my first mistake :/) into a dll. But Visual Studio is still not recognizing it. Can I get some guidance please? I'm kinda lost. Thanks in advance


OO Approach

Work in progress. Feel free to comment along the way.
This is an overview of the objects and their relationships as I currently see them. Some of the objects have yet to be built but are coming shortly :smile:

@woodall I like it! It's a lot that I'm going to have to process, but in general... there's a lot here that I like.
The only consideration that I'll want to make is that this gem was also built as part of a course I made for Pluralsight, and some people might come here from that course to look at the code.  That can easily be managed with some additional comments that I can make, so I don't see it as a blocker.
Sorry for the late reply, I didn't get an email from Github on this for some reason.  :confused:
Thank you for all this work!  I'll be commenting more soon.

@woodall One thought, just something to keep in mind...
I pulled this logic from another project, which brought over the logic from the original game.
I tried playing this game with a browser emulator, and I was able to go through rounds and get the same results on both sides.  At least until the game goes random.
But in that same vein... if the game is going to have text and play like the original, why not make it use the same text as the original?  We could replicate the same game experience as much as possible.

@woodall I took a deeper look at this... are you sure you don't want to just make your own gem?
I say that not to be mean, I'm actually trying to be helpful here... you're rewriting much of the gem, including commenting out all of the tests that I wrote during the refactor.  I'm not against a full rewrite of the thing, it's just... it's easier to take these types of changes in small chunks rather than one big swipe.
I even like the work, and it seems that you have some great ideas, which I don't want to squash.  But as it stands right now, I'm not enthusiastic about this pull request because the bits that give me confidence in how the gem works and how the game is played -- the tests -- are gone.
If it helps, I think you should continue on with this branch.  But when you're done, you could change the name of the gem and release it as your own creation.  Because that's what it is, and that's a good thing!
I'm going to close this PR because I'm not going to accept it as it stands... but I am going to follow your fork and see where it goes!! :smile:

Hey @darrencauthon
Yes I admit based on the branch name that things grew out of scope :-) I was having trouble knowing how to refactor the code with the auto-generated tests so I commented them out and realized I never went back to them.
Thanks for taking the time to review! :sunglasses:

@woodall Don't stop on my account, please... I'm interested to see how this gem looks when you're done. :smile:

@woodall With your permission, I think I'd like to cherry-pick some of your earlier commits regarding the documentation.

Of course!


Add cache flushing command

lgtm

why not just use https://pypi.org/project/django-clear-cache/?

...because I enjoy re-inventing the wheel. Closing this, we can just add a dependency to each project where we want it.


ARM64

The ARM64 servers are here! But no Docker. Since Docker has no official aarch support we need to find a workaround again :/

You would think the software would be in place before the hardware was made available to the public.

22 days and nothing?..

Any updates?

they used the old docker 1.12 which there is an ARM64 binary for. Docker CE is soon to be released on ARM64 officially. The build scripts are ready just not deployed in their release builds yet


[Refactor] Unify the pending inter-broker transaction requests

Motivation
The pending inter-broker transaction requests, including
WriteTxnMarkers, SaslHandshake and SaslAuthenticate requests, are not
unified currently. There are two maps whose key is the correlation id,
but the values are different in TransactionMarkerChannelHandler. One
is InFlightRequest while the other is PendingGenericRequest.

InFlightRequest: the WriteTxnMarkers request
PendingGenericRequest: the SASL related requests

The methods for serialization are not unified as well. InFlightRequest
uses KopRequestUtils to serialize the request to a Netty ByteBuf,
while PendingGenericRequest uses Kafka's utilities to serialize the
request to a NIO ByteBuffer.
In addition, the callback for WriteTxnMarkers response only accepts a
WriteTxnMarkersResponse instance, while in Kafka it's a
ClientResponse, which contains some extra fields like the request
header and the remote address. Therefore, currently KoP prints a
meaningless log and it's not debug level:

Received WriteTxnMarker response from node with correlation id $correlationId

Modifications

Add PendingRequest class as the abstraction of the pending request.
Add ResponseContext as the callback's parameter so that the callback
can print logs with enough information.
Change how the correlation id is generated to make it consistent with
Kafka.

Documentation
Check the box below.
Need to update docs?

[x] no-need-doc
No functionality change

Add type/bug label for this PR because it looks like to have fixed a bug accidentally. I will open an issue to describe how to reproduce it.

This refactor might make the SaslPlainTestBase#transactionsReadCommittedTest fail. Revert it from branch-2.9.3.
@Demogorgon314 Could you take a look at this issue (not an urgent task) later?

Sure. I'll take a look.


Add voltage.utils.get

Summary
h
What is the feature request for?
The core library
The Problem
h
The Ideal Solution
h
The Current Solution
No response
Additional Context
No response

h

h

h
I suppose


Layout attributes were received from the layout but are not valid for the data source counts. Attributes will be ignored.

Hello,
First of all, apologize for my level of English language.
I have setup a view collection with a search bar and filters. The layout being made with your package.
When i perform a reload on this with this method :  self.collectionView.collectionViewLayout.invalidateLayout().
I obtain this error on the debugger :
[CollectionView] Layout attributes <CollectionViewSlantedLayout.CollectionViewSlantedLayoutAttributes: 0x7ff1035113c0> index path: (<NSIndexPath: 0xbcd26c36f94746f0> {length = 2, path = 0 - 3}); frame = (0 603; 414 275); zIndex = 3;  were received from the layout <CollectionViewSlantedLayout.CollectionViewSlantedLayout: 0x7ff1035148a0> but are not valid for the data source counts. Attributes will be ignored.

After research i solved it by adding this method to your class CollectionViewSlantedLayout.swift
The method to add is :
override open func invalidateLayout() {
    super.invalidateLayout()
    self.cachedAttributes.removeAll()
}

I can put this code and make a pull request if you want and if you are ok.

@yacir If you want up this issue :)

Hi @yacir , thanks for sharing the great feature and its implementation! I also experienced the similar issue that the layout is all messed up when try to reload. I found the issue is due to non-clean-invalidation before recalculation. Amend to what @WestFR suggested, the following would be the solution. Thanks!
override func invalidateLayout() {
        super.invalidateLayout()
        self.cachedAttributes.removeAll()
        self.cachedContentSize = 0
        self.currentSize = CGSize.zero
}

@WestFR @DreaMorrin  Hello guys ! sorry i was busy with other projects. I'll fix it soom


[WIP] tests, storage: Fail if block storage not present

WIP

Fixes #
Why we need it and why it was done in this way
The following tradeoffs were made:
The following alternatives were considered:
Links to places where the discussion took place:
Special notes for your reviewer

Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

[ ] Design: A design document was considered and is present (link) or not required
[ ] PR: The PR description is expressive enough and will help future contributors
[ ] Code: Write code that humans can understand and Keep it simple
[ ] Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
[ ] Upgrade: Impact of this change on upgrade flows was considered and addressed if required
[ ] Testing: New code requires new unit tests. New features and bug fixes require at least on e2e test
[ ] Documentation: A user-guide update was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change.
[ ] Community: Announcement to kubevirt-dev was considered

Release note

NONE

phase 1: checking which tests fail when there is no skip pattern.
/test pull-kubevirt-e2e-k8s-1.29-sig-storage
/test pull-kubevirt-e2e-k8s-1.30-sig-storage
/test pull-kubevirt-e2e-k8s-1.31-sig-storage
/test pull-kubevirt-e2e-k8s-1.31-sig-compute-migrations
phase 2: Set the decorators in lanes where needed (need to check if that is done on prow/kubvirt repos).

/sig clean-code

/sig kind/cleanup

/sig cleanup


Problem installing it from pip

When I try to install it with pip, it outputs this error.
Collecting pillow-avif-plugin
  Using cached pillow-avif-plugin-1.3.1.tar.gz (11 kB)
  Preparing metadata (setup.py) ... done
Building wheels for collected packages: pillow-avif-plugin
  Building wheel for pillow-avif-plugin (setup.py) ... error
  error: subprocess-exited-with-error

  × python setup.py bdist_wheel did not run successfully.
  │ exit code: 1
  ╰─> [18 lines of output]
      running bdist_wheel
      running build
      running build_py
      creating build
      creating build\lib.win-amd64-cpython-311
      creating build\lib.win-amd64-cpython-311\pillow_avif
      copying src\pillow_avif\AvifImagePlugin.py -> build\lib.win-amd64-cpython-311\pillow_avif
      copying src\pillow_avif\__init__.py -> build\lib.win-amd64-cpython-311\pillow_avif
      running build_ext
      building 'pillow_avif._avif' extension
      creating build\temp.win-amd64-cpython-311
      creating build\temp.win-amd64-cpython-311\Release
      creating build\temp.win-amd64-cpython-311\Release\src
      creating build\temp.win-amd64-cpython-311\Release\src\pillow_avif
      "C:\Program Files (x86)\Microsoft Visual Studio\2022\BuildTools\VC\Tools\MSVC\14.34.31933\bin\HostX86\x64\cl.exe" /c /nologo /O2 /W3 /GL /DNDEBUG /MD -IC:\Users\igor\AppData\Local\Programs\Python\Python311\include -IC:\Users\igor\AppData\Local\Programs\Python\Python311\Include "-IC:\Program Files (x86)\Microsoft Visual Studio\2022\BuildTools\VC\Tools\MSVC\14.34.31933\include" "-IC:\Program Files (x86)\Microsoft Visual Studio\2022\BuildTools\VC\Auxiliary\VS\include" "-IC:\Program Files (x86)\Windows Kits\10\include\10.0.22000.0\ucrt" "-IC:\Program Files (x86)\Windows Kits\10\\include\10.0.22000.0\\um" "-IC:\Program Files (x86)\Windows Kits\10\\include\10.0.22000.0\\shared" "-IC:\Program Files (x86)\Windows Kits\10\\include\10.0.22000.0\\winrt" "-IC:\Program Files (x86)\Windows Kits\10\\include\10.0.22000.0\\cppwinrt" /Tcsrc/pillow_avif/_avif.c /Fobuild\temp.win-amd64-cpython-311\Release\src/pillow_avif/_avif.obj
      _avif.c
      src/pillow_avif/_avif.c(4): fatal error C1083: Nao e possivel abrir arquivo incluir: 'avif/avif.h': No such file or directory
      error: command 'C:\\Program Files (x86)\\Microsoft Visual Studio\\2022\\BuildTools\\VC\\Tools\\MSVC\\14.34.31933\\bin\\HostX86\\x64\\cl.exe' failed with exit code 2
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
  ERROR: Failed building wheel for pillow-avif-plugin
  Running setup.py clean for pillow-avif-plugin
Failed to build pillow-avif-plugin
Installing collected packages: pillow-avif-plugin
  Running setup.py install for pillow-avif-plugin ... error
  error: subprocess-exited-with-error

  × Running setup.py install for pillow-avif-plugin did not run successfully.
  │ exit code: 1
  ╰─> [20 lines of output]
      running install
      C:\Users\igor\AppData\Local\Programs\Python\Python311\Lib\site-packages\setuptools\command\install.py:34: SetuptoolsDeprecationWarning: setup.py install is deprecated. Use build and pip and other standards-based tools.
        warnings.warn(
      running build
      running build_py
      creating build
      creating build\lib.win-amd64-cpython-311
      creating build\lib.win-amd64-cpython-311\pillow_avif
      copying src\pillow_avif\AvifImagePlugin.py -> build\lib.win-amd64-cpython-311\pillow_avif
      copying src\pillow_avif\__init__.py -> build\lib.win-amd64-cpython-311\pillow_avif
      running build_ext
      building 'pillow_avif._avif' extension
      creating build\temp.win-amd64-cpython-311
      creating build\temp.win-amd64-cpython-311\Release
      creating build\temp.win-amd64-cpython-311\Release\src
      creating build\temp.win-amd64-cpython-311\Release\src\pillow_avif
      "C:\Program Files (x86)\Microsoft Visual Studio\2022\BuildTools\VC\Tools\MSVC\14.34.31933\bin\HostX86\x64\cl.exe" /c /nologo /O2 /W3 /GL /DNDEBUG /MD -IC:\Users\igor\AppData\Local\Programs\Python\Python311\include -IC:\Users\igor\AppData\Local\Programs\Python\Python311\Include "-IC:\Program Files (x86)\Microsoft Visual Studio\2022\BuildTools\VC\Tools\MSVC\14.34.31933\include" "-IC:\Program Files (x86)\Microsoft Visual Studio\2022\BuildTools\VC\Auxiliary\VS\include" "-IC:\Program Files (x86)\Windows Kits\10\include\10.0.22000.0\ucrt" "-IC:\Program Files (x86)\Windows Kits\10\\include\10.0.22000.0\\um" "-IC:\Program Files (x86)\Windows Kits\10\\include\10.0.22000.0\\shared" "-IC:\Program Files (x86)\Windows Kits\10\\include\10.0.22000.0\\winrt" "-IC:\Program Files (x86)\Windows Kits\10\\include\10.0.22000.0\\cppwinrt" /Tcsrc/pillow_avif/_avif.c /Fobuild\temp.win-amd64-cpython-311\Release\src/pillow_avif/_avif.obj
      _avif.c
      src/pillow_avif/_avif.c(4): fatal error C1083: Nao e possivel abrir arquivo incluir: 'avif/avif.h': No such file or directory
      error: command 'C:\\Program Files (x86)\\Microsoft Visual Studio\\2022\\BuildTools\\VC\\Tools\\MSVC\\14.34.31933\\bin\\HostX86\\x64\\cl.exe' failed with exit code 2
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
error: legacy-install-failure

× Encountered error while trying to install package.
╰─> pillow-avif-plugin

note: This is an issue with the package mentioned above, not pip.
hint: See above for output from the failure.```

Any updates?

I mean problem in your python version? try to update it


Fixed some typos and errors in the documentation and added new doc page.

Added new file 'source/docs/essentials/add-new-attribute.md' (name is self explanatory)

Thank you for your hard work. This could still be improved, but it is good enough as a first version :)
You've now the proud creator of a Front-Commerce documentation page ;)


Trademark infringement complain from<EMAIL_ADDRESS>

A few month ago I developed any app Status Saver to save WhatsApp Status but I got
Trademark Owner:
WhatsApp LLC
Complainant Email:
<EMAIL_ADDRESS>Complainant Details:
The app uses the trademarks, banners, badges and logos of WhatsApp without authorization, including, but not limited to, the use of ley elements of WhatsApp's Famous Trademarked Logo in the app's icon. The developer’s use of WhatsApp's trademarks in app’s title and/or icon implies an association or other relationship that is neither authorized nor endorsed by WhatsApp.
I tried to contact them throw email but it has been 5 days but no reply from WhatsApp LLC.  I am ready to do all required changes in app. I have done lots of hard work to develop this app. Please help me out.

Hi!
This repo is specifically for proxy related issues and I am not familiar with the infringement complain process unfortunately. I'll close this task.


priority

This adds a priority field to entries, only used if status is unknown  it should be an integer between 1 and 9  inclusive and unknown entries  are only  listed in the generated table if they have priority 1 or 2.
handling this proved trickier than expected as the where_expr; filter (despite being documented as available since jekyll 3.2) doesn't appear to work on gh-pages, which seems to claim it is jekyll 3.9.5 but anyway I think it's working now filtering "by hand" in a for loop.
The resulting display can be seen at
https://davidcarlisle.github.io/tagging-project/tagging-status/
which now shows 547 rather than 951 entries, although all the data is still in the YAML.
See discussion comments from me and Frank at
https://github.com/latex3/tagging-project/pull/214#issuecomment-2241338408
https://github.com/latex3/tagging-project/pull/190#issuecomment-2241548182
The initial assignment of priorities is a bit arbitrary for ease of bulk editing, all unknown entries with an updated date up to 2024-07-15 get priority 2 and all later ones get 9, this ensures that the TLC3 list gets shown as do all later additions with a state other than unknown. Individual packages could be adjusted after the merge.

@FrankMittelbach  adjusted as you requested (elsewhere)

entries with priority < 5 now show
priority applies to currently-incompatible and uknown
priority value is displayed (currently as a subscript to the status)
still the case that current priorities are all either 2 or 9

https://davidcarlisle.github.io/tagging-project/tagging-status/#classes


enhance: help and feedback panel

enhance: help and feedback panel
Adds a Help and Feedback panel to the new Dendron View Container.

Dendron Extended PR Checklist

NOTE: the links don't work. you'll need to go into the wiki and use lookup to find the note until we fix some issues in the markdown export

Code
Basics

[x] code should follow Code Conventions
[x] circular dependency check: make sure your code is not introducing new circular dependencies in plugin-core.  See Avoiding Circular Dependencies.
[x] sticking to existing conventions instead of creating new ones

eg: if configuration for utilities are already in one module or package, add future utilities there as well

Extended

General

[x] check whether code be simplified
[x] check if similar function already exist in the codebase. if so, can it be re-used?
[x] check if this change adversely impact performance

Operations

[x] when shipping this change, will it just work or will it introduce additional operational overhead due to complicated interface or known bugs?

Architecture

[x] check if code is introducing changes on a foundational class or interface. if so, call for design review if needed

eg: making changes to DNode

Instrumentation
Basics
Added to Airtable / Upcoming

[x] if you are adding analytics related changes, make sure the Telemetry docs are updated

Extended

[ ] can we track the performance of this change to know if it is successful?

eg: see usage for export pod

Tests
Basics

[N/A] Write Tests
[x] Confirm existing tests pass
[x] Confirm manual testing
[x] Common cases tested
[x] 1-2 Edge cases tested
[x] If your tests changes an existing snapshot, snapshots have been updated

looks good, feel free to merge after you've updated the links


Sidebar should be collapsed < 1600px

Sidebar should be collapsed < 1600px

Browser metadata
Path:      /
Browser:   Chrome <IP_ADDRESS> on Mac OS 10.15.7
Viewport:  1708 x 1027 @2x
Language:  en-US
Cookies:   Enabled

Open in BrowserStack

Open Deploy Preview · Mark as Resolved
Originally posted by @xraystyle1980 in https://github.com/decentdao/fractal-interface/issues/1578#issuecomment-2100961791

@xraystyle1980 it collapses for me. does it not on your computer?

Disregard. Behavior works as expected. Closing this issue


ADA/Accessibility: escape and click/tap outside modal to close modal

ADA/Accessibility: see the incredible accessible modal.

Escape should close the modal
clicking or tapping outside the modal should close it.

I'm confused, Remodal does both of these things. What are you suggesting?


public API should not rely on presence of window

Description:
If I use mithril (1.0) serverside (mithril-node-render) it complains about undefined variable window
Steps to Reproduce:
create a file
// test.js
const m = require('mithril')

run it with
> node test.js

Expected:
It should not throw any errors.
Actual:
/Users/sh/Work/OS/mithril-node-render/node_modules/mithril/render.js:1
(function (exports, require, module, __filename, __dirname) { module.exports = require("./render/render")(window)
                                                                                ^

ReferenceError: window is not defined
    at Object.<anonymous> (/Users/sh/Work/OS/mithril-node-render/node_modules/mithril/render.js:1:107)
    at Module._compile (module.js:541:32)
    at Object.Module._extensions..js (module.js:550:10)
    at Module.load (module.js:458:32)
    at tryModuleLoad (module.js:417:12)
    at Function.Module._load (module.js:409:3)
    at Module.require (module.js:468:17)
    at require (internal/module.js:20:19)
    at Object.<anonymous> (/Users/sh/Work/OS/mithril-node-render/node_modules/mithril/index.js:4:21)
    at Module._compile (module.js:541:32)

currently, I'm doing this to use the public api in node scripts: https://github.com/lhorie/mithril.js/blob/rewrite/bundler/lintdocs.js#L91

@lhorie that is incredibly clever code. Great to know everything in the docs has to be true - nice work!
As part of my hacking about with the router API, I've been trying to use ospec to validate patch code, and I'm also struggling with the mocks. I had been using browserify & tape-run to get tape code to run in the browser, but at a certain point I had problems with resetting state and thought I may as well move over to using ospec (now Mithril is the only dependency, which makes a lot of sense).
I was hoping to bind the generated browser environment mock to global.window & global.document, then require the Mithril index. Most things seem to work this way - mount, render, and the location effects of route, but route endpoints don't. Of course, all the route API stuff is constructed differently, with special dependency injections etc in ways I can't follow through to the point where I can see what's missing.
Specifically, this won't pass:
const o         = require( 'mithril/ospec/ospec' )
const callAsync = require( 'mithril/test-utils/callAsync' )
const mock      = require( 'mithril/test-utils/browserMock' )()

global.window   = mock
global.document = mock.document

const m         = require( 'mithril' )

o( 'Route endpoint methods trigger', done => {
	const onmatch = o.spy()
	const view    = o.spy()

	m.mount( document.body, '/', {
		'/' : {
			onmatch,
			view
		}
	} )

	callAsync( () => {
		o( onmatch.callCount ).equals( 1 )
		o( view.callCount ).equals( 1 )

		done()
	} )
} )

Is this a bug with the mock or dependency injection, or have I missed a trick?

o( onmatch.callCount ).equals( 1 ) wouldn't pass with the code that is in the rewrite branch. What error are you getting @barneycarroll ?

Right — that's the problem. I can't get any methods on a route endpoint to trigger (whether it's a RouteResolver or a Component). But, FWIW I can set routes and verify that location is being updated. Why wouldn't onmatch trigger in this scenario?

Could be because RouteResolver is {onmatch, render}, not {onmatch, view}

@lhorie oops, my bad. To give you another example, none of this will work either:
o( 'Route endpoint methods trigger', done => {
	const oninit = o.spy()

	m.mount( document.body, '/', {
		'/' : {
			oninit,
			view : () =>
			  m( 'p' )
		}
	} )

	callAsync( () => {
		o( oninit.callCount ).equals( 1 )
		o( document.body.firstChild.tagName ).equals( 'P' )

		done()
	} )
} )

...Which makes me think there is something special going on in how the router API test suite constructs the mocks which I don't understand.

try this
    m.mount( document.body, '/', {         '/' : {             oninit,             view () {                return m( 'p' )             }         }     } )

@jonathanobino well spotted! I meant m.route, not m.mount! I'll edit the code snippets...

OK, my problem was down to async test resolution. I found I needed to set a timeout of at least 9 milliseconds for the route to resolve. I'm not going to delve into the specifics of how the router API tests construct the mock differently, but it seems for convenience the standard frame budgeting doesn't apply in that suite.
So I can confirm the mocks work as expected with bundled Mithril routing as long as you make allowance for deferred execution.

@lhorie using global.window has some issues for me

some libs use the presence of global.window to determine if they are in browser or not
you have to make sure that you set this in advance which might be tricky in some cases

Only solution I would imagine is to allow to set window mock after initialisation (like in 0.2.x). Will try if that's possible somehow.

Other option would be to utilize browser-field. But I don't know if that's feasible with the custom bundler. It it would require to have 2 different /render.js one that uses window and one that uses the mock.

or something like...
(function (factory) {
	if (typeof exports === 'object' && typeof module !== 'undefined') {
		module.exports = factory(global);
	} else if (typeof define === 'function' && define.amd) {
		define(factory(window));
	} else {
		window.m = factory(window);
	}
}(function (window) {
	'use strict';
        var document = window.document;

window is global in node and window in browser, you can then check
document ? or window.window === window ?

to know if you are in the node env or the browser

The browser field may be the better way to go, although I don't think the bundler understands that field.

Any progress on this? I need mithril to work in node, for my isomorphic framework...

Here's what I just did for our similar-to-node-but-not-exactly-the-same SSJS framework.
var m;

// Polyfill DOM env for mithril
global.window = require("mithril/test-utils/browserMock.js")();
global.document = window.document;

// Require the lib AFTER THE POLYFILL IS UP
m = require("mithril");

// Make available globally for client scripts running on the server
global.m = m;

// Export for normal server usage
module.exports = m;

Yes, it's a bit silly but I don't see an obvious alternative currently.

@tivac That's a nice hack, thanks for sharing!

I do before everything other. Odd, but works
require('mithril/test-utils/browserMock')(global);

Will close this for now.

Is that a good way to go though? Having a mock window can trip some libraries up; this method seems to work: https://www.npmjs.com/package/detect-is-node, but still...
@StephanHoyer How will your getting started example for mithril-node-render look then? Will it be this?
require('mithril/test-utils/browserMock')(global);
var m = require('mithril');
var render = require('mithril-node-render');

render(m('span', 'huhu')).then(function (html) {
   	// html === 'huhu'
})

Ie: forced use of the mock?


[clockcal] Added an option to show weeks prior to the current week on clock calendar

Added setting CAL_ROWS_PRIOR: 0-4. This does not affect CAL_ROWS
In app.js, drawWatch() will now subtract CAL_ROWS_PRIOR * 7 from the first day of the clock calendar
In app.js, drawWatch() will now find today by accounting for CAL_ROWS_PRIOR

Nice feature, thanks!


Limit fusion of linalg.generic/indexed_generic ops to avoid redundant computation

The upstream fusion pass is greedy. It will fuse two operations based
only on whether they can be fused or not. This means there are cases
where operations are fused even if the original producer has other
uses that make the original producer non-dead. The side-effect is that
you end up with cases where the same computation is done many times
using multiple generic/indexed_generic operation.
It also has the side-effect of

Increasing the number of arguments to the dispatch region.
Increasing life-times of tensors.
Make dispatch regions non-dedupable.

Also add pass-statistics to DispatchLinalgOnTensors to get the number of dispatch regions created.

oh neat - I'm guessing DEBUG_WITH_TYPE(DEBUG_TYPE, only enables the debugs with -debug-only= set? (I was looking for a way to do this)

oh neat - I'm guessing DEBUG_WITH_TYPE(DEBUG_TYPE, only enables the debugs with -debug-only= set? (I was looking for a way to do this)

Thats right.


Update version to 1.0.67-0 on staging

Update version to 1.0.67-0

🚀 Cherry-picked to staging in version: 1.0.67-0🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production in version: 1.0.68-4🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Illegal Instruction on Rpi ZeroW

bluealsa is working fine on a Rpi3, but on a Rpi ZeroW, bluealsa crashes with an Illegal instruction.
$ sudo bluealsa
bluealsa: ctl.c:489: Starting controller loop
bluealsa: bluez.c:699: Registering endpoint: 0000110A-0000-1000-8000-00805F9B34FB: /MediaEndpoint/A2DP_MPEG24_Source
bluealsa: bluez.c:699: Registering endpoint: 0000110A-0000-1000-8000-00805F9B34FB: /MediaEndpoint/A2DPSource
bluealsa: bluez.c:699: Registering endpoint: 0000110B-0000-1000-8000-00805F9B34FB: /MediaEndpoint/A2DP_MPEG24_Sink
bluealsa: bluez.c:699: Registering endpoint: 0000110B-0000-1000-8000-00805F9B34FB: /MediaEndpoint/A2DPSink
bluealsa: bluez.c:935: Registering profile: 00001108-0000-1000-8000-00805F9B34FB: /Profile/HSPHeadset
bluealsa: bluez.c:935: Registering profile: 00001112-0000-1000-8000-00805F9B34FB: /Profile/HSPAudioGateway
bluealsa: bluez.c:935: Registering profile: 0000111E-0000-1000-8000-00805F9B34FB: /Profile/HFPHandsFree
bluealsa: bluez.c:935: Registering profile: 0000111F-0000-1000-8000-00805F9B34FB: /Profile/HFPAudioGateway
bluealsa: main.c:226: Starting main dispatching loop
bluealsa: bluez.c:857: Profile method call: org.bluez.Profile1.NewConnection()
bluealsa: transport.c:608: State transition: 0 -> 2
bluealsa: transport.c:96: Created new IO thread: HFP Audio Gateway
bluealsa: ctl.c:571: +-+-
bluealsa: bluez.c:796: HFP Audio Gateway configured for device A0:E9:DB:0D:2D:FD
bluealsa: transport.c:608: State transition: 0 -> 2
bluealsa: transport.c:96: Created new IO thread: HFP Audio Gateway
bluealsa: rfcomm.c:389: Starting RFCOMM loop: HFP Audio Gateway
bluealsa: at.c:156: AT message: SET: command:+BRSF, value:59
bluealsa: rfcomm.c:48: Sending AT message: RESP: command:+BRSF, value:992
bluealsa: io.c:997: Starting IO loop: HFP Audio Gateway
bluealsa: rfcomm.c:48: Sending AT message: RESP: command:(null), value:OK
bluealsa: rfcomm.c:55: HFP state transition: 0 -> 2
bluealsa: at.c:156: AT message: TEST: command:+CIND, value:(null)
bluealsa: rfcomm.c:48: Sending AT message: RESP: command:+CIND, value:("call",(0,1)),("callsetup",(0-3)),("service",(0-1)),("signal",(0-5)),("roam",(0,1)),("battchg",(0-5)),("callheld",(0-2))
bluealsa: rfcomm.c:48: Sending AT message: RESP: command:(null), value:OK
bluealsa: rfcomm.c:55: HFP state transition: 2 -> 5
bluealsa: at.c:156: AT message: GET: command:+CIND, value:(null)
bluealsa: rfcomm.c:48: Sending AT message: RESP: command:+CIND, value:0,0,1,5,0,5,0
bluealsa: rfcomm.c:48: Sending AT message: RESP: command:(null), value:OK
bluealsa: rfcomm.c:55: HFP state transition: 5 -> 7
bluealsa: at.c:156: AT message: SET: command:+CMER, value:3, 0, 0, 1
bluealsa: rfcomm.c:48: Sending AT message: RESP: command:(null), value:OK
bluealsa: rfcomm.c:55: HFP state transition: 7 -> 8
bluealsa: rfcomm.c:55: HFP state transition: 8 -> 9
bluealsa: rfcomm.c:55: HFP state transition: 9 -> 13
bluealsa: at.c:156: AT message: SET: command:+VGS, value:10
bluealsa: rfcomm.c:48: Sending AT message: RESP: command:(null), value:OK
bluealsa: ctl.c:571: +-+-
bluealsa: at.c:156: AT message: GET: command:+BTRH, value:(null)
bluealsa: rfcomm.c:48: Sending AT message: RESP: command:(null), value:OK
bluealsa: at.c:156: AT message: CMD: command:+CLCC, value:(null)
bluealsa: Unsupported AT message: AT+CLCC
bluealsa: rfcomm.c:48: Sending AT message: RESP: command:(null), value:ERROR
bluealsa: bluez.c:504: Endpoint method call: org.bluez.MediaEndpoint1.SelectConfiguration()
bluealsa: bluez.c:504: Endpoint method call: org.bluez.MediaEndpoint1.SetConfiguration()
bluealsa: ctl.c:571: +-+-
bluealsa: bluez.c:438: A2DP Source (SBC) configured for device A0:E9:DB:0D:2D:FD
bluealsa: bluez.c:440: Configuration: channels: 2, sampling: 48000
bluealsa: transport.c:608: State transition: 0 -> 0
bluealsa: ctl.c:550: New client accepted: 13
bluealsa: ctl.c:571: +-+-
bluealsa: ctl.c:571: +-+-
bluealsa: ctl.c:521: Client closed connection: 13
bluealsa: ctl.c:571: +-+-
bluealsa: ctl.c:550: New client accepted: 13
bluealsa: ctl.c:571: +-+-
bluealsa: ctl.c:571: +-+-
bluealsa: ctl.c:326: PCM requested for A0:E9:DB:0D:2D:FD type 1 stream 0
bluealsa: transport.c:698: New transport: 16 (MTU: R:672 W:895)
bluealsa: ctl.c:571: +-+-
bluealsa: bluez.c:1039: Signal: PropertiesChanged: org.bluez.MediaTransport1
bluealsa: transport.c:608: State transition: 0 -> 2
bluealsa: transport.c:96: Created new IO thread: A2DP Source (SBC)
Illegal instruction

Found a problem with libsbc (it was build for armv7)  so I rebuilt it, and I get a few lines further before a segfault.  This happens when playback is started.
bluealsa: transport.c:96: Created new IO thread: A2DP Source (SBC)
bluealsa: io.c:50: Opening FIFO for reading: /var/run/bluealsa/hci0-A0:E9:DB:0D:2D:FD-1-0
bluealsa: io.c:408: Starting IO loop: A2DP Source (SBC)
bluealsa: transport.c:608: State transition: 2 -> 2
bluealsa: ctl.c:571: +-+-
Segmentation fault

Hi,
Could you run bluealsa with gdb? I've got no armv7 device with bluetooth, which I could use for testing. Compile bluealsa with the -g option: CFLAGS=-g ../configure [extra options is any], then run bluealsa as follows: gdb --args bluealsa. When the segfault occurs, type bt and post here the results.

Armv7 devices were fine.   This is only a problem with armv6.   I ran the debugger, and it was still libsbc crashing....  Finally got the right search term in google to find this.   https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=856487  I applied the referenced patch to not use inline asm for armv6, and it now runs without crashing.
At least for the first track.  Anytime I change tracks or skip ahead in the track, the alsa output thread from the player stops sending data.   In this case, there are no errors or crashes from the player or bluealsa.  I'm assuming this is still a libsbc issue.   (For the record, I'm using squeezelite as the player.)


[action] added Appcenter plugin link to use instead of hockeyApp

Checklist

[x] I've run bundle exec rspec from the root directory to see all new and existing tests pass
[x] I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
[x] I've read the Contribution Guidelines
[x] I've updated the documentation if necessary.

Motivation and Context
The change is required because is mentioning to use hockeyApp, which is obsolete, as an option to submit beta versions.
A note is added to refer to an Appcenter plugin instead
Description
Added Appcenter link to refer to instead of HockeyApp
Tested my changes with the steps described in Checklist

I signed it!
El jue., 28 feb. 2019 a las 18:23, googlebot<EMAIL_ADDRESS>escribió:

Thanks for your pull request. It looks like this may be your first
contribution to a Google open source project (if not, look below for help).
Before we can look at your pull request, you'll need to sign a Contributor
License Agreement (CLA).
📝 Please visit https://cla.developers.google.com/
https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here (e.g. I
signed it!) and we'll verify it.
What to do if you already signed the CLA Individual signers

It's possible we don't have your GitHub username or you're using a
different email address on your commit. Check your existing CLA data
https://cla.developers.google.com/clas and verify that your email is
set on your git commits
https://help.github.com/articles/setting-your-email-in-git/.

Corporate signers

Your company has a Point of Contact who decides which employees are
authorized to participate. Ask your POC to be added to the group of
authorized contributors. If you don't know who your Point of Contact is,
direct the Google project maintainer to go/cla#troubleshoot (Public
version https://opensource.google.com/docs/cla/#troubleshoot).
The email used to register you as an authorized contributor must be
the email used for the Git commit. Check your existing CLA data
https://cla.developers.google.com/clas and verify that your email is
set on your git commits
https://help.github.com/articles/setting-your-email-in-git/.
The email used to register you as an authorized contributor must
also be attached to your GitHub account
https://github.com/settings/emails.

ℹ Googlers: Go here
https://goto.google.com/prinfo/https%3A%2F%2Fgithub.com%2Ffastlane%2Ffastlane%2Fpull%2F14325
for more info.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/fastlane/fastlane/pull/14325#issuecomment-468141986,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAkXgYbngLqIZxAnTy4sD9kGw2Pat08Kks5vR2e5gaJpZM4bWCRE
.

@ksairi Thanks for making this change! Can you check the "Allow edits from maintainers" button on this pull request so that I can add a few things on top of this change as well? https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork
Thanks! ❤

Great changes @joshdholtz! And thanks again @ksairi for taking the initiative on this one.

@janpio pleasure!


Deploy to NPM action is broken

The code fails to change the version number, I don't know why

I have no idea why it failed before...
I will close the issue and consider it a quantic interference


Add npx create-abell-app .

added  "npx create-app-abell ." functionality
Fixes #16

Glad you like that 😂, will check those and get back to you in a couple of days.

Totally missed this PR 🤦🏼
I'll merge it into separate branch and fix the tests and merge to main later.
Thanks for contributing @saideepesh000 🥳

Totally missed this PR 🤦🏼
I'll merge it into separate branch and fix the tests and merge to main later.
Thanks for contributing @saideepesh000 🥳


Minor improvements to CI build

Apparently apt-cache is not supported, and they recommend using a pip cache. https://github.com/travis-ci/docs-travis-ci-com/commit/bd8b56d501dbb47f76d139831c99f55ac69d1314
Also moved pytest.ini to base-level (so you can run pytest from anywhere in the repo)

Before:

After:

eh, i'll merge it with the other. sorry for the noise!


Library is using "babel-runtime", but doesn't have it in dependency list

I've removed babel from my project and saw that this library requires 'babel-runtime'. It is not in the list of dependencies (and peer dependencies also).  Also it is not in the source code, because babel adds it during transpiling.

Oh good catch, my bad!  Looks like this repo is still on Babel 6 too, I'll upgrade and fix the deps shortly.

Thank you, that is not obvious thing, because almost everybody uses Babel now

:tada: This issue has been resolved in version 1.1.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Windows Defender SmartScreen treats installer as an unrecognized app.

When installing CairoSetup_64bit.exe Windows Defeneder SmartScreen blocks it with a popup saying it is an unrecognized app and that running it might put your PC at risk.  Not the best first impression if someone it trying it out for the first time. I'm assuming that the installer is unsigned and that signing it would fix this issue.

This is almost certainly due to the installer not being signed