Running with -e STEINBOCK_MASK_DTYPE=uint32 flag error

Hi,
I am currently running steinbock using (on ubuntu virtual machine):
alias steinbock="docker run -e STEINBOCK_MASK_DTYPE=uint32 -v ${BASEDIR}:/data -u $(id -u):$(id -g) ghcr.io/bodenmillergroup/steinbock:0.14.1"

The first few steps work fine (eg.):
steinbock preprocess imc panel --imcpanel config/TH152_panel.csv --mcd mcd/1 -o steinbock/panel.csv
steinbock preprocess imc images --hpf 50 --mcd mcd/1 --txt mcd/1 --panel steinbock/panel.csv --imgout steinbock/img --infoout steinbock/images.csv

But when I try to run the deepcell segmentation:
steinbock segment deepcell --minmax --panel steinbock/panel.csv --img steinbock/img -o steinbock/masks_deepcell

I get the following error:
2022-06-23 11:42:17,986 ERROR steinbock.segmentation.deepcell - Error segmenting objects in steinbock/img/20220520_TsH_th152_cisi1_001.tiff
Traceback (most recent call last):
  File "/app/steinbock/steinbock/segmentation/deepcell.py", line 113, in try_segment_objects
    yield Path(img_file), mask
GeneratorExit
Exception ignored in: <generator object try_segment_objects at 0x7f30909d19e0>
Traceback (most recent call last):
  File "/app/steinbock/steinbock/segmentation/_cli/deepcell.py", line 184, in deepcell_cmd
    io.write_mask(mask, mask_file)
RuntimeError: generator ignored GeneratorExit
Traceback (most recent call last):
  File "/usr/lib/python3.8/runpy.py", line 194, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/usr/lib/python3.8/runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "/app/steinbock/steinbock/__main__.py", line 17, in <module>
    steinbock_cmd_group(prog_name="steinbock")
  File "/opt/venv/lib/python3.8/site-packages/click/core.py", line 1130, in __call__
    return self.main(*args, **kwargs)
  File "/opt/venv/lib/python3.8/site-packages/click/core.py", line 1055, in main
    rv = self.invoke(ctx)
  File "/opt/venv/lib/python3.8/site-packages/click/core.py", line 1657, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/opt/venv/lib/python3.8/site-packages/click/core.py", line 1657, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/opt/venv/lib/python3.8/site-packages/click/core.py", line 1404, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/opt/venv/lib/python3.8/site-packages/click/core.py", line 760, in invoke
    return __callback(*args, **kwargs)
  File "/app/steinbock/steinbock/_cli/utils.py", line 35, in wrapper
    return func(*args, **kwargs)
  File "/app/steinbock/steinbock/segmentation/_cli/deepcell.py", line 184, in deepcell_cmd
    io.write_mask(mask, mask_file)
  File "/app/steinbock/steinbock/io.py", line 293, in write_mask
    tifffile.imwrite(
  File "/opt/venv/lib/python3.8/site-packages/tifffile/tifffile.py", line 1145, in imwrite
    result = tif.write(
  File "/opt/venv/lib/python3.8/site-packages/tifffile/tifffile.py", line 2022, in write
    raise ValueError(
ValueError: the ImageJ format does not support data type 'I'

Any help with this would be greatly appreciated.

Hi @leonorss, thanks for checking in! Indeed, the ImageJ TIFF format only supports uint8, uint16 and float32, but not uint32: https://github.com/cgohlke/tifffile/blob/master/tifffile/tifffile.py#L1348-L1357. I will adapt steinbock to only write TIFF files in ImageJ format when supported, and otherwise resort to "generic" TIFF files.

Thank you very much for your help, it is working now!


Code review and refactoring

Worked on Drifty_CLI, CreateLogs, FileLoader and ProgressBarThread.
Created package for the utility functions which were extracted from Drifty_CLI file.
Moved the HardCoded strings to DriftyConstant file.
Created Singletons for the Scanner class and CreateLogs file.

Used SonarLint (IntelliJ Plugin) to remove 90% of the code smells and followed best coding practices.

@bharathkalyans Issues help to manage the project and track it's progress. Please create an issue for the changes that you have brought through this Pull Request (PR).
I shall review the code changes within 3 days.
Thank you!

@bharathkalyans Let me know when you are done.


[Feature request] Global Gantt for all projects

Please, do not create duplicate issues
Actual behaviour
Gantt View is not available to see a global Gantt for all the managed projects
Expected behaviour
"Global Gantt" could be a new menu item in the /dashboard view
Configuration

Plugin version: latest
Kanboard version: latest
Database type and version:
PHP version:
OS: ALL
Browser: ALL

I would like to request a feature that my be already included in what you have in mind here. I would like to be able to see a gantt chart that represents the tasks that any given team member is working on across all projects in Kanboard. So if John Doe is working on Project A and Project B, and I want to see what availability John Doe has to work on Project C, I could filter my Global Gantt chart view to see all tasks assigned to John Doe.
(...or is this already possible???!!)

@unecologeek I can see all my projects in the Gantt chart. Maybe this issue is already solved and can be closed. Can you confirm?

Tested on kanboard 1.2.7 and 1.2.8... the Gantt for all projects is running forever in the browser after request (click on the link, see the yellow mark)... Gantt chart for ONE project works fine. How can I help, my debog.log is enabled.
I don't know if it it an interaction with another plugin, I'm a new user of Kandboard but I love it already, a beautiful piece of... code ;-)


TestNG DataProvider annotation regression

between 6.8.21 and 6.9.x there has been a dataprovider regression.
It used to be dataproviders would map to a particular method based on the containing class.
Now it appears that they pull from sort of global 'pool', and they aren't even filtering properly by supplying dataProviderClass.
Do you not have a TestNG test for this stuff yet? You need more tests for your tests, @cbeust
Will write-up a more detailed example, basically, I have:
`
class A {
@DataProvider(name="blah") public Iterator<Object[]> stuff() { ... }
@Test(dataProvider="blah") public void test1(Object... args) { ... }
}
class B {
@DataProvider(name="blah") public Iterator<Object[]> stuff() { ... }
@Test(dataProvider="blah") public void test1(Object... args) { ... }
}
`
The test1 in A and B should use the DataProvider in their classes. Not randomly pick and choose.
Already there was a regression in 6.8 I think where you have to specify the dataProviderClass...

It would be great if you can provide a test that fails...
Thanks!

Weird.
I have the test case, unless I'm doing something exactly what didn't work in my project is working in your project...
I have some other things to try, like changing the java version (8 vs 7).
A couple of questions regarding the current project.

I have my tests on top of tag 6.9.5 - is this 'current release'? 6.9.10 is the last release on maven central:

http://search.maven.org/#search|gav|1|g%3A"org.testng" AND a%3A"testng"
I saw the weird behavior w. 6.9.10 but not so much with 6.8.21, and then tried 6.9.4/5, didn't see a difference, but after testing inside the project maybe I have to eat my words... if there's not something else involved (like version of maven, java, project specific things).

I see you are using maven-release-plugin to version things. Your maven/pom-test.xml:
a) is that supposed to be in the root directory still?
b) you are referencing a 6.8.22-SNAPSHOT that AFAIK doesn't exist anywhere (no tags, no maven central releases.

What are you trying to say ? I'm not following you.

I'll push later today. I think it might be more informative just to see what I've done.

Sorry, have this on my plate still as a TODO. Have not forgotten.

Closing this issue. Please comment if this is still a problem in TestNG 6.14.3 (latest released version as of today)
I can't reproduce this using TestNG 6.14.3
Here's what I have.
Test classes
package com.rationaleemotions.github.issue989;

import java.lang.reflect.Method;
import org.testng.annotations.DataProvider;
import org.testng.annotations.Test;

public class ClassA {
  @DataProvider(name = "blah")
  public Object[][] stuff(Method method) {
    String m = method.getName();
    String c = method.getDeclaringClass().getName();
    System.err.println("Running data provider in ClassA for test method " + c + "." + m + "()");
    return new Object[][] {{1}};
  }

  @Test(dataProvider = "blah")
  public void test(int i) {
    System.err.println(i);
  }
}

package com.rationaleemotions.github.issue989;

import java.lang.reflect.Method;
import org.testng.annotations.DataProvider;
import org.testng.annotations.Test;

public class ClassB {
  @DataProvider(name = "blah")
  public Object[][] stuff(Method method) {
    String m = method.getName();
    String c = method.getDeclaringClass().getName();
    System.err.println("Running data provider in ClassB for test method " + c + "." + m + "()");
    return new Object[][] {{1}};
  }

  @Test(dataProvider = "blah")
  public void test(int i) {
    System.err.println(i);
  }
}

Suite xml
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE suite SYSTEM "http://testng.org/testng-1.0.dtd">
<suite name="336_Suite-MySuite-InVM" parallel="false" verbose="2">
  <test name="989_test">
    <classes>
      <class name="com.rationaleemotions.github.issue989.ClassA"/>
      <class name="com.rationaleemotions.github.issue989.ClassB"/>
    </classes>
  </test>
</suite>

output
...
... TestNG 6.14.3 by Cédric Beust<EMAIL_ADDRESS>...
Running data provider in ClassA for test method com.rationaleemotions.github.issue989.ClassA.test()
1
Running data provider in ClassB for test method com.rationaleemotions.github.issue989.ClassB.test()
1
PASSED: test(1)
PASSED: test(1)
===============================================
989_test
Tests run: 2, Failures: 0, Skips: 0
===============================================
336_Suite-MySuite-InVM
Total tests run: 2, Failures: 0, Skips: 0


Tools Page, Advisors Card, and Advisors Backend

Summary
Creates customizable tool card component, organizes tools page, and implements advisor tool card.
Card.vue is the tool card component, and it takes in a slot another component. AdvisorCard.vue is the first type of component implemented for the tools page, and it is used as a child element of a Card.vue on the Tools.vue container.

[x] Create tool card component according to design
[x] Implement collapsing and expanding tool card
[x] Keep tool cards from changing position on collapse/expansion
[x] Save collapsed state of individual tool card in browser
[x] Use tool card props for different desired sizes
[x] Implement basic organization of tool cards on tools page
[x] Create advisor card
[x] Implement front-end components for advisor content table
[x] Add link icon to email
[x] Create types for advisors and packages of information and add them to existing requirement architecture
[x] Write checkers for advisor based on user's last name
[x] Add advisors for CS major & Engineering college

Test Plan
Run GK.enableTools().
Add majors, minors, and colleges that we have advisor data for. Go to the tools page and verify that the advisors are correct based on any checker logic are in the right order (college -> major -> minor). Also make sure the amount of advisors is capped (default is 5 max).

Notes

Should we keep the Gatekeep for the tools page?
Should the checkers be an array like for requirements, and are there any other things we should be able to check aside from first/middle/last name?
I excluded the advisors from the decorated requirements because I'm doing all the computation by reading the index file directly.
Do I include the advisor type on the card?
Is there anything wrong with using pixels?
What happens when there are no advisors?
What do I do with source?

Future TODOs for another PR:
From Yuxuan:

card grows and always has 48px margin bottom

let cards reposition when collapsed

implement design for no advisors

Strengthen organization of cards in tools page. Currently, tools will maintain their position when collapsed or expanded, so that is not an issue. However, the currently layout will place cards horizontally then wrap based on space.

https://user-images.githubusercontent.com/47431797/166091905-f7e81744-758a-448f-b87a-d32916a30ab8.mov

note from Will: make hidden button not a real button

Hi @jessfeng, thanks for the feedback! I'm not sure what you mean by including the general advising office in case students want to reach them. I included a required field for the source of our advisor data in the code, so we have a link to at least where we see that the shown advisors are the advisors. Is that what you mean, or would you want something even more general like the Engineering Advising home page? Either way, I think I brought this up in crit, but we don't currently have anywhere to display the source or any other link in the current design. How would you like me to try to include this information?

Hi @jessfeng, thanks for the feedback! I'm not sure what you mean by including the general advising office in case students want to reach them. I included a required field for the source of our advisor data in the code, so we have a link to at least where we see that the shown advisors are the advisors. Is that what you mean, or would you want something even more general like the Engineering Advising home page? Either way, I think I brought this up in crit, but we don't currently have anywhere to display the source or any other link in the current design. How would you like me to try to include this information?
I'm not sure what the intended behavior is when the screen is shrunk so that the card cannot display all the information. Once we decide what should happen, I'll be happy to fix this!

The changes look good--whitespace and lowercasing last names work as expected now!
As for the general advising office, I meant something like the Cornell Eng Advising office like Yuxuan put on the Figma file, so we minimize the amount of people with the empty state contact advisor card. Not sure if all colleges have a contact like this, but I know I've emailed them a couple times about transfer credits among other things, so it might be useful to have that on there if they need to talk to anyone. It's just a minor thing, so if it's too much work, we can just table it and add it to the backlog.

As for shrinking the screen, we can do that in the next PR once Yux gets back to us but other than that, I think it looks good to go!

Hi @jessfeng, thanks for the feedback! I'm not sure what you mean by including the general advising office in case students want to reach them. I included a required field for the source of our advisor data in the code, so we have a link to at least where we see that the shown advisors are the advisors. Is that what you mean, or would you want something even more general like the Engineering Advising home page? Either way, I think I brought this up in crit, but we don't currently have anywhere to display the source or any other link in the current design. How would you like me to try to include this information?
I'm not sure what the intended behavior is when the screen is shrunk so that the card cannot display all the information. Once we decide what should happen, I'll be happy to fix this!

The changes look good--whitespace and lowercasing last names work as expected now!
As for the general advising office, I meant something like the Cornell Eng Advising office like Yuxuan put on the Figma file, so we minimize the amount of people with the empty state contact advisor card. Not sure if all colleges have a contact like this, but I know I've emailed them a couple times about transfer credits among other things, so it might be useful to have that on there if they need to talk to anyone. It's just a minor thing, so if it's too much work, we can just table it and add it to the backlog.

As for shrinking the screen, we can do that in the next PR once Yux gets back to us but other than that, I think it looks good to go!

Oh, I see what you're talking about! Yeah, I think we could include that! That would require a little bit of work to do nicely, and I don't have time for that right now with finals. I want to probably implement Yuxuan's final design for the empty state first since we don't have much data yet, but it would definitely be good to include something like that.


TextFieldLabel: Wrong position on focused/filled

Describe the bug
When a TextField is focused or filled, the label x translation is variable based on string length.  The longer the string the more to the right the label is pushed.  Short strings seem to line up almost correctly.
To Reproduce
Steps to reproduce the behavior:

Render TextFields (outlined/filled) with variable length labels
Observe that when focused/filled the label's x position is wrong.

Expected behavior
The TextField should follow Material Design and position the label accordingly.
Screenshots
If applicable, add screenshots to help explain your problem.

Smartphone (please complete the following information):

Device: iPhoneX
OS: iOS 12.2

Additional context
Will be putting in a fix very shortly.

Closed by #207


feat: add Submodule.Quotient.instBoundedSMul

The proof needs minimal modifications to go through for the inequality case.

I don't think that performance should be an issue here.
maintainer merge

Thanks! :tada:
bors merge


Add a grace period for new stakes to become active

Fixes #901

Codecov Report

Merging #905 (0734255) into master (828364b) will decrease coverage by 0.68%.
The diff coverage is 50.86%.

@@            Coverage Diff             @@
##           master     #905      +/-   ##
==========================================
- Coverage   50.51%   49.82%   -0.69%
==========================================
  Files         145      145
  Lines        7544     7582      +38
==========================================
- Hits         3811     3778      -33
- Misses       3066     3130      +64
- Partials      667      674       +7

Impacted Files
Coverage Δ

pkg/config/consts.go
0.00% <ø> (ø)

pkg/config/loader.go
58.97% <0.00%> (+0.74%)
:arrow_up:

pkg/core/candidate/validator.go
57.14% <ø> (ø)

pkg/core/chain/legacy.go
26.08% <0.00%> (-2.49%)
:arrow_down:

pkg/core/chain/mock.go
8.33% <ø> (ø)

pkg/core/chain/sequencer.go
91.30% <ø> (ø)

pkg/core/consensus/agreement/accumulator.go
83.01% <ø> (ø)

pkg/core/consensus/agreement/handler.go
56.14% <ø> (ø)

pkg/core/consensus/agreement/store.go
62.12% <ø> (ø)

pkg/core/consensus/agreement/testutil.go
100.00% <ø> (ø)

... and 124 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ee8839...0734255. Read the comment docs.


Dependency installation with npm fails

Installing creator-js-client fails since the line
"creator-js-client": "https://github.com/CreatorDev/creator-js-client.git",
in package.json is invalid. It should be
"creator-js-client": "git://github.com/CreatorDev/creator-js-client.git",
instead.

@malaakso tried 'npm install' and it works fine with me. Can you please let us know your 'npm --version'?

@payalsarnot it's 1.3.10 (which is old, I know). According to https://docs.npmjs.com/files/package.json#git-urls-as-dependencies, plain https is not correct.

@malaakso what I see from logs is
"+--<EMAIL_ADDRESS>(git+https://github.com/CreatorDev/creator-js-client.git#a058bf7e06b391b8502ee1c2775c929181dae79c)"

Hi @malaakso,
We've updated the creator-js-client dependency URL: https://github.com/CreatorDev/ci40-kiwano-webapp/commit/a4b9288f96fd29c4281327212e90633f08160118
Thank you for your suggestion.
Best regards,
Hugo


Github Project Templates for PULL REQUESTS, CONTRIBUTING AND CREATING ISSUES

This PR helps new contributors to the project get pretty much acquainted with steps to begin contributing to React Proto using

A CODE OF CONDUCT to describe a recommended tone for communication
AN ISSUE TEMPLATE to structure out features/enhancements from bug reports
A CONTRIBUTING guide for new contributors

Refer to Issue #79

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] This change requires a documentation update

[x] I have read the CONTRIBUTING document and have signed (or will sign) the CLA.
[ ] I have updated/added documentation affected by my changes.
[ ] I have added tests to cover my changes.

Thanks.

You're welcome


firing resume on multiple operations causes the AFURLConnectionOperation to crash

Steps to reproduce:
Setup AFHTTPRequestOperationManager with custom maxConcurrentOperationCount for example = 3  and add several operations.
Pause all the operations and then resume them.
AFURLConnectionOperation crashes at:
-[NSObject(NSKeyValueObserverNotification) didChangeValueForKey:] + 88
-[AFURLConnectionOperation setState:] (AFURLConnectionOperation.m:331)
-[AFURLConnectionOperation finish] (AFURLConnectionOperation.m:478)
-[AFURLConnectionOperation connectionDidFinishLoading:] (AFURLConnectionOperation.m:696)

It is somehow connected to customising maxConcurrentOperationCount because if it's not set the following crash will not occur.

Thanks for the issue @Wielkibrat. Would you be able to add a test demonstrating the crash, and post it up?
Thanks!

Created a very sample project demonstrating the issue and uploaded it here http://sendfile.es/pokaz/517680---qW1d.html

@Wielkibrat would you be able to push the example to github or include the zip here? I can't seem to access that URL.

@kcharwood Sure https://github.com/Wielkibrat/AFUrlConnectionCrash

@Wielkibrat Given we have now moved past AFN 2.x and deprecated all use of NSURLConnection, I am going to close this out.
We are now only going to accept security patches for 2.x going forward.
:beers:


Add support for Python Playwright

Please add support for Python Playwright as python is the most used language for automation. Adding support for it would be easy as just the debugging address would be required and modifying the fetching of fingerprint by using requests. What's the use of having fingerprint switcher license and not being able to use the browser for Python when both the languages have similar Playwright implementations?

@CheshireCaat is there a possibility to port this to Python?

Right now we are busy with other tasks.

Right now we are busy with other tasks.

Maybe you should look at implementing support for language such as Python which is primarily used for automation instead of other things. I prefer using python for automation for Fingerprint switcher instead of the BAS.

I actually made it to the python

I actually made it to the python

Do you have a repo?


Which ONE play the response from AVS if there are multiple AVS Client devices in the same room?

IMPORTANT: Before you create an issue, please take a look at our Issue Reporting Guide.
Briefly summarize your issue:

if there are multiple AVS Client devices in the same room, the user he/she use voice command to trigger interaction, then which one AVS client will play the response from AVS server?
What is the expected behavior?

There is only one device play the response from AVS server.
What behavior are you observing?

It seems all of the AVS client device play the response from AVS server if it receive the answer.
Provide the steps to reproduce the issue, if applicable:

Setup multiple AVS client devices in one room, Start "SampleApp" on all devices then using voice command like "alexa, what time is it?", then all of AVS client will be wake-up and play response
Tell us about your environment:

What version of the AVS Device SDK are you using?
  <x.y.z>

<1.9.0>
Tell us what hardware you're using:

[ ] Desktop / Laptop
[ ] Raspberry Pi
[x] Other - tell us more: my embedded platform

Tell us about your OS (Type & version):

[X] Linux
[ ] MacOS
[ ] Raspbian Stretch
[ ] Raspbian Jessy
[ ] Other - tell us more:

Hi @DiazSo, I believe this is already something AVS takes care of.  It does require all devices to be under the same user account.  Is that the case here?  If the users are running registered to different users, yes they will all try to reply to the "Alexa" query, at least as things stand today.  Please let us know, thanks.

Hi @dhpp ,
Followed by this question. To compared with Echo, it seems under AVS, it will need to wait until timeout in thinking state, but Echo, it will stop immediately (I checked with the LED status).
Is it a expected behavior ?  Is there any mechanism and received "cancel" from server side under this ESP state ?

Hi @DiazSo, I believe this is already something AVS takes care of. It does require all devices to be under the same user account. Is that the case here? If the users are running registered to different users, yes they will all try to reply to the "Alexa" query, at least as things stand today. Please let us know, thanks.

Hi @dhpp . I have tested this condition. You are right. If all devices are under the same user account, then AVS takes care this condition. Only one device will play the response from AVS. If the devices are under different account then  all devices will play the response from AVS. In advance, could you provide the information about:
when all device are under the same account, then how AVS know which device should play the response from AVS? I see the behavior :
all devices will enter the state  Listening...-->Thinking...--> then there is only one device will enter Speaking..., and finally, all device will enter "Alexa is currently idle!".
Thanks!

Hi @DiazSo , according to this: https://www.amazon.com/gp/help/customer/display.html?nodeId=202013740 , the one you're closest to will respond. It's determined by the voice energy (ESP) determined from the audio.
I'll be closing this issue. But feel free to reopen if you have more questions regarding this


error:tImplementedError: Could not run 'aten::amp_foreach_non_finite_check_and_unscale' with arguments from the 'CPU' backend.

when I use:
from torch.cuda.amp import GradScaler
amp = GradScaler(init_scale=512, growth_interval=100)
for img, label in train_iter:
with torch.cuda.amp.autocast(True):
label = backbone(img)
amp.scale(loss).backward()
amp.unscale_(opt)

@daixiangzi that looks like an error that is specific to cpu with the amp.scale? could you retry on cuda?

@daixiangzi that looks like an unrelated error that is specific to cpu with the amp.scale? could you retry on cuda?

When I use a single machine with multiple cards, I can run your code, but when I use multiple machines with multiple cards, this error will appear.

@daixiangzi that looks like an unrelated error that is specific to cpu with the amp.scale? could you retry on cuda?
I have always used it on cuda

are you using fsdp?

fsdp

no ,I use dip

ah, hard for me to debug. i only have a single machine

@daixiangzi could you try disabling mixed precision just for the MoE block?
with torch.cuda.amp.autocast(enabled = False):
    # ... your moe forward

@daixiangzi could you try disabling mixed precision just for the MoE block?
with torch.cuda.amp.autocast(enabled = False):
    # ... your moe forward

ok

@daixiangzi could you try disabling mixed precision just for the MoE block?
with torch.cuda.amp.autocast(enabled = False):
    # ... your moe forward

I try it just now, but not work

define moe layey:
self.softmoe = SoftMoE(dim = d_model,num_experts = num_experts,is_distributed=False,offload_unused_experts_to_cpu=True)

NotImplementedError: Could not run 'aten::amp_foreach_non_finite_check_and_unscale' with arguments from the 'CPU' backend. This could be because the operator doesn't exist for this backend, or was omitted during the selective/custom build proces

in fact I train dp version on single machine with multiple gpu, but result is still bad,  I have a little doubt about
https://github.com/lucidrains/soft-moe-pytorch/blob/4dc07b0d7ebc128e330cefc98af171c557b3a143/soft_moe_pytorch/soft_moe.py#L315
I see origin rep:https://github.com/google-research/vmoe/blob/dfb9ee01ce6dfc5a8228b406e768ee325dd18fcd/vmoe/nn/vit_moe.py#L109C27-L109C45
your code:
x = self.norm(x)
logits = einsum('b n d, e s d -> b n e s', x, slot_embeds)
...
slots = einsum('b n d, b n e s -> b e s d', x, dispatch_weights)

origin rep code seem is:
norm_x = self.norm(x)
logits = einsum('b n d, e s d -> b n e s', norm_x, slot_embeds)
....
slots = einsum('b n d, b n e s -> b e s d', x, dispatch_weights)

@daixiangzi hmm, have you tried it their way? conventionally we always work with pre-normalized values, so that would be weird they dispatch based on unnormalized input into the block

@daixiangzi hmm, have you tried it their way? conventionally we always work with pre-normalized values, so that would be weird they dispatch based on unnormalized input into the block

no ,I will try it.but I always have some doubts about the effectiveness of softmoe, mainly because I have been adjusting it for a long time

In terms of visual tasks, there are currently many open source versions of MOE, but in fact, there is not a sufficient experiment to demonstrate the effectiveness of this approach

@daixiangzi yea it happens
thanks for sharing your results
just to make sure we don't miss anything, would you like to also do a quick run where i substituted the rmsnorm with layernorm? (set https://github.com/lucidrains/soft-moe-pytorch/blob/main/soft_moe_pytorch/soft_moe.py#L287 to True)

Actually, before this, I tried my own version where the norm part used LN, but the effect was still not as good as the baseline

@daixiangzi ah ok, good to know
i'll take your experience as a datapoint

myself softmoe version:
        #x: [b,50,768]
        #phi [768, 128, slots]
        phi = self.phi
        phi = self.scale*self.normalize(phi,axis=0)
        #logits:[b, 50, 128, 1]

        logits = einsum(self.normalize(x,axis=-1), phi, "b m d, d n p -> b m n p")
        #add noise
        if self.training:
            normal = torch.randn(logits.shape, dtype=logits.dtype,device=logits.device)
            logits = logits +(1.0 * normal)
        #dispatch_weights:[b, token_num, 128, 1])
        dispatch_weights = logits.softmax(dim=1)  # denoted 'D' in the paper
        # NOTE: The 'torch.softmax' function does not support multiple values for the
        # 'dim' argument (unlike jax), so we are forced to flatten the last two dimensions.
        # Then, we rearrange the Tensor into its original shape.
        #对experts softmax:combine_weights:[b, token_num, 128, 1]
        combine_weights = rearrange(logits.flatten(start_dim=2).softmax(dim=-1),"b m (n p) -> b m n p",n=self.num_experts)

        # NOTE: To save memory, I don't rename the intermediate tensors Y, Ys, Xs.
        # Instead, I just overwrite the 'x' variable.  The names from the paper are
        # included in a comment for each line below.

        x = einsum(x, dispatch_weights, "b m d, b m n p -> b n p d")  # Xs
        #x:[b,128, 1, out_d]
        x = self.experts(x)  # Ys
        #combine_weights:[b, 50, 128, 1]
        x = einsum(x, combine_weights, "b n p d, b m n p -> b m d")  # Y
        #[b, 128, 1, 384]
        return x

in softmoe paper:
self.normalize should l2_norm, for example:
 def normalize(self,x:torch.Tensor,axis:int):
        return x*torch.rsqrt(torch.square(x).sum(dim=axis, keepdim=True) + 1e-6)

in softmoe paper: self.normalize should l2_norm, for example:
 def normalize(self,x:torch.Tensor,axis:int):
        return x*torch.rsqrt(torch.square(x).sum(dim=axis, keepdim=True) + 1e-6)

ohh i did it correct then the first time

ok

NotImplementedError: Could not run 'aten::amp_foreach_non_finite_check_and_unscale' with arguments from the 'CPU' backend. This could be because the operator doesn't exist for this backend, or was omitted during the selective/custom build proces

Hi, I met the same problem as you. Have you solved this problem?


[Windows] Add Ruby 3.1 to Windows 2019/2022

Description
Added Ruby 3.1 to Windows 2019/2022 versions.
Related issue:
https://github.com/actions/virtual-environments-internal/issues/3533
Check list

[x] Related issue / work item is attached
[x] Tests are written (if applicable)
[x] Documentation is updated (if applicable)
[ ] Changes are tested and related VM images are successfully generated

/azp run windows2019, windows2022


[tbd ???] update Android build tools Gradle classpath

update to com.android.tools.build:gradle:3.5.0
update comments
remove the useless safeExtGet call

as was originally proposed by @friederbluemle in pr #135
motivation: I would like to keep this change in a separate PR, to land in a separate commit, if possible

Status:

updated & rebased onto recent changes from pr #135;
at this point, I am reluctant to apply this change since it would increase the inconsistency between "stand-alone" build and build as part of a React Native 0.59 / 0.60 / 0.61-rc project

keeping in draft state for now


Content panel becomes unresponsive when pressing backspace with no content

Jodit Version:  3.2.10
This can be seen on the demo at:
https://xdsoft.net/jodit/play.html
repro:

Delete all content of the editor

Once there is no content, hit backspace or delete again

Expected behavior:
User can continue to use the control and add content.
Actual behavior:
Editor content panel becomes unresponsive until refresh.

Also running into this issue

Same problem here.
MacOs Safari 11.1.2, Chrome 68.0.3440.106


Solana bootcamp tasks

You are not supposed to be sending pull requests for the repository that everybody is using as a reference.
Instead, you need to create a fork of this repository, and publish all your changes in there.
Here is the GitHub documentation on how to fork a repository: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/fork-a-repo
It is also available in a few other languages, if you click on the globe icon on the upper right.


ISPN-13125 Upgrade Console to 0.14.3.Final

https://issues.redhat.com/browse/ISPN-13125

Merged, thanks


Issue with CSS autocomplete

When I type React code I get dropdown box under line with suggestions and when I select it it does what it should. But when things are suggested in CSS it is not the case. When I select suggestion with Left Mouse Button nothing happens. When I press enter it just sends me to new line. I tried other buttons but no luck. Is this an issue or there is something I am missing?

Hello,
First of all, thank you. I actually didn't think that someone would use Reacto as of today.
To be honest, I feel that this project was more of a proof of concept. I sadly don't have enough free time to work alone on such a huge project, while on the other hand big players are working daily on their projects.
I am sorry you ran into this issue and I think that I should point it out in the readme that Reacto might not be the best way to go.
Thanks again for giving it a try Micko, I really appreciate it.
Also, good luck in learning programming. I checked your profile and I hope that you will really enjoy making things with what you learn :)

Hi,
Thank you for getting back to me. I was looking for good IDE or Text Editor
to work with React and Front End in general. And I really love what you
made. I am using it now for React. It is simple, fast and beautiful. But to
be honest I was a bit sad when I saw that last commit was 11 months ago.
Anyway. Thanks again for reaching me out.
PS: I like your projects on git. Especially Reacto and the one where you
make portfolio out of git (can't remember the name :D)
Best regards,
Mileta
On Wed, May 1, 2019, 16:41 Arnaud Dellinger<EMAIL_ADDRESS>wrote:

Hello,
First of all, thank you. I actually didn't think that someone would use
Reacto as of today.
To be honest, I feel that this project was more of a proof of concept. I
sadly don't have enough free time to work alone on such a huge project,
while on the other hand big players are working daily on their projects.
I am sorry you ran into this issue and I think that I should point it out
in the readme that Reacto might not be the best way to go.
Thanks again for giving it a try Micko, I really appreciate it.
Also, good luck in learning programming. I checked your profile and I hope
that you will really enjoy making things with what you learn :)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/eveningkid/reacto/issues/91#issuecomment-488301024,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AETDASYW7SFMHDOZGQIFXITPTGTYLANCNFSM4HJSSC4A
.


Consolidate versions of playwright and @playwright/test

Problems

the versions of playwright and @playwright/test are defined in two locations, are different in each location, and must be manually maintained:

package.json
packages/nx-playwright/src/generators/init/generator.ts

the packages/nx-playwright/src/generators/init/generator.ts file mutates the consumer's package.json file when the generator is run

it seems a brittle approach to update the consumer's package.json file – it would be good to avoid this if possible
it would be easy to forget to update the playwright and @playwright/test versions when the root ones are updated
we should be able to resolve this issue by specifying those packages in the peerDependencies section of either package.json or packages/nx-playwright/package.json (to be determined)

Tasks

[ ] Investigate how best to solve the above issues
[ ] Implement solution

Reminder
Update private repos that are affected by these changes.

I have a branch for this here https://github.com/marksandspencer/nx-plugins/tree/consolidate-playwright-versions
Am waiting for https://github.com/marksandspencer/nx-plugins/pull/55 (which bumps the nx version) before creating a PR for this one.


[Windows][Powershell7] linking with link.exe failed: exit code: 1120

Building and linking in Windows has been a problem for a long time. (Un?)fortunately I don't have access to a Windows machine to try to figure out why.
Closing in favor of #77.

so basically your library can't be used in windows as of now right ? :( cause building is a requirement to make it work :(

Building works, linking apparently doesn't. I assume it's a matter of appropriately configuring Cargo via the /.cargo/config.toml file. If you're on Windows and can get it to work I'd be happy to merge a PR.

I am trying to build it, and I get the Link error, so can't really build anything, this is how my config.toml file looks
[target.x86_64-pc-windows-msvc]
rustflags = [
  "-C", "link-arg=-undefined",
  "-C", "link-arg=dynamic_lookup",
]

Looks like after adding a link to "lua51.lib" it is able to resolve the links for some functions, but still 105 (originally 133) of them are unresolved
Added the following to build.rs
fn main() {
  println!("cargo:rustc-link-search=E:\\forks\\luajit\\src");
  println!("cargo:rustc-link-lib=lua51");
}


[cluster-agent] When Number of External Metrics gets to 55, all become invalid.

We are using the cluster-agent on Kubernetes and we have a lot of HPAs which all read from datadog metrics to scale.  These work great when we had less than 55 HPAs, they are all valid and work well to scale our apps.
However, when we reached 55 External Metrics over the course of about 5 seconds all of them became invalid.  I was doing a watch agent status to try to see what was happening, and literally it went from
      Total: 50
      Valid: 45

to
      Total: 55
      Valid: 0

I don't want to cause our cluster any more downtime but that is the behavior is really weird and I couldn't find much related to it in logs (even with DD_LOG_LEVEL: trace).  Is this a known maximum?
If needed I could make it happen again and get logs etc, but I'd rather not do it.  Maybe you guys try a repro on your side with a cluster that has >55 HPAs?

Hey @george-miller, thanks for reaching out!
I have never tried with this many HPAs to be honest, I'm surprised that you are hitting an issue at 55 but we would need to further investigate.
Could you open a ticket with<EMAIL_ADDRESS>so we can gather as much info as possible to reproduce ?
Sorry for the headache!
Best,
.C

course, sounds good.  I will open a ticket.  Thanks!!

Hey George! Just to close the loop here from what Charly discovered in the support ticket, the high number of HPAs is relative to the high number of queries involved in the request from the cluster-agent to our API.
With the test that we ran, the cluster-agent makes a batch query, and receives an HTTP/1.1 200 OK status but the following error, contained in the body, is raised: "Query aborted; too many subqueries attempted". The client used by the agent doesn't raise the error due to the 200 status.
We have a rough limit of 50 HPAs or distinct queries, which we'll work on documenting and explore the possibility of raising a 400 when the query length is too large. On top of that, we have backlogged work to paginate the batch queries if possible so that there is virtually no more limit in the number of HPA used. Customers would just need to ask to raise the rate limit if necessary.
Lastly, we would like to add logic in the upstream client so that even if we receive a 200 and the body status contains an error, it is surfaced.

Hi All -- we have added improved error handling and logging via #4285 so that HPAs are not invalidated should a query fail for some reason. This change will be included in the upcoming 1.4.0 release of the cluster agent.
If you need additional assistance please open a ticket at<EMAIL_ADDRESS>Our support team can help raise any query limits as well as offer advice on configurations.
Best,
Yair


'brave base' command fails on Windows when exporting image

Describe the bug
brave base command fails on Windows on final step, when exporting image.
To Reproduce
Run brave base github.com/beringresearch/bravefiles/ubuntu/ubuntu-bionic-py3 on Windows.
After all dependencies are installed using apt, on the final step, the build will fail.
Expected behavior
Expected brave image to be built successfully.
Command line log
Publishing image ubuntu-bionic-py3
Exporting image ubuntu-bionic-py3
Failed to export image: remove ubuntu-bionic-py3-1.0.root: The process cannot access the file because it is being used by another process.
Environment (please complete the following information):

Your operating system name and version: Windows 10 Pro version 1903 (OS Build 18362.1082) 64-bit
Bravetools version: 1.53
LXD version: 4.4

This was merged in f172c8b and included in #16
If issue persists, do reopen.


add optional encoder data displays

Coverage increased (+1.6%) to 29.026% when pulling d5a888a0b137ff07b5883efb31d87d9931c0c8dc on gabrielburnworth:encoder_display into fda279d3298bfb9f450062c466bb381016981a08 on FarmBot:master.

Coverage increased (+2.0%) to 29.397% when pulling ef050075e1499fbcd64ade5e07f6b5c835b74e7f on gabrielburnworth:encoder_display into fda279d3298bfb9f450062c466bb381016981a08 on FarmBot:master.


No LICENSE

Please add a LICENSE file to your repo, so that we now what License you using. (Like MIT, GPL-2.0, ...)

Added. Thank you!


engine_test: replace os.MkdirTemp with t.TempDir

Fixes: #9594
Signed-off-by: Palash Nigam<EMAIL_ADDRESS>

not sure why windows tests are failing with OOM, let me know if that is because of my change. seems unrelated though.

I have rebased, let's see how Windows behaves.

testing.go:1206: TempDir RemoveAll cleanup: remove C:\Users\RUNNER~1\AppData\Local\Temp\TestQueryConcurrency3839867193\001\queries.active: The process cannot access the file because it is being used by another process.

Looking at this during the bug scrub.
Since there was no follow-up in a long time, we'll close this PR. However, we should still migrate to t.TempDir generally (and everywhere). Any help appreciated.


No Devices Connect

Hello,
I am not sure where else to ask, so I'm just opening an issue here.
Problem:
TL;DR upon following all instructions, no devices connect to my Windows 10 VM. I have tried with a USB kvm switch as well as a USB3.0 thumb drive with the same results.
Detail:
I am trying to switch a mouse and keyboard with a USB KVM switch. I realize this may be mildly more complicated than the intended purpose here, but since the switch is basically just a hub, I figured adding all the ports that show up in the monitor script should work.
Heck, even just a single device hot-plugging would be good, but I can't get that either.
It seems to be failing to remove the USB devices, but I imagine that maybe be because they never attach in the first place. Like I mentioned above, result is the same with just a single USB drive.
Windows sees the xhci controllers added by the command line, but has absolutely no reaction upon connecting or disconnecting USB devices from the ports I've added to the config. The QMP socket file shows up and the scripts don't seem to have any issues with it. I'm just confused since there doesn't seem to be any indication of any issues anywhere except for the disconnect failures. The devices in question always just end up connecting to the host.
OS:
I'm on Ubuntu 20.04 with KVM/QEMU 5.0.
Steps to reproduce:
Simply follow all instructions, and attempt to connect a USB device via hotplug.
Logs are attached. Thank you for your help!
udev.log
hotplugger.log
win10.xml.txt
config.yml.txt

Did you ever resolve this? I encountered the same error from your logs in the middle of many other errors so I am not sure exactly what fixed it but I now have no errors - although still no USB visible on Debian. More here: darkguy2008/hotplugger#4

I replaced call to info usbhost with pyusb/libusb1 device queries to get port number here: https://github.com/hansemro/hotplugger/commit/8f3443ad28a5852cf8c7269746efc813be0c7b60

I hate to bump a year-old thread, but this isn't working. I applied the diff from @hansemro and now my hotplugger.py doesn't generate any output at all. I'm still getting the "info usbhost" is not available error.


Add actual tutorial

I knew micro for ages, but had to spend some time to discover how to do basic things like working with multiple files.
I think these notes belongs to official tutorial to help others discover micro and save that time. I tried to cut the amount of text to read, because people skim, don't read, but I am not sure if it became better.

I think adding an example on how to edit a file using micro is great, but using micro codebase itself as an example requires a bit of effort. (Needs git and also need to clone it)
Not to mention you can't do much with the cloned codebase after the example unless you are a developer or contributing to the codebase.
I personally think editing either bindings.json or settings.json is relatively straightforward and practical as a tutorial example. Or even extending it to init.lua would be quite nice as well.
And one minor note is that I think using ctrl-s is more familiar then F2 for saving a file? Or maybe list both of them?

(Needs git and also need to clone it, not everyone is a developer)

I kind of agree with that, but let's also admit that we don't have the data. Maybe micro is a niche product only for developers and Linux savvy people, who know how to use wget or git clone to download stuff, or at least ask LLM about it. Everybody else is most likely using Notion or Google docs.

And one minor note is that I think using ctrl-s is more familiar then F2 for saving a file? Or maybe list both of them?

Pressing Ctrl-s in Bash is a recipe to disaster, so it is a bad habit to have this motor memory in Linux terminal. I don't know why it is not possible in Linux to fix it.

I personally think editing either bindings.json or settings.json is relatively straightforward and practical as a tutorial example. Or even extending it to init.lua would be quite nice as well.

Only vim need a need a tutorial to edit a single file. Other editors are quite intuitive with that. Tutorial should give some notable details about that specific editors, and common use cases. I found editing multiple files in vim and copy/pasting contents extremely hard to remember, so that's why I switched to micro few days ago.

Actually it might be a good idea to provide short tutorials for different experience levels. Maybe also linking them to external sites.
But the greater problem for beginners that the tutorial is hard to find. On the web site it is hidden in About section.

I personally think editing either bindings.json or settings.json is relatively straightforward and practical as a tutorial example. Or even extending it to init.lua would be quite nice as well.

Only vim need a need a tutorial to edit a single file. Other editors are quite intuitive with that. Tutorial should give some notable details about that specific editors, and common use cases. I found editing multiple files in vim and copy/pasting contents extremely hard to remember, so that's why I switched to micro few days ago.

I am not saying we can't have a tutorial that works with multiple files, we definitely can.
In fact it is a good tutorial as well since we can introduce users to split/tab relatively easily.
What I was saying is that the tutorial should be using something the user already has.
Using something the user needs to acquire just adds more effort to the tutorial and makes the user less likely to do it.
Maybe we can copy and paste some of the keybindings or options from the help page to the user's keybindings / settings as an example of working with multiple files.
How does that sound? @techtonik

@techtonik
No, I meant copying things from the help page to the user's settings.json or bindings.json as an example.
For example, we can say something like we want to set the brace highlighting style from underline to highlight when our cursor is on it but we don't remember what the exact name is, and we have no internet so we can't search it on micro's page.
So we open up our settings.json, then the options help page with ctrl-e, then type help options.  Which is just a read-only buffer.
Find brace using ctrl-f and go to the next occurrences until we find matchbracestyle, copy it and the option highlight to settings.json on another split that we opened previously, ctrl-v to paste it to the place you like.
This is just an example on what we can do a tutorial on obviously.


screenOrientationAngle is not reliable

Hi there,
First thank you, you're doing great!
I'm trying to create a controller on mobile for a desktop based experience.
My objective is basically to deduce directions from accelerometer values so if we're tilting the phone left, right, front or back we can move accordingly on the desktop.
Most of the time, it works well. But sometimes, my devices returns miscalibrated values.
It's actually related to screenOrientationAngle returning 0. If I trigger manually an orientation change by moving the device to portrait and move back to landscape, the value gets fixed (something like 90 or 270 is now returned) and the adjustment is right.
I know that those values are based on natives window.screen.orientation or window.screen.orientation.angle and that it's not directly related to Fulltilt.
Do you have an idea of how I could fix it?
I hope I was clear enough!

I think I've found the problem here. screenOrientationAngle is set when the library is loaded, but the handleScreenOrientationChange event isn't hooked up until an instance of DeviceOrientation is created.
So, if the orientation has changed between page load and new DeviceOrientation it isn't correct.


Support Auto Save

Support to auto save on request will save lot of my time
I thing put a new preference in general tab could be good ideia!

This would be great together with disabling the tab bar, see #1739.
Insomnia does auto-save and doesn't have tabs, and to me, the resulting way of working is vastly superior to the one in Postman/Bruno.
Also, let's not forget that developers probably store their .bru files in a Git repo anyway, so there's not much harm in saving automatically. On the plus side, it frees you of the burden of managing what you still need to save, or pressing Ctrl-S all the time. That's the reason why JetBrains' IDE products (IntelliJ IDEA, WebCharm...) also have auto-save.
If Bruno offered an option for this, I would enable it and finally be happy (again) to have a REST client that works for me, not against me!

Duplicate of #142


refactor: cleanup opts structure

Breaking: opts.opts.FOO is now accessed directly with opts.FOO instead
This was mainly used with some options, such as noautocmd and margin
-- old
dashboard.opts.opts.margin = 5

-- new
dashboard.opts.margin = 5

-- old
startify.opts.opts.redraw_on_resize = false

-- new
startify.opts.redraw_on_resize = false

The main benefits of this change is clarity and shorter/simpler parsing.

i'm a bit conflicted, it's a silly name (i am hilariously bad at naming things lol) but the opts.opts table is meant to indicate that those options are opt ional :)
i think that makes it easier to copy+paste code around without reading docs
perhaps it would be more apt to rename the upper opts config or something?

but the opts.opts table is meant to indicate that those options are opt ional :)

I get what you mean but they're already part of opts

imo that makes it easier to copy+paste code around without reading docs

It still is in this case, I don't see how that is changing that part.

perhaps it would be more apt to rename the parent opts table config or something?

The better approach from a refactoring pov, would be to rename the entire opts table, which is an unfortunate name since it's not really optional. but now we'd be really introducing a breaking change for everyone, so I'm thinking you mean dashboard.opts.config instead of dashboard.opts.opts. In that case, I thought about calling it global_opts instead.

i was thinking dashboard.config.opts

i was thinking dashboard.config.opts

Yeah, but that's the bigger breaking change that I was talking about, it would require a deprecation notice and I'm not exactly sure how to handle it on the fly instead of just bailing out and telling the user to use the new syntax.
To be clear, I'm in favor of your suggestion.

well, we could export opts = config, which would avoid any damage to the end user i think. then a migration plan would look like

replace mentions of opts with config in the docs
emit a deprecation warning when opts is used
after X time has passed, remove opts with a breaking! commit so packer users are notified


Add support for mouse wheel scrolling

Thanks to @djclueless for doing the heavy lifting in #301

Not sure where its broken, but clicking without moving isn't working. Only click and drag works.

Oh, nice catch. Checking...

@djclueless - Okay, should be fixed in #308


Databound TreeviewItem does not respond to changes when inside Mahapps window. (Sample Project attached)

Hello,
i have a TreeView control which has TreeviewItems bound to a viewmodel. In a standard Window the tree reflects changes to IsVisible, IsExpanded and IsSelected properties. But this does not work as soon as tree is in a mahapps window.

I created a solution that directly shows the problem, so that you can quickly see what this issue is about.
http://portalvhdstlvf6zph5075c.blob.core.windows.net/exchange/TreeViewWpfApplication.7z

@pothmann there are 2 points in this issue:

MahApps should not set the MetroTreeViewItem style as the ItemContainerStyle, this is fixed with 6cc298ba49d3b39a95769d6ca3b9d5ba3c4386ec
you should inherit the TreeViewItem style

        <Style TargetType="{x:Type TreeViewItem}" BasedOn="{StaticResource {x:Type TreeViewItem}}">
            <Setter Property="Visibility"
                    Value="{Binding IsVisible, Converter={StaticResource BooleanToVisibilityConverter}}" />
            <Setter Property="IsExpanded"
                    Value="{Binding IsExpanded}" />
            <Setter Property="IsSelected"
                    Value="{Binding IsSelected}" />

        </Style>


Change Log Detection in Harvest

[x] Implementation
[x] Documentation
[ ] Create Sample Alerts
[x] Add dashboard

Tested in release branch 23.11 with commit 815fca8e0af0c0d70307d28b5a72451071c4ad79

Changed svm state from running to stopped. reporting from zapi and rest both.

Changed node location from GDL to SVL. reporting from zapi and rest both.

Changed volume state from to restricted. reporting from zapi only, rest is not giving change_log metric.

Working on it.

Tested with this PR https://github.com/NetApp/harvest/pull/2478 changes,
3. Changed volume state from to restricted. reporting from zapi and rest both.

Tested on release branch 23.11 with commit a6f049fc6e5e8924717232bd4a8b83e2400d95ba


howdy reaching out

https://gov.near.org/t/rentable-nfts-draft/31977 wanted to discuss creating a rentable nft standard

Hi @codingshot, thank you for reaching out.
We are indeed interested to the NFT rental standard in NEAR.
However, we have a slightly different vision. For the draft you shared, our main concern is that the approach proposed requires the rental feature build-in within the NFT contract. Using a real life analogy, it's like when Ford build a new car, they need to decide how it can be rented, and no one can change it afterwards.
Given that, at NiFTyRent, we are using a different approach, so that the logic of NFT basic functionality and rental can be decoupled. And therefore it can be more future-proof.
Let me know what do you think. Happy to discuss further 😊


Master ticket: Version 1.0 release

Tasks to hit out before the next release. Timeline: end of January.

UI milestone.
Server-side authentication and user permissions. -- #159
Design improvements to the UI and map style, cc: @rasagy.
Documentation refresh.

Please let me know if there's anything else we should add.
cc: @aaronlidman @Rub21 @geohacker @batpad @rasagy

Update:

Server-side auth is done. Next: add a admin page to manage user permissions.
Stats-related fixes. PR #186.

Small set of todo items from a short walkthrough of the To-fix UI:

Type
Description
Status

Styling
Descriptions: Wrap the truncating comments & descriptions

Styling
Descriptions: Copy comments button

Styling
Descriptions: Make v button more clickable

Styling
Descriptions: Make panel responsive

Styling
Descriptions: Disable user select/highlight on rest of text

Styling
Preview button should change pointer on hover

Styling
Map design: Improve feature layer colors

Styling
Top tabs & Login button: spacing & float issues

Styling
Tooltip for task names that are truncated

Styling
Tooltip for location in Preview section

Styling
Profile popup: styling + better hover states

Styling
Edit & action bar breaks on resizing

Styling
Statistics table style

Copy
Activity: Change text to Edit_ed_, Skip_ped_, Fix_ed_, Not an error

Copy
Activity: Update message for all activity loaded

Copy
Relook at all error messages

Bug
GL JS update breaks map at small widths (can’t fitbounds() )

Feature Request
UI: Layer selector (Mapbox Satellite, Streets)

Feature Request
Edit icons on tasks that the user can edit, disable which you can’t

Feature Request
Default photo for user + take care of portrait photos

Feature Request
Errors when 503 (or any server side error happens)

Feature Request
Can we cancel loading and align loading indicator to center of the map

@ajithranka & I will tag team to hit as many of these as possible, will open ticket for those issues that need more discussions.
cc @geohacker @batpad @planemad

Closing. Let's revisit individual feature requests separately.


neon build --target

We need an RFC for cross-compilation flags. The design should try to mirror the UX of Cargo as much as possible.

Has there been any progress made on cross-compilation or a manual workaround?  Currently looking to build for iOS and Android toolchains.

The rust side of this is actually pretty easy and works today. Since neon-cli passes on environment variables, cargo will respect the TARGET variable.
Unfortunately, the complexity of cross compiling node-gyp is where this becomes problematic (required by neon-runtime). Due to that complexity, I believe that this is blocked by N-API support which will eliminate node-gyp.
There is no timeline for N-API.
https://github.com/neon-bindings/neon/issues/202
https://github.com/neon-bindings/neon/pull/440

http://www.janeasystems.com/blog/support-native-modules-node-js-mobile-apps/ They have a modified node-gyp

Hello,
What is the current status of this feature?
Does it exist any workaround as of today, and if not, is there anything we can do to help?

@ShinySaana It's not being worked on. The legacy backend requires node-gyp which does not easily handle cross compiling.
The good news is that the N-API backend does support cross compiling and only uses cargo to build.
Try npm init neon my-project to create a new N-API project.

As my neon project already used N-API, it was a breeze to migrate to the new backend. I just tested it and it worked wonders. Thank you very much for saving me a lot of headaches !

I'm a little confused between the information on the wiki and here.  If I create a project today with npm init neon my-project, can I compile for windows, mac, etc. in linux and how?

@JRedOW Additional arguments to cargo can be passed after the npm command. npm run build -- --target ....
Cross compiling documentation for Rust applies equally to Neon. (At the end it's just a Rust shared library)

@JRedOW Additional arguments to cargo can be passed after the npm command. npm run build -- --target ....
Cross compiling documentation for Rust applies equally to Neon. (At the end it's just a Rust shared library)

Thanks!  Should this issue be closed then?

@JRedOW if you're looking for an example of cross compilation from macs of a neon project you can check out the Temporal Node.js SDK:
https://github.com/temporalio/sdk-node/blob/main/docs/building.md
https://github.com/temporalio/sdk-node/blob/main/.github/workflows/ci.yml#L73


Add size info while resizing

This builds on the recent feature from #347 adding information about image size while resizing. As soon as one activates one of the resize handles a small and fairly unobtrusive info overlay in the bottom right corner displays the width and height of the image. The size info is kept up-to-date as one resizes, and goes away as soon as the resize handler is deactivated (eg. mouse released).
By default the size info overlay has to be enabled through the resizeControls.sizeInfo option.

First, sorry it's taken me so long to response.
But rather than going this direction with it, I think it'd be better to add a resizeViewport event.  I can do it if I find the time.  Thanks again for the useful features!


umbraco/backoffice/relationseditor/relations/isallowedentity 404 on add relation from search

When trying to add a relation from search, this error is thrown. It looks like the treeAlias property is undefined.

There is also a console error Cannot get a descendant node from a section container node without a treeAlias specified. Is there a fix for this issue?

Umbraco version is 7.9.2 and RelationEditor package version is 1.2.3
It was installed from Nuget.
I have found, just testing locally, that setting treeAlias to $scope.resourceSets[index].ChildType.Section as opposed to $scope.resourceSets[index].ChildType.TreeType (Ln 78) or entity.metaData.treeAlias (Ln 58) in $scope.pickRelation in the relationeditor.js file, that appears to fix it.
Although I'm unsure if that is the correct way to go about fixing it, I am unsure about where treeAlias is supposed to be set. I can say it appears to work.

@lars-erik I might attempt a fix and submit a PR, if you are happy enough with that. I would need to know if my assumption on the treeAlias value matching the section is correct. I have found it to work in my testing, if that helps.

I had the same problem (Umbraco 7.10.4 and also 7.11.1), solved by changin line 58 in relationeditor.js from:
                   entity.metaData.treeAlias,
to:
                   entity.metaData.treeAlias || $scope.resourceSets[index].ChildType.TreeType || $scope.resourceSets[index].ChildType.Section,
but I guess it is more a hack than a solution.
Seems that the treePicker() dialog passes the searchSelected() callback an entity with a null metaData.treeAlias, don't know why.


Release files of <IP_ADDRESS> version are empty

I think there was an error when generating the latest relase! The files are < 1KB and dont have any content.

You mean this: juicy-gcode-<IP_ADDRESS>-win64.zip? Looks like I made a mistake, the other files are good

Looks like I don't know how the zip command works on mac :) fixed


Some thoughts on the concept of a 'framework'

I am a dev with 20 years experience, mainly in the middle tier and db.  My front end skills aren't that great, which is why I turn to solutions like AdminLTE :-)
I'd like to see Admin LTE 3.0 have the ability to honor a plain vanilla bootstrap site, and give the developer the ability to extend what bootstrap provides by providing some cool components that work seamlessly with your chosen flavor of bootstrap skin.
See for example http://bootswatch.com   I can do a bootstrap website, use one of their free themes and change the whole theme of my site (e.g. for a client) simply by downloading a new css file and linking to that - I can be confident nothing breaks as the themes are 'plug and play'
I'd like to see AdminLTE take a similar route, offering the ability to honor a given bootstrap 'look and feel' but able to offer some extended functionality e.g. calendars, sliders, example forms etc etc
I'd be more than happy to expand on what I mean if you think this concept would fit with your development plans
Cheers
Chris Lennon

Hello @xo-chris ,
This is actually the goal of AdminLTE v3. We are trying our best to make all Bootstrap components and plugins integrate seemlessly without direct changes to AdminLTE. So far, we are honoring all variables that Bootstrap provides. Therefore, bootswatch themes should work with AdminLTE without problems if you use SASS files.
However, v3 is going to take some time to be production ready and that depends greatly on when Bootstrap 4 gets officially released.
Thanks for the suggestions!


XSetInputFocus on non-mapped windows can trigger a crash

There are cases where the host gives us a window that is not yet mapped.
Or sometimes on standalones our own window is not mapped yet, likely result of a puglShow directly followed by a puglGrabFocus
Trying to give input focus here results in a crash.
I already had some code in Carla that deals with this (needed by a few plugins, for many reasons I cant explain).
So plugging this in for DPF made the crashes go away, I did not investigate the matter further.
Relevant code in question:
XWindowAttributes wa;
memset(&wa, 0, sizeof(wa));

if (XGetWindowAttributes(impl->display, impl->win, &wa) && wa.map_state == IsViewable) {
// safe to give focus
}

Fixed in 17fa2a0d


Zqs 1134/backend api rework

Description
Include description of feature this PR introduces or a bug that it fixes. Include the following information:

Context: why is it needed? In case of bug, what was the cause for the bug?
Concise description of the implemented solution.
If any dependencies are added, list them and justify why they are needed.

Please verify that you have completed the following steps

[ ] I have self-reviewed my code.
[ ] I have included test cases validating introduced feature/fix.
[ ] I have updated documentation.

Codecov Report
Base: 94.10% // Head: 94.78% // Increases project coverage by +0.67% :tada:

Coverage data is based on head (5a7f1f2) compared to base (559fa04).
Patch coverage: 87.15% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #66      +/-   ##
==========================================
+ Coverage   94.10%   94.78%   +0.67%
==========================================
  Files          46       48       +2
  Lines        3039     3012      -27
==========================================
- Hits         2860     2855       -5
+ Misses        179      157      -22

Impacted Files
Coverage Δ

...rc/orquestra/quantum/operators/_pauli_operators.py
96.37% <60.00%> (-0.68%)
:arrow_down:

src/orquestra/quantum/api/circuit_runner.py
81.13% <81.13%> (ø)

src/orquestra/quantum/testing/mocks.py
90.00% <83.33%> (+6.66%)
:arrow_up:

...rc/orquestra/quantum/api/wavefunction_simulator.py
83.92% <83.92%> (ø)

.../orquestra/quantum/api/circuit_runner_contracts.py
85.00% <85.00%> (ø)

...ra/quantum/api/wavefunction_simulator_contracts.py
86.84% <86.84%> (ø)

src/orquestra/quantum/api/estimation.py
94.73% <100.00%> (ø)

src/orquestra/quantum/api/estimator_contract.py
100.00% <100.00%> (ø)

src/orquestra/quantum/circuits/_itertools.py
100.00% <100.00%> (ø)

src/orquestra/quantum/estimation/_estimation.py
100.00% <100.00%> (ø)

... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


When not using TabBar in AppBar rendering fails: The following NoSuchMethodError was thrown during performLayout(): The method 'toStringAsFixed' was called on null

It seems that the TabBar needs to have space reserved for it on the render tree, if you're not putting it on the bottom of an AppBar. Couldn't find that anywhere in docs. If I just see didn't it, then I apologize.  I don't know if this is a bug, but I couldn't find the answer in the documentation and it was difficult to solve. Putting it here for posterity and maybe it needs better documentation or error handling.
════════ Exception caught by rendering library ═════════════════════════════════════════════════════
The following NoSuchMethodError was thrown during performLayout():
The method 'toStringAsFixed' was called on null.
Receiver: null
Tried calling: toStringAsFixed(1)

#0      Object.noSuchMethod (dart:core-patch/object_patch.dart:51:5)
#1      ViewportOffset.debugFillDescription (package:flutter/src/rendering/viewport_offset.dart:248:39)
#2      ScrollPosition.debugFillDescription (package:flutter/src/widgets/scroll_position.dart:896:11)
#3      ScrollPositionWithSingleContext.debugFillDescription (package:flutter/src/widgets/scroll_position_with_single_context.dart:261:11)
#4      ViewportOffset.toString (package:flutter/src/rendering/viewport_offset.dart:233:5)

Steps to Reproduce
Place a TabBar outside of App Bar in any fashion, I've placed it in a column row below.

class _ReferralsNestedTabViewState extends State<ReferralsNestedTabView>
    with TickerProviderStateMixin {
  TabController _nestedTabController;
  int _index;

  @override
  void initState() {
    super.initState();
    _nestedTabController = TabController(
      length: 2,
      vsync: this,
    );
  }

  @override
  Widget build(BuildContext context) {
    return Column(
      children: [
        TabBar(
          onTap: (index) {
            _nestedTabController.index = index;
          },
          controller: _nestedTabController,
          indicatorColor: Colors.blue,
          labelColor: Colors.blue,
          unselectedLabelColor: Colors.black54,
          isScrollable: true,
          tabs: [
            Tab(text: 'Tab 1'),
            Tab(text: 'Tab 2'),
          ],
        ),
        Container(
//          height: MediaQuery.of(context).size.height * .70,       //<---- adding size to other row in 2 row column solves the render issue
          child: TabBarView(controller: _nestedTabController, children: [
            ReferralListView(),
            GuestListView(),
          ]),
        ),
      ],
    );
  }
}

Expected results:
A TaBar displayed in column row
Actual results:
No TabBar, but the problem was solved by defining the height of the container taking its space creating a void for it to render in.

@joeyda3rd
Please check this issue and corresponding solution on how to use tabbar without appbar.
Hope it helps.

This technically does work, but doesn't solve the problem of removing the TabBar from the AppBar, if it's required there, then that's acceptable, just needs documented. There is currently no way to remove tabbar from appbar without requiring a manually sized void from other widgets rendered in the space it would normally occupy if it would reserve it's own space.
Title of this issue should read "When not using TabBar in AppBar rendering fails: The following NoSuchMethodError was thrown during performLayout(): The method 'toStringAsFixed' was called on null"

@darshankawar @joeyda3rd  I have similar problem I want to show tab bar in middle of page without appbar my TabBarView crashed with
The following NoSuchMethodError was thrown during performLayout():
The method 'toStringAsFixed' was called on null.
Receiver: null
Tried calling: toStringAsFixed(1)

Why the following code not works?
import 'package:flutter/material.dart';

void main() {
  runApp(TabBarDemo());
}

class TabBarDemo extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      home: DefaultTabController(
        length: 3,
        child: Scaffold(
          body: Column(
            children: [
              TabBar(
                tabs: [
                  Tab(icon: Icon(Icons.directions_car)),
                  Tab(icon: Icon(Icons.directions_transit)),
                  Tab(icon: Icon(Icons.directions_bike)),
                ],
              ),
              TabBarView(
                children: [
                  Icon(Icons.directions_car),
                  Icon(Icons.directions_transit),
                  Icon(Icons.directions_bike),
                ],
              ),
            ],
          ),
        ),
      ),
    );
  }
}

This is the problem. I can't get any code to work without declaring a size for the widget under the tabbar that will leave space for the tab bar to fill.
Try this package a friend of mine made, it's new and still needs some work, but it may solve the problem for you.
https://pub.dev/packages/contained_tab_bar_view

Wrap your TabBarView in the Expanded widget.  This resolves my issue.

@kurzekar-rohit in my use case it doesn't apply because I'm on a list of slivers.
flutter: ══╡ EXCEPTION CAUGHT BY WIDGETS LIBRARY ╞═══════════════════════════════════════════════════════════
flutter: The following assertion was thrown while applying parent data.:
flutter: Incorrect use of ParentDataWidget.
flutter: The ParentDataWidget Expanded(flex: 1) wants to apply ParentData of type FlexParentData to a
flutter: RenderObject, which has been set up to accept ParentData of incompatible type
flutter: SliverPhysicalParentData.
flutter: Usually, this means that the Expanded widget has the wrong ancestor RenderObjectWidget. Typically,
flutter: Expanded widgets are placed directly inside Flex widgets.
flutter: The offending Expanded is currently placed inside a SliverToBoxAdapter widget.
flutter: The ownership chain for the RenderObject that received the incompatible parent data was:
flutter:   _ScrollSemantics-[GlobalKey#3b293] ← Scrollable ← NotificationListener<ScrollNotification> ←
flutter: PageView ← NotificationListener<ScrollNotification> ← TabBarView ← Expanded ← Container ←
flutter: SliverToBoxAdapter ← Viewport ← ⋯

@kurzekar-rohit update in my use-case it works if I wrap it into a SliverFillRemaining yay!.

Wrap your TabBarView in the Expanded widget. This resolves my issue.

Thank you, been searching all over for how to implement a TabBar outside an AppBar, and kept playing a whack-a-mole with issues, fix one, another pops up, until I finally solved it.

Wrap your TabBarView in the Expanded widget. This resolves my issue.

Thank you, been searching all over for how to implement a TabBar outside an AppBar, and kept playing a whack-a-mole with issues, fix one, another pops up, until I finally solved it.

@sm2017 Just wrap your TabBarView with an Expanded widget. It's tested to work.
void main() {
  runApp(TabBarDemo());
}

class TabBarDemo extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      home: DefaultTabController(
        length: 3,
        child: Scaffold(
          body: Column(
            children: [
              TabBar(
                tabs: [
                  Tab(icon: Icon(Icons.directions_car)),
                  Tab(icon: Icon(Icons.directions_transit)),
                  Tab(icon: Icon(Icons.directions_bike)),
                ],
              ),
              Expanded(
                child: TabBarView(
                  children: [
                    Icon(Icons.directions_car),
                    Icon(Icons.directions_transit),
                    Icon(Icons.directions_bike),
                  ],
                ),
              ),
            ],
          ),
        ),
      ),
    );
  }
}

@sm2017 Just wrap your TabBarView with an Expanded widget. It's tested to work.
void main() {
  runApp(TabBarDemo());
}

class TabBarDemo extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      home: DefaultTabController(
        length: 3,
        child: Scaffold(
          body: Column(
            children: [
              TabBar(
                tabs: [
                  Tab(icon: Icon(Icons.directions_car)),
                  Tab(icon: Icon(Icons.directions_transit)),
                  Tab(icon: Icon(Icons.directions_bike)),
                ],
              ),
              Expanded(
                child: TabBarView(
                  children: [
                    Icon(Icons.directions_car),
                    Icon(Icons.directions_transit),
                    Icon(Icons.directions_bike),
                  ],
                ),
              ),
            ],
          ),
        ),
      ),
    );
  }
}

@joeyda3rd I had the same issue but with AppBarView. The following is an excerpt from my code where I have the TabBar somewhere in the body.
The key is to wrap your Column and TabBarView in Expanded so that it resolves the height of the parent Flex (which I am guessing is another Column)
DefaultTabController(
              length: 2,
              child: Expanded(
                child: Column(
                  mainAxisSize: MainAxisSize.max,
                  children: <Widget>[
                    Container(
                      child: TabBar(
                        tabs: [
                          Tab(text: "Home"),
                          Tab(text: "Articles"),
                        ],
                      ),
                    ),
                    Expanded(
                      child: Container(
                        constraints: BoxConstraints.expand(),
                        child: TabBarView(children: [
                          Center(
                            child: Text(
                              "Home Body",
                              style: TextStyle(color: Colors.white),
                            ),
                          ),
                          Center(
                            child: Text(
                              "Articles Body",
                              style: TextStyle(color: Colors.white),
                            ),
                          ),
                        ]),
                      ),
                    ),
                  ],
                ),
              ),
            )```

@joeyda3rd I had the same issue but with AppBarView. The following is an excerpt from my code where I have the TabBar somewhere in the body.
The key is to wrap your Column and TabBarView in Expanded so that it resolves the height of the parent Flex (which I am guessing is another Column)
DefaultTabController(
              length: 2,
              child: Expanded(
                child: Column(
                  mainAxisSize: MainAxisSize.max,
                  children: <Widget>[
                    Container(
                      child: TabBar(
                        tabs: [
                          Tab(text: "Home"),
                          Tab(text: "Articles"),
                        ],
                      ),
                    ),
                    Expanded(
                      child: Container(
                        constraints: BoxConstraints.expand(),
                        child: TabBarView(children: [
                          Center(
                            child: Text(
                              "Home Body",
                              style: TextStyle(color: Colors.white),
                            ),
                          ),
                          Center(
                            child: Text(
                              "Articles Body",
                              style: TextStyle(color: Colors.white),
                            ),
                          ),
                        ]),
                      ),
                    ),
                  ],
                ),
              ),
            )```

@kurzekar-rohit update in my use-case it works if I wrap it into a SliverFillRemaining yay!.

Omg thank you so much, this also works in CustomScrollView for example

@kurzekar-rohit update in my use-case it works if I wrap it into a SliverFillRemaining yay!.

Omg thank you so much, this also works in CustomScrollView for example

nvm, now the TabBarView doesn't have an unlimited height. Does anyone know how to give a TabBarView inside of a CustomScrollView enough height for the children?

nvm, now the TabBarView doesn't have an unlimited height. Does anyone know how to give a TabBarView inside of a CustomScrollView enough height for the children?

@pumuckelo I don't know what you're trying to compose, but I have an example for you:
https://gist.github.com/normancarcamo/031191ccd2eb2f4c2878c588db506e76

@pumuckelo I don't know what you're trying to compose, but I have an example for you:
https://gist.github.com/normancarcamo/031191ccd2eb2f4c2878c588db506e76

Thank you for the quick response!
What I am trying to do is to render a TabBarView and the TabBar inside of a CustomScrollView.
I'll a code example tomorrow, I'm on my phone rn.

Thank you for the quick response!
What I am trying to do is to render a TabBarView and the TabBar inside of a CustomScrollView.
I'll a code example tomorrow, I'm on my phone rn.

@pumuckelo I think the example I did does what you are looking for, if not :) good luck.

@pumuckelo I think the example I did does what you are looking for, if not :) good luck.

@normancarcamo in the example, you have a CustomScrollView inside of a TabBarView. What I am trying to achieve is the opposite, to have TabBarView inside of a CustomScrollView.
Your info to use SliverFillRemaining helped me to fix the "toStringAsFixed" error but now I got the problem that the tabbarview inside of the customscrollview only gets the size of the screen as height so it overflows on the bottom if the content is larger

@normancarcamo in the example, you have a CustomScrollView inside of a TabBarView. What I am trying to achieve is the opposite, to have TabBarView inside of a CustomScrollView.
Your info to use SliverFillRemaining helped me to fix the "toStringAsFixed" error but now I got the problem that the tabbarview inside of the customscrollview only gets the size of the screen as height so it overflows on the bottom if the content is larger

@pumuckelo I understand you, good luck bro!.

@pumuckelo I understand you, good luck bro!.

@saadamin94 is correct, wrapping in expanded widget resolves the height of the parent.


New version: Mozilla.Firefox.DeveloperEdition.ff version 132.0 (132.0b4)

Created by 🥟 Dumplings.
Microsoft Reviewers: Open in CodeFlow

Verify by proxy: https://github.com/microsoft/winget-pkgs/pull/179431#issuecomment-2400690391


Not support high dpi

@hlwhl Thank you for your support on the previous issue!
Does it not support high dpi?
and running into some performance issues
Is it because I am using debug mode?
If it's just a simple display of youtube, it will also lag

#9 fixed


create variable

many terraform module support create or create_xx variables to controls whether resource should be created. I think, one of the reasons for doing this is, it's hard to use count or for_each in module block.
terraform-aws-next-js also has create_domain_name_records  and create_image_optimization. But no option to skip for other resources.
Do you have any plans to add a create variable that controls the creation of the entire resource? Or can I create a PR?

Do you have a specific resource in mind?
My philosophy here is to support optional resources when they are not necessary or can be replaced with self-written constructs.
The next optional resource to add will be the main CloudFront distribution, which is targeted in #55.
IMHO I currently don't see other resources where this would make sense, but I am open for suggestions 🙂

@ofhouse In many use cases, one Terraform code covers multiple environments. For example, in the code below, I would like to decide to create the next-tf module according to the environment.
module "next-tf" {
  source = "dealmore/next-js/aws"
  create = terraform.workspace == "prod"
  // or
  // create = var.env == "prod"

  next_tf_dir     = var.next_tf_dir
  deployment_name = var.deployment_name
}

This pattern can be used in many modules, including the following two modules used by this module:

https://github.com/terraform-aws-modules/terraform-aws-apigateway-v2
https://github.com/terraform-aws-modules/terraform-aws-lambda

My philosophy here is to support optional resources when they are not necessary or can be replaced with self-written constructs.

This can also be achieved by just using var.create && var.create_xxx.
resouce "cloudfront_distribution" "this" {
  count = var.create && var.cloudfront_distribution ? 1 : 0
}

Ah, thanks for clarification.
I think the create variables there were originally added for versions of below Terraform 0.13 since it was not possible to use count or for_each on modules.
Terraform 0.13 (which is already the minimal required version for this module) and up support count on modules which I would prefer here since it is an official Terraform feature and no workaround like a create variable would be.
However, using count on this module currently does not work because we use an internal AWS provider to ensure that some resources are created in us-east-1 region.
The plan is to drop this internal provider in the next version which should lift the limitation on using count.

You're right. Using count in module block, prevents the use of provider inside the module, I think the create variable is still useful in many cases.

Would like to reevaluate this after #50 is implemented.
Introducing a create variable would require a lot of changes and it must also be ensured that the submodules support it.
For this reason I would appreciate it when this could be handled in userland with a simple count on the module itself.

I'm going to close this issue because it has been inactive for 30 days ⏳. This helps to find and focus on the active issues.


Update markup for combobox/popover/pill-container

Fixes https://github.com/salesforce/design-system-react/issues/2570
Additional description

CONTRIBUTOR checklist (do not remove)
Please complete for every pull request

[ ] First-time contributors should sign the Contributor License Agreement.  If you haven't before, wait a few minutes and a bot will comment on this pull request with instructions.
[x] npm run lint:fix has been run and linting passes.
[x] Mocha, Jest (Storyshots), and components/component-docs.json CI tests pass (npm test).
[ ] Tests have been added for new props to prevent regressions in the future. See readme.
[x] Review the appropriate Storybook stories. Open http://localhost:9001/.
[ ] Review tests are passing in the browser. Open http://localhost:8001/.
[x] Review markup conforms to SLDS by looking at DOM snapshot strings.

REVIEWER checklist (do not remove)

[ ] TravisCI tests pass. This includes linting, Mocha, Jest, Storyshots, and components/component-docs.json tests.
[ ] Tests have been added for new props to prevent regressions in the future. See readme.
[ ] Review the appropriate Storybook stories. Open http://localhost:9001/.
[ ] The Accessibility panel of each Storybook story has 0 violations (aXe). Open http://localhost:9001/.
[ ] Review tests are passing in the browser. Open http://localhost:8001/.
[ ] Review markup conforms to SLDS by looking at DOM snapshot strings.

Required only if there are markup / UX changes

[ ] Add year-first date and commit SHA to last-slds-markup-review in package.json and push.
[ ] Request a review of the deployed Heroku app by the Salesforce UX Accessibility Team.
[ ] Add year-first review date, and commit SHA, last-accessibility-review, to package.json and push.
[ ] While the contributor's branch is checked out, run npm run local-update within locally cloned site repo to confirm the site will function correctly at the next release.

It seems that Combobox needs more updates that may have more impact, logged follow-up issue https://github.com/salesforce/design-system-react/issues/2586

@Azmarie I made some updates to the Combobox markup changes.  Can you take a look and if everything is ok, I think we're good to merge.  Thanks!

Yes, looks good! Thanks for finishing it off, @garygong  🎉

Sure thing!


import image to table

Thank you for your great library.
I'm working on a project and there i need to have an image(qrcode image) in a table.
How to add to the image to the first row of the table.
thanks in advance for you help

Hi @DominikKaiser74, thank you for using the library!
You can do what you need with the following code
from pdfme import build_pdf

build_pdf({
    "sections": {
        "content": [
        # in this list you place the contents of the document, in your case there's only one element, a table, that contains the image
            {
                "table": [
                # this list holds the rows of the table, in your case there's only one row
                    [
                    # this list holds the cells of the current row, in your case there's only one cell, that contains the image
                        {
                        # this dictionary has only one key named image, and its value is a string with the path of the  #image
                            "image": "path/to/the/qr_image.jpg"
                        }
                    ]
                ]
            }
        ]
    }
})

Give it a try and let me know if you have any questions


Fix conflict bootstrap-datepicker & jquery-ui

Fix to avoid conflict between bootstrap-datepicker & jquery-ui libraries.
When a field type "date_picker" is created before a field type "table", there's a conflict between the libraries.
For this reason, the datepicker is shown without styles.

        $this->crud->addField([
            'label' => 'Service date',
            'type' => 'date_picker',
            'name' => 'service_date',
        ]);

        $this->crud->addField([
            'name' => 'services',
            'label' => 'Services',
            'type' => 'table',
            'entity_singular' => 'service',
            'columns' => [
                'name' => 'Detail',
            ],
            'min' => 0
        ]);

Hi @dgtal ,
Wow, didn't know that conflict was there. Thanks a lot for the PR! Just merged it, it'll be available for everyone in the next point update (today).
Cheers, keep 'em coming!


Changing number and length of bins in geom_histogram()

For geom_histogram(),  ggplot2 has the options bins and  binwidth to change the number and the length of the bins, respectively. This does not seem to work in TidierPlots.jl:
using Tidier.TidierPlots
using DataFrames

# create data
df = DataFrame(
    x = randn(1000),
)

# histogram with 50 bins
@chain df begin
    ggplot()
    geom_histogram(aes(x=:x), bins=50)
end

# ... and with 100 bins look identical
@chain df begin
    ggplot()
    geom_histogram(aes(x=:x), bins=100)
end

# ... the same holds with binwidth of 5
@chain df begin
    ggplot()
    geom_histogram(aes(x=:x), binwidth=5)
end

# ... and with binwidth of 10
@chain df begin
    ggplot()
    geom_histogram(aes(x=:x), binwidth=10)
end

I am using TidierPlots v.0.5.5.

Thanks for reporting this! I've fixed the bins option in the development version (as of https://github.com/TidierOrg/TidierPlots.jl/commit/eaabd2e3a54ac2932c4cb5b20c07c1d27077fa3a), but haven't gotten to binwidth yet:
df = DataFrame(
    x = randn(1000),
)
g1 = ggplot(df) + geom_histogram(aes(x = :x), bins = 10)
g2 = ggplot(df) + geom_histogram(aes(x = :x), bins = 100)

g1

g2

I'm leaving this open until binwidth is implemented

binwidth is not an option in Makie's hist plot, making this more difficult than expected. binwidth is not likely to be implemented in the near term, but may be revisited

Great, thank you!


Created the desktop version of the portfolio

Here on this branch, I created the desktop version of this portfolio and updated the README file.

Finished the desktop design


Cleanup GitHub Action workflow

Codecov Report

Merging #658 (e5d723d) into main (90dfcde) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head e5d723d differs from pull request most recent head 8bde5f9. Consider uploading reports for the commit 8bde5f9 to get more accurate results

@@           Coverage Diff           @@
##             main     #658   +/-   ##
=======================================
  Coverage   90.29%   90.29%
=======================================
  Files          77       77
  Lines        4532     4532
  Branches      838      838
=======================================
  Hits         4092     4092
  Misses        250      250
  Partials      190      190

Flag
Coverage Δ

unittests
90.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


⚠ ClamAV has degraded performance

In 4fc35e2, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 52 ms

Resolved: ClamAV performance has improved in da89f23.


UnboundLocalError: local variable 'res' referenced before assignment

UnboundLocalError                         Traceback (most recent call last)
 in <cell line: 4>()
2
3 markitdown = MarkItDown()
----> 4 result = markitdown.convert("/content/TEST.pdf")
5 print(result.text_content)
2 frames
/usr/local/lib/python3.10/dist-packages/markitdown/_markitdown.py in _convert(self, local_path, extensions, **kwargs)
1043                     error_trace = ("\n\n" + traceback.format_exc()).strip()
1044
-> 1045                 if res is not None:
1046                     # Normalize the content
1047                     res.text_content = "\n".join(
UnboundLocalError: local variable 'res' referenced before assignment

`# If we hit an error log it and keep trying
try:
res = converter.convert(local_path, **_kwargs)
except Exception:
error_trace = ("\n\n" + traceback.format_exc()).strip()
            if res is not None:
                # Normalize the content
                res.text_content = "\n".join(
                    [line.rstrip() for line in re.split(r"\r?\n", res.text_content)]
                )
                res.text_content = re.sub(r"\n{3,}", "\n\n", res.text_content)

                # Todo
                return res`

maybe here should some fix

I'm also experiencing this error not on every pdf but just on some of them, and it doesn't finish the conversion to md file

same as #40


Add a wiki: Cheese E Pedia

Link to origin wiki: https://chucke.fandom.com/wiki/Chuck_E._Cheese_Wiki
Link to destination (independent) wiki: https://cheeseepedia.org/

Not sure about this one. The Fandom wiki's scope is specifically Chuck E. Cheese, while Cheese-E-Pedia is "all things animatronics". A redirect could work if Cheese-E-Pedia covers Chuck E. Cheese is as much depth as the Fandom wiki does.

The majority of the articles are of relation to Chuck E. Cheese. The wiki is open to contributions for other animatronic groups but about 90% of it is just CEC contributions, hence the name.

@The64thGamer Thanks! Will include in the next update.

Added in v3.7.0 (now available for Chrome, release pending for Firefox).


Remove stale branches

There are branches like 454_refactor_time_sheets that are far behind dev and are probably not needed anymore.
Ideally, there are only dev and master branches, in addition to those branches actively being worked on right now.

Done. Only branches left are master dev and 454_refactor_time_sheets. I am currently using that one :P

:+1:


Error: Uncaught (in promise): TypeError: Class constructor Lh cannot be invoked without 'new'

I get this error, and it happens only if I use es6 and production.
main.16ed0bb01156b27f659a.bundle.js:1 ERROR Error: Uncaught (in promise): TypeError: Class constructor Lh cannot be invoked without 'new'
TypeError: Class constructor Lh cannot be invoked without 'new'

So the same code base is fine if run with es5 dev/prod or es6 dev only.
Versions
Angular CLI: 1.6.0
Node: 8.4.0
OS: darwin x64
Angular: 5.1.0
... animations, common, compiler, compiler-cli, core, forms
... http, language-service, platform-browser
... platform-browser-dynamic, router

@angular/cli: 1.6.0
@angular-devkit/build-optimizer: 0.0.35
@angular-devkit/core: 0.0.22
@ngtools/json-schema: 1.1.0
@ngtools/webpack: 1.9.0
@schematics/schematics: 0.0.10
typescript: 2.5.3
webpack: 3.10.0

Repro steps

Clone this repo: https://github.com/ShinDarth/angular-test-app
npm install
ng serve --prod
open the app with the browser

you will see the error in the browser console
Observed behavior
The app is broken and there is that error in the console. Happens only if es6 AND production.
Desired behavior
It should always run fine, no matter of es5/es6 or prod/dev.

this was originally created here https://github.com/valor-software/ngx-bootstrap/issues/3252
It happens when you build project with es6 & AOT. So non-prod build with AOT has this error as well.
I figured out that the main reason in rxjs version. If you downgrade it to 5.4.3, everything works as expected, but 5.5+ seems to break the app. So I think this is more related to rxjs, not angular CLI. I'll create an issue in rxjs repo as well.
Does someone have any idea about why it's happening this way? I don't see any breaking changes notes in rxjs changelog

Also want to notice that in the stack trace I see a link to the es5 file but our lib has es2015 bundle. Seems like it's ignored