Mapped network drive won't load all files and folders

Description
Hi there, the Files app can open mapped network drive, but it won't display all files and folders. For example I have attached a screenshot. The network drive should have 800 items inside (shown on Windows File Explorer), but on Files app, it only shows 32 items.
Steps To Reproduce
No response
Expected behavior
It should display all of the mapped network drive contents (files and folders).
Files Version
Version: <IP_ADDRESS> OS Version: 10.0.22000.438
Windows Version
Windows 11 21H2 22000.438
Relevant Assets/Logs

Seems to be related to #3903. It's taking very long to enumerate the items on the share and they will slowly pop up in batches. Might be a duplicate even.

Is this still an issue. if so have you tried waiting a while and seeing if it loads more?


63 avg dam features

Was just discussing dams on another project. I'm guessing there was some normalization by drainage area to determine 'altered' (I guess a traditional threshold is 103 acre-feet per square mile). Would definitely be curious to learn the procedure for Gages2.1.


Getting Error after Installation

Awesome theme, I am very happy with it, but I am getting error whenever opeing any file from terminal. I do not get any error if I disable the theme.
The Error is::
(emacs:3067): Gtk-WARNING **: Theme parsing error: gtk-widgets.css:513:20: Not using units is deprecated. Assuming 'px'.

(emacs:3067): Gtk-WARNING **: Theme parsing error: gtk-widgets.css:2066:20: Not using units is deprecated. Assuming 'px'.

(emacs:3067): Gtk-WARNING **: Theme parsing error: gtk-widgets-assets.css:13:7: Missing name of pseudo-class

(emacs:3067): Gtk-WARNING **: Theme parsing error: gtk-widgets-assets.css:17:7: Missing name of pseudo-class

(emacs:3067): Gtk-WARNING **: Theme parsing error: gtk-widgets-assets.css:37:7: Missing name of pseudo-class

(emacs:3067): Gtk-WARNING **: Theme parsing error: gtk-widgets-assets.css:41:7: Missing name of pseudo-class

(emacs:3067): Gtk-WARNING **: Theme parsing error: gtk.css:83:29: Failed to import: Error opening file: No such file or directory

(emacs:3067): Gtk-WARNING **: Theme parsing error: gtk.css:85:44: Failed to import: Error opening file: No such file or directory

If the theme works fine for you - just ignore those warnings.

Thanks for reporting @therimalaya. I have been trying to catch all of the warnings. I'll fix them. However, I think they should not affect the performace of the theme.


Unresolved Dependency: org.spark-packages#sbt-spark-package

I added the plugin to project/plugin.sbt like described in the readme file:
addSbtPlugin("org.spark-packages" % "sbt-spark-package" % "0.2.3")

However, SBT cannot resolve the dependency. Please find the error log below.
[info] Loading project definition from .../drunken-data-quality/project
[info] Updating {...}drunken-data-quality-build...
[info] Resolving org.spark-packages#sbt-spark-package;0.2.3 ...
[warn]  module not found: org.spark-packages#sbt-spark-package;0.2.3
[warn] ==== typesafe-ivy-releases: tried
[warn]   https://repo.typesafe.com/typesafe/ivy-releases/org.spark-packages/sbt-spark-package/scala_2.10/sbt_0.13/0.2.3/ivys/ivy.xml
[warn] ==== sbt-plugin-releases: tried
[warn]   https://repo.scala-sbt.org/scalasbt/sbt-plugin-releases/org.spark-packages/sbt-spark-package/scala_2.10/sbt_0.13/0.2.3/ivys/ivy.xml
[warn] ==== local: tried
[warn]   /Users/frosner/.ivy2/local/org.spark-packages/sbt-spark-package/scala_2.10/sbt_0.13/0.2.3/ivys/ivy.xml
[warn] ==== jcenter: tried
[warn]   https://jcenter.bintray.com/org/spark-packages/sbt-spark-package_2.10_0.13/0.2.3/sbt-spark-package-0.2.3.pom
[warn] ==== public: tried
[warn]   https://repo1.maven.org/maven2/org/spark-packages/sbt-spark-package_2.10_0.13/0.2.3/sbt-spark-package-0.2.3.pom
[info] Resolving com.fasterxml.jackson.module#jackson-module-scala_2.10;2.5.1 [info] Resolving org.scala-sbt.ivy#ivy;2.3.0-sbt-c5d1b95fdcc1e1007740ffbecf4eb[info] Resolving org.fusesource.jansi#jansi;1.4 ...
[warn]  ::::::::::::::::::::::::::::::::::::::::::::::
[warn]  ::          UNRESOLVED DEPENDENCIES         ::
[warn]  ::::::::::::::::::::::::::::::::::::::::::::::
[warn]  :: org.spark-packages#sbt-spark-package;0.2.3: not found
[warn]  ::::::::::::::::::::::::::::::::::::::::::::::
[warn]
[warn]  Note: Some unresolved dependencies have extra attributes.  Check that these dependencies exist with the requested attributes.
[warn]      org.spark-packages:sbt-spark-package:0.2.3 (scalaVersion=2.10, sbtVersion=0.13)
[warn]
[warn]  Note: Unresolved dependencies path:
[warn]      org.spark-packages:sbt-spark-package:0.2.3 (scalaVersion=2.10, sbtVersion=0.13) (/Users/frosner/Documents/projects/drunken-data-quality/project/plugin.sbt#L1-2)
[warn]        +- default:drunken-data-quality-build:0.1-SNAPSHOT (scalaVersion=2.10, sbtVersion=0.13)
sbt.ResolveException: unresolved dependency: org.spark-packages#sbt-spark-package;0.2.3: not found
    at sbt.IvyActions$.sbt$IvyActions$$resolve(IvyActions.scala:294)
    at sbt.IvyActions$$anonfun$updateEither$1.apply(IvyActions.scala:191)
    at sbt.IvyActions$$anonfun$updateEither$1.apply(IvyActions.scala:168)
    at sbt.IvySbt$Module$$anonfun$withModule$1.apply(Ivy.scala:155)
    at sbt.IvySbt$Module$$anonfun$withModule$1.apply(Ivy.scala:155)
    at sbt.IvySbt$$anonfun$withIvy$1.apply(Ivy.scala:132)
    at sbt.IvySbt.sbt$IvySbt$$action$1(Ivy.scala:57)
    at sbt.IvySbt$$anon$4.call(Ivy.scala:65)
    at xsbt.boot.Locks$GlobalLock.withChannel$1(Locks.scala:93)
    at xsbt.boot.Locks$GlobalLock.xsbt$boot$Locks$GlobalLock$$withChannelRetries$1(Locks.scala:78)
    at xsbt.boot.Locks$GlobalLock$$anonfun$withFileLock$1.apply(Locks.scala:97)
    at xsbt.boot.Using$.withResource(Using.scala:10)
    at xsbt.boot.Using$.apply(Using.scala:9)
    at xsbt.boot.Locks$GlobalLock.ignoringDeadlockAvoided(Locks.scala:58)
    at xsbt.boot.Locks$GlobalLock.withLock(Locks.scala:48)
    at xsbt.boot.Locks$.apply0(Locks.scala:31)
    at xsbt.boot.Locks$.apply(Locks.scala:28)
    at sbt.IvySbt.withDefaultLogger(Ivy.scala:65)
    at sbt.IvySbt.withIvy(Ivy.scala:127)
    at sbt.IvySbt.withIvy(Ivy.scala:124)
    at sbt.IvySbt$Module.withModule(Ivy.scala:155)
    at sbt.IvyActions$.updateEither(IvyActions.scala:168)
    at sbt.Classpaths$$anonfun$sbt$Classpaths$$work$1$1.apply(Defaults.scala:1392)
    at sbt.Classpaths$$anonfun$sbt$Classpaths$$work$1$1.apply(Defaults.scala:1388)
    at sbt.Classpaths$$anonfun$doWork$1$1$$anonfun$90.apply(Defaults.scala:1422)
    at sbt.Classpaths$$anonfun$doWork$1$1$$anonfun$90.apply(Defaults.scala:1420)
    at sbt.Tracked$$anonfun$lastOutput$1.apply(Tracked.scala:37)
    at sbt.Classpaths$$anonfun$doWork$1$1.apply(Defaults.scala:1425)
    at sbt.Classpaths$$anonfun$doWork$1$1.apply(Defaults.scala:1419)
    at sbt.Tracked$$anonfun$inputChanged$1.apply(Tracked.scala:60)
    at sbt.Classpaths$.cachedUpdate(Defaults.scala:1442)
    at sbt.Classpaths$$anonfun$updateTask$1.apply(Defaults.scala:1371)
    at sbt.Classpaths$$anonfun$updateTask$1.apply(Defaults.scala:1325)
    at scala.Function1$$anonfun$compose$1.apply(Function1.scala:47)
    at sbt.$tilde$greater$$anonfun$$u2219$1.apply(TypeFunctions.scala:40)
    at sbt.std.Transform$$anon$4.work(System.scala:63)
    at sbt.Execute$$anonfun$submit$1$$anonfun$apply$1.apply(Execute.scala:226)
    at sbt.Execute$$anonfun$submit$1$$anonfun$apply$1.apply(Execute.scala:226)
    at sbt.ErrorHandling$.wideConvert(ErrorHandling.scala:17)
    at sbt.Execute.work(Execute.scala:235)
    at sbt.Execute$$anonfun$submit$1.apply(Execute.scala:226)
    at sbt.Execute$$anonfun$submit$1.apply(Execute.scala:226)
    at sbt.ConcurrentRestrictions$$anon$4$$anonfun$1.apply(ConcurrentRestrictions.scala:159)
    at sbt.CompletionService$$anon$2.call(CompletionService.scala:28)
    at java.util.concurrent.FutureTask.run(FutureTask.java:266)
    at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
    at java.util.concurrent.FutureTask.run(FutureTask.java:266)
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
    at java.lang.Thread.run(Thread.java:745)
[error] (*:update) sbt.ResolveException: unresolved dependency: org.spark-packages#sbt-spark-package;0.2.3: not found

Can be resolved by adding
resolvers += "Spark Package Main Repo" at "https://dl.bintray.com/spark-packages/maven"

to plugin.sbt.

Handled by #12.

According to https://spark.apache.org/news/new-repository-service.html , we should not use dl.bintray anymore. I replaced the following
resolvers += "bintray-spark-packages" at "https://dl.bintray.com/spark-packages/maven/"

with this
resolvers += "spark-packages" at "https://repos.spark-packages.org/"

and it seems to work now.

According to https://spark.apache.org/news/new-repository-service.html , we should not use dl.bintray anymore. I replaced the following
resolvers += "bintray-spark-packages" at "https://dl.bintray.com/spark-packages/maven/"

with this
resolvers += "spark-packages" at "https://repos.spark-packages.org/"

and it seems to work now.


Added disk image unmount step for MSIX App Attach & Added a note for how to view Azure SQL Database logs from an Azure Storage Account

Added a step to dismount the VHD in the final code sample. Also added a note to explain that it should be used during Shutdown.
The second commit was for another file/section of docs for Azure SQL Database log viewing when pushed to a Storage Account.

@drewjanderson : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@drewjanderson : Thanks for your contribution! The author(s) have been notified to review your proposed change.

I've honestly never updated 2 separate docs pages before. If I need to separate them into separate PRs, wouldn't mind a tip on the best way to do that!


Filter "bereits adoptiert" should also show non adopted trees but in another color

Background: Why this issue?
The filter"breits adoptiert" shows the engagement of the community on the platform but it could also help to choose for a tree to adopt that isn't yet adopted. For this purpose, all trees should be displayed and those that are already adopted should be highlighted.
Deliverables: How to fix the issue?
Show all trees and display them differently than  those adopted (gray?)
Output: Gain of fixing the issue?
Helps to find a tree to adopt.
Issue creation checklist

[ ] I have attached one of the priority labels HIGH, MIDDLE, LOW
[ ] I have attached other labels with regard to the issues purpose (i.e.enhancement, bug, community feedback)

We currently don't have the filter of all the adopted trees any longer, but might implement it again soon. Furthermore, we have generally adapted the color code of the trees, and could therefore add another color for adopted trees and those taken care of by the city authorities.


Fix MV-132 (outline without text when navigating with TAB)

This PR fixed bug MV-132 (outline without text on controls when navigating with TAB).

Now it should works ok


Evaluate mlx-community/CodeLlama-70b-Instruct-hf-4bit-MLX

Requires MLX runtime support

I don't have Apple hardware, so not something I'll be able to do.


EGL not working

Followed all the setup step in the documents but can't seem to get working, am I missing the any dependency?
I am trying to run on WSL with 3090ti
(4D-humans) ❯ python demo.py \
    --img_folder example_data/images \
    --out_folder demo_out \
    --batch_size=48 --side_view --save_mesh --full_frame
WARNING: You are using a SMPL model, with only 10 shape coefficients.
Traceback (most recent call last):
  File "/home/samxu/projects/hpe/4D-Humans/demo.py", line 154, in <module>
    main()
  File "/home/samxu/projects/hpe/4D-Humans/demo.py", line 31, in main
    model, model_cfg = load_hmr2(args.checkpoint)
  File "/home/samxu/projects/hpe/4D-Humans/hmr2/models/__init__.py", line 84, in load_hmr2
    model = HMR2.load_from_checkpoint(checkpoint_path, strict=False, cfg=model_cfg)
  File "/home/samxu/miniconda3/envs/4D-humans/lib/python3.10/site-packages/pytorch_lightning/core/module.py", line 1561, in load_from_checkpoint
    loaded = _load_from_checkpoint(
  File "/home/samxu/miniconda3/envs/4D-humans/lib/python3.10/site-packages/pytorch_lightning/core/saving.py", line 89, in _load_from_checkpoint
    model = _load_state(cls, checkpoint, strict=strict, **kwargs)
  File "/home/samxu/miniconda3/envs/4D-humans/lib/python3.10/site-packages/pytorch_lightning/core/saving.py", line 156, in _load_state
    obj = cls(**_cls_kwargs)
  File "/home/samxu/projects/hpe/4D-Humans/hmr2/models/hmr2.py", line 59, in __init__
    self.mesh_renderer = MeshRenderer(self.cfg, faces=self.smpl.faces)
  File "/home/samxu/projects/hpe/4D-Humans/hmr2/utils/mesh_renderer.py", line 50, in __init__
    self.renderer = pyrender.OffscreenRenderer(viewport_width=self.img_res,
  File "/home/samxu/miniconda3/envs/4D-humans/lib/python3.10/site-packages/pyrender/offscreen.py", line 31, in __init__
    self._create()
  File "/home/samxu/miniconda3/envs/4D-humans/lib/python3.10/site-packages/pyrender/offscreen.py", line 137, in _create
    egl_device = egl.get_device_by_index(device_id)
  File "/home/samxu/miniconda3/envs/4D-humans/lib/python3.10/site-packages/pyrender/platforms/egl.py", line 83, in get_device_by_index
    raise ValueError('Invalid device ID ({})'.format(device_id, len(devices)))
ValueError: Invalid device ID (0)

I have the same problem. Have you solved it?

I  also have the same problem. Have you solved it?

After installing libegl1-mesa-dev and mesa-utils using apt-get, the initial problem was resolved.
sudo apt-get install libegl1-mesa-dev
sudo apt-get install mesa-utils

However, I encountered a new issue:
raise ValueError('Invalid device ID ({})'.format(device_id, len(devices)))
ValueError: Invalid device ID (0)


Update WordLift Vector Store

Description
We updated the WordLift Vector Store to use the new WordLift Python SDK, so that we could remove the manager_client source code from the Vector Store. We also streamlined the code, removing unnecessary classes and refactored UTs.
New Package?
Did I fill in the tool.llamahub section in the pyproject.toml and provide a detailed README.md for my new integration or package?

[ ] Yes
[x] No

Version Bump?
Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

[x] Yes
[ ] No

Type of Change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[x] Added new unit/integration tests
[ ] Added new notebook (that tests end-to-end)
[ ] I stared at the code and made sure it makes sense

Suggested Checklist:

[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[ ] I have added Google Colab support for the newly added notebooks.
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] I ran make format; make lint to appease the lint gods

great cleanup PR! Just confirming, @ziodave you are done making changes here?

I confirm


fix: remove flags enum attribute

Hi, I don't think the Ordinal enum should have a Flags attribute on it as the enum values are not powers of two. This PR removes it and adds some unit tests documenting the Format/Parse behaviour.
Thanks.

@rars Good catch and thanks for the contribution :+1:


jacobi-sdag

Original issue: https://charm.cs.illinois.edu/redmine/issues/613

No body.

Original date: 2015-02-09 19:19:31

There is no "test" target in the makefile. All of the targets in the test file are related to fault tolerance, and only run when Charm++ is built with fault tolerance enabled. Otherwise they crash due to bad command line parsing.

Original date: 2015-02-10 17:37:42

Both this and bug 429 were resolved by the fix for bug 654. There are now warning messages when you pass in flags that don't apply to the current build of charm, so when these tests fail on incorrect builds it will be clear why. This test will stay in the tests directory because it is meant as a fault tolerance test, which is why it has fittest targets but no test target.


character_test.aly fails

Test output:
Compiling character_test.aly...
Compilation failed: returned with -6

Duplicate of #271 ?

@raoulvdberge Yeah, duplicate. When you run it normally, i.e. not with the unit test, you get that error message. Not too sure what it is.


Add Readme Badges

hello,
i want to add readme badges, image for the reference is attached, this image is just for the reference, to make it clear of what im talking about.

Hi, @UjjwalSharma01 , you can work on this and please refer to the Contribution guidelines on the readme once.
All the best!

@AKD-01 kindly refer #47
this issue is already raised earlier

@S-ishita aren't they different?

No he is refering to same thing. @AKD-01

Oh okay. @UjjwalSharma01  you may work on any new issue as this issue ghas already been assigned. Thank you!

@AKD-01 alright


canvas render slicing

:construction: WIP - not a full implem, and in need of refactor :construction:
Followup to #655.
I figured that when we modify elements, the elements below and above selection aren't modified and thus don't need rerender. So I now keep 3 other "main" canvases, one for selected elements (and elements deselected, but in between the selection, z-index-wise), one for elements below them, and one for elements above them. The 2 other canvases are composited together with the selected elements onto the main canvas.

The idea is that copying 2 canvases to the main canvas instead of hundreds of small canvases will have better perf, and it does! Note that this PR doesn't change or remove keeping the small element canvases around because we still use them when drawing on the 2 temp main canvases, or when this new hack isn't applied at all.
It radically improves performance on huge scenes, but only in certain cases such as when moving/resizing elements.
Doesn't work when scrolling or zooming, because we can't guarantee such action won't change visible elements.
Currently doesn't work for creating elements either, but will be added.
testing
(4096 elements)
Try picking an element and moving it around or resizing it.

production (before)
this PR (after)

before:

after:

This is a really cool idea! Are you going to land it?

The links are not working anymore.. :/

Ohhh yeah, I changed zeit integration from my account to a team account... If he rebases should be good.

Yup, I'll continue on this. It needs further work as there are unhandled cases I believe, and I've seen some weird bugs around zooming that I'll need to investigate.

I've rebased and updated the links - problem is our backend API doesn't work with ZEIT, so you'll need to save/restore from a file if you wanted to test the 4096 elements on this PR :/.

What do you mean it's not working.. works for me with the previews :)

First, there are major cases that aren't implemented and should be (such as creating new elements). Second, I dimly recall bugs that are hard to reproduce, so I'll need to investigate this. Third, it's not refactored and optimized, so this PR is definitely not ready for merge.

Can confirm a bug: the non-selected elements don’t respect devicePixelRatio

I'll shelve this until multiplayer is finished and codebase settled down, since right now it seems this heuristic wouldn't even work anymore.


Failed to verify the signature.

When verifying the signature of the SAMLResponse returned by the server, I find that the signature verification fails. I do not know the cause. Here's my verification code:
let sso_cert_der: &[u8] = &fs::read("/home/hello/src/jks_cer/rust-registry_idp.cer").unwrap();
let response_xml: &[u8] = &fs::read("/home/hello/response.xml").unwrap();
samael::crypto::verify_signed_xml(response_xml, sso_cert_der, Some("ID")).expect("failed to verify response signature");

The error message is as follows:
func=xmlSecOpenSSLAppCertLoadBIO:file=app.c:line=1051:obj=unknown:subj=d2i_X509_bio:error=4:crypto library function failed:openssl error: 218529960: asn1 encoding routines: asn1_check_tlen wrong tag func=xmlSecOpenSSLAppKeyFromCertLoadBIO:file=app.c:line=781:obj=unknown:subj=xmlSecOpenSSLAppCertLoadBIO:error=1:xmlsec library function failed: func=xmlSecOpenSSLAppKeyLoadBIO:file=app.c:line=312:obj=unknown:subj=xmlSecOpenSSLAppKeyFromCertLoadBIO:error=1:xmlsec library function failed: func=xmlSecOpenSSLAppKeyLoadMemory:file=app.c:line=207:obj=unknown:subj=xmlSecOpenSSLAppKeyLoadBIO:error=1:xmlsec library function failed: thread 'main' panicked at '**failed to verify response signature: XmlSecError { error: KeyLoadError }**', src/main.rs:24:89 note: run with RUST_BACKTRACE=1environment variable to display a backtrace
Also, I never understood what the third parameter was correctly understood.

Can someone guide me? Thank you.

@njaremko @RavuAlHemio @agrinman @Guiguiprim

It's generally bad form to tag a bunch of people on an issue you just created.
If you googled (or China's equivalent) the error, you'd see it's an issue with your key.
It might be in PEM format instead of DER, or the data could be garbage, not sure, but it's definitely an issue with parsing your key.

I'm sorry for the inappropriate way it was done. That was not my intention.

When I use a certificate to authenticate Response, the certificate format is (.CER). It is not a private key in (.pem) format. Is this function not used for certificate verification?
What is the purpose of the third parameter (like'some("ID")')?

I also found a problem, I don't know if it was a problem with the way I tested it. I entered the following command to test:
cargo test --features=xmlsec
The following error occurred:
error[E0599]: no method named remove_attribute_nsfound for mutable reference&mut Nodein the current scope    --> src/crypto.rs:190:10     | 190 |     node.remove_attribute_ns(ATTRIB_SIGVER, XMLNS_SIGVER)     |          ^^^^^^^^^^^^^^^^^^^ help: there is an associated function with a similar name:remove_attribute``

.cer is just a file extension, the content of the file is either in PEM (ascii) or DER (binary) format. The function you used expects it's argument to be in DER format, but it seems like you're passing in either a mangled file, or a PEM encoded key.

This is my problem. When importing a public key, the newline character in the public key is ignored. The format fails to be parsed. Thank you for your answer.


Fix incorrect pasted text on copied HTML snippet

Details

If you send html snippet as plain text and select the message you just sent, paste to our App textbox or other external editor, the pasted text is NOT the same as the copied text, this PR fix it. PR only affects Web and Desktop.
Since Clipboard API is available only in secure context (https), if you test with your local ip address, you need to enable https first.
https://github.com/Expensify/App/blob/fedefd12c8ef55040fcdb200e41dc87d3520354a/package.json#L19
-     "web-server": "webpack-dev-server --open --config config/webpack/webpack.dev.js",
+     "web-server": "webpack-dev-server --open --config config/webpack/webpack.dev.js --server-type https",

Fixed Issues
$ https://github.com/Expensify/App/issues/12271
PROPOSAL: https://github.com/Expensify/App/issues/12271#issuecomment-1312326623
Tests

Launch and login to Expensify App
Type asd as plain text(not code or code block) in a chat and send
Use your mouse to select or highlight the message you just send, and pressing Ctrl+C / Cmd+C
Paste it with Ctrl+V / Cmd + V on App textbox or your external text editor
Verify the pasted text is the same as the copied text
Use your mouse to select or highlight the message you just send, right click your mouse to show context menu
Click Copy to Clipboard in context menu
Paste it with Ctrl+V / Cmd + V on App textbox or your external text editor
Verify the pasted text is the same as the copied text

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

Launch and login to Expensify App
Type asd as plain text(not code or code block) in a chat and send
Use your mouse to select or highlight the message you just send, and pressing Ctrl+C / Cmd+C
Paste it with Ctrl+V / Cmd + V on App textbox or your external text editor
Verify the pasted text is the same as the copied text
Use your mouse to select or highlight the message you just send, right click your mouse to show context menu
Click Copy to Clipboard in context menu
Paste it with Ctrl+V / Cmd + V on App textbox or your external text editor
Verify the pasted text is the same as the copied text

[ ] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] iOS / native
[x] Android / native
[x] iOS / Safari
[x] Android / Chrome
[x] MacOS / Chrome
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product was added in all src/languages/* files
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

PR Reviewer Checklist
The reviewer will copy/paste it into a new comment and complete it after the author checklist is completed

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for expected offline behavior are in the Offline steps section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[ ] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] iOS / native
[ ] Android / native
[ ] iOS / Safari
[ ] Android / Chrome
[ ] MacOS / Chrome
[ ] MacOS / Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product was added in all src/languages/* files
[ ] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] I verified that if a function's arguments changed that all usages have also been updated correctly
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

https://user-images.githubusercontent.com/103875612/204394307-187b8077-9098-4d54-979d-fa05ce3bde6a.mp4

Mobile Web - Chrome

https://user-images.githubusercontent.com/103875612/204394187-004ab181-38ce-4acd-aea5-20e65d4690fc.mp4

Mobile Web - Safari

https://user-images.githubusercontent.com/103875612/204394226-4a72ea6e-fd01-4240-8f3b-bd1aa6bc449d.mp4

Desktop

https://user-images.githubusercontent.com/103875612/204394257-2fde3606-3382-4c6b-aac2-3e157b46711e.mp4

iOS

https://user-images.githubusercontent.com/103875612/204394377-2945fe57-f6d8-47d1-bb37-fffe53cea36e.mp4

Android

https://user-images.githubusercontent.com/103875612/204394415-6b0f64e8-4088-4b75-a6d7-ddf69f9e56b4.mp4

Let's merge @danieldoglas.

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by @danieldoglas in version: 1.2.34-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by @luacmartins in version: 1.2.34-1 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Rdd string

Relates to https://github.com/databricks/spark-csv/issues/188

The implicit functions in package.scala are not going to be updated in future. Users are encouraged to use spark's load and save API to interact with spark-csv rather than directly calling the implicit functions.

Current coverage is 86.24%

Merging #270 into master will increase coverage by +0.15% as of 3fa5363

@@            master    #270   diff @@
======================================
  Files           12      12
  Stmts          525     538    +13
  Branches       155     157     +2
  Methods          0       0
======================================
+ Hit            452     464    +12
  Partial          0       0
- Missed          73      74     +1

Review entire Coverage Diff as of 3fa5363

Powered by Codecov. Updated on successful CI builds.

Thank you. Which spark-csv version this PR will be part of?

load and save functions exist in all Spark 1.4+ versions.

I was asking regarding "adds a csvRdd function to create a Dataframe from RDD[String]".
Please check https://github.com/databricks/spark-csv/issues/264
Thanks.


How to link FSharp.Core.php

Hi thank you for the example of crazy on BGA and this awesome tool.
I was just wondering, do you advise copying the https://github.com/thinkbeforecoding/peeble/tree/master/src/FSharp.Core directory over?
Is this something that this tool could potentially do behind a flag? (To be able to always get the latest version?)

For now, yes.
I think ultimately it should be generated by compiling Fable.Core in Php, and put in a Composer package, but it's not done yet.


ci: configure max concurrent GHA jobs

The failure on the error-chain integration job is spurious (plus there's no code changes in this PR anyway):
+ git clone --depth=1 https://github.com/rust-lang-nursery/error-chain.git
Cloning into 'error-chain'...
fatal: unable to access 'https://github.com/rust-lang-nursery/error-chain.git/': Could not resolve host: github.com
##[error]Process completed with exit code 128.

Thanks!


Ensure dep has been run in CI

What this PR does / why we need it:
If someone fails to add a dep then the build will fail but
if they remove one and dont run it then it can lead to
deps hanging around unnecessarily and a future dev/PR getting
a surprising diff.
Which issue(s) this PR fixes
Fixes #244
Special notes for your reviewer:
dep says that the command is supposed to exit non-zero if it would write something but that is just not true if you try it out/look at the code. Just checking that something gets written to stdout which seems (by looking into the code) to the only way to tell.
I am trying not to hinge on an exact wording like Would have written just in case that gets tweaked at some point. We are also pinning the version here though so it should be fine.
Release note:
NONE

Codecov Report

Merging #755 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #755   +/-   ##
=======================================
  Coverage   42.59%   42.59%
=======================================
  Files          70       70
  Lines        4029     4029
=======================================
  Hits         1716     1716
  Misses       2208     2208
  Partials      105      105

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 985c071...4db55e3. Read the comment docs.

./dep ensure --dry-run produced output on stdout; did you need add/remove a dependency?
But didnt fail the build; forgot to exit 1
However, there isn't a reason the lockfile should be written; it is the same data. Didnt think this was the case the first time I tried it but /shrug. May need to check for some other value besides the lockfile. Will double check the code but maybe just an inverted grep is enough?

Pushed a commit to show that section now fails as expected. Has since removed it (but you can look at the travis history if you want to see the failure).
I ended up setting the failure against an actual dep ensure && git status check because (1) it is clear what/why we are checking (2) dep ensure --dry-run oddly always wrote that it was going to write the gopkg.lock so we would have had to do a more awkward, unintuitive check.


the lib is too heavy (about 2 Mb), png flags could be resized

Hi,
Are you planning to reduice the lib size (mainly due to png flags) ?
thx.

What is a nice size in your opinion?

Any upgrade on this issue ?

Hey, with the last version the images are resized


Kb scenario updates

All updates in datasheet_raster branch (see pull request)
First argument is parsed as sid if integer
Can now input lists into the name and sid arguments
Added copy_external_inputs argument to the run() method to mirror new rsyncrosim enhancement

Updates over the previous PR look good! Once the comments in the other PR are resolved this should be good to merge!

Regarding the comments from the previous PR:

Scenarios are returning DataFrames because of summary = True, explicitly setting it to false fixes the behaviour issues I was seeing. I think the work around here would be to disregard summary if scenario name or sid is provided? Here's a working example:

`import pysyncrosim as ps
myLibrary = ps.library("test.ssim")
myProject = myLibrary.projects("example project")
myScenario = myProject.scenarios("example scenario")
myScenario2 = myProject.scenarios("example scenario", summary = False)
type(myScenario)
type(myScenario2)`

When I try to filter_columns in datasheet_raster to access rasters that are not in a "*.temp" folder, I'm getting an error on line 622 of library.py because tempfile_path is being called without being assigned. tempfile_path is only ever assigned in the except clause, so this will fail if the try statement doesn't raise an exception. I'm not sure how you'd like to fix this. Maybe lines 622 and 623 should just be in the except clause and not the finally?

I'm just running the package through pytest and fixing up the tests before I make my next commit, but #1 will definitely be fixed in the nextcommit. I've made it so that summary is None by default now and is assigned True or False based on whether a name or sid is included. This is overridden if the user explicitly sets summary to True or False.
As for #2, that should be an easy fix that I can also make in the next commit!

Hi Katie – I think it would be best to make the behaviour with respect to defaults regarding summary=True the same in pysyncrosim as they currently are in rsyncrosim. I can’t recall exactly how it all works right in now in rsyncrosim but there is some history behind the decisions that were made. Does this make sense? Are we doing the same thing in both packages? Colin
From: Katie Birchard @.>
Sent: December 28, 2021 7:00 PM
To: syncrosim/pysyncrosim @.>
Cc: Subscribed @.***>
Subject: Re: [syncrosim/pysyncrosim] Kb scenario updates (PR #6)
I'm just running the package through pytest and fixing up the tests before I make my next commit, but #1https://github.com/syncrosim/pysyncrosim/pull/1 will definitely be fixed in the nextcommit. I've made it so that summary is None by default now and is assigned True or False based on whether a name or sid is included. This is overridden if the user explicitly sets summary to True or False.
As for #2https://github.com/syncrosim/pysyncrosim/pull/2, that should be an easy fix that I can also make in the next commit!
—
Reply to this email directly, view it on GitHubhttps://github.com/syncrosim/pysyncrosim/pull/6#issuecomment-1002327442, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACB237RKNJRNGUCVKGI6GGTUTJFQXANCNFSM5KTNWUCQ.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you are subscribed to this thread.Message ID<EMAIL_ADDRESS>

Hi Colin,
I think in this case it is quite different from rsyncrosim since scenarios() is a method of a Library or Project, and you can use the scenarios() method to either retrieve a dataframe of all the scenarios (i.e. summary = False) or retrieve a specific scenario instance (i.e. summary = True). With rsyncrosim, you would just use the scenario() function to create or retrieve a Scenario, or you would use the ssimLibrary() or project() functions with name set to the Scenario to get the dataframe. ssimLibrary() and project() have a summary argument that is set to NULL by default, then set to TRUE or FALSE within the code depending on the other arguments. So it does seem that we are doing similar things in both packages.
Katie

Perfect – thanks!
From: Katie Birchard @.>
Sent: December 28, 2021 7:39 PM
To: syncrosim/pysyncrosim @.>
Cc: Colin Daniel @.>; Comment @.>
Subject: Re: [syncrosim/pysyncrosim] Kb scenario updates (PR #6)
Hi Colin,
I think in this case it is quite different from rsyncrosim since scenarios() is a method of a Library or Project, and you can use the scenarios() method to either retrieve a dataframe of all the scenarios (i.e. summary = False) or retrieve a specific scenario instance (i.e. summary = True). With rsyncrosim, you would just use the scenario() function to create or retrieve a Scenario, or you would use the ssimLibrary() or project() functions with name set to the Scenario to get the dataframe. ssimLibrary() and project() have a summary argument that is set to NULL by default, then set to TRUE or FALSE within the code depending on the other arguments. So it does seem that we are doing similar things in both packages.
Katie
—
Reply to this email directly, view it on GitHubhttps://github.com/syncrosim/pysyncrosim/pull/6#issuecomment-1002338974, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACB237U26XZHRKVHU7VLLP3UTJKBHANCNFSM5KTNWUCQ.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you commented.Message ID<EMAIL_ADDRESS>

Ok, those two bugs should be fixed now! Let me know if everything works okay for you now @shreeramsenthi

Thanks Katie! The scenarios behaviour looks perfect, and I'm no longer getting the datasheet_raster error with filter_columns, but the filtering doesn't appear to be happening.
Sorry I don't have a portable example, but I think the issue has something to do with the indentation of lines 626-629 in library.py. I think this is the only place where the datasheet is filtered by col and col_id (which are parsed from the filter_column argument), and since it is in an except block it would only ever get called if col_id is not an integer (the try block on line 576). Any ideas? Let me know if you can't reproduce the issue and I'll get an example together for you.

Hey Shree, I don't think lines 626-629 should be the issue because all that code has to do with if a string is input into the filter_column argument rather than an integer. The actual filtering takes place at the SyncroSim level, so this code is just grabbing the corresponding column ID for a column string so that it can pass on the integer ID to the SyncroSim call. What are you inputting into the filter_column argument in the function? It should be a string phrase like "TransitionGroupID=20". Maybe this will be too confusing for the users though, and instead there should be two arguments, like "filter_column" and "filter_value"?

Sounds good, thanks Katie! For reference I'm trying to filter stsimsf_OutputStockGroup with "StockGroupID=420" (the stock group ID's are conveniently encoded in the file name). I also tried "Timestep=2021" and got the full stack of rasters in the datasheet both times. Since I am getting rasters back I assume the issue is not that the library is not in the working directory with files in the *.output folder.
Also, this is probably a feature for later, but do you think it would be possible to implement more advanced filtering? For example filtering by multiple columns, or allowing values in lists, etc? I'm probably missing something here, but maybe we could do the filtering that happens in SyncroSim in python using pandas.DataFrame.query()? That we we won't need to make or parse our own filtering syntax and just let users provide a single string.

Maybe we can brainstorm a way forward for the filtering sometime today? I agree with shree we should avoid getting into the weeds with our own unique filtering code. As always I’d like to check this against rsyncrosim also. I’m around today. Colin

From: Shreeram Senthivasan @.>
Sent: Thursday, December 30, 2021 10:34:01 AM
To: syncrosim/pysyncrosim @.>
Cc: Colin Daniel @.>; Comment @.>
Subject: Re: [syncrosim/pysyncrosim] Kb scenario updates (PR #6)
Sounds good, thanks Katie! For reference I'm trying to filter stsimsf_OutputStockGroup with "StockGroupID=420" (the stock group ID's are conveniently encoded in the file name). I also tried "Timestep=2021" and got the full stack of rasters in the datasheet both times. Since I am getting rasters back I assume the issue is not that the library is not in the working directory with files in the *.output folder.
Also, this is probably a feature for later, but do you think it would be possible to implement more advanced filtering? For example filtering by multiple columns, or allowing values in lists, etc? I'm probably missing something here, but maybe we could do the filtering that happens in SyncroSim in python using pandas.DataFrame.query()? That we we won't need to make or parse our own filtering syntax and just let users provide a single string.
—
Reply to this email directly, view it on GitHubhttps://github.com/syncrosim/pysyncrosim/pull/6#issuecomment-1003078692, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACB237XGVLYKNMWZSN6KUYLUTR3WTANCNFSM5KTNWUCQ.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you commented.Message ID: @.***>

That works for me, I'll be around all day! But if Katie's got it working as is though I think that's also fine for the current version. I don't know everyone else's priorities for the next few days.

Sure - if it’s working now and not holding you up Shree then let’s perhaps revisit next week instead? Katie - you decide?

From: Shreeram Senthivasan @.>
Sent: Thursday, December 30, 2021 10:47:23 AM
To: syncrosim/pysyncrosim @.>
Cc: Colin Daniel @.>; Comment @.>
Subject: Re: [syncrosim/pysyncrosim] Kb scenario updates (PR #6)
That works for me, I'll be around all day! But if Katie's got it working as is though I think that's also fine for the current version. I don't know everyone else's priorities for the next few days.
—
Reply to this email directly, view it on GitHubhttps://github.com/syncrosim/pysyncrosim/pull/6#issuecomment-1003083674, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACB237UV6B4VMBQ7TZD3PIDUTR5IXANCNFSM5KTNWUCQ.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you commented.Message ID: @.***>

That's interesting! I was just testing it out with the example-library from the helloworldSpatial package and it was working okay, but maybe in other use cases something weird is going on. Is that the Mariposa library you're using Shree? I can check it out today and see if I can reproduce your error.
As for filtering methods, I agree that it would be a lot simpler to do in Python, but the reason why we did it at the SyncroSim level was so that the methods would be identical between the Python and R APIs. However it would also be more efficient to do the filtering in Python since we wouldn't have to make a console call. Anyway, we can discuss all of this at some point. I'm free anytime today - perhaps we should discuss before I make any more changes to the filtering code?

I'm afraid I'm working out of the CONUS library which is pretty huge, I'll pare it down as best I can and send it to you soon! And makes sense, I'll propose a meeting over teams!

Okay! I just tried the filter_column on the Mariposa Library that Bronwyn sent me and it looks like setting filter_column="StockGroupID=420" or filter_column="Timestep=2019" is working fine for that Library. I wonder if there is something different about your CONUS wide Library that's throwing off the filter_column?

yeah, that would be really helpful, thanks!

Looks like I was just using the wrong version of SyncroSim. This PR is good to be merged in.


Getting error: "Unable to locate the appropriate interpreter to run this script." on version 1.50.7-beta.

I wasn't sure where else to post this so remove if it isn't the right place.
But I downloaded the newest version, deleted the folder for the previous one, and went to launch it and am given the following error:
Unable to locate the appropriate interpreter to run this script.
Script: Lailloken UI.ahk
Requires: >=1.1.36 <2
If anyone could point me in the right direction on how to remedy this it would be appreciated. I tried googling the error, but only seemed to get results related to other random projects.

v1.50.x requires AutoHotkey version 1.1.36 or newer, but it cannot run on AutoHotkey v2. If you have AHK v2 on your system, you'll need to install v1 as well. If you already have v1 installed, you'll have to update it to at least 1.1.36
https://www.autohotkey.com/download/

v1.50.x requires AutoHotkey version 1.1.36 or newer, but it cannot run on AutoHotkey v2. If you have AHK v2 on your system, you'll need to install v1 as well. If you already have v1 installed, you'll have to update it to at least 1.1.36 https://www.autohotkey.com/download/

Thank you so much! The was simple enough. Appreciate the quick response as well.


json::parse return value and errors

I was reading through your examples I noticed your parse error example
    try {
        json::parse(message);
    } catch (json::parse_error& e) {
        return;
    }

First I receive a compiler warning saying discarding return value with a function declared with 'nodiscard' attribute and second I wan to be able to parse the message without wrapping the entire rest of my function in the exception handler. For instance I can just parse it twice like so.
    try {
        json::parse(message);
    } catch (json::parse_error& e) {
        return;
    }
    auto packet = json::parse(message);

Once to check if there's an error and the second to store the value in packet. Then I can use the packet structure, but that isn't very efficient because I'm parsing the message twice. I also can't store the return value in an auto type outside the block scope and assign it inside the block because auto wouldn't work that way. Essentially what I'm asking is, what does json::parse return so I can declare a variable for it outside the try catch and assign it inside the try catch then check if the assigned variable is valid. And I don't know if your code allows for that functionality.

It returns json.  You can check it for is_null() outside the block.

Ah okay! Thank you.
This works fine.
    json packet;
    try {
        packet = json::parse(message);
    } catch (json::parse_error& e) {
        return;
    }


new release?

Howdie 👋
I just came by to start fixing the qt4 bug in the latest release, but then found it had already been fixed back in June by https://github.com/matplotlib/viscm/pull/57
any chance we could get a release on pypi?

Don't like to bump threads, but I recently tried to use viscm after getting a new laptop. It used to be installable with conda, but not anymore. I'd be willing to help fix up the conda-forge feedstock, but the first step is getting this released onto PyPI.
@stefanv @njsmith could you help out with this?

I would absolutely be willing to become a maintainer of this project, but I need to work out whether I can be funded to do it during work time.

No go on getting time allocated at work for this, but I'm willing to contribute to maintenance on my personal time. This is @MattF-NSIDC 's personal account (I regret having two accounts right now :laughing:).
Would you be able to provide onboarding support as I get started? I don't see any documentation or automation for releasing, so I'd like to start with automating the release process with Actions or Travis if you prefer, but I haven't used Travis much :)

I'd be happy to help with that, @mfisher87. Thanks for your willingness to help out!

Great, thanks @stefanv ! Do you have a preferred communication method for onboarding and discussing PyPI auth? Happy to join a Slack instance or Zoom or whatever works for you. Timing-wise, best for me is the weekend or weekday evenings, but have some flexibility. I live in UTC-6 and typically work until 6PM.

Either the Scientific Python discord (see link at bottom of scientific-python.org), or via email should be fine.

I've been working on getting another open-source project packaged for release for the last couple of weekends, but should be free to start looking at this this weekend. I'll hopefully see you in Discord soon :)

Thanks very much for all your work @mfisher87!

Thanks for your support :heart:

Happy to! Thank you for cmocean, they're my favorite colormaps! I'll be running a workshop for researchers with a colleague starting tomorrow, and we have a slide where we recommend them ;)

@mfisher87 Awesome! Thank you! Hope your workshop goes well.

Thank you :) So far, going great, and lots of fun. We had a module on FAIR & CARE principles today and asked our attendees to post some thoughts on GH Discussions and they shared so much interesting stuff! I'll be presenting our module on symbology tomorrow :)

v0.10 is out! Thanks to all for your patience :heart:

Now on conda-forge!


Parallel query execution

This is a psuedo-WIP PR for parallel query execution in codegen.

Sequential scans, sorting, and hash joins are currently supported. Inserts, updates deletes, and aggregations disabled.
1a. I might add parallel aggregations with the help of @mbutrovich and @dqrs.
Parallelism is done in fork-join manner.
Settings added to toggle parallel execution, and set the minimum table size threshold before parallel execution kicks in. This logic should be modified.
3a. @chenboy Check plan_generator to see if the logic looks good.
Cleaned up proxies to simplify loading/store struct member variables.

TODO:

Remove std::mutex from buffer output
Enable parallel aggregations
Add tests for memory leak

Coverage decreased (-77.3%) to 0.0% when pulling 1e70e93bbb42be2b7c0e6e75f8d29730cf937926 on pmenon:mt into d583b5f18e9853e7074ab99bcfd1e8ebc23a9a35 on cmu-db:master.

@tcm-marcel Want to get started on this review? It's quite big, so I don't want to leave it un-merged for too long.

@tcm-marcel A small final change, then it's good to go.


[MINOR] fix the warning of go mod

What changes were proposed in this pull request?

Fix the Go mod warning: google.golang.org/genproto/googleapis/rpc is required directly.
Why are the changes needed?

Does this PR introduce any user-facing change?

How was this patch tested?

Why did you change the version of the library, it looks like the commit you picked is earlier than the indirect dependency one.

Why did you change the version of the library, it looks like the commit you picked is earlier than the indirect dependency one.

I run go mod tidy in my local :)
updated now.

Thanks, merging to master.


chore(tests): verify correct bitcoin rpc is used

Followup addressing:

Can we assert in a test that the correct blockchain API is used to avoid regressions? Do you think that would be useful?

https://github.com/fedimint/fedimint/pull/5902#pullrequestreview-2254638875
I'm not a huge fan of this approach since it still relies on calling cargo nextest with --features <rpc_kind>, which may accidentally get refactored out in the future. If anyone sees a better approach or thinks this additional check isn't valuable, please don't hesitate to push back.

@bradleystachurski
I thought that maybe we'll need fedimint-cli dev get-bitcoin-backend kind of thing.

I think @Kodylow could use the local config, especially the bitcoin backend in use, exposed as an admin API route anyway, maybe that way we could use an admin CLI tool like mentioned by @dpc to fetch and check it?

Moving to draft until CI passes


Support batch session conf advisor

Why are the changes needed?

As title.
How was this patch tested?

[ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[x] Run test locally before make a pull request

Codecov Report

Merging #4731 (5cf73d1) into master (17514a3) will increase coverage by 0.01%.
The diff coverage is 71.42%.

@@             Coverage Diff              @@
##             master    #4731      +/-   ##
============================================
+ Coverage     58.03%   58.05%   +0.01%
  Complexity       13       13
============================================
  Files           580      581       +1
  Lines         32270    32307      +37
  Branches       4307     4314       +7
============================================
+ Hits          18728    18755      +27
- Misses        11739    11753      +14
+ Partials       1803     1799       -4

Impacted Files
Coverage Δ

...apache/kyuubi/session/KyuubiBatchSessionImpl.scala
84.15% <71.42%> (-2.66%)
:arrow_down:

... and 21 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Thanks, merged to master/1.7


[WIP][Distributed][Refactoring] Improvements to scheduling code

Description of changes:

Disable forkserver forcing by default
moved file utils
Extracted all resource management into managers.py
Stability improvements

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Job PR-820-1 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-820/1/index.html

Job PR-820-7 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-820/7/index.html

Tested using nthreads_per_trial=1 (all cores are used - worst case scenario with the highest probability of hanging) + time_limits=60*45. No hanging observed on multiple runs.

Job PR-820-8 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-820/8/index.html

Job PR-820-20 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-820/20/index.html

Non-deterministically hangs in text application - closing for rework


model.validate resets training metrics

System information

Have I written custom code (as opposed to using a stock example script
provided in Keras): Yes
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Linux Ubuntu 20.04
TensorFlow installed from (source or binary): Binary
TensorFlow version (use command below): 2.8.0
Python version: 3.9
GPU model and memory: Irrelevant
Exact command to reproduce: See the description

Describe the problem
The Model.validate function has a surprising side effect - it resets all metrics, including the loss. We call Model.validate in a callback to report validation metrics many times during our epochs because our epochs are long, and we just found out that we overwrite training metrics while doing so. It'd be great to either modify Model.validate to not reset metrics or to have a mechanism of saving and restoring metrics.
Source code / logs
This is the callback we that logs validation metrics every N steps. The model.validate call, apparently, resets training metrics.
class MetricsLogger(tf.keras.callbacks.Callback):
    """Logs training metrics every N steps.

    This callback can be used to log metrics more often than once every epoch,
    which allows to make the training process introspectable when epochs are
    very long and when the out of the box per-epoch logging is not enough.

    The metrics are logged to Weights and Biases.
    """

    def __init__(
        self,
        model: tf.keras.Model,
        val_ds: tf.data.Dataset,
        freq: int,
        run: wandb_sdk.wandb_run.Run,
        prefix: str = "",
    ):
        """
        Args:
            model: Model being trained.
            val_ds: Dataset to be used when calculating validation metrics.
            freq: Frequency of logging metrics, in number of batches. Logging
                too often with a large validation dataset will significantly
                slow down training.
            run: W&B run to publish metrics to.
            prefix: Prefix to prepend to metric names. If this is set to a
                non-empty value, metrics published with this callback will have
                names different from the metrics TensorFlow publishes by the end
                of each epoch. Defaults to "".
        """
        self.model = model
        self.val_ds = val_ds
        self.freq = freq
        self.run = run
        self.prefix = prefix
        self.step = 0

    def on_batch_end(self, batch, logs=None):
        self.step += 1
        if self.step % self.freq == 0:
            if logs:
                self.run.log(self._add_prefix(logs), step=self.step)

            val_logs = self.model.evaluate(x=self.val_ds, verbose=0, return_dict=True)
            val_logs = {f"val_{key}": value for key, value in val_logs.items()}
            self.run.log(self._add_prefix(val_logs), step=self.step)

    def _add_prefix(self, logs: Dict[str, Any]) -> Dict[str, Any]:
        if self.prefix:
            return {f"{self.prefix}_{k}": v for k, v in logs.items()}
        return logs

@diggerk
In order to expedite the trouble-shooting process, please provide a complete code snippet to reproduce the issue reported here. Thank you!

Here's a colab demoing the problem. It's a modified mnist tutorial that shows that when a callback is used to run model validation more often than once per epoch, training metrics are lost.
https://colab.research.google.com/drive/1-lMkaKlzK5SEba11tJ0eA-LJxFleNFxx

The comment from google-ml-butler says to reopen the issue if it needs further work, but I don't seem to have permissions to do that. Can somebody with permissions please reopen this?

@diggerk Reopening this issue as per the above comment.
Thank you!

@gadagashwini I was able to replicate the issue on colab, please find the gist here. Thank you!

Closing this as stale. Please reopen if this is still a valid request. Thank you!


"Server Feedback Command"

There should be a bot command that allows for users to send in potential feedback for server moderation purposes. Distinct from the existing suggest command as it is for more general non-bot specific purposes, and feedback goes to all moderators, versus just the bot owner. Should also be able to blacklist for abuse like the report command.
This suggestion was created by a user and sent by the bot:
jukebox-botto#8602

solved with just a thread


TaskVine occasionally doesn't run a task(?)

Describe the bug
Here's something that's come up in some work @khk-globus has done rearranging our build system, so probably caused by shaking the race-condition machine -- @dthain @tphung3
In one test run on a branch:
https://github.com/Parsl/parsl/actions/runs/7549882832/job/20555983849 with a zipfile of all the working files here: https://github.com/Parsl/parsl/actions/runs/7549882832/artifacts/1174063468
DEBUG    parsl.executors.taskvine.executor:executor.py:638 Updating Future for Parsl Task: 36.                                Task 36 has result_received set to False
...
parsl.executors.taskvine.errors.TaskVineTaskFailure: ('taskvine result: unable to process TaskVine system failure', None)

and in the working files collection, the relevant task (executor task 36 = taskvine task 37) does not have a result:
./000/TaskVineExecutor/function_data/0035/argument
./000/TaskVineExecutor/function_data/0035/function
./000/TaskVineExecutor/function_data/0035/map
./000/TaskVineExecutor/function_data/0035/result
./000/TaskVineExecutor/function_data/0036
./000/TaskVineExecutor/function_data/0036/argument
./000/TaskVineExecutor/function_data/0036/function
./000/TaskVineExecutor/function_data/0036/map

This happens:
1705460394612239 10624 TASK 37 READY generate FIRST_RESOURCES 1 {}
1705460395614276 10624 TASK 37 RUNNING worker-670a95fec2b0cbe6d1410e2aa269dce6  FIRST_RESOURCES {"time_commit_start":[1705460395.61355,"s"],"time_commit_end":[1705460395.614212,"s"],"time_input_mgr":[0.000662,"s"],"size_input_mgr":[0.008025169372558594,"MB"],"memory":[15991,"MB"],"disk":[23399,"MB"],"gpus":[0,"gpus"],"cores":[2,"cores"]}
1705460395622025 10624 TASK 37 WAITING_RETRIEVAL worker-670a95fec2b0cbe6d1410e2aa269dce6
1705460395622123 10624 TASK 37 READY generate FIRST_RESOURCES 2 {}
1705460400448987 10624 TASK 37 RUNNING worker-670a95fec2b0cbe6d1410e2aa269dce6  FIRST_RESOURCES {"time_commit_start":[1705460400.448389,"s"],"time_commit_end":[1705460400.44894,"s"],"time_input_mgr":[0.0005509999999999999,"s"],"size_input_mgr":[0.008025169372558594,"MB"],"memory":[15991,"MB"],"disk":[23398,"MB"],"gpus":[0,"gpus"],"cores":[2,"cores"]}
1705460400449272 10624 TASK 37 WAITING_RETRIEVAL worker-670a95fec2b0cbe6d1410e2aa269dce6
1705460400449394 10624 TASK 37 READY generate FIRST_RESOURCES 3 {}
1705460400449444 10624 TASK 37 RETRIEVED MAX_RETRIES  -1  {} {}
1705460400449464 10624 TASK 37 DONE MAX_RETRIES  -1

I don't know where to look further than this to understand what is happening to the task inside taskvine.
=============
In the second failure, https://github.com/Parsl/parsl/actions/runs/7549882832/job/20554640838 which does not have any downloadable log collection, I see a task failing like this, which looks similar:
DEBUG    parsl.executors.taskvine.executor:executor.py:638 Updating Future for Parsl Task: 189.                                Task 189 has result_received set to False

this is a fork of current master -  the taskvine executor code shouldn't be any different, and the cctools version used there is https://github.com/cooperative-computing-lab/cctools/releases/download/release/7.7.2/cctools-7.7.2-x86_64-ubuntu20.04.tar.gz

That sequence of events in the transaction log indicates that the task attempted to run twice.  After the second attempt, it exhausted the maximum number of retries and was returned to the caller.
@colinthomas-z80 please take a quick look at this (I think the TV debug log is the place to start) and figure out why it is failing.

The task was forsaken the first time around. This also happened to task 22 but the second time it succeeded.
It looks like the problem is in the interaction between task requested disk space, and available disk at the worker. By default a task declaration requests the whole worker disk. Each time the worker computes its disk space it is marginally smaller because of the inputs. If a task goes through the resource setup process in between these events it will request more disk than the worker has available and the task will be forsaken.
We will have to make an issue for this and think of a proper fix. You could work around this by manually declaring a disk space for the tasks such as t.set_disk(1000)

that sounds quite similar to what @dthain hypothesised was happening with Work Queue here: https://github.com/cooperative-computing-lab/cctools/issues/3593
In the parsl case, maybe this could be changing:
                t.set_disk(task.disk)

to
            if task.disk is not None:
                t.set_disk(0)

?

Yes that should do it. I'm not sure what the other issue is about just yet.


Send SendGrid logs to Splunk

Requires assistance from CDC. We are using SendGrid to email users. We should work with the CDC Splunk team to get SendGrid's logs into Splunk so CDC owns all logs managed by the application.

Hello @ronaldheft-gov I am trying to determine if is this still a priority and if so, how high.  Could you please chime in and tag other parties that need to be involved in this ticket?


Nanastria/download pdf

Implement download PDF

Include commit from prev PR

Create MIT License file
Add Description and Photo in templates

Bug :

Fail to load bootstrap to both templates

Include commit from prev PR

Create MIT License file
Add Description and Photo in templates

Bug :

Fail to load bootstrap to both templates


[MWPW-145375][Security Fix] - Moved hardcoded secrets to milo config

Description
Moved hardcoded secrets detected by kodiak in ganv-search JS files to .milo configs.
Resolves:
MWPW-145375
MWPW-145419
MWPW-144311
Test URLs:

Before: https://main--milo--adobecom.hlx.page/?martech=off
After: https://mwpw-145375--milo--deva309.hlx.page/drafts/devashish/wam?martech=off

Closing this PR.
As these are not secrets and marking these kind of issues as false positive.


SPI won't build on microbit with I2C

Describe the bug
I am trying to add additional flash memory to a BBC microbit board via its edge connector.   The flash memory is an MX25R64 chip.   After I modify the devicetree file to have both i2c0 and spi1, it doesn't recognize the flash memory when I try to build the spi_flash example.   However, if I disable the i2c0 bus and rename the spi1 bus to spi0 it does recognize the flash and compiles.  I need the i2c0 bus to get readings from the sensors, and I need the SPI bus to store data on the flash memory.
To Reproduce

Modify the microbit dtsi file to include SPI flash memory on the spi1 bus

`&spi1 {

......status = "ok";
......sck-pin = <23>;
......mosi-pin = <21>;
......miso-pin = <22>;
......cs-gpios = <&gpio0 20 0>;
......mx25r6435f@0 {
......>.......compatible = "jedec,spi-nor";
......>.......reg = <0>;
......>.......spi-max-frequency = <80000000>;
......>.......label = "MX25R64";
......>.......jedec-id = [c2 28 17];
......>.......size = <67108864>;
......>.......wp-gpios = <&gpio0 16 0>;
......>.......hold-gpios = <&gpio0 18 0>;
......};
};`

Try to build spi_flash example.   Will not build, here is the example of the error
/Users/nams/zephyrproject/zephyr/saewoo/ubit/spi_flash/src/main.c:24:2: error: #error Unsupported flash driver
24 | #error Unsupported flash driver
|  ^~~~~
/Users/nams/zephyrproject/zephyr/saewoo/ubit/spi_flash/src/main.c: In function 'main':
/Users/nams/zephyrproject/zephyr/saewoo/ubit/spi_flash/src/main.c:42:13: error: expected ')' before 'FLASH_NAME'
42 |  printf("\n" FLASH_NAME " SPI flash testing\n");
|             ^~~~~~~~~~~
|             )
/Users/nams/zephyrproject/zephyr/saewoo/ubit/spi_flash/src/main.c:45:33: error: 'FLASH_DEVICE' undeclared (first use in this function)
45 |  flash_dev = device_get_binding(FLASH_DEVICE);
|                                 ^~~~~~~~~~~~
/Users/nams/zephyrproject/zephyr/saewoo/ubit/spi_flash/src/main.c:45:33: note: each undeclared identifier is reported only once for each function it appears in
[56/120] Building C object zephyr/CMakeFiles/zephyr.dir/lib/os/mempool.c.obj
ninja: build stopped: subcommand failed.

When I disable i2c0, and rename spi1 to spi0.   It will build.

If I disable i2c0 and try to use the spi as spi1, it also fails

Impact
This is a showstopper for my project to add memory to my microbit to log data.  I have been trying to build low-cost bluetooth dongles that implement the exposure tracing protocols proposed by Apple/Google, PACT, TCN, etc..  Here is my github repo:
https://github.com/saewoonam/ble_adv_covid
Environment (please complete the following information):

OS: OSX Catalina
Toolchain Zephyr SDK
Version 2.2.99

You're missing one piece:
&spi1 {
	status = "okay";
	compatible = "nordic,nrf-spi";  /* <<< this */
	sck-pin = <23>;
	mosi-pin = <21>;
	...

The nrf51822 dtsi doesn't provide a compatible for spi1, leaving it to the user to select between nordic,nrf-spi and nordic,nrf-spis.  In other nRF51 boards this is defaulted in the board dts file; that wasn't done on microbit.
If you add that to your devicetree source it should build correctly.  Please confirm.

You may want to update to the latest Zephyr master (and to 2.3.0 when it's released later this month).  I can confirm failures against master, but the way it fails is different due to recent changes to the devicetree tooling.  I tested against master.

Great!   Thanks for taking the time to respond to my issue.   I am sorry that I am a newbie and didn't realize that I needed to add that line.  I will try to update against the new master after I see if the SPI bus actually works with a device...


Authorized User Gets No Permissions Exception When Index Doesn't Exist

Authorized user gets No-Permissions exception when index doesn't exist
Discover: no permissions for [indices:data/read/search] and User [name=admin, roles=[admin], requestedTenant=null]
...

Search Guard Version: 23.2
Search Guard Kibana-plugin version: 16
Kibana version: 6.4.1
Elasticsearch version: 6.4.1

Closing this due to inactivity


Quantstats.reports.metrics would be nice to have last date stats for Drawdown

The quantstats.reports.metrics report is quite complete. But I find myself always wanting, in addition, the current or endpoint (last day) statistics for Drawdown. Right now I have to guestimate by looking at the chart.

Hi @TraderMikeS, this is a great suggestion and I believe would provide a bunch of value for other end users who may also be guesstimating these dates. I have submitted a pull request that will enable this functionality and output results similar to that shown below (when using the quantstats.reports.metrics). If you urgently need this feel free to use the pull request submitted otherwise we can wait for this to be merged into the main branch.

Check out https://github.com/Lumiwealth/quantstats_lumi, which is being updated regularly. We are a fork of this library that is being maintained by Lumiwealth


Fix build on OPENSSL_SYS_TANDEM and older POSIXes

This should hopefully fix not just the build on NONSTOP platform but also older POSIX systems.
It also allows for passing -DOPENSSL_NO_LOCALE as a workaround to ./Configure command.
This is alternative to #18233
Fixes #18232

The master branch needs this fix as well, but it will require small tweaks. I'll create PR once this is reviewed.

@rsbeckerca Could you please test this one?

In progress. Could you include this define in the base 50-nonstop.conf after this passes?

I'm getting the following issue, on every compile, passing -DOPENSSL_NO_LOCALE to configure:
  #  define OPENSSL_NO_LOCALE
            ^
"/home/ituglib/randall/openssl-3.0/./e_os.h", line 425: warning(140): macro redefined differently

passing in -DOPENSSL_NO_LOCALE= avoids this issue.

Fixed now. Also fixed the Windows build failure.

Could you include this define in the base 50-nonstop.conf after this passes?

Why? I explicitly handle OPENSSL_SYS_TANDEM in e_os.h.

Could you include this define in the base 50-nonstop.conf after this passes?

Why? I explicitly handle OPENSSL_SYS_TANDEM in e_os.h.

A more general solution is not to hard-code TANDEM everywhere where there is an issue. I was fine putting it in 50-nonstop.conf without any other ref. But ok. I'm retesting.

At least for glibc 2.5 - which is the one on RHEL-5 it should work.

@florinspatar could you please try this patch?

This patch fixed the build on Solaris. For the other platforms, the build is still in progress.

Tests pass on NonStop.

@florinspatar could you please try this patch?

This patch fixed the build on Solaris. For the other platforms, the build is still in progress.

The build passed on HP-UX, AIX, Solaris and older Linux (RHEL5 & SLES10). I didn't tested on Windows at all.

Is there an ETA for 3.0.4?

Is there an ETA for 3.0.4?

Not at this stage.  However, given this break, soon.

The more of a mess this turns into, the less I like us dealing with locales.  I'm leaning towards reverting the original "fix" and instead assuming/requiring that the strings passed for algorithm names and properties be ASCII.
Question for OTC: should we revert the original fix and rely on applications passing us sane strings?

Also fixes #18244

The problem is not with ASCII but with a Turkish locale (and probably some other locales we are not aware of) that breaks the ASCII upper/lowercase assumptions.

@paulidale this is not at all about the compared strings being ASCII or not. They are ASCII already but the Turkish locale makes it not work for any string containing i/I.
IMO there is no way to revert this apart from providing our own strcasecmp implementation that is pure ASCII.

And given this PR fixes the problems discovered so far I would kindly ask you to remove the hold. If we later decide to do a different implementation of OPENSSL_strcasecmp() we can still do it without a complete revert.
And yeah we cannot fully revert the original fix as we cannot remove OPENSSL_strcasecmp() from the API anymore.

We've got macros that are the exact strings we want, is using them broken?  If not, it seems like a nice workaround that won't cause problems.
OSSL_DIGEST_NAME_RIPEMD160 might be broken, it has the dot less uppercase I and if spelt out as "ripemd160", it would be different in Turkish.

If we want users to be able to provide case-insensitive input, we are still broken.

Retesting this fix at commit 9a6b5c5

LFTM

Ping for second review so this can be merged once the hold is lifted. This fix needs to be done regardless of what we do with the locale initialization.

Ping for second review so this can be merged once the hold is lifted. This fix needs to be done regardless of what we do with the locale initialization.

Also @beldmit please re-approve.

My approval persists.

@t8m
Proper location of e_os.h header file is 'include/internal/e_os.h' since d5f9166bacfb3757dfd6117310ad54ab749b11f9

100% clean build/test on NonStop

Closing as the commits were merged as part of #18293


minmea working with empty RMC and VTG messages:

I realize this is not good data so if you reject this, I understand, but as it is causing me issues, I am hoping something can be done about these:

VTG sentence:   "$GNVTG,,,,,,,,,N*2E"
causes function minmea_parse_vtg() to return false.
This is because c_true is not equal to 'T'  (line #579)

RMC sentence:   "$GNRMC,,V,,,,,,,,,,N*4D"
The call to minmea_parse_rmc() passes, but the following values are set which are probably ok, but not what I expected:
latitude is NaN, not 0
longitude is NaN, not 0
speed is NaN, not 0
magnetic variation is NaN, not 0

Please allow sentences larger than 80 characters.
This 86 length string was found on the web but is rejected:
"$GPGGA,115739.00,4158.8441367,N,09147.4416929,W,4,13,0.9,255.747,M,-32.00,M,01,0000*6E"

We appreciate the feedback. It's been a while since this was opened, is the idea that these are valid strings but not being handled as they should by the library? Having some tests and pointers to the specs that confirm the intended behavior would be helpful.

We should be able to parse an empty frame, so yes, this is a bug.
This is correct behavior, NaN means "no value" while zero means "a value of zero" or empty field. Otherwise we wouldn't be able to differentiate those two cases.
We should allow redefining MINMEA_MAX_LENGTH.


bso-vote - buff gorajan stats

From: mylife
buff stats of gorajan gear by a very small amount (+3-5) so they are prioritized when using autoequip - currently they match nex so you get mismatch of gear equipped.
At time of raising
+57
-3

Please don't make github issues for bso-vote things, unless they are bugs, or OSB-related.


feat: Add Manage Warehouses Account Grant

Add MANAGE WAREHOUSES account privilege
Test Plan

[x] acceptance tests

References
Snowflake Docs

Hey @scottwinkler - any chance we can get this merged? ty!

Hi @sfc-gh-asawicki, @sfc-gh-pbosak - should be an easy approval to get into the next release? 🙏

Hey folks, any chance we merge this?
@GtheSheep, can you please rebase on the newest main so that we can run integration tests?

@sfc-gh-asawicki - updated!

/ok-to-test sha=efff173d14ae726f34735de288ed36b0920932ee

@sfc-gh-asawicki - Errors don't seem related to this change? PipeGrants/ PwdPolicy

@GtheSheep, yeah, we will be working on the stability of the tests shortly because, sadly, there are plenty of flaky ones... Let me retry them.

/ok-to-test sha=ab9bcdfbf365f2fef709755f4375779503e5d4d0

@GtheSheep merged; thanks for your contribution!


Fix jekyll installation in alluxio-maven dockerfiles

to address the following error
ERROR:  Error installing jekyll:
The last version of public_suffix (< 6.0, >= 2.0.2) to support your Ruby & RubyGems was 4.0.7. Try installing it with gem install public_suffix -v 4.0.7 and then running the current command again
public_suffix requires Ruby version >= 2.6. The current ruby version is 2.5.0
What changes are proposed in this pull request?
Please outline the changes and how this PR fixes the issue.
Why are the changes needed?
Please clarify why the changes are needed. For instance,

If you propose a new API, clarify the use case for a new API.
If you fix a bug, describe the bug.

Does this PR introduce any user facing changes?
Please list the user-facing changes introduced by your change, including

change in user-facing APIs
addition or removal of property keys
webui

alluxio-bot, merge this please


updated the about us section

Related Issue
[Cite any related issue(s) this pull request addresses. If none, simply state “None”]
Fixes:  #2511
Description
I have made the changes as commented in the issue.

Type of PR

[ ] Bug fix
[ ] Feature enhancement
[ ] Documentation update
[ ] Other (specify): _______________

Screenshots / videos (if applicable)
previously it was like below:

i solved the dropdown error
the boxes were not at a correct margin

I have corrected the margin

changed the style of the heading

the profile and switch button were overlapping

improved it

Checklist:

[ ] I have made this change from my own.
[ ] I have taken help from some online resources.
[ ] My code follows the style guidelines of this project.
[ ] I have performed a self-review of my own code.
[ ] I have commented my code, particularly in hard-to-understand areas.
[ ] I have made corresponding changes to the documentation.
[ ] My changes generate no new warnings.
[ ] I have tested the changes thoroughly before submitting this pull request.
[ ] I have provided relevant issue numbers and screenshots after making the changes.

This branch has conflicts that must be resolved
Conflicting files
assets/css/rate.css
assets/html/about.html
index.html
Create a new PR after changing new codebase!!


Remove unused import

Found by running pyflakes recursively from the repo root.

Thanks for your help and interest! :)


[ip6] enable multicast loop

This commit enables the feature IPV6_MULTICAST_LOOP into OpenThread IPv6
stack. The default-enabled feature allows a node receives a multicast
message sent by its own.

solves #openthread/ot-br-posix#610.


Issue/Observation while using Versioning and Swashbuck with IIS Deployment

@commonsensesoftware  Thanks for giving the detailed samples to work with the Versioning and the Swashbuckle. Being new to the Web API, I wasn't able to get it work correctly when we are using the IIS (It works good when we use OWIN).
Issue Description
The Swagger UI doesn't shows any of the controller methods when the multiple versions are enabled, however it works fine with single version
This is how the SwaggerConfig.cs Looks Like for the multiple versions .
var constraintResolver = new DefaultInlineConstraintResolver() { ConstraintMap = { ["apiVersion"] = typeof(ApiVersionRouteConstraint) } };
// GlobalConfiguration.Configuration.AddApiVersioning(o => o.ReportApiVersions = true);
// GlobalConfiguration.Configuration.MapHttpAttributeRoutes(constraintResolver);
var configuration = new HttpConfiguration();
configuration.AddApiVersioning(o => o.ReportApiVersions = true);
configuration.MapHttpAttributeRoutes(constraintResolver);
var apiexplorer = configuration.AddVersionedApiExplorer(o => o.GroupNameFormat = "'v'VVV");
        GlobalConfiguration.Configuration
                          .EnableSwagger(
            "{apiVersion}/swagger", c =>
                      {

                          //c.SingleApiVersion("v1", "Sample API");
                          c.MultipleApiVersions(
                            (apiDesc, targetApiVersion) => apiDesc.GetGroupName() == targetApiVersion,
                           info =>
                           {
                               foreach (var group in apiexplorer.ApiDescriptions)
                               {
                                   var description = "sample API Solution.";

                                   if (group.IsDeprecated)
                                   {
                                       description += " This API version has been deprecated.";
                                   }

                                   info.Version(group.Name, $"Sample  API {group.ApiVersion}")
                                       .Contact(c2 => c2.Name("Sample  API").Email("abc@gmail.com"))
                                       .Description(description)
                                       .License(l => l.Name("test").Url("test"))
                                       .TermsOfService("test");
                               }
                           });
                          c.OperationFilter<SwaggerDefaultValues>();

                      })
                  .EnableSwaggerUi(c =>
                      {
                          c.EnableDiscoveryUrlSelector();
                      });

The new HttpConfiguration is created as the API explorer is unable to fetch the descriptions from GlobalConfiguration.Configuration.AddApiVersioning at initialization stage. The apiexplorer.ApiDescriptions has the correct descriptions of all the versions which can be seen by putting the breakpoints.
This is how the WebAPIConfig.cs looks like :
var constraintResolver = new DefaultInlineConstraintResolver() { ConstraintMap = { ["apiVersion"] = typeof(ApiVersionRouteConstraint) } };
        config.AddApiVersioning(o => o.ReportApiVersions = true);
        config.MapHttpAttributeRoutes(constraintResolver);
        config.Routes.MapHttpRoute(
          name: "DefaultApi",
          routeTemplate: "v{api-version:apiVersion}/{controller}/",
            defaults: new { apiVersion = RouteParameter.Optional }

        );

After long hours of analyzing i was able to get if worked only by moving the code of the SwaggerConfig.cs to WebAPIconfig.cs.  The Main issue  (i think) was the fact that Apply Method of SwaggerDefaultValues is not getting called if its in SwaggerConfig.cs  but gets called if its in Startup.cs as in your example or WebAPIconfig.cs as shown below
Please let me know if this the expected behavior/Solution
Now after fixing this his how WebapiConfig.cs Looks Like
var constraintResolver = new DefaultInlineConstraintResolver() { ConstraintMap = { ["apiVersion"] = typeof(ApiVersionRouteConstraint) } };
        config.AddApiVersioning(o => o.ReportApiVersions = true);
        config.MapHttpAttributeRoutes(constraintResolver);
        //config.Routes.MapHttpRoute(
        //    name: "DefaultApi",
        //    routeTemplate: "v{api-version:apiVersion}/{controller}/",
        //    defaults: new { apiVersion = RouteParameter.Optional }

        //);
        var apiexplorer = config.AddVersionedApiExplorer(o => o.GroupNameFormat = "'v'VVV");
        config.EnableSwagger(
            "{apiVersion}/swagger", c =>
            {

                //c.SingleApiVersion("v1", "Sample");
                c.MultipleApiVersions(
                  (apiDesc, targetApiVersion) => apiDesc.GetGroupName() == targetApiVersion,
                 info =>
                 {
                     foreach (var group in apiexplorer.ApiDescriptions)
                     {
                         var description = "Sample API Solution.";

                         if (group.IsDeprecated)
                         {
                             description += " This API version has been deprecated.";
                         }

                         info.Version(group.Name, $"Sample API {group.ApiVersion}")
                             .Contact(c2 => c2.Name("Sample Tech").Email("abc@gmail.com"))
                             .Description(description)
                             .License(l => l.Name("Sample").Url("test"))
                             .TermsOfService("test");
                     }
                 });
                c.OperationFilter<SwaggerDefaultValues>();

            })
                  .EnableSwaggerUi(c =>
                  {
                      c.EnableDiscoveryUrlSelector();
                  });

I think there are a couple of things going on:

You can 100% use the Web API OWIN stack with IIS; the provided examples run in IIS Express (which is IIS with an isolated, per-user configuration).

This setup only requires Swashbuckle.Core NuGet package

When running with the legacy Application_Start event from HttpApplication, you need to use GlobalConfiguration.Configure( config => { /* all your config */ } ); as documented in Configuring ASP.NET Web API.

It's common to break component configurations into different classes and invoke them all in this callback (ex: GlobalConfiguration.Configure( c => { WebApiConfig.Register( c ); SwaggerConfig.Register( c ); } );)
If this callback isn't used, attribute routing will likely not work correctly; in other words, do not use GlobalConfiguration.Configuration directly.
This setup needs the full Swashbuckle NuGet package. If I understand what it does correctly, it dynamically injects and registers the necessary Swashbuckle IHttpModule for Swagger. I've honestly never used this approach.

It also seems that you have added a convention-based route via config.Routes.MapHttpRoute. I strongly recommend that you do not do that. Mixing attribute and convention-based routing is supported in a limited capacity, but it can be very confusing. I only demonstrate it for illustration. It is definitely not a best practice. I suggest that you choose one method and stick with it. Attribute routing tends to be easier to follow and pair with the source code, but it's your choice.
I hope that provides more context for you. Try some of those adjustments and let me know if things light up the way you expect.

Thanks for the insights . I was about to use only the Attribute based routing and will comment out the convention based routing.  For now we have two working solution one using OWIN(personally as i dont have much experience with OWIN i am reluctatnt to take this route) and one invoking the swagger in webapiconfig.cs

using  GlobalConfiguration.Configure(SwaggerConfig.Register) in the Global.asax works. Thanks. :)

Great! Glad to hear.


Reflux.Store setState issue

I'm using Reflux in ES6 style, that's Reflux.Store + Reflux.Component, everything works fine until I today changed the setState({ someState: someValue }) call in Reflux store to setState(previousState => { return { someState: someValue }; }) call.
The problem was that in the 2nd form of setState call, the value of someState got updated in Reflux.Component instead of Reflux.Store despite that I was calling it in the store.
My question is: if Reflux only supports setState calls with a object but not a function in the store.
BTW, I really need to call setState in the store to update some states in the store in order to persist them during page navigation. Please advise.

Currently Reflux stores do not have any support for the state => newState function type of state setting.
I supposed the result of that would have been it sending the actual function to the component rather than calling it for state of the store first, then sending the result to the component. Which would probably lead to the effect you're describing.
For the sake of idiomatic API, it definitely would be a good addition. So I'll add it as a planned enhancement.
However, in the mean time, as an FYI: there's no actual technical need for it. So you can move on with your project without it.
The stale-state issue that it solves in React doesn't exist in Reflux stores. React can't guarantee that state updates in a component will be synchronous, but state updates within a Reflux store are always synchronous (within the store anyway, the pushing of that state to the components still is handled by React, of course, but that's not what's relevant at the moment).
They don't have the overhead that component updates have, so there's no need to batch them or anything like React does to perform better. Therefore there's is no need to worry about stale state in a Reflux store. So you can just set the state and not worry about state being stale even if you're using current state as part of the update to the new state.
That said, I'm definitely gonna update to support the syntax...it's just plain the good idiomatic way to do it to keep it similar to React. Just saying...don't let it hold you back in your project :)


Backend: leave pretty-printing code in release builds

The original reason this was left out of release builds was to make the 16 bit compiler as small as possible. That reason evaporated 25 years ago, and it is just inconvenient to not have it there. Besides, it reduces the # ifdef hell.

Requires https://github.com/D-Programming-Language/dmd/pull/5338 in order to compile.

Auto-merge toggled on

noice


added lock command

much more functional and secure than just sleep.  You might want to spruce it some if you accept it, but it works.

@mackhankins Awesome! Thanks for your contribution.