[RuleDocGenerator] KeywordHighlighter highlights quoted strings weirdly

Just a minor annoyance I discovered in https://github.com/rectorphp/rector-src/pull/1606. The highlighter highlights quotes attached to annotations from the left:
-Remove "self" return type, add a "@return self" tag instead
+Remove "self" return type, add a `"@return` self" tag instead

I guess that might be fixed by adding ^ to the start of ANNOTATION_REGEX but that would skip "@return altogether so we might need a different tokenization approach.
It might be also useful to skip highlighting stuff already in backticks to avoid the following when one tries to work around it manually:
-Remove `self` return type, add a `@return self` tag instead
+Remove `self` return type, add a ``@return` self` tag instead

Could you create more data provider data on the following test:
https://github.com/symplify/symplify/blob/1937c3e187a884af3f4c61dad8e486d601e6c783/packages/rule-doc-generator/tests/Text/KeywordHighlighterTest.php#L31-L44
so it can be covered?

Could you create more data provider data on the following test:
https://github.com/symplify/symplify/blob/1937c3e187a884af3f4c61dad8e486d601e6c783/packages/rule-doc-generator/tests/Text/KeywordHighlighterTest.php#L31-L44
so it can be covered?

I guess the following will cover this:
yield ['adds a "@return self" tag', 'adds a "`@return` self" tag'];
yield ['adds a `@return self` tag', 'adds a `@return self` tag'];
``

Just quickly scrolling through https://github.com/rectorphp/rector-src/blob/main/build/target-repository/docs/rector_rules_overview.md reveled few more weirdnesses:

```php
yield ['Replace (clone $obj)->call() for something else', 'Replace `(clone $obj)->call()` for something else'];
yield ['@param/@return', '`@param`/`@return`'];
yield ['$value = $value + 5;', '`$value = $value + 5;`'];

And __DIR__ rendered as DIR
yield ['__DIR__ and dirname(__FILE__)', '`__DIR__` and `dirname(__FILE__)`'];

But maybe we should just give up on highlighting and backtick every code fragment manually in the doc comments.

I guess the following will cover this:
yield ['adds a "@return self" tag', 'adds a "`@return` self" tag'];
yield ['adds a `@return self` tag', 'adds a `@return self` tag'];
``

Just quickly scrolling through https://github.com/rectorphp/rector-src/blob/main/build/target-repository/docs/rector_rules_overview.md reveled few more weirdnesses:

```php
yield ['Replace (clone $obj)->call() for something else', 'Replace `(clone $obj)->call()` for something else'];
yield ['@param/@return', '`@param`/`@return`'];
yield ['$value = $value + 5;', '`$value = $value + 5;`'];

And __DIR__ rendered as DIR
yield ['__DIR__ and dirname(__FILE__)', '`__DIR__` and `dirname(__FILE__)`'];

But maybe we should just give up on highlighting and backtick every code fragment manually in the doc comments.

Thanks for exploring this topic!

But maybe we should just give up on highlighting and backtick every code fragment manually in the doc comments.

That might be also way to do, seems it's hard to handle all the cases.

Closing as accepted to avoid keep issue tracker focus on unclear issues that needs our attention.
Feel free to send PR with the failing test or feature change :+1:

Could there maybe a tag to find such issues in the future?

The search should do, we try to keep complexity as low as possible as we have limited time for maintenance.

Looks like GitHub is going to support issue close reason so that might help: https://github.blog/changelog/2022-03-10-the-new-github-issues-march-10th-update/#🕵🏽♀-issue-closed-reasons

Thanks for sharing 👍


Appium cannot find Infragistics WPF controls

Similar to problems with other UI test automation frameworks (Coded UI, etc). Searching by name or accessibility ID for items contained within Infragistics controls (such as their grid view control) does not work. Items within the control appear to not be discoverable by Appium -- the entire control is "opaque".  Inspect sees the items within the control in UIA mode, but not in MSAA mode.
Tried Appium Desktop Inspector -- controls do not show up. The entire Infragistics control is just one big "pane" element with no children.
Is there any workaround?

Hi @DanielBMann9000,
WinAppDriver is suppose to see everything that inspect.exe tool see in UIA mode. If this is not what you observe, could you please provide a simple app that we can repro the issue with?

@timotiusmargo Unfortunately, I observed the behavior with a client's application. I do not have access to the application, nor do I have a license to Infragistics controls. I will reach out to them and see if they can provide a MCVE for you.

Closing issue due to time gap.


Is this issue still valid?

This wasn't there first so resolved


Don't warn about gitignore when already correct

If the .gitignore already correctly ignores .env and /wp-config.php, then this orange notice should be hidden, and an - OK .gitignore ignores .env and wp-config.php added to the bullet list.

The environment file name is configurable, so it is currently not possible to look for it being ignored, because the "step" object does not know the actual environment file name.
I added milestone 3.0, because I already plan to make WP Starter configuration easily shareable across different steps, at that point, being the file name known, it will be possible to search for it in .gitignore content.

For v2 this is not gonna change.
For v3 I've reconsidered the creation of a gitignore step at all, my experience in 3 years usage of WP Starter has been that manually created .gitignore has worked best.
The big yellow warning has been removed completely from v3, so ther'es no reason to keep this open.
Thanks anyone involved.


nvm install --lts does not seem to work

Operating system and version:
Arch Linux 4.13.11-1-ARCH x86_64

nvm debug output:

nvm --version: v0.31.1
$SHELL: /bin/bash
$HOME: /home/platon
$NVM_DIR: '$HOME/.nvm'
$PREFIX: ''
$NPM_CONFIG_PREFIX: ''
nvm current: v9.2.0
which node: $NVM_DIR/versions/node/v9.2.0/bin/node
which iojs: which: no iojs in (/home/platon/.nvm/versions/node/v9.2.0/bin:/home/platon/.rvm/gems/ruby-2.4.0/bin:/home/platon/.rvm/gems/ruby-2.4.0@global/bin:/home/platon/.rvm/rubies/ruby-2.4.0/bin:/home/platon/.cargo/bin:/home/platon/.gem/ruby/2.3.0/bin:/home/platon/bin:/home/platon/bin:/usr/local/sbin:/usr/local/bin:/usr/bin:/usr/lib/jvm/default/bin:/usr/bin/site_perl:/usr/bin/vendor_perl:/usr/bin/core_perl:/home/platon/sync/gopath//bin:/home/platon/.rvm/bin)
which npm: $NVM_DIR/versions/node/v9.2.0/bin/npm
npm config get prefix: $NVM_DIR/versions/node/v9.2.0
npm root -g: $NVM_DIR/versions/node/v9.2.0/lib/node_modules

nvm ls output:

         v4.4.5
         v6.2.2
         v6.9.4
        v6.10.3
        v6.11.2
         v7.3.0
        v7.10.0
         v8.4.0
         v8.9.1
         v9.1.0
->       v9.2.0
         system
current -> 7.10.0 (-> v7.10.0)
default -> 8.9.1 (-> v8.9.1)
new -> 9.2.0 (-> v9.2.0)
stable -> 6.10.3 (-> v6.10.3)
node -> stable (-> v6.10.3) (default)
iojs -> N/A (default)

How did you install nvm? (e.g. install script in readme, homebrew):
curl install script from readme

What steps did you perform?
Typed nvm install --lts into terminal.

What happened?
The following output:

grep: unrecognized option '--lts'
Usage: grep [OPTION]... PATTERN [FILE]...
Try 'grep --help' for more information.
grep: unrecognized option '--lts'
Usage: grep [OPTION]... PATTERN [FILE]...
Try 'grep --help' for more information.
Version '--lts' not found - try `nvm ls-remote` to browse available versions.

What did you expect to happen?
Installation of LTS node version.

Is there anything in any of your profile files (.bashrc, .bash_profile, .zshrc, etc) that modifies the PATH?
Yes. The resulting $PATH is: /home/platon/.nvm/versions/node/v9.2.0/bin:/home/platon/.rvm/gems/ruby-2.4.0/bin:/home/platon/.rvm/gems/ruby-2.4.0@global/bin:/home/platon/.rvm/rubies/ruby-2.4.0/bin:/home/platon/.cargo/bin:/home/platon/.gem/ruby/2.3.0/bin:/home/platon/bin:/home/platon/bin:/usr/local/sbin:/usr/local/bin:/usr/bin:/usr/lib/jvm/default/bin:/usr/bin/site_perl:/usr/bin/vendor_perl:/usr/bin/core_perl:/home/platon/sync/gopath//bin:/home/platon/.rvm/bin

@Rogach you're using an outdated version of nvm; rerun the installation script from this repo's readme, and it will work.

You were right - I did run the installation script again, but forgot to reload my terminal.


Add TableSchema.diff method to understand the difference between two TableSchema objects

As a user, I wish I had an easy way to tell the difference between two Woodwork TableSchemas.

When passing around Woodwork dataframes, it is easy to lose track of some of the woodwork types, like feature origins or metadata, and because the table schema repr only shows column names, logical types, and semantic tags, it is hard to tell if other woodwork typing info has changed without going through all the relevant fields and directly comparing. It would be great if there was a Woodwork method to make this easier.
Code Example
schema_1.diff(schema_2)

We would need to come up with a design for what the output could be, but we could go as simple as just displaying all fields that are not equal and outputting the entire value, leaving it up to the user to determine what exactly is different. A more involved option would be to isolate the difference and display that specifically.
For consistency's sake, we should use this function to implement the TableSchema.__eq__ method, which will make sure that these two always stay in sync.

@tamargrey What is the urgency of this issue?


Show stops when selecting  a train

When you've researched a route, you can't show the stops, which can be handy to remember when to get off.

@pietercolpaert This looks awesome to add. What is your opinion?


Parse resource and persist to existing EIP model

As we use parsers to build an in-memory model for comparing with original design, we'd like to allow this in-memory model to be merged and persist into an existing one. This will open the way to migration scenarios where you are using EIP tooling to migrate from one technology to another while retro-documenting existing resources.

Done!


Missing calc mod?

After I grabbed the most recent beta version, I noticed that calc mod was missing. It didn't strike me as a significant problem, but I wasn't entirely certain whether this omission was deliberate or not. I find the mod to be quite handy!

oops, no that is not intentional. I will fix this in the bug fix release in a couple days, thanks for the report.

Fixed in commit #9f9815a


找不到可与此代码版本兼容的 evermonkey 版本。

VSCode: 1.8.1 (node 6.5.0)
evermonkey: 1.2.8
VSCode will report error as above message "找不到可与此代码版本兼容的 evermonkey 版本。"
Do i need to upgrade VSCode to latest 1.10.xx ?

Yes, evermonkey is developed based on the VS Code engine v1.10.0.

Appreciate your kind comments, I shall upgrade my CODE to latest 1.10 to taste this nice extension.

May I close this issue?


Low validity on moses3 dataset

Dear authors,
I tried to train the model with default parameters on moses3.csv dataset, then generate with the trained model. However, the validity that I achieved is 0.868, which I think is much smaller than 0.994 as you mentioned on the paper.
python train.py --run_name unconditional_moses --data_name moses --num_props 0
python generate.py --model_weight moses_nocond_12layer.pt --csv_name sampled.smiles --data_name moses

Do you have any suggestion for solving this problem? Or can you provide any hints on how to improve this validity. Thanks!

BTW, why do you use LSTM for scaffold embedding, rather than a linear embedding with position embedding?
For me, the usage of LSTM here feels very strange. If you can use LSTM for scaffold, why not use for all the inputs?

I'm not sure we can point out the problem straight up like this, have you tried using the pretrained weights for generation? LSTM was used to represent the scaffold with a single vector, more for convenience than anything. To take advantage of the transformer architecture we need to use linear and positional embeddings for the main molecule.;


New gallery item detail 3.0

We've had a quick designer session to knock some bugs out

Align description with JPEG
put padding inside, probably same as actions?

put on same level

#955 plus link facts there as well under price chart as we assume no one is checking it but keep it for someone
#957 show only when you can do something with nft
#956
#990 will be done separately
Store folded preferences in Vuex so whenever you open another detail it would have a state of current one
Contextual NFTs should be foldable as well.
Default, price chart, history chart and contextual nfts should be folded
Mind that Collection, Creator was moved under price

Currently @MiracleCorunus is working on this
I guess we should have a separate interface for

creator
collector

As it's different personas.

Let's start with collector one, an important one for us.
Merge Price box with Actions if it's for Collecting and not the owner of NFT
When creator, showing rest buttons would work in the same place.
Put it in a place where is an existing action component is, price on the top.
Sharing under the same place. Check #1063 #1082 done by @roiLeo
The history chart should be full width.

Added test case https://deploy-preview-1134--nftkodadot.netlify.app/rmrk/detail/7479313-7a147cba01afccbf17-GA-GENERATIVE_ASTERISM_23-0000000000000023

Continue to #1209


Local development issues

Following the instructions in README.md I installed hyperline locally. Whenever I start hyperterm or refresh the window I see the following error: Uncaught TypeError: Failed to execute 'removeChild' on 'Node': parameter 1 is not of type 'Node' on line 134 of index.js. This is triggered because this._canvas is null. Doing some debugging I found out _onTerminal is not triggered. Did you see this before?

Hey @timneutkens  - that is definitely strange. I'll take a look and see if I can replicate this.

I just removed my local development version and reinstalled it again - I didn't get any errors.
First, I ran:
cd ~/.hyperterm_plugins/local/
git clone https://github.com/NickTikhonov/hyperterm-hyperline.git
vim ~/.hyperterm.js

Then I added "hyperterm-hyperline" to localPlugins:
 localPlugins: [
    "hyperterm-hyperline"
 ]

I'm on the latest version of HyperTerm, and have no other plugins installed. It might be useful if you could list all other plugins you have installed :)

should note that when I add it to plugins everything is fine, just removed all plugins. Now it seems to function properly 👍 just have to figure out which plugin is killing it. I have these 'hypercwd', 'hyperterm-atom-dark', 'hyperterm-1password', 'hyperterm-blink'

hmmm that's just plain weird. Removed all plugins, restarted, added them back one by one. Everything was fine. Updated all plugins. Now it's all functioning properly. Thanks Nick!

No problem, glad it worked in the end  👍


test-branch/execute-job/quoted-authorization/7b84ddb8-d7dc-4311-83f4-1e9178f1746e

PR for testing dc557122e04c08d1acc7de4d3f3d1ddd5bce5d15

/canonical/self-hosted-runners/run-workflows dc557122e04c08d1acc7de4d3f3d1ddd5bce5d15


Improve logic to extract identifier names

Description
Previously, the logic to extract original identifier names from query string was
not proper and could not handle the identifiers with special characters or object
name being prefix of schema name. This logic was there to extract original table
name and original function/procedure name from the query and due to this issue,
we were storing wrong original names.
Implemented helper function extract_multipart_identifier_name which improves
the logic to extract original name from a multi-part identifier in a query string taking
care of spaces or possibly quoted identifier. It internally uses extract_identifier
function to extract individual parts of an identifier.
Additional fixes:

Fixed sp_rename to properly handle rename of a table so that it also updates the
underlying original table name (bbf_original_rel_name).
Fixed helper function babelfish_sp_rename_word_parse which is used by sp_rename
to split multi-part identifier names. Previously, it was using string_split() for the splitting
which could not handle the quotes or special characters. Implemented helper SQL function
babelfish_split_identifier which is mostly a wrapper over split_object_name C function
to correctly split multi-part identifiers.
Updated logic to fetch original table_name/column_name in sql views information_schema_tsql.columns_internal
and information_schema_tsql.tables so that they don't assume that bbf_original_rel_name
or bbf_original_name is always the first option in reloptions and attoptions list respectively,
instead now the logic is to iterate over the whole list and search of the desired option.

Task: BABEL-5089
Signed-off-by: Rishabh Tanwar<EMAIL_ADDRESS>Test Scenarios Covered

Use case based -

Boundary conditions -

Arbitrary inputs -

Negative test cases -

Minor version upgrade tests -

Major version upgrade tests -

Performance tests -

Tooling impact -

Client tests -

Check List

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

82 of 84 (97.62%)  changed or added relevant lines in 5 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.02%) to 73.23%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

contrib/babelfishpg_tsql/src/hooks.c
30
31
96.77%

contrib/babelfishpg_tsql/src/procedures.c
18
19
94.74%

Files with Coverage Reduction
New Missed Lines
%

contrib/babelfishpg_tsql/src/procedures.c
1
88.41%

Totals

Change from base Build<PHONE_NUMBER>:
0.02%

Covered Lines:
42931

Relevant Lines:
58625

💛  - Coveralls


Adding font-size vars for consistent sizing

Adding font-size vars for consistent sizing
Additions

Added new variables matched to the corresponding heading level.

Changes

Updated heading-# mixins to use new variables in place of px values.

Testing

Source locally with npm link and build your project, headings should all be the same size.

Review

@KimberlyMunoz
@Scotchester
@cfarm
@contolini

Notes

Now easier to use font-sizes without exposing the @font-size var.
Naming based on http://csswizardry.com/2012/02/pragmatic-practical-font-sizing-in-css/.
Adds @size-giga, @size-mega, @size-milli, @size-micro for future use.
Fixes cfgov-refresh #1387

Checklist

[ ] Changes are limited to a single goal (no scope creep)
[ ] Code can be automatically merged (no conflicts)
[ ] Code follows the standards laid out in the front end playbook
[ ] Passes all existing automated tests
[ ] New functions include new tests
[ ] New functions are documented (with a description, list of inputs, and expected output)
[ ] Placeholder code is flagged
[ ] Visually tested in supported browsers and devices
[ ] Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)

I don't know that I love that naming scheme, even after reading the well reasoned article on it. I need to stew on it.

My biggest support of it, is there are times a mockup or discussion will reference text as say an H4, but only mean the size, not the weight change (like the lead paragraph). Separating the sizing names from the rest of the heading styles will help break that confusion.

How come there’s a mix of metric prefixes and not? Could you use metric prefixes across the board? That might be more familiar https://en.wikipedia.org/wiki/Metric_prefix

I'm on board with that approach as well. Whatever gets us discussing sizes and heading styles distinctly works for me.

Would something like roman numerals work better so we still have a little obfuscation to show this doesn't have the responsive behavior of the h[1-6] classes, but developers don't have to memorize a new number scale to find the right font-size variable?

I dig it, updated.

You didn't update the vars in cf-base.less.
How about size-lg for the superheading font size variable? So it's not misinterpreted as Roman numeral 50, or as Arabic numeral one.

P.S.: I like the Roman numeral approach.

What in the world? I updated cf-base, no idea why it didn't push through because it's updated locally. Will figure that out, but in the mean time, l was intentional as 50, because it's crazy high. Is x better so we stick to the naming convention we've chosen?

@jimmynotjim The problem is that the Roman numerals grow larger as the size decreases. L would seem to indicate 1px type ;)

Ah, right, I hadn't thought of that. Updated to xl because it should be clear it's giant.

:+1:


Adding ipyfilechooser to conda-forge

It would be nice to have this package available on conda-forge. Here is the instruction to add a package to conda-forge. I can help in this regard if needed. Thanks.

@crahan I have creatred the meta.yaml for you. This was created using conda skeleton pypi ipyfilechooser with some additional edits. You just need to fork conda-forge/staged-recipes and add a ipyfilechooser folder with the meta.yaml and LICENSE to the recipes folder. Submit a pull request and wait for the review and approval.

That's awesome. Thank you! I'll try and get a pull request out as soon as possible.

Working on it now. I'll post an update once the PR has been submitted.

Here we go: https://github.com/conda-forge/staged-recipes/pull/11297

@crahan Thanks for your prompt action. I saw that the pull request has been merged. It should be available on conda-forge soon. It might take a few hours. Congrats!

Thank you for the suggestion and the help on this!


Refusal to takeoff

Im getting sometimes, aircraft which wont budge from Waiting to takeoff, even if cvs or an altitude command has been given.

@dutchdavey could you provide a few more details?

What browser were you using
What airport
Did you taxi the aircraft to a specific runway or just use taxi
Was the runway valid
Did you see any errors in the DevTools console
Did the sim freeze afterwards
Did this happen early in the sim or only after playing for a while
Can you reproduce this (and if so, what are the steps to reproduce)

Chrome
SFO
taxi
I don't know, in any case the aircraft remain unuseable.
I dont know where that is, let me know and Ill check..
No, sim continues to work, but the aircraft are unuseable
Playing for a while
I'm still trying to reproduce it reliably

Ive got 4 stuck at waiting right now.

Coulld it be related to a performance issue on a slow PC? Timeouts maybe?
this laptop slowa appallingly once the sim has been running for some time.

Hmm.  Do you still have the same problem if you taxi one aircraft, then clear it to takeoff?  Do you get the same problem with all the aircraft waiting to takeoff?  My guess is you are trying to clear an aircraft that is not first in line.
That console error suggests it could be a different issue, though.

just running through it quick I am unable to reproduce your issue, even after taxiing several aircraft and clearing them out of order.
The decreased performance is likely due to drawing the projected routes for all aircraft.  That takes a lot of work to do, and the more aircraft the more power it needs.  That will be improved in the future.

I don't think its to do with a takeoff queue. As I said, once it happens, the affected aircraft won't take off, none of them, even if you wait a half hour.. I still have the same four waiting at the moment..

If you have the sim still paused, try and delete all the departures (or at least the ones that are stuck).  You can do that by issuing a delete command: CALLSIGN del.
That will completely remove an aircraft from the sim and should clear the present log jam.
I'm more concerned with how you got to that spot.  I haven't been able to reproduce this issue at all in any of our environments.  Any additional information you can provide, or steps leading up to the issue, would help immensely in trying to spot where this is coming from.

I decided at some point to use the command 'caf taxi' to get the aircraft to the takeoff runway, and then to use 'a 2 to' or 'a 3 to' or 'cvs to' to get them in the air, depending on the traffic. It seems, though I'm not sure, that this is where the anomaly started to appear.

That doesnt seem to be relevant either, alas. I still get it with 'caf cvs taxi' followed by 'to'.

@dutchdavey I am still unable to reproduce this.  Could you give it a try here: http://atc-dev.herokuapp.com
That is running my current develop branch and, in a few weeks, will be the next version released.
If you still get this error there, please provide a list of commands you used to cause the error.  I am unable to reproduce this error by running the commands above.

will do..

I had this problem too, and I'm also using Chrome.  It can happen even if only issuing the 'w' or 'taxi' command to a single aircraft and not creating a queue.  Because of the other bug where a landing arrival will cause a waiting departure to disappear, I have been making sure to only tell a flight to taxi when no arrivals are close to landing, and this issue where a flight will appear to taxi but won't take off happens.  Usually when I see it, the plane won't appear on the screen even.  And I was playing at a different airport than dutchdavey by the way.  I will also try this on the dev branch linked above later tonight.

@n8rzz
I played for over 30 min. on timewarp 5 on LKPR on your development branch and could not replicate this issue there either, and I really tried to make it happen.   Maybe one of the fixes for the other bugs also addressed this?   I must say it was nice to play without worrying that waiting departures would disappear if another plane landed, or that every plane would change to heading 360 at the end of their assigned routes all the time.  :-)   Can't wait for 3.2.1 to merge to fix these issues.

@scott-j-smith  Thanks for taking a look!  I'm glad to hear you were not able to replicate.  This feels like a sneaky issue and I'm not totally convinced that it is fixed in develop.
Perhaps there is a race condition somewhere?  Perhaps this is a side effect of a completely different issue?  I don't know.  I'd love to say the glitch is gone, but I know better 😉
@dutchdavey did you have any luck reproducing in our develop env?

No, I couldn't reproduce it either on development.
Looks to me like a classic automagical fix!

I have actually come across the same issue.
Running in any of the airports...
Mac using Safari
Multiple aircraft appear "waiting" and refuse to do anything.
It occurs when, you have used "Taxi" to a runway and they are "waiting" for "takeoff".
If a arriving aircraft lands, at the moment it is cleared and "contacting ground" appears, all aircraft on the airport waiting are partially removed (radar tag), whilst the strip remains.
Perhaps something is clearing all traffic on the airport instead of just the aircraft that has landed.

hmm, thanks @scott-j-smith!  Could you open an issue in my fork for that (with that screenshot)?  That looks like it could be a side effect from one of the features completed this sprint.
re: @erikquinn

@n8rzz
Done!

@matt5611:
It occurs when, you have used "Taxi" to a runway and they are "waiting" for "takeoff".
If a arriving aircraft lands, at the moment it is cleared and "contacting ground" appears, all aircraft on the airport waiting are partially removed (radar tag), whilst the strip remains.

@scott-j-smith:
@matt5611 I think that is a different bug that I reported earlier too. The bug discussed in this issue is not related to the case where an aircraft lands and the waiting plane is removed from radar and then can't take off.

I concur with @matt5611. This is almost definitely a similar symptom to that described in #770; both symptoms are resolved following n8rzz/atc#241. This also explains why it is broken at zlsa/gh-pages, but working at n8rzz/develop. When #776 (v3.2.1) is merged, this will be resolved.


Task :react-native-share-menu:verifyReleaseResources FAILED

Task :react-native-share-menu:verifyReleaseResources FAILED

FAILURE: Build failed with an exception.

What went wrong:
Execution failed for task ':react-native-share-menu:verifyReleaseResources'.

A failure occurred while executing com.android.build.gradle.tasks.VerifyLibraryResourcesTask$Action
Android resource linking failed
ERROR:E:\React TEST1\test8\earthid_2.0_mobile_app\node_modules\react-native-share-menu\android\build\intermediates\merged_res\release\values\values.xml:2717: AAPT: error: resource android:attr/lStar not found.

@praveenr7 I have the same error. Were you able to resolve this?

use this patch:
index 9557fdb..ebdeb6f 100644
--- a/node_modules/react-native-share-menu/android/build.gradle
+++ b/node_modules/react-native-share-menu/android/build.gradle
@@ -1,12 +1,12 @@
 apply plugin: 'com.android.library'

 android {
-    compileSdkVersion 29
-    buildToolsVersion "29.0.2"
+    compileSdkVersion 31
+    buildToolsVersion "31.0.0"

     defaultConfig {
-        minSdkVersion 16
-        targetSdkVersion 29
+        minSdkVersion 21
+        targetSdkVersion 31
         versionCode 1
         versionName "1.0"
         ndk {

Had the same issue, can confirm @kingajohanna's patch fix my build


walproposer hangs if single safekeepers hangs

Steps to reproduce
Run a single safekeeper that accepts new connections and accepts new messages, but doesn't reply with any messages. Other 2 safekeepers should be healthy. Run postgres --sync-safekeepers and it will stuck.
For example, this happened in https://github.com/neondatabase/cloud/issues/2426 because we had a deadlock (#2566) and timelines became locked when they tried to persist something to disk. This made safekeeper read new messages without replying back.
Expected result
walproposer requires only 2 working safekeepers to finish --sync-safekeepers. It also should drop connection to safekeeper if it doesn't receive new messages for some time (~5 seconds).
Actual result
postgres --sync-safekeepers doesn't exit

Hi @petuhovskiy, so i did a little test on my computer trying to replicate that scenario:

Manually provoke a deadlock on PhysicalStorage to avoid writing to disk in only one safekeeper.
Modify test_sync_safekeepers to do append_logical_message in background just to avoid the exception because of the previous deadlock.
Run the test and i see that hangs on sync_safekeepers, great!
With gdb i can check that one safekeeper is stuck in epoll_wait coming from WaitEventSetWait with SS_HANDSHAKE_RECV state, and this state cannot move forward.

So at the end i modified WalProposerPoll:
for (int i = 0; i < n_safekeepers; i++)
{
	Safekeeper *sk = &safekeeper[i];

	if ((sk->state == SS_CONNECTING_WRITE ||
		 sk->state == SS_CONNECTING_READ ||
                  sk->state == SS_HANDSHAKE_RECV ) && /* <------------------ I added this line */
		TimestampDifferenceExceeds(sk->startedConnAt, now, wal_acceptor_connect_timeout))
	{
		elog(WARNING, "failed to connect to node '%s:%s': exceeded connection timeout %dms",  sk->host, sk->port, wal_acceptor_connect_timeout);
		ShutdownConnection(sk);
	}
}

And now the conn gets dropped and the test does not get stuck.
So i am a new in this repo and is possible that everything i said i'm wrong, if so, excuse me. Let me know what you think please, thanks!

Hi @andresrsanchez! You got the idea right. Your fix works if safekeeper is stuck in SS_HANDSHAKE_RECV state and fixes the original issue. But I'd try to create a general fix, which will also work if safekeeper will be stuck in any other state.
The idea for a general fix is to track timestamp of the last received message from the safekeeper. If we are connected to a safekeeper from which we have not received a message in the last 5 seconds, then we can disconnect from it by timeout. It should work because we have a logic to send a message every second between compute and safekeeper.
It's actually not very different from your patch, you can try to open a PR with the proposed general fix.
P.S. We also have another issue here:

walproposer requires only 2 working safekeepers to finish --sync-safekeepers.

In theory, we got 2/3 responses from the safekeepers and we could finish the sync immediately – then we wouldn't have hanging sync. But right now we are waiting for all alive safekeepers and this issue is a bit harder to fix properly, we should come back to it later.

done


bugs-tab is too slow

Sometimes bugs-tab doesn't appear and more often than not it doesn't seem to be cached:

Reload this issue
Notice that the bugs tab is never instant

Strangely, the count is definitely cached.
Originally posted by @fregante in https://github.com/refined-github/refined-github/issues/6469#issuecomment-1500218721

Related:

https://github.com/refined-github/refined-github/issues/6293

I don't know if I'm just too sensitive to 40ms, but this is what I'm seeing by sprinkling some logs in bugs-tab and one in repo-avatars, which is "fast". It feels like the browser is lying to me

And this is what it looks like:
https://github.com/refined-github/refined-github/assets/1402241/9a4852de-02f9-4254-96d9-fa96b2e8ed53


Unified API for storage proposal

As titled

release as GRIN project in https://github.com/graphscope/grin


Keep track of number of inodes

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/2304/
Test FAILed.

Merged build finished. Test FAILed.

Jenkins, test this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/2310/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/2311/
Test PASSed.


Expose all torch.distributed.init_process_group parameters in the DistributedManager

Modulus Pull Request
Description

Adding kwargs to DistributedManager.initialize to pass down to torch.distributed.init_process_group. Added a test to specifically check that the timeout parameter gets passed down to torch.
Checklist

[x] I am familiar with the Contributing Guidelines.
[x] New or existing tests cover these changes.
[x] The documentation is up to date with these changes.
[x] The CHANGELOG.md is up to date with these changes.
[ ] An issue is linked to this pull request.

Dependencies

None

How does it behave if you pass a kwarg which has already been passed explicitly, for example rank or world_size? Will that overwrite the previous one?

That's a good point. Maybe should pop the explicitly specified kwargs out before passing them down?

@akshaysubr do we want to merge this PR before the release?

@mnabian Yes, we should merge this before the release. This is a fairly low risk PR I think but exposes certain mechanisms for more advanced usage. I think we can merge this as is and add other functionality that come up in subsequent PRs.


Bump/jetbrains 2<IP_ADDRESS>

Bump jetbrains IDEs to latest:
    jetbrains: 2024.3 -> 2024.3.3

    jetbrains.aqua: 2024.3 -> 2024.3.1
    jetbrains.clion: 2024.3.1 -> 2<IP_ADDRESS>
    jetbrains.datagrip: 2024.3.2 -> 2024.3.3
    jetbrains.dataspell: 2024.3.1 -> 2<IP_ADDRESS>
    jetbrains.idea-community: 2024.3.1 -> 2<IP_ADDRESS>
    jetbrains.idea-ultimate: 2024.3.1 -> 2<IP_ADDRESS>
    jetbrains.phpstorm: 2024.3.1 -> 2<IP_ADDRESS>
    jetbrains.pycharm-community: 2024.3.1 -> 2<IP_ADDRESS>
    jetbrains.pycharm-professional: 2024.3.1 -> 2<IP_ADDRESS>
    jetbrains.ruby-mine: 2024.3.1 -> 2<IP_ADDRESS>
    jetbrains.rust-rover: 2024.3.1 -> 2024.3.2
    jetbrains.webstorm: 2024.3.1 -> 2<IP_ADDRESS>

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Thanks!
#366290 should be merged before and then you should re-run the plugin update script to make sure plugins for source builds are also up-to-date


cli: add env var for esm config

Allows loading ESM config in CLI

[x] Read and sign the [CLA][1]. PRs that haven't signed it won't be accepted.
[x] Make sure your PR complies with the [writer's guide][2].
[ ] Review the diff carefully as sometimes this can reveal issues.
[ ] Do not abandon your Pull Request: [Stale Pull Requests][3].

yeah makes sense to separate them

/cc @chenxsan


Run controller e2e test with Contour

This patch adds Contour to e2e test.
Also this patch moves the directories/files to add more ingress as:

Add contour gateway config files to third_party/contour-head/gateway/
Move istio specific config from config/* to third_party/istio-head/gateway/
Add e2e and conformance test script to test/kind-{e2e,conformance}-<INGRESS_NAME>.sh
Drop istio/contour specific test map in test/conformance/ingressv2/run.go. (They skip unsupported test by --skip-test now).

/cc @markusthoemmes @ZhiminXiang @carlisia


Wrong text color for light button

node, npm, react-native, react and native-base version, expo version if used, xcode version
node: 13.8.0
npm: 6.13.6
react: 16.9.0
react-native: sdk-36.0.0
expo: 36.0.0
native-base: 2.13.8
Expected behaviour
The text color for the light button should be darker
Actual behaviour
The text color for the light button is white
Steps to reproduce
Just rendering a light button
Is the bug present in both iOS and Android or in any one of them?
This is happening in both platforms
example

code repo with code example
https://github.com/cruzlutor/error-button-sample
Related issue: https://github.com/GeekyAnts/NativeBase/issues/2204
I tried to wrap each Button in a View element, same result
thanks in advance

Hi @cruzlutor , latest version of Native base has been released. The issues should be fixed now.
Native Base 2.13.12


tCounter not showing for "iframe" type in galleries

For example, say I have a gallery setup like this:
JS:
$('.gallery').magnificPopup({
    delegate: 'a',
    gallery: { enabled: true }
});

Markup:

  Open popup 1
  Open popup 2
  Open popup 3

This works great as a gallery of mixed types with navigation arrows allowing you to switch between items, however only the "image" type displays the tCounter element in the bottom right corner (i.e. 1/3, 2/3, etc).

... still works 11+ years later!


JavaScript: The docs website logo does not appear in the correct size

Issue type: Bug fix
Complexity: Easy
Issue description:
OpenEBS docs site https://docs.openebs.io/ has a logo on the top left corner. The mule logo and the text in the OpenEBS Docs are created as one image. Because of this, the mule logo is not appearing as one image.
We probably need to split this into two images, One with just the Mule whose height can be more than the other image (OpenEBS Docs). This probably needs changes to JavaScript to support more than one image as part of the header logo or any other solution.

i can work on this

Since you suggested splitting the images into two. How do i get them? Also whats the Js file for the site?

Hi @OPARA-PROSPER, Thanks for picking up the issue.
The logo is a header icon whose path is defined in siteConfig.js.
You can find the image in static directory.
HeaderIcon implementation is residing in HeaderNav.js and feed.js files.
If you have any further query, please let us know.
You can also join hacktoberfest2018 channel on our slack workspace.

The link prompts me to login instead of registering. Can you please check it out

@OPARA-PROSPER I've updated the link.

@OPARA-PROSPER  You can use these images for the header icon.
OpenEBS logo
OpenEBS Docs logo

@Akash4927 Hey can I take this one?

I would like to submit a PR for this issue, @Akash4927 !

Is this issue still open?

I have submitted work on this issue, @anuragsachdeva28

Hi @brute4s99 . Thank you for making the appropriate changes with OpenEBS logo. PR #368 has been merged.


Document which credential types have built-in token caching

The Azure Identity library's README doesn't indicate which credential types have built-in token caching. Customers must read each credential type's code to figure it out. This info should be available at Credential classes. Consider adding a "Built-in token caching?" column to each of these tables.

Fixed in https://github.com/Azure/azure-sdk-for-python/pull/30090


Support for GUID

#191

Hi @RonFrick, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla2.dotnetfoundation.org.

TTYL, DNFBOT;

@RonFrick, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.
Thanks, DNFBOT;

@RonFrick closing this as this PR doesn't include any changes. You'll need to send a PR from your fork.


v1.1.0rc1 on windows: cmake generators for Visual Studio missing?

under v1.1.0rc1 latest, the cmake generators for Visual Studio don't appear to be available.
$ cmake .. -G"Visual Studio 16 2019" -A x64
CMake Error: Could not create named generator Visual Studio 16 2019

Generators
* Unix Makefiles               = Generates standard UNIX makefiles.
  Ninja                        = Generates build.ninja files.
  CodeBlocks - Ninja           = Generates CodeBlocks project files.
  CodeBlocks - Unix Makefiles  = Generates CodeBlocks project files.
  CodeLite - Ninja             = Generates CodeLite project files.
  CodeLite - Unix Makefiles    = Generates CodeLite project files.
  Sublime Text 2 - Ninja       = Generates Sublime Text 2 project files.
  Sublime Text 2 - Unix Makefiles
                               = Generates Sublime Text 2 project files.
  Kate - Ninja                 = Generates Kate project files.
  Kate - Unix Makefiles        = Generates Kate project files.
  Eclipse CDT4 - Ninja         = Generates Eclipse CDT 4.0 project files.
  Eclipse CDT4 - Unix Makefiles= Generates Eclipse CDT 4.0 project files.

reference: https://xgboost.readthedocs.io/en/latest/build.html#compile-xgboost-with-microsoft-visual-studio

@glycerine It looks like CMake on your machine cannot find instance of Visual Studio. We cannot produce this problem on our end: https://xgboost-ci.net/blue/organizations/jenkins/xgboost-win64/detail/release_1.1.0/2/pipeline/37#step-43-log-5

Sorry but I don't think that's a XGBoost issue.  Closing but feel free to re-open if there's anything we can do about it.


Split and global state

Previous discussion: https://groups.google.com/d/msg/elm-dev/n9EwDQeFU5I/joCIYE8qBQAJ
@mgold wrote

Regarding splitting: PCG has 64 bits of state, and a 63-bit "incrementer" (it's always odd) that indicates which of the 2^63 possible PRNG sequences you are on. So, no need to figure out how to mix some history of splitting into the RNG, you just change the incrementer. And for a pure implementation, you've got the right idea: keep track of your position in the binary tree and map that onto the space of incrementers. The problem is that you can only split a seed 63 times then. And, adjacent incrementers provide nearly-identical results. (Essentially, each time you split, you divide the space of possible incrementers available to that seed in half, one for each new seed, so they don't run over each other.)
I've implemented split, but it's impure. Basically there's a piece of shared state that tracks how many split have occurred (plus one), and when you want to do a split, it adds that number to the more significant half of the incrementer, so they're far apart. Then it steps each seed to the next value (in testing, it worked better). Even as implemented you could split a few million times and be fine. Why do I think it's okay to do this in an impure way? The only way you'd notice is if you called split on the same seed twice, and you're not supposed to do that. Seeds are opaque, so you're not supposed to inspect or equate them. The implementation is still deterministic; any program can be rerun with identical results. And, as I just described, I don't think it's acceptable to do this in a pure way since it limits the number of splits to something you could conceivably hit.

I think it's probably a mistake to implement split with global state. Because Elm is single threaded, I think it's probably true that running the same program twice (with all the same event inputs, of course) will return the same output, but you might still have situations where changes to the program that seem like they should leave its output the same actually don't.
The idea of hashing the binary tree position is so that you are less likely to hit the same incremeter value even if you split more than 63 times. This is essentially what hashing is always for: to reduce the likelihood of collisions when you are mapping a sparse subset of some large set into some smaller one.

I'll have to mull over exactly how hashing the tree position would work (pointers appreciated), but if it can work, I'm not opposed. Especially since that would open the door to porting this to Elm proper, which means I could publish it, assuming the perf falloff isn't too bad.

You might still have situations where changes to the program that seem like they should leave its output the same actually don't.
Yes, if I have a component that does a split, and the programmer adds a call to split upstream, the result changes. But it's also splitting a different seed, so that would happen anyway, right? Again, I think it's only possible to observe the impurity if you reuse seeds.

I've pushed a version implemented in Elm. It takes 10 seconds to generate 720000 random numbers; the Native implementation takes 9. So not too bad. (The core implementation also takes around 10 seconds.)
I understand it's Thanksgiving, so this might get punted to next week on my end if not yours, but I'm interested in how you'd do a good pure split.

I'm mulling it over, but I don't know what to say yet.
On Wed, Nov 25, 2015 at 1:12 PM Max Goldstein<EMAIL_ADDRESS>wrote:

I've pushed a version implemented in Elm. It takes 10 seconds to generate
720000 random numbers; the Native implementation takes 9. So not too bad.
(The core implementation also takes around 10 seconds.)
I understand it's Thanksgiving, so this might get punted to next week on
my end if not yours, but I'm interested in how you'd do a good pure split.
—
Reply to this email directly or view it on GitHub
https://github.com/mgold/elm-random-pcg/issues/1#issuecomment-159691244.

So here's a dumb idea: what if we just pulled random numbers to create the second seed. According to this post (good but long read), you can draw n numbers from a psuedorandom source and consider it to be random is the period is >n^2. Since the period is 2^32 and we'll be splitting only dozens of times, this should be fine, right? But I'm skeptical since such a strategy could work for the standard library, in which case wouldn't it have been done already?
I also implemented Random.PCG.Interop.fission on a similar principle.

Yeah, in some ways that seems like the "obvious" answer, and I don't
understand why it isn't ok, if it isn't.
On Thu, Nov 26, 2015 at 12:13 PM Max Goldstein<EMAIL_ADDRESS>wrote:

So here's a dumb idea: what if we just pulled random numbers to create the
second seed. According to this post
<EMAIL_ADDRESS>(good but long read), you can draw n numbers from a psuedorandom source and
consider it to be random is the period is >n^2. Since the period is 2^32
and we'll be splitting only dozens of times, this should be fine, right?
But I'm skeptical since such a strategy could work for the standard
library, in which case wouldn't it have been done already?
I also implemented Random.PCG.Interop.fission on a similar principle.
—
Reply to this email directly or view it on GitHub
https://github.com/mgold/elm-random-pcg/issues/1#issuecomment-159962084.

If you implemented split in core as let (i, seed') = generate gen seed in (initialSeed i, seed'), you have no guarantees about where the new seed is in the cycle. It might reproduce numbers that have already been seen, or that will be seen later. By contrast, with PCB's 2^63 independent "streams", you can use a random number to make a seed that is nowhere on the cycle of numbers it came from. (I mean, maybe by chance you'll generate the current stream number, but I consider that so unlikely as not to be worth checking, but you could.)

I thought about contacting the PCG author, but I'm going to go with this method of generating random seeds.

I thought about contacting the PCG author, but I'm going to go with this method of generating random seeds.

Here's what Melissa (author of PCG) said in an email:

The problem with your approach is that while it may seem to work well in practice, there is no evidence that it does not have any bad pathologies.   For example, can you be sure be sure that if you split the generator, generate 1000 numbers and then split it again you might not get back to a state you've already been in?

From a practical standpoint, it "probably won't happen", but people have been burned by that before.  In many of the early implementations of the RNG arc4random, 1 time in 75,000, the period of the generator could be tiny, producing only 16320 integers before repeating.

It's something I'm thinking about, but for me to provide this feature I'll have to have an implementation scheme I'm happy about.  I may yet end up with a probabilistic scheme similar to yours but I'm still thinking about it.

I don't have a satisfactory proof, but here are some inklings: one of the new seeds is merely the input seed stepped a few times, and as such, won't go back to a previous state. As for the other seed, it's the increment that matters (identical state but a different increment is okay). And because the increment must be odd, so we throw away the last bit, n and n+1 (for odd n) both produce the same increment. So it is indeed a merely probabilistic guarantee.
The properties of PCG are that as long each split seed has a unique increment, everything will be fine. So the odds are that of hitting a 2-number-wide target in a sea of 2^32 numbers twice. I don't think empirical tests will be helpful -- either you get unlucky or you don't. There's nothing that could be subtly wrong.
On the other hand, she didn't say it's completely and ridiculously wrong, so I think I'm okay with it. (There are easier-to-find bugs in the language and standard library...)


Prepare 0.11.0-beta.1 release

Bump all version numbers and update CHANGELOG.md.

Please, update release date (which is 2019-12-27) before merging and tagging.


Logistic regression weights: Using a tf.Tensor as a Python bool is not allowed

Trying to use logistic_regression weights led me to the exception:
Traceback (most recent call last):
  File "train.py", line 22, in <module>
    results = run(X, y, hyperparams, args.model_name)
  File "/opt/app/app/logistic_classifier.py", line 104, in run
    logdir='/opt/app/log/' + model_name
  File "/usr/local/lib/python2.7/dist-packages/tensorflow/contrib/learn/python/learn/estimators/base.py", line 227, in fit
    self._setup_training()
  File "/usr/local/lib/python2.7/dist-packages/tensorflow/contrib/learn/python/learn/estimators/base.py", line 148, in _setup_training
    self._inp, self._out)
  File "/opt/app/app/logistic_classifier.py", line 204, in model
    init_mean=params['init_mean'], init_stddev=params['init_stddev']
  File "/usr/local/lib/python2.7/dist-packages/tensorflow/contrib/learn/python/learn/models.py", line 158, in logistic_regression
    if not class_weight:
  File "/usr/local/lib/python2.7/dist-packages/tensorflow/python/framework/ops.py", line 475, in __nonzero__
    raise TypeError("Using a `tf.Tensor` as a Python `bool` is not allowed. "
TypeError: Using a `tf.Tensor` as a Python `bool` is not allowed. Use `if t is not None:` instead of `if t:` to test if a tensor is defined, and use the logical TensorFlow ops to test the value of a tensor.

which is fixed by attached change.

Can one of the admins verify this patch?

I signed it!

@ilblackdragon @martinwicke  are there really no tests for this? :)

@vrv Let me know if you want me to add any.
I stumbled upon this quite randomly and might need some guidance on where it would be appropriate to put the tests for this.

I feel like some test should be written that exercises this behavior, but I'm not too familiar with this code so I've assigned those who might know more.

That's why we're having a special event next week to add tests. :/

@vrv @martinwicke Let's start with class weights were tested until we stopped supporting them. (see tensorflow/contrib/learn/python/learn/tests/base_test.py?l=58) and this before was a deprecation warning which wasn't failing them.
@tensorflow-jenkins test this please!

PS. @vrv @martinwicke  really need that test coverage showing here if you really want to keep test coverage up. Jenkins will do

@ilblackdragon the code is wrong and there is no test for it, so we need a test to validate this is workign as intended before accepting.  Can you suggest a good place for a test?

We deprecated it in our interface so it's quiet hard to test :)

@petrjanda you can implement test that uses custom Estimator with class weight - that should hit this code.

you probably want to revert this, the check is the reverse of what you had before


Add preprocessing of Sentinel-1

Closes #31, #38, #42

Note: Once this is merged and published, we need to change the remove_bands parameter inside the eurocrops-config (eurocrops.yaml) of the meta-learning repository from "B10" to "10".

@jsreuss Since the above note refers to another repository, could you create a ticket for that in the other repo. I feel like it might go unnoticed otherwise, once we close this MR here.


[BUG] tap action is hard to invoke by finger

Versions
Flutter: 1.19.0-2.0.pre.83
Android 8
photo_view: ^0.9.2
Describe the bug
I used PhotoViewGallery.builder to show a set of images. But when I use finger to swipe or click, it is hard to invoke the action. Only by my little finger, will it be invoked sometimes.
For example, onTapDown, onTapUp or double click to zoom.
When I debug in emulator by mouse and use mouse in my Android mobile phone, it works normally. But it is too hard by finger.
But if I use PhotoViewGestureDetector directly, everything works normally.
To Reproduce
Here is my code:
Container(
  decoration: BoxDecoration(color: Colors.black),
  constraints: BoxConstraints.expand(
    height: MediaQuery.of(context).size.height,
  ),
  child: Stack(
    children: [
      Positioned.fill(
        child: PhotoViewGallery.builder(
          scrollPhysics: const BouncingScrollPhysics(),
          backgroundDecoration: BoxDecoration(color: Colors.black),
          loadingBuilder: (c, ImageChunkEvent e) => ImageLoadingView(title: '${_currentPage + 1}', event: e),
          loadFailedChild: ImageLoadFailedView(title: '${_currentPage + 1}'),
          onPageChanged: _onPageChanged,
          pageController: _controller,
          itemCount: widget.images.length,
          builder: (BuildContext context, int index) => PhotoViewGalleryPageOptions(
            initialScale: PhotoViewComputedScale.contained,
            minScale: PhotoViewComputedScale.contained / 2,
            maxScale: PhotoViewComputedScale.covered * 2,
            filterQuality: FilterQuality.high,
            onTapDown: (c, d, v) => _onPointerDown(d.globalPosition),
            onTapUp: _onImagePointerUp,
            heroAttributes: PhotoViewHeroAttributes(
              tag: '${widget.images[index]}: $index',
            ),
            imageProvider: LocalOrNetworkImageProvider(
              url: widget.images[index],
              file: () async => _presenter.getFile(index: index),
            ),
          ),
        ),
      ),
      Positioned(
        bottom: 0,
        child: Listener(...),
      ),
    ),
  ),
)

double _pointerDownXPosition = 0;
double _pointerDownYPosition = 0;

void _onPointerDown(Offset pos) {
  _pointerDownXPosition = pos?.dx ?? 0;
  _pointerDownYPosition = pos?.dy ?? 0;
}

void _onImagePointerUp(BuildContext c, TapUpDetails d, PhotoViewControllerValue v) {
  var width = MediaQuery.of(context).size.width;
  var height = MediaQuery.of(context).size.height;
  Fluttertoast.showToast(
    msg: 'localPosition: ${d.localPosition}, globalPosition: ${d.globalPosition}, ' +
        'x: ${d.globalPosition?.dx}, y: ${d.globalPosition?.dy}, width: $width, height: $height',
  );
}

Screenshots
Emulator:

Android by mouse:

Android by finger: (I can't capture it)

I've got a similar issue where it is also sometimes hard to swipe to the next image. But I also can relate to the onTap issue. Zooming with 2 fingers works, but double tapping to zoom almost never.

@Aoi-hosizora How to use PhotoViewGestureDetector?

@woodstream You can see the source code in https://github.com/renancaraujo/photo_view/blob/master/lib/src/core/photo_view_core.dart and https://github.com/renancaraujo/photo_view/blob/master/lib/src/core/photo_view_gesture_detector.dart.
PhotoViewGallery -> PhotoView -> PhotoViewCore -> PhotoViewGestureDetector
return PhotoViewGestureDetector(
  child: Container(
    constraints: widget.tightMode ? BoxConstraints.tight(scaleBoundaries.childSize * scale) : null,
    child: Center(
      child: Transform(
        child: customChildLayout,
        transform: matrix,
        alignment: basePosition,
      ),
    ),
    decoration: widget.backgroundDecoration ?? _defaultDecoration,
  ),
  onDoubleTap: nextScaleState,
  onScaleStart: onScaleStart,
  onScaleUpdate: onScaleUpdate,
  onScaleEnd: onScaleEnd,
  hitDetector: this,
  onTapUp: widget.onTapUp == null ? null : onTapUp,
  onTapDown: widget.onTapDown == null ? null : onTapDown,
);

@renancaraujo Have you seen this issue? This is a major blocker for my app. It would be very kind of you if you could look at this.

@Aoi-hosizora i have same issue here, could you give me simple sample code use PhotoViewGestureDetector ?

This gallery issue is very very challenging. I can not reproduce it in any of my devices, but there is enough amount of people complaining about this.
Since I'm alone maintaining this lib, I guess I will have to try to fix it even without knows the reason why.

I believe you can do it

@febryardiansyah Oh I'm sorry to reply so late, you can see https://github.com/renancaraujo/photo_view/issues/293#issuecomment-654076836 and change some parameter directly.

Just realized we have an small fix on gesture detector that was not yet released in any version. Would any of you (that can reproduce the bug) test if it works when pointing to photo_view's master?

@renancaraujo I tried master yesterday behaves the same, I have problem with swiping + the double tap, sometimes the picture get "stuck" instead of moving to another picture bcs the custom gesture detector acepted the first event move even there is no way to pan the picture.

I can sadly confirm that the latest version does not resolve the error

I will probably change my career after fixing this. Become an astronaut or something.

@renancaraujo As you see, Mars is waiting for you.

@renancaraujo I think this is not really a good solution, but it basically solved my problem
`class PhotoViewGestureRecognizer extends ScaleGestureRecognizer {
PhotoViewGestureRecognizer({
this.hitDetector,
Object debugOwner,
this.validateAxis,
PointerDeviceKind kind,
}) : super(debugOwner: debugOwner, kind: kind);
final HitCornersDetector hitDetector;
final Axis validateAxis;
Map<int, Offset> _pointerLocations = <int, Offset>{};
Offset _initialFocalPoint;
Offset _currentFocalPoint;
Offset _tabDown;
bool ready = true;
@override
void addAllowedPointer(PointerEvent event) {
if (ready) {
ready = false;
_pointerLocations = <int, Offset>{};
}
super.addAllowedPointer(event);
}
@override
void didStopTrackingLastPointer(int pointer) {
ready = true;
super.didStopTrackingLastPointer(pointer);
}
@override
void handleEvent(PointerEvent event) {
if (validateAxis != null) {
_computeEvent(event);
_updateDistances();
_decideIfWeAcceptEvent(event);
}
super.handleEvent(event);
}
void _computeEvent(PointerEvent event) {
if (event is PointerMoveEvent) {
if (!event.synthesized) {
_pointerLocations[event.pointer] = event.position;
}
} else if (event is PointerDownEvent) {
_pointerLocations[event.pointer] = event.position;
} else if (event is PointerUpEvent || event is PointerCancelEvent) {
_pointerLocations.remove(event.pointer);
}
_initialFocalPoint = _currentFocalPoint;

}
void _updateDistances() {
final int count = _pointerLocations.keys.length;
Offset focalPoint = Offset.zero;
for (int pointer in _pointerLocations.keys)
focalPoint += _pointerLocations[pointer];
_currentFocalPoint =
count > 0 ? focalPoint / count.toDouble() : Offset.zero;
}
void _decideIfWeAcceptEvent(PointerEvent event) {
if (!(event is PointerMoveEvent)) {
if (event is PointerDownEvent) _tabDown = event.position;
return;
} else {
if (_tabDown == event.position) return;
}
final move = _initialFocalPoint - _currentFocalPoint;
final bool shouldMove = validateAxis == Axis.vertical
? hitDetector.shouldMoveY(move)
: hitDetector.shouldMoveX(move);
if (shouldMove || _pointerLocations.keys.length > 1) {
acceptGesture(event.pointer);
}
}
}`

@renancaraujo I think this is not really a good solution, but it basically solved my problem
class PhotoViewGestureRecognizer extends ScaleGestureRecognizer {
  PhotoViewGestureRecognizer({
    this.hitDetector,
    Object debugOwner,
    this.validateAxis,
    PointerDeviceKind kind,
  }) : super(debugOwner: debugOwner, kind: kind);
  final HitCornersDetector hitDetector;
  final Axis validateAxis;

  Map<int, Offset> _pointerLocations = <int, Offset>{};

  Offset _initialFocalPoint;
  Offset _currentFocalPoint;

  Offset _tabDown;

  bool ready = true;

  @override
  void addAllowedPointer(PointerEvent event) {
    if (ready) {
      ready = false;
      _pointerLocations = <int, Offset>{};
    }
    super.addAllowedPointer(event);
  }

  @override
  void didStopTrackingLastPointer(int pointer) {
    ready = true;
    super.didStopTrackingLastPointer(pointer);
  }

  @override
  void handleEvent(PointerEvent event) {
    if (validateAxis != null) {
      _computeEvent(event);
      _updateDistances();
      _decideIfWeAcceptEvent(event);
    }
    super.handleEvent(event);
  }

  void _computeEvent(PointerEvent event) {
    if (event is PointerMoveEvent) {
      if (!event.synthesized) {
        _pointerLocations[event.pointer] = event.position;
      }
    } else if (event is PointerDownEvent) {
      _pointerLocations[event.pointer] = event.position;
    } else if (event is PointerUpEvent || event is PointerCancelEvent) {
      _pointerLocations.remove(event.pointer);
    }

    _initialFocalPoint = _currentFocalPoint;
  }

  void _updateDistances() {
    final int count = _pointerLocations.keys.length;
    Offset focalPoint = Offset.zero;
    for (int pointer in _pointerLocations.keys)
      focalPoint += _pointerLocations[pointer];
    _currentFocalPoint =
        count > 0 ? focalPoint / count.toDouble() : Offset.zero;
  }

  void _decideIfWeAcceptEvent(PointerEvent event) {
    if (!(event is PointerMoveEvent)) {
      if (event is PointerDownEvent) _tabDown = event.position;
      return;
    } else {
      if (_tabDown == event.position) return;
    }
    final move = _initialFocalPoint - _currentFocalPoint;
    final bool shouldMove = validateAxis == Axis.vertical
        ? hitDetector.shouldMoveY(move)
        : hitDetector.shouldMoveX(move);
    if (shouldMove || _pointerLocations.keys.length > 1) {
      acceptGesture(event.pointer);
    }
  }
}

Has this problem been fixed? @renancaraujo give you a suggestion. You can try to ask Google's flutter development engineer to help you find out the problem.

@TheLiyo With your code, it seems to solve the problem，I just did a test，But I also hope  author can find out the reason and tell us why

I'm not sure it's helping this specific issue, but just in case...
A while ago I noticed some precision issue in the HitCornersDetector and I fixed it in my fork: https://github.com/deckerst/photo_view/commit/e1c14b07a1c759c14fa33b066dd240d47812038d
The issue was preventing user interaction for specific combinations of image size and scale (so, screen size). Maybe that's why the issue can be reproduced on some devices but not others... Hopefully you just have to play with precisionErrorTolerance to solve this.

I've just spent the whole weekend over this. Basically, we have two issues with our custom scale recog: it is taking precedence over all other recognizers even when it shouldn't be doing that, this causes double and taps not to work well. The second issue is that HitCornersDetector has some bugs. The last one is the one that concerns this issue.
@DNetORM @vikeychen  and @TheLiyo: I think we can solve that by fixing hit corners instead. This PR should fix this issue, can you test it?
@deckerst That's new to me, but I think we have to add that to different places as well. I shall debug that in more depth. Thanks for the insight. This will help to solve #304

Anyway, @deckerst would open a PR with this fix?

The problem still here.

@progid Have you tested with master?

@renancaraujo yes, I have. It happens after loadingBuilder is shown.

Was this issue fixed? Got kind of confused over here.

https://github.com/fireslime/photo_view/pull/326 should fxied it.
You can try to ref the lib in your pubspec.yaml as the following code:
  photo_view:
    git:
      url: https://github.com/fireslime/photo_view.git
      ref: master

#326 should fixed it.
You can try to ref the lib in your pubspec.yaml as the following code:
  photo_view:
    git:
      url: https://github.com/fireslime/photo_view.git
      ref: master

It seems this worked for me.
Thank you!

Yep, working fine, thanks a lot.

double tap and swiping works again, you rock @renancaraujo !

Amazing. Installing just the version v0.10.2 didn't work but installing it from the master branch actually helped. Thanks.

Thank you so much! Referencing the lib also worked for me.

Next release should come ASAP, sorry for the delay.

I still seem to be having issues with this.
The first double tap works 100%, the second one sometimes,
and the third one to unzoom is in most cases almost impossible to trigger.
Most of the taps just trigger a pan gesture, but it is way too easy to trigger it.
I installed from master so I have the latest code.

@clragon isn't it https://github.com/fireslime/photo_view/issues/216?

0.10.3 released, this should be fixed.

I shall close this for now, if someone finds an issue in this matter after updating to 0.10.3, feel free to retake the discussion or message me on discord.

I had confused with the slide problem,but finally i try comment the backgroundDecoration attr and it reslove this problem.Here is my code.hope help you and everyone.  @renancaraujo
PhotoViewGallery.builder(               scrollPhysics: const BouncingScrollPhysics(),               builder: (BuildContext context, int index) {                 print("-----------index=$index");                 return PhotoViewGalleryPageOptions(                   imageProvider: NetworkImage(widget.galleryItems[index]),                   initialScale: PhotoViewComputedScale.contained * 1, //            heroAttributes: PhotoViewHeroAttributes( //                tag: widget.galleryItems[index].hashCode),                 );               },               pageController: PageController(initialPage: widget.initialIndex),               itemCount: widget.galleryItems.length,               loadingBuilder: (context, event) => Center(                 child: Container(                   width: 20.0,                   height: 20.0,                   child: CircularProgressIndicator(                     value: event == null                         ? 0                         : event.cumulativeBytesLoaded / event.expectedTotalBytes,                   ),                 ),               ),               onPageChanged: _onPageChanged, //        backgroundDecoration: BoxDecoration(color: Colors.black),//加上该行会导致滑动翻页不灵敏             ),

Unfortunately I have same problem on 0.10.3 with Samsung Galaxy s20+


Next() function in category merchandising returns 5 results instead of original request amount

As described in title.

Looks like it isn't straightforward. I cannot reproduce this bug anymore.
Let's keep this issue open for a while if same problem is reproduced.


images for beginner/id-editor based on the new iD release

These images are based on screenshots from http://preview.ideditor.com/master and should be used together with a revised edition of the guide

@michael63-osm
Nice!  I've had a look through and all looks good. We have a couple of options

Merge all of these images now onto the staging site so they are easier to view. Also would allow circulation and possible discussion at the meeting Monday (tomorrow).  Then when new version of iD is released just transfer the changes across to the main site.
Keep everything here and only add when iD version is released.

Personally I favour 1.
Thanks for doing this - they look good!


Screenshot not getting entire page

I am using capybara-selenium w/ Chrome headless.  The screenshots that are saved on failure are not getting the entire page.  The error I'm having is farther down on the page than what is shown in the saved PNG file.  Is there some way to configure things to capture the entire page or to take an image that is positioned relative to the last successful focus from capybara?

A solution would be to get the document height/width on the fly with some JS :
height = Math.max($(document).height(), $(window).height())
width = Math.max($(document).width(), $(window).width())

see: https://stackoverflow.com/a/14744331
and do the screenshot with these values instead of using the configured :window_size

@n-rodriguez A quick question side question, is there a reason you're using?
# Configure Capybara JS driver
Capybara.current_driver    = :headless_chrome
Capybara.javascript_driver = :headless_chrome

My Cuprite-driven tests seem to run fine without it?

After studying the various API this does the trick :
Capybara::Screenshot.register_driver(driver_name) do |driver, path|
  driver.save_screenshot(path, full: true)
end

Ferrum doc : https://github.com/rubycdp/ferrum#screenshots

It looks like it already passes full: true to save_screenshot for the driver named :cuprite as of e19db98b1f6a142a63084e694677f1250bd8e4d4.
So it looks like you only ran into this because you weren't using the default name for the driver (you're calling yours :headless_chrome, which is a great name, by the way—I think I may copy that).
(I've run into similar problems when I've tried to use names that make more sense to me, like calling my Firefox driver :firefox instead of using the default name of :selenium.)
It would be nice if Capybara::Screenshot looked up the adapter code for the current driver based on page.driver.class (Capybara::Cuprite::Driver) rather than Capybara.current_driver (:headless_chrome). Then it wouldn't matter which custom name you had used to register the driver with Capybara (Capybara.register_driver)—it would find it regardless of the name used!
Does that sound reasonable to you guys? If so, here's a MR; please merge. :smile:

I am having the issue with selenium. If I set full: true I get:
WARN: Screenshot could not be saved. An exception is raised: #<ArgumentError: unknown keyword: :full>.

In Selenium full was renamed to full_page, which explains the last error.
However, note that it only is supported in Firefox.
https://github.com/SeleniumHQ/selenium/issues/14116


release dev under alpha and fix windows install

@andrewwhitehead any idea why this is failing (https://github.com/hyperledger/aries-askar/actions/runs/6692810757/job/18182849484)? I thought including the cargo.lock would make sure we use ring 16.x, but it fails on an issue for ring 17.x. The issue can be fixed by updating the containers GCC version (manylinux and android), but I am hoping for a slightly easier fix.


Extra letter-spacing only on OSX (fixes #13017)

fixes #13017

Coverage remained the same at 61.229% when pulling 905a23d6fee49d4dffcb602fe283b708bd4127da on chrmarti/letterspacing into 623e0176c701ab18f114b855026c23f492df4088 on master.


The action is also compatible with macos-12 runners

The documentation states:

The runs-on: macos-10.15 must be macos-10.15.

Since https://github.com/actions/virtual-environments/pull/5594, macos-12 is also supported.
This PR was a follow-up on macos-10.15 deprecation notice: https://github.com/actions/virtual-environments/issues/5583
Here's a sample of this action working properly on macos-12: https://github.com/mayeut/psutil/runs/6698397720?check_suite_focus=true

Thank you so much.  but  macos-12 is beta for now.
I will make a new release as soon as macos-12 is in production

Thank you so much. but macos-12 is beta for now.

Yes, this was just a heads-up. FYI, macOS-12 shall be out of BETA before macos-10.15 is removed.

Thank you so much. but macos-12 is beta for now. I will make a new release as soon as macos-12 is in production

macos-12 is now generally available

Thanks,  the readme is updated.

👁🗨🐥🌐


Update to OpenChain Security Assurance specification 1.1

Update the OpenChain Security Assurance specification to version 1.1, and tweak the language to make it a little clearer what its role is. The specification focuses on how organizations should be looking for known vulnerabilities, which wasn't as clear in the concise guide, so I hope this makes it better.
Signed-off-by: David A. Wheeler<EMAIL_ADDRESS>

I'd like Shane Coughlan's review @shanecoughlan before merging this. This document should reference the OpenChain document, but put it in a proper context so it's not confusing to readers.

shanecoughlan - thanks for the review!
I think we should merge this soon. The concise guide for evaluation of OSS currently references the old name and an old (and no longer working URL); this PR updates them to the current document name and URL. So it's not really changing anything significant about the OpenSSF guide, merely updating the OpenSSF guide.
Any other comments?

Good to go on my side. :)

I'm going to merge this, since otherwise we point to the wrong (old) name and the wrong (old) URL, which helps no one.


Fix play kube command in pod yaml

This PR fixes the play kube can't recognize command setting in pod yaml file.
The initial issue was fixed in: https://github.com/containers/libpod/pull/3588
But it was introduced again in: https://github.com/containers/libpod/pull/3744
/assign @haircommander @mheon

LGTM, @mheon I wonder why this wasn't caught in tests :thinking:

bot, add author to whitelist
/ok-to-test
thanks for the PR @chenzhiwei

@chenzhiwei I am trying to write a test case that replicates the problem, but can't on the current master. if I have the kube yaml:
# Generation of Kubernetes YAML is still under development!
#
# Save the output of this file and use kubectl create -f to import
# it into Kubernetes.
#
# Created with podman-1.4.5-dev
apiVersion: v1
kind: Pod
metadata:
  creationTimestamp: "2019-08-14T12:27:01Z"
  labels:
    app: hello
  name: hello
spec:
  containers:
  - command:
    - /bin/sh
    - -c
    - echo "hello"
    env:
    - name: PATH
      value: /usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
    - name: TERM
      value: xterm
    - name: HOSTNAME
    - name: container
      value: podman
    image: docker.io/library/alpine:latest
    name: wonderfulpoincare
    resources: {}
    securityContext:
      allowPrivilegeEscalation: true
      capabilities: {}
      privileged: false
      readOnlyRootFilesystem: false
    workingDir: /
status: {}

and play kube with it, I can then run
podman logs -l
and get "hello" back
How did you find this problem?

LGTM, if we could add a test, either in this PR or another to watch for another regression, it would probably be a good idea.

and forgot the most important thing, Thanks @chenzhiwei !

@haircommander Which version did you use?
Mine is:
root@ubuntu:~# podman version
Version:            1.5.0
RemoteAPI Version:  1
Go Version:         go1.10.4
OS/Arch:            linux/amd64

And use your yaml file, I got:
root@ubuntu:~# podman ps -a
CONTAINER ID  IMAGE                            COMMAND               CREATED         STATUS                     PORTS  NAMES
cac3c431eb10  docker.io/library/alpine:latest  /bin/sh               20 seconds ago  Exited (0) 19 seconds ago         wonderfulpoincare
bd57c8608ebd  k8s.gcr.io/pause:3.1                                   25 seconds ago  Up 20 seconds ago                 8197b58ea5f2-infra

Oh, oops. This won't trigger on run - instead it'll blank out CMD on commit
of the image (and on inspect).
On Wed, Aug 14, 2019, 09:04 Tom Sweeney<EMAIL_ADDRESS>wrote:

@TomSweeneyRedHat commented on this pull request.
This smells like a bad merge somewhere....
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/containers/libpod/pull/3809?email_source=notifications&email_token=AB3AOCCUJ7QVKVYCO5YYQ63QEP7D7A5CNFSM4ILR3CEKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCBRC63Q#pullrequestreview-274870126,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AB3AOCAB2Y5HRQ4UQ2KP3ELQEP7D7ANCNFSM4ILR3CEA
.

@chenzhiwei confirmed ps shows the wrong output. This has the side effect of a regression in generate kube where the command isn't properly set...
I have a test case attached, can you apply it with git apply -f play-patch.txt
play-patch.txt

haha whoops, you'll need to run make gofmt and commit the changes

LGTM assuming the test passes :) thanks a bunch @chenzhiwei
@mheon added Release Notes 1.5.1 to make sure this gets in :)

/approve

@haircommander Sorry, I did not verify the final result, it was just a display error.
I have vim-go installed, usually there should be no format error, but for this patch I did not use vim to edit it. :(

no worries at all :smiley:

/lgtm


Refactor APIs for Shopcarts (not include subroutines)

As a developer
I need to refactor the code using a more advanced framework
So that I can have generated documentation automatically
Details and Assumptions

Using Flask-RESTX and Swagger
Add Swagger annotations
Add Swagger data models to document our API payloads
Refactor the /shopcarts and /shopcarts/{user_id} routes
Make sure all of the proper error codes returned (~e.g. 400 for an invalid user_id or item_id meaning not a non-negative integer, NOT 404~)  [EDIT: prof said default 404 for those is the right thing to do so switch back to /shopcarts/<int:user_id>] :(
After refactoring use flask routes to list all routes, make sure there are no static gets or other routes not specified by our API explicitly.

Acceptance Criteria
Given we have refactored the above routes
When we run nosetests and behave on the tests we had previously written on these routes
Then all tests pass
When we call a method on a route that produces an HTTP error
Then we get JSON error messages back not HTML
And we never get 500 error messages
Given we have automatically generated the documentations using Swagger
When we go to the URL /apidocs/
Then we have comprehensive documentation of all of the routes available in our service as well as how to use them

sorry i just realised we still need to add the swagger tags for automatically generating docs! since you've already done a lot of work, feel free to write a separate story for the swagger tags.

I think most tags are already done? You can see docs in .../apidocs @TimothyXu

@kdokm Yes you're right sorry! It's all done

Copying my comment in the other PR: Most of the work is done which is great! Refactoring is fine. But: (we can open a different story to fix this if you wish so someone else can do it)

As prof said in our slack channel, A 400_BAD_REQUEST is reserved for the payload. Not the path. so we need to change all the urls back to int:shopcart_id etc. and not check for them manually. And when we try to call e.g. /shopcarts/wrongid we should get the default 404 from Flask and that's fine.


Add more fields to user model

Pretty self explanatory - new fields added for User type, relevant areas of code updated to suit these changes.

LGTM!

LGTM!

LGTM!

LGTM!


Add support for nvim-dap >= 0.8

Fixes #23

This fixes it but is probably the wrong approach. The pick_one function uses vim.ui.select(), so this should be replaced with:
https://github.com/nvim-telescope/telescope-ui-select.nvim

Confirming that this works perfectly.
Thanks @cryptomilk

Ping

@Conni2461 @theHamsta @zoriya @JRasmusBm

Ping, as well :)
I solved it like this for me until this has been merged:
      local dap_ui = require("dap.ui")
      local original_pick_one = dap_ui.pick_one
      telescope.load_extension("dap")
      dap_ui.pick_one = original_pick_one

Thanks :)


DocsArchive-<IP_ADDRESS>Auto archive content

Auto archive content from https://github.com/OPS-E2E-PPE/docs-archive-test-source

Docs Build status updates of commit 5306417:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error] Run script failed with no detailed information. Please retry building your content again. If the issue still happens, open a ticket in https://SiteHelp and include the error report for our team to troubleshoot

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


HTS concurrent put and delete resolution -- Reopen and Refractor tests

Summary
Bug fix for the reverted pr. This PR refractors the fragile unit tests. The save() method will change the state of the hts storage, so we need to delete all instances after each test to prevent the state propagation. The save() method will also update the version of TEST_USER_TABLE_ROW from null to 0, and even the builder cannot change the version to null (reason still unknown). So we need to avoid using static TEST_USER_TABLE_ROW, but instead create an instance for each test.
Changes

[ ] Client-facing API Changes
[ ] Internal API Changes
[x] Bug Fixes
[ ] New Features
[ ] Performance Improvements
[ ] Code Style
[x] Refactoring
[ ] Documentation
[ ] Tests

For all the boxes checked, please include additional details of the changes made in this pull request.
Testing Done

[x] Manually Tested on local docker setup. Please include commands ran, and their output.
[x] Added new tests for the changes made.
[x] Updated existing tests to reflect the changes made.
[ ] No tests added or updated. Please explain why. If unsure, please feel free to ask for help.
[ ] Some other form of testing like staging or soak time in production. Please explain.

For all the boxes checked, include a detailed description of the testing done for the changes made in this pull request.
Additional Information

[ ] Breaking Changes
[ ] Deprecations
[ ] Large PR broken into smaller PRs, and PR plan linked in the description.

For all the boxes checked, include additional details of the changes made in this pull request.

Why did the pre-commit succeed but post-commit fail with the previous instance of the PR? could you capture those details in the description

The hypothesis is that pre-commit didn't capture the new commit. This is a common phenomenon of Github Action as I have encountered it several time.


Stencil buffer cutoff?

Now cutoffs use fragment shader strategy, which overcalculates them, esp. for sharp angles or small scales. Engaging stencil buffer would allow to avoid conditions in fragment shader, in theory.

There is no way to make an absolute stencil buffer as segments can overlap and therefore cutoff.


enabled but signal is not

Full_Name: Eric Robert Peskin
Version: -rwxr-x---   1 peskin   async    12894974 Nov 24 17:32 /home/xia/peskin/atacs/src/atacs*
OS: RedHat 6.0 (Linux xia.elen.utah.edu 2.2.5-22 #1 Wed Jun 2 09:17:03 EDT 1999 i686 unknown)
source: /home/xia/peskin/atacs/examples/g/vmeA.g
log: /home/xia/peskin/atacs/examples/g/vmeA.log
Submission from: xia.elen.utah.edu (<IP_ADDRESS>)
Submitted by: peskin
The in the grep appended below terminate with an error of the form
 enabled but signal is not  or  in state .
See also bug reports 205, 211, 212, 214, 244.
209 xia:~/atacs/examples> g enabled /.log
csp/chantal.log:ERROR: CSC0+/1 enabled but signal is not 0 or R in state 000F
csp/pab_b1.log:ERROR: CSC0-/1 enabled but signal is not 1 or F in state RR01B
csp/pab_pa.log:ERROR: CSC0-/1 enabled but signal is not 1 or F in state F001B
csp/pab_pla.log:ERROR: CSC0-/1 enabled but signal is not 1 or F in state 0F10B
csp/safe2.log:ERROR: a+/1 enabled but signal is not 0 or R in state 10
g/2demux.log:ERROR: Rin_1+ enabled but signal is not 0 or R in state
R1R00110000000R000
g/ram-read-sbuf2.log:ERROR: CSC0-/1 enabled but signal is not 1 or F in state
0100R1F00101
g/sbuf-ram-writeA.log:ERROR: CSC0+/1 enabled but signal is not 0 or R in state
R0100111001
g/vbe5.2.log:ERROR: Za- enabled but signal is not 1 or F in state 10RF00
g/vmeA.log:ERROR: CSC0+/1 enabled but signal is not 0 or R in state 00F10
vhd/bcmp.log:ERROR: eq-/1 enabled but signal is not 1 or F in state 000
vhd/ifetch1.log:ERROR: pc_ack-/1 enabled but signal is not 1 or F in state RRR
vhd/pre_dec.log:ERROR: exception_out-/2 enabled but signal is not 1 or F in
state R00
vhd/sample2_ctrl.log:ERROR: mult_1_req-/2 enabled but signal is not 1 or F in
state R1RRR00RRRR
vhd/sample_ctrl.log:ERROR: mult_1_req-/2 enabled but signal is not 1 or F in
state 0RRRRR0RRR
vhd/sample_ctrl2.log:ERROR: mult_1_req-/2 enabled but signal is not 1 or F in
state 0RRRRR0RRR
vhd/sample_ctrl_tb.log:ERROR: mult_1_mux2_sel-/1 enabled but signal is not 1 or
F in state 010001110R10000110R
vhd/sample_ctrl_tb2.log:ERROR: mult_1_mux2_sel-/1 enabled but signal is not 1 or
F in state 010001110R10000110R
vhd/serial1_ctrl.log:ERROR: alu_1_req-/2 enabled but signal is not 1 or F in
state 0RRR0RR
vhd/serial1_ctrl_tb.log:ERROR: alu_1_mux2_sel-/1 enabled but signal is not 1 or
F in state<PHONE_NUMBER>10R
vhd/serial_ctrl.log:ERROR: alu_1_req-/2 enabled but signal is not 1 or F in
state 0RRR0RR
vhd/serial_ctrl2.log:ERROR: alu_1_req-/2 enabled but signal is not 1 or F in
state 0RRR0RR
vhd/serial_ctrl_tb.log:ERROR: alu_1_mux2_sel-/1 enabled but signal is not 1 or F
in state<PHONE_NUMBER>10R
vhd/serial_ctrl_tb2.log:ERROR: alu_1_mux2_sel-/1 enabled but signal is not 1 or
F in state<PHONE_NUMBER>10R
vhd/small_pre_dec.log:ERROR: pre_dec_ack-/1 enabled but signal is not 1 or F in
state R0
vhd/tb_pre_d.log:ERROR: pre_dec_req+/4 enabled but signal is not 0 or R in state
100000000
vhd/tb_small_pre_dec.log:ERROR: pre_dec_req+/2 enabled but signal is not 0 or R
in state 1001
vhd/uno1_ctrl.log:ERROR: mult_1_req-/1 enabled but signal is not 1 or F in state
RRRRR
vhd/uno_ctrl.log:ERROR: mult_1_req-/1 enabled but signal is not 1 or F in state
RRRRR
210 xia:~/atacs/examples>

Many of these examples are bad (most of the vhd, for example), and better error
messages come out for those that should not work.
Those examples that are ok now all work when untimed.  Some examples, chantal,
pab_pa, and pab_pla run into problems when a timing method is used.  Therefore,
leaving in potential problem for now.


[FLINK-16954] Don't use JDK11 APIs in ClassRelocator

We instead use asm-7, which is normally not available in the Flink 1.9.x
line, as a test dependency.
cc @zentol

I copied the code from the master branch, so there's also a small fix included for https://issues.apache.org/jira/browse/FLINK-15739 (the additional "filter" line). I can remove that, though, if you want.

True about the filter, it's just a more conservative approach overall.

Thanks for the review!


Separate DateTime provider

General Information
Right now we use kotlinx-datetime as multiplatform solution.
However, sometimes it make sense to use other DateTime provider.
Possible Solution
We have to extract any work with LocalDateTime into injected abstract DateTimeProvider.
We also must extract the functionality without the kotlinx-datetime library into kcron-common-core library.
As default implementation we must keep kcron-common package which will use kotlinx-datetime as DateTime implementation.

After some investigation, I found that there is no better KMP date-time library than kotlinx-datetime.
So, maybe add the possibility to use different date-time provider is good but it should not reduce the current platforms amount.

Hi, in my case I would use you dependency in a JVM context, but without an other dependency like kotlinx-datetime as DateTime implementation. The JDK give already the java.time and I prefer to avoid to multiply dependency to do the same things.

Hello @romualdbassinot!
Could you look into my PR?

Thanks I will look this week.


My chrome extension doesnt function anymore. It only worked the first time

Hey @palakshah11 - I've observed chrome extensions sometimes being spotty, but generally either restarting chrome, or if that doesn't work restarting your computer, generally resolves the issue
Can you try that and let us know if that resolves your issue?

Hi,
It did resolve my issue. Thanks for the quick help.
thanks a lot!
Palak Shah
User Experience Designer
Aubergine Solutions Pvt. Ltd.
https://auberginesolutions.com/Facebook
https://www.facebook.com/auberginesolutions/ | LinkedIn
https://www.linkedin.com/company/aubergine-solutions-pvt-ltd/| Blog
https://medium.com/aubergine-solutions | Work-Portfolio
https://www.behance.net/auberginesolutions| Client-Testimonials
https://clutch.co/profile/aubergine-solutions
On Mon, Sep 14, 2020 at 11:47 PM Steve Sewell<EMAIL_ADDRESS>wrote:

Hey @palakshah11 https://github.com/palakshah11 - I've observed chrome
extensions sometimes being spotty, but generally either restarting chrome,
or if that doesn't work restarting your computer, generally resolves the
issue
Can you try that and let us know if that resolves your issue?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/BuilderIO/html-to-figma/issues/43#issuecomment-692227140,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AQ3JPRJPIJUSFWKH33KGSV3SFZM2TANCNFSM4RLIFRLQ
.


KA-Lite Monitor first launch is taking a long time.

Branch: MAster (OSX Installer)
Expected Behavior: Not taking a long time when clicking on Apply button in Preferences dialog.
Current Behavior: It's taking a long time when clicking on Apply button in preferences dialog.
Steps to reproduce:

Launch KA-Lite Monitor app.
Click Apply in preferences dialog, another dialog box will appear asking your password type a password and click Ok.

3. Another dialog box will appear prompting the user to wait, click on Ok button.

After clicking on the Ok button, it will make you wait 25 seconds before the KA-Lite Monitor menus become available
4. Click on Start KA-Lite menu.

After clicking on Start KA-Lite menu, it will make you wait 40 seconds before you can click the other menus.
@EdDixon, I tested this at the latest build: KA-Lite-Monitor.dmg-2015-07-29b.zip.  Please test this also if it the same at your end.

Yes it was my understanding that there are performance related git issues
open already but I can verify that there are performance related issues as
late as day 7/29 in the develop MAC installer and those seem to be carrying
over to the app itself. I have been waiting to see if there is a central
cause for this as it has not been an issue before before flooding with
specific issues but areas affected are the installation process as
described, The video and language pack progress bars, and just user
interaction in general?
Ed Dixon
Corrections Adviser
Foundation for Learning Equality http://learningequality.org/
Give to FLE, Support FLE via Amazon Smile!
https://learningequality.org/donate/
M<PHONE_NUMBER>
On Thu, Jul 30, 2015 at 3:04 AM, Danny Jim P. Allado <
<EMAIL_ADDRESS>wrote:

Branch: MAster (OSX Installer)
Expected Behavior: Not taking a long time when clicking on Apply button
in Preferences dialog.
Current Behavior: It's taking a long time when clicking on Apply button
in preferences dialog.
Steps to reproduce:

Launch KA-Lite Monitor app.
Click Apply in preferences dialog, another dialog box will appear
asking your password type a password and click Ok.

[image: screen shot 2015-07-30 at 10 50 44 am]
https://cloud.githubusercontent.com/assets/8664071/8974819/f88c6806-36a8-11e5-9770-74e84a016417.png
3. Another dialog box will appear prompting the user to wait, click on Ok
button.
[image: conferm]
https://cloud.githubusercontent.com/assets/8664071/8974655/d020f58c-36a6-11e5-9a93-b3a7f80bcbcb.png
After clicking on the Ok button, it will make you wait 25 seconds before
the KA-Lite Monitor menus become available
4. Click on Start KA-Lite menu.
[image: start ka-lite]
https://cloud.githubusercontent.com/assets/8664071/8974683/20e3442a-36a7-11e5-9e3a-5cb13e51f158.png
After clicking on Start KA-Lite menu, it will make you wait 40 seconds
before you can click the other menus.
@EdDixon https://github.com/EdDixon, I tested this at the latest build:
KA-Lite-Monitor.dmg-2015-07-29b.zip. Please test this also if it the same
at your end.
—
Reply to this email directly or view it on GitHub
https://github.com/learningequality/installers/issues/120.

Moved to 0.15.

We've fixed this for the upcoming 0.16 release.  We've reduced the startup time to a few seconds only!
Check-out the develop branch for the fixes.


Return non-zero exit status in case of an error

I believe that this feature is essential to use htmlcs from scripts.

Agree.


Ui additions

Nice to see many features implemented. I merge this branch because it is very important for tomorrow to show the changes in the sprint review.


UNR-3008 Spawn players Actors based on PlayerStart authortitative server

4.23 Engine PR
4.22 Engine PR
Description
This PR affects player spawning logic in a zoned environment.
Previously:
The PlayerSpawner component authoritative worker is sent SpawnPlayer requests by the client worker
GDK forwards request params to SpatialNetDriver::AcceptNewPlayer (and onto the GameMode)
GameMode then:
selects a PlayerStart Actor,
spawns the player-relevant Actors according to that start location.
This can cause immediate migrations of player Actors if the load balancing strategy dictates, which makes it harder for games to achieve single-server parity without writing all of their player migration logic upfront.
For example, in this gym, the GasCharacter has BeginPlay with authority and then OnAuthorityGained called for different servers (which has also messed up the camera):

Now

The PlayerSpawner component authoritative worker is sent SpawnPlayer requests by the client worker
PlayerSpawner authoritative worker then (if zoning is enabled):
a. GDK calls directly into GameMode to find a PlayerStart Actor
b. Checks LB strategy to get virtual worker ID of selected PlayerStart Actor
c. If, selected virtual worker ID == local virtual worker ID, then
i. Pass player params + PlayerStart Actor to SpatialNetDriver::AcceptNewPlayer (where the PlayerStart Actor is a new optional param)
d. else:
i. Create a ForwardSpawnPlayerRequest with the SpawnPlayer request data AND the UnrealObjectRef of the PlayerStart Actor
ii. Lookup the server worker entity ID for the PlayerStart Actor’s virtual worker
iii. Send a ForwardSpawnPlayer to the relevant server worker entity
Strategized server-worker then:
a. Receives ForwardSpawnPlayer request
b. Deserializes SpawnPlayer params and finds PlayerStart Actor from UnrealObjectRef
c. Passes to SpatialNetDriver::AcceptNewPlayer

Main changes:

New ForwardSpawnPlayer command on every ServerWorker entity-component containing a SpawnPlayerRequest and UnrealObjectRef properties
SpatialNetDriver::AcceptNewPlayer and relevant GameMode/LevelActor functions in engine now accept an optional PlayerStart Actor* that the SpatialPlayerSpawner can pass through
VirtualWorkerTranslation mapping now contains the server worker entity ID as well as physical worker name

Robustness:

The SpawnPlayer command has eventually-exactly-once semantics for actioning the command through retries on the client-worker side and keeping track of processed client worker IDs on the server-wide.
The ForwardSpawnPlayer uses the same logic, with additional checking by the authoritative PlayerSpawner server that the relevant PlayerStart Actor still exists/isn’t being destroyed before retrying
For the working receiving the ForwardSpawnPlayer request, there will be no rechecking of the PlayerStart against the load-balancing strategy once the ForwardSpawnPlayer request is received. This would be an issue for dynamic load-balancing strategies but since this work is initial zoning adoption I think 1) doing this now would be overengineering and 2) having a restriction of users to account for special-casing the dynamic load-balancing of PlayerStart isn’t too much of a restriction going forward anyway.

Tests
In UnrealGDKTestGyms master branch, add logs to BeginPlay with authority and OnAuthorityGained  blueprint events in Character_BP. Open the AbilityLockingGym and run it several times (with 4 workers). Observe that the two logs are printed from the same worker ID (should happen about 1 in 4 if the feature wasn't working).

This change allows FindPlayerStart to be called with PlayerController set to a nullptr - we should make sure that that is documented somewhere, since I believe that would not previously happen.