Update mint_nft.cdc

I was having some issues with this transaction and I brought it up in the discord.   The solution I got from the discord was to put the address inside getAccount.  I later tried the change I made below and that worked as well.
let recipient = getAccount(signer.address) in line 22

@iwill610 Sorry for not responding to this sooner! This is a good idea and would definitely make it easier for playground and VSCode users, but when we're using it with the SDK, we want to use transaction arguments because that is the proper way to do it. Sorry for the confusion. I should add some comments to clarify that.

@joshuahannan All good.  I just realized that the code I have for this transaction is a little different so my solution wouldn't have worked anyway.  Could you give me an example of how you pass arguments through the transactions?  I think I read that it should similar to functions, but transactions don't have names, so that left me a little stuck.

Passing arguments with the playground or VSCode isn't possible yet, but you can do it with JS or Go. Here is an example of creating a transaction in Go and adding arguments to it. You'll probably need to ask in the javascript channel in discord if JS is the language you're using though

Thank you


Speed result

minor feature request : get speed displayed for console results
when using current version of benchmark, results are provided using, I suspect, time in second. Some minor issues :

Scale is not explicitly mentioned
Number of significant digits can sometimes be too small, especially when the file benchmarked is very small and the algorithm selected is very fast

Example :
./benchmark -c lz4 sum
Using sum:
  lz4:lz4
    level 1: compressed (0.0007 CPU, 0.0007 wall, 32004 bytes)... decompressed (0.000828 CPU, 0.000829 wall).
    level 2: compressed (0.0007 CPU, 0.0007 wall, 33343 bytes)... decompressed (0.001052 CPU, 0.001054 wall).
    level 3: compressed (0.0008 CPU, 0.0008 wall, 29358 bytes)... decompressed (0.000849 CPU, 0.000851 wall).
    level 4: compressed (0.0008 CPU, 0.0008 wall, 24915 bytes)... decompressed (0.000873 CPU, 0.000875 wall).

The number of significant digits is fine for decompression, but it's not for compression, as a slight difference in rounding can make > 10%.
Anyway, while I'm fine regarding this format (with possibly a bit more digits) for -o jsonFile, it's less agreeable to use for direct onscreen result.
One can always grab a calculator and manually type size / time to obtain speed, but it's less usable than having speed directly calculated on screen.

Good point.  FWIW I think I did it this way to conserve horizontal real estate… at the time I was writing everything (incuding the dataset and codec) for every line, and I was trying to avoid wrapping.  Now that dataset and codec are on their own lines this isn't really an issue.
Anyways, fixed a few days ago, sorry I forgot to close then.


Remove dataclass decorator

This should fix your syntax error I hope.

ok, I'll try that... so no class member at all anymore?

Right. Just make them all dynamic like in previous python versions.
On Fri, Jun 21, 2019 at 13:44, Fred Blaise<EMAIL_ADDRESS>wrote:

ok, I'll try that... so no class member at all anymore?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/madchap/django-DefectDojo/pull/1?email_source=notifications&email_token=AAGBF2ZRHRR4FEXK4IVD7BLP3UORNA5CNFSM4H2TKQPKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYJIXNA#issuecomment-504531892,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAGBF25S3YCGW32BLDQO6K3P3UORNANCNFSM4H2TKQPA
.

--
Matt Sicker<EMAIL_ADDRESS>

Does not work
Exception Value: BlackduckFinding() takes no arguments


liblxi not found even though it's installed

I built & installed liblxi (from the 1.13 tarball; to /usr/local/lib, which is in my ld.so.conf), but when I run configure on lxi-tools (from the 1.21 tarball) I get:
checking for lxi_connect in -llxi... no
configure: error: liblxi not found

the linker setup definitely worked though:
$ ldconfig -p | grep lxi
     liblxi.so.1 (libc6,x86-64) => /usr/local/lib/liblxi.so.1
        liblxi.so (libc6,x86-64) => /usr/local/lib/liblxi.so

so i wonder if configure could be trying to override LD_{LIBRARY,RUN}_PATH or trying to somehow find the library using some heuristic that's excluding /usr/local even though it's a pretty standard path...
there also doesn't seem to be a --with-lxi=path parameter for it?
even LDFLAGS=' -L/usr/local/lib ' ./configure doesn't work.
EDIT: configure.log shows:
configure:12385: checking for lxi_connect in -llxi
configure:12410: gcc -o conftest -g -O2   conftest.c -llxi  -lreadline  >&5
/bin/ld: /usr/local/lib/liblxi.so: undefined reference to `avahi_discover'
collect2: error: ld returned 1 exit status

sooo i guess there's a check missing in liblxi's configure and the ld error is misinterpreted as a generic "library not found"?
my package manager says:
$ xbps-query -s avahi
[*] avahi-0.7_8                   Multicast DNS Service Discovery
[*] avahi-compat-libs-0.7_8       Avahi compatiblity shared libraries
[*] avahi-compat-libs-devel-0.7_8 Avahi compat libraries - development files
[*] avahi-discover-0.7_8          Service discover user interface for avahi
[*] avahi-glib-libs-0.7_8         Avahi glib shared libraries
[*] avahi-glib-libs-devel-0.7_8   Avahi glib libraries - development files
[*] avahi-libs-0.7_8              Avahi shared libraries
[*] avahi-libs-32bit-0.7_8        Avahi shared libraries (32bit)
[*] avahi-libs-devel-0.7_8        Avahi core libraries - development files
[*] avahi-python-0.7_8            Python utility package for Avahi
[*] avahi-ui-libs-gtk3-0.7_8      Avahi UI GTK+3 shared libraries

soooo pretty sure that's all there, and i don't even find anything related to avahi_discover as a library export on google, just the avahi-discover cli tool. plus liblxi's readme claims avahi to be optional.

Be sure to tell 'configure' where the libraries are located.  /lusr/local/lib is a non-default path.
./configure --libdir=/usr/local/lib
--OR--
LDFLAGS=-L/usr/local/lib ./configure
First method is easier.  Basically, linker can see the library (ldconfig -p example), but 'configure' is kinky and wants to touch it to verify it exists.

Seems you have the liblxi library file but for some reason it does not contain the lxi_init function.
Anyway, a lot of changes are coming, including switching from autotools to meson so you may get a better experience on your distribution soon.

Sorry to re-open this issue.
I tried to build from source on Ubuntu 20.04 and got this:
`Found pkg-config: /usr/bin/pkg-config (0.29.1)
Run-time dependency readline found: YES 8.0
Run-time dependency lua-5.3 found: YES 5.3.3
Found CMake: /usr/bin/cmake (3.16.3)
Run-time dependency liblxi found: NO (tried pkgconfig and cmake)
src/meson.build:42:0: ERROR: Dependency "liblxi" not found, tried pkgconfig and cmake
liblxi and liblxi-dev is installed but:dietmar@modsys:~/Projects/lxi-tools$ pkg-config --modversion liblxi
Package liblxi was not found in the pkg-config search path.
Perhaps you should add the directory containing liblxi.pc' to the PKG_CONFIG_PATH environment variable No package 'liblxi' found
Seems the installation is not complete. Should I install liblxi from source?

You are a bit too early - this is an issue of non-released lxi-tools and liblxi.
We've recently migrated to meson and that primarily rely on pkgconfig for resolving library configurations etc. The old liblxi using autotools does not install a pkgconfig. The latest git versions, liblxi installs a pkgconfig configuration so that lxi-tools can find it.
In, in short, install the latest git version of liblxi and it will match.

OK, I will wait.
Thank you for the nice work.

No problem. It will be released soon. Until then you could try out the edge snap for easy install.

I tried snap - but I got
dietmar@modsys:~$ lxi-gui Gtk-Message: Failed to load module "gail" Gtk-Message: Failed to load module "atk-bridge" Qt: Session management error: Could not open network socket
libatk-adaptor libgail-common was installed properly.
lxi-gui seems functiona, but in the end I removed the snap.

Since lxi-tools v2.0 has not yet been officially released you need to install the bleeding edge snap like so:
$ snap install lxi-tools --edge

gotta love the necromancy spam...


structlog config

https://github.com/kiwicom/structlog-sentry

https://github.com/jrobichaud/django-structlog
https://opentelemetry-python.readthedocs.io/en/latest/examples/django/README.html
https://www.structlog.org/en/stable/getting-started.html

https://tonybaloney.github.io/posts/using-dotnet-aspire-dashboard-for-python-opentelemetry.html


DOC: Table of Content incomplete in Quickstart Tutorial

Issue with current documentation:
This is what I am seeing in Quickstart Tutorial

Everything past "Part 3: Adding Memory to the Chatbot" is not visible in Table of Content.
Idea or request for content:
No response

Thanks for reporting - fixed in #1024 !


why not organize the ext package into dapr

Ask your question here
Now whole project is divided into four packages:

dapr
dapr-ext-fastapi
dapr-ext-grpc
flask_dapr

which may be intended for that

dapr itself is independent of others, and
dapr-ext-fastapi, dapr-ext-grpc and flask_dapr are extensions for dapr.

However some evidences show these packages may be better to organize into one package:

If one install package dapr-ext-grpc, he will find that dapr-ext-grpc is actually named as dapr.ext.grpc in local, which shares the same package name of dapr.
If one dig more into the codes, he will find the package dapr-ext-grpc uses the private variables from dapr, like
https://github.com/dapr/python-sdk/blob/87e9d11d20f8cdc8ed73072e3087700233421b49/ext/dapr-ext-grpc/dapr/ext/grpc/_servicier.py#L17-L18

So my question is that why whole project is divided into four packages?

Because users don't need to use all the extensions. New extensions can be created independently from the core project. Also, extensions can be deprecated independently from the core project. This is the same design for the other SDKs. See https://github.com/dapr/java-sdk and https://github.com/dapr/dotnet-sdk

Because users don't need to use all the extensions. New extensions can be created independently from the core project. Also, extensions can be deprecated independently from the core project. This is the same design for the other SDKs. See https://github.com/dapr/java-sdk and https://github.com/dapr/dotnet-sdk


[SPO] Rearranging visits page. Consent-visits (1-1 relationship)

Similar issue is added after, issue #324

Adding more details as learned from the business:


Update swarm mode endpoint

What does this PR do?

According to docker's doc, https://docs.docker.com/engine/swarm/swarm-tutorial/#the-ip-address-of-the-manager-machine, port 2375 is replaced by 2377 for cluster management communications
Motivation

Use port 2375 simply does not work with the new swarm the doc needs an update
More

[ ] Added/updated tests
[x] Added/updated documentation

Additional Notes

endpoint = "tcp://<IP_ADDRESS>:2377" is only usable when launching traefik directly on the host. In a dockerized environment, endpoint = "unix:///var/run/docker.sock" should be used with a mounted volume /var/run/docker.sock:/var/run/docker.sock

Closed by #4206


AVM Circuit Gas

### Tasks
- [ ] https://github.com/AztecProtocol/aztec-packages/pull/6542
- [ ] AVM circuit gas - unit tests
- [ ] AVM circuit gas - range check and failure support

This is a follow-up task of PR #6542


Add API related tests

We should test the API related code without depending on DejaCode
We can use the mock library for this purpose

see also all the following tests: https://github.com/dejacode/about-code-tool/blob/69f4a204894f6ff649ac0aa19f6af63051c62830/about_code_tool/tests/test_about.py#L401
Tests should not depend on network connectivity and external API calls
the goal is to test AboutCode internal code logic, not what DejaCode returns (which is tested on the DejaCode side)

https://pypi.python.org/pypi/mock/


pretraind model

Counld you share me the segnet pretrained model?Thanks

Sorry I have never trained this model on classical segmentation datasets, only on medical imaging.


Outlook preview link issue

When adding links to emails in Outlook you sometimes get a preview box for the link:

This includes the text 'Learning Object Title. Overview for the content below' rather than any real text from the project itself. Ideally this should be customisable in the same way as you can now edit the content of twitter card previews (@ronm123).

@FayCross I can't reproduce this and don't ever see a preview when adding a link to an email. I tested the link from your example too and don't see that preview. I wondered if perhaps this was with Outlook online rather than local but quickly tested there too and don't see this. Could it be some kind of proxy server caching or something else at Nottingham picking up that preview? Do you get the same with external Xerte links? If I view and inspect your example I don't see anything that matches that text you are seeing e.g. Learning Object Title. Overview Title for the content below so I'm not sure where that is coming from or why/how the preview is being created?

@ronm123 The previews are apparently on by default (Link previews) but in my experience they don't work consistently for all links you add. I get one for https://xot.xerte.org.uk but not if I link to a project from there - I'll play around and see if I can recreate with one outside UoN.
That text isn't coming from the project data but from rloObject.htm

@FayCross so according to that Link previews page on the support site this does only work on Outlook.com and Outlook on the web and not local Outlook? That said I checked in my online Outlook and the option is on but I still don't get previews.
I can see the place holder text in the site player but we don't have the same place holder text in the xot player. What happens when you add a link to an xot project?
Rather than an optional property perhaps the placeholder text should be automatically replaced with the LO title and page title? e.g. change:
id="pageTitle">Learning Object Title<
id="pageSubTitle">Overview title for the content below<
to:
id="pageTitle">%LOTITLE%<
id="pageSubTitle">%LOSUBTITLE%<
and then use replace in play.php?

Good idea - I'll give that a go. None of the XOT projects I've tried seem to show the preview


[Integration Test] Generate worker artifact to AzureFunctionsPreRelease feed

Description
This opts-in Azure Functions Integration Test of Python Worker.

It allows dev branch to build Python Worker artifact because we want it to run integration test now.
Upload artifact to AzureFunctionsPreRelease for integration test in core tools when build from dev branch

Test
Able to publish the artifact in AzureFunctionsPreRelease feed

/cc: @Francisco-Gamino

PR information

[x] The title of the PR is clear and informative.
[x] There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
[x] If applicable, the PR references the bug/issue that it fixes in the description.
[ ] New Unit tests were added for the changes made and CI is passing.

Quality of Code and Contribution Guidelines

[x] I have read the contribution guidelines.

Thanks for sending this out @Hazhzeng !
Question: This new tag 3.$LATEST_TAG-dev will be the same as the one reference in the https://github.com/Azure/azure-functions-host/blob/dev/build/python.props#L3 and https://github.com/Azure/azure-functions-core-tools/blob/v3.x/src/Azure.Functions.Cli/Azure.Functions.Cli.csproj#L152 except that we are adding -dev, correct?

Thanks for sending this out @Hazhzeng !
Question: This new tag 3.$LATEST_TAG-dev will be the same as the one reference in the https://github.com/Azure/azure-functions-host/blob/dev/build/python.props#L3 and https://github.com/Azure/azure-functions-core-tools/blob/v3.x/src/Azure.Functions.Cli/Azure.Functions.Cli.csproj#L152 except that we are adding -dev, correct?

@Francisco-Gamino
Yes, that is the same but we're adding -dev to it.
Basically, if the latest release version of Python worker is 1.1.12, then the package version will be 1.1.12-dev


Fix for disappearing places picker marker

@tobrun @LukasPaczos
Resolves #529 by fixing the floating marker in the place picker functionality of the places plugin.  In my opinion, this bug renders the picker essentially unusable.
If you share my slight concern thatmapView.getY() / 2 isn't the most performant fix, given that it happens every time that onCameraIdle() fires, I'm happy to hear other ideas for fixing.

Any chance we can do a new release of the Places Plugin in the next couple of weeks @LukasPaczos @zugaldia ? A release hasn't gone out since this pr was merged into master, so in my opinion, the place picker functionality continues to be broken/useless for devs who are using the latest stable version. They'll still see #529 in their projects. Or are we fine with advising folks to use 0.6.0-SNAPSHOT for now?
cc @riastrad in case you get any future inbound questions about this.

@zugaldia could you explain or direct me to any information about the "frappe" release? I had not heard of it before now, thank-you

@bradjonesca my bad, I should have provided a better explanation :) frappe is the codename for the upcoming Maps SDK release, which on Android is 6.5.0. We just released 6.5.0-alpha.2 and we expect a final release in the next few weeks (we name our Maps SDK release after drinks, you can see previous names in the release-* branch names in http://github.com/mapbox/mapbox-gl-native).


Add  mapping to popup for clearing inputs

For neovim, <C-u> will clear inputs, but vim won't.
This PR adds <C-u> mapping to vim's popup for clearing inputs.

Can you please also update the docs https://github.com/liuchengxu/vim-clap#keybindings and the help doc?

@liuchengxu Thanks for your confirmation!
I updated README and help file.

Merged, thanks!


[26.x][WFLY-16049] Update the OIDC tests so that they can run with Keycloak 17.0.0 and later

https://issues.redhat.com/browse/WFLY-16049
Upstream: https://github.com/wildfly/wildfly/pull/15231

Thanks @fjuma


[SMALLFIX] Removed redundant initializer in DataFileChannel

Removed a redundant initializer in the DataFileChannel class.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/9683/
Test FAILed.

Jenkins, test this please.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/9684/
Test PASSed.

LGTM


[Extensions] Add ExtensionAwarePlugin extension point to add custom settings for extensions

Description
This creates a new extension point inside of IdentityPlugin called getExtensionSettings that allows this singular plugin to define settings that should be placed in extensions.yml that are needed for security. This creates a new scope for settings called the Extension scope that means that these particular settings should be placed in extensions.yml and pertain to an extension. I first implemented this without using scoped settings, but ultimately chose to use Scoped Settings similar to get Plugin.getSettings() works. Using ScopeSettings, defaults can be assigned to the settings within the implementation of the getExtensionSettings() method.
Related Issues
https://github.com/opensearch-project/security/issues/2746
Check List

[ ] New functionality includes testing.

[ ] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[ ] Commits are signed per the DCO using --signoff
[ ] Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@reta @owaiskazi19 Could I trouble you for a review of this PR today? This one should be pretty straightforward.

@reta @owaiskazi19 Could I trouble you for a review of this PR today? This one should be pretty straightforward.

@cwperks my apologies, I am off most of the day today, could get to this pull request early next week

Np, have a great weekend @reta!

@owaiskazi19 @dbwiddis @saratvemulapalli @reta Would any of you be able to review this PR today?

@cwperks LGTM, looks much better (to me), would be great to have an opinion from extension experts, but I have no more comments, thank you.

@owaiskazi19 @reta Can this be merged if there are no outstanding questions? This should be backported to 2.x.

All comments have now been marked as resolved

@cwperks may need manual backport sadly ...

On it

Opened up backport PR: https://github.com/opensearch-project/OpenSearch/pull/7756


register_commands() plugin hook to register extra CLI commands

The datasette CLI tool currently has 7 subcommands: serve, inspect, install, package, plugins, publish and uninstall.
A plugin hook could allow plugins to register extra subcommands.
I've avoided this for quite a while because I didn't have good use-cases for it - but the existence of the datasette install xxx command for installing packages into the correct virtual environment means that actually there's a good reason to do this: it would allow plugins to provide additional command-line mechanisms without the user having to understand how virtual environments work in order to install those commands into the same environment as the rest of Datasette.

The closest plugin hook to this right now is [publish_subcommand])https://docs.datasette.io/en/stable/plugin_hooks.html#publish-subcommand-publish) - which looks like this:
@hookimpl
def publish_subcommand(publish):
    @publish.command()
    @add_common_publish_arguments_and_options
    @click.option(
        "-k",
        "--api_key",
        help="API key for talking to my hosting provider",
    )
    def my_hosting_provider(...):

But there are also several plugin hooks with register_ prefixes, which may be a good naming convention to stick to here: register_output_renderer(datasette), register_routes(datasette), register_facet_classes(), register_magic_parameters(datasette).

There's also the option for plugins to muck around with existing registered commands - this could get a bit untidy if multiple plugins try to do it, but being able to replace serve with a fresh implementation that adds an additional command-line option before calling back to the original might open up some interesting possibilities.

Terminology question: is it correct to call these subcommands or should they be commands? publish_subcommand() adds subcommands of the format datasette publish X - but are we instead adding commands with this new one?

Here's the answer to that:
~ % datasette --help
Usage: datasette [OPTIONS] COMMAND [ARGS]...

  Datasette!

Options:
  --version  Show the version and exit.
  --help     Show this message and exit.

Commands:
  serve*     Serve up specified SQLite database files with a web UI
  inspect
  install    Install Python packages - e.g.
  package    Package specified SQLite files into a new datasette Docker...
  plugins    List currently available plugins
  publish    Publish specified SQLite database files to the internet...
  uninstall  Uninstall Python packages (e.g.

Since it's adding extra things that show up in --help under the "Commands:" heading, I should call them commands.

I'm going to call the new hook register_commands - since it will allow ambitious plugins to register more than one command if they want to. That's also pleasingly similar to register_routes.

The first example plugin I'm going to build for this will be datasette verify file.db file2.db - it takes one or more paths to SQLite files and verifies if they can be opened by Datasette or not.

Considering this piece of code: https://github.com/simonw/datasette/blob/a1a33bb5822214be1cebd98cd858b2058d91a4aa/datasette/cli.py#L122-L142
I think the hook itself gets called with a single argument, cli, which it can then use in the standard Click way to register extra stuff.
I can't pass it datasette (like I do with register_routes()) because the Datasette object itself is instantiated by the serve command, which will not have been called.

I don't think I can get this new hook to support the handy --plugins-dir= mechanism for loading plugins from Python files as opposed to registering them with setuptools - that mechanism is itself implemented inside of code called by datasette serve so I don't have a way of taking advantage of it from outside that command.

I'll probably have to use this mechanism for the tests then: https://til.simonwillison.net/pytest/registering-plugins-in-tests

Partial prototype of datasette-verify:
from datasette import hookimpl
import click

@hookimpl
def register_commands(cli):
    from datasette.cli import sqlite_extensions
    @cli.command()
    @click.argument("files", type=click.Path(exists=True), nargs=-1)
    @sqlite_extensions
    def verify(files, sqlite_extensions):
        "Verify that files can be opened by Datasette"
        for file in files:
            print(file)

I had to move the from datasette.cli import sqlite_extensions inside the hook function to avoid a circular import.

Writing the test for this is proving difficult, because the cli module has already been imported when I attempt to register a new plugin - so it doesn't pick up on the additional command registrations.
Trying to work around that with importlib.reload(cli).

Documentation: https://docs.datasette.io/en/latest/plugin_hooks.html#register-commands-cli

I need to push this out as an alpha so I can release a demo plugin that uses it.


Add Java support

I'm going to close this because realistically it will be up to whoever has the need for it. With the team we have now, we can't implement and support this without contributions from outside.


chore(main): release 0.39.1

:robot: I have created a release beep boop
0.39.1 (2024-05-22)
Miscellaneous

deps: update momento requirement from 0.38.0 to 0.39.0 in /example (#331) (7bf0f16)
implement Debug for DictionaryFetchResponse, tweak debug fmt utils (#335) (37dd7a9)
move existing examples to a subdirectory (#337) (eb16864)
move sdk source code to a subdir (#338) (8eddf9a)
run ci on ubuntu-24.04 (#332) (8338069)
update stability to beta (#336) (ebf044f)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/momentohq/client-sdk-rust/releases/tag/v0.39.1 :sunflower:


Skip with Schema Generation

For some Params, I want to skip with Schema Generation as I use this with KubeApps. I want to only show values in the values.schema.json that are useful or desirable to have be set by customers, while still providing documentation.
The goal is to have people be able to easily spin up an easy chart that only shows values that are important and let the configuration done for more rare things be conducted inside a direct yaml editor.

We have a similar use case. When we configure the helm values, we set the default values, and the rest are marked as @skip because they are nullable. In the following example, stack.mode is not added to the schema, but it is to the documentation. This makes the schema incomplete to use it in VSCode # yaml-language-server: $schema=./docs/schema.json
## @section stack Configuration for the deployment
## @param stack.mode [string, nullable] way to deploy
## @param stack.version version of the stack
stack:
  version: 8.10.3

## Parameters

### stack Configuration for the deployment

| Name            | Description          | Value       |
| --------------- | -------------------- | ----------- |
| `stack.mode`    | way to deploy        | `undefined` |
| `stack.version` | version of the stack | `8.10.3`    |

{
    "title": "Chart Values",
    "type": "object",
    "properties": {
        "stack": {
            "type": "object",
            "properties": {
                "version": {
                    "type": "string",
                    "description": "version of the stack",
                    "default": "8.10.3"
                }
            }
        }
    }
}

Hi @jl-beast and @kuisathaverat.
We have released version 2.6.0 and now modifiers also apply to schema generation. Could you please give it a try to check if your issues are solved with that version?

I have to review it with the real YAML I have because some of the default values disappeared with the new version. With a tiny example seems to work fine.
## @section stack Configuration for the deployment
## @param stack.mode [string, nullable] way to deploy
## @param stack.version version of the stack
## @param stack.elasticsearch.image image to use for elasticsearch
stack:
  version: 8.10.3
  elasticsearch:
    image: docked.example.com/elasticsearch:8.10.3

{
    "title": "Chart Values",
    "type": "object",
    "properties": {
        "stack": {
            "type": "object",
            "properties": {
                "version": {
                    "type": "string",
                    "description": "version of the stack",
                    "default": "8.10.3"
                },
                "elasticsearch": {
                    "type": "object",
                    "properties": {
                        "image": {
                            "type": "string",
                            "description": "image to use for elasticsearch",
                            "default": "docked.example.com/elasticsearch:8.10.3"
                        }
                    }
                }
            }
        }
    }
}

# Cluster Configuration

## Parameters

### stack Configuration for the deployment

| Name                        | Description                    | Value                                     |
| --------------------------- | ------------------------------ | ----------------------------------------- |
| `stack.mode`                | way to deploy                  | `undefined`                               |
| `stack.version`             | version of the stack           | `8.10.3`                                  |
| `stack.elasticsearch.image` | image to use for elasticsearch | `docked.example.com/elasticsearch:8.10.3` |

If you pass the type the schema does not have the default and the markdown is not generated
## @param version [string] Version of app (default: 0.5.0)
version: 0.5.0

{
    "title": "Chart Values",
    "type": "object",
    "properties": {
        "ess_terraform_version": {
            "type": "string",
            "description": "Version of the Elastic terraform provider to use (default: 0.5.0)",
            "default": "0.5.0"
        }
    }
}

# Cluster Configuration

## Parameters

If you remove the type the schema is correct bit the markdown is not
## @param version Version of app (default: 0.5.0)
version: 0.5.0

{
    "title": "Chart Values",
    "type": "object",
    "properties": {
        "ess_terraform_version": {
            "type": "string",
            "description": "Version of the Elastic terraform provider to use (default: 0.5.0)",
            "default": "0.5.0"
        }
    }
}

# Cluster Configuration

## Parameters

Sorry for my very late response.
I've just created an internal task to fix this issue


Typo in auto-generated  "kubeadm Configuration (v1beta4)" reference page

found typo "ontrolPlaneEndpoint" in the below

There is a typo "ontrolPlaneEndpoint" in the localAPIEndpoint description it should be "controlPlaneEndpoint"
https://kubernetes.io/docs/reference/config-api/kubeadm-config.v1beta4/#kubeadm-k8s-io-v1beta4-InitConfiguration

Page related to issue: https://kubernetes.io/docs/reference/config-api/kubeadm-config.v1beta4
/language en

/retitle Typo in auto-generated  "kubeadm Configuration (v1beta4)" reference page

The mentioned reference page for "kubeadm Configuration (v1beta4)" is automatically generated. The page is generated from the upstream source code kubernetes/kubernetes.
As the page is generated from the upstream source code, any fixes would need to be addressed there. For those interested in contributing to resolve this issue, please refer to the upstream contribution guidelines outlined at: https://kubernetes.io/docs/contribute/generate-ref-docs/contribute-upstream

/sig docs

this is not a typo in the code files
https://github.com/kubernetes/kubernetes/blob/master/cmd/kubeadm/app/apis/kubeadm/v1beta4/types.go#L51
https://github.com/kubernetes/kubernetes/blob/master/cmd/kubeadm/app/apis/kubeadm/v1beta3/types.go#L47
and also in my browser it's shown as controlPlaneEndpoint, so maybe it's a rendering issue.

cc @tengqm

the image is for v1beta3, but v1beta4 does have the problem as the OP shows.

the c in controlPlaneEndpoint is also dropped in another place on that page, screenshot below. I'm not familiar with the autogeneration for these pages, is there some processing on the word that is dropping letters when converting from the original? Looks like in the source file its written with a capital and in the generated file its with a lower case. Not sure why it would only so it sometimes though.
We should check to see if this is happening on other pages.
/priority awaiting-more-evidence

Another interesting observation looking at the Code Search instances of this - it appears to only happen on the v1beta4 version of the docs, not the previous versions.
Looks like it was modified with<PHONE_NUMBER>5.

Put up a fix in #45709. It looks like this wasn't from an autogeneration error and just a simple typo when the docs were updated for v1beta4.


fix: 修复 steps extra 渲染问题

🤔 这个 PR 的性质是？

[ ] 日常 bug 修复
[ ] 新特性提交
[ ] 文档改进
[ ] 演示代码改进
[ ] 组件样式/交互改进
[ ] CI/CD 改进
[ ] 重构
[ ] 代码风格优化
[ ] 测试用例
[ ] 分支合并
[ ] 其他

🔗 相关 Issue

💡 需求背景和解决方案

📝 更新日志

fix(组件名称): 处理问题或特性描述 ...

[ ] 本条 PR 不需要纳入 Changelog

☑ 请求合并前的自查清单
⚠ 请自检并全部勾选全部选项。⚠

[ ] 文档已补充或无须补充
[ ] 代码演示已提供或无须提供
[ ] TypeScript 定义已补充或无须补充
[ ] Changelog 已提供或无须提供

Codecov Report

:exclamation: No coverage uploaded for pull request base (develop@b6acdb1). Click here to learn what that means.
The diff coverage is n/a.

:exclamation: Current head 27ede0b differs from pull request most recent head d7eb240. Consider uploading reports for the commit d7eb240 to get more accurate results

@@            Coverage Diff             @@
##             develop     #769   +/-   ##
==========================================
  Coverage           ?   61.50%
==========================================
  Files              ?      404
  Lines              ?    14146
  Branches           ?     2702
==========================================
  Hits               ?     8700
  Misses             ?     5191
  Partials           ?      255

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6acdb1...d7eb240. Read the comment docs.


Invalid RUF028 for match case header

The doc suggests:

# fmt: skip comments suppress formatting for a preceding statement, case header, decorator, function definition, or class definition

but for the following use case, I get a RUF028 warning. I believe this should be acceptable.
string = "hello"
match string:
    case ("C"
        | "CX"
        | "R"
        | "RX"
        | "S"
        | "SP"
        | "WAP"
        | "XX"
        | "Y"
        | "YY"
        | "YZ"
        | "Z"
        | "ZZ"
    ):  # fmt: skip
        pass
    case _:
        pass

❯ ruff --version
ruff 0.3.0

relevant ruff.toml setting:
[format]
preview = true

@snowsignal would you mind taking a look at this?


Coalesce Citation Information - page number

If there are multiple citation sources, one thing that could be done would be to look from an ordered list, and continuously add in parameters.  For example, if the best citation didn't include a volume  number, but the next best did, then use the volume number from that citation source.
@Vensberg will select a set of parameters to include in such a scheme.  To help, Elseveir provides some great tools for investigating citeproc citations.  csl.mendeley.com Specifically, the Visual Editor can help identify these, for  example; using APA as an example, the following figure shows where the 'issue' parameter is used in the citation.

We are starting with a very limited idea.  Coalescing ~page_number~.  Note, that I've discovered one example where a page number that is added, can't actually be added to the system, since it's so big, and so an idea for  this is we could coalesce on the minimum value in this case.
There is on example 3538204 publication, that could benefit from a fixed page_number, but unfortunately there is only one datasource for  this.

If we look at the source of all the pagination, then can see that although
most best citations have pages, there are quite a few that get filled in
with a later citation.
  select ?best ?page  (count(*) AS ?CNT) WHERE {
    VALUES (?best ?p) {
      ("verified-manual" 1) ("epmc" 2) ("pubmed" 3)  ("scopus" 4)("wos" 5) ("wos-lite" 6)
      ("crossref" 7)  ("dimensions" 8) ("arxiv" 9)("orcid" 10) ("dblp" 11)  ("cinii-english" 12)
      ("repec" 13)  ("figshare" 14)  ("cinii-japanese" 15) ("manual" 16)  ("dspace" 17) }

    VALUES (?page ?p2) {
      ("verified-manual" 1) ("epmc" 2) ("pubmed" 3)  ("scopus" 4)("wos" 5) ("wos-lite" 6)
      ("crossref" 7)  ("dimensions" 8) ("arxiv" 9)("orcid" 10) ("dblp" 11)  ("cinii-english" 12)
      ("repec" 13)  ("figshare" 14)  ("cinii-japanese" 15) ("manual" 16)  ("dspace" 17) }

    ?work ucdrp:best_source ?best;
          ucdrp:pagination_source ?page;
          .
    #  filter( ?best != ?page)
  } group by ?best ?page  ?p ?p2 order by ?p ?p2

This table is in order of preference of citation use.

best
page
CNT

epmc
epmc
2099

epmc
scopus
13

epmc
wos-lite
1

epmc
crossref
60

epmc
dimensions
7

pubmed
wos-lite
1

scopus
scopus
5274

scopus
wos-lite
97

scopus
crossref
336

scopus
dimensions
259

scopus
dblp
1

scopus
dspace
1

wos-lite
wos-lite
733

wos-lite
crossref
35

wos-lite
dimensions
2

wos-lite
manual
1

crossref
crossref
76

crossref
dimensions
32

crossref
dspace
1

dimensions
dimensions
18

arxiv
arxiv
3

dblp
dblp
47

cinii-english
cinii-english
2

manual
manual
129

dspace
dspace
4

Many citations have been improved with added pages.
All the ones that I checked that are still missing pages have only the starting page listed in the citation. E.g.
https://dev.experts.ucdavis.edu/work/3109768
https://oapolicy.universityofcalifornia.edu/viewobject.html?cid=1&id=3109768
@qjhart, if it is a big lift to allow a single page for pagination (and leave off the end page), let's leave it for 1.5
Some publications have lost abstracts, but that was expected since the sources were reprioritized. This will be addressed in the next increment of improving citations.


Deletion of always true check

sess_id_len is defined in the previous if/else blocks as
if (...) {
    if (...) {
        sess_id_len = sizeof(s->tmp_session_id);
        ...
    } else {
        sess_id_len = 0;
    }
else {
    sess_id_len = s->session->session_id_length;
    ...
    memcpy(s->tmp_session_id, s->session->session_id, sess_id_len);
}

Either
*s->session->session_id_length is always lesser than sizeof(s->session->session_id) and this check is useless

or it should be done before memcpy three lines above

Relevant question in the context is whether or not s->session->session_id_length can be affected by peer's input. Not that I know the answer to this question, I'm only saying that it's the one that would answer your "either" question. Even if it's not affected, one can still argue that it wouldn't be inappropriate to leave a note that removed condition is always met [because of this-n-that]. A way to leave such note can be assert(sess_id_len <= sizeof(s->session->session_id); Some could argue that it could as well be ossl_assert, but I'd say that it's not inappropriate to reduce amount of conditions in production builds. (Recall that assert is compiled as "nop" in production build.)

Relevant question in the context is whether or not s->session->session_id_length can be affected by peer's input.

I agree. And I guess it is not affected by user's input

A way to leave such note can be assert

Good idea, here is a new patch

I guess it is not affected by user's input

Formally speaking it's not a guessing game. Otherwise you've got to #include <assert.h>.

Formally speaking it's not a guessing game

Sure, but since I can not prove it, that is the best I can do so far.

I am not angry :-) I was rather wondering if this check is always true or not.
If it were not then it should be done before the memcpy.
Since we suppose it to be always true, there is no big deal.
In our case, the compile will not optimize this check, right ?

In our case, the compile will not optimize this check, right ?

Right.
Editorial note. If I will be one who commits this, then I intend to change commit subject to "statem/statem_clnt.c: omit redundant check in tls_construct_client_hello."

No problem for renaming 👍

Merged. Thanks.


[30613] merging v.1.11.0 from jsforce:master

Pull Request Checklist

Description of Change
Part of Dec 2021 npm audit.
Updating repo to match v1.11.0 from https://github.com/jsforce/jsforce
Customer Notification

[ ] Requires customer notification.
[ ] Customers Notified.

Pull Request Author

[ ] If for a large feature, Design Doc created/updated/approved.
[x] Met requirements as written in stories.
[ ] Includes tests for all testable files.
[x] Thought about edge cases the new code might introduce.
[ ] Checked locally to make sure feature / related features still work.

1st Code Reviewer

[ ] Met requirements as written in stories.
[ ] Includes tests for all testable files.
[ ] Thought about edge cases the new code might introduce.
[ ] Checked locally to make sure feature / related features still work.

2nd Code Reviewer

[ ] Met requirements as written in stories.
[ ] Includes tests for all testable files.
[ ] Thought about edge cases the new code might introduce.
[ ] Checked locally to make sure feature / related features still work.

@ryanau I think this needs to be tested.


Examples: Sessions stay open even after programs exit

TODO: implement scopeguard

SAM sessions live and die with the socket they are associated with. When the socket is closed, the session dies, and all communications using the session die at the same time. And the other way round, when the session dies for any reason, the SAM bridge closes the socket." - SAMv3 docs.
My mistake, I assumed they lasted longer.


Add dependency from literal to jawn

//> using scala 3.5.1
//> using dep io.circe::circe-literal:0.14.10

import io.circe.literal.*
val key = "theKey"
println(json"{ $key: 123 }")

fails with "class not found".
It works after adding //> using dep io.circe::circe-parser:0.14.10

actually, the dependency should be to circe-jawn and not parser.

It works after adding //> using dep io.circe::circe-parser:0.14.10

Thanks!
It works after adding //> using dep io.circe::circe-jawn:0.14.10 as well :)
I updated the MR.


[feature]drag files on ssh terminal wnd can upload with zmodem

Now the behavior is just paste the local filepath on term,but this means nothing.

That would be very convenient :)


[Feature Request] Video stops when rotate the screen

Hey 👋
I would like it better if the playback of a video continues when you rotate the screen instead of stopping it.
I would not call this an issue but an improvement.
Other video players do not stop either.

Sure, I'll make sure it's fixed by next release


Remove linting from test scripts.

Seems unnecessary to be linting on the CI and every time we run a test script.
I think it might be wiser to make linting a pre-commit hook instead.

We can use Husky + lint-staged to setup git commit hooks for the repo.
Saying that, I think that linting is something that should run on CI and not on every commit.
If during the course of coding I make 5 commits and linting takes 2 minute each time that's 10 minutes of dev time.
If CI does it it's 2 minutes of robot time...

In practice, linting doesn't add any time to circleci runs, as it's not the rate-limiting step. The whole job takes less than 30s After this has been merged, we could move the lint check to the build:ci job, and we wouldn't have to spin up a container just to run yarn lint. Would you be opposed to keeping it in CI in that context?

I just tried this out locally, and I would personally find it more annoying to wait 5s on each local commit compared to waiting 5s on each circleci run. At the same time, having lint:check (or some other similar command) run in a pre-commit hook seems like a good idea, since it means the git history always conforms to some set of rules.

Oh, I completely misunderstood the intention of the PR until just now. I see that linting is still checked in circle:ci, it's just not checked twice.
I've made another PR branched from this, which combines yarn lint:ci with yarn build:ci, and speeds up the pre-commit hook.


Binary Indexed Tree (Fenwick Tree)

Since you've added SegmentTree, I think it's good to add Fenwick too, they differ on speed and some usages.

Thanks for the suggestion @farzadshbfn! 👍 I would be happy to include the Fenwick Tree data structure in the repo if anyone would like to contribute.

I'd give it a try ;)... it's not the code that needs time... it's ReadMe 🙃


Factor the task runner out of Packager.

The current design of Packager is a bit too optimized for batch processing, not convenient for on-demand processing (e.g. suppose Packager is used inside some server process). After this change,
Packager.Run will return error rather than accumulate it into a field. Packager will no longer prevent the same resource from being accessed multiple times in some cases, but will still cache signed exchanges and reuse them without making a server access. We can also write a wrapper around FetchClient to "cache" HTTP responses, when needed.

Let me know if you find anything else. Thanks.


Instance Issue: Christie Projector Shuttering

Shutter open feature does not work. Shutter close does work.
Using Christie HD14K projectors

Please check the latest version of the module and if it is still not working, re-open this issue and let me know.


How to use Tone.js to preserve audio's pitch when changing its playbackRate using AudioBufferSourceNode

I used sample code on MDN github to change an audio's playbackRate but the original audio pitch is not preserved.
audioCtx.decodeAudioData(audioData, function(buffer) {
      myBuffer = buffer;
      source.buffer = myBuffer;
      source.connect(offlineCtx.destination);
      source.playbackRate = 1.5; // <<<<<<<<< added this to change playbackRate
      source.start();
      //source.loop = true;
      offlineCtx.startRendering().then(function(renderedBuffer) {
        console.log('Rendering completed successfully');

        let song = audioCtx.createBufferSource();
        song.buffer = renderedBuffer;

        song.connect(audioCtx.destination);

        play.onclick = function() {
          song.start();
        }
      }).catch(function(err) {
          console.log('Rendering failed: ' + err);
          // Note: The promise should reject when startRendering is called a second time on an OfflineAudioContext
      });
    });

It is the same question as this Stackoverflow question
Jacob suggested in this thread that we can use Tone.js to change the pitch. I am not really sure how to make it make it work.

I am not sure how I can achieve this and I am not familiar with semitone / cents etc. Can you someone point me to the right direction? Thank you

I would use GrainPlayer which would give you that control. Tone.PitchShift might also work, but would likely introduce more artifacts.
A semitone is a single step in a chromatic scale like between C to C#.

@tambien
Thank you for your help. I have 2 questions if you don't mind.

I made a CodePen used GrainPlayer to play audioBook short clip at higher playbackRate and compared it with HTML audio element playing audio at a higher playbackRate. The audio playback by GrainPlayer seems to have some echo. Is that expected?
source = new Tone.GrainPlayer({url: audioBuffer, playbackRate: 2})
source.toDestination()
source.start(0);

https://codepen.io/juny711/pen/abwjaJE
You can download the audio I used from my github repo

It is the same question as the above.
How can I get the renderedAudioBuffer out from GrainPlayer so that I can pass it to OfflineAudioContext or how do I set the destination as OfflineAudioContext?


Outdated PHP 5.6

Hi,
I'm wondering why we still use PHP 5.6?
It's unsupported and outdated and FreePBX does support 7.x.
This may be a security vulnerability.

I'd love to see us using PHP 7 however not all the modules are compatible at this time.
It won't be until Freepbx 16 is released that they provide true PHP 7.2 (minimum) support for all modules as per a recent post by the developers.

7.3 still testing in latest patch, I think, you can try change 5.6 to 7.3 in docker environment and test it.
https://github.com/tiredofit/docker-freepbx/pull/149


Add utility for creating a table

Based on this code: https://github.com/feathersjs/feathers-generator/pull/30/files#r88298599
I think we should move this into a standalone utility inside the feathers-rethinkdb repo, so you can just do something like this.
const createTable = require('feathers-rethinkdb/create-table');
const r = require('rethinkdbdash');

createTable('tableName', r).then(...)

This hides the really ugly table setup code that rethinkdb requires (+1 for hiding it behind a module), but handy for portability (between dbs) and cheap to keep in the app initialization.

Could the service just do that like app.service('rethinkservice').createTable()?

I vote yes.  Then r doesn't have to be passed separately. 👍

Agreed. I'm working on this In the generator right now and will push up a PR for it on this side shortly.

@daffl @marshallswain do you guys agree we'll also need to add an option I the constructor so it's called dynamically when required via service.json and feathers-bootstrap? service.model.js doesn't implement feathers-rethink db, rather is a dependency of it.

FYI, I've implemented this in #55.


View permissions for collections don't restrict image view access

Issue description:
When trying to set image/document permissions according to the documentation (https://docs.wagtail.io/en/v2.11.3/topics/permissions.html) by adding them to a collection and restricting it's permission (for example to only viewable for logged in users). However, the possibility to view the images in the collection is still viewable for everyone
Proposal:
When checking the code the page restriction is handled by the use of executing the hook 'before_serve_page' before serving the page. However, even though most logic seems to be in place, such a construct don't seem to be in place for images. Therefore my proposal would be to add a new hook 'before_image_rendition' in the AbstractRendition.
Questions:
What might be needed also is for sure what should happen when an image is not permitted to view, should nothing be displayed or should there be a sign in field or something entirely different?
Have I misunderstood the functionality or are there a better solution than the one proposed above?

Forgot to write but issue is verified in a fresh install of wagtail 2.11.3

Hi @mr-klint - thanks for the report. There's an existing issue open for this, at #3880.


AWSSDK AutoScaling not found (dotnet core)

Hello,
I try to use AutoScalingClient in a dotnet core 1.1 program.
I already use ECS in this program, and everything is fine.
But for AutoScaling, the namespace is not even found into Visual Studio 2017 Pro.
The installed nuget is AWSSDK.AutoScaling 3.3.1.
Is something missing into the SDK, or the nuget is corrupt ?
Thanks

This could be caused by the dotnet tools not properly restoring the dependencies. Try closing Visual Studio, then running dotnet restore from your project directory.

All nuget are installed correctly, actually I have only AWSSDK.ECS and AWSSDK.AutoScaling.
Both use AWSSDL.Core 3.3.17

Nevermind, after few close and reopen, switching to dotnet core 1.1.2 and everything is fine.


fix1695: update LH volume status to pvc and vm annotations

IMPORTANT: Please do not create a Pull Request without creating an issue first.
Problem:

LH volumes` bad status like disk space is not enough,  is not easily found in Harvester WEBUI and kubectl.
Solution:

This fix tries to abstract the error status of LH volume, and update them to PVC and VMs annotations  With web UIs fix (coming in another PR), the info will be displayed in PVC and VM page.

update LH volume status to PVC when change and remove
update PVC status to VM when change and remove
strip VM volume status when it is restored from vm backup

Related Issue:
#1695
Test plan:

The design consideration:

As a side note: I believe that current KibeVirt supports hotplug and hotunplug disks without restart VMs, but it seems that harvesters haven't integrated that part well.

If I interpret it correctly, the last test case in the test plan is adding a hotplug volume. At first glance, it seems weird that removing volume need a VM restart. However, if we have the "Remove volume" (hot-unplug) button, then it should be removed without restart the VM. I feel like you don't need to handle that situation in this PR.

If I interpret it correctly, the last test case in the test plan is adding a hotplug volume. At first glance, it seems weird that removing volume need a VM restart. However, if we have the "Remove volume" (hot-unplug) button, then it should be removed without restart the VM. I feel like you don't need to handle that situation in this PR.

--
The tricky is, one volume may be in "unusable" real state even though it shows"Ready", no matter normal "add volume" or  "hotplug"  , we should block those actions. Otherwise, the effect is unpredictable.
I filed #1931 to track it.

Overall it's in a good shape. Would you mind adding some tests, as other controllers do?
Edit: All test case you listed work as expected.

--
The "test" file will be designed and committed in another PR. The status is updated from LH volume, to PVC, to VM, is a bit complex. This PR makes sure those manual test cases are well covered first.

Oh unfortunately the code hit the CodeFactor CI check 🤯
You might need to extract function from the so-called "complex code" to other files.

Oh unfortunately the code hit the CodeFactor CI check 🤯 You might need to extract items from the so-called "complex code" to other files. That's my bad suggesting you to add doc comment on those items 🙇🏾

--
The CodeFactor issue here is interesting.
I did a test:
It claims complex code of pkg/controller/master/backup/restore.go

There are 3 lines added in restore.go

I tried to remove those 3 lines from restore.go
CodeFactor does not complain anymore, all other 4 files are fine.

Conclusion: CodeFactor  here complains the existing code in  pkg/controller/master/backup/restore.go, please skip it.

As tested and explained in https://github.com/harvester/harvester/pull/1923#issuecomment-1048564904
Please skip the CodeFactor  failing in this PR, it is complaining the existing code in pkg/controller/master/backup/restore.go, saying some parts are complex codes, but it does not mention which function.
@weihanglo @FrankYang0529 @guangbochen

Remark: CodeFactor is happy again with all 5 changed files in https://github.com/harvester/harvester/commit/1980296fd9c353b59ad23cc6dcbece490aef78ba.

Here, it complained pkg/controller/master/backup/restore.go
https://github.com/harvester/harvester/pull/1923#issuecomment-1048564904
But those 2 commits have no different change in restore.go.
No idea why CodeFactor does so.

update:
LH will have a solution to update status/message to PVC, Harvester will get the real status from PVC directly. The Harvester (planned in v1.0.2) implementation will re-adapt with LH (planned in v1.2.5) solution .


feat(amplify-nodejs-function-template-provider): make function name to lower case in package.json

Description of changes
improve function name matches spec for package.json name field.

Issue #, if available
fix #7905

Description of how you validated changes
Manual Testing:

Run amplify-dev function add.
Select lambda function.
Type testFunction when cli asks Provide an AWS Lambda function name
Select Node.js when cli asks Choose the runtime that you want to use
Select Hello World when cli asks Choose the function template that you want to use

Checklist

[x] PR description included
[x] yarn test passes

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #9868 (120a429) into master (44a9bea) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #9868   +/-   ##
=======================================
  Coverage   53.11%   53.11%
=======================================
  Files         830      830
  Lines       46002    46002
  Branches     9829     9829
=======================================
  Hits        24433    24433
  Misses      19557    19557
  Partials     2012     2012

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44a9bea...120a429. Read the comment docs.


introduce API force reconnect() for update SSL cert

for SSL-based goovn client,  if the TLSconfig cert updated based on security, the client needs to disconnect the live connection and connect again use the updated TLSconfig.
@hzhou8  Any suggestions about how to support this?
the API can use internal function c.client.disconnect() and reconnect() I think.

tls config struct already have methods to get cert so you don't need to restart app for mTLS like stuff, but why you need to drop old connection forcable ?

tls config struct already have methods to get cert so you don't need to restart app for mTLS like stuff, but why you need to drop old connection forcable ?

@vtolstov thanks for the quick reply.
Could you please share more info about how tlsconfig automatic load new key pairs?
I am referring the code goovn usage in ovn-kubernetes.
https://github.com/ovn-org/ovn-kubernetes/blob/master/go-controller/pkg/util/go_ovn.go
L70-L98.
cert, err := tls.LoadX509KeyPair(certFile, privKeyFile)
if the certFile, privKeyFile content changed,  my thinking is I need get new cert bytes and update to the *.tlsConfig.
but based my test goovn client will not use the cert unless the connection broken and reconnect callback happened.
please correct me if my understanding is wrong.

@vtolstov thanks for the quick reply.
Could you please share more info about how tlsconfig automatic load new key pairs?
I am referring the code goovn usage in ovn-kubernetes.
https://github.com/ovn-org/ovn-kubernetes/blob/master/go-controller/pkg/util/go_ovn.go
L70-L98.
cert, err := tls.LoadX509KeyPair(certFile, privKeyFile)
if the certFile, privKeyFile content changed,  my thinking is I need get new cert bytes and update to the *.tlsConfig.
but based my test goovn client will not use the cert unless the connection broken and reconnect callback happened.
please correct me if my understanding is wrong.

in this case this is not possible, you need to extend ovn-kubernetes to use https://golang.org/pkg/crypto/tls/#Config
GetCertificate func(*ClientHelloInfo) (*Certificate, error) // Go 1.4
and
GetClientCertificate func(*CertificateRequestInfo) (*Certificate, error) // Go 1.8
mostly you need to read google about mTLS in golang and dynamic certs

in this case this is not possible, you need to extend ovn-kubernetes to use https://golang.org/pkg/crypto/tls/#Config
GetCertificate func(*ClientHelloInfo) (*Certificate, error) // Go 1.4
and
GetClientCertificate func(*CertificateRequestInfo) (*Certificate, error) // Go 1.8
mostly you need to read google about mTLS in golang and dynamic certs

Thanks for the info.
From the comments in the function:
// GetClientCertificate may be called multiple times for the same
|   | // connection if renegotiation occurs or if TLS 1.3 is in use.
  |   | GetClientCertificate func(*CertificateRequestInfo) (*Certificate, error)
The function can be called when Server-side starts renegotiation when after the client in the connected state.
For goovn.Client,  the sever side is ovsdb-server which I support TLS1.2 1.1 1.0 from the man page.
http://www.openvswitch.org/support/dist-docs/ovsdb-server.1.html
My understanding is if ovsdb-sever process does not start renegotiation, then goovn.Client still use the old cert.
Please correct me if my understanding if wrong.
Thanks for your help.

Thanks for the info.
From the comments in the function:
// GetClientCertificate may be called multiple times for the same
|   | // connection if renegotiation occurs or if TLS 1.3 is in use.
  |   | GetClientCertificate func(*CertificateRequestInfo) (*Certificate, error)
The function can be called when Server-side starts renegotiation when after the client in the connected state.
For goovn.Client,  the sever side is ovsdb-server which I support TLS1.2 1.1 1.0 from the man page.
http://www.openvswitch.org/support/dist-docs/ovsdb-server.1.html
My understanding is if ovsdb-sever process does not start renegotiation, then goovn.Client still use the old cert.
Please correct me if my understanding if wrong.
Thanks for your help.

yesm may be, i don't know about tls version in ovn =(

yesm may be, i don't know about tls version in ovn =(

I think an API like ForceReconnect() would be no different than calling Close() and NewClient() again. Maybe we should find a better to way to support dynamic cert rotation (maybe support it from ovsdb server side first).

I think an API like ForceReconnect() would be no different than calling Close() and NewClient() again. Maybe we should find a better to way to support dynamic cert rotation (maybe support it from ovsdb server side first).

@hzhou8 yeah, i think so

@hzhou8 yeah, i think so

@hzhou8 thanks for your comments.
Yes, the application can use the current API to finish the task using your suggested method.
The reason I am thinking to introduce this API is making the current ovn-k8s code easy to support it.
From the application level,  if it detects cert/key pair change, then just update the tlsConfig cert file with goovn.Client.ForceReconnect().

@hzhou8 thanks for your comments.
Yes, the application can use the current API to finish the task using your suggested method.
The reason I am thinking to introduce this API is making the current ovn-k8s code easy to support it.
From the application level,  if it detects cert/key pair change, then just update the tlsConfig cert file with goovn.Client.ForceReconnect().


Import game information

Take what galaxy is given and import game data, pictures and metadata.

The partial implementation has Caused the need for #6 .


Adding aggregateTx_InnerTx.toAggregate() for single signer

Enhancement feature - For discussion

Raised by Aleix on slack

AggregatedCompleteTransaction
At the moment when issuing an Aggregated Complete Transaction, PublicAccount is used as a mandatory parameter on innerTx.toAggregate(..) for every inner transactions. Catapult server will validate cosignatories if multiple accounts (signers) provided in the inner transactions to make sure the AggregateCompleteTransaction isComplete. There could be potentially an enhancement to be created by making this parameter optional. So that the ACT Can/Only be signed by the issuer if other signers are unknown.
example:
const transferTransaction = TransferTransaction.create(
                Deadline.create(),
                recipient.address,
                [NetworkCurrencyMosaic.createAbsolute(1)],
                PlainMessage.create('test-message'),
                NetworkType.MIJIN_TEST,
            );
const aggregateTransaction = AggregateTransaction.createComplete(Deadline.create(),
                [transferTransaction.toAggregate()],
                NetworkType.MIJIN_TEST,
                [],
            );
const signedTransaction = aggregateTransaction.signWith(issuer, generationHash);

Node that the inner transaction's toAggregate method is taking zero parameter, so the only the issuer is needed to sign the ACT

My view of this is this enhancement is Optional as when construct the ACT, the toAggregate() method can take the issuer's Public Account, so that only the issuer is required to sign.
const transferTransaction = TransferTransaction.create(
                Deadline.create(),
                account2.address,
                [NetworkCurrencyMosaic.createAbsolute(1)],
                PlainMessage.create('test-message'),
                NetworkType.MIJIN_TEST,
            );
const aggregateTransaction = AggregateTransaction.createComplete(Deadline.create(),
                [transferTransaction.toAggregate(account.publicAccount)],
                NetworkType.MIJIN_TEST,
                [],
            );
const signedTransaction = aggregateTransaction.signWith(account, generationHash);

This feature in fact delegates signature validation to an external entity and can be useful for application that implement aggregate transactions without knowing exactly who will be signing.
What can be done on the side of the SDK is to have the parameter set to be optional, and delegate the verification of "correct signer" to the broadcaster where, in case the signer is not set, the issuer is used. In those cases, transactions will most likely be passed over as payloads, and wallets intercept the payload and fills it with the correct issuer public key before it get broadcast.
The AggregateTransaction.signWith method could stay as is and the toAggregate method should store undefined in the publicAccount field such that signWith will recognize and fill with issuer when needed.

Just to confirm that this logic only applies on AggregateComplete transaction!


How-to: Obtain an access token using a specific grant_type

Publish a guide on How-to: Obtain an access token using a specific grant_type:

authorization_code
client_credentials
refresh_token

Related gh-499

Hey @jgrandja Can I work on this?

Thanks for your interest @likith187.
We are prioritizing "How-to guides" based on up-votes and this one doesn't have any yet so we'll wait on this one.
As well, we're still early in writing the reference documentation and have a few things we need to iron out as far as the format goes. Our plan is to release the initial version in 0.3.0 and then will likely open things up to external contributions at that point.

Closing this issue as it's redundant given the samples demonstrate the various grant_type flows.


[Message Reactions - UI] Need feature like emojies to get rendered in bot messages for webchat.

@compulim  as per the request i have created the mockup for the custom feature.
here is the follow up link of last feature requirement was raised.
Link:- https://github.com/microsoft/BotFramework-WebChat/issues/2431
please see this attachment.
powerpoint.pptx

Hello @Bradrajkumar - thanks for the suggestion.  We'll take the UI guidance as we prioritize our upcoming WebChat sprint.
As far as protocol support: making use of custom events going through Direct Line would be the suggested approach for message reactions. The Message Reaction activity type is currently not supported in Direct Line (cc @dandriscoll )

@cwhitten @dandriscoll Are you sure Direct Line doesn't support message reactions? The current Custom Reaction Button Web Chat sample sends a message reaction activity to the bot and works fine with the onReactionsAdded and onReactionsRemoved handlers.
handleDownvoteButton = () =>
  this.props.postActivity({
    type: 'messageReaction',
    reactionsAdded: [{ activityID: this.props.activityID, helpful: -1 }]
  });

https://github.com/microsoft/BotFramework-WebChat/blob/3cf5d9bef057920e7ab8812507d320441594e1de/samples/09.customization-reaction-buttons/index.html#L73

IMO, your Teams emoji design is targeting user-to-user conversation, but not user-to-bot conversation. So I don't think 80% or more users are going to benefit from this feature. Making this feature in production doesn't make sense to me.
The sample linked by @tdurnford makes sense to me because it is upvote/downvote button. It will benefit bot designers to get feedback about their bots. And this means it could benefit a larger number of users.
In your #2431, you mentioned React is not an option in your case. Web Chat support different tiers of customization. For this tier of customization (a.k.a. custom activity/attachment renderers), because of its complexity, it is only supported when using React. We won't be able to build this feature for you in JavaScript.

@compulim  if you are not able to provide me the javascript solution please provide me the react code with the requirement i want i.e. feedback as well as reactions for every mesages rendering from bot side(if possible).
FYI
i tried adding feedback for the message using react and it rendering for only text responses, not for any rich responses. so is it possible that for all the responses the feedback option should render from bot side?
please do let me know if possible with required solution.


[DAOSpace]: Review StakeToSBT plugin and  GrantWithSBTPlugin SBT distribute strategy

The SBT plays an important role in the DAOSpace, representing the membership and the voting weight of the members in the DAO's governance.
See the documentation: https://starcoin.atlassian.net/wiki/spaces/DAO/pages/33849405/Starcoin+DAOSpace+SBT+DAO
Different DAOs can convert members' contribution values into SBTs through a plugin mechanism so that DAOSpace can be adapted to any type of DAO.
Take the following two plugins as examples.
I. StakeToSBTPlugin
Users can obtain SBT by stake Token for a period.
According to the current design, SBT is a reward for one period of stake Token, so SBT is obtained when the user stakes the Token, and the SBT will not be reduced when the user unstake.
However, if the user quits the DAO during the period, the SBT will be emptied, and the staked Token can only be retrieved after the stake expires.
However, there may be a potential issue with this design. When the user's stake period expires, the user still has the right to vote, but he is weakly bound to the interests of the DAO and may not be able to make decisions based on the long-term interests of the DAO.
II. GrantWithSBTPlugin
StarcoinDAO has a seed member plan, which rewards seed members with SBT voting rights and the Grant. The SBT amount is positively correlated with the Grant amount; the Token of the Grant is linear release, and the SBT amount is issued at once.
The question is whether SBT voting rights are automatically reduced as the Grants are released and withdrawn. The reasoning is similar to the above.

在 DAOSpace 的设计中，SBT 是其中重要的一个角色，它既代表了成员身份，也代表了成员在 DAO 中的治理投票权重。参看文档： https://starcoin.atlassian.net/wiki/spaces/DAO/pages/33849405/Starcoin+DAOSpace+SBT+DAO
不同的 DAO 可以通过插件机制，将成员的贡献值转换成 SBT，这样 DAOSpace 就可以适配到任何类型的 DAO。
以下面两个插件为例：
一. StakeToSBTPlugin
用户可以通过 stake Token 一定周期来获取 SBT。
按当前的设计，SBT 是 stake Token 一个周期的奖励，所以设计逻辑上 SBT 在用户 stake Token 的那一刻就获得了，到期用户 unstake 的时候并不收回 SBT。
但如果期间用户退出 DAO，SBT 会被清空，而 stake 的 Token 只有到期后才能取回。
但这样设计，可能有一个潜在的问题，当用户到期 unstake 的时候，该用户依然有投票权，但和 DAO 的利益绑定又很弱，可能不能从 DAO 的长期利益出发进行决策。
二. GrantWithSBTPlugin
StarcoinDAO 有一个种子成员计划，给种子成员奖励 Grant 的时候同时给予 SBT 投票权，SBT 额度和 Grant 额度正相关。Grant 的 Token 按时间线型释放，SBT 额度是一次性发放。
这里有个问题是，随着 Grant 释放和提取，是否自动降低 SBT 投票权? 道理和上面的类似。

不过感觉普通用户主动质押stc的动力似乎没有那么强；starswap质押star得到vestar后，不仅可以投票、获得质押利息，还多了加速流动性挖矿加速赚取star的功能

不过感觉普通用户主动质押stc的动力似乎没有那么强；starswap质押star得到vestar后，不仅可以投票、获得质押利息，还多了加速流动性挖矿加速赚取star的功能

DAO 里质押 stc 也是要给奖励的


[beta] Night mode, buttons do not have a "web safe" border

Working on MBP in Chrome browser
The page in night mode:
http://beta.freecodecamp.com/en/settings
has 3 unselected buttons with a very dark border, is not accessible or "colorsafe"
.btn-twitter
.btn-linkedin
.btn-github
these buttons borders should be changed to
border:inherit;

i have provided a screenshot in another comment
to show the difference, linkedin does not have a proper border-color

@tommygebru we recently made the off-on buttons have a border-color of #777 on staging if you want to see if that solves it for the off-on switches. @raisedadead want to update the social ones too?

Very cool #777 should be fine, a little brighter wouldnt hurt either

Closing as resolved.


Release Google.Cloud.AdvisoryNotifications.V1 version 1.1.0

Changes in this release:
New features

Adding notification types (commit 2a8a2a6)

Created release for Google.Cloud.AdvisoryNotifications.V1-1.1.0


Failed POST request to play.google.com on signup

I tried out your library to authenticate with and I noticed in the console that there is a failed request to:
https://play.google.com/log?format=json&hasfast=true&authuser=0 getting back a 401
I am wondering firstly what this call is for and why it is being made?
And secondly why it is failing?
I also noticed this happens in your demo site too.
Any help would be great! Thanks

The same

Same error with me

Interesting
Actually these requests and the button are all done from google side, we don't fire requests manually unfortunately

The same for me, but there is no error in incognito mode, hm)


Trying to change display name

It's weird that your extension is 5th on the query autohotkey in marketplace:

By installs and rating I think it should be 2nd.
Could you try to change display name to be 2 words (from AutoHotkeyPlus to AutoHotkey Plus)
https://github.com/cweijan/vscode-autohotkey/blob/307a1a749042eb6eb6b5f42c5389142d10e0d558/package.json#L3
Don't know if it's going to work, but it just might.

It's possible, I try change name in next update.

It does become 2nd, interesting

Now you just need 80k more installs to get to the first place ⬆

Added to the Awesome list: https://github.com/viatsko/awesome-vscode/pull/303


Fixing sample code

Noticed the sample code didn't work on my shell (osx, OTP 20).  Now it matches the readme.io more.

Great, thanks for your help!

Yeah, cool stuff!  Are there more real world uses of this library yet?  And any docs on the available data types, I couldn't find any but I see there are alot more than just orset.

Unfortunately, not.  I haven't had much time to really write any documentation for this stuff since I've been focusing on some other work as part of my Ph.D.


Indeterminism in json array comparison (LenientJsonArrayPartialMatcher), Results are differening based on array order

Hello, I recently discovered your JSON comparison implementation, and it appears to be the most suitable one for my specific use case among the open-source options I explored. While playing with some examples, I encountered this scenario,
The scenario,
expected
[   {     "a": 1,     "d": 5   },   {     "a": 1,     "b": 5   } ]
actual
[   {     "a": 1,     "d": 2   },   {     "a": 1,     "b": 3   } ]
The result is,
The property "$.0.d" didn't match. Expected 5, Received: 2
The property "$.1.b" didn't match. Expected 5, Received: 3
Same scenario when order of actual is changed,
expected : same as above
actual :
[   {     "a": 1,     "b": 3   },   {     "a": 1,     "d": 2   } ]
The result is
The property "$.0.d" in the expected json is not found
The property "$.1.b" in the expected json is not found
Dependancy on order of actual for the comparison seems undesirable to me. Thoughts?

Hi,
I a strange behavior, I will check why the order have an impact on the result.

In fact this is due to comparaison issue between your object.
When the lib compare two arrays, they compare items using a similarity rate.
The similarity between two objects are computed base on structure (have same properties 50%) and on values (are same values 50%).
With you exemple, All object have a similarity rate of 75.

{ "a": 1, "d": 5 } and { "a": 1, "d": 2 }: 2 matching property (50%), 1 matching values on two property (25%) ==> 75%
{ "a": 1, "d": 5 } and { "a": 1, "b": 3 }: 1 marching property (25%),  1 matching value on one property (50%) ==> 75%

I should rework the similarity rate computation to fix this issue

Can you try with the 0.0.7 version?

Seems to work fine, Thanks for the quick reply and fix. i am observing another issue!, Have raised the same https://github.com/deblockt/json-diff/issues/12


Player: loaded/current/buffering widths should be CSS percentages, not pixel units

I am encountering numerous layout errors on viewport resize. The timeline and the volume control sometimes don't quite fit on the same line during/after a resize. It's basically a 1 pixel rounding error. It looks glitchy and breaks layout.
In general, elements that stretch should be sized in percentages. Listening for viewport resize and running a debounced callback that outputs new inline widths is much slower than native layout. There's no reason to touch the DOM here when the percentage loaded/played has stayed the same. All browsers support percentage widths so there's no browser support penalty. Also, sometimes page layout changes without a viewport resize, and that shouldn't break the player layout.
I would like this to be part of the 3.x CSS overhaul currently under discussion, if there are no objections.

Of course any improvements that you can suggest are very welcome.

i will consider it too

I think this change would be compatible with any existing or future theme. It wouldn't change any class names. @johndyer can you advise on this?

Digging a bit more, In tandem with this, I think we should just rip out setControlsSize completely. The logic there is really tortured and the while loop on the railwidth has noticeably bad performance. If I'm not mistaken, all the layout math done here can be done both faster and with greater flexibility using CSS calc().

@albell yeah! will be great to configure this
through the "config theme". i mean either any fixed width or flexible(depends of container)

@albell I'm working on a PR that I'll release soon so you can review it to make sure we don't use setControlSize() anymore since I agree that it's complex and has a lot of issues because of error margin of pixels


[SPARK-6268][MLlib] KMeans parameter getter methods

jira: https://issues.apache.org/jira/browse/SPARK-6268
KMeans has many setters for parameters. It should have matching getters.

Test build #28460 has started for   PR 4974 at commit f94a3d7.

This patch merges cleanly.

Test build #28460 has finished for   PR 4974 at commit f94a3d7.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28460/
Test PASSed.

LGTM except one minor inline comment.

Test build #28466 has started for   PR 4974 at commit f44d4dc.

This patch merges cleanly.

@mengxr Thanks for review. New commit submitted.

Test build #28466 has finished for   PR 4974 at commit f44d4dc.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28466/
Test PASSed.

Hi @srowen Thanks for the suggestions.

For adding the @return prefix. Sounds fair, and if we're doing it, shall we change other implementations as well? (like LDA, GaussianMixture and others).

For using foo rather than getFoo, again it may impact a wide range of code. And shall we change setters to age_= (value:Int) : this.type ? @srowen, @mengxr ,@jkbradley. I'm not sure what's the general recommendation within Spark. And I'd appreciate if there can be a quick decision from community leads. Thanks.

Ignore my second comment; it would take a fair bit more change including changing current setters.
I would not change javadoc on other code, no. LGTM.

Merged into master. Thanks!


Revised JS so only 10/31 counts as Halloween

I have updated logic to get current month, and if October, and date is 31, display Halloween message.

@humanforklift  - This update was completed by another user. If you see another enhancement you'd like to make, feel free to create a new pull request.


Test execution does not stop

Once started mode 2, the test will not stop anymore. It prints only one result line
Start input:
m2acr5CFFhp0d5l1D01234567hN01234567890ABCDEF01234567890ABCDhA01234567890ABCDEF01234567890ABCDh
Always returns here
### Data string: +SNR
 CR 4/0 DR 5 MSK [EN] 255
 Freq [hz] 0 pwr [dBm] 0 rssi 0 snr 0
 Time TX: 0.000 ms Time RX: 0.000 ms Time Total: 0.000 ms
Reset
Restart - Init

It was actually a printout issue


CI run black formatter on notebooks as well as Python scripts

Hi :wave:
I've noticed that in your .pre-commit-config file, you check that your Python files follow the black formatting style, but you don't do so for your Jupyter Notebooks.
So, here's a little PR to add a hook for that!

Thanks @MarcoGorelli, could we also add the hooks for isort and flake8?

Hi @mloning - sure, I'll give that a go tomorrow!

I just had a look at running nbqa-flake8 - there's a few errors because of
from sktime.forecasting.all import *

Would you like me to silence the F405 when running flake8 on notebooks, or should the 01_forecasting notebook's imports be re-written to be explicit? I'd suggest adding it in a separate PR so there's not too many changes to review in one go (likewise for adding nbqa-isort), but I can add it here if you prefer

@mloning I've added nbqa-isort as well, as the diff's quite small.
For nbqa-flake8, I was trying to re-run the 01_forecasting notebook (so I could replace the star import), but when trying to install sktime locally I get
(sktime-dev) marco@marco-Predator-PH315-52:~/sktime-dev$ pip install --editable .
Obtaining file:///home/marco/sktime-dev
  Installing build dependencies ... done
  Getting requirements to build wheel ... done
    Preparing wheel metadata ... error
    ERROR: Command errored out with exit status 1:
     command: /home/marco/miniconda/envs/sktime-dev/bin/python /home/marco/miniconda/envs/sktime-dev/lib/python3.8/site-packages/pip/_vendor/pep517/_in_process.py prepare_metadata_for_build_wheel /tmp/tmp55q5_ruq
         cwd: /home/marco/sktime-dev
    Complete output (32 lines):
    Traceback (most recent call last):
      File "setup.py", line 226, in check_package_status
        module = importlib.import_module(package)
      File "/home/marco/miniconda/envs/sktime-dev/lib/python3.8/importlib/__init__.py", line 127, in import_module
        return _bootstrap._gcd_import(name[level:], package, level)
      File "<frozen importlib._bootstrap>", line 1014, in _gcd_import
      File "<frozen importlib._bootstrap>", line 991, in _find_and_load
      File "<frozen importlib._bootstrap>", line 973, in _find_and_load_unlocked
    ModuleNotFoundError: No module named 'numpy'
    Traceback (most recent call last):
      File "/home/marco/miniconda/envs/sktime-dev/lib/python3.8/site-packages/pip/_vendor/pep517/_in_process.py", line 280, in <module>
        main()
      File "/home/marco/miniconda/envs/sktime-dev/lib/python3.8/site-packages/pip/_vendor/pep517/_in_process.py", line 263, in main
        json_out['return_val'] = hook(**hook_input['kwargs'])
      File "/home/marco/miniconda/envs/sktime-dev/lib/python3.8/site-packages/pip/_vendor/pep517/_in_process.py", line 133, in prepare_metadata_for_build_wheel
        return hook(metadata_directory, config_settings)
      File "/tmp/pip-build-env-9zr87gf4/overlay/lib/python3.8/site-packages/setuptools/build_meta.py", line 161, in prepare_metadata_for_build_wheel
        self.run_setup()
      File "/tmp/pip-build-env-9zr87gf4/overlay/lib/python3.8/site-packages/setuptools/build_meta.py", line 253, in run_setup
        super(_BuildMetaLegacyBackend,
      File "/tmp/pip-build-env-9zr87gf4/overlay/lib/python3.8/site-packages/setuptools/build_meta.py", line 145, in run_setup
        exec(compile(code, __file__, 'exec'), locals())
      File "setup.py", line 319, in <module>
        setup_package()
      File "setup.py", line 309, in setup_package
        check_package_status(package, version)
      File "setup.py", line 255, in check_package_status
        raise ImportError(
    ImportError: numpy is not installed.
    sktime requires numpy >= 1.18.0.
    Installation instructions are available on the sktime website: https://www.sktime.org/en/latest/installation.html

    ----------------------------------------
ERROR: Command errored out with exit status 1: /home/marco/miniconda/envs/sktime-dev/bin/python /home/marco/miniconda/envs/sktime-dev/lib/python3.8/site-packages/pip/_vendor/pep517/_in_process.py prepare_metadata_for_build_wheel /tmp/tmp55q5_ruq Check the logs for full command output.

However, I do have numpy installed:
(sktime-dev) marco@marco-Predator-PH315-52:~/sktime-dev$ python
Python 3.8.5 (default, Sep  4 2020, 07:30:14)
[GCC 7.3.0] :: Anaconda, Inc. on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import numpy
>>> numpy.__version__
'1.19.2'

Have added an nbqa-flake8 check as well :tada:
I added E402 (Module level import not at top of file) to extend-ignore for this one because sometimes there are imports in the middle of notebooks and I'd imagine you want to keep it that way? That's what the --treat-comment-as-code flag to isort achieves

Thanks @MarcoGorelli, much appreciated!
Not sure about the installation error, haven't seen that one before. Our setup.py follows scikit-learn's and all the code does is call importlib.import_module("numpy"), so not sure why that fails.

FYI We just merged another big PR which resulted in a number of merge conflicts, I wanted to take a look at the notebooks anyway, so I can resolve them at the same time.

Thanks @MarcoGorelli for fixing this, realised I added a few more conflicts with other PRs, git isn't great for notebooks ...
Will take a look at this now and then hopefully merge it later today!

🤣 no worries! I'll take a look at the conflicts and'll update

@MarcoGorelli just pushed the changes, that should be it hopefully!

FYI I reverted back to standard imports and remove the imports from sktime.forecasting.all, I still like the idea of it but perhaps it's better to be more explicit in tutorial notebooks about the file structure where functions/classes come from.
I'll leave sktime.forecasting.all though, import everything you need via from sktime.forecasting.all import * seems way to convenient once you're familiar with the toolbox.

Interesting, the new CI checks we now give the same error that you reported earlier, that numpy is missing even though it has been installed, will have to look into this https://dev.azure.com/mloning/sktime/_build/results?buildId=1337&view=logs&s=6884a131-87da-5381-61f3-d7acc3b91d76&j=e395bb75-778f-525f-dfb1-52e1f09bc325

Hey @mloning
Sorry for the delay, but I finally got to the root of the cause - it's that if you have a pyproject.toml file present, then pip install -e . works differently. If you look at sklearn, they have a [build-system] section in their pyproject.toml file.
So, rather than changing how sktime is packaged, I've just moved configuration for nbqa over to the pre-commit file - all seems to works as expected now :tada:

Thanks again @MarcoGorelli, will merge now!


Allow type safe usage of useGqlError

Your use case
When defining a custom error handler using useGqlError I'd like to write a type safe function, e.g.:
Instead of:
useGqlError((err) => {
    console.error(err)
 })

I want to write:
useGqlError((err: GqlError) => {
    // Access err in a type safe way...
 })

The solution you'd like
I'd like to import the type GqlError. Could not find a working export. (Ideally, this would be reflected in the docs)
Possible alternatives
No response
Additional information
No response

same here

It seems to me that GqlError could be included in the dist in some way...
Nuxt Module Builder might be relevant too?

I made a PR to export the type

@mariopries Thanks for taking the time to address this! Your fix has been merged into the latest release.


feat(jsonwebtoken): improve jsonwebtoken types

@facundo-viale-olx One more thing, you'll need to copy over and teak the specs before I can get this merged in.

Something I'm surprised no one has noticed is that the types for jwt$Callback are wrong. Currently they are:
declare type jwt$Callback = (tokenOrError: Error | string) => void;

But the function actually takes two arguments, (error, token).
This could be represented with a union of the two signatures. One that takes an error and no token and another that takes null for the error and a string for the token.

Done!


[2.0.1-cherrypick][Feature][Workflow relationship] Format name.

Purpose of the pull request
7144

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:

Codecov Report

:exclamation: No coverage uploaded for pull request base (2.0.1-prepare@b2143c3). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             2.0.1-prepare    #7149   +/-   ##
================================================
  Coverage                 ?   32.13%
  Complexity               ?     1568
================================================
  Files                    ?      433
  Lines                    ?    14494
  Branches                 ?     1439
================================================
  Hits                     ?     4657
  Misses                   ?     9378
  Partials                 ?      459

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2143c3...b6d8a07. Read the comment docs.


Clarify rationale for CDP and AIA changes

As a non-expert, it is not clear to me why it is desirable to remove the ldap and file URLs and change the http URL for CDP and AIA, as described on this page.  Are the changes always required?  Clearer explanation of the rationale and when and to whom these recommendations apply would be helpful.
Thanks,
Kevin

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2929b93e-fe36-d3e4-ee28-2a4aaf977da6
Version Independent ID: 689f7606-45b0-3444-65dc-85c2ba217e9b
Content: Configure the CDP and AIA Extensions on CA1
Content Source: WindowsServerDocs/networking/core-network-guide/cncg/server-certs/Configure-the-CDP-and-AIA-Extensions-on-CA1.md
Product: windows-server-threshold
GitHub Login: @shortpatti
Microsoft Alias: pashort

I agree. Where is this documented? Anyone know?

Ditto.  Can we get an official word from Microsoft here?

Certificates created by the Certificate Authority will advertise revocation information, and those locations should be publicly available so applications can verify whether a certificate valid or has been revoked. Default values work fine for an Intranet-deployed certificate authority, but not for Enterprises that wish to make their certificates accessible and validated not only internally, but externally as well. LDAP is normally not made accessible outside an enterprise, nor is a file share, so advertising either location would not be helpful when validating certificates. The public URL where the revocation information will be published by enterprises may be different than the default internal Intranet location advertised by the certificate authority (typically the CA's Web Server), so that's why the article discussed changing or removing and changing these default entries and values.

That makes a lot of sense.  Thanks for the explanation @sergio-re!

#please-close

#please-close


Train a model from scratch

there is way to train gemma or llama from scratch in limited language EN-DE and only for special task: QA or Translation

https://github.com/hiyouga/LLaMA-Factory/blob/c6e3c14a93490df6e7f8099e09d62d602a667542/src/llamafactory/hparams/model_args.py#L252-L255


Delete my code

Since OpenCollective has more funds than I do in the bank, and no one is willing to share for the % of contributions I've made to the project, I would like to delete every line which is still associated with my commits. I'll try to send a pull-request soon, same for the docs and website.

You've given so much to the JavaScript community for so many years. You absolutely deserve whatever there is for your contributions.
If you want to be punitive, also delete lines modified after you created them... 💪🏻￼￼

To be fair he's done a lot of work as well, just feels a bit shady, but whatever don't worry about it I guess.


Screenshot tests take huge time to run

I feel the current approach for composing screenshot testing is not scalable as it takes a huge time to run a single test. Currently, for each screenshot test, a new activity is instantiated. Can we do something to share single instance of activity to optimize the time.

It all depends on the U library you are using @mittalshivansh. If you are using old android views, you'll be able to inflate different views and take as many screenshots as you want with only 1 activity instantiated only 1 time. However, the compose testing tools don't provide this capability. At least it didn't provide it last time I checked. I hope this is the answer to your question.


how change this line? 7u7

this xD http://i.imgur.com/96YySgy.png http://i.imgur.com/96YySgy.png http://i.imgur.com/96YySgy.png

that is client sided

solo quiero agregarle el id :´v  a lado de la massa

yo te ayudo discord https://discord.gg/0tIkwmjWJW9SQBkw

Yo creí que te referías a hacer con "k" la masa lol

I think you screwed up sending ID packets over, you might want to fix that.

This is also client sided, you can use regex or edit the code itself to remove this.

@imnotNxhz1 This is client sided, out of scope of project.
But if you host a Cigar client you can change it in main_out.js
So making an issue here is off topic I'm afraid.


Feat/combined middleware

Change Summary

combines the middleware

Merge Checklist

[ ] PR has a Changeset
[ ] PR includes documentation if necessary
[ ] PR updates the boilerplates if necessary

@davidfurlong i assume the idea would then be for other middleware like farcaster and openframes to merge into the top level state as well?

yeah


Problems running terminal in VSCode

Always when I'm trying to use the integrated terminal in VSCode, to run some code snippet or something else, my window ends up crashing, forcing me to reopen it again or even close it. In other words, my integrated terminal freezes my window if used once or more times. I asked this same question before some time ago, but I didn't understand any answer gave to me, neither figured out how to solve it.  Without any extension installed, it keeps happening, even reinstalling the program this bug persists.

i have a terminal integration too..
Git Bash open more slow than previous version.. and after lastest update i cant use multiple panel.. it didnt load correctly.. below the screenshoot :

the right bash is didnt working yet.. anyway i use git v 2.27.0-window.1 and here the visual studio information

I am having the same issue, it seems to bug out when I have 2 terminals side by side and when I use some git commands (git push).

I am having the same issue, it seems to bug out when I have 2 terminals side by side and when I use some git commands (git push).

In my case,

I am having the same issue, it seems to bug out when I have 2 terminals side by side and when I use some git commands (git push).

I'm having trouble just by open one single terminal. I needs less than 1 minute to crash everything. As a substitute I'm using repl.it to run snippets and default windows 10 terminal to use git.

I'm having the same issue with bash integrated terminal... The first time I open the terminal it freezes, then it works when I close it and open again. Today, I've noticed that when I was trying to run a java main function it wasn't starting... then I switch to powershell and it was executing.
There are also some other weird issues like when the terminal starts, I have to scroll up to reach the line or the terminal is blank until I type something.

/duplicate https://github.com/microsoft/vscode/issues/76548


Can't see beyond first level dependencies

Hi. I get only one level of dependencies on my project.
Say, I have a file name mediaParent that has:
import '@myrepo/media-child1';
import '@myrepo/media-child2';

On the generated graph image, I only see mediaParent1 that is dependent from media-child1 and media-child1 (with option --includeNpm).
What If I want to see dependencies of media-child1 and media-child2?
I mislead something or this has to be the exact purpose of this library?
Thanks in advance

Yes, this is intentional. It was not designed for doing deep a NPM dependency overview. There's other tools for that.

Thanks. Can you suggest me at least one of these tools? It would be great.

Here's at least on version you can you use online: http://npm.broofa.com/?q=madge

@pahen  Thanks, but this works with published modules. What about private ones? I'd like something that works locally

No problem on it :)
Just say, it would be nice if on the readme of madge it's clear that this doesn't work with NPM dependencies, which are pretty used nowadays  :)
Will traverse child dependencies automatically. I suggest to specify this limitation. I have a feel that many people by reading the readme like me has mislead that. Anyways, great library and great job