security group and subnet parameters for AWS can be specified but have not effect

[Version]
16.1 fix7 2017/03/17
[How to reproduce]

when provisioning, specify subnet or security group for aws service
look at created instance on aws

[Expected result]
the parameters specified should be reflected in the created aws resource
[Observed result]
values used in aws are default
[Details]
In logfiles I see that the parameter values are sent to app by bes domain. I cannot find the parameters
after that. To me it looks like app ignores them.

TechnicalService_AWS_161f7_SecGroup_xml.txt

At FT time of US-8617 US-1618 these features were OK for AWS.

Hi, I am also interested in this fix since I am using the AWS controller for CT-MG IaaS demos. Can anyone tell me what the target milestone will be for the fix?

I checked and found that your tech. service uses the old, lower case parameters. These have been updated to upper case. I updated the service and tested it. Both subnet and sec group are configured correctly in AWS.

@MiethanerR Is this correct? Is it no longer compatible with previous versions? So we cannot use existing services?

https://github.com/servicecatalog/development/releases/tag/v16.1_Fix6
These parameters were introduced with 16.1.4 and updated with 16.1.6 with no backward compatibility.

Previous versions of services are upgraded my an sql script. New services imported have to be correct. Otherwise this feature will fail.
Verified.


Add support for Flutter 3.0 (possibly just one line change: edit dependency version)

according to my test, seems to work well now, no need to change things.


--allow-staged flag

As a generalization of --allow-dirty, there could be an --allow-staged flag that lets us run only if there are no unstaged changes in Git (and similarly if Mercurial, Pijul, or Fossil have an analogue of Git's staging area—I'm not familiar), the rationale being that content that has been git added isn't actually in danger of being permanently eaten by a poor suggestion application, because you can git checkout -- . to back out the changes.

Closing in favor of https://github.com/rust-lang/cargo/issues/5737 now that cargo fix has changed homes


Add support for partial tx batch unlocking

Problem
There's no way to partially unlock a batch of transactions (needed for fixing https://github.com/solana-labs/solana/issues/34825)
Summary of Changes

Added method to TransactionBatch for updating lock_results which unlocks any accounts that are no longer eligible for execution
Changed Accounts::unlock_accounts and Bank::unlock_accounts to operate over a zipped iterator of transactions and lock results so that it's easier to implement a partial unlock of a transaction batch.
Added debug assertions to ensure that no tests are relying on double unlocking transactions
Added an is_empty check inside Accounts::unlock_accounts to avoid taking the accounts lock if it's not needed

Fixes #

Codecov Report
Attention: Patch coverage is 96.36364% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 81.8%. Comparing base (ce34f3f) to head (853c670).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #110   +/-   ##
=======================================
  Coverage    81.8%    81.8%
=======================================
  Files         838      838
  Lines      225941   225974   +33
=======================================
+ Hits       184945   184983   +38
+ Misses      40996    40991    -5


Toggle ol.Feature visibility

Now, if I want to make feature invisible, I have three options:

Remove the feature from ol.Collection(or plain array and redraw)
Set the style to null or undefined or empty style
Add each feature to new layer and set the visibility on layer itself

The first solution works, but requires additional code to store the invisible features in another array, which leads to another messy code if I'm working with all features regardless of their visibility in other parts of the code(I have to iterate or join both arrays etc.).
The second solution works only partially. The features are really invisible optically, but they are active, they are triggering events, for example modify interaction is active on them etc.
The third solution is absolutely inappropriate I think.

Option 2 is preferable. Just make sure that interactions with their own style (like e.g. ol.interaction.Modify have a style that also respects your visibility setting on features. This can most easily be accomplished by setting feature.setStyle(function() {}));.

For ol.interaction.Modify I use custom style function. But passed feature parameter of the style function is not the original feature but only temporary interaction feature which does not contain my custom data. Probably I can solve this by setting the temporary variable in modifystart evenhandler, which is a little bit cumbersome. Anyway, the modify interaction is still active on the feature regardless of the style. Moreover, with default modify interaction options property pixelTolerance the feature becomes even more vulnerable for unintended modifications by user. I must be absolutely sure these features are not changed when invisible.

You can configure your Modify interaction with a collection of features. Add only the features you want to be modified to that collection.

I end up with option 1, separating the visible and invisible features to different collections. I think that the UI should be separated from the logic anyway. Maybe it would break the ol code structure, but I think it is a basic functionality to be able to show/hide the objects on the map per feature, as it was in openlayers 2, or as it is possible in other map libraries.

I got the same problem, but I find the best answer to solve this problem, I am using the V5.3.0 API, so here is my solution:

First, you have to set the layer's style option to null, all layers are best to set null;
Second, you can use the setStyle function of the feature to control the show/hide of the feature, if it set null, the feature will not be rendered in the layer, otherwise, the feature will be rendered in the layer with its own style which you set.

Honestly speaking, I never thought of ol API will handle the problem like this, the logic confuses me a lot, I hope it will be optimized in the future.


Add travis-ci build status to README.md

@DarthGandalf can be closed due to https://github.com/znc/znc/commit/934a0a9babb0d4a28b3fb623e2cf11159359a945

@Kriechi Are you sure I can be closed? :P


Arrt tool vanishing when rendering object

In the last few weeks i`ve noticed when the Arrt tool is rendering (regardless of model used)  it will run fine with keyboard functions (WASD) and the auto-collecting statistics but as soon as I click with the mouse pointer in the render view the tool crashes.
It ran fine previously.
Any ideas what could be causing this?
Thanks

Thanks for reporting the problem!
I suggest you delete the local configuration file, in case there is some invalid value that is used during mouse navigation.

Close ARRT, if it's running.
Find the configuration file here %LOCALAPPDATA%/Arrt/config.json
Rename the file, as a backup
Start ARRT
Insert again your credentials details for Azure Remote Rendering and Azure Storage
Try and repro

Let me know if this doesn't fix it, so we can try a different approach.
Marco

Hi Marco,
Just tried your suggestion but again same issue.
I`ll try and give it a go on another PC in case something on mine has changed.

I tried on another PC with a fresh install and had the same issue, but then i realised its the left mouse button thats causing the crash, the right mouse button is ok. Click the left mouse in the 3d viewport and it vanishes.

I could repro.
Apparently it crashes only when you click on the empty space (not on an object).
We'll work on a fix as soon as possible.
Marco

Can you try with the new version 1.6? That should be fixed!
Best regards,
Marco

All good now with 1.6, thanks Marco.


Add gitignore support

There is gitcommit but not yet a gitignore comment symbol.  I think it may come
in handy for those that define the gitignore filetype.

Done, sorry I messed up, only the gitignore commit was intended to be in
the pull-request, the other files where already joined in commit
e1af5da.

Thanks @alejandrogallo that makes more sense now.


Add VC type "Pass" in category Pass

and types : BloometaPass and CompanyPass

@ThierryThevenet company pass is currently the Arago Pass, right?

That's done exept in BloometaPass: adding it in BloometaPass ticket


After deploying a MicroVM, I found extra 1.8 TB disk

Description
https://dashboard.bknd1.ninja.tf/#/deploy/vms/vm, 2.3.0-alpha6
Why does my Micro VM instance have a 1.8 TB disk, which I didn't add or select when deploying it?

A clear description of the bug, including relevant identifiers like:

Twin ID: 7189

Node ID 344

Farm ID: 76

Contract ID: 147540

Steps to reproduce

Navigate to the Dashboard.
Connect your wallet.
Navigate to Virtual Machines.
Select MicroVM.
Leave capacity small.
(Optional) I add a disk with a 505 size.
Load nodes and deploy.
Shh into the VM and type df -h.

Logs/Alerts
{
  "version": 0,
  "contractId": 147540,
  "nodeId": 344,
  "name": "vmojayu",
  "created":<PHONE_NUMBER>,
  "status": "ok",
  "message": "",
  "flist": "https://hub.grid.tf/tf-official-apps/threefoldtech-ubuntu-22.04.flist",
  "publicIP": null,
  "planetary": "300:2986:81a4:da47:35a8:acc4:58c5:1b2e",
  "interfaces": [
    {
      "network": "nwnvtq4",
      "ip": "<IP_ADDRESS>"
    }
  ],
  "capacity": {
    "cpu": 1,
    "memory": 2048
  },
  "mounts": [
    {
      "name": "diskiv8mkk6",
      "mountPoint": "/mnt/iv8mkk6",
      "size":<PHONE_NUMBER>20,
      "state": "ok",
      "message": ""
    }
  ],
  "env": {
    "SSH_KEY": "ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABgQCvmSYj5BKWkizdNyIziMfMm0CRrgq0UxFtBfBdArUMXSFkU30rtExbg6dlVFJCufw6UsCESm/QBSwlOyYKRdpsfVARcAw5G5OG0iX/22n+tYmCcWpmOJLJZaAmSynF1kwpBx3XDy40mFL6OMXjqFcU3DirbcucIL185XfAsTzrq3tDtSvmYPwbXMVMbs1ZAZValxOQNuaLty4qGD2awxVNZq4vtAzgpz3FFo3cs2g70jsGiPq/rsH+NxZHYmqvYnF/S0aPGBrbOe2yW8Cz0mqq5CzqbjYd+Qorkmt7uyJrlCBI43ky+pUuiAYeE1eJlWl5svA+ibWk5yYoa6svLUkaL1kcOMeZWLzDjL3OCrno9gglNp8zUkdSagHROoYlGgpc5fnzMGX4MKDLpHdE9xdk4NjpjB2Iq3hV3DamexXAhLEirLYv9fSilSyKVf/2kvYAa9o+NS4DgBVvXg9J54By/mAVsydD4lbpNe/2pX/WoFGCczmoQfWdHgJPYVCf2vU= harby@ahmed-Saleh-Harby"
  },
  "entrypoint": "/sbin/zinit init",
  "metadata": "{\"type\":\"vm\",\"name\":\"vmojayu\",\"projectName\":\"vm/vmojayu\"}",
  "description": "",
  "rootfs_size":<PHONE_NUMBER>0,
  "corex": false,
  "gpu": [],
  "deploymentName": "vmojayu",
  "projectName": "vm/vmojayu",
  "billing": "No Data Available"
}

That's the node root disk it's a know issue @muhamadazmy

See https://github.com/threefoldtech/zos/issues/1579 (not sure why that one was closed).
This applies to any deployment that's not booted from a raw disk image (that is, micro VMs and the new style full VMs). It's not really anything specific to the Playground.
To be clear, you are seeing the total capacity of whichever SSD in the node Zos assigned this VMs root filesystem to. There's a quota enforced according to how much capacity was reserved, so the only issue here is that it's more difficult for the user to see how much space they have left.

Verified, Devnet 408184e.
I tried a few times, and the microVM disk size was correct. I also created a test case to make sure it wouldn't happen again.

TC2726: Disk is in the correct size


List actions are susceptible to GRPC message limits

Right now all list operations can trigger max message sizes in GRPC.
Of course this message size can be increased, however this is a problem in that these operations do not scale well and requires lots of allocations in both the client and the server.
We should investigate other means of handling lists.
A couple of alternatives. maybe someone else has another idea:

Pagination
Streaming responses

I think pagination is difficult to do reliably, particularly in a system with constant change and requires storing some extra state in both the client and the server.
A streaming response would require new API's but does not require juggling state as pagination would.
Containerd recently addressed a similar concern and decided to add streaming API's for lists here: https://github.com/containerd/containerd/pull/2347

ping @dperny

cc @anshulpundir

If we are going to make changes to the API it might make sense to look at what data is actually needed for the use cases and plan accordingly. From https://github.com/docker/cli/pull/1489#issuecomment-434108066 even with the limit fix or any stream/pagination fix this testcase still takes 16 sec just to return from service ls. That is hardly a great experience and I'm sure with some changes to the endpoint it could be much faster and not transfer 5MB+ of data per response.

TasksList is the RPC we're currently running into limitations on (moby/moby#37997), and a patch to add a streaming RPC endpoint currently open at #2773.
We'd need to profile it to be sure, but I have a suspicion that most of the overhead of the service ls call is happening on the engine or CLI side of the request, which is where we'd want to change things to make it go faster.

@dperny also interested in finding out what makes up the size of the grpc message.
I see this comment which says a message size can get to 300MB but would like to verify how this can be.

The task list includes all of the tasks, including the non-running ones. The OP (in this thread) is using a task retention limit of 5, which means however many tasks they're using, multiply that number by 5.
https://gist.github.com/dperny/5c359f416036ab38a0d6347b49269391

(sorry, i had a mis-post)
I built up what I think a fairly typical task object might look like (linked to in a gist at the bottom of this post), marshaled it to proto, and then got the size of it. This task object is 1331 bytes. If you take the default max of 4 million bytes, that's about 3000 tasks before you exceed the size.
However, these task list operations ALSO include every dead task as well, which means you could scale up the number of tasks by a constant factor from the number actually running.
https://gist.github.com/dperny/5c359f416036ab38a0d6347b49269391

docker service ls is also only fetching tasks to get actual/desired counts, right?
What if we provided an endpoint that could provide these counts for a service? Actually I think people would like this in the docker API as well. Maybe just a breakdown of each state. Would save a lot of time/data, particularly for large deployments.

we could add RunningTasks to the Service object, i suppose, as an optimization.

I think the reason it is not there is this must be computed on the fly and adds lots of overhead if someone just wants to fetch a service.

based on https://github.com/docker/swarmkit/issues/2774#issuecomment-434391952 I agree that it makes sense to reconsider the API and see if there are possible ways to optimize the response size.


Issue 6847 & 6848 - Fix special cases of typeof(super)

Issue 6847 - typeof(super) doesn't work outside member function
Issue 6848 - typeof(super) does not take into account const/immutable attributes inside member functions
Supplemental changes of Phobos: https://github.com/D-Programming-Language/phobos/pull/301

This causes std.xml to fail with:
..\dmd -c -o- -O -release -nofloat -w -d -version=StdDdoc -Df..\doc\phobos\std_xml.html std.ddoc std
\xml.d
std\xml.d(622): Error: function std.xml.Element.opCmp (Object o) is not callable using argument type
s (const(Element)) const
std\xml.d(633): Error: function std.xml.Element.toHash () is not callable using argument types ()
--- errorlevel 1

I have posted Phobos patch for this, it is #301, and it is already merged.
I think your phobos library is not newest.

Thanks, I'll get it.


Experimental details of Table 1?

Hi, Tengda.
I'm trying to reimplement your promising result using the small dataset UCF101. Can you provide the hyper-parameter setting of the Table 1 in your paper? Such as input size, training epochs, etc. Very thanks.

Hi,
Note at the beginning: this experiment is just for proof of concept, it's not the right way for self-supervised learning (pretrain & finetune on the same dataset). IMO, the right way is always to utilize more unlabelled data to show its quality.
We tried slightly different settings for multiple times and get similar performance. Here is just one example to get Table1 DPC result.
For DPC training on UCF101 (dpc/):

python main.py --gpu {your gpu id} --net resnet18 --model dpc-rnn --dataset ucf101 --seq_len 5 --num_seq 8 --pred_step 3 --ds 3 --batch_size {32 per GPU} --img_dim 128.
Note that batch size is 32 per GPU, changing the number of GPUs should not affect performance much because the effective batch size for contrastive loss is capped by single GPU batch size.
Learning rate schedule: Adam 1e-3 for 400 epochs and then Adam 1e-4 for 70 epochs.
Here is DPC loss and top1 acc curve (blue=train, orange=val):

From the curve, you can see probably you can save your time for training. e.g. you could reduce lr earlier because the validation curve from ep250 to ep400 doesn't change much.

For UCF101 finetuning (eval/):

python test.py --gpu {your gpu id} --net resnet18 --model lc --dataset ucf101 --seq_len 5 --num_seq 5 --ds 3 --batch_size {32 per GPU} --img_dim 128 --pretrain {the pretrained model} --train_what ft
Learning rate schedule: Adam 1e-3 for 60 eps, 1e-4 for 40 eps, repeat 3 times (other schedules also work, like decay lr twice, you can try. Also SGD should always give better results than Adam, although we didn't try). The purpose of this step is to evaluate the feature quality. So you choose one schedule, and fix it to get the comparison.

Good luck & have fun!

@TengdaHan Thanks for your kind reply. I just want to do a quick, simple experiment because the Kinetics 400 dataset is so time-consuming (as long as 1 week+ and 6 weeks). Do you think what is the bottleneck of the training time?

Kinetics400 with 128x128 resolution, 3D-ResNet18, can get a good feature with less than 1 week (maybe 2-3 days). The bottleneck of the training time is always GPU runtime (GPU utility is 100% in my training), as long as you read video frames from SSD.

Hi Tengda,
thanks for sharing your code and thanks for the detailed reply to this issue, I found it very helpful!
However, there is one thing I'm wondering about. I could reproduce 60.2% of the DPC method using the hyperparameters mentioned here, but when I ran the same finetuning code (same hyperparameters) with random initialization I got 54.4% instead of 46.5% mentioned in the paper. Is there something I might be missing?
Thanks in advance!

Hi, thanks for mention this. Your experimental setting and results are correct.
By the time of submission, we didn't train the random initialization baseline long enough, partially because the 46.5% we obtained already matches previous random initialization baselines (e.g. Hara et al. 2018).
Now we have realized this issue, and we will release a public benchmark very soon. Stay tuned :)

Hi Tengda,
thank you for the quick reply! That's very helpful :)


"otherwise" method in content based queue record writer builders should be optional

As of version 5.1, the "otherwise" method in content based queue record writer builders is mandatory:
ContentBasedBlockingQueueRecordWriter recordWriter = ContentBasedBlockingQueueRecordWriterBuilder.newContentBasedBlockingQueueRecordWriterBuilder()
        .when(predicate)
        .writeTo(queue)
        .otherwise(defaultQueue)
        .build();

specifying a default queue should be optional.
This is the case for both ContentBasedBlockingQueueRecordWriterBuilder and ContentBasedJmsQueueRecordWriterBuilder

fixed in dc837dc1cbb955a4b0b421fdcdcc549e3753f4b0


Demo for in the wild tests

Hii, sorry for bothering you again. I found that you use HO3D and Dex datasets; could you please share the demo codes for testing with a custom video? Thank you so much!

Unfortunately, we lost the checkpoints during a lab NAS cleaning and I don't have the bandwidth (I have graduated) and resources to re-train the models. However, we released the training code and instructions that you are welcome to train the models by yourself.


[FEAT]:

Description
////— END OF LIFE Product — 24.04.2024
A finished product is a product that has reached the end of the product life cycle. This means that users will no longer be able to receive updates and the product's shelf life has expired. At this stage, vendors will stop marketing their product, service or software update.

XContainer new version is available and supersedes XCL
Xoopscube's new XContainer updates are complete in Japan and Switzerland. The XoopsCube project needs to be modified for maintenance or archived.
XContainer is an enterprise solution built using the latest technologies (No-code, AI, ML). There is no backwards compatibility. Xoopscube Legacy is therefore no longer supported.
Additional Information

Maintenance Mode
In the world of software development, it refers to a point in a computer program's life when it has reached all of its goals and is generally considered to be "complete" and bug-free.
Theis also refers to the point in XoopsCube's evolution when it is no longer supported by developers to be competitive with other products or the LAMP technology environment it operates within.
In both cases, continued development is deemed unnecessary or ill-advised, but occasional bug fixes and security patches are still issued, hence the term maintenance mode. Moreover, maintenance mode often transitions to abandonware.


Finding exact value of CpuShares for 100% cpu usage

Hello ,
I have 2 service fabric application (sln) with 3 services (3 code packages). I want to distribute those in 40%  20%  20% of max CPU percentage irrespective of core i.e. no limitation on number of CPU cores (current machine is 4 core logical). According to above content/blog if I specify the CpuShares = 512 ,  CpuShares =  256 and CpuShares =  256 then it should take max CPU of 40 , 20 , 20 percent. However this is not the case it only allowed 5% 2% and 2% of max CPU usages for respective services. By reading this post I thought 1024 is default value (max value) for CpuShares , after lot of try and error I finally come to the value 10,000 for CpuShares if we apply any values greater than this we get error in service explorer saying Invalid Arg for CpuShare.
So considering 10,000 = 100% CPU usage allowed. I have modified above CPU share values to CpuShares =  4000,  CpuShares =  2000 and CpuShares =  2000 in testing I can see the max CPU percent usage where 40% 20% 20% (not exact 5% variance ). So the question is I could not find 10,000 = 100% CPU usage value in any of the documents. So I want to confirm if this is correct and if not then how can I restrict the service or code package to specific percentage. Please kindly help on this

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 19a961bb-1091-be9f-f9bb-895abf625e39
Version Independent ID: fa7dc2a2-6901-1efe-8921-4d2f673ac7b5
Content: Azure Service Fabric resource governance for containers and services
Content Source: articles/service-fabric/service-fabric-resource-governance.md
Service: service-fabric
GitHub Login: @masnider
Microsoft Alias: subramar

@masnider could you comment on this one?

@mandar003 you are correct. The number for total shares is 10,000.
I am working offline to determine the best way to explain this in the doc

@MicahMcKittrick-MSFT
It would also help to communicate that the CpuCores settings can be set at a fractional value to allow a service type a certain percentage of cpu. We worked with our CSA Adam Turner to figure this out and he confirmed with @masnider's team. If you want to govern a service type at 20% on a 8 core machine, the CPU cores can be set at 1.6 to achieve 20% governance. This is how we ended up governing our services a target threshold.
When we attempted to implement this however, it worked on some clusters and not on others. It appears that if CPU Cores is set across multiple service types, the sum of cores allocated to each service type cannot exceed a certain value. That value is unknown to us similarly to the 10,000 shares value @mandar003 figured out. We were getting errors related to placement constraints on some of our smaller testing clusters. We were never able to dig into this to determine if there was some sort of cluster maximum.
cc @mandar003

@charleszipp just FYI, we are working to address this in a doc update. We have an internal work item for it. I will close this issue out but we are working to get the doc updated to be more clear :)

@charleszipp please take a look at this SO answer to understand the 10k value:
https://stackoverflow.com/questions/52418527/service-fabric-code-package-value-of-cpushares-for-100-cpu-usagemax


Replicating CoreDNS pod failure

I have some questions regarding the nature of pod failure and I need to clarify those before building a solution. Here are some cases I have thought of.

The pods are scheduled but the required number are not up and running. In this case, the number of Pod IPs obtained won't match the number of pods specified.

The required number of pods are running and the TCP health check (by kubernetes) is showing that the pods are healthy but the DNS queries are not being answered (refer this issue).

Simulation Ideas Considered

For the first case, we can scale the deployment down to zero. This way, CoreDNS pods will be shown in the list of pods but effectively won't provide any service.

⚠ I am yet to come up with a simulation for this condition.

Additional Questions
Are there any pod failure scenarios that I've missed?

@yongtang


Missing ingress on GKE without GCLB

If I prepare a gke cluster without gclb and have server service with ingress: true the ingress won't be deployed either with or without using the orchestrator.

Yes, ns prepare gke but not using the --experimental_use_gclb. The nginx controller is deployed but during ns deploy the Kubernetes ingress resource is missing.


File-based configuration

We should support configuration via a file, but what this looks like exactly is not yet determined.

Please dont use dirs, as they've explicitly rejected the idea of supporting XDG on macos, which is really annoying to the people that care, and irrelevant to the people that dont care. You'll eventually (or immediately) get requests to do so, and will have to work around their weird stance. Nushell has had a many years long open issue as a result of their early choice to use app_dirs.
I've had good success with etcetera, although I'm certain there are other options for arriving at mutually liked behavior.


Mesa table can have double tooltips

I noticed this in ortho (on the orthogroup-tree-table branch) - the "All groups" results , if the EC number column overflows, the first tooltip is black text on yellow (from <Tooltip> I assume) and then the second is white text on dark grey (presumably the browser 'title' attr rendering).
Sorry no movie!

Looks like packages/libs/wdk-client/src/Views/ResultTableSummaryView/ResultTable.tsx is using the renderCell prop which is using packages/libs/wdk-client/src/Views/ResultTableSummaryView/AttributeCell.tsx for cells, and this has its own overflow/tooltip implementation.
Possible solution is to not do the setTitle stuff in packages/libs/coreui/src/components/Mesa/Ui/DataCell.jsx when 'renderCell' in column

I'm not looking at the code, but I remember there being a Mesa prop to prevent those tooltips.

https://github.com/VEuPathDB/web-monorepo/blob/orthogroup-tree-table/packages/libs/coreui/src/components/Mesa/types.ts#L39

I think we should consider removing the Tooltip from AttributeCell


Feature: add presets

First question:
? Select presets or resolution:
- Best audio + video
- Smallest file size
- only audio
- 480x240
- 1024x720

Youtube-dl does presets, that's what they call flags and that's the opposite of what youtube-dl-interactive is trying to solve. If you need presets, just use upstream.

@yura8 How should the UI of youtube-dl-interactive look / how should it work in your opinion?

improved in current release, https://github.com/synox/youtube-dl-interactive/releases/tag/v0.1.0


[WIP] gitlab CI

test failed

Check gitlab tests results before merging: [  PASSED  ] Ran 2/2 test case(s) from 2 check(s) (0 failure(s), 0 skipped) https://git.scicore.unibas.ch/j.piccinali/mirror_test/-/pipelines/13307


[1.9.3] Train 200

This is train 200 targeted for the 1.9.3 release, against the 1.9 branch. It contains the following pull requests:

#1766 ([1.9.3] Bump dcos-metrics version)
#1743 ([1.9.3] bump spartan and navstar)

@mesosphere-mergebot bump-ee

Known flake: https://teamcity.mesosphere.io/viewLog.html?buildId=728670

mergebot/enterprise/build-status/aggregate failed as of known flake.

integration-test/upgrade-onprem failed -- known flake?
https://teamcity.mesosphere.io/viewLog.html?buildId=728678

integration-test/upgrade-onprem failed again. This needs investigation.

Tracking the investigation of the potential integration-test/upgrade-onprem breakage here: https://jira.mesosphere.com/browse/DCOS_OSS-1503

CI finally passed. This is now only lacking one review.

@mesosphere-mergebot bump-ee


wasm-builder: allow default cargo nightly

I added a dev-dependency on substrate from ink!, and the build failed with https://github.com/paritytech/substrate/blob/33609c707a3bf7b1a520d639b7b1199dc77c0cff/core/utils/wasm-builder/src/prerequisites.rs#L40
It's because ink has the rust-toolchain file https://github.com/paritytech/ink/blob/master/rust-toolchain, which means that the vanilla cargo defaults to that version. It's a fixed version of nightly, and the wasm toolchain is installed for that version and not the latest nightly.
This PR fixes get_nightly_cargo to return the default cargo command if it is a nightly version.

@ascjones I talked to @Robbepop and we agreed to remove the toolchain file from ink!.
Rather we will have ink! use the latest nightly just like Substrate does.
In this case, I don't think this change is needed right?

It wouldn't be as urgent, but would still be needed for any project which has a toolchain file and  depends on substrate.


Use JSDoc with tsc for strong static typing

It is possible to use JSDoc comments with the TypeScript compiler to enforce some strong typing, as documented in the following resources:

https://medium.com/@trukrs/type-safe-javascript-with-jsdoc-7a2a63209b76 - this is the best explanation I have found but may be a little outdated
https://devblogs.microsoft.com/typescript/how-to-upgrade-to-typescript-without-anybody-noticing-part-1/ - more formal explanation which I think is not quite as clear

Here is the best example I have found: https://github.com/prettier/prettier/pull/6313
I would personally favor this alternative over porting to TypeScript as proposed in #64.

I'm also looking to do a technique like this for another node library I contribute to.
I think this is set up to work best with the next major version of TypeScript coming out at the beginning of next month, as they're making changes to support parsing JS+JSDoc via TypeScript-compiler.
Specifically, I think this PR was a blocker: https://github.com/microsoft/TypeScript/pull/32372
If JSDoc is super detailed and robust, then theoretically, the .d.ts declaration file could be directly output from there. -- From my initial work writing the JSDoc types for another library, however, it was way clunkier and harder to do than directly writing TypeScript, and nothing helped guide correctness in the JSDoc types. :(

OK, so a made a very basic starter project for this: https://github.com/composi/check-js and added a link for that in the article.


How do we connect using a AD FS SPN ?

The instructions assume that the user is using AAD to connect.  The az login --help shows "The AAD tenant, must provide when using service principals."
az login
--tenant <Azure Active Directory Tenant name. For example: myazurestack.onmicrosoft.com>
--service-principal
-u <Application Id of the Service Principal>
-p <Key generated for the Service Principal>
How do we use AD FS?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 583c4bab-c16a-a723-04ac-b3265d9e8269
Version Independent ID: ba902e46-2c31-aeea-87e8-8c186d6d1820
Content: Connect to Azure Stack with CLI
Content Source: articles/azure-stack/user/azure-stack-version-profiles-azurecli2.md
Service: azure-stack
GitHub Login: @sethmanheim
Microsoft Alias: sethm

@dmc-tech Thanks for the feedback! We are currently investigating and will update you shortly.

@dmc-tech you will need to create service principles for ADFS.

Yes, that is clear, but can you be more precise in the connection example.  '--tenant ' mentions AAD tenant only, not AD FS.
Also, when supplying the key generated for the Service Principal, it has to be in PEM format.  Nowhere in the docs does it indicate how you go about converting the certificate to the correct format.  The example in the link you provide only shows how to connect via PowerShell.

@dmc-tech ADFS does have some AAD Components, and the Tenant ID is retrieved using the example Here.
$AzureStackInfo = Invoke-Command -Session $session -ScriptBlock { get-azurestackstampinformation }
 $TenantID = $AzureStackInfo.AADTenantID

@dmc-tech We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


[libdwarf] New port

Trying to add libdwarf. Needed for #34217.

[x] Changes comply with the maintainer guide
[x] The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
[x] Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx
[x] The versioning scheme in vcpkg.json matches what upstream says.
[x] The license declaration in vcpkg.json matches what upstream says.
[ ] The installed as the "copyright" file matches what upstream says.
[x] The source code of the component installed comes from an authoritative source.
[x] The generated "usage text" is accurate. See adding-usage for context.
[x] The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
[x] Only one version is in the new port's versions file.
[x] Only one version is added to each modified port's versions file.

I'm running into /usr/bin/ld: cannot find -lZLIB locally. Not sure what I'm doing wrong here.

Ok, looks like it's just z not ZLIB for linking.

I'm seeing dwarf_init_finish.c(57): fatal error C1083: Cannot open include file: 'zlib.h': No such file or directory on windows, not really sure why.

You must transfer these suggestions by hand.
Baseline: Use CMake targets to carry the right library names (z/zlib/zlibd) and include dirs (vcpkg_root/include). Use alias targets to keep the patch minimal.

I'm not sure why dlls are being created in static

Looked a little more but I'm not really sure what's up here. Unless VCPKG_LIBRARY_LINKAGE STREQUAL "static" doesn't do what I think it does. BUILD_NON_SHARED feels backwards to me but the current setting is working on everything but the two targets that are failing.

Hi @dg0yt and @Adela0814, I think this is now hopefully good to go

Note: I will be converting your PR to draft status. When you respond, please revert to "ready for review". That way, I can be aware that you've responded since you can't modify the tags.

Should be good now @Adela0814, thank you for the review!

@jeremy-rifkin  Usage test failed on x64-windows.
Usage:
  # this is heuristically generated, and may not be correct
  find_package(libdwarf CONFIG REQUIRED)
  target_link_libraries(main PRIVATE libdwarf::dwarf-static)

Error message:
1> CMake generation started for configuration: 'x64-Debug'.
1> Command line: "C:\WINDOWS\system32\cmd.exe" /c "%SYSTEMROOT%\System32\chcp.com 65001 >NUL && "C:\PROGRAM FILES\MICROSOFT VISUAL STUDIO\2022\COMMUNITY\COMMON7\IDE\COMMONEXTENSIONS\MICROSOFT\CMAKE\CMake\bin\cmake.exe"  -G "Ninja"  -DCMAKE_BUILD_TYPE:STRING="Debug" -DCMAKE_INSTALL_PREFIX:PATH="E:\CMakeTest\out\install\x64-Debug" -DCMAKE_TOOLCHAIN_FILE:STRING="E:\\5\vcpkg\\scripts\\buildsystems\\vcpkg.cmake" -DCMAKE_C_COMPILER:FILEPATH="C:/Program Files/Microsoft Visual Studio/2022/Community/VC/Tools/MSVC/14.37.32822/bin/Hostx64/x64/cl.exe" -DCMAKE_CXX_COMPILER:FILEPATH="C:/Program Files/Microsoft Visual Studio/2022/Community/VC/Tools/MSVC/14.37.32822/bin/Hostx64/x64/cl.exe"   -DCMAKE_MAKE_PROGRAM="C:\PROGRAM FILES\MICROSOFT VISUAL STUDIO\2022\COMMUNITY\COMMON7\IDE\COMMONEXTENSIONS\MICROSOFT\CMAKE\Ninja\ninja.exe" "E:\CMakeTest" 2>&1"
1> Working directory: E:\CMakeTest\out\build\x64-Debug
1> [CMake] -- The C compiler identification is MSVC 19.37.32824.0
1> [CMake] -- The CXX compiler identification is MSVC 19.37.32824.0
1> [CMake] -- Detecting C compiler ABI info
1> [CMake] -- Detecting C compiler ABI info - done
1> [CMake] -- Check for working C compiler: C:/Program Files/Microsoft Visual Studio/2022/Community/VC/Tools/MSVC/14.37.32822/bin/Hostx64/x64/cl.exe - skipped
1> [CMake] -- Detecting C compile features
1> [CMake] -- Detecting C compile features - done
1> [CMake] -- Detecting CXX compiler ABI info
1> [CMake] -- Detecting CXX compiler ABI info - done
1> [CMake] -- Check for working CXX compiler: C:/Program Files/Microsoft Visual Studio/2022/Community/VC/Tools/MSVC/14.37.32822/bin/Hostx64/x64/cl.exe - skipped
1> [CMake] -- Detecting CXX compile features
1> [CMake] -- Detecting CXX compile features - done
1> [CMake] -- Configuring done (6.2s)
1> [CMake] CMake Error at E:/5/vcpkg/installed/x64-windows/share/libdwarf/libdwarf-targets.cmake:60 (set_target_properties):
1> [CMake]   The link interface of target "libdwarf::dwarf-static" contains:
1> [CMake]
1> [CMake]     ZLIB::ZLIB
1> [CMake]
1> [CMake]   but the target was not found.  Possible reasons include:
1> [CMake]
1> [CMake]     * There is a typo in the target name.
1> [CMake]     * A find_package call is missing for an IMPORTED target.
1> [CMake]     * An ALIAS target is missing.
1> [CMake]
1> [CMake] Call Stack (most recent call first):
1> [CMake]   E:/5/vcpkg/installed/x64-windows/share/libdwarf/libdwarf-config.cmake:2 (include)
1> [CMake]   E:/5/vcpkg/scripts/buildsystems/vcpkg.cmake:859 (_find_package)
1> [CMake]   CMakeTest/CMakeLists.txt:17 (find_package)
1> [CMake] -- Generating done (0.0s)
1> [CMake] CMake Generate step failed.  Build files cannot be regenerated correctly.
1> 'C:\WINDOWS\system32\cmd.exe' '/c "%SYSTEMROOT%\System32\chcp.com 65001 >NUL && "C:\PROGRAM FILES\MICROSOFT VISUAL STUDIO\2022\COMMUNITY\COMMON7\IDE\COMMONEXTENSIONS\MICROSOFT\CMAKE\CMake\bin\cmake.exe"  -G "Ninja"  -DCMAKE_BUILD_TYPE:STRING="Debug" -DCMAKE_INSTALL_PREFIX:PATH="E:\CMakeTest\out\install\x64-Debug" -DCMAKE_TOOLCHAIN_FILE:STRING="E:\\5\vcpkg\\scripts\\buildsystems\\vcpkg.cmake" -DCMAKE_C_COMPILER:FILEPATH="C:/Program Files/Microsoft Visual Studio/2022/Community/VC/Tools/MSVC/14.37.32822/bin/Hostx64/x64/cl.exe" -DCMAKE_CXX_COMPILER:FILEPATH="C:/Program Files/Microsoft Visual Studio/2022/Community/VC/Tools/MSVC/14.37.32822/bin/Hostx64/x64/cl.exe"   -DCMAKE_MAKE_PROGRAM="C:\PROGRAM FILES\MICROSOFT VISUAL STUDIO\2022\COMMUNITY\COMMON7\IDE\COMMONEXTENSIONS\MICROSOFT\CMAKE\Ninja\ninja.exe" "E:\CMakeTest" 2>&1"' execution failed with error: ''C:\WINDOWS\system32\cmd.exe' '/c "%SYSTEMROOT%\System32\chcp.com 65001 >NUL && "C:\PROGRAM FILES\MICROSOFT VISUAL STUDIO\2022\COMMUNITY\COMMON7\IDE\COMMONEXTENSIONS\MICROSOFT\CMAKE\CMake\bin\cmake.exe"  -G "Ninja"  -DCMAKE_BUILD_TYPE:STRING="Debug" -DCMAKE_INSTALL_PREFIX:PATH="E:\CMakeTest\out\install\x64-Debug" -DCMAKE_TOOLCHAIN_FILE:STRING="E:\\5\vcpkg\\scripts\\buildsystems\\vcpkg.cmake" -DCMAKE_C_COMPILER:FILEPATH="C:/Program Files/Microsoft Visual Studio/2022/Community/VC/Tools/MSVC/14.37.32822/bin/Hostx64/x64/cl.exe" -DCMAKE_CXX_COMPILER:FILEPATH="C:/Program Files/Microsoft Visual Studio/2022/Community/VC/Tools/MSVC/14.37.32822/bin/Hostx64/x64/cl.exe"   -DCMAKE_MAKE_PROGRAM="C:\PROGRAM FILES\MICROSOFT VISUAL STUDIO\2022\COMMUNITY\COMMON7\IDE\COMMONEXTENSIONS\MICROSOFT\CMAKE\Ninja\ninja.exe" "E:\CMakeTest" 2>&1"' returned with exit code: 1'.

Thank you, I think the best solution is just to provide a usage text including instructions to find_package(ZLIB CONFIG REQUIRED). It's a bit misleading that the libdwarf target is dwarf-static regardless of static or dynamic linkage but I'm not sure it's worth the effort to fix.
Should be good to review again now.

Thank you, I think the best solution is just to provide a usage text including instructions to find_package(ZLIB CONFIG REQUIRED). It's a bit misleading that the libdwarf target is dwarf-static regardless of static or dynamic linkage but I'm not sure it's worth the effort to fix.
Should be good to review again now.

It's better to add find_dependency(ZLIB) to ***Config.cmake.

@jeremy-rifkin I will send you a PR instead of review comments.

https://github.com/jeremy-rifkin/vcpkg/pull/1

Updates dependency import and export. Skips the try-compile for zlib and zstd because it doesn't work well with targets, and we know the result.
Install proper pkg-config.
Fixes library linkage, and ensures dllexport.
Installs the dwarfdump tool.

I think it should now be good to go for another review. Thanks so much for all the help!

The target is named differently for shared/static, which seems sub-ideal. I might be able to add an alias to take care of that if needed.

The target is named differently for shared/static, which seems sub-ideal. I might be able to add an alias to take care of that if needed.

Please restore the usage file. It is the correct solution to the target name variation.

No feature needs to test.
Usage tested pass on x64-windows.

@dg0yt My apologies, I didn't realize you had updated the usage file :)

Your usage file works for me locally for x64 static and shared


Add response.content_range() API

When working with content ranges, all clients would need to perform the same content range parsing based on RFC. Would it be ok to add support for such parsing to the reqwest lib? I could try to provide a PR for that if there is interest.
Update I implemented this as a separate crate - not sure if the reqwest maintainers want to use it directly.
/// HTTP Content-Range response header representation.
pub enum ContentRange {
    /// Regular bytes range response with status 206
    Bytes(ContentRangeBytes),
    /// Regular bytes range response with status 206
    UnboundBytes(ContentRangeUnbound),
    /// Server response with status 416
    Unsatisfied(ContentRangeUnsatisfied),
    /// Header cannot be parsed. This includes non-standard response with status 206
    Unknown,
}

pub struct ContentRangeBytes {
    pub first_byte: u64,
    pub last_byte: u64,
    pub complete_length: u64,
}

pub struct ContentRangeUnbound {
    pub first_byte: u64,
    pub last_byte: u64,
}

pub struct ContentRangeUnsatisfied {
    pub complete_length: u64,
}

@seanmonstar hi, any thoughts on this? The crate is stable by now, and had 150k+ downloads


Way to stop "double workflows" when pushing a tag

Feature Description
I have a Gitea Actions workflow that is run on my master branch, but also has to be run on tags so it can create a Gitea Release.
This means that when I push a new release, Gitea will start two workflows. One on master which will just build the project, and another on the new tag which will build the project and create a release.
While GitHub might be able to handle this sort of redundancy, my poor overworked server cannot.
It would be nice if there was a way to configure Gitea to only run one workflow when a commit is pushed to master and a tag at the same time.
Screenshots
No response

If it only runs one workflow, which one it should? Just build the project or create a release?
And I think the older workflow will be canceled if you only have one runner and two running workflows.

Ideally there would be a way to configure it. For instance in my case, I'd want to it to skip building master if the same commit is pushed as a tag.
The issue is that because my server sucks and my project has to be built for multiple architectures, my CI takes 3 hours. So I have to wait 3 hours for it to build a redundant build on master, before waiting another 3 hours for it to build again on the tag.
And it's definitely not auto-cancelled:

My bad. Auto cancel is for the same event.


Add multiple : true to the $mdDialog ?

Hello, thank you for your plugin.
I would like to use it inside a $mdDialog, is it possible to add the multiple option for the $mdDialog ?
Thanks

I'm having the same issue. Ever since the 1.1.2 release of angular material, the color picker inside a $mdDialog will close the dialog
https://github.com/angular/material/blob/master/CHANGELOG.md

Hello,
I was having the same issue. So i dig inside dist/mdColorPicker.js. The plugin is using skipHide to implement the multi dialog functionality but skipHide is removed from angular material. They added the multiple option, so go inside dist/mdColorPicker.js search for skipHide and replace it with multiple and that's it.
I hope a next version @brianpkelley  will implement that new option instead of skipHide.

+1

Is this fixed  in the latest version

+1

This is related to issue #111.

I set default options for $mdDialog.show like this in my module config to work around this issue:
        .config(function($provide) {
            // Decorate the $mdDialog service using $provide.decorator
            $provide.decorator("$mdDialog", function ($delegate) {
                // Get a handle of the show method
                var methodHandle = $delegate.show;
                function decorateDialogShow () {
                    var args = angular.extend({}, arguments[0], { multiple: true })
                    return methodHandle(args);
                }
                $delegate.show = decorateDialogShow;
                return $delegate;
            });
        });


Wrong  links in Jules Kremer's info on 'about us' page

https://angular.io/about/
Jules Kremer's info has invalid twitter and webiste urls :
https://twitter.com/undefined
https://angular.io/about/undefined

Closed by #1027


ci: Switch to Circle 2.0

Closing. This was superseded by https://github.com/jcfr/qt-easy-build/pull/56


Add Hydra

Create me readme

Why:
Closes [issue link]

What's being changed:

Check off the following:

[x] I have reviewed my changes in staging (look for the deploy-to-heroku link in your pull request, then click View deployment).
[ ] For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

[x] This pull request impacts the contribution experience

[ ] I have added the 'writer impact' label
[ ] I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

Thank you for the pull request. We are unable to accept this change at this time.


fix: consign route on artwork pages

Description
This PR fixes the consign route on artwork pages. The route was changed from /sales to /sell
https://github.com/artsy/eigen/assets/11945712/2f599c0b-0634-4b40-9c11-52625d6892ce

PR Checklist

[x] I have tested my changes on iOS and Android.
[x] I hid my changes behind a feature flag, or they don't need one.
[x] I have included screenshots or videos, or I have not changed the UI.
[x] I have added tests, or my changes don't require any.
[x] I added an app state migration, or my changes do not require one.
[x] I have documented any follow-up work that this PR will require, or it does not require any.
[x] I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

[ ] I would like at least one of the reviewers to run this PR on the simulator or device.

Changelog updates
Changelog updates

Cross-platform user-facing changes

fix consign route on artwork pages - mounir

iOS user-facing changes

Android user-facing changes

Dev changes

Need help with something? Have a look at our docs, or get in touch with us.

This PR contains the following changes:

Cross-platform user-facing changes (fix consign route on artwork pages - mounir)

  Generated by :no_entry_sign: dangerJS against aab8c86178627d6a1686e19a3048fe1e42b04221


✨ 🐛  new interaction features, bugfix and refactor

Bugfix in command loader, dispatcher close & partialmember + removed some __post_init__s.
Added:

MessageContext interaction property
MessageContext.send coroutine
Interaction.ack coroutine
Restart method

closes #166
closes #161

I'll handle the conflict within other prs


[$500] Sign In - Data - Acc and app data does not fully loaded after attempt to Sign In with suspended acc

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Open https://staging.new.expensify.com/
Tap in email label
Write a suspended account email
Tap "Continue" button
Tap on "Back"
Replace the email with a valid (non-suspended) account email
Tap on "Continue" button
Fill the magic code label
Observe the listed chat in LHN
Tap on FAB
Tap on Request Money
Select Manual tab
Tap on currency
Observe listed currencies

Suspended account<EMAIL_ADDRESS>Tested account<EMAIL_ADDRESS>Expected Result:
User should be signed in and all account and app data should be loaded
Actual Result:
Step 9:
Only several conversations listed in LHN (the issue occurs occasionally)
Step 13:
Unable to change currencies because all currencies is missing on search page
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

Version Number:  1.3.79-3
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/78819774/d1a99e9d-9d12-45f2-9c5c-df8386ab4549
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01240579ed69bf1c9d
Upwork Job ID:<PHONE_NUMBER>061881856
Last Price Increase: 2023-10-17

^ just added external label

waiting for proposals

Not overdue, still waiting for proposals.

@lanitochka17
The account<EMAIL_ADDRESS>doesn't have emails suspended anymore. Do you happen to have other account that has emails suspended? I'm not able to reproduce it anymore

@NicMendonca Let's assign this issue to @MrMuzyk, so there's no proposal submitted.

Hello We don't have any blocked accounts yet

@lanitochka17
That's too bad :( I think I've found the root cause of the issue but in order to confirm that together with the fix I need an account to test this. I've asked for help in obtaining account with suspended mailing but no luck so far.

@MrMuzyk I found a suspended email you can try<EMAIL_ADDRESS>

@mollfpr
Thanks, I've tried it and it works so I'm working on proposal now

Hey, I’ve started work on some wave6 features that are high-priority and someone else from Callstack will take over this issue

@MrMuzyk cool! Do we know who that person will be yet?

@NicMendonca Hi! I'm Bartek from Callstack and I want to take over this issue, please assign me :)

Not overdue, Melv. Bump @NicMendonca to assign this issue to @barttom.

Proposal
Please re-state the problem that we are trying to solve in this issue.
When user tries to log in into account that has email suspended, then goes back and logs into regular account, then regular account doesn’t behave properly.
What is the root cause of that problem?
When user logs into to the app a check if performed to see if it should initialise the app with App.openApp() or to try to reconnect - https://github.com/Expensify/App/blob/main/src/libs/Navigation/AppNavigator/AuthScreens.js#L171
When we first try to log in into the account with suspended mails and then into the regular account this check https://github.com/Expensify/App/blob/main/src/libs/SessionUtils.ts#L39 sets loggedInDuringSession variable to false because authToken is already present at this point. It happens even though this variable just got reset when going back to 1st step of login form - https://github.com/Expensify/App/blob/main/src/libs/actions/SignInRedirect.ts#L83
What changes do you think we should make in order to solve the problem?

We can check if current email is different that this saving into session, by adding another conditional in https://github.com/Expensify/App/blob/main/src/libs/Navigation/AppNavigator/AuthScreens.js#L158
const isLoggingInAsNewUser = SessionUtils.isLoggingInAsNewUser(currentUrl, session.email);
const shouldGetAllData = isUsingMemoryOnlyKeys || SessionUtils.didUserLogInDuringSession() || isLoggingInAsNewUser;

What alternative solutions did you explore? (Optional)
We should change the check in this line - https://github.com/Expensify/App/blob/main/src/libs/SessionUtils.ts#L39 to if (session?.authToken && loggedInDuringSession !== undefined) { to also account for the reset of loggedInDuring session variable. If it gets reseted we should be ignoring already present authToken which will result in App.openApp() being called after logging in and resolving our issue.

The proposal looks good to me! @barttom Let's do it!
🎀 👀 🎀 C+ reviewed!

Sounds good to me too.

The fix was merged two weeks ago, should we close this issue?

The PR that introduced the bug has been identified. Link to the PR:
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

No offending PR.

A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

The regression step should be enough. I think this is a case where we haven't handled it yet.

Determine if we should create a regression test for this bug.
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Open the app
Try to log in with a suspended account (e.g<EMAIL_ADDRESS>and type continue
Tap back to the login screen
Log in with Your proper account.
Observe the listed chat in LHN - should have listed Your chats
Tap on FAB -> Tap on Request Money -> Tap on currency - should have a list of currencies
👍 or 👎

@NicMendonca Could you give the payment summary so I can do the manual request? Thank you!

This caused a regression. See https://github.com/Expensify/App/issues/32590#issuecomment-1845121244

Re-opening for the regression. Also holding payment until regression is resolved.

What are the next steps here?

bump @barttom @mollfpr! Have you had a chance to look at this regression?

Sorry, I'm unaware that the OpenApp should be called once after login.

Sorry, I'm also not aware of that. Looks like they proceeded solution in the other issue

Alright, so are you saying that @iwiznia shouldn't have identified this issue as a regression?

Let's get to the bottom of this soon, as it's delaying payment for @mollfpr until we align on whether a regression was involved or not.

@JmillsExpensify I believe there's a regression, but the root cause of the proposal was correct.

Ok, so in that case, I approve the $500 payment for @mollfpr based on this comment.


Ensemble percentiles as dimension instead of variables

Currently, xclim.ensembles.ensemble_percentiles takes in a dataset and returns a new one with one variable per percentile and data variable. A more "xarray-like" behaviour would be to replace the realization dimension by the percentile dimension. In fact, ensemble_percentiles is more or less a xr-wrapper and workaround because xr.quantiles doesn't work on dask arrays.
Moreover, it would be nice if ensemble_percentiles accepted DataArrays directly.
Discussion points:

Should we keep the old behaviour (creating new variables)?
If yes, should it be the default?

Should we keep the old behaviour (creating new variables)?

I think I would still need via a split flag: climatedata.ca is pretty much built to read the separate variable output (e.g. tg_mean_p10, p_50, p_90).
it seems like it should most likely be the default though... as it is more xarray like


Missing columns in table header

First of all. Congratulation to us with issue/PR #100! Let's celebrate with an extra long Christmas holiday.
In the new and much faster version of the table, not all the columns are shown in the header of the table. All data in the table can be shown by using the scrollbar in the bottom, but this does not affect the header of the table.

So should the header bar should scroll in line with the columns?
I am seeing weird things in which the header line changes the columns it shows when scrolling up and down.
(I think because the size of the data visible is changes, which changes column size dynamically.)

That is true, I also see that. But if the horizontal slider is all the way to the left, the columns seems to match. However, I am never able to see the most right header names, just the data when I scroll horizontally to the right.


services.xserver.resolutions does not apply in qemu VMs

Issue description
I've got a test setup that runs:
nix-build -I ~/nixpkgs -I nixos-config=./test/test-config.nix '<nixpkgs/nixos>' -A vm
./result/bin/run-machine-test-vm

The test-config.nix sets the option services.xserver.resolutions to a supported resolution but the generated X config does not contain the resolution. The services.xserver.virtualScreen does add things to the X config, but does not change anything.
I can switch to my requested resolution in the virtual machine via xrandr, so I don't think it's a resolution support issue.
Steps to reproduce
basic.nix:
{ config, pkgs, lib, ... }:
{

  services.xserver.enable = true;
  services.xserver.windowManager.i3.enable = true;
  services.xserver.windowManager.default = "i3";
  services.xserver.displayManager.slim.enable = true;
  services.xserver.displayManager.auto.enable = true;
  services.xserver.displayManager.auto.user = "root";
  services.xserver.resolutions = { x = 1680; y = 1050; };
  services.xserver.virtualScreen = { x = 1680; y = 1050; };

  virtualisation.memorySize = 1024;
  virtualisation.qemu.options = [ "-full-screen -sdl" ];

  networking.hostName = "basic-test";

  system.stateVersion = "16.03";
}

Commands:
  $ nix-build -I nixpkgs=path-to-nixpkgs \
                   -I nixos-config=./basic.nix \
                    '<nixpkgs/nixos>' -A vm
  $ ./result/bin/run-basic-test-vm

Result is an X11 setup with 1024x768 as the resolution, instead of what has been set in services.xserver.resolutions.
Technical details

Host System: 16.03.1287.6ac7ffd
Host Nix version: nix-env (Nix) 1.11.2
Host Nixpkgs version: 16.03.1287.6ac7ffd

Tested nixpkgs=... for:

no nixpkgs, using 16.03.1287.6ac7ffd directly.
release-16.03 revision a8e0739 (16.03pre-git).
release-16.09 revision dccf8c5 (16.09pre-git).

Can you also print the output of xrandr on the guest? Maybe it can not use the resolution you specified.

@domenkozar: "I can switch to my requested resolution in the virtual machine via xrandr, so I don't think it's a resolution support issue."
That said (switched to openbox since i3 in i3 was causing keybinding conflicts):

For posterity:
resolutions is overrided at nixos/modules/virtualisation/qemu-vm.nix line 512.
mkVMOverride is mkOverride 10, so you can force the value you want with something like:
services.xserver.resolutions = lib.mkOverride 9 { x = 1680; y = 1050; };
This old issue can be closed.

As reported by @ThibautMarty , lib.mkOverride is needed to change the resolution.


Inconsistent treatment of [as] in SMILES and SMARTS

Description:
Here's the reproducible showing the problem:
In [10]: Chem.MolToSmiles(Chem.MolFromSmiles('[as]1ccccc1'))
Out[10]: 'C1=CC=[As]C=C1'

In [11]: Chem.MolToSmarts(Chem.MolFromSmarts('[as]1ccccc1'))
Out[11]: '[a&s]1ccccc1'

These should at least be consistent with each other; probably it makes sense to go with the (probably) clear intent that [as] in a SMARTS means [a&#33]
When fixing this, should also check other inconsistencies

Nice to see this one fixed - thanks Greg!


Cannot build plugin

Since the addition of the withChecks (#49), I've been unable to build locally, due to the error:
 Failed to resolve new artifacts: Could not find artifact io.jenkins.plugins:checks-api:hpi:1.2.0null in repo.jenkins-ci.org (https://repo.jenkins-ci.org/public/). The API analysis will not proceed.

Adding back the -SNAPSHOT to the pom doesn't help, as it then complains about breaking semantic versioning.
Out of interest, I tried bumping to 2.0.0 (with -SNAPSHOT), which succeeded, but with:
Failed to resolve old artifacts: Could not find artifact io.jenkins.plugins:checks-api:hpi:1.2.0${changelist} in repo.jenkins-ci.org (https://repo.jenkins-ci.org/public/). The API analysis will proceed comparing the new archives against an empty archive.

:(

This is what I noted in my review: https://github.com/jenkinsci/checks-api-plugin/pull/49/files#r544681526

Without a SNAPSHOT we cannot release as well.


MWPW-148028 | Change bg remove launch load in deps js

Change bg remove launch load in deps js
Resolves: MWPW-148028
Test URLs:

Before: https://main--cc--adobecom.hlx.live/drafts/mathuria/performance/remove-background?martech=off
After: https://mwpw148028--cc--adobecom.hlx.live/drafts/mathuria/performance/remove-background?martech=off

Validation done in below url :
https://mwpw148028--cc--adobecom.hlx.live/products/photoshop/remove-background

verified the analytics call


VSTS shallow cloning does not shallowly clone submodules and clones all branches

Agent Version and Platform
2.115.0
OS X and Windows
VSTS Type and Version
visualstudio.com
maungu
What's not working?
Everything works, just not efficiently. 3 excerpts below
2018-04-02T14:51:32.8066258Z ##[command]git remote add origin $url

2018-04-02T14:51:32.9933327Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ********" fetch --tags --prune --progress --no-recurse-submodules --depth=1 origin

2018-04-02T14:52:14.9899144Z ##[command]git -c http.https://github.com.extraheader="AUTHORIZATION: basic ********" submodule update --init --force --recursive

These two commands do a lot more work than needed:
a) Cloning does not clone a single branch, so all the objects for refs alive in the remote are cloned. In the case of a repository with remote branches which were not deleted, it'll pull in more objects than needed. The branch name can be specified after the remote like so
git fetch --no-tags --prune --progress --no-recurse-submodules --depth=1 origin master

Another option is to add the remote via:
git remote add -t $branch origin $url
b) --tags is supplied instead of --no-tags, which causes fetching of tags.
c) submodules are not shallowly cloned in the depth=1 version. This should work always with git > 2.8.

@Therzok
a) branch is not required for queuing a build, you can provide either a branch or a commint hash, so the client has to fetch origin in case the there is no branch been provided.
b) we support build a given tag, so the client has to fetch tags.
c) thanks for let me know this, i will fix this later. :)

I see.
Tag names could be supplied too at the end of the fetch parameter or as a specific ref to grab. Regardless it seems there is a way to actually just fetch a single commit, but it is computationally expensive to actually look for the commit and grab only that (has to traverse the ref until it reaches the commit itself), and it seems to time out on github on my test case.
So yeah, it seems better to grab all the branches. Thank you for looking into this!

#1594

i will close this issue, the next agent release will pass fetch depth to git submodule udpate


Update persistence

Updates the existing self-employments persistence to use partial updates so that arrays are not overridden. Applies appropriate indexes and provides a pattern for persisting summaries.

👍


[BUG] Slow as hell with +2GB db size even on SSD

Version
5.0.11
Describe the bug
When file of the DB grows over +2GB then the Insert method becomes almost unresponsive
Code to Reproduce
just add +10M entities and try to add more
Expected behavior
not sure
Screenshots/Stacktrace
NA
Additional context
no Indexes were added so far

It is better to insert BsonDocument entities (without mapping). In my case, 18m rows were inserted in 5 minutes, and actual DB file about 5GB.

Hi @okarpov, can you describe how design your document? How many fields/arrays/subdocuments contains? How many indexes you have in this collection?

I used my class for storing bitcoin keys
it had >10M rows/items
`[Table("Search")]
public partial class Search
{
public long ID { get; set; }
    [StringLength(128)]
    public string Priv { get; set; }

    [Required]
    [StringLength(128)]
    public string PubWif { get; set; }

    [Required]
    [StringLength(128)]
    public string PubAddr { get; set; }

    public decimal amt { get; set; }
}`

Did you have any adicional index? Can you send some data-example of "Priv", "PubWif" e "PubAddr" to get some size-idea per iitem?


Switch to use Too Many Requests response code

@bgrant0607 pointed out that we should really return a 429 Too Many Requests code for rate limit error responses rather than Service Unavailable.

Ping. I'd like to get this in quickly, before we have clients in the wild dependent on the current behavior.

Sorry, I actually did this in < 10 mins after you asked but then my laptop
fork of the repo got into the version error with document generation.
I will re-do the work from my work fork now.
S
On Tue, Jan 27, 2015 at 2:05 PM, Brian Grant<EMAIL_ADDRESS>wrote:

Ping. I'd like to get this in quickly, before we have clients in the wild
dependent on the current behavior.
—
Reply to this email directly or view it on GitHub
https://github.com/GoogleCloudPlatform/kubernetes/pull/3781#issuecomment-71737638
.

Done. PTAL. Thanks.

Thanks much. Two quick tweaks.

Done. PTAL.

Thanks much. Could you please remove the definition from here:
https://github.com/GoogleCloudPlatform/kubernetes/blob/358ace610d7036991e0b14b9a3a9a5e513e1d8b3/pkg/apiserver/apiserver.go#L54
and update the use here:
https://github.com/GoogleCloudPlatform/kubernetes/blob/4c413e794ef04081dd5ed41bbe0b61fc0acc819f/pkg/apiserver/handlers.go#L99

Done. It was tricky to add the line:
	"github.com/emicklei/go-restful"

with my Emacs Go settings (I had to use vi). Perhaps it should read:
	restful "github.com/emicklei/go-restful"

LGTM


Add ManyToMany relationship field at the sqla orm.

Currently we don't support the custom ManyTOMany relation field. TO defile this currently we are using the old flask-sqlalchemy ManyToMany relation system. We need to add our own wrappers for this.

Django like orm system is quite difficult in SQLAlchemy. So we have decided to use the default SQLAlchemy pattern  to define the relationships. So we will remove the OneToOne and ManyToOne fields from the fields of Navycut-ORM.


Refactor file upload to use Upload model

This commit refactors the file upload functionality to use the Upload model. This is a polymorphic model that can be attached to any other model. It is used to store the file data and metadata.
I also added a rake task to transfer the existing file data to the new model.

Superseded by #764


Request failed [404]

Hello, I've been consistently encountering an issue when attempting to download data. The error message I receive is 'Request failed [404], try in 1.6.' I appreciate your guidance in addressing this problem. Thank you in advance!

I managed to download by changing the url in the bm_get_data() function
from : https://ladsweb.modaps.eosdis.nasa.gov/opendap/hyrax/allData/5000/
to : https://ladsweb.modaps.eosdis.nasa.gov/opendap/RemoteResources/laads/allData/5000/
I also had difficulties to connect but the problem (though quite similar)  came from  opendapr
(see https://github.com/ptaconet/opendapr/pull/6), I did the changes on my computer and asked for a pull request

Thanks for signalling this @babakou9 ! I pushed the change


Allow "Point" for RoadEventFeatures

Background
WZDx has always implied that a road event must include least a start and end coordinate, though it hasn't been technically required by the specification.
Currently, the documentation for the RoadEventFeature geometry property states:

The Geometry object's type property MUST be LineString or MultiPoint. LineString allows specifying the entire road event path and should be preferred. MultiPoint should be used when only the start and end coordinates are known.

The GeoJSON Point geometry is explicitly not allowed. However, there is nothing in the JSON schema limiting the number of positions (coordinate pairs) included for a LineString or MultiPoint, so technically including only one position is valid and has been used in practice.
Proposed Change Options

Update the JSON schema to require at minimum that two positions are provided for LineString and MultiPoint. In addition, the description of the RoadEventFeature geometry should clearly state this. For cases where only a point location is known, producers can use the same lat/lon for both points in the coordinates array; OR
Remove the language about road events needing at least a start and end point and allow "Point" as a geometry type option for the RoadEventFeature.

Is there a specific reason triggering this request? We see some validity in having an event reported with just a single point in case of very short road work or when the ending position is yet unknown (currently deploying equipment).

The vast majority of road events will only be a single point for many years into the future.  It is just a reality that 85% of the work will be represented by an automated report from a truck with its flashers on or a smart arrow board.

Given the above comments, this issue can shift to discussion about adding Point geometry as an option for a RoadEventFeature.

Note that Option 1. is a breaking change as any RoadEventFeatures including only one position would no longer be valid.

Co-chairs discussion 2022-09-23 led to supporting the current implementation which emphasizes that road events should have at least a start and an end point. It is valid to include an event with a single lat/lon pair, but is not recommended.


hub-tool logout produces scary error message when not logged in

Description

When using hub-tool logout, an obscure error message is produced if I'm not currently logged in to Docker Hub
Steps to reproduce the issue:
$ hub-tool login
Username: thajeztah
Password:
Login Succeeded

$ hub-tool logout
Logout Succeeded

$ hub-tool logout
Error: error erasing credentials - err: exit status 1, out: `error erasing credentials - err: exit status 1, out: `The specified item could not be found in the keychain.``

Note that the docker cli looks to have the same issue in similar conditions (also something we should fix), but provides slightly more details on what it's doing;
$ docker logout
Removing login credentials for https://index.docker.io/v1/

$ docker logout
Removing login credentials for https://index.docker.io/v1/
WARNING: could not erase credentials:
https://index.docker.io/v1/: error erasing credentials - err: exit status 1, out: `error erasing credentials - err: exit status 1, out: `The specified item could not be found in the keychain.``

Describe the results you received:
A scary error message
Describe the results you expected:
Either;

the same message as when running a successful logout ("Logout Succeeded")
a message informing me that I was not logged in

Given that the end-result is the same for the user, I'm tempted to prefer 1., and consider logout to be idempotent
Additional information you deem important (e.g. issue happens only occasionally):
Output of docker hub --version:
hub-tool --version
Docker Hub Tool v0.2.0, build 0edf43a

I suggest this fix: #166
I implemented @thaJeztah first suggestion using a little existence check when the erase fails.
Let me know what do you think 🙂

I suggest this fix: #166
I implemented @thaJeztah first suggestion using a little existence check when the erase fails.
Let me know what do you think 🙂


Validate extension examples with circle ci

We are using CircleCI for checking the main examples, but it'd be great to also validate the examples in the 'extensions', making sure they are valid stac, and ideally valid to the extension fields.

I don't think we'll get to this for 0.8.0, moving out.

See PR #834


Rip CDs and DVDs automatically when inserted

Flagging this feature enhancement idea: Automatic CD and DVD ripping.
Since our laptops, tablets, and phones lack optical drives, it would be extremely convenient to have the optical drive of the Ansible NAS rip CDs and DVDs directly to the media shares automatically on insertion, and then eject when finished. This could be done using clever scripted abcde and handbrake-cli.
Most Ansible NAS boxes will lack a GUI, and you don't necessarily want to have to SSH into your box to rip a CD with a command-line interface. I envision that you pop in the CD and 5 minutes later it ejects and you see it in your music share. Hands-free.
If I ever get this working I will submit a PR. If anyone beats me to it, let us all know here.

Nice idea for those that still own CDs and optical drives! Please do submit a PR if you get anywhere with this. 👍

I've great success running this on a Linux Mint machine: https://github.com/automatic-ripping-machine/automatic-ripping-machine

@manikmakki ARM looks amazing and if you look at my original comment it is exactly what I envisioned. I am going to experiment with this and if I add it to my Ansible-NAS I will submit a PR.

I wonder if there would be a lower-tech way of doing this with a simple shell script based on Safecopy
(see https://askubuntu.com/questions/15827/recovering-files-from-a-corrupt-cd-dvd). Something that has
safecopy --stage1 /dev/cdrom /mnt/scratch/cd1.iso as the main ingredient?

Please consider https://github.com/whipper-team/whipper for this.

Possibly someone could look at VortexBox and duplicate how it does it. I've used it in the past and it works really well.
REF: https://wiki.vortexbox.org/what_is_vortexbox

One hurdle would be that cd-rom/dvd devices are not generally available to containers in Docker that I am aware of. In the interest of keeping software in containers, LXC/LXD does allow passing a cd-rom through to a container, so perhaps an AutomaticRippingMachine LXC container could be created?
This would be a heck of a lot more work to do via Ansible than just pulling an image via Docker and setting a couple of env variables, though.

Looks like mounting the optical drive is more or less the same complexity as sharing a normal data folder https://docs.cancergenomicscloud.org/docs/mount-a-usb-drive-in-a-docker-container
As for whether ARM or similar software will recognise when a CD/DVD is inserted or not is another matter. This might be a path to explore though, a simple cron every minute on the container to check whether data in the mounted directory has changed or not might help (sadly, this is the resolution limit on cron >_<) but this is far from ideal. This project may help though https://github.com/rix1337/docker-ripper (uses https://hub.docker.com/r/jlesage/makemkv/ ) although this software is in Beta with free keys currently and may cease functioning at any point and require payment.

I've got a MakeMKV container in use that works well but I have not tried it for auto-ripping. I will be doing a PR in the future and will look into changing it to autorip if I can.


Fixing possible NPE in SourceDecorator

I've seen NPEs during logging.
@pcadabam Can you review?

@pcadabam ping

LGTM

LGTM


Is there a way to validate a document with custom validation rules?

Hey, I am maintaining a GraphQL server library that uses this package. I am planning to allow the user of my library to add additional custom validation rules which will be used to validate incoming requests before they are executed. My library is heavily inspired by apollo-server and looking at their approach, they are using the graphql-js validate function here.
I figured this package should also have the same function, but the only validate function that is public doesn't accept any custom rules.
https://github.com/GraphQLSwift/GraphQL/blob/283cc4de56b994a00b2724328221b7a1bc846ddc/Sources/GraphQL/Validation/Validate.swift#L11
I found out that the primary entry point function already perform validation but it also doesn't accept custom validation rules.
https://github.com/GraphQLSwift/GraphQL/blob/151c2f18dd12bd7bb6ab301a212c1da2010415ea/Sources/GraphQL/GraphQL.swift#L92
It seemed like this library already have the function and struct needed for custom validation, but they are just not public. I am not sure if this is a intentional decision.

Hey @paulofaria, before I mash merge on this PR, was scoping the validation functions as internal an intentional decision?

@NeedleInAJayStack not that I can't remember. Probably out of habit.


Prevent extraneous whitespace around date time inputs in Webkit

Fixes #34433, closes #37313.
Description
Motivation & Context
Type of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Refactoring (non-breaking change)
[ ] Breaking change (fix or feature that would change existing functionality)

Checklist

[x] I have read the contributing guidelines
[x] My code follows the code style of the project (using npm run lint)
[ ] My change introduces changes to the documentation
[ ] I have updated the documentation accordingly
[ ] I have added tests to cover my changes
[x] All new and existing tests passed

Live previews

Before: https://codepen.io/stephenreay/pen/dyexpoG
After: https://codepen.io/stephenreay/pen/NWMQRxy

Related issues
twbs/bootstrap#34433

LGTM! Thoughts @julien-deramond?

LGTM as well! Tried it on the latest versions of FF, Chrome, Safari and Edge + all Safari version until 13 (there was an issue with the rendering of CodePen with the 12 but I suppose it'll work as well).
@stephenreay In order to merge this PR could you please just update the corresponding value of FAIL ./dist/css/bootstrap.css: 29.5KB > 29.5KB (gzip) in .bundlewatch.config.json to set it to "maxSize": "27.75 kB".

Assuming you meant 29.75, done.

should this be added to the Reboot file similar to how it was done in https://github.com/twbs/bootstrap/pull/30269?


fix: remove automatic content-type header on file upload

Fixes #138

Although, we could take out contentType from FileUploadOptions as well then, am I right?
Also it has the similar assignment in chunk.ts, and soc.ts

Although, we could take out contentType from FileUploadOptions as well then, am I right?

No, we do want to let the user define the content-type. What this change does is that when the user does not define a content-type we don't set it in the header automatically to application/octet-stream but instead let Bee to decide it based on the content of the file.

Also it has the similar assignment in chunk.ts, and soc.ts

It only matters with files, because there the content-type is preserved and returned when the user fetches the content. Chunks (SOCs included) are handled as binaries by Bee and therefore having content-type as application/octet-stream is correct.


Altme : Change the text on the splash screen

Replace : "Manage credentials, NFTs and coins in one app" by "Your digital identity and digital assets, secured."

Size: S


Closes #1670 : Modify a string

Description
Made the desired changes to the string.
Related issues and discussion
Fixes #1670
Checklist
Make sure you've done all the following (You can delete the checklist before submitting)

[x] Apply the AndroidStyle.xml style template to your code in Android Studio.
[x] Code is well documented
[x] Include unit tests for new functionality
[x] All user-visible strings are made translatable
[x] Code passes Travis builds in your branch
[x] If you have multiple commits please combine them into one commit by squashing them.
[x] Read and understood the contribution guidelines .

LGTM. Merging :)

Hey @huzaifaiftikhar,
Something went wrong with the build.
TravisCI finished with status errored, which means the build failed because something unrelated to the tests, like a problem a dependency or the build process itself.

Hey @huzaifaiftikhar,
Something went wrong with the build.
TravisCI finished with status errored, which means the build failed because something unrelated to the tests, like a problem a dependency or the build process itself.


[STORM-1517] add peek api in trident stream

Similar to the Java 8 peek, the peek api can be used to examine trident tuples at
some point in the stream pipeline or execute some custom actions.
Note: this includes changes from https://github.com/apache/storm/pull/1050 and should go away once that gets merged.

upmerge?

done

Reviewed code and run the sample topology by local.
LGTM, +1

@arunmahadevan
Could you submit a pull request which documents this feature to asf-site?
After submitting pull request I'll merge this.

@HeartSaVioR raised https://github.com/apache/storm/pull/1083 for updating doc.

@arunmahadevan Great, I'll merge both.


String performance improvements on top of #411

This adds additional performance improvements (namely string.Concat overloads) for a few cases. It also eliminates an extra check inside QueryHelper.

Hi @NickCraver, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.
TTYL, DNFBOT;

W00p!

As this is performance related, please share your relevant measurements.

@Tratcher sorry! I took for granted this was a more widely known thing - string.Concat() has overloads for up to 4 strings and it's substantially faster than string.Format() for these cases. I've put up some quick benchmarks here as a sample: https://gist.github.com/NickCraver/fce9754c50aa7a4c9593

:shipit:

string.Concat() has overloads for up to 4 strings and it's substantially faster than string.Format() for these cases.

Can't disagree; but feels like coreclr or rosyln is missing a trick here; or maybe its that they aren't missing the trick with .Concat :D

Is there an existing issue for optimizing these types of interpolated strings (basically concatenating strings) in the Roslyn repo?


update testnet latest release version

testnet latest release is v1.7.1-rc1 which is not what is mentioned in the readme file

we will provide a link to terraform registry where ppl can list all versions


Drop infinite-scroll feature on user profile

Closes #1627

There's also code specific to user profiles in the feature and a mention in the readme.


Add 'Check for blocked websites' warning to first meeting prep call

Closes #663.

@zachlatta Ready to merge :) Sorry this took so long.

Incredible. Merged!


Allow time-varying UnempPrb

construct_lognormal_income_process_unemployment in ConsIndShockModel.py currently only accepts constant unemployment probabilities which can be different while working and while retired, UnempPrb and UnempPrbRet.
This setup does not allow one to implement, for instance:

Age-specific unemployment probabilities while working (I think it is the case that unemployment is much higher for young people, at least in my native Colombia).
Age-varying but risk-free retirement income: most papers assume that retirement income is constant, but there are exceptions. Cagetti (2003), for instance, has a downward trend in retirement income that is still safe. A way to achieve this in HARK is to ignore the built-in retirement functionality, choose the appropriate PermGroFac sequence and make PermShkStd = TranShkStd = 0 after some age. The issue is that one can not shut down unemployment after some age.

Thus, I think a time-varying UnempPrb would be a nice feature to have.

I completely agree. I was just running into a related issue with the Adjust shocks.
I think that rather than having the age-varying nature of these variables be hard coded into the models, it should be pulled out into an age-varying distribution class. I have ticketed this in #1017
I'm not 100% sure that the 'age-varying' use case is the same as the 'time-varying' one here. Can you confirm? It seems that sometimes this time-varying functionality is being handled in separate ways by the simulation and solution code, though it's really a model element.

Hey,
Yes, I do think they are the same use case. I usually interpret the models annually but what I meant was an unemployment probability that can change from period to period (whatever a time period represents).
A time-varying distribution class might be useful for finite-horizon models. A suggestion if you do implement it is for it to have the capacity to produce the time-specific distributions easily, so that they can still be passed to the solvers without passing the whole age-varying distributions.

I do agree that these case-handling bits of code where one might run through agents checking their t_cycle and drawing from different distributions is repeated throughout HARK, so a tool to deal with it would be nice.

Perfect. Let me see if I can get a good PR for this by Thursday.

Now that #1018 is in, this might be easier.

I think HARK already handles this.
On Mon, Jun 3, 2024 at 3:35 PM Sebastian Benthall @.***>
wrote:

Assigned #1015 https://github.com/econ-ark/HARK/issues/1015 to @mnwhite
https://github.com/mnwhite.
—
Reply to this email directly, view it on GitHub
https://github.com/econ-ark/HARK/issues/1015#event-13025997887, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ADKRAFNKN2L3JSRLJDDXO4TZFTAQBAVCNFSM46A2WKX2U5DIOJSWCZC7NNSXTWQAEJEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW4OZRGMYDENJZHE3TQOBX
.
You are receiving this because you were assigned.Message ID:
@.***>


Fix release event and test event parsing with database

Fix release event parsing. Fixes #536
Add tests for parsing events to the requre(=database) testsuite.

recheck

recheck


Console Throwing An Error With Specific Shelter ID

Hello,
I am developing a site for our local animal shelter. The site can be found at
http://www.horseheadscommunityanimalshelter.com/pets.php
The console is throwing the error "Uncaught TypeError: localAPI.pets.reverse is not a function(…)"
This is only happening with the shelter I am trying to incorporate which is ID# NY1346 a new shelter established about a month ago.
If I use another ID from a nearby shelter the API works fine. For example ID# NY441
An example of it working can be viewer here.
http://www.horseheadscommunityanimalshelter.com/test.php
I have logged into the petfinder account for the shelter and verified that the sharing settings for api users is turned on so I am confused as to why it isn't working.
Any help would be greatly appreciated.

Hey, looks like you've found a bug in my code related to Petfinder's terrible data structure.
When only one cat or dog is present, they send data back in a slightly different format that my code is not accounting for. In your first example, there's only one pet listed, so it's breaking the script. I'll try to get this fixed sometime this week.

Fantastic. You are very helpful. I could probably rip the code it apart myself and fix it, however I would take me much longer to learn your code, and I would rather not step on another developers feet. I would like to say your application is impressive. Very good job sir. :-)

I'm not sure if that is entirely the problem though. I have uploaded 3 cats and 5 dogs to petfinder and the console is still throwing errors. However the errors thrown now are different.

So, if you want to take a look at the site now you can see the API in full swing with a beatiful UI layed over top of it... http://www.horseheadscommunityanimalshelter.com/pets.php

WOW... that is truly gorgeous! Really nice work.
I'm going to leave this issue open as there is still an error when there's only one pet and I just frankly haven't had time to look into it. But what you built with this is beautiful!


Updates to ControlPlaneMachineSet validation with CEL

/hold this needs the Kube 1.25 rebase to have landed before it will work
We have these validations already but they are currently maintained as a webhook. In an effort to reduce our code complexity and demonstrate the CEL usage for OpenShift, I've tried to replicate the validations here.
Eg. Today we validate the unions with https://github.com/openshift/cluster-control-plane-machine-set-operator/blob/1fa6ff25480e5eb4221a1f5d059dd7b416381e12/pkg/webhooks/controlplanemachineset/webhooks.go#L511-L570, which is complicated, using CEL would simplify this for us and others who are writing unions.
Q: Can users override this validation and persist objects that don't match the schema? Does this change allow us to delete the webhook code?

+1 on the proposed .testsuite.yaml approach 👍

rendering of failures could use some help, but they failed as expected.

I'll have a think about how to improve the rendering of the errors

lgtm, makes sense to me.
I can not say I like this approach to testing, but there is seems a broad agreement about how it should look.

I'll leave the test failure rendering issues for a separate PR as that will need some time to investigate. I've tested these validations manually and am pretty happy that the integration tests are doing as they should be as well, so I think this is good to merge
/label px-approved
/label docs-approved
/label qe-approved

/hold cancel
Tests mean we don't need to wait for the rebase


Categoricals only stored if autodetect=True when encoding

Describe the bug
The adata.uns["categoricals"] field is only set when autodetect=True during encoding. This is important because we use this field to check an object has been encoded and identify numeric variables for normalization in #162.
To Reproduce
Example with MIMIC-II
adata = ep.dt.mimic_2(encoded=False)
adata = ep.pp.encode(
    adata, encodings={"one_hot_encoding": ["service_unit", "day_icu_intime"]}
)
"categoricals" in adata.uns_keys()

Expected behavior
Either need to make sure this is always set or have another system for identifying numeric variables.
System [please complete the following information]:

OS: MacOS
Language Version: Python 3.8
Virtual environment: conda

Thanks! Putting into urgent 0.1 milestone.

IMO, we should have another way of detecting numerical data in the AnnData object. Setting this property always makes no sense, because when not using autodetect ehrapy already knows the categorical values (those that were passed).

What is a good alternative?  Friday, 21 January 2022, 06:36PM +01:00 from Philipp Ehmele  @.*** :

IMO, we should have another way of detecting numerical data in the AnnData object. Setting this property always makes no sense, because when not using autodetect ehrapy already knows the categorical values (those that were passed).
—
Reply to this email directly,  view it on GitHub , or  unsubscribe .
You are receiving this because you commented. Message ID:  @ github . com>

One thing that comes to my mind would be to just use a heuristic approach:
Something like:
for each variable in var:
    take first x non nan values
    infer dtype of those values
    if numerical:
        add to to result

Other solution: When reading our data, just store all numerical values in a list/set and store it somewhere. Since we currently always transform pandas dataframes to anndata object, this could be easier, since its very easy (in contrast to a numpy array, that is not designed for this) to get the dtype for each column.

Nice.
Option 1. Totally not a fan. Ugly and requires computation. A colleague of mine has a dataset with easily more than 2000 features already.
Option 2. Fine with me.
Option 3. I don't see how this gives us what we want?

Option 3. I don't see how this gives us what we want?

;D. I mean for each column, if there's any NaN value (any non numerical value) it will return true; when it return false all values in the column are numerical; it's that simple.

Option 3. I don't see how this gives us what we want?

;D. I mean for each column, if there's any NaN value (any non numerical value) it will return true; when it return false all values in the column are numerical; it's that simple.

Yeah, but we would have to calculate this every time. Too expensive.
Let's find a solution which is simply stored in .uns

Na its a pretty fast operation. I just want to point out of different ways cause I have the feeling we always tend to just store everything into uns...


uuid:Uuid not implemented for sea_orm::Value

I am trying to use the updated uuid::Uuid 1.1.0 version in a struct with SeaOrm but getting an error because it cannot be converted to  sea_orm::Value
Has anyone else encountered this issue?
the trait bound `sea_orm::Value: std::convert::From<uuid::Uuid>` is not satisfied
the following implementations were found:
  <sea_orm::Value as std::convert::From<&'a [u8]>>
  <sea_orm::Value as std::convert::From<&'a str>>
  <sea_orm::Value as std::convert::From<JsonValue>>
  <sea_orm::Value as std::convert::From<NaiveDate>>
and 25 others
required because of the requirements on the impl of `Into<sea_orm::Value>` for `uuid::Uuid`rustcE0277

The code:
#[derive(
    SimpleObject,
    Serialize,
    Deserialize,
    FromRow,
    Validate,
    Debug,
    DeriveEntityModel, // ---> This throws the compiler error
    Clone,
    PartialEq,
)]
#[graphql(complex)]
#[sea_orm(table_name = "user")]
pub struct Model {
    #[sea_orm(primary_key)]
    pub id: uuid::Uuid,  // --> does not accept this but accepts sqlx::types::Uuid which is incompatible with new `async-graphql` version

    pub created_at: DateTime<Utc>,
}

SOLVED
Cross-posting from hereL https://github.com/async-graphql/async-graphql/issues/937
So, while I was digging to make a PR, I realised that the older uuid had been renamed to uuid08.
So, the solution is to simply add this as a feature in your Cargo.toml. e.g
async-graphql = {version = "4.0.1", features = [
  "apollo_tracing",
  "apollo_persisted_queries",
  "bson",
  "dataloader",
  "chrono",
  "chrono-tz",
  "log",
  "dataloader",
  "tracing",
  "opentelemetry",
  "unblock",
  "url",
  "uuid",
  "uuid08",  // ---> this should solve your problem. and u can switch after ur orm switches
  "string_number",
  "secrecy",
  "decimal",
  "smol_str",
]}

This is relevant for those using async-graphql

Closing this now as resolved


Update renovate config

Updating renovate config to the current state of the world
Before you complete this pull request ...
Look for any open pull requests in the repository with the title "e2e-tests update" and
see if there are recent e2e-tests updates that will be applicable to your change.

/retest

needs rebase

needs rebase

It first need working e2e tests, till that I can rebase indefinitely

FYI the PR pipeline won't work with the merge queue, trying to fix in https://github.com/redhat-appstudio/build-definitions/pull/933


fix: API profile selection

Description
Closes #1742
Fixes current tag in API using old selection system (last_save)
Also adds game_mode tag
Example

Before

After

tested and lgtm


Support multiple kind of resources

Normal /users
By id /users/{id}
Nested /users/{id}/orgs

#31


feat: allow project feature to be filtered by status

Tasks

[x] Place a mobile friendly component on the mapping interface that allows the user to toggle by project status.
[x] Hide and how features based on the active toggle behavior
[x] The filtering always uses a any | or join since projects can't have more than one status
[x] The toggle components should match the project status colors to act as a legend
[x] The filter shows the filtered data for project centroids and project features
[x] Allow the filter to be reset to the default where all feature types are displayed

Known issues

[x] Race condition with setting the initial definition expression
[x] Type errors
[x] switching between centroids and feature isn't implemented yet so testing needs to happen by manually editing the initial layer visibilities.

ugh, this was supposed to be set to auto merge


Refactor Lograge.setup

The method was quite cluttered and needed some love.
This change should help to easier understand what is when setup and make
the code more maintainable.

@benlovell if you have 5 minutes can you give me some feedback?

LGTM :heart_eyes: :shipit:


Add new Flag column

Adds a new flag column for OXCGRT records and moves values in prov_category to prov_measure, updating coding as appropriate.

Checking that this change is OK locally and then we can merge.

Checking that this change is OK locally and then we can merge.

This is now working locally.

This is now working locally.