Won't compile for wasm32-wasi

I'm trying to compile my canister to Wasi (I know this isn't an official target, but I am trying to get this to work and will be polyfilling the methods). Candid won't compile with the following errors. When I switch back to wasm32-unknown-unknown the compiler errors go away. From the errors it looks like this affects 0.8.4 and 0.9.0-beta.3. The Cargo.lock files are identical when switching targets:
error[E0277]: the trait bound `BigUint: From<i64>` is not satisfied
   --> /home/lastmjs/.config/kybra/1.68.2/registry/src/github.com-1ecc6299db9ec823/candid-0.9.0-beta.3/src/types/number.rs:192:42
    |
192 |                 Ok(Nat(BigUint::try_from(v).map_err(|_| {
    |                        ----------------- ^ the trait `From<i64>` is not implemented for `BigUint`
    |                        |
    |                        required by a bound introduced by this call
    |
    = help: the following other types implement trait `From<T>`:
              <BigUint as From<types::number::Nat>>
              <BigUint as From<u128>>
              <BigUint as From<u16>>
              <BigUint as From<u32>>
              <BigUint as From<u64>>
              <BigUint as From<u8>>
              <BigUint as From<usize>>
    = note: required for `i64` to implement `Into<BigUint>`
    = note: required for `BigUint` to implement `TryFrom<i64>`

error[E0277]: the trait bound `BigUint: From<i64>` is not satisfied
   --> /home/lastmjs/.config/kybra/1.68.2/registry/src/github.com-1ecc6299db9ec823/candid-0.9.0-beta.3/src/types/number.rs:192:24
    |
192 |                 Ok(Nat(BigUint::try_from(v).map_err(|_| {
    |                        ^^^^^^^^^^^^^^^^^ the trait `From<i64>` is not implemented for `BigUint`
    |
    = help: the following other types implement trait `From<T>`:
              <BigUint as From<types::number::Nat>>
              <BigUint as From<u128>>
              <BigUint as From<u16>>
              <BigUint as From<u32>>
              <BigUint as From<u64>>
              <BigUint as From<u8>>
              <BigUint as From<usize>>
    = note: required for `i64` to implement `Into<BigUint>`
    = note: required for `BigUint` to implement `TryFrom<i64>`

error[E0277]: the trait bound `BigUint: From<i64>` is not satisfied
   --> /home/lastmjs/.config/kybra/1.68.2/registry/src/github.com-1ecc6299db9ec823/candid-0.8.4/src/types/number.rs:198:42
    |
198 |                 Ok(Nat(BigUint::try_from(v).map_err(|_| {
    |                        ----------------- ^ the trait `From<i64>` is not implemented for `BigUint`
    |                        |
    |                        required by a bound introduced by this call
    |
    = help: the following other types implement trait `From<T>`:
              <BigUint as From<types::number::Nat>>
              <BigUint as From<u128>>
              <BigUint as From<u16>>
              <BigUint as From<u32>>
              <BigUint as From<u64>>
              <BigUint as From<u8>>
              <BigUint as From<usize>>
    = note: required for `i64` to implement `Into<BigUint>`
    = note: required for `BigUint` to implement `TryFrom<i64>`

error[E0277]: the trait bound `BigUint: From<i64>` is not satisfied
   --> /home/lastmjs/.config/kybra/1.68.2/registry/src/github.com-1ecc6299db9ec823/candid-0.8.4/src/types/number.rs:198:24
    |
198 |                 Ok(Nat(BigUint::try_from(v).map_err(|_| {
    |                        ^^^^^^^^^^^^^^^^^ the trait `From<i64>` is not implemented for `BigUint`
    |
    = help: the following other types implement trait `From<T>`:
              <BigUint as From<types::number::Nat>>
              <BigUint as From<u128>>
              <BigUint as From<u16>>
              <BigUint as From<u32>>
              <BigUint as From<u64>>
              <BigUint as From<u8>>
              <BigUint as From<usize>>
    = note: required for `i64` to implement `Into<BigUint>`
    = note: required for `BigUint` to implement `TryFrom<i64>`

error[E0277]: the trait bound `i128: From<BigInt>` is not satisfied
   --> /home/lastmjs/.config/kybra/1.68.2/registry/src/github.com-1ecc6299db9ec823/candid-0.9.0-beta.3/src/de.rs:504:23
    |
504 |                 int.0.try_into().map_err(Error::msg)?
    |                       ^^^^^^^^ the trait `From<BigInt>` is not implemented for `i128`
    |
    = help: the following other types implement trait `From<T>`:
              <i128 as From<NonZeroI128>>
              <i128 as From<bool>>
              <i128 as From<i16>>
              <i128 as From<i32>>
              <i128 as From<i64>>
              <i128 as From<i8>>
              <i128 as From<u16>>
              <i128 as From<u32>>
            and 2 others
    = note: required for `BigInt` to implement `Into<i128>`
    = note: required for `i128` to implement `TryFrom<BigInt>`
    = note: required for `BigInt` to implement `TryInto<i128>`

error[E0277]: the trait bound `i128: From<BigUint>` is not satisfied
   --> /home/lastmjs/.config/kybra/1.68.2/registry/src/github.com-1ecc6299db9ec823/candid-0.9.0-beta.3/src/de.rs:508:23
    |
508 |                 nat.0.try_into().map_err(Error::msg)?
    |                       ^^^^^^^^ the trait `From<BigUint>` is not implemented for `i128`
    |
    = help: the following other types implement trait `From<T>`:
              <i128 as From<NonZeroI128>>
              <i128 as From<bool>>
              <i128 as From<i16>>
              <i128 as From<i32>>
              <i128 as From<i64>>
              <i128 as From<i8>>
              <i128 as From<u16>>
              <i128 as From<u32>>
            and 2 others
    = note: required for `BigUint` to implement `Into<i128>`
    = note: required for `i128` to implement `TryFrom<BigUint>`
    = note: required for `BigUint` to implement `TryInto<i128>`

error[E0277]: the trait bound `u128: From<BigUint>` is not satisfied
   --> /home/lastmjs/.config/kybra/1.68.2/registry/src/github.com-1ecc6299db9ec823/candid-0.9.0-beta.3/src/de.rs:525:33
    |
525 |         let value: u128 = nat.0.try_into().map_err(Error::msg)?;
    |                                 ^^^^^^^^ the trait `From<BigUint>` is not implemented for `u128`
    |
    = help: the following other types implement trait `From<T>`:
              <u128 as From<Ipv6Addr>>
              <u128 as From<NonZeroU128>>
              <u128 as From<bool>>
              <u128 as From<char>>
              <u128 as From<u16>>
              <u128 as From<u32>>
              <u128 as From<u64>>
              <u128 as From<u8>>
    = note: required for `BigUint` to implement `Into<u128>`
    = note: required for `u128` to implement `TryFrom<BigUint>`
    = note: required for `BigUint` to implement `TryInto<u128>`

error[E0277]: the trait bound `i128: From<BigInt>` is not satisfied
   --> /home/lastmjs/.config/kybra/1.68.2/registry/src/github.com-1ecc6299db9ec823/candid-0.8.4/src/de.rs:414:23
    |
414 |                 int.0.try_into().map_err(Error::msg)?
    |                       ^^^^^^^^ the trait `From<BigInt>` is not implemented for `i128`
    |
    = help: the following other types implement trait `From<T>`:
              <i128 as From<NonZeroI128>>
              <i128 as From<bool>>
              <i128 as From<i16>>
              <i128 as From<i32>>
              <i128 as From<i64>>
              <i128 as From<i8>>
              <i128 as From<u16>>
              <i128 as From<u32>>
            and 2 others
    = note: required for `BigInt` to implement `Into<i128>`
    = note: required for `i128` to implement `TryFrom<BigInt>`
    = note: required for `BigInt` to implement `TryInto<i128>`

error[E0277]: the trait bound `i128: From<BigUint>` is not satisfied
   --> /home/lastmjs/.config/kybra/1.68.2/registry/src/github.com-1ecc6299db9ec823/candid-0.8.4/src/de.rs:418:23
    |
418 |                 nat.0.try_into().map_err(Error::msg)?
    |                       ^^^^^^^^ the trait `From<BigUint>` is not implemented for `i128`
    |
    = help: the following other types implement trait `From<T>`:
              <i128 as From<NonZeroI128>>
              <i128 as From<bool>>
              <i128 as From<i16>>
              <i128 as From<i32>>
              <i128 as From<i64>>
              <i128 as From<i8>>
              <i128 as From<u16>>
              <i128 as From<u32>>
            and 2 others
    = note: required for `BigUint` to implement `Into<i128>`
    = note: required for `i128` to implement `TryFrom<BigUint>`
    = note: required for `BigUint` to implement `TryInto<i128>`

error[E0277]: the trait bound `u128: From<BigUint>` is not satisfied
   --> /home/lastmjs/.config/kybra/1.68.2/registry/src/github.com-1ecc6299db9ec823/candid-0.8.4/src/de.rs:432:33
    |
432 |         let value: u128 = nat.0.try_into().map_err(Error::msg)?;
    |                                 ^^^^^^^^ the trait `From<BigUint>` is not implemented for `u128`
    |
    = help: the following other types implement trait `From<T>`:
              <u128 as From<Ipv6Addr>>
              <u128 as From<NonZeroU128>>
              <u128 as From<bool>>
              <u128 as From<char>>
              <u128 as From<u16>>
              <u128 as From<u32>>
              <u128 as From<u64>>
              <u128 as From<u8>>
    = note: required for `BigUint` to implement `Into<u128>`
    = note: required for `u128` to implement `TryFrom<BigUint>`
    = note: required for `BigUint` to implement `TryInto<u128>`

For more information about this error, try `rustc --explain E0277`.
error: could not compile `candid` due to 5 previous errors
warning: build failed, waiting for other jobs to finish...
error: could not compile `candid` due to 5 previous errors

This very simple example will reproduce the issue:
Cargo.toml:
[package]
name = "test"
version = "0.0.0"
edition = "2018"

[dependencies]
candid="0.8.4"

src/main.rs:
fn main() {
    println!("{}", candid::Int::from(0));
}

rustup target add wasm32-wasi
cargo build --target wasm32-wasi

These errors are produced:
   Compiling typenum v1.16.0
   Compiling memchr v2.5.0
   Compiling num-traits v0.2.15
   Compiling serde v1.0.162
   Compiling regex-syntax v0.7.1
   Compiling cfg-if v1.0.0
   Compiling unicode-width v0.1.10
   Compiling typed-arena v2.0.2
   Compiling lazy_static v1.4.0
   Compiling termcolor v1.2.0
   Compiling arrayvec v0.5.2
   Compiling thiserror v1.0.40
   Compiling crc32fast v1.3.2
   Compiling binread v2.2.0
   Compiling num_enum v0.5.11
   Compiling candid v0.8.4
   Compiling anyhow v1.0.71
   Compiling logos v0.12.1
   Compiling aho-corasick v1.0.1
   Compiling pretty v0.10.0
   Compiling codespan-reporting v0.11.1
   Compiling hex v0.4.3
   Compiling leb128 v0.2.5
   Compiling generic-array v0.14.7
   Compiling data-encoding v2.3.3
   Compiling num-integer v0.1.45
   Compiling byteorder v1.4.3
   Compiling block-buffer v0.10.4
   Compiling crypto-common v0.1.6
   Compiling digest v0.10.6
   Compiling sha2 v0.10.6
   Compiling regex v1.8.1
   Compiling lalrpop-util v0.19.12
   Compiling num-bigint v0.4.3
   Compiling serde_bytes v0.11.9
error[E0277]: the trait bound `BigUint: From<i64>` is not satisfied
   --> /home/lastmjs/.cargo/registry/src/github.com-1ecc6299db9ec823/candid-0.8.4/src/types/number.rs:198:42
    |
198 |                 Ok(Nat(BigUint::try_from(v).map_err(|_| {
    |                        ----------------- ^ the trait `From<i64>` is not implemented for `BigUint`
    |                        |
    |                        required by a bound introduced by this call
    |
    = help: the following other types implement trait `From<T>`:
              <BigUint as From<types::number::Nat>>
              <BigUint as From<u128>>
              <BigUint as From<u16>>
              <BigUint as From<u32>>
              <BigUint as From<u64>>
              <BigUint as From<u8>>
              <BigUint as From<usize>>
    = note: required for `i64` to implement `Into<BigUint>`
    = note: required for `BigUint` to implement `TryFrom<i64>`

error[E0277]: the trait bound `BigUint: From<i64>` is not satisfied
   --> /home/lastmjs/.cargo/registry/src/github.com-1ecc6299db9ec823/candid-0.8.4/src/types/number.rs:198:24
    |
198 |                 Ok(Nat(BigUint::try_from(v).map_err(|_| {
    |                        ^^^^^^^^^^^^^^^^^ the trait `From<i64>` is not implemented for `BigUint`
    |
    = help: the following other types implement trait `From<T>`:
              <BigUint as From<types::number::Nat>>
              <BigUint as From<u128>>
              <BigUint as From<u16>>
              <BigUint as From<u32>>
              <BigUint as From<u64>>
              <BigUint as From<u8>>
              <BigUint as From<usize>>
    = note: required for `i64` to implement `Into<BigUint>`
    = note: required for `BigUint` to implement `TryFrom<i64>`

error[E0277]: the trait bound `i128: From<BigInt>` is not satisfied
   --> /home/lastmjs/.cargo/registry/src/github.com-1ecc6299db9ec823/candid-0.8.4/src/de.rs:414:23
    |
414 |                 int.0.try_into().map_err(Error::msg)?
    |                       ^^^^^^^^ the trait `From<BigInt>` is not implemented for `i128`
    |
    = help: the following other types implement trait `From<T>`:
              <i128 as From<NonZeroI128>>
              <i128 as From<bool>>
              <i128 as From<i16>>
              <i128 as From<i32>>
              <i128 as From<i64>>
              <i128 as From<i8>>
              <i128 as From<u16>>
              <i128 as From<u32>>
            and 2 others
    = note: required for `BigInt` to implement `Into<i128>`
    = note: required for `i128` to implement `TryFrom<BigInt>`
    = note: required for `BigInt` to implement `TryInto<i128>`

error[E0277]: the trait bound `i128: From<BigUint>` is not satisfied
   --> /home/lastmjs/.cargo/registry/src/github.com-1ecc6299db9ec823/candid-0.8.4/src/de.rs:418:23
    |
418 |                 nat.0.try_into().map_err(Error::msg)?
    |                       ^^^^^^^^ the trait `From<BigUint>` is not implemented for `i128`
    |
    = help: the following other types implement trait `From<T>`:
              <i128 as From<NonZeroI128>>
              <i128 as From<bool>>
              <i128 as From<i16>>
              <i128 as From<i32>>
              <i128 as From<i64>>
              <i128 as From<i8>>
              <i128 as From<u16>>
              <i128 as From<u32>>
            and 2 others
    = note: required for `BigUint` to implement `Into<i128>`
    = note: required for `i128` to implement `TryFrom<BigUint>`
    = note: required for `BigUint` to implement `TryInto<i128>`

error[E0277]: the trait bound `u128: From<BigUint>` is not satisfied
   --> /home/lastmjs/.cargo/registry/src/github.com-1ecc6299db9ec823/candid-0.8.4/src/de.rs:432:33
    |
432 |         let value: u128 = nat.0.try_into().map_err(Error::msg)?;
    |                                 ^^^^^^^^ the trait `From<BigUint>` is not implemented for `u128`
    |
    = help: the following other types implement trait `From<T>`:
              <u128 as From<Ipv6Addr>>
              <u128 as From<NonZeroU128>>
              <u128 as From<bool>>
              <u128 as From<char>>
              <u128 as From<u16>>
              <u128 as From<u32>>
              <u128 as From<u64>>
              <u128 as From<u8>>
    = note: required for `BigUint` to implement `Into<u128>`
    = note: required for `u128` to implement `TryFrom<BigUint>`
    = note: required for `BigUint` to implement `TryInto<u128>`

For more information about this error, try `rustc --explain E0277`.
error: could not compile `candid` due to 5 previous errors

I've been able to track the problem down to the serde feature on num-bigint: num-bigint = { version = "0.4.3", features = ["serde"] }
If that feature is added into the num-bigint dependency then it won't compile for wasm32-wasi for something like num_bigint::BigUint::try_from(0i64).unwrap()

I have found a temporary workaround by adding the following to the Cargo.toml:
[patch.crates-io]
num-bigint = { git = "https://github.com/rust-num/num-bigint" }


Remove sending error through next

I've just removed sending error to continue with botkit pipeline to handle the raw message. #24

Hello! I am using this middleware in one of my projects, and I've noticed this error appear when my bot posts a message. Any information on whether this fix will be applied?

@jschnurr Any updates on this? In the meantime, I've been monkey-patching around this. @adantoscano you might look at this solution if we can't get your patch merged.
const DialogFlowMiddleWare = require('botkit-middleware-dialogflow')
const { GOOGLE_APPLICATION_CREDENTIALS } = process.env

const dialogflowMiddleware = GOOGLE_APPLICATION_CREDENTIALS
  ? DialogFlowMiddleWare({
      keyFilename: GOOGLE_APPLICATION_CREDENTIALS,
    })
  : DialogFlowMiddleWare()

const middlewareWrapper = controller => (bot, message, next) => {
  const _next = err => {
    if (!err) return next()
    message.error = err
    controller.trigger('pipeline_error', bot, message)
  }
  dialogflowMiddleware.receive(bot, message, _next)
}

module.exports = {
  dialogflowMiddleware: middlewareWrapper,
}

Setup with
controller.middleware.receive.use(dialogflowMiddleware(controller))

Here, we don't fire next() at all. Instead, we allow botkit to intercept and we fire the pipeline_error event - which appears to be borked. I expected botkit to fire pipeline_error or receive_error when calling next(err) from a receive middleware.
Since next() isn't called, and the message is intercepted, your upstream features won't be called. You can trap the triggered pipeline_error with:
  controller.on('pipeline_error', (bot, message) => {
    const { error = {} } = message
    bot.reply(
      message,
      `There was an error processing your request. Please try again later. Error: ${error.toString()}`
    )
  })

Of course, you can inspect the error a give a more meaningful response to the user.  Like trapping the 256 char limit and giving the user a nice message as referenced in #24

Close due proyect discontinued


⚠ PrivateHD has degraded performance

In aa111e8, PrivateHD ($PHD) experienced degraded performance:

HTTP code: 200
Response time: 3078 ms

Resolved: PrivateHD performance has improved in 0af6feb.


Crosplane - Retrospectively add the required role for enabling assuming role in AWS provider

[x] Investigate how this is currently done
[ ] Complete #480
[ ] Find and replace the referenced infrastructure-modules version in all capability sub-folders of aws-account-manifests and update to the new infrastructure-modules version
[ ] Submit PR
[ ] Merge PR

related issues: https://github.com/dfds/backstage/issues/448 and https://github.com/dfds/backstage/issues/477

Moved to blocked. I think I can proceed but I'm awating a sanity check on the implementation and more importantly applying the terraform to a single account to test it in-case there is something I am overlooking or have missed

Blocked until #480 is merged

https://github.com/dfds/aws-account-manifests/pull/24


”HUȘI” is listed in the drop-down menu

Description:
"HUȘI" is listed in the drop-down menu alongside its corresponding county and commune, according to the law.
Precondition:
The website is up an running.

Step 1
Type "HUȘI" in the search bar.

Expected results
The location is listed in the drop-down menu as "Oraș HUȘI, VASLUI (HUȘI)".


Add responsive grid for books plus add animations for hovering text o…

Description
Add responsive grid for books plus add animations for hovering and text-overflow
Checklist

[x] I am making a proper pull request, not spam.
[x] I've checked the issue list before deciding what to submit.

Related Issues or Pull Requests
https://github.com/wasimreja/book-finder/issues/4
Add relevant screenshot or video (if any)
(Add here)

resolve the conflicts and raise the pr in hacktoberfest branch

@wasimreja , removed the conflicts and changed the merge target to hacktoberfest!


updates/upgrades for hauler v1.0.0

code related changes:

Upgraded to docusaurus v3, specifically docusaurus v3.1.1
Upgraded to docusaurus-lunr-search (from docusaurus-search-local) due to docusaurus v3

https://github.com/praveenn77/docusaurus-lunr-search

Modified previous versions of the docs to support breaking changes in docusaurus v3

https://docusaurus.io/blog/preparing-your-site-for-docusaurus-v3

docs related changes:

Updated the docs to support new features and functionalities in hauler v1.0.0
Updated existing pages in the docs based on feedback from users and recent demo
Updated content in existing pages that have been "pending release"

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Preview the updates here... http://<IP_ADDRESS>:3000/hauler-docs

Preview site updated and ready for review!

Looks great!  Just a few suggestions.

Looks great! Just a few suggestions.

Updated and terminated the preview site.


Inproper creation of tags, but still teaches concept.

Challenge Waypoint: Turn an Image into a Link has an issue.
User Agent is: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Ubuntu Chromium/45.0.2454.101 Chrome/45.0.2454.101 Safari/537.36.
Please describe how to reproduce this issue, and include links to screenshots if possible.
 This should be clarified. It passes all tests.

Don't know why you'd want to do that, but I can see how the tests could be written with more specificity.

@SaintPeter It's just me quickly going through the stuff, and I threw that there. It's not important, but it's just there ;P

@SaintPeter  I would improve the test case as follows.
Test --> Check if there exists an a tag that has an img tag with a class smaller-image.
Old Description:
Nest your img element within an a element.
New Description:
Nest the existing img element within an a element.
Would that be sufficient?

@gasperno Sounds great.  Are you set up to test locally?

yes. I just tested it. I will push it in sometime.


Copy properties defaults on node creation

Copies properties defaults into app_data field of nodes on node creation. Fixes elyra-ai/elyra#1785
Developer's Certificate of Origin 1.1
   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

I think this looks okay so far, but I need to spend some more time testing and wrapping my head around this, before approving

@bourdakos1 Just removed the tooltip / validation code that uses current_parameters as default - do you know of any other places that use it?

Just removed the tooltip / validation code that uses current_parameters as default - do you know of any other places that use it?

@marthacryan I think that's it

Codecov Report

Merging #133 (3ec3470) into master (d215120) will increase coverage by 0.61%.
The diff coverage is 30.76%.

:exclamation: Current head 3ec3470 differs from pull request most recent head 4dfb857. Consider uploading reports for the commit 4dfb857 to get more accurate results

@@            Coverage Diff             @@
##           master     #133      +/-   ##
==========================================
+ Coverage   78.73%   79.34%   +0.61%
==========================================
  Files          40       40
  Lines        1331     1322       -9
  Branches      309      305       -4
==========================================
+ Hits         1048     1049       +1
+ Misses        220      210      -10
  Partials       63       63

Impacted Files
Coverage Δ

...kages/pipeline-editor/src/PipelineEditor/index.tsx
44.61% <0.00%> (+2.17%)
:arrow_up:

packages/pipeline-services/src/validation/index.ts
97.61% <0.00%> (+2.16%)
:arrow_up:

...es/pipeline-editor/src/PipelineController/index.ts
96.36% <44.44%> (-0.55%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d215120...4dfb857. Read the comment docs.


[BUG\Feature] ReflectionClass::getDocComment

Example:
/**
 * Class Some
 * @Some("Test")
 */
class Some
{
}

echo (new ReflectionClass(Some::class))->getDocComment();

jphp: 0.6.11

Class Some
@Some("Test")

php: 5.6 x86 TS
/**
 * Class Some
 * @Some("Test")
 */

Propose: Save currently behavior, but;

Move \ReflectionSome classes to php\reflection\ReflectionSome
Add class ReflectionSome extends \php\reflection\ReflectionSome {} inside Zend Extension and override required methods behavior.

:+1: Good idea =)

Ok. I can to do this.


APP-143 - Android sample "Notification"  ONLY code

http://jira.kaaproject.org/browse/APP-143

@kaa-leeroy test this please

@kaa-leeroy test this please

@kaa-leeroy test this please

Can one of the admins verify this patch?

@kaa-leeroy test this please


Support for using {{ values }} within values.yaml

For example:
values.yaml
myApp:
  fooServiceName: {{ .Release.Name }}-foo-service

It seems like it would be a common pattern to incorporate {{ .Chart.Name }} or {{ .Release.Name }} into some variables.  I got the following when I tried this:
error converting YAML to JSON: yaml: line 15: did not find expected key

Edit
To better illustrate my issue, consider a Chart with the following structure:
serviceA Chart directory structure:
charts/
    serviceB/
        templates/
            serviceB.yaml
        Chart.yaml
templates/
    serviceA.yaml
Chart.yaml
<etc...>

serviceB.yaml

apiVersion: apps/v1beta1
kind: Deployment
metadata:
  name: {{ .Release.Name }}-service-b
spec:
  <...spec...>

Now, currently if I want serviceA to make calls to serviceB, I would have to do something like this:
serviceA.yaml

apiVersion: apps/v1beta1
kind: Deployment
metadata:
  name: {{ .Release.Name }}-service-a
spec:
  containers:
    - env:
        - name: SERVICE_B_HOSTNAME
          value: {{ .Release.Name }}-{{ .Values.serviceB }}

values.yaml

serviceB: service-b

When I'd like to be able to do something like this:
serviceA.yaml

apiVersion: apps/v1beta1
kind: Deployment
metadata:
  name: {{ .Release.Name }}-service-a
spec:
  containers:
    - env:
        - name: SERVICE_B_HOSTNAME
          value: {{ .Values.serviceB }}

values.yaml

serviceB: {{ .Release.Name }}-service-b

We have talked about supporting these as environment variables (e.g. $RELEASE_NAME, $CHART_NAME, etc).
However, the file that is passed into the template engine as a source of data for templates is itself not passed through the template engine. We almost definitely will not do that because it gets very confusing for users. It also breaks both standard YAML compatibility and backward compatibility with all existing Helm versions.

@DrEsteban Did you have anything else you wanted to discuss or anything that @technosophos didn't address? If not, we are going to close this

@thomastaylor312 Apologies, yes one more question.
@technosophos Makes sense, thanks for the reasoning. As for the "environment variables support", do you mean automatically including $RELEASE_NAME or $CHART_NAME in the list of environment variables for a pod? Or something else? I'm just trying to determine how it relates to this issue of being able to specify values-within-values.
To better illustrate my issue, consider a Chart with the following structure:
serviceA Chart directory structure:
charts/
    serviceB/
        templates/
            serviceB.yaml
        Chart.yaml
templates/
    serviceA.yaml
Chart.yaml
<etc...>

serviceB.yaml

apiVersion: apps/v1beta1
kind: Deployment
metadata:
  name: {{ .Release.Name }}-service-b
spec:
  <...spec...>

Now, currently if I want serviceA to make calls to serviceB, I would have to do something like this:
serviceA.yaml

apiVersion: apps/v1beta1
kind: Deployment
metadata:
  name: {{ .Release.Name }}-service-a
spec:
  containers:
    - env:
        - name: SERVICE_B_HOSTNAME
          value: {{ .Release.Name }}-{{ .Values.serviceB }}

values.yaml

serviceB: service-b

When I'd like to be able to do something like this:
serviceA.yaml

apiVersion: apps/v1beta1
kind: Deployment
metadata:
  name: {{ .Release.Name }}-service-a
spec:
  containers:
    - env:
        - name: SERVICE_B_HOSTNAME
          value: {{ .Values.serviceB }}

values.yaml

serviceB: {{ .Release.Name }}-service-b

It means the templates of parent charts must adhere to/adopt the naming conventions of child charts, rather than allowing the parent templates to be independent of child naming conventions, and allowing Values.yaml to configure the entirety.  If I decide to deploy serviceB separately from serviceA, I must edit the actual serviceA.yaml template to remove the {{ .Release.Name }} section instead of simply editing the values passed in.
Would the proposed "environment variables support" do anything to help with that?

@thomastaylor312 Apologies, yes one more question.
@technosophos Makes sense, thanks for the reasoning. As for the "environment variables support", do you mean automatically including those in the list of environment variables for a pod? Or something else? I'm just trying to determine how it relates to

Oops, clicked the wrong button...

Sharing variables between parent and child is bad enough,  but it gets worse when you have a dependency tree with children that need to share variables between them as peers.
e.g. for gitlab-bundle, I want a values.yaml something like":
baseDomain: your-domain.com
gitlab:
  ingress:
    hosts:
      - gitlab.{{ .Values.baseDomain }}
      - registry.{{ .Values.baseDomain }}
      - mattermost.{{ .Values.baseDomain }}
      - prometheus.{{ .Values.baseDomain }}
gitlab-runner:
  gitlabUrl: http://gitlab.{{ .Values.baseDomain }}

I hit this problem trying to configure a default prometheus datasource for grafana using the charts under "stable".  Grafana expects a url to the service, but I have no way of providing a release name prefix to the service name in the values yaml.

@dsanders1234 I have exactly the same problem.
In fact, this is a problem any time you try to build a meta-package with packages from other repositories as requirements, as they tend to use {{ .Release.Name }} in their service names. This means you can't automatically configure the linkages.
It would be really nice to at least be able to access the release name and namespace in values.yaml. Without it, building meta-packages is pretty much impossible...

I have similar issues as well.  I am trying to pass in a k8s dns for cassandra child package which is dependent on {{ .Release.Name }} and {{ .Release.Namespace }}.

We are also having this issue to create "fully qualified" names for subcharts that are known to the parent and child.  We can workaround this by (re)creating all the charts ourselves, but this defeats the purpose of packaged and shared charts.

This issue is also affecting me in a similar manner to those above. I am trying to create a meta-package and need to pass a base host name to all subcharts to use to define their Ingress resources. Looks like I will have to rewrite all the charts I want to use myself.

Also affecting me. I am having nginx-ingress as a dependency for one of my charts and I want to set up tcp forwarding, but the nginx-ingress require to know the service name upfront which I am not able to provide in values.yaml.

We actually hit the same limitation and ended up implementing our own layer around Helm to glue services together. You can traverse the entire service tree by using {{ .Discovery }} variable and get access to dependent & peer services' data.
If you want to take a look, here is an example that brings up multiple instances kafka, spark, hdfs, zookeeper and twitter-based analytics around them. All from Helm charts:

here is how "serviceA" can expose a variable:
https://github.com/Aptomi/aptomi/blob/master/examples/twitter-analytics/policy/Frank/kafka.yaml#L17

here is how "serviceB" can rely on a variable exposed by "serviceA":
https://github.com/Aptomi/aptomi/blob/master/examples/twitter-analytics/policy/John/twitter_stats.yaml#L38

demo:
https://asciinema.org/a/k8ZpQTazoSaDV24fiLbG7DfT9?speed=2

I think this is the same as: https://github.com/kubernetes/helm/issues/2492 and it looks like there is a pr mentioned over there: https://github.com/kubernetes/helm/pull/3252

closing as a duplicate of #2492.

Interesting that my issue, filed several months earlier, was the "duplicate" ;)  I understand... #2492 is a lot better described.

@markpundsack Did you ever get a solution for https://github.com/helm/helm/issues/2133#issuecomment-301581084 ? I'm sorry to resurrect this issue, but it's exactly the problem I have and I can't find a solution in this thread or https://github.com/helm/helm/issues/2492

@cep21 I never found a solution that worked well.

:) Thankfully, latest Helm manual says how to achieve this.
https://helm.sh/docs/howto/charts_tips_and_tricks/#using-the-tpl-function
The trick is enclosing variable in " or in yaml block |-, and than referencing it in a template as {{ tpl .Values.variable . }}
This seems to make Helm happy.
Example:
$ cat Chart.yaml | grep appVersion
appVersion: 0.0.1-SNAPSHOT-d2e2f42

$ cat platform/shared/t/values.yaml | grep -A2 image:
image:
  tag: |-
    {{ .Chart.AppVersion }}

$ cat templates/deployment.yaml | grep image:
          image: "{{ .Values.image.repository }}:{{ tpl .Values.image.tag . }}"

$ helm template . --values platform/shared/t/values.betradar.yaml | grep image
          image: "docker-registry.default.svc:5000/namespace/service:0.0.1-SNAPSHOT-d2e2f42"
          imagePullPolicy: Always
      image: busybox

Otherwise there is an error thrown..
$ cat platform/shared/t/values.yaml | grep -A1 image:
image:
  tag: {{ .Chart.AppVersion }}

1 $ helm template . --values platform/shared/t/values.yaml | grep image
Error: failed to parse platform/shared/t/values.yaml: error converting YAML to JSON: yaml: invalid map key: map[interface {}]interface {}{".Chart.AppVersion":interface {}(nil)}

@MilanMasek 's solution won't work in general for subcharts, because the context . passed into tpl will have the subchart's values, not the parent chart's values.
It happens to work in the specific example this ticket was opened for, because .Release.Name should be the same in all the subcharts. It won't work for .Chart.AppVersion as in the tpl example.
There was a proposal to support tval in #3252 for interpolating templates in values files, but that was dropped in favour of a lua-based Hook system which has been proposed for Helm v3: https://github.com/helm/helm/issues/2492#issuecomment-413635332

See also #2514.
:) Thankfully, latest Helm manual says how to achieve this.
https://helm.sh/docs/howto/charts_tips_and_tricks/#using-the-tpl-function
The trick is enclosing variable in " or in a yaml block |-, and than referencing it in a template as {{ tpl .Values.variable . }}
This seems to make Helm happy.
Example:
$ cat Chart.yaml | grep appVersion
appVersion: 0.0.1-SNAPSHOT-d2e2f42

$ cat platform/shared/t/values.yaml | grep -A2 image:
image:
  tag: |-
    {{ .Chart.AppVersion }}

$ cat templates/deployment.yaml | grep image:
          image: "{{ .Values.image.repository }}:{{ tpl .Values.image.tag . }}"

$ helm template . --values platform/shared/t/values.betradar.yaml | grep image
          image: "docker-registry.default.svc:5000/namespace/service:0.0.1-SNAPSHOT-d2e2f42"
          imagePullPolicy: Always
      image: busybox

Otherwise there is an error thrown..
$ cat platform/shared/t/values.yaml | grep -A1 image:
image:
  tag: {{ .Chart.AppVersion }}

1 $ helm template . --values platform/shared/t/values.yaml | grep image
Error: failed to parse platform/shared/t/values.yaml: error converting YAML to JSON: yaml: invalid map key: map[interface {}]interface {}{".Chart.AppVersion":interface {}(nil)}

Thanks @MilanMasek that quote save my hours.

For people still tracking this request, the current way forward appears to be #6876, which is apparently under review.

There's also #8580 which is a similar approach to the problem as #6876. See #8576 for some discussion on the differences.

I was facing the same issue i.e. passing a value set by user using --set to subchart. This came to my rescue:
helm install --set subchartname.subchartkey=myvalue

See also #2514.
:) Thankfully, latest Helm manual says how to achieve this. https://helm.sh/docs/howto/charts_tips_and_tricks/#using-the-tpl-function
The trick is enclosing variable in " or in a yaml block |-, and than referencing it in a template as {{ tpl .Values.variable . }} This seems to make Helm happy.
Example:
$ cat Chart.yaml | grep appVersion
appVersion: 0.0.1-SNAPSHOT-d2e2f42

$ cat platform/shared/t/values.yaml | grep -A2 image:
image:
  tag: |-
    {{ .Chart.AppVersion }}

$ cat templates/deployment.yaml | grep image:
          image: "{{ .Values.image.repository }}:{{ tpl .Values.image.tag . }}"

$ helm template . --values platform/shared/t/values.betradar.yaml | grep image
          image: "docker-registry.default.svc:5000/namespace/service:0.0.1-SNAPSHOT-d2e2f42"
          imagePullPolicy: Always
      image: busybox

Otherwise there is an error thrown..
$ cat platform/shared/t/values.yaml | grep -A1 image:
image:
  tag: {{ .Chart.AppVersion }}

1 $ helm template . --values platform/shared/t/values.yaml | grep image
Error: failed to parse platform/shared/t/values.yaml: error converting YAML to JSON: yaml: invalid map key: map[interface {}]interface {}{".Chart.AppVersion":interface {}(nil)}

Can you do that with third party charts? I would assume this requires said third party to call tpl on the value you are using template syntax with, which is unlikely. If I am in control of the chart myself. Id probably had a number of other fixes.

Yes, that depends on the third party chart to be calling tpl on various values it receives. I've noticed for example that the Bitnami charts are quite liberal in doing that, I guess partly because they are built using a lot of templates anyway.
So if you find a third-party chart that doesn't call tpl on a value you need it to call tpl on, perhaps open it with them as a feature request.

I submitted a plugin to override values.yaml with additional templates.
helm-viv
example

This won't work however when you try to pass value down to children charts https://github.com/helm/helm/issues/2133#issuecomment-1040766731

ChatGPT tells me it doesn't work

any suggestion how we can handle "{{ .Values.images.abc-load-test }}"  hyphen(-). it's failing.

You'll have to use something like {{ get $Values.images "abc-load-test" }}. If you get more complicated, e.g., the hyphenated-key is a dictionary too, you can use {{ $Values | dig "images" "abc-load-test" "subkey" }} to make things more readable than nested gets.

i am little confused here, can you give me some examples if possible? Thanks

I'd suggest opening a new ticket if you need further help, since this is a closed ticket and not actually related to your question. In that ticket, you can post more details of what you're trying to do, including an example of what isn't working, and you should be able to get more-detailed help.


You may have taken more than 60 seconds to complete the OAuth process and need to start over

Issue summary
I want to install a manual proxy app in my Shopify website.
The Shopify app is created in my Shopify Partner account.
I have configured the allowed redirection URL api/auth, api/auth/callback and api/webhooks.
My credentials are set in my PHP application.
I'm able to generate the link to install the Shopify app, select my website and accessing the admin to install the app.
When I click on the install app, I have the error You may have taken more than 60 seconds to complete the OAuth process and need to start over.
I started investigated and I realized that on the \vendor\shopify\shopify-api\src\Auth\OAuth.php file (line 332), $expectedSignature is generated is not the same that $signature.
But I don't know why.
The process stop here and I don't have my token set so I can't use my application even if it say install on Shopify.
Expected behavior
When I click on the Install app button, my app should be installed without any error and my token generated.
Actual behavior
What actually happens?
I have the error You may have taken more than 60 seconds to complete the OAuth process and need to start over.

The signature I got from the cookie
eyJpdiI6ImpGZzNIZGZvc2kxSVI2TjJ5RUhqY1E9PSIsInZhbHVlIjoiRGlJb3NwZzJNSjhmdHRzY2NEMTVJQ0xKU2htbHFUdzMyYnZRcnVndS9zemgzV2hpVDlBYnZYVnVJNVdFcFhvSVE5aXVhQTJDMVBpN2x4Y3UyVGw4bE8xSHc2bHpMSEU3QTBQWE1sd1VGRi9KZUpESmQ3ZjhRc0ZNRkZNZEVxZ1hURURFMmZwVEwzeW9VUGRKd0tyakpRPT0iLCJtYWMiOiJmYWFiNzYzNGI0NmI4YTQzZDhhMTM2YjY1MmZmMmMwYjA5MzdmY2EyOTcwOWQyODE2NDdjNjQxMjk0NmUxZmVmIiwidGFnIjoiIn0=
The expected signature
8ae2cce0787b6ecd40d58c36595aa9236b8242e26f595530f6289d663c62f61f


Update checkmarx-ast-cli binaries with 2.2.7

Updates checkmarx-ast-cli to 2.2.7
Auto-generated by [create-pull-request][2]

Checkmarx One – Scan Summary & Details – cd17ae9f-0a1d-4fa5-912d-22b8989b3921
No New Or Fixed Issues Found


Project > Filter > Blank screen displayed when applying "In development" and "Low" filters

Describe the bug
Project > Filter > Blank screen displayed when applying In development and Low filters.
Steps to Reproduce

Login
Click on the projects menu and Click on filter option button
Apply  In development and Low filter and select Apply Filter button
Direct hit the Submit button without editing any detail

Expected Result
Project results should be displayed according to applied filters.
Actual Result
Blank screen displayed when applying In development and Low filters.
See video-  https://drive.google.com/file/d/1KUQQZNqylrMZAtsm25XAE8Lt4nVdhCri/view?usp=sharing
cord-field# b1ebad03

Duplicate of #488


F1 Visa Experiences

Pull Request for ML-Crate 💡
Issue Title:  F1 Visa Experiences

Info about the related issue (Aim of the project) : Finding out if the review is positive, negative or neutral.
Name: Churnika S Mundas
GitHub ID: (https://github.com/stackaway)
Idenitfy yourself: JWOC 2024 Contributor

Closes: #128
Describe the add-ons or changes you've made 📃
We analyse the data, preprocess and visualize the features. We then investigated two predictive models. The data was split into two parts, a train set and a test set.
We started with Logistic Regression, Random Forest Classifier and SVM and SVM had the highest accuracy followed by Random Forest Classifier.
What sort of change have you made:

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Code style update (formatting, local variables)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested? ⚙
Logistic Regression, Random Forest Classifier and SVM and SVM had the highest accuracy followed by Random Forest Classifier.
Checklist: ☑

[X] My code follows the guidelines of this project.
[X] I have performed a self-review of my own code.
[X] I have commented my code, particularly wherever it was hard to understand.
[X] I have made corresponding changes to the documentation.
[X] My changes generate no new warnings.
[X] I have added things that prove my fix is effective or that my feature works.
[X] Any dependent changes have been merged and published in downstream modules.

I have updated the README file

Hi @stackaway can you please share your email ID for further communication.

Hi @stackaway can you please share your email ID for further communication.

<EMAIL_ADDRESS>


Analysis Page

Created a page with a text input form, to analyze datasets from a Kaggle command or url.
The page is not pragmatically functioning, it needs further developments and installation to link the HTML form to the bias auditor app.
Link to the deployed version: https://datasetbucket.herokuapp.com/analyse_data

Page created, but not programmatically.
Needs function to connect the analysis tool
@sakshigupta265 @eliboss @wyang0216

The branch, connect_front_back, connects the page to the analysis tool.
Added error message to analyse.html page when a report can not be generated.
Connected runTerminalCommands.py to app.py so that when a URL is submitted on analyse.html, it is grabbed by app.py and sent to runTerminalCommands.py and downloaded and analyzed. If a report is generated, it is downloaded as a pdf in the user's browser.


Feature request: Option to always minimize to tray instead of closing the program

It would be a very useful QOL feature to add, the "Minimize to Tray" button is too close to the exit button, the users could click the wrong button and because visually both buttons do the same, users may think the program is still running in the background but in reality they closed the program.
You can add an "Always minimize to tray" option and an "Exit app" option to the settings so the users can control the behavior of the program

Hello o/
I cannot help users fat-fingering wrong buttons. The "Minimize to Tray" button placement is intentional, and this is to discourage accidental closing of the miner via :x:, and instead minimize it to tray where it can still run. I see no point for an additional option that literally does the same thing - just click on the other button. Simple.


[WIP] zulip: Make background light grey.

This is a WIP series of commits to make the background in Zulip light grey to distinguish components from each other on the otherwise white background.

Closing, since we're working on a similar design direction with newer PRs these days.


Replace matrix generator with PowerShell script

To make better use of native capabilities for handling object creation and conversion to JSON, this PR replaces the Bash based matrix generator with a PowerShell equivalent.

/azp run unit

/azp run unit

/azp run e2e

/azp run unit

/azp run e2e


Feat/transaction routes logic

What ❔
Logic to filter /transactions endpoints.
Why ❔
Transaction discovery is not open in the context of double zero. Users can only discover transactions sent or received by them. If someone already has a tx id that transaction can always be reached.
Checklist

[ ] PR title corresponds to the body of PR (we generate changelog entries from PRs).
[ ] Tests for the changes have been added / updated.
[ ] Documentation comments have been added / updated.

LGTM!


psutil host level is not supported macos

at the begining, i want to run cargo test on macos. unfortunately i saw the error about psutil.
so i looked through the documentation and found that it was not supported.

I didn't consider the multi-platform portability since it is still at the very beginning of sentinel-rs development. The tests are carried on Ubuntu 18.04 with rustc 1.53.0.
In fact, not only psutil, it would be better to remove other dependencies if possible. Currently, it depends on plenty of crates. The PRs are always welcomed if someone is experienced in these jobs.

The psutil is not maintained actively, one of its dependency is deprecated in crates.io, the tracing is now migrated to another crate named sysinfo. It supports following OSs:

Android
iOS
Linux
macOS
Raspberry Pi
Windows

Personally, I only focus on the tests on Linux now. I'm not sure whether sysinfo does work on other OSs or not.

Does it work well under container env?

Yep, it works. I forget this... I will add git actions scripts for other OS environments soon :)

All the unit tests passed on platforms including Ubuntu 20.04, macOS Catalina 10.15 and Windows Server 2019, which are also the default environments in GitHub-hosted runners.


Values not present in "Time series" after "Save with hourly results"

Is it possible to have the values saved via "Save with hourly results" present in the "Time series" pane like they are in "Data tables"? And, potentially, have the same plots showing at the prior close?

This would be very helpful for some of our slower (CSP) models.

User request for this feature: https://sam.nrel.gov/forum/forum-general/4294


Added keyboard shortcut to edit the last message

Fixes #1147

Automated message from Dropbox CLA bot
@TigorC, it looks like you've already signed the Dropbox CLA. Thanks!

@timabbott thanks for comments, Casper test added

@TigorC I posted a few comments on the details, otherwise this looks good!  Also you need to rebase and resolve some merge conflicts.

Merged as 55cffa1e69879e6aab26a4500224820c46ed7c40, thanks @TigorC!  I think a lot of folks will enjoy this feature :).


Write a Julia program to convert hours to minutes

Description
Write a Julia program to convert hours to minutes
1 hour = 60 minutes
Input  : 5
Output : 300

How to contribute

Save the solution in program/convert-hours-to-minutes.jl file
Add convert-hours-to-minutes.jl file in convert-hours-to-minutes folder

!assign


Tooltip hover time of 300ms needs to be raised higher

Does this issue occur when all extensions are disabled?: No
The issue happens when Pylance and Python Intellisense are active. But since the problem can be mitigated by setting the tooltip hover to 1 second in VS Code, this is not an issue that needs to be reported to Pylance. This is something that needs to be fixed in VS Code.

VS Code Version: 1.78.2
OS Version: Mint OS 21

Steps to Reproduce:

Install Pylance extension.
Open up some Python code and hover the mouse pointer on any of the functions or classes.
In 300ms, a tooltip hint is shown. When developers navigate code, this tooltip hint box frequently obstructs the view.

Impact of this problem:
The upvotes in this StackOverflow question shows  how many people found the tooltips annoying. I've used VS Code for around 5 years already, and even though I found the tooltips annoying, I only thought of searching for a setting to disable it, today. So you could extrapolate, to figure out how many more people would be annoyed by the tooltip obstructing the code, and they don't know that there might be an option to disable it.
The solutions:

Increase the default delay from 300ms to 1 second or more. An Interaction Designer could help you decide which is the best delay to select for tooltips across the editor.
Provide an option to disable code hover tooltips, which is easy to find in the settings.

ps: It would be good if VS Code maintainers occasionally go through StackOverflow and Reddit or similar sites to see what kind of questions people are asking about VS Code, so that you can improve the IDE, instead of waiting for someone to create an issue on GitHub. Being proactive.

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.79.2. Please try upgrading to the latest version and checking whether this issue remains.
Happy Coding!

"Provide an option to disable code hover tooltips, which is easy to find in the settings."
So you do know about the setting Editor > Hover: Enabled or not?

Thank you Arturo, but there are few things to consider:

This is not about me. As I've mentioned in the first post, there are a lot of others facing this issue.
I didn't know about the Hover: Enabled setting, but I don't want to disable hover. I need the hover functionality. It's just the 300ms that makes it extremely annoying, since when I'm navigating code, the tooltips appear too quickly, blocking my view of the code.
These are things an Interaction Designer would understand. Hence my recommendation to allow an Interaction Designer to evaluate the various aspects of VS Code (because there are other annoying things too, like how the terminal pane is not foldable like how it is in Netbeans).
The main point is, that the 300ms should not be a default. Not everyone knows or realizes that they can go to settings to change the setting.

/duplicate https://github.com/microsoft/vscode/issues/123851

ps: It would be good if VS Code maintainers occasionally go through StackOverflow and Reddit or similar sites to see what kind of questions people are asking about VS Code, so that you can improve the IDE, instead of waiting for someone to create an issue on GitHub. Being proactive.

FWIW we do sometimes, but we have our hands more than full trying to triage and action the incoming GH issues.

@Tyriar I understand. However, I'd like to know if the change to a higher value of wait time was made or did you close this issue just because it was a duplicate of 123851? Even issue 123851 was closed without being resolved.

https://github.com/microsoft/vscode/issues/123851 is not closed


308 automatic generation of python binding code

Merge Request - GuideLine Checklist
Guideline to check code before resolve WIP and approval, respectively.
As many checkboxes as possible should be ticked.
Checks by code author:

[ ] There is at least one issue associated with the pull request.
[ ] The branch follows the naming conventions as defined in the git workflow.
[ ] New code adheres with the coding guidelines
[ ] Tests for new functionality has been added
[ ] A local test was succesful
[ ] There is appropriate documentation of your work. (use doxygen style comments)
[ ] If new third party software is used, did you pay attention to its license? Please remember to add it to the wiki after successful merging.
[ ] If new mathematical methods or epidemiological terms are used, has the glossary been updated ? Did you provide further documentation ?
is present or referenced. Please provide your references.
[ ] The following questions are addressed in the documentation*:  Developers (what did you do?, how can it be maintained?), For users (how to use your work?), For admins (how to install and configure your work?)
For documentation: Please write or update the Readme in the current working directory!

Checks by code reviewer(s):

[ ] Is the code clean of development artifacts e.g., unnecessary comments, prints, ...
[ ] The ticket goals for each associated issue are reached or problems are clearly addressed (i.e., a new issue was introduced).
[ ] There are appropriate unit tests and they pass.
[ ] The git history is clean and linearized for the merge request.
[ ] Coverage report for new code is acceptable.

Closes #308

What's the status @MaxBetzDLR ? It is still draft. And who should it review when?

What's the status @MaxBetzDLR ? It is still draft. And who should it review when?

Im still working on the bug happening during the test. Thus, i dont exactly know when its ready for review. Do you have anyone in mind as reviewer @mknaranja?

@dabele do you have any time? Otherwise I think I'll have to do this

Codecov Report
Base: 90.10% // Head: 90.10% // No change to project coverage :thumbsup:

Coverage data is based on head (45e9456) compared to base (fa6372c).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #333   +/-   ##
=======================================
  Coverage   90.10%   90.10%
=======================================
  Files          91       91
  Lines        6944     6944
=======================================
  Hits         6257     6257
  Misses        687      687

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Support forcing a different HTTP method for all payloads except httpmethods

Hi, thanks for publishing this tool!
This is a small change to support HTTP endpoints that should be queried with another HTTP method.

Hey!
Thanks for the PR, it's a nice feature.


Bug 1562368 - Update bugherder dependencies

@Archaeopteryx I think this should just work, but I haven't tested actually going through with the bugzilla submissions. The updates are only to the packages that serve the website and run the tests, and the website is still at least served correctly, as far as I can tell. Might be worth running this locally for marking a merge before landing it?

Extending it to https://github.com/Archaeopteryx/bugherder/commit/9623458b7411a2864e4e8828ed0784cb7af7f40e makes the CI run green again.


Feature Request: Icons based on file extension

I would suggest using icons like telescope.nvim using devicons.

Hi! It makes sense. I would suggest opening a PR 🙂


Location history not available

Hi,
Thanks for this , works like a charm, there's only one thing I'm missing.
I can view location of the vehicle without any problem, however, I'm not able to see any history of the location and als no logbook entries of the past.
Any idea what can be the cause of this ?

You mean the HomeAssistant logbook ?

Kind of, when I click on the "location" of the car i get below...
As you can see, location is there but no history and no log of past locations.
I'm not sure if this is a "HA" thing or not, but I can see an track history of iphones for example (like my kids)

For me, this works very well. I can't reproduce this issue, sorry!
Try to delete the whole mqtt device and restart the volvo2mqtt addon.

Works for me to. Did a restart work?


BZ1320357 - [GSS] (6.2.z) Default Tasks List filters doesn't keep up …

…with user's roles changes

+1 thanks @nmirasch

@nmirasch this PR now has conflicts, please verify.

@cristianonicolai  done. Thanks!

Thanks @nmirasch
e9928f386e3a6266f38918e57a5f08d86c7a0c0b


Remove field validation from serialize_embed

This validation only checks fields and not all the other possibilities that Discord will complain about. It is best to just leave it to Discord to decide whether to error or not.

You won't get an error response from discord in the interaction server flow

You won't get an error response from discord in the interaction server flow, could move this logic to the response builders instead maybe?

I personally dislike builders a tiny bit because, for other languages it would be great, but for python it just adds overhead, so I really don't know.
Maybe it could be added there but, and I havent played around with an interaction server yet so idk, if Discord don't reply with error codes, handing this one specific case for embeds and not all the other things Discord could raise I as a bit unnecessary. We might as well not handle anything and skip all these checks all the time.

I personally dislike builders a tiny bit because, for other languages it would be great, but for python it just adds overhead, so I really don't know.

Adds overhead compared to what?

Maybe it could be added there but, and I havent played around with an interaction server yet so idk, if Discord don't reply with error codes, handing this one specific case for embeds and not all the other things Discord could raise I as a bit unnecessary. We might as well not handle anything and skip all these checks all the time, as it would be more in-line with the rest of the lib, don't you think?

It being more inline with the rest of the lib would be bad ux there; the plan has always been to add some level of validation to the server response builders as you don't get a response to your initial response and therefore will get no info/feedback on why it failed (just this is really low priority).

Adds overhead compared to what?

Sorry, wrote that as I woke up and idk what I was thinking. Embed is basically a builder anyways, so yea, the validation could be moved there

It being more inline with the rest of the lib would be bad ux there; the plan has always been to add some level of validation to the server response builders as you don't get a response to your initial response and therefore will get no info/feedback on why it failed (just this is really low priority).

Yea, there it would make sense there. My bad


Add full_name to ConstantPathNode and ConstantPathTargetNode

Add full_name to both ConstantPathNode and ConstantPathTargetNode, so that one can easily figure out the complete name of the constant being referenced.
This implementation is very odd given the template approach, but I wasn't sure if we already have a standard for adding methods to specific nodes only. Please, let me know if we do and I can switch the implementation.

Ahh yeah these methods should go in node_ext.rb


CI service guide

As discussed here is the PR that covers instructions and template config files for CI services. I'll just leave Travis there along with Circle so people have options and can choose themselves.
I've also edited the header structure on the readme a bit to flow a little better. CI stuff is at the bottom.

Cool, I see why you wanted to have both - so lets keep both? I enabled travis and circle. Add badges to README?

added the badges and currently waiting patiently for Travis' status.
The badges will currently not show passing because they are targeting master so we can fix that by pushing some dummy commit when the PR is merged.
As for including both ye like I said, options are great imo.

There we go. Travis and CircleCI are passing. Had a few issues in the config before. It's now ready for a merge, I'll leave that for you.

Merged, thank you!


App icons and Launch Screen

Description
Insert app icons in various sizes and add launch screen image.
Trello card: https://trello.com/c/UbNWZn3F/138-launch-screen
Type of change

[x] New feature (non-breaking change which adds functionality)

Change Status

[x] Complete, tested, ready to review and merge

How Has This Been Tested?

[x] Manually tested with simulator (iPhone 8)

Checklist

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] There are no merge conflicts

 Launch Screen


Add MinWiz.com

Added MinWiz.com to list of under 250 KB sites.
I have added it in a random place to avoid any merge conflict. Hope it's OK with you and order on pages.txt is not important.

I add it manually now and close this because I'm currently adding stuff anyways. But thanks for being so considerae!

I add it manually now and close this because I'm currently adding stuff anyways. But thanks for being so considerae!


Share echo deployment in ingress test for performance

Please provide a description for what this PR is for.
And to help us figure out who should review this PR, please
put an X in all the areas that this PR affects.
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Pull Request Attributes
Please check any characteristics that apply to this pull request.
[ ] Does not have any changes that may affect Istio users.

@howardjohn: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
50fbed46a0482c94dbac2f7a22af057763eacdff
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
50fbed46a0482c94dbac2f7a22af057763eacdff
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
2a6bbae3e61e8ad5b7c437f80a9e2757ba25362f
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
2a6bbae3e61e8ad5b7c437f80a9e2757ba25362f
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
2a6bbae3e61e8ad5b7c437f80a9e2757ba25362f
link
/test integ-security-k8s-tests_istio

integ-security-multicluster-tests_istio
2a6bbae3e61e8ad5b7c437f80a9e2757ba25362f
link
/test integ-security-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
2a6bbae3e61e8ad5b7c437f80a9e2757ba25362f
link
/test integ-security-k8s-tests_istio

integ-security-multicluster-tests_istio
2a6bbae3e61e8ad5b7c437f80a9e2757ba25362f
link
/test integ-security-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-mc-k8s-tests_istio
f35aa8e24507d6d083a97966271d94b07afa8869
link
/test integ-telemetry-mc-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

3min -> 51s

3min -> 51s

/retest

/retest


Update golang.org/x/crypto commit hash to 30dcbda

This PR contains the following updates:

Package
Type
Update
Change

golang.org/x/crypto
require
digest
198e437 -> 30dcbda

Configuration
📅 Schedule: At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by Renovate Bot.

⚠ Artifact update problem
Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.
♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

any of the package files in this branch needs updating, or
the branch becomes conflicted, or
you click the rebase/retry checkbox if found above, or
you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:
File name: go.sum
Command failed: docker pull registry.k8s.pwagner.net/dockerhub/renovate/go:latest
failed to register layer: Error processing tar file(exit status 1): write /usr/local/buildpack/go/1.17.6/pkg/linux_amd64_race/image.a: no space left on device


HBASE-27629 Let lock wait timeout to improve performance of SnapshotHFileCleaner

Backport of HBASE-27043

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 32s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2.4 Compile Tests _

+1 :green_heart:
mvninstall
3m 28s
branch-2.4 passed

+1 :green_heart:
compile
2m 34s
branch-2.4 passed

+1 :green_heart:
checkstyle
0m 36s
branch-2.4 passed

+1 :green_heart:
spotless
0m 43s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
1m 30s
branch-2.4 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 56s
the patch passed

+1 :green_heart:
compile
2m 16s
the patch passed

+1 :green_heart:
javac
2m 16s
the patch passed

+1 :green_heart:
checkstyle
0m 35s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
21m  7s
Patch does not cause any errors with Hadoop 2.10.2 or 3.1.4 3.2.4 3.3.4.

+1 :green_heart:
spotless
0m 39s
patch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
1m 39s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 12s
The patch does not generate ASF License warnings.

41m 33s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5020/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5020

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux 2693a94ea528 5.4.0-135-generic #152-Ubuntu SMP Wed Nov 23 20:19:22 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.4 / 9236242dac

Default Java
Eclipse Adoptium-11.0.17+8

Max. process+thread count
85 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5020/1/console

versions
git=2.34.1 maven=3.8.6 spotbugs=4.7.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 28s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2.4 Compile Tests _

+1 :green_heart:
mvninstall
3m 44s
branch-2.4 passed

+1 :green_heart:
compile
2m 47s
branch-2.4 passed

+1 :green_heart:
checkstyle
0m 41s
branch-2.4 passed

+1 :green_heart:
spotless
0m 47s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
1m 55s
branch-2.4 passed

_ Patch Compile Tests _

-1 :x:
mvninstall
3m 24s
root in the patch failed.

+1 :green_heart:
compile
2m 22s
the patch passed

+1 :green_heart:
javac
2m 22s
the patch passed

+1 :green_heart:
checkstyle
0m 36s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
25m 25s
Patch does not cause any errors with Hadoop 2.10.2 or 3.1.4 3.2.4 3.3.4.

+1 :green_heart:
spotless
0m 51s
patch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
2m  8s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 10s
The patch does not generate ASF License warnings.

47m 44s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5020/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5020

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux c0da80c8d514 5.4.0-135-generic #152-Ubuntu SMP Wed Nov 23 20:19:22 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.4 / 8df32127ef

Default Java
Eclipse Adoptium-11.0.17+8

mvninstall
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5020/2/artifact/yetus-general-check/output/patch-mvninstall-root.txt

Max. process+thread count
85 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5020/2/console

versions
git=2.34.1 maven=3.8.6 spotbugs=4.7.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 23s
Docker mode activated.

-0 :warning:
yetus
0m  5s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2.4 Compile Tests _

-1 :x:
mvninstall
2m 25s
root in branch-2.4 failed.

+1 :green_heart:
compile
0m 35s
branch-2.4 passed

+1 :green_heart:
shadedjars
4m 16s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 23s
branch-2.4 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 18s
the patch passed

+1 :green_heart:
compile
0m 36s
the patch passed

+1 :green_heart:
javac
0m 36s
the patch passed

+1 :green_heart:
shadedjars
4m 17s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 22s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
167m 46s
hbase-server in the patch passed.

187m  3s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5020/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5020

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 799e8aacfdfc 5.4.0-135-generic #152-Ubuntu SMP Wed Nov 23 20:19:22 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.4 / 8df32127ef

Default Java
Temurin-1.8.0_352-b08

mvninstall
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5020/2/artifact/yetus-jdk8-hadoop2-check/output/branch-mvninstall-root.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5020/2/testReport/

Max. process+thread count
2576 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5020/2/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  6s
Docker mode activated.

-0 :warning:
yetus
0m  5s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2.4 Compile Tests _

+1 :green_heart:
mvninstall
3m  9s
branch-2.4 passed

+1 :green_heart:
compile
0m 43s
branch-2.4 passed

+1 :green_heart:
shadedjars
4m 43s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 26s
branch-2.4 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 54s
the patch passed

+1 :green_heart:
compile
0m 43s
the patch passed

+1 :green_heart:
javac
0m 43s
the patch passed

+1 :green_heart:
shadedjars
4m 41s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 25s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
174m 11s
hbase-server in the patch passed.

197m  2s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5020/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5020

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux c3109f9fcdc4 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.4 / 8df32127ef

Default Java
Eclipse Adoptium-11.0.17+8

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5020/2/testReport/

Max. process+thread count
2376 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5020/2/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

The mvninstall failures are strange and inconsistent. I was not able to reproduce it locally and the LICENSE file is not archived so I can't check what files are violating the licenses. This should be unrelated to this change.


Better import

Description
Better import
Type of change

[x] Refactor
[ ] New feature
[ ] Bug fix
[ ] CVE fix
[ ] Optimization
[ ] Documentation Update
[ ] Configuration Update
[ ] Bump-up dependent library
[ ] Bump-up library or tool used for development (does not change the final image)
[ ] CI configuration change
[ ] Konflux configuration change

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.88%. Comparing base (12c8083) to head (9c0237c).
Report is 22 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1671   +/-   ##
=======================================
  Coverage   94.88%   94.88%
=======================================
  Files          60       60
  Lines        2681     2681
=======================================
  Hits         2544     2544
  Misses        137      137

Flag
Coverage Δ

94.88% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines
Coverage Δ

runner.py
60.86% <100.00%> (ø)

/lgtm

/approve

/override "Red Hat Konflux / lightspeed-service-on-pull-request"


sprint challenge user interface

What I was able to accomplish. Had a hiccup on the about page. I couldn't figure out which part of my code I messed up with the containers.

Minimum Viable Product
Your finished project must include all of the following requirements:
Homepage

[x] Build the HTML and CSS to create the missing navigation and header.
[x] Link the About navigation item to the about.html page

You will also notice there are 10 boxes on the home page that need background colors.  Use this list below to correctly style each box:

[x] box1: teal
[x] box2: gold
[x] box3: cadetblue
[x] box4: coral
[x] box5: crimson
[x] box6: forestgreen
[x] box7: darkorchid
[x] box8: hotpink
[x] box9: indigo
[x] box10: dodgerblue

About Page
Review the provided design file for the about page. You have been provided the HTML wrapper, footer, and page content for the about page. Create the rest of the missing HTML and CSS to match the design file.

[x] Copy and paste your home page navigation and header into the about page
[x] Update the header image with the about page image
[x] Link the Home navigation item back to the index.html page.
[X] Build the rest of the about page layout to match the design

Stretch Problems
After finishing your required elements, you can push your work further. These goals may or may not be things you have learned in this module but they build on the material you just studied. Time allowing, stretch your limits and see if you can deliver on the following optional goals:

[ ] Build a page of your choosing from the navigation items.  Come up with content and images that fit the theme.
[ ] Introduce CSS animations to your site.
[ ] Build a contact page and create a form with several inputs of your choosing
[ ] Add responsive breakpoints to your code by using media queries

What Looks Great

Great job reaching MVP!
Code is organized and easy to read.

Suggested Improvements

Good work completing the project, keep working on and practicing CSS and this sort of project will become second nature for you

Rating
2


Set UserId for server-to-server (S2S) rewarded video callbacks

Hello everyone and great respect!
Could you please implement the ability to set a user id for server side validation of RewardedAd?

none of these issues seem to have any response. Is this package abandoned?


Feature/add spotify icon

Added icon for Spotify, thanks for the awesome widget!

Thank you for this addition and you support!


Change current polling model to waiting on conditional variable

Right now the schedule polls every 5 seconds to check if is time to process a schedule. Instead, change to use pthread based conditional variable visible to other threads also, especially when a change to the schedule is received.

https://github.com/Comcast/aker/pull/62


Feat/hybrid snark agg

Description
[PR description]
Issue Link
[link issue here]
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Contents

[item]

Rationale
[design decisions and extended information]
How Has This Been Tested?
[explanation]

How to fill a PR description
Please give a concise description of your PR.
The target readers could be future developers, reviewers, and auditors. By reading your description, they should easily understand the changes proposed in this pull request.
MUST: Reference the issue to resolve
Single responsibility
Is RECOMMENDED to create single responsibility commits, but not mandatory.
Anyway, you MUST enumerate the changes in a unitary way, e.g.
This PR contains:
- Cleanup of xxxx, yyyy
- Changed xxxx to yyyy in order to bla bla
- Added xxxx function to ...
- Refactored ....

Design choices
RECOMMENDED to:

What types of design choices did you face?
What decisions you have made?
Any valuable information that could help reviewers to think critically

some high level comments:
the name, hybrid, i would recommend the a more general/broad name, meaning "1 in many", like muxer, oneshot and so on.
hybrid, meaning combining somethings different.  Actually, in this design,   we could even allow v0.12, v0.13, v0.14 chunks inside batch circuit if we will.  (we just did not do that).
better don't use "sp1" part of naming.    Use a name like proof_a / proof_lhs , or even an array/vector of proofs/procotols.


Increase code coverage

Codecov Report

Merging #110 (56f1479) into master (4ebaba7) will increase coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #110      +/-   ##
==========================================
+ Coverage   71.28%   71.36%   +0.08%
==========================================
  Files         117      117
  Lines       34270    34270
==========================================
+ Hits        24429    24457      +28
+ Misses       9841     9813      -28

Impacted Files
Coverage Δ

...just/dynadjust/dnageoidwrapper/dnageoidwrapper.cpp
80.10% <0.00%> (+0.35%)
:arrow_up:

dynadjust/dynadjust/dnageoid/dnageoid.cpp
69.83% <0.00%> (+1.27%)
:arrow_up:

dynadjust/include/functions/dnatemplatefuncs.hpp
72.57% <0.00%> (+2.21%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ebaba7...56f1479. Read the comment docs.


TextWorld env.step reward!=1 after game=won

TextWorld env.step reward != 1 after game=won

Fixed.


Did not receive email with password reset instructions

As a visitor
When I register
It does not send me an email with password reset instructions
It should send me an email with password reset instructions
I registered yesterday, and I received a "Welcome to Operation Code" email with information about Slack, and an invite to the Slack.
Reading over Veterans::RegistrationController, it seems like it should be sending an email with reset: https://github.com/OperationCode/operationcode/blob/0bc01628d09415ed520df45a9a5b75dcb9d372fb/app/controllers/veterans/registrations_controller.rb#L26-L32 . While testing in development, I also get a new window open with the sent Welcome email but not the registration.
This @veteran.send_reset_password_instructions seems to come from devise's recoverable which is set in Veteran

Forgot to mention I checked my spam folder, and didn't see anything there either.

With a tip from @sfillm07 in slack, the welcome email is the password reset: https://github.com/OperationCode/operationcode/blob/0bc01628d09415ed520df45a9a5b75dcb9d372fb/app/views/devise/mailer/reset_password_instructions.html.erb

We had this functionality but then removed it to focus on shoring up our UX on slack.
Closing this out as if we choose to turn on profiles again we should be covered by devise.


Update go-xcode/v2 and wire in automatic signing style export options

Checklist

[x] I've read and followed the Contribution Guidelines
[x] step.yml and README.md is updated with the changes (if needed)

Version
Requires a PATCH version update
Context
This PR updates the go-xcode/v2 dependency and wires in exportOptions.plist generation for automatic code signing style.

Hey there, since the update of the step, we got the following error:
Failed to execute Step main logic: failed to archive the project: command failed with exit status 65 (set -o pipefail && xcodebuild "archive" "-workspace" "/Users/[REDACTED]/git/ios/meilleurtaux.xcworkspace" "-scheme" "preprod" "-configuration" "preprodRelease" "-xcconfig" "/var/folders/yy/6kcn9mkd5svdbqnznwf474f00000gn/T/52466558/temp.xcconfig" "-archivePath" "/var/folders/yy/6kcn9mkd5svdbqnznwf474f00000gn/T/xcodeArchive2430447478/MTX PREPROD.xcarchive" "-destination" "generic/platform=iOS" | xcpretty): error: Could not get GOOGLE_APP_ID in Google Services file from build environment (exit code: 1)

We changed nothing since yesterday, we just got these errors on every build since this morning, and I only just thought about checking for changelogs, and got the good surprise of finding only one update on the step that is now failing ^^
Should I open an issue on that?


pubsub: move on top of gRPC

Change the pubsub client from using HTTP to gRPC.

Hi @jba sorry for follow up, but would it be possible to confirm if the transport: http2Client.notifyError got notified that the client transport was broken EOF. errors are benign for long running iterators (Next()), and if so, if there is a way to disable logging?
They are filling up my k8 logs and obfuscating other errors.
Any way to confirm if this is benign? seems to always recover. any way to suppress?

So you're still seeing them at head? We just moved pubsub to gRPC. Can you replicate the problem?

@jba thanks for that reminder. It seems that the errors are actually coming from the go/errors and datastore libraries. Basically my datastore clients that are left open log this error every 4 minutes running on Container Engine.
Should they be manually closed more often? Is there a list of which libraries are on gRPC, and also which clients are safe for concurrent use with multiple goroutines?

nevermind it looks like I'm running into something others have seen. https://github.com/GoogleCloudPlatform/google-cloud-go/issues/293

I'm seeing exactly the same issue as @schmohlio with getting this error every 4 minutes. I have a pubsub client and a bigquery client in my application.

@rtjoseph11 For now I just included the following in one of my libs and import it:
import "google.golang.org/grpc/grpclog"

func init() {
	grpclog.SetLogger(log.New(ioutil.Discard, "", 0))
}


Debugify - Enable Fix

What config to change
MC-199467
Why should it be changed
This bug is evident when players stay in the same chunks for more than around an hour with the same mobs. (Afk farm or simply just really busy) This bug looks really funky (as seen in the video) and affects a few mobs (specifically ones with wings).
Category
Mod config option
Additional details
though this is listed as server side the bug on Debugify tracker it's actually a client issue but the underlying problem affects both environments.

Enabled in 3.4.1.


Create Mk1RocketFuelFuselage.netkan

Fix #2851

Please filter the source.

Source code and license filtered.

Please don't filter the license, many licenses require the distribution of the license itself with the mod and it's best not to start down that road.

Should have stopped when I had it right :)

Merging with my thanks.


python3Packages.teslajsonpy: 1.4.1 -> 1.4.2

Motivation for this change
https://github.com/zabuldon/teslajsonpy/releases/tag/v1.4.2
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 152436 run on x86_64-linux 1

2 packages built:

python38Packages.teslajsonpy
python39Packages.teslajsonpy


Can't correctly infer generic interface type when it's behind a function

TypeScript Version:  2.9

Search Terms:
function parameter inference
Code
interface MyInterface<T> {
    retrieveGeneric: (parameter: string) => T,
    operateWithGeneric: (generic: T) => string
}

const inferTypeFn = <T>(generic: MyInterface<T>) => generic;

// inferred type for myGeneric = MyInterface<{}>, `generic.toFixed()` marked as error (as {} doesn't have .toFixed())
const myGeneric = inferTypeFn({
    retrieveGeneric: parameter => 5,
    operateWithGeneric: generic => generic.toFixed()
});

// inferred type for myGeneric = MyInterface<number>, everything OK
const myWorkingGeneric = inferTypeFn({
    retrieveGeneric: (parameter: string) => 5,
    operateWithGeneric: generic => generic.toFixed()
});

Expected behavior:
myGeneric has every type correctly inferred, parameter is a string, generic is a number.
Actual behavior:
it doesn't infer the correct type for generic parameter unless you manually specify the type of parameter (which it already had the right type)
Playground Link:
https://www.typescriptlang.org/play/#src=interface MyInterface<T> {
    retrieveGeneric%3A (parameter%3A string) %3D> T%2C
    operateWithGeneric%3A (generic%3A T) %3D> string
}

const inferTypeFn %3D <T>(generic%3A MyInterface<T>) %3D> generic%3B

%2F%2F inferred type for myGeneric %3D MyInterface<{}>%2C `generic.toFixed()` marked as error (as {} doesn't have .toFixed())%0D%0Aconst%20myGeneric%20%3D%20inferTypeFn(%7B%0D%0A%20%20%20%20retrieveGeneric%3A%20parameter%20%3D%3E%205%2C%0D%0A%20%20%20%20operateWithGeneric%3A%20generic%20%3D%3E%20generic.toFixed()%0D%0A%7D)%3B%0D%0A%0D%0A%2F%2F%20inferred%20type%20for%20myGeneric%20%3D%20MyInterface%3Cnumber%3E%2C%20everything%20OK%0D%0Aconst%20myWorkingGeneric%20%3D%20inferTypeFn(%7B%0D%0A%20%20%20%20retrieveGeneric%3A%20(parameter%3A%20string)%20%3D%3E%205%2C%0D%0A%20%20%20%20operateWithGeneric%3A%20generic%20%3D%3E%20generic.toFixed()%0D%0A%7D)%3B%0D%0A%0D%0A

The error doesn't happen if at least one of the parameters is not declared in the callback:
declare function f<T>(obj: { get: (p: number) => T, set: (v: T) => void }): T;
const res0 = f({ get: p => 0, set: v => {} });
const res0N: number = res0; // Error

const res1 = f({ get: () => 0, set: v => {} });
const res1N: number = res1; // Works

const res2 = f({ get: p => 0, set: () => {} });
const res2N: number = res2; // Works

Is this the same issue? Return type is casted to any, if generic is used:
declare function $eval<T extends Element = HTMLElement, A = any, R = any>(
    selector: string,
    pageFunction: (element: T, ...args: A[]) => R,
    ...args: A[]
): Promise<ReturnType<typeof pageFunction>>;

$eval<HTMLButtonElement>('.btn', (el) => el.disabled).then(value => value);
                                         // ^-- boolean             ^-- any, SHOULD be boolean
$eval('.btn', (el) => el.spellcheck).then(value => value);
                      // ^-- boolean               ^-- boolean

I wonder if I got the same issue for interfaces + classes. Have a look at this playground.
If you hover over createHandler you will see {} as inferred type instead of string

@andy-ms I got the similar issue and found a solution/workaround:
- declare function f<T>(obj: { get: (p: number) => T, set: (v: T) => void }): T;
+ declare function f<T>(obj: { get: (p: number) => T, set: <U extends T>(v: U) => void }): T;

declare function f<T>(obj: { get: (p: number) => T, set: <U extends T>(v: U) => void }): T;
const res0 = f({ get: p => 0, set: v => {} });
const res0N: number = res0; // Works!

const res1 = f({ get: () => 0, set: v => {} });
const res1N: number = res1; // Works

const res2 = f({ get: p => 0, set: () => {} });
const res2N: number = res2; // Works

Hope it helps :) .

@YiSiWang thanks! Never thought swapping the position would change something :)
I wonder if this is bug or works as intended?

Inside the compiler, we have this concepts of something called a contextual type and a context-sensitive function. A contextual type is simply the type a position must have based on what it is being assigned to. A context-sensitive function is a function with untyped function parameters. When a context-sensitive function exists, its type must be derived from the contextual type at that location.
In
const myGeneric = inferTypeFn({
    retrieveGeneric: parameter => 5,
    operateWithGeneric: generic => generic.toFixed()
});

both functions in the object literal are context-sensitive. This means we try to solve their types during inference independently. We see parameter unannotated first, lock in {} as the inference (since we decide that parameter must have a type before we can check the body), and then that's what it's stuck with.
whereas
const myWorkingGeneric = inferTypeFn({
    retrieveGeneric: (parameter: string) => 5,
    operateWithGeneric: generic => generic.toFixed()
});

only operateWithGeneric is context-sensitive. This means we create an inference of T -> string before we even look at the context sensitive function (since we do context-free inferences and then context-sensitive ones) and everything's good.
We're conservative here because we assume that a parameter, if present, may affect the return type of a function. Based on what we've talked about in related issues before, it's unlikely we'll specifically improve this without moving to a full unification-based solve for the arguments. the recommendation right now is to not list parameters you don't use (or if you must list them, manually assign them types). ❤

@weswigham I wonder if following piece of code is related to this issue:
declare function test<T>(a: T, b: T): void;
declare const a: { cb: (arg: number) => number }
test(a, { cb: arg => arg }) // [ts] Parameter 'arg' implicitly has an 'any' type.

We have type checking here ((arg: string) => arg won't fit), but don't have type inference.
Is it the same problem or something different?

@weswigham I should add that this affects JSX as well, with generic components:
interface MyInterface<T> {
  retrieveGeneric: (parameter: string) => T,
  operateWithGeneric: (generic: T) => string
}

export declare function Component<T>(props: MyInterface<T>): JSX.Element

const element = (
  <Component
    operateWithGeneric={ generic => generic.toFixed() }
    retrieveGeneric={ parameter => 5 }
  />
)

Tracking at #303134

declare function f<T>(obj: { get: (p: number) => T, set: <U extends T>(v: U) => void }): T;
const res0 = f({ get: p => 0, set: v => {} });
const res0N: number = res0; // Works!

const res1 = f({ get: () => 0, set: v => {} });
const res1N: number = res1; // Works

const res2 = f({ get: p => 0, set: () => {} });
const res2N: number = res2; // Works

It will report error when you do this:
declare function f<T>(obj: { get: (p: number) => T, set: <U extends T>(v: U) => void }): T;

const res0 = f({
    get: p => 0, set: v => {
        // error!
        return v.toFixed()
    }
});

This is so wierd.


Add support for Common Lisp

Support for Common Lisp was recently added to Treesitter, I have already added the current main parens to my clone of the repo, the only ones necessary are square brackets and parenthesis.

I have already added the current main parens to my clone of the repo,

Can you make a PR? you just need to fork this repo, add your fork as a remote to your clone, push to your fork and make a PR

Done. Thanks in advance for this awesome work. #36

Closed by #36


[flash_ctrl] err_code register shows mp_err (in tests on Verilator)

Hey all,
Having run the following test tests:flash_ctrl_test. The test output shows that transaction end error_codes = 00000002.
Which (I believe) is the mp_err flag set in err_code register. I'm trying to fixup a flash driver (tock os - showed the err flag), but came across this error during testing. Is this a bug? or is this the expected behavior?
It seems that as a result, I am unable to write to flash. Atleast on Verilator.
Here's the output:

Thanks!

Closing as the tests were working fine, I incorrectly diagnosed where it was happening.


README.md: Switch chat-zulip-org.html to chat.zulip.org

Automated message from Dropbox CLA bot
@lonerz, it looks like you've already signed the Dropbox CLA. Thanks!

So I do want to link to chat-zulip-org.html aka https://zulip.readthedocs.io/en/latest/chat-zulip-org.html ; I think we just need to use absolute links in README.md.

@timabbott Ah, darn. Will fix it.


clean up to remove old bag deletion code in resource_modified()

clean up to remove old bag deletion code. This will not cause issues for NFIE release, since the exception is ignored, but will be nice to remove it since it causes extra wasted operations.

The fix is properly included in develop branch and deployed on dev. Closing.