Output layer names

While not necessary, it would be nice if the output layer names were more along the lines of "control" and "flow" instead of devicelayer_0 and such.

A potential solution for this issue is suggested in #100 . That should cover both what is requested and also a larger problem of separating outputs for every feature size.


market reporting states should be right aligned in my markets list

@matt-bullock plz confirm

Yes, should be right aligned

Yep


Build/test javaharness on Travis

Currently we only run bazel build/test for the particles, src and src_kt folders. A big missing part is all of our Android code in javaharness.
The main two issues are:

We need to install an Android SDK on Travis before we can build Android code with bazel.
Travis builds are already super slow, and this will make them even slower.

For 1, I have a PR ready and waiting (https://github.com/PolymerLabs/arcs/pull/3585), which downloads an Android SDK using bazel repo rules. This seems to work, but involves significant juggling in order to let people to continue to use their regular Android SDK installation on their workstations.
For 2, @cromwellian has proposed using GCP Remote Build Execution to speed things up. Other ideas are to introduce caching of build artifacts somehow.

From #4026: PR #4008 introduces Dockerfile.CI, which would be a simple way of installing the Android SDK on Travis. Once that's in, we won't need to jump through all the special hoops in #3585, enabling testing of //javaharness/... should just work straight away.

Some updates on the Docker work that is still in flight. Code is at https://github.com/alxrsngrtn/arcs/tree/travis-docker.
As of commit https://github.com/alxrsngrtn/arcs/commit/80dafa6b9d791b7e3a17642a484bfeff142f777d:
Not all packages build correctly yet:

running sigh build and sigh test now works, if you use node v10, and if you don't mount the workdir as a volume but instead add COPY . . to the Dockerfile. Current theory is that mounting the volume doesn't give Docker the correct write access, or maybe it's incorrectly copying the host's node_modules/build folders.
//particles/Tutorial/Kotlin/... now works. Needed to install the full jdk8, not just the jre.
Emscripten is currently failing with 403 forbidden. Seeing this locally too, so it's not a docker thing: https://s3.amazonaws.com/mozilla-games/emscripten/packages/llvm/tag/linux_32bit/index.txt
//src_kt/... now works!

Other notes:

Need to bump up the RAM memory limit on Docker Desktop from 2GB (5GB seems to work) otherwise it OOMs

Some remaining tasks:

[ ] Fix C++ Emscripten (I suspect this is broken locally now too)
[ ] Consolidate and submit the latest Dockerfile (don't necessarily need to update Travis yet)
[ ] Install an Android SDK into the Docker image so that the Android code builds and runs
[ ] Figure out how to get ChromeDriver to run inside Docker
[ ] Update Travis to use the Docker image

[ ] Create an official Arcs Docker hub repository
[ ] Create a one-off repo or CICD rule for building the docker image and publishing it in Docker hub

Some troubleshooting for the failing emsdk stuff. Building //src/wasm/cpp/... in the Docker container was failing. I suspect this is broken locally too, but I haven't actually checked. Here are the errors and how I've fixed them:

Error downloading URL 'https://s3.amazonaws.com/mozilla-games/emscripten/packages/llvm/tag/linux_32bit/index.txt': HTTP Error 403: Forbidden

It looks like emsdk has moved its hosting from amazon to google. The emsdk commit we are pegged to still points to the old URLs. To fix this, I updated the commit hash in build_defs/emscripten/repo.bzl from efc64876db1473312587a3f346be000a733bc16d to a5082b232617c762cb65832429f896c838df2483 (still using version 1.38.43 of emscripten though) and it successfully downloads the right binaries now.

tar (child): lbzip2: Cannot exec: No such file or directory

Need to add apt-get install lbzip2 to the Dockerfile.

tar (child): xz: Cannot exec: No such file or directory

Need to add apt-get install xz-utils to the Dockerfile.
After following those steps, C++ wasm works in Docker! 🎉

Download all of our largest dependencies (Kotlin Native, Emscripten) and install them in the Dockerfile, rather than getting bazel to do it. This should speed up clean bazel builds significantly.

After experimentation, I think we should skip this step.
While a lot of time is consumed in downloading our repo dependencies (emscripten, the kotlin native compiler, the stuff related to //src_kt), I don't think it'll be worth it in the end. As an experiemnt, I've added a final command in the dockerfile:
RUN bazel fetch //particles/... //src_kt/... //src/..

The trouble is, this leads to a dockerimage file ballooned in size (~12GB). So, in some sense, we are changing the travis waiting period from building the sources to downloading the image.

Been having a look into the time taken to run the necessary fetching on my laptop (not ideal conditions, limited RAM, CPU, bandwidth, using wifi, in Australia etc), but I am imagining that Travis is under similar constraints.
bazel clean --expunge
bazel fetch //particles/... //src/... //src_kt/...  1.12s user 1.05s system 0% cpu 38:21.14 total

This suggests that there's significant amount of time being spent in CI just in downloading our dependencies.
Cameron suggested that there's a flag for looking up dependencies before downloading them --distdir=<a path> multiple uses are accumulated.
https://docs.bazel.build/versions/master/command-line-reference.html

Another reason to prefer including deps inside our Docker image, I just saw this on my Travis build:
Error: Downloading URL 'https://storage.googleapis.com/webassembly/emscripten-releases-builds/linux/737d4a07be76c15124adf3c6ef2c218123f7a67f/wasm-binaries.tbz2': [Errno 104] Connection reset by peer
Installation failed!

[ ] Install an Android SDK into the Docker image so that the Android code builds and runs

@yuangu-google


Add isMemoizedComponent

Codecov Report

Merging #3 into master will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master        #3   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            4         6    +2
  Lines           15        32   +17
  Branches         4         8    +4
=========================================
+ Hits            15        32   +17

Impacted Files
Coverage Δ

src/is-memoized-component/isMemoizedComponent.ts
100.00% <100.00%> (ø)

src/is-react-component/isReactComponent.ts
100.00% <100.00%> (ø)

src/test-utils/testUtils.tsx
100.00% <100.00%> (ø)

src/utils/isObject.ts
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 696858d...9d7d2cb. Read the comment docs.


Create repository in retaildevcrews for service bus / event grid integration with key vault

@bartr to discuss with Dan

Just as a note, not a requirement for Accolade anymore as they as more interested in using CSI driver to bring in secrets.


modified the Y rotation to be multiplied by -1 so that UE interprets …

Not sure if this is universal or only in our maya/UE setup but we had to multiply the Y value by -1 to get it to come into UE properly

This may be dependent on what axis is 'Up' in Maya. If so, a better fix will be to automatically figure out if this flip is needed. Investigating.

Jesus for some reason I never got this notification


An unhandled rejection has occurred inside Forge: RequestError: connect ETIMEDOUT <IP_ADDRESS>:443

Pre-flight checklist

[x] I have read the contribution documentation for this project.
[x] I agree to follow the code of conduct that this project uses.
[x] I have searched the issue tracker for a bug that matches the one I want to file, without success.

Electron Forge version
7.5.0 or 7.6.0
Electron version
33.2.0
Operating system
windows 11
Last known working Electron Forge version
No response
Expected behavior
Successfully packaged
Actual behavior

Steps to reproduce

Additional information
No response

Hi @zhangjiji03, thanks for reporting the issue. It would be helpful to get a bit more context on the problem at hand. Is this what you're encountering when you attempt to package the app? Does the start command work separately from this? Do you usually use a mirror for npm?

Pre-flight checklist
* [x]  I have read the [contribution documentation](https://github.com/electron/forge/blob/main/CONTRIBUTING.md) for this project.[x]  I agree to follow the [code of conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project uses.[x]  I have searched the issue tracker for a bug that matches the one I want to file, without success.

Electron Forge version
7.5.0 or 7.6.0
Electron version
33.2.0
Operating system
windows 11
Last known working Electron Forge version
No response
Expected behavior
Successfully packaged
Actual behavior

Steps to reproduce
Additional information
No response

Hello, I'm having the same issue.
Did you ever find a solution?


how to read whatsapp messages ?

is there any way to read whats app messages ?

Sorry I don't know
On Sat 1 Dec, 2018, 8:08 PM Jishnu Raj<EMAIL_ADDRESS>wrote:

is there any way to read whats app messages ?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/adonespitogo/AdoBot/issues/24, or mute the thread
https://github.com/notifications/unsubscribe-auth/Aq8VXYNGVWT-odGEXyB1j02z-thXun_Bks5u0pR5gaJpZM4Y87C_
.

Yes possible. We need to change the WhatsApp version to the legacy WhatsApp by reinstalling it, we can access keys and message databases easily without root if we have the legacy version of WhatsApp.


better brain control

Can we allow a better control of the brain, aka the memory, by users?

Export/Import(load): Say I'm running hubot in the cloud and over time it saves data to its brain, and I want to export the memory (could be a JSON file) elsewhere.
Perhaps I migrate or update my hubot, and wish to load its old memory.
Modularization of memory. This allows for specialization of task and better performance. e.g. favfood.json and favdrink.json keep track of my team's favorite food and drinks, with 10000 entries each. Each can be uploaded independently, and searching from separate file is def faster than searching a larger concatenated file.

Hi,
In general I believe improving the brain is greatly needed. But for your case I believe for the most part it is doable without change to hubot:
1: The most common hubot setup includes persistence via Redis. This pretty much solves the problem.
Your data will be stored to Redis each time you write to the brain and restored each time you boot Hubot. So you can safely reboot / update / modify your hubot installation.
If you wish to migrate to another host, you can just export / import your redis.
2: Why do you even bother with the performance of this task? How often will you import data to your hubot? And won't you be importing it prior to booting it?

There are two requests here, and I think they can be discussed separately.
I agree there could be better support for importing and exporting the contents at the brain. At some point, it's just a JavaScript object (robot.brain.data), so it can be JSON.stringifyd and exported to a file. Similarly, robot.brain.data could be replaced with data from another source. You could do most of that outside of hubot already.
For example, if you are using the file brain, there's a JSON blob on disk. If you wanted to switch to the redis brain, you'd stop hubot, create the appropriate key, and assign that JSON string to the value, update hubot to use redis-brain, and then start it back up.
As for modularizing the brain, I'm not really sure about that. The current implementation of the brain isn't awesome already, so adding that seems like a stretch. I would also point out that scripts are just javascript, so you can easily attach other things to the robot object and access them other places. For example, if you wanted to be using mysql directly for your data, you'd be able to initialize a robot.mysql client, and use that from your scripts.

I bet we will have some deep thinking about the brain in hubot3. Be sure we'll dig into the issues archives. So I'm closing this.

We're moving to Hubot Evolution for discussing future features of hubot if anyone is interested in writing something up about this.


Failed config question : Get BadRequest: Failed post to Discord Channel

Is there something i'm missing in my configuration below ? Got Bad request.
Using the latest image in docker. It starts up well. Polling the rss feeds well. But fails to send to discord channel.
//Regards Niklas
I have tested a minimal payload to my discord webhhok and it works.
This is postman payload I have tested, and worked:
{   "username": "Test",   "avatar_url": "",   "embeds": [     {       "author": {         "name": "",         "url": "",         "icon_url": ""       },       "title": "Test 123",       "url": "https://google.com/",       "description": "This is the description",       "image": {         "url": ""       },       "footer": {         "text": "Woah! So cool! :smirk:",         "icon_url": ""       }     }   ] }
I have configured my appsettings.conf like this:
{   "Instances": [     {       "Id": "MorningBrew",       "RssUrls": [         "https://blog.cwa.me.uk/feed/"       ],       "YoutubeUrls": [ "" ],       "DiscordWebhookUrl": "https://discord.com/api/webhooks/1.......",       "Username": "nikbra68",       "RssCheckIntervalMinutes": 3,       "EnableAutoRemove": true,       "Color": 8411391,       "DescriptionLimit": 200,       "Forum": true     },     {       "Id": "Dn",       "RssUrls": [         "https://www.dn.se/rss/"       ],       "YoutubeUrls": [ "" ],       "DiscordWebhookUrl": "https://discord.com/api/webhooks/1....",       "Username": "nikbra68",       "RssCheckIntervalMinutes": 3,       "EnableAutoRemove": true,       "Color": 8411391,       "DescriptionLimit": 200,       "Forum": true     }   ]   }
I hade to add username. When testing payload in postman to

Did use "forum = true", changed it to false. And it works now

Hey glad you were able to resolve! For future reference you will only want Forum set to true if sending to Discord's Forum type channels, normal text channels should always be false. Cheers!

Hey @Qolors
Not Sure if i should open up a new issue for this or not; but i'm receiving the same issue with the following error
BadRequest: Failed post to Discord Channel
{
"Instances": [
{
"Id": "xxxxxx",
"RssUrls": [
"https://www.xxxxxx.com.au/feed/"
],
"YoutubeUrls": [
""
],
"DiscordWebhookUrl": "https://canary.discord.com/api/webhooks/xxxx?thread_id={xxxxxxxxxxx}",
"Username": "imschema",
"RssCheckIntervalMinutes": 3,
"EnableAutoRemove": true,
"Color": 8411391,
"DescriptionLimit": 200,
"Forum": true
}
]
}
Tried to add in the username as above too, but have the same issue still.
same issue with the normal or canary url api too.
using the ?thread=id= for the following channel in the forum.

Is there somethng i'm missing here? cheers!

Hey @notschema,
using the ?thread=id= for the following channel in the forum.
Just wanting to understand correctly - when you copy the webhook url from Discord, you're not including ?thread=id= correct? When you don't include that in to the original url do you still get the same Bad Request?
As a last step - have you tried creating a brand new Discord Webhook for that channel and using it without any altering? Just trying to narrow down the issues. Let me know and we can hopefully resolve this issue for you. Thanks!

Hey @notschema,
using the ?thread=id= for the following channel in the forum.
Just wanting to understand correctly - when you copy the webhook url from Discord, you're not including ?thread=id= correct? When you don't include that in to the original url do you still get the same Bad Request?
As a last step - have you tried creating a brand new Discord Webhook for that channel and using it without any altering? Just trying to narrow down the issues. Let me know and we can hopefully resolve this issue for you. Thanks!

Hey
Yeah that's correct, even when not including it I'm still getting the same error.
Normal webhooks also aren't working; although i am runing this on unraid via docker too.

Had the same issue here, and I hope setting forum to false will fix it. I only had Forum as true as that's what the default example in the README had. Consider changing that to false, or at least adding in a comment to state that it should be set to false on normal chats 👍


Fix Typo in UEAloader load_all Function Annotation (csv -> ts)

Hello, there is a clerical error here, in the UEAloader of data_loader.py, the load_all function annotation should be ts file, but the clerical error is written as csv file

Thanks for pointing out this. We have fixed this bug in the lastest commit.


backend: Use client-go to generate tls

fixes:https://github.com/headlamp-k8s/headlamp/issues/961

5 lines in, 57 out in one patch. Love it.
Also tested and it works the same as the current backend AFAICS.


No throws for impossible neural network conditions

If I ran code that used the neuralNet constructor with negative numbers, it messes. Also, the activation function string can be anything, but should throw an error if not part of the map.
Maybe throw an error or print an error and terminate the function if a condition is broken

This is true. Both should throw errors.


Not able to build IOS

Description
I am using macbook pro with m2 chip. I setup react-native-firebase in my project. But it is working fine in android
and giving error in macbook.
React Native Version
0.71.3
Output of npx react-native info

Steps to reproduce
I follow the official documention to setup FCM in ios. after setting everything up I run the command yarn run ios || npx react-native run-ios. It throws this error in xcode.
Snack, code example, screenshot, or link to a repository

I setup react-native-firebase in my project

Hi @NitinSinghElegant
Thanks for reporting this issue.
As you mentioned you're having this problem with react-native-firebase, you should open this issue against this other repository:
https://github.com/invertase/react-native-firebase/issues
I'll be closing this but feel free to reopen if the other repo points back to us as a issue in the core of React Native.
If you're having the same problem on a empty react-native project, please reopen.

Thanks @cortinico


Add the capability to check whether a B-series is energy-preserving

This code is based on the Theorem 2 of the paper "Energy-Preserving Integrators and the Structure of B-series" (link: https://link.springer.com/article/10.1007/s10208-010-9073-1).
In this code we want to know if a method is Energy-Preserving or not up to some order.
The function 'EnergyPreserving(A,b,s)' receives as input a square Matrix which is the inner part of the Butcher Array of a numerical method, a vector b (which length is the same as the amount of rows of A) and an intenger s, which will be the order up to which we are testing this method.
For example, the classical Runge-Kutta method:
A = [0//1  0//1  0//1  0//1
 1//2  0//1  0//1  0//1
 0//1  1//2  0//1  0//1
 0//1  0//1  1//1  0//1]
 b =  [1//6, 1//3, 1//3, 1//6]

the function 'EnergyPreserving(A,b,s)' will return 'True' for s = 3,4 but will return 'False' for s = 5, i.e. 'EnergyPreserving(A,b,5)'.
Furthermore, for any method described by the square matrix A and vector b, the function 'OrderMethod' will say up to which order it is energy-preserving. For example, for the same (A,b) as before this function will return "Energy Preserving for order < 4".
Finally, if you have already generated a BSeries serie following the next steps:
 rka = RungeKuttaMethod(A, b)
#generate bseries
 series = bseries(rka, s)

the function is_energy_preserving(serie) will return True for  s = 4, and False for s = 5.

Thanks, @Sondar74 !  Could you edit the box above (where it says "no description provided") and add a description of the contents of this PR?  Specifically:

Describe what functionality is added
Give example(s) of how to use it

Also, it would be great to make a notebook like https://github.com/ranocha/BSeries.jl/blob/main/docs/src/tutorials/bseries_basics.ipynb but explaining and demonstrating the functionality of the code in this PR.  From the Jupyter notebook we can generate a page for the online docs that will look similar to https://ranocha.de/BSeries.jl/dev/tutorials/bseries_basics/.

The Style Guide site recommends not to use the from x -> f(x). Should I rewrite this lines?
last_j_occurrence = findlast(x -> x == j, a)

No, that's fine as it is

I haven't looked at the algorithm in details yet. How does it compare to the approach of Sundklakk (2015)?

I haven't looked at the algorithm in details yet. How does it compare to the approach of Sundklakk (2015)?

I was trying to download the paper from this website, is this the reference you mentioned? And also, can you share the paper with me?
https://www.semanticscholar.org/paper/A-Library-for-Computing-with-Trees-and-B-Series-Sundklakk/4c5c94924f63ed3c61997c5972955d20f83a2145

Done on Slack

@Sondar74 It may be simpler as @ranocha suggests to simply add your new code to the main bseries.jl file.
The CSRK file is really a different topic and shouldn't be added in this pull request.  We will add it in a future pull request.  You can put it in a different branch (on your machine/fork) and remove it from this branch.  If needed, I can help you with this.

@Sondar74 I realized later yesterday that instead of "spine" and "ribs", it probably would make more sense to use "trunk" and "branches" (you had already suggested branches, which got me thinking about this).

Celledoni also calls it "spine" in the page 6 (678), during the first line of the proof of the Teorem 2

Celledoni also calls it "spine" in the page 6 (678), during the first line of the proof of the Teorem 2

Oh, that must be where I got the word from; I had forgotten.  Nevertheless, I think it would be nice to use "trunk" and "branches" as they are more consistent with other terminology used in this area.

I will make some fixes to this PR and perform a final review before merging the first working version


Changing tabs titles without restarting router

Is it possible to change bottom tabs titles in my navigation component without restarting router when receiving new props from redux state ? Because right now all the stack data is reset after it receives new props. I am implementing multiple language in my app so i just want seamless transition without jumping around the nav.

Have you found solution?


[Backend] Save Privacy Preferences for Fides User Device Id Only

Closes https://github.com/ethyca/fidesplus/issues/845
Description Of Changes
Support pseudonymous consent requests with fides_user_device_id in the privacy center for the new consent workflow.  The old workflow was handled here: https://github.com/ethyca/fides/pull/3158.  Note that some of the endpoints are shared between the old and new workflow (in particular the endpoint to create the ConsentRequest)
Note that this PR assumes subject identity verification is off to just save consent requests under the fides user device id only which seems consistent with how the other PR handled.
Code Changes

[ ] When saving privacy preferences through the privacy center, verify what type of provided identity was associated with the original Consent Request so we know which corresponding column to save privacy preference details
[ ] When retrieving privacy preferences through the privacy center, query the correct column on CurrentPrivacyPreference depending on the type of ProvidedIdentity saved with the ConsentRequest

Steps to Confirm

[ ] Turn subject identity verification off
[ ] Create a Consent Request POST {{host}}/consent-request.  Note the returned consent_request_id

{
  "phone_number": null,
  "email": null,
  "fides_user_device_id": "test_fides_user_device_id"
}

[ ] Create a Privacy Notice POST {{host}}/privacy-notice.  Note the returned privacy_notice_history_id

[
   {
      "name":"Profiling",
      "regions":[
         "us_ca",
         "us_ut"
      ],
      "description":"Making a decision solely by automated means.",
      "consent_mechanism":"opt_in",
      "data_uses":[
         "personalize"
      ],
      "enforcement_level":"system_wide",
      "has_gpc_flag":false,
      "displayed_in_overlay":true
   }
]

[ ] Save Privacy Preferences **PATCH {{host}}/consent-request/{{consent_request_id}}/privacy-preferences

{
   "browser_identity": {
       "ga_client_id": "UA-XXXXXXXXX",
       "ljt_readerID": "test_sovrn_id"
   },
   "preferences": [{
       "privacy_notice_history_id": "{{privacy_notice_history_id}}",
       "preference": "opt_out"
   }]
}

[ ] Retrieve Privacy Preferences **POST {{host}}/consent-request/{{consent_request_id}}/verify-for-privacy-preferences

Pre-Merge Checklist

[ ] All CI Pipelines Succeeded
Documentation:

[ ] documentation complete, PR opened in fidesdocs
[ ] documentation issue created in fidesdocs

[ ] Issue Requirements are Met
[ ] Relevant Follow-Up Issues Created
[ ] Update CHANGELOG.md
[ ] For API changes, the Postman collection has been updated

Small change to accommodate what @seanpreston / @allisonking / @NevilleS added for the old workflow in which ConsentRequests can be submitted under a fides user device id only.  The new workflow shares the endpoint that creates ConsentRequests from the privacy center, and needs to be able to handle that the primary ProvidedIdentity is actually associated with a fides user device id, not an email or phone number as previously assumed.
The new Privacy Preferences have separate columns for different types of provided identities for easier querying in consent reporting, so it's important we know which type of identity we're talking about.


Dynamically detect strip-depth for consistent pre/post-thud behaviour

@balena-ci retest

@ZubairLK this PR needs a Change-type entry apparently

@balena-ci retest


Subscription event sometimes does not fire.

Sometimes an incoming twitch subscription does not fire off the subscription websocket event to the attached client.  Test subscription events don't seem to be affected.

Fixed with PR #1

Fixed with PR #1


Fix some typos and improve some phrasing in confirms.md

(Just some arbitrary changes in passing as I was reading. Props for the very nice documentation by the way!)

@t-nelis Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

Thank you!


unregister_gdnative_types() now checks if discoverer pointer is NULL before deleting

unregister_gdnative_types() now checks discoverer pointer to see if it is NULL
before deleting.
Reason: When selecting a godot project to edit (Win10) in the dialog, the
discoverer_callback() wasn't called before unregister_gdnative_types() thus discoverer was NULL.

I submitted a PR for this crash at #11058 this is a fix for the symptom, the problem is that the project manager isn't the editor.

Yes, it seems so, but this check doesn't hurt anyway. 😛


Fix: UITabBarItem color options not working https://github.com/Vabere…

Fix for https://github.com/Vaberer/Font-Awesome-Swift/issues/69: UITabBarItem color options not working
With this fix you can correctly set the color of the FA icon and text when using tabBarItem.setFAIcon

thanks for your contribution


Feature/use marked js for markdown

Description
Removed local regex to use MarkedJS
The repo as per #25 comments was suggested.
When used correctly it offsets maintaining to others
https://github.com/markedjs/marked
Type of change

Mantainability fix

Pretty much the same thing but OK.
Not really, they use a very nice tokenizer and have a little of github flavored markdown parsing.
Can you please change the colors? Both of the characters and the background
Could you be more specific?

I've updated the CSS with some of the one used here on github.
anything in a code tag will look more  like this

Here are some screenshots in Windows with different themes, both in Insiders and Live versions of vscode


[ADD] Clicking custom share button now works as intended.

Pull Request Test Coverage Report for Build 983446739

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 16.701%

Totals

Change from base Build 983421128:
0.0%

Covered Lines:
142

Relevant Lines:
667

💛  - Coveralls


NameError: uninitialized constant JSON::Validator::SchemaParseError

When one passes an object, instead of a valid schema to the library it throws
NameError:
       uninitialized constant JSON::Validator::SchemaParseError

This seems to be because SchemaParseError is under JSON::Schema, while the call site is in JSON::Validator.
See lib/json-schema/validator.rb, line 572 for the call site.

Thanks for reporting that, I've just raised a pull request to fix it.

Thanks for the quick action.


Documentation: Glossary

I reopen the issue because there are probably more terms to add in the glossary later.


net: unclear how to confirm synchronously that a net.TCPListener is closed

What version of Go are you using (go version)?
1.9
Does this issue reproduce with the latest release?
Yes.
What operating system and processor architecture are you using (go env)?
GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/shivaram/go"
GORACE=""
GOROOT="/usr/local/go"
GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build866858012=/tmp/go-build -gno-record-gcc-switches"
CXX="g++"
CGO_ENABLED="1"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"

What did you do?
https://gist.github.com/slingamn/f1f2ef4a8d004e67a9b0f27b698a5b13
This is a simple TCP ping-pong server that uses channels for connection handoff. The wrinkle is that I'm trying to periodically close the connection from a separate goroutine, then open a new connection that rebinds to the address. (The non-toy use case for this is implementing reload of configuration files in a long-running server.) This is implemented by:

Using Listener.Close() to interrupt the Listener.Accept() call on the other goroutine
Using a channel to tell the other goroutine that it should call Listener.Close() itself and exit
Using a channel to wait for the other goroutine to complete its call to Listener.Close()

Observed behavior:

As written, the code appears to work (it runs correctly, and no races are reported under stress testing with -race)
When step 3 above (waiting for the other goroutine to call Listener.Close) is omitted (by running the test case with the command-line argument --waitforstop=false), the program crashes with: listen error: listen tcp :7777: bind: address already in use.

According to strace, the problem is that the close(2) call on the underlying socket has not executed by the time the goroutine executing main() tries to create the new listener; therefore the bind(2) call fails with EADDRINUSE. Based on my reading of the runtime's source code, this is because the underlying file descriptor is reference-counted, and close(2) is not called until the reference count drops to 0. (Since the runtime sets SO_REUSEADDR on the socket, the address can be rebound immediately after close(2).)
The problem I'm having is that based on my reading of the documentation, I'm unable to either prove that step 3 makes the code safe (i.e., that by the time <-wrapper.HasStopped finishes, the underlying socket has definitely been closed), or understand why the omission of step 3 makes the code unsafe (i.e., why the reference count does not immediately go to 0 after the main() goroutine calls Listener.Close()). Is there any way to get a synchronous guarantee that the underlying socket has been closed?
Thanks very much for your time.

				listener.Close()
				wrapper.HasStopped <- true

Creates a happens before relationship, a value can only be received from HasStopped if the sender, above has reached that step.
We don't the issue tracker to ask questions, so I'm going to close this. Please see https://golang.org/wiki/Questions for good places to ask. Thanks.

I'm sorry if the question was either misdirected or poorly phrased. I should clarify that I think this may indicate either a bug in the documentation or in the runtime. Specifically, TCPListener.Close is documented as "Close stops listening on the TCP address." The test case demonstrates that a single call to Close() (i.e., the one that occurs on the main() goroutine) is not guaranteed to release the address, in the sense of making it available for new bind(2) calls. It's not clear on the basis of the documentation whether this is the expected behavior, or whether there is any mechanism for ensuring that the address is released.


Use Box instead of DialogTitle, DialogContent, span

Codecov Report

Merging #124 (b48aa28) into main (a8fb2fd) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main      #124   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           43        43
  Lines          849       849
  Branches       348       348
=========================================
  Hits           849       849

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Feature/ Venue: use hide_fields in post_decision_stage()

Adding hide_fields to the post_decision_stage() so that PCs can hide/unhide fields without having to use the Post Submission button

@melisabok please don't merge yet, I am thinking we might have issues with single-blind venues and I'm checking

can I merge this now?

can I merge this now?

Yes, this should be ready


Move gist instances to a separate file?

Consider in conjunction with #305 and #556.

My current thinking is that we should not do this because they are referenced in the ontology. E..g., CurrencyUnit:
gist:CurrencyUnit
	owl:equivalentClass [
		a owl:Class ;
		owl:intersectionOf (
			gist:SimpleUnitOfMeasure
			[
				a owl:Restriction ;
				owl:onProperty gist:hasBaseUnit ;
				owl:hasValue gist:_USDollar ;
			]
		) ;
	] ;

What implications does this have then for namespacing - issue #305? Would we mix namespaces in a single file?
We could still implement #556 without either #305 or this.

It is common practice to use multiple namespaces in the same file,

gist:,
pleo:, pleox:
skos: etc.

I don't see this as a problem.

That is different: you are referring to using different namespaces in an ontology (file), whereas I am referring to defining terms in different namespaces in an ontology (file). My comment was unclear.

OK - that is an important distinction.  Even so, I think it is ok to use gistx namespace to define things in gistCore. If we really did not like it, then we could have them in a separate file and import them.  NOrmally the taxonomy fiel imports the ontology file, so it would be a bit backwards.  There are pros and cons.

Dan - it's ok to put the uoms etc in a separate file and reference them from the ontology without doing an import.
Delete gist:_greenwichTimeZone since no longer used.
The magnitudes one_X are no longer used either - they were used to define precisions of TimeInstants.
So the remaining instances are all uoms.
Dan - with pared down list, let's leave them in the ontology file.
Proposal - keep all units referenced in the ontology file (e.g., _second referenced by DurationUnit) and have a separate file for others (non-base units) - _day and others Michael has proposed adding (issue #460).
Rebecca - if we were to define Area using standard units (meter x meter) - which we don't currently but should - then we would also put the standard units in the gist file.
DECISION:

Keep units referenced in the ontology (these are base units) in the ontology file.
Also keep the existing derived units in the ontology file as exemplars of how to define derived units.
Put the big list from Michael into a separate file.

NO ACTION REQUIRED


Surfacing screen memory allocation

Description

Surfacing screen memory allocation
Motivation and Context

When doing intensive graphic like UI with gif, jpg and other elements, the needed graphic memory can be higher than the default allocated one
Surfacing for all M5Stack which has a screen the capacity to allocate manually this memory
The mechanism uses a default value and is compatible with all the current implementations

How Has This Been Tested?

Real devices
Screenshots
Types of changes

[x] Improvement (non-breaking change that improves a feature, code or algorithm)
[ ] Bug fix (non-breaking change which fixes an issue with code or algorithm)
[ ] New feature (non-breaking change which adds functionality to code)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Config and build (change in the configuration and build system, has no impact on code or features)
[ ] Dependencies (update dependencies and changes associated, has no impact on code or features)
[ ] Unit Tests (add new Unit Test(s) or improved existing one(s), has no impact on code or features)
[x] Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

[ ] My code follows the code style of this project (only if there are changes in source code).
[ ] My changes require an update to the documentation (there are changes that require the docs website to be updated).
[ ] I have updated the documentation accordingly (the changes require an update on the docs in this repo).
[ ] I have read the CONTRIBUTING document.
[ ] I have tested everything locally and all new and existing tests passed (only if there are changes in source code).
[ ] I have added new tests to cover my changes.

@josesimoes is it ok to ignore the SonarCloud warnings? It's mainly because of duplicate code.

@Ellerbach sonar analysis has a point on the assignment of the static field MemoryAllocationBitmap... any harm on not having it static?
As for the duplicated, it's OK.

Yes and no. I was thinking of best way to solve it. I need the field to be static and it's assigned only in the constructor of the screen as we can't have it static :-) So by design, this has to be like this.

Yes and no. I was thinking of best way to solve it. I need the field to be static and it's assigned only in the constructor of the screen as we can't have it static :-) So by design, this has to be like this.

Understood. Then go for merge!


made my first pr thanks to you, and again for making me step into open source, I have added my tech stack and why I like them

…n source

PR Type: ___

Affiliation: N/A

Ticket: N/A

Checklist:

[ ] I've read Contributing Guidelines
[ ] I agree to follow the Code of Conduct

ok thank you

I've fixed it, and have merged :) You're now visible in the readme
For future reference, don't forget to fill in the PR template when you open up a pull request, as it makes reviewing PRs easier :)


Imges outside of viewport would be loaded before user scrolls to them

Before I scroll to the images,they are loaded.What can I do to prevent

URL of the page which has the problem?

https://pay.sina.com.cn/zjtg

https://pay.sina.com.cn/zjtg
for the last page

In your JavaScript code you bind lazy load to images with class lazy which are inside .section8.
a("img.lazy").lazyload({effect:"fadeIn",container:a(".section8")})
In your html code there however is no such images.

I used template to input images.This is original code

@zhaoxueyin000 FYI your width and height values should not include "px"


[Bug][Connectors] Text And Json WriteStrategy lost the sinkColumnsIndexInRow

Purpose of this pull request
refer #3815
Fix text and json write strategy lost the sinkColumnsIndexInRow
Check list

[ ] Code changed are covered with tests, or it does not need tests for reason:
[ ] If any new Jar binary package adding in your PR, please add License Notice according
New License Guide
[ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
[ ] If you are contributing the connector code, please check that the following files are updated:

Update change log that in connector document. For more details you can refer to connector-v2
Update plugin-mapping.properties and add new connector information in it
Update the pom file of seatunnel-dist

@TyrantLucifer


MA - IITB newsletter item

[x] draft newsletter item
[x] review and finalize newsletter item
[x] decide on the date we want this to be in the newsletter
[x] translate?
[ ] review french translation
[ ] draft email for Phil to send to the IITB showcase team (asking to be near the top in the newsletter)
[ ] send to the IITB newsletter team

Sent to translation. Expected back on Sept. 10.

French translation (to be reviewed): https://014gc.sharepoint.com/:w:/r/sites/GCDevEx/Shared Documents/Change Management/Comms/IITB news_Micro-acquisition-pilot_FR.docx?d=wdf2e80e8432142d68f5209d1fb334f62&csf=1&web=1&e=BqJlrL
English version for reference: https://014gc.sharepoint.com/:w:/r/sites/GCDevEx/Shared Documents/Change Management/Comms/IITB news_Micro-acquisition-pilot.docx?d=w404740955e5842bda4958bdd95f5bb2e&csf=1&web=1&e=Ky2rFN


Preloading the script returns segfault

Preloading the scripts using require, require_once or opcache_compile_file will (segfault if the file uses aliases classes)[https://bugs.php.net/bug.php?id=78918]. It's confirmed by PHP team.
This is not a problem with the Preloader itself, but a bug on PHP 7.4. But I will left it has pinned until it's resolved in the next patch.

Fixed in latest PHP version


Create factorial.rb

Thanks for viewing my PR and merging it.

Hey @AnshumanGoel !
Great work.
You can follow me and star this repository for further updates.
Have fun 🙌🏼


[BUG] Latest Release Throws Exception When Using New Experimental Attached to SImple Calendar

When using the new experimental feature to attach SImple Weather to the Simple Calendar window, the following exception is thrown when trying to display the Simple Weather window from the Simple Calendar window.

To Reproduce
Steps to reproduce the behavior:

Update to Simple Weather 1.9.0.
Activate the "Attach to Simple Calendar" option in the Simple Weather options.
Restart Foundry.
Open the Simple Calendar window and click on the Simple Weather button.

Expected behavior
No exception should be thrown; the Simple Weather window should appear.
Screenshots
(above)
System info (please complete the following information):

macos 14.4.1
Arc 1.37.0 and Edge 121.0.2277.128
As GM

Foundry Virtual Tabletop: Version 11 Stable, 11.315
Game System: rqg, 3.4.2
Active Modules: 41
Performance Mode: 2
OS: Unknown
Client: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36 Edg/<IP_ADDRESS>
GPU: ANGLE (ATI Technologies Inc., AMD Radeon Pro Vega 64 OpenGL Engine, OpenGL 4.1)
Max Texture Size: 16384
Scene: 3000 x 3000 | Grid Size: 100 | Padding Percentage: 0.25
Walls: 42 | Ambient Lights: 6 | Ambient Sounds: 1 | Tiles: 4 | Tokens: 19
Actors: 43 | Items: 24 | Journal Entries: 190 | Rollable Tables: 0 |
Playlists: 8 | Compendium Packs: 84 | Chat Messages: 0

What version of Simple Calendar?  I may need to know your simple calendar settings, as I can't reproduce this (just the ones on the game settings screen for now - not all the detailed control settings).
Did you actually restart foundry or just accept the option in the settings popup to reload after adjusting the weather attachment setting?
How did you open the calendar - the toolbar on the left under journal notes or another way?

Also, maybe see if 1.9.1 fixes it?  I didn't do anything specifically to fix it, but I made some changes around the edges of that code that might have cleaned up some problem I can't see.

I'm not seeing any error codes, however, the popup doesn't display when I push the button. The window does appear when it isn't connected to Simple Calendar...
Simple weather 1.9.2
Simple Calendar 2.4.13
Accepted the setting and Restarted Foundry. No luck either way.

1.9.2 does not fix it (as @MapperD sees as well), but the error messages went away.
To answer the other questions:

Simple Calendar 2.4.13
I have SC opening per configuration option when Foundry starts. I toggled (with logout/login restart) between normal and compact (I had compact selected normally). No change. I toggled off the SC Load on Start option, logout/login, and started SC from the menu item. No change.
I logout/login between settings. I do not bounce the Foundry server. After the last setting change in #2, I bounced the entire server. No change.

Yep - v2.4.13 broke it already :)
Hopefully this isn't the beginning of a trend of continuous updates.  I'll work on a new release.

OK!  I believe 1.9.3 will fix this.  And going forward, every release of SC is likely to need a new release of this package.  Depending on frequency of those, I might fall behind and will need a reminder.  :)

Anyone following this issue please note that 1.9.2 will work with SC 2.4.3 and 1.9.3 will work with SC 2.4.13 (I've noted in the changelog/version notes which versions go together).  Versions between 2.4.3 and 2.4.13 may or may not work with one or the other, but no promises.

Closing but please reopen if this didn't fix it for you.


Incorrect schema inferred

Incorrect schema is being inferred.
For the xml
<request>     "test"                      <c></c>               </request>
Schema generated is -
root
|-- a: string (nullable = true)
|-- b: struct (nullable = true)
|    |-- c: string (nullable = true)
However the expected schema is -
root
|-- a: struct (nullable = true)
|    |-- _VALUE: string (nullable = true)
|    |-- b: struct (nullable = true)
|    |    |-- c: string (nullable = true)
Can  you point us how to resolve this issue ?

Can you change your format? I'm not sure this type of mixed format is supported not. Ideally you'd have <value>"test"</value><c></c>

There are different combinations of such types of xml in our project. Figuring out these combinations may not be possible.
Since this is a valid use case, are there any chances of fixing it or if it is worth trying for us to contribute to spark-xml and fix it?

Your best bet is indeed to propose a fix. There are a few related issues here about mixed content in children. I think it's a little harder than it sounds, as this isn't the type of XML the library was really designed for. Still probably possible to implement

This is pretty much exactly the use case in https://github.com/databricks/spark-xml/issues/415 where we had some more discussion; see also https://github.com/databricks/spark-xml/pull/416 . Just closing this for now as a duplicate


python error

from: can't read /var/mail/main.nepali
from: can't read /var/mail/main.english
from: can't read /var/mail/time
/home/computebox/Documents/github/nepali-datetime-applet/main.py: 5: /home/computebox/Documents/github/nepali-datetime-applet/main.py: True: not found
/home/computebox/Documents/github/nepali-datetime-applet/main.py: 9: /home/computebox/Documents/github/nepali-datetime-applet/main.py: Syntax error: "(" unexpected

What's the python version you're running? It works with python 3. I tested it again, it works fine & I also added installation procedure, be sure to add a virtual environment as described there. Let me know if that solves it.
The error logs show nothing like python, how does it not recognize it's the builtin boolean syntax True? Please check once again.

Let me check

working now.


Add shorthands notifyReloading and notifyStopping

Hi Erèbe, cool library! I'm using it in production.
It would be nice if you could add the shorthands:
notifyReloading :: IO (Maybe())
notifyReloading = notify False "RELOADING=1"

notifyStopping :: IO (Maybe())
notifyStopping = notify False "STOPPING=1"

Having support for FDSTORE=1 and FDNAME would be nice as well but I haven't thought about a good API for that yet.
https://www.freedesktop.org/software/systemd/man/sd_notify.html#

I added those shortcut and bumped the version to hackage (1.0.6 now)
I took a look at the implementation for FDSTORE and FDNAME in libsystemd, and sadly they use ancillary data to pass file descriptors with the message and as far as I know there is no equivalent in Haskell for that.
I can add it but I have to add more c code (should I depend on libsystemd directly ?) and I have to find time to test it properly.

Hello I have added the support for FDSTORE and FDNAME, you can have a look at it
https://hackage.haskell.org/package/systemd . The new version is the 1.1.0.
I tested the code on my machine with success, but tell if it is working on your side too.

Nice work!
I'm using 1.0.6 at the moment. I will try out the FDSTORE functionality later.
Thanks a lot.


Docker Integration

This pull request allows users to deploy Lychee through docker using the codebase itself, rather than some third party wrapper such as kdelfour/lychee-docker.
This youtube video demonstrates the code in action.
Resons for Development
It looks like the Lychee used to support building through docker, but then using kdelfour/lychee-docker became the official way, but the problem with this is that the third party wrapper may get out of sync with the codebase. For example, if a new branch needs a new package, then its easier for that branch to just edit the Dockerfile here for when it is ready to be merged into master.
Also, it looks like the kdelfour image is not being kept up-to-date. The last time an image was pushed was 8 months ago.
Another factor is that the kdelfour image uses php 5.5 instead of this integration which uses 5.6. Php 5.5 isn't supported anymore, and 5.6 only has security updates. It would be good to upgrade to 7.0 or 7.1 which this should make somewhat easier (ties into my first point).
Lastly, the kdelfour image works based on using an internal MySQL server. As somebody else has pointed out, it's much better practice to keep the database outside the application container, either by using another container, or by just running your own MySQL server. In this case you can do either, and just pass the details in using environment variables.

If I may suggest something, it'd a great idea to move to Alpine Linux as a base, instead of Debian Jessie. More and more official images are migrating to Alpine since it's lightweight and more suitable for containers (in the vast majority of cases).
I'm the author of wonderfall/lychee, if my work can help (it's not a lot a work, I prefer to keep it simple, and it's working flawlessly for my needs).

@Wonderfall I have seen a lot of people move over to alpine linux, and to be honest, I'm not too fussed about what distribution is used for the container, as long as we have the docker build inside the project rather than outside for the reasons stated in the pull request:

...the third party wrapper may get out of sync with the codebase. For example, if a new branch needs a new package, then its easier for that branch to just edit the Dockerfile here for when it is ready to be merged into master.

By having docker integration in a project, there is one known environment to build and test against that is supposed to work. If people decide to deploy in some other manner with different versions of PHP etc, then it is their own fault if something breaks either immediately or in the future after an update.
The main reasons for sticking with a base image like Debian or Ubuntu rather than switching to Alpine, is that its probably easier for people who wish to deploy manually, or set up their own dev environments. I believe a lot of developers are fairly familiar/used to deploying on debian/ubuntu in their day-to-day life, compared to Alpine which I believe is aimed squarely at things like docker containers. They would not have a hard time reproducing their dev environment by reading through the Dockerfile. One can mostly just replace RUN with sudo. This is also good for developers to set up their dev environments for a rapid iteration cycle, rather than having to build their container every time they make a change to the code. Admittedly, they could dev inside the container using SSHFS, but even I didn't stick to that.
The size of the base image doesn't really affect the build process much, but does affect the deployments if users are just pulling from the dockerhub instead of building their own container. However, the difference in the size between the two base images is 51.36MB, and 29.92MB. Yes its nearly twice the size, but only 21.44 MB size difference.
In conclusion, I believe go ahead with alpine if a lighter weight final docker image is most important, or stick with debian/ubuntu if you want to make it easier for other developers to provide contributions to the project and actually test their changes against the build environment.

As I'm not a developer at all, I was only interested in final deployment (and at this perspective I only see advantages for Alpine Linux). Now if you say it's better for dev, I obviously can't say the contrary.

@Wonderfall sorry, I didn't mean to say that Debian is better than alpine Linux for development. I was just trying to make the case that it might be easier for other people to contribute if the environment is debian/ubuntu based as I think more people are generally more familiar with those distros. I could be wrong and perhaps Alpine linux is way more popular than I realize. A good example of what I'm saying is that I can easily take this pull request further and implement ssl handling, but I'd have a bugger of a time figuring that out with Alpine, but maybe other's can take care of that.
I really don't want to come across as x is better than y. Alpine is clearly a lighter image that is gaining popularity in the docker sphere.

Alpine is terrible, when you use something, that unsupported by his community, like RabbitMQ.

Can we just merge this and if the community decides Debian is not suitable change it as and when? This pull request is better than our current situation. If there is an actual issue with the pull request, then let me know and I will try to address it.

Why isn't this merged yet? I would love a docker image for lychee.

Meanwhile, this one works : https://hub.docker.com/r/linuxserver/lychee/

There are multiple working images : https://hub.docker.com/search/?isAutomated=0&isOfficial=0&page=1&pullCount=0&q=lychee&starCount=0

Any updates on this?

This PR will be closed because I'm not actively working on Lychee anymore. The repository of Lychee will stay available, but the main development continues under the Lychee Organisation. A fork maintained by the community.


use env vars for config

This replaces the settings.json file with environment variables for configuration.

We should probably cast the various numeric values as integers when they're used, as env vars will all be strings by default.

This branch is not ready because of broken test coverage.


test: Make scriptnum test a unit test

The scriptnum tests (https://github.com/bitcoin/bitcoin/pull/14816) is a roundtrip test of the test framwork. Thus, it would be better suited as a unit test. This is now possible with the introduction of the unit test module for the functional tests. See https://github.com/bitcoin/bitcoin/pull/18576
Useful skills:
Basics of the Bitcoin Core functional test framework.
Want to work on this issue?
The purpose of the good first issue label is to highlight which issues are suitable for a new contributor without a deep understanding of the codebase.
You do not need to request permission to start working on this. You are encouraged to comment on the issue if you are planning to work on it. This will help other contributors monitor which issues are actively being addressed and is also an effective way to request assistance if and when you need it.
For guidance on contributing, please read CONTRIBUTING.md before opening your pull request.

Hi Marco! I'd like to work on this! :)

@gillichu Great! Before you start contributing, familiarize yourself with the Bitcoin Core build system and tests. Refer to the documentation in the repository on how to build Bitcoin Core and how to run the unit and functional tests. Once that is done, you are all set and can start working on this issue.
If you need more help getting started, please refer to the following resources:

https://medium.com/@amitiu/onboarding-to-bitcoin-core-7c1a83b20365
https://jonatack.github.io/articles/how-to-review-pull-requests-in-bitcoin-core

Let me know if you have any questions.


M3-1870 Display Volume Configuration on Volume Creation.

change: VolumeConfigDrawer -> VolumeConfigForm.
change: Added display of Volume configuration in global VolumeDrawer.
remove: Removed configDrawer from VolumeLanding.
change: VolumeActionsPanel onCancel and onSubmit made optional (although ended up not being used).
change: Display VolumeConfigForm on successful volume creation.

Coverage increased (+0.04%) to 31.745% when pulling 572f1a597522da64f8b25c6bc3ac3a12f6c23240 on rjstires:M3-1870 into 722876a7a590525a048f6a05e028cc74666f0bcd on linode:develop.

Unrelated from this PR, but I found that when attaching an existing volume to a Linode (by means of the Linodes Volume form, no error appears.


Remove disabling of web ui buttons

change for #9481
remove button disable logic for FileView and Browse
kept disable logic in Paginator but changed color of selected item for extra clarity

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/4600/
Test PASSed.

@calvinjia PTAL, thanks

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/4601/
Test FAILed.

@tieujason330 Thanks for the fix! Do we still need the bookkeeping for lastFetched or any other state we used to facilitate this?

@calvinjia Good catch for lastFetched, I removed it from the edited components

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/4604/
Test PASSed.

alluxio-bot, merge this please.


aichat sidebar

red, you're going to have to resolve the conflicts here -- including migrate to use clsx (instead of classnames) and the new "yarn modern".

closing, since I think this is the old PR.  I don't want to get confused.


Fix typo in manifest.json

Docs Build status updates of commit 0b92af1:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/concepts/connectors/connectors-creating.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


fix #384

This shouldn't be merged right away (it's too invasive to merge until the 1.1.0 development window); there's no need to review it right now either. But it's done so I thought, might as well file it now.

Nice, good change


Slide Transition from bottom to top Repainting systemNavigationBarColor

This is my first time posting in Github, apologise if confusing content.
I have to my system navigation bar color set in main.dart as follow:
SystemChrome.setSystemUIOverlayStyle(SystemUiOverlayStyle.light.copyWith(
        statusBarColor: Colors.white,
        systemNavigationBarColor: Colors.white,
        systemNavigationBarIconBrightness: Brightness.dark));

However, when I tried to write my own transitionBuilder from bottom up for page route, I realised the System Navigation Bar Color changed back to default.
Widget Code as follow:
        Navigator.push(context,
            PageRouteBuilder(
                opaque: false,
                pageBuilder: (BuildContext context, _, __) {
                  return FilterPage();
                },
                transitionsBuilder:
                    (___, Animation<double> animation, ____, Widget child) {
                  return SlideTransition(
                    position: Tween<Offset>(
                      begin: Offset(0.0, 1.0),
                      end: Offset(0.0, 0.0)
                    ).animate(animation),
                    child: child);
}));

Flutter doctor as below:
[✓] Flutter (Channel master, v0.10.2-pre.99, on Mac OS X 10.14 18A391, locale en-GB)
[✓] Android toolchain - develop for Android devices (Android SDK 28.0.3)
[✓] iOS toolchain - develop for iOS devices (Xcode 10.0)
[✓] Android Studio (version 3.2)
[✓] VS Code (version 1.28.2)
[✓] Connected device (2 available)

The FAB will route trigger the page route animation:

Once clicked, the System Navigation Bar color changed back to default (black):

Not sure if this is the way, but I solved with by added fade transition to the child of slide transition:
return SlideTransition(
                    position: Tween<Offset>(
                      begin: Offset(0.0, 1.0),
                      end: Offset(0.0, 0.0)
                    ).animate(animation),
                    child: FadeTransition(
                      opacity: Tween<double>(
                        begin: 0.0,
                        end: 1.0
                      ).animate(animation),
                      child: child));

I'm facing the same issue and I can confirm this is the solution: https://github.com/flutter/flutter/issues/23715#issuecomment-434171893


Update font docs to include note about wrapping fonts in quotes

I updated the font docs to include a note and example about wrapping certain font names in quotes.

Thanks!


copyq: 3.7.3 -> 3.8.0

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/copyq/versions.
meta.description for copyq is: '"Clipboard Manager with Advanced Features"'.
Release on GitHub
Compare changes on GitHub

Checks done (click to expand)

built on NixOS
/bin/sh passed the binary check.
1 of 1 passed binary check by having a zero exit code.
0 of 1 passed binary check by having the new version present in output.
found 3.8.0 with grep in /nix/store/pjqxhcy5digl4naaasnmv200rkkh5qjk-CopyQ-3.8.0
directory tree listing: https://gist.github.com/3925eec9e8b29598b59764d8de3936ec
du listing: https://gist.github.com/c72a7333f5afc71e7128c5b0c84ed877

Rebuild report (if merged into master) (click to expand)

3 total rebuild path(s)
1 package rebuild(s)
1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
0 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)
First fifty rebuilds by attrpath
copyq

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/pjqxhcy5digl4naaasnmv200rkkh5qjk-CopyQ-3.8.0 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
Or, build yourself:
nix-build -A copyq https://github.com/r-ryantm/nixpkgs/archive/282426b6ed2cb25113be14af1e936a182c2e755a.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/pjqxhcy5digl4naaasnmv200rkkh5qjk-CopyQ-3.8.0
ls -la /nix/store/pjqxhcy5digl4naaasnmv200rkkh5qjk-CopyQ-3.8.0/bin

Works here (we don't support copyq on osx yet, so no need to wait for the build).


Support Setup

Current progress on getting this running.
setup
Mac

brew install ghc cabal-install

or
download the installer from (here)[https://www.haskell.org/platform/mac.html].
then,

cabal update

cd ./nvds-lib

Error using cabal install so use brew

brew install pango

cabal sandbox init

You'll need to install nvds lib which is in the folder shown below

cd ./nvds-lib

cabal install
(note: this currently takes a few minutes? Is this expected?)

Error

cabal get pango-<IP_ADDRESS>

Error
Still getting an error
cabal: Leaving directory '/var/folders/0t/j57h3h3x4ns9km96jhb_zmxw3_4my0/T/cabal-tmp-36315/gtk2hs-buildtools-<IP_ADDRESS>'
Building lens-4.16.1...
Installed lens-4.16.1
cabal: Error: some packages failed to install:
cairo-<IP_ADDRESS>-FlHMbXIytdkJ24AuhwTIIm depends on cairo-<IP_ADDRESS> which failed
to install.
diagrams-cairo-1.4.1-4W03qxIZoMwXpuoIGYWLd depends on diagrams-cairo-1.4.1
which failed to install.
glib-<IP_ADDRESS>-8v3ZoQEqpf3Ib0SRPzybZI depends on glib-<IP_ADDRESS> which failed to
install.
gtk2hs-buildtools-<IP_ADDRESS>-9uxkFCuHbD1DY12djFrAtw failed during the configure
step. The exception was:
ExitFailure 1
nvds-lib-<IP_ADDRESS>-FjJ99jVVqrCJBCSaxbYDg4 depends on nvds-lib-<IP_ADDRESS> which
failed to install.
pango-<IP_ADDRESS>-9Ppj0iNVrww8InFTamPfKW depends on pango-<IP_ADDRESS> which failed
to install.

Once installed you can goto a project and install and run it as shown below.
Example

goto a project folder e.g. fashion/Cubic-Limit-Series/
run >ghc Setup.

sorry, you should just use stack - https://docs.haskellstack.org/en/stable/README/
it should just work with that (say the cubic-limit-series one folder):

install stack
cd Cubic-Limit-Series
stack setup
stack build
stack exec -- Cubic-Limit-Series -w 1000 -o a.svg


Fix TensorFlow Windows build

fix configure.py on Windows
Update nsync to make it work on Windows
disabled some failing tests.

@yifeif @gunan

Jenkins, test this please

@m3bm3b for nsync change. Mike updated the nsync binary to head from internal to make nsync work for cmake on macOS. Would that version also work for Windows @meteorcloudy?

@yifeif Just checked, yes it will work for Windows.

Jenkins, test this please

I'll re-enable these tests in #12680


Orbit camera preset

We need a good orbit camera style preset for the three build, similar to the orbit camera we had in the old version.

This is badly needed - hard to test without it. I tried to create one from the old preset, but it didn't work out as it used to.

Here's what i'm talking about:
http://vizor.io/fthr/orbit-camera-preset/edit
This should be plugged into the VR Camera ...

obsoleted by new cameras


Image Template Creation hangs on creating if StagingResourceGroup already exists

Team,
I have attempted to create a Azure VM Image Builder template using the 'stagingResourceGroup' parameter with the resource ID of an existing and empty resource Group. The Image template deployment remains in progress and the image template is stuck on creating. This completely 'hangs up' the service. I've successfully used the stagingResourceGroup parameter with a non-existing staging resource group and the service successfully creates the resource groups and gives the user-assigned managed identity Contributor rights to this resource group. I've even tried to grant the user-assigned managed identity the same rbac permissions to the pre-existing resource group in advance with the same hung results.
Thanks,
Shawn Meyer
CSA-E

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 9ef2d683-1557-7097-0415-ea67a0350718
Version Independent ID: 20667a9c-cd22-ce77-d4d6-61ac10d380c8
Content: Create an Azure Image Builder Bicep file or ARM JSON template - Azure Virtual Machines
Content Source: articles/virtual-machines/linux/image-builder-json.md
Service: virtual-machines
Sub-service: image-builder
GitHub Login: @kof-f
Microsoft Alias: kofiforson

@shawntmeyer
Thanks for your feedback! We will investigate and update as appropriate.

@shawntmeyer
Thanks for bringing this to our attention.
I'm going to assign this to the document author so they can take a look at it accordingly

@kof-f
Can you please check and add your comments on this doc update request as applicable.

Thanks for your dedication to our documentation. Unfortunately, at this time we have been unable to review your issue in a timely manner and we sincerely apologize for the delayed response. If you are still experiencing a problem, you might want to move this question to Microsoft Q&A: https://learn.microsoft.com/en-us/answers/tags/94/azure-virtual-machines.  #please-close


Add arguments to object() changes

It seems like the "child_added", "child_changed", "child_removed", and "child_moved" limiting events are only exposed on the .list() method and not .object() via typings.
Is that by design? If not. I'd like to file this feature request :)

Object is only value by design. What use case do you have for needing events on an object?


add feature Recomendation dot env editor

its very cool editing env file without using nano on terminal when server is in production mode.
also if it can do artisan command in voyager its amazing.
https://ibb.co/d5oTDw

This is more suitable as a hook, since then people can just install that hook if they want the .env editor.

Production servers should be using system environment variables, not .env file(s).
I second @marktopper's suggestion to make this into a Hook instead of adding it to the core.


[webapi][02.echo with counter] Sample crashes when running it

Sample information

Sample type: \samples\
Sample language: webapi
Sample name: 02.echo-with-counter

Describe the bug
When running the sample, the following error gets thrown in the served page:
Could not find file 'C:\Users\username\Documents\Repos\BotBuilder-Samples\samples\csharp_webapi\13.Basic-Bot-Template\BasicBot.bot'.
Description: An unhandled exception occurred during the execution of the current web request. Please review the stack trace for more information about the error and where it originated in the code.

Exception Details: System.IO.FileNotFoundException: Could not find file 'C:\Users\username\Documents\Repos\BotBuilder-Samples\samples\csharp_webapi\13.Basic-Bot-Template\BasicBot.bot'.

Source File: C:\Users\username\Documents\Repos\BotBuilder-Samples\samples\csharp_webapi\13.Basic-Bot-Template\App_Start\BotConfig.cs    Line: 34

To Reproduce
Steps to reproduce the behavior:
Since there's no README in the sample ( see #109 )

Open the project
Build the solution
Run the project
See error in the served URL

Expected behavior
Sample should run without any problems since there's no required services that should be deployed in order to work.
Proposed solution
Change the endpoint configuration in the .csproj files to a unique port per sample. This change would require changing the .bot files endpoints too.
Additional context
The .csproj files, seems to have the same endpoint configuration URL. Per example see line 191 of the EchoBot.csproj file.
At the EchoBot.csproj file, the  <WebProjectProperties> is the same as the BasicBot.csproj file
<WebProjectProperties>
    <UseIIS>True</UseIIS>
    <AutoAssignPort>True</AutoAssignPort>
    <DevelopmentServerPort>2190</DevelopmentServerPort>
    <DevelopmentServerVPath>/</DevelopmentServerVPath>
    <IISUrl>http://localhost:3978/</IISUrl>
    <NTLMAuthentication>False</NTLMAuthentication>
    <UseCustomServer>False</UseCustomServer>
    <CustomServerUrl>
    </CustomServerUrl>
    <SaveServerSettingsInUserFile>False</SaveServerSettingsInUserFile>
</WebProjectProperties>

When running a sample, all the endpoints in the solution get served in the IIS web servers thus overriding the last served page in the process and provoking unexpected behavior when running the samples.
[bug]

Closed due to Microsoft#744


Use BTreeMap for forex rate serialization so that they are sorted by key

I think we can close this down. The other forexes do not experience this issue.


Bump CAPAS to 0.1.23

Issue #, if available:
EKS-A added hostname config in https://github.com/abhay-krishna/cluster-api/pull/14, which creates duplicated entries for hostname as CAPAS also appends the value. It causes BR cluster provision failure.
[settings.network]
hostname = "chy-test-control-plane-1-q78ck"

[settings.network]
hostname = "chy-test-5sbrd"

Description of changes:
https://github.com/aws/cluster-api-provider-aws-snow/pull/123
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/lgtm


Multiple aatp.exe process

What steps will reproduce the problem?
1. Have the Rom Toolbox apk at the folder
2. Open It, a aatp.exe process is created
3. Close the explorer and redo the steps, and new, and new, and a new aatp.exe
will be created.

What is the expected output? What do you see instead?
The apk have not icon, and a lot of aatp process opened using resourcers

What version of the product are you using? On what operating system?
apksellext 2.1 win7 x64 sp1

Please provide any additional information below.
Also, when apkshellext is installed, zip and rar don't show icons and open
context menu become a pain.

Original issue reported on code.google.com by<EMAIL_ADDRESS>on 2 Jun 2013 at 5:17

This issue is finished, someone should close it.


Add switch --nunjucks to add the Nunjucks template engine

This is by far my favorite template engine and it would be pretty sweet if this generator could automatically wire this up as the default template engine.
https://mozilla.github.io/nunjucks/
It is pretty simple to configure express.js to use nunjucks:
var app = express();

nunjucks.configure('views', {
    autoescape: true,
    express: app
});

app.get('/', function(req, res) {
    res.render('index.html');
});

(above snippet taken from https://mozilla.github.io/nunjucks/getting-started.html)

SGTM. Would you be willing to put together a PR? It should be pretty straight-forward.

Hi @kruncher a PR was created to do this, but when I reviewed it and dig into it, I found the following things (from #119):

I was also just browsing their issues and it looks like they don't really want to deal with the Express.js integration anyway: mozilla/nunjucks#611


Sending docs to record center

How do we use this connection in a site to send documents to record center? Apparently the "Send To Location" has been removed from team sites now. What's the new way?
Thanks.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7cb2447b-a827-0d50-ee81-5b6f603dc5fb
Version Independent ID: 4ac95806-98f8-cf56-5562-8419b3c4bc4b
Content: Manage a connection to a document center or a records center in SharePoint Server
Content Source: SharePoint/SharePointServer/sites/manage-a-connection-to-a-document-center-or-a-records-center.md
Service: unspecified
GitHub Login: @bentoncity
Microsoft Alias: stevhord

I've asked the product team who owns this area about this and will address the topic when I receive more information.

After talking with the product team they agree this is a high priority item and will work to get this operational. No timeline but this sounds promising.


Emit deprecation warning for duplicate files with default duplicate strategy

Instead of failing.
See https://github.com/gradle/gradle/pull/10143 which introduced the change to fail the build on duplicates.

@lptr PTAL!

@lptr PTAL!


Initial calendar view setting

Allows to set the default view in the plugin settings.
This currently works only for desktop, I don't really know how to implement the mobile version since the check gets done relying on the screen dimensions. The first and immediate solution I can think of consists of adding two different rows in the settings (one for mobile, one for desktop), but maybe it could result overwhelming.
Fixes #124

Personally, I think that two different rows in Settings makes sense, since folks often want to see different views depending on the device they're on.

Thanks for the feedback, I added the mobile option too.


how to use flux loras with text encoder keys with diffusers?

resulting lora weights from setting train text encoder to true is incompatible with diffusers load_lora_weights. the script networks/convert_flux_lora.py does not convert the text encoder keys either.

@kohya-ss i'll train one next week and send it to you, but i don't think diffusers also trains t5xxl


Co-locate metrics worker code with the worker

https://trello.com/c/3ixGroQO/469-apply-retry-logic-for-digest-runs
This repeats a similar refactoring of the RecoverLostJobsWorker 1,
which has the benefit of keeping the 'lib' directory lean.

Love a bit of refactoring @benthorner!
One comment - if we're moving these classes under app shouldn't we be refactoring these *Exporter classes into their own exporters directory and dropping the namespace? From having a nosey through the code this seems to be the common practice for the other workers and their called upon classes. Some examples are the Archive worker and it's archive query class or the process messages worker and it's matched message generation service.
What do you think?

Thanks @1pretz1 - we can but try!
I think I see where you're coming from: there's a precedent for grouping unconventional code like "queries" by type. That makes sense when it's an application-wide concern: many parts of the app need to do complex queries. And "services" is a well-established concept in many of our apps.
Thinking about the exporters: they're only used in one place, for one purpose. I argue they shouldn't have their own top-level namespace. While we can always shove "misc" code in lib/, it's helpful if we can bring related code closer together, without making a mess. We take a similar approach for some of the code in Content Publisher.
How are you seeing it now?

Okay I see where you're coming from @benthorner, thanks for explaining.
By that thinking should we also move the classes in the providers directory to the delivery_request_service dir as they're only used by DeliveryRequestService and similarly only serve one purpose (giving us the provider when sending emails)?

@1pretz1 sure, good spot (/ what have I started 😱). I've added another commit to do that - slowly this app gets less special.

Sure, I've done that @1pretz1 - unfortunately this isn't something we can lint for, as it depends on the point when the parent class gets required.


Add support for Synchronised Clips with a Speed Effect

Currently we support speed effects WITHIN Synchronised Clips, but not on the Synchronised Clips themselves.

This has been fixed in FCPXMLReport.


Support Bitdeer as provider

Description
Bitdeer is a cloud computing platform that provides computing power for cryptocurrency mining.
In the AI age, Bitdeer also provides multiple managed AI models (For example, llama2, mistral, etc.) API services.
Tasks

[x] https://github.com/pingcap/tidb.ai/pull/97
[x] https://github.com/pingcap/tidb.ai/pull/107
[x] https://github.com/pingcap/tidb.ai/pull/114
[ ] API support streaming mode

Currently we don't plan to support bitdeer as a new provider, it may be can be integrated by openai-like provider.


[Bug report] remove redundant memcopy when reading raft snapshot

Describe the bug
this bug fixed before but be reopen caused by code merge
Environment
3.1.0

#1549


NV hangs when Z3 returns unexpected answer

For instance if Z3 returns an error then NV hangs and doesn't display anything.
We should adjust the behavior such that the error message gets propagated and the program terminated.

Do you have a particular example that displays this?

Um not of the top of my head. I faced this issue when I made a mistake in the SMT encoding causing Z3 to return an error message and NV would just hang leaving me to wonder what was going on.


wrong backtrace line numbers for 3rd party libraries

Here's how to repro.  Linux ubuntu.  From a crystal git repo:
diff --git a/src/socket.cr b/src/socket.cr
index fb25d63ae..3da6719cf 100644
--- a/src/socket.cr
+++ b/src/socket.cr
@@ -544,6 +544,7 @@ class Socket < IO
   end

   private def unbuffered_write(slice : Bytes)
+    raise "hello"
     evented_write(slice, "Error writing to socket") do |slice|
       LibC.send(@fd, slice, slice.size, 0)
     end

Use it somehow:
crystal$ ./bin/crystal  spec/std/openssl/ssl/socket_spec.cr
Unhandled exception in spawn: hello (Exception)
  from src/socket.cr:547:5 in 'unbuffered_write'
  from src/io/buffered.cr:135:14 in 'write'
  from src/openssl/bio.cr:31:7 in '->'
  from src/slice/sort.cr:147:5 in 'heapify!'
  from src/slice/sort.cr:153:10 in 'center_median!'
  from src/slice/sort.cr:204:0 in 'cmp'
  from src/slice/sort.cr:156:9 in 'center_median!'
  from ???
  from ???
  from ???
  from SSL_do_handshake
  from src/openssl/ssl/socket.cr:32:15 in 'initialize'
  from src/openssl/ssl/socket.cr:3:5 in 'new'
  from spec/std/openssl/ssl/socket_spec.cr:43:7 in '->'
  from src/fiber.cr:255:3 in 'run'
  from src/fiber.cr:47:34 in '->'
  from ???

Same trace, in gdb
$ gdb socket_spec
(gdb) b src/socket.cr:547
(gdb) r
(gdb) bt
#0  unbuffered_write () at /home/joshua/dev/crystal/src/socket.cr:547
#1  0x0000555555682c63 in write () at /home/joshua/dev/crystal/src/io/buffered.cr:135
#2  0x00005555555d5bb5 in -> () at /home/joshua/dev/crystal/src/openssl/bio.cr:31
#3  0x00007ffff7cfea33 in ?? () from /lib/x86_64-linux-gnu/libcrypto.so.1.1
#4  0x00007ffff7cfeed3 in BIO_write () from /lib/x86_64-linux-gnu/libcrypto.so.1.1
#5  0x00007ffff7cfd02a in ?? () from /lib/x86_64-linux-gnu/libcrypto.so.1.1
#6  0x00007ffff7cff3a7 in BIO_ctrl () from /lib/x86_64-linux-gnu/libcrypto.so.1.1
#7  0x00007ffff7f6d3bd in ?? () from /lib/x86_64-linux-gnu/libssl.so.1.1
#8  0x00007ffff7f71e0f in ?? () from /lib/x86_64-linux-gnu/libssl.so.1.1
#9  0x00007ffff7f6c89a in ?? () from /lib/x86_64-linux-gnu/libssl.so.1.1
#10 0x00007ffff7f589c4 in SSL_do_handshake () from /lib/x86_64-linux-gnu/libssl.so.1.1
#11 0x00005555556b0890 in initialize () at /home/joshua/dev/crystal/src/openssl/ssl/socket.cr:32
#12 0x00005555556b06c9 in new () at /home/joshua/dev/crystal/src/openssl/ssl/socket.cr:3
#13 0x00005555555d78ad in -> () at /home/joshua/dev/crystal/spec/std/openssl/ssl/socket_spec.cr:43
#14 0x0000555555614123 in run () at /home/joshua/dev/crystal/src/fiber.cr:255
#15 0x00005555555d2c96 in -> () at /home/joshua/dev/crystal/src/fiber.cr:47
#16 0x0000000000000000 in ?? ()

Appears crystal is identifying some lines as part of the crystal std lib crystal files (heapify et al) that are actually part of a different library.

There's a general "debug info is sometimes wrong" issue. Could you comment there instead of creating a new issue? Thank you!

Sounds good, moved to #7471

This particular one seems fixed, I guess, though the file location changed, it looks better.
Unhandled exception in spawn: hello (Exception)
from src/crystal/system/unix/socket.cr:215:5 in 'unbuffered_write'
from src/io/buffered.cr:136:14 in 'write'
from src/openssl/bio.cr:31:7 in '->'
from ???
from BIO_write
from ???
from BIO_ctrl
from ???
from ???
from ???
from SSL_do_handshake
from src/openssl/ssl/socket.cr:32:15 in 'initialize'
from src/openssl/ssl/socket.cr:3:5 in 'new'
from src/openssl/ssl/socket.cr:43:7 in '->'
from src/primitives.cr:266:3 in 'run'
from src/fiber.cr:92:34 in '->'
from ???


[WIP] Support for automatically shimming dynamic libraries

I've opened this PR to get some feedback on my approach for automatically shimming dynamic libraries (as per https://github.com/rust-lang/miri/issues/11)
The current implementation uses libffi to generate a call to the underlying function, using the type information provided by the arguments. Using ripgrep as a test, this code successfully shimmed a call to 'libc::readlink'
The major unresolved question is how to deal with pointers. There are two cases we need to handle:

'Input pointers' - raw pointers created in Miri and passed into foreign code, either directly or through a struct/wrapper
'Output pointers' - raw pointers created in foreign code and returned out to Miri, either as a return value or by writing into a structure.

To handle 'output pointers', we could add a new variant to rustc_mir::interpret::place::Place (e.g. `Place::Raw') to handle ffi pointers. We wouldn't be able to track any extra information for these kinds of pointers, since they would be a raw address pointing somewhere into the Miri process.
A Place::Raw would be created for any pointers returned by a foreign function (either directly or wrapped in another type). All reads/writes to a Place::Raw would be implemented by directly writing/reading from the underlying pointer, since we can't know when C code might write/read from it.
'Input pointers' will be much tricker. We need to be able to support C code writing directly into Miri-controlled memory. Obviously, this will need to bypass all of the normal StackedBorrows code, since we can't control how the pointer is written to. We might want to create a separate struct in Miri to hold the backing allocations for all such pointers - this would reduce the chance of C code corrupting internal Miri state, and would make it easier to reason about the lifetimes of the raw pointers we create into such allocations.
However, there are tricky scenarios that we need to handle. Consider code like this:
#[repr(C)]
#[derive(Debug)]
struct MyStruct {
	my_field: libc::c_int
}

extern "C" {
	fn extern_one(ptr: *mut MyStruct);
	fn extern_two();
}

fn foo() {
	let mut my_struct = MyStruct { my_field: 27 };
	unsafe { extern_one(&mut my_struct as *mut MyStruct); }
	println!("My struct: {:?}", my_struct);
	unsafe { extern_two() };
	println!("My struct: {:?}", my_struct);
}

What can we say about this code, especially w.r.t how it should interact with stacked borrows?
As soon as we call 'extern_one', we have to assume that my_struct can be modified by C code at any point, for the rest of its lifetime. That is, we need to assume that the raw pointer it receives might be stored somewhere, and later used by extern_two. This means that any reads/writes from normal Miri will need to go through the same memory used by C code, so that we properly observe/propogate modifications to it. This reminds me a little of intptrcast - when we expose a pointer to foreign code, we force it to take on a 'definite' representation for the rest of its existence.
Notes:

Currently, my shimming code doesn't handle aggregate types. However, it shouldb't be too difficult to support shimming arbitrary structures.
The rust libffi crate has a high-level API for making function calls. However, it requires that the return type be specfified at compile-time, which makes it useless for our purposes. As a result, I use a combination of the higher-level API and the raw bindings to the C libffi library to create and call the shims.
This PR currently only supports Linux. However, it should be possible to port this to Windows and OS X without too much effort.
I make no attempt to dlopen any dynamic libraries that the target application links to. We should be able to extract this information from the arguments passed to miri by cargo
On Linux, we could attempt to support staticly linked C libraries as follows: link all of the required static libraries into a single archive, and then build a shared object which exports all of the symbols from that static library. However, I have no idea if this would actually work for any real-world applications.

Wow, that's pretty impressive! I called @oli-obk crazy when he originally suggested this. :D
In terms of "how to do this", I don't have many things to say as I haven't tought about this very much. It's also not currently a priority for me, so I am basically fine with anything that works. ;)  However, there's the usual caveat that this should have as little impact as possible on the remaining code. An interpreter is a subtle thing to write, getting good test coverage is hard, and we defend against that by striving for maximal code clarity. We don't always achieve that though.^^ But good abstractions are key, and I feel our place/operand system is currently working very well.
I think this is a feature that I'd like to see off-by-default; by allowing the interpreted code to do FFI calls it can cause arbitrary UB, that seems like something that the user should opt-in to.

'Output pointers'

Why does this need a new Place variant? If this is really one-way communication, it could just take the result that it got back, turn it into a byte slice, and then create a regular Miri allocation for that byte slice.

'Input pointers'

Yeah, this is hard. My feeling is it is better to consider this out-of-scope for now.
And as you noted, for such allocation there is basically no hope of doing any checks -- I am not just talking about Stacked Borrows, even uninitialized memory cannot be tracked any more. That seems in direct contradiction with Miri's goals as a tool for detecting UB. If you need that kind of FFI, maybe a sanitizer or valgrind are better tools?

Why does this need a new Place variant? If this is really one-way communication, it could just take the result that it got back, turn it into a byte slice, and then create a regular Miri allocation for that byte slice.

That prevents us from observing any other writes made by C code. As a real-world example, consider libc::__errno_location. We need code like this to work:
let errno_ptr = unsafe { libc::__errno_location(); }
unsafe { libc::read(/* something */); }
let read_errno = unsafe { *errno_ptr };
unsafe { libc::write(/* something else */); }
let write_errno = unsafe { *errno_ptr };

With your approach, read_errno would always equal write_errno, which is incorrect.

That seems in direct contradiction with Miri's goals as a tool for detecting UB. If you need that kind of FFI, maybe a sanitizer or valgrind are better tools?

I agree that this should be considered out of scope for now. However, I think it would make sense to consider adding it at some point in the future. Given that Miri is currently the only way of detecting UB in rust code, I think it would be useful to eventually be able to run Miri on arbitary rust code (even if the overhead can be very high).
Specifically, I think suporting 'input pointers' would still be compatible with detecting UB in the rest of a Rust program. While FFI usage necessary 'infects' (in the sense of preventing us from doing UB checks) anything we take a pointer to, it need not propagate further through the program. If we have code like:
#[repr(C)]
struct MyFFIType { ... }

struct MyWrapper {
	normal_field: u8,
	ffi_field: MyFFIType
}

We won't be able to run proper UB checks on ffi_field, assuming that a pointer to it gets passed to C code. However, we can certainly enable stacked borrows for normal_field - as well as any struct containg a MyWrapper.
From what I've seen, most FFI code in libstd and other crates tends to already be written in this fashion - normal repr(Rust) types are exposed through the API, while dedicated #[repr(C)] structs are used to communicate with C. Miri could still check the vast majority of the program, assuming that FFI usage is properly encapsulated (as it really should be).
Tl;dr - I think it could be very useful to have Miri support 'input' pointers - even if we can never check everything, we can still check a lot of things. This would enable usages like running a Tokio echo server and client through Miri - while it would probably be incredibly slow, it would allow us to check an end-to-end test of the whole async io stack.

That prevents us from observing any other writes made by C code. As a real-world example, consider libc::__errno_location. We need code like this to work:

Oh, so this is two-way then. But once it's two-way, how does that not have all the same difficulties as 'input pointers'? It's C writing into memory that Miri "controls". Once you have that mechanism, you can implement 'input pointers' by enabling Miri to turn a "normal" allocation into a Raw one. Since all our pointers in Miri are "symbolic", existing pointers just keep working.
Your proposal suggested to have Place::Raw, but wouldn't it make more sense to have "raw allocations"?  Otherwise you'll also need Pointer::Raw and I don't know what else.
And I think raw allocations could be implemented with just a few extra machine hooks in librustc_mir, so the complexity would be very manageable.

Given that Miri is currently the only way of detecting UB in rust code

That's not true, there's also valgrind and various sanitizers.

I think it would be useful to eventually be able to run Miri on arbitary rust code (even if the overhead can be very high).

The plan we (Niko Matsakis and me) had during my internship was that eventually there would be a valgrind mode that implements Stacked Borrows, and that should be able to handle FFI. That sounds more realistic to me than, say, being able to run the part of Firefox that is written in Rust in Miri to check it for UB...

Tl;dr - I think it could be very useful to have Miri support 'input' pointers - even if we can never check everything, we can still check a lot of things.

Agreed!

@Aaron1011 are you still working on this?
My thinking is that some more design work is needed before implementation can start in earnest. In that case, I'd prefer to close the PR (to keep the PR list clean) and discuss the design on the issue.

Closing for now to keep the PR list clean; @Aaron1011 feel free to reopen if you want to pick this up again.


Fixed the behavior of backspace key when using search_key=None

When search_key=None, if we press backspace as the first character, the word is entered literally ("backspace") as the search term.
If the search_key is None and backspace is pressed, do nothing. (Do not set the search_key to "backspace".)
Partially resolves https://github.com/IngoMeyer441/simple-term-menu/issues/41 (The issue with accented characters mentioned in the issue description is not handled.)

tab is causing the same problem and as you know left and right cursors cause crashes, potentially there are others as well
So the definitive solution is probably to only allow printable characters with if wcswidth(next_key) >= 0 like it is done when adding to search text. When I have some time I might give it a try.


Suggestion

https://github.com/xan-crypto/CurveZero/blob/d082f394bec403fd91e07db51755f6b9fffa9e62/Core/CZCore.cairo#L90
for authorised_callers() function id suggest adding a mapping in CZCore or TrustedAddy that maps address to 1 if address is an authorised actor instead of writing all if statements.

not sure I follow this, ultimately regardless of what you store, you need to compare the caller (any addy) to a list of valid addys (auth list) at the time of call. Not sure how storing a mapping to 1 solves that problem. Can you perhaps add a code snippet, else we can discuss on the weekly call

Will close for now. Happy to chat through whenever you want.


in helm install ， searcher enable_endpoint is invalid

https://quickwit.io/docs/configuration/node-config#jaeger-configuration
enable_endpoint is valid in this doc

but  install helm with https://artifacthub.io/packages/helm/quickwit/quickwit  to use , get error :
2024-09-06T09:18:09.300Z  INFO quickwit_cli::service: quickwit version: 0.8.2 (x86_64-unknown-linux-gnu 2024-06-17T16:36:47Z 42766b8)
2024-09-06T17:18:09.302739161+08:00 ✘ command failed: failed to parse node config file:///quickwit/node.yaml
2024-09-06T17:18:09.302750760+08:00
2024-09-06T17:18:09.302754010+08:00 Caused by:
2024-09-06T17:18:09.302757175+08:00     0: failed to parse YAML file
2024-09-06T17:18:09.302760603+08:00     1: unknown field enable_endpoint, expected one of aggregation_memory_limit, aggregation_bucket_limit, fast_field_cache_capacity, split_footer_cache_capacity, partial_request_cache_capacity, max_num_concurrent_split_searches, max_num_concurrent_split_streams, split_cache
2024-09-06T17:18:09.302763937+08:00

Thanks for reporting this. Here is the mistake: the enable_endpoint is the jaeger section, not searcher one.

I just fixed it here
I will be fixed on the website soon.

Thank you for your reply. I like your efficiency


USER STORY: Add ability to user react router to link to hash links

As a User I can use the side menu to navigate to anywhere in the site so that get to any page or section from anywhere
Acceptance Criteria

Acceptance Criteria 1: The side bar navigation links work from anywhere in the site.
Acceptance Criteria 2: The link will bring you to a certain section of the page from any page.

Tasks

[ ] Task 1: Change react router to hash mode.
[x] Task 2: Update the links to work from any page.

Needed to install HashLink to solve the problem instead of changing to HashRouter


Templates: Reset page/element selection and globalStoryStyles

Task Description
As mentioned at https://github.com/google/web-stories-wp/pull/6988/files#r614312125, some templates do have current (the page selection) and selection (the selected element(s)) set.
We should reset those in all templates.
current should be set to null
selection should be an empty array
A new test should be added in packages/templates/src/test/raw.js to test for this.

Does it matter if this info is in the raw or not? Just double checked the function that loads in the templates and seems that it selectively takes the selected properties off the raw data and ignores others:
https://github.com/google/web-stories-wp/blob/37908fd08b72de83621f074136e4ebd189200eba/packages/templates/src/getTemplates.js#L23

Where does it selectively take selected properties there? That function does ...data.default and data.default is the whole template object, including current and selection

Amendment: globalStoryStyles in templates should also be reset. It's not used when opening a template in the editor, so not a big deal if it's there, but it makes sense to remove everything that's not really related to the template itself.


Which branch moving forward?

Hey @jreese - I know previously it's been mentioned that the python branch was going to be the future moving forward, but I've noticed that's had no commits for ~6 months, whilst master/C branch has had a few commits this year.
Has the plan changed, or will python still be "the future"? Just want to make sure I'm using the right stuff, and building my docker images with the right stuff for others as well :)

There are still some blocking issues with the Python branch, like failing on multi-user instances, but I haven't had much time to work on the branch.  For the time being, the master branch should still be considered the "official" version of znc-push.

No worries - appreciate the response @jreese :)