Ng build fails always using aws codebuild

🐞 Bug report
Command (mark with an x)

[ ] new
[x] build
[ ] serve
[ ] test
[ ] e2e
[ ] generate
[ ] add
[ ] update
[ ] lint
[ ] xi18n
[ ] run
[ ] config
[ ] help
[ ] version
[ ] doc

Is this a regression?
Yes, the previous version in which this bug was not present was: ....
No
Description
We're using aws codebuild for building and the build process always fails and exits without providing any info , it says : Command did not exit successfully , the full message is : "Command did not exit successfully node --max-old-space-size=4096 node_modules/@angular/cli/bin/ng build --prod exit status 1".
🔬 Minimal Reproduction
I'm going to mention aws codebuild support team response as following :
"""
Hi Rami,
I hope you are doing well and taking good care of your health during this pandemic. Thank you for getting back to us with the requested information. I am glad to assist you further.
Before I commence, I would like to apologise for the delayed response. As I was replicating the issue in my environment, it took me a while to get back to you. I hope that you understand it and co-operate with me.
Investigation made -
Initially I have thoroughly gone through the "verbose" log you have sent me on the case. However, even in the verbose logs, I was unable to observe any particular error messages. Later, I have made use of the "package.json" file to install the same dependencies which you are using to test the build.
I installed the dependencies and used them in the CodeBuild environment to build a sample application. To replicate the issue exactly, I have made use of the same compute type and compute environment in the codebuild project that you are making use of. The environment information where I have tested the sample application is given below. However, the issue was not reproduce-able in my environment.

type 	                            LINUX_CONTAINER
image 	                          aws/codebuild/standard:3.0
computeType 	                    BUILD_GENERAL1_MEDIUM
privilegedMode 	                  false
certificate 	                    blank
registryCredential 	              blank
imagePullCredentialsType 	        CODEBUILD
Later, As my area of expertise is AWS CodeBuild, to gain more understanding about the Angular CLI and "ng build" I have gone through the Angular documentations. After that, to check if there are any existing issues in the angular CLI, I checked all the existing Git issues of the Angular CLI. I found the actual issue on git where, the "ng build" just fails without any particular reason. Below is the link to the issue description.
Errors in child compilers not reported, process exits without info #17565 - https://github.com/angular/angular-cli/issues/17565
The issue affects "ng build" and "ng serve" commands. Accordingly, If a compilation includes child compilations as is the case when using worker-loader for example (or many other webpack loaders/plugins) the build process can fail and exit without providing any info but the exit code being 1.
The replication steps for this error with the replication repository is given in the issue description itself. I have tried this both in my local environment and in CodeBuild as well.
When I tried in the Local machine the build looks like completed as the error is not visible in the console. The local build output which I ran is given below:

8c859032105a:angular-child-compiler-error user$  node --max-old-space-size=4096 node_modules/@angular/cli/bin/ng build --prod
Browserslist: caniuse-lite is outdated. Please run next command npm update
Date: 2020-06-27T07:11:23.605Z
Hash: c773dc7753f32d162a5b
Time: 13047ms
chunk {0} runtime-es5.967b40d860653894bbb2.js (runtime) 1.45 kB [entry] [rendered]
chunk {1} main-es5.6a83abc16d1e39382351.js (main) 188 kB [initial] [rendered]
chunk {2} polyfills-es5.4e06eb653a3c8a2d581f.js (polyfills) 111 kB [initial] [rendered]
8c859032105a:angular-child-compiler-error user$ echo $?
1
8c859032105a:angular-child-compiler-error user$

You can see that the build looks completed in the local machine. However, the exit code of the command is 1. This can be the reason that the Build looks like working fine when it ran Locally in your case as well.
To replicate the issue in CodeBuild environment, I have made use of the below buildspec file and the replication was successful. You can use this buildspec for the further replication on you end.

version: 0.2
phases:
build:
commands:
- git init
- git clone https://github.com/nadavsinai/angular-child-compiler-error.git
- cd angular-child-compiler-error
- npm install
- node --max-old-space-size=4096 node_modules/@angular/cli/bin/ng build --prod --verbose
I have also tried with the angularcli vesrion 8.0.6 and 8.0.3 which is running in your environment. This version also has the same issue and the error is reproduce-able.
========================================================================================
Having said that, the issue seems more specific to the anularcli and application you are building rather than the CodeBuild environment. As I have just started with the Angular and My area of expertise is AWS CodeBuild, I may not able to debug the reason for the error. However, we can be sure that AWS CodeBuild is not having any direct relation with the issue we are observing. Rather, the issue is specific to angular and how it handles the compilation which includes child compilations. I hope that you understand this.
""""
🔥 Exception or Error

Command did not exit successfully node --max-old-space-size=4096 node_modules/@angular/cli/bin/ng build --prod exit status 1

🌍 Your Environment

Angular CLI: 8.0.3
Node: 12.16.1
OS: linux x64
Angular: 8.0.2
... animations, common, compiler, compiler-cli, core, forms
... language-service, platform-browser, platform-browser-dynamic
... router

Package                           Version
-----------------------------------------------------------
@angular-devkit/architect         0.800.3
@angular-devkit/build-angular     0.800.3
@angular-devkit/build-optimizer   0.800.3
@angular-devkit/build-webpack     0.800.3
@angular-devkit/core              8.0.3
@angular-devkit/schematics        8.0.3
@angular/cdk                      8.0.1
@angular/cli                      8.0.3
@angular/material                 8.0.1
@angular/pwa                      0.901.6
@angular/service-worker           8.0.3
@ngtools/webpack                  8.0.3
@schematics/angular               8.0.3
@schematics/update                0.800.3
rxjs                              6.4.0
typescript                        3.4.5
webpack                           4.30.0

Hi @ramimohammad, let's keep tracking this issue  #17565.
As a quick workaround to determine what's the error that you are encoutnering.
Modify<EMAIL_ADDRESS>by adding process.stdout.write(stats.toString() + '\n'); right above the // Log stats. comment.

Duplicate of  #17565


Status Bar Fixed

**Changed from navigationBarColor to statusBarColor ( and it worked )
**Added windowsLightStatusBar ( with boolean value: [true] so that status bar doens't become opaque
**Light and Dark theme colors implemented

@Redeem-Grimm-Satoshi Thanks!
Screenshots for the results can help reviewers immediately see results.
I'm having trouble reviewing the PR, have asked for help to review code.

@maprehensive thanks, let send screenshots

I tried these changes on an emulator and when I entered dark mode it did not seem to work. Perhaps once you send screenshots you will have identified the issue.

Yes I'm working on that, using android 9 and seems to have some issues with darkmode.

@wbrunette I forgot darkmode is made available from API 29 and higher and my android devices are Android 9 ( API 28 ),  that's where I had issues. Switching to Android 10 so I fix the issues and send the final PR


Remove TypeNode#has_attribute? and references to "attribute"

Resolves #9943.

TypeNode#has_attribute? is part of the public API and would need to be deprecated before complete removal. So the documentation should stay (supplemented by @[Deprecated("Use #annotation instead")]), and the implementation should issue a deprecation notice.
The implementation can be based on annotation, the AST methods can be removed right away.

If there is a better way of reporting warnings from the macro interpreter please let me know (Crystal is able to report deprecated macros defined in Crystal code, but src/compiler/crystal/macros.cr is purely documentation and doesn't actually define these methods).


TS3 Dream Launcher Closes

When I click play for The Sims 3 on steam, the dream launcher opens. At the bottom it tells me it is working on 15 tasks, when it gets down to 1 task, the launcher closes and never reopens again unless I hit play on steam. It is a repeating cycle of the same thing.

Hi! Is your Sims 3 installation new?
Also, what is the name of the Sims 3 folder in Documents on your computer?
Finally, have you successfully launched the game at least once?

Yes, I redid all installation, including dream launcher to be sure but I end up with the same issue
Documents > Electronic Arts > The Sims 3, is this what you mean? It is just called The Sims 3
Yes I have

I forgot to ask. Have you ever installed any mods, patches or anything else through the Launcher?
So I can try to reproduce the problem, could you zip your The Sims 3 folder of your Documents and post it here?

I've installed Alder Laker Patch and the Language Patch.
It says my file is too big to upload

Got it. Could you upload this compressed file to a cloud and post the link here?
This would be very necessary because with the files, it would be easier for me to try to reproduce the problem.

https://drive.google.com/file/d/1AigLRe71-20YVA8WBqGO82cjY85bG0Nx/view?usp=sharing
Let me know if that doesn't work, and thank you for helping! (:

Sorry for the delay, I had some issues to resolve, but I have already analyzed the folder you sent.
Unfortunately I was unable to reproduce the problem... :/
So that I can expand the test scenario, would it be possible for you to share your "Bin" folder? It can be found in the following directory...
<install_dir>\Game
Example...
I:\SteamLibrary\steamapps\common\The Sims 3\Game
The folder you send must have been edited only by Dream Launcher, to ensure the scenario is as close as possible to your scenario.


add hero and logo images.

added logo.svg & hero.jpg

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: kigateG sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


[issue] cannot delete invalid destinations from dialer list

A receiver was deleted during a scheduled reset of the servers mining dimension. currently i am unable to delete invalid destinations from the dialer and as this has happened multiple times there are several identical but invalid destinations listed in the dialer. there needs to be a method of deleting missing destinations from the dialer list
perhaps this should be accomplished by analyzer providing a dialogue to remove the destination if it cannot find the reciever

RFTools dimensions should preferably be deleted with /rftdim safedel and after that removing the dimension folder. Otherwise RFTools can get confused. But you can use /rfttp cleanup to clean up all invalid matter receivers from the dialer list to fix this issue now.

the dimensions where this occurs are the nether and the deep dark these are not dimensions managed by RF tools. but again the ability to delete invalid destinations is something that needs to be added

It exists like I told you in previous comment: /rfttp cleanup

/rfttp is a admin command there needs to be a public command to perform this function per dialer

Well for un oped players the way to do is is to manually remove the receiver. There is no need for a command to do this.

unless the receiver has been destroyed ... XD

Well if the receiver is destroyed in game (by breaking or explosion) it should normally be removed from the list. If the receiver is destroyed out of game by removing a dimension (dimension reset or something) then it is up to the person who does that (presumably an admin) to run the needed cleanup commands.

why not solve the issue completely by running cleanup each time the server restarts ?

Well the cleanup command has to load all dimensions that have (or had) a receiver in them so that could add a bit to startup time. Also if a dimension was corrupt but only triggered a crash on visiting/loading it then it would now crash all the time.

so coming full circle it should be fairly simply to add a dialogue when checking with a destination anylizer to delete invalid destinations after the check button has been pressed

In theory yes but I still feel this is not the responsibility of the player.
This feature would be really nice.
Jeremiah Grimsley
"All of humanity is in peril of extinction if each one of us does not dare,
now and henceforth, always to tell only the truth, and all the truth, and
to do so promptly — right now." - R Buckminster Fuller
On Thu, Oct 22, 2015 at 12:42 PM, McJty<EMAIL_ADDRESS>wrote:

In theory yes but I still feel this is not the responsibility of the
player. It is the admin that should worry about this
—
Reply to this email directly or view it on GitHub
https://github.com/McJty/RFTools/issues/362#issuecomment-150301881.

But its the player who ultimately has to deal with many bad destinations on their dialing device

Fixed in next release. Doing 'check' on an invalid destination will clean up all invalid destinations (not only the one that you were checking)


table_exists unit/integration test for NoSuchTableError

Implementation of table_exists method at Initialization level already exists bypassing it.
Unit Test for glue, sqlcatalog and dynamodb.
Integration test for glue and dynamodb.

Overall LGTM! The lint issue can be resolved by executing make lint

Thank you @HonahX and @kevinjqliu for all the feedback!

Thank you for the PR! Do you mind changing the PR title and description to match?

Thanks everyone! Merged!


KAFKA-15578: Migrating other system tests to use the group coordinator

Adding the use new coordinator flag to all the decorators in all the existing tests that use consumer groups.
The new group coordinator cannot be used with zookeeper so this combination will not run.

https://jenkins.confluent.io/job/system-test-kafka-branch-builder/5915/

https://jenkins.confluent.io/job/system-test-kafka-branch-builder/5930/


Report dill usage

Dill is a wrapper around pickle and thus is vulnerable to the same
threat. Dill documentation states that dill "is not intended to be secure
against erroneously or maliciously constructed data. It is left to the
user to decide whether the data they unpickle is from a trustworthy
source." (https://pypi.org/project/dill/)

Hi there, I cannot find a way to run the test defined at https://github.com/PyCQA/bandit/pull/347/files#diff-2f46466028791b674d0508626e0dc273R357. tox does not seems to invoque the tests under tests/functionnals. Am I missing something ?

Thanks. I amended my commit to pass the style checks.
Also, locally, the test file appears to be correct;
...
{2} tests.functional.test_functional.FunctionalTests.test_dill [0.184176s] ... ok
...

I wasnt sure but I do agree, rewritted. I set a different message to explain to end user what's going on.

Rewritted.


Storybook Integration Overview

Update Readme with Storybook integration section

We should mention that native and common stories have to be written in storiesOf format, whereas web can use CSF.
And also document that we can't use the docs plugin as it is not compatible with @storybook/react-native
(Since you are off the bench, If you don't have time to make these doc changes I'll do them Monday morning.)

@skywickenden this is a good idea, can you please add it to this Doc on Monday!


Prototype for defining Ensemble schema as typescript as generating json schema from there

Changing the json schema is hard and error-prone.
This change will prototype how developers would just define the schema as typescript and the json schema used by the editor will be generated from that.

@imjaadFRT checked in as we discussed


Fix the issue of Android add2app build fails on Android when assets are read-only

Description
With the latest dev build (Flutter 1.10.14-dev), the flutter:copyFlutterAssets task fails when the assets being copied are read-only. This can happen when a source control tool makes files read-only.
Related Issues
https://github.com/flutter/flutter/issues/43686
Tests
I added the following tests:
The change fixes the build issue.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I signed the CLA.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[ ] I updated/added relevant documentation (doc comments with ///).
[x] All existing and new tests are passing.
[x] The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
[x] No, this is not a breaking change.

@shihchanghsiungsonos This LGTM. Would you be able to modify https://github.com/flutter/flutter/blob/master/dev/devicelab/bin/tasks/module_test.dart to make some assets read only?

@shihchanghsiungsonos This LGTM. Would you be able to modify https://github.com/flutter/flutter/blob/master/dev/devicelab/bin/tasks/module_test.dart to make some assets read only?

@shihchanghsiungsonos This LGTM. Would you be able to modify https://github.com/flutter/flutter/blob/master/dev/devicelab/bin/tasks/module_test.dart to make some assets read only?

Do you mean to make, for example, "isolate_snapshot_data" as read only in module_test.dart and run the test "../../bin/cache/dart-sdk/bin/dart bin/run.dart -t module_test"?

Yes -- After this line, change the file permission to read only, then build again and verify that it currently fails and then with your fix, it passes.

@shihchanghsiungsonos let us know if you need any additional help with the tests for this PR

@shihchanghsiungsonos let us know if you need any additional help with the tests for this PR

Thanks for the follow up @xster !
Sorry for the delay. I haven't ran this before.
When I tried this comment:
../../bin/cache/dart-sdk/bin/dart bin/run.dart -t module_test
I am getting these errors:
Error: Could not resolve the package 'args' in 'package:args/args.dart'.
Error: Could not resolve the package 'path' in 'package:path/path.dart'.
Error: Could not resolve the package 'flutter_devicelab' in 'package:flutter_devicelab/framework/manifest.dart'.
Error: Could not resolve the package 'flutter_devicelab' in 'package:flutter_devicelab/framework/runner.dart'.
Error: Could not resolve the package 'flutter_devicelab' in 'package:flutter_devicelab/framework/utils.dart'.
bin/run.dart:9:8: Error: Not found: 'package:args/args.dart'
import 'package:args/args.dart';
       ^
bin/run.dart:10:8: Error: Not found: 'package:path/path.dart'
import 'package:path/path.dart' as path;
       ^
bin/run.dart:12:8: Error: Not found: 'package:flutter_devicelab/framework/manifest.dart'
import 'package:flutter_devicelab/framework/manifest.dart';
       ^
bin/run.dart:13:8: Error: Not found: 'package:flutter_devicelab/framework/runner.dart'
import 'package:flutter_devicelab/framework/runner.dart';
       ^
bin/run.dart:14:8: Error: Not found: 'package:flutter_devicelab/framework/utils.dart'
import 'package:flutter_devicelab/framework/utils.dart';
       ^

Is there anything I need to make sure before running this test? Thanks for the help!

I don't think I've seen these issues so I'm not 100% sure but flutter update-packages could likely solve it if you run it at the Flutter repo's root.

I don't think I've seen these issues so I'm not 100% sure but flutter update-packages could likely solve it if you run it at the Flutter repo's root.

Thank you! It fixes the errors. Will update once I verify the fix.

cool, good to hear. Thanks for your contribution.

cool, good to hear. Thanks for your contribution.

I don't have much luck.
After these:
        await exec(gradlewExecutable,
          <String>['app:assembleDebug'],
          environment: <String, String>{
            'JAVA_HOME': javaHome,
            'FLUTTER_ANALYTICS_LOG_FILE': analyticsOutputFile.path,
          },
        );

I add line to exec 'chmod +r' to make flutter_assets/isolate_snapshot_data read only. But, always get file not found. what's the correct file path for flutter_assets/isolate_snapshot_data?
Thanks for the help!

cool, good to hear. Thanks for your contribution.

I don't have much luck.
After these:
        await exec(gradlewExecutable,
          <String>['app:assembleDebug'],
          environment: <String, String>{
            'JAVA_HOME': javaHome,
            'FLUTTER_ANALYTICS_LOG_FILE': analyticsOutputFile.path,
          },
        );

I add line to exec 'chmod +r' to make flutter_assets/isolate_snapshot_data read only. But, always get file not found. what's the correct file path for flutter_assets/isolate_snapshot_data?
Thanks for the help!

I found the path. But, change the file permission after await exec(gradlewExecutable is probably too late, since the apk has been created.
I think @blasten 's suggestion to change the asset to read only within await exec(gradlewExecutable. what's the right line I should add to change asset's file permission before the apk is created. Thanks!

@shihchanghsiungsonos what about adding a user read only .txt file to flutter_assets and then verify that the file copied into packageAssets.outputDir is user-readable and writable?  The output dir should be build/app/intermediates/merged_assets/<build-variant>/out/flutter_assets/.

@shihchanghsiungsonos what about adding a user read only .txt file to flutter_assets and then verify that the file copied into packageAssets.outputDir is user-readable and writable? The output dir should be build/app/intermediates/merged_assets/<build-variant>/out/flutter_assets/.

Will give it a try. Thanks!

@shihchanghsiungsonos Are you interested in continuing with this PR?

@shihchanghsiungsonos Are you interested in continuing with this PR?

Yes. But, having problem to verify the way @blasten is asking.

@shihchanghsiungsonos somehow this PR gained a huge diff (looks to be the result of a non-standard git merge).

Just commit the change to update module_test test case, not sure why there are so many files changed?

@shihchanghsiungsonos somehow this PR gained a huge diff (looks to be the result of a non-standard git merge).

Just did:
git fetch updtream
git pull
git commit -a -m
git push origin dev-local

@christopherfujino should I start another new PR and close this one?

@shihchanghsiungsonos that might be easiest. When you start a new branch, make sure you create your branch by starting from master. If you branch off of stable, it won't cleanly merge to master.

@shihchanghsiungsonos that might be easiest. When you start a new branch, make sure you create your branch by starting from master. If you branch off of stable, it won't cleanly merge to master.

Cool. Thanks!

@shihchanghsiungsonos that might be easiest. When you start a new branch, make sure you create your branch by starting from master. If you branch off of stable, it won't cleanly merge to master.

Cool. Thanks!

Closing in favor of your new PR, thank you!

I have created a new PR: https://github.com/flutter/flutter/pull/50047
Close this one.


[WIP 1.21.0] Fix/flaky DHT tests

Proposed changes
We found flaky DHT (ACN / libp2p) tests on windows.
Exit Code	Package
1       	valory\connections\p2p_libp2p
1       	valory\connections\test_libp2p

This is cause by termination of agents and subsequently checking if they have successfully terminated as part of the test. There is a more elaborate termination process present in BaseAEATestCase.teardown. However, did does not include the check for successful subprocess termination, which I have now included there. The results in failures in other tests, which may well simply reveal issues that went previously undetected.
Fixes
If it fixes a bug or resolves a feature request, be sure to link to that issue.
Types of changes
What types of changes does your code introduce to agents-aea?
Put an x in the boxes that apply

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist
Put an x in the boxes that apply.

[ ] I have read the CONTRIBUTING doc
[ ] I am making a pull request against the develop branch (left side). Also you should start your branch off our develop.
[ ] Lint and unit tests pass locally with my changes and CI passes too
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have checked that code coverage does not decrease.
[ ] I have added necessary documentation (if appropriate)
[ ] Any dependent changes have been merged and published in downstream modules

Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

fails on all platforms and python:
ERROR tests/test_skills/test_task_subprocess.py::TestTaskTestSkill::test_task_run_in_a_subprocess
the rest concerns various failures in tests/test_test_tools/test_test_cases.py::TestGenericCases accross the platforms without a clear pattern
note that an error is raised and not a test failed, as it should.

interesting failure here I've never seen before:
FAILED tests/test_helpers/test_exec_timeout.py::TestThreadGuard::test_cancel_by_timeout

another failure here I've never seen before:
tests.test_cli.test_utils.test_utils.InitConfigFolderTestCase testMethod=test_init_cli_config_positive
tests/test_cli/test_utils/test_utils.py:180:
-->  _init_cli_config()
E       FileNotFoundError: [Errno 2] No such file or directory: '/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/tmpyh4twl5c/cli_config.yaml'

this seems to indicate that cleanup of the tmp test

Codecov Report
Base: 94.26% // Head: 94.15% // Decreases project coverage by -0.10% :warning:

Coverage data is based on head (f03f5f1) compared to base (903686a).
Patch coverage: 70.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #336      +/-   ##
==========================================
- Coverage   94.26%   94.15%   -0.11%
==========================================
  Files         217      204      -13
  Lines       18859    18493     -366
==========================================
- Hits        17778    17413     -365
+ Misses       1081     1080       -1

Flag
Coverage Δ

unittests
94.15% <70.00%> (-0.11%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

aea/test_tools/docker_image.py
78.26% <ø> (ø)

aea/test_tools/test_cases.py
98.18% <70.00%> (+0.25%)
:arrow_up:

aea/helpers/__init__.py

aea/__init__.py

aea/registries/__init__.py

aea/agent.py

aea/contracts/__init__.py

aea/connections/__init__.py

aea/exceptions.py

aea/registries/base.py

... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Update code hosting domain entities' enrichment logic in Github and Gitlab plugins

Description
... so the code-hosting-related data collected by the Github and Gitlab plugins can be standardized and stored in the right format in the domain layer.
Action items

[ ] update Github plugin's enrichment logic
[ ] update Gitlab plugin's enrichment logic

Note: the scope of this issue is determined by #915, which means the conversion logic should align with the up-to-date schema of table repos, commits, and repo_commits
Linked issue
#700
Additional context
If the design in #700 changed, the enrichment logic should change accordingly.

duplicated with #915


Autofocus inside a wizard step gets ignored

Package
filament/filament
Package Version
^2.0
Laravel Version
9.32.0
Livewire Version
^2.5
PHP Version
8.1.6
Problem description
If you set autofocus->() to an input inside a step inside a wizard - it will be ignored.
Expected behavior
To set autofocus properly
Steps to reproduce
Set autofocus() on any input inside a \Step
Reproduction repository
https://github.com/dissto/filament
Relevant log output
No response

Fixed by #4408.


refactor(connlib): use phoenix-channel crate for clients

Resolves: #2158.

For this PR to be green, I needs the linked PRs I extracted out of it. Will leave as draft until then.

@conectado It would be nice to still get a review for this, once it is rebased on top main with the linked PRs merged, the tests should be green :)
(At least they were green before I extracted them all.)

@conectado Now rebased and ready for review.

The last commit does not fail the eventloop on tunnel errors. This is also what we currently do. I don't think it is correct but it is what we currently do and I see it out of scope of this PR to change that.
In https://github.com/firezone/firezone/pull/4015, I am refactoring the phoenix-channel to only return fatal errors. Once that is merged, we can continue here to only invalidate the client's token upon authentication errors.


Enable delete_comment and claim_reward_balance

These operations are needed to implement a full Steem web interface.
Related to #43 . But in case there is no generic broadcast, these two methods would be needed.

A generic broadcast has been impleneted since then.


Question on batch size

In the training code, the batch size is set to 16. There's a youtube video that explores many of the parameters of the net, but not larger batch sizes. In my experience with similar nets, used for non-musical purposes, a larger batch size allows the net to train more effectively. The limitation is that larger batches use up the GPU's memory more quickly. Is GPU memory the reason a batch size of 16 is used? If not, has there been any experimentation with larger batch sizes? I'm running Linux, and the training code doesn't work out of the box (pip can't find a version of onnyxruntime, for the GPU environment), so I haven't been able to play around with it yet.

I have gotten training working with Linux, just by installing python 3.9 instead of 3.11. I did a training run using the standard input file, and the provided overdrive.wav as the target, using a batchsize of 32. Got the same ESR as with batchsize 16. So, at least it's feasible to play with it.

The parameters that are the defaults are roughly what should be "good" based on some playing around with them, but I haven't thoroughly checked.
The goal I had in mind when setting the default parameters was to train quickly (i.e. wall time) to a reasonable level of accuracy, not use an overly-heavy model, and be reasonably reliable; not to:

To use as much of the GPU as possible (though that sometimes coincides with the real goal)
To get as good of accuracy as possible (ESR=0.01 seems plenty accurate to my ears in most cases.)

But, you should definitely play around with things if you've got other goals or if you've got a reamp that's behaving oddly.


No license specified

Would you care to specify a license under which others can use this library? http://choosealicense.com/

Note: I see that some files do have license headers, e.g. Company.java  and Person.java are Apache-licensed. However, some files do not specify any license, e.g. LinkedIn.java. Putting a LICENSE file in the top directory would resolve the ambiguity.

Ah, sorry @mike10004 , totally missed the notifications for this. I'll sort this out asap.

Right, thats added now, let me know if there's a problem with it.


fix: store rerender types

Codecov Report

Merging #966 (c0420ce) into master (ca159fe) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #966   +/-   ##
=======================================
  Coverage   48.93%   48.93%
=======================================
  Files          46       46
  Lines        1175     1175
  Branches      284      284
=======================================
  Hits          575      575
  Misses        600      600


Fix 'expected .. received ..' message for function arguments

For some reason, whenever type::function was expected, the argument order given to the checker is the other way around. This produces messages such as:

expected number, received function

when executing process_callback(100), whereas process_callback takes a sol::function as argument.
I'm not sure whether this is the case for any other types, but I didn't find any cases when I had a quick look.
PS I'm absolutely loving this library so far!

Derp.  Thanks for checking that: copy-paste programming flips me the bird once again..

 I just realized I edited the auto-generated single header file! Do you want me to fix the appropriate header?

 I was totally oblivious to the fact that I edited the auto-generated header that will be overwritten anyway.

SNRK. I'll shift the fixes over to the main header.
There's another "I'm an idiot" comment to be made here. Something about not even realizing it was in the auto-generated header and being the repo owner... :B

It's actually in both, so that's not even necessary :laughing:


B 16771 okta login

There are three tickets in this pull request
B-16771 & B-17148 & B-17153
Summary
Major changes

Login gov handlers switched to Okta.
Login gov tests replaced with Okta tests.
Login gov providers replaced with Okta goth providers.
Custom Okta provider wrapping for added functionality.
API URLs changes from login-gov to Okta.
Login gov auth has been replaced with Okta auth.
Introduced http mock tests that can be utilized for RESTful backend testing.
New libraries provided. This will be detailed in the minor mod.
Added additional API call inside of callback handling for added security and code exchanging between Okta.

It is incredibly unlikely this would impact any rate limiting due to our current high amount allotted.

Be aware:
Full login is not yet supported as of yet until Okta sessions have been implemented.
Verification Steps for Reviewers

Successful Okta login
Only error on login is unable to find identity
Internal server error after redirect (Remember, this is due to the lack of sessions! This doesn't mean Okta isn't working!).

Setup to Run the Code

Ensure you have chamber correctly configured
Ensure you do not have local environment variables that would replace Okta variables pulled from chamber

If you have an env variable that is the same name as the ones pulled, it will overwrite and break

How to test
Please see the automated auth_test.go file located here: pkg/handlers/authentication/auth_test.go

In a private browsing window, open up milmove under the customer, office, or admin domains
Click sign-in
Accept EULA
You should be redirected to Okta for login
Create an account if you do not have on yet, otherwise provide your existing credentials
After successful login (Also works for account creation), you should be redirected back to milmove
You should receive an internal server error due to sessions not being handled yet, however you should now successfully be authenticated into Okta.
Your server should have logged an identity error like so:

ERROR	authentication/auth.go:870	Error loading Identity.

Verify successful Okta login by navigating to the tenant and checking if you are logged in.

Example: https://test-milmove.okta.mil/

Verify after login if you click "sign-in" again that it will not prompt you for login, it will automatically redirect you back.

Frontend

Modified sign-in URL route from login-gov to okta

Backend

[x] Code follows the guidelines for Logging.
Code will require truss security review in this file: pkg/cli/auth.go

Reason being the word "secret" trips security. This can be put under review when merging to the experimental / staging location. Truss has already stated they would prefer if we pinged them in the PR to their branch.

This also includes the chamber secrets story for @danieljordan-caci. I already peer reviewed it when we PR'd the sessions branch into this login branch.


Display associated ID for claimed links

Would be nice to have the token id displayed in the table if it is possible to get it, which I guess it should be.
Motivation: I was trying to use the tool to avoid going link by link checking the ID of each manually.
Extra: Can the owner be displayed as well? probably yes, all if this is info that at list can be scrapped from the claim success page.
This will add some extra use cases to the app.

If that sounds reasonable I can even try to help 😄


Add files via upload

This is a emoji randomizer that changes emoji every time you run it. There are 11 emojis and 330 lines of code. Hope you enjoy-Nidhir Reddy Manne

[x] I have read the steps to getting a blot
[x] I have read all the submission requirements and follow them
[x] I am submitting art that...

[x] is algorithmically generated (will meaningfully change each time the program is run)
[x] is your own work that is not copied from somewhere else
[x] is drawable through the editor(does not use outside tools)
[x] doesn't call Math.random() (See the documentation on randomness)
[x] is drawable on Blot itself (doesn't have lines overlap more than 5 times)

[x] Doesn't overlap lines more than 5 times
[x] Fits in the working area of 125x125mm
[x] Doesn't rely on colour to look good

If you used based your art on something else, used a tutorial, or remixed it from something else, please link it here:
Lastly, link a picture of your art piece here:

Hello! Sorry it's been so long. The main reviewer has been swamped lately, so I wanted to give you a few hints so you have the best chance of getting a blot.
First, it would be great if you could name your PR and files according to the correct format (see directions here). This allows the automation to generate a preview link that makes it much easier for reviewers.
I love all the emojis you made! It looks like it took a lot of time to figure out all of those numbers. To get a blot, though, you'll need a little bit more work.
Currently, you're using a lot of draw lines using the fill option. Unfortunately, the blot machine does not know how to parse this, so you will need to submit a project not using the fill option at all to be eligible for a blot (you can have it on a toggle if you like it better with it, but you need to make it look good without using the fill option). I would suggest using diagonal lines to shade areas you want filled in as a replacement.
Other than that, I like all the emojis! I think you could do a little bit more with making certain elements of each emoji randomize within the face to make it perfect, but for now I would focus on converting your project to not use any fill lines.
I'm excited to see where you go with this!


Traceroute not working even after the Windows 10 Creator's Update

A brief description: The traceroute command is giving * * * for all hops

Expected results: It should return proper traceroute, like it work on command prompt

Actual results (with terminal output if applicable):
traceroute to google.com (<IP_ADDRESS>), 30 hops max, 60 byte packets
1  * * *
2  * * *
3  * * *
4  * * *
5  * * *
6  * * *
7  * * *
8  * * *
9  * * *
10  * * *
11  * * *
12  * * *
13  * * *
14  * * *
15  * * *
16  * * *
17  * * *
18  * * *
19  * * *
20  * * *
21  * * *
22  * * *
23  * * *
24  * * *
25  * * *
26  * * *
27  * * *
28  * * *
29  * * *
30  * * *

Your Windows build number: 1703

Steps / All commands required to reproduce the error from a brand new installation: Just simply run a traceroute command on any domain

I'm too facing the same problem.

Pretty sure this was addressed in the first RS3 insider builds.

@fpqc thanks for giving the link. First of all I am not a insider user as I use windows on my production PC. Besides what I can see is that in that note the build number was 16176, but I'm running the public version of the creator's update which is 1703 and the issue is still here, so I thought I should report it to see if this is a duplicate reporting or Microsoft needs to be aware of this.

1703 is the release #, its build # is 15063.

@isaumya and @somu1795 - Traceroute is still not fixed. We are aware of the issue.
@fpqc - I think the release notes for 16176 are somewhat confusing around traceroute, dig... because they make it sound like all these tools are now working. But, IP_MTU was one of the socket options that these tools were blocked on. But, there are other options left to enable traceroute fully.

It's still not working. Saying this:
traceroute to aol.com (<IP_ADDRESS>), 30 hops max, 60 byte packets
1  * * *
2  * * *
3  * * *
4  * * *
5  * * *
6  * * *
7  * * *
8  * * *
9  * * *
10  * * *
11  * * *
12  * * *
13  * * *
14  * * *
15  * * *
16  * * *
17  * * *
18  * * *
19  * * *
20  * * *
21  * * *
22  * * *
23  * * *
24  * * *
25  * * *
26  * * *
27  * * *
28  * * *
29  * * *
30  * * *

still not working,
version 1803

Same.  I can't even traceroute from within the Ubuntu shell inside of Winblows 10.

just change the protocol in the ip packet header to icmp, seems to work fine:
~$ traceroute -M icmp  yahoo.com
traceroute to yahoo.com (<IP_ADDRESS>), 64 hops max
1   <IP_ADDRESS>  0.408ms  0.313ms  0.303ms
2   <IP_ADDRESS>  3.066ms  3.604ms  3.451ms
3   <IP_ADDRESS>  8.750ms  8.038ms  8.064ms
4   <IP_ADDRESS>  5.426ms  5.754ms  5.603ms
5   <IP_ADDRESS>  5.841ms  5.689ms  5.512ms
6   <IP_ADDRESS>  5.316ms  5.358ms  5.844ms
7   <IP_ADDRESS>  15.203ms  15.555ms  16.110ms
8   <IP_ADDRESS>  33.588ms  30.942ms  32.177ms
9   <IP_ADDRESS>  36.838ms  36.965ms  36.639ms
10   <IP_ADDRESS>  35.490ms  35.474ms  35.009ms
11   <IP_ADDRESS>  36.906ms  36.946ms  36.724ms
12   <IP_ADDRESS>  36.975ms  57.647ms  48.738ms
13   <IP_ADDRESS>  35.240ms  34.788ms  34.372ms
then just create an alias in your .bashrc to:
~$ cat .bashrc | grep traceroute
alias traceroute='traceroute -M icmp'
alias t='traceroute -M icmp'
done deal.

@manilaboy1vic
That doesn't work for me. I get:
You do not have enough privileges to use this traceroute method. socket: Operation not permitted
and with sudo it's:
connect: Operation not supported
Any ideas?

Yeah I am not sure where manilaboy is coming from on this one. The $ prompt in that post doesn't suggest Linux root, so traceroute -M icmp wouldn't fly to begin with (without taking special sudoers steps, which are not mentioned, anyway). On 17744 and 18219 with traceroute 2.1.0 (ubuntu 1:2.1.0-2) the same fails on missing surface. This was run with wsl.exe running elevated.
An strace for the pedantry provided below, but "still not working" posts here are not especially constructive. You'll know when it is working because the status of this tracker will change when it does. In the meantime use tracert.exe with interop.
ken@DESKTOP-4UTIQSF:/mnt/c/Windows/System32$ sudo strace -ff traceroute -4 -M icmp google.com
execve("/usr/sbin/traceroute", ["traceroute", "-4", "-M", "icmp", "google.com"], 0x7ffff1af38b8 /* 15 vars */) = 0
brk(NULL)                               = 0x7fffcb519000
[... blah blah]
socket(AF_INET, SOCK_DGRAM, IPPROTO_ICMP) = -1 EACCES (Permission denied)
socket(AF_INET, SOCK_RAW, IPPROTO_ICMP) = 3
close(-1)                               = -1 EBADF (Bad file descriptor)
bind(3, {sa_family=AF_INET, sin_port=htons(0), sin_addr=inet_addr("<IP_ADDRESS>")}, 28) = 0
setsockopt(3, SOL_IP, IP_MTU_DISCOVER, [0], 4) = 0
setsockopt(3, SOL_SOCKET, SO_TIMESTAMP, [1], 4) = 0
setsockopt(3, SOL_IP, IP_RECVTTL, [1], 4) = 0
fcntl(3, F_SETFL, O_RDONLY|O_NONBLOCK)  = 0
connect(3, {sa_family=AF_INET, sin_port=htons(0), sin_addr=inet_addr("<IP_ADDRESS>")}, 28) = -1 EOPNOTSUPP (Operation not supported)

Try this.
sudo apt-get update
sudo apt install inetutils-traceroute
sudo apt install traceroute
~$ date
Tue Sep  4 12:30:42 DST 2018
:~$ traceroute -M icmp google.com
traceroute to google.com (<IP_ADDRESS>), 64 hops max
1   <IP_ADDRESS>  0.330ms  0.171ms  0.335ms
2   <IP_ADDRESS>  26.188ms  33.891ms  27.873ms
3   <IP_ADDRESS>  37.236ms  40.551ms  28.034ms
4   <IP_ADDRESS>  38.088ms  26.533ms  37.524ms
5   <IP_ADDRESS>  26.601ms  35.464ms  24.785ms
6   <IP_ADDRESS>  23.555ms  21.098ms  34.259ms
7   *  *  *
8   <IP_ADDRESS>  20.493ms  20.595ms  21.085ms
9   <IP_ADDRESS>  21.831ms  23.923ms  22.717ms
10   <IP_ADDRESS>  23.491ms  33.049ms  24.304ms
11   <IP_ADDRESS>  24.081ms  35.248ms  22.704ms
12   <IP_ADDRESS>  23.455ms  26.143ms  36.993ms
13   <IP_ADDRESS>  26.469ms  38.482ms  37.480ms
14   <IP_ADDRESS>  28.186ms  39.740ms  25.910ms
$ uname -a
Linux DESKTOP-4.4.0-17134-Microsoft #137-Microsoft Thu Jun 14 18:46:00 PST 2018 x86_64 x86_64 x86_64 GNU/Linux

sudo apt-get update
sudo apt install inetutils-traceroute
sudo apt install traceroute

That sequence is going to make a fine mess of /etc/alternatives because you've just installed two competing traceroute implementations. On Ubuntu 18.04, those are /usr/bin/traceroute.db "Modern traceroute for Linux, version 2.1.0" by Dmitry Butskoy and /usr/bin/inetutils-traceroute "traceroute (GNU inetutils) 1.9.4" by Elian Gidoni. The latter appears to be SUID, which explains why no sudo is needed. Neither work here (with different modes of fail for different reasons) when run in an elevated WSL instance, but that does at least explain what you are running.

Of course nothing works, traceroute is based on RAW SOCKETS and Windows forbids them "to avoid improper use". Unfortunatly there is only one option: Microsoft changes its policy in order to make WSL work and re-enables raw sockets (I don't think so) or we will never have a working traceroute

traceroute is based on RAW SOCKETS and Windows forbids them

Hold my beer

@therealkenc Unfortunately that doesn't work for me. I get the following:
`memphiz@BOB01:/mnt/c/Windows/System32$ cat /proc/version
Linux version 4.4.0-17134-Microsoft<EMAIL_ADDRESS>(gcc version 5.4.0 (GCC) ) #137-Microsoft Thu Jun 14 18:46:00 PST 2018
memphiz@BOB01:/mnt/c/Windows/System32$ nmap -sn --traceroute --send-eth microsoft.com
Starting Nmap 7.60 ( https://nmap.org ) at 2018-09-12 13:36 DST
Traceroute has to be run as root
QUITTING!
memphiz@BOB01:/mnt/c/Windows/System32$ sudo nmap -sn --traceroute --send-eth microsoft.com
[sudo] password for memphiz:
Starting Nmap 7.60 ( https://nmap.org ) at 2018-09-12 13:36 DST
pcap_open_live(eth0, 50, 1, 25) FAILED. Reported error: socket for SIOCETHTOOL(ETHTOOL_GET_TS_INFO): Socket type not supported.  Will wait 5 seconds then retry.`

Unfortunately that doesn't work for me

The implication was that it is possible (in the same way that doing a lot of stupid things like jumping off a roof is possible) not that it works. My screencap uses a third party driver not endorsed or recommended by MSFT. Or even endorsed or recommended by myself.
You'll know when traceroute is working because the status of this tracker (and #1349) will change when it does.

Would run cmd on Windows with administration and the enter bash in cmd the run traceroute work?

Would run cmd on Windows with administration and the enter bash in cmd the run traceroute work?

Nope, just tested it. Just gives you the list of * :)

Try running the trace route with source IP option

Would run cmd on Windows with administration and the enter bash in cmd the run traceroute work?

Nope, just tested it. Just gives you the list of * :)

For you, and for me. But not for manilaboy1vic and wobblybobz, for whom it works fine. But seriously, whether it works for them or not, straight up: if the traceroute enabling work was complete this issue would be closed. There would be much music and rejoicing. You'd know.

You guys realize im changing the proto to icmp right??
if you can ping google.com, which uses icmp, why cant you traceroute using icmp?? nix uses udp by default..
traceroute -M icmp
vic@DESKTOP-SVUEQK6:~$ traceroute -M icmp google.com
traceroute to google.com (<IP_ADDRESS>), 64 hops max
1   <IP_ADDRESS>  0.423ms  0.322ms  0.310ms
2   <IP_ADDRESS>  3.709ms  3.065ms  3.355ms
3   <IP_ADDRESS>  7.191ms  7.400ms  8.690ms
4   <IP_ADDRESS>  5.345ms  5.927ms  5.523ms
5   <IP_ADDRESS>  5.793ms  5.491ms  5.265ms
6   <IP_ADDRESS>  5.750ms  5.622ms  5.989ms
7   *  *  *
8   <IP_ADDRESS>  8.366ms  8.224ms  7.555ms
9   <IP_ADDRESS>  9.303ms  6.715ms  5.939ms
10   <IP_ADDRESS>  6.245ms  7.186ms  6.488ms
11   <IP_ADDRESS>  11.048ms  7.848ms  5.497ms
12   <IP_ADDRESS>  5.951ms  6.487ms  6.244ms
13   <IP_ADDRESS>  6.603ms  7.245ms  6.895ms
14   <IP_ADDRESS>  5.892ms  5.894ms  5.397ms
vic@DESKTOP-SVUEQK6:~$ uname -a
Linux DESKTOP-SVUEQK6 4.4.0-17134-Microsoft #285-Microsoft Thu Aug 30 17:31:00 PST 2018 x86_64 x86_64 x86_64 GNU/Linux
vic@DESKTOP-SVUEQK6:~$ whoami
vic
vic@DESKTOP-SVUEQK6:~$

heh, why are there lines thru my post

You guys realize im changing the proto to icmp right??

Your premise here is illiteracy.

shashilx@shashilx-omen:~~$ traceroute -M icmp aol.com
You do not have enough privileges to use this traceroute method.
socket: Operation not permitted
shashilx@shashilx-omen:~$ sudo traceroute -M icmp aol.com
[sudo] password for shashilx:
connect: Operation not supported
shashilx@shashilx-omen:~~$ su -
Password:
root@shashilx-omen:~# traceroute -M icmp aol.com
connect: Operation not supported
root@shashilx-omen:~# uname -a
Linux shashilx-omen 4.4.0-17134-Microsoft #285-Microsoft Thu Aug 30 17:31:00 PST 2018 x86_64 x86_64 x86_64 GNU/Linux
do not see for added ~ it's just added so the text not strucked

wow that is strange.
do this cmd pls:
dpkg -l | grep trace
you have the same as me?
I dont even have to sudo to run my traceroute.
vic@DESKTOP-SVUEQK6:~$ dpkg -l | grep trace
ii  inetutils-traceroute           2:1.9.4-3                         amd64        trace the IPv4 route to another host
ii  iputils-tracepath              3:20161105-1ubuntu2               amd64        Tools to trace the network path to a remote host
ii  ltrace                         0.7.3-6ubuntu1                    amd64        Tracks runtime library calls in dynamically linked programs
ii  mtr-tiny                       0.92-1                            amd64        Full screen ncurses traceroute tool
ii  strace                         4.21-1ubuntu1                     amd64        System call tracer
ii  traceroute                     1:2.1.0-2                         amd64        Traces the route taken by packets over an IPv4/IPv6 network
vic@DESKTOP-SVUEQK6:~$

was
shashilx@shashilx-omen:~~$ dpkg -l | grep trace
ii  iputils-tracepath                    3:20161105-1ubuntu2                 amd64        Tools to trace the network path to a remote host
ii  libbabeltrace1:amd64                 1.5.5-1                             amd64        Babeltrace conversion libraries
ii  ltrace                               0.7.3-6ubuntu1                      amd64        Tracks runtime library calls in dynamically linked programs
ii  mtr-tiny                             0.92-1                              amd64        Full screen ncurses traceroute tool
ii  strace                               4.21-1ubuntu1                       amd64        System call tracer
ii  traceroute                           1:2.1.0-2                           amd64        Traces the route taken by packets over an IPv4/IPv6 network
installed inetutils-traceroute and tried
root@shashilx-omen:~~# inetutils-traceroute -M icmp aol.com
traceroute to aol.com (<IP_ADDRESS>), 64 hops max
1   *  *  *
2   *  *  *
3   *  *  *
4   *  *  *
^C
root@shashilx-omen:~#
no changes

i am at a loss..
Im glad its working for me but thats so wierd...
full path maybe??
-I, --icmp                 use ICMP ECHO as probe
vic@DESKTOP-SVUEQK6:~$ /usr/bin/traceroute -I yahoo.com
traceroute to yahoo.com (<IP_ADDRESS>), 64 hops max
1   <IP_ADDRESS>  0.404ms  0.355ms  0.308ms
2   <IP_ADDRESS>  3.410ms  3.341ms  3.714ms
3   <IP_ADDRESS>  5.406ms  8.085ms  7.201ms
4   <IP_ADDRESS>  6.098ms  6.524ms  6.503ms
5   <IP_ADDRESS>  6.018ms  6.630ms  5.537ms
6   <IP_ADDRESS>  6.457ms  6.380ms  5.535ms
7   <IP_ADDRESS>  14.085ms  14.504ms  14.143ms
8   <IP_ADDRESS>  39.606ms  39.446ms  39.494ms
9   <IP_ADDRESS>  58.848ms  60.140ms  58.918ms
10   <IP_ADDRESS>  72.893ms  73.501ms  74.769ms
11   <IP_ADDRESS>  74.715ms  75.296ms  74.109ms
12   <IP_ADDRESS>  74.146ms  74.162ms  89.967ms
13   <IP_ADDRESS>  74.302ms  73.791ms  73.761ms
14   <IP_ADDRESS>  73.964ms  75.061ms  74.090ms
15   <IP_ADDRESS>  74.617ms  75.139ms  73.469ms
vic@DESKTOP-SVUEQK6:~$

Doesn't work for me:
inetutils-traceroute -M icmp www.microsoft.com
traceroute to e13678.dspb.akamaiedge.net (<IP_ADDRESS>), 64 hops max
  1   *  *  *
  2   *  *  *
  3   *  *  *
  4   *  *  *
  5   *  *  *
  6   *  *  *
  7   *  *  *
  8   <IP_ADDRESS>  23.349ms  22.878ms  23.195ms

Same result for other hosts as well.

regular traceroute doesn't work but inetutils-traceroute does for me

There has been credible evidence the necessary syscall surface works for some folks but not others. This is complicated by the fact that if it works at all, you'd surely (?) need to be running WSL elevated. The success/fail stories don't usually say which was tried. But it doesn't work for me elevated or nonelevated as of 18298:
ken@DESKTOP-4UTIQSF:~$ sudo strace -ff traceroute inetutils-traceroute <IP_ADDRESS>
execve("/usr/bin/traceroute", ["traceroute", "inetutils-traceroute", "<IP_ADDRESS>"], 0x7fffc30f5698 /* 14 vars */) = 0
[...]
socket(AF_INET, SOCK_RAW, IPPROTO_ICMP) = 4
setsockopt(4, SOL_IP, IP_TTL, [1], 4)   = 0
sendto(3, "SUPERMAN\0", 9, 0, {sa_family=AF_INET, sin_port=htons(33434), sin_addr=inet_addr("<IP_ADDRESS>")}, 16) = 9
gettimeofday({tv_sec=1544742322, tv_usec=582511}, NULL) = 0
select(5, [4], NULL, NULL, {tv_sec=3, tv_usec=0}) = 0 (Timeout)
gettimeofday({tv_sec=1544742325, tv_usec=588222}, NULL) = 0
write(1, "  1   * ", 8  1   * )                 = 8

WSL thinks the ICMP TTL packets are going out the door, but they never come home.
I haven't been able to explain how/why it is working for some. [I have an unsubstantiated guess but it is probably wrong.] Best that can be said of this issue is: if the MSFT devs considered this feature-complete we'd know. The underlying fail blocks more than just inetutils-traceroute. Addressing it wouldn't be kept a secret. This issue isn't of the burried "we forgot to tell ya" sort.

same here traceroute not working :(

traceroute still not working for 1809...  worked for real Ubuntu Distro in same network

yes it's still not work because it's kernel related and not hardware related. once microsoft do something with low level stuff - then it will work.

Using a network sniffer, we can see the UDP datagrams that traceroute builds are sent correctly to the network interface, and the related ICMP errors (Time-to-live exceeded) are received correctly too. I guess they are not forwarded to traceroute.
Behavior is the same when using ICMP mode. The ping command does work though.

wasn't the latest update supposed to support raw sockets? Is this a bug or feature.

is this going to work on WSL2?

@Tey @manilaboy1vic
Actually, If you turn off windows firewall and do inetutils-traceroute -M icmp www.google.com
Then it works

Do you know if there's a way to make it work without disabling the firewall?

traceroute still not working for 1909...  tracert.exe works in a command/powershell window, but traceroute does not work in Ubuntu under WSL

Do you know if there's a way to make it work without disabling the firewall?

yip, trying to add different firewall rules.. not getting it right .. :(

@consal @atsaloli  @chris-gela
After my careful investigation, the root cause is Windows disable ICMP to pass through.
Windows machine normally won't rely ping, for example.
https://www.howtogeek.com/howto/windows-vista/allow-pings-icmp-echo-request-through-your-windows-vista-firewall/
Using this post and let All ICMP type pass through.
And it Works

@consal @atsaloli @chris-gela
After my careful investigation, the root cause is Windows disable ICMP to pass through.
Windows machine normally won't rely ping, for example.
https://www.howtogeek.com/howto/windows-vista/allow-pings-icmp-echo-request-through-your-windows-vista-firewall/
Using this post and let All ICMP type pass through.
inetutils-traceroute -M icmp www.google.com
And it Works

awesome, thanks for the investigation!

@po-wei Hi, not sure if I'm doing something wrong - but can't get it to work;

Addressed in WSL2.

WSL1 is okay too so long as you let ICMP through your firewall:

Non-ICMP flavours of traceroute that open AF_PACKET + SOCK_RAW (aka #1349) (contrast IPPROTO_ICMP aka ping) aren't going to fly on WSL1.
One can also use tracert.exe with interop on WSL1 in a pinch.

@chris-gela
Do you  follow the steps in https://www.howtogeek.com/howto/windows-vista/allow-pings-icmp-echo-request-through-your-windows-vista-firewall/ ?
Note that this step should click all type

@chris-gela
Do you follow the steps in https://www.howtogeek.com/howto/windows-vista/allow-pings-icmp-echo-request-through-your-windows-vista-firewall/ ?
Note that this step should click all type

Thanks @Po-wei, I was too lazy to try the manual firewall rule. I've anyhow updated to WSL2... so all good :)

to expand on the suggestions of others here, i did the following to get this working:
windows cli/powershell session
netsh advfirewall firewall add rule name= "All ICMP V4" protocol=icmpv4:any,any dir=in action=allow

WSL ubuntu session
$ sudo apt install -y inetutils-traceroute

$ inetutils-traceroute -I <IP_ADDRESS>
traceroute to <IP_ADDRESS> (<IP_ADDRESS>), 64 hops max
  1   <IP_ADDRESS>  0.258ms  0.189ms  0.195ms
  2   10.x.x.x  1.398ms  0.789ms  0.845ms
  3   60.x.x.x  5.999ms  6.747ms  6.123ms
  4   202.x.x.x  13.650ms  7.813ms  7.741ms
  5   203.x.x.x  6.215ms  5.781ms  5.972ms
  6   203.x.x.x  6.076ms  5.797ms  5.874ms
  7   110.x.x.x  6.538ms  6.878ms  6.780ms
  8   203.x.x.x  6.638ms  6.930ms  6.792ms
  9   203.x.x.x  7.235ms  7.233ms  7.560ms
 10   <IP_ADDRESS>  5.801ms  5.874ms  5.920ms


Multiclass Sampling

Describe the solution you'd like
An additional function for multi-class sampling
Describe why this is needed
The current sampling function is only for binary class
Describe alternatives you've considered
No alternative.
Additional context
Nothing

I reviewed SMOTE Oversampling for Multi-Class Classification.
Firstly, in this method all the classes and the corresponding number of observations are identified. Say for example there are 4 classes with different number of observations (n=34, n=45, n=21, n=54).
Secondly, once classes are identified SMOTE oversampling samples all the classes to the largest n. In this case, it is 54. So SMOTE oversampling for multi-classification creates 4 classes with (n=54, n=54, n=54, n=54).
Thirdly, after sampling is done we plot histograms to compare the classes before and after sampling.
Conclusion: The basic transformation syntax looks like this
transform the dataset
oversample = SMOTE()
X, y = oversample.fit_resample(X, y)
We will need to review and see how another sampling function can be created for multi-classification in Weedout.


⚠ ClamAV has degraded performance

In 7d6275f, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 68 ms

Resolved: ClamAV performance has improved in 18527ce.


Fix \Illuminate\Database\QueryException when deleting records with foreign keys

This PR addresses the issue where a \Illuminate\Database\QueryException is thrown when attempting to delete or force delete a record with foreign keys in the database.

The normal behavior of the system would previously throw an exception when attempting to delete a record with foreign keys. Now, the system gracefully handles this situation and provides a user-friendly message to inform the user that the record cannot be deleted.

[x] Changes have been thoroughly tested to not break existing functionality.
[x] New functionality has been documented or existing documentation has been updated to reflect changes.
[ ] Visual changes are explained in the PR description using a screenshot/recording of before and after.

Thanks, but I don't think I am going to merge

Query exceptions are there to indicate that something went wrong. IMO, we should prevent exceptions in the first place, which you can do by disabling / hiding actions that should not be clicked. For example ->hidden(fn ($record) => $record->relationship->exists())
By catching all query exceptions, you are silencing many other issues that could occur, like a SQL syntax error. There is no way to properly catch foreign key exceptions only.

Thank you for your insights. To enhance error handling and make it more user-friendly and precise, consider narrowing your error-catching scope to focus on foreign key constraint-related issues. In PostgreSQL, you can target these specific error codes for foreign key violations:

23000 | Integrity Constraint Violation
23001 | Restrict Violation
23502 | Not Null Violation
23503 | Foreign Key Violation
23505 | Unique Violation
23514 | Check Violation
23P01 | Exclusion Violation

For MySQL, you should keep an eye out for error number 1451  ER_ROW_IS_REFERENCED_2.
Just an example below to illustrate how we can handle a foreign key violation error:
try {
    // Our code here.
} catch (\Illuminate\Database\QueryException $e) {
    // For instance, using an array of error codes:
    if ($e->getCode() == '23503') {
        // Handle the foreign key violation error appropriately.
        // Display a user-friendly message.
        return;
    }
    // For other errors, we can rethrow the exception.
    throw $e;
}

if you want i can rewrite my RP and improve it to catch only errors related to foreign key violation error.

Hm but what I said about preventing the exceptions in the first place is probably best, I dont think we should be silencing exceptions

I 100% agree with you that we should not be silencing exceptions entirely. Our approach will involve catching and handling exceptions selectively. Specifically, we will catch and handle exceptions when a user is trying to delete a record that has related data elsewhere in the database. In such cases, we will display a meaningful message to inform the user that they cannot delete the record due to its usage in other places.
For other exceptions, such as SQL syntax errors or any unforeseen issues, we will not catch them but instead re-throw the errors back to the user, as you mentioned in point 2. This way, we maintain transparency and provide users with clear feedback about why they cannot perform certain actions while ensuring that other unexpected errors are appropriately raised and not hidden.

I understand that we can selectively silence, but I believe that we should never get the DB into a situation where it sends an error, it's our job as developers to prevent the DB from wasting its time doing operations that will fail. What is your opposition to doing PHP checks beforehand?
If you want, you can override this code in your own app to catch the exception


Fixes for projects API

Fixes hanging projects API tests / simplifies the async run framework:

Local & Databricks runs are no longer asynchronously monitored in a subprocess by the client. Instead, the client assumes that local & Databricks project runs will report their own status to a tracking server.
Adds a new internal CLI command mlflow internals _run_internal [entry_point_command] that runs an entry point command in a subprocess & reports its status to a tracking server.
Asynchronous local runs are now launched by invoking the internal CLI command in a subprocess opened via subprocess.Popen instead of multiprocessing.Process (should reduce the likelihood of resource leaks, since subprocess.Popen calls fork() + exec().

After this PR:

SubmittedRun.get_status now returns the status of the launched unit of execution (local process / Databricks run) rather than an MLflow run status from a tracking server
A program that calls mlflow.projects.run() and completes will exit successfully, leaving behind launched runs (that will asynchronously report their status to a tracking server). The old behavior was to block until all launched runs completed.
A program that calls mlflow.projects.run() and exits with an exception will terminate all runs launched thus far via SubmittedRun.cancel() and exit.

Codecov Report

Merging #193 into master will increase coverage by 0.94%.
The diff coverage is 80.35%.

@@            Coverage Diff            @@
##           master    #193      +/-   ##
=========================================
+ Coverage   50.36%   51.3%   +0.94%
=========================================
  Files          93      93
  Lines        4684    4697      +13
=========================================
+ Hits         2359    2410      +51
+ Misses       2325    2287      -38

Impacted Files
Coverage Δ

mlflow/cli.py
75.32% <100%> (+0.65%)
:arrow_up:

mlflow/projects/__init__.py
80.51% <71.42%> (-11.49%)
:arrow_down:

mlflow/utils/internal_cli.py
75% <75%> (ø)

mlflow/projects/submitted_run.py
79.24% <76.59%> (-9.65%)
:arrow_down:

mlflow/projects/databricks.py
83.51% <96.29%> (+83.51%)
:arrow_up:

mlflow/entities/run_status.py
80% <0%> (-6.67%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da77647...cad470b. Read the comment docs.

The flow looks good! Mostly minor comments.


dm/approvers

Note for reviewers: I removed the logic that used to let the user interactively choose the assignee from a list of matches.
1/ This would have made the ux flow annoying when using an option like --reviewer more than once
2/ It seems the gitlab API prefers to not return anything when there's an ambiguity and the query is not
an empty string
3/ It makes the code in push_gitlab simpler and closer to the push_github implementation.


bug: $ionicHistory.goBack() doesn't take current stateParams of last View

Type: bug
Platform: all
following scenario:

entering view A of a list products (stateParams = ?category=all
filter some stuff (each filtering changes the stateparams)
enter view with 1 product (view A has now stateParams ?category=pants,tops,socks
$ionicHistory.goBack()
get back to view A, but with ?category=all instead of the last params

Greetings @zwacky!
My sensors indicate that you need to update your issue through our custom issue form. We are now requiring all issues to be submitted this way, to ensure that we have all of the information necessary to fix them as quickly as possible.
Click Here To Update Your Issue
I will have no choice but to close this issue if it is not resubmitted through the form. Please fill out the rest of the form, so that I may use my friendly robot powers to assist you.
Thank you!

Seems to be related to these other issues: #3551 #3884 #3551
Quicky walkthrough over ionicHistory file shows that it looks like view.stateParams are set only once during registration step and never update again and getting out of sync with real $state.params.
https://github.com/driftyco/ionic/blob/master/js/angular/service/history.js#L361

Digging more into the ionic codebase, here is my interpretation so far:
Background: Ionic navigation data is persisted on $ionicHistory.viewHistory and each view on the history has among other things: stateName, stateParams and url.
Architecture Dissonance: Ionic navigation/history is structured in terms of "views" while angular-ui-router has the concept of "states", the cardinality between view and state is not necessary 1x1, you can within the same view navigate across different possible states (eg: search and search result ).
This introduce an synchronisation complexity, meaning you have to keep the current view information  in sync with current state params.
Issue
view.stateName and view.stateParams are not updated as user navigate thought different states ( within the same view ).

View state is captured just once during the registration phase (First time you navigate to the view ) and never updated again.
Local optimisation on navViewDirective prevents transition within the same view from happening ( which is a good thing, undesired transitions would popup all the time )

Workaround
As of now I've been spiking possible solution, and this code snipped seems to be doing the right think, I don't recommend using it in production by any means:
  $rootScope.$on('$locationChangeSuccess', function (e, url) {
      console.log('$locationChangeSuccess', url);
      if (! $ionicHistory.currentView()) {
        return
      }

      function getCurrentStateId() {
        var id;
        if ($state && $state.current && $state.current.name) {
          id = $state.current.name;
          if ($state.params) {
            for (var key in $state.params) {
              if ($state.params.hasOwnProperty(key) && $state.params[key]) {
                id += "_" + key + "=" + $state.params[key];
              }
            }
          }
          return id;
        }
        // if something goes wrong make sure its got a unique stateId
        return ionic.Utils.nextUid();
      };

      var currentView = $ionicHistory.currentView();
      currentView.stateId = getCurrentStateId();
      currentView.stateName = $state.current.name;
      currentView.stateParams = angular.copy($state.params);
    });

The idea is to update currentView state every time there is an update on the url as well, this way the viewHistory will always be consistent with the $state.params.
In order to make this solution work I had to pull the getCurrentStateId() function out of the $ionicHistory.
If this is the right thing to do we should probably move this code snippet to inside the $ionicHistory itself.
I am looking forward to hear from the more senior contributors if they see any problem with this approach.
Cheers.

More information on this.
I were able to reproduce issue when you have an ui-view inside an ion-nav-view:
State:
$stateProvider
    .state('parent', {
        template: '<ion-view>Parent View: <ui-view></ui-view></ion-view>'
    })
    .state('parent.child', {
        template: 'Child View: {{childStateParam}}',
        params: {
           childStateParam: 'Initial Value'
        }
    })
   .state('foo', { template: 'bar' })

Javascript*
/** activate state 'parent.child' with default param will register a new transition**/
$state.go('parent.child');

/** activate again state 'parent.child' but with different param will not register a new transition
because we are still in the same view **/
$state.go('parent.child', {childStateParam: 'New Value'});

/** activate a new view will register a new transition**/
$state.go('foo');

/** go back should register a transition back to previous view with the latest known params**/
$ionicHistory.goBack();

$state.params.childStateParam === 'InitialValue'; //(true but should be false)

Example
http://codepen.io/thiagofelix/pen/aOPJWZ/
Solution
Change navView.updateView function to update the current view information after $stateChangeSuccess event is fired.
It also require $ionicHistory to have this function exposed so it can receive updates requests.

Greetings @zwacky!
I've closed this issue because my sensors indicated it was old and inactive, and may have already been fixed in recent versions of Ionic. However, if you are still experiencing this issue, please feel free to reopen this issue by creating a new one, and include any examples and other necessary information, so that we can look into it further.
Thank you for allowing me to assist you.

So, a question...why are you modifying the stateParams for your view? You should expect that you got that data from a navigation, and using it again won't be correct.
Instead, it sounds like a better idea would be to cache their search and filtering history in a local storage or in-memory cache rather than relying on stateParams again. Something like:
$scope.$on('$ionicView.enter', function() {
   $scope.filter = getStoredFilter('shoes') || $stateParams.filter;
});

I think I'm going to close for now, if only because we can hack uiRouter and our nav forever, but there is a really complex dance here. v2 will really simplify the navigation process and make this really easy to do.
Let me know if you have any additional thoughts.

Thank you @mlynch  for taking a look, I wish I had more time to dig further here, It is indeed hard to explain the navigation, I tried hard to provide context and enough detail, even them still hard to follow.
I kept the workaround snipped on the application I was working on and the temporary solution became the final one.
Congratz for the V2 stuff, I am playing with it and is really cool! =)

@thiagofelix Your fix worked for me.  Thanks for posting it, it's been very frustrating trying to figure this one out.

The solution with ionic v1 is on back button click function that you called  $ionicHistory.goBack();
so the state params not changed when navigating  and you also pass objects in state params(productData)  like this:
.state('app.product', {
url: '/product',  //:prod_id
views: {
'menuContent': {
templateUrl: 'templates/product.html',
controller: 'ProductCtrl'
}
},
params: {productData : null},
cache: false
})
$ionicPlatform.registerBackButtonAction(function(event) {
if ($state.current.name == "app.home") {
navigator.app.exitApp(); //<-- remove this line to disable the exit
} else {
//            navigator.app.backHistory();
$ionicHistory.goBack();//very important;
}
}, 100);


Updated existing VMs grammar

The header currently says "Exist VMs". This is not grammatically correct, it should be "Existing VMs". Additionally, there is HTML anchor tag for this heading as "existing-vms". The tag can now be removed, as the anchor "existing-vms" will be catered for with the new heading.

Thanks! This probably happened during a regular gerund cleanup process. We appreciate your feedback.


Complete documentation rebuilding

Rewrite all the documentation. The user must be put directly into situation while being comfortable in the interpretation of the different examples. The latter one will have to present various scenarios with both simple cases and cases with complexity.

Update the description since that the library is described as a preprocessor only.

Add a section/note about the filter selector and how is it organized (scope parent child) -> exclusive to flysh (+ class property mandatory)

Other links to include in docs
investigate for multiple selector funiction Jquery
https://api.jquery.com/multiple-selector/
Descendant Selector (“ancestor descendant”)
Selects all elements that are descendants of a given ancestor.
https://api.jquery.com/descendant-selector/
Class Selector (“.class”)
Selects all elements with the given class.
https://api.jquery.com/class-selector/
Child Selector (“parent > child”)
Selects all direct child elements specified by “child” of elements specified by “parent”.
https://api.jquery.com/child-selector/

Add a schematic stack representation like (top - down),
Flysh

JSDOM | Jquery

Node
JS
0S


✏ Fix typo in docs/tutorial/automatic-id-none-refresh.md

Specifically in subsection Print Data After Closing the Session

Now, as a fnal experiment, we can also print data after the session is closed.

Awesome, thanks @leynier! :cake:


Clean Up BuyMenu and improve selecting tiles

BuyMenu is a little too long, as uses plain r3f , a custom button that respondson click and hover would be better.
Tiles can only be selected if they are on top, but it's still tricky if there are other top tiles "behind" the first from the camera's POV. It would be best if the tile "closest" to the camera were always selected on first click.

Regarding the buy menu, I was thinking we should consider rendering it in HTML instead. It was convenient for prototyping but I'm not sure if it makes sense to keep it in the camera view.

Yeah, HTML will be much easier to read and click. We can chat about this later, but most of the game info and menus could be moved to the sides or something.

Covered by #75


question about mse shim

Have you read the FAQ and checked for duplicate issues:
are you working on or is already available  a MSE shim using flash ?

We have no plans to polyfill MediaSource through flash.  We only maintain our own polyfills for the browsers we directly support, all of which have MSE.
If you have access to a flash-based MSE implementation, you can always load that in addition to Shaka Player.  So long as shaka.Player.isBrowserSupported() returns true before you create a Player, it should work.
Does this help?

yes another question please .... in the past i realized  my player but i m thinking to pass to shaka. But there is a problem. My player uses a customized datasource for retrieval chunks ...
is there a manual or source example or other for make easy to understand how to implement a additional datasource ?

I'm not sure if I understand you.  Do you mean that you want to get media data from some custom piece of code, rather than directly from the network?

No it doesnt use dash specifications but custom specification and it retrieves data in different way ...There is a generic prototype Stream  class permitting to handle streams of data , to seek in a specific offset.

We have many plugin interfaces you may want to explore: https://shaka-player-demo.appspot.com/docs/api/tutorial-plugins.html
Manifest parser plugins would allow you to source your media metadata from something other than DASH or HLS.  We don't care where the info comes from, but we need metadata in a certain format to allow us to generically stream the content and feed it to the browser using MediaSource.
Networking plugins allow you to provide data from a source other than HTTP.  You register your plugin to handle a certain URI scheme, and Shaka Player will invoke your plugin any time it wants data from a URI using that scheme.  For example, you could ask Shaka to load media from myapp://foo/bar, and we would invoke the "myapp" plugin to get the actual data.
Does this help?

yes i think. I will read this documentation for having a better idea about
it.
Thanks for your support :)
2017-05-31 19:23 GMT+02:00 Joey Parrish<EMAIL_ADDRESS>
We have many plugin interfaces you may want to explore:
https://shaka-player-demo.appspot.com/docs/api/tutorial-plugins.html
Manifest parser plugins
https://shaka-player-demo.appspot.com/docs/api/tutorial-manifest-parser.html
would allow you to source your media metadata from something other than
DASH or HLS. We don't care where the info comes from, but we need metadata
in a certain format to allow us to generically stream the content and feed
it to the browser using MediaSource.
Networking plugins
https://v2-1-2-dot-shaka-player-demo.appspot.com/docs/api/lib_net_http_plugin.js.html#line35
allow you to provide data from a source other than HTTP. You register your
plugin to handle a certain URI scheme, and Shaka Player will invoke your
plugin any time it wants data from a URI using that scheme. For example,
you could ask Shaka to load media from myapp://foo/bar, and we would
invoke the "myapp" plugin to get the actual data.
Does this help?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/google/shaka-player/issues/835#issuecomment-305257747,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACZspL543JcKVJb3vRc9jDhUf9lBqVtXks5r_aIlgaJpZM4NrC0x
.

Happy to help!


Allow completion functions to associate data with completion items [RFC]

When using v:completed_item, it is useful to be able to perform
subsequent actions based on the completed item. This allows user defined
completion functions to supply custom data (in the form of a string, for
simplicity), which can be used within the CompleteDone autocommand to
perform any subsequent actions.
Example use cases include:

automatic insertion of import or include statements
insertion of snippets for method arguments.

Fixes #2508

Codecov Report

Merging #2608 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2608      +/-   ##
==========================================
- Coverage   74.63%   74.63%   -0.01%
==========================================
  Files          92       92
  Lines      133036   133039       +3
==========================================
  Hits        99292    99292
- Misses      33744    33747       +3

Impacted Files
Coverage Δ

src/edit.c
85.34% <100%> (+0.01%)
:arrow_up:

src/message.c
68.5% <0%> (-0.2%)
:arrow_down:

src/term.c
50.77% <0%> (-0.11%)
:arrow_down:

src/gui_gtk_x11.c
47.65% <0%> (-0.1%)
:arrow_down:

src/ex_cmds2.c
80.19% <0%> (-0.1%)
:arrow_down:

src/eval.c
81.08% <0%> (-0.05%)
:arrow_down:

src/screen.c
73.91% <0%> (+0.02%)
:arrow_up:

src/syntax.c
77.49% <0%> (+0.02%)
:arrow_up:

src/os_unix.c
54.51% <0%> (+0.04%)
:arrow_up:

src/channel.c
82.91% <0%> (+0.08%)
:arrow_up:

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9407316...503409c. Read the comment docs.

I think the feature is useful for plugins.
I think the name "extra" is better than user_data.
It contains the extra information.
What do you think?

I'm totally ambivalent on the name. I liked user_data because it was sufficiently different from extra text for the popup menu which is the description of the menu parameter, and it more precisely describes its usage than data or extra or something.
But like I said, I'd go with any consensus on the key name.

What about 'msg'? It seems one of the main goal will be to communicate an information to an autocmd listening to CompleteDone. It could be seen as a message.

I think msg is even more ambiguous

+1 for user_data or data. That is a very common convention.

I fixed the texts failures, though I honestly don’t understand what caused hem.

Thanks, Bram!


Allow axes to start from 0

Hey @zavrick
Can you provide some more details about what's going on? Axes should certainly be able to start from zero, and there are a variety of ways to make this happen (such as setting xDomain to include zero) or use tickValues!

https://github.com/uber/react-vis/issues/675
I think this may be what he is referring to. I'm having the same issue @mcnuttandrew

You can make the axes start from 0 by providing your own axis ticks, starting at 0.
Something like this:
 let ticks = [];   for( let i = 0; i <= 10; ++i ){      ticks.push( parseInt( maxFlowRate / 10 ) * i );    } //... <YAxis tickValues={ticks} />

You can start the chart at zero by adding a Mark series at 0,0 and set its display to none.
<MarkSeries data={[{ x: 0, y: 0 }]} style={{ display: 'none' }} />


[Dropzone] change physical link to the default style file

Q
A

Bug fix?
no

New feature?
no

License
MIT

Hello, after installing and following the doc, I have a message with an error on the path to the style file after having copy docs config example :)

Good catch, thanks @chadyred.


common improve

basic improve for some procesures and formats. Try to make contribution for this
project.

Coverage decreased (-0.0001%) to 98.7% when pulling b649991f22ef4620dea46da5b9c1051f0edf9c3c on tonyyyye:master into 5dad317744882cb4c4fbbce53edc3d7f4576552e on danielyule:master.

redo it


remove hard coded fontname

#20

hiya. seems better if we allow a parameter on that function, right?


How to use it with Java code

Kotlin and Java are interoperable but I how can I use the FirebaseRestAuth class within a activity class that is written in Java while it is an interface class and not static singleton?
auth = FirebaseRestAuth.getInstance(FirebaseApp.getInstance()); is what I think it should look when written in Java.

I discovered that it should be written as auth = FirebaseRestAuth.Companion.getInstance(FirebaseApp.getInstance());

On 24 Sep 2020, at 13:27, ArcherEmiya<EMAIL_ADDRESS>wrote:
auth = FirebaseRestAuth.getInstance(FirebaseApp.getInstance()); is what it I think it should look when written in Java.

This is what I do:
public static FirebaseRestAuth sGetFirebaseRestAuth()
{ return (FirebaseRestAuth) FirebaseApp.getInstance().get(FirebaseRestAuth.class); }
A++
Andrew Green        skype:electricmagic<EMAIL_ADDRESS>Electric Magic Co.                    +1<PHONE_NUMBER>

On 24 Sep 2020, at 13:27, ArcherEmiya @.***> wrote: auth = FirebaseRestAuth.getInstance(FirebaseApp.getInstance()); is what it I think it should look when written in Java.
This is what I do: public static FirebaseRestAuth sGetFirebaseRestAuth() { return (FirebaseRestAuth) FirebaseApp.getInstance().get(FirebaseRestAuth.class); } A++ --- Andrew Green skype:electricmagic<EMAIL_ADDRESS>Electric Magic Co. +1<PHONE_NUMBER>

Is what I did wrong or just the same result as yours?

I had to go back and look to be sure!
My code's looking for the FirebaseRestAuth instance in the FirebaseApp's pre-populated ComponentRuntime. So it should fail when FirebaseRestAuth has not been instantiated by the component registry mechanism. Going through FirebaseRestAuth.Companion.getInstance, we do always get a FirebaseRestAuth, but it's not necessarily InternalAuthProvider instance that the FirebaseApp itself would find.
This is really only an issue if the code is dynamically registering FirebaseRestAuth or FirebaseAuth at runtime, so you have FirebaseRestAuth code running, but a FirebaseAuth has been registered and is being used by other firebase components in preference to your FirebaseRestAuth.


Footer is not visible when specify vertical scroll and data table height

I am using ngx-datatable to display the data.I need the limit the height of data table & display the vertical scrollbar. Below is my configuration for table
I tried limiting the height of the data table using scss as
.ngx-datatable {
height: 250px;
overflow-y: auto;
}
<ngx-datatable
class="bootstrap"
[rows]="rows"
[loadingIndicator]="loadingIndicator"
[columns]="columns"
[columnMode]="'force'"
[headerHeight]="5"
[footerHeight]="20"
[rowHeight]="30"
[reorderable]="reorderable"
[scrollbarH]="true"
[scrollbarV]="true"
[selected]="selected"
[selectionType]="'single'"
(activate)="onActivate($event)"
(select)="onSelect($event)"
>

{{row.company }}

I am not able to display both vertical scroll bar & footer at the same time. My Footer and last rows in grid are not showed at all

Try make [headerHeight] and [rowHeight] value bigger than it's content

Same problem, the solution by @Weizz does not work for me.


DatasetGenerator doesn't stop generating?

In this code block, I had an instance of the dataset generator not stopping and continuing generating. I'm investigating this, it may be a bug introduced by the switch in #324
from prompt2model.dataset_generator import PromptBasedDatasetGenerator, DatasetSplit

dataset_generator = PromptBasedDatasetGenerator(
    initial_temperature=0.3,
    max_temperature=1.4,
    responses_per_request=3,
    max_api_calls=10000,
    requests_per_minute=80,
)
generated_dataset = dataset_generator.generate_dataset_split(
    prompt_spec, 5000, split=DatasetSplit.TRAIN
)
generated_dataset.save_to_disk("generated_dataset")

Hmmm. I've written a lot of unit tests to test DatasetGenerator ends correctly. It seems that these mocks in the unit tests of DatasetGenerator is invalid now. 🤔


setDatePicker Behavior

From<EMAIL_ADDRESS>on June 03, 2011 03:42:15
What steps will reproduce the problem? 1. Have a View that will open a DatePicker Dialog when clicked
2. Click on the View
3. Call Solo.setDatePicker(0,2011,5,7);
4. Click on Button "Set" in the DatePickerDialog so that the Setting is done. What is the expected output? What do you see instead? expected:
4. The Button is clicked and the setting is done. The DatePicker gets closed.
instead:
4. The EditText for the Day is clicked on. What version of the product are you using? On what operating system? 2.2, Android 2.2 HTC Desire Please provide any additional information below. Not sure if this is a Robotium problem or an Android problem...
Original issue: http://code.google.com/p/robotium/issues/detail?id=118

From<EMAIL_ADDRESS>on June 05, 2011 08:02:25
Have you tried this on the emulator?

From<EMAIL_ADDRESS>on June 06, 2011 02:25:22
Same behaviour in Emulator (Google API Level 8)

From<EMAIL_ADDRESS>on June 06, 2011 02:57:49
Please see: "Why do text and button clicks get wrong?" https://code.google.com/p/robotium/wiki/QuestionsAndAnswers

From<EMAIL_ADDRESS>on June 06, 2011 07:25:11
Thank you for that hint.
I tried that in two seperate projects. While in one project the tags in the manifest files helped, in the other project it didn't.
I am completely clueless why it does not work on both or neither.. Maybe you know something more?
In my Project I have:
<supports-screens
android:anyDensity="true" />
<uses-sdk
android:targetSdkVersion="4"
android:minSdkVersion="3" />
In my Test Project I have:
<uses-sdk android:targetSdkVersion="4" />

From<EMAIL_ADDRESS>on June 06, 2011 08:14:20
In the method Clicker.public void clickOnScreen(View view, boolean longClick, int time)
the line
view.getLocationOnScreen(xy);
returns different values for the y-coordinate.
This is why the EditText is clicked instead of the Button.

From<EMAIL_ADDRESS>on June 06, 2011 08:42:45
Robotium does not support version API version 4. It only works with Android 1.6 and up.

From<EMAIL_ADDRESS>on June 06, 2011 08:46:48
Isn't Android 1.6 API version 4 ?

From<EMAIL_ADDRESS>on June 06, 2011 08:50:19
The min version 3 (1.5) might be the reason why you are getting the wrong coordinates back.
The only other reason why you would get the wrong coordinates back is because of the screen densitiy issue described in the QA wiki page. You need to add those tags to the application that you want to test (not the test project).

From<EMAIL_ADDRESS>on June 06, 2011 09:00:42
I have now in my project:
<supports-screens
android:anyDensity="true" />
<uses-sdk
android:targetSdkVersion="8"
/>
And in my test project:
<uses-sdk android:targetSdkVersion="8"
/>
Same behaviour..

From<EMAIL_ADDRESS>on June 06, 2011 09:23:26
As I said in the previous message it has to do with wrong coordinates being given back to Robotium. This is not a Robotium defect. Unfortunetaly I can not give you any other solution then what is described in the QA page.
Status: Invalid

From<EMAIL_ADDRESS>on June 10, 2011 02:31:24
Hi,
I have just found the reason.
Before I opened the DatePickerDialog, a software keyboard was shown!
The keyboard will be closed once the DatePickerDialog is shown.
However, one has to close the keyboard manually (e.g. by calling Solo.goBack), otherwise the following click will not be made correctly.
I attached a Sample Project and a Sample Test Project that makes this clear.
Note that the test projects writes the processing steps of the test to the LogCat. You can see there that a wrong coordinate for the y-axis will be used.
(Used Emulator 2.2)

From<EMAIL_ADDRESS>on June 10, 2011 02:31:54
Added the sample..
Attachment: DatePickerDialogSample.zip


Circular linked list implementation

Id like to implement this is JavaScript. Please assign the issue to me.

Id like to implement this is JavaScript. Please assign the issue to me.

Circular Linked List implemented in Java.My PR is #220

Heya! Just added a PR, check it out once and would like to contribute.

Is it possible for You @swastikchugh to add the hacktoberfest" topic to this issue, it would be really helpful though :)


Rest Service - Top 10 Hashtags

In addition to the results of tokensearch request, a list with top 10 hashtags should returned if the query parameter "topten" is pesent in the request and has the value true or 1
e.g. .../api/tokensearch?field=text&token=yolo&topten=true
the default value of topten is false, so if the parameter isn't set, no hashtags-list will be added and only one element "tweets" is in the retured json object.
The response of an request will look like:
{
"tweets": [ {"created_at": "W...},{"created_at": "W...},...],

"topten" : [ "#hashtag1","#hashtag2","#hashtag3",....]
}

"#hashtag1" is the most frequenty hashtag in the result
...
"#hashtag10" is the 10th most frequenty hashtag in the result
After this is implemented, i'll add it to the wiki in webservice part.
@kev007 you can have a look at the structure above. In future we can think about a list of all tweet_ids to each hashtag to see, in which tweets the hashtag occurs.

@kev007 I added this functionality in branch iss72-webservice-top-ten-hashtags . Please checkout that branch, do the neccessary changes in the ui code (add query parameter topten, access tweets for tweet list ...) and merge it to master.

todo: merge

//TODO: client side filtering when selecting a hashtag

Done. Any suggestions?

I'll fix the case sensitive problem

Done and merged into master branch. Please test it on live system after deploy. If it's working, close this ticket and delete Branch iss72-webservice-top-10-hashtags


Don't Hide Address Bar on Overview Tab

User is left sort of lost without it; need to click the first tab to get the address bar back

We don't know exactly what we want to do with the overview, so unassigning for now.


[SPARK-45590][BUILD] Upgrade okio to 1.17.6 from 1.15.0

What changes were proposed in this pull request?

This PR aims to upgrade okio from 1.15.0 to 1.17.6.
Why are the changes needed?

Okio 1.15.0 is vulnerable due to CVE-2023-3635,  details: https://nvd.nist.gov/vuln/detail/CVE-2023-3635
Previous attempts to fix this security issue:
Update okio to version 1.17.6 #5587: https://github.com/fabric8io/kubernetes-client/pull/5587
Followup to Update okio to version 1.17.6 #5935: https://github.com/fabric8io/kubernetes-client/pull/5935
Unfortunately it is still using 1.15.0:
https://github.com/apache/spark/blob/v4.0.0-preview1/dev/deps/spark-deps-hadoop-3-hive-2.3#L227
https://github.com/apache/spark/blob/v3.5.2/dev/deps/spark-deps-hadoop-3-hive-2.3#L210
Does this PR introduce any user-facing change?

No.
How was this patch tested?

Pass the CIs.
Was this patch authored or co-authored using generative AI tooling?

No.

Hi @bjornjorgensen,
I saw that you worked on this CVE fix in the past. Unfortunately the latest Spark versions still include this Okio vulnerability, see below releases:
$ find spark-4.0.0-preview1-bin-hadoop3/ | grep okio
spark-4.0.0-preview1-bin-hadoop3//jars/okio-1.15.0.jar
$ find spark-3.5.2-bin-hadoop3/ | grep okio
spark-3.5.2-bin-hadoop3//jars/okio-1.15.0.jar
$

This PR aims to upgrade okio from 1.15.0 to 1.17.6 with a package pin. What is your opition about this solution?

@roczei Thank you.
Yes, I did have some problems with this one.
This seams to be a better way to solve the issue.
I think the issue is that okio is in both kubernet-client and in hadoop.

This seams to be a better way to solve the issue.

@bjornjorgensen, Ok, thanks!

Merged to master。
Can you send backports to branches 3.5 and 3.4?

@yaooqinn,
Could you please assign me to the SPARK-45590 jira?  Thank you in advance!


feat: first draft elsevier parser

Keeping Sergi's optimization comments in mind for a possible future optimization - the hit on readability makes this less desirable if its not needed.


How do I import this thing? (TypeScript ES6/ES2015 + Webpack)

So far the below seems to work in terms of assigning Sugar to the global scope.
require("expose-loader?Sugar!sugar");

Testing it in the web browser shows that it is working.
However I am having zero luck being able to use the now bundled definitions file!
I do not want use the old /// method, it is deprecated as of latest typescript versions.
Any advice for me? Thanks!

Also the below:
import * as Sugar from "sugar";

Leads to

"File '.../node_modules/sugar/sugar.d.ts' is not a module

This isn't a exactly a duplicate, but can we move this over to #529? The typescript definitions just went out, and they likely need some help here. I didn't know, for instance, that the /// method was deprecated -- we've been proceeding on that thread with that as the assumption. Maybe you can provide some insight here?


Refactoring and updating new features (v0.1.1)

Refactoring OpenBioSeq to v0.1.1 and supporting the following features:

Refact code structures according to OpenMixup.
Support the online document for OpenBioSeq (built on Read the Docs).
Support new backbone architectures for both 1D and 2D sequences.
Support more regression losses (Focal L1/L2 loss, Balanced L1 loss, Balanced MSE loss) and more regression metrics in the regression dataset.
Update training settings and benchmarks to support self-supervised learning (SSL) methods (e.g., new methods and benchmark configs).
Refine the setup for the local installation and PyPi release in setup.py and setup.cfg. View PyPi project of OpenBioSeq (commit https://github.com/Westlake-AI/OpenBioSeq).

We will release OpenBioSeq v0.1.1 after code refactoring.

Refine the setup for the local installation and PyPi release in MANIFEST.in, setup.py, and setup.cfg. View PyPi project of OpenBioSeq (commit https://github.com/Westlake-AI/OpenBioSeq/commit/d8c1c9a710e696313eaa490c65acf4f69aaa0be2).