Error while trying to add page from a copy

What were you trying to do?
I was trying to add a page in a new PDF Document from another file
How did you attempt to do it?
Below is all my code, with comments
My file is "gestionPDF.mjs", ran with "nodemon" /node.js v19.3.0
/*
fichier dédié aux PDF
*/

import { degrees, PDFDocument, rgb, StandardFonts } from 'pdf-lib';
import * as fs from 'fs';

export async function fabriquePDF() {
    // lecture du template
    const template = 'PDF/TemplateBordereau.pdf';
    const contenuTemplate = fs.readFileSync(template);
    const T=await PDFDocument.load(contenuTemplate);
    const first=T.getPage(0);     // I added this to try to fix the Pb
    const { width, height } = first.getSize()       // also this

    // creation du nouveau document
    const pdfDoc = await PDFDocument.create();

    // copy du template en guise de fond
    const fond=await pdfDoc.copyPages(T,[0]);

    console.log(fond)       // OK
    console.log([width,height])     // OK : Known ([540,780])

    // ajout de la page
    pdfDoc.addPage(fond);           // Not Working (see just below)

    const pdfBytes = await pdfDoc.save()
    fs.writeFileSync("PDF/BIDON.PDF", pdfBytes);
}

fabriquePDF();

TemplateBordereau.pdf
What actually happened?
F:\SN100PC\Developpements\CPC_Back\node_modules\pdf-lib\cjs\utils\validators.js:140
throw new TypeError(exports.createTypeErrorMsg(value, valueName, types));
^
TypeError: width must be of type number, but was actually of type NaN
at exports.assertIs (F:\SN100PC\Developpements\CPC_Back\node_modules\pdf-lib\cjs\utils\validators.js:140:11)
at PDFPage.setSize (F:\SN100PC\Developpements\CPC_Back\node_modules\pdf-lib\cjs\api\PDFPage.js:100:17)
at PDFDocument.insertPage (F:\SN100PC\Developpements\CPC_Back\node_modules\pdf-lib\cjs\api\PDFDocument.js:606:26)
at PDFDocument.addPage (F:\SN100PC\Developpements\CPC_Back\node_modules\pdf-lib\cjs\api\PDFDocument.js:565:21)
at fabriquePDF (file:///F:/SN100PC/Developpements/CPC_Back/gestionPDF.mjs:28:12)
*/
What did you expect to happen?
BIDON.PDF
How can we reproduce the issue?
I think you have all elements . If not : please mail me : samuel.landis.btlc -at- gmail.com
Version
1.17.1
What environment are you running pdf-lib in?
Node
Checklist

[X] My report includes a Short, Self Contained, Correct (Compilable) Example.
[X] I have attached all PDFs, images, and other files needed to run my SSCCE.

Additional Notes
Thank You !!!

This error occurs because you're passing something that isn't a page. In my case, it was an array of pages.

Any updates?


Package 'jellyfish-2.0', required by 'virtual:world', not found

When i have download pangenie from github  and install jellyfish-2.2.10 by conda.  The error :
-- The C compiler identification is GNU 8.5.0
-- The CXX compiler identification is GNU 8.5.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Found PkgConfig: /usr/bin/pkg-config (found version "1.4.2")
-- Found ZLIB: /usr/lib64/libz.so (found version "1.2.11")
-- Checking for module 'jellyfish-2.0'
--   Package 'jellyfish-2.0', required by 'virtual:world', not found
CMake Error at /usr/share/cmake/Modules/FindPkgConfig.cmake:556 (message):
A required package was not found
Call Stack (most recent call first):
/usr/share/cmake/Modules/FindPkgConfig.cmake:778 (_pkg_check_modules_internal)
CMakeLists.txt:11 (pkg_check_modules)
-- Configuring incomplete, errors occurred!

The same issue. Did you find a solution?

with the provided yaml file, I succeeded.

@liukeweiaway did you install PanGenie with the conda environment provided in the yaml file (as described in the README)?


SWITCHYARD-2979 Transformer invoked from getContent() should also handle Message parameter

https://issues.jboss.org/browse/SWITCHYARD-2979

This is Tomo's fix from SWITCHYARD-2979.


Increase flexibility regarding development dependencies.

Inspired by this comment of @mkniewallner
https://github.com/fpgmaas/deptry/issues/162 proposes to add support for PEP-621. However PEP-621 does not provide any standards for dealing with development dependencies. Currently, deptry has no implemented method to extract development dependencies for such a project.
AFAIK, there are now two main methods of specifying development dependencies for these projects:

As a category/multiple categories under [project.optional-dependencies] in pyproject.toml. A drawback of this approach is that this adds an installation option to end-users, e.g. pip install package[dev], which may be undesirable.
Outside of pyproject.toml, for example in a separate dev-requirements.txt

My initial proposal was to add a CLI command that allows the user to specify which entries under [project.optional-dependencies] are development dependencies, e.g.
[project.optional-dependencies]
develop = ["pytest", "pytest-cov"]
rest = ["docutils>=0.3", "pack ==1.1, ==1.3"]

deptry . --dependencies-dev-keys develop

But this only supports (1) from the above listed ways to specify development dependencies. We might want to provide end-users with more flexibility regarding the detection of development dependencies than we currently support.
On the other hand, we should balance between flexibility and overengineering. I do think additional flexibility only is needed for projects that uses PEP-621 (for now), since for the other projects it's quite straightforward. Below a table of all reasonable combinations I think can occur.

requirements-dev.txt
Poetry
PDM [tool.pdm.dev-dependencies]
PEP-621 [project.optional-dependencies]

requirements.txt
x

Poetry

x

PDM [project] dependencies

x

PEP-621 [project] dependencies
x

x

close as duplicate


fixed the bug: UI of video page is cluttered #313

PR Fixes:

1 fixed the bug: UI of video page is cluttered

Resolves #313
Checklist before requesting a review

[x] I have performed a self-review of my code
[x] I assure there is no similar/duplicate pull request regarding same issue

https://github.com/code100x/cms/assets/89733575/9b50645b-cddd-407e-8aa6-4bd0c06c0a43

closing, already fixed


Collection/Carousel-View, Shell

Not every of this control is working currently correctly.
Collection works fine for iOS but not Android.
Carousel seems to work on Android but not iOS.
Shell needs a Test.
It would be great if we could make this work.

Noticed it as well.
I couldn't make Shell work on iOS for some reasons (only a blank page, a top black header and a page title), while it worked fine on Android. (only tested it for 10min)
Also ShellContent doesn't work (it wants View and not ViewElement)
With this test, I also found that we may be able to simplify the nesting when using Shell.
Today, XF handles it with implicit conversion.
Something we don't have

Shell needs some specific parts which I think we do not include but I need to check this before I can clearly say which.

Shell is definitely too complicated to use today in Fabulous (when ignoring blocking bugs)
See this issue for a super simple Hello world: https://github.com/fsprojects/Fabulous/issues/427

That's right. It is the 'old' style - the way in 3.5. With 4.0 it is possible to make it a lot easier but this needs some changes in converting the viewparts.

@SergejDK I'm currently trying to re-implement the Xanimals sample from Xamarin.Forms to iron out our implementation of Shell.
I will make it part of our samples too.

@TimLariviere great thing! I think everyone will appreciate this.

@TimLariviere do you have your effort for the Xanimals sample in a repo anywhere?

@PureWeen Yes, here: https://github.com/TimLariviere/Fabulous/tree/xaminals
Still very WIP, had to change quite a lot of things.
Shell is not the mostly functional-friendly control. 😄
It might not be easy to read the change log because I split Fabulous.Core into several projects for better extensibility in the future.
Overall the sample is working for the most part. Still have to fix:

Routing
FlyoutHeader not showing
SearchHandler.ItemsSource not removing items from UI, even though it's an ObservableCollection behind the scenes

Once everything works as expected, I will refactor my changes and prepare it for a pull request.

I'm having a hard time with Routing.
The way it works in Shell is just not applicable to Fabulous, and I can't find a way to workaround.
The page being navigated to needs to declared inside the main view function to access the model.
But Xamarin.Forms requires to declare routes ahead of time so it can creates the pages on the fly.
Then these pages are managed internally, no way to access the current model...

@TimLariviere would resolving this issue help you?
https://github.com/xamarin/Xamarin.Forms/issues/5166
If we provided some additional places for Fabulous to hook into?

@PureWeen Yes, that would be really helpful.
I'll try to think of what Fabulous would need ideally and share my views in this issue.

@TimLariviere that sounds great!! I'm working on figuring out the best way for shell to compose and recompose itself so I'd really like to have something that plays cleanly with Fabulous. Kind of like a small version of the MVU loop :-)
Something happens on shell -> you tell shell how you want it to change -> it changes
I'd like for users to always be able to have an entry point, like the update function, where they can modify aspects of the shell like the look and the stack.
I think by trying to make this work super well for Fabulous we can end up with some really useful things on the non fabulous side as well. If you ever want to chat over skype or anything about shell and where you're having issues let me know
shneuvil at microsoft.com

The issue for the problem with the ContentView in CollectionView and CarouselView: https://github.com/xamarin/Xamarin.Forms/issues/6461.
If we could replace the base class for the ItemTemplate I think it should work for now.
(Currently trying it out)

I'm working on figuring out the best way for shell to compose and recompose itself so I'd really like to have something that plays cleanly with Fabulous. Kind of like a small version of the MVU loop :-)

@PureWeen That's awesome! :)
I will contact you as soon I figure out my planning.
I could use a deeper insight of the current inner workings of Shell as well. 😄

If we could replace the base class for the ItemTemplate I think it should work for now.

@SergejDK What do you mean? Only ContentView doesn't work inside a CollectionView?

@SergejDK Oddly CollectionView works in #445

@TimLariviere
will take a look on this. On Android it works??

Yes, it works both on Android and iOS.

@TimLariviere
found the solution for now with CollectionView....
If you use a Layout-class like StackLayout, FlexLayout, Grid etc. as the itemsproperty e.g.:
View.CollectionView(items= [
    View.StackLayout( children = [
        View.Label(text="Person 1")
])
    View.Grid(children=[View.Button(text="ok")])
])

it renders all correct. Using a simple Element in the collectionview as Label or Button won't render it currently.

@TimLariviere
CollectionView and CarouselView works with <IP_ADDRESS>6342-pre2.
It was a problem with XF and ContentView as I wrote before.
So with the release of 4.1 we should be good on this!

closed by #511


minimal requirements?

Solution to issue cannot be found in the documentation.

[X] I checked the documentation.

Issue
I notice that the requirements include:
- cf_xarray
- cmocean
- dask <=2022.05.0
- matplotlib-base
- netcdf4
- numba
- numpy
- python >=3.7
- pytest
- requests
- scikit-learn
- xarray
- xcmocean
- xoak

Most of these are indeed hard requirements, but some I assume are only required if you want to do visualization, etc, e.g. Cartopy, matplotlib, etc.
I think with conda packages, it's best to have as requirements only those packages that are required for core functionality.
Anyone that's using cartopy will know they need to install it anyway :-)
The challenge with being comprehensive is that folks then need to install a lot of unneeded stuff on production systems.
oh, and pytest shouldn't be included either.
Installed packages
not relevant

Environment info
not relevant

This is being addressed in the new version: https://github.com/conda-forge/extract_model-feedstock/pull/20


Unlock environments on pull request merge

Describe the Issue
I am trying to recreate the locking feature of the Atlantis workflow using the branch-deploy action.
In Atlantis, it is possible to configure a workflow behavior where a lock is acquired on terraform plan for a set of directories, and the lock is released after the pull request is successfully merged into the main branch.
When running terraform apply before a pull request is merged, the main branch ceases to represent the most current version of the infrastructure. Locking ensures no further changes occur until the PR is merged, keeping the infrastructure representation intact. More reasoning behind this concept is well explained in Atlantis documentation.
I believe incorporating a similar locking feature would be a significant improvement for Terraform users of this action. This is particularly relevant given that Terraform is showcased as one of the main usage examples.
When using the branch-deploy action, it is easy to implement the first part of the locking feature, i.e., acquire a lock on terraform plan (or apply) using the lock action. However, it is problematic to release the lock on the pull request merge (e.g., using the on: pull_request[closed] trigger). The main difficulty lies in obtaining the list of active locks to release.
I would genuinely appreciate any insights you might have on implementing this functionality. Perhaps, I missed some details in the documentation or usage examples.
Action Configuration
No response
Relevant Actions Log Output
No response
Extra Information
No response

I managed to implement this using the following workflow configuration:
name: Release deployment locks

on:
  pull_request:
    types: [closed]

permissions:
  deployments: read
  contents: write

jobs:
  release-locks:
    runs-on: ubuntu-latest

    steps:
      - name: Checkout code
        uses: actions/checkout@v3

      - name: Remove active deployment locks
        env:
          GH_REPO: ${{ github.repository }}
          GH_TOKEN: ${{ github.token }}
        run: |
          environments=$(gh api "/repos/{owner}/{repo}/deployments?ref=${{ github.head_ref }}" | jq -r '.[].environment | select(. != null)' | uniq)

          for environment in $environments; do
              lock_branch="$environment-branch-deploy-lock"

              echo "Checking lock: $lock_branch"
              if gh api --method GET "repos/{owner}/{repo}/git/refs/heads/$lock_branch" > /dev/null 2>&1; then
                  echo "Deleting lock: $lock_branch"
                  gh api --method DELETE "repos/{owner}/{repo}/git/refs/heads/$lock_branch"
              else
                  echo "Lock does not exist: $lock_branch"
              fi
          done

@bzurkowski This is soon coming as a fully native feature of this Action, so keep your eyes out :eyes: for a new major release!

@bzurkowski You are most welcome! v6.0.0 is now in pre-release if you want to test it out! :tada:


OADP-3654: fix CVE CVE-2024-24786

@weshayutin This one is upstream in main. That will come in during the next rebase from main (we're overdue for that). oadp-1.3 PR is fine, since that hasn't been resolved upstream in the release branch.

Closing for now, since it will come in via rebase.


PHOENIX-6437: Parent-Child Delete marker should get replicated via Sy…

…stemCatalogWALEntryFilter

With this PR we are fixing the bug where delete markers for parent-child link rows do not get replicated via SystemCatalogWalEntry Filter for tenant views.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 36s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ 4.16 Compile Tests _

+1 :green_heart:
mvninstall
15m 24s
4.16 passed

+1 :green_heart:
compile
1m  9s
4.16 passed

+1 :green_heart:
checkstyle
0m 30s
4.16 passed

+1 :green_heart:
javadoc
0m 49s
4.16 passed

+0 :ok:
spotbugs
3m 23s
phoenix-core in 4.16 has 945 extant spotbugs warnings.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
6m 50s
the patch passed

+1 :green_heart:
compile
1m 10s
the patch passed

+1 :green_heart:
javac
1m 10s
the patch passed

-1 :x:
checkstyle
0m 31s
phoenix-core: The patch generated 6 new + 8 unchanged - 0 fixed = 14 total (was 8)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
javadoc
0m 51s
the patch passed

+1 :green_heart:
spotbugs
3m 40s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
199m 44s
phoenix-core in the patch passed.

+1 :green_heart:
asflicense
0m 10s
The patch does not generate ASF License warnings.

236m 36s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1219/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/1219

JIRA Issue
PHOENIX-6437

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile

uname
Linux b2b42220db37 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
4.16 / e3c8ac0

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1219/2/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1219/2/testReport/

Max. process+thread count
4919 (vs. ulimit of 30000)

modules
C: phoenix-core U: phoenix-core

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1219/2/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


Hn uuid

Add UUID and Base_img info to the show_headnode function. However, cannot find the column of the name of the virtual machine in the data base.
For the unit test case, I am having trouble of retrieving the 'uuid'. Since there is no any function such as get_headnode_uuid(), I cannot check whether the show_headnode() outputs a correct uuid. Seeking for help to solve this issue.

Also, I am having a hard time for switching the branch. Trying to create a new branch using git checkout -b hn-uuid, and make some changes over there. However, after I commit the changes, I cannot push the code upstream to my own repo.


Separate Promise.prototype.finally from Promise polyfill

The reason for the separation is because modern browsers support Promise but not Promise.prototype.finally. If we bundle this method with the Promise polyfill then users who wanted this method on modern browsers would have to download the whole Promise polyfill, which is over 4KB.

The proposal is stage 2, I can see the specification document needs updating to reflect that, sorry for the confusion caused.
I'll revert the Yaku change so that we carry on using the latest version (which includes Promise.prototype.finally). I'm tempted to not include the Promise.prototype.finally tests in the Promise test suite as it would show all modern browsers as not supporting Promises in our compat data which we display on the features page of the website.


useSearch issue: Undefined is not an object (evaluating 'opts.select')

Which project does this relate to?
Router
Describe the bug
There seems to be an issue with this line of code: https://github.com/TanStack/router/blob/5cc2f9f1b0cb6b7ca4d2f19382b3f08d6f3daa60/packages/react-router/src/useSearch.tsx#L35
I didn’t get this error a few days ago. If I override the select option, it works. It seems like useParams also has the same issue.
Your Example Website or App
I can’t share
Steps to Reproduce the Bug or Issue
I’m not sure how to reproduce other than install the package and try using the useSearch hook.
Expected behavior
I shouldn’t get that error.
Screenshots or Videos
No response
Platform

OS: macOS
Browser: Safari
Version: 1.74.4
Node: 22.7.0

Additional context
No response

If I change the code (in Chrome) to opts?.select it seems to work fine.

useSearch (and useParams) have a mandatory opts param, so you cannot just call useSearch()

In docs, it's still marked as optional https://tanstack.com/router/latest/docs/framework/react/api/router/useParamsHook

@msantic PRs are always welcome to fix docs


Memory Leaks in IE and Firefox

I have an application developed using OL3, in which maps can be recreated quite often. My problem is that when I "destroy" a map and create a new one I'm seeing a constant increase in memory utilization looking at the task manager.
I have created a basic fiddler with the problem here: http://jsfiddle.net/aLyrc95u/. It can be reproduced by clicking on create and destroy maps button and looking at the task manager.
My app has many other features than this basic example so the increase in memory is even more drastic. On Chrome it seems to work just fine but on IE 11  and Firefox the memory goes crazy.
I am not sure if I correctly release OL3 resources or this is a browser related problem. The code for cleaning old maps is the one presented in the fiddler.

See also #3420


fortran module breaks under -r8 or -fdefault-real-8

ifort's -r8 and gfortran's -fdefault-real-8 cause LIBXSMM_SINGLE_PRECISION and LIBXSMM_DOUBLE_PRECISION to be the same, causing double implementations of all the calls that differ only in precision.  I can think of a few solutions:

Don't change anything; codes shouldn't be using -r8 anyways.
Define LIBXSMM_SINGLE_PRECISION using selected_real_kind
Define LIBXSMM_SINGLE_PRECISION as 4
If BLAS had a true interface, then I'd go with (1), but seeing as LIBXSMM_SINGLE_PRECISION being defined as anything other than 4 would break the underlying SGEMM call, I think (2) and (3) are more flexible for right now.  The difference there should be mostly aesthetic.  Thoughts?

@hfp I've done (2) or (3) in my local copy.  If you want to go that route, I'll open a PR.

#7 took the (3) approach, which is definitely the simplest.  Close if you think that is adequate.

yes. let me close this for now and I'll update the whole F90 interface issue we have open.

Perhaps we need to introduce an ILP64/LP64 build option if this is something people will need frequently.

I think -r8 is ugly and wrong, but it is absolutely necessary for Nek5000 and other implicitly typed fortran programs, of which there are many.  I could probably compile NekBox without it, with a little effort.  You could also go the FFTW route and offer different 'legacy' and 'modern' fortran interfaces.

For the REAL I am planning to settle the following:
LIBXSMM_SINGLE_PRECISION = SELECTED_REAL_KIND(6, 30)
LIBXSMM_DOUBLE_PRECISION = SELECTED_REAL_KIND(14, 200)
For LIBXSMM_INTEGER_TYPE, I will adjust wrt LP64 (32-bit) or ILP64 (64-bit).

The problem with the current KIND of our REAL types can be shown using the NAG compiler (KIND(1): single, and KIND(2): double precision).

Are you sure this matches IEEE754? The number are quite a bit off. This would be perfect IEEE754:
LIBXSMM_SINGLE_PRECISION = SELECTED_REAL_KIND(7.22, 38.24)
LIBXSMM_DOUBLE_PRECISION = SELECTED_REAL_KIND(15.95, 307.95)
This is what says (http://fortranwiki.org/fortran/show/Real+precision) which is closer to IEEE, but still sp looks weird:
integer, parameter :: sp = selected_real_kind(6, 37)
integer, parameter :: dp = selected_real_kind(15, 307)
integer, parameter :: qp = selected_real_kind(33, 4931)

Let's adopt proven code: https://github.com/cp2k/cp2k/blob/intel/cp2k/src/base/kinds.F#L31

Can you create a bit-wise comparison example. I experimented in the past with the gnulibs and you can get what ever you want. This definition clearly differs from IEEE754 as we call assembly and C we rely on IEEE754 and have to make sure that we are not getting some gnu internal representation.

Commit 4e58958b50eb779620704e0c8d9b7efbf80a2243 removes any LIBXSMM-induced KIND for REAL types while keeping the MODULE PROCEDURE overloads intact (distinction relies on C_FLOAT vs. C_DOUBLE providing a fixed type-width). I've checked the NEK sample collection using "-fdefault-real-8 -fdefault-double-8", and it worked. Therefore this issues will be closed again. Any future compatibility requirement e.g., Fortran 77 conformance will be covered in a new issue.


Fix linting for rna-transcription exercise ( #480 )

@tarunvelli again, merge conflicts!  If you don't mind resolving this looks good to merge.


Align end-of-encode stats to what AOMAnalyzer would show

AOMAnalyzer shows the percentage of pixels in a frame
that comprise each block size or transform type.
This commit updates rav1e to do the same.

Coverage increased (+0.004%) to 75.542% when pulling 8c5f806c9711601f9830345849ed6bdbf3dd15de on shssoichiro:fix-verbose-pcts into b45684e88cf1986d3651f4817921ecedfd59f441 on xiph:master.

Agreed, we had a brief discussion a couple of months ago because this mismatch was discovered. We never came to a hard conclusion, but I think it would be less confusing if we were consistent with other commonly used tooling.


EQL syntax doesn't work

Hi all,
the EQL statement mentioned as an example, doesn't work, and the error is related to boolean condition.
(type.id = 2 or type.id = 3) and type.name == "Farm"
Could you please check the statement ?
Thanks a lot.

This should be (type.id = 2 or type.id = 3) and type.name = "Farm". I just updated the Readme, thanks.
Note the single = instead of the double ==. This is because in EQL there is no assignment so I used the single = for "equals". Given the audience that might have to be revised.

Hi All,
sorry but It doesn't work yet.
Do I open a new issue for this error ?
However, may thing doesn't work, for example:

Not equals, It's not exposed any example.. I've tried with "!=", "!==",  "<>", but nothing
Or, And condition doesn't work

So is It possible to understand these errors ?

Do you have a more detailed example of how you're trying to use this?

Consider my model (more less identical the yours)

// and, the value of request.Query is "(type.id = 1 or type.id = 2)", like your example

If you try OrElse as indicated in the exception message, it's consider the first part of query, so "(type.id = 1".
you can reproduce this error with a simple Unit Test.

Sorry, this is an issue with how the parser takes the order of the operators (here being =, orand=`).
You can fix this now with explicitly defining your order with brackets like you would else where. So the query becomes (type.id = 1) or (type.id = 2)
I updated the Readme, I'll look at another time on making the operators order better/smarter

Hi,
like that works, but I have another questions.. How does it work for the others operators ?
example:

(type.id != 1)
usage of linq methods (where(), order(), take(), skip())

The ideal would be to do an example which you have a complex query criteria, with a projection of data... maybe following the same Data model expose in the Readme.
Thanks


Add code owners

What enforces this?

This is a github owner file, that means you will be added as reviewer for change to go file.


Feature/idva6 1467 refactoring - sonar qube issues fixes

Link to Jira:
https://companieshouse.atlassian.net/browse/IDVA6-1467
Changes:

Unnecessary type assertions removed
Duplicated import removed

CI: No security warnings found


Results with Ignatius not reproducible due to problematic intrinsics file in data

@apchenstu Hi! Thanks for this amazing project. Unfortunately I found that the intrinsics.txt file of "Ignatius" in Tanks & Temples seems wrong, as it looks like colmap instead. When I try to replicate results by training TensoRF on Ignatius, it gives the following error:
ValueError: The number of columns changed from 4 to 3 at row 2.
Any solutions and fixes? Thanks a bunch in advance.

https://github.com/sunset1995/DirectVoxGO/issues/4

Thank you!


Terminus freezes

Version: 1.0.134
Platform: win32 10.0.18363
Plugins: none
In multiple times the console freezes when I want to close it. Yesterday took it to the extreme and freeze the entire operating system.

Maybe it's similar to #3604. Could you check Terminus' CPU/memory usage when it freezes?


fix(events): Adds config flag. Reduce number of dupe events emitted.

Checklist:

[x] Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
[x] The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
[x] I've signed the CLA.
[x] I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
[x] My builds are green. Try syncing with master if they are not.
[x] My organization is added to USERS.md.

Changes

Adds a new flag to disable node events. I'm hoping we won't need this, but just in case.
Use EventRecorder to batch events.

Testing
I've not added an e2e test for the flag, because this is not default behaviour. So this must be tested manually.

@sarabala1979 do you think you might be able to review this in the next day or two please?


Add symbolic links as alternative to hard links

Potential improvements on top of the mere bug fix for #519:
Add a --link-method {hard|soft|copy},... command line argument and implement the soft method using symbolic links.
The default should be --link-method=hard. To try hard links first and then fall back to copies, the user would specify --link-method=hard,copy.
Any errors that occur during the actual linking should cause a diagnostic message to be printed that alerts the user of the --link-method option.

I think there currently is some code that looks at st_nlink. That logic would be thrown off by alternating between hard and soft method. Switching between hard and copy or soft and copy should be fine.
Consider persisting the link method in the filestore so that the problematic transitions can be avoided.
Note that changing the filestore format should require bumping the filestore version. If we don't bump the version, filestores created by older CLI releases would break the release that includes this feature and vice versa.


Fix typo for releasing arm64 linux

@achew22 I think I made a typo in https://github.com/bazelbuild/bazel-watcher/pull/578 🤦
Also all the mac artifacts are gone in https://github.com/bazelbuild/bazel-watcher/releases/tag/v0.21.1.. Any ideas why?

Look's like the mac books was aborted because of the linux build error: https://github.com/bazelbuild/bazel-watcher/actions/runs/3874388934/jobs/6605520062

Seems like a reasonable attempt to me. Let's see what the release says now

Seems like a reasonable attempt to me. Let's see what the release says now

the darwin-arm64 build failed.... but I tried to run the same command on my M1
> bazel build //cmd/ibazel:ibazel --config release --platforms=@io_bazel_rules_go//go/toolchain:darwin_arm64_cgo
...
        ^
external/com_github_protocolbuffers_protobuf/src/google/protobuf/descriptor.cc:1048:9: warning: passing variable 'unknown_enum_values_by_number_' by reference requires holding mutex 'unknown_enum_values_mu_' [-Wthread-safety-reference]
        unknown_enum_values_by_number_, std::make_pair(parent, number));
        ^
2 warnings generated.
Target //cmd/ibazel:ibazel up-to-date:
  bazel-bin/cmd/ibazel/ibazel_/ibazel
INFO: Elapsed time: 29.763s, Critical Path: 6.05s
INFO: 193 processes: 4 internal, 189 darwin-sandbox.
INFO: Build completed successfully, 193 total actions

Let me try to reproduce on my fork: https://github.com/xinbinhuang/bazel-watcher/actions/runs/3880935795


issues when trying to hide the menu button

Hi, I want to hide this menu button from the UI.

but I get errors when I try to paste the code. should I place it somewhere else ? do I have to initialize anything before pasting the code? I really appreciate any explanation.

Hi it seems like you are intended to use custom ui but you are using webui.Custom ui doesnt add menu button by default so that button comes from webui.Meaning that function(showMenuButton) wont work for webui menu button anyways, The only way to remove that is removing that element with js.
Which i already answered similar question, Here : #885

So, I have to get into "ayp_youtube_player.html" file (the one you mentioned in #885) and write some code in order to remove that? I really can't find any file with that name

To be able to edit the library you have to add this library as a module not implementation way or you can search the internet for alternative way

To be able to edit the library you have to add this library as a module not implementation way

Thanks a lot. Just one more question, please. If I edited the webUi or just covered these 3 dots button with something (like a useless button) just so the user won't be able to share the video, will be that a problem if I tried to publish my app on Google Store?

It might be a problem, you're not supposed to alter the UI of the web player.


tools: scale and shift vertex and edge weights for METIS and SCOTCH

These tools cannot handle null weights for vertices nor edges, so the input weights are "zoomed in" so that the sum of the weights plus one is INT_MAX.
Closes #220
TODO

[ ] edge weights are scaled independently from vertex weights, decide whether this is good or bad and add a comment
[ ] recover multi-criteria support for metis
[ ] return an iterator instead of a Vec

edge weights are scaled independently from vertex weights, decide whether this is good or bad and add a comment

Seems OK to me.


Fix failed tests after upgrading to JDK 17

@bot-gradle test and merge

OK, I've already triggered a build for you.


"Associated of" to "Associated with"

Members
The members of a class are either static members or instance members. Static members belong to classes, and instance members belong to objects (instances of classes).
The following list provides an overview of the kinds of members a class can contain.
Constants: Constant values associated with the class
Fields: Variables that are associated of the class
Methods: Actions that can be performed by the class
Properties: Actions associated with reading and writing named properties of the class
The definition of constants and the definition of fields are a bit confusing at first. Using "associated with" and "associated of" respectively can indicate a difference between those two members based on the prepositions used with 'to associate'.
However, I could not find anything on the internet that explains the meaning of 'to associate of' so i guess this is a typo?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3148b5e9-550e-67c9-eb13-907cb78f7fe7
Version Independent ID: c723989f-2ff6-389d-dcb4-f55d97d14501
Content: The building blocks of C# programs'
Content Source: docs/csharp/tour-of-csharp/program-building-blocks.md
Product: dotnet-csharp
Technology: csharp-get-started
GitHub Login: @BillWagner
Microsoft Alias: wiwagn

Related to #22805
This should be "associated with", not "associated of". Further, the distinction between instance and static fields should be mentioned.

This was fixed by #23593 and can be closed


Document schema IDs for dsnp/instant-seal-node-with-deployed-schemas

The Docker image dsnp/instant-seal-node-with-deployed-schemas should also publish an Overview to DockerHub with some minimal descriptive documentation, including the schema IDs in the contained image.
Currently, as of v1.8.1, the schema IDs match mainnet (as documented here), but that is not always guaranteed to be the case going forward.

I added machinery to return the schema mappings as the output from cli/deploy.ts::deploy().
It looks like this (prettified):
[
  {
    "schemaName": "tombstone",
    "id": 1
  },
  {
    "schemaName": "broadcast",
    "id": 2
  },
  {
    "schemaName": "reply",
    "id": 3
  },
  {
    "schemaName": "reaction",
    "id": 4
  },
  {
    "schemaName": "profile",
    "id": 5
  },
  {
    "schemaName": "update",
    "id": 6
  },
  {
    "schemaName": "publicKey_keyAgreement",
    "id": 7
  },
  {
    "schemaName": "userPublicFollows",
    "id": 8
  },
  {
    "schemaName": "userPrivateFollows",
    "id": 9
  },
  {
    "schemaName": "userPrivateConnections",
    "id": 10
  },
  {
    "schemaName": "publicKey_assertionMethod",
    "id": 11
  }
]

Naively, we could make npm run deploy write this to a file or do a template transform; would that be sufficient for the docker image? Is there a specific filename it looks for?

I added machinery to return the schema mappings as the output from cli/deploy.ts::deploy().
It looks like this (prettified):
[
  {
    "schemaName": "tombstone",
    "id": 1
  },
<...>
]

Naively, we could make npm run deploy write this to a file or do a template transform; would that be sufficient for the docker image? Is there a specific filename it looks for?

Unfortunately, this isn't what I was driving at, and I don't really see a way to achieve what I wanted: the description of an image hosted on Docker Hub is controlled by the LABEL description = ... tag inside the Dockerfile itself.
Having a file inside the image with the deployed schema IDs is probably fine for now, though, especially if we're close to a solution for schema names, which would eliminate the need for publishing known schema IDs.

With proposed changes in #46 you should be able to get deterministic answers from dsnp.getSchemaId() (or treat the code for the "default" schema mapping as documentation for instant-seal-node). But let me know if you think more is needed.


Add sonar scanner to CI

This PR is created to check how it works and if it makes sense to actually integrate it.
Closes #42

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 97.269%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
748

Relevant Lines:
769

💛  - Coveralls


Get (padded) footprint from costmap when footprint_model/type parameter is missing

Any reason why TEB doesn't use costmap's footprint? Feel free to close this if there's a reason I'm missing
PS. Ignore whitespaces... my editor removed plenty, obscuring the actual changes, that I did as much minimal as I could

OK, I understand why after reading "How Obstacle Avoidance works" tutorial.


Upgrade alpine and node version

Do we need to update the windows container node version?

Do we need to update the windows container node version?

Please add in your PR description "How built" and "How validated" sections

Please add in your PR description "How built" and "How validated" sections

Do we need to update the windows container node version?
It is not needed for debugging purposes. However, I can upgrade to the latest version 12 if you think we should stick to the latest?

Do we need to update the windows container node version?
It is not needed for debugging purposes. However, I can upgrade to the latest version 12 if you think we should stick to the latest?


Keyboard shortcut for "Select All" doesn't work in certain input text fields

Issue Type: Bug
With OS X (I've tested 10.11 El Capitan and 10.12 Sierra), some input fields doesn't respond to the common Command-A keyboard shortcut, although Command-Xor Command-V work as expected for example.
I've encountered the issue with extension related windows :

PlatformIO : input field « Search libraries… »
Git History : input search field

"Pure" VSC search fields work as intended and they display a local menu with a right click whereas the extensions' ones doesn't.
VS Code version: Code - Insiders 1.24.0-insider (bfd155e6039f64d2795c6b514a029ebd01a33527, 2018-05-29T06:13:09.810Z)
OS version: Darwin x64 15.6.0
https://github.com/platformio/platformio-vscode-ide/issues/67

System Info
|CPUs|Intel(R) Core(TM)2 Duo CPU     P8600  @ 2.40GHz (2 x 2400)|
|GPU Status|2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: disabled_offnative_gpu_memory_buffers: enabledrasterization: unavailable_softwarevideo_decode: enabledvideo_encode: enabledvpx_decode: enabledwebgl: enabledwebgl2: enabled|
|Load (avg)|2, 2, 2|
|Memory (System)|8.00GB (0.42GB free)|
|Process Argv|/Applications/Visual Studio Code - Insiders.app/Contents/MacOS/Electron -psn_0_1245488|
|Screen Reader|no|
|VM|0%|

Extensions (10)
Extension|Author (truncated)|Version
beautify|Hoo|1.3.0
vscode-markdownlint|Dav|0.17.0
vscode-eslint|dba|1.4.10
vscode-html-css|ecm|0.2.0
auto-close-tag|for|0.5.6
cpptools|ms-|0.17.3
printcode|nob|2.3.0
vscode-icons|rob|7.23.0
vscode-arduino|vsc|0.2.15
html-css-class-completion|Zig|1.17.1

Those are webviews where input aren't controlled by VS Code. Please open issue in the extension's repository.

I think this is a issue of vscode. I can reproduce in by create a webview and put an "input" inside it. The reason should be vscode first intercept the "cmd" + "a" keyboard event and map to vscode host "select all" and doesn't send the event to the input inside webview.

@mjbvz


Profile endpoint times

What is needed?
Know how long takes for an endpoint to return the result, so we can find bottlenecks
Proposed solutions

Add elapsed time to the logs
Parse them on Kibana

Implemented on staging, pending on devops to move it to production

Implemented on staging, pending on devops to move it to production

@Uxio0 is there a Kibana dashboard for this?
I only found https://logs.gnosis.io/app/kibana#/dashboard/1e7efa80-8dfa-11ea-91fe-73ebc1c30edf

This is the dashboard, but there are some issues with the logs not being filtered devops are checking: https://logs.gnosis.io/app/kibana#/dashboard/faa19a80-5ef7-11eb-af57-6961fcf94ae7


Support Alpine 3.9 and 3.10

Details of the Distribution

Name of the Distribution: Alpine
Version of the Distribution: 3.9 and 3.10
[x] The version of the Distribution is supported for at least one year.
[x] The version of the Distribution is not an interim release or equivalent.
[x] The version of the Distribution is supported by .NET Core.
[x] An issues has been filed to create a Docker image in https://github.com/powershell/powershell-docker

Progress - For PowerShell Team ONLY

[x] Docker image created
[x] Docker image published
[x] Distribution tested
[x] Lifecycle updated
[x] Documentation Updated

There is NO CIM, PowerShell remoting, or DSC support on this platform.

https://github.com/MicrosoftDocs/PowerShell-Docs/pull/4903


rm inter sample/prep tables and fixing tests

Removing:

study_sample_columns table
prep_columns table
type_loookup
get_datatypes
cast_to_python
as_python_types
convert_type

This also includes the code to transform all tables to varchar but is commented cause it increases the testing time dramatically.

👍

Changes Unknown when pulling 35a7dee49bc2e962253a1f610e3db903243a6031 on antgonza:rm-inter-tables into ** on biocore:str-ing_info_fles**.

Changes Unknown when pulling 35a7dee49bc2e962253a1f610e3db903243a6031 on antgonza:rm-inter-tables into ** on biocore:str-ing_info_fles**.

@ElDeveloper, @wasade, @HannesHolste, do you guys have a (few) second(s) to review?

👍 once test pass

👍 once tests pass.

Looks good.

Changes Unknown when pulling 8d9c6553eede5c417cb8684214e7ca209bf70de0 on antgonza:rm-inter-tables into ** on biocore:str-ing_info_fles**.


Installer Error

Describe the bug
I have tried installing on Windows XP SP2 Supermium to my USB drive(D:\Supermium\SM118(x64)) and the installer refused to install, even when I deleted the folder, citing "Unspecified Error". The installer first deletes the folder then tries to install before throwing the error.
To Reproduce
Steps to reproduce the behavior:
1 -> Attempt to install Supermium 122 to USB/Directory on USB
Expected behavior
I expected it to install properly with no errors.
Screenshots

Desktop (please complete the following information):

OS: Windows XP SP2(Dell)
v122_xp32(Supermium version)

Additional context
Windows XP SP2 UNMODDED. Has all of the drivers properly installed.
Specs :
Dell Latitude X300
Pentium M CPU @1.40GHZ
631MB RAM to system
No video card(integrated)
30GB Hard Disk
Thanks,
Okmeque1

Why not SP3?

We must have the source code to be able to debug such problems on source level.
It is not proper, that code for installer component not published.

Why not SP3?

Don't want to upgrade. I know it will work on SP2, because what I had to do is install to a random directory on the C: drive then copy the contents of that random directory into a proper folder on my USB, which the installer was unable to do. And I also have more SP2 systems that I don't want to upgrade. I ain't got time to upgrade these systems to SP3, and most XP programs works on SP2 with no issues.

We must have the source code to be able to debug such problems on source level.
It is not proper, that code for installer component not published.

You could debug it with IDA :)

You are totally right. This is just a bug, which must be fixed.
Suggest to rename the topic to line like this:
[installer] "Unspecified error" while installing.
To be more standardized and filtered by component by developers

You could debug it with IDA :)

Its of course :). But its not fine for opensource project. I personally --can. But users - No .

... Related to / duplicate of #319 ...

Well, I can't install it to any directory on XP SP3 POS Ready.  I get the same error.  What's the workaround?

Looks like you have "(" and ")" in path. Could it be a reason?

Looks like you have "(" and ")" in path. Could it be a reason?

No, tried on a different directory(D:\recreatebug) and it still wanted it.

... Related to / duplicate of #319 ...

Not exactly, because instead of the installer completing properly the 2nd time for me it will never make it. Also I'm running XPSP2 so this is in fact not a duplicate of #319 , but more of a Related to.

As I say before, we just need to have source code for this installer, (the code is small and has no "knowhow"). So someone having troubes, If they are developers (even beginer developers). Can recompile this installer and find cause of the bug, and propose changes in the code.
The opensource projects intended exactly for that.

P.S I've tried the installer on Windows 10 and it returned this :

I have made a slight revision to the installer which should make it workable across multiple volumes (as just tested) and include an option that may be relevant to this method of operation, which is to not write to the registry on the system of installation.
MoveFileExW with MOVEFILE_COPY_ALLOWED does not work as intended with directories. I switched to SHFileOperation which seems to work the best out of all the options available.

Please retest your ticket @Okmeque1 with
Supermium 122.0.6261.85 Hotfix (R2)
it should be fixed now. Close your ticket in case it is fixed.

yay it works how I needed it to


Animated emotes from Twitch itself (not BTTV) do not animate

It's all in the title. These emotes play fine in the web browser but are static (first frame only) in Chatterino. This is true under all conditions and in all chats, I have thoroughly inspected all settings and options, BTTV animated emotes play just fine, but Twitch's do not.

This is fixed in latest nightly and (soon to be released) 2.3.3

Whoops, when did Github switch to hiding all closed issues by default?  I just saw you have this issue reported lots of times as a result. Sorry about that! Thanks for the quick response :)


Running on Heroku

Hi guys,
Just tried to get an instance of this running on Heroku and seems to be having some problems.
Was wondering if you might be able to point me to where things are going wrong.  Not a node expert but from the logs it looks like heroku might not be loading the child dependencies for the sample app when it builds perhaps?
Works well locally, can't wait to try it out!
2018-06-27T16:52:21.928989+00:00 heroku[web.1]: Starting process with command npm start
2018-06-27T16:52:25.456084+00:00 app[web.1]:
2018-06-27T16:52:25.456114+00:00 app[web.1]: ><EMAIL_ADDRESS>start /app
2018-06-27T16:52:25.456116+00:00 app[web.1]: > cd examples/demo-app && (path-exists node_modules || npm i) && npm run start-local
2018-06-27T16:52:25.456118+00:00 app[web.1]:
2018-06-27T16:52:25.469805+00:00 app[web.1]: sh: 1: path-exists: not found
2018-06-27T16:52:27.924482+00:00 app[web.1]: npm WARN deprecated<EMAIL_ADDRESS>🙌  Thanks for using Babel: we recommend using babel-preset-env now: please read babeljs.io/env to update!
2018-06-27T16:52:31.202342+00:00 app[web.1]: npm WARN deprecated<EMAIL_ADDRESS>Please update to 0.2.2+ for support of the latest react, improved browser support, and typescript definitions
2018-06-27T16:52:39.390601+00:00 app[web.1]: npm WARN deprecated<EMAIL_ADDRESS>This
2018-06-27T16:53:06.298841+00:00 app[web.1]: Error waiting for process to terminate: No child processes
2018-06-27T16:53:06.298841+00:00 app[web.1]: Error waiting for process to terminate: No child processes
2018-06-27T16:53:06.274702+00:00 heroku[web.1]: Error R10 (Boot timeout) -> Web process failed to bind to $PORT within 60 seconds of launch
2018-06-27T16:53:06.274840+00:00 heroku[web.1]: Stopping process with SIGKILL
2018-06-27T16:53:06.379927+00:00 heroku[web.1]: Process exited with status 22
2018-06-27T16:53:22.439036+00:00 heroku[web.1]: Error R10 (Boot timeout) -> Web process failed to bind to $PORT within 60 seconds of launch
2018-06-27T16:53:22.439171+00:00 heroku[web.1]: Stopping process with SIGKILL
2018-06-27T16:53:22.570011+00:00 heroku[web.1]: Process exited with status 137
2018-06-27T16:53:22.707001+00:00 heroku[web.1]: State changed from starting to crashed
2018-06-27T16:53:22.710173+00:00 heroku[web.1]: State changed from crashed to starting

hi @AlexAscherson
Do you know which node version are you on?


Add entry for awesome-zsh-plugins

List of oh-my-zsh compatible plugins for oh-my-zsh, zgen and antigen

Ok, changed case and removed description

Would be cool if you could link back here in your list so users can easily discover more awesome lists ;)

Done.


Implement login/signup page

Wireframe was set up in https://github.com/ubclaunchpad/pinpoint/issues/7

https://www.figma.com/file/CTaCig2GBm6Tn6qvpA5nl32x/Pinpoint?node-id=0%3A1


[DOCS] Extra text

Description
There's a extra "and the" in the documentation layout which should be removed as there are no links after that.
Screenshots

Additional information
No response

Will make a pr regarding this :)

Im trying to make a pr but when i compare the changes it's showing me changes in 4 files(changelog.md,package-lock.json,package.json and the layout one which im actually trying to make a change) the other three are getting changed automatically. What should i do?

Im trying to make a pr but when i compare the changes it's showing me changes in 4 files(changelog.md,package-lock.json,package.json and the layout one which im actually trying to make a change) the other three are getting changed automatically. What should i do?

did you use npm install to install the dependencies? try using npm ci .

Yeah i first used npm install but after watching the video i tried npm ci..still same

Yeah i first used npm install but after watching the video i tried npm ci..still same

https://www.youtube.com/watch?v=jHkIXYVpMTo&t=270s check this part of the video it shows the solution to it

I've fixed and opened a PR for this.🙂

Oh that's great!!
U faced the issue of files getting changed automatically?

No, everything worked fine. Where do you face the issues of files changing automatically?

@rohinish404 This is just a doc change right so I didn't do the npm install.

Oh yeah..that makes sense. Awesome!!🙂👍


[SPARK-13696][WIP] Remove BlockStore class & simplify interfaces of mem. & disk stores

Today, both the MemoryStore and DiskStore implement a common BlockStore API, but I feel that this API is inappropriate because it abstracts away important distinctions between the behavior of these two stores.
For instance, the disk store doesn't have a notion of storing deserialized objects, so it's confusing for it to expose object-based APIs like putIterator() and getValues() instead of only exposing binary APIs and pushing the responsibilities of serialization and deserialization to the client. Similarly, the DiskStore put() methods accepted a StorageLevel parameter even though the disk store can only store blocks in one form.
As part of a larger BlockManager interface cleanup, this patch remove the BlockStore interface and refines the MemoryStore and DiskStore interfaces to reflect more narrow sets of responsibilities for those components. Some of the benefits of this interface cleanup are reflected in simplifications to several unit tests to eliminate now-unnecessary mocking, significant simplification of the BlockManager's getLocal() method, and a narrower API between the MemoryStore and DiskStore.
Next week I'll update this PR description to have a more comprehensive list of improvements. In the meantime, though, the commit messages provide lots of detail into my rationale for the intermediate steps in this refactoring.

Test build #52506 has started for PR 11534 at commit 7d2aba3.

Test build #52506 has finished for PR 11534 at commit 7d2aba3.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/52506/
Test FAILed.

Merged build finished. Test FAILed.

Test build #52521 has started for PR 11534 at commit 18c07e6.

There seems to be a lot of
12:54:15.739 WARN org.apache.spark.storage.BlockManager: Block rdd_38548_0 already exists on this machine; not re-adding it
12:54:15.742 ERROR org.apache.spark.executor.Executor: 1 block locks were not released by TID = 103091:
[rdd_38548_0]

entries in the test log during HiveCompatibilitySuite. I'll try to investigate to see if I can spot what's going on. This isn't leading to test failures but likely indicates a problem somewhere.

Spotted the problem: we need an extra releaseLock() call in getOrElseUpdate's "block already exists" branch; see 9dc510c. I can spin this change off into a smaller patch against master in case we want to clean up the log noise sooner.

Test build #52522 has started for PR 11534 at commit 9dc510c.

Test build #52521 has finished for PR 11534 at commit 18c07e6.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/52521/
Test PASSed.

Merged build finished. Test PASSed.

Test build #52522 has finished for PR 11534 at commit 9dc510c.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/52522/
Test PASSed.

Overall changes look good. Need to take another pass or two to understand this code better.

FYI I rebased this to fix the merge conflicts, so the diff + commit log is now smaller.

Test build #52638 has started for PR 11534 at commit 04f8d15.

Splitting up doPut() into two smaller methods, one concerned with putting bytes and another for putting iterators of objects, would let me simplify its return type and might lead to other simplifications (e.g. by eliminating impossible error-handling cases).  I might try this tomorrow.

Test build #52638 has finished for PR 11534 at commit 04f8d15.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/52638/
Test PASSed.

Test build #52679 has started for PR 11534 at commit 988f003.

Test build #52683 has started for PR 11534 at commit 14857b3.

Test build #52679 has finished for PR 11534 at commit 988f003.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/52679/
Test PASSed.

Test build #52683 has finished for PR 11534 at commit 14857b3.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/52683/
Test FAILed.

Test build #52702 has started for PR 11534 at commit 92c5125.

Test build #52704 has started for PR 11534 at commit 7a08a17.

Test build #52705 has started for PR 11534 at commit a16276e.

I went ahead and split up doPut(), which greatly simplified the return types.

Test build #52707 has started for PR 11534 at commit 66796b5.

Test build #52702 has finished for PR 11534 at commit 92c5125.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/52702/
Test PASSed.

Test build #52705 has finished for PR 11534 at commit a16276e.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/52705/
Test FAILed.

Test build #52704 has finished for PR 11534 at commit 7a08a17.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/52704/
Test PASSed.

Test build #52707 has finished for PR 11534 at commit 66796b5.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/52707/
Test PASSed.

LGTM

Test build #52777 has started for PR 11534 at commit 94d2bd6.

Test build #52787 has started for PR 11534 at commit e3a4c22.

Test build #52791 has started for PR 11534 at commit 0147471.

Test build #52792 has started for PR 11534 at commit 84e4d76.

@JoshRosen This looks great. The only concern I have is the duplicate code in doPutIterator and doPutBytes. In the future if we find a bug in one of them and forget to fix it in the other place things will get really hard to maintain. I do agree on the general idea of separating the two instead of having one giant monolithic doPut method, but I really think we need to fix the duplicate code here and I would prefer to do it in this patch.

Test build #52794 has started for PR 11534 at commit e2ee2e2.

@andrewor14, let me take another shot at reducing that duplication and I'll get back to you.

Test build #52797 has started for PR 11534 at commit 08bc93b.

Test build #52777 has finished for PR 11534 at commit 94d2bd6.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/52777/
Test PASSed.

Test build #52792 has finished for PR 11534 at commit 84e4d76.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/52792/
Test PASSed.

Test build #52794 has finished for PR 11534 at commit e2ee2e2.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/52794/
Test PASSed.

Test build #52791 has finished for PR 11534 at commit 0147471.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/52791/
Test FAILed.

Test build #52797 has finished for PR 11534 at commit 08bc93b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/52797/
Test PASSed.

Merged build finished. Test PASSed.

Test build #52787 has finished for PR 11534 at commit e3a4c22.

This patch fails from timeout after a configured wait of `250m`.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/52787/
Test FAILed.

LGTM, can't wait to merge this!

Test build #52850 has started for PR 11534 at commit 2752655.

Test build #52845 has finished for PR 11534 at commit 2e8b531.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/52845/
Test FAILed.

Merged build finished. Test FAILed.

Test build #52850 has finished for PR 11534 at commit 2752655.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/52850/
Test PASSed.

Merged into master.


ncdu 2.4 segfaults on Darwin

Describe the bug
Exactly what's in the title
Steps To Reproduce
Steps to reproduce the behavior:

Install ncdu while on macOS (the exact method doesn't matter; however, for completeness, I'm using home-manager)
Run ncdu
See segmentation fault

Expected behavior
That there is no segmentation fault
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.
Notify maintainers
@pSub @rodrgz
Metadata
 - system: `"aarch64-darwin"`
 - host os: `Darwin 20.4.0, macOS 11.3.1`
 - multi-user?: `yes`
 - sandbox: `no`
 - version: `nix-env (Nix) 2.18.1`
 - nixpkgs: `/Users/system/.nix-defexpr/channels/nixpkgs`

Add a :+1: reaction to issues you find important.

What's your usage like? Full drive and running for a long time? Specific files? I have it installed on darwin and dont get a segfault when scanning my home folder.

No, any invocation makes it fail. There's nothing particularly unique about mys setup (in fact, outside of Nix itself, it's a pretty standard install). On Darwin, is ncdu compiled on the user's machine, or is it downloaded from a mirror?

I will note that I've been using unstable.ncdu --- switching to pkgs.ncdu fails to build due to:
Running phase: unpackPhase
unpacking source archive /nix/store/311mpzwmfd5h3n44bk0g758fzpw3swpz-ncdu-2.4.tar.gz
source root is ncdu-2.4
setting SOURCE_DATE_EPOCH to timestamp<PHONE_NUMBER> of file ncdu-2.4/src/main.zig
Running phase: patchPhase
Running phase: updateAutotoolsGnuConfigScriptsPhase
Running phase: configurePhase
no configure script, doing nothing
Running phase: buildPhase
zig build flags: -Dcpu=baseline --release=safe -Dpie=true
/nix/store/s6smzmbvzv7ra9s2y5d1jj7ip924gala-zig-hook/nix-support/setup-hook: line 10: 84690 Abort trap: 6           zig build "${flagsArray[@]}"
error: builder for '/nix/store/9sx9j1laccpiagqi3bn0fvynkak9rs4l-ncdu-2.4.drv' failed with exit code 134;
       last 10 log lines:
       > unpacking source archive /nix/store/311mpzwmfd5h3n44bk0g758fzpw3swpz-ncdu-2.4.tar.gz
       > source root is ncdu-2.4
       > setting SOURCE_DATE_EPOCH to timestamp<PHONE_NUMBER> of file ncdu-2.4/src/main.zig
       > Running phase: patchPhase
       > Running phase: updateAutotoolsGnuConfigScriptsPhase
       > Running phase: configurePhase
       > no configure script, doing nothing
       > Running phase: buildPhase
       > zig build flags: -Dcpu=baseline --release=safe -Dpie=true
       > /nix/store/s6smzmbvzv7ra9s2y5d1jj7ip924gala-zig-hook/nix-support/setup-hook: line 10: 84690 Abort trap: 6           zig build "${flagsArray[@]}"
       For full logs, run 'nix log /nix/store/9sx9j1laccpiagqi3bn0fvynkak9rs4l-ncdu-2.4.drv'.
error: 1 dependencies of derivation '/nix/store/5xd7gfg4005848zdrzam4qrnac303xcl-home-manager-applications.drv' failed to build
error: 1 dependencies of derivation '/nix/store/vfwkldb4gccjjkv9pa9fchvxg1vy2fgr-home-manager-fonts.drv' failed to build
error: 1 dependencies of derivation '/nix/store/vil7rsq0afhlygkhw2zdcy17a0173an8-home-manager-path.drv' failed to build
error: 1 dependencies of derivation '/nix/store/1d3mghz99ckr8fdn1bk6v3dfy0rp4zs5-home-manager-generation.drv' failed to build


New package: cuStateVec v1.0.0

Registering package: cuStateVec
Repository: https://github.com/JuliaGPU/CUDA.jl
Created by: @maleadt
Version: v1.0.0
Commit: a70c83e2cbe978873a7aa74f2493838b509aa42c
Reviewed by: @maleadt
Reference: https://github.com/JuliaGPU/CUDA.jl/commit/a70c83e2cbe978873a7aa74f2493838b509aa42c#commitcomment-99047845
Description: CUDA programming in Julia.

Following NVIDIA's naming scheme.


Newbie question about step 7

Hello! Sorry for having an amateur question but I am a total newbie with coding and linux but since I play on console I really want to make this work but I keep encountering hiccups.
-I have  followed the steps from 1-6 so far and everything seems to be going smoothly but I encountered an issue with step 7 which leads to my confusion:

If I am understanding this correctly, I need to drag and drop ffxiv.exe or ffxiv_dx11.exe into the vm. My confusion is the next part, download run HFS. Initially I did this inside the linux os vm but even with Wine installed I can’t open and run HFS which leads me to assume that I should download and run it on the host os? would really help me if I can receive help and advice on this. I use a macbook to do this though and my linux os is Fedora so I don’t know if it has anything to do with it. I want to know if HFS needs to be installed and run on linux vm? and if so why does it not want to open even with wine installed.

If you're using Linux already, then you don't have to use HFS; it's purely for the purpose of transferring ffxiv exe from Windows PC to a linux environment. This step really is about copying the executable file into the directory.

You can also use SCP to copy file between macOS and Linux
scp SOURCE DESTINATION
scp "/path/to/your/exe/on/mac/ffxiv_dx11.exe" root@VM_IP:/path/you/want/to/keep/file/
Replace root if you use other username.

Hello! I was happy that I managed to make some progress but I encountered an issue that I didn’t see in the other posts. I tried to curl but it came out with Segmentation Fault (Core Dumped).

Can you show the output of following command?
python --version

Of course!

Python version does not seems to be a problem. However, I'm not a Fedora expert, but from quick research on Segmentation fault (core dumped) error. It looks like some python modules is not working correctly. You may want to completely uninstall python and install it again. But as mentioned, I'm no Fedora expert, I don't know how to do that or if it will solve your problem.
Or you may try create a Debian/Ubuntu VM for XivMitmLatencyMitigator instead.

Hello! Yes! I tried to run it on both ubuntu and debian and both came out with similar error but instead of Segmentation Fault its Illegal Instruction. I’m beginning to wonder if it has something to do with apple silicon since it seems there’s compatibility issues with it.

That's definitely the source of problem! You need x64 VM to run the script. The ARM VM for Apple Silicon will not work.

Hello! Thank for your advice! I took in what you said and tried something out: Instead of virtualization I tried to instead do emulation via UTM vm for mac. I managed to download and run ubuntu x64 even though its slow the important thing was I could run the terminal. Here’s the result:

It didn’t reply with an error so I hope I’m on the correct path. I didn’t test it out on ff yet cause I’m still unsubbed.


Update provisioning-mode.md

Adding additional information that it can also be triggered manually.  Provided the 'timestamp' registry key.
Summarize the change in the pull request title
Describe your change, specifically why you think it's needed.
Fixes #Issue_Number (if necessary)

@gwblok : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off
Once merged, this should be live with the next daily publishing process. Right now that should be tomorrow (Tuesday, 20 August) around 11:00 Pacific time. No further action needed from you.

@ktoliver : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@ktoliver : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Add src and more files to npmignore

Hi, I'm new to this lib community, and I just wanted to suggest adding more files to npmignore.
I don't know if it was intentional because I don't actively follow the development of this project, but I noticed that there were some files that I don't think are necessary in npm, such as:

src
.huskyrc
CONTRIBUTING.md
.lintstagedrc

Mainly src increases the size of the library.
If it was intentional, you can resolve this issue, thanks.

this project is no longer maintained.
I talked to the main contributor, he told me that he will archive this repo eventually.


Problem with installation on Ubuntu 18.04  - No such file or directory  #include "laszip_api.h"

Hello guys, I am using Ubuntu 18.04 and I have the problem with installation. I followed the instruction which @spatialhast posted here: https://github.com/potree/PotreeConverter/issues/180
I successfully installed LAStools, but I got stuck at the Portree. :/ When I run the command
sudo make && sudo make install

I get the output:
Scanning dependencies of target PotreeConverter
 [  8%] Building CXX object
PotreeConverter/CMakeFiles/PotreeConverter.dir/src/BINPointReader.cpp.o
[ 16%] Building CXX object PotreeConverter/CMakeFiles/PotreeConverter.dir/src/GridCell.cpp.o
[ 25%] Building CXX object
 PotreeConverter/CMakeFiles/PotreeConverter.dir/src/LASPointReader.cpp.o

  /home/user/LAStools/LASzip/build/PotreeConverter/PotreeConverter/src/LASPointReader.cpp:8:10:
    fatal error: laszip_api.h: No such file or directory
     #include "laszip_api.h"
         ^~~~~~~~~~~~~~
     compilation terminated.
    PotreeConverter/CMakeFiles/PotreeConverter.dir/build.make:110: recipe for target
    'PotreeConverter/CMakeFiles/PotreeConverter.dir/src/LASPointReader.cpp.o' failed
    make[2]: *** [PotreeConverter/CMakeFiles/PotreeConverter.dir/src/LASPointReader.cpp.o] Error 1
    CMakeFiles/Makefile2:85: recipe for target 'PotreeConverter/CMakeFiles/PotreeConverter.dir/all' failed
    make[1]: *** [PotreeConverter/CMakeFiles/PotreeConverter.dir/all] Error 2
    Makefile:129: recipe for target 'all' failed
    make: *** [all] Error 2

But I have that file in LAStools/LASzip/dll
I tried to manually copy it in /LAStools/LASzip/build/PotreeConverter/build but without success.

The solution to my problem was, believe or not, just to run this command separately:
sudo make && sudo make install

So, I first run make, and then make install.
Or maybe restart was the solution (But I am using Ubuntu, I don't know..). Because I tried to install again the day after and my computer was switched off in meantime.
Anyway, these two things are only things that I changed from yesterday.

You have to run cmake with these flags: cmake -DCMAKE_BUILD_TYPE=Release -DLASZIP_INCLUDE_DIRS=/your_path/to/LAStools/LASzip/dll -DLASZIP_LIBRARY=/your_path/to/LAStools/LASzip/build/src/liblaszip.so ..

When I run make command after running this command, I got an error.
sudo cmake -DCMAKE_BUILD_TYPE=Release -DLASZIP_INCLUDE_DIRS=~/var/www/html/lastools/master/LASzip/dll -DLASZIP_LIBRARY=~/var/www/html/lastools/master/LASzip/build/src/liblaszip.so ..
So I removed ~ in the path.
sudo cmake -DCMAKE_BUILD_TYPE=Release -DLASZIP_INCLUDE_DIRS=/var/www/html/lastools/master/LASzip/dll -DLASZIP_LIBRARY=/var/www/html/lastools/master/LASzip/build/src/liblaszip.so ..
It worked. 🔥

Hello, I have the following error when executing the make on potreeconverter build:
sudo make
[  8%] Building CXX object PotreeConverter/CMakeFiles/PotreeConverter.dir/src/BINPointReader.cpp.o
In file included from /home/ubuntu/Desktop/workspaces/PotreeConverter/master/PotreeConverter/include/BINPointReader.hpp:11,
from /home/ubuntu/Desktop/workspaces/PotreeConverter/master/PotreeConverter/src/BINPointReader.cpp:8:
/home/ubuntu/Desktop/workspaces/PotreeConverter/master/PotreeConverter/include/PointReader.h:11:21: error: ‘filesystem’ is not a namespace-name
11 | namespace fs = std::filesystem;
|                     ^~~~~~~~~~
In file included from /home/ubuntu/Desktop/workspaces/PotreeConverter/master/PotreeConverter/src/BINPointReader.cpp:9:
/home/ubuntu/Desktop/workspaces/PotreeConverter/master/PotreeConverter/include/stuff.h:38:21: error: ‘filesystem’ is not a namespace-name
38 | namespace fs = std::filesystem;
|                     ^~~~~~~~~~
/home/ubuntu/Desktop/workspaces/PotreeConverter/master/PotreeConverter/include/stuff.h:96:15: error: ‘fs’ has not been declared
96 |  bool copyDir(fs::path source, fs::path destination);
|               ^~
/home/ubuntu/Desktop/workspaces/PotreeConverter/master/PotreeConverter/include/stuff.h:96:32: error: ‘fs’ has not been declared
96 |  bool copyDir(fs::path source, fs::path destination);
|                                ^~
/home/ubuntu/Desktop/workspaces/PotreeConverter/master/PotreeConverter/include/stuff.h:96:52: error: expression list treated as compound expression in initializer [-fpermissive]
96 |  bool copyDir(fs::path source, fs::path destination);
|                                                    ^
/home/ubuntu/Desktop/workspaces/PotreeConverter/master/PotreeConverter/src/BINPointReader.cpp:11:21: error: ‘filesystem’ is not a namespace-name
11 | namespace fs = std::filesystem;
|                     ^~~~~~~~~~
/home/ubuntu/Desktop/workspaces/PotreeConverter/master/PotreeConverter/src/BINPointReader.cpp: In constructor ‘Potree::BINPointReader::BINPointReader(std::string, Potree::AABB, double, Potree::PointAttributes)’:
/home/ubuntu/Desktop/workspaces/PotreeConverter/master/PotreeConverter/src/BINPointReader.cpp:27:5: error: ‘fs’ has not been declared
27 |  if(fs::is_directory(path)){
|     ^~
/home/ubuntu/Desktop/workspaces/PotreeConverter/master/PotreeConverter/src/BINPointReader.cpp:30:7: error: ‘fs’ has not been declared
30 |   for(fs::directory_iterator it(path); it != fs::directory_iterator(); it++){
|       ^~
/home/ubuntu/Desktop/workspaces/PotreeConverter/master/PotreeConverter/src/BINPointReader.cpp:30:40: error: ‘it’ was not declared in this scope; did you mean ‘int’?
30 |   for(fs::directory_iterator it(path); it != fs::directory_iterator(); it++){
|                                        ^~
|                                        int
/home/ubuntu/Desktop/workspaces/PotreeConverter/master/PotreeConverter/src/BINPointReader.cpp:30:46: error: ‘fs’ has not been declared
30 |   for(fs::directory_iterator it(path); it != fs::directory_iterator(); it++){
|                                              ^~
/home/ubuntu/Desktop/workspaces/PotreeConverter/master/PotreeConverter/src/BINPointReader.cpp:31:4: error: ‘fs’ has not been declared
31 |    fs::path filepath = it->path();
|    ^~
/home/ubuntu/Desktop/workspaces/PotreeConverter/master/PotreeConverter/src/BINPointReader.cpp:32:7: error: ‘fs’ has not been declared
32 |    if(fs::is_regular_file(filepath)){
|       ^~
/home/ubuntu/Desktop/workspaces/PotreeConverter/master/PotreeConverter/src/BINPointReader.cpp:32:27: error: ‘filepath’ was not declared in this scope
32 |    if(fs::is_regular_file(filepath)){
|                           ^~~~~~~~
/home/ubuntu/Desktop/workspaces/PotreeConverter/master/PotreeConverter/src/BINPointReader.cpp: In member function ‘virtual bool Potree::BINPointReader::readNextPoint()’:
/home/ubuntu/Desktop/workspaces/PotreeConverter/master/PotreeConverter/src/BINPointReader.cpp:182:5: error: ‘memcpy’ was not declared in this scope
182 |     memcpy(target.data(), (buffer + offset), attribute.byteSize);
|     ^~~~~~
/home/ubuntu/Desktop/workspaces/PotreeConverter/master/PotreeConverter/src/BINPointReader.cpp:10:1: note: ‘memcpy’ is defined in header ‘’; did you forget to ‘#include ’?
9 | #include "stuff.h"
+++ |+#include
10 |
make[2]: *** [PotreeConverter/CMakeFiles/PotreeConverter.dir/build.make:63: PotreeConverter/CMakeFiles/PotreeConverter.dir/src/BINPointReader.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:91: PotreeConverter/CMakeFiles/PotreeConverter.dir/all] Error 2
make: *** [Makefile:130: all] Error 2
any hint of what could it be? regards

@erickucl
I solved in ubuntu 19.10 the issue about  namespace fs = std::filesystem;
in all files where is used replacing following code
#include <filesystem>

namespace fs = std::filesystem;

with this
//#include <filesystem>
#include <experimental/filesystem>

//namespace fs = std::filesystem;
namespace fs = std::experimental::filesystem;

and issue about  memcpy definition adding follow declaration at top of PotreeConverter/src/BINPointReader.cpp
#include <cstring>

@il-Brando Can you specify the files? I can't really find the file, especially BINPointReader.cpp since that's the one breaking for me.


[Feature Idea] Drag in folder -> all files from folder and subfolders are added to the list

An awesome upgrade (imho of course) would be to be able to drag in a folder from the Windows Explorer, and it then automatically searches the folder and all subfolders (and their subfolders etc.) for files and just add them to the list. I solved this by searching for . in the explorer which works of course but I thought maybe you like the idea! Thanks in any case!

Hi! I really like the idea and I'm already working on it. It will be available in the next update.

New version released with the requested feature.


Python 3 assumes source code is encoded with UTF-8

But PTVS saves with OS's codepage encoding by default. Furthermore, I cannot find any resort to change the default behavior in VS. I don't want to change OS's codepage.
I think the default behavior should save with UTF-8 when the environment is Python 3.

Are you using PTVS 2.2.2 (from about a month ago)? We had a bug around this in an earlier version that was causing issues here.
Also note that Visual Studio will always save a file with the same encoding as it was loaded with, so if there's something in the file indicating the encoding to use, it may be the issue. You can change the encoding through File, Advanced Save Options.


totalSupply on NFTDrop returns 0

I am using the useNFTDrop("0xbBf8320D0C65C063a47A9b21605Aa30ed2722b1F") hook and everything including claim, estimator, totalClaimedSupply(), totalUnclaimedSupply() seem to work just fine except for totalSupply() which always returns 0 but should return 10000. I am using<EMAIL_ADDRESS>Is this a known issue or do I need to do something else to make totalSupply() return the correct value?

hi @NoodleOfDeath - for NFTDrop (and NFTCollection), totalSupply() is the amount of NFTs that are actually minted by an end user and currently in circulation.
So for the case of NFTDrop, NFTs are not "minted by an end user" until they're claimed using claim() - That's why we added totalClaimedSupply() and totalUnclaimedSupply() for NFTDrop to give a clear distinction.
Let me know if that makes sense.

Ahh yes that makes more sense. I ended up using totalClaimedSupply + totalUnclaimedSupply to get my total collection size. I might suggest that totalSupply be renamed more precisely like totalCirculationSupply?

hey @NoodleOfDeath, yup that all makes sense.
We're thinking about renaming totalSupply() to something like totalCirculatingSupply() (name still pending) to make it clearer what it actually does.
For Edition totalSupply works differently yet again (and we should clarify this as well in the docs, thanks for pointing it out):

edition.totalSupply(tokenId) gives you the amount of that given tokenId that exist
edition.getTotalCount() gives you the size of the edition (aka how many token types exist within the edition)