WEB API Controller method return value causes net::ERR_INCOMPLETE_CHUNKED_ENCODING

Describe the bug
When we moved to .NET Core 3 controllers stopped working properly. When method from controller returns data (e.g string) of size >= 4099 it causes net::ERR_INCOMPLETE_CHUNKED_ENCODING in chrome.
Tried on preview 3 and preview 4, on .NET Core 2.2 everything was good.
No issues when method returns data <=4098.
To Reproduce
Method of controller causing this behavior:
[HttpGet("TestControllerResponse")]
public IActionResult TestControllerResponse()
{
     string result = "";
     var i = 0;
     //var size = 4098;    // 4098 -> OK
     var size = 4099;    // 4099 -> net::ERR_INCOMPLETE_CHUNKED_ENCODING
     while (++i <= size)
     {
          result = $"{result}+";
     }
     return Ok(result);
}

Expected behavior
As in previous versions, this should be OK, not causing net::ERR_INCOMPLETE_CHUNKED_ENCODING.
Details from uncaught exceptions:

fail: Microsoft.AspNetCore.Server.Kestrel[13]
Connection id "0HLLHQ2L5SQMD", Request id "0HLLHQ2L5SQMD:0000000E": An unhandled exception was thrown by the application.
System.ArgumentOutOfRangeException: Specified argument was out of the range of valid values.
at System.Memory1.Slice(Int32 start, Int32 length)    at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http.Http1OutputProducer.GetChunkedMemory(Int32 sizeHint)    at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http.Http1OutputProducer.GetSpan(Int32 sizeHint)    at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http.HttpProtocol.GetSpan(Int32 sizeHint)    at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http.HttpResponsePipeWriter.GetSpan(Int32 sizeHint)    at Microsoft.AspNetCore.Http.HttpResponseWritingExtensions.WriteMultiSegmentEncoded(PipeWriter writer, String text, Encoding encoding, Span1 destination, Int32 encodedLength)
at Microsoft.AspNetCore.Http.HttpResponseWritingExtensions.Write(HttpResponseresponse, String text, Encoding encoding)
at Microsoft.AspNetCore.Http.HttpResponseWritingExtensions.WriteAsync(HttpResponse response, String text, Encoding encoding, CancellationToken cancellationToken)
at Microsoft.AspNetCore.Mvc.Formatters.StringOutputFormatter.WriteResponseBodyAsync(OutputFormatterWriteContext context, Encoding encoding)
at Microsoft.AspNetCore.Mvc.Formatters.TextOutputFormatter.WriteAsync(OutputFormatterWriteContext context)
at Microsoft.AspNetCore.Mvc.Infrastructure.ObjectResultExecutor.ExecuteAsync(ActionContext context, ObjectResult result)
at Microsoft.AspNetCore.Mvc.ObjectResult.ExecuteResultAsync(ActionContext context)
at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.InvokeResultAsync(IActionResult result)
at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.InvokeNextResultFilterAsyncTFilter,TFilterAsync
at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.Rethrow(ResultExecutedContext context)
at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.ResultNext[TFilter,TFilterAsync](State& next, Scope& scope, Object& state, Boolean& isCompleted)
at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.InvokeResultFilters()
at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.InvokeNextResourceFilter()
at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.Rethrow(ResourceExecutedContext context)
at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.Next(State& next,Scope& scope, Object& state, Boolean& isCompleted)
at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.InvokeFilterPipelineAsync()
at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.InvokeAsync()
at Microsoft.AspNetCore.Routing.EndpointMiddleware.Invoke(HttpContext httpContext)
at Microsoft.AspNetCore.Routing.EndpointRoutingMiddleware.Invoke(HttpContexthttpContext)
at Microsoft.AspNetCore.Builder.Extensions.MapMiddleware.Invoke(HttpContext context)
at Microsoft.AspNetCore.StaticFiles.StaticFileMiddleware.Invoke(HttpContext context)
at Microsoft.AspNetCore.Authentication.AuthenticationMiddleware.Invoke(HttpContext context)
at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http.HttpProtocol.ProcessRequests[TContext](IHttpApplication`1 application)

This is also being reported over here: https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/1082
@jkotalik

@anurse bringing into preview4 and assigning to @jkotalik as a critical bug. We can load balance in triage.

Let's just say @Tratcher and I are shocked that this wasn't caught by a test beforehand...


⚠ Bofrost.de has degraded performance

In 8f2d1e3, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 973 ms

Resolved: Bofrost.de performance has improved in 737b9d6 after 8 minutes.


Too many open files error from Helidon/Netty NIOServerSocket Channel

Environment Details

Helidon Version: 1.4.4
Helidon SE or Helidon MP: Helidon MP
JDK version: 11.0.7
OS**: Oracle Linux - 4.14.35-1902.301.1.el7uek.x86_64**
Docker version (if applicable): NA

Problem Description
This is a Helidon MP based REST application which serves API requests. It starts up successfully and after a few days, the server was not responding and while checking the log files, found this error for each unserviced request:
2021-01-14 14:51:35.093+0000 | ioEventLoopGroup-2-1 |  WARN | .c.DefaultChannelPipeline |  | An exceptionCaught() event was fired, and it reached at the tail of the pipeline. It usually means the last handler in the pipeline did not handle the exception.
java.io.IOException: Too many open files
at java.base/sun.nio.ch.ServerSocketChannelImpl.accept0(Native Method)
at java.base/sun.nio.ch.ServerSocketChannelImpl.accept(ServerSocketChannelImpl.java:533)
at java.base/sun.nio.ch.ServerSocketChannelImpl.accept(ServerSocketChannelImpl.java:285)
at io.netty.util.internal.SocketUtils$5.run(SocketUtils.java:111)
at io.netty.util.internal.SocketUtils$5.run(SocketUtils.java:108)
at java.base/java.security.AccessController.doPrivileged(Native Method)
at io.netty.util.internal.SocketUtils.accept(SocketUtils.java:108)
at io.netty.channel.socket.nio.NioServerSocketChannel.doReadMessages(NioServerSocketChannel.java:147)
at io.netty.channel.nio.AbstractNioMessageChannel$NioMessageUnsafe.read(AbstractNioMessageChannel.java:75)
at io.netty.channel.nio.NioEventLoop.processSelectedKey(NioEventLoop.java:714)
at io.netty.channel.nio.NioEventLoop.processSelectedKeysOptimized(NioEventLoop.java:650)
at io.netty.channel.nio.NioEventLoop.processSelectedKeys(NioEventLoop.java:576)
at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:493)
at io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:989)
at io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74)
at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
at java.base/java.lang.Thread.run(Thread.java:834)
At first, I increased the ulimit to 4096 and after restart the problem went away but again resurfaced after a few days. It looks like the NIO Socket Channel is not releasing the socket connection at linux level and it fills up the limit of linux open files.
I have not written any directly using the NIO Socket Channel but rely on Helidon/Netty to open Socket Channel for every server request.
Any pointers would be appreciated.
Thanks.

@mchakrav Could you provide more information about the business logic in your application? Are you using Helidon's static content support? Have you tried running lsof on your Linux system to get more info?

@mchakrav Could you provide more information about the business logic in your application? Are you using Helidon's static content support? Have you tried running lsof on your Linux system to get more info?

The Java (Helidon) Application does not have this problem when the request
is routed correctly to the service controller so that business logic
gets applied correctly either with OK response or any other error response.
There is no issue with that flow at all.
2021-01-26 08:29:55.313+0000 | oEventLoopGroup-3-15 | ERROR |
i.h.w.RequestRouting      |  | Unexpected error occurred during routing!
java.lang.IllegalArgumentException: Could not parse ****** (masked)
When helidon is unable to parse the header information and after the above
error the nio socket channel is not released and linux level socket files
does not get released. Here is the list:
(removed the user and group from the ls)
/proc/702/fd
lrwx------. 1  64 Jan 21 08:59 990 -> socket:[27589049]
lrwx------. 1 64 Jan 21 08:59 991 -> socket:[27589072]
lrwx------. 1  64 Jan 21 08:59 992 -> socket:[27598186]
lrwx------. 1  64 Jan 21 08:59 993 -> socket:[27589097]
lrwx------. 1  64 Jan 21 08:59 994 -> socket:[27589118]
lrwx------. 1 64 Jan 21 08:59 995 -> socket:[27598148]
lrwx------. 1  64 Jan 21 08:59 996 -> socket:[27598218]
lrwx------. 1  64 Jan 21 08:59 997 -> socket:[27598019]
lrwx------. 1  64 Jan 21 08:59 998 -> socket:[27598257]
lrwx------. 1 64 Jan 21 08:59 999 -> socket:[27598288]
Eventually runs out of max open files limit at the linux level.
On Thu, Jan 21, 2021 at 12:32 PM Santiago Pericasgeertsen <
<EMAIL_ADDRESS>wrote:

@mchakrav https://github.com/mchakrav Could you provide more
information about the business logic in your application? Are you using
Helidon's static content support? Have you tried running lsof on your
Linux system to get more info?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/oracle/helidon/issues/2663#issuecomment-764850691,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADXUZTK7ORWYOQIDAEHJCXDS3BXKNANCNFSM4WCTCFMA
.

The Java (Helidon) Application does not have this problem when the request
is routed correctly to the service controller so that business logic
gets applied correctly either with OK response or any other error response.
There is no issue with that flow at all.
2021-01-26 08:29:55.313+0000 | oEventLoopGroup-3-15 | ERROR |
i.h.w.RequestRouting      |  | Unexpected error occurred during routing!
java.lang.IllegalArgumentException: Could not parse ****** (masked)
When helidon is unable to parse the header information and after the above
error the nio socket channel is not released and linux level socket files
does not get released. Here is the list:
(removed the user and group from the ls)
/proc/702/fd
lrwx------. 1  64 Jan 21 08:59 990 -> socket:[27589049]
lrwx------. 1 64 Jan 21 08:59 991 -> socket:[27589072]
lrwx------. 1  64 Jan 21 08:59 992 -> socket:[27598186]
lrwx------. 1  64 Jan 21 08:59 993 -> socket:[27589097]
lrwx------. 1  64 Jan 21 08:59 994 -> socket:[27589118]
lrwx------. 1 64 Jan 21 08:59 995 -> socket:[27598148]
lrwx------. 1  64 Jan 21 08:59 996 -> socket:[27598218]
lrwx------. 1  64 Jan 21 08:59 997 -> socket:[27598019]
lrwx------. 1  64 Jan 21 08:59 998 -> socket:[27598257]
lrwx------. 1 64 Jan 21 08:59 999 -> socket:[27598288]
Eventually runs out of max open files limit at the linux level.
On Thu, Jan 21, 2021 at 12:32 PM Santiago Pericasgeertsen <
<EMAIL_ADDRESS>wrote:

@mchakrav https://github.com/mchakrav Could you provide more
information about the business logic in your application? Are you using
Helidon's static content support? Have you tried running lsof on your
Linux system to get more info?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/oracle/helidon/issues/2663#issuecomment-764850691,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADXUZTK7ORWYOQIDAEHJCXDS3BXKNANCNFSM4WCTCFMA
.

@mchakrav Thanks for the additional information. Is it at all possible for you to upgrade to a more recent version than 1.4.4? This issue should be fixed in the 2.X codebase.

@mchakrav Thanks for the additional information. Is it at all possible for you to upgrade to a more recent version than 1.4.4? This issue should be fixed in the 2.X codebase.

Inactive for about a month. Please re-open if necessary.


Fixed multi-part requests on ThingClient

There were a couple problems: First there was a bug on ThingDeserializer where the connection passed in wasn't getting saved. Second, there were a couple of missing .ConfigureAwait(false) statements, meaning that the synchronous access in ThingCollection was causing a deadlock.
Also added a unit test to validate this scenario.

@RandomEngy,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

:shipit:


update

Signed-off-by: qwettttttt<EMAIL_ADDRESS>

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


DockerFile: Add dep packages to pass build

I added a couple packages in DockerFile in order to successfully build the repo.

travis_time:start:05003021`
$ python3 ./testSuite/scripts/run.py
Smoke tests starting...
Traceback (most recent call last):
  File "./testSuite/scripts/run.py", line 239, in <module>
    main()
  File "./testSuite/scripts/run.py", line 176, in main
    init()
  File "./testSuite/scripts/run.py", line 114, in init
    parse_config_file_set_env()
  File "./testSuite/scripts/run.py", line 25, in parse_config_file_set_env
    raise Exception("Failed to find/open test_suite_config.ini file")
Exception: Failed to find/open test_suite_config.ini file
travis_time:end:05003021:start=1560655156066807087,finish=1560655156243170217,duration=176363130
The command "python3 ./testSuite/scripts/run.py" exited with 1.

Travis seems to fail because I did not provide my own test_suite_config.ini file.

Hi, panfeng0007
Thanks a ton for the contribution. Currently, we lock CI to members of the project (hence why your tests are failing). I would recommend against supplying your own test config, as it contains secrets.
Atop this, were working on moving away from Travis CI.
In the future, our builds will go through Azure DevOps and our testing suite will be written in Go instead.
We're already producing OSX builds via Azure DevOps, so no worries on this.

Hi @adreed-msft,
Thanks for letting me know! I will close this PR now.


How to set height and width of the dialog ?

When i open the dialog it showing me full screen... It does not look good in my case... Is there any way to set height and width ?

you can use .SetContentWidth and .SetContentHeight method
also if u want use expanded feature. use setExpanded(true,desireHeight)

Above answer should be good 👍 Closing this issue.


Dynamic blackbox module

This PR adds a blackbox exporter module that handles external target lists as mentioned in https://github.com/grafana/agent/issues/4526

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@erikbaranowski Is it enough that the info sits in the README.md? or should we pull it into the main Agent (reference?) docs?


What about emoji bage?

Let's find out.

Here is your emoji :blue_heart:

:blue_heart:

That didn't work.


Update LD_LIBRARY_PATH in R2022b Dockerfile

From Matlab Runtime version R2022b the runtime is no more installed in a folder identified by the version number (i.e. v913) but by the name of the Matlab release name (i.e. R2022b).
See Release notes here  in the R2022b section under "MATLAB Runtime: Installation path updated to use MATLAB release name"

thanks @Eschivo , I'll have a look at that and get all the Dockerfiles in line

issue fixed in new v1.2


Skill - Multiscale

Halves damage taken if the skill holder is at full HP.

This hack is not quite in safety. I prefer not to merge it


YARN-6766 added HelperMethod for AppsBlock Class

YARN-6766
Description of PR
The various *AppsBlock classes are riddled with statements like:
.append(appInfo.getReservedVCores() == -1 ? "N/A" : String.valueOf(appInfo.getReservedVCores()))
The code would be much cleaner if there were a utility method for that operation, e.g.:
.append(printData(appInfo.getReservedCores()))

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m 20s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

-1 :x:
mvninstall
31m 20s
/branch-mvninstall-root.txt
root in trunk failed.

-1 :x:
compile
0m 38s
/branch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdkUbuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04.txt
hadoop-yarn-server-resourcemanager in trunk failed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04.

-1 :x:
compile
0m 38s
/branch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdkPrivateBuild-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07.txt
hadoop-yarn-server-resourcemanager in trunk failed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07.

-0 :warning:
checkstyle
0m 36s
/buildtool-branch-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
The patch fails to run checkstyle in hadoop-yarn-server-resourcemanager

-1 :x:
mvnsite
0m 40s
/branch-mvnsite-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
hadoop-yarn-server-resourcemanager in trunk failed.

-1 :x:
javadoc
0m 42s
/branch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdkUbuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04.txt
hadoop-yarn-server-resourcemanager in trunk failed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04.

-1 :x:
javadoc
0m 43s
/branch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdkPrivateBuild-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07.txt
hadoop-yarn-server-resourcemanager in trunk failed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07.

-1 :x:
spotbugs
0m 40s
/branch-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
hadoop-yarn-server-resourcemanager in trunk failed.

+1 :green_heart:
shadedclient
5m  1s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

-1 :x:
mvninstall
0m 31s
/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
hadoop-yarn-server-resourcemanager in the patch failed.

-1 :x:
compile
0m 31s
/patch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdkUbuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04.txt
hadoop-yarn-server-resourcemanager in the patch failed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04.

-1 :x:
javac
0m 31s
/patch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdkUbuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04.txt
hadoop-yarn-server-resourcemanager in the patch failed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04.

-1 :x:
compile
0m 30s
/patch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdkPrivateBuild-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07.txt
hadoop-yarn-server-resourcemanager in the patch failed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07.

-1 :x:
javac
0m 30s
/patch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdkPrivateBuild-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07.txt
hadoop-yarn-server-resourcemanager in the patch failed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07.

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 28s
/buildtool-patch-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
The patch fails to run checkstyle in hadoop-yarn-server-resourcemanager

+1 :green_heart:
mvnsite
1m 24s

the patch passed

-1 :x:
javadoc
0m 44s
/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdkUbuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04.txt
hadoop-yarn-server-resourcemanager in the patch failed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04.

-1 :x:
javadoc
1m  2s
/results-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdkPrivateBuild-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07.txt
hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdkPrivateBuild-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07 with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07 generated 343 new + 0 unchanged - 0 fixed = 343 total (was 0)

-1 :x:
spotbugs
0m 32s
/patch-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
hadoop-yarn-server-resourcemanager in the patch failed.

+1 :green_heart:
shadedclient
34m 27s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
102m 23s

hadoop-yarn-server-resourcemanager in the patch passed.

+1 :green_heart:
asflicense
0m 45s

The patch does not generate ASF License warnings.

180m 19s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4959/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4959

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 80de180b4813 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / ffc07ef2d2941be6a09fc75b3057eb03b50baf90

Default Java
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4959/1/testReport/

Max. process+thread count
939 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4959/1/console

versions
git=2.25.1 maven=3.6.3

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.


Closed problem

I am compile and using c#.
after close connectin get error memory problem.
I have problem call destroySnowball many thread.
http://system.data.sqlite.org/index.html/info/b4ef73b33a7ce8d9

Closed as duplicate of #3


use call to insure all arguments are passed

Not sure how this could work as is...  The callback on line 81 wants a single argument... and then it again tries to apply it... I could only get this to work if I changed this to a call (as I have done in this PR) or if I changed line 81 to use the new ...args syntax so that it accepted the FULL list of arguments trying to be passed here and then turned around and passed them on.
Without any changes only the first argument makes it to line 81 and then line 82 can't possibly work properly with the apply since you only have one argument.
Am I missing something?

If interested, here is the last bit of code I had in the parent project before it was deleted:
/*
Copyright (c) 2015 Sereth Infrastructure Systems

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
in the Software without restriction, including without limitation the rights
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
copies of the Software, and to permit persons to whom the Software is
furnished to do so, subject to the following conditions:

The above copyright notice and this permission notice shall be included in
all copies or substantial portions of the Software.

 IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
THE SOFTWARE.

*/
// Simple promised-based AMD solution
// WARNING: No deadlock detection.
(function (root) {
  // "use strict" implied, but not used because I like smaller files

  // Do nothing if already defined
  if(root.ul_amd) return;
  root.ul_amd = 1;

  // Minimizer hinting
  var Promise = root.Promise;
  var function_type = "function"

  // Can not work without Promise support
  if (!Promise) {throw "Promise required";}

  var callback_error = 'Missing callback';
  var exists_error = 'Module exists';
  /**
   * Define a module within the Sereth AMD environment
   *
   * @param {Object} key
   *     The identifier for this module. This will be used to specify dependencies.
   * @param {Object|Object[]} [dependencies]
   *     The key, or array of keys of modules required for the definition of this module
   * @param {function} callback
   *     A callback that returns the value of the module to be stored. Parameters will be the requested dependency modules
   */
  root['use_module'] = function (dependencies, callback) {
    if (typeof callback != function_type) throw callback_error;
    satisfy_dependencies(dependencies).then(function (dependencies_actual) {
      callback.apply(root, dependencies_actual);
    });
  }

  /**
   * Define a module within the Sereth AMD environment
   *
   * @param {Object} key
   *     The identifier for this module. This will be used to specify dependencies.
   * @param {Object|Object[]} [dependencies]
   *     The key, or array of keys of modules required for the definition of this module
   * @param {function} callback
   *     A callback that returns the value of the module to be stored. Parameters will be the requested dependency modules
   */
  root['def_module'] = function (key, dependencies_or_callback, callback) {
    // Handle infixed optional dependencies parameter
    var dependencies = null;
    if (typeof dependencies_or_callback == function_type) callback = dependencies_or_callback;
    else dependencies = dependencies_or_callback;

    // Verify callback is a function
    if (typeof callback != function_type) throw callback_error;

    // Resolve the dependencies, and store the new module
    root.use_module(dependencies, function (dependencies_actual) {
      store_dependency(key, callback.apply(root, dependencies_actual));
    })
  }

  /* Local Variables */
  var dependency_resolvers = {};
  var dependency_promises = {};

  /* Helper Functions */
  // Returns a promise for a single named dependency
  function lookup_dependency(key) {
    if (!dependency_promises[key]) {
      dependency_promises[key] = new Promise(function(resolve, reject) {
        dependency_resolvers[key] = resolve;
      });
    }

    return dependency_promises[key];
  }

  // Promises any number of named dependencies. Must return a promise that resolves to an array.
  function satisfy_dependencies(keys) {
    // Given no keys, resolve to an empty array
    if (!keys) return satisfy_dependencies([]);
    // Given keys that responds to map (like an array), map the keys into an array of individual promises, and combines them through Promise.all
    else if (typeof keys.map == function_type) return Promise.all(keys.map(lookup_dependency));
    // Given a non-array like key, run a single lookup through Promise.all to get array resolution
    else return Promise.all([lookup_dependency(keys)]);
  }

  // Resolves a single named dependency
  function store_dependency(key, value) {
    // Lookup the dependency promise, and resolve
    var dependency_promise = dependency_promises[key];
    var dependency_resolver = dependency_resolvers[key];

    if (!dependency_promise) {
      // If module has not been looked up, just create a resolved promise
      dependency_promises[key] = Promise.resolve(value);
    } else {
      // If module has been looked up, try to resolve it. If there is a promise, but no resolver then it must have already been resolved.
      if (dependency_resolver) {
        dependency_resolver.call(dependency_promise, value);
        delete dependency_resolvers[key];
      } else {
        throw exists_error;
      }
    }
  }
})(this);


feature: add stat_linux_arm64.go to support for building on arm

Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?

fixes: #481
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

Thanks for your contribution. And could you please sign off your commit?  😄

@lurenjia528 Please write the title of this PR according to the guidance of contribution. There are some useful documents in the repo. You also can refer to this example: https://github.com/dragonflyoss/Dragonfly/pull/316

manually merged via command line


Update the URL of bbs and wiki.

@SnowballXueQiu CC.

And the website is not the newest?

And the website is not the newest?

resolve


slack:notifier : Exclude prestashop-specs from PR sent to devs

Questions
Answers

Description?
slack:notifier : Exclude prestashop-specs from PR sent to devs

Type?
improvement

Thanks you @Progi1984


⚠ Bofrost.at has degraded performance

In 8fdf318, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 2187 ms

Resolved: Bofrost.at performance has improved in 909274b.


Rename target_rows argument to max_pairs in estimate_u_using_random_sampling()

This is actually what this argument represents. I added some compat
so this change shouldn't be breaking.

@NickCrews I think this makes sense - I am going to change the base branch from master to rename_target_rows which I have created and merge in order to get the tests running properly. Then I will open another PR to go from that into master


Pageslice cards not loading correctly if there are a lot of cards

In GitLab by @lakhoune on Jan 17, 2021, 13:01
If there  are more than 80 cards the carousel will not load the cards correctly on new slice. This is due to the fact that handleNewCard cannot find the new index because the new cards have not yet been loaded into this.tmp . This is probably due to the fact that cards.slice takes a long time and it is called at each slide

In GitLab by @lakhoune on Jan 17, 2021, 13:04
The Displayed cards can be found in the selector.ts file


Allow static build

Currently, the generation of the main preview is done in dev-only webpack hooks.
So static build doesn't work at all.
The PreviewPlugin should handle both envs, or another plugin should be added and used depending on the env.

Fixed in #9


H5 project exception  Cannot read property 'querySampleTypeAggregated' of undefined

angular.js:12330 TypeError: Cannot read property 'querySampleTypeAggregated' of undefined
at querySampleTypeAggregat (healthMovement.js:31)
at moveOut (healthMovement.js:87)
at draw (healthMovement.js:93)
at new  (healthMovement.js:140)
at invoke (angular.js:4450)
at Object.instantiate (angular.js:4458)
at angular.js:9014
at Object.self.appendViewElement (ionic-angular.js:6398)
at Object.render (ionic-angular.js:4592)
at Object.init (ionic-angular.js:4512)

copy the healthkit.js into my project,but it created an error when I use window.plugins.healthkit.querySampleTypeAggregated ,someone can help me?   thanks!!!


Get nym displays role INDY-333

The cli.py will now test if there is a role associated with a GET_NYM transaction. If a role is defined, then it will display the role. If a role is not defined (either None or '' ) then it will not display the role.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


p7zip is preinstalled in macos

https://github.com/jurplel/install-qt-action/issues/244

Nice PR.
And I'm confused why we needed "p7zip" on macOS. I read the docs of py7zr but didn't see the requirement of "p7zip". Maybe I'm missing something?
Is "p7zip" related to External 7-zip extractor § Getting Started — aqtinstall 3.1.16 documentation ?

My guess is, in the earlier versions of macOS GitHub runners, they did not have p7zip, which is used by aqtinstall action so they had to install it every time. In the latest macOS p7zip is pre-installed. Unfortunately, that is pretty much everything I know about this.


Broken Link to Angular Cheatsheet during environment setup

Link leads to a 404 page.
Proposed Change:  #11

Fixed via #11


LiteLLM API key Config

Description
Adds support to provide api_key directly to config instead of setting in env variables. Since the model defaults to gpt-4o-mini, key also defaults to OPENAI_API_KEY if not provided.
Fixes #1746
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Refactor (does not change functionality, e.g. code style improvements, linting)
[ ] Documentation update

How Has This Been Tested?
Tested by giving api_key directly to config instead of env variables
Please delete options that are not relevant.

[ ] Unit Test
[ ] Test Script (please provide)

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules
[x] I have checked my code and corrected any misspellings

Maintainer Checklist

[x] closes #1746
[ ] Made sure Checks passed

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Ignore, the other PR #1747  solves it already.


Upgrade to newer nanovg version

This crate currently targets a outdated nanovg commit from 2015. Upgrading to a newer version is probably a very good idea. I'm not a nanovg pro so I don't know specifics, but I assume not much has changed API wise, so the upgrade should be mostly straight forward.

Would be solved by #32.


:radio_button: add online task buttons

:rocket: deployment of profiles-pr-114 in nhsuk-dev succeeded (http://profiles-pr-114.dev.beta.nhschoices.net)

:rocket: deployment of profiles-pr-114 in nhsuk-dev succeeded (http://profiles-pr-114.dev.beta.nhschoices.net)

How low are we supporting this? IE8 on Win7 on Browserstack

:rocket: deployment of profiles-pr-114 in nhsuk-dev succeeded (http://profiles-pr-114.dev.beta.nhschoices.net)

:rocket: deployment of profiles-pr-114 in nhsuk-dev succeeded (http://profiles-pr-114.dev.beta.nhschoices.net)

Look ok to me!


Why no trailing slash on self closing elements?

Just wondering, given its optional status, why not use it?
Using it makes it easy to differentiate between an closed 'void' element and an accidentally unclosed element...

It's an unnecessary syntactical bit, yes, but the main thing to realizes is that a trailing slash isn't the focus of the element. When I think of an , I know it doesn't need closing, so I know I don't need to go looking for an indicator of it being closed. I just think . Same with
,
, etc.

This falls in the same camp as the 'no final semi-colon'.
While I personally always add the closing slash to all these type of tags, and the final semi-colon for that matter, it is not necessary, it just makes me happy.
This is a code 'guide' to help give us all a base of good coding practices, and direction, not a coding law/requirement.
Take what you need from the guide, and try to understand it's principles, and hopefully it will help you become a better programmer.
I think the main idea of the guide is to bring us all together, so when I open your code I'm not lost, making us more productive.


Switch to Github Actions from Travis-CI, update supported python version

Removed old python versions added newer python versions
It currently passes, see: https://github.com/asherf/docformatter/actions/runs/1767671452

@myint Ping


Bulma-Extensions: Checkradio

Add support for the checkradio form components.
See docs here: https://wikiki.github.io/form/checkradio/

These are now working.


Add $is_identified

Description
https://github.com/PostHog/posthog/pull/22216
$is_identified is the property to filter identified users or not (anonymous).
https://github.com/PostHog/posthog-js/blob/7022ab69505959fb065d41870d2bceeb69145916/src/posthog-core.ts#L912
JS SDK uses the $user_state super property to track if the user has identified already or not with the values identified or anonymous (this super property is in deny list so not set in the event)
Add to:

[ ] Android
[ ] iOS
[ ] RN

See this comment before implementing https://github.com/PostHog/posthog/issues/10659#issuecomment-2142256209

Hi, I can I take up this issue? I think adding the is_identified property to the PostHog class with a get() getter that checks if the anonymousId is equal to the distinctId, will solve this.

Hi, can I take up this issue? I think adding the is_identified property to the PostHog class with a get() getter that checks if the anonymousId is equal to the distinctId, will solve this.

Hello, sure, feel free to open a Draft PR and I can guide you, I'd link at https://github.com/PostHog/posthog-js/blob/7022ab69505959fb065d41870d2bceeb69145916/src/posthog-core.ts#L912 instead since its more reliable than just comparing the distinctId and anonymousId.

Thanks a lot for the help. Can you explain me why will it be more reliable than comparing them? Going through PostHog.kt, what I've understood is that, if identify() hasn't been invoked earlier i.e. distinctId hasn't been set, then distinctId defaults to the anonymousId. Once identify() is invoked, the distinctId is changed and set to distinctId param of identify(). So, comparing distinctId and anonymousId would be in my opinion a single source of truth to verify if the user is identified or not.

@beradeep good point and I don't disagree but this is a heuristics approach, this behavior may change hence implementing directly on identify and reset would be the correct approach without side effects in case this changes.

Ah, I see. Also going through posthog-js, it seems that an "identify" event is captured only when new_distinct_id !== previous_distinct_id && isKnownAnonymous is true, however in posthog-android, it is captured whenever we call identify(). Is there any specific reason to that?

Ah, I see. Also going through posthog-js, it seems that an "identify" event is captured only when new_distinct_id !== previous_distinct_id && isKnownAnonymous is true, however in posthog-android, it is captured whenever we call identify(). Is there any specific reason to that?

Nope, something I likely missed during the Android implementation or that was added after on the JS SDK, we can either address that too or make a new issue.

Nope, something I likely missed during the Android implementation or that was added after on the JS SDK, we can either address that too or make a new issue.

I'm sorry, I just noticed that there's already an open issue #108 mentioning this. Yes, I think both these issues are related, and can be resolved together.


Implement PoW rate limiting extension for greater protection and better system characteristics

PoW is a better way to rate limit than basic resource denial. Implement a PoW mechanism with escalating work challenges issued to callers via 429 response payloads.

This falls in web5-js land.


Handle subdomains

When trying to make a request from example.com to a protected CSRF endpoint on api.example.com, verification fails as the CSRF cookie is not the same one between domains/subdomains.
Would be nice to have an option to specify the domain(s) when creating the cookie.

Thanks for the feedback. Added in 0.6.1.


More doxygen warning fixes

Part of #2329
Fixes #2186.
Fixes #1696
This PR includes my previous PR #2330.
In this PR I add a bunch more fixes for doxygen warnings.
The remaining warnings are somewhat stubborn, and I can't quite figure out what to do with them. But let's get these changes in because they will improve the documentation for the release.

This work is included in #2336, so I will close this PR.


Enhance readme

Enhance the readme by adding the following sections with relevant content:

Introduction
Quickstart
Advanced usage
Development - Contributing
FAQ

[ ] Add  query endpoint examples for alerts, cases and observables using the respective find endpoints


add telemetry.auto.name

add telemetry.auto.name as the name of the agent or distribution.
Right now, you can use telemetry.sdk.name, but

is not correct if you build a distribution (e.g. a spring boot starter) and you didn't change the SDK in any way
it's not clear that telemetry.auto.version should be the version of telemetry.sdk.name

Question:

should we call it telemetry.distribution.(name|version) instead?

Do you have any recommendation how to call official distributions?

I would be in favor of telemetry.distro.name (and version) instead of auto because we also have the need in Android, where it's mostly not "auto-instrumentation". We can use this regardless, it's just less fitting with auto in the name. I think distro is more flexible and applies cleanly to other situations.

I would be in favor of telemetry.distro.name (and version) instead of auto because we also have the need in Android, where it's mostly not "auto-instrumentation". We can use this regardless, it's just less fitting with auto in the name. I think distro is more flexible and applies cleanly to other situations.

Then probably we should also rename telemetry.autp.version to telemetry.distro.version. While I think it is a good idea as the name can even include "auto" to make it clear that the distribution is an automatic instrumentation I would rather prefer to have it as a separate PR.

@zeitlinger How do we want to proceed with that?
Do you mind updating the PR to the proposal from above? (updating to telemetry.distro.name + telemetry.distro.version): https://github.com/open-telemetry/semantic-conventions/pull/178#issuecomment-1662576602

@zeitlinger How do we want to proceed with that?
Do you mind updating the PR to the proposal from above? (updating to telemetry.distro.name + telemetry.distro.version): #178 (comment)

yes, that's a good idea :smile:

Do you have any recommendation how to call official distributions?
There is a strict recommendation what to set for sdk.name attribution
**[1]:** The OpenTelemetry SDK MUST set the `telemetry.sdk.name` attribute to `opentelemetry`.
If another SDK, like a fork or a vendor-provided implementation, is used, this SDK MUST set the
`telemetry.sdk.name` attribute to the fully-qualified class or module name of this SDK's main entry point
or another suitable identifier depending on the language.

I would like to rise this topic once more time before merging.

@zeitlinger This still needs a telemetry schema file

@open-telemetry/specs-semconv-maintainers I guess this can be merged?

@joaopgrassi @Kielek thanks for the feedback :smile:
Added a section on naming the official distro & fixed the schema file.


CASSANDRA-18129 Accord <-> Paxos live migration

I think we need a way to segregate normal and accord data for paxos->accord migration to work correctly. Otherwise the repair and coordinated read operations can replicate data from the future onto the local node.

There is definitely a problem here with coordinators and recovery coordinators. @dcapwell  just fixed CASSANDRA-18422 which is similar where two coordinators are concurrently reading and writing and one coordinator accidentally reads the writes of the other. The fix there was to invalidate any in-flight reads when committing a write.
The invalidation approach won't help with repair. Seem like for repair the data starts segregated, and we could keep it segregated, and then commit it into Accord in a range transaction?

The good news is that this would solve the problem of how to run data repairs in clusters where users are mixing normal and accord operations, and if this metadata was the accord execution epoch, it would be pretty useful in bootstrap/range movement/and extended failure recovery.
Can you elaborate more on this stable component? What would it contain?

For coordinated reads. Maybe it makes sense to run those in Accord and route them through their respective command stores so invalidation works? I am not clear if that is better or worse than segregating Accord writes since I don't understand the thinking there yet.

This problem is resolved in the bootstrap patch by disabling reads for txnid less than some point determined after the repair snapshot was taken. It might be we want to hook into that.
The pain point for coordinated reads is that they aren't a quorum of reads from Accord command stores they are a regular quorum read in Cassandra so there is no filtering there to prevent picking up data from other nodes that have moved on to later transactions.

There is no Accord transaction that starts the migration to Accord for a range that is after some snapshot. Migration uses repair and repair is unreliable so it starts after the migration to Accord begins and keys are migrating before the repair even starts.
I think both repair and coordinated reads have to change.


chore: Update Spark operator example to use new bootstrap flag for instance store volume RAID0 configuration

What does this PR do?

Update Spark operator example to use new bootstrap flag for instance store volume RAID0 configuration
Remove addons not used by pattern (nginx-ingress, aws load balancer controller)
Clean up VPC CNI configuration
Update EKS blueprints addons version; use default policy provided for AWS for FluentBit

Motivation

This was recently added to the EKS AMI https://github.com/awslabs/amazon-eks-ami/pull/1171

More

[x] Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
[ ] Mandatory for new blueprints. Yes, I have added a example to support my blueprint PR
[ ] Mandatory for new blueprints. Yes, I have updated the website/docs or website/blog section for this feature
[x] Yes, I ran pre-commit run -a with this PR. Link for installing pre-commit locally

For Moderators

[ ] E2E Test successfully complete before merge?

Additional Notes

k get pods -A
NAMESPACE              NAME                                                              READY   STATUS    RESTARTS   AGE
amazon-cloudwatch      aws-cloudwatch-metrics-7bq9k                                      1/1     Running   0          47m
amazon-cloudwatch      aws-cloudwatch-metrics-9g7wb                                      1/1     Running   0          12m
amazon-cloudwatch      aws-cloudwatch-metrics-cg4r6                                      1/1     Running   0          12m
amazon-cloudwatch      aws-cloudwatch-metrics-rn9z2                                      1/1     Running   0          47m
amazon-cloudwatch      aws-cloudwatch-metrics-zflrs                                      1/1     Running   0          45m
grafana                grafana-8466845568-gl9td                                          1/1     Running   0          41m
karpenter              karpenter-c8d5488d-58qf9                                          1/1     Running   0          38m
karpenter              karpenter-c8d5488d-mwwvs                                          1/1     Running   0          44m
kube-system            aws-for-fluent-bit-9n5vv                                          1/1     Running   0          12m
kube-system            aws-for-fluent-bit-r42rr                                          1/1     Running   0          47m
kube-system            aws-for-fluent-bit-r544b                                          1/1     Running   0          47m
kube-system            aws-for-fluent-bit-rwgws                                          1/1     Running   0          12m
kube-system            aws-for-fluent-bit-tzml7                                          1/1     Running   0          45m
kube-system            aws-node-cjs9p                                                    1/1     Running   0          47m
kube-system            aws-node-cq6h4                                                    1/1     Running   0          45m
kube-system            aws-node-d6jfw                                                    1/1     Running   0          47m
kube-system            aws-node-k9t5q                                                    1/1     Running   0          12m
kube-system            aws-node-lnjcz                                                    1/1     Running   0          12m
kube-system            cluster-autoscaler-aws-cluster-autoscaler-84764c55b6-hldpc        1/1     Running   0          44m
kube-system            cluster-proportional-autoscaler-kube-dns-autoscaler-758f884tgx7   1/1     Running   0          44m
kube-system            coredns-f76998b44-277n8                                           1/1     Running   0          38m
kube-system            coredns-f76998b44-mh8hw                                           1/1     Running   0          41m
kube-system            ebs-csi-controller-6bd74c9df-cmqsr                                6/6     Running   0          38m
kube-system            ebs-csi-controller-6bd74c9df-pdk8n                                6/6     Running   0          41m
kube-system            ebs-csi-node-294gk                                                3/3     Running   0          45m
kube-system            ebs-csi-node-2lmh5                                                3/3     Running   0          12m
kube-system            ebs-csi-node-bxrzf                                                3/3     Running   0          12m
kube-system            ebs-csi-node-k6gs6                                                3/3     Running   0          47m
kube-system            ebs-csi-node-v5zr7                                                3/3     Running   0          47m
kube-system            kube-proxy-6bdsj                                                  1/1     Running   0          45m
kube-system            kube-proxy-bjzjp                                                  1/1     Running   0          47m
kube-system            kube-proxy-h9bd6                                                  1/1     Running   0          12m
kube-system            kube-proxy-jzn27                                                  1/1     Running   0          12m
kube-system            kube-proxy-s7bln                                                  1/1     Running   0          47m
kube-system            metrics-server-644f9cbbcf-m8bzf                                   1/1     Running   0          38m
kube-system            metrics-server-644f9cbbcf-zk7md                                   1/1     Running   0          41m
kubecost               kubecost-cost-analyzer-58c6674d57-zwkqn                           2/2     Running   0          44m
kubecost               kubecost-prometheus-server-7bc77dcc7f-cncwn                       2/2     Running   0          44m
prometheus             prometheus-kube-state-metrics-79775c6c-trkz9                      1/1     Running   0          44m
prometheus             prometheus-prometheus-node-exporter-5knpr                         1/1     Running   0          47m
prometheus             prometheus-prometheus-node-exporter-jmwqv                         1/1     Running   0          12m
prometheus             prometheus-prometheus-node-exporter-jsr85                         1/1     Running   0          12m
prometheus             prometheus-prometheus-node-exporter-q4qp2                         1/1     Running   0          45m
prometheus             prometheus-prometheus-node-exporter-sbzzr                         1/1     Running   0          47m
prometheus             prometheus-server-6c5b74d9d9-4x2h4                                2/2     Running   0          41m
spark-history-server   spark-history-server-7ddddbcd86-mqb44                             1/1     Running   0          44m
spark-operator         spark-operator-5fd887888d-bccx5                                   1/1     Running   0          41m
yunikorn               yunikorn-admission-controller-865dcdd5bb-xlbjg                    1/1     Running   0          44m
yunikorn               yunikorn-scheduler-7695f8b55d-9fxv5                               2/2     Running   0          38m

Also, did you observe that mount path is getting created as /mnt/k8s-disks/0


Fix crash when optimizing shaders with DebugPrintf

Fixes #4219

@alan-baker Can you pls review? There are a couple groups waiting for this fix. Thanks!

@dnovillo Could you find someone to review please if @alan-baker is not available?

Thanks for the review @alan-baker. Didn't mean to be impatient :)
I am deferring removal of the non-semantics only because the algorithms that iterate over all instructions in a function seem to not tolerate killing of the next instruction in the iteration. It just seemed cleanest to collect these and delete them all after the analysis iteration was complete.
I am not deferring removal to necessarily affect an order of deletion based on use-before-def ordering. While that does seems potentially desirable, it does not seem that the current DefUse mechanism requires it. While the previous algorithm did remove a non-semantic use before its non-non-semantic def, it did not enforce such an ordering within a non-semantic tree. Neither did it enforce such an ordering among non-non-semantic instructions.
I can improve to do all removal in use-before-def order if you think that is necessary or advantageous.

I'm ok as long as the def-use manager is ok with it.


Azure provider

Still need more work

Is this overlapping with https://github.com/Capgemini/Apollo/pull/320 ?

What's the current state of this? still WIP? I haven't made an Azure deployment but code looks pretty good to me.
This needs Rebase on master though.

I am gonna create a new PR with a different approach. Because I encountered some difficulties using terraform with azure so I decided to do it with Azure Resource Manager template using azure cli.
https://azure.microsoft.com/en-gb/documentation/articles/resource-group-template-deploy/#deploy-with-azure-cli-for-mac-linux-and-windows
I am going to build an inventory file base on the example.
https://github.com/ansible/ansible/blob/devel/contrib/inventory/windows_azure.py
Anyway we should keep the PR just in case if terraform will have better support for Azure. At the moment there are not support for ARM.

Setting this PR to blocked for now then.

Removing blocked label - we have a way forward with https://github.com/hashicorp/terraform/pull/3695


Add MrLololoshka - The Anthem of Radiance by Quineros AE BOCXOD

Song Name
MrLololoshka - The Anthem of Radiance
Artist Name
Quineros AE BOCXOD
Source
Direct file download
Youtube Link
CYqnmwDF6pTzMaku
Direct File Link
quineros-ae-voshod-gimn-siyaniya-mp3.mp3
Song ID
993
Start Offset [ms]
0
Extra
Created from Auto Nong.
Created for level: 108395799

reject
use youtube as source, other sources are not supported


use maven wrapper to ensure maven 3.3.9 is used

and upgrade maven-jar-plugin to 3.0.2
Based on some issues I ran into when testing on travis-ci.
Using maven wapper is recommended in:
https://github.com/travis-ci/travis-ci/issues/4872

maven wrapper is awesome!

@pjfanning Sorry for the delay, and thanks for this. Would you consider submitting a similar PR to the 2.0 branch (our next-get core)?

@webron I just added https://github.com/swagger-api/swagger-core/pull/2431

Hmm, some bad news. Even though the PR built properly, master's build is failing after merge.

@webron I raised a Travis CI bug - https://github.com/travis-ci/travis-ci/issues/8455
There seems to be a problem with builds that use oraclejdk7.
The 2.0 branch uses oraclejdk8 without issue

Any idea if the issue also exists with openjdk7? We can switch to that. Otherwise, we'll have to revert the PR for now.

I've kicked off a PR build with openjdk7: https://github.com/swagger-api/swagger-core/pull/2432

@webron https://github.com/swagger-api/swagger-core/pull/2432 passed - could you merge that?

Great, we're making progress.


Directory seems wierd... Are you sure the install directory needs to be set to Custom Scenery, or where the X-Plane executable is?

"C:/Program Files (x86)/Steam/steamapps/common/X-Plane 12/Custom Scenery" seems wrong, will exit due to errors."

This message is warning you because it is not a standard place you are putting your data. Standard would be
C:\X-Plane 12\Custom Scenery
I get this message because my XP lives on drive G: and my data is on drive D:. Just press OK and it works fine.

Except it closes when I press OK. Does it still run for you?

Yes, it does continue working fine. So maybe look at your .autoortho file - perhaps delete it and start AO to create a new one. Then be careful where you point it.
I do not use Steam so maybe there is something there in the Steam setup that it doesn't like.
As I said, that is just warning you that it does not agree with your locations. Make sure they are correct and it should play.
I hope some Steam user can reply if they've seen this problem.

The website says that the XI tried deleting all the files, reinstalling, AutoOrtho. My current "Setup" page is:
Scenery install dir: C:/Program Files (x86)/Steam/steamapps/common/X-Plane 12/Custom Scenery
X-Plane install dir: C:/Program Files (x86)/Steam/steamapps/common/X-Plane 12/Custom Scenery
Still get the same error.
Does it need to be:
X-Plane install dir: C:/Program Files (x86)/Steam/steamapps/common/X-Plane 12
Does the website instruction page need to be updated to reflect 0.6.0-1?
There was no "X-Plane install dir:" box in the older versions.

Please check out this tutorial and skim thru what you know. Maybe a tidbit will help you. Sorry.
https://forums.x-plane.org/index.php?/forums/topic/293308-autoortho-installation-tutorial/#comments


How can we see results of deploy-preview?

We probably need some instructions. I cannot easily find it.

Once the Actions is done, a bot will post a comment in the PR

When a PR is merged, the preview is removed.

This is how it works.

Thanks! Understood.


feat: customer client connection

The client load balancing proxy executes the client.
There is already a cluster of load balancing connections executing the client.
It supports batch data writing and transmission compression.

@ljz0721cx closed by no udates and conflict, feel free to reopen it if you still want to work on this. :)


Consider projects in Jest config

My Jest config looks something like this:
import { readdirSync } from 'node:fs';

const project = (name) => ({
  setupFilesAfterEnv: ['<rootDir>/../../jest.setup.ts'],
  // ...
});

const CONFIG = {
  projects: readdirSync('packages').map((x) => project(x)),
  // ...
};

export default CONFIG;

Knip doesn't look at projects, so jest.setup.ts and the stuff it imports end up being marked as unused.

Are you sure you aren't thinking of presets? Grepping the plugin doesn't reveal any occurrences of projects.

Apologies, you're right. Probably an easy fix then :)

:rocket: This issue has been resolved in v2.18.0. See Release 2.18.0 for release notes.

Also caught another uncovered runner prop :)

Thank you!

There's a mistake here, Jest is weird about the resolution of the paths in projects, it's done relative to the root of the project, not the root of the repository, so given setupFilesAfterEnv: ['<rootDir>/../../jest.setup.ts'] Knip ends up looking for it in repo_root/../.., not in repo_root/packages/foo/../... I wish I could just put setupFilesAfterEnv in the base config of Jest, but that doesn't work at all.

Are you sure? Knip replaces <rootDir> with the dir of the project.
I just added f32d8156d00b14958416911989722c6ee01a8ca7 for extra test coverage.
In the plugin the variable is called cwd which might lead to confusion?

It definitely breaks if there are .. involved (with the configuration from the original post). Note that setupFilesAfterEnv is in projects, not in the root config, as it is in the fixture linked :stuck_out_tongue:

It's path.join(rootDir, optionValue) so I think the issue is not the .., but the fact that the linked file is in a different workspace.
What is the result you're seeing?

I get the following:
Unused files (1)
jest.setup.ts
Unresolved imports (1)
/dir-two-levels-below-repo-root/jest.setup.ts  jest.config.js

The idea is that modules are isolated, shouldn't traverse like that in a monorepo.
E.g. ESLint can reference other workspaces with extend specifiers like @org/eslint-config-name/config-file.

Hmm, my intention is to have as much development boilerplate in the root as possible. My jest.setup.ts has just this:
import { toMatchImageSnapshot } from 'jest-image-snapshot';
import { toBeDeepCloseTo } from 'jest-matcher-deep-close-to';

expect.extend({ toMatchImageSnapshot, toBeDeepCloseTo });

And currently I'm getting away with not having a copy/symlink of it in every package. Also makes sense to colocate it with jest.config.js, as one is basically an extension of the other.
What would you change about this? :thinking:

Maybe you can tell Jest to look for jest.setup.ts in the root?
Either way, this is the reason I didn't went too far with trying to support all types of cross-package references like this and try to be relatively strict about it. Whatever you end up with, I hope there's a way Knip plays nice with to (probably some combo of ignore and jest in root and/or packages using Jest).

Hmm, I think there's a misunderstanding. Confusingly, in the examples above, Jest resolves <rootDir> to /root/package/foo, not /root. And I can't put setupFilesAfterEnv in the main config; if I do that, then its effects don't propagate to the projects. Both jest.config.js and jest.setup.ts are located in the root of the monorepo, and I run Jest from the root as well. There's zero Jest configuration in any of the packages themselves. Let me know if you'd like me to setup a repro!

This result is expected behavior: https://github.com/webpro/knip/issues/189#issuecomment-1666879431. You can use ignore and jest entry/config items in knip.json for Knip to handle this better. Currently I don't really feel like messing around isolated packages too much.
Feel free to open a repo if you think there's a bug on Knip. It could also be useful as a reference to discuss how to best handle the situation as it might be a common setup.

Created a repro: https://github.com/alecmev/knip-repro-189 You can try playing around with the config of Jest, this is the only way to have a reusable jest.setup.js, AFAIK.

@webpro Have you had a chance to take a look at the repro? Just wondering if you believe that it's an anti-pattern and I should try setting it up differently, or if it's something that Knip may support in the future.

Yes, I looked at it and this is Knip's behavior as expected.
Don't want to leave anyone behind, but some tools allow things that are hard to deal with for Knip. Another notable example is ESLint. Luckily they ESLint has realized this too and are going the sane route with the new explicit eslint.config.js way of configuring things.
So unfortunately, no, I'm not eager to spend my time here, but of course I would be happy to look into PRs with sane solutions.

A quick update for future readers, I ended up getting rid of rootPath and just pre-resolving everything:
import { readdirSync } from 'node:fs';
import { fileURLToPath } from 'node:url';

const project = (name) => ({
  setupFilesAfterEnv: [fileURLToPath(new URL('jest.setup.ts', import.meta.url))],
  // ...
});

const CONFIG = {
  projects: readdirSync('packages').map((x) => project(x)),
  // ...
};

export default CONFIG;


Migrate to null safety

Is your feature request related to a problem? Please describe.
Flutter stable now uses Dart 2.12.0 which supports sound null safety.
Describe the solution you'd like
Add support for null safety.
Additional context
Can start upgrading to null safety by updating SDK from sdk: ">=2.7.0 <3.0.0" to sdk: ">=2.12.0 <3.0.0" and running dart migrate on this package.

I've tried to do it here #265


Vickel: Watch pinibuy.com

Vickel requests the watch of the watch_keyword pinibuy\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

pinibuy\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.


WARN "subject occluded", while visible in Nexus

Hello,
I use Nexus 2.7.0, but when I run roslaunch vicon_bridge vicon.launch I get the warning that my created subject is occluded while I see this created subject in Vicon Nexus. A colleague for who it was working a month ago, has the same problem as me right now.
Information is exchanged for sure between the Vicon computer and my computer (Ubuntu 16.04, colleague Ubuntu 18.04), because when we change the session and so the subjects in Nexus, we also see that the names of the subjects in the warning message changes.
We did the test with a live subject and with a recorded subject, but none of them works.
Below you can see the message we get for the subject called Kelly.

I hope someone knows the solution to this problem!
Thanks in advance,
Kelly

Hello again,
In Nexus you have to make sure that the processing output level is kinematic fit, like in the screenshot below.

Like this the problem should be solved.


[WIP]

testing...

Codecov Report
Patch coverage has no change and project coverage change: +0.01 :tada:

Comparison is base (0462ce6) 86.20% compared to head (989cdcb) 86.21%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #62      +/-   ##
==========================================
+ Coverage   86.20%   86.21%   +0.01%
==========================================
  Files         199      199
  Lines       14759    14795      +36
==========================================
+ Hits        12723    12756      +33
- Misses       1734     1735       +1
- Partials      302      304       +2

see 3 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


silently failing make

I'm trying to run make from the root pf the project but it is failed to lint the files silently:
$ PYTHON=/usr/bin/python3 make
cd ./ && /usr/bin/python3 .//cpplint.py --filter=-whitespace/parens examples/async_pi_estimate/addon.cc examples/async_pi_estimate/async.cc examples/async_pi_estimate/async.h examples/async_pi_estimate/pi_est.cc examples/async_pi_estimate/pi_est.h examples/async_pi_estimate/sync.cc examples/async_pi_estimate/sync.h nan.h nan_callbacks.h nan_callbacks_12_inl.h nan_callbacks_pre_12_inl.h nan_converters.h nan_converters_43_inl.h nan_converters_pre_43_inl.h nan_define_own_property_helper.h nan_implementation_12_inl.h nan_implementation_pre_12_inl.h nan_json.h nan_maybe_43_inl.h nan_maybe_pre_43_inl.h nan_new.h nan_object_wrap.h nan_persistent_12_inl.h nan_persistent_pre_12_inl.h nan_private.h nan_string_bytes.h nan_weak.h test/cpp/accessors.cpp test/cpp/accessors2.cpp test/cpp/asyncresource.cpp test/cpp/asyncworker.cpp test/cpp/asyncprogressworker.cpp test/cpp/asyncprogressworkerstream.cpp test/cpp/asyncprogressworkersignal.cpp test/cpp/asyncprogressqueueworker.cpp test/cpp/asyncprogressqueueworkerstream.cpp test/cpp/asyncworkererror.cpp test/cpp/buffer.cpp test/cpp/bufferworkerpersistent.cpp test/cpp/error.cpp test/cpp/gc.cpp test/cpp/indexedinterceptors.cpp test/cpp/callbackcontext.cpp test/cpp/converters.cpp test/cpp/isolatedata.cpp test/cpp/json-parse.cpp test/cpp/json-stringify.cpp test/cpp/makecallback.cpp test/cpp/maybe.cpp test/cpp/morenews.cpp test/cpp/multifile1.cpp test/cpp/multifile2.cpp test/cpp/multifile2.h test/cpp/namedinterceptors.cpp test/cpp/nancallback.cpp test/cpp/nannew.cpp test/cpp/news.cpp test/cpp/objectwraphandle.cpp test/cpp/persistent.cpp test/cpp/private.cpp test/cpp/returnemptystring.cpp test/cpp/returnnull.cpp test/cpp/returnundefined.cpp test/cpp/returnvalue.cpp test/cpp/setcallhandler.cpp test/cpp/settemplate.cpp test/cpp/sleep.h test/cpp/strings.cpp test/cpp/symbols.cpp test/cpp/threadlocal.cpp test/cpp/trycatch.cpp test/cpp/typedarrays.cpp test/cpp/weak.cpp test/cpp/weak2.cpp test/cpp/wrappedobjectfactory.cpp node_modules/node-gyp/gyp/data/win/large-pdb-shim.cc
make: *** [Makefile:92: lint] Ошибка 1

How to fix it?

Try this: make PYTHON=python2 - cpplint.py currently dies quietly with python 3.

We have not supported python2 already... (


1440p 165hz screen is stuck at 1440p 120hz

Hyprland Version
hyprland, built from branch main at commit 512a59731b2e579b66325d0e9ce770919eecd685 dirty (config: default special_scale_factor to 1). Tag: v0.32.3-64-g512a5973
Bug or Regression?
Bug
Description
My primary monitor is 2560x1440 165hz but in hyprland it's only detected as 2560x1440 120hz.
165hz works in windows so I know its not a hardware issue but a software/driver issue.
I have tried both highres, highrr and 2560x1440@165 with the same result.
This is my hyprland.conf
monitor = DP-1,highres, 1920x0, 1
monitor = HDMI-A-1,highres,0x0,1
monitor = DVI-D-1,highres,1920x-1080,1

xrandr
DP-1 connected primary 2560x1440+1920+0 (normal left inverted right x axis y axis) 600mm x 340mm
   2560x1440    119.95*+
   1920x1440    119.97
   1600x1200    119.82
   1440x1080    119.92
   1400x1050    119.90
   1280x1024    119.83
   1280x960     119.89
   1152x864     119.77
   1024x768     119.80
   800x600      119.85
   640x480      119.52
   320x240      117.34
   1920x1200    119.90
   1680x1050    119.89
   1440x900     119.94
   1280x800     119.85
   1152x720     119.73
   960x600      119.74
   928x580      119.55
   800x500      119.47
   768x480      119.71
   720x480      119.65
   640x400      119.64
   320x200      117.55
   2048x1152    119.89
   1920x1080    119.93
   1600x900     119.95
   1368x768     119.83
   1280x720     119.67
   1024x576     119.85
   864x486      119.69
   720x400      119.54
   640x350      119.24

hyprctl monitors
Monitor DP-1 (ID 1):
<EMAIL_ADDRESS>at 1920x0
	description: ASUSTek COMPUTER INC VG27A N8LMQS070105 (DP-1)
	make: ASUSTek COMPUTER INC
	model: VG27A
	serial: N8LMQS070105
	active workspace: 2 (2)
	special workspace: 0 ()
	reserved: 0 0 0 0
	scale: 1.00
	transform: 0
	focused: no
	dpmsStatus: 1
	vrr: 0
	activelyTearing: false

How to reproduce
.
Crash reports, logs, images, videos
No response

can't you just do monitor = DP-1,2560x1440@165,1920x0,1

can't you just do monitor = DP-1,2560x1440@165,1920x0,1

Forgot to mention that I have also tried that :smile:

wlroots issue. does happen.

@vaxerski Happens to me too.. Is there a solution?

afaik, no

Try doing cvt -r 2560 1440. You should hopefully get something along those linesModeline "2560x1440_165.00"  109.00  1280 1368 1496 1712  1024 1027 1034 1063 -hsync +vsync. This basically shows the Modeline for the resolution you want.
Then you need to type xrandr --newmode and add everything yafter Modeline you got before, so in this case "xrandr --newmode "2560x1440_165.00"  109.00  1280 1368 1496 1712  1024 1027 1034 1063 -hsync +vsync. to create a new xrandr mode.
Then type xrandr --addmode DP-1 2560x1440_165.00 to add this mode to your current output device.
And then you just change the output to the new mode you added by doing this xrandr --output DP-1 --mode 2560x1440_165.00
Hopefully this should fix your issue. I don't think that this fix always works but you can give it a try.

this only works for xwayland. For hyprland, you can put this modeline as your monitor res param (see https://wiki.hyprland.org/Configuring/Monitors/#custom-modelines )

cvt -r 2560 1440

cvt gives me # 2560x1440 164.90 Hz (CVT) hsync: 261.86 kHz; pclk: 938.50 MHz
Modeline "2560x1440_165.00"  938.50  2560 2792 3072 3584  1440 1443 1448 1588 -hsync +vsync
but adding "modeline 938.50  2560 2792 3072 3584  1440 1443 1448 1588 -hsync +vsync" to Hyprland doesn't work... @vaxerski

Similar issue. Modeline does not seem to work.


mxnet Parser has not supported operator upsampling

when I want to convert mnxet model(including upsampling with nearest) to tensorflow but I get this error.
mxnet Parser has not supported operator upsampling

I have the same problem

@rikichou I changed the source code of mxnet parser ignoring these operators not supported including upsampling, crop, reshape and SoftmaxActivation. Then I get .npy and .py and modify .py to add these layer by hand。

@liupengkd great !  and can you show me your .py ?

Hi @liupengkd, could you give an example of a modification you made for an operation in the mxnet parser ? I'm having some trouble doing the change myself.
By the way, the SotfmaxAxctivation in the symbol file can be changed to softmax (new mxnet operation name) for it to work.


feat: add automatically generated changelogs

Script is where it should, but action still needs work

Added pretty version generation if we dont have it for the title. Should look the same as build id


Allow customized controllers to be added to devise_for

Why?

Currently there is no way to add customized controller when using mount_devise_token_auth_for. See more at https://github.com/lynndylanhurley/devise_token_auth/blob/master/lib/devise_token_auth/rails/routes.rb#L10-L23. For eg: adding customized controller for https://github.com/scambra/devise_invitable#configuring-controllers-.

How?

Allow controller option when using mount_devise_token_auth_for. Eg:

  mount_devise_token_auth_for 'User', at: 'users', skip: [], controllers: {
      sessions:  'api/users/sessions',
      passwords:  'api/users/passwords',
      token_validations:  'api/users/token_validations',
      invitations: 'api/users/invitations'
    }

It seems that is breaking the specs for some reason, can you take a look? I don't know if it would be easier to add a new spec for it

Agree, let me check and add more specs for this @MaicolBen

@MaicolBen Updated with new specs and fix. Please check whether it's good to merge or not

Yes, but still some specs are failing

#1435 was merged and has these changes


Write manual test cases for "GroningenPage"

Please write a manual test case for the following pages manual test which involves breaking down the functionality of the webpage into specific steps that can be tested.
GroningenPage:
https://prayersconnect.com/mosques/search/Delfzijl%252C%2520Groningen%252C%2520Netherlands/53.33102719999999%2C6.924459799999999/53.33102719999999%2C6.924459799999999
Please use this Google doc for your test cases.
https://docs.google.com/spreadsheets/d/1O1NJRmobfNfk6cGgc5BWHCMhRSjF6vJK3C-AljYxgHo/edit?usp=sharing

Please let me know if this is done.


bandwidth="0" is invalid

@lelikg filed google/shaka-player#940, in which Shaka Player was unable to play a particular DASH stream generated by nginx-rtmp-module.  The root cause was a bandwidth attribute of 0 on the Representation element.
In https://github.com/google/shaka-player/issues/938#issuecomment-317278180 I detailed why 0 seems to be invalid.  Is there any way to ensure that nginx-rtmp-module always outputs a valid bandwidth value?  Or is this dependent on user input?
If detailed repro steps are needed to generate bandwidth="0" in DASH, @lelikg may be able to provide them.
Thanks!

As a temporary workaround it's possible to replace the problematic bandwidth=0, using the ngx-lua module
Here is a sample configuration
location ~* \.mpd {
    header_filter_by_lua_block {
        ngx.header.content_length = nil
    }
    body_filter_by_lua_block {
        ngx.arg[1] = ngx.re.gsub(ngx.arg[1], "bandwidth=\"0\"", "bandwidth=\"600000\"")
    }
}


Inherit documentation from abstract types

I don't think this is possible as of yet from what I've looked through so far, but it seems like a potentially useful feature to make it that little bit easier writing documentation.
For example in Java, you can use the following code to inherit documentation from that of the class' super:
/**
 * {@inheritDoc}
 */

I've seen special # :something:  syntax in those docstrings, but I haven't yet seen any documentation on some source, e.g. # :nodoc:  to have it not show up in the documentation.
We could have a similar # :inherit: syntax that would have this functionality.

#6989 will solve this in an even better way :grin:

This can prob be closed now that https://github.com/crystal-lang/crystal/pull/6989  is merged.

@Blacksmoke16 Good point.
We are missing document this new behavior in https://crystal-lang.org/reference/conventions/documenting_code.html . Someone wants to tackle that?


Aggregation Example is generating invalid end date

The end date should be 1 milli second less than midnight.

Can you explain this in more detail? Is it one of the examples built-in to Gaffer that is generating the invalid end date or a particular example you've found on your own data set?

One of the examples built-in to Gaffer.

Merged into develop.


Is there a XOR equivalent?

Hi there, not really an issue, more of a question.
I am trying to validate that the payload contains either property a or property b but not both.
How can I achieve that elegantly?
Note: the case where both are present can either be a success or a failure, I would be happy with either.
Thank you in advance, and thanks for creating such an amazing library!

The standard TS typing of this is:
type T = { a: string; } | { b: string; }

One way to achieve this type in Runtypes is:
const T = Union(Record({ a: String, }), Record({ b: String}));

There are other ways, each with their own advantages and disadvantages.

The standard TS typing of this is:

No, that's not correct because it allows const t: T = { a: 'foo', b: 'bar' };. The OP wants to allow only either, not both.
I thought it could be achieved by this:
Union(Record({ a: Unknown, b: Never }), Record({ a: Never, b: Unknown }))

But it doesn't work. I believe this is a bug (Never property is not working expectedly), and will be fixed soon.
Using Never like above will become a pain if you have a ton of properties. Once "exact match" (#41, #169) has been introduced, you would be able to simply unionize exact Records to do that.


Gigabyte Z97X-Gaming 3 hidden 4G Decoding

MOBO: Gigabyte Z97X-Gaming 3
BIOS: F8e (not available on GB page, i got it from Support. This bios add TPM 2.0)
CPU: Intel Xeon E3-1285L v4
GPU: RX 6900XT
CSM disabled, SecureBoot enabled, TPM 2.0 Enabled
Im curious to check if Re-Bar can work on my motherboard using this instruction:
https://github.com/xCuri0/ReBarUEFI/wiki/Enabling-hidden-4G-decoding
Im stuck on 4 step. I find 4G Decod using UEFITOOL, extracted body, next i used [IRFExtractor_0.3.6] to save output file.
Output file doesn't contain "4G Decod".
I attached original bios file and txt output.
Z97XGAMING3.zip
Section_Freeform_subtype_GUID_97E409E6-4CC1-11D9-81F6-000000000000_Setup_Setup_body IFR.txt

seems like the it is not included in the setup configuration in the bios... and only counted as a Bios String...

I checked older bioses. F8d and F7 do not include 4G Decod as a string. F6 have one mention, but still not included in txt output.

My Gigabyte B85M-D3H(rev.1.2) has the same issue.

Update: when I locate the offset in hex-editor which has been found in UEFITool, I can see a string "Above 4G Decoding. Enables or Disables 64bit capable Devices to be Decoded in Above 4G Address Space".
It looks like just a description string but not an configuration.

97E409E6-4CC1-11D9-81F6-000000000000_Setup_Setup_body.zip

I did the same thing. Added FFS module unlock ReBar <= 1GB without 4G Decoding.

Unfortunately, I have not been able to get ReBar to run above 1GB. Nevertheless I have a higher minimum FPS.

A guy on winraid has added options from strings into his settings
https://winraid.level1techs.com/t/add-option-in-ami-uefi-bios-menu-how-to/31609/15
Perhaps we can do the same for 4g decode?

@xCrui0 I'm on asus h81m-d rev1 and enabled 1GB rebar already. My 4g decoding strings are in the bios but when I extract the text file, it's not in there.
You said adding 4g decode in could be possible via asm editing but you weren't planning on doing it. Do you still want me to try the setup_var commands you mentioned?

@NoUserNameForYou don't really think anything more can be tried other than swapping pcihostbridge or maybe pcibus modules with a similar motherboard that supports 4g decoding.
patching is complicated because it would require addition of code which isn't easy

@xCuri0 I'm willing to experiment. I can come back with a ch341a.
Let's see, https://findhard.ru/en/motherboards/model?id=2026&m=asus-h81-gamer
Just tried this bios and it has 4g decoding in its .txt file after ifrextract.
How do we proceed after this. H81gamer looks a bit different when it comes to ram slots (4 vs my 2) and usb sockets but there shouldn't be that much difference.

@xCuri0 Well mate?

The Grub mod setup var method did not unlock 4G Decoding. I also discovered a strange bug with Unreal Engine games. When I have ReBar enabled for 1GB, games on UE can only allocate 1GB of VRAM, causing performance to drop dramatically. Games on otyher engine, e.g: Dying Light 2 gain performance and the game can allocate more than 6+GB VRAM.

@BartekJablonski I've seen others report similar issues on Polaris GPUs but didn't know it happened on RDNA too. Also 2GB does have this issue too just that it will happen at 2GB VRAM

It was a fun adventure to squeeze the last sweat out of that Broadwell. I am glad that I was able to participate in this :)

@BartekJablonski You mention 256mb causes the issue, but isn't that the default size no rebar ?

I'll straighten the whole thing out a bit
In ReBar 9 and 10 AMD Settings says that ReBar is supported and I can turn it off. Disabling it will allocate up to 256MB, although GPU-Z will not change the BAR0 and BAR1 values
ReBar State: 0 (disabled). AMD Settings: ReBar Unsupported. UE Games can allocate all memory.
ReBar State: 8 (256MB). AMD Settings: ReBar Unsupported. UE Games can allocate all memory.
ReBar State: 9 (512MB). AMD Settings: ReBar Supported. UE Games can allocate 512MB Only.
ReBar State: 10 (1024MB). AMD Settings: ReBar Supported. UE Games can allocate 1024MB Only.
Also check out the pics of what it looks like.
https://imgur.com/a/Zdr5n52

Source 2 games is also affected to this VRAM allocation bug.

Unity Engine game are also affected to this VRAM allocation bug, but i find out workaround for this. DXVK fixed it. Contraband Police (Unity Game) had this bug. I tried DXVK and now game is can utilize more than 1GB VRAM :p

Yeah, DXVK also fixed allocation bug in Sea of Thieves (UE4 game)

@BartekJablonski dxvk often reduces performance tho, we are enabling rebar to get more fps

I know that, but it depends on hardware. Obviously im cpu bottlenecked and take f.e Contraband Police.
Native DX11 65FPS -> DXVK 85FPS -> DXVK+ReBar 1GB 92FPS
Sea of Thieves Native VS DXVK+ReBar 1GB gave very similar results.
I wanted to share this finding

DSDT.aml.zip
Hi Everyone, need some help with DSDT.
I am getting errors after doing iasl DSDTMod.dsl,  initially it was just a Syntax error,  but after I the removed ARG0, now I am getting 1 error, but a bunch of warnings and remarks. I'm not sure If I did anything wrong or how about to fixing this. I've attached the files. If anyone can help me or guide me through this is appreciated.
Thanks!

试试 UEFITool 替换附件中 pcibus模块 我的主板用的是同样技嘉品牌Z97-HD3 2.1 可以打开1G 以上 Bar 这个模块是我从华擎Z97-EXTREME 中已启用 Bar 中提取 这似乎是技嘉主板PCIBUS模块的问题 地址是：https://winraid.level1techs.com/t/request-resizable-bar-added-to-asrock-z97-extreme-6-v2-80a/91036/2
PCIBUS.zip

@xYuuna go to the lines mentioned and remove Arg0, it says this at the bottom of the DSDT editing wiki page.

I'm too much of a brainlet to make any sense out of this but thank you for your discoveries.
BTW, sorry I had to delete my discord account.

@xCuri0 thanks for that write up, really appreciate you taking the time. Though this is way beyond my level, I don't even know where to begin. Hopefully someone tries this and figures out an easier way to patch/add this :)

MOBO: Gigabyte Z97X-UD5H-BK
BIOS: F8
CPU: Intel i5-4670K
GPU: Intel A380
Stock DSDT section:
                If ((Local1 >= 0x07D9))                 {                     If ((M64L == Zero))                     {                         CreateDWordField (BUF0, \_SB.PCI0._Y1E._LEN, MSLN)  // _LEN: Length                         MSLN = Zero                     }                     Else                     {                         CreateQWordField (BUF0, \_SB.PCI0._Y1E._LEN, M2LN)  // _LEN: Length                         CreateQWordField (BUF0, \_SB.PCI0._Y1E._MIN, M2MN)  // _MIN: Minimum Base Address                         CreateQWordField (BUF0, \_SB.PCI0._Y1E._MAX, M2MX)  // _MAX: Maximum Base Address                         M2LN = M64L /* External reference */                         M2MN = M64B /* External reference */                         M2MX = ((M2MN + M2LN) - One)                     }                 }
My attempt at bypassing:
`                If ((Local1 >= 0x07D9))
{
CreateQWordField (BUF0, _SB.PCI0._Y1E._LEN, M2LN)  // _LEN: Length
CreateQWordField (BUF0, _SB.PCI0._Y1E._MIN, M2MN)  // _MIN: Minimum Base Address
CreateQWordField (BUF0, _SB.PCI0._Y1E._MAX, M2MX)  // _MAX: Maximum Base Address
                    // 39-bit for Haswell and up
                    M2MX = 0x8000000000 - One
                    If ((TUUD >= 0x1000))
                    {
                        M2MN = (TUUD << 0x14)
                    }
                    Else
                    {
                        M2MN = 0x100000000
                    }
            }

`
I'm also unable to find the 4G Decode option with UEFITool. The stock DSDT seems to account for 4G Decoding, but when I bypass that M64L conditional I get the expanded root bus in the OS, but anything above 1G resizebar won't POST. I'm guessing that M64L bit needs to be actually toggled somehow, instead of bypassed in order for the PCIBus to work?

MOBO: GA-X99-Gaming 5
BIOS F23c
CPU: Intel i7-5930K
GPU: RTX 3070
Same issue, stuck on finding the '4G Decod in txt' step.
I appreciate the support and write-up above, @xCuri0, but it's a bit too impenetrably written for non-programmers. I'm unsure where to start :)
I've added my extracted text. Perhaps it could serve as an example of how to trace the '4g decod' flag?
Section_PE32_image_Setup_Setup_body.efi.0.0.en-US.ifr.txt

@jakeman2048 aren't you then missing M2LN = ((M2MX - M2MN) + One)
Also, after removing the stray Arg0, I still can't compile:
PS D:\Work> D:\Programs\iasl.exe -ve .\DSDT.dsl

Intel ACPI Component Architecture
ASL+ Optimizing Compiler/Disassembler version 20230628
Copyright (c) 2000 - 2023 Intel Corporation

./DSDT.dsl   9112:         Device (SDMA)
Error    6141 -   Missing dependency ^  (Device object requires a _HID or _ADR)

./DSDT.dsl   9161:         Device (I2C0)
Error    6141 -   Missing dependency ^  (Device object requires a _HID or _ADR)

./DSDT.dsl   9282:         Device (I2C1)
Error    6141 -   Missing dependency ^  (Device object requires a _HID or _ADR)

./DSDT.dsl   9400:         Device (SPI0)
Error    6141 -   Missing dependency ^  (Device object requires a _HID or _ADR)

./DSDT.dsl   9481:         Device (SPI1)
Error    6141 -   Missing dependency ^  (Device object requires a _HID or _ADR)

./DSDT.dsl   9574:         Device (UA00)
Error    6141 -   Missing dependency ^  (Device object requires a _HID or _ADR)

./DSDT.dsl   9655:         Device (UA01)
Error    6141 -   Missing dependency ^  (Device object requires a _HID or _ADR)

./DSDT.dsl   9748:         Device (SDHC)
Error    6141 -   Missing dependency ^  (Device object requires a _HID or _ADR)

ASL Input:     ./DSDT.dsl -  596415 bytes   7624 keywords      0 source lines

Compilation failed. 8 Errors, 134 Warnings, 169 Remarks
No AML files were generated due to compiler error(s)

Is it safe to force with -f? Or should I be doing something with these:
Scope (_SB.PCI0)
{
    Device (SDMA)
    {
    }
}

试试 UEFITool 替换附件中 pcibus模块 我的主板用的是同样技嘉品牌Z97-HD3 2.1 可以打开1G 以上 Bar 这个模块是我从华擎Z97-EXTREME 中已启用 Bar 中提取 这似乎是技嘉主板PCIBUS模块的问题 地址是：https://winraid.level1techs.com/t/request-resizable-bar-added-to-asrock-z97-extreme-6-v2-80a/91036/2 PCIBUS.zip

I've attempted to replace the pcibus module in the Z97-HD3 firmware; however, I'm still unable to set BARs larger than 1G. Could you provide a more detailed explanation on how to successfully implement this?

@ZLHuo there a bunch of other modules too not just pcibus
i think pcihostbridge and some sa related module.
i dont think it will be easy to implement tbh

@xCuri0
I understand, there's a lot of work to be done.
Achieving a BAR size of 1 GB is truly satisfying. Thank you for your exceptional project!

@ZLHuo there a bunch of other modules too not just pcibus
i think pcihostbridge and some sa related module.
i dont think it will be easy to implement tbh

Hi,
I have a GA-Z97N-Gaming 5 here that I would like to use. I can't quite get my head around the patching here yet.
Can you tell me roughly whether it works with my board? I was able to add the module to the bios, but I've already failed with the 4G.
I can't find anything with UEFITool. Will DSDT patching help me here?
I am not planning to use windows, only Linux.

if you're using linux you don't need to even flash rebardxe, there's a linux section on dsdt patching wiki just follow that

@xCuri0 Can you tell me about method directly manipulating PCH and PCI setup variables to enable 4G decoding?

@ivan49k someone tried and it doesn't work, the uefi has been built without the code for 4g decoding.

@xCuri0 I am able to reach till here by following the guide, I'm using the motherboard GA-H81M-DS2 rev 3.0, couldn't enable Above 4G decode through grub tho sadly.

I have the same mb and result as @Shranobxtha. However i found above 4g in grub but changing it seems do no effect in gpu-z report (tried both setupvar/setupvar3).
I also found somebody else with a same mb who successfuly enabling above 4g decoding, but i dont understand what he mean with replacing the pcibus and the PciHostBridge.
Can anybody help? i attached grub txt and my patched bios in case.
https://github.com/xCuri0/ReBarUEFI/issues/231
5.bin.1.0.en-US.ifr.txt
REBAR.zip


support

is there way i can pay u ? thanks for that amazing program

nope, funds taken care of. thanks!


Application does not terminate on dev. mode

When you run application with npm start and use alt + f4 to close, process is not terminated.
The problem is on 'close' event. I propose to add quit method.
createWindow() {
        let options = {
            width: 500,
            height: 600,
            icon: this.getTrayIcon(),
            frame: false,
            show: false,
            alwaysOnTop: this.settings.get('alwaysOnTop')
        };
        this.window = new electron.BrowserWindow(options);
        this.window.on('close', (e) => {
            e.preventDefault();
            this.window.hide();
            this.quit(); // terminate process
        });
        this.window.loadURL(this.getView('index'));
        this.window.on('ready-to-show', () => {
            this.window.show();
        });

        return this.window;
    }

Could you provide a pull request? Thx.


Add Option wrapper for React Select

For testing, we need to add a data attribute to each option in the
new enhanced select. This PR overrides the default Option component
with a wrapper (just a div with the qa attribute).

Coverage increased (+0.02%) to 26.41% when pulling 36798d146856f5fefca644c5986b678ca82e8dcc on Jskobos:rs-option-wrapper into 6d6e56fe8c97fbcdb44e249f09b6b2a438318b5c on linode:develop.


W-10945841: Update secure-configuration-properties.adoc

the AES key size must be of at least 32 characters (256 bytes).

should be

the AES key size must be of at least 32 characters (256 bits).

since 32 characters are 256 bits, not bytes. 32 characters are 32 bytes.

Hi @sg-cmusser
Thanks for the contribution! Before we can merge a PR from you, you need to sign the Salesforce.com Contributor License Agreement.

I am unable to "sign the Salesforce.com Contributor License Agreement" as its saying that I've already done so.

You already signed the CLA on 2021-11-23


ESSL #version 300 es

The preprocessor directive #version in ESSL 3.0 should have the 'es'.
Currently when targeting ESSL300, ESSL310 and ESSL320 the preprocessor is set to '#version 300'.
It should be '#version 300 es'.
Reference: “#version 300 es” must appear in the first line of a shader program written in GLSL ES version 3.00." Source

Thanks for the hint. I'll take care of this.

Fixed with 6cd87fb.


Support Question - Best practice for cross-platform paths

Support Question
If I'm on *nix, my paths use /; if I'm on Windows, my paths use \.  This isn't much of an issue, as I believe it mostly only affects aesthetics of printed paths.  What is the best practice for maintaining consistent path output cross-platform?
Possibly related--
If I'm on *nix, my PATHs use : delimeters; if I'm on Windows, my PATHs use ; delimiters.   Would a similar strategy apply?

You have a couple options. One is to just avoid dealing with paths directly, and always use Joi-Path and Split-Path as needed. I tend to do this a fair bit.
Another option is to use a variable separator, for example the slash for paths on the current system is exposed in [System.IO.Path]::DirectorySeparatorChar so you can just define a variable like ${/} = [IO.Path]::DirectorySeparatorChar and just use that variable to insert platform appropriate slashes.
With respect to PATH separators, a similar thing applies; you can pull the appropriate character frow [System.IO.Path]::PathSeparator
Also, where slashes are concerned you can often cheat a bit and just always use forward slashes in a lot of cases. Windows filesystems don't care which slash you want to use, but Unix only recognises forward slash, so you could opt to just always use forward slashes.

The simple answer is:

Always use forward slashes / -- Windows is more forgiving.
Always Convert-Path when passing paths to applications -- PowerShell's PSDrives result in paths that aren't real (e.g. the new Temp: drive in PS7)

Thanks all


Run button

How can I "activate" / select the Run button, so that I can just press enter and it will run.
Is there a shortcut or can I create it myself?
I Currently have a shortcut that opens up the script window, I rearly change the settings once I have them set up so I can do everything with just the keyboard and every time I need to run the script I have to use the mouse to click the RUN button, which gets so annoying when you do it 100 times a day.

@plikapisike This is now supported as of v2.6.0
Note that this requires a little manual intervention, so please see the instructions on how to do this.


Shape shrink form size before instantly return to it normal size during animation

Hi, currently i'm adding a feature that toggle display between two form using Shape. Everything went fine except during animation, the form that have bigger size shirnk down to the size of the other form: http://jsfiddle.net/n2mq51d6/2/
Is it a bug, or is there any config that can make the bigger form keep it size during animation.

Having revisited shapes recently, theres a few things.
It was one of the first components I wrote, now about 4 years ago, and the basic architecture could use some improvements. Generally shape behaves inconsistently with centered content, block level content, and inline block content.
That being said, I've included a new setting in next build which lets you specify the width and height of the component on animation to either, the next side's size, the parent size, or a specified width in pixels.


flaky benchmark test on AppVeyor

Looks like this test became flaky after implementing the new pacer (#2615):
Running Suite: Benchmark Suite
==============================
Random Seed:<PHONE_NUMBER> - Will randomize all specs
Will run 1 of 1 specs
+ Failure [30.197 seconds]
Benchmarks
C:/gopath/src/github.com/lucas-clemente/quic-go/benchmark/benchmark_test.go:20
  with version TLS dev version (WIP)
  C:/gopath/src/github.com/lucas-clemente/quic-go/benchmark/benchmark_test.go:24
    transferring a file [Measurement]
    C:/gopath/src/github.com/lucas-clemente/quic-go/benchmark/benchmark_test.go:34
    Unexpected error:
        <*qerr.QuicError | 0xc000f2ddd0>: {
            ErrorCode: 0,
            FrameType: 0,
            ErrorMessage: "No recent network activity",
            isTimeout: true,
            isApplicationError: false,
        }
        NO_ERROR: No recent network activity
    occurred
    C:/gopath/src/github.com/lucas-clemente/quic-go/benchmark/benchmark_test.go:59
    Full Stack Trace
    github.com/lucas-clemente/quic-go/benchmark.glob..func<IP_ADDRESS>(0xc051474fff, 0xc000084210, 0xc000082120, 0xc000082180, 0xc00008ba40)
    	C:/gopath/src/github.com/lucas-clemente/quic-go/benchmark/benchmark_test.go:59 +0x5bb
    created by github.com/lucas-clemente/quic-go/benchmark.glob..func2.1.2
    	C:/gopath/src/github.com/lucas-clemente/quic-go/benchmark/benchmark_test.go:39 +0x10d
------------------------------

I'm seeing signs of busy-looping in https://ci.appveyor.com/project/lucas-clemente/quic-go/builds/33773759.
It looks like TimeUntilSend is called in a loop, although no packets (?) are sent.