feat(init): add check task to run all static analysis

closes https://github.com/denoland/fresh/issues/784
The author of 784 has very kindly provided a repo to reproduce the issue. I agree, the error message when starting the project is horrible:
deno task start
Task start deno run -A --watch=static/,routes/ dev.ts
Check file:///Users/reed/code/temp/issue-fresh-dx/dev.ts
Watcher Process started.
The manifest has been generated for 3 routes and 1 islands.
error: Uncaught (in promise) SyntaxError: Unexpected reserved word at file:///Users/reed/code/temp/issue-fresh-dx/islands/Counter.tsx:12:5
  await import(entrypoint);
  ^
    at async dev (https://deno.land/x/fresh@1.2.0/src/dev/mod.ts:140:3)
    at async file:///Users/reed/code/temp/issue-fresh-dx/dev.ts:5:1
Watcher Process failed. Restarting on file change...

It does highlight the problematic file Counter.tsx, but the error shown isn't super clear. I don't understand why we're not type checking projects before. After I add the check command to the start task I get the following:
deno task start
Task start deno check main.ts && deno run -A --watch=static/,routes/ dev.ts
Check file:///Users/reed/code/temp/issue-fresh-dx/main.ts
error: TS7006 [ERROR]: Parameter 'p' implicitly has an 'any' type.
  const wrongFunction = (p) => {
                         ^
    at file:///Users/reed/code/temp/issue-fresh-dx/islands/Counter.tsx:11:26

TS1308 [ERROR]: 'await' expressions are only allowed within async functions and at the top levels of modules.
    await p();
    ~~~~~
    at file:///Users/reed/code/temp/issue-fresh-dx/islands/Counter.tsx:12:5

TS1356 [ERROR]:     Did you mean to mark this function as 'async'?
      const wrongFunction = (p) => {
                            ~~~~~~~~
        at file:///Users/reed/code/temp/issue-fresh-dx/islands/Counter.tsx:11:25

Found 2 errors.

This makes it abundantly clear what's wrong with the project. If someone doesn't want to type check their project, it should be decently clear about how to remove the deno check main.ts &&  part from the task. But the other way -- figuring out how to add this isn't so obvious. (I only got it working after a few attempts, e.g. deno check dev.ts doesn't catch the error. How checking main.ts checks the other files in the project is still a mystery to me. As another hurdle to figuring out how to do this on your own<EMAIL_ADDRESS>doesn't mention check, so this is difficult to find.)

On the other hand this will make startup slow, deno disabled typechecking by default everywhere for this reason
Also is there a reason to not just use deno run --check .. dev.ts , I'm not 100 % sure but in my usage I think it feels like it typechecks more stuff then just deno check file
Maybe at  least we should have start:fast or something that doesn't type check

Also I remember the argument for disabling type-checking by default was that the editor should have the checks via the lsp already and the uesr shouldn't need to pay the costly startup time for the same redundant diagnostics. I guess the mentality is the user should fix errors before running the file

Agree that the error message thrown by V8 is confusing and not as user friendly as it should be. I'm a little worried about introducing a type-check step when launching the server as it slows down the startup sequence very noticeably. For smaller projects that is likely not much of a concern, but with bigger ones you tend to end up in situations where type checking takes more than 30s.
I feel like another alternative is custom linting rules. I've added one that catches when an await keyword is used in a non-async function here https://github.com/denoland/deno_lint/pull/1176 . That way users get immediate feedback in their editors and it won't affect the startup time.

Why not use deno run --check ....? Because this is a photo of me:

So two things:

great point on this possibly being slow for large projects
thanks for showing me the --check flag for run. I suppose I should go through the commands listed from doing deno --help and then the subcommands as well, just to see the full spectrum of things out there.

The point about "the user should fix errors before running the file" is, I think, easily countered with "have you ever met humans before?" 😂  But more seriously:

they might make a change that causes an error in another file and not be aware of it
knowledge of best practices is, by definition, tribal knowledge. Newcomers will not have this knowledge until they've cut themselves enough (like I've done here).

In general I'm in favor of providing a safe space that gives friendly error messages. Do we agree with that? If so, is there some way that we could enable this by default and let people opt out if necessary? Given that this is a change to the init script, I don't think it will impact existing projects. And if an experienced user is creating a new project and doesn't want to type check in dev mode, they can easily delete the relevant part from the start command. But it's not so easy to come across this idea (type checking before starting) as a newbie.
Of course it's perfectly ok to just close this as well -- it is just a request after all.

I've reworked this to introduce a safe command. check seems like the better choice, but I don't want to cause confusion with the built in deno check command.
Fun fact: if you do this in a newly created project, it doesn't pass. When we build the _404.tsx file, there's an empty line at the top, so deno fmt --check complains. PR incoming.

I like check as the task name more than safe. With safe I'm not sure what it means and it seems less descriptive to me.

i like check better as well, but if you think it won't be confusing, then great. now people can just deno task check in their projects 🙌

I realized we also need to check .tsx files as well 🤦 . And it seems useful enough to have in the fresh source itself, no?

Shall we align this with #1538, using deno task check:types?

I don' think so. I find myself doing all of these things, and I wanted a shortcut. I could imagine other people do the same as well, and also want a shortcut. So "check:types" isn't descriptive of linting and formatting and type checking. And if you're suggesting removing linting/formatting, then I'm also not in favor of that 😅 , since I want all at once.

error: TS2614 [ERROR]: Module<EMAIL_ADDRESS>has no exported member 'Page'. Did you mean to use 'import Page from<EMAIL_ADDRESS>instead?
Page,

Another strange CI failure, which didn't happen on any of the other variants in this run...


Expose formatting option for TwiML extension methods

TwiML.ToString accepts an optional parameter SaveOptions formattingOptions = SaveOptions.None.
I think we should expose the same or a similar option to the TwiML extension methods in this library.
I'm leaning towards using our own enum so user's don't have to import the System.Xml.Linq namespace.

Fixed #95


Release request

In our project we need the new SpaceAfterComma style option which currently resides in master. We hereby request if a new version can be released!

0.42.0 has been released.

Cool, thanks!


add prop_rng_map<T>(Fn(r: Rng, T) method

This relates to #13, and could probably be a way to just solve it outright.
The idea is that you would do:
impl_strategy
    .prop_rng_map(|rng, value| {
        // compose new value using the rng
    }

As far as I can tell, there is no way to get the Rng object in a mapped body. This is certainly a power feature, but in some case (like sampling) there is no reason why a simple Rng object is not sufficient -- no shrinking, etc could be gained anyway.
Obviously this could be misused to effectively make shrinking impossible and complicate a Strategy chain, so this feature may not be desired. However, I think it would help provide at least a workaround for any issue that a developer wants to address, even if the solution isn't 100% in compliance with this library.

So I actually added this in 0.3.2 as prop_perturb(). While the original need here has been addressed via #13, I do think it provides a useful "escape hatch" in the future as less powerful versions of those two could be implemented on top of it, for example.
It also turns out that this doesn't break shrinking as long as the user function gets the same Rng each time, which the new combinator ensures.

Awesome, prop_perturb is exactly what I wanted!
In fact, I've come to realize that my needs are far more complicated than simple sampling, so this is what I need anyway. I've been using thread_rng waiting for these features, but now I can refactor and make it deterministically random (and probably faster). Yay!


SQLServerConnection infinite loop

Driver version
12.4.2
SQL Server version
Microsoft SQL Server 2022 (RTM-CU15-GDR) (KB5046059) - 16.0.4150.1 (X64)  	Sep 25 2024 17:34:41
Client Operating System
Ubuntu 20.04.06 LTS
JAVA/JVM version
java version "21.0.2" 2024-01-16 LTS
Table schema
Not needed
Problem description
We have a server that provides the client listeners for a. large number of messaging queue, which means it runs hundreds of threads draining 100+ queues.  The thread uses the message to preform a series database inserts/updates.
The problem is that randomly, as the message processing completes so statements and connections are being closed/committed), a thread will get stuck in SQLServrConnection.endRquestInternal(), specifically on the loop in
sqlWarnings = originalSqlWarnings;
if (null != openStatements) {
while (!openStatements.isEmpty()) {
try (Statement st = openStatements.get(0)) {}
}
openStatements.clear();
}
Naively, shouldn't this loop not be an infinite loop, but have some form of timeout?  Out of hundreds of threads running 24/7, its not unusual for us to lose 5-10 threads every couple of week to being stuck on this loop.
Expected behavior
The code should not get stuck in an infinite loop.
Actual behavior
The thread hangs in an infinite loop.
Error message/stack trace
A sample stack trace is below - note the cpu time.
"AccountListener-1" #305 [2606778] prio=5 os_prio=0 cpu=146605778.46ms elapsed=298559.22s tid=0x00007fdcb427d360 nid=2606778 runnable  [0x0000
7fdc9dfdd000]
java.lang.Thread.State: RUNNABLE
at com.microsoft.sqlserver.jdbc.SQLServerConnection.endRequestInternal(SQLServerConnection.java:7367)
at com.microsoft.sqlserver.jdbc.SQLServerConnection43.endRequest(SQLServerConnection43.java:35)
at com.mchange.v2.c3p0.impl.C3P0PooledConnectionPool$2.attemptNotifyEndRequest(C3P0PooledConnectionPool.java:182)
at com.mchange.v2.c3p0.impl.C3P0PooledConnectionPool.markEndRequest(C3P0PooledConnectionPool.java:360)
Any other details that can be helpful
JDBC trace logs

This looks like a deadlock. in endRequestInternal() the try-with-resources block calls close() which calls removeOpenStatement(). removeOpenStatement is waiting on the lock, which was acquired earlier by endRequestInternal().
Thanks for the report. Will look into fixing.

@haasc do you have a standalone java app that would reproduce this issue to help us look into this issue?

I've had the preview release running under load for 4 days - so far so good.

Thanks @haasc for letting us know.


setup-android と setup-msbuild のバージョンをあげる

Node.js 16 の Deprecated に伴い setup-android と setup-msbuild のバージョンをアップデート
setup-android のバージョンアップに合わせて ANDROID_SDK_CMDLINE_TOOLS_VERSION をアップデート

This pull request primarily updates various tools and versions used in the project's GitHub Actions workflow, as detailed in .github/workflows/build.yml. It also includes updates to the CHANGES.md and VERSION files to reflect these changes.
Key updates:
GitHub Actions Workflow:

.github/workflows/build.yml: The version of microsoft/setup-msbuild used in the workflow has been updated from v1.3 to v2.
.github/workflows/build.yml: The android-actions/setup-android action has been updated to v3. In addition, the Setup JDK 17 step has been added to the workflow for cases when the matrix name is 'android'.

Version Updates:

VERSION: The ANDROID_SDK_CMDLINE_TOOLS_VERSION has been updated from 8092744 to 9862592.

Documentation:

CHANGES.md: The changes made to the setup of android-actions/setup-android, microsoft/setup-msbuild, and the addition of Setup JDK 17 have been documented.

レビューありがとうございました。こちらマージします


Background Button Color not visible on Android

I was trying to find other issues related to this, and I can't seem to find one. I made sure that the ActionButton buttonColor was an rgba only value.
We have several throughout the app, but here is one example of code that I have. Again this is working perfectly on iOS, just not for Android. I have also made sure that any debugging is off, cause I saw that could cause some issues. Any suggestions or help would be appreciated!
<ActionButton
              buttonColor={this.convertHexToRgba(this.props.visibleOptions.buttonColor)}
              position="right"
              hideShadow={true}
              onPress={() => this.addToCart()}
              icon={<Icon name="shopping-cart" style={styles.actionButtonIcon} />} />

And I'm running a convertHexToRgba function which is returning what is expected:
  convertHexToRgba(hex) {
    var c;
    if(/^#([A-Fa-f0-9]{3}){1,2}$/.test(hex)){
        c= hex.substring(1).split('');
        if(c.length== 3){
            c= [c[0], c[0], c[1], c[1], c[2], c[2]];
        }
        c= '0x'+c.join('');
        console.log("COLOR HIT: ", 'rgba('+[(c>>16)&255, (c>>8)&255, c&255].join(',')+',1)');
        return 'rgba('+[(c>>16)&255, (c>>8)&255, c&255].join(',')+',1)';
    }
    throw new Error('Bad Hex');
  }

I'm console logging it out just to check ... but yeah, works great on iOS ... just not android.

This is weird. Do you see a background color when putting the output of your converter function directly to buttonColor?

One sec ... let me double check that real quick, thanks for the quick response, @mastermoo !

okay, @mastermoo ...
I put in this just to see if it would work:
<ActionButton
              buttonColor="rgba(0,179,227,1)"
              position="right"
              hideShadow={true}
              onPress={() => this.addToCart()}
              icon={<Icon name="shopping-cart" style={styles.actionButtonIcon} />} />

And still getting the same result on Android. :/
I don't know if this is important information right now, but here are my package versions:
"react-native": "0.34.1",
"react-native-action-button": "2.6.0",

i'll try your code, one moment

@mastermoo awesome, thanks. looking forward to the result.

I tried your code on android, and i can see a light blue background color. what happens, when you remove the icon prop? maybe the background color of your icon overlaps the background color.

okay ... i'll try that out.

okay @mastermoo ... now it's just a white "+" symbol:

I'm trying to remember correctly though some of our from former builds ... but I feel like this wasn't an issue prior, and our latest build yesterday somehow reverted to this. So, do you know by chance other outside variables that could potentially mess with this package?

that's some weird stuff..

maybe it's because of the RN version
maybe upgrading this package to v2.6.4 helps
maybe using hex value instead of rgba value helps (which also means, you don't need to use your converter function)
maybe you are just trolling lol

other than that, i'm clueless.. but it doesn't look like a bug in this package

hahaha, I wish this was a time where I would be trolling.
You can go ahead and probably close this issue, I might update it later if I find out what external thing is causing this issue if it will help someone in the future, but you are probably right ... it might not have anything to do with this package. Hope this won't be too tricky to debug. Thanks for your help though! @mastermoo

roger that. good luck!


Performance improvement of basic search

Summary Change Description
Added a prefetch_related after the filter of the search term.
Affected Issue Numbers
none
Code Review Notes
The run time of the search is less than halved.  Initial testing was done without serum data and resulted in a load of around 12 seconds.  With serum data, it takes anywhere from 27 to 55 seconds (not sure what the factor is which determines the variability).
Searching all other models is reasonably fast.
The remaining bottleneck seems to be the cached_property fields.
Checklist

[x] All issue requirements satisfied (or no linked issues)
[x] Linting passes.
[x] Migrations created & committed (or no model changes)
[ ] Tests implemented (or no code changes)
[x] All tests pass

Awesome! Much faster! I would suggest that we create an issue to write some tests for the search_basic function as well as the peakgroups_results.html template, but this looks ready for prime time to me.

Out of curiosity, how quickly did the results load for you from the 1 study record link?

Only 2 lines of code were changed.  Merging.


Fix variant of spline() that didn't compute derivatives properly.

Specifically, the case where the knots are colors (without derivs), the
abscissa float with derivs.
(And add a regression test.)

LGTM


Publishing initial release requirements

@jwerre @HappyZombies is there anything else we might need to publish this package?

@jankapunkt i think I invited you though NPM is not really telling me ...

@HappyZombies got the invitation, thanks I will publish within the next hour


WebUI: Cannot configure Amazon Sagemaker API

Describe the bug
Cannot update API Url and API Token after installing Stable Diffusion WebUI on EC2(Ubuntu 20.04.1)

I just installed stable diffusion webui on EC2 by this doc Option 2, and configured a nginx as proxy in front of the webui process
location / {
                proxy_pass http://<IP_ADDRESS>:7860;
                #try_files $uri $uri/ =404;
        }

When I access webui from my browser, I got error at the API Url & API Token tab, therefore I cannot configure my API for the extension.
Expected Behavior
Be able to configure API for the extension
Current Behavior

Cannot Configure API for the extension.
Reproduction Steps

Install the stable-diffusion-webui and extension with option2 from  this doc
Install nginx and configured as a proxy

location / {
                proxy_pass http://<IP_ADDRESS>:7860;
                #try_files $uri $uri/ =404;
        }

Access the nginx

Possible Solution
No response
Additional Information/Context
No response
Solution Version
not related
AWS Region. e.g., us-east-1
No response
Other information
No response

will you able to connect to the http://${MyEIP.PublicIp}:7860 directly instead of proxy?

@Shellmode Have you solved the problem?


Initial updates

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


hack: add verification of go deps in gh action

update Make file to add new targets to verify go deps and add it in the github action

/hold

LGTM

/unhold


Form validation

In this pull request, we initialize a client-side validation of the data in the contact form before submission.
we implemented the following:

The content of the email field has to be lowercase.
When the user submits the form, you check if the email is in lower case.
If the validation is OK, the form is sent.
If the validation is not OK, you show an error message to the user near the submit button informing them of the error, and the form is not sent.

KINDLY WAIT FOR 15 MINUTES BEFORE STARTING WORK THE BUTTON WAS PRESSED UNEXPECTEDLY. IT WOULD BE RESOLVED SOON. THANK YOU


Detached mode for T5-3C-120

Hi !
Is it possible to add the detached mode to this switch just like it was added to the MINIR4 in  #1227  ?
My diagnostics:
sonoff-db5723099e49a2abe6f50339abe52a05-Switch Oficina-591f8396ae306f4549d8b8d8341c8978.json.txt

I can't see something similar in your diagnostics. Do you have this options in ewelink mobile app?


Selenide creates an unneeded downloads folder before launching app

Sample log:
[main] INFO com.codeborne.selenide.impl.FileHelper - Creating folder: /home/xp/work/app-android/uitests/build/downloads/1598528219400_32685_1

This folder is not needed.
It's not critical, because Selenide deletes this folder in the end of tests. But still, could skip it.

it there any treatment for it?

Not yet: it's a very, very low priority :)
But you are welcome to submit a pull request. :)

wish i could help... you are a way better programmer than I am @asolntsev


Create Email Notifications

Notes
Add ability to create Email Notifications.

@muhallan @arthuroe - I have created our develop branch so I can merge in your working branches and test with all dependencies.

Let me work on resolving these errors. In regards to post requests, I have been getting 400 or 500. I think it maybe an issue with the data am parsing. Is there a specific format for data sent?

@nateklaiber develop is updated with the fixes for the errors above?

@arthuroe  - might have another circular reference issue. The latest with develop gives me: ImportError: cannot import name 'EmailNotification' from 'naas.models.email_notification
and naas/models/email_notification.py has from naas.models.email_notifications import EmailNotifications, and naas/models/email_notifications.py has from naas.models.email_notification import EmailNotification


hubble: Repeated crashes on 1.10.6

What is the bug?
We're seeing repeated crashes on hubble due to alchemy RPC timing out
hubble-hubble-1  | {"message":"{\"level\":50,\"time\":1709495350524,\"pid\":41,\"hostname\":\"fa79cc04c428\",\"reason\":\"Unhandled Rejection\",\"err\":{\"type\":\"TimeoutError\",\"message\":\"The request took too long to respond.\\n\\nURL: https://opt-mainnet.g.alchemy.com/v2/xxxxxxxxxxxxxxxxxxxxxxx\\nRequest body: {\\\"method\\\":\\\"eth_uninstallFilter\\\",\\\"params\\\":[\\\"0xda34257861b4d8172d4331eb9e36bc3b\\\"]}\\n\\nDetails: The request timed out.\\nVersion: viem@1.12.2\",\"stack\":\"TimeoutError: The request took too long to respond.\\n\\nURL: https://opt-mainnet.g.alchemy.com/v2/xxxxxxxxxxxxx\\nRequest body: {\\\"method\\\":\\\"eth_uninstallFilter\\\",\\\"params\\\":[\\\"0xda34257861b4d8172d4331eb9e36bc3b\\\"]}\\n\\nDetails: The request timed out.\\nVersion<EMAIL_ADDRESS>  at Object.http (file:///home/node/app/node_modules/viem/utils/rpc.ts:102:24)\\n    at fn (file:///home/node/app/node_modules/viem/clients/transports/http.ts:95:28)\\n    at request (file:///home/node/app/node_modules/viem/clients/transports/http.ts:97:45)\\n    at withRetry.delay.count.count (file:///home/node/app/node_modules/viem/utils/buildRequest.ts:69:24)\\n    at attemptRetry (file:///home/node/app/node_modules/viem/utils/promise/withRetry.ts:34:28)\\n    at retry (file:///home/node/app/node_modules/viem/utils/promise/withRetry.ts:30:9)\",\"details\":\"The request timed out.\",\"metaMessages\":[\"URL: https://opt-mainnet.g.alchemy.com/v2/xxxxxxxxxxxxxxxxxxxxxxx\",\"Request body: {\\\"method\\\":\\\"eth_uninstallFilter\\\",\\\"params\\\":[\\\"0xda34257861b4d8172d4331eb9e36bc3b\\\"]}\"],\"shortMessage\":\"The request took too long to respond.\",\"name\":\"TimeoutError\",\"version\":\"viem@1.12.2\"},\"msg\":\"shutting down hub\"}\n","timestamp":"2024-03-03T19:49:10.524Z","type":"out","process_id":0,"app_name":"hubble"}

We've addressed this in 1.10.9. Thanks for the report!


[nrf fromlist]zephyr/serial_recovery: fix serial device binding

zephyr changes the way in which it provide name of
serial device used by serial recover.
see: zephyrproject-rtos/zephyr#18752
This path introduce build time configuration of device name
which is set to exact the same device which was set before.
Signed-off-by: Andrzej Puzdrowski<EMAIL_ADDRESS>

cc @andvib

Re-tested locally, this PR fixes the compilation issue


fix: fix broken SWA flow

The type of this PR is: Fix

This PR solves CX-2779
Description

Added separate route for submissions from my collection

Warnings

:warning:

Routes added to routes.tsx should have a corresponding cypress.js smoke test. See the cypress/e2e folder for examples.

  Generated by :no_entry_sign: dangerJS against 21664e884d2670d369e8cd32962125d28a5f3b91


Copy Button

have a copy button, that copies the url once the encryption has occurred. or auto copy, on encryption.

I will implement this suggestion on the dev branch, and it will be merged to main once the next update is released.


feat: nuxt-i18n-micro module integration

🔗 Linked issue
https://github.com/s00d/nuxt-i18n-micro/issues/11

❓ Type of change

[ ] 📖 Documentation (updates to the documentation or readme)
[ ] 🐞 Bug fix (a non-breaking change that fixes an issue)
[ ] 👌 Enhancement (improving an existing functionality)
[x] ✨ New feature (a non-breaking change that adds functionality)
[ ] 🧹 Chore (updates to the build process or auxiliary tools and libraries)
[ ] ⚠ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

As the i18n config has an identical signature we can support the https://github.com/s00d/nuxt-i18n-micro module out of the box without any extra effort :crossed_fingers:

@harlan-zw is a similar change required here?
https://github.com/harlan-zw/nuxt-seo/blob/bc1dc0b4263adcf90d8df372c4b4eb21a937ba6e/src/module.ts#L143C5-L146C6

Thanks for the review @genu, I'm only considering sitemap integration with this module at the moment.

I see, but wouldn't it cause issue when using the main seo module?
For instance, it will polyfill the i18n composable when it should not, since its provided by nuxt-i18n-micro.
Nuxt throws errors about duplicate composables when using together.

Hmm good point but it's a warning that is thrown so not a big deal, the pollyfills should be registered with low priority though.
Having to support nuxt-i18n-micro in all SEO modules is not something I have capacity for at the moment so if this is a blocker then we may consider closing this PR.

Hmm, I can test a little bit more on my end, as I noticed the polyfill is indeed used instead of the i18n-micro composable.
Maybe the order in the modules array affects this? 🤔


help: LocalBusiness with multiple locations

📚 What are you trying to do?
I could just be missing it, but I don't see the "department" attribute on Organization / LocalBusiness. From what I can tell, when you have a business with multiple locations, the best practice is to put each one in a "department" array on Organization - is this something the library supports?
🔍 What have you tried?
No response
ℹ Additional context
No response

Scratch this. It may not be in the typescript defs, but just adding "department" and a list of "defineLocalBusiness" seems to work. Thanks for the library!

Hi @shurth, thanks for the issue.
Let me just clarify, Nuxt Schema.org only provides types for keys which Google recommends as part of their Structured Data docs. This is to improve type performance otherwise it would be very slow.
You can provide any value on top of this.


NameError: name 'brush' is not defined in last cell of 12-Measles.ipynb

Fixed in https://github.com/altair-viz/altair_notebooks/commit/ca609bbb662265008920f3458e3042366edb3972, thanks


Doc update

this PR contains the demo version update commit, will push after that one is pushed.

This change is

 You have another PR https://github.com/tensorflow/tfjs-converter/pull/140 that does the demo version update. Keep this PR to be only related to the docs.

Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


Add JsEnergyManager status output

Obtaining running status information on the Energy Manager has been impossible before. This change adds a status flag to the JsEnergyManager module which gets published both to the 'external' mqtt topic (for legacy reasons; will be removed in future) and the module-specific 'energy_manager:JsEnergyManager' topic.
changes:

add wrapper functions for enabling/disabling JsEnergyManager 'running' var to publish the var's state via mqtt
add 'emgr_running' var to manifest

DCO did not work again. Branch history is getting too dirty to proceed, abandoning branch and trying again.


fix(opensearch): handle non existing SAMLOptions in domain

Description
Handle non existing SAMLOptions in OpenSearch Domain.
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Could you please add get() for all the calls in the function? Thanks!

At which calls do you refer? Remember that we have to do this one by one because since we have to make sure to handle each specific case correctly.

I meant for all the calls within that function but it's good for now.


ValueError: Passed db_path does not exist! when trying to perform only face analysis on video

from deepface import DeepFace
DeepFace.stream(source="test/dataset/videoplayback.mp4", enable_face_analysis=True)

Is it possible or I have to manually extract a clear frame from the video to perform analysis on top of images?

the problem you are not setting any db path
DeepFace.stream(db_path="some_path", source="test/dataset/videoplayback.mp4", enable_face_analysis=True)

Hi, with "some_path" to db_path, I get an error still
How can I fix this?
Traceback (most recent call last):
  File "E:\github\deepface\stream_demo.py", line 13, in <module>
    DeepFace.stream(db_path="empty/", model_name="VGG-Face", detector_backend="retinaface", source="D:/Videos/vis_results/dialogue_1min.mp4", enable_face_analysis=True)
  File "E:\github\deepface\deepface\DeepFace.py", line 738, in stream
    realtime.analysis(
  File "E:\github\deepface\deepface\commons\realtime.py", line 50, in analysis
    DeepFace.find(
  File "E:\github\deepface\deepface\DeepFace.py", line 469, in find
    raise ValueError(
ValueError: ('There is no image in ', 'empty/', ' folder! Validate .jpg or .png files exist in this path.')

I tried to set the db_path to a directory that has images (images/),
Although the code worked without an error, where can I check the video results?
Thank you for sharing your nice codebase


BUG: Custom Sort always called with a {type="Dir", path="foo"} argument

Did you check docs and existing issues?

[X] I have read all the docs.
[X] I have searched the existing issues.
[X] I have searched the existing discussions.

Neovim Version (nvim -v)
NVIM v0.10.0-dev-e59cf3b3a
Operating System / Version
Ubuntu Mate 22.04
Describe the Bug
When using a custom sorting function, it is always called at least once with an object that doesn't actually exist. The object looks like
local fooObj = {
  type = "Dir",
  path = "foo"
}

This is a problem because one needs to filter out this object from their search, because sorting by another field like name causes a lua error to occur, because the erroneous foo object doesn't have such other fields that one might want to sort by.
Screenshots, Traceback
No response
Steps to Reproduce

Use this sort function

-- Sort function for files
local sortFunc = function(a, b)
    -- keys of a and b
    -- not documented anywhere
    --   parent_path:           full, absolute path of parent directory
    --   type:                  "directory" (even for links), or "file"
    --   path:                  full, absolute path, no trailing slash
    --   name:                  file name
    --   is_link                bool is a symlink
    --   is_reveal_target       bool ??
    --   link_to                full, absolute path to link target
    --   loaded                 bool if file is loaded in editor
    --   id                     seems to be same as path
    --   children               type of a/b table, directories only
    --   exts                   file extension  ??, files only
    --   ext                    file extension  ??, filey only
    --   name_lcase             name, but lowercase, files only?

    if a.name == nil then
        local s = ""
        if a ~= nil and type(a) == 'table' then
            for k, v in pairs(a) do
                s = s .. '[' .. k .. '] = ' .. tostring(v) .. ' , '
            end
        else
            s = s .. tostring(a)
        end
        print(s)
        return false
    end

    if b.name == nil then
        local s = ""
        if b ~= nil and type(b) == 'table' then
            for k, v in pairs(b) do
                s = s .. '[' .. k .. '] = ' .. tostring(v) .. ' , '
            end
        else
            s = s .. tostring(b)
        end
        print(s)
        return true
    end

    if a.type == "directory" and b.type ~= "directory" then
         -- directories first
        return true
    end
    if b.type == "directory" and a.type ~= "directory" then
        -- directories first
        return false
    end

    if a.name:sub(1, 1) == '.' and b.name:sub(1, 1) ~= '.' then
        -- dotfiles last
        return false
    end
    if b.name:sub(1, 1) == '.' and a.name:sub(1, 1) ~= '.' then
        -- dotfiles last
        return true
    end
    -- otherwise just sort by name, case insensitive
    return a.name:upper() < b.name:upper()
end

Open :Neotree
Observe output from print

Expected Behavior
Every item has a field "name"
Documentation on what the sort function's arguments are is available in :h neo-tree
Your Configuration
-

That is a test function that is used to confirm your custom sort function is valid before it is used. Your sort function should not assume that any particular field exists, and must always return a boolean value no matter what was passed in.

Then that test function should at least have all the same fields that are guaranteed to be present in all other items, and it should be documented, as should be the fields and what they mean.

Then that test function should at least have all the same fields that are guaranteed to be present in all other items,

There is no such guarantee. I think that in practice type and id are required, but everything else is source specific. A sort function should not assume that any particular field exists.
If you want to submit a PR that to enhance that documentation, I'll happily accept it. For the most part however, the fields are internal implementation details that could change at any time. type and path are the two that you are expected to use for this custom sort function.
I should also point out that the custom sort function is mostly legacy at this point, as there are now built in sort mappings for most fields.
o  = order_by...     Show help menu for order by choices.

oc = ...created:     Sort the tree by created date.

od = ...diagnostics: Sort by diagnostic severity.

og = ...git_status:  Sort by git status.

om = ...modified:    Sort by last modified date.

on = ...name:        Sort by name (default sort).

os = ...size:        Sort by size.

ot = ...type:        Sort by type.

I want to sort directories before files and dotfiles at the end of directories/files respectively. currently such a sort is only possible with that custom sort.


Fill out remaining Security Guidelines doc items

Filling out a few remaining sections, such as adding a few diagrams, adding some basic examples, and referencing U-SPS integration example.

Completed the documentation on 01-Mar-2022 (https://github.com/unity-sds/unity-cs/wiki/Unity-Security-Guidelines). Also, added some code samples and relevant documents in the following locations.

https://github.com/unity-sds/unity-cs-security/tree/main/code-samples/hysds_ui_auth
https://github.com/unity-sds/unity-cs-security/tree/main/code-samples/hysds_mozart_mock
https://github.com/unity-sds/unity-cs-security/tree/main/code-samples/hysds_mozart_mock_consumer


[testing] Implement cli tool to generate llvm IR for kernels without running them

We want something like dpexcli compile -m <python module path> -n <kernel function name> -o <llvm output path> to generate llvm code of function without running it.
TODO:

think about passing arguments type

@ZzEeKkAa take a look at https://github.com/IntelPython/numba-dpex/blob/8fc7fbddb2b73d80b98a0e629fddb6647aa456f8/numba_dpex/tests/experimental/codegen/test_intenum_literal_codegen.py#L15.
It is possible to only compile a kernel provided we generate the right signature. Perhaps a solution can be to have a CLI tool that takes a config file to spell out the signature and any extra compile flags.


Error: couldn't retrieve IP address of domain

Hi,
I'm using default NAT sample config and receive such error during setup
╷
│ Error: couldn't retrieve IP address of domain id: 02bcae0c-2ceb-4658-aa88-36746361bd65. Please check following:
│ 1) is the domain running proplerly?
│ 2) has the network interface an IP address?
│ 3) Networking issues on your libvirt setup?
│  4) is DHCP enabled on this Domain's network?
│ 5) if you use bridge network, the domain should have the pkg qemu-agent installed
│ IMPORTANT: This error is not a terraform libvirt-provider error, but an error caused by your KVM/libvirt infrastructure configuration/setup
│  timeout while waiting for state to become 'all-addresses-obtained' (last state: 'waiting-addresses', timeout: 5m0s)
│
│   with module.host_localhost.module.master_module["1"].libvirt_domain.vm_domain,
│   on modules/vm/vm.tf line 72, in resource "libvirt_domain" "vm_domain":
│   72: resource "libvirt_domain" "vm_domain" {
│
╵
┌
│ Error: terraform apply failed: exit status 1
But host is accessible via IP:
root@###:~/kubitect# ping <IP_ADDRESS>
PING <IP_ADDRESS> (<IP_ADDRESS>) 56(84) bytes of data.
64 bytes from <IP_ADDRESS>: icmp_seq=1 ttl=64 time=0.301 ms
I have Debian 12

Hi @MarkYSA,
that is really odd. I was not able to reproduce the issue, but ran into the similar issue with CentOS Stream 9. Could you please provide the Kubitect config file?

@MusicDin Thank you for you reply!
Sure, here is it:
hosts:

name: localhost
connection:
type: local

cluster:
name: k8s-cluster
network:
mode: nat
cidr: <IP_ADDRESS>/24
dhcp:
enabled: false
nodeTemplate:
user: k8s
updateOnBoot: false
ssh:
addToKnownHosts: true
os:
distro: ubuntu22
nodes:
master:
default:
ram: 6
cpu: 4
mainDiskSize: 20
instances:
- id: 1
ip: <IP_ADDRESS>
kubernetes:
version: v1.26.6
networkPlugin: calico

Hi @MarkYSA, thanks for providing the configuration file.
I can confirm that when static IP addresses are set in NAT mode, it causes libvirt not to register them, which produces the above issue.

Hi @MarkYSA,
This has been fixed in [v3.2.1](https://github.com/MusicDin/kubitect/releases/tag/v3.2.1). Let me know if you encounter any other issue.


New navigation system

Our sample uses Jetpack Navigation. It brought some strong dependencies through whole project, such as
HomeFragment.kt
...
val navController = viewBinding.bottomNavigation.setupWithNavController(
            navGraphIds = navGraphIds,
            fragmentManager = childFragmentManager,
            containerId = R.id.nav_host_container,
            intent = requireActivity().intent
        )

or codegen into
CharactersListFragment.kt
...
is CharactersListViewEvent.OpenCharacterDetail ->
                findNavController().navigate(
                    CharactersListFragmentDirections
                        .actionCharactersListFragmentToCharacterDetailFragment(viewEvent.id))

It's not good decision without scalable points for projects "under Forma". And we think that will be good have some abstraction navigation layer, which will protect project structure, architecture from navigation tools dependencies, especially codegen from Navigation component.
That's why need to create own navigation system, which will be use by app presentation layer. May be after, we will think about additional navigation targets for Forma.
See here, some mind ideas how it may be look

It's better to BackTo have field Class<Destination> instead of Destination. In that case you have no need to create such Destination with it's explicit paramswhen you just want to go back.

It's better to BackTo have field Class<Destination> instead of Destination. In that case you have no need to create such Destination with it's explicit paramswhen you just want to go back.

Maybe we can use cicerone? In our project we use cicerone and one more navigation abstraction for controlling screens flow


Improve and document development environment setup

Hi, this is James from @neighbourhoodie. I have been working on STF milestone M1
to improve the development workflow and documentation, so that new contributors
can get started quickly and successfully.
To meet this goal I have made the following changes:

Add make commands for starting/stopping/destroying the Docker-based dev
environment, running migrations, creating an "admin" user, and displaying the
routes.

Remove manage.py, which would not load due to its use of flask-script,
which has not worked since the release of Flask 2.0. (It tries to import
flask._compat which does not exist.)

Document the newly added make commands and remove the outdated documentation
which has barely been changed since the project's inception.

@ewdurbin I've addressed the comments you left, save for the issue of non-container dependencies.


Image trails in the sky when using 1.10

This problem can demonstrated in this application here:
http://nasa-gibs.github.io/data-curtains/index-1.10.html
Click on the red or blue ring around the Earth to bring up a profile image. Spinning the globe around should leave a ghost trail in the sky regions. This does not occur with version 1.9 which can be found here:
http://nasa-gibs.github.io/data-curtains/index-1.9.html
This occurs in Firefox and Chrome.

I have seen this randomly with 1.10 as well.  It might be related to #2790, in either case it's a pretty bad regression so I'm marking this as a showstopper.

Thanks for writing this up @mike-mcgann.
@kainino0x let's look at this when we finish #2782 or by next Monday, the 22nd, whichever comes first.

This is a dup of #2790, because there is picking on every frame.


http: Add support for receiving and sending /ac/ protobuf in JSON encoding.

We are working on adding caching to SCons using the bazel-remote server, ideally we want to avoid adding the python protobuf dependencies into SCons and thus it is much better for us if we can use the JSON protobuf encoding. Here I add support for that to the http server by using the "Accept:" header for a GET request and a "Content-Type" header for a PUT.

Oh, and please mention this in the README.md.


Dependency not found error can be misleading

Description
If you're referencing own, internal dependencies (not node_modules) that do not exist, Gridsome answers with:
This dependency was not found:

* ~/layouts/Default.vue in ./src/main.js

To install it, you can run: npm install --save ~/layouts/Default.vue

I'm not sure if this comes from Webpack or Gridsome. But I work quite some years with Webpack and never got the suggestion to install something via npm the way Gridsome does.
Steps to reproduce
Import a file or asset that doesn't exist.
Expected result
Error about missing dependency, but no note about installing dependencies when using Webpack's tilde to reference.
Actual result
Tells me to install dependencies via npm which would not work of course.

The message comes from friendly-errors-webpack-plugin and it looks like it only checks for ./and ../ to determine if it's a module or package, so an alias like ~ is treated as a package. I'm not sure what we can do about it.

Closing this, as issue is caused by webpack plugin and not Gridsome.

Any work around? Closing issues without referencing anything is not smart..


Add license file

As mentioned in PR #6, this is the fix for the linter. After merging this PR, the linter should recognize the license file and Travis CI should succeed for every further pull request.

Awesome thanks!


Rebuild images off latest upstream to fix iconv bug

Hello,
upstream fixed a bug in march https://github.com/docker-library/php/pull/1264
the last changes here were in Feb, would it be possible to rebuild and publish the images based off the latest upstream docker php to include this bug fix.
Let me know if theres anything I can do to make this process quicker and easier for you.
Thank you kindly.

@WyriHaximus Do you think you could kindly assist in rebuilding the images to get the latest upstream php image fixes.
Thank you kindly,

Thanks, looks like automated builds are fixed now so this ended up happening automatically.


prefetch_to_device not working with SparseTensor when fetching to GPU

System information

Have I written custom code: yes
OS Platform and Distribution: Linux Ubuntu 14.04
TensorFlow installed from: source
TensorFlow version: 1.9
Python version: 2.7
Bazel version: 0.12.0
GCC/Compiler version: 4.8.4
CUDA/cuDNN version: 9.1
GPU model and memory: GTX 1080, 8114MiB
Exact command to reproduce:
(Any sparse tensor being prefetched to GPU will work here, this is just one short example)

import tensorflow as tf

# Set up simple sparse tensor
ds = tf.data.Dataset.from_tensors(tf.contrib.layers.dense_to_sparse([1], 0))

# prefetch to GPU
gpu_ds = ds.apply(tf.contrib.data.prefetch_to_device('/gpu:0'))

# Get a value
gpu_iter = gpu_ds.make_one_shot_iterator()
val = gpu_iter.get_next()

# Barf
with tf.Session() as sess:
    sess.run(val)

Describe the problem
Bug resulting from prefetch_to_device with the following conditions:

device is GPU
dataset element contains a sparse tensor

Iterator functions appropriately, only when you try to use the data do you run into the error. (see log for error)
Also, as a side note which may or may not be relevant, I've found that even a single sparse tensor in an element will spoil any other nice, kind, and dense tensors in the pack. So, if, in the previous example, I were to do the following, I would still run into an error:
import tensorflow as tf
# Make a sparse tensor
ds = tf.data.Dataset.from_tensors(tf.contrib.layers.dense_to_sparse([1], 0))

# Add in a non-sparse component
ds = ds.map(lambda x: (x,1))

# Prefetch to device
gpu_ds = ds.apply(tf.contrib.data.prefetch_to_device('/gpu:0'))

# Pull out vals
gpu_iter = gpu_ds.make_one_shot_iterator()
val_sparse, val_normal = gpu_iter.get_next()

# Uh oh!
with tf.Session() as sess:
    sess.run(val_normal)

Log
Traceback (most recent call last):
File "sparse_bunk.py", line 17, in
sess.run(val_normal)
File "/local/lib/python2.7/site-packages/tensorflow/python/client/session.py", line 877, in run
run_metadata_ptr)
File "/local/lib/python2.7/site-packages/tensorflow/python/client/session.py", line 1100, in _run
feed_dict_tensor, options, run_metadata)
File "/local/lib/python2.7/site-packages/tensorflow/python/client/session.py", line 1272, in _do_run
run_metadata)
File "/local/lib/python2.7/site-packages/tensorflow/python/client/session.py", line 1291, in _do_call
raise type(e)(node_def, op, message)
tensorflow.python.framework.errors_impl.InternalError: No unary variant device copy function found for direction: 1 and Variant type_name: tensorflow::Tensor
[[Node: FunctionBufferingResourceGetNext = FunctionBufferingResourceGetNextoutput_types=[DT_VARIANT, DT_INT32], _device="/job:localhost/replica:0/task:0/device:GPU:0"]]
Thank you

Have I written custom code: yes
OS Platform and Distribution: Linux Ubuntu 14.04
TensorFlow installed from: source
TensorFlow version: 1.9
Python version: 2.7
Bazel version: 0.12.0
GCC/Compiler version: 4.8.4
CUDA/cuDNN version: 9.1
GPU model and memory: Tesla K40, K80
I have been getting a similar error when I use MirroredStrategy() for training across multiple devices. Here is the stack trace for it:
Stacktrace
`  File "train.py", line 113, in
tf.app.run()
File "/home/weinman/virtualenv/tf-b2fe2a874/local/lib/python2.7/site-packages/tensorflow/python/platform/app.py", line 125, in run
_sys.exit(main(argv))
File "train.py", line 110, in main
classifier.train(input_fn=lambda: _get_input_stream())
File "/home/weinman/virtualenv/tf-b2fe2a874/local/lib/python2.7/site-packages/tensorflow/python/estimator/estimator.py", line 376, in train
loss = self._train_model(input_fn, hooks, saving_listeners)
File "/home/weinman/virtualenv/tf-b2fe2a874/local/lib/python2.7/site-packages/tensorflow/python/estimator/estimator.py", line 1141, in _train_model
return self._train_model_distributed(input_fn, hooks, saving_listeners)
File "/home/weinman/virtualenv/tf-b2fe2a874/local/lib/python2.7/site-packages/tensorflow/python/estimator/estimator.py", line 1366, in _train_model_distributed
saving_listeners)
File "/home/weinman/virtualenv/tf-b2fe2a874/local/lib/python2.7/site-packages/tensorflow/python/estimator/estimator.py", line 1449, in _train_with_estimator_spec
_, loss = mon_sess.run([estimator_spec.train_op, estimator_spec.loss])
File "/home/weinman/virtualenv/tf-b2fe2a874/local/lib/python2.7/site-packages/tensorflow/python/training/monitored_session.py", line 583, in run
run_metadata=run_metadata)
File "/home/weinman/virtualenv/tf-b2fe2a874/local/lib/python2.7/site-packages/tensorflow/python/training/monitored_session.py", line 1059, in run
run_metadata=run_metadata)
File "/home/weinman/virtualenv/tf-b2fe2a874/local/lib/python2.7/site-packages/tensorflow/python/training/monitored_session.py", line 1150, in run
raise six.reraise(*original_exc_info)
File "/home/weinman/virtualenv/tf-b2fe2a874/local/lib/python2.7/site-packages/tensorflow/python/training/monitored_session.py", line 1135, in run
return self._sess.run(*args, **kwargs)
File "/home/weinman/virtualenv/tf-b2fe2a874/local/lib/python2.7/site-packages/tensorflow/python/training/monitored_session.py", line 1207, in run
run_metadata=run_metadata)
File "/home/weinman/virtualenv/tf-b2fe2a874/local/lib/python2.7/site-packages/tensorflow/python/training/monitored_session.py", line 987, in run
return self._sess.run(*args, **kwargs)
File "/home/weinman/virtualenv/tf-b2fe2a874/local/lib/python2.7/site-packages/tensorflow/python/client/session.py", line 877, in run
run_metadata_ptr)
File "/home/weinman/virtualenv/tf-b2fe2a874/local/lib/python2.7/site-packages/tensorflow/python/client/session.py", line 1100, in _run
feed_dict_tensor, options, run_metadata)
File "/home/weinman/virtualenv/tf-b2fe2a874/local/lib/python2.7/site-packages/tensorflow/python/client/session.py", line 1272, in _do_run
run_metadata)
File "/home/weinman/virtualenv/tf-b2fe2a874/local/lib/python2.7/site-packages/tensorflow/python/client/session.py", line 1291, in _do_call
raise type(e)(node_def, op, message)
tensorflow.python.framework.errors_impl.InternalError: No unary variant device copy function found for direction: 1 and Variant type_name: tensorflow::Tensor
[[Node: FunctionBufferingResourceGetNext = FunctionBufferingResourceGetNextoutput_types=[DT_FLOAT, DT_STRING, DT_INT32, DT_VARIANT], _device="/job:localhost/replica:0/task:0/device:GPU:0"]]
[[Node: GroupCrossDeviceControlEdges_0/train/OptimizeLoss/global_norm/gradient_norm/tags/_766 = _Recvclient_terminated=false, recv_device="/job:localhost/replica:0/task:0/device:CPU:0", send_device="/job:localhost/replica:0/task:0/device:GPU:0", send_device_incarnation=1, tensor_name="edge_1235_..._norm/tags", tensor_type=DT_FLOAT, _device="/job:localhost/replica:0/task:0/device:CPU:0"]]
Caused by op u'FunctionBufferingResourceGetNext', defined at:
File "train.py", line 113, in
tf.app.run()
File "/home/weinman/virtualenv/tf-b2fe2a874/local/lib/python2.7/site-packages/tensorflow/python/platform/app.py", line 125, in run
_sys.exit(main(argv))
File "train.py", line 110, in main
classifier.train(input_fn=lambda: _get_input_stream())
File "/home/weinman/virtualenv/tf-b2fe2a874/local/lib/python2.7/site-packages/tensorflow/python/estimator/estimator.py", line 376, in train
loss = self._train_model(input_fn, hooks, saving_listeners)
File "/home/weinman/virtualenv/tf-b2fe2a874/local/lib/python2.7/site-packages/tensorflow/python/estimator/estimator.py", line 1141, in _train_model
return self._train_model_distributed(input_fn, hooks, saving_listeners)
File "/home/weinman/virtualenv/tf-b2fe2a874/local/lib/python2.7/site-packages/tensorflow/python/estimator/estimator.py", line 1241, in _train_model_distributed
input_fn, model_fn_lib.ModeKeys.TRAIN))
File "/home/weinman/virtualenv/tf-b2fe2a874/local/lib/python2.7/site-packages/tensorflow/python/estimator/estimator.py", line 1011, in _get_features_and_labels_from_input_fn
return estimator_util.parse_input_fn_result(result)
File "/home/weinman/virtualenv/tf-b2fe2a874/local/lib/python2.7/site-packages/tensorflow/python/estimator/util.py", line 111, in parse_input_fn_result
result = iterator.get_next()
File "/home/weinman/virtualenv/tf-b2fe2a874/local/lib/python2.7/site-packages/tensorflow/contrib/distribute/python/values.py", line 619, in get_next
data_list = self._iterator.get_next(name=name)
File "/home/weinman/virtualenv/tf-b2fe2a874/local/lib/python2.7/site-packages/tensorflow/contrib/distribute/python/prefetching_ops_v2.py", line 124, in get_next
self.output_types, self.output_classes)), name=name)
File "/home/weinman/virtualenv/tf-b2fe2a874/local/lib/python2.7/site-packages/tensorflow/contrib/data/python/ops/gen_dataset_ops.py", line 351, in function_buffering_resource_get_next
output_types=output_types, name=name)
File "/home/weinman/virtualenv/tf-b2fe2a874/local/lib/python2.7/site-packages/tensorflow/python/framework/op_def_library.py", line 787, in _apply_op_helper
op_def=op_def)
File "/home/weinman/virtualenv/tf-b2fe2a874/local/lib/python2.7/site-packages/tensorflow/python/util/deprecation.py", line 432, in new_func
return func(*args, **kwargs)
File "/home/weinman/virtualenv/tf-b2fe2a874/local/lib/python2.7/site-packages/tensorflow/python/framework/ops.py", line 3212, in create_op
op_def=op_def)
File "/home/weinman/virtualenv/tf-b2fe2a874/local/lib/python2.7/site-packages/tensorflow/python/framework/ops.py", line 1702, in init
self._traceback = self._graph._extract_stack()  # pylint: disable=protected-access
InternalError (see above for traceback): No unary variant device copy function found for direction: 1 and Variant type_name: tensorflow::Tensor
[[Node: FunctionBufferingResourceGetNext = FunctionBufferingResourceGetNextoutput_types=[DT_FLOAT, DT_STRING, DT_INT32, DT_VARIANT], _device="/job:localhost/replica:0/task:0/device:GPU:0"]]
[[Node: GroupCrossDeviceControlEdges_0/train/OptimizeLoss/global_norm/gradient_norm/tags/_766 = _Recvclient_terminated=false, recv_device="/job:localhost/replica:0/task:0/device:CPU:0", send_device="/job:localhost/replica:0/task:0/device:GPU:0", send_device_incarnation=1, tensor_name="edge_1235_..._norm/tags", tensor_type=DT_FLOAT, _device="/job:localhost/replica:0/task:0/device:CPU:0"]]`
End of Stacktrace
My guess is that the underlying issue should be the same. I do not make any explicit calls to prefetch_to_device(Insert GPU here) with sparse tensors anywhere in my code. Hence, the issue probably lies with references to prefetching ops under the hood.

I think I'm experiencing the same error here.
After staring at it for a while, I realized that the direction (HOST_TO_DEVICE = 1), the recv_device ("/job:localhost/replica:0/task:0/device:CPU:0"), and the send_device ("/job:localhost/replica:0/task:0/device:GPU:0") don't seem to be in agreement.
Perhaps I'm misunderstanding what's going on here, but maybe it's a simple issue related to getting the direction of the copy correct?

@rohan100jain Any thoughts on the above?

Nagging Assignee @rohan100jain: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

So @mrry added some support recently that makes this go away. I ran the same piece of code with tf-nightly-gpu and seems to work.
https://github.com/tensorflow/tensorflow/commit/02ae1e2e781b8e049d1fc1ab7b52f6ee7edb4423#diff-3d32c23cf21d0adac13fdd28576dd6f9
Please test it and let me know if there is still a problem.


Support separate ZFS boot pool

While working in a chroot environment where /mnt/boot is used for a second system and /boot has been mounted AFTER /mnt/boot (yes, sounds strange but it could happen)
target = re.compile(r'^.*\s*' + mountpoint + r'\s*zfs\b')

returns the ZFS pool for /mnt/boot which is not correct.

I'm not 100% sure if my fix is correct. Is an exact match of mountpoint required in /proc/mounts? In other words, if I set org.zedenv.grub:boot=/mnt/boot and /mnt/boot is not explicit mounted, what should be returned in this case? The mountpoint of /mnt? What happens if there is no entry for /mnt?
Background info:
Due to some custom mount operations, my current /proc/mounts has the entries:

Entry
Mountpoint

...
...

bpool2/boot/env/zedenv-default
/mnt/boot

bpool2/boot/grub
/mnt/boot/grub

/dev/sda1
/mnt/boot/efi

bpool/boot/env/zedenv-ubuntu
/boot

bpool/boot/grub
/boot/grub

If I set the org.zedenv.grub:boot=/boot, the regex from above evaluates to target = bpool2/boot/env/zedenv-default. Therefore, I would suggest to make the whitespaces mandatory.
target = re.compile(r'^.*\s+' + mountpoint + r'\s+zfs\b')


filter --link docker option when building dockerfile app

i'm not sure this is the best solution but it works in leiu of making the plugins handle it
closes #1609

Is --link the only option expected to be used by plugins at this stage not used by herokuish/buildstep? My first impression is that this fix is short-sighted but I'm also suffering from the issue so I'm happy if this works as a temporary fix.
What about dockerfile plugins that don't work for herokuish builds like --build-arg or --file?

Probably not and it is short-sighted indeed. However, leaving this broken is probably not good either.

Yeah I was just bringing up the inverse problem where a plugin is expecting a dockerfile deployment.
It does seem beneficial to tell the plugin which deployment type is happening to really solve this issue.

Updated to take into account the inverse problem. This is by no means exhaustive but gets us a pattern to filter args for now.

@michaelshobbs you want to add that static buildpack and a test app to herokuish?

I can yeah. My fork or the official one?

Your fork. Or just move your fork to the dokku org and be done with it. Official fork?

Yeah I'll revert this change here and open a new PR


Couldn't run this as a service on OpenWRT/LEDE 17.01.4

I'm trying to run this as a service on OpenWRT/LEDE 17.01.4, using the arm version, but couldn't get it to run as a service.
I tried
/etc/init.d/dnscrypt-proxy enable
/etc/init.d/dnscrypt-proxy start
/usr/sbin/dnscrypt-proxy -config /etc/config/dnscrypt-proxy.toml &
/usr/sbin/dnscrypt-proxy -service install
/usr/sbin/dnscrypt-proxy -service start
Are there any issues with running this on OpenWRT?

No messages and errors in /var/log/dnscrypt-proxy.log /var/log/dnscrypt-proxy.err
Both files are empty.

Managed to fix this by editing /etc/init.d/dnscrypt-proxy to the following:
#!/bin/sh /etc/rc.common
by chuacw 18 Apr 2018
cmd="/usr/sbin/dnscrypt-proxy"
name=$(basename $(readlink -f $cmd))
stdout_log="/var/log/$name.log"
pid_file="/var/run/$name.log"
stderr_log="/var/log/$name.err"
arguments="-config /etc/config/dnscrypt-proxy.toml -logfile $stdout_log"
start_cmd="start-stop-daemon -b -S -m -p $pid_file -x $name -- $arguments"
stop_cmd="start-stop-daemon -K -p $pid_file"
echo start cmd is: $start_cmd
echo stop cmd is: $stop_cmd
get_pid() {
cat "$pid_file"
}
start() {
echo "Starting DNSCrypt proxy..."
$start_cmd
echo "See ps result for confirmation"
ps | grep "$name"
}
stop() {
echo "Stopping DNSCrypt proxy..."
$stop_cmd
echo "See ps result below for confirmation"
ps | grep "$name"
rm $pid_file
}


Using escape key permanently hides preferences window

🐛 Bug
Related to #2527 ... but perhaps different enough for a different issue:
If you use the escape key when the preferences window is open, it will indeed close the window.  However, using command-W or File > Preferences will not re-show the window.

Buuug!


WIP: Fix tomcat_version variable usage

Description of the Change
In the "Download & Extract Tomcat" task we try to detect if the tomcat
version to install is the same as the configured in the variables.
The check used the literal tomcat_version instead of
interpolating the Jinja2 value like {{ tomcat_version }}.
NOTE: this opens a new changelog "Fixed" section as well as #96. I will set this as draft as it would cause conflicts on merge. If the other PR is merged in, I will rebase this branch against the latest develop to avoid conflicts.
Benefits
The check that tries to figure out whether the installed Tomcat is the wanted version in the tomcat_version variable should work as expected.
Possible Drawbacks
TBH, I'm not sure how this was working before. I guess that the particular version check was yelding false always.
Also, if I understand correctly, the check should be != instead of ==, since I believe that this task will download & install if the installed version is different from the one we want. Is that right? In such case, I can fix the conditional as well.
Applicable Issues
N/A

OK, "draft" is not what I thought. Setting to Ready for review but adding WIP to the title.

Hi @agimenez thanks for noticing this missbehaviour, I've verified the mentioned issues.
If you could also fix the conditional for the version check (using != instead of ==) would be awesome!

@vicsufer branch updated with the comparison fix. Thanks!

It seems that the linter doesn't like jinja2 templating inside when conditionals.
From travis builds running ansible-lint: tasks/install.yml:36: [E102] No Jinja2 in when
As an alternative you may like to consider something like or tomcat_version not in tomcat_check.stderr (Notice there is no quotations here)


[SPARK-48591][PYTHON] Add a helper function to simplify Column.py

What changes were proposed in this pull request?
Add a helper function to simplify Column.py
Why are the changes needed?
code clean up
Does this PR introduce any user-facing change?
No
How was this patch tested?
CI
Was this patch authored or co-authored using generative AI tooling?
No

merged to master


fix: openSSH setup guide

Ref: https://learn.microsoft.com/en-us/windows-server/administration/openssh/openssh_install_firstuse?tabs=powershell
I'm getting this weird phenomenon. I wanted to suggest that we do away with the multiple tildes (~), but then it works for Client but consistently fails for Server, until when I just have one tilde, i.e
Add-WindowsCapability -Online -Name OpenSSH.Server~<IP_ADDRESS>

I'm not sure about the inconsistencies. Please see my output below:

Hey @profnandaa,
Thanks again for contacting Microsoft, we value your feedback.
As you stated, "I wanted to suggest that we do away with the multiple tildes (~)". We as writers have zero control of how the product and dev teams decide to produce their apps and software. You can provide them this feedback by using the Windows Feeback Hub.
Working with @christking246, we have set up fresh VMs of the following OSs of different builds (no preview OS release due to their nature):

Windows 10
Windows 11
Windows Server 2019
Windows Server 2022

We ran the PS command from this doc as described for both client & server without issue:

There was an exception of WS2019. The 0x800f0950 error was reproduced due to missing cumulative KB update KB5034127 as OpenSSH is directly affected based on the affected files information for said update.
This was not the case reviewing the other OS builds as OpenSSH installed out of the box. We're unable to track what KBs directly affect OpenSSH as it can always change as more cumulative and security updates are released. KB updates are known to potentially affect other aspects of the operating system that, once discovered, are corrected with another KB update. It is recommended to keep your device up to date which may correct such issues.
If you're still having issues, we recommend you reach out to our community forums as this is outside our scope:

Microsoft TechNet
Microsoft Developer Network
Microsoft Support Community

As there isn't an issue with the doc itself, updates to OpenSSH won't be made and we'll now be closing this thread. Thank you and have a most pleasant day.
#please-close


Tree

Looks like a good start.
Were you able to get Amanda's lecture? Did you do post order and in order traversals?
Looks like you are missing testing.


Spaceship::Client.handle_two_factor can loop indefinitely in CI environments, causing Apple Account lockouts

New Issue Checklist

[x] Updated fastlane to the latest version
[x] I read the Contribution Guidelines
[x] I read docs.fastlane.tools
[x] I searched for existing GitHub issues

Issue Description
If ENV[FASTLANE_SESSION] has expired, and Spaceship is used in a CI environment that utilizes FASTLANE_SESSION to authenticate with the Apple APIs, Spaceship falls back on the handle_two_factor method, which attempts to request a 2fa code and verify in the CI's non-interactive shell.  When this fails, Fastlane handles the error by logging it, incrementing depth, and calling handle_two_factor again.  Unfortunately, outside of determining whether or not to output the first-time explanation of what's happening, depth is completely unused, which means this code loops until Apple locks the account for 12 hours - at which point Fastlane catches Spaceship::AccessForbiddenError and exits.
Command executed
Not relevant, the bug is visible in spaceship/lib/spaceship/two_step_or_factor_client.rb
Complete output when running fastlane, including the stack trace and command used
Relevant stack trace:

INFO [2022-09-21 22:19:47.37]: Current team: MyTeamName
Loading session from environment variable
Session loaded from environment variable is not valid. Continuing with normal login.
Two-factor Authentication (6 digits code) is enabled for account<EMAIL_ADDRESS>More information about Two-factor Authentication: https://support.apple.com/en-us/HT204915
If you're running this in a non-interactive session (e.g. server or CI)
check out https://github.com/fastlane/fastlane/tree/master/spaceship#2-step-verification
Please enter the 6 digit code you received at +1 (•••) •••-••XX:
Requesting session...
Error: Incorrect verification code
Please enter the 6 digit code you received at +1 (•••) •••-••XX:
Requesting session...
Error: Incorrect verification code
Please enter the 6 digit code you received at +1 (•••) •••-••XX:
Requesting session...
Error: Incorrect verification code
Please enter the 6 digit code you received at +1 (•••) •••-••XX:
Requesting session...
Error: Incorrect verification code
Please enter the 6 digit code you received at +1 (•••) •••-••XX:
Requesting session...
Error: Incorrect verification code
Please enter the 6 digit code you received at +1 (•••) •••-••XX:
Requesting session...
Error: Incorrect verification code
Please enter the 6 digit code you received at +1 (•••) •••-••XX:
Requesting session...
Error: Incorrect verification code
Please enter the 6 digit code you received at +1 (•••) •••-••XX:
Requesting session...
Error: Incorrect verification code
Please enter the 6 digit code you received at +1 (•••) •••-••XX:
Requesting session...
Error: Incorrect verification code
Please enter the 6 digit code you received at +1 (•••) •••-••XX:
Requesting session...
Timeout received: 'Spaceship::AccessForbiddenError', 'Access forbidden'. Retrying after 3 seconds (remaining: 4)...
Timeout received: 'Spaceship::AccessForbiddenError', 'Access forbidden'. Retrying after 3 seconds (remaining: 3)...
Timeout received: 'Spaceship::AccessForbiddenError', 'Access forbidden'. Retrying after 3 seconds (remaining: 2)...
Timeout received: 'Spaceship::AccessForbiddenError', 'Access forbidden'. Retrying after 3 seconds (remaining: 1)...
WARN [2022-09-21 22:20:04.18]: Lane Context:
INFO [2022-09-21 22:20:04.18]: {:PLATFORM_NAME=>nil, :LANE_NAME=>"certs_and_profiles"}
ERROR [2022-09-21 22:20:04.18]: Access forbidden
ERROR [2022-09-21 22:20:04.18]: fastlane finished with errors
Looking for related GitHub issues on fastlane/fastlane...
Search query: The request could not be completed because:
Access forbidden
URL: https://api.github.com/search/issues?q=The request could not be completed because%3A
	Access forbidden+repo:fastlane/fastlane
➡  Match receives Access Forbidden response
https://github.com/fastlane/fastlane/issues/20530 [open] 1 💬
2 weeks ago
➡  Requesting preview sets with token based login throws access forbidden error
https://github.com/fastlane/fastlane/issues/19788 [closed] 2 💬
12 Jun 2022
➡  undefined method `include?' for nil:NilClass (NoMethodError)
https://github.com/fastlane/fastlane/issues/20444 [closed] 73 💬
a day ago
and 12 more at: https://github.com/fastlane/fastlane/search?q=The request could not be completed because%3A
	Access forbidden&type=Issues&utf8=✓
🔗  You can ⌘ + double-click on links to open them directly in your browser.
/usr/local/lib/ruby/gems/2.5.0/gems/fastlane-2.198.1/spaceship/lib/spaceship/client.rb:925:in handle_error': [!] The request could not be completed because: (Spaceship::AccessForbiddenError) 	Access forbidden 	from /usr/local/lib/ruby/gems/2.5.0/gems/fastlane-2.198.1/spaceship/lib/spaceship/client.rb:902:in block in send_request'
from /usr/local/lib/ruby/gems/2.5.0/gems/fastlane-2.198.1/spaceship/lib/spaceship/client.rb:657:in with_retry' 	from /usr/local/lib/ruby/gems/2.5.0/gems/fastlane-2.198.1/spaceship/lib/spaceship/client.rb:898:in send_request'
from /usr/local/lib/ruby/gems/2.5.0/gems/fastlane-2.198.1/spaceship/lib/spaceship/client.rb:742:in request' 	from /usr/local/lib/ruby/gems/2.5.0/gems/fastlane-2.198.1/spaceship/lib/spaceship/two_step_or_factor_client.rb:176:in handle_two_factor'
from /usr/local/lib/ruby/gems/2.5.0/gems/fastlane-2.198.1/spaceship/lib/spaceship/two_step_or_factor_client.rb:201:in rescue in handle_two_factor' 	from /usr/local/lib/ruby/gems/2.5.0/gems/fastlane-2.198.1/spaceship/lib/spaceship/two_step_or_factor_client.rb:183:in handle_two_factor'
from /usr/local/lib/ruby/gems/2.5.0/gems/fastlane-2.198.1/spaceship/lib/spaceship/two_step_or_factor_client.rb:201:in rescue in handle_two_factor' 	from /usr/local/lib/ruby/gems/2.5.0/gems/fastlane-2.198.1/spaceship/lib/spaceship/two_step_or_factor_client.rb:183:in handle_two_factor'
from /usr/local/lib/ruby/gems/2.5.0/gems/fastlane-2.198.1/spaceship/lib/spaceship/two_step_or_factor_client.rb:201:in rescue in handle_two_factor' 	from /usr/local/lib/ruby/gems/2.5.0/gems/fastlane-2.198.1/spaceship/lib/spaceship/two_step_or_factor_client.rb:183:in handle_two_factor'
from /usr/local/lib/ruby/gems/2.5.0/gems/fastlane-2.198.1/spaceship/lib/spaceship/two_step_or_factor_client.rb:201:in rescue in handle_two_factor' 	from /usr/local/lib/ruby/gems/2.5.0/gems/fastlane-2.198.1/spaceship/lib/spaceship/two_step_or_factor_client.rb:183:in handle_two_factor'
from /usr/local/lib/ruby/gems/2.5.0/gems/fastlane-2.198.1/spaceship/lib/spaceship/two_step_or_factor_client.rb:201:in rescue in handle_two_factor' 	from /usr/local/lib/ruby/gems/2.5.0/gems/fastlane-2.198.1/spaceship/lib/spaceship/two_step_or_factor_client.rb:183:in handle_two_factor'
from /usr/local/lib/ruby/gems/2.5.0/gems/fastlane-2.198.1/spaceship/lib/spaceship/two_step_or_factor_client.rb:201:in rescue in handle_two_factor' 	from /usr/local/lib/ruby/gems/2.5.0/gems/fastlane-2.198.1/spaceship/lib/spaceship/two_step_or_factor_client.rb:183:in handle_two_factor'
from /usr/local/lib/ruby/gems/2.5.0/gems/fastlane-2.198.1/spaceship/lib/spaceship/two_step_or_factor_client.rb:201:in rescue in handle_two_factor' 	from /usr/local/lib/ruby/gems/2.5.0/gems/fastlane-2.198.1/spaceship/lib/spaceship/two_step_or_factor_client.rb:183:in handle_two_factor'
from /usr/local/lib/ruby/gems/2.5.0/gems/fastlane-2.198.1/spaceship/lib/spaceship/two_step_or_factor_client.rb:201:in rescue in handle_two_factor' 	from /usr/local/lib/ruby/gems/2.5.0/gems/fastlane-2.198.1/spaceship/lib/spaceship/two_step_or_factor_client.rb:183:in handle_two_factor'
from /usr/local/lib/ruby/gems/2.5.0/gems/fastlane-2.198.1/spaceship/lib/spaceship/two_step_or_factor_client.rb:201:in rescue in handle_two_factor' 	from /usr/local/lib/ruby/gems/2.5.0/gems/fastlane-2.198.1/spaceship/lib/spaceship/two_step_or_factor_client.rb:183:in handle_two_factor'
from /usr/local/lib/ruby/gems/2.5.0/gems/fastlane-2.198.1/spaceship/lib/spaceship/two_step_or_factor_client.rb:21:in handle_two_step_or_factor' 	from /usr/local/lib/ruby/gems/2.5.0/gems/fastlane-2.198.1/spaceship/lib/spaceship/client.rb:515:in send_shared_login_request'
from /usr/local/lib/ruby/gems/2.5.0/gems/fastlane-2.198.1/spaceship/lib/spaceship/portal/portal_client.rb:28:in send_login_request' 	from /usr/local/lib/ruby/gems/2.5.0/gems/fastlane-2.198.1/spaceship/lib/spaceship/client.rb:XX4:in do_login'
from /usr/local/lib/ruby/gems/2.5.0/gems/fastlane-2.198.1/spaceship/lib/spaceship/client.rb:404:in login' 	from /usr/local/lib/ruby/gems/2.5.0/gems/fastlane-2.198.1/spaceship/lib/spaceship/client.rb:366:in login'
from /usr/local/lib/ruby/gems/2.5.0/gems/fastlane-2.198.1/spaceship/lib/spaceship/portal/spaceship.rb:25:in login' 	from /usr/local/lib/ruby/gems/2.5.0/gems/fastlane-2.198.1/spaceship/lib/spaceship/portal/spaceship.rb:103:in login'
from Fastfile:28:in block in parsing_binding' 	from /usr/local/lib/ruby/gems/2.5.0/gems/fastlane-2.198.1/fastlane/lib/fastlane/lane.rb:33:in call'
from /usr/local/lib/ruby/gems/2.5.0/gems/fastlane-2.198.1/fastlane/lib/fastlane/runner.rb:49:in block in execute' 	from /usr/local/lib/ruby/gems/2.5.0/gems/fastlane-2.198.1/fastlane/lib/fastlane/runner.rb:45:in chdir'
from /usr/local/lib/ruby/gems/2.5.0/gems/fastlane-2.198.1/fastlane/lib/fastlane/runner.rb:45:in execute' 	from /usr/local/lib/ruby/gems/2.5.0/gems/fastlane-2.198.1/fastlane/lib/fastlane/lane_manager.rb:47:in cruise_lane'
from /usr/local/lib/ruby/gems/2.5.0/gems/fastlane-2.198.1/fastlane/lib/fastlane/command_line_handler.rb:36:in handle' 	from /usr/local/lib/ruby/gems/2.5.0/gems/fastlane-2.198.1/fastlane/lib/fastlane/commands_generator.rb:109:in block (2 levels) in run'
from /usr/local/lib/ruby/gems/2.5.0/gems/commander-4.6.0/lib/commander/command.rb:187:in call' 	from /usr/local/lib/ruby/gems/2.5.0/gems/commander-4.6.0/lib/commander/command.rb:157:in run'
from /usr/local/lib/ruby/gems/2.5.0/gems/commander-4.6.0/lib/commander/runner.rb:444:in run_active_command' 	from /usr/local/lib/ruby/gems/2.5.0/gems/fastlane-2.198.1/fastlane_core/lib/fastlane_core/ui/fastlane_runner.rb:117:in run!'
from /usr/local/lib/ruby/gems/2.5.0/gems/commander-4.6.0/lib/commander/delegates.rb:18:in run!' 	from /usr/local/lib/ruby/gems/2.5.0/gems/fastlane-2.198.1/fastlane/lib/fastlane/commands_generator.rb:353:in run'
from /usr/local/lib/ruby/gems/2.5.0/gems/fastlane-2.198.1/fastlane/lib/fastlane/commands_generator.rb:42:in start' 	from /usr/local/lib/ruby/gems/2.5.0/gems/fastlane-2.198.1/fastlane/lib/fastlane/cli_tools_distributor.rb:122:in take_off'
from /usr/local/lib/ruby/gems/2.5.0/gems/fastlane-2.198.1/bin/fastlane:23:in <top (required)>' 	from /usr/local/bin/fastlane:23:in load'
from /usr/local/bin/fastlane:23:in `'

Ideally we would see this logic retried a maximum of 3 times, which is enough to account for short-term networking issues without locking teams out of their service account. The depth variable is already there and can likely be used for this purpose.
Environment

Unable to run `fastlane env` due to permissions constraints, but the bug has been located.

Updated with a short blurb regarding fastlane env

I can put together a quick PR, but I'm not sure which error to use to denote that a maximum number of retries has been exceeded.

Please do not close this issue, this is at the very least undesired behavior.

*Bump

Same:

Same for me, even with the newest fastlane-version.

*bump

Any solution ?


Build instruction for map is missing log.c

In the description of map building, there is:
RUN i686-w64-mingw32-g++ -o bin/d2-map.exe \
    -Wno-write-strings \
    -static-libgcc -static-libstdc++ \
    map/json.c map/map.c map/offset.c map/d2_client.c map/main.c

And it should be:
RUN i686-w64-mingw32-g++ -o bin/d2-map.exe \
    -Wno-write-strings \
    -static-libgcc -static-libstdc++ \
    map/json.c map/map.c map/offset.c map/d2_client.c map/main.c map/log.c

The command is missing "map/log.c".

Sorry for my super slow response, must have missed this somehow..
That README  was mostly to work around a permission problem with windows, I #275 might be a better solution for the problem rather than duplicating the build command into the README.

Thanks for the response! I also hope there would be better way to fix windows permission issue.

I don't have a windows computer so testing under windows is a little patchy, I should setup some more windows/mac pipelines to make sure this actually fixes the problem.


Fix variant synonyms in web vep

Fix https://github.com/Ensembl/public-plugins/pull/404
Sandbox: http://ves-hx2-76.ebi.ac.uk:7040/Homo_sapiens/Tools/VEP?tl=hix2ELsDmBobb5II-392

Definitely not expecting this change to fix it, I thought it needed something in the javascript file. @dglemos how did you figure out by changing it to yes it will work.
I have tested the change and it works, happy for it to merge but just curious how that fix works.

Definitely not expecting this change to fix it, I thought it needed something in the javascript file. @dglemos how did you figure out by changing it to yes it will work.
I have tested the change and it works, happy for it to merge but just curious how that fix works.

@ens-ma7 I compared other options and the ones with 'yes' work properly. I just tried to change the value and it worked. I don't know if there's any javascript, probably there is something.

@ens-ma7 I compared other options and the ones with 'yes' work properly. I just tried to change the value and it worked. I don't know if there's any javascript, probably there is something.


No topic to know which devices have been found

There should be a topic that should send the list of devices found. So far, the only way I found is by reading the logs.
Am I missing something ?

You are correct, log is the only source to see all discovered devices if any
Do you want to have a special MQTT topic to see all discovered devices there?

You are correct, log is the only source to see all discovered devices if any
Do you want to have a special MQTT topic to see all discovered devices there?

Oh it would be awesome, please.
On Tue, 12 Jan 2021, 06:23 Eugene Schava<EMAIL_ADDRESS>wrote:

You are correct, log is the only source to see all discovered devices if
any
Do you want to have a special MQTT topic to see all discovered devices
there?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/eschava/broadlink-mqtt/issues/90#issuecomment-758262712,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AOHBL4CBMMVACX3R2WBXZADSZN25NANCNFSM4V3ZNCFQ
.

Oh it would be awesome, please.
On Tue, 12 Jan 2021, 06:23 Eugene Schava<EMAIL_ADDRESS>wrote:

You are correct, log is the only source to see all discovered devices if
any
Do you want to have a special MQTT topic to see all discovered devices
there?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/eschava/broadlink-mqtt/issues/90#issuecomment-758262712,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AOHBL4CBMMVACX3R2WBXZADSZN25NANCNFSM4V3ZNCFQ
.

Oh yes, absolutely, it would be awesome.
.

Oh yes, absolutely, it would be awesome.
.


Branches clean up

@plantec @labordep
do you agree to delete all the branches in the capture EXCEPT:

dev
master
ToSelectionModelSelecter (it has 2 weeks without changes but it doesn't look merged)
Pharo12 (I've created it today, this will be a stable branch similar to master, but even more stable, that we ensure newcomers that are in Pharo12 click on a World Menu entry to load it)

ok for me.
ToSelectionModelSelecter can be removed too
thanks

done!


ci(release.yml): cache enable: node

:tada: This PR is included in version 3.5.5 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[release/1.6] go.mod: Bump hcsshim to v0.9.4

This tag contains some fixes for hostprocess containers, mainly around
fixing task stats which regressed from a change in v0.9.3.
https://github.com/microsoft/hcsshim/releases/tag/v0.9.4

close+re-open to kick off CI

Linux test failures are definitely unrelated, but if anyone can re-kick them off I'd appreciate it. @thaJeztah I'm going to open up a series of commits against main to upgrade to the same tag as this PR

https://github.com/containerd/containerd/pull/7200#discussion_r929023350

This was "semi"-intentional for now as we were looking to move main to a 0.10.0-beta tag very shortly. v0.9.2 doesn't even have the code that introduced the regression so we should be fine in that regard. If we want to do the incremental move main to 0.9.4 first as well I'm fine with that, let me know

^^ PR to main was opened and merged; https://github.com/containerd/containerd/pull/7212

CGroupsV2 and I are in a constant feud

CGroupsV2 and I are in a constant feud

Rerunning

hmm, the Cgroups v2 failure is potentially an interesting package version inter-dependency problem? Looks like crun is needing a specific function linkage in criu that isn't in the criu version installed? I'm not sure if this is a temporary issue with this specific mix of Fedora 35 and our scripts or something we need to fix specifically in release/1.6 (since we aren't seeing this particular failure in main)

Trying #7217 since the only difference now is that main has moved up to Fedora 36 as a base.

Thanks Phil, it seems like CI passed for that PR

Gonna rebase to bring in that fedora bump

Still failed, but now it actually got past the preamble before even running the tests and failed on a port forward test


Set previews to have display:none.  #1555

Set previews to have display:none when their expressions have been typeset.  This avoids the problem with Firefox where the preview causes an extra line break when a displayed equation appears as the first thing in a list.
Resolves issue #1555.

lgtm.


fix: network is_public init value set to true for domain scope

这个 PR 实现什么功能/修复什么问题:
修正：network创建时刻的is_public/public_scope的设置
是否需要 backport 到之前的 release 分支:

release/2.10.0

/cc @wanyaoqi

Codecov Report

Merging #1246 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master   #1246      +/-   ##
=========================================
- Coverage    7.89%   7.89%   -0.01%
=========================================
  Files         370     370
  Lines       58032   58034       +2
=========================================
  Hits         4584    4584
- Misses      53050   53052       +2
  Partials      398     398

Flag
Coverage Δ

#aFlag
7.89% <0%> (-0.01%)
:arrow_down:

Impacted Files
Coverage Δ

pkg/compute/models/networks.go
0.97% <0%> (-0.01%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b841d3...96e099d. Read the comment docs.

/lgtm
/approve


Include the possible reason for missing uplinks in the Device Troubleshooting guide

Summary
Add the possible reason for missing uplinks in device live data but reaching gateway live data.
Why do we need this?
Adding common reasons for missing uplink in device live data to the Devices troubleshooting documentation will be useful for the Users.
What is already there? What do you see now?
Troubleshooting points for missing uplinks in device live data. https://www.thethingsindustries.com/docs/devices/troubleshooting/#i-can-see-some-received-uplinks-in-gateway-live-data-events-but-i-do-not-see-them-in-device-events
What is already there? What do you see now?
Add the below troubleshooting points in the I can see some received uplinks in gateway Live data events, but I do not see them in device events. section.
Insights:
We have observed missing uplinks in device live data when an ABP devices transmit uplinks at a frequency that is not part of the standard frequency plan used in TTS V3 (lorawan frequency plan).

For suppose, the ABP device is configured with an EU frequency plan. If the device transmits the uplink in the 866900000 frequency, the packet will be dropped at the gateway live data and will not be seen in the device live data in TTS Console. Here, 866900000 is not part of the standard EU frequency plan used in TTS V3.
In this case, the user had to check at the end device level and configure it with the correct frequencies.

How do you propose to document this?
...
Can you do this yourself and submit a Pull Request?
No.

Can you please elaborate on how is this different from what we already have:

Using inappropriate frequencies
This case applies only to ABP devices and EU/IN/AS frequency bands. Since the Network Server is initially accepting >uplinks from devices only in default channels, uplinks from the device that is using non-default channels are dropped. In this >case, Factory Preset Frequencies have to be set either in device’s overview in The Things Stack Console, or by setting MAC >commands using the CLI. If these settings are applied to an existing device, you might need to reset the device as well.

The example you mentioned is using a non-standard EU frequency, i.e. an inappropriate frequency. Could the issue in your case be solved by setting MAC commands or Factory Preset Frequencies instead of re-configuring the device?

@nejraselimovic, The existing scenario refers to the device using the frequencies that are part of the EU frequency plan used in TTS V3. (868100000, 868300000, 868500000, 867100000, 867300000, 867500000, 867700000, 867900000)
The current scenario refers to the device using a few frequencies (Eg: 866900000 instead of 867900000) out of 8 that are not part of the EU frequency plan used in TTS. (868100000, 868300000, 868500000, 867100000, 867300000, 867500000, 867700000, 866900000)
True, setting the MAC commands or Factory Preset Frequencies should serve the purpose here. But, we are not sure if it is a suggested practice in the current scenario or not.
@adriansmares, Let us know your thoughts.

The original issue that @ymgupta was thinking about when he wrote this issue is strongly related to migration.
When an end device is migrated from v2, we don't add any factory preset frequencies, as these were not stored in v2, since v2 did not actually check the frequency in which the end device has sent a message. The problem becomes then that these end devices, whose session we have migrated, will still use them, but the uplinks are lost in v3.
There are two solutions, depending on what the customer can do:

If he can physically reset the device (so rejoin, or at least reset the frame counters for ABP devices), he can add the factory frequencies, as we currently mention in the documentation, and rejoin / reset the MAC state using the Console button. This forces the NS to accept the uplinks from these 'custom' frequencies at the start of the session.
If he cannot do that, then the rejoin / reset is out of discussion. In such situations, setting the factory preset frequencies won't help, as these are taken into consideration only after a join / reset. For these rather weird moments, the closest solution that we had was to add the channels manually in both the mac_state.current.channels and mac_state.desired.channels parameters in the JSON file generated by ttn-lw-migrate. This basically tells the stack 'hey, the end device will also use these channels, allow it' - it's a workaround.

I think that the workaround should be added to the migration guide, and maybe add a small callback in the device troubleshotting guide that says 'If you migrated and have this issue, you may experience this', and link to this explanation.


Make Terminal Theme Colour array a typed listed instead

I've opted to submit this as an issue here as I may be able to effect the change myself, but I wanted to submit it for discussion before doing work/issuing a PR (and I'd probably need a little help finding the relevant place in code).
The current Terminal Theme json requires a color array of 16 RGB values:
{
  "name": "Test",
  "foreground": "#FFFFFF",
  "background": "#000000",
  "colors": [
    "#FFFFFF",
    "#808080",
    "#FFFFFF",
    "#808080",
    "#000000",
    "#000000",
    "#FFA500",
    "#000000",
    "#808080",
    "#FF0000",
    "#0000FF",
    "#FFFF00",
    "#0000FF",
    "#0000FF",
    "#0000FF",
    "#1F1F1F"
  ]
}

These values look like the align with the Vim Terminal Colours. However, its not immediately obvious what the usage of these array elements actually are (not how their index is important).
Since brevity is not really a concern in this case (we're not attempting to transmit this over the wire, etc), I feel like this is simply acting as a barrier to entry for theme designers.
I'd like to suggest replacing this array with a typed collection of properties, e.g.
{
  "name": "Test",
  "foreground": "#FFFFFF",
  "background": "#000000",
  "Black": "#FFFFFF",
  "Red": "#808080",
  "Green": "#FFFFFF",
  "Yellow": "#808080",
  "Blue": "#000000",
  "Purple": "#000000",
  "Cyan": "#FFA500",
  "White": "#000000",
  "BrightBlack": "#808080",
  "BrightRed": "#FF0000",
  "BrightGreen": "#0000FF",
  "BrightYellow": "#FFFF00",
  "BrightBlue": "#0000FF",
  "BrightPurple": "#0000FF",
  "BrightCyan": "#0000FF",
  "BrightWhite": "#1F1F1F"
}

Or a similar structure, e.g.
{
  "name": "Test",
  "foreground": "#FFFFFF",
  "background": "#000000",
  "NormalColors": {
    "Black": "#FFFFFF"
    // ...
  },
  "BrightColors": {
    "Black": "#808080",
    // ...
  }```

Alternative names for the colour items (which might make it more obvious what their intention is are also an option (e.g. ConsoleBlack).
Changing this now will reduce the barrier to entry for theme writers, before a point where too many themes exist to cause a breaking change.

Honestly, I'm not really sure I even agree with the choice to store the colors here in the xterm/posix order instead of the ConsoleColor enum order that's used everywhere else in this repo. I mean, wouldn't it make sense to use the ColorTool order?

The terminal is our stake in the ground around being compatible with everyone else first: it is a VT-compliant terminal emulator that works like terminal emulators do. That seems like reason enough to follow the ANSI SGR color ordering over the Windows one.

Yeah, I fully agree. A named list is a lot more readable and easier to understand than an array where order actually matters.

I'd guess this would be the place to make any changes: https://github.com/microsoft/Terminal/blob/dc7fff7ab0d698a6ec72cac75dacdf6b5183a63c/src/cascadia/TerminalApp/ColorScheme.cpp#L120-L130
    for (auto v : table)
    {
        if (v.ValueType() == JsonValueType::String)
        {
            auto str = v.GetString();
            auto color = Utils::ColorFromHexString(str.c_str());
            result._table[i] = color;
        }
        i++;
    }

On the surface, I think a change to this would be relatively minimal, the result._table[i] = color can more or less remain as-is, it just needs a code block that can translate named properties into their array positions. That would allow a change to clean up the theming without needing to effect a change at lower levels.

Yea, naming the properties is probably a good idea. That'll also make it easier when we decide to add a bold color as well.
I'd certainly prefer the first proposal, without the nesting, to the second. @ObsidianPhoenix you're correct, that's the right spot to put them.

Thanks. I'm in the middle of creating the commit for it just now. Having some trouble in ToJson though, I think its a pointer issue.
for (int i = 0; i < TABLE_SIZE; i++)
{
	auto current = TABLE_COLORS[i];
	auto color = _table[i];
	auto hexColor = Utils::ColorToHexString(color);
	const auto s = JsonValue::CreateStringValue(hexColor);

	jsonObject.Insert(current, s);
}

With this code, all the item values get spat out as "#000000". I'm a C++ newbie, so not sure how to resolve it?

@ObsidianPhoenix If you create a "draft" PR, I could take a look through the code and see if I can psychic debug what's going wrong.
You might need auto& color = _table[i];, but I really doubt that's it.

Cheers ^^. I gave your suggestion a go, but it didn't seem to make a difference.

@zadjii-msft Ok, it's definitely something local to my machine, rather than the code. I blitzed the entire codebase, uninstalled the app, and rebuilt master from a fresh clone. All the color values are still being set to #000000, even in the original color array.
There has to be an errant file cached somewhere.

You cannot make this a named list.
It's not just 16 colors. It supports the full 256 color xterm color palette:

For what it’s worth, I agree. There was somewhat of a discussion about it in #742, which doesn’t seem to have been linked to this issue.

See, I believe that the number of people changing the default values of the other 240 colors in their settings is going to be vanishingly small compared to the number of people changing the first 16. This change positively improves the user experience of changing the first 16 colors, without preventing us from adding support for the other 240 colors in the future.
As I mentioned in the PR, we could add an optional extendedTable:[] array to a colorscheme and profile, that lets the user override those values if they so chose. I figure'd an array would be fine for the extended values, because you're almost certainly not writing it by hand, and 240 sets of {"color16":"#000000", "color17":"#000004"},... etc, would be insane.

So make it possible, but hide it for only the more advanced users.
Perhaps the ability to import a colour scheme, and support the same file types that other terminal's use, with the full range of colours swappable.

I have a dream that one day, we'll have just a commandline arg you can pass to wt.exe that'll cause us to look for colortool, and if it finds colortool, it'll use colortool to import all the schemes colortool knows about.
Of course, adding native support for .itermcolors files would be cool too

The Windows Terminal settings screen with it's profile editor, could have all the functionality of ColorTool built in.  Import and Export a colourscheme and apply it to that profile.  Use the XAML colour picker to edit colours, and provide a preview screen.

This should have been closed with #742. If the community in general disagrees, we can continue the discussion on this thread.


fix(rate limits): Setting anonymous rate limits to a constant

:tada: This PR is included in version 1.22.3 :tada:
Your semantic-release bot :package::rocket:


feat(playground): visualize scope

Partial support https://github.com/oxc-project/oxc/issues/1048

Current dependencies on/for this PR:

main

PR #1882   👈

This stack of pull requests is managed by Graphite.


beforeRemove not called

Hi,
Not sure why this is happening, don't see any errors in the console. I have:
 {{> quickRemoveButton beforeRemove=removeConfirm collection="Meteor.users" _id=this._id  class="btn btn-danger"}}
and the following helper function:
Template.Users.helpers({
data: function() {
return Meteor.users.find();
},
removeConfirm: function() {
    return function(collection, id) {
        console.log("beforeremove");
        var doc = collection.findOne(id);
        if (confirm('Really delete user: "' + doc.name + '"?')) {
            this.remove();
            Router.go('users');
        }
    };
}

});
but the removeConfirm method is never called and I'm unable to see why its not being called.
Any suggestions?
Thanks,
Mark

nevermind, there was another confirmation library getting in the way, I had forgotten that I had setup hinas:meteor-bootstrap-confirmation.
Sorry,
Mark


Quests can start when talking to NPCs even in quest

If talking to an NPC as part of a quest for chat_npc, dialogue boxes are cut off by the quest acceptance options box.
https://gfycat.com/unnaturaldifferentibex

This has been resolved


Update of Russian language localisation

Updated the Russian translation to be more full and accurate.
Instead of Xcode I used the app called Loca Studio to actually translate the ru.xliff file directly. It is the most convenient way I found. But for some reason it didn't add state="translated" parameter to the  tag for the newly added ones. So I've added them manually.
There are a couple of strings that I haven't actually found in the app itself while using it. But I translated them nonetheless.
Hope this translate would be useful to you and won't break anything :)
Thanks for a great app!

Btw are you sure the end of this statement is correct?
https://github.com/newmarcel/KeepingYouAwake/blob/1076ccb427e2bd6755a4c2710c555fbe02d325fc/Localizations/KeepingYouAwake/en.xcloc/Localized Contents/en.xliff#L214
I see there are four options to enable Low Power Mode in macOS: Never, Always, Only on battery, Only on charge. So the Low Power Mode can be enabled while charging.
Or what you're talking about here is the logic of your app, not about macOS' one?

Thanks for your effort 👍. I was able to import the XLIFF changes and update the translations.


Deal with ambiguous bases in tidyKmerData()

Ambiguous classifications from kraken2 come up as an A: in the cigars

Fixed in 1c30799d2660d0a5de8ef789e10e45a8401d8a95