OAuth 2.0 Device Authorization Grant

Thanks for writing this wonderful library!
Do you think it would be difficult to add support for device flow?
https://datatracker.ietf.org/doc/draft-ietf-oauth-device-flow/
https://www.identityserver.com/articles/an-introduction-to-the-oauth-device-flow
https://www.ibm.com/blogs/security-identity-access/oauth-device-flows/
Someone wrote a proxy server in PHP which may be useful to investigate.
https://github.com/aaronpk/Device-Flow-Proxy-Server

You can build a custom grant with Authlib for device grant. But I won't put it in the library for now since it is still a draft.
Here is the documentation on custom grant types: http://docs.authlib.org/en/latest/flask/2/grants.html#custom-grant-types
You can also get commercial support from me. Find out at https://authlib.org/support

Just for the record.
It seems "OAuth 2.0 Device Authorization Grant" is no longer a draft.
https://datatracker.ietf.org/doc/rfc8628/

@asteven rfc8628 is added into plan list

Code available in master branch now.

Wow! Thanks!


build: reduce dependabot update frequency

See https://github.com/fastify/fastify/pull/3659

Checklist

[x] commit message and code follows the Developer's Certification of Origin
and the Code of conduct

@Eomm are you able to merge this one for me please? Don't have access

Thank you!


Fix deployment errors via custom helm chart

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 48.693%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
298

Relevant Lines:
612

💛  - Coveralls


Plural version of {{ .Name }} ?

Is there plural version of {{ .Name }} available? It would be perfect to use it when creating slices of model in template.

The func's that are made available to the templates are defined in internal/funcs.go, however there is no "plural" template func at the moment. For reference, xo uses package inflector to Singularize and Pluralize names. It would be fairly straight forward to make this available to templates by adding a wrapper to inflector.Pluralize in funcs.go. Unfortunately, this is kind of the limitation of working with Go's templates, and I do not expect that we will in the xo code base add this, as it is not used by the base templates.
The best way to work around this is to branch the xo code and version it with your project. I realize this is frustrating/not ideal, but its partly a limitation of how the underlying technology works (ie, Go templates), which twists one's arm in what can be offered in the base xo tool.


Error: configmaps is forbidden

Output of helm version:
$ helm version
Client: &version.Version{SemVer:"v2.11.0", GitCommit:"2e55dbe1fdb5fdb96b75ff144a339489417b146b", GitTreeState:"clean"}
Server: &version.Version{SemVer:"v2.11.0", GitCommit:"2e55dbe1fdb5fdb96b75ff144a339489417b146b", GitTreeState:"clean"}

Output of kubectl version:
$ kubectl version
Client Version: version.Info{Major:"1", Minor:"12", GitVersion:"v1.12.0", GitCommit:"0ed33881dc4355495f623c6f22e7dd0b7632b7c0", GitTreeState:"clean", BuildDate:"2018-09-27T17:05:32Z", GoVersion:"go1.10.4", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"11", GitVersion:"v1.11.3", GitCommit:"a4529464e4629c21224b3d52edfe0ea91b072862", GitTreeState:"clean", BuildDate:"2018-09-09T17:53:03Z", GoVersion:"go1.10.3", Compiler:"gc", Platform:"linux/amd64"}

Cloud Provider/Platform (AKS, GKE, Minikube etc.):
AWS via Kops/Terraform
$ helm repo update
Hang tight while we grab the latest from your chart repositories...
...Skip local chart repository
...Successfully got an update from the "stable" chart repository
Update Complete. ⎈ Happy Helming!⎈

$ helm ls
Error: configmaps is forbidden: User "system:serviceaccount:kube-system:tiller" cannot list configmaps in the namespace "kube-system"

Hey @mabushey, this ticket is a duplicate of other existing issues like https://github.com/helm/helm/issues/2787 which is an indication that RBAC is enabled for the cluster, but the service account tiller has been configured to use (in this case, tiller) does not have the right permissions to read configmaps. Did you go through the RBAC documentation in https://docs.helm.sh/using_helm/#role-based-access-control?


[ISSUE #3102] integer multiplication implicitly cast to long

@piyush280599 pls fix build error.

please solve the checkstyle error.


HDDS-5765. Test cluster provider possibly returns null

What changes were proposed in this pull request?
MiniOzoneClusterProvider may timeout (100 seconds) while waiting for a cluster to become available.  In this case it simply returns null without warning.  This results in NPE when trying to use the cluster in test.
testAllDataNodeFailuresAfterScmPostFinalizeUpgrade  Time elapsed: 100.076 s  <<< ERROR!
java.lang.NullPointerException
	at org.apache.hadoop.hdds.upgrade.TestHDDSUpgrade.init(TestHDDSUpgrade.java:173)
	at org.apache.hadoop.hdds.upgrade.TestHDDSUpgrade.setUp(TestHDDSUpgrade.java:135)

This change makes MiniOzoneClusterProvider throw exception if cluster could not be started.  This way test failure is a bit more explicit.
https://issues.apache.org/jira/browse/HDDS-5765
How was this patch tested?
Regular CI.
https://github.com/adoroszlai/hadoop-ozone/runs/3651226035

Thanks @sodonnel for the review.


Add Timestamp to the Failure exporter

Adding Timestamp to the Failure exporter is important to properly calculate Change Failure Rate Over Time (CFR)
The CFR metric is a simple number that represents the number of failed deployments to the number of all deployments. As such without the timestamp we were adding the Failures to the previously known ones and never calculating properly based on a chosen time window.
The max_over_time is required to be able to deduct creation time of the failure from the resolution time of that failure to properly calculate Mean Time to Restore and other metrics. Without that we would almost never had the time window that both metrics create/failure would be within it and as such the deduction would return nothing.

[ ] I have read Pelorus Contributing guidelines

Linked Issues

resolves #1010
Testing Instructions
Use script provided in the #1010 to test the scenario.

/lgtm

I am merging this change. It is approved and it has been previously tested by the CI and in the current revision only one doc line was changed.


Add permission support for viewing the Permissions tab

What is the motivation for adding/enhancing this feature?

Currently any one can access the permissons tab, Need to update permission management for the page to allow users with security view and security admin permissions to access the Permissions tab.
What are the acceptance criteria?

[ ] ...

Can you complete this feature request by yourself?

[ ] YES
[ ] NO

Additional information

Changes verified in release v1.9.1 and found few issues while verification.

Users with only security creation permissions cannot uncheck permissions that are already checked for security groups. However, they can check or uncheck permissions that are currently unchecked.
Even though users with only security viewing permissions cannot change the permission status of security groups, when they attempt to check or uncheck, the checkbox appears checked or unchecked, respectively.

Hence, reopening this ticket.

Changes verified in release v1.9.1 and found few issues while verification.

Users with only security creation permissions cannot uncheck permissions that are already checked for security groups. However, they can check or uncheck permissions that are currently unchecked.
Even though users with only security viewing permissions cannot change the permission status of security groups, when they attempt to check or uncheck, the checkbox appears checked or unchecked, respectively.

Hence, reopening this ticket.

Verified the changes in release v.10.0.
When a user within a security group attempts to modify permissions by checking or unchecking options after either the 'Security Update' or 'Security Create' permission is unchecked, the UI incorrectly displays the status of permissions as changed, despite the API failing to apply these modifications on the backend. Additionally, an error toast message appears on the UI in this scenario.
Therefore, assigning it back to dev team.

Verified and working fine in release v2.4.3. Hence, closing this ticket.


[question] Can I have more than one version of incremental dom on the same page?

We want to bundle Incremental DOM as the defacto rendering pipeline for SkateJS (merged in from Kickflip). Part of the API of Skate is to be able to exist and seamlessly function with multiple versions of itself on the same page. In the virtual DOM module, we configure Incremental DOM a certain way and don't want that to leak to any other library that may be sharing that version of Incremental DOM, for example if NPM were to dedupe it between two separate packages so that they consumed the same version.

Not currently. We have a ticket to make iDOM configure instances instead of the class definition. (On a phone now, can't find it…)

In https://github.com/google/incremental-dom/issues/114#issuecomment-134739247 you mention:

They are global. We could potentially create iDOM instances, each being able to specify their own configuration.

I couldn't find any other issues related to this. I've also commented there. It'd be rad to be able to do that. I'm happy to do whatever I can to help (including PR'ing it).

PRs, welcome. 😁
I think the best path would be to be able to pass patching options into patchInner/patchOuter.

Looking at the code, it would seem that the only global configuration that creates side effects are attributes and notifications. It would seem the best way to accomplish this would then be to remove the ability to mutate those and instead they'd be passed as you suggested above. The rest of the code seems like it would work fine, if I'm not mistaken
I'll see if I can find some time later today or this week to start some work on that.

@jridgewell we've started running into problems with this so I might start dev on it soon. Do you pefer to not make this a breaking change? For example, we can probably inject the relevant stuff into the patch() functions while still keeping the globals, or would you prefer to clean up the API and have one way of doing things? I vote for the latter. Maybe @sparhami would have some input here, too.

I'm looking at allowing patch take a config object for the attributes config. For the change notifications, I'm thinking of taking them out of the core library and creating a helper that uses MutationObserver (or monkey patches the few DOM operations Incremental DOM uses if it is not available).

I'm looking at

As in you've already started working on it, or plan to? Just don't want to double up on any work. I think I could probably successfully move things to patch() for now, but it sounds like you have other ideas in your head for the MO approach.

I have the pieces for the mutation observer approach for creation/removal notifications. Let me get that out of the way real quick, since that reduces the amount of changes needed to patch to support multiple instances.

👍 thanks @sparhami. When that's done I'll work on attributes.

For now I just removed the notification hooks. For attributes, I'm looking at adding a few new APIs: I'm going to be somewhat relying on dead-code elimination from the consumers of Incremental DOM to get the optimal size since that should be more common these days.

Expose elementOpen and elementClose from core (as open / close?) directly
Create updateAttributes
Create updateProperties
Create bufferAttribute and applyAttributes, similar to elementOpenStart + attr
Create bufferProperty and applyProperties
Create updateAttrs (pending better name) which does it based on a non-configurable mapping that does what people want (e.g. set value as a property on <input> elements)
Create the above APIs, but taking objects instead of key-value pairs

The attribute APIs may or may not have a callback to format the value when the data changes. Still thinking through this one.
From some exploration work, I have found that separating out the calls could be an improvement for performance. The elementOpenStart flow currently takes a bit of a performance hit as well, which would be nice to improve since there is more usage of it than I initially anticipated. It would still be possible to building a configurable API on top of the new API.
The new API will likely batch changes at the end of the patch (or perhaps outermost patch) by default. There will be a flush function to immediately sync any pending changes.

From some exploration work, I have found that separating out the calls could be an improvement for performance.

OOC, how did you determine this?

Expose elementOpen and elementClose from core (as open / close?) directly

Does this mean you'll also rename elementOpenStart / End to openStart / End too? 👍 if so. The element part does feel somewhat redundant.
Would the update* functions be the same thing as the current attr function, but also allow property setting? How does buffer* differ? Would you have to call apply* to flush the buffer?
How does updateAttrs differ from the previously mentioned update* and buffer* functions?
I really like the idea of using objects.
Sorry about all the questions, this looks like a great path for iDOM :)

OOC, how did you determine this?

I have some personal branches where I experiment on ideas with some simplifications and differences to the core parts of Incremental DOM that I am thinking about. The simplifications make changes and playing with different ideas easier. Two relevant branches I have are:
https://github.com/sparhami/incremental-dom/tree/explore_batch
https://github.com/sparhami/incremental-dom/tree/explore_batch_updateAttributes
with the difference being:
https://github.com/sparhami/incremental-dom/commit/963f33fdb106e7bc6a87f569a01e57dd25998919
I'm just looking at the two tests in the perf directory for now. Running both in a clean profile, I get the following numbers rather consistently for the 'list' test. The high mutation one is more bound by the number of attribute updates going on. As an aside, I found that I need to restart Chrome when switching branches since refreshing the page changes the numbers quite a bit.
explore_batch: 170-174ms
explore_batch_updateAttributes: 160-164ms
Not a huge difference. I will been happy with even a small performance hit. Need to dig more into why this is. It could be something about how the variable arguments work in the elementOpen flow or perhaps there is a hit when there are no attributes specified as the variable arguments. Not sure what is going on.
This doesn't stay consistent when doing the same change in Incremental DOM (there is a slight hit), so I want to try to figure out why that is.

Does this mean you'll also rename elementOpenStart / End to openStart / End too? :+1: if so. The element part does feel somewhat redundant.

For now, core's version are open and close (no variable arguments). I don't think elementOpenStart will have an exact equivalent. Haven't thought through everything, but for now am just messing around with needing to call an empty updateAttributes to make sure they are removed correctly.
If you specify a typeId you wouldn't need to do that. This may change to have the close function clear any unused attributes if you never called it.

Would the update* functions be the same thing as the current attr function, but also allow property setting? How does buffer* differ? Would you have to call apply* to flush the buffer?

Yep. The buffer versions would be like attr currently, which was originally added to support template compilation.

How does updateAttrs differ from the previously mentioned update* and buffer* functions?

It would do what people expect for the most part, which is look up from a mapping to see if it should set a property or an attribute and maybe set Objects and Functions as properties.

So an initial stab at the implementation looks like this commit
There are still a few open questions that need to be figured out. Probably some more that I am missing.

Should setting properties with the same as attributes be supported?
Should formatting functions for values be supported? Can support just one or variable, though this makes the diff somewhat ugly.

Could always compose the formatting functions together on the calling side.

If 1 is not supported, should an API be created to just give an attribute/value be provided that allows you to specify your own function to run on change? The internals could just use this API.
Should updateAttributes and similar functions be added at all? Leaning heavily towards 'no'.

With the current implementation, it requires copying the arguments into the buffer before calling diff, performance is worse.
The performance of the current implementation is as good as optimizing for updateAttriibutes.
The current implementation is better for other libraries to integrate with and for template code generation.

Should the mixed logic just apply value and checked (any others?) always as properties or just for <input> / <textarea>? Same for disabled for <button>.
Object API

Is there a performance hit if we just convert the Object into an Array?
Does it make sense to have a diff that just operates on objects for better performance if there is a sizable impact?
What if a DOM node goes from an Array declaration to an Object one, need to make sure attributes updated correctly.
Should there be an API for the Element + Object in one call or just keep them separate?

There are still a few open questions that need to be figured out.

Yes, we need to support both. We just had something crop up where Chrome and Safari handle the attribute or property, but not both.
Hm? Other than just the text api?
I think giving people both updateAttribute and updateProp will cover this.
I see two ways to get around this:

Pass in the element to update attributes: updateAttributes(open('div'), 'attr', 'value', 'attr2', 'value')
Update the attributes of the currently open element: open('div'); updateAttributes('attr', 'value', 'attr2', 'value'); close('div')

See 3.
We could probably handle both array iteration and object iteration without performance penalties.

Yes, we need to support both. We just had something crop up where Chrome and Safari handle the attribute or property, but not both.

Of course, why am I not shocked.

Hm? Other than just the text api?

Yeah, this would be for formatting functions for attribute values. Not sure if this is useful though.

I think giving people both updateAttribute and updateProp will cover this.

One case I can think of is if you wanted to have custom logic, say, to add event listeners. So you might want something like:
function applyListener(node, name, newValue, prevValue) {
  if (newValue) {
    node.addEventListener(name, newValue);
  } else {
    node.removeEventListener(name, prevValue);
  }
}

function myUpdateAttr(name, vakye) {
  if (name.startsWith('on')) {
    updateAttr(name, value, applyListener);
  } else {
    updateMixed(name, value);
  }
}

For number 4, from my testing
open('div');
updateAttributes('attr', 'value', 'attr2', 'value');
close('div')

is strictly worse than
open('div');
bufferAttribute('attr', 'value');
bufferAttribute('attr2', 'value');
applyAttributes();
close('div')

if you optimize for the bufferAttribute flow. That is, copying the variable arguments into an array, then calling the diff function. Maybe for the same reason that pushing one item at a time into an array is better?
For number 5,
I would like to just add updateAttribute and updateProp, but there has been a pretty strong desire for something that handles checked/value for you as a part of the library. Since it could be removed with dead-code elimination, I'm not super worried about it. From an API perspective, I would rather not have it though.

One case I can think of is if you wanted to have custom logic, say, to add event listeners. So you might want something like:

Forgot to mention that this would be useful for adding listeners for CustomEvents.

Any updates on that?


Stop failing on double disposal.

After cleanup of not disposed leaks, some user code that disposes instances of ChangeNotifier, started failing, because the disposal is now second disposal which is considered as usage after disposal.
As all flutter tests passed and number of the failures in user code is small (cl/564068590), the failing disposals are violations of ownership.
This PR suggests to stop considering disposal as usage and allow second disposal for ChangeNotifier, the same way as it is allowed for many other disposables, like FocusManager: https://github.com/flutter/flutter/blob/9dbbd5b4bfefb34514b569f962f267ebe22c9399/packages/flutter/lib/src/widgets/focus_manager.dart#L1752

I don't understand. If the failing cases are violating ownership, isn't asserting the right thing to do?

Agree this shouldn't land. There was only a single g3 project failing due to new double disposal errors. We may want to instead update the assert with instructions on the correct steps to take if hitting this issue (the change to the g3 project was simple... remove a few unneeded dispose() calls).

There are complicated cases. For example when user class creates ScrollController if it does not exist in context yet.
So, ideally the user class should sometimes dispose the controller, sometimes not.
After getting failure some users will not have capacity to resolve it in right way and will just remove disposal completely.
So, in this cases the choice is between two issues (1) no disposal and (2) double disposal.
By failing on double disposal we are forcing user to go without disposal at all.

A double disposal usually means that someone incorrectly has assumed ownership of the object where it shouldn't have. That is almost certainly a bug and we shouldn't paper over it.

Closing. Hopefully leak_tracker will prevent no-disposals


[FR] allow points to define a "cutout" of area(s) NOT to trigger on

I love the zone implementation, I wonder if a "mask" implementation could be similar, where you define points to enclose an area you want no detection to occur. I thought perhaps it could be done with another 'zone' definition with the object detection confidence set to 100.0, but I'm not sure if this introduces "priority" issues. e.g. you make a zone that covers the entire image, then cut out a rectangle with confidence 100.0 -- the first zone would "hit" but the second one would never hit, which isn't quite what we want.
Also, what happens if you define overlapping zones - do they both fire if an object is detected in the overlapped area? What happens if I name two zones the same, does the resultant zone equal the areas covered by both? If that were the case then this is perhaps a solved problem, although in an ugly way.

Sorry for taking long to respond to this.
If you get a little creative with creating the polygon, you can actually create a cutout like this (see the greyed out area):

If you define overlapping zones they will both be marked as active if an object is within both zones.
Naming two zones the same will still only create one binary sensor in home assistant, and both zones will trigger the same entity.

 We're very happy you're better now!
So it sounds like defining multiple zones for a camera creates different areas that you can name for different purposes (e.g. a camera that can see both a sidewalk and a front porch could have two zones that HA can do different things on such as turn on the porch light if the porch zone is hit, but perhaps not for the sidewalk zone).
It also sounds like creating a dozen zones and naming them all the same thing logically "OR"s them together, so if anything interesting happens in any ONE zone, the MQTT messages will fire.

You are correct! Im gonna take your comment and tweak it a little and put it in the README. Just realized there is absolutely no explanation of this in the README, sorry about that

Closing due to inactivity, feel free to reopen if the issue persists


Update fr migration docs

This PR corrects spelling mistakes in the French version of 0.14 to 1.0 migration document.

THanks!


Update popover.css

Description
This fixes a slight issue with native popups, which remain display: none because [popup]:not(.\:open) is always true for those popups.
To fix this issue this adds [popup]:not(.\:open, :open) . In other words apply this style only if the element has neither the .\:open class nor the :open psuedo selector.
Steps to test/reproduce
Try running the demo in Chrome with Experimental Web Technology enabled.
Show me
Provide screenshots/animated gifs/videos if necessary.
REMEMBER: Attach this PR to the Trello card

Hmm test failures look somewhat genuine. Maybe I flubbed this.

@jgerigmeyer / @sanajaved7 I've included the 0.0.7 commit with this one. If you would kindly publish this one that'd be swell 🥰

@keithamus I just published v0.0.7 🚀


Questions about the paper & repo

Hi there,
Thanks for providing such a great paper and code. I have read your paper in arXiv, but still have some questions. Could you explain it a little bit for me?
About the article:

How did you compare the prediction accuracy to chips like Eyeriss and TPU? I believe the source code of them are not available in public.
How did you consider the data orchestration and memory bank conflict?
Does ONNXim target to systolic array (WS/IS/OS) only?

About the code:
4) Is there optimizer for optimal mapping? If yes, could you let me know where it is in code?
5) It is mentioned in II-A, "the tile size are chosen using heuristics form prior work [8]". So the tile size calculator in ONNXim is exactly to the one from Gemmini?
6) How did you calculate the data manipulation time (e.g. from global buffer to local buffer)?

Hi, thank you for your interest in our work.
Here are the responses to your questions:

We compared the prediction accuracy to GEMMINI RTL models, which are publicly available.
In this work, we targeted regular-patterned computations with deterministic latency, assuming that bank conflicts do not occur. However, supporting more complex computations with potential bank conflicts could be an area for future improvements.
Initially, we targeted a systolic array-based structure, but it can be extended to other structures, such as adder-tree-based architectures.
You can use the Timeloop mapper for finding optimal mappings. ONNXim can load mapping information from a file, and it prioritizes that mapping when provided.
If no mapping is provided, we use the fallback heuristics from GEMMINI.  The relevant  code is implemented in https://github.com/PSAL-POSTECH/ONNXim/blob/master/src/Mapping.cc
The latency of data movement from the on-chip cache is included in the operation latency. For instance, the GEMM_PRELOAD operation includes preload latency from the scratchpad to buffers in the systolic array, as well as the computation time within the systolic array.

I hope this response helps. If you have further questions, feel free to ask.

Thanks for your answers. I'll close it since no more questions right now.


HIVE-25385: Prevent Hive Server 2 process failures when InterruptedEx…

…ception encountered

What changes were proposed in this pull request?

Why are the changes needed?

Does this PR introduce any user-facing change?

How was this patch tested?

Not sure this is the right thing to do -- tabling for now.


Setting max_phase_one_targets seems to change where labels are drawn

Hi there, apologies if this is intended behavior but I didn't see it documented anywhere.
I set out to configure leap.nvim to only show highlight groups after two keypresses. After setting max_phase_one_targets = 0, it seems that labels are now drawn on top of their jump targets, rather than adjacent to them.
For example, with the default max_phase_one_targets = nil setting, I might type sgi and see:

But with max_phase_one_targets = 0, I see

So, the labels have moved two spaces to the left, and there also seems to be an extra space.
Thanks!

Yes, this is intended, see #102. I didn't felt the need to explicitly mention this in the docs, but maybe we could do that.

But with max_phase_one_targets = 0, I see

I wanted to try this, but setting it to 0 and 'highlight_unlabeled_phase_one_targets = false' didn't change anything for me.

@ggandor I can not understand why when i type one character, the highlighting that is being shown, the labels make no sense, if i press any of the letters being shown after the first char i type, leap is just canceled.  For example i have a word "max",, i type "m", and a label will show over the letter "x" in "max".  It makes no sense, i would like to see the labels after i enter 2 characters not after the first one.  This is confusing since i can't tell how many characters i have entered, when typing fast.

Why set it to 2? You should set the value to 0 to completely disable the feature (:help leap.opts.max_phase_one_targets).

Neither 0 nil 1 or 2 do anything for me
On Fri, Oct 20, 2023, 19:03 György Andorka @.***> wrote:

Why set it to 2? You should set the value to 0 to completely disable the
feature (:help leap.opts.max_phase_one_targets).
—
Reply to this email directly, view it on GitHub
https://github.com/ggandor/leap.nvim/issues/142#issuecomment-1773006094,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADZXOY5AWXXPEUMO2ACEBATYAKOERAVCNFSM6AAAAAAXKOU4T2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZTGAYDMMBZGQ
.
You are receiving this because you commented.Message ID: <ggandor/leap.
@.***>

require('leap').opts.max_phase_one_targets = 0 should work, the issue is something else then.

Neither 0, 1 or nil work. Initially i was just setting it on a trial and error principle was too lazy to look at the source, and 2 worked, even then the docs seemed very poorly explained, there was no explanation on what phases are etc.


specifally query thnoas sidecars from thanos queriers when using grafana

While writing queries in grafana, How can I mention I need the data to be fetched from specific sidecars only for faster retrieval instead of store gateway?

There are two ways I can think of:

Use a recent time range. Sidecar always has the latest data while store gateway usually has not so updated data. If you select a recent query time range then it is possible to skip store gateway.
You can use store filtering in the Thanos UI to only query sidecars. But it is not easy to do this in Grafana. IIRC you can only set customQueryParams in the datasource configuration but it is global for this datasource.

Try set store gateway flags --max-time=1d to serve only time 1 day ago.

the querier will use sidecar/store external label as first filter.
for example:
there are two prometheus，one config team='a' external label. another config team='b' external label.
if the query is 'up{team='a'}'，it only query the first one prometheus sidecar.
the store gateway has relabel config filter and time range filter，it can on serve a part of labels or time range across all the blocks. for example， set store gateway flags --max-time=1d to serve only time 1 day ago.

@denniceritchie Will close this issue for now. Let me know if you still have other questions.


[VS Code] [Audio] Request startOrJoinCall failed unexpectedly without providing any details.

Error:
Request startOrJoinCall failed unexpectedly without providing any details.
Steps to Reproduce:
1.
2.

Version Data

extensionName
VSLS-Audio

extensionVersion
0.1.85

applicationName
VSCode

applicationVersion
1.48.0

platformName
Windows

platformVersion
10.0.18362

Migrating logs from #3910, where the customer experienced this problem on Linux.
logs.zip

Closing this as a duplicate of #2555.


xlsx pipe from stream not working

// pipe from stream
var workbook = new Excel.Workbook();
stream.pipe(workbook.xlsx.createInputStream())
.on('data', (data) => {
       // event not triggering...
          console.log(data)
})

Hi, I met the same question just now, and I have solved it by transferring the stream into a buffer then load it successfully. You can see XLSX Streaming Reader is still in the backlog in readme, hope it can help.


Fixed boot_system renamed to boot_application in Sidekiq 6.1.1

A PR for fixing #36 .

Sidekiq 6.1.1 adds a dependency to ruby >= 2.5.0. This is why the PR fails on older versions of ruby.

Sidekiq 6.1.1 adds a dependency to ruby >= 2.5.0. This is why the PR fails on older versions of ruby.

I have updated the gemspec to restrict this PR since now we know it will only work for sidekiq versions < 6.5.0 (later versions will need another PR).

Seems like the current sidekiq-pool team is supporting a working on a quite old version of sidekiq and maintains the gem only in the scope a very specific project. For example, last year's commit :
https://github.com/vinted/sidekiq-pool/commit/a4fd05bd462e639a3210c822e3d44aaf60a4b774
uses the write_pid method which was removed more than 3 years ago in sidekiq :
https://github.com/mperham/sidekiq/issues/4045
It's going to be more and more complicated to reintroduce support for latest versions of sidekiq.

@tdeo : salut Thierry, if you're stuck and are in an urgent situation, you can try to use the following branch : https://github.com/BenTalagan/sidekiq-pool/tree/edge/sidekiq6.5.0 . Please note however that I've diverged from the official sidekiq-pool's master for my own needs and haven't reintegrated recent commits (I cannot, since they are not compatible with recent versions of sidekiq).

Is there any plan to merge this? It seems like supporting a more recent version of Sidekiq is a good thing.
@andriusm @vitiokss @laurynas


Add support for OVA v3 / xAIF

OVA v3 uses a new data format called xAIF. An example has been uploaded by arg-tech.

Resolved by #20 (available since v1.8.0)


Replace setup.cfg with pyproject.toml

Changes proposed in this pull request:

Keep setuptools
Replace setup.cfg with pyproject.toml
Replace setup-cfg-fmt with pyproject-fmt + validate-pyproject

This is a first step towards moving to hatchling in https://github.com/python-humanize/humanize/pull/79, and will make the diff smaller there whilst figuring out the translation files.

Codecov Report

Merging #90 (5e60d18) into main (60e3b47) will decrease coverage by 1.61%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #90      +/-   ##
==========================================
- Coverage   99.06%   97.44%   -1.62%
==========================================
  Files           9        9
  Lines         745      745
==========================================
- Hits          738      726      -12
- Misses          7       19      +12

Flag
Coverage Δ

macos-latest
96.64% <ø> (-0.81%)
:arrow_down:

ubuntu-latest
97.44% <ø> (ø)

windows-latest
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

tests/test_i18n.py
88.57% <0.00%> (-11.43%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Install ElastixTargets.cmake file

Created variables in ElastixConfig.cmake to specify installation path
and build path uniformly.

The example external project built when I defined ITK_DIR on the cmake configuration line. i.e.: cmake -G Ninja -DElastix_DIR=/scratch/elx -DITK_DIR=/scratch/itk/ ~/src/elastix/dox/externalproject/
With this change the find_packge(ITK) has moved into the ElastixConfig.cmake file. So these lines are not longer needed in an external project:
https://github.com/SuperElastix/elastix/blob/02489736455ad9893856ccb376f616b7305d0a6a/dox/externalproject/CMakeLists.txt#L16-L19
The above is require so that the target defined in ElastixTargets ITK dependencies are targets defined in ITKTargets.
The "ELASTIX_ITK_DIR" variable definition was left in the ElastixConfig.cmake file for compatibility, but it is problematic to save the ITK_DIR directory used to build.
So, this is a change in behavior requiring ITK_DIR to be defined on the command line.

this is a change in behavior requiring ITK_DIR to be defined on the command line.

Thanks for investigating this issue, Bradley. However, I would like an external project that links to the elastix build tree to be able to link to specifically the ITK_DIR that was used by the elastix build. By default, a find_package(ITK) in such an external project should find the ITK binaries used by the specific elastix build. Do you think that could still be made possible?

I just updated the PR so that the build config has code to set ITK_DIR.


Folders with space in name are packed as %20 in the Cloud Service Package

Using SDK 2.2, 2.5 or 2.6 (do not have other versions to confirm), with either Web or Worker roles, if I have a folder name that contains spaces, those are wrongly encoded into %20 when the cloud service package is created.
The problem is illustrated here:

@astaykov This repo is for azure management sdks - the visual studio tooling is managed elsewhere.  Can you please raise this issue in the appropriate forum?


CAS2-401 refactor application summaries (add personName)

This PR contains the work required for the first bullet point of CAS2-401
Tasks:

API: add personName as field to Cas2ApplicationSummary

We currently return for ApplicationSummaries a full Person result, which includes a lot of data, and causes issues with how we handle whether the person has been found/is restricted.
We propose that we follow the standard set for /submissions and just return a personName which will be ‘Unknown’ if person not found or restricted.
This will mean we can then do a bulk search with the CRNs more easily, and just get the person’s name.

Added crn and noms number and also unit test coverage for these (as recommended in Slack conversation).


created a program that converts Celsius to Fahrenheit

created tempConverter.cpp that converts temperature in Celsius to Fahrenheit in tasks/c++/easy/

Merged

This is an automated message from Fork, Commit, Merge [BOT].

Thank you for your contribution! Your pull request has been merged. The files have been reset for the next contributor.
What's next?
If you're looking for more ways to contribute, I invite you to check out my other projects. Just click here to find more. These projects contain real issues that you can help resolve.
Also please leave a star to this project if you feel it helped you, i would really appreciate it.
I look forward to seeing your contributions!


chore(META): add make lib all target

ISSUES CLOSED: #589

[ ] I added new tests for the issue I fixed/built
[ ] I ran make test FOO for the package FOO I'm modifying
[x] I used make commit instead of git commit

The tests failed because of timeouts, not because of this addition

Thanks! Good stuff!


Not able to verify new user after register

after registered user and received the verification email, click "verifify email" link, it had error to verify the email with the link.

Not able to verify user email is because the link doesn't have user_id, this is because it send the verification email before the user saved to database while creating the user.
To fix it we have to send the email after the user been created in the database.


Grasp generator issue

Hi all I have been trying to understand the grasp generator.
Trying to grasp a box using # finger gripper but getting this grasp generations :point_down:

where I want this grasp generation to get generated and executed :point_down:  , Some time its generated successfully and working but sometime its generating :point_up: this and executing. for which its not able to grab the object correctly in simulation.

python code used for generating grasps

    grasp_generator = stages.GenerateGraspPose("Generate Grasp Pose")
    grasp_generator.angle_delta = 1.5708
    grasp_generator.pregrasp = "open"
    grasp_generator.grasp = "close"
    grasp_generator.setMonitoredStage(task["current"])
    grasp_generator.object = object_name

Thanks

The GenerateGraspPose stage just creates Cartesian poses around the object's frame by rotating about the z-axis by default. Additionally some properties, like pregrasp and grasp posture for fingers are set, which can be used by neighbouring stages to actually actuate the fingers.

Thanks @rhaschke  I will check it out, first I thought it was issue with the object size but then its showed the same for bigger object,
there was a python doc for moveit task constructor, but it was showing 404,  can you help me with the link for that page ?

The docs are available here: https://moveit.github.io/moveit_task_constructor/api.html

I figured out that jupyter notebook don't have the sourced directory thus it was not able to get the model info, now its fetching error on certain grasp,

added gripper group name in grasp
added object name in grasp
added source ...devel.bash info the jupyter server.


niworkflows.utils.bids.collect_data failing to retrieve BOLD images

It seems that the original bug causing poldracklab/fmriprep#1481 is still there (https://neurostars.org/t/fmriprep-from-singularity-unboundlocalerror/3299/9?u=oesteban).
Not getting a 'bold' entry after the BIDSLayout query would explain the original UnboundLocalError symptom. @emdupre first noticed this during #285.
@effigies, any quick thoughts about what could've changed in pybids land that we did not account for in our end?

Seems like the original UnboundLocalError is not happening anymore. Please reopen in case of regression.


[NO QA] [TS migration] Migrate remaining Test files to TypeScript #38536

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/38536
PROPOSAL:
Tests

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/AndrewGable in version: 1.4.56-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/yuwenmemon in version: 1.4.56-8 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Update Gradle and SDK version. Also fixes a segfault.

With these changes, Vinyl Cast now builds under the current Android Studio (hedgehog).

Gradle 8.5
targetSdkVersion 34

@aschober Any chance you can merge this + release a new version here and an updated Android build on the Google Play Store?
https://play.google.com/store/apps/details?id=tech.schober.vinylcast.playstore
@kyleatmakrs If not and this project is abandoned then any chance you could release an updated fork under a different name?
Myself and others would love an updated version released on the Google Play Store, and preferably as an improved variant! 😉

Just trying to upstream some fixes I made for myself.  I don't have time to maintain a fork.
I emailed @aschober before sending the PR, and he suggested that he'd be interested in reviewing it.

@kyleatmakrs @Hedda appreciate the interest and contributions! I'm looking at the PRs now and my goal is to get an update published. May take me longer than usual to re-pick this up but my aim is to get an update published.


[v1.1][ISSUE-220] colab notebook demos for WnD, RNN-T and DE-NAS ASR

What changes were proposed in this pull request?

provide pip install notebook demo for WnD, RNN-T and DE-NAS ASR
Why are the changes needed?

support run colab notebook or non-docker env
How was this patch tested?

CI/CD covered test

@Peach-He

may be you should switch option1 and option 2, put pip install firstl2
clear pip install log, only show data process and training log


No support for Vite/Typescript

Hello, thanks for your package
I wanted to user this package as icon provider, but I am getting this error with Vite:
Uncaught ReferenceError: process is not defined
    s2 factoryWithTypeCheckers.js:170
    i2 factoryWithTypeCheckers.js:241
    exports factoryWithTypeCheckers.js:116
    Q index.js:9
    u context.js:34
    <anonymous> factoryWithThrowingShims.js:16

Why?
I also want to ask for Plug and List  icons.
Thanks

You can fix add define in your vite.config.ts
export default defineConfig({
  ...
  define: {
    'process.env': {},
  }
});

You can fix add define in your vite.config.ts
export default defineConfig({
  ...
  define: {
    'process.env': {},
  }
});

You can fix add define in your vite.config.ts
export default defineConfig({
  ...
  define: {
    'process.env': {},
  }
});

Yeah, it worked for me, but, why?

@SalahAdDin Vitejs not use process.env not exist in the environment Vitejs use import.meta.env then we're resolving the process.env like a object empty
More info of Vitejs => https://vitejs.dev/guide/env-and-mode.html


Nullability control for reference return values and parameters

For properties, nullability can be influenced with the RequiredAttribute.
How can I control whether the return value or certain parameters that are reference types are in fact meant to be non-nullable?

At the moment the nullability of the response or parameter cannot be controlled directly... And yes, I agree we need an attribute to do that. Any suggestion what to use? An own one (eg SwaggerRequiredAttribute) or an existing one from the .net fw?

ASP.NET Core used to have NotNullAttribute for a while, but no longer. I like that it's short when it needs to come before parameters and it seems less weird in the context of return values. Not a strong opinion though.
In case you don't know (I didn't until a few seconds ago), you can actually apply attributes to return values:
[return: SwaggerRequired]
SomeReferenceType Foo()

Maybe we should:

Add an own NotNullAttribute to NSwag.Annotations (also NotNullAttribute from R#/old ASP.NET will be supported), with support on parameters and return (as shown in your sample)
Add Nullable (default: true) property to SwaggerResponseAttribute from NSwag.Annotations

In case you don't know (I didn't until a few seconds ago), you can actually apply attributes to return values

Yes, I knew that but I don't like the syntax :)

Sounds all reasonable to me. And the return annotation syntax is a bit off, yes. I do like that it makes the same attribute type work for both parameters and return values.
Thinking of that, it may make sense to honor the attribute on properties also for consistency.

https://github.com/RSuter/NJsonSchema/commit/d408df54457290018761035303f9f897df60816d

Works great, thanks for the quick fix.


Fix tests on windows and the last eslint

Coverage remained the same at 100.0% when pulling 07a220c6a8bb72decf4b99b4b686ecbbc7dfda54 on TrySound:windows-tests into 9e2536714724cf9d01639428969d7001e3fc7b88 on adametry:master.

Thanks.


Focus is lost in current game after the move which is in the Study is made on the board

In a position below focus is on 5...ed5 (red below):

Now I have 2 different behaviours making a move 6.Qc2:

when Qc2 is made by using right arrow for next move in current game, the focus stays on 6.Qc2 and I can continue using arrows to go through the current game

when Qc2 is made by moving queen on the board focus is lost and arrows do not work anymore. We want the focus to stay on teh move we just made on the board 6.Qc2

Fixed.
Tech Note: the Main Window now has a KeyDown handler and passes the even to ActiveLine.  Also, the InactiveHighlightBrush has been set to HighlightBrush so that they show in the same color (event though the focus may be elsewhere)


Too much content

There is too much content to reasonably cover in the lectures. For example discussing Express and Simon Service takes longer than 50 minutes.

Dan, Mark, and Lee met and discussed the following options:

Remove WebSocket. This seems pretty essential to modern web dev and might not be the best option.
Create a 360 class and move web frameworks and more advanced topics to that course.

We reworked React to be earlier in the semester. That simplified a lot of things. Let's see how this goes.


Handling invalid JSON input…

I think this is more of a webargs issue than specific to flask-rest-api, but I also suspect that the most efficient way to address it, would be inside the API…
In case an invalid JSON input is provided (to a POST or PUT call), it is treated as an empty dict {}, no error is thrown, and, depending on the value of model_build_obj, it is either:

passed as is to the function's payload
passed to Marshmallow, which fails to generate an object (but doesn't give the most useful reason why)

From what I understand, this is due to webargs' flask parser loading the JSON silently:
        # Fail silently so that the webargs parser can handle the error
        if hasattr(req, "get_json"):
            # Flask >= 0.10.x
            json_data = req.get_json(force=force, silent=True)
        else:
            # Flask <= 0.9.x
            json_data = req.json
        if json_data is None:
            return core.missing

… from the comment in webarg's code, it seems the user is supposed to implement error handling to catch this case, although I don't quite see how it would be possible to know retrospectively that the core.missing being returned was the reason of an invalid JSON, rather than actually missing…
Do you have any idea how I could go about ensuring my API returns a proper 400 error?

@zedrdave, I think this can be closed thanks to https://github.com/marshmallow-code/webargs/issues/329, right?

@lafrech Yes, I think this is now handled correctly on webargs' side!


Greg Shaughn - finished assignment 1

Awesome work experimenting with Sklearn and facial feature recognition, Buttons and other things of that nature can be difficult to incorporate in a note book. We will explore programs of this level later in the course such as eigen faces and how they are created. Keep up the good work!

Good job working with a data set and cleaning it as needed. Some data sets you encounter in the wild will be very difficult to clean and extract useful information from. Continue practicing with handling of missing or corrupted values in data and you will go far. Good work!

Awesome work with crosstab and binning this data! This concept has been a struggling point for many this week but youve grasped it well! Great work this week on everything!!

Good work on this challenge!
You loaded the data set and named the features clearly, you encoded the survival as binary nicely.
The tables you've made are clear and concise and profile the data well, the plots provided show your process of finding the relationships in the data.
Your interpretations of the relationships in the data show understanding and are backed by your tables and plots. Good Work!


fix Persist storage_medium property for OlapTable and allow partition to inherit it

Persist storage_medium property for OlapTable and allow partition to inherit it
Proposed changes
Currently, 'storage_medium' property in create table statement, is not persisted.

If we set an partitioned table's storage_medium to SSD, the newly added partition will use cluster's default storage_medium(HDD if ont set).
If we set an un-partitioned table's storage_medium to SSD,  Doris creates an partition that use default storage_medium(HDD if ont set) for the table. That cause the storage_medium for un-partitioned table is not effective.

This PR persist storage_medium property for OlapTable and allow partition to inherit this table property.
Issue Number: close #xxx
Problem summary
Describe your changes.
Checklist(Required)

Does it affect the original behavior:

[ ] Yes
[ ] No
[ ] I don't know

Has unit tests been added:

[ ] Yes
[ ] No
[ ] No Need

Has document been added or modified:

[ ] Yes
[ ] No
[ ] No Need

Does it need to update dependencies:

[ ] Yes
[ ] No

Are there any changes that cannot be rolled back:

[ ] Yes (If Yes, please explain WHY)
[ ] No

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35.66 seconds
load time: 556 seconds
storage size:<PHONE_NUMBER>4 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230129114836_clickbench_pr_86231.html


⚠ Mobitopup has degraded performance

In 0171b9d, Mobitopup (https://napcard.voz.tech) experienced degraded performance:

HTTP code: 200
Response time: 5566 ms

Resolved: Mobitopup performance has improved in bde659f after 7 minutes.


Latest Docker version (0.2.15 - master) cannot parse state file

Hi, there's something wrong with the Docker version published with the latest tag (0.2.15, but possibly running master code?). It always gives a NPE when parsing the state file:
kafka-gitops -f state.yaml validate
java.lang.NullPointerException
	at java.util.Objects.requireNonNull(Objects.java:203)
	at com.devshawn.kafka.gitops.config.ManagerConfig_Builder.setConfigFile(ManagerConfig_Builder.java:221)
	at com.devshawn.kafka.gitops.config.ManagerConfig$Builder.setConfigFile(ManagerConfig.java:27)
	at com.devshawn.kafka.gitops.cli.ValidateCommand.generateStateManagerConfig(ValidateCommand.java:41)
	at com.devshawn.kafka.gitops.cli.ValidateCommand.call(ValidateCommand.java:25)
	at com.devshawn.kafka.gitops.cli.ValidateCommand.call(ValidateCommand.java:15)
	at picocli.CommandLine.executeUserObject(CommandLine.java:1783)
	at picocli.CommandLine.access$900(CommandLine.java:145)
	at picocli.CommandLine$RunLast.handle(CommandLine.java:2141)
	at picocli.CommandLine$RunLast.handle(CommandLine.java:2108)
	at picocli.CommandLine$AbstractParseResultHandler.execute(CommandLine.java:1975)
	at picocli.CommandLine.execute(CommandLine.java:1904)
	at com.devshawn.kafka.gitops.MainCommand.main(MainCommand.java:84)

This same command works fine on the image tagged with 0.2.15. I suspect recent changes on master caused this but have no way to verify this.

This is a regression which was introduced by https://github.com/devshawn/kafka-gitops/pull/68, making the configuration file a mandatory parameter (and then ignoring its content 🙃).

@n2taylor If you're still interested, there's a release with a fix for this at https://github.com/joschi/kafka-gitops/releases/tag/0.2.16.


Update wording for likes/dislikes

I think the current wording for likes and dislikes doesn't really match what a user would expect.
I would expect it to say Like or Dislike for a thumbs up or down to be more consistent with a user's expectation from other sites.
Change from:

Really Agree
Somewhat Agree
Somewhat Disagree
Really Disagree
To:
Super Like
Like
Dislike
Super Dislike

AB#59824

I believe we can improve the wording... but not a big fan of Andreas' "Super Like/Dislike" suggestion either...
I would have something like:

Love it!
Agree
Disagree
No way!

Hi @tiagov8,
As per our conversation, we have updated the wording to Love it! Agree Disagree No way
And updated the Love it! icon from a star to a heart.

Are you happy with the new Love it! icon or should we use a different icon/color?

Figure: Change "really agree" to "love it!"

Figure: Change to Love icon

Hey @christianmorfordwaitessw
As per our conversation on Teams,
Just agreed with @adamcogan and @jayden to change the color of Bookmarks to black (dark grey - same as Comments). But we are keeping the name.
We will have:

SSW Red: Love, Disagree, and No Way
Dark Grey: Bookmarks, and Comments
Green: Agree

PS. Please make sure all opacity and hovering effects are consistent between all 6 items

Hey @tiagov8
As per my conversation with @bradystroud:
After the above changes the icons are now black, black, red, green, red, and red. If this is the direction we're moving I would prefer that all the icons simply be red - including the bookmarks and comments icons. This would remove the out of place green and create consistency on the profile page, where all the icons are displayed together. This would also have a minimal impact on the Rules pages themselves, as only one rating can be selected at a time (so only one will be coloured at any time).
Overall though, and seeing the amount of trouble this rating system is giving the team, I would like to suggest that it be replaced with a 5 star rating system or a system of emojis 😍 🙂 🙁 😡

cc: @adamcogan
Hey @jaydenalchinssw, @tiagov8,
As per my conversation with @christianmorfordwaitessw, we agree that all the icons should be the same colour. On the profile page, they should be black. When you click on an icon in a rule (including the bookmark), it should go red.
This would make the rating UI consistent on rules and on the profile page.

What do you think of these?

Figure: All red icons on profile page 👎🏻

Figure: All black icons on profile page 👍🏻

Figure: Red "agree" icon on rules page

Hey @bradystroud

What do you think of these?

I prefer the red icons over the black! To me this creates welcome contrast with all the black text - when the icons are all black it's a little too much.

Team,
I agree with @jaydenalchinssw . Emojis might be the best solution to the icons' colours + it makes the rating clearly different from Bookmarks and Comments.
If we are keeping the icons though... I also agree with Jayden red is better than black.

cc: @adamcogan, @JackLeerson
Hi @tiagov8 @jaydenalchinssw,
As per my conversation with Adam and Jack, we decided that all the icons should all be black.
-Brady

cc: @adamcogan, @JackLeerson
Hi @tiagov8 @jaydenalchinssw,
As per my conversation with Adam and Jack L, we think that the icons should be between the word (e.g. bookmarks) and the count.

What do you think of this?

Figure: Changed the position of the icons

@bradystroud

What do you think of this?

I like this, it's definitely an improvement. However, as per our conversation with @tiagov8 I still think the icons here should be red.

Cc: @bradystroud @tiagov8
Hi @jaydenalchinssw
Done - I have implemented your suggestions, see below:

Figure: Changed reactions and profile rendering

Hi @JackLeerson ,
missed updating the "no way" icon on the rules' titles:

Hi @tiagov8,
Done - I updated the icon.

Figure: Changed from cross to ban icon
Thanks,
Brady


Context propagation using thread local storage

Hello everyone
In OpenTracing tutorial for Java the Scope operator and startActive function is used to propagate trace context using thread local storage.
Is there any equivalent function in cpp-client?
Regards
Mania

+1

@maniaabdi https://github.com/jaegertracing/jaeger-client-cpp/issues/113

Very much interested in seeing this feature, I've been using a tracing library at my workplace which was loosely based on OpenTracing and had this feature, and was surprised to see it absent in OpenTracing itself. It provides the easiest way to enable existing libraries to add tracing/carrier support without having to change their public APIs.

I'd like to try and tackle this using the ScopeManager approach in the Java version:
https://github.com/opentracing/opentracing-java/blob/master/opentracing-api/src/main/java/io/opentracing/ScopeManager.java
This requires mutable access to the span.
Since this is not explicitly a requirement of the Tracer but more like a utility, I'm thinking of keeping this outside of the Tracer interface as currently done in the Java implementation, but this can easily be added later.
The ScopeManager will guarantee thread local semantics and therefore not have any thread safety concerns.
I'll create a WIP PR shortly with a suggested interface prior to any implementation.


Support inlay virtual text option for mini.hipatterns

Contributing guidelines

[X] I have read CONTRIBUTING.md
[X] I have read CODE_OF_CONDUCT.md

Module(s)
hipatterns
Description
The new anticonceal feature in neovim 0.10 opens up the possibility of displaying inlay virtual text with the hipatterns extmarks instead of (or in addition to) just highlights. That way, we could for example display a dot of the corresponding color next to a hex code rather than coloring the code itself (which can sometimes conflict with other highlights).
I don't believe this should be the default but it doesn't sound too out of scope for this plugin to offer this as an option, since it already defines extmarks anyway.
I don't know if it would be best to hold off until 0.10 is released? I don't think that part of the API will change.

Thanks for the suggestion!
This is indeed planned and is already tracked in #340. It is reasonable to wait until this functionality is in stable release, as supporting Nightly feature usually comes with much maintenance burden.

@calops, this is now possible on latest main. There is a more general extmark_opts available which can utilize virt_text_pos = 'inline' feature.
And regarding using that to show colors: this is now possible with a new style = 'inline'.

@echasnovski thanks! This is looking much better now:


zos create2 expected uint256 value for salt.

In testing out zos create2 in zos@alpha I am finding that:
zos create2 SuperColdStorage1 --salt supersalt --query
returns the error:
Invalid salt supersalt, must be an uint256 value.
Is it true that salts need to be uint256 values? I would have expected from this that the salt value could be in bytes.

Solved. Indeed it needs to be a uint256 value.

@crazyrabbitLTC we could still support it easily by hashing the salt if it's non-numeric before passing it to the contract. Do you think using non-numeric salts would be a common use case?

@spalladino  I think yes, non-numeric salts would be a common use case. Even in this example here it feels like the salt should be non-numeric.

Got it, reopening then!


請問下載後要按什麼按鈕？

下載後並沒顯不掛載成功之類的，有什麼按鈕要按嗎？

The new version 3.5+ already supports Apple M1/M2/M3 and other chips.
Sorry for taking so long to update, because before that there was no good way to solve the compatibility problem of the new version of the system.
Fortunately, we have now been authorized by Apple to support the new version of the system kernel, so that we can fully support all macos systems through kernel drivers. Please experience it again, and if you have any questions, please update and communicate.


Adds support for the WebAuthn Register page

Adds the webauthn-register.ftl page

Thank you for your help! It has been implemented in v10


PWA not working with vite-based dev server

Command
serve
Is this a regression?

[X] Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was
Angular 16
Description
Serving a PWA with the default dev server is now broken.
Specifically, the vite dev server apparently mangles the files emitted by the previous build steps, but does not recompute the hashes stored in ngsw.json.
This results in the service worker being installed, but not really serving any file.
It is still possible to use the "old" (webpack-based) dev server that is apparently not affected by this.
Minimal Reproduction
Basically the steps are:

create a new app ng new
make it a PWA ng add @angular/pwa
configure it to start the service worker in dev
start it ng serve
open it in the browser http://localhost:4200/ and wait a few seconds (so that the service worker can initialize)
check the sw state at http://localhost:4200/ngsw/state

A full repo reproducing the issue is https://github.com/ranma42/pwa-repro
From this repo, the needed steps are:

choose the commit to start from (https://github.com/ranma42/pwa-repro/commit/a524b1a36049d77690ac6f37c14a56d1d501a042 to check the issue with vite, https://github.com/ranma42/pwa-repro/commit/6207a68be012eb680e000ff02f82b65c1d6b4b8d to compare with webpack)
install the dependencies npm install
start the server ng serve
open the app in the browser http://localhost:4200/ and wait a few seconds (so that the service worker can initialize)
check the sw state at http://localhost:4200/ngsw/state

Note that the repo contains both a revision that reproduces the issue and one that configures the build to use webpack for comparison, to show that in that case the dev server works as intended.
Also note that to properly check what is going on, you might want to clear the browser state by opening the inspector and (in Chrome-based browsers) going to Application -> Storage -> Clear site data
With the webpack dev server, http://localhost:4200/ngsw/state reports
NGSW Debug Info:

Driver version: 18.2.0
Driver state: NORMAL ((nominal))
Latest manifest hash: a9c562165e1a3b3bf67ea36a6e0537b1075767a8
Last update check: 38s35u

=== Version a9c562165e1a3b3bf67ea36a6e0537b1075767a8 ===

Clients: 946e5332-b1f0-466c-94fe-fac62101a798, 01aa5e79-986a-4910-bf75-eebbd80ad320

=== Idle Task Queue ===
Last update tick: 196u
Last update run: 27s738u
Task queue:

Debug log:

Exception or Error
For the vite devserver http://localhost:4200/ngsw/state reports

NGSW Debug Info:

Driver version: 18.2.0
Driver state: EXISTING_CLIENTS_ONLY (Degraded due to: Hash mismatch (cacheBustedFetchFromNetwork): http://localhost:4200/index.html: expected dcc35fd9e7cb2cbc5727f7dc941ab15beb5c8e94, got c628b20918af9ae65adf19ae7ef74c3c9d168ca7 (after cache busting)
Error: Hash mismatch (cacheBustedFetchFromNetwork): http://localhost:4200/index.html: expected dcc35fd9e7cb2cbc5727f7dc941ab15beb5c8e94, got c628b20918af9ae65adf19ae7ef74c3c9d168ca7 (after cache busting)
    at PrefetchAssetGroup.cacheBustedFetchFromNetwork (http://localhost:4200/ngsw-worker.js:476:21)
    at async PrefetchAssetGroup.fetchFromNetwork (http://localhost:4200/ngsw-worker.js:451:19)
    at async PrefetchAssetGroup.fetchAndCacheOnce (http://localhost:4200/ngsw-worker.js:430:21)
    at async http://localhost:4200/ngsw-worker.js:535:9
    at async http://localhost:4200/ngsw-worker.js:521:9
    at async http://localhost:4200/ngsw-worker.js:521:9
    at async http://localhost:4200/ngsw-worker.js:521:9
    at async http://localhost:4200/ngsw-worker.js:521:9
    at async PrefetchAssetGroup.initializeFully (http://localhost:4200/ngsw-worker.js:520:7)
    at async http://localhost:4200/ngsw-worker.js:924:11)
Latest manifest hash: 92656589d404e75dc7df6ccfe2840f76f7867faa
Last update check: 6s797u

=== Version 92656589d404e75dc7df6ccfe2840f76f7867faa ===

Clients:

=== Idle Task Queue ===
Last update tick: 4s224u
Last update run: never
Task queue:
 * activate: cleanup-old-sw-caches
 * init post-load (cleanup)

Debug log:

[6s755u] Error(Hash mismatch (cacheBustedFetchFromNetwork): http://localhost:4200/index.html: expected dcc35fd9e7cb2cbc5727f7dc941ab15beb5c8e94, got c628b20918af9ae65adf19ae7ef74c3c9d168ca7 (after cache busting), Error: Hash mismatch (cacheBustedFetchFromNetwork): http://localhost:4200/index.html: expected dcc35fd9e7cb2cbc5727f7dc941ab15beb5c8e94, got c628b20918af9ae65adf19ae7ef74c3c9d168ca7 (after cache busting)
    at PrefetchAssetGroup.cacheBustedFetchFromNetwork (http://localhost:4200/ngsw-worker.js:476:21)
    at async PrefetchAssetGroup.fetchFromNetwork (http://localhost:4200/ngsw-worker.js:451:19)
    at async PrefetchAssetGroup.fetchAndCacheOnce (http://localhost:4200/ngsw-worker.js:430:21)
    at async http://localhost:4200/ngsw-worker.js:535:9
    at async http://localhost:4200/ngsw-worker.js:521:9
    at async http://localhost:4200/ngsw-worker.js:521:9
    at async http://localhost:4200/ngsw-worker.js:521:9
    at async http://localhost:4200/ngsw-worker.js:521:9
    at async PrefetchAssetGroup.initializeFully (http://localhost:4200/ngsw-worker.js:520:7)
    at async http://localhost:4200/ngsw-worker.js:924:11) initializeFully for 92656589d404e75dc7df6ccfe2840f76f7867faa

Your Environment
$ ng version

     _                      _                 ____ _     ___
    / \   _ __   __ _ _   _| | __ _ _ __     / ___| |   |_ _|
   / △ \ | '_ \ / _` | | | | |/ _` | '__|   | |   | |    | |
  / ___ \| | | | (_| | |_| | | (_| | |      | |___| |___ | |
 /_/   \_\_| |_|\__, |\__,_|_|\__,_|_|       \____|_____|___|
                |___/

Angular CLI: 18.2.0
Node: 20.13.0
Package Manager: npm 10.5.2
OS: linux x64

Angular: 18.2.0
... animations, cli, common, compiler, compiler-cli, core, forms
... platform-browser, platform-browser-dynamic, router
... service-worker

Package                         Version
---------------------------------------------------------
@angular-devkit/architect       0.1802.0
@angular-devkit/build-angular   18.2.0
@angular-devkit/core            18.2.0
@angular-devkit/schematics      18.2.0
@schematics/angular             18.2.0
rxjs                            7.8.1
typescript                      5.5.4
zone.js                         0.14.10

Anything else relevant?
No response

https://github.com/angular/angular/issues/23613 is related: basically it covers all of the cases in which a proxy mangles the files, not just the mangling performed by the vite dev server. IIUC the conclusion is that the expected approach is to ensure that the file digests match those listed in ngsw.json; even though disabling the hash check has been proposed, it looks like it is considered too fragile.

#28225 might be related

The root cause of the issue is that Vite will transform all JS, CSS and HTML files during request time, this will cause of the hashes in the manifest to be invalid.


Refactor internal sample to use tuple for labels

This preserves the order of labels at all times. The only place a dict
of labels was used in the public api is in get_sample_value(), where we
convert to dict for the comparison, which seems reasonable for
a testing helper.
Originally tried just using OrderedDict, for the best of both worlds,
but sadly python 2.6 doesn't have OrderedDict. If dropping 2.6 support is on the table, then just using OrderedDict would probably be a better change, as you'd get the ordering and the convenient dict API
Signed-off-by: Simon Davy<EMAIL_ADDRESS>

There is a pypi ordereddict module, but I felt that adding a dependency for py2.6 support was a worse option.

The only place a dict of labels was used in the public api is in get_sample_value()

They're used in more places than that. The parser output is all public, as are the samples of the Metric types. So this would be a breaking change for many users.
I'd suggest a more targeted change to do what you need for ordering for multiproc.

Would you be OK with a multiproc change that didn't have any effect on py2.6? Because I'm not sure of any other way to do it.


Priority not persisted after enqueuing

I'm using a SimplePriorityQueue<TItem, TPriority>, where TItem : GenericPriorityQueueNode<TPriority> and TPriority : IComparable<TPriority>; i.e., my Node class is derived from GenericPriorityQueueNode and uses a custom struct as the priority.
The prioritization seems to work correctly. But immediately after calling .Enqueue(item, priority), the Priority property of the queued item iis set to the default value, instead of the value priority which was passed to Enqueue.
Have I misunderstood how to use these objects? I'm implementing D* and was hoping to get the Key value from the Priority property.
Minimal working example (included the whole Key struct in case it's important):
public readonly struct Key(float k1, float k2) : IComparable<Key>
{
    public readonly float K1 = k1;
    public readonly float K2 = k2;

    public static bool operator <(Key left, Key right) => left.K1 < right.K1 || (left.K1 == right.K1 && left.K2 < right.K2);
    public static bool operator >(Key left, Key right) => left.K1 > right.K1 || (left.K1 == right.K1 && left.K2 > right.K2);
    public static bool operator ==(Key left, Key right) => left.K1 == right.K1 && left.K2 == right.K2;
    public static bool operator !=(Key left, Key right) => !(left == right);

    public int CompareTo(Key other)
    {
        return this < other ? -1 : this > other ? 1 : 0;
    }

    public override bool Equals(object? @object)
    {
        return @object is Key key && this == key;
    }

    public override int GetHashCode()
    {
        return HashCode.Combine(this.K1, this.K2);
    }

    public override string ToString()
    {
        return $"{this.K1}, {this.K2}";
    }
}

public sealed class Node : GenericPriorityQueueNode<Key>
{
    public Node() { }
}

class Program
{
    static void Main()
    {
        var queue = new SimplePriorityQueue<Node, Key>();
        queue.Enqueue(new Node(), new Key(1, 1));
        // inspect the queue here and notice that item 0 has Priority = Key {0, 0};
    }
}

I'm not able to reproduce this issue.  Specifically, I added this unit test, which passes
       public readonly struct TestKey : IComparable<TestKey>
       {
           public readonly float Key1;
           public readonly float Key2;

           public TestKey(float key1, float key2)
           {
               Key1 = key1;
               Key2 = key2;
           }

           public static bool operator <(TestKey left, TestKey right) => left.Key1 < right.Key1 || (left.Key1 == right.Key1 && left.Key2 < right.Key2);
           public static bool operator >(TestKey left, TestKey right) => left.Key1 > right.Key1 || (left.Key1 == right.Key1 && left.Key2 > right.Key2);
           public static bool operator ==(TestKey left, TestKey right) => left.Key1 == right.Key1 && left.Key2 == right.Key2;
           public static bool operator !=(TestKey left, TestKey right) => !(left == right);

           public int CompareTo(TestKey other)
           {
               return this < other ? -1 : this > other ? 1 : 0;
           }

           public override bool Equals(object @object)
           {
               return @object is TestKey key && this == key;
           }

           public override int GetHashCode()
           {
               return Key1.GetHashCode() ^ Key2.GetHashCode();
           }

           public override string ToString()
           {
               return $"{this.Key1}, {this.Key2}";
           }
       }

       public sealed class TestNode : GenericPriorityQueueNode<TestKey>
       {
           public TestNode() { }
       }

       [Test]
       public void TestQueueWithCustomKey()
       {
           TestNode node1 = new TestNode();
           TestNode node2 = new TestNode();
           TestNode node3 = new TestNode();
           TestKey key1 = new TestKey(1, 0);
           TestKey key2 = new TestKey(2, 0);
           TestKey key3 = new TestKey(3, 0);

           SimplePriorityQueue<TestNode, TestKey> queue = new SimplePriorityQueue<TestNode, TestKey>();
           queue.Enqueue(node3, key3);
           queue.Enqueue(node1, key1);
           queue.Enqueue(node2, key2);

           Assert.IsTrue(queue.IsValidQueue());
           Assert.AreEqual(key1, queue.GetPriority(node1));
           Assert.AreEqual(key2, queue.GetPriority(node2));
           Assert.AreEqual(key3, queue.GetPriority(node3));

           Assert.AreEqual(node1, queue.Dequeue());
           Assert.AreEqual(node2, queue.Dequeue());
           Assert.AreEqual(node3, queue.Dequeue());
       }

Less importantly, using a custom node class that extends GenericPriorityQueueNode shouldn't be necessary with SimplePriorityQueue. It won't hurt anything, it's just unnecessary.


icons: Switch to conventional track skip icons

Change the track skipping buttons from ⏩, ⏪ to ⏭, ⏮. The shapes are
from the SF Pro font, same as the old icons.
The icons ⏩, ⏪ conventionally denote fast-forward and rewind (seeking
within a single track). By contrast, the icons ⏭, ⏮ denote track
skipping (moving to the next or previous track).
See for instance: https://en.wikipedia.org/wiki/Media_control_symbols#Symbols

Could you post a screenshot of the new svgs?

Hi @jforberg, thanks for the contribution! Can you please fill the names of the icons in the comment on top of the respective const? Merging afterwards.

Hi @jpochyla, I updated the icon names as requested


Allow "=" in config values

After the PR we will be able to pass e.g. Azure keys as command line arguments.
These mime-encoded-data strings end in one or more "=" - e.g.:
azurekey=Eby8vdM02xNOcqFlqUwJPLlmEtlCDXJ1OUzFT50uSRZ6IFsuFq2UVErCz4I6tq/K1SZFPTOtr/KBHBeksoGMGw==

Nice one @quantumagi ! Can you please add a couple of unit tests to this?

Unit tests have been added.

Very nice, thank you


mac fixes + remove debugging code

fixes new actor/interface/project on macos
fixes test build on macos
remove debugging code
Signed-off-by: stevelr<EMAIL_ADDRESS>

@stevelr looks like this failed the fmt check. Classic.

apparently my mac dev environment isn't fully updated: example - the rustfmt errors and the github signature  -Can someone else please check on macos?  thanks. M1 vs x86 shouldn't make a difference since it's an OS file path issue.


Correcting mistakes in README.md again because the README.md was updated

I tried to catch mistakes there and here is the pull request again because the README.md was updated without correcting the mistakes

It looks like a space-mismatch
I think you could click on the Resolve Conflicts button(it should pop up for you) and remove the stuff in angle brackets

more info-
https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/resolving-a-merge-conflict-on-github

@MidouWebDev it looks like there are conflicts again.  Do you think you could just fetch the latest from master and verify the readme still has any mistakes, or close this PR if it seems ok?

Closing it favor of new updates.


Cut new build to pypi?

I was wondering if you could please incorporate https://github.com/puiterwijk/flask-oidc/pull/72 and get a new build on PyPi? Last one was in April. Thank you!

the #49 impediments the dev with keycloak, is there a plan for a new release?


colour errors different to standard output in the console?

Current implementation makes difficult to pick out errors in large process outputs in the console.

Agreed, having regular messages be the same color as warnings and errors is challenging.


Support client objdef loading from xml file

Refer #200.

retest IMG CI (libcoap)

Job stalling on jenkins for erbium - ran tests locally and everything looked ok. Will merge anyway.


adding performance tracking

Added fps and prediction time rolling averages in display (through new CircularBuffer class)
Fixed up some display issues

This change is

Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, 2 unresolved discussions.

demos/teachable_gaming/teachable_gaming.ts, line 259 at r1 (raw file):

  private async animate() {
    const frameTimeStart = performance.now();
    if (this.previousFrameTime) {

!= null

demos/teachable_gaming/teachable_gaming.ts, line 331 at r1 (raw file):

      // Log the environment first time through prediction.
      if (!this.loggedEnv) {
        console.log(ENV);

put a header string here
console.log('Evaluated environment flags:');

Comments from Reviewable

Review status: 1 of 2 files reviewed at latest revision, 2 unresolved discussions.

demos/teachable_gaming/teachable_gaming.ts, line 259 at r1 (raw file):
Previously, nsthorat (Nikhil Thorat) wrote…
!= null

Done.

demos/teachable_gaming/teachable_gaming.ts, line 331 at r1 (raw file):
Previously, nsthorat (Nikhil Thorat) wrote…
put a header string here
console.log('Evaluated environment flags:');

Done.

Comments from Reviewable


Can only install one of: symfony/process[v2.8.0, v3.0.6].

I'm trying to use nmap in laravel 5.2. symfony/process v3.0.6 already installed as dependency for laravel 5.2.
nmap require synfony/process ~2.0 . I can't use nmap because dependency conflict problem.

This has been solved in #21 but there is no new release yet, so it requires to use dev-master in composer.json.
/cc: @willdurand

just pushed a new tag, sorry for the delay :(


Added dockerfile and install shell script

Adding dockerfile and install shell script to load integration (currently only one) from disk
updating: #38

See my comments for #41


Is it working?

I installed this app in my phone..
But it didn't work...

have you provided audio permission in apps setting? i haven't added it to app so, you have to provide it through app settings.

Oh...
Now it's working...
It needs the permission...


Containers - Change entrypoint.sh to use paths relative from the entrypoint.sh file itself, so we operate from the workspace files instead of the .ansible path.

          Change this to use paths relative from the entrypoint.sh file itself, so we operate from the workspace files instead of the .ansible path.

Originally posted by @ClausHolbechArista in https://github.com/aristanetworks/ansible-avd/pull/3179#discussion_r1387820705

Assign this one to me please.


Refactored storage of forecasts within System.

Fixes issue #238.  This is incomplete because the parsing code produces forecasts that match the spec'd behavior in #238.

We should merge https://github.com/NREL/PowerSystems.jl/pull/247 and rebase to make the tests pass.


WARN: using htmlmin besides artesaos/defender and other packages

Hello,
i have found a bug when using GrahamCampbell/Laravel-HTMLMin and artesaos/defender together.
artesaos/defender registers some custom blade directives like @shield and @endshield... when using the option "Automatic Blade Optimizations" the directives will be printed instead of replaced by php code.

Looks like that package is registering them in the wrong place. It must do it in boot, not register,


Initial build for 0.2.3 ❄

laszip-python 0.2.3 :snowflake:
Destination channel: Snowflake
Links

PKG-3900
Upstream repository

Explanation of changes:
Initial build. Note that the package name on PyPI is laszip, but in conda-forge and defaults, laszip is the C+ library.
Also note that this feedstock doesn't exist on conda-forge.

Linter check found the following problems:
ERROR conda.cli.main_run:execute(124): `conda run conda-lint /tmp/abs_degatmh9ba/clone` failed. (See above for error)
The following problems have been found:
===== WARNINGS =====

clone/recipe/meta.yaml:29: host_section_needs_exact_pinnings: Linked libraries host should have exact version pinnings.
===== Final Report: =====
0 Errors and 1 Warning were found

Linter check found the following problems:
ERROR conda.cli.main_run:execute(124): `conda run conda-lint /tmp/abs_f2qgmsc5qw/clone` failed. (See above for error)
The following problems have been found:
===== WARNINGS =====

clone/recipe/meta.yaml:30: host_section_needs_exact_pinnings: Linked libraries host should have exact version pinnings.
===== Final Report: =====
0 Errors and 1 Warning were found

Linter check found the following problems:
ERROR conda.cli.main_run:execute(124): `conda run conda-lint /tmp/abs_0c_gcka4fq/clone` failed. (See above for error)
The following problems have been found:
===== WARNINGS =====

clone/recipe/meta.yaml:34: host_section_needs_exact_pinnings: Linked libraries host should have exact version pinnings.
===== Final Report: =====
0 Errors and 1 Warning were found

Linter check found the following problems:
ERROR conda.cli.main_run:execute(124): `conda run conda-lint /tmp/abs_81i9f_e_am/clone` failed. (See above for error)
The following problems have been found:
===== WARNINGS =====

clone/recipe/meta.yaml:34: host_section_needs_exact_pinnings: Linked libraries host should have exact version pinnings.
===== Final Report: =====
0 Errors and 1 Warning were found

Linter check found the following problems:
ERROR conda.cli.main_run:execute(124): `conda run conda-lint /tmp/abs_8b26jsjvnh/clone` failed. (See above for error)
The following problems have been found:
===== WARNINGS =====

clone/recipe/meta.yaml:34: host_section_needs_exact_pinnings: Linked libraries host should have exact version pinnings.
===== Final Report: =====
0 Errors and 1 Warning were found

Linter check found the following problems:
ERROR conda.cli.main_run:execute(124): `conda run conda-lint /tmp/abs_0c_s7ac1j_/clone` failed. (See above for error)
The following problems have been found:
===== WARNINGS =====

clone/recipe/meta.yaml:34: host_section_needs_exact_pinnings: Linked libraries host should have exact version pinnings.
===== Final Report: =====
0 Errors and 1 Warning were found

Linter check found the following problems:
ERROR conda.cli.main_run:execute(124): `conda run conda-lint /tmp/abs_d7ielv09xc/clone` failed. (See above for error)
The following problems have been found:
===== WARNINGS =====

clone/recipe/meta.yaml:34: host_section_needs_exact_pinnings: Linked libraries host should have exact version pinnings.
===== Final Report: =====
0 Errors and 1 Warning were found


Integrate apply() and type() improvements from https://github.com/torch/nn/pull/303

nn.Module now has an :apply() method, so use that instead of gmodule's custom apply().
nn.Module:type() now preserves sharing semantics, but I have to pass a tensorCache argument through for gmodule to support it.
Add missing method updateParameters

I also added self.modules to gmodule, which should make some things easier. It would be great if gmodule could inherit from nn.Container instead of nn.Module, as a lot of the functionality here is duplicated from nn.Container.
Note: this PR depends on https://github.com/torch/nn/pull/303.

cc @koraykv what yu think?

ping ping!

I am fine with this PR.
And, I have a question. Is there a reason gModule is not inheriting from nn.Container? When I first wrote it, there was no nn.Container, maybe we should make it inherit from nn.Container. Any objections?

I agree, gModule should inherit from nn.Container.

What is blocking this merge? @koraykv did you want me to change gModule to inherit from nn.Container in this PR? I was thinking it belonged in its own PR. Also #82 does what you asked. Please just pick which order to merge this and #82 and I will fix the conflicts. Thanks!

I think we should merge this one first and then #82 to inherit from nn.Container. Thanks a lot @adamlerer .

Ready for merge @soumith, thanks!

thanks adam.