Clue bug

Was doing an Elite clue. Clue feature couldn't tell me where the coordinate was. Switched to OSB to quickly get the clue done. When I switched back to RuneLite it still thought I had the Elite Clue so the box that told me to go to the highlighted area or whatever was still up and I can't get rid of it even if I log in and out or turn the feature on or off.

Can you post a screenshot?

This will be closed by #1493

Fixed in #1493


Fix textual CLI not working, drop Python 3.7.

The textual CLI tool didn't work because importlib_metadata wasn't in the dependencies.
It must have worked coincidentally before, since that was specified in Textual's own dependencies until recently.
Drop Python 3.7 support, update to use importlib.metadata module from 3.8+.

@willmcgugan Bumped to 1.3.0

Ta


Rdk 33900 network thunder plugin document update

The current network thunder plugin's document is not as per the latest code.
Update the network thunder plugin's document.
Jira ID:https://ccp.sys.comcast.net/browse/RDK-33900
@vijs  could you please review this pull request.

@tnykkn
I have addressed and updated the .md and .json files.
Please review once.


Filters for Schemas/Users broken in 6.1.3

System information:

Operating system: Windows 7 x64 SP1
DBeaver version: 6.1.3 (CE)
Additional extensions: n/a

Connection specification:

Database name and version: All
Driver name: All

Describe the problem you're observing:
Under Edit Connection -> General -> Filters -> Schemas/Users, the "Enable" option does not stay checked between restarts of DBeaver.
Seems to be related to a configuration setting not being stored or recorded correctly under the new configuration style introduced in 6.1.3.
Steps to reproduce, if exist:

Load DBeaver, under any database type (I tried both Teradata and Postgres), click Edit Connection -> General -> Filters -> Schemas/Users.
Click "Enable", then create an Include or Exclude filter list. I created an Exclude of '%' to Filter everything.
Save the Filter list and press OK.
DBeaver offers to reconnect to database to apply new settings, press Yes to reconnect.
Observe that new settings have been applied and the Filter is applied correctly.
Restart DBeaver and connect to same database.
Notice that Filter is NOT applied.

Thanks :)

Duplicate of #6414
This bug was fixed in 6.1.4

Ah, apologies, DBeaver "check for updates" still wasn't showing that there was a newer version available, so didn't check in 6.1.4 first.
Cheers!


github auth via token

readme says that tokens can be used, but checking the code I don't see any reference to where the auth token would be configured.
is the readme a bit premature?

:+1:

:+1:

This is still an issue.  And a simple fix.  If you're using auth tokens, this is the issue in grunt-release.js.
      request
        .post('https://api.github.com/repos/' + options.github.repo + '/releases')
        .auth(process.env[options.github.usernameVar], process.env[options.github.passwordVar])
        .set('Accept', 'application/vnd.github.manifold-preview')
        .set('User-Agent', 'grunt-release')
        .send({
          'tag_name': tagName,
          name: tagMessage,
          prerelease: type === 'prerelease'
        })

TL;DR - .auth(process.env[options.github.usernameVar], '') where options.github.usernameVar is your auth token fixes it.
The plugin expects the following to exist in your grunt task configuration
            github: {
                repo: 'your_name/your_repo',
                usernameVar: 'YOUR_NAME',
                passwordVar: 'YOUR_PASS'
            }

If you want to use a key, your grunt task may look like this
            github: {
                repo: 'your_name/your_repo',
                usernameVar: 'YOUR_KEY'
            }

Which fails because options.github.passwordVar isn't set in the .auth() method above.
To make things work until a fix, you must do the following:
            github: {
                repo: 'your_name/your_repo',
                usernameVar: 'YOUR_KEY',
                passwordVar: 'YOUR_PASS'
            }

And set the environment variable YOUR_PASS=''

We now have an option github.accessToken which you can set with your token. This just landed in 111eaf4a5e6d4a305196e10c0d58e157de8abc68. Release will be here today.
Thank you so much for your input and sorry for the late response.


Contains query for multiple permissions should be separated per permission

The problem with the current contains query is that the contains is a full set comparison, but if you had

Role 1: Perm 1
Role 2: Perm 2
UserRole: Perm 1 and 2

The current query includes {Perm 1, Perm 2}, but it'll return the user does not have permission because neither of the roles have both perms simultaneously. Essentially, you need to call contains for each perm: {Perm 1} is a query and {Perm 2} is another. Ref contains query: https://docs.djangoproject.com/en/4.1/ref/contrib/postgres/fields/#contains
The nice thing about async ORM is that we can use asyncio.gather for parallel querying.

Nevermind, it's resolved: contained_by (ref: https://docs.djangoproject.com/en/4.1/ref/contrib/postgres/fields/#contained-by)


[Nomination] Again validator web34ever! He is unstoppable!

Who are you nominating?
Validator web34ever - https://t.me/HeKit
What are you nominating them for?
For the creating of russian translation of "Smart Contract ERC20 Tutorial on Juno testnet"  - Инструкция по созданию Смарт контракта ERC20 в Juno testnet lucina
It really helps to russian-speaking developers and not only to deploy smart-contract on Juno Network, and bring more decentralization to the Network by involving in the process people who don't speak english very good. It's a big value for the community!
Please provide links to their work.
https://github.com/cybernekit/JunoSmartContract/blob/main/READMERUS.md

If you have multiple entries for the same person, please put them all in the same ticket. Makes it easier to review. THANKS.

I will try, but the problem, that people do something for Juno at the different time.
Do I need to edit my previous nominations?

I will try, but the problem, that people do something for Juno at the different time.
Do I need to edit my previous nominations?

No need to edit the previous one, just keep in mind for the future. : )
You can always edit or add comments to the previous nominations.

Duplicate of #34


Please add support for stable OpenVZ version (2.6.32) to libcontainer

Hello!
We very interesting in this feature. Could you add it? We can participate in development but need some help from Parallels team because OpenVZ interfaces is not documented fully.

There is already PR for merging libct support. I think that libct will work on openvz.

Are you sure? I do not know about support of OpenVZ from libct side. Xemul, could you help us?

Sure. We had the openvz "backend" in libct on the early stages, then @avagin concentrated on fixing issues to have the libct core merged. Once this is done we will resurrect the openvz backend.  I guess @mrunalp and @crosbymichael can tell us about their plans about merging it in (pr #434 ).

I know that @avagin did some fixes last week and I need to retry it again on Fedora. I should be test them tomorrow and report here.
Sent from my iPhone

On May 25, 2015, at 10:05 PM, Pavel Emelyanov<EMAIL_ADDRESS>wrote:
Sure. We had the openvz "backend" in libct on the early stages, then @avagin concentrated on fixing issues to have the libct core merged. Once this is done we will resurrect the openvz backend. I guess @mrunalp and @crosbymichael can tell us about their plans about merging it in (pr #434 ).
—
Reply to this email directly or view it on GitHub.

Awesome :) Thanks!


still crashes?

it still crashes my game even after the updates, only when i run it before the game starts though.

What Server

EUNE

It means your game is loading slowly from disk to ram. Inject the cheat after the game starts.


Refresh highlight-column filter fix

Desired Outcome
Refresh button will use the column\highlight filters.
Implemented Changes
Changed the Form1 - Initialize function.

Now when using the refresh button it will use the filters


Read cron value from a Setting or a RAILS variable

I have a configuration as below in config/sidekiq.yml.erb
   do_some_work:
      every: '1h'
      class: 'DoSomeWork

Now I want the value of every key should change based on the environment.  I have defined a variable like this Settings.do_some_work_polling_interval: 1h under config/settings/development.yml and trying to use this
    do_some_work:
      every: Settings.do_some_work_polling_interval
      class: 'DoSomeWork

But while starting sidekiq, it gives an error : not a duration "Settings.do_some_work_polling_interval"
How can I make config/sidekiq.yml.erb to read values from variables instead of hardcoding.
This is a genuine requirement as I would want to run a job with different intervals based on my environment i.e. dev, qa, staging and production

if you do something like
every: <%= Settings.do_some_work_polling_interval %>

does it work?
If you put it just a string it won't be evaluated, it needs to be in <%= %> to be evaluated, it's not even something related to sidekiq

@vipulvkp did the suggestion work?


Bug: Unable to use the latest release of the GitHub action

What happened?
New version 1.10.0 was released 3 days ago: https://github.com/Azure/k8s-deploy/releases/tag/4.10.0
However, in the GitHub action release page, the new version is not listed:

Yet, the latest tag is visible on when the 'Use latest version' option is selected:

I am unable to resolve the latest version:

Also, unable to retrieve lates release by the following links:
https://github.com/marketplace/actions/deploy-to-kubernetes-cluster?version=v10.0
https://github.com/marketplace/actions/deploy-to-kubernetes-cluster?version=10.0
https://github.com/marketplace/actions/deploy-to-kubernetes-cluster?version=latest
Version

[X] I am using the latest version

Runner
self-hosted
Relevant log output

Does is have to do with the new release workflow?: https://github.com/Azure/k8s-deploy/pull/297

this appears to be related to an issue with the updated release workflow missing the lib directory, which should be fixed by https://github.com/Azure/action-release-workflows/pull/1
patching now with https://github.com/Azure/k8s-deploy/pull/301

release v4.10.0 has been regenerated, and I can see the /lib directory with run.ts now, so that should get us back up and running. @bramdehart please let us know when you have a chance to try it out

@davidgamero  I will try but am mostly sure it still wouldn't work. The version is still not listed in the github action marketplace page. See for exameple

Were the latest version is also listed as the tag
This is not the case with this action

Also you can spot the formatting difference in tagging, with and without 'v' since release refactor.

@davidgamero I can confirm that is now works. Still weird that is not listed as seperate tag on the Github Action page on marketplace. Issue resolved :)

I see what you mean with the missing tag on the action page.


updates generated code for MachineSet

What this PR does / why we need it: this PR updates generated code for MachineSet type
Special notes for your reviewer:
Release note:

NONE

@kubernetes/kube-deploy-reviewers

FYI @rsdcastro, @mrIncompetent

/lgtm


Chore fix docs examples master

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix for the docs-app
What is the current behavior? (You can also link to an open issue here)
Docs app included incorrect files for the embedded / plnkr examples
Please check if the PR fulfills these requirements

[ ] The commit message follows our guidelines: https://github.com/angular/angular.js/blob/master/CONTRIBUTING.md#commit-message-format
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

Other information:
I would like to test that the plnkrs open with the reference to the correct files (code.angularjs.org), but I think this is out of scope for an e2e test / too difficult. We should probably test the plnkrOpener directive instead.

I think this commit broke https://docs.angularjs.org/
Something broke https://docs.angularjs.org/ last night and it is making it difficult for users on Stackoverflow that view answers about AngularJS that link to it.

See: https://github.com/angular/angular.js/issues/16194


Check underlying OS

Check to see how #37 should be implemented depending on the OS.

Implemented in commit 101.


no work Synology Camera

Make sure you are running the latest version of Home Assistant before reporting an issue.
You should only file an issue if you found a bug. Feature and enhancement requests should go in the Feature Requests section of our community forum:
Home Assistant release (hass --version):
0.33.2
Python release (python3 --version):
3.3.4
Component/platform:
Synology Camera
Description of problem:
16-11-27 07:18:33 homeassistant.components.camera: Error while setting up platform synology
Traceback (most recent call last):
File "/srv/hass/hass_venv/lib/python3.4/site-packages/homeassistant/helpers/entity_component.py", line 145, in _async_setup_platform
entity_platform.async_add_entities, discovery_info
File "/srv/hass/hass_venv/lib/python3.4/site-packages/homeassistant/components/camera/synology.py", line 118, in async_setup_platform
syno_auth_url
File "/srv/hass/hass_venv/lib/python3.4/site-packages/homeassistant/components/camera/synology.py", line 206, in get_session_id
return auth_resp['data']['sid']
KeyError: 'data'
Expected:
Problem-relevant configuration.yaml entries and steps to reproduce:
camera:

platform: synology
url: https://<IP_ADDRESS>:5001
username: admin
password: 123456
verify_ssl: false

Traceback (if applicable):

Additional info:

It looks like this has something to do with how aiohttp is encoding these params (or possibly the mime-type Synology has chosen?), I get:
WARNING:aiohttp.client:Attempt to decode JSON with unexpected mimetype: text/plain; charset="utf-8"

...with the same error as @cuihaijun
But when I replace this: https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/camera/synology.py#L176,L177
With vanilla urllib encoding: login_url + '?' +  urllib.parse.urlencode(auth_payload), it works!

On second thought what's almost certainly going on is that the password is being escaped, I have a bunch of funky characters in mine. So the easy fix is to make a new Synology user with a simpler password (letters/numbers only).

I was running into the same error but then I realized I was using my Syno username and password and didn't actually have any users set up in Surveillance Station. Once I created a Spectator-level user in Surveillance Station for hass, it worked.


Improve performance of filter_dict

Which issue does this PR close?

Closes #2062.
Rationale for this change

filter context string dictionary (kept 1/2)
                        time:   [21.995 us 22.197 us 22.408 us]
                        change: [-2.3630% -1.2909% -0.2122%] (p = 0.02 < 0.05)
                        Change within noise threshold.
Found 8 outliers among 100 measurements (8.00%)
  8 (8.00%) high mild

filter context string dictionary high selectivity (kept 1023/1024)
                        time:   [10.567 us 10.650 us 10.735 us]
                        change: [-3.2419% -2.2248% -1.2276%] (p = 0.00 < 0.05)
                        Performance has improved.

filter context string dictionary low selectivity (kept 1/1024)
                        time:   [910.91 ns 917.49 ns 924.83 ns]
                        change: [-23.778% -22.819% -21.986%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 2 outliers among 100 measurements (2.00%)
  1 (1.00%) high mild
  1 (1.00%) high severe

filter context string dictionary w NULLs (kept 1/2)
                        time:   [53.386 us 53.870 us 54.349 us]
                        change: [-5.8932% -4.8921% -3.8850%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 2 outliers among 100 measurements (2.00%)
  2 (2.00%) high mild

filter context string dictionary w NULLs high selectivity (kept 1023/1024)
                        time:   [20.187 us 20.381 us 20.576 us]
                        change: [-2.2931% -1.2510% -0.2547%] (p = 0.02 < 0.05)
                        Change within noise threshold.
Found 6 outliers among 100 measurements (6.00%)
  5 (5.00%) high mild
  1 (1.00%) high severe

filter context string dictionary w NULLs low selectivity (kept 1/1024)
                        time:   [1.2670 us 1.2742 us 1.2816 us]
                        change: [-24.367% -23.820% -23.263%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 4 outliers among 100 measurements (4.00%)
  4 (4.00%) high mild

What changes are included in this PR?

Are there any user-facing changes?

cc @sunchao

Codecov Report

Merging #2063 (3983af9) into master (742a590) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2063   +/-   ##
=======================================
  Coverage   83.55%   83.56%
=======================================
  Files         222      222
  Lines       58216    58224    +8
=======================================
+ Hits        48645    48657   +12
+ Misses       9571     9567    -4

Impacted Files
Coverage Δ

arrow/src/array/array_dictionary.rs
92.09% <100.00%> (+0.03%)
:arrow_up:

arrow/src/compute/kernels/filter.rs
88.08% <100.00%> (+0.03%)
:arrow_up:

...row/src/array/builder/string_dictionary_builder.rs
90.64% <0.00%> (-0.72%)
:arrow_down:

arrow/src/ffi.rs
87.52% <0.00%> (+0.04%)
:arrow_up:

parquet/src/column/writer.rs
91.53% <0.00%> (+0.05%)
:arrow_up:

parquet_derive/src/parquet_field.rs
66.21% <0.00%> (+0.45%)
:arrow_up:

arrow/src/datatypes/ffi.rs
76.56% <0.00%> (+1.56%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 742a590...3983af9. Read the comment docs.

Thanks @sunchao


Blocked from Serde organization

Have you been blocked from https://github.com/serde-rs organization?
If yes, please vote here: #1
Andrei has been blocked because he reacted to this PR: https://github.com/serde-rs/serde/pull/2580

@mo8it Thanks for being my voice.

What was the bannable reaction?

I reacted to https://github.com/serde-rs/serde/pull/2580 with 3 existing emojis. I might not be the only one.


[Feature Request] Redux batch action should be worked on reselect computed.

Hey everyone,
I use redux batch api, but I found that do not work on reselect. I meet the performance issue.
I write the demo code below to describe my problem. The reason I use batch is reusing my action code.
// studentActions.js
export function setStudentById(uid, student = {}) {
  return dispatch => {
    dispatch({ type: 'SET_STUDENT', uid, student })
  };
}
export function batchSetStudents(students = []) {
  return dispatch => {
    // batch api should emit render once in component
    batch(() => {
      students.forEach(student => (
        dispatch(setStudentById(student.uid, student))
      ));
    });
  };
}

// teacherActions.js
export function setTeacherById(uid, teacher = {}) {
  return dispatch => {
    dispatch({ type: 'SET_TEACHER', uid, teacher })
  };
}
export function batchSetTeachers(teachers = []) {
  return dispatch => {
    // batch api should emit render once in component
    batch(() => {
      teachers.forEach(teacher => (
        dispatch(setTeacherById(teacher.uid, teacher))
      ));
    });
  };
}

// classActions.js
export function updateStudentsAndTeachers(classId) {
  return async dispatch => {
    // update teachers
    const teachers = await fetchTeachersByClassId(classId)
    dispatch(batchSetTeachers(teachers))
    // update students
    const students = await fetchStudentsByClassId(classId)
    dispatch(batchSetStudents(students))
  };
}

// classReselect.js
export const getClassStudents = createSelector(
  state => state.currentClass,
  state => state.students,
  (currentClass, students) => {
    // if excute setStudentById 1000 times, the reselect will computed 1000 times.
    // school students count is 10000, that will be 1000 * 10000, right?
    // but setStudents using redux batch, I think it should be just excute once.
    return students.filter(student => student.classId === currentClass.id)
  }
)

My workaround solution is move reselect code to react component class get/set.
But I think that is not a good idea. Because that computed variable is used in multiple components.  😂

Where are you actually using this selector?
FWIW, I would strongly recommend changing how you are dispatching in the first place.  Don't dispatch a separate "setter" action for each item.  Dispatch one action containing all the data, and update many pieces of state in response:
https://redux.js.org/style-guide/style-guide#model-actions-as-events-not-setters
https://redux.js.org/style-guide/style-guide#allow-many-reducers-to-respond-to-the-same-action

Yeah~ The code I write is just a simple demo. Write the batch update "setter" action is also good, the redux-dev-tool will show single action and good for time traveling.
But it will be more complex in real situation. For example, setStudentById will dispatch other sync/async action. Like the step below:

Teacher has some fields that can write expression(maybe sql, mdx).
The expression can write students' name, such as: select * from [student].[foo].
If the student name is changed and updated when fetching, the teacher expression will send request, response error and set in redux.

Emm~ Developer will write a lot of code to realize the batch update reducer again.
In my opinion, code should be reused. (Maybe I'm too lazy, but I believe most developers are lazy also.😹)
Dispatch one async action in component, then the async action will dispatch other sync/async actions. Each sync action (Dispatch one action containing all the data) will do it job (update many pieces of state in response).
Maybe write the batch "setter" to single "setter" is the best practice, but I just give my idea. If the selector can support batch state change into one change, I think it will be more cool. 😸

I'm still a bit confused what your specific concern is.
Where and how are you trying to use this selector, and what "performance concerns" are you referring to?


Fix invalid argument name in opensearch example

The opensearch_dashboards_request_timeout in the opensearch docs example is an invalid argument name and presumably should be opensearch_request_timeout

@Tapppi thanks for contributing


Allow parse_file to create file if it doesn't exist

Is your feature request related to a problem? Please describe.
When trying to parse a file that doesn't exist, the lib throw an error. But for something like settings file, there are many times the settings are created at the first launch of a program.
Describe the solution you'd like
A possible solution could be to add a boolean (by default false) to create the file instead of throwing an error when parsing it.
Another possibility could be another function, something like parse_or_create_file(const char* path), that will create the file if the lib cannot open it.
Additional context

There's likely to be many opinions on what the appropriate semantics are here. Is creating an empty file on disk OK? If not, how does the callsite specify the default TOML? What should the function return? Etc.
Given that, I would rather not try to answer those questions at all. A simpler solution is for you to create a helper function in your own code that handles the situation exactly as you need it handled.


armadillo: 10.4.1 -> 10.5.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/armadillo/versions.
meta.description for armadillo is: "C++ linear algebra library"
meta.homepage for armadillo is: "http://arma.sourceforge.net"
meta.changelog for armadillo is: ""
Updates performed

Version update

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 10.5.0 with grep in /nix/store/mbsxdr95hw2j9k4zwx5klvl0m4bdcyhy-armadillo-10.5.0

found 10.5.0 in filename of file in /nix/store/mbsxdr95hw2j9k4zwx5klvl0m4bdcyhy-armadillo-10.5.0

directory tree listing: https://gist.github.com/7f05ba3af94b0dbbbf3c73882b1aa5f9

du listing: https://gist.github.com/e4190c47a12173dc9ad8c74e6d0e4b5c

Rebuild report (if merged into master) (click to expand)

8 total rebuild path(s)

3 package rebuild(s)

3 x86_64-linux rebuild(s)
2 i686-linux rebuild(s)
1 x86_64-darwin rebuild(s)
2 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
armadillo
gnss-sdr
openmolcas

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/mbsxdr95hw2j9k4zwx5klvl0m4bdcyhy-armadillo-10.5.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A armadillo https://github.com/r-ryantm/nixpkgs/archive/43551fc19e98e210da27a397ad66efcdce9ab575.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/mbsxdr95hw2j9k4zwx5klvl0m4bdcyhy-armadillo-10.5.0
ls -la /nix/store/mbsxdr95hw2j9k4zwx5klvl0m4bdcyhy-armadillo-10.5.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

3 packages built:

armadillo
gnss-sdr
openmolcas

Maintainer pings
cc @juliendehos @knedlsepp for testing.

Result of nixpkgs-review pr 124164 at 43551fc1 run on aarch64-linux 1

2 packages built successfully:

armadillo
gnss-sdr

Tested. LGTM


1.2

Thanks for your input - unfortunately, this branch is not under maintenance anymore. Please use Bob v2, which is fully described here: https://github.com/idiap/bob/wiki


Add Golang linting in CI and remove unreachable code from the repo

Describe the issue you're facing

There are few unused funcs/packages that need to be removed. Run Golang lint to check other lint errors.
Add Golang lint job to CI, use https://golangci-lint.run/ or similar

Hey @akshay196 I would like to work on this issue.

@bhavyastar Thanks for showing interest.
There are quite a few lint errors that we need to fix as part of this issue. At the end we need to enable go lint checker in CI.
With the default linters enabled golangci-lint reports 184 errors.
$ golangci-lint run --out-format json | jq '.Issues | length'
184

Feel free to fix all at once or take a sequential approach. Let us know if you need any help.
Meantime I would like to take a look at different golangci-lint linters (from disabled list) that we can enable for us.

@bhavyastar Are you still on this issue?

@theluckiesthuman If you're interested, you can get started on this. Let us know if you need anything.

@akshay196 can i work on this ?

@theluckiesthuman Are you still working on this?

@karthikmurali60 Feel free to take it up and raise PR once done.

Hi @akshay196 I want to work on this issue!

@Omkar0114 You can use automatic fix option of golangci-lint.
We also need to add the golang lint checker in CI (GitHub Actions) so that new changes/PRs are verified for linting errors.
Hope this is clear. Feel free to raise PR.

@akshay196  Sure. I'll raise a PR soon. Also, I want to ask if we create the lint.yaml file separately under .github/workflows, or in go.yaml we can add the lint job?

@Omkar0114 let's add link check in go.yml itself.

Cool. Thanks @akshay196

Hi, @akshay196  I would like to work on this.

Hey @jaydee029 Feel free to start working. No one actively working on it right now.
Let us know if you need any help.

@akshay196 I'm assuming we resolve all the linting errors not just the unused func/types error? right?

@akshay196 I'm assuming we resolve all the linting errors not just the unused func/types error? right?

If this is true, we would need to make certain structural changes such as error handling, since lot of the errors involved are missing error checks.

@jaydee029 sure, lets try to resolve all possible linting errors.
If it is going to be a big change then take iterative approach, fix few errors at first and then others.
Also we need to add CI check for linting so we avoid adding new errors in future.

@jaydee029 Thanks for your contribution. We have now added golangci-lint to GitHub workflows.
Feel free to start raising PRs to fix lint issues in code.


Support for Windows Server 2019 Domain Controller needed

Documentation states - "The solution supports domain controllers running Windows Server 2008 and 2008 R2, Windows Server 2012 and 2012 R2, and Windows Server 2016."
My customer needs support for Windows Server 2019 Domain Controller. Any recommendations? Thx.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: cce1867c-6526-4d34-0b0e-bde51321193f
Version Independent ID: 8577e152-47dd-6f01-bf7d-184cd47f3111
Content: Monitor Active Directory replication status - Azure Monitor
Content Source: articles/azure-monitor/insights/ad-replication-status.md
Service: azure-monitor
Sub-service: logs
GitHub Login: @bwren
Microsoft Alias: bwren

Thanks for your comment. We are actively investigating and will get back to you shortly. Thanks for your patience.

@stefan-rapp - were you able to test the solution on a DC running WS2019? did you get an incompatibility error?
@bwren do you have any insight into the above question? IF no, who on the feature team can share guidance?

Hi, I tried it for Windows Server 2019 DC. Unfortunately, there is the same problem like the "AD Health Check" (https://github.com/MicrosoftDocs/azure-docs/issues/53701) as the following screenshot illustrated ("No data found"). Thx

fyi @stefan-rapp  - following up internally on this. Please stay tuned.

Hi @stefan-rapp  - was able to re-confirm WS 2019 DCs are supported. we need to investigate further to get to the root cause. Please raise a technical support request using these steps. If you do not have a support plan, send mail to<EMAIL_ADDRESS>including your subscription ID and a link to this thread (for context) and we will gladly connect you with the Azure support channel.
Will now close this thread since this is no longer a question on the underlying documentation, We look forward to connecting with you on our support channel.
Cheers.


[4.0.0-rc.3] Bug or feature? Behavior when webpack configuration has an entry

Documentation Is:

[ ] Missing
[ ] Needed
[ ] Confusing
[x] Not Sure?

The issue
In the Readme, the comments say you don't need to specify the entry option. It doesn't say what happens if you do though. Currently, whatever is in the configuration entry will be bundled by Webpack in addition to the karma files.
If you are like me and you are reusing the same configuration for building and testing, it makes the testing really slow, as the main entry point of your application will be bundled with the tests.
What should be done

If that is a feature, we need to make the documentation clearer and explain that if you do have an entry in the Webpack config, it will be bundled. My understanding was that it was ignored since karma uses the files and preprocessors options.

If that is a bug, let's fix it, and also document that. Would removing the if statement here do the trick?

Yes, it'll build any given entry files and also add all the given test files as entry files too. I don't think we should restrict this, as there are probably reasons that this behaviour would be wanted, but I agree that the docs could be a bit better.

Currently v5 enforces a single entry point and there is another ticket out for supporting multiple entries #165


Remove for loops

Hi @ollybritton
I had a quick go at trying to refactor the for loops into idiomatic array operations. There is a bug somewhere which I ran out of time to squash but hopefully will get time to take another look or maybe there's something obvious you'll spot!

Still quite a few array api issues too so very much a prototype

If I can't figure it out in the next couple days let's just proceed as you have it since the arrays are small enough that the for loop doesn't really hurt performance as you showed

Thanks a lot! I'll run this locally and see if I can get all the tests to pass.

Thanks a lot! I'll run this locally and see if I can get all the tests to pass.

Thanks! If it turns into a complete wild goose chase we can just proceed with the original version but it should be feasible to do something like this

I'm not sure how to work around the errors like
IndexError: Single-axes index [False False False] is a boolean array and len(key)=2, but masking is only specified in the Array API when the array is the sole index.

@lucascolley did suggest using something like

Thanks again for taking a proper look at this. I've made some changes that fixes the array API errors; should I merge this PR and then commit and push the new changes to my infinite-limits-and-points branch?

Whatever is easiest for you, I don't mind!


[Shaz] populate airlines db

Populated airlines db with the added count attribute.

i dont think this is required - especially, if the attribute is nullable. What's the reason for populating this for all existing records?

Sorry, that was a communication issue. I will close this PR.


Only operations and admin roles should have the DELIVERY-SERVICE:UPDATE permission

This PR is not related to any issue.

Which Traffic Control components are affected by this PR?

Traffic Ops

What is the best way to verify this PR?

Before the change: make sure a user with the portal role can update a delivery service.
After the change: make sure a user with the portal role can only update a DS via the safe update endpoint.
If this is a bugfix, which Traffic Control versions contained the bug?

master

PR submission checklist

[ ] This PR has tests
[ ] This PR has documentation
[x] This PR has a CHANGELOG.md entry
[ ] This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

Allowing users with a priv_level below 20 to do "safe" updates is privilege escalation. The route definition in traffic_ops/traffic_ops_golang/routing/routes.go restricts that operation to users with a priv_level of at least 20 - "operator" or higher.

Allowing users with a priv_level below 20 to do "safe" updates is privilege escalation. The route definition in traffic_ops/traffic_ops_golang/routing/routes.go restricts that operation to users with a priv_level of at least 20 - "operator" or higher.

@mitchell852 Do the roles below priv level 20 need the "safe" update permissions?

@mitchell852 Do the roles below priv level 20 need the "safe" update permissions?
actually be able to do that
If we decide they do, the route definitions in routes.go will need to change. Otherwise, no matter what Permission you give their Role, users with a "priv level" that low using our current stable API version (3) will not actually be able to do it. And currently, they can't.

I think requiring operations priv-level was a regression from TO-Perl: https://github.com/apache/trafficcontrol/blob/4.0.x/traffic_ops/app/lib/API/Deliveryservice.pm#L534
We only checked if they're operations priv-level if we weren't using tenancy (which we do now). Therefore, it should be usable by any role, and the update should be allowed as long as the user's tenant checks out.

I think requiring operations priv-level was a regression from TO-Perl: https://github.com/apache/trafficcontrol/blob/4.0.x/traffic_ops/app/lib/API/Deliveryservice.pm#L534
We only checked if they're operations priv-level if we weren't using tenancy (which we do now). Therefore, it should be usable by any role (other than disallowed obviously), and the update should be allowed as long as the user's tenant checks out.

That would be consistent with the documentation not mentioning any required Roles. If nobody's been relying on the behavior of that regression then never mind what I said.


Get additional information from hook output

Add a function that executes the list_additional_information hook and returns the formatted output of it.
I added a function in the private folder that calls execute_with_output on the hook and returns a string that is 10 characters long without a trailing new line, which would break the output.
Relates to uptech/git-ps-rs#123
ps-id: 66cbc199-1918-4733-83e2-dbd6291d7d7c

This is no longer needed.


mongo_dart  doesn't work with flutter web

I wanted to port my App to the web so I used flutter web from flutter dev channel but seems like that the App doesn't work with mongo_dart on the web, without mongo_dart it works perfectly
Console Logs from chromium:
errors.dart:145 Uncaught (in promise) Error: Unsupported operation: Socket constructor
at Object.throw_ [as throw] (errors.dart:194)
at Function._connect (io_patch.dart:477)
at Function.connect (socket.dart:740)
at mongo_dart._Connection.new.connect (connection.dart:76)
at mongo_dart._ConnectionManager.new._connect (connection_manager.dart:23)
at _connect.next ()
at runBody (async_patch.dart:84)
at Object._async [as async] (async_patch.dart:123)
at mongo_dart._ConnectionManager.new.[_connect] (connection_manager.dart:22)
at connection_manager.dart:58
at future.dart:492
at future.dart:534
at _RootZone.runUnaryGuarded (zone.dart:1314)
at zone.dart:1353
at Function.doWhile (future.dart:549)
at Function.forEach (future.dart:490)
at mongo_dart._ConnectionManager.new.open (connection_manager.dart:59)
at db.dart:220
at Function.sync (future.dart:224)
at mongo_dart.Db.new.open (db.dart:207)
at main$ (main.dart:40)
at main$.next ()
at runBody (async_patch.dart:84)
at Object._async [as async] (async_patch.dart:123)
at Object.main$ [as main] (main.dart:39)
at main$ (main_web_entrypoint.dart:9)
at main$.next ()
at onValue (async_patch.dart:45)
at _RootZone.runUnary (zone.dart:1379)
at _FutureListener.thenAwait.handleValue (future_impl.dart:137)
at handleValueCallback (future_impl.dart:678)
at Function._propagateToListeners (future_impl.dart:707)
at async._AsyncCallbackEntry.new.callback (future_impl.dart:387)
at Object._microtaskLoop (schedule_microtask.dart:41)
at _startMicrotaskLoop (schedule_microtask.dart:50)
at async_patch.dart:166

You can't create Socket objects in a web browser. This is not an issue with flutter, instead it seems like an issue with mongo_dart

So, is there any workaround to use MongoDB in backend with flutter web

I would recommend filling an issue https://github.com/mongo-dart/mongo_dart .


Add kubernetes.Client controller implementation

Issue #, if available: part of #1090
Description of changes:
The controller runtime client implementation takes client.Client as an
input, which is a superset of runtime.Object. To make things easier, we
just make that a requirement in our kube client interface. To avoid
polluting our interface with something defined in controller runtime,
we just create a our own kubernetes.Object interface.
Testing (if applicable):
Unit tests
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

LGTM


perlPackages.XMLLibXML 2.0206 -> 2.0207

This fixes build failure on aarch64-darwin:
ld: library not found for -lz
clang-11: error: linker command failed with exit code 1 (use -v to see invoc
make: *** [Makefile:583: blib/arch/auto/XML/LibXML/LibXML.bundle] Error 1
error (ignored): error: interrupted by the user

Motivation for this change
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

@GrahamcOfBorg build perlPackages.XMLLibXML


ingest_runner falls over on non-ascii chars

ingest_runner fails with the following error:
 Traceback (most recent call last):
   File "ingest_runner.py", line 49, in <module>
     rtxt = 'stderr:' + rbin.decode('ascii').rstrip()
 UnicodeDecodeError: 'ascii' codec can't decode byte 0xe2 in position 31: ordinal not in range(128)

I think this is caused by the presence of a unicode char in the error message that ingest_runner is trying to process that can't be decoded to ascii. Changing to rbin.decode('utf-8') on that line appears to fix the immediate problem, but requires proper investigation and probably fixing elsewhere too.
This is the log that it appears to be choking on:
INGEST ---------- 2021/11/02T22:48:01
Processes = 1
ERROR in ingest/ingestBatch: Cannot connect to Cassandra
{}
eop end of messages
INGEST 0 finished with 0 alerts 0 candidates
0 alerts and 0 candidates
Tue Nov  2 22:48:06 UTC 2021
stderr:mkdir: cannot create directory ‘/mnt/cephfs’: Permission denied
stderr:%4|1635893281.962|CONFWARN|client-1#producer-2| [thrd:app]: Configuration property group.id is a consumer property and will be ignored by this producer instance
stderr:%4|1635893281.962|CONFWARN|client-1#producer-2| [thrd:app]: Configuration property session.timeout.ms is a consumer property and will be ignored by this producer instance
stderr:%4|1635893281.962|CONFWARN|client-1#producer-2| [thrd:app]: Configuration property enable.auto.commit is a consumer property and will be ignored by this producer instance
stderr:%4|1635893281.962|CONFWARN|client-1#producer-2| [thrd:app]: Configuration property auto.offset.reset is a consumer property and will be ignored by this producer instance
stderr:%3|1635893281.962|FAIL|client-1#consumer-1| [thrd:['lasair-dev-kafka-0:9092/bootstrap]: ['lasair-dev-kafka-0:9092/bootstrap: Failed to resolve '['lasair-dev-kafka-0:9092': Missing close-']' (after 0ms in state CONNECT)
stderr:%3|1635893281.963|FAIL|client-1#producer-2| [thrd:'lasair-dev-kafka-1:9092/bootstrap]: 'lasair-dev-kafka-1:9092/bootstrap: Failed to resolve ''lasair-dev-kafka-1:9092': Name or service not known (after 0ms in state CONNECT)
stderr:%3|1635893282.962|FAIL|client-1#consumer-1| [thrd:'lasair-dev-kafka-1:9092/bootstrap]: 'lasair-dev-kafka-1:9092/bootstrap: Failed to resolve ''lasair-dev-kafka-1:9092': Name or service not known (after 0ms in state CONNECT)
stderr:%3|1635893282.962|FAIL|client-1#producer-2| [thrd:['lasair-dev-kafka-0:9092/bootstrap]: ['lasair-dev-kafka-0:9092/bootstrap: Failed to resolve '['lasair-dev-kafka-0:9092': Missing close-']' (after 0ms in state CONNECT)
stderr:%3|1635893283.961|FAIL|client-1#consumer-1| [thrd:['lasair-dev-kafka-0:9092/bootstrap]: ['lasair-dev-kafka-0:9092/bootstrap: Failed to resolve '['lasair-dev-kafka-0:9092': Missing close-']' (after 0ms in state CONNECT, 1 identical error(s) suppressed)
stderr:%3|1635893283.962|FAIL|client-1#producer-2| [thrd:'lasair-dev-kafka-1:9092/bootstrap]: 'lasair-dev-kafka-1:9092/bootstrap: Failed to resolve ''lasair-dev-kafka-1:9092': Name or service not known (after 0ms in state CONNECT, 1 identical error(s) suppressed)
stderr:%3|1635893284.962|FAIL|client-1#consumer-1| [thrd:'lasair-dev-kafka-1:9092/bootstrap]: 'lasair-dev-kafka-1:9092/bootstrap: Failed to resolve ''lasair-dev-kafka-1:9092': Name or service not known (after 0ms in state CONNECT, 1 identical error(s) suppressed)
stderr:%3|1635893284.962|FAIL|client-1#producer-2| [thrd:['lasair-dev-kafka-0:9092/bootstrap]: ['lasair-dev-kafka-0:9092/bootstrap: Failed to resolve '['lasair-dev-kafka-0:9092': Missing close-']' (after 0ms in state CONNECT, 1 identical error(s) suppressed)
stderr:Traceback (most recent call last):
stderr:  File "ingest.py", line 441, in <module>
stderr:    rc = main()
stderr:  File "ingest.py", line 435, in main
stderr:    ms.add({'today_alert':nalert, 'today_candidate':ncandidate}, nid)
stderr:  File "/home/ubuntu/lasair-lsst/ingest/../utility/manage_status.py", line 113, in add
stderr:    status = self.lock_read(file_id)
stderr:  File "/home/ubuntu/lasair-lsst/ingest/../utility/manage_status.py", line 43, in lock_read
stderr:    f = open(status_file, 'w')
stderr:FileNotFoundError: [Errno 2] No such file or directory: '/mnt/cephfs/lasair/system_status/status_1766.json'
END getting more ...

Thanks Gareth. I changed decode('ascii') to decode('utf-8') in ingest/ingest_runner.py, filter/filter_runner.py, and services/TNS/tns_runner.py

If this is done can we safely close it?

Thanks for pointing this out. Fixed now.


ERROR: Could not find a version that satisfies the requirement torch==1.7.1+cu110

Describe the bug
Model I am using (UniLM, MiniLM, LayoutLM ...):
The problem arises when using:

[x] the official example scripts: (give details below)
[ ] my own modified scripts: (give details below)

conda create -n trocr python=3.7
conda activate trocr
git clone https://github.com/microsoft/unilm.git
cd unilm
cd trocr
pip install pybind11
pip install -r requirements.txt
pip install -v --no-cache-dir --global-option="--cpp_ext" --global-option="--cuda_ext" 'git+https://github.com/NVIDIA/apex.git'
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:
1.
2.
3.
Expected behavior
A clear and concise description of what you expected to happen.

Platform: OSX 16
Python version: 3.8.5
PyTorch version (GPU?):

Could you run the following command instead and let me know if it was successful or failed:
pip install pybind11
conda install pytorch==1.7.1 torchvision==0.8.2 torchaudio==0.7.2 -c pytorch
pip install timm==0.4.5
pip install natsort
pip install tensorboard
pip install nltk
pip install h5py
pip install numpy
pip install fastwer
pip install git+https://github.com/liminghao1630/fairseq.git

conda install pytorch==1.7.1 torchvision==0.8.2 torchaudio==0.7.2 -c pytorch

This worked for layoutLM model.


GSF IEF Meeting Agenda 2023-12-14

Time 10:30am (GMT) / 4:00pm (IST) - See the time in your timezone

Lead – @srini1978 (Microsoft)
Co-Lead @navveenb (Accenture)
Co-Lead – @jawache (GSF)
PM - @jmcook1186 (GSF)

Antitrust Policy
Joint Development Foundation meetings may involve participation by industry competitors, and it is the intention of the Joint Development Foundation to conduct all of its activities in accordance with applicable antitrust and competition laws. It is therefore extremely important that attendees adhere to meeting agendas, and be aware of, and not participate in, any activities that are prohibited under applicable US state, federal or foreign antitrust and competition laws.
If you have questions about these matters, please contact your company counsel or counsel to the Joint Development Foundation, DLA Piper.
Roll Call
Please add 'Attended' to this issue during the meeting to denote attendance.
Any untracked attendees will be added by the GSF team below:
Agenda

[ ] Press Record!

Discussions

[ ]  Sprint progress update
[ ] Carbon Hack

Issues

[ ] AOB

Attended

Attended


by Tim Klecka, Markus Kurzmann, Thomas Brych

Use develop branch

Hi @tklecka!
Thank you for your solution. Nice, you have used Angular 👍. Your code works really fine 😃. Here are some tips where you could improve (we will cover some of these topics in the 2nd semester):

Prefer const over let if you do not change the value of a variable.
Don't forget to format code. Run npm run lint and you will see that your code isn't formatted properly.
Avoid Spaghetticode where UI logic and data access logic is mixed. In your case, you could have created a separate data access service (docs) that is responsible for accessing the PokeAPI. That service could have been used in your UI components.
RxJS would allow you to write your code more elegantly by using more of the features of Observables.
Bold goal: Try writing automated tests for your logic.

Don't get me wrong. I really appreciate that you did the extra work and solved the Pokemon example using Angular. The points above are just items that could make you code even better.
Greetings and congrats to you and your colleagues!
Rainer Stropek.

Forgot to mention: Of course that's +2 points for all three of you.


Overview duplicated and texts vanished

Symptoms and reproduction
The following two relevant bugs are observed in Note overview v1.5.2:

Vanishing Bug: Texts after the last overview setting and texts after an overview setting without its overview  result are vanished at the next update.
Duplicating Bug: If some texts exist after the last overview result, the result is duplicated at the next update.

To reproduce the vanishing Bug, create the following note, and then execute Create note overview.
<!-- note-overview-plugin
search: title:xxx
-->
apple

The result is as below. apple is vanished.
<!-- note-overview-plugin
search: title:xxx
-->
Note count: 0
| updated_time | title |
| --- | --- |
<!--endoverview-->

To reproduce the duplicating Bug, create the following note (or add a text to the end of the above result), and then execute Create note overview.
<!-- note-overview-plugin
search: title:xxx
-->
Note count: 0
| updated_time | title |
| --- | --- |
<!--endoverview-->
orange

The result is as below. orange is vanished and the overview setting and result are duplicated.
<!-- note-overview-plugin
search: title:xxx
-->
Note count: 0
| updated_time | title |
| --- | --- |
<!--endoverview-->
<!- - note-overview-plugin
search: title:xxx
-->
Note count: 0
| updated_time | title |
| --- | --- |
<!--endoverview-->

Causes and Fixes
Soon, I'll send a pull request fixing the above bugs. Its code self-explains the causes.

+1 for getting the PR merged :) I'd love to have todo's relevant to a note generated at the top of a note, but it currently deletes any subsequent content.


Fix core build failures

Description
Revert the tox.ini changes until the irt changes are in again https://github.com/inmanta/irt/pull/2022
Self Check:
Strike through any lines that are not applicable (~~line~~) then check the box

[ ] Attached issue to pull request
[ ] Changelog entry
[ ] Type annotations are present
[ ] Code is clear and sufficiently documented
[ ] No (preventable) type errors (check using make mypy or make mypy-diff)
[ ] Sufficient test cases (reproduces the bug/tests the requested feature)
[ ] Correct, in line with design
[ ] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: )
[ ] If this PR fixes a race condition in the test suite, also push the fix to the relevant stable branche(s) (see test-fixes for more info)

Processing this pull request

Merged into branches master in 280804f1e574ffc258957a847f912286ee45f4c9


Using 'nameof' operator instead of magic strings

Using the "nameof" operator instead of magic string will help us if the variable change in the future for whatever the reason

Hi @hishamco, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.
TTYL, DNFBOT;


[Version 1.0] README / Final Interpretation outputs

Temporary place for version 1.0 goals:

[x] README Modifications. Possibly include generated gifs from branch #14 .
[x] Future feature implementations. Where is this repo planned to go?
[x] Tempted to add some form of blogging for the progress of this repo. Note sure though

I think I will see about a github pages


UP-4710: Bug on GuestUserTester

see on JIRA for more details : https://issues.jasig.org/browse/UP-4710

use the test without the class update and you will see the problem

Coverage increased (+0.02%) to 22.877% when pulling b1a274daaf530bf2a7a850ba619efcd405d9059d on GIP-RECIA:UP-4710_GuestUserTesterBug into 7b01ee9c1d8409584107a93060d8054d1c213ca9 on Jasig:master.

Now there are problems on guest evaluation. There is something but it would be great to know what, do you know why the pags was done on this way ?

@jgribonvald -- For starters... thank you so much!
This is excellent work.  Accurate diagnosis of the issue, correct solution, JIRA, test cases, and a pull request... this contribution is essentially perfect.  You're exactly the sort of person we want involved.  Please, more of these.

@drewwills : :blush:
With an easy correction it was the least that I could do


CI Should Send E-Mails On Failure

Looks like this isn't working and needs to be fixed.

E-Mails now sent out to person who triggered failure (if e-mail address is known) and the maven jmeter plugin devs group (https://groups.google.com/forum/#!forum/maven-jmeter-plugin-devs)


Type Error updating TanStack Query version

Describe the bug
I'm trying to update the TanStack Query version to 5.59.15 but I'm having the following error:
Type 'UseQueryOptions<T, Error, T, QueryKey> & { queryKey: DataTag<QueryKey, T>; }' is not assignable to type 'UseSuspenseQueryOptions<T, Error, T, QueryKey>'.
  Types of property 'queryFn' are incompatible.
    Type 'unique symbol | QueryFunction<T, QueryKey, never> | undefined' is not assignable to type 'QueryFunction<T, QueryKey, never> | undefined'.
      Type 'typeof skipToken' is not assignable to type 'QueryFunction<T, QueryKey, never>'

I tried other versions and it seems that the 5.59.11 version changed something related to the error.
Do you know what is causing the error?
Thanks
Steps to reproduce
  const [{ data: objects }, { data: containers }] = useSuspenseQueries({
    queries: [
      getAllObjects.getOptions({
        projectId,
      }),
      getAllContainers.getOptions({
        projectId,
      }),
    ],
  });

---

const getAllObjects = createSuspenseQuery<T, { projectId: string }>({
  queryKey: ["objects"],
  fetcher: async (variables): Promise<]T> => {...}
})

TanStack Query version
5.59.11
react-query-kit version
3.3.0

Fixed in v3.3.1

@liaoliao666 Thank you very much


Exampels

Hello, Sergiu
Can you help me, please?
How can I get an array for another digit to insert values into the image array [32321] in weights.h?
How can I get parameters in the fc_layer3_py.out file for this digit?
Can you add an example set of "fc_layer 3_py.out" and image [32321] for different numbers in weights.h?
I would like to try running CNN with few examples (for digists 2,3,8 and ect.).

Hi Ultrasq,
I think it would be a nice feature to convert a given image into the format accepted by the design. In this way, the user can see the full translation from picture -> input data -> output data from design.
I think the best approach for this is to add a script for creating the necessary header file and expected output. When I get spare time, I will work on this, but I cannot promise a clear deadline for an update.
Thank you for the suggestion!
Regards,
Sergiu


Doc fix

In docs/docs/shapes/vertices.md, the Description of mode should be Can be 'triangles', 'trianglesStrip' or 'triangleFan'. Default is 'triangles'.

Thank you for catching this 🙌🏼 Doing fun things with vertices? 😉


target same element with multiple jquery selector: passing function for checkmarks not working when completing tasks appropriately

Challenge http://beta.freecodecamp.com/challenges/waypoint-target-the-same-element-with-multiple-jquery-selectors has an issue.
Completed task appropriately, though was not able to continue due to code not being recognized properly by the code checking for the right answers.
in BETA FCC

closing as duplicate of #1529


Implement order independent transparency

We currently sort by distance to camera and render that, it's not ideal.

Simplest approach would be this one
https://github.com/KhronosGroup/Vulkan-Samples/tree/main/samples/api/oit_linked_lists


Timeout policy interruptable by default

Interruptable true as a more sensible default.
I think this might be more the expected behavior, I certainly was surprised that I need to set additional flags to get a useful timeout. When I define a timeout of 1s and an execution(rpc) takes 10s, getting a response after 10s that the computation timed out hardly introduces resiliency to the code. I think it might be more sensible to make the timeout policy interruptable and cancellable by default with ability to disable it for some reason. I would be interested about the reasoning behind this default.
If this is reasonable I can finish this PR, we would need some changes to the API.
Issue supporting this:
#209

My thinking echoes @tembrel's comments. Interrupting by default (withCancel(true)) could be somewhat dangerous since not all code is designed to be interrupted. This leaves the question of whether we should cancel by default (withCancel(false)).
Synchronous executions can't be cancelled, only interrupted. Async executions can be cancelled, but cancelling an async execution that has already started typically has no effect.
It could be possible that when using a Timeout with a RetryPolicy (ex: Failsafe.with(timeout, retryPolicy)), the Timeout might be exceeded during a retry delay, in which case it might make sense to just cancel the execution by default rather than letting the retry proceed. I can't think of a good reason why we'd still want a retry to proceed after a Timeout has already happened.
Thoughts?

why not create a static factory method to hide the extra few characters?

Sure, there are options to hide this.

(Aside: There's a minor spelling error in the Failsafe code, which uses "interruptable". The latter is an acceptable alternative in prose, but the Java platform uses the former consistently.)

Thank you :) I was more presenting the shape of the solution to answer the comment rather than providing the exact interface.
After thinking about this deeper for a library which purely offers constructs for handling failures in arbitrary execution contexts not specifically for access to remote systems it make sense to behave this way by default. I might've assumed too much that the majority of people will be using this library as a wrapper for "small controlled" contexts making network calls. @Tembrel thanks for highlighting the potential problems.
The least I think @Tembrel's comments on this PR provide a valuable rationale behind this.

@kkowalski No worries, thanks for sparking this discussion since it does highlight whether cancellation (without interruption) should default to true. Do you use Failsafe/Diehard at CircleCI? If so, mind if I add CircleCI to the users list?

Separately, do you use Failsafe/Diehard at CircleCI? If so, mind if I add CircleCI to the users list?

We use diehard for some of our integrations. I think it's fine, go ahead and add it.

@jhalterman wrote:

That said, when using a Timeout with a RetryPolicy, there could be a pending execution, in which case it might make sense to always just cancel the execution by default rather than letting the retry proceed. I can't think of a good reason why we'd still want a retry to proceed after a Timeout has already happened.

Yeah, I can't come up with a realistic counterexample where there's a timeout and you know somehow (or rather, Failsafe knows) that one or more tasks are enqueued for execution and yet for some reason you don't want to prevent them from running. The closest I can come is to imagine that in some cases preventing a pending task from running could be more expensive from letting it run, but that involves deliberately ignoring what I know to be true of the current Failsafe implementation and getting on a high horse about not restricting future implementations.
In other words, there's no reason not to remove pending tasks on timeout. The default behavior, therefore, should be to call cancel(false) on Future<?> instances on timeout. For completeness, I now think it would  be a good idea to offer a withoutCancel method, as @kkowalski suggested, to suppress this default behavior, though probably it wouldn't see much use. And I think it makes sense to continue to offer withCancel(boolean) to allow users to state their expectation that it is safe to use interruption to cancel a running task, even though withCancel(false) would then be redundantly confirming the default behavior.

Coincidentally, this just came in from Doug Lea:
http://cs.oswego.edu/pipermail/concurrency-interest/2020-February/017061.html
Seems relevant here and in some outstanding issues.

Opened #234 to discuss the issue related to cancellation. Since interruption will stay non-default for now, I'm closing this.


Refactor (MASConstraintMaker): Fix to remove Xcode warning.

Split declaration and assignment of anyAttribute variable to remove Xcode warning.

Thanks fixed in https://github.com/Masonry/Masonry/commit/1232b3e6e8cf8a2c19c008651ac738afe65e05bc

:+1:


add Option and Either Prism in Prism's companion object

do you think it makes sense to define them in the companion object of Prism?

It seems fine, they are a bit hard to find now living on std.

I agree but Iso seems to be a less clear cut. Should we put Iso[List[A], Vector[A]] in the companion object of Iso? what about the other way around? should we do all Seq combinations?

I also wondered about adding these on each Optic, considering that it could be nice to have a very small kernel

Yes, it is tricky to know where to draw the line.
IMO, the most important is that the kernel will be very stable. For example, I am not sure if adding a method to a companion object break binary compatibility.


server.authenticate  problem

If I use newest ver. 1.8.1  (when I use 1.7.0 work correct)

I get problem with  server.authenticate
server.on(F("/"),   {
if (!server.authenticate(www_username, www_password))
{
return server.requestAuthentication();
}
server.send(200, F("text/plain"), F("Login OK"));
});

If you call above you don't get  LOGIN windows, but clear window  and callin finis with :
return server.requestAuthentication();

I testing on ESP32-S2 + W5500 + Ehtrenet3 lib  (this lib I patchet library)

Close via PR #42

Hi @dirkdickler
The new EthernetWebServer releases v1.8.2 has just been published. Your contribution is noted in Contributions and Thanks
Best Regards,

Releases v1.8.2

Fix wrong http status header bug. Check fix for wrong http status header #42


Re introduce lastest channel and operator symlink

This PR relies on the existence of the latest channel and also appropiate symlinks on non-olm mig-operator deployments. Those are "latest" , "v1.1", "v1.2" etc.

Remove unnecessary logic needed to deal with the absence of a latest channel on OLM and missing non-olm (ocp3) latest directory/symlink
mig_operator_release controls CAM/MTC version being tested
Remove fixes for deprecated v1.0

@jmontleon Let me know if my assumptions are correct on this one


PackageNotFoundError: scramp when using redshift_connector library in glue

In aws glue shell job , i am using a wheel file which has all the libraries needed for aws wrangler, redshift-connector and i do see scramp library part of the wheel file. However when i install this wheel during glue python shell job i am getting the following error event though scramp library is installed.
Glue python version 3.9
aws wrangler version = 3.7.3
redshift-connector version = 2.1.1
I am trying to connect to redshift serverless using the above libraries and here
`

 from redshift_connector.core import BINARY, Connection, Cursor  File "/glue/lib/installation/redshift_connector/core.py", line 18, in  | from redshift_connector.core import BINARY, Connection, Cursor File "/glue/lib/installation/redshift_connector/core.py", line 18, in
-- | --
from scramp import ScramClient  # type: ignore  File "/glue/lib/installation/scramp/init.py", line 12, in  |
version = version("scramp")  File "/.pyenv/versions/3.9.10/lib/python3.9/importlib/metadata.py", line 560, in version |

return Distribution.from_name(distribution_name)  File "/.pyenv/versions/3.9.10/lib/python3.9/importlib/metadata.py",
"/.pyenv/versions/3.9.10/lib/python3.9/importlib/metadata.py", line 187, in from_name
raise PackageNotFoundError(name) importlib.metadata.PackageNotFoundError: scramp

`

I am stuck on same issue, You got any luck with this ?


Adopt flake8-pytest-style

Resolves #1133.
Changelog-friendly one-liner: Adopt flake8-pytest-style.
Contributor checklist

[ ] Provided the tests for the changes.
[x] Gave a clear one-line description in the PR (that the maintainers can add to CHANGELOG.md on release).
[ ] Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

Thanks, @hramezani, good job! Thanks for reviewing this @auvipy @webknjaz! 👍


[TA2584] MEMPOOL command for ISTGTCONTROL to list istgt mempool and its stats

Changes :

Added MEMPOOL command to list memory pool(allocated for replication) and its stats. It will also list spec in-flight IOs count and replica in-flight IOs count.
Command: istgtcontrol MEMPOOL
The output will be in JSON format as listed below:

{
  "mempool list": [
    {
      "MEMPOOL": "rcommon_mempool",
      "Size": 100000,
      "Free": 100000,
      "volume usage": [
        {
          "volume": "vol1",
          "in-flight read": 0,
          "in-flight write": 0,
          "in-flight sync": 0
        }
      ]
    },
    {
      "MEMPOOL": "rcommon_mempool",
      "Size": 300000,
      "Free": 300000,
      "replica usage": [
        {
          "replica": 6061,
          "in-flight read": 0,
          "in-flight write": 0,
          "in-flight sync": 0
        },
        {
          "replica": 6062,
          "in-flight read": 0,
          "in-flight write": 0,
          "in-flight sync": 0
        },
        {
          "replica": 6063,
          "in-flight read": 0,
          "in-flight write": 0,
          "in-flight sync": 0
        }
      ]
    }
  ]
}

@mynktl please resolve conflicts

@vishnuitta I have resolved conflicts and also removed few unused variables from istgt_lu_ctl.c from previous merged PR.


Include xow for newer xbox controller support

Although controllers such as the xbox 360 have drivers in the kernel, such isn't possible yet for the newer controllers. And since you can no longer buy the older controllers, this can be a problem.
There's an open source tool called xow that allows this, although it's still in userland. I'm wondering if it is possible to include support for it somehow. It can't be packaged as a flatpak, as it's a CLI program, and as I understand it such things aren't allowed in flathub for some reason. xow does require a CAB to work, whose license doesn't allow distribution; I expect this would further lead to problems as a flatpak. Usually, that's worked around via the usual means of downloading it at install time.
Technically, is this even feasible? It has packages in the AUR if that helps.

I'm dumb. I should have looked first before opening this... it looks like it's already supported.

I'm dumb. I should have looked first before opening this... it looks like it's already supported.


Serving a Backbone app from a subdirectory isn't supported by Router

A user should be able to specify a parameter to the Router ( say {root: 'myDir'} ) to specify that the app is being served from a subdirectory. After specifying this, the prefix parameter should be prepended to each route within the Router, so that routes can be properly handled, even when a Backbone application is served from a subdirectory.

Check out this gist I wrote for subrouting:
https://gist.github.com/1235317

Thanks for the code there tbranyen, seems to be exactly the functionality I'm looking for.
So now the big question: if one was to incorporate the prefix parameter like shown in tbranyen's code, how would you go about testing that?
I presume you'd want to test several different types of prefixes ("", "sub", "sub/", "sub/sub/sub", "sub/sub/") to properly test all cases, but wouldn't this require instantiating several Routers? In Backbone's current testing scheme for Routers (in router.js) there seems to be a single Router which is referenced by all the following tests. Is there any reason to keep this testing scheme?
I'm still in the process of familiarizing myself with Backbone.Router and Backbone.History (as well as Qunit) so I'd appreciate an opinion on the best way to go about adding tests for different instances of Router.

A "root" option is already supported in precisely this fashion:
https://github.com/documentcloud/backbone/blob/master/backbone.js#L769-780
No need for any extra code.

Oh man, thats incredible.  Thanks @jashkenas!

Thanks for pointing that out, I was looking in the wrong place, I should have been looking at Backbone.History instead of Backbone.Router.

This is a really old issue, and I don't think the link that @jashkenas left links to the right place in the code anymore. Is it documented somewhere?

Given that the link was posted on 10/15/2011 we can find the most current master git ref, which was ef40512d8441201e01f8d46c271fcf23235e9bc5
The link should be  https://github.com/jashkenas/backbone/blob/ef40512d8441201e01f8d46c271fcf23235e9bc5/backbone.js#L769-L780
(The most up-to-date would code be https://github.com/jashkenas/backbone/blob/1.2.3/backbone.js#L1633-L1661)

Is it worth putting some documentation about root on the website? I don't see it mentioned there under router anywhere. If so, I'd be happy to write something up!

It takes some searching but it's documented under http://backbonejs.org/#History-start

If your application is not being served from the root url / of your domain, be sure to tell History where the root really is, as an option: Backbone.history.start({pushState: true, root: "/public/search/"})

It's really a History option, not a Router one.

Ah, there it is. Thanks for pointing that out!

Dear!
Have you read the latest  article written by me? Just take a  look, it's very interesting. Please read here http://dunkiliwy.verdantgreenla.com/e4dmgevy
See you soon, Alberto Martinez


Logic correction

Corrected logic error for Birthday.isBirthdayToday and Birthday.isBirthdayTomorrow
Also changed the message for Birthday.

Coverage increased (+0.006%) to 90.478% when pulling b97b656207eaa102d8fd03a74ec4cb64e698dd65 on justinpoh:isBirthdayToday-correction into ea6b243944cd0941d5d8f803df4ffca71f8506b6 on CS2103AUG2017-W14-B1:master.

Coverage increased (+0.006%) to 90.478% when pulling f7925b17e60f4ee109430ca102365f2109ae9147 on justinpoh:isBirthdayToday-correction into ea6b243944cd0941d5d8f803df4ffca71f8506b6 on CS2103AUG2017-W14-B1:master.


Stricter validation in pod_set_spec

Not sure if this is the right repo vs https://github.com/juju/juju, can refile there if necessary.
It would be nice if pod_set_spec could either reject or warn about invalid properties the spec that it's passed. For example, I'm able to call this without warning:
layer.caas_base.pod_spec_set({
    'containers': {...}, # Some valid YAML
    'customResourceDefinition': [{
        ... # Some valid YAML
        'names': {...} # The `spec.names` key that appears in normal K8S CRD YAML
    }],
})

Looking at https://github.com/juju/juju/blob/d1e735e6bfe3641bc0c25c348904f59e7be91d3c/caas/containers.go#L81, I think that property is not supported, but is never complained about, which is very confusing when trying to adapt some pre-existing CRD spec to Juju.

+1.  We could do it here, but it would have to be kept in sync with core.  So it might be better to have the hook tool return an error message that is then surfaced by this layer.

@johnsca: Yeah, they're just ignored

The yaml required to be produced by the charm is now aligned with native k8s yaml for crds. The charm specifies a map of crd spec yaml, keyed on name, eg
customResourceDefinitions:
  pytorchjobs.kubeflow.org:
    group: kubeflow.org
    version: v1beta1
    names:
      kind: PyTorchJob
      plural: pytorchjobs
      singular: pytorchjob
    scope: Namespaced
    validation:
      openAPIV3Schema:
        properties:
          spec:
            properties:
              pytorchReplicaSpecs:
                properties:
                  Master:
                    properties:
                      replicas:
                        maximum: 1
                        minimum: 1
                        type: integer
                  Worker:
                    properties:
                      replicas:
                        minimum: 1
                        type: integer


734: Step 2

What (if any) features are you implementing?
Work for the Step #2

Updated heading & body (https://github.com/Gary-Community-Ventures/benefits-calculator/issues/734)
Removed the current line under the heading
Added box behind disclaimer text. #FBF9FC
Link colors in Terra Cotta #B85A27
Checkbox when clicked, #FFFFFF (white) checkmark with #41528C (mid blue) background

@Mdemenko1 The light purple/grey background should go behind the body of the text in the first box. There should not be a background/highlight around the actual confirmation checkbox lines.
Comp has different text than what we have now, but same concept.

I'm good with this visually now. @CalebPena - will you review code whenever you have a sec.


Invalid schema while listing runtime configurations via metadata cli

Describe the issue
Invalid schema while listing runtime configurations via metadata CLI
To Reproduce
Steps to reproduce the behavior:

elyra-metadata list runtimes

Available metadata instances for runtimes (includes invalid):

Schema    Instance               Resource
------    --------               --------
airflow   apache_airflow_v11012  /.../Library/Jupyter/metadata/runtimes/apache_airflow_v11012.json  **INVALID** (SchemaNotFoundError)
kfp       kfp-shared             /.../Library/Jupyter/metadata/runtimes/kfp-shared.json
kfp       kfp-shared-argo        /.../Library/Jupyter/metadata/runtimes/kfp-shared-argo.json
kfp       kfp-shared-tekton      /.../Library/Jupyter/metadata/runtimes/kfp-shared-tekton.json

more /.../Library/Jupyter/metadata/runtimes/apache_airflow_v11012.json

{
  "display_name": "Apache Airflow v1.10.12",
  "metadata": {
    "api_endpoint": "http://teacloth1.fyre.ibm.com:32706/",
    "github_api_endpoint": "xxx",
    "github_repo": "xxx",
    "github_repo_token": "xxx",
    "github_branch": "main",
    "cos_endpoint": "xxx",
    "cos_username": "xxx",
    "cos_password": "xxx",
    "cos_bucket": "elyra-pipeline",
    "tags": []
  },
  "schema_name": "airflow"
}

And, even though this is marked as invalid, it is available via REST APIs.

IIRC, we tolerate a missing schema but not an invalid instance wrt exposure via REST.
Any idea why the airflow schema is not present?

Any idea why the airflow schema is not present?
That is exactly the question, to me, it is there, but maybe it's getting confused with two schemas now?
Having said that, I did not investigate the issue yet.

Ok - thanks, I'll take a look.  I wanted to make sure this wasn't an older release or something funky going on.

Hmm.  I'm getting what appears to be a valid ValidationError...
$ elyra-metadata list runtimes
[E 2021-03-02 09:34:31,814.814] Validation failed for instance 'airflow_1' using the airflow schema with error: 'xxx' is not a 'uri'.
Available metadata instances for runtimes (includes invalid):

Schema    Instance      Resource
------    --------      --------
airflow   airflow_1     /Users/kbates/Library/Jupyter/metadata/runtimes/airflow_1.json     **INVALID** (ValidationError)
kfp       baz           /Users/kbates/Library/Jupyter/metadata/runtimes/baz.json
kfp       foofoo        /Users/kbates/Library/Jupyter/metadata/runtimes/foofoo.json
kfp       kf_1          /Users/kbates/Library/Jupyter/metadata/runtimes/kf_1.json
kfp       kf_eg         /Users/kbates/Library/Jupyter/metadata/runtimes/kf_eg.json
kfp       kfp-dex-auth  /Users/kbates/Library/Jupyter/metadata/runtimes/kfp-dex-auth.json

$ cat airflow_1.json
{
  "display_name": "Apache Airflow v1.10.12",
  "metadata": {
    "api_endpoint": "http://teacloth1.fyre.ibm.com:32706/",
    "github_api_endpoint": "xxx",
    "github_repo": "xxx",
    "github_repo_token": "xxx",
    "github_branch": "main",
    "cos_endpoint": "xxx",
    "cos_username": "xxx",
    "cos_password": "xxx",
    "cos_bucket": "elyra-pipeline",
    "tags": []
  },
  "schema_name": "airflow"
}

Once I fix the validation errors (there are 3, two URIs are invalid (github_api_endpoint and cos_endpont) and cos_password is too short) then the command completes:
$ elyra-metadata list runtimes
Available metadata instances for runtimes (includes invalid):

Schema    Instance      Resource
------    --------      --------
airflow   airflow_1     /Users/kbates/Library/Jupyter/metadata/runtimes/airflow_1.json
kfp       baz           /Users/kbates/Library/Jupyter/metadata/runtimes/baz.json
kfp       foofoo        /Users/kbates/Library/Jupyter/metadata/runtimes/foofoo.json
kfp       kf_1          /Users/kbates/Library/Jupyter/metadata/runtimes/kf_1.json
kfp       kf_eg         /Users/kbates/Library/Jupyter/metadata/runtimes/kf_eg.json
kfp       kfp-dex-auth  /Users/kbates/Library/Jupyter/metadata/runtimes/kfp-dex-auth.json

This was after pulling master and make clean install.

I just reproduced this using the released elyra - 2.0.1.
$ elyra-metadata list runtimes
Available metadata instances for runtimes (includes invalid):

Schema    Instance      Resource
------    --------      --------
airflow   airflow_1     /Users/kbates/Library/Jupyter/metadata/runtimes/airflow_1.json     **INVALID** (SchemaNotFoundError)
kfp       baz           /Users/kbates/Library/Jupyter/metadata/runtimes/baz.json
kfp       foofoo        /Users/kbates/Library/Jupyter/metadata/runtimes/foofoo.json
kfp       kf_1          /Users/kbates/Library/Jupyter/metadata/runtimes/kf_1.json
kfp       kf_eg         /Users/kbates/Library/Jupyter/metadata/runtimes/kf_eg.json
kfp       kfp-dex-auth  /Users/kbates/Library/Jupyter/metadata/runtimes/kfp-dex-auth.json

The airflow schema is not present...
$ ls /opt/anaconda3/envs/elyra-dev/lib/python3.6/site-packages/elyra/metadata/schemas
code-snippet.json   kfp.json            metadata-test.json  metadata-test2.json runtime-image.json

Airflow was not released in 2.0.1, so I believe this is still behaving as expected.  The inclusion of the schemas in the MANIFEST.in file looks correct.

Thanks for helping investigate this @kevin-bates, for some reason, I cannot reproduce this anymore even though I didn't change anything on the actual metadata file. For now, I will close this, but we can revive it if we start seeing this again,


Shell (i.e., curl and/or wget) examples

Provide a complete set of curl and/or wget examples for accessing the blpapi-http server over HTTPS.  Examples should cover the following:

Historical data
Reference data
Field lookup and search
Overrides
Varied options and parameters
Using different securities that are not just equities (i.e., stocks)
Getting the result back in some usable language-specific structure

@aceofsteel, I believe #31 addresses this issue except for overrides.  Override examples would be great to add after a new release of blpapi that includes bloomberg/blpapi-node@2da76913c716ebe939495b499a7c3457bb5332f2.

More examples have been added.


Not allowing parts to be rotated at all

I think this tool would be great for figuring out efficient cutting for fabric as well, however with some fabric it is essential that none of the parts get rotated at all due to the fabric structure.
Setting "Part Rotations" to 0 or 1 still caused the parts to be rotated, I would suggest an option to not rotate any parts.

setting rotations to 1 should ensure all parts maintain their orientation.
I think you may have clicked the x icon instead of "save". That cancels the config change instead of saving it, but I guess it's a bit ambiguous.

Oh, I just realized what happened! The Save button was covered by the "Click on outline to use as the bin" message, so I assumed settings were saved automatically.
Thanks for the quick reply and the great work!


Brezze not working after run "php artisan larastarters:install"

After Run php artisan larastarters:install, I selected windmill with Brezze but it stopped after making some actions as you see in the Screenshot!
.
I tried 3 times with creating fresh laravel install.

Delete everything and start from new project

Delete everything and start from new project

I tried 3 times but Alas, it's stacked only this place everytime!

@Minhazul-Islam18 thank you for the reporting, I reproduced it as well, with the fresh install, with two different themes of Tailwind:

Recently they've been really active with Breeze, so maybe they added something that broke our package.
@krekas could you please investigate and fix?

@krekas
Could you please mention me after fixing that?

@Minhazul-Islam18 try adding blade to this this command at this line https://github.com/LaravelDaily/Larastarters/blob/main/src/Console/InstallCommand.php#L69

@krekas oh right, they released the wizard when installing. But that should be fixed in the package, too, could you test and make a PR?

@PovilasKorop I tested and it seems to work, but with some delay for me. Need a few more people to test before pr

@krekas tried it myself, yes, it works and also with ~5-10 seconds delay. But works! So yeah I guess PR should be good, please do it.

@Minhazul-Islam18 fixed with the new v2.2 release.


Could you expose the function to change the input value

I use a support of react-hot-key so I can intercept such keys like ctrl+c
So in my case, I'd like to be able to manipulate the input field when user hit ctrl+c (or ctrl+d or maybe get history of command with up arrow. .) so I could add the interrupt information on last line and reset the input:
prompt> echo "foo" ^C
prompt>

Maybe we could have a props acting like a wrapper :
const [wrapper, setWrapper] = useState((value) => return value);

const clearInput = () => {
  setWrapper((value) => return '')
}
// On ctrl+c hit, call clearInput

<Terminal valueWrapper={wrapper} />

And in Terminal, the updateCurrentLineInput would have to call the wrapper to transform the value if valueWrapper is set.
I'm not sure about the method, you may have a better solution.

Hi @Jean-PhilippeD . Thanks for opening up this issue. I see your use case and it is definitely doable. I would like to do it in a way as to not expose the internal input state; a new prop input value wrapper might work. Let me think about this one for a bit. Feel free to submit a PR with your suggestion.

@Jean-PhilippeD What do you think about simply adding a startingInput: string prop? like:
<Terminal startingInput='echo "foo"' />

The terminal could be cleared by:
<Terminal startingInput="" />

Since the Terminal would only update when the startingInput changed, we may need to make the type of startingInput to be a Symbol, which is kind of weird.

Yes I think it can do the job but why do you need to make the type to be a Symbol ?

If it's a String type, subsequent clearInputs would not work, e.g.
const [startingInput, setStartingInput] = useState("");
const clearInput = () => {
  setStartingInput("");
}
<Terminal startingInput={startingInput} />

Since the startingInput prop is not changing values.

I'm not sure I really understand the matter, I still need to learn about react and js..
I thought that if you set
useEffect(() => {
  //change the starting input
}, [props.startingInput])

That way, the inut would change only if props change ?

I was going to update the Terminal component def with:
useEffect(() => {
    setCurrentLineInput(props.startingInput);
  }, [props.startingInput]);

so setCurrentLineInput would only get called when props.startingInput changes.  I'm not sure if there is a better pattern for this.
Anyway, I'll make the change early this week, and you can try it out if you want. We can iterate on the solution if it doesn't meet your needs.

great, I'll test it as soon as possible.

Hey I just had an other needs, what about if use is filling a password input like su -
For now, the input is visible, what do you think about adding a props like inputType which maybe passwords type, and in that case, it should be hidden.
:)

For now, the input is visible, what do you think about adding a props like inputType which maybe password type, and in that case, it should be hidden.
Feel free to open up a separate issue for this. I think it makes sense to allow more control over how the input is displayed in general. We'll have to put more thought into it.

@Jean-PhilippeD You can try this out if you upgrade to v0.1.11.

I just tested it and I got a problem, maybe the one you were talking about Symbol.
If I modify the startingInputValue  with setStartingInputValue in my component, it's working the first time, but once I changed it (with blank in my ctrl+C example), the next ctrl+C doesn't change anymore the startingInputValue  so the trick doesn't work anymore.
I tried to set to false immediatly after the blank but your Terminal reject a false value (it tries to trim on false value)... by the way it's not really pretty to do:
setStartingInputValue ('')
setInputValue(false)

I have to take a break, I'll think on how I could manage this, maybe you'll have an idea.
Thanks for the support, I appreciate ;)

            setInputValue('^C')
            setInputValue('')

works and seems to be acceptable for me

I think a better pattern for this might be something like an InputChangeHandler, which could have an API like:
class InputChangeHandler
  + triggerInputChange(String input)
  + onInputChange(String input)
  + onInputReceived(String input)


Why return array for uints and addresses?

Calling a contract function that returns an address, uint or enum gives the result in the first item of an array instead of just returning the value.
Is this on purpose? If so what is the reasoning?
Steps to reproduce:
const [
  publicAddressInContractStorage,
  publicEnumInStorage,
  publicUintInStorage
] = useContractCalls(...)

returns 3 arrays of type string, big number and big number respectively instead of a single array with the values.

Noticed varying type conflicts in the useContractCall(s) methods too


Support for composite asserts

This is pseudo code illustrating the use case (api test)
describe("Authentication service", () =>
  testPromise("Should save user", ()=> {
    let requestResult = client->ServiceClient.saveUser(...)
    let savedUser = // retrieve saved user

    expect(requestResult) |> toBe(...)
    && expect(savedUser) |> toBe(savedUser)
    });
});

Earlier discussion in #8. I'm not entirely opposed to it, but I have yet to see a good design and use cases that really need something like this.

@glennsl There are a lot of cases that need something like this. Take a look at this simple example using jest + react-testing-library from:
test('checkboxes (and radios) must use click', () => {
  const handleChange = jest.fn()
  const {container} = render(<input type="checkbox" onChange={handleChange} />)
  const checkbox = container.firstChild
  // for checkboxes, the event that's fired is the click event,
  // and that causes the change event handler to be called.
  // learn more: https://github.com/testing-library/react-testing-library/issues/156
  userEvent.click(checkbox)
  expect(handleChange).toHaveBeenCalledTimes(1)
  expect(checkbox.checked).toBe(true)
})

Example from Kent Dodds's workshop
It's really simple, but you can see that is often to have more than one expect inside of a test / it. Since jest supports it, makes sense to me that these bindings should also support too.

I understand your frustration @vmarcosp in being artificially restricted from doing these kinds of things, but this is also exactly the kind of thing it is meant to discourage.
This is IMO not a well-written test, as it tests two completely different aspects in a single test. This leads to a terribly vague test name, and assertions that mask other assertions. In this case, if the handleChange assertion fails, you don't know if checkbox,checked has been checked or not until you've gotten past the other assertion, and this might mask the actual underlying root cause.
In this simple example it might seem like an exaggerated concern, but what is the general principle that decides whether an assertion should be separate or included in another test? To take it to an extreme, why not put everything in a single test? It seems to me that the ideal is one assertion per test, and that the only reason you put multiple assertions in a test is code reuse. We already have good and appropriate code reuse mechanisms. They're called functions. jest itself even has a code reuse mechanism, beforeEach /beforeAll`` and afterEach/afterAlll.
So I'd encourage exploring these and making arguments against them as code reuse mechanisms, if that is the sole purpose for wanting this. If it's not, then I'd need more of an explanation to understand the use case and problem.

Hey, thanks for answering!
I understand your points and I disagree that is not a well-written test. But, my point is not if is a good or a bad test. My point is: Since jest supports multiple assertions in a test, its rescript bindings should support too. I know that you have good intentions with this restriction and I think it's a good idea, especially when dealing with bindings for a javascript library with a poor API.

I think most people just want the bindings without any opinions on how they should be authoring tests with Jest. Especially people migrating existing apps. This is one more hurdle in their way.
To say having a single test with multiple assertions is bad is subjective. Given no technical reason for the limitation I think teams should be able to decide if that is good or bad. I think this this is easily defeated anyway by wrapping the assertion in a function that returns a unit.
For example, is this test bad?
expect(foo).toHaveBeenCalledTimes(1);
expect(foo).toHaveBeenCalledWith(bar);

In my opinion this test is acceptable.


I changed the remote branch, from master to st3, but it keeps asking to merge from master

I changed the remote branch, from master to st3, but it keeps asking to merge from master.
The upstream was: BoundInCode/AutoFileName on branch master
The downstream is: evandrocoan/AutoFileName master
Now:
The upstream was: BoundInCode/AutoFileName on branch st3
The downstream is: evandrocoan/AutoFileName master
But when I call the hook URL, it keeps creating merge commits from the master branch, instead of st3.
Of course I saved the changes. https://github.com/evandrocoan/AutoFileName/pull/5

Hah, I think I never actually made the fork branch configurable: https://github.com/1egoman/backstroke/blob/master/src/webhook/index.js#L96

I'm in the process of pushing up quite a few changes, I'll make sure this is one of them.

Fixed by https://github.com/backstrokeapp/server/issues/66


Importing xarray fails if old version of bottleneck is installed

Importing version 0.11 of xarray fails if version 1.0.0 of Bottleneck is installed.
Bottleneck seems to be an optional dependency of xarray. During runtime xarray replaces functions by their bottleneck versions if that is installed, but it does not check if the version of bottleneck that is installed is new enough to provide that function:
The getattr here fails with an AttributeError in this case:
https://github.com/pydata/xarray/blob/b46fcd656391d786b8d25b0615f6d4bd30b524b7/xarray/core/ops.py#L361-L365
AttributeError: 'module' object has no attribute 'move_argmax'
move_argmax was included into bottleneck in version 1.1.0, so if version 1.0 is installed this can't work.
I saw this on python2.7, but I don't think that should matter...

@aseyboldt - Xarray now has a minimum version requirement for bottleneck of 1.1. This is mentioned in the docs here: http://xarray.pydata.org/en/latest/installing.html#for-accelerating-xarray

The error message could be better; this is how pandas does it: https://github.com/pandas-dev/pandas/blob/93c755e0ea64b6039c8ecd55fc637d1dd67dbd6e/pandas/core/nanops.py#L28

@jhamman Ah, I didn't see that. In hindsight the install docs seem like an obvious place to look for info about this...
@maxim-lian That pandas solution would have saved me a bit of debugging :-)
I guess another option would be to only replace functions that are present in Bottleneck. As long as they only add and never change functions this would allow xarray to use even very recent additions to bottleneck.

Also experiencing this, though for a different method & version of bottleneck:
$ pip list | grep -Ei "(bottleneck|xarray)"
Bottleneck                         1.2.1
xarray                             0.10.1
$ python3 -c "import xarray"
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/home/khaeru/.local/lib/python3.6/site-packages/xarray/__init__.py", line 10, in <module>
    from .core.extensions import (register_dataarray_accessor,
  File "/home/khaeru/.local/lib/python3.6/site-packages/xarray/core/extensions.py", line 7, in <module>
    from .dataarray import DataArray
  File "/home/khaeru/.local/lib/python3.6/site-packages/xarray/core/dataarray.py", line 16, in <module>
    from . import rolling
  File "/home/khaeru/.local/lib/python3.6/site-packages/xarray/core/rolling.py", line 377, in <module>
    inject_bottleneck_rolling_methods(DataArrayRolling)
  File "/home/khaeru/.local/lib/python3.6/site-packages/xarray/core/ops.py", line 362, in inject_bottleneck_rolling_methods
    f = getattr(bn, bn_name)
AttributeError: module 'bottleneck' has no attribute 'move_sum'


Allow QuickCheck 2.8.1

When installing haskoin after following instructions on the Stackage site to install Haskell in Ubuntu, I must issue --force-reinstalls because QuickCheck is affected by haskoin.
The version of QuickCheck present in the user’s GHC installation depends on the installation of alex and happy that is performed as the last step of Stackage instructions.

We are tracking LTS Haskell and using Stack now. We will add QuickCheck 2.8 support when it makes it there.


Decouple MLflow Components

Describe changes
This PR decouples the MLflow deployer and model registry from the experiment tracker so they can be used without any models having been logged beforehand.
Example
@step
def digits_data_loader():
    ...

@step  # No experiment tracker used here
def svc_trainer(X_train: np.ndarray, y_train: np.ndarray) -> ClassifierMixin:
    model = SVC(gamma=0.001)
    model.fit(X_train, y_train)
    return model

from zenml.integrations.mlflow.steps.mlflow_deployer import mlflow_model_deployer_step

@pipeline
def first_pipeline():
    X_train, X_test, y_train, y_test = digits_data_loader()
    model = svc_trainer(X_train, y_train)
    mlflow_model_deployer_step(model)

Implementation Details

Both mlflow_model_deployer_step and mlflow_register_model_step now log the model to MLflow in a new run if the model was not found; both steps were also heavily refactored
Instead of getting the MLflow connection from the experiment tracker in the stack, the model registry and deployer can now be configured separately
To achieve this, MLFlowStackComponentMixin and MLFlowConfigMixin classes were added which all three MLflow components now inherit from

Pre-requisites
Please ensure you have done the following:

[x] I have read the CONTRIBUTING.md document.
[x] If my change requires a change to docs, I have updated the documentation accordingly.
[ ] If I have added an integration, I have updated the integrations table and the corresponding website section.
[ ] I have added tests to cover my changes.

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Other (add details above)

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Felix Altenberger seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

branch was too stale, we'll revisit if we come back to this


[WIP]add grpc broker

closing this in favor of https://github.com/openshift-online/maestro/pull/157/


"Automatically hide the taskbar in desktop mode" stops AudioBand from updating info

Description
When using Spotify as an audio source, switching taskbar to "Automatically hide the taskbar in desktop mode" stops AudioBand from updating its data. The app freezes with the last state still held, and buttons seem to work, but information such as track, track time, artists, etc. no longer update.
How To Reproduce
Steps to reproduce the behavior:

Start Audioband while using Spotify
Right Click Taskbar -> Taskbar Settings
Toggle "Automatically hide the taskbar in desktop mode" to "On"

Version

Windows 10 version 21H2
AudioBand Version 1.1.4

Logs/Screenshots Attachment
Nothing really seems to show up in the log. I'll take a look and if I get anything I will update.

What audiosource were you using?
I have not been able to reproduce this, what audiosources were you using? (I could be doing it wrong)
Also jsut a side note but when in fullscreen MusicBee will stop the taskbar from poing up unless you exit fullscreen or minimise the app.

Spotify! that's a great point. I'll edit my original post to include that information

I have no idea as to why it is not updating. Can you share a screen recording?

Im able to reproduce the issue

Here is a screen recording
https://user-images.githubusercontent.com/56735924/182640402-622f75f7-20b3-435f-8d46-5fcc95b98bad.mp4