Terraform 0.12 map merging

It appears that Terraform 0.12 no longer merges maps, but only selects the 'newest' one when using a chained set of tfvars files. It is documented at the bottom of this page:
https://www.terraform.io/docs/configuration/variables.html
This definitely breaks a good part of my workflow with 0.12. I'm wondering if perhaps this could be something that is supported in the terragrunt.hcl inputs = {} sections so that you can chain map variables and merge them like with 0.11.x?

Hm, I don't think I'd want to merge maps by default. I think that would be unexpected and is one of the reasons Terraform itself stopped doing it.
However, if there was an explicit way to opt into that sort of behavior, it would make sense. For example, in a few issues, the idea of adding a get_input helper has come up:
inputs = {
  foo = "bar"
  baz = get_input("../common.hcl", "baz")
}

That allows you to explicitly reuse a single input from another .hcl (or .tfvars?) file. That could be combined with an merge function:
inputs = {
  foo = "bar"
  baz = merge(get_input("../common.hcl", "baz"), { "foo": "bar" })
}

This is verbose, but clear and explicit... It would work if you only have a small number of such variables, but might not be effective if you have dozens.

As of v0.19.4, merge (and all other Terraform built-in functions) is now available.

@brikis98
I've been trying to figure out the best way to do this, and I'm just not clear where terraform built-in functions can be run. The end goal in my scenario is specifically merge tags where I could have account level tags (or any arbitrary directory level) that would be applied to all sub-directories and merged into a single tag map to be applied to all resources.
The documentation under locals (https://github.com/gruntwork-io/terragrunt#locals) seems to indicate the only way to do this is by adding something like the below which works. The only issue is that now we have to use another configuration yaml configuration file throughout the directory structure, and the yaml files only need to be used for this type of map merge scenario which adds a bit of overhead/confusion.
`locals {
account_tags = yamldecode(file("${get_terragrunt_dir()}/${find_in_parent_folders("account.yaml")}"))
local_tags = {
"app"  = "local_app"
"type" = "local_type"
}
tags = merge(
local.account_tags,
local.local_tags
)
}
`
inputs = {   tags = local.tags }
Is there a simpler/more explicit method to merge maps for this type of scenario that I am just missing?
Thanks

It seems like you are looking for a better way to reference common variables. It would help to know what would be the ideal setup for you, since there are a few different ideas that we've floated around:
Implementing get_input helper function as described above
Implementing hcldecode helper function
This provides an alternative to yamldecode, where the vars are read as HCL so you can preserve the same syntax.
Updating dependency blocks to be able to load the config variables for access
In this setup, you can load the common vars from a base, reference terragrunt config in your setup. This is an alternative to get_input, where you would look something like:
dependency "common" {
  path = "../common"
  skip_outputs = true
}
inputs = {
  foo = "bar"
  baz = merge(dependency.common.inputs.baz, { "foo": "bar" })
}

@yorinasub17 - Appreciate the quick response.
I think the cleanest solution would at least be able to have all the variable data within a single file type (so maybe just the hcl files), and being able to pull/merge from parent hcl files. Having the ability to pull in tfvars/yaml/json files does allow for a lot of flexibility, but makes it a bit more complicated to track variables through a directory structure.
One thought I had was being able to merge locals from a parent.hcl file.
For example:
root level account.hcl
locals {
  account_tags = {
     "environment"  = "dev"
     "account_alias"  = "dev-app"
  }
}

mid-level app.hcl file
locals {
  app_tags = {
     "app"  = "local_app"
     "type" = "local_type"
     "appid= "appid"
  }
}

leaf level resource terragrunt.hcl
locals {
  resource_tags = {
     "app"  = "local_app"
     "type" = "local_type"
  }
  tags = merge(
     local.account_tags,
     local.app_tags,
     local.resource_tags
  )
}

I think the get_input/hcldecode helper functions might accomplish this. I think using the dependency functionality might make some things more complicated though I'd have to do some testing around it to see if it would work.
Thanks

The idea of hcldecode would be to decode an hcl file into a map, similar to how yamldecode and jsondecode works.

One thought I had was being able to merge locals from a parent.hcl file.

I know you realized this wasn't ideal, but FWIW, we discussed a similar construct called globals that does this. See the thread here: https://github.com/gruntwork-io/terragrunt/issues/814

Thanks for the link. That is definitely similar to what I was thinking. In the end any solution that allows for eplicit merging of variables/maps, and only using hcl files would be ideal.

As a matter of providing a use case where something like this is required, here is my example.
My Terraform deploys an Azure Function which takes a app_settings block which is a map(string). I am using the pattern from Infrastructure Live Example where the inputs are merged at different levels of the directory.
For my simple example, I have the following directory structure.
app/
  common.yaml
  terragrunt.hcl
  qa/
    environment.yaml
    terragrunt.hcl
  prod/
    environment.yaml
    terragrunt.hcl

The environment.yaml and common.yaml files are merged. There are app_settings blocks in the environment.yaml and common.yaml files. The common.yaml contains app_settings common to all environments, but it's app_settings block is replaced by the more specific environment.yaml file instead of being recursively merged.
The ability to opt-in/opt-out to a recursive merge would be much appreciated.

We now have multiple include blocks, exposed includes, and include deep merge, which combined should handle this use case (https://terragrunt.gruntwork.io/docs/reference/config-blocks-and-attributes/#include). Closing as solved.
If the original use case still can't be addressed with the new functionality, please open a new issue. Thanks!


[2.x] Replace deprecated session.writeTransaction on session.executeWrite in Neo4jHealthCheck

Description
Backport 2.x - https://github.com/helidon-io/helidon/pull/8397

I'm sorry. My IDE fooled me :( . There is no deprecated in 2.x . My dependencies were not updated. I'll close the PR.


Error with "upload_video.py" and track.txt generated with OSV app v1.4.4(2)

A new version of the OSV application has been delivered today:
==> version v1.4.4(2).
A try to use the upload_video.py script with a track generated with app v1.4.4 is aborted with the error:
"Processing directory: 14763xxxxxxx
Metadata backup found
An error has appeared in track.txt
An error has appeared in track.txt
Traceback (most recent call last):
File "/Users/xxxxx/Documents/Programmation/OpenStreetView/upload-scripts-master/upload_osv_videos/upload_video.py", line 398, in     main(sys.argv[1:])
File "/Users/xxxxx/Documents/Programmation/OpenStreetView/upload-scripts-master/upload_osv_videos/upload_video.py", line 282, in main
'sequenceId': id_sequence
UnboundLocalError: local variable 'id_sequence' referenced before assignment"
A look inside the track.txt generated with v1.4.4 shows that a new format has been identified
unknown;10.0.2;1.1.2;1.4.4(2)
==> new format identification is 1.1.2
The code in upload_video.py only considers that format may have values 1.1 or 1.1.1:
=> it is why the error occurs
Regards

Thanks for reporting 👍
Aded new versions into python script


No parameter to set (enable_open_metrics) otelcol.exporter.prometheus on Grafana Alloy

Request
OTLP Prometheus exporter supports a parameter to export metrics in OpenMetrics Format enable_open_metrics. This parameter is needed to enable exemplars.
Use case
This is no reference in the documentation to set enable_open_metrics . This required to enable exemplars on OTLP Prometheus Exporter configured on Grafana Alloy.

There's a note banner saying that the Alloy component is unrelated to your referred OTLP Prometheus exporter, fyi. The metric conversion schema is different, so to speak.

@hainenber
I understand. This is a feature request for a Parameter that does the same function (if possible).

@shaiajneh does this mean, with this there is not way to send exemplars to any backend?

I think that after this change, exemplars should work out of the box for a few metric types:

The exemplars are available for the histograms and for the sums of type "counter" (cumulative and monotonic).

Do you happen to be working with a different metric type?
cc @wildum


Add Podman support

I have following error on Mac with Podman Desktop enabled (with docker compatibility enabled, I even tried enabling docker cli emulation, but it didn't help):
composer-dev create --from-image-version composer-2.8.0-airflow-2.7.3 example-local-environment
No dags directory provided, using default dags directory.
╭─ Error ────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╮
│ Docker not available or failed to start. Please ensure docker service is installed and running. Error: Error while fetching    │
│ server API version: ('Connection aborted.', FileNotFoundError(2, 'No such file or directory'))                                 │
│                                                                                │
│ To print debug messages please add --debug flag.                                                                               │
╰────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╯

@peon-pasado-zeitnot Are you sure your issue is related to podman and not to #55?

@nbonnotte how can I verify it? Should I assume that Podman is allredy supported?

No, I don't Podman is not natively supported at the moment.
def get_client(self):
        try:
            return docker.from_env()
        except docker.errors.DockerException as err:
            logging.debug("Docker not found.", exc_info=True)
            raise errors.DockerNotAvailableError(err) from None

do you have DOCKER_HOST environment variable pointing to podman sock file?
It works with that

@rishi-aga can you elaborate? i have the DOCKER_HOST env var set and it works when i use the astro cli to run airflow locally but not when trying to run composer locally.
my error is similar but doesn't like the url scheme Error: Error while fetching server API version: Not     │ │ supported URL scheme http+docker

Closing as duplicate of https://github.com/GoogleCloudPlatform/composer-local-dev/issues/78

@ahidalgob why close this older issue with more context in favor of an issue that shouldn't have been opened?


When creating a system restore point it either gets stuck on 99% or 50%

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.

Im having same issue did you ever resolve?

i think i did but this was a long time ago. but ill tell you this, its not an issue with the tool its an issue with windows. try to make a restore point using system restore and it should spit out an error. look that up on the internet and that should be your fix for it

So thanks for getting back to me. The tool was working fine for a while then all of a sudden this started happening. If I go to system restore through windows to create a point it makes it no problem. That’s the wierd part. On Nov 5, 2023, at 1:28 AM, 006 @.***> wrote:
i think i did but this was a long time ago. but ill tell you this, its not an issue with the tool its an issue with windows. try to make a restore point using system restore and it should spit out an error. look that up on the internet and that should be your fix for it
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: @.***>

then you should be ok to use the program as long as you make a restore point manually and uncheck the restore point option in the program.


MoneyContext and all price related classes

[x] Think frameworky.
[x] Improve.
[ ] Take into account currency symbol from language and country.

Consider to move all previous/applied prices to SDK as a reference implementation (platform certified).


Yarn setup

I've just realised for yarn it's
"resolutions": {
    "uri-js": "npm:uri-js-replace"
  }

worth mentioning I think

Thanks! Added to README


K5WEB - Firmware Not Supported when writing SI4732 SSB Patch - LOSEHU130ES

On K5WEB I went to LOSEHU DIY and loaded firmware with English, spectrum, SI4732 and enable SSB. The firmware displays LOSEHU130ES. When I tried to write the SSB Patch, K5WEB says Firmware Not Supported. I got it to work by loading LOSEHU130HS firmware, then writing the SSB Patch, then reloading the LOSEHU130ES.

well,that's a problem

Hello, this issue is not due to a firmware bug but rather because the multiple versions are difficult to manage. Only the firmware versions with 'K' and 'H' are for machines that have already been equipped with a larger EEPROM by default. Due to the difficulty in managing the numerous firmware versions, we recommend using K5WEB for customizing features.
https://k5.vicicode.com/#/idea/losehu


feat: community docs implementation

Implemented the first iteration of the community docs section which will contain different docs categories... This can be located under docs&resources in the community path
let me know what your thoughts are
cc @derberg @derberg

@magicmatatjahu why's the Netlify preview job not running?

@AceTheCreator We have queue for Netlify builds, please wait some minutes.

@magicmatatjahu why's the Netlify preview job not running?

I think from Netlify settings, there has been a restriction to run the jobs only on the master branch and not on other branch created in the repository. There could be 2 possible solutions: either change the settings in Netlify for the website repo or you can try deploying your forked repo on your Netlify account and share the deployed link with us. We can preview the PR from that link.

@akshatnema Aaa yes... You are right. @derberg Could you enable build for other branches? I think that you can define which one - in our case it will be production, master and community.
https://docs.netlify.com/site-deploys/overview/#branch-deploy-controls

@akshatnema Aaa yes... You are right. @derberg Could you enable build for other branches? I think that you can define which one - in our case it will be production, master and community.

Hmm... I explored and tested the branch deploys right now. The problem exists that even if @derberg change the settings in Netlify, it will still not trigger the branch deploys until and unless a change is being made in the other branch. Since this PR is made before making the changes, there will not be any trigger related to this PR deploy. So make sure, if we change the settings, @AceTheCreator has to close this PR and make another one to trigger the branch deploy.
For a working template, I tested in this PR - https://github.com/akshatnema/website/pull/1 (Yeah :sweat_smile:, AsyncAPI CODEOWNERS workflow also works in my repo, that's why Missy has been tagged for review in PR)

@akshatnema Aaa yes... You are right. @derberg Could you enable build for other branches? I think that you can define which one - in our case it will be production (master) and community.
https://docs.netlify.com/site-deploys/overview/#branch-deploy-controls

@derberg can you please update Netlify settings to enable build for other branches :)

current settings are

netlify did not react on PR reopen event, so @AceTheCreator you have to create new PR as @akshatnema wrote I guess

@AceTheCreator try making an empty commit to trigger the deployment else you have to make a new PR.

The preview is ready, @derberg @magicmatatjahu @akshatnema can you kindly share your thought on this :)

Change in the layout of community docs
I'm not sure you should have a completely different layout specially for the community docs. Please confirm this design first from @mcturco and the theme you have followed. I would better suggest having a review from @mcturco as well.

I have to agree with @akshatnema here, we should just use the DocsLayout that we have already for any kind of documentation. No need to re-invent the wheel, but more importantly we don't want to confuse users and offer different ways of reading docs!

@AceTheCreator please accept all my commit suggestions to make it feasible for @Dule-mart to copy your latest version into his own PR.

Change in the layout of community docs
I'm not sure you should have a completely different layout specially for the community docs. Please confirm this design first from @mcturco and the theme you have followed. I would better suggest having a review from @mcturco as well.

I have to agree with @akshatnema here, we should just use the DocsLayout that we have already for any kind of documentation. No need to re-invent the wheel, but more importantly we don't want to confuse users and offer different ways of reading docs!

The reason I went for this approach is just to keep things simple :) Since the community docs are in categories and some categories only consist of a few docs, then this approach will really make more sense for such scenarios.

yeah, I agree to stick to current docs layout for community docs as you get many stuff out of the box:

feedback
right hand side toc
consistency 😛

@AceTheCreator Great work so far, hats off! 👏. I have left some comments on here for certain changes.

Docs pages not working

The content inside the page is not rendering. Kindly look into it.

Intentionally removed the contents cuz the reason why added it before was that I was using a custom UI and wanted you, folks, to see what the result looks like :)

Unnecessary extra spacing between components

I don't think we should have so much space between these 2 components.

You sure about this? Cuz if I didn't add the extra white space, it will look like a bunch of texts jam-packed without segregation

Card's background matches with the website's background

These cards are linked to different community pages, and the way they are highlighted doesn't specify to users that they are links to other pages. I would suggest you change the background colors of these cards to some interactive ones with some animation on hover to make them look good. It's my opinion and do ask some design contributors so they would suggest better colors and approaches.

Yea, I'm leaving it this way just for the sake of having the MVP. The big plan is to ensure each card is an illustration kinda design with different backgrounds. We'll definitely need a designer to help with this

Button size is too small as compared to text in the block

I think we should have the normal button size as we have on the homepage.

Link type property in cards

The cards pointing to some pages should have a cursor pointer on hover.

Description font size is very small

I would suggest to kindly have the font-size as normal as we use in Blog page description.

@derberg can we get this PR merged? Need to move to the next section

@akshatnema @mcturco @magicmatatjahu please i need this PR approved as soon as possible

@AceTheCreator Why soon as possible? 🤔

@AceTheCreator Why soon as possible? 🤔

Wanna get rid of my fork and refork it again due to some personal setup issue.

@AceTheCreator ok, I thought you wanna merge that PR to the master. I don't mind fix things in the next PRs, but I see that others have given you things to improve.

I want it merged with the community branch and I've also updated it with most of the suggested changes.
So once it's been merged, i can go ahead and delete my fork and fix the issue I'm facing over here

I want it merged with the community branch and I've also updated it with most of the suggested changes.

@AceTheCreator If you want to get this merged with community branch right now, I think there is no requirement for final reviews at all. community branch is just created for the completion of the community route and its pages. So, we can definitely approve and merge this PR now and then, can later on suggest changes to upcoming PRs.

Yo, @alequetzalli can you please approve this PR 🙂

Hey @AceTheCreator I don't think I can approve this PR yet because:

there are still some commit suggestions you haven't accepted
the branch has conflicts, which I assume is why it hasn't deployed a preview link
😄✌🏽

Hey @AceTheCreator I don't think I can approve this PR yet because:

there are still some commit suggestions you haven't accepted
the branch has conflicts, which I assume is why it hasn't deployed a preview link (I can't preview the new changes so I can't approve)
😄✌🏽

@alequetzalli the commit suggestions are outdated and I don't think this branch has a conflict. It also has a preview link https://deploy-preview-950--asyncapi-website.netlify.app/ :)

@AceTheCreator 👇🏼 😉

@AceTheCreator 👇🏼 😉

Thanks for pointing it out. Can't believe I missed it even with 4 eyes :)

Hmm, I actually see a few bugs to address before we can merge this:

The animation is LOVELY but the user will be confused because the mouse behavior makes the user think it's clicackle. This should only happen for the CTA button in that section. Here's a screen recording showing the issue:
https://user-images.githubusercontent.com/19964402/196254980-f62f42de-1115-4380-b4d6-64aed9836f3d.mov

The Ambassador programs and Community Members link in Home of #CommunityOps section 404s. Is this PR dependant on another PR that you need to merge together? 🤔 Or is this a bug? 🐛

There is a typo in the slide for the 22' Conference; Con instead of Conf.

Should the Ambassador Programs section link to the /events page? Wouldn't it make more sense for this to link to an 'Ambassador' page? 🧐

The 3 cards in the following section are confusing as a user because I cannot engage with them. Seeing those cards, users tend to expect them to be clickable and to take you to the section they mention. As such, I would expect these cards to link to the following 3 spots: tutorials, use cases, and roadmap.

Why does the meta data title for this Community landing page say "Events"? It should be Community.

@alequetzalli while you gave one hell of a review, thanks so much.
Concerning your review to the pages either with the wrong link or page doesn't exist, the reason is because I'm currently on the first iteration of this feat. And the first iteration is basically me creating the UI for every page with test functionality.
So this PR is not the final PR :)
I only want it to get merged to the community branch because I'm currently having some upstream issue from my local version and I wanna get rid of it and set it up again.
And concerning the docs section, @derberg can you share your opinion on that?

@AceTheCreator you sure you wanted to close this one?
@alequetzalli not sure if you are aware, discussion was somewhere is a related issue. But anyway, this PR is not directed to master but a temporary community branch. The reason is that changes are big, and @AceTheCreator and @akshatnema didn't want to push one gigantic PR at once to master. So @AceTheCreator is iteratively adding features to community branch one by one. I think we should scope our reviews to topics related to the PR, and overall/final review once master branch is a target. Does it make sense?


Fix ci cd

What

Fix CI/CD

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 97.561%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
38

Relevant Lines:
39

💛  - Coveralls


Until on recurrence_rule not set after version > 0.14.0

Hi,
First of all, thanks for this gem! But i'm having an issue while updating from version 0.14.0 to 0.15.0. The same thing occurs when updating to 0.16.0 or 0.16.1. What's happening is that the .until on the recurrence_rule isn't set anymore.
The difference:
0.14.0
{:validations=>{:day=>[5]}, :rule_type=>"IceCube::WeeklyRule", :interval=>1, :week_start=>1, :until=>2017-07-21 23:59:59 +0200}

0.15.0 (and above)
{:validations=>{:day=>[5]}, :rule_type=>"IceCube::WeeklyRule", :interval=>1, :week_start=>1}

This has many consequences in my spec files, because I use appointment.schedule.all_occurrences (which would return all the dates) a lot to explicitly check the dates. The method .terminating? just returns false because the rule is not terminating anymore.
This is how i'm adding the recurrence rules
self.schedule = Schedule.new(start_time, end_time: end_time) do |s|
  s.add_recurrence_rule(Rule.weekly(week_pattern, :monday).day(day_number).until(end_date))
end

Where the variables could be as followed:
week_pattern = 1
day_number = 5
end_date = Time.zone.today + 4.weeks (it's a Date object, But Time object doesn't fix it)
Also setting the backwards compatibility towards 12, 13, 14 doesn't solve it. I can't see where or what PR changed this behaviour, am I doing something wrong? Help is greatly appreciated 👍

Sorry to poke you like this @avit, but do you have a clue what is going on here?

Thanks, confirmed. Looking at it.

It looks like this is happening because you are setting a Date for the until, and it's expecting a Time.
Setting it with Date is ambiguous, and I believe incorrect that we allow it, so we should prevent bad input from failing silently like this.
There are a few places where we allow Date input because we can use the schedule's context to convert it to the proper time zone. In the case of Schedule.new(Time.zone.today) and then Rule.new(Date.today), these are independent inputs and the new rule doesn't know the schedule's time context for us to convert it. (We would have to change the API for building rules to support that.)
I'm going to add some input checking for the next version, but you can work around this in the meantime.

My mistake, it should be possible to set the until using a Date after all: we do get the correct context later when evaluating the schedule, so it is just a problem with serialization.

That I did not see! Thanks for this fix, just wanted to let you know that it fixes the problem! 👍


Add generic isometric shape to be used as container

This is related to #339 and aims to solve the issue by adding a new isometric library so that it can be used as container for both other sub-shapes or images. It requires the change in mxGraph here.

I have created a PR for mxGraph in Bitbucket, but it doesn't seem to be visible to anyone. @davidjgraph and @alderg , could you guys take a look into it, please? This is a very small change that could benefit others.

I have rewritten the previous code by implementing the proper isometric projection of any given shape/image and created a PR for mxGraph. @davidjgraph and @alderg , could you guys take a look into it, please?

Nice! We'll have to think about this to make it work with the Java and .Net APIs.

Hi, I don't see changes on draw.io. How Can I look at this ?

The PR isn't merged...

Ok...
And when will it be ?
Le mer. 17 juil. 2019 à 11:20, David Benson<EMAIL_ADDRESS>a
écrit :

The PR isn't merged...
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/jgraph/drawio/pull/340?email_source=notifications&email_token=ACKKQTNA663OGRFQKZM4DY3P73P7RA5CNFSM4F76DXQ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2DSVWQ#issuecomment-512174810,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACKKQTJHZPRALQBOIN6KXGDP73P7RANCNFSM4F76DXQQ
.

Sooner, if you review and merge it.

I'll wait for you to do it
Le mer. 17 juil. 2019 à 11:24, David Benson<EMAIL_ADDRESS>a
écrit :

Sooner, if you review and merge it.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/jgraph/drawio/pull/340?email_source=notifications&email_token=ACKKQTOURE2ICWTJRPQQWQDP73QM7A5CNFSM4F76DXQ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2DTADQ#issuecomment-512176142,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACKKQTKHNELQ2TUQR2RBHXTP73QM7ANCNFSM4F76DXQQ
.

@eduardomourar this is awesome PR! I'll fork your PR and promote it whenever it needs a promotion. Crazy that drawio team don't want to support this. Shame!

@duraki , I think this other PR is also important to you then: https://github.com/jgraph/mxgraph2/pull/1. We should ask that to be merged so that you don't have to keep both forks up-to-date.

 We really miss this feature in draw.io.


bundle install don't work, how to fix on this problem ?

Sample: https://github.com/artsy/eidolon
git clone https://github.com/artsy/eidolon.git
cd eidolon
bundle install
bundle exec fastlane oss

Uthens-MacBook-Pro:eidolon uthen$ bundle install
don't work how to resolve on this problem ?

Last login: Mon Jan 18 22:56:11 on ttys004
Uthens-MacBook-Pro:eidolon uthen$ bundle install
Fetching gem metadata from https://rubygems.org/.........
Fetching version metadata from https://rubygems.org/...
Fetching dependency metadata from https://rubygems.org/..
Fetching https://github.com/ffi/ffi.git
fatal: Could not parse object 'd94b923c1f574ff63743f0a3eefc917da03386b9'.
Git error: command git reset --hard d94b923c1f574ff63743f0a3eefc917da03386b9 in directory
/Users/uthen/.rbenv/versions/2.1.2/lib/ruby/gems/2.1.0/bundler/gems/ffi-d94b923c1f57 has failed.
If this error persists you could try removing the cache directory
'/Users/uthen/.rbenv/versions/2.1.2/lib/ruby/gems/2.1.0/cache/bundler/git/ffi-7fa1fad54f97b3471351dbde91d8b0a9444ce49e'
Uthens-MacBook-Pro:eidolon uthen$

Did you try deleting Users/uthen/.rbenv/versions/2.1.2/lib/ruby/gems/2.1.0/cache/bundler/git/ffi-7fa1fad54f97b3471351dbde91d8b0a9444ce49e like it asked, and re-runnning?

We're seeing this on our Continuous Integration, too. Started over the weekend, still looking into it.

Probably related to https://github.com/ffi/ffi/issues/461#issuecomment-172568651

Did you try deleting Users/uthen/.rbenv/versions/2.1.2/lib/ruby/gems/2.1.0/cache/bundler/git/ffi-7fa1fad54f97b3471351dbde91d8b0a9444ce49e like it asked, and re-runnning?
<<< I try to deleted on folder and re-rerunning, but still have the same problem..
Uthens-MacBook-Pro:eidolon uthen$ bundle install
Fetching gem metadata from https://rubygems.org/.........
Fetching version metadata from https://rubygems.org/...
Fetching dependency metadata from https://rubygems.org/..
Fetching https://github.com/ffi/ffi.git
fatal: Could not parse object 'd94b923c1f574ff63743f0a3eefc917da03386b9'.
Git error: command git reset --hard d94b923c1f574ff63743f0a3eefc917da03386b9 in directory /Users/uthen/.rbenv/versions/2.1.2/lib/ruby/gems/2.1.0/bundler/gems/ffi-d94b923c1f57 has failed.
If this error persists you could try removing the cache directory '/Users/uthen/.rbenv/versions/2.1.2/lib/ruby/gems/2.1.0/cache/bundler/git/ffi-7fa1fad54f97b3471351dbde91d8b0a9444ce49e'
Uthens-MacBook-Pro:eidolon uthen$

now i can build this project, thanks you

@uthens could you tell me how did you fix this problem? thanks

Deleting this line worked for me:
https://github.com/artsy/eidolon/blob/24e36a69bbafb4ef6dbe4d98b575ceb4e1d8345f/Gemfile.lock#L3
Seemingly revision d94b923c1f574ff63743f0a3eefc917da03386b9 does not exist and it causes this problem.

This one helped me: https://semaphoreci.com/docs/fail-could-not-parse-object.html

@shingt this works for me. thanks

Yeah, not sure what's up. ffi had problems with El Capitan, which is why we had that line. They seem to have resolved it, and maybe the commit hash is no longer accessible? Not sure. In any case, this solution worked for us, too: https://github.com/artsy/eidolon/commit/dec899a324e791de4774629c37b7bbe1310f313c

So, thanks!

You can try "sudo bundle install". It's work for me

to re-run bundle install helps me out.

❯ rm -rf vendor/bundle/ruby/2.7.0/cache/*

remove your cache.


check legend colors in explore_map

I'm looking at dvqcoefs.c in explore_map. The range of values is 0 to 2.5 in both the histogram and the legend, but the histogram indicates there should only be a couple of values in the 2-2.5 range, while the map shows lots of deep maroon points. Hovering over those points confirms that their values are often in the 0.5-1.5 range, despite their deep maroonness. Seems like the points coloring might not be properly aligned with the values and/or the color legend...take a look, @jread-usgs ?

got a fix for this.

:+1:


HotDistance

@mzouink It seems like maybe we should set it up so that Tasks are composable (e.g. HotDistance = OneHot + Distance) from within DaCapo?

Exactly, we did that one already but need to be finished, tested and merged.

we can start we new task - InnerDistanceTask = Distance * binary
So no more masks. related to https://github.com/janelia-cellmap/dacapo/issues/28


feat: add function to check disk size on startup

Purpose
Currently if we run out of space, we always core because we can not write default config. This change introduce check on startup if there is at least 100MB to run the node and exit if it is not
How does the solution address the problem

Changes made

prnet cleaned-up successfully


ghc-8.2.1-binary: Patch shebang causing failures in Centos 6

Motivation for this change
On Centos 6, when building from source the system shell would be used causing glibc reference problems.
...
cannot find section .interp
cannot find section .interp
cannot find section .interp
cannot find section .interp
cannot find section .interp
not an ELF executable
not an ELF executable
missing ELF header
not an ELF executable
cannot find section .interp
file ./ghc-8.2.1/ghc/stage2/build/tmp/ghc-stage2 had a PT_GNU_STACK program header, converted
setting SOURCE_DATE_EPOCH to timestamp<PHONE_NUMBER> of file ghc-8.2.1/configure
patching sources
configuring
configure flags: --prefix=/share/nix/store/6gvgr6m1rclbm9q9dah623awc263qzxp-ghc-8.2.1-binary --with-gmp-libraries=/share/nix/store/c5dw1yv0jkyf2p35scnl07lipdz1y2sv-gmp-6.1.2/lib --with-gmp-includes=/share/nix/store/kmwwwq5c0b8wdq6pw5x3b7sl8xzswj1-gmp-6.1.2-dev/include
/bin/sh: /lib64/libc.so.6: version `GLIBC_2.14' not found (required by /share/nix/store/p0sdx09s2nk9js3f914660x1l9smlcbk-ncurses-6.1-abi5-compat/lib/libtinfo.so.5)
/bin/sh: /lib64/libc.so.6: version `GLIBC_2.16' not found (required by /share/nix/store/p0sdx09s2nk9js3f914660x1l9smlcbk-ncurses-6.1-abi5-compat/lib/libtinfo.so.5)
builder for ‘/share/nix/store/b4b7d0d4zfmqkqsh1ydc4cmchzqk9vy5-ghc-8.2.1-binary.drv’ failed with exit code 1
cannot build derivation ‘/share/nix/store/r9vi05vlgmbly78wvynh4mdyhyz0998w-ghc-8.4.3.drv’: 1 dependencies couldn't be built
error: build of ‘/share/nix/store/r9vi05vlgmbly78wvynh4mdyhyz0998w-ghc-8.4.3.drv’ failed

Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Fits CONTRIBUTING.md.

Can we do this to the other binary GHC too?

@peti done
@Ericson2314 Seems like it was done before https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/compilers/ghc/7.10.3-binary.nix#L68

Original issue for ghc-7 https://github.com/NixOS/nixpkgs/pull/40691

Now properly rebased on haskell-updates.

Hehe I don't blame you. The other person should have patched all of them for the same reasons! (Or, we should abstract these would there's nothing to forget...)


nuscenes dataset split

I want to utilize nuscenes 1/7 dataset. Is there any arg in openpcdet repository that supports nuscenes split dataset?

Not yet.


Allow default value for memory view

An attempt at fixing #4313.

[x] The bug in #4313 is now tested and fixed
[x] No need for extra doc

Essentially, what I tried to achieve is to pass the default values as a decoration to the __default__ instead of casting it into the type associated with the argument.
For example, let us take the following example
class Foo:
    def my_method(self, int[:] foo = None):
        pass

My understanding is that Cython tries to cast None into a memory view, which it then fails to cast back into a Python object to populate the __default__ of my_method. One solution is to not cast default values and use them as is.
However, since I am not at all an expert into the inner workings of Cython, I am a bit worried I have missed something here and that this PR may cause inconsistencies between the actual default argument (as understood by Cython) and the one found in __default__.

I think what's happening is that analyse_types is being called on a CoercionNode (when the newly made "defaults" TupleNode is created. However, CoercionNode doesn't have analyse_types since it's usually created at the analyse_types stage.
I think in the past we've dealt with this kind of problem by implementing analyse_types for the class where it's missing. For CoercionNode that would probably just be return self (since the node should be already analysed). Or possibly self.arg.analyse_types(env); return self.

Thanks


docs: correct readme on how Alias works

The README was out of date and showed how to use Alias in a previous alpha release. Alias is now it's own parameter and not just a special token to use with MetasysHost.

cc: @hicksjacobp I just realized that I had much more to fix on the README.


feat: Sum.left, Sum.right

More intuitive names than .inl and .inr for non-type-theorists.
See https://leanprover.zulipchat.com/#narrow/stream/270676-lean4/topic/No.20Either.20type

do these definitions need any of reducible, inline, always_inline?

if you use abbrev they will get reducible, inline

It's possibly a bit confusing that prod.left is a projection but sum.left is a constructor.

This WIP PR has been inactive for over a year. Should we close it?


Rewrite using fish builtins

Over 5x faster than current awk script, and keeps everything nice and fishy.
Benchmark: time for i in (seq 50); random 1 99999999 | humanize_duration; end
current:

Executed in
183.48 millis
fish
external

usr time
116.28 millis
16.08 millis
100.20 millis

sys time
56.10 millis
13.87 millis
42.23 millis

this PR:

Executed in
31.10 millis
fish
external

usr time
27.07 millis
26.50 millis
575.00 millis

sys time
7.04 millis
7.04 millis
0.00 millis

This PR also adds the ability for arguments to be supplied directly to the function rather than having to be piped in.

Excellent work! I'll have a detailed look soon! 💯

@ammgws This PR also adds the ability for arguments to be supplied directly to the function rather than having to be piped in.

But you can still pipe them in, right?

can still pipe them in, right?

Yep

Fixed the maths for the seconds calculation. Oops.


Use values file to supply values for prototypes

ks generate deployed-service deployed-service5 --values-file /tmp/values-file

Fixes #550
Signed-off-by: bryanl<EMAIL_ADDRESS>

Pull Request Test Coverage Report for Build 925

140 of 179 (78.21%)  changed or added relevant lines in 4 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.3%) to 69.557%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/actions/prototype_use.go
18
19
94.74%

pkg/prototype/values.go
98
136
72.06%

Files with Coverage Reduction
New Missed Lines
%

pkg/actions/prototype_use.go
1
65.96%

Totals

Change from base Build 924:
0.3%

Covered Lines:
9482

Relevant Lines:
13632

💛  - Coveralls


[MINOR][DOCS] Update license header of LZ4BlockInputStream.java and remove it from RAT exclusion list.

What changes were proposed in this pull request?
LZ4BlockInputStream.java seems to be excluded RAT check due to its literally-different Apache license header and java package line order.
This PR updates the license header and moves it to the top of the file. Also, this removes LZ4BlockInputStream.java from dev/.rat-excludes.
How was this patch tested?
Manual.

Test build #56913 has started for PR 12665 at commit 879fda9.

Hi, @davies .
I made this PR to ask your opinion.

Can we remove LZ4BlockInputStream.java from RAT exclusion file like other files?
Can we remove TODO: merge this into upstream?

This PR contains only comment updates and moves, and RAT check is passed.
========================================================================
Running Apache RAT checks
========================================================================
Attempting to fetch rat
RAT checks passed.

LZ4BlockInputStream.java is NOT licensed to Apache Software Foundation (ASF), even it's licensed under Apache License.

Oh, I see. I overlooked that.
Thank you, @davies !

Test build #56913 has finished for PR 12665 at commit 879fda9.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/56913/
Test FAILed.

Merged build finished. Test FAILed.

@davies this should still be able to pass RAT checks though. It has a valid license header. This is a fine PR @dongjoon-hyun but as long as the text of the license in this file is not changed. Or am I missing that somehow RAT won't like this copyright header?

Oh, thank you, @srowen . It really does.
spark:license_header$ git diff master --name-only
dev/.rat-excludes
spark:license_header$ ./dev/check-license
RAT checks passed.

Then, is it possible to remove LZ4BlockInputStream.java from dev/.rat-excludes in this PR?

@davies and @srowen .
I opened a new PR #12677 to monitor LZ4BlockInputStream.java file properly from now.
If we can monitor it, we had better do that.


Change docker plugin version. Run docker image as non root user.

those changes not planned upstream for Open Source UAA version?

Not as they are at least. We could submit an open source pull request if we change the names and id's of the user and group.


The first click will not trigger the mouse down event in chrome

I make a little modified on the example: crs-simple.
I add a rectangle on a map. And there is a mousedown event listening on the rectangle. I add the options to map: renderer: L.canvas() and preferCanvas: true.
After I drag and drop the map, when I first click the Rectangle nothing happens. When I click the rectangle second time, the mousedown event is fired. But the first click should fire mousedown event also.
After I comment out the following lines, the program works.
renderer: L.canvas()
preferCanvas: true

Chrome  73.0.3683.86 x64
Leaflet: 1.6
Here is the code:
<script>
    var map = L.map('map', {
        crs: L.CRS.Simple,
        renderer: L.canvas(),
        preferCanvas: true,
    });

    var bounds = [[0,0], [1000,1000]];
    var image = L.imageOverlay('https://leafletjs.com/examples/crs-simple/uqm_map_full.png', bounds).addTo(map);

    map.fitBounds(bounds);

    // define rectangle geographical bounds
    var bounds = [[500, 500], [750, 750]];
    // create an orange rectangle
    var device = L.rectangle(bounds, {color: "#ff7800", weight: 1, fillOpacity:1}).addTo(map);

    function onDeviceMouseDown(e) {
        alert("You clicked the map at " + e.latlng);
    }

    device.on('mousedown', onDeviceMouseDown);
</script>

Try it online https://output.jsbin.com/dileyuy
Not reproduced with touch (with dev tools in desktop Chrome)

Click handled here:
https://github.com/Leaflet/Leaflet/blob/d843c3b88486713827d7e860b58bdba75bfbd5a2/src/layer/vector/Canvas.js#L351
And on first click after drag this._map._draggableMoved(layer) is true, that's why we miss first click.
I will try to find out what's going on in _draggableMoved

https://github.com/Leaflet/Leaflet/blob/d843c3b88486713827d7e860b58bdba75bfbd5a2/src/dom/Draggable.js#L87-L95
Here is sort of race condition: this handler is executed too late, because it is propagated event.
Perhaps simplest solution would be subscribing to capture phase.
But it appears not so simple, as we do not have 'capture' argument in leaflet api: https://leafletjs.com/reference-1.6.0.html#domevent
Not a big issue, as we can use addEventListener directly: it should be available from IE 9.
and Canvas is also available from IE 9

The issue is not reproduced with current master.

Ok, with touch enabled the bug is not reproduced, but I found that it's just a matter of coincident: 2 different bugs neutralized each other.

When Browser.touch and Browser.pointer both are true, our touchstart handlers in fact listens for pointerdownevent.
It is bug: #7058.
https://github.com/Leaflet/Leaflet/blob/d843c3b88486713827d7e860b58bdba75bfbd5a2/src/dom/Draggable.js#L24
It is bug: in result, for every single mouse down our handler process both events: 1. pointer 2. mouse. Same for mouse up.

_onClick in Canvas is listen for mouseup (may be this is wrong too, as our intention is handle 'click').
But pointer event come first, so code _onUp in Draggable is processed earlier, and all works fine.

So to really get rid of the bug we need fix race condition.

Your support is greatly appreciated.


Vim9: stuck when nested try/catch fail to catch error

Describe the bug
In Vim9 script, a nested try/catch failing to catch an error might cause Vim to get stuck.
To Reproduce
Run this shell command:
vim -Nu NONE -S <(cat <<'EOF'
    vim9script
    def Func()
        try
            eval [][0]
        catch
            try
                eval [][0]
            catch /nothing/
            endtry
        endtry
    enddef
    Func()
EOF
)

Vim is stuck, and cannot be interrupted by pressing <C-C>.
Expected behavior
Vim is not stuck.
Environment

Vim version: 8.2 Included patches: 1-3075
OS: Ubuntu 20.04.2 LTS
Terminal: XTerm(353)

Additional context
No issue at the script level:
vim9script
try
    eval [][0]
catch
    try
        eval [][0]
    catch /nothing/
    endtry
endtry

E684: list index out of range: 0

In the outer catch, if we specify a pattern to catch the first error (instead of catching everything), then Vim is still stuck, but can be interrupted by pressing <C-C>:
vim9script
def Func()
    try
        eval [][0]
    catch /E684:/
        try
            eval [][0]
        catch /nothing/
        endtry
    endtry
enddef
Func()

In the outer try, if we trigger an error with colder instead of eval [][0], and update the pattern to still catch it specifically, then Vim is no longer stuck; however the second eval [][0] which is run from the inner try/catch should give an uncaught error; it does not:
vim9script
def Func()
    try
        colder
    catch /E380:/
        try
            eval [][0]
        catch /nothing/
        endtry
    endtry
enddef
Func()

no error

While I was trying to find a MWE for this issue, I found something else which looks weird:
vim -Nu <(cat <<'EOF'
    vim9script
    &showtabline = 2
    &tabline = '%{Flag()}'
    def g:Flag(): string
        eval name
        return ''
    enddef
    autocmd VimEnter * var name = 0
    var lines =<< trim END
        vim9script
        try
            eval [][0]
        catch /nothing/
        endtry
    END
    lines->writefile('/tmp/s.vim')
EOF
) -S /tmp/s.vim

This gives an expected error:
E684: list index out of range: 0

Now, press Enter:
Error detected while compiling function Flag:
line    1:
E1001: Variable not found: name

I don't know whether this second error is expected.
It disappears if we remove the try/catch, or if we keep it but make it catch the previous error.  Maybe it means that we should not declare a script-local variable from an autocmd (even though it's technically possible)?  If so, maybe it warrants some mention in the help.

The hanging issue is fixed, but not the missing error.  This should raise E684:
vim9script
def Func()
    try
        eval [][0]
    catch /E684:/
        try
            eval [][0]
        catch /nothing/
        endtry
    endtry
enddef
Func()

It does not.  But it does at the script level:
vim9script
try
    eval [][0]
catch /E684:/
    try
        eval [][0]
    catch /nothing/
    endtry
endtry

E684: list index out of range: 0

About that "what looks weird" example: this reads a script from stdin, not a realistic example.  I think I'll just leave it.
I'll look into the nested try not throwing an exception


Added redirection and updated ref doc url for azps 7.1.0

Docs Build status updates of commit 1c38c73:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.openpublishing.redirection.json
:white_check_mark:Succeeded

docs-conceptual/azps-7.1.0/index.yml
:white_check_mark:Succeeded
View (azps-7.1.0)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


my_agent.run defaults to OPENAI even when custom LLM is passed (only if custom functions are added to agent)

Importance of Issue
This issue is of very high importance for the following reason
a. We are using custom LLM to save cost of calling openai.
b. The issue is only reproducible if you have NOT SET the OPENAI key.
c. If OPENAI key is set, even if I am using custom LLM, it will automatically call OPENAI for this task and the issue is NOT RAISED.
Steps to reproduce

Create Custom LLM

from openai import OpenAI
llm_model_name = "lmstudio-community/Meta-Llama-3-8B-Instruct-GGUF"
BASE_URL = "http://<IP_ADDRESS>:1234/v1"
MAX_TOKENS = 8192

def strict_llm(system_prompt: str, user_prompt: str) -> str:
    ''' Here, we use llama3-8B '''
    # ensure your LLM imports are all within this function
    # define your own LLM here
    client = OpenAI(base_url = BASE_URL, api_key = "lm-studio")
    response = client.chat.completions.create(
        model=llm_model_name,
        temperature = 0,
        messages=[
            {"role": "system", "content": system_prompt},
            {"role": "user", "content": user_prompt}
        ]
    )
    return response.choices[0].message.content

Create a new Agent
my_agent = Agent('Helpful assistant', 'You are a generalised agent', llm = strict_llm)
Create a simple custom function (Internal or External)

sentence_style = Function(fn_description = "Output a sentence wtih <obj> and <entity> in the style of <emotion>",
                          outout_format = {'output':'sentence'},
                          llm = strict_llm)

str(sentence_style)

Assign Custom function to agent

my_agent.assign_function(function_list=[sentence_style])

Run the agent

output = my_agent.run('Give me 5 words rhying with cool, and make a 4-sentence poem using them')

Error
OpenAIError: The api_key client option must be set either by passing api_key to the client or by setting the OPENAI_API_KEY environment variable
Observation
Without the custom function the Agents works fine, but once you pass any function to agent with custom LLM, the error is raised from ranker.py
if self.ranking_fn is None:
     [26](.conda/envs/agents/Lib/site-packages/taskgen/ranker.py:26)     from openai import OpenAI
---> [27](.conda/envs/agents/Lib/site-packages/taskgen/ranker.py:27)     client = OpenAI()
     [28](.conda/envs/agents/Lib/site-packages/taskgen/ranker.py:28)     query_embedding = self.get_or_create_embedding(query, client)
     [29](.conda/envs/agents/Lib/site-packages/taskgen/ranker.py:29)     key_embedding = self.get_or_create_embedding(key, client)

Possible Solution
Provide functionality to ranker to use custom embeddings (GPT4ALL, HUGGINGFACE) instead of defaulting to OPENAI Embeddings

Will address this. Kindly post this Issue on the taskgen github too.
The strictjson github is mainly for LLM parsing issues.

Done. Closing Issue from here.


Return parking lot coordinates

/parkinglots api endpoint response contain coordinates now
'''
Request
    GET: /parkinglots
Response
    [
        {
            parkinglot_id: int,
            name: string,
            longitude: float,
            latitude: float,
            current_capacity: int,
            maximum_capacity: int,
            current_handicap_capacity: int,
            maximum_handicap_capacity: int,
        }
    ]

#TODO address should be add into database
'''


Add rossmalone's file

created a branch, created a file and made a commit, and opened a pull request!

All OK


Rebase action

Uses https://github.com/tibdex/github-app-token and https://github.com/Label305/AutoRebase.
Allowed only these actions in settings.

We should be able to see how it works after something gets merged to master.


new storage

Resolves #683

@gyorb There is an issue. CodeChecker cmd login on an authentication-requiring server simply states that you need to authenticate (via CodeChecker cmd login) and then the process exits. (With return code 0.)

@whisperity the login problem should be fixed now

CodeChecker cmd login --logout is broken. It states "You are already logged in." and does not terminate the session.


encoding/xml: unmarshaller and whitespace

The issue
I had a file with space padded numbers (NumberOfPoints="   266703") but the XML unmarshaller couldn't handle the spaces.
Booleans are trimmed, so why not numbers?
Does this issue reproduce with the latest release?
The issue exists in the currently latest commit in the GitHub repository:
https://github.com/golang/go/blob/99da873/src/encoding/xml/read.go
What operating system and processor architecture are you using (go env)?
Not relevant as the issue is in architecture-independent library code.
Examples

Simple example: https://play.golang.org/p/3O0T3oU3Wy
My case: https://play.golang.org/p/tF1HZRE-un (Strangely, no error is returned when I run it locally; I just get 0 for NumberOfPoints.)

Good to know
I first asked about this and was given a workaround on Google Groups:
https://groups.google.com/forum/#!topic/golang-nuts/RtKU05cE9PY

According to the git history 1a37656b7a5aa97b23ec837825c6b30622f11b2c bools have been trimmed since they were first added by @rsc. @rsc: What was the motivation for trimming bools? Was it convenience?
If the reasoning was convenience I think it makes sense for there to be consistency across types where whitespace has no meaning since consistency will result in less wrong assumptions, but I think if it was to be added for consistency it'd need to be added to unsigned ints and floats too.
The no error on an invalid integer isn't intuitive and I think it should be considered a bug if trimming isn't introduced.

Not to weigh on any part of the scales, I'd still point out a bit from my response to @md2perpe over there on the ML:

The question of whether the string "   266703" represents a valid
integer is hardly decidable in my opinion.  For instance, would the
string "\v\v\v\n\n\n\t\t266703\n\n\n\v\v\v\v\t\x20\t" represent a valid
integer as well?

That is, while    266703 looks innocent enough, though mildly annoying as it hints at sloppy
implementation of whatever generated that document, a string containing lots of "weird"
characters considered to be whitespace by Unicode (or Go's strings / bytes packages)
is, IMO, a bit less easily decidable to represent "valid" data.

@leighmcculloch Since we don't do our code review on Github it sometimes helps to look over there to get more background on a change.  In this case, https://golang.org/cl/218050 .  In this case it looks like the purpose of the CL was to accept more strings for bool values.  It's not clear that anybody really considered the call to strings.TrimSpace in there.

Clearly we didn't think much of adding strings.TrimSpace in CL 218050 (which Michael Hoisie wrote and I reviewed), but it seems fine to apply strings.TrimSpace to all those numeric fields. Please make sure to update the docs and add a test. CLs welcome. Thanks.

If no one else is already on it I'd like to submit a CL to make the change. 🖐


Happy

Happy
Originally posted by @SatyamPote in https://github.com/open-decision/open-decision/discussions/324

asd


Feat UI/UX Page [Settings]

[+] fix(auth.tsx): fix condition to set custom endpoint to true if it's app
[+] refactor(auth.tsx): update accessStore to set useCustomConfig to true

A Preview:

a preview for app:

[!NOTE]
This are correct for app (desktop app) because while you using app (desktop app), it will used https://deploy.com/api/proxy/ instead of /api/openai (this /api/openai as default are for non app)

lgtm


'charmap' codec can't encode character error when syncing data

Ran into this error in the final stages of syncing the data from pubmed. Wondering if anyone has run into this issue aswell.
![stack trace](https://user-images.githubusercontent.com/40435390/193055141-e8e6c4b5-573e-4cff-aaad-12292b5a9136.

Looks like an encoding compatibility with my version of Python (3.9.13).
Fixed here: c9a1b20


coach evaluate runs forever

Is it possible to add something so that we can set the number of steps used for the evaluate branch of the code. At the moment sys.maxsize runs for a very long time.
def start_graph(graph_manager: 'GraphManager', task_parameters: 'TaskParameters'):
    """
    Runs the graph_manager using the configured task_parameters.
    This stand-alone method is a convenience for multiprocessing.
    """
    graph_manager.create_graph(task_parameters)

    # let the adventure begin
    if task_parameters.evaluate_only:
        graph_manager.evaluate(EnvironmentSteps(sys.maxsize))
    else:
        graph_manager.improve()
    graph_manager.close()

Fixed with PR #225


Awesome Profile Cards Interactive

VALUE
Someone in the Internet could see an interactive ongoing Adalabers project
CONTEXT
Corina is a back-end developer is a startup in Campus Madrid. She finds out that the adalabers working in Campus are building a project about an interactive site. She checks out one of the projects from GitHub and create a pull-request with improvements to help them.
To Do

[ ]  Preview interactive - color palette
[ ]  Preview interactive - full name
[ ]  Preview interactive - job
[ ]  Preview interactive - social networks
[ ] Interactive form: when modifying a form field, both the card design and the user data (except the photo), the preview is updated.
[ ] Perform form data validations: mandatory fields, email, etc.

DoD (cuándo consideramos que está acabado)

[ ] Published online

25-10:

merge all branch in main branch
start js button reset


Improve documentation about guarding Task execution using Conditions

Changes
As noted in #2635, it is not very clear what a Condition is in the context of a Pipeline.
And it is not clear how they work or what happens after.
This commit use the concept with "Guards" to explain how to guard Task execution within a Pipeline using Condition resources. An example showing the flow when a Condition is not successfully evaluated is also added.
/kind documentation

Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:

[ ] Includes tests (if functionality changed/added)
[x] Includes docs (if user facing)
[x] Commit messages follow commit message best practices

See the contribution guide for more details.
Double check this list of stuff that's easy to miss:

If you are adding a new binary/image to the cmd dir, please update
the release Task to build and release this image.

Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes
- Improved documentation about how to guard Task execution using Conditions within a Pipeline

/ok-to-test


[azure-queue] possible memory leak in package

Package Name: @azure/storage-queue
Package Version: 12.14.0
Operating system: linux/macos/windows (issue was observed in all these platforms)
[ ] nodejs:

version: 12.x

[ ] browser

name/version:

[ ] typescript

version:

Is the bug related to documentation in

[ ] README.md
[ ] source code documentation
[ ] SDK API docs on https://docs.microsoft.com

Describe the bug
I suspect there is a memory leak in the storage-queue package. I have been upgrading recently from the legacy storage-queue package, using the same logic in wrapper code. When downgrading back, the memory leak stops. Either bad implementation of mine or a possible memory leak in the package itself.
After logging the live instance for while, I keep getting this node error shortly after booting up the instance:
(node:18) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 close listeners added to [TLSSocket]. Use emitter.setMaxListeners() to increase limit
To Reproduce
Steps to reproduce the behavior:

Write a utility class

const { QueueClient } = require('@azure/storage-queue')

module.exports = class AzureQueue {
  constructor(QUEUE_NAME, QUEUE_CONNECTION_STRING) {
    this.queueName = QUEUE_NAME
    this.queueConnectionString = QUEUE_CONNECTION_STRING

    this.queueClient = new QueueClient(this.queueConnectionString, this.queueName)
  }

  async checkIfQueueExists() {
    return await this.queueClient.exists()
  }

  async dequeueNextMessage(visibilityTimeout) {
    const response = await this.queueClient.receiveMessages({ <==== possible memory leak?
      numOfMessages: 1,
      visibilityTimeout,
    })

    if (response.error) {
      console.log("Couldn't receive messages from queue", response.error)
      return error
    }

    if (response.receivedMessageItems.length == 1) {
      return response.receivedMessageItems[0]
    }

    return null
  }

  async deleteMessageFromQueue(messageId, popReceipt) {
    return await this.queueClient.deleteMessage(messageId, popReceipt)
  }
}

Apply wrapper code:

const runWorkerIteration = require('./runWorkerIteration')
const { getQueue } = require('./../services/utils')

// hold a single instance of the queue for a lifetime of the worker
let queue

async function runWorkerLoop() {
  let isRunning = false
  if (!queue) {
    queue = getQueue('QUEUE_NAME', 'QUEUE_CONNECTION_STRING')

    // check if the queue exists
    try {
      const exists = await queue.checkIfQueueExists()
      if (!exists) {
        throw new Error(`Queue 'QUEUE_NAME' doesn't exist`)
      }
    } catch (error) {
      return
    }
  }

  setInterval(() => {
    if (!isRunning) {
      isRunning = true
      runWorkerIteration(queue)
        .catch(error => {
          // on catch logic
        })
        .finally(() => {
          isRunning = false
        })
    }
  }, 1000)
}

module.exports = {
  runWorkerLoop,
}

apply iterator function

const DEQUEUE_INVISIBLE_TIMEOUT = 90

module.exports = async function runWorkerIteration(queue) {
  let message
  let errorMessage
  try {
    if (!queue) {
      throw new Error(`Queue [QUEUE_NAME] doesn't exist`)
    }

    message = await queue.dequeueNextMessage(DEQUEUE_INVISIBLE_TIMEOUT) // <==== possible memory leak trigger
    if (!message) {
      return
    }
  } catch (error) {
    errorMessage = error.message
    return
  }

  try {
    const parsedMessage = JSON.parse(message.messageText)
    // ... logic with parsed message
  } catch (error) {
    errorMessage = error.message
  } finally {
    try {
      if (message) {
        await queue.deleteMessageFromQueue(message.messageId, message.popReceipt)
      }
    } catch (error) {
      // on error logic
    }
  }
}

Expected behavior
Memory shouldn't leak.
Screenshots
Using legacy package, memory consumption over a week:

Using updated @azure/storage-queue, memory consumption increasing linearly quickly, few hours after instance booting up - it restarts do to shortage of memory:

Additional context
Attention: This instance is particularly running on node 12.x - due to the specific need for another package.

/cc @HarshaNalluru

Hi @orenlwsc ,
Thanks for reporting this to us.
I have run the code you shared for about half an hour, seems there's slightly memory increasing. I'll keep running it for more time to confirm.
From the repro code, seems it won't put any message into the queue, it just keeps retrying to receive message from the queue. The app still have memory issue even though no messages put/got into/from the queue, right?
We may need some time to debug into the issue. Will get back to you when there's any progress.

Hey, thanks for looking into it!
As far as I can see, it happens also when the queue is empty. We are not pushing new messages, only dequeuing them and deleting them.

Hi @orenlwsc ,  I can repro the issue on Node 12.22.12, cannot repro it on Node 18.  With Node 12, it reports the MaxListenersExceededWarning in several seconds, then its memory use increase pretty quickly.
@xirzec , Is Node 12 in our support matrix?

Hi @orenlwsc , I can repro the issue on Node 12.22.12, cannot repro it on Node 18. With Node 12, it reports the MaxListenersExceededWarning in several seconds, then its memory use increase pretty quickly.
@xirzec , Is Node 12 in our support matrix?

Ok, thanks for your insight! I suspected it might be related to the node version. I'll try to see if we can upgrade the node version here. Do you know what's the minimum version we need to get it running on to avoid the memory leak?

@orenlwsc , I tried with Node 14, didn't see this issue.

@xirzec, Is Node 12 in our support matrix?

No, it is not. Please refer to the support policy below.
https://github.com/Azure/azure-sdk-for-js/blob/97b5adee2384a1555ab8c85288755fdf5db6c3fb/SUPPORT.md?plain=1#L32-L36


nofollow is removed when internal links is set

Environment

Operating System: Linux
Node Version:     v18.14.0
Nuxt Version:     3.2.2
Nitro Version:    2.2.3
Package Manager<EMAIL_ADDRESS>Builder:          vite
User Config:      -
Runtime Modules:  -
Build Modules:    -

Reproduction
https://stackblitz.com/edit/github-c8trhm?file=pages/index.vue
Describe the bug
When I set an internal link and rel="nofollow" to <NuxtLink />, rel="nofollow" is removed.

<NuxtLink to="/a" rel="nofollow">to a</NuxtLink>

to a

to a

https://github.com/nuxt/nuxt/blob/268cded/packages/nuxt/src/app/components/nuxt-link.ts#L213-L229
Looking at the code above, it seems that rel is excluded for internal links.
However, sometimes you want to add rel="nofollow" even for internal links.
For example, if an application needs to set a query to display a modal, but you don't want search engines to recognize it as a page.
Additional context
https://stackblitz.com/edit/github-bqbgne?file=pages/index.vue
rel="nofollow" was not removed when Nuxt2.
Logs
No response

I think maybe @lihbr could help here :)

Hey there, thanks for contributing, and thanks for the heads up @Baroshem
This sounds legit to me!
@igayamaguchi, do you want to take that as an opportunity to submit a PR for it?
No pressure of course, if yes, just tag me in the PR, if no, I'll take care of it later today ☺

@lihbr Thank you for your reply.
I want to try 😄
I will make a PR, so please wait.


Harmonized RichText and Checkbox/Radio label max width depending on screen ratio

Summary | Résumé

Harmonized RichText and Checkbox/Radio label max width depending on screen ratio

closes #414
Test instructions | Instructions pour tester la modification

Using form http://localhost:3000/en/id/85 you can see that the width of RichText and Checkbox/Radio label is harmonized when resizing the browser window

So that this does not get stale. I propose we create a new issue for this and address it separately https://github.com/cds-snc/platform-forms-client/issues/479


microsoft-edge: 117.0.2045.35 -> 117.0.2045.40

Description of changes
Changelog: https://learn.microsoft.com/en-us/deployedge/microsoft-edge-relnote-stable-channel

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 257019 run on x86_64-linux 1

3 packages built:

microsoft-edge
microsoft-edge-beta
microsoft-edge-dev


job_start's callback doesn't redraw screen properly

This issue happens on gVim 8 on Windows 10. Second example happens also on cmd's Vim.
Minimal vimrc
set guicursor=a:blinkon0

function! Handler(ch, msg)
  echom a:msg
endfunction
let job = job_start('cmd /c dir /s/b c:', { 'callback': 'Handler' })

To reproduce, run Vim with minimal vimrc in folder with many  (c. 10000) files.
Examples

redraw is blocked after several seconds, I can move cursor to force redraw

with cursor blinking enabled, redraw is not blocked but it's delayed

with timer set to 1 ms, redraw is not blocked at all

Related issues
https://github.com/w0rp/ale/issues/515
https://github.com/roxma/nvim-completion-manager/issues/47
Version
VIM - Vi IMproved 8.0 (2016 Sep 12, compiled Jul 15 2017 22:02:21)
MS-Windows 64-bit GUI version with OLE support
Included patches: 1-717
Compiled by appveyor@APPVYR-WIN
Huge version with GUI.  Features included (+) or not (-):
+acl                +ex_extra           +multi_byte_ime/dyn -tag_any_white
+arabic             +extra_search       +multi_lang         +tcl/dyn
+autocmd            +farsi              +mzscheme/dyn       -termguicolors
+balloon_eval       +file_in_path       +netbeans_intg      -terminal
+browse             +find_in_path       +num64              -tgetent
++builtin_terms     +float              +ole                -termresponse
+byte_offset        +folding            +packages           +textobjects
+channel            -footer             +path_extra         +timers
+cindent            +gettext/dyn        +perl/dyn           +title
+clientserver       -hangul_input       +persistent_undo    +toolbar
+clipboard          +iconv/dyn          -postscript         +user_commands
+cmdline_compl      +insert_expand      +printer            +vertsplit
+cmdline_hist       +job                +profile            +virtualedit
+cmdline_info       +jumplist           +python/dyn         +visual
+comments           +keymap             +python3/dyn        +visualextra
+conceal            +lambda             +quickfix           +viminfo
+cryptv             +langmap            +reltime            +vreplace
+cscope             +libcall            +rightleft          +wildignore
+cursorbind         +linebreak          +ruby/dyn           +wildmenu
+cursorshape        +lispindent         +scrollbind         +windows
+dialog_con_gui     +listcmds           +signs              +writebackup
+diff               +localmap           +smartindent        -xfontset
+digraphs           +lua/dyn            +startuptime        -xim
+directx            +menu               +statusline         +xpm_w32
-dnd                +mksession          -sun_workshop       -xterm_save
-ebcdic             +modify_fname       +syntax
+emacs_tags         +mouse              +tag_binary
+eval               +mouseshape         +tag_old_static
   system vimrc file: "$VIM\vimrc"
     user vimrc file: "$HOME\_vimrc"
 2nd user vimrc file: "$HOME\vimfiles\vimrc"
 3rd user vimrc file: "$VIM\_vimrc"
      user exrc file: "$HOME\_exrc"
  2nd user exrc file: "$VIM\_exrc"
  system gvimrc file: "$VIM\gvimrc"
    user gvimrc file: "$HOME\_gvimrc"
2nd user gvimrc file: "$HOME\vimfiles\gvimrc"
3rd user gvimrc file: "$VIM\_gvimrc"
       defaults file: "$VIMRUNTIME\defaults.vim"
    system menu file: "$VIMRUNTIME\menu.vim"
Compilation: cl -c /W3 /nologo  -I. -Iproto -DHAVE_PATHDEF -DWIN32  -DFEAT_CSCOPE -DFEAT_NETBEANS_INTG -DFEAT_JOB_CHANNEL   -DFEAT_XPM_W32   -DWINVER=0x500 -D_WIN32_WINNT=0x500  /Fo.\ObjGXOULYHTRZAMD64/ /MP -DHAVE_STDINT_H /Ox /GL -DNDEBUG  /Zl /MT -DFEAT_OLE -DFEAT_MBYTE_IME -DDYNAMIC_IME -DFEAT_MBYTE -DFEAT_GUI_W32 -DFEAT_DIRECTX -DDYNAMIC_DIRECTX -DDYNAMIC_ICONV -DDYNAMIC_GETTEXT -DFEAT_TCL -DDYNAMIC_TCL -DDYNAMIC_TCL_DLL=\"tcl86.dll\" -DDYNAMIC_TCL_VER=\"8.6\" -DFEAT_LUA -DDYNAMIC_LUA -DDYNAMIC_LUA_DLL=\"lua53.dll\" -DFEAT_PYTHON -DDYNAMIC_PYTHON -DDYNAMIC_PYTHON_DLL=\"python27.dll\" -DFEAT_PYTHON3 -DDYNAMIC_PYTHON3 -DDYNAMIC_PYTHON3_DLL=\"python35.dll\" -DFEAT_MZSCHEME -I "C:\Program Files\Racket\include" -DMZ_PRECISE_GC -DDYNAMIC_MZSCHEME -DDYNAMIC_MZSCH_DLL=\"libracket3m_a0solc.dll\" -DDYNAMIC_MZGC_DLL=\"libracket3m_a0solc.dll\" -DFEAT_PERL -DPERL_IMPLICIT_CONTEXT -DPERL_IMPLICIT_SYS -DDYNAMIC_PERL -DDYNAMIC_PERL_DLL=\"perl524.dll\" -DFEAT_RUBY -DDYNAMIC_RUBY -DDYNAMIC_RUBY_VER=22 -DDYNAMIC_RUBY_DLL=\"x64-msvcrt-ruby220.dll\" -DFEAT_HUGE /Fd.\ObjGXOULYHTRZAMD64/ /Zi
Linking: link /RELEASE /nologo /subsystem:windows /LTCG:STATUS oldnames.lib kernel32.lib advapi32.lib shell32.lib gdi32.lib  comdlg32.lib ole32.lib uuid.lib /machine:AMD64 gdi32.lib version.lib   winspool.lib comctl32.lib advapi32.lib shell32.lib  /machine:AMD64 /nodefaultlib libcmt.lib oleaut32.lib user32.lib  /nodefaultlib:lua53.lib  /STACK:8388608  /nodefaultlib:python27.lib /nodefaultlib:python35.lib   "C:\Tcl\lib\tclstub86.lib" WSock32.lib xpm\x64\lib\libXpm.lib /PDB:gvim.pdb -debug

This issue happens on gVim 8 on Windows 10. Second example happens also on cmd's Vim.
Minimal vimrc
set guicursor=a:blinkon0

function! Handler(ch, msg)
  echom a:msg
endfunction
let job = job_start('cmd /c dir /s/b c:', { 'callback': 'Handler' })

It does not appear to be very useful to flood Vim with messages.  What
are you actually trying to do?
--
hundred-and-one symptoms of being an internet addict:
169. You hire a housekeeper for your home page.
/// Bram Moolenaar --<EMAIL_ADDRESS>-- http://www.Moolenaar.net   \
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \
\\  an exciting new programming language -- http://www.Zimbu.org        ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

I just wanted to provide easily reproducible steps for the problem. I encountered this bug in plugins. For example, in ALE linter messages are delayed for a couple of seconds and in NCM  autocomplete suggestions are also delayed for a couple of seconds if I disable cursor blinking.

I just wanted to provide easily reproducible steps for the problem. I encountered this bug in plugins. For example, in ALE linter messages are delayed for a couple of seconds and in NCM  autocomplete suggestions are also delayed for a couple of seconds if I disable cursor blinking.

If messages are to be displayed asynchronously, they will interfere with
whatever the user is doing.  This is going to be a problem sooner or
later.  It's much better to open a (small) window to display the
messages there.  That's also a much better way to look back in previous
messages than using :messages (which will mix output of all kinds of
stuff).  E.g. you can search back.
--
If Microsoft would build a car...
... Occasionally your car would die on the freeway for no
reason.  For some reason
you would simply accept this.
/// Bram Moolenaar --<EMAIL_ADDRESS>-- http://www.Moolenaar.net   \
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \
\\  an exciting new programming language -- http://www.Zimbu.org        ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

I made an issue only because I found it strange that whether cursor is blinking or not is influencing job_start behavior. And it only happens on one platform (Windows). If this is an intended behavior?

I've seen this behavior too. But it's a plain channel, no job involved. And I'm running Vim on a Linux box.
My plugin used a separate window to display messages from a server. A callback is registered to the channel for appending server messages to that window, but sometimes new messages just stopped showing up, until I move the cursor, or type another command.
My channel callback may also create new windows, but sometimes the new window will not show up until I move the cursor, or type another command.
I don't think it's a big usability issue once you have realized it. But this behavior do incur bad user experience.

I've seen this behavior too. But it's a plain channel, no job
involved. And I'm running Vim on a Linux box.
My plugin used a separate window to display messages from a server. A
callback is registered to the channel for appending server messages to
that window, but sometimes new messages just stopped showing up, until
I move the cursor, or type another command.
My channel callback may also create new windows, but sometimes the new
window will not show up until I move the cursor, or type another
command.
I don't think it's a big usability issue once you have realized it.
But this behavior do incur bad user experience.

It can happen that Vim is not checking for messages on the channel, or
doesn't find the end of a message.
Any input would then cause exiting the wait and start the loop again,
then the message is found.
It can be difficult to figure out why this happens.  Even using a
debugger might not work, since the code is asynchronous.  Adding ch_log
calls in the code would help, after opening a log file you can see what
happens, and inspect the time stamps.  This does require rebuilding Vim.
--
Wizards had always known that the act of observation changed the thing that
was observed, and sometimes forgot that it also changed the observer too.
Terry Pratchett  -  Interesting times
/// Bram Moolenaar --<EMAIL_ADDRESS>-- http://www.Moolenaar.net   \
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \
\\  an exciting new programming language -- http://www.Zimbu.org        ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

I get the same issue with new :terminal command.
Examples
With cursor blinking disabled

With cursor blinking enabled

Should I report it separately?

@xtal8 it is different issue from this. could you please file new issue?

I can't reproduce delays anymore. I'm not sure which patch solved the issue but I'm certain  https://github.com/vim/vim/commit/62426e168ef29fb941d1bd91a112fa09445322a5  fixed the issue  I had with ale.


Idea: partial handling of semantic-versioning as a way to provide some way of choosing specific versions of libraries

First of all, I've already seen and read #1681
I'd like to start by disagreeing with one statement:

This approach minimizes the burden on library authors and maintainers (how many boost versions must you test against? We say: only the latest supported upstream release), though the user experience can be rough as you've experienced and we do want to improve it in the future.

Of course. That's a good idea. As long as the library updates are compatible. However, "nowadays" we are a bit more aware about versioning issues and library authors often use more-or-less semantic versioning. In face or a large change that is meant/expected/etc to be not compatible, library authors often change the major number of that library, and the consumers often want to stay with their old major number.
As far as I quicky looked through the vcpkg project and structure of 'ports', it should be pretty easy to achieve. It could be added as a section to the installation command:
vcpkg install foobar:3:x86-windows

where the ":3:" section marks the major tag number.
Of course, from this there's a short path to
vcpkg install foobar:3.4-alpha-56-pretest-demo:x86-windows

and so on. I understand that this leads to the more-hellish part of dependency management that we dont want to dive into (for now?).
However, for the purpose of at least some way of managing the major versions (which seem pretty important..) there's one really simple trick:
(here's the actual request, the ^ was an lenghy intro)
Please consider adding major number version as a suffix to the library name.
That one is easy. I think it doesn't require any changes to the internal parts, just small edit to the ports library.. for example:
pdcurses ----> pdcurses-v3
sfml ---> sfml-v2

Using this scheme, which I think comes at almost no cost, when a new breaking major version shows up in any library (say, pdcurses publish version 4.0), its users will still stay with the previous one. Library authors may choose how long they want to keep patching both version and when to stop patching the old one, and users may decide when to switch to the new major number, while still being able to update their dependency safely in bounds of their currently-selected major version.

This would be a great feature for vcpkg! It would make it much more flexible for users to choose the version of packages they need. Although some refactor and format change in control file is need. But should be not a big change (defining multiple versions instead of one single version).

Not sure I completely understand this. Would foobar-v2 and foobar-v3 be separate packages/ports? Or two mutually exclusive versions of the same port?

Using the major version as part of the port name is already been done in some cases (e.g. qt5). Renaming all other ports would however be pretty disruptive

I'd say "pretty disruptive" would be to leave it as is, so when a library Foobar (v2.x) gets a braking change and is now Foobar (v3.x), current handling would be to just update it and push the breaking change to all unsuspecting consumers :)
I agree that renaming all current libs to foo-X right now would break current uses. Noone has it as foo-X right now, so it'd break all builds. However, what I want to suggest, is to use this scheme, name-major, for all future libs and versions. Let the Foobar (v2.x) library stay "foobar" for now, but when it gets a major change, leave "foobar" as is, bound to 2.x, and register the newer 3.x version as foobar-3, or something similar.

Then I guess the simplest way would still be to create separate ports and to add a field in the control.txt file that list packages which can't be installed simultaneously with the particular port.
This might make ci testing a bit more difficult, because now multiple different combinations need to be tested.

Of course the other can of worms this opens is the question which version x of libX, libY should list as its dependency.

My relevant post here #2823. Major version specifying is not enough. Libraries like Boost only have minor version changing, it doesn't make a difference for Boost since there's no Boost v2.
Again, really weird that vcpkg is still struggling from the awkward git-based versioning...

What if we enabled it so we could create subfolder that contained portfiles for old versions.
For example here's what the boost folder could look like:

Boost

/desktop

/uwp

/boost-1.70

/desktop

/uwp

0001-Fix-boost-ICU-support.patch

CONTROL

portfile.cmake

usage

0001-Fix-boost-ICU-support.patch

CONTROL

portfile.cmake

usage

Then when someone does ./vcpkg install boost it will install the top level (latest) version of boost. But if someone writes ./vcpkg install boost:boost-1.70 or some sort of syntax similar, it will use the install instructions located in the boost-1.70 folder.
This could be a non-disruptive approach to implementing versioning. Every time a new version comes out, you plop the existing files in a new folder, and then modify the top level to fit the new version.

Hi All, Installing an old or specific version in vcpkg is supported now, see versioning for details, please file a new issue if you encounter a problem.


[Improve][Core][spark-starter] Fix SparkStarter Supplementary check parameter

…arameter

Purpose of this pull request

Check list

[ ] Code changed are covered with tests, or it does not need tests for reason:
[ ] If any new Jar binary package adding in your PR, please add License Notice according
New License Guide
[ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
[ ] If you are contributing the connector code, please check that the following files are updated:

Update change log that in connector document. For more details you can refer to connector-v2
Update plugin-mapping.properties and add new connector information in it
Update the pom file of seatunnel-dist

link #3231

@Hisoka-X @CalvinKirs Please help to review it, thanks


ROX-26720: Reset dele scan config at end of suite

Description
Make sure the delegated scanning config is reset at end of test suite so that other tests are not impacted.
User-facing documentation

[x] CHANGELOG is updated OR update is not needed
[x] documentation PR is created and is linked above OR is not needed

Testing and quality

[x] the change is production ready: the change is GA or otherwise the functionality is gated by a feature flag
[x] CI results are inspected

Automated testing

[x] modified existing tests

How I validated my change
CI

Nice! I would love to understand whether this a sufficient or necessary change to address the issue of mutexes being locked for long?

This will likely eliminate the CI failures - but it is not a fix for the lock waiting issue


Neo4j source connector data transform is not valid for elastic sink or any other sink except neo4j

I have updated our neo4j connector to version 5.1.1 and now I see the data produced by the source connector is like
Struct{id=Struct{S=training},modifiedUtc=Struct{I64=1725965750415}}

I am using the StringConverter.
This Struct format, is not supported by any sink connector. Is there any SMT needed in between to transform the data to a normal json?
Also tried with JsonConverter and Avro, but no difference.

Yes, and you can use ksqlDB for the transformation.

Are we right to understand that the Source connector from 5.1 onwards, even with Query strategies, there is and will no longer be a configuration to allow for the messages to come as simple schema-less JSONs without including the schema on each field as a struct? And this option is not in the roadmap for the newer >5.1 versions?
In 5.1.0-rc01 changelog there is a mention:

To disable schemas, configure your key and value converters accordingly.

But this doesn't seem to be possible anymore. And it's a bit concerning having to depend on ksqlDB or other stream processing tools to continue supporting replication of Neo4j (4.4) to other DBs with the connector on Query mode.

Hi @Romsick,
You are correct that starting from version 5.1, the source connector behavior has changed, and the option to send schema-less JSONs with simple field values is currently unavailable. However, I wanted to clarify that we will bring this feature back, and we're actively working on it. It's expected to be included in one of the upcoming releases, most likely the next one. With the solution, you will be able to decide what type of structure you want to use, so there is not gonna be a need for ksqlDB or any kind of manual data parsing solutions.

Thanks for clarifying, that's great to hear, we will be paying attention to future releases!

Here is the latest release of the connector; https://github.com/neo4j/neo4j-kafka-connector/releases/tag/5.1.5
and the documentation about the feature; https://neo4j.com/docs/kafka/current/source/payload-mode/
I'm closing this issue now, and please feel free to create another one if anything comes up. Thanks!


Brittle VC<=>BN interaction

2020-08-04 03:51:41  []                error: Failed to obtain genesis time Error: undefined hitting the same now
restarting the validator client fixed it
I think that if the VC can't reach the beacon node at that moment, it gets that error
See https://discordapp.com/channels/593655374469660673/593655641445367808/740055094908944435

It seems like we don't catch error when polling so it probably breaks our interval check


(#124) LCOM5 tests

As per #124
LCOM5 for OneVoidMethodWithoutParams will not be NaN. According to LCOM5.xsl the value will be NaN only when the class has 1 method. The Skeleton treats the constructor of the class as a method, so OneVoidMethodWithoutParams has in fact two methods.
UPD. Same goes for OneMethodCreatesLambda for the same reason

Job #207 is now in scope, role is REV

This pull request #207 is assigned to @amihaiemil/z, here is why. The budget is 15 minutes, see §4. Please, read §27 and when you decide to accept the changes, inform @yegor256/z (the architect) right in this ticket. If you decide that this PR should not be accepted ever, also inform the architect.

Codecov Report

Merging #207 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #207   +/-   ##
=========================================
  Coverage     74.41%   74.41%
  Complexity      163      163
=========================================
  Files            31       31
  Lines          1020     1020
  Branches         73       73
=========================================
  Hits            759      759
  Misses          231      231
  Partials         30       30

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdacc73...410f356. Read the comment docs.

@rexim

The Skeleton treats the constructor of the class as a method,

It's because of this that the value for those 2 classes won't be NaN, but is this correct? Do we want the ctor to be counted as a method?

@amihaiemil In many cases class constructor is used as a legit class method. It can touch class attributes and call other class methods and overall contribute alot to the whole class cohesion. So I would not disregard it during the calculations.

@rexim I see, ok :)

@rultor good to merge

@rultor good to merge

@amihaiemil Thanks for your request. @yegor256 Please confirm this.

@yegor256 ping

@amihaiemil/z this job was assigned to you 5 days ago. It will be taken away from you soon, unless you close it, see §8. Read this and this, please.

@rultor merge

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@ypshenychka/z please review this job, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 12min)

@amihaiemil According to our QA Rules:

The code reviewer found at least three problems in the code. Comments were mostly about design problems, not cosmetic issues.

No issues were found during code review.
Please confirm that you'll try to find at least three problems while future reviews.

@ypshenychka I confirm, This was yet again a small PR but see, I did ask the author about something that smelled fishy :)

@amihaiemil Thanks. You asked but eventually nothing was fixed.

@0crat quality acceptable

QA review completed: +8 points just awarded to @ypshenychka/z, total is +766

Order was finished, quality was "acceptable": +15 points just awarded to @amihaiemil/z, total is +1055

@0crat quality acceptable (here)

@ypshenychka You can't do that, unless you have one of these roles: ARC, PO. Your current roles are: QA.

Payment to ARC for a closed pull request, as in §28: +10 points just awarded to @yegor256/z, total is +10949

The job #207 is now out of scope


feat: add nsq scaler

This change adds a new scaler for NSQ, enabling auto-scaling based on topic/channel depth. The main components of NSQ that the scaler interacts with are nsqlookupd and nsqd. First the scaler makes /lookup requests to the nsqlookupd instances in the cluster to determine which nsqd instances have messages for the given topic. Then for each nsqd instance the scaler makes /stats requests to and aggregates the results to determine a final depth value.
NSQ consumers create the channel they are reading if they do not exist. As such, if the channel does not exist on an nsqd host, the topic depth is used. The consumer pods that KEDA would be responsible in spawning would then create the channel.
The base functionality works, but TLS support is still needed. I could add that in this PR or in a subsequent PR if desired.
I also still need to create a PR in the kedacore/keda-docs repo.
Checklist

[x] When introducing a new scaler, I agree with the scaling governance policy
[x] I have verified that my change is according to the deprecations & breaking changes policy
[x] Tests have been added
[x] Changelog has been updated and is aligned with our changelog requirements
[x] A PR is opened to update the documentation on (repo) (if applicable)
[x] Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes #3281
Relates to:

kedacore/test-tools#175
kedacore/keda-docs#1485

@JorTurFer thanks for merging in kedacore/test-tools#175! I updated the code here to utilize the image that can be created from that PR.
I also wanted to let you know that I have created the corresponding docs PR as well here: kedacore/keda-docs#1485
The last remaining TODO's seem to just be getting these CI checks to pass. Is it safe to ignore the remaining semgrep checks since they just relate to tests? I initially got flagged for no-direct-write-to-responsewriter and now I'm getting no-fprintf-to-responsewriter, yet I do see both of these patterns being used in other test files.

/run-e2e nsq

I see the e2e tests have failed, but I'm wondering if the e2e test image was created? 🤔 I don't see it here. I'm guessing if make e2e-images is run in the test-tools repo it should create the ghcr.io/kedacore/tests-nsq:latest image. I'm thinking the issue was an image pull error due to it not existing yet.
# Local run w output snippet from describing a consumer pod
  Warning  Failed     9s    kubelet            Failed to pull image "ghcr.io/kedacore/tests-nsq:latest": failed to pull and unpack image "ghcr.io/kedacore/tests-nsq:latest": failed to resolve reference "ghcr.io/kedacore/tests-nsq:latest": failed to authorize: failed to fetch anonymous token: unexpected status from GET request to https://ghcr.io/token?scope=repository%3Akedacore%2Ftests-nsq%3Apull&service=ghcr.io: 401 Unauthorized
  Warning  Failed     9s    kubelet            Error: ErrImagePull
  Normal   BackOff    8s    kubelet            Back-off pulling image "ghcr.io/kedacore/tests-nsq:latest"
  Warning  Failed     8s    kubelet            Error: ImagePullBackOff

I also noticed I had only updated one of the refs of my custom images to ghcr.io/kedacore/tests-nsq:latest so I went ahead and made that fix.

The image was created but GH creates them as private by default, now it's public

/run-e2e nsq

Do we need to update the policy to include any extra permission? https://github.com/kedacore/testing-infrastructure/blob/main/terraform/modules/aws/iam/main.tf#L88-L96

Do we need to update the policy to include any extra permission? https://github.com/kedacore/testing-infrastructure/blob/main/terraform/modules/aws/iam/main.tf#L88-L96
If yes, could you open a PR there?

No additional permissions are required 👍

@JorTurFer just wanted to check in and see if you need anything else before merging this in?

@JorTurFer thanks for taking a look! I believe I addressed all of your comments, but let me know if anything else needs to change of course.

I'm worried about the lifecycle of the project, I closed the issue with the feature request a year and a half ago because there wasn't activity, and it looked as no longer maintained.

I'm an engineer at Bitly, which is where NSQ was initially developed. We use it extensively throughout our stack, and while updates to the project are not as frequent as they were in the past, it is stable. There are plans for updates in the near future and it is under active development.

/run-e2e nsq

@zroubalik @wozniakjan PTAL

/run-e2e nsq

@JorTurFer, I have updated this PR along with kedacore/docs#1485 to account for the 2.16 release that happened last week, PTAL!

/run-e2e nsq

Thanks for your contribution!


prometheus_alert_rules_files link is broken

This link in the README https://github.com/cloudalchemy/ansible-prometheus/blob/master/tree/master/defaults/main.yml#L58 is returning 404.

Thanks, links should be ok now :)


TestSimpleBuildRequestCancelled test doesn't preserve current working directory

The test RequestBuilder_Tests.TestSimpleBuildRequestCancelled is failing because the invariant that the current directory should not be changed is not being preserved.
I'm not sure whether it's expected for the current directory to change in this scenario.
@cdmihai

Possibly related to https://github.com/Microsoft/msbuild/issues/2977.


Incorrect balance on block explorer

The balance showed for my LBC address on the block explorer is incorrect. As of July 8th 2020 at 7:38 AM EST, my wallet balance was 1,875.75226 LBC.

However, it showed on the block explorer as 1,231.856047 LBC which is incorrect.

As far as I can tell, my address hasn't changed or anything (and I don't know how I'd do that with a lbry wallet).
I'm not sure if this is happening with other wallets.

Balance is correct now. Idk, close if no one else is having this problem I guess.

Could this be a Chainquery delay issue ? I don't think it's due to the explorer.

Could this be a Chainquery delay issue ? I don't think it's due to the explorer.