objstore: Be clear of our consistency assumptions or handle eventual consistency gracefully.

As per discussion here https://github.com/improbable-eng/thanos/pull/282 it is clear that we care about strong consistency for our block storages. However we are not sure if S3 is really strong consistent for our usage, or any other storage that will be implemented, will it be true as well?
Options:

State clear that we assume strong consistency for write-read. GCS has strong consistency. S3 has as well, but with some caveats, so we are not 100% sure. Let's invest some time to dig it further. In the worst case, we can add code to make strong consistency happen (poll the block until it is listable? and fully uploaded?)

Set up some consistent storage then additionally (etcd?). We wanted to avoid external deps, so this is not really preferable solution.

Handle eventual consistency gracefully. This needs to be investigated more deeply, but for example for compactor it can mean optimistic compaction: Refactor compactor to be aware that we are not really sure that these blocks we have visible now are really ALL of them. It kind of works like that when we add support for vertical compactions (?). But it needs to be investigated more for other consequences.

We tried to mitigate lack of certainty of consistency with sync-delay but that introduced other problems, so we needed to remove it. Worth to revisit this issue and be clear about our consistency assumptions in Thanos.

https://thanos.io/proposals/201901-read-write-operations-bucket.md/ was created in Dec 31, 2018, we will open separate issue to track work defined there.


Injecting User details to services (online, offline) servers and using Auth config

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes

/lgtm


Sitemap caching

Hello Tobi,
If you have a lot of pages, retrieving the sitemap.xml can sometimes take more than 15 seconds. There is currently no way to cache the sitemap.xml, as Kirby caching does not work here.

do you have any additional information for me? caching should work and does for my sites:

Hello,
we're facing the same issue here. The "sitemap.xml" URL takes ages to appear.
We have +650 txt files in content (and counting) with a variety of different blueprints/templates.
Many files are used as "modules" to be included/linked to via blocks (similar to your Forms) in the actual articles and pages or serve as "Internal" pages and content only accessible within the Panel (like help pages or file listings).
I added their templates to the excludeTemplates of the config:
'excludeTemplates' => [
	'error',
	'form',
	'forms',
	'guide-chapter',
	'listings',
	'intropages',
	'mediathek',
	'category',
	'panel-categories',
	'shared',
	'panel-shared',
	'card',
	'panel-cards',
	'definition',
	'panel-module',
	'module-html',
	'module-data',
	'panel-help',
	'panel-storage',
]

How is caching enabled for the sitemap or what may cause this delay?
I suspect it may evtl. even error out (for whatever other reason) w/o showing an error 'cos I sometimes wait for MINUTES and the "sitemap.xml" page still remains blank
What other information do you need?
Thanks.

The sitemap is cached after full generation using the normal Kirby pages cache.
You can write a custom generator method that uses partial caching if you need so.
Generally I can't do anything against it running out of time/RAM since Kirby doesn't have a feature for queuing/background tasks. Please upvote this and maybe we will get it in Kirby 6.

I assume the amount of excludeTemplates canhave a negative effect?
anyway upvoted.
thanks

Kirby will always resolve all pages because of the use of $site->index(), in order to filter by template Kirby has to read the file first.
The only way to mitigate this is by moving the generation process to the background and allow it to exceed the 30 sec PHP max execution duration and the RAM limits. This would need queuing/managing the stuff, which should be a Core feature.


fix typos

Deploy preview ready!
Built with commit 6dd7554c0e46937f75f648bfba996a2a7d80a273
https://deploy-preview-706--docker-docs.netlify.com

Thanks, @friism !


heavy metal filter

hi , i need a heavy metal filter, can you tell me how do i?, thanks!

hi @bianzhifeng ,
what meaning of heavy metal ?

you can download MIX app and choose heavy metal filter

Hi @bianzhifeng ,
Can you provide your question with more details, like website address for others could help you quickly?
Thanks

https://itunes.apple.com/app/id913947918.

sorry, i don't know how to describe this filter.

can you find this filter at MIX App? @erickingxu


Steps for Setting-Up Compose Destinations on a Multi Modular Project

Hi Ram,
I'm completely lost and I don't where to start to set-up Navigation for a Multi-Modular Project. I have also checked other related issues eg. #149 , #419 and even #216 but I still can't get started.
All I know is that I want each feature module to expose a single destination that belongs to a navigation graph containing destinations from other feature modules.
Thanks for providing Tivi's link but I will be lying if I say I understand what is happening.
Kindly requesting for a short List of Steps Involved to set-up Compose Destination in a Multi-Modular Project. This way I will try to implement the steps one after the other.

Hi @Tonnie-Dev !
Thank you for doing this!
Want to contribute it to the docs repository? It will be included in the documentation website automatically as soon as it gets merged.
As you'll see the pages are just markdown with some special capabilities, but nothing crazy. So it's super easy to contribute!
https://github.com/raamcosta/compose-destinations-docs
I think it should go under "common use cases" as a new sub page there.

Just as a FYI, the reason I haven't done this is because the multi module support is still a bit to rough and manual and I am thinking of providing easier integration in v2 version of this library. So keep in mind that most of this can and probably will still change / be improved.

Hello @raamcosta
Thanks for your kind comments. I am excited that this is being looked at for improvement in Version 2.
I'm not a Pro in Documentation but I will chip in with your approval.
Once again thanks for this great Library, all efforts in improving the libray is really worth it!

I finally submitted the documentation although I accidentally messed up on the PR but managed to resolved the confict.

Just as a FYI, the reason I haven't done this is because the multi module support is still a bit to rough and manual and I am thinking of providing easier integration in v2 version of this library. So keep in mind that most of this can and probably will still change / be improved.

Hello @raamcosta , I would like to ask you if there is a roadmap/timeline for the improved multimodule support? I would like to use the library in the upcoming project and just wondering if I should wait a little for the  support.
Btw great library and exceptional support 👍

Hi!
Thank you 🙏
I’m still targeting the end of the year, but it’s possible I’ll need January as well.
And the idea is to start with an alpha version so I can get feedback about it 🙂

V2 is here and has new and improved multi module setup!
Check it here:
https://composedestinations.rafaelcosta.xyz/v2/multi-module-setup

@raamcosta Thanks lots for following through on V2, can't wait to start messing with it soon. 🎆 🍾 😄


add instructions for handling large log files

Changes

log size is limited by the LOGS_BUFFER_SIZE and it is not logical to
increase it too high
Reaching this limit causes the response to be broken in chunks where
each chunk is a valid JSON/proto response but the complete response is
no longer a valid JSON/proto
This must be handled from the client size by parsing each chunk and
then combining the data field to retrieve the complete log
Added example for handling such case using bash commands

Signed-off-by: Avinal Kumar<EMAIL_ADDRESS>
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you review them:

[x] Has Docs included if any changes are user facing
[ ] Has Tests included if any functionality added or changed
[x] Tested your changes locally (if this is a code change)
[x] Follows the commit message standard
[x] Meets the Tekton contributor standards (including functionality, content, code)
[x] Has a kind label. You can add a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
[x] Release notes block below has been updated with any user-facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
[ ] Release notes contain the string "action required" if the change requires additional action from users switching to the new release

Release Notes
none

/kind documentation
/ok-to-test

cc: @khrm @enarha @sayan-biswas

/lgtm
This suggests that we need a better mechanism for serving large logs as a stream of text. Requiring all of the data to be streamed before base64 decoding will not scale to mutli-gigabyte log files.


make use of new CommonHttpProtocolOptions.MaxRequestsPerConnection

Please provide a description of this PR:
cluster.MaxRequestsPerConnection has been deprecated for long
To help us figure out who should review this PR, please put an X in all the areas that this PR affects.

[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

Please check any characteristics that apply to this pull request.

[x] Does not have any user-facing changes. This may include CLI changes, API changes, behavior changes, performance improvements, etc.

@hzxuzhonghu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
dbaef941771d6d1f9efedfdefd2583b458469538
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

I think this needs version guard to work with old proxies

It has long been deprecated, and istio does not support version x-1 proxy connects to version x control plane, so i guess no problem

It has only been deprecated in 1.20 https://www.envoyproxy.io/docs/envoy/latest/version_history/current#new-features - not yet released. I am sure it will have issues with 1.11 because 1.11 uses 1.19.

you are right, it was indeed just deprecated

@hzxuzhonghu: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ramaraochavali ptal

@hzxuzhonghu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
9ca0ad4104e4c15f45773e38448f9ae974501989
link
true
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot-multicluster-tests_istio
f97b96cd8d7b2186ba8bcf981506696a2215db54
link
true
/test integ-pilot-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-pilot-multicluster-tests_istio


Use of "Release-As:" in commit

TL;DR
Per the docs, previously I could force a version by adding Release-As: 0.2.0 somewhere in the body of the commit message used in the squash-merge to main regardless of other content in the message.  Now it seems to only work if Release-As: 0.2.0 is not accompanied by other Github things like co-authors or perhaps just any presence of --- in the commit message.
Expected behavior
The GHA workflow run would create/update the release-please PR with the version provided in the Release-As: line.
Observed behavior
It does not set the provided version.
Action YAML
on:
  push:
    branches:
      - main

name: release-please-workflow

jobs:
  tag-new-version:
    permissions: write-all
    runs-on: ubuntu-latest
    outputs:
      release_created: ${{ steps.release-flag.outputs.release_created }}
      release_tag: ${{ steps.release-tag.outputs.release_tag }}
    steps:
      - name: Create Release Tag
        id: tag
        uses<EMAIL_ADDRESS>      - id: release-flag
        run: echo "release_created=${{ steps.tag.outputs.release_created || false }}" >> $GITHUB_OUTPUT
      - id: release-tag
        run: echo "release_tag=${{ steps.tag.outputs.version || false }}" >> $GITHUB_OUTPUT
      - id: release-debug
        run: echo "$GITHUB_CONTEXT"

  publish-release:
    needs: tag-new-version
    if: ${{ needs.tag-new-version.outputs.release_created == 'true'}}
    runs-on: ubuntu-latest
    steps:
      - id: publish-debug
        run: echo "$GITHUB_CONTEXT"
      - name: Publish Release Artifact
        id: echo-release
        run: echo "RELEASE ARTIFACT WILL BE CREATED AT THIS POINT"

Log output
no useful log info

Additional information
workflow:  https://github.com/MxNxPx/quick-test/blob/main/.github/workflows/release-workflow.yaml
commits to main:  https://github.com/MxNxPx/quick-test/commits/main/

I am also facing the same issue.


Lighthouse audit suggests font be loading using

Lighthouse suggest performance improvement where font should be indicated as preload.

I am unsure how to change the iconfont to be preloaded?

Me too ;) Any suggestions?

I'm no expert at @vue/preload-webpack-plugin, but this is what I ended up with in my vue.config.js:
// ...
module.exports = {
  // ...
  chainWebpack: (config) => {
    // ...
    const isLegacyBundle = process.env.VUE_CLI_MODERN_MODE && !process.env.VUE_CLI_MODERN_BUILD;
    if (!isLegacyBundle) {
      config.plugin("preload").tap(() => {
        return [{
          rel: "preload",
          include: "allAssets",
          fileWhitelist: [/.*\.css/, /.*\.js/, /.*\.woff2$/],
          fileBlacklist: [/\.map$/, /hot-update\.js$/]
        }];
      });
    }
    // ...
  }
};

Seems to have fixed the issue so far.

Any solution with Angular CLI ?


How to change items to be Recycled and which not to Recycle?

Keep having the issue in which the bot will keep high amounts of pokeballs and yet gets rid of other items I need. Someone know where I can find the location to modify these values? Thanks and sorry for the newb questions..

Edit your item filter in config.json (e.g.):
"item_filter": {
"1":   { "keep" : 100},
"2":   { "keep" : 100},
"3":   { "keep" : 100},
"101": { "keep" : 0 },
"102": { "keep" : 0 },
"103": { "keep" : 80 },
"104": { "keep" : 30 },
"201": { "keep" : 80 },
"701": { "keep" : 100 }
},
The numbers to the left of the brackets (such as "1":, "2":,"3":, etc.) denote the item IDs. These item IDs are in your /PokemonGo-Bot/data/items.json:
{
"0": "Unknown",
"1": "Pokeball",
"2": "Greatball",
"3": "Ultraball",.... etc.

Thanks Mate =)

I tried it and having a issue launching, can you look at this picture and tell me what is wrong and possibly correct it for me? Sorry again =\ http://imageshack.com/a/img921/3108/EeGyQi.png

JSON error, use http://jsonlint.com/ to check your JSON

said it was valid =\

remove } just before item_filter

still not working...


Issue694: Dealing with file drop directory name

So everything works as expected EXCEPT ~. Even after expanding using path.expanduser and escaping it, it still doesn't work.
Deals with #643 and #694

Codecov Report

Merging #715 into master will increase coverage by 0.05%.
The diff coverage is 57.14%.

@@            Coverage Diff             @@
##           master     #715      +/-   ##
==========================================
+ Coverage   87.91%   87.96%   +0.05%
==========================================
  Files          48       48
  Lines        3765     3781      +16
==========================================
+ Hits         3310     3326      +16
  Misses        455      455

Impacted Files
Coverage Δ

vent/menus/main.py
76.2% <0%> (-0.93%)
:arrow_down:

vent/helpers/meta.py
71.6% <100%> (+0.35%)
:arrow_up:

vent/core/rq_worker/watch.py
48.59% <100%> (+3.47%)
:arrow_up:

vent/api/plugins.py
93.22% <0%> (+0.26%)
:arrow_up:

vent/menus/tools.py
88.62% <0%> (+0.59%)
:arrow_up:

vent/api/plugin_helpers.py
81.87% <0%> (+0.6%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 783ab54...377fc87. Read the comment docs.


Admin rights check

Spec discussion: https://github.com/ontola/atomic-data-docs/issues/82
When processing search or collection queries, by far the most time is spent on iterating over every resource, and recursively checking whether the user has the correct rights.
A very simple way of speeding this up, is to check if the user has some root level / admin level rights. That way, we could skip all these checks, and make things way faster.
Relates to #279

Perhaps when implementing this, I should also update the default .save behavior, since that one uses the default_agent, which should probably have admin rights if we fix this issue.


Put in hash_algorithm in config to switch between SHA256 and SHA3_512

Would appreciated refactoring's as my knowledge of Python OO is limited. This is very useful for us and having in a config allows much easier testing and deployment.

Hi @djhmateer I've updated the names so they are standard instead of reflecting python's nomenclature SHA-256 or SHA3-512 and made this into a global Archiver property like TMP_FOLDER is for Storage, as this way it requires less visual complexity, there could be better OO approaches here, but those would require some refactor that I don't think is worth the time. Let me know if you see any issues, otherwise I'll merge to dev soon.


Add googletest test framework

[x] merge #106
[x] determine reason for test failures

CI fails as we cache submodules (but we just added a new one and it's empty).

Is COBS decode being called correctly in the random data test? I get the follow errors when I run the test:
oliver@canopus:~/repos/phobos/tests/build$ ./test_cobs_random
Running main() from gtest_main.cc
[==========] Running 10 tests from 1 test case.
[----------] Global test environment set-up.
[----------] 10 tests from CobsRandomInput/CobsRandomDataTest
[ RUN      ] CobsRandomInput/CobsRandomDataTest.RandomInput/0
/Users/oliver/repos/phobos/tests/test_cobs_random.cc:47: Failure
      Expected: des_res.status
      Which is: 4-byte object <03-00 00-00>
To be equal to: cobs::DecodeResult::Status::OK
      Which is: 4-byte object <00-00 00-00>
[  FAILED  ] CobsRandomInput/CobsRandomDataTest.RandomInput/0, where GetParam() = 10 (0 ms)
[ RUN      ] CobsRandomInput/CobsRandomDataTest.RandomInput/1
/Users/oliver/repos/phobos/tests/test_cobs_random.cc:47: Failure
      Expected: des_res.status
      Which is: 4-byte object <03-00 00-00>
To be equal to: cobs::DecodeResult::Status::OK
      Which is: 4-byte object <00-00 00-00>
[  FAILED  ] CobsRandomInput/CobsRandomDataTest.RandomInput/1, where GetParam() = 100 (1 ms)
[ RUN      ] CobsRandomInput/CobsRandomDataTest.RandomInput/2
/Users/oliver/repos/phobos/tests/test_cobs_random.cc:47: Failure
      Expected: des_res.status
      Which is: 4-byte object <03-00 00-00>
To be equal to: cobs::DecodeResult::Status::OK
      Which is: 4-byte object <00-00 00-00>
[  FAILED  ] CobsRandomInput/CobsRandomDataTest.RandomInput/2, where GetParam() = 200 (0 ms)
...

@oliverlee Random test code code seems correct. I'd have to inspect the input data, encoded (input  data) and decoded (encoded (input data)).

Looks good.

Are the tests running? It doesn't look like it from the logs.


Feature:  Add GraphiQL Explorer

A company called OneGraph has an awesome addition to GraphiQL called "GraphiQL Explorer" -- it would be great to integrate that into this app as well.
GraphiQL Explorer

I took a shot at this with #152! It needs a bit more work, but waiting to hear back for guidance first.

မိတ္ဆက္ေပးသူ

မိတ္ဆက္ေပးသူ

မိတ္ဆက္ေပးသူကုဒ္ :

မိတ္ဆက္ေပးသူအမည္ :

ID ကို႐ိုက္ထည့္ပါ : *

စကားဝွက္ကို႐ိုက္ထည့္ပါ : *

ေလာဂ့္အင္

This is a much needed feature


--write reference undefined error in some case

Problem
Error occured when running jsr<EMAIL_ADDRESS>--write in
https://github.com/Milly/denops-batch-accumulate/tree/875b71c14001c0520cd84f60c3be767c4a80ccbc
Actual
> git clone https://github.com/Milly/denops-batch-accumulate.git
> cd denops-batch-accumulate
> git checkout 875b71c14001c0520cd84f60c3be767c4a80ccbc
> deno run -A jsr<EMAIL_ADDRESS>deno.jsonc --write
� @denops/core 7.0.0 →  7.0.1
� @denops/std 7.0.0 →  7.0.3
� @denops/test 3.0.1 →  3.0.3
� @std/assert 1.0.1 →  1.0.2
� @std/async 1.0.1 →  1.0.2
� @std/testing 1.0.0-rc.5 →  1.0.0
error: Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'replace')
  lines[index] = lines[index].replace(outdated, stringify(updated));
                              ^
    at rewriteImportMap (https://jsr.io/@molt/core/0.19.1/refs.ts:181:31)
    at Module.rewrite (https://jsr.io/@molt/core/0.19.1/refs.ts:137:7)
    at eventLoopTick (ext:core/01_core.js:168:7)
    at async Update.write (https://jsr.io/@molt/core/0.19.1/mod.ts:212:11)
    at async https://jsr.io/@molt/cli/0.19.1/main.ts:92:9
    at async Command.actionHandler (https://jsr.io/@molt/cli/0.19.1/main.ts:90:5)
    at async Command.execute (https://jsr.io/@cliffy/command/1.0.0-rc.5/command.ts:1940:7)
    at async Command.parseCommand (https://jsr.io/@cliffy/command/1.0.0-rc.5/command.ts:1772:14)
    at async https://jsr.io/@molt/cli/0.19.1/main.ts:113:1

Environment
OS: Windows 11 23H2 (Build 22631.3880)
Deno: deno 1.45.4 (release, x86_64-pc-windows-msvc) v8 <IP_ADDRESS> typescript 5.5.2
@molt/cli: 0.19.1

Could you try<EMAIL_ADDRESS>as well just in case it's been fixed?

OK I have reproduced it with both 0.19.1 and 0.19.3.
You can workaround it by not specifying deno.jsonc explicitly or specifying it with --config.
Thanks for reporting all the time :pray:

The workaround worked!
Thank you!


Update bitflags to latest version

What does this PR do
Update dependency of bitflags to latest release to avoid duplicate crate versions in serialport.
Checklist:

[x] I have read CONTRIBUTING.md
[x] I have written necessary tests and rustdoc comments
[x] A change log has been added if this PR modifies nix's API

Thank you for the hint. Alas, both commands fail:
~/RustroverProjects/nix> cargo update -p bitflags --precise 2.3.1
error: There are multiple `bitflags` packages in your project, and the specification `bitflags` is ambiguous.
Please re-run this command with one of the following specifications:
<EMAIL_ADDRESS><EMAIL_ADDRESS>~/RustroverProjects/nix> cargo update -p bitflags --precise 2.5.0
error: There are multiple `bitflags` packages in your project, and the specification `bitflags` is ambiguous.
Please re-run this command with one of the following specifications:
<EMAIL_ADDRESS><EMAIL_ADDRESS>~/RustroverProjects/nix>

That means that you have some other dependency pulling in bitflags-1.3.2.  In that case, modify the commands I posted to specify the exact version of bitflags that you want to update, like this for example: cargo update -p<EMAIL_ADDRESS>--precise 2.5.0


straighten out codecov

This is a consequence of #185

This is all set. CodeCov actually figured out the repo rename on its own and no action was required.


Parallelization

I'm going to break down my current understanding of how CSS blocks works (I think as long as I'm close enough it will work for explanation purposes)

Find all the CSS Blocks files (recursively)
Parse out all the selectors for the CSS Blocks files
Create interfaces for every CSS Blocks file
Transform CSS Blocks files(?)
Find all the JS/HBS files that use CSS Blocks
Parse out all the usages of CSS Blocks
Replace them with the appropriate selectors
Continue transforming JS/HBS files by whatever tool CSS Blocks is running inside

The problem with this design is that in expects to happen in a very specific order and to have all the information it needs before continuing. This means that you cannot parallelize the transformation of CSS Blocks files and JS/HBS files that use CSS Blocks.
In a large app where every component uses CSS Blocks, this will have a really noticeable performance impact, you'll be blocking the transformation of hundreds if not thousands of files on an effectively synchronous process.
So I would like to revisit the design of CSS Blocks to see if there are things that we can do so that JS/HBS files and CSS files can be transformed in parallel, even if it means we have to revisit JS/HBS files after the CSS is done.

Transform CSS Blocks/JS/HBS in parallel

CSS Blocks

Parse out selectors
Create interfaces
Transform(?)

JS/HBS

Replace usages of CSS Blocks with "references" that can be optimized out later
Transform

Optimizations after everything has been transformed

Validate CSS Blocks interfaces in JS/HBS
Optimize away references in JS/HBS with appropriate selectors

These references could be just strings that CSS Blocks is able to identify:
"css-blocks-ref:path/to/button.css:size(small)"

Or maybe something more complex than that. The point is that you could come back later on and map it to something that was calculated in parallel elsewhere.
/cc @devongovett

@jamiebuilds is it still open? I could work on this.


I don't get the authClient behaviour with Promises

May be I am misunderstanding the authClient feature, but here is what I am observing with admin-on-rest 1.2.1:

User navigates to resource action page:
AUTH_CHECK is triggered.
authClient returns a Promise. Admin-on-rest continues state transition without waiting for promise resolution. In my case the user's access token is expired and I want to attempt a silent renew before resolving/rejecting the promise.

User attempts API action without being authenticated:
AUTH_CHECK is not triggered.
AUTH_ERROR is triggered. status is not in params (API returned 401, but anyway, not a big deal)
authClient returns Promise. Admin-on-rest shows error message to user without waiting for promise resolution. When promise is resolved admin-on-rest does not re-attempt the request.

Here is what I expect the behaviour to be:

Show spinner and don't proceed with state transition until promise is resolved/rejected. If promise rejected redirect to login page instead.
Show spinner and don't show message to user until promise is resolved/rejected. If promise is resolved re-attempt failed request. If promise is rejected show error message to user.

That's a consequence of an aggressive frontend performance optimization we've made (optimistic rendering). What you experience is a race condition, where the response of the initial AUTH_CHECK arrives after the unauthentified API call.
I don't want to fallback to pessimistic rendering as you suggest, it would harm usability a great deal.
But maybe we can handle this case using a custom saga, delaying the AUTH_ERROR notification until the AUTH_CHECK response has arrived.

Hi, is there any news on this?
We are in the same situation, trying to autorefresh token when expired.

We have a similar issue with this behavior.
After a auth error the login page does not redirect to the correct page.
Example: the user (not logged in) clicks a link to the app at /reviews/1234, because the API is called even AUTH_CHECK rejected the user gets redirected to the list.
Current:  /reviews/1234 =>  /reviews => /login => /reviews
Expected:  /reviews/1234 =>  /login => /reviews/1234
What is happening:

AUTH_CHECK => reject
AUTH_LOGOUT => resolve (nextPathname = /reviews/123)
Failed to load resource (401, api/reviews/123)
AUTH_ERROR => resolve
AUTH_CHECK => reject
AUTH_LOGOUT => resolve (nextPathname = /reviews)
Failed to load resource (401, api/reviews)
AUTH_ERROR => resolve
AUTH_LOGOUT => resolve (nextPathname = undefined)
login page shows

Our authClient and restClient are based on the clients from the demo app with minor modifications.
AUTH_CHECK does reject directly without any async API call.
Is there a way to prevent this?
The only workaround I know of is do not return 401 at the API level …
This issue is not reproducible in the demo app because the fakeRestServer always returns 200 responses.


add a bootstrap script

This PR

removes lock files.

Libraries don't need these, only apps do. In practice, if we use lock files, we have less chance of catching in-range breaking changes in dependencies, and end users will experience such breakages before we notice them. These lock files are ignored by npm install or yarn install. Lastly, adding an npm shrinkwrap lock file will eliminate the ability for semver dependency version resolution to work properly, leading to issues like dependency forks (i.e. multiple of the same package with differing patch or minor version numbers even though they are compatible, leading to issues like libraries not working due to duplicate singleton instances existing within an app).

updates @types/jest to avoid a dependency fork (npm 7+ throws errors on these)
add lerna bootstrap to package.json install so that after installing dependencies at the root, dependencies for all packages will be installed, and dependent packages will be automatically linked together for faster dev iteration.

I wanted to replace jest with uvu anyways.

@trusktr mind resolving the conflicts? Then I can merge! =)


magnum-image: use $clouddata instead of clouddata.cloud.suse.de

While the test had failed somewhere in magnum, I verified that the download still worked fine.


Clear batch store on view change

Description
This changeset clears the batch store on view change, does not start the request timer when not in an active view, and decreases the batch timeout to be less than the request timeout.
Usual SMEs are @kchristidis @corecode and @tuand27613, though you may wish to check PR #2007 (the companion to this PR against 0.5) for signoffs.
Motivation and Context
This is intended to address symptoms of #1874 as well as a duplicated deploy transaction seen in busywork.
If a replica was a primary and had a transaction in its batch store when the view change timer expired, it would include that request in the next batch when it became primary again, leading to transaction duplication.
If only a single request came in, then the view change timer would expire before the batch was created, and the network would view change over and over again until another request came in, never executing the first request.
Finally, while processing a new view, it was possible for the request timer to start, negating the doubling of the new view timer.
How Has This Been Tested?
This has been tested against the busywork stress2b test, and a new unit test checking for the batchStore emptying on view change has been added.
Checklist:

[X] I have added a Signed-off-by.
[X] I have either added documentation to cover my changes or this change requires no new documentation.
[X] I have either added unit tests to cover my changes or this change requires no new tests.
[X] I have run golint and have fixed valid warnings in code I have added or modified. This tool generates false positives so you may choose to ignore some warnings. The goal is clean, consistent, and readable code.

The continuous integration build process will run make checks to confirm that tests pass and that code quality meets minimum standards. You may optionally run this locally as PRs will not be accepted until they pass.
Signed-off-by: Jason Yellick<EMAIL_ADDRESS>

Reviewed as part of PR #2007 in the 0.5 branch. LGTM


Weird backspace issue when using type"email"

Are you submitting a bug report or a feature request?

Bug Report
What is the current behavior?

See https://codesandbox.io/s/yk5y52nzp9
Steps to reproduce.
Goto above sandbox link.
Type "test test" into the test field field. Backspace 5 times (Or more).
Current Behavior: It doesn't appear to continue to backspace. It resets the cursor position to the start of the string when it hits a space at the end of a word.
What is the expected behavior?
Cursor should be after the first test, and continuing to hit backspace should clear the field.
Sandbox Link
https://codesandbox.io/s/yk5y52nzp9
What's your environment?
See sandbox. Latest chrome version.

Wow, that is really bizarre.

Type the value "a a" on the input
Press backspace one time
If you console.log the value of the input it has "a".

The odd thing is: you pressed backspace only one time so the value of the input should be "a " (with a space after)
I couldn't investigate more.. hope this helps a little..


Move edit-distance file directory to fv-postCollation repo

As agreed with @raffazizzi, I'm moving the edit-distance directory and processing over to the fv-postCollation repo as a more appropriate location for processing work! The fv-data repo is really just for files we're prepared to release to the Variorum.

Moved the files!


Missing a crucial data file: Lung_FPKM.csv

When attempting to reproduce the code, I encountered an issue with a missing data file: Lung_FPKM.csv. This file is crucial for the successful execution of the code. I am currently utilizing this code in my ongoing work.
This repo is really helpful, which has been highly beneficial to my research, providing valuable insights into the Mapper algorithm in Topological Data Analysis (TDA).
Would it be possible for you to upload the missing file at your earliest convenience?
I greatly appreciate your efforts and support.

Sorry about that. I just added a zip file of the file Lung_FPKM.csv (since the original csv file was too large to add to github). Please let me know if you run into any other issues.


Support some options via data attributes

now content, openOn and position can be set via data attributes
as per https://github.com/HubSpot/tooltip/pull/45

thanks for the feedback @geekjuice I've updated the PR pls take a look when you have a chance

Sorry for the delay :crying_cat_face:
I'm back from hiatus so I should be more responsive going forward.
Everything looks great, but I did have one question: If a data-attribute is available, should it override anything set programmatically vis constructor? The changes here seem to hint that anything set on the DOM element directly data-attribute has higher precedence than options set from using the constructor API.
Just wanted to confirm if this was intended or if we should still give options set by the constructor API precedence. I actually think the current implementation makes more sense, but just wanted to confrim before merging. :+1:

hey @geekjuice no worries thanks for getting back o/
and yeah the idea is any data attribute would override constructor level settings it seems to make sense (same approach with inline css styles for example). Let me know if you'd like this other way
cheers

Awesome. Just wanted to confirm that. LGTM :tada: :+1:


Parse error on seemingly valid HTML

I am trying to run the following HTML through the toRichText function:
Age (use days if <1 month, months if <1 year):
This results in:
flutter: simple_html_css Exception: Closure: () => String from Function 'toString':.: <!DOCTYPE expected at 1:21
flutter: simple_html_css Stack Trace: #0      XmlEventIterator.moveNext (package:xml/src/xml_events/iterator.dart:35:9)
flutter: #1      Parser.parse (package:simple_html_css/src/internals.dart:150:34)
flutter: #2      HTML.toTextSpan (package:simple_html_css/src/html_stylist.dart:83:21)

I am getting the same result if I am using < instead of the <.

Sorry for the delay. I'm a little busy these days. I'll look into it as soon as I have the time.

@tiloc Sorry as of now there are no easy ways around this. If you tried to fix it one way, it breaks the other way. This issue needs some more time put in and might involve quite a bit of refactoring which I unfortunately cant afford at the moment. This issue has to do with the two dependencies of this package. htm_unescape and xml. You can see a similar case in this issue here in the xml repo.
For your use case If you know that starting angle brackets (<) of html tags wont be escaped as < then you can somewhat by pass this error yourself by forking this package and adding some code, which i can help with if thats the case.

Ok, thanks for the background info. Unfortunately, I also have very little time I can invest. So I guess this will just be a known limitation for the time being.

+1

+1

@ali-thowfeek Hello. We recently ran into this issue as well when using this package.
From what we could see the problem is apparently in this line when using HtmlUnescape. If we remove the unescaping, everything works as expected (at least from our side).
- final Parser parser = Parser(context, HtmlUnescape().convert(content),
+ final Parser parser = Parser(context, content,

The example string in the issue comment Age (use days if <1 month, months if <1 year): would then be passed as-is to the parser instead of being converted to Age (use days if <1 month, months if <1 year):.
That said, we see this is the only place where html_unescape is being used in the package, so in all likelihood the unescaping is being done on purpose, and we're not sure if this would end up causing some unintended behaviors.
Would it be fine to remove the unescaping here?

Hi @fjwong Its been quite a while since I worked on this.
I see your problem. In that case instead of removing the unescaping part would you be able to create a PR which makes it unescape by default (So that it stays backward compatible) and by passing an optional boolean flag you could disable unescaping.
Although this will not solve the issue, this would at least give a choice to bypass it
CC: @nohli any comments?

If it's a bug, we could think about a breaking change and removing it.
The bugfix should be the default imho.
Any idea why the package uses html_unescape? Does removing it break functionality?

@nohli my initial requirements had a lot of text with html escaped characters thus I included it within the package. But removing it won't actually break anything. Only thing is we would have to pass unescaped strings for rendering, as RichText doesn't unescape by itself.
Nevertheless removing unescaping would solve this error only if the string which has < > is escaped as < >, still in this case the characters: < and > and any other escaped characters are not going to be rendered correctly rather it'll be rendered as < and > etc. And in the case where they are not escaped, we would still have this error even after removing unescaping. Thus I believe unescaping is not the cause of this issue.
Angle brackets are always going to be a problem. Unless if someone could find another way.
One possible way, which I haven't tried is enclosing any occurrence of angle brackets with CDATA like below:
<![CDATA[Age (use days if < 1 month, months if < 1 year):]]> This is valid XML. And we can have unescaping around, if this would work. And it would solve this issue fully.

@ali-thowfeek @nohli I've submitted a PR with the changes suggested in https://github.com/ali-thowfeek/simple_html_css_flutter/issues/17#issuecomment-1772417562.
Unescaping is done by default, but please let me know if you would prefer to have this inverted, or have any further changes in the PR.

Nevertheless removing unescaping would solve this error only if the string which has < > is escaped as < >, still in this case the characters: < and > and any other escaped characters are not going to be rendered correctly rather it'll be rendered as < and > etc.

I guess the concern is with other escaped entities such as × (if present in the html content) which would end up not being rendered as expected if unescaping is removed, since these are escaped entities in HTML but not in XML, and thus ignored by the parser.
I'm not sure if this would be a better or worse alternative, but I guess we could keep unescaping and just handle < and > separately like:
content = content.replaceAll('<', '&lt;'); // After unescaping, this would be converted back to < to be readable by the XML parser
content = content.replaceAll('>', '&gt;');

It feels a bit hacky-ish though, and I'm not sure if this would result in other unintended behaviors.

One possible way, which I haven't tried is enclosing any occurrence of angle brackets with CDATA like below:
<![CDATA[Age (use days if < 1 month, months if < 1 year):]]> This is valid XML. And we can have unescaping around, if this would work. And it would solve this issue fully.

Just in case, I tested doing this on my side and, while the content appears to be parsed as valid XML and doesn't throw any errors, the text content within CDATA is not rendered at all.

In any case, please let me know if you have any feedback on the matter.

Fixed by https://github.com/ali-thowfeek/simple_html_css_flutter/pull/29 available on v4.0.1
And unescaping will be remove in the upcoming Major release to avoid tight coupling.
Also the issue is fixed in the xml dependency: https://github.com/renggli/dart-xml/issues/123 hence, removing unescaping from my package will allow to render texts such as this: Age (use days if <1 month, months if <1 year): without issues.
Yet a known issue is still around where, if the text contains an unescaped < within the tags, it'll still fail because of the strictness of xml.


FGA presses Xiaomi turbo mode buttons

Preparation

[X] I tested the latest release
[X] I looked at other issues (even the closed ones)
[X] I read the Troubleshooting Guide

FGO server
NA, JP
FGA build number
1709
Describe the bug
With a new MIui update and the JP game going 60fps I was testing playing with Turbo in the Xiaomi Note 10 and I found that is running the game far better than expected. My issue begins when trying to start FGA with it. The moment FGA is testing the servant cards it pulls the Turbo menu and desynchs. Any advice on how to configure the FGA so both can work together?
Video
https://youtu.be/gVHcU4CB_-U
Device model
Xiaomi redmi note 10s
Android version
12
Screen size
1080x2400
RAM
6GB

Sorry, FGA needs the top right because that's the only place we can use to close dialogs because everything else is covered in buttons or windows.

Sucks but it is what it is, the new Game Turbo is great, Pushes NA to 60FPS and allows JP to go steady with almost no drop. But honestly I value FGA more. Thanks

For NA, there's BetterFGO by rayshift.io: #1300
There's also a JP version, but FGA can't handle translated buttons right now.

Mmm, don't think I will use it. Thanks anyway, I will save Turbo for fights, lostbelt and any other thing we're I don't need to farm.


fix: mysql addr bug

alertgateway start tigger connect error:
KeyError: 'mysql_password'

you can see mysql_password in mysql container ，/install-compose/mysql-compose/docker-compose.yml


Backup dba database master key

Fixes #1611
Changes proposed in this pull request:

Change Param from BackupDirectory to Path

How to test this code:

[ ] Backup-DbaDatabaseMasterKey -SqlInstance server1 -Path \server1\BackupTest\
[ ]

Has been tested on minimum requirements:

[ ]  Powershell 3
[ ]  Windows 7
[ ]  SQL Server 2000

Has been tested on maximum requirements:

[ ]  SQL Server vNext
[ ]  Windows 10
[ ]  Azure Database

Tests for tester:

[ ] Working/useful help content, including link to command on dbatools web site
[ ] All examples work as advertised
[ ] Does not contain template content
[ ] Does not contain excessive/unnecessary amounts of comments
[ ] Works remotely
[ ] Works locally
[ ] Works on lower versions or throws error specifying version not supported
[ ] Works with named instances
[ ] Works with clustered instances
[ ] Handles offline/read only databases
[ ] Supports multiple servers (at the command line or piped from Get-SqlRegisteredServerName)
[ ] No un-handled errors which stop the command working with multiple servers

😍


Declare SCROLLBAR_WIDTH variable for strict mode

I was getting the following error after transpiling from ES6 with babel:
ReferenceError: assignment to undeclared variable SCROLLBAR_WIDTH

Hey,
yeah that's one of the things that needed cleanup x)
Thanks!

You're welcome. Thanks for maintaining this.


Need to use "importlib-metadata<5.0" to use Celery

I meet an issue when docker-compose up -d
ImportError: cannot import name 'Celery' from 'celery' (/usr/local/lib/python3.7/site-packages/celery/__init__.py)

I fix it in this way.
(at data-backend/app/pyproject.toml)
...
[tool.poetry.dependencies]
python = "^3.7"
uvicorn = "^0.11.3"
fastapi = "^0.54.1"
python-multipart = "^0.0.5"
email-validator = "^1.0.5"
requests = "^2.23.0"
celery = "^4.4.2"
passlib = {extras = ["bcrypt"], version = "^1.7.2"}
tenacity = "^6.1.0"
pydantic = "^1.4"
emails = "^0.5.15"
raven = "^6.10.0"
gunicorn = "^20.0.4"
jinja2 = "^2.11.2"
psycopg2-binary = "^2.8.5"
alembic = "^1.4.2"
sqlalchemy = "^1.3.16"
pytest = "^5.4.1"
python-jose = {extras = ["cryptography"], version = "^3.1.0"}
importlib-metadata = "<5.0"
...

Reference Issue
https://github.com/celery/celery/issues/7783

I think origin issue were solved, but I have no idea how to apply that on this project...


Consider removing EOL K8s versions

On the devel branch we should be focused on the latest supported versions of K8s, keeping older versions doesn't really guarantee much since they're not supported anyhow.
On the other hand, keeping this support has some maintenance costs for us (code to deploy them, jobs to test them, etc) so removing them makes sense.

already taken care of


Windows support?

Any plans on supporting windows 11?
Pleaseeeeeeeeeeeeee

Hello, currently we do not plan to support Windows in the near future. You may use something like WSL to run F2-nerf on Windows. Sorry for any inconvenience caused.

Thanks for the reply @Totoro97
I will test it out on WSL2 ;-)


Freeze dependencies

So they won't be too eagerly updated and possibly break recline.
Ie.
"jquery": "1.6.x" instead of "jquery": ">=1.6",

agreed. Please submit a PR 😄


Size and color select option

Can anyone help me to add a size or colour select option in product modal

@rajeev-ops You need to add a new field to every single document on your firestore collection.
To my knowledge, you can't yet do this in your firebase console directly but you can try to execute this in your app. You need to remove this once you have successfully run it.
(async function () {
	const col = await firebase.db.collection('products').get();
	col.forEach((doc) => {
		doc.ref.update({
                        // add new field of your likeness and set default value
			frameSize: {
				eye: 50,
				bridge: 20,
				temple: 142,
				height: 36
			},
			availableColors: ['#000000', '#c500c5', '#840309', '#004d84', '#753600']
		});
	})
})()

Now you all you have to do is to update the products view page to consume these new fields. And on the admin, you need to add a new color input field to control these new field.

Please see the latest commit b15e4db
Check the changes and additions for this.

Thankyou so much sir


Monster Muncher Import Fails When Creating Compendium Folders

During the monster import process, when:

Usage of compendium folders is enabled.
Not all compendium folders of the selected kind (A-Z, Monster Type, etc.) exist.
A monster is processed that would required creation of a compendium folder.

The entire import process will fail with a "document is undefined" error in the browser console.
Inspection reveals that the missing compendium folder is created, and retrying the import will process the monster successfully (unless, of course, the import process encounters the above conditions again).
This occurred with approx. version 2.6.26, with other modules enabled, however I will be re-testing later will all other modules disabled and on the latest version (2.71).

99% sure this is fixed now.


Add files via upload

Updated example with changes to bring in line with FINOS

@vitorespindola I am going to let you review this one. Let me know if you want to review together.

Superseded by #34


add autofocus to fix a11y issue with dialog

Add autofocus=true to first TextButton in dialog so that focus automatically goes to an interactive element when dialog is opened.
Before: https://screencast.googleplex.com/cast/NTYxNTczMTk2MDk3MTI2NHxlMjAyOTMzZi1lNw
After: https://screencast.googleplex.com/cast/NTk1NzMxNjYxNTYwMjE3NnxlYWNlM2Q1MC1jYw
fixes b/338656477
NOTE: This would be a good candidate to update the documentation for Dialogs and TextButtons to encourage the user to add autofocus=true on at least one button so that focus automatically goes to an interactive element instead of the actual Dialog element.
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is test-exempt.
[x] I followed the breaking change policy and added Data Driven Fixes where supported.
[x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

cc @yjbanov  I think this should be the default behavior, but I remembered you mention web engine have trouble detecting a new page is pushed

The correct behavior is to focus on the first item in screen order when a new page or dialog is pushed, which is the "This is a typical dialog".
I am not sure if this is possible for web though.

The correct behavior is to focus on the first item in screen order when a new page or dialog is pushed, which is the "This is a typical dialog".
I am not sure if this is possible for web though.

In most cases, yes this is the correct behavior. According to APG, the initial focus can be variable depending on the circumstance of the dialog and what makes most sense for the user. Since this is a simple dialog that conveys information to a user, focus should be set on the first focusable element of "Ok"
An example can be seen at this link:
https://www.w3.org/WAI/ARIA/apg/patterns/dialog-modal/examples/dialog/
Once at the page click on the "Add Delivery Address" button and once the dialog is open, click "Add" at the bottom. Notice that initial focus is set on the OK button, which is the last focusable element. This is for efficiency since most users will simply dismiss the dialog as soon as they have read the message.
Due to the variability in interactive elements that can be in a dialog, initial focus is variable and it sounds like it's really up to the developer to know which initial focus use case is best.
However, I believe in this case in particular for the dialog testing, initial focus should be put on the "Ok" button.

thanks for explanation, I am ok with using auto focus to get around the current behavior.
However, the current behavior is not ideal, looks like it doesn't focus anything. Looking at the semantics tree from the browser devtool, it seems like it is not generating a dialog div. This is something we should look into cc @yjbanov, but not necessary in this pr.

filed https://github.com/flutter/flutter/issues/153791


Check for GRAPHQL_ENDPOINT first

I am curious to know if there is a specific reason for the order in which this plugin checks for the GraphQL URL. I ask because I am working on an integration with graphcool and Netlify but Netlify needs to use the GRAPHQL_ENDPOINT and it won't work if I have a local .graphqlrc/request URL.
Is it possible to check for the GRAPHQL_ENDPOINT first and then fallback to the checks for the package.json or the .graphqlrc
export function parse (path: string = process.cwd()): Config {
  try {
    const packageJson = require(`${path}/package.json`)
    if (packageJson.hasOwnProperty('graphql')) {
      return parseConfigJson(packageJson.graphql)
    }
  } catch (ex) {
    // do nothing here
  }

  try {
    const graphqlrc = JSON.parse(readFileSync(`${path}/.graphqlrc`, 'utf-8'))
    return parseConfigJson(graphqlrc)
  } catch (ex) {
    // do nothing here
  }

  if (process.env.hasOwnProperty('GRAPHQL_ENDPOINT')) {
    ...
  }

  throw new Error('Couldn\'t find a GraphQL config. Please refer to https://github.com/graphcool/graphql-config')
}

Would there be any limitation to doing this? My thought would be the GRAPHQL_ENDPOINT would take precedent over the .graphqlrc request URL.
export function parse (path: string = process.cwd()): Config {

  if (process.env.hasOwnProperty('GRAPHQL_ENDPOINT')) {
    ...
  }

  try {
   ...
  } catch (ex) {
    // do nothing here
  }

  try {
  ...
  } catch (ex) {
    // do nothing here
  }

  throw new Error('Couldn\'t find a GraphQL config. Please refer to https://github.com/graphcool/graphql-config')
}

+1 it would be great to change this order

As of version 3.0, the endpoint url can be specified using the schema option. graphql-config uses string interpolation to provide environmental variables, so it's possible to do something like:
schema: ${GRAPHQL_ENDPOINT}

You can also provide a fallback value if the environmental variable doesn't exist:
schema: ${GRAPHQL_ENDPOINT:"./graphql/schema.json"}

If this still doesn't meet your needs, please let us know by opening a new issue with an explanation of your use case.


Add new parameter to also delete attached assets (files) on each release prior to release deleting

So this seems to work as advertised...but not quite what we expected! :-)
See my note on our issue in OpenRefine: https://github.com/OpenRefine/OpenRefine/issues/2462#issuecomment-645529774
So I think a new parameter is needed perhaps?  "delete_assets_for_release"?

That would gather the release asset_id's https://developer.github.com/v3/repos/releases/#list-release-assets
and then Delete the release assets with https://developer.github.com/v3/repos/releases/#delete-a-release-asset
Finally, deleting the X number of releases themselves.

If you're taking about list of releases listed in
https://github.com/OpenRefine/OpenRefine-nightly-releases/releases?after=3.4-beta-109-g4e9d365, I don't think these releases still exist cuz assets that are not deleted. These releases (I
think they are called "archive files") exist for every tag, the repo has.
The only way to remove these archive files is to delete corresponding tags. Let me know If I understood something wrong

@dev-drprasad
From https://help.github.com/en/github/administering-a-repository/about-releases

Releases are based on Git tags, which mark a specific point in your repository's history. A tag date may be different than a release date since they can be created at different times. For more information about viewing your existing tags, see "Viewing your repository's releases and tags."

So after deleting the release...
We probably need to offer an additional parameter that will delete the tag and assets?
https://developer.github.com/v3/repos/releases/#delete-a-release-asset
Unfortunately, since Releases in GitHub are in fact based on tags as shown in the quote above, when you create a release, it's required to give it a tag.  Which we do.
So we just need to delete the tags additionally.
Unfortunately still, GitHub does not currently supply an API endpoint to delete tags and so regular Git commands need to be used instead via a shell script, etc.  Read more:
https://www.abeautifulsite.net/how-to-delete-a-tag-on-github

@thadguidry
GitHub API supports deleting of tags https://developer.github.com/v3/git/refs/#example-deleting-a-tag
I can add new config property delete_tags (type: boolean) to specify, whether to delete tags or not

@dev-drprasad Great!  Ready to test when you have it available!

Also Reddy, you should signup for https://github.com/sponsors, so some folks can pay you :-)
But for now, send me a private email to my email address<EMAIL_ADDRESS>so that I can at least compensate you some for your time in helping us here!

@thadguidry
I released this under v0.1.0. You don't need to update in your workflow.

I can at least compensate you some for your time in helping us here!

Thanks for offering. But don't mind it. It is open source project and other people going to use it. Although, I am available for part-time work, adhoc work on hourly based. If you need to get any task done, drop me mail at<EMAIL_ADDRESS>I made this https://gist.github.com/dev-drprasad/6162929c3d7ed900dcbd2cf6f804a980 to help you cleanup your old tags. I see lot of them :) . You need to run this multiple times with prefixes like 3.4-beta, 3.3-beta. ☠ CAUTION: I haven't tested it properly ☠


Response Body not pretty printed

What happens?
When there is a successful response, it is printed on a single line.

What did you expect to happen?
The response should be pretty-printed to be more easily readable. Additionally should give the option for raw response.
OpenAPI Document
https://bolt-docs-git-abdul-api-ref-by-scalar-technical-writing.vercel.app/api-bolt/#tag/transactions/GET/v1/merchant/transactions/{REFERENCE}

hey @abdulamite thanks for the issue! a similar one has been opened where a fix is ongoing #3955

Hey @antlio  thank you so much for letting me know! We can close this request. I will follow the other thread!


how construct ./simu_config files from Relate reasults?

Thank you for your software.I have some questions when I used this software.
In the first step, I tried to construct the file which is like the example file in ./simu_condig, but I don't understand how to set 'en' .I am not sure how to set 'en' as described in the example 'en t 0 Nt/Na'. The parameter 't' I calculate using Relate is increasing integers, while in the example, it is decimals, and Nt/Na is also a large number. I want to ask if this is an issue with my population. And this is the popsize.coal file below.
row1 group1
row2 0 500 694.748<PHONE_NUMBER>.35 1863.8 2589.74 3598.43 5000 6947.48 9653.49 13413.5 18638 25897.4 35984.3 50000 69474.8 96534.9<PHONE_NUMBER>80<PHONE_NUMBER>43<PHONE_NUMBER>48 965349 1.34135e+06 1.8638e+06 2.58974e+06 3.59843e+06 5e+06 5e+07
row3 0 0 0.00548889 0.000566733 5.27115e-09 3.20568e-06 1.08257e-05 8.11082e-06 7.32608e-06 5.15276e-06 1.02772e-05 1.16711e-05 1.15036e-05 1.30137e-05 7.88228e-06 7.88483e-06 7.85693e-06 6.26058e-06 7.55161e-06 7.6819e-06 8.48413e-06 6.95591e-06 5.98037e-06 8.03699e-06 7.94197e-06 7.82151e-06 3.16058e-06 2.29464e-05 -nan -nan -nan -nan -nan
Thank you!

Thank you for using our software and for reaching out with your questions.
In the popsize.coal file, the values in row2 represent the number of generations t in the past. When setting up the simulation, this value should be scaled using t = t / (4*Na). The values in row3 represent the coalescence rate at  t. You can determine Nt using 1 / (2 * coalescence rate). The value of Na should be the Nt corresponding to the smallest t.
In your example, since the first two coalescence rates are 0, you can use the third value as an approximation for Na, which is Na = 1 / (2 * 0.00548889) ≈ 91.1. The corresponding parameter t = Nt/(4*Na)= 694.748 / (4 * 91.1) ≈ 1.9. Therefore, the demographic should be set as follows:
-en 1.906 0 1
-en 2.649 0 9.684
...

I hope this helps! If you have any further questions, please feel free to reach out.
Best regards!

Thank you for using our software and for reaching out with your questions.
In the popsize.coal file, the values in row2 represent the number of generations t in the past. When setting up the simulation, this value should be scaled using t = t / (4*Na). The values in row3 represent the coalescence rate at t. You can determine Nt using 1 / (2 * coalescence rate). The value of Na should be the Nt corresponding to the smallest t.
In your example, since the first two coalescence rates are 0, you can use the third value as an approximation for Na, which is Na = 1 / (2 * 0.00548889) ≈ 91.1. The corresponding parameter t = Nt/(4*Na)= 694.748 / (4 * 91.1) ≈ 1.9. Therefore, the demographic should be set as follows:
-en 1.906 0 1
-en 2.649 0 9.684
...

I hope this helps! If you have any further questions, please feel free to reach out.
Best regards!

Thank you very much for your response.


Network status isn't updated automatically

Changes only by manual refresh, not automatically in background:

It is automatically refreshing... cannot reproduce this bug.
see src/store/store.js:
    setTimeout(() => store.dispatch(loadSyncing()), 3000); // check for syncing     setTimeout(() => store.dispatch(loadSyncing()), 30000); // double check for syncing after 30 seconds

@elaineo how you tried to reproduce it? Normally I make npm run build and then open /build/index.html in Chrome, that's right?

Yes, that works!  Each one should update the network status. Connector and node must also be running at the same time.

NETWORK/SYNCING fails for me:

TRACE:jsonrpc_core::io: Request: {"jsonrpc":"2.0","method":"eth_syncing","params":[],"id":9}.
INFO:reqwest::client: Request: Post http://<IP_ADDRESS>:8545/
INFO:reqwest::response: Response: '200 OK' for http://<IP_ADDRESS>:8545/
DEBUG:jsonrpc_core::io: Response: Some("{\"jsonrpc\":\"2.0\",\"result\":false,\"id\":9}").

So, I think the problem with false eth_syncing RPC call, so this issue isn't actual any more.


db: log schema errors, distinguish them from nil results where needed

gorp schema errors are a big deal, and probably worth some log information. This PRQ also changes the error protocol of some DB functions to distinguish between nil (which seems like a common thing) and type assertion failures (which are super scary)

Thanks @joeatwork


Implement net/fdb net/tunnels net/tunnel net/vlans

all but fdb are done right?

fdb is done.

so we can close right?


Error with qwik 1.1.5

Hi,
Trying to use the client, I get the following error:
[q] 9:23:46 AM [vite] Internal server error: Dynamic require of "null.js" is not supported
...
[q]       at AsyncFunction.GraphQLClientProvider_component_useTask_S0wzgaltP98 (/.../node_modules/qwik-graphql-client/lib/index.qwik.mjs:11084:48)
...

Not sure what to do, but it points to a non-serialisable value provided, probably the Provider:
        <GraphQLClientProvider
          clientGenerator$={() =>
            new ApolloClient({
              cache: new InMemoryCache(),
              uri: saleorApiUrl,
            })
          }>

On second thought, this seems like an anti-pattern to what qwik wants us to do, like avoiding pushing anything but serialisable, simple data into component$'s.
Did you test this with the latest qwik version?
edit: just tried without using the context provider and providing clientGenerator$ directly in the component, but I get an error as well, referring to a missing context:
[q] 9:43:30 AM [vite] Internal server error: Code(13): Actual value for useContext() can not be found, make sure some ancestor component has set a value using useContextProvider()

Ah, it looks like the anonymous function in the parameter of the provider component needs to be wrapped with a dollar function in order for it to work. I copy/pasted from the example in the readme.md.

I have pushed out a quick fix to allow generating clients in the useLazyQuery and the useMutation hooks outside of a client provider. Doing so in a useQuery won't work the current way everything is set up and requires a bit more thought on how to implement that.

I got it to work. all fine :) thank you.


[MINOR][BUILD] Fix lint-js

What changes were proposed in this pull request?
The pr aims to fix lint-js.
Why are the changes needed?
https://github.com/panbingkun/spark/actions/runs/6306820397/job/17123186216

Does this PR introduce any user-facing change?
No.
How was this patch tested?
Manually test.

Was this patch authored or co-authored using generative AI tooling?
No.

cc @yaooqinn

Merged to master.

thank you @panbingkun for this quick fix

Thank you, @panbingkun !


[SPARK-3577] Report Spill size on disk for UnsafeExternalSorter

What changes were proposed in this pull request?
Report Spill size on disk for UnsafeExternalSorter
How was this patch tested?
Tested by running a job on cluster and verify the spill size on disk.

Test build #75363 has started for PR 17471 at commit 4546d43.

Test build #75363 has finished for PR 17471 at commit 4546d43.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75363/
Test PASSed.

cc - @rxin, @kayousterhout, @squito

cc @cloud-fan / @ueshin / @sameeragarwal  can you review this?

SPARK-3577 is about reporting spill time, seems not related to this PR?

@cloud-fan - There is discussion in the JIRA to report the disk spill size as well. I can create a new JIRA if you prefer.

this is basically the same as this old pr, right? https://github.com/apache/spark/pull/15616
the last comment on there is a request for a test, which I think still applies here.  I also think a separate jira would be clearer.

I did not see we already have an open PR for this. Sure,  I will add test to this PR and also file a separate JIRA.

@sitalkedia any updates here?

@sameeragarwal - Thanks for taking a look. I will update the PR adding test case soon.

I was just looking though PRs for my curiosity. Please let me leave a gentle ping @sitalkedia.

Test build #78348 has started for PR 17471 at commit da1f384.

Thanks for the ping @HyukjinKwon. Updated the PR with test case.
cc - @sameeragarwal

test this please

Test build #78363 has started for PR 17471 at commit da1f384.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78363/
Test FAILed.

Jenkins retest this please.

Test build #78405 has started for PR 17471 at commit da1f384.

@shaneknapp, @sameeragarwal  - Not able to access the jenkins build link- https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78405/testReport, something wrong with the jenkins sever?

I think the power is still out in the CS building at Berkeley because of the earthquake, so I'm guessing Jenkins is down as a result (note that even the vanilla AMP website doesn't work: http://amplab.cs.berkeley.edu/)

it was actually a cut power line due to street construction.  apparently
power is back online, and we're waiting for machines and switches to finish
booting back up.
i'm WFH today, so i'm monitoring things remotely.
On Wed, Jun 21, 2017 at 2:52 PM, Kay Ousterhout<EMAIL_ADDRESS>wrote:

I think the power is still out in the CS building at Berkeley because of
the earthquake, so I'm guessing Jenkins is down as a result (note that even
the vanilla AMP website doesn't work: http://amplab.cs.berkeley.edu/)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/apache/spark/pull/17471#issuecomment-310215731, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABiDrCpWyketc1oi9h0i7qKbvgEEVIbnks5sGZCtgaJpZM4MtZcI
.

also, see my message to the dev@ list.  jenkins is up, but not reachable
via the amplab link.
On Wed, Jun 21, 2017 at 3:23 PM, shane knapp ☠<EMAIL_ADDRESS>wrote:

it was actually a cut power line due to street construction.  apparently
power is back online, and we're waiting for machines and switches to finish
booting back up.
i'm WFH today, so i'm monitoring things remotely.
On Wed, Jun 21, 2017 at 2:52 PM, Kay Ousterhout<EMAIL_ADDRESS>wrote:

I think the power is still out in the CS building at Berkeley because of
the earthquake, so I'm guessing Jenkins is down as a result (note that even
the vanilla AMP website doesn't work: http://amplab.cs.berkeley.edu/)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/apache/spark/pull/17471#issuecomment-310215731, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABiDrCpWyketc1oi9h0i7qKbvgEEVIbnks5sGZCtgaJpZM4MtZcI
.

Test build #78405 has finished for PR 17471 at commit da1f384.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78405/
Test PASSed.

LGTM, shall we fix it for other sorters? e.g. UnsafeExternalRowSorter, UnsafeKVExternalSorter, etc.

shall we fix it for other sorters? e.g. UnsafeExternalRowSorter, UnsafeKVExternalSorter, etc.

Actually other sorters are using UnsafeExternalSorter internally(https://github.com/sitalkedia/spark/blob/master/sql/catalyst/src/main/java/org/apache/spark/sql/execution/UnsafeExternalRowSorter.java#L67), so this change should fix others as well.

Test build #78821 has started for PR 17471 at commit 6b94c2b.

Test build #78821 has finished for PR 17471 at commit 6b94c2b.

This patch fails PySpark pip packaging tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78821/
Test FAILed.

Merged build finished. Test FAILed.

Jenkins retest this please.

Test build #78830 has started for PR 17471 at commit 6b94c2b.

Test build #78830 has finished for PR 17471 at commit 6b94c2b.

This patch fails due to an unknown error code, -10.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78830/
Test FAILed.

retest this please

Test build #78851 has started for PR 17471 at commit 6b94c2b.

Test build #78851 has finished for PR 17471 at commit 6b94c2b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78851/
Test PASSed.

thanks, merging to master!


sys: Use readdir withFileTypes option to skip lots of stat syscalls

This makes walking large directory trees much more efficient on Node 10.10 or later.
See:
https://lwn.net/Articles/606995/
https://www.python.org/dev/peps/pep-0471/
nodejs/node#22020
https://nodejs.org/en/blog/release/v10.10.0/

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: andersk sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Only suggestion is that we might want to do a single check up front, rather than looking for strings in every result.

My reasoning was that the typeof checks are extremely cheap compared to the IO we’re doing (even now), and doing the check up front requires duplicating code. Let me know if you’d like me to do this anyway.

@andersk I don't feel strongly either way.  I agree that it's a small overhead, I just thought it seemed like a shame to pay it for all future versions (whereas an explicit version check is more likely to be cleaned up if we decide to deprecate older nodes).  Either way, this is a huge improvement over the current implementation.  Thanks again!

The CI failure is unrelated.  We're working on it.

Closing and re-opening to re-trigger CI.


Provide a way to supply an external IServiceCollection to WebHostBuilder

I´m writting a server framework which has the ability to load extensions (modules). The framework  creates a ServiceCollection and during the extension lifecycle the service collection is passed to the extensions to register their services. One of these extensions utilizes asp.net core. It´s problematic that there is no way to pass an external service collection to the WebHostBuilder.
When this scenario is something which is desirable (I hope so :)), then let´s discuss where would be a appropriate place to add this feature.
What comes into my mind, are these three possibilities:

Add a constructor overload to WebHostBuilder
Add another overload of WebHost.CreateDefaultBuilder which takes a IServiceCollection
Add a new method to WebHostBuilder, something like WithServiceCollection(IServiceCollection collection)

When we agree on an appropriate place to add this, I would be happy to supply a PR.

Either of those could work, but the bigger issue would be that the webhostbuilder doesn't do tryadd today.
How does this work if someone adds a service to the collection that the WebHostBuilder then wants to create and add, like IHostingEnvironment. This seems like a much bigger ask, namely "allow WebHostBuilder to know that another builder has already initialized all the services it needs and do nothing". No?
That leaves out potential problems with multiple builds of the service provider and whether or not it's possible to get all parts of all modules to use the same instance.

I think you could almost achieve some of this by implementing and registering an instance of IServiceProviderFactory<IServiceCollection> in the WebHostBuilder.
Instead of returning back the services passed into the CreateBuilder method, you could return an instance passed into its constructor, potentially merging them in some way. If you don't copy over registrations from the hosting services (passed in), you need to make sure all required services are in place for the web host (and app) to work.

I think you could almost achieve some of this by implementing and registering an instance of IServiceProviderFactory in the WebHostBuilder.

Yes, that is the recommended way to go about this.

IServiceProviderFactory will not solve the problem, because the problem is more general. In terms of dependency injection, applications have to be build around AspNetCore in the designated extension points IServiceProviderFactory or StartUp.ConfigureServices. This feels wrong to me, because dependency injection should be configurable "outside" of WebHostBuilder.
The problem is, although IServiceProviderFactory provides a way to customize how the IServiceProvider is created,  WebHostBuilder still controls when IServiceProvider is created.
This is particular problematic when using other frameworks like e.g Orleans. They mimic WebHostBuilder and use the same workflow. I´have created a gist to show how akward and cumbersome it is to use AspNetCore and Orleans together: here
I came up with no other solution to make AspNetCore and Orleans to share the same IServiceProvider.
One possible solution in my opinon would be, to make the build process composable and give an external entity control over IServiceProvider creation. This BuildComposer would first ask all composables to register the services and create the service provider and give it to the composables.
In this scenario WebHostBuilder and SiloHostBuilder would register to the BuildComposer.
I know this would break the current build process for webhostbuilder and there are multiple open points like duplicate registrations @glennc mentioned. However this would make it much easier to use  multiple frameworks.

I've written why it's physically impossible to provide a build IServiceProvider, it is a mismatch, it'll never work with the WebHostBuilder. it owns the container and that will not change, the model is the model and isn't changing, we can make a new model that isn't what the WebHostBuilder is (nor the HostBuilder).
I've written about this in detail on several issues:
https://github.com/aspnet/Hosting/issues/1060
https://github.com/aspnet/Hosting/issues/1309
https://github.com/aspnet/Hosting/issues/550

We periodically close 'discussion' issues that have not been updated in a long period of time.
We apologize if this causes any inconvenience. We ask that if you are still encountering an issue, please log a new issue with updated information and we will investigate.


Update the Readme files with illustrations for the topic

In this project you see each folder has Readme some of the complete some or not so we want to complete Readme file for each topic in the repository. Readme file should contain the theoretical concept regarding the topic and should also help understand the code available in repository in a better way.

Assign this to me, I will try my level best to elaborate and write really simplified documentation.

Sure I am assigning this to you and I hope to see some wonderful contribution
happy coding <3

Thanks buddy, I will make sure its wonderful contribution <3

a pull request has been made, please review it.

General request to everybody, the Documentation is being handled so avoid writing README because that makes conflicts in between commits, If you want to help you can surely help by pulling request on my fork so I can format them and pull request over here.


Example XLSX Import Not working

The JSFiddle linked to in your documentation for importing Excel (http://jsfiddle.net/3ve90afo/) doesn't work. This is possibly related to an error in xlsx.full.min.js: f.charCodeAt is not a function at line 18. I tried spawning a new fiddle and using the latest cdn available at jsdelivr for alaSql and xlsx.js, but this did not solve the problem.

Thank you for taking the time to let us know!

Any word on this? FWIW, the similar Sheet JS demo is working http://oss.sheetjs.com/js-xlsx/

Nothing new on this.

Did you close it because you fixed it, or because you removed the link to the jsfiddle from the docs?

@AmyBlankenship The fiddle was changed but the README wasn't updated.  According to the commit http://jsfiddle.net/s2h9d59a/3/ should work.

The link will work as soon as the next version is published.
I should have explained that the merge referred here solved the issue...


Whitespace checking isn't working

environment

vim: vim version 8
vim-airline: ????

I have been adding plugins ... I am not sure if they have caused the issue.
I am sure it was working before here is
here is my vimrc file
set shell=/bin/bash
runtime macros/matchit.vim
set ttyfast
set lazyredraw
let g:ruby_path="~/.rvm/bin/ruby"
" have jsx highlighting/indenting work in .js files as well
let g:jsx_ext_required = 0
let $PATH='/usr/local/bin:' . $PATH
:au FocusLost * :wa "Save on focus lost
" Sessions
let g:session_autoload = 'no'
" This kebyboard Options
set listchars=tab:▸\ ,eol:¬
" Leader Mappings
map
map w :update
map q :qall
map gs :Gstatus
map gc :Gcommit
map gp :Gpush
"
" vim-test mappings
nmap  s :TestNearest
nmap  t :TestFile
nmap  a :TestSuite
nmap  l :TestLast
let test#strategy = "tslime"
" Toggle nerdtree with F10
map  :NERDTreeToggle
" Current file in nerdtree
map  :NERDTreeFind
" Reduce timeout after  is recieved.
set ttimeout
set ttimeoutlen=20
set notimeout
" highlight vertical column of cursor
au WinLeave * set nocursorline nocursorcolumn
au WinEnter * set cursorline
set cursorline
"key to insert mode with paste using F2 key
map  :set pastei
" Leave paste mode on exit
au InsertLeave * set nopaste
set backspace=2   " Backspace deletes like most programs in insert mode
set nocompatible  " Use Vim settings, rather then Vi settings
set nobackup
set nowritebackup
set noswapfile    " http://robots.thoughtbot.com/post/18739402579/global-gitignore#comment-458413287
set history=500
set ruler         " show the cursor position all the time
set showcmd       " display incomplete commands
set incsearch     " do incremental searching
set hlsearch      " highlight matches
set laststatus=2  " Always display the status line
set autowrite     " Automatically :write before running commands
" Fuzzy finder: ignore stuff that can't be opened, and generated files
let g:fuzzy_ignore = ".png;.PNG;.JPG;.jpg;.GIF;.gif;vendor/;coverage/;tmp/;rdoc/"
" Switch syntax highlighting on, when the terminal has colors
" Also switch on highlighting the last used search pattern.
if (&t_Co > 2 || has("gui_running")) && !exists("syntax_on")
syntax on
endif
if filereadable(expand("~/.vimrc.bundles"))
source ~/.vimrc.bundles
endif
filetype plugin indent on
augroup vimrcEx
autocmd!
" For all text files set 'textwidth' to 78 characters.
autocmd FileType text setlocal textwidth=78
" When editing a file, always jump to the last known cursor position.
" Don't do it for commit messages, when the position is invalid, or when
" inside an event handler (happens when dropping a file on gvim).
autocmd BufReadPost *
\ if &ft != 'gitcommit' && line("'"") > 0 && line("'"") <= line("$") |
\   exe "normal g`"" |
\ endif
" Set syntax highlighting for specific file types
autocmd BufRead,BufNewFile Appraisals set filetype=ruby
autocmd BufRead,BufNewFile *.md set filetype=markdown
" Enable spellchecking for Markdown
autocmd FileType markdown setlocal spell
"
" Automatically wrap at 80 characters for Markdown
autocmd BufRead,BufNewFile *.md setlocal textwidth=80
augroup END
" bind K to search word under cursor
nnoremap K :Ag "\b\b":cw
" Softtabs, 2 spaces
set tabstop=2
set shiftwidth=2
set expandtab
let g:rspec_command = 'call Send_to_Tmux("NO_RENDERER=true bundle exec rspec {spec}\n")'
" Mocha command is specific to Product Hunt setup. Probably doesn't work with
" other apps
let g:mocha_js_command = 'call Send_to_Tmux("$(npm bin)/mocha --opts spec/javascripts/mocha.opts {spec}\n")'
let g:rspec_runner = "os_x_iterm"
" Display extra whitespace
"set list listchars=tab:»·,trail:·
" Use The Silver Searcher https://github.com/ggreer/the_silver_searcher
if executable('ag')
" Use Ag over Grep
set grepprg=ag\ --nogroup
let g:grep_cmd_opts = '--line-numbers --noheading'
" Use ag in CtrlP for listing files. Lightning fast and respects .gitignore
let g:ctrlp_user_command = 'ag %s -l -g ""'
" ag is fast enough that CtrlP doesn't need to cache
let g:ctrlp_use_caching = 0
endif
" Plugin
Plugin 'flazz/vim-colorschemes'
Plugin 'itchyny/lightline.vim'
Plugin 'vim-airline/vim-airline'
Plugin 'vim-airline/vim-airline-themes'
Plugin 'rizzatti/dash.vim'
Plugin 'mattn/emmet-vim'
Plugin 'valloric/youcompleteme'
Plugin 'terryma/vim-multiple-cursors'
Plugin 'rstacruz/sparkup'
Plugin 'raimondi/delimitmate'
Bundle 'xolox/vim-misc'
Bundle 'xolox/vim-notes'
Plugin 'jiangmiao/auto-pairs'
Plugin 'othree/html5.vim'
Plugin 'alvan/vim-closetag'
Plugin 'tyru/open-browser.vim'
"Plugin 'honza/vim-snippets'
"Plugin 'sirver/ultisnips'
"Plugin 'kien/ctrlp.vim'
Plugin 'jpo/vim-railscasts-theme'
Plugin 'iandoe/vim-osx-colorpicker'
Plugin 'wikitopian/hardmode'
Plugin 'dietsche/vim-lastplace'
Plugin 'maksimr/vim-jsbeautify'
Plugin 'tmhedberg/simpylfold'
" Airline
if !exists('g:airline_symbols')
let g:airline_symbols = {}
endif
let g:airline_symbols.space = "\ua0"
let g:airline_exclude_filename = []
let g:Powerline_symbols='fancy'
let g:airline_powerline_fonts=0
let Powerline_symbols='fancy'
let g:bufferline_echo=0
set laststatus=2
set t_Co=256
set fillchars+=stl:\ ,stlnc:"
" unicode symbols
let g:airline_left_sep = '»'
let g:airline_left_sep = '▶'
let g:airline_right_sep = '«'
let g:airline_right_sep = '◀'
let g:airline_symbols.linenr = '␊'
let g:airline_symbols.linenr = '␤'
let g:airline_symbols.linenr = '¶'
let g:airline_symbols.branch = '⎇'
let g:airline_symbols.paste = 'ρ'
let g:airline_symbols.paste = 'Þ'
let g:airline_symbols.paste = '∥'
let g:airline_symbols.whitespace = 'Ξ'
" airline symbols
let g:airline_left_sep = ''
let g:airline_left_alt_sep = ''
let g:airline_right_sep = ''
let g:airline_right_alt_sep = ''
let g:airline_symbols.branch = ''
let g:airline_symbols.readonly = ''
let g:airline_symbols.linenr = ''
let g:airline_theme='onedark'
" Lightline
"let g:lightline = {
"      \ 'colorscheme': 'wombat',
"      \ 'component': {
"      \   'readonly': '%{&readonly?"":""}',
"      \ },
"      \ 'separator': { 'left': '', 'right': '' },
"      \ 'subseparator': { 'left': '', 'right': '' }
"      \ }
" Use the same symbols as TextMate for tabstops and EOLs
" set list
set listchars=tab:▸\ ,eol:¬
:set smartcase
:set ignorecase
" Color scheme
let $NVIM_TUI_ENABLE_TRUE_COLOR=1
set background=dark " or light
colorscheme onedark
" Numbers
set number
set numberwidth=5
" Persistent undo
set undodir=~/.vim/undo/
set undofile
set undolevels=1000
set undoreload=10000
:nnoremap  y (v:register ==# '"' ? '"+' : '') . 'y'
:nnoremap  yy (v:register ==# '"' ? '"+' : '') . 'yy'
:nnoremap  Y (v:register ==# '"' ? '"+' : '') . 'Y'
:xnoremap  y (v:register ==# '"' ? '"+' : '') . 'y'
:xnoremap  Y (v:register ==# '"' ? '"+' : '') . 'Y'
" Tab completion
" will insert tab at beginning of line,
" will use completion if not at beginning
"i commmented this out to see if listchar works"
"set wildmode=list:longest,list:full
set complete=.,w,t
function! InsertTabWrapper()
let col = col('.') - 1
if !col || getline('.')[col - 1] !~ '\k'
return "<tab>"
else
return "<c-p>"
endif
endfunction
inoremap  =InsertTabWrapper()
" Exclude Javascript files in :Rtags via rails.vim due to warnings when parsing
let g:Tlist_Ctags_Cmd="ctags --exclude='*.js'"
" Get off my lawn - helpful when learning Vim :)
"nnoremap  :echoe "Use h"
"nnoremap  :echoe "Use l"
"nnoremap  :echoe "Use k"
"nnoremap  :echoe "Use j"
" Treat  and  tags like the block tags they are
let g:html_indent_tags = 'li|p'
" Open new split panes to right and bottom, which feels more natural
set splitbelow
set splitright
" Quicker window movement. Seemlessly navigate between Vim/Tmux panes
let g:tmux_navigator_no_mappings = 1
" This is a hack due to a neovim bug for going Left
" Details: https://github.com/christoomey/vim-tmux-navigator#it-doesnt-work-in-neovim-specifically-c-h
nnoremap   :TmuxNavigateLeft
nnoremap   :TmuxNavigateLeft
nnoremap   :TmuxNavigateDown
nnoremap   :TmuxNavigateUp
nnoremap   :TmuxNavigateRight
nnoremap  {Previous-Mapping} :TmuxNavigatePrevious
" configure syntastic syntax checking to check on open as well as save
let g:syntastic_ruby_checkers = ['mri']
let g:syntastic_enable_highlighting=0
" Remove trailing whitespace on save for ruby files.
function! s:RemoveTrailingWhitespaces()
"Save last cursor position
let l = line(".")
let c = col(".")
%s/\s+$//ge
call cursor(l,c)
endfunction
au BufWritePre * :call RemoveTrailingWhitespaces()
" cmd n, cmd p for fwd/backward in search
map  :cn
map  :cp
" Create related file (Rails Spec file if missing). :AC
function! s:CreateRelated()
let related = rails#buffer().alternate_candidates()[0]
call s:Open(related)
endfunction
function! s:Open(file)
exec('vsplit ' . a:file)
endfunction
command! AC :call CreateRelated()
" Track the engine.
Plugin 'SirVer/ultisnips'
" Snippets are separated from the engine. Add this if you want them:
Plugin 'honza/vim-snippets'
" Trigger configuration. Do not use  if you use https://github.com/Valloric/YouCompleteMe.
let g:UltiSnipsExpandTrigger=""
let g:UltiSnipsJumpForwardTrigger=""
let g:UltiSnipsJumpBackwardTrigger=""
" If you want :UltiSnipsEdit to split your window.
let g:UltiSnipsEditSplit="vertical"
let g:colorpicker_app = 'iTerm.app'

please give reproducible steps to show the issue.

any update here?


FLAC support

Hello. Can you add support for Flac files in Create-Playlist? This is an open source audio format.
Thanks,
Arturo

Hey @arturo71 - that was easy enough =) Let me know if it works!

It works like a charm! Thanks a lot

You're welcome!


Try format quantity

return<PHONE_NUMBER>00m (= 0.1Gi) as 102.4M

It seems we are doing some format things on backend? Why not just send orignial data back without unit to frontend, and leave the format work to frontend.
We can assume the memory basic unit is Byte, the memory unit is 0.001 Core.
If the number is too big to put in a int64. We can use string.

closed, format will be done at frontend

got it


Feature/grid home page

This PR updates Home page styles and structure to leverage XY-grid capabilities.
A inner div has been added to <Section> component to adapt to the structure needed by xy-grid.
<Stories> component also has been migrated to the new grid.

Closing as the mixins are outdated, please review #435


Extract UI Web Security AutoConfiguration

Coverage remained the same at 56.403% when pulling dce65b32024eef915b8fce2c51bf75c25f855591 on extract-ui-web-login-configuration into 6620daf5303fa7859dea5655742b0722128e8a3d on master.


Handle default database for persistent connection

This change is a fix for change #462 . Specifying both default database (as 0) and persistent (as true) results in falsy persistent setting. In mentioned PR, there is a mentioned predis change, which works only if persistent key is not boolean.
Since we are interested in persistent => true cases, it is required to check if mentioned database is falsy or not.

Thanks! LGTM.
Could you rebase your branch and we will be good to go.

Done

Something is wrong the branch contains 11 commits

@B-Galati i run git remote add upstream https://github.com/snc/SncRedisBundle and git rebase upstream/master. Which step was wrong, how can I solve it? Should I create new PR?

No need for another MR.
Do git rebase -i upstream/master and remove lines that do not belong to your MR.

Should be good now hopefully.

No it's not, it should have one commit only.
did you git fetch before? Make sure to have the option -i on rebase.

Now?

Perfect, thanks @asilelik.


Move test_default_cluster_spinup_time to its own module

Follow-up from https://github.com/coiled/coiled-runtime/pull/341

@ian-r-rose there are lots of regression here -- are these "known" regressions or are these somehow new?

These mostly look like ones that are known to have a lot of variability. We should look into the regression calculation and try to decrease the sensitivity.


Add response item change callback on checkbox click event.

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #736
Description
Response item change callback was missing on checkbox click event.
Alternative(s) considered
No
Type
Choose one: (Bug fix)
Screenshots (if applicable)
Checklist

[x] I have read and acknowledged the Code of conduct
[x] I have read How to Contribute
[x] I have read the Developer's guide
[x] I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA
[x] I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach
[x] I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project
[x] I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally
[x] I have built and run the reference app(s) to verify my change fixes the issue and/or does not break the reference app(s)

Codecov Report

Merging #738 (a338f50) into master (7b7c1e0) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head a338f50 differs from pull request most recent head 2002ee4. Consider uploading reports for the commit 2002ee4 to get more accurate results

@@            Coverage Diff            @@
##             master     #738   +/-   ##
=========================================
  Coverage     53.08%   53.08%
  Complexity      195      195
=========================================
  Files            47       47
  Lines           974      974
  Branches        134      134
=========================================
  Hits            517      517
  Misses          376      376
  Partials         81       81

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b7c1e0...2002ee4. Read the comment docs.


Uninitialized variable error in match-stmt

Description:
$subject
Steps to reproduce:
function foo(int i) {
    int j;
    match i {
        3 => {
            j = 3;
        }
        _ => {
            panic error("MSG");
        }
    }
    int k = j; // error:variable 'j' may not have been initialized
}

public function main() {
}

Affected Versions:
swan-lake beta3 rc1

Duplicate of https://github.com/ballerina-platform/ballerina-lang/issues/25857


App server coordination

Hey, remix v1.16 requires custom app servers to coordinate with dev server broadcasting via broadcastDevReady. Will this plugin do it in the background or I need to call it on my server file?

for now it can be user-land, but the plugin will do it at some point


Question: Is slate still maintained/active?

There hasn't been any activity (commits or comments on issues) for 2 months. Is there an active fork somewhere?

Yup! I've been busy with work, but this project is definitely still alive and kicking. I think progress is slower in recent years as Slate becomes closer to being "feature complete" so to say.


Set rufus_scheduler_options via sidekiq.yml file as configuration option

This ensures that rufus_scheduler_options is read during boot and
sidekiq-scheduler instance (that also instantiates rufus scheduler)
is initialized with any custom options passed into rufus_scheduler_options.
Doing it this way allows us to not set the rufus_scheduler_options, manually
during application runtime (like below), which doesn't take into effect, due to the
memoization of @rufus_scheduler.
SidekiqScheduler::Scheduler.instance.rufus_scheduler_options = { max_work_threads: 5 }

More about the issue here: https://github.com/moove-it/sidekiq-scheduler/issues/374
Fixes: https://github.com/moove-it/sidekiq-scheduler/issues/374

I know it is fixing an issue but still is a breaking change so I prefer not to cherry-pick it to v3; v4 has no big changes except the minor version requirement for the redis gem so it should be a smooth upgrade path.

Sounds great! Thanks @marcelolx! Just to get an idea - by when do you think a v4 release is possible?

Probably at the end of this month


Wrap-up slot mappings implementation proposal

Definition of Done:

[x] respond to feedback comments
[x] finalise open questions in the proposal
[x] create implementation issues
[x] estimate project in 3.0 action plan

GH issues were submitted in the Enable inbox.
Project effort estimation can be found in the action plan here.


Pomodoro alarm is broken or non-existent

💻 Environment
Platform: macOS
OS Version: Monterey 12.3
Toggl Version: Track 7.5.441
🐞 Actual behavior
No alarm sounds when pomodoro is complete (across all apps, but reporting desktop here)
💯 Expected behavior
An alarm or even basic notification should sound at the end of a pomodoro.
🔨 Steps to reproduce

Start a pomodoro through the desktop app
Wait for it to finish
Witness the lack of notification

OS version: Platform: macOS
OS Version: Monterey 12.3
Browser version: Version 1.37.111 Chromium: 100.0.4896.79 (Official Build) (x86_64), Chrome Version 100.0.4896.75 (Official Build) (x86_64), Firefox 99.0 (64-bit)
Extension version: 2.0.8

🐛 Describe the bug
Pomodoro alarm is either broken or non-existent in extension
Expected behaviour
An alarm or even basic notification for pomodoro and break endings.
Steps to reproduce
Steps to reproduce the behaviour:

Install the extension
Start pomodoro
Witness lack of notification

Hey there even I am facing the same issue.
I can only hear the sound at the end of a single Pomodoro session, but it does not notify me to take a break.
Platform: Windows OS
OS Version: Home 10
Toggl Version: Track 2.0.8


Pasting text in search box creates an image

Description
When I copy an excel column and paste it in the search field, a PNG file is created with the paste value.
Steps To Reproduce

Copy a column from excel
Paste it on search field

Expected behavior
Paste the value and not create the PNG file.
Files Version
Version: <IP_ADDRESS> OS Version: 10.0.22000.556
Windows Version
Windows 11 Pro | 21H2 | 22000.556 | Windows Feature Experience Pack 1000.22000.556.0
Relevant Assets/Logs

This issue should be resolved with #8811


Home: Background Map image orientation

@reginafcompton The text for the link to "Search the Metro Board Archive (1952-2015)" is obscured by the text on the image behind it. Is it possible to crop or adjust the image so the text appears in either of the areas highlighted in the image attached?
I'm also seeing the link kind of obscured on mobile (see attached screenshot from iPhone 6s Plus). Maybe once the text is moved to a location with less interference on the desktop site, it's possible to reduce the font size slightly and avoid the text wrap? I'm open to to other ideas you have for how to approach this,

@shrayshray This change appears on the staging site.
I cropped the image and also lightened the bottom. If it looks okay, then you can close this issue!

@reginafcompton Looks good, thanks!


Buy with total instead of amount

The documentation for placing a buy clearly states that you need to specify either amount or total.
The current check was too strict, and only allows to specify the amount

The same problem existed for the sell method, so adjusted that one as well

Thanks!


Implement setFileTimes

I need touchFile which uses setFileTimes. The implementation is based on the one in the turtle library. The conversion from EpochTime to FILETIME is done as described in https://support.microsoft.com/en-us/kb/167296.

This is great, thanks for the patch 👍 I'll merge it and make a release as soon as that import is fixed.
I don't think this needs a major version bump as it's unlikely anyone was relying on that function throwing an exception 😂

Perfect, thanks! 🚗

Available as unix-compat-<IP_ADDRESS>