Retry for Hyper Errors [unexpected EOF, SSLShutdown]

Describe the feature
When forming many client connections we get the following errors:
unrecognized error from Hyper. If this error should be retried, please file an issue. err=error trying to connect: the SSL session has been shut down: the SSL session has been shut down (hyper::Error(Connect, Ssl(Error { code: ErrorCode(6), cause: None }, X509VerifyResult { code: 0, error: "ok" })))

and
unrecognized error from Hyper. If this error should be retried, please file an issue. err=error trying to connect: unexpected EOF: unexpected EOF (hyper::Error(Connect, Ssl(Error { code: ErrorCode(5), cause: None }, X509VerifyResult { code: 0, error: "ok" })))

Use Case
We should still be able to retry if we make too many client connections and our host shut downs our sockets.
Proposed Solution
We should retry these errors as transient errors here.
Other Information
No response
Acknowledgements

[X] I may be able to implement this feature request
[ ] This feature might incur a breaking change

A note for the community

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue, please leave a comment

thanks I have an open PR adding support for more Hyper errors, I'll add these as well. Do you happen to have a way to reproduce these for testing?

mmm...this is actually quite tricky. We can't look at that error code without taking a dependency on the SSL package. One option might be to make the error classifier configurable when you construct the Hyper Adapter so you could add connector-specific codes.


MIC-336: Moved "Other" to the bottom of the radios list on referral i…

…ncident page

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 80.87%. Comparing base (11a56e6) to head (a8824af).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #88      +/-   ##
==========================================
+ Coverage   80.79%   80.87%   +0.08%
==========================================
  Files         109      109
  Lines        1645     1652       +7
  Branches      277      278       +1
==========================================
+ Hits         1329     1336       +7
  Misses        304      304
  Partials       12       12

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Unable to download Udemy paid lectures offline

Checklist

[✓] I'm reporting a broken site support issue
[✓] I've verified that I'm running youtube-dl version 2021.12.17
[✓] I've checked that all provided URLs are alive and playable in a browser
[✓] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[✓] I've searched the bugtracker for similar bug reports including closed ones
[✓] I've read bugs section in FAQ

Verbose log

PASTE VERBOSE LOG HERE

Description

WRITE DESCRIPTION HERE
When i try to download the udemy lecture's it says
  C:\Users\Siddhesh\Music\youtube-dl>youtube-dl -U
  youtube-dl is up-to-date (2021.12.17)

  C:\Users\Siddhesh\Music\youtube-dl>youtube-dl.exe https://www.udemy.com/course/qlik-sense-certification-the-complete-
  practical-course/learn/lecture/23277012#overview
  [udemy:course] course: Downloading webpage
  ERROR: Unable to download webpage: HTTP Error 403: Forbidden (caused by HTTPError()); please report this issue on https://yt-
  dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose
  flag and include its complete output.

Use --cookies ... with cookies exported from your logged-in browser session that can show the course videos.
If that fails, duplicate of #29915.
See why failure is likely.

Closing for lack of response.

Where can i find the cookies

Please make a video for how to download Udemy DRM-protected content. Please

Where can i find the cookies

Read the Manual regarding cookies.

Please make a video for how to download Udemy DRM-protected content. ...

You can make it yourself.

The anxious Udemy user looks at the screen and turns off the computer with a sad shake of the head, turns to camera, and says "I give up -- it's impossible."
Ends.


Tilted CV view and adjust transition from 2D to CV

Fixes #3878.
Columbus view now has a tilt and the animation from 2D to CV has been updated.
Based on the PR by @JoshuaStorm in #3983. I followed his camera setup for CV, but updated the transition to be smoother and crashes no longer happen when transitioning.
There is a slight jump in the transition from CV back to 2D, but that is the current behavior in master. I believe it is from the FOV switch from perspective to orthographic.

Updated.

@ggetz can you please merge in master and I'll test and merge?

@pjcozzi Merged!

@ggetz did you mean to delete your update to CHANGES.md?  I will update it.

The new morph is good with me.

did you mean to delete your update to CHANGES.md? I will update it.

No, that was an accident.


image  show wrong

Laravel Version: 10.28.0
Nova Version: 4.27.14
PHP Version: 8.1.22
Database Driver & Version: mysql 8.0.34
Operating System and Version: Ubuntu 20.04.6 LTS(base on macOS 14 and homestead)
Browser type and version: Firefox 118.0.2

PHP Code:
SimpleRepeatable::make(__('orderGoods'), 'orderGoods', [
    Image::make(__('thumb'), 'thumb')->readonly(),
    Text::make(__('goods_id'), 'goods_id')->readonly(),
    Text::make(__('goods_name'), 'goods_name')->readonly(),
    Text::make(__('market_price'), 'market_price')->readonly(),
    Text::make(__('number'), 'number')->readonly(),
    Text::make(__('total_price'), 'total_price')->readonly(),
    ])
    ->canAddRows(false) // Optional, true by default
    ->canDeleteRows(false)
    ->readonly()->onlyOnForms(),

on edit page,only show a svg image,not show the image.

Hi and thanks for the feedback.
Currently the way Nova's image field works it's not possible for it to work in such a tiny space. Nova image field divides available space into 6 columns and displays image in the first one which means your image is pretty much in 1/6th of the repeatable column.
Nova now has it's own repeater field that displays fields per row. This may yield better results for you. Another solution would be to create your own version of nova's image field with better rules than they currently are.


Added API endpoint to convert mobiledoc posts to lexical

refs TryGhost/Product#3639

Added /posts/:id/convert endpoint to convert a mobiledoc post to lexical

To do:

[ ] Add PostsService tests
[ ] Add Posts input serializer tests
[ ] Duplicate for pages


chore(ci): use the commit hash instead of the change_id

Proposed Changes
Small changes to the way we print the build success message in Slack. It will allow us to build branches instead of PR and will make the renovate bot happier
Potential Breaking Changes
None

I see double :eyes: :eyes:

I see double 👀 👀

Should be fixed in the next build


i18n(ko-KR): update project-structure.mdx

Description (required)

update project-structure.mdx
#8953

Related issues & labels (optional)

Closes #
Suggested label:

Lunaria Status Overview
🌕 This pull request will trigger status changes.

Learn more
By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.
You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale
File
Note

ko
basics/project-structure.mdx
Localization changed, will be marked as complete.

Warnings reference

Icon
Description

🔄
The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.


Ensure details from client

Describe the issue
Need the necessary configuration details from the client in order to correctly configure the instance
Which Sprint Priority is this issue related to?
The 'Milestone' should clearly list Sprint Priorities - which one is this issue related to?
Additional context
Usually this is attached to the order.  In the case of AEST they ordered this instance in 2018 prior to the list of known details.  So this was done via email & phone calls.
Definition of done
All details received from the client

Details gathered from AEST


confReader is painfully slow

Need to find strategies to speed it up. It takes 2 minutes to read a $24^3\times8$ lattice, which is entirely unacceptable.

i managed to speed this up by about a factor 6. i'm not sure yet how to improve further 3a7ca9a


[google_maps_flutter] Use structured options in platform interface

Adds replacement methods in the platform interface that use a structured options class instead of a dictionary.
This fixes a remaining legacy of the direct conversion from method channel to platform interface during the original federation, which required the web implementation to know all of the magic strings and reconstruct the types in order to get the options, even though they started out as structured types in Dart. It also consolidates the magic strings on the Dart side of the method channel and the native side into the same package, avoiding potential issues across package boundaries and versions there.
Since this involved changes to buildView*, it also applies our current best practices for complex-param platform interface methods and creates extensible parameter objects so that we won't need to keep making new versions (e.g., to add a new map object type, or another widget configuration detail).
In order to avoid needing to keep both the JSON-based and the new structured-object based implementations of option handling in the web implementation, this makes a breaking change to the web implementation and only implements the new methods (rather than our usual practice of having all versions of a method implemented for maximal compatibility).
Fixes https://github.com/flutter/flutter/issues/70330
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
[x] I signed the CLA.
[x] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
[x] I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is test-exempt.
[x] All existing and new tests are passing.

(This may not actually pass all tests yet; feel free to hold off on reviewing for a bit. I ran some unit tests locally, but haven't done more extensive testing yet. I wanted to get it all running in CI in the meantime.)
Unfortunately unlike the previous round of de-Map-ification this actually doesn't let us remove much code from the web implementation since we still need to translate between the different objects. But it's clearly a better structure even though it's more code in some places (e.g., not being able to rely on Map iteration to create and apply diffs, leading to a lot of boilerplate code in the new configuration class) since it doesn't discard type safety early or rely on cross-package magic strings.

I think we should hold off a little bit on this PR, at least until these two land:

https://github.com/flutter/plugins/pulls/Rexios80

We've made Rexios80 rewrite their PRs a bunch of times because of our changes to the API, I think we should land those first, and then land this one :P

I think we should hold off a little bit on this PR, at least until these two land:

https://github.com/flutter/plugins/pulls/Rexios80

We've made Rexios80 rewrite their PRs a bunch of times because of our changes to the API, I think we should land those first, and then land this one :P

This should land before https://github.com/flutter/plugins/pull/5274, because as written that has a breaking change to the platform interface (adding heatmaps to the build* methods) and won't be landable. So the part that would conflict with this has to be rewritten anyway.
My future-proofing change to the new build method will make that landable without yet another new build method.

the build* methods

Well, someday we can do a breaking change and eliminate all but one of them. And we can largely ignore all but this one once this lands.

Reverted the web portion to land that last (in https://github.com/flutter/plugins/pull/5965), per https://github.com/flutter/plugins/pull/5965#issuecomment-1155586782


Attaching non-existing value automatically

Hi,
Is there any option to attach non-existing value?
It would be perfect to attach any tag, just pressing Enter, even if not exists in Options list.

Hi! This is out of the scope of a multi-select. You want something like a tag or label field.


No Android Information on Microsoft Teams Rooms maintenance and operations

[No Android Information on Microsoft Teams Rooms maintenance and operations]
All information written in this page is based on Microsoft Teams Rooms on Windows.
Better to add "Windows" on the title. Such as Microsoft Teams Rooms on Windows maintenance and operations
In other words, we cannot find Microsoft Teams Rooms on Android maintenance and operations including how to upgrade software. Please create or add pages of Microsoft Teams Rooms on Android side.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: fd52fe62-457b-c9e1-ad13-a9b1f24c9c38
Version Independent ID: 6a8c3285-30e1-15a8-6472-f0cfe5b30e20
Content: Microsoft Teams Rooms maintenance and operations - Microsoft Teams
Content Source: Teams/rooms/rooms-operations.md
Service: msteams
GitHub Login: @dstrome
Microsoft Alias: dstrome

Hi @yuki-iwagishi, thank you for bringing this to our attention. We've notified the documentation team of similar requests and will send you feedback as well.

Thank you for submitting feedback. We understand that this issue has been resolved.
Please feel free to re-open this issue if there is a specific area of the docs that we can improve or make better. Thank you.


Issue #SC-0000 fix: updated pom version

Codecov Report

Merging #431 into samza-lag-fix will not change coverage.
The diff coverage is n/a.

@@               Coverage Diff               @@
##             samza-lag-fix    #431   +/-   ##
===============================================
  Coverage             32.1%   32.1%
  Complexity            1211    1211
===============================================
  Files                  172     172
  Lines                15045   15045
  Branches              2386    2386
===============================================
  Hits                  4830    4830
  Misses                9498    9498
  Partials               717     717

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bea76c...d38d082. Read the comment docs.


feat(ghost-button): add ghost button component

Reopening https://github.com/carbon-design-system/carbon-components-react/pull/10 to point at master

👍 ✅


[Feature] Allow any name for observation and global_state keys

This PR allows any name for the group observation key and the global state key.
Before benchmarl constrained the observation to be named "observation" and the global state to be named "state"
cc @ezhang7423

The next PR will allow any shape observation and state.
However there is a problem. DDPG and SAC critics take as input the concatenation of the state and the actions.
Up until now we had only 1-dimensional states and observation so concatenating the actions was easy.
Now if the state and obs can be pictures, concatenating them to actions is less trivial.
They should ideally be prrcessed by different nets before being concatenated.
This poses a non-trivial problem to the way BenchMARL is designed. In particular:

BenchMARL models, algorithms and envs are designed to be decoupled. I want to avoid the rllib way where the codebase realizes that you are using images and instantiates a CNN for you. If the user runs Meltingpot with an MLP i want an error to be thrown telling the user to explicitly add a CNN to their model.

Proposed solution
The proposed solution is to allow models to get more than one key as input.
For example if an MLP receives 2 keys, it will concatenate them before processing (just like in torchrl https://github.com/pytorch/rl/blob/2461eb20d21b79a410e01aed71c26b77712a30d8/torchrl/modules/models/models.py#L295)
If an CNN receives multiple inputs, it will also try to concatenate them, but if they have different shapes, it will just cat the images and ignore the rest.
This means that if you have a CNN+MLP model and you pass it an image and a tensor, the CNN will process the image and ignore the tensor and the MLP will cat them and process both

Codecov Report
Attention: Patch coverage is 0% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 47.57%. Comparing base (276345b) to head (eb69934).

Files
Patch %
Lines

benchmarl/algorithms/qmix.py
0.00%
6 Missing :warning:

benchmarl/algorithms/common.py
0.00%
2 Missing :warning:

benchmarl/algorithms/maddpg.py
0.00%
2 Missing :warning:

benchmarl/algorithms/masac.py
0.00%
2 Missing :warning:

benchmarl/algorithms/iddpg.py
0.00%
1 Missing :warning:

benchmarl/algorithms/isac.py
0.00%
1 Missing :warning:

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #72       +/-   ##
===========================================
- Coverage   89.96%   47.57%   -42.40%
===========================================
  Files          69       69
  Lines        2731     2739        +8
===========================================
- Hits         2457     1303     -1154
- Misses        274     1436     +1162

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Generate MMR proof

Goal: Query mmr_generateProof. Relevant RPC methods are defined here.
Set up: Start services as described here.
Error:
2021/03/16 13:26:19 Connecting to ws://<IP_ADDRESS>:9944...
--- FAIL: TestGenerateMMRProof (0.02s)
panic: Runtime trapped [recovered]
	panic: Runtime trapped

fixed in https://github.com/Snowfork/go-substrate-rpc-client/pull/4


docs: move to the new LTS accross all projects

This will enable us to do things such as https://github.com/libp2p/js-libp2p-crypto/issues/130

@vmx applied your review

@VictorBjelkholm once this is merged, can you help this effort by creating the automated PRs that update the package.json and the badges to reference the new base supported versions?

@diasdavid Just to double check This change is about dropping Node 8.x support, right? Perhaps you can mention that when you squash merge the commits. We are not really moving to a new LTS, we are just dropping an older one.

That's a fair way to describe it. I would say that we are moving to a new baseline, which is the new LTS

I don't think it's a good idea to drop support for an Active LTS version (node 8)

As a project(s) that's deemed to be alpha/experimental/unstable I think it's reasonable to switch to the new LTS. It'll save us a bunch of admin supporting both, allow us to take advantage of the new APIs and FWIW I don't think that the environments IPFS/libp2p supports need necessarily be tied to the same timelines that Node.js gives to it's releases.

I'm in support of @alanshaw point. It is a tough decision and one that we should not make lightly or repeatedly but for this moment in time, it will provide a feature and speed boost that will benefit the project which will then benefit the users.

4 (including me) out of 7 have approved this PR, I believe we have a quorum :)

I agree it will save a lot of time up front, and we'll be able to remove testing on node8 from jenkins which will save a lot of bandwidth.
I would recommend we set some review milestones to revisit this in the IPFS roadmap to v1.0 as that gets closer to happening. Reducing upgrade cycles for projects from 18 months to 12 months is pretty brutal for large applications, or applications with limited teams. That's potentially a pretty significant maintenance cost for them, especially if we're using new features in the latest LTS versions.

I would sincerely recommend against this approach. Not only Node 8 is still Active LTS, but it will be supported for more than one year. See https://github.com/nodejs/Release#release-schedule for more details.
I would also remember that dropping support for a Node.js release line is typically a semver-major change.


not working autofocus in model

BaseSelection.prototype._handleBlur = function (evt) {
    var self = this;

    // This needs to be delayed as the active element is the body when the tab
    // key is pressed, possibly along with others.
    window.setTimeout(function () {
      // Don't trigger `blur` if the focus is still in the selection
      if (
        (document.activeElement == self.$selection[0]) ||
        ($.contains(self.$selection[0], document.activeElement))
      ) {
        return;
      }

      self.trigger('blur', evt);
    }, 1);
  };

when i open select2, then cursor blink in search field and always blur

Even noop this function get blinking cursor :(

Found
when select2 in label it not works autofocus

fixed with
element.parent("label").on("click", function(e) {
											e.preventDefault();
										});

is it select2 bug? I mean will be fixed?

I don't think is is bug. But this solve my problem.
If Select placed inside label, when it opened search focus is lost. This code prevent this.

Updated jsfiddle with: jsfiddle

Great, it works, thanks!


(TEST) Test for repodocs template

This PR was created from the following URL segment (removing https://github.com/michaeltlombardi for brevity):
/ghe/compare/test/main/test-pr-template-repodocs?quick_pull=1&template=repodocs.md

PR Summary

Affected Files

Repository documentation and configuration (.git/.github/.vscode etc.)
Docs build files (.openpublishing.* and build scripts)
Docset configuration (docfx.json, mapping, bread, module folder)

PR Checklist

[ ] I have read the contributors guide and followed the style and process guidelines
[ ] PR has a meaningful title
[ ] PR is targeted at the staging branch
[ ] Includes content related to issues and PRs - see Closing issues using keywords.
[ ] This PR is ready to merge and is not Work in Progress. If the PR is work in progress,
please add the prefix WIP: or [WIP] to the beginning of the title and remove the prefix when
the PR is ready.

The markdown for this PR (visible when you are filling it out before you submit):
# PR Summary
<!--
    Summarize your changes and list related issues here. For example:

    This changes fixes problem X in the documentation for Y.
    - Fixes #1234
    - Resolves #1235
-->

## Affected Files

<!--
    Delete the entries in this list that this PR does not affect:
-->

- Repository documentation and configuration (.git/.github/.vscode etc.)
- Docs build files (.openpublishing.* and build scripts)
- Docset configuration (docfx.json, mapping, bread, module folder)

## PR Checklist

<!--
    These items are mandatory. For your PR to be reviewed and merged,
    ensure you have followed these steps. As you complete the steps,
    check each box by replacing the space between the brackets with an
    x or by clicking on the box in the UI after your PR is submitted.
-->

- [ ] I have read the [contributors guide][contrib] and followed the style and process guidelines
- [ ] PR has a meaningful title
- [ ] PR is targeted at the _staging_ branch
- [ ] Includes content related to issues and PRs - see [Closing issues using keywords][key].
- [ ] This PR is ready to merge and is not **Work in Progress**. If the PR is work in progress,
  please add the prefix `WIP:` or `[WIP]` to the beginning of the title and remove the prefix when
  the PR is ready.

[contrib]: https://docs.microsoft.com/powershell/scripting/community/contributing/overview
[key]: https://help.github.com/en/articles/closing-issues-using-keywords


Fix unsized spike train and libgfortran issues in testing

Same as #60 except with sensible commit log

Travis errors unrelated to this PR.

Abandoning for #61 -- I rebased too far back and had to start from scratch.


Avoid switching over SwiftDriver.VirtualPath

This will allow adding new enum cases without breaking the SPM build, like in https://github.com/apple/swift-driver/pull/250. It's not a perfect solution, but it solves the immediate issues with exposing an enum (VirtualPath) as public API.

This depends on https://github.com/apple/swift-driver/pull/285, so I'm not running tests yet

@swift-ci please smoke test

@swift-ci please smoke test

This is ready to merge, unless you're waiting for something, @owenv ?

@DougGregor No, I've just been busy and never got around to following up on this, sorry! This can be merged at any time, it doesn't have any dependencies

I'm going to re-run tests just to be paranoid. 6 days can be a long time

@swift-ci please smoke test


Expose what was validated in SchemaValidator

BUILD SUCCESSFUL in 3m 44s
130 actionable tasks: 129 executed, 1 up-to-date


Add assert.notOk() function

The same way that equal(), deepEqual(), propEqual() and strictEqual() has their negative versions, ok() should have a notOk() negative version to check for falsy values, in a more clean and explicit way that by adding a negation operator in front of the value to check.
assert.ok(!value)
assert.notOk(value)

The assert.notOk seems better to go as an extension. It's not necessary to include this assertion in the API as it aims to keep itself simple.
not[Equal|DeepEqual|PropEqual|StrictEqual] has some more specific cases and I would be more inclined to remove them, but that would break the retrocompatibility and they're already there.

I would love to get a negation property implemented, e.g. assert.not, assert.not.not == assert.

Ok, I'm reopening it.

I searched and saw the other assertion libraries does have the same assert.notOk method. Some of then was tape and chai.
I've also talked with some other developers and it seems the .notOk would improve readability for other developers.
One thing I noticed during those conversations that makes QUnit great for me is being one of the JS testing libraries with the fewest assertions in it's API, making it simple. That's why I'm not 50/50 to decide which way to go, and we also have positive perspective from @JamesMGreene.
More opinions, please.

For the record, I would be accepting of an assert.notOk for readability's sake.

For the record, I would be accepting of an assert.notOk for readability's sake...

That's the main reason why I proposed it :-) Also, it makes it more orthogonal with the other assert methods, that have their negative version.

but would much rather implement a negation property and eliminate all of the not* assertions both in QUnit core and for custom assertion extensions.

I'm not too much into this kind of literate properties since at my opinion makes the code more verbose and ofuscate (behaviour-driven libraries abuse of this and I'm not always sure if I'm writting a valid word or not), but if this is the only case mostly as a namespace and makes simpler the code, I think is not a bad alternative... :-)
From an implementer point of view, in Python is trivial to automagically negate and route all the calls done on the namespace also for custom asserts, but on Javascript would require to use Proxy objects. Another alternative would be to fill the .not namespace on start with the methods found in the assert object, but this would still has the problem of the custom asserts after that (Object, observe(), maybe?).

I'm okay with adding assert.notOk. That would be a pretty simple change, while supporting assert.not might get much more complicated. PRs for the one or the other would help.

Quick pull-request done.

I'd like to challenge the ok and not* assertions. I think they're a bad practice. Putting them together seems a step backwards. I'd rather we discourage them as a "Bad Part". Perhaps kept for backwards compatibility; and parity with CommonJS' Unit Testing spec (which I believe was inspired by QUnit, awkward..).
Using ok() indicates one of two problems:

The software (or testing strategy) is unreliable. (Unsure what value to expect.)
The author is lazy and uses it as shortcut for a proper comparison.

The former necessitates improvement in the code being tested. The latter comes with two additional caveats:

Less debug information. (No actual/expected diff). Without an expected value provided, one can't determine what's wrong with the value.
Masking regressions. Even if the API being tested returns a proper boolean and ok is just a shortcut, the day the API breaks (e.g. returns a number, string, array, function, Promise or other object) the test will not catch it.

Common examples:
// Meh
assert.ok( bool );
assert.ok( fn );

// Better?
assert.strictEqual( bool, true );
assert.equal( typeof fn, 'function' );

Using not*() indicates one of three problems:

The software is unreliable.  (Unsure what value to expect.)
The test uses an unreliable environment. (E.g. variable input data, insufficient isolation or mocking.)
The author is lazy and uses it as shortcut for a proper comparison.

Common example:
var index = list.indexOf( item );
// Meh
assert.notEqual( index, -1 );
// Better?
assert.equal( index, 2 );

I've yet to see the first use of ok or not* that wouldn't be improved by writing it a different way.
I'd love to be proven wrong, so I ask you: What is the added value in ok or not*?

What would you find as a better alternative? Maybe assertTrue() and assertFalse() and checking explicitly for Boolean values?

I have some examples that come to mind.
ok()
I often have tests where I want to verify that a method is called as a result of calling some other method, but there's no input to verify. Using ok( true, "foo() was called" ) works great for this case. The inverse case also exists: verifying that a method is not called via ok( false ). Here's a real example: https://github.com/jquery/jquery-license/blob/3b5c3c57b65fdc61b85528cb95f6df5edf03b939/test/repo.js#L43-L50
not*()
Let's say you have a widget which takes an array of values and you initialize multiple instances with the same array, but the widget needs to treat the two instances separately. You can currently use notStrictEqual( widget1values, widget2values ). If ok() and not*() were removed, this assertion would become equal( widget1values === widget2values, false ) which is definitely less expressive.
Another example is testing a method that generates unique values, e.g., a random password generator. I've tested this before by calling the method multiple times and using notEqual() on the output.

@scottgonzalez As said, I agree there are scenarios where a negated comparison is useful and appropriate. Especially for token generators. One could still assert value type and shape, however (e.g. string / length). (example)
As for function call tracking, I think using ok( Boolean ) for that is inferior to strict flow tracking using a counter (example) or array (example, example). This becomes more important when abandoning the assert.expect model, of course, though not required.


Explain current biography logic to users

The current process for creating or editing people is confusing. We have some logic that shows a truncated biography for any person without a current role. If you’re creating a new person, they have no role – when you enter your full biography and check it on the live site, it’s not clear why the whole thing isn’t showing.
This is a simple change to try and explain that. The decision to do the truncation should be re-assessed.
Zendesk ticket: https://govuk.zendesk.com/agent/tickets/1298476
Original PR to add truncation: https://github.com/alphagov/whitehall/pull/2058

👍


Uk

Please, split this into smaller PRs with explanations of the changes. This one looks like an accident so I'm going to close it now.


Broken link on official website

The link to this GitHub repository on the official website (https://www.playtron.one/playtron-os), under the "How will I be able to contribute to Playtron?" drop down menu, contains a trailing period which redirects to https://github.com/playtron-os/playtron-os. The correct URL is https://github.com/playtron-os/playtron-os

Thank you @AarizYT  for reporting this! I've been trolled by this on websites in the past. Web browsers always think the period "." is part of the URL. I let our team know so it can be updated.


Get number of bits right

What is your question?
In a scaled_integer, how to get the number of bits left or right of the point?
The aim is to write code immune against power changes.
TY John

On sixth thought that might be an antipattern, to want to know the number of fractional bits :')


Add Python 3.8 classifier

Thanks for creating useful library. As it already runs on Python 3.8 in CI I think it is good to add Python 3.8 classifier.

Thanks for the PR!


handle  as a RAWTEXT element

See bullet item 4 in http://www.w3.org/TR/html/syntax.html#concept-frag-parse-context
As we assume scripting is always enabled (otherwise, no script nor XSS), <noscript> tag should be handled as RAWTEXT. The filter NOT_HANDLE is equiv. to the default handlebars filter.

@neraliu , please give it a quick review. Thanks.

this implementation is quite tricky, right now, the filtering rules for both RAW_TEXT and DATA are the same? we need to doc it.
the assumption of enabling js in the browser side makes sense to me, as it is the criteria for xss.
@yukinying, please have another eye on this


ArchiveOperations documentation is incorrect

Issue type
Wrong or misleading information
Problem description
In the service documentation, it states that ArchvieOperations is used for "creating archives, such as ZIP and TAR files;" however, it only contains methods for reading archives.
I believe the package is also wrong.
Context (optional)
I was looking for a way to create zips from within a task.
Page with the problem
https://docs.gradle.org/current/userguide/service_injection.html#archiveoperations

This is a valid documentation issue.


[liba52] add new port

Adds #24973

[x] Changes comply with the maintainer guide.
[ ] The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
[x] Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.
[x] The versioning scheme in vcpkg.json matches what upstream says.
[x] The license declaration in vcpkg.json matches what upstream says.
[x] The installed as the "copyright" file matches what upstream says.
[x] The source code of the component installed comes from an authoritative source.
[ ] The generated "usage text" is accurate. See adding-usage for context.
[x] The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
[x] Only one version is in the new port's versions file.
[x] Only one version is added to each modified port's versions file.

This library is also known as a52dec (the program)

Note: I will be converting your PR to draft status. When you respond, please revert to "ready for review".
That way, I can be aware that you've responded since you can't modify the tags.


Fails to Load. ERR_TOO_MANY_REDIRECTS

I have rainloop installed on my server and since two days, it is unable to open.
The Error displayed is :
e.atulbhats.com redirected you too many times.
ERR_TOO_MANY_REDIRECTS
I had updated Rainloop around last week to <IP_ADDRESS>
The error_log and error_log.txt are both empty.
I cannot even access the admin panel with ?admin as it gives the same error.

It looks like web server configuration error.
Connection:Keep-Alive
Content-Length:206
Content-Type:text/html; charset=iso-8859-1
Date:Mon, 30 May 2016 12:16:59 GMT
Keep-Alive:timeout=3, max=8
Location:http://e.atulbhats.com
Server:Apache Phusion_Passenger/4.0.10 mod_bwlimited/1.4 mod_fcgid/2.3.9

<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN">

<title>302 Found</title>

Found

The document has moved here.

This is not a RainLoop response.


 In Firefox, selected code was invisible due to ::-moz-selection styles also declaring a white background.
This PR also removes the commented out ::selection colors.

ha, strange one. thanks!


fix(ui_localizations): loading Traditional Chinese

Description
I found that the firebase_ui_localizations package includes a translation for Taiwan (ZhTWLocalizations), but has not been used appropriately. So I follow the same approach of how the flutter_localizations package gets the appropriate translation and how to fallback when the scriptCode or countryCode is not defined.
Related Issues
Closes #33
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
[x] All existing and new tests are passing.
[x] I updated/added relevant documentation (doc comments with ///).
[x] The analyzer (melos run analyze) does not report any problems on my PR.
[x] All unit tests pass (melos run test:unit:all doesn't fail).
[x] I read and followed the Flutter Style Guide.
[x] I signed the CLA.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change.
[x] No, this is not a breaking change.

@gary6lin Thanks for submitting a PR! Could you please add unit tests verifying that traditional Chinese loads correctly now?  Also might be good to add a test verifying that localization overrides still work.

Trailing comma and test cases added.

@gary6lin could you please run melos run format to make code_health/format green.


Sensibly handle attribute values of type image, file, date

#1132 and #1149 raised the issue that handling of Rich Text attributes is lacking. While this is being fixed right now, we should add sensible defaults for the other more exotic attribute values. This means adding $type_as_html and $type_as_text properties on AbstractProductAttributeValue.

closing all issues that are feature requests that don't have PR's attached.


inotify: code cleanup. Closing watcher should now always shut down goroutine

fixes go-fsnotify/fsnotify#3
fixes go-fsnotify/fsnotify#5
Also fixed a racey access to w.watches in Close.
I put the tests in notify_test.go, so it doesn't break any other builds. These tests should be checked against the other platforms one by one before pulling them into integration_test.go.

Thanks.

Have you confirmed that #3 is fixed by this change?
I'll take a closer look and do some QA tomorrow before I merge it in. Thanks again for the help.

I've checked. I did the same as you (checked /proc/x/fd), disabled tests until i found the one that did it. Unsurprisingly, it was a blocking goroutine.
It still happened due to corner case that I hadn't covered yet; in close, when there were watches to remove but they all gave errors, the 'wakeup' wasn't done. Now it is. And thus it is fixed.

@PieterD Have you already signed Google's CLA for contributing to Go? (This code base originates from Go exp packages and may one day land in Go).
https://developers.google.com/open-source/cla/individual

Did that (and A+C) years ago. It's fine.

There's still some uncertainty when closing which I'm fixing now.

Thanks. I'm on my way to a hack day, fsnotify will be my project for today.

Nice. I'm using epoll to get rid of the last bit of uncertainty.

And then it gets interesting. :-)

Yeah, it's a lot of busywork for a small imperfection, but it's got to be done. You could accept the pull as is, and I'll shoot the epoll thing as a seperate pull request. That might ease the review.

Man, it SUCKS that syscall.Read doesn't unblock with you close the file descriptor. Even epoll doesn't respond when you do that.

Does IN_NONBLOCK help at all? See #5.

I admit I don't understand this stuff. I'm yet to become a Linux guru. :-)

A separate PR would be appreciated. Let me get this tested and merged in.

Please. It would be nice to seperate this mess and the next mess, instead of creating one giant ubermess :P

übermess!

HOLY CRAP I just figured it out. There's a truly awesome race condition that happens :D
I was wondering how it could be possible that sometimes, test n was making test n+1 fail with "bad file descriptor" or with the wrong number of events.
What happens is that when you've got a goroutine waiting for events, it's possible to close it and create a new one, before other goroutines have a chance to respond. But since the previous descriptor was closed, the new inotify file descriptor will have the same number as the previous one, which will then get closed once the previous test's goroutines wake up and close their stuff.
So, yeah. From now on, Close waits for the readEvents goroutine to finish.

Hah. "awesome" race conditions. So awesome that -race didn't catch it.

So if, during the execution of Add, some other goroutine closes the watcher and something else opens a file descriptor, it'll get messed up.
This changes a lot. Add and Remove will have to be properly synced with readEvents. Yeah, I don't think think you'll like the next pull request.

I wonder if -race could be adapted to catch this.

For the changelog, #5 isn't actually solved yet, correct? (coming next)

I was under the impression that https://github.com/go-fsnotify/fsnotify/issues/5 was about goroutines blocking forever.
Perhaps I'm mistaken.

Squashed and merged.
#5. Doesn't readEvent still block though? That little hack to wake it up on Close might work, but maybe not?

readEvents still has a blocking read on the file descriptor, but that's fine. So does kqueue and the Windows thing.
It should get cleaned up pretty much always, but not ABSOLUTELY always. That's the next one. So yeah, I suppose #5 might not be fixed until I push the epoll stuff.

kqueue has a timeout right now so that it doesn't block indefinitely, but it does use a little bit of CPU to go around the loop every few 100ms.


[Bug]: using concatenateModules with rspack serve cause runtime panic "should have build info"

System Info
  Binaries:
    Node: 18.17.1 - ~/Library/Caches/fnm_multishells/180_1706947163882/bin/node
    Yarn: 1.22.19 - ~/Library/Caches/fnm_multishells/180_1706947163882/bin/yarn
    npm: 9.6.7 - ~/Library/Caches/fnm_multishells/180_1706947163882/bin/npm
    pnpm: 7.33.6 - ~/Library/Caches/fnm_multishells/180_1706947163882/bin/pnpm
  Browsers:
    Chrome: 121.0.6167.139
    Firefox Nightly: 115.0
    Safari: 17.0
  npmPackages:
    @rspack/cli: 0.5.3-canary-c9f8d78-20240201071306 => 0.5.3-canary-c9f8d78-20240201071306
    @rspack/core: 0.5.3-canary-c9f8d78-20240201071306 => 0.5.3-canary-c9f8d78-20240201071306

Details
I'm using the concatenateModules from https://github.com/web-infra-dev/rspack/pull/5415. It is great that the bundle size reduced significantly!
But when using rspack serve, the following panic happens.
https://github.com/web-infra-dev/rspack/blob/1b057d6ab0b1cc758897ec8a5b03c1ab712299ad/crates/rspack_plugin_javascript/src/plugin/module_concatenation_plugin.rs#L575
Panic occurred at runtime. Please file an issue on GitHub with the backtrace below: https://github.com/web-infra-dev/rspack/issues
Message:  should have build info
Location: crates/rspack_plugin_javascript/src/plugin/module_concatenation_plugin.rs:575

Reproduce link
No response
Reproduce Steps
With the following files:
// src/index.js
console.log('Hello, rspack');

// rspack.config.js
export default {
  entry: {
    main: "./src/index.js",
  },
  optimization: {
    concatenateModules: true,
    minimize: false,
  },
  experiments: {
    rspackFuture: {
      newTreeshaking: true,
    },
  },
};

run rspack serve and edit the src/index.js will re-produce the panic.

It is a known issue, cc @jkzing

It's a known issue, @jerrykingxyz

I am also facing error
Panic occurred at runtime. Please file an issue on GitHub with the backtrace below: https://github.com/web-infra-dev/rspack/issues
Message:  internal error: entered unreachable code
Location: crates/rspack_plugin_javascript/src/dependency/esm/provide_dependency.rs:82

Run with COLORBT_SHOW_HIDDEN=1 environment variable to disable frame filtering.
Run with RUST_BACKTRACE=full to include source snippets.
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ BACKTRACE ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
 1: _napi_register_module_v1
    at <unknown source file>
 2: _napi_register_module_v1
    at <unknown source file>
 3: _napi_register_module_v1
    at <unknown source file>
 4: _napi_register_module_v1
    at <unknown source file>
 5: _napi_register_module_v1
    at <unknown source file>
 6: _napi_register_module_v1
    at <unknown source file>
 7: _napi_register_module_v1
    at <unknown source file>
 8: _napi_register_module_v1
    at <unknown source file>
 9: _napi_register_module_v1
    at <unknown source file>
10: _napi_register_module_v1
    at <unknown source file>
11: _napi_register_module_v1
    at <unknown source file>

I am also facing error
Panic occurred at runtime. Please file an issue on GitHub with the backtrace below: https://github.com/web-infra-dev/rspack/issues
Message:  internal error: entered unreachable code
Location: crates/rspack_plugin_javascript/src/dependency/esm/provide_dependency.rs:82

Run with COLORBT_SHOW_HIDDEN=1 environment variable to disable frame filtering.
Run with RUST_BACKTRACE=full to include source snippets.
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ BACKTRACE ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
 1: _napi_register_module_v1
    at <unknown source file>
 2: _napi_register_module_v1
    at <unknown source file>
 3: _napi_register_module_v1
    at <unknown source file>
 4: _napi_register_module_v1
    at <unknown source file>
 5: _napi_register_module_v1
    at <unknown source file>
 6: _napi_register_module_v1
    at <unknown source file>
 7: _napi_register_module_v1
    at <unknown source file>
 8: _napi_register_module_v1
    at <unknown source file>
 9: _napi_register_module_v1
    at <unknown source file>
10: _napi_register_module_v1
    at <unknown source file>
11: _napi_register_module_v1
    at <unknown source file>

It looks like your issue is irrelated, could you please file another issue?

I tried the canary version in #5692 with the same demo, and another panic occurred:
Module(<path>) should be added before using.
Message:  Module(/home/webpack-app/node_modules/.pnpm/@rspack+dev-server@0.5.4_cfxbo3brkdttvrslyfa2opfk5e/node_modules/@rspack/dev-server/client/index.js?protocol=ws%3A&hostname=<IP_ADDRESS>&port=8080&pathname=%2Fws&logging=info&overlay=%7B%22errors%22%3Atrue%2C%22warnings%22%3Afalse%7D&reconnect=10&hot=true&live-reload=true|94e243c27d9fb0a2fa50cb7b8d90fd3f) should be added before using
Location: crates/rspack_core/src/chunk_graph/chunk_graph_module.rs:75

Should I file another issue? Or re-open this one?
BTW, I can make a workaround by setting devServer.client to false.

can you try 0.5.7-canary-6007430-20240313111541


Document the bug reporting process

Add comments to the README about how to report bugs in Twizzler.

Updated in the latest README commit.


feat(release): Try corp semantic release tool.

Coverage remained the same at 100.0% when pulling 44e195065353f4148deebc1919597eebcf570edf on try-corp-semantic-release into c4e303dc195bc45700185baad1888a003bb76c34 on master.


#84 added adapter.py to chat with finetuned model

Fixes #84

Oh sorry about that, might as well close it as the other PR might be more
advanced
Abdul Rehman Mohammad,* BSc, MSc *
Ph.: +61413201400
www.agmo.xyz
On Fri, Jun 30, 2023 at 12:17 PM Carlos Mocholí @.***>
wrote:

@.**** commented on this pull request.
Sorry, this PR has become stale and so the code is outdated. If you are
still interested in working on it, I would accept it if updated.
Just note that #197 https://github.com/Lightning-AI/lit-gpt/pull/197 is
also attempting this.
—
Reply to this email directly, view it on GitHub
https://github.com/Lightning-AI/lit-gpt/pull/119#pullrequestreview-1506367575,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AMXC76VFZOSD2IDP2HPRTXTXNYZL7ANCNFSM6AAAAAAY5LGA5U
.
You are receiving this because you authored the thread.Message ID:
@.***>


How about prefetching js assets?

Hi Addy,
And thanks for pushing the web forward as always!
We as web developers started to focus on code-splitting (e.g. via Webpack) and you've already wrote about this powerful feature multiple articles.
Prefetching next assets by using tiny neural network implementation would learn which asset you will likely grep (page -> js assets to be fetched pair). Notice also that many tend to even embed css-in-js that will take the benefit from this approach also.
That propose is more related to dynamically fetching assets chunks that will likely be fetched more the data itself, which will save the latency time + parse + execution.

In low network connection you can feel the time between accessing a route and the component that was asynchronously fetched, which prefetching js assets chunk can improve.


Per-user fonts don't load

Windows Terminal version
1.16.10262.0, 1.17.1023 (Preview)
Windows build number
10.0.22621.0
Other Software
CaskaydiaCove Nerd Font
SF Mono Nerd Font
Steps to reproduce

Install a font on a per-user basis (not system-wide)
In Windows Terminal, navigate to Settings, Profiles, Defaults, Appearance, select a per-user font, click Save
Different behaviors depending on application version, but neither works

Windows Terminal stable will not load the font at all

Windows Terminal Preview loads the font to the current session but upon closing and reopening Terminal, the same message as above is displayed

Notes:

Windows Terminal handles fonts correctly when they are installed system-wide.
The fonts I used for this test work correctly in other applications.

Expected Behavior
Windows Terminal should load the selected font to the current session and continue to load it in new sessions.
Actual Behavior
Windows Terminal stable is unable to load per-user fonts at all. Windows Terminal Preview can load them to the current session but not to subsequent sessions.

I believe this issue is being tracked in #3257, although I think it's an OS problem, so it'll likely be fixed by an OS update.

Thanks for the report! @j4james is absolutely right. This is a known issue with installing fonts into the user font directory. It's a bug that's unfortunately outside of our control and we're all patiently waiting for a fix for this as well. It's one of the most common bug reports we get. Here's how you fix it: https://github.com/microsoft/terminal/issues/14231#issuecomment-1280827973
/dup #3257

Thanks for the report! @j4james is absolutely right. This is a known issue with installing fonts into the user font directory. It's a bug that's unfortunately outside of our control and we're all patiently waiting for a fix for this as well. It's one of the most common bug reports we get. Here's how you fix it: #14231 (comment)
/dup #3257

Thanks. I figured it was already reported and tried searching but didn't come up with anything.


Compile for latest version

Hi there,
Thanks for making this awesome plugin ^^. It looks like the compiled version is outdated at the moment:
~> plugin add /Users/srobbe/.cargo/bin/nu_plugin_highlight
Error:
  × Failed to send plugin call to `highlight`
  help: try loading the plugin again with `plugin use 'highlight'`

Error: nu::shell::plugin_failed_to_load

  × Plugin failed to load: Plugin `highlight` is compiled for nushell version 0.100.0, which is not compatible with version 0.101.0

Is it as simple as updating the nu Cargo dependencies?

Most often you just need to update the nu dependencies. If that is not enough, you have to check the changelog. Often it has a notes for plugin developers section that explains changes for plugins. This release did not break anything for my plugin, so I just released v1.4.2+0.101.0.


drag folders

Type: Feature Request
I can't drag folders after running VSCode as an administrator.
But I don't want to turn off administrator mode.
VS Code version: Code 1.71.2 (74b1f979648cc44d385a2286793c226e611f59e7, 2022-09-14T21:03:37.738Z)
OS version: Windows_NT x64 10.0.22621
Modes:
Sandboxed: No

\gifPlease

Thanks for reporting this issue! Unfortunately, it's hard for us to understand what issue you're seeing. Please help us out by providing a screen recording showing exactly what isn't working as expected. While we can work with most standard formats, .gif files are preferred as they are displayed inline on GitHub. You may find https://gifcap.dev helpful as a browser-based gif recording tool.
If the issue depends on keyboard input, you can help us by enabling screencast mode for the recording (Developer: Toggle Screencast Mode in the command palette).
Happy coding!

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


[Feature Request] let us input our home instance at the top of the page, and make the links all point to federated versions of lemmy/kbin

e.g. my account is on kbin.social. If I click on https://lemmy.ml/c/hamradio I would rather be pointed to<EMAIL_ADDRESS>which I think is possible to generate procedurally based on the home instance entered by the user.
Thanks so much, this tool is already amazing!!

Hi @RheingoldRiver!
This already exists as a feature. Go to "Settings" (button on the top right) and setup a Home Instance.

ohhhhhh cool! I did that just now, and it seems to be working! thanks so much!


Char/UI styles

Pull Request Test Coverage Report for Build<PHONE_NUMBER>0
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 69.772%

Totals

Change from base Build<PHONE_NUMBER>3:
0.0%

Covered Lines:
2816

Relevant Lines:
4036

💛  - Coveralls


feat: added relevant links to expense breakdown components and fixed a minor typo #2482

Description
In this pull request, I have made the following changes:

Added navigation links to certain components for improved user navigation. The new links provide direct access to relevant services.

Addressed minor typographical errors throughout the codebase to enhance code readability and maintain consistency.

Related issue(s)
Fixes #2482

@Mayaleeeee @akshatnema Can you review this PR?

@SwetanshuSingh Kindly resolve the merge conflicts in your PR.

@akshatnema resolved

@SwetanshuSingh any update on this one??

@SwetanshuSingh any update on this one??

raising the pr by eod

This was the previous UI

@sambhavgupta0705 I am really sorry for making this silly mistake. I will fix this right now!

We already have PR for https://github.com/asyncapi/website/issues/2482 , hence closing this PR. @SwetanshuSingh Kindly work on some other issue to contribute to the project.


Winner Bug

Fix the issue where the winner is incorrectly calculated. For example, it may say "Pair beats Mix... Tie". The pair beats mix part is correct but obviously that is not a tie (and the chips should be given to the winner).

W18 OK (100 pts)

Completed W18


demo.bluelatex.org is down

Domain demo.bluelatex.org doesn't resolve.

I rent a new server for the demo.
The demo is available again.

@tdurieux Unable to connect. Seems to be down again.

the HTTP version is available: http://demo.bluelatex.org/
I did not yet setup the HTTPS version, sorry


Hex initializable

Added test cases

Save to delete branch after

Current coverage is 97.02%

Merging #30 into master will increase coverage by +13.20% as of dd29389

@@            master     #30   diff @@
======================================
  Files            3       3
  Stmts          235     235
  Branches         0       0
  Methods
======================================
+ Hit            197     228    +31
  Partial          0       0
+ Missed          38       7    -31

Review entire Coverage Diff as of dd29389

Powered by Codecov. Updated on successful CI builds.


Add support for managing and install from repository on Debian platforms

Add support for managing and install from repository on Debian platforms

Closing as this functionality was implemented in #34


[SUPPORT] Apply 'write.ignore.failed' when write data failed

Describe the problem you faced
In Flink engine, if exception occurs when task writing data, it will be ignored and the exception will be reported to StreamWriteCoordinator with write event, StreamWriteCoordinator will decide whether to commit when there is write failure according to 'write.ignore.failed'.
Whether we should apply 'write.ignore.failed' ahead when write failure occurs, thus throw an exception faster.
To Reproduce
Expected behavior

promote 'write.ignore.failed' to hudi-client-common
throw exception  in write handles
default value of 'write.ignore.failed' is false

Environment Description
Additional context
related PR：https://github.com/apache/hudi/pull/12150
Stacktrace

@nbalajee Do you have some insights about promote the 'write.ignore.failed' as a basic option for all the engines? I kind of remember we had a discussion before and engine specific maintainance is prefferable.


lazysizes.client.js running on server

Environment
------------------------------
- Operating System: Darwin
- Node Version:     v18.18.2
- Nuxt Version:     3.13.0
- CLI Version:      3.13.1
- Nitro Version:    2.9.7
- Package Manager:  unknown
- Builder:          -
- User Config:      ssr, nitro, compatibilityDate, devtools, app, modules, runtimeConfig, plugins, hooks, sitemap
- Runtime Modules<EMAIL_ADDRESS><EMAIL_ADDRESS>- Build Modules:    -
------------------------------

Reproduction
import lazySizes from 'lazysizes'
import 'lazysizes/plugins/parent-fit/ls.parent-fit'

export default defineNuxtPlugin(() => {
    lazySizes.init()
})

plugins/lazysizes.client.js
I get this error.

rendered on server: class="c-product__image lazyloading"

Describe the bug
As above, lazyloading shouldn't be applied on server as the plugin shouldn't be running...
Additional context
No response
Logs
No response

Here is one:
https://layout-transition-no-worky-nuxt3.netlify.app/
https://github.com/simonhrogers/transition-no-worky
My workaround for this, has been to wrap the import in a client check, but this appears to negatively affect load times in pagespeed scores:
  if (import.meta.client) {
    import('lazysizes')
    import('lazysizes/plugins/parent-fit/ls.parent-fit')
  }

Seems counter intuitive considering the suffix should be sufficient enough as a "client check".

Oh absolutely, the plugin should only be loaded on the client as stated at the top of the Nuxt docs:
You can use .server or .client suffix in the file name to load a plugin only on the server or client side.
I’m just sharing a quick workaround as I don‘t know how quickly the Nuxt team is currently able to respond to issues like this!  It feels like a fundamental part of the framework not working as advertised to me, as does my open issue on layout transitions, but they are a small team doing a heroic amount and I imagine Nuxt 4 is taking a lot of headspace.

In your reproduction, the plugin is not running on the server, nor are the classes c-product__image lazyloading rendered on either page.
Note that you do not need to add the plugin in the plugins array in nuxt config - they are scanned automatically.
Would you explain more, or provide a working reproduction? 🙏

Good to know about the plugins scanning.

nor are the classes c-product__image lazyloading rendered on either page.

https://github.com/simonhrogers/transition-no-worky/blob/main/pages/index.vue#L93
See the above, ignore the .c-product_image, that's from my setup. It's the .lazyloading class were looking at.

It's actually nothing to do with the .init() either, it's running on the server just via the import
import lazySizes from 'lazysizes'
// import 'lazysizes/plugins/parent-fit/ls.parent-fit'

export default defineNuxtPlugin(() => {
//     lazySizes.init()
})

No, the lazyloading class isn't added either in the server-rendered HTML.
I've added a console log and fixed the incorrect HTML. You can see it's working fine: https://stackblitz.com/edit/github-xdvnbl?file=plugins/lazysizes.client.js,pages/about.vue,pages/index.vue

The problem, is the OP is not linked to the hydration of the kindly provided reproduction.
Here is my error. Perhaps, it's nothing to do with lazysizes, it's just the "rendered on server" is giving us a red herring? As lazyloading or lazyloaded should never happen on server.

The error is almost certainly related to the lazy loading code running before Nuxt is hydrated.
That's why I suggested using onNuxtReady.
But if the code runs on import and not when calling init() then you may have to use a dynamic import as you suggested.

@danielroe Sorry my bad – you’re right – it works perfectly in my reproduction once the nuxt.config plugins array was removed, mistake on my part as I thought it was still needed (I’ve been a Nuxt user since V1).
If you do have time to look into https://github.com/nuxt/nuxt/issues/28988, which is what I originally prepared the reproduction for, I would really appreciate it as it would save me doing some fairly massive/hacky workarounds to get it to appear as if there were different layouts. If you have time this week or next, I would love to buy you a 1:1 bouldering coaching session with Louis Parkinson should you ever be down in London :-)

you know the way to my heart

indeed – there is only bouldering
...non-London based coach also offered, but I have only been bouldering a couple of years and had a lovely time with Louis and a couple of friends in May which has seriously helped all three of us get the most out of our sessions :-) Mike Mullins in Scotland I hear is also great


illogicality

@Krastanov  in lv_tileview.c file
/**

@file lv_tab.c

*/
/*********************
/**

@file  lv_tileview.c

*/
/*********************

@caoliuchao Thanks for the report! Please tell me around which line number(s) in the file(s) you saw this.


Is it possible to do something like this so I don't need to enter my password when starting a instance?

The following blog explains how to add entries to the shudders file so that you don't need to enter your root password to start Vagrant when command is run for landrush to start that needs SUDO, this one appears to be targeted at NFS alone?
https://blog.jtclark.ca/2014/07/how-to-start-vagrant-boxes-without-a-password-on-your-mac/
What are the commands that get run at start and stop on a Mac?

@BrianGilbert landrush doesn't normally need root privileges to start and stop. Can you make a gist of the commands and output leading up to the password prompt you're seeing?

confirmed it was NFS shares asking for PW


Add required dependencies

Now depends on ToolbarController and ClickThroughBlocker

Thanks!
For thoroughness, confirmed that it's mentioned in the GitHub release note:

... although that version isn't on SpaceDock yet. We might need to do some clean-up after the dust settles.


[11.x] Read XSRF-TOKEN Directly from Cookie

Description:
I propose enhancing the XSRF token retrieval process to also read the XSRF-TOKEN directly from the cookie if the input or header does not contain the token.
Rationale:
There are numerous cases where users encounter errors related to missing XSRF tokens because they don't understand the current mechanism. Even if the header is set, the cookie contains the same data. By reading the XSRF-TOKEN directly from the cookie, we simplify the process and reduce potential errors.
Benefits:

Improved Reliability: Ensures the token is always retrieved, reducing the chance of missing token errors.
Simplicity: Cookies are already decrypted at this point, eliminating the need to pass the token through a decryptor (as it's done for header).
Tested Solution: I have tested this approach on two projects, and it works seamlessly.

https://cheatsheetseries.owasp.org/cheatsheets/Cross-Site_Request_Forgery_Prevention_Cheat_Sheet.html#storing-the-csrf-token-value-in-the-dom

A CSRF token can be included in the  tag as shown below. All subsequent calls in the page can extract the CSRF token from this  tag. It can also be stored in a JavaScript variable or anywhere on the DOM. However, it is not recommended to store the CSFR token in cookies or browser local storage.

Yes, but Laravel already stores it inside cookies. It's not about storing, it's about reading it from the cookie. If we follow that link, Laravel should remove the csrf-cookie endpoint, that sets cookie with the name XSRF-TOKEN.
I think Laravel comply this OWASP recommendation by encrypting CSRF token and storing it encrypted in cookies.

Thanks for your pull request to Laravel!
Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.
If possible, please consider releasing your code as a package so that the community can still take advantage of your contributions!
If you feel absolutely certain that this code corrects a bug in the framework, please "@" mention me in a follow-up comment with further explanation so that GitHub will send me a notification of your response.

Yes, but Laravel already stores it inside cookies. It's not about storing, it's about reading it from the cookie. If we follow that link, Laravel should remove the /csrf-cookie endpoint, that sets cookie with the name XSRF-TOKEN.

The CSRF token must be submitted to the server in another way than via a cookie, as its purpose is to show that the request is first-party, and not initiated from a third party (which may still carry cookies depending on settings). See the OWASP page for more information about the kind of attacks the CSRF token prevents.
The XSRF Laravel cookie is simply a convenience feature, and is only used in the direction from the server to the client. It is used because client libraries like axios automatically pick up the cookie value and send is as request headers (an example of "another way", as post data is also valid).


[BUG] Macro variable (KeyRelease) didn't work in some conditions

Hope I'm not wasting you time.
🔵 *Describe the bug😘
I use this macro:
{
["Variables"] = {
["KeyRelease"] = {
[1] = "/castsequence [nochanneling,exists]   reset=target  Marchio del Cacciatore, null",
[2] = "/cast [exists] Tiro Mortale"
},
["KeyPress"] = {
[1] = "/targetenemy [noharm]",
[2] = "/castsequence [nochanneling,nopet,nodead]   reset=target/combat  Richiamo: Famiglio 1, Cura Famiglio; [nochanneling,@pet,dead] Cura Famiglio",
[3] = "/petattack [pet,harm]",
[4] = "/petassist [pet,harm]",
[5] = "/petpassive [noharm]",
[6] = "/startattack [nocombat]",
[7] = "/cast [combat,pet] Slancio",
[8] = "/cast [combat,pet] Morso; [combat,pet] Sfregio; [combat,pet] Botta"
}
},
["Actions"] = {
[1] = {
[1] = "KeyPress",
[2] = "/cast [combat] Tiro Lacerante",
[3] = "KeyRelease",
["Type"] = "Action"
},
[2] = {
[1] = "KeyPress",
[2] = "/cast [combat,exists] Ordine di Morte",
[3] = "KeyRelease",
["Disabled"] = false,
["Type"] = "Action"
},
[3] = {
[1] = "KeyPress",
[2] = "/cast [combat,exists] Tiro Mortale",
[3] = "KeyRelease",
["Type"] = "Action"
},
[4] = {
[1] = "KeyPress",
[2] = "/castsequence [combat]   reset=combat/3  Tiro Lacerante, Ordine di Morte",
[3] = "KeyRelease",
["Type"] = "Action"
},
[5] = {
[1] = "KeyPress",
[2] = "/cast [combat] Ira Bestiale",
[3] = "KeyRelease",
["Type"] = "Action"
},
[6] = {
[1] = "KeyPress",
[2] = "/cast [nochanneling,talent:7/3,exists,pet] Carneficina",
[3] = "KeyRelease",
["Disabled"] = false,
["Type"] = "Action"
},
[7] = {
[1] = "KeyPress",
[2] = "/cast [combat] Tiro del Cobra",
[3] = "KeyRelease",
["Type"] = "Action"
}
},
["InbuiltVariables"] = {
["Trinket1"] = true,
["Combat"] = true
}
}
If I delete the block [6] OR Talent "Carneficina" so the block can work, the variables content of KeyRelease stop working.
🔵 To reproduce: (Steps to reproduce the behavior)
Simply use the macro
🔵 **GSE.lua file😘
GSE.lua.txt
🔵 Desktop (please complete the following information):

OS: Mac OS Monterey 12.1
Game Version retail last version

🔵 GSE Version:

Version: last version
Downloaded From: https://www.curseforge.com

Quick questions -
Are either of these on the GCD:
[1] = "/castsequence [nochanneling,exists] reset=target Marchio del Cacciatore, null",
[2] = "/cast [exists] Tiro Mortale"
if so then it’s not a bug but working the way it is supposed to as they will be blocked by the spells in your actions.  Your macro can only do one GCD spell per action and these will never get processed as there are GCD spells in your actions ahead of these.
when I hit compile template these are showing where they are supposed to be so this isn’t a bug with GSE but potentially a case where your macro is trying to break WoW’s rules.
Also when you disable a block everything in that block is disabled including the variables for that block.
moving this to a discussion as it looks to be a question rather than a bug.


Flutter: Why to use Flutter?

A README file to understand.

Why to use flutter.
Why to use it over traditional android and ios development,
How it reduces code
Which language it uses

The reference you may take:
Flutter Docs: https://flutter.dev/
https://github.com/dwyl/learn-flutter

Can I work on this,I'm contributor in GWoC'21

Can I please work on this.

Can I please work on this.

@msramesh2k1 can you take issue #136

@msramesh2k1 can you take issue #136 ?

Sure

Can u pls assign me any work,I really want to contribute in this

I'd like to contribute to this issue.

Hey @ViAsmit,
Shabi Kaushal this side. I am good at Cross-platform development using Dart and Flutter. I can implement them in practice lucidly as well as document them. May you assign me this task?
Shabi Kaushal (Android Development with Flutter Batch 10)
issue #448


”Dăeni” is listed in the drop-down menu

Description:
"Dăeni" is listed in the drop-down menu alongside its corresponding county and commune, according to the law.
Precondition:
The website is up an running.

Step 1
Type "Dăeni" in the search bar.

Expected results
The location is listed in the drop-down menu as "Comuna Dăeni, TULCEA".


✨ Adds interop delay option

Description

by default the inclusiondelay is false
adds --interop.inclusiondelay flag in cli which delays sent messages by 5 seconds

Todo:

[ ] write tests
[ ] update documentation

Metadata

#133

discussed on tg: decided that it be better to include this logic in opsimulator rather than indexer


Group collections on multiple fields

Use case
In the project I am working on I frequently need to create nested structures that are then converted to JSON. This involves some ugly boilerplate code that is needed each time, so my idea is to add a groupByMultiple function to Laravel's Collections that supports grouping multiple times into a nested structure. The new function will be similar to the existing groupBy function.
Example:

A
B
C
D

foo
bar
baz
thud

foo
garply
corge
plugh

foo
bar
corge
thud

foo
bar
corge
waldo

qux
garply
xyzzy
fred

qux
grault
garply
quuz

By calling myCollection->groupBy(['A', 'B', 'C', 'D']) the result would become:

foo

bar

baz

thud [foo, bar, baz, thud]

corge

thud [foo, bar, corge, thud]
waldo [foo, bar, corge, waldo]

garply

corge

plugh [foo, garply, corge, plugh]

qux

garply

xyzzy

fred [quz, garply, xyzzy, fred]

grault

garply

quuz [qux, grault, garply, quuz]

Backwards compatibility
Since this is a new function and does not change existing functions, it could be added to 5.4 because no backwards compatibility is broken. The new functionality cannot be integrated into the existing groupBy function, because the groupBy function signature is groupBy(callable|string $groupBy, bool $preserveKeys = false) and this conflicts with groupBy(callable|string|array $groupBy, bool $preserveKeys = false) because a callable can be an array ["Foo", "Bar"] where Foo::Bar() is a valid method.
Cross compatibility
The groupByMultiple function is somewhat compatible with groupBy in that it functions in the same way if you pass as first argument something that is not an array, so just like groupBy you can call it with a string or a closure. The function just puts the first argument in an array if it isn't one. If you try to pass a callable as an array, so ["Foo", "Bar"] where Foo::Bar() is a valid method, then of course the groupByMultiple function will just attempt to group on the key "Foo" first and "Bar" second; this is the main difference with groupBy(). Of course you can pass an array with a callable in it, so [["Foo", "Bar"]] or [["Foo", "Bar"], "Baz"] would work just fine.
Code questions
My implementation is heavily based on Laravel's groupBy function. Since I am not that familiar with Laravel's internal code I am very open to improvements. For example I have a few questions:

I basically inlined the usage of offsetSet() because it was simpler. Is that okay?
The original groupBy code directly creates a child collection because the nesting is always one level, but when you have arbitrary grouping levels this is not possible. To solve this I added a helper to Arr which recursively converts a (nested) array into a (nested) collection. I am not sure this is the right place though, perhaps add it to Collection itself? It could also be made private if you do not want it exposed.

Tests

I modified all existing Collection groupBy unit tests to also call groupByMultiple with the same parameters, and they all pass. This ensures the "semi cross-compatibility".
I also created new unit tests specific to groupByMultiple that are based on all the cases that the existing groupBy unit tests test. They also all pass.

Performance

Do I need to test for performance "regressions" compared to groupBy?
Is there a frequently used / standard benchmark for collection operations?

Would love to hear feedback :)

Would rather this just be published as a package macro. Thanks.

Thanks for responding @taylorotwell. I can definitely publish this as a package macro, but can you tell me what the reasoning behind this is? Since it's not a new feature per se, it's meant to allow the existing groupBy to group on more than one field.

It would be very rare situation that user need to do it.... But your work is appreciable.. 👍
Thanks.

In both my job and my study I actually need this functionality quite a lot, but I guess it totally depends on what kind of problems you work on.
I also tried to submit it to an already existing Laravel collection macros project, but the developer refused to merge it because he didn't need the specific functionality in his own projects. Gotta love open source development!
Anyway I put it up as a separate package if anyone ever needs this: https://packagist.org/packages/thomhurks/laravel-collection-extensions


Add option to reevaluate key during save

Description
In save.ts there's a comment that describes that because inputs are reevaluated before the post action, the cache key is  retrieved from state instead of input:
https://github.com/actions/cache/blob/5c79b3fd6c0e87c9444fe7b18edafe7d9ba61531/src/save.ts#L29-L30
In some cases, it is actually quite desirable to have the input re-evaluated and a different cache key used for save than was used during restore.
This PR adds an option reevaluate-key which when set true will re-evaluate the key input in the post action instead of retrieving it from state.
The default is false, retaining the existing behavior.
Motivation and Context
I'm primarily a .NET developer, and I often use this cache action to cache NuGet packages for my build pipelines.  When doing so, I have to create a cache key from some reasonable source of the packages in my repository.  If I've opted in to using lock files, then I can  use the packages.lock.json files that are created when the restore phase of my build executes.  Indeed, this is what the examples file shows.  But there are downsides to using lock files, and thus they are off by default in .NET.
Without lock files, one can base the hash on project files (.csproj, .props, etc.), but there are many reasons that project files might change - not just package changes.  Also that technique doesn't take into account any floating versions that might be defined in the projects, such as <PackageReference Include="SomePackage" Version="2.*" />.  There could be a new version of the package without any change to the file, and thus the cache would never get updated.
Since lock files are still the best source of information about which packages are installed, the easiest thing to do is create them during restore with dotnet restore --use-lock-file.   The problem is that the cache restore has to run first.
So, by having an option to re-evaluate the key, we can save a cache based on the hash of the generated lock files.  If anything ever changes, a new cache gets created automatically and used on subsequent runs.
Without the option, there's no way to base the cache key on the generated lock files.  Generating them before the cache restore would restore all packages without using the cache, invalidating the reason to have a cache in the first place.
I'm reasonably certain that this unblocks many other similar scenarios.  It's not just for .NET developers.  Pretty much any time you need to base the cache key on something that depends on the files being cached, you'll need to re-evaluate the key.
How Has This Been Tested?

I added unit tests to this PR
I built and deployed a branch on my fork, then used it in a workflow of a test project on another repo to validate its behavior.
I also tested without the option set, to ensure that the default behavior does not change.

Screenshots:
First Run (nothing in the cache):

Cache created by first run:

Second Run (has cache hit):

Workflow for above tests is as follows (using my fork):
name: Build

on:
  workflow_dispatch:
  push:
    branches: [ main ]

jobs:

  build:
    runs-on: ubuntu-latest
    steps:

      - name: Checkout
        uses: actions/checkout@v3

      - name: Cache
        uses: mattjohnsonpint/gha-cache@dist
        with:
          path: ~/.nuget/packages
          key: nuget-${{ runner.os }}-${{ hashFiles('**/packages.lock.json') }}
          restore-keys: nuget-${{ runner.os }}
          reevaluate-key: true

      - name: Restore .NET Dependencies
        run: dotnet restore --use-lock-file --nologo

      - name: Build
        run: dotnet build -c Release --no-restore --nologo

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[x] Documentation (add or update README or docs)

Checklist:

[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

Does your process also require I build and commit the dist folder?  That would seem strange to me, and it's not described in the contributing docs.  Please advise. Thanks.

Seeing that other PRs have indeed been including the dist folder, I have done the same.  But really this should be added to the contributing docs, as most other projects would expect you only commit source files to a PR.  THanks.

Thanks @mattjohnsonpint  for contributing.  Yes dist/ changes are indeed required for tests to pass.
I understand what change you are proposing but have some questions -

If the lockfile is changing , it would normally be committed to the repository and not remain unchanged. Why would people use stale lockfiles in their repos?
We are also trying to give users  the ability to decide where in the workflow they want to run restore and/or save separately. Would that help solve this problem?

If the lockfile is changing , it would normally be committed to the repository and not remain unchanged. Why would people use stale lockfiles in their repos?

In .NET, lock files are not normally used.  The tooling does not create them unless specifically asked to do so.  Thus by default, there's no complete list of which packages and versions are required to restore a project - which means no good source of information to create a cache key.  One way to get that information is to create a lock file on the fly during the restore phase of a CI build.  It's never committed to the repository, so it's never stale.  It's not actually used to lock anything, but rather as the basis for the cache key.  Since the cache-restore doesn't require an exact match on the key, it can easily restore the last cache that was created regardless of the full key.  Then by creating the lock file and using it to compute the cache key, a save only occurs if the key has changed - because the lock file has changed in some way.
One important use case is when floating versions are used.  For example, I use floating versions in unit test projects for the libraries I develop, such that my library is always being tested against the latest version of any dependencies.
Sure, I could instead switch to using lock files and commit them.  But then I would have to also have a process to separately update the lock files any time one of my dependencies had an update.  On larger projects, this can lead to a disproportionately large number of pull requests that are just bump versions of dependencies for no other purpose than testing.  Tooling like Dependabot can help automate that, but it still leads to a lot of maintenance overhead.  I prefer just using a floating version in my test projects, and having a test workflow fail when a newer version of a dependency breaks something.

We are also trying to give users the ability to decide where in the workflow they want to run restore and/or save separately. Would that help solve this problem?

Perhaps.  I would need two separate actions - one to restore the cache and a separate one to save it.  I'd also need to have the ability to get the key that was restored, such that I could conditionally compare it to the hash of the generated lockfile to decide whether or not to save.  Otherwise I'd end up saving every run, overwriting a cache that already exists with the exact same content.
I'm not against the idea, but it's a lot simpler with just asking for the key to be re-evaluated.  By doing so, the save phase already recognizes it as a cache hit and doesn't attempt to save again (despite it actually being a cache miss in the restore phase).

I'd also need to have the ability to get the key that was restored (as an output), such that I could conditionally compare it to the hash of the generated lockfile to decide whether or not to save. Otherwise I'd end up saving every run, overwriting a cache that already exists with the exact same content.

If I am not wrong, you would still need to get the restored key as output and compare it - so as to decide whether to set reevaluate-key to true or not.

I'm not against the idea, but it's a lot simpler with just asking for the key to be re-evaluated. By doing so, the save phase already recognizes it as a cache hit and doesn't attempt to save again (despite it actually being a cache miss in the restore phase).

While it will be simpler in this particular case, there are many asks to add more such knobs to the action e.g. force save cache even if job fails, or save cache even if a cache hit occurred earlier etc etc. Individually each ask is a small one and good to do, but in sum total it becomes one too many knobs bringing down usability and actually making it more opaque and prone to misconfiguration.
That's why a more transparent (though a bit more verbose) approach is to have two separate actions and use them in combination by leveraging the conditionals which workflow schema offers.

Hey @mattjohnsonpint 👋🏽
After considering multiple asks from our customers and this use case, we have published two new actions restore and save with restore action outputting the restore key as cache-matched-key.
Also the save action can re-evaluate the key in realtime when the step executes or reuse the primary key passed as input in the restore action using one of the outputs.
Hope it solves the use case. :)
More details about the new actions here - https://github.com/actions/cache/discussions/1028
Beta release feedback from other users - https://github.com/actions/cache/discussions/1020
Closing this now, feel free to reopen if need be, thanks!


Issue #190 Adding tip about sudoers configuration

@LalatenduMohanty, any chance you could verify this sudoer config on your machine?
You can try this Vagrantfile. You can use the latest released version of Landrush. No need to build a gem from HEAD
Vagrant.configure('2') do |config|
  config.vm.box = 'debian/jessie64'
  config.vm.hostname = 'my-host.landrush-acceptance-test'

  config.vm.network :private_network, type: 'dhcp'

  config.vm.synced_folder '.', '/vagrant', disabled: true

  config.landrush.enabled = true
  config.landrush.tld = 'landrush-acceptance-test'
end

@hferentschik will do.


Particle Swarm Optimization (PSO)

Set of activities for this task:

Verify the PSO optimization technique
Analyse if optimization can be integrated to the darwin solution
Implement PSO optimization if possible

Implemented in commit d68421cea5a6197bf3d3b24d6d5330c24d316896. Closing issue.


feat(pom-bom): Add gounthar to pom-bom.

Link to GitHub repository
https://github.com/jenkinsci/bom
When modifying release permission
I will help with PR merge and releases for the BOM occasionally, starting in May.
We have seen with @MarkEWaite.
List the GitHub usernames of the users who should have commit permissions below:

@gounthar

This is needed in order to cut releases of the plugin or component.
If you are modifying the release permission of your plugin or component, fill out the following checklist:
### Reviewer checklist
- [ ] Check that the `$pluginId Developers` team has `Admin` permissions while granting the access.
- [ ] In the case of plugin adoption, ensure that the Jenkins Jira default assignee is either removed or changed to the new maintainer.
- [ ] If security contacts are changed (this includes add/remove), ping the security officer (currently `@Wadeck`) in this pull request. If an email contact is changed, wait for approval from the security officer.

There are IRC Bot commands for it.

You need to login in Jira. From build logs:

User name not known to Jira: gounthar


very slow make command

Issue you'd like to raise.
The make api_docs_build command is very slow. This command builds the API Reference documentation. This command is defined in the Makefile
Suggestion:
No response

Thank you for your very detailed answer. You asked about more specific information about the create_api_rst.py script and the size of your project. The project code is in the langchain/libs folder. Can it help?

@dosu-bot Can you help with refactoring code to split in two make commands? To split the main() function into two parts with the_document_langchain_core() and _document_langchain_experimental() and create two make commands for each.

It was solved (partially) by splitting Docs and API Ref builds into two parts. API Ref build is now even slower but this is another story.


Bonding Text is confusing

UI Version: 0.7.0
Description: When staking to a delegator you have the checkbox that says: "Yes, update my bonds. I understand unbonding will take 30 days". This reads like it's an option instead of a disclaimer.
Maybe good to add something like: "Please confirm you understand that after staking tokens to a validator it will take at least 30 days to remove your tokens again."
Maybe it's good to stop using both "stake" and "bond" as they're basically the same thing, right?

great point @okwme !

Maybe it's good to stop using both "stake" and "bond" as they're basically the same thing, right?

yes, please let's use stake / staking.

I think Rigel wants to use Delegating and Undelegating everywhere, instead of "stake" or "bond". Pingingg @rigelrozanski

Having meditated on this, I think the clearest language can be broken down as following:

To describe a delegators action we use delegating/undelegating/redelegating
To describe the created object we use delegation/unbonding-delegation/redelegation
(rare) to describe the state of tokens we use bonded/unbonding/unbonded

Thus I would say:
Please confirm you understand that after delegating to a validator, undelegating takes 3 weeks. Note however that you may redelegate to other validators instantaneously. See XXX for a more detailed explanation

I'd include a link to further descriptions

moved to #781


Adds Dense SIFT feature type. http://www.vlfeat.org/overview/dsift.html

Hi,
vl/dsift.h is already present in opensfm/src/third_party/vlfeat/vl/dsift.h
They are not part of this pull req.
-sashi.
On Fri, Apr 20, 2018 at 8:39 PM, Russ<EMAIL_ADDRESS>wrote:

@russkel commented on this pull request.
In opensfm/src/dsift.cc
https://github.com/mapillary/OpenSfM/pull/236#discussion_r183199051:

@@ -0,0 +1,52 @@
+#include "types.h"
+#include "dsift.h"

+#include
+#include
+
+extern "C" {

#include "vl/dsift.h"

Are these files included in the pull req?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/mapillary/OpenSfM/pull/236#pullrequestreview-114161644,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Af6yBm19FiMlzHaRQAvhcVcqlfAf-KCaks5tqqnqgaJpZM4QVw9n
.

Hi @sashichandra, sorry I deleted my comment after I found the file.

Is there a chance you could resolve the conflict in the features.py file @sashichandra ?
@paulinus are you willing to merge this? Otherwise I'll pull this into my own working copy.

@russkel, I've resolved the conflicts on this branch and put the result in this branch https://github.com/paulinus/OpenSfM/tree/sashichandra-dsift
About merging it to master, the main concern is that Dense SIFT is not a suitable feature for SfM in general.  The reason for that is that it extracts features on a fixed grid that is not adapted to the actual image texture. As a result, corresponding features in different images are not centered around the same real-world point.  This adds substantial error to triangulation and resection algorithms to the point where they no longer work.
Testing this branch on berlin and lund dataset, I was unable to get good reconstructions. Only berlin yield a reasonable reconstruction after setting dsift_step to a small number so that the discretization error was reduced. That produced a lot more features which were then slow to match.
If there is a trick to make things work better, please let me know.


opening the repo in 4.2 version shows a lot of error logging

Recently opened the project with the v4.2 (been working with 4.1 previously)
and the console log is flooded with some errors.
These needs to be looked into and resolved.

oops nvm it is because there are some local changes. closing.


RCTCamera.xcodeproj unavailable for setup in 0.3.7

Step three of installation states:

Go to node_modules ➜ react-native-camera and add RCTCamera.xcodeproj

However, when I upgrade from 0.3.6 to 0.3.7 the RCTCamera.xcodeproj file is no longer available.

My fault - closing, sorry!


[ISSUE] 17.2 feature KO is no access to window action

    {
        "jsonrpc": "2.0",
        "id": null,
        "error": {
            "code": 200,
            "message": "Odoo Server Error",
            "data": {
                "name": "odoo.exceptions.AccessError",
                "debug": ""
                "message": "You are not allowed to access 'Action Window' (ir.actions.act_window) records.\n\nThis operation is allowed for the following groups:\n...\n\nContact your administrator to request access if necessary.",
                "arguments": [
                    "You are not allowed to access 'Action Window' (ir.actions.act_window) records.\n\nThis operation is allowed for the following groups:\n...\n\nContact your administrator to request access if necessary."
                ],
                "context": {}
            }
        }
    }

Confirmed

tooltipMetadata
assignMeTask
starringTaskEffect

Maybe

newServerActionCode

Addition of developer option to setup manual link between window action and model


Whoami example not working after cluster restart

Yesterday I did a full wipe of my local K3S installation. I have successfully tested the example afterwards. I could deploy my own Helm chart and use the Mesh, however I have encountered an issue (traffic was routed to the wrong service) and had to call it a day.
After starting my cluster today I verified that all pods have started successfully. The whoami example is not working anymore.
$ kubectl -n whoami exec whoami-client -- curl -Lv whoami.whoami.maesh
* Expire in 0 ms for 6 (transfer 0x55de5b1c8620)
* Expire in 1 ms for 1 (transfer 0x55de5b1c8620)
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0* Expire in 0 ms for 1 (transfer 0x55de5b1c8620)
* Expire in 1 ms for 1 (transfer 0x55de5b1c8620)
* Expire in 0 ms for 1 (transfer 0x55de5b1c8620)
[...]
* Expire in 0 ms for 1 (transfer 0x55de5b1c8620)
* Could not resolve host: whoami.whoami.maesh
* Expire in 0 ms for 1 (transfer 0x55de5b1c8620)
* Closing connection 0
curl: (6) Could not resolve host: whoami.whoami.maesh
command terminated with exit code 6

I'm not sure if that is an issue with Maesh or K3S, but I was expecting that a Kubernetes cluster would survive a restart of the underlying OS.

I'm not sure if that is an issue with Maesh or K3S, but I was expecting that a Kubernetes cluster would survive a restart of the underlying OS.

Kubernetes is not designed to be able to handle that sort of situation, and in production it would be a complete rebuild if quorum was lost.
In this case, is the resolution broken on restart? A clean install works fine?

In this case, is the resolution broken on restart? A clean install works fine?

Yes, clean install works fine.

Kubernetes is not designed to be able to handle that sort of situation

How are people developing on Kubernetes clusters if I cannot restart the cluster node? I was under the impression that losing a node should be handled gracefully by Kubernetes. Can I work around this by having at least two nodes where one is always reachable (e.g. cloud provider) and the other is my local workstation (as you've mentioned quorum loss)? I apologize for asking all these newbie questions, but that's what I currently am, a complete Kubernetes noob. I'm learning as I'm going and I really appreciate all the answers I'm getting here. Thank you!

Hello @riker09

How are people developing on Kubernetes clusters if I cannot restart the cluster node?

Most of us use development cluster tools such as k3s for just this reason. K3s allows for new clusters to be quickly scaffolded. There is another tool k3d that is used exclusively to quickly build k3s clusters, and we use it in our own integration tests!
https://github.com/containous/maesh/blob/master/Makefile#L43

I was under the impression that losing a node should be handled gracefully by Kubernetes.

Correct, kubernetes can handle (n-1)/2 failures where n is the number of nodes (data and control plane separate). If your control plane loses more than half its nodes, the cluster is unrecoverable. Data nodes don't have the same quorum, but if you lose more data nodes than your workload, pods will be unscheduleable.

Can I work around this by having at least two nodes where one is always reachable (e.g. cloud provider) and the other is my local workstation (as you've mentioned quorum loss)?

Its not really that feasible for development. I would look at using another scaffolding tool like k3d to quickly rebuild your cluster if you break it. I personally use the k8s installation in docker-for-mac for development, but that too has to be rebuilt when I break stuff.

Okay, so the solution is recreating everything from scratch each time. I noticed that Persistent Volumes (and Claims) survive during a restart (guess that's the persistence everybody is talking about :slightly_smiling_face: ) and I can store data that I want to keep during reboots in a PV.
I have already looked at another scaffolding tool skaffold. I will spend some time and investigate k3d and see how they both compare. In the meantime I guess I will use a combination of helm and kubectl commands and do everything by hand until I'm more familiar with the whole Kubernetes universe.
Thanks again for your kind answers and taking your time for explaining everything.

No Problem. Therefore, I close this :)


let's try returning text/plain in serial console geneva action

application/octet-stream gives us an xml + base64 encoded response; I think we should probably be ok just to use text/plain.

@nilsanderselde fyi (I guess I was wrong again ;-)