x/tools/gopls: reverting files after formatting

What version of Go are you using (go version)?

$ go version
go version go1.12.5 windows/amd64

Https://go.googlesource.com/tools
Commit:e45ffcd953cceb219dc536e24468c0d22a5be010

Does this issue reproduce with the latest release?
What did you do?
x/tools/gopls makes me painful.
I recently updated this package. I often can't save the code.
Sometimes, When I delete some code, after pressing ctrl +s, those extra codes will appear again.
I don't know if the description is clear,
if there are other people who have encountered it.
In short, this is a painful experience.
What did you expect to see?
When I press ctrl +s, I can save the code automatically.
What did you see instead?
When I delete some code, after pressing ctrl +s, those extra codes will appear again.

I'm sorry you're experiencing this issue; this definitely shouldn't happen. What editor are you using gopls with? Can you confirm your gopls version by running the gopls version command?

Also, can you share your gopls logs from a time when this happens? You can get information on how to get logs in the Troubleshooting guide.

@stamblerre
Thank you very much for your enthusiastic and positive reply. Just before the bug appeared, my operation is ctrl+x cutting a line, then pressing ctrl+s, then the code is messed up.
Initial code
package cmd

import (

	"github.com/ElandGroup/joblog"
	"log"
	"github.com/ElandGroup/joblog"
	"log"
	"github.com/ElandGroup/joblog"
	"log"
	_ "github.com/go-sql-driver/mysql"
	"github.com/spf13/viper"
)

var jobLog *joblog.JobLog
const (
	YMLNAMEPROJEC        = "project"
	YMLNAMEDOCKERCOMPOSE = "docker-compose"
	CONFIGNAMENGINX      = "default"
	SUFSERVER            = "-server"
	PRETEST              = "rtc-"

	TEMP_FILE        = "temp"
	EventBroker_Name = "event-broker-kafka"
	jobLogUrl        = "https://gateway.p2shop.com.cn/batchjob-api/v1/jobs"
)

Code after ctrl + x
package cmd

import (
	"github.com/ElandGroup/joblog"
	_ "github.com/go-sql-driver/mysql"
	"github.com/spf13/viper"
)

var jobLog *joblog.JobLog

const (
	YMLNAMEPROJEC        = "project"
	YMLNAMEDOCKERCOMPOSE = "docker-compose"
	CONFIGNAMENGINX      = "default"
	SUFSERVER            = "-server"
	PRETEST              = "rtc-"

	TEMP_FILE        = "temp"
	EventBroker_Name = "event-broker-kafka"
)

Code after ctrl + s
package cmd

import (
	_ "github.com/go-sql-driver/mysql"
const (
	YMLNAMEPROJEC        = "project"
	"log"
	YMLNAMEDOCKERCOMPOSE = "docker-compose"
	CONFIGNAMENGINX      = "default"
	SUFSERVER            = "-server"

	PRETEST              = "rtc-"

	TEMP_FILE        = "temp"
	EventBroker_Name = "event-broker-kafka"
)

golang.org/x/tools/gopls v0.1.7
<EMAIL_ADDRESS>h1:YwKf8t9h69++qCtVmc2q6fVuetFXmmu9LKoPMYLZid4=

PS D:\source\gopath\src\rtc-api> gopls -debug
flag needs an argument: -debug
The Go Language source tools.
Usage: gopls [flags]  [command-flags] [command-args]
Available commands are:
serve : run a server for Go code using the Language Server Protocol
bug : report a bug in gopls
check : show diagnostic results for the specified file
format : format the code according to the go standard
query : answer queries about go source code
version : print the gopls version information
    Serve debug information on the supplied address

-listen string
address on which to listen for remote connections
-logfile string
filename to log to. if value is "auto", then logging to a default output file is enabled
-mode string
no effect
-ocagent string
The address of the ocagent, or off (default "off")
-port int
port on which to run gopls for debugging purposes
-profile.cpu string
write CPU profile to this file
-profile.mem string
write memory profile to this file
-profile.trace string
write trace log to this file
-remote string
EXPERIMENTAL - forward all commands to a remote lsp
-rpc.trace
Print the full rpc trace in lsp inspector format
-v    Verbose output
PS D:\source\gopath\src\rtc-api>
PS D:\source\gopath\src\rtc-api> gopls bug
Please file a new issue at golang.org/issue/new using this template:
Please answer these questions before submitting your issue. Thanks!
What did you do?
If possible, provide a recipe for reproducing the error.
A complete runnable program is good.
A link on play.golang.org is better.
A failing unit test is the best.
What did you expect to see?
set GOFLAGS=
set GOHOSTARCH=amd64
set GOHOSTOS=windows
set GOOS=windows
set GOPATH=D:\source\gopath
set GOPROXY=
set GORACE=
set GOROOT=C:\Go
set GOTMPDIR=
set GOTOOLDIR=C:\Go\pkg\tool\windows_amd64
set GCCGO=gccgo
set CC=gcc
set CXX=g++
set CGO_ENABLED=1
set GOMOD=
set CGO_CFLAGS=-g -O2
set CGO_CPPFLAGS=
set CGO_CXXFLAGS=-g -O2
set CGO_FFLAGS=-g -O2
set CGO_LDFLAGS=-g -O2
set PKG_CONFIG=pkg-config
set GOGCCFLAGS=-m64 -mthreads -fmessage-length=0 -fdebug-prefix-map=C:\Users\ADMINI~1\AppData\Local\Temp\go-build513634462=/tmp/go-build -gno-record-gcc-switches

vscode version: 1.38.1

{
"explorer.confirmDragAndDrop": false,
"git.enableSmartCommit": true,
"window.zoomLevel": 1,
"git.autofetch": true,
"workbench.colorTheme": "Visual Studio Light",
"javascript.updateImportsOnFileMove.enabled": "never",
"terminal.integrated.rendererType": "dom",
"terminal.integrated.shell.windows": "C:\Windows\System32\WindowsPowerShell\v1.0\powershell.exe",
"python.jediEnabled": false,
"editor.suggestSelection": "first",
"vsintellicode.modify.editor.suggestSelection": "automaticallyOverrodeDefaultValue",
"extensions.ignoreRecommendations": true,
"editor.minimap.enabled": true,
"workbench.statusBar.visible": true,
"files.eol": "\n",
"editor.multiCursorModifier": "ctrlCmd",
"editor.formatOnPaste": true,
"go.formatTool": "goimports",
"go.useLanguageServer": true
}

Can you share your gopls logs from when the error occurs? (See how to do this here.) It looks like you don't have the formatting configurations for gopls set, so I wonder if this is a combination of gopls interacting with VSCode-Go. Does the error still occur if you've set the following?
"[go]": {
    "editor.formatOnSave": true,
    "editor.codeActionsOnSave": {
        "source.organizeImports": true,
    }
}

before ctrl + s

type ProjectOwnerDto struct {
	IsKafka     bool
	IsMysql     bool
	IsSqlserver bool
	IsRedis     bool
	DbNames     []string
	Databases   map[string][]string
	Children    []string
}

modify:
IsSqlserver  ==> IsSqlServer
after ctrl +s
type ProjectOwnerDto struct {
type ProjectOwnerDto struct {
type ProjectOwnerDto struct {
	IsKafka     bool
	IsMysql     bool
	IsRedis     bool
	IsRedis     bool
	DbNames     []string
	Databases   map[string][]string
	Children    []string
	Entrypoint     string              `json:"entrypoint"`
	Envs           []string            `json:"envs"`
	IsProjectKafka bool                `json:"isProjectKafka"`
	Ports          []string            `json:"ports"`
	Databases      map[string][]string `json:"databases"`
	StreamNames    []string            `json:"streamNames"`

gopls --rpc.trace -v check D:\source\gopath\src\rtc-api\cmd\project.go
2019/09/25 06:20:46 Info:2019/09/25 06:20:46 Build info
----------
version v0.1.6, built in $GOPATH mode

Go info
-------
go version go1.12.5 windows/amd64

set GOARCH=amd64
set GOBIN=
set GOCACHE=C:\Users\Administrator\AppData\Local\go-build
set GOEXE=.exe
set GOFLAGS=
set GOHOSTARCH=amd64
set GOHOSTOS=windows
set GOOS=windows
set GOPATH=D:\source\gopath
set GOPROXY=
set GORACE=
set GOROOT=C:\Go
set GOTMPDIR=
set GOTOOLDIR=C:\Go\pkg\tool\windows_amd64
set GCCGO=gccgo
set CC=gcc
set CXX=g++
set CGO_ENABLED=1
set GOMOD=
set CGO_CFLAGS=-g -O2
set CGO_CPPFLAGS=
set CGO_CXXFLAGS=-g -O2
set CGO_FFLAGS=-g -O2
set CGO_LDFLAGS=-g -O2
set PKG_CONFIG=pkg-config
set GOGCCFLAGS=-m64 -mthreads -fmessage-length=0 -fdebug-prefix-map=C:\Users\ADMINI~1\AppData\Local\Temp\go-build056399410=/tmp/go-build -gno-record-gcc-switches
2019/09/25 06:20:47 Info:2019/09/25 06:20:47 114.9961ms for GOROOT=C:\Go GOPATH=D:\source\gopath GO111MODULE= PWD=D:\source\gopath\src\rtc-api go "list" "-e" "-json" "-compiled=true" "-test=true" "-export=false" "-deps=true" "-find=false" "--" "builtin", stderr: <<>>
2019/09/25 06:20:47 Info:2019/09/25 06:20:47 124.9034ms for GOROOT=C:\Go GOPATH=D:\source\gopath GO111MODULE= PWD=D:\source\gopath\src\rtc-api go "env"
"GOMOD", stderr: <<>>
2019/09/25 06:20:47 Info:2019/09/25 06:20:47 133.9693ms for GOROOT=C:\Go GOPATH=D:\source\gopath GO111MODULE= PWD=D:\source\gopath\src\rtc-api go "list" "-m" "-json" "all", stderr: <<go list -m: not using modules
>>
2019/09/25 06:20:47 Info:2019/09/25 06:20:47 150.995ms for GOROOT=C:\Go GOPATH=D:\source\gopath GO111MODULE= PWD=D:\source\gopath\src\rtc-api go "list"
"-m" "-json" "all", stderr: <<go list -m: not using modules
>>
2019/09/25 06:20:47 Info:2019/09/25 06:20:47 212.9986ms for GOROOT=C:\Go GOPATH=D:\source\gopath GO111MODULE= PWD=D:\source\gopath\src\rtc-api go "env"
"GOPATH", stderr: <<>>
2019/09/25 06:20:47 Info:2019/09/25 06:20:47 155.9941ms for GOROOT=C:\Go GOPATH=D:\source\gopath GO111MODULE= PWD=D:\source\gopath\src\rtc-api go "env"
"GOMOD", stderr: <<>>
2019/09/25 06:20:47 Info:2019/09/25 06:20:47 137.0135ms for GOROOT=C:\Go GOPATH=D:\source\gopath GO111MODULE= PWD=D:\source\gopath\src\rtc-api go "env"
"GOPATH", stderr: <<>>
2019/09/25 06:20:48 Info:2019/09/25 06:20:48 1.125939s for GOROOT=C:\Go GOPATH=D:\source\gopath GO111MODULE= PWD=D:\source\gopath\src\rtc-api go "list"
"-e" "-json" "-compiled=true" "-test=true" "-export=false" "-deps=true" "-find=false" "--" "D:\\source\\gopath\\src\\rtc-api\\cmd", stderr: <<>>
2019/09/25 06:20:48 Info:2019/09/25 06:20:48 go/packages.Load
        packages = 1
2019/09/25 06:20:48 Info:2019/09/25 06:20:48 go/packages.Load
        package = rtc-api/cmd
        files = [D:\source\gopath\src\rtc-api\cmd\compose.go D:\source\gopath\src\rtc-api\cmd\enum.go D:\source\gopath\src\rtc-api\cmd\env.go D:\source\gopath\src\rtc-api\cmd\file.go D:\source\gopath\src\rtc-api\cmd\flag.go D:\source\gopath\src\rtc-api\cmd\project.go D:\source\gopath\src\rtc-api\cmd\project_should.go D:\source\gopath\src\rtc-api\cmd\start.go D:\source\gopath\src\rtc-api\cmd\utils.go]
D:\source\gopath\src\rtc-api\cmd\project.go:32: expected '}', found 'type'

@stamblerre
I applied your configuration, but it doesn't seem to work, I found this on the Internet, and after a while, I will give you feedback.
"files.autoSave": "afterDelay",
    "go.goroot": "C:/Go",
    "go.gopath": "C:/Code/MyGoWorks",
    "go.useLanguageServer": true,
    "go.languageServerExperimentalFeatures": {
        "format": false,
        "autoComplete": true,
        "rename": true,
        "goToDefinition": true,
        "hover": true,
        "signatureHelp": true,
        "goToTypeDefinition": true,
        "goToImplementation": true,
        "documentSymbols": true,
        "workspaceSymbols": true,
        "findReferences": true,
        "diagnostics": false
    },
    "http.proxy": "http://<IP_ADDRESS>:1080",
    "[go]": {
        "editor.defaultFormatter": "ms-vscode.Go"
    },

reference:  https://fullstack.love/achieve/21

The problem still appears，Is this the log you expect to see?
gopls --rpc.trace -v check D:\source\gopath\src\rtc-api\cmd\env.go

2019/09/25 17:36:40 Info:2019/09/25 17:36:40 Build info
----------
golang.org/x/tools/gopls v0.1.7
<EMAIL_ADDRESS>h1:YwKf8t9h69++qCtVmc2q6fVuetFXmmu9LKoPMYLZid4=
<EMAIL_ADDRESS>h1:8gQV6CLnAEikrhgkHFbMAEhagSSnXWGV915qUMm9mrU=
<EMAIL_ADDRESS>h1:ER45Jz0UDQ3e6em1lwXVwuPf96lvyQogb7m+gEbsoPg=
<EMAIL_ADDRESS>h1:9zdDQZ7Thm29KFXgAX/+yaf3eVbP7djjWp/dXAppNCc=

Go info
-------
go version go1.12.5 windows/amd64

set GOARCH=amd64
set GOBIN=
set GOCACHE=C:\Users\Administrator\AppData\Local\go-build
set GOEXE=.exe
set GOFLAGS=
2019/09/25 17:36:40 Info:2019/09/25 17:36:40 392.0042ms for GOROOT=C:\Go GOPATH=D:\source\gopath GO111MODULE= PWD=D:\source\gopath\src\rtc-api go "list" "-m" "-json" "all", stderr: <<go list -m: not using modules
>>
2019/09/25 17:36:40 Info:2019/09/25 17:36:40 120.0346ms for GOROOT=C:\Go GOPATH=D:\source\gopath GO111MODULE= PWD=D:\source\gopath\src\rtc-api go "env"
"GOPATH", stderr: <<>>
2019/09/25 17:36:40 Info:2019/09/25 17:36:40 168.9979ms for GOROOT=C:\Go GOPATH=D:\source\gopath GO111MODULE= PWD=D:\source\gopath\src\rtc-api go "env"
"GOMOD", stderr: <<>>
2019/09/25 17:36:41 Info:2019/09/25 17:36:41 255.9945ms for GOROOT=C:\Go GOPATH=D:\source\gopath GO111MODULE= PWD=D:\source\gopath\src\rtc-api go "list" "-m" "-json" "all", stderr: <<go list -m: not using modules
>>
2019/09/25 17:36:41 Info:2019/09/25 17:36:41 136.999ms for GOROOT=C:\Go GOPATH=D:\source\gopath GO111MODULE= PWD=D:\source\gopath\src\rtc-api go "env" "GOPATH", stderr: <<>>
2019/09/25 17:36:43 Info:2019/09/25 17:36:43 2.6235343s for GOROOT=C:\Go GOPATH=D:\source\gopath GO111MODULE= PWD=D:\source\gopath\src\rtc-api go "list" "-e" "-json" "-compiled=true" "-test=true" "-export=false" "-deps=true" "-find=false" "--" "D:\\source\\gopath\\src\\rtc-api\\cmd", stderr: <<>>
2019/09/25 17:36:43 Info:2019/09/25 17:36:43 go/packages.Load
        packages = 1
2019/09/25 17:36:43 Info:2019/09/25 17:36:43 go/packages.Load
        package = rtc-api/cmd
        files = [D:\source\gopath\src\rtc-api\cmd\compose.go D:\source\gopath\src\rtc-api\cmd\enum.go D:\source\gopath\src\rtc-api\cmd\env.go D:\source\gopath\src\rtc-api\cmd\file.go D:\source\gopath\src\rtc-api\cmd\flag.go D:\source\gopath\src\rtc-api\cmd\project.go D:\source\gopath\src\rtc-api\cmd\start.go D:\source\gopath\src\rtc-api\cmd\utils.go]

It looks like you have disabled the formatting feature from gopls, so if you still see this issue it means it's not coming from gopls. Can you run gopls -v -rpc.trace format path/to/file.go?
To get full logs from gopls (and to confirm if gopls is doing the formatting), add the following to your settings:

Duplicate of https://github.com/golang/go/issues/34955

Let's move the discussion of this issue to https://github.com/golang/go/issues/34955, as I'm hoping to consolidate all of the error reports from users experiencing this issue. Please follow the suggestions in that issue.


Give useful error if Defender isn't enabled

If defender isn't enabled, we get a pretty nasty and confusing error (cimexception with code 0x800106ba). There should probably be a more useful error reporting here.

You could do that by checking DisableAntiSpyware value which is under the following registry key:
HKLM\SOFTWARE\Microsoft\Windows Defender
I'm using Win 7 SP1 x64 so not quite sure about x86 and Win 8, Win 8.1 and Win10 but I guess it's the same.
Then there's also DisableRealtimeMonitoring value under:
HKLM\SOFTWARE\Microsoft\Windows Defender\Real-Time Protection so I'm not sure if the off state also causes the error.

Good pointers, thanks for those!


Remove read numbers from read names for methylated FASTQs

The sarscov2/illumina/test_methylated fastq files had read names such as:
asdfasdf_R1 and asdfasdf_R2, which confused downstream tools which depend on reads from the same template molecule having the same name. Removed _R[12]$ from the end of each read name and recompressed these files.

Hi. These files are used in several modules:

biscuit/align
biscuit/biscuitblaster
bismark/align
bismark/coverage2cytosine
bismark/report
bismark/summary
bwameth/align

I don't want to bring their tests unintentionally. Could you check them and make a PR (or hijack https://github.com/nf-core/modules/pull/2656) if necessary ?

Hello @muffato, thanks so much for the review! I pulled down the modules repo, edited tests/config/test-data.config to point to my fork, and ran local tests (using Singularity) for all the modules you suggested. I updated the biscuit modules on https://github.com/nf-core/modules/pull/2656. All the others passed without hiccups, and I checked their test.yml files - they don't contain m5d hashes for the .bam files, so this makes sense.
I should note that bwameth/align didn't pass, but that was due to some weird Singularity mount error. I also checked the test.yml for bwameth/align and it also doesn't have hashes for .bam files, so should be no problem


nicovideo.jp issue

Checklist

[x] I'm reporting a broken site support
[x] I've verified that I'm running youtube-dl version 2021.06.06
[x] I've checked that all provided URLs are alive and playable in a browser
[x] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[x] I've searched the bugtracker for similar issues including closed ones

Verbose log

C:\Users\XXXXX>"C:\Users\XXXXX\Desktop\Video Tools\Youtube DL\youtube-dl.exe" --verbose  https://www.nicovideo.jp/watch/sm12134023
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['--verbose', 'https://www.nicovideo.jp/watch/sm12134023']
[debug] Encodings: locale cp1252, fs mbcs, out cp437, pref cp1252
[debug] youtube-dl version 2021.06.06
[debug] Python version 3.4.4 (CPython) - Windows-10-10.0.19041
[debug] exe versions: ffmpeg 4.4-full_build-www.gyan.dev, ffprobe 4.4-full_build-www.gyan.dev
[debug] Proxy map: {}
[niconico] sm12134023: Downloading webpage
[niconico] sm12134023: Downloading flv info
ERROR: Unable to find video URL; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpkqxnwl31\build\youtube_dl\extractor\niconico.py", line 291, in _real_extract
KeyError: 'smileInfo'
Traceback (most recent call last):
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpkqxnwl31\build\youtube_dl\extractor\niconico.py", line 291, in _real_extract
KeyError: 'smileInfo'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpkqxnwl31\build\youtube_dl\YoutubeDL.py", line 815, in wrapper
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpkqxnwl31\build\youtube_dl\YoutubeDL.py", line 836, in __extract_info
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpkqxnwl31\build\youtube_dl\extractor\common.py", line 534, in extract
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpkqxnwl31\build\youtube_dl\extractor\niconico.py", line 310, in _real_extract
youtube_dl.utils.ExtractorError: Unable to find video URL; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.

Description

Unable to download from the above website. Related bugs suggest problems with downloading speeds or requiring a login. Neither of those issues appear to be related to the problem I am having.

same issue here

same issue. different log.
a@c:~$ python3 youtube-dl -u "mylogin" -p "mypassword" "http://www.nicovideo.jp/watch/sm37944844" --verbose
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['-u', 'PRIVATE', '-p', 'PRIVATE', 'http://www.nicovideo.jp/watch/sm37944844', '--verbose']
[debug] Encodings: locale UTF-8, fs utf-8, out utf-8, pref UTF-8
[debug] youtube-dl version 2021.06.06
[debug] Python version 3.8.5 (CPython) - Linux-5.10.0-1029-oem-x86_64-with-glibc2.29
[debug] exe versions: ffmpeg 4.2.4, ffprobe 4.2.4, rtmpdump 2.4
[debug] Proxy map: {}
[niconico] Logging in
[niconico] sm37944844: Downloading webpage
[niconico] sm37944844: Downloading flv info
ERROR: Unable to find video URL; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
  File "youtube-dl/youtube_dl/extractor/niconico.py", line 291, in _real_extract
    video_real_url = api_data['video']['smileInfo']['url']
KeyError: 'smileInfo'
Traceback (most recent call last):
  File "youtube-dl/youtube_dl/extractor/niconico.py", line 291, in _real_extract
    video_real_url = api_data['video']['smileInfo']['url']
KeyError: 'smileInfo'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "youtube-dl/youtube_dl/YoutubeDL.py", line 815, in wrapper
    return func(self, *args, **kwargs)
  File "youtube-dl/youtube_dl/YoutubeDL.py", line 836, in __extract_info
    ie_result = ie.extract(url)
  File "youtube-dl/youtube_dl/extractor/common.py", line 534, in extract
    ie_result = self._real_extract(url)
  File "youtube-dl/youtube_dl/extractor/niconico.py", line 310, in _real_extract
    raise ExtractorError('Unable to find video URL')
youtube_dl.utils.ExtractorError: Unable to find video URL; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.

It seems that the API has changed – the smileInfo key no longer exists, and in fact, no flat-out URL appears at all in the API response… Could it be that the video URL is nowadays being derived from this part somehow?
'urls': [{'isSsl': True,
        'isWellKnownPort': True,
        'url': 'https://api.dmc.nico/api/sessions'}],
'videos': ['archive_h264_360p',
            'archive_h264_360p_low'],

That's in api_data['media']['delivery']['movie']['session'].

I've figured the issue out – apparently, Niconico have been recombobulating their API quite a bit lately, including switching from snake case to camel case. Here's a diff patch that makes videos of this type work:
@@ -195,7 +195,7 @@
         def yesno(boolean):
             return 'yes' if boolean else 'no'

-        session_api_data = api_data['video']['dmcInfo']['session_api']
+        session_api_data = api_data['media']['delivery']['movie']['session']
         session_api_endpoint = session_api_data['urls'][0]

         format_id = '-'.join(map(lambda s: remove_start(s['id'], 'archive_'), [video_quality, audio_quality]))
@@ -208,15 +208,15 @@
             data=json.dumps({
                 'session': {
                     'client_info': {
-                        'player_id': session_api_data['player_id'],
+                        'player_id': session_api_data['playerId'],
                     },
                     'content_auth': {
-                        'auth_type': session_api_data['auth_types'][session_api_data['protocols'][0]],
-                        'content_key_timeout': session_api_data['content_key_timeout'],
+                        'auth_type': session_api_data['authTypes'][session_api_data['protocols'][0]],
+                        'content_key_timeout': session_api_data['contentKeyTimeout'],
                         'service_id': 'nicovideo',
-                        'service_user_id': session_api_data['service_user_id']
+                        'service_user_id': session_api_data['serviceUserId']
                     },
-                    'content_id': session_api_data['content_id'],
+                    'content_id': session_api_data['contentId'],
                     'content_src_id_sets': [{
                         'content_src_ids': [{
                             'src_id_to_mux': {
@@ -229,7 +229,7 @@
                     'content_uri': '',
                     'keep_method': {
                         'heartbeat': {
-                            'lifetime': session_api_data['heartbeat_lifetime']
+                            'lifetime': session_api_data['heartbeatLifetime']
                         }
                     },
                     'priority': session_api_data['priority'],
@@ -239,14 +239,14 @@
                             'http_parameters': {
                                 'parameters': {
                                     'http_output_download_parameters': {
-                                        'use_ssl': yesno(session_api_endpoint['is_ssl']),
-                                        'use_well_known_port': yesno(session_api_endpoint['is_well_known_port']),
+                                        'use_ssl': yesno(session_api_endpoint['isSsl']),
+                                        'use_well_known_port': yesno(session_api_endpoint['isWellKnownPort']),
                                     }
                                 }
                             }
                         }
                     },
-                    'recipe_id': session_api_data['recipe_id'],
+                    'recipe_id': session_api_data['recipeId'],
                     'session_operation_auth': {
                         'session_operation_auth_by_signature': {
                             'signature': session_api_data['signature'],
@@ -288,7 +288,8 @@
             return 'economy' if video_real_url.endswith('low') else 'normal'

         try:
-            video_real_url = api_data['video']['smileInfo']['url']
+            # video_real_url = api_data['video']['smileInfo']['url']
+            video_real_url = None
         except KeyError:  # Flash videos
             # Get flv info
             flv_info_webpage = self._download_webpage(
@@ -335,12 +336,11 @@
         else:
             formats = []

-            dmc_info = api_data['video'].get('dmcInfo')
+            dmc_info = api_data['media']['delivery']['movie']
             if dmc_info:  # "New" HTML5 videos
-                quality_info = dmc_info['quality']
-                for audio_quality in quality_info['audios']:
-                    for video_quality in quality_info['videos']:
-                        if not audio_quality['available'] or not video_quality['available']:
+                for audio_quality in dmc_info['audios']:
+                    for video_quality in dmc_info['videos']:
+                        if not audio_quality['isAvailable'] or not video_quality['isAvailable']:
                             continue
                         formats.append(self._extract_format_for_quality(
                             api_data, video_id, audio_quality, video_quality))

I'm hesitant to make a pull request – as it stands, this almost certainly ruins the ability to download other types of videos (like FLV videos, for example). I'll leave the formal fix to someone who's more familiar with Niconico's inner workings. (Does the FLV video endpoint even still work? Does the “old HTML5 video” method still exist? From what I can tell in the API, it might be the case that the DMC approach is the only one at this point, although I may very well be wrong about that.) Here's the fix, either way!

I'm 99.9% sure that FLV videos at least are entirely dead. 10+ year old videos are served as video/MP2T now when they were certainly flv at the time (this also goes for swf videos, which used to be interactive and now are not). I'd take most videos working over none, in any case, so I'll use this patch for now - thanks!

Thanks for the patch! Required a bit more fixing though.
See here https://github.com/no1d/youtube-dl/commit/e493896925f99c5781f5e490ecec109a46213869

Also getting this issue.
C:\Users\Jorge>ytdl -f best "https://www.nicovideo.jp/watch/sm36773221" -o "C:\Users\Jorge\Desktop\%(title)s.%(ext)s" --verbose
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['-f', 'best', 'https://www.nicovideo.jp/watch/sm36773221', '-o', 'C:\\Users\\Jorge\\Desktop\\%(title)s.%(ext)s', '--verbose']
[debug] Encodings: locale cp1252, fs mbcs, out cp437, pref cp1252
[debug] youtube-dl version 2021.06.06
[debug] Python version 3.4.4 (CPython) - Windows-10-10.0.19041
[debug] exe versions: ffmpeg 4.2
[debug] Proxy map: {}
[niconico] sm36773221: Downloading webpage
[niconico] sm36773221: Downloading flv info
ERROR: Unable to find video URL; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpkqxnwl31\build\youtube_dl\extractor\niconico.py", line 291, in _real_extract
KeyError: 'smileInfo'
Traceback (most recent call last):
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpkqxnwl31\build\youtube_dl\extractor\niconico.py", line 291, in _real_extract
KeyError: 'smileInfo'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpkqxnwl31\build\youtube_dl\YoutubeDL.py", line 815, in wrapper
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpkqxnwl31\build\youtube_dl\YoutubeDL.py", line 836, in __extract_info
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpkqxnwl31\build\youtube_dl\extractor\common.py", line 534, in extract
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpkqxnwl31\build\youtube_dl\extractor\niconico.py", line 310, in _real_extract
youtube_dl.utils.ExtractorError: Unable to find video URL; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.```

Same error here

For downloading nicovideo.jp, I recommend using one of the following alternatives (this list is copied from my another abandoned project readme file):

yt-dlp, which contains tsukumijima's niconico fix
nndownload, a python command line downloader for niconico only
nao20010128nao's yt-dlp fork
animelover1984's youtube-dl

Same with me. This was my go to method of downloading Nico vids and now I can no longer do so.


fix typos in config file

Hi @jinw960 ,
Thanks for your great contribution. Could you following the doc to reformat the code?
We would also appreciate it if you could add readme in the configs that describe the performance of the implementation.

Maybe @jinw960 accidently raised this PR and it will be closed. If not, please feel free to open another PR.

Hi @hello-jinwoo！We are grateful for your efforts in helping improve this open-source project during your personal time.
Welcome to join OpenMMLab Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us ：https://discord.gg/UjgXkPWNqA
If you have a WeChat account，welcome to join our community on WeChat. You can add our assistant ：openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends：）
Thank you again for your contribution❤ @hello-jinwoo


AAU, on the CLI, when I go on the doc website, I see that I can download a zip file with basic ressources to launch all commands on the getting started

we won't publish that in the python-sdk, but directly in the doc. We will see the proper way to do it with @theodu

https://github.com/kili-technology/kili-python-sdk/pull/629 should be merged before as the documentation has been written as if it was already merged.


Use DeleteOnMetadataMatch instead of Delete for endpointUpdated

Node restart may lead to ip addresses 'swap' for services.
In such case using ipcache.Delete may lead to deleting newly assigned ip address of other service.
Fixes: #19958
Signed-off-by: Viktor Kuzmin<EMAIL_ADDRESS>

It seems that my PR doesn't fix all the cases. Got one more case after intensive testing:
level=debug msg="Upserting IP into ipcache layer" identity="{34037 custom-resource false}" ipAddr=<IP_ADDRESS> k8sNamespace=kube-system k8sPodName=oauth2-proxy-8554548984-lh2jp key=0 namedPorts="map[http:{4180 6} metrics:{44180 6}]" subsys=ipcache
level=debug msg="Daemon notified of IP-Identity cache state change" identity="{34037 custom-resource false}" ipAddr="{<IP_ADDRESS> ffffffff}" modification=Upsert subsys=datapath-ipcache
...
level=debug msg="Upserting IP into ipcache layer" identity="{21190 custom-resource false}" ipAddr=<IP_ADDRESS> k8sNamespace=seaweedfs k8sPodName=seaweedfs-volume-0 key=0 namedPorts="map[volume-grpc:{18444 6} volume-http:{8444 6}]" subsys=ipcache
level=debug msg="Daemon notified of IP-Identity cache state change" identity="{21190 custom-resource false}" ipAddr="{<IP_ADDRESS> ffffffff}" modification=Upsert subsys=datapath-ipcache
...
level=info msg="!!! updateFunc" newIp=<IP_ADDRESS> newName=seaweedfs-volume-0 oldIp=<IP_ADDRESS> oldName=seaweedfs-volume-0 subsys=k8s-watcher
...
level=debug msg="Deleting IP from ipcache layer" ipAddr=<IP_ADDRESS> subsys=ipcache
level=debug msg="Daemon notified of IP-Identity cache state change" identity="{21190 custom-resource false}" ipAddr="{<IP_ADDRESS> ffffffff}" modification=Delete subsys=datapath-ipcache
level=debug msg="Kubernetes service definition changed" action=service-updated endpoints="<IP_ADDRESS>:4180/TCP,<IP_ADDRESS>:44180/TCP" k8sNamespace=kube-system k8sSvcName=oauth2-proxy old-service=nil service="frontends:[<IP_ADDRESS>]/ports=[http metrics]/selector=map[app.kubernetes.io/instance:oauth2-proxy app.kubernetes.io/name:oauth2-proxy]" subsys=k8s-watcher

After node restart pods are reinitializing and each pod may have new ip address. In this case:

oauth2-proxy got it new ip - <IP_ADDRESS>
seaweedfs-volume-0 added to ipcache with it's old ip - <IP_ADDRESS> and replaced oauth2-proxy entry
seaweedfs-volume-0 ip is updated from <IP_ADDRESS> to <IP_ADDRESS> - entry for <IP_ADDRESS> is completly deleted

Rebased PR to latest master and now I'm not able to reproduce the problem (PR is still needed). I think if it may be related to the following commit: https://github.com/cilium/cilium/commit/b629e59315c3871e66739a9777c1e0ea97bafd88

/test

I think this code change is likely correct, independent of any other thoughts. I attempted to add a release note into the PR summary to help advertize the bugfix in the upcoming releases that would include this change.
At the same time I'm a bit confused about how k8s ends up reusing the same IP for two different pods due to a Node restart. Reusing IP addresses without appropriate grace periods can lead to weird behaviour in general, as all nodes need to discover that the IP was released from a specific identity/pod and will be reallocated to something with a potentially different security posture / security identity. I'm not sure I fully understand the complete flow of events here and whether we could be doing something additional during those earlier steps (potentially in addition to this code change).

@joestringer, restart takes 2 minutes on real hardware. After node restart old IPs are automatically assigned to pods and after that all pods gets 'Unknown' status and their ip are reassigned... It's strange behaviour for me aswell... I'm sure my change are ok anyway, but I'm not sure that theese changes will really solve the root of the problem. Once I was able to see following events on node restart:

pod A is assigned new ip
event for pod B with its old ip which is equal to new ip of pod A
pod B reassigned with new ip

It seems that kubelet restart is enough to trigger the problem. I've reproduced the problem in test vm cluster on kubernetes upgrade to 1.24.1 (cilium was with current PR applied).


Fix 175 : As a user, I want to be able to save a label

When confirm button is clicked, sends a request to backend to save form and gives feedback to user if an error occured or if the label has been saved successfully.
If the label has been saved, the user is sent back to the capture page.
Warning
This does not work with the backend main
It does work with the branch 119-CORS

Waiting for ai-cfia/fertiscan-backend#119


[WIP]backend/fix: floor-price-logical-error

NOTE TO SELF :
in the scope of getCollectionByChain endpoint, wrong floor price is returned

NOTE TO SELF : in the scope of getCollectionByChain endpoint, wrong floor price is returned

Fixed


Feature request: isotopic multiplexing

Hello,
I am using DIA-NN to process multiplexed samples using dimethyl labeling. I would like to request a feature where your program can be used to derive the protein intensities for each of the channels within a sample. Please let me know if you need an example of this.
Best,
Ronnie

Hi Ronnie,
thanks for your comment. Please feel free to check out our RefQuant package: https://github.com/MannLabs/refquant
It is designed to do exactly what you describe. There is no GUI for it, but there are example notebooks that you can follow.
Best
Constantin

Right, I was aware of that. But does it produce directLFQ for quantification?

Yes, the .protein_intensities.tsv table is directLFQ quantified

This is great! Thanks!
Get Outlook for iOShttps://aka.ms/o0ukef

From: ammarcsj @.>
Sent: Tuesday, November 19, 2024 11:44:49 AM
To: MannLabs/directlfq @.>
Cc: Ronald Cutler @.>; Author @.>
Subject: Re: [MannLabs/directlfq] Feature request: isotopic multiplexing (Issue #55)
CAUTION: This email comes from an external source; the attachments and/or links may compromise our secure environment. Do not open or click on suspicious emails. Please click on the “Phish Alert” button on the top right of the Outlook dashboard to report any suspicious emails.
Yes, the .protein_intensities.tsv table is directLFQ quantified
—
Reply to this email directly, view it on GitHubhttps://github.com/MannLabs/directlfq/issues/55#issuecomment-2486227308, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AUCDKM4RTHDXBIIUYYVGSVT2BNTIDAVCNFSM6AAAAABSCOOZLWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOBWGIZDOMZQHA.
You are receiving this because you authored the thread.Message ID: @.***>


Tar extraction - Confirm wether this is an issue or not

SD-749, originally created on 4/4/2006 04:54:45 by John Reilly
Hi , I am using SharZipLib for tar archive managment and I get a
problem:
When I list the content of my archive ( in order to know how many item
it contains ), the  ExtractContents method don't extract anythings.
For example , With this code, nothing is extract :
            m_tarArchive = TarArchive.CreateInputTarArchive( tarStream
);

            m_tarItemCount = 0;
            ProgressMessageHandler countHandler = new
ProgressMessageHandler( CountTarEntry );
            ProgressMessageHandler notifyHandler = new
ProgressMessageHandler( NotifiTarExtract );
            m_tarArchive.ProgressMessageEvent += countHandler;
            m_tarArchive.ListContents();
            m_tarArchive.ProgressMessageEvent -= countHandler;
            m_tarArchive.ProgressMessageEvent += notifyHandler;

            m_tarArchive.ExtractContents( restoreBaseDirectory );
            m_tarArchive.CloseArchive();
If I comment the m_tarArchive.ListContents(); line,  archive content is
extract in restoreBaseDirectory.
Any ideas?
Thanks,
Nicolas

Closing this due to inactivity and age.


Add background filler color

Better yet,
add_image_border(x, y, color, image)

Merge cancelled. New function will be added instead.


chore: fix quick start link in the main README.md file

Problem
When trying to visit the "quick start" guide I saw the next:

Solution
Either put the correct link or create the page for https://docs.waku.org/guides/js-waku/quick-start.
In this PR I'm just adding a link that I think is correct, but not sure :D

Anyone who agrees with the change, please merge it directly.
I can't myself snif snif:


Implement event models

See issue #1

Validation must be added as part of the event creation task.

TODO: Create base tests for models


Create CODEOWNERS

Description

Release required?

[ ] No release
[ ] Patch release (x.x.X)
[ ] Minor release (x.X.x)
[ ] Major release (X.x.x)

Release notes content

Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
/run pipeline

Checklist for reviewers

[ ] If relevant, a test for the change is included or updated with this PR.
[ ] If relevant, documentation for the change is included or updated with this PR.

For mergers

Use a conventional commit message to set the release level. Follow the guidelines.
Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
Use the Squash and merge option.

@Roavill2 @mjamasri We are rolling out codeowners to all repos, please let me know if I should add someone different?

@Roavill2 @mjamasri We are rolling out codeowners to all repos, please let me know if I should add someone different?

Please add @kevinkuhner as a code owner and he can add others as needed.

/run pipeline

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


retain chart state when refreshed

when the refresh button is clicked the chart displays success percent for all the data and not based on the applied protocol filters
fix bug, include/exclude do not display all publicIDs when filters are applied and refresh button is clicked

This is currently not being worked on


Fake type checking - use argument name substitution

Instead of providing full type checking, one could do a different kind of type checking that is closer to faking it entirely, using argument name substitution. This means that instead of types, one associates an argument name with a variable which is used to append _<type> when calling a function, if there is no specified argument name. If there are no argument names and the function is not found, then it uses the short name.
Example:
c := [1; 4]
r := [0, 0, 100, 100]
draw(color: c, rectangle: r)

In Dyon, draw(color: c, rectangle: r) is the same as draw_color_rectangle(c, r). With fake type checking, using argument name substitution, the above can be written as:
c: color = [1; 4]
r: rectangle = [0, 0, 100, 100]
draw(c, r)

A function can return a type:
fn blue() -> color {
    return [0, 0, 1, 1]
}

fn center(x, y, rad) -> rectangle {
    return [x - rad, y - rad, 2 * rad, 2 * rad]
}

c := blue() // Assigned the `color` type
r := center(100, 100, 5) // Assigned the `rectangle` type
draw(c, r)

Alternative:
draw(blue(), center(100, 100, 5))

A function can declare types for argument, but these are not used when calling the function. Therefore, to fake type checking both inside and outside, one must write the type of the argument twice:
fn add_f64_f64(a: f64, b: f64) -> f64 { return a + b }

a: f64 = 0
b: f64 = 2
c := add(a, b)

Closed in favor of https://github.com/PistonDevelopers/dyon/issues/80


Disable UUID check on xfs

Add nouuid mount option when mounting xfs to disable checks of filesystem UUIDs. This allows a xfs volume and its clone (or restored snapshot) to be mounted on the same node - they will have the same UUID, yet they're separate volumes.

coverage: 83.303% (+0.001%) from 83.302% when pulling 8229698a04269695acd62f1d209a95dc9edf7c38 on jsafrane:fix-xfs into decb9df4873fbc815bde3e77455d24145b886d78 on kubernetes-sigs:master.

/check-cla

/test all

/test EasyCLA

@arahamad @ambiknai, PTAL.  A similar fix was implemented in other CSI drivers, e.g. AWS EBS or GCP PD.

@arahamad @ambiknai, PTAL. A similar fix was implemented in other CSI drivers, e.g. AWS EBS or GCP PD.

Hi @jsafrane
Thank you  for the PR !! We will go through and come back.

@arahamad can you please take a look again?

@arahamad, @ambiknai @spzala @bradtopol can you please take a look?

@arahamad, @ambiknai @spzala @bradtopol can you please take a look?

@jsafrane , changes looks fine, although block storage has device ID as well but we are always mounting with device path to it looks good.
I know this will work, Just to make sure this flag always work across supported OS on IKS cluster, @ambiknai can you please help to verify these changes on our supported cluster versions.

@jsafrane  @arahamad   I will have the results ready by tomorrow.


Prepare release 2.8.0

What does this PR do?
This PR prepares release 2.8.0.
Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] Make sure you discussed the feature or bugfix with the maintaining team in an Issue
[ ] Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

Codecov Report

Merging #1971 (2ec68a5) into release/2.8.0 (0706c32) will decrease coverage by 0.16%.
The diff coverage is n/a.

Additional details and impacted files
@@                Coverage Diff                @@
##           release/2.8.0    #1971      +/-   ##
=================================================
- Coverage          83.58%   83.42%   -0.16%
=================================================
  Files                489      489
  Lines              17932    17931       -1
  Branches            2671     2671
=================================================
- Hits               14987    14958      -29
- Misses              2226     2236      +10
- Partials             719      737      +18

see 22 files with indirect coverage changes


Delay when clicking on page magnification button

Description of the bug
When I click on the page magnification button on my record list (both the modal and full screen variants), there is a bit of a delay before the modal opens up.
I’m not sure why that is, but my guess is that we’re loading the content before we open the modal. If that’s the case, this might throw people off (especially on slower connections).
Reproduction steps

Make a record list magnifyable (as a modal)
Magnify the record list

Expected behavior
The modal should open immediately, or there should be some indication that it’s processing.
Version
Branch: 2023.3.0-dev.5.1
Reporter: Tomaz (Test fest)
Browser: Firefox
Note:
This needs to be investigated

@tjerman I retested this and I don't think that I am able to reproduce this. Magnifying a record list or any other block works pretty fast for me. Can you confirm if we can close this ticket?
379285a8-99e8-494c-9ffc-5586924ec768.webm

Can you test on something with more data in it? Perhaps try rate limiting your network to a slower connection (can do this in the dev tools)

8a28bb2d-cf2f-4933-a7a6-5f49a909a82f.webm
bfc6507a-0577-4c01-a490-e8ae34b35dbc.webm
On fast internet even if I have more data everything opens as it should, and on slow network while the content is loading I see a loading spinner indicating that something is loading up, so I think we are good with this one.
What do you think @tjerman ?

@tjerman Ping

The issue has already been resolved


Move files from temporary directory changer

What is the change?
Use shutil.move / mv instead of shutil.copy / cp to move files from temporary directory back to the original working directory on __exit__.
Why is the change being made?
Copying files from one location to another keeps the original file intact, but the original files in a temporary directory do not need to be kept around after the __exit__ from the TemporaryDirectoryChanger. These files are immediately deleted after the copy operation is completed.
Using shutil.move() is significantly faster than shutil.copy() when the source and destination locations are on the same drive, since the data doesn't have to physically be copied to a new place in memory.

Checklist

[x] This PR has only one purpose or idea.
[x] Tests have been added/updated to verify any new/changed code.

[x] The code style follows good practices.
[x] The commit message(s) follow good practices.

[x] The release notes have been updated if necessary.
[x] The documentation is still up-to-date in the doc folder.
[x] The dependencies are still up-to-date in pyproject.toml.

I didn't touch safeCopy at all, but I added some assert statements to verify that the safeCopy call is actually copying the files. The unit test for safeCopy passes locally for me, but here it is now failing on those assertions, which is strange.
It's also weird that the existing unit test of safeCopy doesn't actually assert that the files are copied successfully. Makes me wonder if there is a known issue here.

The secret overwriting of shutil.copy is something I want to remove from ARMI

I note we already have a ticket for this: #1690
But I think Michael's PR doesn't touch that, because he didn't alter safeCopy(), but added a new saveMove(). Am I wrong?

Yep! the first iteration in this PR had a similar setup, (where shutil.move was overwritten with safeMove) but that was undone in favor of not overwriting shutil.move.


Add Neon-Dark & Neon-Palenight Themes

Add two new themes for the github-readme-streak-stats
Hi, I designed two new version of theme for the github-readme-streak-stats. One is neon-dark and another one is neon-palenight.

Neon Dark ( neon-dark )
Theme Colors :
"neon-dark" => [
    "background" => "#020200"
    "border" => "#a8a8a8"
    "stroke" => "#a8a8a8"
    "ring" => "#e41d44"
    "fire" => "#e41d44"
    "currStreakNum" => "#f9dd3c"
    "currStreakLabel" => "#f9dd3c"
    "sideNums" => "#5cadc0"
    "sideLabels" => "#5cadc0"
    "dates" => "#ed7b25"
]

Neon Palenight ( neon-palenight )
Theme Colors :
"neon-dark" => [
    "background" => "#212237"
    "border" => "#a8a8a8"
    "stroke" => "#a8a8a8"
    "ring" => "#e41d44"
    "fire" => "#e41d44"
    "currStreakNum" => "#f9dd3c"
    "currStreakLabel" => "#f9dd3c"
    "sideNums" => "#5cadc0"
    "sideLabels" => "#5cadc0"
    "dates" => "#ed7b25"
]

I hope you liked these two themes. Thank You :pray:

Hi @vikasganiga05! These themes look awesome!
Do you plan on making the PR to add them?

Hi @vikasganiga05! These themes look awesome!
Do you plan on making the PR to add them?

Yeah sure, I like to work on this :slightly_smiling_face: . Assign it to me.


None-check for packages_file

auto-formatted code
removed unused import
check packages_file for None

Thanks @elsamuko, looking good :+1:


Add an option to just copy latest backup

So I'd like to have just the most recent complete backup of my (now dead) Mac on my Linux box.  If I run this script, I'll be copying a mostly-full 2TB drive onto my 1TB drive, which doesn't really work (I tried).  And anyway, I don't need a second copy of the full history; it's what the backup drive is for.

I might try taking a look at this this weekend since I've got a few old Time Machine backups I'd like data from.

Hm, I don't have access to a Mac Time Machine backup atm to reproduce, but I think this is already feasible. From the README:

where $source is the mount point (i.e. not e.g. /dev/sdb2) of the Time Machine Volume and the proper directory (e.g. could be "Latest"

So, if the first parameter (aka "$source") not only points to the mount of the backup but also to the directory (by suffixing /Latest) you should only get the (complete) latest backup.

I tried this and a lot of the main folders in my home directory (desktop and documents, etc) were empty. I am re-running this with the source set to just Backups.backupdb to see if it fixes it.

Thx @GreenJon902 for trying this out. Have you had success? Also, I don't know, but maybe the latest backup of yours was somehow faulty - you could try out an other backup (not "latest" but something with a datestamp on it)?

@dr0i
I set it to copy all of the backups so it is still running. Of ones has done, it looks like the folders are still empty.
From what I can tell so far, it creates the folders from the special files but then doesn't fill them. I saw you mentioned that it needs to be able to re-run the original script, could this be a permissions issue where it only re-runs it for the special folder file things but can't which is why the folders aren't filled?
When it is finished then I'll check the folders again to see if the '/latest' was the issue. If it takes much longer or you think that won't help then I can stop it and try using the date as you suggested.

I have stopped it because it was going to take a lot longer.
I have started a new one with the source set to mountpoint/2022-02-23-230344/Macintosh HD - Data. So far it has copied the system wide applications folder which was a special folder and has turned it into an actual folder and started filling its contents, fingers crossed it will do the same for special folders in my user directory and elsewhere on the drive!

@dr0i I believe I have discovered a fix, I think i needed to run the script with sudo as it didn't have permissions to some files on the time machine backup file (some had a red circled X on the icons and the script sometimes outputted permission denied). I ran this just for my user folder and it has started filling Desktop and Documents which it didn't do before, meaning

So, if the first parameter (aka "$source") not only points to the mount of the backup but also to the directory (by suffixing /Latest) you should only get the (complete) latest backup.

probably works! I will test this and get back to you.

@GreenJon902 great that it works for you - and no problem for not following the README correctly. Your comments here may well help others who experiences the same problems.
Closing.


alt tag support for product images to improve accessibility

Greetings medusa team and contributors,
As of now Admin portal doesn't seem to support setting the alt description for the product images.
Alt tags are very important for visually impaired users to understand the images shown in their screen through various screen reading tools.
Currently the alt tags are set "Product #N" in the storefront with N being the index of the product images.
I feel the alt tag input can be added to the dialog where the images are uploaded.

@abishekmuthian - This project has entered maintenance mode. We are moving feature requests to GitHub Discussions to track the most requested features (using the upvote mechanism) and streamline GitHub Issues around bugs. Could I ask you to re-open your request here: https://github.com/medusajs/medusa/discussions/categories/feature-requests
Thanks!


Error when installing

I'm trying to install on a raspberry pi zero 2 w running raspbian bookworm and i get this error:
Package gpac is not available, but is referred to by another package.
This may mean that the package is missing, has been obsoleted, or
is only available from another source

E: Package 'gpac' has no installation candidate

i looked everywhere online but havent found a way to install gpac.
and yes i ran apt upgrade etc multiple times :D
i'm going to try to build it myself now but this shouldn't be the way to install imho.
I would be happy to hear if this is an issue for others aswell or if i missed something obvious.
regards ;)

I came across this recently too, and went down a rabbit hole trying to resolve it.
Basically the gpac packages have not yet been made available in Raspberry Pi Bookworm.
The only solution for now is to use Bullseye until Raspberry Pi foundation adds the packages.
I'll try find the reference for this,

I have read from several people that Bookworm is not ready for prime-time.
Lot’s of problems to work out.
On Thu, Nov 30, 2023 at 9:13 PM James @.***> wrote:

I came across this recently too, and went down a rabbit hole trying to
resolve it.
Basically the gpac packages have not yet been made available in Raspberry
Pi Bookworm.
The only solution for now is to use Bullseye until Raspberry Pi foundation
adds the packages.
I'll try find the reference for this,
—
Reply to this email directly, view it on GitHub
https://github.com/silvanmelchior/RPi_Cam_Web_Interface/issues/689#issuecomment-1835311335,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADJTLWW5FYJVYYLS7QB7B63YHE4LJAVCNFSM6AAAAABACCG32OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZVGMYTCMZTGU
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***
com>

any updates here, same issue:
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
Note, selecting 'php7.0-thrift' for regex 'php7.0'
Note, selecting 'php7.0-common' for regex 'php7.0'
Note, selecting 'php7.0-curl' for regex 'php7.0'
Package gpac is not available, but is referred to by another package.
This may mean that the package is missing, has been obsoleted, or
is only available from another source

E: Unable to locate package php7.0-cli
E: Couldn't find any package by glob 'php7.0-cli'
E: Couldn't find any package by regex 'php7.0-cli'
E: Unable to locate package libapache2-mod-php7.0
E: Couldn't find any package by glob 'libapache2-mod-php7.0'
E: Couldn't find any package by regex 'libapache2-mod-php7.0'
E: Package 'gpac' has no installation candidate

I come from:
https://www.remote.it/resources/10-minute-secure-webcam-with-raspberrypi-and-remote-it
Kind regards

First this is probably because you have a later version of php. If you have used bookworm for example php version 8.2 is installed by default. You can check by running php -v  in the command window.
You can specify the php version when the install script runs.
The install script tries to figure out which php version to run but hasn't been updated for bookworm. I'll check that out.

I've tried to rebuild from this
https://github.com/gpac/gpac/wiki/GPAC-Build-Guide-for-Linux
Also, remove the 'gpac' from shell command 'apt-get' in 'install.sh', which I believe actually caused this issue.

I am having this same issue. Apache is installed and running on port 80; Node-Red is installed and running on port 1880; PHP 8.2 is installed and running. But I still get "gpac has no installation candidate". I've ran updates and such.

When will this issue be solved? Whole RPi Webcam isnt usable, which is sad.

just use legacy OS (RPi OS "Bullseye" i think). thats how i got it running. i don't know if this is gonna be fixed soon.
we shouldn't be so demanding of open source devs. most of them do this in their free time after all.

just use legacy OS (RPi OS "Bullseye" i think). thats how i got it running. i don't know if this is gonna be fixed soon.
we shouldn't be so demanding of open source devs. most of them do this in their free time after all.

You're so right

I'm not making any demands; I'm simply outlining the current situation. What adjustments are necessary to ensure compatibility with the latest Raspberry Pi OS (Bookworm)?

https://github.com/silvanmelchior/RPi_Cam_Web_Interface/issues/688

Hi @05k4rausdertonne and others, you might be interested in this. Be aware that not all functionality has been implemented but it should be a good starting point ^_^


Warning when loading extension

Behaviour
Expected Behavior

Warning messages must not be required
Actual Behavior
<!-- What actually happened? —>
2024-08-08 21:00:58.923 [warning] [mypy-type-checker]: Couldn't find message for key settings.cwd.description.
2024-08-08 21:00:58.923 [warning] [mypy-type-checker]: Couldn't find message for key settings.ignorePatterns.description.

## Reproduction Steps:
<!-- How can we reproduce the bug? Please be as detailed as possible so we can help with your bug faster! —>
Install inside devcontainer, and watch on the output / server

Thanks for the bug report, but unfortunately, we need some more information from you in order to triage this issue appropriately. Please follow the bug template to create a new bug with all the critical details we need for diagnosis.
Please include logs and any screenshots that might help.


Bluetooth: CSIP: Handle disconnects while in procedure

If a device disconnects while we are in a procedure then get_next_active_instance would return a service instance pointer with the conn set to NULL.
The issue was caused by the set_info being potentially memset
when the device that disconnected was the one that held the
set_info pointer.
The solution is to not use a pointer, but rather a copy of the
set_info, so that the active.set_info value is still valid
after a disconnect.
Since the set_info is not longer a pointer to a specific
set_info from one of the members, the logs have been updated
as well, as the pointer of the active.set_info is useless
for debugging.
fixes https://github.com/zephyrproject-rtos/zephyr/issues/80747

Refactored the solution. Found the root cause thanks to @pin-zephyr pointing out that this quick fix didn't solve it properly.
Please re-review :)


Add social-media/content-search profile with Twitter map

Description

This PR adds social-media/content-search profile with SearchByHashtag and SearchByMentions use-cases. PR adds also maps for  mock and twitter providers.
Motivation and Context

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have read the CONTRIBUTING document.
[x] I haven't repeated the code. (DRY)
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

"Lookup" instead of search implies that you have better idea what you are looking for, while search is rather more general. But I welcome any other suggestions.

I understand your concerns, Lookup sounds much more appropriate in this case.

I think we don't have any use-case for fetching the profile ID from username in case of Twitter; IMO the SearchByMentions could accept username as an alternative to profileId? (can be extended later)

Right we do not have it. username seems to be appropriate naming as even Facebook requires to create username for Facebook page to be able to mention it.

@jnv I changed the name of profile and use-cases as you proposed. 🙏


[#102] Fix zsh plugin and arguments with whitespaces

Broken https://travis-ci.org/ezh/shpec/builds/217703619
Fixed https://travis-ci.org/ezh/shpec/jobs/217730218

@ezh I'm having a lot understanding what's going on here, and I'm going to need clarification before I consider merging this. A few notes:

If the multiple-argument issues are separate from #102, please address those in a separate PR; having that work here makes both solutions harder to understand.
The more zsh-specific logic that we can put in the plugin itself, the better. shpec is meant to be POSIX-compliant, and we should not be bending over backwards special-casing non-standard shells' behavior.
The .travis.yml was bad before, but it's getting out of control; we need to figure out how better to organize our build.
Given the choice between:
a. Explaining the code in the commit message
b. Explaining the code in a comment
c. Not explaining the code
I am always going to prefer a.

You may do as you wish.
Since I have near broken shpec under zsh, I just fix it.
I showed errors in https://travis-ci.org/ezh/shpec/builds/217703619
Could you please merge it to separate branch and relayout them as you think is correct? Since the commits is very little
I prefer not to use telepathy.
I have concern about your point:
If I make PR with better travis.yml, then CI build will be broken. Will you merge broken code to master?
Would 1. is separate from issue? I don't think so - #102 that arguments in zsh is broken. As side effect we know right now that it is broken everywhere.
I suspect that copy'n'paste of working solution between files is relatively easy job.
The only blocker is 2: move zsh specific code to plugin (minute or two of work - cut text from bin/shpec, add explicit find to zsh plugin).

What do you think? Did you merge it to separate branch and re layout for you pleasure?
I could move zsh specific code to plugin. Is this enough?
Or please provide me instruction what is my next step to fix it up.

With hope that shpec will be fixed 😄

I see here two different problems:
formal: PR not POSIX compilant - I could fix it
informal: I don't like this/that, this/that is not verbose(for whom?), it is not so right... - I could't fix it

API not changed
modification are test covered
new functions are absent - nothing changed

So except the POSIX part formal patch is correct.
I hope I explain my thought 🤔

@ezh I understand your concerns; I too want the zsh plugin to be fixed.
I think that I misunderstood this branch's description; let me try to summarize the issues:

The zsh plugin does not allow arguments to be passed (#102)
shpec does not handle arguments with whitespace (issue not yet opened)
We have no unit tests around calling function itself (w/ or w/o arguments), and thus have no way of testing either of the aforementioned issues.

@ezh assuming my understanding is correct, I would still prefer to address issues 1) and 2) separately. As you have requested, I will create a branch that provides some regression tests for 1) and possibly 2) as well. With that in place, we can come to a good solution together! I will have that done sometime this week.
Thank you again for your insight into this issue and the time taken to address it. I appreciate that you've found a solution, but I hope that you can also appreciate my discrimination; if I understand neither the "how" nor the "why" of some code, I have no hope of maintaining it, which is the quickest way to kill an OSS project.

All points 1-3 are correct.
It is a great pleasure that we have a conversation.
My only interest is working solution - all other are insignificantly (my PR too)
P.S. About live or dead OSS projects - I already involved in OSS salt with 25k PRs. Their community live within KPI, formal rules and extreme evolution rate. There are no I like/I don't like, more verbose/less verbose. I'm sure that there are more that one way to target. You may follow your own.

@ezh I've added a branch with some failing tests; see the details in #112. If you have the time, I would greatly appreciate a PR to address that issue be based on said branch.
I am still working on doing the same for the #102; I will let you know as soon as that's done.
Thanks!


Server needs to sign invoices on receipt

When the server receives an invoice, it needs to sign the invoice upon reception, using its host key as described in the signing-spec.md

This feature has been added. Closing


Flake8 Fails on Amazon LInux 2

Potentially related to the fix for #201
Also to this issue in flake8: https://github.com/PyCQA/flake8/issues/1701
STeps to reproduce:
checkout out repo, install requirements, install pre-commit
Make minor change to *.py
commit change:
Result:
flake8...................................................................Failed

hook id: flake8
exit code: 1

Traceback (most recent call last):
File "/home/ec2-user/.cache/pre-commit/repox3x2enjw/py_env-python3/bin/flake8", line 8, in
sys.exit(main())
File "/home/ec2-user/.cache/pre-commit/repox3x2enjw/py_env-python3/lib/python3.7/site-packages/flake8/main/cli.py", line 22, in main
app.run(argv)
File "/home/ec2-user/.cache/pre-commit/repox3x2enjw/py_env-python3/lib/python3.7/site-packages/flake8/main/application.py", line 363, in run
self._run(argv)
File "/home/ec2-user/.cache/pre-commit/repox3x2enjw/py_env-python3/lib/python3.7/site-packages/flake8/main/application.py", line 350, in _run
self.initialize(argv)
File "/home/ec2-user/.cache/pre-commit/repox3x2enjw/py_env-python3/lib/python3.7/site-packages/flake8/main/application.py", line 330, in initialize
self.find_plugins(config_finder)
File "/home/ec2-user/.cache/pre-commit/repox3x2enjw/py_env-python3/lib/python3.7/site-packages/flake8/main/application.py", line 153, in find_plugins
self.check_plugins = plugin_manager.Checkers(local_plugins.extension)
File "/home/ec2-user/.cache/pre-commit/repox3x2enjw/py_env-python3/lib/python3.7/site-packages/flake8/plugins/manager.py", line 357, in init
self.namespace, local_plugins=local_plugins
File "/home/ec2-user/.cache/pre-commit/repox3x2enjw/py_env-python3/lib/python3.7/site-packages/flake8/plugins/manager.py", line 238, in init
self._load_entrypoint_plugins()
File "/home/ec2-user/.cache/pre-commit/repox3x2enjw/py_env-python3/lib/python3.7/site-packages/flake8/plugins/manager.py", line 254, in _load_entrypoint_plugins
eps = importlib_metadata.entry_points().get(self.namespace, ())
AttributeError: 'EntryPoints' object has no attribute 'get'
Expected:
Passed or linting error.
OS:
cat /etc/os-release
NAME="Amazon Linux"
VERSION="2"
ID="amzn"
ID_LIKE="centos rhel fedora"
VERSION_ID="2"
PRETTY_NAME="Amazon Linux 2"
ANSI_COLOR="0;33"
CPE_NAME="cpe:2.3:o:amazon:amazon_linux:2"
HOME_URL="https://amazonlinux.com/"
Python:
python --version
Python 3.7.10

Closing for now as I can't reproduce, but let me know if there's still an issue!


porting: Add NPL equivalent for OS_ASSERT_CRITICAL

included in https://github.com/apache/mynewt-nimble/pull/346


Local authentication plugin

This is the first plugin with its own resources to be checked in AFAIK.
Please review and see whether you are comfortable with i18n'ed strings being stored this way. Our current proposal is for the app using this to embed strings into their own .arb bundles and get them translated. Unfortunately, we know of no way of shipping translated strings with a plugin since merging these at runtime seems to be infeasible.*
*: One way is to provide the strings at native layer and translate them. However, that creates a large burden on plugin maintainer [need to translate both iOS and Android flavors] and also makes overriding the string value more complicated.

I'd like @alan-knight to have a look and chime in.
Alan, check out auth_strings.dart and how it's used in local_auth.dart

How do Cocoapods or Gradle plugins provide translations today?  e.g. does the FaceBook SDK come with pre-translated strings, or is it up to every app developer to send off all their own strings + all the strings for their various dependencies off for translation?  @cbracken, @collinjackson or @jason-simmons might know.
I suspect that we will need to change the way package:intl works for Flutter to use the default iOS and Android data file formats, but I don't know?

I'm suspicious that putting the messages in a Map like that at initialization could run into a race condition between locale initialization and Map creation. That is, if that Map gets created before initializeMessages has completed, then they will have the wrong language. And obviously if the user changes the language then they'll be wrong.
I guess the obvious alternatives would be to do it as a case statement form, to wrap each method in a switch between the iOS and Android versions. Or possibly you could make the map be a map of closures. So e.g. instead of a getter, make the messages be methods/functions.
  fingerprintHint() => Intl.message ...

then you could have a map
 'fingerprintHint' : fingerprintHint,
  ...

and you just have to invoke the closure once you get it out of the map. And be sure that that only happens after locale initialization, but you'd have more control there.
I have a half-formed thought about being able to have the plugin have its own separate messages, involving tweaking the locale name and zones (or maybe just wrapping functions).

@alan-knight Thanks for the comments.
We are not pulling the strings during initialization of the plugin or the app. It is done when .args getter is called. See https://github.com/flutter/plugins/pull/151/files#diff-f997d8930094f3111f91642a1d40d5d8R47. There should not be a race condition here and even when language changes, the next call to authenticateWithBiometrics should evalute all the strings again.

Friendly ping!
Are there any other AIs for this PR?

My gut is that plugins should really be bundling their own translated messages.  As an example, when an app uses the GoogleSignIn plugin, the app developer doesn't expect to provide translations for all the native sign-in UI dialogs and such.
There's a logistical question about how we might go about wiring this into Google's internal process for getting strings translated, but in the meantime, I think it's probably best to structure the API to assume that the translations are self-contained in this plugin (even if it means we'll only have en in the first commit).
WDYT?

It's easier to add to the Dart API than subtract; if we can get away with making the strings self-contained in the plugin, that makes sense to me as a first step.
We could provide an optional mechanism for overriding the string values, either now or in the future, which is what other SDKs like Facebook do.

Ah, sorry, I didn't understand what was going on. It seems a bit hard to follow, and potentially slow. So we're eagerly building up a map of of all possible messages, keyed by message name, and passing that in to the constructor, which will then look them up by string again? And we have subclasses for Android and for iOS, why not just use the dispatch there to distinguish them?
I have an example of having a component with its own separate, bundled messages. It's not entirely pretty, but it works. What happens is that the component defines its own locale suffix, and then things within the component use that locale. Either they run inside an Intl.withLocale() call, or they explicitly pass in the locale. Not externally visible yet, but shortly, or ping me for the internal reference.

I agree that providing a complete package makes the most sense. The question is should it be done on Dart side or native side.
Dart side pros:

A single language/place to define all the strings. More dart, less native code. Hurray!
Easier for user to override.
One-time translation and single process.
Dart translation is well understood by most contributors (who need to translate their own apps).
Presumably easier to roll into Google.

Dart side cons:

No proper support for having multiple translation bundles (@alan-knight is working on a solution)
Not entirely clear where the strings are used. Need to completely rely on string descriptions.
More keys to maintain.

I am leaning towards Dart side even though I don't think it is a common use case to override these strings. What do the rest of you think?

Many plugin translations will be outside of our control.  For example, if you have a Example.com SDK plugin, that will likely wrap existing Example.com iOS and Android "native" SDKs and include translations in those formats.  So it is my belief that Flutter (and thus package:intl?) will need to support reading/loading translations from at-least "native" plugin components, but also likely from in-app "native" translation systems.

It should not be particularly difficult to make it look up messages in some other format. The current generated code imports message_lookup_by_library.dart, which has a reasonably narrow set of messages, just provide a different implementation that knows how to read and interpret the native messages. But there are probably interesting edge cases, like how the messages are identified or if the semantics of the native messages aren't a close match to Dart/ICU semantics.

@alan-knight it sounds like the workaround of the component defining its own locale suffix is a temporary workaround.  As we get more and more plugins (and third-party widgets with built-in strings), this will become a pattern that's seen again and again.
As such, can we add first-class support of multiple message bundles to package:intl?  It looks like it's covered by https://github.com/dart-lang/intl/issues/9.

@eseidelGoogle I don't foresee issues with bundling of native strings. If you have pre-translated bundles, it should just work due to gradle manifest/res merge on Android side. I am not sure about iOS mechanism but I have evidence that works also (internal Feedback plugin).

So at this point, my understanding is that our choices are:

Put the messages in Dart (our desired solution), but in so doing, we need to employ the workaround of having the plugin define its own locate suffix (and we require a new package:intl release that enables the workaround)
Put the messages in native bundles, which unfortunately means that we'll have duplicate translated strings (for iOS and Android).  This in turn means:

The two sets of translations could get out of sync
We'll have the extra overhead of creating and maintaining the duplicate bundles (the process for each platform is different), which will be burdensome on plugin authors.

Since we expect the multi-bundle problem to be resolved in Dart, can we make a bet on it and let the PR go in as is? Until Dart has proper support for this, the recommended workaround is for apps to manually merge the strings in the plugin to their bundle. @tvolkert @collinjackson are you OK with this?
@alan-knight What would be the timeline to resolve dart-lang/intl#9?

@tvolkert You don't need a new Intl release to do the trick with a locale suffix. The unpublished part is just an example/test for how to do it, there are no code changes to Intl.
@mehmetf Right now there is no timeline for resolving that. It's potentially a significant change. We might be able to do something in code generation with exposing a different Intl class, but it's certainly not worked out.

LGTM on the initial commit.  I think we should follow-up with a change to use the locale suffix trick suggested by @alan-knight before we publish the plugin.


PDP Content Panel/Props F&F

@josephco I merged in pairing-with-design PR. You can remove the squash commit once you rebase


Can't locate jeet in webpack!

I use stylus-loader to process .styl file, but @import('jeet') will throw a ERROR: failed to locate @import file jeet.styl . Who know how can fix it?
thx!!!

OK, i extract jeet dir from jeet module and put it into style dir , @import 'jeet' works!

Yep, the same is with sass. I still cannot import even bootstrap from node_modules.


'url' property is deprecated - question

I am using withRouter HoC as described in this snippet, however, I am still getting the error:
 utils.js:26 Warning: the 'url' property is deprecated. https://err.sh/next.js/url-deprecated

[x ] I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior

Code executes without the deprecation warning.
Current Behavior

The error mentioned above appears.
Steps to Reproduce (for bugs)

Import withRouter to your component
Refer any field from this.props.router
Export your component wrapped in withRouter HoC
When component is rendered, the deprecation error appears in console

Context

I am implementing Navigation component that is aware of the current route (to highlight the NavItem).
Your Environment

Tech
Version

next
6.0.0

node
9.11.1

OS
OSX 10.13.4

browser
Chrome Version 66.0.3359.139

If you check the source of basic App component (https://github.com/zeit/next.js/blob/30b0e36c7134ea4eb711c95f61cc773354348f09/lib/app.js), you'll see how it works. So the answer is to create your own App component like it described in README of next.js

I do not have a custom App component and I still get the warning. I do have a custom _document with the contents described here https://github.com/zeit/next.js#custom-document
Any ideas how to get rid of that warning?

@hugotox you simoly need to create a custom _app.js(x)

I think this should be told in the readme because now it just states that "Each top-level component receives a url property..."
Maybe there should be a note of the special case when using custom App component?

continously focus on this issue

While some of my page components rely on this.props.url, this isn't what is triggering the warning. One of my child components triggers the warning with JSON.stringify( this.props ).

I'm using a pretty standard configuration (no custom App, no attempt to ever reference url) and I get this warning. I don't think we should be forced into using a custom _app.js just to get rid of this.

@remy mentioned it's possible that React devtools triggers the url property read that causes the warning to show

@timneutkens Yep, that appears to be the issue in my setup. Should we update the error docs to reflect this?

I've removed the suggestions in this thread saying you should create a custom _app.js that passes in the url property globally, as the reason we removed it is to be more explicit and not pass in url as a property, but instead you can inject the router using withRouter() as per the deprecation. We will provide a codemod soon to update url in pages to the withRouter() implementation automatically.

I just open sourced the codemod we used to upgrade 35K+ lines of code from url to withRouter:
https://github.com/zeit/next-codemod#url-to-withrouter
@scaasic regarding documenting the React devtools property read, sure feel free to send a pull request. We always welcome documentation improvements 😌

After re-visiting this issue it seems like there's nothing wrong. Only React Devtools making it log out the warning, unfortunately, we can't get around that. @scaasic has created a pull request that adds a message saying react devtools can cause the warning to show up.

I was getting this warning message when I accessed the property query in this.props.url, in some page with query param url, like post?id=22, even by console when I printed this.props.
I got fix it using withRouter from next/router and accessing query from this.props.router.
import { withRouter } from "next/router";

class Single extends Component {
  componentDidMount = () => {
    const { router: { query: { id } }} = this.props;
    console.log(id);
  };
}

export default withRouter(Single);


tests: 🐣 mock consensus engine can perform an app handshake

stub issue.
see #3588.
https://github.com/cometbft/cometbft/blob/main/spec/abci/abci++_comet_expected_behavior.md
we should implement functionality such that the mock consensus engine can bootstrap itself. it should be able to perform a handshake with the app, which will involve implementing the info and init-chain parts of ABCI.

https://github.com/cometbft/cometbft/blob/main/spec/abci/abci++_methods.md#info
https://github.com/cometbft/cometbft/blob/main/spec/abci/abci++_methods.md#initchain

I'm not sure this is important, the mock consensus engine and the app state will never be out of sync since they'll be in the same test function.

notes from call today:

we won't need info, at least initially

closing in favor of #3787.


Pipeline to process Liquid Templating Language

Jekyll - another static page generator - is currently using Liquid as templating language.
Having a pipeline to process their tags/syntax would allow to re-use most of the Jekyll Templates out of the box (or at least quickly re-wire them).
As potential Feature Request for future milestone :)

I haven't tested it but I think this is done through #120 since scriban is compatible with liquid.


Touch support

Did anyone succeeded in enabling touch support?

I have the official 7'' touchscreen working. But I can't remember the details anymore.
There was a read-only issue so I dropped in a fstab (the /tmp/.Xsession or whatever could not be created)
Then I've updated everything (rpi-update, apt update)
And then I still needed
dtoverlay=vc4-kms-v3d,nocomposite,noaudio
dtoverlay=vc4-kms-dsi-7inch,swapxy=1,invy=1
max_framebuffers=2

lcd_rotate=1
display_rotate=1
display_lcd_rotate=1

disable_overscan=1

The vc4-kms-dsi-7inch,swapxy=1,invy=1 adjusts the touch directions. I've also added video=DSI-1:800x480@60 to the cmdline but I think that has no effect.
I've also adjusted the xsession with
xrandr --output DSI-1 --rotate left

You might need different settings though. And I would say you are potentially better off using a stock image, get the display working and then copy in the home data.
Running on an RPI4 with the official 7'' Display, showing the WLED UI (a WLED controller is in the box next to it)


Do not strip 'uuid:' prefix from submission instanceID

For posterity, this came out of the discussion at https://forum.getodk.org/t/incorrect-documentation-api-mock-for-instanceid/31027/6. The intent is for instanceID to simply be passed through and that's the case except for frontend display. This can be misleading/confusing when comparing with an export.


Updates to lib6502 breaks objdump

objdump does not build with the updated lib6502 (#93) as the zpr addressing mode is not handled by the disassembler:
apps/objdump.c:191:46: error: use of undeclared identifier 'zpr_cb'

Thanks for reporting. Fixed here https://github.com/davidgiven/cpm65/pull/96


Lifetime of constructor injected services for an Actor

I have a few question about the lifetime of contructor injected services for IRemindable Actors.
Background
We are going to be using an Actor for our .NET application with a long lifetime (several days), which is going to be reminded to activate once every day for a few days.
The Actor will be dependent on a service that in turn is dependent on an EF Core DbContext. We want the context to be as short lived as possible, and ensure that it doesn't share the same lifetime as the Actor (which will be several days).
It will look something like this:
public class MyActor : Actor, IMyActor, IRemindable
{
    public MyActor(ActorHost host, IMyRepository) // IMyRepository contains an EF Core DbContext
        : base(host)
    {
        ...
    }

    ...

 	public async Task ReceiveReminderAsync(string reminderName, byte[] state, TimeSpan dueTime, TimeSpan period)
    {
        ...
    }
}

Questions
From the documentation:

Each actor instance has its own dependency injection scope and remains in memory for some time after performing an operation. During that time, the dependency injection scope associated with the actor is also considered live. The scope will be released when the actor is deactivated.

When is the Actor deactivated? And is the Actor only reactivated when it receives a reminder?
Is the Actor, and/or its services, disposed on deactivation?
Do you see any issues with using constructor injected services for long-running IRemindable Actors (several days)?
Should we perhaps use an IServiceProvider.CreateScope() instead and create a new scope everytime the Actor is reminded, to ensure that services are disposed of properly? Like so:
public async Task ReceiveReminderAsync(string reminderName, byte[] state, TimeSpan dueTime, TimeSpan period)
    {
        using (var scope = _serviceScopeFactory.CreateScope()) // Constructor injected IServiceScopeFactory
        var myRepository = scope.ServiceProvider.GetRequiredService<IMyRepository>();
        ...
    }

@hittaKAFFE I'm sorry this was missed and no one wrote back to you for so long.
Actors are virtual - it'll be activated whenever a turn starts for its identifier (e.g. when a method is invoked on it or a reminder is triggered) and will be deactivated at some unknown point beyond that (up to the runtime), but re-activated whenever another turn is triggered.
I don't anticipate issues with any constructor-injected services so long as the DI registrations aren't themselves subject to change (e.g. you're creating a scoped or transient EF context from a connection string in Key Vault that you delete out of the blue at some point).
Creating your own scope isn't necessary.

@hittaKAFFE I was reading through other issues this morning and also noticed this response which might be of some use to you. Here, the user did find value in creating their own scope to gain access to a correlation identifier that would be consistent across the scoped request, so there may indeed be some limited value in doing that, but I struggle to think of any other similar situations off the top of my head.

Cool, thanks @WhitWaldo.


AutoFaker.Generate on delegate-based types causes EngineExecutionException

Actual Behavior
Calling AutoFaker.Generate<T> on types like Action<...> and Func<...> either directly or indirectly (e.g. target type has public property of type Action<int>) causes the whole program to crash with EngineExecutionException.
Sample code:
AutoFaker generator = new();
generator.Generate<Action>();

The problem seems to be that autobogus is calling private delegate constructor with randomly generated method pointer. However, setting public reflection flags doesn't seem to be a workaround as this constructor for some reason is reported as public by reflection API. So the following code also crashes:
AutoFaker generator = new()
{
    Config =
    {
        ReflectionCacheOptions = new ReflectionCacheOptions()
        {
            ConstructorFlags = BindingFlags.Public | BindingFlags.Instance,
            MethodFlags = BindingFlags.Public | BindingFlags.Instance,
        }
    }
};
generator.Generate<Action>();

Expected Behavior
Probably I'm missing some autofaker configuration settings, but it seems like the best way of doing this is to have some special handling for delegates by either ignoring them or assigning empty methods.

@sergey-rybalkin should be fixed in 0ea1232380e803f9480800605edc21f18c14e5c6
We're now skipping any delegate creation of 'top level' types (i.e. .Generate<Action>()). 'Second level' types (Actions within classes) were already being skipped.


Incorrect rendering of multiple - in \texttt

Try
\texttt{a---b}

In LaTeX the --- will appear as 3 individual "-". In KaTeX they will get merged into a single dash, which shouldn't happen for such a monospace font.

Thanks for spotting. As a temporary work-around, \verb|a---b| should work correctly. We should be able to fix the \texttt behavior, though I forget how ligatures like this are processed in KaTeX.

another workaround is to type -{}-{}-{}. this issue isn't a big deal, but
I thought I'd point out anyway.
On 27 May 2018 at 22:28, Erik Demaine<EMAIL_ADDRESS>wrote:

Thanks for spotting. As a temporary work-around, \verb|a---b| should work
correctly. We should be able to fix the \texttt behavior, though I forget
how ligatures like this are processed in KaTeX.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Khan/KaTeX/issues/1367#issuecomment-392327537, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AEawh9bMCIVuJ_wqMbf3BBKpTkTGR1Zgks5t2pwEgaJpZM4UPNiU
.

Does this occur in any of the other \textX commands or is it just a \texttt thing?

It's specific to \texttt.  Curiously, \text{\tt --} works fine.  I'm investigating.

I think it's the normal behavior for other \textX.
On 30 May 2018 at 01:12, Kevin Barabash<EMAIL_ADDRESS>wrote:

Does this occur in any of the other \textX commands or is it just a
\texttt thing?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Khan/KaTeX/issues/1367#issuecomment-392813789, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AEawh0f8JmiHvTXAxhKX7NGB1YY-4IIkks5t3WVMgaJpZM4UPNiU
.


A thread keeps running while main threads ends in results in a background process in SharpChatUIClientVS

Issue Solved by Setting NetworkStream.ReadTimeOut


Use the StructureMap integration as a base and implement as Lamar.

Hi guys,
I have added Lamar tests in the MassTransit.Containers.Tests project. Hopefully that verifies it works as much as any of the other Containers!
Please see https://github.com/MassTransit/MassTransit/issues/1145 for comments around the motivation and a couple of issues I had when developing - plus an outstanding issue in Lamar. Once that issue is resolved, I'll fix these up and make another PR for you.

I did wonder about that. I did the autocrlf as suggested in the readme, but let me see if there's something I can do here.
Will get back to you


Helvetica Neue will cause the Bold command to have to be executed twice if on an empty field

I haven't figured out how to fix this yet. It works fine with all other fonts that I have tested.

This also happens at the beginning of any new line.


How to track down the code line

I am having the problem to add polyfill support (e.g. support old Chrome and IE11 etc).
I want to use core-js. relay-compiler demands core-js2, while using core-js2, I come across this:
[craco] =============
[craco] Failed to compile.
[craco]
[craco] ./src/index.tsx
[craco] Module not found: Can't resolve 'core-js/modules/es.array-buffer.constructor' in 'd:\me\svn\FE\src'

I know es.array-buffer is core-js3 feature, but I have no clue to find out which package wants it.
In summary, Could you give me some hint on how to track this error?

Hi @silencej
I dont think this has something to do with CRACO.
You should look for answers in the CRA or Babel repository.
I am closing this issue, if you think it's really an issue with CRACO, you can re-open it.
Patrick


Improve user friendliness of the output of the @show of the energy_problem

What and Why
Fix significant digits and units in the timing and objective function.
Format the values of the timing and objective function

objective function: Plain format (no scientific format). Instead of 3.35e3, it should be 3350
timing: do not show "(in seconds)" -> format it to have in the meaningful format, e.g., 17ms

Possible Drawbacks
No response
Related Issues
No response

Since I was the one bothered by this, I assigned it to myself.
There is a default Date formatter, but its output is rather long:
julia><PHONE_NUMBER>23456 |> Dates.Nanosecond |> Dates.CompoundPeriod |> Dates.canonicalize
1 day, 10 hours, 17 minutes, 36 seconds, 789 milliseconds, 123 microseconds, 456 nanoseconds

I'd rather have something like:
1d 10h 17m 36s 789ms 123μs 456ns

I looked at the existing packages that output time in this format (TimerOutputs.jl and BenchmarkTools.jl), and they both implement their own formatters. We can do the same, it's not hard to write a formatter like this. The question is, should this be a part of Tulipa or a separate thing (e.g., a micropackage with just a few pretty formatting tools). It's not really a part of TulipaEnergyModel per se, and I can see other libraries like TulipaPlots using the formatting tools later.
Or maybe I missed something and there exists a nice time formatting library we can use?
@abelsiqueira @suvayu thoughts?

Most Tulipa* libraries will depend on TEM.  So I wouldn't bother creating a separate package, because then to use it easily you would need to register it as well.

I'm in favour of not implementing anything new for this. Instead, maybe we change how we use the timing packages to benefit from their printing.
If that doesn't work, we can check with, for instance, TimerOutputs, to see if it makes sense to export their pretty printing function.


The scheduler shouldn't care about the scheduled payload

There's a design fault in the current scheduler implementation, it currently assumes that only TransportUserMessages are to be scheduled when in fact we want it much to behave like a persistent reactor.callLater type of thing so we can apply robust scheduling to all sorts of scenarios - not only message delivery. Thanks for pointing this out @overnin.

The TransportUserMessage bit is here: https://github.com/praekelt/vumi/blob/develop/vumi/transports/scheduler.py#L144

Good point. We'll probably want a convenience wrapper for TransportUserMessages, though. I'm pretty sure that'll be a significant enough use case to warrant it.

Yes I'll keep that in but enable other, more generic, use as well.

:+1:

I think we could just deserialize to a generic vumi.message.Message for now.


Tooltip not shown when clicking help questionmark

Microsoft PowerToys version
0.47.1
Running as admin

[X] Yes

Area(s) with issue?
FancyZones Editor
Steps to reproduce

Open fancy zones editor -> Edit some layout;
Click on "Help"/quastionmark icon in order to get help;

It is expected for help tooltip to appear (as expected in most applications), but nothing happens (NOT OK). Hover over that icon for some time for tooltip to appear (OK).

✔ Expected Behavior
No response
❌ Actual Behavior
Clicking on help icon does not immediately show tooltip.
Other Software
No response

does this issue still happen with v0.73.0? /needinfo


PothosError: builder.prismaNode requires @pothos/plugin-relay to be installed

Hi!
Just trying out Pothos in a fresh project, and wanted to get the prisma integration + relay to run.
installed versions:
"@pothos/core": "^3.29.0",
"@pothos/plugin-prisma": "^3.47.2",
"@pothos/plugin-relay": "^3.39.0",

So everything is installed. But I keep getting the error
PothosError: builder.prismaNode requires @pothos/plugin-relay to be installed

code in question:
const builder = new SchemaBuilder<{
  PrismaTypes: PrismaTypes;
}>({
  plugins: [RelayPlugin, PrismaPlugin],
  prisma: {
    client: prisma,
    filterConnectionTotalCount: true,
  },
  relayOptions: {
    clientMutationId: 'omit',
    cursorType: 'String',
  },
});

builder.prismaNode('User', {
  id: { field: 'id' },
  fields: (t) => ({
    title: t.exposeString('title'),
    author: t.relation('author'),
  }),
});

any idea what I am doing wrong here?

Ran into the same error but when using Bun instead. If this happens to you when using bun do the following:

Delete the node_modules directories (you may have multiple if you are in a mono repo).
Run the following to clean Bun's cache so that dependencies are installed.bun pm cache rm

You can find it at the of this Bun doc.


Intermittent errors on Windows

Sometimes getting:
Error: LIBUSB_TRANSFER_STALL
    at Error (native)(anonymous function) @ Logger.js:136errorHandler @ misc.js:128emitOne @ events.js:77emit @ events.js:169window.onerror

and
Error: LIBUSB_TRANSFER_STALL
    at Error (native)(anonymous function) @ Logger.js:136errorHandler @ misc.js:128emitOne @ events.js:77emit @ events.js:169window.onerror

OS: Windows 10
Dongle: BCM20702A0 dongle with PID 21E8 and VID 0A5C
Platform: Electron
Communication with peripherals stop when encountering these errors. Is there a way to recover from these?

@mhle have you looked it what USB endpoint is stalling?
Also, do you have code and steps to consistently reproduce?

Looking into this further, this seems to be caused by too many hci events blocking communication with the dongle. We could consistently produce this by triggering a surge of data going to/from dongle by:

trying to connect/disconnect to multiple (7+) devices at the same time,
continuously triggering startscan and stopscan with short intervals

@mhle can we close this or are there any action items on the noble side?


Change ResourceLocation property to Location

This PR is related to two issues (Both issues are same but raised in two language SDKs):

https://github.com/Azure/azure-sdk-for-js/issues/11224
https://github.com/Azure/azure-sdk-for-net/issues/15120

The issue is, in the Cognitive Services Face API, the service returns the property location in the response (This has been confirmed by the HTTP Logs). But, in the swagger response it was mentioned as resourceLocation, which is a mistake. So, this PR fixes it.

/azp run automation - sdk

/azp run automation - sdk