Integrate the settings file as a part of deployment

Emulate the richmondsunlight.com deployment process.

Maybe just use Travis' environment variables.

I'm working on a Bash script that retrieves all of the environment variables set in Travis, for the various settings config constants, and populates includes/settings.inc.php with them.

I'm having an absurd problem with this. Every element in the array fails if [ -z $"{!i}" ], but echo " ${!i}" displays the value just fine. I'm baffled

Now the problem is the DSN string. It looks like this:
mysql:dbname=rs;host=rs.co5x32ldqap.us-east-2.rds.amazonaws.com;charset=utf8

But the resulting line in the config file looks like this:
define('PDO_DSN', 'mysql:dbname=rs');

It's getting hacked off at the semicolon. I don't know why.

Ah-ha—semicolons have a reserved value in sed.

Aaand that didn't do it. I'm baffled.

HOW DID THIS NOT FIX THE PROBLEM

This has got to be a Bash problem, instead of a sed or Perl problem. Debug with this in mind.

I tried modifying the DSN value, as stored in Travis, to test;test2, and that worked fine. 🤔 Then I tried modifying the DSN value to omit the first semicolon. The effect of that was that more of the DSN was included...everything up until the second semicolon (the first in the test string).
Now I'm going to expose the value of each variable in the logs and see where that gets me.

Huh, so Travis displayed the list of environment variables (as it always does), and PDO_DSN was correct. Then, when iterating through the array in config_variables.sh, the value was again truncated at the first semicolon.
Here's where things get weird.
The process of $PDO_DSN, before anything is done to it, is already truncated.
Ohhhhhh, I think this is on Travis! I think they're failing to process environment values in any way. I think they're literally doing this:
$ export PDO_DSN=mysql:dbname=rsdbname;host=[secure];charset=utf8

And, of course, that gets truncated.
Dopes.

And now it's deploying with no values completed at all.
I'm being punished for something, I guess.


Fix Coverage

Status
READY
Breaking Changes
NO
Description

100% coverage

@AppleEducate can you take a look?

Looks great! 👍🏼


Install Fails: go install fails with error in utils.go

When installing this via go install on an ubuntu based EC2 VM , I am facing an issue
$ go install<EMAIL_ADDRESS># github.com/rivosinc/prometheus-slurm-exporter/exporter
go/pkg/mod/github.com/rivosinc/prometheus-slurm-exporter@v1.5.1/exporter/utils.go:175:8: cannot use 1e+12 (untyped float constant) as int value in map literal (truncated)

Here is the go version and other details about my environment
$ uname -r
5.19.0-45-generic

$ lsb_release -a
No LSB modules are available.
Distributor ID:	Ubuntu
Description:	Ubuntu 22.04.2 LTS
Release:	22.04
Codename:	jammy

$ go version
go version go1.22.0 linux/amd64

Interestingly it works on my local WSL setup. Here are the details for my local setup
$ go version
go version go1.22.0 linux/amd64
$ uname -r
<IP_ADDRESS>-microsoft-standard-WSL2
$ lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description:    Ubuntu 22.04.4 LTS
Release:        22.04
Codename:       jammy

The only thing I can think of is perhaps it's using int32 instead of 64 by default?
>>> 2**32 > 1e12
False
>>> 2**64 > 1e12
True

I will push a branch with int64 typing and see if that helps :)

Please let me know if the following branch works

The installation work but now the exporter does not
root@rgEval:~# prometheus-slurm-exporter prometheus-slurm-exporter -slurm.cli-fallback
time=2024-06-20T10:49:03.466+02:00 level=INFO msg="serving metrics at :9092/metrics"
time=2024-06-20T11:07:01.426+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T11:41:22.325+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T11:41:37.333+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T11:41:52.334+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T11:42:07.325+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T11:42:22.326+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T11:42:37.324+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T11:42:52.327+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T11:43:07.334+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T11:43:22.335+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T11:43:37.325+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T11:43:52.330+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T11:44:07.326+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T11:44:22.328+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T11:44:37.324+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T11:44:52.335+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T11:45:07.324+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T11:45:22.325+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T11:45:37.333+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T11:45:52.325+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T11:46:07.328+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T11:46:22.326+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T11:46:37.338+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T11:46:52.325+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T11:47:07.336+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T11:47:22.323+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T11:47:37.323+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T11:47:52.324+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T11:48:07.326+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T11:48:22.325+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T11:48:37.325+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T11:48:52.325+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T11:49:07.324+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T11:49:22.330+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T11:49:37.323+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T11:49:52.323+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T11:50:07.326+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T11:50:22.325+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T11:50:37.324+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T11:50:52.325+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T11:51:07.326+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T11:51:22.325+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T11:51:37.326+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T11:51:52.327+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T11:52:07.326+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T11:52:22.327+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T11:52:37.341+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T11:52:52.324+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T11:53:07.325+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T11:53:22.327+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T11:53:37.327+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T11:53:52.323+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T11:54:07.337+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T11:54:22.324+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T11:54:37.341+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T11:54:52.329+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T11:55:07.333+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T11:55:22.328+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T11:55:37.325+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T11:55:52.324+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T11:56:07.331+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T11:56:22.328+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T11:56:37.326+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T11:56:52.328+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T11:57:07.331+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T11:57:22.326+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T11:57:37.331+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T11:57:52.327+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T11:58:07.332+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T11:58:22.326+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T11:58:37.324+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T11:58:52.324+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T11:59:07.325+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T11:59:22.327+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T11:59:37.323+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T11:59:52.329+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T12:00:07.327+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T12:00:22.330+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T12:00:37.329+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T12:00:52.326+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T12:01:07.328+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T12:01:22.327+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T12:01:37.324+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T12:01:52.324+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T12:02:07.324+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T12:02:22.338+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T12:02:37.323+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T12:02:52.333+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T12:03:07.326+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T12:03:22.329+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T12:03:37.330+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T12:03:52.338+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T12:04:07.327+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T12:04:22.324+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T12:04:37.326+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T12:04:52.324+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T12:05:07.325+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T12:05:22.323+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T12:05:37.328+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T12:05:52.324+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T12:06:07.329+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T12:06:22.343+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T12:06:37.330+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T12:06:52.324+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T12:07:07.324+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T12:07:22.341+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T12:07:37.326+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T12:07:52.325+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T12:08:07.327+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T12:08:22.343+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T12:08:37.324+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T12:08:52.327+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T12:09:07.326+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T12:09:22.329+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T12:09:37.326+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T12:09:52.333+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T12:10:07.328+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T12:10:22.353+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T12:10:37.329+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T12:10:52.325+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T12:11:07.323+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T12:11:22.324+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T12:11:37.336+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T12:11:52.324+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T12:12:07.338+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T12:12:22.324+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T12:12:37.332+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T12:12:52.323+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T12:13:07.330+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T12:13:22.337+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T12:13:37.331+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T12:13:52.336+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T12:14:07.323+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T12:14:22.322+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T12:14:37.326+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T12:14:52.331+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T12:15:07.325+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T12:15:22.330+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T12:15:37.330+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 ``"
time=2024-06-20T12:15:52.328+02:00 level=ERROR msg="squeue fallback parse error: failed on line 0 `

The slurm version
root@rgEval:/etc/alloy# squeue --version
slurm 23.02.7
root@rgEval:/etc/alloy#

Well, we are getting somewhere. Could you tell me whether the following command provides a viable output and give me some of the example output (with no proprietary data off course)? I'm thinking for some reason maybe squeue is printing no output/an extra empty line. Perhaps one of the cli output options works differently on that version of slurm.
squeue --states=all -h -r -o '{"a": "%a", "id": %A, "end_time": "%e", "u": "%u", "state": "%T", "p": "%P", "cpu": %C, "mem": "%m", "array_id": "%K"}'

This command somehow does not work.
squeue --states=all -h -r -o {"a": "%a", "id": %A, "end_time": "%e", "u": "%u", "state": "%T", "p": "%P", "cpu": %C, "mem": "%m", "array_id": "%K"}
squeue: error: Unrecognized option: %a,
Usage: squeue [-A account] [--clusters names] [-i seconds] [--job jobid]
              [-n name] [-o format] [-p partitions] [--qos qos]
              [--reservation reservation] [--sort fields] [--start]
              [--step step_id] [-t states] [-u user_name] [--usage]
              [-L licenses] [-w nodes] [--federation] [--local] [--sibling]
	      [-ahjlrsv]

Although while attempting to debug , I changed the command a little which works and does print an output
squeue --states=all -h -r -o "%a %a %e %u %t %p  %c %m %k"
root root N/A root PD 0.99998472956940  1 0 (null)

Yeah seem all data you guys are fetching using sinfo, I guess like nodes and stuff but not job info. Also my jobs don't tracing on yet. Does that contribute to this ?

Howdy, the version of slurm we have is: slurm 23.02.4. I checked docs for 23.02.4 and 23.02.7 and found no changes to the squeue output format. For the problem above, do you mind

Trying to put the format statement in single quotes
Try using a bash/zsh shell?
You could try modifying the statement and passing it into -slurm.squeue-cli option. Not the option splits by the space character, so you'd have to do something like:

prometheus-slurm-exporter -slurm.squeue-cli squeue <modified cmd>

Or you could make a small squeue_fetch script with the command that works for your machine and do the following:
#!/bin/bash

set -e

# in squeue_wrapper.sh
# keep modifiying the below statement till the output works
squeue --states=all -h -r -o '{"a": "%a", "id": %A, "end_time": "%e", "u": "%u", "state": "%T", "p": "%P", "cpu": %C, "mem": "%m", "array_id": "%K"}'

Then invoke it in the exporter:
prometheus-slurm-exporter -slurm.squeue-cli ./squeue_wrapper.sh

Unfortunately, if you are using slurm 23, trying to use the dataparser json option might not work for you, but you could give it a shot (-slurm.cli-fallback=false) or contribute to that fetcher if you'd like. I started work on that here.
What's more puzzling is that you should get the following log message if the fetcher fails as you've describe above:
time=2024-06-20T12:19:21.446-07:00 level=ERROR msg="fetcher failure %q" !BADKEY="exit status 1"

So that's even more confusing.

@codeknight03 I think I reproduced the problem and patched it here. I don't think you had any jobs running. That case should now be handled.

I'm going to merge the MR with the type fix in. If there are any other job problems, we can handle them in a separate MR.

Thanks for the quick turnaround @abhinavDhulipala . I also have a few free hours every to take up some HPC challenges. Let me know how I can help you. I am interested in implementing the support for rest. Let me know a good point to start.


review on what docker-java version it based atm

2.1.2-SNAPSHOT because of testing shading. 2.x will be released soon, so i will switch to released version.
3.x under active development and will require changes later.


Calling load() on a lazy loaded element doesn't work

I've discovered a bug where calling load() manually on a lazy loaded breaks the element. It triggers the request, but then when the element becomes visible the content isn't replaced. Example below from the examples page:
https://user-images.githubusercontent.com/78225/127467621-928ad4cd-9149-421e-8449-5e18f196f452.mov

There appear to be two separate bugs at play here:

The load() function un-observes the intersection observer, which means when the element becomes visible it will not trigger content replacement: https://github.com/github/include-fragment-element/blob/5785cf3323b3d75e008d0d4ad718f57c6f314e00/src/index.ts#L149
Removing that line will fix the bug, but the preloading doesn't actually work, a second request for the content will be made when the element becomes visible. That's because the load() function doesn't actually store the result anywhere.


fix: If an error occurs, the value of svc will be overwritten and the print error message will be panic

fix: If an error occurs, the value of svc will be overwritten and the print error message will be panic

Hi @cinderyx. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.


HTML views

Currently working on getting some base HTML views up, inspired by those packaged in Devise. This is a feature set requested from a number of people, and makes sense for the large Phoenix ecosystem.

Completed in the update to v1.0.0


Make examples run again

Update build.zig to ensure it can be compiled successfully under Zig 0.11.
Update to the latest version of the JSON API.

failed tests are due to singly linked list tests no longer working, not the PR.

Thanks for this!


Mobile support

Mobile viewport is not currently supported well.
On mobile you can't drag and drop an image, need an explicit image upload button.

Fixed by adding breakpoints and handling touch events when repositioning the image.


Section <IP_ADDRESS>, FCS_NTP_EXT.1.4 Test 2

As written, Test 2 appears to want the CCTL to create an “NTP Server Response” packet which is distinctly different from an NTP broadcast/multicast packet (i.e., it has authentication and keying material vice the broadcast packet which does not.
TOE response to broadcast packets is specifically covered in testing for FCS_NTP_EXT.1.3.  Test 2, as currently written, appears to allow the reuse of broadcast packets to demonstrate TOE functionality in this test.
From a technical evaluation standpoint, it is difficult to know if the TOE rejected the packet because it was a broadcast/multicast packet or if it was because the NTP Server was not configured on the TOE.
Suggested change:
For FCS_NTP_EXT.1.4 Test 2 (Line 491), the intent of this test should be clarified to explicitly allow or disallow the use of broadcast or multicast packets to satisfy the test requirement.
•	If broadcast/multicast packets are part of the intent, additional testing should be considered to evaluate that the TOE is able to ignore unsolicited packets from rogue NTP servers.

Recommendation...
Add to test 2: "This test must use a unicast packet, not broadcast nor multicast. The source IP of the packet from the NTP server must not correspond to any configured NTP server on the TOE, but the packet must otherwise conform to at least one packet used to test FCS_NTP_EXT.1.2."

I don't think clarification of Test 2 is necessary, as FCS_NTP_EXT.1.3 element already prevents acceptance of broadcast and/or multicast packets in the evalauted configuration.
If further clarity is still required, I recommend updating Application Note 95 in the following way:
The TOE has to support configuration of at least 3 unicast time sources ...

Agreed test 2 needs no changes.  The test for FCS_NTP_ECT.1.3 states "The evaluator shall confirm the TOE is configured to not accept broadcast and multicast NTP packets that would result in the timestamp being updated" Seems like we specifically call those types of packets out already.

Agreed above and in MINT meeting on Feb 20 to not make any changes to the test nor to the application note.


Doesn't work with SVG images

it doesn't work with app:srcCompat which is used to load vector images.

Duplicate of #188.


fix infinite loop in stripeBillingService

This should fix #59

LGTM - thanks for the fix @joelbudu

You're welcome @MikeEvansLarah . Will/can the docker image be rebuilt?

I triggered the workflow for publishing the Docker image but there are build errors that are preventing it from running.
I've opened a new issue: https://github.com/microsoft/azure-api-management-monetization/issues/61


Unable to create schema

I am using Cequel without Rails (or Sinatra). It's a standalone gem. I tried to use rake cequel:init and it throws error:
NoMethodError: undefined method `schema' for nil:NilClass
/Users/pranav/.rvm/gems/ruby-2.1.5/gems/cequel-1.7.0/lib/cequel/record/tasks.rb:38:in `create!'
/Users/pranav/.rvm/gems/ruby-2.1.5/gems/cequel-1.7.0/lib/cequel/record/tasks.rb:9:in `block (3 levels) in <top (required)>'
/Users/pranav/.rvm/gems/ruby-2.1.5/bin/ruby_executable_hooks:15:in `eval'
/Users/pranav/.rvm/gems/ruby-2.1.5/bin/ruby_executable_hooks:15:in `<main>'

It's originating maybe because I didn't specify any configuration file. So, this time I create a custom Rakefile that does the following
config_file = 'lib/blogger/config/config.yml'
  config = YAML.load_file config_file
  Cequel.connect(config)
  Cequel::Record.establish_connection(config)
  Cequel::Record.connection.schema.create!

The config.yaml is below:
name: blogger_development
host: '<IP_ADDRESS>'
port: 9042
keyspace: blogger_development
max_retries: 3
retry_delay: 0.5
replication:
  class: SimpleStrategy
  replication_factor: 1

However, this throws following error
Cassandra::Errors::SyntaxError: line 2:0 no viable alternative at input 'WITH' (CREATE KEYSPACE [WITH]...)
	from /Users/pranav/.rvm/gems/ruby-2.1.5/gems/cassandra-driver-2.1.5/lib/cassandra/future.rb:570:in `get'
	from /Users/pranav/.rvm/gems/ruby-2.1.5/gems/cassandra-driver-2.1.5/lib/cassandra/future.rb:363:in `get'
	from /Users/pranav/.rvm/gems/ruby-2.1.5/gems/cassandra-driver-2.1.5/lib/cassandra/session.rb:121:in `execute'
	from /Users/pranav/.rvm/gems/ruby-2.1.5/gems/cequel-1.7.0/lib/cequel/metal/keyspace.rb:205:in `block in execute_with_consistency'
	from /Users/pranav/.rvm/gems/ruby-2.1.5/gems/cequel-1.7.0/lib/cequel/metal/request_logger.rb:30:in `log'
	from /Users/pranav/.rvm/gems/ruby-2.1.5/gems/cequel-1.7.0/lib/cequel/metal/keyspace.rb:203:in `execute_with_consistency'
	from /Users/pranav/.rvm/gems/ruby-2.1.5/gems/cequel-1.7.0/lib/cequel/metal/keyspace.rb:187:in `execute'
	from /Users/pranav/.rvm/gems/ruby-2.1.5/gems/cequel-1.7.0/lib/cequel/schema/keyspace.rb:75:in `create!'

What am i missing here?

So it turns out that I had to deep symbolise the keys from YAML before it could be useable. Spend hours on it like crazy. Here is how to do it:
config_file = 'lib/blogger/config/config.yml'
  config = YAML.load(config_file).deep_symbolize_keys
  Cequel.connect(config)
  Cequel::Record.establish_connection(config)
  Cequel::Record.connection.schema.create!

If you're wondering how it occured to me, take a look at this line

Turns out that there is a better way to do this. Define your Rakefile as
require 'cequel'
require 'yaml'

task :environment do
  config_file = 'lib/octocore/config/config.yml'
  config = YAML.load_file(config_file).deep_symbolize_keys

  connection = Cequel.connect(config)
  Cequel::Record.connection = connection

end

spec = Gem::Specification.find_by_name 'cequel'
load "#{spec.gem_dir}/lib/cequel/record/tasks.rb"

Glad you found a solution.


ONNX RNN export: add some padding to mimic pytorch

[note: tested in onnx-fb-universe in a separate diff]

@salexspb regarding tests, this is fully tested by existing tests in onnx-fb-universe test_caffe2.py (In fact, the reason I realized we need this functionality is because those tests were failing without it).


[bug]Balance calculation error

The conditions for this error are as follows:

The same receive address, receive twice, once 1ltc, once 10ltc
Send 4.73865ltc, here is the change. Here, after synchronization, it becomes receiving 6.257607ltc, and the intermediate difference is fee. What is sent out is not reflected.
At this time, you find that the balance becomes 17.25ltc, and the real balance should be 6.57607ltc
This bug should be getting the change in the txid as the receiving calculation, but the actual sending did not get it

Likely this transaction is still in the mempool.  After 10 mins you should let us know if this is still incorrect.  Many balance issues we see are due to poor internet connectivity because the Litewallet client is not getting the latest block updates.

Likely this transaction is still in the mempool. After 10 mins you should let us know if this is still incorrect. Many balance issues we see are due to poor internet connectivity because the Litewallet client is not getting the latest block updates.

It's been 7 days, and the problem still exists. I'm sure the latest block is obtained. The network is normal and the nodes are normal

Wow @vcexnet this is very very bad and unusual.
Do you mind contacting us in<EMAIL_ADDRESS>?
We need to get to the bottom of the problem. We will need the Litewallet version, device Android version and maybe screen shots

Wow @vcexnet this is very very bad and unusual.
Do you mind contacting us in<EMAIL_ADDRESS>?
We need to get to the bottom of the problem. We will need the Litewallet version, device Android version and maybe screen shots

E-mail has been sent, but there is no reply


DataGrid; Selecting the filter menu or filter icon causes the filter to be added even if the user does not configure the filter and select's apply

Bug type
Component
Component name
DataGrid
What happened?
If you select the filter button/icon or the filter menu, and the filter popover appears, the filter is automatically added into the popover filter window.  But if the user clicks out of the window (without clicking "apply") the filter is still applied/remains in the UI.
Expected behavior
The filter should either not be automatically added or should not be kept if the user is not selecting "apply".
The issue here is a user does not have the ability to make a difference between "check what filters are currently applied" without adding a filter
Potentially easy fix is: If operator field is null then do not keep the filter
Reproduction link

Reproduction steps

...
Relevant log output
No response
Version (bug)
6.19.1
Version (working)
No response
What browsers are you seeing the problem on?
Chrome
On which operating systems are you experiencing the issue?
macOS
Pull Request

[ ] I would like to do a Pull Request

Code of Conduct

[X] I agree to follow this project's Code of Conduct

I agree with Stephen, and hope this can be fixed soon. 👍


AVRO-2001 Adding support for doc attribute [ruby]

AVRO-2001: https://issues.apache.org/jira/browse/AVRO-2001
The Avro schema and protocol specification(http://avro.apache.org/docs/current/spec.html) allows for an optional attribute doc defined as, "a JSON string describing this field for users." Users should be able to include a doc with each field for records (http://avro.apache.org/docs/current/spec.html#N10085), record fields, and enums (http://avro.apache.org/docs/current/spec.html#N10186). The doc attribute is also in the spec for protocols and protocol messages (http://avro.apache.org/docs/1.8.1/spec.html#N105C6 and http://avro.apache.org/docs/1.8.1/spec.html#N105F1).
This doc attribute should be stripped when transforming into "Parsing Canonical Form" (http://avro.apache.org/docs/current/spec.html#N10815).
Currently, the Ruby Avro library (https://github.com/apache/avro/tree/master/lang/ruby) does not support doc. It is supported in other languages libraries, for example PHP (https://github.com/apache/avro/blob/master/lang/php/lib/avro/schema.php#L46).

Solid feedback on all counts. I'll have another draft soon.

@tjwp This is ready for another look. I've added doc support to the classes you listed, and fixed my wrong headed unit test.
Right now I've just added two unit tests, each with multiple asserts for testing doc support in various contexts. Perhaps they should be separate tests? I'm happy to break them down or do whatever you recommend. I'm new to test-unit there may be syntax I'm not aware of. I could use context but that would add another dependency to the project.
If you run the tests you'll see a lot of warning: instance variable @doc not initialized. I followed the pattern for @name, which also issues this warning (in the master branch). I'm down for a follow up PR to address that, and those warning: File.exists? is a deprecated name, use File.exist? instead deprecation warnings. But I figured that was out of scope for AVRO-2001.
Thanks again for your prompt feedback. It will make my task a lot easier to have this supported in the core gem!

@tjwp Solid feedback again; good catch on the missing attr_readers! I don't mind "nit picks" at all - I'd like to get this right.  Thank you for your help with this, much appreciated!

@tjwp this PR has been sitting out here awhile, is there something I can or should do get this merged? My team is using a fork on prod right now, which works, but we'd rather not do that indefinitely...
(I realize you don't merge PRs, but I figured you'd know the process and maybe the likely timeline?)
Thanks!

@lostphilosopher I'm in the same boat with AVRO-1695 and AVRO-1969, so I don't really have any answers for you.

@rdblue @busbey @spacharya hi folks, sorry to "cold mention" you. You all seem active in the Ruby side of this project so I decided to reach out. This is my first PR to this project and I'm curious how long it will take to get this merged? Did I miss any steps in the process? If the answer is that this could take a long time that's fine with me. I'd just like to know; and to be sure the hold up isn't on my end. Thank you all.

This looks good to me.
I see other peoples approvals too :).
If no one has any objection then I will merge this into master in the next week.

@spacharya awesome! Thank you!

@tjwp reviews do help a ton. Do you have a preferred email address to have published as a reviewer of this change? Any other things you've reviewed that you'd like to point me towards as I work through a round of Avro changes?

Hi,
I have committed this to master.
However, I forgot to close the commit as I was pushing it. @lostphilosopher  can you close this pull request. I will make my life a lot easier.
Thanks.

@spacharya consider it done!

Thank you very much @spacharya, @busbey, and @tjwp, this makes my life easier - and makes my day! 😄

@busbey My preferred email would be (tjwp @ cantab.net). Thanks!
I don't have anything else to point you to right now. I try to look at any Ruby changes that go by since that is the implementation that I use primarily.


New Command: New-DbaDbUser to add a user to a database

Feature Request
There is an existing command to Remove-DbaDbUser but no corresponding Add command.
Problem to solve
This is an inconsistency.
Additional information
Accept pipeline input from New-DbaLogin
Returns the newly created user

fixed via https://github.com/sqlcollaborative/dbatools/commit/a14117203bf3d0c1f86e499c2722da289947c29d


How to change border color for the entire menu?

Is there a way to change border color for the entire menu?

the same project @kolyvan

Is there way to scrolling ?


Refactored tests rules in order for time out to give K3po diffs

@dpwspoon Please align the code with https://github.com/kaazing-private/gateway.server/pull/70 (similar change you did for gateway.server 4.0)


Mock Consumer ignoring config

As thing stand today, the mock Consumer object ignores the Config object passed to it via the NewConsumer constructor. This is expected behavior as documented here.
I am wondering whether:

There is a specific reason for this decision.
You would be interested in a patch that treats the conf argument the same way NewClient does.

IIRC we just couldn't think of any config values that would influence the way the mock consumer actually behaved in practice when we wrote it. It's quite possible we've added some since then. Which ones in particular are you thinking of?

I'm writing a unit test where it would be extremely helpful for me to set ChannelBufferSize to 0 to make it the pc.messages channel unbuffered.

That is already respected: https://github.com/Shopify/sarama/blob/61ca52d100f625ec7d4762c8ea0dda195cd035f1/mocks/consumer.go#L99 I think the documentation might just be out of date.

But this is reading the config object that is created internally here right? So I don't have a means to edit it. Am I missing something?

That's only created if the config you pass in as an argument is nil. If you pass in a valid config it will use that instead.

Ugh, I am obviously blind. Thanks for this — and the quick response.

(Will update the documentation with a patch.)

See: https://github.com/Shopify/sarama/pull/891


accessibility test meetsGuideline(textContrastGuideline) throws on web

This issues surfaced in a pre-submit test: https://cirrus-ci.com/task/4889346271870976
Repro code:
flutter test --platform=chrome test/cupertino/button_test.dart
      await tester.pumpWidget(
        CupertinoApp(
          theme: const CupertinoThemeData(brightness: Brightness.dark),
          home: CupertinoPageScaffold(
            child: CupertinoButton.filled(
              child: const Text('Button'),
              onPressed: () {},
            ),
          )
        ),
      );

      await expectLater(tester, meetsGuideline(textContrastGuideline));

Stacktrace
══╡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK ╞════════════════════════════════════════════════════                                                                                [85/1869]
The following _Exception was thrown while running async test code:
Exception: Incorrect sequence of push/pop operations while building scene surfaces. After building
the scene the persisted surface stack must contain a single element which corresponds to the scene
itself (_PersistedScene). All other surfaces should have been popped off the stack. Found the
following surfaces in the stack:
PersistedScene, PersistedTransform

When the exception was thrown, this was the stack:
package:dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/errors.dart 194:49      throw_
package:build_web_compilers/lib/_engine/engine/surface/scene_builder.dart 26:9            <fn>
package:build_web_compilers/lib/_engine/engine/surface/scene_builder.dart 33:14           get [_persistedScene]
package:build_web_compilers/lib/_engine/engine/surface/scene_builder.dart 464:21          build
package:flutter/src/rendering/layer.dart 767:35                                           buildScene
package:flutter/src/rendering/layer.dart 1196:28                                          toImage
package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 84:54                runBody
package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 123:12               _async
package:flutter/src/rendering/layer.dart 1185:27                                          toImage
package:flutter_test/src/accessibility.dart 204:26                                        <fn>
package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 84:54                runBody
package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 123:12               _async
package:flutter_test/src/accessibility.dart 201:71                                        <fn>
package:flutter_test/src/binding.dart 923:10                                              <fn>
package:dart-sdk/lib/async/zone.dart 1124:13                                              _rootRun
package:dart-sdk/lib/async/zone.dart 1021:19                                              run
package:flutter_test/src/binding.dart 913:25                                              runAsync
package:flutter_test/src/accessibility.dart 201:43                                        evaluate
package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 84:54                runBody
package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 123:12               _async
package:flutter_test/src/accessibility.dart 196:30                                        evaluate
package:flutter_test/src/matchers.dart 1973:47                                            matchAsync
package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 84:54                runBody
package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 123:12               _async
package:flutter_test/src/matchers.dart 1972:28                                            matchAsync
package:test_api/src/frontend/expect.dart 116:25                                          _expect
package:test_api/src/frontend/expect.dart 75:5                                            expectLater
package:flutter_test/src/widget_tester.dart 269:13                                        expectLater
button_test.dart 100:13                                                                   <fn>
package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 45:50                onValue
package:stack_trace/src/stack_zone_specification.dart 129:26                              <fn>
package:stack_trace/src/stack_zone_specification.dart 209:15                              [_run]
package:stack_trace/src/stack_zone_specification.dart 129:14                              <fn>
package:dart-sdk/lib/async/zone.dart 1132:38                                              _rootRunUnary
package:dart-sdk/lib/async/zone.dart 1029:19                                              runUnary
package:dart-sdk/lib/async/future_impl.dart 137:18                                        handleValue
package:dart-sdk/lib/async/future_impl.dart 678:44                                        handleValueCallback
package:dart-sdk/lib/async/future_impl.dart 707:32                                        _propagateToListeners
package:dart-sdk/lib/async/future_impl.dart 522:5                                         [_completeWithValue]
package:dart-sdk/lib/async/future_impl.dart 552:7                                         <fn>
package:dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/operations.dart 324:14  _checkAndCall
package:dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/operations.dart 329:39  dcall
package:quiver/testing/src/async/fake_async.dart 268:32                                   [_drainMicrotasks]
package:quiver/testing/src/async/fake_async.dart 164:5                                    flushMicrotasks
package:flutter_test/src/binding.dart 1067:16                                             <fn>
package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 84:54                runBody
package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 123:12               _async
package:flutter_test/src/binding.dart 1055:35                                             <fn>
package:dart-sdk/lib/async/future.dart 200:37                                             <fn>
package:stack_trace/src/stack_zone_specification.dart 209:15                              [_run]
package:stack_trace/src/stack_zone_specification.dart 119:48                              <fn>
package:dart-sdk/lib/async/zone.dart 1120:38                                              _rootRun
package:dart-sdk/lib/async/zone.dart 1021:19                                              run
package:dart-sdk/lib/async/zone.dart 923:7                                                runGuarded
package:dart-sdk/lib/async/zone.dart 963:23                                               <fn>
package:stack_trace/src/stack_zone_specification.dart 209:15                              [_run]
package:stack_trace/src/stack_zone_specification.dart 119:48                              <fn>
package:dart-sdk/lib/async/zone.dart 1124:13                                              _rootRun
package:dart-sdk/lib/async/zone.dart 1021:19                                              run
package:dart-sdk/lib/async/zone.dart 923:7                                                runGuarded
package:dart-sdk/lib/async/zone.dart 963:23                                               callback
package:dart-sdk/lib/async/schedule_microtask.dart 41:11                                  _microtaskLoop
package:dart-sdk/lib/async/schedule_microtask.dart 50:5                                   _startMicrotaskLoop
package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 166:15               <fn>

Version
[✓] Flutter (Channel unknown, v1.10.7-pre.107, on Linux, locale en_US.UTF-8)
    • Flutter version 1.10.7-pre.107
    • Framework revision 2affe5ba7c (3 days ago), 2019-11-01 16:07:20 -0700
    • Engine revision 8ea19b1c76
    • Dart version 2.6.0 (build 2.6.0-dev.8.2 bbe2ac28c9)

Here is another example of where this bug is present: https://github.com/flutter/flutter/blob/45c5250825b07d639a30bca39709b81f6b56c12d/packages/flutter/test/material/raised_button_test.dart#L134


Debug docs

Coverage remained the same at 60.665% when pulling ec9e1c0dd08d9ab8a0ad85bd4987c94b7cd78952 on jtschladen:fix-docs into 3049fa658500b7fbfa07425bfc41c945924078cd on Netflix:master.


[BUG] cis benchmark chart v2.1.2-rc1 fails to install on RKE1 hardened cluster v1.24.10.

Rancher Server Setup

Rancher version: v2.6.11
Installation option (Docker install/Helm Chart): Helm Chart

If Helm Chart, Kubernetes Cluster and version (RKE1, RKE2, k3s, EKS, etc): RKE1

Proxy/Cert Details: Self Signed

Information about the Cluster

Kubernetes version: v1.24.10-rancher4-1
Cluster Type (Local/Downstream): Downstream

If downstream, what type of cluster? (Custom/Imported or specify provider for Hosted/Infrastructure Provider):

User Information

What is the role of the user logged in?  Admin

Describe the bug

CIS Benchmark chart v2.1.2-rc1 fails to install on k8s v1.24.10-rancher4-1.
To Reproduce

Create a rancher HA server v2.6.11.
Provision a hardened downstream k8s cluster v1.24.10-rancher4-1. Follow the hardening guide here.
Install a CIS Benchmark chart from dev-v2.6 branch of rancher/charts repository.

Result
CIS Benchmark chart fails to install successfully.
patch-sa pod fails with following error.
Error: container has runAsNonRoot and image will run as root (pod: "patch-sa-c756t_cis-operator-system(0d04085d-6496-4aaa-b9eb-72447407a51f)", container: sa)
Expected Result
CIS benchmark chart installs successfully.
Screenshots

Additional context
CIS Benchmark chart fails to install.

Tested the issue on rancher v2.6.11 and downstream cluster v1.24.10-rancher4-1
Testing steps

Created a rancher HA server v2.6.11.
Provisioned a hardened downstream k8s cluster v1.24.10-rancher4-1. Follow the hardening guide here.
Installed a CIS Benchmark chart v2.1.2-rc2 from dev-v2.6 branch of rancher/charts repository.
CIS-Branchmark chart installed successfully. Hence closing the issue.


Refactor contract detail

Context information
application version:
device:
browser:
operating system:
Steps to reproduce
GO to contract detail
see in narrow view

also examine different entities details.
What is expected?
The information does not overflow the container
What is actually happening?

possible resolution
https://github.com/aeternity/aescan/issues/786
The problem is too much text on one line.


[action] register_devices: Fastlane rejects new device id for iPhone XS

New Issue Checklist

[x] Updated fastlane to the latest version
[x] I read the Contribution Guidelines
[x] I read docs.fastlane.tools
[ ] I searched for existing GitHub issues

Issue Description

Complete output when running fastlane, including the stack trace and command used

[INSERT OUTPUT HERE]

Environment

[INSERT OUTPUT HERE]

@halleynora Heyyyyyy 👋 Can you private more details (output of your fastlane execution) and your fastlane env? Thanks!

Happy New Year @joshdholtz - sorry for the delay on this.  Let me clean the log a bit and will send you the info shortly

Attempting to add a device for iPhone XS with the following uuid format:
00008020-00142XXXXXXXXXXX        TL iPhone XS
Based on a couple apple support articles:
https://forums.developer.apple.com/thread/108871
https://forums.developer.apple.com/thread/108848
let me know if you need anything else.. Thanks!
[18:38:16]: --- Step: register_devices ---
[18:38:16]: ------------------------------
Available session is not valid any more. Continuing with normal login.
[18:38:18]: Fetching list of currently registered devices...
+------------------+---------------------+
|              Lane Context              |
+------------------+---------------------+
| DEFAULT_PLATFORM | ios                 |
| PLATFORM_NAME    | ios                 |
| LANE_NAME        | ios ****_distrib |
| VERSION_NUMBER   | 1.0.0               |
+------------------+---------------------+
[18:38:18]: Invalid device line, please provide a file according to the Apple Sample UDID file (http://devimages.apple.com/downloads/devices/Multiple-Upload-Samples.zip)
+------+-------------------------------------------------+-------------+
|                           fastlane summary                           |
+------+-------------------------------------------------+-------------+
| Step | Action                                          | Time (in s) |
+------+-------------------------------------------------+-------------+
| 1    | Verifying fastlane version                      | 0           |
| 2    | default_platform                                | 0           |
| 3    | xcversion                                       | 1           |
| 4    | Switch to ios verify_version_number lane        | 0           |
| 5    | Switch to ios verify_version_number_common lane | 0           |
| 6    | get_version_number                              | 0           |
| 7    | Switch to ios register_test_devices lane        | 0           |
| 💥   | register_devices                                | 2           |
+------+-------------------------------------------------+-------------+
[18:38:18]: fastlane finished with errors
[!] Invalid device line, please provide a file according to the Apple Sample UDID file (http://devimages.apple.com/downloads/devices/Multiple-Upload-Samples.zip)
[18:38:18]: WARNING: fastlane requires your locale to be set to UTF-8. To learn more go to https://docs.fastlane.tools/getting-started/ios/setup/#set-up-environment-variables

I upgraded to the latest and this is still a issue.


Pull Requesto - Eberlya20

So far I have created a branch, created a file and made a commit, and opened a pull request

By Eberlya20


how can i send a request like this select count(*) from account.invoice group by partner_id !! ???

Hi,
Same as you would do it with ORM: call read_group() on invoice model.


Android build error in ionic capacitor

Whenever i build my ionic 3 capacitor app for android i get
E/AccountKitPlugin: java.lang.IllegalArgumentException: Can only use lower 16 bits for requestCode
at
android.support.v4.app.BaseFragmentActivityApi14.checkForValidRequestCode(BaseFragmentActivityApi14.java:79)
at android.support.v4.app.FragmentActivity.startActivityForResult(FragmentActivity.java:748)
at org.apache.cordova.CordovaInterfaceImpl.startActivityForResult(CordovaInterfaceImpl.java:68)
at org.apache.cordova.facebook.AccountKitPlugin.executeLogin(AccountKitPlugin.java:136)
at org.apache.cordova.facebook.AccountKitPlugin$1.run(AccountKitPlugin.java:56)

I need an answer on this please can anybody from the accountkit team help

You have to change this number to be a bit smaller https://github.com/gurisko/cordova-plugin-accountkit/blob/master/src/android/AccountKitPlugin.java#L31

I have reduced it to 65530 but it didn't work.
Please try and fix it please if possible please

I fixed it for android works wonderfully

Linking PR https://github.com/gurisko/cordova-plugin-accountkit/pull/64

Thanks
On Wednesday, June 26, 2019, 02:09:23 PM GMT+1, jcesarmobile<EMAIL_ADDRESS>wrote:
Linking PR #64
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.


require latest underscore.string

fixes https://github.com/zimme/meteor-iron-router-active/issues/18 by exporting 's'
see underscore.string changelog: https://github.com/epeli/underscore.string/blob/master/CHANGELOG.markdown#300

Thank you for this.
I've fixed the issue the same way you did when I saw this so I'm closing this as I've already released 1.0.4.


Updated Object Storage Class

We recently updated the connector and as of S3 connector version 5.3.0 we support all S3 Storage classes.
You may refer to https://www.mulesoft.org/jira/browse/SE-11149 for more details.

We recently updated the connector and as of S3 connector version 5.3.0 we support all S3 Storage classes.
You may refer to https://www.mulesoft.org/jira/browse/SE-11149 for more details.

Goes with https://github.com/mulesoft/docs-release-notes/pull/491 and associated S3 5.3.0 PRs.


Update sbt-github-actions to 0.14.2

Updates com.codecommit:sbt-github-actions from 0.13.0 to 0.14.2.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.codecommit", artifactId = "sbt-github-actions" } ]

labels: sbt-plugin-update, early-semver-major, semver-spec-minor

Manually upgrading this.

Fixed in https://github.com/Banno/vault4s/commit/06d1a35c83fc035b79acbdd7e9f6d2b229d9b641


Display which modifications were added

For gptmd, output statistics of the kinds of modifications added to the database. E.g. 200 phosphorylations, 100 methylations, etc.
For searches, output in a similar format, the modifications found in the 1% FDR target psms.

The search output is done. Need to implement output for gptmd.
Also, need to resolve the non-found N6-acetyllysine, N6-succinyllysine, 4-hydroxyproline.

Done in https://github.com/smith-chem-wisc/MetaMorpheus/commit/0debc4302cdf5844dc33d991b526a6570f343821


nheko: add WebP support

Add “qtimageformats” dependency that provides “libqwebp.so”.

Motivation for this change
WebP images are not recognized in nheko.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

How did you find out this package is needed for this feature? The build log doesn't mention this as an optional dependency:
https://hydra.nixos.org/log/6mrbds63glakfhv2m2qr8i41hsz2g13q-nheko-0.9.0.drv . Speaking of optional dependencies, it seems https://github.com/Nheko-Reborn/qt-jdenticon is an optional dependency according to the releases notes.

@doronbehar I was trying to find out why WebP are not recognized in Qt applications. Both in #nheko:nheko.im and<EMAIL_ADDRESS>I’ve been recommended to try this qtimageformats package. I tried it and it works:

https://github.com/unclechu/nixos-config/commit/e5e0397c8d8e77727a98c0eeebf49e35544087b3
https://github.com/unclechu/nixos-config/commit/c9e5e17198bc25aeccf43bd8d7621f6e8cb7e596

Could you also test if you can add https://github.com/Nheko-Reborn/qt-jdenticon as well to the dependencies?

@doronbehar Let’s maybe do this in another merge request? This is only about adding webp support, this definition does not include supporting of jdenticons. Also since there is no this library yet in nixpkgs the change would be significantly bigger comparing to this two-lines change.

@doronbehar Here is another separate merge request that adds identicons support for Nheko: https://github.com/NixOS/nixpkgs/pull/150487


JS 0.4.0 compatibility

Could anyone help with upgrading prql-vscode to prql-js 0.4.0? We're getting a lot of errors here, from https://github.com/PRQL/prql-vscode/pull/29.
I could probably struggle through with my pedestrian JS, but the API has changed quite significantly — SourceLocation is no longer a top-level attribute, so if anyone is up for helping, that would be very welcome.

Fixed by https://github.com/PRQL/prql-vscode/pull/29, thanks to @aljazerzen ...

Though @aljazerzen if you want to reopen to track promoting that to prql-js please feel free. I don't have much JS context, but that looked like lots of work for the typical consumer of prql-js. That could be a Good First Issue?
(Any thoughts from @mklopets on the JS interface?)


Refine test in set_module_tensor_to_device

Some tensors end up not being set with the recent changes in set_module_tensor_to_device. This should fix the issue.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


Mrchem exercises

Draft of laptop and HCP MRChem exercises.

Running the program should be just
export OMP_NUM_THRADS=16
mrchem jobname.inp

this will write to jobname.out silently in the background. You can have it printed to the screen with
export OMP_NUM_THRADS=16
mrchem --stdout jobname.inp

then it won't write the out file

Perhaps I should give some more details on the defaults of the SCF and response thresholds, so that they don't mess that up :P


Modifying any lib file under the .pioenvs affects the original

To replicate-:
1.Modify any .h or .cpp file of any libs you are using under the .pioenvs folder
2.Delete the .pioenvs folder
3.Trigger a build again
Expected - Platformio should fetch the lib files from the repositories again
Actual - Old modified libs are pulled back into the .pioenvs and build keeps failing in case something was wrongly modified.
Also noticed,if you keep any file open and the editor crashes,the files are sometimes truncated and the contents lost,this compounds the effects of the above issue.

.pioenvs is temporary directory. Don't edit code within it.


Migrate scripts to PlutusV2 to, use serializeData and benchmark tx-cost

Closed by creating draft PR #355


Some devices don't find (No device found.)

Now i have noch problem with the acoount refresh (250s).
But from my devices only 1 from 2 climate device found. Also the heatpump is found. But 2 from 2 Lossnays devices are not found. I try to install a fresh installation but the problem is the same.
The last 4 month i have no problem. The last version without a problem was 14.5

#68

fixed in beta.38


Display console kogs

Can this insight display console.logs from the application?

@olawalejuwonm Yes, absolutely. You can use the .setAutoCollectConsole(true, true) configuration option to receive logs telemetry from your console.log statements. Note that by default, the SDK will only collect winston and bunyan third-party logs, so make sure to set the configuration option mentioned above.

Thank you. Is this an open source tool? Or I need to pay to use it?
On Wed, Mar 6, 2024 at 2:10 AM Jackson Weber @.***>
wrote:

@olawalejuwonm https://github.com/olawalejuwonm Yes, absolutely. You
can use the .setAutoCollectConsole(true, true) configuration option to
receive logs telemetry from your console.log statements. Note that by
default, the SDK will only collect winston and bunyan third-party logs,
so make sure to set the configuration option mentioned above.
—
Reply to this email directly, view it on GitHub
https://github.com/microsoft/ApplicationInsights-node.js/issues/1291#issuecomment-1979901050,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AMSQ2BDL6GTSAMRILNWCWZ3YWZUHFAVCNFSM6AAAAABD54GRKKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZZHEYDCMBVGA
.
You are receiving this because you were mentioned.Message ID:
@.***>

@olawalejuwonm I invite you to read our software license for the SDK here: https://github.com/microsoft/ApplicationInsights-node.js/blob/develop/LICENSE.
If you're looking to collect output telemetry from the SDK in Azure and want to determine pricing structure, that information is available here: https://azure.microsoft.com/en-us/pricing/details/monitor/.


[ENH][TST] more advanced metadata string operations filtering with $like and $nlike operators

More advanced string filtering for Metadata with $like and $nlike operators.
I needed to be able to filter results based on if some metadata fields contained a certain substring,
however chroma's string filtering for metadata was too limited.
Therefore, I modified the library to allow for usable $like and $nlike operators
that can be used with any Collection's get,query,and delete methods.
Description of changes
Added $like and $nlike operands for where kwarg filtering

Improvements & Bug fixes

...

New functionality

The ability to include the "$like" and "$nlike" operators with the where kwarg.
Typing for these two new operators has been added to chromadb/types.py
These operands are meant to be used with "%" and "_" wildcard operators.
operands throw an error if you attempt to use them with a non string value.
added new tests for evaluating the "$like" operator and "$nlike" operators.

Example usage
collection=chromaclient.get_collection('example_collection')
results=collection.get(where={"string_value": {"$like": "%example%"}})

Test plan
How are these changes tested?

[x] Tests pass locally with pytest for python, yarn test for js

Documentation Changes
Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?
Mild documentation changes will be required.

@CrosswaveOmega, this is awesome. Are you familiar with the hypothesis framework? The reason for asking is that, ideally, we want property tests that verify various (statistical) properties of querying with filters. Have a look here:
https://github.com/chroma-core/chroma/pull/1081/files#diff-403dd784c71c55196b6483bc3977c92f24a327a20b3d73429c1ba9a99ef9ef43

chromadb/test/property/strategies.py
chromadb/test/property/test_filtering.py

@tazarov I am not familiar with the hypothesis framework, though I can learn it if needed.
What statistical properties would need to be verified in the case of the like operator?

I think it may be nice to match the $contains syntax of the where_document clause. And @tazarov had been working on supporting $not.

Initially, the plan was to simply match the $contains syntax from the where_document clause, until I noticed that one of the tests for validation was for ensuring that $contains couldn't be used in this context.  Which is why I chose to use $like and $nlike instead, since I could use wildcard characters that way.
I actually haven't noticed any index related speed issues yet while testing, though I'm pretty sure that's because my sqlite version has automatic indexing on by default.  If need be, a special index creation method could be implemented.

I reviewed the hypothesis framework and implemented a variant of the metadata filtering tests for $like/$nlike.
Because $like is filtering based on a substring, additional metadata keys are added to the known_metadata_keys, and are populated with random combinations of the known_document_keywords (as to not add yet another set of known keywords to the collection test object.)
to verify statistical from queries utilizing the $like and $nlike

ensuring that this PR remains compatible with the changes in main.

@CrosswaveOmega just checking in if you plan to continue here :)

Implemented the nitpicks brought up by @tazarov after consideration.
@jeffchuber I do plan on continuing here.

I'm not sure what else should be done for this pr.
Is there anything else in particular I should focus on before a final review & merge?

Waiting for this to be merged

Any chance of getting this merged? The lack of a 'like' operator in default Chroma is really holding us back.

I've updated the tests based on the feedback by @tazarov, including the case sensitive $like.

Hi, any idea then this great feature could be merged? I think we all need it so muuuch :D

When will this awesome feature be merged^_^

Hi all, is there still interest in proceeding with this pull request? Is it normal for a pull request to reach a year or so for the Chroma project? (I am just trying to determine the interest in merging this to know whether to keep waiting)

@pevogam I'm still interested in proceeding, though from what I understand it can't be merged yet because like/nlike doesn't work with distributed chroma, and would need to be implemented in the rust backend for distributed chroma.

This is sorely needed feature in Chroma.

Hi all, is there still interest in proceeding with this pull request? Is it normal for a pull request to reach a year or so for the Chroma project? (I am just trying to determine the interest in merging this to know whether to keep waiting)

Just switch to a different vector store. E.g. milvus

Waiting for this to be merged

@pevogam I'm still interested in proceeding, though from what I understand it can't be merged yet because like/nlike doesn't work with distributed chroma, and would need to be implemented in the rust backend for distributed chroma.

@CrosswaveOmega, thanks for the work.  Is there any additional issue related to distributed chroma feature? Maybe we can find out what needs to be done and continue implementing/merging this feature. Any information would be appreciated regarding related issues or tasks

This pull request has already become older than a year, by this point I would assume despite previous arguments that there is not much maintainer interest in it.

@marcoseiza, the challenge here is that this feature needs to be supported across both single and distributed (cloud) Chroma versions. While the implementation in python is relatively straightforward with the sqlite3 supporting it out of the box, it will take time and effort to also include this in the Rust code-base.

Hi @tazarov, what do you think about my argument here? I guess there is some additional dependency across code-bases that I did not consider there.


Turn numberOflines into maxheight for react-dom

What
Since react-dom doesn't know what to do with numberOfLines, for now we're going to use max-height to cut off the remaining text. Maxheight is calculated off of the line-height of the text style.

LGTM!


xorm support replace into feature for mysql 5.7?

xorm support replace into feature.

it's really needed for me.........


Allow a custom changelog format

Q
A

Fixed tickets
#540 #514

License
MIT

A custom changelog format, this is has been on my wish-list for to long, but I finally came-up
with something that solves my (and others) use-cases 😋
Instead of using a risky unreadable format like %nn (what is nn??)
I decided to use a fully-fledged Template engine, Twig to be exact.
But this is just the start, Gush has always been very opinionated about
which format we use for everything (pull-request merge message, changelog).
With this new system this is finally customizable, and performance is not affected
to much (Twig is lazy loaded).
Not only that, I have a great idea about a new feature (for which I will disclose
some more details soon. In short it's about keeping multiple repositories
common files (README, LICENSE, etc.) in sync (like Sonata-Devkit does).
Which will also use Twig for it's templates.

FYI, I did not enable caching as this doesn't work all the to well with String templates 😉


update spark connection to use session builder

This allows the spark driver to utilize the cluster specified in the
spark-submit command, which will make using the radanalytics s2i builder
possible.

lgtm too.


Changing "Photo" image leaves extra files on server

Changing the image property of the ImageModel class from the admin interface leaves a number of files on the server. When the save function is called, it relies on a call to self.clear_cache() to delete the images from the server. However, value of self.image is changes before save is called, which means that it is looking for the images in the wrong place. Rather, it should be using the value of self._old_image.name for calculations.
There is no-doubt a more elegant way to factor the code, but I solved the problem by modifying a portion of the save function in the ImageModel class:
    def save(self, *args, **kwargs):

        image_has_changed = False
        if self._get_pk_val() and (self._old_image != self.image):
            image_has_changed = True

            # ==== BEGIN CHANGES ====

            # Delete base image
            self._old_image.storage.delete(self._old_image.name)

            # Get components of filenames
            cache_path = os.path.join(os.path.dirname(self._old_image.name), "cache")
            old_filename = os.path.basename(force_text(self._old_image.name))
            base, ext = os.path.splitext(old_filename)
            cache = PhotoSizeCache()

            # Loop through file sizes
            for photosize in cache.sizes.values():
                # Get filename & delete files
                size_name = photosize.name
                filename = os.path.join(cache_path,''.join([base, '_', size_name, ext]))
                if self._old_image.storage.exists(filename):
                    self._old_image.storage.delete(filename)

            # ==== END CHANGES ====

        if self.date_taken is None or image_has_changed:
            # Attempt to get the date the photo was taken from the EXIF data.
            try:
                exif_date = self.EXIF(self.image.file).get('EXIF DateTimeOriginal', None)
                if exif_date is not None:
                    d, t = str.split(exif_date.values)
                    year, month, day = d.split(':')
                    hour, minute, second = t.split(':')
                    self.date_taken = datetime(int(year), int(month), int(day),
                                               int(hour), int(minute), int(second))
            except:
                logger.error('Failed to read EXIF DateTimeOriginal', exc_info=True)
        super(ImageModel, self).save(*args, **kwargs)
        self.pre_cache()

Thanks for spotting the bug and taking the time to write a fix! I took your code and modified it slightly, basically tricking clear_cache to operate on the old image:
 new_image = self.image
 self.image = self._old_image
 self.clear_cache()
 self.image = new_image  # Back to the new image.
 self._old_image.storage.delete(self._old_image.name)  # Delete (old) base image.

Could you try this out please? It works for me, I'd just like a second opinion that all is ok :-)

LGTM. I just tried it out on my server and it's a drop-in replacement for mine. Thanks for the quick fix!

I've just committed some code that should fix this - thanks for your help!


Add runbook help for next set of alerts

Adding runbook help for the following alerts,
CephMgrIsAbsent
CephMgrIsMissingReplicas
CephMdsMissingReplicas
CephMonQuorumAtRisk
CephMonQuorumLost
CephMonHighNumberOfLeaderChanges
CephNodeDown
CephOSDCriticallyFull
ObcQuotaObjectsAlert
ObcQuotaBytesExhausedAlert
ObcQuotaObjectsExhausedAlert
ClusterObjectStoreState

Please fix the lint errors in your PR. (run  "hack/markdownlint.sh" in your local branch before commit changes)
Please remove also references to user/email/name/account number<EMAIL_ADDRESS>in the file alerts/openshift-container-storage-operator/helpers/sre-to-engineering-escalation.md

You need also to run the "hack/markdownlint.sh" file and fix all the lint errors in the files:
alerts/openshift-container-storage-operator/helpers/sre-to-engineering-escalation.md:105:1 MD009/no-trailing-spaces Trailing spaces [Expected: 0 or 2; Actual: 4]
alerts/openshift-container-storage-operator/helpers/sre-to-engineering-escalation.md:107:1 MD007/ul-indent Unordered list indentation [Expected: 2; Actual: 4]
alerts/openshift-container-storage-operator/helpers/sre-to-engineering-escalation.md:108:1 MD007/ul-indent Unordered list indentation [Expected: 2; Actual: 4]
alerts/openshift-container-storage-operator/helpers/sre-to-engineering-escalation.md:109:[81](https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_runbooks/146/pull-ci-openshift-runbooks-master-markdownlint/1734113623556493312#1:build-log.txt%3A81) MD013/line-length Line length [Expected: 80; Actual: 174]
alerts/openshift-container-storage-operator/helpers/sre-to-engineering-escalation.md:110:81 MD013/line-length Line length [Expected: 80; Actual: 128]
alerts/openshift-container-storage-operator/helpers/sre-to-engineering-escalation.md:111:81 MD013/line-length Line length [Expected: 80; Actual: 265]
alerts/openshift-container-storage-operator/ObcQuotaBytesExhausedAlert.md:6:81 MD013/line-length Line length [Expected: 80; Actual: 91]
alerts/openshift-container-storage-operator/ObcQuotaBytesExhausedAlert.md:16:81 MD013/line-length Line length [Expected: 80; Actual: 95]
alerts/openshift-container-storage-operator/ObcQuotaObjectsAlert.md:10:81 MD013/line-length Line length [Expected: 80; Actual: 92]
alerts/openshift-container-storage-operator/ObcQuotaObjectsAlert.md:15:81 MD013/line-length Line length [Expected: 80; Actual: 95]
alerts/openshift-container-storage-operator/ObcQuotaObjectsExhausedAlert.md:5:81 MD013/line-length Line length [Expected: 80; Actual: 92]
alerts/openshift-container-storage-operator/ObcQuotaObjectsExhausedAlert.md:14:81 MD013/line-length Line length [Expected: 80; Actual: 95]

Oh! this is a long list.Trying to fix each

Reduced the lint errors to one. @jmolmo , please take a look

Reduced the lint errors to one. @jmolmo , please take a look

Fixed all lint errors

/lgtm


Suggestion - devise module settings in initializer not model

Has anybody brought up why devise modules that affect not only models, are placed in models not initializer?
It is weird that a line in model directly affects routes. Might it not be better to put modules in devise initializer so that instead of
class User < ApplicationRecord
  devise :database_authenticatable, :validatable
end

it would be something like
Devise.setup do |config|
  config.devise_model User, :database_authenticable, :validatable
end

just food for thought

While I would admit the coupling is a bit akward as you noted, the catalyst is the scoping when using multiple models (resource types). The alternative would be having domain requirements (Users are recoverable but Admins are not, etc.) defined away from the Domain Model.

To adress the scoping issue, I propose just model name as the first parameter( as in the example). We don't even need to change that much logic under the hood (as a first step), since it should be possible to inject functionality in models exactly the same way it is done now, just doing it behind the scenes.

Another added bonus, is that this way it is possible to configure devise per-resource-type, as the configuration logic can be scoped to serve a specific resource (for example different unlock strategies, for User and Admin, etc.)

My understanding was that, it actually gets set up via the the devise_for call in the routes file (the right place). In turn, yes, it looks at the  model and detects which modules are loaded and then loads the appropriate (default) routes if not overrides are given.
That said, I think your premise of "a line in model directly affects routes" is incorrect. It is more specifically, a line in routes checks the model (which is configured in the model file) to create routes.
Simply put, the model definition does not create routes, but it informs the creation of routes depending on the modules loaded.

Simply put, the model definition does not create routes, but it informs the creation of routes depending on the modules loaded.

That is correct.

Another added bonus, is that this way it is possible to configure devise per-resource-type, as the configuration logic can be scoped to serve a specific resource (for example different unlock strategies, for User and Admin, etc.)

This would require a bigger change, right? I don't think that simply changing where the code gets injected in the model would also make this possible since some of the configurations are global.

This would require a bigger change, right? I don't think that simply changing where the code gets injected in the model would also make this possible since some of the configurations are global.

Yes, but my suggestion to move the configuration from model to initializer just opens this possibility for future improvements. I do not suggest doing all of this in one go.

Yes, but my suggestion to move the configuration from model to initializer just opens this possibility for future improvements. I do not suggest doing all of this in one go.

I do think the configuration per-resource could be done with the current design too. I understand what you saying about code organization but I'm struggling to see why your proposal would be more flexible than the way it is today.

the method delete_all_data does not actually delete data, it just calls another method.

IMO, that's true. The method delete_all_data has a dependency on the class name SomeModel and its method delete_all_data. By dependency, I mean that this method would have to change whether SomeModel changes its name, the parameters or the name of its own delete_all_data method. But if SomeModel changes its implementation of delete_all_data while keeping the public API the same, then the parent method does not have to change at all.

The 'best practice' in rails-centric libraries is convention over configuration.
The convention (90% use case) is that if someone has a certain module enabled for their devise resource, Recoverable as an example, they also want to have the routes needed to make that work.
If you really need to de-couple these concerns, you may do so at the model and routes level, via overrides to the  `devise_for, respectively.
The initializer is for global-level configuration (in this case global denotes applying to all the devise resources in use). If you want it to apply only to one resource-type, use options in the model or routes definition calls. You can disable creating routes altogether and create them manually if you wish as well.
I would also say as an aside, that it seems the concerns you have with de/coupling may have to do with an approach that doesn't see the library as a container [block box if you will] itself. The fact that devise informs itself through inference (via the model) rather than hard-coded configuration in the routes is just a choice for convenience of testing/implementation and keeping the library DRY.
Do you have a specific use case / failing test case that you can't accomplish with the current form?

No, it was just something that I thought would be a better way of configuring devise when looking for a problem why some devise routes weren't being generated. As I was continuously searching for something in the model itself, I realized that it seems somewhat odd to look for routes config in the model.
This was just to present a potential alternate approach in the configuration. There are no problems or cases that I've come across so far where this approach would fail to deliver. :)

As I was continuously searching for something in the model itself, I realized that it seems somewhat odd to look for routes config in the model.

@LeKristapino That's a fair point, it would be easier to find out how things work. But this kind of change requires work both from maintainers and users of the Gem. We want to make it easier for the users to upgrade to new versions, that's why we'll leave as it is.
Thanks again for bringing this up and for the discussion.


Dynamic LabelContent inside EKImageNoteMessageView

Is your feature request related to a problem? Please describe.
I'd like to display a notification like ;
"4:25mn remaining on your subscription" and the '4:25mn' should be updated every second
Describe the solution you'd like
An update function, like :
banner.update(labelContent content: String) {}
///
Is it possible to do it with the current library ?
Thanks

Hi @charvoa, Sorry, but that is not currently possible. SwiftEntryKit doesn't support that level of customization for its presets, and probably won't be in future.
But - you can fork and customize its presets (or alternatively create your own) to suit your needs.

@huri000 I dont want to open an old ticket, but very curious why this wont ever happen?
Its seems pretty trivial to make things var's instead of lets....

@huri000 bump.

Apologies, @kylebrowning. This seemed to have escaped me.
The data is 'fed' to preset views using their corresponding structures, not directly to the UI properties (e.g labels, images). I don't want to publicly expose UI properties, but I could maybe create a computed property to access labels' text. Let me think it a bit longer.
In the meantime, reopening.

I managed to work around this as follows:
showSignupForm(titleText: "Please fill in your info", by: [.fullName, .mobile, .email, .password], action: {
            if let topController = UIApplication.shared.keyWindow?.rootViewController,
            let view = topController.view.viewWithTag(392) as? EKFormMessageView,
            let scrollView = view.subviews[0] as? UIScrollView,
            let formTitleLabel = scrollView.viewWithTag(200) as? UILabel {
                view.shake(duration: 0.5)
                formTitleLabel.text = "Wrong Email"
            }
  })

Far from an ideal solution - it also required me to set the tags for the titleLabel in the EKFormMessageView and EKFormMessageView itself...just thought I'd drop this here for anyone looking for a quick solution.

Thanks @albert102000  ! Might give it a try this week !

Is there any update on this?


Update comments to remove etcd specificity and minion term

Some quick API clarifications, This was confusing to me this morning,

after looking at the actual etcd entries for nodes, i think these comments describe the situation more precisely .
etcd shouldn't be assumed as the store, since its really the master cache which is providing the data abstraction.

LGTM
But I'm still hoping we go back to minion...

@k8s-bot ok to test


conf files: Preference to command line options

Command line options should have preference over config files, as they
enable quick testing, for instance.
Work has been done on some relevant 'General' options that can be
overriden via command line options, like log verbosity and stats
reporting.

Updated to perform command line parsing in two steps.


[PATTERN] Add number pattern in Java, Pattern48

Description
Task:
for the given input n the following pattern should print (n=5 for the below pattern):
Pattern Image

Filename
Pattern48.java

can I work on this?

Consider this as a work done.

waiting for assignment then I create my pr

ok, @OkelloSam21 you can work on this issue.


Migrating to Next.js

Here I tried to keep most of the site as it was, just migrating to Next.js. But I also cleaned up a few things, removed unused parts. To deploy I would go with Netlify (or Vercel) instead of GitHub pages. Because that would allow us to use the Netlify features for Next.js, including dynamic image resizing.

@ibgreen I cannot add the repo to Netlify myself. It must be done by somebody with the Owner access to the visgl org. Also is there a team on Netlify for visgl already you could add me to? (They have a free plan for open source projects).


added test case "can handle multiple transpiled files with same name"

Here is a test case to illustrate an issue I have found: under certain conditions Builder throws an error Uncaught Error: Mismatched sourcesContent for: amd.js.
The background: I have some AMD code which already uses elements of ES6. I try to gradually migrate it to Builder. I use plugin-babel do to the transpilation, and I need source maps. However with these requirements two files with identical names cause the Builder to hiccup.

I've stepped through this, and I think the issue is in plugin-babel and this PR appears to fix it: systemjs/plugin-babel#71
@guybedford, could you please publish a new release?

@asapach sure I've released plugin-babel 0.0.18. Let me know if that works out ok here.

Yup, now tests pass for me. @arty-name try bumping to 0.0.18 to see if it fixes your issue.

Thank you, @guybedford and @asapach, that has resolved the issue.
Would you like to merge this PR to avoid regressions in the future?

@arty-name sure extra tests can never hurt :) Thanks for your efforts here.

Seems like builds on Node 0.x have failed because of missing module process. Does plugin-babel support these versions?

That's just the plugin support yeah. But 0.12 is EOL anyway so it's not a big deal.


[Security Tooling] Trivy Workflow Failing

Security Tooling Support Request
Tool

[ ] KICS
[ ] Invicti / OWASP ZAP
[ ] GitGuardian
[x] Trivy
[ ] Veracode (initial setup, GitHub integration)

Issue Description
Our Trivy runs have been failing since last week's monday (2023-11-06). If I read the workflow (run) correctly, the action stops with exit code 1 and does not upload the trivy scan.

Please check https://github.com/eclipse-tractusx/puris/pull/83

Solved by https://github.com/eclipse-tractusx/puris/pull/83


RFM - minishift

Current Maintainer

[x] I am the maintainer of the package and wish to pass it to someone else;

Checklist

[x] Issue title starts with 'RFM - '

Existing Package Details
Package URL: https://chocolatey.org/packages/minishift
Package source URL: https://github.com/chocolatey-community/chocolatey-coreteampackages/tree/master/automatic/minishift

I am happy to pick this one up - Chocolatey user name dgalbraith.

I am happy to pick this one up - Chocolatey user name dgalbraith.

Thanks! I've added you as maintainer, please check your email (also the spam folder) for a confirmation message.
I also have one PR pending, don't transfer the package just yet!

Maintainer confirmation accepted.

This package is maintained by the Chocolatey Community Chocolatey Packages repository. I've removed the other maintainers and will close this issue.


Form $dirty and $valid broken with fields inside tabs

I'm not sure if this is an implementation issue on my end, or a bug with the tabs directive, but I've asked around and most responses I've gotten seem to indicate it might be the latter.
When form fields are inside tabs, and that tabset is nested inside a <form>, the form's $dirty and $valid properties are not affected by the field(s) inside the tabset.
Plunkr here: http://plunker.co/edit/dCSE1jyLYIWY342mQfAl?p=preview

Is this fixed with angular 2 because I face this problem.


Extensibility: Details view: Hide key if the value is empty from panels

Description
I want to be able to hide the full entries from panels or other components when the value is empty. So instead of showing a key with an empty value to the right side, it would not show the key at all. I've attached 2 screenshots below to explain what I mean:
Current

Wanted

Reasons
We want to hide fields which are empty and not relevant to the user when viewing our resources. There is also the case that we have fields which are mutually exclusive so that only one of the two will ever be there and we want to only display the relevant one.

After a second thought I believe it would be even more useful if the visibility can be also controlled through a field in the definition. Then if the field supports JSONata like formula does, it would be possible to write custom logic that will return true/false and decide if the field is visible.


Doesn't work with Yarn

After cloning the project, I ran:
yarn
yarn dev

When loaded the app page in Chrome, the console output:
error - ./node_modules/next/dist/compiled/css-loader/cjs.js??ruleSet[1].rules[2].oneOf[6].use[1]!./node_modules/next/dist/compiled/postcss-loader/cjs.js??ruleSet[1].rules[2].oneOf[6].use[2]!./src/styles/main.css
TypeError: Cannot read property 'theme' of undefined

It's a duplicate actually https://github.com/ixartz/Next-js-Blog-Boilerplate/issues/5
Please add the information about incompatibility with Yarn into the README file.

Hi @kkomelin,
Yes, please use npm instead for the current time being.

Hi @ixartz,
Thanks for your reply.
I've just upgraded Next to 12.0.7 and started receiving the same issue.
Any ideas on how to fix it?

Hi @kkomelin,
I think there is some incompatible dependency when your update package json to the latest version.

For the time being, you might need to keep the package-lock. If I'm not wrong if they're not some much new feature in SSG mode.
I'm planning to totally rewrite this project and add several new features. It was my first open source project and I made some mistakes.
If you need the latest version Next JS 12, I have another project:
https://github.com/ixartz/Next-js-Boilerplate
And add the blog feature from this project.

Thanks @ixartz


Remove nyc_taxis multi client/shard cases and add big5 multi client cases

Description
After analyzing the multi client cases for nyc_taxis, we determined the data from that is not very good as 4/5 operations complete too quickly to get a good picture of resource utilization vs. performance. Instead will use big5 test case as there are longer running operations in that workload. Also removed all multi shard cases.
target_throughput:none depends on change in https://github.com/opensearch-project/opensearch-benchmark-workloads/pull/303
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Tested this on staging endpoint: https://ci-staging.opensearch.org/job/benchmark-test-endpoint/50/parameters/


[BUG] I can't create an account

Describe the bug
When I try to register an account, after confirming that I have saved the PIN code and clicking on the "Confirm" button, the PIN window closes, but nothing else happens. If you click "Create Account" again, it will open the same PIN window again and so on indefinitely. If I try to login with this information, I get an error message saying "Incorrect Username or Password".
Steps to Reproduce
When I try to register an account, after confirming that I have saved the PIN code and clicking on the "Confirm" button, the PIN window closes, but nothing else happens. If you click "Create Account" again, it will open the same PIN window again and so on indefinitely. If I try to login with this information, I get an error message saying "Incorrect Username or Password".
Expected behavior
I was expecting to receive confirmation and log in to my account
Screenshots
No response
Operating System
Windows 11
Hydra Version
2.0.2
Additional Information
No response

Same issue here on Windows 10

Usernames and displayName need to be at least 4 characters long.
We had some bugs that were not showing these information.
If you have any problems creating accounts even after double checking these requirements, join the community discord and ask for help there, it will be easier to aid your exact problem

Closing issue as no response in a long time

I have exactly the same problem. Will there be no solution?


Fix performance regression in normalize operator

Description

In PR #13802 we added additional support for normalize operator and also re-organized with kernel launch/map functionality.
However, PR #13802 introduced performance regression.
In this PR, I fix the performance issue and bring it close to the original performance.
Earlier, I was parallelizing kernel launch based on length (h*w) and hence, there was a significant overhead compared to simple operation being performance in the kernel (x-mean/std)
Main changes in this PR includes - Parallelizing kernel launch based on number of channels rather than length, using omp parallel in the kernel.

Before regressing PR #13802
Total time for 50000 images of shape (3,300,300) to do normalization - 67.39s
Total time for 100000  images of shape (3,300,300) to do normalization - 134.72s
After regressing PR #13802
Total time for 50000 images of shape (3,300,300) to do normalization - 104.09s
Total time for 100000  images of shape (3,300,300) to do normalization - 203.78s
With changes in this PR
Total time for 50000 images of shape (3,300,300) to do normalization - 68.54s
Total time for 100000  images of shape (3,300,300) to do normalization - 136.12s
NOTE I have a revert PR #14054 , just in case, this PR gets delayed to be merged.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.

[X] Changes are complete (i.e. I finished coding on this PR)
[X] All changes have test coverage:
Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
[X] Code is well-documented:
[X] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

Parallelize kernel launch in normalize operator based on channel.

@nswamy @zhreshold @stu1130

@mxnet-label-bot add [pr-awaiting-review, Operator]


Restore the site

Currently the blog is not accessable under  http://journalpanic.com (or elsewhere as far as I could find). It shows this site instead:

It would be cool to have it available again, at least at knowsuchagency.github.io (which is a redirect currently).

Hey, thanks for the interest and for submitting an issue about it!
Yeah, some squatter stole my old domain out from under me and it's taken me forever to get my blog back in order, but it's back now.
The site itself is https://knowsuchagency.com and the repository for it is https://github.com/knowsuchagency/knowsuchagency.github.io
Thanks again @Kaligule!


Changelog: Enable preview mode for reviewing updates before publishing

use Next.js preview mode to retrieve data from the preview endpoint so that users can review entries before publishing

Enabled, URL has been communicated internally


Wasm interpreter for unaligned memory load

In the official test suite address.wast the unaligned memory load give bad results.
We didn't want to regress asm.js which doesn't allow unaligned load so we will have to create a different path for wasm that needs to check the alignment.

Can this be handled using memcpy?

@Cellule I can take care of this one if this is still not done.

@arunetm Sure, if you want to take a stab at it. you can test your fix with address.wast in the official test suite with -nonative vs -forcenative

https://github.com/Microsoft/ChakraCore/pull/1494 fixes this

The PR has been merged. We can mark this one as done.


Fix(#48) draw bugs

Description

fix drawer errors (closing error and share button lifecycle bug)
update drawer detail design
add city and district name to drawer detail

discord username: ssi#9999
closes #48
## Things to check before creating a PR

[ ] I have inspected my topic, checked.
[ ] If it is a core feature, executed detailed tests.

Creating PR rules

[x] PR must be created for an issue with approved tag. Otherwise PR will be rejected.
[x] Relevant issue number: The issue number related to PR must be attached to head of PR header, after prefix after prefix # must be attached in parenthesis. A header like this could be used "prefix(#issue_number): PR header" .
[x] A descriptive and understandable title: The PR title should clearly describe the nature and purpose of the changes. The PR title should be the first thing displayed when the PR is opened. And it should follow the semantic commit rules. For example, a title like "docs(#issueId): Add README.md" can be used.
[x] Related file selection: Only relevant files should be touched and no other files should be affected.
[x] Format and Lint Suitability : The code should be made in accordance with a certain format standard and examined according to the lint rules.
[x] Clean commit history: The commits where the changes are made should be clear and organized.
[x] Opening PR when job is completed: PR should be opened when job is completed and sent for review by other team members.

Changes

[ ] A new feature (a change that adds a new feature, not a breaking change)
[x] A new refactor (a change that is not a breaking change, that improves the readability or performance of the code)
[ ] A breaking change
[ ] Documentation change

New Design

LGTM