XmlComments for references schemas are not generated

I am upgrading from Swashbuckle 3.0 to 5.4.1 and noticed an issue with xml comments for properties referencing another schema.
Using your demo Basic project if I add this type:
 /// <summary>
 /// Product Container Summary
 /// </summary>
 public class ProductContainer
 {
     /// <summary>
     /// Contained Product Summary
     /// </summary>
     public Product ContainedProduct { get; set; }
 }

And change your CrudActionControllers Create method to:
  [HttpPost]
  public ProductContainer Create([FromBody, Required] ProductContainer product)
  {
      return product;
  }

Then the definition in the generated swagger using 3.0 looks like this:
  "ProductContainer": {
    "description": "Product Container Summary",
    "type": "object",
    "properties": {
      "ContainedProduct": {
        "$ref": "#/definitions/Product",
        "description": "Contained Product Summary"
      }
    }
  },

but using 5.4.1 looks like this:
  "ProductContainer": {
    "type": "object",
    "properties": {
      "containedProduct": {
        "$ref": "#/components/schemas/Product"
      }
    },
    "additionalProperties": false,
    "description": "Product Container Summary"
  },

You can see that it has lost the description of ContainedProduct from the ProductContainer class

Long story short, the older version was generating invalid Swagger / OpenAPI JSON, because "reference" schemas should only include the $ref field and no others.
So, with this constraint, how would one provide a description for a property schema that references another schema? Well, the recommended approach is to use the allOf keyword to extend the type-specific schema with additional property-specific metadata (e.g. the property description) as follows:
"properties": {
  "containedProduct": {
    "allOf": [
      { "$ref": "#/components/schemas/Product" }
    ],
    "description": "Contained Product Summary"
  }
}

This way, the property description can be included in addition to the type-specific metadata in the referenced schema. However, it does alter the structure of the generated Swagger / OpenAPI and is therefore supported by Swashbuckle as opt-in behavior via the UseAllOfToExtendReferencedSchemas setting.

Hi
Thanks for the explanation - seems a bit of a strange limitation to have in the spec.
In my use case I have this notion of what an "identifier" looks like, so there is a generic description of this on the Identifier class, but in the specific uses of same I want to be able to describe it as "Identifies the Product" or whatever.   I can't imagine this is an unusual requirements...
The funny thing is that swagger-codegen totally respected the description attribute so if it was incorrect to do so, at least everyone was consistent ;)
I can't see anything in the 2.0 spec that states no other props are allowed (where I can see that in the 3.0 spec) perhaps they weren't strong on that, or just didn't articulate it, or maybe I'm just blind and can't see it...
I see what you mean about {{UseAllOfToExtendReferenceSchemas}} changing the structure of the generated json - I don't think I can go with that unfortunately :/
What I am doing is upgrading a shared library so it can be used with new .NET Core 3.1 apps with OpenAPI3.0 output produced as well as existing .NET Framework apps which output swagger 2.0.   The latter I do not want to introduce any breaking changes but I am struggling a bit to keep the output the same, as in this case.
It would be nice if there was a compatibility option to keep producing things the old way, even if it wasn't quite to spec, but I can understand you might not want to do that.
Is there any way I can force the old behaviour?   Like some kind of "last chance to fiddle with things" hook into the pipeline?
Thanks

@freeranger - unfortunately there is no way to force the old way because it's incorrect. I'm going to close this issue as I don't believe any further action can be feasibly made on the Swashbuckle side.


Always generate gvar table for VFs, even when empty?

We found that Adobe apps like InDesign seem to require a gvar table to show a VF axis slider in the UI. Not sure this is just a bug.
Our use case is a single-source font that contains a lot of alternates that get swapped out along a single axis, no interpolation going on.

if adding an empty gvar table doesn't have other unwanted side effects elsewhere, then we may decide to always add one in varLib.build, to work around issues like these.

Excerpt from the spec:

If a variable font has TrueType outlines in a 'glyf' table, the outline variation data will be provided in the glyph variations ('gvar') table, which is required.

Source: https://docs.microsoft.com/en-us/typography/opentype/spec/otvaroverview#variation-data-tables-and-miscellaneous-requirements

I bet that part of the spec was written before FeatureVariations solidified...
But given that's what's written, we can't really argue against an empty gvar table.

I had missed that part..
I added the code that doesn't output empty gvar in this PR (https://github.com/fonttools/fonttools/pull/1752).
Ok, I guess we should revert to always output empty gvar.


images used in profile repo are linked to other github repos

images used in profile repo are linked to other github repos

use the images from https://github.com/dineshkummarc/dineshkummarc/issues/20


DK release notes are not up to date on docs.chef.io

Description
The DK release notes for 4.7 have not been added to docs.chef.io:
https://docs.chef.io/release_notes_chefdk.html

We are uncertain of how these release notes get ported to the website, but we are okay with doing it manually for the 4.7 release since we do not plan on doing any more ChefDK releases

I didn't see any expeditor config in chef-web-docs or chef-dk that look like these would be automatically updated. We could add some logic to do that, but since we do not plan on releasing ChefDK regularly I decided to just do a one-off fix.


The application terminated with error. Root element is missing.

Hi, I am trying to setup spkl but while executing the  deployment deploy-plugins.bat, getting below error. Did i missed something here?
Error is
Using 'C:\Users\qxw3094\source\repos\Demo.Plugins\packages\spkl.1.0.198\tools\spkl.exe'
spkl Task Runner v<IP_ADDRESS>     Tasks v<IP_ADDRESS>
The application terminated with an error.
Root element is missing.
at System.Xml.XmlTextReaderImpl.Throw(Exception e)
at System.Xml.XmlTextReaderImpl.ParseDocumentContent()
at System.Xml.XmlTextReaderImpl.Read()
at System.Xml.XmlReader.MoveToContent()
at System.Xml.Linq.XElement.Load(XmlReader reader, LoadOptions options)
at System.Xml.Linq.XElement.Load(String uri, LoadOptions options)
at Microsoft.Crm.Sdk.Samples.ServerConnection.ReadConfigurations()
at Microsoft.Crm.Sdk.Samples.ServerConnection.GetServerConfiguration(Boolean ignoreLocalPrincipal)
at SparkleXrmTask.Program.Run(CommandLineArgs arguments)
at SparkleXrmTask.Program.Main(String[] args)
Press any key to continue . . .
Thanks

It looks like it is trying to read the connections file but it is corrupt. Can you try deleting the file at C:\Users<Your User>\AppData\Roaming\CrmServer\Credentials.xml


Canceling msbot clone services leaves an orphan .bot file

Tool
Name: [Msbot|]
Version: 2.0.5-61
OS: Win10
Describe the bug
Running msbot clone services and canceling the operation when asked if like to perform.
msbot clone services -n "YK-ignite-bot1" -f . -l westus --luisAuthoringKey  <keyhere>

The following services will be created by this operation:
 Service                                 Location            SKU                 Resource Group
 Azure App Site Plan                     westus              S1                  YK-ignite-bot1
 Azure Bot Service Registration          Global                                  YK-ignite-bot1
 Azure LUIS Cognitive Service            westus              S0                  YK-ignite-bot1
 Azure WebApp Service (Bot)              westus                                  YK-ignite-bot1
Would you like to perform this operation? [y/n] n
Canceling the operation

PS C:\temp\ignitedemo\BotBuilder-Samples\samples\javascript_nodejs\13.basic-bot\deploymentScripts\msbotClone> ls

Mode                LastWriteTime         Length Name
----                -------------         ------ ----
-a----        9/23/2018   7:38 PM          14398 34.luis
-a----        9/24/2018   8:17 AM            359 bot.recipe
**-a----        9/24/2018   8:13 AM            117 YK-ignite-bot1.bot**

An orphan and not complete .bot file that looks like this
{
    "name": "YK-ignite-bot1",
    "description": "",
    "services": [],
    "padlock": "",
    "version": "2.0"
}

To Reproduce
run msbot clone services and press N to abort operation
Expected behavior
No new artifacts remain after canceling msbot clone services operation
[bug]

Addressed via #804


SPARQL: UNION is ignored if it binds no variables

This query should return two solutions with no variables, but in RDF4J returns only one such solution:
SELECT * {
    {} UNION {}
}

Its behaviour should be the same as this equivalent query, which works fine in RDF4J:
SELECT * {
    VALUES () { () () }
}

It appears that RDF4J simply ignores a UNION that does not bind any variables, even though the UNION can affect the number of results. This can be seen in the following query, which RDF4J evaluates as if the UNION was not there:
SELECT * {
    BIND (1 AS ?a)
    {} UNION {}
}

This is a bug in the QueryModelNormalizer, one of the standard optimizers. It actually deliberately replaces a union with two singleton sets as arguments with a single singleton.


Question: listen to requests

Hi,
Any examples on how homebridge / plugin can listen to an incoming request coming in, to then do something with it.
For example an endpoint on the network will make push a GET to homebridge with a specific query string based on a device doing something, how can homebridge listen for it on an Accessory, to then action off the back of it?  Anyone share how this would look?

I believe what you are asking is, if an event occurs at an accessory/device how can the device tell homebridge about the event, and can HomeKit update the device status with the updated status.  And this is feasible, and a couple of patterns exist.  The plugin could poll the device on regular intervals, and update the status, or the plugin could listen for events from the device, and update the status.
Both patterns are feasible and workable, but would require significant coding by the plugin developer.   If you look at my plugins, I have both patterns.  My homebridge-heyu plugin watches for events and updates HomeKit immediately, and homebridge-tcc plugin polls the thermostat for status every minute, and updates the status.

On Jan 21, 2017, at 10:58 AM, brownad<EMAIL_ADDRESS>wrote:
Hi,
Any examples on how homebridge / plugin can listen to an incoming request coming in, to then do something with it.
For example an endpoint on the network will make push a GET to homebridge with a specific query string based on a device doing something, how can homebridge listen for it on an Accessory, to then action off the back of it? Anyone share how this would look?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Nice one thanks
Sent from my iPhone

On 21 Jan 2017, at 17:54, NorthernMan54<EMAIL_ADDRESS>wrote:
I believe what you are asking is, if an event occurs at an accessory/device how can the device tell homebridge about the event, and can HomeKit update the device status with the updated status. And this is feasible, and a couple of patterns exist. The plugin could poll the device on regular intervals, and update the status, or the plugin could listen for events from the device, and update the status.
Both patterns are feasible and workable, but would require significant coding by the plugin developer. If you look at my plugins, I have both patterns. My homebridge-heyu plugin watches for events and updates HomeKit immediately, and homebridge-tcc plugin polls the thermostat for status every minute, and updates the status.

On Jan 21, 2017, at 10:58 AM, brownad<EMAIL_ADDRESS>wrote:
Hi,
Any examples on how homebridge / plugin can listen to an incoming request coming in, to then do something with it.
For example an endpoint on the network will make push a GET to homebridge with a specific query string based on a device doing something, how can homebridge listen for it on an Accessory, to then action off the back of it? Anyone share how this would look?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

I got some of this working but went with the easy approach of polling continually. It fires off the first event but not subsequent ones. My approach is slightly wrong
Could you suggest how to set the state correctly and reset it please
https://github.com/brownad/homebridge-doorbird/blob/master/index.js
@northernman54
Sent from my iPhone

On 21 Jan 2017, at 17:54, NorthernMan54<EMAIL_ADDRESS>wrote:
I believe what you are asking is, if an event occurs at an accessory/device how can the device tell homebridge about the event, and can HomeKit update the device status with the updated status. And this is feasible, and a couple of patterns exist. The plugin could poll the device on regular intervals, and update the status, or the plugin could listen for events from the device, and update the status.
Both patterns are feasible and workable, but would require significant coding by the plugin developer. If you look at my plugins, I have both patterns. My homebridge-heyu plugin watches for events and updates HomeKit immediately, and homebridge-tcc plugin polls the thermostat for status every minute, and updates the status.

On Jan 21, 2017, at 10:58 AM, brownad<EMAIL_ADDRESS>wrote:
Hi,
Any examples on how homebridge / plugin can listen to an incoming request coming in, to then do something with it.
For example an endpoint on the network will make push a GET to homebridge with a specific query string based on a device doing something, how can homebridge listen for it on an Accessory, to then action off the back of it? Anyone share how this would look?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

I was looking at your code, and is the issue around polling to event or is it with changing the status in homebridge?   At line 58, if you added a self.log line showing binaryState, does it fire correctly?  ( Before the IF )
Also, why are you using setTimeout?
Also, in my TCC plugin, I’m triggering the status update with this
service.getCharacteristic(Characteristic.TargetTemperature).getValue();
And it causes getTemperature to execute, returning the new temperature
In your plugin, the same pattern would trigger
DoorBirdAccessory.prototype.getState
For this to work, binaryState would need to be stored in ‘this’ before getValue is called.
To summarize
polling to event watches for a change, and on change
Take the new binaryState and store it in ‘this' so that DoorBirdAccessory.prototype.getState
can use it to update status.
Then trigger DoorBirdAccessory.prototype.getState
with self.service.getCharacteristic(Characteristic.ProgrammableSwitchEvent).getValue()
The passing around of values with ‘this’ is a bit tricky, in TCC I’m using a global variable called accessory.

On Jan 28, 2017, at 11:13 AM, brownad<EMAIL_ADDRESS>wrote:
I got some of this working but went with the easy approach of polling continually. It fires off the first event but not subsequent ones. My approach is slightly wrong
Could you suggest how to set the state correctly and reset it please
https://github.com/brownad/homebridge-doorbird/blob/master/index.js
@northernman54
Sent from my iPhone

On 21 Jan 2017, at 17:54, NorthernMan54<EMAIL_ADDRESS>wrote:
I believe what you are asking is, if an event occurs at an accessory/device how can the device tell homebridge about the event, and can HomeKit update the device status with the updated status. And this is feasible, and a couple of patterns exist. The plugin could poll the device on regular intervals, and update the status, or the plugin could listen for events from the device, and update the status.
Both patterns are feasible and workable, but would require significant coding by the plugin developer. If you look at my plugins, I have both patterns. My homebridge-heyu plugin watches for events and updates HomeKit immediately, and homebridge-tcc plugin polls the thermostat for status every minute, and updates the status.

On Jan 21, 2017, at 10:58 AM, brownad<EMAIL_ADDRESS>wrote:
Hi,
Any examples on how homebridge / plugin can listen to an incoming request coming in, to then do something with it.
For example an endpoint on the network will make push a GET to homebridge with a specific query string based on a device doing something, how can homebridge listen for it on an Accessory, to then action off the back of it? Anyone share how this would look?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/nfarina/homebridge/issues/1085#issuecomment-275857061, or mute the thread https://github.com/notifications/unsubscribe-auth/AS5CmNLKfpqhSc4C2c_Zj0BB7Zqw2_bBks5rW2k9gaJpZM4LqGp4.

Thanks
I changed it albeit a rough approach to now update the state after it fires. It does work but looks bad in code. So I have it working.
I am suspicious about the notifications stability as it doesn't fire every time as expected I can't work that out. And it's also received on one iOS device and not the other two - any ideas how to push to other devices?
Sent from my iPhone

On 28 Jan 2017, at 17:13, NorthernMan54<EMAIL_ADDRESS>wrote:
I was looking at your code, and is the issue around polling to event or is it with changing the status in homebridge? At line 58, if you added a self.log line showing binaryState, does it fire correctly? ( Before the IF )
Also, why are you using setTimeout?
Also, in my TCC plugin, I’m triggering the status update with this
service.getCharacteristic(Characteristic.TargetTemperature).getValue();
And it causes getTemperature to execute, returning the new temperature
In your plugin, the same pattern would trigger
DoorBirdAccessory.prototype.getState
For this to work, binaryState would need to be stored in ‘this’ before getValue is called.
To summarize
polling to event watches for a change, and on change
Take the new binaryState and store it in ‘this' so that DoorBirdAccessory.prototype.getState
can use it to update status.
Then trigger DoorBirdAccessory.prototype.getState
with self.service.getCharacteristic(Characteristic.ProgrammableSwitchEvent).getValue()
The passing around of values with ‘this’ is a bit tricky, in TCC I’m using a global variable called accessory.

On Jan 28, 2017, at 11:13 AM, brownad<EMAIL_ADDRESS>wrote:
I got some of this working but went with the easy approach of polling continually. It fires off the first event but not subsequent ones. My approach is slightly wrong
Could you suggest how to set the state correctly and reset it please
https://github.com/brownad/homebridge-doorbird/blob/master/index.js
@northernman54
Sent from my iPhone

On 21 Jan 2017, at 17:54, NorthernMan54<EMAIL_ADDRESS>wrote:
I believe what you are asking is, if an event occurs at an accessory/device how can the device tell homebridge about the event, and can HomeKit update the device status with the updated status. And this is feasible, and a couple of patterns exist. The plugin could poll the device on regular intervals, and update the status, or the plugin could listen for events from the device, and update the status.
Both patterns are feasible and workable, but would require significant coding by the plugin developer. If you look at my plugins, I have both patterns. My homebridge-heyu plugin watches for events and updates HomeKit immediately, and homebridge-tcc plugin polls the thermostat for status every minute, and updates the status.

On Jan 21, 2017, at 10:58 AM, brownad<EMAIL_ADDRESS>wrote:
Hi,
Any examples on how homebridge / plugin can listen to an incoming request coming in, to then do something with it.
For example an endpoint on the network will make push a GET to homebridge with a specific query string based on a device doing something, how can homebridge listen for it on an Accessory, to then action off the back of it? Anyone share how this would look?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/nfarina/homebridge/issues/1085#issuecomment-275857061, or mute the thread https://github.com/notifications/unsubscribe-auth/AS5CmNLKfpqhSc4C2c_Zj0BB7Zqw2_bBks5rW2k9gaJpZM4LqGp4.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

My setTimeout was incorrect, basically I wanted to stop receiving multiple push events to the user when state was '1' or you'll receive many IOS notifications.  I switched long polling on now about to test it.
Thanks for the feedback I need to go through it properly and clean up any suggestions would help
Sent from my iPhone

On 28 Jan 2017, at 17:13, NorthernMan54<EMAIL_ADDRESS>wrote:
I was looking at your code, and is the issue around polling to event or is it with changing the status in homebridge? At line 58, if you added a self.log line showing binaryState, does it fire correctly? ( Before the IF )
Also, why are you using setTimeout?
Also, in my TCC plugin, I’m triggering the status update with this
service.getCharacteristic(Characteristic.TargetTemperature).getValue();
And it causes getTemperature to execute, returning the new temperature
In your plugin, the same pattern would trigger
DoorBirdAccessory.prototype.getState
For this to work, binaryState would need to be stored in ‘this’ before getValue is called.
To summarize
polling to event watches for a change, and on change
Take the new binaryState and store it in ‘this' so that DoorBirdAccessory.prototype.getState
can use it to update status.
Then trigger DoorBirdAccessory.prototype.getState
with self.service.getCharacteristic(Characteristic.ProgrammableSwitchEvent).getValue()
The passing around of values with ‘this’ is a bit tricky, in TCC I’m using a global variable called accessory.

On Jan 28, 2017, at 11:13 AM, brownad<EMAIL_ADDRESS>wrote:
I got some of this working but went with the easy approach of polling continually. It fires off the first event but not subsequent ones. My approach is slightly wrong
Could you suggest how to set the state correctly and reset it please
https://github.com/brownad/homebridge-doorbird/blob/master/index.js
@northernman54
Sent from my iPhone

On 21 Jan 2017, at 17:54, NorthernMan54<EMAIL_ADDRESS>wrote:
I believe what you are asking is, if an event occurs at an accessory/device how can the device tell homebridge about the event, and can HomeKit update the device status with the updated status. And this is feasible, and a couple of patterns exist. The plugin could poll the device on regular intervals, and update the status, or the plugin could listen for events from the device, and update the status.
Both patterns are feasible and workable, but would require significant coding by the plugin developer. If you look at my plugins, I have both patterns. My homebridge-heyu plugin watches for events and updates HomeKit immediately, and homebridge-tcc plugin polls the thermostat for status every minute, and updates the status.

On Jan 21, 2017, at 10:58 AM, brownad<EMAIL_ADDRESS>wrote:
Hi,
Any examples on how homebridge / plugin can listen to an incoming request coming in, to then do something with it.
For example an endpoint on the network will make push a GET to homebridge with a specific query string based on a device doing something, how can homebridge listen for it on an Accessory, to then action off the back of it? Anyone share how this would look?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/nfarina/homebridge/issues/1085#issuecomment-275857061, or mute the thread https://github.com/notifications/unsubscribe-auth/AS5CmNLKfpqhSc4C2c_Zj0BB7Zqw2_bBks5rW2k9gaJpZM4LqGp4.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

I made a "proof of concept" example in https://github.com/snowdd1/homebridge-cmd
using a UNIX socket approach, so you can simply send a value to the switch to get its state changed in Homekit. No polling, just event driven.
The "getValue()" of the characteristic just returns the last know state, and does not actually ask for a new state, as the characteristic value is supposed to be current, always.
Magic is in those lines https://github.com/snowdd1/homebridge-cmd/blob/master/index.js#L84 and following. You can easily apply the pattern to

Using a TCP socket (ip/port) instead a local UNIX socket (need to for non UNIX OSes)
More parsing functionality (instead of using just 0s and 1s and one socket per characteristic)
Other characteristics. I just took the cmdswitch as basic example, because, it's just basic and simple to understand

Have a look at the last README line to see how to write values to a local UNIX socket.
Good luck!

@snowdd1 that is a very good example, very tight code.
@brownad I don't think your DoorBirdAccessory.prototype.getState function is working correctly, as the variable this.binaryState is never changed during events.  But after reviewing @snowdd1's example I don't think getState is needed.  Try commenting out this block
this.service
.getCharacteristic(Characteristic.ProgrammableSwitchEvent)
.on('get', this.getState.bind(this));
In getServices
Also you may want to review the DEBUG log when events are triggering, to see what messages are passed between homekit and homebridge.


HBASE-24564: Make RS abort call idempotent.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ branch-1 Compile Tests _

+1 :green_heart:
mvninstall
10m 16s
branch-1 passed

+1 :green_heart:
compile
0m 48s
branch-1 passed with JDK v1.8.0_252

+1 :green_heart:
compile
1m  1s
branch-1 passed with JDK v1.7.0_262

+1 :green_heart:
checkstyle
2m  2s
branch-1 passed

+1 :green_heart:
shadedjars
3m  6s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 48s
branch-1 passed with JDK v1.8.0_252

+1 :green_heart:
javadoc
0m 42s
branch-1 passed with JDK v1.7.0_262

+0 :ok:
spotbugs
3m  3s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
2m 59s
branch-1 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m  0s
the patch passed

+1 :green_heart:
compile
0m 41s
the patch passed with JDK v1.8.0_252

+1 :green_heart:
javac
0m 41s
the patch passed

+1 :green_heart:
compile
0m 45s
the patch passed with JDK v1.7.0_262

+1 :green_heart:
javac
0m 45s
the patch passed

-1 :x:
checkstyle
1m 36s
hbase-server: The patch generated 3 new + 291 unchanged - 1 fixed = 294 total (was 292)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedjars
2m 52s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
4m 41s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2.

+1 :green_heart:
javadoc
0m 34s
the patch passed with JDK v1.8.0_252

+1 :green_heart:
javadoc
0m 46s
the patch passed with JDK v1.7.0_262

+1 :green_heart:
findbugs
3m 13s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
125m 34s
hbase-server in the patch passed.

+1 :green_heart:
asflicense
0m 37s
The patch does not generate ASF License warnings.

176m 12s

Subsystem
Report/Notes

Docker
Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1911/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1911

JIRA Issue
HBASE-24564

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux f8c82b48faa5 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1911/out/precommit/personality/provided.sh

git revision
branch-1 / 5d64f06

Default Java
1.7.0_262

Multi-JDK versions
/usr/lib/jvm/zulu-8-amd64:1.8.0_252 /usr/lib/jvm/zulu-7-amd64:1.7.0_262

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1911/1/artifact/out/diff-checkstyle-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1911/1/testReport/

Max. process+thread count
4111 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1911/1/console

versions
git=1.9.1 maven=3.0.5 findbugs=3.0.1

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Pushed to branch-1 after fixing checkstyle issues.


[RTC-345] Update JF to 0.1.0-5ef4452

Let me cleanup README and env.samples in a separate PR.
df73512 is deployed on sandbox


Cookies not working with Angularjs client but works with postman over .net core WebAPI

I have AngularJS client connected with ASP.net Core WebAPI (via CORS).I'm storing the value in cookie and passing it from Server to Client. Client doesn't seems to store that cookie, because on subsequent requests i'm not able to find that cookie.
Similar scenario is working fine in Postman. I can see Cookies(1) in Postman
ASP.NET Core WebAPI
Startup.cs
public void ConfigureServices(IServiceCollection services)
{
    ... //other configs goes here
    var corsBuilder = new CorsPolicyBuilder();
        corsBuilder.AllowAnyHeader();
        corsBuilder.AllowAnyMethod();
        corsBuilder.AllowAnyOrigin();
        corsBuilder.AllowCredentials();
        services.AddCors(options =>
        {
            options.AddPolicy("TestCorsPolicy", corsBuilder.Build());
        });
        services.Configure<MvcOptions>(options =>
        {
            options.Filters.Add(new CorsAuthorizationFilterFactory("TestCorsPolicy"));
        });
}
public void Configure(IApplicationBuilder app, IHostingEnvironment env)
{
    var cookiePolicyOptions = new CookiePolicyOptions
        {
            Secure = CookieSecurePolicy.SameAsRequest,
            MinimumSameSitePolicy = SameSiteMode.None
        };
        app.UseCors("TestCorsPolicy");
        app.UseAuthentication();
        app.UseCookiePolicy(cookiePolicyOptions);
        app.UseHttpsRedirection();
        app.UseMvc();
}

Cache Set/Get
HttpContext.Response.Cookies.Append("Key", "-11701", option);  //Set
HttpContext.Request.Cookies["Key"]; //Get

Angular JS - Post Method
this.PostApi = function (rowEntity, apiRoute) {
        var def = $q.defer();
        return $http.post(
            apiRoute,
            JSON.stringify(rowEntity),
            {
                withCredentials: true, // Provided this as well based on another Stackoverflow post
                headers: {
                    'Content-Type': 'application/json',
                    'Authorization': 'Bearer ' + getLocalStorageItem("Token")//getLocalStorage("Token"),
                }
            }).then(
                function (response) {
                    def.resolve(response);
                    return def.promise;
                },
                function (error) {
                    // translate the error
                    if (error.status == "401") {
                        window.location.href = defaults.sessionExpiredURL;
                        def.reject(error);
                        return def.promise;
                    } else {
                        def.reject(error);
                        return def.promise;
                    }
                });
    }

Angular JS - Config
masterApp.config(function ($httpProvider, localStorageServiceProvider) {
        $httpProvider.defaults.withCredentials = true;

    });

API and AngularJS app is deployed behind IIS . I asked my colleague to check with Mobile App, outside of DMZ, and even he is able to get cookies. Seems to be Session is also not working. If either Cookies/Session works, thats fine with me. Thanks

Hi. We're closing this issue as we have heard no response from you for some time now. If you have more details and are encountering this issue please add a new reply and re-open the issue.


get ready for debt market collapse

Hello.
Thanks for this excellent node monitor. How would I add top block and hash rate data to Graphana dashborard?
Fun, exciting, extra data to monitor.

I just pushed a new change which contains a more in-depth exporter. It should have those metrics available. The default dashboard has both of those (if I understand you correctly on hash rate metric)

Thank you! I will try the install this weekend.
What is the best way to upgrade the docker image?
wget and rebuild?

docker-compose -f docker-compose.yaml build or make build in the repo

Here's my error with new docker image:
monerod_grafana | Failed to start grafana. error: migration failed (id = Add index user.login/user.email): attempt to write a readonly database
monerod_grafana | migration failed (id = Add index user.login/user.email): attempt to write a readonly database

If you're okay with deleting your existing Grafana (assuming no custom dashboards, users, settings, panels, etc) you can delete the volume and recreate from scratch:
docker rm -f monerod_grafana
docker volume rm docker-monero-node_grafana
docker-compose up -d

Look at all those sweet sweet graphs. Thanks.


HttpBasicAuth broke Session

Using HttpBasicAuth makes Session unusable, because PHPSESSIONID regenerates to new every request. Authentication is working fine, but session become empty.
Example, adding auth behavior.
class Sync1CModule extends Module {
    public function behaviors() {
    	return [
    		'basicAuth' => [
    			'class' => HttpBasicAuth::class,
    			'auth' => function($username, $password) {
                              ...
    			}
    		]
    	];
    }
}

The reason is in yii\web\User::switchIdentity()
    public function switchIdentity($identity, $duration = 0)
    {
         .................
        $session = Yii::$app->getSession();
        if (!YII_ENV_TEST) {
            $session->regenerateID(true);
        }
       ..................
}

Q
A

Yii version
2.0.13

PHP version
7.0

Operating system
Debian 8

    			'auth' => function($username, $password) {
                              ...
    			}

What's inside?

Not matter.... strcmp username and password.
 $session = Yii::$app->getSession();
        if (!YII_ENV_TEST) {
            $session->regenerateID(true);
        }

destruct session anytime.

Not matter.... strcmp username and password

No, it matters. Please, post the code here

Ok :))))))
$user = UserModel::find()->where(['email' => $username])->one();
return !empty($user) && $user->validatePassword($password) ? $user : null;

So usermodel returned ok, authentication done, so how it prevent yii\web\User from
if (!YII_ENV_TEST) {
            $session->regenerateID(true);
        }

My workaround is to set User::$enableSession to false.

Would you please check if it works with <IP_ADDRESS>?

Already have <IP_ADDRESS>

define('YII_ENV_TEST', true) is also workaround :)))

Would you then please try code from master branch?

ok, 15 minutes, please ...

same result, PHPSESSIONID changes every request.
To resolve this problem temporary I have to turn session off:
\Yii::$app->user->enableSession = false;

https://image.prntscr.com/image/fLdy8MalQcKL3e0mBVTL3A.png

Thank you for the report, fixed.

@dicrtarasov did the fix solve your problem?

Thank you very mutch. Your modification of User component completely fix this problem.


Errors about imput.size[1]

Hello. when I run ' main_single_gpu.py' with rgb frames, I met mistakes as follows:
Traceback (most recent call last):
  File "/home/zxf/Desktop/learn/reference/two-stream-pytorch/main_single_gpu.py", line 357, in <module>
    main()
  File "/home/zxf/Desktop/learn/reference/two-stream-pytorch/main_single_gpu.py", line 182, in main
    train(train_loader, model, criterion, optimizer, epoch)
  File "/home/zxf/Desktop/learn/reference/two-stream-pytorch/main_single_gpu.py", line 229, in train
    output = model(input_var)
  File "/home/zxf/anaconda2/lib/python2.7/site-packages/torch/nn/modules/module.py", line 224, in __call__
    result = self.forward(*input, **kwargs)
  File "/home/zxf/Desktop/learn/reference/two-stream-pytorch/models/rgb_vgg16.py", line 30, in forward
    x = self.features(x)
  File "/home/zxf/anaconda2/lib/python2.7/site-packages/torch/nn/modules/module.py", line 224, in __call__
    result = self.forward(*input, **kwargs)
  File "/home/zxf/anaconda2/lib/python2.7/site-packages/torch/nn/modules/container.py", line 67, in forward
    input = module(input)
  File "/home/zxf/anaconda2/lib/python2.7/site-packages/torch/nn/modules/module.py", line 224, in __call__
    result = self.forward(*input, **kwargs)
  File "/home/zxf/anaconda2/lib/python2.7/site-packages/torch/nn/modules/conv.py", line 254, in forward
    self.padding, self.dilation, self.groups)
  File "/home/zxf/anaconda2/lib/python2.7/site-packages/torch/nn/functional.py", line 52, in conv2d
    return f(input, weight, bias)
RuntimeError: Need input.size[1] == 3 but got 30 instead.

The input.size is  (2L, 30L, 224L, 224L). Every videos' 10 frames are fed to VGG, then the net cannot deal with the input.

I have the same issue, I wonder how solve it?
from the forward function in rgb_vgg16, it need to transform  (2L, 30L, 224L, 224L) into (20, 3, 224, 224), but the code did not do this, so i want to konw how the authers solve it , thanks.

I have read the code, it just can deal with the frms with new_length=1, i do not think it is the good method to handle the actions, when read flow stream, i think it is wrong, when new-length = 15, the input should be (2, 15102,224,224), and transform in to (30,  20, 224, 224), then combine before softmax layer. So that this code just img classification, cannot extract temporal information.

Hi thanks for bringing up the issue. I am out of town now and will debug into it this weekend. It should handle temporal information because I test it when I released the code. Maybe some later commits broke it. Sorry about that, I will fix it asap.

It dosen't matter, but thank you for release the code.

During test the code, I have same issue that the dimension of VGG is not fit.
I hope you solve this problem as soon as possible.
Thanks!

@zswzifir @jangho2001us @Blankit I updated the codebase, hopefully the issue is solved. I didn't notice such error when i run my experiments. So just let me know if the issue still exists.

@bryanyzhu Thanks bryanyzhu. I really appreciate for your prompt action!


dbt run error: Catalog namespace is not supported.

Describe the bug
New dbt project pointing at a databricks cluster without unity catalog
looks like dbt is trying to use it despite deleting the catalog tag from the profile (or setting it to null)
Steps To Reproduce
dbt run
Expected behavior
models built
Screenshots and log output
18:33:42.551967 [debug] [Thread-1 (]: Databricks adapter: <class 'databricks.sql.exc.ServerOperationError'>: Catalog namespace is not supported.
18:33:42.551967 [debug] [Thread-1 (]: Databricks adapter: diagnostic-info: org.apache.hive.service.cli.HiveSQLException: Error running query: org.apache.spark.sql.AnalysisException: Catalog namespace is not supported.
System information
The output of dbt --version:
Core:
  - installed: 1.3.1
  - latest:    1.3.1 - Up to date!

Plugins:
  - databricks: 1.3.2 - Up to date!
  - spark:      1.3.0 - Up to date!

The operating system you're using:
windows 10
The output of python --version:
Python 3.10.8
Additional context
databricks version 10.4 LTS

Yes, please don't specify catalog in the profile if you don't use Unity Catalog.

makes no difference
stanford_genomics:
  outputs:
    prod:
      host: adb-xxxx.2.azuredatabricks.net
      schema: default
      http_path: sql/protocolv1/o/5xxxxxxxx
      threads: 4
      token: xxxxxx
      type: databricks
  target: prod

result is still
18:58:07  Concurrency: 4 threads (target='prod')
18:58:07
18:58:07  1 of 1 START sql view model clinvar.variant_summary_history_dbt ................ [RUN]
18:58:10  1 of 1 ERROR creating sql view model clinvar.variant_summary_history_dbt ....... [ERROR in 2.66s]
18:58:11
18:58:11  Finished running 1 view model in 0 hours 0 minutes and 9.32 seconds (9.32s).
18:58:11
18:58:11  Completed with 1 error and 0 warnings:
18:58:11
18:58:11  Runtime Error in model variant_summary_history_dbt (models\clinvar\variant_summary_history_dbt.sql)
18:58:11    Catalog namespace is not supported.
18:58:11
18:58:11  Done. PASS=0 WARN=0 ERROR=1 SKIP=0 TOTAL=1
```

Could yo double-check the dbt project is pointing the profile above?
I guess it's pointing another profile that includes schema: clinvar.
Could you try dbt debug command?

dbt debug is fine
Using profiles.yml file at C:\Users\jakub\.dbt\profiles.yml
Using dbt_project.yml file at C:\Users\jakub\repos\dbt\stanford_genomics\dbt_project.yml

Configuration:
  profiles.yml file [OK found and valid]
  dbt_project.yml file [OK found and valid]

Required dependencies:
 - git [ERROR]

Connection:
  host: adb-xxxxxxxx.2.azuredatabricks.net
  http_path: sql/protocolv1/o/xxxxxxx
  schema: default
  Connection test: [OK connection ok]

this is a new project so there is only one target in the profile.yml
i'm overriding the schema in the config() for the model. i tried it into the default schema and it didn't work either
{{ config(
    materialized='view',
    schema='clinvar',
)
}}

That's interesting.
Is it possible to share the reproducible model? It doesn't need to include your actual model, but simple enough to reproduce the issue.

oops... user error
my source.yml was bad.. i had a database: node in there... so the source yml was generating a 3 part object.
Thanks for looking into it and sorry for wasting your time!

Got it! No worries, I'm happy to hear the issue was fixed anyway. :)


VLANs: add warning not to use tagged + untagged on the same interface

As recently mentioned by @fichtner [1], you should avoid using a parent interface if it has VLANs. Many users are probably unaware of this limitation (I certainly was), especially since having tagged and untagged frames on the same interface is a very common configuration on other devices.
[1] https://forum.opnsense.org/index.php?topic=22571.msg107332#msg107332

I'm unsure about this, if I'm not mistaken some providers over here in the Netherlands only tag the the voice or data channel and leave the rest untagged. By my knowledge this works, but we just don't recommend doing so to avoid risk (the parent interface can see all traffic, tagged ones only see the targeted part).
Broken switches can lead to very odd behaviour and accidental data leakage, where the risk is smaller if one would only used tagged ports on the same physical link.
I'll leave this open for now, don't mind adding a note that we don't advice combining, but if it technically works we might need to rephrase here.

I thought about this... deriving the complex scenario means a lot of code, but maybe we can push something to the interfaces assignment page and warn users about the choice they made/are making when the parent is already assigned instead of adding a note to a note in bold letters.
IMO this is first and foremost documentation material.

Just a comment. I'm using VLANS in combination with the parent interface without any issue sinse years ago.
My parent interface is rarely used, but I need it to access to ESXi management interface in some cases.
DHCP works fine on all interfaces where enabled, including the parent one.

From how I understood @fichtner, the problem isn't that it "doesn't work" or that you might get in trouble with broken switches. The problem is that it does work, but firewall rules added to the parent might also apply to the VLANs. Which has significant security implications. For example, if the parent is a WAN and you have a VLAN with an 'allow all' rule, your WAN might unintentionally be wide open. And you won't notice ("it works") unless you actually do pen testing.
Did I get that correctly?
Having a dynamic warning on the interface assignment page would be great of course, but I'm currently not up for implementing that. And about having it in the docs: Absolutely, but not exclusively. This is essential, security critical information which belongs in the UI.

It’s the other way around. Untagged interface rules may apply to all tagged ones since pf(4) can read and skip over the VLAN tags on the traffic. It depends on rule ordering and quick/non-quick sequence though.

On 14. Apr 2021, at 15:20, Maurice Walker @.***> wrote:

From how I understood @fichtner, the problem isn't that it "doesn't work" or that you might get in trouble with broken switches. The problem is that it does work, but firewall rules added to the parent might also apply to the VLANs. Which has significant security implications. For example, if the parent is a WAN and you have a VLAN with an 'allow all' rule, your WAN might unintentionally be wide open. And you won't notice ("it works") unless you actually do pen testing.
Did I get that correctly?
Having a dynamic warning on the interface assignment page would be great of course, but I'm currently not up for implementing that. And about having it in the docs: Absolutely, but not exclusively. This is essential, security critical information which belongs in the UI.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

@fichtner You're right, had a brain fart, edited it right after posting. The issue remains: You might unknowingly create a configuration which apparently works, but is insecure.
(You might not believe it, but I actually do have a setup where the native (untagged) VLAN is a LAN while the WAN is on a tagged VLAN. Luckily I'm handling VLANs in Hyper-V, not in OPNsense itself. But I'm sure there's someone out there who does...)

Of course... I didn't catch the potential implications on pf filtering rules.
I've got WAN VLAN handled as separate WAN at the hypervisor, as @maurice-w does on Hyper-V.

We just bought a new DEC3850 for our office and we have ax0/ax1 (the 10G ifaces) as a LAGG towards a Unifi Aggregation Switch and on top of that several VLANs (tagged) for internal LAN, Guests-WiFi etc. and use that LAGG also untagged for Unifi network itself (for adoption, updates, provisioning). So I guess the same issue with pf applies to us as well.
From my point of view a warning would help but in my opinion this should be finally fixed in pf that it does not simply take rules from untagged iface to all vlan ifaces - it makes no sense and vlan ifaces have different names and thus should be handled independently. I see this clearly as a bug in pf.
Since I haven't heard of this odd behaviour before in my career, does anyone know if this also applies to Linux filtering (iptables, nftables?)

@martinseener I think long story short is that it's not a best practice (https://github.com/opnsense/core/pull/4918#issuecomment-819265246) and although it does work in most cases, it can make your debugging experience pretty painful and in rare cases can lead to side affects (which may also be driver specific).
It's would however be quite easy to test the general assumption though, just drop all traffic on the parent and allow all on the child. if the child works (what I expect), it's not a generic "issue", merely something we should advise people to avoid.


Only one sample in train and val

Hi, I have totally 16 labelled images (png + json). But after running the command, there is only one in train and one in val. May I know what has gone wrong? Thank you!

Which version are you using?

0.2.4 Below is the command I used: labelme2yolo --json_dir /Users/xxx/Documents/project/train/

Could you try it with 0.2.0? it might be caused by parallelization.

Would you mind providing some logs, I can't reproduce the issue.

Thanks for the fast response! Just tried. Now I have the 16 images organized into 12 for train and 4 for val. But for the labels, there is still only one txt file.

Versions smaller than 0.2 are more stable, just a lot slower, so maybe you could try that.

Would you mind providing some logs, I can't reproduce the issue.

There is actually no error. My file names are like "a.b.png" and "a.b.json". Could this be the cause?

Would you mind providing some logs, I can't reproduce the issue.

There is actually no error. My file names are like "a.b.png" and "a.b.json". Could this be the cause?

I think this is the issue. I renamed my files to "a.png" and "a.json". Now I get all the outputs correctly. Perhaps the parsing of file names needs to be updated. Thanks again!

Thanks for the feedback, I'll try to fix the issue next.

Thanks for the feedback, I'll try to fix the issue next.

No problem. Great work mate!


Update @chainsafe/snappy-stream to 5.1.2

Update contains this fix:

https://github.com/ChainSafe/node-snappy-stream/pull/17

closing in favor of #5001


[Feature]: add attributes for spectral processing

Guidelines

[X] I agree to follow this project's Contributing Guidelines.

Description
Have been thinking about this for some time. Definitely part of the long term vision but not quite sure when to bring it in. One of the challenges with using spectra is that you can forget what transformations you made to the spectra. For example if you did a derivative transformation and then forgot if it was a first or second derivative you'd be in trouble because you need to identify it using the appropriate library. Another example is if you've transformed the data but forgot how and want to reverse the transformation (sometimes possible sometimes not). Obviously the best way for a user to manage this is to code everything and version control their code so they always have the raw data and the cleaned data, but sometimes things get lost so I totally get it.
Problem
Keeping track of processing steps for spectra is hard.
Proposed Solution
I think we could add attributes that describe how spectra are processed to the OpenSpecy object type. These attributes could have special functions that we hit them with, one could be that the user can provide a suite of attributes to the OpenSpecy object and then it will use those attributes to process the spectra. Another could be to reverse the attributes to get as close to the raw spectra as possible. Another could be to try and merge two OpenSpecy objects using similarities in their attributes. Let me know what you think @zachar
Alternatives Considered
Create separate metadata object types that store common processing operations.

Yeah, why not! I would maybe keep this simple in the beginning since a well written R script should take care of this anyway.

Agreed, maybe slowly start supporting it in the background mostly just to send the user helpful warnings then start to support autocorrection of the issues.

Along these lines, also thinking we could control some of the metadata values a little better. We could add checks for metadata variables. W.g. xy need to be distinct, col_id needs to be the same as the spectrum names. Need to have xy and col_id in metadata... I worry though that people may have alternative intended uses for the metadata values that we are currently not considering. Can let that simmer for a while.

Sketching this out for things that could be useful to keep track of:
Intensity Unit Options: Absorbance, Transmittance, Reflectance
Derivative Order: Deriv_0, Deriv_1, Deriv_2
Baseline Options: Raw, No_Baseline
Spectra Type: FTIR, Raman
Looks like to initialize or update we can just add this to the OpenSpecy for each.
attr(obj, "intensity_unit") <- NULL
Then we can retrieve the value with attr(obj, "intensity_unit") and run checks using it.

Have a first pass of this addition added now https://github.com/wincowgerDEV/OpenSpecy-package/pull/157/commits/74e936c9a0164bdeffeebf219c958a976c1bab52
I think we probably want to add in some functionality to updating attributes when it makes sense. For example, if the user does a derivative transformation we can add the order or if they do a baseline transformation we can add that label. Perhaps these could be used to warn people if they try to do something weird like take the 4th derivative or try to remove the baseline on a derivative transformed spectrum or try and baseline correct something that has already been baseline corrected. There are probably other things we can try to catch too.

Sounds good to me! I'll try to have a look at PR #157 as soon as possible.


No edit option for some file types.

No option to edit a .map file type. Make all 'unknown' file types be openable with the text editor by default.

I've already thought about that a while back, but decided not to do it. It will likely result in broken binary files if they are opened as text and then saved (e.g. opening an image and saving it). Even if it is only opened and saved, without modifying anything. That's the reason I chose to only support specific file types.
Do you think the benefits would outweigh this issue? After all the intention of this project is to be a file manager and the goal for the future would be to give the user a "Open with..." option where they could choose an editor of their choice. That's why I tend more towards less but flawless editing features.
I could also just add .map to the list of editable files (https://github.com/Otto-AA/solid-filemanager/blob/e8ec8e3bf64d4b89f9a77c49f37cffd73991797b/src/Api/Item.ts#L67), but this would only resolve this particular use case.


Https SNICallback problem

Using redwire.https(...., .....)  I got an error like the one below on nodejs server.
May you tell me what happen and how to solve the problem ?
I'm using Windows 7 + nodeJs + redwire.
Thanks in advance
Mauro
F:\testProxy\node_modules\redwire\src\certificate-store.js:51
return callback(null, _this._secureContexts[hostname]);
^
TypeError: undefined is not a function
at Object.result.SNICallback [as onselect] (F:\testProxy\node_modules\redwire\src\certificate-store.js:51:18)
at SlabBuffer.use (tls.js:232:18)
at CleartextStream.read [as _read] (tls.js:450:29)
at CleartextStream.Readable.read (_stream_readable.js:320:10)
at callback (tls.js:839:20)
at SecurePair.onclienthello (tls.js:846:5)
at EncryptedStream.write [as _write] (tls.js:357:31)
at doWrite (_stream_writable.js:221:10)
at writeOrBuffer (_stream_writable.js:211:5)
at EncryptedStream.Writable.write (_stream_writable.js:180:11)

Solved.
Just upgrade Node !

I'm glad things worked out. Please let me know if you have any additional issues or questions.


Update _server-sdk-template.mdx

🚀 Deployed on https://66d9f98faeaf6462a70bae1f--cozy-fox-0defec.netlify.app


Additional Of FirewallRules for all cloud providers self-managed ha clusters

Tasks description
Issues
Completed Issue(s)

Fixes #87

Solution
Sub-Tasks

[x] civo (k3s)
[x] civo (kubeadm)
[x] azure (k3s)
[x] azure (kubeadm)
[x] aws (k3s)
[x] aws (kubeadm)

Note to reviewers

[x] Ran Tests locally
[x] Checked Contribution's guidelines

Todo

update testcases for the k3s, kubeadm, k8sdistro
Add test coverage for the firewall.go file to utils_test.go
Update test for consts for the firewall in consts.go
Added Tags to the aws storageDocument (cc @Horiodino)
for cloud provider only test the converter from helpers.FirewallRules -> cloudprovider types

check the kubeadm not working had a change in the private Ip range for joining the conrolplane


Fix/check output bad destination

Final output isn't send to >3&. This PR fix it, allowing to use maven-resource when done checkon concourse.

Thx!


chore(firestore-stripe-payments): cleanup of source files, added prepare build step

Source files no longer need to be included in a repositories directory.
Using an npm prepare scripts the source files can now be generated on build.

[x] Add npm prepare task
[x] Add required dependencies as main dependencies.
[x] Add cleanup dependency
[x] Remove obsolete lib folder

@dackers86 Happy to merge this if you can resolve the conflicts here!

Thanks @jsteele-stripe. Updated!


Suggestion to add App environment

I recognize that the following AppSettings is also valid in App environment.

WEBSITE_DNS_ATTEMPTS : Number of times to try name resolve
WEBSITE_DNS_TIMEOUT :  Number of seconds to wait for name resolve

If I am correct, I would like to have it added to the document, so please let us discuss it.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: f081389e-21ca-4d1a-80e1-d96c13ec1ffb
Version Independent ID: 9d1246c8-bfbf-78af-e87f-4d0dd287da90
Content: Environment variables and app settings reference - Azure App Service
Content Source: articles/app-service/reference-app-settings.md
Service: app-service
GitHub Login: @cephalin
Microsoft Alias: cephalin

@Anno328
Thanks for your feedback! We will investigate and update as appropriate.

@Anno328 We have gone ahead and made a PR of the suggestions. The changes should be public on the doc within 24-48 hours.
We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


Implement default problem matcher and task for running Python files.

Resolves: https://github.com/microsoft/vscode-python/issues/3828
TODO: Check and compare different outputs among Python3.8~3.13.

Make sure errors, outputs are covered across versions that Python extension support.
TODO: Figure out why problem matcher doesnt pick up the error from task when registered in "new Task".
Problem matcher IS able to find exceptions/errors when it is in tasks.json, but does not work when passed as parameter for new Task.

Blocked on https://github.com/microsoft/vscode/issues/225826
Talked to @meganrogge and I think we found a bug.


vim-plug can not show how many plugins neovim loaded

Describe the bug
use vim-plug manage plugins, dashboard always show neovim loaded 0 packages, it works ok with older branch remove-default-header
To Reproduce
Steps to reproduce the behavior:

nvim start neovim dashboard

Expected behavior
show numbers of packages loaded by vim-plug
Screenshots

builtin not support vim-plug. you need custom it.


Added necessary changes as requested  (#123 PR)

This is in continuation with the PR #123 as per the requested changes.
Also please add labels and tags to this PR after review for level, gssoc, haktoberfest.

@770navyasharma please create a separate folder in machine learning named same as the project name as use the same PR template as before don't change it as i have added some workflows and it will work based on that only. Thank you for your cooperation.


Block replication and not just producers

Currently, when the disk is getting full, the quota plugin blocks producers => so it only stops the partitions for which it is a leader. But it does not block replication. So under the right circumstances, producers will be stopped from producing directly into this node. But will keep producing to other partitions with leaders on other nodes and the data will get replicated to the broker with the disk over the limit as well and can make it full.

The idea discussed in the past was to have the plugin just expose the information to CO and the CO would control the quotas both for producers through the plugin but also through replication throttles via Kafka Admin API.

what's CO?

@k-wall Cluster Operator

My 2 cents ...
The ClientQuotaCallback implementations are handled by the ClientQuotaManager in the Kafka broker and it's in charge of handling quotas for clients only (produce, fetch, ...) and not for replica followers.
The Kafka broker has a different component named ReplicationQuotaManager for "internal" handling (without any kind of possible extension via plugin) of the replication throttling via the corresponding dynamic configuration parameter follower.replication.throttled.rate that can be changed, as Jakub mentioned, via the Admin Client API with no need of a broker roll.
Having the current quota plugin doing this configuration would be an hack and it's a solution that I don't like for different reasons:

scope of the plugin and corresponding interface is about clients as already mentioned but ...
... it could be somehow possible instantiating an Admin Client in the plugin even if its configuration would become really problematic. The plugin should have configuration for TLS and even mutual authentication (if you think, for example, that the Strimzi operator does some handling via Admin Client API connecting to the replication port 9091 which has TLS enabled and mutual authentication). Maybe nothing impossible but a real "hack", which I don't like.

Maybe, it's possible I am missing any other good reason so that above "hack" would not work at all.
So, the logic for throttling replication should be somewhere else with plugin providing more information through metrics.
It already exposes JMX metrics for "total storage used bytes" and "soft limit bytes" but it would need some additions:

the broker.id they are referring to (in order to configure replication throttling for that specific broker)
"hard limit bytes" metric in order to allow making better decisions about the throttling

I would say that the quota plugin itself would need the above changes only in order to allow a different component to make decisions about replication throttling.
This component could be the CO, as Jakub mentioned, that:

should be able to scrape metrics from the quota plugin via JMX. It could have somehow same logic of the JMX Exporter that we use today for scraping Kafka JMX metrics and translating into Prometheus format.
it has all the data/information for configuring an Admin Client for connecting to the cluster easily and making the change on a specific broker.

If users are using this quota plugin outside of Strimzi they could anyway use the JMX metrics to allow a software component doing the replication throttling. It's just a matter of providing them the possibility to make decisions via metrics.
@k-wall @scholzj any thoughts on this?

Whatever the solution is, it will probably require a proposal => especially if it would involve the cluster operator for remote configuration.

@Sambarker @robobario I believe this was more or less addressed in your changes to the plugin, right?

Not directly, there can still be replication between brokers but I think blocking replication directly is likely to lead to many subtle and awkward issues.
What we have addressed the core issues and makes replication induced disk problems very unlikely.

Right. But the plugin now blocks producers on all nodes when the disk gets full on one of them and not just on a single node, correct? Which I think mostly addresses this indirectly.
The motivation for this issue was that the old version of the plugin blocked only the producers talking directly to the node running out of disk space but not producers talking to other nodes. So it could have happened that the replication from other nodes filled in the disk anyway. Where as when we block producers on all nodes when just one of them starts getting out of disk space, there should be no new messages going to the cluster and thus not many new data to replicate.

Correct, the quota plugin prevents production on all brokers when any disk fills up and so replication should cease soon after.

Great, thanks.
Closing as this is fixed through blocking producers on all nodes.


Add score token to BeginPlaySession() + store it to state

Prereqs:

[ ] https://github.com/ppy/osu/pull/21588

I fixed a small oversight in 851601cc55aba46e217a9b924f07a1b4c8269114 - scoreToken wasn't being passed to SendAsync() in the sample client.
Looks good otherwise.


Add Support for Link Shortening

Is your feature request related to a problem? Please describe.
You can add a link shortening command to alexis, which can help shorten link without visiting any website.
Describe the solution you'd like
We can use the api of any open-source link shortening service and make an api call with the link to be shortened.
We can also paste the shortened link to user's clipboard.
Describe alternatives you've considered
Alternatively we can route the user to the website itself with the website filled in just to get the shortened link.

I would like to work on this feature as part of hacktoberfest. Assign this request to me if you accept this issue.


Make isNaN(), isFinite(), and isInfinity() work at CTFE

This annoys me frequently. At least one of these three functions is required by practically all floating-point algorithms, so without them nothing works.

@9il What's the decision block label about?
I didn't think there would be anything controversial just about making a few existing functions work at CTFE.

https://github.com/dlang/phobos/pull/2521#issuecomment-56265251

std/math.d(5205): Error: static assert  (!isInfinity(3.40282e+38F)) is false

@9il What's the decision block label about?

that i decided to do not merge this for now

@9il

if(__ctfe) kills inlining in DMD.

Oh. That's pretty bad. I guess we shouldn't merge this right now then, although it would be really useful...

Error: static assert  (!isInfinity(3.40282e+38F)) is false

Fixed. This was only sort of my fault; I copied the pre-existing fallback algorithm for isInfinity() without thinking about it much. Now that I look at it though, it's obviously wrong.
I'll go ahead and close this PR for now due to the inlining issue, but I will make a new PR just to fix the isInfinity() bug.

Closed for now. PR #4329 is just the fix for the isInfinity() fallback algorithm, and nothing else.

if(__ctfe) kills inlining in DMD.

Is there a bug report for this?


Inaccessible line added for 2142 fixes

For S2142 fixes it is possible to generate patches as follows:
           Thread.sleep(sleepTime);
         } catch (InterruptedException e) {
            break;
+          Thread.currentThread().interrupt();
         }

This makes the added line inaccessible, hence compilation error.

I'd imagine the same will happen if there's a continue in a catch.
Should be easy to fix, change this method to also check for continue and break:
https://github.com/SpoonLabs/sorald/blob/bda79e5056e216d1557ce8ad09785a7851d01cf8/src/main/java/sorald/processor/InterruptedExceptionProcessor.java#L64-L69

Yeah, I think it should be easy to fix as well.
I'll fix it soon.

@khaes-kth This will break for all CtFlowBreak - (break, continue, throw, return, and yield). However, yield was introduced in Java 13. Do we support repairs for Java 13 code yet?

Do we support repairs for Java 13 code yet?

ASAIK, we focus on Java 11 for now. I think handling break, continue, throw and return would be enough.


添加tts1分支

PR types

PR changes

Describe

1.在./paddlespeech/exp/transformer_tts/中添加了preprocess_new.py对齐数据处理方法
2.syn_utils.py中加入transformer部分
3.synthesize.py和synthesize_e2e.py中加入transformer声码器
4../example/csmsc/添加tts1文件夹，按标准写了模型训练与使用步骤，使用csmsc训练了一个transformer声源模型

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.吕志轩 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Explode as exit transition

Hi!
In example You show explode transition as enter transition, but reverse transition is slide.
How I can set explode transition as return or exit?
When I call setExitTransition(explodeTransition) or setReturnTransition(explodeTransition) it not take any effect. I want explode as exit or return transition (up part slide up and down screen part slide down), reverse as enter.
Thank You!

What you may be missing is finishAfterTransition()
Instead of finishing your Activity with the regular finish method, use the above to give the exit transition enough time to be displayed

It does not help. I want reverse explode (up part slide up and down screen part slide down) but it slides. But if I set fade it's work.

If you don't set anything the framework should automatically reverse entry transition when activity exits

Entry transition is explode, but why reverse is slide? In Your TransitionActivity2 enter transition is explode, exit and return transitions not defined and reverse is slide down. I setup explode for exit and return transition in TransitionActivity2 but it slide down. Please try by yourself.


Removed the Codesee workflow

Fixes: https://github.com/kubescape/kubescape/issues/1405

@matthyx could you please review this PR in your spare time? Thanks :)

Thanks @VaibhavMalik4187 !


update nottinygc to v0.3.0

replace<EMAIL_ADDRESS>with<EMAIL_ADDRESS>to avoid memory leak

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.钰诚 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Make the parent of a Tenant Resource to be OperationsBase

Description
A container of tenant resource whose direct parent is tenant (for instance, the billing account resource in TenantOnly tests) should be able to get created with TenantOperations which is of type OperationsBase instead of ResourceOperationsBase.
This PR makes corresponding changes to support that and relies on core changes https://github.com/Azure/azure-sdk-for-net/pull/22589
Todo:

Add TenantOperationsExtensionWriter.
In ListAsGenericResourceAsync(), Parent is cast as ResourceGroupOperations. This does not apply for resources whose ancestor is subscription or tenant (here a subscription ancestor means subscription has a direct child resource that is not a resource group, that child resource and the children of that child resource, their ancestor is subscription. A tenant ancestor is similar. Each resource's ancestor is either a resource group, a subscription or a tenant).

Checklist
To ensure a quick review and merge, please ensure:

[ ] The PR has a understandable title and description explaining the why and what.
[ ] The PR is opened in draft if not ready for review yet.

If opened in draft, please allocate sufficient time (24 hours) after moving out of draft for review

[ ] The branch is recent enough to not have merge conflicts upon creation.

Ready to Land?

[ ] Build is completely green

Submissions with test failures require tracking issue and approval of a CODEOWNER

[ ] At least one +1 review by a CODEOWNER
[ ] All -1 reviews are confirmed resolved by the reviewer

Override/Marking reviews stale must be discussed with CODEOWNERS first

/check-enforcer evaluate


Move limit setting above static_preplot

Allow users to set limits in static_preplot!

Whilst I'm here, I don't like the way we can only set AxisAspect(1) or nothing. Bacteria Growth for example would be better off with ax.aspect = DataAspect() for example.

Perhaps the equalaspect keyword is deprecated to aspect = AxisAspect(1), then we can pass in anything.

sure. you don't have to deprecate either, the package is still well before 1.0


High CPU usage when using the http-bad-user-agent scenario

The http-bad-user-agent uses regexp to mach the user-agent, but with high traffic, this leads to very high CPU usage.
The culprit seems to be our use of matches in the expr, which does not compile the regexp ahead of time.
We should implement regex compilation in RegexpInFile and use that instead.

this has been fixed with 1.3.1 and the introduction of https://github.com/crowdsecurity/hub/blob/master/scenarios/crowdsecurity/http-bad-user-agent.yaml


Support Google Cloud Speech API

It seems the speech API from Google is changing to https://cloud.google.com/speech/. We cannot obtain API keys to the old speech API.

Hi @edevil,
The Cloud Speech API looks pretty interesting! I've applied but currently do not have access to it - support will be added when we do. This issue will be updated with progress for that.

Hi @Uberi, today Google announced open Beta of Speech API: https://cloud.google.com/speech/?authuser=1.
I tried recognize_google with my own API-Key, but it did not work. I suppose we have to change the API Call for the new version.

Hi @Uberi!
Here you have the python samples that Google has provided: https://github.com/GoogleCloudPlatform/python-docs-samples/tree/master/speech/api
Many thanks for all the work you are doing, awesome library!

Thanks for the links @jhoelzl and @bodiroga - keep an eye on this issue for progress updates!

Which api are you using ? The only google speech api available I can found is https://cloud.google.com/speech/
If I want to implement my own api, can I do it ? Could you give me some thought ?

Hi @Uberi, just wanted to +1 this. Thanks so much for this great library; looking forward to using it with my own key!

Good luck!
Great library - +1

Hello everyone,
I have few questions about the Cloud speech API from Google.

I have the same problem as @jhoelzl : r.recognize_google(audio) works but r.recognize_google(audio, key="myOwnKey") doesn't. I am confused why. Is there another way to access the API with Python ?

I have a 15 sec limitation, is that normal ?

Thanks a lot for your help :)
Alice

I've started poking at the beta; it's interesting. My impression is this is a distinct service, so the question is whether to considering the existing one superseded by this one (probably not appropriate at least until this is labeled stable; that the example code from a few months ago speaks volumes) or introduce a recognize_google_cloud().
There are REST and gRPC variants. There's an API explorer which allows interactively building and trying requests which is great. (It doesn't use your account though, which can make for odd artifacts when jobs aren't accessible with one's own API keys.)
However, there are some limitations that I've been running up against when trying to run speech-to-text on half-hour scale things: there keep being time limits. (Which seems reasonable - from looking at the behavior when using the API explorer it appears to recognize in real-time instead of faster.) Things beyond a minute (IIRC) as of this writing require service-level authentication which looks complex. Google both recommends using it and recommends using their API client library in order to use it. So this presents another choice: accept that use of the API is length-limited, introduce an optional dependency on Google's API client library, or bother to figure out how to implement just the desired auth parts.


Sui RPC Gateway options question

Steps to Reproduce Issue
Build rpc-server binary
Expected Result
I think options for rpc-server must be
--config <CONFIG> informations here
    -h, --help               Print help information
        --host <HOST>        [default: <IP_ADDRESS>]
        --port <PORT>        [default: 9000]

Actual Result
Currently result is
--config <CONFIG>
    -h, --help               Print help information
        --host <HOST>        [default: <IP_ADDRESS>]
        --port <PORT>        [default: 5001]

Many thanks for the report -- I added @patrickkuo and @arun-koshy who can look into it.

The current rpc-server(gateway) default port is correct (5001), port 9000 is reserved for full node


XSS

Hello,
I've noticed that string passed to the constructor MvcBreadcrumNode don't prevent xss attacks.
(Maybe because they're not escaped before rendering)
My workaround is to encapsulate my string with HttpUtility.HtmlEncode(string) but it's a tedious process.
Is there a workaround built-in your library?
Thank you very much
The escaped version:

Without workaround:

Isn't that the tile of the page?

No string is escaped in the library since I thought everything would be manually set by the developer, can you give me your scenario please?

Sure, my application (web application with netcore) permits to create objects such as application, equipment or whatever.
The user can enter a name, a description and few informations for each objects.
(The creation has this breadcrumb for example: Home > Applications >  New Application)
Then I have a listing of objects with this breadcrumb:
Home > Applications
Finally, the user can view the object created (basically a simple CRUD) with this expected breadcrumb: Home > Applications > "Name of application".
An application's name can have special characteres such as ',",<, >, etc. All labels and fields in aspnet prevent xss attacks (all displayed strings are escaped automagically) and if I remove the Breadcrumb of my view, the script injected isn't executed.
To summarize, I want to be able to display strings from end users in the breadcrumb without any risk of injection of any sort.

Now I understand. I will fix this issue asap!

Hi, this is now fixed in 3.1, download the new version for NuGet!


[Endless Icons] -> [Icons]

Endless Icons
[Icons]
A website offering a number of free icons. Icons are tagged and also compressed into kits.
Link: http://endlessicons.com/
Checklist:

[X] I have performed a self-review of submitted resource and its follows the guidelines of the project.

Hey @dridge737, please add just one resource in a pull request. Btw according to the #277 it should be a good idea to put the Graphic Burger resource in UI Components & Kits or Design Inspiration section.

Changed places for added resources.


Use Dominance Degree Matrix for NDS

Recently, an algorithm for non-dominance sorting has been proposed called Dominance Degree Approach for Non-Dominated Sorting (see: DDA-NS). In the worst case, this algorithm can conduct the sort in $O(MN\log N)$ time in terms of objective function value comparisons which is a vast improvement over the typical $O(MN^2)$. A thorough empirical comparison of NDS algorithms upholds this result, see here
It would be a great addition to the current suite of NDS algos provided by Pymoo.

Thank you for referring to a new paper here! Always good to be up to date!
Did the authors publish the code as well? If yes what programming language? If not, would be be interested in implementing it and contributing to pymoo?

My pleasure! Unfortunately I could not find the code from the original authors - however I did find related work which implemented DDA-NS and provided their own novel method, DDA-ENS in C++ here
I would be willing to implement this, as well as (eventually) the DDA-ENS in python. I'm no computer scientist, though, so it will take some time to interpret the C++ code and merge it with my understanding of DDA-NS.
Another alternative is to simply bind the C++ libraries, with the authors' permission of course - to python but it doesn't look pymoo currently uses a mixed-language approach and it would complicate the bug support process.

I may have overestimated the complexity when I said it might take me a while :laughing:
I believe I have it fully implemented. I haven't compared with with the logic in the C++ from the DDA-ENS paper repo. I implemented it inside of another project I'm working on in a private repo so today or tomorrow I will fork pymoo and move the code over.
Also worth noting is that I implemented it using np.argsort on the objective function values. This means that there is no incorporation of constraint variables. To do so would take considerable more effort and thought for a number of reasons - most obvious of which is that numpy does not provide a way to pass a custom ordering function to the sort functions and thus I would need to determine a clean solution using np.vectorize or similar in order to minimally-impact speed. Second most obvious is that since the authors didn't directly address constraint variables I would need to think deeply about how they fit into the DDA-NS methodology.

Great! You can integrate it with pymoo directly and then write your unit tests there (you can check that it returns the same results as the other implementations that already exist). It would also need to have some comparison of the methods based on efficiency (measured by wall-clock time).
For now, I think you can just assume no constraints (all other implementations in pymoo do this too).
Please keep me posted. Looking forward to your PR.

Perfect!
I just pushed the pure python and cython implementations to my fork. I confirmed it produces the same results as the existing methods.
I will work on the unit tests and timing tests now

@blankjul so I have the tests implemented and everything passes. However comparing the algorithm times shows that both DDA-ENS and DDA-NS are slower than the other algorithms, at least in Cython.
I'm fairly certain this is just because I have not implemented them efficiently in Cython. When I time the algorithms in pure C++ I find the behavior I expect - both perform faster than Fast NDS. I'm pretty sure the crux of the bottleneck is in the construction of the comparison and dominance degree matrices.
Attached is the timing graphs for the pure C++ implementation - ignore the Julia/Python stuff, I reused the timing and graphing code from another investigation I was doing lol. Each point in the graph is based on 1000 samples, population refers to the population size $N$ being sorted.

For reference here is the same test using the timing results with the Cython code I implemented, also 1k samples / data point

Here is the timing test with the Cython code - also 1k samples per point

Thanks for the detailed answer and comparison!
I had a quick look at your fork and implementation. You can use this command cython -a non_dominated_sorting.pyx to compile an HTML file (see screenshot attached) which helps you to detect bottlenecks in your code. Basically, everything that is yellow is not that efficient.

Do you want to try to remove the bottlenecks and see if this improves the performance?
An alternative by the way is including CPP code directly.  Check out the cython/vendor folder for that.

Beautiful! Thanks for your input. This will definitely prove helpful
Fortunately I already have a C++ implementation at-hand so if I can't speed it up in cython I will just call the C++ routine.

Your guidance certainly helped, thank you.
Good news: I was able to vastly improve the speed of the algos in python so now the results are indeed faster than Fast NDS.
Bad news: I was only able to gain mild improvements in Cython, though I've isolated the bottleneck primarily to the in-place addition operation over the $N\times N$ dominance degree and comparison matrices. It's not this way on the branch, but I broke each section into a separate function and then profiled it with cProfile to hunt that issue down.
I've tried a variety of methods to improve the speed here but so far the fastest is still simply looping over each element one-by-one, since we are able to also reset the comparison matrix to zeros in the process. Thus preventing another pass over the entire matrix. FWIW I studied mechanical engineering so I don't have the depth of knowledge of a computer scientist to be able to know what C/C++ practices would help here.
Results for sweeps over # of objectives and # of solutions are attached, 100 samples per data pt.

How do you create the population to test it on? Have you compared the runtime of an algorithm using it during a run? (I think this is what ultimately would be my criterion to make a decision). Can you also add Best-Order-Sort in there? (I have implemented this a while ago because it was proposed by a former lab mate).

I generate the population the same way it is done in testing: an np.ndarray of random floats with a random seed, the only difference being that I don't set the zero-th objective to ones.
I have used both time.perf_counter and timeit.timeit on just the call to the sort strategy (e.g. timeit(f'nds(F, strategy={strategy})', globals = {**globals(), "nds": fn, "F": test_set}, number=1)) for each sample point... so no setup time is included in the results.
I'll run it on some of the benchmark problems to see how it performs in-the-loop and report back

So here are the "comprehensive" results sweeping the # of objectives and population size using various sort algos.
Problem: DTLZ2 (n_var = 7 + n_obj)
Genetic Algorithm: NSGA-II
Stopping Criterion: n_gen == 10
Random Seed: 1
Samples / Data Point: 10

Am I concluding this right that Best-Order-Search seems to be the fastest?
Even if I would still be happy to include your code by the way.

That's what I am seeing as well
I'm honored! Then I will make some finishing touches and open a PR to merge my fork

Great! Thank you in advance!


Skip PAF Approval process if no PAFReviewerRole assigned

Fixes #3839
Assumptions
An organization only chooses one option either go with PAFReviewerRoles or without that. Changing in between might cause the issue with Internal Approval status projects. We will fix this in another issue if needed.
Test Steps

[ ] Remove all PAFReviewerRoles from wagtail admin
[ ] Select a project in draft state, and fill paf
[ ] There should be a Continue to next status button in Actions to take. Also check To do message in the sidebar.
[ ] After confirmation, the project should move to the contracting stage.
[ ] There shouldn't be any Internal Approval stage.

Don't forget to add those PAFReviewerRoles back because we have already chosen that option and to avoid the issue explained in assumption above.

@wes-otf You don't have to remove 'approval roles from user' instead just remove PAFReviewerRoles from Project Settings.
It should be in Project > Project Settings > PAFReviewerRoles.

hahahaha thanks for that assist, I had a feeling I wasn't taking the right steps there. All looks good though! Left a minor comment about wording but perfect functionality wise.


Feature: Display modals for drive errors during file transfer

What feature or improvement do you think would benefit Files?
It would be more helpful if we can tell the user that the drive is full, has insufficient free space, and/or disconnected during file transfers, specially for flash drives.
Requirements

Display a modal for when there's not enough space on a drive
Include the additional size needed to transfer the file(s)
If the drive is disconnected during transfer, notify the user by displaying a modal

Files Version
<IP_ADDRESS>
Windows Version
10.0.22623.730
Comments
No response

Would a link to storage sense be useful when there isn't enough space?

Would a link to storage sense be useful when there isn't enough space?

Regarding storage sense, I personally don't use it because of its lack of details, unlike WinDirStat.
Whenever I transfer files and a drive is full, I usually go to some directory (using explorer) and delete the ones I don't use anymore to free up space, and then click the "Try again" to continue the transfer without having to start all over again
I think the useful thing is to have that Try again option so users can delete files in the meantime and continue the transfer after that process.


Add advanced debugging mode

Adds an advanced debugging mode to help find the source of errors.
To help with #25 - and potentially other issues.

I'm going to hold off on this for a bit. If I get around to it next week I would like to do a more thorough review of this module, and think about the error handling and conditions, and perhaps log more all the time to the companion log

@Julusian I agree that logging more in general would be beneficial


Greenkeeper/@types/node 10.1.1

Coverage remained the same at 40.876% when pulling 895ccca4fc9b17ef833ae3b2ac336c4790337c35 on<EMAIL_ADDRESS>into 4b23a5917fb6859c64f8ff2cd096f43be7e9ec6f on master.


Fix Skia-to-SDL pipeline for any endianness

This PR adds a code-generator, infra/generate_masks.py, to generate channel masks for the Skia-to-SDL copy. Unfortunately it seems to depend both on byte order and OS, so this code generator is linked from the book so students can get the right mask values. To run the browser on your machine, you'll need to run make src/system_specific_constants.py, which is imported by the browser but not committed to git.
When you run infra/generate_masks.py it will pop up a window with a red, green, and blue pixel so you can test if the results are correct. I've tested it on:

[x] Pavel's x86 macOS
[x] Pavel's x86 Linux
[ ] Chris's ARM (?) chromeOS
[ ] Chris's (?) macOS

Nope, this code fails on my Linux machine. It seems to have byte order BGRA, while my macOS has byte order RGBA.

Ok, @chrishtr, I rewrote the test script to actually compute the correct mask values, and describe it that way in the text.
I've also completed experiments on my Linux machine the issue appears to be in Skia (I see different byte values on the two OSs, despite both running x86) not in SDL. More precisely, take the generate_masks.py file in this PR and add this text on line 44:
print(r_bytes, g_bytes, b_bytes)

The code does not even call any SDL methods up to this point, so any differences are due to Skia only. I get a different output on Arch Linux (where I see order BGRA) and on macOS (where I see RGBA).

I asked the Skia eng lead and he said it's a compile-time flag whether to use RGBA or BGRA.
"You can check whether kN32_SkColorType == kBGRA_8888_SkColorType or kRGBA_8888_SkColorType"
Is this exposed in the python bindings?

They said that by default Skia uses BGRA on Windows and RGBA on all other platforms. Perhaps the dll backing skia python is compiled with a particular setting.

Smoking gun:
https://source.chromium.org/chromium/chromium/src/+/master:third_party/skia/BUILD.gn;l=36

He says  you can specify the color type when constructing the surface: kRGBA_8888_ColorType

Ok, interesting, thanks for getting to the bottom of this. I've implemented this and it works. You gotta do this to create the surface:
image_info = skia.ImageInfo.Make(300, 100, ct=skia.kBGRA_8888_ColorType, at=skia.kUnpremul_AlphaType)
skia_surface = skia.Surface.MakeRaster(image_info)

Working on incorporating this into the text.

Ready for re-review

Why remove the comments on endianness? Sadly it is still relevant, because SDL expects integer masks and the integer endianness the affects byte order.

Ok yeah, I guess it does. Nevermind then, go ahead and commit.


wait for all websockets to close in wait_close

This fixes #69

This patch introduces a memory leak. Since references to the protocol for each websocket connection aren't removed from self.websockets anymore, the protocols cannot be garbage-collected. This will lead to unlimited memory consumption and eventually a server crash.


meta.insert.details.ip is always the same ip not matter what echo device I use

SUMMARY

The value in meta.insert.details.ip is always the same ip not matter what echo device I use. I wasn't sure if it should be the ip address of the echo I am saying the command to, but I saw this post in another issue that says it should be.
https://github.com/datech/node-red-contrib-amazon-echo/issues/69#issuecomment-539674081
ECHO DEVICES

Echo 1st Generation
Echo Dot 1st Generation
Echo Dot 2nd Generation
MODULE VERSION

0.1.10

CONFIGURATION

[{"id":"28212899.2e14b","type":"tab","label":"Alexa Shortcuts","disabled":false,"info":""},{"id":"ef61c6be.b450f8","type":"amazon-echo-hub","z":"28212899.2e14b","port":"80","processinput":"2","discovery":true,"x":410,"y":920,"wires":[["ea5bd41.4323128"]]},{"id":"ea5bd41.4323128","type":"amazon-echo-device","z":"28212899.2e14b","name":"Fan","topic":"","x":520,"y":840,"wires":[["31db8d4a.e9b25a"]]},{"id":"31db8d4a.e9b25a","type":"debug","z":"28212899.2e14b","name":"","active":true,"tosidebar":true,"console":false,"tostatus":false,"complete":"true","targetType":"full","x":660,"y":900,"wires":[]}]

CONSOLE OUTPUT

{"on":true,"bri":254,"percentage":100,"hue":0,"sat":254,"xy":[0.6484272236872118,0.33085610147277794],"ct":199,"rgb":[254,0,0],"colormode":"ct","meta":{"insert":{"by":"alexa","details":{"ip":"::ffff:<IP_ADDRESS>","date":"2020-07-06T18:37:40.145Z"}},"input":{"on":true},"changes":{}},"payload":"on","deviceid":"ea5bd414323128","topic":"","_msgid":"ae70930e.1e27d"}

STEPS TO REPRODUCE

Say command to echo using different echo devices, gets the same ip address.
EXPECTED RESULTS

I expected the ip field to have the ip address of the echo device I said the command to.
ACTUAL RESULTS

Same IP address, no matter what device I use.

Already discussed different times, use different Amazon accounts, on for each echo, and you will see different IP

Sorry. I didn't see this in any of the documentation.

Have a look on topics on the closed discussions.
Maybe Datech could put this common issue in Wiki throubleshoot too.


Never ending

If the json file contains corrupt data, it will never be able to continue. In our case it looked like one event was not fully written to disk. And the next event was written to the same line. If e.g. the application throws OutOfMemoryException, StackOverflowException or any similar type of exception this might happen.
To reproduce:
Open an existing json log file, add corrupt data.

Hi Michael, thanks for the note.
This is a design choice in the durable sink mode - the intent is that, if you absolutely can't tolerate log event loss, then:

The sink needs to keep that invalid data so that it can be manually corrected
You'll need to know about it, in this case via the cessation of logging

This makes the durable option a fairly specialised choice; most apps should use the regular, non-durable shipping mode.
In relation to this I've just started spiking out a local (durable) log forwarder as an alternative option, that should provide a bit more flexibility here. Interested in your thoughts.
Regards,
Nick

Seq Forwarder: http://blog.getseq.net/help-us-test-seq-forwarder/
Thanks for the input, hope you can check it out!


Don't add completions from a discriminated union type when the discriminant doesn't match

Fixes #24763

@weswigham can you please reivew

@weswigham Please re-review


feat: add a makefile for local docker env setup

PR Title:
feat: Add Makefile for streamlined development environment setup
Description:

feat: Added a Makefile to automate Docker-related commands, simplifying the setup process for contributors.
Introduced the following targets:

make build: To build the Docker image.
make run: To build and run the Docker container.
make clean: To remove Docker images and clean up resources.

This change improves efficiency, reduces errors, and enhances consistency for all contributors.

Related issue(s):
Resolves #3416

Summary by CodeRabbit

New Features

Introduced a Makefile to simplify the build and execution process for the Dockerized asyncapi-website application.
Added commands to run the application in a Docker container and clean up unused Docker resources.

These changes enhance user experience by streamlining application management.

I am in favor of using a Makefile but it doesn't suit AsyncAPI website repository. Make isn't installed by default on windows and it is the only OS which a person would use docker on to run AsyncAPI website locally.

@anshgoyalevil   i can write a windows powershell script which mimics the same make file which i wrote ,
this will be solely for windows and this makefile will be for linux users we can do like this because the docker commands are so big and it is very tedious to open the docs of the repo and than use it in dev env for contribution


Use -- delimeter for a modifier by Harry Roberts

-- has became a standard for a modifier delimiter. Let's use this convention so that our readers could easily recognise that this is the same BEM which Harry Roberts spoke about and which is currently presented all over the world.

LGTM

@varya can you reopen pull-request? Some questions needs to be solved before switching onto new notation:

How to create --mod directory easly?
Would gulp-bem be still working?
Should markup of getbem be updated as well?