Re-enable tooltips for < 1024px (optional)

Description
I've noticed for a good while now that tooltips don't show at anything smaller than 1024px.
Checking through the commits, the rule to disable them was added as part of:
chore: drawer related css
I'm not sure how tooltips could potentially have any crossover with drawer styles, but @jacobsfletch may have included it for other reasons.
Disadvantages:
Not, sure why the code was added. There might well be a purpose to it.
Miscellaneous:
Sometimes form errors on tablet/mobile are spotlighted by automatically scrolling the viewport to the offending field. This isn't supported by Payload presently (understandable, given most editing happens in desktop browsers).
Yes, I have read and understand the CONTRIBUTING.md document in this repository.
Type of change

[ ] Chore (non-breaking change which does not add functionality)
[ ] Bug fix (non-breaking change which fixes an issue)

Checklist:

[ ] Existing test suite passes locally with my changes

I ran into this today, not being able to see the cause of a validation error is quite irritating as a user.


Warn if trying to use different router flavors

Is there an existing issue for this?

[X] I have searched the existing issues

Problem Statement
If KIC is started with multiple downstream gateways having incompatible router flavors, such configuration has no chance to work and will lead to hard to understand errors.
Proposed Solution
Clearly indicate the "router mismatch among discovered gateways" condition in KIC's logs.
Additional information
post-facto enhancement of #702
Acceptance Criteria

[ ] if Gateway Discovery discovers gateways with pairwise incompatible routers (e.g. one instance with traditional_compatible and one with atc), a warning is present in KIC logs

@mflendrich Do you intend to work on this? FYI: I've submitted #5040 as initial proposal how to tackle this.

@pmalek the assignment was meant for the issue definition phase only. Please feel free to go ahead with your attempt at implementation.

Some work has been started in #5040 and put on hold.
Until I get to it, anyone feeling like working on it feel free to pick this up.

tl;dr

We need to define our expected and supported user workflows before deciding what we should implement here. Simply logging probably doesn't result in great UX (you'll end up in a broken state despite, and bare minimum we'd need to include "do this to fix the problem" instructions somewhere) and we'd need different approaches depending on whether we expect this inconsistency to be a one-off problem when we change the default or a recurring situation because users are switching back and forth.
Proxy instances can be have a consistent router flavor across all replicas and still not come online. The controller doesn't switch the flavor it generates after startup AFAICT. If we expect that this won't be a one-off situation, we probably need to instead rework the controller parser so that it can generate both (traditional_compatible is the same as traditional as far as config is concerned) flavors and send the appropriate one based on the state of an individual proxy replica.
If we expect that the change will just be a one-off event for most users, upgrade docs may be a better solution. We'll probably need them anyway since the steps needed won't easily fit into a log message or Event.
 The "generate both flavors of config, send whichever a given replica wants" approach isn't viable there. I didn't explore this one as much, but the notion of "consistent flavor" doesn't quite apply to it because the controller only talks to a single instance and will add config to the DB based on whatever it reports, but the DB is shared between all replicas. I expect that there's no way to handle DB-backed mode without the outage window+scale down to 0 before changing flavor and scaling back up approach.

Do we expect that this is possible in practice? Are there uncontrived configurations where different router configurations are expected? Was there some report elsewhere where we observed this?
In general, we should expect that Kong replicas will all use the same router configuration under normal operation. All replicas in a Deployment will (eventually) have the same environment.
There are two similar exceptions to this rule:

You have a single Deployment of Kong. You edit it and change spec.template.spec.env[name=KONG_ROUTER_FLAVOR] to a different value. During the update rollout, there are a mixture of Pods with the old and new KONG_ROUTER_FLAVOR value.
You have multiple Deployments of Kong and you've kinda tricked Kubernetes into thinking they're a single Deployment. This is essentially what we do for the operator's blue/green deploy feature. The temporary mismatch state is essentially the same, but convergence to a consistent state is up to the operator instead of Kubernetes' native replica handling.

This state deadlocks immediately because the new replicas never become ready. Roughly:
// this has KONG_ROUTER_FLAVOR=expressions
$ kubectl apply -f ~/src/ingress-controller/test/e2e/manifests/all-in-one-dbless.yaml
namespace/kong created
...

$ kubectl scale deploy -n kong proxy-kong --replicas=3
deployment.apps/proxy-kong scaled

$ kubectl get po -n kong
NAME                            READY   STATUS    RESTARTS   AGE
ingress-kong-7b59dc9857-gncdp   1/1     Running   0          46s
proxy-kong-6545cc68bf-6hjrc     1/1     Running   0          46s
proxy-kong-6545cc68bf-72vql     1/1     Running   0          27s
proxy-kong-6545cc68bf-pp282     1/1     Running   0          46s

Edit the proxy-kong Deployment to use KONG_ROUTER_FLAVOR=traditional.
This will spawn one new replica (AFAIK disruption budget limits the new replicas until some start working) that never becomes ready. Proxy logs will show repeated
<IP_ADDRESS> - - [05/Jan/2024:00:35:40 +0000] "POST /config?check_hash=1&flatten_errors=1 HTTP/2.0" 400 2365 "-" "Go-http-client/2.0"

The controller will show
2024-01-05T00:37:49Z	error	dataplane-synchronizer	Could not update kong admin	{"error": "performing update for https://<IP_ADDRESS>:8444 failed: failed posting new config to /config: got status code 400\nperforming update for https://<IP_ADDRESS>:8444 failed: failed posting new config to /config: got status code 400"}

because the route configuration is invalid for its configuration. You can scale the proxy replicas to 0 and then back up to 3 so that all replicas use the same router flavor, but that state being consistent won't actually fix things. I didn't check the code to confirm, but that behavior suggests the controller decides the flavor it'll use at startup and doesn't change it. This just results in a set of all unready replicas even though the router flavor is consistent.
$ kubectl scale deploy -n kong proxy-kong --replicas=0
deployment.apps/proxy-kong scaled

$ kubectl get po -n kong
NAME                            READY   STATUS    RESTARTS   AGE
ingress-kong-7b59dc9857-gncdp   1/1     Running   0          13m

$ kubectl scale deploy -n kong proxy-kong --replicas=3
deployment.apps/proxy-kong scaled

// these are consistent, but never become ready. the controller is still trying and failing to send a traditional config
$ kubectl get po -n kong
NAME                            READY   STATUS    RESTARTS   AGE
ingress-kong-7b59dc9857-gncdp   1/1     Running   0          13m
proxy-kong-65f9b9f779-5xvtx     0/1     Running   0          17s
proxy-kong-65f9b9f779-7tfdz     0/1     Running   0          17s
proxy-kong-65f9b9f779-d87vh     0/1     Running   0          17s

You need to further rollout restart the controller so that it decides a new router flavor after. Warning in logs is probably not that effective here since it's kind of a die roll whether the system will return to a functional state: if the controller ever starts while the proxy replicas are in a mixed state and it (randomly) chooses a replica with the old config value, it'll get stuck on that and the system will remain in deadlock.
IMO we're better off handling this in upgrade docs: for most users, this transition will probably only happen once, when/if we change the chart default flavor (https://github.com/Kong/charts/pull/937 or similar--IDK if there's a relevant open issue at this point since we closed https://github.com/Kong/kubernetes-ingress-controller/issues/4719). I wouldn't expect users to switch between the flavors on their own, though it's not out of the question: expressions is new enough that we could encounter bugs and recommend a user switch back to traditional until a bug affecting them is fixed. I haven't encountered such issues myself yet though (we should double-check with the gateway team, they may be aware of stuff we're not), so conservatively we could approach this with upgrade docs saying "do an outage window and scale everything to 0 before modifying this, then modify and scale back up to your usual replica count).
If we do expect that users will need to switch router flavors often going forward, we'd maybe need to consider making the controller able to handle either flavor by generating both expressions and traditional/traditional_compatible config blobs and sending whichever matches an individual proxy replica's config. You don't really want to have to take outage windows often, so if we expect that users will switch between them on an ongoing basis, we probably need to handle it gracefully.
Finally, the above mostly applies to DB-less. DB-backed is, AFAIK, a whole different ballgame because routes live in the DB and aren't magically converted to the other flavor if you switch and restart. Initial exploration suggests that the active router flavor can only "see" routes with its type of config, so switching effectively just makes all routes created on the previous flavor disappear. The controller's diff and update logic may work around that (it should see that the route in the DB doesn't match the expected config for the current flavor and update it), but I didn't actually try to confirm, so take that guess with a generously-sized grain of salt.

You have a single Deployment of Kong. You edit it and change spec.template.spec.env[name=KONG_ROUTER_FLAVOR] to a different value. During the update rollout, there are a mixture of Pods with the old and new KONG_ROUTER_FLAVOR value.

That's the typical upgrade scenario where I'd expect users to want to be covered and have zero down time ideally.
@mheap mentioned that we do not expect users to change the flavor back and forth so I'd consider this as a typical use case for flavor change, one-of basically.

I'd like to propose the following course of action in that case:

Add the log as proposed in #5040 so at the very least we let users know that the 400s they are getting
Consider adding a flavor aware translator that would basically generate config for all flavors detected. I haven't looked at the translator code in detail recently but that seems doable. Certainly not attainable for 3.1 but worth considering after that's released.
Document this in docs (until above is implemented). Here I'd like to suggest how we'd like to support this transition for users without the "flavor aware translator".

I am tempted to say that DB-backed wouldn't be covered by this guide?
DB-less would could basically do the following (as suggested by @rainest)

Change the flavor
Scale proxy Deployment down to 0 and back up.
Perform a rolling restart of the controller. It picks up the new flavor and applies new config
NOTE: this implies downtime

Are we OK with this approach or are there any other suggestions to this? @mflendrich @mheap

Updated the title and description and put this tentatively in 3.2 milestone given that there's some pending work on the Gateway side.

As I got from the gateway team, they have the changes on expression router for accepting fields in the traditional router (but cannot specify both traditional fields like paths, headers and expression in the same route). So the steps of changing router flavors could be:

KIC translate to traditional routes and Kong gateway runs traditional/traditional compatible router
Upgrade Kong gateway to expression router (needs Kong gateway 3.7+) and KIC still translate to traditional routes
Upgrade KIC so that it translate to expression routes.
Following these steps, I think we can implement the upgrade process with no changes to KIC translator. Testing and documentation is required. Maybe we need to add a router flavor upgrade test for this.

This is a helm chart change only. Let's wait until the Gateway LTS supports "mixed mode expression routing" and we can turn it on for all supported versions at once.

From @randmonkey:

Kong gateway 2.8LTS will end support in Mar 2025. After that, all supported versions will support expression router.

I'm of the opinion of waiting until Mar 2025 to change the default

Even then, what’s the downside to keeping the current default? The behaviour is the same


Something wrong with the code block display

At first, thanks for this bravo plugin.
When I use the syntax ``` (code block) in markdown to put my c++ code in, the rendered area exceeds the code section. It looks like this:

But the normal situation is this (which I remove the type string "c++" to compare with the previous image)

And the most important thing is, this bug is decided by the code I put in the block. The display in the second block of the above image is correct. I guess some code string broke the parser and cause the issue but I am not sure.
The issue doesn't bother me too much, because I can fix it by declaring nothing about the language type. But I wish it could be fixed in the plugin.
I am using Sublime Text 3 Build 3065.

It's an interesting question, thanks for bringing it up. I noticed the issue myself and it is really annoying. Finally I've got a good reason for doing a little research :-)
First of all the issue is not something that is unique for Markdown Light: all markdown packages for Sublime have it. It doesn't prove anything but is a symptom that the reason is somewhere outside my package.
I've done some experiments with C++ syntax file. Class definitions are handled by a block at line 402. That block captures keywords "class"/"struct" followed by an identifier. There is another block at line 458 inside the previous one for capturing curly braces and everything inside them. That block includes $base at line 496. Actually I did't find any documentation regarding $base but it seems to me that the original intent was in applying all C++ grammar rules recursively to everything inside curly braces.
Let's step back and recall that the C++ code is located inside Markdown file and is enclosed within fenced code block.
The problem is that $base refers to Markdown syntax, not C++. One can easily verify it in Sublime with the following example:
```c++
class A {
***This text will be surprisingly bold in Sublime***
};
```

Replacing $base with $self in C++ syntax file solves the issue because $self refers to current grammar which is C++ in our case.
Again, I am not 100% sure because the $base/$self topic is poorly covered in documentation, but for me this is the most reasonable explanation.

Thanks a lot for your reply and providing the solution, it works :)

Found a good explanation of the $base/$self issue: textmate/textmate#1276

According to the textmate issue the workaround that I proposed earlier is not correct. It affects highlighting of C++ files.
Seems like there is currently no good solution for the issue because it is caused by limitations of the Sublime's syntax highlighting engine. All Markdown packages have the same issue. If you aware of a syntax definition for Sublime that can embed other syntaxes and doesn't have this issue please share.


Build and install extension.

I want to create MR, but first I want to build and test it. Could you tell me how to build project properly ? Then I have to install it in my VSCode from .vsix file, right ?
I want to add option to Build command, which will save all opened unsaved files before build commad.

After npm install I run ./node_modules/.bin/gulp package add loaded extension from vsix but extension seems to not work right. It did not load  my qbs properly.


Add Nghe An College of Economics

@manhnx4 I am sorry, this request has signs of fraud. I have to close it without merging. If you are a student of this school, please apply with official document ("OFFICIAL DOCUMENT" tab at https://www.jetbrains.com/shop/eform/students).


Try to reduce the number of calls when fetching PRs with multiple remotes present

Previous behavior:
When listing PRs, loop through all available remotes. While the number of results returned is less than the max page size, continue to fetch. In a scenario where someone has lots of remotes with no PRs, the number of requests can get very large quickly. And if across all remotes there are fewer than 20 PRs, we end up exhausting all remotes while trying to fill the max page size.
Attempted mitigation:
First, try to be smarter about the starting remote by looking for an 'upstream' or 'origin'. Second, instead of continuing to fetch while the max page size hasn't been filled, stop after any call returns results.
I'm not sure if the UI is clear here. Instead of having only a "Load more" row show up at the bottom, I added a different "Continue fetching from other remotes" row. I wanted to distinguish loading more pages of the current remote vs fetching from other remotes, but I'm not sure if that makes things more confusing. When continuing fetching from other remotes, there may or may not be additional results, so I thought it would be weird to show a "Load more" button and then have it just disappear when clicked. I think a better solution would be more radical: showing remote information in the tree, possibly as a top level or using the new "message" property, and potentially allowing users to configure what remotes to show data from via settings
https://github.com/Microsoft/vscode-pull-request-github/issues/745

I'm not sure assuming that users will use upstream and origin for upstream and forks is a good idea or not, for example our team still needs remotes which are neither upstream or origin for pull requests. I like your idea of having a list remotes that the extension uses for fetching pull requests.


Missing patch in long term branch (IDFGH-4056)

There is a patch in closed issue IDFGH-781 which has been applied to 4.x branches, will be the same solution a part of the long term branch 3.3.x?
Thanks

@swdevelops If you are talking about fix in commit-id https://github.com/espressif/esp-idf/commit/ab6ad844b152594d7df7d4e23df3ec8397acc176#diff-e5ab27131c9215b651df791f52f73d91, then its not applicable for v3.x branch. This issue appeared because of lwIP upgrade to v2.1.0 release, v3.x still runs on older version of lwIP v2.0.3.
Are you observing any specific issue with v3.3.x release? If yes, can you please help to share detailed information per github issue template?

@swdevelops Closing this issue, please feel free to reopen in case your query is not answered or you have any specific issue on v3.3.x release (would recommend new issue in that case).


30 add rarity assertions

Codecov Report

Merging #31 (124023a) into release-candidate (bc51b29) will not change coverage.
The diff coverage is 100.00%.

@@                 Coverage Diff                 @@
##           release-candidate       #31   +/-   ##
===================================================
  Coverage             100.00%   100.00%
===================================================
  Files                     38        38
  Lines                    590       596    +6
===================================================
+ Hits                     590       596    +6

Files Changed
Coverage Δ

src/digimon_card_game/card_rarity.py
100.00% <100.00%> (ø)

tests/test_card_rarity.py
100.00% <100.00%> (ø)


Integration test

Resubmitting PR #130
Added an integration test to run on GCP that tests Feast set up with BQ/REDIS and runs with Dataflow as a runner to ingest batch data.

/approve

/approve

/lgtm


Fix JUnit log order and non verbose mode.

Review by @gzm0

Refer to this link for build results (access rights to CI server needed):
https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/3014/
https://scala-webapps.epfl.ch/jenkins/job/scalajs-matrix-build/3911/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/3018/
https://scala-webapps.epfl.ch/jenkins/job/scalajs-matrix-build/3916/
Test PASSed.

It seems there are many degrees of freedom here. Honestly I think this code is too complex not to be guarded by tests. Do we have any tests of this code?

We do not have any test for this. We should figure out a reliable way of creating tests on the output that can be run on JS and JVM.

Refer to this link for build results (access rights to CI server needed):
https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/3020/
https://scala-webapps.epfl.ch/jenkins/job/scalajs-matrix-build/3919/
Test PASSed.

So I guess what I'm saying is that there is no point fixing nifty details like this, if we don't test for it. Mainly because the aggregate of:

How it works
How it is supposed to work

Is too complex for a developer to just grasp when something is changed.

Refer to this link for build results (access rights to CI server needed):
https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/3029/
https://scala-webapps.epfl.ch/jenkins/job/scalajs-matrix-build/3933/
Test PASSed.


Add Ondat Helm repo

Resolves an error in deploying Umbrella chart

https://github.com/ondat/charts/runs/6652343884?check_suite_focus=true throws no repository definition for... error which has a fix in reported issue https://github.com/helm/chart-releaser-action/issues/74 😊

Thanks @DavidMarchant! 🙌


How handle click on pdfViewer?

Here my code in activity:
private void openFromLocalStorage(String pdfUrl) {
        File pdfFile = FileUtil.getFromDir(this, pdfUrl);
        pdfView.fromFile(pdfFile)
                .defaultPage(currentPage)
                .enableSwipe(false)
                .onPageChange(this)
                .load();
    }

OK. It's work fine.
When I double click on pdfView then it zoom. OK.
But I need to handle simple click on pdfView.
How I can do this?

Use .onTap(), it is in readme

onTap is only from ver. 2.8.0
But I use version 1.6.0 .
I user version 1.6.0  because it has horizontall scrolling. But in version 2.8.0 no horizontall scrolling.
So the question is:
How I can do handle click and not to lose horizontall scrolling?

You created issue in incorrect repository, there is AndroidPdfViewerV1 repo for version 1.x.
onTap() is from 2.7.0.
All version have horizontal scroll.
If you want to use 1.x you may only use standard View's method setOnClickListener()

Use .swipeHorizontal(true), it is in readme.

If I use .swipeHorizontal(true) then pdfViews can stay between pages.
Here details:
https://github.com/barteksc/AndroidPdfViewer/issues/425
So as result I use .enableSwipe(false) - this what I need.
But I can't single click by .onTap
So I result the solution is to use: standard setOnClickListener()
Is I'm right?

You asked for horizontal scroll, not for single-page scroll. Version 2.x only have continuous scroll.

OK. Thanks. The solution is setOnClickListener()


broken parsing on android

after upgrading to 0.4.38 my android app stopped working.
Small investigation shows that libsvgren cannot read svg files generated on windows platforms (with 0d 0a line breaks)
an example: z_tiger1.zip
I see migration from pugixml to mikroxml.
What's the reason?
Pugixml works correctly with any line styles.
Moreover, simple time measurements show that pugixml is a bit faster on my testing android devices.
It would be nice to provide us ability to switch to another xml parser.

Thanks for reporting the problem.
Yes, I switched to another xml lib. I thought that using streaming XML lib instead of DOM xml lib will make loading faster. Unfortunately I did not see tmuch difference in loading time, althogh on desktop PC I observed slight increase in loading times, I haven't tested it on android devices. But, on the other hand, using streaming xml library gives huge decrease in memory footprint, so I decided to switch to it, despite there was no improvement in loading time. Other benefit is that I will have more control on packaging the library to different platforms where I deploy my libs.
I will make a fix for the problem you reported.

streamed reading and smaller memory footprint are great things,
however I see that pugixml is still used in your msvc solution

it shouldn't be there, if it is then it's a bug

just look into svgren/msvs_solution/libsvgren/packages.config

Fix ready. Please update mikroxml to version 0.1.3. It should be ready soon:
https://travis-ci.org/igagis/mikroxml/builds/269651049
https://ci.appveyor.com/project/igagis/mikroxml/build/master-33

thanks for the fix attempt.
I'll check it on android a bit later. However now I see it doesn't work on windows (with native 0d 0a line breaks).
I'm getting malformed document exception when trying to launch your render test
Tiger from the mac (sole 0x0a line break ) works well.
Switching to milroxml v0.1.3  doesn't help.
And BTW,  you are still  targeting mikroxml 0.1.2 in your msvs solution.
give us an opportunity to use pugixml as option, please.
regards!

It works for me on windows after updating to mikroxml 0.1.3. Make sure that you have updated to 0.1.3 on both, libsvgren and render_test projects in MSVS.
I'll think about providing an interface to use side xml parsers in svgdom.

Yeah, it works after manually switching mikroxml to 0.1.3 in both test and lib.
And interface for reader would be great feature (I'm planning use binary serialized svg on mobile platforms)

Ok, closing this bug then.
What do you mean under "binary serialized"?

something like these:
https://en.wikipedia.org/wiki/Binary_XML
probably https://msdn.microsoft.com/en-us/library/cc219210.aspx

Unfortunately I did not see tmuch difference in loading time, althogh on desktop

Hi Ivan!
just a reminder about interface for xml side...
I've just tested that nice back.svg on PC with both pugi- and mikro-xml libs.
Loading with pugixml: 4.2 sec
Loading with mikroxml: 4.6 sec
pugi wins )
0.4s is about 10%...

@Papirosnik could you submit a new issue about it to svgdom?


Keyvault authentication fails after last update

Package Name: @azure/identity
Package Version: 3.2.3
Operating system:
nodejs
version: v18.18.2
browser: N/A
name/version:
typescript
version:
Is the bug related to documentation in
README.md
source code documentation
SDK API docs on https://docs.microsoft.com/
Describe the bug
After the last version release of @azure/identity, all your function apps that got redeployed with version 3.x.x aren't able to connect to the keyvault. I see a major version is release 16 hours ago to 4.0.0. This also fixes the problem. However we missed that this would be a breaking update and are wondering how we would have known that this would be a problem if we didn't upgrade our package version to 4.0.0. so we don't run into this problem again later on.

@edgardcooper-lukasdemeyere can you provide some details about what error you are seeing when trying to use KeyVault with 3.2.3? I don't believe it is expected that you would need to use the 4.0.0 beta in order to continue using the service.

@xirzec @edgardcooper-lukasdemeyere Looks like 3.2.3 was one of the versions we had deprecated.
@edgardcooper-lukasdemeyere I am assuming you were referring to deprecated message. Please use 3.3.2 version. It's a stable GA.

Hi! thanks for the fast responses. Reading back my post it isn't very clear what I meant.
Starting from this morning function apps that got redeployed couldn't authenticate with Azure Key vault anymore. Weird thing is that the function apps that didn't got redeployed still were able to authenticate.
We didn't see a deprecation message in any of our function apps or local development. This is the error we got in production environments (we were still able to connect in local development). When and where should we have seen a deprecation message?
Result: Failure Exception: Worker was unable to load function XXXXX: 'Worker was unable to load function XXXXX: 'ChainedTokenCredential authentication failed. CredentialUnavailableError: EnvironmentCredential is unavailable. No underlying credential could be used. To troubleshoot, visit https://aka.ms/azsdk/js/identity/environmentcredential/troubleshoot. CredentialUnavailableError: WorkloadIdentityCredential: is unavailable. tenantId, clientId, and federatedTokenFilePath are required parameters. In DefaultAzureCredential and ManagedIdentityCredential, these can be provided as environment variables - "AZURE_TENANT_ID", "AZURE_CLIENT_ID", "AZURE_FEDERATED_TOKEN_FILE". See the troubleshooting guide for more information: https://aka.ms/azsdk/js/identity/workloadidentitycredential/troubleshoot CredentialUnavailableError: ManagedIdentityCredential: Authentication failed. Message missing_tenant_id_error: A tenant id - not common, organizations, or consumers - must be specified when using the client_credentials flow. CredentialUnavailableError: Azure CLI could not be found. Please visit https://aka.ms/azure-cli for installation instructions and then, once installed, authenticate to your Azure account using 'az login'. CredentialUnavailableError: Error: Unable to execute PowerShell. Ensure that it is installed in your system. To troubleshoot, visit https://aka.ms/azsdk/js/identity/powershellcredential/troubleshoot. CredentialUnavailableError: Azure Developer CLI couldn't be found. To mitigate this issue, see the troubleshooting guidelines at https://aka.ms/azsdk/js/identity/azdevclicredential/troubleshoot.'' Stack: AggregateAuthenticationError: Worker was unable to load function XXXXX: 'Worker was unable to load function XXXXXX: 'ChainedTokenCredential authentication failed. CredentialUnavailableError: EnvironmentCredential is unavailable. No underlying credential could be used. To troubleshoot, visit https://aka.ms/azsdk/js/identity/environmentcredential/troubleshoot. CredentialUnavailableError: WorkloadIdentityCredential: is unavailable. tenantId, clientId, and federatedTokenFilePath are required parameters. In DefaultAzureCredential and ManagedIdentityCredential, these can be provided as environment variables - "AZURE_TENANT_ID", "AZURE_CLIENT_ID", "AZURE_FEDERATED_TOKEN_FILE". See the troubleshooting guide for more information: https://aka.ms/azsdk/js/identity/workloadidentitycredential/troubleshoot CredentialUnavailableError: ManagedIdentityCredential: Authentication failed. Message missing_tenant_id_error: A tenant id - not common, organizations, or consumers - must be specified when using the client_credentials flow. CredentialUnavailableError: Azure CLI could not be found. Please visit https://aka.ms/azure-cli for installation instructions and then, once installed, authenticate to your Azure account using 'az login'. CredentialUnavailableError: Error: Unable to execute PowerShell. Ensure that it is installed in your system. To troubleshoot, visit https://aka.ms/azsdk/js/identity/powershellcredential/troubleshoot. CredentialUnavailableError: Azure Developer CLI couldn't be found. To mitigate this issue, see the troubleshooting guidelines at https://aka.ms/azsdk/js/identity/azdevclicredential/troubleshoot.'' at /home/site/wwwroot/node_modules/@azure/identity/dist/index.js:3015:29 at process.processTicksAndRejections (node:internal/process/task_queues:95:5) at async Object.withSpan (/home/site/wwwroot/node_modules/@azure/core-tracing/dist/index.js:140:28) at async DefaultAzureCredential.getToken (/home/site/wwwroot/node_modules/@azure/identity/dist/index.js:2990:27) at async tryGetAccessToken (/home/site/wwwroot/node_modules/@azure/core-rest-pipeline/dist/index.js:2005:32) at async beginRefresh (/home/site/wwwroot/node_modules/@azure/core-rest-pipeline/dist/index.js:2013:17) at async Object.authorizeRequestOnChallenge (/home/site/wwwroot/node_modules/@azure/keyvault-secrets/dist/index.js:1233:29) at async Object.sendRequest (/home/site/wwwroot/node_modules/@azure/core-rest-pipeline/dist/index.js:2207:43) at async KeyVaultClient.sendOperationRequest (/home/site/wwwroot/node_modules/@azure/core-client/dist/index.js:1948:33) at async KeyVaultClient.sendOperationRequest (/home/site/wwwroot/node_modules/@azure/core-http-compat/dist/index.js:202:24)

Just a heads up, tried upgrading to v3.3.2 with an app of ours and doesn't seem to work. Same behaviour as the deprecated v3.2.3 version. 4.0.0 seems to work though

@edgardcooper-lukasdemeyere can you try 3.4.1 which was just published? Or feel free to stay on 4.0.0 if that is working for you.


Persist line "minimized" status to DB

Note that I didn't change anything related to height logic so I don't see lines jumping when switching tabs or workspaces.

small change, for this new LineState key lets use "wave:min" as opposed to "prompt:min".  can't change the old ones (since they are stuck in the DB), but going forward better to use the "wave:" prefix.

small change, for this new LineState key lets use "wave:min" as opposed to "prompt:min". can't change the old ones (since they are stuck in the DB), but going forward better to use the "wave:" prefix.

addressed


Add global verbose flag that prints more information about installation progress and errors

This should involve expanding Logging.log with different logging levels, like debug, info, warn and error. A global log level would determine which log messages were actually output. Increasing log levels would print fewer, higher-priority messages. The default log level would be info, and the current output should migrate to the info level.
A new global -v/--verbose flag would change the log level to debug. This should output more information, like network request headers and bodies, so that users can provide more meaningful bug reports and we can more easily troubleshoot issues.
Colors should be set for the warn and error levels in one place, instead of at each Logging.log call site. Errors should also be sent to STDERR instead of STDOUT.

This would be really handy, any updates on this?
I can't get xcodes to work, see this issue: #314


Clean up Bloc dependencies

Some Bloc classes depend on packages they should not depend on:
dependencies := 'Bloc' asPackage methodsGroupedByUsedPackages.
goodPackages := dependencies keys
	select: [ :eachPackage | #(Beacon Announcements Collections Colors 'Graphics-Display' Kernel NewValueHolder 'System-Platforms' 'System-Settings' Transcript) anySatisfy: [ :eachAllowedPackageName | eachPackage name includesSubstring: eachAllowedPackageName ] ].
dependencies removeKeys: goodPackages.
dependencies

dependencies := 'Bloc' asPackage gtPackagesUsed.
goodPackages := dependencies
	select: [ :eachPackage | #(Beacon Announcements Collections Colors 'Graphics-Display' Kernel NewValueHolder 'System-Platforms' 'System-Settings' Transcript) anySatisfy: [ :eachAllowedPackageName | eachPackage name includesSubstring: eachAllowedPackageName ] ].
dependencies \ goodPackages.

they were significantly improved :)


Split vault keys into control and stash

The idea is that a control account can transact on behalf of a stash account which is used to manage a Vault's collateral. This would enable the stash key to be stored offline, perhaps in a cold wallet, to minimize fund loss should the physical server hosting the control key be compromised.

Changes
I am expecting the VaultId to contain the AccountId for the stash key, the control key will be defined separately.

[ ] Add control: AccountId to the Vault struct
[ ] Ensure origin of register_address is signed by the control account
[ ] Ensure origin of accept_new_issues is signed by the control account
[ ] Ensure origin of request_replace is signed by the control account
[ ] Ensure origin of withdraw_replace is signed by the control account
[ ] Ensure origin of accept_replace is signed by the control account
[ ] Ensure origin of cancel_replace is signed by the control account

Since the VaultId will comprise the stash account (to minimize changes and since the control account may change) any function which checks the validity of the origin for the control account should require either a stash_id parameter for lookup and comparison or we may decide instead to define a separate storage map in the vault-registry.
Other Notes
Extrinsics which target nomination / staking & rewards will use the stash key by default, if we want a running Vault (signing with the control key) to be able to claim rewards on behalf of the stack account we may want to consider an alternate approach.
Related reading: https://docs.substrate.io/v3/concepts/account-abstractions/
Client Changes
I would expect the client changes to be largely incidental to most users. That is for auto-registration, the current Vault should use the same key for both control and stash. The front-end Vault dashboard should allow advanced registration for the stash account to explicitly set the control key.

Additionally..

[ ] Ensure origin of execute_redeem is signed by the control account
[ ] Ensure origin of execute_refund is signed by the control account
[ ] Ensure origin of cancel_issue is signed by the control account


⚠ Fortnite has degraded performance

In 50a67d9, Fortnite (https://fortnite.com) experienced degraded performance:

HTTP code: 200
Response time: 1650 ms

Resolved: Fortnite performance has improved in 66a3635.


Length and structure of the introduction

The Introduction + Related Work is currently three pages, and the structure is a bit loose. If I were to put titles in each paragraph:
Introduction

Computers are important -> drop?
Researchers need more and more computer skills that they don't learn in their studies
Researchers write software. RSE is a term.
RSE is a career.
RSEs are diverse but share core skills.
RSEs implement the FAIR principles for software
This paper identifies values and competencies
Terminology -> Make a separate section after Introduction?

Software
Research
Research Software Engineers (not explicitly)

Context / history of this paper
Outline (in several small paragraphs) -> Merge and shorten
Who may want to read this paper (a bit too long / loosely structured). -> Shorten? Move?

Related work
Not really connected to the rest of the introduction/paper. Also brings in several citations that could probably be removed.

Option A: Make it one short paragraph, cite one resource per example, and integrate it into the introduction.
Option B: Drop it.

In both cases, I think a better place for this would be the follow-up paper on teaching.
Action
If we agree on the general direction, I can try shortening this part and improving the structure.

Check again the terminology about research / research software.

I guess this is closed now?


Update .travis.yml

Use the npm cache alias

@siddharthkp: do you use yarn or npm? Apart from my comment here, I think you should definitely add a package-lock.json or yarn.lock if you decide to go with the yarn solution.
My suggestion is to keep this proper either way. Let me know what you want to use and I'll make a PR later.


[priority] Detect Sample Rates for errors and transactions

requires performance to be detected

i.e. detect super low sample rate, like 4

applies only to hardcoded sample rate

See https://github.com/sentry-demos/detective-scentry/pull/16


Get CSS property values from webref

This PR grabs the values for CSS properties from webref, so that we can stay synchronized with new values introduced in the specification.
Statistics
Before this change, there are 1284 features in css.properties.  After this change, there are 2510 features.  This adds 1,226 new features and removes 0.

Before this change, there are 1284 features in css.properties. After this change, there are 2510 features. This adds 1,226 new features and removes 0.

This is massive. I'm not yet sure we have the bandwidth to review this. Do you know how it will affect our coverage (which is a goal)?
Also, what is the plan for avoiding to introduce a lot of ranged values? For example if you have the CSS height property supported since version 1 and you add a sub feature for the height: auto value, which I think was a value that was also added in version 1, how will the collector do this? I often see the collector setting ≤72 for Firefox for example as the earliest version. This is problematic because MDN renders it as "72" which is not ideal as I think we should be indicating that height and height: auto were introduced at the same time, in version 1.

Do you know how it will affect our coverage (which is a goal)?

A natural side effect of adding these features is that our coverage technically increases, because we're adding more covered features to BCD.  Before v10.7.0 (specifically, commit 1a08c73acf2f5dcf700d8058988ab32ded5c89a8), the coverage for css.properties was 213/1227 (17.36%).  After v10.7.0 was released (plus a few tweaks, 1adc979ccc11418ea24e5eccf8975e6878ad9b34), then running add-new-bcd, coverage went down to 206/1784 (11.55%).
Now, if we're focusing only on the coverage improvement of features already tracked in BCD, well, it's only 7 features (a 0.57% difference) -- not exactly a grand improvement.  The intention of this change isn't the coverage, but rather improving BCD by adding verbosity about what values we know are supported.  If we're just focused on the numbers, then it's a plus for coverage.

Also, what is the plan for avoiding to introduce a lot of ranged values?

I didn't really have a plan for that since we have still been focusing on only correcting errors for browser versions released in 2020 and later.  However, it's an easy fix: all we need to do is collect results for older browsers, which is as simple as changing a command line argument.

Thanks for your analysis! I will not review new CSS property values data additions for the moment then. Need to focus on the other goals. I think this would be a great project later in the year, though.


Cannot read property 'state' of null

hello

hello again

Here is another similar callstack
TypeError: Cannot read property 'state' of null/vs/workbench/parts/debug/browser/debugActions.ts#L56:50 (state)/vs/workbench/parts/debug/browser/debugActions.ts#L120:8 (updateEnablement)/vs/base/common/callbackList.ts#L63:26 (apply)/vs/base/common/event.ts#L117:26 (call)/vs/workbench/parts/debug/common/debugViewModel.ts#L100:37 (fire)/vs/workbench/parts/debug/browser/debugActions.ts#L108:35 (setSelectedConfigurationName)/vs/base/common/actions.ts#L210:28 (run)/vs/workbench/parts/debug/browser/debugActionItems.ts#L45:21 (run)/vs/workbench/parts/debug/browser/debugActionItems.ts#L31:7 (updateOptions)/vs/base/browser/ui/actionbar/actionbar.ts#L520:8 (render)

Here is another similar callstack
TypeError: Cannot read property 'state' of null    at t.updateEnablement (out/vs/workbench/electron-browser/workbench.main.js:93:9200)    at out/vs/workbench/electron-browser/workbench.main.js:93:10941    at e.invoke (out/vs/workbench/electron-browser/workbench.main.js:30:22801)    at e.fire (out/vs/workbench/electron-browser/workbench.main.js:31:1364)    at e.setSelectedConfigurationName (out/vs/workbench/electron-browser/workbench.main.js:83:23620)    at t.run (out/vs/workbench/electron-browser/workbench.main.js:93:10521)    at t.run (out/vs/workbench/electron-browser/workbench.main.js:32:24893)    at t.updateOptions (out/vs/workbench/electron-browser/workbench.main.js:82:24694)    at t.render (out/vs/workbench/electron-browser/workbench.main.js:82:24268)    at out/vs/workbench/electron-browser/workbench.main.js:45:23621

Here is another similar callstack
TypeError: Cannot read property 'state' of null/vs/workbench/parts/debug/browser/debugActions.ts#L56:50 (state)/vs/workbench/parts/debug/browser/debugActions.ts#L120:8 (updateEnablement)/vs/base/common/callbackList.ts#L63:26 (apply)/vs/base/common/event.ts#L117:26 (call)/vs/workbench/parts/debug/common/debugViewModel.ts#L100:37 (fire)/vs/workbench/parts/debug/browser/debugActions.ts#L108:35 (setSelectedConfigurationName)/vs/base/common/actions.ts#L210:28 (run)/vs/workbench/parts/debug/browser/debugActionItems.ts#L45:21 (run)/vs/workbench/parts/debug/browser/debugActionItems.ts#L31:7 (updateOptions)/vs/base/browser/ui/actionbar/actionbar.ts#L520:8 (render)

Here is another similar callstack
TypeError: Cannot read property 'state' of null/vs/workbench/parts/debug/browser/debugActions.ts#L56:50 (state)/vs/workbench/parts/debug/browser/debugActions.ts#L120:8 (updateEnablement)/vs/base/common/callbackList.ts#L63:26 (apply)/vs/base/common/event.ts#L117:26 (call)/vs/workbench/parts/debug/common/debugViewModel.ts#L100:37 (fire)/vs/workbench/parts/debug/browser/debugActions.ts#L108:35 (setSelectedConfigurationName)/vs/base/common/actions.ts#L210:28 (run)/vs/workbench/parts/debug/browser/debugActionItems.ts#L45:21 (run)/vs/workbench/parts/debug/browser/debugActionItems.ts#L22:8 (updateOptions)/vs/base/common/callbackList.ts#L63:26 (apply)

Fixed in master


Fix broken homepage URLs

Issue description
repology has a nice listing of broken homepages in Nixpkgs:
https://repology.org/repository/nix_unstable/problems
I went through and fixed a few, but many more still remain. If anyone else would like to work on this, it would be greatly appreciated.
Steps to reproduce
Technical details
Please run nix-shell -p nix-info --run "nix-info -m" and paste the
results.

It would be nice to check source urls for the problems, there are a lot of 404
With repology or a home-grown bot, no matter.

What's the status of this? Has automation been put in place to detect broken homepage URLs?


(git) Include the "core.longpaths" settings to be configured via parameters

If you worked with any project that has very long paths structure you've probably already faced this issue: Filename too long in git for windows

New versions of Git have the core.longpaths setting which allows you to checkout files by very long paths. I think it would be nice to have such parameter in the package.

This is great feature, thx for letting us know.
If anybody can provide what exactly needs to be added here we can push this ASAP.

@AdmiringWorm I agree, that this is something that should be specified after the installation.
Thanks.

Perhaps not useful in this case, but generally I support the concept of configuring app via package parmeters. I have several packages doing so, for example copyq hotkey can be set via parameter becasue its most important setting in which absent it stops the tool from being quickly usefl and you have to manually set it on each machine which takes time
After choco install config 'patch' is not readily available on random place as package parameter. My rundeck packages has few most important 'config params' as another example.


Update .gitpod.yml

Describe your changes
On line 5 in the .gitpod.yml file changed yarn run start to yarn dev
Screenshots - If Any (Optional)
Issue ticket number and link - If Any
#71
Checklist before requesting a review

[x] I have performed a self-review of my code.
[x] Followed the repository's Contributing Guidelines.
[ ] I ran the app and tested it locally to verify that it works as expected.

Additional Information (Optional)
Any additional information that you want to give us.

You are welcome and Thank You


Pex not allowing any commands in game or console

OK did they change the command structure or am just not doing something right?

What commands have you tried? Which version of PEX? Have you read the wiki for 1.x or the getting started guide for 2.x?

/pex group Owner create
/pex user Ironic_8b49 add permissions.*
either one I tried I got error in logs
[22:51:42] [Craft Scheduler Thread - 16/WARN]: Exception in thread "Craft Scheduler Thread - 16"  [22:51:42] [Craft Scheduler Thread - 16/WARN]: org.apache.commons.lang.UnhandledException: Plugin Autorank v3.8.2 generated an exception while executing task 29 	at org.bukkit.craftbukkit.v1_10_R1.scheduler.CraftAsyncTask.run(CraftAsyncTask.java:56) 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) 	at java.lang.Thread.run(Thread.java:745) Caused by: java.lang.NullPointerException 	at me.armar.plugins.autorank.permissions.handlers.VaultPermissionsHandler.getPlayerGroups(VaultPermissionsHandler.java:104) 	at me.armar.plugins.autorank.permissions.PermissionsPluginManager.getPrimaryGroup(PermissionsPluginManager.java:93) 	at me.armar.plugins.autorank.playerchecker.PlayerChecker.checkPlayer(PlayerChecker.java:54) 	at me.armar.plugins.autorank.playtimes.PlaytimesUpdate.updateMinutesPlayed(PlaytimesUpdate.java:63) 	at me.armar.plugins.autorank.playtimes.PlaytimesUpdate.updateMinutesPlayed(PlaytimesUpdate.java:81) 	at me.armar.plugins.autorank.playtimes.PlaytimesUpdate.run(PlaytimesUpdate.java:30) 	at org.bukkit.craftbukkit.v1_10_R1.scheduler.CraftTask.run(CraftTask.java:71) 	at org.bukkit.craftbukkit.v1_10_R1.scheduler.CraftAsyncTask.run(CraftAsyncTask.java:53) 	... 3 more

That looks like an error with Autorank, not PEX. You should talk to them about the issue.

Ok there was no change to the commands, Thanks


Production ready?

Hello,
I am making this issue to ask a few questions related to PasetoV4:

Is PasetoV4 is production ready? Has anyone had issues with it in a production environment?

and a bit more technical questions,

What is the best (most preferred) way to generate assymetric key pairs in hex for PasetoV4 tokens (for production use) ?

and last,

If I understood correctly, using the above way to generate our keys one time, we add to our environment file these hex key pairs:

PublicAccessToken
SecretAccessToken

as well as:
PublicRefreshToken
SecretRefreshToken

and use them for generating every other access and refresh tokens, right?
Thank you once again for your valuable time and I would really appreciate your reply.
Best Regards,
Filippos

Hey! 👋

Yes, it's production ready. I haven't had any reports of library issues manifesting in production, nor experienced any myself.
There are some constructor methods you could use if you want to generate keypairs with the library (create a new secret key, and the public one can be exported from it). Alternatively, you can generate a seed using 32 bytes from a CSPRNG and use that to construct the secret key. Or you can generate a Ed25519 keypair using a method of your choosing, obtain the byte or hex representations of the secret and public keys to be imported.
Note that depending on your use case, you may want to use domain separation between keys which will be used for different purposes (or by different subsets of users), so you might want more than one keypair depending on what you're doing.
The keys themselves would not be tokens, but having a different set of keys for minting access tokens and refresh tokens does look sensible to me. The secret key would be all you need when creating new PASETOs, and the public key would be all you need to verify new PASETOs. If both those operations are done by the same service, that service would need both values. If the create and verify operations will be done by different services, each service would only need the key corresponding to creating/verifying PASETOs (secret/public value).
Note that if you're creating and verifying tokens using the same service (with no need to verify the tokens outside that service) you could opt to use the local mode (which uses a symmetric key to both create and verify).


Launch space invaders on space

When triage was discussing JuliaLang/julia#33875, we discussed the prevalence of keyboard soup scattered across the ecosystem where different packages use different "magic keys" to launch repl modes. @oscardssmith mentioned "you can even press space for space invaders"
While several closed-minded triagers assumed he was joking, the merits of this keybinding are quite apparent

Space is a clear mnemonic for space invaders
The space bar is conveniently located in the center of the widely used BÉPO keyboard layout, and has a large surface area for user convince
No self-respecting line of Julia code entered at the REPL begins with a space

This PR makes pressing space at an empty julia> prompt launch space invaders.
In theory, this could be implemented as a package extension with REPL. However, according to several peer reviewed studies (source), there is growing concern among the Julia community that compile and load times are getting too low. This has resulted in decreased operational readiness in sword fighting atop rolling chairs (c.f. https://xkcd.com/303/). In an effort to rectify the situation, I didn't bother implementing this as a package extension.
As for the file name, while ".jl" is a classic ending, I think we can all agree that " .jl" is a bad file name, so I picked something a little more plain.

https://github.com/JuliaRegistries/General/pull/105025#issuecomment-2059539619

it's not allowed on windows apparently (https://stackoverflow.com/questions/1976007/what-characters-are-forbidden-in-windows-and-linux-directory-names/31976060#31976060), so we don't allow it (https://github.com/JuliaRegistries/RegistryCI.jl/blob/0cd9521b075913dc5b92485ca264b23daa6db9fb/src/AutoMerge/guidelines.jl#L631-L652)

Oh, that is sad, then even  .jl would not help for that file. Maybe 👾.jl then?


with* methods not visible when calling from C#

Hi. I have a ASP.NET 5.0 application that uses Razor Pages and C#. I want to generate a Cytoscape graph in the backend.
It seems to be possible to do this:
public string GraphHTML { get; set; }

public void OnGet()
{
    var graph = CyGraph.initEmpty();
    graph.AddElement(Elements.node("n1", new FSharpList<CyParam.CyStyleParam>(CyParam.label("TEST 1"), FSharpList<CyParam.CyStyleParam>.Empty)));
    graph.AddElement(Elements.node("n2", new FSharpList<CyParam.CyStyleParam>(CyParam.label("TEST 2"), FSharpList<CyParam.CyStyleParam>.Empty)));
    graph.AddElement(Elements.edge("e1", "n1", "n2", FSharpList<CyParam.CyStyleParam>.Empty));
    GraphHTML = HTML.toCytoHTML(graph);
}

However, I am unable to call withSize() or any other with* methods on the graph. This must be something F# specific that I am not familiar with. Any ideas on how to approach this? Thank you.

Seems like all the with* methods are static and can be accessed by passing an existing Cytoscape graph instance to those.


DropdownButton fails in Example toolbar

Running the example application on windows (desktop and edge browser) I find a problem:
In the editor demo: Selecting a word gives you a popup toolbar which shows the current style (e.g. header2). Clicking the down arrow should give a list of styles available. However, I get nothing - the toolbar disappears and I cannot change the style.

What am I doing wrong?

Thanks for filing this. Please let me know if #689 is the problem you're describing.

We haven't received any update on this issue, so I'm going to assume it's the same as #689 and close this as a duplicate.


Removed background from images, closes #32

Pull Request Template
Description
Changed the background of some images to improve the user experience
Fixes #32  (issue)
Type of change
How Has This Been Tested?
Just checking in the images to see if they had background or not
Checklist:

[X] My code follows the style guidelines of this project.
[X] I have performed a self-review of my own code.
[X] I have made corresponding changes to the documentation.
[X] I have added corresponding tests.
[X] Any dependent changes have been merged and published in downstream modules.

I was taking a look at the test failure in the job, it does not seem to be something wrong with the images, though 😄

I was taking a look at the test failure in the job, it does not seem to be something wrong with the images, though smile

Thanks for the PR @Guillergood , regarding the test failure - we are working on that as a separate issue and shall resolve it quickly, You may visit the issue here

The image in static/img/keploy-logo-twitter-card.png needs to be updates since Keploy logo has been changed.
Changes amended 👍🏻


Vanity URLs support for go-import's mod vcs

What version of Go are you using (go version)?

$ go version
go version devel +ecc7dd5469 Sat Sep 21 16:31:44 2019 +0000 linux/amd64

Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE="on"
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/erbesharat/.cache/go-build"
GOENV="/home/erbesharat/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/erbesharat/workspace"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/home/erbesharat/.test/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build190480021=/tmp/go-build -gno-record-gcc-switches"

What did you do?
I used this go-import tag in response to go get so I can use my custom proxy server to fetch the package and use it by the vanity URL, not the real package's import path.
<meta name="go-import" content="github.com/myreal/package mod https://example.test/modproxy">

What did you expect to see?
I expected to receive the mod requests (list, etc.) from go get on https://example.test/modproxy.
What did you see instead?
The mod meta tag gets skipped and go get uses the git vcs tag. Because the import path is not the same as the meta tag's prefix, it goes into this condition:
https://github.com/golang/go/blob/master/src/cmd/go/internal/get/vcs.go#L985

shouldn't it be more like:
<meta name="go-import" content="vanity.tld/module mod https://example.test/modproxy/github.com/myreal/package">

@seankhliao No, it doesn't work like that. It's because x should be a prefix of the given import path to go get.
<meta name="go-import" content="x mod y">

But afaik GitHub urls receive special treatment (making ?go-get=1) unnecessary, so if you want to change the import behavior you need a vanity url

I've tested it with a GitHub url too and in all cases, it goes to the mentioned condition.

@erbesharat, only the server at github.com gets to serve go-import paths for github.com (see https://golang.org/cmd/go/#hdr-Remote_import_paths).
Do you have a concrete example of this problem using your own server on a domain that you control?


Support Parquet Benchmark for BigInt and Double with different Filter and Null rates

This PR supports Parquet Benchmark for BigInt and Double with different Filter and Null rates on both Dictionary and Plain encoded Parquet files. Including:

Refactored the initial parquet benchmark so that it is able to support the benchmark on different types, filter rates, null rates and both Dictionary/Plain Parquet file encoding types.
Added the the element counter to the filter generator and increased the sample size to 65536 for more accurate filter rate estimation. Also, Added allowNulls to FilterSpec to generator non-null filters for the benchmark.

@liushengxuan Shengxuan, thank you very much for improving the benchmark! Could you include the benchmark result at the end of ParquetReaderBenchmark.cpp? You can use #ifdef 0 to comment it out. Also include the CPU model.
Another catch was, the data was actually dictionary encoded, not plain. Would you please rename readSingleColumnPlain to just readSingleColumn, and add benchmarks for plain encoding too? To do that you need to set the writer property
writerProperties_ = ::parquet::WriterProperties::Builder()
                          .disable_dictionary()
                          ->build();

@liushengxuan Running it in release mode gives this error:
E20221116 21:24:52.657351 20850011 Exceptions.h:68] Line: /Users/yingsu/repo/velox1/velox/velox/dwio/parquet/tests/reader/ParquetReaderBenchmark.cpp:202, Function:readSingleColumnPlain, Expression: resultSize <= upperBound && resultSize >= lowerBound Result Size and Expected Size Mismatch, Source: RUNTIME, ErrorCode: INVALID_STATE

@liushengxuan Running it in release mode gives this error:
E20221116 21:24:52.657351 20850011 Exceptions.h:68] Line: /Users/yingsu/repo/velox1/velox/velox/dwio/parquet/tests/reader/ParquetReaderBenchmark.cpp:202, Function:readSingleColumnPlain, Expression: resultSize <= upperBound && resultSize >= lowerBound Result Size and Expected Size Mismatch, Source: RUNTIME, ErrorCode: INVALID_STATE

Yes. It is a known issue. This is caused by the current sampling, which takes 4096 unique elements, without considering the number of appearance. So there is a chance that the filter error rate is pretty hight. I am working on this issue

@liushengxuan Running it in release mode gives this error:
E20221116 21:24:52.657351 20850011 Exceptions.h:68] Line: /Users/yingsu/repo/velox1/velox/velox/dwio/parquet/tests/reader/ParquetReaderBenchmark.cpp:202, Function:readSingleColumnPlain, Expression: resultSize <= upperBound && resultSize >= lowerBound Result Size and Expected Size Mismatch, Source: RUNTIME, ErrorCode: INVALID_STATE

I believe this issue is fixed in the PR. I introduced a counter and increased the sample size. So the estimated filter rate is more accurate.

@liushengxuan Shengxuan, thank you very much for improving the benchmark! Could you include the benchmark result at the end of ParquetReaderBenchmark.cpp? You can use #ifdef 0 to comment it out. Also include the CPU model.
Another catch was, the data was actually dictionary encoded, not plain. Would you please rename readSingleColumnPlain to just readSingleColumn, and add benchmarks for plain encoding too? To do that you need to set the writer property
writerProperties_ = ::parquet::WriterProperties::Builder()
                          .disable_dictionary()
                          ->build();

Addressed

@Yuhta this PR is the same as https://github.com/facebookincubator/velox/pull/3353
I will fix the #if 0 issue later today for both. Thanks!

@Yuhta this PR is the same as #3353
I will fix the #if 0 issue later today for both. Thanks!

@Yuhta I have fixed the #if 0 comment issue. Can you please review it? Thanks!!

@liushengxuan Also can you run dwrf E2EFilterTest under ASAN?  There are some undefined behavior with changes in FilterGenerator.


Label text overlaps the prefix icon in material theme

Label text overlaps the prefix icon when material styles are in use and the textfield is empty.
<link rel="import" href="../theme/material/vaadin-text-field.html">
...
<vaadin-text-field label="Unit price">

USD

</vaadin-text-field>

Actual outcome

This is a known limitation, which we accepted when implementing the floating label.
We would need to measure the width of the prefix elements and then set a CSS custom property value to be able to fix this.

So for now, consider using always-float-label theme variant when you are using a prefix or suffix.


Update to Netty 4.1.9/netty-tcnative 2.0.0

This updates Netty and netty-tcnative to their most recent versions. Perhaps most significantly, the update to netty-tcnative resolves the longstanding conflict between netty-tcnative and Tomcat's own (original) tcnative implementation, which makes life much easier for Tomcat users.

One very significant change in here: we're now relying on netty-tcnative-boringssl-static by default. This should make things work better out of the box for nearly all users. We've provided instructions for switching to a JDK SSL provider for users who can't use netty-tcnative-boringssl-static, but they should be few and far between. Users who want a statically-linked native SSL provider other than boringssl probably know what they're doing already ;)

sweet


Chore/update dependencies

Fixes #294
I’ve marked the largest changes with a ‘⚠’, not because they are a problem from my PoV, but because are interesting, or represent a a feature removal.
The following changes are contained in this pull request:

Update npm package versions where possible
Updates stylelint config to latest available from bitcrowd/frontend
Removes all post-css packages. Uses just stylelint for linting, and just node-sass for building. This should not affect any projects using bitstyles, as the bitstyles build chain is only used here.
Removes various metadata files related to publishing the package on bower, and as a gem. These are no longer useful, nor indeed used.
Updates the node version in .nvmrc
⚠Removes yarn.lock for now, as node-sass will only build when using npm 🤔. We should re-introduce this (instead of package.json, not both), when the issue with building node-sass/node-gyp is resolved
⚠ Removes all the styleguide-related files & setup. The SC-5 project is now abandoned. A newer styleguide/component-library should be found
⚠ Removes all the VRT backstopJS-related content, but retains the reference images for possible future use
Removes css parker, as it’s now unmaintained, and has several vulnerabilities. replaces it with Analyze-css, and updates the stats.json.
Updates the readme to reflect all the above

EDIT:
This results in one LOW-level vulnerability remaining, present in stylelint-config-bitcrowd > stylelint-order > stylelint > micromatch > braces

I’ve created issues to replace the styleguide & VRT runner: #298, and to investigate the problems installing/building node-sass/node-gyp #296

I noticed that the README still includes a sentence pointing to yarn. Since we change the lock-file, should we also take out that reference?

@lwassermann if you can successfully run yarn install (this works for me with no problems with node v13), I’d say we stick with yarn, and remove the package-lock.json (that’s the current state since my last updates)

@planktonic Installing node-sass with yarn was successful.

👍 ⛵


Background Issue

Hi there,
I'm not sure if it's related to this plugin but I got this gray background each time the biometric is fired.

Have you already encounter this kind of issue ?
Regards

That's odd, what iOS version? Simulator or real device?

Note that biometrics actually suspends the app, so if your app is hiding the screen on suspend, that's what you are seeing.

Thanks for the info, it leads me to the good path and this was caused from another plugin :)


Show revision with --version flag

It only show version.
It is required to show revision in --version flag.
To customize version format, see: https://cli.urfave.org/v2/examples/version-flag/

This issue is treated in #25, but it depends on the binary how it released.


Flextype Core: Forms - add new heading field

implemented
usage:
    fields:
      general_heading:
        title: admin_general
        type: heading
        h: 1


searches that starts with a dot gets no results

Hi all,
if i have a string on a page like ".test" and search for it, i get no results.
I tried several other symbols, it seems to be only an issue with the dot.
Any easy way to fix this?
Thanks!

Hi @Evoolo,
The search system works by breaking up the text on a range of characters, A list of which can be seen here in the code. This includes the . which means that what you are seeing is correct (Although annoying for your use case).
Alternatively you can quote search terms, like ".test" for example, to run a deeper less efficient search that will pick up searches with dots in them.
Let me know if that works for you.

Since the last comment on this issue is relatively old I'm going to close this. If the issue remains and the above did not work out for you please comment and this can be reopened if required.


Automated cherry pick of #2956: misc fix

Cherry pick of #2956 on release/2.10.0.
#2956: misc fix

Codecov Report

:exclamation: No coverage uploaded for pull request base (release/2.10.0@c2da048). Click here to learn what that means.
The diff coverage is 0%.

@@               Coverage Diff                @@
##             release/2.10.0   #2964   +/-   ##
================================================
  Coverage                  ?   7.46%
================================================
  Files                     ?     414
  Lines                     ?   66055
  Branches                  ?       0
================================================
  Hits                      ?    4931
  Misses                    ?   60701
  Partials                  ?     423

Flag
Coverage Δ

#aFlag
7.46% <0%> (?)

Impacted Files
Coverage Δ

pkg/baremetal/tasks/bm_register.go
0% <0%> (ø)

pkg/cloudcommon/db/db_dispatcher.go
0% <0%> (ø)

pkg/cloudcommon/db/modelbase.go
1.74% <0%> (ø)

pkg/compute/models/guests.go
0.66% <0%> (ø)

pkg/cloudcommon/db/namevalidator.go
0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2da048...16382bf. Read the comment docs.

/lgtm

/approve


Chewy::UndefinedUpdateStrategy raised in migrations even if specified

In a migration, we're attempting to dynamically set some default values for a new column added to a table and Chewy::UndefinedUpdateStrategy is being raised even though we have a default strategy set. Attempting to explicitly set a strategy does not work either and results in the same error.
Versions:
chewy 0.7.0
Rails 4.21
pg 0.18.1
Example:
class AddNewFieldToThings < ActiveRecord::Migration
def up
Chewy.strategy(:bypass) do
add_column :things, :important_value, :string, default: ""
  Thing.find_each do |t|
    t.important_value = <whatever>
    t.save
  end
end

end
...
The result is the same whether using def change or def up/down. Putting the add_column line before or after the Chewy.strategy does not make a difference either.
We also have Chewy.root_strategy = :bypass set elsewhere, but it does not prevent the exception from being raised (whether Chewy.strategy is present in the migration or not, the exception is raised).
:bypass would be fine since this field does not matter in our index for the time being.

And now I feel silly, this was fixed by Chewy 0.8.1 and I forgot to check for a new version first :(
So no problem here. :)

Yeah, this was a bug with rails 4.2 unfortunately :(


Old info in Helidon SE config documentation

The text below is present in https://helidon.io/docs/v3/#/se/config/mutability-support file. It's old and should be removed. The whole document needs to be re-checked and refreshed for 3.x.
Evolving API
 This section describes the Config.changes() method. It is marked as deprecated because it returns an io.helidon.reactive.Flow.Publisher object. In a future Helidon release that requires Java 11 or later this method will be un-deprecated and changed — or a similar method will be added — so that the return type is java.util.concurrent.Flow.Publisher instead.
 Any code you write using the existing Config.changes() method might need to change at that time.

@arjav-desai Can we close this issue now?


Fixes for latest versions

Hi @paul-gauthier, I'm trying to get this to work with the current versions and I faced the same issues in #5 . These are some updates to this repo, but some would need to happen on the Aider side.
This installation pins swebench==1.1.5 because report.py requires swebench.metrics.report.get_model_report which was removed from later versions (I'm not clear what they replaced it with).
There is an extra change I had to do to run SWE-Bench Lite that I haven't added here because there might already be a better way to do it. That change is to report.py, and it's about importing LITE_DATASET_FNAME and substituting it in most places that mention FULL_DATASET_FNAME. But there might be a better way to do that or existing functionality. I haven't read the code in detail yet.
On the aider side, what I've had to change was:
1- in repomap.py: in get_scm_fname Change except KeyError to  except (KeyError, TypeError)
2- Also in repomap.py:
change
 if not query_scm.exists():
            return

to
if query_scm is None or not query_scm.exists():
            return

Otherwise, it may fail when facing file extensions not in tree-sitter.
Also need to point out this now needs to be run in python 3.11. SWE-bench-docker's run_evaluations.py needs asyncio.TaskGroup.
So for my setup, I did this before installing the requirements:
conda create -n aider-swe python=3.11

@jalammar this is such good work 🙏 I was so confused when things weren't working but your changes helped me figure it out!
Just want to help bump this again to @paul-gauthier


Admin rights to start/stop a service

This documentation should explain how to get elevated rights for starting or stopping a service.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: cb78751c-57d3-5cec-b91d-a68a95b3a8e1
Version Independent ID: d323dec1-69c9-890f-45e4-d86bf9e789b0
Content: Windows services - Power Automate
Content Source: articles/desktop-flows/actions-reference/services.md
Service: power-automate
Sub-service: desktop-flow
GitHub Login: @mariosleon
Microsoft Alias: marleon

Hello @trajekolus. Thank you for reporting this. We are working towards adding this information and will be available soon.

Hello @trajekolus! We have updated our documentation and you can find a section regarding running Power Automate with elevated rights here.


Mode Changes Unexpectedly When QSYing to Call Sign

Describe the bug
When I click on a call sign in the Bandlist section, the radio QSYs (changes frequency) to the desired call sign, but the mode changes from CW-U (Continuous Wave Upper) to USB (Upper Sideband) unexpectedly.
Version Information
OS: [Debian 12]
PHP: [8.3.12]
MySQL/MariaDB: [11.3.2-MariaDB-1:11.3.2+maria~ubu2204]
Wavelog: [1.8.8]

Steps to Reproduce
Go to Bandlist in Wavelog
Click on a desired call sign
The radio QSYs to the selected call sign
Observe that the mode switches from CW-U to USB

Expected Behavior
I expect the radio to QSY to the selected call sign, but the mode should remain as CW-U instead of changing to USB.
Radio: FT991A
Interface between wavelog and radio : Wavelog-gate version v.1.0.16
Interface between Wavelog-gate and radio: FLrig 2.0.04

73
VU2TUM

pse update to latest WavelogGate - there's a new checkbox/option in it, which prevents changing of the mode:

Hi, I updated the wavelog-gate to latest version and the Set MODE via FLrig is checked. Still, the mode changes from CW to LSB or USB

na, uncheck it and save it.
Needs to be unchecked!

Thanks, Works now.


English strings end up in some non-english translation files

When running tx translator with tx_pull=1, we sometimes end up with english strings in non-english translation files.
For example in https://github.com/silverstripe/silverstripe-mfa/pull/506, we see several english strings being added to the de.js translation files. But when we look in transifex, those strings are explicitly not translated for de yet, so they shouldn't be pulled through.

Notes
I have a few thoughts about this:

This could be a result of running tx pull with both -t and -s flags together - we might need to run pull twice per module, once with each flag.
There might be a setting in transifex we need to change via the web portal.
As a last resort, we could simply unset any values in translation files that match their en counterpart.

Have confirmed locally that it's the tx pull step that's causing the en strings to show up in de.yml, so it's not something PHP related which would have been an easier fix
I've had a good look through transifex including on the settings page for mfa - https://app.transifex.com/silverstripe/silverstripe-mfa/settings/workflow/ and I couldn't find anything relevant
I tried change the tx command to tx pull -a - t -f (removing the -s) - it made no difference
I think the "As a last resort, we could simply unset any values in translation files that match their en counterpart." is a good idea.  We've probably already accidentally committed a bunch of en "translations" so makes sense to undo them.

PR merged. I'm on the fence as to whether this should be run now (just on 4.13 and merge up) or just wait until next time the issue is created - so I'll reassign to @emteknetnz and he can decide if that's in scope or not.

Next issue is in under 3 months, I wouldn't worry about it for now, we've had far more than enough automated PR's recently :-)  Practically speaking this won't make much of a difference because an erroneous english "translation" is do different from a missing translation defaulting back to english


Add dataloader combination

📚 Documentation preview 📚: https://metatensor-models--27.org.readthedocs.build/en/27/

@jwa7 this is the code combining dataloaders I mentioned.

@Luthaf Great thanks! Sometime in the near future I'll chat with @frostedoyster to see how to unify with the metatensor-learn Dataset/DataLoader :)


Feature request: native runtime errors

It would be great if native function calls can stop wr_run execution if it's needed. For example, in case of bad parameters supplied by script or some fatal unrecoverable error that must stop further script execution. Since the library already has WRError, it should be possible to easily extend it for 3rd parties:
enum WRError {
  ...
WR_ERR_user = 10000, // some big value to make some space for future library's errors
}

void wr_setLastError(WRContext* c, WRError error) {
     c->w->err = error; // not sure if "w" can be accessed like that
}

And then in wr_callFunction in all places where ccb is called, e.g.:
CASE(CallFunctionByHash):
{
	args = READ_8_FROM_PC(pc++);

	// initialize a return value of 'zero'
	register0 = stackTop;
	register0->p = 0;
	register0->p2 = INIT_AS_INT;

	if ( ! ((register1 = w->globalRegistry.getAsRawValueHashTable(READ_32_FROM_PC(pc)))->ccb) )
	{
		w->err = WR_ERR_function_hash_signature_not_found;
		return 0;
	}

	register1->ccb( context, stackTop - args, args, *stackTop, register1->usr );

        // ADD lines below:
        if (w->err) {
               return 0;
        }

        ....

P.S.: Sorry, if I'm opening too many issues :) I just want to share our feedback using this library and make it better. I think I also can help with implementation if needed.

Not at all! I would absolutely love help on the implementation. Also any
feedback/amendments on the documentation would be most welcome, it's hard
to keep up. Sort of a one-programmer operation here :P
On Sun, Jun 2, 2024 at 9:51 AM ohordiichuk @.***> wrote:

It would be great if native function calls can stop wr_run execution if
it's needed. For example, in case of bad parameters supplied by script or
some fatal unrecoverable error that must stop further script execution.
Since the library already has WRError, it should be possible to easily
extend it for 3rd parties:
enum WRError {
...
WR_ERR_user = 10000, // some big value to make some space for future library's errors
}
void wr_setLastError(WRContext* c, WRError error) {
c->w->err = error; // not sure if "w" can be accessed like that
}
And then in wr_callFunction in all places where ccb is called, e.g.:
CASE(CallFunctionByHash):
{
args = READ_8_FROM_PC(pc++);
// initialize a return value of 'zero'
register0 = stackTop;
register0->p = 0;
register0->p2 = INIT_AS_INT;
if ( ! ((register1 = w->globalRegistry.getAsRawValueHashTable(READ_32_FROM_PC(pc)))->ccb) )
{
w->err = WR_ERR_function_hash_signature_not_found;
return 0;
}
register1->ccb( context, stackTop - args, args, *stackTop, register1->usr );
    if (w->err) {
           return 0;
    }

    ....

P.S.: Sorry, if I'm opening too many issues :) I just want to share our
feedback using this library and make it better. I think I also can help
with implementation if needed.
—
Reply to this email directly, view it on GitHub
https://github.com/jingoro2112/wrench/issues/24, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AALIKAYOU5I3YSCWLXRQVRTZFMPMZAVCNFSM6AAAAABIVCV2ISVHI2DSMVQWIX3LMV43ASLTON2WKOZSGMZDSNRWG42TMMQ
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Okay, great. I'll try to do this feature this week.

oops sorry too late I already implemented it :P
Also putting finishing touches on import, new turned out to be a pain
because the namespace table is linked into the imported code, so I had to
change the bytecode format a bit and push to v5.0.0
On Sun, Jun 2, 2024 at 1:58 PM ohordiichuk @.***> wrote:

Okay, great. I'll try to do this feature this week.
—
Reply to this email directly, view it on GitHub
https://github.com/jingoro2112/wrench/issues/24#issuecomment-2143970095,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AALIKA6ZHRFXNN3UVABOBDDZFNMMZAVCNFSM6AAAAABIVCV2ISVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBTHE3TAMBZGU
.
You are receiving this because you commented.Message ID:
@.***>

Oh, no problem. Great you have already done it :)

okay so this is a PRE release version that includes import functionality.
it is NOT backwards compatible to 4.*
it includes wr_import(), sys::importCompile(), and sys::importByteCode()
Also there is sys::halt( err ) which takes an err argument between 100-255
as "user" level errors and will return immediately with that error.
I have some test code inside wrench_cli.cpp for the import testing but have
not added it to the unit tests yet, JUST got this working and am anxious
for you to try it out.
-Curt
On Mon, Jun 3, 2024 at 10:54 AM ohordiichuk @.***>
wrote:

Oh, no problem. Great you have already done it :)
—
Reply to this email directly, view it on GitHub
https://github.com/jingoro2112/wrench/issues/24#issuecomment-2145411587,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AALIKA6KZTDQUDUHZJM6P53ZFR7RXAVCNFSM6AAAAABIVCV2ISVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBVGQYTCNJYG4
.
You are receiving this because you commented.Message ID:
@.***>

OH.. in order for this to work you have to use the new "export" keyword on
structs that you want to export. this is not necessary for functions, they
just work, but 'export' ensures the namespace hash table is generated and
embedded in the bytecode, normally it only does this if it detects that you
'new'ed it somewhere. 'export' forces it to always be generated.
On Tue, Jun 4, 2024 at 12:48 AM Curt Hartung @.***> wrote:

okay so this is a PRE release version that includes import functionality.
it is NOT backwards compatible to 4.*
it includes wr_import(), sys::importCompile(), and sys::importByteCode()
Also there is sys::halt( err ) which takes an err argument between 100-255
as "user" level errors and will return immediately with that error.
I have some test code inside wrench_cli.cpp for the import testing but
have not added it to the unit tests yet, JUST got this working and am
anxious for you to try it out.
-Curt
On Mon, Jun 3, 2024 at 10:54 AM ohordiichuk @.***>
wrote:

Oh, no problem. Great you have already done it :)
—
Reply to this email directly, view it on GitHub
https://github.com/jingoro2112/wrench/issues/24#issuecomment-2145411587,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AALIKA6KZTDQUDUHZJM6P53ZFR7RXAVCNFSM6AAAAABIVCV2ISVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBVGQYTCNJYG4
.
You are receiving this because you commented.Message ID:
@.***>

Good job! We are happy to test it. But it seems you forgot to push the code into GitHub :)

okay current release implements this as sys::halt()


OCPBUGS-39084: normal user have to use projects no namespaces

Before

After

/cherry-pick release-4.17

/cherry-pick release-4.17


New release?

Would you mind making a new release? The screencasting + json-version functionality would be quite helpful to have.

Sure, I'll try to get one out today.

Done

:+1: Thanks  :bow:!


Fix issue #282

Description
Fixes #282
Type of change

Bug fix (non-breaking change which fixes an issue)

Testing steps
Done on CI
Checklist

[ ] make before_commit passes
[ ] updated documentation wherever necessary
[ ] added or modified tests if necessary
[ ] updated schemas and validators in insights-data-schemas in case of input/output change

Codecov Report
Base: 5.92% // Head: 5.92% // No change to project coverage :thumbsup:

Coverage data is based on head (b1593d6) compared to base (b697a1b).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@          Coverage Diff           @@
##           master    #330   +/-   ##
======================================
  Coverage    5.92%   5.92%
======================================
  Files          15      15
  Lines         827     827
======================================
  Hits           49      49
  Misses        778     778

Impacted Files
Coverage Δ

storage/storage.go
1.08% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Version Packages (beta)

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to beta, this PR will be updated.
⚠⚠⚠⚠⚠⚠
beta is currently in pre mode so this branch has prereleases rather than normal releases. If you want to exit prereleases, run changeset pre exit on beta.
⚠⚠⚠⚠⚠⚠
Releases
<EMAIL_ADDRESS>Minor Changes

#373 e04bddf Thanks @mrcjhicks! - - Updated S2 accordion tokens (non-color) in respective desktop and mobile layout sets

Added S2 meter tokens, including both color and non-color.

Design Motivation

Accordion component is being formalized as a Spectrum 2 component. These net-new tokens define the design data needed for implementation. Introducing content-area-edge-to-content tokens enhances inclusivity for various design patterns. For more information, view Jira ticket.
Meter component is being formalized as a Spectrum 2 component. These net-new tokens define the design data needed for implementation. Introducing static tokens enables us to standardize the use of tokens across various components with indicators and tracks. This includes progress bars, progress circles, and potentially sliders in the future. For more information, view Jira ticket.

Token Diff
Tokens added (18):

accordion-content-area-edge-to-content-extra-large
accordion-content-area-edge-to-content-large
accordion-content-area-edge-to-content-medium
accordion-content-area-edge-to-content-small
accordion-disclosure-indicator-to-text-extra-large
accordion-disclosure-indicator-to-text-large
accordion-disclosure-indicator-to-text-medium
accordion-disclosure-indicator-to-text-small
accordion-item-to-divider
meter-thickness-extra-large
meter-thickness-medium
static-black-text-color
static-black-track-color
static-black-track-indicator-color
static-white-text-color
static-white-track-color
static-white-track-indicator-color
track-color

Newly deprecated tokens (2):

accordion-edge-to-disclosure-indicator
accordion-disclosure-indicator-to-text

Tokens updated (1):

meter-thickness-large

<EMAIL_ADDRESS>Patch Changes

Updated dependencies [e04bddf]:

<EMAIL_ADDRESS>

Run report for f1e181a6
Total time: 28.7s | Comparison time: 28s | Estimated loss: 755.6ms (2.6% slower)

Action
Time
Status
Info

🟩
SyncWorkspace
0ms
Passed

⬛
SetupToolchain(node:~20.12)
1.3s
Skipped

🟩
InstallWorkspaceDeps(node:~20.12)
7.1s
Passed

🟩
SyncProject(node, tokens)
0.4ms
Passed

🟩
SyncProject(node, root)
0.2ms
Passed

🟩
SyncProject(node, csvGenerator)
0.3ms
Passed

🟩
RunTask(tokens:buildTokens)
18.4s
Passed

🟩
RunTask(tokens:buildManifest)
228.8ms
Passed

🟩
RunTask(root:test)
1.2s
Passed

🟩
RunTask(csvGenerator:generateCSV)
233.6ms
Passed

🟩
RunTask(csvGenerator:test)
1s
Passed

🟩
RunTask(tokens:build)
34.4ms
Passed

🟩
RunTask(tokens:generateDiffResult)
1.9s
Passed

Touched files
.changeset/pre.json
packages/tokens/CHANGELOG.md
packages/tokens/package.json
tools/token-csv-generator/CHANGELOG.md
tools/token-csv-generator/package.json


Vars in request context instead of location config; OAuth2Require

Hello,
I've made several modifications to the code:
The values of the variables were stored in the local config. A request with a valid token set them. A second request passing no token at all would retrieve the values of the previous token because the local config object would be shared among the requests.
The variables are now stored in an ngx_hash in a request context. It is destroyed after each request.
If the request passes no token the previous code still returned NGX_OK. Now we check if there was a OAuth2TokenVerify configuration directive for the location. If yes then we return NGX_HTTP_UNAUTHORIZED. An NGX_OK is returned only if there was no OAuth2TokenVerify configuration directive, meaning that the request is not 'for us'.
I've added the optional configuration directive OAuth2Require. It takes between zero and seven arguments. Every argument is a  variable name. The authorization callback returns NGX_OK only if every variable is defined and its value is the string '1'. We can combine the Nginx 'map' configuration directive and the variables that hold token values in order to synthesize the variables used by OAuth2Require. In this way we may check that the token holds desired values, for example that 'iss' matches a given regular expression or that the 'scope' is belongs to a required set.
This new configuration directive is optional. If absent then the module behaves like before, i.e. it returns NGX_OK if the token can be decrypted, parsed, and it is not expired.
I've modelled the configuration directive on auth_jwt_require in the commercial distribution of nginx (https://nginx.org/en/docs/http/ngx_http_auth_jwt_module.html#auth_jwt_require).
Here's how it can be used:
# inside the http block
        map $http_authorization $source_token {
                "~*^Bearer\s+(?<token>[\S]+)$" $token;
        }
        map $pfc_jwks_uri_iss   $valid_issuer {
                https://trusted.issuer.com/  1;
        }
        map $pfc_jwks_uri_scope $valid_scope {
                "~api-my-own-service:readonly"   1;
        }

        ...
# inside the location
        OAuth2TokenVerify $source_token jwks_uri https://keys.host/keys;
        OAuth2Claim sub $pfc_jwks_uri_sub;
        OAuth2Claim scope $pfc_jwks_uri_scope;
        OAuth2Claim iss $pfc_jwks_uri_iss;

        OAuth2Require $valid_issuer $valid_scope;

thanks, that looks very good indeed; it would be even better if you could pull (most of) that code up to liboauth2, into https://github.com/OpenIDC/liboauth2/blob/master/src/server/nginx.c and https://github.com/OpenIDC/liboauth2/blob/master/include/oauth2/nginx.h so that it is re-usable for ngx_openidc_module as well

I'll look into that, but I can't do anything before the end of next week.

I have adopted the "variables in request context" changes since they're clearly a security risk.
Wrt. OAuth2Require: am I right that it obsoletes OAuth2Claim ? Alternatively, would it be possible to merge the map functionality into OAuth2Claim ?

I don't think it obsoletes OAuth2Claim, as OAuth2Claim is just a mapping between token claim and ngx var.
The "map trick" is just a casual way to make "if" with ngx. There are a lot of ngx config that makes use of that.
OAuth2Require allows to set one (or more) variable values as mandatory to give access to location.
So there is no reason IMHO to merge these directives in any way.
BTW nginx+ jwt module works this way too (jwt claim into variable map into require)

@pladen thanks for chiming in, that clarifies things for me a bit; however, it still feels that OAuth2Require doesn't do anything that is specific to OAuth 2.0 or ngx_oauth_module; isn't there (or shouldn't there be) a generic directive that can be applied here, i.e. that matches a variable value against a map result?

Yes, I get your point.
You probably can make something with the "if directive" but it becomes very tricky if you need AND / OR logic because nginx does not have boolean operators (yes !).
When you practice nginx daily, you avoid IF as much a possible because "if is evil" :
https://www.f5.com/company/blog/nginx/avoiding-top-10-nginx-configuration-mistakes#if
So OAuth2Require have sense and this is why @smanolache adds it.
But I understand it would have been better implemented through a generic nginx directive.
To sum up, without OAuth2Require it is possible to just make
if ( $jwt_sub ) { return 403 ; }
But difficult to make something like (following code does not work)
if ( ($jwt_sub) && ($jwt_issuer="myidp") && ($jwt_scope ~= "readaccess") )
So, please, keep it !

I have now adopted - I think - all suggested changes with minor modifications and merged them into the liboauth2 master branch, to be released with liboauth2 1.6.3. I'm closing this as any further refinements/comments can be done as part of a new thread/issue/discussion. Looking for your feedback before releasing liboauth2 1.6.3 and ngx_oauth2_module 3.5.0, thanks!

thank you for your contribution!

I see your point about whether OAuth2Require belongs here or not. I think it can be argued both ways.
On one hand one could say that the module provides authentication only, i.e. no authorization. It authenticates the data found in the token. It is up to the application code to authorize the request, to take action depending on the data in the token.
On the other hand one could argue that OAuth2Require factors out the authorization into a common code, alleviating the application codes. It is also flexible enough to cover most application use-cases. And finally, it is only "additive" to the module, i.e. if the OAuth2Require directive is not used then the module behaves as if the requirements code was never added to it, in an authentication-mode only.


Add path ".well-known/jwks.json"

Hi
Add the path .well-known/jwks.json to the file common.txt

Linked PR is #549

Merged in now! Thanks


Issues in Data interface of Joints

Hacks have been done on the Data interface of Joints to fix it. This is likely not an issue anymore but @kangoananya will provide a minimal example to try and reproduce.

@chenkasirer @kangoananya delete?

this whole inheritance tree has been reworked. closinggg


Custom Metadata Type DLRS causes error when saving record.

I've been using the newest version of DLRS (2.3) in a Sandbox environment and most of the Custom Metadata types work great, but there are times when the Metadata DLRS does not work, and I need to revert to using the original Lookup Rollup Summaries tab. In this scenario, I need to rollup information from one record on an object to that record's parent (all custom fields). When using the Metadata DLRS, I receive an error upon saving the record:
"Error:Apex trigger dlrs_NU_EventTrigger caused an unexpected exception, contact your administrator: dlrs_NU_EventTrigger: execution of AfterUpdate caused by: System.NullPointerException: Attempt to de-reference a null object: Class.dlrs.RollupService.updateMasterRollupsTrigger: line 894, column 1"
Here's an example:
Metadata DLRS:
When enabled, I get an error when trying to populate the Relationship field that the DLRS is referencing.

Lookup Rollup Summary:
When I setup the same DLRS under Lookup Rollup Summaries, and activate it, I am able to successfully update the record without an error.

The debug log for the error is here:
Custom Metadata DLRS Debug Log.txt
Any info you can provide about changes I can make to the Metadata record would be great, or maybe it's an issue that needs to be corrected in the package, but either way, thought it might be helpful for you to have the information to troubleshoot.
Thanks!
Mollie

When you use the Custom Metadata route, it creates 'shadow' records in the old Custom Object based rollups, the error your getting suggests these records have been deleted. Can you check what records you have in the original Lookup Rollup Summaries tab.
BTW, the error your getting is this (as per your attached log), i don't see an error relating to populating the Relationship field, am i missing something?
08:35:03.64 (434978952)|FATAL_ERROR|System.NullPointerException: Attempt to de-reference a null object
Class.dlrs.RollupService.updateMasterRollupsTrigger: line 894, column 1
Class.dlrs.RollupService.handleRollups: line 777, column 1
Class.dlrs.RollupService.triggerHandler: line 307, column 1
Trigger.dlrs_NU_EventTrigger: line 7, column 1
08:35:03.64 (434997200)|FATAL_ERROR|System.NullPointerException: Attempt to de-reference a null object

@mjhill86 I do think there is some kind of issue here, so i'm going to make it a bug, even though we don't have a repo we can try to find one.

Ok, so this issue is a duplicate of one i've just fixed in v2.5, please upgrade to that version and try again. Thanks.