Code quality framework definieren

ABSTRACT - Objective: This document prescribes the criteria that must be met by the subject software (or explicitly waived) before the subject software is allowed to be brought under Open Source license at https://github.com/TNO. As of yet, to the authors best knowledge, no TNO policy has been established that somehow adopts the notion that software, which has been produced by or under the aegis of TNO, should meet some quality criteria in order to maintain her reputation and displayed level of expertise.  As soon as such policy will emerge, the authors are happy to either migrate to it, or integrate its constraints into this document. As a result, and until that moment, the content of this document does not represent the view of TNO or any of her affiliates but those of the authors only. Despite this restriction, the authors have taken all measures to balance quality demands with the pragmatics that come with software authoring, in order to produce a set of criteria that, when met, will show a CMM level 3 - “Defined" (capability maturity level in software development).
Method: We will choose and describe quality dimensions and their underlying quality attributes from, e.g., the extended ISO 9126 model of software quality [+ref]. We will then describe for each quality attribute its definition, the criterion to achieve and the measurement method along which its abidance can be established.
Results: A list of measurable quality criteria for which each case can itself decide whether or not to meet.
De richtlijn voor de code review zou moeten zijn dat een 'outsider' binnen 1 uur voldoende informatie over de opensource repository kan vinden om een idee te krijgen over de volgende vragen:
- Waar dient het software voor?
- Is het stabiel or niet?
- Hoe werkt de software?
○ Uit welke componenten bestaat de software?
○ Waar kan ik de verschillende componenten vinden?
○ Hoe bouw/start ik de software.
- Welke licentie heeft de software?
Onderdelen van een code review:
- Documentatie (zowel commentaar in de code als readme.md)
- Leesbare code (volgens Leesbare code (volgens code convention van betreffende programmeertaal)

irrelevant


[release-v1.1] Handle KafkaChannels with long names (#1172)

Signed-off-by: Pierangelo Di Pilato<EMAIL_ADDRESS>backport of 1172
to at least keep the 1.1 deps in-sync... just.in.case.  :smile:

/cherry-pick release-v1.2
just in case...

/assign @pierDipi

/close


High Constrast mode for skillsmap

We need high contrast mode for skillmap in the settings.

This is implemented.


Add AppleScript commands "Export" (feature request)

This will make it possible to automate the archiving of recording time.

:+1:

Cool! :)


Update 4-invoke.sh

There is a Invalid base64 error appear. need to add to fix the issue.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

I encountered the same error when running the 4-invoke.sh script in the sample-apps/blank-java project. However, I was able to resolve the error by making the same change.

I realized that I need to incorporate configuration based on the following instructions.
If you use the AWS CLI v2, add the following to your [configuration file](https://docs.aws.amazon.com/cli/latest/userguide/cli-configure-files.html) (~/.aws/config):

cli_binary_format=raw-in-base64-out
This setting enables the AWS CLI v2 to load JSON events from a file, matching the v1 behavior.


Support for Horizontal Indent Lines to Create Tree-Like Structure

Problem
Currently, indent-blankline.nvim supports vertical indent lines, but it lacks the ability to render horizontal lines, which would make code with nested structures easier to visualize. For example, in Flutter projects with deeply nested Widgets, the tree-like structure of the code could be better represented with a combination of horizontal and vertical lines.
Expected behavior
Introduce the ability to add horizontal lines (─) in combination with vertical lines (│, ├, └) to create a tree-like visual representation of nested code. This feature should:
1.	Integrate seamlessly with existing Treesitter-based context detection.
2.	Dynamically render horizontal lines where needed (e.g., between sibling blocks or branching points in code).
3.	Support customization of characters used for horizontal and vertical lines.
4.	Enhance the readability of deeply nested code structures in languages like Dart (used in Flutter), JSON, and YAML.
This feature would significantly improve the plugin’s utility for developers working with complex nested code, making it easier to understand the hierarchy at a glance.
Is it worth the cost? Yes, as this feature would extend the usability of the plugin for a broader range of users and use cases, particularly in frameworks like Flutter or configurations using YAML/JSON files.

Sorry, this is out of scope for this plugin.


how much is this work related to Videopose, Attention ?

Hi, thanks for sharing your brilliant work. awesome!
i tested training and visualization code as you directed.
it worked very well.
now, i am finding ways to try Pose3D-RIE for inference with in the wild video.
so I am considering using visualize part of videopose3D
you think is that possible?
I wonder for which part this work is sharing with videopose.

This is possible, the visualization code provided in VideoPose3D is compatible with this repo. I provided the inference code on in-the-wild videos in another repo. Feel free to use it :)


Add binding gen js for remote and local

Added FileReader to config for reading files locally, so it can be mocked out for testing.
Moved shared objects to common module
Added support for js docs
With flix version 1.1 there'll be a return type that can be added to js docs for scripts.

How will we know these templates generated are compatible with the user's installed version of FCL?  What if the interface of FCL changes in FCL 2.0, 3.0, etc?  Or, what if flixkit-go leverages new FCL features in the future, but the user is using an older version of FCL?

How will we know these templates generated are compatible with the user's installed version of FCL? What if the interface of FCL changes in FCL 2.0, 3.0, etc? Or, what if later version flixkit-go leverages new FCL features in the future, but the user is using an older version of FCL?

Good point and good catch.  It would create a javascript dep that I don't want to force on the consumer of the javascript.
I'll add some verbiage in the comment block of the generated javascript that indicates they need version 1.3.0 or greater.

@jribbink @bthaile
In FCL we try to "normalize" the interaction template before its used, and in doing so we check that the version of the interaction template is compatible with that version of FCL:
eg: https://github.com/onflow/fcl-js/blob/master/packages/fcl/src/normalizers/interaction-template/interaction-template.js#L1-L13
So we do have some safeguards today around versioning. That said, we may want to think up a more elegant solution that doesn't require us to release a new version of FCL when a new version of Interaction Template is released.

@bthaile It's a bit of a black box right now unless you know the tools well. Even for me with some context it takes a little to figure out what is happening. This is a new feature and should require docs added. Can you create a page explaining this, how to use it, and what a library needs to do in order to add their library? Then can you link that page off the repo under a new section?

I added usage verbiage in readme, it ended up being really simple.


Release c3673d8

Good day,
I'm chasing down trying to upgrade my vault modules, and noticed that the v1.8.0 of this project uses the old module path, but has been fixed in c3673d8.  May we have a release for this change please?
Cheers.

Thanks for the nudge, released https://github.com/johanbrandhorst/certify/releases/tag/v1.8.1


Conn.Stat().Extra and Stream.Stat().Extra are nil. Cannot assign values.

It is currently impossible to assign values to the Extra map from within a net.Notifiee method.  Indeed, in e.g. Notifiee.Connected(), conn.Stat().Extra is nil.
It would be nice to have an initialized map, here, as it allows library users to pass around contextual information.  An alternative might be to extend https://github.com/libp2p/go-libp2p-net/issues/32 to support a WithContext() method similar to http.Request.  This would allow users to bind contextual data to connections/streams via context.Context, which feels a bit more idiomatic.
Thoughts?

Makes sense.  Feel free to close this.


KYLIN-4245 SqlConverter returns wrong syntax SQL when SqlParser fails…

… for JDBC source
Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
Types of changes
What types of changes does your code introduce to Kylin?
Put an x in the boxes that apply

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation Update (if none of the other choices apply)

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[x] I have create an issue on Kylin's jira, and have described the bug/feature there in detail
[x] Commit messages in my PR start with the related jira ID, like "KYLIN-0000 Make Kylin project open-source"
[x] Compiling and unit tests pass locally with my changes
[x] I have added tests that prove my fix is effective or that my feature works
[x] If this change need a document change, I will prepare another pr against the document branch
[x] Any dependent changes have been merged

Further comments
If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc...

Codecov Report

Merging #1179 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #1179      +/-   ##
============================================
- Coverage     25.00%   25.00%   -0.01%
- Complexity     6251     6255       +4
============================================
  Files          1449     1449
  Lines         88499    88536      +37
  Branches      12373    12381       +8
============================================
+ Hits          22129    22135       +6
- Misses        64190    64223      +33
+ Partials       2180     2178       -2

Impacted Files
Coverage Δ
Complexity Δ

...in/sdk/datasource/framework/conv/SqlConverter.java
91.17% <100.00%> (+0.85%)
7.00 <3.00> (ø)

...ream/core/storage/columnar/ColumnarStoreCache.java
50.00% <0.00%> (-2.28%)
7.00% <0.00%> (-1.00%)

...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java
69.30% <0.00%> (-0.31%)
7.00% <0.00%> (ø%)

...ava/org/apache/kylin/rest/service/CubeService.java
0.00% <0.00%> (ø)
0.00% <0.00%> (ø%)

...ache/kylin/metrics/lib/impl/hive/HiveProducer.java
0.00% <0.00%> (ø)
0.00% <0.00%> (ø%)

...a/org/apache/kylin/dict/Number2BytesConverter.java
82.53% <0.00%> (+0.79%)
18.00% <0.00%> (+1.00%)

...g/apache/kylin/common/util/CliCommandExecutor.java
31.70% <0.00%> (+2.95%)
9.00% <0.00%> (+3.00%)

...he/kylin/dict/lookup/cache/RocksDBLookupTable.java
78.37% <0.00%> (+5.40%)
7.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa4f72d...422fd3c. Read the comment docs.


Line/column indicator only updating at one side in Diff mode

Issue Type: Bug
Steps to Reproduce:

Compare two files
Move the cursor on the left side
The line/column indicator it does not update

Indicator working properly

Indicator not working properly(Should be "Ln 4, Col 3 (9 selected)")

VS Code version: Code - Insiders 1.54.0-insider (52838cf6799cc448e738677ec37e86cf62a5bd89, 2021-02-05T05:17:50.117Z)
OS version: Windows_NT x64 10.0.19042

It's even worse for me because I have line numbers turned off.

Historically, we have made the status bar only work with the right-hand-side editor. That is true for the line number; column indication, but is also true for the file encoding, indentation selector, EOL selector and language selector.
fyi @bpasero


Update CasePathableMacro to SwiftSyntax's latest API

Hi @Ryu0118, thanks for taking the time to do this, but this is actually an old experimental branch that we aren't using anymore. I'm going to close this for now.


CFE-380: Mount Kubelet-serving-ca configmap to the agent daemonset

Updates node-observability-manager-controller RBAC so that it can get configMaps cluster-wide
Upon creation of the agent daemonset:

Uses the KubeClient to get configmap kubelet-serving-ca in namespace openshift-config-managed
Makes a copy of that configmap in node-observability-operator namespace, making the owner reference the nodeobservability object
Creates the daemonset with the contents of the configmap mounted in /var/run/secrets/kubelet-serving-ca/ca-bundle.crt

/test e2e-gcp

/lgtm

/test e2e-gcp

/lgtm

/label docs-approved
/label px-approved
/label qe-approved

/label tide/merge-method-squash

/retest-required

/lgtm


Feature Request: show an indicator if there's a bell in the tab

Description of the new feature/enhancement
This is a pretty straight-forward one. I know iTerm2 has this. As a ex-iOS developer I found it very useful to not only hear the bell but also know which tab is actually triggering the bell.

Proposed technical implementation details (optional)
I think we need a spec for this, to display some kind of accessories in the tab, besides icon and title.

OK now that I think of it, the title is kinda bad. @zadjii-msft Please help me with my English and change the title to something more explanatory.

OK now that I think of it, the title is kinda bad. @zadjii-msft Please help me with my English and change the title to something more explanatory.

Oh I knew exactly what you meant by this, don't sweat 😆
We've had mockups of this dating back to some of the earliest Terminal mockups actually. I'm surprised we didn't already have an issue for it, but that makes sense considering we only just landed the bell in #7679.
I'm mildly worried that we're going to be stuffing a lot of info into the tab pretty soon - the "zoom" indicator, the progress ring, the bell/mute indicator, but I'm not that worried. I think the number of people who are doing all simultaneously will be fairly low.

OK now that I think of it, the title is kinda bad. @zadjii-msft Please help me with my English and change the title to something more explanatory.

Oh I knew exactly what you meant by this, don't sweat 😆
We've had mockups of this dating back to some of the earliest Terminal mockups actually. I'm surprised we didn't already have an issue for it, but that makes sense considering we only just landed the bell in #7679.
I'm mildly worried that we're going to be stuffing a lot of info into the tab pretty soon - the "zoom" indicator, the progress ring, the bell/mute indicator, but I'm not that worried. I think the number of people who are doing all simultaneously will be fairly low.

If you decide to implement the status bar, things like Zoom indication could go there.  I see little reason you need to know a tab's console has been zoomed, unless it is the current active tab.

This is closely related to #1608, if not a duplicate.

I agree that this is closely related, but I'm gonna hold off calling this a dupe. I think I'd rather have this issue specifically track displaying the bell icon in the tab, and the other issue for displaying the alert in the taskbar. They're pretty similar, but I could see people wanting one or the other (or neither, or both), so we should probably have them all configurable independently.
I'll add both of them over to #6700, because they're sorta related. They're all about displaying some state to the user either with the tab or the taskbar.

How long should a bell indicator stay on the tab btw?

Maybe like 1 second, then a 1 second fade? I suppose it should be just about the same as if a Edgium tab played a bell, for consistency.

Also, @mpela81, if you're interested in working on this, you might want to hold off until #8227 is merged. That might make adding the XAML element to the header a bit easier 😉

While the audible bell is very annoying, the visual bell is kinda hard to notice. Maybe instead of plan bell icon, 🔔 can be used? Also bell icon only prepends to tab title, maybe It can be appended to taskbar title too. Or superimpose a little bell icon to taskbar's terminal icon....


Add deprecation warnings

Add messages during Gradle execution when any of those is used:

useVersion2Compat()
generateTestBuilders
useSchemaPackageNameForFragments
codegenModels.set("compat")

There is no way to disable the warning besides actually migrating, which I think is ok.

Heads up I'm moving this to draft to put any other future deprecations at the same time. This way we can properly signal a "deprecation" maintenance release in the changelog


Add a clifford align option for rb

Summary
Details and comments

https://github.com/Qiskit/qiskit-ignis/issues/140


Using Wire1 the sensor doesnt works in M5CoreInk and M5Atom

Summary
Testing the library with normal setup works, but when I try to have to I2C channels, this sensor doesn't works, and other sensors with other libraries with the same validation works fine
Case of use
The next code works fine if you only use Wire.begin(). But if you use Wire1.begin(x,y) before, the sensor doesn't works alone
void Sensors::am2320Init() {
    sensorAnnounce(SENSORS::SAM232X);
    #ifdef ESP32
    this->am2320 = AM232X(&Wire);
    if (!am2320.begin()) {
        this->am2320 = AM232X(&Wire1);
        if (!am2320.begin()) return;
    }
    #else
    if (!am2320.begin()) return;
    #endif
    am2320.wakeUp();
    sensorRegister(SENSORS::SAM232X);
}

Tested with ESP32 M5Stack Atom lite and TTGO T7 board.

Thanks for reporting this issue.
It is a configuration I did not test. The code of begin() currently does not handle Wire1 for ESP. (Wire is hard
coded iirc) Need to investigate, can take a week or two.

Already had some minor edits on this one, and a quick look at begin() made me think it is easy to fix.
So I created a develop branch so you can test and verify.
The following should work on ESP platforms - just a snippet, no HW to test

#include "AM232X.h"

AM232X AM(&Wire1);    <<<<<< Wire1 as parameter here, do not forget &

void setup()
{
 ...
  AM.begin(x, y);       <<<<< preferred pins here
}

give it a try.

it's issue is very weird, because yesterday I try to replicate the issue on other board, and works fine. In the M5 Atom with the sensor connected alone, without any sensor more in the i2c line, it doesn't works, but, if I connected a BMP280 sensor together in the same i2c, the two sensors are detected. Sounds like maybe the BMP280 sensor library doing anything, I don't know what,  that it produced that  the AM2320 worked.
I need research more the issue, but sounds like only fails on M5 Atom board.
The source code right now it's in development, is a wrapper that I'm working in this branch and PR:
https://github.com/kike-canaries/canairio_sensorlib/pull/126

Could be

voltage level
a pull up on the BMP280?
the order of initialization?
The latter can be tested by swapping the order of initialization.

I'm going to try the test the order, because I don't believe that it is a hardware issue, because the sensor works fine together other sensors.

The source code right now it's in development, is a wrapper that I'm working in this branch and PR:
kike-canaries/canairio_sensorlib#126

Nice project!

Thanks, the idea is improve the architecture, with a driver base class and register the drivers, but right now its possible have two registers, one for variables and other one for sensors type, with that is possible have a dynamic firmware with dynamic GUI, like the CanAirIO firmware (on the testing OTA channel. I'm close to release this version).
Of course, all it is possible by the third party libraries like you library, thanks :) .. I need put these credits.

@hpsaturn
Is there a difference in the processor type of the  M5 Atom  and the TTGO?
(both ESP32 but still different...)

Maybe because it is initialized twice?
Or should the wire->setClock(100000); be called explicitly?

I remember that I did both test but nothing. This weekend I'm going to try to check again this possibilities. Thanks for your suggestions.

Do you have a link to M5 atom core?
If time permits i can have a look too.

Yes, is this:
https://shop.m5stack.com/products/atom-lite-esp32-development-kit?variant=32259605200986
But sounds like it is over. But is possible with other resellers you can find it.

M5 Stack atom - ESP32-PICO-D4 Chip:
TTGO - probably ESP32 Wrover
sounds like different versions of the processor.
Compile wise they seem to use the same code. Had a brief look and saw no conditionals referring to PICO or so in the I2C code.

I cannot find any cause so I merged the PR as now the begin(x,y) uses the two-wire interface given as parameter of the constructor. Default this is Wire so code is still backwards compatible.
If the issue is not solved and you can find the cause of the problem to be in this library please reopen this issue.


Water level trigger

Closes #57
The service endpoint for the trigger on the Edmonton Open Data Portal Water Levels and Flows dataset.
This trigger gives back the average and delta of the water levels over a one day, three day, and one week period. It also gives back a "latest water level" measurement ingredient.
This triggers whenever the dataset is updated since the dataset being watched is not updated in real-time.

@j-rewerts Got the last change request in. Please have a look at it and let me know what you think!


Give Slacks and SUNSfan a Hero Health bar instead of Unit Health bar

They should have health bar like heroes to make their bar more obvious when the line "Why do I have a health bar on me" is active.
If I remember correctly, "ConsideredHero" "1" in the unit kv file should do the trick

We should also hide their health bar until they become attackable (because the dialog says "why do I have a health bar").


First Site Visit

First Site Visit
User Story
AS A developer who writes about tech
I WANT a CMS-style blog site
SO THAT I can publish articles, blog posts, and my thoughts and opinions
Acceptance Criteria
GIVEN a CMS-style blog site
WHEN I visit the site for the first time
THEN I am presented with the homepage, which includes existing blog posts if any have been posted; navigation links for the homepage and the dashboard; and the option to log in

Application now meets all acceptance criteria


Allow defining own functions in the func_map

Feature description
I would like to be able to define my own actions. Currently, bqf supports only a list of functions defined in lua/bqf/keymap.lua table actionFuncref which can't be modified.
So, for example, if I would like to define a split function that wouldn't close the quick fix window I would have to do my own autocmd that will be binding the keys which is quite clumsy.
Describe the solution you'd like
Add func_ref key to the configuration that will allow users to define their own functions and then just merge it into the autoFuncref.
Additional context
No response

https://github.com/kevinhwang91/nvim-bqf/issues/39

Well, the point was exactly to avoid such constructs.


Update wrong/missing entries in autocompletion of GDScript keywords

Adds null and class_name (I'm not sure if null should be there) and removes tool

Thanks!


distgit.py: tweak canonical_builders logic for parser

have the correct logic whether user specifies on or "on"

/lgtm


Unit testing for garbagecollector package

Add unit testing for internal/stackql/garbagecollector.
Acceptance Criteria:

85% unit test coverage.

@general-kroll-4-life Can I work on this?

@ryuichi-maeda defnitely yes, have assigned it to you and moved to in progress.  Thanks again  😎


Fix as_samples() when given a sampleset and a labels_type

Adds missing case from 156d9787978a620d010dd0ddb7bdf168482d1cef. See https://github.com/dwavesystems/dimod/pull/1222

Should there be a unit test for dimod.QuadraticModel.energies(sampleset)? (This is what triggered this bug for me initially)

You know, why not. We should probably have something like https://github.com/dwavesystems/dimod/blob/44f23f410138bdc4483512572de01c7d4334ba19/dimod/testing/sampler.py#L76 but for samples-like. And can then use that everywhere.

Didn't end up adding a new testing function, but did add some more test cases.


Cordova video plugin with looping control?

What video plugin can I add to my project that will have a looping control button when exercising a link to a local video?
Is this it?!

HTML5 video can loop. you can use videogular (angular) or video.js.


add collision detection, enabled by default

Fixes #36

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.51%. Comparing base (fecad69) to head (fa1a114).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #43      +/-   ##
==========================================
+ Coverage   98.21%   99.51%   +1.30%
==========================================
  Files          42       15      -27
  Lines         895      207     -688
==========================================
- Hits          879      206     -673
+ Misses         16        1      -15

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Using brackets with pre-selected text removes the expression

https://user-images.githubusercontent.com/52647986/197335823-3a1921d1-6b3d-4a89-a438-03664504c4c3.mp4

hi! @DaSh-More
on my windows version of obsidian v0.16.4, the enclosing of selected text with brackets is already an inbuilt function of obsidian. whether the plugin is active or not the function is still present... sorry I wasnt able to replicate your issue ... might it be due to the version of obsidian you are using?

Maybe I have Obsidian 1.0.0 and didn't seem to have this problem before the update

https://user-images.githubusercontent.com/52647986/197466543-cc0314a3-c314-4962-bac4-1c030a86c683.mp4
An interesting point is that if you select text from right to left, everything works fine, but if from left to right, the expression is deleted. Apparently it has something to do with which position is considered the initial and which is the final

Hi! @DaSh-More
Thank you so much! This did help to pin-point the bug!
I have resolved this issue in v2.5.1.  Please kindly update the plugin and see it works well on yourside.


MaxDataDiskCount is lower for Classic RDFE VMs

CRIs 57005309 - 58844713 - 53789825 ...
Customers with Classic VMs are reporting that MaxDataDiskCount is 2x lower that what's written in the doc. Confirmed in Source Code. They would get errors like the one below if they try to add another Data Disk
Too many data disks specified for virtual machine netserv. The maximum number of data disks currently permitted is 4. The current number of data disks is 4. The operation is attempting to add 1 additional data disks
In order to stop them opening cases / CRIs, we need to update the doc.

@cynthn - Would you review the proposed changes? Thanks

Thanks @axelgMS
@cynthn Please review and #sign-off if appropriate

Also @jonbeck7 in terms of adding Classic information on the docs otherwise focused on Resource Manager.
Personally, I'd #hold-off on this.

Yeah, Jon is aware of this and I thought they were discussing a fix in last week’s VM sizes meeting. I’ll ping him and ask what the long term plan is….
From: Iain Foulds<EMAIL_ADDRESS>Sent: Thursday, February 15, 2018 5:19 PM
To: MicrosoftDocs/azure-docs<EMAIL_ADDRESS>Cc: Cynthia Nottingham<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/azure-docs] MaxDataDiskCount is lower for Classic RDFE VMs (#4726)
Also @jonbeck7https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fjonbeck7&data=04|01|cynthn%40microsoft.com|2e08d539ed1e44e6c47808d574db3975|72f988bf86f141af91ab2d7cd011db47|1|0|636543407264436670|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwifQ%3D%3D|-1&sdata=pfvVhlnvqqoe8AeoinuEhaAULWhQt55T%2Fl2OsrGwZwM%3D&reserved=0 in terms of adding Classic information on the docs otherwise focused on Resource Manager.
Personally, I'd #hold-off on this.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fazure-docs%2Fpull%2F4726%23issuecomment-366117379&data=04|01|cynthn%40microsoft.com|2e08d539ed1e44e6c47808d574db3975|72f988bf86f141af91ab2d7cd011db47|1|0|636543407264436670|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwifQ%3D%3D|-1&sdata=IFYNUcwPVINkOSVVyR9KMFZzi465WPOwMXjeRvLL8mI%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAIVkxOnUJ0WonSzcVnOMNgtbusjRDSYcks5tVNd0gaJpZM4R24mI&data=04|01|cynthn%40microsoft.com|2e08d539ed1e44e6c47808d574db3975|72f988bf86f141af91ab2d7cd011db47|1|0|636543407264436670|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwifQ%3D%3D|-1&sdata=yzwuvU65fiNsWuqLvYMMVvqZCzamCIxltb%2Bf37%2B8hQs%3D&reserved=0.

#sign-off @axelgMS thanks for the contribution! I'm going to merge your change in for now and work with the PM team longer term to decide how to handle differences between classic and Resource Manager.


Mirror to Docker Hub alternative

cross post from https://github.com/kubernetes/ingress-nginx/issues/6666
Now that Docker hub has a rate limit in place could it be considered offering a mirror of the images to for example gcr.io or quay,io? I was hit hard by this when installing ingress-nginx which uses your Docker images making the installation of the webhooks hang.
Thanks!

Was bit by this as well... we found alternative registries for all our images except this one.

Was bit by this as well... we found alternative registries for all our images except this one.

Don't have any information on this right now. I will post an update here when I have some news.

Don't have any information on this right now. I will post an update here when I have some news.

Would love to see this as well, was just bit by this.

+1 on this too. Looks like this is the only viable solution as if you even use a private registry mirror by overwriting the image/registry, if your private registry requires authentication it will fail as you need to patch the service account with the credentials from registry-creds. Only issue with that is, you cannot patch the service account until it exists and it only exists after the image is pulled 😅

@meyskens k8s.gcr.io/ingress-nginx/kube-webhook-certgen is now the upstream image I believe. Maybe we can close this issue then?


Issue with double datasets doughnut

I have a doughnut chart.js with 2 datasets.
The outlabels are in the same point of the screen an i can't read...
i'ts posible move the line and put at the left side ? or any ideas....
thanks!

Can you provide more detailed info? An example would be great (live/code).


DFP pipeline module

Morpheus modules implementation for DFP (Azure, Duo) pipeline training and preprocessing stages
Added modules utility
Moved column_info.py to morpheus.utils
Added tests
Updated digital fingerprinting production example README.md
Added dask and distributed packages
Updated DFP production examples notebooks

/ok to test

rerun tests

/rerun tests

@GPUtester rerun tests

/merge


Use libayatana-appindicator instead of appindicator

The Ayatana Indicator is the continuation of Application Indicators.
It will be marked as deprecated in debian bullseye(next debian
stable - Debian 11)
libayatana-appindicator-dev is already packaged for Debian buster
(Debian 10) and Ubuntu bionic (18.04) or later. so it is time for switch.

Could you review this PR please? @mattn


Error during update: The operation couldn’t be completed. (HCPPluginError error -1.)

Issue Template
To format your messages, please, use a markdown. It's not critical, but since other people might have the same problem - this will help them as well.
Before creating a new issue - please, check that in issues section there is no similar thread. If so - please, post your message in there with some description.
Also, make sure that you did read the wiki and the error codes section.
Below are the sections, that you should try to include in your issue description. They are not mandatory, of course, but will make it easier to investigate and solve the problem.
Problem
Describe your problem. The more information you'll give - the better. Of course, abstract your server addresses.
Steps to reproduce
It is really hard to solve the issue if you can't reproduce it. So please, add a step-by-step guide on how to get the same error.

do this
do that

If you are using JS API - please, include that code as well in this section.
System info
Run cordova info (or ionic info) and paste it here, or give us information like:

Platform: iOS / Android
Platform version:
Cordova version:
Node version:

Also, if plugin works on a clean project, but not on your actual app - please, add the list of the plugins you are using:

plugin 1
plugin 2

You are supposed to fill in the issue template, not just leave it as is. You need to give more info, some code would be nice


Getting started with SmartDeviceLink-iOS?

Is there a sample project or a getting started doc somewhere?
In lieu of either of those, what is the basic starting point for making the connection with SDL?  I'm assuming that the entry point is instantiating an SDLProxy from the SDLProxyFactory?
I have SDL core running in a Parallels VM on the same Mac I'm doing iOS development on.  The network interface for the VM is set to bridge mode so both devices are sharing <IP_ADDRESS> but the following
_sdlProxy = [SDLProxyFactory buildSDLProxyWithListener:self<EMAIL_ADDRESS>tcpPort:@"8087"];

(I picked up the port from the smartDeviceLink.ini) results in a console log message:
2015-03-13 14:53:24.970 SDLPlay[90136:3453271] [TCP] Init
2015-03-13 14:53:24.979 SDLPlay[90136:3453271] [TCP] Server Not Ready, Connection Failed

Am I on the right track?  Any pointers appreciated!

Hey Tom, we're still working on getting documentation and sample projects etc. up and working. There is a pretty basic one on the develop branch at the moment. That code is obviously still in development, so be a bit wary there.
The log that you have there indicates that the device side is incapable of finding a server on the IP and port specified. The default port for SDL Core is 12345, so double check that, unless you changed the configuration. Also, I'm not sure how bridging the VM to the Mac you're doing (I'm assuming in simulator?) development on would affect things. I pretty much always do my work on device.

Thanks Joel.  I was able to get the sample project running.  Thanks for the tip on the default port.  I had no issues running the sample project in the simulator with my setup.


Desugar tuples inside of a variable declaration

The goal is to be able to desugar tuples as so:
let x = (1,2);
let (a,b) = x;
a

Repeated in issue #632


error messages and autocorrect?

regarding the changelog, there should be smarter error messages and an autocorrect function, but still when iam using more_magic=True I will get only the usage message returned and a meaningless message already reported in #5

@ezzra Better error messages are a great goal - the autocorrect felt sketchy to me but seemed useful, so I feature-gated it. I think #14 might help with inspectability / maintainability, the current parser is.... rough.

I just removed the more_magic feature in #51 so now this is a plain old dupe of #5 (but I agree the error message should be better)


ADS-B Exchange not detected as setup already.

Install.sh is not detecting that data sharing to ADS-B Exchange has been previously setup.

Fixed with commit 2942298e59e894765e9702ad9b81953de57d4353.


[WIP] Remove python version specific usage within extensions

Replace PYBIND usage with torch.ops.load_library in order to allow ao to build 1 wheel for multiple python versions.
This requires https://github.com/pytorch/pytorch/pull/138088
Why is this cool?
You no longer have to build an ao wheel for every python version, saving time, resources, and pypi package space (though this last one might not be a concern).
This proves that there is a way to use torch CPP extensions without dragging an unnecessary python dependency, which was not the case before.
One disclaimer:
This does mean that there will be no more torchao._C python module, which may be BC breaking. There are ways to not BC break (by creating a _C.py and re-exposing all the functions) so I'm not too concerned about that. Though some reviewer should let me know if this is crucial.
Test Plan
Yes, it looks like there is still much CI to fix for ao, but I wanted to be confident that the core change worked before sinking the time into this. How did I gain confidence in this change? Locally, I built ao for python 3.10 using
pip wheel -e .

This produced torchao-0.7.0+gitac340bb4-cp38-abi3-linux_x86_64.whl
Then, I installed this wheel within other conda environments (with fresh torch) for python 3.9 through python 3.12 using pip install torchao-0.7.0+gitac340bb4-cp38-abi3-linux_x86_64.whl To verify this wheel was good, I ran python test/test_ops.py to check that all the tests passed, which they do.
I also made sure that the python setup.py develop path was not broken. How? I ran pip install -e . on the code in this PR and ensured that python test/test_ops.py passed in both 3.9 and 3.10.
What do I want review on?
a. Is it okay that there is no longer a python module for torchao._C? A quick GH search shows 0 uses https://github.com/search?q=torchao._C&type=code in public code.
b. Are there other ways to install ao (other than pip install and pip wheel) that I need to test? Or other uses of the custom ops outside of test/test_ops.py that I need to verify?
c. Do we still want the old behavior to exist? Is there any reason we'd still want to build wheels per python?
d. I assumed py38 was the lowest version supported by ao, but I later learned that pytorch has moved to 3.9 so that should probably be 3.9 now. Does ao follow pytorch in terms of python support?
Based on the answers to the above qs, I will clean up this PR accordingly.

Mark has more experience here, We would also want to update the wheel build flow so that it produces py3 wheels not once that specify the version?
As well I think integration into the Nova workflows so that we are pushing the right artifacts is important

Alright thanks for your comments! Sounds like ao would like a single wheel more so I'll make the CI do that as my next step in the PR (amidst getting all the other tests to pass :p)
@msaroufim Just FYI I've done the sanity checks and verified that the custom ops worked + detailed it in the test plan above (that was honestly the most tedious part of this task lol).

Closing in favor of #1276 and #1277


Fix: Fixed issue with selecting multiple items in column layout

Resolved / Related Issues

[x] Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
Closes #12429...

Validation
How did you test these changes?

[x] Did you build the app and test your changes?
[ ] Did you check for accessibility? You can use Accessibility Insights for this.
[ ] Did you remove any strings from the en-us resource file?

[ ] Did you search the solution to see if the string is still being used?

[ ] Did you implement any design changes to an existing feature?

[ ] Was this change approved?

[x] Are there any other steps that were used to validate these changes?

Switch to column layout
Open a folder from the second column
Select al the items in the second column and verify that the third column is closed

Screenshots (optional)
Add screenshots here.

The column disappears when the second file is selected, which is an odd behavior.

Can you confirm if this is fixed now?

For some reason this isn't working if you select multiple items with the arrow key.

The column disappears when the second file is selected, which is an odd behavior.

Can you confirm if this is fixed now?

This causes crashes.

I can't reproduce this issue

I can't reproduce this issue but perhaps it can be fixed by moving the if statement earlier.

https://github.com/files-community/Files/assets/66369541/83303c09-0edb-4b1f-8c8a-b950b2d8ae21

It doesn't crash and it is better than before, but there are still some suspicious behaviors.

I noticed this as well, but I didn't find an easy fix. If you're okay with it, we should merge this PR and try to fix that separately.

It doesn't crash and it is better than before, but there are still some suspicious behaviors.

I noticed this as well, but I didn't find an easy fix. If you're okay with it, we should merge this PR and try to fix that separately.

Yes, I think that is fine too.


System cannot find raw file

Hello Michael,
I ran into a problem in that the raw file cannot be read. I am using Windows 10.
In CMD I have

cd into the sage folder
moved the followings into the sage folder: my.fasta, test.json, LQSRPAAPPAPGPGQLTLR.mzML

test.json:
{
"database": {
"bucket_size": 8192,
"fragment_min_mz": 135.0,
"fragment_max_mz": 1350.0,
"peptide_min_len": 6,
"peptide_max_len": 65,
"missed_cleavages": 2,
"static_mods": {
"C": 57.0215
},
"decoy_prefix": "rev_",
"fasta": "my.fasta"
},
"precursor_tol": {
"ppm": [-10,10]
},
"fragment_tol": {
"ppm": [-20.0, 20.0]
},
"isotope_errors": [-1, 3],
"deisotope": true,
"chimera": true,
"output_directory": "output",
"max_fragment_charge": 2,
"process_files_parallel": true,
"mzml_paths": ["LQSRPAAPPAPGPGQLTLR.mzML"]
}
I keep running into the following error
Finished release [optimized] target(s) in 0.12s
 Running `target\release\sage.exe test.json`
[2022-09-06T20:50:54Z INFO  sage] generated 96410556 fragments in 12554ms
[2022-09-06T20:50:54Z WARN  sage] linear model fitting failed, falling back to poisson-based FDR calculation
Encountered error while processing LQSRPAAPPAPGPGQLTLR.mzML: The system cannot find the path specified. (os error 3)

Where should I keep the .mzML? I have also tried to put the full path (["C:/Users/user/sage/LQSRPAAPPAPGPGQLTLR.mzML"] to the .json, but still getting the same error.
Thanks
HT

Hi  HT,
Thanks for trying out Sage - it's trying to write a file to output/LQSRPAAPPAPGPGQLTLR.sage.pin - and that folder likely doesn't exist... This is a particularly bad error message, thanks for making the issue!


Documentation links broken

Documentation links do not work
https://manual.threefold.io/#/3sdk_install

that's because we're now using the updated version. check the manual on how to get started now :)


Continuous queries not running

I mentioned this bug on the mailing list (https://groups.google.com/forum/#!topic/influxdb/7M3XtZB5CqU) and was told to open a bug report. I'll include the information from that post here.
I'm running InfluxDB 0.12.1 on a vagrant Ubuntu VM with a macbook as the host machine. I'm putting meteorological data in to the database and am having trouble getting any CQs to work even with what I see as the simplest case. I'm sending queries/writes to the database via curl and python via requests. I create the database with these queries:
CREATE DATABASE metobs
CREATE RETENTION POLICY one_hour ON {dbname} DURATION 3h REPLICATION 1 DEFAULT
CREATE RETENTION POLICY one_year ON {dbname} DURATION 365d REPLICATION 1
CREATE CONTINUOUS QUERY one_minute_cq ON {dbname} RESAMPLE EVERY 1s BEGIN SELECT mean(value) INTO pressure_1m FROM pressure GROUP BY time(1m) END

I then write some data by POSTing to /write that make the measurements look like this:
air_temp,inst=tower,site=aoss       value=<float>
pressure,inst=tower,site=aoss       value=<float>

If I'm writing a single line the POST looks like this via requests:
resp = requests.post(
        'http://{host}:{port:d}/write?db={dbname}'.format(host=host, port=port, dbname=dbname),
        data=line
)

Here's some examples of the lines being written:
air_temp,inst=tower,site=aoss value=4.0529<PHONE_NUMBER>000000000
dewpoint,inst=tower,site=aoss value=2.8613<PHONE_NUMBER>000000000
rh,inst=tower,site=aoss value=91.699<PHONE_NUMBER>000000000
air_temp_6_3m,inst=tower,site=aoss value=3.999<PHONE_NUMBER>000000000
air_temp_4,inst=tower,site=aoss value=5.6534<PHONE_NUMBER>000000000
air_temp_2,inst=tower,site=aoss value=4.8075<PHONE_NUMBER>000000000
precip,inst=tower,site=aoss value=0.0<PHONE_NUMBER>000000000
box_air_temp,inst=tower,site=aoss value=4.9099<PHONE_NUMBER>000000000
accum_precip,inst=tower,site=aoss value=0.0<PHONE_NUMBER>000000000
paro_air_temp_period,inst=tower,site=aoss value=5.8614<PHONE_NUMBER>000000000
box_pressure,inst=tower,site=aoss value=959.26<PHONE_NUMBER>000000000
pressure,inst=tower,site=aoss value=960.5<PHONE_NUMBER>000000000

So once I've written 435 points or so to each series I don't see the CQ's "pressure_1m" series in the "show series" output. I'm able to run the CQs select statement without the INTO clause after adding a "WHERE" time clause and get expected results. I can also run the select statement with the INTO clause and get expected results in the "pressure_1m" series.
Can anyone see something obvious that I'm doing wrong? If you need me to provide a copy of the database or output from some commands I can do that. Thanks.

Here is the output from the select statement. I'm not sure why it continues with the rest of the empty records (I'm guessing that's expected):

vagrant@precise64:~$ influx
Visit https://enterprise.influxdata.com to register for updates, InfluxDB server management, and monitoring.
Connected to http://localhost:8086 version 0.12.1
InfluxDB shell 0.12.1
select mean(value) from metobs.one_hour.pressure where time > '2016-04-01' group by time(1m)
name: pressure

time			mean
1459468800000000000<PHONE_NUMBER>09091
1459468860000000000<PHONE_NUMBER>333332
1459468920000000000<PHONE_NUMBER>666667
1459468980000000000	959.975
1459469040000000000<PHONE_NUMBER>666667
1459469100000000000	959.995
1459469160000000000<PHONE_NUMBER>333332
1459469220000000000	960.0225
1459469280000000000<PHONE_NUMBER>333331
1459469340000000000<PHONE_NUMBER>999999
1459469400000000000<PHONE_NUMBER>666666
1459469460000000000<PHONE_NUMBER>666666
1459469520000000000<PHONE_NUMBER>333333
1459469580000000000<PHONE_NUMBER>666666
1459469640000000000<PHONE_NUMBER>333333
1459469700000000000<PHONE_NUMBER>666667
1459469760000000000<PHONE_NUMBER>333333
1459469820000000000<PHONE_NUMBER>333332
1459469880000000000<PHONE_NUMBER>333333
1459469940000000000<PHONE_NUMBER>000001
1459470000000000000<PHONE_NUMBER>666664
1459470060000000000<PHONE_NUMBER>000001
1459470120000000000	960.105
1459470180000000000<PHONE_NUMBER>333336
1459470240000000000<PHONE_NUMBER>666665
1459470300000000000<PHONE_NUMBER>666666
1459470360000000000<PHONE_NUMBER>000002
1459470420000000000<PHONE_NUMBER>666667
1459470480000000000<PHONE_NUMBER>666668
1459470540000000000<PHONE_NUMBER>666666
1459470600000000000<PHONE_NUMBER>333334
1459470660000000000<PHONE_NUMBER>666665
1459470720000000000<PHONE_NUMBER>000002
1459470780000000000<PHONE_NUMBER>999998
1459470840000000000<PHONE_NUMBER>333332
1459470900000000000<PHONE_NUMBER>333334
1459470960000000000<PHONE_NUMBER>333334
1459471020000000000
1459471080000000000
1459471140000000000
1459471200000000000
1459471260000000000
1459471320000000000
1459471380000000000
...

Ok last piece of information that I could think of, I ran tail -fon the log and I can see that the CQ is running, it's just not creating anything.
[continuous_querier] 2016/04/15 20:38:00 executing continuous query one_minute_cq (2016-04-15 20:37:00 +0000 UTC to 2016-04-15 20:38:00 +0000 UTC)
[query] 2016/04/15 20:38:00 SELECT mean(value) INTO metobs.one_hour.pressure_1m FROM metobs.one_hour.pressure WHERE time >= '2016-04-15T20:37:00Z' AND time < '2016-04-15T20:38:00Z' GROUP BY time(1m)

Last message for the day. I was able to get the CQ to work when adding new data. I removed the RPs just to be sure they weren't affecting anything. So I recreated the database, added the CQ, inserted data for 15 days ago. The CQ never picked up on this data. After reading the documentation I thought CQs were supposed to analyze newly inserted data, but not look at data inserted before they were created. Right?
After I noticed that the CQ didn't catch this data I reinserted the data but with no timestamp with a 1 second delay in between each insert. The CQ picked up on this since it is continuously running. Is there a reason the CQ runs even when there is no data being inserted in to the database?

I believe I've encountered a similar issue and separately filed a bug: https://github.com/influxdata/influxdb/issues/6401
In my case the CQ is running (shows up in log) but the time range spans a single grouping, so it never has a second point to generate a delta, and since there's no value generated it writes nothing to the backing store.

This may not be a bug and may just be a confusion with the documentation. It is clear from the documentation that CQs do not operate on data inserted before they existed, but do they also not operate on data timestamped before they were created (even if these data were inserted after the CQ was created)?
Does this also mean that if you insert data out of order and earlier than the CQs sampling that it will never affect the CQ (no recalculation)?

@davidh-ssec yes, that's correct. CQs will only run against the latest time period. We don't currently have a way to know if a CQ needs to rerun against an old shard when a write is performed against that shard. That's part of the reason why the resample options exist so that you can customize when they get run for what your system expects.
A caveat is there's no way to tell CQs to perform a backfill, but it is possible to just run the backfill yourself. You can also just manually use a SELECT ... INTO ... to do that. The only thing different between a new backfill command and what is currently done is we would just grab the command ourselves so you didn't have to copy and paste.

@jsternberg Ok I think that makes sense it just wasn't obvious from the documentation that I was reading.


include: uart: Another pass on improving docstrings

Avoid outdated references to registers of a particular hardware
in the generic API.

Propagate specifications/clarifications of ISR behavior to
docstrings of more functions which guaranteed to work only in ISR.

This continues work previously done in:
38f78e80cf650133827b80cad1c6abbba13d56b5
0fdc9b5b125c60d80a368360851a50f1f03710aa
etc.
Signed-off-by: Paul Sokolovsky<EMAIL_ADDRESS>

Codecov Report

Merging #10761 into master will increase coverage by 0.13%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #10761      +/-   ##
==========================================
+ Coverage   55.06%    55.2%   +0.13%
==========================================
  Files         206      206
  Lines       24880    24880
  Branches     5494     5494
==========================================
+ Hits        13700    13734      +34
+ Misses       8876     8836      -40
- Partials     2304     2310       +6

Impacted Files
Coverage Δ

lib/posix/pthread_sched.c
41.66% <0%> (-20.84%)
:arrow_down:

subsys/logging/log_core.c
76.05% <0%> (-2.35%)
:arrow_down:

subsys/logging/log_output.c
82.14% <0%> (-1.2%)
:arrow_down:

lib/posix/pthread_mutex.c
77.77% <0%> (+1.38%)
:arrow_up:

lib/posix/pthread.c
80.36% <0%> (+12.32%)
:arrow_up:

lib/posix/pthread_cond.c
83.33% <0%> (+20.83%)
:arrow_up:

include/posix/posix_sched.h
100% <0%> (+100%)
:arrow_up:

lib/posix/pthread_barrier.c
100% <0%> (+100%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb6f37d...36c9935. Read the comment docs.

@gon1332: FYI, feel free to have a look/review.

Fixed, thanks.

This came as a side effect of reviewing UART driver in https://github.com/zephyrproject-rtos/zephyr/pull/9042, and seeing that the bunch of docstrings don't mention constraints specified in other docstrings. And going over this for Nth, with everything else happening inbetween (like, people spawning more drivers with raw ISRs for UART access, weird bugreports), following thoughts are dawning:

The UART driver API is too low-level, and despite all attempts to specify constraints, following which it's intended to be possible to write "cross-platform ISRs", there's always chance of some corner case not covered.
Even more surprising was that bunch of IRQ-related functionality of UART API was made userspace syscalls. @andrewboie, how did we get to that? Even with reading the docstring, it's pretty clear that uart_irq_tx_enable() is IRQ related. What's the point of exporting it userspace, like, user calls uart_irq_tx_enable(), what happens next? It's not possible to define ISR callback from userspace anyway. And most of the UART API is strictly related to interrupt-driven mode. Only uart_poll_in()/uart_poll_out() could be exposed to userspace (and perhaps err_check()). They're also not too useful, but why not?  IMHO, we should fix that ASAP.

Ping.


Missing spans

Reproduction: https://github.com/mattfysh/worker_do_otel
Looking into an issue with spans not appearing in honeycomb
The first is 100% reproducible, where if you make any number of followup request from Worker A to Worker B, only the spans from the initial call to Worker B appear. In this instance, honeycomb does not display the "Missing spans" warning.

The second is intermittent but highly-reproducible, where some spans from Worker B may appear as missing. In this instance, honeycomb displays the "Missing spans" warning.
You should be able to reproduce by deploying the linked repo, but let me know if you run into any issues or are unable to see the issue. I've also listed some smaller tangential issues in the repo readme.

Hey @mattfysh, I think that should be fixed now with 1.0.0-rc.13, but haven't had a chance to run it through your reproduction repos.. will see if I have some time to do that later tonight.

It's looking much better, thanks! The service bindings are auto-instrumented now which is great, however there is still the issue where subsequent calls to the same DO in a single request are not appearing:

I've updated my repro repo here: https://github.com/mattfysh/worker_do_otel/commit/5e76ffbddafa73ac8d82037955f3943d4680656b

Oh crap.. I think I may have found the issue with that.. That is a great catch. It is probably an issue in the BatchTraceSpanProcessor.. going to have a think on how to solve that :)

If it helps, adding a 1000ms delay between requests gets the subsequent calls to worker-b and DO to be instrumented (image below).
Using a 500ms delay and only the 1st and 3rd requests were fully instrumented

Yeah, that makes sense given the thing I am looking at. If you start a span in the DO, that is not a child of the first span that was created by it, before that sub tree is done exporting, you run into this problem.

I am always a bit skeptical when a change to the core logic of something so critical like the SpanProcessor works in one go, but look at this beauty!

Thanks Erwin! I've never been more happy to see a fully populated trace 💯
I'm now repurposing the repro to implement an upstash-based drop in replacement for durable objects, because DOs are very slow in Australia.
If you need to continue using the repo for any reason, you can switch off this flag:
https://github.com/mattfysh/worker_do_otel/blob/cd1d85680f2a80ba2d799fc6e04d957ab430be6b/worker-b/index.ts#L9


[FLINK-28720][hive][connectors] Add Hive partition when flink has no data to write

What is the purpose of the change
When inserting a hive static partition, if no data is generated, we also need to add the hive partition
Brief change log

Modify the PartitionLoader and FileSystemCommitter to add hive partition when use static partition

Verifying this change
add ITCase in HiveDialectITCase
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not documented)

LGTM.

@wuchong Could you please help review & merge?


Travis CI - end of a era

This project currently uses Travis CI - however the "free plans" on Travis are being phased out.
Lots of other open source projects are migrating to Github Actions. If I submitted a PR for switching to Github Actions would it be something that would of interest?

@richardbarran of course! We don't have a ton of experience with CI setup on our own so any help is welcome

We've moved CI to Github Actions so I'm closing this ticket


[PE-D][Tester D] Sample add command does not work

When I copy and paste the sample command they gave when trying out the add command I get a invalid command format.

Labels: type.FunctionalityBug severity.High
original: tjch-o/ped#2

This has been addressed.


[dart2wasm] co19/LanguageFeatures/Extension-types/superinterfaces_of_extension_type_A08_t02 crashes compiler

The following test crashes dart2wasm compiler
/==========================================================================================================================\
| co19/LanguageFeatures/Extension-types/superinterfaces_of_extension_type_A08_t02 is new and failed (Crash, expected Pass) |
\==========================================================================================================================/

--- Command "dart2wasm" (took 01.000431s):
DART_CONFIGURATION=ReleaseX64 CHROME_PATH=/b/s/w/ir/cache/builder/sdk/third_party/browsers/chrome/chrome/google-chrome sdk/bin/dart2wasm_developer -Dtest_runner.configuration=dart2wasm-linux-chrome --enable-experiment=inline-class /b/s/w/ir/cache/builder/sdk/tests/co19/src/LanguageFeatures/Extension-types/superinterfaces_of_extension_type_A08_t02.dart /b/s/w/ir/cache/builder/sdk/out/ReleaseX64/generated_tests/dart2wasm-linux-chrome/tests_co19_src_LanguageFeatures_Extension-types_superinterfaces_of_extension_type_A08_t02/superinterfaces_of_extension_type_A08_t02.wasm

exit code:
255

stdout:
Exception in ConstantExpression at file:///b/s/w/ir/cache/builder/sdk/tests/co19/src/LanguageFeatures/Extension-types/superinterfaces_of_extension_type_A08_t02.dart:38:9

stderr:
Unhandled exception:
Null check operator used on a null value
#0      ConstantCreator._makeInterfaceType.<anonymous closure> (package:dart2wasm/constants.dart:731)
#1      ConstantCreator.createConstant (package:dart2wasm/constants.dart:282)
#2      ConstantCreator._makeInterfaceType (package:dart2wasm/constants.dart:730)
#3      ConstantCreator.visitTypeLiteralConstant (package:dart2wasm/constants.dart:807)
#4      TypeLiteralConstant.accept (package:kernel/ast.dart:14286)
#5      ConstantCreator.ensureConstant (package:dart2wasm/constants.dart:249)
#6      ConstantCreator.visitTypeLiteralConstant (package:dart2wasm/constants.dart:813)
#7      TypeLiteralConstant.accept (package:kernel/ast.dart:14286)
#8      ConstantCreator.ensureConstant (package:dart2wasm/constants.dart:249)
#9      ConstantInstantiator.defaultConstant (package:dart2wasm/constants.dart:142)
#10     ConstantVisitorDefaultMixin.visitTypeLiteralConstant (package:kernel/visitor.dart:953)
#11     TypeLiteralConstant.accept (package:kernel/ast.dart:14286)
#12     ConstantInstantiator.instantiate (package:dart2wasm/constants.dart:126)
#13     Constants.instantiateConstant (package:dart2wasm/constants.dart:108)
#14     CodeGenerator.visitConstantExpression (package:dart2wasm/code_generator.dart:2866)
#15     ConstantExpression.accept1 (package:kernel/ast.dart:8621)
#16     CodeGenerator.wrap (package:dart2wasm/code_generator.dart:882)
#17     CodeGenerator.visitArgumentsLists (package:dart2wasm/code_generator.dart:2774)
#18     CodeGenerator._visitArguments (package:dart2wasm/code_generator.dart:2808)
#19     CodeGenerator.visitStaticInvocation (package:dart2wasm/code_generator.dart:1759)
#20     StaticInvocation.accept1 (package:kernel/ast.dart:6543)
#21     CodeGenerator.wrap (package:dart2wasm/code_generator.dart:882)
#22     CodeGenerator.visitExpressionStatement (package:dart2wasm/code_generator.dart:1358)
#23     ExpressionStatement.accept (package:kernel/ast.dart:9105)
#24     CodeGenerator.visitStatement (package:dart2wasm/code_generator.dart:893)
#25     CodeGenerator.visitBlock (package:dart2wasm/code_generator.dart:1015)
#26     Block.accept (package:kernel/ast.dart:9155)
#27     CodeGenerator.visitStatement (package:dart2wasm/code_generator.dart:893)
#28     CodeGenerator.generateBody (package:dart2wasm/code_generator.dart:578)
#29     CodeGenerator.generate (package:dart2wasm/code_generator.dart:234)
#30     Translator.translate (package:dart2wasm/translator.dart:344)
#31     compileToModule (package:dart2wasm/compile.dart:153)
<asynchronous suspension>
#32     main (package:dart2wasm/dart2wasm.dart:143)
<asynchronous suspension>
#33     main (file:///b/s/w/ir/cache/builder/sdk/pkg/dart2wasm/bin/dart2wasm.dart:7)
<asynchronous suspension>

--- Re-run this test:
python3 tools/test.py -n dart2wasm-linux-chrome co19/LanguageFeatures/Extension-types/superinterfaces_of_extension_type_A08_t02

The program contains an ExtensionType (ET4 in this case) whose extensionTypeErasure points to an InterfaceType (for the class A in this case) that is not listed in the component. @johnniwinther @alexmarkov CFE or TFA bug?


Fix 2 fakeintakes creation when not using load balancers

What does this PR do?
We had an issue where two fakeintake service where created when we want to create a fakeintake withtout load balancer. This PR solves this issue as well a refactoring a little bit the fakeintake service creation
Which scenarios this will impact?
Motivation
Additional Notes

/merge


Serialize a Vec<Enum> as a map

Serialize a Vec of externally tagged enums to a map with the map key being the external tag.
vec![
    EnumValue::Int(123),
    EnumValue::String("FooBar".to_string()),
    EnumValue::Int(456),
    EnumValue::String("XXX".to_string()),
    EnumValue::Unit,
    EnumValue::Tuple(1, "Middle".to_string(), false),
    EnumValue::Struct {
        a: 666,
        b: "BBB".to_string(),
        c: true,
    },
],

gets converted into this JSON
{
  "Int": 123,
  "String": "FooBar",
  "Int": 456,
  "String": "XXX",
  "Unit": null,
  "Tuple": [
    1,
    "Middle",
    false
  ],
  "Struct": {
    "a": 666,
    "b": "BBB",
    "c": true
  }
}

This got requested here: https://github.com/serde-rs/json/issues/743
Todo:

[x] Update documentation

This works for me (in at least one case); I still have another that is not covered here that seems to have some more intricate things. I'm not sure how best to approach this though. If this is a separate request, I'll fine a new issue, but it may be of interest here.
In this code, the src/data/data.rs EntityRef is used as an enum variant and a Vec<EntityRef<T>> struct field. When used as a struct field, this line ends up getting called. I can see in the callstack that it goes through EnumMap::visit_map and eventually falls onto an EnumMap::visit_enum which calls that todo!(). Should there be an option to EnumMap to pass the key down too (basically just forwarding visit_map to the inner visitor)?

Hi, thanks for taking a look. I think supporting map-like things by handling deserialize_map separately and forwarding to the existing MapAccess (https://github.com/jonasbb/serde_with/pull/375/commits/19e437befb90bfc00e2bd9bde9fca4eee99dc76e). It does no longer call the todo! in your code snippet.
I couldn't test much more, since I don't quite understand how the implementation is supposed to work, especially this part
https://github.com/mathstuf/rust-bulletml/blob/31221b9e15533960e61420071ce010d63f411de0/src/data/data.rs#L375-L381
It deserializes a second key, which must be a String, but this deserialization must fail.

Hrm. That seems to confuse enum types then :/ . I think I'll have to keep peeling back to do custom Deserialize impls then see what can be factored out that way.

@mathstuf Do you have a small-ish example of what you want to deserialize and how the Rust instances should look like?

That branch now contains code that works with a test suite (the data is in a submodule).

@mathstuf With a small change, all of your tests pass for me. If you implement visit_enum you also need to call deserialize_enum. Probably just a leftover from your previous version.

Patch
diff --git a/src/data/data.rs b/src/data/data.rs
index 90e4bb3..e989c7e 100644
--- a/src/data/data.rs
+++ b/src/data/data.rs
@@ -143,7 +143,7 @@ impl<'de> Deserialize<'de> for Step {
     where
         D: Deserializer<'de>,
     {
-        deserializer.deserialize_map(StepVisitor)
+        deserializer.deserialize_enum("Step", StepVisitor::FIELDS, StepVisitor)
     }
 }

@@ -507,7 +507,7 @@ where
     where
         D: Deserializer<'de>,
     {
-        deserializer.deserialize_map(EntityRefVisitor::new())
+        deserializer.deserialize_enum("EntityRef", EntityRefVisitor::<T>::FIELDS, EntityRefVisitor::new())
     }
 }

Indeed, thanks. I'll keep poking at it down that it works to see if I can remove my custom impl Deserialize bits. It might just be too wonky for codegen though.

bors r+


Failed to check if grpc server is working: rpc error: code = Unavailable desc = transport is closing: unknown

Get your issue reviewed faster
The information provided will help us to understand the problem more quickly
so saves time for both of us! :smile:
Description of problem
Error when creating kata container
Expected result
The kata container was created successfully
Actual result
Nov 04 21:44:58 myhost containerd[200081]: time="2020-11-04T21:44:58.637898529+08:00" level=warning msg="sandox cgroups path is empty" ID=5d9f54d34584b5d2cd439e4bd481615796d4baae5172947e5400e2c8bf881386 sandbox=5d9f54d34584b5d2cd439e4bd481615796d4baae5172947e5400e2c8bf881386 source=virtcontainers subsystem=sandbox
Nov 04 21:44:58 myhost containerd[200081]: time="2020-11-04T21:44:58.640798015+08:00" level=info msg="shim disconnected" id=5d9f54d34584b5d2cd439e4bd481615796d4baae5172947e5400e2c8bf881386
Nov 04 21:44:59 myhost containerd[200081]: time="2020-11-04T21:44:59.250108344+08:00" level=error msg="RunPodSandbox for &PodSandboxMetadata{Name:trade-emergency-test-920d80a34205d924fb8deb35208aea78-y7g7b,Uid:c91278c4-1ea3-11eb-bd94-0a580a308f97,Namespace:test,Attempt:0,} failed, error" error="failed to create containerd task: Failed to check if grpc server is working: rpc error: code = Unavailable desc = transport is closing: unknown"
Nov 04 21:45:12 myhost containerd[200081]: time="2020-11-04T21:45:12.508998670+08:00" level=info msg="RunPodsandbox for &PodSandboxMetadata{Name:trade-emergency-test-920d80a34205d924fb8deb35208aea78-y7g7b,Uid:c91278c4-1ea3-11eb-bd94-0a580a308f97,Namespace:test,Attempt:0,}"

Further information
Version used
kata-runtime-1.10.1
kata-proxy-1.10.1

It should be that the kata-agent failed to start, the key problem occasionally appeared, and it cannot be reproduced now

Thanks for raising @free2k, but you haven't provided the information requested in the template which we really need to see :smile:
Also, can you try to recreate using 1.10.8 with full debug enabled? (or indeed with 1.11.5, 1.12.0-rc0 or 2.0.0).

Thanks for raising @free2k, but you haven't provided the information requested in the template which we really need to see 😄
Also, can you try to recreate using 1.10.8 with full debug enabled? (or indeed with 1.11.5, 1.12.0-rc0 or 2.0.0).

I have opened debug now, but it cannot be reproduced now. There is only a very small chance

@free2k - I suggest you update the version of Kata you are using to one of those I mentioned above. If you can recreate the problem then, please provide further details. Otherwise, there isn't much we can do I'm afraid.

This issue is being automatically closed as Kata Containers 1.x has now reached EOL (End of Life). This means it is no longer being maintained.

Important:
All users should switch to the latest Kata Containers 2.x release to ensure they are using a maintained release that contains the latest security fixes, performance improvements and new features.

This decision was discussed by the @kata-containers/architecture-committee and has been announced via the Kata Containers mailing list:

http://lists.katacontainers.io/pipermail/kata-dev/2020-November/001601.html
http://lists.katacontainers.io/pipermail/kata-dev/2021-April/001843.html
http://lists.katacontainers.io/pipermail/kata-dev/2021-May/001896.html

If you believe this issue still applies to Kata Containers 2.x, please open an issue against the Kata Containers 2.x repository, pointing to this one, providing details to allow us to migrate it.


Metas to go before title

Operation System:
Beaker version: master
According to https://stackoverflow.com/a/30682871/271577 , the following files , <meta charset="UTF-8"> should precede the <title> per HTML:

beaker/app/assets/templates/assets/index.html
beaker/app/assets/templates/website/index.html

(I don't see anything about this in the spec, but it would seem to make sense to me if the title were in a different character set, that the parser should be informed before interpreting the title.)

Okay good catch. I'll update it.


Need help with installation of prerequisites

Description
Note: Please excuse me for categorizing it as a bug, although it is not. There is no other category where I could clarify these and the documentation is also missing many things.
I am trying to build a self hosted Ubuntu runner with all the pre-reqs provided in this repository. I am not sure why there is no documentation around how to build this. It would have been really great if there was a step by step documentation on how to build an image targeting VMWare or Docker or AWS or install pre-reqs.
However, after a lot of research, I found that the ubuntu2004.json is the file to refer to. I am refering this file and trying to build a shell script which will create imagegeneration directory, clone the repository and then run the scripts one by one in the order specified in that json file. However, I am still strugging to get this going and I have some questions. It will be great if someone can please help me.

In ubuntu2004.json, there is a template_dir. Not sure what value gets assigned to this?
Are the scripts mentioned in ubuntu2004.json executed in a loop by an external utility like packer? I am raising this question because I am curious how every subsequent script gets access to the PATH or any other environment variable added by the previous script. When I execute all the scripts in order from a single shell script, I run into issues where some of the scripts after execution display a message saying I need to relogin to the terminal or open a new terminal for the environment variable changes to take effect.
Many of my tests are failing, although the packages seem to be getting installed properly.
In install.sh and Tests.Helpers.psm1 files, there is a path "/imagegeneration". I am curious how this works. In Linux, do they create any new mounts, since  /imagegeneration looks similar to /etc, /usr, /tmp etc.
In some scripts, although there is -y flag for some commands like apt update, I see prompts. I am not sure how to pass DEBIAN_FRONTEND=noninteractive to suppress these prompts.
In some scripts like git.sh, haskell.sh and surprisingly during testing of PHPUnit, I get prompts. I have no idea why. There are -y flags. But still the scripts pause and prompts.
While installing PIP, I get warning that installing using PIP can create issues. I am surprised to see this, because I use a non root user with sudo privileges, which is what the ubuntu2004.json also shows.
I have not been able to install brew using homebrew.sh, even when I run it using non root user. No idea what should I do to install it correctly.
There is a reboot.sh which does the reboot. How does the subsequent script resumes after reboot?
How are the various environment variables like IMAGE_FOLDER, IMAGEDATA_FILE, INSTALLER_SCRIPT_FOLDER, HELPER_SCRIPTS etc persisted without adding to /etc/environment?
What values get assigned to {{ .Vars }} and {{ .Path }} variables in ubuntu2004.json?
Most of the scripts seem to be executed from {{template_dir}} whereas some of them are getting executed from {{image_folder}}. Why is this?
Brew is installed using /bin/sh. Please explain the reason for this?
Why are some scripts written in PowerShell?

Virtual environments affected

[ ] Ubuntu 16.04
[ ] Ubuntu 18.04
[X] Ubuntu 20.04
[ ] macOS 10.15
[ ] macOS 11
[ ] Windows Server 2016
[ ] Windows Server 2019
[ ] Windows Server 2022

Image version and build link
Ubuntu 20.04
Is it regression?
No response
Expected behavior
No response
Actual behavior
No response
Repro steps
No steps.

2 more queries.
11.  What values get assigned to {{ .Vars }} and {{ .Path }} variables in ubuntu2004.json?
12.  Most of the scripts seem to be executed from {{template_dir}} whereas some of them are getting executed from {{image_folder}}. Why is this?
13.  Brew is installed using /bin/sh. Please explain the reason for this?
14.  Why are some scripts written in PowerShell?

I'm not part of actions team but I've spent quite a lot of time with the templates in this repo as well with Packer and I've maintained before a Docker image based on this repository but without using Packer.

I am trying to build a self hosted Ubuntu runner with all the pre-reqs provided in this repository. I am not sure why there is no documentation around how to build this. It would have been really great if there was a step by step documentation on how to build an image targeting VMWare or Docker or AWS or install pre-reqs.

There is documentation here: https://github.com/actions/virtual-environments/blob/main/docs/create-image-and-azure-resources.md

However, after a lot of research, I found that the ubuntu2004.json is the file to refer to. I am refering this file and trying to build a shell script which will create imagegeneration directory, clone the repository and then run the scripts one by one in the order specified in that json file. However, I am still strugging to get this going and I have some questions. It will be great if someone can please help me.

Don't do that, it's not worth it. Maintenance cost is just too much and it will break whenever something is changed in original template, just use Packer it's much easier (although I'm not going to say that Packer works great always, especially the Docker plugin).

In ubuntu2004.json, there is a template_dir. Not sure what value gets assigned to this?

It's a directory where template (ubuntu2004.json) is stored, so it will be https://github.com/actions/virtual-environments/tree/main/images/linux.

Are the scripts mentioned in ubuntu2004.json executed in a loop by an external utility like packer? I am raising this question because I am curious how every subsequent script gets access to the PATH or any other environment variable added by the previous script. When I execute all the scripts in order from a single shell script, I run into issues where some of the scripts after execution display a message saying I need to relogin to the terminal or open a new terminal for the environment variable changes to take effect.

Yes, Packer is used. Scripts are not accustomed to work without Packer and break quite often in many places.

In install.sh and Tests.Helpers.psm1 files, there is a path "/imagegeneration". I am curious how this works. In Linux, do they create any new mounts, since  /imagegeneration looks similar to /etc, /usr, /tmp etc.

It's just a standard directory.
https://github.com/actions/virtual-environments/blob/6968a424be7df5d6ca1d9065438b05395e2e0b25/images/linux/ubuntu2004.json#L17
https://github.com/actions/virtual-environments/blob/6968a424be7df5d6ca1d9065438b05395e2e0b25/images/linux/ubuntu2004.json#L60-L67

In some scripts, although there is -y flag for some commands like apt update, I see prompts. I am not sure how to pass DEBIAN_FRONTEND=noninteractive to suppress these prompts.

bash example
# single command
DEBIAN_FRONTEND=noninteractive ./path/to/script.sh

# multiple commands
export DEBIAN_FRONTEND=noninteractive
some_command
./path/to/script.sh

packer example
https://github.com/actions/virtual-environments/blob/6968a424be7df5d6ca1d9065438b05395e2e0b25/images/linux/ubuntu2004.json#L73-L82

Many of my tests are failing, although the packages seem to be getting installed properly.
In some scripts like git.sh, haskell.sh and surprisingly during testing of PHPUnit, I get prompts. I have no idea why. There are -y flags. But still the scripts pause and prompts.
I have not been able to install brew using homebrew.sh, even when I run it using non root user. No idea what should I do to install it correctly.

Most likely because the environment is not carried over to next process. Hard to tell since all scripts are meant to work together with Packer.

There is a reboot.sh which does the reboot. How does the subsequent script resumes after reboot?
How are the various environment variables like IMAGE_FOLDER, IMAGEDATA_FILE, INSTALLER_SCRIPT_FOLDER, HELPER_SCRIPTS etc persisted without adding to /etc/environment?

Packer handles that.
https://github.com/actions/virtual-environments/blob/6968a424be7df5d6ca1d9065438b05395e2e0b25/images/linux/ubuntu2004.json#L301
https://www.packer.io/docs/provisioners/shell#expect_disconnect

What values get assigned to {{ .Vars }} and {{ .Path }} variables in ubuntu2004.json?

Path is the path to the script to run
Vars is the list of environment_vars, if configured.
EnvVarFile is the path to the file containing env vars, if use_env_var_file is true.

https://www.packer.io/docs/provisioners/shell#execute_command

Brew is installed using /bin/sh. Please explain the reason for this?

sudo is not used since homebrew doesn't support root installation.
As for /bin/sh rather than sh, there seems to be no reason for that, just author preference. (https://github.com/actions/virtual-environments/pull/589)

Why are some scripts written in PowerShell?

Can't speak for the maintainers but it's much easier and clear to write/maintain PowerShell scripts in comparison to bash with jq.

Hi Ryan,
First of all, a big thank you for taking the time out and patiently answering my queries. But I am still curious about a few things.

Why GitHub is not open sourcing the packer build script?
Why are they targeting only Azure (is it just because GitHub is acquired by MS)?
If you have packer script / docker image, can you please share it or open source it? I am sure there are lots of people who have a similar requirement as me.
I had already gone through the first [link] (https://github.com/actions/virtual-environments/blob/main/docs/create-image-and-azure-resources.md) you provided. However it seems to be targeted to Azure. In my case, I just want it as a normal image (say. VMWare or HyperV or Docker).
Even if I learn packer now, it will take sometime. Hence I am requesting.

Why GitHub is not open sourcing the packer build script?

It is open source. It's in this repository, Packer template is here: https://github.com/actions/virtual-environments/blob/main/images/linux/ubuntu2004.json and helper scripts are here: https://github.com/actions/virtual-environments/tree/main/helpers but helper scripts are not required for building the image.
The only thing you need is Packer and that is open source too

Why are they targeting only Azure (is it just because GitHub is acquired by MS)?

Because GH Actions runners are hosted on Azure infrastructure.

If you have packer script / docker image, can you please share it or open source it? I am sure there are lots of people who have a similar requirement as me.

As mentioned in 1. all pre-requisites for building VM is in this repository, if you want to build Docker image you can check out my fork but Packer is still required and unfortunately the built image is not perfect due to how current Packer Docker plugin works but I'm working on fixing that. Other builders might also work but you need to adjust templates yourself.

I had already gone through the first [link] (https://github.com/actions/virtual-environments/blob/main/docs/create-image-and-azure-resources.md) you provided. However it seems to be targeted to Azure. In my case, I just want it as a normal image (say. VMWare or HyperV or Docker).

You need to adapt Packer template yourself to target whichever builder you want. It's not possible for Actions team to support Packer builders they don't use.
In case of VMware/Hyper-V it's very simple, you only need to have a clean Ubuntu VM.

Thanks a lot once again. If I want to just execute Packer build (by following the steps without Azure part), should I run it on the same Ubuntu server on which I am installing prereqs or from another server? Sorry for being naive, but I am very new to all these. The GenerateResourcesAndImage.ps1 calls packer build with lots of Azure related arguments, not sure how to skip them or what will be the consequences? Once I run the packer build script, what sort of Image should I expect? Please explain. Thanks a lot once again.

If I want to just execute Packer build (by following the steps without Azure part), should I run it on the same Ubuntu server on which I am installing prereqs or from another server?

Not sure what you mean by that, you should run Packer on machine that has management tools/can connect to Hyper-V/VMware.

The GenerateResourcesAndImage.ps1 calls packer build with lots of Azure related arguments, not sure how to skip them or what will be the consequences?

It's better to not use it if you are not building VM in Azure. Just replace builder in the template and run Packer pointing to template. Don't forget to set environment variables for Dockerhub credentials.

Once I run the packer build script, what sort of Image should I expect?

For Hyper-V/VMware builders it will leave a VM intact, you can then copy/move/delete it as you wish

If I want to just execute Packer build (by following the steps without Azure part), should I run it on the same Ubuntu server on which I am installing prereqs or from another server?

Not sure what you mean by that, you should run Packer on machine that has management tools/can connect to Hyper-V/VMware.
What I want is to just install all the prerequisites on an Ubuntu server and take a snapshot of it in VMWare. This can act as a template in my case. In such a simple scenario, all I need to do it just install packer (and follow the steps in the documentation in my Ubuntu server (where I want to install the prerequisites) and run the packer build after removing the builder section, right?

The GenerateResourcesAndImage.ps1 calls packer build with lots of Azure related arguments, not sure how to skip them or what will be the consequences?

It's better to not use it if you are not building VM in Azure. Just replace builder in the template and run Packer pointing to template. Don't forget to set environment variables for Dockerhub credentials.
I can completely remove the build section from the json, you mean? Also, the images pulled are all public images, I think I could pull them even without credentials. Not sure why they are expecting Dockerhub credentials.

Once I run the packer build script, what sort of Image should I expect?

For Hyper-V/VMware builders it will leave a VM intact, you can then copy/move/delete it as you wish

Thanks a lot once again for your prompt response.
I can completely remove the build section from the json, you mean? Also, the images pulled are all public images, I think I could pull them even without credentials. Not sure why they are expecting Dockerhub credentials. Anyways, I will try to create a test login and provide that.
What I want is to just install all the prerequisites on an Ubuntu server and take a snapshot of it in VMWare. This can act as a template in my case. In such a simple scenario, all I need to do it just install packer (and follow the steps in the documentation in my Ubuntu server (where I want to install the prerequisites) and run the packer build after removing the builder section, right?

I was wondering how you generated Docker image using packer, since some scripts have systemctl commands which is not supported on Docker.
Also, since their base script (GenerateImageAndResources.ps1) is a PowerShell, I was wondering, if they execute packer build from a Windows machine even for building Ubuntu image.
It will be great, if you could please clarify these.

Also, since their base script (GenerateImageAndResources.ps1) is a PowerShell, I was wondering, if they execute packer build from a Windows machine even for building Ubuntu image.

PowerShell is available for Linux.

I was wondering how you generated Docker image using packer, since some scripts have systemctl commands which is not supported on Docker.

I modified the scripts.

I can completely remove the builder section from the json, you mean?

Replace it with the builder of your choice: https://www.packer.io/docs/builders

Also, the Docker images pulled are all public images, I think I can pull them even without credentials. Not sure why they are expecting Dockerhub credentials.

Credentials are provided to prevent rate limit when pulling images.

What I want is to just install all the prerequisites on an Ubuntu server and take a snapshot of it in VMWare. This can act as a template in my case. In such a simple scenario, all I need to do is to just install packer (and follow the steps in the documentation in my Ubuntu server (where I want to install the prerequisites) and run the packer build after removing the builder section, right?

Packer needs to be installed and run on the machine that has access to VMware/Hyper-V, not in a VM which is going to be built.

Thanks, @catthehacker for all the provided instructions.
@vesubramanian we have the discussions section available here https://github.com/actions/virtual-environments/discussions It's better to ask such kind of configuration questions there.
I'm going to close this issue.


Docs - Minor Note to assist future readers

Problem Statement
Minor updates to templating docs to assist future readers, caught me out today.
Related Issue
None
Proposed Changes
Minor documentation update
Checklist

[x] I have read the contribution guidelines
[x] All commits are signed with git commit --signoff
[ ] My changes have reasonable test coverage
[ ] All tests pass with make test
[ ] I ensured my PR is ready for review with make reviewable

Some minor tweaks following the your notes 😄


Add scopes information to README file

Description
I've added an example to the README for defining scopes because it doesn't seem to be explained anywhere else.

Coverage remained the same at 70.69% when pulling 3a892c4a9c22d50f99369373a8cfa086ed026529 on mikelovely:add-scopes-information into 961825b563ea01b7bc6ef5feacae9d155ff9d5db on thephpleague:master.


Make some txpool logs a bit more compact

Use HexDisplay for OpaqueExtrinsics and TransactionTags.

Please merge master.

Version bump not required, since it's only changing Debug implementation in std environment.

(it's generally easier to bump impl_version than fight with the CI :) )


Update screenshots

The current 3 screenshots are on an old version of unc0ver. These should be updated to screenshots on v1.1.1 with an iPhone X to showcase recently added features and support for the bigger screen.

I'll do this shortly.

Don't close an issue when you're going to do it, close it when you do in fact do it.

fake news!


Model association isLoaded is true at the same time as isPending.

I'll try to see if I can find a way to reproduce this, but I wanted to ensure that this is actually an issue first. In general, on my models, I'd expect isLoading to be false if isPending is also false. However, I've run into a case with Mirage where isLoading is true, but there is no data and isPending is still false. It's also possible that this is a bug with Ember Data, so I'm still investigating further.

Hmmm... I think this was PEBKAC. Looks like the object is a PromiseObject, so it wouldn't have the Ember Data properties on it yet. Sorry for the noise!


change jenkins base image

Must change the base image from jenkinsci/jenkins to jenkins/jenkins:lts.

The base image has been change to jenkins/jenkins:lts


Cleanup style within the config tool script

This makes style across the script signficantly more uniform. yapf was
used to get started on the work but a bit of it needed to be cleaned up
manually; however, in the future, the following yapf config should be
fine.
[style]
based_on_style = pep8
dedent_closing_brackets = true
split_complex_comprehension = true

@ripleymj Rebase complete


Deprecate call to PropTypes

Version
2.7.0
Test Case
Anywhere InternalPropTypes.js is used.
Fix
React throws an error when code call PropType functions, as in this file.
As specs recommend, in future React this would be deprecated.

This is addressed in 92824f606071cd1ee383a3509e26f36016a35bb2


Image for Python 3.8?

Hi, I'm looking for the repo containing the default docker image for an Azure App Service on linux/python-3.8. Can anybody point me to the right location?
The reason I'm asking: I suspect that the python-3.8 image does not contain nginx anymore, and that the only way to serve static resources (js, css etc.) is to use a WSGI framework that can handle static resources. Would be so awesome if anybody could confirm or clarify this. I've done so much research without getting anywhere, and I'm a bit lost now...
Thank you so much!

@ttosch : I have the same observation of nginx not being installed for linux/python-3.8 but the document https://docs.microsoft.com/en-us/azure/app-service/configure-language-python does mention gunicorn is run behind nginx to protect from DDoS attacks. Did you try/ find if latest linux container has this issue addressed?

@sspTest : I solved the problem for my django app by using the whitenoise module to deliver static content. For me, the solution was ok-ish since my app is not particularly high-scale and it doesn't hurt much that the static requests hit django.


Feature request: get fonts data or url

When using tools like Satori, we need to load fonts. It would be great to be able to access the data loaded in an endpoint

Hey @florian-lefebvre,
With the recently released version, now all the font files are present in a astro-font specific directory: https://github.com/rishi-raj-jain/astro-font/blob/master/packages/astro-font/utils.ts#L89
Does this solve your use case?

Btw, love the support! Happy to improve the library.

I can't try it now but it sounds good! It may be great to provide a little utility function to retrieve the data like:
export const getFontData = (fontName: string): ArrayBuffer => {
	// ...
}

Looking into this. Reading upon how can I do this.

@florian-lefebvre
I can use your direction here, how ideally would this function work?

I already shared the type signature above. Regarding its behavior, you're currently fonts files inside your cache. This function would retrieve the right font data (just reading the file content really) from the font family name


[scatter] unable to load bivariate chart (which flashes on screen)

Describe the bug
When I visit this URL, the scatter loads. But switching to bivariate results in an alert, then back to scatter, with a brief flash of the map, but back to scatter
To Reproduce
URL: https://staging.datacommons.org/tools/scatter#%26svx%3DCount_Person_BlackOrAfricanAmericanAlone%26pcx%3D1%26svy%3DCumulativeCount_MedicalConditionIncident_COVID_19_ConfirmedOrProbableCase%26pcy%3D1%26epd%3Dcountry%2FUSA%26epn%3DUnited States of America%26epts%3D%26ept%3DCounty%26qd%3D0%26ld%3D0%26dd%3D0%26ct%3D0%26rg%3D0
Browser: chrome
Reproduced twice, then unable to reproduce. Also unable to upload a screenshot unfortunately :(
Maybe this was fixed, and I had an old copy of js from staging. But just filing so we check again tomorrow
/cc @chejennifer

ok, looks like user bug - i had left out a parameter (epts). this link works:
https://staging.datacommons.org/tools/scatter#%26svx%3DCount_Person_BlackOrAfricanAmericanAlone%26pcx%3D1%26svy%3DCumulativeCount_MedicalConditionIncident_COVID_19_ConfirmedOrProbableCase%26pcy%3D1%26epd%3Dcountry%2FUSA%26epn%3DUnited States of America%26epts%3DCountry%26ept%3DCounty%26qd%3D0%26ld%3D0%26dd%3D0%26ct%3D1%26rg%3D0


Coverage Evaluation

Targets:

OpenSSL 1.1.1 (one version e.g. f/k)
wolfSSL 5.4.0

Fuzzers/Testers:

AFLNet/StateAFL/AFLNew (through profuzzbench)
TLSAnvil

Methodology:
Option A)

Let the fuzzer run for 1h or 24h and collect corpus
Instrument a plain statically compiled server executable with coverage
Execute the corpus over TCP against the server (In AFLNet this is done through afl-replay https://github.com/aflnet/aflnet/blob/master/afl-replay.c)

Issues:

⚠ In tlspuffin we use a custom setup of the server (certificate, options)

Option B)

Use Option A) for AFLNet, TLSAnvil

...

Let the fuzzer run for 1h or 24h and collect corpus
Compile a libssl.a static library just like the coverage binary from Option A)

Do not use any fuzzing specific flags for this binary! No -fsanitze=coverage! Use -fprofile-arcs -ftest-coverage!
Requires a build of tlspuffin which is designed for coverage evaluation.

Use libssl.a in tlspuffin and execute the seed corpus

TODO
OpenSSL: 1.1.1x
wolfSSL: 5.2.0

[ ] Test for CVE-2021-3336

[x] Adjust coverage filters for profuzzbench

[x] Compile without optimizations

[ ] Verify and check ASAN usage (max 1 campaign in parallel with ASAN!)

[ ] Enable 1.2 and 1.3 (wolfssl: -v d -7 3)

profuzzbench

[x] Create a coverage.csv from profuzzbench with OpenSSL

[x] StateAFL
[x] ~AFLNwe~
[x] AFLNet

[x] Create a coverage.csv from profuzzbench with wolfSSL

[x] StateAFL
[x] ~AFLNwe~
[x] AFLNet

tlspuffin

[x] Create a coverage.csv from tlspuffin with OpenSSL
[x] Create a coverage.csv from tlspuffin with wolfSSL

TLSAnvil

[x] Generate max. coverage from TLS-Anvil with OpenSSL
Coverage with TLS-Anvil when testing an OpenSSL 1.1.1j server:
lines: 32.8% (7397 out of 22565)
functions: 38.1% (512 out of 1345)
branches: 25.1% (3899 out of 15558)

With client:
lines: 41.5% (9603 out of 23164)
functions: 46.3% (641 out of 1383)
branches: 33.5% (5287 out of 15778)

[ ] Generate max. coverage from TLS-Anvil with wolfSSL

~Precompiled~ (Instead of precompiled I validated that the max. line count matches across all campaign evaluations)

[x] Use precompiled OpenSSL with TLS-Anvil with OpenSSL
[x] Use precompiled OpenSSL with profuzzbench
[x] Use precompiled OpenSSL with TLS-Anvil with wolfSSL
[x] Use precompiled wolfSSL with profuzzbench
[x] Use precompiled OpenssL with tlspuffin
[x] Use precompiled wolfSSL with tlspuffin

Related:

https://github.com/tls-attacker/TLS-Anvil/issues/11
https://github.com/stateafl/stateafl/issues/10

StateAFL -K bug:

https://github.com/stateafl/stateafl/blob/d923e22f7b2688db45b08f3fa3a29a566e7ff3a4/llvm_mode/afl-llvm-rt-state-tracer.o.c#L1879
https://github.com/stateafl/stateafl/blob/d923e22f7b2688db45b08f3fa3a29a566e7ff3a4/README-AFLnet.md?plain=1#L248

AFLnwe: -f .tmp-file to workaround short read

Execution plan:

Profuzzbench fuzzers (aflnet, aflnwe, stateafl): 10 trials, 24h each

Fuzzes wolfSSL and OpenSSL TLS 1.3 servers
10 (trials) * 2 (targets) * 3 (fuzzers) = 60 campaigns
-> Coverage plot

tlspuffin: 10 trials, 24h, each one core

Restrict to TLS 1.3 servers
10 (trials) * 2 (targets) = 20 campaigns
-> Coverage plot

tlspuffin 32 cores, 24h, 1 trial

1 (trials) * 2 (targets) = 2 campaigns
-> Single coverage number

TLS Anvil

Test first clients and then servers
1 (trials) * 2 (targets) = 2 campaigns
-> Single coverage number

The final result of this evaluation will be:

a large coverage plot, which includes tlspuffin, StateAFL, AFLNet and AFLnwe
Single number coverage comparision between TLS Anvil and tlspuffin and something like tlspuffin reached 95% the coverage of TLS Anvil after x hours.

Pain points during evaluation

Getting StateAFL running (-K flag)
Getting AFLnwe runnign (-f flag)
tlspuffin uses Cargo for linking. This makes tlspuffin reproducible, but it is very hard to compare with others, because linking is done by rustc instead of having control
Environment differences: like clang/gcc versions, gcov versions etc.

CVE-2022-38152 (SDOS2): Not reachable because wolfSSL_clear is not called
CVE-2022-38153 (CDOS): Not reachable because not client is fuzzed
CVE-2022-39173 (BUF): Not reachable because too hard.
CVE-2022-42905 (HEADP): ??

Running s_server with --rand-state=0 does not work -> crash

May: Task A, A1, D (server)

May: Task B, C

GCC and Clang calculate coverage differently, some seeses case XYZ as a line, the other doesn't.

TODO: TLS-Anvil client versions? wolfssl client 1.2/1.3, openssl client 1.2/1.3

Renegotiatoin Info in 5.3.0 is incompatible with TLS-Anvil: https://github.com/tls-attacker/TLS-Attacker/issues/152

https://github.com/profuzzbench/profuzzbench/issues/6

Fixed coverage misses when generating it. flush on exit

Observed issues during this evaluation:

AFLnwe: https://github.com/thuanpv/aflnwe/issues/2
AFLnwe: https://github.com/thuanpv/aflnwe/issues/1
AFLnwe: https://github.com/thuanpv/aflnwe/issues/3
AFLnwe: https://github.com/thuanpv/aflnwe/issues/4
TLS-Anvil: https://github.com/tls-attacker/TLS-Attacker/issues/152
StateAFL: https://github.com/stateafl/stateafl/issues/11


Update ResizeImageDialog.cs

Changed default resize mode from percent to absolute

This looks good, thanks! This behaviour seems to match Paint.NET