Build image only if there is changes in the daily_params file.

@icygalz: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/release-e2e-bookinfoTests
c621f6bb653a849a52569496c51687d1cf60b5f2
link
/test release-e2e-bookinfoTests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@icygalz: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/release-e2e-bookinfoTests
c621f6bb653a849a52569496c51687d1cf60b5f2
link
/test release-e2e-bookinfoTests

prow/release-e2e-simpleTests
c621f6bb653a849a52569496c51687d1cf60b5f2
link
/test release-e2e-simpleTests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@icygalz: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/release-e2e-bookinfoTests
c621f6bb653a849a52569496c51687d1cf60b5f2
link
/test release-e2e-bookinfoTests

prow/release-e2e-simpleTests
c621f6bb653a849a52569496c51687d1cf60b5f2
link
/test release-e2e-simpleTests

prow/release-e2e-pilot-no_auth
c621f6bb653a849a52569496c51687d1cf60b5f2
link
/test release-e2e-pilot-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@icygalz: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/release-e2e-bookinfoTests
c621f6bb653a849a52569496c51687d1cf60b5f2
link
/test release-e2e-bookinfoTests

prow/release-e2e-simpleTests
c621f6bb653a849a52569496c51687d1cf60b5f2
link
/test release-e2e-simpleTests

prow/release-e2e-pilot-no_auth
c621f6bb653a849a52569496c51687d1cf60b5f2
link
/test release-e2e-pilot-no_auth

prow/release-e2e-mixer-no_auth
c621f6bb653a849a52569496c51687d1cf60b5f2
link
/test release-e2e-mixer-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@icygalz: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/release-e2e-bookinfoTests
c621f6bb653a849a52569496c51687d1cf60b5f2
link
/test release-e2e-bookinfoTests

prow/release-e2e-simpleTests
c621f6bb653a849a52569496c51687d1cf60b5f2
link
/test release-e2e-simpleTests

prow/release-e2e-pilot-no_auth
c621f6bb653a849a52569496c51687d1cf60b5f2
link
/test release-e2e-pilot-no_auth

prow/release-e2e-mixer-no_auth
c621f6bb653a849a52569496c51687d1cf60b5f2
link
/test release-e2e-mixer-no_auth

prow/release-e2e-dashboard
c621f6bb653a849a52569496c51687d1cf60b5f2
link
/test release-e2e-dashboard

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@icygalz: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/release-e2e-bookinfoTests
c621f6bb653a849a52569496c51687d1cf60b5f2
link
/test release-e2e-bookinfoTests

prow/release-e2e-simpleTests
c621f6bb653a849a52569496c51687d1cf60b5f2
link
/test release-e2e-simpleTests

prow/release-e2e-pilot-no_auth
c621f6bb653a849a52569496c51687d1cf60b5f2
link
/test release-e2e-pilot-no_auth

prow/release-e2e-mixer-no_auth
c621f6bb653a849a52569496c51687d1cf60b5f2
link
/test release-e2e-mixer-no_auth

prow/release-e2e-dashboard
c621f6bb653a849a52569496c51687d1cf60b5f2
link
/test release-e2e-dashboard

prow/release-upgrade-tests-1.1.7
c621f6bb653a849a52569496c51687d1cf60b5f2
link
/test release-upgrade-tests-1.1.7

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@icygalz: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/release-e2e-bookinfoTests
c621f6bb653a849a52569496c51687d1cf60b5f2
link
/test release-e2e-bookinfoTests

prow/release-e2e-simpleTests
c621f6bb653a849a52569496c51687d1cf60b5f2
link
/test release-e2e-simpleTests

prow/release-e2e-pilot-no_auth
c621f6bb653a849a52569496c51687d1cf60b5f2
link
/test release-e2e-pilot-no_auth

prow/release-e2e-mixer-no_auth
c621f6bb653a849a52569496c51687d1cf60b5f2
link
/test release-e2e-mixer-no_auth

prow/release-e2e-dashboard
c621f6bb653a849a52569496c51687d1cf60b5f2
link
/test release-e2e-dashboard

prow/release-upgrade-tests-1.1.7
c621f6bb653a849a52569496c51687d1cf60b5f2
link
/test release-upgrade-tests-1.1.7

prow/release-e2e-stackdriver
c621f6bb653a849a52569496c51687d1cf60b5f2
link
/test release-e2e-stackdriver

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@icygalz: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/release-e2e-bookinfoTests
c621f6bb653a849a52569496c51687d1cf60b5f2
link
/test release-e2e-bookinfoTests

prow/release-e2e-simpleTests
c621f6bb653a849a52569496c51687d1cf60b5f2
link
/test release-e2e-simpleTests

prow/release-e2e-pilot-no_auth
c621f6bb653a849a52569496c51687d1cf60b5f2
link
/test release-e2e-pilot-no_auth

prow/release-e2e-mixer-no_auth
c621f6bb653a849a52569496c51687d1cf60b5f2
link
/test release-e2e-mixer-no_auth

prow/release-e2e-dashboard
c621f6bb653a849a52569496c51687d1cf60b5f2
link
/test release-e2e-dashboard

prow/release-upgrade-tests-1.1.7
c621f6bb653a849a52569496c51687d1cf60b5f2
link
/test release-upgrade-tests-1.1.7

prow/release-e2e-stackdriver
c621f6bb653a849a52569496c51687d1cf60b5f2
link
/test release-e2e-stackdriver

prow/release-build-test-e2e-simpleTests
c621f6bb653a849a52569496c51687d1cf60b5f2
link
/test release-build-test-e2e-simpleTests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@icygalz: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/release-build-test-e2e-simpleTests
c621f6bb653a849a52569496c51687d1cf60b5f2
link
/test release-build-test-e2e-simpleTests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test release-build-test-e2e-simpleTests

@icygalz: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/release-e2e-simpleTests
07751cbbc0a577092410a5f568ed9c6bbe888897
link
/test release-e2e-simpleTests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test release-e2e-simpleTests

@icygalz: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/release-e2e-bookinfoTests
07751cbbc0a577092410a5f568ed9c6bbe888897
link
/test release-e2e-bookinfoTests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test release-e2e-bookinfoTests

@icygalz: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/release-e2e-bookinfoTests
07751cbbc0a577092410a5f568ed9c6bbe888897
link
/test release-e2e-bookinfoTests

prow/release-e2e-pilot-no_auth
07751cbbc0a577092410a5f568ed9c6bbe888897
link
/test release-e2e-pilot-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test release-e2e-pilot-no_auth


Add absinthe as an optional dependency

Signed-off-by: Maciej Szlosarczyk<EMAIL_ADDRESS>

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from maciej-szlosarczyk. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: 8c5e5bf07ad839b2d1b9619030a69cc00890de78

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: antonsatin
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [antonsatin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


weird dependency on pandas 1.5.3 when upgrading to samplics 0.4.11

I don't know why, but when I try to upgrade samplics package from 0.4.10 to 0.4.11 it wants to downgrade my pandas from 2.2.1 to 1.5.3.  Any ideas?  From what I can tell from the source code this is not indicated in the requirements.txt file or anywhere else so I am not sure why it wants to do that.

I had the same issue but was able to resolve this by installing samplics with no dependencies.
pip install samplics --no-deps
You may need to pip install several other dependencies manually afterward, but it has worked for me so far.

Today I will update the dependency (0.4.12). Thanks

I had the same issue but was able to resolve this by installing samplics with no dependencies.
pip install samplics --no-deps
You may need to pip install several other dependencies manually afterward, but it has worked for me so far.

Thanks.  I ended up upgrading samplics and letting it downgrade my pandas then afterwards I upgraded my pandas back to 2.2.2. Same end result... different path I guess

Today I will update the dependency (0.4.12). Thanks

Thank you for such a quick response!


S005 Query test

We'll check that we can send queries and receive response to and from the db.
Also, we should check that we can write to the db.

Table.objects.using("hypance_db")
Sorgular using kullanacak şekilde düzenlenmeli.


Acrolinx quality improvements: bitsadmin-getproxybypasslist.md

.md

Learn Build status updates of commit 6a46e4b:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

WindowsServerDocs/administration/windows-commands/bitsadmin-getproxybypasslist.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

#assign: @robinharwood, @Xelu86
Can you review the proposed changes? IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team


Python examples signal names

In python examples csv_writer and signal_graphed_overtime.py, and maybe others,
signal names are retrieved using "signal.signal_descriptor.name".
However signal_descriptor is not set via streaming protocol (tested with websocket), giving empty name strings
Instead, the names can be retrieved directly from the object "signal.name"

Hello,
Thank you for the observation! Indeed in those examples signal.name should be used. The data descriptor name is highly specific and it's only used when we want to explicitly label the data in a signal, or when the signal contains struct data.
The field is not mandatory, and as such, cannot be relied upon to be filled in.


when i train model on TID2013 dataset,something went wrong

I want to train a model on tid2013,so i changed some details in  the script of data_loader.py.but i got an error:
Traceback (most recent call last):
File "train_mobilenet_tid.py", line 90, in
validation_steps=(500. // batchsize))
File "/usr/local/lib/python2.7/dist-packages/keras/legacy/interfaces.py", line 91, in wrapper
return func(*args, **kwargs)
File "/usr/local/lib/python2.7/dist-packages/keras/engine/training.py", line 1418, in fit_generator
initial_epoch=initial_epoch)
File "/usr/local/lib/python2.7/dist-packages/keras/engine/training_generator.py", line 181, in fit_generator
generator_output = next(output_generator)
File "/usr/local/lib/python2.7/dist-packages/keras/utils/data_utils.py", line 709, in get
six.reraise(*sys.exc_info())
File "/usr/local/lib/python2.7/dist-packages/keras/utils/data_utils.py", line 685, in get
inputs = self.queue.get(block=True).get()
File "/usr/lib/python2.7/multiprocessing/pool.py", line 567, in get
raise self._value
TypeError: Can't instantiate abstract class Dataset with abstract methods _as_variant_tensor, output_classes, output_shapes, output_types
I am so confused of this error,could you help me with this?

For different datasets, you need to pass in the the correct shapes of the batches, since tid and AVA have different numver of samples.

@titu1994 I already changed the script of data_loader.py,the shape of training set and val set as well.I am not sure what you mean about the shapes of the batches.

Hmm that is weird. I don't know the reason for this error then. I'll search if there is any answer on Google.

@titu1994  i run your code ——train_mobilenet.py,there was the same error

@leeqiaogithub  have you solved this error?

can anyone have TID2013 and TID2008 datasets, i wan to use it for training but i can find it in the internet. Thank you so much


Extended Characters in filenames (like Café.png) are bad encoded...

Hello,
If I upload files containing accentued characters like in "café" in their filename (ex: MyCafé.png), the é is lost and becomes A~... due to the UTF-8 character set in the Content-Type header. (I mean, I receive bad characters in Java in Tomcat)
How can I fix this ?
thank you

hmm.. are you sure this happens on client side?

I have the same result at back end (java).  File name sent to server is not correct


We need to decide on a name

I chose 'Waverbase' as a joke because Waver is an antonym of Parse :)
It's hard to say Waverbase, I think that 'Waver' is a reasonable name, but I'm not sure about domains etc.
It would be nice to have a name without too many clashes on things like github and slack.

Metabase.

abstractmetabase

waverbase.com is available


Initial implementation of the Hive Connector based on the Spark datasource v2

@pan3793 @yaooqinn Have a base implement for kyuubi-hive-connector, this is just the first step, and some other work may be needed later

Documentation for hive-connector
Write code path
DataSourceV2Relation(HiveRelation) can be convered to localRelation to speed up the query
HiveClient Pool
......

Could you hlep review this idea? If the idea is acceptable, we can launch a new PR to kyuubi

can you also pin this in this thread https://lists.apache.org/thread/fq8ywr58rzf9bycflj1q4fl1xyz2rq2w ?

have pulled this POC code to my local repo, will go a detailed look ASAP, keep in touch.

Re-open PR in the community later, close this


Solvers as extra requires

Codecov Report

Merging #143 (4f85c16) into master (7a3cbb2) will decrease coverage by 4.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #143      +/-   ##
==========================================
- Coverage   92.97%   88.88%   -4.09%
==========================================
  Files          89       89
  Lines       11196    11196
==========================================
- Hits        10409     9952     -457
- Misses        787     1244     +457

Impacted Files
Coverage Δ

unified_planning/interop/from_tarski.py
7.22% <0.00%> (-78.32%)
:arrow_down:

unified_planning/test/test_tarski_grounder.py
22.33% <0.00%> (-77.67%)
:arrow_down:

unified_planning/interop/to_tarski.py
17.36% <0.00%> (-61.06%)
:arrow_down:

unified_planning/test/test_tarski_converter.py
40.00% <0.00%> (-60.00%)
:arrow_down:

unified_planning/solvers/tarski_grounder.py
24.28% <0.00%> (-51.43%)
:arrow_down:

unified_planning/transformers/grounder.py
90.50% <0.00%> (-1.27%)
:arrow_down:

unified_planning/model/expression.py
93.08% <0.00%> (-0.63%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a3cbb2...4f85c16. Read the comment docs.


Equi template fails on macos and ios

Describe the bug
Equi example fails on all devices I have access to. Macos and ios.
Macos fails with
error[E0603]: function `main` is private
   --> gen/bin/desktop.rs:3:18
    |
3   |     mobile_equi::main();
    |                  ^^^^ private function
    |
note: the function `main` is defined here
   --> /Users/awk21/Projects/Coding/Rust/mobile_equi/src/lib.rs:160:1
    |
160 | fn main() {
    | ^^^^^^^^^

For more information about this error, try `rustc --explain E0603`.
error: could not compile `mobile-equi` due to previous error

and ios with
Undefined symbols for architecture arm64:
  "_start_app", referenced from:
      _main in main.o
ld: symbol(s) not found for architecture arm64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
note: Building targets in dependency order
note: Run script build phase 'Build Rust Code' will be run during every build because the option to run the script phase "Based on dependency analysis" is unchecked. (in target 'mobile-equi_iOS' from project 'mobile-equi')
** BUILD FAILED **

error: Failed to build via `xcodebuild`
    command ["xcodebuild"] exited with code 65

The first error is easy to fix with the addition of a pub but the latter needed more work
Steps To Reproduce
Create a equi tempalte and try to run or archive it with apple
Expected behavior
No errors
Platform and Versions (please complete the following information):
Host OS: Macos
Target OS: Macos and ios
Rustc: rustc 1.69.0 (84c898d65 2023-04-16)
cargo mobile doctor:
[✔] cargo-mobile v0.5.0
• Contains commits up to "Add egui example (#164)\n"
• Installed at "~/.cargo/.tauri-mobile"
• macOS v12.5 (21G72)
• rustc v1.69.0 (84c898d65 2023-4-16)
[✔] Apple developer tools
• Xcode v14.2
• Active developer dir: "/Applications/Xcode.app/Contents/Developer"
• ios-deploy v1.12.2
• XcodeGen v2.35.0
✗ xcode-rust-plugin plugin absent
✗ xcode-rust-plugin lang spec absent
✗ xcode-rust-plugin lang metadata absent
• xcode-rust-plugin is up-to-date
✗ xcode-rust-plugin doesn't support Xcode UUID "C91F3560-00E7-4749-8E3F-4D83B1496051"
• Development team: Andrew King (N7VJA8E4L8)
[!] Android developer tools
✗ Have you installed the Android SDK? The ANDROID_HOME environment variable isn't set, and is required: environment variable not found
[!] Connected devices
✗ Failed to get iOS device list: Failed to request device list from ios-deploy: command ["ios-deploy", "--detect", "--timeout", "1", "--json", "--no-wifi"] exited with code
253
Would you want to assign yourself to resolve this bug?

[x] Yes
[ ] No

Additional context
See comments on #164 too

The following diff should get it to work
--- ../mobile_cmp/src/lib.rs	2023-05-30 16:09:01.000000000 +0700
+++ src/lib.rs	2023-06-01 16:48:39.000000000 +0700
@@ -1,6 +1,7 @@
 #[cfg(target_os = "android")]
 use winit::platform::android::activity::AndroidApp;

+use anyhow::Result;
 use winit::event::Event::*;
 use winit::event_loop::{ControlFlow, EventLoop, EventLoopBuilder, EventLoopWindowTarget};

@@ -139,25 +140,34 @@
     });
 }

-#[allow(dead_code)]
-#[cfg(target_os = "android")]
-#[no_mangle]
-fn android_main(app: AndroidApp) {
-    use winit::platform::android::EventLoopBuilderExtAndroid;
+#[cfg(any(target_os = "android", target_os = "ios"))]
+fn stop_unwind<F: FnOnce() -> T, T>(f: F) -> T {
+    match std::panic::catch_unwind(std::panic::AssertUnwindSafe(f)) {
+        Ok(t) => t,
+        Err(err) => {
+            eprintln!("attempt to unwind out of `rust` with err: {:?}", err);
+            std::process::abort()
+        }
+    }
+}

-    android_logger::init_once(
-        android_logger::Config::default().with_max_level(log::LevelFilter::Warn),
-    );
+#[cfg(any(target_os = "android", target_os = "ios"))]
+fn _start_app() {
+    stop_unwind(|| main().unwrap());
+}

-    let event_loop = EventLoopBuilder::with_user_event()
-        .with_android_app(app)
-        .build();
-    _main(event_loop);
+#[no_mangle]
+#[inline(never)]
+#[cfg(any(target_os = "android", target_os = "ios"))]
+pub extern "C" fn start_app() {
+    #[cfg(target_os = "android")]
+    android_binding!({{reverse-domain-snake-case app.domain}}, {{snake-case app.name}}, _start_app);
+    #[cfg(target_os = "ios")]
+    _start_app()
 }

-#[allow(dead_code)]
 #[cfg(not(target_os = "android"))]
-fn main() {
+pub fn main() -> Result<()> {
     env_logger::builder()
         .filter_level(log::LevelFilter::Warn)
         .parse_default_env()
@@ -165,4 +175,22 @@

     let event_loop = EventLoopBuilder::with_user_event().build();
     _main(event_loop);
+
+    Ok(())
+}
+
+#[cfg(target_os = "android")]
+pub fn main() -> Result<()> {
+    use winit::platform::android::EventLoopBuilderExtAndroid;
+
+    android_logger::init_once(
+        android_logger::Config::default().with_max_level(log::LevelFilter::Warn),
+    );
+
+    let event_loop = EventLoopBuilder::with_user_event()
+        .with_android_app(app)
+        .build();
+    _main(event_loop);
+
+    Ok(())
 }

Changes were adding the pub on main and also adding start_app and safe_unwind parts. I also did the android_main as a main cfg varient but can't test that.

 It should definitely be there.
But your diff doesn't work on android because app is not found in the scope. We need to have a special android_main for android otherwise winit's android-activity won't bind to it correctly.
May I suggest this for lib.rs?
#[cfg(target_os = "android")]
use winit::platform::android::activity::AndroidApp;

use winit::event::Event::*;
use winit::event_loop::{ControlFlow, EventLoop, EventLoopBuilder, EventLoopWindowTarget};

use egui_wgpu::winit::Painter;
use egui_winit::State;

const INITIAL_WIDTH: u32 = 1920;
const INITIAL_HEIGHT: u32 = 1080;

/// A custom event type for the winit app.
enum Event {
    RequestRedraw,
}

/// Enable egui to request redraws via a custom Winit event...
#[derive(Clone)]
struct RepaintSignal(std::sync::Arc<std::sync::Mutex<winit::event_loop::EventLoopProxy<Event>>>);

fn create_window<T>(
    event_loop: &EventLoopWindowTarget<T>,
    state: &mut State,
    painter: &mut Painter,
) -> winit::window::Window {
    let window = winit::window::WindowBuilder::new()
        .with_decorations(true)
        .with_resizable(true)
        .with_transparent(false)
        .with_title("egui winit + wgpu example")
        .with_inner_size(winit::dpi::PhysicalSize {
            width: INITIAL_WIDTH,
            height: INITIAL_HEIGHT,
        })
        .build(event_loop)
        .unwrap();

    pollster::block_on(painter.set_window(Some(&window))).unwrap();

    // NB: calling set_window will lazily initialize render state which
    // means we will be able to query the maximum supported texture
    // dimensions
    if let Some(max_size) = painter.max_texture_side() {
        state.set_max_texture_side(max_size);
    }

    let pixels_per_point = window.scale_factor() as f32;
    state.set_pixels_per_point(pixels_per_point);

    window.request_redraw();

    window
}

fn _main(event_loop: EventLoop<Event>) {
    let ctx = egui::Context::default();
    let repaint_signal = RepaintSignal(std::sync::Arc::new(std::sync::Mutex::new(
        event_loop.create_proxy(),
    )));
    ctx.set_request_repaint_callback(move |_| {
        repaint_signal
            .0
            .lock()
            .unwrap()
            .send_event(Event::RequestRedraw)
            .ok();
    });

    let mut state = State::new(&event_loop);
    let mut painter = Painter::new(
        egui_wgpu::WgpuConfiguration::default(),
        1, // msaa samples
        None,
        false,
    );
    let mut window: Option<winit::window::Window> = None;
    let mut egui_demo_windows = egui_demo_lib::DemoWindows::default();

    event_loop.run(move |event, event_loop, control_flow| match event {
        Resumed => match window {
            None => {
                window = Some(create_window(event_loop, &mut state, &mut painter));
            }
            Some(ref window) => {
                pollster::block_on(painter.set_window(Some(window))).unwrap();
                window.request_redraw();
            }
        },
        Suspended => {
            window = None;
        }
        RedrawRequested(..) => {
            if let Some(window) = window.as_ref() {
                let raw_input = state.take_egui_input(window);

                let full_output = ctx.run(raw_input, |ctx| {
                    egui_demo_windows.ui(ctx);
                });
                state.handle_platform_output(window, &ctx, full_output.platform_output);

                painter.paint_and_update_textures(
                    state.pixels_per_point(),
                    egui::Rgba::default().to_array(),
                    &ctx.tessellate(full_output.shapes),
                    &full_output.textures_delta,
                    false,
                );

                if full_output.repaint_after.is_zero() {
                    window.request_redraw();
                }
            }
        }
        MainEventsCleared | UserEvent(Event::RequestRedraw) => {
            if let Some(window) = window.as_ref() {
                window.request_redraw();
            }
        }
        WindowEvent { event, .. } => {
            match event {
                winit::event::WindowEvent::Resized(size) => {
                    painter.on_window_resized(size.width, size.height);
                }
                winit::event::WindowEvent::CloseRequested => {
                    *control_flow = ControlFlow::Exit;
                }
                _ => {}
            }

            let response = state.on_event(&ctx, &event);
            if response.repaint {
                if let Some(window) = window.as_ref() {
                    window.request_redraw();
                }
            }
        }
        _ => (),
    });
}

#[cfg(any(target_os = "ios", target_os = "android"))]
fn stop_unwind<F: FnOnce() -> T, T>(f: F) -> T {
    match std::panic::catch_unwind(std::panic::AssertUnwindSafe(f)) {
        Ok(t) => t,
        Err(err) => {
            eprintln!("attempt to unwind out of `rust` with err: {:?}", err);
            std::process::abort()
        }
    }
}

#[cfg(target_os = "ios")]
fn _start_app() {
    stop_unwind(|| main().unwrap());
}

#[no_mangle]
#[inline(never)]
#[cfg(target_os = "ios")]
pub extern "C" fn start_app() {
    _start_app();
}

#[cfg(not(target_os = "android"))]
pub fn main() -> Result<()> {
    env_logger::builder()
        .filter_level(log::LevelFilter::Warn)
        .parse_default_env()
        .init();

    let event_loop = EventLoopBuilder::with_user_event().build();
    _main(event_loop);

    Ok(())
}

#[allow(dead_code)]
#[cfg(target_os = "android")]
#[no_mangle]
fn android_main(app: AndroidApp) {
    use winit::platform::android::EventLoopBuilderExtAndroid;

    android_logger::init_once(
        android_logger::Config::default().with_max_level(log::LevelFilter::Warn),
    );

    let event_loop = EventLoopBuilder::with_user_event()
        .with_android_app(app)
        .build();
    stop_unwind(|| _main(event_loop));
}

Works on linux and android, but I can't test it on iOS or mac

Works on mac, just having trouble connecting ios at the moment. I think perhaps the 1s timeout is too short on ios-deploy, is there anyway to configure that?
Also you will need to remove  -> Result<()> from main the Ok(()) too

Also have you considered adding some checks on the github runners for macos at least? Could probably do ios too with some setup

Might be easier if you just add it in. It's a small change for a PR

If you need any other ios/mac tests drop me a message and I will see if I can accomadate


mssql user settings need to be localized and capitalized correctly

Entries in sqlopsstudio\extensions\mssql\package.json need to use localized references in sqlopsstudio\extensions\mssql\package.nls.json
Some descriptions like:

_"mssql.format.placeCommasBeforeNextStatement": {
          "type": "boolean",
          "description": "**should** commas be placed at the beginning of each statement in a list e.g. ', mycolumn2' instead of at the end e.g. 'mycolumn1,'",_

should be starting with capital letter and should be punctuated properly.

Closing older issues.


Extend the XVIZPrimitiveBuilder API to link more information (like velocity, acceleration, orientation) into /tracklets objects

Motivation
Context: In my project, we have rich data (like velocity, acceleration, orientation) associated with each tracklet object (non-Ego vehicle).
PROBLEM: Currently, XVIZPrimitiveBuilder API [1] just support: style(), polygon(), polyline(), points(), etc, but not support a way to associate extra information (as mentioned above) with each tracklet object.
This fact creates a blocker for features like: we want to have special processing / display when users select a tracklet object in streetscapes.gl. Note that I am aware of the Data Stream labels which is a data stream independent from the data stream /primitives, this solution is not good enough because for a given tracklet object, there is no way to look up associated extra information in Data Stream labels.
Wish
XVIZPrimitiveBuilder API allows to associate more information to tracklet objects so that we can add more features which are specific to each tracklet object.
NOTE
This feature would support ticket in ref[2] because we have more information (such as orientation) of each tracklet object. If a tracklet object is selected, we want the Camera to follow that object and the Camera orientation should respect the orientation of the vehicle.
[1] https://github.com/uber/xviz/blob/master/docs/api-reference/xviz-builder.md
[2] https://github.com/uber/streetscape.gl/issues/256

I make the code changes for this request, but I have no write access. Please help consider this change and merge into the master. Thank you very much!
// Write permission error in my machine
ERROR: Permission to uber/xviz.git denied to tkt028.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

I attach here the patch.
0001-xviz-417-Extend-the-XVIZPrimitiveBuilder-API-to-add-.patch.txt
How it works?
I simply add a method "data()" to XVIZPrimitiveBuilder API to contain the extra data associated with the primitive objects in the property base so that this information is available for application-level features.
Sample code to use this method
                xvizBuilder
                    .primitive('/tracklets/objects')
                    .polygon(points)
                    .data({
                        "velocity": 123.5,
                        "acceleration": 30.3,
                        "orientation": orientationQuarternion
                    })
                    .id(objectId);

The sample output of XVIZ frame
{
  "type": "xviz/state_update",
  "data": {
    "update_type": "snapshot",
    "updates": [
      {
        "timestamp":<PHONE_NUMBER>.068,
        "poses": {
          "/vehicle_pose": {
            "timestamp":<PHONE_NUMBER>.068,
            "mapOrigin": {
              "longitude": -121.9318621943,
              "latitude": 37.3146625269,
              "altitude": 12.1044184975
            },
            "position": [
              0,
              0,
              0
            ],
            "orientation": [
              0.786244846,
              -0.5200232285,
              -0.0794160647
            ]
          }
        },
        "primitives": {
          "/tracklets/objects": {
            "polygons": [
              {
                "vertices": [
                  [
                    -121.9318762094,
                    37.3146411597,
                    11.3361635925
                  ],
                  [
                    -121.9318911258,
                    37.3146555697,
                    11.3402691875
                  ],
                  [
                    -121.9318484293,
                    37.3146837662,
                    11.2606567824
                  ],
                  [
                    -121.9318335129,
                    37.3146693562,
                    11.2565511838
                  ]
                ],
                "base": {
                  "object_id": "1",
                  "style": {
                    "height": 1.6122326993,
                    "fill_color": "#FF0000",
                    "stroke_color": "#50B3FF",
                    "stroke_width": 10
                  },
                  "classes": [
                    "Car"
                  ],
                  "data": {                 // NOTE: the extra data are here.
                    "velocity": 17.0942451587,
                    "velocityVector": {
                      "x": 6.5738332458,
                      "y": -0.4282775614,
                      "z": 3.8728041155
                    },
                    "acceleration": 9.9139034013,
                    "accelerationVector": {
                      "x": 0.0414319802,
                      "y": -2.412983682,
                      "z": -1.8184643239
                    },
                    "orientation": {
                      "w": 0.8958744974,
                      "x": 0.3604790233,
                      "y": -0.2519889424,
                      "z": 0.0629708786
                    }
                  }
                }
              }
            ]
          }
        }
      }
    ]
  }
}

Sample screenshot in Streetscapes.gl of how frame data look like

So we actually do support some associated data, but not in the way you are thinking.
The way we support this is with the id method when you build the streams.
https://github.com/uber/xviz/blob/master/examples/converters/kitti/src/converters/tracklets-converter.js#L80
As you can see in this code, we create separate streams for each datum velocity, etc
Then the front-end application will merge attributes for streams with a matching id.
This is how we show this information when you click on an object.

Now, this works but the data you are passing may run into some issue.  The main stream in XVIZ for such data is our time_series.  The scalar values are fine as they map to just a number, but your vector and mtx values won't fit nicely in our current data model (we don't provide an array type for time_series)
A short-term hack would be to turn it into a string :(
I will add an issue for adding array valued time_series data

So there are ways to track an object today (I'll be adding to some FAQ/examples in the next few weeks).  However it doesn't track the orientation of that object.  That would be cool and will add that to the issue.

Huge thanks for taking the time to work this out!  Will work to make sure our use-case are covered.

See https://github.com/uber/xviz/blob/master/docs/protocol-schema/core-types.md#time-series-state

Hi @twojtasz,
Thank you very much for your below explain about how XVIZ organizes the data structure.
So we actually do support some associated data, but not in the way you are thinking.

The way we support this is with the id method when you build the streams.
https://github.com/uber/xviz/blob/master/examples/converters/kitti/src/converters/tracklets-converter.js#L80

As you can see in this code, we create separate streams for each datum velocity, etc
Then the front-end application will merge attributes for streams with a matching id.

I think this approach is OK for simple feature like rendering a Text Label when users click a vehicle object.
For feature like [1] which make the Camera to follow a selected vehicle object, it's important to be able to look up the orientation information of the vehicle so that we can adjust the Camera View parameters. Since I didn't find a way to look up the orientation information if I have another data stream, so I think it makes sense to attach the extra information to a vehicle object in a tightly-coupled way. Currently, this solution works very well in my project for the feature [1]. But if you have a better way, please feel free to suggest it because I don't want my codes diverge from the AVS code base. Thank you very much!
[1] https://github.com/uber/streetscape.gl/issues/256


[Feat.]: Whether it can support without filling in the host login user name and password

Check Before Asking

[X] Please check the issue list and confirm this feature is encountered for the first time.
[X] Please try full text in English and attach precise description.

Description
The host has been set up for mutual trust and confidentiality. Whether it can support without filling in the host login user name and password.

Other Information
No response

Okay, good suggestion.

This feature is already supported


Working withSurfaceThreshold for SimpleSwipeDrawerCallback

Just added something else I just noticed today - if the click event is consumed, that info has to be communicated to the handler.

Definitely done with my testing. Would be fantastic if you could release that during the week 👍

@RobbWatershed https://github.com/mikepenz/FastAdapter/releases/tag/v5.3.1 here you go :)

Thanks a lot @mikepenz !!


Installation issue

fm: Unable to open /dev/radio0: No such file or directory

Can you provide more detailed info as how it occurred, what is your operating system, python version and if possible fm.log ?

docker service is running , but still not able to create site

Can you provide more detailed info as how it occurred, what is your operating system, python version and if possible fm.log ?

Python 3.10.12
ubuntu22.04

i had same issue and fixed; https://github.com/rtCamp/Frappe-Manager/issues/83

I’ve solved this problem

Create the docker group.
sudo groupadd docker

Add the user to the docker group.
sudo usermod -aG docker jignesh
→ this jignesh is user name

Log out and log back in to ensure docker runs with correct permissions.
Start docker.
sudo service docker start
→ I just do reboot.


Golden Config E3005, E3006, Golden Config Setting - Path in Jinja

Environment

Nautobot version (Docker tag too if applicable): Nautobot version: 2.3.14 | Django version: 4.2.17
Python version: Python 3.10.12
Database platform, version: psql (PostgreSQL) 14.15 (Ubuntu 14.15-0ubuntu<IP_ADDRESS>)
Middleware(s): n/a

If anyone is able to help me at least at some stage, I would be very grateful :)
According to the documentation, the pathways in Jinja should look like this:
https://github.com/racsoce/nautobot-plugin-golden-config/blob/develop/docs/navigating-golden.md#application-settings

However, the Nautobot GUI gives examples like this:

How can I find out what is correct? I'm assuming there is no such thing as ‘site’ any more, as it has probably renamed the field to ‘location’. Please help and briefly explain how this should work.
I also created some GraphQL so that I could configure the Golden Config Setting (the place where I pointed to the GitHub repositories and the Jinja backup paths),

because otherwise I was showing this error:

And I needed to configure Golden Config Setting to be able to do the Config Compliances Job.... :) I also have a simple Compliance Rules configured:

Once I had done everything I described above, I was finally able to run the Configuration Compliance Job, but I was getting errors like E3005 and E3006, which are not described in the documentation:

When I manually added a directory, with these .cfg files on GitHub (empty, just to get rid of the error) the error actually did not occur, however the Return Value remained the same and I don't know what the issue is with it....

However, I'm assuming that's not the point of adding something manually to GitHub, but rather I think it should be created as a result of Job execution or something similar.
I also got as far as a place like this where you can generate some configuration, but here I also encountered an error and I don't know if at this stage you don't need to do something in the CLI in the natubot configuration e.g. in the /opt/nautobot/nautobot_config.py file?

Perhaps this is a clue? However, I don't see such a directory in files like custom_jinja_filters/config_templates.py. However, I prefer to ask because I don't want to mess it all up....
https://docs.nautobot.com/projects/golden-config/en/latest/user/app_feature_intended/#adding-filters-in-nautobot-config

When I additionally performed Generate Intended Configurations from Configuration Overview, I received these errors. This makes me feel all the more confident that if I solve this problem it will cascade the others more easily too.

Are such generic Jinja templates available somewhere or do you have to make them yourself for your own needs? What is the idea with these Jinja templates?

I'll just note that the repo you linked to (https://github.com/racsoce/nautobot-plugin-golden-config/blob/develop/docs/navigating-golden.md#application-settings) appears to be an out-of-date fork of the official golden-config repo (https://github.com/nautobot/nautobot-app-golden-config) which probably explains any discrepancy between that repo and the current version of the app.
I'll let other who are more familiar with deploying golden-config address your other questions.


Update workflows with repository owner variable

As I've been working on the CI a bit to check for updated repositories, I've come across some points that can be improved. As I don't want to put everything in one PR, this is the first bit of it.
Instead of hardcoding aica-technology to the image names everywhere, we can just use ${{ github.repository_owner }}, a much cleaner solution.
Tested on my fork.

Great, seems like a nice improvement. Careful that this syntax is only used for properly formatted repository names (e.g. the prior control_libraries might have been an issue). Here it's good for sure

Remind me, is that because of our own conventions, or because it would actually not be supported?


Add inflector to container settings

This makes it easier to provide a custom inflector. At the same time, this
change is not backward compatible with existing custom loaders since now their
constructors have to accept 2 arguments.

It's my first PR here, please be gentle!

@GustavoCaso no, it wouldn't because it's the problem on the calling side which now passes two args. I brought back the default arg, though, on morning I decided it works better :)

@flash-gordon awesome!


[SPARK-42111][SQL][TESTS] Mark Orc*FilterSuite/OrcV*SchemaPruningSuite as ExtendedSQLTest

What changes were proposed in this pull request?
Like SPARK-33171, this PR aims to mark Orc*FilterSuite/OrcV*SchemaPruningSuite as ExtendedSQLTest.
Why are the changes needed?
This will remove these tests to Slow Test job from Other Test job in order to balance the GitHub Action CI jobs.

Slow Test job took 1h 45m.

https://github.com/apache/spark/actions/runs/3953535259/jobs/6769916752

Other Test job took 3h 8m.

https://github.com/apache/spark/actions/runs/3953535259/jobs/6769916829

Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass the CIs and check GitHub Action jobs' running time.
In the GitHub Action on this PR, sql - Slow job has the moved Orc suites.

https://github.com/dongjoon-hyun/spark/actions/runs/3954897026/jobs/6774120406#step:9:22883

cc @HyukjinKwon

SQL tests passed and the image building job is irrelevant to this PR.

I re-triggered the irrelevantly failed GitHub Action jobs.

Merged to master.

Thank you, @HyukjinKwon !


feat(fabric): switch to maps for view rows

The #view_row{} record that is used for capturing messages with row data is not flexible enough to have it extended easily.  If one wanted to introduce a fresh field, the change would have to be propagated through many functions and modules.  Especially, if support for mixed-version clusters is a concern, this would come with some degree of duplication.
Leverage Erlang/OTP's built-in maps for mitigating this issue and offer the view callbacks the view_row_map Boolean key in #mrargs.extra to request this communication format.  This way the old record-based format would be still in use unless requested otherwise.  This facilitates the smooth interoperability of old coordinators and new workers.  In parallel to that, the new coordinator could still receive view rows from old workers.
Testing recommendations
The unit and integration tests should cover all the changes.  There are no user-facing changes, it is internal to the communication of the coordinator and the workers over fabric.  Backwards compatibility is maintained.
make eunit apps=fabric,couch_replicator,mango
make elixir
make elixir-search
make mango-test

Unit test coverage improvements:

couch_replicator: 85% ⟶ 86%
fabric: 70% ⟶ 78%

Related Issues or Pull Requests
This is to set the stage for #4958.
Checklist

[x] Code is written and works correctly
[x] Changes are covered by tests

That looked a lot smaller than expected! Well done. Just few minor suggestions and cleanup as review comments.
I noticed you opted to not use the {view_row, #{}} shape, like in the original PR and just went straight for a map as a row. That's probably simpler. I guess I could see it work either way.  Let's keep it as a simple map for now.

I'd prefer the {view_row, #{}} approach myself, it will help us clearly lay out clauses in receive code in future, unless we will also add some guaranteed key/value in the bare map?

I'd prefer the {view_row, #{}} approach myself, it will help us clearly lay out clauses in receive code in future, unless we will also add some guaranteed key/value in the bare map?

Thinking about it some more, I agree as well. It will make the receive clauses a bit clearer.
Another suggestion to investigate if it would make sense to make a separate fabric_row accessor module. So that row get/set, record/proplist/maps transform could be handled there, maybe even some merge/compare functions?

I have no strong feelings against using the view_row tag for the maps.  I removed it because I felt the code simpler but I would not say it is future-proof that way.  Also, at the same time, I could explore the fabric_row access module, it seems like a good vehicle of encapsulation.

For the record, the current version works fine in a mixed-version environment, in old coordinator—new worker, new coordinator—old worker configurations.  This was tested with a database of 100K documents, 3 nodes, with 1 coordinator and 2 workers of the respective versions, for 7 minutes on 2 threads.  I used _find queries and I am not sure how to exercise the replicator for example.

Since we're eventually trying to report the work done by a worker up until the row it emitted, would it make sense to have the completed messages return the extra metadata object/stats object as well, if the view_row_map if flag is set?

I am not sure about that.
Originally, the problem what this PR wants to solve is about the case when streaming of view rows is "abruptly" terminated in response to the stop in the callback (as a short circuit).  The proposed {complete, #{}} reply would be sent when the callback is receives complete.  But this means that everything that the worker wanted to stream has reached the destination by that time, assuming that no messages were lost in transit.
On the other hand, the change focuses on making the structure of the view rows more flexible, and it does not know anything about how this is utilized.  It is not necessarily the statistics that could be sent along the streamed rows but anything that the view callback may consider meaningful.
If statistics is sent along with the standard view row data, I think there is no need to return a closing message with metadata.  Statistical information could be sent as either deltas or absolute values, this is subject to the implementation of the given view.  They are both sufficient to keep track of statistics about the view rows.  I have tested this in the Mango rolling execution statistics PR (one of the future consumers of this change) and it worked without the need for extending the complete messages.
That said, I do not see any explicit need for this.  But it could be added later on, if any related use case surfaces.

Originally, the problem what this PR wants to solve is about the case when streaming of view rows is "abruptly" terminated in response to the stop in the callback (as a short circuit). The proposed {complete, #{}} reply would be sent when the callback is receives complete. But this means that everything that the worker wanted to stream has reached the destination by that time, assuming that no messages were lost in transit.

The stop callback would normally be called when limit number of rows had been emitted by the coordinator to the client. With the new code we'd get the extra stats map to account for the work the worker did prior to emitting that row. However, the streaming may also end if we reach the end of the btree. Then, instead of a row we'd emit a complete message. The idea is to account for the work done since we emit the last row, until the complete message. Thinking of a selective filter that pics maybe every 200th row, with a total of 500 rows: if we emit row 400, we'd keep scanning until we reach 500 and emit a complete message, but then we'd wouldn't account for work done while scanning rows 400->500.
Now we emit a separate execution stats message and a callback message https://github.com/apache/couchdb/blob/5c6aeabb3c35ec326714fa830caa635e896389e3/src/mango/src/mango_cursor_view.erl#L419-L422, which is fine but since we're making these messages flexible and able to carry any metadata, if it would make sense let the complete message also carry the extra metadata.  That way we wouldn't have to send separate execution_stats message at all, complete and view rows extra field would have a place to send back stats as well.
However, updating all the message handlers which complete to check the option and also handle {complete, #{}} might be kind of cumbersome, since there are quite a few of them. However we already have a place where we need it and it already returns an extra Props object:
https://github.com/apache/couchdb/blob/5c6aeabb3c35ec326714fa830caa635e896389e3/src/fabric/src/fabric_view_changes.erl#L288-L291

the streaming may also end if we reach the end of the btree. Then, instead of a row we'd emit a complete message.

I would not call those cases "abruptly terminated" because there is a chance to gracefully send out all the required messages.  The easy extension of view rows is a future-proof alternative to creating a another view_row record structure with the missing field (which is the execution stats in the Mango PR) each time.  This level of atomicity is required to protect the worker from failing to communicate its metadata before the stream is closed.  When no view row was streamed, the metadata reaches the coordinator, tight coupling is not a concern.
Yes, this leaves us with separate execution_stats messages, but this is just refactor it does not add much to either the correctness or the performance.  Ideally, I would keep this separation, because it is more compositional but deemed to be less performant.  Stitching a map to the complete message does not do much more in my understanding.

However, updating all the message handlers which complete to check the option and also handle {complete, #{}} might be kind of cumbersome, since there are quite a few of them.

That is one of reasons why I am rather hesitant to take on this advice.

However we already have a place where we need it and it already returns an extra Props object:
https://github.com/apache/couchdb/blob/5c6aeabb3c35ec326714fa830caa635e896389e3/src/fabric/src/fabric_view_changes.erl#L288-L291

I would say this is out of scope of this PR.  I assume this part of the code does not have any consistency or performance issues, introducing extended complete messages would only simplify the code.  Which is nice, but it would leave it for another PR.

I would not call those cases "abruptly terminated" because there is a chance to gracefully send out all the required messages.

Yeah definitely. In fact, I am not sure if "abruptly terminated" exactly applies here in general. That part works like that by design. In the majority of cases, the complete message won't be sent unless scanning is towards the end of the shard for all_docs or it's a short index key range. So the "abrupt" case might be more common in non-test sized databases.

Yes, this leaves us with separate execution_stats messages, but this is just refactor it does not add much to either the correctness or the performance

Exactly. That would be more of a nice-to-have to make things more consistent. And since when we do that refactor later we'd need to introduce another extras option, I thought we could piggy back on this PR, but that does look a large change and so let's not bother with it currently.
Also in theory I think it could affect correctness. We are handling and processing execution stats messages out of band without going through the merge row semantics. Notice, we call the Callback right away https://github.com/apache/couchdb/blob/5c6aeabb3c35ec326714fa830caa635e896389e3/src/fabric/src/fabric_view_all_docs.erl#L272 unlike a view row, which goes through the merge_row + maybe_send_row mechanism https://github.com/apache/couchdb/blob/5c6aeabb3c35ec326714fa830caa635e896389e3/src/fabric/src/fabric_view_all_docs.erl#L263-L266 so, we may be be accounting the stats for row or complete messages which never participated in the generation of the response row. [1] The chances there are small not also not worth bothering about probably.

That is one of reasons why I am rather hesitant to take on this advice.

Yup, agree, let's not worry about in the PR.
[1] This is according to our new semantics as discussed in the previous PR, that we want to account exactly for work which happened on each worker, prior to its emitted row if that row was included as part of the response, as opposed to having a probabilistic kind of a thing where we account for the approximate work as I suggested initially.

Mind we are switching to the discussion of the Mango rolling execution statistics here, which is only a possible application. Note that the execution_stats message is only used by Mango, but for some reason, it had to be driven through (woven into, pun intended) Fabric.

It is related to correctness that's why I mentioned the other pr. I was just pointing out that based on the discussion in the previous pr, and new semantics of how on the coordinator we want to account only for rows which participate in emitting the response to the user. With that view, having separate messages vs one message can lead to unexpected behavior. Because it may be possible for another worker to insert their message in between the two messages when streaming is about to conclude. In general, there could be a good amount of difference between the work done prior to emitting each row sent to the client, and all the work done by each worker.

but for some reason, it had to be driven through (woven into, pun intended) Fabric.

This is a side-effect of mango using fabric all_docs and view query as a layer. That extra handling of execution stats in all_docs and view query was another impetus for having a generic completion metadata. Though that would also require a bit more work to make sure it passes through the merge sort mechanism.

Right.  But is this a real problem here?  The folding of Mango execution statistics hinges upon addition, which is a commutative and non-associative operation, which even lends itself to parallelization.  The collection of the pieces happen locally without any interaction between the workers.  Probably I am missing something here.

It is if we want make any correctness guarantees. It doesn't have as much to do with commutativity and non-associativity of operations but which statistics should contribute to the result. We agreed to two things as far I recall:

We liked Bob's idea of counting only contributing workers 2) based on your comment, not allowing uncertainty

@nickva I am afraid we cannot allow any uncertainty in the statistics if downstream consumers wanted to build uses cases on top of this mechanism that involves billing.

And pointing out that having separate interleaved stats messages based on random arrival order from worker seems to conflict with the correctness goal. Towards the conclusion of request we could end up accounting for stats messages out-of-band so to speak, workers which did work that didn't end up contributing to the final response. However, as we discussed, the chance of this is probably low and maybe not worth worrying about. I am merely clarifying that it does impact correctness.

But is this a real problem here?
It is if we want make any correctness guarantees. It doesn't have as much to do with commutativity and non-associativity of operations but which statistics should contribute to the result.

Ah, now I got it!  Thanks for your patience in explaining this to me.  I was sure that I am missing something and I was confused that the comments about #4958 got included in this discussion.  Please let me think about those in the scope of #4958 and leave them out from this PR.

I noticed this CI failure in a full CI run. It seems to be in the test code in the replicator:
[2024-03-15T00:36:32.126Z]   couch_replicator_scheduler_docs_tests:70: scheduler_docs_test_prefixed_db_test_ (t_scheduler_docs_total_rows)...test/eunit/couch_replicator_scheduler_docs_tests.erl:137:<0.27855.0>: Error = <<"unknown_error">>
[2024-03-15T00:36:32.126Z] test/eunit/couch_replicator_scheduler_docs_tests.erl:138:<0.27855.0>: binary_to_list ( Reason ) = "function_clause"
[2024-03-15T00:36:32.126Z] *failed*
[2024-03-15T00:36:32.126Z] in function erlang:map_get/2
[2024-03-15T00:36:32.126Z]   called as map_get(<<"docs">>,"function_clause")
[2024-03-15T00:36:32.126Z] in call from couch_replicator_scheduler_docs_tests:t_scheduler_docs_total_rows/1 (test/eunit/couch_replicator_scheduler_docs_tests.erl, line 147)
[2024-03-15T00:36:32.126Z] in call from eunit_test:run_testfun/1 (eunit_test.erl, line 71)
[2024-03-15T00:36:32.126Z] in call from eunit_proc:run_test/1 (eunit_proc.erl, line 531)
[2024-03-15T00:36:32.126Z] in call from eunit_proc:with_timeout/3 (eunit_proc.erl, line 356)
[2024-03-15T00:36:32.126Z] in call from eunit_proc:handle_test/2 (eunit_proc.erl, line 514)
[2024-03-15T00:36:32.126Z] in call from eunit_proc:tests_inorder/3 (eunit_proc.erl, line 456)
[2024-03-15T00:36:32.126Z] in call from eunit_proc:with_timeout/3 (eunit_proc.erl, line 346)
[2024-03-15T00:36:32.126Z] **error:{badmap,"function_clause"}
[2024-03-15T00:36:32.126Z]   output:<<"">>

I noticed this CI failure in a full CI run. It seems to be in the test code in the replicator

Oh, the good old CentOS 8.  I will check on it later.

It might be just exposing a flaky test. I'll re-run the CI and we'll see if we get the same error on the same os/arch combination.
The difference from the previous case was that we used to wait longer if we didn't get the expected docs so it could get the error then take longer to possibly fix itself during the 10-15 second wait. Currently however, we exist on first error, but then the rest of the code expects a docs to be there.

I was trying to reproduce this locally (with the CouchDB CI CentOS 8 container) but I could not.  Hence it seems to be a flaky case.  But I think there is an error in the code that tries to provide debug information: it is not prepared for one (or more) of possible outcomes and it breaks when it happens.

Indeed it seems to be a flaky test. After re-running the CI I got the same failure on ubuntu 22.04 https://ci-couchdb.apache.org/blue/organizations/jenkins/jenkins-cm1%2FFullPlatformMatrix/detail/main/1042/pipeline/233
I wonder if it's worth reverting the behavior to let it keep retrying until it's getting an actual doc, or did it always timeout and and crash when testing the PR even with the current time.

I am now trying to add more debugging around this unknown_error to see if it can reveal a scenario when the function actually crashes.  Therefore we could ideally fix the root cause.

Based on its shape there is a chance it's coming from a remote worker node, so it's an error that serialized and sent back as a string.

Opened #5006 for investigation.


News feed summary item image

What's this PR do?
Oval static images for the news feed summary items are added and displayed. They're added twice here because for whatever reason it seemed like I needed them in both of the places to get the images to show up in both a dev environment where the local Node server is running and a release environment where everything gets bundled up.
¯\(ツ)/¯ I could totally be doing something wrong here. If you have a chance to test out building this branch yourself, that'd be helpful.
Where should the reviewer start?
Two particular things to highlight:

I wrap the images in a View container in order to vertically center it for what would just be a single line of text. Otherwise its center would differ depending on how many lines of text there were.
The height of that container is set to 21.5 which I got based off of what I saw in Inspector. More ¯\(ツ)/¯. I at least checked on both iPhone 5 and 6s Plus simulators to make sure it looked the same.

Font sizes and font color changes just based on what I saw in the Sketch file.

What are the relevant tickets?
Closes #741

You had to add the images into the ReactComponent too because we weren't bundling the assets in that curl command I was manually running. Pulled this down, rebased with develop after merging #765, and removed the duplicate set of images. Thanks for rocking this one @uy !

Ah, awesome. Thanks


can you please ensure these steps are correct?

https://github.com/Cloud-V/Fault/blob/75dd9eafb5c5f05c1c34f3636a571875de1fa191/Dockerfile#L26

Duplicate of #9.


Add highlight on current search term

Currently there is no visual indicator showing which search term is selected.
I am expecting something like this:

I tried to do that myself as I saw Issue #26
I merged the commit feat: add SearchBoxMatchCurrent by @romgrk to current main, but it doesn't work fully as when changing current match, as you can see in the same image I am currently on match 2 or 3 but the highlight is on match 7.
If you don't have time right now, you can guide me on where to look on the code base (for changing the current match) so I can try to add it myself.

I've implemented this in c255af5. Update the plugin and let me know if it works.

I found something interesting that might help you.
When I open nvim for the first time the search works as intended, but then when I do the search for the second time the search works as shown previously
https://github.com/user-attachments/assets/c5e84574-597a-43c0-b43e-aa7d9e1ffaba

Are you using <Tab> to navigate or the default control + l?

Yes, now everything works. Thank you.
I only have one question left as I am new to nvim.
Why doesn't the  or  mapping work?
I don't need a full answer if it is long, a link to wiki or article will be enough.

nvim_input() is a non-blocking function that puts your key in a queue. My guess is that makes the order of execution unpredictable, specially if you press it very quickly. Executing the <Plug> keymap is a blocking process, things start happening right away.


Creating new campaign as MX admin does not set the source language to MX Spanish

Reproduced this on Thor & Staging.
Create a new MX admin user, role = mx admin, lang = mx spanish
Create a new campaign
In an admin account, edit that campaign and go to the translate tab. The source language is english. Should be mx.

@mikefantini would you say this is high priority?

@deadlybutter is this happening in thor or just on prod?

Reproduced it on thor & staging, I can try prod as well if you want?

no i just wanted to see if it was happening on thor. thanks

related / being solved here: https://github.com/DoSomething/phoenix/issues/5198

fixed with #5317


Logic flaw in the chapter progress bar

Steps to reproduce

Inject this js  (copy, paste)

chapter = document.querySelector('chapter');
chapter.innerText = chapter.outerHTML

Go to a chapter and open it
Move chapter progress using the chapter progress bar

Another way to show the logic flaw if you:

Empty your css
Set font size to 15 using Lnreader related setting
Go to a chapter, scroll until 50% read progress and exit it
Set font size to 30 using Lnreader related setting
Go to the chapter previously menzioned and watch the resumed read progress. It will be roughly 15%

Expected behavior
Precise movement with the progress bar when used to move in the chapter without "after-click-displacement"
Actual behavior
https://github.com/LNReader/lnreader/assets/75091899/b0179035-875e-4484-b931-083277f68e2c

If I try to go to 50% the bar will show 65% so it is not precise
Sometimes when clicked on, it will not "teleport" to the progress indicated remaining unmoving (for example click on 70% zone but remaining on the bottom of the chapter)

LNReader version
1.1.18
Android version
Android 8
Device
Huawei p8 lite 2017
Other details
I am not sure why. Might be the fact that the content is the same but the space occupied by the paragraphs is not actually displayed.
I guess it is because the chapter progress logic is not actually saved as a %.
In any case the chapter height scrollable doesnt match the chapter progress showed.
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] If this is an issue with a source, I should be opening an issue in the sources repository.
[X] I have updated the app to version 1.1.18.
[X] I will fill out all of the requested information in this form.

Can you guide me on customizing the reader with CSS? I'm encountering a novel where the "?" symbol appears randomly in the text.

Fixed in beta


Test for addDrive in container.go

This needs to be merged after #325

Yay for new tests! \o/ :smile:
But I don't see why this cannot be part of #325 itself? That new code and these tests for it in my mind are a "logical unit". If that makes #325 a big change, so be it.
In my mind it sense to land the feature + the code at the same time. Otherwise, there is still a window when you have untested code in master.

Semaphore failing here because OBS package got kernel cannot be downloaded. Need to rerun until OBS is up or https://github.com/clearcontainers/tests/pull/514 is merged.

Coverage increased (+1.08%) to 66.072% when pulling 9a190fa335cf8df5c58781a09b4e67dae8fd0549 on amshinde:test-for-add-drive into c5059478633b26f528affeefaa95ef3b8b4528d3 on containers:master.

@jodh-intel @sameo Can you take a look at this?

LGTM


Only enable backdrop tap event as needed

Noticed a couple missing documentation items that I fixed (I'm open to better wording on those).
But the main point of this PR is:

document that backdropTapGestureEnabled is an option for Drawer
only add the tap event to the backdrop as needed

The reason for this is if you have enableGlobalTapAnimations set to true in your NativeScript project, it animates anything with a tap event. This can cause unexpected weirdness with the backdrop. For example, I want to scale down and change the opacity on touch. The scaling especially doesn't work with the backdrop:
.

@coltonwood thanks for this! Just about the readme like the changes but in fact the readme.MD is auto generated from this file https://github.com/nativescript-community/ui-drawer/blob/master/packages/ui-drawer/blueprint.md. do you think you can apply the changes there ?
Thanks

@farfromrefug I know this was just merged, but I just had another thought...
I think my change makes sense and should still be added to the plugin. But I also think that we should add the ignoreTouchAnimation property to the Drawer component itself. This way, even if you enable a global touch animation, it won't affect the backdrop being touched.
My fix only fixes this if you disable backdrop touches altogether. (works for my use case, but not all use cases)
Thoughts?

@coltonwood indeed could be added. Wonder if we already can do that from N. Not sure as I never use those touch animation.


requirements.txt

Will you PLEASE put your requirements.txt on the src folder or root folder?


[BUG] pip install requirement ends with error

Hello
I am on Win 11, AMD ryzen CPU, RTX3070, 16GB
When I run  pip install -r requirements.txt, I got those errors:

Collecting playsound==1.3.0 (from -r requirements.txt (line 9))
  Using cached playsound-1.3.0.tar.gz (7.7 kB)
  Getting requirements to build wheel ... error
  error: subprocess-exited-with-error

  × Getting requirements to build wheel did not run successfully.
  │ exit code: 1
  ╰─> [28 lines of output]
      Traceback (most recent call last):
        File "C:\Program Files\WindowsApps\PythonSoftwareFoundation.Python.3.11_3.11.2288.0_x64__qbz5n2kfra8p0\Lib\site-packages\pip\_vendor\pyproject_hooks\_in_process\_in_process.py", line 353, in <module>
          main()
        File "C:\Program Files\WindowsApps\PythonSoftwareFoundation.Python.3.11_3.11.2288.0_x64__qbz5n2kfra8p0\Lib\site-packages\pip\_vendor\pyproject_hooks\_in_process\_in_process.py", line 335, in main
          json_out['return_val'] = hook(**hook_input['kwargs'])
                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        File "C:\Program Files\WindowsApps\PythonSoftwareFoundation.Python.3.11_3.11.2288.0_x64__qbz5n2kfra8p0\Lib\site-packages\pip\_vendor\pyproject_hooks\_in_process\_in_process.py", line 118, in get_requires_for_build_wheel
          return hook(config_settings)
                 ^^^^^^^^^^^^^^^^^^^^^
        File "C:\Users\3950X\AppData\Local\Temp\pip-build-env-6siigbzw\overlay\Lib\site-packages\setuptools\build_meta.py", line 325, in get_requires_for_build_wheel
          return self._get_build_requires(config_settings, requirements=['wheel'])
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        File "C:\Users\3950X\AppData\Local\Temp\pip-build-env-6siigbzw\overlay\Lib\site-packages\setuptools\build_meta.py", line 295, in _get_build_requires
          self.run_setup()
        File "C:\Users\3950X\AppData\Local\Temp\pip-build-env-6siigbzw\overlay\Lib\site-packages\setuptools\build_meta.py", line 480, in run_setup
          super(_BuildMetaLegacyBackend, self).run_setup(setup_script=setup_script)
        File "C:\Users\3950X\AppData\Local\Temp\pip-build-env-6siigbzw\overlay\Lib\site-packages\setuptools\build_meta.py", line 311, in run_setup
          exec(code, locals())
        File "<string>", line 6, in <module>
        File "C:\Program Files\WindowsApps\PythonSoftwareFoundation.Python.3.11_3.11.2288.0_x64__qbz5n2kfra8p0\Lib\inspect.py", line 1262, in getsource
          lines, lnum = getsourcelines(object)
                        ^^^^^^^^^^^^^^^^^^^^^^
        File "C:\Program Files\WindowsApps\PythonSoftwareFoundation.Python.3.11_3.11.2288.0_x64__qbz5n2kfra8p0\Lib\inspect.py", line 1244, in getsourcelines
          lines, lnum = findsource(object)
                        ^^^^^^^^^^^^^^^^^^
        File "C:\Program Files\WindowsApps\PythonSoftwareFoundation.Python.3.11_3.11.2288.0_x64__qbz5n2kfra8p0\Lib\inspect.py", line 1081, in findsource
          raise OSError('could not get source code')
      OSError: could not get source code
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
error: subprocess-exited-with-error

× Getting requirements to build wheel did not run successfully.
│ exit code: 1
╰─> See above for output.

note: This error originates from a subprocess, and is likely not a problem with pip.

Could you help please ?

tout take a look at this link (link) mentioned in #3, this helped fix this for me

@pmavro thanks. It starts now

happy to help!

@toutjavascript @petmav I tried both the commands mentioned in PR, but still the error persists. Here is the log I got
Collecting g4f (from -r requirements.txt (line 1))
  Using cached g4f-<IP_ADDRESS>-py3-none-any.whl.metadata (56 kB)
Requirement already satisfied: setuptools in c:\users\batman\appdata\local\programs\python\python310\lib\site-packages (from -r requirements.txt (line 2)) (75.6.0)
Requirement already satisfied: wheel in c:\users\batman\appdata\local\programs\python\python310\lib\site-packages (from -r requirements.txt (line 3)) (0.45.1)
Collecting requests==2.31.0 (from -r requirements.txt (line 4))
  Using cached requests-2.31.0-py3-none-any.whl.metadata (4.6 kB)
Collecting moviepy==1.0.3 (from -r requirements.txt (line 5))
  Using cached moviepy-1.0.3.tar.gz (388 kB)
  Preparing metadata (setup.py) ... error
  error: subprocess-exited-with-error

  × python setup.py egg_info did not run successfully.
  │ exit code: 1
  ╰─> [56 lines of output]
      C:\Users\batman\AppData\Local\Temp\pip-install-y7vihu3o\moviepy_1976968ad9204357ba6b8df38cfccb82\setup.py:10: SetuptoolsDeprecationWarning: The test command is disabled and references to it are deprecated.
      !!

              ********************************************************************************
              Please remove any references to `setuptools.command.test` in all supported versions of the affected package.

              This deprecation is overdue, please update your project and remove deprecated
              calls to avoid build errors in the future.
              ********************************************************************************

      !!
        from setuptools.command.test import test as TestCommand
      C:\Users\batman\AppData\Local\Programs\Python\Python310\lib\site-packages\setuptools\_distutils\dist.py:261: UserWarning: Unknown distribution option: 'tests_require'
        warnings.warn(msg)
      running egg_info
      creating C:\Users\batman\AppData\Local\Temp\pip-pip-egg-info-696svg7z\moviepy.egg-info
      writing C:\Users\batman\AppData\Local\Temp\pip-pip-egg-info-696svg7z\moviepy.egg-info\PKG-INFO
      writing dependency_links to C:\Users\batman\AppData\Local\Temp\pip-pip-egg-info-696svg7z\moviepy.egg-info\dependency_links.txt
      writing requirements to C:\Users\batman\AppData\Local\Temp\pip-pip-egg-info-696svg7z\moviepy.egg-info\requires.txt
      writing top-level names to C:\Users\batman\AppData\Local\Temp\pip-pip-egg-info-696svg7z\moviepy.egg-info\top_level.txt
      writing manifest file 'C:\Users\batman\AppData\Local\Temp\pip-pip-egg-info-696svg7z\moviepy.egg-info\SOURCES.txt'
      reading manifest file 'C:\Users\batman\AppData\Local\Temp\pip-pip-egg-info-696svg7z\moviepy.egg-info\SOURCES.txt'
      reading manifest template 'MANIFEST.in'
      adding license file 'LICENCE.txt'
      Traceback (most recent call last):
        File "<string>", line 2, in <module>
        File "<pip-setuptools-caller>", line 34, in <module>
        File "C:\Users\batman\AppData\Local\Temp\pip-install-y7vihu3o\moviepy_1976968ad9204357ba6b8df38cfccb82\setup.py", line 110, in <module>
          setup(
        File "C:\Users\batman\AppData\Local\Programs\Python\Python310\lib\site-packages\setuptools\__init__.py", line 117, in setup
          return distutils.core.setup(**attrs)
        File "C:\Users\batman\AppData\Local\Programs\Python\Python310\lib\site-packages\setuptools\_distutils\core.py", line 183, in setup
          return run_commands(dist)
        File "C:\Users\batman\AppData\Local\Programs\Python\Python310\lib\site-packages\setuptools\_distutils\core.py", line 199, in run_commands
          dist.run_commands()
        File "C:\Users\batman\AppData\Local\Programs\Python\Python310\lib\site-packages\setuptools\_distutils\dist.py", line 954, in run_commands
          self.run_command(cmd)
        File "C:\Users\batman\AppData\Local\Programs\Python\Python310\lib\site-packages\setuptools\dist.py", line 995, in run_command
          super().run_command(command)
        File "C:\Users\batman\AppData\Local\Programs\Python\Python310\lib\site-packages\setuptools\_distutils\dist.py", line 973, in run_command
          cmd_obj.run()
        File "C:\Users\batman\AppData\Local\Programs\Python\Python310\lib\site-packages\setuptools\command\egg_info.py", line 313, in run
          self.find_sources()
        File "C:\Users\batman\AppData\Local\Programs\Python\Python310\lib\site-packages\setuptools\command\egg_info.py", line 321, in find_sources
          mm.run()
        File "C:\Users\batman\AppData\Local\Programs\Python\Python310\lib\site-packages\setuptools\command\egg_info.py", line 549, in run
          self.prune_file_list()
        File "C:\Users\batman\AppData\Local\Programs\Python\Python310\lib\site-packages\setuptools\command\sdist.py", line 162, in prune_file_list
          super().prune_file_list()
        File "C:\Users\batman\AppData\Local\Programs\Python\Python310\lib\site-packages\setuptools\_distutils\command\sdist.py", line 380, in prune_file_list
          base_dir = self.distribution.get_fullname()
        File "C:\Users\batman\AppData\Local\Programs\Python\Python310\lib\site-packages\setuptools\_core_metadata.py", line 267, in get_fullname
          return _distribution_fullname(self.get_name(), self.get_version())
        File "C:\Users\batman\AppData\Local\Programs\Python\Python310\lib\site-packages\setuptools\_core_metadata.py", line 285, in _distribution_fullname
          canonicalize_version(version, strip_trailing_zero=False),
      TypeError: canonicalize_version() got an unexpected keyword argument 'strip_trailing_zero'
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
error: metadata-generation-failed

× Encountered error while generating package metadata.
╰─> See above for output.

note: This is an issue with the package mentioned above, not pip.
hint: See above for details.


FlexibleEngine plugin - implement, start, stop and restart services

Fixed #1105

@WangLiNaruto can you please confirm if the requests wait until the servers are fully stopped/started/restarted?


Update/wifi config corrections

@shaunmulligan this looks fine to me, Okay to merge or we waiting on something?


Make the binaries contain the commit version

Signed-off-by: zhujian<EMAIL_ADDRESS>
What this PR does / why we need it:
After this commit is merged, we can use command -v to get the commit id. for example:
╰─$ hypershift -v
hypershift version v0.0.0-unknown-ce94c8cd

BTW, the makefile will use v[0-9]* to match tags, but all tags created in the hypershift repo are all in format x.y.z, so  I propose if it is possible please create tags in the format of vx.y.z.
Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #
Checklist

[x] Subject and description added to both, commit and PR.
[ ] Relevant issues have been referenced.
[ ] This change includes docs.
[ ] This change includes unit tests.

Now it looks like:
╰─$ make build
CGO_ENABLED=0 GO111MODULE=on GOFLAGS=-mod=vendor go build -gcflags=all='-N -l' -o bin/hypershift-operator ./hypershift-operator
CGO_ENABLED=0 GO111MODULE=on GOFLAGS=-mod=vendor go build -gcflags=all='-N -l' -o bin/control-plane-operator ./control-plane-operator
CGO_ENABLED=0 GO111MODULE=on GOFLAGS=-mod=vendor go build -gcflags=all='-N -l' -o bin/hypershift .

╰─$ ./bin/hypershift-operator -v
hypershift-operator version b1247978522cdb047d8779038f7f60107fc851f9
╰─$ ./bin/hypershift -v
hypershift version b1247978522cdb047d8779038f7f60107fc851f9
╰─$ ./bin/control-plane-operator -v
control-plane-operator version b1247978522cdb047d8779038f7f60107fc851f9

/test e2e-aws-nested

there's two commits with the same message "Make the binaries contain the commit version", can we please squash them?

BTW, the makefile will use v[0-9]* to match tags, but all tags created in the hypershift repo are all in format x.y.z, so I propose if it is possible please create tags in the format of vx.y.z.

Is this still relevant, can we update the PR desc?

I'm curious what's the use case that drove you to put this PR @zhujian7?

I'm curious what's the use case that drove you to put this PR @zhujian7?

Hi @enxebre, thanks for the review. I am a developer from ACM, now for our upstream build we use the latest hypershift binary to install hypershift operator, and I want to know the commit sha of the hypershift binary.

After reconsidering, I think it needs to be careful to make compiling hypershift requires golang 1.18 for this feature, for example ACM still uses golang 1.17, so I want to HOLD the PR. (Sorry @alvaroaleman.)
But if you still think the feature is useful and consider accepting the first version of the implementation (without relying on golang 1.18), I'll be very happy to continue working on it. Thanks.
/hold

for example ACM still uses golang 1.17

We don't have any testing that uses go 1.17, so if go 1.17 works or doesn't is a matter of luck. This needs to be fixed by ACM.

We don't have any testing that uses go 1.17, so if go 1.17 works or doesn't is a matter of luck. This needs to be fixed by ACM.

Thanks @alvaroaleman, good to know. Currently we build it with go 1.17 and it works fine, but you are right, we will try to fix it by ACM

@alvaroaleman @enxebre golang version problem fixed in ACM, commit message and PR description updated, PTAL.
/hold cancel


Change 4b094c2 breaks example app's build

Change 4b094c2 (Extracted parameters from ChatItemDecorationAttributes related to BaseMessageDecorationAttributes). introduces  new data struct BaseMessageDecorationAttributes, and example app's source is updated to utilize it. Yet this happened after 3.2.0.,  so Carthage build, which pulls 3.2.0 automatically, would fail to recognize this data structure, causing build failure
We should either bump up 3.2.0 version, or do some other remedy to make the example app work again. (MAGA, lol).

I see. Unfortunately, I can't bump version yet. It will be done in the next weeks. We have to do some tasks before releasing a new version that supports Swift 4.
Until then you can use "master" branch in Cartfile.


The OAP8.1 configuration SW_TRACE_SAMPLE_RATE does not take effect

Please answer these questions before submitting your issue.

Why do you submit this issue?
[x] Question or discussion
[ ] Bug
[ ] Requirement
[ ] Feature or performance improvement

Question

What do you want to know?
SW_TRACE_SAMPLE_RATE is configured as 1, but the segment data in ES is reduced

Bug

Which version of SkyWalking, OS and JRE?

Which company or project?

What happened?
If possible, provide a way to reproduce the error. e.g. demo application, component version.

Requirement or improvement

Please describe your requirements or improvement suggestions.

Why shouldn't? We never said 1 == 100% sampling.

It's true, it's not the same as when I used 6.6. There is also a way to dynamically configure the sampling rate, I can't find the documentation.

I don't know what is the difference, I don't remember anyone changed this. The dynamic configuration document is in the backend setup. If I remember correctly, the sampling rate could be changed in the next release or master.

skywalking版本：v6.0.0-GA
参考文档：https://github.com/apache/skywalking/blob/6.x/docs/en/setup/backend/trace-sampling.md
按照官方设置的服务端trace信息的采样率为5000，数据量未降下来
修改的配置文件名：apache-skywalking-apm-incubating-bin/config/application.yml
配置信息如下：
# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements.  See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership.  The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
# "License"); you may not use this file except in compliance
# with the License.  You may obtain a copy of the License at
#
#     http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

cluster:
  standalone:
  # Please check your ZooKeeper is 3.5+, However, it is also compatible with ZooKeeper 3.4.x. Replace the ZooKeeper 3.5+
  # library the oap-libs folder with your ZooKeeper 3.4.x library.
#  zookeeper:
#    nameSpace: ${SW_NAMESPACE:""}
#    hostPort: ${SW_CLUSTER_ZK_HOST_PORT:localhost:2181}
#    #Retry Policy
#    baseSleepTimeMs: ${SW_CLUSTER_ZK_SLEEP_TIME:1000} # initial amount of time to wait between retries
#    maxRetries: ${SW_CLUSTER_ZK_MAX_RETRIES:3} # max number of times to retry
#  kubernetes:
#    watchTimeoutSeconds: ${SW_CLUSTER_K8S_WATCH_TIMEOUT:60}
#    namespace: ${SW_CLUSTER_K8S_NAMESPACE:default}
#    labelSelector: ${SW_CLUSTER_K8S_LABEL:app=collector,release=skywalking}
#    uidEnvName: ${SW_CLUSTER_K8S_UID:SKYWALKING_COLLECTOR_UID}
#  consul:
#    serviceName: ${SW_SERVICE_NAME:"SkyWalking_OAP_Cluster"}
#     Consul cluster nodes, example: <IP_ADDRESS>:8500,<IP_ADDRESS>:8500,<IP_ADDRESS>:8500
#    hostPort: ${SW_CLUSTER_CONSUL_HOST_PORT:localhost:8500}
core:
  default:
    # Mixed: Receive agent data, Level 1 aggregate, Level 2 aggregate
    # Receiver: Receive agent data, Level 1 aggregate
    # Aggregator: Level 2 aggregate
    role: ${SW_CORE_ROLE:Mixed} # Mixed/Receiver/Aggregator
    restHost: ${SW_CORE_REST_HOST:<IP_ADDRESS>}
    restPort: ${SW_CORE_REST_PORT:12800}
    restContextPath: ${SW_CORE_REST_CONTEXT_PATH:/}
    gRPCHost: ${SW_CORE_GRPC_HOST:<IP_ADDRESS>}
    gRPCPort: ${SW_CORE_GRPC_PORT:11800}
    downsampling:
    - Hour
    - Day
    - Month
    # Set a timeout on metric data. After the timeout has expired, the metric data will automatically be deleted.
    recordDataTTL: ${SW_CORE_RECORD_DATA_TTL:90} # Unit is minute
    minuteMetricsDataTTL: ${SW_CORE_MINUTE_METRIC_DATA_TTL:90} # Unit is minute
    hourMetricsDataTTL: ${SW_CORE_HOUR_METRIC_DATA_TTL:36} # Unit is hour
    dayMetricsDataTTL: ${SW_CORE_DAY_METRIC_DATA_TTL:45} # Unit is day
    monthMetricsDataTTL: ${SW_CORE_MONTH_METRIC_DATA_TTL:18} # Unit is month
storage:
  h2:
    driver: ${SW_STORAGE_H2_DRIVER:org.h2.jdbcx.JdbcDataSource}
    url: ${SW_STORAGE_H2_URL:jdbc:h2:mem:skywalking-oap-db}
    user: ${SW_STORAGE_H2_USER:sa}
#  elasticsearch:
#    # nameSpace: ${SW_NAMESPACE:""}
#    clusterNodes: ${SW_STORAGE_ES_CLUSTER_NODES:localhost:9200}
#    indexShardsNumber: ${SW_STORAGE_ES_INDEX_SHARDS_NUMBER:2}
#    indexReplicasNumber: ${SW_STORAGE_ES_INDEX_REPLICAS_NUMBER:0}
#    # Batch process setting, refer to https://www.elastic.co/guide/en/elasticsearch/client/java-api/5.5/java-docs-bulk-processor.html
#    bulkActions: ${SW_STORAGE_ES_BULK_ACTIONS:2000} # Execute the bulk every 2000 requests
#    bulkSize: ${SW_STORAGE_ES_BULK_SIZE:20} # flush the bulk every 20mb
#    flushInterval: ${SW_STORAGE_ES_FLUSH_INTERVAL:10} # flush the bulk every 10 seconds whatever the number of requests
#    concurrentRequests: ${SW_STORAGE_ES_CONCURRENT_REQUESTS:2} # the number of concurrent requests
#  mysql:
receiver-sharing-server:
  default:
receiver-register:
  default:
receiver-trace:
  default:
    bufferPath: ${SW_RECEIVER_BUFFER_PATH:../trace-buffer/}  # Path to trace buffer files, suggest to use absolute path
    bufferOffsetMaxFileSize: ${SW_RECEIVER_BUFFER_OFFSET_MAX_FILE_SIZE:100} # Unit is MB
    bufferDataMaxFileSize: ${SW_RECEIVER_BUFFER_DATA_MAX_FILE_SIZE:500} # Unit is MB
    bufferFileCleanWhenRestart: ${SW_RECEIVER_BUFFER_FILE_CLEAN_WHEN_RESTART:false}
    sampleRate: ${SW_TRACE_SAMPLE_RATE:5000} # The sample rate precision is 1/10000. 10000 means 100% sample in default.
    slowDBAccessThreshold: ${SW_SLOW_DB_THRESHOLD:default:200,mongodb:100} # The slow database access thresholds. Unit ms.
receiver-jvm:
  default:
service-mesh:
  default:
    bufferPath: ${SW_SERVICE_MESH_BUFFER_PATH:../mesh-buffer/}  # Path to trace buffer files, suggest to use absolute path
    bufferOffsetMaxFileSize: ${SW_SERVICE_MESH_OFFSET_MAX_FILE_SIZE:100} # Unit is MB
    bufferDataMaxFileSize: ${SW_SERVICE_MESH_BUFFER_DATA_MAX_FILE_SIZE:500} # Unit is MB
    bufferFileCleanWhenRestart: ${SW_SERVICE_MESH_BUFFER_FILE_CLEAN_WHEN_RESTART:false}
istio-telemetry:
  default:
envoy-metric:
  default:
#receiver_zipkin:
#  default:
#    host: ${SW_RECEIVER_ZIPKIN_HOST:<IP_ADDRESS>}
#    port: ${SW_RECEIVER_ZIPKIN_PORT:9411}
#    contextPath: ${SW_RECEIVER_ZIPKIN_CONTEXT_PATH:/}
query:
  graphql:
    path: ${SW_QUERY_GRAPHQL_PATH:/graphql}
alarm:
  default:
telemetry:
  none:

@MichaelWangHong All GitHub discussions must be in English. And your description doesn't match this issue at all, and your version is years ago, the community doesn't take care of it anymore.


Update Azure Service Bus docs for 1.8

What content needs to be created or modified?
Metadata options for Azure Service Bus (pubsub and binding) are changing slightly in 1.8. I need to update the docs
The associated pull request from dapr/dapr, dapr/components-contrib, or other Dapr code repos
https://github.com/dapr/components-contrib/pull/1729
https://github.com/dapr/components-contrib/pull/1702

/assign

Merged


ValueError: month must be in 1..12

Hey guy's,
I am currently trying to add holidays via an input but when running my script I get the following error:
Traceback (most recent call last):
  File "test.py", line 22, in <module>
    for date, name in sorted(addHolidays(years=year).items()):
  File "/home/user/anaconda3/lib/python3.8/site-packages/holidays/countries/germany.py", line 81, in __init__
    HolidayBase.__init__(self, **kwargs)
  File "/home/user/anaconda3/lib/python3.8/site-packages/holidays/holiday_base.py", line 37, in __init__
    self._populate(year)
  File "test.py", line 18, in _populate
    self[date(year, day_input, int(month_input))] = add_input
ValueError: month must be in 1..12

This is the code I try to run:
from datetime import date
import datetime
import holidays

add_input = input("give me the name of the holiday: ")
day_input = int(input("give me the day of the holiday: ")
month_input = int(input("give me the month: of the holiday: ")

print(add_input)

class addHolidays(holidays.DE):
    def _populate(self, year):
        holidays.DE._populate(self, year)
        self[date(year, day_input, month_input)] = add_input

print("added a new holiday successfully!")

I've also tried to input different variants of parameters. For example:
01, 02, 03, 04, 05...12 or 1,2,3,4,5...12
Is there something wrong with my code? If so I would be really glad if someone could tell me what I've made wrong and help  me solve this error:)
Thank's for every help and suggestion in advance:)

Hi, whenever creating a new date through date(...), you should set the values as here:
date(yyyy, mm, dd)
Cheers :)


Prevent extra attributes when initializing StackComponents

Describe changes
Previous to this PR, our StackComponent class allowed you to pass arbitrary parameters to its init method and silently ignores them. This could lead to unexpected behavior when accidently mistyping an attribute name when registering a component on the CLI.
Example:
zenml secrets-manager register NAME --flavor=aws --region=eu-west-1 (Note that the attribute on the AWSSecretsManager is called region_name, not region as passed in the command here).
When later running with this secrets manager, it would unexpectedly create secrets in the default region, not the one (wrongly) specified on the CLI.
After this PR, the CLI call would fail instead and let the user know that they passed a value for an attribute that doesn't exist.
Pre-requisites
Please ensure you have done the following:

[x] I have read the CONTRIBUTING.md document.
[ ] If my change requires a change to docs, I have updated the documentation accordingly.
[ ] If I have added an integration, I have updated the integrations table.
[x] I have added tests to cover my changes.

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[x] Other (add details above)

@strickvl Updated the description


Clicking trail ways opens a different trail

Clicking ways sometimes will open the OSM link for an entirely different nearby trail. I haven't been able to identify any particular rhyme or reason behind this.
Example:
Click the trail located here
Way that it opens: w600439599
Expected way: w30969582

This is a specific example, but this happens very often (maybe more often with short ways? Not sure)

@elevenchars Thanks for reporting. This is an issue with Planetiler merging adjacent ways with identical attributes. Only one ID remains, so that's the one that we're linking to. I have a pending fix for this at https://github.com/ZeLonewolf/planetiler-scripts/pull/6.

This was fixed by doing #4.

This was recently fixed. Now, not only does clicking on a path show the exact object in OSM, it includes the entity's current tags and metadata.


Issue 14 - Add Geolocation support for user's current location

Add geolocation support for user's current location
Related Issues
#14
Description
This PR related to issue #14. Within this PR, the changes included are:

If user opens the map, it will ask a permission to ask for a location
When search component in add favorite location and search for location is clicked, the user's location will appear
When users type in search component of add favorite location and search for location, the user's location will dissapear and replaced by searched locations

Media
https://github.com/OneBusAway/otpkit/assets/74521244/b417b60f-069a-43b0-b476-7d56264b98d1
Test Instructions
To test this PR, you can do the following:

Uninstall the OTPKitDemo app in your simulator
Re-run, set the simulator location. For example, here
See if location permission is asked. Grant the permission
Open any origin or destination menu
Try to tap on search component. When it's focused or tapped, the row of "My Location" should appear
Try to type on the search component, "My Location" row should dissapear

Additional Context
This PR is rebased from this PR #20. If you want to check for changes for this PR only, you should merge PR first

superseded by your new PR in #23


Sample code for using the framework

Can you please provide sample code for using the framework in an app to get facial landmarks from an image or video stream ?

@amalcty https://github.com/krishnanmuthiahpillai/DemoAppForMediaPipe

@amalcty please find sample app for mediapipe facemesh with the help of pod file.
https://github.com/krishnanmuthiahpillai/DemoAppForMediaPipe


webgl build fails after connecting to colyseus room

async void Start()
{
    Debug.Log("Creating client");
    ColyseusClient client = new ColyseusClient("ws://localhost:8000");
    Debug.Log("Connecting to room");
    room = await client.JoinOrCreate<State>("herd");
    Debug.Log("Connected to room");
}

The last log doesn't make it in the webgl build, it works fine in the editor and desktop build. These are the logs in the browser console:
Creating client

Connecting to room

<color=olive>Requesting from URL:</color>  http://localhost:8000/matchmake/joinOrCreate/herd

<color=olive>Server Response:</color>  {"room":{"clients":2,"createdAt":"2021-10-18T11:27:12.385Z","maxClients":null,"name":"herd","processId":"QIfCc1Hju","roomId":"RKRV5jchE"},"sessionId":"d9Z8g-qa0"}

ArgumentNullException: Value cannot be null.
Parameter name: source
  at System.Globalization.CompareInfo.IndexOf (System.String source, System.String value, System.Int32 startIndex, System.Int32 count, System.Globalization.CompareOptions options) [0x00000] in <00000000000000000000000000000000>:0
--- End of stack trace from previous location where exception was thrown ---
  at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw () [0x00000] in <00000000000000000000000000000000>:0

Best leads I could find so far:
https://forum.unity.com/threads/webgl-with-signalr-argumentnullexception-value-cannot-be-null.671926/