A way to solve .In(values ...driver.Valuer) with column type

Describe the feature
I'm using a type definition in column.
Which look like this:
type Subject struct {
	ID model.SubjectID `gorm:"..."`
}

and model.SubjectID is a driver.Valuer
Then in dao, I want to select with sql in, so i need to do this:
var q *query.Query
q.Subject.WithContext(ctx).Where(q.Subject.ID.In(ids...)).Find()

This method has a signature of this
// In ...
func (field Field) In(values ...driver.Valuer) Expr {
	return expr{e: clause.IN{Column: field.RawExpr(), Values: field.toSlice(values...)}}
}

which means in this case, it doesn't fit the type requirements:
func (r mysqlRepo) GetByIDs(ctx context.Context, ids ...model.SubjectID) {
	records, err := r.q.Subject.WithContext(ctx).Joins(r.q.Subject.Fields).Where(r.q.Subject.ID.In(ids...)).Find()
    ...
}

and ids has a type []model.SubjectID which doesn't work with []driver.Valuer
I know it's a problem from go type system, But I wonder if there could be a way to solve this with a new field method?

Motivation

Related Issues

If GEN provides a method to solve it, it will inevitably call package reflect's methods and will make some unnecessary complexity, so we prefer to let the user implement the method to do this type conversion, which will have better performance in terms of efficiency and stability.


Add details for all relief camps across different districts

People should be able to look up the locations of different rellief camps across the state

Same as #120


Don't use x509-validation fork

We're currently using the x509-validation fork from https://github.com/vincenthz/hs-certificate/pull/126 in order to have a pure function to do X.509 verification. However we need to upload this library to Hackage, which can't work with this. So we need to do one of these things, ordered from most to least preferred:

Get the PR merged and a new x509-validation release published by @vincenthz
Copy the pure validation code from x509-validation library into our own source code and use that instead
Make this library have its main functions be in IO

https://github.com/tweag/haskell-fido2/blob/44e89a1519b7d9a809209a3e4907daf782091650/cabal.project#L3-L10

The PR has just been merged, but we do need to do version bumb and ask for a re-upload to hackage.


Add support for wildcards for include/exclude backups

As described here, Weaviate allows for the inclusion/exclusion of classes for a specific backup, like so:
{
    "id": "my-very-first-backup",
    "exclude": ["Article"]
}

We noticed that some users are not using logical class names but use a date or numeric value to identify classes. An example:
Classes: [
    "data-20221122",
    "data-20221223",
    "data-20221224",
    "data-20221225",
    "...."
]

In this example, it would be great to extend the include/exclude functionality to use a wildcard to select all data for a specific month:
{
    "id": "my-december-backup",
    "include": ["data-202212*"]
}

Great idea. Full of optimism I've added the good-first-issue label, as I think this should be fairly easy to do, also for first-time contributors.

Hi, I am first time contributor here. Please assign me this issue.

If no one is working on this, can I work on this issue?

Is the issue still open?
Assign it to me

hi Community! We are putting a bounty on this issue! Join us!
/bounty $50

/attempt #2481

Can I be assigned? @dudanogueira

/attempt #2481
It might be a bad idea trying to guess whether users intend to use an exact match or a regular expression.So in order to distinguish the intention whether we could change include list to a list of struct:
{   "include": [       {           "expression": "foo",           "is_regex": false       }   ] }
This approach offers clarity in distinguishing between exact matches and regular expressions. However, it may increase verbosity.
or adding a new array:
{     "include_patterns": []{}     "exclude_patterns": []{} }
This alternative maintains backward compatibility with existing APIs and reduces verbosity.
The linked PR above is implementing the second option.

/attempt #2481

/attempt https://github.com/weaviate/weaviate/issues/2481

Hey @Rutik7066 - @ying-jeanne had a previous attempt and reacted to feedback. We will merge the first PR that is correct and pay the bounty only for that one.


Matching query refactor

Only return WorkflowQueryFailed if the user workflow query handler was run and returned an error. Returning this in any other place is meaningless.
Move checking for first decision complete from matching to history.
Add version check in matching for consistent query

Coverage decreased (-0.004%) to 66.579% when pulling 8a22ab5e09e55f261428ee0cc549288b0832b0e8 on andrewjdawson2016:MatchingQueryRefactor into 3a27d383a534371f08deb4de333198fb8190a539 on uber:master.


feat(dracut)!: improve size by zstd and --aggressive-strip

Need testing

I'd be interested in seeing comparisons with each option before merging


[Feature Request] [SCSS] Please add more variables to be customized in the main scss file

Existing Component
Yes
Component Name
SCSS Customization
Description
Doc:  http://element.eleme.io/#/en-US/component/custom-theme
To customize variables just in the main scss file is more fluently and maintainable than building the theme outside from the project!
Variables like:

$--select-tag-color

the default is $--color-white, and it's vary hard to see the tag text...

You'll be able to customize all variables in the next release.
By the way, $--select-tag-color is actually a mistake.


Allows the adding of metadata on the bake itself.

For some implementations this can be more optimal then doing them separate.

Codecov Report

Merging #1448 (2d73b73) into master (79b51c5) will decrease coverage by 0.12%.
The diff coverage is 44.44%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##           master    #1448      +/-   ##
==========================================
- Coverage   82.64%   82.53%   -0.12%
==========================================
  Files         130      130
  Lines        4138     4146       +8
  Branches      132      139       +7
==========================================
+ Hits         3420     3422       +2
- Misses        718      724       +6

Impacted Files
Coverage Δ

...ain/scala/com/ing/baker/runtime/model/BakerF.scala
39.35% <0.00%> (-1.32%)
:arrow_down:

...n/scala/com/ing/baker/runtime/akka/AkkaBaker.scala
79.35% <100.00%> (+0.13%)
:arrow_up:

...ing/baker/runtime/serialization/JsonDecoders.scala
89.28% <100.00%> (+0.19%)
:arrow_up:

...ing/baker/runtime/serialization/JsonEncoders.scala
100.00% <100.00%> (ø)

...om/ing/bakery/components/InteractionRegistry.scala
53.33% <0.00%> (-3.34%)
:arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Deflayer without having to redeclared whole defsrc?

 However, I don't think it would be terribly difficult to hack this into the deflayer parsing (though I guess this would be a one-way street—as soon as such an assignment is found, every key in the deflayer should be one)

Oh I see, well basically I was asking because Im trying to achieve the adaptative key/magic key/alternate repeat key/... behaviour.
Is there a built-in function for that?
Is this approach of putting layers on top to replace 1 key a good approach?
I will create an issue briefly to try to explain it better if someone else is also looking to achieve the same behaviour.

Oh I see, well basically I was asking because Im trying to achieve the adaptative key/magic key/alternate repeat key/... behaviour. Is there a built-in function for that? Is this approach of putting layers on top to replace 1 key a good approach?
I will create an issue briefly to try to explain it better if someone else is also looking to achieve the same behaviour.

#751

Closing as duplicate of https://github.com/kmonad/kmonad/issues/680


remind youtube auth

Save youtube credentials after first authentification

Thank you for your contributions

It saved email password in .json file ? is that safe ?

It saved in your local just like .env and client_secret.json

@yogeshwaran01 please explain more how this update works. I will update the readme

It just saves the credentials in Json file for first time, Next time when running the script, it loads credentials from that Json file instead of login again in web browser


All stickers are assigned 😳 by default

When adding stickers, all stickers show up as having 😳 in the emoji textbox

This is currently for testing purposes when adding large numbers of stickers, it should be removed in a future release


Intellisense shows "mousewheel" as an applicable event

From @ajbogh on April 7, 2017 7:36
mousewheel should be removed from Javascript's intellisense as it is deprecated and only supported in IE6, Chrome 1, Opera 10, Safari 3, and surprisingly IE Edge. If not removed then it should have "(deprecated)" next to it so people don't accidentally use it instead of "wheel".

VSCode Version: 1.10.2
OS Version: Ubuntu 16.10

Steps to Reproduce:

type "window.addEventListener('mouse..." and notice "mousewheel" as an available option.

https://developer.mozilla.org/en-US/docs/Web/Events/mousewheel
Copied from original issue: Microsoft/vscode#24184

I read the compatibility table as "supported by all major browsers except Firefox".

I don't see how removing this helps anyone if it's so widely supported.

The alternate choice besides removing it was to add a "(deprecated)" notice so that people don't use it instead of "wheel". I understand that perhaps it's not in the best interest to remove it completely, however there's a more standardized approach that's accepted by modern browsers.
This is only a suggestion since the same could also be said about other deprecated features and changing them all would be difficult.
https://developer.mozilla.org/en-US/docs/Web/Events/wheel

There is a definite gap in support between the set of browsers that implement the new wheelevent and those that only implement mousewheel, but what makes this interesting is that, naturally, neither event has solid mobile support 😁


panic: Wrong app version 0, upgrade handler is missing for v5.0.x

Summary of Bug

Validator crashed with the following error:

panic: Wrong app version 0, upgrade handler is missing for v5.0.x

With and without cosmovisor, same issue.
I've tried to resync from truncated dump, it was syncing to some point, then it stopped with the same error.
Version

I've tried docker tagged versions: 4.2.2 and 5.0.0, none of them work anymore.
Steps to Reproduce

For Admin Use

[ ] Not duplicate issue
[ ] Appropriate labels applied
[ ] Appropriate contributors tagged
[ ] Contributor assigned/self-assigned
[ ] Is a spike necessary to map out how the issue should be approached?

Error was a bit confusing.
Upgrade to 5.0.0 helped.


[W5.10c] [W11-A1] wang zi

added 5 user stories

@alexawangzi
Some comments added. Please ack & close the PR after reading comments.


Not Able to Retrive Full Patent Data

Describe the bug
This is not necessarily a bug, but possibly just a misunderstand with the local setup instructions.
When running locally, I get an error when running this command: curl http://localhost:8501/patents/US3930271A. Patent queries work OK. I looked in the API code and can see that the server is trying to call PatentDataRequest, but I don't receive any error messages on the server side. On the client side, I only see, "server error." I think the issue is that PQAI is probably trying to invoke get_patent_data_from_s3, but there is no data on there.
Is there a way to load the full patent data onto S3 (assuming that is where the data should be stored)?
To Reproduce

run the steps in the local deployment
call curl http://localhost:8501/patents/US3930271A on the command line.

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
N/A
Desktop (please complete the following information):
Ubuntu 22.04
Smartphone (please complete the following information):
N/A
Additional context
Same request works fine using the PQAI API + token.

@raymondcarl I am adding an option to configure a local deployment to pull full-text from the API. Should be done in this week.

Hi @mahesh-maan, this is working!


RUMM-622 Handle redirection

What does this PR do?
Make sur that redirections (Http 3xx) can be traced properly.
Motivation
Network requests are traced at the applciation level, so by default they don't show when a redirection occurs. This allows developper to have more in depth tracing of requests.
Review checklist (to be filled by reviewers)

[x] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[x] Make sure you discussed the feature or bugfix with the maintaining team in an Issue
[x] Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

Actually need to rework all this…


[1222] Add simple cov for test coverage

Context
See test coverage
Changes proposed in this pull request
Add simplecov gem and setup
Guidance to review
$ bundle exec rspec
Coverage report generated for RSpec to /Users/Dan/Git/manage-courses-frontend/coverage. 705 / 740 LOC (95.27%) covered.

 Add SimpleCov


cannot import name 'exceptions' from 'asyncio'

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:
installed with pip
do a simple import:
from socketify import App, AppOptions, OpCode, CompressOptions
and I have this error:
cannot import name 'exceptions' from 'asyncio'
I temporay removed the import from init, and the library work correctly (5x time more fast than with websockets library)
Desktop (please complete the following information):

OS: windows
Browser na
Version 0.0.20

Additional context
Add any other context about the problem here.

Which exact version of Python do you use?
I've tested on Python 3.10 and 3.11. Both of versions showed, that from asyncio import exceptions runs correctly

Due some issue compatibility with other pip in my application, I'm using python 3.7

Due some issue compatibility with other pip in my application, I'm using python 3.7

Try a more recent version of python, support for 3.7 will be dropped

Yesterday was the last day we supported python 3.7 because its become End Of Life https://github.com/cirospaciari/socketify.py/releases/tag/v0.0.22
We will try to follow the official roadmap for support, but probably focus on 3.9/3.10+ compatibility since PyPy is  Python 3.10 compatible since 2023-06-16 04:22
https://devguide.python.org/versions/


test(ngMock): fix Firefox crashes on Travis

This test keeps causing Firefox 47 (currently used on Travis) to crash and fail the build. The test passes locally (on Firefox 53). Lowering the loop count from 1000 to 100 seems to fix the issue.
(Note: The crach only affects the mocked implementation of $interval and does not happen locally.)

If I remember correctly, browsers can't actually guarantee an interval of 1ms. Maybe we should instead set it to 10ms to relieve the pressure? Or do you think the condition in the test with 1000 loops is unrealistic and doesn't need to be tested?

But this is a mock interval, right? We should have any reliance upon the real browser's ability to handler short intervals.

You are right, I read over the fact that this is only the mock implementation. But it looks like the "fake" interval of 1ms also causes the browsers in question problems - which could maybe be handled by using a slightly higher interval, which would also be more in line with what browsers do with real intervals.

I haven't tried it but I suspect it is something about the loop count that throws Firefox off. Even if we increased the faked interval to 10ms, using flush(10000) would result in the same number of iterations (and probably the same crashing). Given that this only affects the mock implementation and that I can't reproduce locally with latest Firefox, I am fine going either way. Note though, that this is not specific to the 0-delay interval (e.g. you can cause Firefox 47 to crash on Travis by explicitly using $interval(1) in a test.)

Ok, in that case I'm fine with changing just the test

OK.


Sorting for STIX lists

As a user, I want to be able to sort lists of STIX objects by each column (e.g name, ID, version).

Additionally, if the StixList is opened from the add relationship feature (i.e. via Add a Technique button on a Software object view page), it lists StixObjects as-is from the backend and is unsorted. Ideally, they could be first displayed in A-Z.


Tiling question

Currently, does buzzard support producing tiles with overlap?

Nevermind. Just saw that that tile has overlapx and overlapy parameters.


Add unit tests coverage for NotificationRecordServiceImpl object

This change includes:

Adding NotificationRecordServiceTests.java with all tests
Minor code correctness changes in NotificationRecordServiceImpl.java
Adding Java Docs to the interface - NotificationRecordService.java

In addition to my comments, I'd like to point out that there is a specific Jira task (FLPATH-19) for documenting interfaces, so maybe a separate PR can be more appropriate, but I don't have a strong opinion on this.

Hi @gciavarrini, thank you for the review
I added here the Java doc only for the object that is tested, the java doc is tight to the unit tests (the unit tests must cover the "contract" described in the java doc)
I think this can be added in the same PR


(1316) List tasks to a workflow manager

Context
Workflow managers need to be able to see tasks that are allocated as well as tasks that are unallocated.
This is similar to and will in future replace the assessment lists but I think it's worth keeping the assessment lists around for now until tasks are more feature-complete.
Trello
Changes in this PR

We begin with some general housekeeping
We add the task client
We add the task service
We add a simple controller for the view
We add some util functions for generating the tables in the views and handling the neccessary dates
We add the view

Screenshots of UI changes

 List Tasks to a workflow manager

 Allow a workflow manager to allocate a task


Beam summit blogpost

Adding a blogpost to the website on the Beam Summit London aftermath, containing the presentations and recordings of the Summit.

Awesome. Thanks for contributing the blog post!

Thanks for merging @tweise! And my pleasure @mxm :)


Signed URL not working

I am trying to upload a content to azure using aws signed urls. I was able to generate the signed url but when I am posting data to it I am getting 403 forbidden error.
Here is the link to code where it is throwing the error
https://github.com/andrewgaul/s3proxy/blob/master/src/main/java/org/gaul/s3proxy/S3ProxyHandler.java#L364
How can I resolve this?

Its working when I set the S3SignerType in ClientConfiguration

We require support for Support V4 Signed URLs

Duplicate of #160.


started review

Viewing the comments:

Ensure you have VSCode Line notes installed
Locate the message icon
Hover over the selected code and click on edit to view the comment better

Feedback from this has been incorporated in the latest version of main.


load_dataset cannot download the data and hangs on forever if cache dir specified

Describe the bug
After updating datasets, a code that ran just fine for ages began to fail. Specifying datasets.load_dataset's cache_dir optional argument on Windows 10 machine results in data download to hang on forever. Same call without cache_dir works just fine. Surprisingly exact same code just runs perfectly fine on Linux docker instance running in cloud.
Unfortunately I updated Windows also at the same time and I can't remember which version of datasets was running in my conda environment prior to the update otherwise I would have tried both to check this out.  :(
Steps to reproduce the bug
# Sample code to reproduce the bug

cache_dir = 'c:/data/datasets'
dataset = load_dataset('wikipedia', '20200501.en', split='train',cache_dir=cache_dir)
Note that exact same code without specifying _cache_dir_ argument works perfectly fine.

cache_dir = 'c:/data/datasets'
dataset = load_dataset('wikipedia', '20200501.en', split='train')

## Expected results
Downloads the dataset and cache is handled in the _cache_dir_ directory
## Actual results
Data download keeps hanging on forever, **NO TRACEBACK**!

## Environment info
- `datasets` version: 1.12.1
- Platform: Windows-10-10.0.19042-SP0
- Python version: 3.8.11
- PyArrow version: 3.0.0

Issue was environment inconsistency, updating packages did the trick
conda install -c huggingface -c conda-forge datasets

Collecting package metadata (current_repodata.json): done
Solving environment: |
The environment is inconsistent, please check the package plan carefully
The following packages are causing the inconsistency:

conda-forge/noarch::datasets==1.12.1=pyhd8ed1ab_1
conda-forge/win-64::multiprocess==<IP_ADDRESS>=py38h294d835_0
done

Package Plan
environment location: C:\Users\benoi\anaconda3\envs\UnBias-94-1
added / updated specs:
- datasets
The following NEW packages will be INSTALLED:
dill               conda-forge/noarch::dill-0.3.4-pyhd8ed1ab_0
The following packages will be UPDATED:
ca-certificates    pkgs/main::ca-certificates-2021.9.30-~ --> conda-forge::ca-certificates-2021.10.8-h5b45459_0
certifi            pkgs/main::certifi-2021.5.30-py38haa9~ --> conda-forge::certifi-2021.10.8-py38haa244fe_0
The following packages will be SUPERSEDED by a higher-priority channel:


Fix docstring example for ORTModelForCausalLM

There was no optimum/gpt2. An alternative could be to add optimum/gpt2, here the advantage is that if gpt2 is already cached no need to redownload it.
Note that the modified docstring TEXT_GENERATION_EXAMPLE is used only once.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


[Serial] Refactor begin() method

Remove the random select (default constructor), then the flow becomes greatly simplified.
if (_deviceName) {
    listAvailableDevicesAsync();
    indentifyDeviceFromCollection();
}
connectToDeviceAsync();

this issue is resolved in commit 7e2ba12cea2d663798f7181958e6ebca7022a6de

please close this issue


Enable-WriteCore-feature-for-storagesync

Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.

API change check
APIView has identified API level changes in this PR and created following API reviews.
Azure.ResourceManager.StorageSync


[please review]add a check for importing vllm when running alpha-umi demo

Change Summary
add a check for importing vllm when running alpha-umi demo

please review


I cant set myself as Admin

Hello,
i have the problem that i cant set myself as an admin on the avorion server.
I already tried to set up the admin.xml but it just get wiped clean after i start the server.
And i cant use the docker terminal to pass through any commands to the server.
Is there any other way to set me as admin??
I use docker on an synology ds218+
Thanks for the help.

Is admin.xml getting wiped clean despite you mounting the data volume?

yes

all the other files are fine though

I'm not sure what the cause is for that. It sounds like a server bug since all the other files are fine. You could try denying write permissions on the file. I don't know if that would cause a different problem though.
I'm not familiar with how docker is run on a synology, have you tried passing in the --admin steamId argument to the ENTRYPOINT of the docker container?

I will try denying the permission after changing the file in the morning.
And how do i pass the argument to the entrypoint?
I tried with exec and start but both didnt work

It's passed in when you create the container. docker run rfvgyhn/avorion --admin steamId Or if you're using docker-compose, you can use the command option (command: --admin steamId).

I will try that tomorrow and let you know if it worked

Changing the permission after editing the admin.xml did nothing the server just made a new one.

I know what was wrong with the admin.xml now. I dont understand why but apparently i cant declare my ingame name as Admin.
This works
<admin name="admin" id="76561198066028464"/>
This does not work
<admin name="TheBombTuber" id="76561198066028464"/>

Just for future reference, when you want to pass in additional arguments, they go after the image name.
docker run -d --name avorion \
    -p 27000:27000 \
    -p 27000:27000/udp \
    -p 27003:27003/udp \
    -p 27020:27020/udp \
    -p 27021:27021/udp \
    -p 27001:27001 \
    -v /host/path/saves:/home/steam/.avorion/galaxies/avorion_galaxy \
    rfvgyhn/avorion \
    --admin<PHONE_NUMBER>6028464


DOC-5576

The additional link to the Kotlin page came from a {{< childpages >}} shortcode below the Kotlin relref.

Removed the child pages short code
Inserted a new relref to the Java Flow Code Walkthrough page

Building locally to test now.

Test pass, built locally -  additional link removed and new link to Java Flow Code Walkthrough working.

I think it would be better to remove the 2 hardcoded links and use the shortcode. This will ensure the links are updated automatically if changes are made to the child pages, including if additional child pages are added.

Replaced the two hard coded links with the childpages shortcode, as per https://github.com/corda/corda-docs-portal/pull/1527#issuecomment-1613483694
Tested locally - pass, both links working correctly.


Better error messages

Better error message:

Introduce HttpException, subclass of IOException with url, http responseCode and http responseMessage to help exception handling.
Add a FINEST log message in GitHub.isCredentialsValid() in case of exception as we silently swallow this exception.

@reviewbybees esp @recena @oleg-nenashev

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@jglick I have updated the code according to your recommendations!


[$250] VBA -URL is shown on bottom left corner when Fix the error  is hovered reported by @huzaifa-99

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Navigate to /bank-account/BankAccountStep
Click on the first field, and then click outside, just to blur the field and force the validation error to be shown
Notice that an error label appears before submit button with blue coloured “fix the errors” text inside the label
Hover on “fix the errors” text
Notice it shows url address on bottom/left corner of the browser with the current url address set

Expected Result:
The label “fix-the-errors” should not show url-address when hovered
Actual Result:
“fix-the-errors” label is showing the current url as address on bottom-left screen corner when hovered
Workaround:
unknown
Platform:

Where is this issue occurring?

Web

Version Number: 1.2.27-3
Reproducible in staging?: y
Reproducible in production?: y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
https://user-images.githubusercontent.com/43996225/201452993-388bb712-3673-4a28-822c-43aeb6623b99.mp4

Expensify/Expensify Issue URL:
Issue reported by: @huzaifa-99
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1668124426446149
View all open jobs on GitHub

Proposal
In our current TextLink.js component, we are using the href props, that's why we see the bottom left url when the cursor hovered it.
https://github.com/Expensify/App/blob/0d653cad15c32150c302ac12dc0acdbca1ece18b/src/components/TextLink.js#L60-L66
Solution
To make it didn't show the bottom left url when hovered we can pass undefined as href prop. In some case, we need to use the TextLink.js but we didn't pass the href (like in this issue), we need to defined the props default value.
        <Text
            style={[styles.link, ...additionalStyles]}
            accessibilityRole="link"
-           href={props.href}
+           href={props.href ? props.href : undefined}
            onPress={openLink}
            onKeyDown={openLinkIfEnterKeyPressed}
        >
            {props.children}
        </Text>

Result:
https://user-images.githubusercontent.com/16502320/201486937-76c1a004-234a-4c51-a42f-4210b25e22b1.mov

Proposal
The issue has origins in FormAlertWrapper. We are using a TextLink there which display the current url when hovered
https://github.com/Expensify/App/blob/1b375ed3d3a7e1e42d8e746cb0e6f205ee0a3786/src/components/FormAlertWrapper.js#L59-L64
Since we are not passing an actual link/href prop, this TextLink can be replaced with a normal Text component and adding link styles
<Text
    style={[styles.label, styles.link]}
    onPress={props.onFixTheErrorsLinkPressed}
>
    {props.translate('common.fixTheErrors')}
</Text>

which fixes the bug
Demo
https://user-images.githubusercontent.com/68777211/201543329-45528a86-b6fb-464f-8f39-8376afd4be4e.mp4

I thought we are not handling accessibility as discussed here

Updated Proposal (original https://github.com/Expensify/App/issues/12692#issuecomment-1312815631)
If not breaking accessibility is a concern than we can wrap the Text in a Pressable and add the press callback there. And since it will be nested inside a Text it might break wrapping on native, so we can wrap it in a View.
Basically replacing this whole block
https://github.com/Expensify/App/blob/1b375ed3d3a7e1e42d8e746cb0e6f205ee0a3786/src/components/FormAlertWrapper.js#L57-L66 with
<View style={{ flexDirection: 'row' }}>
    <Text style={[styles.formError, styles.mb0]}>
        {`${props.translate('common.please')} `}
    </Text>
    <Pressable onPress={props.onFixTheErrorsLinkPressed}>
        <Text style={[styles.label, styles.link]}>
            {props.translate('common.fixTheErrors')}
        </Text>
    </Pressable>
    <Text style={[styles.formError, styles.mb0]}>
        {` ${props.translate('common.inTheFormBeforeContinuing')}.`}
    </Text>
</View>

This also achieves the same result but accessibility is not broken

link

This will cause an error console on web, you need to make sure there's no console error happened with your solution.

@hungvu193 i see no console errors specific to this change. Can you please describe a little more? Thanks

@mdneyazahmad yes still reproducible on v1.2.27-3

Hm strange, I don't get this error. Can you please expand the log to see the stack trace. Thanks in advance
For a reference please see this demo (ignore the 30x git file changes in my vscode, they are just console logs)
https://user-images.githubusercontent.com/68777211/201677553-68c0b9a6-d274-4065-b93d-6e8f85a394bb.mp4

@huzaifa-99 Sure, here you are

@hungvu193 I see where the problem is.
In your video demo, you are using this code
<Pressable
    style={[styles.label, styles.link]}
    onPress={props.onFixTheErrorsLinkPressed}
>
    {props.translate('common.fixTheErrors')}
</Pressable>

but in your comment here, it was different. That's why you get the error because {props.translate('common.fixTheErrors')} should be wrapped in a Text element
Again see my proposal here for the correct code block

The job listing is here: https://www.upwork.com/jobs/~01bd917604edb70bce

Hey @aldo-expensify - let me know what you think of these proposals and who we should hire.

I am checking it...

I do not consider this an issue. Why do we think this is an issue? an empty href value is completely valid just like href="#".
So href="" and href="#" is valid. It does not break anything for the user. @aldo-expensify Do you think we should fix it?

I'm pretty undecided about this, thoughts:

Agree with that this is not necessarily an "issue", but I think the link showing in the corner has no value and if it can be removed easily without "workarounds", I think it is better to not have it.
This has a very low ROI
I tested the proposal by @mdneyazahmad, and it does seem to work without breaking accessibility (tab navigation still works)

If the proposal doesn't break other stuff, I think it would be fine to proceed with it, but it worries me a bit because it touches the default value for a prop of a widely used component.
If the mentioned proposal breaks something or doesn't work well, I think we should just close this issue because it is not worth spending more time for such low ROI
@parasharrajat what are your thoughts on the the proposal?

If the mentioned proposal breaks something or doesn't work well, I think we should just close this issue because it is not worth spending more time for such low ROI

For what it's worth, this is where I'm at. If we can't come up with a proposal without side-effects, then I think we should close this issue.

I checked and It seems that defaultValue of null does not break the tab navigation. @mdneyazahmad can you confirm that this change won't break anything?

@mdneyazahmad
In case it is of use, I found the following places where TextLink is used without passing href:
https://github.com/Expensify/App/blob/e79e484e6cb60b2c18b2aa7d559fe0a0349a084f/src/components/PDFView/PDFInfoMessage.js#L32-L34
https://github.com/Expensify/App/blob/e79e484e6cb60b2c18b2aa7d559fe0a0349a084f/src/pages/ReimbursementAccount/ACHContractStep.js#L250-L252
https://github.com/Expensify/App/blob/e79e484e6cb60b2c18b2aa7d559fe0a0349a084f/src/pages/ReimbursementAccount/ACHContractStep.js#L257-L260
https://github.com/Expensify/App/blob/e79e484e6cb60b2c18b2aa7d559fe0a0349a084f/src/pages/ReimbursementAccount/ValidationStep.js#L139-L141
https://github.com/Expensify/App/blob/e79e484e6cb60b2c18b2aa7d559fe0a0349a084f/src/pages/workspace/bills/WorkspaceBillsFirstSection.js#L58-L62
It would be good to at least test that things don't break in these places (not sure if I missed one)

@parasharrajat how about the undefined href props as I mentioned.

@hungvu193 your question on the proposal
href: undefined as a default value also seems to work fine without breaking accessibility (at least tab navigation seems to work fine for me). href: undefined and href: null seems to achieve equivalent results, and I'm leaning toward undefined because that is closer to the value we would see if the prop was not provided.
The following part of the proposal I don't think it makes sense to implement here:

I feel like I may be missing something because of the accessibility concerns raised earlier, I haven't noted this problems, but maybe I'm not testing this correctly.

Yeah, I gave 2 options in my proposal, check the props or give it defaultValue, I also prefer defaultProps so we don't need to update it anywhere else.

I don't know what was wrong the last time I checked, using undefined default value was breaking Tabbing on the fix the errors link.
But now, it is working fine. @hannojg Can you please confirm https://github.com/Expensify/App/issues/12692#issuecomment-1317623554 https://github.com/Expensify/App/issues/12692#issuecomment-1317619029?

confused, I haven't touched any of the code of was working on this issue 😅 are you sure you mean me?

Lol, sorry @hannojg. Tagged the wrong guy. Its @hungvu193.

Just check, it's working fine with undefined props. Also we can reference in react-native-web documentation here:
href: ?string
If href is defined, the view is rendered as an anchor tag pointing to this URL.

@hungvu193 's proposal option 2 looks good to me. They were first so let's go with it.
Thanks, everyone.
cc: @aldo-expensify
:ribbon: :eyes: :ribbon:  C+ reviewed

Thanks @parasharrajat !
I tested quickly using undefined as default value for href (this proposal). I tested in Web Chrome, Web Safari and Desktop, didn't see any bug caused by this and the tab navigation continued working.
Assigning to @hungvu193

PR is ready for review guys 👀

@aldo-expensify could you please review the PR and let me know what you think!

I'll review today. @parasharrajat if you have some time today, please review too :)

yeah, I am just adding the screenshots.

Thanks!

The job listing is here: https://www.upwork.com/jobs/~01bd917604edb70bce

@zanyrenney I've just applied.

I am having troubles logging in to Upwork just now:

I'll hire you when I get it sorted, sorry @hungvu193

I am having troubles logging in to Upwork just now:
I'll hire you when I get it sorted, sorry @hungvu193

no worries :)

Ah glad to know it isn't just me 😅

I got back in and have hired you @hungvu193 - let me know if you have any further questions :)

I got back in and have hired you @hungvu193 - let me know if you have any further questions :)

Thank you, I accepted your offer :)

@zanyrenney am I eligible for reporting on this?

Hired contributors, waiting on the reviews @aldo-expensify @parasharrajat

PR deployed to PROD 5 days back. https://github.com/Expensify/App/pull/12858#issuecomment-1325784980

Waiting until the 7 days and then we will be ready for payment.

sent the payment to you both on upwork @hungvu193 @huzaifa-99 - any questions, lmk!

@zanyrenney Since the PR was merged within 3 days, Can I have the bonus as well?

@zanyrenney Could you please send me offer for C+?

Friendly bump @zanyrenney

have also extended the contract to you @parasharrajat - please accept it so I can pay it out.
@hungvu193 bonus has been paid.

@parasharrajat paid, inc bonus! closing this issue out now as everyone has been paid.


Update appcode-eap-bundled-jdk to v142.4675.7

This needs rebasing.

Thankyou for the contribution, however I've now removed the eap-bundled-jdk cask, as the eap is now only available bundled.


Add the @validate_arguments decorator to methods that need them

Dismissed. We're not going to do this.


Problem with closing codes

How are you doing
I'm having a very strange problem with this beautiful editor
As there is a feature that allows you, with the help of Allah Almighty, to close the codes
picture : https://i.imgur.com/XtuFjEj.png
And the feature works for me and looks great, but the problem is when the number of lines exceeds
10000 or 20000
At the moment there is a bug where if I want to copy and paste an element, or I want to type a double comma, all closed codes are opened!!! This causes me great inconvenience and delay in time, as I have to re-close it again every time this error occurs
So what's the problem?

Thanks for creating this issue! We figured it's missing some basic information or in some other way doesn't follow our issue reporting guidelines. Please take the time to review these and update the issue.
Happy Coding!

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


monitor: if no process found according to the pidfile mysql is not running

This is a common situation when mysql was killed abruptly, like a OOM
scenario.
Closes #52

:+1: for having this merged.

:+1: For merge. Verified by 'kill-dash-nine' on mysqld, mysql_montitor was not aware of it. This fixes the issue.

+1

LGTM merging.


Error initializing Vigem problem

General Information

It seems that controllers cannot be successfully detected when playing xgp games launched by steam.

Have you properly installed ViGEm and HidHide?

I have installed but not properly maybe. Perhaps I need to redownload them.

Have you properly installed ViGEm and HidHide?

Thanks by the way😀

Both (ViGEm and HidHide) are included in the .zip as well as the installer of GlosSI.
If you're having trouble you can always try to get them from https://vigem.org/Downloads/


i tried to use for pnpm but im getting an error with purl

@augustobritodev Do you have a pnpm-lock.json that reproduces the error? I haven't been able to reproduce with my test repository.


[HOLD for payment 2024-12-19] Fix the pusher instance not found crash

We are seeing this specific crash error in firebase that we have not been able to easily reproduce but we can see that its happening:
   Fatal Exception: com.facebook.react.common.JavascriptException: Error: TaskQueue: Error with task : [Pusher] instance not found. Pusher.subscribe()
            most likely has been called before Pusher.init(), js engine: hermes, stack:
anonymous@1:3767030
processNext@1:847707
_processUpdate@1:846412
anonymous@1:524811
_callTimer@1:523728
_callReactNativeMicrotasksPass@1:523929
callReactNativeMicrotasks@1:525881
__callReactNativeMicrotasks@1:218344
anonymous@1:216543
__guard@1:218218
flushedQueue@1:216454
callFunctionReturnFlushedQueue@1:216310

       at com.facebook.react.modules.core.ExceptionsManagerModule.reportException(ExceptionsManagerModule.java:65)
       at com.facebook.jni.NativeRunnable.run(NativeRunnable.java)
       at android.os.Handler.handleCallback(Handler.java:958)
       at android.os.Handler.dispatchMessage(Handler.java:99)
       at com.facebook.react.bridge.queue.MessageQueueThreadHandler.dispatchMessage(MessageQueueThreadHandler.java:27)
       at android.os.Looper.loopOnce(Looper.java:230)
       at android.os.Looper.loop(Looper.java:319)
       at com.facebook.react.bridge.queue.MessageQueueThreadImpl$4.run(MessageQueueThreadImpl.java:235)
       at java.lang.Thread.run(Thread.java:1012)

Here is a link to firebase for the crash
Issue OwnerCurrent Issue Owner: @mallenexpensify

Hello, I'm from SoftwareMansion and I'll work on this issue

Hey, I think the PR fixing this caused https://github.com/Expensify/App/issues/54142. Please take a look 👀

$125 for @allroundexperts as there was a regression from this PR

Contributor+: @allroundexperts due $125 via NewDot
Do we want a test case for this? Or one updated?

I don't think we need a test case for this. In the PR, the test steps just mentioned opening the app and verifying if it crashed or not.

I agree, I am not sure what would be a reliable test case for this one. We will monitor the crashes in firebase

Thanks @allroundexperts and @mountiny, closing


Fast sync before and after an upgrade.

If the trusted hash is from before the most recent upgrade, but that upgrade is already older than ~2 eras, the node would currently fail to join: after applying the upgrade it would try to start consensus, but the other nodes wouldn't have the first era after the upgrade anymore.
Instead, we should continue fast syncing after applying the upgrade.

Closed by #2785 and #2791.


[WIP] Start working on specs implementation

I think we need generate oauth transport on remote side
also AllowedOrganizations and OpenRegistration moved to remote and called from login via accessor methods
By default i set sqlite3 driver
Scope must be moved to settings and by default we set repo,repo:status,user:email

thanks for tackling this. complete agree with the overall decision.  I do have specific ideas for how I want to register and load drivers. I tried to explain in the comments, but let me know if I did a bad job :)

so, next, i think i can start implement gitlab driver

@Bugagazavr
I'm looking forward to gitlab, and have one question about authorization,
it seems that drone 0.4-database uses oauth2.
I tried gitlab driver yesterday in my branch, the authorization failed...
I found below gitlab production.log on debug mode,
Doorkeeper::Application Load (2.5ms)  SELECT  `oauth_applications`.* FROM `oauth_applications`  WHERE `oauth_applications`.`uid` = '12d21c3297d1d0c04d5be46424e196948b8544604b873d773a7b1ee0291a2927' LIMIT 1
   (2.7ms)  SELECT COUNT(*) FROM `projects` INNER JOIN `namespaces` ON `projects`.`namespace_id` = `namespaces`.`id` WHERE `namespaces`.`owner_id` = 2 AND `namespaces`.`type` IS NULL
  User Load (2.7ms)  SELECT  `users`.* FROM `users`  WHERE `users`.`email` =<EMAIL_ADDRESS>ORDER BY `users`.`created_at` DESC, `users`.`id` DESC LIMIT 1
  BroadcastMessage Load (2.6ms)  SELECT  `broadcast_messages`.* FROM `broadcast_messages`  WHERE (ends_at > '2015-07-24 16:02:15' AND starts_at < '2015-07-24 16:02:15')  ORDER BY `broadcast_messages`.`created_at` ASC, `broadcast_messages`.`id` ASC LIMIT 1

should we setting somthing on $GITLAB_HOME/config/gitlab.yml for oauth??
it seems default oauth is doorkeeper.

@Bugagazavr
If you have a time, please see.
https://github.com/Bugagazavr/drone/pull/1
I tried gitlab..

Thanks, i'll try to see this today.
One tip: gitlab has different oauth scopes,  if i rememer correctly, uses
only repo scope
25 июля 2015 г. 11:54 пользователь "Shunsuke Wada"<EMAIL_ADDRESS>написал:

@Bugagazavr https://github.com/Bugagazavr
If you have a time, please see.
Bugagazavr#1 https://github.com/Bugagazavr/drone/pull/1
I tried gitlab..
—
Reply to this email directly or view it on GitHub
https://github.com/drone/drone/pull/1108#issuecomment-124822537.

@Bugagazavr
Thanks, replying.
I remove other scope from gitlab.go
and some functions cannot be implement on gitlab.go for remote.go, I think.
because such Status doesn't seem to get from https://github.com/Bugagazavr/go-gitlab-client libraries.
If you have notes, please tell me.thank you.

PLEASE integrate gogs side by side with gitea :)

@tboerger gitea supports oauth?

Currently it's still the same as Gogs as it's a fork and changes will maybe follow later on...

So, i think gitea can be added, but as backport gogs from 0.3 ( no auth, no private repository, no deploy keys ).

Tell me what we need for gitea and i can push the implementation ;)

Tell me what we need for gitea and i can push the implementation ;)

deploy keys
oauth optionally

yep, even better than deploy keys, in 0.4 we can clone a repository using the oauth token + netrc file. This allows us to more easily clone submodules, or npm install / go get / install dependencies using version control urls

@Bugagazavr
Thank you for replying, https://github.com/Bugagazavr/drone/pull/1, I modified, please see it.

kick ass!


Upgrade clang-tidy and fix warnings

We currently run clang-tidy in the Ubuntu 20.04 image on GitHub Actions, which means it's kinda old. Newer versions of clang-tidy have been known to catch things in our code, e.g. #1462.
It would be cool to:

Run rake docker_tidy locally and fix any warnings.
Have our CI (GitHub Actions) run our rake docker_tidy task. I believe this will let us run a newer version of clang-tidy. (If not, maybe see about what it would take to upgrade our Docker image to newer Ubuntu version.)

The change in #1492 resolves the current issue, clang-tidy now runs successfully on my machine. The only step left should be to run it in the CI.

https://github.com/natalie-lang/natalie/actions/runs/6915553353/job/18814621284?pr=1507#step:4:109
Yeah, this still uses 14


Feedback on Tutorial: How to prepare HANA, express edition environment for tutorials

Accounts XSA_DEV & XSA_SHINE get deactivated due to password expiry. This means you are unable to change the default passwords as documented in the "Test XSC, XSA & WebIDE" section of the getting started document until you reactivate the users.

Hello Graham:
This problem has been corrected in the most recent release of HXE. In the meantime, you can change the password using the system user. Note that after changing the password as system you will still be required to change the password again after the first login as these users.
hdbsql -u system -p (your password) -d SystemDB "alter user xsa_dev password (new password)
Carl


feat(added grid layout generation): user can get css code css grid la…

…yout, which they have created
CSS grid can be generated in ui through no of rows, columns, user can get the css and tailwind code for that
Fixes Issue
My PR closes #issue_number_here
👨💻 Changes proposed(What did you do ?)
✔ Check List (Check all the applicable boxes)

[] My code follows the code style of this project.
[] This PR does not contain plagiarized content.
[] The title and description of the PR is clear and explains the approach.

Note to reviewers

📷 Screenshots

PR Compliance Checks
Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.
Issue Reference In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our Contributing Guide. This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.

Please fix this error, if you don't know how, try this:

Read the error carefully or read the contributing file
Checkout past merged Pull requests to see how they were done for it to be merged

Also fix your PR title, give a summary of what the PR is about and fill the rest properly

Note: you can edit your PR message, this PR won't be merged if the error isn't gone and you have a week max to fix it before the PR gets closed without being merged

@Thilakmani-dev this PR is a mess, please close it and start over with the proper way because there are files you never worked on but there are in this PR, the PR title is too long, the PR description isn't done properly at all

closing this @Thilakmani-dev raise a proper PR


How to know when PDF rendering has partially failed

Is there a way to catch a case in which PDF rendering has partially failed? I can catch exceptions, but in some cases PDF.js only logs warnings into console and even those cases can be quite fatal for end user experience.
For example, we have one invoice PDF which gives the following warning in console.
Warning: Failed to load font "g_d0_f2": SyntaxError: Invalid font data in ArrayBuffer.
A screenshot of the outcome rendered in PDF.js version 1.5.188 in Chrome 52.0.2743.116 (64-bit) on Ubuntu 14.04 looks like this:
http://public.humap.com/images/pdf-font-loading-failed.png
Clearly the PDF is somewhat flawed. Still, some viewers can show the PDF properly (such as Chrome built-in PDF viewer and Ubuntu Document Viewer).
Instead of showing the flawed PDF in browser I would like to show an error message to user and provide just a link to download the PDF file. So how could I do that?
The original PDF file contains secure information, but I can deliver it to developers in case someone wants to take a look at this particular file.

https://github.com/mozilla/pdf.js/blob/master/src/shared/util.js#L254 is used to log the warning to the console. You might be able to throw a custom exception there and catch is elsewhere to abort rendering and display a message for the user.
However, this particular problem should not raise a warning IMO. Could you share the file here so we can take a look at what is causing the issue? If the invoice PDF contains sensitive data, would you be able to create a PDF file with the same issue but without the data in it?

I tested opening the file with latest viewer and fonts are messed there as well.
I tried to edit the PDF, but with every attempt to remove the sensitive data the new PDF file got broken so that it was messed up in every PDF viewer I tested. So unfortunately I was not able to create a version which doesn't contain the sensitive data.
In case someone wants to take a look at the original pdf, please drop me a message at<EMAIL_ADDRESS>and I can send you the file for testing purposes.
Tested and verified the problem with

Browser: Chrome 52.0.2743.116 (64-bit)
OS: Ubuntu 14.04 LTS (64-bit)
PDF.js: 1.5.188

@THausherr kindly helped me and created a reduced version of the invoice PDF which doesn't contain any confidental information.
You can find the test pdf file at http://public.humap.com/pdf/PDFJS-7562-reduced.pdf
It only has word "Summa" in it which displays correctly when viewed with Ubuntu Document Viewer, but in PDF.js the content is scrambled.

The font is indeed broken (the first 4 bytes are "true" instead of 0x00010000, and there's probably more); but I'm able to display the file with Adobe Reader, PDFBox, PDFRenderer, GSWin, IcePDF and JPedal.

Interesting. Thank you @THausherr for helping out here!

The font is indeed broken (the first 4 bytes are "true" instead of 0x00010000, and there's probably more); [...]

Just based on this information you cannot conclude that the font is broken, since either 0x00010000 or true are actually valid TrueType font identifiers; please see https://developer.apple.com/fonts/TrueType-Reference-Manual/RM06/Chap6.html#ScalerTypeNote for additional information.


Add {% raw %} directive to embedded {{page.path}}

Without this change, the {{page.path}} blocks actually resolve on the published microsite (from https://47deg.github.io/sbt-microsites/docs/settings.html):

With the change it doesn't. Here's an example of what the results look like on my generated test site:

Of course @juanpedromoreno!
You know, there was one more thing I noticed that I wanted to ask about before submitting a PR. In the docs, you reference getEnvVar in a few places. It took me a while to realize that before using this command in build.sbt I needed to add
import sbtorgpolicies.utils.getEnvVar

to the top of my build file... BUT I noticed that that was NOT required in this buildfile for Mu:
https://github.com/higherkindness/mu/blob/master/build.sbt#L3
It looks like that project might belong on your README as a user, by the way! https://github.com/higherkindness/mu

Oh, that's right, that function comes from https://github.com/47deg/sbt-org-policies sbt plugin, which is used by sbt-microsites.
In the case of mu the import is not needed because is also explicitly using sbt-org-policies, 👉 https://github.com/higherkindness/mu/blob/master/project/plugins.sbt#L4 .

Nice catch @sritchie! :+1:


No error in log, but can't play rtsp stream.

Many thanks for your work.
We have tried locomote player to play a rtsp stream from a web camera of hikversion. The rtsp stream url is as follows: rtsp://<IP_ADDRESS>:554/ISAPI/streaming/channels/101?auth=YWRtaW46c3RsMTY1MDgzNjAwMA==.
This stream can be played successfully in VLC, but it is failed in locomote player. We checked the log info, there is no errors occurred.  Could you please give us some help? If you need, we can provide a test rtsp stream on the internet for you.
The log is:

API is ready. ‘play’ can now be called
RTSP OUT:
RTSP IN:
RTSPClient: STATE_OPTIONS
RTSP OUT:
RTSP IN:
RTSPClient: STATE_DESCRIBE
v=0
o=-<PHONE_NUMBER>035984<PHONE_NUMBER>035984 IN IP4 <IP_ADDRESS>
s=Media Presentation
e=NONE
b=AS:5100
t=0 0
a=control:rtsp://<IP_ADDRESS>/ISAPI/streaming/channels/101/?auth=YWRtaW46c3RsMTY1MDgzNjAwMA==
m=video 0 RTP/AVP 96
b=AS:5000
a=control:rtsp://<IP_ADDRESS>/ISAPI/streaming/channels/101/trackID=1?auth=YWRtaW46c3RsMTY1MDgzNjAwMA==
a=rtpmap:96 H264/90000
a=fmtp:96 profile-level-id=420029; packetization-mode=1; sprop-parameter-sets=Z2QAH6wXKgFAFuhAAAHCAABX5CE=,aP44sA==
m=audio 0 RTP/AVP 0
b=AS:50
a=control:rtsp://<IP_ADDRESS>/ISAPI/streaming/channels/101/trackID=2?auth=YWRtaW46c3RsMTY1MDgzNjAwMA==
a=rtpmap:0 PCMU/8000
a=Media_header:MEDIAINFO=494D4B48010100000400010010710110401F000000FA000000000000000000000000000000000000;
a=appversion:1.0
Ignored unknown SDP directive: e=NONE
Ignored unknown SDP directive: b=AS:5100
Ignored unknown SDP directive: b=AS:5000
Ignored unknown SDP directive: b=AS:50
SDP contained 2 track(s). Calling SETUP for each.
RTSPClient: STATE_SETUP
undefined
Setting up track: rtsp://<IP_ADDRESS>/ISAPI/streaming/channels/101/trackID=1?auth=YWRtaW46c3RsMTY1MDgzNjAwMA==
RTSP OUT:
RTSP IN:
RTSPClient: STATE_SETUP
RTP/AVP/TCP;unicast;interleaved=0-1;ssrc=2f143857;mode="play"
Setting up track: rtsp://<IP_ADDRESS>/ISAPI/streaming/channels/101/trackID=2?auth=YWRtaW46c3RsMTY1MDgzNjAwMA==
RTSP OUT:
RTSP IN:
RTSPClient: STATE_SETUP
RTP/AVP/TCP;unicast;interleaved=2-3;ssrc=265cb4ee;mode="play"
RTSP OUT:
RTSP IN:
RTSPClient: STATE_PLAY

Maybe this will help you out (it seems the "range" property is missing, like: a=range:npt=....)
You may try that following at Class "RTPTiming.as" -> Function "parse":
Add the following Code snippet after:
public static function parse(rtpInfo:String, range:String):RTPTiming {
var rtpTime:Object = {};
  if (range==null)
  {
	  range = "npt=now-";
  }`

hope that work's for you ...

Thanks for your reply.
We have tried your method, but a error happened:

831:  Unsupported Audio or Video format "DCMU"

Then, we modified the code according to the solution of issue #151 about Foscam IP camera, and it was fixed eventually.


Aerogear 8874

Motivation
https://issues.jboss.org/browse/AEROGEAR-8874
What
Create a common UI content container using the Patternfly 4 Grid system.
Why
To ensure the main application content lies within a consistent boundary.
How
Patternfly 4 Grid
Verification Steps
Verify that the width of the content in all views are the same.
Checklist:

[x] Code has been tested locally by PR requester
[ ] Changes have been successfully verified by another team member

Progress

[x] Finished task

Coverage increased (+0.02%) to 93.514% when pulling 2c4ef0b08827ddae264efa6ec9e426e9fb4b60f9 on craicoverflow:AEROGEAR-8874 into 7942ff4664cec437fc9e9ca9a9becca5d387808b on aerogear:master.


HLS: Support TTML/IMSC subtitles (in mp4 segments)

I'm trying to figure out a way to make time-based subtitles captured from a live DASH stream display correctly after converting the stream to HLS. I'm using ExoPlayer v2.18.6.
My app converts a live DASH stream into HLS. A/V works as expected, but the DASH stream includes TTML-formatted subtitle segments that do not display. The app stores A/V segments from the live DASH stream, beginning at a random time within the stream. Audio, video, and subtitle segments are stored. I then create a set of HLS playlists from these segments to play back the video.
The TTML subtitle segments contain "begin" and "end" times for the display text relative to the start of the live DASH stream. A typical subtitle segment includes something like:

    WHAT SHOULD I DO?

When playing the recording as a DASH stream, the subtitles display correctly, even when played back as a static DASH stream; i.e. not a dynamic stream using clock timing relative to when the stream was originally played. This means the subtitle decoder must be getting the timing data from the A/V stream and displaying the subtitles at the correct time based on this. (Side note: I see other evidence that this is true, like ExoPlayer's timeline bar has 489:20:17 as a start time.)
When playing the segments as an HLS stream, however, this internal timing reference is apparently NOT used, and the subtitles do not display, because the playback start time is 000:00:00 and the first subtitle displays at some much later time (489 hours, in the above example).
If I manually adjust the times in the segments, I get mixed results on whether or not they display. For example, if the above subtitle is the first one at the beginning of the stream, I can adjust it to look like this:

    WHAT SHOULD I DO?

In some cases the caption will display correctly, and others it may just blink on and back off again. My hunch is that I'm not adjusting the times correctly according to when they should be displayed based on the A/V timing. Assuming that the first subtitle should start at time 0 rarely works as desired.
I'm wondering if there is a way to extract the display time value from the MP4 data and use that as a reference start time, and then adjust the subtitle times by this value. I'm not sure what this value would be called or where to look for it; I don't know much about how the the A/V renderers operate. I considered using the DASH timing information (availability start time, current time, etc), but I don't think this will be accurate enough.
Here is an example of the and HLS stream (as extracted from a live DASH stream) with TTML subtitles:
https://1drv.ms/u/s!Ar-5IRkcwwk9gddDSA3TSrBPLus2Sw?e=QhVpC4

Thanks for the report, and for the nice self-contained repro example - that makes it much easier to investigate!
I think I've got an understanding of what's going on - but I'm not yet sure the best way to fix it.
Looking at https://datatracker.ietf.org/doc/html/draft-pantos-hls-rfc8216bis#appendix-A it seems that IMSC/TTML support was added to the HLS spec after the initial RFC was published, so it's possible that ExoPlayer just doesn't really support TTML in HLS very well at the moment.
Here's a summary of my understanding:

Your media has MP4 segments with MP4 sample timestamps that start at roughly<PHONE_NUMBER>54 microseconds (and this matches across the video and text segments)
The MP4 text segments contain TTML data inside each sample, which also has timing information in it (as you've highlighted above). These match roughly with the sample timestamps.

So each TTML cue has two timestamps: The MP4 sample timestamp, and the timestamp from the TTML data itself.

When playing HLS streams, there's a component in ExoPlayer called TimestampAdjuster which (in simple terms) modifies the timestamps of the media to start at zero by subtracting the required offset, based on the first timestamp in the media.

This currently only operates on the MP4 sample timestamps - it doesn't touch the TTML timestamps.

ExoPlayer considers the TTML timestamps to be 'absolute' and effectively ignores the outer timestamp when deciding whether a subtitle should be shown on screen. This is set here: https://github.com/androidx/media/blob/1.1.1/libraries/extractor/src/main/java/androidx/media3/extractor/mp4/AtomParsers.java#L1143

Combining these, we end up only considering the TTML timestamp - and the subtitles never show up, because the player thinks they're due to be shown very far in the future.
I've made a hacky local change that changes the behaviour described in (4), by setting Format.subsampleOffsetUs so that the TTML timestamps have the 'offset' subtracted from them before deciding if they should be shown. This results in subtitles being shown on screen at the right time.
Some questions I haven't resolved (not expecting you to answer, just noting down where I got to):

Is TTML-in-MP4 media always going to have timestamps like this (where both the media and TTML timestamps are very similar, and the TTML subtitles are 'absolute' wrt the stream)?
If setting Format.subsampleOffsetUs is the right fix, should we only do this for HLS streams (and not for DASH)?

Thank you for looking into this, Mr. Baker. I believe your assessment is correct.
You ask good questions too; I'm not sure what the expected behavior of a live HLS stream with TTML subtitles would be, but it seems like the case I'm running into could be common.
Also, regarding DASH streams, isn't the sample offset already being taken into account? In the repro example I provided, I also included a static DASH manifest that can be used to play these segments, and the TTML subtitles do indeed display. But - I also notice that the start time as displayed by the progress bar is not 0, it's a large value that (I assume) correlates with the initial media timestamp. It seems like DASH and HLS are dealing with media timestamps differently.
Thanks again. Please let me know if I can assist in any way.

Checking in on this issue. Any progress?
You mention a local hack you made to get subtitles to display, is this something I could test to see if it works in my live streaming cases?

The hacky change I made looks a bit like this in FragmentedMp4Extractor - specifically inserting code after this line:
https://github.com/androidx/media/blob/282171cb6f469c85d1b5eee1e07f571b5f3021da/libraries/extractor/src/main/java/androidx/media3/extractor/mp4/FragmentedMp4Extractor.java#L1414
private boolean updatedTextSubsampleOffset = false;
private boolean readSample(ExtractorInput input) throws IOException {
  ...
  if (timestampAdjuster != null) {
    if (!updatedTextSubsampleOffset) {
      output.format(
          track
              .format
              .buildUpon()
              .setSubsampleOffsetUs(timestampAdjuster.getTimestampOffsetUs())
              .build());
      updatedTextSubsampleOffset = true;
    }
    sampleTimeUs = timestampAdjuster.adjustSampleTimestamp(sampleTimeUs);
  }
  ...
}

This is not a good fix, because it may change the format of the track after the media period has been fully prepared, which is not permitted and may result in unexpected behaviour.
A better fix would ensure that this offset adjustment is made before the media period is fully prepared - but I haven't investigated exactly how to wire that up.

Thanks for sharing the hack; FWIW I did include it in my build and tried it out on several of the HLS (converted from DASH) live streams we need to support, and it appears to work as desired: the subtitles displayed and appear as intended. Limited test cases, but it didn't appear to break anything at least.
I appreciate your efforts on this, let me know if I can be of any use.

I've continued testing the hack on various streams (DASH converted to HLS, typically), and though it does seem to work in the majority of cases, we've found that certain DRM streams don't play with this hack in place. I haven't looked into the exact scenario that causes it to fail, but video freezes on a frame while audio continues to play.
Probably not a big surprise, since it's definitely not a proposed fix, but I thought I should share my findings.

I wonder if you still see issues with video freezing if you finesse the hack slightly to only trigger on text tracks. Something like:
if (!updatedTextSubsampleOffset && track.type == C.TRACK_TYPE_TEXT) {
  // Same code as suggested above
}

I don't think that should make a major difference, but it also seems more correct to only do this for text tracks, so it seems worth a quick try.

Thanks Ian, I gave this a quick try and yes, it does seem to fix the issue I was seeing. I haven't noticed any other issues but have a bit more testing I can do.


scanner() call missing the excludedirs variable

Row 222, "scanner(suffixlist, equivtypes, scandir)" need to be changed to "scanner(suffixlist, equivtypes, scandir, excludedirs)" otherwise python trows an error.
Thanks for a great script!

Thanks for the bug report! That is what I get for not testing a pull.  I corrected the issue and did a little cleanup.


Add a CLI

Add a CLI to exercise both the verification and provisioning pipelines.

This is OBE by evcli


internal/fs: Don't Sync() destination file after copy

When copying files, directly check for errors when closing
the destination file rather than using out.Sync() with
a deferred Close().
The out.Sync() call can be incredibly expensive on systems which
are I/O-heavy, yet may have more than ample memory and CPU
resources.  As part of a file copy, we only need to ensure that
errors writing and closing the file handle are checked and dealt
with, rather than forcing the entire copied file to physical storage.
Environments such as Continuous Integration servers and container
hosts are often I/O-heavy.  In such environments, this change
can make a significant difference - milliseconds vs minutes.

What does this do / why do we need it?
Avoid unnecessarily syncing newly copied files to physical storage.
A sync to physical disk imposes heavy latency on completing the file copy, and it is
exacerbated when it is done file-at-a-time.
Replacing the out.Sync() call with an error check on out.Close() can dramatically improve
latency on I/O-heavy machines, and actually improves error detection vs the out.Sync() call.
On a container host that I use for CI, this reduced a dep run from 6 minutes to 5 seconds.
(the host has copious RAM and CPU, but is heavily I/O bound)
What should your reviewer look out for in this PR?
Do you need help or clarification on anything?
Which issue(s) does this PR fix?

oh, yes! 🎉 🎉  we're not writing a database here - these calls don't need to guarantee data is flushed to disk prior to the function returning. the various failure modes that arise from not doing an fsync here are within our tolerances.


Parse git commit date into a datetime object.

Without this change the history.date dictionary item is the unmodified string taken from the git log output. This is makes it impossible to - for example - output it localized in the template. (At least without such hackery as implementing date parsing in a template tag.)
This patch adds a date_parsed!

Coverage decreased (-0.2%) to 70.942% when pulling 1270e901edcb2d8c56efa1ae50366c6b8ac6d4be on wagnerflo:git-parse-date into<PHONE_NUMBER>1a8259bef63b39bb9a830c24a38283 on mgaitan:master.

Coverage decreased (-0.2%) to 70.942% when pulling 1270e901edcb2d8c56efa1ae50366c6b8ac6d4be on wagnerflo:git-parse-date into<PHONE_NUMBER>1a8259bef63b39bb9a830c24a38283 on mgaitan:master.

Coverage decreased (-0.2%) to 70.942% when pulling 1270e901edcb2d8c56efa1ae50366c6b8ac6d4be on wagnerflo:git-parse-date into<PHONE_NUMBER>1a8259bef63b39bb9a830c24a38283 on mgaitan:master.

Coverage decreased (-0.2%) to 70.942% when pulling 1270e901edcb2d8c56efa1ae50366c6b8ac6d4be on wagnerflo:git-parse-date into<PHONE_NUMBER>1a8259bef63b39bb9a830c24a38283 on mgaitan:master.

Coverage decreased (-0.2%) to 70.942% when pulling 1270e901edcb2d8c56efa1ae50366c6b8ac6d4be on wagnerflo:git-parse-date into<PHONE_NUMBER>1a8259bef63b39bb9a830c24a38283 on mgaitan:master.

Coverage increased (+0.01%) to 71.117% when pulling ba172a7caebc36e0a9b62885bc85f59d513c43d1 on wagnerflo:git-parse-date into<PHONE_NUMBER>1a8259bef63b39bb9a830c24a38283 on mgaitan:master.


Use flutter_modular and mobx for controllers, DI, state management

Use https://pub.dev/packages/slidy
to set up https://pub.dev/packages/flutter_modular
and https://pub.dev/packages/mobx to enable
to enable

Achieved state management and manual DI with #93


[5.6] Add unset() method in FilesystemManager

I'm building a multi tenant system and I had to add this method to be able to update the disk's root property dynamically when switching tenants. For example, in this app we switch tenants when processing data inside queued jobs.
The disk config is cached, so this method needs to be called manually before making changes to the config. After the disk is used again the new config is cached automatically.
Here is an example of an app with disks for photos and videos:
// First we unset the disks
app('filesystem')->unset(['photos', 'videos']);

// Apply the tenant's slug as the disk path root
Config::set('filesystems.disks.photos.root', $this->currentTenant->slug);
Config::set('filesystems.disks.videos.root', $this->currentTenant->slug);

The method accepts an array of names, but if a single string is more appropriate I can change it.

Nevermind, Taylor already did it in subsequent commit https://github.com/laravel/framework/commit/cbfb4fbf0784ac5eb08ce2effe8727f3428d5812 :)


No @Mockery annotation for param was found

I have an interface defined like this;
    @POST ("api/v1/user/login")
    @DTOArgs(UserMock.class)
    Observable<User> login(@Body LoginWrapper wrapper);

And I get the following error:

Error:error: When checking method
No @Mockery annotation for param wrapper was found.
To fix it, annotate this param with one.

I don't understand why I have to add some Mockery annotation to the request body.
I just want to have the response mocked.
I know I can add @Optional to make it work, buy why should I do so? I would like to avoid that to keep the interface as clean as possible

Because Mockery is not only for mocking data, it is designed too to provide a way to automate unit testing for the network layer. That's why the annotation is required.


Some questions about tables

I figured out how to crack open the raw .mdb files and am now trying to figure out how to get from the raw data to the processed data.
Matt, I have a few questions about a some of the tables. I was hoping you could take a look at tables I still have questions about and give me a bit of insight.
rmp_lepc_cd - This file is just empty.
rmp_proc_chem, rmp_proc_naics, rmp_registration - I'm specifically confused about the columns that begin with "num_ " I'm assuming the values in those columns are boolean, but since I'm not super-familiar, I could be wrong. Do you have a better idea for what those columns mean?
I'll probably have some questions later down the line, but these are the initial questions about the data I have so far.

I'll take a look at this today.  My guess is you're right, but I have to take a look at it to be 100%

Oh and my guess on the lepc_cd thing is it was probably related to a mapping initiative they scrapped when moved the data to us.  Like it was going to be Local Emergency Planning Committees (LEPCs) paired to Congressional Districts? Just a guess


Getting Cannot resolve symbol 'React-Native-Component'

When i include this library in my project, Webstorm says Cannot resolve symbol 'React-Native-Component' where React-Native-Component = any react native component.

I'm not familiar with Webstorm and I'm not sure why Webstorm would do that. I can't imagine what that error would have to do with this library.

I've deleted flow-typed folder from node_modules and the error gone. I am new in RN. I don't know why it worked. I think it happened due to the collision of multiple version of react native.

That's helpful to know. We shouldn't be including that folder in the package anyways. I'll put out a new version in a second that doesn't include that folder.

Okay. that's great.

I think it's a problem with the package, and @Ashoat told me that there will be a new version with a fix to this issue. Anyways, am closing this. Tnx all for the response.

<EMAIL_ADDRESS>has just been published and it should not include flow-typed.

Updated (y). Tnx @Ashoat :)


fix: prepend local bin to PATH

把项目本地的node_modules/.bin放到PATH的最前面，确保优先使用本地安装的命令。
例如：
本地安装@babel/cli@7，全局安装babel-cli@6
build:
  - name: shell
     script:
       - babel src --out-dir lib

之前执行dn run build时，实际执行的babel为全局安装的版本
修改之后，再执行dn run build时，实际执行的会是本地安装的babel

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.龙归 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


[front] - fix(VaultWebsiteModal): edition

Description
This PR fixes the website edition modal.
This mainly splits the creation and edition into two different functions.
Risk
Low
Deploy Plan
Deploy front

Btw, it's weird I remember I did the exact same fix a while ago 🤔

@Fraggle sorry forgot to add the issue, edited the description 👌🏼


Fix Custom CSS

Kbin supports custom css, for both users and magazines, but it comes with a huge flaw. It seems like some selectors are being stripped out, including common stuff like the direct child selector (>).
I'm not sure how feasible this is, but I should look into whether I can manually load the CSS and apply it and whether that would change anything.

Should be relatively simple, just unsanitize

Currently planned goals:

Automatically replace HTML escape codes inside style tags with their actual characters.

Then:

Close this issue.

#31 should be able to use the attribute applied here to avoid having to do a web request if this mod is enabled.


Improve selection of L1 origin in Espresso mode

We now apply corrections to the L1 origin before deciding
whether the batch must be empty, which should lead to fewer
spurious empty batches.
We also use the L1 head of the last Espresso block instead of the
first one, which gives us a more recent L1 origin. Since we must
always wait for the last block of the window to choose the L1
origin, the justification format and validation has fewer edge
cases. The justification will always have start and end bookends,
and the validation flow is simply:

validate all headers
check bookends
check L1 origin
check transactions
The only edge cases are in checking the bookends, where Prev may be
nil in the genesis case.

Depends on #57
Depends on #55 (will need to rebase/fix conflicts)
Closes #52
Closes #53

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 7 committers have signed the CLA.:white_check_mark: jbearer:x: hamdiallam:x: ajsutton:x: OptimismBot:x: Jason Yellick:x: mergify[bot]:x: epociaskJason Yellick seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

@jbearer Did the failing tests pass for you locally or is it worth investigating the failures?

I have these failures for  make test-external-geth locally.
--- FAIL: TestMixedWithdrawalValidity (0.00s)
    --- FAIL: TestMixedWithdrawalValidity/withdrawal_test#6 (2.34s)
    --- FAIL: TestMixedWithdrawalValidity/withdrawal_test#5 (2.34s)
    --- FAIL: TestMixedWithdrawalValidity/withdrawal_test#4 (2.45s)
    --- FAIL: TestMixedWithdrawalValidity/withdrawal_test#3 (2.25s)
    --- FAIL: TestMixedWithdrawalValidity/withdrawal_test#9 (3.04s)
    --- FAIL: TestMixedWithdrawalValidity/withdrawal_test#8 (3.33s)
--- FAIL: TestChallengerCompleteDisputeGame (0.00s)
    --- FAIL: TestChallengerCompleteDisputeGame/ChallengerIncorrectAtLastTraceIndex (1.68s)
    --- FAIL: TestChallengerCompleteDisputeGame/ChallengerIncorrectAtTraceZero (1.61s)
    --- FAIL: TestChallengerCompleteDisputeGame/ChallengerWins_AttackStep (1.43s)
    --- FAIL: TestChallengerCompleteDisputeGame/DefenderWins_AttackStep (1.44s)
    --- FAIL: TestChallengerCompleteDisputeGame/DefenderIncorrectAtLastTraceIndex (68.86s)

make test-legacy-http passes for me locally.

For make test-external-geth
--- FAIL: TestWithdrawals (39.11s)
--- FAIL: TestCannonDefendStep (151.78s)
--- FAIL: TestChallengerCompleteDisputeGame (0.00s)
    --- FAIL: TestChallengerCompleteDisputeGame/ChallengerIncorrectAtLastTraceIndex (120.38s)
--- FAIL: TestMultipleCannonGames (160.33s)
--- FAIL: TestCannonDisputeGame (0.00s)
    --- FAIL: TestCannonDisputeGame/StepFirst (150.88s)

It's pretty non-deterministic, I seem to get different failures each time. I don't think it's worth spending too much time on now as long as the devnet is working

For one thing all my failures are timeouts. I don't know if I've done something to make it slower or if OP is testing on really powerful servers or what


fixing issue 6361

fixing #6361

@ppenzin Hi Petr,
I fixed the oneliner as instructed. Also changed the testcases for toLocaleString.baseline and js in test/Array.
Please advise me if there are other instances i need to change.
Thanks!

@muhdmud Hi Muhd, preliminarily, the patch does not look too bad, I will take a closer look tomorrow, but we need to sort out the CI failures (see the "Checks" insert).
Note, a couple of the CI jobs have a tendency failing intermittently.

@ppenzin Hi Petr, apologies i dont get the checks insert part of your statement. Do you mean the tab above between commits and file changed?

I mean the area in this tab that says "Some checks were not successful", it usually appears after the bottom message in this thread.
Let me know if you need help reproducing the failures.

Looks like something wrong with my tests, i will check and push again for now

@ppenzin looks like its failing the tests in toLocaleString.baseline,
What I did was change that oneliner and then changed the tests in above file and remove the spaces.
for example
0.00, anObject, , , another Object, 1.00, a 3rd Object, 2.00 (with spaces)
0.00,anObject,,,another Object,1.00,a 3rd Object,2.00 (removed (spaces)
is this the correct way? also could it be that the function is affecting other tests in other files? so need to change all at once?
Lastly, to run tests before pushing, am i correct to use ./build.sh --test-build?

To run the tests, run./runtests.py in the test directory. You would need to add --test or --debug for test or debug build (in your case it is the test build), and also --binary <path to ch>, which the path being something like out/Test/ch/ch.
I will take a look at the test tomorrow, I don't think it should be anything serious.
Alternatively you can try to use the experimental end-to-end CMake build for both build and test:
$ mkdir <build dir name>
$ cd <build dir name>
$ cmake <path to ChakraCore root>
$ make
$ make check

The last command runs the test suite. This would also work with Ninja instead of Make.

for the part where i have to change the function in two places,
if (*sepOutSize < 2 || szSeparator[*sepOutSize - 2] != ' ')
{
szSeparator[*sepOutSize - 1] = ' ';    // this line you mean?
szSeparator[*sepOutSize] = '\0';
}

Yeah, you can just delete that whole section, I think.

I added the trailing spaces for the rest but for when i saved it went away.. especially for

Non Object
1 -->(space here but cannot save)
NaN -->
true -->

I think it your text editor mandating "no trailing spaces" - there must be a way to turn that off. I've created a gist with the trailing spaces put back, you can try to copy it (but probably don't open with the same editor before git add on the file): https://gist.github.com/ppenzin/c375a5edc9e2749c7a751175c81ef123
The code changes look good to me, I think we will be all set once we sort the trailing spaces out.

Oh ok noted. I did change the trailing spaces settings in VSCode, thanks for that 👍
Now pushed again with the trailing spaces, thanks sir!

Sure, il do what it takes! quite new so its good learning experience for me

I am happy we got past the POSIX issue. The Windows issue is a bit weird.
Have you looked at what is causing Windows test to fail? ;)  If you can, try to print both expected and result character by character or run the test under debugger.

@muhdmud thank you for your contribution!


Clean up tests and fix errdefer issue

Added a test for an invalid obj file which causes the errdefer logic to be exercised, and added a test for sharing material info over two objects.

Nice catch, thank you!


[SUPPORT] The query result of the partition column as the filter condition is incorrect

Tips before filing an issue

Have you gone through our FAQs?

Join the mailing list to engage in conversations and get faster support at<EMAIL_ADDRESS>

If you have triaged this as a bug, then file an issue directly.

Describe the problem you faced
A clear and concise description of the problem.
To Reproduce
Steps to reproduce the behavior:

use spark-sql create hudi table
insert into table
select table

Expected behavior
A clear and concise description of what you expected to happen.
Environment Description

Hudi version : 0.13.0

Spark version : 3.3.0

Hive version : 3.1.3<IP_ADDRESS>.0-297

Hadoop version : <IP_ADDRESS>.1.6.0-297

Storage (HDFS/S3/GCS..) : HDFS

Running on Docker? (yes/no) : no

Additional context
Add any other context about the problem here.
Stacktrace
Add the stacktrace of the error.
1.
create table hudi_test.hudi_cow_pt_tbl6 (
id bigint,
name string,
ts bigint,
dt date,
hh string
) using hudi
tblproperties (
type = 'cow',
primaryKey = 'id',
preCombineField = 'ts'
)
partitioned by (dt)
location 'hdfs://cdp716-master01.kylin.com:8020/user/hive/warehouse/hudi_test.db/hudi_cow_pt_tbl6';
2. insert into hudi_cow_pt_tbl6 select 1 as id, 'a0' as name, 1000 as ts, cast('2021-12-10' as date) as dt, '10' as hh;
3. execute: select dt,hh from hudi_test.hudi_cow_pt_tbl6 where dt = '2021-12-10';  result is null, but use hh filter result is success.

@fanfanAlice I was able to experiment and confirm this issue in 0.13.0 but it got fixed with version 0.13.1.  So I suggest you to upgrade to 0.13.1 OR 0.14.X release.

I upgraded to hudi version 0.13.1 and the issue has been resolved thank you very much

Thanks @fanfanAlice . Closing this issue then.


chore: bdd-sbhg-import-1586892471 to 0.0.1

chore: Promote bdd-sbhg-import-1586892471 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


System.TypeLoadException:

I find  this issue " Method 'getProperties' in type 'Microsoft.Extensions.Configuration.ConfigurationBuilder' from assembly 'Microsoft.Extensions.Configuration, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=adb9793829ddae60' does not have an implementation. at MicroKnights.Logging.AdoNetAppender.ResolveConnectionString(String& connectionStringContext) at MicroKnights.Logging.AdoNetAppender.InitializeDatabaseConnection()"   for net core 2.0,I think is  the assembly version problem, is there any solution?

Is this a runtime exception, or a build/compilation error?
I am using the Log4NetAdoNetAppender nuget in several 2.x .net core projects without troubles

This is runtime exception, I fix this  issue by override ResolveConnectionString method, to use my self config.
protected override string ResolveConnectionString(out string connectionStringContext)
{
connectionStringContext = "ConnectionString";
return LogOptions.Instance.SqlServerConnString;
}

Seems odd, that you have this error.
Are you running under .Net Standard/Core or .Net Framework?
There is a Nuget package for this library https://www.nuget.org/packages/MicroKnights.Log4NetAdoNetAppender/, have you tried that? And another Nuget package for setting the connectionstring manually/runtime https://www.nuget.org/packages/MicroKnights.Log4NetHelper/.


load chunks with xhr+eval rather than jsonp

Do you want to request a feature or report a bug?
feature
What is the current behavior?
Webpack creates chunks when using lazy loading for scripts, e.g require.ensure, and loads them by adding script src tag to the DOM.
What is the expected behavior?
Allow to load chunks using XHR + Eval  as well instead of adding script src to the DOM
If this is a feature request, what is motivation or use case for changing the behavior?
Handful of my users are gettings the following exception:

Unhandled rejection message: 'Loading chunk 0 failed' stack: Loading chunk 0 failed at HTMLScriptElement.n

Users which are using Chrome60/Win7.
The cause for this is that some extensions/firewalls/security configurations blocks jsonp regardless of the domain. since few of my users getting this error every day, I cannot ignore it.
And it seems I'm not the only one who's having this issue: https://stackoverflow.com/questions/46051722/webpack-loading-chunk-0-failed
Please mention other relevant information such as the browser version, Node.js version, webpack version and Operating System.
Webpack : 2.6.1
Chrome 60
Win 7
node8

It's unclear for me why JSONP should be blocked. Maybe it just run into a timeout because of an unstable internet connection. This seems to be more likely to me.
Have you tried if using XHR+eval solves this problem?
eval is problematic of CSP.

First, The error was consistent for the users who got it. they got it every time they entered. on a fast stable internet connection.
This extension for example : https://chrome.google.com/webstore/detail/scriptblock/hcdjknjpbnhdoabbngpmfekaecnpajba?hl=en will block jsonp.
jsonp is well known kinda hack to bypass CORS, so it's ok if  some are blocking it, the problem is that they do it regardless whether its the same domain.
I did not check but, I'm pretty sure that XHR + Eval will not be blocked. why would it ? XHR is XHR, and eval is just a javascript function. if XHR/Javascript is disabled then I can actually ignore such cases.

I guess it's expected that a page stops working when you block the scripts...
adding scripts via <script> tag is the better way compared to XHR+eval, so I won't change it. Feel free to use the plugin to change it.

I think this feature would be an acceptable solution for #5244 as well.

I've met the same problem ,has anyone solved it yet?

how to solve this problem?

Same issue +1

Please consider this.

The problem is that the browser's load event comes in later when async chunks are loaded via script tags and jsonp, versus XHR. Is there a way we can tell Webpack to load async chunks via XHR instead of JSONP?

@prograhammer impossible due design

Anyway you try to send PoC

@evilebottnawi Understood. Here's a plugin I noticed that seems to do it: https://github.com/seleb/chunk-progress-webpack-plugin

@prograhammer
I've checked this issue while searching how to fire load event faster and I settled down to start loading webpack bundles after load event

@zxzl The main purpose is that typical analytics (such as NewRelic) will naturally look for the load event. So ideally you still want that load event to be after your main chunk. This gives you the time it took for the "important" stuff to be ready. But other async chunks can load whenever (things you decide are not as vital, for example something "below the fold", etc.).

in webpack@5 you can create your own chunkFormat + chunkLoading mechanism.. Feel free to create a plugin for that like
https://github.com/webpack/webpack/blob/main/lib/web/JsonpChunkLoadingPlugin.js
https://github.com/webpack/webpack/blob/main/lib/javascript/ArrayPushCallbackChunkFormatPlugin.js


Upgrade to elm 0.17

Also, noticed that https://github.com/mgold/elm-date-format/pull/10 is true, JavaScript adds your timezone by default, so the expected values would need to be constructed rather than be hardcoded to fix this.

Released in 1.1.4. Thanks!


Questions about real time predictions from an incoming stream of data.

The way the following usage has been covered (from the documentation), it is only possible to use detect() for detecting anomalies within the time series that it has been trained with. How do we save a trained model and pass new incoming data to the detector?
def detect_anomaly(series, threshold, mag_window, score_window, sensitivity, detect_mode, batch_size):
    detector = SpectralResidual(series=series, threshold=threshold, mag_window=mag_window, score_window=score_window,
                                sensitivity=sensitivity, detect_mode=detect_mode, batch_size=batch_size)
    return detector.detect()

@rajdeep-biswas Hi, may I ask whether you get the answer or solution to this question now? I have same concern here and hope you can give me some suggestions.

@ChunhanLi, unfortunately no, I just moved on to other better maintained open source options such as Prophet and PyOD.


Allow numbers to be added to word definitions

Numbers are added to the stack by the outer interpreter, and they can be used just fine in execute mode, but this doesn't get reflected in a colon definition. A word such as LIT (literal handler) is probably needed to force the interpreter to add the stack number to memory when it sees the lit word.. or something like that. It might need to be immediate as well.

With this change, it is now possible to define words such as:
: add5 ( x -- n ) 5 + ; \ add 5 to the current stack number
5 add5   ok

The top of the stack would then contain the number 10.


[Bug]: Off-by-one wei

Describe the bug
We're observing off-by-one wei for liquidity operations (mint, increase, decrease, and collect). Not sure if this is imprecision by LiquidityAmounts, but additional investigation is desired for assurance
For liquidity additions (mint / increase), 1 additional wei is required
For liquidity removal (decrease / collect), 1 wei is missing
Expected Behavior
Liquidity operations are perfect (?)
To Reproduce
See any test with assertApproxEqAbs, or amount0 + 1
Additional context
n/a

believed to be imprecision of liquidity logic
https://github.com/Uniswap/v3-core/issues/570


Fixes 1974: Added manual snapshot

Summary- Added the manual snapshot to the dropdown
Testing steps- Stage is down

https://issues.redhat.com/browse/HMS-1974

I can test in prod now for the changes I pushed; Hold off on the review

⚠ This task currently requires qe-approval, but this PR does not fully resolve the task.  Please contact QE to determine appropriate testing required.

Hi
The task runs, popup displays "Success alert:Snapshot triggered successfully"

Looks good to me.

/retest

Hi
I will merge this as its backend deployment failing in the PR check.


FYPO:0000581

Should  FYPO:0000581 be a cell population phenotype? (currently process phenotype)
A cellular process phenotype in which the occurrence of spore germination is decreased.
Original comment by: Antonialock

now superseded by #2271


feat(storage): separate storage databases experimentally

What this PR does
This PR implemented the idea of separating the storage database, which was proposed by @hungryjang.
It divides storage databases into two parts: data database and commit database. The data part
stores records whose keys are LLSNs and whose values are log data users append. The commit part
stores records whose keys are GLSNs and whose values are LLSNs.
This approach is very performant compared to the previous one. Especially the data part can take
advantage of move compaction dramatically. Empirically throughput can be increased by about 10-20%
and append duration reduced by about 10-20%.
However, it doubles the number of pebble instances. We should configure the storage databases
carefully to overcome this.

Current dependencies on/for this PR:

main

PR #409

PR #410   👈

This comment was auto-generated by Graphite.

Codecov Report
Patch coverage: 50.72% and project coverage change: +0.05 :tada:

Comparison is base (6ccf9ec) 63.60% compared to head (e3fa2f4) 63.66%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@               Coverage Diff                @@
##           test_options     #410      +/-   ##
================================================
+ Coverage         63.60%   63.66%   +0.05%
================================================
  Files               131      131
  Lines             17801    17918     +117
================================================
+ Hits              11322    11407      +85
- Misses             5937     5962      +25
- Partials            542      549       +7

Impacted Files
Coverage Δ

internal/storage/testing.go
18.60% <0.00%> (-0.91%)
:arrow_down:

internal/storage/config.go
51.33% <18.66%> (-12.96%)
:arrow_down:

internal/storage/append_batch.go
76.92% <61.53%> (-5.43%)
:arrow_down:

internal/storage/storage.go
87.45% <74.74%> (+9.52%)
:arrow_up:

internal/storage/recovery_points.go
90.69% <100.00%> (ø)

internal/storage/scanner.go
98.71% <100.00%> (ø)

internal/storagenode/storagenode.go
73.78% <100.00%> (+0.84%)
:arrow_up:

internal/storagenode/volume/volume.go
94.38% <100.00%> (ø)

... and 7 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Color scheme/theme request

I dont have much knowledge to make my own customized theme, so i just modify the css as per my liking, so it will match the color to the  logo of my store.
I did changed the blue #0041ff (default scheme) to the color that i want but nothing happens.
Hope youll add some theming or color picker for schemes options in the future.

Note: To see the changes, you will be required to compile the assets. For compilation of assets NPM should be installed in your system.
Then go inside each of these packages(path from project's root):

packages\Webkul\Admin
packages\Webkul\Shop
packages\Webkul\Ui

Then you need to run command 'npm install' in each of the directories listed above.
Go to your project root again:

Find _variables.scss file by following this path in shop package:
packages\Webkul\Shop\src\Resources\assets\sass\_variables.scss

In this file _variable.scss you will find all the colors values used in Shop package.

Find _variables.scss file by following this path in Ui package: packages\Webkul\Ui\src\Resources\assets\sass\_variables.scss

In this file _variable.scss you will find all the colors values used in Ui package.

But remember the colors in UI package file will affect colors in Admin panel also.

Find _variables.scss file by following this path in Admin package:
packages\Webkul\Admin\src\Resources\assets\sass\_variables.scss

In this file _variable.scss you will find all the colors values used in Admin package.
Note: To compile these assets now, step into all these directories below:

packages\Webkul\Admin
packages\Webkul\Shop
packages\Webkul\Ui

And now run the command 'npm run prod' -> for production and 'npm run watch' -> for development.


Custom tags example only allows one tag

Hi!
This might be a bug because I can't add more than one tag in the "custom tags" example.
https://github.com/i-like-robots/react-tag-autocomplete/blob/973d6a361441f9875e80d8347a8721a108fa5c86/example/src/main.jsx#L115-L165
When I add a second tag the first one gets removed.
I would like to use this component in a project with React 18, that's why I tried the beta version instead of the stable one.

Thank you, good spot. The custom tags are being created with a null ID so it's getting confused.


ctlv3: updated readme for options and examples for get command

Implemented TODO: add consistency, from-key, keys-only
Added examples for get from-key and get range

@sinsharat Can you update your commit message to start with etcdctlv3 perfix?
# modify commit
git commit --amend
(change commit message in your favorite editor)
git push sinsharat readme_get_features_update -f

@xiang90 i have done the change in commit message.
Thanks!

Thanks!


Readme needs more ELI5?

This looks like a cool project! But, and even though I read the readme, I am a little unsure what it actually is.
AFAIK, Scintilla is a text/code editing library and doesn't do anything by itself. So, is scinterm also a library? Or is scinterm more like SciTE (a minimal text/code editor built for showcasing the Scintilla library) for curses?
Maybe you could update the readme for doofuses like myself :)

Aha, I understand now. I guess the missing piece for me was that Scintilla supplies special support for select widget toolkits—so scinterm is that but for curses. Thank you for clarifying.