x/net/html: Tokenizer - incorrect handling of attribute states when U+002F SOLIDUS (/) is encountered

What version of Go are you using (go version)?

$ go version
go version go1.21.1 linux/amd64

golang.org/x/net v0.15.0

Does this issue reproduce with the latest release?
Yes, golang.org/x/net v0.15.0 is the latest version
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE=''
GOARCH='amd64'
GOBIN=''
GOCACHE='/home/maciekmm/.cache/go-build'
GOENV='/home/maciekmm/.config/go/env'
GOEXE=''
GOEXPERIMENT=''
GOFLAGS=''
GOHOSTARCH='amd64'
GOHOSTOS='linux'
GOINSECURE=''
GOMODCACHE='/home/maciekmm/go/pkg/mod'
GONOPROXY=''
GONOSUMDB=''
GOOS='linux'
GOPATH='/home/maciekmm/go'
GOPRIVATE=''
GOPROXY='https://proxy.golang.org,direct'
GOROOT='/usr/lib/go'
GOSUMDB='sum.golang.org'
GOTMPDIR=''
GOTOOLCHAIN='auto'
GOTOOLDIR='/usr/lib/go/pkg/tool/linux_amd64'
GOVCS=''
GOVERSION='go1.21.1'
GCCGO='gccgo'
GOAMD64='v1'
AR='ar'
CC='gcc'
CXX='g++'
CGO_ENABLED='1'
GOMOD='/dev/null'
GOWORK=''
CGO_CFLAGS='-O2 -g'
CGO_CPPFLAGS=''
CGO_CXXFLAGS='-O2 -g'
CGO_FFLAGS='-O2 -g'
CGO_LDFLAGS='-O2 -g'
PKG_CONFIG='pkg-config'
GOGCCFLAGS='-fPIC -m64 -pthread -Wl,--no-gc-sections -fmessage-length=0 -ffile-prefix-map=/tmp/go-build2511272611=/tmp/go-build -gno-record-gcc-switches'

What did you do?
Calling the Tokenizer with HTML element containing SOLIDUS (/) in the attribute name results in incorrect tokenization.
This is due to violation of the following rules in the WHATWG spec:

https://html.spec.whatwg.org/multipage/parsing.html#after-attribute-name-state ->
https://html.spec.whatwg.org/multipage/parsing.html#self-closing-start-tag-state  (we are not reconsuming in before attribute state)

Test cases:
https://go.dev/play/p/ne5aV9XWVBd
What did you expect to see?
I expected to have the HTML code with attributes containing the solidus / character tokenized correctly with following inputs:
	{
		"forward slash before attribute name",
		`<p/=">`,
		`<p ="="">`,
	},
	{
		"forward slash before attribute name with spaces around",
		`<p / =">`,
		`<p ="="">`,
	},
	{
		"forward slash in the attribute name followed by character",
		`<p a/ ="">`,
		`<p a="" =""="">`,
	}

What did you see instead?
<p/="> -> EOF
<p / ="> -> EOF
<p a/ =""> -> <p a="">

cc @neild

Hi, @neild, @prattmic
any idea when this is going to be merged? It's been in "ready to submit" state for months.


Stronger validation for declaration requests (#2789)

https://github.com/edenlabllc/ehealth.api/issues/2789

Coverage decreased (-0.02%) to 90.368% when pulling 945377aee13887bc99012b5d3e86092b5bc0fdca on declaration_request_validation_2789 into a2e516e57b9e5914df85772b492f941a169f690f on develop.


[Recents: Fixes & Improvements] improved queries, tidied up UI, fixed bugs and added pref for folder exclusion

Description

Fixed a bug whereby folders would vanish from results upon opening via 'Recent Folders'
Implemented a user configurable excludeFolders preference to remove all Folders from results, if desired, excluding those in the dedicated 'Recent Folders' command.
Tweaked formatting of the Last used label/date shown against results.
Improved all underlying queries to provide more refined/accurate results.

Screencast

Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing
[x] I ran npm run build and tested this distribution build in Raycast
[x] I checked that files in the assets folder are used by the extension itself
[x] I checked that assets used by the README are placed outside of the metadata folder

Hi @GastroGeek 👋
What an update! One question, how do I use the exclude folder? I only found the setting but I have no clue how to use it, is it using excluded folders from macOS?

you don't use it directly, it simply prevents items of type 'Folder' from showing up in all commands, if checked. (all but Recent Folders of course).


U+2594 doesn't render

Windows Terminal version
1.19.2831.0
Windows build number
10.0.22631.0
Other Software
No response
Steps to reproduce
Write-Host "`n`n`u{2594}`n`n"

Expected Behavior
On current mainline builds:

Actual Behavior
On preview+ builds:

Additional Information
This specific character was called out in #15489:

At that time, turning off Automatically adjust lightness of indistinguishable text was suggested as a fix

I have this currently set to Never

This is allegedly a font bug in Cascadia Code as this character is outside its cell

Switching font to Courier New fixes this, so might be the case this time. Not sure the render should be hacked to fix this vs. fixing the font.

Thanks for filing! This is a specific case tracked in https://github.com/microsoft/terminal/issues/15359 -- with Cascadia, the entire glyph for U+2594 starts and ends outside of the bounding box. We cut off overhangs to avoid specifically box-drawing and shade characters leaking outside of their cells. This of course doesn't work well with this design for U+2594 ☹
/dup #15359 (since it tracks dealing with character overhangs better than we do currently)


Translations don't work in datagrid toolbars

Hi, we have an issue translating our ORO-CRM instance. Despite setting the default language to French (or German) after updating the respective translation package, the datagrid toolbar items are still shown in English.
I can reproduce this behaviour on your demo system at http://demo.orocrm.com/ as you can see on this screenshot:

I traced it down to the localized JS (e.g. http://demo.orocrm.com/js/translation/fr_FR.js ), in which items from the domain "jsmessages" are still english:
...
"jsmessages:oro_datagrid.label_add_filter":"Manage filters",
"jsmessages:oro_datagrid.action.reset":"Reset",
"jsmessages:oro_datagrid.action.refresh":"Refresh"
...

Am I missing a crucial step or is this really a translation bug?
Thanks,
best regards,
Christian

Hi @cawolf,
Yes, this looks like a bug. We'll make a fix in the upcoming release.
Thank you for highlighting this.

Hi @akuzmenko-magecore,
I see the fix made it into the 1.7 release - that's great! :)
Thank you very much,
best regards,
Christian


DBZ-5015 Get the json value of a Document when parsing signaling message

Incremental snapshots on a MongoDB connector are broken. In the signaling table you are expected to provide json in the data (ex: "data": { "data-collections": ["database.collection"] }) that specifies which tables to make the snapshot. However when parsing that data using Document.parse and looping over the values of the fields, if it finds nested json will be treated as another Document. Just calling the .toString() on that will not give the value in json. We need the resulting string for that field to be in json still as there is another json parser later in the method Signal.process

@chadthman Applied, thanks!


Support  Yinxiang Biji, the China special Version

https://www.yinxiang.com/

Please support yinxiang (Evernote China)
There is no option for yinxiang account to login when Region & Language is English on Ubuntu while Chinese language works.

same issue

need this feature as well

same here, this may be a good choice for Chinese ubuntu user

+1

我把作者的代码FORK 后,修改了其中操作地址, 现在已经可以支持访问印象笔记.
https://github.com/cyrnicolase/whatever
下载后, 安装好node_modules 就可以build 出支持印象笔记的情况

指定whatever用中文环境就好了。
$ cat /opt/Whatever/ever.sh
export LANG=zh_CN.UTF-8
export LANGUAGE=zh_CN
export LC_CTYPE=zh_CN.UTF-8
export LC_NUMERIC="zh_CN.UTF-8"
export LC_TIME="zh_CN.UTF-8"
export LC_COLLATE="zh_CN.UTF-8"
export LC_MONETARY="zh_CN.UTF-8"
export LC_MESSAGES="zh_CN.UTF-8"
export LC_PAPER="zh_CN.UTF-8"
export LC_NAME="zh_CN.UTF-8"
export LC_ADDRESS="zh_CN.UTF-8"
export LC_TELEPHONE="zh_CN.UTF-8"
export LC_MEASUREMENT="zh_CN.UTF-8"
export LC_IDENTIFICATION="zh_CN.UTF-8"
export LC_ALL="zh_CN.UTF-8"
whatever

@atfa I cannot find this path, should I create a new .sh file?

@atfa I cannot find this path, should I create a new .sh file?

I have switched to another app named "tusk"，you can try it. https://github.com/klauscfhq/tusk

@atfa I cannot find this path, should I create a new .sh file?

I have switched to another app named "tusk"，you can try it. https://github.com/klauscfhq/tusk

does "tusk" can support chinese input method? i only can input English

@cellardoor42  应该是你输入法配置的问题


Change MISO Default Timezone

Did they, uh, move?

😂 no but i believe their api returns EST weather or not it's daylight savings time, so this is undoing me trying to handle that when i first implemented it


Revert change in deso math and ReadUvarint

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#1348  👈
#1308 : 1 other dependent PR (#1342 )
#1334
feature/proof-of-stake

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @lazynina and the rest of your teammates on  Graphite


Questions about Primer EZ

https://nn.labml.ai/transformers/primer_ez/index.html
130        self.query = nn.Sequential(self.query, SpatialDepthWiseConvolution(self.d_k))
I think there may exist a bug if we use cache because the ``conv'' op has time-dependency.
In Multi-head-Attention, we first project the query, key, value, and add cache if it exists, then we use the conv op.
So, Using the Sequential directly may cause a bug.

Our implementation doesn't support caching.


Graph Valid Tree

File(s) Modified: 261-Graph-Valid-Tree.swift
Language(s) Used: swift
Submission URL: _https://leetcode.com/submissions/detail/813568936/_

Thanks for contributing!


luci-theme-bootstrap: Buttons at Status/Overview/Associated Stations hard to use

Steps to reproduce:

go to: Network → Wireless → Edit (one of your Wireless Networks) → Interface Configuration → MAC Filter
set "Allow all except listed"
add a MAC (probably not necessary for reproducing) in MAC-List
Save
Save & Apply

Actual behavior:
go to: Status/Overview/Associated Stations
The Buttons on the right side of every associated station now are not just Buttons labelled "Disconnect" but a combination of Button and Combo box roughly divided into two halves by a vertical line.
The left part contains the text "Disc" while the right one is empty except a Combo box arrow close to the vertical line.

The Combo box contains the items "Disconnect" and "Add to Blacklist".

Opening the Combo box is quite hard since just a relatively small area around the arrow triggers that behaviour - clicking at the most parts of the button just disconnects immediately instead of opening the Combo box.

Expected behavior:
A Button/Combo box layout like e.g. the "Save & Apply" Button would be more clear.

Additional Information:
luci-theme-bootstrap git-22.047.35373-cc582eb

Please attach a screenshot

Done.
I did't know it was possible and so easy.
On 21.02.22 23:15, Jo-Philipp Wich wrote:

Please attach a screenshot
—
Reply to this email directly, view it on GitHub
https://github.com/openwrt/luci/issues/5693#issuecomment-1047263615,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AX3J5FAZOGUA4JL47W7RFHDU4K2QJANCNFSM5O7VEIMQ.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID:
@.***>

Which version of OpenWrt is that? Did you upgrade individual LuCI components?

Was able to reproduce it. Fix pushed.

I have
openwrt-21.02.1-ath79-generic-tplink_archer-c6-v2-squashfs-factory.bin
installed.
Powered by LuCI openwrt-21.02 branch (git-21.295.67054-13df80d) /
OpenWrt 21.02.1 r16325-88151b8303
The problem existed in this version already, so I updated to
luci-theme-bootstrap git-22.047.35373-cc582eb - which did not solve the
problem.
Nothing else.
On 21.02.22 23:36, Jo-Philipp Wich wrote:

Which version of OpenWrt is that? Did you upgrade individual LuCI
components?
—
Reply to this email directly, view it on GitHub
https://github.com/openwrt/luci/issues/5693#issuecomment-1047273396,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AX3J5FBP5YNN7OUU46CTS4DU4K45JANCNFSM5O7VEIMQ.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID:
@.***>


Validation Error: "AttributeError: 'NightEdgeSegmentation' object has no attribute 'multiscale'"

When training, in validation step, i got this error
Traceback (most recent call last):
File "train_edge.py", line 506, in
trainer.train_edge()
File "train_edge.py", line 316, in train_edge
mIoU = self.ms_val(iteration)
File "train_edge.py", line 375, in ms_val
for i, batch_data in enumerate(tqdm(self.val_loader, ascii= True)):
File "/home/mmlab/miniconda3/envs/fdlnet/lib/python3.8/site-packages/tqdm/std.py", line 1181, in iter
for obj in iterable:
File "/home/mmlab/miniconda3/envs/fdlnet/lib/python3.8/site-packages/torch/utils/data/dataloader.py", line 633, in next
data = self._next_data()
File "/home/mmlab/miniconda3/envs/fdlnet/lib/python3.8/site-packages/torch/utils/data/dataloader.py", line 1345, in _next_data
return self._process_data(data)
File "/home/mmlab/miniconda3/envs/fdlnet/lib/python3.8/site-packages/torch/utils/data/dataloader.py", line 1371, in _process_data
data.reraise()
File "/home/mmlab/miniconda3/envs/fdlnet/lib/python3.8/site-packages/torch/_utils.py", line 644, in reraise
raise exception
AttributeError: Caught AttributeError in DataLoader worker process 0.
Original Traceback (most recent call last):
File "/home/mmlab/miniconda3/envs/fdlnet/lib/python3.8/site-packages/torch/utils/data/_utils/worker.py", line 308, in _worker_loop
data = fetcher.fetch(index)
File "/home/mmlab/miniconda3/envs/fdlnet/lib/python3.8/site-packages/torch/utils/data/_utils/fetch.py", line 51, in fetch
data = [self.dataset[idx] for idx in possibly_batched_index]
File "/home/mmlab/miniconda3/envs/fdlnet/lib/python3.8/site-packages/torch/utils/data/_utils/fetch.py", line 51, in
data = [self.dataset[idx] for idx in possibly_batched_index]
File "/home/mmlab/huycq/FDLNet/core/data/dataloader/night_edge.py", line 100, in getitem
output = self._val_ms_transform(img, mask)
File "/home/mmlab/huycq/FDLNet/core/data/dataloader/segbase.py", line 132, in _val_ms_transform
for scale in self.multiscale:
AttributeError: 'NightEdgeSegmentation' object has no attribute 'multiscale'
I don't see any attribute called multiscale, can you check it for me, thanks

I found that in the paper the multiscale are [0.5, 0.75, 1.0, 1.25, 1.5, 1.75], maybe the codes missing those values ?

sorry for the confusion, I forgot to add this in the code. By the way, you can run the eval.py or train_edge.py with "mode="val"" , since multiscale infertence is time-consuming.


Slack reactions

add slack websocket for fetching +1 reactions as upvotes
don't show -1 button next to owned props

Related issue: #52

LGTM 👍

@pharmaceutics could you take a look again? Only last 3 commits, please :)

Looks good :)


chore(NODE-5829): update driver dependencies for 6.4.0

Description
Update dev, prod, and peer dependencies in the driver to latest safe and compatible versions + ones with minimal code changes.
What is changing?
Dependency Update
No Peer Dependency Updates until next major release
Dev Dependency Updates
@aws-sdk/credential-providers  ^3.465.0  →   ^3.515.0
 @microsoft/api-extractor        ^7.38.4  →    ^7.40.6
 @octokit/core                    ^4.2.4  →     ^5.1.0
 @types/node                    ^20.10.3  →  ^20.11.20
 @types/semver                    ^7.5.6  →     ^7.5.7
 @types/whatwg-url               ^11.0.3  →    ^11.0.4
 eslint                          ^8.55.0  →    ^8.56.0
 eslint-plugin-import            ^2.29.0  →    ^2.29.1
 mocha                           ^10.2.0  →    ^10.3.0
 semver                           ^7.5.4  →     ^7.6.0
 socks                            ^2.7.1  →     ^2.8.1
 ts-node                         ^10.9.1  →    ^10.9.2
 tsd                             ^0.28.1  →    ^0.30.6

Production Dependency Updates
n/a at this time
Note: sinon and @types/sinon will be updated after node v16 bug fix is done in NODE-5942
Is there new documentation needed for these changes?
No.
What is the motivation for this change?
QOL

Release Highlight

Double check the following

[x] Ran npm run check:lint script
[x] Self-review completed using the steps outlined here
[x] PR title follows the correct format: type(NODE-xxxx)[!]: description

Example: feat(NODE-1234)!: rewriting everything in coffeescript

[x] Changes are covered by tests
[x] New TODOs have a related JIRA ticket

here's what I see locally:
Package                           Current   Wanted  Latest  Location                                       Depended by
@microsoft/api-extractor           7.38.5   7.40.5  7.40.5  node_modules/@microsoft/api-extractor          node-mongodb-native
@types/sinon                      10.0.20  10.0.20  17.0.3  node_modules/@types/sinon                      node-mongodb-native
@typescript-eslint/eslint-plugin   5.62.0   5.62.0   7.0.2  node_modules/@typescript-eslint/eslint-plugin  node-mongodb-native
@typescript-eslint/parser          5.62.0   5.62.0   7.0.2  node_modules/@typescript-eslint/parser         node-mongodb-native
chai                               4.3.10    4.4.1   5.1.0  node_modules/chai                              node-mongodb-native
chalk                               4.1.2    4.1.2   5.3.0  node_modules/chalk                             node-mongodb-native
eslint                             8.55.0   8.56.0  8.56.0  node_modules/eslint                            node-mongodb-native
eslint-config-prettier             8.10.0   8.10.0   9.1.0  node_modules/eslint-config-prettier            node-mongodb-native
eslint-plugin-import               2.29.0   2.29.1  2.29.1  node_modules/eslint-plugin-import              node-mongodb-native
eslint-plugin-prettier              4.2.1    4.2.1   5.1.3  node_modules/eslint-plugin-prettier            node-mongodb-native
eslint-plugin-simple-import-sort   10.0.0   10.0.0  12.0.0  node_modules/eslint-plugin-simple-import-sort  node-mongodb-native
eslint-plugin-unused-imports        2.0.0    2.0.0   3.1.0  node_modules/eslint-plugin-unused-imports      node-mongodb-native
gcp-metadata                        5.3.0    5.3.0   6.1.0  node_modules/gcp-metadata                      node-mongodb-native
kerberos                          MISSING    2.1.0   2.1.0  -                                              node-mongodb-native
prettier                            2.8.8    2.8.8   3.2.5  node_modules/prettier                          node-mongodb-native
sinon                              15.2.0   15.2.0  17.0.1  node_modules/sinon                             node-mongodb-native
ts-node                            10.9.1   10.9.2  10.9.2  node_modules/ts-node                           node-mongodb-native
tsd                                0.28.1   0.28.1  0.30.5  node_modules/tsd                               node-mongodb-native
typescript                          5.0.4    5.3.3   5.3.3  node_modules/typescript                        node-mongodb-native

sinon its types types are okay to leave for now, we have https://jira.mongodb.org/browse/NODE-5942
chalk I think is esmodule only now
chai is esmodule only now
typescript can be left alone

ts-node, tsd, api-extractor can probably be upgraded (as per discussions on other PRs)

what about all the eslint plugins?
did you mean to update @aws-sdk/credential-providers? the PR description says no peer dependencies were updated

@baileympearson
I did mean to update the aws-sdk peer dependency, per this slack conversation (i've added a clarification in the PR description).
The eslint-prettier updates cause import errors on my end.

@aditi-khare-mongoDB Let me know if anything is blocking the changes I requested

@baileympearson @nbbeeken
You're right no peer updates, the updated dependencies are the following (only dev dependencies, no prod easily upgradable atm), and I've deleted my duplicate follow-up ticket since Neal's filed NODE-5693 already.
@aws-sdk/credential-providers  ^3.465.0  →   ^3.515.0
@microsoft/api-extractor        ^7.38.4  →    ^7.40.6
@octokit/core                    ^4.2.4  →     ^5.1.0
@types/node                    ^20.10.3  →  ^20.11.20
@types/semver                    ^7.5.6  →     ^7.5.7
@types/whatwg-url               ^11.0.3  →    ^11.0.4
eslint                          ^8.55.0  →    ^8.56.0
eslint-plugin-import            ^2.29.0  →    ^2.29.1
mocha                           ^10.2.0  →    ^10.3.0
semver                           ^7.5.4  →     ^7.6.0
socks                            ^2.7.1  →     ^2.8.1
ts-node                         ^10.9.1  →    ^10.9.2
tsd                             ^0.28.1  →    ^0.30.6


nx584 sometimes freezes on startup and get stuck until restart.

Home Assistant release with the issue:

Last working Home Assistant release (if known):
Operating environment (Hass.io/Docker/Windows/etc.):

Integration:

Description of problem:
Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):

Traceback (if applicable):

Additional information:
I think this happen when there is some other component that takes time to start or has an error,  and when a segment in the alarm is changes when homeassistant starts.

Could you please fill out the issue template provided @zipperten?
All the needed information is missing at this point, which makes it hard to do anything.
Also, if you have, some logs would be helpful.


MGDOBR-445: Update generated SDK due to openapi changes

This PR is built on top of #6 and is dependent on changes in 5733d9e2be6485d52ffa08870cabdee0/sandbox#436
Due to the dependencies, this PR is out of date, demonstrates just "kind of changes", but to see final changes we need to:

merge 5733d9e2be6485d52ffa08870cabdee0/sandbox#436
merge #6

For more details see:

https://issues.redhat.com/browse/MGDOBR-445

@kelvah @vpellegrino @manstis I think this is now worth to review. Please notice quite a lot very similar model files named like inline-response2XXX.ps. That seems to me as worth to investigate in future. I reported https://issues.redhat.com/browse/MGDOBR-471.

@kelvah well I am fine with both approaches. If MGDOBR-420 is not blocking you form other work, I I am fine to keep it open, and addressing your comments.


OffloadActivations MemCpy Stream Sync behavior

We are using the OffloadActivations context manager with separate streams and pinned memory but currently don't see any overlap between the streams.
The default stream has a D2H transfer (which is a cudaMemcpyAsync followed by a cudaStreamSynchronize as described here. We observed that if we use pinned memory for activation offloading and transfer that in a separate stream, the cudaStreamSync on the default stream would block, leading to no overlap.
Our current hypothesis for this is due to implicit synchronization semantic, specifically a page-locked (i.e. pinned) host memory allocation issued before the cudaStreamSync on the default stream would lead to cudaStreamSync block on that stream. So our conjecture is offloading using pinned memory is NOT pre-allocating pinned memory but rather allocate that on the fly which forces other stream sync to be blocking.
Is this behavior expected and is our hypothesis on why this is happening correct? If so, is there any way to have offloading done using preallocated pinned memory instead of allocating pinned
memory on the fly to avoid this synchronization?
Thanks! Happy to answer any further questions/share profile traces.

Thanks for investigating it and sharing this info! @janeyx99 is our PoC for offloading. She is currently on vacation, so we may not hear back from her for a few days.

Hi @amogkam thanks for sharing your detailed findings on the issue. To piggyback on @felipemello1's comment, in the meantime we can debug some as well. A couple questions/comments for you:

are you just running the OffloadActivations context manager with use_pin_memory=True and use_streams=True, or are you doing some additional customization beyond that?
regarding your offer to share profile traces, that would be quite helpful, and
is there a simple repro we can use to observe the same behavior you mentioned? (e.g. using one of our default configs)

Hi @ebsmothers, @felipemello1 thanks for getting back!

Yes I am running just OffloadActivations context manager with those 2 args set.

Yes let me create a small example with profile traces and I will get back to you.

Hello! I just got back and would love to parse through what could be happening here:

We observed that if we use pinned memory for activation offloading and transfer that in a separate stream, the cudaStreamSync on the default stream would block, leading to no overlap.

 Or does the "transfer that in a separate stream" imply that you added some changes to the initial code itself that is causing the behavior?

So our conjecture is offloading using pinned memory is NOT pre-allocating pinned memory but rather allocate that on the fly which forces other stream sync to be blocking.

It is correct that the use_pin_memory flag does NOT pre-allocate pinned memory but indeed allocates on the fly when packing tensors to move to CPU. https://github.com/pytorch/torchtune/blob/main/torchtune/training/_activation_offloading.py#L173 However! We do have a CUDAHostAllocator that will cache these memory blocks so that future iterations will run as if the memory was pre-allocated. Either way, I haven't noticed this failing to overlap properly in other examples. One thing you can try is turning use_pin_memory = False and observing whether that makes a difference.
And a quick q to rule out: are you observing this just for the first iteration or for every iteration? The first iteration usually takes longer because it is doing all the memory allocation/setup that will be cached later. So it is common to observe worse performance for the first step and to not use that as a benchmark.
All in all, if you don't see overlap with the original code for OffloadingActivations, that is strange but could be due to either:

we messed something up xD (and we should fix it) OR
the CPU is not running ahead enough (the GPU doesn't have enough workload) so having multiple streams in the GPU doesn't do much
Either way, having a trace is critical in figuring out which it is!


inline_threshold kwarg not changing result of SingleHdf5ToZarr call

I'm trying to create a reference dict with inlined data, but the inline_threshold argument to SingleHdf5ToZarr doesn't seem to be doing anything. I feel like I'm missing something obvious.
In [1]: import xarray as xr

In [2]: ds = xr.tutorial.open_dataset('air_temperature')

In [3]: ds.to_netcdf('air.nc')
/Users/tom/miniconda3/envs/dev3.11/lib/python3.12/site-packages/IPython/core/interactiveshell.py:3548: SerializationWarning: saving variable air with floating point data as an integer dtype without any _FillValue to use for NaNs
  exec(code_obj, self.user_global_ns, self.user_ns)

In [4]: from kerchunk.hdf import SingleHdf5ToZarr

In [5]: refs = SingleHdf5ToZarr('air.nc', spec=1, inline_threshold=0).translate()

In [6]: refs_inlined = SingleHdf5ToZarr('air.nc', spec=1, inline_threshold=1e9).translate()

In [7]: refs == refs_inlined
Out[7]: True

I was expecting these two dictionaries to be different - refs_inlined to have actual data values in it.

I just ran your example with kerchunk==0.2.2 and got inlining and refs == refs_inlined to be False. @TomNicholas just to check, were you running kerchunk==0.2.4?
Unless this is behavior is expected, it seems like there might be an issue with in-lining introduced in 0.2.3.

I used
In [9]: kerchunk.__version__
Out[9]: '0.2.2.post55'

What does that post55 even mean?

No idea! We could try pinning 0.2.2 and running the test suite.

The CI in https://github.com/TomNicholas/VirtualiZarr/actions/runs/8572561510/job/23495399856?pr=73 looks like it created a references dict with no inlining (i.e. the same behaviour that I see locally). And that's with kerchunk=0.2.4

kerchunk<=0.2.2 worked. kerchunk>=0.2.3 failed to create inlining.

Let's make a reproducer in the form of a test. This rings a bell, something I thought I had fixed.

The code above is a reproducer of the bug.
I would be happy to make a PR, but I would need guidance on how to actually fix the bug.

I just came to this issue and tried to reproduce the original issue on main. It works as expected there, but I did see the behavior that Tom is describing on 2.3.0 and 2.4.0. Seems likely that it was fixed here: https://github.com/fsspec/kerchunk/pull/432 which was just after the 2.4.0 release.
I wrote a test with a little subset of air.nc (ds.sel(time="2014-10", lat=slice(100, 50), lon=slice(250, 300)))


stern customer -c customer runs but no logs are streamed down

Setup
Win 10 / Virtual Box / openshift v3.11.0+6c2b013-59) / minishift v1.26.1+1e20f27
Referce to
https://redhat-developer-demos.github.io/istio-tutorial/istio-tutorial/1.0.0/2deploy-microservices.html#deploycustomer
stern customer -c customer run as admin/admin
Issue
The command
stern customer -c customer
runs but no logs are streamed down
Solution
the command should be
stern customer-1-7bml8 -c customer -n tutorial
where customer-1-7bml8 is the pod name selected by
oc get pods -n tutorial  | grep -E "STATUS|Running"

@jerzy-wachowiak I have tried to reproduce in MacOs but no luck, it worked perfectly. In fact, reading stern docs I see that says that the pod can be a pod query, so I am not sure if it can be the version of stern you are using or something like that.  I have created a PR https://github.com/redhat-developer-demos/istio-tutorial/pull/169 can you review to see if it works in your case? If it works then I will merge the change.

@lordofthejars
[1 ] I use https://github.com/wercker/stern/releases/download/1.10.0/stern_windows_amd64.exe and there is an option "-n" for k8s namespace
λ stern -h
Tail multiple pods and containers from Kubernetes

Usage:
  stern pod-query [flags]

Flags:
      --all-namespaces             If present, tail across all namespaces. A specific namespace is ignored even if specified with --namespace.
      --color string               Color output. Can be 'always', 'never', or 'auto' (default "auto")
      --completion string          Outputs stern command-line completion code for the specified shell. Can be 'bash' or 'zsh'
  -c, --container string           Container name when multiple containers in pod (default ".*")
      --container-state string     If present, tail containers with status in running, waiting or terminated. Default to running. (default "running")
      --context string             Kubernetes context to use. Default to current context configured in kubeconfig.
  -e, --exclude strings            Regex of log lines to exclude
  -E, --exclude-container string   Exclude a Container name
  -h, --help                       help for stern
      --kubeconfig string          Path to kubeconfig file to use
  -n, --namespace string           Kubernetes namespace to use. Default to namespace configured in Kubernetes context
  -o, --output string              Specify predefined template. Currently support: [default, raw, json] (default "default")
  -l, --selector string            Selector (label query) to filter on. If present, default to ".*" for the pod-query.
  -s, --since duration             Return logs newer than a relative duration like 5s, 2m, or 3h. Defaults to 48h.
      --tail int                   The number of lines from the end of the logs to show. Defaults to -1, showing all logs. (default -1)
      --template string            Template to use for log lines, leave empty to use --output flag
  -t, --timestamps                 Print timestamps
  -v, --version                    Print the version and exit

[2] You can skip in stern the -n option if you before have selected the "tutorial" namespace. You can reproduce it this way
λ oc login -u admin -p a
Login successful.

You have access to the following projects and can switch between them with 'oc project <projectname>':

    default
    istio-operator
    istio-system
    kube-dns
    kube-proxy
    kube-public
    kube-system
  * myproject
    openshift
    openshift-apiserver
    openshift-controller-manager
    openshift-core-operators
    openshift-infra
    openshift-node
    openshift-service-cert-signer
    openshift-web-console
    tutorial

Using project "myproject".

C:\Tools
λ oc get pods -n tutorial
NAME                        READY     STATUS      RESTARTS   AGE
customer-1-7bml8            2/2       Running     6          1d
customer-1-build            0/1       Completed   0          1d
preference-v1-1-build       0/1       Completed   0          23h
preference-v1-1-jhldg       2/2       Running     6          23h
recommendation-v1-1-7clfx   2/2       Running     6          23h
recommendation-v1-1-build   0/1       Completed   0          23h
C:\Tools
λ stern customer-1-7bml8 -c customer

C:\Tools
λ stern customer-1-7bml8 -c customer -n tutorial
+ customer-1-7bml8 › customer
customer-1-7bml8 customer Starting the Java application using /opt/run-java/run-java.sh ...
customer-1-7bml8 customer exec java -Xms128m -Xmx256m -Djava.net.preferIPv4Stack=true -javaagent:/opt/jolokia/jolokia.jar=config=/opt/jolokia/etc/jolokia.properties -javaagent:/opt/prometheus/jmx_prometheus_javaagent.jar=9779:/opt/prometheus/prometheus-config.yml -XX:+UseParallelGC -XX:GCTimeRatio=4 -XX:AdaptiveSizePolicyWeight=90 -XX:MinHeapFreeRatio=20 -XX:MaxHeapFreeRatio=40 -XX:+ExitOnOutOfMemoryError -cp . -jar /deployments/customer.jar
...

If you do this
C:\Tools
λ oc project tutorial
Now using project "tutorial" on server "https://<IP_ADDRESS>:8443".

C:\Tools
λ stern customer-1-7bml8 -c customer
+ customer-1-7bml8 › customer
customer-1-7bml8 customer Starting the Java application using /opt/run-java/run-java.sh ...
customer-1-7bml8 customer exec java -Xms128m -Xmx256m -Djava.net.preferIPv4Stack=true -javaagent:/opt/jolokia/jolokia.jar=config=/opt/jolokia/etc/jolokia.properties -javaagent:/opt/prometheus/jmx_prometheus_javaagent.jar=9779:/opt/prometheus/prometheus-config.yml -XX:+UseParallelGC -XX:GCTimeRatio=4 -XX:AdaptiveSizePolicyWeight=90 -XX:MinHeapFreeRatio=20 -XX:MaxHeapFreeRatio=40 -XX:+ExitOnOutOfMemoryError -cp . -jar /deployments/customer.jar
customer-1-7bml8 customer I> No access restrictor found, access to any MBean is allowed
...

it works as the namespace "tutorial" is set implicit by the command before

Ok, but in my case also it works when I do not specify the pod name, but a pod-query


Compiler cannot determine that only one branch of router! macro runs

The router! macro expands to a series of if statements instead of an if ... else if ... else chain or a match statement. This means that the compiler cannot tell that only a single handler can run, and so the compiler will complain about values being used multiple times if they are moved into route handlers.

Changing the macro like this appears to fix it:
     _ => $default:expr $(,)*) => {
        {
            let request = &$request;

            // ignoring the GET parameters (everything after `?`)
            let request_url = request.raw_url();
            let request_url = {
                let pos = request_url.find('?').unwrap_or(request_url.len());
                &request_url[..pos]
            };

            $(
                if request.method() == stringify!($method) {
                    router!(__param_dispatch request_url, $url_pattern => $handle ; $($param: $param_type),*)
                } else
            )+

            {
                $default
            }
        }
    };


chore: re-enable tests for Firefox related to fixed Input.dispatchMouseEvent issues

Fixes issue #7175. With the patch on https://bugzilla.mozilla.org/show_bug.cgi?id=1740798 landed in Firefox Nightly the related tests are no longer failing.

There are more 7 tests which are passing now. \o/

Woa! it's great!

@OrKoN checks for the merge of main are all fine. Now it's waiting for your review before it can auto-merge.


Use Optimization.OptimizationProblem() to find optimal fit of parameters

Hi Maxime,
could you help me to understand, what needs to be done to use the output of your
function EquivalentCircuits.objectivefunction()
in the optimization package Optimization.jl?
Please have a look on my code:
EC_optimisation_via_evolution_strategy.jl
Regards,
Stefan

The Optimization.jl package requires the function to be optimized to have two inputs, but the objectivefunction() outputs a function that only takes one input. You can solve this as follows:

Implement a version of objectivefunction() that outputs a function with two inputs (one of which will be unused):

function objectivefunction_2input(circuitfunc,measurements,frequencies,weights=nothing)
    if isnothing(weights) ; weights = ones(length(frequencies)) ; end
    function objective(x,p)
        model_output = [circuitfunc(x,fr) for fr in frequencies]
        return  mean(weights .* (abs.(measurements - model_output).^2)./(abs.(measurements).^2 .+ abs.(model_output).^2))
    end
    return objective
end

Adjust the function that does the parameter optimisation to the syntax of Optimization.jl:

using Optimization, OptimizationCMAEvolutionStrategy, OptimizationEvolutionary

function parameopt(circuitstring::String,measurements,frequencies,method)
    elements = foldl(replace,["["=>"","]"=>"","-"=>"",","=>""],init = denumber_circuit(circuitstring))
    initial_parameters = EquivalentCircuits.flatten(EquivalentCircuits.karva_parameters(elements));
    circfunc = circuitfunction(circuitstring)
    objective = objectivefunction_2input(circfunc,measurements,frequencies)
    lower = zeros(length(initial_parameters))
    upper = get_parameter_upper_bound(circuitstring)

    prob = OptimizationProblem(objective, init_params,SciMLBase.NullParameters(),lb = lower , ub = upper)
    parameters = solve(prob, method)

    return parameters
end

After these adjustments, it should work, for example:
method_ = Evolutionary.CMAES(μ = 40, λ = 100)
parameopt("R1-L2-[P3,R4]-[P5,R6]-[P7,R8]",Z_data,frequ_data,method_)

Note that I removed the second optimisation fine-tuning step for clarity. You can copy-paste it from the original parameteroptimisation function if you need it.
Regards,
Maxime

Hi Maxime,
thanks for the quick response :-)
Another tip came from Fredrik Bagge Carlson:
obj = (x, p) -> objective(x)

https://discourse.julialang.org/t/equivalent-circuit-optimization/93907/8
P.S.:
Unfortunately, the package Optimization.jl seem to be quite buggy.
I have not manged to use the variant ".ES":
https://docs.sciml.ai/Optimization/stable/optimization_packages/evolutionary/
https://wildart.github.io/Evolutionary.jl/stable/es/
Following call crashes on my machine:
sol = solve(prob, Evolutionary.ES(μ = 40, λ = 100))

or:
sol = solve(prob, Evolutionary.ES(μ = 40, ρ = 3, λ = 100)) # three parents have one offspring


Use latest MDP version 3.3.21

Resolves a bug where content wouldn't show on pages displaying validation errors
Working in deployed form

Superseded


Support horizontal scaling of weaviate

Goal
To support very large workloads we want to make sure weaviate can be scaled horizontally
What's preventing us?
Weaviate is mostly a stateless application, however, at the moment two things are keeping us from achieving horizontal scalability:

Weaviate writes into the local file system. These files describe the schema state of the database. If a database has already been initialized, but weaviate is missing this information it will not be able to start up
To change the schema we need to lock database access (including reads). This (distributed) lock must be shared by all replicas of weaviate

@bobvanluijt The PR (#702) is now ready :)

wonderful


Better error message for required fields not fulfilled

The error currently just tells us there's something missing but it would be very useful if told what is missing.

Ah, I think this is the same issue I ran into. I made a small PR #126 that lists missing fields during chat submit validation, is it relevant? @anovazzi1

Oh that's really nice, i will test your pr locally and merge it asap.  Thanks a lot 👍


fix: Changed the label order for a few components to fix accessibilit…

…y tests, resolves #1163
Closes IBM/carbon-components-react#
#1163
Changelog
Changed
We are now showing labels before components to fix accessibility testing issues.

This is a duplicate of the work in the following PR:  https://github.com/IBM/carbon-components-react/pull/1151


Freeway ModuleNotFoundError: No module named 'checkmac' and No module named 'netaddr'

Describe the bug
Cant run script
To Reproduce
So i tried 2 times.
In the first one i used sudo pip install 3way and i get an error
Traceback (most recent call last):
  File "/usr/local/lib/python3.10/dist-packages/FreewayTools/monitor.py", line 15, in <module>
    from FreewayTools.checkmac import check_manufacturer
  File "/usr/local/lib/python3.10/dist-packages/FreewayTools/checkmac.py", line 2, in <module>
    from netaddr import EUI
ModuleNotFoundError: No module named 'netaddr'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/bin/Freeway", line 16, in <module>
    from FreewayTools.colors import cprint, iprint, wprint, cinput, ColorCodes
  File "/usr/local/lib/python3.10/dist-packages/FreewayTools/__init__.py", line 4, in <module>
    from .monitor import Monitor
  File "/usr/local/lib/python3.10/dist-packages/FreewayTools/monitor.py", line 17, in <module>
    from checkmac import check_manufacturer
ModuleNotFoundError: No module named 'checkmac'

Then i deleted all, and used second way to download through clonning, and get the same error.
Thats it!
How to fix it?

Please try this,
Manually install Freeway using:
$ sudo pip install netaddr
$ sudo pip install .


External url

Is your feature request related to a problem? Please describe.
Not able to add lite speed server
Describe the solution you'd like
Please add option for external url too for generating strm file
Like xyz.com/2021/video/
Kodi has option for http open index directory but lite speed server is not supported ,with this strm files it will be possible to index and stream data
Additional context
Sorry if asking for too much

Hi,
This repository is a small script I wrote to supplement the existing Google Drive Add-on for Kodi.
As such, this script is not really an add-on by itself, but instead, helps generate strm files that can then be parsed by the Google Drive Add-on.
If you want the add-on to support more features, or lite speed server, you should instead raise an issue at the repository  for the Google Drive Add-on.
tl;dr: This repository has nothing to do with Kodi, instead it supplements an existing Kodi add-on. As such, this script can't bypass/overcome the limitations of the add-on. Since the Google Drive add-on does not support strm files outside Google Drive, neither does this script.
Closing this issue since it isn't related to this repository.

Hi,
This repository is a small script I wrote to supplement the existing Google Drive Add-on for Kodi.
As such, this script is not really an add-on by itself, but instead, helps generate strm files that can then be parsed by the Google Drive Add-on.
If you want the add-on to support more features, or lite speed server, you should instead raise an issue at the repository  for the Google Drive Add-on.
tl;dr: This repository has nothing to do with Kodi, instead it supplements an existing Kodi add-on. As such, this script can't bypass/overcome the limitations of the add-on. Since the Google Drive add-on does not support strm files outside Google Drive, neither does this script.
Closing this issue since it isn't related to this repository.


Where does CAPSLOCK come from?

Less an issue and more of a plain question - where does the magic value for the capslock modifier come from?
https://github.com/coldfix/setcapslock/blob/master/setcapslock.c#L8
I see you've hardcoded it to 2 (i.e. (1<<1)) and it happens to work for me also, but I'm dubious as to where it comes from.

Hey! Good question. I think, this is due to LockMask in X11/X.h:
/* Key masks. Used as modifiers to GrabButton and GrabKey, results of QueryPointer,
   state in various key-, mouse-, and button-related events. */

#define ShiftMask		(1<<0)
#define LockMask		(1<<1)
#define ControlMask		(1<<2)
#define Mod1Mask		(1<<3)
#define Mod2Mask		(1<<4)
#define Mod3Mask		(1<<5)
#define Mod4Mask		(1<<6)
#define Mod5Mask		(1<<7)

/* modifier names.  Used to build a SetModifierMapping request or
   to read a GetModifierMapping request.  These correspond to the
   masks defined above. */
#define ShiftMapIndex		0
#define LockMapIndex		1
#define ControlMapIndex		2
#define Mod1MapIndex		3
#define Mod2MapIndex		4
#define Mod3MapIndex		5
#define Mod4MapIndex		6
#define Mod5MapIndex		7

I checked level 0 (Shift), 1 (CapsLock), 2 (Control), 3 (Left-Alt), 6 (Mod4/Windows/Super), 7 (Mod5/AltGr/Right-Alt) which is consistent with the definitions here. (I wouldn't recommend trying those unprepared, these are even less fun than capslock!)
But to be completely honest, I copied the constant from other web sources back then, e.g. here, here or here and just made it into a small utility easy to install without deeper understanding. For a more worked out approach, see the numlockx source, which deals with symbolic names of virtual modifier levels. So, maybe the numlockx devs know more about this topic.

Ahhh; I seeee. It's called Lock, not CapsLock, which is why I didn't find it.
As to numlockx - yes, that's what I'm asking for in fact. numlockx doesn't currently do capslock, because capslock doesn't have an atom name, it's hardcoded. I was looking for the constant in a header file that would contain it, hence my question.


How to logout?

I've successfully logged in to the application, but how can I log out to reconfigure the settings?

I've successfully logged in to the application, but how can I log out to reconfigure the settings?

Hi,
(In case you're still logged in, 1 year straight :-) ) you can logout through "Profile" => LOGOUT


Choose buckets

Why is it necessary to upload the apks to a gs bucket instead of using the ones on the provided path directly?
Another thing, are there plans to support other kind of buckets? My current CI saves the apks on a s3 bucket on aws, it would be nice to fetch than from there and not needing to replicate them to gs://<>
The last thing, is there a CONTRIBUTING.md guide somewhere or is just to fork and make a PR with the desired feature?

Why is it necessary to upload the apks to a gs bucket instead of using the ones on the provided path directly?

It's expensive in terms of time if we use the apks from the local file system. Every shard would have to upload the test and app apk again. This also introduces flakiness since each additional network request is another chance for failure.

Another thing, are there plans to support other kind of buckets?

Bucket support is limited to what Google's gcloud CLI tool allows.

The path to the application binary file. The path may be in the local filesystem or in Google Cloud Storage using gs:// notation.
https://cloud.google.com/sdk/gcloud/reference/beta/test/android/run

The last thing, is there a CONTRIBUTING.md guide somewhere

We should add a contributing guide. It's probably better to open an issue first for any desired features before submitting a PR. Otherwise you may add a feature that isn't a good fit for the project (for example decreasing performance and stability by uploading the apks every time).

Also make sure you are using master since the apk uploading logic has changed. We're now matching the gcloud CLI behavior in terms of storage paths.

Ok, thanks for the answers, I'll open an issue with the desired feature!


Prefetch example broken

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Open the example at https://codesandbox.io/s/github/tannerlinsley/react-query/tree/master/examples/prefetching

Expected behavior
The example should run.
Screenshots

Additional context
The example doesn't have axios added to its dependencies.
I can create a PR and add it if you want.

A Pr would be great!

Oh, I'm too late 😅
Closed by #791


Implements the handle element.

It makes it possible to define the handle property, so the draggable is only triggered from this element.
Feel free to ignore this feat. if you think it's not interesting.
Regards

A simple example can be found here.

Looks great - thanks for the contribution @daniloprates!


Access to View Controller

Hi, I have a little issue, when I implement the drawer and the menu bar. I can't have access to my original ViewController. I try to tap on my subviews and I can't have user Interaction. How can I fix it. I know it's simple but my brain is not working anymore, and it could be nice if you can help me.

Hi must add storyboard id, like this sample
let rootController = storyboard.instantiateViewController(withIdentifier: "navigationmain") as! MainNavigationController2
this case is UINavigationController

hi!
Please explain more clearly, same problem :(  I can't have access to my original ViewController

replace ====================
"let mainVC = UIViewController()"
to =========================
let mainVC = UIStoryboard(name: "Main", bundle: Bundle.main).instantiateViewController(withIdentifier: "ViewController") as! UIViewController
it's working


fixed check for \n\n not allways done

hi. i observed that sometimes asterisk sends the second line feed in a separate package. in this cases i believe this implementation does not complete the initialisation of the call resulting in zombie channels. what's your take on it?

@schwarsi thanks

@namtzigla my pleasure. will there be a new release to npm soon?

Pushed 0.0.9 to npm repository.


accept: too many open files issue

Hi, I'm using ssh forwarding and after a while on my client I get this error:
accept4: too many open files

Server:
gost -L=ssh://:22000

Client:
gost -L tcp://:54321/xx.xxx.xx.xx:54321 -F=ssh://xx.xxx.xx.xx:22000?ping=60

gost Version ?


Bad Fast5 - Half of total reads

Hi,
I am trying to run nanopolish on my dataset. Everything seem to be going fine until the consensus step. The nanopolish indexing seem to be fine. I get all the expected files after indexing with the message:
$ nanopolish index -d Post_Run_Fast5/ -s sequencing_summary.txt XL280_Post_run.fastq
[readdb] indexing Post_Run_Fast5/
[readdb] num reads: 1611286, num reads with path to fast5: 1611286.
It generates 4 files:
XL280_Post_run.fastq.index
XL280_Post_run.fastq.index.fai
XL280_Post_run.fastq.index.gzi
XL280_Post_run.fastq.index.readdb
The alignment works fine and I get a bam file - I have tried both bwa and minimap2 for this step but it did not seem to make any difference. The bam file is not empty - I made sure of that.
Then I ran the following command for consensus calling:
$ nanopolish_makerange.py XL280_10.contigs.fasta | parallel --results nanopolish.results -P 8 nanopolish variants --consensus -o polished.{1}.vcf -w {1} -r XL280_Post_run.fastq -b XL280.bwa-sorted.bam -g XL280_10.contigs.fasta -t 4
Thats when I run into issues and I get the output like this -
[post-run summary] total reads: 5580, unparseable: 0, qc fail: 0, could not calibrate: 0, no alignment: 0, bad fast5: 2790
[post-run summary] total reads: 5748, unparseable: 0, qc fail: 0, could not calibrate: 0, no alignment: 0, bad fast5: 2874
[post-run summary] total reads: 5794, unparseable: 0, qc fail: 0, could not calibrate: 0, no alignment: 0, bad fast5: 2897
[post-run summary] total reads: 6100, unparseable: 0, qc fail: 0, could not calibrate: 0, no alignment: 0, bad fast5: 3050
[post-run summary] total reads: 6122, unparseable: 0, qc fail: 0, could not calibrate: 0, no alignment: 0, bad fast5: 3061
[post-run summary] total reads: 5602, unparseable: 0, qc fail: 0, could not calibrate: 0, no alignment: 0, bad fast5: 2801
Exactly half of the reads seem to be bad. Despite that, I get .vcf files - each of which is just 1 kb and does not have any information.
I looked into the nanopolish results folder and open individual folders. I find three files, two of which seem to have some errors that look like this:
seq file -
$ /path/to/folder/nanopolish.results/1/tig00000003:0-50200/seq ; exit;
/path/to/folder/nanopolish.results/1/tig00000003:0-50200/seq: line 1: 1: command not found
logout
Saving session...
...copying shared history...
...saving history...truncating history files...
...completed.
[Process completed]
stderr file:
$ /path/to/folder/nanopolish.results/1/tig00000003:0-50200/stderr ; exit;
/path/to/folder/nanopolish.results/1/tig00000003:0-50200/stderr: line 1: [post-run: command not found
logout
Saving session...
...copying shared history...
...saving history...truncating history files...
...completed.
[Process completed]
I am not sure what is wrong. Any suggestions? Thank you.

That's odd, can you paste a few lines from the XL280_Post_run.fastq.index.readdb file?
Jared

Hi Jared,
Thanks for replying. Here are some lines from readdb file:
000003cc-8535-4714-ba59-4449543f10b5	Post_Run_Fast5//recovered_6b80c12e-c340-44d1-8ef8-e30a520a8f3f_327.fast5
00002044-c846-4095-9074-a7a97eb98cfd	Post_Run_Fast5//recovered_6b80c12e-c340-44d1-8ef8-e30a520a8f3f_371.fast5
0000222a-72a6-4721-9bf1-0d26c696ba56	Post_Run_Fast5//recovered_6b80c12e-c340-44d1-8ef8-e30a520a8f3f_289.fast5
000025e7-a43d-4d8b-a44b-e4ca4ae79fb7	Post_Run_Fast5//recovered_6b80c12e-c340-44d1-8ef8-e30a520a8f3f_269.fast5
00002c1c-bfc0-4bfd-ac80-83c6cbffb75f	Post_Run_Fast5//recovered_6b80c12e-c340-44d1-8ef8-e30a520a8f3f_405.fast5
00003627-ff0a-457e-9947-bc3aa5a17246	Post_Run_Fast5//recovered_6b80c12e-c340-44d1-8ef8-e30a520a8f3f_372.fast5
00003f5f-71e4-4b71-b59c-a8c4ab41e121	Post_Run_Fast5//recovered_6b80c12e-c340-44d1-8ef8-e30a520a8f3f_217.fast5
000046be-7ae4-456d-82e6-107d673dc082	Post_Run_Fast5//recovered_6b80c12e-c340-44d1-8ef8-e30a520a8f3f_180.fast5
00004cfd-a8e1-420f-904b-3c73cb5f658d	Post_Run_Fast5//recovered_6b80c12e-c340-44d1-8ef8-e30a520a8f3f_85.fast5
00004e98-cc3a-43f0-826e-3697eeace1e9	Post_Run_Fast5//recovered_6b80c12e-c340-44d1-8ef8-e30a520a8f3f_434.fast5
00005168-885a-4a43-8a39-b7c5897877f8	Post_Run_Fast5//recovered_6b80c12e-c340-44d1-8ef8-e30a520a8f3f_248.fast5
000058d5-8d36-4f9f-a6fa-e83c688e3ce5	Post_Run_Fast5//recovered_6b80c12e-c340-44d1-8ef8-e30a520a8f3f_239.fast5
00005efc-3487-47f8-85e9-fa30489d1238	Post_Run_Fast5//recovered_6b80c12e-c340-44d1-8ef8-e30a520a8f3f_142.fast5
0000617f-f22d-4603-9e09-47cae66602a0	Post_Run_Fast5//recovered_6b80c12e-c340-44d1-8ef8-e30a520a8f3f_144.fast5
00006a1c-ca0f-4493-a558-8a7dec5ce6cd	Post_Run_Fast5//recovered_6b80c12e-c340-44d1-8ef8-e30a520a8f3f_25.fast5
0000743a-ba4a-4fc7-aee1-e6a8beb7b0ac	Post_Run_Fast5//recovered_6b80c12e-c340-44d1-8ef8-e30a520a8f3f_354.fast5
00007d8f-4046-41da-8dcd-db357e4af878	Post_Run_Fast5//recovered_6b80c12e-c340-44d1-8ef8-e30a520a8f3f_31.fast5
00009273-c34b-437b-99a3-b1cd60dd9f0b	Post_Run_Fast5//recovered_6b80c12e-c340-44d1-8ef8-e30a520a8f3f_308.fast5
0000969d-ec4f-4adc-9f3d-204c64e210b5	Post_Run_Fast5//recovered_6b80c12e-c340-44d1-8ef8-e30a520a8f3f_224.fast5
00009761-974e-4364-b5dc-b9d9babe2d60	Post_Run_Fast5//recovered_6b80c12e-c340-44d1-8ef8-e30a520a8f3f_224.fast5
00009871-0358-42ad-bf87-012df02c5ef0	Post_Run_Fast5//recovered_6b80c12e-c340-44d1-8ef8-e30a520a8f3f_107.fast5
0000ad1f-1fcd-487b-9fb8-6293d9451100	Post_Run_Fast5//recovered_6b80c12e-c340-44d1-8ef8-e30a520a8f3f_415.fast5
0000bc76-e47d-46a0-8f04-610985f6d4af	Post_Run_Fast5//recovered_6b80c12e-c340-44d1-8ef8-e30a520a8f3f_61.fast5
0000c8f2-4f61-484a-ba57-2d2e72d958c9	Post_Run_Fast5//recovered_6b80c12e-c340-44d1-8ef8-e30a520a8f3f_362.fast5
0000cb69-ab2a-4b9e-8a74-482df82ec779	Post_Run_Fast5//recovered_6b80c12e-c340-44d1-8ef8-e30a520a8f3f_195.fast5
0000e0c8-dc9c-4ed3-b11d-d4f0cbd13146	Post_Run_Fast5//recovered_6b80c12e-c340-44d1-8ef8-e30a520a8f3f_413.fast5
Vikas

Hi,
I am experiencing the same type of issue did you happened to find a solution ?
nanopolish variants --min-flanking-sequence 10 -x 1000000 --progress -t 1 --reads /home/genomique-avl12/Sortie_Resultats/TEST/articNcovNanopore_sequenceAnalysisNanopolish_articGuppyPlex/20210916-COVIDSEQ174_barcode03.fastq -o 20210916-COVIDSEQ174.nCoV-2019_2.vcf -b 20210916-COVIDSEQ174.trimmed.rg.sorted.bam -g /home/genomique-avl12/Sortie_Resultats/Test2/nCoV-2019/V3/nCoV-2019.reference.fasta -w "MN908947.3:1-29904" --ploidy 1 -m 0.15 --read-group nCoV-2019_2
[post-run summary] total reads: 15540, unparseable: 0, qc fail: 0, could not calibrate: 0, no alignment: 0, bad fast5: 7770

Hi,
Please see here: https://github.com/jts/nanopolish/issues/908#issuecomment-865078582
Jared

Hi Jared,
I run into the same problem. The problem you cited in #908 was kind of different from mine. I got
[readdb] num reads: 900132, num reads with path to fast5: 900132
but I still got exactly half of the fast5 bad after I ran eventalign:
[post-run summary] total reads: 395136, unparseable: 0, qc fail: 0, could not calibrate: 0, no alignment: 0, bad fast5: 197568
I double check all my past fast5 and fastq files. No duplication was found. I have not been able to find any ways to fix this issue. Do you have any suggestions?
Thanks,
Ricky

Hello,
I am experiencing the same problem when I try to run nanopolish call-methylation.
I map all of my 159,952 reads with winnowmap. Then I select only the reads mapping on a specific genomic region and save them in a separate REGION.fastq file (with 44,194 reads) as well as in a separate REGION.sorted.bam file.
Then I run
nanopolish index -v -d $FAST5DIRECTORY REGION.fastq
After indexing:
[readdb] num reads: 159,952, num reads with path to fast5: 159,952
The .readdb file contains 159,952 lines, which corresponds to the total amount of reads in my dataset. Interestingly, all reads are indexed, not only the ones I had subselected in the REGION.fastq file. In any case, it seems all reads can find the corresponding fast5 information.
Then I run:
nanopolish call-methylation -r REGION.fastq -b REGION.sorted.bam -g $REFDIR/$REFNAME > output.methylation_calls.tsv
And I get this:
[post-run summary] total reads: 33320, unparseable: 0, qc fail: 0, could not calibrate: 0, no alignment: 0, bad fast5: 16660
The "bad fast5" is exactly half of the "total reads" number. The output output.methylation_calls.tsv file does not have any methylation calls, it is just the header without any other lines.
In addition, I struggle to understand why 33320 reads are taken into account, when my input fastq file has 44194 reads.
I doublechecked that my fastq or fast5 are not duplicated. Maybe I am misunderstanding something of how this tool work.
If anybody has found any solution that would be really helpful.
Thanks
Ric

Hi @NuriaDiaz,
Could you start a new issue for your specific situation, and include the relevant output messages?
Thanks,
Jared

For anyone lands on this issue, in version 0.13.2 the total reads would be double counted: https://github.com/jts/nanopolish/issues/1022#issuecomment-1191790613. Please use the latest version to avoid this issue.


How to clean build files?

All the clap-plugin files are built inside /usr/local/lib, but there is no way to "uninstall" or "clean" them. I've tried sudo cmake --build --preset ninja-system --target clean, but it is not working fine.

I'm not aware of a uninstall function.
Usually it isn't an issue as this is done by a package manager.
You could install it again to see the list of files which are installed and then use that to cleanup.


Release/0.34.0

have you taken a detailed look of the CI failures? @cqc-alec

have you taken a detailed look of the CI failures? @cqc-alec

There is one known test failure due to #443 and three timeouts in the main suite. The example notebooks also seem to have timed out. (We probably need to find another way to test those.)


Typography tweaks

Old
New

Fixes #61

Thanks for the review @fofr! Can you take another look and approve if the latest commit has addressed your comments?


tailwind.css file? does not exists.

tailwind.css file does not exist.

https://daisyui.com/docs/add-themes
In the documentation it mentions this file but it doesn't exist.

@LeonardoDaLuz That would be your main CSS file that Tailwind generates.
The file name can be anything: global.css, style.css, etc...
But the CSS file content is:
@tailwind base;
@tailwind components;
@tailwind utilities;

or
@import "tailwindcss/base";
@import "tailwindcss/components";
@import "tailwindcss/utilities";

more info: https://tailwindcss.com/docs/installation#include-tailwind-in-your-css

I forgot to thank you. This UIKit/Framework is spectacular. Much better than a bootstrap! And it changed my way of thinking about layouts. Thanks!


[Field] Adding the possibility to show or hide the label

[Field] Adding the possibility to show or hide the label
Description
Adding the possibility to display or hide a field's label by giving a prop hasLabel which is a boolean type.
It is, by default, set to true.

Fixes #114

@Ephrame are you ok with this ?

@Ephrame @TomGallon I'm was thinking with @TomGallon about a solution and we a agree with this :
isRaw and displayLabel (props)
Considering the issue, we have think about a solution even for the futur

A fieldFor should have :

a displayLabel (boolean which should treat (in term of design) but hide the label for a field. This would let the space which was the label's place if it's set to false.

a isRaw prop which could give the possibility to display the component as it is given, without design treatment.

Problem : how raw do we want it ?
Still meditating with you, I'm asking this question : how raw do we want it ?
I've tested some cases

case 1 :

case 2 :

case 3 :

So I've updated the field component for the case it's a list.

What we have now
We can now give 2 new props on the field's options when it's declared :

displayLabel which keeps the normal display but without the label/title by keeping the default space

isRaw which only keep the raw list component but displays it as it's given

What was already ther
There was a prop called textOnly. It's still there.


[Feature Request] 关于日期时间选择器

Existing Component
是
Component Name
DatePicker
Description
固定分钟步长，例如设置分钟的步长为15分钟，目前组件没有这个属性可以操作

The configuration of TimePicker is expected to also take effect in DateTimePicker.
The current type="datetimerange" configurable items are incomplete and lack practicality. I hope the configuration of the previous two components (TimePicker and DatePicker) will be perfect.
For example, the step in the Time Select Options of TimePicker

yes，确实没有，只能改动源码然后发包，我看有人这么做了https://github.com/Ducr/DateTimePickerPro/blob/master/src/picker/time-picker.js


generated hooks don't take defaultOptions of your client into account

Describe the bug
In my Apollo client i have set defaultOptions with an errorPolicy: 'all' for query and mutation which is used to prevent the treewalker to actually throw an error on any ssr Error :)
But the generated hook doesn't use these defaults at al,l while if i simply use useQuery from their package it works correctly. I didnt look further in the code but wanted to file the bug first
To Reproduce
Use defaultOptions in your Apollo client
    const client = new ApolloClient({
        cache,
        resolvers: {},
        ...SNIP
        queryDeduplication: true,
        defaultOptions: {
            mutate: {
                errorPolicy: 'all',
            },
            query: {
                errorPolicy: 'all',
            },
        },
    });

Now let one of your queries throw an error on graphql side. Normally the error should be picked up. But when using the generated hook it will not pick it up and literally throw the error while treewalking.

My codegen.yml config file:

schema:
    - 'https://SNIP/graphql'
overwrite: true
require:
    - ts-node/../../codegen-interpreter.ts
documents:
    [
        './src/common/**/*.graphql.ts',
        './src/graphql/queries/*.ts',
        './src/graphql/fragments/*.ts',
    ]
config:
    namingConvention:
        enumValues: change-case#upperCase
generates:
    src/graphql/_generated-types.ts:
        config:
            noNamespaces: true
            avoidOptionals: true
        plugins:
            - add: "/* THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY. */\n"
            - 'typescript'
            - 'typescript-operations'
    src/graphql/_generated-hooks.tsx:
        plugins:
            - add: "/* eslint-disable */\n/* AUTO GENERATED, DO NOT EDIT OVERHERE */"
            - typescript
            - typescript-operations
            - typescript-react-apollo
        config:
            reactApolloVersion: 2
            reactApolloImportFrom: '@apollo/react-hooks'
            withComponent: false
            withHOC: false
            withHooks: true
            avoidOptionals: true
    src/graphql/_generated-fragment-types.ts:
        plugins:
            - 'fragment-matcher'

Expected behavior
Having the client defaultOptions being the default options :)
Environment:
        "@graphql-codegen/add": "1.12.2",
        "@graphql-codegen/cli": "1.12.2",
        "@graphql-codegen/fragment-matcher": "1.12.2",
        "@graphql-codegen/schema-ast": "1.12.2",
        "@graphql-codegen/time": "1.12.2",
        "@graphql-codegen/typescript-operations": "1.12.2",
        "@graphql-codegen/typescript-react-apollo": "1.12.2",
        "@graphql-codegen/typescript-resolvers": "1.12.2",

I have to see why now i see it correctly, maybe its not an issue :(

i did too many changes at once, not reflecting update. Should have restarted the damn server :)

@maapteh I'm running into this issue as well. What was the solve for you?

If anyone else is using graphql-code-generator to generate hooks, this resolved the issue for me:
config: {
  withHooks: true,
  defaultBaseOptions: {
    // Your options here
  },
}

The issue occurs because the generated file overwrites the options passed to hooks with whatever you pass or don't pass in with defaultBaseOptions.


Block images initial setup and styling

Description

picture tags in images block are placed in figure tags
if images block has a caption (italic text in block), caption is placed in figcaption
if images block has a link, picture is wrapped in a

Related Issue
#6
Motivation and Context
semantically link images to captions, mimic blog initial styling
Screenshots (if appropriate):
images block with caption and link

images block with side-by-side images with captions (2- and 3-column supported)

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have signed the Adobe Open Source CLA.
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

** caption functionality and styling will be moved out of blocks/images in a more applicable PR


Banned key being simulated in cli.py causes validate_keystrokes error message spam

I should deal with banned keys a bit more elegantly before reaching the KeyGenerator

I just added an if statement inside the rare clause that was catching the banned key. Closing this.


ci: :arrow_up: update semantic-release to v22

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (2a85e11) 100.00% compared to head (deec46f) 100.00%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff            @@
##              main      #352   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            7         7
  Lines          164       164
  Branches        30        30
=========================================
  Hits           164       164

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Fix routing issue

Why: Home and Pull Requests routes were not working
Fix: Removed redundant Router from App component

You're already including BrowserRouter in index.js. Adding another instance of the router in App was preventing your top level routes from functioning properly.

thanks for this @shishir-srivastava

You're welcome, @Pau1fitz ! :)


import --typescript generates duplicate interface property, when source uses differing case (i.g. snack_case and camelCase)

Description of the bug:
After running the CDK8s import command to generate types for the Postgres-Operator's postgresql.yaml manifest, it generated a few duplicate types. For example podPriorityClassName was duplicated.
i.g.
 /**
   * deprecated
   *
   * @schema PostgresqlSpec#pod_priority_class_name
   */
  readonly podPriorityClassName?: string;

  /**
   * @schema PostgresqlSpec#podPriorityClassName
   */
  readonly podPriorityClassName?: string;

It looks like this can be reproduced when the imported file has duplicate property names in different casing styles.
Here's what the import command is trying to translate:
pod_priority_class_name:
    type: string
    description: deprecated
podPriorityClassName:
    type: string

Link to source manifest code:
https://github.com/zalando/postgres-operator/blob/7d4da928726b5029f72e9ab83ee9b6ff481e70c7/manifests/postgresql.crd.yaml#L353-L357
Reproduction Steps:
Can be reproduced using the postgresql.crd.yaml CRD from Postgres-Operator
curl https://raw.githubusercontent.com/zalando/postgres-operator/7d4da928726b5029f72e9ab83ee9b6ff481e70c7/manifests/postgresql.crd.yaml -o ./postgresql.crd.yaml

Then run the import command:
cdk8s import --language typescript postgresql:=./postgresql.crd.yaml
# outputs postgresql-acid.zalan.do.ts

Then open the generated file at postgresql-acid.zalan.do.ts and search for podPriorityClassName (line 217) which belongs to the PostgresqlSpec interface. Notice how it's right next to a duplicate definition.
Error Log:
When running tsc:
src/imports/postgresql-acid.zalan.do.ts:217:12 - error TS2300: Duplicate identifier 'podPriorityClassName'.

217   readonly podPriorityClassName?: string;
               ~~~~~~~~~~~~~~~~~~~~
src/imports/postgresql-acid.zalan.do.ts:222:12 - error TS2300: Duplicate identifier 'podPriorityClassName'.

222   readonly podPriorityClassName?: string;
               ~~~~~~~~~~~~~~~~~~~~

Environment:

Framework Version: CDK8s CLI: v2.0.13
OS: Monterey v12.4

Other:

This is :bug: Bug Report

We're facing the same issue with a source CRD of https://raw.githubusercontent.com/prometheus-operator/prometheus-operator/v0.59.1/example/prometheus-operator-crd/monitoring.coreos.com_servicemonitors.yaml
Here we find this list:
[...]
enum:
- replace
- Replace
- keep
- Keep
[...]

Is there any solution or workaround currently, other than removing the duplicate entries from the list in the CRD?

This should already be fixed. See https://github.com/cdklabs/json2jsii/pull/1259.
Other duplicates in this issue will be resolved once https://github.com/cdk8s-team/cdk8s-cli/pull/2721 is merged.


MaglevLoadBalancer consistent hashing implementation is NOT stable

Title: MaglevLoadBalancer consistent hashing implementation is NOT stable
Description:
The MaglevLoadBalancer builds a lookup table (LUT) of consistent hashing routes using an algorithm that hashes hostnames/hashKeys/etc for each host. An important prerequisite for this algorithm to be consistent is that the input vector of hosts are in a stable order.  This requirement isn't well stated in the Maglev paper (Google's Borg always uses ordinal replicas, and it's somewhat assumed in the paper: B0, B1, B2, ...), but here is another reference implementation that first string sorts the hosts before building the LUT.
The Envoy implementation does not build the LUT from a stable list of hosts. The order of hosts can change due to unrelated system dynamics. When the order of hosts does change, the Maglev LUT changes slightly.
The impact is small, so I am not so surprised this bug was previously missed. The order of hosts mostly doesn't matter, except in the case where two hosts share very similar preferences for a LUT entry in their permutation lists. If two hosts contend for the same LUT entry within a single iteration, the order of hosts does matter to tie break and decide which host "wins" the LUT entry (order of entries in this loop).
From simulations (see below), approx 20 out of 65537 LUT entries change when permutating the order of 6 hosts (i.e. there are 20 "tiebreaks" between the 6 hosts). This translates to 1-in-3000 (0.03%) keys routing differently whenever the host order changes. Whilst this seems small, it is definitely a painful correctness bug for systems with hard consistency requirements.
A stable host order is not a requirement for the RingHashLoadBalancer algorithm. It is not impacted.
Repro steps:

Use Maglev load balancing
Use dynamic endpoint discovery of 6 hosts (I used EDS, but DNS may work too)
Enable upstream=trace logging to print the Maglev lookup table whenever it updates
Remove and then re-add a host -> the order of hosts will now be changed
Observe small changes in the new Maglev lookup table (approx 22/65537 errors) even though the hostname (the key we use for consistent hashing) is unchanged - bug!
Now 1-in-3000 keys are routed to different hosts unexpectedly

Config:

Redis proxy using a Maglev consistent hashing load balancer.
Endpoint discovery via a xDS control plane.
Six Redis endpoints

Logs:
Here is an example diff of stripped logs from two constructions of the maglev lookup table of the exact same 6 hosts. In both cases, the hostnames did not change, but the order of hosts was different due to unrelated service discovery dynamics. In this case, there are 18 out 65537 errors. (If the hostnames did change, there would be many many more diffs.)
$ diff /tmp/envoy_lut_stripped_1.txt /tmp/envoy_lut_stripped_2.txt
7143c7143
< [source/common/upstream/maglev_lb.cc:71] maglev: i=7142 address=XX.XXX.XXX.XXX:6379 host=redis-2
---
> [source/common/upstream/maglev_lb.cc:71] maglev: i=7142 address=XX.XXX.XXX.XXX:6379 host=redis-0
14323c14323
< [source/common/upstream/maglev_lb.cc:71] maglev: i=14322 address=XX.XXX.XXX.XXX:6379 host=redis-5
---
> [source/common/upstream/maglev_lb.cc:71] maglev: i=14322 address=XX.XXX.XXX.XXX:6379 host=redis-2
25561c25561
< [source/common/upstream/maglev_lb.cc:71] maglev: i=25560 address=XX.XXX.XXX.XXX:6379 host=redis-0
---
> [source/common/upstream/maglev_lb.cc:71] maglev: i=25560 address=XX.XXX.XXX.XXX:6379 host=redis-3
26572c26572
< [source/common/upstream/maglev_lb.cc:71] maglev: i=26571 address=XX.XXX.XXX.XXX:6379 host=redis-0
---
> [source/common/upstream/maglev_lb.cc:71] maglev: i=26571 address=XX.XXX.XXX.XXX:6379 host=redis-3
28330c28330
< [source/common/upstream/maglev_lb.cc:71] maglev: i=28329 address=XX.XXX.XXX.XXX:6379 host=redis-3
---
> [source/common/upstream/maglev_lb.cc:71] maglev: i=28329 address=XX.XXX.XXX.XXX:6379 host=redis-5
34846c34846
< [source/common/upstream/maglev_lb.cc:71] maglev: i=34845 address=XX.XXX.XXX.XXX:6379 host=redis-2
---
> [source/common/upstream/maglev_lb.cc:71] maglev: i=34845 address=XX.XXX.XXX.XXX:6379 host=redis-0
42811c42811
< [source/common/upstream/maglev_lb.cc:71] maglev: i=42810 address=XX.XXX.XXX.XXX:6379 host=redis-0
---
> [source/common/upstream/maglev_lb.cc:71] maglev: i=42810 address=XX.XXX.XXX.XXX:6379 host=redis-5
43034c43034
< [source/common/upstream/maglev_lb.cc:71] maglev: i=43033 address=XX.XXX.XXX.XXX:6379 host=redis-3
---
> [source/common/upstream/maglev_lb.cc:71] maglev: i=43033 address=XX.XXX.XXX.XXX:6379 host=redis-0
44178c44178
< [source/common/upstream/maglev_lb.cc:71] maglev: i=44177 address=XX.XXX.XXX.XXX:6379 host=redis-2
---
> [source/common/upstream/maglev_lb.cc:71] maglev: i=44177 address=XX.XXX.XXX.XXX:6379 host=redis-1
46285c46285
< [source/common/upstream/maglev_lb.cc:71] maglev: i=46284 address=XX.XXX.XXX.XXX:6379 host=redis-0
---
> [source/common/upstream/maglev_lb.cc:71] maglev: i=46284 address=XX.XXX.XXX.XXX:6379 host=redis-3
53595c53595
< [source/common/upstream/maglev_lb.cc:71] maglev: i=53594 address=XX.XXX.XXX.XXX:6379 host=redis-5
---
> [source/common/upstream/maglev_lb.cc:71] maglev: i=53594 address=XX.XXX.XXX.XXX:6379 host=redis-0
55287c55287
< [source/common/upstream/maglev_lb.cc:71] maglev: i=55286 address=XX.XXX.XXX.XXX:6379 host=redis-4
---
> [source/common/upstream/maglev_lb.cc:71] maglev: i=55286 address=XX.XXX.XXX.XXX:6379 host=redis-0
57384c57384
< [source/common/upstream/maglev_lb.cc:71] maglev: i=57383 address=XX.XXX.XXX.XXX:6379 host=redis-1
---
> [source/common/upstream/maglev_lb.cc:71] maglev: i=57383 address=XX.XXX.XXX.XXX:6379 host=redis-4
57429c57429
< [source/common/upstream/maglev_lb.cc:71] maglev: i=57428 address=XX.XXX.XXX.XXX:6379 host=redis-0
---
> [source/common/upstream/maglev_lb.cc:71] maglev: i=57428 address=XX.XXX.XXX.XXX:6379 host=redis-3
59122c59122
< [source/common/upstream/maglev_lb.cc:71] maglev: i=59121 address=XX.XXX.XXX.XXX:6379 host=redis-5
---
> [source/common/upstream/maglev_lb.cc:71] maglev: i=59121 address=XX.XXX.XXX.XXX:6379 host=redis-2
59863c59863
< [source/common/upstream/maglev_lb.cc:71] maglev: i=59862 address=XX.XXX.XXX.XXX:6379 host=redis-3
---
> [source/common/upstream/maglev_lb.cc:71] maglev: i=59862 address=XX.XXX.XXX.XXX:6379 host=redis-5
63646c63646
< [source/common/upstream/maglev_lb.cc:71] maglev: i=63645 address=XX.XXX.XXX.XXX:6379 host=redis-1
---
> [source/common/upstream/maglev_lb.cc:71] maglev: i=63645 address=XX.XXX.XXX.XXX:6379 host=redis-4
65386c65386
< [source/common/upstream/maglev_lb.cc:71] maglev: i=65385 address=XX.XXX.XXX.XXX:6379 host=redis-4
---
> [source/common/upstream/maglev_lb.cc:71] maglev: i=65385 address=XX.XXX.XXX.XXX:6379 host=redis-1

Algorithm Simulations:
Here is a fragment of a simulation sweep permutating the order of 6 hosts and counting the LUT entries that change.
[...]
21/65537 errors (0.0320%) for input host list permutation [4 0 1 2 3 5]
21/65537 errors (0.0320%) for input host list permutation [0 4 1 2 3 5]
18/65537 errors (0.0275%) for input host list permutation [1 0 4 2 3 5]
18/65537 errors (0.0275%) for input host list permutation [0 1 4 2 3 5]
16/65537 errors (0.0244%) for input host list permutation [1 4 0 2 3 5]
24/65537 errors (0.0366%) for input host list permutation [4 1 0 2 3 5]
18/65537 errors (0.0275%) for input host list permutation [2 4 0 1 3 5]
18/65537 errors (0.0275%) for input host list permutation [4 2 0 1 3 5]
22/65537 errors (0.0336%) for input host list permutation [0 4 2 1 3 5]
[...]

Also, as the number of hosts increases, so does the number of "tiebreaks", and hence errors increases too. Some extreme cases:

When simulating reversing a list of 200 hosts, 1-100 LUT entries change.
When simulating reversing a list of 500 hosts, 1-50 LUT entries change.

Thanks for the really detailed report! Super interesting. The fix seems simple enough if you would like to do a PR. Thank you!

Yes glad to take a look @mattklein123

I submitted a pull request to solve this issue: https://github.com/envoyproxy/envoy/pull/28055


export Lock to User

hi @sirupsen
We use hook to rotate the log file, it works fine. But message may be lost while update the new writer without lock the writer.
It's good idea or possible to export  Logger's Lock  to user?  other suggestions?

Another option might be adding a Logger.SetOut() method which changes output with locked mutex

yeah, it make sense

Closing per the project being put into maintenance mode


Update Visual Studio default values for "silent" severity

dotnet/roslyn#27220 changed some Visual Studio default values to the "silent" severity. This should be reflected in the documentation.
Some examples of properties that now have the wrong default severity in the documentation:

dotnet_style_parentheses_in_*
dotnet_style_predefined_type_for_*
dotnet_style_prefer_auto_properties
(Most likely more)

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 410f3156-99cc-2a5c-2696-9d354c4f34c7
Version Independent ID: fe3c3dfe-251f-2585-fe18-7fae3bcc76d0
Content: .NET coding convention settings For EditorConfig - Visual Studio
Content Source: docs/ide/editorconfig-code-style-settings-reference.md
Product: visual-studio-dev15
GitHub Login: @kuhlenh
Microsoft Alias: gewarren

@ cremor @kendrahavens @sharwell There are others as well from that pull that was merged 11 Jun.  The files src/Workspaces/Core/Portable/CodeStyle/CodeStyleOptions.cs and src/Workspaces/CSharp/Portable/CodeStyle/CSharpCodeStyleOptions.cs contain the defaults.
Additional defaults with severity to silent:
csharp_style_expression_bodied_constructors
csharp_style_expression_bodied_methods
csharp_style_expression_bodied_operators
csharp_style_expression_bodied_properties
csharp_style_expression_bodied_indexers
csharp_style_expression_bodied_accessors
csharp_preferred_modifier_order
csharp_prefer_braces
dotnet_style_require_accessibility_modifiers

@kendrahavens I believe everything that was none changed to silent as the default

@sharwell I changed all the defaults that were 'none' to 'silent'. This includes some rules that weren't explicitly listed in this issue, including:

dotnet_style_qualification_for*
dotnet_style_prefer_conditional_expression_over*
csharp_style_var*

Is that correct?

These changes will go live tomorrow.


Update github.com/fsouza/go-dockerclient, and modify kubelet/dockertools to new docker.NewClientFromEnv

The only functionality update here is in pkg/kubelet/dockertools/docker.go. This uses the new go-dockerclient method NewClientFromEnv, which handles DOCKER_HOST, DOCKER_TLS_VERIFY, and DOCKER_CERT_PATH per the way that docker officially handles it.
https://github.com/fsouza/go-dockerclient/blob/933433faa3e1c0bbc825b251143f8e77affbf797/client.go#L226
https://github.com/fsouza/go-dockerclient/blob/933433faa3e1c0bbc825b251143f8e77affbf797/client.go#L790
The big diff is due to https://github.com/fsouza/go-dockerclient/pull/339, where we moved vendor to external to comply with golang 1.5 rules.

Can you have go-dockerclient as a separate commit, and changes for kubelet package in another one? Thanks!

ok to test

No problem, but it will be the godep update first as NewClientFromEnv is a
new function, is that ok?
On Thursday, August 6, 2015, Dawn Chen<EMAIL_ADDRESS>wrote:

ok to test
—
Reply to this email directly or view it on GitHub
https://github.com/GoogleCloudPlatform/kubernetes/pull/12286#issuecomment-128182275
.

Yes, that should be ok. Thanks!

@peter-edge  #12166 was merged earlier. You can rebase your pr now to have NewClientFromEnv update now. Thanks!

Ah very nice! I'll get on this tomorrow when I'm back at my computer (Sunday)

@dchen1107 closing this for https://github.com/GoogleCloudPlatform/kubernetes/pull/12471


Submit button not working when shrunk?

Reported by Erica. I can't repro.
Movie: https://nwactechcommittee.slack.com/files/U03Q5BK1FJ7/F0641MNFSTC/rpreplay_final1698952800.mp4

closing since it is a dupe


WaveFile class closes the underlying audio stream

Hello!
I don't know if that behavior is intentional but to me it does not seem completely logical. When I read an audio stream using the WaveFile class, the stream gets closed automatically afterwards by the underlying BinaryReader. Thus, when I instantiate another WaveFile object using the same Stream instance, I get this exception: "Cannot access a closed stream".
As a hint: the BinaryReader class supports leaving the stream open (see https://docs.microsoft.com/en-us/dotnet/api/system.io.binaryreader.-ctor?view=netcore-3.1#System_IO_BinaryReader__ctor_System_IO_Stream_System_Text_Encoding_System_Boolean_).
King regards from Austria!
Clemens
P.S.: I am a big fan of your work! I really like your coding style as it makes it very easy to debug.

Hi!
Yes, definitely you have a point! I simply didn't focus much on loading/saving data and I didn't consider any scenario other than "open one file -> load data -> close file -> forget about it :-)". I'll take your remark into account, and In the next version the stream won't be closed in WaveFile methods. Moreover, I think I'm going to add another overloaded constructor that will simply accept plain array of bytes as the parameter.
Thanks for your kind words! ))
Regards,
Tim

Hello again,
I've committed a fix.
A couple of notes:
While I agree that there are reasons why underlying stream should not be closed in WaveFile constructor, I don't think that your case is one of these reasons (I mean, the way you use the class). In fact, WaveFile is not intended to be a "wrapper around the stream" or to acquire any resource (and it doesn't implement IDisposable interface, for example). It's more like a "constructor of signals in memory based on data from the stream" and its lifetime is not synchronized with the stream.
Once you've constructed these signals from wav file (i.e. filled WaveFile object with data), you don't need to worry anymore about the underlying data stream, simply work with signals in memory.
Thus, there's no need to do this: (instantiate more than one WaveFile objects, if I understood you correctly):
DiscreteSignal s1, s2;

using (var stream = new FileStream("1.wav", FileMode.Open))
{
	var waveFile = new WaveFile(stream);
        s1 = waveFile[0];

	// ...

        stream.Seek(0, SeekOrigin.Begin);

        var waveFile2 = new WaveFile(stream);
        s2 = waveFile2[0];
}

The code below works OK now, however, I'd do this instead:
WaveFile waveFile;

using (var stream = new FileStream("1.wav", FileMode.Open))
{
	waveFile = new WaveFile(stream);
}

DiscreteSignal s1 = waveFile[0];
DiscreteSignal s2 = s1.Copy();	    // get the copy *before* any processing

// process s1 and s2
// ...

Regards,
Tim


docs: update the reference implementation source

[x] This PR is not from my main or master branch :poop:, but a separate branch :white_check_mark:
[x] Each commit has a valid :black_nib: Signed-off-by<EMAIL_ADDRESS>row (via git commit --signoff)
[x] Each commit and PR title has a valid :memo: <package name>: title first line subject for packages
[ ] Incremented :up: any PKG_VERSION in the Makefile
[ ] Tested on: (architecture, openwrt version, browser) :white_check_mark:
[ ] ( Preferred ) Mention: @ the original code author for feedback
[ ] ( Preferred ) Screenshot or mp4 of changes:
[ ] ( Optional ) Closes: e.g. openwrt/luci#issue-number
[ ] ( Optional ) Depends on: e.g. openwrt/packages#pr-number in sister repo
[x] Description: PR #5976 moved the location of template_lmo.c. This PR adjusts sources to changes.

Thanks


[Bug] Tabs position in RTL locales

Thank you for the awesome notepad.
Describe the bug
Tabs are mispositioned in RTL locales
To Reproduce
Change language to the newly added "العربية (اليمن) [#772] , then restart Notepads
Expected behavior
Close & Maximize & Minimize buttons should be appear on the left and the tabs on the right ideally
Screenshots

Tabs should be beside the Close & Maximize & Minimize box or ideally on the right.
also the controls and texts align should be RTL too

Desktop:

OS: [e.g. Windows 10 20H2 19042.746]
Version [e.g. v<IP_ADDRESS>]

ACK.


Query builder is using wrong id with MEMBER OF

Hello, I've a problem with forms in symfony, and I can't understand if it's related to doctrine or symfony.
I've also opened an issue with symfony in order to understand where is the problem.
I have 2 entities: user and stable. I've a table called user_for_stable with user_id and stable_id
So I've created this simple form called "CowType":
->add('stable', EntityType::class, array(
                'class'=>'AppBundle\Entity\Stable',
                'multiple'=>false,
                'expanded'=>false,
                'choice_label'=>'stableName',
                'query_builder'=> function (EntityRepository $er) use ($options) {
                    return $er->createQueryBuilder('u')
                        ->where(':userobj MEMBER OF u.users')
                        ->setParameter("userobj", $options['userObj'] );
                },
            ))

In the controller I've:
$form = $this->createForm(CowType::class, $cow, array('userObj'=>$this->getUser()));

But the generated query is wrong:
SELECT s0_.id AS id_0, s0_.address AS address_1, s0_.city AS city_2, s0_.zip AS zip_3, s0_.state AS state_4, s0_.stable_name AS stable_name_5 FROM stable s0_ WHERE EXISTS (SELECT 1 FROM user_for_stable u1_ WHERE s0_.id = u1_.stable_id AND u1_.id = ?)

it should be
SELECT s0_.id AS id_0, s0_.address AS address_1, s0_.city AS city_2, s0_.zip AS zip_3, s0_.state AS state_4, s0_.stable_name AS stable_name_5 FROM stable s0_ WHERE EXISTS (SELECT 1 FROM user_for_stable u1_ WHERE s0_.id = u1_.stable_id AND u1_.user_id = ?)

in stable entity I've:
     /**
     * @var
     * @ORM\OneToMany(targetEntity="AppBundle\Entity\UserForStable", mappedBy="stable")
     */

    private $users;

This code is working as expected:
$q= $er->createQueryBuilder('u');
                    $q->select('s')
                        ->from('AppBundle:Stable', 's')
                        ->leftJoin('s.users', 'usersInStable', 'WHERE', 'usersInStable.user = :userObj' )
                        ->setParameter('userObj', $options['userObj']);

the generated sql is
SELECT s0_.id AS id_0, s0_.address AS address_1, s0_.city AS city_2, s0_.zip AS zip_3, s0_.state AS state_4, s0_.stable_name AS stable_name_5, s0_.tav AS tav_6, s0_.kg_for_notch AS kg_for_notch_7, s0_.number_of_meal AS number_of_meal_8 FROM stable s1_, stable s0_ LEFT JOIN user_for_stable u2_ ON s0_.id = u2_.stable_id WHERE u2_.user_id = ?

Can you help me? Thanks

@bettinz can you reproduce this in a test case? You can see examples here: https://github.com/doctrine/doctrine2/tree/c816d375e8ed18964ca277d5fb178ed0b8ea2a26/tests/Doctrine/Tests/ORM/Functional

@bettinz I can't understand the issue: please reduce it:

DQL only (no query builder)
No symfony in the issue

What we basically need is:

the DQL string
the generated SQL
the expected SQL

Hello first of all, thank for the replies, I haven't created any test so far, so please understand I've to study on how to do that 😄
Basically I've that entities:

Stable, with OneToMany called users and mapped by stable in Join Table "UserForStable"
User, with OneToMany called stables and mapped by user in Join Table "UserForStable"
UserForStable with

ManyToOne user, connected to User, inversed by stables
ManyToOne stable, connected to Stable, inversed by users

What I need to check is if a user is in the list of users for that stable.
So I've used the operator MEMBER OF: is the current user MEMBER OF stable.users?
The generated sql is:
SELECT s0_.id AS id_0 FROM stable s0_ WHERE EXISTS (SELECT 1 FROM user_for_stable u1_ WHERE s0_.id = u1_.stable_id AND u1_.id = ?)

but is wrong on that part:
u1_.id=?

because need to be
u1_.user_id=?

and then
SELECT s0_.id AS id_0 FROM stable s0_ WHERE EXISTS (SELECT 1 FROM user_for_stable u1_ WHERE s0_.id = u1_.stable_id AND u1_.user_id = ?)

@bettinz it's not REALLY HARD to create tests, try to do the following:

Fork the repository and clone it (and install all dependencies, sure)
Copy a functional test that you're gonna use as example, like https://github.com/doctrine/doctrine2/blob/c816d375e8ed18964ca277d5fb178ed0b8ea2a26/tests/Doctrine/Tests/ORM/Functional/Ticket/GH6141Test.php
Map your entities there
Create some sample data inside of the test
Set the expectation and run the query (basically $this->_em->getRepository(Entity::class)->createQueryBuilder('u')->where(':userobj MEMBER OF u.users')->setParameter("userobj", $options['userObj']);)

Hello, I've created a simple project in symfony with the problem here:
https://github.com/bettinz/doctrineTest

@bettinz thanks but it doesn't really help since it doesn't isolate the ORM... could you please try to send the test as instructed?

Honestly I tried without help; I'm still learning symfony and doctrine and test is something really new. I've created this simple project with fixtures in order to help. I hope someone can help me and create a simple test based on my simple project 😃

See https://github.com/doctrine/doctrine2/blob/master/tests/Doctrine/Tests/ORM/Query/SelectSqlGenerationTest.php
An example project is not something we can work with: the "learning how" bit goes both ways

I don't know if it help or not, but I'm trying to reply your third post:
DQL:
 SELECT s.name, s.id from AppBundle:Stable s where :userobj MEMBER OF s.users

Generated sql:
SELECT s0_.name AS name_0, s0_.id AS id_1 FROM stable s0_ WHERE EXISTS (SELECT 1 FROM user_for_stable u1_ WHERE s0_.id = u1_.stable_id AND u1_.id = ?)

correct sql
SELECT s0_.name AS name_0, s0_.id AS id_1 FROM stable s0_ WHERE EXISTS (SELECT 1 FROM user_for_stable u1_ WHERE s0_.id = u1_.stable_id AND u1_.user_id = ?)

I've only found documentations on tests for doctrine 1.4. I'm sorry if I can't be useful, I'm really trying to create a test

That's clear now, thanks! We now need to figure out if the problem is in
the mapping definitions or in the DQL transformation
On 2 Feb 2017 00:31, "bettinz"<EMAIL_ADDRESS>wrote:

I don't know if it help or not, but I'm trying to reply your third post:
DQL:
SELECT s.name, s.id from AppBundle:Stable s where :userobj MEMBER OF s.users
Generated sql:
SELECT s0_.name AS name_0, s0_.id AS id_1 FROM stable s0_ WHERE EXISTS (SELECT 1 FROM user_for_stable u1_ WHERE s0_.id = u1_.stable_id AND u1_.id = ?)
correct sql
SELECT s0_.name AS name_0, s0_.id AS id_1 FROM stable s0_ WHERE EXISTS (SELECT 1 FROM user_for_stable u1_ WHERE s0_.id = u1_.stable_id AND u1_.user_id = ?)
I've only found documentations on tests for doctrine 1.4. I'm sorry if I
can't be useful, I'm really trying to create a test
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/doctrine/doctrine2/issues/6270#issuecomment-276817949,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAJakCwfxqcCpnrS4EAN1xSLDbwB2Yg2ks5rYRXlgaJpZM4LzWt4
.

Hey @bettinz, sorry for the late reply. Maybe you just need to handle User and Stable as entity in your code.
Unless you have a specific need for it, you'd better not have an object in your code to materialize this relation, https://github.com/bettinz/doctrineTest/blob/master/src/AppBundle/Entity/UserForStable.php#L13 should not be needed.
class User
{
    // ...

    /**
     *@ManyToMany(targetEntity="Stables")
     */
    private $stables;

    public function __construct()
    {
        $this->stables = new ArrayCollection();
    }
}

With only this mapping, and without creating a $users property in the Stable class, the database would still create a join table https://doctrine-orm.readthedocs.io/en/latest/reference/association-mapping.html#many-to-many-unidirectional, and it's up to you to choose to have a bi-directionnal relation.

Hello @HeahDude , I usually prefer a "Many-To-One<->One-To-Many" relation with an entity in the middle as explained here http://docs.doctrine-project.org/projects/doctrine-orm/en/latest/reference/association-mapping.html#many-to-many-unidirectional

Why are many-to-many associations less common? Because frequently you want to associate additional attributes with an association, in which case you introduce an association class. Consequently, the direct many-to-many association disappears and is replaced by one-to-many/many-to-one associations between the 3 participating classes.

In this particular case I also need some extra fields in the middle entity, and I think I can't do the work with a Many To Many.


A way to step back to previous

I'd like a way to be able to set the step back however many times I need.
For example, setting it back 1 will execute the last action, then the action after that..
Basically, a way to alter the internal counter would be fantastic. :) (but functions like previous could also be helpful)

Interesting proposal.  Comment at https://github.com/creationix/step/issues/24


Allow getting top-level authorizations in enforced mode

What
Allow getting top-level authorizations in enforced mode by replacing the recording-mode only accessor with an accessor that returns all authenticated authorizations regardless of mode.
Why
The recorded top-level authorizations accessor returns all recorded authorizations that were the first authorization in each call tree for each address. Recorded authorizations are authenticated authorizations. On that basis this functionality, accessing the list of authenticated authorizations, works for both enforced and recorded authorizations. This allows SDK developers to get access to top-level authorizations regardless of whether the environment is in recording or enforcing mode.
This is important for supporting introspecting authentication authorizations in tests where recording isn't in use, but some mocking is taking place and developers wish to also validate that their mock is in use.
I didn't add a test for this change because this function is a test utility, it doesn't appear to itself be tested, since it is something used in tests naturally.

This looks good, but shall we wait until the release with this or will you have time to update the SDK/examples before it?

I can update the examples. I'll need to update the examples due to the renames of terminology from recorded to mocked in any case and I can do this at the same time.
I think I need this to unify mock_all_auths with mock_auths so that having an accessor of auths that were seen works for both.


Add 'math' topic to relevant exercises in track config

The new site lets people filter optional exercises by topic, and this
makes it easy for people to skip past them.
This is important since the math-y exercises are not key to learning
the language, and a lot of people find them intimidating and demotivating.
This updates any 'mathematics' topics to be 'math' since it's shorter
and won't get cropped in the UI.
It also removes the math topics for any exercises that are not in the
canonical math-y list.
exercism/exercism.io#4110

@patricksjackson @LegalizeAdulthood I normalized 'mathematics' to 'math', per the discussion in the linked issue, which I think is pretty uncontroversial. This also removes the 'math' topic from triangle and roman numerals, since while they are related to math, they don't seem to be inherently about math (though... I guess "definition of triangle" could be seen as math).

I'm going to go ahead and merge this. We can always tweak in later PRs if there are any changes you think we should have.