Allow conn string via env-var; inteface keys wrapped in quotes; update nvmrc to 8.15.1

Hi 👋
I'd really like to be able to run this on a hook so I've added the ability for it to use env-vars. My thinking is this could be run in a build pipeline / after migrations via an npm script to ensure types are staying as up-to date as possible.
I also noticed the .nvmrc is behind the node version required to run it locally (doesn't work with node 6)... and noticed that the interfaces don't create properly if one of the column names starts with a number so I've wrapped them in quotes.
Run like this node src/cli.js generate -e ENV_VAR_KEY -o dbschema.ts --noHeader

Hi @rubengmurray 👋 , glad you found pg-to-ts (also curious how you found pg-to-ts!).
Just wanted to give you a heads-up that I merged #5, which cleans up and modernizes some of the tooling in this repo. In particular, all the tests should run and pass both locally and via GitHub Actions.
You changes seem fine -- I'm curious why it's important to put the connection string in an environment variable that's really a config file, though. If you want it in an environment variable, why not run the command as pg-to-ts $CONNECTION_STRING -o dbschema.ts? Or if it needs to be in a file, could you just do something like pg-to-ts $(cat connection-string.txt) -o dbschema.ts?

Hi @rubengmurray 👋 , glad you found pg-to-ts (also curious how you found pg-to-ts!).

A blog post I can't seem to re-locate at the moment. I'll try and dig it out to share. Could well have been written by you tbh.

Just wanted to give you a heads-up that I merged #5, which cleans up and modernizes some of the tooling in this repo. In particular, all the tests should run and pass both locally and via GitHub Actions.

Great, lots of 🧹. Looks like .nvmrc could still do with updating though.

You changes seem fine -- I'm curious why it's important to put the connection string in an environment variable that's really a config file, though. If you want it in an environment variable, why not run the command as pg-to-ts $CONNECTION_STRING -o dbschema.ts? Or if it needs to be in a file, could you just do something like pg-to-ts $(cat connection-string.txt) -o dbschema.ts?

My experience with accessing environment variables in the run-time has been via a .env, for which I've always used dotenv to pull in the values from. This has been the same running locally, or accessing env-vars in something like heroku. Being honest, I'm not as familiar with build pipelines config, so perhaps there is a different practice here.
But based on your comments, my thinking is:

Putting it in a text file implies I need to store that text file somewhere to access it or I need to grab that text file from somewhere else to run it.

If I'm pulling it in from somewhere, I want it to be from the same place I have it defined to connect to the database, rather than a separate text file.

Putting it in the command itself once I've grabbed it means I might expose the credentials in the build log when I run the command (if it's accepted that I print the commands i'm running out to the build log - I guess I could obfuscate this somehow).

I'd be grabbing from some exposed set of environment variables here... maybe this is where .env is not relevant?

Using $ENV_VAR without -c won't work with the current setup as -c is demanded. With -c I get an -o is not provided error.

Perhaps provided -c ${var} would be a tidier way of passing the data

What's maybe best at this juncture is for me to test this code in a build pipeline a bit more and see how it works. I've only tested this locally against a .env and not implemented even the forked script into a build pipeline yet.
Cheers the response.

I published a new version of pg-to-ts (4.0.0) that includes your changes to .nvmrc and engines (thanks!).
While I was updating yargs (the argument parser), I noticed that there were two additional ways to invoke pg-to-ts that I hadn't been familiar with:

If you specify --config path/to/config.json, it will read flags from a JSON file (or even a JS file, it uses require). So you could configure pg-to-ts using a file like {"conn": "postgres://...", "output": "path/to/output.ts"}.
You can specify any flag using an environment variable instead. Previously this would have been something like SCHEMATS_CONN but I've changed it to PG_TO_TS_CONN with 4.0.0.

I've added examples of both of these forms to the README.md. Given the latter form, we're already pretty close to being able to do what you want! You just need a way to set those environment variables.
And it looks like dotenv has you covered there. You'll just need to invoke pg-to-ts using node:
node -r dotenv/config node_modules/bin/pg-to-ts

Let me know if that works for you—from my perspective it's definitely preferable to not have to support a fourth way of passing in parameters. And if you'd like to put up a new PR that just adds the column quoting, I'll happily merge it.

Hi @danvk,
I'll try and have a look through this on the weekend, cheers.

Hi @danvk
I'm able to find a solution with a few tweaks... for me the .js isn't happy when I try and dynamically retrieve an already defined env-var inside the file... but for completeness, here's where I'm at:
{
  "pg-to-ts": "node pg-to-ts.js && pg-to-ts generate --config pg-to-ts.json"
}

// pg-to-ts.js
const dotenv = require('dotenv');
const fs = require('fs');
dotenv.config()

const obj = JSON.stringify({
  "conn": process.env.DATABASE_URL,
  "output": "/schemas.ts"
})

fs.writeFileSync('./pg-to-ts.json', obj, { encoding: 'utf-8' });

This is good enough to work with tbh, feel free to close this PR.
I'll re-raise if anything else comes up.. and I'll also look to make that slimmed down PR of the string based keys.
Cheers.

https://github.com/danvk/pg-to-ts/pull/13/files


Fibonacci sequences

Not an issue - more of a suggestion. Would be good to return an array for the fibonacci sequence, as well as the sequence at nth position (and maybe rename the nth-position fibonacciNth() or something). For example:
export default function fibonacci(steps) {
  const fibSequence = [];

  let currentValue = 1;
  let previousValue = 0;

  if(steps === 1) {
    return [1];
  }

  while(steps--) {
    currentValue += previousValue;
    previousValue = (currentValue - previousValue);

    fibSequence.push(currentValue);
  }

  return fibSequence;
}

And:
export default function fibonacciNth(steps) {
  let currentValue = 1;
  let previousValue = 0;

  if(steps === 1) {
    return 1;
  }

  while(steps--) {
    currentValue += previousValue;
    previousValue = (currentValue - previousValue);
  }

  return currentValue;
}

Also, where before there was a:
while(iterationsCounter) {
  // Do code

  iterationsCounter -= 1;
}

This is mildly verbose, and can be more succinctly written without detriment to legibility as:
while(iterationsCounter--) {
  // Do code
}

Personally I think that's more readable. Happy to do a PR?
Edit: camel cased variable names to match existing code

@ohepworthbell thank you for suggestion!
Yes please just create a PR.

Great, pull request created! Had to revert the iterationsCounter to the original loop as JSLint doesn't seem to allow unary operators

Fixed in https://github.com/trekhleb/javascript-algorithms/pull/36

Stop


Fix libunwind static linking on Android toolchains

As well as llvm-mingw with -static-libgcc
It ends up with

set(CMAKE_C_IMPLICIT_LINK_LIBRARIES "atomic;m;-l:libunwind.a;dl;c;-l:libunwind.a;dl")
set(CMAKE_CXX_IMPLICIT_LINK_LIBRARIES "windowsapp;windowsapp;ucrt;windowsapp;ucrtapp;c++;mingw32;-l:libunwind.a;moldname;mingwex;mingw32;-l:libunwind.a;moldname;mingwex")

Merged, thanks!


ionic cordova while build     use of undeclared identifier 'FIRInstanceID' am getting this error

platforms/ios/MyApp/Plugins/cordova-plugin-fcm-with-dependecy-updated/AppDelegate+FCMPlugin.m:215:7: error:
use of undeclared identifier 'FIRInstanceID'
[[FIRInstanceID instanceID] deleteIDWithHandler:handler];
^
1 error generated.
** BUILD FAILED **
The following build commands failed:
CompileC /Users/hanumantb/Library/Developer/Xcode/DerivedData/MyApp-hchilvbspocezlftfzdqggkqrecl/Build/Intermediates.noindex/MyApp.build/Debug-iphonesimulator/MyApp.build/Objects-normal/x86_64/AppDelegate+FCMPlugin.o /Users/hanumantb/Documents/titheeworking/platforms/ios/MyApp/Plugins/cordova-plugin-fcm-with-dependecy-updated/AppDelegate+FCMPlugin.m normal x86_64 objective-c com.apple.compilers.llvm.clang.1_0.compiler
(1 failure)
xcodebuild: Command failed with exit code 65
[ERROR] An error occurred while running subprocess cordova.
    cordova build ios exited with exit code 65.

@dineshmaths1 Hi! Have you found a solution for it?

any updates on this?

I solved this by
cordova plugin rm cordova-plugin-fcm-with-dependecy-updated
and then
cordova plugin add cordova-plugin-fcm-with-dependecy-updated
just need to update the version of the plugin


dart-define not working for building web target

When specifying "dartDefine" or "dartDefineMulti" in a task to build a web target, this setting is ignored. Consequently, no "--dart-define" argument gets passed to the flutter tool.
Based on a quick look at the code, passing any of the two settings to the web target build seems to simply not be implemented yet.
Compare this line for the Android target that includes "dartDefine" variables:
https://github.com/hey24sheep/azure-flutter-tasks/blob/8a3d3658143dec7c26d48a1b05311ba6623d8709/tasks/build/index.js#L71
...with this line for the web target that does not:
https://github.com/hey24sheep/azure-flutter-tasks/blob/8a3d3658143dec7c26d48a1b05311ba6623d8709/tasks/build/index.js#L79

Hi, I have fixed the code and added both the args to web and desktop builds. Updated extension will show up in few minutes.
I am closing this issue in response to latest commit 8f46389. Feel free to re-open or create a new issue in case of a problem.


Protect master branch for website

We're already hitting a few crossed wires with folks working on the same topic at the same time. Hopefully we can smooth that out in the long run, but for now I think we should definitely protect the master branch to require at least 1 review before PRs are merged.
What do folks think? What would be reasonable?

Do we have enough people available for reviewing, and with the right skill set? Reviewing the technical aspects is at the moment non-trivial. AFAIK I am the only one that is checking that it works both locally and on github pages, but even my test setup is non-ideal (since my gh-pages version has a different base_url).
For reviewing page content I agree, but I think that for technical and formatting aspects we should be able to iterate more quickly.
Ideally I would have a way to quickly check formatting of a page during review, and also to test build success/failure, since then it would be possible for reviewers to respond quickly. However, see https://github.com/travis-ci/dpl/issues/991.

If we protect the gh-pages branch (which is the default and the one being rendered), I do think that we should have a .github/CODEOWNERS file that lists who can be held responsible for a timely review. See https://github.blog/2017-07-06-introducing-code-owners/
This relates to an issue I raised some time ago on slack for the (future) agenda of the steering group: "... who is technically capable of merging and/or who feels responsible for it?".

Yep - I agree - I think this is a conversation for the community to have (beyond the steering group - but we can at least make sure it goes forwards!)
I'm very confident we have the technical skills in the BIDS community, but I'm not confident that those who have the skills know how to engage in the most helpful and constructive way. (As in, I think most people won't engage because they don't know if it's up to them or not!)

Side note - netlify does beautiful PR renderings if you want to move from gh pages (still jekyll)

Side note - netlify does beautiful PR renderings if you want to move from gh pages (still jekyll)

I think getting a rendering of each PR would be a very important feature for us! Merging into our personal forks and checking the preview is suboptimal as Robert points out (comparably high effort, and still a bit error prone).

From the 21 forks of this repository, there are only 4 that now appear to be configured for online rendering on https://username.github.io/bids-website/.
More general, without forking (or without cloning and installing your own Jekyll stack), it is not possible to do a review that includes visual inspection of the format/layout.
I suspect (and hope) that there will still be quite some formatting changes to come, especially when we add more content, which makes this even more relevant.


Make sure the restart stage cannot be used on accepted/rejected

I think this could use a test

I'm afraid we will need to come back to this one.
The changes in #397 break this. I thought I rebased the branch to run the tests, but looks like I missed this :(


Caching/Live query support

There was recently a concept explored by Marc over at https://github.com/xuorig/graphql-cache-cdc-invalidation where the strategy of invalidations/data access id's are tracked.
Could there exist a world where this is explored within async-graphql, specifically around the notion of @live query support.
Sounds like every data piece is mapped back to queries that depend on them, and those queries would be documents subscribed to by a client (more https://twitter.com/xuorig/status/1561444162091847680?s=20&t=NiXK5aAmdcOitIK-cUZJxA).
Little new to the project, and just thought perhaps there would be adaptors or something to ease this for us a little. Or probably 100% user land code, and async-graphql already helps us.
Thanks again for the lovely project 🙏🏻

It's not easy to support the live directive, and I've tried it before, but I still haven't found a good solution.

Grafbase just announced live query support, and they write their entire backend in Rust, so it might be useful to look through their code for this.


Ask user for internal/tunnel network during installation

Hi Nyr,
Thank you for the great work on developing and consistently maintaining this tool over so many years.
I'd like to suggest an improvement. Instead of using <IP_ADDRESS> as the internal network would it be possible to ask the user for this information?
The use case I have in mind is installing the script in multiple servers but connecting to these servers from a single client (pfSense) which would be routing traffic to different servers based on policies.
I'm aware I can modify the installation script for each server, but asking the user would be a much cleaner solution.
Cheers

Personally, I would like to see this as well. Maybe a menu choice like:
Choose your VPN IP range:
1) <IP_ADDRESS>/16
2) <IP_ADDRESS>/16
3) <IP_ADDRESS>/24

I recently moved to a 10./8 network at home, and that matches another VPN
network I connect to, causing issues sometimes when working from home.
On Thu, Apr 30, 2020 at 1:52 PM eBeagle<EMAIL_ADDRESS>wrote:

Hi Nyr,
Thank you for the great work on developing and consistently maintaining
this tool over so many years.
I'd like to suggest an improvement. Instead of using <IP_ADDRESS> as the
internal network would it be possible to ask the user for this information?
The use case I have in mind is installing the script in multiple servers
but connecting to these servers from a single client (pfSense) which would
be routing traffic to different servers based on policies.
I'm aware I can modify the installation script for each server, but asking
the user would be a much cleaner solution.
Cheers
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Nyr/openvpn-install/issues/753, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABTQQFQUPUKENBTJWH2SFRTRPHQKHANCNFSM4MWT26JA
.

@eBeagle I don't think that this option will be supported, I understand your particular use case but as with any other non-standard configuration, I just can't support everything.
@lukebarone of course you can configure your home network as you wish, but there is a reason why home networks don't use <IP_ADDRESS>/8 and you've just seen that. You'll never need 16 millions of hosts, while there is other software like commercial VPN software which does.
Sorry for the late response guys, but I wanted to think about it before adopting a definitive decision.


More than one AWTRIX

Thanks for the component, works flawless!
Is it possible to extend the component to handle more than one AWTRIX?
Thanks in advance!

Hello frittes updating this component to work with two awtrix is beyond my programming knowledge.
But if you connect your awtrixes to mqtt you can use this: https://github.com/lubeda/awtrix_python_script
Sorry, there is only a quick and very very dirty german "howto" available.

Works fine. Thx!


Add install

I can't use lest as cmake external project
# Here are registered all external projects
#
# Usage:
# add_dependencies(TARGET externalProjectName)
# target_link_libraries(TARGET PRIVATE ExternalLibraryName)

set(EXTERNAL_PROJECTS_PREFIX ${CMAKE_BINARY_DIR}/external-projects)
set(EXTERNAL_PROJECTS_INSTALL_PREFIX ${EXTERNAL_PROJECTS_PREFIX}/installed)

include(GNUInstallDirs)

# MUST be called before any add_executable() # https://stackoverflow.com/a/40554704/8766845
link_directories(${EXTERNAL_PROJECTS_INSTALL_PREFIX}/${CMAKE_INSTALL_LIBDIR})
include_directories($<BUILD_INTERFACE:${EXTERNAL_PROJECTS_INSTALL_PREFIX}/${CMAKE_INSTALL_INCLUDEDIR}>)

include(ExternalProject)

ExternalProject_Add(externalLest
    PREFIX "${EXTERNAL_PROJECTS_PREFIX}"
    GIT_REPOSITORY "https://github.com/martinmoene/lest.git"
    GIT_TAG "master"
    CMAKE_ARGS -DCMAKE_INSTALL_PREFIX=${EXTERNAL_PROJECTS_INSTALL_PREFIX}
    )

Build the externalLest target and you'll get error:
[ 75%] Performing install step for 'externalLest'
make[4]: *** No rule to make target 'install'.  Stop.

An example on how to achieve that https://github.com/jgaa/restc-cpp/pull/28

Thanks, will look into that.

Thanks! It works now

Thanks to you too!


[Design] Add antiforgery middleware

This new middleware participates in authentication and acts as a filter
when the request doesn't include a valid CSRF token for a POST.
Any authentication middleware that you want to validate an antiforgery
token should go ahead of this middleware in the pipeline (Cookies,
IISIntegration). This also takes care of automatic auth (Windows) done by
weblistener.
Any authentication middleware that you want to ignore antiforgery should
go after this middleware in the pipeline.
To facilitate this, there are a few changes in the antiforgery API
surface. Namely we can now pass in a principal to validate tokens. You
can't pass in a principal to generate tokens - we expect you to be logged
in at that poing. Also, ValidateRequestAsync(...) now checks the HTTP verb
and won't validate GETs and such.

Currently design-tagged as I'm still writing tests for the middleware and auth handler.

/cc @dougbu @HaoK @Tratcher

I'm still a little concerned about the ordering requirement in practice. It would be easy for people to become vulnerable by forgetting this middleware or putting it too early in the pipeline.

I'm still a little concerned about the ordering requirement in practice. It would be easy for people to become vulnerable by forgetting this middleware or putting it too early in the pipeline.

I'm not going to try to say that's not a thing, but this seems like the best of all of our options.
/cc @blowdart

So yea ordering sucks. But if we get it right in the templates that goes a long way to illustrating how to use it.
This is a general middleware problem though. If only we could check that other middlewares are already in place first.

Added tests for the middleware/handler - removed design tag. Next will be addressing feedback.

@dougbu @Tratcher @HaoK updated.
I think I've addressed all the actionable feedback - except this

Cleanup and :shipit:


Updated README.md

Just browsing GitHub and came across this project. Hope you guys are doing well!

Hello sir and good to hear from you! We're getting geared up for the annual PV trip and this is an intro python class that will be teaching at the offsite.
Hope all is well!


MudNavLink Property "IsActive" to set active element programmatically on Click event

Feature request type
Enhance component
Component name
MudNavLink
Is your feature request related to a problem?
There are cases that Href doesnt meet the requirement when navigation has to be dynamic and this case OnClick with NavigationManager is used like below.
<MudNavLink   OnClick="@(async () => await GetNavigation())"<EMAIL_ADDRESS>url</MudNavLink>

    private async Task GetNavigation()
    {
        NavigationManager.NavigateTo(dynamicUrl);
    }

but in this case active NavLink is not set and highlighting is not visible. It is possible to adjust this with Css overriding but it will be nicer this is resolved using with a property and component handles the css.
Describe the solution you'd like
IsActive=true sets the mud-nav-link.active
Have you seen this feature anywhere else?
No response
Describe alternatives you've considered
No response
Pull Request

[ ] I would like to do a Pull Request

Code of Conduct

[X] I agree to follow this project's Code of Conduct

I think the main problem here is that MudNavLink is just a wrapped for the native NavLink and it doesn't have IsActive and adding it on top of it would be an ugly workaround.


duplicate entry: com/google/android/gms/internal/measurement/zzdz.class

Something under the hood has changed with the firebase SDK, with no action on my part. I can no longer create Android builds in Unity.
CommandInvokationFailure: Gradle build failed.
/Library/Java/JavaVirtualMachines/jdk1.8.0_171.jdk/Contents/Home/bin/java -classpath "/Applications/Unity/Hub/Editor/2018.2.13f1/PlaybackEngines/AndroidPlayer/Tools/gradle/lib/gradle-launcher-4.2.1.jar" org.gradle.launcher.GradleMain "-Dorg.gradle.jvmargs=-Xmx2048m" "assembleRelease"

stderr[

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':transformClassesWithJarMergingForRelease'.
> com.android.build.api.transform.TransformException: java.util.zip.ZipException: duplicate entry: com/google/android/gms/internal/measurement/zzdz.class

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.

* Get more help at https://help.gradle.org

BUILD FAILED in 28s
]
stdout[
Starting a Gradle Daemon, 2 stopped Daemons could not be reused, use --status for details
:preBuild UP-TO-DATE
:Firebase:preBuild UP-TO-DATE
:Firebase:preReleaseBuild UP-TO-DATE
:Firebase:checkReleaseManifest
:Firebase:processReleaseManifest
:GoogleMobileAdsAppLovinMediation:preBuild UP-TO-DATE
:GoogleMobileAdsAppLovinMediation:preReleaseBuild UP-TO-DATE
:GoogleMobileAdsAppLovinMediation:checkReleaseManifest
:GoogleMobileAdsAppLovinMediation:processReleaseManifest
:GoogleMobileAdsMediationTestSuite:preBuild UP-TO-DATE
:GoogleMobileAdsMediationTestSuite:preReleaseBuild UP-TO-DATE
:GoogleMobileAdsMediationTestSuite:checkReleaseManifest
:GoogleMobileAdsMediationTestSuite:processReleaseManifest
:GoogleMobileAdsPlugin:preBuild UP-TO-DATE
:GoogleMobileAdsPlugin:preReleaseBuild UP-TO-DATE
:GoogleMobileAdsPlugin:checkReleaseManifest
:GoogleMobileAdsPlugin:processReleaseManifest
:GoogleMobileAdsTapjoyMediation:preBuild UP-TO-DATE
:GoogleMobileAdsTapjoyMediation:preReleaseBuild UP-TO-DATE
:GoogleMobileAdsTapjoyMediation:checkReleaseManifest
:GoogleMobileAdsTapjoyMediation:processReleaseManifest
:GooglePlayGamesManifest.plugin:preBuild UP-TO-DATE
:GooglePlayGamesManifest.plugin:preReleaseBuild UP-TO-DATE
:GooglePlayGamesManifest.plugin:checkReleaseManifest
:GooglePlayGamesManifest.plugin:processReleaseManifest
:unity-android-resources:preBuild UP-TO-DATE
:unity-android-resources:preReleaseBuild UP-TO-DATE
:unity-android-resources:checkReleaseManifest
:unity-android-resources:processReleaseManifest
:preReleaseBuild
:Firebase:compileReleaseAidl
:GoogleMobileAdsAppLovinMediation:compileReleaseAidl
:GoogleMobileAdsMediationTestSuite:compileReleaseAidl
:GoogleMobileAdsPlugin:compileReleaseAidl
:GoogleMobileAdsTapjoyMediation:compileReleaseAidl
:GooglePlayGamesManifest.plugin:compileReleaseAidl
:unity-android-resources:compileReleaseAidl
:compileReleaseAidl
:Firebase:packageReleaseRenderscript NO-SOURCE
:GoogleMobileAdsAppLovinMediation:packageReleaseRenderscript NO-SOURCE
:GoogleMobileAdsMediationTestSuite:packageReleaseRenderscript NO-SOURCE
:GoogleMobileAdsPlugin:packageReleaseRenderscript NO-SOURCE
:GoogleMobileAdsTapjoyMediation:packageReleaseRenderscript NO-SOURCE
:GooglePlayGamesManifest.plugin:packageReleaseRenderscript NO-SOURCE
:unity-android-resources:packageReleaseRenderscript NO-SOURCE
:compileReleaseRenderscript
:checkReleaseManifest
:generateReleaseBuildConfig
:prepareLintJar
:generateReleaseResValues
:generateReleaseResources
:Firebase:compileReleaseRenderscript
:Firebase:generateReleaseResValues
:Firebase:generateReleaseResources
:Firebase:packageReleaseResources
:GoogleMobileAdsAppLovinMediation:compileReleaseRenderscript
:GoogleMobileAdsAppLovinMediation:generateReleaseResValues
:GoogleMobileAdsAppLovinMediation:generateReleaseResources
:GoogleMobileAdsAppLovinMediation:packageReleaseResources
:GoogleMobileAdsMediationTestSuite:compileReleaseRenderscript
:GoogleMobileAdsMediationTestSuite:generateReleaseResValues
:GoogleMobileAdsMediationTestSuite:generateReleaseResources
:GoogleMobileAdsMediationTestSuite:packageReleaseResources
:GoogleMobileAdsPlugin:compileReleaseRenderscript
:GoogleMobileAdsPlugin:generateReleaseResValues
:GoogleMobileAdsPlugin:generateReleaseResources
:GoogleMobileAdsPlugin:packageReleaseResources
:GoogleMobileAdsTapjoyMediation:compileReleaseRenderscript
:GoogleMobileAdsTapjoyMediation:generateReleaseResValues
:GoogleMobileAdsTapjoyMediation:generateReleaseResources
:GoogleMobileAdsTapjoyMediation:packageReleaseResources
:GooglePlayGamesManifest.plugin:compileReleaseRenderscript
:GooglePlayGamesManifest.plugin:generateReleaseResValues
:GooglePlayGamesManifest.plugin:generateReleaseResources
:GooglePlayGamesManifest.plugin:packageReleaseResources
:unity-android-resources:compileReleaseRenderscript
:unity-android-resources:generateReleaseResValues
:unity-android-resources:generateReleaseResources
:unity-android-resources:packageReleaseResources
:mergeReleaseResources
:createReleaseCompatibleScreenManifests
:processReleaseManifest
:splitsDiscoveryTaskRelease
:Firebase:platformAttrExtractor
:GoogleMobileAdsAppLovinMediation:platformAttrExtractor
:GoogleMobileAdsMediationTestSuite:platformAttrExtractor
:GoogleMobileAdsPlugin:platformAttrExtractor
:GoogleMobileAdsTapjoyMediation:platformAttrExtractor
:GooglePlayGamesManifest.plugin:platformAttrExtractor
:unity-android-resources:platformAttrExtractor
:Firebase:generateReleaseBuildConfig
:Firebase:prepareLintJar
:Firebase:javaPreCompileRelease
:Firebase:processReleaseJavaRes NO-SOURCE
:GoogleMobileAdsAppLovinMediation:generateReleaseBuildConfig
:GoogleMobileAdsAppLovinMediation:prepareLintJar
:GoogleMobileAdsAppLovinMediation:javaPreCompileRelease
:GoogleMobileAdsAppLovinMediation:processReleaseJavaRes NO-SOURCE
:GoogleMobileAdsMediationTestSuite:generateReleaseBuildConfig
:GoogleMobileAdsMediationTestSuite:prepareLintJar
:GoogleMobileAdsMediationTestSuite:javaPreCompileRelease
:GoogleMobileAdsMediationTestSuite:processReleaseJavaRes NO-SOURCE
:GoogleMobileAdsPlugin:generateReleaseBuildConfig
:GoogleMobileAdsPlugin:prepareLintJar
:GoogleMobileAdsPlugin:javaPreCompileRelease
:GoogleMobileAdsPlugin:processReleaseJavaRes NO-SOURCE
:GoogleMobileAdsTapjoyMediation:generateReleaseBuildConfig
:GoogleMobileAdsTapjoyMediation:prepareLintJar
:GoogleMobileAdsTapjoyMediation:javaPreCompileRelease
:GoogleMobileAdsTapjoyMediation:processReleaseJavaRes NO-SOURCE
:GooglePlayGamesManifest.plugin:generateReleaseBuildConfig
:GooglePlayGamesManifest.plugin:prepareLintJar
:GooglePlayGamesManifest.plugin:javaPreCompileRelease
:GooglePlayGamesManifest.plugin:processReleaseJavaRes NO-SOURCE
:unity-android-resources:generateReleaseBuildConfig
:unity-android-resources:prepareLintJar
:unity-android-resources:javaPreCompileRelease
:unity-android-resources:processReleaseJavaRes NO-SOURCE
:compileReleaseNdk NO-SOURCE
:mergeReleaseShaders
:compileReleaseShaders
:generateReleaseAssets
:Firebase:mergeReleaseShaders
:Firebase:compileReleaseShaders
:Firebase:generateReleaseAssets
:Firebase:mergeReleaseAssets
:GoogleMobileAdsAppLovinMediation:mergeReleaseShaders
:GoogleMobileAdsAppLovinMediation:compileReleaseShaders
:GoogleMobileAdsAppLovinMediation:generateReleaseAssets
:GoogleMobileAdsAppLovinMediation:mergeReleaseAssets
:GoogleMobileAdsMediationTestSuite:mergeReleaseShaders
:GoogleMobileAdsMediationTestSuite:compileReleaseShaders
:GoogleMobileAdsMediationTestSuite:generateReleaseAssets
:GoogleMobileAdsMediationTestSuite:mergeReleaseAssets
:GoogleMobileAdsPlugin:mergeReleaseShaders
:GoogleMobileAdsPlugin:compileReleaseShaders
:GoogleMobileAdsPlugin:generateReleaseAssets
:GoogleMobileAdsPlugin:mergeReleaseAssets
:GoogleMobileAdsTapjoyMediation:mergeReleaseShaders
:GoogleMobileAdsTapjoyMediation:compileReleaseShaders
:GoogleMobileAdsTapjoyMediation:generateReleaseAssets
:GoogleMobileAdsTapjoyMediation:mergeReleaseAssets
:GooglePlayGamesManifest.plugin:mergeReleaseShaders
:GooglePlayGamesManifest.plugin:compileReleaseShaders
:GooglePlayGamesManifest.plugin:generateReleaseAssets
:GooglePlayGamesManifest.plugin:mergeReleaseAssets
:unity-android-resources:mergeReleaseShaders
:unity-android-resources:compileReleaseShaders
:unity-android-resources:generateReleaseAssets
:unity-android-resources:mergeReleaseAssets
:mergeReleaseAssets
:mergeReleaseJniLibFolders
:Firebase:compileReleaseNdk NO-SOURCE
:Firebase:mergeReleaseJniLibFolders
:Firebase:transformNativeLibsWithMergeJniLibsForRelease
:Firebase:transformNativeLibsWithStripDebugSymbolForRelease
:Firebase:transformNativeLibsWithIntermediateJniLibsForRelease
:GoogleMobileAdsAppLovinMediation:compileReleaseNdk NO-SOURCE
:GoogleMobileAdsAppLovinMediation:mergeReleaseJniLibFolders
:GoogleMobileAdsAppLovinMediation:transformNativeLibsWithMergeJniLibsForRelease
:GoogleMobileAdsAppLovinMediation:transformNativeLibsWithStripDebugSymbolForRelease
:GoogleMobileAdsAppLovinMediation:transformNativeLibsWithIntermediateJniLibsForRelease
:GoogleMobileAdsMediationTestSuite:compileReleaseNdk NO-SOURCE
:GoogleMobileAdsMediationTestSuite:mergeReleaseJniLibFolders
:GoogleMobileAdsMediationTestSuite:transformNativeLibsWithMergeJniLibsForRelease
:GoogleMobileAdsMediationTestSuite:transformNativeLibsWithStripDebugSymbolForRelease
:GoogleMobileAdsMediationTestSuite:transformNativeLibsWithIntermediateJniLibsForRelease
:GoogleMobileAdsPlugin:compileReleaseNdk NO-SOURCE
:GoogleMobileAdsPlugin:mergeReleaseJniLibFolders
:GoogleMobileAdsPlugin:transformNativeLibsWithMergeJniLibsForRelease
:Firebase:processReleaseResources
:unity-android-resources:processReleaseResources
:Firebase:generateReleaseSources
:Firebase:compileReleaseJavaWithJavac
:Firebase:transformClassesAndResourcesWithPrepareIntermediateJarsForRelease
:unity-android-resources:generateReleaseSources
:unity-android-resources:compileReleaseJavaWithJavac
:unity-android-resources:transformClassesAndResourcesWithPrepareIntermediateJarsForRelease
:GoogleMobileAdsPlugin:transformNativeLibsWithStripDebugSymbolForRelease
:GoogleMobileAdsPlugin:transformNativeLibsWithIntermediateJniLibsForRelease
:GoogleMobileAdsTapjoyMediation:compileReleaseNdk NO-SOURCE
:GoogleMobileAdsTapjoyMediation:mergeReleaseJniLibFolders
:GoogleMobileAdsTapjoyMediation:transformNativeLibsWithMergeJniLibsForRelease
:GoogleMobileAdsTapjoyMediation:transformNativeLibsWithStripDebugSymbolForRelease
:GoogleMobileAdsTapjoyMediation:transformNativeLibsWithIntermediateJniLibsForRelease
:GooglePlayGamesManifest.plugin:compileReleaseNdk NO-SOURCE
:GooglePlayGamesManifest.plugin:mergeReleaseJniLibFolders
:GooglePlayGamesManifest.plugin:transformNativeLibsWithMergeJniLibsForRelease
:GooglePlayGamesManifest.plugin:transformNativeLibsWithStripDebugSymbolForRelease
:GooglePlayGamesManifest.plugin:transformNativeLibsWithIntermediateJniLibsForRelease
:unity-android-resources:compileReleaseNdk NO-SOURCE
:unity-android-resources:mergeReleaseJniLibFolders
:unity-android-resources:transformNativeLibsWithMergeJniLibsForRelease
:unity-android-resources:transformNativeLibsWithStripDebugSymbolForRelease
:unity-android-resources:transformNativeLibsWithIntermediateJniLibsForRelease
:processReleaseJavaRes NO-SOURCE
:validateSigningRelease
:Firebase:extractReleaseAnnotations
:Firebase:mergeReleaseConsumerProguardFiles
:Firebase:transformResourcesWithMergeJavaResForRelease
:Firebase:transformClassesAndResourcesWithSyncLibJarsForRelease
:Firebase:transformNativeLibsWithSyncJniLibsForRelease
:Firebase:bundleRelease
:Firebase:compileReleaseSources
:Firebase:mergeReleaseResources
:Firebase:verifyReleaseResources
:Firebase:assembleRelease
:GoogleMobileAdsAppLovinMediation:mergeReleaseConsumerProguardFiles
:GoogleMobileAdsAppLovinMediation:transformNativeLibsWithSyncJniLibsForRelease
:GoogleMobileAdsAppLovinMediation:mergeReleaseResources
:GoogleMobileAdsAppLovinMediation:verifyReleaseResources
:GoogleMobileAdsMediationTestSuite:mergeReleaseConsumerProguardFiles
:GoogleMobileAdsMediationTestSuite:transformNativeLibsWithSyncJniLibsForRelease
:GoogleMobileAdsMediationTestSuite:mergeReleaseResources
:GoogleMobileAdsMediationTestSuite:verifyReleaseResources
:GoogleMobileAdsPlugin:mergeReleaseConsumerProguardFiles
:GoogleMobileAdsPlugin:transformNativeLibsWithSyncJniLibsForRelease
:GoogleMobileAdsPlugin:mergeReleaseResources
:GoogleMobileAdsPlugin:verifyReleaseResources
:GoogleMobileAdsTapjoyMediation:mergeReleaseConsumerProguardFiles
:GoogleMobileAdsTapjoyMediation:transformNativeLibsWithSyncJniLibsForRelease
:GoogleMobileAdsTapjoyMediation:mergeReleaseResources
:GoogleMobileAdsTapjoyMediation:verifyReleaseResources
:GooglePlayGamesManifest.plugin:mergeReleaseConsumerProguardFiles
:GooglePlayGamesManifest.plugin:transformNativeLibsWithSyncJniLibsForRelease
:GooglePlayGamesManifest.plugin:mergeReleaseResources
:GooglePlayGamesManifest.plugin:verifyReleaseResources
:unity-android-resources:extractReleaseAnnotations
:unity-android-resources:mergeReleaseConsumerProguardFiles
:unity-android-resources:transformResourcesWithMergeJavaResForRelease
:unity-android-resources:transformClassesAndResourcesWithSyncLibJarsForRelease
:unity-android-resources:transformNativeLibsWithSyncJniLibsForRelease
:unity-android-resources:bundleRelease
:unity-android-resources:compileReleaseSources
:unity-android-resources:mergeReleaseResources
:unity-android-resources:verifyReleaseResources
:unity-android-resources:assembleRelease
:GooglePlayGamesManifest.plugin:processReleaseResources
:GooglePlayGamesManifest.plugin:generateReleaseSources
:GooglePlayGamesManifest.plugin:compileReleaseJavaWithJavac
:GooglePlayGamesManifest.plugin:transformClassesAndResourcesWithPrepareIntermediateJarsForRelease
:GooglePlayGamesManifest.plugin:extractReleaseAnnotations
:GooglePlayGamesManifest.plugin:transformResourcesWithMergeJavaResForRelease
:GooglePlayGamesManifest.plugin:transformClassesAndResourcesWithSyncLibJarsForRelease
:GooglePlayGamesManifest.plugin:bundleRelease
:GooglePlayGamesManifest.plugin:compileReleaseSources
:GooglePlayGamesManifest.plugin:assembleRelease
:GoogleMobileAdsTapjoyMediation:processReleaseResources
:GoogleMobileAdsTapjoyMediation:generateReleaseSources
:GoogleMobileAdsTapjoyMediation:compileReleaseJavaWithJavac
:GoogleMobileAdsTapjoyMediation:transformClassesAndResourcesWithPrepareIntermediateJarsForRelease
:GoogleMobileAdsTapjoyMediation:extractReleaseAnnotations
:GoogleMobileAdsTapjoyMediation:transformResourcesWithMergeJavaResForRelease
:GoogleMobileAdsTapjoyMediation:transformClassesAndResourcesWithSyncLibJarsForRelease
:GoogleMobileAdsTapjoyMediation:bundleRelease
:GoogleMobileAdsTapjoyMediation:compileReleaseSources
:GoogleMobileAdsTapjoyMediation:assembleRelease
:GoogleMobileAdsPlugin:processReleaseResources
:GoogleMobileAdsPlugin:generateReleaseSources
:GoogleMobileAdsPlugin:compileReleaseJavaWithJavac
:GoogleMobileAdsPlugin:transformClassesAndResourcesWithPrepareIntermediateJarsForRelease
:GoogleMobileAdsPlugin:extractReleaseAnnotations
:GoogleMobileAdsPlugin:transformResourcesWithMergeJavaResForRelease
:GoogleMobileAdsPlugin:transformClassesAndResourcesWithSyncLibJarsForRelease
:GoogleMobileAdsPlugin:bundleRelease
:GoogleMobileAdsPlugin:compileReleaseSources
:GoogleMobileAdsPlugin:assembleRelease
:GoogleMobileAdsAppLovinMediation:processReleaseResources
:GoogleMobileAdsAppLovinMediation:generateReleaseSources
:GoogleMobileAdsAppLovinMediation:compileReleaseJavaWithJavac
:GoogleMobileAdsAppLovinMediation:transformClassesAndResourcesWithPrepareIntermediateJarsForRelease
:GoogleMobileAdsAppLovinMediation:extractReleaseAnnotations
:GoogleMobileAdsAppLovinMediation:transformResourcesWithMergeJavaResForRelease
:GoogleMobileAdsAppLovinMediation:transformClassesAndResourcesWithSyncLibJarsForRelease
:GoogleMobileAdsAppLovinMediation:bundleRelease
:GoogleMobileAdsAppLovinMediation:compileReleaseSources
:GoogleMobileAdsAppLovinMediation:assembleRelease
:GoogleMobileAdsMediationTestSuite:processReleaseResources
:processReleaseResources
:generateReleaseSources
:GoogleMobileAdsMediationTestSuite:generateReleaseSources
:GoogleMobileAdsMediationTestSuite:compileReleaseJavaWithJavac
:GoogleMobileAdsMediationTestSuite:transformClassesAndResourcesWithPrepareIntermediateJarsForRelease
:javaPreCompileRelease
:compileReleaseJavaWithJavac
:compileReleaseSources
:transformClassesWithJarMergingForRelease FAILED
212 actionable tasks: 212 executed
]
exit code: 1
UnityEditor.Android.Command.WaitForProgramToRun (UnityEditor.Utils.Program p, UnityEditor.Android.Command+WaitingFor<message truncated>

Same issue when i upgrade firebase to version 5.4, How to fix this?

Version 5.4.1 - November 5, 2018 , was fix issue

Same issue, even on 5.4.1

I'm also having the same Issue on 5.4.1
The setup that seems to be causing the issue is having AdMob installed alongside Firebase Database.
I have tried removing and reinstalling all my plugins.
I cannot find the conflict inside any of the Firebase dependency xmls. Removing the Android dependency listed inside GoogleMobileAdsDependencies.xml will allow the app to build, but will obviously cause AdMob to fail loading as its dependency is no longer included.
A custom gradle build file would probably fix the issue, but I have barely dabbled in any of this and would prefer not to start learning how Android dependencies are sorted out.

https://github.com/googleads/googleads-mobile-unity/issues/800
@@

Same issue with Unity 2018.2.14f1 + Firebase 5.4.1 (dotnet4).
I get en error when I try create internal build :
`CommandInvokationFailure: Unable to convert classes into dex format.
  If that does not work for you, please let us know.

Hi @a-maurice,
What do we add? I think it's missing from your comment.
I'm using Analytics and Messaging. As a workaround, I disabled auto-resolution and replaced the 3 play-services-measurement AAR's with the following versions

Hi @TerraCo89 , sorry about that, it was in brackets, so got formatted away.  I updated my previous comment, so it should be visible now, but it should be "com.google.android.gms:play-services-measurement-sdk-api:16.0.3"

Hi @a-maurice, if I'm using both Analytics & Messaging, what do I do with the line? Adding it to both of the dependencies.xml and AppDependencies.xml?

Adding it to just Assets/Firebase/Editor/AnalyticsDependencies.xml fixed it for me

Don't work for me, I guess I'm having dependencies conflict after importing Unity FacebookSDK, along with my project's Admob & Firebase.

Don't work for me, I guess I'm having dependencies conflict after importing Unity FacebookSDK, along with my project's Admob & Firebase.

I too am using Facebook SDK, Firebase, and AdMob - I ended up switching to Firebase version 5.3.1 to fix the issue.

Don't work for me, I guess I'm having dependencies conflict after importing Unity FacebookSDK, along with my project's Admob & Firebase.

@xuancelestial I too am using Facebook SDK, Firebase, and AdMob - I ended up switching to Firebase version 5.3.1 to fix the issue.

Oh wow, this worked, thanks!

@xuancelestial, @Kirk-C, thanks for the heads up about the conflicts you are seeing with the Facebook SDK, we will take a look to see what we can do about those.
And while it doesn't matter any more, you could add it to either of those files.  We just parse those files to determine which Android dependencies to include when running the Jar Resolver step, so as long as it was mentioned in one, it would be picked up.

Hi all,
We are working on a proper fix for this issue, but in the meantime as a workaround, you can edit Assets/Firebase/Editor/AnalyticsDependencies.xml (or AppDependencies.xml, if you are not using Analytics), by adding:
<androidPackage spec="com.google.android.gms:play-services-measurement-sdk-api:16.0.3">
</androidPackage>

alongside the other androidPackages in that file. If that does not work for you, please let us know.

G'day man, I'm using Firebase Auth + Firebase DB + GoogleAds, after I included the dependency it in the AppDependencies.xml it did manage to build, and it's all fun in the unity editor, but when I load on the device, the game just crashes, doesn't even boot up, just crashes.
Some people are saying that using the Firebase 3.5.1 solves the problem, but I can't find it anywhere, got any workaround for that?

Hi @dralv3s,
It seems that there is a problem with the integration between the latest Firebase SDKs and the GoogleAds SDK.  We are looking into those, and hopefully will have the proper fix soon.
You can get the 5.3.1 versions of the SDKs at https://dl.google.com/firebase/sdk/unity/firebase_unity_sdk_5.3.1.zip in the meantime, and hopefully that solves as a workaround to the problems you are seeing.

We'd be grateful for an official fix for this, because we are affected by the problem too, but we also rely on the RTDB Persistence APIs added in Firebase 5.4.0.

The Android SDK has been updated with a new version of the Ads and Play Services Measurement SDK, so if you go to the toolbar's Assets > Play Services Resolver > Android Resolver > Force Resolve, because the conflicting dependencies are forcing it to try the latest, it should use those new versions.
We'll aim to have a version of the Unity SDK with these versions properly specified, but that might work for you in the meantime.

The Android SDK has been updated with a new version of the Ads and Play Services Measurement SDK, so if you go to the toolbar's Assets > Play Services Resolver > Android Resolver > Force Resolve, because the conflicting dependencies are forcing it to try the latest, it should use those new versions.
We'll aim to have a version of the Unity SDK with these versions properly specified, but that might work for you in the meantime.

Thanks. Tried Force resolve this morning and worked like a charm!

I am having the same issue with IONIC:
duplicate entry: com/google/android/gms/internal/measurement/zzdz.class

Hi @dralv3s,
It seems that there is a problem with the integration between the latest Firebase SDKs and the GoogleAds SDK. We are looking into those, and hopefully will have the proper fix soon.
You can get the 5.3.1 versions of the SDKs at https://dl.google.com/firebase/sdk/unity/firebase_unity_sdk_5.3.1.zip in the meantime, and hopefully that solves as a workaround to the problems you are seeing.

Thanks a lot, it worked.

If someone facing problems even with 5.3.1 follow these steps from https://firebase.google.com/docs/unity/setup
To resolve the compilation error, if you're using .NET 3.x:
Remove or disable the following DLLs for all platforms:
Parse/Plugins/dotNet45/Unity.Compat.dll
Parse/Plugins/dotNet45/Unity.Tasks.dll
Enable the following DLLs for all platforms:
Parse/Plugins/Unity.Compat.dll
Parse/Plugins/Unity.Tasks.dll
To resolve the compilation error, if you're using .NET 4.x:
Remove or disable the following DLLs for all platforms:
Parse/Plugins/Unity.Compat.dll
Parse/Plugins/Unity.Tasks.dll
Enable the following DLLs for all platforms:
Parse/Plugins/dotNet45/Unity.Compat.dll
Parse/Plugins/dotNet45/Unity.Tasks.dll

I believe the issue - due to the Android SDK - was fixed in version 5.4.0 https://firebase.google.com/support/release-notes/unity#5.4.0


storageState doesn't work when the browser is created with Apify.launchPlaywright()

Describe the bug
When the browser is launched with the Playwright SDK directly, the below code works properly. The browser gets the cookies and local storage state from the state.json file correctly and the authentication session persists.
import playwright from 'playwright';

const browser = await playwright.firefox.launch();
const page = await browser.newPage({ storageState: 'state.json' });

But if the browser is launched with the Apify SDK, the session doesn't persist.
import Apify from 'apify';

const browser = await Apify.launchPlaywright();
const page = await browser.newPage({ storageState: 'state.json' });

System information:

OS: MacOS Monterey
Node.js version: 16.13.1
Apify SDK version: 2.0.7
CPU: Apple Silicon M1
The program was run on the local computer not on a Docker container.

As I said in a different issue, it's because by default, Apify.launchPlaywright() produces a persistent context. storageState is an option of Context and since there is only one context when persistent context is used, you cannot add another storageState. This will work:
import Apify from 'apify';

const browser = await Apify.launchPlaywright({
    useIncognitoPages: true,
});
const page = await browser.newPage({ storageState: 'state.json' });


New rule idea: disallow form elements missing .form-control class

In the projects I work on, some developers just forget to add the form-control class on some elements, which cause these to look different than other elements.  I would love a rule that required this class on the appropriate elements.
Similarly it would require that radio buttons & checkboxes be structured properly as
.radio > label > input[type='radio'] or label.radio-inline > input[type='radio']
and
.checkbox > label > input[type='checkbox'] or label.checkbox-inline > input[type='checkbox']
I'd be happy to write this rule and submit a PR, but I fist just wanted to check to see if this would even be a good idea at all.

@chrismbarr I would gladly accept a PR for such a linter, with the caveat that it be disabled by default so that folks who've opted not to go "full Bootstrap" on their webpages don't get spurious warnings.

@cvrebert yes for sure!  How would a rule be disabled by default?  Would it just have to have it's ID listed as being disabled?

We don't currently have a proper infrastructure for disabled-by-default rules, but it'd be reasonably straightforward to add.
I'm willing to meet you halfway. If you PR your rule as a normal linter, I'd be happy to implement the disabled-by-default logic part.

@cvrebert ok done!  Check out PR #373!


Explanation of the input parameters of the forward function of the model

Thanks a lot for sharing such great work.
In the process of reading the code, there are some questions that cannot be understood. I would like to ask if you can give me some tips. Thank you very much.
Q:  Explanation of the input parameters of the forward function on line 312 of file model/model.py. It’s really hard for me to understand the meaning of parameter features_t and parameter features_ind. Looking forward to your suggestions.

Thanks for your interest in our work.

features_t encode the time in the video at which each feature was extracted. As described in the section 3.1 of the paper, we use temporal embeddings to provide temporal information about the time in the video when each feature was extracted. The temporal information of each feature is discretized here and then embedded here.
features_ind encode if the feature is valid (1) or if it is padding (0). It is then used here to set the attention mask so that padding tokens are not attended.

Thank you very much for your reply. By any chance, Is it possible for you to explain the meaning of the parameters of the vid_bert  function on line 577 of file model/model.py?  especially the parameter input_ids.

input_ids were used initially to encode the different token classes but it became useless with the temporal embeddings. You will find in the forward function that it is only used to infer the shape of the missing token_type_ids.
attention_mask encode the tokens that should be attended (valid tokens) in contrast to the padding tokens that should not be attended.
token_type_ids encode the expert used to extract the feature (called "Expert embeddings" in part 3.1 of the paper).
position_ids encode the time in the video at which each feature was extracted (called "Temporal embeddings" in part 3.1 of the paper)
features are the expert features (called "Features" in part 3.1 of the paper)


fix(neo4j): update user bugfix

Reasoning 💡
Using the neo4j adapter, I noticed that if I sign in with Facebook, then, with email - it fails.
The reason being that updateUser returned an object like { 'properties(u): { id: '123', name: 'abc' } },}`
This PR fixes that by returning a user object fromupdateUser
In addition I have used shorter notation u{.*} instead of properties(u) throughout all neo4j statements.
And, to catch this bug in future, I have made an edit to basic-tests.js for your consideration.
Checklist 🧢

~- [ ] Documentation~

[x] Tests
[x] Ready to be merged

@EarthlingDavey could you reopen this against main? We are out of beta. :)

Sure thing: https://github.com/nextauthjs/adapters/pull/352


[$2000] iOS mWeb - Scroll behavior on some pages is inconsistent and broken

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:
Scenarios:
1.Login with any account that has many reports.
2.From LHN, try to scroll to bottom with the first touch at the fab button, after that try to scroll normally at other position.
3.Notice you can't scroll right after that, you need to scroll 2,3 times to make it scroll as normal.
1.Select any workspace, choose Connect Bank Account => Connect Manually, press back button to Connect Bank Account, continue to press back.
2.Notice you can't scroll right after that, you need to scroll 2,3 times to make it scroll as normal.
1.Go to Settings => About page => Scroll to bottom, change the tab then go back.
2.Notice that you can’t scroll to bottom after that
Expected:
Can scroll to the bottom as normal
Actual:
Can not scroll to the bottom as normal
Workaround:
unknown
Platform:

Where is this issue occurring?

Mobile Web Safari

Version Number: 1.2.39-0
Reproducible in staging?: y
Reproducible in production?: y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
https://user-images.githubusercontent.com/43996225/207710442-d7cae06b-8d10-431b-813b-b919b2331252.MP4
https://user-images.githubusercontent.com/43996225/207710473-30935a84-8929-4452-9b34-c6afcd813d9b.MP4
https://user-images.githubusercontent.com/43996225/208127073-6e5a262d-9995-41ac-a3d0-90bc455e4df3.MP4
https://user-images.githubusercontent.com/43996225/208127089-ea3f48f6-87eb-4b86-9a95-b523a3c16bc7.MP4
Expensify/Expensify Issue URL:
Issue reported by: @hungvu193
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1671032426349589
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~012729407713b5d561
Upwork Job ID:<PHONE_NUMBER>317778432
Last Price Increase: 2022-12-29

I was able to reproduce, sending out to external
https://user-images.githubusercontent.com/6643649/209216672-77a91412-be9d-4469-8d3d-30fa2d5b0ed7.MP4

Proposal
Cause:  IOS has feature of bounce on scroll whenever we reach extreme ends while scrolling. Whenever we scroll to bottom or top and content tries to bounce, on some occasion, due to the user trying to scroll beyond the content, it locks the parent View with it which changes touch focus to parent view and thus stopping the scroll.
Solution: add attribute bounces={false} in FlatList and ScrollView for that page which will stop the bounce on scroll feature and thus solve the issue. I will mention the code to change below for 'About' and 'Reports' page which are currently facing the issue. In future too, if such issue occurs again on any other page, only thing we will need to add is the bounces attritube to the component
src/pages/settings/AboutPage/AboutPage.js
@@ -54,26 +54,27 @@
 <ScrollView
                contentContainerStyle={[
                    styles.flexGrow1,
                    styles.flexColumn,
                    styles.justifyContentBetween,
                ]}
 +             bounces={false}
            >

src/components/InvertedFlatList/BaseInvertedFlatList.js
@@ -121,26 +121,27 @@
            <FlatList
                // eslint-disable-next-line react/jsx-props-no-spreading
                {...this.props}
                ref={this.props.innerRef}
                renderItem={this.renderItem}
+              bounces={false}

I'm not able to reproduce this issue @kavimuru please check on the latest staging again!
https://user-images.githubusercontent.com/85645967/209375794-c1b06d4f-621c-463b-9654-db673edbd5ef.MP4

@dhanashree-sawant
Thanks for the proposal, but we need the bounce effect!
cc: @pecanoro

Waiting for proposals!

I can't reproduce anymore, but also I am using an emulator so I am not sure if it's different with a real device. @davidcardoza can you try again and see if you can reproduce it?

I'm still able to reproduce on latest versionhttps://user-images.githubusercontent.com/16502320/209892453-a88379c8-a117-4095-91ca-baf377e7a4d4.MOV

Yeah, i can still reproduce the LHN freezing. Here's a new screen recording-
https://user-images.githubusercontent.com/6643649/209904359-b433f5e7-8051-4a9a-8ec8-17024bbfeb44.MP4

Proposal
Hey there 👋 I think this issue can be solved in various ways, however I'd propose the minimal changes below to fix this issue of  LHN "body lock" / "scroll freeze"
(Brief explanation below this code)
File: web/index.html
<style>
      html,
      body,
      #root,
      #root > div,
      #root > div > div {
          height: 100% !important;
      }

+    body {
+         overflow:  hidden;
+    }
....

The reason for such error (body locking) is because for some reason, on certain instances of iOS's Safari, the focus gets changed to document's body instead of the element we want to scroll. Therefore, when we're scrolling, it sometimes scrolls the actual body itself and causes the "body lock" / "scroll freeze" bug that we're trying to fix here.
Therefore, the simplest solution I can propose is the above, which is to "disable" the scrolling of the body by using overflow: hidden on the body element. The reason I chose to solve it this way is because it introduces the least amount of code and can be easily reverted, should it be necessary for any purpose.
[Preview] Before (scroll motions: up then down):
https://user-images.githubusercontent.com/28676406/210034441-39f3c2dd-720e-4780-b92c-3d0394074f0a.MP4
[Preview] After (scroll motions: up then down):
https://user-images.githubusercontent.com/28676406/210034445-52c8c1eb-8e11-473a-852c-d6e2df524d89.MP4
Tested on Safari & Chrome (MacOS & iOS).
Note: there's a similar bug on iOS chrome and this fixed it too.
I hope this helps. Thanks! 🙂

It seems root cause is similar to this issue reported here on mWeb/Safari it was closed due to recognized as a safari bug and any solution would be a workaround to solve it https://github.com/Expensify/App/issues/13492. I believe we should do similar here.

This bug is also similar to this: White space appears under compose box
Worth noting that my solution above fixes the problem described in this issue (LHN). I can't repro the problem described in this issue in screens other than LHN.

Unable to test this one due to IP restriction, will check again tomorrow!

@Expensify/design
Can someone check if are we fine with this new behavior.
@pecanoro All the solution looks fine to me, as it addresses the issue shown here, I don't think it breaks anything please let me know your thoughts, thanks!

Thanks for the followups! 🙂
@shawnborton , Ive been testing it the past 2 days and haven't found any issue that it caused - although it is hard to confirm that it won't cause any regression as there's no exact place on where it should be tested...
Regarding your concern about blocking any scrolling though (which would be the regression), I think we are safe in that aspect because we never (nor we should) scroll directly from the html's body, but there's always a component that wraps the content in a page - mostly View (from react-native) which is where users scroll. We now also learn that we should never scroll the body, otherwise the exact bug we're trying to fix is gonna appear.
Anyhow, the proposal actually fixes the same issue that aren't even mentioned here which appears in different places, for example when clicking "new chat" on LHN, and in the "New chat". So most likely this proposal fixes this "body locking" scrolling bug everywhere, not just LHN.
Lastly, by any chance do you have any reference as to what needs to be tested further from your side? As, again, for now scrolling works fine everywhere. Thanks! 😄

Cool cool that sounds good, mostly just want to make sure all scrollable views/lists in the app will still scroll as expected!

Thank you both for your input! I think it's a great solution, but yeah, we will have to be careful about testing so we don't break any other parts of the UI! @shonsirsha assigning you to the job!

Cool cool that sounds good, mostly just want to make sure all scrollable views/lists in the app will still scroll as expected!

I  think it's a great solution, but yeah, we will have to be careful about testing so we don't break any other parts of the UI

Totally agree! Will keep testing stuff! 😄
Applied on Upwork, will create a PR today or latest tomorrow. Thanks!

PR ready for review 🙂
cc @Santhosh-Sellavel @shawnborton

@pecanoro What is the next step on this one?

@davidcardoza Oh dammit, I think the issue wasn't linked properly on the PR and it didn't update the issue with the payment date. You can follow the steps here from step 6. You will need to pay the people involved since it's been more than a week since we deployed the changes. If you have any doubts about how to proceed, I recommend asking on the #bug-zero channel.

@0xmiroslav thanks for reporting. Although I did quite a thorough testing for this one, I missed it as I didn't know that the regression is even a functionality in Android web. Sorry about this.
Anyhow, I don't find another way to solve this in iOS other than disabling the scrolling of the document's body. I'm now thinking of somehthing like this which should fix the regression yet still fixes the issue:
File: index.html
<script>
function disableBodyScrollIOS(){
      if (isMobileSafari()){
            document.body.style.overflow = 'hidden';
      }
}
</script>

<body onload="disableBodyScrollIOS();">
etc...

isMobileSafari is a function that we have in the codebase that we can copy over to index.html.
Open for suggestions.
cc @pecanoro @Santhosh-Sellavel
Also would anyone lmk how to proceed if a PR causes regression? Thx.

PR which fixes this issue and causes serious regression in android chrome. Pull-to-refresh not working. Issue reported here: https://expensify.slack.com/archives/C049HHMV9SM/p1674040409891389

Good catch @0xmiroslav. But I think it is not a serious regression as it does not affect anything within our app. I will wait for @pecanoro to decide on this one.
Whether we fix it or not I think this is something that is a bit out of scope to find out in the PR review testing, thanks!

Thanks, everyone, @davidcardoza this is due for payment!

Confirming payments with @pecanoro  before sending out.

Payment sent to @shonsirsha
@hungvu193 I hired you on the job, please accept to receive $250 payment
@Santhosh-Sellavel please apply for the job so I can process payment - https://www.upwork.com/jobs/~012729407713b5d561

@davidcardoza Applied now!

@davidcardoza bump!

Hired @Santhosh-Sellavel can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~012729407713b5d561

Thanks, @mallenexpensify done!

Paid @Santhosh-Sellavel
@davidcardoza and @Santhosh-Sellavel , can you fill out the below?  The checklist didn't auto-populate
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[ ] The PR that introduced the bug has been identified. Link to the PR:
[ ] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[ ] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[ ] A regression test has been added or updated so that the same bug will not reach production again. Link to the GH issue for creating the test here:

@pecanoro I believe this is not a regression, it existed right from the start!

Thanks for taking over while i was away @mallenexpensify I filled out the two first bullet points.

@davidcardoza The bug-zero assignee usually takes care of the last bullet point, it would be great if you can take care of that last item, thank you!

@pecanoro, @davidcardoza, @shonsirsha, @Santhosh-Sellavel Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

This doesn't require a regression test  it doesn’t make sense to add a step to TestRail test case.

I added it to the testing guidelines sheet  https://docs.google.com/document/d/1UaWlcieiwLnsKfeKw7iwLF7vgYRmdw_-K8OcY5aPBRU/edit#heading=h.zm638pdvzx2


Set the hostname of created machines to match the machine name

When creating and managing multiple machines, it is confusing to identify which machine you have logged into after using machine ssh. Setting the hostname to match the machine name would be useful in this scenario.
(woops I initially raised this against swarm by accident)

If I've read this issue correctly, the implementation should be:

Set a hostname on creation
add machine move/rename which will change a machine's name in the internal data store and change the hostname
For move/rename: Error if the name is taken in the internal data store.

I don't think renaming is necessary to start with - that's already being worked on here https://github.com/docker/machine/issues/59
At the moment we give hostnames long random names. I think we should set the name on the provider to be the name given by the user, which normally is also the hostname given to the machine. For example – when you create a droplet on digital ocean, you give it a name, which is also used by the hostname.

Another thing to be aware of: the name given by the user might already exist on the provider. We should display useful error messages about this.

I absolutely agree with setting the name on the provider too. Things like EC2 won't care since the unique criteria will be the instance id.
As per:

I don't think renaming is necessary to start with - that's already being worked on here #59
That's this issue :)

+1 for setting the name / hostname on the provider if supported.  I agree to leave renaming / moving out of this one -- I believe bfirsh meant #30 is being worked on for that.

I'll give it a go :)

Oh whoops, yes, wrong issue. Sorry.

Closing as #219 has been merged.

How can I disable host renaming?


Model evaluation

First of all, kudos for this nice work. I really liked your work.
I am trying to reproduce the results of your paper. It will be very helpful if you could share the evaluation script for the automated metrics. In the paper, it is written that "We employ the evaluation scripts used by DialoGPT.". Could you please point out the DialoGPT file used for your evaluation.

Thanks a lot.


Bugfix/static file handling

Related issues

closes #2685
closes #2686
Short description and why it's useful

Improves static file request handling, especially for missing files
Screenshots of visual changes before/after (if there are any)

Which environment this relates to
Check your case. In case of any doubts please read about Release Cycle

[x] Test version (https://test.storefrontcloud.io) - this is a new feature or improvement for Vue Storefront. I've created branch from develop branch and want to merge it back to develop
[ ] RC version (https://next.storefrontcloud.io) - this is a stabilisation fix for Release Candidate of Vue Storefront. I've created branch from release branch and want to merge it back to release
[ ] Stable version (https://demo.storefrontcloud.io) - this is an important fix for current stable version. I've created branch from hotfix or master branch and want to merge it back to hotfix

Upgrade Notes and Changelog

[x] No upgrade steps required (100% backward compatibility and no breaking changes)
[ ] I've updated the Upgrade notes and Changelog on how to port existing VS sites with this new feature

IMPORTANT NOTICE - Remember to update CHANGELOG.md with description of your change
Contribution and currently important rules acceptance

[x] I read and followed contribution rules
[x] I read the TypeScript Action Plan and adjusted my PR according to it
[x] I read about Vue Storefront Modules and I am aware that every new feature should be a module

Sorry! Wrong place. It should be on Develop


A Desktop Release

Describe your suggested feature
AniYomi Should have a desktop release as well. I have seen online forums talking and asking for such an application
Other details
No response
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] If this is an issue with an extension, I should be opening an issue in the extensions repository.
[X] I have updated the app to version <IP_ADDRESS>.
[X] I will fill out all of the requested information in this form.

[x]  I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.

Did you really?

I would like to make a petition to close this issue.
Why?:
1. There will be no desktop-native Aniyomi.
If you want to have one, create it yourself. Tachidesk also exists if you want a Tachiyomi without anime but guessing the issue you want a Tachiyomi with anime on Desktop, please move to the next section.
2. You can run Aniyomi in a Android Emulator. Use them.
 Even Windows Subsystem for Android exists. Set one up and get adb and a Aniyomi apk (x86 or x86-64 for WSA* and arm64 or armv7 for other emulators) from releases. From there, you can sideload apps using this guide for WSA or double click the apk in explorer for other emulators. After that, you can copy a backup from Aniyomi, install extensions and log into trackers, and done. You can now use Aniyomi on desktop.
*You can choose x86 or arm since doesn't matter in WSA given that you have a x86 chip(from Intel or AMD) since it has ARM translation engine that fully works though I recommend going with the x86 version(if you have Intel or AMD CPU) or ARM version(for other emulators or if you have a ARM CPU)since some operations introduce overhead and hardware may not be fully utilized if host architecture isn't the app architecture including hardware acceleration which is vital for video decoding(or playing video).
3. This is the third duplicate of a desktop app issue.
The other issues are #147 #560 and #637


TOP() should have option to return sorted results

Bug report
System info: InfluxDB v1.5.2
Steps to reproduce:

Insert a few points
Run a raw query using the TOP() function
Note that the results are ordered by time and not the field selected by TOP().

Expected behavior: TOP() pulls the greatest field values. In that context, most people expect the results will be sorted by value, not timestamp.
Actual behavior: TOP() returns the greatest field values, but the results are ordered by timestamp. Almost all use of this function requires clients to sort the data themselves.
Additional info: Since the existing behavior may be relied upon, I propose that an optional argument be added to TOP() to indicate whether results should be sorted, e.g. TOP("f", 3, true); new function signature TOP( <field_key>[,<tag_key(s)>],<N>[,<sorted>] )[,<tag_key(s)>|<field_key(s)>]

Added difficulty/medium to implement new sorted variants of the top/bottom. Adding these to the transpiler will be straightforward and Flux can already perform sorted top and bottom queries.


Finalise the specification for transaction events

We currently follow the approach taken by GA.
This has many limitations:

Does not capture add-to-basket or remove-from-basket events
Does not capture discounts  at an item or basket level (e.g. voucher codes)
Does not distinguish paying for physical goods / digital goods / prepay / subscription payment / renewals / automatic payments
Does not capture refund events

It is possible to capture the "missing" data currently using generic event tracking (to capture add-to-basket events, or refund events, for example. It will be possible to e.g. distinguish payment for physical goods / digital goods / prepay / subscription / renewals etc. using custom dimensions, when we implement these for transaction events. But there are strong arguments for including these as first class citizens, given they are likely very common requirements for people implementing SnowPlow.
/cc @shermozle

Closing, this would be handled in Iglu Central / tracker repos these days...

Hi @alexanderdean. Would passing a negative value count as a "refund" event for transaction/item events or is refund just not supported? (This is in the context of using something like the .NET library for instance).

Hi @SyedWasiHaider - please discuss on our forums:
https://discourse.snowplowanalytics.com/


iOS print capture the wrong content

Attach (recommended) or Link to PDF file here: any page that contains a PDF file rendered by pdf.js (example)
Configuration:

Web browser and its version: Safari for iOS 16.4 (simulated by xCode, reproduced on a physical device as well)
Operating system and its version: iOS 16.4 (simulated, reproduced on a physical device as well)
PDF.js version: 3.9.148 [a2eca47ed]
Is a browser extension: NO

Steps to reproduce the problem:

Open (this link) with an iOS browser (I can use only Safari);
Click on the "Print" button in the viewer menu:

2.a.1. !Optional! Click on the Share button:

2.a.2. !Optional! Select Print down the list.
What is the expected behavior?
Print preview contains all the PDF pages rendered correctly:

What went wrong?
Print preview contains only the first page (or even nothing) with an artefacts of the viewer's header (second screenshot):

2.a. Print preview contain two pages: first is a complete HTML page without the PDF; second is a blank page (I suppose there should be a PDF file)
I tried to find anything related to the issue for the whole day and found nothing. It seems like this issue appeared after iOS version 15 release, but I can't prove this theory (I don't have an iOS device neither can download a Simulator for earlier version of iOS).

PDF.js version: 3.9.148 [a2eca47]

Note that that's not an official release, please find the latest releases at https://mozilla.github.io/pdf.js/getting_started/#download

Open (this link) with an iOS browser (I can use only Safari);

That page contains an "ancient" version of the PDF.js default viewer, apparently version 1.3.91 which is from 2016 and has been unsupported for years.

Unfortunately this issue really sounds like an problem with the browser and/or platform itself, rather than a bug in the PDF.js library/viewer as such. Please keep in mind that browsers (still) provide fairly limited abilities to control printing via JavaScript, and we're thus forced to jump through some hoops in order to (at all) support printing in the viewer.
Furthermore, please note that Safari is probably the browser that we've seen the most printing-related issues with and that it's also generally the most difficult browser to support; note how Safari is still only listed as "mostly" supported in the FAQ: https://github.com/mozilla/pdf.js/wiki/Frequently-Asked-Questions#faq-support
Finally, given that the built-in Firefox PDF Viewer is the primary development target for this library this issue is unfortunately very unlikely to be fixed here.


download of non-text files fails

It is similar to issue #545 which is already resolved. However, when I download non-text files such as png files, downloaded file is damaged.

Thank you for the report, @marami52.

Seems like ipynb is also an issue
For me:

Downloading .ipynb files downloads a file with the same name but has the content [object Object]
Downloading text and csv files works fine
Downloading images and pdfs increases the file size by ~35% and is corrupt when opening it


9.12.1 RN

@Adam-Dupaski , I pushed changes to this branch because I made some changes (added links) to 9.12.0 RN and wanted to make sure there are no conflicts.


How to finalize the sticker in view??

Suppose i have finished placing the sticker. How to make the sticker final in the view. I mean removing the resizing border of the sticker??

You can set the visiblility of "IvBorder", "IvDelete", "IvFlip", and "IvScale" to gone.
IvBorder.setVisibility(View.GONE);

Thanks magicomiralles,
I've added a new simple method "setControlsVisibility(boolean)" in stickerView class.

Awesome!

it's work fine..! how to make it visible for only current editing sticker or text and gone for other views.
like there is 4 views  in total , if any of single view shows the editing options(Flip, Rotate, Close) then other three views editing options need to hide..!

.setVisibility(View.GONE) will hide the borders .. but the stickers are still moveable.. What to do in this case

"setControlsVisibility(boolean)" where should i call this method ????

it only remove last added stickers border using setControlsVisibility(boolean)

No satisfactory answer yet ?

Just set mCurrentView.setInEdit(false) is OK


Redesign linear_errors

It appears that linear_errors prints the table to the standard output stream and then returns a Dict. In some scenarios this is problematic. E.g. the Documenter tutorials won't show the printed output, only the Dict.  I wonder, whether linear_errors should produce a custom type, and that printing of the output can be enfroced with display.
While we are discussing this -- why call this linear_errors? What is linear about it?  Don't we just evaluate the model on the test set?

I didn't spend much time on this routine and it is in desperate need of a refactor. I will start by adding the display option you mention.
The name is a bit silly and we should change it, particularly if we can now dispatch on acemodel.

before you charge in, can you propose the new naming here?

@cortner, do you still want to weigh in before I make some changes?

My suggestion:

define a type ACEErrorTable which just wraps the two dicts
allow additional dicts for train and test within a single structure
display should show everything - both RMSE and Mae, train and test.
define display_rmse, display_mae, display_rmse_train, ... to show just partial information.
instead of compute_errors use error_table(train, test, model)

This is the basic functionality and we can start adding to it from here?

Btw - it's unclear to me whether this should be in ACEfit or in ACE1pack? Maybe the former?

For now I've added a verbose option to linear_errors that prevents printing and the option to print the tables from the Dict.
I think we can close this and figure out a better more general structure at some unspecified point in the future...


state names compatibility support

[Environment]: bare metal, Kubernetes (maybe)
[Known affected releases]: master (includes all releases)
Describe the Issue
Allow KNIX state names to contain special characters (: ; , \ | ^ ~ $ # % & ` ", whitespace) as this is supported in state machine definitions in AWS StepFunctions service. Currently, ASL state machine definitions containing state names with special characters cannot be deployed.
Changes to be made:

Management service to allow for state names containing special characters in state names
SandboxAgent to allow for state names containing special characters in state names

Merged to 'develop' branch.


Cant deploy

There are no current deployments in progress , the previous deploy succeeded and after that I keep on getting this deployment error below
Repro steps:

1.Try and deploy
2.
Action: appService.Deploy
Error type: 409
Error Message: There is a deployment currently in progress. Please try again when it completes.
Version: 0.16.1
OS: win32
Product: Visual Studio Code
Product Version: 1.39.2
Language: en

Call Stack
s.pipeline extension.bundle.js:323:757026
s extension.bundle.js:218:111699
s extension.bundle.js:157:26069
extension.bundle.js:157:27311extension.bundle.js:157:27311
o extension.bundle.js:164:7075
extension.bundle.js:157:24982extension.bundle.js:157:24982
$.t.headersOnly.t.streamedResponse.t.body.function.t.body.pipe.a [as _callback] extension.bundle.js:1:576782
$.t._callback.t.callback.t.callback extension.bundle.js:194:5449
$.emit events.js:182:13
$.<anonymous> extension.bundle.js:194:18309
$.emit events.js:187:15
IncomingMessage.<anonymous> extension.bundle.js:194:17141
Object.onceWrapper events.js:273:13
IncomingMessage.emit events.js:187:15
endReadableNT _stream_readable.js:1092:12
process._tickCallback next_tick.js:63:19

Hi @SymplexitySGL
Thanks for reporting.  Is this still recurring?  It may have just been a hiccup with Azure.  If it does, could you try restarting your app and verify with deployment logs that the deployment completed?


stm32f7/stm32_serial.c: fix console re-initialisation if DMA enabled

Summary
Without this patch if serial console is configured to work with DMA (RX or TX) on stm32f7, it can cause a hardfault if something tries to write to console on boot.
issue #1598
Impact
stm32f7 boards now can correctly use serial console with enabled DMA
Testing
Tested with stm32f7 custom board within project based on PX4

@lukegluke - is this related to the other issues you were seeing? IIRC We have RX DMA on, on all the F7 HW, So why were you seeing a hardfault and the PX4 test rack is not?

Hi @davids5 and @lukegluke doesn't SERIAL_HAVE_CONSOLE_DMA imply both TX and RX? BTW, if it fix your issue and doesn't introduce any issue on PX4 side, it is fine. But I is strange that we need to make explicit CONSOLE_DMA for TX or RX...

@lukegluke - is this related to the other issues you were seeing?

What do you mean by other issues? Issue with USB console is the separate one.

IIRC We have RX DMA on, on all the F7 HW, So why were you seeing a hardfault and the PX4 test rack is not?

As I mentioned in issue description:

This can leads to hardfault when trying to write with not yet initialized serial dma in case when serial is used for console and something try to write to console on boot (for example board_hardfault_init in px4 can write to syslog (and to console if CONFIG_SYSLOG_CONSOLE defined)

I don't remember details, but it seems that I encountered on hardfault, just when I added CONFIG_SYSLOG_CONSOLE in my board configuration, while non of the px4 boards have this config option.
(and maybe it was also caused by my misunderstanding of CONFIG_DEV_CONSOLE default value :)
So in the end I think it's not the problem for current PX4.

Hi @davids5 and @lukegluke doesn't SERIAL_HAVE_CONSOLE_DMA imply both TX and RX? BTW, if it fixes your issue and doesn't introduce any issue on PX4 side, it is fine. But I is strange that we need to make explicit CONSOLE_DMA for TX or RX...

Hi @acassis. I fixed this issue by just defining general SERIAL_HAVE_CONSOLE_DMA as in stm32 (see #1598), but then I notice that there is separate defines for TX and RX (because stm32f7 support both) added by David, so within this PR I just adjust for current defines.

IIRC We have RX DMA on, on all the F7 HW

@davids5, in fact you're wrong here. I've just checked - only two F4 boards fmu-v2 and fmu-v4 have RX DMA.

Hi @davids5 and @lukegluke doesn't SERIAL_HAVE_CONSOLE_DMA imply both TX and RX? BTW, if it fixes your issue and doesn't introduce any issue on PX4 side, it is fine. But I is strange that we need to make explicit CONSOLE_DMA for TX or RX...

Hi @acassis. I fixed this issue by just defining general SERIAL_HAVE_CONSOLE_DMA as in stm32 (see #1598), but then I notice that there is separate defines for TX and RX (because stm32f7 support both) added by David, so within this PR I just adjust for current defines.

Hi @lukegluke thanks for explanation, now I recall about it. David decided to separate both DMAs sometime ago. So I think your fix is correct. @davids5 can we merge it?


Is there any method to get GIL in async?

Is there any method to get GIL in async? It is useful when users call python from rust
async fn run_python() {
    let gil = Python::acquire_gil().await;
    let py = gil.python();
    do_something();
}
#[async_std::main]
async fn main() {
    run_python().await;
}

I'm afraid Python::with_gil is the best choice at the moment. Because the GIL is like a sync Mutex, I'm not aware there's anything we can do in PyO3 to avoid a blocking wait at the moment.

@davidhewitt  Maybe it is feasible to do so, although many specific details are not considered.
https://gist.github.com/rust-play/2168724b061bf6b8aa2f2d3c64bb235b

I would strongly advise not using that. In particular:
async fn acquire_gil(&self) -> AsyncGILGuard<'_> {
    let _guard = self.inner.lock().await;
    let gil = Python::acquire_gil();
    AsyncGILGuard { _guard, gil }
}

This causes two waits: an async wait to acquire the Mutex, and then a blocking wait for Python::acquire_gil. Acquiring the Mutex won't guarantee that the GIL is ready to be acquired; this could even potentially deadlock your program.
If you really want a true async acquire_gil then I believe this would need upstream support in CPython. The only APIs we have accessible to us at the moment block the thread waiting for the GIL.

What I want to express is actually: blocking APIs will not block when they meet certain conditions. Therefore, as long as the asynchronous primitives are used to ensure that the blocking APIs will not be blocked when accessed, the blocking APIs can be converted to asynchronous APIs.
My example is written under your premise " the GIL is like a sync Mutex", that is, through asynchronous Mutex, it is guaranteed that there is only one coroutine that calls Python::acquire_gil() at the same time, so theoretically the call will not block if it is similar to a sync mutex. If this premise is not precise, such as GIL is actually more similar to a reentrant mutex, then this example is of course unreasonable, but it should not affect its feasibility (Asynchronous GIL can be implemented without additional support from CPython).
My English is not very good. These sentences are largely translated by Google. If there is any offense in the words, please understand, it is not my intention.

Perhaps in this case you are better off having only one thread that acquires the gil and use channels to communicate between threads, if your program is multithreaded. Generally it is recommended that things like resources work better with message passing than passimg around a mutex containing it.

@mejrs So at least we have reached a consensus: it is feasible to obtain GIL asynchronously. Why not try to support it in pyo3?
I'm the core maintainer of MegFlow, which uses Rust's asynchronous scheduler to schedule Python/Rust programs at the same time. It would be very helpful if pyo3 supports asynchronous acquisition of GIL, and I also think that this will be a very cool feature.

it is guaranteed that there is only one coroutine that calls Python::acquire_gil() at the same time

@Easonzero I understand your point however I must disagree still with the implementation. Any number of other threads spawned from Python by threading.Thread, or even Rust threads which are not running async code, may also be waiting on acquire_gil. So I expect it to be very likely that calls to acquire_gil will block even with the companion async Mutex.
For this reason I think offering this API in PyO3 at the moment is misleading to users - if I use an async function from a library I expect it to be guaranteed that the function will never block.
In your own code you are able to control what other threads may be spawned, so I'm fine for you to do this in your own code if you choose.

It would be very helpful if pyo3 supports asynchronous acquisition of GIL, and I also think that this will be a very cool feature.

Please do understand that I very much want to have async support in PyO3 too. More research into how to best integrate async Rust and Python needs to be done before I think we are ready to provide anything in PyO3. A lot of progress has been made at https://github.com/awestlake87/pyo3-asyncio, however that implementation is very coupled to the Rust runtimes and I hope that anything in PyO3 core would be runtime-agnostic.
I still believe that an async acquire_gil is dependent on having upstream CPython support.

So at least we have reached a consensus: it is feasible to obtain GIL asynchronously.

That's not what I said.


KPOINTS files for band-structure calculations

When the command "vise vs -t band" is entered, to my knowlege, the following message will be displayed:
INFO: Numbers of kpoints are incremented to be even numbers.

What is the effect/reason of this treatment?

Would it be a problem to rewrite non-zero-weighted k points created in a vise command with those written in a IBZKPT file in a previous SCF calculation?
In my calculations, band-structure caluculations are performed self-consistently;
a WAVECAR file converged in a previous run is read, and an ICHARG tag is NOT set.

This is mainly because it is often better to use an even number of k-points (e.g. NKRED=2). However, for band structure calculations, this is not necessary.
To perform hybrid functional calculations, we need to use the KPOINTS file that the software generates. However, when using GGA(+U), we can utilize fixed charge density and run non-selfconsistent calculations using ICHARG=11. In that case, as you mentioned, you should modify the parameters accordingly.

Thank you for your reply.

I have understood the content. I had an interest on why the even-number k points are imposed in the case of band structure calculations (vise vs -t band).

I have an additional question to evaluate band structures.

I have done band structure calculations on collinear antiferromagnetic systems with the GGA-PBEsol functional.
All calculations have been done self consistently; so, ICHARG tags are NOT set to be 11.
In the case of MF2 (M = Mn, Co, etc.), the experimental XRD-derived space group is P4_2/mnm (tP lattice); meanwhile, antiferromagnetic primitive cells belong to Cmmm (oS lattice).
When KPOINTS files are created by the command "vise vs -t band" (by the SeeK-path rule), which Bravais lattice should be applied?
For example, the following warning is displayed when Cmmm is applied:
warnings.warn("oC lattice, but a almost equal to b", EdgeCaseWarning)
As a side note, to impose antiferromagnetic Cmmm, other "false" elements were intentionally included in POSCAR files only in the commands "vise vs" and "vise vs -t band"; for example, a Co2F4 POSCAR file was modified into a CoFeF4 where Fe played a role in "false" down-spin Co, and after entering the above commands, Fe was manually written into Co to get a "true" Co2F4 POSCAR file.


Fix memory leak issues with age_load

In this patch, all agtype_values, that are allocated while processing the csv file, are free'd.

PG15 is not the branch for version 15, yet. Just use the master for now.


ImportError: numpy.core.multiarray failed to import

Hi, after installing the package using Python 3.6 I get the following error when trying to import the package:
ImportError: numpy.core.multiarray failed to import

Hi @qemtek, could give us more details?
It was Installed through Pip, Conda, Lambda Layer or Glue wheel file?
Which OS?
Thanks

Closing by inactivity.


MECH 10 - Create handgun blueprint and implementation

Definition of Done:
The prototype handgun can fire and perform required actions and triggers
Implementation
Pre-Actions:

[ ] Subclass the HitScan blueprint
[ ] Create another subclass for the prototype handgun and import its model

Required blueprint functionality

[ ] Fire
[ ] Reload
[ ] Aim
[ ] ApplyDamageToTarget (if extended)

Changes to method signatures
The diagram for the weapon sub classing may have changed the method signatures


Removed unnecessary files from Gemspec to reduce file size of distributed gem

Background: I want to use gitlab gem to run in a CLI and vendor all the dependencies. Gitlab was the largest with over 1MB. Granted, compared to node_modules the overhead is tiny, but nevertheless there are some needless configs that are shipped with the Gem but never needed for a usage.
Removed /specs + Docker configs + Dev configs
Size of the unzipped gem dir:
Before: 1,4MB
After: 380KB (-72%)
Instead of reject { .. regex } one could use grep_v, which is available from Ruby 2.3. I was not sure, if you are supporting Ruby 2.2 and lower though.

LGTM 👍

Instead of reject { .. regex } one could use grep_v, which is available from Ruby 2.3. I was not sure, if you are supporting Ruby 2.2 and lower though.

No, we don't support Ruby 2.2 anymore as it reached EOL. https://www.ruby-lang.org/en/downloads/branches/

Thank you.


Feat: Want to add the fade up and fade in animation for the resources page

Describe the feature
I want to add the fade up and fade in aniamtion for the resources page
Like in this animation when the resources comes in the view port of the user then i will looks like popping up which will looks attractive
Add ScreenShots
https://github.com/user-attachments/assets/2e619b37-06b7-432f-bdac-a5de139faadf
Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[ ] I'm a VSoC'24 contributor
[X] I want to work on this issue

You are assigned @Ayushmaanagarwal1211


fix: remove global shadow on mobile

Fixes: #185
Changes:
Add a new stylesheet entry to prevent the display of global shadows.
Screenshots of the change:

cc @qier222, this issue is fixed by @bzp2010

well done👍


readlink -e option not recognized on MacOS

digipolis:sync-local command uses readlink -e to read out the private key, but -e is unknown on MacOS version (BSD) of readlink.

Mac readlink options:
     -F      As in ls(1), display a slash (`/') immediately after each pathname that is a
             directory, an asterisk (`*') after each that is executable, an at sign (`@')
             after each symbolic link, a percent sign (`%') after each whiteout, an equal sign
             (`=') after each socket, and a vertical bar (`|') after each that is a FIFO.  The
             use of -F implies -l.

     -f format
             Display information using the specified format.  See the FORMATS section for a
             description of valid formats.

     -L      Use stat(2) instead of lstat(2).  The information reported by stat will refer to
             the target of file, if file is a symbolic link, and not to file itself.

     -l      Display output in ls -lT format.

     -n      Do not force a newline to appear at the end of each piece of output.

     -q      Suppress failure messages if calls to stat(2) or lstat(2) fail.  When run as
             readlink, error messages are automatically suppressed.

     -r      Display raw information.  That is, for all the fields in the stat structure, dis-
             play the raw, numerical value (for example, times in seconds since the epoch,
             etc.).

     -s      Display information in ``shell output'', suitable for initializing variables.

     -t timefmt
             Display timestamps using the specified format.  This format is passed directly to
             strftime(3).

     -x      Display information in a more verbose way as known from some Linux distributions.

If something doesn't work on Windows, we get a "Windows sucks" reply by default, but here clearly OSX sucks...
I would suggest to drop the option.

@matthijs-va surely, you mean BSD ;-)


[raylib] Build error

PS C:\vcpkg> ./vcpkg install raylib
warning: Starting with the September 2023 release, the default triplet for vcpkg libraries will change from x86-windows to the detected host triplet (x64-windows). To resolve this message, add --triplet x86-windows to keep the same behavior.
Computing installation plan...
The following packages will be built and installed:
raylib[core,use-audio]:x86-windows -> 4.5.0#1
Detecting compiler hash for triplet x86-windows...
Restored 0 package(s) from C:\Users\joffr\AppData\Local\vcpkg\archives in 272 us. Use --debug to see more details.
Installing 1/1 raylib:x86-windows...
Building raylib[core,use-audio]:x86-windows...
-- Using cached raysan5-raylib-4.5.0.tar.gz.
-- Cleaning sources at C:/vcpkg/buildtrees/raylib/src/4.5.0-5af5a3d891.clean. Use --editable to skip cleaning for the packages you specify.
-- Extracting source C:/vcpkg/downloads/raysan5-raylib-4.5.0.tar.gz
-- Applying patch fix-project-version.patch
-- Using source at C:/vcpkg/buildtrees/raylib/src/4.5.0-5af5a3d891.clean
-- Configuring x86-windows
CMake Error at scripts/cmake/vcpkg_execute_required_process.cmake:112 (message):
Command failed: C:/vcpkg/downloads/tools/ninja/1.10.2-windows/ninja.exe -v
Working Directory: C:/vcpkg/buildtrees/raylib/x86-windows-rel/vcpkg-parallel-configure
Error code: 1
See logs for more information:
C:\vcpkg\buildtrees\raylib\config-x86-windows-dbg-CMakeCache.txt.log
C:\vcpkg\buildtrees\raylib\config-x86-windows-rel-CMakeCache.txt.log
C:\vcpkg\buildtrees\raylib\config-x86-windows-out.log
Call Stack (most recent call first):
installed/x64-windows/share/vcpkg-cmake/vcpkg_cmake_configure.cmake:252 (vcpkg_execute_required_process)
ports/raylib/portfile.cmake:47 (vcpkg_cmake_configure)
scripts/ports.cmake:147 (include)

Please see https://github.com/microsoft/vcpkg/issues/30604 for how to report an issue.

Please see #30604 for how to report an issue.

got it, thanks. should i edit this post or make a new one?

I could install this port successfully with the latest vcpkg 2023-06-22-f19f3d9939100085fe2f7e41502d60b08e2083b6, could you please run following commands in your vcpkg folder:
1. git pull
2. .\bootstrap-vcpkg.bat
3. .\vcpkg install raylib[core,use-audio]:x86-windows --binarysource=clear

Thanks for posting this issue. Please make sure you have the following installed.
Visual Studio Desktop development with C++.
Windows 10 SDK or Windows 11 SDK.

Thanks for posting this issue. Please reopen this issue if this is still a problem for you.


code should be "cargo format" clean

... and currently isn't.
We should make sure the CI bails when the code isn't "cargo format" (currently it doesn't) and have a pre-commit hook that enforces this so that we minimize the changes of reintroducing divergence in the future.
(I'm postponing this for now because currently the CI doesn't pass for other reasons.)

As of 9efbd3d2bba028768a6bd76e4306a8321a19e4cb the code base is cargo format clean. Closing.


add documentation to support venafi issuer caBundleSecretRef

Documentation for the https://github.com/cert-manager/cert-manager/pull/7036 feature.

/approve
/lgtm


Remove all references to "eth1"

Changes wording to emphasise that eth2 is an upgrade to the consensus of Ethereum, not a replacement of "eth1".

one additional ref here to "Ethereum 1.0"
maybe

"to the deposit contract on Ethereum."
"to the deposit contract on the current Ethereum chain."
"to the deposit contract."
"to the deposit contract on Ethereum mainnet."


CAMEL-19058: rework the Message to avoid hitting the type-check scalability issue

This introduces a trait that works similarly to the internal properties one in the Exchange so that we carry certain details about the message without relying on type specifications.
Among other things this:

avoids unnecessarily recreating the DefaultMessage multiple times
moved the data type aware checks out of the hot path
reworks the isTransactedRedelivered to avoid costlier checks for specific message types

This superseds the proposed changes on #9432.
Additionally, this implements the same pattern of using an array for
internal properties as we already do on the Exchange. Subsequently, my
idea is to abstract this complex array manipulation in an specific class
so we can reuse code and simplify maintenance.

I wonder if we should move some of those trait out of the root package to avoid having to much stuff there (there is already too much) - as those are mostly for internal optimization use, then they better fit in .spi or in a new .trait package.

I wonder if we should move some of those trait out of the root package to avoid having to much stuff there (there is already too much) - as those are mostly for internal optimization use, then they better fit in .spi or in a new .trait package.

I like this idea. Let me explore it in one shot with this PR.
Also, I'm marking this one as a draft for a while. I found a bug in the JMS code and I'll need to review it.
Thanks!

Remarking as ready to review after fixing a bug in JMS changes. Also moved the traits to a separate trait package.

By chance do you have any benchmarks to share?

By chance do you have any benchmarks to share?

Yes I do. I am preparing a blog post with the details, methodology, etc. But here's a preview for the disruptor (in just few of the many other scenarios):
Obs.: the notation is inverted and the baseline is the code is the code with this patch and the test code is the test with 4.0.0-M1.
25 consumers + 25 producers:
GEOMETRIC MEAN (RATE):
Test:<PHONE_NUMBER>745428 | Baseline:<PHONE_NUMBER>009845
Delta: -72568.25922644173
The geometric mean rate was lower for the test than for the baseline

10 consumers + 9 producers:
GEOMETRIC MEAN (RATE):
Test:<PHONE_NUMBER>252476 | Baseline:<PHONE_NUMBER>985515
Delta: -73760.17987330398
The geometric mean rate was lower for the test than for the baseline

7 consumers + 3 producers:
GEOMETRIC MEAN (RATE):
Test:<PHONE_NUMBER>278101 | Baseline:<PHONE_NUMBER>864418
Delta: -123345.27195863164
The geometric mean rate was lower for the test than for the baseline

All in all, the new code tends to be faster in around 95% of the cases. The results from JMH also indicate the code being faster (i.e.; having a higher score in ops/ms - IIRC), although I don't have them easily at hand right now.