Flow says that Text nad Image are not React components

It is not possible to return JSX with an Image or a Text component from react-native which satisfies return type Element<typeof Image> or Element<typeof Text>.
Environment
Environment:
OS: Linux 4.13
Node: 8.10.0
Yarn: 1.5.1
npm: 5.6.0
Watchman: Not Found
Xcode: N/A
Android Studio: Not Found
Packages: (wanted => installed)
react: ^16.0.0 => 16.1.1
react-native: ^0.52.0 => 0.52.0
Flow version: 0.66.0
Expected Behavior
Flow should say "No errors".
Actual Behavior
Flow says that it is not a React component (the same errors are shown with an Image component):

Cannot instantiate Element because:
 • module Text [1] is not a React component.
 • in type argument ElementType:
    • Either a callable signature is missing in module Text [1] but exists in React.StatelessFunctionalComponent [2].
    • Or module Text [1] is incompatible with statics of React.Component [3].

     -
       4│ import React from 'react';
       5│ import type { Element } from 'react';
       6│
       7│ function MyText(props: Object): Element<typeof Text> {
       8│     return (
       9│         <Text {...props} />
      10│     );

     /tmp/flow/flowlib_10ce9ec3/react.js
 [2] 150│   | React$StatelessFunctionalComponent<any>
 [3] 151│   | Class<React$Component<any, any>>;

     node_modules/react-native/Libraries/react-native/react-native-implementation.js
 [1]  52│   get Text() { return require('Text'); },

Error ┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈ -:9:10

Cannot create Text element because module Text [1] is not a React component.

     -
      6│
      7│ function MyText(props: Object): Element<typeof Text> {
      8│     return (
      9│         <Text {...props} />
     10│     );
     11│ }
     12│

     node_modules/react-native/Libraries/react-native/react-native-implementation.js
 [1] 52│   get Text() { return require('Text'); },

Error ┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈ -:9:9

Cannot instantiate React.Element because:
 • module Text [1] is not a React component.
 • in type argument ElementType:
    • Either a callable signature is missing in module Text [1] but exists in React.StatelessFunctionalComponent [2].
    • Or module Text [1] is incompatible with statics of React.Component [3].

     -
       6│
       7│ function MyText(props: Object): Element<typeof Text> {
       8│     return (
       9│         <Text {...props} />
      10│     );
      11│ }
      12│

     /tmp/flow/flowlib_10ce9ec3/react.js
 [2] 150│   | React$StatelessFunctionalComponent<any>
 [3] 151│   | Class<React$Component<any, any>>;

     node_modules/react-native/Libraries/react-native/react-native-implementation.js
 [1]  52│   get Text() { return require('Text'); },

Found 5 errors

Only showing the most relevant union/intersection branches.

Steps to Reproduce
The simplest example:
// @flow

import { Text } from 'react-native';
import React from 'react';
import type { Element } from 'react';

function MyText(props: Object): Element<typeof Text> {
    return (
        <Text {...props} />
    );
}

export default MyText;

It gives the same errors when Text is replaced with Image but it works (no errors) when Text is replaced with View.

Yes, I can. I have the same results with the following setup:
Packages: (wanted => installed)
react: ^16.3.0-alpha.1 => 16.3.0-alpha.1
react-native: latest => 0.54.0

This is complicated to fix but I just finished going through it for View. Hopefully I’ll get to Text and Image by the next release cut.

@TheSavior Thanks that would be great! Because this problem means that every file which uses Text or Image shows errors which is quite uncomfortable.

I’m actually not sure why you are getting these errors. We don’t get these errors internally. I am planning on making modifications around this space right now but Text and Image shouldn’t be broken in the previous release... Hmm.

We have changed the types of these components a bunch. Does this still repro on 0.56.0-rc.2?

I'd like to try it again with a fresh project but currently I'm blocked by this problem: https://github.com/facebook/react-native/issues/19797 I'll write here again when it will be solved.

The fix for that has landed has landed but a new version hasn’t been cut yet. You can use the fix to the flowconfig from #19766 to be able to try to repro this issue.

Ok, #19766 led me to play around with .flowconfig file and I've found that we had nothing starting with module.system.haste in [options] section. Adding it solves my original problem even with version 0.55.0 so it looks like we missed somethink while upgrading to the newer version of react-native.
I'm sorry about that and I would like to thank you very much for your cooperation.


CustomScrollView does not support this plugin?

` sliver: SliverPadding(
padding: const EdgeInsets.only(left: 8, right: 8),
sliver: SliverToBoxAdapter(
child: ReorderableBuilder(
onReorder: (ReorderedListFunction  reorderedListFunction){
},
        key: gridViewKey,
        builder: (children){
          return SliverGrid(
            key: gridViewKey,..........`

flutter: The RenderPointerListener that expected a RenderBox child was created by: flutter:   Listener ← ReorderableScrollingListener ← ReorderableBuilder-[GlobalKey#efb17] ← flutter:   SliverToBoxAdapter ← SliverPadding ← SliverStickyHeader ← _WGroup ← GetBuilder<ZMenu> ← Viewport ← flutter:   IgnorePointer-[GlobalKey#846ae] ← Semantics ← Listener ← ⋯

Hello @wajipu
Currently it’s not really supported but it’s on the future list

You can implement it using SliverFillRemaining.
I implemented it like this:
import 'package:flutter/material.dart';
import 'package:flutter_reorderable_grid_view/widgets/reorderable_builder.dart';
import 'package:flutter_riverpod/flutter_riverpod.dart';

class GridTestPage extends ConsumerWidget {
  final _scrollController = ScrollController();
  final _gridViewKey = GlobalKey();
  final _fruits = <String>[
    "1",
    "2",
    "3",
    "4",
    "5",
    "6",
    "7",
    "8",
    "9",
    "10",
    "11",
    "12",
    "13",
    "14",
    "15",
    "16",
    "17",
    "18",
    "19",
    "20",
  ];
  @override
  Widget build(BuildContext context, WidgetRef ref) {
    final generatedChildren = List.generate(_fruits.length, (index) {
      return Container(
        key: Key(_fruits.elementAt(index)),
        color: Colors.lightBlue,
        child: Text(
          _fruits.elementAt(index),
        ),
      );
    });
    return Scaffold(
      body: CustomScrollView(
        slivers: <Widget>[
          SliverAppBar(
            pinned: true,
            floating: true,
            expandedHeight: 50,
            collapsedHeight: 0,
            toolbarHeight: 0,
            flexibleSpace: FlexibleSpaceBar(
              title: Text('Demo'),
            ),
          ),
          SliverPadding(
            padding: EdgeInsets.only(left: 10, right: 10),
            sliver: SliverFillRemaining(
              key: Key("sliver"),
              child: ReorderableBuilder(
                key: Key("ReorderableBuilder"),
                scrollController: _scrollController,
                onReorder: (ReorderedListFunction reorderedListFunction) {
                  // setState(() {
                  //   _fruits = reorderedListFunction(_fruits) as List<String>;
                  // });
                },
                children: generatedChildren,
                builder: (children) {
                  return GridView(
                    key: _gridViewKey,
                    controller: _scrollController,
                    gridDelegate: const SliverGridDelegateWithFixedCrossAxisCount(
                      crossAxisCount: 5,
                      mainAxisSpacing: 4,
                      crossAxisSpacing: 8,
                    ),
                    children: children,
                  );
                },
              ),
            ),
          ),
        ],
      ),
      floatingActionButton: FloatingActionButton(
        onPressed: () {},
        child: Icon(Icons.add),
      ),
    );
  }
}

I started to investigate how easy it is to implement a solution with SliverGrid.
Unfortunately the structure of this package doesn't support sliver widgets at all which means I have to make a rebuild of this package that should also support this kind of widgets.
I saw some solutions which support this but it has a totally different approach than this package.
What is possible:
You can use CustomScrollView along with this package by wrapping ReorderableBuilder with a sliver widget e.g. SliverToBoxAdapter. The solution would look like this:
import 'package:flutter/material.dart';
import 'package:flutter_reorderable_grid_view/widgets/widgets.dart';

void main() {
  runApp(const MaterialApp(home: MyApp()));
}

class MyApp extends StatefulWidget {
  const MyApp({super.key});

  @override
  State<MyApp> createState() => _MyAppState();
}

class _MyAppState extends State<MyApp> {
  final _scrollController = ScrollController();
  final _gridViewKey = GlobalKey();

  var _fruits = <String>["apple", "banana", "strawberry"];

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      body: CustomScrollView(
        controller: _scrollController,
        slivers: [
          SliverToBoxAdapter(
            child: ReorderableBuilder<String>.builder(
              scrollController: _scrollController,
              onReorder: (reorderedListFunction) {
                setState(() {
                  _fruits = reorderedListFunction(_fruits);
                });
              },
              childBuilder: (itemBuilder) {
                return GridView.builder(
                  key: _gridViewKey,
                  physics: const NeverScrollableScrollPhysics(),
                  shrinkWrap: true,
                  itemCount: _fruits.length,
                  itemBuilder: (context, index) {
                    return itemBuilder(
                      ColoredBox(
                        key: Key(_fruits.elementAt(index)),
                        color: Colors.lightBlue,
                        child: Text(_fruits.elementAt(index)),
                      ),
                      index,
                    );
                  },
                  gridDelegate: const SliverGridDelegateWithFixedCrossAxisCount(
                    crossAxisCount: 4,
                    mainAxisSpacing: 4,
                    crossAxisSpacing: 8,
                  ),
                );
              },
            ),
          ),
        ],
      ),
    );
  }
}

I will close this issue because there is already for supporting SliverGrid #99


dead link

https://link.springer.com/article/10.1007%2Fs00259-019-04541-y

see here: https://github.com/bids-standard/bids-website/actions/runs/2995204675


Add collection assert infix support

Ha! Looks like #404 beat me to it and my changes vanished when I rebased on upstream. Thanks @jensim !

Great minds think alike @checketts 😉👍


SUSPICIOUS DLL LOAD (METHODOLOGY).ioc is broken (missing end tags)

rule is currently terminating at 'sear' and the following is needed to complete the file:

ch="processEvent/processCmdLine" type="event" />
              <Content type="string">-userconfig</Content>
            </IndicatorItem>
          </Indicator>
        </Indicator>
      </Indicator>
  </criteria>
</OpenIOC>

Thanks for reporting this @pelamatt! Turns out that during our release process, an intermediate system truncated this large rule. I've updated the rule with its complete content.


Cypress Tests for Campaign Entry Creation

Description

Write E2E Cypress tests for #252 Campaign Entry Creation.
Possible Implementation

Check creation of campaigns for other members

Please add your planning poker estimate with ZenHub @pascwhale

Hey team! Please add your planning poker estimate with ZenHub @bcobo341 @IanjhPhillips @JasonGadoury @luigibesani @willyyhuang


Failed to login if password contain !

Unable to login via api getting "invalid user name or password (6)" exception if password contains exclamation character.
`Exception in thread "main" me.legrange.mikrotik.MikrotikApiException: invalid user name or password (6)
at me.legrange.mikrotik.impl.ApiConnectionImpl$SyncListener.getResults(ApiConnectionImpl.java:476)
at me.legrange.mikrotik.impl.ApiConnectionImpl$SyncListener.access$100(ApiConnectionImpl.java:430)
at me.legrange.mikrotik.impl.ApiConnectionImpl.execute(ApiConnectionImpl.java:114)
at me.legrange.mikrotik.impl.ApiConnectionImpl.execute(ApiConnectionImpl.java:72)
at me.legrange.mikrotik.impl.ApiConnectionImpl.login(ApiConnectionImpl.java:58)
at com.h8.mktapi305test.App.main(App.java:18)
Caused by: me.legrange.mikrotik.impl.ApiCommandException: invalid user name or password (6)
at me.legrange.mikrotik.impl.ApiConnectionImpl$Processor.run(ApiConnectionImpl.java:267)`

Can you please try this with the latest version, 3.0.6. I think this was fixed in #67 which I merged in October but which I forgot to make a new release for and released this morning.
I tested this this morning with password "123!456" and "!123456" and it does seem to be fixed.
Gideon


Changes the route-href so that it can be used on custom elements

In relation to the issue by @thomas-darling (https://github.com/aurelia/templating-router/issues/36), I have modified the route-href custom attribute, so that it can be rationally applied to custom elements.
With this change existing behavior remain unchanged, however, when applied to a custom element, this will get an href property on its view-model having the generated route. Refer to the mentioned issue for a use-case scenario.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Mikkel Todberg seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

Is there a scenario where this.element.au.controller.viewModel can be null? If so, we need another check for that @EisenbergEffect.

Thanks @Todberg


Implement jobs

TODO:

[x] docs
[ ] this is now done only for github webhooks: implement the same thing for fedmsg (in a new PR)

Fixes #103

Rebased, all tests pass for me locally, please review!

Tests are passing, I forgot to clean up the first commit after rebase. Sadly pre-commit does not run on rebase.


Highlighting the active dropdown item

<UncontrolledDropdown>
               <DropdownToggle nav caret>
                       Availability
                </DropdownToggle>
                <DropdownMenu>
                       <DropdownItem href="url">
                                 Backup
                       </DropdownItem>
                       <DropdownItem href="url">
                                 Restore
                       </DropdownItem>
                       <DropdownItem href="url">
                                  Share
                       </DropdownItem>
                </DropdownMenu>
 </UncontrolledDropdown>

How can I highlight the dropdown item which is selected? I tried adding <NavLink activeClassName="active-item">Restore</NavLink> inside <DropdownItem> but it doesn't work.

Add active prop to DropdownItem component to style them as active.
Demo

Yes, of course! This library adds the bootstrap classes which use CSS. You can override the SASS variables in bootstrap and create a custom style. In this situation, you should override the dropdown-item active class to provide a custom active dropdown style.
Demo

I am closing this issue as it appears to be resolved. If that is not correct, please feel free to comment and it will be reopened.


data:Tk-brainCodes

Changes proposed
Add a new file data/Tk-brainCodes.json which contains my Linkfree profile links

[x] My code follows the code style of this project.
[x] This PR does not contain plagiarized content.
[x] The title of my pull request is a short description of the requested changes.

Note to reviewers
This PR contains my bio data for Linkfree, in the directory data/Tk-brainCodes .

We look forward to seeing your Profile on BioDrop, but as there is no recent activity from you to make the changes suggested I am going to close this pull request.
We hope you will raise a new pull request to create your Profile and when you do, you might want to take a look at these Docs which will help with the suggested changes the maintainers have proposed.
Please remember you can also create your Profile using Forms.


In memory label propagation community detection

[!IMPORTANT]
Replaces graph projection with in-memory label propagation for community detection, updates functions and tests, and removes Neo4j GraphDataScience Plugin requirement.

Community Detection: Replaces graph projection with in-memory label propagation in get_community_clusters() in community_operations.py. Introduces Neighbor class in community_operations.py to support label propagation.
Function Updates: Updates build_communities() in graphiti.py to use the modified get_community_clusters().
Testing: Updates test_graphiti_int.py to call build_communities() during tests.
Misc: Removes Neo4j GraphDataScience Plugin requirement from README.md.

This description was created by  for 7a43c41083d8120ca5fd5b1f9634ac50cf724001. It will automatically update as commits are pushed.

@prasmussen15 I see the following when running build_communities from this branch
  File "/Users/danielchalef/dev/zep/chat-tenetmedia/ingest.py", line 408, in <module>
    asyncio.run(main())
  File<EMAIL_ADDRESS>line 194, in run
    return runner.run(main)
           ^^^^^^^^^^^^^^^^
  File<EMAIL_ADDRESS>line 118, in run
    return self._loop.run_until_complete(task)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File<EMAIL_ADDRESS>line 687, in run_until_complete
    return future.result()
           ^^^^^^^^^^^^^^^
  File "/Users/danielchalef/dev/zep/chat-tenetmedia/.venv/lib/python3.12/site-packages/langfuse/decorators/langfuse_decorator.py", line 217, in async_wrapper
    self._handle_exception(observation, e)
  File "/Users/danielchalef/dev/zep/chat-tenetmedia/.venv/lib/python3.12/site-packages/langfuse/decorators/langfuse_decorator.py", line 508, in _handle_exception
    raise e
  File "/Users/danielchalef/dev/zep/chat-tenetmedia/.venv/lib/python3.12/site-packages/langfuse/decorators/langfuse_decorator.py", line 215, in async_wrapper
    result = await func(*args, **kwargs)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/danielchalef/dev/zep/chat-tenetmedia/ingest.py", line 388, in main
    await client.build_communities()
  File "/Users/danielchalef/dev/zep/chat-tenetmedia/.venv/lib/python3.12/site-packages/graphiti_core/graphiti.py", line 569, in build_communities
    community_nodes, community_edges = await build_communities(self.driver, self.llm_client)
                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/danielchalef/dev/zep/chat-tenetmedia/.venv/lib/python3.12/site-packages/graphiti_core/utils/maintenance/community_operations.py", line 199, in build_communities
    community_clusters = await get_community_clusters(driver)
                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/danielchalef/dev/zep/chat-tenetmedia/.venv/lib/python3.12/site-packages/graphiti_core/utils/maintenance/community_operations.py", line 70, in get_community_clusters
    cluster_uuids = label_propagation(projection)
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/danielchalef/dev/zep/chat-tenetmedia/.venv/lib/python3.12/site-packages/graphiti_core/utils/maintenance/community_operations.py", line 109, in label_propagation
    new_community = max(community_lst[0][1], curr_community)
                        ~~~~~~~~~~~~~^^^
IndexError: list index out of range```


feat: update partial tag names to follow Django convention

Rename 'startpartial' to 'partialdef'
Update corresponding end tag to 'endpartialdef'
Alias old 'startpartial' and add a DeprecationWarning when used
Update existing test_partial_tags test case
Add test_deprecated_startpartial_tag test case

BREAKING CHANGE: The tag name 'startpartial' is deprecated and will be removed in future versions. Use 'partialdef' instead.
Fixes issue #12 - templatetag incompatible with IntelliJ editors.

@scriptogre Fancy looking at the test errors here? Thanks.

Merged into main as 4c3c9cdb0984670beab032162856f8cf73fcdde2. Thanks for this @scriptogre! It'll be in the next release shortly. 🎁


Re-enable --shell-escape for LaTeX

Similar to f7bb61b5166e, but for main wscript. Was there any reason to disable it that I cannot remember? Leaving it on is crucial for the Stata template because the only thing Stata consistently produces are eps-files and they need conversion to pdf before being useful to pdflatex.

we disabled it for azure, is it an option to save the stuff as png instead of eps, or directly as pdf (do we need shell escape then?)

No, at least older versions of Stata relied on some library to generate pngs that was only available as GUI... Maybe they took the graph they displayed and made a screenshot :-)
So we should leave the comment where it is unless we are using the Stata example.

i am pretty sure, stata 13 at least already supports png, do we really need to care for older versions?

Yes, but to my best recollection only the GUI version of Stata, not the command line version, which is what we need.

fixed in #65

Just for reference: https://www.stata.com/statalist/archive/2011-07/msg00536.html


Fix typo

As the # Typo in name comment is trying to explain, the typo here is intentional.  One of the benefits of verifying doubles is that they catch typos like this, and this scenarios is trying to demonstrate that.


The demo is not working! It stays on the loading screen!

Hello guys,
I am working on this repo.
It works successfully on localhost. However, when I get build with next.js and export it, it stays as "loading". Same with the current demo on github right now.
Is there anyone who has experienced the same problem? Your help is really appreciated.

Thanks for letting us know @3web3, we're taking a look into this

Hey @3web3 this should be fixed now - let me know if you're still running into any issues or i'll close this one!

I've published it on my own server before without any problems. This is a big problem for those who want to host on their own server like me.

You shouldn't need to build/export - I don't think that method will work.
You can deploy with a site that is Next.js compatible like Netlify or Vercel, here's a guide https://www.netlify.com/blog/2020/11/30/how-to-deploy-next.js-sites-to-netlify/

You shouldn't need to build/export - I don't think that method will work.
You can deploy with a site that is Next.js compatible like Netlify or Vercel, here's a guide https://www.netlify.com/blog/2020/11/30/how-to-deploy-next.js-sites-to-netlify/

It was working before. I have successfully hosted it on my own server.

Hello @jarrodwatts,
What might be causing this problem? My server supports node.js and it was working before. Can you take a look at this thread for those who want to host it on their own server? This is really much appreciated.

This issue looks stale to me, can we close this? @eabdelmoneim @atharvadeosthale

Hi! when i trying to open demo get.
Client ID is required as a query param to use this page.

@ramykatour should be fixed now

@ramykatour should be fixed now

thank you


single tag archive template

create a template for displaying single tags, with tag image and description.

finished, will be available on v0.2.0


[SPARK-30688][SQL] Week based dates not being parsed with TimestampFormatter

What changes were proposed in this pull request?

When executing the following query using a week based pattern the result is null.
scala> spark.sql("select unix_timestamp('2020-10', 'YYYY-ww')").show
+--------------------------------+
|unix_timestamp(2020-10, YYYY-ww)|
+--------------------------------+
|                            null|
+--------------------------------+

You can replicate this behavior with:
import java.time.temporal._
import java.time.format._
import java.util.Locale
import java.time.chrono.IsoChronology

val pattern = "YYYY-ww"
val locale = Locale.US
val s = "2020-10"
val formatter = new DateTimeFormatterBuilder().appendPattern(pattern)
    .parseDefaulting(ChronoField.ERA, 1)
    .parseDefaulting(ChronoField.MONTH_OF_YEAR, 1)
    .parseDefaulting(ChronoField.DAY_OF_MONTH, 1)
    .parseDefaulting(ChronoField.MINUTE_OF_HOUR, 0)
    .parseDefaulting(ChronoField.SECOND_OF_MINUTE, 0)
    .toFormatter(locale)
    .withChronology(IsoChronology.INSTANCE)
    .withResolverStyle(ResolverStyle.STRICT)

val result = formatter.parse(s)
result.query(TemporalQueries.localDate)

The date is parsed, but not resolved.
This is caused by the default temporal fields that are conflicting with the week based values:
      .parseDefaulting(ChronoField.ERA, 1)
      .parseDefaulting(ChronoField.MONTH_OF_YEAR, 1)
      .parseDefaulting(ChronoField.DAY_OF_MONTH, 1)

To avoid this conflict, I propose to check if the pattern is a week/year based and change the defaults as follows:
      .parseDefaulting(ChronoField.ERA, 1)
      .parseDefaulting(ChronoField.DAY_OF_WEEK, 1)

Why are the changes needed?

Week/Year based dates should be supported since it is part of ISO8601. Also, as seen in SPARK-30688, this issue is failing silently.
Does this PR introduce any user-facing change?

No

How was this patch tested?

Passing current tests
Added test case for different timezones in DateExpressionsSuite.scala

Can one of the admins verify this patch?

Can one of the admins verify this patch?

cc @MaxGekk since you're touching the codes around here.

Can one of the admins verify this patch?

ping @MaxGekk @HyukjinKwon :)


support for laravel 5.5

is it support for laravel 5.5 ?

support for laravel 5.5 is coming soon. you can track it here. https://github.com/InfyOmLabs/laravel-generator/issues/470

Hi @mitulgolakiya
Which version do we install? Still v5.4 for Laravel 5.5.  Because when I visit Labs yet no new documentation version found.
Thanks.

@devaescasio laravel 5.5 is still under development. I had done very good progress on that. It will be available soon. But as of now, you should use 5.4.


Add script_flags seeds

Can only be merged after https://github.com/bitcoin/bitcoin/pull/20242

Coverage before (just this target): https://drahtbot.space/host_reports/DrahtBot/reports/coverage_fuzz/MarcoFalke/bitcoin-core/88271184e82222f5/fuzz.coverage/index.html
Coverage after: https://drahtbot.space/host_reports/DrahtBot/reports/coverage_fuzz/MarcoFalke/bitcoin-core/fa56d56d4e9b69fd/fuzz.coverage/index.html


Proposal: INCLUDE syntax for specifying multiple images per context

Multiple use cases call for an ability to build several Docker images from a single context. An example would be a set of microservices that reside in a shared repository, because they also share common libraries. The common folder layout looks like this:
/README.md
/bar-service/...
/foo-service/...
/common/...

An ideal solution would:

allow to specify one (or more) image to be built for each service
co-locate the Dockerfile(s) of the service inside the folder of the corresponding service
have a default build action that would build all images
have an option to only build one specific image

This proposal is to introduce a new verb in the Dockerfile that would look like this:
INCLUDE /bar-service/Dockerfile.foo AS bar-service and a CONTEXT verb to be used in the included Dockerfiles.
The INCLUDE verb can be used multiple times. If there is an INCLUDE in a Dockerfile, it must come before the FROM verb in that file and FROM verb becomes optional.
If such line is included in the root Dockerfile and a user runs docker build -t aigarius/xyz . then this verb would have the following effects:

docker build specified in the file /bar-service/Dockerfile.foo would be build and tagged as aigarius/xyz/bar-service.foo;
the included Dockerfile may optionally use the new CONTEXT verb to shift the context up to the parent folder, such as if /bar-service/Dockerfile.foo includes a line CONTEXT .., then the ADD/COPY commands will work in the context of the parent folder. If such verb is not used, then the context of the included build is the folder containing the included file;
after this line in the root Dockerfile or in any subsequently included Dockerfiles the invocation of FROM bar-service:included would use the newly built bar-service image as a base.

In addition it should be possible for a user to run docker build -t aigarius/xyz --images=bar-service,foo-service . to only build images of those two services.
Tag ":included" should be considered to be equivalent to ":latest" (possibly with a warning) if there is no build with such name in the current build set.
CONTEXT verb shifts the context for a Docker build relative to the Dockerfile. This can be used to only have a subfolder of the original context be uploaded to the daemon. It can also be used to shift the context folder up, but only if the Dockerfile is included in another Dockerfile higher in the path and only up to the folder of the top level Dockerfile.

closed as duplicate of https://github.com/docker/docker/issues/7115, trying to consolidate so we can get cool stuff like this is


Update dependencies to remove arweave.dev gateway

Ready for review. Went ahead and updated all Arweave dependencies, which fixed the issue.


proposal: spec: allow overloading generic functions strictly on type constraints

Proposal: Overload Generic Functions
Summary
This proposal suggests introducing support for function overloading with generic constraints in the Go programming language. The goal is to provide a more expressive and flexible way to define multiple function signatures for a single function name, based on the type constraints of the generic parameters.
Motivation
Currently, the Go programming language does not support function overloading, which means that multiple functions with the same name but different parameter types cannot coexist. This limitation can lead to naming conflicts and reduce code readability. Additionally, when working with generic functions, it can be challenging to provide different behaviors based on the types of the generic parameters.
By introducing support for function overloading with generic constraints, Go developers would gain the ability to define multiple function signatures for a single function name, taking into account the type constraints of the generic parameters. This would provide a more intuitive and expressive way to handle different cases and improve the overall code organization and readability.
Proposal
The proposal suggests extending the Go language syntax to allow function overloading with generic constraints. Here's an example of the proposed syntax:
func Foo[T any](x T) {
    // Function implementation for generic case
}

func Foo[T constraint1](x T) {
    // Function implementation for constraint1 case
}

func Foo[T constraint2](x T) {
    // Function implementation for constraint2 case
}

Example
package main

import "fmt"

type Number interface {
	~int | ~int8 | ~int16 | ~int32 | int64 | uint | uint8 | uint16 | uint32 | uint64 | float32 | float64
}

// Foo is a function that has three different function signatures based on the type constraints of the generic parameter T.
func Foo[T any](x T) {
	fmt.Println("Generic function with any type:", x)
}

func Foo[T string](x T) {
	fmt.Println("Generic function with String constraint:", x)
}

func Foo[T Number](x T) {
	fmt.Println("Generic function with Numeric constraint:", x)
}

func main() {
	Foo(10)         // Calls the generic function with Numeric constraint
	Foo("Hello")    // Calls the generic function with Stringer constraint
	Foo(true)       // Calls the generic function with any type
}

In the example above, Foo is a function that has three different function signatures based on the type constraints of the generic parameter T. The compiler would select the appropriate function implementation based on the actual type of T when the function is called.
Compatibility and Impact
The proposed feature of function overloading with generic constraints does not introduce any backward compatibility issues. Existing code using generic functions without constraints will remain unaffected, as the overloaded functions would only be called when the appropriate constraints are satisfied.
Implementation Details
The implementation of function overloading with generic constraints would require changes to the Go compiler to handle the resolution of overloaded function calls based on the type constraints of the generic parameters. The compiler would need to analyze the available function signatures and select the most specific function implementation that satisfies the constraints at the call site.
Alternatives Considered
An alternative approach to achieving similar functionality is to use function suffixes or different function names to represent different implementations of generic functions with constraints. However, this approach can lead to less readable code and make the API surface more cluttered.
Conclusion
The addition of function overloading with generic constraints in Go would enhance the expressiveness and flexibility of generic functions. It would enable the creation of more reusable and readable code by allowing multiple function signatures with different constraints to coexist under the same function name. This proposal aims to improve the capabilities of Go's generics and align with the goal of making the language more powerful and expressive.

@fzipp
methods with the same name but different signatures was occasionally useful but that it could also be confusing and fragile in practice
I agree with you. Traditional method overloading with varying number of parameters as in Ruby or different parameter types as in Typescript is confusing.
Same would have been the case with Go as well. But go1.18 changes it all by introducing generics constraints.
Top-down debugging of the code as well as readability won't be affected as we can pinpoint to the implementation of the overloaded function that's being called by just checking the argument types. Gopls can navigate the gofer to the right implementation of the function cuz the type of the argument of the function is determined statically not dynamically.

Go intentionally doesn't support function overloading for regular functions and methods.

I think this should always be the case.
On the other hand, generic functions with the constraints implementation gives the developer a headup ! that the the function is built to handle multiple types

Currently Function overloading [in a sense] is only possible by leveraging build constraints. But it makes troubleshooting difficult.

package main

func IsZero[P int] (n P) bool {
	return n==0
}

func IsZero[P string] (n P) bool {
	return n==""
}

func main() {
	IsZero(1)
	IsZero("hey")
}

This was my proposal all along - overloading generics with varying type constraints.

@atdiar
I think you got me wrong there. I meant that the code i provided should run! Obviously I know the generic implementation of isZero. To remove further confusions down the road, i have deleted the comment...

@Nasfame I recommend you start fact checking GPT's output.

The compiler would need to analyze the available function signatures and select the most specific function implementation that satisfies the constraints at the call site.

What defines "most specific"?
type A interface {
	A()
}

type B interface {
	B()
}

type S struct{}

func (S) A() {}

func (S) B() {}

func Foo[T any](t T) {}

func Foo[T A](t T) { t.A() }

func Foo[T B](t T) { t.B() }

func main() {
	Foo(S{}) // Which version gets called?
}

@atdiar if you are looking for usecases. As an alternative to function overloading, go suggests abstractions with interface and polymorphism.
type Shape interface {
    Area() float64
}

type Rectangle struct {
    Width  float64
    Height float64
}

func (r Rectangle) Area() float64 {
    return r.Width * r.Height
}

type Circle struct {
    Radius float64
}

func (c Circle) Area() float64 {
    return math.Pi * c.Radius * c.Radius
}

Judging from functional paradigm, with functional overloading we can have multiple multiple implementations of Area
func Area[P Rectangle] (r P) float64{}
func Area[P Circle] (r P) float64{}

Advantages := There is no need for creating interfaces like Shape; implement empty methods to satisfy .
@atdiar  the proposal is to enable flexibility to the developer to choose a paradigm which he thinks is the best for the project.

What defines "most specific"?

@rittneje
for starters- We can restrict the ambiguity by only allowing overloading for generic constraints without inner block.

The compiler would need to analyze the available function signatures and select the most specific function implementation that satisfies the constraints at the call site.

The compilation fails as go cannot use interfaces with methods in union. Go compiler fails to construct the unified constraints for the Foo
type constraints interface {
	any | A() | B()
}

@fzipp while other languages support regular function overloading; the proposal is to overload constraints not the function signature

see also #45380 and related proposals

We can run this through the proposal process but in my opinion there is no chance that it will be accepted.  Go rejected function overloading based on argument types from the very start.  This is just another form of function overloading.  The reasons that Go does not support overloading for argument types apply just as well to constraints.

Go has already has ad-hoc based polymorphism, the operator + | - | * | % | /, but not allow user defined functions do this.
If we accept this, we also can accept #57975

Refining the proposal- #61177 -v2
func Foo[T int | string | any](x T)  //declare the overloading function #inspired from go:linkname directive

func Foo[T string](x T) {
	fmt.Println("Generic function with string constraint:", x)
}

func Foo[T int](x T) {
	fmt.Println("Generic function with int constraint:", x)
}

func Foo[T any](x T) {
    fmt.Println("Generic function with any constraint:", x)
}

func main() {
	Foo(10)         // Calls the generic function with int constraint
	Foo("Hello")    // Calls the generic function with string constraint
	Foo(true)       // Calls the generic function with any constraint
}

Takeaways

[x] generic overloaded function should be declared with all the constraints
[x] allow overloading on constraint types strictly i.e similar to Typescript
[x] implement the overloaded function

[x] zero tolerance on ambiguity
[x] no multiple implementations for the same constraint type.
[x\ Note any is an exception for the above rule.

[x] Successful compilation requires

[x] implementation of all the constraints in the declaration

[x] Compiler -

[x] inlines the appropriate function body at the function call site

[x] warns users in case of ambiguity in constraints [~int, int] - "overlapping terms int and ~int"

Based on the discussion above, and the emoji voting, this is a likely decline.  Leaving open for three weeks for final comments.

No further comments.

@ianlancetaylor would u mind sharing why was the proposal declined? This would provide me insights on bringing up proposals for both Go1 and Go2 in future.
Also, I can see that this proposal was moved to Go 2 by you. May I know why u find this proposal not backwards compatible?
As far as I only directive go:linkname supports function definitions with body. And the proposal doesn't have conflicts with its working.

As I said in https://github.com/golang/go/issues/61177#issuecomment-1624260996, Go doesn't do function overloading.
All language changes get the v2 tag.  It doesn't mean that they are not backward compatible.


À trous 1D convolution slow in certain scenarios

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): Yes
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Linux Ubuntu 16.04
TensorFlow installed from (source or binary): binary
TensorFlow version (use command below): 1.10.1
Python version: 3.5.2
CUDA/cuDNN version: 9.0.176
GPU model and memory: CPU
Exact command to reproduce: See below
Bazel version: N/A
Mobile device: N/A

Describe the problem
Running
tf.nn.atrous_conv2d(images, filters, rate=dilation_rate, padding="SAME")
and
tf.nn.convolution(images, filters, dilation_rate=[dilation_rate, dilation_rate], padding="SAME")
takes much more time to run than:
tf.nn.convolution(images, filters, dilation_rate=[1, dilation_rate], padding="SAME")
for 1D convolutions.
I don't think this is supposed to behave like this, provided that the input data is one dimensional along the width or the height (i.e. shape = [batch, 1, width, channels] or [batch, height, 1, channels]) since in this case, no dilation is needed on the corresponding axis.
A person using tf.nn.atrous_conv2d for 1D "à trous" convolutions might never notice the issue here, and his network will be really slow to train.
Source code / logs
A small snippet to compare the performance of the different methods
import tensorflow as tf
import numpy as np
import time

# Scenario
batch_size = 100
channels = 3
o_channels = 10
image_size = 160
filter_size = 3

# Dummy images and filters
images = tf.random_normal(shape=[batch_size, 1, image_size, channels],  dtype=tf.float32)
filters = tf.random_normal(shape=[1, filter_size, channels, o_channels], dtype=tf.float32)

# Ops definition
normal_conv = tf.nn.convolution(images, filters, padding="SAME")
atrous_convs = []
atrous_convs_wrapper = []
for i in [5, 10, 20, 50]:
    atrous_convs.append({"dilation": i, "op": tf.nn.convolution(images, filters, dilation_rate=[1, i], padding="SAME")})
    atrous_convs_wrapper.append({"dilation": i, "op": tf.nn.convolution(images, filters, dilation_rate=[i, i], padding="SAME")})
    # Or
    # atrous_convs_wrapper.append({"dilation": i, "op": tf.nn.atrous_conv2d(images, filters, rate=i, padding="SAME")})
# Test
with tf.Session() as sess:
    repeats = 50

    for conv in atrous_convs:
        op1 = conv["op"]
        op2 = [elt for elt in atrous_convs_wrapper if elt["dilation"] == conv["dilation"]][0]["op"]
        op1_res, op2_res = sess.run([op1, op2])
        np.testing.assert_equal(op1_res, op2_res)

    # Benchmark normal method
    start = time.time()
    for _ in range(repeats):
        _ = sess.run(normal_conv)
    end = time.time()
    normal_conv_time = int((end - start) / repeats * 1000)

    # Benchmark atrous conv method
    for conv in atrous_convs:
        start = time.time()
        for _ in range(repeats):
            _ = sess.run(conv["op"])
        end = time.time()
        conv.update({"time": int((end - start) / repeats * 1000)})

    for conv in atrous_convs_wrapper:
        start = time.time()
        for _ in range(repeats):
            _ = sess.run(conv["op"])
        end = time.time()
        conv.update({"time": int((end - start) / repeats * 1000)})

    print("Normal conv: {}ms".format(normal_conv_time))
    for conv in atrous_convs:
        print("Atrous conv w/ dilation {}: {}ms".format(conv["dilation"], conv["time"]))
    for conv in atrous_convs_wrapper:
        print("Atrous conv(wrapper) w/ dilation {}: {}ms".format(conv["dilation"], conv["time"]))

returns
Normal conv: 1ms
Atrous conv w/ dilation 5: 1ms
Atrous conv w/ dilation 10: 2ms
Atrous conv w/ dilation 20: 1ms
Atrous conv w/ dilation 50: 2ms
Atrous conv(wrapper) w/ dilation 5: 4ms
Atrous conv(wrapper) w/ dilation 10: 9ms
Atrous conv(wrapper) w/ dilation 20: 15ms
Atrous conv(wrapper) w/ dilation 50: 47ms

Thank you for your post. We noticed you have not filled out the following field in the issue template. Could you update them if they are relevant in your case, or leave them as N/A? Thanks.
Bazel version
Mobile device

@tensorflowbutler Done :)

The best might be to simply specify it in the documentation. Something along theses lines for the atrous_conv2d doc:

Before

This function is a simpler wrapper around the more general tf.nn.convolution, and exists only for backwards compatibility. You can use tf.nn.convolution to perform 1-D, 2-D, or 3-D atrous convolution.

After

This function is a simpler wrapper around the more general tf.nn.convolution, and exists only for backwards compatibility. Make sure to use tf.nn.convolution to perform 1-D, 2-D, or 3-D atrous convolutions, by specifying the proper dilation rate for your input.

Be especially wary not to use this function to perform 1-D atrous convolutions, since we zero-pad the input tensor to have a size multiple of the dilation rate along the corresponding dimensions, which will affect the performance of the operation.

Or you could put up a warning in the atrous_conv2d function if you notice that the input tensor is one dimensional along the width or height axis.

Nagging Assignee @skye: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

@skye Hi, is there any update made in the documentation as per above ?

Nagging Assignee @skye: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @skye: It has been 29 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @skye: It has been 44 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @skye: It has been 59 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

@zbitouzakaria,

If the rate parameter is equal to one, it performs regular 2-D convolution. If the rate parameter is greater than one, it performs convolution with holes, sampling the input values every rate pixels in the height and width dimensions. This is equivalent to convolving the input with a set of upsampled filters, produced by inserting rate - 1 zeros between two consecutive values of the filters along the height and width dimensions, hence the name atrous convolution or convolution with holes.
Does this explanation not suffice, given here. Thank you!


add Tensor::is_contiguous

Tensor::is_contiguous: returns true if this tensor is stored contiguously in memory

Yup, good to have this addition, otherwise it's hard to tell when a matmul can be performed 👍


Atom fails to install package 1.0.6

Issue Type
Bug
Issue Description
Fails to install in Atom with the error:
Bug Checklist

[Y] Restart Atom
[Y] Go to Install Packages, find linter-eslint-node and click Install
[Y] Paste the output of the Install Packages screen alert

Installing<EMAIL_ADDRESS>failed.
Package version: 1.0.6 not found

Note: clicking on the package name opens the link https://atom.io/packages/linter-eslint-node
This returns:
Error 500

This is a known issue related to website errors on atom.io. See: atom#25438, atom#25426.
One workaround is to install directly from GitHub via terminal…
apm install AtomLinter/linter-eslint-node

…but I have not tried this yet. I don't know if it requires uninstalling the version from atom.io, or if you'd still get automatic updates. I am holding out hope that the website issue is just a simple fix and somebody's just on vacation or something.
So this isn't our bug. But I'll keep this issue open for visibility until the website problems are fixed.

Got it.
Thanks for the advice, the good news is apm was able to install the package. Hopefully Atom can fix this at their end.

Keeping this open so people will see it if they try to report this again.

apm install AtomLinter/linter-eslint-node
Cloning https://github.com/AtomLinter/linter-eslint-node.git failed
Installing modules done
Cannot read property 'getReferenceTarget' of null

I'm getting this error. It doesn't show up in my packages.

It doesn't happen for me. Can you try installing some other package via apm and see if the same error occurs?

using apm worked for me on atom 1.61.0-beta0


Editing config-kafka causes consolidated channel controller to panic and block forever

Describe the bug
2 problems:

When there's an existing Kafka Channel, it can't be deleted when I modify config-kafka.

To Reproduce
Steps to reproduce the behavior.
Knative release version
Additional context
Add any other context about the problem here such as proposed priority

/assign


Allows correlation fields to not match BaggageField names

This helps port code which formerly added different naming conventions
for span IDs.
Ex. If your log property is %X{trace-id}, you can do this:
builder.clear(); // traceId is a default field!
builder.addField(BaggageFields.TRACE_ID, "trace-id");

PS I noticed sleuth has an old thing that maps multiple names for trace ID. It is better to overlap scope decorators than handle this internally


Profile detail fetch issue

The profile detail module is not fetching data and showing this error:

Also previous profiles are read on the dashboard but not on the profiles screen neither on the hud


Adding debounce feature for Input component.

It would be great to have debounce and debounceTime props for the Input component that will simplify implementing debounce for the developer.
Below props can be added to the Input component:

debounce: boolean (When set to true, enables debouncing, default - false)
debounceTime: number (Takes time (in ms) which set the response time of a debounce, defaults to 500ms or whatever reviewer agrees to)

We can further decide on below -

Using a third party useDebounce hook.
Developing a useDebounce hook from scratch.

I think this should be the responsibility of the developer.
The great thing is, these components are building blocks that give the developer a lot of flexibility to tweak/extend to their own liking.

@kevinmitch14, yes correct
@AtharvaJoshi16 for debounce, if you are not using lodash you can use mantine useDebounceState hook

This issue has been automatically closed because it received no activity for a while. If you think it was closed by accident, please leave a comment. Thank you.


md-form-field label/placeholder incorrect state with reactive form

Bug
What is the expected behavior?
when we set Control in form group to assign value to mdInput placeholder should go into there position
What is the current behavior?
placeholder or label doesn't move to the position after set control
What are the steps to reproduce?
Link stackbliz
Just click 'TEST' the problem will occure at input field
What is the use-case or motivation for changing an existing behavior?
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
Is there anything else we should know?

play around.
It work correctly if not set new FormControl.

This is already mentioned in #6849

thank you so i close this


[FocusTrap] Fix Shadow DOM issue moving focus outside

[ ] I have followed (at least) the PR section of the contributing guide.

Fixes #34980

I'm getting some authorization errors when running CCI on my fork:
https://app.circleci.com/pipelines/github/arminbashizade/material-ui?branch=focus-trap-shadow-dom
@gzrae since you edited the PR I'm tagging you for help

@arminbashizade I am not sure what is the issue. Can you check the authorization settings on your forked repo?

The issue with the recursive drill-down approach is that the shadowRoot property is null in the closed mode.
I believe it is more a conceptual issue than a technical one. Usually, we want to avoid crossing shadow dom boundaries.
Let's suppose we are using a third-party component encapsulated in a shadow dom implementing a customizable select box. Once a user focuses it, we have two active elements:

from the select box perspective: some element (probably an input) inside the select box dom tree.
from the outer scope using the select box: the entire select box.

So, the activeElement()'s result depends on the context. We can provide the context to the function by passing a reference dom node. Then, the function would call referenceNode.getRootNode().activeElement to detect the root of the current dom tree, either shadow or not.

Since this PR is inactive and in draft, I am closing it. Please create a new PR pointing to the next branch if you want to fix it.


Fix typo in upgrade guide

Via: https://gitter.im/bigchaindb/bigchaindb?at=5951653a11755ab05625ce53

Codecov Report

Merging #69 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #69   +/-   ##
=======================================
  Coverage   74.64%   74.64%
=======================================
  Files          21       21
  Lines         284      284
=======================================
  Hits          212      212
  Misses         72       72

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c83181f...4c34f33. Read the comment docs.


Improve the home page

Intends to address

[x] Fixes #855
[x] Fixes #851
[ ] Fixes #854
[ ] Fixes #853

I have updated your comment to link to the original issues; see Development on the side:

If you end up not fixing an issue, you should remove the Fixes from the comment.

Ahh. Thanks. Ok. I've never noticed any one using that before in the HoloViz projects?

Thanks a lot Marc, I've only made some small changes.


Installation fails on Windows, possibly due to UTF-8 encoding issues

Hello!  Thanks for creating this!
Following your installations instruction verbatim from your video (https://www.youtube.com/watch?v=qXxO7SvbGs8) on Windows 11 resulted in the following error when running:

pip install .

The error was:
C:\Code\agency-swarm>pip install .
Processing c:\code\agency-swarm
  Installing build dependencies ... done
  Getting requirements to build wheel ... error
  error: subprocess-exited-with-error

  × Getting requirements to build wheel did not run successfully.
  │ exit code: 1
  ╰─> [21 lines of output]
      Traceback (most recent call last):
        File "C:\Users\Bret\AppData\Local\Programs\Python\Python312\Lib\site-packages\pip\_vendor\pyproject_hooks\_in_process\_in_process.py", line 353, in <module>
          main()
        File "C:\Users\Bret\AppData\Local\Programs\Python\Python312\Lib\site-packages\pip\_vendor\pyproject_hooks\_in_process\_in_process.py", line 335, in main
          json_out['return_val'] = hook(**hook_input['kwargs'])
                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        File "C:\Users\Bret\AppData\Local\Programs\Python\Python312\Lib\site-packages\pip\_vendor\pyproject_hooks\_in_process\_in_process.py", line 118, in get_requires_for_build_wheel
          return hook(config_settings)
                 ^^^^^^^^^^^^^^^^^^^^^
        File "C:\Users\Bret\AppData\Local\Temp\pip-build-env-b81tpqjt\overlay\Lib\site-packages\setuptools\build_meta.py", line 325, in get_requires_for_build_wheel
          return self._get_build_requires(config_settings, requirements=['wheel'])
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        File "C:\Users\Bret\AppData\Local\Temp\pip-build-env-b81tpqjt\overlay\Lib\site-packages\setuptools\build_meta.py", line 295, in _get_build_requires
          self.run_setup()
        File "C:\Users\Bret\AppData\Local\Temp\pip-build-env-b81tpqjt\overlay\Lib\site-packages\setuptools\build_meta.py", line 311, in run_setup
          exec(code, locals())
        File "<string>", line 13, in <module>
        File "C:\Users\Bret\AppData\Local\Programs\Python\Python312\Lib\encodings\cp1252.py", line 23, in decode
          return codecs.charmap_decode(input,self.errors,decoding_table)[0]
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
      UnicodeDecodeError: 'charmap' codec can't decode byte 0x90 in position 4: character maps to <undefined>
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
error: subprocess-exited-with-error

× Getting requirements to build wheel did not run successfully.
│ exit code: 1
╰─> See above for output.

note: This error originates from a subprocess, and is likely not a problem with pip.

I found a work-around, which is to run the following before that instruction:
set PYTHONUTF8=1
I don't know if this is something that can be fixed, but if so, that might save other Windows users some pain. :-)

Even setting pythonutf8=1 didn't work for me either.
Figured it out, looks like the setup.py just needs to force the encoding for the readme:
long_description=open('README.md', encoding='utf-8').read(),


Add 'isort:skip' to model imports in forked apps

Since from xxx.models import * must always be after custom model definitions in forked apps, isort should skip that line.

Thanks for the contribution.


feat: Transaction creation options are supported by all transactions

feat: Support excluding a transaction from change streams

@jskeet as always, one commit at a time.

All top commits, except for the last one, are adding full support for transaction creation options. Review these carefully, in particular:

Naming
I hacked away at the overload explosion that we had been accumulating, in particular for the SpannerConnectio.BeginTransaction set of methods. The idea is that, if we want to offer helpers for building different types of transaction, we do that via SpannerTransactionCreationOptions. Still it might be useful to leave a few of the more commons overloads.
The last commint add support for the new transaction creation option, "exclude transaction from change stream". It's very easy to add those type of options now, and that commit is in this PR to demonstrate the benefits of the approach.
There's still similar work to be done for adding full support for the transaction options that may be set after transaction creation.

Another thing to note is that individual commits won't build on their own, I'll squash them before merging, but for reviews it's better as is.

(I'm looking at PR errors, but all are because C# language version)

All green and ready for review now.

In SpannerCommandTests.cs, you've got this reply to a comment of mine - I can't see my comment now, or reply to yours:

SpannerDataReader does not implement IAsyncDisposable, or did you mean something else?

I suspect I meant changing this:
using (var reader = await command.ExecuteReaderAsync())
{
    ...
}

into:
using var reader = await command.ExecuteReaderAsync();
...

In SpannerCommandTests.cs, you've got this reply to a comment of mine - I can't see my comment now, or reply to yours:

SpannerDataReader does not implement IAsyncDisposable, or did you mean something else?

I suspect I meant changing this:
using (var reader = await command.ExecuteReaderAsync())
{
    ...
}

into:
using var reader = await command.ExecuteReaderAsync();
...

Ah OK, yes, I'll do that, I though you meant await using...


Before-render-action as a plugin

Hi
It would be great if plugins could act before all other things are done, for example a plugin could be written that generates html files from haml files in a certain directory. If this is about _layouts, it has to be before the rest of the rendering is done I think, so it would be cool to be able to do this.

duplicate #225


Rescan Wikis in February

These weren't indexable before in the last survey:

https://github.com/NuGet/Home/wiki/Repository-Signatures-and-Countersignatures-Technical-Specification

https://github.com/ajayyy/SponsorBlock/wiki/Edge

and probably more
They are now.

https://github.com/imchillin/Anamnesis/wiki

is now noindexed.

This is now complete:
https://docs.google.com/spreadsheets/d/1y5V1xVtL-Z4w4yt9mVQuwGCP3s8TgNAS756IKStRUqs/edit#gid=611938779

Service updated with new skip list


Fix NULL Entity error

This should "fix" the following error:
libk/lua/libk/server/sv_libk_player.lua:6: Tried to use a NULL entity!
This error comes when the player somehow leaves the server shortly after joining it.

Thanks for the PR!


Add options to Variant Recoder

Description
Variant Recoder has two more options available.
Use case
We need to add two options:

vcf_string (at the moment, it can be switched on using fields but it's more correct if vcf_string is a separate option)
var_synonyms (new option to report variation synonyms)

Benefits
More Variant Recoder options.
Possible Drawbacks
None
Testing
Have you added/modified unit tests to test the changes?
Yes, tests added to t/variation.t
If so, do the tests pass/fail?
Tests pass
Have you run the entire test suite and no regression was detected?
No regression detected.
Changelog
Are you changing the functionality of an endpoint? If so, please give a one line summary for the public facing changelog.
[variant_recoder/:species/:id] Has the option to return VCF and variation synonyms

Coverage increased (+0.1%) to 44.422% when pulling 64166cc01cf9ad55f998bf57e55b0aecbed384da on dglemos:vr/add_options_105 into c5a88efeece7f8f29e5c8dec0a4a207a65329772 on Ensembl:master.


api: add getServerMeta and readState api for antenna rpc methods, clo…

…se #541.
What type of PR is this?

Uncomment only one  /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:
/kind api-change
/kind backend-change
/kind ui-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
Add getServerMeta and readState api for antenna rpc methods.
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


best way to check if update is available (?)

Hi,
I have incorporated youtube-dl in another program, and I just finished implementing youtube-dl automatic updating as the said program loads.  It's working, but the problem is that I'm not sure if my strategy was the best one. What the program currently does is access youtube-dl Download page (https://rg3.github.io/youtube-dl/download.html) and then grab the MD5 hash there and compare against the hash of the currently installed version, and if the hash differs then it updates youtube-dl. But I guess this may not be so good for maintainability, since the page source may be modified anytime. I know I could simply always call sudo youtube-dl -U, but I prefer to only use the update command if necessary, because of performance (the program is for the Raspberry Pi). So, what do you think? Is there a better way to do it?
Thanks!

You may want to have at look at http://rg3.github.io/youtube-dl/update/versions.json and http://rg3.github.io/youtube-dl/update/LATEST_VERSION. These files are used internally for youtube-dl -U functionality.

Good, thanks!


Remove remnants of Analytics API

There is still some references to the Analytics API left-over that should be removed:

[ ] Wiki: Reference -> API
[ ] config.template.toml

There might be other places too.

Good call


Accessible LED display simulator state

Describe the bug
Accessibility feedback from a user:

Screen (LED) state. I liked being able to toggle individual LEDs through buttons in the browser; I was able to understand the numbering of LEDs (e.g. LED 0,0) and their corresponding location on the board by toggling individual LEDs. However, it may be nice to have some sort of textual representation of the current state of the screen as it would prevent the screen reader user from having to check 25 button states to recall the state of the screen.

We could treat the LED matrix as a sequencer.

Something like this: https://glitch.com/edit/#!/tone-example-sequencer?path=sketch.js%3A13%3A38

Neat, let’s discuss this on our call tomorrow
James
From: Peli de Halleux @.>
Date: Wednesday, 14 July 2021 at 14:25
To: microsoft/jacdac @.>
Cc: James Devine @.>, Author @.>
Subject: Re: [microsoft/jacdac] Accessible LED display simulator state (#525)
Something like this: https://glitch.com/edit/#!/tone-example-sequencer?path=sketch.js%3A13%3A38https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fglitch.com%2Fedit%2F%23!%2Ftone-example-sequencer%3Fpath%3Dsketch.js%253A13%253A38&data=04|01|t-jamdev%40microsoft.com|8cb527e0e68e4208f41a08d946cac7be|72f988bf86f141af91ab2d7cd011db47|1|0|637618659018421622|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=z8eVu6axPSL20vBmodbVRCPeUyn1CI5zWH0BYvkRy6M%3D&reserved=0
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fjacdac%2Fissues%2F525%23issuecomment-879889338&data=04|01|t-jamdev%40microsoft.com|8cb527e0e68e4208f41a08d946cac7be|72f988bf86f141af91ab2d7cd011db47|1|0|637618659018421622|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=ef5Sf2BvbqknZQST%2BLsrDtnYFlJC47EJzOeDa1QBc4k%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FABEF4KLTKDLESOKJXFE5ZHDTXWF2XANCNFSM5ALEST5Q&data=04|01|t-jamdev%40microsoft.com|8cb527e0e68e4208f41a08d946cac7be|72f988bf86f141af91ab2d7cd011db47|1|0|637618659018431619|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=rN97FErJ2XiNm9Ccwi70MTub0LfiMgIZRp2T3zzjQEo%3D&reserved=0.


Add load rest

@ssyssy Could you format your code based on the development guide? https://github.com/ChunxuTang/AI-Reference-Architecture/blob/main/README.md

@ssyssy Could you format your code based on the development guide? https://github.com/ChunxuTang/AI-Reference-Architecture/blob/main/README.md

Sure


Removed Retry handler

Codecov Report

Merging #40 into releases/3.0.0 will increase coverage by 0.01%.
The diff coverage is 100%.

@@                Coverage Diff                @@
##           releases/3.0.0     #40      +/-   ##
=================================================
+ Coverage           93.78%   93.8%   +0.01%
=================================================
  Files                  42      41       -1
  Lines                 644     597      -47
=================================================
- Hits                  604     560      -44
+ Misses                 40      37       -3

Impacted Files
Coverage Δ

...l.Client/Extention/HttpResponseMessageExtension.cs
100% <ø> (ø)
:arrow_up:

ReportPortal.Client/ReportPortalClient.cs
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8502a3a...92e9463. Read the comment docs.


Gif static

Hello,
I use kitty and the gif doesn't move like it should with icat. Is it normal?

I just wrap their API, which is frame-based.  To do animation, you'll have to send it frame-by-frame like icat does:
https://github.com/kovidgoyal/kitty/blob/b9051d82888017cc89363b0e7aa1fbd38751f8b0/kittens/icat/native.go#L141
I believe the only interface for doing a direct upload of animated gifs is the iTerm/WezTerm one--the one that kitty doesn't support:
https://pkg.go.dev/github.com/BourgeoisBear/rasterm#ItermCopyFileInline

Ok I see ty.
I would like this feature, I can make a PR if you want. Do you have indication where to start ? Sadly you seem to only support png for now and not other image format tho, I would have to do that too

rasterm is intended as a thin wrapper over popular inline image protocols.  It only supports direct PNG and "raw" in kitty because those are the only formats supported by kitty's protocol:
https://sw.kovidgoyal.net/kitty/graphics-protocol/
iTerm protocol supports a broader range of encodings, but only works in iTerm, Wezterm, & mintty, and is not specific about what it handles, since iTerm seems to defer most of the actual handling to macOS:
https://iterm2.com/documentation-images.html
Things outside of the protocols should go in a new project.

I understand what you're saying, however gif animation is literally in your todo file. Is it supposed to be there ?

https://github.com/BourgeoisBear/rasterm/commit/9daf9e15f423a780da83d7c3de85d0ff13606c2b
Between KittyImgOpts, and the ability to specify extra options in  ToHeader(), rasterm should already have everything you need to upload the frames.  I respect Kovid, but I am also not inclined to pave-over the potholes in Kitty's overwrought protocol.  There's a saying we have in this business: "If you touch it, it's yours."
https://sw.kovidgoyal.net/kitty/graphics-protocol/#animation

Ok I see, thank you for your answer. I started a fork if you want, I can make a PR once I'm done.

If you are going to rename public functions, please rename the project as well.


feat(windows, linux): Add with_extension_path to WebviewBuilder

Now that https://github.com/tauri-apps/wry/pull/1403 has been merged, it's time to bring it to the Tauri side!
Adds a function to the WebviewBuilder that sets the extension path. On Windows, the directory should contain unpacked Chrome extensions. On Linux, it should contain compiled .so extensions.

Should be fixed now 👍


[no ticket] Update PULL_REQUEST_TEMPLATE.md

Purpose
Update the PR template to better reflect how we use it.

Summary of Changes

Move ticket number and feature flags to line items at the top
Remove the largely unused "reviewer checklist"

Side Effects
n/a

Feature Flags
n/a

QA Notes
n/a

Ticket

https://openscience.atlassian.net/browse/EMB-123
Reviewer Checklist

[x] meets requirements
[ ] easy to understand
[x] DRY
[x] testable and includes test(s)
[x] changes described in CHANGELOG.md

Pull Request Test Coverage Report for Build 3273

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 75.885%

Totals

Change from base Build 3266:
0.0%

Covered Lines:
7235

Relevant Lines:
8350

💛  - Coveralls


Settings are broken (RDNA3, 0.5.2)

I previously played around with 0.5.1, but RDNA3 wasn't supported. Now I'm trying it again after updating everything, but my settings seem to be broken.
When clicking Apply, it always snaps back to the state it was in when messing with version 0.5.1. This results in being unable to save anything since there's one fan control point too much.
It appears that it's somehow unable to overwrite the settings. Running the GUI as root and reinstalling with a fresh config (pacman -Rn) doesn't help. Do you have any ideas? Maybe chmod or delete some files manually?
Error popup:

You probably had a custom fan curve applied back in 0.5.1, which wasn't supported on RDNA3. Now it's trying to apply the curve, and is failing to do so.
You should be able to remove one of the curve points on the thermals page, so the curve becomes valid.
If that doesn't work, you can fully reset the config by removing /etc/lact/config.yaml and restarting the service.

That worked, thanks!
To clarify, it would always replace the curve with a 6-point one.


THRIFT-4645: TCurlClient: include failure reason in exception

When curl_exec fails, more detailed failure information is available by calling curl_error.  Include this error information in the message in the thrown TTransportException.
Also change the comparison of the return value of curl_exec to explicitly check for boolean false, so as to distinguish from an empty response body (per the PHP documentation on this subject).
Changes have been tested and running in production at Thumbtack for the past several days, and it's working as expected.  TCurlClient doesn't seem to have any existing test suite to update.

I'd say as long as this doesn't expose any stack frame information (anything that would be considered a security leak) it should be fine.  Can you post an example of the new output?

No stack information what-so-ever.  Here's an example message:
TCurlClient: Could not connect to http://production-users.internal.aws/thrift, Operation timed out after 3001 milliseconds with 0 bytes received


I can't install it from amp

Hi, when I installed atom-discord I had this issue.

Failed to install atom-discord because Git was not found.

The atom-discord package has module dependencies that cannot be installed without Git.

You need to install Git and add it to your path environment variable in order to install this package.

You can install Git by downloading, installing, and launching GitHub for Windows: https://windows.github.com

Run apm -v after installing Git to see what version has been detected.

But I have Git and GitHub desktop installed.

Could you describe exactly why it is not installed from apm?

Supposedly it's because I don't have Git. But I have Git and GitHub Desktop.

Hmm.. I meant that is there any error reports or error message, etc...

It's all. It's a CopyPaste

Oh, I think installing git, not github desktop is essential to install.

I have reinstalled git yet.

But, I think that is a bluebird's problem

If you install this package via apm, the libraries (like blubird) should be installed automatically and I strongly recommend to do that.
But, if you download github release and copy to packages folder, you should install libraries by executing command $ npm install on the package directory. You can get npm by installing node.js

But, I tried to install it with apm and then with npm. When I was installing blubird, the same fail message showed. So I tried to install another library (eg: express) and works.


Export ECharts class in TypeScript

Version
5.0
What problem does this feature solve?
The init function returns a class of type ECharts. This works fine as long as you use the chart variable right after initalization.
import {init, EChartsOption} from "echarts";
...
export class BaseChart {
  initChart() {
    const chart = init(nativeElement);
    // do something else with the chart.
  }
}

But all typings get lost, when you want to pass the chart around (e.g. for updating data later on)
import {init, EChartsOption} from "echarts";
...
export class BaseChart {
  const chart: ECharts; // <--- This does not work. You can it make `any`, but then all typings are lost;
  initChart() {
    this.chart = init(nativeElement);
    // do something else with the chart.
  }
}

The TypeScript definitions do not export the ECharts class
import {ECharts} from "echarts" // <---- This is not possible

Edit
Using EChartsType which is extending ECharts does not work too.
import {init, EChartsOption} from "echarts";
import {EChartsType} from "echarts/lib/echarts";
...
export class BaseChart {
  initChart() {
    const chart: EChartsType = init(nativeElement);
    // This doesn't work too
    // TS2322: Type 'ECharts' is not assignable to type 'EChartsType'.
    // Types have separate declarations of a private property '_zr'.
  }
}

What does the proposed API look like?
Extend the exports in TypeScript. Something like this:
export { ECharts, EChartsFullOption as EChartsOption, connect, disConnect, dispose, getInstanceByDom, getInstanceById, getMap, init, registerLocale, registerMap, registerTheme };

Further to your comment, we are relying on other types like BarSeriesOption, ChartDataset, etc. This change in v5 will result in losing all of the typings in our code base. Why don't you export those?

Same problem, the only way now I can import the type I want is like:
import {CartesianAxisOption} from'echarts/lib/coord/cartesian/AxisModel'
This is really confusing.

@ilueckel Hi, we will plan to export more types
before that, you can use
type EChartsInstance = ReturnType<init>;

as a workaround.

+1 to this issue.

A bigger issue I'm having is defining a renderItem function for custom series. This is because the return type, CustomElementOption, isn't actually exported from the type definitions.

@ThomasBower Hi, this issue is already in the 5.0.1 milestone https://github.com/apache/incubator-echarts/milestone/21

Same problem, the only way now I can import the type that I want is like:
import {CartesianAxisOption} from 'echarts/lib/coord/cartesian/AxisModel'
This is really confusing.

Same for me. Took a lot of work to get my 4.9 implementation to work with 5.0. I will wait until a later version and also when ngx-echarts officially supports v5.x

@ilueckel Hi, we will plan to export more types
before that, you can use
type EChartsInstance = ReturnType<init>;

as a workaround.

In my case the workaround above does not work but the codes below worked around
import * as echarts from 'echarts';
type ECharts = ReturnType<typeof echarts.init>;
let chart = echarts.init(someElement);

<EMAIL_ADDRESS><EMAIL_ADDRESS>

Sorry for the mistake. You are right. It should be ReturnType<typeof echarts.init>;


add license and badge

Fixes #81

Codecov Report

Merging #83 (b0ab4d2) into main (52d69d8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #83   +/-   ##
=======================================
  Coverage   47.30%   47.30%
=======================================
  Files           5        5
  Lines         241      241
=======================================
  Hits          114      114
  Misses        117      117
  Partials       10       10

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52d69d8...b0ab4d2. Read the comment docs.


Failed to automatically apply fixes to a procedural macro crate

Cargo.toml
[package]
name = "procedural"
version = "0.0.1"
authors = ["David Tolnay<EMAIL_ADDRESS>edition = "2018"

[lib]
proc-macro = true

src/lib.rs
extern crate proc_macro;
use self::proc_macro::TokenStream;

#[proc_macro]
pub fn demo(_input: TokenStream) -> TokenStream {
    TokenStream::new()
}

Running cargo fix --edition-idioms I get:
warning: failed to automatically apply fixes suggested by rustc to crate `procedural`

after fixes were automatically applied the compiler reported errors within these files:

  * src/lib.rs

This likely indicates a bug in either rustc or cargo itself,
and we would appreciate a bug report! You're likely to see
a number of compiler warnings after this message which cargo
attempted to fix but failed. If you could open an issue at
https://github.com/rust-lang/cargo/issues
quoting the full output of this command we'd be very appreciative!

warning: `extern crate` is not idiomatic in the new edition
 --> src/lib.rs:1:1
  |
1 | extern crate proc_macro;
  | ^^^^^^^^^^^^^^^^^^^^^^^^ help: convert it to a `use`
  |
  = note: `-W unused-extern-crates` implied by `-W rust-2018-idioms`

warning: `extern crate` is not idiomatic in the new edition
 --> src/lib.rs:1:1
  |
1 | extern crate proc_macro;
  | ^^^^^^^^^^^^^^^^^^^^^^^^ help: convert it to a `use`
  |
  = note: `-W unused-extern-crates` implied by `-W rust-2018-idioms`

There have been a few other reports of people having problems with the extern prelude changes.  See also rust-lang/rust#54381 rust-lang/rust#53964.  The original PR mentioned something about cargo growing support for --extern crate_name, but I haven't been able to find any detail about a plan on how this is supposed to work.

@eddyb sorry I may be confused, but it looks like https://github.com/rust-lang/rust/pull/54116 was merged with no recourse for Cargo? Cargo can't pass --extern proc_macro because it's an unstable flag, and the edition is supposed to be in theory stable on beta?

The fix for this issue is that Cargo isn't passing --extern proc_macro, which in turn requires -Z unstable-options, which in turn means that this is simply a bug in the edition that will require more work than a patch to Cargo. We'll wait to see what the pings on the various issues come up with.

@eddyb mentions on IRC that the intention was for the lint to not fire on extern crate proc_macro;, basically continuing to consider that annotation "idiomatic for now". @eddyb will work on a patch to rustc to skip linting about extern crate proc_macro (specifically just that one crate) and that will in turn fix this issue.

I believe we're tracking this as rust-lang/rust#54381, right?

@eddyb I think both can be fixed in the same way, yeah, so I'd be fine tracking this there too


[WIP] Increase work_mem to speed up queries in Index page

The following query is taking more than 10 seconds to run. The reason for this performance is the GIN index on the fields title and base_path when the result is a big collection (like 150K content items) it perform several operation in batches because it has memory constraints.
This is the query:
explain analyze SELECT     base_path,
           title,
           organisation_id,
           document_type,
           "aggregations_search_last_thirty_days"."upviews",
           "aggregations_search_last_thirty_days"."pviews",
           "aggregations_search_last_thirty_days"."useful_yes",
           "aggregations_search_last_thirty_days"."useful_no",
           "aggregations_search_last_thirty_days"."searches",
           "aggregations_search_last_thirty_days"."feedex",
           pdf_count,
           words
FROM       "aggregations_search_last_thirty_days"
INNER JOIN dimensions_editions
ON         aggregations_search_last_thirty_days.dimensions_edition_id = dimensions_editions.id
INNER JOIN facts_editions
ON         dimensions_editions.id = facts_editions.dimensions_edition_id
WHERE      "dimensions_editions"."document_type" NOT IN ('redirect',
                                                         'gone')
AND        (
                      To_tsvector('english',title) @@ plainto_tsquery('english', '/government/publication')
           or         to_tsvector('english'::regconfig, replace((base_path)::text, '/'::text, ' '::text)) @@ plainto_tsquery('english', ' government publication'))
ORDER BY   upviews DESC limit 100 offset 1;

By increasing the memory to 64MB we decrease the time to 1.5 seconds, which is acceptable considering that these queries are not too frequent.
Without the memory increase:
 Limit  (cost=204057.75..204058.00 rows=100 width=252) (actual time=9940.531..9940.552 rows=100 loops=1)
   ->  Sort  (cost=204057.74..204272.82 rows=86029 width=252) (actual time=9940.529..9940.545 rows=101 loops=1)
         Sort Key: aggregations_search_last_thirty_days.upviews DESC
         Sort Method: top-N heapsort  Memory: 59kB
         ->  Hash Join  (cost=169052.41..200763.60 rows=86029 width=252) (actual time=9524.722..9902.169 rows=136683 loops=1)
               Hash Cond: (aggregations_search_last_thirty_days.dimensions_edition_id = dimensions_editions.id)
               ->  Seq Scan on aggregations_search_last_thirty_days  (cost=0.00..16052.38 rows=514538 width=56) (actual time=0.022..115.362 rows=514538 loops=1)
               ->  Hash  (cost=165069.85..165069.85 rows=93085 width=220) (actual time=9524.364..9524.364 rows=150004 loops=1)
                     Buckets: 16384 (originally 16384)  Batches: 16 (originally 8)  Memory Usage: 3969kB
                     ->  Hash Join  (cost=134531.15..165069.85 rows=93085 width=220) (actual time=9117.982..9460.695 rows=150004 loops=1)
                           Hash Cond: (facts_editions.dimensions_edition_id = dimensions_editions.id)
                           ->  Seq Scan on facts_editions  (cost=0.00..19457.62 rows=555262 width=16) (actual time=0.012..115.665 rows=556829 loops=1)
                           ->  Hash  (cost=130720.50..130720.50 rows=93332 width=204) (actual time=9116.496..9116.496 rows=150004 loops=1)
                                 Buckets: 32768 (originally 32768)  Batches: 16 (originally 8)  Memory Usage: 3841kB
                                 ->  Bitmap Heap Scan on dimensions_editions  (cost=1101.58..130720.50 rows=93332 width=204) (actual time=125.869..8976.190 rows=150004 loops=1)
                                       Recheck Cond: ((to_tsvector('english'::regconfig, (title)::text) @@ '''/government/publication'''::tsquery) OR (to_tsvector('english'::regconfig, replace((base_path)::text, '/'::text, ' '::text)) @@ '''govern'' & ''public'''::tsquery))
                                       Rows Removed by Index Recheck: 129819
                                       Filter: ((document_type)::text <> ALL ('{redirect,gone}'::text[]))
                                       Rows Removed by Filter: 14840
                                       Heap Blocks: exact=26930 lossy=26487
                                       ->  BitmapOr  (cost=1101.58..1101.58 rows=104922 width=0) (actual time=113.139..113.139 rows=0 loops=1)
                                             ->  Bitmap Index Scan on dimensions_editions_title  (cost=0.00..42.44 rows=325 width=0) (actual time=0.344..0.344 rows=0 loops=1)
                                                   Index Cond: (to_tsvector('english'::regconfig, (title)::text) @@ '''/government/publication'''::tsquery)
                                             ->  Bitmap Index Scan on dimensions_editions_base_path  (cost=0.00..1012.48 rows=104598 width=0) (actual time=112.793..112.793 rows=164874 loops=1)
                                                   Index Cond: (to_tsvector('english'::regconfig, replace((base_path)::text, '/'::text, ' '::text)) @@ '''govern'' & ''public'''::tsquery)
 Planning time: 2.003 ms
 Execution time: 9940.714 ms
(27 rows)

With the memory increase:
 Limit  (cost=177506.43..177506.68 rows=100 width=252) (actual time=1459.419..1459.442 rows=100 loops=1)
   ->  Sort  (cost=177506.43..177721.50 rows=86029 width=252) (actual time=1459.416..1459.430 rows=101 loops=1)
         Sort Key: aggregations_search_last_thirty_days.upviews DESC
         Sort Method: top-N heapsort  Memory: 59kB
         ->  Hash Join  (cost=151809.85..174212.28 rows=86029 width=252) (actual time=1000.994..1409.458 rows=136683 loops=1)
               Hash Cond: (facts_editions.dimensions_edition_id = aggregations_search_last_thirty_days.dimensions_edition_id)
               ->  Seq Scan on facts_editions  (cost=0.00..19457.62 rows=555262 width=16) (actual time=0.014..176.902 rows=556831 loops=1)
               ->  Hash  (cost=150731.63..150731.63 rows=86258 width=260) (actual time=1000.631..1000.631 rows=136683 loops=1)
                     Buckets: 262144 (originally 131072)  Batches: 1 (originally 1)  Memory Usage: 41598kB
                     ->  Hash Join  (cost=131887.15..150731.63 rows=86258 width=260) (actual time=529.762..890.804 rows=136683 loops=1)
                           Hash Cond: (aggregations_search_last_thirty_days.dimensions_edition_id = dimensions_editions.id)
                           ->  Seq Scan on aggregations_search_last_thirty_days  (cost=0.00..16052.38 rows=514538 width=56) (actual time=0.015..54.551 rows=514538 loops=1)
                           ->  Hash  (cost=130720.50..130720.50 rows=93332 width=204) (actual time=529.420..529.420 rows=150006 loops=1)
                                 Buckets: 262144 (originally 131072)  Batches: 1 (originally 1)  Memory Usage: 36929kB
                                 ->  Bitmap Heap Scan on dimensions_editions  (cost=1101.58..130720.50 rows=93332 width=204) (actual time=126.891..391.323 rows=150006 loops=1)
                                       Recheck Cond: ((to_tsvector('english'::regconfig, (title)::text) @@ '''/government/publication'''::tsquery) OR (to_tsvector('english'::regconfig, replace((base_path)::text, '/'::text, ' '::text)) @@ '''govern'' & ''public'''::tsquery))
                                       Filter: ((document_type)::text <> ALL ('{redirect,gone}'::text[]))
                                       Rows Removed by Filter: 14840
                                       Heap Blocks: exact=53418
                                       ->  BitmapOr  (cost=1101.58..1101.58 rows=104922 width=0) (actual time=102.859..102.859 rows=0 loops=1)
                                             ->  Bitmap Index Scan on dimensions_editions_title  (cost=0.00..42.44 rows=325 width=0) (actual time=0.344..0.344 rows=0 loops=1)
                                                   Index Cond: (to_tsvector('english'::regconfig, (title)::text) @@ '''/government/publication'''::tsquery)
                                             ->  Bitmap Index Scan on dimensions_editions_base_path  (cost=0.00..1012.48 rows=104598 width=0) (actual time=102.512..102.512 rows=164880 loops=1)
                                                   Index Cond: (to_tsvector('english'::regconfig, replace((base_path)::text, '/'::text, ' '::text)) @@ '''govern'' & ''public'''::tsquery)
 Planning time: 2.707 ms
 Execution time: 1466.839 ms
(26 rows)

Some notes:

The memory is only increased for this particular query (local transaction)
The index query will by cached, so the changes of having multiple users running the same query multiple times and increasing the overall memory are minimal.

Closed in favor of https://github.com/alphagov/content-performance-manager/pull/1149


1800, 1300 and 13 numbers not formatting correctly in Australia

Very useful Gem. Thanks!
If you input +611800123456 you see 01800 123 456 but you would expect 1800 123 456.
If you input +611300123456 you see 01300 123 456 but you would expect 1300 123 456.
If you input +61131234 you see 013 12 34 but you would expect 13 1234.

Sorry. It has been done.

Hi @raefa ! Thanks for the nice issue entry – do you think you could provide a pull request improving the rules for Australia?

Hi @floere. Sorry. I had a look and could not work out how to do it without a massive overhaul ... and I am not skilled enough for a massive overhaul!

@raefa Ok – but when does the issue occur? When you run this?
ruby -e 'require "phony"; p Phony.format("611800123456", :format => :national)'

@floere Yes. Exactly.

@raefa Thanks! I've added a spec here: https://github.com/floere/phony/commit/715c2713c2ce1396c78dd17b543f77d86f9901af, and a fix here: https://github.com/floere/phony/commit/7ff3ea3aa7c7e120818f979e07b72732f9bff03e Thanks again!
Released in 2.15.31 🚀

@raefa Raef, @jashank has noticed that this issue broke Australian numbers – the issue is that non-geographic phone numbers in Australia do not use a trunk code, and are generally not accessible internationally: https://en.wikipedia.org/wiki/Telephone_numbers_in_Australia.
Now, I am wondering in what context you have encountered e.g. the number +611800123456 – was it a natural context or a synthetic test case? I am trying to find an elegant solution to the issue at hand, and whether the example case here actually must be covered or whether it never occurs naturally. Thanks for any help 😊

Most 1800 numbers in Australia will accept international calls. If they do you would call +61 1800 123 456.  I can't test because I'm in Australia but I am reasonably confident this is correct.
I believe the same applies to 1300 and 13 numbers too.
Sent from my iPhone

On 13 Feb 2017, at 9:44 pm, Florian R. Hanke<EMAIL_ADDRESS>wrote:
@raefa Raef, @jashank has noticed that this issue broke Australian numbers – the issue is that non-geographic phone numbers in Australia do not use a trunk code, and are generally not accessible internationally: https://en.wikipedia.org/wiki/Telephone_numbers_in_Australia.
Now, I am wondering in what context you have encountered e.g. the number +611800123456 – was it a natural context or a synthetic test case? I am trying to find an elegant solution to the issue at hand, and whether the example case here actually must be covered or whether it never occurs naturally. Thanks for any help 😊
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

My interpretation of some (annoyingly CIC) documentation on this is that you have to explicitly request international connectivity for these numbers, and that documentation leads me to believe this is unusual.
FWIW, in the application I'm currently working on, this change breaks more phone numbers than it fixes.

It's not unusual most tourist places with 1800 numbers work internationally - I've tried a handful.


docs: add missing information in the room package readme

This PR will add some missing informations which are:

Bitrate configuration options when initializing the Room() including the example
Add information related to custom room configuration including the example of creating a room with custom configuration.
Add information related to creating client with custom configuration

See the readme here.

Mas @tyohan , minta tolong diapprove ulang. Tadi saya ada tambahan sedikit terkait custom client config di sini ab4e5cf


Wording change on db export confirmation dialog (override -> overwrite)

Description
In my opinion, the word "override" should be "overwrite" in the following confirmation dialog:

(You get this dialog when restoring a MySQL database.)
Rationale: You override something when you leave it intact but substitute it for something else. However, when exporting the database, the confirmation dialog is confirming that it's okay to overwrite an existing file (replace it completely).
DBeaver Version
Community Edition <IP_ADDRESS>403031740
Operating System
Windows 11
Database and driver
MySQL (where's the version???)
Steps to reproduce
Right click on a MySQL database.
Tools > Dump database > Next > Start
Additional context
No response

Thank you for paying attention to the messages. It makes sense to change it this way.

My pleasure! Keep up the great work.
[Description: @.***
Craig Silver
Owner Operator
t.<PHONE_NUMBER> | e<EMAIL_ADDRESS>computer services with a personal touch
From: Elizabeth @.>
Sent: Sunday, March 24, 2024 8:37 PM
To: dbeaver/dbeaver @.>
Cc: Craig Silver @.>; Author @.>
Subject: Re: [dbeaver/dbeaver] Wording change on db export confirmation dialog (override -> overwrite) (Issue #23215)
Thank you for paying attention to the messages. It makes sense to change it this way.
—
Reply to this email directly, view it on GitHubhttps://github.com/dbeaver/dbeaver/issues/23215#issuecomment-2017150491, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAU6WWCKCVA4YG4FZZN367DYZ6LWLAVCNFSM6AAAAABFFISKUKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJXGE2TANBZGE.
You are receiving this because you authored the thread.Message ID<EMAIL_ADDRESS>


Build strings breaks godoc

It is useful to be able to read the documentation on godoc.
https://godoc.org/github.com/dennwc/dom
Unfortunately the build strings in this project hide the code from the godoc system, which presumably wants to build for linux.
//+build wasm,js

This doesn't seem to be an issue for other projects.  Do we really need the build strings?
https://godoc.org/honnef.co/go/js/dom

Agree, will see what I can do to make it go-get-able and show the doc at the same time.

Fixed in master.

Awesome - thanks!


Deploy page fail when no webpage found in db

Description
A bug found: failing to deploy to GitHub when no webpage info of a team is found in the db
Read more: https://trello.com/c/tbBk8hXN
Type of change

[x] Bug fix
[x] New feature
[x] Refactoring
[ ] Documentation

Problem
In the current code, when no webpage info is found for a specific team, it returns a 404 code with a string. Thus, for a team with no websiteInfo created in db, an error would occur when trying to deploy to github

Solution description
A trigger is created in the database, when a new team signs up, the trigger will automatically create a webpage and homepage document of that team in the websites and homepages collection.
https://cloud.mongodb.com/v2/606768fe9f1a3467c7fcb3fb#triggers

Note: For the newly created team, the error should be fixed. However, for the existing team, the error would still exist. Pls register a new team to prevent the error mentioned above.
Tests
All unit tests pass? N/A
Builds successfully? Yes
Provide steps in detail for reviewers to reproduce the expected result of the code changes.

Registrate a new team and double-check if the webpage and homepage documents of that team are created, then try to deploy the page to github.
Pls let me know if any bugs exist in adding/ deleting web pages functionality as I've also refactored these 2 endpoints.

Relevant document/ link (if any)
https://trello.com/c/tbBk8hXN
Risk
Low to Medium. Modified a few endpoints, might affect other functions which use this endpoint I am not aware of.

Do you know if we can programmatically create that trigger you just made @mable-yip @pmyip3 ? It may be the solution to the problems I brought up.

Do you know if we can programmatically create that trigger you just made @mable-yip @pmyip3 ? It may be the solution to the problems I brought up.
Don't have any idea. But I did some research on that, instead of using functions to create the trigger, MongoDB also allows using Amazon EventBridge. I don't know much about AWS tho, but seems like we can configure the trigger in AWS and then provide the AWS account ID to MongoDB.
https://docs.atlas.mongodb.com/triggers/eventbridge/

@pmyip3 @mable-yip I think I may have found a neater solution that can avoid triggers + clean up the original approach. We can apparently implement mongoose middleware to act like triggers on the Model level. I've pushed up a change to this branch https://github.com/Researchify/Researchify/commit/ff4ca6efc503e9e679905076b8ca76c73debceed so you can have a look.
IMO, it's pretty neat. Could you test it out and lmk what you think?
References:
https://stackoverflow.com/questions/57971183/is-there-a-way-to-create-after-update-triggers-or-events-in-mongoose
https://mongoosejs.com/docs/middleware.html#post
https://mongoosejs.com/docs/api.html#schema_Schema-post

@pmyip3 @mable-yip I think I may have found a neater solution that can avoid triggers + clean up the original approach. We can apparently implement mongoose middleware to act like triggers on the Model level. I've pushed up a change to this branch ff4ca6e so you can have a look.
IMO, it's pretty neat. Could you test it out and lmk what you think?
References:
https://stackoverflow.com/questions/57971183/is-there-a-way-to-create-after-update-triggers-or-events-in-mongoose
https://mongoosejs.com/docs/middleware.html#post
https://mongoosejs.com/docs/api.html#schema_Schema-post

@vgoh1 @rpra0006 tagging so you can pitch in on this approach, if you want.


tsparticles 3

will this lib get updated to 3.0.x ? I am getting lot of deprecated message when npm install

Yes, I’m working on it