#![feature(impl_trait_in_bindings)] has been removed from rustc

Hi,
Per https://github.com/rust-lang/rust/commit/e8c04b4386d015e126591c799b562d6a578acc40 and the code on https://github.com/rust-lang/rust/blob/a72c360a30f9a8160e4f40340cecc9b1ce979cd7/compiler/rustc_feature/src/removed.rs#L151-L153
the impl_trait_in_bindings has been removed, which seems like the embassy requires a major change on code.
KL

I took a quick swing through, and -nrf and -stm32 and their associated example both still compile even without that feature-flag, on our current toolchain nightly.
Can you point me towards where we are currently using that feature?

I took a quick swing through, and -nrf and -stm32 and their associated example both still compile even without that feature-flag, on our current toolchain nightly.
Can you point me towards where we are currently using that feature?

Hi, I'm trying to run the example. it shows something like this
   Compiling embassy-traits v0.1.0 (https://github.com/embassy-rs/embassy?branch=master#d83cd3ff)
error[E0557]: feature has been removed
 --> /Users/cnnblike/.cargo/git/checkouts/embassy-9312dcb0ed774b29/d83cd3f/embassy-traits/src/lib.rs:7:12
  |
7 | #![feature(impl_trait_in_bindings)]
  |            ^^^^^^^^^^^^^^^^^^^^^^ feature has been removed
  |
  = note: the implementation was not maintainable, the feature may get reintroduced once the current refactorings are done

Yah, we definitely have the feature-flag enabled, but I'm not finding where we actually use that feature upon first glance.
If you're feeling adventurous, comment-out (or remove) all instances of that line (and only that one feature flag) until the compile stops complaining about it.  I think we're flipping the flag, but not taking advantage of it. Maybe.

I definitely can help with this but I’m not sure whether I’m the right one to do this, like, i have never ran even a helloworld in embassy yet, any expected behavior?

We have a few examples in examples/ if any of them match the hardware you might have on hand. cargo run --bin blinky is always a pretty good starting point.
But even earlier, if removing all mentioned of impl_trait_in_bindings and stuff still compiles, that's quite a start.
If it doesn't compile, then paste in the errors you get, and we can track them down.
I do think @Dirbaio tries later nightlies on occasion. We'll get this sorted if it's a larger problem than I'm imagining at the moment.

If it doesn't compile, then paste in the errors you get, and we can track them down.
I do think @Dirbaio tries later nightlies on occasion. We'll get this sorted if it's a larger problem than I'm imagining at the moment.

ok, I'll take a look into that, I only have two nrf52833-dk on my hand so I'm not able to test as-is. some modification may be required.

@cnnblike This is already known, fix in progress. To avoid breakages like these, the embassy repo pins the nightly version to a fixed one. You should pin your project to that version too, that's the one that's tested in CI and known working.
As for this particular breakage: the task macro shouldn't require feature(impl_trait_in_bindings), but for some reason the currently pinned nightly does require it. Later nightlies don't, but some ICEs have appeared. See #318

oh, looks legit to me. Closing this as there is already a ongoing PR for this.


Avoid errors from the asynchrony in the modifier lifecycle hooks

I experienced sporadic test failures when an element is a css-transition modifier is removed soon after it is added. The new tests in this commit illustrate the timing issues that can occur, and add guards to avoid them causing runtime errors.
I find the many guards distasteful, but I don't know a better way to account for these edge cases. Normally I would reach for ember-concurrency, but the fact that some of this code is running asynchronously after teardown by design makes e-c not a great fit.

@peec just a reminder on this. I think it it could help a lot of temperamental test suites around the world. :)

I added a second fix, not related to asynchrony. It was an error occurring if you have a sibling element following your modified element and you remove this sibling before removing the element. In general, it seems that we may want to wait until teardown to look at the nextSiblingElement. I didn't go so far as to make that change but I'm happy to revise in that direction if you think it is better.

Hi @lukemelia
You’ll want to get @miguelcobain involved I believe :)
I played around with some potentially related issues I was having too. I opted not to share at the time because I was focusing on #38. Spike here
I was having an issue when I’d do this.

Visit the current Animating insert/ destroy docs https://peec.github.io/ember-css-transitions/docs/insert-destroy

Keep clicking “Press me” it will error in logs and visually be jumpy

What are your thoughts on setting parentElement to occur at the beginning of didInstall?

@pdud This PR appears to fix the issue you mentioned. I don't expect that setting this.parentElement earlier would change anything. I don't really understand why the code is capturing parentElement as opposed to getting it at teardown-time.

I don't really understand why the code is capturing parentElement as opposed to getting it at teardown-time.

We do that because at some point the willRemove hook ran when the element was already detached from DOM.
I'm fixing this issue using generator functions à lá ember-concurrency. It's much cleaner and also safer.
Your tests are being a great help!
I'll ask you to give it a try when ready @lukemelia .

@lukemelia I set up a branch here https://github.com/peec/ember-css-transitions/tree/generator-guard
Could you please test if it works correctly over there?
It did pass all the tests you have.

@miguelcobain I've run my apps' test suites against master and everything passes 👍 Implementation looks good with the caveat that I'm not very familiar with generator functions.

We do that because at some point the willRemove hook ran when the element was already detached from DOM.

Sounds like some other bug then, no? Certainly willRemove should be running before the element is detached. Anyway, that's really a different issue so no need to deal with it here. Will you release master as 1.0.2?

@miguelcobain I've run my apps' test suites against master and everything passes 👍 Implementation looks good with the caveat that I'm not very familiar with generator functions.

That's great! Thank you for testing.

Sounds like some other bug then, no? Certainly willRemove should be running before the element is detached. Anyway, that's really a different issue so no need to deal with it here. Will you release master as 1.0.2?

I brought this up with @pzuraq some months ago. It seemed like the change was intentional.
Let me quote him on the outcome:

@miguelcobain we discussed it today, and the consensus is that it the behavior is definitely valid, and we need to get an RFC up to add a new hook specifically for it for modifier managers

https://discordapp.com/channels/480462759797063690/608346628163633192/695751485551542365

Released as 1.1.0.
Thanks again.

@miguelcobain we discussed it today, and the consensus is that it the behavior is definitely valid, and we need to get an RFC up to add a new hook specifically for it for modifier managers

Thanks, just caught up on this. Do you know if the proposed RFC has been opened? I don't see it on a browse of the RFCs repo.

I don't think it was opened, no.


New Module: ThreatMiner

Requires API Key:

[ ] Yes
[x] No

Tasks

[x] Write module for IP, Domain, Hash queries

Hash will retrieve http traffic
IP will retrieve Passive DNS info
Domain gets Passive DNS info and Subdomains

[x] Create child artifacts found by results when applicable
[x] Test in development branch

Completed in v1.0-prod branch


Revert "stdenv: set NIX_DONT_SET_RPATH_FOR_TARGET on Darwin"

This reverts commit 10c87ee2c7661b0e699b270744439b2643aaa43b.
Fixes https://github.com/NixOS/nixpkgs/issues/355622.
@emilazy @sternenseemann

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Before the revert:
$ nix-instantiate . -A pkgsCross.gnu64.pkgsBuildBuild.jq
/nix/store/idydjykv86f3wzy87jrx0pf8rzf08hmq-jq-1.7.1.drv!bin
$ nix-instantiate . -A pkgsCross.gnu64.pkgsBuildHost.jq
/nix/store/ay9bsvb6vslgi0xqmvmyfwczmnyzkqv3-jq-1.7.1.drv!bin

After the revert:
$  nix-instantiate . -A pkgsCross.gnu64.pkgsBuildBuild.jq
/nix/store/p3b6czc6y9ba6la6kf8j9bx6rpm3gcw4-jq-1.7.1.drv!bin
$ nix-instantiate . -A pkgsCross.gnu64.pkgsBuildHost.jq
/nix/store/p3b6czc6y9ba6la6kf8j9bx6rpm3gcw4-jq-1.7.1.drv!bin

I guess technically this is breaking because it changes the semantics of Darwin as a target platform, but not reverting on 24.11 would keep this major regression for cross-compilation until 25.05.
@RossComputerGuy Thoughts?

Is it still possible to get this in time for 24.11? It's a pretty big regression for cross-compilation.

Not in time for the initial release (unless we delay it, which seems unlikely for cross), but given the release manger has approved it, it will go in the first staging-24.11 backport cycle.

Would still like to see the comment and/or commit message updated, but otherwise will merge within a day or two.

I pushed an additional commit clarifying the nature of the mass rebuilds.


Prevent accounts from going positive

You can now define accounts as negative only.
DoubleEntry.configure do |config|
  config.define_accounts do |accounts|
    accounts.define(
      :identifier => :my_account_that_never_goes_positive,
      :negative_only => true
    )
  end
end

If a transfer is requested that would take an account positive a AccountWouldBeSentPositiveError is raised.
Fixes #76

looks good!


Project repository corrupt

Describe the bug
I found a bug in my project that I was using trying to find the source of a different bug. The one I'm reporting caused me to not be able to enter my game.
To Reproduce
Steps to reproduce the behavior:

Create a new project
Click the GitHub icon to make it a repo
Once complete press home and select "Import"
Select "Insert URL"
Without leaving the tab write what the URL should be for the repo you just made (example project name: my-game so URL would be https://github.com/[your username]/my-game)
Click enter
When it reloads click the first project
Watch as you can't enter it again

Expected behavior
I would expect this to duplicate the project, so you have two of the same
Screenshots
https://github.com/user-attachments/assets/1f1c2926-9001-4cd5-860a-fbe18b40b3b8
Desktop (please complete the following information):

OS: Windows I guess
Browser: Edge
Version: Version of what? My browser my computer the editor itself?

Sidenote: The GitHub.io link my private repo provided doesn’t work.
https://robbyzero.github.io/my-gam/

I tested this more with both public and private repos and the public one I could enter but did nothing and the private one duplicated it. So I have no idea what's going on.


Unexpected space in zh-tw LongDecimalFormatter thousands

Describe the bug
LongDecimalFormatter with locale zh-tw for numbers 1000..9000 gives an unexpected space:
zh-cn: 1千, 2千, 3千, 4千, 5千, 6千, 7千, 8千, 9千
zh-tw: 1 千, 2 千, 3 千, 4 千, 5 千, 6 千, 7 千, 8 千, 9 千

Multiples of <100 and >10,000 are unaffected.
To Reproduce
console.log(
	['zh-cn', 'zh-tw'].map((locale) => `${locale}: ${Array.from({ length: 9 }, (_, i) => i + 1).map(n => {
		const TwitterCldr = require('twitter_cldr').load(locale)

		return new TwitterCldr.LongDecimalFormatter().format(n * 1000)
	}).join(', ')}`).join('\n')
)

Expected behavior
Results for zh-tw's 1000..9000 should look identical to those for zh-cn for that same range.
Environment
twitter_cldr 2.2.0, Node v16.13.0

Very curious. It looks like the data itself is wrong. Must be a bug with the Ruby code that generates the data.

Turns out the data in twitter-cldr-rb is wrong in v3.1.2, the version -js uses. The problem has since been fixed, but later versions of twitter-cldr-rb don't work because a number of internal classes etc have changed in the intervening years. We will need to upgrade the -rb dependency, which is going to be a project.


Support scroll lock indicator light

Description
I use hyprland, which is based on wlroots. Normally, the lights of numeric lock and caps lock work normally, but the LED light of scroll lock does not light up. For users of operating systems that support scroll lock, should we provide corresponding LEDs? Support?

yes, that will be very useful


[Internal] Jobs API 2.1 pinning tests

Changes

Adds regression tests to ensure required Jobs endpoints say pinned to API 2.1
Tests

Unit tests.

No idea why the unit test work with MacOS but are failing on ubuntu in the checks. If anyone has tips, I would appreciate it :)

No idea why the unit test works with MacOS but are failing on ubuntu in the checks. If anyone has tips, I would appreciate it :)

@mgyucht Do you happen to have any idea? I see other tests using a similar strategy, and this test works on macos, so I'm really not sure what I could be missing.
If not, I'll just try re-writing it in some other way.


Initial changes to the hero and the What is Bitcamp Section

Made some responsive adjustments--but looks good 😎. Merging now.


Show active / inactive channels

Description of the Feature or Idea
Channels can be active: false, which makes them unusable for routing. There should be a little icon that shows when a channel is active vs inactive (similar to transactions status). This could also be used for pending channels, for #71.

Fixed the failing build for this and submitted a PR.


Write release notes for Chef 13

First pass, review and updates appreciated @chef/maintainers.
I used https://github.com/search?l=&o=asc&p=1&q=type%3Apr+merged%3A"2017-02-23+..+%2A%22+repo%3Achef%2Fchef&ref=advsearch&s=updated&type=Issues&utf8=%E2%9C%93 as a query for all the PRs we merged since 12.19.36 .

@smurawski yep, feel free to push more commits to this :)


Change scroll-bar colour

Change the colour of the scrollbar thumb to 'rgba(19,43,57,1)' and the colour of the track-pad to '#959595' when in dark mode.

assign to me pls

@mshokoya sure


Doesn't work After "Selection to Subflow"

What are the steps to reproduce?

Before "Selection to Subflow"

Here is the corresponding JSON of this flow:
[{"id":"ee6711f4.ef043","type":"http in","z":"1b53be18.b0a122","name":"","url":"/test0","method":"get","upload":false,"swaggerDoc":"","x":120,"y":160,"wires":[["2671010.e829e"]],"constraints":{}},{"id":"e680303d.fb92b","type":"http response","z":"1b53be18.b0a122","name":"","statusCode":"","headers":{},"x":470,"y":160,"wires":[],"constraints":{}},{"id":"2671010.e829e","type":"function","z":"1b53be18.b0a122","name":"LogOnly2","func":"msg.payload = {\"a\":\"b\"};\nconsole.log(\"log2\");\nreturn msg;","outputs":1,"noerr":0,"x":300,"y":160,"wires":[["e680303d.fb92b"]],"constraints":{}}]

After "Selection to Subflow"

Here is the corresponding JSON of this flow:
[{"id":"19b6afe.fea9d5","type":"subflow","name":"Subflow 7","info":"","in":[{"x":160,"y":160,"wires":[{"id":"2671010.e829e"}]}],"out":[{"x":440,"y":160,"wires":[{"id":"2671010.e829e","port":0}]}]},{"id":"2671010.e829e","type":"function","z":"19b6afe.fea9d5","name":"LogOnly2","func":"msg.payload = {\"a\":\"b\"};\nconsole.log(\"log2\");\nreturn msg;","outputs":1,"noerr":0,"x":300,"y":160,"wires":[[]],"constraints":{}},{"id":"ee6711f4.ef043","type":"http in","z":"1b53be18.b0a122","name":"","url":"/test0","method":"get","upload":false,"swaggerDoc":"","x":120,"y":160,"wires":[["5de036f6.b93638"]],"constraints":{}},{"id":"e680303d.fb92b","type":"http response","z":"1b53be18.b0a122","name":"","statusCode":"","headers":{},"x":470,"y":160,"wires":[],"constraints":{}},{"id":"5de036f6.b93638","type":"subflow:19b6afe.fea9d5","z":"1b53be18.b0a122","x":300,"y":160,"wires":[["e680303d.fb92b"]]}]

What happens?
Before "Selection to Subflow", I can visit http://localhost:12002/test0 on browser (without any error on terminal also).

After "Selection to Subflow" and I visit http://localhost:12002/test0 again on browser, it shows a error TypeError: Cannot read property 'configs' of undefined on Node-RED instance 1 (run on port 12001).

TypeError: Cannot read property 'configs' of undefined
    at createSubflow (/Users/weishi/Desktop/OneDrive/Dissertation/Project/NodeRed-subnode2/node-red/red/runtime/nodes/flows/Flow.js:341:18)
    at Flow.start (/Users/weishi/Desktop/OneDrive/Dissertation/Project/NodeRed-subnode2/node-red/red/runtime/nodes/flows/Flow.js:97:41)
    at start (/Users/weishi/Desktop/OneDrive/Dissertation/Project/NodeRed-subnode2/node-red/red/runtime/nodes/flows/index.js:327:29)
    at /Users/weishi/Desktop/OneDrive/Dissertation/Project/NodeRed-subnode2/node-red/red/runtime/nodes/flows/index.js:164:21
    at tryCatchReject (/Users/weishi/Desktop/OneDrive/Dissertation/Project/NodeRed-subnode2/node-red/node_modules/when/lib/makePromise.js:845:30)
    at runContinuation1 (/Users/weishi/Desktop/OneDrive/Dissertation/Project/NodeRed-subnode2/node-red/node_modules/when/lib/makePromise.js:804:4)
    at Fulfilled.when (/Users/weishi/Desktop/OneDrive/Dissertation/Project/NodeRed-subnode2/node-red/node_modules/when/lib/makePromise.js:592:4)
    at Pending.run (/Users/weishi/Desktop/OneDrive/Dissertation/Project/NodeRed-subnode2/node-red/node_modules/when/lib/makePromise.js:483:13)
    at Scheduler._drain (/Users/weishi/Desktop/OneDrive/Dissertation/Project/NodeRed-subnode2/node-red/node_modules/when/lib/Scheduler.js:62:19)
    at Scheduler.drain (/Users/weishi/Desktop/OneDrive/Dissertation/Project/NodeRed-subnode2/node-red/node_modules/when/lib/Scheduler.js:27:9)

What do you expect to happen?
Can visit http://localhost:12002/test0 correctly.
It seems that the reason of that is there is no definition of the "Subflow 7" in Node-RED instance 1 (run on port 12001).

Please tell us about your environment:

[ ] Node-RED version:0.18.7
[ ] node.js version:v8.11.2
[ ] npm version:6.1.0
[ ] Platform/OS:macOS 10.13.6 (17G65)
[ ] Browser:Google Chrome Version 67.0.3396.99 (Official Build) (64-bit)

Hi,
Subflow is not implemented yet so that's why the error.
For the work around, please use the full flow in the design. A little bit inconvenience I agree :(
Thanks

Hi,
Thanks for your reply.
Using a full flow will be OK.


Building reputation in StackOverflow: An empirical investigation

Paper link: http://ieeexplore.ieee.org/xpl/articleDetails.jsp?arnumber=6624013

the authors used MSR 2013 challenge
the link is : A. Bacchelli, “Mining challenge 2013: Stack overflow,” in The 10th
Working Conf. on Mining Soft. Repositories, 2013, p. to appear  .


fix #803, use queue instead of list to avoid concurrent modify exception

Ⅰ. Describe what this PR did
fix issue 803
Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

Codecov Report

Merging #877 into develop will decrease coverage by <.01%.
The diff coverage is 25%.

@@              Coverage Diff              @@
##             develop     #877      +/-   ##
=============================================
- Coverage      38.86%   38.85%   -0.01%
  Complexity      1028     1028
=============================================
  Files            220      220
  Lines           8501     8498       -3
  Branches        1024     1024
=============================================
- Hits            3304     3302       -2
+ Misses          4812     4809       -3
- Partials         385      387       +2

Impacted Files
Coverage Δ
Complexity Δ

.../main/java/io/seata/rm/datasource/AsyncWorker.java
16.43% <25%> (+0.64%)
4 <0> (ø)
:arrow_down:

...eata/server/store/FileTransactionStoreManager.java
53% <0%> (-1%)
15% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a13de66...21bf95d. Read the comment docs.

@zhangthen please check😊


Change monkey-patched functions' signature to be in line with Python's

stat, listdir and scandir are fine and have the same signature right now. Open's is different and I changed it

An out of scope addition - added a "monkey-patched" os.open, that is used to actually monkey-patch _pathlib.open.
Turns out on Python<=3.9, pathlib uses os.open to open stuff, and on 3.10 it uses io.open. In 3.11 the whole NormalAccessor construct is completely removed and it always calls os functions instead.


Ensure ghost nodes are skipped when getting parent clipping rect

Objective

Follow up on #16044
extract_uinode_borders uses bevy_hierarchy directly instead of going through the traversal utilities, meaning it won't handle GhostNodes properly.

Solution

Replaced the use of bevy_hierarchy::Parent with UIChildren::get_parent

Testing

Ran the overflow example, clipping looks ok.

Wondering if it would make sense to give all ghostnodes a CalculatedClip component instead and then just walk the tree normally during clipping updates, it should just work and I'd expect it to be more efficient. This should be merged though, that's just speculative etc.

Yeah something like that could be great if the ghosts decide to stick around.  Or a more general optimization strategy like a retained (relations-based) UI node tree that can be walked like a normal hierarchy.
But seeing as ghost nodes are still experimental, and likely to be removed/re-designed if a better solution comes along, IMO it is probably better to hold off on any substantial optimizations right now.


Unique Download Ids.

I have implemented this library to download files from the list of items displayed to the user in a view pager. Each item of the view pager can be downloaded. If for example, the user is downloading a file which has a download Id "1" and he comes out of the app while the download goes in the background. Again the user enters the app and now starts download of another file. This time too the new file is given download Id as "1". Due to this, I am unable to display progress of the download to the users because both the downloads have the same Id.
Everytime the user enters the app, I setup download manager as below.
Is there a way to have a unique id for each download even after exiting and re-entering the app?
private void setupDownload() {
    OkHttpClient client = new OkHttpClient.Builder().build();
    downloadManager =
            new DownloadManager.Builder().context(this)
                    .downloader(OkHttpDownloader.create(client))
                    .threadPoolSize(1)
                    .logger(new Logger() {
                        @Override
                        public void log(String message) {
                            Log.d(TAG, "Log message: " + message);
                        }
                    })
                    .build();
}

DownloadRequest request = new DownloadRequest.Builder()
.url(uriString)
.retryTime(0)
//                    .retryInterval(2, TimeUnit.SECONDS)
//                    .progressInterval(1, TimeUnit.SECONDS)
.priority(Priority.NORMAL)
.allowedNetworkTypes(DownloadRequest.NETWORK_WIFI | DownloadRequest.NETWORK_MOBILE)
.destinationFilePath(destPath)
.downloadCallback(new DownloadCallback() {
                    @Override
                    public void onStart(int downloadId, long totalBytes) {

.....

You can download file in service.

Thanks for the quick response. I will implement the downloading part in a service.

Not now, maybe later.


EPSG code as string

This is one of the cases, where it seems the specification doesn't fully match what people expect. Also, implementations and examples did often also encourage the "wrong" way...
EPSG codes currently are provided as integers. We should probably also allow strings in 2.0 as this is what people seem to use quite a lot...
So the schema for it would change to something like:
{
  "title": "EPSG Code",
  "type": [
    "integer",
    "string"
  ],
  "subtype": "epsg-code",
  "oneOf": [
    {
      "type": "string",
      "pattern": "^(epsg|EPSG):\\d{4,}$"
    },
    {
      "type": "integer",
      "minimum": 1000
    }
  ],
  "examples": [
      3857,
      "EPSG:3857"
  ]
}

Thoughts?

In general I favor this, as the "EPSG:3857" notation seems to be very common in practical use. It's also more self-documenting than a raw integer 3857.
Counter argument: would users expect other prefixes are also allowed, e.g. something like "WGS:84"?

For reference, we're using https://pyproj4.github.io/pyproj/stable/api/crs/crs.html#pyproj.crs.CRS.from_user_input to validate CRS fields now, so we're be happy with both strings and integers!

Thanks. I don't think so as it clearly states EPSG code in the schema, also validation should reject it. If you dig down into other authorities it quickly gets messy...

On the other hand, we discourage the usage of complex JSON Schema elements such as "oneOf" so that makes it a bit more difficult.

I've tried to do this, but the schemas get very messy. I'm wondering whether we should cater for the string vs. number issue in the clients. It seems like allowing it in the process spec makes it a work item for clients + backends while otherwise it makes it only to a work item in the clients.
In the Web Editor for example it's not an issue at all as it hidden from the user anyway.
The R client also already converts from string to integer if I understand it correctly.
So it's just a work item for the Python client: https://github.com/Open-EO/openeo-python-client/issues/259


fix: useBreadcrumbItems support static meta from dynamic routes

❓ Type of change

[ ] 📖 Documentation (updates to the documentation or readme)
[ ] 🐞 Bug fix (a non-breaking change that fixes an issue)
[x] 👌 Enhancement (improving an existing functionality)
[ ] ✨ New feature (a non-breaking change that adds functionality)
[ ] 🧹 Chore (updates to the build process or auxiliary tools and libraries)
[ ] ⚠ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description
useBreadcrumbItems() does not work fetch page's meta from dynamic routes (e.g. /items/[id]). This proposes to fix that. This still doesn't solve the problem of dynamic labels as definePageMeta is a render macro and figuring out how to morph crumps with dynamic attributes is a different topic, but ability to use even static overrides in dynamic routes I think is usefull

Awesome, thanks!

Does we know when it will released ?

It's available in Nuxt SEO Utils latest, which won't be used in Nuxt SEO until the v2 is stable.
This is coming soon :eyes:


Spelling error telefonish - should be telefonisch

The order emails contain a spelling error. In two occurences in the translation file the word telefonish should be replaced by telefonisch

The order emails contain a spelling error. In two occurences in the translation file the word telefonish should be replaced by telefonisch

That's right! please change it.
Thank you in advance.

Update github_contributions.csv #15
Correct spelling error telefonish to telefonisch
mageplaza:master ← bamboekeizer:patch-1

I couldn't find this anymore, can we close this?

Yes, the change has been incorporated


Actor JSON Serializer randomly failing

Expected Behavior
Correct serialization (99.9% of the time) on the HTTP endpoints for actors
Actual Behavior
When running a Proxy call for the Actor implementation, it randomly fails and spits out a weird JSON string, as if something happened on the protocol transport.  :)

Update: I am thinking it's due to aiohttp (https://github.com/aio-libs/aiohttp/issues/3881)

Update: I am thinking it's due to aiohttp (aio-libs/aiohttp#3881)

Yeah looks like it.

Update: I am thinking it's due to aiohttp (aio-libs/aiohttp#3881)

Yeah looks like it.

What do you suggest here? Seeing that it's in the Dapr code :-)

Update: I am thinking it's due to aiohttp (aio-libs/aiohttp#3881)

Yeah looks like it.

What do you suggest here? Seeing that it's in the Dapr code :-)

We will look at it :) I put P1 label on this.

Update: I am thinking it's due to aiohttp (aio-libs/aiohttp#3881)

Yeah looks like it.

What do you suggest here? Seeing that it's in the Dapr code :-)

We will look at it :) I put P1 label on this.

You rock! 😀

Any update on this? :)

@amanbha @msfussell @orizohar I will prioritize this bug as P0 because it is blocking one of python-users.

@XavierGeerinck I tried to reproduce this issue using demo_actor app, but I could not.
According to the log that you attached, I do not think it is related to aiohttp bug because the response seems to overlap the previously received data rather than truncate the data. ActorProxy is asynchronous calls, but seems like you make this async call to sync call in multiple threads. It might be the root cause of this problem.
Can you please share your code?

Thanks a lot for diving into this @youngbupark , what you say might make sense actually... sadly enough I am struggling with the issue that the calls have to be synchronous due to the Libraries I am utilizing.
The entire code base I am working on can be found here: https://github.com/Roadwork/Roadwork-RL/tree/master/src (including diagrams). When you speak about "overlapping" data instead of truncating (I've never thought of it in this way, thanks a lot for this hint!) the first thing coming to my mind is the "Nest Asyncio" library (https://pypi.org/project/nest-asyncio/) that I am utilizing to access the event loop.
I wonder if I am able to create the event loop per thread 🤔 that might indeed solve the overlapping issue then.
What do you think? Is this the way I should be thinking about it? (again: sync is a requirement due to the third party libraries). Definitely open towards going through the problem together, but if it's overlapping I definitely understand that it's not a Dapr issue (nor asyncio one).

@XavierGeerinck let's not use nest-asyncio. Instead, try to use asyncio.run() or django's async_to_sync to make async call to sync.
Also try to scale out the replicaset of actor services. Please update the status then I can follow it up tomorrow morning.

Thanks for the quick comment! I switched it all out towards asgiref's async_to_sync and creating async methods where they should be (reference: https://github.com/Roadwork/Roadwork-RL/commit/b62e5723d6618b0bd92f80f8a4d16a82d8dfe38e) but the problem still exists.
 Try to test it again.
Also please let me know how I can reproduce on my environment. Did you test it on local machine or on K8s ?

I forgot to push the latest changes :) I had indeed removed that new event loop creation already.
I tested on a local machine environment, but you should be able to reproduce it with the container installation part (https://github.com/Roadwork/Roadwork-RL/tree/master/src under "Kubernetes")

@XavierGeerinck I can reproduce it now. I am investigating this.

I captured tcp traffic of server and client side with wireshark

You can open the captured packets on wireshark by downloading this high_freq.pcapng.gz

Based on the investigation, actorservice returns correct json format response when proxy calls actor and its method. but when dapr sidecar send the response from actor service to client via http client. the data is corrupted.
For example, two invocation requests, such as A and B, come to dapr sidecar for invocation in a row with almost several ns time gap, where A comes first and B next. actorservice returns the response for B and then response for A. but B's response body was same as A's response body, but no header change. B's headers were not changed and content-length is correct for B's original body.
so when proxy tried to deserialize B's response body, it was failed because B's response body was A's and B's data was truncated or B's data included garbage data.
We will investigate this issue more and fix runtime as soon as possible.

cc/ @yaron2 @amanbha @LMWF @yolember

@XavierGeerinck I found the root cause of this issue and will fix the bug and release 0.9.1 tomorrow.

Awesome! Amazing work, you rock! Looking forward to see what was causing this 😊


Index.html is very blank

Create a nice interface

Working on that after finalizing the functionality part. At end will determine what components will be needed in Html Page.

Added and Enhanced GUI For Index


Parallel jobs don't run on the same git sha

Since multi jobs don't pass git sha to the downstream dependencies, the downstream jobs will always execute the latest commit from origin
given a job config:
{
    "stages": [
        {
            "name": "build",
            "jobs": [
                [
                        { "static_analysis": {"cmd": "echo ''" } },
                        { "compile": {"cmd": "echo ''" } },
                        { "dex_watchdog": {"cmd": "echo ''" } }
                ]
            ],
            "next-stages": [ "test" ]
        },
        {
            "name": "test",
            "jobs": [
                [
                    { "unit_tests": {"cmd": "echo ''" } },
                    { "acceptance_tests": {"cmd": "echo ''" } }
                ]
            ],
            "next-stages": [ "deploy" ]
        },
        {
            "name": "deploy",
            "jobs": [
                { "deploy_alpha": {"cmd": "echo 'deployingAlpha'"} }
            ]
        }
    ],
    "settings": {
        "jenkins-server": "http://localhost:8080",
        "default-name" : "pipelinetest",
        "git-url": "git@github.com:ssmiech/pipeline-test.git",
        "slave-label": "master"
    }
}

if there are any commits in between pipeline stages, the stages after commit will be executed with wrong git commit leading to incorrect build artifacts/results.

I think the solution would be to pass the git-commit to the job phases + pass it further to the downstream dependencies:

don't use trigger other builds  to trigger other jobs as this one does not pass the git params.

Now I think all pipelines are affected in the same way, could it be?

Fixed #6


Opioids model

Creates a generic module for the opioids addiction model developed by Project SAMMI
Adds the ability for generic modules to have complex transitions, which are a combination of conditional and distributed transitions.
Adds a "Socioeconomic Status" to each person, made up of 3 factors which range from 0.0 to 1.0; education, income, and occupation. SES is assigned at birth, and is based on the town using census data.
Adds the ability for generic modules to do logic based on SES.

For the Wiki:
Complex
Complex transitions are a combination of distributed and conditional transitions.  A complex_transition consists of an array of condition/distributions pairs which are tested in the order they are defined.  The first condition that evaluates to true will result in a transition based on its corresponding distributions.  The module will then transition to one of the transitions defined in distributions according to the same rules as the distributed_transition. See Distributed for more detail. The last element in the complex_transition array may contain only a distributions (with no condition) to indicate a fallback transition when all other conditions are false.
If none of the conditions evaluated to true, and no fallback transition was specified, the module will transition to a default Terminal state.
Please see the Logic section for more information about creating logical conditions.
Example
The following example demonstrates a state that for male patients should transition to the "Foo" state with 15% probability and the "Bar" state with 85% probability, and for female patients should transition to the "Baz" state with 75% probability and the "Qux" state with 25% probability.
{
    "type": "Initial",
    "complex_transition": [
        {
            "condition": {
                "condition_type": "Gender",
                "gender": "M"
            },
            "distributions" : [
                {
                    "distribution": 0.15,
                    "transition": "Foo"
                },
                {
                    "distribution": 0.85,
                    "transition": "Bar"
                }
            ]
        },
        {
            "condition": {
                "condition_type": "Gender",
                "gender": "F"
            },
            "distributions" : [
                {
                    "distribution": 0.75,
                    "transition": "Baz"
                },
                {
                    "distribution": 0.25,
                    "transition": "Qux"
                }
            ]
        }
    ]
}

Socioeconomic Status
The Socioeconomic Status condition type tests the patient's socioeconomic status. Socioeconomic status is based on income, education, and occupation, and is categorized in Synthea as "High", "Medium", or "Low".
Supported Properties

condition_type: must be "Socioeconomic Status" (required)
category: the gender to test for.  Synthea currently defines the following categories: High, Middle, or Low. (required)

Example
The following Socioeconomic Status condition will return true if the patient is "Middle" Socioeconomic Status; false otherwise.
{
  "condition_type" : "Socioeconomic Status",
  "category" : "Middle"
}

The wiki says High, Medium, or Low but then the example uses Middle

Thanks, good catch. The term that I'm seeing in various places online is "Middle", I assume based on "middle class". Updated code + wiki snippet and added a check in the logic module to watch out for that as it's an easy mistake to make.


Show text on hover main action button

I see that you added to show text on hover sub-buttons, but how I show text when hover the main button?
Thanks!

{"icon":"",
"title": "Add Payments"}
Give title property to display text on hover.

Hi, could you share the solution?


JUnit5 :: unit, extraction, id, and functional tests

To use the test jar --
     <dependency>
        <groupId>emissary</groupId>
        <artifactId>emissary</artifactId>
        <version>${emissary.version}</version>
        <classifier>tests</classifier>
        <type>test-jar</type>
        <scope>test</scope>
      </dependency>

Breaking this up into separate PRs see #278 #279 #300

Breaking this up into separate PRs see #278 #279 #300 #301

These are all merged now.


Don't use deprecated 'U' flag to read manifest

The universal newlines mode ('U' flag) is deprecated since Python
3.4. It only replaces "\r\n" with "\n", but it doesn't split lines at
"\r" (Mac newline). In practice, the flag was useless, the
sdist.read_manifest() method already uses line.strip() and so removes
newline characters.
Example of warning:
.../setuptools/command/sdist.py:182: DeprecationWarning: 'U' mode is deprecated
manifest = open(self.manifest, 'rbU')

I vaguely recall experimenting with this before and finding we couldn't drop it for some reason. Can we be sure the U doesn't affect other aspects such as text encoding?

New test on Python 2:
$ python2
Python 2.7.11 (default, Jun 13 2016, 12:33:53)
[GCC 6.1.1 20160510 (Red Hat 6.1.1-2)] on linux2

>>> open("x", "wb").write("\n".join(["a", "b", ""]))
>>> open("x", "rb").readlines()
['a\n', 'b\n']
>>> open("x", "rbU").readlines()
['a\n', 'b\n']

>>> open("x", "wb").write("\r\n".join(["a", "b", ""]))
>>> open("x", "rb").readlines()
['a\r\n', 'b\r\n']
>>> open("x", "rbU").readlines()
['a\n', 'b\n']

>>> open("x", "wb").write("\r".join(["a", "b", ""]))
>>> open("x", "rb").readlines()
['a\rb\r']
>>> open("x", "rbU").readlines()
['a\n', 'b\n']

Oh wait: replacing "rbU" with "rb" doesn't work for Mac newline (\r) :-/ I made a mistake in my previous test.
Test on Python 3:
$ python3
Python 3.5.1 (default, Jun 13 2016, 16:14:50)
[GCC 6.1.1 20160510 (Red Hat 6.1.1-2)] on linux

>>> open("x", "wb").write(b"\n".join([b"a", b"b", b""]))
>>> open("x", "rb").readlines()
[b'a\n', b'b\n']
>>> open("x", "rbU").readlines()
[b'a\n', b'b\n']

>>> open("x", "wb").write(b"\r\n".join([b"a", b"b", b""]))
>>> open("x", "rb").readlines()
[b'a\r\n', b'b\r\n']
>>> open("x", "rbU").readlines()
[b'a\r\n', b'b\r\n']

>>> open("x", "wb").write(b"\r".join([b"a", b"b", b""]))
>>> open("x", "rb").readlines()
[b'a\rb\r']
>>> open("x", "rbU").readlines()
[b'a\rb\r']

On Python 3, the "U" flag is simply ignored for binary mode and Mac newlines don't work as expected.

"All checks have passed"
If setuptools must support Mac newlines, at least one unit test must be added, no?

I'm all but certain we don't need to support Mac newlines any longer. I agree about the tests, with the caveat that setuptools has never had suitable use-case coverage, so we have to be extra considerate. In this case, let's make the change and if someone complains, we'll add the necessary test.


Remove multiple members from UH Groupings doesn't work #933

Squashed commits and fixed the member names being displayed.

These changes also need to go to 2-2 I am making a separate branch for that

This looks good to me!

I created a dev-2-2-0 version of this branch here

Looks good, thank you for moving the admin modal functionality in the admin controller.

Everything looks in check to me. I will also be pushing this pull request.


This PR includes integration tests for conditional profiles

Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Added integration tests for conditional profiles
Please delete options that are not relevant.

[x] Refactor/improvement

Checklist

[x] My commit message is conventional
[x] I have run pre-commit on all files before creating the PR
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] I have checked my code and corrected any misspellings

It worked with shorter timeout

Please fill the PR template, squash commits and run integration tests locally again to check if it works with the newest dependecies.

PR template filled, commits squashed, integration tests locally passed.

:tada: This PR is included in version 1.9.1-beta.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


unable to verify contract

for verification on the block explorer. Waiting for verification result...
I am met with this error message upon the verify contract step. it worked for me several times, now it throws these errors. even after restarting with a new zip file.
Error in plugin @nomiclabs/hardhat-etherscan: The contract verification failed.
Reason: Fail - Unable to verify

You didn't use the search function... and you didn't even notice that there is a pinned issue on top of the "Issues" page about this exact topic... please respect our time.


inference for plants

Inference for plants trained.

error is on this line....
local lst = protos.rnn:forward{x, unpack(current_state)}

I am getting this output for the first plant test image. Is this correct?

This does not look correct.
Have you been training with the default launcher? For how long? What is the training error you are getting at the end (in the log)?

using the default launcher...
[======================================== 100000/100000 ==============================>]  Tot: 3h32m | Step: 127ms
test: ../Data/LSCData/A1/plant042_rgb.png
==> time to learn 1 sample =<PHONE_NUMBER>8032ms
-0.60202038425659

@xjoshramos @bernard24  Hi guys, I have downloaded the Plant_Phenotyping_Datasets dataset, but I cannot find the LSCData folder. Did I download the correct dataset ? Could you provide a link ?

http://www.plant-phenotyping.org/CVPPP2014-dataset

Thanks @xjoshramos.
The training loss error you are reporting is not as low as it should be (for seq_length=2), so I would train the model for a bit longer. You can have a look at usual training loss values, as well as typical results in this issue: https://github.com/bernard24/RIS/issues/2.


Creating a (stack) loadbalancer fails: Validation failed in API: stackId

Hi!
When creating a loadbalancer within a stack (using a selector rule), it fails with the error: "Validation failed in API: stackId".

I customized the default registry to an azure registry.
The HAproxy setting is changed to hold the full path, e.g. "lb.instance.image=docker.io/rancher/lb-service-haproxy:v0.9.3"

Any help would be great!
Regards,
Jos

Useful
Info

Versions
Rancher v1.6.21 Cattle: v0.183.60 UI: v1.6.45

Access
github admin

Orchestration
Cattle

Route
service.new-balancer

With the release of Rancher 2.0, development on v1.6 is only limited to critical bug fixes and security patches.


(Feature) #925 add start claiming card

Description
Implement functionality to add new 'start claiming' feed card to the user's timeline after 3 days since the first login. Added tests for new util and event obj.
About #925
How Has This Been Tested?
Change the value from 3 days to some smaller. (UserStorageClass.js 847 line)
Register a new account.
Go to dashboard - after time you set for testing refresh the page and the new event will appear.
Check the item looking and open to test the button and design.
Don't forget to revert the changes with time back.
New Environment Variable
Delay for displaying start claiming card (in milliseconds)
Optional. Default 3 * 24 * 60 * 60 * 1000  // 3 days
REACT_APP_DISPLAY_START_CLAIMING_CARD_TIME
Checklist:

[x] PR title matches follow: (Feature|Bug|Chore) Task Name
[x] My code follows the style guidelines of this project
[x] I have followed all the instructions described in the initial task (check Definitions of Done)
[x] I have performed a self-review of my own code
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] I have added reference to a related issue in the repository
[x] I have added a detailed description of the changes proposed in the pull request. I am as descriptive as possible, assisting reviewers as much as possible.
[x] I have added screenshots related to my pull request ( for frontend tasks)
[x] I have pasted a gif showing the feature.
[x] @mentions of the person or team responsible for reviewing proposed changes

Screenshots:

Browser
Simulators

Card

Modal

Gif

@yaroslav-fedyshyn-nordwhale
Didn't we talked about canceling the line breaking after "income" in the pop up?

Yes, i fixed it. But didnt attach the new screenshots.See how it will look now -

@yaroslav-fedyshyn-nordwhale
Didn't we talked about canceling the line breaking after "income" in the pop up?

Yes, i fixed it. But didnt attach the new screenshots.See how it will look now -

Cool, looks great. Thanks!

why do we need the claiming.svg? cant we use the exisiting claim icon?
it shoud fire event when pressing the claim g$

All of the images displayed at the top of the popup dialog is placed in /src/assets/Feed/ folder. The TopImage Component makes import of these images and pasting them as src prop to a react-native Image component. So I followed the principles of TopImage Component implementation.
Whick event it should fire? I just had a look at the existing events in the app. There is no event related to 'redirect on claim page'. The 'claim G$' button redirecting the user to the claim page.

see other button events in modalactionsbyfeedtype

ok. Added event trigger for claim button. See new commit


Fixing missing Kali AMI

https://github.com/splunk/attack_range/issues/964

Thank you for improving it


Animated tiles can't be used on the background layer.

They can be used but they are invisible

4b60109bcb1fcef3083e5930f0dc06e545f3f59e


LLM Compatibility

Does this library only work with OpenAI models in the cloud, or can it also work with a local model—such as GPT-Neo, Alpaca, etc.?

Hey @mhillebrand
Currently, this only supports OpenAI GPT models.
Actually it would be great to have open source LLMs integrated that can offer great degree of reasoning.
I'll keep your issue open, will consider it as a feature request and might work on it soon.
Meanwhile, if you would like to contribute this feature, feel free to raise a PR


V0.6.0

0.6.0 changes:

Updated versioning system and build process. Each library now maintains its own version (and potentially changelog at some point).

New version format is MAJOR.MINOR.PATCH.BUILD-REVISION. This will allow for greater versioning control and patching to minor versions.
Only 0.6+ will follow this, older versioning will stay as it is.

Removed a trace warning about early memory allocations.
Branching strategy is changing.

Branch names will be based on version using the format "vMAJOR.MINOR.PATCH". Ex: v0.6.0
Development will continue to happen in feature branches, but those will be branched from version branches.
When complete, feature branches will merge into version branches.

Ex: feature/terrain_chunking is branched from v0.6.0. When complete, feature/terrain_chunking is merged into v0.6.0. feature/terrain_chunking is then deleted.

Version branches will be merged into main as they are completed. A tag is then created on the main branch.

Release cycles (when they happen) will follow this.

Changelog will list all changes under a minor version (i.e. 0.6.0) unless a later patch is made.

If a patch update is made, new notes would appear under that patch version (i.e. 0.6.1, 0.6.2, etc.).

All libraries (as of now, engine, plugin_audio_openal, standard_ui, testbed_lib and vulkan_renderer) now maintain their own versions.

NOTE: The engine version is the one used to denote primary releases, this changelog, etc. since plugins, etc. may not have updates between versions.
The build process now generates a file for each library: /src/_version.h. Ex: engine/src/engine_version.h.
Each library includes its version file and now reports version to the console during its initialization.

versiongen utility has been updated to accept a filename parameter instead of major/minor versions. The build process passes "/version.txt".

version.txt is read in its entirety (up to 10 characters) and is used to define the major, minor, and patch. Ex: "0.6.0". This is then prepended to the generated build-revision to complete the format listed above.

Added terrain chunking support.
Fixed an issue with darrays that could cause invalid header data in certain scenarios.
Updated simple scene query functions to take pointers to arrays of geometry render data to account for array resizes if needed.
Fixed extents generation for terrain chunks, which fixes improper frustum culling issue.
Fixed a bug where shader scopes weren't being bound properly in the scene pass, causing debug objects to render all over the place.
The scene is now only queried once for geometry to be used with all shadow map cascades, as opposed to once per cascade.
Removed "wireframe" shader config property and replaced it with "supports_wireframe". See next entry for details.
Added the ability to have a wireframe mode, if supported, in a shader. This creates a separate set of pipelines that are used when this
mode is selected.
Added a RENDERER_MODE_WIREFRAME, which will enable wireframe for certain shaders when swapped to.

macOS: Note that, in order to support wireframe mode in macOS the newest (at the time) Vulkan SDK
must be used (1.3.275).

Fixed an issue where ksort would segfault while trying to access a negative array index.
Added "skirt" geometry to terrain sides in an effort to plug holes in transitions between chunks.
Vulkan Renderer performance updates (see Vulkan Plugin Changelog).
To facilitate the above, several areas of logic that previously required a separate command buffer and queue wait have had thier work offloaded
to the beginning of the next frame. This reduces waits and more efficiently batches workload to the GPU.
The core engine frame lifecycle now has a slightly altered sequence of events. The new cycle is as follows (only changed section is listed):

After resize detection, renderer_prepare is called, which can cause the renderer to wait for resource regeneration if needed. Otherwise:
renderer_begin is now called in the main engine loop instead of by the application. This makes the renderer begin its current command buffer.
systems_manager_renderer_frame_prepare is called. All systems can now have a "frame_prepare" phase, which is optional. Only standard_ui uses this for now. This is to allow updates which need GPU uploads to occur before the rest of the frame workload begins.
The application instance recieves a call to its prepare_frame.

In testbed, this calls a new function in simple_scene for prepare_frame, which handles any GPU uploads before the rest of the frame workload begins.

renderer_end ends the renderer's current command buffer. This is now called from the main engine loop instead of the application.
renderer_present presents the current drawn-to attachment to the screen. This is now called from the main engine loop instead of the application.

Added missing "peek" function to stack container.
Fixed an issue with the sui_label_control where pending data didn't include new vertex/index buffer offsets during an update.
Created specialized rendergraphs for Forward rendering, one for the Editor (currently lives in TestBed) and one for Standard UI.
Added job ids, and job dependencies that can be used to link jobs one after another.
Added semaphores.
Updated job system to use semaphores to block worker threads until there is work to be done. Semaphores are signaled when work is deployed to a job thread.
Added threadpool, worker threads and setup layered texture loading to use them.

NOTE: the target branch was renamed to release/v0.6.0.


question: support  option for remote host

Hi Sultan team,
Thank you for developing and sharing this package.  Is it possible to provide an SSH port number, alternative to 22 via the API?  I know I could workaround this using an .ssh/config setting.  I'd prefer to have this ability supported natively in the API if possible.
Cheers,
-- Jeremy

Good idea. I'll add it as part of the next release

This is fixed now in Sultan v0.6. http://sultan.readthedocs.io/en/latest/sultan-ssh-examples.html#example-3-passing-additional-options-port
I'm going to close this ticket, but please reopen it if it is still an issue.


Vite creations and file structure

initialize the vite react template and aff folder and file to create outline

DONE I was stressing about this assignment i didn't even make any issues. this is all done retroactively


Truth constants as properties

Just a minor suggestion. It seems strange to write truth constants as function calls TRUE() and FALSE().
https://github.com/aiplan4eu/unified-planning/blob/master/unified_planning/model/expression.py#L407
How about providing them as properties of ExpressionManager? This technique is in use in UP even for more complex properties.

My understanding is that FNode is mostly intended for internal usage (even though it leaks in some parts of the API).
I would say that in any public API where you would like to represent true, the corresponding python literal should be accepted as well.
For instance, the BoolenExpression type alias (used in And, Or,...)  accepts python booleans as an alternative to more complex expressions.

The support for the Python literals is great, no doubt. The suggestion still stands, though, since somebody decided to explicitly offer these constants. Anyway, I close this issue since it is really minor. Sometimes improvements just need the right circumstances to happen.


Remove property range validation from ECL builder

Some ECL is valid, but uses properties and ranges not in the domain property range ontology. As a result you cannot use the ECL builder.
Suggest removing the validation, whilst retaining the expected properties and expected range for new properties. This enables ECL to get ahead of the authoring, which will then need to catch up


Permanent workspace delete incorrect

The example for the permanent workspace delete poewrshell command is incorrect:
Remove-AzOperationalInsightsWorkspace -ResourceGroupName "resource-group-name" -Name "workspace-name" -Force
The -Force tag in the powershell command Remove-AzOperationalInsightsWorkspace forces the command to run without asking for user confirmation. (https://docs.microsoft.com/en-us/powershell/module/az.operationalinsights/remove-azoperationalinsightsworkspace?view=azps-4.3.0)
It needs to be the az command:
az monitor log-analytics workspace delete --resource-group
--workspace-name
[--force {false, true}]
[--subscription]
[--yes]
--force -f
Deletes the workspace without the recovery option. A workspace that was deleted with this flag cannot be recovered.
accepted values: false, true
(https://docs.microsoft.com/en-us/cli/azure/monitor/log-analytics/workspace?view=azure-cli-latest#az-monitor-log-analytics-workspace-delete)

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 86984751-da7f-c77b-c78b-a9c9ffacb4a3
Version Independent ID: 57838082-5ee8-097c-9814-803a5077ba4e
Content: Delete and recover Azure Log Analytics workspace - Azure Monitor
Content Source: articles/azure-monitor/platform/delete-workspace.md
Service: azure-monitor
Sub-service: logs
GitHub Login: @bwren
Microsoft Alias: bwren

@HuwSilverthorn - Thanks for brining this to our attention. We will investigate it further and update you shortly.

#label:"CreateAzMonWIFeb2021"

Thank you for your contribution to the Azure Monitor documentation. We have created a workitem for this issue in our internal backlog database. We will prioritize it and make any necessary changes as we are able.
#please-close


Custom module not loading in Front-end builder

Hello
I'm trying to create a new custom module with instruction - https://www.elegantthemes.com/documentation/developers/divi-module/how-to-create-a-divi-builder-module/
All works fine except the module in the frontend builder, it shows strange content - https://prnt.sc/qhwruk
And i can not get how can i make it works. Because i have only Divi theme and no Divi plugin. In this case i have not such files "HelloWorld.jsx" and "index.js". Can you please help with this.

To get tis to work you have to include the following lines to your divi-module class. So if you made a Hello-World Module you can find it under includes/HelloWorld.php
`/**
* Enqueues non-minified, hot reloaded javascript bundles.
*
* @since 3.1
*/
protected function _enqueue_debug_bundles() {
// Frontend Bundle
$site_url       = wp_parse_url( get_site_url() );
$hot_bundle_url = "http://localhost:3000/static/js/frontend-bundle.js";
	wp_enqueue_script( "{$this->name}-frontend-bundle", $hot_bundle_url, $this->_bundle_dependencies['frontend'], $this->version, true );

	if ( et_core_is_fb_enabled() ) {
		// Builder Bundle
		$hot_bundle_url = "http://localhost:3000/static/js/builder-bundle.js";

		wp_enqueue_script( "{$this->name}-builder-bundle", $hot_bundle_url, $this->_bundle_dependencies['builder'], $this->version, true );
	}
}`

Did you use npx create-divi-extension helloworld to create your plugin? If so there should be a php and jsx file in the /includes/modules/helloworld folder.
The text you see in the VB is usually caused because you are not running yarn start during development. By running yarn start from the root directory of your extension (plugin folder), a development server will be startet which on the fly compiles the jsx file to js which can be used in the VB.

Hi, i'm have some problem. but the module i look on builder

and the page normal

Hi @Hononenokami! Please be sure that yarn start is running (in the root folder of module) while you develop.


Here is the mac build for you [Wed Nov 22 19:42:14 2017] 442ec4c

mscHack.zip

Major thanks JW

Thank you very much!


Update module to support SilverStripe 4

Namespace code
Update tests to work with SS4, try and setup travis to see if it works
Update Travis to tests against 5.6, 7.0 and 7.1
Update README with new instructions
Move module to sit inside vendor/ instead of in webroot

Nice work @madmatt 👍

Hold fire on merging this for a bit, I've found a few bugs with how it handles versioned data objects and intermediary objects (e.g. Page doesn't truncate SiteTree but does truncate descendants of Page for example). Have fixed a few of these up but will use it a bit more before I push up changes.

Good to go now? Or still wait for more testing?

Up to you both - I haven't tested every feature of the module, and the current tests don't cover a huge amount (the Versioned test was passing even before I fixed the versioned stuff 😉 ).
I guess you won't release a new version right away, so in that case it's probably fine for dev-master to be unstable?
Will leave it with you to decide :)

Sorry, file formatting has gotten whack with IDE changes (tabs v spaces). Rather than adding PSR-2 to this change (which will make it hard to review just the actual code changes, even with ?w=1 I suspect), I suggest we do a separate PSR-2 review once this has been merged in - renaming to use a src/ directory and so on. Otherwise I can do it as part of this PR if you'd prefer, I just like to keep them separate if possible.

@pitchandtone, @wilr: I think this is good to go now, haven't had to make any alterations in the last little while.
It currently has some issues that the original module had (e.g. doesn't clear relation tables like Group_Members), but that could come as a separate PR to avoid this dragging on forever.


Update README.md

Hello,
I try to use your extension, but I didn't make it works.
I think the readme isn't up-to-date because the last commit is from 4 month and didn't talk about the prerequisite PluggableAuth.
Can you please update the readme for the new integration path ?
Thank you

Sorry about that, I haven't had time to update the README. Please take a look at https://www.mediawiki.org/wiki/Extension:JWTAuth for more info

Thank you, but I can't find the correct configuration...
In LocalSettings.php I have :
# PluggableAuth with JWTAuth

wfLoadExtension( 'PluggableAuth' );
wfLoadExtension( 'JWTAuth' );

$wgPluggableAuth_Config = [
	"Overbookd" => [
	  'plugin' => 'JWTAuth',
	  'data' => [
		'Key' => 'supersecret',
		'Algorithm' => 'HS256'
	  ]
	]
  ];

  $wgGroupPermissions['*']['autocreateaccount'] = true;
  $wgPluggableAuth_EnableAutoLogin	= true;
  $wgPluggableAuth_EnableLocalProperties	= false;

And the JWT I want to use is :
eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpZCI6OCwidXNlcklkIjo4LCJ0ZWFtcyI6WyJhZG1pbiIsImhhcmQiXSwicGVybWlzc2lvbnMiOlsiYWRtaW4iLCJtYW5hZ2UtY29uZmlnIiwicmVhZC1mdCIsImFzay1mb3ItaGVscCIsInZpZXctdGltZWxpbmUiLCJoYXJkIiwidmFsaWRhdGVkLXVzZXIiLCJyZWFkLWZhIiwiZG93bmxvYWQtcGxhbm5pbmciLCJjcCIsInZpZXctc3RhdHMiLCJmaWxsLWF2YWlsYWJpbGl0eSJdLCJwcmVmZXJyZWRfdXNlcm5hbWUiOiJhZG1pbl9hZG1pbiIsImlhdCI6MTY5MzQyNTQzMSwibmJmIjoxNjkzNDI1NDMxLCJleHAiOjE2OTM1MTE4MzEsImF1ZCI6IlVzZXIgb2YgT3ZlcmJvb2tkIiwiaXNzIjoiT3ZlcmJvb2tkIC0gQ2x1YiBkZXMgMjRoIGRlIGwnSU5TQSIsInN1YiI6Ik92ZXJib29rZCJ9.9bjMTjfxDAuIWLy8UQfSlOB_KhsEHFfXbs26RYVgR6E
Decode JWT :
{
  "id": 8,
  "userId": 8,
  "teams": [
    "admin",
    "hard"
  ],
  "permissions": [
    "admin",
    "manage-config",
    "read-ft",
    "ask-for-help",
    "view-timeline",
    "hard",
    "validated-user",
    "read-fa",
    "download-planning",
    "cp",
    "view-stats",
    "fill-availability"
  ],
  "preferred_username": "admin_admin",
  "iat":<PHONE_NUMBER>,
  "nbf":<PHONE_NUMBER>,
  "exp":<PHONE_NUMBER>,
  "aud": "User of Overbookd",
  "iss": "Overbookd - Club des 24h de l'INSA",
  "sub": "Overbookd"
}

I have all required fields according the documentation but I have always the following error message
"Unable to continue connection. Your session has probably expired."

Have I missed an information ?

Hi, I have a problem too.
I'm want to setting private environment for mediawiki selfhost and
following from extension installing and configuration guide but not work. I'm not sure what i did mistake or something wrong.
In LocalSettings.php I have setting 2 options
option 1 :
wfLoadExtension( 'PluggableAuth' );
wfLoadExtension( 'JWTAuth' );

$wgPluggableAuth_Config = [
	"JWT Login" => [
	  'plugin' => 'JWTAuth',
	  'data' => [
		'Key' => 'SECRET',
		'Algorithm' => 'HS256'
	  ]
	]
  ];
$wgGroupPermissions['*']['read'] = false;
$wgPluggableAuth_EnableAutoLogin	= true;
$wgPluggableAuth_EnableLocalProperties	= false;

option 2 :
wfLoadExtension( 'PluggableAuth' );
wfLoadExtension( 'JWTAuth' );
$wgJWTAuthAlgorithm = 'HS256';
$wgJWTAuthKey = 'SECRET';

$wgJWTGroupMapping = [
  // one group can map to multiple MediaWiki groups...
  'customgroup1' => [
    'sysop', 'bureaucrat'
  ],
  // ...or just one MediaWiki group.
  'customgroup2' => 'sysop'
];

$wgGroupPermissions['*']['read'] = false;
$wgPluggableAuth_EnableAutoLogin	= true;
$wgPluggableAuth_EnableLocalProperties	= false;

JWT :
eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJodHRwOi8vc2NoZW1hcy54bWxzb2FwLm9yZy93cy8yMDA1LzA1L2lkZW50aXR5L2NsYWltcy9zaWQiOiIxIiwiRnVsbG5hbWUiOiJDaGFsZXJtY2hhdCBUaGFpcGVlcmFrdWwiLCJodHRwOi8vc2NoZW1hcy54bWxzb2FwLm9yZy93cy8yMDA1LzA1L2lkZW50aXR5L2NsYWltcy9uYW1lIjoid2thZG1pbiIsImh0dHA6Ly9zY2hlbWFzLnhtbHNvYXAub3JnL3dzLzIwMDUvMDUvaWRlbnRpdHkvY2xhaW1zL2VtYWlsYWRkcmVzcyI6ImNoYWxlcm1jaGF0LnRAaGFuZHMtb24uY28udGgiLCJodHRwOi8vc2NoZW1hcy5taWNyb3NvZnQuY29tL3dzLzIwMDgvMDYvaWRlbnRpdHkvY2xhaW1zL3JvbGUiOiJBZG1pbmlzdHJhdG9yIiwicHJlZmVycmVkX3VzZXJuYW1lIjoid2thZG1pbiIsImVtYWlsIjoiY2hhbGVybWNoYXQudEBoYW5kcy1vbi5jby50aCIsImZhbWlseV9uYW1lIjoiVGhhaXBlZXJha3VsIiwiZ2l2ZW5fbmFtZSI6IkNoYWxlcm1jaGF0Iiwic3ViIjoid2lraS1qd3QiLCJwZXJtaXNzaW9ucyI6WyJWSUVXIiwiQUREIiwiVVBEQVRFIiwiREVMRVRFIl0sIm5iZiI6MTcxMzk2NjExOSwiZXhwIjoxNzE0MDA5MzE5LCJpYXQiOjE3MTM5NjYxMTksImlzcyI6ImhhbmRzb24taXQiLCJhdWQiOiJoYW5kc29uLW1hcmtldGluZyJ9.tofP75EzM7nSVDeWmhQ_B5sHKpOwMS2MR1UR7bdILHU
Decode JWT :
  {
  "http://schemas.xmlsoap.org/ws/2005/05/identity/claims/sid": "1",
  "Fullname": "admin wikimedia",
  "http://schemas.xmlsoap.org/ws/2005/05/identity/claims/name": "wkadmin",
  "http://schemas.xmlsoap.org/ws/2005/05/identity/claims/emailaddress"<EMAIL_ADDRESS>  "http://schemas.microsoft.com/ws/2008/06/identity/claims/role": "Administrator",
  "preferred_username": "wkadmin",
  "email"<EMAIL_ADDRESS>  "family_name": "wikimedia",
  "given_name": "admin",
  "sub": "wiki-jwt",
  "permissions": [
    "VIEW",
    "ADD",
    "UPDATE",
    "DELETE"
  ],
  "nbf":<PHONE_NUMBER>,
  "exp":<PHONE_NUMBER>,
  "iat":<PHONE_NUMBER>,
  "iss": "handson-it",
  "aud": "handson-marketing"
}

i used setting "option1" and "option2" but no luck and this is result
Result
Option 1:

Option 2:

Can you advice me for this problem?

Today I finally got the chance to update the docs. Your configs look correct, so I'm suspecting whether it's because it's not being POSTed to Special:PluggableAuthLogin. Please see https://www.mediawiki.org/wiki/Extension:JWTAuth#Integrating_your_auth_system_with_JWTAuth_on_MediaWiki for more info.


Config updates should be propagated

Describe the problem/challenge you have
When I update the config for a package, the package needs to be updated.
Describe the solution you'd like
15. As a user, I want my package to be updated if I update the configuration for the package.
Anything else you would like to add:
Status: Currently not possible in TCE package plugin. PENDING ISSUE Will be moved into Tanzu CLI Package plugin. Experience to be defined.

Vote on this request
This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.
👍 "I would like to see this addressed as soon as possible"
👎 "There are other more important things to focus on right now"
We are also happy to receive and review Pull Requests if you want to help working on this issue.

Sorry - I have been opening a few here that should be for the Tanzu CLI plugin. Closing.


Ability to record Glory and make Reputation rolls directly from character sheet

Is your feature request related to a problem? Please describe.
Have to use a workaround when using Reputation instead of Discipline when rolling; having to record Glory in an ad-hoc note section.
Describe the solution you'd like
A field on the sheet to record Glory acquired.
Ability to roll for Glory as per STA Klingon Empire rulebook and add newly acquired Glory to total.
A ‘tickable’ Reputation field on the sheet
Describe alternatives you've considered
To use reputation: temporarily adjusting a Discipline to match.
Additional context
None.

Reputation roll to be included for 2e character sheets in v1.2.4.
I don't have the Klingon book though, can you explain how glory works?

Glory is the same as Acclaim in 2e.

Would it clutter the character sheet too much to add somewhere to record Acclaim (Glory) and Reprimand (Dishonour)? Could just be a free text box to record a number rather than a tracker.

Weirdly there isn't anywhere to record this on the official forms that Modiphius produced either, on either the main sheet or on the personal log.... I wonder whether an enhancement could be for a 2nd tab on the character sheet for the personal log, and it could be captured there? The main sheet itself is already quite busy.

Did the latest update sufficiently resolve this issue? There's a space on the character sheet to record it, and the side bar roller can roll any combo you can think of (so 7 and reputation for example). If so I'll close this issue.

The side bar roller is great, but for reputation rolls there is the following (p.171 2e core book):

Assemble Dice Pool: Roll a number of d20s equal to the number of positive influences you have. Unlike a normal task, there is no maximum number of d20s for this roll.

Although in reality there are only 7 items in the list of positive influences, so a practical limit of 7 dice in the dice pool here?

The sidebar roller now allows for free input of dice numbers, does this now meet your requirements?

That's perfect, thanks!


fix: typo in defineExpose in UiTextarea

Description
exposed object in UiTextarea
Related Issue

Closes #
Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):
Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my code
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes

I did it in my PR


Merge Editor does not having preview merge

Hi all, have been waiting for this feature for quite sometime.
Tried it out today but unfortunately i dont get the preview merge option as shown. i have updated the git mergeEditor to true.
Do i need to do some more additional settings ?
A screenshot of the same

Thanks

This should work now, please try it out and let us know what you think about it.


Prevent memory leak when SimpleChannelPools are destroyed

Motivation:
https://github.com/netty/netty/pull/9548 introduced a change that creates a new AttributeKey for each SimpleChannelPool instance created. AttributeKeys are cached statically in a ConstantPool by the AttributeKey.newInstance method. Because of this, creating a SimpleChannelPool instance will allocate memory that will never be released, even after the SimpleChannelPool is closed.
Modifications:
This change goes back to a single AttributeKey for all SimpleChannelPool, just using a more specific name to reduce the chance of conflicts with user code.
Result:
No memory is leaked after a SimpleChannelPool instance is created and destroyed.

@netty-bot test this please

@millems oh my... you are right

@millems thanks a lot!


Add Analytics lib

Includes HTTP-based clients for Google Analytics and Tracks with simple event tracking support.
TODO:

[x] Wire up uuid (#117)
[x] Config for specifying GA ID
[x] Tests

In future PRs, also need to implement:

Integrate with CLI
Disclosure on login
Opt-out

See #32

Still have to generate the GA ID for the published release.


Design fixes for footer and some other fixes

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):
Fix #37
Test URLs:

Before: https://main--channelco-crn-com--hlxsites.hlx.page/
After: https://design-fixes--channelco-crn-com--hlxsites.hlx.page/

Closing. Please open PR against https://github.com/thechannelcompany/crn-com


Remove celo-extension-wallet

Is there an existing issue for this?

[X] I have searched the existing issues

Description
Consider removing the celo-extension-wallet option
It haven't been updated since June 2021. It's dead, better to not direct users there anymore. Especially since Metamask works well with Celo these days.
Steps to reproduce

Expected behavior

Screenshot
No response
Where is the problem happening?
Both
Environment

What version of react-celo were you using? (This can be found in the list of wallets in the "Connect" modal)
latest
What wallet were you using?
No response
What is the dApp URL? (if applicable)
No response
Additional context
No response

Agreed, I'm going to remove it from defaults and deprecate it but not remove it yet. We'll remove it next major release.


How to download the eval / test videos?

Hi, thanks for this great work. In the README I see instructions for downloading the training data. However, I wonder where can I download the validation & testing data? In the json files I only see video path formatted like storybench/xxx, which are not links. Can you provide the links for downloading these videos?
EDIT: ok I guess I can download them from the original video datasets. Hopefully the video path matches the original video name

Hi, yes! The videos are from the original datasets (UVO, Oops and DiDeMo).
Please let me know if you have any issues downloading them, and feel free to share your steps here (for future users).

Thanks for your reply. It's actually easier than I thought. I just go to their official websites, and select videos in the annotation json files. The only issue I met is about the DiDeMo dataset -- it's a very old dataset so the dataset website no longer works. Nevertheless, I found this issue reply and followed it to successfully download the raw videos.

Great! You can also download the DiDeMo videos from a Google Drive linked in their repo's README file.

Great! You can also download the DiDeMo videos from a Google Drive linked in their repo's README file.

I checked that link first, but I think they only stored 13 missing videos instead of all videos in the drive? Maybe I'm missing smth

A few questions about the task split and annotations:

What's the difference between story and segment? IIUC, a story may contain multiple segments -- segments are different actions/steps in a story. For example, in a story happening in a swimming pool, segments can be 1) people stand in the pool, 2) someone starts to swim left, 3) he arrives at the border and swims back.
Yet, on Oops and UVO, a video might contain more than one story. For example, UVO test set has 1565 videos but 2613 stories. Is my understanding correct?
I did some check of data/tasks/uvo-test/story_cont.json, and found that some stories only have one segment, e.g. the first two entries I posted below, which are from the same video. I'm a bit confused because from my understanding, story continuation means we have some initial frames of the first segment, plus captions of more than one segments. But for the below two examples, since they both have only one text, shouldn't they be excluded from the story continuation task?

Sorry for so many questions! A very detailed one:

According to the paper, you always condition on the initial 4 frames in the story continuation task. Indeed, skip_frames_after_generation for most items in the json file is 4, the same as npz_video_end_frame. However, there are a few examples with a different value as I posted below. What does this mean?

>>> [a['skip_frames_after_generation'] for a in story_cont if a['skip_frames_after_generation'] != 4]
[83, 6, 38, 95, 8, 5, 12, 18, 90, 148, 9, 22, 10, 11, 37, 26]

Sorry for so many questions but a few more after processing the data in detail:
5. I noticed some differences between json files of the same dataset on UVO, specifically, data/uvo-test.json and data/tasks/uvo-test/story_gen.json. Sometimes the background descriptions don't match, sometimes the segment captions don't match. Should I always use the one under tasks? On DiDeMo everything matches tho, and I haven't checked Oops.

@e-bug a gentle reminder of the above questions. Thank you!

Hi, sorry for the late reply.

story vs segment

A video story is a sequence of video segments, where each segment is represents an action.

a video might contain more than one story

Yes, a few videos have been annotated by multiple annotators, resulting in multiple annotations per video.
Moreover, for UVO and Oops, each video was originally described from the perspective of a given actor in VidLN.
So, for a given video id (e.g. "UVO_dense_val_100"), you can have different annotations for different actors (e.g. "UVO_dense_val_100_1" or "UVO_dense_val_100_2")

story continuation of single-segment videos

Yes, several stories are indeed 1 segment long, as we pointed out in the paper. We did not remove single-segment stories from story continuation but your point is valid. You could either remove them, or show performance w.r.t. number of segments per story.

story generation vs story continuation

Yes, story generation aims at generating a video without any visual conditioning. Instead, we first generate one segment from the background_description and then continue video generation from there.

differences between json files

Hmm.. I'll need to double-check. In the meantime, please use the task-specific annotations as they would match our evaluation setup.

Thanks for the detailed reply! Yeah I guess since my model only cares about multi-action story, I will only evaluate on videos examples with multiple segments.


Make AltScreen is an option

Hi @elewis787, Nice project
Can you make the AltScreen is an option ?
like this format
boa.WithAltScreen(false) // or true

@abdfnx absolutely! I am planning on improving some of the optional configurations and will add this to that effort.

Changes have been added to v0.1.0
I realized after pushing that the readme and go docs could use some updates so I will be circling back to that next but here is an example usage
	styles := boa.DefaultStyles()
	styles.Title.BorderForeground(lipgloss.AdaptiveColor{Light: `#E3BD2D`, Dark: `#E3BD2D`})
	styles.Border.BorderForeground(lipgloss.AdaptiveColor{Light: `#E3BD2D`, Dark: `#E3BD2D`})
	styles.SelectedItem.Foreground(lipgloss.AdaptiveColor{Light: `#353C3B`, Dark: `#353C3B`}).
		Background(lipgloss.AdaptiveColor{Light: `#E3BD2D`, Dark: `#E3BD2D`})
	b := boa.New(boa.WithAltScreen(true), boa.WithStyles(styles))

	rootCmd.SetHelpFunc(b.HelpFunc)
	rootCmd.SetUsageFunc(b.UsageFunc)

You can still use the package level HelpFunc and UsageFunc if you do not want to change any of the default behavior
i.e
rootCmd.SetHelpFunc(boa.HelpFunc)
rootCmd.SetUsageFunc(boa.UsageFunc)

Closing this out but please feel free to reopen if this does not solve the issue !

thank you so much @elewis787


[pigeon] Support custom type arguments

Use case
Defining custom argument types would be very helpful to reduce code duplication. Nothing special about that just more Generics support
Proposal
Opportunity to generate Apis using such classes (at least for Kotlin/Swift)
class A<T> {
  final List<T> list;
  final T value;

  A({required this.list, required this.value});
}

sealed class Option<T> {}

class Some<T> extends Option<T> {
  final T value;

  Some({required this.value});
}

class None<T> extends Option<T> {}

Actually we know that in HostApi/FlutterApi only known types are used, either are generated or predefined (int, bool, String etc), so it is possible to implement such feature.

This could end up being somewhat misleading as it wouldn't be true generic support.
It would work normally for the types that are normally supported, but not for any custom types defined outside of the pigeon file. Those types could be used, but would fail to encode/decode and crash.
I did just add sealed class extensions that could be used to solve this problem for you, but only for classes/enums.
I'll look into it more to see what I can do.

It would work normally for the types that are normally supported, but not for any custom types defined outside of the pigeon file. Those types could be used, but would fail to encode/decode and crash.

Yes. Only  normally supported types and types defined within pigeon file should be allowed to be used as custom type arguments
I meant exactly that

Could you provide a concrete use case, so that we can evaluate the potential benefits? I'm very skeptical that we want to add ways of generating code that won't always work, and it's hard to reason about the benefits in the abstract.

Could you provide a concrete use case, so that we can evaluate the potential benefits? I'm very skeptical that we want to add ways of generating code that won't always work, and it's hard to reason about the benefits in the abstract.

Let's assume that we have add-to-app application that is provided like black box.
I would like to have safely typed protocol that consumer will know about and support/implement.
For example:
@HostApi()
abstract class SomeHostApi {
  Result<SomeMethodFailure, String> getSomething();
}

sealed class Result<T, K> {}

class Success<T, K> extends Result<T, K> {
  T value;
  Success({
    required this.value,
  });
}

class Failure<T, K> extends Result<T, K> {
  K error;
  Failure({
    required this.error,
  });
}

enum SomeMethodFailure {
  noNetwork,
  unknown,
  notFound,
}

This is the most obvious example. In such case we got finite amount of errors that everyone is known about and should respect.
Yes we could rely on PlatformException.code but it is raw String that could contain anything.

I don't follow; what benefit are the generics providing in that example? It appears to be identical in practice to:
@HostApi()
abstract class SomeHostApi {
  SomeMethodResult getSomething();
}

sealed class SomeMethodResult {}

class SomeMethodSuccess extends SomeMethodResult {
  String value;
  StringSuccess({
    required this.value,
  });
}

class SomeMethodFailure extends SomeMethodResult {
  SomeMethodFailureCode error;
  SomeMethodFailure({
    required this.error,
  });
}

enum SomeMethodFailureCode {
  noNetwork,
  unknown,
  notFound,
}

I don't follow; what benefit are the generics providing in that example? It appears to be identical in practice to:

In practice we should write dozens of code to follow such approach:

@HostApi()
abstract class SomeHostApi {
  Result<GetStringFailure, String> getString();

  Result<GetIntFailure, int> getInt();

  Result<GetDoubleFailure, double> getDouble();

  Result<GetBoolFailure, bool> getBool();

  Result<GetCustomFailure, Custom> getCustom();
}

class Custom {}

sealed class Result<T, K> {}

class Success<T, K> extends Result<T, K> {
  T value;
  Success({
    required this.value,
  });
}

class Failure<T, K> extends Result<T, K> {
  K error;
  Failure({
    required this.error,
  });
}

enum GetStringFailure {
  noNetwork,
  unknown,
  notFound,
}

enum GetIntFailure {
  invalidFormat,
  outOfRange,
}

enum GetDoubleFailure {
  unknownValue,
}

enum GetBoolFailure {
  somethingWentWrong,
}

enum GetCustomFailure {
  genericsAreHard,
}

Now image how many lines of code should we write to follow your approach


Show default identity in ockam identity show

fix(rust): Fix issue 3461, Make ockam identity show command work without creating nodes
Current Behavior
> ockam enroll
...
> ockam identity show
No such node available. Run `ockam node list` to list available nodes

Proposed Changes
Check for a failure to find a port number for an identity and show information
about the default identity instead.
Checks

[x] All commits in this Pull Request are signed and Verified by Github.
[ ] All commits in this Pull Request follow the Ockam commit message convention.
[x] I accept the Ockam Community Code of Conduct.
[x] I have accepted the Ockam Contributor License Agreement by adding my Git/Github details in a row at the end of the CONTRIBUTORS.csv file in a separate pull request to the build-trust/ockam-contributors repository.

I'm not sure about the third check, please let me know if I got the format right.

@rtsuk thank you for creating a PR.
Don't worry about the commit message, we can fix it as part of the merge.
This will satisfy the commit linter.

feat(rust): show default identity in ockam identity show

I'll look at the PR in more detail a little later today.

I'm going to close this for now since there's no consensus on how to solve the related issue and I've learned what I need to learn.


Further exponential notation fix.

I neglected to apply the NumberStyles.Float fix for supporting exponential notation to the V2 SchemaDeserializer. I also added it to the handling of Maximum and Minimum properties in both V2 and V3 SchemaDeserializer's as hey both leverage decimal.Parse().

@darrelmiller any idea what's causing my pull requests to fail on the OpenApi-CI-Allbranches check? This is the second time. Unfortunately, the check won't let me see the details.

The tests are failing...
[xUnit.net 00:00:05.51]   Starting:    Microsoft.OpenApi.Readers.Tests
##[error][xUnit.net 00:00:07.09]     Microsoft.OpenApi.Readers.Tests.V2Tests.OpenApiDocumentTests.ParseDocumentWithDifferentCultureShouldSucceed(culture: "hi-IN") [FAIL]
[xUnit.net 00:00:07.09]       System.FormatException : Input string was not in a correct format.
[xUnit.net 00:00:07.10]       Stack Trace:
[xUnit.net 00:00:07.10]            at System.Number.StringToNumber(String str, NumberStyles options, NumberBuffer& number, NumberFormatInfo info, Boolean parseDecimal)
[xUnit.net 00:00:07.10]            at System.Number.ParseDecimal(String value, NumberStyles options, NumberFormatInfo numfmt)
[xUnit.net 00:00:07.10]            at System.Decimal.Parse(String s, NumberStyles style, IFormatProvider provider)
[xUnit.net 00:00:07.10]         src\Microsoft.OpenApi.Readers\V2\OpenApiSchemaDeserializer.cs(35,0): at Microsoft.OpenApi.Readers.V2.OpenApiV2Deserializer.<>c.<.cctor>b__83_141(OpenApiSchema o, ParseNode n)
[xUnit.net 00:00:07.10]         src\Microsoft.OpenApi.Readers\ParseNodes\PropertyNode.cs(41,0): at Microsoft.OpenApi.Readers.ParseNodes.PropertyNode.ParseField[T](T parentInstance, IDictionary`2 fixedFields, IDictionary`2 patternFields)
[xUnit.net 00:00:07.10]         src\Microsoft.OpenApi.Readers\V2\OpenApiSchemaDeserializer.cs(252,0): at Microsoft.OpenApi.Readers.V2.OpenApiV2Deserializer.LoadSchema(ParseNode node)
[xUnit.net 00:00:07.10]         src\Microsoft.OpenApi.Readers\ParseNodes\MapNode.cs(70,0): at Microsoft.OpenApi.Readers.ParseNodes.MapNode.<>c__DisplayClass6_0`1.<CreateMap>b__0(KeyValuePair`2 n)
[xUnit.net 00:00:07.10]            at System.Linq.Enumerable.WhereSelectEnumerableIterator`2.MoveNext()

Thank you Darrel. I'll blame it on a "senior" moment. Test are passing now.

@EricWilson-BluePrism I believe your code was right and the tests are wrong.  JSON and YAML do not allow commas in integer or floating point values.  Yaml does support octal and hexadecimal but JSON doesn't, so we shouldn't.  The commas should be removed from the tests and the NumberStyle should go back to being Float.
Let me know if you want me to make those change.

Hi @darrelmiller,
I'm happy to make the changes. Do you want me to update the test cases too?
Cheers,
Eric

@darrelmiller,
I've changed the NumberStyles back to Float and removed the commas from the two test cases.
Cheers,
Eric

Thank you for this contribution.  I'm really hoping we can get the build pipeline sorted so that we can release an update soon.


Update dependencies toward ring 0.17 and aarch64-pc-windows-msvc targeting support

These dependencies are in the tree that depend on ring 0.16.20 and prevent compiling for aarch64-pc-windows-msvc.
By updating them all these, the only remaining path to 0.16.20 is through hdwallet, which hasn't yet upgraded (https://github.com/jjyr/hdwallet/pull/21).

@juanky201271 Do you think you could help with addressing the build break:
error[E0433]: failed to resolve: use of undeclared crate or module `futures_core`
   --> /home/andrew/git/zingolib/target/debug/build/zingolib-acd9665e77faf7c5/out/cash.z.wallet.sdk.rpc.rs:711:35
    |
711 |         type GetBlockRangeStream: futures_core::Stream<
    |                                   ^^^^^^^^^^^^ use of undeclared crate or module `futures_core`

As this break is evidently in generated code instead of code within the repo (if I'm reading the path correctly), I don't know what it'll take to fix this.

@juanky201271 Do you think you could help with addressing the build break:
error[E0433]: failed to resolve: use of undeclared crate or module `futures_core`
   --> /home/andrew/git/zingolib/target/debug/build/zingolib-acd9665e77faf7c5/out/cash.z.wallet.sdk.rpc.rs:711:35
    |
711 |         type GetBlockRangeStream: futures_core::Stream<
    |                                   ^^^^^^^^^^^^ use of undeclared crate or module `futures_core`

As this break is evidently in generated code instead of code within the repo (if I'm reading the path correctly), I don't know what it'll take to fix this.

Well, sorry, but I have no idea. Maybe @AloeareV can help up...


Make toObservable lazy.

Prevents work (like cache key calculation) from happening before subscription

This also implies that queue()/observe() will not throw anymore
The IllegalStateException now gets wrapped in a HystrixRuntimeException

/cc @stevegury @robertroeser @NiteshKant Thoughts on this?

I am not familiar with the code but conceptually wrapping it in .defer() makes sense for lazy method toObservable()


[Bug] Non Clean Music Automatically

Describe the bug
I don't know exactly if this is a bug, but I think it is. So basically I am a clean user, meaning I have the clean filter on in Apple Music. On Apple Music on my iPad all the explicit songs everywhere are replaced with the clean songs by default, and so if I search 16 by Baby Keem or look the top 100 Apple Music Global songs, it would automatically show all the clean versions. I also used to use apple music web on my windows machine and the same would happen. But now on your electron app everything is shown its explicit version and because of my settings I can't play anything. In Apple Music made playlists I have to go the album and look for the clean version of the song and play it, while in just normal albums I have to find the clean version and play it. Please fix this and make it so your app also automatically shows only the clean versions of songs instead of the explicit if the clean filter is on. I don't even know how you changed it and made that not work but 🤷
To Reproduce
Steps to reproduce the behavior:

Go to your settings and add the song restrictions to clean only
Go to Browse and Global Top 100
Watch as all the explicit versions of songs show up and you can't play anything except the songs which have no explicit version

Expected behavior
All the songs with clean versions showing up as playable and when you press play the clean version plays.
Screenshots
Apple music website:

Apple music electron app:

Desktop (please complete the following information):

OS: [Windows]
Application Version [Couldn't find it but a very recent version for sure (I installed nightly and this was installed 3 days ago or something)]

Log File
Don't know where it is

wait also the album icons are different I just noticed...

Try and open your settings menu and go to the advanced tab and then scroll down and uncheck useBetaSite then restart. If you want to go to here and try, it’ll probably show a bug with Apples beta site. Using the main site will limit you in terms of features, but should give you the filter.

Wait everything works now. I don't know what happened


Update rustc to nightly-2022-02-01

Update rustc to nightly-2022-02-01.
@vakaras could you take care of this?

bors r+


Apply for Air cash test

Hello, I want to apply for the air coin test.
I used to be the general manager of IT projects. I started to understand the blockchain in 2016 and later became a merchant of other exchanges. I still understand this aspect quite well.
I am very interested in Air Cash, and I hereby apply, hoping to become a member of Air Cash and contribute to Air Cash.

Anyone who applied for the AirCash testing please join the discord channel for test volunteers.
https://discord.gg/eRSY7NtxZA


can't use addon with less project

Im trying to add SASS support to already existing project that uses LESS files (with ember-cli-less). I'm getting below error on build:

File not found: /app/styles/app.scss
in any of the following include paths:
.../tmp/sass_compiler-input_base_path-50K8SQUz.tmp/0
Error: File not found: /app/styles/app.scss
in any of the following include paths:
.../tmp/sass_compiler-input_base_path-50K8SQUz.tmp/0
at Object.findFileSync (.../node_modules/include-path-searcher/index.js:12:9)
at SassCompiler.build (.../node_modules/ember-cli-sass/node_modules/broccoli-sass-source-maps/index.js:62:31)
at .../node_modules/ember-cli-sass/node_modules/broccoli-sass-source-maps/node_modules/broccoli-caching-writer/index.js:152:21
at lib$rsvp$$internal$$tryCatch (.../node_modules/rsvp/dist/rsvp.js:493:16)
at lib$rsvp$$internal$$invokeCallback (.../node_modules/rsvp/dist/rsvp.js:505:17)
at lib$rsvp$$internal$$publish (.../node_modules/rsvp/dist/rsvp.js:476:11)
at lib$rsvp$asap$$flush (.../node_modules/rsvp/dist/rsvp.js:1198:9)
at nextTickCallbackWith0Args (node.js:433:9)
at process._tickCallback (node.js:362:13)
I have just scrubbed the folder paths in above trace with '.../'.

Does it still happen if you remove ember-cli-less from package.json?

If I remove ember-cli-less, it works fine. But I need to keep the plugin as I have LESS files.

That's not the question. See above ^

@stefanpenner any ideas about this?

removing ember-cli-less takes away the error. But the app throws runtime js errors. Im also using ember-cli-bless, and it looks like that addon is failing. I see that -blessed1.css file is missing and browser is throwing a 404 exception there.

Closing due to inactivity, feel free to reopen.