[Preset] New preset to build macOS toolchain without test

@swift-ci build toolchain

Hm. Why without testing?

@swift-ci build toolchain

@jrose-apple This is just to create a new toolchain for evolution proposals. Proposal PR will still require testing, but this way we can split the work on to multiple systems.

macOS Toolchain
Download Toolchain
Git Sha - 28a1224cd737a2ec4126a757e90a33fcb0a4f484

@swift-ci build toolchain

@swift-ci build toolchain

Is this faster than an ordinary test run? If it is, and it supported Linux, then it could be useful when those of us without Linux machines abuse the CI system to find our Linux compile-time errors.

I assume not; an ordinary test run builds fewer things and doesn't try running the tests if the compiler or stdlib build fails.

And in the success case I probably want to continue to the tests anyway. Good point.

@swift-ci build toolchain

macOS Toolchain
Download Toolchain
Git Sha - 28a1224cd737a2ec4126a757e90a33fcb0a4f484
Install command
tar -zxf  swift-PR-12930-5-osx.tar.gz --directory ~/

@shahmishal Cool! On the toolchain download! I think having the ability for swift-ci to provide minimal artifacts (especially in the case of benchmarks) would be awesome!

@swift-ci smoke test and merge


Hold request - Scan request loses "Held" status once the scanning is complete

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.45-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:

Go to staging.new.expensify.com
Create a scan request
Go to request details page
Click 3-dot menu > Hold request
Add a reason and save it
Wait for scanning to complete
When it is complete. go to details page

Expected Result:
The "Held" status of the scan request will be preserved
Actual Result:
The scan request loses "Held" status once the scanning is complete
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/e96caddc-35b6-4701-bd67-3972a58bd636
View all open jobs on GitHub

I am not able to recreate this via Staging. When the scanning was completed, the request is still on Hold, so I don't see this being a bug:

Going to close and if the issue pops up again, we can readdress.

@CortneyOfstad Hello
Issue is still reproducible on the latest build  1.4.46-1
https://github.com/Expensify/App/assets/78819774/8fccbf31-be62-4f10-904b-1c75ad37f154

Per https://github.com/Expensify/App/issues/37536#issuecomment-1977234505 you shouldn't be able to hold a scanning request. So we'll be getting rid of the hold/scan behavior altogether, no need to fix this one


chore: Add likhith4

Hey guys I'm @likhith4  Likhith and I have added my name here and this is my first PR
Related issue

What changes does this PR do?
Screenshots (If any)
Questions

Hello there My name is Likhith and this is my first PR ever thanks for helping me out

Thanks :) 🙌🏻🎉

Why still I can't see my name in the repo ?

Why still I can't see my name in the repo ? in the master repo?

Your branch needs to be merged so that your commit history appears in the main branch of the repository. Once this PR is merged, you'll be among all the contributors to the repository.

OK Thanks


Missing requirement: curl

Hi,
In the list of requirements, the "curl" commandline-tool is missing.
When you try to do the "luarocks install lua-resty-auto-ssl" on a minimalistic container, it fails on that not being available.
Daniël

Thanks for pointing this out. I've added an additional line about the other system dependencies (based on the dependencies letsencrypt.sh notes): https://github.com/GUI/lua-resty-auto-ssl/commit/c717f8343d4bb33a019a477b7b26431e4f7a4ada
There's also this somewhat related issue: https://github.com/GUI/lua-resty-auto-ssl/issues/19 It probably would be good for us to try and detect the dependencies at install or run time so we could provide a better error message. I'll try to get to that sometime this week.

In v0.9.0 there's now some better checking for dependencies during installation and at runtime.


Does it support grounding, OCR, Video hybrid fine-tuning training?

I see a lot of single-task fine-tuning examples here, so can I ask if there is support for hybrid fine-tuning training for grounding, OCR, and Video?

Supported

thank, you!


Fix store init

Besides the @State being in the wrong place, it is designed for value types and will leak heap memory if used for objects (a new object will be init every time the struct containing @State is re-init). Since Store is a class we can take advantage of Swift globals to init an object lazily. This means it won't be init during previews if it was a var inside App. It's made fileprivate to hide it from the rest of the source code.
The alternative is to conform store to ObservableObject and use @StateObject. Or make a singleton and access it from .environment()

Ah, yes, I see the variable is in the wrong place, but are you sure about the rest? My understanding is that with the new Observation, @StateObject has effectively been replaced with @State for observable objects. Otherwise how do you do the equivalent of @StateObject.
It is true if it was some View type, it would indeed be created each time the View appeared on screen, an removed when it left, but I was of the belief that something like an App or ContentView, which "appears" only once is a safe place to create something like a store.

Yes I’m sure.
When Observable first came out @State was changed to have an auto closure init thunk like @StateObject but that must have caused issues for simple @State so they back tracked and removed it. Some of the docs have yet to be undone.  So currently an @Observable still needs to conform to ObservableObject to have a lifetime tied to a View with StateObject. However this is not very common since .task replaces the need for an object at all.

With App the aim is for the object to be init in body and not at App init. So that the object is not init during previews.  You could also use @StateObject but then would need to conform it to ObservableObject or use singleton but I think in this case exploiting the lazy global is nicer.

Gosh, that's awful. There must be so many apps leaking out there then. I have an app using this stuff in the App Store.

State autoclosure removed:
https://mastodon.social/@bernndr/110786893210053444
https://mastodon.social/<EMAIL_ADDRESS>Observable leak:
https://forums.developer.apple.com/forums/thread/743099
https://developer.apple.com/forums/thread/736239
https://developer.apple.com/forums/thread/736110
https://mas.to/@okla/110915814130579266
By the way, I committed the @StateObject version instead of using the lazy feature of Swift global. Because thats how it would be done if a View owned an Observable so might as well be consistent in App.

Now I'm really confused. I read the references (thanks!), but one of them concludes with "Excellent news, the issue has been addressed in the iOS 17.2 beta 1 released yesterday. Thanks to everyone who made this important fix possible."
And the Apple docs themselves suggest to make it optional and use .task to initialize (which is a royal pain the neck in terms of checking for nil in the UI.)
Re: @StateObject, that is mentioned, but is it actually a supported part of the new Observation framework, or is that reverting to the old system?
I would like to use whatever is the most up-to-date recommended approach. If @StateObject is not a reversion, that seems like the best option. If it is, I would prefer the optional with task, if that is what Apple are pushing.
I'm still not fully understanding the issue with using @State in App. I can see that if you put it in a view that comes onscreen, and then leaves (eg a sheet), that you would leak objects. It would make the object, and then not properly release it. But with App, it is created once, right, and the @State would ensure that if the struct is recreated it would copy the reference from the last @State storage, so it shouldn't create a new object. Am I missing something?
Sorry for the questions. I want to understand this, not only for Forked, but also for my other apps.

I've done a bit of testing myself now, and I can't find a case where it recreates the App value more than once in iOS 18. Since the project is targeted at iOS 18 and later, I think it is OK to use @State with an object. There was also that claim in the forums that iOS 17.2 fixed it, so if that is the case, I think we should continue with @State.
Of course, the variable was declared in the wrong place, and I'm now fixed that. Thanks for that fix, and for drawing my attention to the problem. If you think I'm misunderstanding, please let me know.

No worries happy to help you understand.
Sorry for confusing you, I think the "Excellent news, the issue has been addressed in the iOS 17.2 beta 1 released yesterday." isn't regarding the change of State to have an auto-closure to let it init objects once, but it is to do with when @State is using an object, the object is not released when the View owning it is removed.
You are right, the App struct is init once. However there is no need for @State you might aswell just do let store = Store(). But both @State var and let suffer from the same problem. During Previews, the App is init but body is not called. So you actually need the Store object init to be lazy and happen when body is called. This is the functionality that @StateObject provides so you should use that and not @State.

For why @StateObject in the App is a good idea for Previews, see:
WWDC 2020 Structure your app for SwiftUI previews
8:19 For previews models that are initialised with @StateObject are not initialized.


Release 0.4.9

@JuliaRegistrator register branch=release/v0.4

Registration pull request created: JuliaRegistries/General/72389
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.4.9 -m "<description of version>" c834e9d8eceab340149b3c1461cbe7834195d3ca
git push origin v0.4.9


⚠ Bofrost.de has degraded performance

In 41ec315, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1660 ms

Resolved: Bofrost.de performance has improved in 5e42110 after 19 minutes.


Editing slows down in large files when ui is enabled

🐛 Describe the bug
When editing a file that's larger than around 250KiB, making edits in insert and normal mode become slow. The effect is much more dramatic as the file grows towards 500KiB, like the file I noticed this on. This is much more annoying when in insert mode however as the text lags a lot while typing.
Adding ui = { enabled = false } to the settings fixes this, but as far as I'm aware there's no way to set this on a per-file basis.
Ideally the editing speed could be fixed for larger files, but I think even a way to disable ui for certain files, ideally based on a user-defined function, would be a huge improvement over the current behavior.
Here's an example of a large file that causes a bad slow down in edit speed (it's around 450KiB): https://pastebin.com/C4khy3k3
Config
local lazypath = vim.fn.stdpath("data") .. "/lazy/lazy.nvim"
if not vim.loop.fs_stat(lazypath) then
	vim.fn.system({
		"git",
		"clone",
		"--filter=blob:none",
		"https://github.com/folke/lazy.nvim.git",
		"--branch=stable", -- latest stable release
		lazypath,
	})
end
vim.opt.rtp:prepend(lazypath)

require('lazy').setup({
	{
		'epwalsh/obsidian.nvim',
		version = '*',
		dependencies = {
			'nvim-lua/plenary.nvim',
		},
		opts = {
			templates = {
				subdir = 'templates'
			},
			workspaces = {
				{
					name = 'notes',
					path = vim.env.XDG_DOCUMENTS_DIR .. '/obsidian',
				},
			},
			ui = {
				-- Uncommenting this line fixes the problem (at the cost of disabling ui features)
				-- enabled = false,
			},
		},
	},
})

Environment
NVIM v0.10.0
Build type: Release
LuaJIT 2.1.1713773202
Run "nvim -V1 -v" for more info

Obsidian.nvim v3.7.12 (db41b1f20459293436fab510bec58c82a73bd1f7)
Status:
  • buffer directory: nil
  • working directory: /home/addison/documents/obsidian
Workspaces:
  ✓ active workspace: Workspace(name='notes', path='/home/addison/documents/obsidian', root='/home/addison/documents/obsidian')
Dependencies:
  ✓ plenary.nvim: a3e3bc82a3f95c5ed0d7201546d5d2c19b20d683
Integrations:
  ✓ picker: nil
  ✗ completion: disabled
Tools:
  ✓ rg: ripgrep 14.1.0
Environment:
  • operating system: Linux
Config:
  • notes_subdir: nil

Hey @Addisonbean, increasing update_debounce may help, but I agree we need a better solution. I'll see what I can come up with.

Ok #613 adds the option to disable UI features for big files.

Wow, that was a fast turn around. Thanks!!


No longer allows normal login after clicking Facebook login

Clicking Facebook login and then not signing in with it causes the Facebook login page to open up by default next time Spotify xp is opened not allowing for the normal email login. This continues even after u installed and reinstalled

This is what I get after running the debug tool if it helps at all

Address already in use. It looks like SpotifyXP is running in the backround. Can you make sure that its closed using the Taskmanager

I never tested this functionality it isn't even in the stable version of librespot-java. This code is in an untested unstable version. The 403 can mean anything and I can't do anything about it

Can you reproduce this in my virtual machine?

is there anything i can do to reset spotifyxp? ive tried reinstalling but it keeps trying to open in browser

Can you reproduce this in my virtual machine?

yeah, try signing in to spotifyxp and use facebook login instead. then dont sign in to facebook and instead close spotifyxp. then reopen it and try to sign in normally

Can I give you login details and you do it on my virtual machine?

Can I give you login details and you do it on my virtual machine?

how would i do that for you? isnt it on your pc?

You can connect remotely into it via realvnc

alright, sure. should i send any files such as my vlc version and java version

Yeah sure

I am setting up the vm right now

https://www.filepuma.com/download/java_development_kit_64bit_8.0.1510.12-16904/
this was the specific java download i used. its an offline download as the online ones werent working

Unfortunately I only have time later because I have silvester dinner with my family

alright, thats fine

Please contact me per discord: werwolf2303

I have decided to remove this functionality due to it not being in the stable branch of librespot-java and not working correctly


Numbers are not supported: +917983045283, +918208621967

Following numbers are valid Indian numbers
7983045283
8208621967
Please add them.

@ashwinrkjain ,
Thanks for reporting this issue.
We already support<PHONE_NUMBER> as valid mobile number in India.
https://libphonenumber.appspot.com/phonenumberparser?number=8208621967&country=IN
Yes, we are not supporting<PHONE_NUMBER> as valid number. We've accepted this issue and will fix this in an upcoming release.
Please note that you have submitted this information with the knowledge that we
may use, modify, reproduce, publicly display, and distribute the information in
accordance with our open source policies. Please let us know if you did not
intend to submit the information for such use.
We were not able to find carrier details for this range.
Please share any supporting evidence (for example, a national numbering plan,
announcements from mobile carriers, news articles) so that we can update the
carrier details as well.

Fixed in release 8.3.0.


Fixes & enhancments to SplitContainer

Made titles work
Refactored to use Visible for collapse
Refactored to enable future where > 2 panels are possible
Fixed a bunch of little bugs

I have no idea why this has so many changes in it. I gotta run, but will try to fix later.

I have no idea why this has so many changes in it. I gotta run, but will try to fix later.

No worries, it was because the PR was targetting main.  I've redirected it to tznind:splitcontainer which is the branch I am working from.
Changes look awesome thanks!


VPC does not require a subnet to be specified

As mentioned in #344, AWS accounts created after 2013-12-04 don't support "EC2 Classic" and just use VPC. These accounts have a default subnet created so you don't have to specify one. We should

find a different way to determine we are on VPC for #vpc_mode?
ensure we raise an reasonable error (ourselves if the API doesn't) if VPC is the only supported platform, there is no default subnet, and the user has not passed a subnet.
if vpc_mode? is true, we have a default subnet, but the user has not passed a subnet_id, populate subnet_id (so the solution in #344 can tell if auto-assign-ip is enable for that subnet).

Hello @btm ,
This is very nice idea to use default vpc and subnet and find out auto-assing-ip intelligently for bootstrapping.
We have below findings in-terms of use cases. Please have look and share your thoughts -
1 . If account only supports EC2-VPC platform then existing knife-ec2 creates VM's in default VPC and Subnet.
2 . Consider if account supports both platform i.e EC2-VPC and EC2-CLASSIC.
For this case we should have flag like --select-aws-platform vpc(i.e default)  or classic it will give choice to user to select platform.
2.1 --select-aws-platform VPC
a. For this case by default VM will gets created in default VPC and Subnet. Validate does account supports VPC platform? and find default VPC id and Subnet id to create VM.
b. if --subnet-id specified then we will find corresponding VPC id and create VM in same.
Note- By default, for both cases check auto-assign-public-ip is enabled.
c. If default VPC is deleted and no --subnet-id specified. In this case raise an error.
2.2 --select-aws-platform classic
The VM will gets created in AWS Classic network.
Could you please comment on this.
Thank You.

@btm , please let us know your views on this.

@NimishaS I suppose over time the number of people who still have classic accounts will decrease and new people will just have vpc with a default subnet and be less confused, but I'm a little surprised more people don't need a --aws-platform flag.

@btm,
If the account supports only EC2-VPC platform then existing knife-ec2 creates VMs by using default VPC and Subnet.
We don't have EC2 classic account so we can't create the node on EC2 classic.
Can you please explain what needs to be fixed in this issue?

2013-12-04 was a long time ago. Let's figure that everyone who has support for EC2 classic has figured this out, and everyone else will already have a default subnet with their VPC based EC2 account.


Add fchown

the travis build has a spurious build error.

:pushpin: Commit e6864db has been approved by alexcrichton

@bors: r+

:hourglass: Testing commit e6864db with merge c6a68f1...

:sunny: Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing c6a68f18cbd7cdbf205a3923f93e19624cb79dde to master...


⚠ Samsung has degraded performance

In b9f8387, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2283 ms

Resolved: Samsung performance has improved in 0155185.


Manage passwords: Create, Read, Update, Delete

Inspiration

https://github.com/bndw/pick

closing this as chrome has become really good at managing and remembering my passwords, also across my multiple devices.


iOS - Any example is closed immediately after the install

Describe the bug
Hello, I tried something simple with all the templates:
mkdir my_dor
cargo mobile init
cargo apple run

This succeded but then, after the installation and the launch, the app is closed without rendering:
[100%] Installed package /Users/nazariglez/personal/mobile_test4/gen/apple/build/Payload/mobile-test4.app
------ Debug phase ------
Starting debug of 2600fae624d1da23d210fd58bf51efbf247c4614 (J98aAP, iPad Pro (12.9"), iphoneos, arm64, 16.4.1, 20E252) a.k.a. 'Nazarí’s iPad' connected through USB...
[  0%] Looking up developer disk image
[ 95%] Developer disk image mounted successfully
Symbol Path: /Users/nazariglez/Library/Developer/Xcode/iOS DeviceSupport/16.4.1 (20E252)/Symbols
[100%] Connecting to remote debug server
-------------------------
(lldb) command source -s 0 '/tmp/6E31D58B-1EDD-4BF2-95AF-D0469ECDC04F/fruitstrap-lldb-prep-cmds-2600fae624d1da23d210fd58bf51efbf247c4614'
Executing commands in '/tmp/6E31D58B-1EDD-4BF2-95AF-D0469ECDC04F/fruitstrap-lldb-prep-cmds-2600fae624d1da23d210fd58bf51efbf247c4614'.
(lldb)     platform select remote-'ios' --sysroot '/Users/nazariglez/Library/Developer/Xcode/iOS DeviceSupport/16.4.1 (20E252)/Symbols'
  Platform: remote-ios
 Connected: no
   Sysroot: /Users/nazariglez/Library/Developer/Xcode/iOS DeviceSupport/16.4.1 (20E252)/Symbols
  SDK Path: "/Users/nazariglez/Library/Developer/Xcode/iOS DeviceSupport/16.4.1 (20E252)/Symbols"
(lldb)     target create "/Users/nazariglez/personal/mobile_test4/gen/apple/build/Payload/mobile-test4.app"
Current executable set to '/Users/nazariglez/personal/mobile_test4/gen/apple/build/Payload/mobile-test4.app' (arm64).
(lldb)     script fruitstrap_device_app="/private/var/containers/Bundle/Application/84D35CB8-6BB1-4DC2-93A9-CC7DABD27ECC/mobile-test4.app"
(lldb)     script fruitstrap_connect_url="connect://<IP_ADDRESS>:50734"
(lldb)     script fruitstrap_output_path=""
(lldb)     script fruitstrap_error_path=""
(lldb)     target modules search-paths add /usr "/Users/nazariglez/Library/Developer/Xcode/iOS DeviceSupport/16.4.1 (20E252)/Symbols/usr" /System "/Users/nazariglez/Library/Developer/Xcode/iOS DeviceSupport/16.4.1 (20E252)/Symbols/System" "/private/var/containers/Bundle/Application/84D35CB8-6BB1-4DC2-93A9-CC7DABD27ECC" "/Users/nazariglez/personal/mobile_test4/gen/apple/build/Payload" "/var/containers/Bundle/Application/84D35CB8-6BB1-4DC2-93A9-CC7DABD27ECC" "/Users/nazariglez/personal/mobile_test4/gen/apple/build/Payload" /Developer "/Users/nazariglez/Library/Developer/Xcode/iOS DeviceSupport/16.4.1 (20E252)/Symbols/Developer"
(lldb)     command script import "/tmp/6E31D58B-1EDD-4BF2-95AF-D0469ECDC04F/fruitstrap_2600fae624d1da23d210fd58bf51efbf247c4614.py"
(lldb)     command script add -f fruitstrap_2600fae624d1da23d210fd58bf51efbf247c4614.connect_command connect
(lldb)     command script add -s asynchronous -f fruitstrap_2600fae624d1da23d210fd58bf51efbf247c4614.run_command run
(lldb)     command script add -s asynchronous -f fruitstrap_2600fae624d1da23d210fd58bf51efbf247c4614.autoexit_command autoexit
(lldb)     command script add -s asynchronous -f fruitstrap_2600fae624d1da23d210fd58bf51efbf247c4614.safequit_command safequit
(lldb)     connect
(lldb)     run
success
(lldb)     safequit
Process 1432 detached
[connected]

If I try to do cargo apple open and try to build from there, then Command PhaseScriptExecution failed with a nonzero exit code.
Platform and Versions (please complete the following information):
Host OS: MacOS Ventura 13.3.1 (a)
Target OS: iOS 16.4.1
Rustc: rustc 1.71.0 (8ede3aae2 2023-07-12)
cargo mobile doctor:
[✔] cargo-mobile v0.5.1
    • Contains commits up to "fix(linux): fix command detection (#174)\n"
    • Installed at "~/.cargo/.tauri-mobile"
    • macOS v13.3.1 (a) (22E772610a)
    • rustc v1.71.0 (8ede3aae2 2023-7-12)

[✔] Apple developer tools
    • Xcode v14.3
    • Active developer dir: "/Applications/Xcode.app/Contents/Developer"
    • ios-deploy v1.12.2
    • XcodeGen v2.35.0
    • xcode-rust-plugin plugin present
    ✗ xcode-rust-plugin lang spec absent
    ✗ xcode-rust-plugin lang metadata absent
    • xcode-rust-plugin is up-to-date
    ✗ xcode-rust-plugin doesn't support Xcode UUID "EA3EACC9-A0BE-423D-9BA3-AA8B9FE68E38"
    • Development team: Hopscotch Technologies (839GE64MX3)
    • Development team: NAZARI GONZALEZ (DJQBHZ4AR9)
[2023-07-19T16:54:39Z WARN  tauri_mobile::android::env] `ANDROID_HOME` isn't set; falling back to `ANDROID_SDK_ROOT`, which is deprecated

[✔] Android developer tools
    • SDK v26.1.1 installed at "~/Library/Android/sdk"
    • NDK v22.1.7171670 installed at "~/Library/Android/sdk/ndk-bundle"
[2023-07-19T16:54:40Z WARN  tauri_mobile::android::env] `ANDROID_HOME` isn't set; falling back to `ANDROID_SDK_ROOT`, which is deprecated

[✔] Connected devices
    • Nazarí’s iPad (iPad Pro (12.9"))

Any hint on how to resolve it? I am sure that it must be something silly.
Would you want to assign yourself to resolve this bug?

[ ] Yes
[ ] No

Hi I was having similar issues so I've made a template / example for tauri mobile with Apple ecosystem. You can check it out here https://github.com/Adimac93/tauri-mobile-apple-ecosystem currently it's using Svelte for simplicity.


refactor: grouped files based on language and added corresponding links to README.md

Changes
Sorted the files into respective folders based on their language and updated README.md to contain a list of all files under each folder in order to give a sort of snapshot into the contents of the folder.
Closes : #5

Links in readme.md are taking to your forked repository  @Ansh-Sarkar

Aah ok. My apologies. Will fix that.

I'll just open another PR for fixing the links. Sorry for the issue.

Ok , Go ahead @Ansh-Sarkar


Enable views to move between containers (Part 2)

This is a continuation of the work from #85164.
Debt

[x] ViewDescriptorService tests #89686
[x] Remove sync openPanel in favor of async #89723
[ ] Fix issue with panel naming before opening #88637
[x] Have all panels using the new infrastructure #90252 #89993 50bc5d71aa4f5ea728ace3daaa4574f12fcc4d9a
[ ] Make sure views are not using panel or viewlet semantics (IPanelService, IViewletService)
#90020
[x] Introduce attachStyler in ViewPane so that implementing views can simply attach tree or list using it. No longer necessary

Features

[x] Ensure all core views can be moved without issue

[x] Explorer

[x] Open Editors a28e0a93b170ead69645a3d64f00e7d3a06af2d0
[x] ~File Explorer~
[x] Timeline d05b78490f04d66d05a856f57169f724d7679049

[x] Source Control #90461
[x] Search
[x] Run and Debug #90468
[x] Extensions (will not be enabled)
[x] References view?
[x] Remote

[ ] Invert canMove property to allow exclusion of extensions viewlet views
[x] Drag and drop support between existing containers
[x] Drag and drop support into new containers

Future (Not targeted for February)

[ ] Generate icons for panel views/containers to enable new containers in sidebar from panel views
[ ] Enable multiple views in panels

migrated comments panel with 50bc5d71aa4f5ea728ace3daaa4574f12fcc4d9a

Updated description

added all default views contributed to explorer in order to make sure we do not miss any. We have new timeline view and I think this can be made movable.

Added debt item to remove deps on panel and viewlet semantics

Added debt item to introduce attachStyler

I have updated the OpenEditorsView, it was pretty straightforward.
The only remaining "reference" to viewlets in these views is a mention of IViewletViewOptions. We should probably try to get rid of them.

Timeline is done

Will it let me drag the tree view to the left side while activity bar and all the other panels/views on the left? Just like in Atom where you can move views to any side container.

Clsoing this issue since I believe @sbatten has done what was on the plan for this milestone
@sbatten feel free to reopen or to create follow up issues.
@terrysahaidak this is not possible currently in vscode, though we do want to have that in the future

@sbatten just want say thank you so much sbatten, i just tested and this was awesome feature and will help a lot my workflow.
Your awesome !


Could you publicize functions of "getCellStyle"?

It is really useful when developers want to set the style of a new cell as same as an existent cell (format painter).

I join the request. In our project, too, there is such a need. We need this for integration with a similar xlsx js library.

I plan to reflect the style method by adding a new function NewStyle() to get style ID, and pass this ID to function SetCellStyle(). I will export this function after completion.

Thank you! It will be useful.

The function GetCellStyle() has been exported (the function name typo in commit log).


Add docker configuration details to README

@elezar I can't merge this PR for some reason. Can you help with this?

@elezar I can't merge this PR for some reason. Can you help with this?

@bart0sh you're not officially a member of the org. I'm not sure who you need to reach out to to get yourself added. Do you have some pending invites in GitHub somewhere?


support setting service buffer size

What type of PR is this?

What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

/auto-cc


dark mode

the current web interface is a little too calm and bright. obviously we need dark mode css.
can we add a dark mode for the command line tool too?

Everyone knows the equivalent of dark mode on the command line is ansi
colors.
On Fri, Apr 10, 2020 at 10:54 AM salmān aljammāz<EMAIL_ADDRESS>wrote:

the current web interface is a little too calm and bright. obviously we
need dark mode css.
can we add a dark mode for the command line tool too?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/saljam/cpace-machine/issues/15, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABDJJ4QBF4M52LVAXEUKDKLRL5MO7ANCNFSM4MFTB4JQ
.

Recently, I coded the Dark Mode in CSS and basic Java Script.
In my version of the dark mode switch one can set multiple color themes in one CSS file and call or remember them with a short JS function.
Try it on the GitHub demo page :
https://dorson.github.io/CSS-Dark-Mode-and-color-switch/
Feel free to fork, copy, adopt, etc..
Have fun ! :+1:


Clarify "If you want to enable secure feature" on README

There's a line I think should be clarified on the README - "If you want to enable secure feature, Go (>=1.7) is required". Not much else is said about this and no link to an outside resource is provided, so there's really no knowing what is meant by this other than it implies that the crate is inherently insecure unless this feature is enabled.

Sent a PR as #190, feel free to add comments if there is still anything unclear.

Looks great, thank you.


I just updated the example to Swift 4.2

Currently not able to push to a new branch because of some creds issue.
How would any of you like me to get these changes up and into Master?
Thanks.

git push --set-upstream origin Swift-4.2
remote: Permission to tapwork/HeapInspector-for-iOS.git denied to azav.
fatal: unable to access 'https://github.com/tapwork/HeapInspector-for-iOS.git/': The requested URL returned error: 403
Buildasaurus:HeapInspector-for-iOS zav$


Breadcrumbs misinterpret git conflict marker in XML files

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version: 1.72.2
OS Version: Windows 10.0.19042

Steps to Reproduce:

Edit XML file with a conflict
git merge
Git will add <<<<<<< HEAD conflict marker
Put cursor inside the conflict region
VSCode breadcrumbs will think each < is an opening XML tag with no name

Also affects sticky scroll:

Which extension are you using to populate the breadcrumb and the outline view? If unsure please use the Start Extension Bisect command.

This issue is caused by an extension, please file it with the repository (or contact) the extension has linked in its overview in VS Code or the marketplace for VS Code. See also our issue reporting guidelines. If you don't know which extension is causing the problem, you can run Help: Start extension bisect from the command palette (F1) to help identify the problem extension.
Happy Coding!


az postgres allow access to azure services

I want "Allow Access To Azure Services"  to be turned on for a postgres database.
There is no direct option for this in the CLI, but I found out that this can be done by adding a firewall rule with a specific name and ip-address:
az postgres server firewall-rule create -g $(RESOURCEGROUP_DATA_NAME) -s $(DATABASESERVER_NAME) -n "AllowAllWindowsAzureIps" --start-ip-address "<IP_ADDRESS>" --end-ip-address "<IP_ADDRESS>"
The button in the portal is turned on now. This looks great, but onfortunately it is not working.
After disabling it in the portal and enable it again to make it really working for other services to have access to the database.

@tjprescott if you ask me. It is really a bug. But I can't determine if the Azure CLI contains the bug. All I know is when I use the Azure CLI to turn on Allow Access To Azure Serices, it is not working.
The UI of the portal shows it is turned on. But it isn't.

Hi @pascalnaber the "Question" label is often used by us to flag a new issue. The service team will need to investigate this and determine how they want to classify it as they maintain these commands.

I can confirm that the functionality works when executing an ARM template. So the CLI is not working correct. ARM is doing it correct.
{
    "$schema": "https://schema.management.azure.com/schemas/2015-01-01/deploymentTemplate.json#",
    "contentVersion": "<IP_ADDRESS>",
    "parameters": {
        "databaseServerName": {
            "type": "string",
            "metadata": {
                "description": "Name of database server"
            }
        }
    },
    "variables": {
        "databaseServerName": "[parameters('databaseServerName')]"
    },
    "resources": [
        {
            "type": "Microsoft.DBforPostgreSQL/servers/firewallrules",
            "name": "[concat(variables('databaseServerName'), '/AllowAllWindowsAzureIps')]",
            "apiVersion": "2017-12-01",
            "properties": {
                "startIpAddress": "<IP_ADDRESS>",
                "endIpAddress": "<IP_ADDRESS>"
            }
        }
    ]
}

@tjprescott, @pascalnaber
For us we have seen the issue with ARM template deployment triggered via CLI as well.
here is the used template: https://commontemplates.blob.core.windows.net/postgres/2.2/azuredeploy.json

This has been resolved in the latest release.
@tjprescott please close.

Can confirm this worked for me with az cli 2.18.0 e.g.
az postgres server firewall-rule create --resource-group RG --server-name SN --name "AllowAllLinuxAzureIps" --start-ip-address "<IP_ADDRESS>" --end-ip-address "<IP_ADDRESS>"


Clicking "Enable the Google Sheets API" Fails

When clicking the "Enable the Google Sheets API" button on the Sheets Quickstart page I am presented with a dropdown to either select one of my existing projects or create a new project.  Regardless of whether I choose an existing project or create a new project, when "Next" is clicked an error is displayed.
Sample Name
Google Sheets Quickstart
Expected Behavior
I'm unsure, but I don't expect an error to be displayed.
Actual Behavior
An error is displayed.  Usually "Something went wrong. Please try again.", but sometimes the message is blank.  Regardless of the error message a request is made right before the error to https://people-pa.clients6.google.com/v2/people that is returning
{
  "personResponse": [
    {
      "personId": "me",
      "status": "NOT_FOUND",
      "responseStatus": {
        "code": 5
      }
    }
  ]
}

Specifications

Java version: java version "1.8.0_172"

I'm not able to replicate this behavior, perhaps it was a temporary outage? If you are still getting this error please let us know.

Must have been a temporary outage.  I am now able to complete the quickstart without error.  Thank you.

This is happening for me now for the past hour. Exact same symptoms as the OP. Considering this last happened 12 days ago, it seems there is something intermittently wrong with this functionality.

Thanks for the follow up. Are you still seeing this behavior today?


Unable to load nodobjc code

Kudos on the awesome project. It is great to be able to use all the advanced technologies like React, Redux, WebPack, etc. without having to spend hours wiring everything up.
Unfortunately, I've been having difficulty getting the nodobjc library for bridging Objective C code in an Electron app to work. The same code works fine in the electron-quick-start app, which makes me think perhaps something about webpack is screwing things up.
Here's the code I've been testing with
const $ = require('nodobjc');
const pool = $.NSAutoreleasePool('alloc')('init');
const string = $.NSString('stringWithUTF8String', 'GoChip');
console.log("String is " + string);
pool('drain');

When I start the app I get a Uncaught TypeError: Path must be a string. Received undefined in path.js in the Chrome debugger as it attempts to require the library.
Any idea what I can do to fix this?

What is the stack trace for this?

Here you go:
nodobjc-chrome-trace.txt

A screenshot would be better

Of the trace in the Chrome debugger?

Yea

I've experienced this issue before:
https://github.com/jaruba/wcjs-player/issues/65

Thanks for the suggestion.
I went ahead and added the nodobjc module to the webpack externals and am no longer getting the error. However, my module versions don't match so I was attempting to do a node-rebuild. When I npm install I now get the following error:
><EMAIL_ADDRESS>install /Users/maxwell/gochip/electron-react-boilerplate/node_modules/fsevents
> node-pre-gyp install --fallback-to-build

Warning: node-pre-gyp could not find exact match for 1.2.8
Warning: but node-pre-gyp successfully choose 1.0.4 as ABI compatible target
node-pre-gyp ERR! Tried to download: https://fsevents-binaries.s3-us-west-2.amazonaws.com/v1.0.14/fse-v1.0.14-node-v42-darwin-x64.tar.gz
node-pre-gyp ERR! Pre-built binaries not found for<EMAIL_ADDRESS>and<EMAIL_ADDRESS>(node-v42 ABI) (falling back to source compile with node-gyp)
Warning: node-pre-gyp could not find exact match for 1.2.8
Warning: but node-pre-gyp successfully choose 1.0.4 as ABI compatible target
gyp WARN install got an error, rolling back install
gyp ERR! configure error
gyp ERR! stack Error: 404 response downloading https://iojs.org/download/release/v1.2.8/iojs-v1.2.8.tar.gz
gyp ERR! stack     at Request.<anonymous> (/Users/maxwell/gochip/electron-react-boilerplate/node_modules/npm/node_modules/node-gyp/lib/install.js:210:14)
gyp ERR! stack     at emitOne (events.js:101:20)
gyp ERR! stack     at Request.emit (events.js:188:7)
gyp ERR! stack     at Request.onRequestResponse (/Users/maxwell/gochip/electron-react-boilerplate/node_modules/npm/node_modules/request/request.js:977:10)
gyp ERR! stack     at emitOne (events.js:96:13)
gyp ERR! stack     at ClientRequest.emit (events.js:188:7)
gyp ERR! stack     at HTTPParser.parserOnIncomingClient (_http_client.js:472:21)
gyp ERR! stack     at HTTPParser.parserOnHeadersComplete (_http_common.js:105:23)
gyp ERR! stack     at TLSSocket.socketOnData (_http_client.js:361:20)
gyp ERR! stack     at emitOne (events.js:96:13)
gyp ERR! System Darwin 15.6.0
gyp ERR! command "/usr/local/Cellar/node/6.3.1/bin/node" "/Users/maxwell/gochip/electron-react-boilerplate/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "configure" "--fallback-to-build" "--module=/Users/maxwell/gochip/electron-react-boilerplate/node_modules/fsevents/lib/binding/Release/node-v42-darwin-x64/fse.node" "--module_name=fse" "--module_path=/Users/maxwell/gochip/electron-react-boilerplate/node_modules/fsevents/lib/binding/Release/node-v42-darwin-x64"

I don't think I was seeing this previously.

Try this:
rm -rf node_modules
npm cache clean
npm i
npm rb

It turns out I had an environmental variable set for node-gyp that I had set while troubleshooting. Everything is working now :) Thanks for the help.

No problem? Can this issue be closed?

Yes go ahead and close it. It might be worth adding some examples of modules that have to be excluded from webpack to the README. I had no idea that this was one of them.


Setup: SSL detection does not work

The following line was missing in setup/index.php
originHeaders(); // This is important so that http://.../setup/ can query https://.../setup/ in order to do an SSL availability check

Fixed in version <IP_ADDRESS>


[AMORO-2637] Enable return back to origin uri when relogin

Why are the changes needed?

Close #2637 .
Brief change log

How was this patch tested?

[ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[ ] Run test locally before making a pull request

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 50.95%. Comparing base (882b78b) to head (2fc66cf).

Additional details and impacted files
@@              Coverage Diff              @@
##             master    #2645       +/-   ##
=============================================
+ Coverage     34.02%   50.95%   +16.93%
+ Complexity     4364      590     -3774
=============================================
  Files           604       46      -558
  Lines         50754     4708    -46046
  Branches       6673      513     -6160
=============================================
- Hits          17269     2399    -14870
+ Misses        32086     2084    -30002
+ Partials       1399      225     -1174

Flag
Coverage Δ

core
?

trino
50.95% <ø> (+0.02%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

@minteliuwm PTAL

If the dashboard module's codes are modified, please recompile the project frontend

Now the front end can automatically submit the built files through the Maven plugin.


Allow merging line with no tags with multipolygons

Description
While #8675 in v2.20.2 helps prevent relations from being damaged, it has made it more difficult for me to clean up multipolygon areas sharing the same sides, such as here:

Is it possible to enable the merge operation when merging a line with one that doesn't have any tags or affiliated with any relations, like shown below?

As you can see in the image above, I removed the residential area relation from the way selected in the other image and am trying to merge another way in that same residential area with a line I created parallel to the one selected in the other image that has no tags or memberships in any relations.

Is it possible to enable the merge operation when merging a line with one that doesn't have any tags or affiliated with any relations, like shown below?

That would involve making an exception here, which would be straightforward:
https://github.com/openstreetmap/iD/blob/1457759994c91b2a65922d6bfa478504355e65be/modules/actions/join.js#L145-L147
However, note that #8645 was fixed specifically by disallowing merging with a nonmember way, which can inadvertently introduce a branch in a route relation or a degenerate multipolygon or boundary. Ideally, iD would distinguish the case where the relation was already broken and needs fixing, which may be feasible with some types of relations but more difficult with others (like boundaries: #8286).
As a workaround, you can manually add the nonmember way to the relation.

(Error is 'These features can't be merged because they belong to conflicting relations' for searchability)

I guess this should be the same, I tried to merge a line with a waterway and shows me this message, depite the line have No tags or other values

Absolutely and totally NNnd this request, severely slowed down the complex mapping I'm doing. Map a line to enlarge an area and first the tag(s) need adding and 9 out of 10 if more than 1 area relation is involved the merge is rejected, then having to remove all but one, merge the line and add the relation tags back. If a tagless line is merged with a tagged line you're 100% sure the correct areas/tags are proliferated, Picture having multiple zones in the area of the same... farmland e.g. Before you know it you pick the wrong one. Goes for areas and highways. Oddly, a single closed tagless line can be merged with any area relation, by shift selecting an existing area, right clicking and hitting the plus sign, Anyway, 2.20.2 sped up work, then took 2 steps back, for me, with removing the select-lines merge feature.


Splash screen update

Now we support Android 12 splash screens

@M123-dev Please remind me: is there a good reason why we switch to Android 12 (aka 31)? In my apps a user reported me another bug due to Android 12.

@monsieurtanuki when we added permission_handler for asking for camera permission I checked if we fully switched to AndroidX and then upgraded to target version to 31, but android 11 will be probably fine as well. Is android 12 really that buggy

@M123-dev If the package needs it and if we need the package, that's solved: go for 31.
But so far 31 is the first Android version upgrade that brought trouble in my Android/java apps, like crash at init time. I started around 21 - that means 9 harmless Android version upgrades before 31.
It's not really bugs, it's about evolutions like: "if this flag is not set, from 31 we crash", or "the Toasts size is less than 16 characters from now on" (instead of possibly several lines).

@monsieurtanuki, I am going to try to downgrade the target to 30 for https://github.com/openfoodfacts/smooth-app/issues/1038

AFAICR the country selector library only worked with Android 31 ... (I
think)
On Mon, Jan 31, 2022, 18:46 Marvin M @.***> wrote:

@monsieurtanuki https://github.com/monsieurtanuki, I am going to try to
downgrade the target to 30 for #1038
https://github.com/openfoodfacts/smooth-app/issues/1038
—
Reply to this email directly, view it on GitHub
https://github.com/openfoodfacts/smooth-app/pull/1053#issuecomment-1026042894,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABZRHYQNYYBSE7WV6GGDIK3UY3DH3ANCNFSM5NG2X6UQ
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

AFAICR the country selector library only worked with Android 31 ... (I think)
…

@jasmeet0817 https://pub.dev/packages/iso_countries: "Android: API level 21 required"


chore: clean up "was simp" porting notes

Go through all the files with porting notes along the lines of "was simp", "was simp_rw", "used to be simp" and try to:

Restore original, if possible;
Use another cleaner way to solve the issue;
Delete the note if it's not worth going back to the old version;
Renumber the note if it's a more applicable issue (#11119 in particular);
Or not touch the note if it's still relevant.

(I trust you, and did not verify, that you really caught all such notes.)

bors r+


Create davinciagherbino.txt

Create davinciagherbino

@claudiofus Thank you for your patience while waiting for a review and processing your request. Pull request merged.


Error on launch

Running last cell results in this error. Who knows what can be the issue, send help:
Traceback (most recent call last):
File "/content/gdrive/MyDrive/sd/stable-diffusion-webui/webui.py", line 413, in
webui()
File "/content/gdrive/MyDrive/sd/stable-diffusion-webui/webui.py", line 302, in webui
shared.demo = modules.ui.create_ui();shared.demo.queue(concurrency_count=999999,status_update_rate=0.1)
File "/content/gdrive/MyDrive/sd/stable-diffusion-webui/modules/ui.py", line 463, in create_ui
with gr.Blocks(analytics_enabled=False) as txt2img_interface:
File "/usr/local/lib/python3.10/dist-packages/gradio/blocks.py", line 486, in init
super().init(render=False, **kwargs)
File "/content/gdrive/MyDrive/sd/stable-diffusion-webui/modules/scripts.py", line 561, in BlockContext_init
add_classes_to_gradio_component(self)
File "/content/gdrive/MyDrive/sd/stable-diffusion-webui/modules/scripts.py", line 529, in add_classes_to_gradio_component
comp.elem_classes = ["gradio-" + comp.get_block_name(), *(comp.elem_classes or [])]
AttributeError: 'Blocks' object has no attribute 'elem_classes'

try running the notebook without the first cell and let me know how it goes

you used this link https://colab.research.google.com/github/TheLastBen/fast-stable-diffusion/blob/main/fast_stable_diffusion_AUTOMATIC1111.ipynb ?

yep, the last one

same thing for me

exactly the same error for me to

same error here

try running the notebook without the first cell and let me know how it goes

Same problem

not sure what changed, working on it

works now

same problem here. going to recheck

i turned Use_Latest_Working_Commit to positive, and everything worked

seems like that did it for now!

yep. working now.

fixed

Everything working now. Thank you!


Inconsistencies/Confusion with API Connectors Documentation

The information about the "before sending the token" API connector in the Modify sign up experiences article is inconsistent with the information in the Enrich tokens with external claims article.
From what I can tell, both articles are talking about the same "before sending the token" API connector, but the 2nd article dedicated to "enriching tokens with external claims" contains an example request that seems more complete.
Example from first article:
POST <API-endpoint>
Content-type: application/json

{
 "clientId": "231c70e8-8424-48ac-9b5d-5623b9e4ccf3",
 "step": "PreTokenApplicationClaims",
 "ui_locales":"en-US"
 "email"<EMAIL_ADDRESS> "identities": [
     {
     "signInType":"federated",
     "issuer":"facebook.com",
     "issuerAssignedId":"0123456789"
     }
 ],
 "displayName": "John Smith",
 "extension_<extensions-app-id>_CustomAttribute1": "custom attribute value",
 "extension_<extensions-app-id>_CustomAttribute2": "custom attribute value",
}

vs
Example from second article:
POST <API-endpoint>
Content-type: application/json

{
 "email"<EMAIL_ADDRESS> "identities": [
     {
     "signInType":"federated",
     "issuer":"facebook.com",
     "issuerAssignedId":"0123456789"
     }
 ],
 "displayName": "John Smith",
 "objectId": "ab3ec3b2-a435-45e4-b93a-56a005e88bb7",
 "extension_<extensions-app-id>_CustomAttribute1": "custom attribute value",
 "extension_<extensions-app-id>_CustomAttribute2": "custom attribute value",
 "client_id": "231c70e8-8424-48ac-9b5d-5623b9e4ccf3",
 "step": "PreTokenIssuance",
 "ui_locales":"en-US"
}

The example request in the 2nd article contains properties like objectId, while the example in the 1st article does not. If both of these articles are indeed talking about the same API connector, then the documentation and example requests in one or both of the articles may need to be updated.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8e32e9a4-3b2f-dafb-605e-d87350a7d58d
Version Independent ID: 872b2c4c-7762-4ef8-29c5-29011da165a2
Content: Add API connectors to sign up user flows
Content Source: articles/active-directory-b2c/add-api-connector.md
Service: active-directory
Sub-service: b2c
GitHub Login: @kengaderdus
Microsoft Alias: kengaderdus

@br-tyler-milner
Thanks for your feedback! I've assigned this issue to the author who will investigate and update as appropriate.


Not obvious correlation between field name exporting and corresponding parameter visibility in API

Describe the bug
If you move example album handling stuff from https://dev.to/vearutop/tutorial-developing-a-restful-api-with-go-json-schema-validation-and-openapi-docs-2490 to separate package say mypackage and then (after exporting function names with capital letter) try to register  interactors from main package with
	service.Get("/albums", mypackage.GetAlbums())
	service.Get("/albums/{id}", mypackage.GetAlbumByID())
	service.Post("/albums", mypackage.PostAlbums(), nethttp.SuccessStatus(http.StatusCreated))

everything works ok. But if you decide to change getAlbumByIDInput.ID to unexported getAlbumByIDInput.id than you'll get panic on app start saying
panic: failed to reflect API schema for GET /albums/{id}: undefined path parameter: id

If you restore getAlbumByIDInput.ID and add another query param say
	type getAlbumByIDInput struct {
		ID string `path:"id"`
		important string `query:"important"`
	}

no panics/warnings/errors will be thrown on start and important param won't be visible in OpenAPI nor defined in interactor even if present in request url.
If it's expected - consider adding info in manual about correlation between field name exporting and corresponding parameter visibility in API.

This library is in the same boat with encoding/json, encoding/gob and many others, that use reflect to provide generalized implementations for user-defined types. Go allows visibility of unexported names (struct fields included) only in their own package, reflect honors that and can not read or write to unexported fields from an external package (unless unsafe tricks are applied).
There is a panic for path field because there is a condition that can be checked, if url pattern declares variable path segment, there must be a request parameter for it in structure. Query parameters are not enumerated in url pattern, so there is no way to tell if important query param is missing in request structure.
Having unexported fields in request/reponse structure is a legit situation, those fields can be an implementation detail of user code. Not having any exported fields is also ok, this may indicate request that has no parameters.
I'm not sure there is a need for specific documentation of unexported fields handling, given their lack of visibility is inherited from the Go language itself.
🤖 Bonus explanation from ChatGPT 🤖

hello, why can not I marshal unexported field with JSON in Go?

In Go, fields that are unexported (i.e., that begin with a lowercase letter) are not accessible from outside the package in which they are defined. This means that the JSON package, which is in a different package, cannot access unexported fields when marshalling or unmarshalling data. To make a field exported, you need to capitalize the first letter of the field name.

can a 3rd-party library access an unexported field of my Go program?

No, a 3rd-party library cannot access unexported fields of your Go program because unexported fields are not accessible from outside the package in which they are defined. This is a key feature of Go's encapsulation mechanism and it ensures that the internal state of your program is hidden from other packages.
If you want a 3rd-party library to have access to a field, you need to make the field exported by capitalizing the first letter of the field name. Additionally, you can use the tag feature of Go struct fields to specify a different name for the field when it is marshaled to JSON and other formats.

Thank you for answer and great lib!

This library is in the same boat with encoding/json, encoding/gob and many others, that use reflect to provide generalized implementations for user-defined types.

Studying manuals of all dependencies should probably be not required for github.com/swaggest/rest users to use it.

Go allows visibility of unexported names (struct fields included) only in their own package

User will notice if try to use unexported name  in other package (compilation error, IDE warning, etc.); example from this issue mentions not obvious situation (delegating all stuff connected with one "api object" to separate package with all its internals treated as "private" = unexported names where possible in first attempt) where no warnings where produced which may surprise github.com/swaggest/rest users.
Idea: add swaggest/rest manual section about decomposing big apis into separate packages with recommended/example implementation (would be nice to see cleaner "service" way with "subservices" similar to "router" and "subrouters" in chi, without using chi wrapping) and mention there when using exported go field names is required in such separated packages for api params to be available.


Added SDL2 library

Requested in #280.

I've pushed some changes to develop, now it has conflicts and I was not able to merge it. Please rebase.
@Cyberunner23 Can you add an example so this package can be tested?

Rebase done, example should be up after some local tests.

Hmm... find_package is failing... What can be causing this?
CMake Error at CMakeLists.txt:10 (find_package):
  Could not find a package configuration file provided by "SDL2" with any of
  the following names:

    SDL2Config.cmake
    sdl2-config.cmake

  Add the installation prefix of "SDL2" to CMAKE_PREFIX_PATH or set
  "SDL2_DIR" to a directory containing one of the above files.  If "SDL2"
  provides a separate development package or SDK, be sure it has been
  installed.

-- Configuring incomplete, errors occurred!
See also "/home/cyberunner23/Dev/hunter/examples/SDL2/CMakeFiles/CMakeOutput.log".

I added the example in case you wanted to check it out.

What can be causing this?

Probably because it not supported by SDL2's CMake part. Can you show the link from docs about using installed SDL2 in user's CMake?

Seems like there is nothing in the SDL docs for using it with cmake though some people made a FindSDL2.cmake file, example usage here and I also used SDL in another project directly by linking with the SDL targets here

Seems like there is nothing in the SDL docs for using it with cmake though some people made a FindSDL2.cmake file

It means we have two options now:

Pick some FindSDL2.cmake and add it to the Hunter cmake/find modules (should be easy but not so good option)
Patch CMake's SDL code so it will generate SDL2Config.cmake modules, see https://github.com/ruslo/hunter/wiki/example.find_package.config (require fork/patch, but it's the best)

Alright I'll have to work on this later but I would go with the patch.

We will have to patch it anyways because I just found I missed the part where it doesnt respect CMAKE_C_FLAGS...

We will have to patch it anyways

Does this project host sources on GitHub? Is there an official/unofficial GitHub fork already? There is a central place for patches: https://github.com/hunter-packages I can create repo and add you to contributors. Also it will be good to send this patches upstream so there will be no need to use "hunterized" fork.

There is an unofficial mirror on github located here it is an automatic mirror of the mercurial repo but there are no release tags on the github repo so it might be a bit hard to get the fork aligned with the releases.

I've created repo https://github.com/hunter-packages/SDL2. Please keep master branch in a "clean" state so we can just fast-forward updates. Patches should be applied against branch hunter (which is default).
@Cyberunner23 check your email

but there are no release tags on the github repo so it might be a bit hard to get the fork aligned with the releases

You can create them manually. Let me know if you have any better ideas.

Sorry for the delays, been deep in school work and I only managed to get time to work on this now. https://github.com/hunter-packages/SDL2 shoule be ready for testing.

shoule be ready for testing/inclusion

can you please update this pull request? thanks

Update what exactly?

Update what exactly?

This pull request. I'm not able to merge it because of conflicts (you can do rebase to fix it) also I see no new commits. Last commit in this pull request (Mar 3): https://github.com/ruslo/hunter/pull/336/commits/0378863ea396efc33091338e42b3d02dafb673dd

Rebase done, only thing left to do is to switch the project file to use the package from hunter-packages.

Testing:

https://ci.appveyor.com/project/ingenue/hunter/build/1.0.479
https://travis-ci.org/ingenue/hunter/builds/135259615

Testing

/home/travis/build/ingenue/hunter/examples/SDL2/main.cpp:2:9: fatal error: 'SDL.h' file not found
#include<SDL.h>
        ^
1 error generated.

I think it shoud be #include <SDL2/SDL.h> (?)

Ready for retest.

Tests work locally, should be fine to do the tests on travos and appveyor

also fails with #include<SDL2/SDL.h>...

Include propagation fixed, Local tests work, test in travis (https://travis-ci.org/Cyberunner23/CITests/builds/135450613) work

testing:

https://ci.appveyor.com/project/ingenue/hunter/build/1.0.480
https://travis-ci.org/ingenue/hunter/builds/135462205

testing

some tests failed, need to fix/exclude broken stuff

Closing PR, moved SDL2 package to develop_sdl2 branch, havinf SDL2 in develop was causing issues when branching off to work on other packages. New PR: #441


Fix wrong link to key concepts in README

Closes #9070

@liketic has signed the CLA.
Thanks @liketic!

CLA?


Abort when running tensorflow.python.ops.nn_ops.max_pool

Issue type
Bug
Have you reproduced the bug with TensorFlow Nightly?
No
Source
binary
TensorFlow version
2.10.0
Custom code
Yes
OS platform and distribution
22.04
Mobile device
No response
Python version
3.9
Bazel version
No response
GCC/compiler version
No response
CUDA/cuDNN version
nvidia-cudnn-cu11==<IP_ADDRESS>, cudatoolkit=11.8.0
GPU model and memory
No response
Current behavior?
Due to an invalid list element
Standalone code to reproduce the issue
import tensorflow as tf
import os
import numpy as np
from tensorflow.python.ops import nn_ops
try:
  arg_0_tensor = tf.random.uniform([1, 6, 8, 1], dtype=tf.float32)
  arg_0 = tf.identity(arg_0_tensor)
  arg_1_0 = 1
  arg_1_1 = -54.0
  arg_1_2 = 2
  arg_1_3 = True
  arg_1 = [arg_1_0,arg_1_1,arg_1_2,arg_1_3,]
  arg_2_0 = 1
  arg_2_1 = 1
  arg_2_2 = 1
  arg_2_3 = 1
  arg_2 = [arg_2_0,arg_2_1,arg_2_2,arg_2_3,]
  arg_3 = "VALID"
  out = nn_ops.max_pool(arg_0,arg_1,arg_2,arg_3,)
except Exception as e:
  print("Error:"+str(e))

### Relevant log output

```shell
2023-08-14 22:00:35.715971: W tensorflow/compiler/tf2tensorrt/utils/py_utils.cc:38] TF-TRT Warning: Cannot dlopen some TensorRT libraries. If you would like to use Nvidia GPU with TensorRT, please make sure the missing libraries mentioned above are installed properly.
2023-08-14 22:00:36.276384: I tensorflow/stream_executor/cuda/cuda_gpu_executor.cc:980] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero
2023-08-14 22:00:36.293827: I tensorflow/stream_executor/cuda/cuda_gpu_executor.cc:980] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero
2023-08-14 22:00:36.293973: I tensorflow/stream_executor/cuda/cuda_gpu_executor.cc:980] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero
2023-08-14 22:00:36.294262: I tensorflow/core/platform/cpu_feature_guard.cc:193] This TensorFlow binary is optimized with oneAPI Deep Neural Network Library (oneDNN) to use the following CPU instructions in performance-critical operations:  AVX2 FMA
To enable them in other operations, rebuild TensorFlow with the appropriate compiler flags.
2023-08-14 22:00:36.295471: I tensorflow/stream_executor/cuda/cuda_gpu_executor.cc:980] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero
2023-08-14 22:00:36.295585: I tensorflow/stream_executor/cuda/cuda_gpu_executor.cc:980] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero
2023-08-14 22:00:36.295682: I tensorflow/stream_executor/cuda/cuda_gpu_executor.cc:980] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero
2023-08-14 22:00:36.356219: I tensorflow/stream_executor/cuda/cuda_gpu_executor.cc:980] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero
2023-08-14 22:00:36.356397: I tensorflow/stream_executor/cuda/cuda_gpu_executor.cc:980] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero
2023-08-14 22:00:36.356535: I tensorflow/stream_executor/cuda/cuda_gpu_executor.cc:980] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero
2023-08-14 22:00:36.356654: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1616] Created device /job:localhost/replica:0/task:0/device:GPU:0 with 4375 MB memory:  -> device: 0, name: NVIDIA GeForce GTX 1660 Ti, pci bus id: 0000:01:00.0, compute capability: 7.5
2023-08-14 22:00:36.419723: I tensorflow/stream_executor/cuda/cuda_dnn.cc:384] Loaded cuDNN version 8600
2023-08-14 22:00:36.419777: F tensorflow/stream_executor/cuda/cuda_dnn.cc:886] Check failed: cudnnSetPoolingNdDescriptor( handle_.get(), (pooling_descriptor.mode() == dnn::PoolingMode::kMaximum ? cudnn_max_pooling_mode : CUDNN_POOLING_AVERAGE_COUNT_EXCLUDE_PADDING), propagate_nans ? CUDNN_PROPAGATE_NAN : CUDNN_NOT_PROPAGATE_NAN, nd, shape.data(), padding.data(), strides.data()) == CUDNN_STATUS_SUCCESS (3 vs. 0)

@dmc1778 ,
I have replicated the reported behaviour with tf-nightly and attached logs below.
(tf2.13) suryanarayanay@surya-ubuntu20:~$ python 61578.py
2023-08-16 04:45:37.420609: E tensorflow/compiler/xla/stream_executor/cuda/cuda_dnn.cc:9498] Unable to register cuDNN factory: Attempting to register factory for plugin cuDNN when one has already been registered
2023-08-16 04:45:37.420786: E tensorflow/compiler/xla/stream_executor/cuda/cuda_fft.cc:609] Unable to register cuFFT factory: Attempting to register factory for plugin cuFFT when one has already been registered
2023-08-16 04:45:37.425599: E tensorflow/compiler/xla/stream_executor/cuda/cuda_blas.cc:1518] Unable to register cuBLAS factory: Attempting to register factory for plugin cuBLAS when one has already been registered
2023-08-16 04:45:37.765288: I tensorflow/core/platform/cpu_feature_guard.cc:182] This TensorFlow binary is optimized to use available CPU instructions in performance-critical operations.
To enable the following instructions: AVX2 FMA, in other operations, rebuild TensorFlow with the appropriate compiler flags.
2023-08-16 04:45:39.479782: W tensorflow/compiler/tf2tensorrt/utils/py_utils.cc:38] TF-TRT Warning: Could not find TensorRT
WARNING:tensorflow:From /home/suryanarayanay/miniconda3/envs/tf2.13/lib/python3.11/site-packages/tensorflow/python/ops/distributions/distribution.py:259: ReparameterizationType.__init__ (from tensorflow.python.ops.distributions.distribution) is deprecated and will be removed after 2019-01-01.
Instructions for updating:
The TensorFlow Distributions library has moved to TensorFlow Probability (https://github.com/tensorflow/probability). You should update all references to use `tfp.distributions` instead of `tf.distributions`.
WARNING:tensorflow:From /home/suryanarayanay/miniconda3/envs/tf2.13/lib/python3.11/site-packages/tensorflow/python/ops/distributions/bernoulli.py:165: RegisterKL.__init__ (from tensorflow.python.ops.distributions.kullback_leibler) is deprecated and will be removed after 2019-01-01.
Instructions for updating:
The TensorFlow Distributions library has moved to TensorFlow Probability (https://github.com/tensorflow/probability). You should update all references to use `tfp.distributions` instead of `tf.distributions`.
2.15.0-dev20230813
2023-08-16 04:45:49.879774: I tensorflow/compiler/xla/stream_executor/cuda/cuda_gpu_executor.cc:894] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero. See more at https://github.com/torvalds/linux/blob/v6.0/Documentation/ABI/testing/sysfs-bus-pci#L344-L355
2023-08-16 04:45:49.881895: I tensorflow/compiler/xla/stream_executor/cuda/cuda_gpu_executor.cc:894] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero. See more at https://github.com/torvalds/linux/blob/v6.0/Documentation/ABI/testing/sysfs-bus-pci#L344-L355
2023-08-16 04:45:49.884000: I tensorflow/compiler/xla/stream_executor/cuda/cuda_gpu_executor.cc:894] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero. See more at https://github.com/torvalds/linux/blob/v6.0/Documentation/ABI/testing/sysfs-bus-pci#L344-L355
2023-08-16 04:45:49.886245: I tensorflow/compiler/xla/stream_executor/cuda/cuda_gpu_executor.cc:894] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero. See more at https://github.com/torvalds/linux/blob/v6.0/Documentation/ABI/testing/sysfs-bus-pci#L344-L355
2023-08-16 04:45:50.267787: I tensorflow/compiler/xla/stream_executor/cuda/cuda_gpu_executor.cc:894] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero. See more at https://github.com/torvalds/linux/blob/v6.0/Documentation/ABI/testing/sysfs-bus-pci#L344-L355
2023-08-16 04:45:50.270046: I tensorflow/compiler/xla/stream_executor/cuda/cuda_gpu_executor.cc:894] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero. See more at https://github.com/torvalds/linux/blob/v6.0/Documentation/ABI/testing/sysfs-bus-pci#L344-L355
2023-08-16 04:45:50.272130: I tensorflow/compiler/xla/stream_executor/cuda/cuda_gpu_executor.cc:894] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero. See more at https://github.com/torvalds/linux/blob/v6.0/Documentation/ABI/testing/sysfs-bus-pci#L344-L355
2023-08-16 04:45:50.274200: I tensorflow/compiler/xla/stream_executor/cuda/cuda_gpu_executor.cc:894] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero. See more at https://github.com/torvalds/linux/blob/v6.0/Documentation/ABI/testing/sysfs-bus-pci#L344-L355
2023-08-16 04:45:50.276234: I tensorflow/compiler/xla/stream_executor/cuda/cuda_gpu_executor.cc:894] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero. See more at https://github.com/torvalds/linux/blob/v6.0/Documentation/ABI/testing/sysfs-bus-pci#L344-L355
2023-08-16 04:45:50.278245: I tensorflow/compiler/xla/stream_executor/cuda/cuda_gpu_executor.cc:894] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero. See more at https://github.com/torvalds/linux/blob/v6.0/Documentation/ABI/testing/sysfs-bus-pci#L344-L355
2023-08-16 04:45:50.280214: I tensorflow/compiler/xla/stream_executor/cuda/cuda_gpu_executor.cc:894] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero. See more at https://github.com/torvalds/linux/blob/v6.0/Documentation/ABI/testing/sysfs-bus-pci#L344-L355
2023-08-16 04:45:50.282147: I tensorflow/compiler/xla/stream_executor/cuda/cuda_gpu_executor.cc:894] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero. See more at https://github.com/torvalds/linux/blob/v6.0/Documentation/ABI/testing/sysfs-bus-pci#L344-L355
2023-08-16 04:45:51.526972: I tensorflow/compiler/xla/stream_executor/cuda/cuda_gpu_executor.cc:894] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero. See more at https://github.com/torvalds/linux/blob/v6.0/Documentation/ABI/testing/sysfs-bus-pci#L344-L355
2023-08-16 04:45:51.529321: I tensorflow/compiler/xla/stream_executor/cuda/cuda_gpu_executor.cc:894] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero. See more at https://github.com/torvalds/linux/blob/v6.0/Documentation/ABI/testing/sysfs-bus-pci#L344-L355
2023-08-16 04:45:51.531250: I tensorflow/compiler/xla/stream_executor/cuda/cuda_gpu_executor.cc:894] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero. See more at https://github.com/torvalds/linux/blob/v6.0/Documentation/ABI/testing/sysfs-bus-pci#L344-L355
2023-08-16 04:45:51.533277: I tensorflow/compiler/xla/stream_executor/cuda/cuda_gpu_executor.cc:894] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero. See more at https://github.com/torvalds/linux/blob/v6.0/Documentation/ABI/testing/sysfs-bus-pci#L344-L355
2023-08-16 04:45:51.535263: I tensorflow/compiler/xla/stream_executor/cuda/cuda_gpu_executor.cc:894] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero. See more at https://github.com/torvalds/linux/blob/v6.0/Documentation/ABI/testing/sysfs-bus-pci#L344-L355
2023-08-16 04:45:51.537244: I tensorflow/compiler/xla/stream_executor/cuda/cuda_gpu_executor.cc:894] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero. See more at https://github.com/torvalds/linux/blob/v6.0/Documentation/ABI/testing/sysfs-bus-pci#L344-L355
2023-08-16 04:45:51.538944: I tensorflow/compiler/xla/stream_executor/cuda/cuda_gpu_executor.cc:894] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero. See more at https://github.com/torvalds/linux/blob/v6.0/Documentation/ABI/testing/sysfs-bus-pci#L344-L355
2023-08-16 04:45:51.540842: I tensorflow/compiler/xla/stream_executor/cuda/cuda_gpu_executor.cc:894] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero. See more at https://github.com/torvalds/linux/blob/v6.0/Documentation/ABI/testing/sysfs-bus-pci#L344-L355
2023-08-16 04:45:51.542740: I tensorflow/compiler/xla/stream_executor/cuda/cuda_gpu_executor.cc:894] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero. See more at https://github.com/torvalds/linux/blob/v6.0/Documentation/ABI/testing/sysfs-bus-pci#L344-L355
2023-08-16 04:45:51.544756: I tensorflow/compiler/xla/stream_executor/cuda/cuda_gpu_executor.cc:894] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero. See more at https://github.com/torvalds/linux/blob/v6.0/Documentation/ABI/testing/sysfs-bus-pci#L344-L355
2023-08-16 04:45:51.546454: I tensorflow/compiler/xla/stream_executor/cuda/cuda_gpu_executor.cc:894] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero. See more at https://github.com/torvalds/linux/blob/v6.0/Documentation/ABI/testing/sysfs-bus-pci#L344-L355
2023-08-16 04:45:51.548386: I tensorflow/compiler/xla/stream_executor/cuda/cuda_gpu_executor.cc:894] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero. See more at https://github.com/torvalds/linux/blob/v6.0/Documentation/ABI/testing/sysfs-bus-pci#L344-L355
2023-08-16 04:45:54.970594: I tensorflow/compiler/xla/stream_executor/cuda/cuda_gpu_executor.cc:894] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero. See more at https://github.com/torvalds/linux/blob/v6.0/Documentation/ABI/testing/sysfs-bus-pci#L344-L355
2023-08-16 04:45:54.972877: I tensorflow/compiler/xla/stream_executor/cuda/cuda_gpu_executor.cc:894] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero. See more at https://github.com/torvalds/linux/blob/v6.0/Documentation/ABI/testing/sysfs-bus-pci#L344-L355
2023-08-16 04:45:54.975063: I tensorflow/compiler/xla/stream_executor/cuda/cuda_gpu_executor.cc:894] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero. See more at https://github.com/torvalds/linux/blob/v6.0/Documentation/ABI/testing/sysfs-bus-pci#L344-L355
2023-08-16 04:45:54.977261: I tensorflow/compiler/xla/stream_executor/cuda/cuda_gpu_executor.cc:894] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero. See more at https://github.com/torvalds/linux/blob/v6.0/Documentation/ABI/testing/sysfs-bus-pci#L344-L355
2023-08-16 04:45:54.979343: I tensorflow/compiler/xla/stream_executor/cuda/cuda_gpu_executor.cc:894] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero. See more at https://github.com/torvalds/linux/blob/v6.0/Documentation/ABI/testing/sysfs-bus-pci#L344-L355
2023-08-16 04:45:54.981267: I tensorflow/compiler/xla/stream_executor/cuda/cuda_gpu_executor.cc:894] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero. See more at https://github.com/torvalds/linux/blob/v6.0/Documentation/ABI/testing/sysfs-bus-pci#L344-L355
2023-08-16 04:45:54.983170: I tensorflow/compiler/xla/stream_executor/cuda/cuda_gpu_executor.cc:894] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero. See more at https://github.com/torvalds/linux/blob/v6.0/Documentation/ABI/testing/sysfs-bus-pci#L344-L355
2023-08-16 04:45:54.985099: I tensorflow/compiler/xla/stream_executor/cuda/cuda_gpu_executor.cc:894] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero. See more at https://github.com/torvalds/linux/blob/v6.0/Documentation/ABI/testing/sysfs-bus-pci#L344-L355
2023-08-16 04:45:54.986988: I tensorflow/compiler/xla/stream_executor/cuda/cuda_gpu_executor.cc:894] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero. See more at https://github.com/torvalds/linux/blob/v6.0/Documentation/ABI/testing/sysfs-bus-pci#L344-L355
2023-08-16 04:45:54.988979: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1898] Created device /job:localhost/replica:0/task:0/device:GPU:0 with 13621 MB memory:  -> device: 0, name: Tesla T4, pci bus id: 0000:00:04.0, compute capability: 7.5
2023-08-16 04:45:54.989351: I tensorflow/compiler/xla/stream_executor/cuda/cuda_gpu_executor.cc:894] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero. See more at https://github.com/torvalds/linux/blob/v6.0/Documentation/ABI/testing/sysfs-bus-pci#L344-L355
2023-08-16 04:45:54.991305: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1898] Created device /job:localhost/replica:0/task:0/device:GPU:1 with 13621 MB memory:  -> device: 1, name: Tesla T4, pci bus id: 0000:00:05.0, compute capability: 7.5
2023-08-16 04:45:54.991664: I tensorflow/compiler/xla/stream_executor/cuda/cuda_gpu_executor.cc:894] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero. See more at https://github.com/torvalds/linux/blob/v6.0/Documentation/ABI/testing/sysfs-bus-pci#L344-L355
2023-08-16 04:45:54.993597: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1898] Created device /job:localhost/replica:0/task:0/device:GPU:2 with 13621 MB memory:  -> device: 2, name: Tesla T4, pci bus id: 0000:00:06.0, compute capability: 7.5
2023-08-16 04:45:54.994013: I tensorflow/compiler/xla/stream_executor/cuda/cuda_gpu_executor.cc:894] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero. See more at https://github.com/torvalds/linux/blob/v6.0/Documentation/ABI/testing/sysfs-bus-pci#L344-L355
2023-08-16 04:45:54.995832: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1898] Created device /job:localhost/replica:0/task:0/device:GPU:3 with 13621 MB memory:  -> device: 3, name: Tesla T4, pci bus id: 0000:00:07.0, compute capability: 7.5
2023-08-16 04:45:58.302475: I tensorflow/compiler/xla/stream_executor/cuda/cuda_dnn.cc:442] Loaded cuDNN version 8600
2023-08-16 04:45:58.307942: F tensorflow/compiler/xla/stream_executor/cuda/cuda_dnn.cc:1019] Check failed: cudnnSetPoolingNdDescriptor( handle_.get(), (pooling_descriptor.mode() == dnn::PoolingMode::kMaximum ? cudnn_max_pooling_mode : CUDNN_POOLING_AVERAGE_COUNT_EXCLUDE_PADDING), propagate_nans ? CUDNN_PROPAGATE_NAN : CUDNN_NOT_PROPAGATE_NAN, nd, shape.data(), padding.data(), strides.data()) == CUDNN_STATUS_SUCCESS (3 vs. 0)
Aborted (core dumped)
(tf2.13) suryanarayanay@surya-ubuntu20:~$

Please report this issue through proper channel as mentioned in SECURITY.md.
Thanks!

Please always check with the latest version.
Please always report security issues using the proper channels.

The issue resolved. Adding gist with tf-nightly.


Update FreeCAD-asm3.yml

Apply the same fixes as used by FreeCAD Daily.

Reference:
https://forum.freecadweb.org/viewtopic.php?f=10&t=30386&p=251529#p251529


RAC-5725 add knowledge base

there are many buttons in the main page, compared other portals at first glance, it's just my personal feeling. And I'm not sure 'Knowledge Base' have the same level with other buttons.  Invite @tsullivanjr  to review, if that's @tsullivanjr  want, I'm fine with it.

Looks good but swapping Tutorial and Knowledge Base may look more balenced.

@tsullivanjr  Thanks~ I''ll do that


How to avoid unexpected indent at the start of each line in Vim?

The awesome version was installed on my Mac.
I copied several lines from Vim to clipboard using "Cmd+C" and pasted in python from terminal. It returned "IndentationError: unexpected indent". Below's a screenshot of multi-lines selection in Vim:

From the image, we can see one-space ident at the start of each line. But when I move the cursor, no space would be highlighted by the cursor.
Question: how to delete these unexpected indents? Is there any way to set the .vimrc file?
Thanks.

You can go into the visual mode (CTRL+V), select all the white-space and press x.


Stong Named Assemblies

I am investigating the use of Prometheus and have a requirement for strong names in all dependencies.
Is there any objection to adding strong naming to this project? And other parts of the ecosystem such as Prometheus.Client.MetricServer.

@ScottGuymer No problem. I will research this, and you can make PR.

Happy to contribute!

Microsoft advice is to check in the keys for OSS projects.
https://docs.microsoft.com/en-us/dotnet/framework/app-domains/strong-named-assemblies
Althought advice seems to vary
https://stackoverflow.com/a/396159
https://stackoverflow.com/a/886024
I will work up a PR with signing activated and a key checked into the repo

Merged!

@phnx47 to be able to string name the dependent assemblies (eg Prometheus.Client.MetricsServer) this will need to be published on NuGet as the dependent assemblies pull this from NuGet

@ScottGuymer Ok, I will publish later

Great i can then work on getting the rest of the projects upgraded.

3.0.0-rc2

Now all extensions: 'Strong Named Assemblies'


"来園者" needs to be replaced with "ゲスト"

Strongly recommend to replace "来園者" with "ゲスト" , I can see "来園者" is used as a localized Japanese word of "guest" in English, however, it should be "ゲスト" which stands for guest user of SharePoint Online.

ドキュメントの詳細
⚠ このセクションを編集しないでください。 docs.microsoft.com で必須です ➟ GitHub の問題のリンク。

ID: 6ed46514-8036-a543-d690-73d48acef690
Version Independent ID: 8542c3ce-3012-3d23-c3e4-4331dac033d2
Content: SharePoint Online の外部共有をオンまたはオフにする
Content Source: SharePoint/SharePointOnline/turn-external-sharing-on-or-off.md
Service: sharepoint-online
GitHub Login: @MikePlumleyMSFT
Microsoft Alias: mikeplum

Hi @hyoshioka0128 can you help me solve a mystery ;-)   Have you noticed that in Japanese content that the Feedback control is disabled

For example scroll to the bottom of these articles and you see that it's possible to leave feedback from the English page but not from the Japanese page.
Japanese: https://docs.microsoft.com/ja-jp/sharepoint/turn-external-sharing-on-or-off
English: https://docs.microsoft.com/en-us/sharepoint/turn-external-sharing-on-or-off
I am curious how you are able to leave feedback like this issue, which includes a link to the Japanese content.    Can you share the steps you take to leave feedback on a Japanese page (if you can include screen shots that would be great).
Thanks again for all the great feedback that you have been giving on our content.
Best wishes
Tina, from the Office Localization team

@MollyMalone.Sorry for my poor English.
As you said.
Since it can not be done with a Japanese page, I switch to an English page and Issues it.
Below, screen shots of Japanese pages (Base 64)

@MollyMalone. Sorry for my poor English.
As you said.
Since it can not be done with a Japanese page, I switch to an English page and Issues it.

Japanese: https://docs.microsoft.com/ja-jp/sharepoint/turn-external-sharing-on-or-off

@hyoshioka0128 Thank you for sharing the information that you switch to English to leave feedback.  What is interesting is that the Japanese Title and URL are included in the GitHub issue - see the one in this issue above for example.

I don't understand how that is happening when you leave feedback from an English page.


API > Schema > Remove list query > Get query not generated

Before opening, please confirm:

[X] I have installed the latest version of the Amplify CLI (see above), and confirmed that the issue still persists.
[X] I have searched for duplicate or closed issues.
[X] I have read the guide for submitting bug reports.
[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.
[X] I have removed any sensitive information from my code snippets and submission.

How did you install the Amplify CLI?
npm
If applicable, what version of Node.js are you using?
14
Amplify CLI Version
10.3.2
What operating system are you using?
windows
Did you make any manual changes to the cloud resources managed by Amplify? Please describe the changes made.
na
Amplify Categories
api
Amplify Commands
codegen
Describe the bug
If you want the model to not allow "list" queries, but allow "get" queries, BOTH the get and list queries are not generated
i.e. the following @model decoration will not generate a getTestObj query.
type tmpObj
@model(subscriptions: null, queries: { list: null }){
id: ID!
}
Expected behavior
listTestObj is not generated, gettestObj is created
Reproduction steps

Add api to project
Add following schema type tmpObj
@model(subscriptions: null, queries: { list: null }){
id: ID!
}
Deploy
amplify codegen

GraphQL schema(s)

# Put schemas below this line
type tmpObj
@model(subscriptions: null, queries: { list: null }){
  id: ID!
  }

Project Identifier
No response
Log output

# Put your logs below this line

Additional information
No response

Hi @conorw, thank you for reporting this issue. I believe you can mitigate this problem by enabling the shoulddeepmergedirectiveconfigdefaults in your cli.json file within the amplify directory. This is a feature flag which was released beginning in October of 2022.
In order for this update to take effect, you'll need to:

Ensure you've updated your amplify CLI (current latest version is 11.0.2)
Update the cli.json file to enable the shoulddeepmergedirectiveconfigdefaults flag.
Make a no-op change to your schema.graphql file to trigger a rebuild.
Push the backend with amplify push
Re-run codegen with amplify codegen

Feel free to re-open this issue if you encounter any issues with that flow.


Incorrect entry in load-path for ess package

Firstly, I've just switched to straight and was impressed how painless it was. So well done.
I install and configure ess via my init.el as follows:
(use-package ess-site                   ; ESS - Emacs Speaks Statistics
  :straight ess
  :commands R
  :hook (ess-mode . subword-mode))

The straight build as far as I can tell is successful however I see the following entries in my load-path.
"/home/doolio/.emacs.d/straight/build/ess"
"/home/doolio/.emacs.d/straight/build/ess/"
"/home/doolio/.emacs.d/straight/build/ess/obsolete/"

The first and third entries make sense to me looking at the repos/ESS directory but I don't understand why I see the second entry. Now there is an etc/ directory within my build/ess directory. Should this second entry instead be
"/home/doolio/.emacs.d/straight/build/ess/etc/"
Thanks for your time.
Edit: correct path

The first entry is standard, and is added by straight.el. The second entry is not standard, and is added by ESS when you load it (see https://github.com/emacs-ess/ESS/blob/625041ad51038e43ac12e466e3001a252725d88b/lisp/ess-site.el#L56 and https://github.com/emacs-ess/ESS/blob/625041ad51038e43ac12e466e3001a252725d88b/lisp/ess-custom.el#L158). The third entry is nonstandard, and is added by ESS (see https://github.com/emacs-ess/ESS/blob/625041ad51038e43ac12e466e3001a252725d88b/lisp/ess-custom.el#L162).
In other words, the unexpected behavior is caused by nonstandard packaging. straight.el always adds one and only one entry to load-path, and expects that all Lisp files should be symlinked into that directory by the package's build spec.

I see. Thanks for the explanation. This likely is the reason for a similar issue  (https://github.com/rswgnu/hyperbole/issues/23) I reported with the hyperbole package and which still exists with straight when using your recommended receipe given in #237.
I'm happy to report this issue upstream but unsure how I should word it if you have any suggestions. In any case, feel free to close this issue. Thanks for your time.

I do not know if upstream will be amenable to modernizing their packaging. Large packages do seem to be attracted to nonstandard packaging for some reason. But, if you want to give it a go, I'd point out that if ESS is installed using any package manager, then it will already be added to the load-path, and therefore this line can be removed. I think the line in ess-site.el is reasonable, because if I understand correctly, that file shouldn't be loaded unless you are trying to install ESS manually outside of a package manager. And finally the line having to do with obsolete also seems reasonable, because Emacs' feature of producing a warning when you load a file inside a directory called obsolete won't work if the obsolete files aren't actually in a subdirectory called obsolete (so therefore a load-path entry needs to be added).

Thanks. I've opened ESS/issues/1000 upstream. Hopefully, it explains the issue sufficiently and that they are amenable to the suggested correction. In any case, I think you can close this issue. Thanks again for your time.

Upstream were very quick to respond and am happy to report with their fix I now only have the following entries in my load-path:
"/home/doolio/.emacs.d/straight/build/ess"
"/home/doolio/.emacs.d/straight/build/ess/obsolete/"

Therefore, this issue can be closed. Thanks again.


added typescript version

Codecov Report

Merging #149 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #149   +/-   ##
=======================================
  Coverage   97.77%   97.77%
=======================================
  Files           7        7
  Lines         359      359
  Branches      110      110
=======================================
  Hits          351      351
  Misses          7        7
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1666a8...c1fcab5. Read the comment docs.

@shadowvzs Hey, sir.
Thank you very much for your contribution. Now there is a typescript version that will be released as v2. Are you interested?
https://github.com/yisar/fre/tree/next
Frankly, I'm not very familiar with typescript, Hope get your help

@shadowvzs Hey, sir.
Thank you very much for your contribution. Now there is a typescript version that will be released as v2. Are you interested?
https://github.com/yisar/fre/tree/next
Frankly, I'm not very familiar with typescript, Hope get your help, You can turn it into your code.

yeah, sure :)

Thanks! I will merged first, and second will refator next version based this 😀


activeSpan being reused

I believe we're seeing an issue using opentracing-contrib:java-jaxrx:0.1.4, io.zipkin.brave:brave:4.19.2 and brave-opentracing-0.30.3 (all of this inside Dropwizard 1.2), however I'm very new to open tracing in and the available Java tracers and I'm hoping someone here can point me in the right direction:
The active span is not being cleared across requests and all spans that are created in requests are being tagged to the parent thread created in the first request to the server.
On this line the finishing filter pulls the active scope via the tracer's scope manager.
This active scope is closed via it's close() method.  This eventually calls this close implementation in the BraveScopeManager.  This scope manager has a noop close implementation and thus the scope remains open.
Then in later requests the JAXRS filter grabs the active span.  On subsequent requests the active span is set to span that was created during the first request and all traces end up being children of the first trace ever created.
I'm unsure of the relation between Spans and Scopes in this situation but we've confirmed that the active span is being reused across all requests.
For context this is how we are initializing our filters:
AsyncReporter<Span> reporter = AsyncReporter.builder(sender).build();

Tracer tracer = BraveTracer
        .newBuilder(
                Tracing.newBuilder()
                        .localServiceName(openTracingConfig.getServiceName())
                        .spanReporter(reporter)
                        .sampler(Sampler.ALWAYS_SAMPLE)
                        .build()
        )
        .build();

GlobalTracer.register(tracer);

// Register feature / servlet filter to start traces
environment.jersey().register(
        new ServerTracingDynamicFeature.Builder(tracer).build()
 );

// Register filter to end traces
FilterRegistration.Dynamic registration = environment.servlets()
        .addFilter("tracing-filter", new SpanFinishingFilter(tracer));

registration.setAsyncSupported(true);
registration.addMappingForUrlPatterns(EnumSet.of(DispatcherType.REQUEST), false, "*");

A simple dropwizzard app with required deps would be sufficient

https://github.com/jmif/open-tracing-jaxrs-active-span-bug-repro
If you fire 5 - 10 requests you'll notice that the trace IDs / span IDs start to become identical (i've included a simple log below to demonstrate - the RealSpan log entries come via debugger from this line and are the result of the expression ((BraveSpan) activeSpan).delegate
0:0:0:0:0:0:0:1 - - [23/May/2018:18:50:45 +0000] "GET / HTTP/1.1" 200 0 "-" "curl/7.54.0" 38565 RealSpan(59e3a12149dbb753/59e3a12149dbb753) 0:0:0:0:0:0:0:1 - - [23/May/2018:18:50:47 +0000] "GET / HTTP/1.1" 200 0 "-" "curl/7.54.0" 14 RealSpan(8e95010a5bae45ad/8e95010a5bae45ad) 0:0:0:0:0:0:0:1 - - [23/May/2018:18:50:48 +0000] "GET / HTTP/1.1" 200 0 "-" "curl/7.54.0" 5 RealSpan(afbff7b805ae2102/afbff7b805ae2102) 0:0:0:0:0:0:0:1 - - [23/May/2018:18:50:49 +0000] "GET / HTTP/1.1" 200 0 "-" "curl/7.54.0" 5 RealSpan(0ae6ce78d065d464/0ae6ce78d065d464) 0:0:0:0:0:0:0:1 - - [23/May/2018:18:50:49 +0000] "GET / HTTP/1.1" 200 0 "-" "curl/7.54.0" 5 RealSpan(8e95010a5bae45ad/8e95010a5bae45ad) 0:0:0:0:0:0:0:1 - - [23/May/2018:18:50:50 +0000] "GET / HTTP/1.1" 200 0 "-" "curl/7.54.0" 6 RealSpan(0ae6ce78d065d464/0ae6ce78d065d464) 0:0:0:0:0:0:0:1 - - [23/May/2018:18:50:51 +0000] "GET / HTTP/1.1" 200 0 "-" "curl/7.54.0" 5 RealSpan(8e95010a5bae45ad/8e95010a5bae45ad) 0:0:0:0:0:0:0:1 - - [23/May/2018:18:50:52 +0000] "GET / HTTP/1.1" 200 0 "-" "curl/7.54.0" 5 RealSpan(0ae6ce78d065d464/0ae6ce78d065d464) 0:0:0:0:0:0:0:1 - - [23/May/2018:18:50:54 +0000] "GET / HTTP/1.1" 200 0 "-" "curl/7.54.0" 4 RealSpan(8e95010a5bae45ad/8e95010a5bae45ad) 0:0:0:0:0:0:0:1 - - [23/May/2018:18:50:54 +0000] "GET / HTTP/1.1" 200 0 "-" "curl/7.54.0" 4 RealSpan(0ae6ce78d065d464/0ae6ce78d065d464) 0:0:0:0:0:0:0:1 - - [23/May/2018:18:51:02 +0000] "GET / HTTP/1.1" 200 0 "-" "curl/7.54.0" 4 RealSpan(59e3a12149dbb753/59e3a12149dbb753) 0:0:0:0:0:0:0:1 - - [23/May/2018:18:51:02 +0000] "GET / HTTP/1.1" 200 0 "-" "curl/7.54.0" 4 RealSpan(8e95010a5bae45ad/8e95010a5bae45ad) 0:0:0:0:0:0:0:1 - - [23/May/2018:18:51:03 +0000] "GET / HTTP/1.1" 200 0 "-" "curl/7.54.0" 4 RealSpan(afbff7b805ae2102/afbff7b805ae2102) 0:0:0:0:0:0:0:1 - - [23/May/2018:18:51:06 +0000] "GET / HTTP/1.1" 200 0 "-" "curl/7.54.0" 5 RealSpan(0ae6ce78d065d464/0ae6ce78d065d464) 0:0:0:0:0:0:0:1 - - [23/May/2018:18:51:06 +0000] "GET / HTTP/1.1" 200 0 "-" "curl/7.54.0" 6 RealSpan(afbff7b805ae2102/afbff7b805ae2102) 0:0:0:0:0:0:0:1 - - [23/May/2018:18:51:06 +0000] "GET / HTTP/1.1" 200 0 "-" "curl/7.54.0" 4

Then in later requests the JAXRS filter grabs the active span. On subsequent requests the active span is set to span that was created during the first request and all traces end up being children of the first trace ever created.

This was added https://github.com/opentracing-contrib/java-jaxrs/pull/74.

@pavolloffay I'm still seeing this problem with java-jaxrs 0.1.6, brave 5.1.x and brave-opentracing 0.31.2. If a serving thread decides not to trace the incoming request (because of sampling), a NoopSpan is put in scope, but that scope is then never closed correctly and a subsequent request served by the same thread sees that previous span as being active, creating a new span as a child of that first request's old span.

@mpetazzoni is it related to brave implementation - the difference between noopSpan and realSpan?
Would you have a reproducer for tihs?

Yeah, it definitely is because of the interaction with Brave and the Brave/OT bridge. I'll try to work on a reproducer in the java-jaxrs unit tests, but I'm curious to hear your thoughts on how this would be fixed.