Release 0.6.0

Ship 0.6 with the typed extensions changes.

Codecov Report

Merging #68 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #68      +/-   ##
==========================================
- Coverage   95.26%   95.23%   -0.04%
==========================================
  Files          13       13
  Lines        1057     1050       -7
==========================================
- Hits         1007     1000       -7
  Misses         50       50

Impacted Files
Coverage Δ

src/transaction.rs
62.50% <0.00%> (-5.93%)
:arrow_down:

src/api_call.rs
87.09% <0.00%> (-1.14%)
:arrow_down:

src/response.rs
88.35% <0.00%> (-0.07%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d85eb3e...2410e1a. Read the comment docs.


Sniff spacing for language constructs

isset(), exit(), etc. are technically language constructs and not functions, and therefore need special handling to be sniffed for spacing along with the other functions. Support for this was added in #225, but was later removed in #385 when we removed our version of the function call signature sniff in favor of the upstream version.
I still need to investigate upstream to see if this might be handled upstream somewhere. If not, we may be able to sub-class the parent sniff and just replace the list of tokens it sniffs for.

Related: https://github.com/squizlabs/PHP_CodeSniffer/issues/589

This was actually fixed in PHPCS 2.3.3 (https://github.com/squizlabs/PHP_CodeSniffer/commit/9de93e09d1320d9d1e0e21baba5ad5906a398247). I was using PHPCS 2.3.2.


my practice for sort

Hey @Sweetymeow, thanks for the PR. Probably it's more appropriate to publish the code in a playground repo where you collect all the code you practice.


Consistently use GCP XML API

Which issue does this PR close?

Relates to #2241
Rationale for this change

We currently use a mixture of the XML and JSON APIs.
The XML API is more complete, supporting the full set of request preconditions, list offsets, etc... and so we should just switch over. As an added bonus this allows for code sharing between the implementations.
What changes are included in this PR?

Are there any user-facing changes?

There appear to be some emulator quirks... Will fix tomorrow...

It would appear that fake-gcs-server doesn't properly support the XML APIs... - https://github.com/fsouza/fake-gcs-server/issues/331


CitadelDAO - Potential race conditions in batch mode

Code Location:
https://github.com/CivMC/Citadel/blob/23a41a90335ad6d96fd2712df8cea26a1c0ed5a1/paper/src/main/java/vg/civcraft/mc/citadel/model/CitadelDAO.java#L32
Especially selects.

Issue:
Selects are passthrough even while in batch mode (afaics), this leads to potential race conditions if batches have not been processed yet.

Solution:

Batches need to be queried for selects.
Batches need to be forced to be flushed before executing selects.

I'm closing this out as something that we won't fix. It could be revisited in the future, but it's not within our capacity to work on right now.


Comparison Matrix - Mobile View Broken

On smaller view ports, the comparison matrix "pinned" left column is failing to render.  It works okay when testing / emulating locally, but fails on the device.
The javascript for this is located in "responsive-tables.js".  The expected result should be one scrollable div and one pinned div.  The pinned div is fixed position while the scrollable div slides horizontally behind the pinned div.  Currently, the page is only rendering the scrollable div.

Closing this issue as it cannot be replicated by other devices.


Proxy class properties accessing object instance properties

Added failing unit-test for issue #177
When using proxy classes, it appears that lazy-loaded properties can not access the property values of its object instance.
@JimBobSquarePants to review (in due course - no rush, just wanted to keep track of this) :sunglasses:

Just to note what lee and I observed when we reviewed this (to the best of our understanding), it looks like an IProxy object is made per property that only contains that individual property, so if one property accesses another, it doesn't exist on the IProxy, so it fails.

@mattbrailsford No, that's not correct at all. An IProxy is created per instance.
https://github.com/leekelleher/umbraco-ditto/blob/develop/src/Our.Umbraco.Ditto/Extensions/PublishedContentExtensions.cs#L362
Basically if you have a class like this:
public class Foo {
    public virtual string Bar {get; set;}
}

The proxy generator will create a class like this:
public class FooProxy : Foo, IProxy {

    public IInterceptor Interceptor { get; set; }

    public override string Bar {
        get {
            return (string) interceptor.Intercept(methodof(Foo.get_Property), null);
        }
        set {
            interceptor.Intercept(methodof(Foo.set_Property), value);
        }
}

We set the interceptor containing all the virtual properties here.  It also reference the current instance.
In the example code the lazy property seems to be getting called against the base class and not the proxy class but Ill have to dig around to be sure. Now we have a failing test I should easily be able to do so.
It really is an odd design pattern though. Why have to properties referencing the same object? If they want to convert it to a string they should be using a method or casting their property. They're hurting performance and making their code difficult to follow.

Is this still relevant with PR #191?

TBH I don't know. Will have to conduct further tests after we merge.

Merged in and tested locally... the failing unit-test (for issue #177) now passes.
Merged in this PR - we can decide whether or not to keep the actual unit-test, or to combine with another unit-test (from PR #190)?

I'd move the tests together. still want to have a dig around though.


Verification management UI overlaps with gutter icons

I managed to get to the following state while working with verification management UI:

Any idea of how to reproduce? Can you also reproduce while using https://github.com/dafny-lang/ide-vscode/pull/234 ?

To reproduce, even using #234 , enter the code
method test(a: int) {
  assert true;
}

Then place the caret at the beginning of the file and press ENTER twice very quickly. Try a few times. You should see this:

Version with failure:


I cannot find the "Take action on" by clicking the ellipse to the left of one of the fields

I followed this article, but in the section "To initiate runbook from log search", step 5, I cannot find the "Take action on".

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4a353507-e410-2caf-0a8b-15d68b5fbe9e
Version Independent ID: c473aa2c-2226-7406-4ca0-a1c4fc7b6e5b
Content: User-initiated Azure Automation Runbook Action in Log Analytics
Content Source: articles/azure-monitor/log-query/take-action.md
Service: log-analytics
GitHub Login: @MGoedtel
Microsoft Alias: magoedte

@imeya Thanks for bringing this to our attention. Your feedback has been shared with the content owner for further review.


[SMALLFIX] Ignore flaky tests

See https://alluxio.atlassian.net/browse/ALLUXIO-1907

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/9445/
Test PASSed.

LGTM


[BUG] automation seems to have stopped

Cards are no longer being moved from column to column when I apply a tag. This has been working without an issue for some time and appears to have stopped either today or within the past two days.

My automation cards are at the bottom of my columns
the tags match the tags specified in the cards

I have not made any changes to the automation rules or tags recently, not sure what's going on here. I do not see a way to message, I hate to add an issue, but can someone help?

I think this is happening since #50 (issue #47) was merged yesterday. @tcely @philschatz
I tried to reinstall the bot with no effect.

Can I help somehow? I will try to debug the bot locally if I have time.

There is a syntax error in current version of bot. I prepared a fix: #52
I successfully run this version of code locally, rules got applied.

Thanks for debugging this. I am sorry to have missed it in my pull request.

Thanks @ondrejbouda for the quick fix!

Just tested on my end and it's working again. Thank you for the quick turn around time, you guys rock!


The target entry-point "angular-stl-model-viewer" has missing dependencies

So I had the stl-model-viewer run all good, the 3d model was being displayed properly and angular was running with no errors.
However I installed angular cdk with
ng add @angular/cdk
After that I wanted to build my project with ng build and got the error
ERROR in The target entry-point "angular-stl-model-viewer" has missing dependencies:
 - three
 - three/examples/jsm/loaders/STLLoader
 - three/examples/jsm/controls/OrbitControls

I tried reinstalling the stl viewer with
yarn add angular-stl-model-viewer
npm install angular-stl-model-viewer

but it didn't help
My package.json does contain three declaration:

{
  "name": "client",
  "version": "0.0.0",
  "scripts": {
    "ng": "ng",
    "start": "ng serve",
    "build": "ng build",
    "test": "ng test",
    "lint": "ng lint",
    "e2e": "ng e2e"
  },
  "private": true,
  "dependencies": {
    "@angular/animations": "~10.2.4",
    "@angular/cdk": "^10.2.7",
    "@angular/common": "~10.2.4",
    "@angular/compiler": "~10.2.4",
    "@angular/core": "~10.2.4",
    "@angular/forms": "~10.2.4",
    "@angular/platform-browser": "~10.2.4",
    "@angular/platform-browser-dynamic": "~10.2.4",
    "@angular/router": "~10.2.4",
    "angular-stl-model-viewer": "^3.2.0",
    "angular-toastr": "^2.1.1",
    "bootstrap": "4.1.1",
    "font-awesome": "^4.7.0",
    "ngx-bootstrap": "^6.2.0",
    "ngx-toastr": "^13.2.0",
    "rxjs": "~6.5.4",
    "three": "^0.125.2",
    "tslib": "^2.0.0",
    "uuid": "^8.3.2",
    "zone.js": "~0.10.2"
  },
  "devDependencies": {
    "@angular-devkit/build-angular": "~0.1002.2",
    "@angular/cli": "~10.2.2",
    "@angular/compiler-cli": "~10.2.4",
    "@types/jasmine": "~3.5.0",
    "@types/jasminewd2": "~2.0.3",
    "@types/node": "^12.11.1",
    "codelyzer": "^5.1.2",
    "jasmine-core": "~3.5.0",
    "jasmine-spec-reporter": "~5.0.0",
    "karma": "~5.0.0",
    "karma-chrome-launcher": "~3.1.0",
    "karma-coverage-istanbul-reporter": "~3.0.2",
    "karma-jasmine": "~4.0.0",
    "karma-jasmine-html-reporter": "^1.5.0",
    "protractor": "~7.0.0",
    "ts-node": "~8.3.0",
    "tslint": "~6.1.0",
    "typescript": "~4.0.7"
  }
}

Any ideas how can I make it work back again?

Also: when I browse my node_modules folder I can't find any folder inside that contains "three" in its name

Then try to remove The node_modules folder an Reinstall your deps
Am 26.02.2021 in 14:48, tekilla667<EMAIL_ADDRESS>schrieb:
Also: when I browse my node_modules folder I can't find any folder inside
that contains "three" in its name
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/codaline-io/angular-stl-model-viewer/issues/447#issuecomment-786657830,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AARI4YBE54QQUVMA5KWVT23TA6RBRANCNFSM4YIO543A
.

I ran the npm install angular-stl-model-viewer first and then yarn add angular-stl-model-viewer. It did the trick, now I have the three folder in node modules and everything runs smoothly again. Thanks anyway bro!


calculate-state-pension: undefined method `pension_date' for nil:NilClass

See the exception report in Errbit.
To replicate:

Visit http://smartanswers.dev.gov.uk/calculate-state-pension/y/age/male
Enter a date of birth that's at least 2 days in the future
Observe the undefined method pension_date' for nil:NilClass` error

This same error occurs in both the :dob_age? and :dob_amount? questions.

This has been fixed by PR #2080.


Add Funcodec

This pull request includes several changes to the codec_bpe/audio_to_codes.py file to enhance the functionality and readability of the code. The main changes involve reformatting argument parsing, adding support for a new model, and updating encoding logic.
Argument Parsing Enhancements:

Reformatting of the argument parsing section for better readability.

New Model Support:

Added support for the Funcodec model, including new arguments and handling logic. [1] [2]

Encoding Logic Updates:

Updated the sample rate logic to include the Funcodec model.
Modified the encoding logic to handle the Funcodec model.

Hey @indiejoseph thanks for this contribution! I'll review it soon.

@indiejoseph in testing it out I get this error:
  File "/home/codec-bpe/codec_bpe/audio_to_codes.py", line 115, in <module>
    model = Speech2Token(config_file, model_pth, device=device)
  File "/home/anaconda3/envs/dev/lib/python3.9/site-packages/funcodec/bin/codec_inference.py", line 68, in __init__
    with open(config_file, "rt", encoding="utf-8") as f:
FileNotFoundError: [Errno 2] No such file or directory: 'facebook/funcodec-base-8bit/config.yaml'

I'm not familiar with how downloading works with ModelScope - ideally it should work like in transformers, where the model is automatically downloaded from the huggingface hub if it does not exist. Alternatively to implementing this directly in audio_to_codes, instructions to download the model in the readme would be sufficient.

Oh sorry, coz the it required to download the model in the working folder, and I have not add the instruction or other information into the README.md, this is my fault. I will update the PR. And it doesnt work like how transformers does, that have to download manually.
https://huggingface.co/alibaba-damo/audio_codec-encodec-zh_en-general-16k-nq32ds640-pytorch

@indiejoseph thanks - please add a short instruction to the Readme on how to download the model. I'll review once that's in.

I've added a section into README.md, please check

Thanks for reviewing my PR, Will soft out some mistakes and reply your comments soon


One or more arguments are invalid

Describe the bug
Due to unknown reasons, the UI framework throws this exception and the source cannot be traced
Steps to reproduce the bug

Unknown

StackTrace
StackTrace.txt
Version Info
2.5.0-prerelease.201027002
NuGet package version:
[Microsoft.UI.Xaml.2.5.0-prerelease.201027002]

Windows app type:

UWP
Win32

Yes

Windows 10 version
Saw the problem?

Insider Build (xxxxx)

May 2020 Update (19041)
Yes

November 2019 Update (18363)

May 2019 Update (18362)

October 2018 Update (17763)

April 2018 Update (17134)

Fall Creators Update (16299)

Creators Update (15063)

Device form factor
Saw the problem?

Desktop
Yes

Xbox

Surface Hub

IoT

can you please attach a repro app ?

It is temporarily unclear what UI controls cause this problem. But it may be related to double-clicking the ListView/GridView that enables drag and drop.


Error message text is "64"!

We're testing out S:ES 1.20 plus all-latest prereqs and encountered an odd problem.
Everything seems to work fine, but if there is an error then the error message text is just 64!
For example:

[Request] ** [http://mls-es-stag-ddc.tigerlead.local:9200]-[0] 64, called from sub Search::Elasticsearch::Transport::try {...}  at /home/tigerstage/trunk_1506041752/cpan/cpan-5.020/lib/perl5/Try/Tiny.pm line 81. With vars: {'request' => {'method' => 'GET','body' => {'from' => 0,'query' => {'constant_score' => {'filter' => {'and' => [{'terms' => {'mls_area_id' => [902146,901799,902027,902132,902933,902554,902896,901817,901810,901938,901989,901770,902583,902337,902170,901646,902442,902657,902946,903058,902401,903118,901748,902807,901884,901974,903013,902254,902710,903433,903133,901869,901873,902026,902065,903178,901864,901836,901725,901701,902987,901853,902463,902789,902645,902371,901728,901717,903031,903092,902815,902688,902427,901905,901716,902998,903057,902428,901706,902557,901762,903104,902929,902444,902191,903132,902953,902496,902925,901901,903056,902509,902636,902297,902842,901855,901894,903087,901882,902693,901765,902764,901775,902686,901719,902576,902718,903151,902500,902423,903086,902335,902273,901790,902462,902631,902911,902875,901802,903091,902242,903060,901995,902156,901903,901898,903082,902735,902894,901711,902323,901968,902961,902881,902142,902885,902999,902973,902861,902201,902075,902724,902927,903070,903068,902648,902397,902014,902339,903033,902721,903045,902291,905765,902660,902699,903119,901944,902029,902586,902499,902381,902990,902906,903185,901757,901872,902924,901768,902114,903146,902985,903089,902192,902979,902566,901689,902915,903081,902251,901832,901924,901861,902023,902059,902840,902623,902757,903153,901913,902743,902492,902746,902022,902908,902547,902497,902874,902282,901842,902344,903080,902517,902917,902817,902087,901926,902199,902848,902078,902951,901824,903035,902687,902349,902864,902316,902202,902507,902188,901657,903051,902571],'execution' => 'bool'}},{'geo_polygon' => {'address_location' => {'points' => [['-117.3994','33.98902'],['-117.59167','34.06642'],['-117.76195','33.97991'],['-117.91576','34.00724'],['-117.97069','33.97536'],['-118.01464','33.87052'],['-117.79491','33.83859'],['-117.89379','33.72901'],['-117.82238','33.72901'],['-117.77294','33.64674'],['-117.50927','33.56439'],['-117.51476','33.48654'],['-117.3994','33.43613'],['-117.31701','33.48196'],['-117.33349','33.62845'],['-117.21813','33.56439'],['-117.13024','33.66503'],['-117.14672','33.76555'],['-117.22362','33.81577'],['-117.26208','33.94347'],['-117.02587','33.88876'],['-116.56994','33.89788'],['-116.25133','33.71988'],['-116.16344','33.73358'],['-116.31725','33.77469'],['-116.58642','33.92979'],['-117.3994','33.98902']]}}},{'term' => {'mls_board_id' => 1312}},{'terms' => {'mls_boards_mls_type_id' => [5022,5182,5186]}},{'range' => {'images_count' => {'gte' => 1}}}]}}},'sort' => ['_score',{'price' => 'desc'},{'created_at' => 'desc'}],'fields' => ['_parent','_routing','_source'],'explain' => '','size' => 18},'qs' => {'version' => 1},'serialize' => 'std','path' => '/mls_fts_board_1312/mls_listing/_search','ignore' => [],'mime_type' => 'application/json'},'status_code' => 0}

For this application we're still using ES 0.90 (yes, I know!) so that might be a factor.

Would you prefer "42"?  :)
I did some refactoring of error messages to handle the structured exceptions coming in v2, and I probably messed something up somewhere.  Could you turn on trace logging to see the actual body that is returned for the above request? ie
$e=Search::Elasticsearch->new( trace_to => 'Stderr' )

Of course! If you're going to provide an answer then it would obviously be the answer!
I forgot to mention I'm using Elastic::Model 0.50.
curl -XGET 'http://localhost:9200/mls_fts_board_925/mls_listing/_search?pretty=1&version=1' -d '
{
   "sort" : [
      "_score",
      {
         "created_at" : "desc"
      },
      {
         "created_at" : "desc"
      }
   ],
   "fields" : [
      "_parent",
      "_routing",
      "_source"
   ],
   "explain" : "",
   "query" : {
      "constant_score" : {
         "filter" : {
            "and" : [
               {
                  "terms" : {
                     "execution" : "bool",
                     "mls_area_id" : [
                        "489348",
                        "489379",
                        "489371",
                        "489333",
                        "489362",
                        "489368",
                        "489329",
                        "489343",
                        "489339",
                        "489332",
                        "489317",
                        "489327",
                        "489376",
                        "489325",
                        "489349",
                        "489316",
                        "489321",
                        "489374",
                        "489345",
                        "489380",
                        "489366",
                        "489328",
                        "489337",
                        "489323",
                        "489367",
                        "489357",
                        "489378",
                        "489377",
                        "489358",
                        "489335",
                        "489344",
                        "489331",
                        "489546",
                        "489346",
                        "489314"
                     ]
                  }
               },
               {
                  "geo_polygon" : {
                     "address_location" : {
                        "points" : [
                           [
                              -80.95022,
                              32.30283
                           ],
                           [
                              -80.97219,
                              32.24187
                           ],
                           [
                              -80.91932,
                              32.26104
                           ],
                           [
                              -80.92962,
                              32.21283
                           ],
                           [
                              -80.88018,
                              32.24013
                           ],
                           [
                              -80.88293,
                              32.19192
                           ],
                           [
                              -80.84379,
                              32.21399
                           ],
                           [
                              -80.84859,
                              32.16634
                           ],
                           [
                              -80.80671,
                              32.18552
                           ],
                           [
                              -80.79847,
                              32.13786
                           ],
                           [
                              -80.78542,
                              32.18204
                           ],
                           [
                              -80.75109,
                              32.17855
                           ],
                           [
                              -80.78268,
                              32.21399
                           ],
                           [
                              -80.74972,
                              32.22096
                           ],
                           [
                              -80.78748,
                              32.23432
                           ],
                           [
                              -80.75933,
                              32.25523
                           ],
                           [
                              -80.8122,
                              32.25988
                           ],
                           [
                              -80.7916,
                              32.30167
                           ],
                           [
                              -80.83623,
                              32.28194
                           ],
                           [
                              -80.85065,
                              32.29819
                           ],
                           [
                              -80.87125,
                              32.26046
                           ],
                           [
                              -80.87331,
                              32.32315
                           ],
                           [
                              -80.89048,
                              32.28716
                           ],
                           [
                              -80.89185,
                              32.33997
                           ],
                           [
                              -80.91314,
                              32.30109
                           ],
                           [
                              -80.92206,
                              32.33707
                           ],
                           [
                              -80.92206,
                              32.3098
                           ],
                           [
                              -80.93648,
                              32.31676
                           ],
                           [
                              -80.93786,
                              32.30167
                           ],
                           [
                              -80.95022,
                              32.30283
                           ]
                        ]
                     }
                  }
               },
               {
                  "term" : {
                     "mls_board_id" : "925"
                  }
               },
               {
                  "term" : {
                     "mls_boards_mls_type_id" : "3315"
                  }
               },
               {
                  "range" : {
                     "images_count" : {
                        "gte" : "1"
                     }
                  }
               }
            ]
         }
      }
   },
   "from" : 0,
   "size" : "18"
}
'

# ERROR: Search::Elasticsearch::Error::Request [http://mls-es-stag-ddc.tigerlead.local:9200]-[0] 64

If I copy-n-paste that curl command, and fix the hostname, then the request runs fine, repeatedly.

What I'm interested in is the response that ES sent, hence the trace logging

Adding a -v to the curl shows
> GET /mls_fts_board_925/mls_listing/_search?pretty=1&version=1 HTTP/1.1
> User-Agent: curl/7.19.7 (x86_64-redhat-linux-gnu) libcurl/7.19.7 NSS/<IP_ADDRESS> Basic ECC zlib/1.2.3 libidn/1.18 libssh2/1.4.2
> Host: mls-es-stag-ddc.tigerlead.local:9200
> Accept: */*
> Content-Length: 6601
> Content-Type: application/x-www-form-urlencoded
> Expect: 100-continue
>
< HTTP/1.1 100 Continue
< HTTP/1.1 200 OK
< Content-Type: application/json; charset=UTF-8
< Content-Length: 41934

Is that what you're after?

No, turn on trace logging as follows:
$e=Search::Elasticsearch->new( trace_to => 'Stderr' )

I did. I pasted the output (curl ... plus Error: ...) in the earlier comment.

That's it?  Nothing in the body itself?

Nope. Nothing.

Per twitter DMs this seems to be a bug in Hijk handling of a particular case, so it returns an error, combined with a bug in the ES Hijk Cxn module in how it reports that error.
The Hijk error is Wasn't expecting a 0 byte response for http head. This shouldn't happen.
The write to ES is:
GET /mls_fts_board_925/mls_listing/_search?version=1 HTTP/1.1
Host: mls-es-stag-ddc.tigerlead.local
Content-Length: 1340
Content-Type: application/json

{"from":0,"query":{"constant_score":{"filter":{"and":[{"terms":{"execution":"bool","mls_area_id":["489348","489379","489371","489333","489362","489368","489329","489343","489339","489332","489317","489327","489376","489325","489349","489316","489321","489374","489345","489380","489366","489328","489337","489323","489367","489357","489378","489377","489358","489335","489344","489331","489546","489346","489314"]}},{"geo_polygon":{"address_location":{"points":[[-80.95022,32.30283],[-80.97219,32.24187],[-80.91932,32.26104],[-80.92962,32.21283],[-80.88018,32.24013],[-80.88293,32.19192],[-80.84379,32.21399],[-80.84859,32.16634],[-80.80671,32.18552],[-80.79847,32.13786],[-80.78542,32.18204],[-80.75109,32.17855],[-80.78268,32.21399],[-80.74972,32.22096],[-80.78748,32.23432],[-80.75933,32.25523],[-80.8122,32.25988],[-80.7916,32.30167],[-80.83623,32.28194],[-80.85065,32.29819],[-80.87125,32.26046],[-80.87331,32.32315],[-80.89048,32.28716],[-80.89185,32.33997],[-80.91314,32.30109],[-80.92206,32.33707],[-80.92206,32.3098],[-80.93648,32.31676],[-80.93786,32.30167],[-80.95022,32.30283]]}}},{"term":{"mls_board_id":"925"}},{"term":{"mls_boards_mls_type_id":"3315"}},{"range":{"images_count":{"gte":"1"}}}]}}},"fields":["_parent","_routing","_source"],"sort":["_score",{"created_at":"desc"},{"created_at":"desc"}],"explain":"","size":"18"}

This is different to the request sent by curl, for example it's missing the Expect: 100-continue and has a different Content-Type.
The POSIX::read in Hijk returns "0 but true" on the first call. So it seems that ES has closed the connection.

@timbunce In eg the NetCurl backend, we disable the Expect header and set the same content type, so the request should be the same as what is being sent via Hijk.

I suspect the bug in Hijk is that it doesn't handle getting a 0 byte packet. That ought to be ignored.
Using the HTTPTiny backend seems to be working fine.

I've opened a Hijk ticket for this.


Add example showing how to use SpecializedMeshPipeline

Objective

A lot of mid-level rendering apis are hard to figure out because they don't have any examples
SpecializedMeshPipeline can be really useful in some cases when you want more flexibility than a Material without having to go to low level apis.

Solution

Add an example showing how to make a custom SpecializedMeshPipeline.

Testing

Did you test these changes? If so, how?
Are there any parts that need more testing?
How can other people (reviewers) test your changes? Is there anything specific they need to know?
If relevant, what platforms did you test these changes on, and are there any important ones you can't test?

Showcase
The examples just spawns 3 triangles in a triangle pattern.

This seems very helpful, I did not know this functionality existed. However, with this example I'm still slightly confused what the use cases and limitations are and when to use it.

I'm still slightly confused what the use cases and limitations are and when to use it

It's a bit hard to explain if, for example, using the material apis was enough for your use case. This api is useful when you want to have more control over how a mesh is rendered than is possible with the material api.

Ah yep, that seems useful information to add to the example! They're often a bit short on information as to why to do things, I find.

This has subtle merge conflicts with https://github.com/bevyengine/bevy/pull/14273 that need to be fixed manually <3


Automatic scratch config's c_flags does not include extra_cflags

It includes all of the shared cflags but not the object-specific extra_cflags.
Example fix: https://github.com/zeldaret/tww/commit/7916599cad12c8a6809946ac07e8a2479f38a5cc

That fix looks good, I’d accept it as a PR if you were willing to open one. Otherwise I’ll copy it when I’m able.


[SPARK-8139] [SQL] Updates docs and comments of data sources and Parquet output committer options

This PR only applies to master branch (1.5.0-SNAPSHOT) since it references org.apache.parquet classes which only appear in Parquet 1.7.0.

Merged build triggered.

Merged build started.

Test build #34360 has started for   PR 6683 at commit 285fc45.

Test build #34360 has finished for   PR 6683 at commit 285fc45.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Merged build triggered.

Merged build started.

Test build #34408 has started for   PR 6683 at commit 9c168e2.

Test build #34408 has finished for   PR 6683 at commit 9c168e2.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Merged build triggered.

Merged build started.

Test build #35594 has started for   PR 6683 at commit b1d4d67.

Merged build triggered.

Merged build started.

Test build #35596 has started for   PR 6683 at commit b4648b8.

Test build #35596 has finished for   PR 6683 at commit b4648b8.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test build #35594 has finished for   PR 6683 at commit b1d4d67.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Merging to master.


[FEA] control location of textual report output from CliOnpremLocalMode

Is your feature request related to a problem? Please describe.
the qualification report generated by CliOnpremLocalMode is sent to stdout and intermixed with other output
Describe the solution you'd like
a parameter to specify where the textual qualification report should be stored

There is an existing parameter to specify the output folder local_folder. should we just save the textual output into that path?
The summary report of the wrapper is generated at the end of execution. It is not intermixed with the logging information. The output of the Qualification java command  - which is not considered part of the summary output - is logged because it gives the user insights about the eventlogs that were processed and exceptions if any. @mattf Can you clarify further on the format you want to see in the output?


Error message: Deprecated - preg_match_all() on line 83

Error message: Deprecated - preg_match_all(): Passing null to parameter #2 ($subject) of type string is deprecated, File: /var/www/html/modules/redcap_qrcode_v1.2.2/QRCodeExternalModule.php, Line: 83
might be fixed by adding a line above it:
if(is_null($misc)) {continue;}
Which would continue the loop:
foreach ($Proj->forms[$instrument]["fields"] as $fieldName => $_) {

@biggeeves - Thanks for reporrting. Fixed via c0c40d0256072690fa92a4dd3f0dcc7e6d5a9e17


Match the jenkins version to the one in CI

Description
Match the jenkins version to the one in https://build.ci.opensearch.org/
Depends on https://github.com/opensearch-project/opensearch-ci/pull/260
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #3332 (54bc3a3) into main (0bcc428) will decrease coverage by 0.29%.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##             main    #3332      +/-   ##
==========================================
- Coverage   91.74%   91.46%   -0.29%
==========================================
  Files         172      172
  Lines        4991     4991
==========================================
- Hits         4579     4565      -14
- Misses        412      426      +14

see 2 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Improvements

Closes #

BalDatepicker prop min do not seem to works #306
BalDatepicker fail because allowedDates is not a function #305
useField return "field is not valid" when the helper validators() is not used #309
BalSelect fail if data is set to undefined #304
bal-radio swap label content that is between tag (first become last) #303

Thanks a lot!


Cleaned Commits for Unit Tests, added testing suites to deps

Only tested functionality is UI side - Specifically nesting group order/functionality

Sorry for the delay on this... testing should have been a part of this a while ago.
I appreciate this PR very much. Let's get tests to this library!


Move top right toasts to bottom right

Having toasts in the top right prevents you from being able to click on the links in the nav bar until they go away, which is annoying.

:+1:


goto v1027 of pipeline

@bparees @csrwng fyi - has the plugin version for the fix @csrwng needs

[test]

more jenkins rhel failures :(
[test]

(failing job in case you want to look at it: https://ci.openshift.redhat.com/jenkins/job/jenkins/417/console)

hm
-> Re-tagging openshift/jenkins-slave-base-rhel7-candidate image to openshift/jenkins-slave-base-rhel7
unknown shorthand flag: 'f' in -f
See 'docker tag --help'.
might be caused by the docker1.12 update @danmcp just noted.  we may have to remove that flag from the vagrant plugin.

@bparees You will.

@gabemontero you'll need to rebase on top of https://github.com/openshift/jenkins/pull/176 to get this PR to pass testing.

this should be able to pass now, w/ a rebase.

rebased
[test]
but most likely will cut new version of plugin based on https://github.com/openshift/jenkins-plugin/pull/102, and will then tweak this to go to v1.0.28

actually I think we will be OK .... will elaborate at https://github.com/openshift/jenkins-plugin/pull/102

So just to summarize on the latest code, the "triggered in jenkins" annotations occur:

on the Build object here, whenever a build is triggered
on the ReplicationController object here, whenever a deployment is triggered
on the ReplicationController object here, whenever the user selects to verify after triggering a build that deployments listening for the build output image in fact triggered

test job passed ...merging


nvALT does not respect OSX highlight color

I've chosen a lovely pink as my OSX highlight color (System Preferences -> General -> Highlight color), but the edit window in nvALT uses a drab grey highlight color.
The search bar does show the pink highlight color.
Interestingly – I have not checked all colors, but if I switch to blue or red, it does use that color, but green turns grey as well.
I'm on OSX Sierra (10.12.3 (16D32)), with nvALT at Version 2.2.7 (126).

I can confirm that on macOS 10.12.2 and nvALT 2.2.6, text is also highlighted in gray and not the system highlight color.


DynamicCam's error message after Elvui AFK screen

Hi,
Since the first pre-patch update from Dragonflight, I have this error message when I go back from the afk screen from Elvui. I can't see my UI. It can be "fix" when I mount or dismount.

270x Interface/AddOns/DynamicCam/UiHideModule.lua:445: Usage: self:SetIgnoreParentAlpha(ignore)
[string "=[C]"]: in function SetIgnoreParentAlpha' [string "@Interface/AddOns/DynamicCam/UiHideModule.lua"]:445: in function <Interface/AddOns/DynamicCam/UiHideModule.lua:435> [string "@Interface/AddOns/DynamicCam/UiHideModule.lua"]:475: in function <Interface/AddOns/DynamicCam/UiHideModule.lua:472> [string "@Interface/AddOns/DynamicCam/UiHideModule.lua"]:746: in function HideUI'
[string "@Interface/AddOns/DynamicCam/Core.lua"]:653: in function FadeOutUI' [string "@Interface/AddOns/DynamicCam/Core.lua"]:1161: in function ChangeSituation'
[string "@Interface/AddOns/DynamicCam/Core.lua"]:964: in function `EvaluateSituations'
[string "@Interface/AddOns/DynamicCam/Core.lua"]:163: in function <Interface/AddOns/DynamicCam/Core.lua:153>
Locals:
(*temporary) = Button {
0 =
glow = Texture {
}
OnPostShow =  defined @Interface/FrameXML/AlertFrameIntrinsic.lua:4
SetExternallyManagedOutroAnimation =  defined @Interface/FrameXML/AlertFrameIntrinsic.lua:28
Shield = Frame {
}
SetAlertContainer =  defined @Interface/FrameXML/AlertFrameIntrinsic.lua:12
SetAlpha =  defined =[C]:-1
Name = FontString {
}
ludius_collected = true
Background = Texture {
}
Icon = Frame {
}
GuildBanner = Texture {
}
backdrop = Frame {
}
waitAndAnimOut = AnimationGroup {
}
hooked = true
GuildBorder = Texture {
}
id = 13477
alertContainer = AlertFrame {
}
Unlocked = FontString {
}
queue =  {
}
animIn = AnimationGroup {
}
OnManagedAlertFrameVisibilityChanged =  defined @Interface/FrameXML/AlertFrameIntrinsic.lua:20
GetAlertContainer =  defined @Interface/FrameXML/AlertFrameIntrinsic.lua:16
GuildName = FontString {
}
OnPostHide =  defined @Interface/FrameXML/AlertFrameIntrinsic.lua:8
ManagesOwnOutroAnimation =  defined @Interface/FrameXML/AlertFrameIntrinsic.lua:24
shine = Texture {
}
ludius_ignoreParentAlphaBeforeFadeOut = false
}
(*temporary) = nil

I went back to the version bellow. No problem anymore, but the option's mode doesn't have Y axe value setting. My caracter is too low on my screen now.

I will wait next addon update to have more option.

Well, glad it now works with the current DynamicCam-2.0.0.zip. :-)
Let me know, if you are experiencing this issue again. Thanks for reporting it anyway.

With pleasure. Ty for your hard work! This addon is great :)

The problem is back. (version: DynamicCam-2.0.1.zip)
1x Interface/AddOns/DynamicCam/UiHideModule.lua:446: Usage: self:SetIgnoreParentAlpha(ignore)
[string "=[C]"]: in function SetIgnoreParentAlpha' [string "@Interface/AddOns/DynamicCam/UiHideModule.lua"]:446: in function <Interface/AddOns/DynamicCam/UiHideModule.lua:436> [string "@Interface/AddOns/DynamicCam/UiHideModule.lua"]:476: in function <Interface/AddOns/DynamicCam/UiHideModule.lua:473> [string "@Interface/AddOns/DynamicCam/UiHideModule.lua"]:747: in function HideUI'
[string "@Interface/AddOns/DynamicCam/Core.lua"]:653: in function FadeOutUI' [string "@Interface/AddOns/DynamicCam/Core.lua"]:1166: in function ChangeSituation'
[string "@Interface/AddOns/DynamicCam/Core.lua"]:969: in function `EvaluateSituations'
[string "@Interface/AddOns/DynamicCam/Core.lua"]:163: in function <Interface/AddOns/DynamicCam/Core.lua:153>
Locals:
(*temporary) = Button {
0 =
ItemName = FontString {
}
OnPostShow =  defined @Interface/FrameXML/AlertFrameIntrinsic.lua:4
Label = FontString {
}
BGAtlas = Texture {
}
SetAlertContainer =  defined @Interface/FrameXML/AlertFrameIntrinsic.lua:12
SetExternallyManagedOutroAnimation =  defined @Interface/FrameXML/AlertFrameIntrinsic.lua:28
hyperlink = "|cff1eff00|Hitem:166846::::::::60:258:::::::::|h[Pièces détachées]|h|r"
ludius_collected = true
Background = Texture {
}
waitAndAnimOut = AnimationGroup {
}
glow = Texture {
}
RollValue = FontString {
}
RatedPvPBackground = Texture {
}
lootItem = Frame {
}
RollTypeIcon = Texture {
}
UpdateTooltip =  defined @Interface/FrameXML/AlertFrameSystems.lua:421
PvPBackground = Texture {
}
queue =  {
}
animIn = AnimationGroup {
}
shine = Texture {
}
GetAlertContainer =  defined @Interface/FrameXML/AlertFrameIntrinsic.lua:16
alertContainer = AlertFrame {
}
OnPostHide =  defined @Interface/FrameXML/AlertFrameIntrinsic.lua:8
ManagesOwnOutroAnimation =  defined @Interface/FrameXML/AlertFrameIntrinsic.lua:24
OnManagedAlertFrameVisibilityChanged =  defined @Interface/FrameXML/AlertFrameIntrinsic.lua:20
ludius_ignoreParentAlphaBeforeFadeOut = false
}
(*temporary) = nil

Could you please check if this still happens with 2.0.2, I just uploaded?
Is using Elvui the only way to reproduce this error?
If so, I will check it out over the weekend.

Yes, of course!
The problem remains, sadly.
1x Interface/AddOns/DynamicCam/UiHideModule.lua:475: Usage: self:SetIgnoreParentAlpha(ignore)
[string "=[C]"]: in function SetIgnoreParentAlpha' [string "@Interface/AddOns/DynamicCam/UiHideModule.lua"]:475: in function <Interface/AddOns/DynamicCam/UiHideModule.lua:465> [string "@Interface/AddOns/DynamicCam/UiHideModule.lua"]:505: in function <Interface/AddOns/DynamicCam/UiHideModule.lua:502> [string "@Interface/AddOns/DynamicCam/UiHideModule.lua"]:776: in function HideUI'
[string "@Interface/AddOns/DynamicCam/Core.lua"]:669: in function FadeOutUI' [string "@Interface/AddOns/DynamicCam/Core.lua"]:1191: in function ChangeSituation'
[string "@Interface/AddOns/DynamicCam/Core.lua"]:994: in function `EvaluateSituations'
[string "@Interface/AddOns/DynamicCam/Core.lua"]:163: in function <Interface/AddOns/DynamicCam/Core.lua:153>
Locals:
(*temporary) = Button {
0 =
ItemName = FontString {
}
OnPostShow =  defined @Interface/FrameXML/AlertFrameIntrinsic.lua:4
Label = FontString {
}
BGAtlas = Texture {
}
SetAlertContainer =  defined @Interface/FrameXML/AlertFrameIntrinsic.lua:12
SetExternallyManagedOutroAnimation =  defined @Interface/FrameXML/AlertFrameIntrinsic.lua:28
hyperlink = "|cff0070dd|Hcurrency:1807:500|h[Recommandation de la cour des Moissonneurs]|h|r"
ludius_collected = true
Background = Texture {
}
isCurrency = true
waitAndAnimOut = AnimationGroup {
}
glow = Texture {
}
RollValue = FontString {
}
RatedPvPBackground = Texture {
}
lootItem = Frame {
}
RollTypeIcon = Texture {
}
UpdateTooltip =  defined @Interface/FrameXML/AlertFrameSystems.lua:421
PvPBackground = Texture {
}
queue =  {
}
animIn = AnimationGroup {
}
shine = Texture {
}
GetAlertContainer =  defined @Interface/FrameXML/AlertFrameIntrinsic.lua:16
alertContainer = AlertFrame {
}
OnPostHide =  defined @Interface/FrameXML/AlertFrameIntrinsic.lua:8
ManagesOwnOutroAnimation =  defined @Interface/FrameXML/AlertFrameIntrinsic.lua:24
OnManagedAlertFrameVisibilityChanged =  defined @Interface/FrameXML/AlertFrameIntrinsic.lua:20
ludius_ignoreParentAlphaBeforeFadeOut = false
}
(*temporary) = nil

So with ElvUI enabled, it happens reliably every time you exit the AFK screen/situation?

Yes. I don't have the problem with Elvui desactivated.
I think I found the problem. It seems the be linked with the AFK situation of DynamicCam.
-->I disable the situation "AFK [Priority: 120]" and it solved the problem with Elvui.

I just installed ElvUI 13.04 (ElvUI, ElvUI_Libraries, ElvUI_Options) and still cannot reproduce this error. Going in and out of AFK with the DynamicCam situation enabled works just fine. Did you make any ElvUI settings that deviate from its stock settings, which I could try?

Did the same (installed Elvui 13.04) and I haven't the problem anymore. (I was on the 13.02 before).
If you want I can wait for the next Elvui's update to see if the error message comes back,
After this, I think I will just disable the AFK situation. It's not usefull for me with Elvui.

Hm, do you still have the 13.02 zip file, so I could reproduce the error? It seems like other addon combinations are triggering it too, but so far no one named the other addons I would have to combine DynamicCam with to evoke it. Unfortunately ElvUI does not seem to have an online archive of their older versions.

Yeah sure! I have the v12.99 too (which was the first I had this problem with (except error)).
To which e-mail address do you want me to send them?

<EMAIL_ADDRESS>please.

I think I fixed this with 2.0.5.
Let me know if it pops up again.

Great! Thank you :)


Python 3 transition

(I am not comfortable even opening this P/R, but I guess we should do this eventually)
As of 2020, Python 2 is no longer maintained. Package registries are working for now, but new software should use Python 3 instead.
This is concerning for us, since Clever (Clover?) is an educational platform, and teaching how to use deprecated tools is not our goal. As such, we are transitioning to Python 3.
This transition is somewhat complicated:

ROS Melodic still uses Python 2;
ROS Noetic is not out yet (and will probably only be ready by summer);
not all packages support Python 3.

I've done some preparations for Python 3 (for example, I've built our dependencies against it, patching as required). There are still some issues to be resolved, though:

[x] Butterfly should be running from a virtual environment (may be resolved by patching rosbridge_suite) (UPDATE: May be worked around by using an older tornado version) Butterfly runs like before, it just uses an older Tornado version;
[ ] rosbridge_suite does not work with Python 3 (UPDATE: Should be fixed by https://github.com/RobotWebTools/rosbridge_suite/pull/460) (UPDATE 2: We are using a patched build that should work);
[x] cv_bridge seems to work after applying these patches: https://github.com/ros-perception/vision_opencv/pull/312;
[x] python-opencv is not getting installed (since it's not required anywhere) python-opencv is installed explicitly;
[x] native tests are failing because of #!/usr/bin/env python3 shebangs All tests now use ros_pytest, which selects the correct interpreter automatically;
[ ] documentation needs to be updated (mainly the usage of print statements in Python)

This is still a work-in-progress, but we should perform regular builds from this branch and try using them. This needs to be thoroughly tested before merge.

@okalachev, this P/R drops ROS support for Python 2 completely (for reasons stated elsewhere). python-opencv is just no longer a dependency of anything, we could re-add it manually though.

Regarding rosbridge_suite: I've sent them a pull request to add Python 3 compatibility. Might still be rough around the edges, but at the very least it works for our web visualizations: https://github.com/RobotWebTools/rosbridge_suite/pull/460

Regarding our failing (native) tests: Looks like we need to use some hacks to be both Python2- and Python3-compatible. The ROS way is to use Python2 shebangs (#!/usr/bin/env python) and let catkin take care of everything (see http://wiki.ros.org/UsingPython3/SourceCodeChanges#Changing_shebangs), but that requires:

adding catkin_install_python() for all of our Python scripts;
actually using install space instead of devel space (if I understand correctly, of course).

Using install space is a no-go (at least in my opinion), at the very least this will make changing .launch files a pain.
One possible thing would be to invoke our Python scripts from shell scripts that would test for ROS_PYTHON_VERSION == 3 and select proper interpreter. Not a clean way to do anything, but if anyone has other ideas, they are very welcome to contribute them!

Work goes in #327.


Utkarsh pro/meshery/kubernetes service scan

Description
This PR adds dropdown select for both grafana and prometheus configuration menu. Along with that it adds minor bug fixes for proper filtering of pods in kubernetes_scan.go.
Following is the comparison for the proposed change in ScanKubernetes function:

Pros
Cons

Better filtering of pods, in the previous approach  identifying pods based on container images created  ambiguity as some pods have containers from different meshes (eg. Linkerd pods)
Matching on names can be problematic if someone deploys a pod with name similar to a pod created by a service mesh. (eg. someone creates a pod istio-test)

PR also adds a function to scan services based on names which is used to scan prometheus and grafana but does not replaces  detectServiceForDeployementImage. Although detectServiceForDeployementImage is no longer being used anywhere else.
Relevant screenshots:

Additional note: With the current implementation, the drop down displays the urls in the dropdown iff prometheus and grafana services have an allocated external ip (ie external ip must not be in pending state). This was tested on KinD with metallb.
This PR fixes #772
Notes for Reviewers
@leecalcote following issues were addressed:

Add "https" protocol for port 443
Show "NA" if we fail to extract version from the mesh scan rather than "vundefined"
However, error notification needs a few clarifications on my part and could be addressed in a subsequent PRs?

Signed commits

[x] Yes, I signed my commits.

Why we need to scan based on names? Scanning on images is more reliable and extensible.

Why we need to scan based on names? Scanning on images is more reliable and extensible.

@kushthedude

In the initial  implementation we were looking for all of the pods inside the deployments and filtering them based on the container images. But this approach used to miss out any pod that was not a part of a deployment (as far as I remember, it was significant in case of nsm).
I replaced the previous implementation with an implementation which is analogous to kubectl get pods -A by which we could access all of the pods and I was filtering based on container images inside the pod. The problem with filtering based on image names emerged when I realized that some of the linkerd pods have istio based containers too which was increasing ambiguity.
In the final code that I have just pushed, I am matching/filtering based on the names of the pods this removes the container images ambiguity and returns all of the pods but will be problematic if someone manually deploys a pod with similar names to the pods deployed by a service mesh, for eg linkerd-test.

I couldn't figure out a better alternative :sweat_smile:

Why we need to scan based on names? Scanning on images is more reliable and extensible.

@kushthedude

In the initial  implementation we were looking for all of the pods inside the deployments and filtering them based on the container images. But this approach used to miss out any pod that was not a part of a deployment (as far as I remember, it was significant in case of nsm).

Then NSM may move away from this approach soon, pods and its count are controller by the deploymentSets. Sp querying the deployment images is not a bad approach but yet more efficient than kgp -A .

I replaced the previous implementation with an implementation which is analogous to kubectl get pods -A by which we could access all of the pods and I was filtering based on container images inside the pod. The problem with filtering based on image names emerged when I realized that some of the linkerd pods have istio based containers too which was increasing ambiguity.

Can you share the containerImages names of linkerd which were creating issues? Also if few linkerd deployments have istio containerImages then what is the ambiguity here since they are part of different mesh deployments?

In the final code that I have just pushed, I am matching/filtering based on the names of the pods this removes the container images ambiguity and returns all of the pods but will be problematic if someone manually deploys a pod with similar names to the pods deployed by a service mesh, for eg linkerd-test.

Wont be needed if the above points are addressed.

Why we need to scan based on names? Scanning on images is more reliable and extensible.

@kushthedude

In the initial  implementation we were looking for all of the pods inside the deployments and filtering them based on the container images. But this approach used to miss out any pod that was not a part of a deployment (as far as I remember, it was significant in case of nsm).

Then NSM may move away from this approach soon, pods and its count are controller by the deploymentSets. I dont know if maintaing bare pods without deployments has any advantage, So querying the deployment images is not a bad approach but yet more efficient than kgp -A .

Oh no, I did not mean bare pods. I meant pods created by daemonset, which both consul and nsm do. Kind of new to this so I am not sure if we should be showing them.
Also, I thought that kgp -A would be more efficient than the previous implementation as the previous implementation used to first query all the namespaces then all the deployments and then used to get all the pods. Where as right now it's a single query to /api/v1/pods. Again, I am not sure if internally this is an expensive call, I considered lowering number of calls and nested loops only.

I replaced the previous implementation with an implementation which is analogous to kubectl get pods -A by which we could access all of the pods and I was filtering based on container images inside the pod. The problem with filtering based on image names emerged when I realized that some of the linkerd pods have istio based containers too which was increasing ambiguity.

Can you share the containerImages names of linkerd which were creating issues? Also if few linkerd deployments have istio containerImages then what is the ambiguity here since they are part of different mesh deployments?

I think I couldn't clarify in my previous comment, I meant that I was already querying only for the pods (kgp -A) so when I was comparing the container images in those pods, some of the linekrd pods had istio images. Example is linkerd-controller (It took me several hours to reproduce this issue though, steps followed: Deploy istio, prometheus, grafana, linkerd latest).
Sample json response of kubernetes api server to /api/v1/pods
sample_response.zip

I think you gents hashed through the logic as to why changing to a pod name approach solves some problems. Efficiency isn't a concern in MeshSync v1, but is addressed in the v2 architecture instead.

I think the only outstanding item on this PR is that of including logic for HTTPS when port 443 is present.

This error is one that we will want to avoid using a toaster notification for.

While we should show the user this error, this error is one that we will want to avoid using a toaster notification for. Instead what we should aim for is incorporating badges into Meshery's use of chips (https://material-ui.com/components/badges/).

Let's avoid including the hardcoded "v" when MeshSync is unable to retrieve a version number.

The comments that I've noted on this PR can either be addressed in this PR or turned into issues to be addressed in subsequent PR(s).

@leecalcote I'll address them in my subsequent commits in the same PR.

@utkarsh-pro the new changes look good. I came across another issue:

Expect to see http://localhost:9000.
Output from /api/prometheus/scan:
{
   "prometheus":[
      {
         "metadata":{
            "name":"prometheus",
            "namespace":"istio-system",
            "selfLink":"/api/v1/namespaces/istio-system/services/prometheus",
            "uid":"69388fc2-4ed4-4494-a747-a674892814d4",
            "resourceVersion":"473127",
            "creationTimestamp":"2020-11-16T02:34:02Z",
            "labels":{
               "app":"prometheus",
               "chart":"prometheus-11.7.0",
               "component":"server",
               "heritage":"Helm",
               "release":"prometheus"
            },
            "managedFields":[
               {
                  "manager":"kube-vpnkit-forwarder",
                  "operation":"Update",
                  "apiVersion":"v1",
                  "time":"2020-11-16T02:34:02Z"
               },
               {
                  "manager":"meshery-istio",
                  "operation":"Update",
                  "apiVersion":"v1",
                  "time":"2020-11-16T02:34:02Z"
               }
            ]
         },
         "spec":{
            "ports":[
               {
                  "name":"http",
                  "protocol":"TCP",
                  "port":9090,
                  "targetPort":9090,
                  "nodePort":32603
               }
            ],
            "selector":{
               "app":"prometheus",
               "component":"server",
               "release":"prometheus"
            },
            "clusterIP":"<IP_ADDRESS>",
            "type":"LoadBalancer",
            "sessionAffinity":"None",
            "externalTrafficPolicy":"Cluster"
         },
         "status":{
            "loadBalancer":{
               "ingress":[
                  {
                     "hostname":"localhost"
                  }
               ]
            }
         }
      },
      {
         "metadata":{
            "name":"osm-prometheus",
            "namespace":"osm-system",
            "selfLink":"/api/v1/namespaces/osm-system/services/osm-prometheus",
            "uid":"bc1e4605-f38f-4f99-b85a-1ad16ea191c2",
            "resourceVersion":"14009",
            "creationTimestamp":"2020-11-13T01:49:49Z",
            "labels":{
               "app.kubernetes.io/managed-by":"Helm"
            },
            "annotations":{
               "meta.helm.sh/release-name":"osm",
               "meta.helm.sh/release-namespace":"osm-system",
               "prometheus.io/port":"7070",
               "prometheus.io/scrape":"true"
            },
            "managedFields":[
               {
                  "manager":"Go-http-client",
                  "operation":"Update",
                  "apiVersion":"v1",
                  "time":"2020-11-13T01:49:49Z"
               }
            ]
         },
         "spec":{
            "ports":[
               {
                  "protocol":"TCP",
                  "port":7070,
                  "targetPort":7070
               }
            ],
            "selector":{
               "app":"osm-prometheus"
            },
            "clusterIP":"<IP_ADDRESS>",
            "type":"ClusterIP",
            "sessionAffinity":"None"
         },
         "status":{
            "loadBalancer":{

            }
         }
      }
   ]
}

Additional details:
http://undefined:9090 also shows when only the Istio instance of Prometheus is deployed as type LoadBalancer with a value of localhost.

@leecalcote, unfortunately initially I didn't consider hostname while creating the urls. I think the recent push should have fixed that. Can you please test the latest push as I don't have a system to test hostname on my system (kind + metallb)?
I have also now included clusterIP based urls now,

Looking good, @utkarsh-pro. I’m kicking off the build again with @kushthedude having fixed it.

@leecalcote, I am not sure why golang lint is failing although nothing in golang has really changed in this commit. I have also tested it locally by running golangci-lint run and it seemed to work fine.

Will publish into Meshery Edge release channel now...


	Cannot read property 'length' of undefined	 	316
2.	Object #<LazyRelayOutReq> has no method 'onTimeout'	 	178
3.	Cannot call method 'cancel' of null	 	4
4.	Object #<LazyRelayInReq> has no method 'onTimeout'         2

cc @jcorbin

Working on this in  https://github.com/uber/tchannel-node/pull/37

is https://github.com/uber/tchannel-node/commit/6e6f52706f18f368e0ae7b6306d93505c8f7e28f

and 4. are https://github.com/uber/tchannel-node/commit/ccb39cd26a1f396aeb9fc756271401922b7479ab

We've decided that 3. is Not A Thing ™, and are chalking it up to state corruption caused by one of the other uncaughts mentioned here.

We've also seen:
TypeError: Object #<LazyRelayOutReq> has no method 'emitError'
    at eachOutOp (.../tchannel/connection.js:606:13)
...

now fixed in mentioned PR.

Related #31 will be solved separately.


$sample: Handle case of sample > collection / performance improvements

See commit messages for details

Thanks for your work !

great, thanks !


scope of this repo?

Bin, what is the scope of this repository?
There is a bunch of ETL code that lives in the nmdc-metadata and nmdc-server repos, that is potentially looking for a shared home, as much of the code is midstream between metadata definition / publishing of the schema upstream, and dissemination of processed metadata on the data portal downstream.
cc @cmungall @jeffbaumes

The scope of this repository is really loosely defined. One can define it as a Python package and library to generate and validate nmdc workflow JSON data against the NMDC data schema. It came out from the need to convert genome annotation in GFF format to JSON for downstream data ingestion. I also thought about future extension to include workflow testing/validation and other functionalities to support users to manage and run NMDC workflows in their own environment through command line. But that is just a thought and out of scope of the current project SOW. Perhaps something to include in FY 23 proposal.


HarfBuzz: Update to version 3.5.1

Update to the latest release:  https://github.com/harfbuzz/harfbuzz/releases/tag/5.3.1

Seems like you wrote the wrong version in the commit.


fill missing bootnodes + a few helper scripts for determining missing entries

following bootnode entries still missing
"asset-hub-kusama: Missing bootnodes for [\"radiumblock\"]"
"asset-hub-paseo: Missing bootnodes for [\"gatotech\",\"helikon\",\"luckyfriday\",\"metaspan\",\"stakeplus\",\"turboflakes\",\"polkadotters\"]"
"asset-hub-polkadot: Missing bootnodes for [\"radiumblock\",\"luckyfriday\"]"
"asset-hub-westend: Missing bootnodes for [\"radiumblock\",\"luckyfriday\"]"
"bridge-hub-kusama: Missing bootnodes for [\"radiumblock\"]"
"bridge-hub-polkadot: Missing bootnodes for [\"amforc\",\"helikon\",\"luckyfriday\",\"metaspan\",\"radiumblock\",\"stakeplus\",\"turboflakes\"]"
"bridge-hub-westend: Missing bootnodes for [\"amforc\",\"helikon\",\"luckyfriday\",\"metaspan\",\"radiumblock\",\"stakeplus\",\"turboflakes\"]"
"collectives-polkadot: Missing bootnodes for [\"radiumblock\"]"
"collectives-westend: Missing bootnodes for [\"luckyfriday\",\"radiumblock\"]"
"coretime-kusama: Missing bootnodes for [\"amforc\",\"helikon\",\"polkadotters\",\"radiumblock\",\"turboflakes\",\"luckyfriday\"]"
"coretime-westend: Missing bootnodes for [\"amforc\",\"polkadotters\",\"turboflakes\"]"
"encointer-kusama: Missing bootnodes for [\"dwellir\",\"luckyfriday\",\"radiumblock\"]"
"kusama: Missing bootnodes for [\"luckyfriday\",\"radiumblock\"]"
"paseo: Missing bootnodes for [\"dwellir\",\"luckyfriday\",\"radiumblock\"]"
"people-kusama: Missing bootnodes for [\"amforc\",\"dwellir\",\"gatotech\",\"helikon\",\"luckyfriday\",\"metaspan\",\"polkadotters\",\"radiumblock\",\"rotko\",\"stakeplus\",\"turboflakes\"]"
"people-westend: Missing bootnodes for [\"luckyfriday\"]"
"polkadot: Missing bootnodes for [\"luckyfriday\",\"radiumblock\"]"
"westend: Missing bootnodes for [\"dwellir\",\"luckyfriday\",\"radiumblock\"]"

missing entries from official repositories(polkadot-sdk / encointer / paseo runtime)
"asset-hub-paseo: Missing bootnodes for [\"gatotech\",\"helikon\",\"luckyfriday\",\"metaspan\",\"turboflakes\",\"polkadotters\"]"
"asset-hub-westend: Missing bootnodes for [\"luckyfriday\"]"
"bridge-hub-polkadot: Missing bootnodes for [\"amforc\"]"
"bridge-hub-westend: Missing bootnodes for [\"amforc\",\"luckyfriday\"]"
"collectives-westend: Missing bootnodes for [\"luckyfriday\"]"
"coretime-kusama: Missing bootnodes for [\"amforc\",\"helikon\",\"polkadotters\",\"radiumblock\",\"turboflakes\",\"luckyfriday\"]"
"coretime-westend: Missing bootnodes for [\"amforc\",\"polkadotters\",\"turboflakes\"]"
"encointer-kusama: Missing bootnodes for [\"luckyfriday\"]"
"paseo: Missing bootnodes for [\"luckyfriday\",\"radiumblock\"]"
"people-westend: Missing bootnodes for [\"luckyfriday\"]"