Python VS Code unittest Test Runner (visualstudio_py_testlauncher.py) crashing on assertEqual (ConnectionAbortedError and OSError)

Environment data

VS Code version: 1.22.2
Extension version (available under the Extensions sidebar): 2018.3.1
OS and version: Windows 7
Python version (& distribution if applicable, e.g. Anaconda): Python 3.4.4
Type of virtual environment used (N/A | venv | virtualenv | conda | ...): n/a
Relevant/affected Python packages and their versions: PySide, unittest

Actual behavior
If all tests pass, it runs fine. If a single test fails, a ConnectionAbortedError and then a OSError occurs instead.
I'm using unittest for Python 3.4.4 inside VS Code and am encountering some strange test behaviour. Originally I was using Python 3.6 and the tests ran fine, if I ran all tests it would tell me which ones failed and which ones passed, then if I debugged a test with "Uncaught Exceptions" checked it would break where the exception occurred in my program.
I then downgraded to Python 3.4.4 so I could use PySide to create a GUI for my program, everything in my program runs fine apart from my tests. Clicking all tests works fine if all tests pass, however, if just one test fails, "No tests ran, please check the configuration settings for the tests" is displayed in the bottom right hand corner instead (however discover all tests works fine).
If I run a single test, using the lens displayed above the test, that also works fine as long as the tests pass and the tick appears next to it. However if the test fails it displays no tests ran again. When debugging a failing test, it raises a ConnectionAbortedError, here is what is displayed in the Debug Console and doesn't break on the error:
test_simplify_regex_more (test_algorithms.test_kleenes.TestKleeneAlgebra) ... FAIL
ConnectionAbortedError, [WinError 10053] An established connection was aborted by the software in your host machine

If I break just before the assertEqual line, then tick the "All Exceptions" box in the breakpoints dialogue, the following is output on the debug console:
ImportError, No module named 'thread'
test_simplify_regex_more (test_algorithms.test_kleenes.TestKleeneAlgebra) ...
AssertionError, 'b*bb' != 'b*bbb'
- b*bb
+ b*bbb
?     +
FAIL
AttributeError, 'NoneType' object has no attribute '__context__'
AttributeError, 'NoneType' object has no attribute '__context__'
AttributeError, 'NoneType' object has no attribute '__context__'
ConnectionAbortedError, [WinError 10053] An established connection was aborted by the software in your host machine
AttributeError, 'NoneType' object has no attribute '__context__'
OSError, [WinError 10038] An operation was attempted on something that is not a socket

If I break just before the assertEqual line, with only "Uncaught Exceptions" ticked, then step over it (F10), it takes me to line 317 of visualstudio_py_testlauncher.py and closes the debug (I think) socket with this code
finally:
    if cov is not None:
        cov.stop()
        cov.save()
        cov.xml_report(outfile = opts.coverage + '.xml', omit=__file__)
    if _channel is not None:
        _channel.send_event(
            name='done'
        )
        _channel.socket.close()

Which then causes an OSError and this is displayed in the Debug Console
test_simplify_regex_more (test_algorithms.test_kleenes.TestKleeneAlgebra) ... FAIL
ConnectionAbortedError, [WinError 10053] An established connection was aborted by the software in your host machine
OSError, [WinError 10038] An operation was attempted on something that is not a socket

Furthermore, unittest runs fine when ran on the command line with the exact same arguments. This is my settings.json file:
{
    "python.unitTest.unittestEnabled": true,
    "python.unitTest.unittestArgs": [
        "-v",
        "-s",
        "./tests",
        "-p",
        "test_*.py",
    ],
    "python.linting.pylintArgs": [
        "--disable=E0611"
    ],
    "python.unitTest.debugPort": 3005,
}

and my user settings:
{
    "workbench.colorTheme": "Default Light+",
    "window.zoomLevel": -1,
    "debug.inlineValues": true,
    "C_Cpp.intelliSenseEngineFallback": "Disabled",
    "editor.autoClosingBrackets": false,
}

If I run
python -m unittest discover -v -s ./tests -p test_*.py

from the root folder of my project unittest works fine and displays an appropriate x many tests failed, x many errors type message (here is a screenshot for clarity)
I just can not for the life of me figure out to fix this. I tried uninstalling python and vs code, installing python 3.4.4 and then vs code in case VS Code was still configured to Python 3.6 at all but that didn't work and I've messed with my settings.json file numerous times to no avail. I've searched for any answer similar to mine but I can't find anything that works! I'm not sure if this is indeed a bug or something is misconfigured but I cannot figure it out and have tried asking this question on StackOverflow but received no response so I am trying here.
Expected  behavior
When running unittest from inside VS Code, the tests should be run and a log of which tests passed and failed should be displayed.
Steps to reproduce:
Open VS Code and run all tests, with at least one test failing.
Logs
Output from Console under the Developer Tools panel (toggle Developer Tools on under Help)
[Extension Host] Error: read ECONNRESET

Please could you test this once again with the current developer build of the extension?

Just download the file
Uninstall the current python extension
Install from VS Code using the Install from VSIX command
(instructions can be found here)

If that still fails, please could you provide a sample repo or some sample we could to replicate at our end.


Done markers: Match done at start of newline, and also "fixed"

When we have a third word I'll pull out a nicer structure than repetition of the regex

LGTM


Orientation Listener don't work

OrientationListener didn't do the job I believe

What do you mean by didn't do the job?

@BruceHammerTech , if you want someone to help you then you have to provide at least some info about your case. Opening an issue just to open an issue is... at least depressing :)

BruceHammerTech is one of my accounts. I opened this issue.  The problem I found out is that even I have OrientationListener attach to the screen. The screen will not be responsive when I rotate the screen. For example, if <Box style={{width: wp('80%')}} /> . If I rotate it from landscape to portrait. The box component will exceed the screen.

@BruceSuperProgramer do you have sample project to reproduce your issue?

Hi guys, I just tested the orientation feature from the example project listed in this git repository. I found that it looks like not working properly in the simulator because when we click rotate button on the simulator found the simulator rotated but the screen seems didn't responsive change to fit the orientation direction.

But if you test it again on an iPad real device, you will find it working perfectly. As this working on a real iPad,  so I think it is not a bug. Please close this issue, thanks.


Create user service

Ticket
N/A
Changes

Created services directory with users
Separated create_user, get_user, and patch_user functions into separate files
Created api/route/models directory for API models
Moved user API models into api/route/models/user.py

Context for reviewers

Part of a set of changes to separate service and controller-level concerns
Next: user service takes API objects as inputs (eg UserParams), returns db objects as output (eg User instead of UserResponse)

Testing
N/A

So far looking good. Could you say a few words about the end state you're imagining?

Sure thing!
This PR:

Separate user service logic into services/users module, from route module

Shorter term:

Update user service module to be independent of controller concerns (eg no ApiContext, no UserResponse)
Add tests for main user service functions (focus our testing on services module instead of routes)
Create a README that outlines the purpose of the routes and services modules

Longer term:

Separate db / persistence logic out from user service module into its own layer
Create another set of REST endpoints, something like UserData, to further establish the above into a pattern

@lorenyu Do you want me to include the above somewhere? Maybe in a git issue?

@zelgadis sure maybe create some tickets for those

Nit - what are your thoughts on service / user instead of plural? IMHO using singular matches the contents, makes the import read better (import service.user) and avoids dealing with the different ways that English does plural (addresses, children, taxes, etc.)

@jamesbursa what about services/user? I think user makes sense, but I think pluralizing services makes sense since it's more of a directory of services. We can do from services import user or import services.user.
Other options: services/user_service or services/user_services?


Question regarding --ignore

Hi Max,
is it possible to define an inverted list with --ignore, i.e. instead of
--ignore google.com -> disregard google.com content via Port 443
define something like
--ingore (ignore everything except for mySite.com and myOtherSite.com)
Cheers
Gordon

Hi @gfrench17,
you can use a negative lookahead in the regex:
--ignore "^(?!mysite.com)(?!myothersite.com)"
I'll add an example to the docs.
Cheers,
Max

Is this the correct way to open in Terminal?
~$ mitmproxy --ignore "^(?!google\.com)"

but I got this error:
-bash: !google\.com: event not found

and I tried to escape the !:
~$ mitmproxy --ignore "^(?\!google\.com)"

I got this error:
Traceback (most recent call last):
  File "/usr/local/bin/mitmproxy", line 3, in <module>
    mitmproxy()
  File "/Library/Python/2.7/site-packages/libmproxy/main.py", line 89, in mitmproxy
    proxy_config = process_proxy_options(parser, options)
  File "/Library/Python/2.7/site-packages/libmproxy/proxy/config.py", line 196, in process_proxy_options
    ssl_ports=ssl_ports
  File "/Library/Python/2.7/site-packages/libmproxy/proxy/config.py", line 78, in __init__
    self.check_ignore = HostMatcher(ignore_hosts)
  File "/Library/Python/2.7/site-packages/libmproxy/proxy/config.py", line 17, in __init__
    self.regexes = [re.compile(p, re.IGNORECASE) for p in self.patterns]
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/re.py", line 190, in compile
    return _compile(pattern, flags)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/re.py", line 242, in _compile
    raise error, v # invalid expression
sre_constants.error: unexpected end of pattern

please help, thanks.

@ryanzzff: sorry for the late reply - you need to use single quotes. The docs are updated accordingly now.


Authenticated File Upload API Question

First of all, great work you've done with Identity Server. I'm very impressed with the flexibility you've built into the system and the many examples are very helpful.
I've been searching far and wide for an example of uploading a file to an authenticated WebApi. I need to upload from both a native client and a web page. Implementing the native client client will be very straight forward using Bearer tokens to POST the file stream to the WebApi. It's the web page where I'm less certain what to do.
My plan was to host a form with an <input type='file'/> on the web page and set the action to post directly to the WebApi URL. That way the multi-part file contents are sent directly to the WebApi (do not want to upload to the web page's server then have to send the contents to the WebApi).
The problem is how to send the authorization token with the posted form contents? Some options I've considered:

Enable both bearer token and cookie authentication on the WebApi end point. Thus native client uploads with a bearer token and the web page naturally sends its cookie along (web page and WebApi can be made to be in the same domain).  I haven't seen anyone do this, so I'm wondering if this is a bad idea (or even possible).

Web page post with javascript. Getting the token out of the cookie with javascript is out (HTTP-only, right?) so I was thinking the token could be stored in a hidden input field and the javascript could read it and concoct the bearer Authorization header and a post request to the WebApi. I'm not big on javascript (more backend) so I'm not sure this is even a good idea.

Something better?

Any insight would be appreciated.

With XHR2 you can do programmatic file uploads (and thus set the access token as the authorization header). But if you can't use that then just send the token in an input field.

So it sounds like Option 2 is the way to go and if I don't want to worry about browser support I can standardize on sending the token via a hidden input field. If I got any of that wrong feel free to correct me. :)
Thank you for your insight.


Implemented support for custom user types in configuration

Reorganized your code a bit.
Added dependency on TypePreservingCodingAdapter to be able to use custom types with PackageConfig.
Replaced JSONSerialization with JSON Encoder/Decoder.
See for yourself.

Fixes issue #1

@orta looking forward to what you'll say about it.

Now you from any library depending on PackageConfig developers are able to load their configuration like this:
import PackageConfig

let adapter = TypePreservingCodingAdapter()
	.register(aliased: ExampleConfiguration.self)

let example: ExampleConfiguration? = PackageConfig.load(.example, adapter: adapter)

It's not yet working, tested with an external project which depends on PackageConfig.
It fails cause the PackageConfig when running needs to know where to find other libraries to link itself against so that types are present. Will solve this today probably.

Nice one! Yeah, this looks great.
This last problem is interesting, perhaps in the package.swift above you can define a which includes both PackageConfig, and the other target? then the runtime aspect of PackageConfig can guarantee those libs are either in .build/debug or .build/release
Does look very cool though!

@orta actually already solved this in a pretty nice way. Will update and push everything.
Here how the configuration inside Package.swift looks for my library on which i test.

I love that your color scheme in Xcode-y features completely throws my intuition off, looks good!


Update PUT behaviour for ReqMgrAux APIs; use PUT method for updating CMSSW releases - wma branch

wmagent branch version of
https://github.com/dmwm/WMCore/pull/9250  Update PUT behaviour for ReqMgrAux APIs; use PUT method for updating CMSSW releases
We can patch the agents before the production ugprade.

 Fix #9255 - Update PUT behaviour for ReqMgrAux APIs; use PUT method for updating CMSSW releases


Title Element

Title Element
User Story
AS A marketing agency
I WANT a codebase that follows accessibility standards
SO THAT our own site is optimized for search engines
Acceptance Criteria
GIVEN a webpage meets accessibility standards
WHEN I view the title element
THEN I find a concise, descriptive title

Updated Title Element with concise, descriptive title


After applying an analysis, it offers you to create it instead of apply changes

STR

Create a map with a layer of points (layer A).
Go to the builder.
Apply a simple style to the layer A.
Add a buffer analysis over that layer A.
Apply a radius 40 meters.
Go to style again, style should be reseted.
Apply a simple one and change the color.
Go to the CartoCSS panel and change the polygon-fill to red, for example, apply changes.
Go back to analyses tab and check that the analysis already applied is offering Create instead of  Apply.

Reported by @saleiva

After testing with @makella a little bit, we have discovered that this happens when a new analysis is added. I feel this is pretty important.

I'll look into it next

Not only then, It's also happening if you...
Create a dataset with points
Apply a cluster analysis
Go to Style
Style by value
go back to analysis.
It says CREATE instead of APPLY, and the parameters are reset to defaults.


Add summary view of all expenses and outstanding balances

As a user, I want to view a summary of all expenses and outstanding balances within the shared group, so that I can quickly see who owes what and who has overpaid.

This is a story under Epic #2.


Performance on CartPole-v0

Hi Ku. I try to use discrete sac on CartPole-v0 with some modifications on the env.py and use fc in model.py. However, I found it failed to achieve reasonable results like getting ~200 reward. Do you have any idea why dsac failed on my code?
I list all changes here: (mark changes with #)
# in env.py
def make_gym(env_id):
    env = gym.make(env_id)
    return env

def make_pytorch_env(env_id, episode_life=True, clip_rewards=True,
                     frame_stack=True, scale=False):
    env = make_gym(env_id)
    return env

# in sacd.py
    def explore(self, state):
        # Act with randomness.
        state = torch.ByteTensor(
            state[None, ...]).to(self.device).float()#
        with torch.no_grad():
            action, _, _ = self.policy.sample(state)
        return action.item()

    def exploit(self, state):
        # Act without randomness.
        state = torch.ByteTensor(
            state[None, ...]).to(self.device).float()#
        with torch.no_grad():
            action = self.policy.act(state)
        return action.item()

# in model.py
class DQNBase(BaseNetwork):

    def __init__(self, num_channels):
        super(DQNBase, self).__init__()

        self.net = nn.Sequential(
            nn.Linear(num_channels, 64),  #
            nn.ReLU(),
            nn.Linear(64, 64), #
            nn.ReLU(),
            nn.Linear(64, 32), #
            nn.ReLU(),
            Flatten(),
        ).apply(initialize_weights_he)

    def forward(self, states):
        return self.net(states)

class QNetwork(BaseNetwork):

    def __init__(self, num_channels, num_actions, shared=False,
                 dueling_net=False):
        super().__init__()

        if not shared:
            self.fc = DQNBase(num_channels)

        if not dueling_net:
            self.head = nn.Sequential(
                nn.Linear(32, 32),#
                nn.ReLU(inplace=True),
                nn.Linear(32, num_actions))#
        else:
            self.a_head = nn.Sequential(
                nn.Linear(32, 32),#
                nn.ReLU(inplace=True),
                nn.Linear(32, num_actions))#
            self.v_head = nn.Sequential(
                nn.Linear(32, 32),#
                nn.ReLU(inplace=True),
                nn.Linear(32, 1))#

        self.shared = shared
        self.dueling_net = dueling_net

    def forward(self, states):
        if not self.shared:
            states = self.fc(states)#

        if not self.dueling_net:
            return self.head(states)
        else:
            a = self.a_head(states)
            v = self.v_head(states)
            return v + a - a.mean(1, keepdim=True)

class CateoricalPolicy(BaseNetwork):

    def __init__(self, num_channels, num_actions, shared=False):
        super().__init__()
        if not shared:
            self.fc = DQNBase(num_channels)

        self.head = nn.Sequential(
            nn.Linear(32, 32),#
            nn.ReLU(inplace=True),
            nn.Linear(32, num_actions))#

        self.shared = shared

    def act(self, states):
        if not self.shared:
            states = self.fc(states)#

        action_logits = self.head(states)
        greedy_actions = torch.argmax(
            action_logits, dim=1, keepdim=True)
        return greedy_actions

    def sample(self, states):
        if not self.shared:
            states = self.fc(states)#

        action_probs = F.softmax(self.head(states), dim=1)
        action_dist = Categorical(action_probs)
        actions = action_dist.sample().view(-1, 1)

        # Avoid numerical instability.
        z = (action_probs == 0.0).float() * 1e-8
        log_action_probs = torch.log(action_probs + z)

        return actions, action_probs, log_action_probs

Hi @YongyiTang92
The code below first casts state into dtype=torch.uint8 then recasts it into dtype=torch.float32, which discards mush information about states.
state = torch.ByteTensor(state[None, ...]).to(self.device).float()

So you should use the code below instead.
state = torch.FloatTensor(state[None, ...]).to(self.device)

Let me know if you still have any problems.

Hi @ku2482
I use the code and got better results, from 9.4 to 30 with per. But it still far from getting 200 reward. I just wonder if dsac failed on this simple task and others like Pong?

Hi @YongyiTang92
I don't think so.
I implemented SAC-Discrete for CartPole for you here.
I assume that target_entropy_ratio=0.98 is too high and it results in low train return.
However, even with target_entropy_ratio=0.98, test return gets around 200 at 30k steps.
Sorry for cluttered codes, but I hope it can help you.

@ku2482 Thank you so much! It helps alot!

I found the difference in the memory.py where I forgot to change the following
‘
state = torch.ByteTensor(state[None, ...]).to(self.device).float()
’

Sorry.
I should have include floatifying and dividing by 255 in the model, not in the trainer nor replay buffer.
Thank you, I could notice it :)

Hi @YongyiTang92
I don't think so.
I implemented SAC-Discrete for CartPole for you here.
I assume that target_entropy_ratio=0.98 is too high and it results in low train return.
However, even with target_entropy_ratio=0.98, test return gets around 200 at 30k steps.
Sorry for cluttered codes, but I hope it can help you.

It helped me, too. 0.98 is too high for CartPole.
Thank you.

Hi @YongyiTang92
The code below first casts state into dtype=torch.uint8 then recasts it into dtype=torch.float32, which discards much information about states.
state = torch.ByteTensor(state[None, ...]).to(self.device).float()

So you should use the code below instead.
state = torch.FloatTensor(state[None, ...]).to(self.device)

Let me know if you still have any problems.

Good evening,
I think it should be committed to getting rid of unnecessary cast.

@VCasecnikovs
Thank you for your suggestion ;)
Actually, I did it on purpose.
It reduces the latency when transferring tensors between GPU and RAM.
In other words, when tensors are big (e.g. images), the cost of redundant casting (convert into "uint8", transfer to GPU, then convert into "float32") is much smaller than the cost of transferring "float32" tensors to GPU.
(Note that it doesn't lose any information only if tensors are images. )
This repository only supports Image inputs (Atari) now, however, I will make it compatible with vector inputs (e.g. CartPole) when I have time :)
Thanks :)

@YongyiTang92 thank you for so fast comment. Your answer makes sense. Have you tried to measure the increase in performance?
Also, I have a more etheric question...
I will try to form it as another issue...
Best regards,
Vadims.


Fix string formatter in FuseIOBench

Fix string formatter that lacks input

Codecov Report

Merging #13901 (3e327fc) into master (e5e53e0) will decrease coverage by 26.32%.
The diff coverage is 1.76%.

@@              Coverage Diff              @@
##             master   #13901       +/-   ##
=============================================
- Coverage     43.75%   17.43%   -26.33%
+ Complexity     9135     2677     -6458
=============================================
  Files          1388     1395        +7
  Lines         80734    81180      +446
  Branches       9823     9874       +51
=============================================
- Hits          35325    14151    -21174
- Misses        42462    65780    +23318
+ Partials       2947     1249     -1698

Impacted Files
Coverage Δ

...ient/journal/RetryHandlingJournalMasterClient.java
0.00% <0.00%> (ø)

...on/src/main/java/alluxio/metrics/EventCounter.java
0.00% <0.00%> (ø)

...a/alluxio/master/journal/DefaultJournalMaster.java
29.41% <0.00%> (-6.31%)
:arrow_down:

...ter/journal/JournalMasterClientServiceHandler.java
33.33% <0.00%> (-12.13%)
:arrow_down:

...alluxio/master/journal/raft/RaftJournalSystem.java
0.00% <0.00%> (-64.84%)
:arrow_down:

...ava/alluxio/cli/fsadmin/journal/QuorumCommand.java
0.00% <0.00%> (ø)

...lluxio/cli/fsadmin/journal/QuorumElectCommand.java
0.00% <0.00%> (ø)

...luxio/cli/fsadmin/journal/QuorumRemoveCommand.java
0.00% <0.00%> (ø)

...main/java/alluxio/stress/fuse/FuseIOOperation.java
0.00% <0.00%> (ø)

...ain/java/alluxio/stress/fuse/FuseIOParameters.java
0.00% <0.00%> (ø)

... and 682 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 634bd32...3e327fc. Read the comment docs.

alluxio-bot, merge this please


[lav] Adds Latvian phone list and updated TSV data

[x] Updated Unreleased in CHANGELOG.md to reflect the changes in code or data.

Closes #321

Some notes on the orthography:

 and <ē> are ambiguous between a mid front vowel (transcribed [e(ː)] or [ɛ(ː)]) and a low front vowel [æ(ː)]
Tone is unmarked, so stressed vowels are three-ways ambiguous (tone does not occur in unstressed syllables)

Some notes on the orthography:

 and <ē> are ambiguous between a mid front vowel (transcribed [e(ː)] or [ɛ(ː)]) and a low front vowel [æ(ː)]
Tone is unmarked, so stressed vowels are three-ways ambiguous (tone does not occur in unstressed syllables)

The tests that require an internet connection are timing out (this happens sometimes). I have to look up how to make them run again but I assume the second run will make this all green.

The tests that require an internet connection are timing out (this happens sometimes). I have to look up how to make them run again but I assume the second run will make this all green.

This is a model of the genre, thanks. LGTM.

What do you mean by that?

This is a model of the genre, thanks. LGTM.

What do you mean by that?

I just mean that it's a good example of what these ought to look like.
On Thu, Jan 21, 2021 at 12:39 PM ajmalanoski<EMAIL_ADDRESS>wrote:

This is a model of the genre, thanks. LGTM.
What do you mean by that?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/kylebgorman/wikipron/pull/322#issuecomment-764818962,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABG4ONLRDFUA3R5VL3HFKLS3BRGPANCNFSM4WNHKRGQ
.

I just mean that it's a good example of what these ought to look like.
On Thu, Jan 21, 2021 at 12:39 PM ajmalanoski<EMAIL_ADDRESS>wrote:

This is a model of the genre, thanks. LGTM.
What do you mean by that?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/kylebgorman/wikipron/pull/322#issuecomment-764818962,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABG4ONLRDFUA3R5VL3HFKLS3BRGPANCNFSM4WNHKRGQ
.

The tests that require an internet connection are timing out (this happens sometimes). I have to look up how to make them run again but I assume the second run will make this all green.

Test flakiness is cleared up, submitting now.

The tests that require an internet connection are timing out (this happens sometimes). I have to look up how to make them run again but I assume the second run will make this all green.

Test flakiness is cleared up, submitting now.

I just mean that it's a good example of what these ought to look like.
…
On Thu, Jan 21, 2021 at 12:39 PM ajmalanoski @.***> wrote: This is a model of the genre, thanks. LGTM. What do you mean by that? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#322 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABG4ONLRDFUA3R5VL3HFKLS3BRGPANCNFSM4WNHKRGQ .

Oh, thanks!

I just mean that it's a good example of what these ought to look like.
…
On Thu, Jan 21, 2021 at 12:39 PM ajmalanoski @.***> wrote: This is a model of the genre, thanks. LGTM. What do you mean by that? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#322 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABG4ONLRDFUA3R5VL3HFKLS3BRGPANCNFSM4WNHKRGQ .

Oh, thanks!


ENG-8873 - Update iOS Min Deployment to 13

Timeout issue on a test, merging because all tests pass on local machine for developers


Cloud: Error: ConnectError: [unknown] Load failed

What's your CLI version?
0.87.2
Description & steps to reproduce

I have added no customization. Just ran a random ethereum-package with no configuration.
Desired behavior
I should be able to run an enclave.
What is the severity of this bug?
Critical; I am blocked and Kurtosis is unusable for me because of this bug.
What area of the product does this pertain to?
Frontend: the Graphical User Interface, including the Enclave Manager

closing this one, because we are tracking it here: https://github.com/kurtosis-tech/kurtosis/issues/2176


Add the web app localization file as a resource to Transifex

I would like to start translating the web app itself (ie. the locales folder). It looks like it’s not on Transifex yet – the Resources group there only contains the survey. Can somebody please add a new resource for the app localization?
At the moment I don’t need any fancy workflow with the strings going automatically back and forth, I just want to load the strings into Transifex, translate them into Czech and create a pull request for the translated version once I’m done.
(As for the file format, the Ruby YAML localization format should be supported out of the box by Transifex.)

@zoul I've added the current locales files, they aren't complete but there it's something to get started with.

Perfect, thanks!


Properly Form the Command string on Windows

Previously, the naive command line construction failed if an argument
contained a space.
Now that the hard work is done, this is an easy fix!

@swift-ci please smoke test

Yay, thanks!


目录安排问题

目录安排比较混乱，好好的入门硬是不在入门那里，给个安装教程就入门了？

目录安排比较混乱，好好的入门硬是不在入门那里，给个安装教程就入门了？

确实 混乱

/language zh

The Chinese version is synchronized with the English upstream version, so if you need to change the site directory structure, the upstream English directory needs to be changed.
Feel free to reopen this issue, preferably in English so that people who review the English upstream version can discuss it.
/close


Mutable structs for writing

Introducing WritableBufferWriter which is basically a stack only WritableBuffer (I know the name is bad) blame @pakrym, it was his idea
Removed methods from WritableBuffer
Refactored flushing logic to share between StreamSocketOutput and SocketOutput

dev
 Method |                       Type |      Mean |    StdDev |      Op/s | Allocated |
------- |--------------------------- |---------- |---------- |---------- |---------- |
 Output |                 LiveAspNet | 4.3396 us | 0.1037 us | 230434.11 |     109 B |
 Output |           PlaintextChunked | 2.9787 us | 0.0988 us | 335713.83 |     107 B |
 Output | PlaintextChunkedWithCookie | 3.4702 us | 0.0898 us | 288165.11 |     112 B |
 Output |        PlaintextWithCookie | 2.7523 us | 0.0529 us | 363336.68 |      71 B |
 Output |       TechEmpowerPlaintext | 2.1249 us | 0.0935 us | 470615.57 |      66 B |

PR
 Method |                       Type |      Mean |    StdErr |    StdDev |      Op/s | Allocated |
------- |--------------------------- |---------- |---------- |---------- |---------- |---------- |
 Output |                 LiveAspNet | 3.9969 us | 0.0463 us | 0.2536 us | 250195.76 |     108 B |
 Output |           PlaintextChunked | 2.7911 us | 0.0105 us | 0.0577 us | 358283.93 |     106 B |
 Output | PlaintextChunkedWithCookie | 3.3504 us | 0.0149 us | 0.0816 us | 298468.79 |     108 B |
 Output |        PlaintextWithCookie | 2.4734 us | 0.0153 us | 0.0836 us | 404294.28 |      66 B |
 Output |       TechEmpowerPlaintext | 1.9231 us | 0.0081 us | 0.0444 us | 519994.78 |      66 B |

/cc @benaadams

WritableBufferWriter belongs to corefxlab

Yes I know this. It'll be added then this will be removed once we like the implementation. The lag time between the 2 repos is restrictive at the moment.
If we like this (and the end to end perf is better). I'll make a PR to corefxlab to add it

Will do this over.


MudNumericField: Change default InputMode for numeric types that require decimals. (#4198)

MudNumericField: Change default InputMode for numeric types that require decimals. (#4198)

Description

Fixes #4198
How Has This Been Tested?

Ran MudBlazor.Docs.Server with a devtunnel to connect an iPhone using Safari browser and checked MudNumericField, MudDataGrid, and MudColorPicker for appropriate updates. Did the same with a Windows machine using Chrome and an Android device using Chrome to make sure there were no other breaking changes.
Also modified the NumericFieldBasicExample.razor to ensure that a user can override the default back to InputMode numeric if they so desired. (Not included in PR, just for testing purposes.)
Type of Changes

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation (fix or improvement to the website or code docs)

Checklist

[X] The PR is submitted to the correct branch (dev).
[X] My code follows the code style of this project.
[X] I've added relevant tests.

I wanted to point out that I did see this mentioned in the contributing guidelines: https://github.com/MudBlazor/MudBlazor/blob/dev/CONTRIBUTING.md#avoid-overwriting-parameters-in-blazor-components
Correct me if I'm wrong, but I don't think this is applicable here because it's being changed in the constructor, so it won't have an issue of re-running when re-rendering. There is also no event for InputModeChanged.
If this does need tackled in a different way though, just let me know.

You probably need to update the xmldoc
https://github.com/MudBlazor/MudBlazor/blob/0abf26dceb177ff4a8e9640046cd6d2849b0a48b/src/MudBlazor/Components/NumericField/MudNumericField.razor.cs#L404-L405

Correct me if I'm wrong, but I don't think this is applicable here because it's being changed in the constructor

Yes, it's not applicable when we talk about constructor.
Tho if we spoke about v8 I'd probably would want to have something like this:
[Parameter]
-public override InputMode InputMode { get; set; } = InputMode.numeric;
+public override InputMode? InputMode { get; set; } = null;

+private InputMode GetInputMode()
+{
+	if (InputMode.HasValue)
+	{
+		return InputMode.Value;
+	}
+
+	var numericTypes = new[]
+	{
+		typeof(sbyte), typeof(sbyte?), typeof(byte), typeof(byte?),
+		typeof(short), typeof(short?), typeof(ushort), typeof(ushort?),
+		typeof(int), typeof(int?), typeof(uint), typeof(uint?),
+		typeof(long), typeof(long?), typeof(ulong), typeof(ulong?)
+	};
+
+	var decimalTypes = new[]
+	{
+		typeof(float), typeof(float?), typeof(double), typeof(double?),
+		typeof(decimal), typeof(decimal?)
+	};
+
+	if (numericTypes.Contains(typeof(T)))
+	{
+		return MudBlazor.InputMode.numeric;
+	}
+
+	if (decimalTypes.Contains(typeof(T)))
+	{
+		return MudBlazor.InputMode.@decimal;
+	}
+
+	return MudBlazor.InputMode.numeric;
+}

It's weird to me that the MudBaseInput already has a predefined InputMode set.
Anyway, I will let @henon to decide this one. If we merge it in v7 or we keep it v8 which will be started soon.

We'll merge this in v8, just to be sure. It can be in preview.1 which we can make available end of next week or so. Then you can already use it. Is that a good compromise @Eddie-Hartman ?

@henon please don't compromise for that.  I was just generally trying to better understand the thought process of how these types of things get fixed and playing devil's advocate since I rely so heavily on this library and felt like it is an actual bug scenario.
I'd have to review any other breaking changes in V8 as well and likely won't be rushing to upgrade right away with what may be other breaking changes (yes I'm aware of the irony).
Let me know if you need me to update anything to follow more closely what ScarletKuro suggested.
Stick to your timelines. It's a great library and I want it to stay great so keep doing what you're doing bc it's working. 🙂

I'd have to review any other breaking changes in V8 as well and likely won't be rushing to upgrade right away with what may be other breaking changes (yes I'm aware of the irony).

I plan to create a roadmap thread outlining what will be done in v8.
Based on our previous experience with v7, we aim to minimize breaking changes, it certainly won't include a billion property renames.
v8 will be a logical continuation of v7, primarily dropping .NET 7, removing obsolete APIs, and changing behaviors that make more sense (like in this PR). There will be few renames but mainly the typo ones and things that interfere (like this one https://github.com/MudBlazor/MudBlazor/pull/9434#issuecomment-2359333865). We do not plan to make fundamental changes, like replacing SVG icons with Font icons at this stage. I think this will be postponed to v9.
I hope the transition will be smoother and easier. Considering that the v7 will be deprecated and will not receive any support, even from the community.

@henon so are we merging this into v8?

Thanks!
Added to the v8 Migration guide

It looks like this change introduces an unexpected behaviour when the application language/culture uses comma as a decimal separator. When opening the application in a browser with a language that uses period as a decimal separator, the comma is not accepted by the MudNumericField.
Example 1:

Chrome browser language: English
Application language: Slovenian (culture: sl-SI), decimal separator is comma
Component: <MudNumericField @bind-Value="@Value" Label="@("Test")" />
Behaviour: I'm not able to enter 3,14.

Example 2:

Chrome browser language: Slovenian
Application language: Slovenian (culture: sl-SI), decimal separator is comma
Component: <MudNumericField @bind-Value="@Value" Label="@("Test")" />
Behaviour: I'm able to enter 3,14.

Example 3:

Chrome browser language: English
Application language: Slovenian (culture: sl-SI), decimal separator is comma
Component: <MudNumericField @bind-Value="@Value" Label="@("Test")" InputMode="InputMode.text" />
Behaviour: I'm able to enter 3,14.

So setting the InputMode="InputMode.text" solves the issue, but then it probabbly won't work on an iOS device, right (I'm not able to test it)?

@andrejpanjan Thanks for the comment.
I'm unfortunately less familiar with your situation. With this PR I was trying to bring things to a better web standard for these input types as was discussed in the original issue. I see that some others had commented on your particular situation as having issues before these changes as well. https://github.com/MudBlazor/MudBlazor/issues/4198#issuecomment-1081391051
Knowing that, would your comment be better as a new issue?
Also, your example 1 sounds like it might be a browser limitation (or trying to adhere to a standard in some way) rather than a component specific bug. In other words, Chrome is running in English, and therefore not expecting a comma as a decimal separator regardless of the fact that the app is "running" in Slovenian. I'm not super familiar with localization and cultures for the web and how it interacts with Blazor, but maybe make sure you're setting the culture properly for the page/browser itself and not just the Blazor app itself.
Regardless, I think you'd get results faster with a new issue.


Fix signature length correction

Discovered an old bug - sometimes there can be a lot of leading zeros in the signature. This should come as no surprise considering how bitcoin works. It doesn't happen often ...
Fixed.

@JamesSmartCell when is a signature greater than 65 bytes?

Good question and well spotted.
It's a phenomena of Two's Compliment. If the value of the final two bytes is greater than 0x80 then the BigInteger byte interpreter assumes a Two's Compliment value, and to keep the byte conversion positive it has to add an extra byte to the value to keep it matching. This breaks the 65 byte manipulation in the signing system. So, if the converted value is greater than 65 we know that BI has converted it into a Two's Compliment value and we just convert it back into the byte value if it were unsigned.
You may also wonder - say if the top two bytes were zero, and the next byte is greater than 0x80, it will grow into the final byte and break the signature system? It doesn't matter because the signing system converts the byte value back to BI and knows the value is unsigned, so it comes out the same.

so ... do the lords deem this request now worthy of inclusion?


[8.x] Update Arr helper docblock

Updated docblock for the Arr helper, based on the code.

As far as I understand, mixed includes null.


Expose Vulkan performance counter from VK_KHR_performance_query

VK_KHR_performance_query
Much like the existing counters in GL/DX, we can also expose the new performance queries Vulkan counters.
This purposefully avoid adding the VK_KHR_separate_depth_stencil_layout to the new headers so that change is more self contained.
Note that I recently realized there is an issue with this change :
A given implementation might have different sets of performance counters on different queue families. This change assumes the performances from family 0 are available everywhere. The Intel/Mesa implementation only have one queue so that works there, but it's something that needs fixing.
I'm not quite sure how to do this in Renderdoc as it seems to kind of assume counters apply to the whole VkDevice and can be queried for operations on compute & graphic queues alike.

Can you rebase this onto latest code? I pushed the headers update this morning so that you'd be able to land this PR (hopefully) without needing to include any header changes at all.
Regarding queue family restrictions, I think the thing to do would be to skip the counters when the command buffer is destined for a queue that doesn't support them, and return 0 for the data. This would be consistent with e.g. graphics counters returning 0s for EIDs that are compute dispatches and vice-versa.
This does break down in the case where a command buffer is recorded once and submitted to multiple queues with different sets of counter support AND the user has selected counters that are only supported on some. That would require recording once per submission with different counters (ick), so hopefully no-one does that...

Can you rebase this onto latest code? I pushed the headers update this morning so that you'd be able to land this PR (hopefully) without needing to include any header changes at all.
Regarding queue family restrictions, I think the thing to do would be to skip the counters when the command buffer is destined for a queue that doesn't support them, and return 0 for the data. This would be consistent with e.g. graphics counters returning 0s for EIDs that are compute dispatches and vice-versa.
This does break down in the case where a command buffer is recorded once and submitted to multiple queues with different sets of counter support AND the user has selected counters that are only supported on some. That would require recording once per submission with different counters (ick), so hopefully no-one does that...

I think I'll need to build as many query pool as there are family queues and capture the counters accordingly with 0s for stuff that doesn't match.

Uploaded all the changes but the InitInstanceExtensionTables call removal.

This looks good - still a little to do on the KHR enum rename. There also still seems to be a no-op change on gen_dispatch_table.py to be reverted.

This looks good - still a little to do on the KHR enum rename. There also still seems to be a no-op change on gen_dispatch_table.py to be reverted.

Thanks fixed (was made executable).
Thanks a lot for your time on this review, I'll do a follow up to address the different family queues issue.

No problem, sorry it ended up having a few bits to go over and fix up. This LGTM now, I'll merge once CI is green again.


Add support for  HDF file format

Good morning, would it be possible to add support for the following data format, please?
https://en.wikipedia.org/wiki/Hierarchical_Data_Format
Thanks

Hello @ll4strw. You can already create standard conformant ISCCs for HDF files (actually for any file type) using the ISCC SUM SubType
Here is an example script to generate ISCCs for any subtype:
"""Create an ISCC-CODE for any file"""
from os.path import basename
import iscc_sdk as idk
import iscc_core as ic

def code_iscc_sum(fp, ld_type="Dataset"):
    # type: (str, str) -> idk.IsccMeta
    """
    Generate a minimal ISCC-CODE (SubType SUM)

    The ISCC-CODE SUM is a combination of the Data-Code and Instance-Code UNITS.
    As such it can handle any file irrespective of the file format.

    :param str fp: Filepath used for ISCC-CODE creation.
    :param str ld_type: JSON-LD schema.org type of the identified file
    :return: ISCC metadata including ISCC-CODE
    :rtype: IsccMeta
    """

    # Prepare basic metadata
    with open(fp, "rb") as infile:
        data = infile.read(4096)
    meta = {
        "@type": ld_type,
        "filename": basename(fp),
        "mediatype": idk.mediatype_guess(data, file_name=basename(fp)),
    }

    # Generate Data-Code and Instance-Code
    data = idk.code_data(fp)
    instance = idk.code_instance(fp)
    iscc_code = ic.gen_iscc_code_v0([data.iscc, instance.iscc])

    # Collect Metadata form UNIT processors
    meta.update(instance.dict())
    meta.update(data.dict())
    meta.update(iscc_code)

    return idk.IsccMeta.construct(**meta)

if __name__ == '__main__':
    fp = "/path/to/test.h5"
    iscc_meta = code_iscc_sum(fp)
    print(iscc_meta.json(indent=2))

The output then looks like this:
{
  "@context": "http://purl.org/iscc/context",
  "@type": "Dataset",
  "$schema": "http://purl.org/iscc/schema",
  "iscc": "ISCC:KUABEKSKSEJGHCQXVBIYEODRUPP5S",
  "filename": "test.h5",
  "filesize": 15072,
  "mediatype": "application/x-hdf",
  "datahash": "1e20a851823871a3dfd92c49834eb03ceba5b182f0e5095e6bf532f8774ff240172f"
}

This is the structure of the ISCC SUM:

(see INSPECT tab on https://huggingface.co/spaces/iscc/iscc-playground)
The Data-Code component of the ISCC SUM would allow to match HDF files that have minimal changes in the raw bitstream. How good that works in practical terms will depend on how deterministic HDF file encoding is.
If you want support for higher level ISCC-UNITs than it gets more complicated. In the end it is use-case dependent. You would need to think about what does HDF file content-similarty mean and what should similarity matching accomplish. For some guidance see: https://eval.iscc.codes/similarity/

Meta-Code: Would require some standardized way of extracting metadata from HDF files
Content-Code: Would require "content"-extraction from HDF files. But what is the content modality? TEXT, IMAGE, AUDIO, VIDEO ...
Same goes for an eventual Semantic-Code

Happy to discuss any ideas around metadata/content extraction from HDF files.

Yes, if you have external metadata then the ISCC NONE SubType is a perfectly valid type for internal use-cases. The problem with using custom/external metadata is interoperability. If other parties only have the HDF file they can likely not reproduce the Meta-Code unit. As far as I see HDF supports internal metadata (Attributes) attached to Group and Dataset objects. It shouldn´t be to hard to create some deterministic metadata extraction from the objects and their attributes.
I guess the best way forward would be to first create some kind of plugin system with hooks for handling specific file types. We could than create separate python packages that could register themselves. There are already some file types supported by the iscc-sdk which I would love to put into a separate package.  The SDK tries to support metadata extraction, mapping and embedding as good as that is possible for well known file types. See: https://github.com/iscc/iscc-sdk/blob/main/iscc_sdk/metadata.py. The extraction, embedding, and mapping logic is in the individual modules per modality. For example: https://github.com/iscc/iscc-sdk/blob/main/iscc_sdk/image.py#L255
We distinguish between different kinds of metadata. Metadata that is used for calculation of the Meta-Code is called Seed-Metadata. Those are only 3 fields: name,  description,  meta.  There are other fields that are embeddable/extractable but they are purely informational and not processed algorithmically.
For industry specific metadata you would usually define or pick an existing schema, serialize it into a Data-URL and put it into the meta field. The long version: https://ieps.iscc.codes/iep-0002/


Add Julia and LiveScript to the list.

Thank you!

You're welcome :-)
The repo was briefly mentioned on hacker news, but it was penalized somehow, and was booted off the home page.


Add an Alert informing the user of the status of the task he's viewing

If it's already successfully done: mention this
If this task is in the future, mention we need to solve

Done!


Weak Key Exchange algorithm diffie-hellman-group14-sha1 is enabled by default

Description
The default SSHD configuration on Flatcar enables the diffie-hellman-group14-sha1 Key Exchange algorithm. This algorithm is considered to be a weak algorithm by the CIS Distribution Independent Linux benchmark v2.0.0:

Impact
Organizations using Flatcar subject to CIS benchmarks must customize the SSH key exchange algorithms to remove weak algorithms.
Environment and steps to reproduce
Run sudo sshd -T | grep kexalgorithms
Expected behavior
Weak algorithms should not be present by default.
Additional information
This is super nitpicky, but I was running through the CIS benchmark for my org to make sure Flatcar met our compliance requirements and I noticed this. Thought I'd file an issue.

Incoming fixes:

https://github.com/kinvolk/init/pull/36
https://github.com/kinvolk/coreos-overlay/pull/852

Alpha 2801.0.0 includes the fix https://github.com/kinvolk/init/pull/36 .
On its production image, you can see:
$ sudo sshd -T | grep kexalgorithms
kexalgorithms curve25519-sha256,curve25519-sha256@libssh.org,ecdh-sha2-nistp256,ecdh-sha2-nistp384,ecdh-sha2-nistp521,diffie-hellman-group-exchange-sha256,diffie-hellman-group16-sha512,diffie-hellman-group18-sha512,diffie-hellman-group14-sha256

As it shows, the kexalgorithms do not include weak ones like diffie-hellman-group14-sha1.
The fix will be included in other channels as well in the future.
Thanks!


Trying to make RTMP Connection using URL w/ encoded Params

Hello
I absolutely love your library!! Thank you so much!!! Ive been using it without Auth for the most part but Ive come to an issue when I am working with an already established Wowza server that takes a normal RTMP Url with an additional base64 encoded params string appended to the end.
rtmp://wowzaServer.specificServer.com/applicationName/applicationInstance?params=base64EncodedParameters
The param string is a set of variables that the wowza server uses for multiple functions. It does not take a standard username/password or I'd use
setAuthorization(String user, String password);
Ive been using the haishinKit lib in Swift and it seems to just pass the whole params string to the wowza server with no issues.
Is this something that is supported or can be made to work with your amazing library?
Thank you again!!!

Hello,
I never tried it with my library and I'm not sure how to send that data in the url like haishinKit. You can try use same url like in haishinKit and see the result, but if it isnt working.
I will try find how to implement it reading haishinKit. If you can share class file used for this in haishinKit I will really appreciate it.

You are amazing!! Thank you so much! I included all of the source files of the haishinKit as well as the two files I think are most of interest.
I make the call with
rtmpConnection.connect(urlString)
with
urlString = rtmp://wowzaServer.com/appName/appInstance/appInstance?params=base64EncodedString
as well as
streamnameString = mp4:appInstance
which is called with
rtmpStream.publish(streamnameString)
Thank you again!!!
filesOfInterest.zip
Sources.zip

Hello : )
I hope you are doing well! I have been messing with the rtmpUrlPattern matcher in RtmpConnection to try to modify it so that the regex expression takes in all the params info with the rest of the app instance. Ive gotten this expression that works well when tested against my url and stream name data.
^rtmps?://([^/:]+)(?::(\d+))*/([^*]*)//?(mp4[^*]*)$
Ive downloaded a zip of the src files but cannot seem to compile them back into the library after making the changes.
Have you had any success with the haishinkit code? Or do you know how to get the library to compile from src on a separate project? Ive followed some stackoverflow forums but can't seem to get all the dependencies of the library satisfied so it will compile.
Thank you so much!

Sorry for late response but I'm on holydays. About haishinkit code I read interest files but I can't find a regular expression or anything about params. I need study the code but this is more difficult and take more time because I haven't apple device so I can't compile it.
About compile you can add all module manually to your project and modify code to test your regular expression (if you add rtplibrary first, the others modules will be added automatically because this module have that dependencies):
https://github.com/pedroSG94/rtmp-rtsp-stream-client-java/wiki/Add-library-to-your-project

AMAZING! No apologies necessary! By no means expecting a response :) Just wanted to update you on my progress.
The haishinkit passes the full url string to its rtmp connection function but separate of the stream name which it uses in an rtmp publish function. The rtmp connection function takes the full url from domain to app instance and params.
I think with the modified regex it might work for your incredible library so going to try to get that to work.
Thank you so so much for your support and enjoy your holiday!!!


feat: add ability to validate IR and define custom op validators

Validators provide comprehancive checks of the IR structure. This patch adds both generic validators as well as ability for developers to define custom semantics for their operations.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

60 of 67 (89.55%)  changed or added relevant lines in 12 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.2%) to 89.771%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

core/src/validate.rs
0
1
0.0%

core/src/region.rs
29
35
82.86%

Totals

Change from base Build<PHONE_NUMBER>:
0.2%

Covered Lines:
1922

Relevant Lines:
2141

💛  - Coveralls


Reset StorageClasses and PriorityClasses

These non-namespaced objects were left behind after a reset.

Thank you for the PR @rbt. Sorry for the late review.


wrong fs type error

I have had Tesla_dashcam running without any issues on a pi w for a long time (I want to say 18+ months but I can't remember exactly). Every now and then I did do an update but mostly it was just working.
But now it stopped. The car started complaining that the USB drive was off (I can't remember the exact error) and I noticed, it wasn't copying saved events to the NAS.
Connecting it to a Windows computer, the drive mounts and I can see the following content, and that tells me this hasn't copied things off the SD card for a while now.

When I SSH in and run an upgrade I get the error wrong fs type. Any ideas on what is wrong? Is this a bug or is the SD card starting to go bad or something else? Below is the output when I run the upgrade.
root@teslausb-Model3:~# bin/setup-teslausb upgrade
preparing for full upgrade
/tmp/setup-teslausb is up to date
rc.local is up to date
Updating package index files...
Get:1 http://raspbian.raspberrypi.org/raspbian buster InRelease [15.0 kB]
Hit:2 http://archive.raspberrypi.org/debian buster InRelease
Fetched 15.0 kB in 3s (4,864 B/s)
Reading package lists... Done
Verifying that the requested configuration is valid...
Downloaded /tmp/verify-configuration.sh ...
USB_DRIVE is not set. SD card will be used.
Verifying that there is sufficient space available on the MicroSD card...
There is sufficient space available.
Downloading additional setup scripts.
Downloaded /root/bin/remountfs_rw ...
Downloaded /root/bin/make_snapshot.sh ...
Downloaded /root/bin/mount_snapshot.sh ...
Downloaded /root/bin/release_snapshot.sh ...
Downloaded /root/bin/force_sync.sh ...
Downloaded /tmp/create-backingfiles-partition.sh ...
Downloaded /tmp/create-backingfiles.sh ...
Downloaded /tmp/make-root-fs-readonly.sh ...
Downloaded /tmp/configure.sh ...
~ ~
Fixing the modules-load parameter in /boot/cmdline.txt...
Fixed cmdline.txt.
USB_DRIVE not set. Proceeding to SD card setup
create-backingfiles-partition: using existing backingfiles and mutable partitions
umount: /mnt/cam: not mounted.
mount: /mnt/cam: wrong fs type, bad option, bad superblock on /dev/loop0, missing codepage or helper program, or other error.
STOP: Couldn't check image

Thanks!

I'm assuming here that you use the pi within your Tesla for it to write to and that it then copies the files over to NAS on which you then have tesla_dashcam running to process them?
If so, based on what you are saying the issue you have might seem to be with the teslausb image and not with tesla_dashcam. I would then recommend opening an issue there: https://github.com/marcone/teslausb

Closing, not a Tesla_dashcam issue.


Add ability to rename 'out' directory in do_seg function in prediction_imports.py

One issue in CoastSeg is that all model outputs are saved into a directory named 'out' which mean only one model can be run on a directory of imagery. Coastseg uses doodleverse_utils. predition_imports function do_seg to perform segmentations on satellite imagery. By default do_seg creates a directory named 'out'.  I modified  do_seg to keep the default name of the model output directory to 'out' and allow the user to pass a different name for the model output directory. This should make the code backwards compatible with older versions while still allowing the 'out' directory to be renamed.

Thanks :)


App Crash on Hot Reload

My App crashes when hot-reloading, both from IDE or Flutter run.
Flutter doctor:
Doctor summary (to see all details, run flutter doctor -v):
[√] Flutter (Channel master, v0.7.6-pre.27, on Microsoft Windows [Version 10.0.17134.228], locale en-NL)
[√] Android toolchain - develop for Android devices (Android SDK 28.0.2)
[√] Android Studio (version 3.1)
[√] VS Code (version 1.26.1)
[√] Connected devices (1 available)

• No issues found!
Vebose output of flutter run after reloading:
[+5501 ms] Initializing hot reload...
[   +5 ms] Refreshing active FlutterViews before reloading.
[        ] _flutter.listViews: {isolateId: isolates/224998240}
[ +276 ms] Syncing files to device Android SDK built for x86...
[        ] DevFS: Starting sync from LocalDirectory: 'C:\Projecten\Van Doren - Introductie App'
[        ] Scanning project files
[   +1 ms] Scanning package files
[  +30 ms] Scanning asset files
[        ] Scanning for deleted files
[  +26 ms] Compiling dart to kernel with 0 updated files
[  +10 ms] Updating files
[   +9 ms] DevFS: Sync finished
[        ] Syncing files to device Android SDK built for x86... (completed)
[        ] Synced 0.0MB.
[   +2 ms] _flutter.setAssetBundlePath: {isolateId: isolates/224998240, viewId: _flutterView/0xec23760c, assetDirectory: /data/user/0/com.example.introductieapp/cache/Van Doren - Introductie AppGZIMCN/Van Doren - Introductie App/build/flutter_assets}
[   +8 ms] _reloadSources: {pause: false, rootLibUri: file:///data/user/0/com.example.introductieapp/cache/Van%20Doren%20-%20Introductie%20AppGZIMCN/Van%20Doren%20-%20Introductie%20App/lib/main.dart.incremental.dill, packagesUri: file:///data/user/0/com.example.introductieapp/cache/Van%20Doren%20-%20Introductie%20AppGZIMCN/Van%20Doren%20-%20Introductie%20App/.packages, isolateId: isolates/224998240}
[   +9 ms] D/        (26871): HostConnection::get() New Host Connection established 0xe43e3080, tid 26889
[  +82 ms] Service protocol connection closed.
[   +2 ms] Lost connection to device.
[   +3 ms] DevFS: Deleting filesystem on the device (file:///data/user/0/com.example.introductieapp/cache/Van%20Doren%20-%20Introductie%20AppGZIMCN/Van%20Doren%20-%20Introductie%20App/)
[   +1 ms] _deleteDevFS: {fsName: Van Doren - Introductie App}
[ +255 ms] TimeoutException after 0:00:00.250000: Future not completed

Are you able to provide a sample of code to reproduce this?

It doesn't happen when i create a new project.
I'll try to narrow it down more, though it happens on more than 1 project.

I reduced my App code to this, and the error still persists:
import 'package:flutter/material.dart';

void main() {
  runApp(VDApp());
}

class VDApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      // navigatorKey: navigatorKey,
      onGenerateTitle: (BuildContext context) => "Test",
      onGenerateRoute: (RouteSettings settings) {
        return MaterialPageRoute(builder: (context) {
          List<Widget> children = <Widget>[];
          // if (vanDorenStore.state.currentPage.background != null)
          children.add(Container(color: Colors.green));

          // if (vanDorenStore.state.currentPage.content != null)
          children.add(Container(child:Text("Test test ")));

          return Stack(
            children: children
          );
        });
        // return VanDorenPageRoute(pageData: vanDorenStore.state.currentPage);
      }
    );
  }
}

However, copy/paste this code into a newly created app doesn't crash on reload.
I'll try re-creating the app and copying the .dart source files into it.

Have you tried flutter clean?

Yeah, tried that.
I think it has something to do with the name of the directory, which containes a dash.
The project is in source-control and cloned into a directory which does not match the app-name inside pubspec.yaml. Renaming the directory to not contain spaces and/or dashes seems to have fixed it.
Should the directory-name reflect the pubspec.yaml name? Or just a name without spaces / glyphs?

This should be fixed in the next engine roll (see https://fuchsia.googlesource.com/tonic/+/3c566bc96b527f7032969b23fc1ddadc6fd165af)

@SankaCoffee are you still seeing this issue?

@zoechi No, it seems fixed. I also renamed my working directory with several special chars, but it didn't crash anymore. Thanks!


Remove more special cases for scalars

These aren't needed, since blades_to_grades_dict and indexes_to_bases_dict contain S(1) already.

Coverage fails because I only removed code that was covered!


Fix Subsurface Scattering

Works again
Transmittance also works again
Removed the curve parameter, exp() function is good enough.

This looks good to me

Thanks!


the requirement of NCCS core files

Could you give me some details of the fields about the "NCCS core files" data? Some of the shorthands are confusing. And I cannot find any docs in your project or websites that describe the meanings of those fields.
The related data as follows: nccs.core2005pc.csv

@CPUmaker Have you looked at the data dictionaries? The core files DD are listed up to 2013 but I'm unsure if that is when they were last updated or if they haven't changed since.
https://nccs-data.urban.org/showDD.php?ds=core


changed implementation of bringInView for compatability with all browsers

created a function  mannualScroll to scroll manually when scrollIntoView fails.
this fixes
Fixes #2

Merged in https://github.com/kamranahmedse/driver.js/commit/5ea1f0d4eb81790a949d709fcf8ff8ca70a33f23. Thanks! 👍


@alloy -> remove opaque view from behind search keyboard

closes https://github.com/artsy/eigen/issues/538

note this has my second_curtain fix, you can see all the images now :dancers:
https://eigen-ci.s3.amazonaws.com//304/index.html

or maybe the same one four times, hard to tell ;)

fixed the images!!!!!!

what does this mean
BlueprintIdentifier = "F82A938C8E623C49A74E330A"
-               BuildableName = "Pods.framework"
+               BlueprintIdentifier = "5E858A9E58475A1006BF493A"
+               BuildableName = "libPods.a"

That isn't a change you want, I would specifically remove that change in Artsy.xcodeproj/xcshareddata/xcschemes/Artsy.xcscheme, somehow you've got something pre-frameworks influencing this code.

@orta , ok i reverted it to how it is on master.

Perfect, thanks :+1:
I’m ignoring those three test failures (see #571).
I also keep getting that ilbPods.a change in the scheme, I’ll see if I can figure out where it’s coming from.

@1aurabrown It’s missing a CHANGELOG btw, can you PR one when you get back?

@alloy yes sorry!


Escape hotkey interferes with stopping playback

Many animators use Escape key for stopping playback.. while the addon is in use, hitting escape removes onion skin drawing.. Escape being optional might be more helpful..

This issue should be fixed in version 1.0.4


(GH-741 GH-749) Add missing package parameters

I also switched to an helper.ps1 file for the package parameters to not
go over the 100 lines guideline.
Also the Package Parameter for UseDelayedSearch will now contain the
correct value.
Fixes #741  #749

@mkevenaar your changes have been merged, thanks for your contribution 👍


use curl to test availability of ACME server, which tries all resolved IPs

Fixes https://github.com/shellhub-io/shellhub/issues/3639
Tested in my gateway container.
docker compose exec -ti gateway /bin/sh
...
/app # nc -z localhost 80; echo $?
1
/app # nc -z <IP_ADDRESS> 80; echo $?
0
/app # nc -z ::1 80; echo $?
1
/app # curl -sSf http://localhost > /dev/null; echo $?
0

Even with this fix, it may still fail to get the certificate, if the host has only IPv6 address, because this line listens only on IPv4 somehow.
https://github.com/shellhub-io/shellhub/blob/12e51169339893368c58fd156210d5951f55a5ea/gateway/entrypoint.sh#L71
Even though the Python3 doc says

By default, the server binds itself to all interfaces. The option -b/--bind specifies a specific address to which it should bind. Both IPv4 and IPv6 addresses are supported.

Merged! Thanks @merlinran


Run on Windows issue

Describe the bug
I can't launch your program, it says there are missing dll
To Reproduce
Steps to reproduce the behavior:

Download Windows release
Extract it
launch program
See error

Screenshots

Desktop (please complete the following information):
OS: Windows 11 (22H2)
Additional context
Have i to download some dependencies ? Or you have to integrate them to the archive ?

@ld892012 @Denveous I don't have windows laptop. I hope someone from community can help with this. So I am keeping this issue as open.


fix(client): use globalThis to get env vars

Fixes #14924

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Event emmitting not functioning on Android

Read this for context. I'm not sure as to why this is failing and if anyone has any suggestions or insights please comment here or on the SO thread. Thank you!

I've tested on Android 7.0, 8.1 and 9.0 and found that events are emitted on 7.0 but not on Android 8.1 and 9.0.  It appears that the problem is most likely with the Intent Service and doze mode in 8.0 as suggested in the stackoverflow link.  You might want to give Job Intent Service a try.

Here is some tips on geo fencing using Job Intent Service and BroadcastReceiver for geo fencing:
https://stackoverflow.com/questions/46675242/issue-moving-from-intentservice-to-jobintentservice-for-android-o
Maybe this might help.

@cloudmobiledevelopment thanks a lot for your research! I remember playing around with JobIntentService but I couldn't get consistent results. I'll revisit this though and follow up with what I've found.

Hi Eddie, Wondering if by chance you were able to fix this issue by using JobIntentService? It would be a lifesaver.

+1

@rfranczyk working on it this week. I'll follow up with some results shortly.

So I've been playing around with the JobIntentService quite a bit and I can get it to work very nicely on the Android side. Geofences are triggered, and sent to the appropriate places but I can't get past the hurdle of the ReactApplicationContext being bound to the RNBoundaryModule class.
As you can see here in my branch, the context passed to BoundaryEventJobIntentService is not the ReactApplicationContext which I need to publish events. I'm a bit stumped as to how I can leverage this service and still have access to the context.
I'm definitely no Android expert so if anyone can chime in with some help I'd be very grateful!

Might you need the JobIntentService#getApplicationContext() @eddieowens ? I'm new to RN but proficient with Android. The BaseContext in this instance would refer to the underlying android.app.Service. So calling getApplicationContext() would invoke the ContextWrapper that should go off and find the application context... which I think is what we need?

Ok, I'm going to try another way (since it didn't seem to work with the above technique) with LocalBroadcastManagers - will let you know how it goes.

@BrantApps ya I've tried all of the contexts available but none of them can be cast to the ReactApplicationContext which doesn't make much sense to me. Thanks for looking into this too!

This has been fixed thanks to the work and help of @BrantApps. The Boundary will still not trigger in the background if the app has been dozed. Creating another issue to address that problem but this fix is in as of 1.0.7


Provide availability information to HA.

Summary by CodeRabbit

New Features

Enhanced error handling for configuration loading.
New method for retrieving bridge availability topic paths.
Improved integration of MQTT interface with Home Assistant.

Bug Fixes

Enforced requirement for a valid MQTT base topic.

Chores

Updated default values for MQTT configuration.
Cleaned up commented-out code related to availability settings.

@coderabbitai review


[ko] Translate /docs/concepts/security/multi-tenancy into Korean

This is a Feature Request

What would you like to be added

Translate "/docs/concepts/security/multi-tenancy" into Korean.
Why is this needed
Not translated into Korean yet.
Comments

original entry: https://kubernetes.io/docs/concepts/security/multi-tenancy/
/language ko
/assign

/triage accepted


pull request for e2e test at 12/11/2016 06:15:02

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

optest/docs/updated_at.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Local Dev - DEV-ENV

Due to the high number of dependencies required to develop and build Daml.Finance, check if DEV-ENV (https://github.com/digital-asset/dev-env and https://direnv.net/) would help make this managing dependencies and their versions simpler.

List of required dev tools
Required for our scripts -

jq
yq
Docs generation -
python
pyenv
pipenv
ruby
node
yarn
sass
grunt

Other useful tools

circlici cli
gh cli

Some of these may not be in Nix...

I guess the docs generation part should go away once we piggy-back on the assembly build?

The docs generation step won't go away as we will still need to validate that the doc generation builds after making changes to the project.


feat(twilight-model,twilight-validate)!: Implement select menu default values

This pull request adds the default_values field Discord recently introduced for select menus. This field allows selecting default values for auto-populated select menu types (currently, user, role, mentionable, and channel).
Setting this field to Some(...) for any other select menu type is an error at runtime. However, I've changed the twilight-verify implementation to detect mistakes like this before sending the data to Discord.
Given the previous decision to implement select menu types as entirely flattened structs, I added the default_values field as an option to SelectMenu. While this doesn't statically enforce the type requirement explained above, this matches the behaviour of other type-specific fields.
Testing
I've updated my simple test project to use the feature introduced by this PR. As with my last PR, you can use it to get a quick overview of how the new API works.
Breaking changes
I'm aware of the following breaking change that this PR introduces:

SelectMenu (exhaustive) received a new default_values field.

I've updated the documentation and tests wherever necessary, but if I missed something or you want me to rephrase a comment, please request changes.
I believe you should add the d-api and d-breaking labels to this PR.

Interestingly enough, the test passed with the (outdated) version I had in my Cargo.lock file.
After a quick cargo update, I could reproduce the failure and push a fix.

@laralove143, I could reproduce the CI failure locally (after setting the necessary environment variables).
However, I believe this failure is unrelated to this PR, as the main branch seems to be failing with the same error.
Maybe this was introduced by better/worse detection of unused exports in a nightly toolchain update? :thinking:

I believe the CI error this PR is experiencing will be fixed by #2295.
I'll rebase the source branch of this PR once 2295 is merged :slightly_smiling_face:

I rebased the PR, and this fixed the CI. Please let me know if there are any other changes you'd like to see c:


haste-task-read accepts a filter function

enables filtering after the glob pattern, base on the file paths.

Codecov Report

Merging #128 into master will increase coverage by 0.07%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #128      +/-   ##
==========================================
+ Coverage   96.46%   96.53%   +0.07%
==========================================
  Files          22       22
  Lines         226      231       +5
  Branches       25       27       +2
==========================================
+ Hits          218      223       +5
  Misses          8        8

Impacted Files
Coverage Δ

packages/haste-task-read/src/index.js
100% <100%> (ø)
:arrow_up:

packages/haste-task-webpack/src/index.js
89.47% <0%> (+1.97%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fde9402...8c5da0e. Read the comment docs.


[9.x] Consider newlines in foreach/forelse statements

Consider newlines in foreach/forelse statements.
Fixes: https://github.com/laravel/framework/pull/44134#issuecomment-1264042847

I am closing this pull request because it lacks sufficient explanation, tests, or both. It is difficult for us to merge pull requests without these things because the change may introduce breaking changes to the framework.
Feel free to re-submit your change with a thorough explanation of the feature and tests - integration tests are preferred over unit tests. Please include it's benefit to end users; the reasons it does not break any existing features; how it makes building web applications easier, etc.
Thanks!


Manta Ray Boats refuse to slow down on water sections.

OS: Windows 10
Version: 0.2.5
Commit/Build: b5bcd0c
This has been an issue even as far back as the first release of OpenRCT2 or even RCT2 vanilla. The Manta Ray Boats from the Wacky Worlds expansion for the Water Coaster refuse to slow down greatly on water sections, just speeding through them as though they're normal steel track pieces, even though the other vehicle types (Coaster Boats from the base game, and Trilobite Boats and Flying Boats from Time Twister) do slow down. I looked in the json file for the Manta Ray Boats and it also doesn't have a "playSplashSoundSlide" flag. I suggest having this vehicle changed so that it not only actually slows down on water sections and plays a splashing sound effect, but also has the "hasShelter" flag activated (which should also be activated for the Flying Boats vehicle type, which should even get a description fix so that it mentions having a capacity of 6 passengers per boat, not 16).
Despite this bug, the Manta Ray Boats still do not get an excitement rating penalty that the Water Coaster gets for not having a water section.

Reproducible in RCT2 (vanilla)? Yes
Specific to multiplayer? No

Steps to reproduce:

Build a water coaster (any design, preferably Splashtastic).

If the Manta Ray Boats are available, select them. Otherwise, go to Object selection → Ride Vehicles/Attractions → select the Manta Ray Boats (it is at the bottom if you are sorting alphabetically by ride type from A to Z).

Build the exact same design but without the Manta Ray Boats.

The Manta Ray Boats version of the design will end up with higher stats due to lack of speed reduction on water sections, resulting in higher G forces, especially lateral Gs, which can potentially jeopardize the coaster's intensity rating.

Alternatively, you can start the default Wacky Worlds scenarios "Australasia - Ayers Rock" or "Australasia - Fun at the Beach". For the former scenario, you already get a water coaster. For the latter scenario, you need to open the water coaster that's on the far side of the park.

Screenshots:

In this screenshot, you can see the exact same design built four times, with each copy using the four available Water Coaster vehicle types,

In this screenshot, you can see that the Manta Ray Boats refuse to slow down on water sections, which results in higher G forces, which can be especially dangerous as it can trigger a very high (or even extreme) intensity rating due to heightened lateral G force ratings. The Manta Ray Boats are still traveling at 33 mph at the last curve even as the other boat types slow down to 23.

Can reproduce.
shakes head in disappointment over the expansions' quality

Thanks for investigating the flags btw.
I won't add the hasShelter flags, though, because while they're technically covered, water will still come in from the front if you ride it.
The capacity string that was incorrect on two of the four vehicles has already been fixed here, that just needs an object release (which we will do in time for 0.2.6).


Fix dependency conflict between tez and vineyard.

What do these changes do?
As tittled.
Related issue number

Fixes #1682

Cleanup dockerfile
Done


Indiescripter/update misc deps

Just a baby step further towards getting all the dependencies in better shape

Ops, something went wrong https://github.com/verdaccio/verdaccio/commit/d21279b35c9db32d41e3f3c7ff6a77d166ff44da

Nevermind, someone has translated the ID of the docs to Italian, thus the sidebar could not find the right ID and failed, I fixed it on crowdin.


[Skype for Business] SfB client does not receive message, when Message is sent from bot to SfB client, if SfB client window is minimized, or not in Right-Down corner of screen, or has multiple conversation added in SfB client.

Bot Info

SDK Platform: Node.js
botbuilder Version: 3.8.4
Active Channels: Skype for Business
Deployment Environment: Azure Bot Service, Azure App Service

Issue Description
We have created a bot for Skype for Business to start conversation with SFB clients.  In our case,  when conversation is initiated from bot using following code, SFB client does not receive the message from bot if  -
user has minimized SFB window,
OR
if SFB client window is not near right-lower corner of the screen.
OR
If  then only it is able to receive the message from bot.
OR
if user has multiple conversation added in the SFB client,
SFB client receives the message from Bot if -
User has it SFB window in right -Down corner of the screen, and it has only one coversation (i.e Conversation with Bot) in the SFB client window.
Code Example
var restify = require('restify');
var builder = require('botbuilder');
var server = restify.createServer();
server.listen(process.env.port || process.env.PORT || 3978, function () {
console.log('%s listening to %s', server.name, server.url);
});
// Create chat connector for communicating with the Bot Framework Service
var connector = new builder.ChatConnector({
appId: //GUID,
appPassword: password,
stateEndpoint: process.env.BotStateEndpoint,
openIdMetadata: process.env.BotOpenIdMetadata
});
// Listen for messages from users
server.post('/api/messages', connector.listen());
var inMemoryStorage = new builder.MemoryBotStorage();
// Create your bot with a function to receive messages from the user
var bot = new builder.UniversalBot(connector)
.set('storage', inMemoryStorage);
let addr1 =
{
channelId: 'skypeforbusiness',
user: {
id<EMAIL_ADDRESS>},
channelData: {
tenant: {
id: //GUID
}
},
bot:
{
id<EMAIL_ADDRESS>name: 'BotName'
},
serviceUrl: 'https://api.skypeforbusiness.com/platformservice/botframework/'
};
bot.loadSession(addr1, function (err, session) {
session.send('hi00');
});
bot.dialog('/', intents);
Reproduction Steps

Minimize the SFB client window.
Start bot to initiate the conversation  , and send the message to SFB client .
OR
Add another conversation to SFB client (with another contact except BOT).
Start bot and initiate the conversation from bot to send the message to SFB client.

In our case we stat debugging in VSCode and attaching debugger to NGRok )
Expected Behavior
When Bot is started , SFB client must receive message sent from the bot, whether client window in minimized, or it has multiple conversation adde , or SFB client window it is anywhere on the screen .
Actual Results
When message is sent from the Bot, if SFB client window is not in Right-Down corner of screen,or if user has multiple conversation in SFB client window,  It does not receive the message from Bot.
error messages. -->
There are no error messages seen while running the bot.

Thank you for opening an issue against the Bot Framework SDK v3. As part of the Bot Framework v4 release, we’ve moved all v3 work to a new repo located at https://github.com/microsoft/botbuilder-v3. We will continue to support and offer maintenance updates to v3 via this new repo.
From now on, https://github.com/microsoft/botbuilder repo will be used as hub, with pointers to all the different SDK languages, tools and samples repos.
As part of this restructuring, we are closing all tickets in this repo.
For defects or feature requests, please create a new issue in the new Bot Framework v3 repo found here:
https://github.com/microsoft/botbuilder-v3/issues
For Azure Bot Service Channel specific defects or feature requests (e.g. Facebook, Twilio, Teams, Slack, etc.), please create a new issue in the new Bot Framework Channel repo found here:
https://github.com/microsoft/botframework-services/issues
For product behavior, how-to, or general understanding questions, please use Stackoverflow.
https://stackoverflow.com/search?q=bot+framework
Thank you.
The Bot Framework Team


what is best way to implement Discovery page for best user experience

My application makes a n/w call to discovery server and the received posters (different genres and around 150 to 250 count) need to inflate on the scene.
Please suggest me the best way to inflate all these posters on the scene with horizontal and vertical smooth scrolling.

Could you elaborate? Is each poster a 3d object or some text or picture? It sounds similar to all the 360 video VR apps. Are you looking for tech or design advice?
Techwise, would be good to have an object pool. Don't want to keep on allocating data

@bohuang3d  each poster is a picture, yeah it same as video VR apps which support both 360 and normal video playback. We are looking for tech advice in implementation perspective.

You can make a 2d array of quadrilaterals that face the viewer. As your network calls brings you image data, convert images to textures and assign to the quadrilaterals.
Make some planning on the memory consumed by each image with the minimal resolution. Divide your available memory by image memory size to see if 100-200 images can be loaded without hiccups.
Then look at the speed of drawing say 100 quads each representing a video. Those 100 draw calls could be the bottleneck depending on what else you are doing

@bohuang3d Thanks for your inputs.

If you use ListView or other Android containers, consider at least:
can they be found in the scene during ray casts or collision detection?
do you need to write code to visualize them? (including scrolling)
UI elements/toolkits are usually slow. How expensive are the auto adjustment?

my listview is not scrolling while the swipe up and down on controller, when i check the listview focus it returns true, enableGestureDetector() added for my GvrActivity.
am i missing something to enable auto scroll for the list view .?
-> click event working fine for each list item.
-> GVRMain onSwipe() calling in which i added the logic to scroll listview but performance is not good.
Why listView not scrolling even hasFocus() returns true?


Localized java microservice to Hindi

Fixed: #46404
Due to some issues, I have closed the previous PR #46437, and made the required changes in this PR.
@divya-mohan0209

@anushatomar13  I have suggestion please go through it.
I think  these suggestion will also looks good to you.
PLease do the needful.

The proposed changes look good to me as well! Thank you for reviewing. I have made the changes now, does it look fine to you now?

@anushatomar13  Thank you for your work. Now it looks good to me

/lgtm


added assertion and rectified a bug

Signed-off-by: manorit chawdhry<EMAIL_ADDRESS>

Thanks!!!


Use entire phpstan config

Closes #110
After opening #110 I took a look around the codebase and realised this would be a fairly trivial change, so I thought I'd do a quick PR.
PS. I've run this fork in my project where I wanted to include the phpstan-strict-rules, phpstan-doctrine extensions, and it works as expected 😄

phpstan improvements released in v1.18.0.
Thanks @ndench.


Lint warning appears in Android Studio when accessing public resources from any of the appcompat-v7, gridlayout-v7, and design libraries

https://code.google.com/p/android/issues/detail?id=183120
BottomSheetPickers has dependencies on the appcompat-v7, gridlayout-v7, and design libraries. All resources in the library have been marked as private, which unfortunately marks the public resources in the other libraries private as well. You will get a Lint warning in Android Studio if you are using any of these attributes:

?colorPrimary
?colorPrimaryDark
?colorAccent
?selectableItemBackground
etc.

2-step solution:

Unmark all resources as private
Remove unused resources to minimize noise in auto-complete

This will end up exposing the remaining resources, which will still be quite a lot, but the tradeoff is necessary.


Number of "warning"s in MProductGroupReport

derived from the #209.
I want to see the number of MaterialProducts with "warning" status, like this:

In this screenshot, you can find
1w 1i 8t
on the top left corder of the viewport.
1w means there is 1 warning .
1i means there is 1 ignorable.
8t means there are 8 MaterialProducts  as total in the list.
If I check or uncheck MaterialProducts, the figure of W and I can vary while T stays unchanged.
The figure should be displayed fixed on the top left corder even if the list is long and scrollable.

Should change the design of counts.
Currently 1w 1i 8t
Change to 1x 1i 8t.
change the method/property name "warning" -> exceeding.
Becuase the word "warning" is already in use.
warning = exceeding + ignorable.
2 = 1 + 1

done at v0.7.0


where the file is stored

Same issue, have you found the solution?

Hi,
you can specify the location of the uploaded files by passing some options to the IncomingForm in upload.js:
  var form = new IncomingForm({
    uploadDir: "./upload",
    keepExtensions: true,
  });

You have to make sure that the directory exists!
I hope that helps, have a nice day!


Include Typings for Typescript users and improve node webpack settings

This PR does two things:

Adds a basic typescript definition file so that typescript users can use the package with noImplicitAny turned on
Resolved the node settings on webpack better for the server so that users can choose to set other variables.

Coverage decreased (-0.2%) to 32.21% when pulling 3ec38b85c76fcc5cb9ef8daa16bccb75d6046b88 on LukeSheard:master into c0515804905a804332b8b7f4fc3d13ccabbab367 on halt-hammerzeit:master.

thx, released as part of the latest version.

Awesome, thanks!


API allows to set bucket both erasure coding and replicas

Environment info

Version: 2.1.3 65ecabe
Deployment: **AZURE **

Actual behavior

API allows calls like this:
client.tier.update_tier({          name: res.tiering.tiers[0].tier,          chunk_coder_config: { data_frags, parity_frags, replicas }      })
where all 3 parameters are not empty, e.g.
data_frags = 4,
parity_frags = 2,
replicas = 3,

In this case bucket will be set to erasure coding (4+2) and UI will report that you need minimal 6 agents. But even with 6 agents attached bucket sill be considered not healthy and will use spillover instead of nodes.
Expected behavior

Error thrown when all 3 parameters have value.
Or replicas ignored if data and parity frags have value.

Steps to reproduce

Create a bucket with 6 nodes.
Set chunk_coder_config: { 4, 2, 3 }
Try to upload file to the bucket
Ensure that spillover used instead of agents and bucket shown as not healthy on UI.

Screenshots or Logs or other output that would be helpful

Closing no fix


Log still prints 'load data completed app saved' after script error

Describe the bug
Suppose your script has an error.
Normally the script will stop running when it encounters an error.
In VSQlik, the error message is printed, but at the end the log prints:
load data completed
app PMHC MDS saved
<<<

I think it should not print this if there was an error!
To Reproduce

Create a script with an error (e.g. an extra comma before the first item in the LOAD.)
Run the script from VSQlik.
You will see at the end of the log:

load data completed
app PMHC MDS saved
<<<

Expected behavior
In Qlik Sense, when an error is encountered, the log ends with:
Data has not been loaded. Please correct the error and try loading again.

Screenshots
VSQlik:

Qlik Sense:

Desktop (please complete the following information):

OS: Windows 1909
Browser: Edge
VSQlik Version: 1.3.0

@davidwales we will fix it ASAP
Please can you leave here a rating for the extension
https://marketplace.visualstudio.com/items?itemName=q-masters.vscode-qlik&ssr=false#review-details

Rating completed!


Get User Name Function from Backend.

Currently profile screen is showing hardcoded name, it should show the correct name.

Please assign to me


Visually inconsistant context menus on Web

A picture is worth a thousand words:

Seems the repost menu needs updating with the shiny new context menu component - probably got missed because it only uses the context menu on web.
Happy to make a PR

Yeah this should be the new one for sure. Mobile shows a modal, which is a different behavior which we'd like to keep at the moment. Happy to accept a PR but I can prolly knock this out in 20 minutes if its too much of a hassle for ya!

Seems like the backdrop no longer shows:

I had a go at making a PR but I couldn't figure out a neat way to do it - not sure where the best place to branch the logic for diplaying context menu items is

@mozzius Sorry, which backdrop are you referring to?

The menu is open but the rest of the screen isn't darkened, so you can't see the menu's border at all (see screenshot)

@mozzius Omg I couldn't even see the menu hahahha
I am unable to reproduce this. This is web, right?

Yep, Firefox. Lemme see if I can reproduce

Firefox on a different MacBook - it gets even better because without the backdrop, you can select as many as you'd like! And you can keep scrolling to collect more!

Oh and they stick around even when you change tab

We just pushed a fix to this, not yet released


Chunked tests gives access violation on Windows CI

test_filled_random_uniform_no_corner_mask_chunk for serial algorithm sometimes gives Windows fatal exception: access violation on windows-latest CI, any Python version.
OK on linux and macos.

Fixed by PR #22.


render_view should return document, not fragment

Phlex::TestHelpers#render_view returns a Nokogiri fragment, which is not useful when wanting ti test against the full document.
I think instead of Nokogiri::HTML.fragment(rendered), Nokogiri::HTML(rendered) would be better, as that returns the entire document.
For example, have_css('head > link[rel="stylesheet"]') on the fragment will fail, while it will work on the document.

The problem with document is it returns a HTML page, instead a html snippet.
Using fragment it is possible to do something like this:
# my component
class MyCard
  def template
    # ...  some code
    render StatusBadge.new(item: item)
    # ... some code
  end
end

# tests
it "renders status badge" do
  item = Item.new(...)
  result = render_view(MyCard.new(item: item))
  status_badge = render_view(StatusBadge.new(item: item))

  expect(result).to include(status_badge) # it will fail if status_badge is a document instead a fragment
end

One solution is to create a new helper, eg.: render_page, render_layout, returning a document instead a fragment.

I suppose the challenge is knowing whether the view is a full HTML page (with , , , etc.), or just a fragment (an HTML element). A Phlex view can be anything.
I'm not sure different methods would be great - that could be confusing for newcomers. Perhaps render_view could accept a keyword argument (as:), which could have a value of either page or fragment. And perhaps with a sensible default?
render_view MyCard.new(item: item), as: :page
render_view StatusBadge.new(item: item), as: :fragment

@joelmoss @stephannv I wonder if we should remove Nokogiri support and just support Capybara instead. What do you think? Are there any advantages to direct Nokogiri integration? Of course anyone could make a plugin — but I don't know if we should ship it in Phlex.

I'm actually only using Nokogiri, simply because I think capybara is overkill. And besides, capybara uses Nokogiri under the hood anyway.

How does ViewComponent handle this issue with fragments vs documents? I guess it's not an issue for them because they don't recommend using view component for the whole page.

They render as a Fragment. But yes, that makes sense, as they focus on components, not pages.
This is nice though - it allows for Capybara assertions to be used.

They render as a Fragment. But yes, that makes sense, as they focus on components, not pages.
This is nice though - it allows for Capybara assertions to be used.

It's already possible to use capybara assertions, because matchers convert the object to capybara node:
result = render_view(MyComponent.new)

expect(result).to have_link("Contact", href: "/contact") # capybara matcher

The page is useful when you are doing this:
def test_my_component
  render_view(MyComponent.new)

  assert_link "Contact", href: "/contact" # capybara will use `page`
end

The page was being implemented in these PRs https://github.com/joeldrapper/phlex/pull/282 and https://github.com/joeldrapper/phlex/pull/278.
About fragments vs documents, I think assert against head tag is a edge case, we can add to the docs a suggestion:
# If you want assert against html, head and body tags, you can do this:
result = Nokogiri::HTML(view.call)
# If you are using Rails
result = Nokogiri::HTML(view.call(view_context: controller.view_context))

# If you are writing this code a lot you can create a custom helper, eg.
module Phlex
  module CustomHelpers
    def render_document(view)
      Nokogiri::HTML(view.call(view_context: controller.view_context))
    end
  end
end

RSpec.configure do |config|
  config.include Phlex::CustomHelpers, type: :view
end

About fragments vs documents, I think assert against head tag is a edge case

I definitely disagree with that. The head can contain a lot of important stuff, and it usually matters if what you are testing for exists in the head or the body.

About fragments vs documents, I think assert against head tag is a edge case

I definitely disagree with that. The head can contain a lot of important stuff, and it usually matters if what you are testing for exists in the head or the body.

On second thought, I really think I was wrong in my statement, and I agree with you. I said that thinking that complete pages (with html, head, body tags) are usually tested with integration/feature/system tests. But you are testing just the layout shell, makes sense to do unit tests, asserting head tags.

One idea that I'm exploring is distinguishing between a page, and a component, where both are Phlex views, but have different responsibilities and behaviour, especially when it comes to Rails.
A page would usually be rendered from a controller action, and a component would replace partials, and be used within one or more pages.
When you think like this, testing becomes clearer, as you know want to test against a Fragment for components, and a document for pages.

One idea that I'm exploring is distinguishing between a page, and a component, where both are Phlex views, but have different responsibilities and behaviour, especially when it comes to Rails.
A page would usually be rendered from a controller action, and a component would replace partials, and be used within one or more pages.
When you think like this, testing becomes clearer, as you know want to test against a Fragment for components, and a document for pages.

Yeah, in my pet project I'm doing this:

In controller:

I'm using feature/system tests to test high-level behavior: "i click here, render this, fill that, expect to have some content". And I'm using unit tests to test some specific compoment behaviors that would be very expensive to do cover all scenarios with integration tests, eg.: "When post is draft, renders Draft badge, when is published, renders Published badge", "when user has admin permission, navbar should render admin menu", etc.

I wonder if we could detect whether a view is a document or not by detecting a call to html. For this, we'd need a global render context.

We have helpers for Nokogiri documents and fragments now.


WIP: master detail template

affects: @haulmont/jmix-front-generator, @haulmont/jmix-react-core, @haulmont/jmix-react-ui

On Linux the build will fail with:
src/ui/MasterDetail/useMasterDetailList.ts:4:33 - error TS2307: Cannot find module './MasterDetailContext' or its corresponding type declarations.

because the filename starts with lowercase - masterDetailContext.tsx

But let's wait for @web-devel comments before moving forward.