[Code Addition Request]: SuperStore Sales Analysis with Pandas

Have you completed your first issue?

[X] I have completed my first issue

Guidelines

[X] I have read the guidelines
[X] I have the link to my latest merged PR

Latest Merged PR Link
https://github.com/UTSAVS26/PyVerse/pull/113/commits/b71170e84b3b39cd0a9c32946e8392f96d581c68
Project Description
I would like to contribute by performing a detailed Sales Analysis using the SuperStore dataset with Pandas. This analysis is critical for understanding key business metrics and trends, providing insights that can drive better decision-making and sales strategies.
Objective:-
• What is the overall sales trend?
• Sales by Category?
• Sales by Sub-Category?
• Profit Analysis
• Profit analysis by customer segments:
• Which are the Top 10 products by sales?
• Which are the Most Selling Products?
• Which is the most preferred Ship Mode?
• Which are the Most Profitable Category and Sub-Category?
This analysis is particularly important for e-commerce platforms or retail companies to optimize inventory, marketing strategies, and customer engagement by understanding their sales data comprehensively. I believe this contribution will add significant value to the repository and help users understand practical use cases of sales data analysis using Pandas.
Full Name
Pasam Tharun
Participant Role
Contributor for GirlScript Summer of Code 2024 - Extended Edition!

@UTSAVS26 You Assigned the Level as 1???
Do u think this is Level Problem??

Hello @PasamTharun,
I hope this message finds you well. I am eager to work on the SuperStore Sales Analysis with Pandas (#472) issue. I believe I can provide a detailed solution using the provided information.
Could you please grant me access to start working on this? I am excited about the opportunity to contribute and look forward to solving this problem.
Thank you for considering my request!
Best regards,
Gaurav Patil
Contributor, GirlScript Summer of Code 2024

@UTSAVS26 You Assigned the Level as 1???
Do u think this is Level 1 Problem??

The thing is as stated in guidelines shared in discussion page, any type of project or code would come under level1 and if you fix big or add new feature in the existing codebase that will be counted in level2 and level3.

But You have given Level 3 for coding part they haven't fixed any bugs in
that.
I Think The issue Number is #93
On Sat, 12 Oct, 2024, 9:12 am UTSAV SINGHAL, @.***>
wrote:

@UTSAVS26 https://github.com/UTSAVS26 You Assigned the Level as 1???
Do u think this is Level 1 Problem??
The thing is as stated in guidelines shared in discussion page, any type
of project or code would come under level1 and if you fix big or add new
feature in the existing codebase that will be counted in level2 and level3
.
—
Reply to this email directly, view it on GitHub
https://github.com/UTSAVS26/PyVerse/issues/472#issuecomment-2408335675,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BDYCS4K3TWMCAORKTCJJC3DZ3CLBFAVCNFSM6AAAAABPZCGIN2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBYGMZTKNRXGU
.
You are receiving this because you were mentioned.Message ID:
@.***>

But You have given Level 3 for coding part they haven't fixed any bugs in
that.
I Think The issue Number is #93
On Sat, 12 Oct, 2024, 9:12 am UTSAV SINGHAL, @.***>
wrote:

@UTSAVS26 https://github.com/UTSAVS26 You Assigned the Level as 1???
Do u think this is Level 1 Problem??
The thing is as stated in guidelines shared in discussion page, any type
of project or code would come under level1 and if you fix big or add new
feature in the existing codebase that will be counted in level2 and level3
.
—
Reply to this email directly, view it on GitHub
https://github.com/UTSAVS26/PyVerse/issues/472#issuecomment-2408335675,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BDYCS4K3TWMCAORKTCJJC3DZ3CLBFAVCNFSM6AAAAABPZCGIN2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBYGMZTKNRXGU
.
You are receiving this because you were mentioned.Message ID:
@.***>

I have updated the guidelines after that you can see the time when the issue is raised and when the guidelines are given and in the guidelines I have also mentioned that if i have assign the levels before they will not be change.

It's not fair!!
On Sat, 12 Oct, 2024, 9:38 am UTSAV SINGHAL, @.***>
wrote:

But You have given Level 3 for coding part they haven't fixed any bugs in
that.
I Think The issue Number is #93
https://github.com/UTSAVS26/PyVerse/pull/93
On Sat, 12 Oct, 2024, 9:12 am UTSAV SINGHAL, @.***>
wrote:
@UTSAVS26 https://github.com/UTSAVS26 https://github.com/UTSAVS26 You
Assigned the Level as 1???
Do u think this is Level 1 Problem??
The thing is as stated in guidelines shared in discussion page, any type
of project or code would come under level1 and if you fix big or add new
feature in the existing codebase that will be counted in level2 and level3
.
—
Reply to this email directly, view it on GitHub
#472 (comment)
https://github.com/UTSAVS26/PyVerse/issues/472#issuecomment-2408335675,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BDYCS4K3TWMCAORKTCJJC3DZ3CLBFAVCNFSM6AAAAABPZCGIN2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBYGMZTKNRXGU
.
You are receiving this because you were mentioned.Message ID:
@.***>
I have updated the guidelines after that you can see the time when the
issue is raised and when the guidelines are given and in the guidelines I
have also mentioned that if i have assign the levels before they will not
be change.
—
Reply to this email directly, view it on GitHub
https://github.com/UTSAVS26/PyVerse/issues/472#issuecomment-2408344184,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BDYCS4NCJ63IK7YTCVVJN2LZ3COFNAVCNFSM6AAAAABPZCGIN2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBYGM2DIMJYGQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

In the 1st You have assigned level to her but after that You have Changed
the label to level 3.
On Sat, 12 Oct, 2024, 9:52 am Pasam Tharun, @.***> wrote:

It's not fair!!
On Sat, 12 Oct, 2024, 9:38 am UTSAV SINGHAL, @.***>
wrote:

But You have given Level 3 for coding part they haven't fixed any bugs in
that.
I Think The issue Number is #93
https://github.com/UTSAVS26/PyVerse/pull/93
On Sat, 12 Oct, 2024, 9:12 am UTSAV SINGHAL, @.***>
wrote:
@UTSAVS26 https://github.com/UTSAVS26 https://github.com/UTSAVS26 You
Assigned the Level as 1???
Do u think this is Level 1 Problem??
The thing is as stated in guidelines shared in discussion page, any type
of project or code would come under level1 and if you fix big or add new
feature in the existing codebase that will be counted in level2 and level3
.
—
Reply to this email directly, view it on GitHub
#472 (comment)
https://github.com/UTSAVS26/PyVerse/issues/472#issuecomment-2408335675,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BDYCS4K3TWMCAORKTCJJC3DZ3CLBFAVCNFSM6AAAAABPZCGIN2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBYGMZTKNRXGU
.
You are receiving this because you were mentioned.Message ID:
@.***>
I have updated the guidelines after that you can see the time when the
issue is raised and when the guidelines are given and in the guidelines I
have also mentioned that if i have assign the levels before they will not
be change.
—
Reply to this email directly, view it on GitHub
https://github.com/UTSAVS26/PyVerse/issues/472#issuecomment-2408344184,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BDYCS4NCJ63IK7YTCVVJN2LZ3COFNAVCNFSM6AAAAABPZCGIN2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBYGM2DIMJYGQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

In the 1st You have assigned level 1 to her but after that You have Changed
the label to level 3.
On Sat, 12 Oct, 2024, 9:52 am Pasam Tharun, @.***> wrote:

It's not fair!!
On Sat, 12 Oct, 2024, 9:38 am UTSAV SINGHAL, @.***>
wrote:

But You have given Level 3 for coding part they haven't fixed any bugs in
that.
I Think The issue Number is #93
https://github.com/UTSAVS26/PyVerse/pull/93
On Sat, 12 Oct, 2024, 9:12 am UTSAV SINGHAL, @.***>
wrote:
@UTSAVS26 https://github.com/UTSAVS26 https://github.com/UTSAVS26 You
Assigned the Level as 1???
Do u think this is Level 1 Problem??
The thing is as stated in guidelines shared in discussion page, any type
of project or code would come under level1 and if you fix big or add new
feature in the existing codebase that will be counted in level2 and level3
.
—
Reply to this email directly, view it on GitHub
#472 (comment)
https://github.com/UTSAVS26/PyVerse/issues/472#issuecomment-2408335675,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BDYCS4K3TWMCAORKTCJJC3DZ3CLBFAVCNFSM6AAAAABPZCGIN2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBYGMZTKNRXGU
.
You are receiving this because you were mentioned.Message ID:
@.***>
I have updated the guidelines after that you can see the time when the
issue is raised and when the guidelines are given and in the guidelines I
have also mentioned that if i have assign the levels before they will not
be change.
—
Reply to this email directly, view it on GitHub
https://github.com/UTSAVS26/PyVerse/issues/472#issuecomment-2408344184,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BDYCS4NCJ63IK7YTCVVJN2LZ3COFNAVCNFSM6AAAAABPZCGIN2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBYGM2DIMJYGQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

Yes you can see her work through the PR, and it was when the guidelines was not released and I was given strict action to do that for adding project or just code give level1 and for bug fixing and feature addition give higher level.

It's not fair!!
On Sat, 12 Oct, 2024, 9:38 am UTSAV SINGHAL, @.***>
wrote:

But You have given Level 3 for coding part they haven't fixed any bugs in
that.
I Think The issue Number is #93
https://github.com/UTSAVS26/PyVerse/pull/93
On Sat, 12 Oct, 2024, 9:12 am UTSAV SINGHAL, @.***>
wrote:
@UTSAVS26 https://github.com/UTSAVS26 https://github.com/UTSAVS26 You
Assigned the Level as 1???
Do u think this is Level 1 Problem??
The thing is as stated in guidelines shared in discussion page, any type
of project or code would come under level1 and if you fix big or add new
feature in the existing codebase that will be counted in level2 and level3
.
—
Reply to this email directly, view it on GitHub
#472 (comment)
https://github.com/UTSAVS26/PyVerse/issues/472#issuecomment-2408335675,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BDYCS4K3TWMCAORKTCJJC3DZ3CLBFAVCNFSM6AAAAABPZCGIN2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBYGMZTKNRXGU
.
You are receiving this because you were mentioned.Message ID:
@.***>
I have updated the guidelines after that you can see the time when the
issue is raised and when the guidelines are given and in the guidelines I
have also mentioned that if i have assign the levels before they will not
be change.
—
Reply to this email directly, view it on GitHub
https://github.com/UTSAVS26/PyVerse/issues/472#issuecomment-2408344184,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BDYCS4NCJ63IK7YTCVVJN2LZ3COFNAVCNFSM6AAAAABPZCGIN2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBYGM2DIMJYGQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

It is based on the guidelines.

Anyway I think you are biased!!
On Sat, 12 Oct, 2024, 10:11 am UTSAV SINGHAL, @.***>
wrote:

It's not fair!!
On Sat, 12 Oct, 2024, 9:38 am UTSAV SINGHAL, @.***>
wrote:
But You have given Level 3 for coding part they haven't fixed any bugs in
that.
I Think The issue Number is #93
https://github.com/UTSAVS26/PyVerse/pull/93
#93 https://github.com/UTSAVS26/PyVerse/pull/93
On Sat, 12 Oct, 2024, 9:12 am UTSAV SINGHAL, @.***>
wrote:
@UTSAVS26 https://github.com/UTSAVS26 https://github.com/UTSAVS26
https://github.com/UTSAVS26 You
Assigned the Level as 1???
Do u think this is Level 1 Problem??
The thing is as stated in guidelines shared in discussion page, any type
of project or code would come under level1 and if you fix big or add new
feature in the existing codebase that will be counted in level2 and level3
.
—
Reply to this email directly, view it on GitHub
#472 https://github.com/UTSAVS26/PyVerse/issues/472 (comment)
#472 (comment)
https://github.com/UTSAVS26/PyVerse/issues/472#issuecomment-2408335675,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BDYCS4K3TWMCAORKTCJJC3DZ3CLBFAVCNFSM6AAAAABPZCGIN2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBYGMZTKNRXGU
.
You are receiving this because you were mentioned.Message ID:
@.***>
I have updated the guidelines after that you can see the time when the
issue is raised and when the guidelines are given and in the guidelines I
have also mentioned that if i have assign the levels before they will not
be change.
—
Reply to this email directly, view it on GitHub
#472 (comment)
https://github.com/UTSAVS26/PyVerse/issues/472#issuecomment-2408344184,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BDYCS4NCJ63IK7YTCVVJN2LZ3COFNAVCNFSM6AAAAABPZCGIN2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBYGM2DIMJYGQ
.
You are receiving this because you were mentioned.Message ID:
@.***>
It is based on the guidelines.
—
Reply to this email directly, view it on GitHub
https://github.com/UTSAVS26/PyVerse/issues/472#issuecomment-2408381841,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BDYCS4NLGKJCAC2CXEBONSDZ3CR6XAVCNFSM6AAAAABPZCGIN2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBYGM4DCOBUGE
.
You are receiving this because you were mentioned.Message ID:
@.***>

Anyway I think you are biased!!
On Sat, 12 Oct, 2024, 10:11 am UTSAV SINGHAL, @.***>
wrote:

It's not fair!!
On Sat, 12 Oct, 2024, 9:38 am UTSAV SINGHAL, @.***>
wrote:
But You have given Level 3 for coding part they haven't fixed any bugs in
that.
I Think The issue Number is #93
https://github.com/UTSAVS26/PyVerse/pull/93
#93 https://github.com/UTSAVS26/PyVerse/pull/93
On Sat, 12 Oct, 2024, 9:12 am UTSAV SINGHAL, @.***>
wrote:
@UTSAVS26 https://github.com/UTSAVS26 https://github.com/UTSAVS26
https://github.com/UTSAVS26 You
Assigned the Level as 1???
Do u think this is Level 1 Problem??
The thing is as stated in guidelines shared in discussion page, any type
of project or code would come under level1 and if you fix big or add new
feature in the existing codebase that will be counted in level2 and level3
.
—
Reply to this email directly, view it on GitHub
#472 https://github.com/UTSAVS26/PyVerse/issues/472 (comment)
#472 (comment)
https://github.com/UTSAVS26/PyVerse/issues/472#issuecomment-2408335675,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BDYCS4K3TWMCAORKTCJJC3DZ3CLBFAVCNFSM6AAAAABPZCGIN2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBYGMZTKNRXGU
.
You are receiving this because you were mentioned.Message ID:
@.***>
I have updated the guidelines after that you can see the time when the
issue is raised and when the guidelines are given and in the guidelines I
have also mentioned that if i have assign the levels before they will not
be change.
—
Reply to this email directly, view it on GitHub
#472 (comment)
https://github.com/UTSAVS26/PyVerse/issues/472#issuecomment-2408344184,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BDYCS4NCJ63IK7YTCVVJN2LZ3COFNAVCNFSM6AAAAABPZCGIN2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBYGM2DIMJYGQ
.
You are receiving this because you were mentioned.Message ID:
@.***>
It is based on the guidelines.
—
Reply to this email directly, view it on GitHub
https://github.com/UTSAVS26/PyVerse/issues/472#issuecomment-2408381841,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BDYCS4NLGKJCAC2CXEBONSDZ3CR6XAVCNFSM6AAAAABPZCGIN2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBYGM4DCOBUGE
.
You are receiving this because you were mentioned.Message ID:
@.***>

It's your call not mine. I have tell you about the guidelines and all the details, i am only following the rules.

But Why You have Given level 3 for coding part!!!???
On Sat, 12 Oct, 2024, 10:17 am UTSAV SINGHAL, @.***>
wrote:

Anyway I think you are biased!!
On Sat, 12 Oct, 2024, 10:11 am UTSAV SINGHAL, @.***>
wrote:
It's not fair!!
On Sat, 12 Oct, 2024, 9:38 am UTSAV SINGHAL, @.***>
wrote:
But You have given Level 3 for coding part they haven't fixed any bugs in
that.
I Think The issue Number is #93
https://github.com/UTSAVS26/PyVerse/pull/93
#93 https://github.com/UTSAVS26/PyVerse/pull/93
#93 https://github.com/UTSAVS26/PyVerse/pull/93 #93
https://github.com/UTSAVS26/PyVerse/pull/93
On Sat, 12 Oct, 2024, 9:12 am UTSAV SINGHAL, @.***>
wrote:
@UTSAVS26 https://github.com/UTSAVS26 https://github.com/UTSAVS26
https://github.com/UTSAVS26
https://github.com/UTSAVS26 You
Assigned the Level as 1???
Do u think this is Level 1 Problem??
The thing is as stated in guidelines shared in discussion page, any type
of project or code would come under level1 and if you fix big or add new
feature in the existing codebase that will be counted in level2 and level3
.
—
Reply to this email directly, view it on GitHub
#472 https://github.com/UTSAVS26/PyVerse/issues/472 #472
https://github.com/UTSAVS26/PyVerse/issues/472 (comment)
#472 https://github.com/UTSAVS26/PyVerse/issues/472 (comment)
#472 (comment)
https://github.com/UTSAVS26/PyVerse/issues/472#issuecomment-2408335675,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BDYCS4K3TWMCAORKTCJJC3DZ3CLBFAVCNFSM6AAAAABPZCGIN2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBYGMZTKNRXGU
.
You are receiving this because you were mentioned.Message ID:
@.***>
I have updated the guidelines after that you can see the time when the
issue is raised and when the guidelines are given and in the guidelines I
have also mentioned that if i have assign the levels before they will not
be change.
—
Reply to this email directly, view it on GitHub
#472 https://github.com/UTSAVS26/PyVerse/issues/472 (comment)
#472 (comment)
https://github.com/UTSAVS26/PyVerse/issues/472#issuecomment-2408344184,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BDYCS4NCJ63IK7YTCVVJN2LZ3COFNAVCNFSM6AAAAABPZCGIN2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBYGM2DIMJYGQ
.
You are receiving this because you were mentioned.Message ID:
@.***>
It is based on the guidelines.
—
Reply to this email directly, view it on GitHub
#472 (comment)
https://github.com/UTSAVS26/PyVerse/issues/472#issuecomment-2408381841,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BDYCS4NLGKJCAC2CXEBONSDZ3CR6XAVCNFSM6AAAAABPZCGIN2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBYGM4DCOBUGE
.
You are receiving this because you were mentioned.Message ID:
@.***>
It's your call not mine. I have tell you about the guidelines and all the
details, i am only following the rules.
—
Reply to this email directly, view it on GitHub
https://github.com/UTSAVS26/PyVerse/issues/472#issuecomment-2408385243,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BDYCS4IJANRMUR55F25GJR3Z3CSXBAVCNFSM6AAAAABPZCGIN2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBYGM4DKMRUGM
.
You are receiving this because you were mentioned.Message ID:
@.***>

But Why You have Given level 3 for coding part!!!???
On Sat, 12 Oct, 2024, 10:17 am UTSAV SINGHAL, @.***>
wrote:

Anyway I think you are biased!!
On Sat, 12 Oct, 2024, 10:11 am UTSAV SINGHAL, @.***>
wrote:
It's not fair!!
On Sat, 12 Oct, 2024, 9:38 am UTSAV SINGHAL, @.***>
wrote:
But You have given Level 3 for coding part they haven't fixed any bugs in
that.
I Think The issue Number is #93
https://github.com/UTSAVS26/PyVerse/pull/93
#93 https://github.com/UTSAVS26/PyVerse/pull/93
#93 https://github.com/UTSAVS26/PyVerse/pull/93 #93
https://github.com/UTSAVS26/PyVerse/pull/93
On Sat, 12 Oct, 2024, 9:12 am UTSAV SINGHAL, @.***>
wrote:
@UTSAVS26 https://github.com/UTSAVS26 https://github.com/UTSAVS26
https://github.com/UTSAVS26
https://github.com/UTSAVS26 You
Assigned the Level as 1???
Do u think this is Level 1 Problem??
The thing is as stated in guidelines shared in discussion page, any type
of project or code would come under level1 and if you fix big or add new
feature in the existing codebase that will be counted in level2 and level3
.
—
Reply to this email directly, view it on GitHub
#472 https://github.com/UTSAVS26/PyVerse/issues/472 #472
https://github.com/UTSAVS26/PyVerse/issues/472 (comment)
#472 https://github.com/UTSAVS26/PyVerse/issues/472 (comment)
#472 (comment)
https://github.com/UTSAVS26/PyVerse/issues/472#issuecomment-2408335675,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BDYCS4K3TWMCAORKTCJJC3DZ3CLBFAVCNFSM6AAAAABPZCGIN2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBYGMZTKNRXGU
.
You are receiving this because you were mentioned.Message ID:
@.***>
I have updated the guidelines after that you can see the time when the
issue is raised and when the guidelines are given and in the guidelines I
have also mentioned that if i have assign the levels before they will not
be change.
—
Reply to this email directly, view it on GitHub
#472 https://github.com/UTSAVS26/PyVerse/issues/472 (comment)
#472 (comment)
https://github.com/UTSAVS26/PyVerse/issues/472#issuecomment-2408344184,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BDYCS4NCJ63IK7YTCVVJN2LZ3COFNAVCNFSM6AAAAABPZCGIN2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBYGM2DIMJYGQ
.
You are receiving this because you were mentioned.Message ID:
@.***>
It is based on the guidelines.
—
Reply to this email directly, view it on GitHub
#472 (comment)
https://github.com/UTSAVS26/PyVerse/issues/472#issuecomment-2408381841,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BDYCS4NLGKJCAC2CXEBONSDZ3CR6XAVCNFSM6AAAAABPZCGIN2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBYGM4DCOBUGE
.
You are receiving this because you were mentioned.Message ID:
@.***>
It's your call not mine. I have tell you about the guidelines and all the
details, i am only following the rules.
—
Reply to this email directly, view it on GitHub
https://github.com/UTSAVS26/PyVerse/issues/472#issuecomment-2408385243,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BDYCS4IJANRMUR55F25GJR3Z3CSXBAVCNFSM6AAAAABPZCGIN2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBYGM4DKMRUGM
.
You are receiving this because you were mentioned.Message ID:
@.***>

Have you checked the efforts and the work contributor have put?

Thats what I'm asking you!!!
Based on my work update the label ok???
On Sat, 12 Oct, 2024, 10:25 am UTSAV SINGHAL, @.***>
wrote:

But Why You have Given level 3 for coding part!!!???
On Sat, 12 Oct, 2024, 10:17 am UTSAV SINGHAL, @.***>
wrote:
Anyway I think you are biased!!
On Sat, 12 Oct, 2024, 10:11 am UTSAV SINGHAL, @.***>
wrote:
It's not fair!!
On Sat, 12 Oct, 2024, 9:38 am UTSAV SINGHAL, @.***>
wrote:
But You have given Level 3 for coding part they haven't fixed any bugs in
that.
I Think The issue Number is #93
https://github.com/UTSAVS26/PyVerse/pull/93
#93 https://github.com/UTSAVS26/PyVerse/pull/93
#93 https://github.com/UTSAVS26/PyVerse/pull/93 #93
https://github.com/UTSAVS26/PyVerse/pull/93
#93 https://github.com/UTSAVS26/PyVerse/pull/93 #93
https://github.com/UTSAVS26/PyVerse/pull/93 #93
https://github.com/UTSAVS26/PyVerse/pull/93
#93 https://github.com/UTSAVS26/PyVerse/pull/93
On Sat, 12 Oct, 2024, 9:12 am UTSAV SINGHAL, @.***>
wrote:
@UTSAVS26 https://github.com/UTSAVS26 https://github.com/UTSAVS26
https://github.com/UTSAVS26
https://github.com/UTSAVS26
https://github.com/UTSAVS26 You
Assigned the Level as 1???
Do u think this is Level 1 Problem??
The thing is as stated in guidelines shared in discussion page, any type
of project or code would come under level1 and if you fix big or add new
feature in the existing codebase that will be counted in level2 and level3
.
—
Reply to this email directly, view it on GitHub
#472 https://github.com/UTSAVS26/PyVerse/issues/472 #472
https://github.com/UTSAVS26/PyVerse/issues/472 #472
https://github.com/UTSAVS26/PyVerse/issues/472
#472 https://github.com/UTSAVS26/PyVerse/issues/472 (comment)
#472 https://github.com/UTSAVS26/PyVerse/issues/472 #472
https://github.com/UTSAVS26/PyVerse/issues/472 (comment)
#472 https://github.com/UTSAVS26/PyVerse/issues/472 (comment)
#472 (comment)
https://github.com/UTSAVS26/PyVerse/issues/472#issuecomment-2408335675,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BDYCS4K3TWMCAORKTCJJC3DZ3CLBFAVCNFSM6AAAAABPZCGIN2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBYGMZTKNRXGU
.
You are receiving this because you were mentioned.Message ID:
@.***>
I have updated the guidelines after that you can see the time when the
issue is raised and when the guidelines are given and in the guidelines I
have also mentioned that if i have assign the levels before they will not
be change.
—
Reply to this email directly, view it on GitHub
#472 https://github.com/UTSAVS26/PyVerse/issues/472 #472
https://github.com/UTSAVS26/PyVerse/issues/472 (comment)
#472 https://github.com/UTSAVS26/PyVerse/issues/472 (comment)
#472 (comment)
https://github.com/UTSAVS26/PyVerse/issues/472#issuecomment-2408344184,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BDYCS4NCJ63IK7YTCVVJN2LZ3COFNAVCNFSM6AAAAABPZCGIN2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBYGM2DIMJYGQ
.
You are receiving this because you were mentioned.Message ID:
@.***>
It is based on the guidelines.
—
Reply to this email directly, view it on GitHub
#472 https://github.com/UTSAVS26/PyVerse/issues/472 (comment)
#472 (comment)
https://github.com/UTSAVS26/PyVerse/issues/472#issuecomment-2408381841,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BDYCS4NLGKJCAC2CXEBONSDZ3CR6XAVCNFSM6AAAAABPZCGIN2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBYGM4DCOBUGE
.
You are receiving this because you were mentioned.Message ID:
@.***>
It's your call not mine. I have tell you about the guidelines and all the
details, i am only following the rules.
—
Reply to this email directly, view it on GitHub
#472 (comment)
https://github.com/UTSAVS26/PyVerse/issues/472#issuecomment-2408385243,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BDYCS4IJANRMUR55F25GJR3Z3CSXBAVCNFSM6AAAAABPZCGIN2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBYGM4DKMRUGM
.
You are receiving this because you were mentioned.Message ID:
@.***>
Have you checked the efforts and the work contributor have put?
—
Reply to this email directly, view it on GitHub
https://github.com/UTSAVS26/PyVerse/issues/472#issuecomment-2408388288,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BDYCS4L2B6LZ45MCSFB2BRTZ3CTURAVCNFSM6AAAAABPZCGIN2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBYGM4DQMRYHA
.
You are receiving this because you were mentioned.Message ID:
@.***>

Yes


Fix len in CIFAR10Sequence example in Python2

Fix PR https://github.com/fchollet/keras/pull/8275 for Python2.

An alternative would be to
use np.ceil(), since np is already imported (removes one extra line in example)
AND
1a. cast denominator to float first
or
1b from future import division (adds one extra line in example)

done. There is a place in the code with a similar issue, where readability doesn't matter, but speed may:
https://github.com/fchollet/keras/blob/master/keras/preprocessing/image.py#L762
$ python -m timeit -s 'import numpy as np' 'int(np.ceil(10 / float(3)))'
1000000 loops, best of 3: 1.17 usec per loop
$ python -m timeit -s 'import numpy as np' '(10 + 3 - 1) // 3'
10000000 loops, best of 3: 0.0185 usec per loop

I can fix it, if warranted.

Maybe there is a need for library function for that?


interpolated string has inconsistent handling of containers

Steps to reproduce
vim9script

var l = [ 'one', 'two' ]
echo '(1)' string(l)
echo '(2)' printf("%s", l)
echo '(3)' $'{l}'

echo '================='

var d = {a: 1, b: 2}
echo '(4)' string(d)
echo '(5)' printf("%s", d)
echo '(6)' $'{d}'

(3) - each list item is followed by a new line
(6) - fails on dictionary
(1) ['one', 'two']
(2) ['one', 'two']
(3) one
two
=================
(4) {'a': 1, 'b': 2}
(5) {'a': 1, 'b': 2}
(6)
Error detected while processing :source buffer=1:
line   13:
E731: Using a Dictionary as a String

Expected behaviour
According to the docs
Any expression returning a value can be enclosed between curly braces.
The value is converted to a string.

Does this mean it should be like string(expr)?
Version of Vim
9.1.301
Environment
ubuntu/gtk
Logs and stack traces
No response

I guess it should mean string(expr) then.

Closing as "won't fix" (dict is fixed, not list). See https://github.com/vim/vim/pull/14541#issuecomment-2054157620. Not sure what #7684 has to do with interpolated string.
Anyway, ${string(l)} is a workaround.

I guess it should mean string(expr) then.

Guess not.

Another way is to put it inside a List:
vim9script

var l = [ 'one', 'two' ]
echo '(1)' string(l)
echo '(2)' printf("%s", l)
echo '(3)' $'{[l]}'

echo '================='

var d = {a: 1, b: 2}
echo '(4)' string(d)
echo '(5)' printf("%s", d)
echo '(6)' $'{[d]}'

Uutput:
(1) ['one', 'two']
(2) ['one', 'two']
(3) ['one', 'two']
=================
(4) {'a': 1, 'b': 2}
(5) {'a': 1, 'b': 2}
(6) {'a': 1, 'b': 2}

My bad, it was completed.


[REACT] Add Zerion Wallet

@zerts , before I merge I got eyes from another eng on the team on this to confirm.
We encourage you to also add a brief description of how to create the Zerion wallet in our documentation/portal. This is where devs go first to check which wallets are available.
Please, see an example here: https://github.com/thirdweb-dev/docs/blob/main/docs/onboarding/14 Wallet/1 Wallets/MetaMask.mdx

@zerts , two things we realized:

When I don't have the Zerion extension installed I'm getting an error. Instead you could show a UI to suggest the user to install your extension.
If the extension is not installed and given that you have a mobile app that supports WCV2, you should also provide the option to users to connect via the WCV2 QRCode.

Please, check our MetaMask implementation to see how we did it. In your case it should be pretty similar sin Zerion also has the extension + mobile wallet combo:
https://github.com/thirdweb-dev/js/blob/main/packages/react/src/wallet/wallets/metamask/metamaskWallet.tsx
https://github.com/thirdweb-dev/js/blob/main/packages/react/src/wallet/wallets/metamask/MetamaskConnectUI.tsx

@iketw Thank you for noticing!
I'll add an update tomorrow!

/release-pr


Several bugs in solidcommunity.net UI with language entries in one's pod

Hello!
While adding Languages (WebID is https://dimou.solidcommunity.net/profile/card#me) I see text:
"Add one or more knows Language". If it means "Add one or more known Languages", please fix the typo.
It puts off newcomers to Solid!
I also want to add "russian", it only accepts "russu". What is this?!?!

The same with "french". It gives me "Lenga haitian creole french" and something more exotic, no way to enter the french spoken in France...
Please fix this.
Grateful
Maria Dimou

to a) (the typo) ... finding the part of the code that shows that message should be no problem.
to b) I think it is because the language is shown in that specific language. so english , francais or deutsch .

Lieber Matthias,
ich danke Dir fuer Deine schnelle Antwort.
I think the explanation to 'b' is brilliant, still unacceptable.
I trust there must be a way en français to say "Lenga haitian creole french", still this bogus description is offered in english.
Moreover, WHY "Modern Greek" works and is not presented, by the same algorithm as Ελληνικά?
Whatever the explanation I doubt I am the only multi-lingual and puzzled Solid pod owner.
Thanks again for considering my proposal to fix this.
Yours
Maria

The typo is in fact more complicated, as the prompt is built up automatically from the label on the predicate, in the ontology, which i this case says "knows language".   So just adding a label with priority (like ui:label)  to the schema or the form metadata "known language" or for that matter just "language" should fix that problem.
The language selection problems you have are more complicated. I can't see from the screen shot clearly what you are being offered.  Looking at your profile I see it has three competing versions of your language preferences, where  each list contains the language Modern Greek.  Maybe it is trying to offer you choices of other languages in greek.  Can you show what options you are getting?  Maybe they are being displayed in greek, but the browser don't have greek fonts or something.
:id1629201755476 solid:publicId l:el.
[...]
:me
    a schema:Person, foaf:Person;
    schema:knowsLanguage
        ( :id1629201755476 :id1629201806315 :id1629201830484 ),
        ( :id1629201755476 ),
        ( :id1629201755476 :id1629201806315 );

Sorry my screenshot was ridiculously small.

Grateful to @timbl for the explanations.
Here comes another screenshot about the french. I tried to type français as @ewingson suggested. See what happens:

Tutlayt Tafransist is what comes up when I type franç. Before I finish the string Tutlayt... comes up and can't be overriden.
The browser has greek characters.
Thanks again!

to test the above I tried to enter Ελληνικά. Contrary to français case above, this was accepted and overriden by what you see below. It means Modern Greek (so it doesn't complain if a language is entered more than once, in various languages. :-)

The language selection is done sending the strings you type to Wikidata at the bottom of the profile form https://github.com/solid/solid-panes/blob/main/src/profile/profileFormText.ttl#L359

so anything you type in any language is sent of to see if it matches any language code label in any language.  The language code itself, not the label, is currently stored in your pod.   Yes, there is no check you don't have two the same.   Strange that typing "french" did not give you  "French".  Maybe something to do with post-filtering the results for things in your language.

Hmmmm... console trace from reproducing the situation:

aka
Setting lock at "fre"
mashlib.min.js:172 getPreferredLanguages: No publiID of language.
(anonymous) @ mashlib.min.js:172
mashlib.min.js:172      User knows languages with codes: "el,el"
mashlib.min.js:1 Setting lock at "fren"
mashlib.min.js:172 getPreferredLanguages: No publiID of language.
(anonymous) @ mashlib.min.js:172
mashlib.min.js:172      User knows languages with codes: "el,el"
mashlib.min.js:1    Querying database at "fren" cf last "undefined".
mashlib.min.js:172 getPreferredLanguages: No publiID of language.
(anonymous) @ mashlib.min.js:172
mashlib.min.js:172      User knows languages with codes: "el,el"
mashlib.min.js:1 Querying public data - sparql: SELECT ?item ?subject ?name
WHERE
{ ?item wdt:P305 ?subject .
  OPTIONAL {?item rdfs:label ?name}
  OPTIONAL {?item wdt:P1705 ?name}
  FILTER regex(?name, "fren", "i")
  FILTER regex(?subject, "^..$", "i")
}
mashlib.min.js:1  queryPublicDataSelect uri: https://query.wikidata.org/sparql?query=SELECT+%3Fitem+%3Fsubject+%3Fname%0AWHERE%0A%7B+%3Fitem+wdt%3AP305+%3Fsubject+.%0A++OPTIONAL+%7B%3Fitem+rdfs%3Alabel+%3Fname%7D%0A++OPTIONAL+%7B%3Fitem+wdt%3AP1705+%3Fname%7D%0A++FILTER+regex%28%3Fname%2C+%22fren%22%2C+%22i%22%29%0A++FILTER+regex%28%3Fsubject%2C+%22%5E..%24%22%2C+%22i%22%29%0A%7D
mashlib.min.js:1 Ignoring "frenc" because of lock
mashlib.min.js:1     Query result JSON{
    "head": {
        "vars": [
            "item",
            "subject",
            "name"
    ...
mashlib.min.js:1  Filter by language: 15 -> 2
mashlib.min.js:1  Filter:"fren" lastBindings: 2, slimmed to 2; rows: 2, Enough? true, All displayed? true

Query results re-running the wikidata query:
{"head":{"vars":["item","subject","name"]},"results":{"bindings":[{"item":{"type":"uri","value":"http://www.wikidata.org/entity/Q150"},"subject":{"type":"literal","value":"fr"},
  "name":{"xml:lang":"en","type":"literal","value":"French"}},{"item":{"type":"uri","value":"http://www.wikidata.org/entity/Q150"},"subject":{"type":"literal","value":"fr"},
  "name":{"xml:lang":"en-ca","type":"literal","value":"French"}},{"item":{"type":"uri","value":"http://www.wikidata.org/entity/Q150"},"subject":{"type":"literal","value":"fr"},

  "name":{"xml:lang":"en-gb","type":"literal","value":"French"}},{"item":{"type":"uri","value":"http://www.wikidata.org/entity/Q150"},"subject":{"type":"literal","value":"fr"},

  "name":{"xml:lang":"sco","type":"literal","value":"French"}},{"item":{"type":"uri","value":"http://www.wikidata.org/entity/Q150"},"subject":{"type":"literal","value":"fr"},

  "name":{"xml:lang":"jam","type":"literal","value":"French"}},{"item":{"type":"uri","value":"http://www.wikidata.org/entity/Q150"},"subject":{"type":"literal","value":"fr"},

  "name":{"xml:lang":"pih","type":"literal","value":"French"}},{"item":{"type":"uri","value":"http://www.wikidata.org/entity/Q150"},"subject":{"type":"literal","value":"fr"},

  "name":{"xml:lang":"ang","type":"literal","value":"Frenċisċ sprǣc"}},{"item":{"type":"uri","value":"http://www.wikidata.org/entity/Q150"},"subject":{"type":"literal","value":"fr"},
  "name":{"xml:lang":"crh","type":"literal","value":"Frenk tili"}},{"item":{"type":"uri","value":"http://www.wikidata.org/entity/Q150"},"subject":{"type":"literal","value":"fr"},
  "name":{"xml:lang":"crh-latn","type":"literal","value":"Frenk tili"}},{"item":{"type":"uri","value":"http://www.wikidata.org/entity/Q150"},"subject":{"type":"literal","value":"fr"},
  "name":{"xml:lang":"st","type":"literal","value":"Se-french"}},{"item":{"type":"uri","value":"http://www.wikidata.org/entity/Q150"},"subject":{"type":"literal","value":"fr"},
  "name":{"xml:lang":"tpi","type":"literal","value":"Tok Frens"}},{"item":{"type":"uri","value":"http://www.wikidata.org/entity/Q150"},"subject":{"type":"literal","value":"fr"},
  "name":{"xml:lang":"xh","type":"literal","value":"Ulwimi lwasiFrentshi"}},{"item":{"type":"uri","value":"http://www.wikidata.org/entity/Q150"},"subject":{"type":"literal","value":"fr"},
  "name":{"xml:lang":"hif","type":"literal","value":"French bhasa"}},{"item":{"type":"uri","value":"http://www.wikidata.org/entity/Q150"},"subject":{"type":"literal","value":"fr"},
  "name":{"xml:lang":"kw","type":"literal","value":"Frenkek"}},{"item":{"type":"uri","value":"http://www.wikidata.org/entity/Q33491"},"subject":{"type":"literal","value":"ht"},
  "name":{"xml:lang":"pms","type":"literal","value":"Lenga haitian creole french"}}]}}

So.. when you typed "fren" it narrowed it to two languages, 14 labels for French  (Q150 ) in different languages, and one label in one language for Haitian Creole (Q33491).  Of the many for French, it looked for one in Greek but there was greek label for the French language. So it picked randomly - and do you got the label for french in Xhosa!  Hence your puzzlement at "Ulwimi lwasiFrentshi" as clearly your Xhosa is not up to level of your other languages!  This is why it is so valuable to have real users!
As a fix, a simple thing do do might be to temporarily append "en, fr, de, ar, cn" say to the list of preferred languages which is passed into the function, being admittedly western-centric with the order.
That would be for general multi-lingual queries from somewhere like Wikidata.
But for the case of a name for a language itself, we should probably prioritize the language itself of course, so you wold have got "Français" if you had typed "fran" instead of "fren".

Thanks again @timbl.
Maybe present the pod owner with a drop down menu to select from, where all exotic languages can be present, including the ones most people know.
In this way one doesn't wonder now whether to write french or français.

Btw,
the Νέα ελληνική γλώσσα of yesterday was replaced by Modern Greek overnight (it wasn't me).
German gives fantastic varieties of germanic(?) dialects and Yiddish (maybe), wherelse the orthodox Deutsch is simply not accepted.
Please see screenshot:

Recording for the record due to difficulty to navigate inside a busy gitter channel:
Discussing this again with @timbl and @jeff-zucker starting with gitter post https://gitter.im/solid/solidos?at=61f159209a335454064067d6

This should be fixed now.


TensorflowLite Upsampling2D does not change output shape when resize_input_tensor is called

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): Yes (code can be found here https://github.com/benjamintanweihao/YOLOv3)
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Windows, but probably all
TensorFlow installed from (source or binary): binary
TensorFlow version (use command below): 1.14.0
Python version: 3.7.3
CUDA/cuDNN version: 10.0
GPU model and memory: NVIDIA GTX 1070 8GB

Describe the current behavior
Upsampling 2D set to twice the size of the input always outputs the size set at convert time, even when resize inputs are called.
Describe the expected behavior
Upsampling2D outputs size times the size of the new input
Code to reproduce the issue
import tensorflow.keras as keras
from tensorflow.lite.python import lite, interpreter

#define model that uses upsampling 2D and depends on it's output changing with the input size
def DemoModel():
  inputs = keras.layers.Input(shape=[None,None, 3], name="input_1")
  a = keras.layers.MaxPooling2D((2,2))(inputs)
  b = keras.layers.UpSampling2D(size=(2,2))(a)
  c = keras.layers.Concatenate()([b, inputs])
  return keras.models.Model(inputs=[inputs], outputs=[a, c])

#convert to tflite
model = DemoModel()
model.compile(optimizer="sgd", loss="mean_squared_error")
model.save("testModel.h5")

converter = lite.TFLiteConverter.from_keras_model_file("testModel.h5", input_shapes={'input_1': [1,32,64,3]})
tflite_model=converter.convert()

#run the tflite model

inter = interpreter.Interpreter(model_content=tflite_model)
print(inter.get_input_details())
inter.resize_tensor_input(1, [1,16,32,3])
inter.allocate_tensors()
print(inter.get_input_details())

Is there a workaround for this or any fix in any of the 2.x releases?

Hi There,
We are checking to see if you still need help on this, as you are using an older version of tensorflow which is officially considered end of life . We recommend that you upgrade to the latest 2.x version and let us know if the issue still persists in newer versions. Please open a new issue for any help you need against 2.x, and we will get you the right help.
This issue will be closed automatically 7 days from now. If you still need help with this issue, please provide us with more information.

The above code run on tf 2.4.0 gives the following runtime error:
RuntimeError: Attempting to resize a fixed-size tensor.
I guess that this probably indicates that tensorflow lite doesn't support changing the input size at runtime then?


Make spec more user friendly

We should make the spec section more user friendly because that is where we direct people who want in depth documentation on Pulumi YAML. This was brought up from the following conversation:

Thanks — this is useful info that should make it into the docs. I wondered myself whether there was way to name something differently from its resource name. Is this documented yet?

Originally posted by @cnunciato in https://github.com/pulumi/templates/issues/281#issuecomment-1120566968

We should likely also move this content into the docs while we are at it.


List signals and remove signals without label

It would be nice to see a list of registered signals and remove them without having to reload yabai.
For example, list the signals (not sure if JSON output would be more consistent):
$ yabai -m signal --list
0: event=application_activated action=...
1: event=application_activated action=...
2: event=space_changed action=...

Then delete them by index:
$ yabai -m signal --remove 2

Not sure if I see the point in this. I don't think "permanent" signals should be manually queried and modified in a running session. If you are still in a prototyping stage, labels are just as simple to utilize in my opinion. If you are modifying signals during runtime, I would also suggest labeling them.

I have the same feeling that something is missing in the signal labelling feature.
May I propose alternatives:

add a "-m signal clear" action to remove all signals
make "label" mandatory
if "label" is missing, randomly generate one (however still need a "-m signal list" feature

However the API is asymmetric that cuz we can add but remove only those with label.

I’m not trying to be difficult here, but I still don’t see any actual gain in usability by making these changes. Signals are not meant to be modified by a user manually at runtime. The label only exists because it is useful for a script to recognize a signal it automatically created, so that it can later be removed or rewritten from the same script.
Sent from my iPhone
On 21 Apr 2020, at 14:34, Jonathan Huot<EMAIL_ADDRESS>wrote:

I have the same feeling that something is missing in the signal labelling feature.
May I propose alternatives:

add a "-m signal clear" action to remove all signals
make "label" mandatory
if "label" is missing, randomly generate one (however still need a "-m signal list" feature

However the API is asymmetric that cuz we can add but remove only those with label.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/koekeishiya/yabai/issues/458#issuecomment-617151201, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABPDZVZM4P6X5YZYZKKPLEDRNWHEVANCNFSM4LT4IVDA.

If someone can come up with a practical problem they are trying to solve, that require changes to the signal system, or is tedious to do, because of limitations of the current system, please let me know and we can discuss viable solutions from that point.

Having a function to list existing signals would let users inspect this hidden state, making it easier to set up new signal handlers. When I created signal handlers, it was quite confusing because at some point I ended up with multiple handlers registered to the same signal and no way to query this information, so I had to restart yabai often.

Implemented on master.

sample output:
~ yabai -m signal --list | jq                                                                     0:48
[
  {
    "index": 0,
    "label": "",
    "app": "",
    "title": "",
    "event": "application_terminated",
    "action": "yabai -m query --windows --window &> /dev/null || yabai -m window --focus mouse"
  },
  {
    "index": 1,
    "label": "",
    "app": "",
    "title": "",
    "event": "application_activated",
    "action": "pkill -SIGUSR1 limelight &> /dev/null"
  },
  {
    "index": 2,
    "label": "",
    "app": "",
    "title": "",
    "event": "window_destroyed",
    "action": "yabai -m query --windows --window &> /dev/null || yabai -m window --focus mouse"
  },
  {
    "index": 3,
    "label": "AA1BE1CD-6665-47B5-B5C4-111FBFFF0E1D",
    "app": "",
    "title": "",
    "event": "window_moved",
    "action": "\trestore=\"$(yabai -m query --windows --window \"${YABAI_WINDOW_ID}\" |\n    jq -re --arg YABAI_WINDOW_ID \"${YABAI_WINDOW_ID}\" '\n        if .floating == 1 then\n           .frame | \"yabai -m window \\($YABAI_WINDOW_ID) --move abs:\\(.x):\\(.y)\\n\"\n               + \"yabai -m window \\($YABAI_WINDOW_ID) --resize abs:\\(.w):\\(.h)\"\n        else\n            empty\n        end')\" \n\tif [[ ! -z \"${restore}\" ]]\n\tthen\n\t\techo \"${restore}\" > \"/tmp/yabai-restore/${YABAI_WINDOW_ID}.restore\"\n\t\tchmod +x \"/tmp/yabai-restore/${YABAI_WINDOW_ID}.restore\"\n\tfi"
  },
  {
    "index": 4,
    "label": "91CC175D-9D33-4D48-9767-0FAF33E63209",
    "app": "",
    "title": "",
    "event": "window_resized",
    "action": "\trestore=\"$(yabai -m query --windows --window \"${YABAI_WINDOW_ID}\" |\n    jq -re --arg YABAI_WINDOW_ID \"${YABAI_WINDOW_ID}\" '\n        if .floating == 1 then\n           .frame | \"yabai -m window \\($YABAI_WINDOW_ID) --move abs:\\(.x):\\(.y)\\n\"\n               + \"yabai -m window \\($YABAI_WINDOW_ID) --resize abs:\\(.w):\\(.h)\"\n        else\n            empty\n        end')\" \n\tif [[ ! -z \"${restore}\" ]]\n\tthen\n\t\techo \"${restore}\" > \"/tmp/yabai-restore/${YABAI_WINDOW_ID}.restore\"\n\t\tchmod +x \"/tmp/yabai-restore/${YABAI_WINDOW_ID}.restore\"\n\tfi"
  }
]

Remove by using the index from the output: yabai -m signal --remove 1
Note that the index is based on its location in the list and is not a fixed identifier, e.g if you remove signal with index 4, the signal that previously had index 5 will now become index 4.


RPM related Python binding Installer collection

Summary
Currently rpm-py-installer is "RPM Python binding Installer".
In the future, it is going to be like a "RPM related Python binding Installer collection".
This ticket manages the implmentation.
It is like gcc changing from "Gnu C Compiler" to "Gnu Compiler Collection".
Situation
The situation is
project name: fm-orchestrator(module name: module-build-service can not install from source by pip directly.
https://pagure.io/fm-orchestrator/issue/700
The reason is
module-build-service depends on koji.
But koji is not in PyPI.
Because koji depends on RPM Python binding (rpm-python).
And RPM Python binding is not in PYPI.
So, rpm-py-installer is useful for this situation.
But challenging is
koji depends on another Python binding module python-libcomps.
https://pagure.io/koji/blob/master/f/koji.spec

Requires: python%{python3_pkgversion}-libcomps
Requires: python-libcomps

python-libcomps's source is here.
https://src.fedoraproject.org/rpms/libcomps
https://github.com/rpm-software-management/libcomps/tree/master/libcomps/src/python/src
So, maybe I will implement the installer too, if koji needs it.
Related information: hawkey is Python binding module. But it will be unprovided soon.
https://github.com/junaruga/rpm-py-installer/issues/17
Steps to implement.

Check koji needs python-libcomps in the setup.py to install koji from pip.
If koji needs it, list up RPM project's python binding modules that are available. It is not like hawkey.
Implementation

Manage installers in one repository. Because those are common logic.
https://github.com/junaruga/rpm-py-installer
  rpm-py-installer/ <= current top directory
    rpm_py_installer/ <= py source directory.
    setup.py <= setup.py for rpm-py-installer
    installer.py <= installer.py for rpm-py-installer
  installer_b/
    setup.py <= setup.py for installer_b
    installer.py <= installer.py for installer_b
  installer_c/
    setup.py
    installer.py

Generate a list of install.py from common logic.
install.py is necessary for Direct Install.
Every installer has same version number.
My concern is CI running time becomes longer.

This is a page about koji installing from PyPI.
https://pagure.io/koji/issue/458


invalid supported color modes with 3.0 and 2024.3

-->
Version of the integration
 latest, 3.0
Configuration

Tapo L920 with latest firmware (1.1.3)
Add your logs here.

Describe the bug
Logs show this error after updating to 3.0 (from 2.14 i believe?) and 2024.3 HAOS. Also automations with color change doesn't work on this lightstrip now and showing error:
"  File "/usr/local/lib/python3.12/site-packages/plugp100/common/functional/tri.py", line 159, in get_or_raise
raise self.value
plugp100.responses.tapo_exception.TapoException: Returned error_code: TapoError.ERR_PARAMS: Request params error"
That's account only my Tapo LED, other light from different brand is fine
Debug log

Add your logs here.

Hi
I've got something similar.

Fixed by 3.1.0


Enhance docs: local node

Review required specs to run local node

This issue will be revisited when local node provides a better experience.

https://docs.hedera.com/hedera/tutorials/more-tutorials/how-to-set-up-a-hedera-local-node


[Event Request] codeunit 7322 "Create Inventory Pick/Movement" - OnCreatePickOrMoveLineOnCheckCompleteShipment

Can we please get the following event?
local procedure CreatePickOrMoveLine(NewWhseActivLine: Record "Warehouse Activity Line"; var RemQtyToPickBase: Decimal; OutstandingQtyBase: Decimal; ReservationExists: Boolean)
var
    ReservationEntry: Record "Reservation Entry";
    ATOSalesLine: Record "Sales Line";
    WhseItemTrackingSetup: Record "Item Tracking Setup";
    ItemTrackingMgt: Codeunit "Item Tracking Management";
    QtyAvailToPickBase: Decimal;
    OriginalRemQtyToPickBase: Decimal;
    ITQtyToPickBase: Decimal;
    TotalITQtyToPickBase: Decimal;
    QtyToTrackBase: Decimal;
    EntriesExist: Boolean;
    ShouldInsertPickOrMoveDefaultBin: Boolean;
begin
....
if RemQtyToPickBase > QtyAvailToPickBase then begin
    //+Event
    OnCreatePickOrMoveLineOnCheckCompleteShipment(WhseActivHeader, WhseItemTrackingSetup."Serial No. Required", WhseItemTrackingSetup."Lot No. Required", ReservationExists, RemQtyToPickBase, QtyAvailToPickBase);
    //-Event
    RemQtyToPickBase := QtyAvailToPickBase;
    CompleteShipment := false;
end;
....
end;

[IntegrationEvent(false, false)]
local procedure OnCreatePickOrMoveLineOnCheckCompleteShipment(WarehouseActivityHeader: Record "Warehouse Activity Header"; SNRequired: Boolean; LNRequired: Boolean; ReservationExists: Boolean; RemQtyToPickBase: Decimal; QtyAvailToPickBase: Decimal)
begin
end;

I requested this additional event, because the event OnCreatePickOrMoveLineOnAfterCalcQtyAvailToPickBase has the followin decimal values passed by reference  var RemQtyToPickBase: Decimal; var QtyAvailToPickBase: Decimal.
Therefore other apps could subscribe to this event to change those values.
And since the execution order is not deterministic we cannot be sure that we are the last event and we can't check this condition RemQtyToPickBase > QtyAvailToPickBase in our subscriber .
This was my reason for the second event where none of  these values is passed by reference.

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


Display more than 25 options

I have a list of options that exceed 25. How would I display all of them?

you can use the search-limit attribute http://bentorfs.github.io/angular-bootstrap-multiselect/#example-largedatasets


How to auto-upload generated apk to Slack?

Despite Googling and looked through the issues here I've failed to find a way to auto-upload an apk that has been built using Fastlane to a Slack channel.
Has anybody else managed to do this and if so, how?

While totally possible, it's not implemented in fastlane, but it would be a really cool addition to the slack action that we have. It looks pretty complicated (https://api.slack.com/tutorials/working-with-files) but definitely possible 👍

Hi @taquitos, thanks for getting back to me.
Is there any way this might be officially implemented in the near future?
If not I could have a go and share it with the community if I work it out.

We're super busy at the moment, but it could be something somebody in the community might want to pick up and run with. If that's something you'd like to do, we have a getting started guide: Your First PR and we'd be happy to provide any guidance 😄


Add Matrix URL to footer

Netlify deploy preview URL seem broken.

@sahilister yup, looks like the integration was not done correctly. If you are up to fix it, can pass you the credentials.

@planemad sure, I can give it a shot. Shouldn't be too hard I guess.
Can you send the creds on Telegram? Same nick for me there.


Minor issue with jira provider

Hey rafi!
There may be a minor bug:
autoload/issue/provider line195
" Get the amount of room for the ticket summary / labels
let ww = winwidth(0) - s_width - t_width - 37
if ww < 0
       ww = 10
endif

I believe it should be let ww = 10, otherwise, it crashes.
Thanks!

Fixed. thank you!


Which Organization Should I Choose for the Lab

I am starting the DevOps White Belt DoJo lab for Continuous Planning. I'm trying to do Task 1: Configuring the Parts Unlimited team project.
It asks to Select your Azure DevOps organization, but I don't have one that I know of to select. I don't know how to create an organization for this Lab.
Can you please help? The clock is ticking and I have a limited time to complete this entire course!

HI @smacar01 ,
You can create from here
https://azure.microsoft.com/en-in/services/devops/
https://docs.microsoft.com/bs-cyrl-ba/azure/devops/organizations/accounts/create-organization?view=azure-devops#create-an-organization
Thanks


About introducing-goproxy-light-http-proxy

The link on the front page for introducing-goproxy-light-http-proxy, http://ripper234.com/p/introducing-goproxy-light-http-proxy/, is gone.
Has it been moved to somewhere else? Thx.

I removed it, since this website seem to go offline soon.

Do you still have a copy somewhere?

As far as I can see, it's still available, but without CSS.
Care to mirror it somewhere?
On Sun, Sep 18, 2016, 5:26 PM suntong<EMAIL_ADDRESS>wrote:

Do you still have a copy somewhere?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/elazarl/goproxy/issues/186#issuecomment-247850679,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAP4ojgZJea-LiB13V1eau84gUkszeaIks5qrUn5gaJpZM4J9F_J
.

Oh, I only saw "This blog has moved to Medium", then checked over there without scrolling further down. Will put it into my personal private collection before it went away.

Can you please put it online, and I'll add a link to where you add it?
On Mon, Sep 19, 2016 at 1:34 AM suntong<EMAIL_ADDRESS>wrote:

Oh, I only saw "This blog has moved to Medium", then checked over there
without scrolling further down. Will put it into my personal private
collection before it went away.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/elazarl/goproxy/issues/186#issuecomment-247885411,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAP4os9oaURnA2QPnRRcSmsUCI6OXDKqks5qrbyOgaJpZM4J9F_J
.

Sorry I don't have a proper online place to mirror it either. Maybe you put it into your wiki page?


Enable user to uncheck wich question he want to see on the Chartscreen

Fixed in 8d5201bcc29de456d8ea71f13d3216658ed1c8fc

Fixed in 8d5201bcc29de456d8ea71f13d3216658ed1c8fc

Fixed in 8d5201bcc29de456d8ea71f13d3216658ed1c8fc


Doesn't seem to work

<EMAIL_ADDRESS>returns the following:
import { initFontPicker as i } from "./index.js";
i();

Obviously, from client's perspective index.js is nil.

Thanks for reporting this. If you import it as a module, it should work:
<script type="module"<EMAIL_ADDRESS>
I need to at least change the documentation, but it would be better if it didn't require modules in the first place.

It turned out to be easy to change it to not require a module, so the original url should now work (when jsdelivr refreshes its cache)


Segfault on mobian(running Linux 6.6 and pretty-much Debian 12)

The device is a OnePlus 6T with a Snapdragon 845 SoC.

Oki i have tested on xiaomi poco f1 mobian and redmi note 9s droidian both debian 12 not faced seg faults so we gonna need to see where it happens for you there is a debug branch in wlgamepad i do push latest changes on it try it if still issue i will see thx for reporting issues
My telegram
https://t.me/Petronazeh1


Train Llama-3-8B-Instruct on my own dataset

How can I train llama-3-8B-Instruct with my own dataset in csv format? Do you have a code or idea?

You can use this repo. unslothai
There are sample colab notebooks for llama-3-8B.


Add eml_validate_full function

Just a programattic way to use https://knb.ecoinformatics.org/emlparser which can fully validate EML documents. EML::eml_validate only checks for schema validity which only partly helps you know whether your document will upload successfully because Metacat Member Nodes (such as {test.}arcticdata.io) enforce additional constrains on EML documents (like custom units needing to be defined).
The response is just raw HTML but it's short and readable. Further tweaks could be made to parsing the response if desired or we could make the EML validator return a more parseable output. I decided to wait on any of that to see if this is useful in the first place.

@amoeba We've added checks for schema-validity according to the rules in EML 2.2.1 in https://github.com/ropensci/emld/pull/27, (I believe this also includes checks for the test files included in the EML source).  If we're missing something, a bug report and/or PR against emld's validation check would be super!
(Note that now the EML package simply re-exports the validation routine implemented in emld)

Nice addition @amoeba. I think it would be good for the datateam to use this as the first choice in validators for EML documents, and maybe falling back to eml_validate if a more familiar output along the lines of "got X element, expected Y" is needed.
Regarding the output: The HTML doesn't bother me too much, but I think it should definitely be shorter for EML documents that pass. Right now it is hard to tell at a glance whether it passed or not. This should be an easy fix though

Hey @cboettig, my apologies for not pointing that out in my PR: IIRC arcticdatautils and the team that uses it are still on the old EML so they only have access to the first version of EML::eml_validate so this function is just a stop-gap until then.
@jeanetteclark 	That sounds like a vote for some parsing. The HTML we'd have to parse of clean up is generated in https://github.com/NCEAS/eml/blob/4417cbf6588fdca4e06bd67190a9d7a18a8e944f/src/main/java/org/ecoinformatics/eml/EMLParserServlet.java#L239-L302.

The #135 PR just landed and we're working through it now. It obviates any need for this PR. I'll leave this open but feel free to close when we merge the EML2 refactor.

Now that the eml2 branch is merged, do we still want this for any reason? I'm in favor of deleting this PR so we get everyone using eml_validate. Any differences between the Metacat EMLValidator and EML::eml_validate should get resolved and having a path around improving EML::eml_validate won't help.

That's ok with me

Closing as discussed. If anyone still wants this, feel free to comment or reopen.


Xiaomi aqara gateway unavailable after some time

Home Assistant release with the issue:

0.71.0, 0.70.1
Last working Home Assistant release (if known):
unknown
Operating environment (Hass.io/Docker/Windows/etc.):

Docker (homeassistant/home-assistant:0.71.0)
Component/platform:

https://www.home-assistant.io/components/xiaomi_aqara/
Description of problem:
All sensor data is available when home-assistant starts up, but after some time all sensors connected to the xiaomi aqara gateway become unavailable. Restarting home-assistant fixes the issue
Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):
xiaomi_aqara:
  gateways:
    - key: *****************
      mac: ****************
      host: ****************

Traceback (if applicable):

Additional information:
There are no aqara/gateway related error messages.

I have more or less the same issue here.
In my case the gateway remains online while some sensors become unavailable.
Restarting HA --> I have all sensors back but I need to add that no heartbeat is received for these sensor  (confirmed by wireshark) so after 150min they go back to unavailable (and that is the expected behaviour as far as I've read here https://github.com/home-assistant/home-assistant/pull/11631 )
I would like to add that forcing poll with self._should_poll = True in components/binary_sensor/xiaomi_aqara.py seem to avoid the unavailable issue but (apart from gas sensor that doesn't have a battery) I don't think this should be the correct way, even because it generates a lot of traffic and I need to check as soon as I come back home that the sensor effectively changes its state when kept alive with polling.
Question: Is there any way to trigger a poll to a sensor from a script for example? I'd like to check whether, if polled, the sensor goes back to available.
Thanks in advance

Last time I checked my sensors where still online in mi-home, but I'll try to confirm this.
@luci-11 which firmware/hardware version of the gateway are you using?

hello to everyone,
I have the same problem, all my 4 sensors (pir, temp, door and  button) are no more available on ha (0.71). Currently I can not make a clean restart because the system stops at this point:
2018-06-14 18:15:51 INFO (Thread-13) [homeassistant.components.xiaomi_aqara] Shutting down Xiaomi Hub
2018-06-14 18:15:51 INFO (Thread-13) [xiaomi_gateway] Closing socket
2018-06-14 18:15:51 INFO (Thread-13) [xiaomi_gateway] Closing multisocket
I tried the following attempts without any good result:

downgrade up to 0.67
downgrade of pycryptodome to version 3.3.1
remove and reconfigure the gateway and sensors from the application mi-home

after all these attempts the situation is this, I can see the values of the sensors after the restart but these are not updated anymore and after 150min they go back to unavailable again
@luci-11 have you solved in some way?
Thanks in advance

I have slightly different (and potentially related) issue. All my sensors appear offline on the Mi Home app, but they appear fine in HA.

@groggemans i have xiomi gateway v3, firmware version 1.4.1_155.0143

I'm also running 1.4.1_155.0143 with hw version 3.
@PsycoS81 does it stop while exiting? or while starting again?

@groggemans while exiting

Same issue for me :
Home Assistant release with the issue:
0.71.0
Last working Home Assistant release (if known):
unknown
Operating environment (Hass.io/Docker/Windows/etc.):
Docker (homeassistant/home-assistant:0.71.0)
Component/platform:
https://www.home-assistant.io/components/xiaomi_aqara/
It only gets the sensors state/values at HA start then nothing updates until all Aqara sensors become unavailable.

I just install https://github.com/monster1025/aqara-mqtt with the aqara-mqtt container bound to the host network interface and it works like a charm :-)

Can somebody provide debug logs? I will provide some instructions if needed.

@syssi which log files do you need?

I can confirm @captnbp's observation that the sensors are only updated once when HA starts.
Currently running in debug mode, hopefully this results in some usable logs.

@syssi any (preferably not public) way to send you the log? (its 1800 lines, from the start of home assistant til just after sensors become unavailable)

Just drop me a mail<EMAIL_ADDRESS>

@groggemans I've checked your logs. Your Home Assistant instance is unable to receive multicast traffic. Could you describe your network setup in detail? Do you use this setting:
If you are using Home Assistant in Docker, make sure to use --net=host.

I'm running in docker with --net=host (using nomad container orchestrator/scheduler).
The server has a virtual interface on a vpn which is used for web interface access (subnet 128 and 132) and a physical interface connected in the network the gateway is in (subnet 0).
Aren't the chromecasts and yeeelights also using multicast traffic? These work just fine, so I didn't suspect this to be the problem.

The Yeelight communication is UDP and no multicast traffic. Trust me. The multicast messages of the xiaomi gateway doesn't arrive at the HA instance.  Try other hosts on your network.

Ok, I'll check so we are sure. Any idea what the problem could be? As multicast with --net-host should work.. ?

@syssi I can see the multicast traffic inside the container, but it seems it takes the virtual vpn interface as the default interface. If I use ngrep on the correct physical interface traffic comes in as expected. Home assistant probably doesn't listen on all interfaces by default?

Per default "any" interface is used:
https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/xiaomi_aqara.py#L100
If you use the interface parameter a specific interface can be selected. You could try something like:
xiaomi_aqara:
  interface: '192.168.0.XXX'
  gateways:
    - mac: xxxxxxxxxxxx
      key: xxxxxxxxxxxxxxxx

any should contain the physical interface shouldn't it?
I've added the ip of the physical interface with this option, but it doesn't seem to make a difference.
Any other things I should try?

What's your host (operation) system? This is the code which doesn't work properly for your setup: https://github.com/Danielhiversen/PyXiaomiGateway/blob/master/xiaomi_gateway/init.py#L118-L137

The host is running ubuntu 16.04, but this should not be important, as the code runs inside a docker container. (which is running debian, stretch I believe)

I've used https://github.com/monster1025/aqara-mqtt in the past on this setup, and that worked as @captnbp reported. We might find the problem by comparing both implementations. Although I'm not really seeing any big difference in the case any is used as the interface.

@syssi Seems like my firewall was interfering. For me the problem can be considered fixed.
(didn't think of this, as ngrep showed traffic without problems)
Still have some trouble with a few sensors, but I'll open a new issue if I can't get it fixed after some investigation/debugging.
Thanks for your help and time!

@luci-11 @PsycoS81 @captnbp
You should all check if:

multicast messages are receivable/received (ngrep port 9898)
firewall allows traffic on port 9898
docker uses --net=host

in my case, I receive all multicasts except heartbeat of unavailable sensors.
Now i've moved my gateway closer to gas and water detector and they are correctly online/working in case of alarm.
Doing this now I have other sensors unreachables (offline in mihome) and that appear online in HA at restart.
So in my case it's a zigbee range problem but the first state in HA is still fake until unavailable

Correct. A device is marked as unavailable if unseen for a couple of minutes. We could invert the behaviour: All sensors will be initialized as unavailable and gets available on the first update.

Question thinking about inverted behaviour (i don't remember this thing): if a sensor changes state while unavailable in HA, you should receive  a report in any case right? .. and is report message triggering status change back from unavailable to available?

A event (window open/close) is published as a report. On network level it's a UDP multicast to <IP_ADDRESS>:9898:
$ ngrep port 9898
#
U <IP_ADDRESS>:4321 -> <IP_ADDRESS>:9898
  {"cmd":"report","model":"magnet","sid":"158d000116dff3","short_id":35590,"data":"{\"status\":\"close\"}"}
#
U <IP_ADDRESS>:4321 -> <IP_ADDRESS>:9898
  {"cmd":"report","model":"magnet","sid":"158d000116dff3","short_id":35590,"data":"{\"status\":\"open\"}"}
#

$ tail -f home-assistant.log
2018-07-03 07:55:38 DEBUG (Thread-23) [xiaomi_gateway] MCAST (report) << {'cmd': 'report', 'model': 'magnet', 'sid': '158d000116dff3', 'data': '{"status":"close"}', 'short_id': 35590}
2018-07-03 07:55:38 DEBUG (MainThread) [homeassistant.components.xiaomi_aqara] PUSH >> <Entity Door Window Sensor_158d000116dff3: on>: {'status': 'close'}

2018-07-03 07:55:41 DEBUG (Thread-23) [xiaomi_gateway] MCAST (report) << {'cmd': 'report', 'model': 'magnet', 'sid': '158d000116dff3', 'data': '{"status":"open"}', 'short_id': 35590}
2018-07-03 07:55:41 DEBUG (MainThread) [homeassistant.components.xiaomi_aqara] PUSH >> <Entity Door Window Sensor_158d000116dff3: off>: {'status': 'open'}

I'll close the issue as it seems to be fixed for most people here. Best to open a new ticket if you still have problems.


ReCaptchaField clean method was not respecting required=False

My use case required me to optionally disable and hide the captcha. The clean method wasn't respecting required=False, so this is just a super quick fix to make it work.

bump @praekelt

Merged in 2215c76b1f692fbb0eea7232f5dee81d76617602, thanks!

Released on PyPI @ 1.1.0: https://pypi.python.org/pypi/django-recaptcha


Writing to data stream in elastic returns an error

Hello,
I set up my index to be a data stream in elastic but I get an error stating the request should have op_type: create.
Is there a way to overcome, or is this not ready yet to work with data streams?
Thank you

@hmlmartins You can try this pre-release nuget-package to see if resolves your problem (Just place in local nuget-folder).
It introduces a new option called OpCodeCreate that can be used like this:
<target xsi:type="ElasticSearch" uri="http://localhost:9200/" opCodeCreate="true" />

unfortunately the lib version we are using comes bundled with another
software tool we have in place.
I will have to wait for them to update. Is it possible to get notice of
when it is no longer pre-release?
Thanks
On Wed, Oct 28, 2020 at 7:08 PM Rolf Kristensen<EMAIL_ADDRESS>wrote:

@hmlmartins https://github.com/hmlmartins You can try this pre-release
nuget-package
https://ci.appveyor.com/api/buildjobs/nws831ap6fnwg1pt/artifacts/src%2FNLog.Targets.ElasticSearch%2Fbin%2FRelease%2FNLog.Targets.ElasticSearch.7.1.20-alpha-bamrajut.nupkg
to see if resolves your problem (Just place in local nuget-folder).
It introduces a new option called OpCodeCreate that can be used like this:

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/markmcdowell/NLog.Targets.ElasticSearch/issues/132#issuecomment-718148138,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABL7K5U665JP2EJ7XP6NK6DSNBT3RANCNFSM4TBRPZJQ
.

So maybe create a small test tool that depends on the provided pre-release nuget-package. And do a quick test?
Sent from my Sony Xperia
---- hmlmartins wrote ----
unfortunately the lib version we are using comes bundled with another
software tool we have in place.
I will have to wait for them to update. Is it possible to get notice of
when it is no longer pre-release?
Thanks
On Wed, Oct 28, 2020 at 7:08 PM Rolf Kristensen<EMAIL_ADDRESS>wrote:

@hmlmartins https://github.com/hmlmartins You can try this pre-release
nuget-package
https://ci.appveyor.com/api/buildjobs/nws831ap6fnwg1pt/artifacts/src%2FNLog.Targets.ElasticSearch%2Fbin%2FRelease%2FNLog.Targets.ElasticSearch.7.1.20-alpha-bamrajut.nupkg
to see if resolves your problem (Just place in local nuget-folder).
It introduces a new option called OpCodeCreate that can be used like this:

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/markmcdowell/NLog.Targets.ElasticSearch/issues/132#issuecomment-718148138,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABL7K5U665JP2EJ7XP6NK6DSNBT3RANCNFSM4TBRPZJQ
.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/markmcdowell/NLog.Targets.ElasticSearch/issues/132#issuecomment-718453818, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACXZ7HAQD7FCKJWQAWHTNYTSNEOSBANCNFSM4TBRPZJQ.

Thanks for the feedback
We have a small dev environment, maybe I will be able to test it. Not
really sure when. Best estimate at the moment is the end of year. But I'll
keep an eye out for changes and eventually provide some feedback.
Regards,
On Thu, Oct 29, 2020 at 8:26 AM Rolf Kristensen<EMAIL_ADDRESS>wrote:

Sadly enough it will stay pre-release until someone validates it is
working.
So maybe create a small test tool that depends on the provided pre-release
nuget-package. And do a quick test?
Sent from my Sony Xperia
---- hmlmartins wrote ----
unfortunately the lib version we are using comes bundled with another
software tool we have in place.
I will have to wait for them to update. Is it possible to get notice of
when it is no longer pre-release?
Thanks
On Wed, Oct 28, 2020 at 7:08 PM Rolf Kristensen<EMAIL_ADDRESS>wrote:

@hmlmartins https://github.com/hmlmartins You can try this pre-release
nuget-package
<
https://ci.appveyor.com/api/buildjobs/nws831ap6fnwg1pt/artifacts/src%2FNLog.Targets.ElasticSearch%2Fbin%2FRelease%2FNLog.Targets.ElasticSearch.7.1.20-alpha-bamrajut.nupkg
to see if resolves your problem (Just place in local nuget-folder).
It introduces a new option called OpCodeCreate that can be used like
this:

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<
https://github.com/markmcdowell/NLog.Targets.ElasticSearch/issues/132#issuecomment-718148138
,
or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/ABL7K5U665JP2EJ7XP6NK6DSNBT3RANCNFSM4TBRPZJQ
.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub<
https://github.com/markmcdowell/NLog.Targets.ElasticSearch/issues/132#issuecomment-718453818>,
or unsubscribe<
https://github.com/notifications/unsubscribe-auth/ACXZ7HAQD7FCKJWQAWHTNYTSNEOSBANCNFSM4TBRPZJQ

.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/markmcdowell/NLog.Targets.ElasticSearch/issues/132#issuecomment-718472932,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABL7K5WS47LK2AHKSAO4EHTSNERLBANCNFSM4TBRPZJQ
.

But I'll keep an eye out for changes and eventually provide some feedback.

Excellent. Looking forward to hear about the test results.

I ran into this issue as well, so I took the time to test the PR build and it worked perfectly for me. I'm using elastic v7.9.1, and verified with the prelease package that I could still write to traditional (non data stream) indexes both with & without opCodeCreate="true". Writing to the datastream isn't successful without the opCodeCreate enabled (as expected), and is successful with it.

ElasticSearch ver. 7.5.0 has been released: https://www.nuget.org/packages/NLog.Targets.ElasticSearch


chore: fix downstream type inference

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
2495

Relevant Lines:
2495

💛  - Coveralls


failed: Error during WebSocket handshake: Unexpected response code: 400

verison:
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>error:
WebSocket connection to 'wss://westus.stt.speech.microsoft.com/speech/recognition/interactive/cognitiveservices/v1?language=ja&format=detailed&Authorization=eyJhbGc........29' failed: Error during WebSocket handshake: Unexpected response code: 400
microsoft.cognitiveservices.speech.sdk.bundle.js:3182

Related to #1845, thanks for reporting.

Plz find the network tab details,

Hi @Akkilz, for the second screenshot. Could you also dump the "Body" tab?
We want to know what exactly the HTTP 400 is talking about.
Thanks!

Request, response headers are available and response body is empty.

Hi everyone, for organization purposes it would be great if everyone could post their images over on https://github.com/Microsoft/BotFramework-WebChat/issues/1823, where this bug was originally filed. I will be closing this issue and adding the images provided by @Akkilz and @NoDirective over there. Thank you!


all: add canonical imports

Performed by:
for f in $(find gonum.org/v1/gonum/ -name "*.go"); do
	if grep -q "^package main$" $f; then echo skipping $f ...; continue; fi
	sed -i "s|^\(package .*\)$|\1 // import \"$(dirname $f)\"|" $f
done

then some manual fixes including checks of the code generation.
Locally passes CGO_LDFLAGS="-L/usr/local -lopenblas" go test ./... except for expected Dgeev error in OpenBLAS code.

I have left blas/testblas/benchautogen/autogen_bench_level1double.go as I don't know how that is invoked.

In the future is the convention to add the canonical URL to all new files?

I think so.
If we had a doc.go in every directory we could have done it there, but we didn't.

LGTM

I can redo this that way though: iterate over all package directories adding a doc.go if it doesn't exist and add the canonical path there, otherwise to the existing doc.go. Then we can slowly go over things and move the actual docs as needed.

I should not do this to *_test.go files at least. Fixing that now.

That seems like a better idea.
The other thing to check if there is a pkgname.go, for example stat has stat.go

It probably is a better idea, but it is not trivial. After much hating of bash, I think it needs a Go parser to do correctly. I can have a look at that, but not now.

Abandoning in favour of #13.


GLPK installation

CVXOPT now bundles GLPK as part of its standard Wheel distribution binaries for Linux, Windows, and macOS on PyPI. Thus all that's needed to make GLPK work out of the box with cvxpy on all but the strangest setups is pip install cvxopt. Rather than just updating the now out-of-date instructions in the documentation, cvxpy could simply add "cvxopt >= 1.2.1" as one of the install_requires items in setup.py. Then GLPK would become a first-class pre-bundled solver, just like SCS, ECOS, and OSQP (meaning updating those docs too).
If you don't want CVXOPT to be installed by default, you can always put it in setup.py's extra_requires so that people can install GLPK support with pip install cvxpy [glpk].

That's a good suggestion! Do you want to create a pull request that implements the "extra_requires" option?

I merged in PR #619


Book fails to open via OpenBookAsync (Regression)

Description
I have a book that fails to open after updating this library from v3.1.2 to v3.2
My Code:
using var epubBook = EpubReader.OpenBook(filePath, BookReaderOptions);
BookReaderOptions = = new()
    {
        PackageReaderOptions = new PackageReaderOptions()
        {
            IgnoreMissingToc = true
        }
    };

Sample EPUB file
<?xml version="1.0" encoding="utf-8"?>
<package unique-identifier="fanficfare-uid" version="2.0" xmlns="http://www.idpf.org/2007/opf">
    <metadata xmlns:dc="http://purl.org/dc/elements/1.1/" xmlns:opf="http://www.idpf.org/2007/opf">
        <dc:identifier id="fanficfare-uid">fanficfare-uid:www.royalroad.com-u87585-s26294</dc:identifier>
        <dc:title id="id">He Who Fights With Monsters</dc:title>
        <dc:creator opf:role="aut">Shirtaloon (Travis Deverell)</dc:creator>
        <dc:contributor id="id-2">FanFicFare [https://github.com/JimmXinu/FanFicFare]</dc:contributor>
        <dc:language>en</dc:language>
        <dc:date opf:event="publication">2019-07-28</dc:date>
        <dc:date opf:event="creation">2022-09-17</dc:date>
        <dc:date opf:event="modification">2022-09-17</dc:date>
        <meta content="2022-09-17T00:00:30" name="calibre:timestamp" />
        <dc:description>Some description here</dc:description>
        <dc:subject>High Fantasy</dc:subject>
        <dc:subject>Last Update: 2022/09/17</dc:subject>
        <dc:subject>LitRPG</dc:subject>
        <dc:subject>Adventure</dc:subject>
        <dc:publisher>www.royalroad.com</dc:publisher>
        <dc:identifier opf:scheme="URL">https://www.royalroad.com/fiction/26294</dc:identifier>
        <dc:source>https://www.royalroad.com/fiction/26294</dc:source>
    </metadata>
    <manifest>
        <item href="toc.ncx" id="ncx" media-type="application/x-dtbncx+xml" />
        <item href="OEBPS/stylesheet.css" id="style" media-type="text/css" />
        <item href="OEBPS/title_page.xhtml" id="title_page" media-type="application/xhtml+xml" />
        <item href="OEBPS/file0001.xhtml" id="file0001" media-type="application/xhtml+xml" />
        ...
        <item href="OEBPS/file0153.xhtml" id="file0153" media-type="application/xhtml+xml" />
    </manifest>
    <spine toc="ncx">
        <itemref idref="title_page" linear="yes" />
        <itemref idref="file0001" linear="yes" />
        ...
        <itemref idref="file0153" linear="yes" />
    </spine>
</package>

I have validated all items exist and table of contents looks fine.
Stack Trace:
[18:47:11 WRN] [BookService] There was an exception when opening epub book: E:\Books\Wont Open\He_Who_Fights_With_Monsters_-_Shirtaloon.epub
System.AggregateException: One or more errors occurred. (Object reference not set to an instance of an object.)
 ---> System.NullReferenceException: Object reference not set to an instance of an object.
   at VersOne.Epub.Internal.BookCoverReader.ReadEpub2CoverFromGuide(EpubSchema epubSchema, Dictionary`2 imageContentRefs)
   at VersOne.Epub.Internal.BookCoverReader.ReadEpub2Cover(EpubSchema epubSchema, Dictionary`2 imageContentRefs)
   at VersOne.Epub.Internal.BookCoverReader.ReadBookCover(EpubSchema epubSchema, Dictionary`2 imageContentRefs)
   at VersOne.Epub.Internal.ContentReader.ParseContentMap(EpubBookRef bookRef, ContentReaderOptions contentReaderOptions)
   at VersOne.Epub.EpubReader.<>c__DisplayClass10_0.<OpenBookAsync>b__1()
   at System.Threading.Tasks.Task`1.InnerInvoke()
   at System.Threading.Tasks.Task.<>c.<.cctor>b__272_0(Object obj)
   at System.Threading.ExecutionContext.RunFromThreadPoolDispatchLoop(Thread threadPoolThread, ExecutionContext executionContext, ContextCallback callback, Object state)
--- End of stack trace from previous location ---
   at System.Threading.ExecutionContext.RunFromThreadPoolDispatchLoop(Thread threadPoolThread, ExecutionContext executionContext, ContextCallback callback, Object state)
   at System.Threading.Tasks.Task.ExecuteWithThreadLocal(Task& currentTaskSlot, Thread threadPoolThread)
--- End of stack trace from previous location ---
   at VersOne.Epub.EpubReader.OpenBookAsync(IZipFile zipFile, String filePath, EpubReaderOptions epubReaderOptions)
   --- End of inner exception stack trace ---
   at System.Threading.Tasks.Task.ThrowIfExceptional(Boolean includeTaskCanceledExceptions)
   at System.Threading.Tasks.Task`1.GetResultCore(Boolean waitCompletionNotification)
   at System.Threading.Tasks.Task`1.get_Result()
   at VersOne.Epub.EpubReader.OpenBook(String filePath, EpubReaderOptions epubReaderOptions)

Yeah, I found this issue too: https://github.com/vers-one/EpubReader/issues/57
It is already fixed but the fix hasn't been released yet. Let me publish a preview version to Nuget.

I published v3.3.0-alpha1 to Nuget. Could you check if it fixes the issue?
I marked it as alpha and not the full release because it doesn't have some features I planned for v3.3, but it should be stable enough to use in production.

Wow, extremely fast. I'll take a look and validate and report back to you after work today.

It is working. Thanks for the fast support. I still have some time before my next release, so hopefully can roll with your v3.3 release.
Before I close, can I quickly ask if you have an OpenCollective or a way for me to donate? I'm donating back to libraries I've used to make my software and my software wouldn't be possible without this library.

Thank you for reporting this issue and validating the fix. I plan to release v3.3 in about two weeks.
Yeah, I've seen your project. It looks very impressive!
I considered setting up donations in the past but since my employer pays me well, it never felt like it's worth the effort in my case. Just the fact that this library is useful for someone means much more to me.

Okay, then looks like I have enough time. Well, thank you again for the library and especially now that you're back and improving it. My users have been extremely happy with the recent changes you've been making.


fix(linter): disable react/rules-of-hooks for vue and svelte files

because of https://github.com/oxc-project/oxc/issues/8003
I used the FrameworkFlags in hope they are only active in .vue and .svelte files.
Not Tested!

this is exactly what I wanted to avoid. I can patch it and check for the file extension instead

just a heads up, you can't rely on the extension being .tsx as some people have hooks in just ts files


Add IE8 support

This PR adds an optional polyfill that users can include to add support for IE8, and makes a couple of small patches to the style handling code to be IE8 compatible.
The examples have also been modified to work properly on IE8.

This should not be part of this library, just part of your individual setups.

The library requires code changes to become compatible.
On Tue, 5 Jun 2018, 8:38 AM Daniel Ruf<EMAIL_ADDRESS>wrote:

This should not be part of this library, just part of your individual
setups.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/insites/cookieconsent/pull/345#issuecomment-394491266,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AB1Rg46zv3xc5vxksaOJXHQjMPIpF47iks5t5ZrYgaJpZM4UJ4e6
.

The library requires code changes to become compatible.

Not really. You can always use Babel with its plugins and autoprefixer.
Also IE8 is not officially supported anymore and not used (in the enterprise field).
Still, this is a very specific use case for you but not most others and just bloats the entire library without adding much benefit.

I agree with @DanielRuf, plus I don't really think we should be polluting the prototypes. Rather the plugin should just implement it's own util functions.


MSVC __TBB_CPP17_DEDUCTION_GUIDES_PRESENT is wrong

__TBB_CPP17_DEDUCTION_GUIDES_PRESENT is incorrectly defined for MSVC usage.
in tbb_config.h it's defined as
‘‘#define __TBB_CPP17_DEDUCTION_GUIDES_PRESENT            (_MSVC_LANG >= 201703L)’
instead of
‘#define __TBB_CPP17_DEDUCTION_GUIDES_PRESENT            (_MSVC_LANG >= 201703L && _MSC_VER >= 1914)’
See https://docs.microsoft.com/en-us/cpp/visual-cpp-language-conformance?view=vs-2017 for language conformance and https://en.wikipedia.org/wiki/Microsoft_Visual_C%2B%2B for MSVC macro version-values linked with VS 2017 updates.

Fixed in TBB 2019 Update 4.


[Wrong link in Blockchain Roadmap] <The link "SOLIDITY DOCS" in the Blockchain roadmap is not linked to the Solidity documentation. Instead, it is linked to a video (Rick Astley - Never Gonna Give You Up (Official Music Video)).>

Description
The link "SOLIDITY DOCS" in the Blockchain roadmap is not linked to the Solidity documentation. Instead, it is linked to a video (Rick Astley - Never Gonna Give You Up (Official Music Video)).
Screenshots
Please find the attached screenshot below!

Additional information
Solution:
Change the corresponding URL to "https://docs.soliditylang.org/en/v0.8.16/"

Dude prefer to use brief title for the issue, like "Wrong link in Blockchain Roadmap"

Sure, will change it. Thanks!


[MM-19327] Add keyboard shortcut to focus search bar and search in current channel

Summary
Added a keyboard shortcut (Ctrl/Cmd+Shift+F on browser, Ctrl/Cmd+F on desktop) to focus the top search bar, and set the search term to in:{currentChannelName} as a shortcut for the user to quickly search the channel they're working in.
Ticket Link
https://mattermost.atlassian.net/browse/MM-19327

@devinbinnie what happens on a new server, old desktop app (where we haven't removed the browser search functionality)? Does the browser search override this in channel search, or will there be conflicts?

@devinbinnie what happens on a new server, old desktop app (where we haven't removed the browser search functionality)? Does the desktop find search override this in channel search, or will there be conflicts?

@esethna There will be conflicts. Unfortunately since the old desktop app assumes it's the only application accepting Ctrl+F, we won't be able to override that. We could see if there's a way to have the webapp detect the desktop app version and turn off the new behaviour so that there's no conflict.

We could see if there's a way to have the webapp detect the desktop app version and turn off the new behaviour so that there's no conflict.

+1, I think it's worth investigating since this will be a common case (new server, old desktop app)

cc// @jgilliam17 on this test case: https://github.com/mattermost/mattermost-webapp/pull/7718#issuecomment-801447514

@devinbinnie
On macOS Catalina Desktop app Mattermost v4.7.0-develop commit: b5c59fa
cmd+f opens both find search box on the tab bar (focused) and adds in:ChannelName to search bar (not focused)

cmd+shift+f also works on desktop app, opens search bar and pre-fills with in:

@devinbinnie
On macOS Catalina Desktop app Mattermost v4.7.0-develop commit: b5c59fa
cmd+f opens both find search box on the tab bar (focused) and adds in:ChannelName to search bar (not focused)

cmd+shift+f also works on desktop app, opens search bar and pre-fills with in:

@jgilliam17 You'll need the latest version of the desktop app, the changes were only merged yesterday. For release, the app checks for version v4.7, so as long as you're using v4.6 or earlier the new behaviour shouldn't happen at all.
As for Ctrl+Shift+F, I don't think there's anything wrong with having that enabled, as it allows people using v4.6 to use the new behaviour should they care to.

Thanks @devinbinnie I'll re-test tomorrow, new mac build wasn't available today.
(Oh, I was just adding cmd+shift+f note as a bonus 😄 )

Thanks @devinbinnie
Retested and seeing few issues.

On browsers and desktop app on all OSes:
When only search icon is present (no text input box) in lower browsers widths cmd/ctrl+shift+f and cmd/ctrl+f in desktop fail to focus the search bar. Also shortcuts are not working on mobile view, not sure if we are considering implementing mobile view at this time or not.

On Windows and Ubuntu (browsers only) ctrl+shift+f is not focusing the search bar; ctrl+f on desktop works as expected (as long as search bar is present due to issue 1.)

@calebroseland @michelengelen @nevyangelova Needed to refactor some stuff to fix the issues Jelena rose, so would like to have dev re-review.
@jgilliam17 Issues should be fixed.

@devinbinnie here's what I observed when going back and testing on previous desktop app releases
On 4.6.2 desktop app (macOS):

7718 server

cmd+f opens find textbox on tab header
cmd+shift+f focuses search, inputs in: text (it does not work if find textbox is open on header)

daily (master)

cmd+f opens find textbook on tab header, old functionality - as expected
cmd+shift+f  nothing happens
I'm having some issues with Windows, restarting and will re-test later on both win10 and ubuntu.

/update-branch

@devinbinnie here's what I observed when going back and testing on previous desktop app releases
On 4.6.2 desktop app (macOS):

7718 server

cmd+f opens find textbox on tab header
cmd+shift+f focuses search, inputs in: text (it does not work if find textbox is open on header)

daily (master)

cmd+f opens find textbook on tab header, old functionality - as expected
cmd+shift+f  nothing happens
I'm having some issues with Windows, restarting and will re-test later on both win10 and ubuntu.

@jgilliam17 Are you able to re-test?

@devinbinnie I was able to re-test

Windowsnew server(7718)/ old app (4.6.2 and later)
ctrl+f - opens Find text box in header
shift+ctrl+f - opens search,  inputs in: text

@devinbinnie I was able to re-test (edited, submitted too soon)

Windows 10 and Ubuntu 20.04.2

new server(7718)/new app (4.7beta2)
shift+ctrl+f and ctrl+f - opens search, inputs in: text as expected - passed
old server/new app (4.7beta2)
ctrl+f - nothing happens, including using menu option view>find - failed

@jgilliam17 This is expected, because we had to completely remove the Find function from all versions of v4.7 due to the issues we experienced with it on Windows/Linux. But since old servers won't have the code to trigger the in-app find functionality nothing would happen.
@esethna Are we okay with this?

shift+ctrl+f - nothing happens, as expected
new server(7718)/ old app (4.6.2 and earlier)
ctrl+f - opens Find text box in the header
shift+ctrl+f - opens search, inputs in: text - I believe we said this is ok, a bonus, to allow people on earlier versions of the app to still use this functionality
old server/old app (4.6.2 and earlier)
ctrl+f - opens Find text box in the header, as expected
shift+ctrl+f - nothing happens, as expected

This is expected, because we had to completely remove the Find function from all versions of v4.7 due to the issues we experienced with it on Windows/Linux. But since old servers won't have the code to trigger the in-app find functionality nothing would happen. @esethna Are we okay with this?

Yes this would be expected

@hmhealey @calebroseland @michelengelen Implemented some changes, have a look guys.

/update-branch

Gentle ping @jgilliam17 for re-review

Thanks @devinbinnie
Looks good on re-test.
One small issue on Firefox, the keyboard shortcut is shared; it opens search, inputs in: text as expected, but also simultaneously triggers Enter/Exit Full Screen

Thanks @devinbinnie
Looks good on re-test.
One small issue on Firefox, the keyboard shortcut is shared; it opens search, inputs in: text as expected, but also simultaneously triggers Enter/Exit Full Screen

@jgilliam17 Should be fixed now