Feature/charter africa partners cms

Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # 285
Type of change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Screenshots
Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation

@kilemensi

@kilemensi

Ola @koechkevin .
Just had a quick look and yes, this is def. going in the right direction. Will do a full review later.


How about support OS X?

Sounds like a great idea! Shouldn't be too much work, though I think it would be best to make FLAnimatedImage optional first. Happy to accept any pull requests adding support for OS X.

It's done, can be closed


NFDIV-3118: Add common header and footer and update template versions

Change description
Enter a description.
JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/NFDIV-3118
Before merging a pull request make sure that:

[X] tests have been updated / new tests has been added (if needed)
[ ] README and other documentation has been updated / added (if needed)

If this ticket will have any visible impact on users and is not behind a feature toggle, make sure that:

[ ] this ticket been reviewed by QA
[ ] the user story been signed off by the PO

Note that bug fixes, dependency updates and technical tasks do not directly impact the user experience and can be merged without QA and PO review.
If this user story cannot be immediately merged find a way to put it behind a feature toggle and get it merged.

This is now covered by PR #2684


new location option to setup router

A common use case is to test an app that requires a predefined router for different paths. To make the setup more convenient, this comes with a new location option that makes render setup a router and navigate to the location.

This does not work for me.
  it('can render a route with the id', async () => {
    const { findByText } = render(() => <App />, { location: '/ids/1234' })
    expect(await findByText('Id: 1234')).not.toBeFalsy()
  })

Gives:
 FAIL  src/test/pages/Drone-view.test.tsx > location option > can render a route with the id
TestingLibraryElementError: Unable to find an element with the text: Id: 1234. This could be because the text is broken up by multiple elements. In this case, you can provide a function for your text matcher to make your matcher more flexible.

Related: https://github.com/solidjs/solid-testing-library/issues/60#issuecomment-2054228917


Create Vignette for using base plot tester

let's create a vignette for base plot tester.
Following earthpy for an example of creating a vignette.
https://github.com/earthlab/earthpy/blob/master/examples/plot_bands_functionality.py
it will become an example in the gallery like this: https://earthpy.readthedocs.io/en/latest/gallery_vignettes/index.html
In this vignette:

create a basic scatter plot
create a plot tester object for it.
test that:

the title contains a word,
that there is an x and y axis label
that the plot is of type scatter plot
test that the data are correct in the plot

i believe i'll have to setup the gallery functionality in matplotcheck like it's setup in earthpy
https://github.com/earthlab/matplotcheck/blob/master/docs/conf.py#L43
https://github.com/earthlab/earthpy/blob/master/docs/conf.py#L48
for this to work properly and build locally.

@lwasser needs to get a good assignment from @jlpalomino  !! jenny do you have a homework assignment that we can use as a use case for matplotcheck?! i'll ping you on slack as well.


test_cli.py uses removed md5 module

Describe the bug
The file test_cli.py uses the module md5, which has been removed from Python 3.
To Reproduce
Run the test suite with pytest.
Expected behavior
Tests pass.
Additional context
The fix is simple:

replace import md5 with from hashlib import md5
replace md5.new with md5
replace digest with hexdigest

Thanks-- fortunately only in the test code rather than the main package. I've updated this script in the latest commit.


Latest Version crashes Steve Carts when being searched in JEI

Minecraft version & Mod Version:
1.12.2-1.15.9
Single player or Server:
Both (Client-sided Only)
Describe problem (what you were doing / what happened):
Okay, this is an interesting crash, whenever I have steve carts (doesn't matter which version) and jei (just enough items, also doesn't matter what version is installed) installed alongside with this I end up having a looping crash involving a rendering item which talks about steve cart's modules when searching it in JEI's search bar.
Now, what does this cyclic have to do with this? Well, with the latest version installed that I've provided in this issue post. Whenever this version is installed, apparently typing @ste (or anything that brings up steve cart's items) in the jei search bar crashes me resulting in saving and quitting then booting me out.
However, If I try to enter that world again, it'll just give me the same crash again (looping crash). Until I clear the jei world settings, so I can access that world again.
If I try to use an older version, the game behaves normally and won't crash. It's just this very version.
Issue report on Steve Cart's side: https://github.com/TechReborn/StevesCarts/issues/151
Crash log (if any):
https://pastebin.com/JUzBPSnk

Was an issue on the SC end, you can close this.


Bug: Preview pane dimensions reset after changing the orientation

Description
When I split my screen among two apps, the Files window gets automatically resized to accomodate the spacing that I need. However the preview sidebar does not maintain the previous setting (in terms of dimension) once i go out of the side-by-side app view, and it just goes back to the initial/default dimension, which is too small for me. The thing is that when the files app is in side-by-side mode, the sidebar gets placed below the elements, great design choice, and if I resize it it maintains its dimension even if I go in and out of side-by-side mode, but the contrary is not true, so the dimension preview sidebar when I have my app is not preserved when I move in and out of the side-by-side mode.
Steps To Reproduce

Open the files app
Open the preview sidebar
move the files app to the right (or left) part of the screen until it gets attached to the side (alternatively use the keyboard shortcut: start + left/right arrow key)
go out of side-by-side app view

Requirements

eg. Fix preview sidebar bug that occurs when you go in and out of side-by-side app viewing

Files Version
<IP_ADDRESS>
Windows Version
10.0.19045.2913
Log file
debug.log

@enricodarodda can you attach a screen recording of this issue?

Unfortunately the file becomes quite big, can I be clearer somehow?

I see, it looks like it changes to the minimum size.

Yeah, exactly

This appears to be fixed in the latest dev build. The changes will be included in the upcoming v2.5 release.


Cost of revenue value is not correct

I'm taking this ticker as an example.
For 2020-30-12, we have Cost of Revenue = 79,020,000
When I do this :
>>> import yfinance as yf
>>> stock = yf.Ticker("VOC.MC")
>>> stock.financials

I get Cost of Revenue = 178,061,000.
Gross Profit is also incorrect.
Thank you

Is this a possible dupe with #700


docs: add a description for the package

Without this, npm tries to guess a description, which ends up being <div align="center"> as that is the first line in the readme.

Thanks


Fix Installer singleton support. Don't try to copy obsolete .pri files to the TRansport package

/azp run


CFDE - Customized count request

Currently, chaise is using the Reference.getAggregates API to fetch the total count displayed in the recordset pages. This API will internally use the ermrest's aggregate API to fetch the cnt_d of the shortestkey.
While this works in most cases, in a table with millions of rows and complicated facet structure, the generated request might result in a timeout. That's why previously we decided to disable the count in CFDE tables.
We should investigate if there's a special treatment that we can do for CFDE to switch to use a more performant and customized Query for this request.
@karlcz Can you please add more details?

I'm going to close this issue in favor of #959. This specific feature is not needed anymore.


Monorepo support

We have a monorepo that uses Yarn workspaces and Lerna.

The core package is a Lightning application which depends on the account package.
Both core and account depend on @lightningjs/sdk.

When I try to run lng build inside core it throws an error because it can't find @lightningjs/sdk. This is because part of the build steps in Lightning CLI assumes node_modules will be in the same directory as the application. While most of the time this will be true for standalone apps, monorepo dependencies from all the packages are hoisted into a node_modules directory in the root of the project to prevent duplicates.
A work around for this is to flag the core package with no-hoist to prevent its dependencies from being hoisted into the root. This allows lng build to be successful but then introduces a different issue where multiple versions of Lightning SDK are being used - one for core and another for the packages with hoisting enabled. When using the application in the browser, various error messages appear in the console.
Would it be possible for Lightning to support monorepos?

Thanks for the patience on this topic. We've released v2.8.0 of the CLI last week, that has support for mono-repos.

Thanks Michiel


Bottom toolbar expands past screen display. (ArcGIS Pro)

Populating the list of coordinates will eventually expand the display so the buttons on the bottom are no longer visible.

same thing happens in ArcMap #345

@kgonzago Not a deal breaker, just not thrilled the add-in isn't using up all the real estate it has.

@ACueva The approach taken is the simplest but the drawback is what you experienced. Having it fill the entire dock window will require more time. I suggest we log it as a version after next issue.

@kgonzago @nfeuerstein can we discuss this a bit before we decide for certain that it is an enhancement for version after next

(moving back to backlog just for tracking purposes, will discuss in war room)

As seen in @ACueva  comment, the original issue has been fixed.  In regards to @ACueva comment about extening the list dialog, that has been placed in the enhancement request below.
https://github.com/Esri/coordinate-conversion-addin-dotnet/issues/425
Closing issue.


Reevaluate "always defer chunk updates"

What config to change
Sodium setting "always defer chunk updates" should be disabled again. It could provide better FPS in some cases, but at the same time has some side effects that make it seem like server lag.
Why should it be changed
Sxc

I think I've has that issue before but with doors so when I open them they don't do the animation of opening them. It does the animation after some time

TacoMonkey

I always turn it off because it makes everything delayed

Julienraptor01

I personnally noticed that it has tendancy of delaying  animations
And it can have some effects similar to server lag
Which is more annoying than having less fps and/or lag spikes

Category
Mod config option
Additional details
No response

The only thing i find good in this option is that it completly remove the stuttering i have with Lambdynamiclights when enabled

The only thing i find good in this option is that it completly remove the stuttering i have with Lambdynamiclights when enabled

Considering that I'd want to keep it enabled, it seems like a good thing then 😄

This issue happens when you're laggy or when chunk loading is happening, set the chunk from 8 to 16 and when the chunk is loading open up some doors and the doors will be delayed

In the beginning I was against this idea but after some testing I found out that sometimes when swapping servers in-game eg. Minehut servers there's a render bug that you can't see anything. This can be stressful for the users and I think that ACDU should be disabled since it can be reopened by the user again

Disabled in 3.6.0.


Reduce dependency tree

atspi, in its current state, has a dependency tree in at 113 as reported by cargo tree | grep -ve '*' | wc -l. This grep is to remove lines containing existing dependencies in the tree. Basically, it ignores duplicates.
I know it's arbitrary, but I think we should try to get that down to 50 or so, maybe less. Let's find the largest libraries which we are using the least of and scrap them in favor of something simple and home-grown.

I think the following counts more accurately:
cargo tree --prefix none -e normal | grep -ve '*' | wc -l

It is currently at 141. I bet zbus brings most of the dependencies though. It's probably the one I'd be less in favor of replacing.

Partially adressed by #82


What is it? Why xbar connect to bihell.com on startup?

I am getting this alert on MacOs from Little Snitch Firewall. I just started and with no script/plugin loaded.
I can't get any reference to this website on the source code.
Any idea?

I received this same prompt from Little Snitch. When I run the bihell.com domain through Whois History, it shows that since ~2017, the domain has been registered by someone in Shanghai, China.
The 2017 WHOIS registration shows the registrant as Haseo with the email<EMAIL_ADDRESS>All subsequent registrations have all info scrubbed, excluded the location still being Shanghai.
If I do a github search for that gmail address, it pulls up: https://github.com/bihell and that looks like the person who owns that domain.
I'll leave it up to @matryer to investigate and reach out to that person, if needed.

Same here. Not cool. Seems to be some kind of big data collection platform: https://bigdata.bihell.com

I also came here to report this

Can we pinpoint a specific date when this started. There hasn't been a build for quite some time.

I'm not seeing that behavior at all. Might be helpful if people post the version they have, how they installed it, any plugins they are using, and how they installed the plugins. I'm on v2.1.7-beta and only have two plugins running -- my own and MergeFreeze.

@matryer @leaanthony
I think I might know what is going on here. I wonder if Little Snitch is reporting the connection from the xbarapp.com website itself. Currently, there is a plugin being featured on the front page that is reaching out to bihell.com for its app thumbnail image:

The plugin also shows up in the initial opening view of the plugin browser:

The plugin in question seems to have been around for awhile. Might be it just started getting featured in the app recently, or people are opening the plugin browser for the first time. Seems fairly benign unless the image itself is meant to be a stealth tracker of xbar usage. 🤷🏽
Hope that helps.

The plugin in question seems to have been around for awhile. Might be it just started getting featured in the app recently, or people are opening the plugin browser for the first time. Seems fairly benign unless the image itself is meant to be a stealth tracker of xbar usage. 🤷🏽

It seems fairly naive to assume that a plugin from China, linked to a Chinese data collection service is benign.
It seems much safer to assume that such "features" are malign unless explicitly advertised, which is not the case here.

It seems fairly naive to assume that a plugin from China, linked to a Chinese data collection service is benign. It seems much safer to assume that such "features" are malign unless explicitly advertised, which is not the case here.

I gave the plugin code a read before my initial post. The plugin itself appears to be trying to get a list of videos from a particular user on bilibili.com, a Shangai YouTube-esque site. The only link it has to bihell.com is the image https://bihell.com/media/2020/02/bilibili-bitbar.jpg used for the plugin thumbnail. It doesn't even connect to a live asset any longer. Would wager the author used that site as an image host.
Unless you have the plugin installed, the most happening is a request to fetch an image and having that network connection time out. Happy to concede I may be unware of sophisticated attacks that somehow could leverage this communication. 🤷🏽

I gave the plugin code a read before my initial post. The plugin itself appears to be trying to get a list of videos from a particular user on bilibili.com, a Shangai YouTube-esque site. The only link it has to bihell.com is the image https://bihell.com/media/2020/02/bilibili-bitbar.jpg used for the plugin thumbnail. It doesn't even connect to a live asset any longer. Would wager the author used that site as an image host.
Unless you have the plugin installed, the most happening is a request to fetch an image and having that network connection time out. Happy to concede I may be unware of sophisticated attacks that somehow could leverage this communication. 🤷🏽

An attack seems unlikely but this definitely allows them to track any user of xbar which has this plugin installed. That's the whole point of linking to a data collection service.
That may be fine if properly advertised, after all, everyone can choose for themselves, but unless one has Little Snitch installed they would not know that, which is not exactly proper.
And in any case, giving a Chinese entity information that our IP correspond to an xbar using Mac does not seem like a good idea by default.

An attack seems unlikely but this definitely allows them to track any user of xbar which has this plugin installed.

I pointed that out in my initial post. "unless the image itself is meant to be a stealth tracker of xbar usage. 🤷🏽"
At this point, if you are concerned, don't open the plugin finder, visit the homepage of xbarapp.com, or the Web category page. You'll never get a request made for the image. Open a PR for the plugin removing the reference. Put on your peril sensitive sunglasses, grab your towel, and don't panic.

I pointed that out in my initial post. "unless the image itself is meant to be a stealth tracker of xbar usage. 🤷🏽"

Yet you ignore my concern that this tracker is not publicized to users.

At this point, if you are concerned, don't open the plugin finder, visit the homepage of xbarapp.com, or the Web category page. You'll never get a request made for the image. Open a PR for the plugin removing the reference. Put on your peril sensitive sunglasses, grab your towel, and don't panic.

Can we abstain of sarcasm and keep the topic on point of the issue?
If you do not mind the tracking, then you can simply leave the conversation to people who do.

Yet you ignore my concern that this tracker is not publicized to users.

I think where we differ is the opinion that it is a tracker. I feel based on the overall plugin it was simply someone hosting an image somewhere. Maybe the site is connected to a data tracking platform. That doesn't necessarily mean the plugin author is malicious or is attempting to track us. Your mileage clearly varies.

Can we abstain of sarcasm and keep the topic on point of the issue? If you do not mind the tracking, then you can simply leave the conversation to people who do.

No sarcasm intended; apparently my attempt at humor at the end to lighten things up fell flat.  The only way I've managed to get that image to appear in my network traffic is by:

Opening the xbar plugin browser. The first view of this brings up a similar view to the xbarapp.com homepage, a view that features the plugin details in turn making a network request for the image.
Opening the xbarapp.com homepage. See above.
Opening the Web plugin page on xbarapp.com where the plugin is also listed.

Finally, I mentioned the solution to not even have this "tracker" present is to open a PR and remove the image line from the plugin. No one will ever see it again. Was going for a bit of levity in the presentation. Apologies for not landing the joke.

The request to bihell.com was made on my device without opening any of Xbar's UI elements. It occurred when Xbar launched at device startup. The plugin browser was not open.

The request to bihell.com was made on my device without opening any of Xbar's UI elements. It occurred when Xbar launched at device startup. The plugin browser was not open.

Interesting. I haven't been able to reproduce that behavior. What version are you on? By "device startup", do you mean literally after booting up your machine? I've been closing / reopening the xbar app. Maybe on bootup, there is a code path that pre-fetches the plugin browser data.

At this point, best I can say is someone can get a PR against the file (in the xbar-plugins repo) and poke @matryer, et. al. to merge it. I don't know if there would be anything in the site or plugin code that would need to change. If the pages / dialogs are hard-coded / cached with the view of that plugin, may need something there.

What's the real solution here though? Mirror all the plugin images?
Kudos for tracking down the culprit 🙏

That's a great idea. Base64 encoded PNG should suffice. That's still a lot of work but worth considering

Hello @leaanthony,
I'm very new here and while checking the issues list before installing I found this thread and wanted to offer up a sledgehammer solution of sorts to this ET phone home style issue that @xenio raised.
This project looks cool and I hope to dive into it more over the coming weeks.

It's a thumbnail for the plugin. @matryer and I are looking to self host the images once we can sync 👍


fix: Added collection id and clientSideExecution to layout on page load DTO

Fixes #9621

/ok-to-test sha=4433010


Clean up naming scheme

Great suggestion from @mbobra.
Notebooks could be better named with a convention such as
YYYY-MM-DD_MeetingName_MeetingLocation_NotebookTopic.ipynb
and for the folders
YYYY_MeetingName_MeetingLocation.
Also should move 2016SPD-Python-SunPy into 2016_spd and the same for 2017, so there is one consistent place to look for tutorial notebooks.

@ehsteve submitted a pr


Add sessions.start_autosave to API

Closes #5
This turned out more complex than I expected 😄

added path param to write_session_file so that functions can optionally pick other value than current session_file_path
similarly added an optional path param to the new start_autosave_internal(), which now should be used to set the session_file_path for simpler logic
fixed a bug that caused get_session_path(path, false) to work as get_session_path(path, true) because of incorrect logic for the default ensure value

Looks good! Thanks for the cleanups and fixes!


If I click "PROJECT FILES", automatically open "Included Files"

I shouldn't have to click twice to see what's included.

Thanks for the feedback. This should change quite a bit in the next release (1.1.6) coming in a day or two.
We addressed some early feedback in issue #1210 (with PR #2097 and #2168) and made Project Files a hierarchical tree that is automatically expanded. It shows base files and directories with checkboxes indicating if they are included in the deployment or not.
That reduces the clicks down to zero, and makes it more prominent in the "review prior to deployment" stage.
I'll leave this open and check back in when 1.1.6 is released.

1.1.6 has been released. Check out the new Project Files view, and let us know if it solves this bit of feedback for you. If you have any new feedback on the release we'd love to hear it.

Yes, much better, thank you!


Warning: THREE.WebGLRenderer: Property .outputEncoding has been removed. Use .outputColorSpace instead.

Noticed this warning in the browser console.

same , is it a problem ?

This is due to three r157 color space change. This has been fixed in v2 (coming soon, check pinned issue)


feat(config): friendly ESM file require error

Description
When importing an CJS package from the config, Vite throws the following errors.
X [ERROR] Failed to resolve entry for package "@sveltejs/vite-plugin-svelte". The package may have incorrect main/module/exports specified in its package.json: No known conditions for "." specifier in "@sveltejs/vite-plugin-svelte" package [plugin externalize-deps]

failed to load config from D:\documents\GitHub\vite\playground\alias\vite.config.js
error when starting dev server:
Error [ERR_REQUIRE_ESM]: require() of ES Module<EMAIL_ADDRESS>from D:\documents\GitHub\vite\playground\alias\vite.config.js not supported.
Instead change the require of index.js in D:\documents\GitHub\vite\playground\alias\vite.config.js to a dynamic import() which is available in all CommonJS modules.

These errors seems to be confusing for the users: https://github.com/sapphi-red/vitepress-plugins/issues?q=is%3Aissue+ERR_REQUIRE_ESM+is%3Aclosed, https://github.com/vitejs/vite/issues/13255, https://github.com/Subwaytime/vite-aliases/issues?q=is%3Aissue+is%3Aclosed+"Failed+to+resolve+entry+for+package", https://github.com/sveltejs/vite-plugin-svelte/issues?q=is%3Aissue+"Failed+to+resolve+entry+for+package"
This PR changes the error message to tell what happened and what needs to be done.
X [ERROR] "slash" resolved to an ESM file. ESM file cannot be loaded by `require`. See http://vitejs.dev/guide/troubleshooting.html#this-package-is-esm-only for more details. [plugin externalize-deps]

X [ERROR] Failed to resolve "@sveltejs/vite-plugin-svelte". This package is ESM only but it was tried to load by `require`. See http://vitejs.dev/guide/troubleshooting.html#this-package-is-esm-only for more details. [plugin externalize-deps]

I hope this would unblock plugins to migrate to ESM only.
Additional context

What is the purpose of this pull request?

[ ] Bug fix
[x] New Feature
[ ] Documentation update
[ ] Other

Before submitting the PR, please make sure you do the following

[x] Read the Contributing Guidelines.
[x] Read the Pull Request Guidelines and follow the PR Title Convention.
[x] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
[x] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
[ ] Ideally, include relevant tests that fail without this PR but pass with it.

Looks great! Just some naming nitpicks. Cheers for an ESM only future 🙏🏼


Move imports in wake_on_lan component

Description:
Moved imports from functions to top-level as requested in #27284
Checklist:

[ ] The code change is tested and works locally.
[x] Local tests pass with tox. Your PR cannot be merged unless tests pass
[x] There is no commented out code in this PR.
[x] I have followed the development checklist

Duplicate of #27415

@fabaff, thanks for returning. But I know that this pull is duplicated, I did it to correct the tests, since @inverse didn't give any answer already 12 days ago

c'mon

Hi @inverse, I believe there is no time policy, I commented there because it is the information that is appearing to me here on Git. As you did not respond, I decided to make the changes so that the issue could be closed as soon as possible, we are an Open Source community, we are here to help, sorry if I offended you in any way, it was not my intention.

@djpremier I think there should be some policies around "trumping" PR's etc since that could demotivate people from contributing which would have an much more negative effect on an Open Source community than closing issues "as soon as possible".

@inverse We don't have a policy for that, nor do I personally think that is needed.
I'm sorry to hear that this has happened, however, this PR did pass the CI, the other didn't. It makes sense to merge the passing contribution. Closing it by saying: "Nope, great PR, but there is a dupe that needs to be fixed first" is awkward as well.
In the end, what matters is that we move forward, so everybody can enjoy this creat piece of software. This is not a competition. We value every contributor and contribution. Merged or not merged doesn't matter.
So let me close by saying; Thanks @inverse, please don't be sad and I would definitely hope to see a contribution from you sometime again. ❤


ValueError: Must provide API key or enterprise credentials when creating client.

I'm wondering where I can get an API key and once I get it, how to configure the bot to use it?

https://developers.google.com/maps/documentation/javascript/get-api-key
you can put in config.json as "gmapkey" or pass in cli with --gmapkey [KEY]


feat: enhanced lookup behaviour

Description
Am opening up this PR for discussion as it has some useful features. Much of the work was done to support several UK stores and ended up duplicating #141 which wasn't merged at the time. I've since rebased and tried to make all changes fully backwards compatible with the structure prior to #141 and with the current HEAD.

Fixes runtime errors caused by incorrect devDependencies when running with npm install --only=production
Uses ts-node to speed up dev workflow a little, also allows end user running without build/ folder
Adds some missing card brands that are available at some stores (in the UK at least)
Adds the ability to disable the puppeteer adblocker extension on a per-store basis - this was required for scan.co.uk where every request after the first one would fail otherwise
Enhances lookup behaviour:

Status codes >= 400 fail immediately
403 (Forbidden) responses are retried with exponential backoff to allow IP rate limits to reset
Empty responses are sent to the debug log
Restores outOfStock and bannedSeller behaviours (see below)
Requires all checks to pass before declaring a card in stock, i.e. if any of inStock, outOfStock, bannedSeller or captcha are defined, they must pass
Adds support for multiple Element lookups, i.e. multiple container, text definitions
Restores support for "legacy" array of string checks (can be removed - work was started on this before the changes were merged which changed to the Element style)
Adds the ability to determine a stores links at runtime, see eBuyer and Scan examples here https://github.com/andrewmackrodt/nvidia-snatcher/compare/pr-enhancements...develop - note: the current implementation only works for the first page of results, this is fine for the stores given as an example

Testing
Tested with the following .env file:
OPEN_BROWSER="false"
SCREENSHOT="false"
SHOW_ONLY_SERIES="test:series,3080"
STORES="adorama,amazon,amazon-ca,asus,bandh,bestbuy,bestbuy-ca,evga,evga-eu,microcenter,newegg,newegg-ca,officedepot,zotac"

To test the behaviour of runtime detected store links please try the develop branch of my fork https://github.com/andrewmackrodt/nvidia-snatcher
New dependencies

package
description

cheerio
DOM parser with js/css like selectors, used by dynamic link feature

nodemon
(dev) monitors the project for changes and automatically restarts it

ts-node
(dev) compiles typescript on-the-fly

Changed dependencies

package
description

@slack/web-api
moved from devDependencies to dependencies

discord-webhook-node
moved from devDependencies to dependencies

play-sound
moved from devDependencies to dependencies

This is really good. I'll have to look at it in the AM so I can have a closer look. Thanks for contributing!!!

Thanks for the review @jef. I'm thinking of breaking out the "Adds the ability to determine a stores links at runtime" feature to another PR as I've modified beyond the scope of what's discussed in here, primarily it can run multiple times during tryLookupAndLoop https://github.com/andrewmackrodt/nvidia-snatcher/blob/develop/src/store/lookup.ts#L172. The reason for doing so was for yesterdays 3090 stock availability check before the digital-river-product-id was known, and I'm happy to say it worked; as is the feature generally which successfully found 3090 stock at currys and box today.

start:dev is find with me, start:nodemon is a little long, is it pronounced node-mon or no-demon, I never know :sweat_smile:.

@serg06, #383 just got merged. I think you'll want to do that now.


Pull repositories from FusionForge

Have you got a URL?

https://adullact.net

There is also a GitLab instance: https://gitlab.adullact.net. Are they going to migrate over there?

I don't know.
I'm copying Matthieu on this (cc @mfaure), working for Adullact, he may have more information for us.

Documentation: https://scm.fusionforge.org/anonscm/gitweb?p=fusionforge/fusionforge.git;a=tree;f=src/plugins/repositoryapi/Documentation;hb=refs/heads/feature/plugin-repositoryapi-6.0

To sum up:

not all FusionForge instances use the repositoryapi API;
this plugin, when available, does not allow to collect the same metadata than the ones we currently collect from GitHub, gitlab.com and GitLab instances;
we suggest users of FusionForge tackle this problem together by enhancing this plugin and/or developing a REST API for FusionForge instances.

Possible users are Adullact, INRIA, RENATER and maybe others.

We shall consider dismissing this FR.

I'm now closing this issue: some agencies are still using a FusionForge instance but they are slowly migrating to GitLab forges, so there is no need to invest time on this.


Re-population not working properly on smaller screens

Describe the bug
On larger screen sizes when hitting the Repopulate Form button located on the side bar, the "Select items to be re-populated" dialog appears if there are items to be re-populated.
However on smaller screen sizes where the Repopulate Form button is located in the hover menu (bottom right), it always show the "Form is up to date" dialog.
After some debugging, it seems like the error is caused by the automatic closing and re-opening of the hover menu. At the moment, the itemsToRepopulate state is located on the button itself. That means when the hover menu closes, the itemsToRepopulate state is destroyed, which then always results in an empty itemsToRepopulate state when it re-opens - which is why we always get "Form is up to date".
Potential solutions
There is a need to re-factor how theitemsToRepopulate state is stored, we could leverage a global state management store instead of keeping the state local to the re-pop button.
Expected behavior
In both cases, the correct rpopulation-related dialogs should be displayed consistently.

Resolved by #895


Fixed wrong autocompletion. fixes #1664

The changes to HandleDeclarationCompletion are unrelated, aren't they? I hope I will have the time to look into this today.

No, they are not related to HandleDeclarationCompletion


[Event Request] Codeunit 90 Purch.-Post - procedure PostItemChargePerRcpt - OnAfterPostItemChargePerRcpt

Please add the following existing Event OnAfterPostItemChargePerRcpt to procedure PostItemChargePerRcpt in Codeunit 90 Purch.-Post
[Event Request] Codeunit 90 Purch.-Post - procedure PostItemChargePerRcpt
var
    PurchRcptLine: Record "Purch. Rcpt. Line";
    TempItemLedgEntry: Record "Item Ledger Entry" temporary;
    Sign: Decimal;
    DistributeCharge: Boolean;
    IsHandled: Boolean;
begin
    IsHandled := false;
    OnBeforePostItemChargePerRcpt(PurchHeader, PurchLine, TempItemChargeAssgntPurch, IsHandled);
    if IsHandled then
        exit;

    if not PurchRcptLine.Get(
         TempItemChargeAssgntPurch."Applies-to Doc. No.", TempItemChargeAssgntPurch."Applies-to Doc. Line No.")
    then
        Error(ReceiptLinesDeletedErr);
    ...
    if DistributeCharge then
        PostDistributeItemCharge(
          PurchHeader, PurchLine, TempItemLedgEntry, PurchRcptLine."Quantity (Base)",
          TempItemChargeAssgntPurch."Qty. to Assign", TempItemChargeAssgntPurch."Amount to Assign",
          Sign, PurchRcptLine."Indirect Cost %")
    else
        PostItemCharge(PurchHeader, PurchLine,
          PurchRcptLine."Item Rcpt. Entry No.", PurchRcptLine."Quantity (Base)",
          TempItemChargeAssgntPurch."Amount to Assign" * Sign,
          TempItemChargeAssgntPurch."Qty. to Assign",
          PurchRcptLine."Indirect Cost %");

    OnAfterPostItemChargePerRcpt(PurchLine); // <-- NEW EVENT

end;

[IntegrationEvent(false,false)]
local procedure OnAfterPostItemChargePerRcpt(var PurchaseLine: Record "Purchase Line")
begin
end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 51150.


Dynamic Zuul url using spring cloud netflix

Dear All,
I have a Zuul url which is working fine as of now, how ever based on a query parameter from the front end i need to change the url, could you please suggest how can i acheive that??
For example zuul.routes.myapplication.url=http://myserver:myport/myapplication/{queryparameterfromfrontend}/forms

You'd have to write a custom filter.

I am trying to write the  same. Thank you.
Narendra...!
On 1 December 2016 at 19:25, Spencer Gibb<EMAIL_ADDRESS>wrote:

You'd have to write a custom filter.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/spring-cloud/spring-cloud-netflix/issues/1513#issuecomment-264337987,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AViSFkzhh2_oJvuu8-iaRKIelriXg-RYks5rD2V3gaJpZM4K_uZp
.

@reddynr please reopen if you need additional help


openvdb: 5.1.0 -> 5.2.0

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/openvdb/versions.
meta.description for openvdb is: '"An open framework for voxel"'.
Release on GitHub
Compare changes on GitHub

Checks done (click to expand)

built on NixOS

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 5.2.0 with grep in /nix/store/2g6sz8w7psqdd02q2bajrf56ncf1g2rr-openvdb-5.2.0

directory tree listing: https://gist.github.com/8dbfd4fc7741a951c46a48eb05389e9b

du listing: https://gist.github.com/24a0da60cbdf1d69f57be1d5bb59ec54

Test this build with Cachix (click to expand)

One time setup in nixpkgs Git checkout:
cachix use r-ryantm
git remote add r-ryantm https://github.com/r-ryantm/nixpkgs.git

Test this build:
git fetch r-ryantm && git checkout 49ac554094768bcd4dae028adca05d3b8fffc998 && nix-shell --pure -I nixpkgs=. -p openvdb

cc @guibou for testing.

No attempt on x86_64-darwin (full log)
The following builds were skipped because they don't evaluate on x86_64-darwin: openvdb
Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

Success on x86_64-linux (full log)
Attempted: openvdb
Partial log (click to expand)
    popd > /dev/null
Copied libopenvdb to /nix/store/2g6sz8w7psqdd02q2bajrf56ncf1g2rr-openvdb-5.2.0/lib
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/2g6sz8w7psqdd02q2bajrf56ncf1g2rr-openvdb-5.2.0
shrinking /nix/store/2g6sz8w7psqdd02q2bajrf56ncf1g2rr-openvdb-5.2.0/lib/libopenvdb.so.5.2.0
/nix/store/vp40my263xk32f07788srrgl59rycsna-binutils-2.30/bin/strip is /nix/store/vp40my263xk32f07788srrgl59rycsna-binutils-2.30/bin/strip
stripping (with command /nix/store/vp40my263xk32f07788srrgl59rycsna-binutils-2.30/bin/strip and flags -S) in /nix/store/2g6sz8w7psqdd02q2bajrf56ncf1g2rr-openvdb-5.2.0/lib
patching script interpreter paths in /nix/store/2g6sz8w7psqdd02q2bajrf56ncf1g2rr-openvdb-5.2.0
checking for references to /build in /nix/store/2g6sz8w7psqdd02q2bajrf56ncf1g2rr-openvdb-5.2.0...
/nix/store/2g6sz8w7psqdd02q2bajrf56ncf1g2rr-openvdb-5.2.0

Success on aarch64-linux (full log)
Attempted: openvdb
Partial log (click to expand)
    popd > /dev/null
Copied libopenvdb to /nix/store/840gvv10djphmmm2gjsc0mg9dkwrkd8v-openvdb-5.2.0/lib
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/840gvv10djphmmm2gjsc0mg9dkwrkd8v-openvdb-5.2.0
shrinking /nix/store/840gvv10djphmmm2gjsc0mg9dkwrkd8v-openvdb-5.2.0/lib/libopenvdb.so.5.2.0
/nix/store/8wl4dykwswy42wxj671b6k7vk2ydxg86-binutils-2.30/bin/strip is /nix/store/8wl4dykwswy42wxj671b6k7vk2ydxg86-binutils-2.30/bin/strip
stripping (with command /nix/store/8wl4dykwswy42wxj671b6k7vk2ydxg86-binutils-2.30/bin/strip and flags -S) in /nix/store/840gvv10djphmmm2gjsc0mg9dkwrkd8v-openvdb-5.2.0/lib
patching script interpreter paths in /nix/store/840gvv10djphmmm2gjsc0mg9dkwrkd8v-openvdb-5.2.0
checking for references to /build in /nix/store/840gvv10djphmmm2gjsc0mg9dkwrkd8v-openvdb-5.2.0...
/nix/store/840gvv10djphmmm2gjsc0mg9dkwrkd8v-openvdb-5.2.0


Fix enqueue now exception

Coverage increased (+0.02%) to 96.441% when pulling 190620ecb30720846388ae70c300449049c8581d on fix/enqueue_now_exception into 059a2654f3f1e633f1b972c85ab0b4b0a9939288 on master.


Randomized algorithms for partial matrix factorizations

For my own work, I had to implement a partial singular value and a partial eigenvalue decomposition using the randomized algorithms from [1] here. The interfaces are very similar to the existing svds and eigsh functions in scipy.sparse.linalg. I haven't compared them in detail to the existing work, but my feeling is that they might be faster if the desired precision is not too high.
My question is if there is any interest in adding these functions to scipy -- I would be willing to create a pull request and maybe add some more features (e.g. specialists faster strategies for dense matrices or higher precision for the eigenvalue decomposition of a positive semidefinite matrix.
Note that some of these strategies are available in a different package, which doesn't abide to the scipy interface.
[1]  Halko, N., Martinsson, P.-G., & TroJ. A. (2009). Finding structure with randomness: Probabilistic algorithms for constructing approximate matrix decompositions.

Hi @dseuss, thanks for asking. I suggest asking on the scipy-dev mailing list to reach a broader audience, since this is a quite specialized topic.

we have some randomized algorithms in linalg/_sketches.py and linalg.interpolative. No further follow-up, so closing.


Get Spring error message in JVM console (again) on start-up error

Describe the bug
When something really bad happens at start-up (like ActiveMQ classes not found) no error is written to the log file or system out while in the past you would see an error message and/or stacktrace (for example when using Frank!Runner) in your terminal / command prompt.
Reporter
Jaco de Groot
Category
Use following Tags to categorize your bug report

Frank!Framework

To Reproduce
Steps to reproduce the behavior:

Remove a vital jar
Start you Frank!
See that no error is reported in the logfile or your terminal / command prompt
Go to GUI 3.0
See that your Frank! hasn't started and showing the error screen
See only an error in the log saying the context is not found but no message explaining the real cause

Expected behavior
I would expect to find an error message explaining the real cause.
Screenshots
-
Environment:

Tomcat
IAF 7.6-SNAPSHOT

Additional context
-

This might have been fixed in #1207. Is it possible to test this again?

I did some testing by adding  to the build.xml of frank-runner/examples/Frank2Example3/build.xml and adding ff.version to frank-runner.properties and tested with a number of framework versions.
With versions 7.1, 7.2, 7.3-RC1, 7.5 and 7.6-20201216.082101 I can not find the problem at the command prompt, console or any logfile.
With versions 5.5 and 7.0-RC3 I can also not find the problem at the command prompt, console or any logfile after start-up, but after that I can click on "click here to start the ConfigurationServlet" and then it will show me java.lang.NoClassDefFoundError: javax/transaction/SystemException

Last week I noticed some errors go to Tomcat's localhost.<date>.log and made a change to the Frank!Runner to make them show up in the Tomcat console window:
https://github.com/ibissource/frank-runner/commit/9fc32830ceaba8b147a88842397a642c3acdfcb8
I've tested that change by breaking springIbisTestTool.xml (also tested breaking springCommon.xml but errors in this file didn't go to localhost.<date>.log).
I see now see that my change in the Frank!Runner also makes the NoClassDefFoundError I mention in this issue appear in the Tomcat console window.
It would still be nice to see the error in the Frank!Console. I probably didn't look in the localhost.<date>.log for this issue as I don't often look in this logfile and expect Frank related issues in the Frank specific logfiles.

Last week I noticed some errors go to Tomcat's localhost.<date>.log and made a change to the Frank!Runner to make them show up in the Tomcat console window:
https://github.com/ibissource/frank-runner/commit/9fc32830ceaba8b147a88842397a642c3acdfcb8
I've tested that change by breaking springIbisTestTool.xml (also tested breaking springCommon.xml but errors in this file didn't go to localhost.<date>.log).
I see now see that my change in the Frank!Runner also makes the NoClassDefFoundError I mention in this issue appear in the Tomcat console window.
It would still be nice to see the error in the Frank!Console. I probably didn't look in the localhost.<date>.log for this issue as I don't often look in this logfile and expect Frank related issues in the Frank specific logfiles.

The exception shows up in catalina.out (which when using eclipse is mapped to the console). When running Tomcat as a service (usually) there's no console, so it's being written to a file in stead. Since you're not running Tomcat headless, you can print everything to the console instead by setting the following property in conf/logging.properties:
org.apache.catalina.core.ContainerBase.[Catalina].[localhost].handlers = java.util.logging.ConsoleHandler

Found 1 scenario where nothing was logged to the Ibis log but only to the servlet.out log.


Improve the states for adding repos

This may be done already but based on feedback from @vincent99 when talking with @oskapt about some Rancher 2.5.3 UI questions, there could be some refinements needed.
Once we check to the state in 2.5.6, we could expand this ticket.

This may move back to rancher/rancher since we're getting information about app repos there.

Closing.


Parent menu no more clickable after adding submenu

Laravel Version: 5.3.*
Voyager Version: 0.10.5
PHP Version: 7
Database Driver & Version:

Description:
After i add a menu as a submenu to another menu the parent menu is no more clickable.
Steps To Reproduce:

I have a feeling this was done on purpose (specifically for the Tools menu), though that doesn't mean it can't be added.

closing this issue, menu is working with the expected behavior.


what is the edition of the tensorflow

I have got the problem when I run the code.
Could you please tell me the edition of your tensorflow?
Thanks.

I have met the question too, as below， maybe the edition is different，mine is "1.2.1",and on cpu, what and where should I change to make it run on cpu?

Traceback (most recent call last):
File "train_c3d_ucf101.py", line 273, in
tf.app.run()
File "/usr/lib/python2.7/site-packages/tensorflow/python/platform/app.py", line 48, in run
_sys.exit(main(_sys.argv[:1] + flags_passthrough))
File "train_c3d_ucf101.py", line 270, in main
run_training()
File "train_c3d_ucf101.py", line 192, in run_training
logits = tf.concat(0, logits)
File "/usr/lib/python2.7/site-packages/tensorflow/python/ops/array_ops.py", line 1044, in concat
).assert_is_compatible_with(tensor_shape.scalar())
File "/usr/lib/python2.7/site-packages/tensorflow/python/framework/tensor_shape.py", line 732, in assert_is_compatible_with
raise ValueError("Shapes %s and %s are incompatible" % (self, other))
ValueError: Shapes (0,) and () are incompatible

The latest code has supported TF 1.2 version now.


Discord Sidebar: Failure to remember login

As title suggest. Everytime we close out and re-enter discord, it seems we are automatically logged off.

Hey @cafelinked,
I tried to replicate a few different situations but I haven't encountered this issue. Using a new Firefox installation, and my current config seems to be working as intended.
When it happens, are you being logged out of the full Discord Webapp as well as the sidebar? If you are, that might indicate a problem with your cookies/cache retention, not necessarily with the extension.
Hope this helps.


ci: add testing to PR workflow

Description: adds testing to Github Actions PR workflow
Test Plan: under checks tab, should show the workflow running lint, format and unit tests successfully
Depends on #77

A docker container inside github actions was having issues of memory due to sequelize. I think it is a good practice to keep unit tests and integration tests separated, so I was wondering if we could make this workflow for now only for lint + format + unit tests, so no starting docker here.
Integration tests will change/behave differently due to prisma (and probably better than sequelize).
I had to make tests and sequelize models relative to their path, tested here in a container of mine and it didn't change anything. Can you check in your machine @chedieck  @Gattaca1?
Should I put these changes in a separate PR?

A docker container inside github actions was having issues of memory due to sequelize. I think it is a good practice to keep unit tests and integration tests separated, so I was wondering if we could make this workflow for now only for lint + format + unit tests, so no starting docker here.
Integration tests will change/behave differently due to prisma (and probably better than sequelize).
I had to make tests and sequelize models relative to their path, tested here in a container of mine and it didn't change anything. Can you check in your machine @chedieck @Gattaca1?
Should I put these changes in a separate PR?

I tested on my machine and looks like everything is still working. I agree that when we finish merging the sequelize -> prisma PRs we can  try to run the integration tests again.


Better error-checking when constructing a GeoData set

If you give lon,lat,depth,data as 3D arrays to construct a GeoData structure, we implicitly assume that the first dimensions of the 3D array is the x-direction, the second one the y direction and the third one the z (vertical) direction.
Yet, if that is not the case, the resulting Paraview output generated with
julia> Write_Paraview(Data_3D, "Data_3D")

looks weird, e.g.:

A solution would be to extend the manual pages accordingly (to better explain this), and perhaps also to do automated error checking to see if the input is as expected.
Automated checking, however, can likely only be done for 3D (perhaps 2D) data sets, because we should still allow for point-wise data (such as earthquakes). As before, such data can be written to paraview with:
julia> Write_Paraview(Data_3D, "Data_3D", PointsData=true)

thanks to Elisabeth Walter for reporting.

this was address in version 0.3.4


Master node launch failure

Hi everybody,
I updated from cfncluster to parallelcluster recently.
I have a configuration which worked on cfncluster and crashes with parallelcluster. The only thing I added is the EFS configuration and the new security group.
My configuration looks like this :

[aws]
aws_region_name = us-east-1
aws_access_key_id = XXX
aws_secret_access_key =XXX

[cluster default]
vpc_settings = public
key_name = XXX
compute_instance_type = t2.micro
master_instance_type = t2.micro
initial_queue_size = 0
max_queue_size = 2
maintain_initial_size = false
custom_ami = ami-XXX
master_root_volume_size = 20
compute_root_volume_size = 20
efs_settings = customfs
additional_sg = sg-XXX

[vpc public]
master_subnet_id = subnet-XXX
vpc_id = vpc-XXX

[global]
update_check = true
sanity_check = true
cluster_template = default

[aliases]
ssh = ssh {CFN_USER}@{MASTER_IP} {ARGS}

[efs customfs]
shared_dir = efs
encrypted = false
performance_mode = generalPurpose
efs_fs_id = fs-XXX

And it gives me this error :
Creating stack named: parallelcluster-mycluster
Status: parallelcluster-mycluster - ROLLBACK_IN_PROGRESS
Cluster creation failed.  Failed events:
  - AWS::EC2::Instance MasterServer Received FAILURE signal with UniqueId i-07af1cb218dd6a081

Thank you for you help
Bye

Hi @carlitador
Any update on this?


Don't handle alt-f4

On both Windows and Linux (not sure about Mac), alt-f4 is translated into window close events by the window manager, and thus need not be handled by individual applications. Also, many Linux environments can be configured to not use alt-f4 at all (I use win-X for example). In those cases, handling alt-f4 inside applications is directly detrimental to the user experience, as it is different from just about every other application on the system.

Good to know! Yeah, let's remove it then.
On mac one has to manually opt-in to Cmd-Q (surprisingly enough), that's why I assumed it was the same on Windows/Linux.

Oh, checking for Cmd-Q is no longer needed on mac either. This must have changed when I upgraded winit!


[SPARK-7862] [SQL] Disable the error message redirect to stderr

This is a follow up of #6404, the ScriptTransformation prints the error msg into stderr directly, probably be a disaster for application log.

Merged build triggered.

Merged build started.

Test build #35129 has started for   PR 6882 at commit 402f746.

Test build #35129 has finished for   PR 6882 at commit 402f746.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class ElementwiseProduct(VectorTransformer):
case class CreateStruct(children: Seq[Expression]) extends Expression
case class Logarithm(left: Expression, right: Expression)
case class SetCommand(kv: Option[(String, Option[String])]) extends RunnableCommand with Logging

Merged build finished. Test PASSed.

Thanks for fixing this!  Minor suggestion otherwise LGTM.  It would also be good if follow-ups like these got a new JIRA.  Its hard to track progress on tickets that are already closed.

For this case I can just reopen the JIRA though.

Thank you @marmbrus that's a good idea, updated!.

Merged build triggered.

Merged build started.

Test build #35199 has started for   PR 6882 at commit bf3d592.

Test build #35199 has finished for   PR 6882 at commit bf3d592.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Merged build triggered.

Merged build started.

Thank you @srowen that's a good suggestion, I've also move the CircularBuffer into the Utils.

Test build #35274 has started for   PR 6882 at commit 09dd5b9.

Test build #35274 has finished for   PR 6882 at commit 09dd5b9.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

btw, let's enable "test script transform for stderr" in this pr.

Merged build triggered.

Merged build started.

Test build #35515 has started for   PR 6882 at commit 5ccbfaa.

Test build #35515 has finished for   PR 6882 at commit 5ccbfaa.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Merged build triggered.

Merged build started.

Test build #35640 has started for   PR 6882 at commit ed8f875.

Test build #35640 has finished for   PR 6882 at commit ed8f875.

This patch fails MiMa tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Seems not related to my change.
retest this please

retest this please

Merged build triggered.

Merged build started.

Test build #35659 has started for   PR 6882 at commit ed8f875.

Test build #35659 has finished for   PR 6882 at commit ed8f875.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Merged build triggered.

Merged build started.

Test build #35848 has started for   PR 6882 at commit 4316d07.

Test build #35848 has finished for   PR 6882 at commit 4316d07.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

retest this please

Merged build triggered.

Merged build started.

Test build #35912 has started for   PR 6882 at commit 4316d07.

Test build #35912 has finished for   PR 6882 at commit 4316d07.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Merged build triggered.

Merged build started.

Test build #35955 has started for   PR 6882 at commit bfedd77.

Test build #35955 has finished for   PR 6882 at commit bfedd77.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Thanks, merged to master.


Manually adding doesn't work properly.

I have this for 1.8.9 and 1.12.2. The 1.8.9 version works flawlessly but the 1.12.2 version doesn't. On my server we have a prefix for command spy [Spy] so I want this to have it's own tab and not show in the general tab. But when I add it manually as a filter it selects everything that starts with [ If I turn on automatic finding then it does it properly but doesn't hide it from the main chat of which I can't edit it to tell it to. Also I try to add pms as a custom filter aswell that would be separated from the main chat and that doesn't work either. Idk what is wrong because the 1.8.9 version works fine. Could it be a problem with Bungeecord making it not detect the servers properly?

I took a screenshot https://i.imgur.com/jJjavoW.png

And here's the one I was also trying for Staff Chat https://i.imgur.com/bmkua69.png

PMs are somewhat more advanced than usual filters. This is because it could be Me -> You or You -> Me. Depending on the plugin you're using, this could be different. HeroChat for example uses the To You/From Me format.
I suggest using a website such as regexr to test your filters.

Yeah my problem was if I didn't enable regular expressions nothing at all happened and if I did it just took everything starting with [ I guess I'll try that though. Again the pms weren't hard to do for me on Hypixel on 1.8.9 but doing the same thing on 1.12.2 didn't work

Okay well weird thing is now it works.. One last thing.. is there a way to disable them from lighting up red every time a new message appears in a specific tab?

In general settings, there's a setting called unread flashing. Disable that.

But it already is and still does it.


Debug: Render collision  shape

Feature request
I was trying to add a collider for my GLB model, but I have not been able to fit it into the model in any way, it always seems to be inverted, out of scale, among other problems.
It would be much easier and agile to render and see exactly the shape of the colliders - both mesh and primitive types - during development.

As of today, I can see the shapes of collision components in the editor.

Is this what you wanted, @derickwelman?

@mast4461 I think the problem is that you can only view GLB based models in the launch page and not the Editor but you can only view collision volumes in the Editor and not the launch page.
We are working on adopting GLB in the Editor properly so this should become less of a problem. As a workaround, you could just write a debug utility script that draws transparent primitive shapes in your running app/game.

I suggest we close this, as there is now a PlayCanvas based collision shape view, as well as third party runtime viewers (e.g. https://playcanvas.com/project/744419/overview/ammo-debug-draw)

Agreed.


What network types are supported?

The docs mention:
Currently, only WPA is supported for the algorithm value.
What does this mean in practice? Does this mean only networks with WPA authentication can be joined? What about WPA2, WPA-PSK, WPA Enterprise, WEP, or even open networks?

WPA, WPA2, WPA-PSK are supported. WEP is not supported and I'm not sure about WPA Enterprise.
However, we are able to support whatever android supports since we interact with android wifimanager directly. If you have a specific algorithm you want support for I'm sure we can add it.
let me know, thanks.

Any way to just abstract the network type out of the process?
Since I cannot predict the type of WiFi my users intend to use, I'd prefer not to worry about it and just have them supply the SSID and password.
However, I realize that some networks require a username also. But since the array of networks coming back from the scan, don't reveal the authentication type, I wouldn't know how to anticipate this. The same goes for open networks actually. I would prefer to just let the user join those without prompting for a password first. Any way that the scan results could include the type of network?
In comparison: If you open the AirPort dropdown on a Mac with the alt key down, you can see the type of every network in range. My guess is that my Mac didn't have to say hi to every network to get their authentication type. Any way this could be included?

Yes the scan result should be returning the wifi capabilities. ScanResult.capabilities describes the authentication, key management, and encryption schemes supported by the access point.
If the wifi network has a captive portal like you get at an airport or hotel there is really no way around that.
The way the add network function works right now is it checks the authentication type. If auth == wpa else if auth == wep else if auth == NONE. So, you should be able to add to most wpa networks and open networks. However, this may not be the best way to go about determining the network type, as you pointed out if it's an open network the user shouldn't be prompted for a password.

I'm trying this plugin on Android 5.x and 6.x. I have an open Wifi network which I need to add and then connect to. I'm not able to add the open network to the phone. The plugin returns an error saying incorrect protocol for NONE, and doesnt work for the said network if I try WPA as the protocol.
Any ideas how I can connect to an open network?
var config = WifiWizard.formatWifiConfig(wifi_ssid, "", "NONE");//None - incorrect protocol; WPA not working for device...
console.log("connectWifi: ", wifi_ssid, config);
console.log("calling addNetwork...");
WifiWizard.addNetwork(config, function() {
console.log("addNetwork done! now calling connectNetwork...");
WifiWizard.connectNetwork(wifi_ssid, win_wifi, fail_wifi);
}, fail_wifi);


How to use JS & TS ?

Hello again..
It is possible to use some JS code inside my index.ts ?
I have some default Frida JS code that i cannot replicate via frida-il2cpp-bridge (due some less knowledge reason)
For example i can call some function/methods from other classes to interact with that function but cannot with frida-il2cpp-bridge.
Can we use FridaJS in our *.ts?

Of course you can, I strongly suggest you to google a little bit about this topic.


fixed the typo on step61 of sudoku solver project

Checklist:

[x ] I have read and followed the contribution guidelines.
[x] I have read and followed the how to open a pull request guide.
[x] My pull request targets the main branch of freeCodeCamp.
[x] I have tested these changes either locally on my machine, or GitPod.

Closes #54253
Fixed the typo on Step 61 of Sudoku Solver project in Scientific Computing with Python (Beta) cert from "withing" to "within".

Fix: Typo on Step 61 of Sudoku Solver

HI @himzz1234 !
Thank you for your interest in contributing to freeCodeCamp.
We just merged in this PR which addresses the same issue
https://github.com/freeCodeCamp/freeCodeCamp/pull/54253
We are going to close this PR.
But we encourage you to look into other first timer or help wanted issues.
Happy coding!


testing: bad output formatting when test stdout ends in an incomplete line

What version of Go are you using (go version)?

$ go version
go version go1.14.1 darwin/amd64

Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE="on"
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/pete/Library/Caches/go-build"
GOENV="/Users/pete/Library/Application Support/go/env"
GOEXE=""
GOFLAGS=" -mod="
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOINSECURE=""
GONOPROXY="github.com/circleci"
GONOSUMDB="github.com/circleci"
GOOS="darwin"
GOPATH="/Users/pete/Source/go"
GOPRIVATE="github.com/circleci"
GOPROXY="direct"
GOROOT="/usr/local/Cellar/go/1.14.1/libexec"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/Cellar/go/1.14.1/libexec/pkg/tool/darwin_amd64"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="<>/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/lh/8qc651cn25n1knh824hcyd0r0000gn/T/go-build757047380=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?
package testissue

import (
	"fmt"
	"testing"
)

func TestBad(t *testing.T) {
	// No newline below
	fmt.Print("bad output")
}

func TestGood(t *testing.T) {
	// Print a newline below
	fmt.Println("good output")
}

then run:
go test -json ./testissue

What is the issue?
The JSON output seems corrupted for the "bad" test. You can see that it is missing a "pass" action.
The issue appears to be in the conversion the test2json command is doing from stdout of the test runner into JSON. https://github.com/golang/go/blob/master/src/cmd/internal/test2json/test2json.go
{"Time":"2020-03-25T10:07:16.831092Z","Action":"run","Package":"github.com/circleci/distributor/testissue","Test":"TestBad"}
{"Time":"2020-03-25T10:07:16.83137Z","Action":"output","Package":"github.com/circleci/distributor/testissue","Test":"TestBad","Output":"=== RUN   TestBad\n"}
{"Time":"2020-03-25T10:07:16.831384Z","Action":"output","Package":"github.com/circleci/distributor/testissue","Test":"TestBad","Output":"bad output--- PASS: TestBad (0.00s)\n"}
{"Time":"2020-03-25T10:07:16.831401Z","Action":"run","Package":"github.com/circleci/distributor/testissue","Test":"TestGood"}
{"Time":"2020-03-25T10:07:16.831405Z","Action":"output","Package":"github.com/circleci/distributor/testissue","Test":"TestGood","Output":"=== RUN   TestGood\n"}
{"Time":"2020-03-25T10:07:16.831414Z","Action":"output","Package":"github.com/circleci/distributor/testissue","Test":"TestGood","Output":"good output\n"}
{"Time":"2020-03-25T10:07:16.831423Z","Action":"output","Package":"github.com/circleci/distributor/testissue","Test":"TestGood","Output":"--- PASS: TestGood (0.00s)\n"}
{"Time":"2020-03-25T10:07:16.831426Z","Action":"pass","Package":"github.com/circleci/distributor/testissue","Test":"TestGood","Elapsed":0}
{"Time":"2020-03-25T10:07:16.831443Z","Action":"output","Package":"github.com/circleci/distributor/testissue","Output":"PASS\n"}
{"Time":"2020-03-25T10:07:16.831486Z","Action":"output","Package":"github.com/circleci/distributor/testissue","Output":"ok  \tgithub.com/circleci/distributor/testissue\t0.149s\n"}
{"Time":"2020-03-25T10:07:16.833206Z","Action":"pass","Package":"github.com/circleci/distributor/testissue","Elapsed":0.151}

@matloob @bcmills @jayconrod

This has basically nothing to do with test2json — it is more-or-less correctly parsing the bad output. The problem is that the output is missing a newline, and the testing wrapper doesn't inject one:
example.com$ go version
go version devel +6b6414ca Wed Mar 25 04:06:34 2020 +0000 linux/amd64

example.com$ go mod init example.com
go: creating new go.mod: module example.com

example.com$ cat > testissue_test.go
package testissue

import (
        "fmt"
        "testing"
)

func TestBad(t *testing.T) {
        // No newline below
        fmt.Print("bad output")
}

func TestGood(t *testing.T) {
        // Print a newline below
        fmt.Println("good output")
}

example.com$ go test -v .
=== RUN   TestBad
bad output--- PASS: TestBad (0.00s)
=== RUN   TestGood
good output
--- PASS: TestGood (0.00s)
PASS
ok      example.com     0.021s

This problem appears to have existed for a long time:
example.com$ go1.13.9 test -v .
=== RUN   TestBad
bad output--- PASS: TestBad (0.00s)
=== RUN   TestGood
good output
--- PASS: TestGood (0.00s)
PASS
ok      example.com     (cached)

example.com$ go1.12.17 test -v .
=== RUN   TestBad
bad output--- PASS: TestBad (0.00s)
=== RUN   TestGood
good output
--- PASS: TestGood (0.00s)
PASS
ok      example.com     (cached)

CC @mpvl

Can we really do anything about this? I could not imagine a way to determine the last character from flushed outputs... In the log package, it is pretty straightforward, because it has an internal buffer, and the check can be done by checking its buffer, but in the testing package, the output is directly executed from the userland.

Related to #27764 #35180 #33419 at least.

Can we really do anything about this? I could not imagine a way to determine the last character from flushed outputs...

Maybe. Test binaries write messages to the go test driver on stdout. Tests may also write to stdout, so the output gets mixed together. Test binaries could write messages on some other channel (pipe, socket, whatever) to avoid this problem.

A dedicated “test metadata” communication channel with JSON or other machine readable format to transport this data around would seem sensible. Then it can be converted to the regular output (or kept as JSON or whatever other output formats that are required) would seem logical to me.
Could it even be kept in-process, to avoid the serialisation overhead?

Could it even be kept in-process, to avoid the serialisation overhead?

Unfortunately not. Each package's test is built into a separate binary and run in a separate process. Global side effects from tests and init functions shouldn't be visible to tests for other packages.

@changkun, testing and os are both in the standard library, so if need be we could even hook os.Stdout and os.Stderr with a side-channel to tell the testing package about output line state.
(#29062 is closely related, in the sense that it could be implemented by hooking the os package.)

Interesting. The print and println builtins just came to my mind and I didn't know them is not guaranteed to stay in Go (said in builtin package). A quick look into runtime implementation indicates that they invoke syscall write directly. The same applies to the syscall package... It seems we cannot easily do hooks about these writes, is it?
Perhaps we could just duplicate meta outputs from testing to a tmp file similar to what @jayconrod suggested, then parse these temp files in test2json?

I'm not worried about hooking the builtins or anything that hard-codes writes to those file descriptors other than via the os package. (Any test relying on their behavior is already, uh, “not guaranteed not to be broken”.)

What's the resolution to this issue? It's currently marked closed, but I couldn't find a clear explanation of why it was closed. Should downstream test frameworks be handling this in some way?

@nicks The issue remains unsolved, but not really sure if someone has the interest to write a fix that well balances the implementation complexity and the actual achievements on solving the problem (and probably the reason that @pete-woods of this issue closes this). As for now, a simple workaround is as you referenced: add a \n if needed.

I actually thought the issue was solved (for the most part) with changes to the way the logs are emitted.
For me, at least, we moved away from parallel tests at CircleCI after finding extremely marginal to negative benefit to using them.


doesn't send access-control-allow-origin header

Fetch API cannot load https://api.steemitdev.com/. No 'Access-Control-Allow-Origin' header is present on the requested resource. Origin 'https://steemitdev.com' is therefore not allowed access. The response had HTTP status code 502. If an opaque response serves your needs, set the request's mode to 'no-cors' to fetch the resource with CORS disabled.

http --headers get https://api.steemitdev.com
HTTP/1.1 200 OK
Access-Control-Allow-Headers: DNT,Keep-Alive,User-Agent,X-Requested-With,If-Modified-Since,Cache-Control,Content-Type,Content-Range,Range
Access-Control-Allow-Methods: GET, POST, OPTIONS
Access-Control-Allow-Origin: *
Connection: keep-alive
Content-Length: 114
Content-Security-Policy: upgrade-insecure-requests
Content-Type: application/json
Date: Fri, 15 Sep 2017 17:54:09 GMT
Server: nginx/1.10.3 (Ubuntu)
Strict-Transport-Security: max-age=31557600; includeSubDomains; preload


Telemetry test: handle multiple paths in KUBECONFIG

Please provide a description of this PR:
Follow up for #54392
Handle multiple paths in KUBECONFIG - https://kubernetes.io/docs/tasks/access-application-cluster/configure-access-multiple-clusters/#set-the-kubeconfig-environment-variable

@sergii-ssh: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
d52b679d4bd8497b48dfe510c77d858d6fc8dcd6
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@sergii-ssh: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
14daa6d058bb3949bc5384362dfd06d5bce3c4f8
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@MaxBab PTAL, seems that I don't have permissions to add you to "Reviewers".
Our multi-cluster tests are configured with multiple entries in KUBECONFIG and after #54392 they are failing with kubeconfig file not found:.  This PR changes the IsKindCluster to return true if any cluster in kubeconfig is kind type

@MaxBab PTAL, seems that I don't have permissions to add you to "Reviewers". Our multi-cluster tests are configured with multiple entries in KUBECONFIG and after #54392 they are failing with kubeconfig file not found:. This PR changes the IsKindCluster to return true if any cluster in kubeconfig is kind type

Hi @sergii-ssh
The fix looks great.
Sorry for creating a bug for you while fixing my flow and thanks for the fix.

Maybe this is a good sign its time to do this the proper way? #54392 (comment)

I can take care of it.
As far as I understand, I need to add the relevant flow of context fetch here - https://github.com/istio/istio/blob/master/pkg/test/framework/resource/context.go
I just thinking of a proper way to do so.

Ok, I've created something.
Will organize it properly, then create a PR and then will link it here so @sergii-ssh will check and validate it on his flow as well.

I've created the following PR that should cover the issue - https://github.com/istio/istio/pull/54507


Create User Personas

Create user personas to represent  the groups of users we are building this functionality for. You can find various templates online. It can be a fairly simple representation.
We can start with two:

Researchers (from various organisations specifically looking for tools like the DMF) and
General User (anyone who uses/vists the ACE website)

We can validate the characteristics of the personas with Ellen and Rana.

@mhallaq @leilafaez @Ekremteke @luan-murilo-de-oliveira-e-souza please feel free to have this ticket assigned to either one or two of you only but please make sure that whoever has worked on it shares it with the rest of the group.

Hi team, has there been any progress on this?

Hi Milan. Ekrem and I working on it

Brilliant, thanks @leilafaez & @Ekremteke

we make 2 user personas one for Rana another, as a user . I will attach them here

Thank you @leilafaez , looks great. I have a few comments to make some revisions but we can close this task as the first draft done.


Updated selinux python package to python3 version

changed python package to python3 version

Looks fine, but I would protect the master branch in this repo


Footer

This PR connects to 47

Since the wrappers and the main components are part of app.component, I'd move the css you added to main.scss to app.component.scss

Also, instead of prefixing the footer css with /* just for demo */ I'd try to take it a step further in the right direction, by using variables as much as possible.
e.g. https://gist.github.com/artlowel/76bc90d2722fbe4ee2e2576bf718ee54
That way it'll be easier to theme later.

LGTM

Good also for me!

+.inner-wrapper {
 +  flex: 1 1 auto;
 +  flex-flow: column nowrap;
 +  display: flex;
 +  min-height: 100vh;
 +  flex-direction: column;
 +}

I don't think there should be a fixed min-height.


feat: Populate is_view property in AtlasProxy

Summary of Changes
Distinguish between tables and table views based on tableType property of table in Atlas.
Tests
Extended mock and expected data.
Documentation

CheckList
Make sure you have checked all steps below to ensure a timely review.

[x] PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"

In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

[x] PR includes a summary of changes.
[x] PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
[x] In case of new functionality, my PR adds documentation that describes how to use it.

All the public functions and the classes in the PR contain docstrings that explain what it does

[x] PR passes make test

Codecov Report

Merging #155 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #155      +/-   ##
==========================================
+ Coverage   73.35%   73.38%   +0.02%
==========================================
  Files          26       26
  Lines        1265     1266       +1
  Branches      136      136
==========================================
+ Hits          928      929       +1
  Misses        309      309
  Partials       28       28

Impacted Files
Coverage Δ

metadata_service/proxy/atlas_proxy.py
84.30% <100.00%> (+0.05%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6178a03...4756358. Read the comment docs.

lgtm, but will let @verdan to confirm.


Error enum and correct handling of no config

Added an enum to represent errors and certain behaviour types (to avoid magic numbers).

There was an error introduced in 11d476c3bcdf5465835bd4a7ead7c80ec21cc1d7 so that ReX quit if no config file was present rather than reverting to defaults.

There's quite a few changes in here that don't seem directly related to the key bullet points above (changes to default values in CausalArgs, adding new command line options) - do you mind stripping these out (or I can do it)? I imagine the new command line options are changes that are also introduced in one of the other branches you're working on atm and I think it'll be confusing /cause issues later if they're introduced here (and the default value changes look like unintentional reversions to previous values).
I'm also not familiar with using an Enum in this way - I was imagining something like:
class BadTomlException(Exception):
    pass

def get_config_file(path):
    """parses toml file into dictionary"""
    if path is None:
        return None
    if not os.path.isfile(path):
        raise FileNotFoundError
    try:
        file_args = toml.load(path)
        return file_args
    except Exception as e:
        raise BadTomlException from e

with a try/except statement in the function that calls get_config_file

I must have forked off of the wrong branch accidentally. I'm happy to fix the config values but it'll have to wait until Monday. As for the enum pattern, it's the sort of thing one finds in functional programming and in general I prefer it. I really don't like stacked exception raising, but if it's more pythonic then I could be convinced.

@liz-is I think that reverts the changed args. One point I forgot to mention is the removal of self.type = CAUSAL. This used to do something (as we also had a statistical based approach to explanation generation) but I removed that code a long time ago. Didn't seem worth a separate pull request just to remove that. Let discuss it next week

Yeah that looks like it fixes it, thanks!
@LouiseABowler do you have any thoughts on what's a more Pythonic approach here?

I had a chat with a couple of other members of the RSE team in the office today, and they think that raising exceptions would be the more pythonic way to handle this kind of situation. We think that it would likely be easier for users to understand, as they'd be more familiar with how to handle exceptions. I'd be happy to have a quick go at implementing that approach in Jan? We can stick with this approach though if you'd rather.

@liz-is I've created a ReXError class that inherits from Exception, and then spun off a few subclasses. For the time being, they live in _utils.py but it might make sense to move then to their own module. I've linked this into the config.py as well. The removal of self.type == CAUSAL now causes the tests to fail, but I'm not familiar with the snapshot stuff enough to fix this myself.


Add master toleration

and switch to community accepted master role label
In favor https://github.com/giantswarm/aws-terraform/commit/28067f79d4e13fa3ee0ade7b57aec44d12bb4e31

@calvix @corest pls review

this is for the host cluster and I don't think we have this new label in host cluster anywhere.
I cant say if this break stuff or not

@calvix you're right. So at the moment just added comment and later when all clusters will have this label we can switch to it.

Merging.


Enhancement: Ability to select a folder for recordings.

Personally, I do not like having much stuff in Foundrys data folder, I like it much better to have it sorted in my worlds folders. A way to select a folder (scope world) where the sound files are placed would greatly enhance the user experience for me.

Agreed, I will add a module setting to select a recording directory.


showDetails toolbar button can be in wrong state after initialization

It seems that the showDetails button is always in the active state by default, even when json-viewer is initialized with show-data-types="false" and show-size="false". In that scenario the button then requires two clicks before it has the expected toggling effect.

Thank you for reporting this issue. I will check it and work on a fix.


BUG: Mitigate integer overflow

In cshape.c, v_max would quickly overflow with big images resulting in messages like RuntimeError: Calculation of Shape coefficients failed. To mitigate this effect, this PR changes its type from int to size_t (usually unsigned long).

Thanks for the contribution :+1:


Expose secp256k1 Signature

This is for re-use in sui repo where we use AWS KMS as a signer for secp256k1

fix lint with: cargo fmt && cargo xclippy
lgtm


Compile Files is disabled

For some reason the Compile FIles button is disabled. Did I missed something?

Had the same problem. This worked for me:

Use Unity 2018.4.22f1
Delete everything in the default scene
Adding "ImageTarget" with corresponding steps
Check if Compile files is enabled
Add objects
Compile

Half of this might not have any effect, but this worked for me. I hope it does for you!