Migrate AWS JS SDK back to V2

Backstage recently migrated the AWS JS SDK being used to V3 (#3953, #4035). While this is great in terms of keeping Backstage updated with the latest dependencies, the V3 SDK has not implemented a number of authentication-related features that make it more difficult to use with Backstage, namely:

No clean way to chain credentials with automatic refresh - see https://github.com/aws/aws-sdk-js-v3/issues/1796 . This is important for Backstage especially because, depending on the cloud account setup for a company, Backstage might be using AWS APIs in several accounts (i.e. reading Organizations data from a privileged account, storing S3 data in another account, scraping EKS data from a bunch). Without ChainableTemporaryCredentials, this is extremely difficult to do effectively.

No support for IAM Roles for Service Accounts - see https://github.com/aws/aws-sdk-js-v3/issues/1808 . This makes it difficult for folks running Backstage on EKS to easily integrate with IAM roles. There are workarounds available - using KIAM, static credentials, shared node credentials - but these workarounds have security tradeoffs involved.

If we decide to migrate back to V2, it would make it easier for folks running on AWS to use the built in AWS integrations, especially those using multiple accounts or those running Backstage on EKS.

@backstage/maintainers leaning towards migrating back to v2. Seems like it might take quite a while until v3 implements these features.
Any thoughts on this @ayshiff or anyone else? As I understand it the migration to v3 was mainly do to it being a bit nicer to use in modern JS/TS, but not driven by any other need. As mentioned it's ofc best to stay on top of the latest versions, but it's a bit troublesome that we're seemingly losing these auth features.

Agreed. I believe the decision was based on better TS support and being on the latest version. Unfortunate that v3 does not have feature parity.

Alright, repurposed this issue for the task of migrating back to v2. We should strive to do it in an as clean way as possible with few unrelated changes, just to make it easy to use it as a reference once we want to go back to v3. Ofc the existing PRs are good references for migrating back, #3953, #4035

This is great news from my point of view.  I'm looking forward to being able to use OIDC auth from my EKS cluster.
Thanks for prioritising functionality for us users over keeping up with latest and greatest!


Updated scripts to generate and rule doc page

This PR update the lint scripts:

it generates a new .md page inside the website, which will contain the description of the rule inside the website
the new .md file will be named <kebab-case-name-of-rule>.md and it will be placed under website/src/docs/check/rules/<CATEGORY>
update the update.cjs script in order to update the correct paths

I wanted to have the rules divided by category as we do inside the lint. This PR updates that too.

Looks good! Ignore the macos CI failure. I have actually ran into it a few times on macOS. Maybe I can figure it out today. I'll leave final review and merging to @EduardoLopes.

@sebmck @EduardoLopes change done!


Add epik

Seems to be Pinterest
https://painlessbloganalytics.com/what-is-fbclid-how-to-remove/

Resolved by 75dd01bbf5a93d377a3e1ec4c5bacd95b8023f3f


Workflow fail parsing

Script to parse workflow fail logs and categorize them into fail types, with log snippets that attempt to pinpoint the error message or stack trace of each failure

Collects and parses error logs of latest master branch fails to find possible issues. Currently diagnoses most out of space issues; more error determinations and functionality to come.
Example run:
https://github.com/kliao-csa/connectedhomeip/actions/runs/6018533131


Destroy locust tfstate in gcp-dev

To prevent failures like:
https://gitlab.com/gpii-ops/gpii-infra/-/jobs/93807657

LGTM


Adds short day of the week to the date, above my-units calendar

Doesn't work, like we talked. Just marking so it doesn't get merged accidentially.

Yup, the date input is broken all-in-all. Moved the weekday outside the input-element, but it would need design decisions and then styling according to those before being ready.


Issue with MXRoyale project

Hi Josh,
using latest local build (0.15.0-SNAPSHOT) and pointing with "as3mxml.sdk.editor" to local SDK with latest compiler, I'm seeing as3&mxml gives an error when using a MXRoyale project, I think caused by this:
http://apache-royale-development.20373.n8.nabble.com/Proxy-method-calls-with-RemoteObject-td6717i20.html#a6834
Test case is here:
https://github.com/apache/royale-asjs/tree/develop/examples/mxroyale/RemoteObjectAMFTest
I get:
{
"resource": "/Users/carlosrovira/Dev/Royale/Source/royale-asjs/examples/mxroyale/RemoteObjectAMFTest/",
"owner": "generated_diagnostic_collection_name#1",
"code": "1310",
"severity": 8,
"message": "Unexpected character. '' is not allowed here",
"startLineNumber": 1,
"startColumn": 1,
"endLineNumber": 1,
"endColumn": 1
}

You seem to have an invalid character in App.mxml. I see that the encoding appears to be UTF-8 with BOM rather than just UTF-8. It's probably having an issue with that invisible BOM character at the beginning of the file.

The compiler also seems to dislike the theme compiler option in asconfig.json.

Thanks Josh, doing the two fixes and setting up "as3mxml.sdk.editor" with the local build SDK makes all work perfectly. Thanks! :)


[QUERY] How do I create a Function v4 using resource manager API?

Library name and version
Azure.ResourceManager.AppService
Query/Question
Consider the following code that worked for function apps prior to v4:
var bindingsConfig = new
{
    bindings = new object[]
        {
            new
            {
                AuthLevel = "function",
                Type = "httpTrigger",
                Direction = "in",
                Name = "request",
                Methods = new[] {"post"}
            },
            new
            {
                Type = "http",
                Direction = "out",
                Name = "$return"
            }
        }
};

app = await myResourceGroup.GetWebSites().GetAsync("my-app-name", ct);
var func = await app.GetSiteFunctions().CreateOrUpdateAsync(WaitUntil.Completed, "my-func-name", new FunctionEnvelopeData
{
    Config = BinaryData.FromObjectAsJson(config)
}, ct);

Now according to this doc, function.json is no longer used in v4 programming model. My question is - does it mean I shouldn't be passing bindingsConfig into CreateOrUpdateAsync()? When I try it though I get the following error:
Azure.RequestFailedException: 'Error creating function. <my-func-name> is not a valid function name
Status: 400 (Bad Request)
ErrorCode: BadRequest

In general how should I call CreateOrUpdateAsync() to create a v4 kind of function?
Environment
No response

Thank you for your feedback.  Tagging and routing to the team member best able to assist.

I'd greatly appreciate if someone can point me to an example of creating a v4 function app using Resource Manager API.

Well I can certainly open a ticket with Azure support, but I believe this is a problem of SDK. Azure allows creating a v4 function app  via deployment from VS Code. But what I need is to create one using SDK (Azure.ResourceManager.AppService lib). All I ask is for a working example of making a call to CreateOrUpdateAsync() described above that will create a v4 function app. Unfortunately there is no documentation that describes it or gives any examples.
Can you at least answer the question whether or not the creation of v4 function app is supported by Azure.ResourceManager.AppService? Have you ever tried/tested it internally on your end?


Receive: Make head series limiting config per tenant

This PR adds head/active series limiting configuration to the new per tenant limiting config added in #5565.

[x] I added CHANGELOG entry for this change.
[ ] Change is not relevant to the end user.

Changes

Remove flags and fields passed via receive Handler options
Make naming of active series limiting interfaces/structs consistent to "head series" and move to a separate file
Add options to limiting config file
Update e2e test to use new config
Update docs

Verification
All receive e2e tests pass locally and have tested different config scenarios.

Have implemented all suggestions. Also, initialized limiter in cmd/receive.go and passed it down to webHandler as suggested by @matej-g . 🙂

Seems like test failure is related :monocle_face:
--- FAIL: TestReceiveQuorum (0.00s)
    --- FAIL: TestReceiveQuorum/size_1_success (0.00s)
panic: runtime error: invalid memory address or nil pointer dereference [recovered]
	panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x10 pc=0xea9352]

goroutine 64 [running]:
testing.tRunner.func1.2({0xfb8c40, 0x1b41ff0})
	/usr/local/go/src/testing/testing.go:1389 +0x24e
testing.tRunner.func1()
	/usr/local/go/src/testing/testing.go:1392 +0x39f
panic({0xfb8c40, 0x1b41ff0})
	/usr/local/go/src/runtime/panic.go:838 +0x207
github.com/thanos-io/thanos/pkg/receive.(*Handler).receiveHTTP.func1({0x140fd58?, 0xc0000440b0?})
	/home/circleci/project/pkg/receive/handler.go:411 +0x52
github.com/thanos-io/thanos/pkg/tracing.DoInSpan({0x140fd58?, 0xc0000440b0?}, {0x1121e8c?, 0x2?}, 0xc00028fcc0, {0x0?, 0x0?, 0xa?})
	/home/circleci/project/pkg/tracing/tracing.go:95 +0xa3
github.com/thanos-io/thanos/pkg/receive.(*Handler).receiveHTTP(0xc0001942a0, {0x140f148, 0xc00022a6c0}, 0xc000152400)
	/home/circleci/project/pkg/receive/handler.go:410 +0x2b0
github.com/thanos-io/thanos/pkg/receive.makeRequest(0xc0001942a0, {0x1105819, 0x4}, 0x1?)
	/home/circleci/project/pkg/receive/handler_test.go:1210 +0x25e
github.com/thanos-io/thanos/pkg/receive.TestReceiveQuorum.func4(0xc0002621a0)
	/home/circleci/project/pkg/receive/handler_test.go:687 +0xd2
testing.tRunner(0xc0002621a0, 0xc00023c7c0)
	/usr/local/go/src/testing/testing.go:1439 +0x102
created by testing.(*T).Run
	/usr/local/go/src/testing/testing.go:1486 +0x35f
FAIL	github.com/thanos-io/thanos/pkg/receive	0.053s


Atualizar a versão do axios

Axios up to and including 0.18.0 allows attackers to cause a denial of service (application crash) by continuing to accepting content after maxContentLength is exceeded

Resolvido com o pullrequest #5


asGeoJson hook breaks reactivity

Because the GeoJson structure does not comply with the standard Feathers structure real-time events do not correctly update the underlying items when using feathers-reactive.
A workaround could be to send back only the features property content of the GeoJson collection instead of a FeatureCollection item but this is not a "valid" GeoJson per-se.

Can be fixed by using the asFeatureCollection option of the hook set to false (default to true).


Eloquent builder passthru should include "raw"

For example:
$raw = MyModel::query()->raw('1');

echo get_class($raw);

Expected output:

Illuminate\Database\Query\Expression

Actual output:

Illuminate\Database\Eloquent\Builder

Since the Eloquent query builder does not have 'raw' listed in its passthru array, the raw method is called on the base query (and, in turn, on the connection class), but the result is then discarded and $this is returned.
https://github.com/laravel/framework/blob/2b4aa9fb285a16755afd88d28e7d1bbe4a012ae5/src/Illuminate/Database/Eloquent/Builder.php#L69

For suggestions and feature requests please use the https://github.com/laravel/internals repo.


Partition keys not sorted in alphabetic order

Preflight Checklist

[X] I have installed the latest version of Storage Explorer.
[X] I have checked existing resources, including the troubleshooting guide and the release notes.
[X] I have searched for similar issues.

Storage Explorer Version
1.35.0
Regression From
No response
Architecture
i86
Storage Explorer Build Number
20240810.1
Platform
All
OS Version
Windows 10
Bug Description
When sorting partition keys, they are not appearing in the expected sort order (i.e. alphabetic)
Steps to Reproduce

Load records from attached file into new storage table.
View table in Azure Storage Explorer.
Sort by partition key increasing.
Sort Issue.csv

Actual Experience

Expected Experience
I would expect partition key 251540a0dd7541ccadac81d50807a7b0 to appear BEFORE partition key 43ea54abb79849539b3e6880982b1dce.
Additional Context
No response

@sixeyes Odd... Out of curiosity, is this the result of default sorting (when the table is first opened)? Does manually sorting the column resolve the issue?
Can you provide sample data? Our existing tests still seem to sort correctly.

@sixeyes As a workaround, you can simply turn off the Natural Sort Order setting.
Natural sort order is implemented like this:
"43ea54abb79849539b3e6880982b1dce".localeCompare("251540a0dd7541ccadac81d50807a7b0", undefined, { numeric: true })
// Returns -1

Default sort order is implemented like this:
"43ea54abb79849539b3e6880982b1dce".localeCompare("251540a0dd7541ccadac81d50807a7b0", undefined, { numeric: false })
// Returns 1

The unexpected result from numeric comparisons comes from the comparison function trying to parse out the largest continuation of digits and treat them as one number. This is easy to see if you insert rows with the keys 9aaa, 88aa, 777a, and 6666. Clearly, 9aaa should be last, but with natural sort order turned on, it actually comes first.
Natural sort order was added primarily for blob users who wanted blobs to be sorted not purely by ASCII or Unicode characters:

Unexpected char-based order
Expected numeric order

blob19
blob2

blob2
blob19

blob321
blob321

A universal setting for natural sort order is not suitable for all columns. We can consider a more granular approach.

@sixeyes Odd... Out of curiosity, is this the result of default sorting (when the table is first opened)? Does manually sorting the column resolve the issue?

This is the order, regardless of when it's done. Reverse sorting Partition Key has the same sort order (but in reverse)


python3Packages.pytorch-lightning: fix build, add deps

Description of changes
adds missing propagatedBuildInputs
pydeprecate: init at 0.3.1
torchmetrics: init at 0.7.3

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

cc @bcdarwin, this PR would be up your alley. I should have noted above, the current build for pytorch-lightning is broken and fails due to missing dependencies pyDeprecate, torchmetrics, and fsspec, the first two of those needed to be added to nixpkgs.

editorconfig error seems spurious

Fixed merge conflict (tensorflow-tensorboard got renamed to tensorboard).

Build is currently failing due to this release specifying an exact point release of setuptools -- need to either update pytorch-lightning or jailbreak setuptools in requirements.txt.

Mostly addressed by #172300 except for python3Packages.pydeprecate addition.


Optionally support Rewrite Engine, disabled by default

Therefore we have chosen to not support URL rewriting out of the box.

No, built-in rewrite support has been nixed to enable truly "zero config" installs and to maintain backwards compatibility with 2.X URLs

I do agree your willing to make the installation easy. But please, inspect my code before you deny it: I didn't break any URL compatibility and what's more, this can be controlled via .env files and defaultly it's disabled. It didn't break the "zero config" ability.
 Your code is terrible! You are totally stupid! " and let me give up instead of using an excuse like zero-config thing.

Thank you but we do not wish to add rewrite engine support at this time and it has nothing to do with you or your code.


litecross: build binutils with --enable-deterministic-archives

as proposed in #26 :
binutils' ar program defaults to creating timestamp in archives, which
breaks reproducible builds.
this misfeature can be explicitly turned off on every usage (-D), or be
disabled completely at build time using the --enable-deterministic-archives
option.
since the former requires patches for every package, having the toolchain
doing the right thing by default seems to be the much better choice.
the configure option is available since binutils 2.20, so it should be
safe to use by now.

does that look OK ?

ping

ping # 23

Merged. Sorry for the delay. Thanks, this is the obviously-right thing to do.


68 add native support for categorical variables

Slow progress on this one:

Removed CounterfactualState as this really isn't necessary.
Currently something is wrong with the latent space encoding (reconstruction error is huge)

Lots to be done before merging.

To do:

[ ] Fix issue with latent space
[ ] Fix issue with ClapROAR
[ ] Then merge progress into main

To do:

[x]  Fix issue with latent space
[x]  Fix issues with StatsBase.reconstruct to allow feature transformations
[x]  Fix issue with ClapROAR
[ ]  Then merge progress into main

Note: for decoding the state, I've tried to only map back from the latent space to avoid the issues with StatsBase. But this doesn't work, because the model was trained on untransformed features. In other words, we definitely need to fully decode the state. Will try FeatureTransforms.

Actually, in the end I've (somehow!) managed to make it work with StatsBase. I prefer to rely on StatsBase, because FeatureTransforms does not allow transformations on a per feature basis (it seems).
Final thing to do before merging:

[ ] Find a solution for how to deal with one-hot-encoded features. Rather than doing that sort of encoding here, it will be assumed that encoding has already happened at the training stage.

Have a basic version now working, where in each round categorical encodings are reconstructed. Having looked at some basic examples, though, it seems that perturbations in any single round are simply never large enough to switch the label.


Update command installs @ latest

Just want to leave this as a flag for us in the future, no action required.
This is totally fine for now, but eventually it seems like we should be respecting whatever version semver users have in their project (e.g. they are only accepting minor bumps).

Closing this as it's not an actionable or workable ticket.
Please reopen when you decide what you'd like to change for the "latest" packages update.


Remove one log bundle

I think there is no need for both log bundles.

Closing as that's on purpose.


lots of errors in newer version

I'm on version 0.1.29 of V and I'm getting lots of errors when trying to use valval.
Is there any progress on upgrading it to support a later version? Otherwise I'll give it a shot and might throw up a PR for it. Just wanna check first so I'm not doing work someone else already started.

Hi! When I first developed valval, vlang was version 0.1.24, and later I found that there were many problems with 0.1.25. Many reasons made me plan to drop support for all versions before  1.0.
My time and abilities are limited, and I hope more people like you will join us, and together we can make valval and vlang better.

I have transferred the valval project to the valvalio organization.
I hope that more people will come together to develop and maintain this project, and that the V language will be better.


Leader board issue

Why its show people who 0 points??

We should display if min. 1 PR accepted and min 1 point..


restore static linking and bump the build number

symbol conflicts were reported again in pyFFTW/pyfftw#106 after static linking was removed in #47. This PR just restores the static linking
Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.
I do have some suggestions for making it better though...
For recipe:

License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

I suspect the user has another issue. Have commented over there ( https://github.com/pyFFTW/pyFFTW/issues/106#issuecomment-1005988408 )


fasthttp support

Hello!
Is there any possibility of integration with fasthttp (https://github.com/valyala/fasthttp)?
It would be great to have such integration

I also need this integration, and if support is possible, I would like to contribute

@victorvcruz you can use fasthttp for your controllers and use net/http for listen and serve swaggo/swagg. It is work for me

newly created: https://github.com/swaggo/fasthttp-swagger


feat(olm-catalog) : Generated alm-examples in a pretty format

Description of the change:
Generated alm-examples for olm in a pretty format.
Motivation for the change:

To improve the Maintenace ability and understatement.
https://github.com/operator-framework/operator-sdk/issues/1708

Tests performed locally:

Hi @joelanford,
Really tks for your help. It is working now. Please, feel free to review.

Hi @estroz and @joelanford,
The changes requested are done. Realy tks for your review.
Please, feel free to check if all is ok and if has anything else that we should improve here.

Hi @joelanford,
Thank you for your review and help on it. The latest nits were addressed.

All latest nits addressed tks for the review and patient with 👍
c/c @joelanford @estroz

/ok-to-test

/test e2e-aws-subcommand

@camilamacedo86 thanks for the PR!


Don't work in Firefox

All work in chrome, but do not work in firefox and safari.
      {           test: /\.(svg)$/i,           loader: 'svg-sprite-loader',           options: {             extract: true,             spriteFilename: 'theme-sprite.svg',           },         }
Icon use via css https://monosnap.com/file/BVf4cJjnjD2nQDMFINCl8c3IaZYwBS
If open sprite fragment in firefox (copy link address) in separate tab all works (see svg).
Chrome print screen: https://monosnap.com/file/dVSjUtPXg82HSaFE6ZwxHrQri12iX7
Firefox print screen: https://monosnap.com/file/Rt9fhl2hYWJmqkQ1gselrBIHcQLVMx
Firefox svg: https://monosnap.com/file/dL0M6syvAf0pBTgkBBlNQMbvAoHzY6

Node.js version: 8.6.0
webpack version:  2.7.0
svg-sprite-loader version: 3.4.1
OS type & version: macos 10.13.1

Please create repo with minimal setup to demonstrate a problem (package.json, webpack config, SVG image and piece of your code). If you don't want to create a repository - you can create a gist with multiple files.


remove version <IP_ADDRESS>

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?

[x] Does your manifest conform to the 1.0 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

Is there a reason for removing the version? I see the new version has already been added, but it doesn't mean that the previous version has to be removed


How to add onLongPress to ListItem

Hello,I edited the ListItem.js in src/basic to support longpress , but it still not working when I do LongPress on ListItem. Is there any way to using longpress ? Thanks.

@Symous onLongPress support has been already added from v2.0.13.
Do check the latest versions.


Create DocMap sample for 86628 according to new steps

https://github.com/elifesciences/data-hub-issues/issues/685

Seems to generally make sense. I haven't cross-checked it with the Miro board.

I think we will need to check with bioRxiv, that it doesn't impact their process. (Maybe it would be an idea to keep the first step in, initially until they confirmed it)

I am not sure if they are using the DocMaps let me check with Scott.


Using rethinkdbdash 2.3.1, I'm getting error when opening changefeeds

The server throw this:
rethinkdb[21831]: warn: Connection attempt from [::ffff:<IP_ADDRESS>]:58622 failed, reason: unrecognized or incompatible version (local: 2.3.0, remote: 2.2.2)

Which also makes the server shutdown sometimes, but for that I opened a issue on the RethinkDB github

Nevermind, it was a older proxy causing the issue, not rethinkdbdash


Renew btn issue

The renew button had an issue and the renew function wasn't catching the value sent from the UI. The problem was the ajax call wasn't being made and the function wasn't returning anything. We fixed it by adding   $('#renewBtn').on('click', renew); to the .ready() function at the top to capture ajax call.

This issue and the solution has been moved to issue number 1257 (https://github.com/BCStudentSoftwareDevTeam/celts/pull/1258)


GAN Training Issue

Hi,
I was trying to train a super-resolution model with L1+ Adversarial Loss. The weights I set for L1 is 0.85 and Adversarial Loss is set to 0.15. Any formal way to set it?
Also, I observe as the training progresses,
The L1 loss saturates, The GAN loss increases, The Discriminator Loss decreases to a very small value.  And the validation PSNR fluctuates.  Am I doing something wrong? I think all losses should go down right?
My Super Resolution network is very small ~2000 MACs. Do I need to change the discriminator for a small SR network?

I have the same question. The L1 loss and GAN loss of generator increase dramaticlly , and the GAN loss of discriminator drops to a small value. The results are very bad. I can't figure out why the issue happens.
If you find the solution, please let me know, thanks!

My GAN loss increases while dis loss decreases,why?

Hi, how to train the model with the Adversarial Loss?
Could you give an example of the code?  Thanks

Hi, how to train the model with the Adversarial Loss?
Could you give an example of the code?  Thanks


Fix parsing of reek output for newer versions of reek

Looks like possibly on newer versions of reek (or it never worked to begin with), the output has an indent the original regex didn't account for. Now it does, also added some additional specs to cover this filename parsing.

Thanks for the fix, @piotrb!
Merged in 994fbca9dda8c1cb036d6889ec5f9eb253bda525.

Any chance of a release that includes this fix?


chore(package): update ember-cli-eslint to version 4.1.0

Closes #33

CI is 🍎 for some probably unrelated reason

superseded by #48


Fix broken links to docs in readme

Sorry, this link syntax works in readthedocs. It should be maintained.


Add citation to readme

oncethe open seeds paper is out :)

we already have a cite page, so we can link to it now :)


enumer: 1.5.8 -> 1.5.9

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/dmarkham/enumer/releases.
meta.description for enumer is: Go tool to auto generate methods for enums
meta.homepage for enumer is: https://github.com/dmarkham/enumer
Updates performed

Golang update

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.5.9 in filename of file in /nix/store/zp082p01kaanh4jcqs5vjv8r8mxmvv04-enumer-1.5.9

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
enumer

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/zp082p01kaanh4jcqs5vjv8r8mxmvv04-enumer-1.5.9 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A enumer https://github.com/r-ryantm/nixpkgs/archive/b843f75a559a91d8203e17a671bf0195cc7a599f.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/b843f75a559a91d8203e17a671bf0195cc7a599f#enumer

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/zp082p01kaanh4jcqs5vjv8r8mxmvv04-enumer-1.5.9
ls -la /nix/store/zp082p01kaanh4jcqs5vjv8r8mxmvv04-enumer-1.5.9/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

enumer

Maintainer pings
cc @mweinelt for testing.

@ofborg test evcc


Fix feature detection

This PR splits up the feature detection used in the CSS parser in two parts:

Separately detect support for scroll-timeline (by checking for animation-timeline: scroll() support)
Separately detect support for view-timeline

This will benefit browsers that land partial support, should that ever be the case.
Note that this doesn’t work in today’s Chrome Canary with the Experimental Web Platform Features enabled, as it never seems to trigger an animationstart event for animations that are linked to a view-timeline.

FYI: Rebased this branch onto master to make sure it can be merged easily.

Do we still need this? I'm curious are there any browsers planning to ship one of scroll-timeline or view-timeline but not both?

Yeah, good question. In theory it is possible, so I think it’s better to err on the safe side of things here.

Abandoning this PR after all. Giving all this some more thought, it’s highly unlikely that a vendor would implement STL but not VTL.
(The more obvious split they could make is CSS vs JS,but that’s a different story)


SUBMARINE-1180. Fix the hibernate error in server

What is this PR for?
Fix the bugs in the server.

hibernate dependency error
split interruptedexception from Exception

What type of PR is it?
[Bug Fix]
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/SUBMARINE-1180
How should this be tested?
Screenshots (if appropriate)
Questions:

Do the license files need updating? No
Are there breaking changes for older versions? No
Does this need new documentation? No

I have a question: if we use Mybatis, why do we import Hibernate?

We have discussed the database issue about half a year ago but I think it is suitable to use mybatis now. I will discuss whether to remove it in the next meeting.


[1] Refactor AI response retrieval and creation

Refactors

Extract AI response creation & retrieval logic from CreateAIReply

This will be reused in ListArticles, as it looks up transcripts and potentially creates one as AI replies.
createAIResponse creates an AI response in loading state and returns a callback . When transcript is done, calls the provided callback to update the AI response.
getAIResponse will try waiting for a loading AI Response if one exists.

refactor(graphql): extract latest AI response retrieval logic to utility

refactor(CreateAIReply): extract AI Response creation and updating to util function

coverage: 88.175% (+0.03%) from 88.141% when pulling 1501d53f31b1dbef390db481c93b8f2d26eaff74 on refactor-ai-resp into aa5e85f7a62bf8562d8aa92b39b9b6d3f1487871 on master.


[no review] [no merge] [will be closed] just for checking some issues from #1702

Description
Draft pr just for checking some issues from #1702

/intelci: run


Fix Concurrency Sample Link in README.MD

Description
This PR fixes a typo that made the link to the concurrency sample broken. It should now point to the concurrency sample for the async client.
All SDK Contribution checklist:

[ ] The pull request does not introduce [breaking changes]
[ ] CHANGELOG is updated for new features, bug fixes or other significant changes.
[ ] I have read the contribution guidelines.

General Guidelines and Best Practices

[ ] Title of the pull request is clear and informative.
[ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[ ] Pull request includes test coverage for the included changes.

API change check
API changes are not detected in this pull request.


Add API for manipulating windows/tabs

Add method for convenient creating new tabs, switching to tab and back.

Hi @asolntsev, is there a built-in method for opening a new tab?

@kenston No, nor Selenide neither Selenium has such an API.
But this idea seems strange to me. Why would you need to open a tab?
User doesn't do it. Typically a tab is opened when user clicks some element. So, your test should also click that element.

@asolntsev There are cases where we want to interact with more than two tabs at a time. We may have to interact (test) the front-end of a site, but at the same time having to interact (set-up) something on the back-end of the site (e.g., in the middle of the front-end testing) which requires opening a new tab.

I recommend to avoid using 2 tabs. More generally, avoid using UI for any
technical needs. If you need to prepare some data, change settings etc.,
please do it via API or SQL or whatever else, but not via UI. UI is only
for emulating user actions.
On Jun 2, 2016 2:36 PM, "Kenston Choi"<EMAIL_ADDRESS>wrote:

@asolntsev https://github.com/asolntsev There are cases where we want
to interact with more than two tabs at a time. We may have to interact
(test) the front-end of a site, but at the same time having to interact
(set-up) something on the back-end of the site (e.g., in the middle of the
front-end testing) which requires opening a new tab.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/codeborne/selenide/issues/72#issuecomment-223266680,
or mute the thread
https://github.com/notifications/unsubscribe/AARE3U5blL9HCytjyjqDBeTeImjQprhUks5qHsBLgaJpZM4BaQUO
.

@asolntsev Thanks for the general advice. There are still legitimate use cases where back-end (UI) testing is part of the overall testing to be carried out by testers (for back-end users) although not necessarily for front-end users. For example, I may be testing my own WordPress plugin with a setting page in the Admin backend.

@kenston Well, you may test your own WordPress plugin, but I still claim that you don't need 2 tabs for that.
The idea is still the same:

You write a separate test for the settings page.
You click elements on the settings page and verify that appropriate settings are changed in database.

You write a separate test for client side.
You change settings in database and verify that end-client sees changes in UI.


Use Expect header

When we return results to the Two Six server, the connection was being closed:
INFO: I/O exception (java.net.SocketException) caught when processing request to {s}->https://wm-ingest-pipeline-rest-1.prod.dart.worldmodelers.com:443: Connection reset by peer: socket write error
May 18, 2020 12:07:25 PM org.apache.http.impl.execchain.RetryExec execute

It turns out that this happens only for larger files, of size somewhere between 190KB which worked, and 380KB which didn't.  At some point the server won't take a files unless the client has stated that it will accept this continue header thing.  The server uses that to handshake with the client regarding whether it will accept the relatively large file.  The client can then go ahead and upload.  This behavior isn't part of the default setting for the Apacha HttpClient and needed to be added.  Thank you to the curl code which showed this header information, I think with the -D flag:
HTTP/1.1 100 Continue

HTTP/1.1 201 Created
Content-Length: 61
Content-Type: application/json;charset=utf-8
Date: Mon, 18 May 2020 19:57:20 GMT
Server: Jetty(9.4.z-SNAPSHOT)


Issue Parsing Strain URIs

In GitLab by @mweston on May 27, 2020, 10:24
Issue description
When parsing an experiment request with a list of defined strains using SynBioHub URIs, the strains do not appear to parse correctly. Instead of parsing the full URI, the URIs are seperated into "https" and the remaining part of the string, e.g.
"strains": ["https", "//hub.sd2e.org/user/sd2e/design/UWBF_6390/1", ...]
This appears to be splitting on ':'?
Steps to reproduce the issue
Run the intent-parser on the following experiment request:
https://docs.google.com/document/d/1fFcxyJyheMrzSsVoSsO6v7qHJKFf_0heIFtqEur02cg
http://intentparser.sd2e.org/document_request?1fFcxyJyheMrzSsVoSsO6v7qHJKFf_0heIFtqEur02cg
What's the expected result?
The strains would parse with the URIs preserved, e.g.
"strains": ["https://hub.sd2e.org/user/sd2e/design/UWBF_6390/1", ...]
What's the actual result?
Instead of parsing the full URI, the URIs are seperated into "https" and the remaining part of the string, e.g.
"strains": ["https", "//hub.sd2e.org/user/sd2e/design/UWBF_6390/1", ...]
Additional details / screenshot
Here is a Slack thread discussing this issue: https://sd2e.slack.com/archives/GP34M2C02/p1590587634008100
Here is the full JSON output from the intent-parser:
{
"name": "YeastSTATES 1.0 Growth Curves Request",
"experiment_id": "experiment.transcriptic.TBD",
"challenge_problem": "YEAST_STATES",
"experiment_reference": "YeastSTATES-1-0-Growth-Curves",
"experiment_reference_url": "https://docs.google.com/document/d/1fFcxyJyheMrzSsVoSsO6v7qHJKFf_0heIFtqEur02cg",
"experiment_version": 1,
"lab": "Transcriptic",
"runs": [{
"measurements": [{
"measurement_type": "PLATE_READER",
"file_type": ["CSV"],
"replicates": 6,
"strains": ["https", "//hub.sd2e.org/user/sd2e/design/UWBF_6390/1", "https", "//hub.sd2e.org/user/sd2e/design/W303/1"],
"timepoints": [{
"value": 0.0,
"unit": "hour"
}, {
"value": 1.0,
"unit": "hour"
}, {
"value": 3.0,
"unit": "hour"
}, {
"value": 6.0,
"unit": "hour"
}, {
"value": 9.0,
"unit": "hour"
}, {
"value": 12.0,
"unit": "hour"
}, {
"value": 15.0,
"unit": "hour"
}, {
"value": 18.0,
"unit": "hour"
}, {
"value": 21.0,
"unit": "hour"
}, {
"value": 24.0,
"unit": "hour"
}],
"temperatures": [{
"value": 30.0,
"unit": "celsius"
}],
"contents": [
[{
"name": {
"label": "Media",
"sbh_uri": "NO PROGRAM DICTIONARY ENTRY"
},
"value": "sc_media"
}]
]
}, {
"measurement_type": "PLATE_READER",
"file_type": ["CSV"],
"replicates": 3,
"strains": ["https", "//hub.sd2e.org/user/sd2e/design/UWBF_6389/1", "https", "//hub.sd2e.org/user/sd2e/design/UWBF_7375/1", "https", "//hub.sd2e.org/user/sd2e/design/UWBF_8225/1", "https", "//hub.sd2e.org/user/sd2e/design/UWBF_5783/1", "https", "//hub.sd2e.org/user/sd2e/design/UWBF_8545/1", "https", "//hub.sd2e.org/user/sd2e/design/UWBF_16970/1", "https", "//hub.sd2e.org/user/sd2e/design/UWBF_16968/1", "https", "//hub.sd2e.org/user/sd2e/design/UWBF_8231/1", "https", "//hub.sd2e.org/user/sd2e/design/UWBF_6391/1", "https", "//hub.sd2e.org/user/sd2e/design/UWBF_5992/1", "https", "//hub.sd2e.org/user/sd2e/design/UWBF_16967/1", "https", "//hub.sd2e.org/user/sd2e/design/UWBF_7373/1", "https", "//hub.sd2e.org/user/sd2e/design/UWBF_8543/1", "https", "//hub.sd2e.org/user/sd2e/design/UWBF_7377/1", "https", "//hub.sd2e.org/user/sd2e/design/UWBF_6388/1", "https", "//hub.sd2e.org/user/sd2e/design/UWBF_5993/1", "https", "//hub.sd2e.org/user/sd2e/design/UWBF_16969/1", "https", "//hub.sd2e.org/user/sd2e/design/UWBF_7376/1", "https", "//hub.sd2e.org/user/sd2e/design/UWBF_8544/1", "https", "//hub.sd2e.org/user/sd2e/design/UWBF_7300/1", "https", "//hub.sd2e.org/user/sd2e/design/UWBF_7374/1", "https", "//hub.sd2e.org/user/sd2e/design/UWBF_8542/1", "https", "//hub.sd2e.org/user/sd2e/design/UWBF_7299/1"],
"timepoints": [{
"value": 0.0,
"unit": "hour"
}, {
"value": 1.0,
"unit": "hour"
}, {
"value": 3.0,
"unit": "hour"
}, {
"value": 6.0,
"unit": "hour"
}, {
"value": 9.0,
"unit": "hour"
}, {
"value": 12.0,
"unit": "hour"
}, {
"value": 15.0,
"unit": "hour"
}, {
"value": 18.0,
"unit": "hour"
}, {
"value": 21.0,
"unit": "hour"
}, {
"value": 24.0,
"unit": "hour"
}],
"temperatures": [{
"value": 30.0,
"unit": "celsius"
}],
"contents": [
[{
"name": {
"label": "Media",
"sbh_uri": "NO PROGRAM DICTIONARY ENTRY"
},
"value": "sc_media"
}]
]
}, {
"measurement_type": "CONDITION_SPACE",
"file_type": ["CSV"],
"replicates": 20,
"strains": ["https", "//hub.sd2e.org/user/sd2e/design/UWBF_6390/1", "https", "//hub.sd2e.org/user/sd2e/design/W303/1", "https", "//hub.sd2e.org/user/sd2e/design/UWBF_8545/1", "https", "//hub.sd2e.org/user/sd2e/design/UWBF_16970/1", "https", "//hub.sd2e.org/user/sd2e/design/UWBF_16968/1", "https", "//hub.sd2e.org/user/sd2e/design/UWBF_8231/1", "https", "//hub.sd2e.org/user/sd2e/design/UWBF_6391/1", "https", "//hub.sd2e.org/user/sd2e/design/UWBF_5992/1", "https", "//hub.sd2e.org/user/sd2e/design/UWBF_16967/1", "https", "//hub.sd2e.org/user/sd2e/design/UWBF_7373/1", "https", "//hub.sd2e.org/user/sd2e/design/UWBF_8543/1", "https", "//hub.sd2e.org/user/sd2e/design/UWBF_7377/1", "https", "//hub.sd2e.org/user/sd2e/design/UWBF_6388/1", "https", "//hub.sd2e.org/user/sd2e/design/UWBF_5993/1", "https", "//hub.sd2e.org/user/sd2e/design/UWBF_16969/1", "https", "//hub.sd2e.org/user/sd2e/design/UWBF_7376/1", "https", "//hub.sd2e.org/user/sd2e/design/UWBF_8544/1", "https", "//hub.sd2e.org/user/sd2e/design/UWBF_7300/1", "https", "//hub.sd2e.org/user/sd2e/design/UWBF_7374/1", "https", "//hub.sd2e.org/user/sd2e/design/UWBF_8542/1", "https", "//hub.sd2e.org/user/sd2e/design/UWBF_7299/1"],
"timepoints": [{
"value": 0.0,
"unit": "hour"
}, {
"value": 24.0,
"unit": "hour"
}],
"temperatures": [{
"value": 0.0,
"unit": "celsius"
}, {
"value": 35.0,
"unit": "celsius"
}],
"contents": [
[{
"name": {
"label": "Media",
"sbh_uri": "NO PROGRAM DICTIONARY ENTRY"
},
"value": "sc_media"
}]
]
}]
}],
"doc_revision_id": "242",
"parameters": [{
"inoc_info.inoc_vol": "10:microliter",
"inoc_info.inoc_media_vol": "700:microliter",
"inoc_info.inc_time_1": "16:hour",
"inoc_info.inoculation_media": "sc_media",
"incubation_info.shaking": "high_speed",
"recovery_info.recovery_sample_vol": "50:microliter",
"recovery_info.recovery_media_vol": "1000:microliter",
"induction_info.induction_time.total_induction_time": "8:hour",
"induction_info.induction_time.doubling_time": "2:hour",
"induction_info.dil_volume": "1700:microliter",
"induction_info.induction_reagents.media_vol": "300:microliter",
"induction_info.induction_time.induction_plate_info": "new-induction-plate",
"read_info.sampling_info.read_cult_vol": "300:microliter",
"plate_reader_info.fluor_ex": "488:nanometer",
"plate_reader_info.fluor_em": "530:nanometer",
"plate_reader_info.gain": 0.16
}]
}

In GitLab by @tramyn on May 27, 2020, 14:35
@mweston, this issue was introduced because colons : are used as separators to parse information from a lab table. If we want to fully resolve this issue, I will need clarifications on how strains should be parsed.
Intent parser currently reads in strains as strings. However, the data catalog schema allow strains to be represented as a string or a url. Do you plan on changing the data catalog to represent both? So for example, if a user decides to specify AND_00 as a strain and link this strain to https://hub.sd2e.org/user/sd2e/design/UWBF_7376/1, what would you like intent parser to generate from this input?

In GitLab by @mweston on May 28, 2020, 12:57
@tramyn Sure, per the schema strains can be either a common name, like UWBF_7376 or a synbiohub URI, e.g. https://hub.sd2e.org/user/sd2e/design/UWBF_7376/1. Both are strings.
So the desired intent parser output here is either a common name string or a SBH URI string (both are acceptable). The colon separation looks to be accidental or an unintended side effect - we've never delimited strains this way.

In GitLab by @tramyn on May 28, 2020, 13:52
@mweston Yes, I agree that parsing a string with a colon is a bug produced from intent parser. I can modify the way strings are parsed from intent parser to interpret URIs but there is another issue that isn't clear to me how intent parser should handle. For the example above where AND_00 is provided, what is  intent parser's expected return value here? Is it AND_00 or its URI? The problem that I am expressing in this case, is if you want intent parser to always prefer returning strings over linked terms for strains? What happen when a user decides to provide both a string with a URI? What should intent parser generate under this condition?
The table below show examples that illustrates this problem. The left column defines user input for strains and the right column defines intent parser's output.

Input Strain
Output from IP

AND_00
AND_00

https://hub.sd2e.org/user/sd2e/design/UWBF_7376/1
https://hub.sd2e.org/user/sd2e/design/UWBF_7376/1

https://hub.sd2e.org/user/sd2e/design/UWBF_7376/1
https://hub.sd2e.org/user/sd2e/design/UWBF_7376/1

AND_00
?

https://hub.sd2e.org/user/sd2e/design/UWBF_7376/1
https://hub.sd2e.org/user/sd2e/design/UWBF_7376/1 or www.foo.com?

Clarification that I need from you is shown on the last 2 rows. What would intent parser return on the 4th row for a linked AND_00 strain? Should IP return the string AND_00 or its linked URI https://hub.sd2e.org/user/sd2e/design/UWBF_7376/1.
Also, the example shown on the 5th row represents a URI represented as a string https://hub.sd2e.org/user/sd2e/design/UWBF_7376/1. This URI has a link term that refers to www.foo.com. For this example, should IP return https://hub.sd2e.org/user/sd2e/design/UWBF_7376/1 or www.foo.com?

In GitLab by @mweston on May 28, 2020, 13:58
@tramyn I see the discrepancy, thanks for raising it. We should do the following:

If the user provides a string (no link): Pass this through.
If the user provides string that is linked to a target: Pass the link target through. You can ignore whatever text they provided. For your row 3 and 4 this is https://hub.sd2e.org/user/sd2e/design/UWBF_7376/1 and https://gitlab.sd2e.org/sd2program/experimental-intent parser/develop/www.foo.com respectively.

The latter example is obviously incorrect, but I don't think it's worth investing in additional validation here. This will add additional requirements and work to the intent-parser. We'll resolve this downstream.

In GitLab by @tramyn on May 28, 2020, 14:24
@mweston Sounds good. I'll resolve this issue in 2 releases. The first release will support this condition (If the user provides a string (no link): Pass this through.). This will resolve your current situation with parsing strains. This shouldn't take much time to fix and I can get it up and running by the end of today or early tomorrow morning. I'll ping you when this first release is up and running.
The second release will occur in 2.6. This release will address this condition (If the user provides string that is linked to a target: Pass the link target through. You can ignore whatever text they provided).

In GitLab by @tramyn on May 28, 2020, 14:44
mentioned in merge request !116

In GitLab by @tramyn on May 28, 2020, 14:44
created merge request !116 to address this issue

In GitLab by @tramyn on May 28, 2020, 19:32
@mweston I have a new release running on http://intentparser2.sd2e.org. This release should address intent parser's issue with reading strains specified as a URI.
I can go ahead and update the production server http://intentparser.sd2e.org. But before I do, let me know when you are okay with me stopping the production server for a minute to update the new release. It looks like there are a couple of requests performed on IP so I don't want to stop these tasks unless it is safe to do so.

In GitLab by @mweston on May 28, 2020, 19:50
@tramyn Thanks. Can you clarify? Pending requests that are still processing?

In GitLab by @mweston on May 28, 2020, 19:53
@tramyn the document parsed by http://intentparser2.sd2e.org looks correct.

In GitLab by @tramyn on May 28, 2020, 19:59
@mweston Great. 'http://intentparser.sd2e.org' is updated with a new build.

In GitLab by @tramyn on Jun 8, 2020, 19:22
closed via merge request !116

In GitLab by @tramyn on Jun 8, 2020, 19:22
mentioned in commit bdc86548c6cbc3f0c062abff6233ae1d8e365b3b

In GitLab by @tramyn on Jun 12, 2020, 18:58
mentioned in commit e02a22a851b51fc4542e96d1ec74bb162824d512


Adding strong-mode: true to .analysis_options while running causes weirdness with generic methods

Reproduction steps:

Use someIterable.map in a way that requires type information and where the generic type can be inferred.
Add strong-mode: true to .analysis_options in a running IntelliJ instance

Expected: no errors. Either the new option isn't honored (until restart) or strong mode goes clean
Actual: get a warning about Iterable<dynamic> is not Iterable<SomeType>
Thoughts from @leafpetersen – the SDK libs are not refreshed with the generic info (without a restart)
Dart version: Dart VM version: 1.15.0-dev.4.0

Edited your comment so the <...> show up.  The error is what I would expect to see if the definition of Iterable.map is not being parsed in strong mode (i.e. the generic annotation is not being picked up), but then the application of Iterable.map is being checked in strong mode.  Hence my hypothesis that the SDK context isn't getting rebuilt appropriately.

I'm assuming this has been fixed by now.


cmd/go/internal/list: Wildcard expansion inside testdata does not work

What version of Go are you using (go version)?

$ go version
go version go1.14 linux/amd64

Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/tbe/.cache/go-build"
GOENV="/home/tbe/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/tbe/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/x86_64-pc-linux-gnu/lib/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/x86_64-pc-linux-gnu/lib/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
AR="ar"
CC="x86_64-pc-linux-gnu-cc"
CXX="x86_64-pc-linux-gnu-c++"
CGO_ENABLED="1"
GOMOD="/home/tbe/repos/go/packagesTest/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="x86_64-pc-linux-gnu-pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build133136046=/tmp/go-build -gno-record-gcc-switches"

What did you do?
$ go list k8s.io/gengo...
k8s.io/gengo/args
k8s.io/gengo/examples/deepcopy-gen
k8s.io/gengo/examples/deepcopy-gen/generators
k8s.io/gengo/examples/deepcopy-gen/output_tests
[...]
$ go list k8s.io/gengo/testdata/a
k8s.io/gengo/testdata/a
$ go list k8s.io/gengo/testdata/a...
go: warning: "k8s.io/gengo/testdata/a..." matched no packages
$ go list k8s.io/gengo/testdata/a/b
k8s.io/gengo/testdata/a/b

What did you expect to see?
$ go list k8s.io/gengo/testdata/a...
k8s.io/gengo/testdata/a
k8s.io/gengo/testdata/a/b

What did you see instead?
see above
While it is a wanted behavior, that testdata is excluded from wildcard lists, i't seems rather counter-intuitive, that wildcard expansion inside testdata does not work.

@bcmills @matloob @jayconrod

Per go help packages:

Directory and file names that begin with "." or "_" are ignored by the go tool, as are directories named "testdata".

Note that the documentation refers to directories, not suffixes or subdirectories.
Could you explain more about the use-case here? (Why do you need to list testdata packages using a wildcard?)

During development of a package that makes use of x/tools/go/packages, I hit this issue, as we are not able to build useful tests.
I understand that testdata is ignored, but we try listing inside testdata
Am 16. April 2020 22:56:02 MESZ schrieb "Bryan C. Mills"<EMAIL_ADDRESS>
Per go help packages:

Directory and file names that begin with "." or "_" are ignored by
the go tool, as are directories named "testdata".

Note that the documentation refers to directories, not suffixes or
subdirectories.
Could you explain more about the use-case here? (Why do you need to
list testdata packages using a wildcard?)
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
https://github.com/golang/go/issues/38470#issuecomment-614890646

--
Diese Nachricht wurde von meinem Android-Gerät mit K-9 Mail gesendet.


Add changelog for v4.9.4

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.98%. Comparing base (6bc9b39) to head (a373ee6).
Report is 53 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1429      +/-   ##
==========================================
+ Coverage   93.94%   93.98%   +0.03%
==========================================
  Files         221      221
  Lines       21283    21332      +49
==========================================
+ Hits        19995    20048      +53
+ Misses       1288     1284       -4

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚨 Try these New Features:

Flaky Tests Detection - Detect and resolve failed and flaky tests


Fix #14 Download button for attachments

Should be able to download file now :)
For https://bbp-nexus.epfl.ch/staging/explorer/sandbox/test5e31122f734447d38c57/person/v0.1.1/fd04e128-3c9d-41b9-b2c1-5bcea2bfe6b0:

Media Type is empty because originalFileName is file, which doesn't have an extension and Media Type is based on the file extension.
File is downloaded with txt extension because of https://github.com/eligrey/FileSaver.js ...
txt extension can be renamed to .png to view the file properly (image below)

Dear Wei Quan,
First of all, thank you very much for your contribution to making Blue Brain Nexus and it's ecosystem better, we really appreciate it.
Now as to the merging of your pull request, I just want you to know that we are in the process deciding how to formerly handle external contributions and as such we cannot yet include your contributions. Rest assured that we are making all possible speed to get this settled.
We will be in touch as soon as possible.
Thanks again
Samuel

Already fixed elsewhere


Feature/implement history filter

Main functionality to resolve #233 :
Sticky header for field titles and filter
Support for both in string filter matches and regular expressions
Filtered/total message count awareness
Bug fix for document.getElementById error when no messages are visible with filter when targeting last message element as new messages load

Thanks for this :) Will review as soon as I get a chance...

Let me know. I had pushed and opened PR to the private repo before the multi-tab support got merged to develop and repo switched. After that got merged and merging into my fork i wasn't seeing history messages being dispatched at all, and haven't confirmed yet if it was an issue w/ my environment or something about the merge.
Will try to get some time into it this weekend to troubleshoot further. Also want to start looking at tests around the API for verifying these kinds of things.

@psiinon Yup! Will make those changes and I did want to reduce the font size and add a draggable bar to let the user manage visibility based on personal preference. 👍

We should probably have a 'global' control to manage font size, as this is something that should apply to all tools.

I quite like the hidden messages counter ;)

Gonna make those changes today. I actually took the hidden messages concept from Firefox Console tab filter 😄

@thc202 Sure! Can you clarify where you'd like to see that?  The description on this PR or is there somewhere else you'd like this documented?

In CHANGELOG.md, worth rebase/merge the latest changes to avoid conflicts.

Do we have notes somewhere about how to use the changelog? this is new to me.


Persistent extremely loud clicking noise when opening on linux

I built the program on arch linux using the latest sdl2 and sdl2_image. Everything built fine; no warnings or anything. The program itself runs great, there doesn't seem to be any issues. However, there is a persistent, extremely loud clicking playing constantly, no matter what file I load. It starts as soon as the program starts, and whether I do a new deck or load a file or anything, the sound plays continuously. Other sounds within the program work, they just play alongside the presumably) max volume clicking sound.
I opened the waveform in audacity and this is what it looks like:

Here's the sound file if you're interested:
out.zip
If you need more information, please let me know. I might try to reproduce the issue on other hardware and distros if possible. I used the latest build as of the time of writing (I just cloned it an hour or two ago).

Off the top of my head this sounds like signed/unsigned conversion shenanigans somewhere in the audio pump highlighting differences in behavior between clang and gcc.
This looks rather suspicious to me:
https://github.com/JohnEarnest/Decker/blob/2fff47e4e70782685de6acc530d4f9ffcebecda8/c/decker.c#L3047-L3048
I think it would be more correct to do something like
int b=(signed char)audio_slots[z].clip->sv[audio_slots[z].sample];

I'm sorry, that didn't seem to work. I made the change and very carefully checked it 3 times, and cleaned/built it twice to make sure. I can try other things if you'd like. Just to be clear: I replaced the two lines given with the one line as shown.

I went ahead and looked a little closer at the waveform and found that it's not quite one blip, it's spread out. I don't know if this is FFT stuff or whatever, or some kind of post processing. I'm not super familiar with audio.

I compiled with clang rather than gcc and the sound clicking persisted. I tried both versions; the original and the suggested change. The versions of the SDL libraries I'm using are:
SDL2: 2.30.0-1 (released 3 weeks ago, see https://github.com/libsdl-org/SDL/releases/tag/release-2.30.0)
SDL2_Image: 2.8.2-2 (released January 1, see https://github.com/libsdl-org/SDL_image/releases/tag/release-2.8.2)
Sorry for all the messages, just hoping it helps

I removed the body of n_play and sfx_install and the clicking persists. I verified that the sound system was basically non-functional by opening decks with sounds (or just trying to play sounds from the menu). Strangely though, removing the body of sfx_pump also appears to do nothing. I'm wondering if perhaps this is just a glitch with SDL with my particular hardware. I'll try building this on some other hardware when I can. It should be noted that running with --no-sound does indeed remove the clicking.

Hm I think you're right about a regression.
I tried it on another arch system, completely different hardware, and it still made the clicking. I tried swapping the audio hardware to use an external device and it still did it. But when I tried on ubuntu using sdl 2.0.20 (the version available on the system I'm using) there were no clicks.
I tested out a very basic example program that only creates an audio context and should (theoretically) play silence for 5 seconds. It also clicks on the arch systems, so this is either a bug in SDL or perhaps an invalid configuration. I noticed that the clicks in my example program don't happen unless I set the format to AUDIO_S8. I'll go look around at the documentation to see if there's anything mentioning something about this, then I'll make an issue on SDL if not.
Thank you for your suggestions! I understand if you want to close the issue, but I'd really like to wait until I've looked over the documentation on the slim chance that this isn't a bug on their end. Up to you of course.

Let's definitely keep this issue open until we're certain it's entirely an SDL problem.

The code mentioned previously is:
#include <SDL.h>
#include <SDL_image.h>

void audio_callback(void *userdata, Uint8 *stream, int len) {
    // Fill the audio stream with zeros
    memset(stream, 0, len);
}

int main() {
    // Initialize SDL
    if (SDL_Init(SDL_INIT_AUDIO) < 0) {
        // Handle initialization error
        return -1;
    }

    // Set the audio format
    SDL_AudioSpec audio_spec;
    audio_spec.freq = 8000;
    audio_spec.format = AUDIO_S8; //AUDIO_S16SYS;
    audio_spec.channels = 2;
    audio_spec.samples = 1024;
    audio_spec.callback = audio_callback;

    // Open the audio device
    if (SDL_OpenAudio(&audio_spec, NULL) < 0) {
        // Handle audio device opening error
        return -1;
    }

    // Start playing audio
    SDL_PauseAudio(0);

    // Wait for some time (or perform other tasks)
    SDL_Delay(5000); // Wait for 5 seconds

    // Pause audio playback
    SDL_PauseAudio(1);

    // Keep the audio device open but stop playback
    // The audio_callback function will continue to fill the stream with zeros

    // Wait for user input or perform other cleanup tasks
    // ...

    // Close the audio device and quit SDL
    SDL_CloseAudio();
    SDL_Quit();

    return 0;
}

Built with gcc $(sdl2-config --cflags --libs) -lSDL2_image main.c (it doesn't matter if I use gcc or clang). I included the image library just to make it as similar as possible, though I assume none of it is used. I tried it without the image library and it's still the same.

I've done some testing and research on various examples and past issues, including looking for examples that are supposed to work with specifically 2.30. According to the examples, they didn't change anything, and I'm not seeing anything we could be doing wrong, either with Decker or the super small example program. I've created an issue on SDL, though it might be an arch-specific issue. I built SDL 2.30 from source and tried that and it still produces the clicking on the simple program. Hopefully we'll see what happens, but I don't think Decker is doing anything wrong: https://github.com/libsdl-org/SDL/issues/9099

I think it's safe to close this. Thanks for your help in identifying and tracking down this issue, @randomouscrap98!


pflag: explicit replace

Pull Request Test Coverage Report for Build<PHONE_NUMBER>7
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 38.819%

Totals

Change from base Build<PHONE_NUMBER>6:
0.0%

Covered Lines:
434

Relevant Lines:
1118

💛  - Coveralls


Anomaly detection alarms

Newer to monitoring in AWS and I'm tasked with setting up anomaly detection alerts. I'm not quite understanding how to use this for the anomaly detection alarms. How can this be used using a standard deviation calculation and only alert us when something is "out of band?" I know how to do this in the AWS console but wondering how I would do that with this repo. Thanks.
Great repo btw.

This particular repository, as far as I can read, is only intended to use anomaly detection type alarms for the “out of band” case. You can create a fork to generate the proposal for the use case that you say you need.
cc. @knizami @nizamik
Recommendation: Close the case.


Fixes 1435: Document getting the data form uploaded zip/url

Fixes #1435 which is part 1 of #1433

@rohanagarwal94 I think it would be better to upload image on this issue and link it in the markdown as it will not increase the size of repo

@iamareebjamal I have infact referenced the image from the cloud itself. Its just that I have uploaded the image like any other screenshots in the screenshots folder.

@rohanagarwal94 Yes, I noticed, but images being binary files always increase the size of repo monotonically, so IMO they should be avoided as updating the image in future by replacing it will not decrease the repo size. As you can notice that many screenshots in the folder are stale and not referenced in any documentation.

Please resolve conflicts and add image inside repository. Let's avoid long discussions for a few kilobytes.

@iamareebjamal @mariobehling closing this. Please refer #1459.


GGUF not working with aidock comfyui template

I have also posted this on the ai dock github but havent gotten a response yet. I have tried many things to run a GGUF model but no matter what i do comfyui can not detect it. It can't detect the clip either. I've put the checkpoint and clip in the right place, downloaded the GGUF node, did what the github instructions said to do but it still cannot detect a GGUF. Regular flux dev and schnell work just fine, GGUF doesnt. This is on vast ai. Is there any chance you or anyone has a docker that works with GGUF?

did you find out what the issue was? GGUF models not showing up after i add them to unet folder

@ibadmore yes lol in my case it was because the file was named in random numbers instead of the actual name which is whatevertheactualnameis.safetensors


Re-add timestamp definition

A few months ago the timestamp definition was moved to a separate file. Here I've added it back in because our system is not able to reach out to the web to use the schema. I'm not sure if the validation library I'm using is able to load and validate against multiple schema files at once, but thought I'd propose this as this is what we're currently going forward with.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Sorry, I'm not sure how the indentation changed.

Hi @allink28,
I did this because the timestamp property should only be defined once throughout the schemas.  I'm not sure what the issue is with you reaching out to the web for it, but maybe it is something you should do locally?

Closing this because significant time has passed without signing the CLA nor responding to Rich's comments.


Swift Package Manager: nanopb deployment target warning

Environment

Xcode version: Xcode 12 beta 6
Firebase SDK version: 6.32-spm-beta
Firebase Component: Analytics
Installation method: Swift Package Manager

Problem
Firebase is dependent on the nanopb framework. This dependency shows the following warning in Xcode 12 beta 6 when integrating Firebase Analytics using Swift Package Manager:
The iOS Simulator deployment target 'IPHONEOS_DEPLOYMENT_TARGET' is set to 8.0, but the range of supported deployment target versions is 9.0 to 14.0.99.

Steps to reproduce:

Integrate the Firebase Analytics SDK into a new project following the documentation for Firebase Swift Package Manager support
Observe that there is a new warning related to the nanopb framework when building the project

Thanks for the report. This is also a problem for other Firebase dependencies that support iOS 8 and earlier as well. I started a discussion at https://forums.swift.org/t/minimum-ios-version-xcode-12-and-build-warnings/40224 to explore solutions.

https://github.com/nanopb/nanopb/pull/585 is sent for nanopb. We'll follow up with the other dependency updates and updates to the Firebase Package.swift in the next week or so.


1.13.1 support

Please test the latest dev build from here https://ci.lucko.me/job/LuckPerms/
If it does not work, please provide your full latest.log in paste service such as gist.github.com

Hello RJHaytree,
I've tried the build 4.2.82. The server loads, but when I do /lp editor it freezes and gives me errors.
Please find in attachment the latest log file.
Hope it can help.
latest.log

@Wyzcraft Different issue, should be fixed now


Import in eclipse is impossible

Please could you create a branch to import the project in eclipse ?
Nice job ;)
Thanks,

hi I am facing the same issue

Is there any reason you can't switch to gradle and/or android studio...?

is it possible to covert this build for eclipse ?


Code coverage for asserts

I love this framework and want to use it in our professional projects. For this I have to verify it, which involves code coverage measurements.
I was measuring coverage via running the tests shipped with the framework. I got quite nice results, but found some uncovered branches, which I think are tested.
For example:
UtestShell::assertCstrEqual
...
    if (actual == 0 || expected == 0)
    {
        failWith (StringEqualFailure (this, fileName, lineNumber, expected, actual), testTerminator);
    }

this failWith is never called, although tests are targeting this check, see:
TEST(TestFailure, StringsEqualFailureWithNullAsActual)
TestFailureTest.cpp, line 173
If I write a test, by calling STRCMP_EQUAL("ok", NULL), which fails, because of actual = NULL, then the aforementioned branch gets covered.
Same issue with assertCstrNoCaseEqual, assertCstrContains, assertCstrNoCaseContains.
Is it possible that in similar cases an overwritten method gets called, and not the original assertCstrEqual?

If I'm reading things right, the tests in the TestFailure group should never reach that failWith function anyways, I think it's supposed to be tested by the UnitTestMacros group in TestUTestMacro.cpp.  That said, it looks like there aren't any tests for the failure behavior of the STRCMP_EQUAL macro.

I started writing some tests for this. Interestingly, STRCMP(NULL, NULL) passes. One might argue that it should fail, since neither side is a c-string? But then, they are equal as pointers, indeed :P...

C:/CppUTest//tests/TestUTestMacro.cpp:136: error: Failure in TEST(UnitTestMacros, FailureWithSTRCMP_CONTAINSAndExpec
        actual <
Generic:1: error: Failure in TEST(Generic, Generic)
C:/CppUtest//tests/TestUTestMacro.cpp:130: error:
        actual <ok>
        did not contain  <>

.
Errors (1 failures, 1 tests, 1 ran, 1 checks, 0 ignored, 0 filtered out, 0 ms)
...
 - 31 ms

This looks like "ok" did not contain the empty string (which it should). In reality, "expected" was NULL. Comments?

C:/data/00_Dev/05_CppUTest/cpputest/tests/TestUTestMacro.cpp:218: error:
        expected <1 (0x1) 0x1>
        but was  <0 (0x0) 0x0>

What is the point of displaying the hex value twice?

Sometimes after a call to FailWith, the final line is covered, as in
      511:  339:void UtestShell::assertTrueText(bool condition, const char *checkString, const char *conditionString, const char* text, const char *fileName, int lineNumber, const TestTerminator& testTerminator)
        -:  340:{
      511:  341:    getTestResult()->countCheck();
      511:  342:    if (!condition)
       18:  343:        failWith(CheckFailure(this, fileName, lineNumber, checkString, conditionString, text), testTerminator);
      501:  344:}

Other times, however, it is not:
       32:  346:void UtestShell::fail(const char *text, const char* fileName, int lineNumber, const TestTerminator& testTerminator)
        -:  347:{
       32:  348:    getTestResult()->countCheck();
       60:  349:    failWith(FailFailure(this, fileName, lineNumber, text), testTerminator);
    #####:  350:}

Why?

Oh, never mind. It can get covered when there's a condition inside, so there are tests for which no failure occured.

Currently killing myself trying to get rid of -O2 in the coverage run...
Where do the other 13500 lines in configure come from, that don't have a counterpart in the 500 lines of configure.ac? Specifically, where does the code come from that set CFLAGS to "-g -O2" (or not)?
Help would be much appreciated. A coverage run really shouldn't be optimized. This makes for very confusing stuff in the .gcov files.

-g -O2 is default when you do not set a CFLAGS or not pass it to automake.

Oookay. Where in configure.ac would I specify that I want otherwise, just when the coverage option is specified?

Easiest is probably to add it to the call of configure. Just add CFLAGS= to there

Sounds good to me -- I don't like messing with configue.ac ;-)

I believe I fixed this?

I think this can be closed. I worked a lot on getting all of CppUTest covered, and used LCOV exclusion in the few places that can't possibly covered (e.g. a return after a FailWith() ).


DIone PPP

fixes #238

Codecov Report

Merging #239 (31b113e) into master (02be39e) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #239   +/-   ##
=========================================
  Coverage     67.94%   67.94%
  Complexity      821      821
=========================================
  Files           121      121
  Lines          3010     3010
  Branches        436      436
=========================================
  Hits           2045     2045
  Misses          784      784
  Partials        181      181

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more


Browser Steps - Support for <select>

Closes #1224

Any plans for this getting merged? Curious to try out if it has been fixed :)

Any update on this?

@dgtlmoon I'd love to hear any updates on this, if possible

Any updates on this?


Invite instructor and TA to repo

I didn't get an invitation?

sir you seem as a collaborator

@ahmetcandiroglu Are you sure? How come I cannot change assignments, etc. Limited access?

@ugurdogrusoz I guess it automatically gave you limited access. You now have admin rights


Allow for LiveKernels to be detected and added / removed as NotebookControllers

Looks like this is an actual functional issue that might take a bit of work.
When we connect to the remote machine we add our notebook kernels for installed kernels. But we also look for live running kernels. This test does the following:
Starts server
Starts a kernel with a document
Closes the document
Re-opens the document
Connects to the kernel that was previously left running
Runs a cell
But right now we only add NotebookControllers at first document open in the remote case.
There is a basic solution here, where on document open we just run our kernel finder again and addin anything missing from last time we ran it. This should pick up the new running kernels. However I did think that there might be an issue with the VS Code controller API where .dispose wouldn't remove a controller from the list. Will investigate.

When this work is done must turn back on and verify the test:
"Use same kernel when re-opening notebook"
I've also put this issue in a comment in the code.

Validated


feat: Custom Action Sample

Description

Create a custom action sample: here are the details:

add two parts in the runtime, add a new custom dialog called Multiply, register it in the startup.cs.
create a custom action sample, which includes the custom action schema and one sample dialog which uses the custom action.

How to run this sample:

create new bot from CustomAction sample.
start the bot and test it in emulator then it works.

Note: in a real user case, user need to first eject the runtime, do the customization and put the schema file under the ejected bot runtime folder and run update.cmd in the runtime/azurewebapp/schemas to regenerate the sdk.schema, I just run this step offline and directly put the new generated schema to the sample's schema folder. we should explain the details in the doc.
Task Item
fixes #2824

Screenshots

If we want to keep the custom schema "custom", we need keep two versions of schema in composer:

composer/packages/server/schemas/sdk.schema, this is our default schema and should not include custom schema.
runtime/azurewebapp/schemas/sdk.schema. this is default+custom schema.

which means, every time we update the sdk package+schema, we need to keep in mind to do twice of the schema merge for the above two, which doesn't look good for me.
So my hacky way is to put custom schema in the sample folder and when ejection you can customize you sdk.schema by rerun the dialog:merge.
I think both way are not perfect, how about we just explain how to use it in documents. I am not sure providing a single click experience on custom schema is a good direction which will make user confused.  ("I don't need to do anything to enable custom schema"?)
@srinaath is working on a readme to explain how to enable this. we can decide whether that is enough for user. if adding this sample just introduces more confusion, let's close this.
@cwhitten @benbrown  thoughts?

I prefer to let user know how to merge the sdk.schema instead of just give them the customized sdk.schema as if user really use this feature later, he need to know how to do the schema merge.
So until we have the UX trade off to implement this step later, we just provide the readme file(manual step) to user.
For custom schema, there are 2 steps.

custom runtime (self-contained now)

The customized runtime can be set up through the ejection
User can learn from this sample for how to write a customized code and also how to register the customized code into startup.cs . User can easily extend it based on this sample code.

customized schema (manual for R9)

The customized schema (sample) is located in the sample folder
User need to follow readme to install bf-dialog tool and manually execute "bf dialog:merge" to get the updated sdk.schema file.

Just like we did the manual step for azure provision, if user don't follow the step, they can not make it.

@luhan2017  I used this PR to actually build my README file for adding custom actions. I think there is a lot of value in including this sample and I'm mentioning about this sample in the README too. Granted the PR does a little magic of showing the merged schema directly. But the README coupled with this sample should give a user a good idea to add custom actions.

@luhan2017 @benbrown should this be added to the functions runtime as well? If yes, we could place the dialog in the core project (/runtime/core) and then jsut reference it from the web app startup.cs and from the functions startup.cs.

IMO - yes!

To who evolved in the PR, @benbrown @benbrown @hibrenda @cwhitten @srinaath
I have removed an action sample and added a custom action project in the runtime folder. which user need to refer to it explicitly to enable it. See the details at the beginning.
@carlosscastro , if user want to enable it for azure function, he/she will need to add a project reference for azure function and add CustomActionComponentRegistration in Azurefunction/startup.cs. which I didn't explicitly add right now.

Awesome @luhan2017 .. Adding my README commits to this PR too. Once added I think we can request a rereview and merge it

README updated and update.sh script to run bfdialog tool on Mac/Win added. PR ready for rereview


allow to pass init_queries executed for each new connection

I often need to set up connection (set strict mode, set session variables etc.), so having connection pool do it for me seems handy

This repo is deprecated, as it's been inlined into Diesel. Please open a PR on the main repo. :)


Scenario outline doesn't work inside a Rule scope

I tried to make an secnario outline - it didn't work. I'm not sure whether this is relevant, but it resides inside a Rule. Looking at the matches I seems to just put the placeholder
<name of a col in the Examples table> instead of a value from the regarding table. How is this supposed to work?
This is a minimal example to reproduce the issue:
Feature
Feature: Guinea Pig
This feature was made to be abused!

  Rule: To them all

    @SomeTag
    Scenario Outline: Parse a Number
      Given the rate of rage is at least <rate of rage> feet per minute
      When the pressure of caviar is most <pressure> miles
      Then tea might help

      Examples:
        | rate of rage | pressure |
        | 1200         | 42       |
        | 2200         | 48       |
        | 3200         | 3        |

Step Definition
.given_regex(
    r"the rate of rage is at least (\d+) feet per minute",
    |world, matches, _step| {
        panic!("{}", matches[1]);
        world
    },
);

Output
Feature: Guinea Pig                                                     features/guinea_pig.feature:1:1

 Rule: To them all                                                      features/guinea_pig.feature:4:3
  Scenario: Parse a Number                                              features/guinea_pig.feature:8:5
   - Given the rate of rage is at least <rate of rage> feet per minute  features/guinea_pig.feature:9:7
     ⚡ Not yet implemented (skipped)

Changing the (\d+) to (.+) reveals:
Output
Feature: Guinea Pig                                                     features/guinea_pig.feature:1:1

 Rule: To them all                                                      features/guinea_pig.feature:4:3
  Scenario: Parse a Number                                              features/guinea_pig.feature:8:5
   ✘ Given the rate of rage is at least <rate of rage> feet per minute  features/guinea_pig.feature:9:7
———— [!] Step failed: ————————————————————————————————————————————————————————  test/cucumber.rs:111:17
  <rate of rage>
———————————————————————————————————————————————————————————————————————————————————————————————————————

The placeholder rate of rage is not replaced by an actual number from the table.

Closing in favour of https://github.com/bbqsrc/cucumber-rust/issues/64.

The fixes which claim to solve #64 are not making this work, hence I would like to have this issue reopened @bbqsrc

And I can confirm that this issue is caused by the Rule:  part. Removing it makes it work with latest master. So @bbqsrc , this indeed is not the same issue a #64 . Unfortunately I can't re open this issue, as you closed it.

Right, then it's a slightly different issue. Will reopen. :smile:
Seemingly, the next obvious step to fix this issue then is to replicate the logic under the rule handling part of the code.

Fixed in #128


request help: Getting route not found issue

We are facing route not found issue with apisix ingress controller
Development

apisix version: 2.2
OS: APISIX docker image (ubuntu)
OpenResty / Nginx version: openresty/<IP_ADDRESS>
etcd version: 3.4.8

we have also added apisix route and upstream.

Hello,
Below is the ingress configuration I used.
Upstream
apiVersion: apisix.apache.org/v1
kind: ApisixUpstream
metadata:
name: myapp
spec:
ports:

port: 80
loadbalancer:
type: chash
hashOn: header
key:

Route
apiVersion: apisix.apache.org/v1
kind: ApisixRoute
metadata:
name: myapp
spec:
rules:

host: localhost
http:
paths:

backend:
serviceName: myservice
servicePort: 80
path: /path*

A log from ingress controller says: E0222 22:24:19.709891 1 leaderelection.go:325] error retrieving resource lock default/ingress-apisix-leader: leases.coordination.k8s.io "ingress-apisix-leader" is forbidden: User "system:serviceaccount:default:apisix-view-serviceaccount" cannot get resource "leases" in API group "coordination.k8s.io" in the namespace "default"

@Bhanuji95 How did you install apisix-ingress-controller and apisix?

Hello @tokers,
we installed using docker images and followed official installation document, below are the details:
etcd: quay.io/coreos/etcd:v3.4.8
apisix-gw: apache/apisix:latest
ingress: apache/apisix-ingress-controller:0.3.0

It weird since the permission missing problem was fixed in 0.3.0.

@Bhanuji95 Could you please paste the contents of the serviceaccount apisix-view-serviceaccount.

Hello @tokers,
I am giving my serviceaccount, cluster role and role binding information here
---
kind: ServiceAccount
apiVersion: v1
metadata:
  name: apisix-view-serviceaccount
  namespace: default
secrets:
  - name: apisix-view-serviceaccount-token-hhmp4
---
kind: ClusterRoleBinding
apiVersion: rbac.authorization.k8s.io/v1
metadata:
  name: apisix-view-clusterrolebinding
subjects:
  - kind: ServiceAccount
    name: apisix-view-serviceaccount
    namespace: default
roleRef:
  apiGroup: rbac.authorization.k8s.io
  kind: ClusterRole
  name: apisix-view-clusterrole
---
kind: ClusterRole
apiVersion: rbac.authorization.k8s.io/v1
metadata:
  name: apisix-view-clusterrole
rules:
  - verbs:
      - get
      - list
      - watch
    apiGroups:
      - ''
    resources:
      - configmaps
      - endpoints
      - persistentvolumeclaims
      - pods
      - replicationcontrollers
      - replicationcontrollers/scale
      - serviceaccounts
      - services
  - verbs:
      - get
      - list
      - watch
    apiGroups:
      - ''
    resources:
      - bindings
      - events
      - limitranges
      - namespaces/status
      - pods/log
      - pods/status
      - replicationcontrollers/status
      - resourcequotas
      - resourcequotas/status
  - verbs:
      - get
      - list
      - watch
    apiGroups:
      - ''
    resources:
      - namespaces
  - verbs:
      - get
      - list
      - watch
    apiGroups:
      - apps
    resources:
      - controllerrevisions
      - daemonsets
      - deployments
      - deployments/scale
      - replicasets
      - replicasets/scale
      - statefulsets
      - statefulsets/scale
  - verbs:
      - get
      - list
      - watch
    apiGroups:
      - autoscaling
    resources:
      - horizontalpodautoscalers
  - verbs:
      - get
      - list
      - watch
    apiGroups:
      - batch
    resources:
      - cronjobs
      - jobs
  - verbs:
      - get
      - list
      - watch
    apiGroups:
      - extensions
    resources:
      - daemonsets
      - deployments
      - deployments/scale
      - ingresses
      - networkpolicies
      - replicasets
      - replicasets/scale
      - replicationcontrollers/scale
  - verbs:
      - get
      - list
      - watch
    apiGroups:
      - policy
    resources:
      - poddisruptionbudgets
  - verbs:
      - get
      - list
      - watch
    apiGroups:
      - networking.k8s.io
    resources:
      - ingresses
      - networkpolicies
  - verbs:
      - get
      - list
      - watch
    apiGroups:
      - metrics.k8s.io
    resources:
      - pods
  - verbs:
      - get
      - list
      - watch
    apiGroups:
      - apisix.apache.org
    resources:
      - apisixroutes
      - apisixupstreams
      - apisixservices

@Bhanuji95 It seems your ClusterRole is obsolete, how did you get it? Anyway, try the newest one https://github.com/apache/apisix-ingress-controller/blob/master/charts/apisix-ingress-controller/templates/rbac.yaml :)

Hello @tokers,
We have tried APISIX earlier, looks like the old ClusterRole didn't get update during re-deployment. Now we have created the role again with the latest configuration. Thanks for your help 👍

@Bhanuji95 You're welcome :).

Hi @tokers,
One more query, is it possible to integrate APISIX with AzureAD/Azure OIDC authentication?

Hi @tokers,
One more query, is it possible to integrate APISIX with AzureAD/Azure OIDC authentication?

Well, that depends on whether APISIX supports it. @spacewander @membphis

@Bhanuji95 the APISIX does not support  AzureAD/Azure OIDC authentication now. if you need it, you can create a new issue for discussion.
link: https://github.com/apache/apisix/issues

@Bhanuji95  Has the problem of not finding the route been resolved? If so, we can close this issue.

Hello @gxthrj,
Our issue is resolved now, we can close the issue.


chore: fake Grist data

This PR adds a script that was used for adding 300 fake records to a Grist table. The fake data is added to a separate table so that we can simulate the expected amount of records for development without touching the table used for gathering the actual data. For using this table in development, please change your local environment variables.
The script was executed via
NODE_ENV=development npx ts-node scripts/createFakeGristData.ts

Note that the seed script is a rather quick&dirty work and could be improved. Feel free to take a look, discard or change it. Also note that I've tried using Grist's choice list datatype. However, I couldn't find a way to fill this programmatically via their API. That's why the fake data table is currently a mirror of the production table.

[x] create script
[x] execute script
[x] add information about fake table to team (env vars)
[x] add information to README

:tada: This PR is included in version 1.0.0-rc.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Add directory input

Add a line edit for the directory where the result will be saved.
The content of this line edit can be retrieve with the method self.directory_line.text().
A switch is available to enable it or not.

Any thoughts, inputs, feedback ? Do you want me to elaborate on tee purpose of the PR ?

Did a wrong operation on the git. I'll recreate it.


Errors on datetime-explicit document

I'm getting this error on the document (admittedly there are errors within the document, but the toolchain should still not fail):
NoMethodError: undefined method `[]' for nil:NilClass
  /Users/myself/.rbenv/versions/2.4.3/lib/ruby/gems/2.4.0/gems/isodoc-0.8.10/lib/isodoc/function/terms.rb:46:in `block (2 levels) in termnote_parse'

This is caused by a NOTE inside a list item entry:
"`M`"::
the months or minutes designator, represented by the character "`M`", preceding a data element which represents the number of months or minutes in a duration expression
+
NOTE: Although "`M`" can be used to designate months or for minutes, its meaning is unambiguous in expressions because the time portion will be preceded by the time designator "`T`".

The cross-references generator for term notes expects to find notes only at the top level of term content, and not embedded in other objects such as lists. (In fact, it doesn't expect to find lists in there either.) This is taking liberties with the CSD grammar. But it should still make an effort to deal with such embedded notes, so I will look for termnotes at an arbitrary level of embedding, using ".//note".

Indeed. How does ISO DIR 2 deal with these? Thanks!

The point is that ISO DIR 2 doesn't deal with them: it does not foresee notes embedded in lists.

24.3 Numbering and subdivision
Within a given clause or subclause, notes shall be numbered sequentially. The numbering restarts at each new subdivision. A single note in a subdivision need not be numbered.

Which implies that the behaviour that (accidentally) happens right now in generic notes is correct: notes are numbered sequentially whether they are inside of lists or examples or paragraphs (but not tables!)
In fact, I've just noticed that p. 19 of the 2016 IEC/ISO DIR 2 does have notes embedded in lists, and numbers them sequentially. I'll check the grammar about making sure they're permitted.

Fixed in isodoc: made termnote_anchor_names, which gives IDs to all termnotes, search for notes as descendants of terms, not just children.


perf($q): small $q performance optimization

Only generate a new promise when then receives some non-undefined parameter

This saves a few cycles when calling when without any parameters as will resolve to a value in one step instead of two

lgtm since the a+ specs are ok with this

It seems to be a breaking change for projects that intensively use angular.mocks.$timeout service and unit testing. After this change had applied, many of our tests began crashing with

Error: No deferred tasks to be flushed

before Angular 1.4.4 we had to use $timeout.flush();  in our unit tests when working with $q.when. For now, there are no deferred tasks and $timeout.flush() crashes. It is not a big deal and can be fixed easily but imho it is worth mentioning that in the change log.

Thanks for the information. Would it be possible for you to create a
plunker so the release note would have a concrete example and the steps to
follow to make things work?

For sure, please find it here http://plnkr.co/edit/1ajOE3JEiSZvauvjct3D?p=preview
Let me know if you need further information.

@akoshelev #12705 should take care of this issue


Pkg 1768v2

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_32c5wpp85h/clone/recipe/meta.yaml:34: host_section_needs_exact_pinnings: Packages in host must have exact version pinnings, except python build tools.
ERROR: /tmp/abs_32c5wpp85h/clone/recipe/meta.yaml:35: host_section_needs_exact_pinnings: Packages in host must have exact version pinnings, except python build tools.
Errors were found

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_aangtgsmvs/clone/recipe/meta.yaml:35: host_section_needs_exact_pinnings: Packages in host must have exact version pinnings, except python build tools.
ERROR: /tmp/abs_aangtgsmvs/clone/recipe/meta.yaml:36: host_section_needs_exact_pinnings: Packages in host must have exact version pinnings, except python build tools.
Errors were found

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_b459iy2123/clone/recipe/meta.yaml:35: host_section_needs_exact_pinnings: Packages in host must have exact version pinnings, except python build tools.
ERROR: /tmp/abs_b459iy2123/clone/recipe/meta.yaml:36: host_section_needs_exact_pinnings: Packages in host must have exact version pinnings, except python build tools.
Errors were found

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_2ee0bdtyw9/clone/recipe/meta.yaml:35: host_section_needs_exact_pinnings: Packages in host must have exact version pinnings, except python build tools.
ERROR: /tmp/abs_2ee0bdtyw9/clone/recipe/meta.yaml:36: host_section_needs_exact_pinnings: Packages in host must have exact version pinnings, except python build tools.
Errors were found

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_47j8np8c5u/clone/recipe/meta.yaml:39: host_section_needs_exact_pinnings: Packages in host must have exact version pinnings, except python build tools.
ERROR: /tmp/abs_47j8np8c5u/clone/recipe/meta.yaml:40: host_section_needs_exact_pinnings: Packages in host must have exact version pinnings, except python build tools.
ERROR: /tmp/abs_47j8np8c5u/clone/recipe/meta.yaml:41: host_section_needs_exact_pinnings: Packages in host must have exact version pinnings, except python build tools.
ERROR: /tmp/abs_47j8np8c5u/clone/recipe/meta.yaml:43: host_section_needs_exact_pinnings: Packages in host must have exact version pinnings, except python build tools.
Errors were found

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_fc4kiasche/clone/recipe/meta.yaml:39: host_section_needs_exact_pinnings: Packages in host must have exact version pinnings, except python build tools.
ERROR: /tmp/abs_fc4kiasche/clone/recipe/meta.yaml:40: host_section_needs_exact_pinnings: Packages in host must have exact version pinnings, except python build tools.
ERROR: /tmp/abs_fc4kiasche/clone/recipe/meta.yaml:41: host_section_needs_exact_pinnings: Packages in host must have exact version pinnings, except python build tools.
ERROR: /tmp/abs_fc4kiasche/clone/recipe/meta.yaml:43: host_section_needs_exact_pinnings: Packages in host must have exact version pinnings, except python build tools.
Errors were found


striptags in version 3.0.0 and 3.1.0 wouldn't compile with uglify-es

If you try to compile striptags version 3.0.0 or 3.1.0 using uglify-es, it will fail with a cryptic message:
ERROR in index.js from UglifyJs
Unexpected token: name (n) [index.js:1,863]

If I downgrade to striptags version 2.xthe problem disappears. I'm not sure if this is a striptags bug, or one of the other involved packages like webpack, babel-core, uglifyjs-webpack-plugin, or uglify-es.
How to reproduce
I prepared a minimal example how to reproduce this: https://gist.github.com/apepper/d149caadacea6852623ff42325829469

Place all files of that gist in a folder. Please note, that a beta version of uglifyjs-webpack-plugin is used, which already relies on uglify-es instead of uglify-js.
File src_index.js needs to be in src/index.js, but github will not let me use / in file names.
run npm install in terminal
run npm run build in terminal

Expected
The build should finish successfully.

Hey @apepper! The README specifies that v3+ is not compatible with the master branch of uglify-js.

Note: v3+ targets ES6, and is therefore incompatible with the master branch of uglifyjs. You can either:

use babili, which supports ES6
use the harmony branch of uglifyjs
stick with the 2.x.x branch

@ericnorris I'm completly aware of the readme section. That is why, I use uglify-es instead of uglify-js. Accodring to https://www.npmjs.com/package/uglify-es :

uglify-es
A JavaScript parser, mangler/compressor and beautifier toolkit for ES6+.

So it should work with ES6.
Again I'm not 100% sure, if this is a striptags issue or one of the other involved packages like webpack, babel-core, uglifyjs-webpack-plugin, or uglify-es.
Please reconsider option this issue again.


Introduce Tailwind to replace styled-components

step by step and in the longer term. For new components or updating exsting components only.
Why?
Currently all styles are defined in {ComponentXYZ}.styles.tsx files using styled-components. It might be great for separation of concerns, but not for fast development. Let's start an experiment to see if we can speed-up UI development by using Tailwind to get rid of styling-components. It might results in faster rendering, too.

Will be an ongoing process - closing now...