Bogus assertions in ContainerParentDataMixin.detach()

ContainerParentDataMixin  assert(previousSibling != this);
previousSibling is an instance of ChildType, while "this" is an intance of ParentData.
So it can never be true?

Please add the output of flutter doctor -v and the code that allows to reproduce
and the exact and full error output.

Without additional information, we are unfortunately not sure how to resolve this issue. We are therefore reluctantly going to close this bug for now. Please don't hesitate to comment on the bug if you have any more information for us; we will reopen it right away!
Thanks for your contribution.

@kgdev is right, this code is completely bogus.
@goderbauer I'm not sure how this code can ever even be running, because the very next assert is previousSiblingParentData.nextSibling == this which makes even less sense: how can the nextSibling (which is a RenderObject) ever equal this, which is a ParentData??
I don't see any reports of this assert being hit, so presumably this code is never being run. Maybe by the time we detach parentDatas, all the children have been detached first? Assuming that is indeed happening, we should decide whether to just remove this code and replace it with just assert(previousSibling == null), requiring it to happen.

Another reason to just remove this code is that it doesn't update the parent's child count.

Looks like most (all?) ContainerParentDataMixins get their sibling pointers cleared here (and the parent's count is updated correctly as well there):
https://github.com/flutter/flutter/blob/13382f41c06acca01bcfd24725ef7d6ef9d368cf/packages/flutter/lib/src/rendering/object.dart#L2990-L3012
This is called from ContainerRenderObjectMixin.remove(ChildType child) before calling RenderObject.dropChild(ChildType child). The latter then calls ContainerParentDataMixin.detach(), which has those questionable asserts in it. At that point the siblings pointers are already null and those asserts never fire.
I agree, we should just remove them and require instead in that detach that the pointers are already nulled out.


Wrong full name for active pattern case in rename dialog

When renaming an active pattern case, the full name shown in the dialog is incorrect. I have attached a screenshot that shows it.
I don't know if this is a bug in VSFPT or in the F# compiler, but I don't know how to check it either.

What is wrong with that?
I read Fo.Foo as Foo active pattern case in Fo module.

I guess I wasn't very clear. There is no Fo module. Had I tried renaming Bar the full name had read Ba.Bar.

Thanks. It's indeed a bug here.

I must say RenameDialog.fs is a complete imperative mess.

It seems active patterns always has empty DisplayName:

So our logic here does not work properly
let location =
    if fullName.EndsWith displayName then
        let locationLength = max 0 (fullName.Length - (displayName.Length + 1))
        fullName.Remove locationLength
    else fullName

Maximum we can do is to show FullName = Bar.

Fixed in https://github.com/fsprojects/VisualFSharpPowerTools/pull/944


Allow acl-template to be applied to multi-authorities

Implemented the apply acl-template to multi-authority (comma separated list of authorities) feature.
If the authorityResolver returns a list like "user1,user2", then split the value in independent authorities and apply the same permission for each of them.

Merged. If you get a chance, please add an integration test for this. Thanks!

And thanks for the pull request!


Adding custom data with wdio

I am wondering how should i add the custom data in wdio config file.  the below code didnt work

Hi @sajjadh
This report is not related to WebdriverIO, feel free to create an issue here and provide all needed information to reproduce this


Find an intereting dataset and make it model ready

Great Sitkin eruption data is downloaded and processed into an AI ready format


Date picker fails: constraints.maxWidth < double.INFINITY' is not true.

To reproduce: launch the date picker from flutter gallery.

Probably my fault.

This is still a problem 25 days later.

This is now:
I/flutter : ══╡ EXCEPTION CAUGHT BY RENDERING LIBRARY ╞═════════════════════════════════════════════════════════
I/flutter : The following assertion was thrown during performLayout():
I/flutter : RenderVirtualViewport does not support returning intrinsic dimensions.
I/flutter : Calculating the intrinsic dimensions would require walking the entire child list, which cannot
I/flutter : reliably and efficiently be done for render objects that potentially generate their child list
I/flutter : during layout.

The problem is that dialogs try to shrink-wrap their block around its children, but the date picker contains a widget that doesn't know its intrinsic size because it's lazily built.


chore: Set receiver app ID for v4.3

This will be reverted in the main branch after the launch/branch of v4.3, so that main continues refers to the nightly version of the receiver app.

Out of curiosity, what is the purpose for having a separate receiver app for 4.3?

These demo receivers aren't using CAF (for historical reasons).  The sender and receiver are both using Shaka Player more or less directly, with a custom message namespace to proxy the whole Shaka API across the v2 Cast SDK.  All of this goes through classes in Shaka Player like shaka.cast.CastProxy for the sender and shaka.cast.CastReceiver for the receiver.
Since what they are transmitted to one another is a serialized version of the Shaka API and state, each demo release is pinned to a matching receiver from the same branch.  That way, we can ensure compatibility.
For Shaka v5 (some time next year), I have it in mind to drop Shaka's custom Cast API and messaging, move to the latest sender SDK, move to a styled media receiver, and stop publishing versioned receiver apps entirely.  Instead of having shaka.cast.CastProxy, Shaka's UI controls will talk directly to the sender SDK.  Anyone not using our UI should integrate with the sender SDK at that point.


Can't run at starup

Hi.
I can't make it run at startup. If I start it using terminal returns a error.
$ xpander-indicator
Error loading new keyboard description
Error loading new keyboard description
(xpander-indicator:23664): Gdk-CRITICAL **: gdk_window_thaw_toplevel_updates: assertion 'window->update_and_descendants_freeze_count > 0' failed
Using Linux Mint 18.1 64bits.
Thanks.

Hello! Thank you for your interest.
Unfortunately that's a Gtk+ error and the message is unhelpful as per usual. I'll try to reproduce it in a virtual machine when I have more time, but this is going to take a while.

I restarted Linux Mint using recovery mode for another reason and noticed that xpander-indicator runned on startup. Hope it can help you find some clue.
Thanks for your reply.

I am experiencing similar issue. After drilling down into the code I pinned this line - https://github.com/OzymandiasTheGreat/xpander/blob/master/xpander-indicator#L25
Commenting out that line solves the issue but deprives me of the tray menu. Replacing it with self.indicator.set_menu(Gtk.Menu()) gives the same error. The issue may be with Gtk itself.

I'm sorry, I've been rather busy. Anyway, finally got around to installing linuxmint and while I do get that gtk error, everything runs just fine. I installed linuxmint 18.3 tho, that might be why.
@reider-roque As for that line, it's beyond strange. This would mean that no app with an app indicator can run. It might be a bug in the python bindings (wouldn't be the first) but if so it's fixed in the current version.

There are no more gtk dependencies, so give it a try if you may.


refactor(client): move "create_dataset" from SearchResult to SearchJob

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

1 of 3 (33.33%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 86.082%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

tensorbay/client/job.py
1
3
33.33%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
7985

Relevant Lines:
9276

💛  - Coveralls


Support for "stagehand "

This tool would really rock if it can be used for Flutter or Aqueduct projects with anyone's own template, much like Golang's "go get "
(context: from this thread with @dantup: https://twitter.com/DanTup/status/1096736856815923201)

Repo would require to have some kind of spec file
"stagehand " would ensure that spec file exists and generate the template found in the repo.

This would be a major value add for Flutter especially, since creating projects vary so widely regarding base requirements and the out of the box "flutter create" creates too trivial / not realistic of a project.
Would love your thoughts.

Related: #192, #394

a very similar thing that exists in the py eco system is cookiecutter. It's very nice becuase the whole structure of the project is as a regular project, just that the things that shall be replace are wrapped by the {{ }} template syntax.
I wonder if it would make sense to add one new generator template to stagehand that would accept an additional parameter like a github repo url, and it will checkout this repo as the template and will do the scanning for replacement needs and interactively replace all the variables.
The major benefit IMO is that users could use stagehand with their own templates hosted on e.g. github very easily.
@seenickcode does this goes int your direction?

It would be a great benefit to be able to generate a project from a repo. I suppose we should also consider creating them from a specific version, such as a branch or tag. Also should we be doing this discussion in this issue or #192, as both seem to try to achieve the same thing.

fwiw I’ve been working on mason which allows you to create your own custom templates using mustache which can be hosted either locally or on git.


Incorrect Labeling for the SWDIO Interface Pins?

I had just started reverse engineering my own little Controller (which seems to be identical to the one shown), when I stumbled across this awesome repository. However  the Pin furthest from the Edge, which is labeled +5V, seems to be connected directly to the supply pins of the STM32F103, aswell as the output of the regulator (at least on my board). Am I missing something here or is it misslabeled as +5V?

Oh.
Yes, I checked it now, and I believe you are totally correct! Thanks for noticing, I'll fix it in the schematic soon.


[bug] dynamic_import_to_require should interop after require module

found the bug in dumi ssr server side dist file @Jinbao1001

closed by https://github.com/umijs/mako/pull/1209


[mgmt] standbypool release

https://github.com/Azure/sdk-release-request/issues/5443

API change check
APIView has identified API level changes in this PR and created following API reviews.
@azure/arm-standbypool


im need help

I was building mods for the game with my friends, everything seems to be fine, but when 10-20 minutes pass, it immediately crashes.Please help me!   Logs: https://mclo.gs/fPnIWY4

This isn't the place to get help with your server. This is for support with the logging software itself or to bring issues to the team's attention.

< This isn't the place to get help with your server. This is for support with the logging software itself or to bring issues regarding the software itself to the team's attention.
and where can I get help?

Through<EMAIL_ADDRESS>or the discord:
https://discord.aternos.org


Add store and retrieve latency to mock block store

Mock block store is not very realistic as blocks are all in memory and storage/retrieval operations are more or less instant.
-> Add should wait some time related to WRITE_STORAGE_LATENCY and byte count * WRITE_STORAGE_BANDWIDTH
-> Get and Has should wait some time related to READ_STORAGE_LATENCY and byte count * READ_STORAGE_BANDWIDTH
We should make some effort to fix reasonable numbers for these given Kubo as base, paying attention to the fact that caching may make average read performance much worse than read performance in a trivial test.

Also - ensure that instrumented store collects time metrics


chore: use direct imports for mempool test util macros

This change is

No need.

No, there isn't a practical issue with the imports being processed multiple times in macro expansions because:
Rust's module system is designed to handle this efficiently:
The actual symbol resolution is cached by the compiler
Duplicate imports in the same scope are effectively deduplicated
The compiler is smart enough to not do redundant work for the same imports
While theoretically it's less efficient than having a single import at the module level, the overhead is negligible in practice and will not meaningfully impact:
Compilation time
Runtime performance
Memory usage
Binary size
The current approach in your macro (having imports inside) might actually be preferable because:
It makes the macro more self-contained and explicit about its dependencies
It ensures all necessary types are available in the macro's scope, preventing subtle errors
It's more maintainable as all dependencies are clearly visible where they're used
Unless you're seeing specific performance issues that you've traced back to these macro imports, I would suggest keeping them as they are. The theoretical inefficiency isn't worth optimizing unless you have a concrete need to do so.

Reopened. Now used for just one small change.


add ci for build process

To document and verify the build process, ensuring the project can be successfully built in a defined environment.

Since we're using Ubuntu 18.04, the Git version is 2.17, which is not supported by actions/checkout for checking out submodules[^1]. Given this limitation, along with other minor challenges, I'm closing this PR.
[^1]: Error: Input 'submodules' not supported when falling back to download using the GitHub REST API. To create a local Git repository instead, add Git 2.18 or higher to the PATH.


Update to unicode 8.0

What does this PR do?
This updates the data files and generated sources to the latest released Unicode data file version, 8.0. Things like "U+0001F643 UPSIDE-DOWN FACE" are now find/name-able.
Notes

This change replaces the (custom?) codepoint_name.csv with the unchanged UnicodeData.txt file - I think I have figured out how you generated  codepoint_name.csv, but I feel that just using the upstream source might make it easier to keep up to date with newer releases.
I've based this on #7, so that I could build and test it in newer environments. If you merge #7, I'll rebase this so it can be merged also.
Same comment re. the generator applies - I am not sure if I should have used any other command-line arguments when generating the updated source... but it does seem to do the right thing (:

Again, hope you find this useful - until you find the time to review & merge these PRs, I'll use this revision in chars (-:

Thanks for the pull request, and welcome! You should hear from @huonw (or someone else) soon.

ping?


Updated requirements file to have version of transformers

[x] I have updates the requirements file

This pull request adds version of transformers to libra requirement. @Palashio, could you please take a look at it?

what's the reason for freezing its version?

Transformers had some breaking changes from 2.10.0 to 2.11.0, this might repeat

yeah we noticed that too. thanks!


Require.js integration conflicts with CommonJS projects

I have a Brunch/Bower/Chaplin-Setup. Updating jsPDF to a version higher than 1.0.272 breaks the whole project in unexpected ways.
It expects that if require exists, it has to be http://requirejs.org. This is a wrong assumption.
Deleting everything between 'config.js' and the end of the file fixed all the issues and makes it even work on the iPhone.
I think this is related to #536.

can u clarify what do I need to delete and in what file?
you said I must delete everything between 'config.js' and the end of the file. wich file? is 'config.js' a string or a filename? is this the file I should clear out?

Open jspdf.debug.js and search for 'config.js' - it's in a comment. Delete that entire comment and everything to the end of the file.

This is now fixed in 1.3.x 👍 https://github.com/MrRio/jsPDF/issues/506
Let me know if you're still having trouble!


azure-sdk-c iothub_client  sample run error

when i cross  compiled iothub_client application for my AM-5728 EVM ,
i got below error . Below is my output log . please help me . My connection string is correct.
root@am57xx-evm:~# ./iothub_ll_telemetry_sample
Creating IoTHub handle
Sending message 1 to IoTHub
Error: Time:Tue Oct  9 13:16:15 2018 File:/home/kdasari/azure-iot-sdk-c/c-utility/adapters/socketio_berkeley.c Func:socketio_open Line:632 Failure: getaddrinfo failure -5.
Error: Time:Tue Oct  9 13:16:15 2018 File:/home/kdasari/azure-iot-sdk-c/c-utility/adapters/tlsio_openssl.c Func:on_underlying_io_open_complete Line:725 Invalid tlsio_state. Expected state is TLSIO_STATE_OPENING_UNDERLYING_IO.
Error: Time:Tue Oct  9 13:16:15 2018 File:/home/kdasari/azure-iot-sdk-c/c-utility/adapters/tlsio_openssl.c Func:tlsio_openssl_open Line:1209 Failed opening the underlying I/O.
Error: Time:Tue Oct  9 13:16:15 2018 File:/home/kdasari/azure-iot-sdk-c/umqtt/src/mqtt_client.c Func:mqtt_client_connect Line:981 Error: io_open failed
Error: Time:Tue Oct  9 13:16:15 2018 File:/home/kdasari/azure-iot-sdk-c/iothub_client/src/iothubtransport_mqtt_common.c Func:SendMqttConnectMsg Line:1893 failure connecting to address IH-Embedded-COE.azure-devices.net.
Sending message 2 to IoTHub
Sending message 3 to IoTHub
Sending message 4 to IoTHub
Sending message 5 to IoTHub
Error: Time:Tue Oct  9 13:16:16 2018 File:/home/kdasari/azure-iot-sdk-c/c-utility/adapters/socketio_berkeley.c Func:socketio_open Line:632 Failure: getaddrinfo failure -5.

getaddrinfomeans the hostname that you are connecting to is not resolving correctly on your device/module.

After setting up a network connection through ethernet ensure it's working good , i got a new error as shown below please look into this
root@am57xx-evm:~# ./iothub_ll_telemetry_sample
./iothub_ll_telemetry_sample: error while loading shared libraries: libssl.so.1.0.0: cannot open shared object file: No such file or directory

@chinnaece, thank you for your contribution to our open-sourced project! Please help us improve by filling out this 2-minute customer satisfaction survey


Added logging via logfire

Added logging via logfire (Ref: #4)

Did this by introducing a decorator @logger

Improved Type hinting
Sorted imports (using isort)
Fixed the problem with Gemini Provider (the genai.configure() had to be called)
Shifted imports to runtime as discussed in #27

Summary by CodeRabbit
Release Notes

New Features

Introduced a logging decorator to various methods across multiple providers, enhancing monitoring of function execution, parameters, and return values.
Added methods to dynamically enable or disable logging within the application settings.
Improved type safety with updated method signatures in several provider classes.

Bug Fixes

Enhanced error handling in methods to ensure proper exceptions are raised when required parameters are missing.

Documentation

Minor adjustments made to import statements for clarity and organization in test files.

This looks great! I'll pull it locally and try it out

should we call this tracing instead of logging?

✨🍰✨


Test with py 3.12

Currently there is an issue with onnxruntime not available for 3.12
https://github.com/ModECI/modelspec/actions/runs/7198773348/job/19608969023

py3.12 still failing: https://github.com/ModECI/modelspec/actions/runs/8362632014

Being tested already...


ErrorReturnCode not well documented

I was looking at the documentation on http://amoffat.github.io/sh/#exit-codes and found that the  ErrorReturnCode exception is not well documented.
In particular, I found that the following members of the exception are not mentioned: args, exit_code, full_cmd, message, stderr, stdout, truncate_cap.
I'd be happy to submit a pull request that adds a little more detail if this issue is confirmed.

Confirmed, some more docs would be welcome @jorisroovers

http://amoffat.github.io/sh/sections/command_class.html#errorreturncode


Strider on fstar-lang.org is down

The website is up again (#381) but Strider integration is still down.
It used to be at https://www.fstar-lang.org:3443/

We'll can try to work on fixing this after moving to a new server under our control. Hopefully soon, but don't hold your breath. Volunteers welcome, of course.

Give me a server and I can do it.

Would be great, I can also help.

We could also setup an instance of F* for Travis instead of creating our own CI…
I guess it is less flexible though ?

I think we do need the extra flexibility of having our own server or VM instance: we need to test several platforms, we depend on OCaml and F# compilers, and typechecking in F* uses significant resources.
There are plenty of free, hosted CI services we could use, but I don't think that any of them allows to do everything we want. We could use Travis to do some of those things as a temporary solution, though.

I don't think we seriously considered VMs for something other than Linux so far. I don't think that Mac OS can be legally installed in a VM, and a Windows WM might cause security and maintenance trouble. We could still discuss though, at least for creating releases and nightly builds it might be useful.

For nightly testing and regression, we will need to run VMs for linux + windows; but for the web-facing servers we’ll only use linux VMs.
-K

On 12 Oct 2015, at 21:17, Catalin Hritcu<EMAIL_ADDRESS>wrote:
I don't think we seriously considered VMs for something other than Linux so far. I don't think that Mac OS can be legally installed in a VM, and a Windows WM might cause security and maintenance trouble. We could still discuss though, at least for creating releases and nightly builds it might be useful.
—
Reply to this email directly or view it on GitHub https://github.com/FStarLang/FStar/issues/411#issuecomment-147495558.

I noticed the Strider server is now back up. That's excellent news, I hope it's not just temporary.

@s-zanella That's Jenkins not Strider. I even forgot we had that set up on https://ci.inria.fr
It doesn't do much on each commit at the moment (only make -C src) but we could set up it so that it runs bootstrapping and more tests. If you would like access to it please make an account on https://ci.inria.fr and send me your credentials by email.

@catalin-hritcu Hmmm. The one on https://www.fstar-lang.org:3443 is Strider and it appears be working as it used to do. I've created an account on https://ci.inria.fr with my MSR address (first name at microsoft.com).

True, it seems we have 2 CI servers at the moment, and only the Jenkins one sends emails, so I missed the fact that the Strider one also come back up. I have no clue why Strider was down and why it came back up now. It seems to still be running on Antoine's server, so no big changes yet. I've added you as admin on Jenkins and will also send you an invite for Strider.

Thanks!
(I don't seem to be an admin on Jenkins, but that's fine.)

We now use Travis and it is functional. Closing this issue.


Sort rules

This commit builds on #115, and contains just the reorganization part of #113.

The discussion for #115 suggested that these rules should be sorted alphabetically. They are almost alphabetical, aside from @typescript-eslint/restrict-plus-operands and @typescript-eslint/require-array-sort-compare being swapped, so I'm updating the PR to fix that.


Pencil does not start due to "pango: Harfbuzz version too old"

Describe the bug
Pencil does not start. When executed from the terminal, I get the following output:
Hardware acceleration disabled for Linux.

(pencil:17950): Pango-ERROR **: 15:20:19.627: Harfbuzz version too old (1.2.7)

[1]    17950 trace trap (core dumped)  pencil

To Reproduce
Steps to reproduce the behavior:

Install pencil from the nixos-unstable channel
Run pencil

Expected behavior
Pencil starts without errors
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
System with "nixos-unstable" standard channel, xfce-i3wm
Metadata

system: "x86_64-linux"
host os: Linux 5.4.3, NixOS, 20.03pre206331.eeaf1f702d4 (Markhor)
multi-user?: yes
sandbox: yes
version: nix-env (Nix) 2.3.1
channels(root): "nixos-20.03pre206331.eeaf1f702d4, nixpkgs-unstable-20.03pre205792.fb1bc1b891f"
channels(carsten): "nixos-19.09.1292.e1843646b04"
nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos

Maintainer information:
# a list of nixpkgs attributes affected by the problem
attribute:
# a list of nixos modules affected by the problem
module:

This looks like an issue in pango.
 Pango-ERROR **: 15:20:19.627: Harfbuzz version too old (1.2.7), is by no means true
❯ nix eval nixpkgs.harfbuzz.name                                              ~
"harfbuzz-2.6.4"

Hmm, not an issue in pango but harfbuzz.
Here's the code in pango with the message

https://gitlab.gnome.org/GNOME/pango/blob/master/pango/pangofc-fontmap.c#L2956
and that's a call into harfbuzz function
https://harfbuzz.github.io/harfbuzz-hb-version.html#hb-version-atleast

Note this is a binary package, and could do with an update https://pencil.evolus.vn/Downloads.html.
Using gnome2.pango currently :frowning:

gnome2.pango is just alias of pango. The issue is that harfbuzz is picked up from the binary package instead of the nixpkgs one. We should probably build from source but it is Electron app :scream_cat:
https://github.com/evolus/pencil/tree/development

Closing now as pencil works on both nixos-20.03 (tested at b50d55871fb7de1e5791bbd56738ff20f4d15f2c) and master (6127d1e117dfb7c85f216435f3a4378368b2966a).
For the record, this is the terminal output on master (same as on nixos-20.03):
$ ./result/bin/pencil
Hardware acceleration disabled for Linux.
Fontconfig warning: "/etc/fonts/fonts.conf", line 86: unknown element "blank"
Background web-printer started.
Shortcut main service started.
Shortcut: Super+F12 registered
RENDERER started.


[Server]. Invoke Dictionary function in deprettification process of components

Expected Behavior
Whitespacing/whitespace removal, capitalization/decapitalization, and custom dictionary entries need to be accounted for on hydrate / dehydrate.

Contributor Guides and Handbook

🛠 Meshery Build & Release Strategy
📚 Instructions for contributing to documentation

Meshery documentation site and source

🎨 Wireframes and designs for Meshery UI in Figma
🙋🏾🙋🏼 Questions: Discussion Forum and Community Slack

Are we doing this now?


Error with destructuring array within if condition with no braces

Getting an "Unexpected token" error with code such as the following:
export function replaceRange(from, to) {
  if (from) [from, to] = [to, from]

}

The error doesn't occur if braces are present.

Specifically, the generated code looks like this:
export function replaceRange(from, to) {
  var assign;

  if (from) { (assign = [to, from], from = assign[0], to = assign[1] })

}

Which has mismatched brackets (the paren after the destructuring expression ended up before the brace)

See PR #153

Fixed with 8117b6902507374a2a88da3e763eda3e37387869.


Feature/query state display Displays active query params and # of matches

This will show the query and number of matches without needing to hover over query button.  I suppose some people might find the screen a bit less pretty with this displayed however I've found myself wanting to see what I've searched for by default ...especially when there are no matches (and all you get is a blank column).  It's up to you guys to decide.
Help! : ) As I mentioned on another pull request I haven't learned how to hide a bunch of housekeeping commits I made unrelated to this PR .  This gitignore is wrong too btw...but that and the bundle files shouldn't be getting pushed anyway.

👍

thanks for the screenshots!

good idea!


Cannot read property 'getInitialProps' of undefined

Hi there, going through the example pages and on: https://learnnextjs.com/basics/getting-started/first-page I get the following:

Let me know if you need anything else

For now simple reload the page. We fixed this bug.
Basically this happens when your page doesn't have a default export.

Thanks


Add periodic job for capi-ibmcloud e2e vpc test

Signed-off-by: Prajyot-Parab<EMAIL_ADDRESS>

/cc @Amulyam24

Dependent on - #901

can we also use boskos here?
cc @Amulyam24

Yes Manju, I think we can use Boskos here. Will check further on this w.r.to the flow and get back on it.

/hold awaiting for infra related changes to be in-place. /cc @Amulyam24

@mkumatag @Prajyot-Parab, All the required changes are done. We are good to proceed with this.
/unhold


added cpp course

I have added a cpp course in hindi by CodeWithHarry for beginners.

Note to reviewers
I am participating in hacktoberfest. it will be a great help if this pr gets merged.

Hi [Place name here]. Welcome to LinksHub! :) We don't accept unassigned pull requests, so I'm putting yours in draft mode for now. In the future, please raise an issue and wait until it has been approved and assigned to you before you submit a pull request. Refer to our Contributing Guide to learn how to effectively contribute to the project. Happy Contributing! 😊

This already exists, I mentioned in the issue as well. Closing this!


Add answer type specific hint text

What problem does the pull request solve?
Adds ansdwer-specific hint text for all existing answer types. Uses the current hint text as a sensible default if we add other answer types later.
I pulled this out of the autocomplete PR because I think this makes sense independently of the autocomplete changes.
Trello card: https://trello.com/c/2SL7oeph/372-add-answer-specific-hints-to-edit-question-page
Checklist

[x] I've used the pull request template
[x] I've linked this PR to the relevant issue (if mission work)
[x] I've written unit tests for these changes (if code change)
[n/a] I've updated the documentation in (If any documentation requires updating)

[n/a] README.md
[n/a] Elsewhere (please link)

Fix for the breaking test is here: https://github.com/alphagov/forms-admin/pull/244


SVG path not big enough for ViewBox

I have an issue with some SVGs. After fixing these SVGs the viewBox is not filled with the path. It seems that the path is 80% smaller than the viewbox.
Input SVG:
<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 19 13.44"><path d="M9.5,13.44C3.88,13.44.22,7.23.07,7a.5.5,0,0,1,0-.5C.22,6.21,3.88,0,9.5,0s9.28,6.21,9.43,6.47a.5.5,0,0,1,0,.5C18.78,7.23,15.12,13.44,9.5,13.44ZM1.09,6.72c.73,1.13,4,5.72,8.41,5.72s7.68-4.59,8.41-5.72C17.18,5.59,13.94,1,9.5,1S1.82,5.59,1.09,6.72Z" style="fill:#282828"/><path d="M9.5,9.89a3.17,3.17,0,1,1,3.2-3.17A3.19,3.19,0,0,1,9.5,9.89Zm0-5.34a2.17,2.17,0,1,0,2.2,2.17A2.19,2.19,0,0,0,9.5,4.55Z" style="fill:#282828"/></svg>
Output SVG:
<svg xmlns="http://www.w3.org/2000/svg" width="19" height="13.444" viewBox="0 0 19 13.444"><path d="M6.135 1.958 C 4.880 2.110,3.633 2.708,2.421 3.740 C 2.113 4.002,1.496 4.621,1.212 4.953 C 0.814 5.418,0.391 5.988,0.127 6.414 C -0.049 6.699,-0.048 6.742,0.149 7.055 C 0.602 7.774,1.302 8.636,1.925 9.239 C 3.232 10.504,4.565 11.231,5.998 11.459 C 6.358 11.516,7.212 11.516,7.572 11.459 C 8.996 11.232,10.336 10.504,11.633 9.250 C 12.256 8.648,13.038 7.686,13.431 7.036 C 13.570 6.808,13.589 6.728,13.537 6.593 C 13.495 6.482,13.160 5.971,12.936 5.675 C 11.551 3.844,9.998 2.647,8.367 2.153 C 7.691 1.948,6.836 1.873,6.135 1.958 M7.181 2.647 C 8.918 2.797,10.699 3.951,12.224 5.914 C 12.452 6.208,12.778 6.680,12.778 6.716 C 12.778 6.779,12.300 7.439,11.948 7.862 C 11.001 8.999,9.889 9.890,8.845 10.349 C 7.037 11.144,5.217 10.890,3.445 9.597 C 2.823 9.143,2.180 8.531,1.620 7.859 C 1.256 7.423,0.790 6.777,0.792 6.712 C 0.795 6.640,1.390 5.835,1.742 5.428 C 3.449 3.456,5.340 2.489,7.181 2.647 M6.459 4.479 C 5.960 4.557,5.508 4.787,5.162 5.138 C 4.964 5.338,4.864 5.475,4.750 5.699 C 4.553 6.088,4.471 6.532,4.517 6.949 C 4.625 7.912,5.302 8.677,6.258 8.915 C 6.556 8.990,7.051 8.985,7.353 8.905 C 8.288 8.656,8.946 7.899,9.052 6.949 C 9.175 5.850,8.445 4.811,7.353 4.531 C 7.107 4.468,6.683 4.443,6.459 4.479 M7.317 5.261 C 7.801 5.438,8.186 5.857,8.313 6.344 C 8.359 6.522,8.359 6.912,8.313 7.090 C 8.169 7.642,7.705 8.094,7.149 8.224 C 6.958 8.269,6.612 8.269,6.423 8.225 C 5.857 8.091,5.397 7.640,5.255 7.079 C 5.207 6.888,5.207 6.546,5.255 6.355 C 5.372 5.892,5.743 5.462,6.175 5.292 C 6.426 5.193,6.511 5.179,6.830 5.187 C 7.100 5.194,7.156 5.202,7.317 5.261 " stroke="none" fill-rule="evenodd" fill="black"></path></svg>

@adrianengel Thanks for the issue, it looks like the input svg already has a single path attribute so I am wondering why it needs fixing? Where is it not working?

@adrianengel Thanks for the issue, it looks like the input svg already has a single path attribute so I am wondering why it needs fixing? Where is it not working?

Oh sorry. This is my input SVG:
<svg xmlns="http://www.w3.org/2000/svg" width="19" height="13.444" viewBox="0 0 19 13.444"><defs><style>.a{fill:none;stroke:#282828;stroke-linecap:round;stroke-linejoin:round;stroke-miterlimit:10;}</style></defs><g transform="translate(0.5 0.5)"><path class="a" d="M2,11.222S5.6,5,11,5s9,6.222,9,6.222-3.6,6.222-9,6.222S2,11.222,2,11.222Z" transform="translate(-2 -5)"/><ellipse class="a" cx="2.7" cy="2.667" rx="2.7" ry="2.667" transform="translate(6.3 3.556)"/></g></svg>

We are using your script to optimize all SVGs in our ReactApp. So a npm script is running a loop through all SVGs. If you open the output SVG in Illustrator you can see that the ViewBox ist bigger than the path inside.

Yes! The Icon pack was build in house. do you need more samples? I can send you all SVGs via mail for debugging.

@adrianengel please try v1.3.1 did not receive the samples so sorry if I missed any edge cases that may be in the pack, but this issue should be fixed now.


UniPC for diffusion sampling

Hi, thanks for the awesome library! It's great having these tools available in the Rust ecosystem.
I was interested in low step-count inference for some experiments, so ported over the UniPC scheduler. I figured I'd open a PR here in case this work is useful to others. Here is a comparison with Euler A and DDIM at 5 steps which demonstrates UniPC's benefits for quick convergence:

Would you have some examples with good quality where this makes a difference?

Sure, here is a comparison of DDIM (default cfg) and UniPC (corrector enabled past step 2, Bh2 solver type, otherwise defaults) on sd1.5 across 50 steps with the following prompt with seed 1984 and guidance scale 15:

a rusty robot holding a fire torch in its hand,android scrapyard,oxidized,intricate exposed wires,arcing,neon lights,sci-fi,dystopia,futuristic city background,silhouettes,strange illuminated mannequins,geisha billboard,flying cars,4k,cinematic lighting,photo-realistic,extremely detailed,high quality,epic,lfg

negative prompt:

reduction,reducing agents,electron rich,drawing,illustrated,low quality,out of focus,blurry,cut off,simple,clean,organized,daytime,utopia,peaceful,low contrast,lowres,worst quality

6 steps is about where the output starts becoming clear from both schedulers, but the composition is quite different:

At 50 steps both have converged to a similar output with some differences. Which one looks better is a bit subjective, but I think most would agree the composition is closer to the 6-step output from UniPC than that from DDIM:

Just for fun here's the 50-step output from UniPC with the same settings as above but using 3 for the solver order:

Somewhat different output again, but overall the composition pretty much resembles what it produces at 5 steps:

Thanks for the detailed analysis, I've put a bunch of comments inline, please also look at the clippy and rustfmt failures in the CI.

Thanks for the detailed analysis, I've put a bunch of comments inline, please also look at the clippy and rustfmt failures in the CI.

Thanks, these should be addressed now.


Allow Editors to add new poems

Need to think about how to handle custom dict entries...

Research using Markupsafe: https://palletsprojects.com/p/markupsafe/


[AIRFLOW-2129] Presto hook calls _parse_exception_message but defines…

… _get_pretty_exception_message
Make sure you have checked all steps below.
JIRA

[x] My PR addresses the following Airflow JIRA issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"

https://issues.apache.org/jira/browse/AIRFLOW-2129

Description

[x] Here are some details about my PR, including screenshots of any UI changes:
_parse_exception_message does not exist in presto_hook file. Based on the git blame history(https://github.com/apache/incubator-airflow/pull/2128), I blame it is a typo when the patch original committed. Just rename to the correct functions.

Tests

[x] My PR adds the following unit tests OR does not need testing for this extremely good reason: just fix the typo.

Commits

[x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

[x] Passes git diff upstream/master -u -- "*.py" | flake8 --diff

Codecov Report

Merging #3094 into master will not change coverage.
The diff coverage is 0%.

@@          Coverage Diff           @@
##           master   #3094   +/-   ##
======================================
  Coverage    73.3%   73.3%
======================================
  Files         179     179
  Lines       12500   12500
======================================
  Hits         9163    9163
  Misses       3337    3337

Impacted Files
Coverage Δ

airflow/hooks/presto_hook.py
36.95% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e28f6e2...62e9a2b. Read the comment docs.


Adding form fields to AttachAction does not work

Package
filament/tables
Package Version
v3.0.16
Laravel Version
v10.18.0
Livewire Version
v3.0.0-beta.7
PHP Version
PHP 8.2.8
Problem description
When adding an AttachAction to a table inside a RelationManager, any custom fields added to it using ->form() do not show up. Below are two images and the resulting form:

A link to the relation manager that is misbehaving: https://github.com/bram-pkg/filament-issue-7649/blob/main/app/Filament/Admin/Resources/TenantResource/RelationManagers/UsersRelationManager.php#L43-L49
Note that I have confirmed with the documentation that this is the expected syntax.
Expected behavior
It's expected that the select dropdown shows up underneath the user selection dropdown.
Steps to reproduce
Create an AttachAction inside a RelationManager and add a custom field to the form with code like:
Tables\Actions\AttachAction::make()
    ->preloadRecordSelect()
    ->form(fn (Tables\Actions\AttachAction $action): array => [
        $action->getRecordSelect(),
        Forms\Components\TextInput::make('role')->required(),
    ])

Reproduction repository
https://github.com/bram-pkg/filament-issue-7649
Relevant log output
No response

I've imported the repo to GitHub, hopefully that's fine now.

I have a feeling this is to do with the emptyStateActions() AttachAction with the same name... can you try moving the custom form to there instead? Whichever action is defined last will be used I think.

That seems to have fixed the form rendering, yes. It feels a bit unintuitive, though. Any chance this behaviour could be adjusted in the future? (I noticed you added this to the roadmap, so I'm guessing you have already)

I don't really know how to fix it yet to be honest. All issues are added to the roadmap automatically

Hm okay. Let's see then, it would be good to note this in the docs regardless of if there's a fix coming!

Closing this issue as it isn't a bug really. (Also see https://github.com/filamentphp/filament/issues/7547#issuecomment-1685844698.)
Might have to add a note to the docs indeed as multiple people seem to run into this, @danharrin.

I want to work out a way to fix it, hence why I kept it open

Okay, let's keep this issue open then and leave the other duplicate closed.


plugins/lualine: migrate to mkNeovimPlugin

Resolves https://github.com/nix-community/nixvim/issues/2191
Migrating to the current standards. Required using a transitionType for the component options that will help keep existing configurations working, but recommend switching to the new way of being explicit in your configuration to match upstream plugin declaration.

Created https://github.com/NixOS/nixpkgs/pull/337579 to free up the extraPlugins logic since it's listed as a dependency of the plugin.

Created NixOS/nixpkgs#337579 to free up the extraPlugins logic since it's listed as a dependency of the plugin.

Based on https://github.com/NixOS/nixpkgs/pull/338164, I guess we'll need to tackle this the same as #2108?

@MattSturgeon I think I was overcomplicating the warnings... I can just inline the warnings in the apply and then we'll see the warning on the actual usage without having to parse again later.

Current CI failures:
Need to update usage in a test:
(We should really fix the <unknown-files> issue with the test-cases)
40> Unexpected warnings:
40> - The option `plugins.lualine.componentSeparators' defined in `<unknown-file>' has been renamed to `plugins.lualine.settings.options.component_separators'.
40> - The option `plugins.lualine.sectionSeparators' defined in `<unknown-file>' has been renamed to `plugins.lualine.settings.options.section_separators'.
40> - The option `plugins.lualine.theme' defined in `<unknown-file>' has been renamed to `plugins.lualine.settings.options.theme'.

Need to update usage in pluigins/colorschemes/base16:
> Unexpected warnings:
> - The option `plugins.lualine.theme' defined in `/nix/store/XXX-source/plugins/colorschemes/base16' has been renamed to `plugins.lualine.settings.options.theme'.

Current CI failures:
Need to update usage in a test: (We should really fix the <unknown-files> issue with the test-cases)
> Unexpected warnings:
> - The option `plugins.lualine.componentSeparators' defined in `<unknown-file>' has been renamed to `plugins.lualine.settings.options.component_separators'.
> - The option `plugins.lualine.sectionSeparators' defined in `<unknown-file>' has been renamed to `plugins.lualine.settings.options.section_separators'.
> - The option `plugins.lualine.theme' defined in `<unknown-file>' has been renamed to `plugins.lualine.settings.options.theme'.

Need to update usage in pluigins/colorschemes/base16:
> Unexpected warnings:
> - The option `plugins.lualine.theme' defined in `/nix/store/XXX-source/plugins/colorschemes/base16' has been renamed to `plugins.lualine.settings.options.theme'.

Yeah, I always leave the tests until the implementation is done so I can see that the old configs aren't broken.

Everything looks good, IDK if you want a second opinion, but you've been very thorough in checking upstream options so I trust your changes 🚀

Thanks, I'm fairly confident in the changes since it works with my config and I'd consider it robust. Was just double checking the diff a bit and everything looks pretty good.

@mergifyio queue

I don't think the mkRenamedOptions is working correctly here
       error: A definition for option `programs.nixvim.plugins.lualine.settings.sections.lualine_b' is not of type `null or (list of (string or ((attribute set of anything) or raw lua code))) or raw lua code'. Definition values:
       - In `/nix/store/y93lbhv6j469navzizc944gvgc5hcn4v-source/plugins/by-name/lualine':

I don't think the mkRenamedOptions is working correctly here
       error: A definition for option `programs.nixvim.plugins.lualine.settings.sections.lualine_b' is not of type `null or (list of (string or ((attribute set of anything) or raw lua code))) or raw lua code'. Definition values:
       - In `/nix/store/y93lbhv6j469navzizc944gvgc5hcn4v-source/plugins/by-name/lualine':

Thanks for reporting. What does the offending definition look like?

This doesn't make much sense, because the new type should be a superset of the old type.
# new type:
null or (list of (string or ((attribute set of anything) or raw lua code))) or raw lua code

# old type:
null or (list of (string or (submodule)))

Thanks for reporting. What does the offending definition look like?

That is the old config https://github.com/NuschtOS/nvim.nix/blob/4aae65ffea0b488803245fd27e6ef5812faa5fa7/modules/default.nix#L79-L92
My attempt at updating is at https://github.com/NuschtOS/nvim.nix/pull/47/commits/d11ad57b7a4b8236150d15f0c83662a21f84bebd

Thanks for reporting. What does the offending definition look like?

That is the old config https://github.com/NuschtOS/nvim.nix/blob/4aae65ffea0b488803245fd27e6ef5812faa5fa7/modules/default.nix#L79-L92
My attempt at updating is at NuschtOS/nvim.nix@d11ad57 (#47)

I created test cases for both configs and they worked: https://github.com/nix-community/nixvim/compare/main...khaneliman:nixvim:sandro?expand=1

Running the old config:

Testing and running the new config worked without the warnings.


Code coverage

It would be nice to show our test coverage in a badge on the README, especially since our coverage is pretty good!

After thinking about it a bit, I don't think the risk is worth the value for us, so closing this issue.


Fixes fee estimation output

Summary
Fixes the fee estimation issue that happened due to second last commit

Closes https://futureverse.atlassian.net/browse/TRN-188
Checklist

[x] Add description
[x] Tag related issue(s)

can you fix the lint errors @KarishmaBothara, hard to view the changes

sorry... did not realise the lint error.. will fix it now


/commands: Links to a writeup that holds commands list + small desc.

Complete the following REQUIRED checkboxes:

[x] I have thoroughly read and understand The Odin Project Contributing Guide

[x] The title of this issue follows the command name: brief description of request format, e.g. /help: add optional @user parameter

The following checkbox is OPTIONAL:

[x] I would like to be assigned this issue to work on it

1. Description of the Feature Request:

I think that using /commands should send a link in the chat where there is a writeup including all of TOP's commands as well as a small description along side it.
2. Acceptance Criteria:

[ ] Decide where write-up is hosted and how it is formatted
[ ] New-era command created that sends link to it

3. Additional Information:

I think that this could be easily automated, more specifically because most new commands have that title and description we could just use those. I will note having to scroll to find all odin-bot commands when using / may not be known by most people.

I agree, and that's why I think it would be nice to add that information to the help command (once that gets updated).
Having a huge list of available commands show up in chat doesn't feel exactly right either, but it could be made ephemeral I guess.
Would love more opinions on this from @TheOdinProject/maintainers

I agree with @ManonLef, having a big list of commands show up in chat, hidden or not, does not feel right. As we migrate fully to slash commands it would only make sense to check using Discord's built in features. We can't really help people who don't know how to use Discord, and even then they'd have to know the command to show all the commands.
That is my personal two cents.

Fair enough.
Still, I like this from Manon and think it should be added :) :

I agree, and that's why I think it would be nice to add that information (about all commands visible when typing /) to the help command (once that gets updated).

Sounds like /commands isnt needed though, closing this issue!

@Baguirre03 The help command will definitely be updated, currently working on quite a few bot updates actually


Dataset

I am writing to express my appreciation for your open-source project. It is a valuable tool for the field of drug discovery. I am interested in retraining a model using the dataset you generated in your paper. Could you please advise me on how to access the dataset for download? Thank you for your time and consideration.

Thanks for the encouraging words! Which dataset are you referring to?

Which is generated for ANI-2xt training.

Unfortunately, that dataset was not published. A similar dataset is ANI-1, which is public: https://www.nature.com/articles/sdata2017193

Thanks a lot.


Pagination and Ajax Notifications

Implemented Pagination for merchant and vendors.
Known issues/needs more testing: Maintaining the correct pagination object (sometimes it can randomly forget that it is on a "search" pagination and return to the original page. Example. If I look up "eggs" and come up with like 3 pages of results, if I click on page 3, it may return a page that is what page 3 would normally look like if there aren't search terms). I have managed to fix a lot of the bugs that arose, but it would be best to run thru a few more cases to be sure:
Added success ajax messages. General ajax message for favoriting and increasing/decreasing quantities can be found in base.html.
Also, random files may have been imported and exported from other branches

@jondubin @Huntrr Ready for code review.

When I go to the page and try favoriting or unfavoriting something (before any cart changes), the notification dialog doesn't come up. Once I make cart changes, the notification for favoriting/unfavoriting works correctly

@webfreak7 I also thought the order by field was taking up a lot of room as its own row, so I put it side-by-side with the main search. Let me know what you think about that

When there's a search with 0 results, an empty page button appears

When I search for something with no results, the search form clears and all the listings show

When I go to the page and try favoriting or unfavoriting something (before any cart changes), the notification dialog doesn't come up. Once I make cart changes, the notification for favoriting/unfavoriting works correctly

This has since been fixed

When there's a search with 0 results, an empty page button appears

Now when someone searches something with no results, they are shown all listings (A header will appear on the page as follows. http://puu.sh/m48g9/23b206f8dc.png)

@webfreak7 I found that behavior a bit counter-intuitive, or at least it was confusing at first. I think this is usually handled (on other sites with search) with a "no results found" declaration. Is there a reason you opted not to use that here?

How does the actual pagination templating work? With the sample data loaded, when I'm on any page (but 6) I can select any of the pages, but when I'm on page 6, I can't see page 3 anymore.

@webfreak7 also, merge master into this branch so we can make sure everything is functionally compatible

We should re-add clicking on a row in the vendor listings view to get to the edit view for that listing

How does the actual pagination templating work? With the sample data loaded, when I'm on any page (but 6) I can select any of the pages, but when I'm on page 6, I can't see page 3 anymore.

This is the default definition of the iter_pages method you will find in listings.html. The definition is found packaged with sqlalchemy. Full method can be found here: http://flask.pocoo.org/snippets/44/
For now, the behavior should be fine. It will make much more sense when there are a larger amount of pages.

OK, that sounds good to me. It looks like this PR is very close to being finished, I'll take a close look at the code tomorrow. I noticed that the vendor items view is currently broken (some count error)

OK, that sounds good to me. It looks like this PR is very close to being finished, I'll take a close look at the code tomorrow. I noticed that the vendor items view is currently broken (some count error)

fixed

also, merge master into this branch so we can make sure everything is functionally compatible

fixed

We should re-add clicking on a row in the vendor listings view to get to the edit view for that listing

fixed

@webfreak7 I found that behavior a bit counter-intuitive, or at least it was confusing at first. I think this is usually handled (on other sites with search) with a "no results found" declaration. Is there a reason you opted not to use that here?

User is now directed to a page with no search results and a link to reset the search.
http://puu.sh/m4p4E/4740558f2d.png

LGTM


Broken link to demo

Overview:
The link to the demo is broken or the site is down.
Acceptance Criteria:
As a user, I expect when I click the link to the demo (currently "CLICK HERE TO DEMO THE WIDGET"), I'll be taken to a page where I can demo the widget.
Steps to Duplicate ( required for bug reports ):
Click "CLICK HERE TO DEMO THE WIDGET" and/or visit https://www.ourstates.org/action
System Info ( required for bug reports ):
macOS 10.15.5, Brave Version 1.8.96 Chromium: 81.0.4044.138 (Official Build) (64-bit)

Watching as I would get a lot of use out of this widget.


New projects - this is not an issue - more of an request

Having to create a test version on another issue, I created a new meter project, added angular, deleted the sample files and added new client server and model folders, then added app.ng.js, main and index files.
Would it not be possible to have a meteor createAngular call which would all this for us?

@JohnAReid
If you are fond of material (I am!) - here is an opinionated  boiler plate with material account (login, logout, register) windows you can copy.
It has a todos app to point where to start.
https://github.com/Tallyb/angular-meteor-material
[if you like it - please star...]

Thank @Tallyb the boiler plate looks good but if I read it correctly the user would still have to create meteor then add the pakages for Angular and other items - I am suggesting this could be done in the Meteor create stage.

right...

I beleive this would make Angular easier to work with Meteor - but as no one else is interested I have closed this issue.


Improve C++11 support

This improves the support for older C++ versions

Not sure why the new CI tests fail yet. I am out for the next week, so I will look into it once I am back.

@maxbachmann This looks incredible, thank you so much!! 🎉 Let me know if there is anything I can help with.


BUG: Concat with tz-aware and timedelta raises AttributeError

[x] closes #12620
[x] tests added / passed
[x] passes git diff upstream/master | flake8 --diff
[x] whatsnew entry

@jreback 's comment on #12620:

should be handled at a slightly higher level.

I added number of dtype check logic in tseries/common/_concat_compat. But it should work on base/common/_concat_compat. Lmk which is preferable.

Current coverage is 88.64%

Merging #12635 into master will not affect coverage as of a53c27c

@@            master   #12635   diff @@
=======================================
  Files          275      275
  Stmts       133688   133694     +6
  Branches         0        0
  Methods          0        0
=======================================
+ Hit         118511   118517     +6
  Partial          0        0
  Missed       15177    15177

Review entire Coverage Diff as of a53c27c

Uncovered Suggestions

+0.07% via ...s/io/sas/sas7bdat.py#30...121
+0.03% via ...s/io/sas/sas7bdat.py#531...569
+0.03% via ...as/tools/plotting.py#633...664
See 7 more...

Powered by Codecov. Updated on successful CI builds.

thanks @sinhrks


Support for shrinkpdf under Windows

Shrinking the final proceedings.pdf seems not to be supported under Windows.

Maybe there should be an explizit hin to run the script through the Git bash?
mgs must be called instead of gs (using MikTeX)
The PDFSETTINGS and AutoRotatePages options require a double slash instead of a single slash
The resulting PDF is optimized for printing, so all hyperlinks are removed. Shouldn't it be called using the dPrinted=false option to preserve the links?

 Need to double check.
I added -Printed=false.


Open Images: add writing support

Summary

This is another step towards implementing #274. This time, I add writing support for metadata, images and labels.
How to test

N/A
Checklist

[x] I submit my changes into the develop branch
[x] I have added description of my changes into CHANGELOG
[x] I have updated the documentation accordingly
[x] I have added tests to cover my changes
[x] I have linked related issues

License

[x] I submit my code changes under the same MIT License that covers the project.
Feel free to contact the maintainers if that's a concern.
[x] I have updated the license header for each file (see an example below)

# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

I addressed all remarks where I haven't posted a reply.

I tested this dataset format. I have the following questions:

The links in the documentation to the image description file need to be swapped (validation and test)

For testing, I added the following files to the dataset: validation set, class descriptions, class hierarchy and validation images.
└─ Dataset/
├── annotations/
│   └── bbox_labels_600_hierarchy.json
│   └── validation-images-with-rotation.csv
│   └── oidv6-class-descriptions.csv
└── images/
└── validation
...
└── ...
After import-export, I received the following differences:

The file with the description of classes after import-export doesn't contain a description. For example, /m/0100nhbf,/m/0100nhbf, and there was /m/0100nhbf, Sprenger's tulip.
The validation-images-with-rotation.csv file contains only the ImageID and Subset for all items.
Added an empty validation-annotations-human-imagelabels.csv file (with a header). Maybe if there is no information for it, it does not need to be created?

The links in the documentation to the image description file need to be swapped (validation and test)

Whoops, you're right. I'll fix it in a separate PR (since it's unrelated to writing support).

The file with the description of classes after import-export doesn't contain a description. For example, /m/0100nhbf,/m/0100nhbf, and there was /m/0100nhbf, Sprenger's tulip.
The validation-images-with-rotation.csv file contains only the ImageID and Subset for all items.

These are both consequences of the same problem - that the information in those other columns doesn't map to Datumaro concepts and therefore has to be discarded when the dataset is loaded. I don't know how I would solve that.

Added an empty validation-annotations-human-imagelabels.csv file (with a header). Maybe if there is no information for it, it does not need to be created?

That's a good point (and will become an even better point when support for other annotation types is added). I'll see if I can implement this.

Added an empty validation-annotations-human-imagelabels.csv file (with a header). Maybe if there is no information for it, it does not need to be created?

That's a good point (and will become an even better point when support for other annotation types is added). I'll see if I can implement this.

Alright, implemented.


Update scala3-library to 3.5.1-RC2

About this PR
📦 Updates org.scala-lang:scala3-library from 3.5.0-RC7 to 3.5.1-RC2
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scala-lang", artifactId = "scala3-library" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.scala-lang", artifactId = "scala3-library" }
}]

labels: library-update, early-semver-pre-release, semver-spec-pre-release, version-scheme:semver-spec, commit-count:1

https://github.com/scala/scala3/issues/21368


Add the DfE's govuk-components to resources list

The govuk-components gem is a lightweight alternative to the govuk_publishing_components library and provides all of the non-form components from the GOV.UK Design System.
Version 1.0.0 has recently been released and it's now used across several DfE projects.
It uses GitHub's ViewComponent framework.
This supersedes #1430 where the forked repository fell victim to my spring clean.

You can preview this change here:
Built without sensitive environment variables with commit 4733316e9f2eb4674e42e857bbbe3a3cf3cc62ba
https://deploy-preview-1550--govuk-design-system-preview.netlify.app

Thanks @peteryates!
(For anyone else's reference, there is additional conversation in https://github.com/alphagov/govuk-design-system/pull/1430)


Use/nette code generator

Description
Use the nette code generation library
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #33
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:

[ ] Code compiles correctly
[ ] Created/updated tests
[ ] Extended the documentation

Codecov Report

Merging #34 (827bc8d) into main (c7e3287) will increase coverage by 0.27%.
The diff coverage is 91.46%.

@@             Coverage Diff              @@
##               main      #34      +/-   ##
============================================
+ Coverage     67.40%   67.68%   +0.27%
+ Complexity      402      395       -7
============================================
  Files            45       45
  Lines          1439     1439
============================================
+ Hits            970      974       +4
+ Misses          469      465       -4

Impacted Files
Coverage Δ
Complexity Δ

src/lib/Actors/ActorProxy.php
91.32% <91.46%> (+2.31%)
51.00 <9.00> (-7.00)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7e3287...827bc8d. Read the comment docs.

Codecov Report

Merging #34 (827bc8d) into main (c7e3287) will increase coverage by 0.27%.
The diff coverage is 91.46%.

@@             Coverage Diff              @@
##               main      #34      +/-   ##
============================================
+ Coverage     67.40%   67.68%   +0.27%
+ Complexity      402      395       -7
============================================
  Files            45       45
  Lines          1439     1439
============================================
+ Hits            970      974       +4
+ Misses          469      465       -4

Impacted Files
Coverage Δ
Complexity Δ

src/lib/Actors/ActorProxy.php
91.32% <91.46%> (+2.31%)
51.00 <9.00> (-7.00)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7e3287...827bc8d. Read the comment docs.


Forecasting

Hey @mandyxmg and @vsonnemans
Please, provide inputs to the Forecasting section of the doc.
Please include the following parts:

Conditional predictive density one period ahead - this part is assigned to @mandyxmg
Algorithm to sample from the predictive density with the description of how the latest draws of parameters and forecasted values are used in the iterative forecast - this part is assigned to @vsonnemans
Sampler implementation in R for a single draw s but at all horizons h=1,...,H

Introduce the material using the notation in line with that established in section Autoregressions.
Please, create a Pull Request and include there all your commits containing contributions to this section. In your commits, please, include changes only to the index.qmd file. Could you make your submission clear, making instructive comments on the individual commits? If you're planning to introduce changes to other parts of the website, you can do that in a separate pull request. This would require you either to play with the branches to which you commit changes in GitHub Desktop or to wait to introduce changes to other parts of the page later on when you submit the Pull Request about your section.

Hey @vsonnemans
How are you? May I suggest that in your part of this section, you describe how the conditional one-period-ahead (frequentist) predictive density is used to perform Bayesian prediction h periods ahead?
Please, let me know what you think.
Greetings,
Tomasz


use cue to vet another cue file

Hi,
I am trying to validate a cue file with another cue file. Is it possible to validate cue with another cue?

What version of CUE are you using (cue version)?

➜  cue version
cue version v0.5.0-beta.2

       -compiler gc
        -ldflags -s -w
     CGO_ENABLED 0
          GOARCH amd64
            GOOS darwin
         GOAMD64 v1

Does this issue reproduce with the latest release?
yes
What did you do?

create a schema file

-- schema.cue
close({
	foo: bar: string
})

create another cue file

-- another.cue
foo: {
	bar: "passed down"
}
extra: "this extra field not defined in schema"

run vet command cue vet another.cue schema.cue

What did you expect to see?
Error for field extra in another.cue
What did you see instead?
cue vet another.cue schema.cue does not raise any error. And exit status is 0.

Duplicate of https://github.com/cue-lang/cue/issues/2214, which was converted from your discussion with the same request.


Make TC Analysis parallel

Issue resolution

May close #180. If the errors from #180 persist, I will try merging the zppy implementation of https://github.com/E3SM-Project/e3sm_diags/pull/824 first, and run the tests again, seeing if they are gone then.
Resolves the e3sm_diags piece of #623, thus closing #622.

Select one: This pull request is...

[ ] a bug fix: increment the patch version
[x] a small improvement: increment the minor version
[ ] an incompatible (non-backwards compatible) API change: increment the major version

1. Does this do what we want it to do?
Objectives:

Remove sequential-only restriction on tc_analysis task.
Remove sequential-only restriction on the  e3sm_diags task when tc_analysis is in sets.
Change min-case tests of tc_analysis to use v2, since data in v3 is unavailable at the moment (https://github.com/E3SM-Project/e3sm_diags/pull/866#issuecomment-2405873119)

Required:

[ ] Product Management: I have confirmed with the stakeholders that the objectives above are correct and complete.
[ ] Testing: I have added or modified at least one "min-case" configuration file to test this change. Every objective above is represented in at least one cfg.
[ ] Testing: I have considered likely and/or severe edge cases and have included them in testing.

If applicable:

[ ] Testing: this pull request introduces an important feature or bug fix that we must test often. I have updated the weekly-test configuration files, not just a "min-case" one.
[ ] Testing: this pull request adds at least one new possible parameter to the cfg. I have tested using this parameter with and without any other parameter that may interact with it.

2. Are the implementation details accurate & efficient?
Required:

[ ] Logic: I have visually inspected the entire pull request myself.
[ ] Logic: I have left GitHub comments highlighting important pieces of code logic. I have had these code blocks reviewed by at least one other team member.

If applicable:

[ ] Dependencies: This pull request introduces a new dependency. I have discussed this requirement with at least one other team member. The dependency is noted in zppy/conda, not just an import statement.

3. Is this well documented?
Required:

[ ] Documentation: by looking at the docs, a new user could easily understand the functionality introduced by this pull request.

4. Is this code clean?
Required:

[ ] Readability: The code is as simple as possible and well-commented, such that a new team member could understand what's happening.
[ ] Pre-commit checks: All the pre-commits checks have passed.

If applicable:

[ ] Software architecture: I have discussed relevant trade-offs in design decisions with at least one other team member. It is unlikely that this pull request will increase tech debt.

Unit tests pass (https://github.com/E3SM-Project/zppy/actions/runs/11355423070/job/31584722994?pr=631).
I didn't run into any of the issues from #180. Those errors were intermittent, so I do have some concern they just didn't happen to happen this time. That said, it's very possible underlying things have changed since those bugs were first noticed. For reference, those bugs were:

GenerateConnectivityFile: error while loading shared libraries: libnetcdf.so.11: cannot open shared object file: No such file or directory previously occurred when multiple year sets of tc_analysis were run simultaneously. This was tested here with test_min_case_e3sm_diags_tc_analysis_parallel_chrysalis.cfg.
socket.gaierror: [Errno -2] Name or service not known previously occurred in E3SM Diags when running the tc_analysis set in parallel. This was also tested here with test_min_case_e3sm_diags_tc_analysis_parallel_chrysalis.cfg.

 Full testing details
# zppy dev environment
mamba clean --all
mamba env create -f conda/dev.yml -n zppy_dev_make-tc-parallel-20241015
conda activate zppy_dev_make-tc-parallel-20241015
pre-commit run --all-files
pip install .
python -u -m unittest tests/test_*.py

# e3sm_diags dev environment
cd ../e3sm_diags
git checkout main
git fetch upstream
git reset --hard upstream/main
git log # Should match https://github.com/E3SM-Project/e3sm_diags/commits/main
mamba clean --all
mamba env create -f conda-env/dev.yml -n e3sm_diags_20241015
conda activate e3sm_diags_20241015
pip install .

cd ../zppy
conda activate zppy_dev_make-tc-parallel-20241015
pip install .

zppy -c tests/integration/generated/test_min_case_tc_analysis_simultaneous_1_chrysalis.cfg
zppy -c tests/integration/generated/test_min_case_tc_analysis_simultaneous_2_chrysalis.cfg
cd /lcrc/group/e3sm/ac.forsyth2/zppy_min_case_tc_analysis_simultaneous_1_output/test-631-v2/v2.LR.historical_0201/post/scripts/
grep -v "OK" *status
# No errors
cd /lcrc/group/e3sm/ac.forsyth2/zppy_min_case_tc_analysis_simultaneous_2_output/test-631-v2/v2.LR.historical_0201/post/scripts/
grep -v "OK" *status
# No errors

zppy -c tests/integration/generated/test_min_case_e3sm_diags_tc_analysis_chrysalis.cfg
cd /lcrc/group/e3sm/ac.forsyth2/zppy_min_case_e3sm_diags_tc_analysis_output/test-631-v2/v2.LR.historical_0201/post/scripts
grep -v "OK" *status
# No errors
# https://web.lcrc.anl.gov/public/e3sm/diagnostic_output/ac.forsyth2/zppy_min_case_e3sm_diags_tc_analysis_www/test-631-v2/v2.LR.historical_0201/e3sm_diags/atm_monthly_180x360_aave_tc_analysis/model_vs_obs_1985-1986/viewer/tc_analysis/index.html has plots

zppy -c tests/integration/generated/test_min_case_e3sm_diags_tc_analysis_mvm_1_chrysalis.cfg
# Wait to complete
cd /lcrc/group/e3sm/ac.forsyth2/zppy_min_case_e3sm_diags_tc_analysis_mvm_1_output/test-631-v2/v2.LR.historical_0201/post/scripts/
grep -v "OK" *status
# No errors
cd -
zppy -c tests/integration/generated/test_min_case_e3sm_diags_tc_analysis_mvm_2_chrysalis.cfg
cd /lcrc/group/e3sm/ac.forsyth2/zppy_min_case_e3sm_diags_tc_analysis_mvm_2_output/test-631-v2/v2.LR.historical_0201/post/scripts/
grep -v "OK" *status
# No errors
# https://web.lcrc.anl.gov/public/e3sm/diagnostic_output/ac.forsyth2/zppy_min_case_e3sm_diags_tc_analysis_mvm_2_www/test-631-v2/v2.LR.historical_0201/e3sm_diags/atm_monthly_180x360_aave_mvm/model_vs_model_1995-1996/viewer/tc_analysis/index.html has plots

zppy -c tests/integration/generated/test_min_case_e3sm_diags_tc_analysis_parallel_chrysalis.cfg
cd /lcrc/group/e3sm/ac.forsyth2/zppy_min_case_e3sm_diags_tc_analysis_parallel_output/test-631-v2/v2.LR.historical_0201/post/scripts/
grep -v "OK" *status
# No errors
# https://web.lcrc.anl.gov/public/e3sm/diagnostic_output/ac.forsyth2/zppy_min_case_e3sm_diags_tc_analysis_parallel_www/test-631-v2/v2.LR.historical_0201/e3sm_diags/atm_monthly_180x360_aave_tc_analysis/model_vs_obs_1985-1986/viewer/tc_analysis/index.html has plots
# https://web.lcrc.anl.gov/public/e3sm/diagnostic_output/ac.forsyth2/zppy_min_case_e3sm_diags_tc_analysis_parallel_www/test-631-v2/v2.LR.historical_0201/e3sm_diags/atm_monthly_180x360_aave_tc_analysis/model_vs_obs_1987-1988/viewer/tc_analysis/index.html has plots

@forsyth2 thank you for working on the PR and the comments. I visually checked and it looks good. I'm happy to review any upcoming TC analysis related PRs, so feel free to tag me.

Thanks @chengzhuzhang!


Bad Result

I used your model on my task, it seems no that good?
I clipped the size of my img to (512, 128) following your size. The original input img is the first below followed by the result img.

Is there anything wrong?
Below is my code：
from PIL import Image
from omegaconf import OmegaConf

from model.IDM.utils.util import instantiate_from_config

if __name__ == '__main__':
    DiffTSR_yaml_config = './model/DiffTSR_config.yaml'
    DiffTSR_ckpt_config = './ckpt/DiffTSR.ckpt'
    DiffTSR_config = OmegaConf.load(DiffTSR_yaml_config)
    DiffTSR_model = instantiate_from_config(DiffTSR_config.model)
    DiffTSR_model.load_model(DiffTSR_ckpt_config)
    print("Model Loaded")

    lq_image_pil = Image.open('./test.png').convert('RGB')
    lq_image_pil = lq_image_pil.resize((512, 128))

    # Start sampling!
    sr_output = DiffTSR_model.DiffTSR_sample(lq_image_pil)
    # Save sr image!
    sr_image_pil = Image.fromarray(sr_output, 'RGB')
    sr_image_pil.save('./task2_new.png')

I conducted another test: padding on left, right, top, bottom to keep the size (512, 128), leaving the text image centric and deformed.
This is result:

Thank you for your interest in this work. There are a few key points that require clarification.
First, this project is currently only applicable to single-line text images, with the input size limited to patches of 128x512, and the number of text characters is no more than 24. Therefore, for other images containing text patches, you should first detect the text line image from the original image using a text detection method like PaddleOCR, then crop and resize the patches to 128x512 and input them into the DiffTSR model.
Second, the text area in the cropped image should occupy the center. Usually, the text patches detected by the text detection model meet this condition. Additionally, the DiffTSR model is robust to text deformation.
Third, the DiffTSR model focuses on scene text images. We have not fully tested its performance in other scenarios, but it can be easily adapted for other scenarios with fine-tuning.
For more details, please refer to the main manuscript and the supplementary materials. Thanks for your interest, and we are also working on developing methods that are more adaptable.

Thanks for your reply and appreciate your work.
I'm going to check your paper again and follow your proposal soon afterwards to see whether the model actually works or not in my case. Please keep this issue open, I think I could post my feedback here.


[Script] Add BERT SST-2 finetuning result

Description
Add sst-2 result to the website.
Checklist
Essentials

[x] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
[x] Changes are complete (i.e. I finished coding on this PR)
[ ] All changes have test coverage
[x] Code is well-documented

Changes

[ ] Feature1, tests, (and when applicable, API doc)
[ ] Feature2, tests, (and when applicable, API doc)

Comments

If this change is a backward incompatible change, why must this change be made.
Interesting edge cases to note here

Job PR-600/2 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-600/2/index.html

Job PR-600/3 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-600/3/index.html


Use facade.mediachain.io by default

Closes #8
Hostname is assigned, waiting to propagate

lgtm 👍


Replacement for VCAP_APP_PORT

As per https://github.com/cloudfoundry/diego-design-notes/blob/master/migrating-to-diego.md#vcap_app_port , it appears that both PORT and CF_APP_PORT can be used as replacement for VCAP_APP_PORT . But while migrating a CF app to Diego I noticed that replacing VCAP_APP_PORT with CF_APP_PORT just makes the app crash, while replacing it with PORT seems to make it run fine.
http://docs.cloudfoundry.org/devguide/deploy-apps/environment-variable.html#CF-INSTANCE-PORT seems to explain the difference correctly, and I think the diego deltas part of Diego migration readme should have the proper explanation.

Thanks, @ssmoily! Fixed in https://github.com/cloudfoundry/diego-design-notes/commit/7dd883f5d99ed37b2c772b3f924a4f4be0894ed7.

👍


Best way to import Initial Data to some tables

Hi all,
I have some tables that I want to have some initial values because of some dependencies.
I've tried using event.listens_for on 'after_create' but that's starting to get a bit messy «cause I need lots of data.
I was thinking of having something like .csv files with the values I want to ensure that exist on some table but I don't know if this is the best method.
What should I use for this? The most efficient way to ensure everytime I run the app that those values exist on some tables.
Thanks,
Bruno

Just add a cli command to your app that does it, either together with calling db.create_all() or as a completely separate command.


fix: when there is a network error, display error panel instead of no results

When we have a network error, the Operations and Objects pages show our "No objects yet" UI instead of indicating that there was an error. Network errors are common in development (fix-gov issue), and it can be confusing what has happened given that you are possibly switching between a prod and local datastore.
The traces page also has this issue, but saving that for a different PR (need to think about export button in header for example).  Also, @tssweeney could we get rid of cgDataModelHooks.ts entirely?
Misleading current behavior:

After this PR:

Where in this PR is error non null??

Not in this PR, but error is being set here:
https://github.com/wandb/weave/blob/master/weave-js/src/components/PagePanelComponents/Home/Browse3/pages/wfReactInterface/tsDataModelHooks.ts#L99


Graphics: adaptive calculation of quadratic curve and arc subdivision

Evaluating PIXI (great engine indeed!) I found that the curves have constant subdivision ratio. This produces jagged edges if the curves are long enough:
https://www.dropbox.com/s/y9hxkkhjbtpkgsm/pixi_curves_old.png?dl=0
So I suggest calculating the subdivision based on the curves' length:
https://www.dropbox.com/s/h1dx5smaxp7inzl/pixi_curves_new.png?dl=0

Adaptive rasterizing is good, but that change breaks previous behaviour. I approve it either other approve either if something like PIXI.settings.graphicsAdaptCurve is set.

Also it has max segments lengths constant. Lets see if @GoodBoyDigital and @bigtimebuddy agree to changes in current form.

Big +1
As for BC I'm not sure it applies here, so we should be able to drop it for next patch/minor version.

Patch version Z (x.y.Z | x > 0) MUST be incremented if only backwards compatible bug fixes are introduced. A bug fix is defined as an internal change that fixes incorrect behavior.

Minor version Y (x.Y.z | x > 0) MUST be incremented if new, backwards compatible functionality is introduced to the public API. It MUST be incremented if any public API functionality is marked as deprecated. It MAY be incremented if substantial new functionality or improvements are introduced within the private code. It MAY include patch level changes. Patch version MUST be reset to 0 when minor version is incremented.

See https://semver.org/#spec-item-6

I say just put those numbers and behaviour switch in constant and document it properly , and then merge. Set behaviour by default in next major version.

These constants were selected experimentally. 10 is the length of a single segment. It seems to give good looking results on the curves of average length. 8 seems to be enough for very short curves. 2048 is just some "bug number" limiting the maximal number of segments. But you right, there could be some corner cases, when these constants won't be adequate. So I agree, the setting for this is the best choice. I fix it soon.

Btw, currently, all vector things in pixi work for scale=1. Transform isnt taken into account in rasterizing, and  for now its ok.

@icosaeder Don't forget about the regular bezierCurveTo method. It also uses a fixed number of segments.
Another way to get number of segments using hyperbola.
http://ciechanowski.me/blog/2014/02/18/drawing-bezier-curves/
function tesselationSegmentsForLength(length) {
  const segs = length / segmentLength;
  return Math.ceil(Math.sqrt(segs * segs * 0.6 + minSegmentNumber * minSegmentNumber));
}

@OSUblake makes a good point! @icosaeder, Thanks for your efforts so far, think you could round this PR off by adding similar functionality to bezierCurveTo?

Thank you! :)
Sure, I take a look at bezierCurveTo.

hey @icosaeder, any progress on this with bezierCurveTo?

Hi! I'm very sorry for the delay, the last couple of weeks I had some urgent things to do. But now I pushed the bezierCurveTo improvement.


et build over-builds even when fine-grained targets are provided

On a clean build I ran et build //flutter/tools/engine_tool:tests.
It appears to be doing a full engine build however, versus just what is required to build that target:
matanl@matanl-macbookpro4 flutter % et build //flutter/tools/engine_tool:tests
[2024-10-04T16:44:06.172][macos/host_debug: GN]: OK
[2024-10-04T16:44:07.221][macos/host_debug: RBE startup]: Proxy started successfully.
[macos/host_debug: ninja] 50.7% (4840/9542) CXX obj/flutter/third_party/dart/runtime/vm/libdart_vm_precompiler.raw_object_fields.o

Mentioned in Impeller weekly as a potential pain point, so I'll look into this.

For some reason, building engine_tool:tests translates to a full build:
% et -v et build //flutter/tools/engine_tool:tests
matanl@matanl-macbookpro4 flutter % et -v build //flutter/tools/engine_tool:tests
[2024-10-09T15:06:27.699][macos/host_debug: GN]: STARTING: /Users/matanl/Developer/engine/src/flutter/tools/gn --runtime-mode debug --no-stripped --no-lto --xcode-symlinks --rbe --no-goma
[2024-10-09T15:06:28.345][macos/host_debug: GN]: OK
[2024-10-09T15:06:28.493][macos/host_debug: RBE startup]: STARTING: /Users/matanl/Developer/engine/src/flutter/buildtools/mac-arm64/reclient/bootstrap --re_proxy=/Users/matanl/Developer/engine/src/flutter/buildtools/mac-arm64/reclient/reproxy --use_application_default_credentials --cfg=/Users/matanl/Developer/engine/src/flutter/build/rbe/reclient-mac.cfg
[2024-10-09T15:06:28.751][macos/host_debug: RBE startup]: Proxy started successfully.
[2024-10-09T15:06:28.752][macos/host_debug: ninja]: STARTING: /Users/matanl/Developer/engine/src/flutter/third_party/ninja/ninja -C /Users/matanl/Developer/engine/src/out/host_debug -j 800 --verbose

Ah, because it's not a recognized action. Let's improve this.


Timestamp formats

We've had a lot of discussion previously about timestamps, and we arrived at a nice clean simple solution which was to have the millisecond epoch time as the time in the base attribute.
We've found that when working with OCSF data there are destination systems that support only a specific timestamp format. Most recently it's been Opensearch, which supports an ISO timestamp.
When putting OCSF data in to a system that can't accommodate the OCSF epoch format the options are:

Put it in as OCSF formatted data and don't index a timestamp at all (obviously not entirely useful for timeseries data)
Accept that the storage format and the transmission format will be different and process the timestamp before it hits Opensearch replacing the millisecond epoch timestamp with the ISO string timestamp that Opensearch is able to index. If the data needs to be exported, transform the ISO format back to the OCSF conforming epoch format.
Put the ISO format in unmapped and index on that, leaving the storage format OCSF compliant

The way we have tackled it is by option 3, putting a timestamp_iso field in unmapped so that we can store the data in an OCSF compliant way, and then don't need to do additional transformations on input and output from the system.
While the prompt for this is a storage format issue, the same problem could arise in other cases such as where a higher precision timestamp is needed.
The solution we've chosen in this case works great but feels a bit hacky for timeseries data, and am curious if others have encountered this issue and how they have worked with it / around it.
OCSF has many more real-world use cases than it did when we implemented timestamps. Would now be a good time to discuss how we could accommodate additional timestamp formats in a more "first class" way?

Have you taken a look at the datetime profile? The issue you described was pretty much the problem this profile intends to solve.
It adds a *_dt field(with a datetime_t format) for every timestamp field in a class where the profile is applied.

How did I not remember that? I've looked at those profiles 1000 times! :man_facepalming:
Certainly takes care of both use cases described, thanks @floydtree


"Show on Audit" Setting in Skill Lists Broken

CorpTools Version 2.0.10
Expected Behavior
Skill lists with the "show on audit" checkbox cleared should be hidden from regular member users.
Steps to reproduce:

Create a skill list.
Ensure the Show on audit checkbox is cleared (not selected).
Login to Auth with a non-admin character with the permission can_view_character_audit only
Skill list is still accessible under the audit module

Confirmed bug, that is for reporting! I'll look at why.


Add default response settings configuration

It would be great if one could configure a set of default settings in the JSON configuration (and/or inject them in code as well), so you don't have to define the same config settings for all your responses over and over again.

This feature is now ready for use in version 2.1. Please raise tickets as you find issues.


Issue 5938 - Updated loadColors function to work with Mod config settings

In addition to the modification to the case statement fall through, loadColors function and cooresponding config settings needed to be modified/created.

Revert the change in the configuration file

Mods really don't need a separate colour definition

can you also rebase this on master? so the changes in getDefaultColor are not in this PR's diff

Any update?

rebased


[MS-2712] Introduce App Repository API

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: bvanreeven:x: Pasqale LatrofaPasqale Latrofa seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Feature Request - Netflow Exporter

Feature Request:
Add netflow exporter (softflowd, or ng_netflow) with a basic GUI and support for v5 & v9 export.

+1 ipfix would be awesome as well

I agree, this is a good roadmap item for 16.7 :)

(This should probably be a plugin)

Looking forward getting Netflow.

First bits of this are going to hit the development version soon. :)

The development version (github) contains a functional netflow collector, in case anybody wants to try it out, don't forget to install samplicator first.

Already in the development version, closing in anticipation of a release in maybe 1-2 weeks from now.


matplotlib 2.1.0

Type: Missing
Summary:
matplotlib 2.1.0
Details:
PyPi indicates  Python Software Foundation License (BSD)
Matplotlib readme states: Matplotlib only uses BSD compatible code, and its license is based on the PSF license. See the Open Source Initiative licenses page for details on individual licenses.
DiffTool indicates nonstandard SPDX
Resolution:
OTHER
Affected definitions:

matplotlib 2.1.0

@ariel11 Last year, it was decided to go ahead and curate this as PSF based on this SPDX issue: https://github.com/spdx/license-list-XML/issues/1104.
However, it looks like the conversation has stalled. Should we continue using PSF or go back to using OTHER?

@capfei - I support staying with PSF-2.0 based on the SPDX issue (looks like Steve added it to the next release - 3.17).   Does that sound good to you?


Add functional file cog

Description
The file cog will allow us to preview file types of which discord does
not support previewing for
Type of change

[ ] Bug or typo fix
[x] New feature

Checklist:

[x] Code conforms to convention guidelines
[x] Tested changes in a dev environment
[x] Updated documentation (if necessary)

oh yeah, typing should be added for all the new functions 💡
Docstrings too, where appropriate.


Gitea 1.2 when will it be finished?

Listen, version 1.2 already has a lot of delay ...
From two months is 99% of the finished milestone (1.2).
It was 99% and 480 commits
Today 99% and 612 commits
This way you will never close the version.

I think maybe next week. Sorry for the delay.

Please don't close 1.2 before having merged #2276
That PR is to complete the OpenID support, which is new in 1.2.0

maybe we should create the release/v1.2 branch and release rc1 version. move the discussion to https://github.com/go-gitea/gitea/issues/2329

duplicate of #2283


Improve @api3/ois README

The README seems a bit underwhelming and could be improved at least by adding installation instructions.

I've decided to implement this now, since we will need to release new version of the OIS repo for https://github.com/api3dao/ois/issues/6 and I'd like a nicer README in the npm.


[mgmt] sphere release

https://github.com/Azure/sdk-release-request/issues/5061

API change check
APIView has identified API level changes in this PR and created following API reviews.
@azure/arm-sphere


API800 Support for Scope

Description
API 800 Support for Scope
Issues Resolved
NA
Check List

[x] New functionality includes testing.

[x] All tests pass for go 1.11.x + gofmt checks .

[x] New functionality has been documented in the README if applicable.

[x] New functionality has been thoroughly documented in the examples (please include helpful comments).
[X] New endpoints supported are updated in the endpoints-support.md file.

[X] Changes are documented in the CHANGELOG.

LGTM. Though attributes like created and modified don't make sense in Terraform.


Far Future Caching

It looks as though SassAndCoffee does not currently support far future caching. From what I can tell based on a brief inspection of the source, it currntly sets a max-age header to no longer than 1 hour. I don't see a codeless way to override that. Just curious if I am missing something, if this is intentional, or if its just something no one has gotten to.

I'm not sure of the behavior in the latest NuGet release, but if you're referring to the latest code you're correct.  I'll work on moving the caching settings to a cache profile in web.config which can be easily altered.

If you need this immediately, it should be possible with the code in the version2 branch.  Check out the web.config file in the WebTest project and the PipelineHandler in the ASP.Net project to see how it works.

nice. great turnaround!


Get initial package(s) filenames from loader.Program

Assuming a linter implements Checker as follows, but needs the original filenames because it doesn't actually operate on the AST, but rather does raw text operations like checking line-length, spelling etc. Does it really need to get the filenames via token.Position?
func Checker(lprog *loader.Program, prog *ssa.Program) {
       for _, info := range lprog.InitialPackages() {
                for _, file := range info.Files {
                        pkg := file.Package
                        pos := lprog.Fset.Position(pkg)
                        fmt.Println(pos.Filename) // do something with files
                }
        }
}

Am I missing something obvious?

Does it really need to get the filenames via token.Position?

What exactly do you mean by this? Does it really need so much boilerplate just to get the filename? Or is as simple as just using the fileset to obtain the filename?

The boilerplate. I somehow thought an ast.File knows about its name, but it looks like it doesn't.

Yeah it would be convenient, but having said that, maybe it's a convenience function lint could provide.

It actually makes sense that ast.File doesn't know about the actual file, so there's an abstraction from the underlying file system. However, I find the ast.File.Name field is a bit misnamed - it contains the package name, although you would expect to get the filename. But let's not get side-tracked.
So if we go with the three linters levels @mvdan suggested in #9, then level 0 linters either:

Each need to run the above code to get the filenames (iterate packages and files, query Position)
metalint passes the filenames through the Checker interface (if requested, at least)
lint provides a convenience function like InitialFiles (as suggested above)

The more I think about it, the more I realise we always want to use go/loader. It handles special import paths for us for example, like std, cmd/foo or all. And for linters that don't need ASTs, it's just some extra unnecessary work - all they need is still there.
I agree that, for linters that need filenames of the Go files, having to do that boilerplate is a bit repetitive. Adding a helper func like InitialFiles sounds fine to me.

Let's hold this off until go/loader gets overhauled in a few months. If such a helper func is still useful in the new API, and it won't get included in go/loader itself, we can add it here instead.

Still no news from the go/loader overhaul, unfortunately. Hopefully something will happen soon :)

Now that go/packages and go/analysis are a thing, this repo lost its purpose.


Broken link

The README.md for this Github repository has a broken link that needs to be updated.

Thanks!

Thanks!

Thanks!


Cheatsheet syntax to retrieve Secret values with dashes (-) in their key names

This template syntax was not obvious to me until someone pointed it out on stackexchange, it should be in the cheatsheet for future users. Because trying to retrieve a value with dashes in its key-name using the normal template syntax will result in an error.
I placed the example under the other example that also deals with "non-standard" characters in key names like period.

@stemid , the CLA must be signed before this PR can be reviewed
Please sign the CLA
https://github.com/kubernetes/community/blob/master/CLA.md

Hey @krousey, you are in the reviewers list, how do you think about this suggestion?
/cc @krousey
The labels are missing due to no CLA signed.
/language en

/sig docs

Hey @krousey, you are in the reviewers list, how do you think about this suggestion? /cc @krousey
The labels are missing due to no CLA signed. /language en

Why do people keep saying I haven't signed the CLA? I have definitely signed it.

The labels are missing due to no CLA signed.
/language en

Why do people keep saying I haven't signed the CLA? I have definitely signed it.

I know you already signed CLA when I reviewing your PR.
What I am saying is that CLA hasn't been signed at the beginning, so the bot didn't automatically add language label and assign reviewer.

/lgtm

Preview:
https://deploy-preview-32491--kubernetes-io-main-staging.netlify.app/docs/reference/kubectl/cheatsheet/#viewing-finding-resources

I have not tested this template. @stemid, did you evaluate the command and template? Thanks.

Sure I have tested it verbatim.
kubectl create secret generic my-secret --from-literal=key-name-with-dashes=supersecret
kubectl get secret my-secret --template='{{index .data "key-name-with-dashes"}}'
c3VwZXJzZWNyZXQ=

/approve


Remote Validation, Submit button missing in POST

I'm trying with JQuery 1.4.4 and Validation Plugin 1.9,
When I click Submit button from a page that has remote validation, the submit button is not include in POST fields.
This issue happen only when user click submit button without set cursor or change anything to the field that has remote validation.
Below is the code that I tested
<?php
	var_dump($_POST);
	if(isset( $_POST ['btnupdate'] ))
	{
		echo 'POST success';
	}
?>

	<form method="post" id="frmeditfriend" name="frmeditfriend">
		Email :
		<input type="text"<EMAIL_ADDRESS>id="txtemail" name="txtemail" />

			<input type="submit" id="btnupdate" name="btnupdate" value=" Update " />

	</form>

In the friend_exec.php, for testing I put below code
<?php
	echo 'true';
?>

Upgrading to the jQuery Validation Plugin v1.13.1 didn't fix this for me.
My solution was simple assuming the server side script looked for $_POST['submit'] which was the name of my submit field. Just create a hidden field with same name when the submit button is clicked and write it into your form. The server side (PHP in my case) can use this instead.
        $('<input>').attr({
                        type: 'hidden',
                        name: 'proceed',
                        value: '1'
                    }).appendTo('form');
    });```

abrookbanks, your work around worked for me thanks  !

@milanraval pleased it helped someone


Issues and Projects: Dependencies

Summary
We are providing users with the ability to track dependencies across issues. This will enable you to visualize the sequence in which issues need to be addressed.
Intended Outcome
We have heard your feedback that dependencies are important for advanced planning and tracking purposes. We want to enable your teams to power up your workflows.
How will it work?
You will be able to set, manage, and view dependencies in issues. These dependencies will then also be reflected in your project views.

Please continue to refer to our updated Public Roadmap for the latest ships, including updates on the continuation of these projects.

For updates, please refer to this updated roadmap issue: https://github.com/github/roadmap/issues/1036