the experimental results are not as good as the results presented in your paper?

Dear sir:
I repeated your open source transformer experiment, but found that the experimental results are not as good as the results presented in your paper and log files, its mr performance is excellent, but r performance is not good. Is there a problem of large fluctuations in this training process, because I see that your loss has been dynamically adjusted. Do you have any adjustment suggestions?
log.txt

I carefully checked the uploaded code and re-ensured its correctness.
I read your log file and found that the recall dropped by about 1 point, possibly due to the device or random seed. Generally speaking, the results of my experiment on 3090 are the best. I suggest running more times.  The attached log file results are shown in the paper
log.txt

as you say, i run the code in v100, haha, if that's the case, it would be very interesting. The random seed problem is also a baffling one. I will try it again. By the way, could you please help me to check my log file to see if there are any additional operating errors?

If you use the code and script that I uploaded, there should be no error. The model and log file I shared in README.md are completely executed by the uploaded code and script. And I didn't find any wrong operation in your log file

If you use the code and script that I uploaded, there should be no error. The model and log file I shared in README.md are completely executed by the uploaded code and script. And I didn't find any wrong operation in your log file

ok thank you very much, i will try.


position embedding only operate in visiable patch

I am learning with your work，I think it is a great job, thanks for your contribution.
Now I am learning your code, I have a simple question in the forward function of MaskTransformer class,
    def forward(self, neighborhood, center, noaug = False):
        # generate mask: True: masked patch; False: visiable patch
        if self.mask_type == 'rand':
            bool_masked_pos = self._mask_center_rand(center, noaug = noaug) # B G
        else:
            bool_masked_pos = self._mask_center_block(center, noaug = noaug)

        # get the embedding token of each group: shape(B G C)
        group_input_tokens = self.encoder(neighborhood)  #  B G C

        batch_size, seq_len, C = group_input_tokens.size()

        x_vis = group_input_tokens[~bool_masked_pos].reshape(batch_size, -1, C) # visiable patch token
        # add pos embedding
        # mask pos center
        masked_center = center[~bool_masked_pos].reshape(batch_size, -1, 3)
        pos = self.pos_embed(masked_center) # pos embedding only operates in visiable patch
        # pos_embed input: masked center(B, G, 3)
        # pos_embed output: masked center position token(G, G, )

        # transformer
        x_vis = self.blocks(x_vis, pos)
        x_vis = self.norm(x_vis)

        return x_vis, bool_masked_pos

the bool_masked_pos: True: masked patch; False: visiable patch
so group_input_tokens[~bool_masked_pos] extracts the visiable patch token
but in code center[~bool_masked_pos] extracts the masked patch center coordinate
but I found that the dim 2 of x_vis is 26, the dim 2 of masked_center is 26 too in the process of debugging
I think center[~bool_masked_pos] extracts the visiable patch center coordinate actually
Can you give me some suggestions. Thank you sincerely

Hi,
Yes, we drop masked patches in the encoder when doing pre-training. So we only need to get coordinates for visible patches. See the framework figure in our paper to get a better understanding.

'I think center[~bool_masked_pos] extracts the visible patch center coordinate actually'
Yes, your understanding is correct. But what do you mean by 'but in code center[~bool_masked_pos] extracts the masked patch center coordinate'?

Oh, that's just beacuse I found that the variable name is masked_center  for code  center[~bool_masked_pos].reshape(batch_size, -1, 3), I didn't make myself clear, sorry.😂


SARAALERT-334: 508 Compliance

Description
Jira Ticket: SARAALERT-334
UI improvements have been made to meet 508 Compliance. Necessary improvements are outlined in the Accessibility Audit section in Communicate Health report (excluding #1): https://mitre.sharepoint.com/sites/CoVDT/Shared Documents/General/Product Owner Materials/Requirements/CommunicateHealth Audit/MITRE-Sara-Alert_Discovery-Summary-Memo_2020.09.29_UPDATED.docx?web=1
This includes the changes made by ORAU in this PR
Code to include this in the CI will be included in a separate PR.
Important Changes
Please list important files (meaning substantial or integral to the PR) along with a list of the general changes that should be highlighted for reviewers.
Too many to even count - mostly small behind the scenes changes.
Testing
This fix was tested on the following browsers (submitter must check all those that apply):

[x] Chrome
[ ] Firefox
[ ] Safari
[ ] IE11

Please describe the tests needed to verify your changes. Provide instructions for reproducing these tests. List any relevant details for your test configuration.

Finding 6 - Do the search bars for reports, lab results, etc. need a label?
Finding 9 - I could have missed this but did you adjust the background and foreground for the warning text?
Finding 17 - Do the select for reports, lab results, etc. need a label?

Finding 6 - Do the search bars for reports, lab results, etc. need a label?
Finding 9 - I could have missed this but did you adjust the background and foreground for the warning text?
Finding 17 - Do the select for reports, lab results, etc. need a label?

Finding 6: these should be fine because they are contained in a  tag (see below)

Finding 9: this had previously been changed (by myself in a different PR).  if you pick a monitoree that is non-reporting and scroll to the reports section, the workflow is a badge now - it used to be colored text
Finding 17: same as finding 6 - these are also rendered with a  tag

I was able to spend a decent amount of time looking through it and it looks good to me.

@sgober Can you please make the requested changes on the remaining threads above and then squash the commits for this PR?

@sgober Can you please rebase this off of 1.19.0 once more (since it has been updated), make the requested changes on the remaining threads above, and then squash the commits for this PR?

all set

not sure why that test is failing... I re-ran it 3 times

not sure why that test is failing... I re-ran it 3 times

This has been intermittently failing - not sure why you've gotten unlucky


Replace ExecutionState with kill method on RowReceiver

Previously the executionState had a isKilled flag which was used in
some RowReceiver implementations to interrupt them. To do so they
internally used fail which wasn't designed to be called asynchronous.
This led to problems, e.g. if a context was killed during a fail or
finish was being executed.

otherwise ack


Exercises must sbt compile at CI stage

... to be aware about potential issues, like in this case :P . I've just realized about it :(
This is needed because the compile task has been overridden.
In this case, we'll see that master branch is broken :P
As side note, this is happening also in the rest of the exercises libraries.
CC @raulraja @dialelo

LGTM


apple/t2: update to kernel 6.7.7 and add tiny-dfr service

Description of changes

Update the linux kernel with t2 patches to 6.7.7
Removed fix-keyboard-backlight-and-touchbar.sh as this should no longer be needed.
Added the package and service tiny-dfr as the new patches removed this functionality from a kernal module and placed it in userland. Kekrby's fork is used since the official one does not support t2 macs.

Things done

[x] Tested the changes in your own NixOS Configuration
[x] Tested the changes end-to-end by using your fork of nixos-hardware and
importing it via <nixos-hardware> or Flake input

Any testing would be appreciated especially anyone that uses apple-set-os-loader as i do not use this and have not tested with it.

@mergify queue


Fixed failure when a user's home dir is a drive root on Windows

Note that the bug remains under Python 2
Addresses #83

The build failure looks unrelated

@rayluo - this now contains your change too


use HPC to train deep neural networks

traditional HPC use MPI to do large scale computing intensive tasks. Is it possible to train using mpi interface?

For your question in general, I think the answer is yes. MPI is good in bandwidth but bad in latency, so it is suitable for blob data transmission which frequently happens in data parallelism.
You could use MPI to start parameter server and worker instance (your mxnet program) like here. But the underlying communication is not based on MPI.
@mli do you have any comments?

@jermainewang Latency depends largely on the underlying infrastructure and MPI implementation. On a HPC cluster with a good (infinband) interconnect MPI should have good performance.

@vchuravy gotcha. I think within current framework, what we could do is to implement two special dataflow operators: one for MPISend, one for MPIRecv. But this is only the first step. For MPIRecv task, there is no upstream task so it (and its memory space) will be created and stay there for a long time. One way to deal with it is the technique mentioned in tensorflow paper that delay the schedule of MPIRecv task until MPISend task is launched.

Also crossref #977.
I think what would be really interesting is CUDA aware MPI [1,2]. Using that could actually give quite a speedup to communication.
[1] http://devblogs.nvidia.com/parallelforall/introduction-cuda-aware-mpi/
[2] https://www.open-mpi.org/faq/?category=runcuda


Run ASP.net core on Raspberry Pi 3 with Windows 10 Iot

I am trying to run asp.net core app on Raspberry pi 3 which runs Windows10 IoT .What I have done so far is:

Created a simple Web Api application in Asp.net core in local Windows 10 machine using visual studio.
removed type:platform from project.json file  (for self contained deployment)
built and published the application using dotnet publish -c release -r win10-arm
copied the published files to UNC share folder in path
opened the port 5000 in pi powershell session  netsh advfirewall firewall add rule name="DNX Web Server port" dir=in action=allow protocol=TCP localport=5000
typed 'C:\PROGRAMS\dnxpi\RasberryService.exe' in powershell session to pi

But it errors
Program 'RasberryService.exe' failed to run: The operation completed successfully.
+ CategoryInfo          : ResourceUnavailable: (:) [], ApplicationFailedException
+ FullyQualifiedErrorId : NativeCommandFailed

source code is present in my repo It is just a visual studio new web api project.
Thanks in Advance!!

Duplicate of https://github.com/aspnet/Home/issues/1531


Register

@JuliaRegistrator register

Registration pull request created: JuliaRegistries/General/56312
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.1.0 -m "<description of version>" 75b4d4bc7d114b669c639bf1ac34bd0f35e0e9be
git push origin v0.1.0

@JuliaRegistrator register

Registration pull request created: JuliaRegistries/General/65477
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.1.2 -m "<description of version>" 0cd4e26e5fee0f604827d31e9681aeba0fb1c42e
git push origin v0.1.2


Tag a release for pre-aff 4.0?

Could you tag a release for a766d7bf8c097ff9b54a6fc518f0055065490e2c so I can add this to the current package-set?

Yeah, sure. There's now a v1.0.0 for that commit (https://pursuit.purescript.org/packages/purescript-spec-mocha/1.0.0) and v2.0.0 for current master.

Great, thanks!


[Question] Thread safe way to use grpc bidi stream with envoy grpc async client inside a http filter.

Title: Thread safe way to use grpc bidi stream with envoy grpc async client inside a http filter.
Description:
I have written a http filter for web socket connections that is capturing websocket frames and publishing metadata related to these frames through a grpc bidi stream with envoy grpc client. According to the filter logic, there may be a possible race condition that will occur on Grpc::AsyncStream stream_{};. So the below code segment explains about the possible race condition.
From decodeData(Buffer::Instance& data,bool) in my http filter, I'm calling a method in my helper class which publish metadata through a grpc bidi stream. Helper class has a pointer to Grpc::AsyncStream stream_{};
FilterDataStatus HttpSampleDecoderFilter::decodeData(Buffer::Instance& data, bool) {
    HelperClass::publishMetadataAsync(data);
    return FilterDataStatus::Continue;
}

My HelperClass implements Grpc::AsyncStreamCallbacks and has methods onMessage() and onRemoteClose. Also the publishMetadataAsync method too.
void HelperClass::publishMetaDataAsync(Buffer::Instance& data){
    stream_->sendMessage(params);
}

void HelperClass::onRemoteClose(Grpc::Status::GrpcStatus status, const std::string& message) {
    stream_ = nullptr;
    ENVOY_LOG(trace, "onRemoteClose : {} {}", status, message);
};

So my concern is that when onRemoteClose() gets called when the remote upstream gets disconnected, there maybe a possibility of calling stream_->sendMessage(params); at the same time.Since I assign stream_ = nullptr in onRemoteClose, calling a method on nullptr makes a segmentation fault. And I don't think a simple if condition to check stream_!= nullptr will work because I assume these two happen in 2 different threads. I'm not sure whether it's a good choice to use mutex to handle stream_ in a thread safe way because envoy encourages non-blocking thread model.
So my questions are,

Is my concern valid ?
How to handle this kind of a scenario by following envoy best practices ?

The threading here depends on where you're allocating the gRPC client, if it's done as part of the filter then it should end up on the same thread as the filter, so the null check should be sufficient. If you are trying to put it on another thread (e.g. the main thread) then you'd probably be posting the sends to the relevant dispatcher, which means that you'd also be okay with just a null check since the send and the remote close callback is still running on the same thread.

@snowp I'm creating a gRPC async client for each of the filter objects that get created. So I think just doing a nullptr check will do the job. But since you mentioned about dispatching to main thread, I'm a little bit concerned about my implementation. So basically , according to my implementation a gRPC bidi stream will be created for each of the filter objects that gets created. Since the lifetime of a filter object is equal to the lifetime of a web socket connection, 1000 web socket connections means 1000 bidi streams from envoy to the external grpc service. Will that be a problem in terms of envoy memory management ?
Also I read this from envoy docs,
Maximum concurrent streams allowed for peer on one HTTP/2 connection. Valid values range from 1 to<PHONE_NUMBER> (2^31 - 1) and defaults to<PHONE_NUMBER>.
So I assumed I'm safe with having high number of concurrent streams in terms of connection management. But not sure in terms of memory management. Thanks a lot for the help.


What about Az?

AzureRM modules are legacy. Why still not changed to use Get/Set-AzAutomationVariable?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: fbcf48d3-ba48-75e5-092d-40317111b389
Version Independent ID: 055126f7-51a5-37b3-a447-829b75c694b8
Content: Variable assets in Azure Automation
Content Source: articles/automation/shared-resources/variables.md
Service: automation
Sub-service: shared-capabilities
GitHub Login: @MGoedtel
Microsoft Alias: magoedte

Thanks for your comment. The feedback has been shared with the content owner for further review. Thanks for your patience.


Instructor onboarding

Motivation
Create a Form to get information form instructor
Information is stored in Zustand
Card can get rendered out of stored information
Wizzard excluded due to size
Issues closed
closes #4, opens #18 image upload, #20 Form Wizzard and #19 Form Design Feature

s

Sonst passts


Separate select and delete queries for m2m unrelate operations

This is an attempt on working around ER_CANT_UPDATE_USED_TABLE_IN_SF_OR_TRG mysql error when executing a db trigger on a join table in m2m relation

extract a subquery reading related ids to separate query run before the delete query for m2m unrelate operation

oh god. I was supposed to set up this PR on my fork only, not here 😓 I'm sorry.

Coverage decreased (-0.04%) to 97.132% when pulling cb3813bbda1002291c6c111e60d4e9d8c6bb24d7 on ovos:m2m-delete-queries into 5aa7dd0f2d7e6380388c8df8d118a8d3fcff3fc0 on Vincit:master.


Uncaught TypeError: Cannot read property 'top' of undefined

[Enter steps to reproduce below:]

...
...

Atom Version: 0.166.0
System: linux 3.13.0-43-generic
Thrown From: minimap package, v3.3.4
Stack Trace
Uncaught TypeError: Cannot read property 'top' of undefined
At /home/albert/.atom/packages/minimap/lib/minimap-view.coffee:353

TypeError: Cannot read property 'top' of undefined
  at MinimapView.module.exports.MinimapView.updateScrollY (/home/albert/.atom/packages/minimap/lib/minimap-view.coffee:353:64)
  at MinimapView.updateScrollY (/home/albert/.atom/packages/minimap/lib/minimap-view.coffee:1:1)
  at MinimapView.module.exports.MinimapView.updateScroll (/home/albert/.atom/packages/minimap/lib/minimap-view.coffee:368:6)
  at MinimapView.updateScroll (/home/albert/.atom/packages/minimap/lib/minimap-view.coffee:1:1)
  at /home/albert/.atom/packages/minimap/lib/minimap-view.coffee:268:8

Commands

Config
{
  "core": {
    "themes": [
      "trendy-light-ui",
      "suranyami-light-syntax"
    ]
  },
  "minimap": {
    "plugins": {
      "git-diff": true
    }
  }
}

Installed Packages
# User
atom-cli-diff, v0.6.4
atom-python-debugger, v0.1.0
color-picker, v1.2.5
compare-files, v0.2.6
javascript-snippets, v1.0.0
language-diff, v0.2.0
language-docker, v1.1.1
language-pgsql, v0.2.0
language-python-django, v0.3.1
language-sql-mysql, v0.3.1
linter, v0.7.4
linter-js-yaml, v0.1.3
linter-xmllint, v0.0.5
minimap, v3.3.4
minimap-git-diff, v3.0.8
script, v2.13.0
suranyami-light-syntax, v0.8.0
trendy-light-ui, v0.28.1

# Dev
No dev packages

/cc @atom/core

Please update to the latest version (3.5.4), yours is now obsolete.

Thank's I solved deleting the ~/.atom/packages/minimap folder and reinstalling it with package manager. There was a git diffs related folder that i deleted as well


bug: 2.4 changes schema key names

Summary
There was a change in this PR (https://github.com/litestar-org/litestar/commit/219355c0e322fab41c921c56ca97d356b7ef868b#diff-6cdcc2ab6bdeda3d72588f3b65db0c437f7ba9cad43892829e75c4d701f9e658R659-R661) that updated the way schema keys are generated for the OpenAPI schema.
Where we originally had something like UserAccount as the model name, we know have app_domain_accounts_UserAccount or something similar.
Basic Example
MCVE
import json

from litestar import Litestar, get
from litestar.testing import TestClient
from pydantic import BaseModel

class SampleOne(BaseModel):
    property_one: str

class SampleTwo(BaseModel):
    __module__ = ""
    property_one: str

@get("/one")
async def test_handler_one() -> SampleOne:
    return SampleOne(property_one="test")

@get("/two")
async def test_handler_two() -> SampleTwo:
    return SampleTwo(property_one="test")

app = Litestar(route_handlers=[test_handler_one, test_handler_two], debug=True)

with TestClient(app=app) as client:
    response = client.get("/schema/openapi.json")
    print(json.dumps(response.json()["components"]["schemas"], indent=2))

This outputs:
{
  "main_SampleOne": {
    "properties": {
      "property_one": {
        "type": "string"
      }
    },
    "type": "object",
    "required": [
      "property_one"
    ],
    "title": "SampleOne"
  },
  "SampleTwo": {
    "properties": {
      "property_one": {
        "type": "string"
      }
    },
    "type": "object",
    "required": [
      "property_one"
    ],
    "title": "SampleTwo"
  }
}INFO - 2023-11-29 18:43:59,780 - httpx - _client - HTTP Request: GET http://testserver.local/schema/openapi.json "HTTP/1.1 200 OK"

Notice that for the SampleOne model the generated schema key name is main_SampleOne.
After reviewing the PR as far as I can understand it you are now making use of class metadata to get name of the model, whereas previously you were using the schema title field.
The only workaround I've been able to come up with can be seen in the the SampleTwo model where I set __module__ = "". This allows me to get only the class name as the schema key as can be seen in the output.
Drawbacks and Impact
This is a breaking change for us as we use an OpenAPI typescript generator from the generated openapi.json
and the named types are now different than what it expects.
Unresolved questions

Is there any other way to define the model name other than the workaround presented here
If you take on this feature request then the implementation details are up to you but perhaps this could be achieved with a new dunder method on the class and if it's there, use it otherwise use the __module__.__name__

[!NOTE]
While we are open for sponsoring on GitHub Sponsors and
OpenCollective, we also utilize Polar.sh to engage in pledge-based sponsorship.
Check out all issues funded or available for funding on our Polar.sh Litestar dashboard

If you would like to see an issue prioritized, make a pledge towards it!
We receive the pledge once the issue is completed & verified
This, along with engagement in the community, helps us know which features are a priority to our users.

I think we should consider this a bug fix

Agree

My suggestion would be that we revert to the original behaviour and hide the new one behind a feature flag. The change itself is fairly straightforward, and it's mostly our tests that would need to be adjust to test for both versions of this.

Maybe we can have our cake and eat it too by using the complex naming only if there is a collision detected. So, where we would have raised an error before 2.4, we would only then introduce the complex naming. That would mean that any pre-2.4 code should still continue to work as planned, and only new code that leverages 2.4's feature to support same-named-types will notice any difference in the generated schema.
And then, I think we should also consider making the complex naming only long enough, i.e, if two colliding types have full names like "a.b.c.Model" and "a.b.d.Model" then "c_Model" and "d_Model" would be sufficient.

I think we should consider this a bug fix

Agree

My suggestion would be that we revert to the original behaviour and hide the new one behind a feature flag. The change itself is fairly straightforward, and it's mostly our tests that would need to be adjust to test for both versions of this.

Maybe we can have our cake and eat it too by using the complex naming only if there is a collision detected. So, where we would have raised an error before 2.4, we would only then introduce the complex naming. That would mean that any pre-2.4 code should still continue to work without change, and only new code that leverages 2.4's feature to support same-named-types will notice any difference in the generated schema.
And then, I think we should also consider making the complex naming only long enough, i.e, if two colliding types have full names like "a.b.c.Model" and "a.b.d.Model" then "c_Model" and "d_Model" would be sufficient.

After looking at the problem closer, one issue to overcome to achieve my solution is that we add the schemas and build references route by route, operation by operation. So, this means that at the time any single schema is being added, we don't yet know about all of the schemas in order to determine the minimum unique key name. One way I can overcome this is to keep the current behavior of adding the full path keys, and then post-process at the end, trimming down the keys to the minimum required length to remain unique. Will also need to take care of the case where a route is added after the openapi schema has been generated.
To handle this extra layer of processing and state tracking I'm building a suite of factory functions for our openapi generation, which also has the benefit of tidying up the passing around of state between all of the functions in the _openapi namespace. This is being done in #2805, which I'll prob try to get merged before attempting to specifically address this issue, as even if we decide to go with the feature flag approach, I think that refactoring stands on its own merits.

Thanks for the comments.
In the interim, before the proposed solution makes it into a release, any comments on the workaround I am using? Is it safe to continue with it or is there are better way to workaround it you can think of?

Thanks for the comments.
In the interim, before the proposed solution makes it into a release, any comments on the workaround I am using? Is it safe to continue with it or is there are better way to workaround it you can think of?

Is the workaround that you are overriding the __module__ attribute?
There's a good chance that will introduce issues if you are using from __future__ import annotations in your code, as that module attribute is required to get the namespace to resolve the type annotations within.
If you aren't doing that and it doesn't break anything else for  you then sure, but we wouldn't want to encourage that as anything more than a temporary workaround.


Build Failed on Arch exactly following the README

Bug Report
1. Minimal reproduce step (Required)
> ninja tiflash

[0/40] Building TiFlash Proxy using release profile
./release.sh
make[1]: Entering directory '/home/jigao/Workspace/tiflash/contrib/tiflash-proxy'
PROXY_ENABLE_FEATURES="portable sse test-engine-kv-rocksdb test-engine-raft-raft-engine cloud-aws cloud-gcp cloud-azure pprof-fp" ./build.sh
profile is release
engine is tiflash
prometheus metric name prefix is tiflash_proxy_
frame pointer is enabled
+ [[ -n 1 ]]
+ [[ 1 != \0 ]]
+ rustup component add rust-src
info: component 'rust-src' is up to date
+ cargo build --no-default-features --features 'portable sse test-engine-kv-rocksdb test-engine-raft-raft-engine cloud-aws cloud-gcp cloud-azure pprof-fp' --release -Z build-std=core,std,alloc,proc_macro,test --target=x86_64-unknown-linux-gnu -Z unstable-options --out-dir=target/release
   Compiling snappy-sys v0.1.0 (https://github.com/busyjay/rust-snappy.git?branch=static-link#8c12738b)
   Compiling grpcio-sys v0.10.1+1.44.0
error: failed to run custom build command for `snappy-sys v0.1.0 (https://github.com/busyjay/rust-snappy.git?branch=static-link#8c12738b)`

Caused by:
  process didn't exit successfully: `/home/jigao/Workspace/tiflash/contrib/tiflash-proxy/target/release/build/snappy-sys-4bb1c1b3c53e7d57/build-script-build` (exit status: 101)
  --- stdout
  running: "/usr/bin/cmake" "/home/jigao/.cargo/git/checkouts/rust-snappy-0ed33e4b7b96fc57/8c12738/snappy-sys/snappy" "-DCMAKE_INSTALL_PREFIX=/home/jigao/Workspace/tiflash/contrib/tiflash-proxy/target/x86_64-unknown-linux-gnu/release/build/snappy-sys-3c3ee3f3563c6036/out" "-DCMAKE_C_FLAGS= -ffunction-sections -fdata-sections -fPIC --target=x86_64-unknown-linux-gnu -w -fuse-ld=lld -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer" "-DCMAKE_C_COMPILER=/usr/bin/clang" "-DCMAKE_CXX_FLAGS= -ffunction-sections -fdata-sections -fPIC --target=x86_64-unknown-linux-gnu -w -fuse-ld=lld -stdlib=libc++ -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer" "-DCMAKE_CXX_COMPILER=/usr/bin/clang++" "-DCMAKE_ASM_FLAGS= -ffunction-sections -fdata-sections -fPIC --target=x86_64-unknown-linux-gnu -w -fuse-ld=lld -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer" "-DCMAKE_ASM_COMPILER=/usr/bin/clang" "-DCMAKE_BUILD_TYPE=Release"
  -- The C compiler identification is Clang 14.0.6
  -- The CXX compiler identification is Clang 14.0.6
  -- Detecting C compiler ABI info
  -- Detecting C compiler ABI info - failed
  -- Check for working C compiler: /usr/bin/clang
  -- Check for working C compiler: /usr/bin/clang - broken
  -- Configuring incomplete, errors occurred!
  See also "/home/jigao/Workspace/tiflash/contrib/tiflash-proxy/target/x86_64-unknown-linux-gnu/release/build/snappy-sys-3c3ee3f3563c6036/out/build/CMakeFiles/CMakeOutput.log".
  See also "/home/jigao/Workspace/tiflash/contrib/tiflash-proxy/target/x86_64-unknown-linux-gnu/release/build/snappy-sys-3c3ee3f3563c6036/out/build/CMakeFiles/CMakeError.log".

  --- stderr
  CMake Error at /usr/share/cmake/Modules/CMakeTestCCompiler.cmake:69 (message):
    The C compiler

      "/usr/bin/clang"

    is not able to compile a simple test program.

    It fails with the following output:

      Change Dir: /home/jigao/Workspace/tiflash/contrib/tiflash-proxy/target/x86_64-unknown-linux-gnu/release/build/snappy-sys-3c3ee3f3563c6036/out/build/CMakeFiles/CMakeTmp

      Run Build Command(s):/usr/bin/make -f Makefile cmTC_f752e/fast && make[2]: Entering directory '/home/jigao/Workspace/tiflash/contrib/tiflash-proxy/target/x86_64-unknown-linux-gnu/release/build/snappy-sys-3c3ee3f3563c6036/out/build/CMakeFiles/CMakeTmp'
      /usr/bin/make  -f CMakeFiles/cmTC_f752e.dir/build.make CMakeFiles/cmTC_f752e.dir/build
      make[3]: Entering directory '/home/jigao/Workspace/tiflash/contrib/tiflash-proxy/target/x86_64-unknown-linux-gnu/release/build/snappy-sys-3c3ee3f3563c6036/out/build/CMakeFiles/CMakeTmp'
      Building C object CMakeFiles/cmTC_f752e.dir/testCCompiler.c.o
      /usr/bin/clang   -ffunction-sections -fdata-sections -fPIC --target=x86_64-unknown-linux-gnu -w -fuse-ld=lld -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer  -MD -MT CMakeFiles/cmTC_f752e.dir/testCCompiler.c.o -MF CMakeFiles/cmTC_f752e.dir/testCCompiler.c.o.d -o CMakeFiles/cmTC_f752e.dir/testCCompiler.c.o -c /home/jigao/Workspace/tiflash/contrib/tiflash-proxy/target/x86_64-unknown-linux-gnu/release/build/snappy-sys-3c3ee3f3563c6036/out/build/CMakeFiles/CMakeTmp/testCCompiler.c
      Linking C executable cmTC_f752e
      /usr/bin/cmake -E cmake_link_script CMakeFiles/cmTC_f752e.dir/link.txt --verbose=1
      /usr/bin/clang  -ffunction-sections -fdata-sections -fPIC --target=x86_64-unknown-linux-gnu -w -fuse-ld=lld -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer  -rdynamic CMakeFiles/cmTC_f752e.dir/testCCompiler.c.o -o cmTC_f752e
      clang-14: error: invalid linker name in argument '-fuse-ld=lld'
      make[3]: *** [CMakeFiles/cmTC_f752e.dir/build.make:100: cmTC_f752e] Error 1
      make[3]: Leaving directory '/home/jigao/Workspace/tiflash/contrib/tiflash-proxy/target/x86_64-unknown-linux-gnu/release/build/snappy-sys-3c3ee3f3563c6036/out/build/CMakeFiles/CMakeTmp'
      make[2]: *** [Makefile:127: cmTC_f752e/fast] Error 2
      make[2]: Leaving directory '/home/jigao/Workspace/tiflash/contrib/tiflash-proxy/target/x86_64-unknown-linux-gnu/release/build/snappy-sys-3c3ee3f3563c6036/out/build/CMakeFiles/CMakeTmp'

    CMake will not be able to correctly generate this project.
  Call Stack (most recent call first):
    CMakeLists.txt:2 (project)

  thread 'main' panicked at '
  command did not execute successfully, got: exit status: 1

  build script failed, must exit now', /home/jigao/.cargo/registry/src/github.com-1ecc6299db9ec823/cmake-0.1.45/src/lib.rs:894:5
  note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
warning: build failed, waiting for other jobs to finish...
error: build failed
make[1]: *** [Makefile:178: build] Error 101
make[1]: Leaving directory '/home/jigao/Workspace/tiflash/contrib/tiflash-proxy'
make: *** [Makefile:194: release] Error 2
FAILED: /home/jigao/Workspace/tiflash/contrib/tiflash-proxy/target/release/libtiflash_proxy.so
cd /home/jigao/Workspace/tiflash/contrib/tiflash-proxy && /usr/bin/cmake -E env CC=/usr/bin/clang CXX=/usr/bin/clang++ CXXSTDLIB=c++ CMAKE=/usr/bin/cmake "CFLAGS=-w -fuse-ld=lld" "CXXFLAGS=-w -fuse-ld=lld -stdlib=libc++" "RUSTFLAGS=-C rpath=yes -C linker=/home/jigao/Workspace/tiflash/build/contrib/tiflash-proxy-cmake/tiflash-linker" PROTOC=/home/jigao/Workspace/tiflash/build/contrib/protobuf-cmake/protoc PROTOC_INCLUDE=/home/jigao/Workspace/tiflash/contrib/protobuf/src ENGINE_LABEL_VALUE=tiflash make release
ninja: build stopped: subcommand failed.

2. What did you expect to see? (Required)
Build success.
3. What did you see instead (Required)
Build fails
4. What is your TiFlash version? (Required)
TiFlash: master
Cmake: 3.24.1
Clang 14
OS: Arch

/assign


The mul operation of Perbill doesn't work properly

I was trying to calculate multiplying a balance value by a ratio via Perbill, like Perbill::from_percent(90) * my_balance. But the mul operation of Perbill won't work for large values like when balance is u128 and 1 coin is 10^18.
As in the Mul impl of Perbill, rhs is converted to u64, and the output would be saturated to u64::MAX/1_000_000_000, which around 1.84 * 10^10. This make it impossible to multiply by a typical balance value.
https://github.com/paritytech/substrate/blob/e2fc0430ab3bcd644cded0353d4514611256ad3c/core/sr-primitives/src/lib.rs#L209-L212
Due to Currency::Balance :As<u64>, this implicit saturating is error prune for balances calculation, such as offline slash calculation in staking module if I don't misunderstand: https://github.com/paritytech/substrate/blob/fc836ada049f7e3bafca5414738bb14a027d1937/srml/staking/src/lib.rs#L1018-L1019
Expected behavior: Perbill should be capable of u64 and u128 multiplying, and saturate the output to be Output::max_value().

relating to https://github.com/paritytech/substrate/issues/1572 and https://github.com/paritytech/substrate/issues/1377.
A bit hacky but afaik, by design, Perbill and Permill are only safe and sound to be used for balances that are As<u64> (i.e. smaller than u64::max_value). @thiolliere even has a mention in one of the above discussion about these two being erroneous.
Though, in the grand scheme, the above issues won't solve everything. You have to take into account that the runtime cannot simply interpret a number which is larger than u128. Hence, if your balance is already a u128 and you want to multiply it by a ratio (in this case a scalar) there is always the possibility that it will overflow. I agree with your recommendation of making perbill/permill large enough to handle u128, but think of this:
Hasdow to calculate Percent(99) * X where X is a very large value in the scale of u128, say almost the max_value(). This is why one proposed suggestion is for the modules to always accept a Convert config type from the implementer to convert any balance to u64. Only then, applying any arithmetic with u128 will be safe.
You should also look into phragmen.rs in Staking as it is dealing with many similar problems w.r.t. accuracy.
cc @thiolliere @gnunicorn

parity-common provides U256 / U512 type, can we use them to do math so that U128 as U256 * 99 / 100 won't have overflowing intermediate state?
I know it have performance implication but a slow chain is better than a broken chain.
u64 is simply too small. People are going to trying to bridge ERC20 tokens into substrate chains and their types are U256. We need to support ERC20 balance types.

I am not sure if this is enough to justify bringing types such as U256/U512 into the runtime (keeping in mind that it should be used for much more fundamental purposes) but I like to see everyone's opinion on the discussion.
And I'll try to come up with some temporary ways to harden Per-X types for multiplication.

What are the downsides of bring U256/U512 into runtime?
Increase runtime size? I don't expect they will increase the side significantly.
They are slow? There must be some way to optimize the calculation performance if those types are actually causing performance issue.
Anything else I have missed?

I think user should defines its type. and Permill and Perbill should operate in those types.
optimisation is let to user.
This comment shows how to operate in the type: https://github.com/paritytech/substrate/issues/1377#issuecomment-476278870
Also it worth mention that it was the previous behavior before like in January

I think that balances should be u128.  Ideally, the runtime would use bignums, but that is slow.  Perhaps we could use trapping arithmetic?

I implemented operations in a better way in the PR, no overflow nor saturation, by differentiating operation on quotient and remainder https://github.com/paritytech/substrate/pull/2501


why circuitbreaker recordexceptions attribute in spring cloud does not work?

I am using cloud gateway circuitbreaker,  find the method  Mono run(Mono toRun, Function<Throwable, Mono> fallback)  only handle TimeoutException, the recordexceptions  of CircuitBreakerConfig does not work，such as  java.lang.RuntimeException。Looks like it is bug。

The code is there specifically in the reactive case because we are using Project Reactor's timeout api and R4J will not handle a timeout from reactor like it would if we were using an R4J timeout.

Thanks for your reply. When I used cloud gateway, the downstream uri has runtimexception, but R4J does not CircuitBreak. I try to config the RecordExceptions，add java.lang.RuntimeException. But it still doesn't work. I hope I can get your help and support. Thanks you very much.

Currently, only TimeOutException trigger CircuitBreak, other exceptions does not work. Is it a problem?

Currently, only TimeOutException trigger CircuitBreak, other exceptions does not work. Is it a problem?

Other exceptions also can be recorded. See here io.github.resilience4j.reactor.circuitbreaker.operator.CircuitBreakerSubscriber#hookOnError

Is the downstream service returning a specific status code when the exception is thrown?

Is the downstream service returning a specific status code when the exception is thrown?

If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed.

If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed.

Closing due to lack of requested feedback. If you would like us to look at this issue, please provide the requested information and we will re-open the issue.

Closing due to lack of requested feedback. If you would like us to look at this issue, please provide the requested information and we will re-open the issue.

Currently, only TimeOutException trigger CircuitBreak, other exceptions does not work. Is it a problem?

Other exceptions also can be recorded. See here io.github.resilience4j.reactor.circuitbreaker.operator.CircuitBreakerSubscriber#hookOnError. If you want the circuit breaker to work with the response status code, you can write a gateway filter to check the status code and throw custom exceptions. Then CircuitBreakerSubscriber#hookOnError will catch and record the failure request.

Hello! I had same problem like author has, and I had follow this advice and it was very helpful for me. But now circuitbreaker's fallback method is called every time when downstream service returning http status code exception, even ciruitbreaker state is closed. Is it possible to use this way to intercept not only TimeOutException and call fallback method only when circuitbreaker is open?

Please open a separate issue and provide a sample


Fix usecase for ImageButton with icon(_url) and name

Hi Chris,
Thanks for this great library! It makes my code to create a message for Hangouts Chat so much more readable :)
I found a small issue: it's not possible to create an ImageButton with both a icon(_url) and a name. The use case is that the name will be a tooltip for the image, when viewing the message in the browser. I've created this patch, including a test case that does fail without the fix.
Can you please merge and release a new version or give feedback if you do not agree with this proposal?
Thanks, Erik

Thanks for the contribution @ewjmulder. I've merged your changes and pushed a new version to PyPI.

Thanks @christippett !


Add collate comments and file for Chng-Zhi-Xuan

Collated code for #55 requirements

LGTM

@Chng-Zhi-Xuan After skimming the code, I think your code quality is fine. Please refer to this: nus-cs2103-AY1718S1/forum#173 for more tips to improve the code quality.


Bump FRR to 9.1.0

Is this a BUG FIX or a FEATURE ?:

Uncomment only one, leave it on its own line:
/kind bug
/kind cleanup
/kind feature
/kind design
/kind flake
/kind failing
/kind documentation
/kind regression

What this PR does / why we need it:
Bumping FRR to 9.1.0
Special notes for your reviewer:
Release note:

Bump FRR to version 9.1.0

[I] kka@f-t14s ~/w/g/m/frr-k8s (bumpfrr10 ✔)> rg "9\.0\.2"
RELEASE_NOTES.md
17:- FRR: bump to 9.0.2, allow to peer with localhost ([PR 118](https://github.com/metallb/frr-k8s/pull/118))

internal/frr/docker_test.go
27:     frrImageTag = "9.0.2"

hack/demo/demo.sh
16:docker run -d --privileged --network kind --rm --ulimit core=-1 --name frr --volume "$FRR_CONFIG":/etc/frr quay.io/frrouting/frr:9.0.2

any of this references to older frr image should be updated? I suppose the RELEASE note entry is added when releasing.

Why you do not bump in the latest frr?
skopeo list-tags docker://quay.io/frrouting/frr
{
    "Repository": "quay.io/frrouting/frr",
    "Tags": [
        "10.0.0",
        "10.0.1",

if there is a reason could we add it in the description of the commit?

[I] kka@f-t14s ~/w/g/m/frr-k8s (bumpfrr10 ✔)> rg "9\.0\.2"
RELEASE_NOTES.md
17:- FRR: bump to 9.0.2, allow to peer with localhost ([PR 118](https://github.com/metallb/frr-k8s/pull/118))

internal/frr/docker_test.go
27:     frrImageTag = "9.0.2"

hack/demo/demo.sh
16:docker run -d --privileged --network kind --rm --ulimit core=-1 --name frr --volume "$FRR_CONFIG":/etc/frr quay.io/frrouting/frr:9.0.2

any of this references to older frr image should be updated? I suppose the RELEASE note entry is added when releasing.

Good catch!

Why you do not bump in the latest frr?
skopeo list-tags docker://quay.io/frrouting/frr
{
    "Repository": "quay.io/frrouting/frr",
    "Tags": [
        "10.0.0",
        "10.0.1",

if there is a reason could we add it in the description of the commit?

I tried the latest, CI started failing for no clear reasons, so I assume latest is not super stable and went to the previous generation which still fixes my problem with importing vrfs.
I'll leave a comment.

Ack, then maybe you could state that not bumping to latest due to ci is failing), and what is the reason you bump (fixes my problem, which problem?)
Also we could have an issue "bump to FRR 10" to follow it

Ack, then maybe you could state that not bumping to latest due to ci is failing), and what is the reason you bump (fixes my problem, which problem?)

I won't state why I am not bumping on a later version as it might be obsoleted / fixed when we look at it in the future.
Hopefully, 10.x will be stable and pass in our CI in the future.

Also we could have an issue "bump to FRR 10" to follow it

Filed https://github.com/metallb/frr-k8s/issues/165 , but not sure I want us to work / bump on that any time soon.


Imports fail for github:  and npm:  dependencies

It seems karma-systemjs doesn't understand the registry mappings for github and npm.
Unhandled rejection (SystemJS) XHR error (404 Not Found) loading<EMAIL_ADDRESS>

This kind of urls doesn't seem to be manageable by karma proxies, so I was hoping that karma-systemjs would deal with them.

Update: it seems this happens because jspm v0.17 creates a config with many sections (devConfig, nodeConfig) in addition to the global settings. Also, it calls SystemJS.config twice.
I got through this one by adding:
     "github:": "jspm_packages/github/",
      "npm:": "jspm_packages/npm/",

to the paths section of my karma.systemjs.config


help dfu mode not booting iphone 7 plus liunx 20.04

hello i have this iphone 7 plus after doing it and downgrading to 14.8 i cant boot it up the power + sound button also when i try to run the command --boot it gives me this error [libusb] Waiting for the USB handle with VID: 0x5AC, PID: 0x1227
CPID: 0x8010
Found the USB handle.
Stage: PATCH
ret: true
for anything i do and i also tryed to re downgrade but it still gives the same error and jailbreak but im thinking that the iphone is dead and also its it dfu mode

hello i have this iphone 7 plus after doing it and downgrading to 14.8 i cant boot it up the power + sound button also when i try to run the command --boot it gives me this error [libusb] Waiting for the USB handle with VID: 0x5AC, PID: 0x1227
CPID: 0x8010
Found the USB handle.
Stage: PATCH
ret: true
for anything i do and i also tryed to re downgrade but it still gives the same error and jailbreak but im thinking that the iphone is dead and also its it dfu mode

your device is in false dfu mode, First: execute sudo ./binaries/$(uname)/gaster pwn, if that start to loop (like never finish) Force reboot when the loop stop please press home button (or volume down) and stop gaster by pressing ctrl + c in your computer and after 10 second execute the command again

hi so i did that and it dose not work i tryed like 15-20 times it still spams and i did it after 10 secs and it still spams the error

hi so i did that and it dose not work i tryed like 15-20 times it still spams and i did it after 10 secs and it still spams the error

we need a video tutorial fr, well please restore with iTunes and if you want use dualra1n. dualra1n is a dual boot you are going to have iOS 15 with iOS 14.8 tethered, https://github.com/dualra1n/dualra1n


Add diagnostics

Develop a library to aid in diagnostics, that includes things like:

counters about subscriber state, successes, failures, etc
device traits are already exported
api request/response stats
event details - messages delivered, by type
media fetches, loads, etc.

Marking as closed given initial baseline level of support is in for next release.


unclear former documentation

most of the documentation refers to "the Former trait".  there is no trait named Former, only a derive macro.
the primary purpose of the builder pattern is the ability to enforce invariant when the structure is built, and to not expose the internal structure (eg. so that you could switch from a HashMap to a DashMap in semver-compatible versions).  it is not clear how you would achieve either of these.

Thank you for the feedback; it will help improve the documentation's quality.
While the primary purpose of the Builder pattern is constructing complex objects step by step, it also ensures invariants and hides internal structures, allowing for implementation changes (e.g., switching from HashMap to DashMap) without breaking compatibility. This flexibility is indeed part of what Former aims to achieve, although it may not automate all aspects. Don't you think that the purpose you described aligns more with the Adapter pattern, which focuses on interfacing different implementations? The Builder pattern is about constructing objects with various configurations. Using Former, you can produce different types and representations of an object with the same construction code, though this flexibility isn't fully automated by the crate.
Regarding the "Former trait," it should be "Former trait system," which encompasses multiple traits contributing to Former's flexibility. I agree that "Former trait" is misleading and will clarify this in the documentation.
Do you see any other problems or areas for improvement?

although it may not automate all aspects

yes, obviously you would need to manually override certain automatically generated functions, namely form().
however, it doesn't seem like there's any way to do this?

How should a minimal reproducible case look? Could you provide a code snippet and explain the expected behavior of that code?

look at any fallible builder, such as request::ClientBuilder::build


disable yamllint truthy-rule for swagger-editor-validator.yml

What type of PR is this?
Add one of the following kinds:

bug

What this PR does / why we need it:
This PR fix the megalinter issue to disable "on"-keyword validation (truthy)
Which issue(s) this PR fixes:
Fixes #211

@maxl2287 Thanks for fixing this.


When parameter style is invalid, return a helpful message instead of throwing an NPE

This fixes the NPE (see issue #1409) and also alters the resulting error message to more accurately describe the problem.

thanks @kerrykimbrough for this fix!


dep init does not work

dep init does not work when vg is activated (path is not in GOPATH)
workaround:
vg globalExec -- dep init

This problem is only when using full isolation mode and the workaround is now described in the README:
https://github.com/GetStream/vg#dep-commands

it is not a typo??
https://github.com/GetStream/vg#dep-commands says
vg globalExec -- vg init

Good find, it was indeed some mistake in the repo. And actually the -- shouldn't be used with globalExec. Fixed it now in the README.


菜单栏效果

刘进益我幺儿
------------------ 原始邮件 ------------------
发件人:                                                                                "JJF-LJY-ZHW-ZH-HYS/WebProject"                                                                                @.>;
发送时间: 2021年10月31日(星期天) 晚上10:34
@.>;
抄送: "【<EMAIL_ADDRESS>主题: Re: [JJF-LJY-ZHW-ZH-HYS/WebProject] 菜单栏效果 (Issue #3)
Assigned #3 to @HEasoner.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.

刘进益我幺儿
…
------------------ 原始邮件 ------------------ 发件人: "JJF-LJY-ZHW-ZH-HYS/WebProject" @.>; 发送时间: 2021年10月31日(星期天) 晚上10:34 @.>; 抄送: "【<EMAIL_ADDRESS>主题: Re: [JJF-LJY-ZHW-ZH-HYS/WebProject] 菜单栏效果 (Issue #3) Assigned #3 to @HEasoner. — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

纯土狗


feature request: pseudo-continuous color ranges for numeric data

Is there a one-liner that I can use to get the color of a numeric value? For example, I want to make a color range from blue to red using 256 levels, where blue somehow maps to 0.0 and red maps to 1.0. From the markdown file I've come up with the following workflow.
from colour import Color
import numpy as np

# make the base colors
red = Color("red")
blue = Color("blue")

# define the color range
levels = 256
r_to_b = list(red.range_to(blue, levels))

def map(x, color_range, m=0.0, M=1.0):
    """ This map converts a numeric value to Color object in a list of Color objects """
    n = len(color_range)
    numeric_range = np.linspace(m,M,n)
    nearest_idx = np.abs(x - numeric_range).argmin()
    return color_range[nearest_idx]

# retrieve the color of float x
x = 0.2425
color_x = map(x, r_to_b)

Is this functionality already present in colour, or do you see a better implementation?

Your workflow is basically correct. To resume: You can use the Color(source).range_to(target, N) to manage color scales and generate a N level definition way between source color and target color. This gives you arbitrary precision at the cost of memory. Please remember that the scaling between the colors will use HSL for now, so it has some use to have a better resolution than 256, even if your final output will be RGB.
Without numpy considerations (and thus with probable rounding and typing issues):
import colour import Color

def mk_map(source, target, levels=1024):
    range = list(Color(source).range_to(Color(target), levels))
    def map(x, m=0.0, M=1.0):
        return range[min(int(levels * (x - m) / (M - m)), levels - 1)]
    return map

## Usage
map = mk_map("red", "blue", 2048)

map(0.0)  ## returns Color("blue")
map(1.0)  ## return Color("red")

It might be a good idea to provide this functionality (mapping continuous value to color scales) indeed. I'll look into this when I'll have more time.


Replaced every occurance of data_pattern

Description of Work
Fixes #39
Replaced every occurence of data_pattern_in and data_pattern_out with data_x and data_y respectively.
Testing Instructions

Run example_runScript.py with both

run_data = "nist"
run_data = "neutron"

After each run, compare the results with those given by master.

please fix conflicts

passes with nist and neutrons


treewide: rename name to pname&version

Description of changes
#103997

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 165303 run on aarch64-darwin 1

7 packages marked as broken and skipped:

bitcoin-unlimited
bitcoind-unlimited
gnuradio3_8
gnuradio3_9
litecoin
litecoind
qxmledit

4 packages failed to build:

cardinal
grass
wine64Packages.staging
wine64Packages.stagingFull

1 package built:

inkscape-extensions.hexmap

/nix/store/rpk8vd0habrxqfj7mg29yk56gsyvg1b1-clion-2021.3.3/clion/plugins/remote-dev-server/bin/launcher.sh: interpreter directive changed from "#!/bin/sh" to "/nix/store/dndi916j6yxzfzzj2sma2llhrlwahq06-bash-5.1-p16/bin/sh"
checking for references to /build/ in /nix/store/rpk8vd0habrxqfj7mg29yk56gsyvg1b1-clion-2021.3.3...
patchelf: cannot find section '.dynamic'. The input file is most likely statically linked
/nix/store/lkk0hf9h4x85mb4lrsf2sh25qm2i4n18-stdenv-linux/setup: line 87: cd: /nix/store/rpk8vd0habrxqfj7mg29yk56gsyvg1b1-clion-2021.3.3/clion-2021.3.3: No such file or directory
error: builder for '/nix/store/ywqpaza1v0wpgvfhvp8a54y8j24kvnbw-clion-2021.3.3.drv' failed with exit code 1;

This update broke clion for me. Is anybody testing these changes before they go in?

The CLion breakage is now tracked in #166216.


Season 27 of anime Doraemon not opening

I have tested the latest Elementum update and it fixes my previous reported issues.
I decided to open a new issue because this is related to Elementum not Burst.
Issues:

When I click on anime Doraemon season 27, it doesn't open and it shows an error: Elementum Internal Server Error, using a similar addon, Themoviedb Helper, I can click on season 27 and play it with Elementum without any issue.
In the same show, Elementum is sending payload with inconsistent episode numbers, here is an example of what I click on and what Elementum sends.

The first is the episode I click on -> this is what Burst receives, I notice the value of absolute_number in the payload
S25E9->S25E9 payload has absolute_number:0
S25E10->S25E1704 payload has absolute_number:1704

S24E9->S24E1658 payload has absolute_number:1658
S24E10->S24E10 payload has absolute_number:0
S24E11->S24E1660 payload has absolute_number:1660

Here is the log from the moment I started testing.
I clicked on S25E9 then S25E10 then went back and tried to enter S27
https://pastebin.com/raw/PWc5anzN

@movianlost
this particular issue (Elementum Internal Server Error) should be fixed by https://github.com/elgatito/elementum/commit/a9010a9fd93f4babcc8b6ce538489799ec975527
i am not talking about absolute_number since it looks like a separate issue.

Issue should be already fixed.

@elgatito I tested the latest version and Elementum Internal Server Error is fixed and season 27 is working fine.
However, the second issue is still not fixed, can you read my original comment I have described it there where the payload sometimes it send the absolute number and sometimes not

@movianlost  let's keep separate issues in separate tickets, please.


Can't access any methods of GDScript classes (except .new()) unless you first cast them as Script or GDScript

Godot version
4.0.2
System information
Windows 11
Issue description
You can't use any methods of a class (except .new()) unless you explicitly cast it to Script or GDScript.
class Example:
	pass;

func _init():
	print(Example is GDScript); # true
	print((Example as GDScript).has_source_code()); # false
	print((Example as Script).has_source_code()); # false
	print(Example.has_source_code()); # error

	var typed_implicit := Example; # also doesn't work
	print(typed_implicit.has_source_code()); # error

There is also some other... strangeness going on.
func _init():
	var untyped = Example;

	# print(untyped.has_source_code()); # error
	# print(Example.has_source_code); # error
	print(untyped.has_source_code); # works??
	print(untyped.has_source_code.call()); # also works??
	print(Example["has_source_code"].call()); # also works

Likely related to #73140
Edit: You actually can't even access .new() outside of calling it.
func _init():

	print(Example.new()); # works, of course
	print(Example["new"]); # works
	print(Example.new); # error

Also, everything works out the same if Example is a class_name in its own file instead of an inner class.
Steps to reproduce
Attempt to access the methods of a GDScript-based class without first casting it to Script or GDScript.
Minimal reproduction project
MRP.zip

Example in your example is neither Script nor GDScript, it's RefCounted (or Reference in 3.x).
print(Example is GDScript); # true

seems like an error to me, since it's not even a script, it's an inner class.

Everything is still the same if Example is a class_name in a separate file. Also, Example.new().get_script() returns a GDScript object. It appears that inner class objects themselves do extend GDScript.

No, they don't. And if they somehow do, it's an error. If you don't specify any base type, RefCounted is used. But there is trickery to make it script-based types work that expose some of those GDScript methods, like new().

The object you get from Example.new() does not implement GDScript. Example itself absolutely does. I don't know if that's an error, but it is 100% what I am seeing.

Ok I'm actually partly wrong. Example itself is a RefCounted, but the fact that you can coerce it into a GDScript/Script object despite that is very weird and probably the cause of a lot of this strangeness.

Yes, you are correct, of course. I got confused.


idea: MCP server that exposes computer use tool implementations

The computer use quickstart is useful, but the one-shot chat interface means I can't write my own agent loop. What if the tool implementations (arguably the most useful part) were exposed in some way? Could they be exposed by the docker image as an MCP server using websocket as transport? This could make it possible to write my own agent loop that calls out to the CU tool implementations running remotely on the docker image.

Try what could go wrong (wcgw) MCP server.
Has the computer use option.
"wcgw": {
  "command": "uv",
  "args": [
    "tool",
    "run",
    "--from",
    "wcgw@latest",
    "--python",
    "3.12",
    "wcgw_mcp",
    "--computer-use"
  ]


InputManager: Fix scenario where click can occur when ExclusiveDoubleClickMode = true

A user in the forum found an issue where clicks could occur ExclusiveDoubleClickMode was set to true.  This PR adds a change to the logic to prevent this from happening.  A test was also added to prevent this in the future.
Forum Link: https://forum.babylonjs.com/t/bug-with-babylon-scene-exclusivedoubleclickmode/38541/

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

Snapshot stored with reference name:
refs/pull/13577/merge
Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13577/merge/index.html
To test a playground add it to the URL, for example:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13577/merge/index.html#WGZLGJ#4600
Links to test babylon tools with this snapshot:
https://playground.babylonjs.com/?snapshot=refs/pull/13577/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/13577/merge
https://gui.babylonjs.com/?snapshot=refs/pull/13577/merge
https://nme.babylonjs.com/?snapshot=refs/pull/13577/merge
To test the snapshot in the playground with a playground ID add it after the snapshot query string:
https://playground.babylonjs.com/?snapshot=refs/pull/13577/merge#BCU1XR#0


cbrrr v1.0

Here's all the things I want to complete before it's ready for a v1.0 release:

[x] Implement parsing into "atjson" format ($link, $bytes)
[x] Implement base32 encode/decode in C (to optimise perf in atjson mode)
[x] Clean up any (important) TODOs in the source
[x] Rename "parse" to "decode"
[x] Clean up the CID class, audit correctness
[x] Robust testing, within a proper testing framework Edit: I'm marking this as done, but there's lots of room for improvement
[x] Set up a fuzz harness
[x] Automate testing on GHA
[x] Figure out some standard benchmarks, show off perf vs dag_cbor, libipld - done at https://github.com/DavidBuchanan314/dag-cbor-benchmark although some more atproto-specific tests would be good
[ ] Documentation - the API is simple enough that a good README should be enough
[x] Get it on pypi

Deferred to 1.x:

[ ] More test coverage
[ ] GHA testing on macos and windows, and aarch64 if I can figure that out.
[ ] Test edge-cases that might arise on 32-bit platforms (and fix any related bugs) https://github.com/DavidBuchanan314/dag-cbrrr/issues/3
[ ] Optional hard resource limits - recursion depth, number/size of objects allocated https://github.com/DavidBuchanan314/dag-cbrrr/issues/2
[ ] Parsing into an existing bytearray object, and parsing directly into a new bytes object without copy
[ ] Implement the CID type entirely in C

pre-built wheels for all platforms and python versions (uploaded to pypi, automated via GHA)?

pre-built wheels for all platforms and python versions (uploaded to pypi, automated via GHA)?

I'd love to have that but it's not something I know how to do currently, is it maybe something you could help with setting up? I'll put it down as a 1.x goal but that doesn't mean it can't happen sooner (my main aim with 1.0 is to have it ready to use in my PDS rewrite)


EXSWHTEC-331 - Implement tests for half-precision comparison functions

Numerical accuracy tests for half/half2 comparison functions
Negative compiler tests

Depends-on: https://github.com/ROCm-Developer-Tools/hip-tests/pull/409

PR has been merged into develop branch via commit b9ea146b28f169a366c5f90763f7ac49e94a79b3.


Issue with "Office 365 Search and Delete" in @site/docs/reference/playbooks/office-365-search-and-delete.md

Describe the problem

Page: Office 365 Search and Delete
Source: https://github.com/demisto/content/blob/master//Packs/EWS/Playbooks/playbook-Office_365_Search_and_Delete_README.md

The commands listed in this playbook are from the EWSv2 integration and this page says there are no integration dependencies.  Please add ewsv2 integration (https://xsoar.pan.dev/docs/reference/integrations/ews-v2) as a dependency.  Screenshot shows the commands from the ews v2 intgeration
Screenshots

Environment

OS: [e.g. Windows]
Browser: [e.g. chrome, safari, firefox..]
Browser Version:

Suggested fix

Add the ewsv2 integration as a dependency to this playbook

Duplicate issue to https://github.com/demisto/content-docs/issues/712 sorry :/


Error when run with EfficientDet model

/usr/local/lib/python3.6/dist-packages/icevision/models/efficientdet/fastai/callbacks.py in before_batch(self)
      7 class EfficientDetCallback(fastai.Callback):
      8     def before_batch(self):
----> 9         assert len(self.xb) == len(self.yb) == 1, "Only works for single input-output"
     10         self.learn.xb = self.xb[0]
     11         self.learn.records = self.yb[0]

AssertionError: Only works for single input-output

Could you guys suggest any reason

Can you provide a minimal reproducer for the error? What is the code you're running?

Can you provide a minimal reproducer for the error? What is the code you're running?

Resolved.


nakedret enabled

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Pull request type

Please check the type of change your PR introduces:

[ ] Bugfix
[ ] Feature
[x] Code style update (formatting, renaming)
[x] Refactoring (no functional changes, no api changes)
[x] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

What is the current behavior?

Issue Number: #953
What is the new behavior?

Other information

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (321be1b) 67.41% compared to head (0dc5c5b) 38.52%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #990       +/-   ##
===========================================
- Coverage   67.41%   38.52%   -28.89%
===========================================
  Files         261      207       -54
  Lines       24686    21410     -3276
===========================================
- Hits        16641     8249     -8392
- Misses       7177    12814     +5637
+ Partials      868      347      -521

Flag
Coverage Δ

?

go-1.17.x
38.52% <ø> (-27.29%)
:arrow_down:

go-1.20.x
?

go-1.21.x
?

integration
?

macOS
38.52% <ø> (-0.29%)
:arrow_down:

ubuntu
?

unit
38.52% <ø> (-0.39%)
:arrow_down:

windows
?

ydb-22.5
?

ydb-23.1
?

ydb-23.2
?

ydb-23.3
?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Add UDP feature to network utilities

Create Python scripts for UDP client and server

Scripted was created and tested successfully.


Added language similarity and network similarity packages

Docs Build status updates of commit 43f3fd7:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/MicrosoftDocs/microsoft-academic-services, working directory: W:\qi5i-s, target branch: live, target branch commit: 601c3d8749a5126eeb0919a19c86834fc0d58d34, source commit: 43f3fd7a861d322dbce468e845952c799b8befb6.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit e382299:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.openpublishing.publish.config.json
:white_check_mark:Succeeded

academic-services/graph/TOC.yml
:white_check_mark:Succeeded

academic-services/graph/get-started-setup-provisioning.md
:white_check_mark:Succeeded

academic-services/graph/index.yml
:white_check_mark:Succeeded

academic-services/graph/language-similarity-computesimilarity.md
:white_check_mark:Succeeded

academic-services/graph/language-similarity-constructor.md
:white_check_mark:Succeeded

academic-services/graph/language-similarity-example.md
:white_check_mark:Succeeded

academic-services/graph/language-similarity-gettopfieldsofstudy.md
:white_check_mark:Succeeded

academic-services/graph/language-similarity.md
:white_check_mark:Succeeded

academic-services/graph/media/language-similarity/content.png
:white_check_mark:Succeeded

academic-services/graph/media/language-similarity/zip.png
:white_check_mark:Succeeded

academic-services/graph/media/network-similarity/databricks-get-top-entities.png
:white_check_mark:Succeeded

academic-services/graph/media/network-similarity/databricks-top-entities-detail.png
:white_check_mark:Succeeded

academic-services/graph/media/network-similarity/folder.png
:white_check_mark:Succeeded

academic-services/graph/media/network-similarity/usql-get-top-entities.png
:white_check_mark:Succeeded

academic-services/graph/media/network-similarity/usql-top-entities-detail.png
:white_check_mark:Succeeded

academic-services/graph/network-similarity-analytics.md
:white_check_mark:Succeeded

academic-services/graph/network-similarity-databricks.md
:white_check_mark:Succeeded

academic-services/graph/network-similarity.md
:white_check_mark:Succeeded

academic-services/graph/reference-data-schema.md
:white_check_mark:Succeeded

academic-services/graph/resources-faq.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Some questions

Hi, when I run the code

python -m torch.distributed.run --nproc_per_node=8 train.py --cfg-path lavis/projects/blip2/train/3dvqa_ft.yaml

there are some questions:

I downloaded the weights locally from "https://huggingface.co/facebook/opt-2.7b" and replaced 'opt_model' in the code with the local weight file, but it shows that the weight and model sizes don't match.

What directory should I place the downloaded dataset in?

I found that the three annotations files in 3dvqa_ft.yaml do not exist. How can I obtain them?

train:
  storage: ./examples/all_refer_questions_train.json
test:
  storage: ./examples/all_refer_questions_val.json
val:
  storage: ./examples/all_refer_questions_val.json

The codes in this repo use flant5. The weights should be automatically downloaded with the scripts.
self.feature dir should be "features", and self.voxel dir should be "points" from the scene data
replace the files with the json file in the google drive

We will push another version to fix these path mismatch

The codes in this repo use flant5. The weights should be automatically downloaded with the scripts.
self.feature dir should be "features", and self.voxel dir should be "points" from the scene data
replace the files with the json file in the google drive

We will push another version to fix these path mismatch

For "3. replace the files with the json file in the google drive",  json files in the google drive are 'data_part1_all_objaverse.json' and 'data_part2_scene.json'. In 3dvqa_ft.yaml, there are train, val, and test.
Do I need to split the 'data_part1_all_objaverse.json' and 'data_part2_scene.json' into train/val/test sets in proportion of (8:1:1)?

The codes in this repo use flant5. The weights should be automatically downloaded with the scripts.
self.feature dir should be "features", and self.voxel dir should be "points" from the scene data
replace the files with the json file in the google drive

We will push another version to fix these path mismatch

Thanks! Do I need to split the 'data_part1_all_objaverse.json' and 'data_part2_scene.json' into train/val/test sets in proportion of (8:1:1)? I found you have uploaded files "voxelized_features_sam_nonzero_preprocess.zip" and "voxelized_voxels_sam_nonzero_preprocess.zip", what's that for?

Are you using the voxel point cloud as input? I thought the paper was using continuous representation.


Fix parent hash verification after to spec change

This PR fixes #380.

I'm closing this in favor of #390, which includes this fix.


How to exactly disable the functionality auto-retry of shaka when error happen?

Have you read the Tutorials?
Yes
Have you read the FAQ and checked for duplicate open issues?
Yes
If the question is related to FairPlay, have you read the tutorial?

Yes
What version of Shaka Player are you using?
4.6.3
https://cdnjs.cloudflare.com/ajax/libs/shaka-player/4.6.3/shaka-player.ui.min.js
What browser and OS are you using?
Both Window and macOs
Please ask your question
I would like to know how to exactly disable the functionality auto-retry of shaka when streaming has error or manifest has error. What I need is whenever these errors happen, player only need to throw the error and NOT auto retry.
I see there's streaming.retryParameters.maxAttempts and manifest.retryParameters.maxAttempts. But when set to zero (0), it throws error Cannot read properties of null (reading 'code') after call function player.load(manifestUrl)

Can you please let me know the exact configuration to do this?
Thank you

The number of attempts described by streaming.retryParameters.maxAttempts includes the initial attempt, before any retries. Setting it to 0 would mean that we wouldn't try to download anything at all, which doesn't really make sense.
Just set it to 1 instead, if you want to disable retrying.

Thanks @avelad


running_content_start_at should not alter page numbering

The page numbering should not be altered if the running_content_start_at is set to title or toc. Instead, roman numerals should be used for any page that proceeds the body.
(If we do want to alter the page numbering, that should be handled by a different setting).

cc: @habamax

Not sure I get what is the bug.
Is it about page_numbers should always start from the non toc/title pages?
title -- pagenum ==0
toc page 1 -- pagenum ==0
toc page N -- pagenum == 0
content first page -- pagenum ==1
?
If so, then for my article type docs I am not sure I want that behavior.

Just because we're adding the running content on the toc and/or title pages doesn't mean all of a sudden we should start numbering pages differently. These are front matter pages and have special (roman numeral) page numbering already (deeply rooted in PDF / book layout).
Now, we could allow the page numbering to be shifted (so that the front matter numbering isn't used), but that's a separate behavior that should be controlled by a separate setting.

my article type docs I am not sure I want that behavior.

None of this applies to the article doctype since the article doctype doesn't have a title and toc page (except when using the legacy title-page attribute).

(Look at the outline of the PDF for how pages are numbered normally. There, you will see "i" for the title page and "ii" for the toc page).

None of this applies to the article doctype since the article doctype doesn't have a title and toc page (except when using the legacy title-page attribute).

I didn't know title-page is legacy. I use it quite extensively (80% of my "printed" docs) -- asciidoctor doesn't have report type which is between article and book (in latex), so this option let me mimic report type.

(Look at the outline of the PDF for how pages are numbered normally. There, you will see "i" for the title page and "ii" for the toc page).

Ahh, yes, I remember I saw it.
Anyway, I agree it makes sense

It's legacy because it was the wrong behavior to begin with (since Asciidoctor PDF was originally only made for books).

Regardless, I'm not saying you can't have the behavior you want. I'm saying it's not correct for the page numbering to be affected by running_content_start_at. We need a separate property for that since it's fundamentally a different thing.


 I would like to like add "preload:none" to the video tag and load it on an hovering event.
Great example: https://codepen.io/gil--/pen/bNxZWg
Greetings,
Thomas

This functionality isn't offered by the youtube iframe api and since this project aims to be a minimal wrapper i don't think we will implement it.
I'd recommend you create your own VideoPlayer element wrapping react-youtube which uses the video id to load a thumbnail and display that until you actually want to load the video.

Hi tjallingt,
thanks for the answer. I already built a wrapper based on your package. If people are interested in it I might publish it :)
Greetings,
Thomas


⚠ ClamAV has degraded performance

In 57e9024, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 248 ms

Resolved: ClamAV performance has improved in dabd73e.


Update utils.py

minor exception, so the training is not interrupted if a checkpoint got deleted.

This pull request makes 13,513 additions and 300 deletions to a total of 118 files, which is vastly more than what it claims to do in the title.
I assume this was an accident.

Yes, sorry - that was not my intention. You can ignore it.    Am Sonntag, 19. März 2023 um 00:44:31 MEZ hat Flux9665 @.***> Folgendes geschrieben:
This pull request makes 13,513 additions and 300 deletions to a total of 118 files, which is vastly more than what it claims to do in the title.
I assume this was an accident.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>


source the GraphPL code

If it is convenient for you, I hope you can open source the GraphPL code. Thank you very much.

Uploaded. :)


Vulkan: Environment Fog: Severe sky shader-related instability when PanoramaSky is used

Godot version
v4.0.beta8.official [45cac42c0]
System information
Manjaro Linux, Vulkan, RX 570 (Mesa 22.2.4)
Issue description
Preface: This is a very strange problem, and I haven't been able to entirely pin down what causes it, I'm largely speculating and guessing from experimentation.
This all mainly occurs upon startup of the project -- once the scene is loaded, it settles into some state, until the next time the project is started.
The simple (non-volumetric) environment fog seems to exhibit severe problems when it is used in conjunction with PanoramaSky (or a shader that is very similar to it), and with visible ReflectionProbes in the scene upon startup.
I have experienced issues of varying severity,:

Sections of sky being pitch black (probably NaN because they cause glow to be extremely bright)

This in turn affects ReflectionProbes, causing anything within them to become black/NaN too

Severe performance hit when any fragment of the sky is visible (not obscured by the world)
OS' compositor crashing and rendering the system unusable, forcing a reboot.

The last one is the worst by far, and is the main reason I've struggled to learn much about
The pattern of occurrences of these bugs seems to be entirely random.
I have made attempts to tinker and try to pin down the exact conditions for causing the bug(s), but it is inconsistent and I haven't been really able to find much. It seems like other sky materials besides PanoramaSky don't have any of these problems, but I'm not really sure.
I apologize for this issue's relatively poor quality and lack of sufficient info. I mainly just want to alert others to this issue, to see if others have experienced this too, or can replicate this on their systems. So that we can get more potential info on this.
Steps to reproduce

Download MRP. Ensure you won't gonna lose anything important if your system crashes from running it
Run it. It has a simple FPS player controller for moving around the scene. WASD controls with mouselook. It is fullscreen so press ESC to pause and regain mouse control, Alt+F4 to exit at any moment
Observe the sky and see if anything is erroneously black-coloured, if having the sky in-view severely damages performance, and/or if your system's compositor/graphics crash.
Rerun the project if nothing happened, this is an inconsistent bug and may take multiple tries to get.

Minimal reproduction project
I was unable to replicate it in a fresh project, so I trimmed down my FPS project (in which I ran into the issue) to the bare minimum needed to replicate it.
Environment Fog+Sky Test.zip

Process of reproduction:
First attempt, no adverse effects.
Second attempt, got stuck on a grey screen. Couldn't alt-f4. Mouse vanished completely, and was rendered unusable, even when alt-tabbing or switching workspaces. Had to restart PC.
Third attempt, project did not open in the editor at all. Just a grey screen. Godot log for that attempt is as follows:
ERROR: Condition "gvtype == RenderingServer::GLOBAL_VAR_TYPE_MAX" is true. Continuing.
   at: global_shader_parameters_load_settings (servers/rendering/renderer_rd/storage_rd/material_storage.cpp:2163)
WARNING: FBX file import is enabled in the project settings, but no FBX2glTF path is configured in the editor settings. FBX files will not be imported.
     at: _editor_init (modules/gltf/register_types.cpp:99)
SCRIPT ERROR: Parse Error: Identifier "Directory" not declared in the current scope.
          at: GDScript::reload (res://common/AnimatedDecal.gd:11)
ERROR: Condition "gvtype == RenderingServer::GLOBAL_VAR_TYPE_MAX" is true. Continuing.
   at: global_shader_parameters_load_settings (servers/rendering/renderer_rd/storage_rd/material_storage.cpp:2163)
ERROR: Condition "err" is true. Returning: ERR_CANT_CREATE
   at: swap_buffers (drivers/vulkan/vulkan_context.cpp:2299)
ERROR: Condition "err" is true. Returning: ERR_CANT_CREATE
   at: swap_buffers (drivers/vulkan/vulkan_context.cpp:2299)

Godot would not close. Running kill godot4 after this caused a system freeze for around 5 seconds, before the editor closed and system returned to normal.
Subsequent attempts were the same. Deleting the shader cache in the .godot folder allowed the project to open again.
Fourth attempt yielded the same results as the second attempt, although I realised that I could kill Godot from the terminal as described earlier using only the keyboard, so I didn't have to restart the PC.
Fifth yielded the same results as the third attempt. From this point onwards, I started deleting the shader cache after every run.
Sixth attempt, I disabled fog. The project ran perfectly with it disabled.
Seventh, I re-enabled fog, and it broke again. Same as attempt 2.
GPU: NVIDIA GTX 1060
CPU: AMD Ryzen 7 1800X
On Manjaro Linux with KDE

I have similar issues with Volumetric Fog (v4.0.beta.custom_build [3c9bf4bc2]). From a time to time the fog is very bright and glowing or completely dark. This has happened before (on alpha or before alpha).

Expected result:

Next thing is, that starting from Godot 4 Beta 12 I'm noticing frequent performance drops. A restart of the project is required, but also sometimes changing the window size (i.e. go to toggle fullscreen) is enough to bring back the performance. The editor remains open, but I'm always activating empty tab or script editor.

On this scene I'm getting 30-40fps typically. But today I've added a 4k exr panorama sky, and Godot almost freezed together with whole operating system. The stdout contains:
ERROR: 1 shaders of type VolumetricFogShaderRD were never freed
   at: ~ShaderRD (servers/rendering/renderer_rd/shader_rd.cpp:708)
ERROR: 1 RID allocations of type 'N10RendererRD15MaterialStorage6ShaderE' were leaked at exit.

Are these issues related to volumetric fog? Do you know these issues, or should I create new tickets and try to reproduce these issues with MRPs?
Thanks.

Running the MRP, this appears to be an issue with the sun_scatter property. Changing it to 0 makes the issue go away


Hotreload of externally edited GDScript

When editing a GDScript in an external editor, Godot tries to reload it when it gets modified. The problem was that Godot already has the script instanciated and tried to instanciate a new one from the same resource to reload the source code. This was prevented by the ResourceCache so it failed every time (see bug report #17044 for the triggered error).
This is now working correctly but the exception still triggers.
Fix #17044

I just tested it and it does not fix #10946

I may be able to spend some more time this week to fix this other issue too and enhance the script management process altogether so it can handle reloading cached resources (or at least, try my best to). Do I update this PR or use another branch ?

Could you squash the commits together?

@T4g1 It would be nice to have this feature first and then work on enhancements in another PR if you have the interest.
I was about to write a script to implement this behaviour, but it's great to see that we're already working on a solution.
I can test on windows/osx/linux if you need any checks done.

Moving to 3.2 milestone as we're about to enter the beta stage and release freeze for Godot 3.1. Only bug fixes against issues of the 3.1 milestone (or enhancements to core features of the 3.1 roadmap) will be considered until 3.1-stable is released.
Note: If it's merged after 3.1-stable is released, this change may be considered for cherry-picking into a later 3.1.x release.

Moving to next milestone as this seems not to be working properly as per https://github.com/godotengine/godot/pull/20910#discussion_r333702941

Any update? There is still this issue that needs to be resolved.

@T4g1 This is now working correctly but the exception still triggers.

If you would like to take another look at the problem, perhaps you can solve this issue too?


Please correct the typo in 'blur_videos.py'

blur_videos.py#L30
name="yolo_vidoes_pred") → name="yolo_videos_pred")

@YB-7  Thanks for pointing out!
Done.


Run history

A task (with an UUID) runs some actions (eg : docker-compose). With that we need

[ ] history of runs GET /task/{task_id}/runs
[ ] run detail GET /task/{task_id}/run/{run_id}
[ ] run delete DELETE /task/{task_id}/run/{run_id}

Closed by #55


feat(sandbox): make icons searchable by keyword

Summary
http://localhost:5173/icons/?q=south

http://localhost:5173/icons/?q=islands

the lag seems to be related to search; the current site loads pretty quickly

@adamdehaven the search input was already debounced, i lowered the timeout from 500ms to 200ms
https://github.com/Kong/icons/pull/322/commits/d58093fe7bb887bdd7e324b97ca819b8b8d290ea#diff-f5b67e1dd2f5e869bf6f35aadae0f59bd40f4f96aaebb91de2b99876e57740e2R50
If you look at my last commit, I think maybe the other reason for the perceived slowness could have been that were were redefining allComponents inside of filteredComponents every time the search value was changed 😬
Should be considerably more performant now.

Updated:


Fix for "rulebook producing a list of ..." in 6M62

As dicussed on IntFiction here: https://intfiction.org/t/crash-memory-access-out-of-range-when-getting-a-list-of-values-from-a-rulebook/50338
And here: https://intfiction.org/t/i7-6m62-rulebook-producing-a-list-of-numbers/13696

Wow! I wouldn't have expected a bug like to be fixible, so fantastic work finding a way to patch it.


feat!: implement HelpCommand

This would address the users who would like to see a summary of commands that they would like to refer to.
Closes #121 and testing for HelpCommand

Codecov Report

Merging #153 (29e28bc) into master (07a7bb3) will increase coverage by 0.10%.
The diff coverage is 28.57%.

@@             Coverage Diff              @@
##             master     #153      +/-   ##
============================================
+ Coverage     59.97%   60.07%   +0.10%
- Complexity      449      451       +2
============================================
  Files            84       84
  Lines          1784     1786       +2
  Branches        173      173
============================================
+ Hits           1070     1073       +3
+ Misses          628      627       -1
  Partials         86       86

Impacted Files
Coverage Δ

...java/seedu/address/logic/commands/ExitCommand.java
100.00% <ø> (ø)

...a/seedu/address/logic/parser/RecipeBookParser.java
0.00% <0.00%> (ø)

src/main/java/seedu/address/ui/HelpWindow.java
0.00% <ø> (ø)

...java/seedu/address/logic/commands/HelpCommand.java
100.00% <100.00%> (+100.00%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07a7bb3...29e28bc. Read the comment docs.


offline book - C# content missing

The offline book in VS 2019 for C# is missing some of the C# reference content. This is because the TOC is in a form that the offline book build tool doesn't know how to deal with. The issue to be avoided is that when a parent TOC node references a topic in a sub-TOC in order to pull in the sub-TOC, the referenced topic must be the root node of the sub-TOC.
So the fix here is to change the C# reference sub-TOC to eliminate the extra node at the top level and bring the topic referenced in the parent TOC to the root node.

@BillWagner I have a PR to address this and will mention you on it.

@rpetrusha @Thraka

Does your PR closes this issue or is there more @ghogen?

I would like to keep this open until we rebuild the book and verify that our fix worked.

Sounds good! 👍

The referenced PR did fix this. We didn't close it in in a timely fashion.
Closing now.  /cc @ghogen


Distributed sklearn kmeans based on ray and modin

Added one_ccl transceiver.
Rewrote dist_kmeans.h. The spark sample and daal4py used map_tree, but it is based on send and receive operations, which oneccl not support yet. oneDAL KMeans MPI sample didn't use map_tree, so I used it as a basis.
Added ray_partition_actor and ray context. At the moment ray_context is basic and serves more to extract some information from the ray cluster. This functionality is planned to be expanded in the future.
Added to build.sh the ability to work with oneccl. At the moment, for correct operation, you need a oneccl build: https://github.com/oneapi-src/oneCCL/tree/2021.1-beta07-1
And also set the variable CCLROOT. In addition, it needs to use oneccl_transceiver:
export D4P_TRANSCEIVER = oneccl_transceiver

Out of date with repository - if continued work on this is desired a new ticket+PR can be opened


updated svnx (2.0b2)

Tick #17075

Thank you for the contribution. It was merged directly as c757e5c1a094133d62ae1410437eb3f6b57085ce to keep commit history cleaner. Your contribution is still credited to you.


Add command prompts

@princecodes247  what do you think?
Currently what is left is implementing the fs operations from within the presets package

Most of what we need is around the io.Copy function, passing it a writer and receiver


[Feature request] tracing in SQL requests

Feature request
Is your feature request related to a problem? Please describe.
It's hard to dig into the details while troubleshooting a query. In our use case, queries from clients are sent to Starrocks using the JDBC protocol, and Datadog is the observability platform for log/metric collection, etc.
It lacks some core features when looking into the details of the query processing:

there's no trace for SQL queries to show the processing steps, communication between FE/BE, etc;
not able to find all the log events based on query_id;

Describe the solution you'd like
With OpenTelemetry, we build a platform-independent trace record for each SQL request to expose the processing information, including spans and log events, within/between FE and BE components. It includes several improvements:

build trace record for each SQL request;
support trace context propagation from client;
support trace context from FE to BE;
attach trace context to log events;

Describe alternatives you've considered
Additional context
We run a PoC(proof-of-concept) to achieve some of the requirements, the solution is implemented as below:

trace context is added as a comment to the SQL;
In FE, it starts a trace record for each query, with the parentContext extracted from SQL comments when provided;
trace context is added to log events as tags with MDC, BE is not covered in the PoC;

cc @dengliu @chaoyli


cdc: how to get correct Version when debug cdc

Before asking a question, make sure you have

[X] Searched existing Stack Overflow questions
[X] Googled your question
[X] Searched open and closed GitHub issues
[X] Read the documentation

What is your question?
I want to debug ticdc in ubuntu environment. When I start debugging from cmd/cdc, ticdc works correctly. But when I created the changefeed, panic appeared in creatorVersion := semver.New(SanitizeVersion(g.version)), so I tried to skip the version check here and successfully created the changefeed.  But at this time, this wrong changefeed already exists in etcd, so whenever I debug ticdc, this changefeed will run, causing the system to crash.
So I wonder where etcd's data is stored when TiCDC uses etcd? Or is there any other command to clear the changefeed information? thanks for your answers. (ps. there is no /var/lib/etcd folder on my system)

I have found the floder: /tmp/cdc_data

@Benevor

for the version check, I think it's better to modify the version.go https://github.com/pingcap/tiflow/blob/72afa810214abdbb419d935c5e4df65213f6c524/pkg/version/version.go#LL27C25-L27C25 , set the ReleaseVersion  with a valid value like v7.1.0.
you can use cdc  cli unsafe  reset  to clear all cdc metadata and changefeeds,  or you can use `etcdctl del' to delete the related changefeed keys in etcd ,then restart cdc cluster.
for the panic things, we are working on it. invalid changefeed will not panic the CDC server in a future release.

Thank you for your answer!

For the version check, I tried to write the version number in the code yesterday. When debugging now, everything works fine.
For etcd, I'm still not sure where its data is in the file system, it doesn't seem to be /tmp/cdc_data. I am not very familiar with the use of etcd. During the debugging process, I saw a prefix like /tidb/cdc. That doesn't mean such a path exists in the filesystem, does it?

@Benevor
cdc use the etcd embedded by PD, so the datapath should be PD data dir.
/tidb/cdc is the etcd key prefix in etcd, there is no path exists in the filesystem.

I understand, thank you very much.


add a set of favicons

[x] take a screenshot, crop it
[x] generate a package using https://realfavicongenerator.net/blog/new-favicon-package-less-is-more/
[x] adjust the webpack config (CopyWebpackPlugin, HtmlWebpackPlugin), make sure it takes care of the publicPath (needed by #10)

c7a5c3755b0242770029751326abe8f14fc9276b


Wrapper for druid database init scripts

Fixes #13738
Description
As described part of the issue, created a wrapper shell script with druid database init scripts
Release note
Wrapper for druid database init scripts
This PR has:

[x] been self-reviewed.

[ ] using the concurrency checklist (Remove this item if the PR doesn't have any relation to concurrency.)

[ ] added documentation for new or modified features or behaviors.
[x] a release note entry in the PR description.
[ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
[ ] added or updated version, license, or notice information in licenses.yaml
[ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
[ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
[ ] added integration tests.
[ ] been tested in a test Druid cluster.

@techdocsmith Could you please share your thoughts on this PR ?

thanks for the contribution, @siva-nb ! I think @paul-rogers or maybe @findingrish  would be better to comment on this particular pr.
cc: @sergioferragut

@LakshSingla Thanks for the review, will look into it.


Compact the state after slow block imports

Description
The new sync strategy puts more pressure on the db by importing blocks significantly faster. To counterbalance this I've added functionality to call LevelDBs compaction process when block import times reach 100 milliseconds, which results in a speedup of subsequent imports.
Type of change
Insert x into the following checkboxes to confirm (eg. [x]):

[ ] Bug fix.
[ ] New feature.
[x] Enhancement.
[ ] Unit test.
[ ] Breaking change (a fix or feature that causes existing functionality to not work as expected).
[ ] Requires documentation update.

Testing
Please describe the tests you used to validate this pull request. Provide any relevant details for test configurations as well as any instructions to reproduce these results.

existing test suite

Verification
Insert x into the following checkboxes to confirm (eg. [x]):

[x] I have self-reviewed my own code and conformed to the style guidelines of this project.
[x] New and existing tests pass locally with my changes.
[ ] I have added tests for my fix or feature.
[ ] I have made appropriate changes to the corresponding documentation.
[x] My code generates no new warnings.
[x] Any dependent changes have been made.

I'm seeing some issues on my full node that I think is related to this change. Whenever we get a single import which takes more than 1 second, the compaction gets triggered. While the compaction is running, the node cannot handle any API requests are do anything else but wait for the compaction to finish, which is taking 15+ minutes for me. This is getting triggered a bunch right now because of some load testing on the mastery network.
Since this effectively shuts down the kernel from doing anything useful, this behavior should be configurable and disableable. Then it would be on the kernel operator to occasionally stop the node and run aion.sh --db-compact before restarting it.
Here's the DB section of my config:
      <db>
        <!--Sets the physical location on disk where data will be stored.-->
        <path>database</path>
        <!--Boolean value. Enable/disable database integrity check run at startup.-->
        <check_integrity>false</check_integrity>
        <!--Data pruning behavior for the state database. Options: FULL, TOP, SPREAD.-->
        <!--FULL: the state is not pruned-->
        <!--TOP: the state is kept only for the top K blocks; limits sync to branching only within the stored blocks-->
        <!--SPREAD: the state is kept for the top K blocks and at regular block intervals-->
        <state-storage>FULL</state-storage>
        <!--Database implementation used to store data; supported options: leveldb, h2, rocksdb.-->
        <!--Caution: changing implementation requires re-syncing from genesis!-->
        <vendor>leveldb</vendor>
        <!--Boolean value. Enable/disable database compression to trade storage space for execution time.-->
        <enable_db_compression>true</enable_db_compression>
      </db>

Here's a snippet of the logs before the compacting and the result while compacting is going on (compacting starts on line 333)
compaction_snippet.log