[BugFix] Support set tablet state in script engine to fix tablet in NOT_READAY state in tablet meta caused by #21223

Fixes #28735
Because of #21223, lots of tablets may already in NOT_READY state and cannot do compaction.
Although #21224 fixes this bug, early versions without the fix may already persist the bad state, which need to be updated. This PR addes a method to set tablet states in script engine, so providing a way for developer/SA to use scripts to fix error tablets. Example:
admin execute on 10004 '
for (info in StorageEngine.get_tablet_infos(-1, -1)) {
    if (info.state == 0) {
        var t = StorageEngine.get_tablet(info.tablet_id)
        if (t != null) {
            t.set_tablet_state_as_int(0)
            t.save_meta()
            System.print("fix table %(info.table_id) tablet %(info.tablet_id)")
        }
    }
}
';

What type of PR is this:

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch

[x] 3.1
[x] 3.0
[x] 2.5
[x] 2.4

[FE PR Coverage Check]
:heart_eyes: pass : 0 / 0 (0%)

@Mergifyio backport branch-3.1

@Mergifyio backport branch-3.0

@Mergifyio backport branch-2.5

@Mergifyio backport branch-2.4

https://github.com/Mergifyio backport branch-2.3


Cucmber HTML Report is having ANSI values

Environment (please complete the following information):

multiple-cucumber-html-reporter: 3.6.0
Node.js version: v18.17.1
NPM version: 9.6.7
Platform name and version: macOs sonoma 14.3
Cucumber version: [e.g. 4.2.0]

Config of multiple-cucumber-html-reporter
I configured the report using the below file
//cucumberReport.ts
import report = require('multiple-cucumber-html-reporter')
report.generate({
jsonDir: 'reports/cucumberReport',
reportName: 'Purple Portal Report',
reportPath: './reports/cucumberReport',
metadata: {
browser: {
name: '',
version: '',
},
device: 'Local test machine',
platform: {
name: '',
version: '',
},
},
customData: {
title: 'Run info',
data: [
{ label: 'Project', value: 'CRSP' },
{ label: 'Application', value: 'Purple Portal' },
],
},
})
Describe the bug
In the Html report, assertion error is showing with ANSI Values. But, terminal it is displaying correctlry
Terminal Output

Cucumber Html Report

To Reproduce
Steps to reproduce the behavior:

Project is configured with Playwright
running the command with the following command npx cucumber-js test --tags '@smoke'
cucumber.json files is given below
//cucumber.json
{
"default": {
"paths": ["src/test/features"],
"require": ["src/test/stepDefinitions/*.ts", "src/hooks/hooks.ts"],
"requireModule": ["ts-node/register"],
"publishQuiet": true,
"format": [
"progress-bar",
"./src/helper/report/allureReport.ts:./output.txt",
"html:reports/cucumberReport/cucumber-report.html",
"json:reports/cucumberReport/cucumber-report.json"
],
"parallel": 1
}
}
package.json

[Include code or an example repository that can easily be set up]
Expected behavior
ANSI Values should not be present in the html file
Log
If applicable, add logs to help explain your problem. If you don't have logs, enable 'debug:true' in the config and paste the log here.
Please use proper markdown to style it
Additional context
Add any other context about the problem here.

@WasiqB any update about this issue

Hi @varshanharshank , did you test this issue using the latest version 3.6.2?
Let me know if the issue still exists.

@WasiqB Yes itried with 3.6.2 version and still seeing this issue. Refer the below info
In terminal, it is showing the text properly but in the repot it is not showing properly
CLI screen

Report


Fixing Generated Module Code

Codecov Report

Merging #8 (ade70a3) into main (46948e1) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main        #8   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           10        10
  Lines          345       345
  Branches        59        59
=========================================
  Hits           345       345

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46948e1...ade70a3. Read the comment docs.


Add tests for extending blocks

@kampersanda Thank you. I corrected the order of the arguments to be the same as the others.


Difficulty to use with enet on DTLS?

Any idea where I would start?
Imagining use for godot's future DTLS code.

http://erlang.org/doc/apps/ssl/ssl_protocol.html

Good question! I'm not very knowledgeable about DTLS. I will dig and try to understand how one is supposed to use this.
All of the socket handling is done in enet_host.erl so I think that's the place to start.


Add GetMinTS interface

This interface is used by the TSO microservice.

@coocood why do we have to kvproto repos, and for the same change, we need to create a new pr in two repos repectively instead of cherry-picking from one repo to another repo?

The public repo doesn't have the fields used in cse.


Certain keys are not working in Neovide

Not all shift-key combinations are working in Neovide. This includes all the symbols above the number keys (except @), ?, <, and >. It's picking up the shift key itself though because I'm able to write capital letters and the @ and : symbols.
Desktop:

OS: Arch Linux: Linux offmain 5.12.12-arch1-1 #1 SMP PREEMPT Fri, 18 Jun 2021 21:59:22 +0000 x86_64 GNU/Linux
Neovide Version: 0.7.0
Neovim Version: 0.5.0

Log:
> neovide --log
Ignored client type property: "methods"
Ignored client type property: "attributes"
Ignored style attribute: "standout"

Nevermind, after pulling from repo and rebuilding, the issue went away.


identity_file not passed to ssh command

If the field identity_file is not empty, it should be passed to ssh with -i <identity_file>.

Yes!  Thanks for filing this I meant to include that in a list of issues I made before releasing.  I'm going to try to make sure all the flags work this weekend!

Hi @fpkoschitzki , this was actually easier than I thought. I've gone ahead and released https://github.com/cornyhorse/sshaman/releases/tag/0.1.1 which addresses the identity file not being passed. Please let me know if have any issues with it. I don't have unit tests for it, but I tested it locally and it works as I expect it!


change system api organization

change system api organization

Codecov Report
Patch coverage has no change and project coverage change: -0.14 :warning:

Comparison is base (32de9c4) 24.52% compared to head (ac76e07) 24.39%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1433      +/-   ##
==========================================
- Coverage   24.52%   24.39%   -0.14%
==========================================
  Files         130      130
  Lines       15313    15399      +86
  Branches     2414     2414
==========================================
  Hits         3756     3756
- Misses      11424    11510      +86
  Partials      133      133

Flag
Coverage Δ

adapter
23.53% <ø> (-0.20%)
:arrow_down:

common-controller
0.00% <ø> (ø)

config-deployer-service
20.90% <ø> (ø)

idp-domain-service
80.10% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 3 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


[BUG]:

What version of drizzle-orm are you using?
0.30.8
What version of drizzle-kit are you using?
0.20.16
Describe the Bug
When I create this entity from drizzle studio "Add record" button
import { text, sqliteTable } from "drizzle-orm/sqlite-core";
import { sql } from "drizzle-orm";

export const user = sqliteTable("user", {
  id: text("id").notNull().primaryKey(),
  name: text("name").notNull(),
  email: text("email").notNull(),
  createdAt: text("created_at")
    .default(sql`CURRENT_TIMESTAMP`)
    .notNull(),
});

The created_at is not being populated with the actual date but i see "CURRENT_TIMESTAMP"

If i run the following in SQL runner:
INSERT INTO
  user (id, name, email)
VALUES
  ('123456789', 'John Doe', 'john@example.com');

the entity is created with the correct date.
Note:
note riproducible with version: ^0.20.14
Expected behavior
When I add a record from Studio I need to see the current time of creation if i leave the field as DEFAULT.
Environment & setup
I am using Drizzle and Turso in next JS environment.

@christianstamati Hey! This should be fixed, try it.


fix endtime calculation

This change leverages the OTJS project's timeInputToHrTime to give more predictable timestamps in spans.

ok jenkins


Load initial values

Technical debt is noted in #54 (storing initial value in declref). This looks good for now!


Feature follow page

Implement feature follow. Users can follow each other and see their followers, and following. User can see others' profile pages with their posts.

Follow page is work! can merge.


Camera3D.project_ray_origin does not place the ray origin on the near plane when in perspective mode

Godot version
v4.2.beta.custom_build [06d518916] (latest master)
System information
Godot v4.2.beta (06d518916) - Windows 10.0.22621 - GLES3 (Compatibility) - NVIDIA GeForce RTX 3050 Laptop GPU (NVIDIA; <IP_ADDRESS>98) - 11th Gen Intel(R) Core(TM) i5-11400H @ 2.70GHz (12 Threads)
Issue description
When a Camera3D node is set to perspective projection mode, I expected Camera3D.project_ray_origin to place the ray origin on the camera's near plane. But in reality it always returns the camera's origin. In comparison, in the case of orthographic projection, the ray origin is correctly placed on the camera's near plane.
The code causing this bug can be found in Camera3D.cpp, where it always returns the camera's origin for non-orthographic projections.
Steps to reproduce

Create a Camera3D node and place it in any 3D scene.
Add a built-in script on the Camera, and put the following test code inside:

func _ready():
	global_position = Vector3(0, 0, 0)
	global_rotation = Vector3(0, 0, 0)
	set_orthogonal(5.0, 0.5, 1000.0)
	# Prints -0.5, on the near plane as expected.
	print("Orthogonal ray origin: " + str(project_ray_origin(Vector2(200, 200)).z))
	set_perspective(75.0, 0.5, 1000.0)
	# Prints 0 instead, which is the camera origin's Z position and not the near plane.
	print("Perspective ray origin: " + str(project_ray_origin(Vector2(200, 200)).z))

Run the 3D scene and observe the output.

Minimal reproduction project
N/A

I think this is appropriate, the method is intended for casting rays, and for a non-orthogonal matrix that's a single point at the origin of the camera, that's what a projection is mathematically right?

I do think that this behavior on its own could be appropriate (treating the camera as an infinitely-small eye rather than a rectangular window), but I find it inconsistent with the orthogonal mode, which does consider the near plane and intends for project rays to start from the near plane.
In any case I think it'd be a good idea to document this behavior.

I mean the documentation doesn't say anything about the near plane, and the orthogonal isn't comparable as the alternative would be to have it on the plane without the near shift, because it's not converging

The documentation says that it's projecting a point on the viewport rectangle by the inverse camera projection.  The viewport rectangle here would be equivalent to the near plane, if I'm not mistaken. Going by the current documentation I'd expect it to be equivalent to passing the near plane's z depth to project_position, but this equivalence only holds for orthographic projections.
This is actually what prompted the investigation in the first place for me, as I was working on unit tests and sort of expected the equivalence above to hold.

Then the documentation can be tweaked indeed

I don't really hold an opinion of which is better, but having the ray origin be on the near plane would require additional logic that generally does not change the outcome of any ray cast, and will need to be reversed if the user requires the ray to originate from the camera origin. e.g. for correct ray casting: near_plane_origin = camera_origin + ray_direction * (near / abs(ray_direction.z)).
I'm never a fan of adding extra logic unless there is a clear case for it always being required. So I'm in agreement that the best option is to keep the logic as is, document correctly how it works, and maybe add the formula IF someone has a reason they want really want the position to be on the near plane.

@chocola-mint you can use Camera3D::project_position(screen_pos, near_distance) instead to get the vector from the camera origin to the fragment on the near plane in world space.


merge from konsum-frontend-svelte,template-svelte-app

package.json

chore(deps): add ^6.12.47 remove ^6.12.45 (devDependencies.npm-pkgbuild)
chore(deps): add ^17.4.7 remove ^17.4.6 (devDependencies.semantic-release)

:tada: This PR is included in version 1.29.23 :tada:
The release is available on:

v1.29.23
npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Changed the Chrome Extension Title

I really loved this extension and have been using it for the past week.
A few months ago, even I had a similar urge to create a bookmarking service but I couldn't get it off the ground due to lack of enough motivation.
But I find Geekmarks suitable to what I wanted (if not better). Hence, I am excited about working on it.
Recently, I noticed that while hovering over the extension icon, it displays some default text test. In this PR, I have changed it to Geekmarks which seems to be an apt title for the extension.

Thanks for the feedback and for the PR!


Update/change button size

Updated navigation arrows and close button on Vega tutorial messages to be easier to click.

This branch got mixed up with another one, but I cherry-picked #860fe24 to get those buttons a little bigger. Thanks!


Customize pro layout theme color

PrimaryColor value does not take effect in pro layout theme in app settings.
How can customize it?

As workround until it's fixed, I solved forcing the theme in the index.html:
 <link href="/_content/AntDesign.ProLayout/theme/dust.css" rel="stylesheet"/>

Any workaround to add custom color?

As workround until it's fixed, I solved forcing the theme in the index.html:
 <link href="/_content/AntDesign.ProLayout/theme/dust.css" rel="stylesheet"/>

Any workaround to add custom color?

You can generate custom color theme by adding the customcolor.less file and build the ant design pro layout project to get the customcolor.css stylesheet


 This will allow real doc-string problems to be more visible. At the moment there is 13 warning messages:
C:\Users\leungp\Documents\GitHub\compas_fab\src\compas_fab\backends\kinematics\analytical_inverse_kinematics.py:docstring of compas_fab.backends.kinematics.analytical_inverse_kinematics.AnalyticalInverseKinematics.inverse_kinematics:22: ERROR: Unexpected indentation.
C:\Users\leungp\Documents\GitHub\compas_fab\src\compas_fab\backends\kinematics\analytical_inverse_kinematics.py:docstring of compas_fab.backends.kinematics.analytical_inverse_kinematics.AnalyticalInverseKinematics.inverse_kinematics:23: WARNING: Block quote ends without a blank line; unexpected unindent.
C:\Users\leungp\Documents\GitHub\compas_fab\src\compas_fab\backends\pybullet\planner.py:docstring of compas_fab.backends.pybullet.planner.PyBulletPlanner.add_attached_collision_mesh:18: WARNING: Inline literal start-string without end-string.
C:\Users\leungp\Documents\GitHub\compas_fab\src\compas_fab\backends\pybullet\planner.py:docstring of compas_fab.backends.pybullet.planner.PyBulletPlanner.add_attached_collision_mesh:18: WARNING: Inline literal start-string without end-string.
C:\Users\leungp\anaconda3\envs\cf-dev\Lib\site-packages\roslibpy\ros.py:docstring of roslibpy.ros.Ros.blocking_call_from_thread:7: ERROR: Unexpected indentation.
C:\Users\leungp\anaconda3\envs\cf-dev\Lilooking for now-outdated files... b\site-packages\roslibpy\ros.py:docstring of roslibpy.ros.Ros.call_sync_service:9: ERROR: Unexpected indentation.
C:\Users\leungp\anaconda3\envs\cf-dev\Lib\site-packages\roslibpy\ros.py:docstring of roslibpy.ros.Ros.off:6: ERROR: Unexpected indentation.
C:\Users\leungp\Documents\GitHub\compas_fab\src\compas_fab\robots\reachability_map\reachability_map.py:docstring of compas_fab.robots.reachability_map.reachability_map.ReachabilityMap:15: CRITICAL: Unexpected section title.

Links
-----
C:\Users\leungp\Documents\GitHub\compas_fab\src\compas_fab\robots\trajectory.py:docstring of compas_fab.robots.trajectory.Trajectory:4: CRITICAL: Unexpected section title.

What type of change is this?

[ ] Bug fix in a backwards-compatible manner.
[ ] New feature in a backwards-compatible manner.
[ ] Breaking change: bug fix or new feature that involve incompatible API changes.
[x] Other (e.g. doc update, configuration, etc)

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[ ] I added a line to the CHANGELOG.md file in the Unreleased section under the most fitting heading (e.g. Added, Changed, Removed).
[ ] I ran all tests on my computer and it's all green (i.e. invoke test).
[ ] I ran lint on my computer and there are no errors (i.e. invoke lint).
[ ] I added new functions/classes and made them available on a second-level import, e.g. compas_fab.robots.CollisionMesh.
[ ] I have added tests that prove my fix is effective or that my feature works.
[ ] I have added necessary documentation (if appropriate)

This PR is based on the https://github.com/compas-dev/compas_fab/pull/394 because a bunch of error is present in the V-Rep part, since that is going away, I'm not fixing those mistakes.
#394 should be reviewed and merged before this one.

@chenkasirer or @gonzalocasas
Maybe if anyone of you wants to review this.


site-docker: make it more readable

These conditions introduced by d981c6bd2 were insane.
This should be a bit easier to read.
Signed-off-by: Guillaume Abrioux<EMAIL_ADDRESS>

jenkins test luminous-ansible2.4-docker_cluster

jenkins test luminous-ansible2.4-docker_cluster

@guits luminous-ansible2.4-docker_cluster_collocation is failing, did you rebase on top of your mds patch?

@leseb I thought I had but apparently no

jenkins test luminous-ansible2.4-bluestore_osds_container

jenkins test this please


Problems with VLC 2.2.6 and 3.0.0 while playing HLS (.M3U8)

I have an issue / a question (pick one) about Vlc.DotNet.
Generic information

Vlc.DotNet version : 2.2.1
Vlc.DotNet project used : WPF
libvlc version : x86 and x64
.net version : 4.0
Project language : C#
Project build architecture : AnyCPU
Operating system : Windows 7 Professional (x64) in VirtualBox

Summary
I'm doing tests with HLS (.M3U8) and the following is happening to me (these are some examples):
HLS v3 "https://bitdash-a.akamaihd.net/content/MI201109210084_1/m3u8s/f08e80da-bf1d-4e3d-8899-f0f6155f6efa.m3u8" (NO AUDIO in VLC 2.2.6 and sometimes fails, OK in 3.0.0).
HLS v1 "https://bitdash-a.akamaihd.net/content/sintel/hls/playlist.m3u8" (HAS NO AUDIO in VLC 2.2.6 and sometimes fails, OK in 3.0.0)
HLS v3 "https://mnmedias.api.telequebec.tv/m3u8/29880.m3u8" (OK in 2.2.6, in 3.0.0 saturates memory and does not play)
HLS v5 "http://<IP_ADDRESS>/vod/smil:BigBuckBunny.smil/playlist.m3u8" (Does NOT work in 2.2.6, OK in 3.0.0)
HLS v3 "http://www.streambox.fr/playlists/test_001/stream.m3u8" (OK in 2.2.6, in 3.0.0 saturates memory and does not play)
In the cases where I write "sometimes fails", the error is always "The program '[844] X.exe' ended with code -1073741819 (0xc0000005) 'Access violation'." What is curious is that with the version of VLC 3.0.0 in the desktop program, the cases where I write "saturates memory and does not play" work perfectly. I understand that these problems are due to the wrapper, but I can not find an explanation. Remember that I am using Visual Studio 2017. Is anyone else experiencing these problems?
Log output is here: https://pastebin.com/9bdmmGtQ. Someone can try the "https://github.com/ZeBobo5/Vlc.DotNet/tree/develop/src/Samples/Vlc.DotNet.Wpf.Samples" with the sample HLS "http://www.streambox.fr/playlists/test_001/stream.m3u8", Vlc.DotNet 2.2.1 and VLC 3.0.0? It would be good for me to know if it is a problem of mine or of the library itself (with the "Vlc.DotNet.Wpf.Samples" the memory is also saturated and no image of the video is shown).
Thanks!!!

Hi,
I tried with VLC 3.0.0 (not libvlc but the media player) with the stream : http://www.streambox.fr/playlists/test_001/stream.m3u8
It turns out that the stream stops after 3s, the memory increases and then after a while, VLC gives up.
Could you try again and confirm that your issue only happen in Vlc.DotNet and not in VLC itself on your side?


Query by ID not working for one specific ID

The following fails only for the specific ID in the example.
When I use a different ID, everything is fine.
It would be helpful to get an error message out of chromedp.Run, but if I don't use the timeout context, the program hangs forever.
What versions are you running?
github.com/chromedp/chromedp v0.9.1
$ google-chrome --version
Google Chrome 111.0.5563.146
$ go version
go version go1.19.5 linux/amd64

What did you do? Include clear steps.

func main() {
	actx, acancel := chromedp.NewRemoteAllocator(ctx, "http://<IP_ADDRESS>:9222")
	defer acancel()
	cctx, _ := chromedp.NewContext(actx)
	tctx, _ := context.WithTimeout(cctx, 10*time.Second)

	html := `<!DOCTYPE html>
<html>
<head>
    <title>
        Foo
    </title>
</head>
<body>
    <div id="32a66fae-42b6-4e80-a9e6-c559579c01b0">
        Bar
    </div>
</body>
</html>`

	var buf []byte
	if err := chromedp.Run(tctx,
		chromedp.Navigate("about:blank"),
		chromedp.ActionFunc(func(ctx context.Context) error {
			frameTree, err := page.GetFrameTree().Do(ctx)
			if err != nil {
				return err
			}
			return page.SetDocumentContent(frameTree.Frame.ID, html).Do(ctx)
		}),
		chromedp.Screenshot("32a66fae-42b6-4e80-a9e6-c559579c01b0", &buf, chromedp.NodeReady, chromedp.ByID),
	); err != nil {
		panic(err)
	}
	if err := os.WriteFile("/tmp/test.png", buf, 0644); err != nil {
		panic(err)
	}
}

What did you expect to see?
The screenshot is written to disk and the program terminates successfully.
What did you see instead?
The context times out after 10 seconds.

I don't know why, but an id started with a number should be escaped. See also #1236.
If you execute document.querySelector('#3') directly in the DevTools, you will see error message like this:
Uncaught DOMException: Failed to execute 'querySelector' on 'Document': '#3' is not a valid selector.

And the following video shows that DevTools will escape such kind of ids:
https://user-images.githubusercontent.com/1063615/234017209-78a5f03a-bab9-43d0-ba6b-f07a0fad7ae7.mp4
Note: 33 is 0x33 (decimal 51), which is the ASCII of the character 3.

It would be helpful to get an error message out of chromedp.Run, but if I don't use the timeout context, the program hangs forever.

The query action is designed to wait until the query result matches the criteria or times out. But it does not make sense to retry an invalid id which we know will always fail. So this requirement is fair. I'm working on it.

It's cumbersome that the CDP only gives us this information for an invalid selector:
{"id":31,"error":{"code":-32000,"message":"DOM Error while querying"},"sessionId":"271FFAC187A099BAAE06AECDB1E3807B"}

Maybe some of the cases are temporary and we should keep retrying. I'm not sure whether #1303 will be merged.

I don't know why, but an id started with a number should be escaped. See also #1236.

Thank you so much for your thoughtful response!
Appreciate the great work on this.


Vulnerability roundup 81: libbsd-0.9.1: 1 advisory

search, files

[ ] CVE-2019-20367 CVSSv3=9.1 (nixos-19.03, nixos-19.09)

Scanned versions: nixos-19.03: c8db7a8a16e; nixos-19.09: eb65d1dae62. May contain false positives.

Closing as NixOS 19.03 and 19.09 are no longer supported.


WIP: increase the psalm error level from 3 to 2

Codecov Report

Merging #249 (740d204) into main (c8c48b2) will decrease coverage by 0.07%.
The diff coverage is 94.73%.

@@             Coverage Diff              @@
##               main     #249      +/-   ##
============================================
- Coverage     92.83%   92.76%   -0.08%
- Complexity      333      340       +7
============================================
  Files            56       55       -1
  Lines           879      898      +19
============================================
+ Hits            816      833      +17
- Misses           63       65       +2

Impacted Files
Coverage Δ

src/CLI/Application.php
0.00% <ø> (ø)

src/CLI/Command/Init.php
85.71% <ø> (ø)

src/Rules/Constraints.php
100.00% <ø> (ø)

src/Rules/Specs.php
100.00% <ø> (ø)

src/Analyzer/FileVisitor.php
84.37% <85.71%> (-0.82%)
:arrow_down:

src/Analyzer/ClassDescription.php
95.91% <100.00%> (+0.08%)
:arrow_up:

src/Analyzer/ClassDescriptionBuilder.php
93.33% <100.00%> (+0.83%)
:arrow_up:

src/Analyzer/FileParser.php
85.71% <100.00%> (+0.52%)
:arrow_up:

src/CLI/Check.php
84.50% <100.00%> (ø)

src/CLI/Progress/ProgressBarProgress.php
100.00% <100.00%> (ø)

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c668b1a...740d204. Read the comment docs.

it seems the build problem is related to composer, as it complains about unsupported PHP version

The same problem is in the other PR too:
https://github.com/phparkitect/arkitect/pull/252
We can try to use for example version: 1 instead of version: 2 @micheleorselli

Yeah, it was that now it's all green.
Do you think that it's better to solve the problem in another little PR moving last commit from here @micheleorselli ?

let's stick with version 2. composer 1 is unsupported and slow as hell. Version 2.2.12 should be compatible with our PHP version

@micheleorselli I tried with composer 2 and that specific version without success.


An thrift protocol request question

The realization of the work for envoy.filters.network.thrift_proxy:
When a Thrift protocol request goes to the Envoy, the Envoy decodes the request through the ThriftFilter, converts it into a new HTTP request, and sends the HTTP request to the back-end service. When the response from the back-end service arrives, the Envoy converts the HTTP response into the Thrift serialization format and sends it back to the client.
Am I reading this correctly?
Waiting for your reply, thank you!

cc @JuniorHsu as code-owner.

@JuniorHsu
Waiting for your answer, thank you！

There's no HTTP protocol involved. It's thrift_proxy so envoy basically proxy the thrift request to the upstream and the thrift response back to the downstream. We can do metrics/load balancing/routing/filter from features of thrift like thrift header or method. The connection model is like HTTP1 at the moment, i.e., ping-pong model.

There's no HTTP protocol involved. It's thrift_proxy so envoy basically proxy the thrift request to the upstream and the thrift response back to the downstream. We can do metrics/load balancing/routing/filter from features of thrift like thrift header or method. The connection model is like HTTP1 at the moment, i.e., ping-pong model.

Thank you very much for your reply!


force layout right away

the thing is when I call reloadData and tries to get the visiblecells it's empty because layoutSubviews hasn't be called yet. so with this it will force layoutSubviews right away. Let me know if this is okay.

Cool. I want to remove self.
from self.layoutIfNeeded() to layoutIfNeeded().
Thank you.

@KyoheiG3 updated. removed self

Thank you!!


Fix CI

This PR makes sure that we fail if the cmake call isn't successfull. Furthermore, we first try if the LAPACK interface provided by deal.II is sufficient for LAPACKE and only search for an additional library if that fails.
Alternative to #158.

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@bb90114). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #159   +/-   ##
=========================================
  Coverage          ?   89.09%
=========================================
  Files             ?       53
  Lines             ?     2503
  Branches          ?        0
=========================================
  Hits              ?     2230
  Misses            ?      273
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb90114...4a5aef6. Read the comment docs.


Migrate basic components from 2024

[x] robot.py
[x] chassis
[x] vision
[x] tests

Do it bit-by-bit. Doesn't need to be all in one. Just get started.

Should be done now


Xylophone needs a website

The README currently links to propensive.com promising more info about Xylophone, but none can be found.

Thanks, @dwijnand. I've broadened the scope of the issue, though I'll make a quick change to the README to remove the incorrect link for now.


refactor bonfire tests to use assert instead of expect

Closing because basic bonfires have been done and there are different issues for the other bonfires.


Quote include of file in same directory failing to be found

This time, repro'ed within DWYU test case :)
looks like if you have a single build rule with two headers in sub directories, one including the other, DWYU doesn't find the locally sourced header.
Tested with:
bazel build   --aspects=//my_awesome:aspect.bzl%your_dwyu_aspect --output_groups=cc_dwyu_output --override_repository=depend_on_what_you_use=/home/michael.johnson/code/depend_on_what_you_use @depend_on_what_you_use//test/aspect/includes:includes2
0001-Add-relative-include.patch

Confirmed that bazel build :include2 succeeded while bazel build --config=dwyu failed.
the content of deps_info.json:
{
	"self": {
		"headers": [
			"dir/includes.h",
			"dir/includes2.h",
		],
		"target": "@//test/aspect/includes:includes2"
	}

Changing either #include "includes.h" to #include "dir/includes.h" in includes2.h or add
some/sub/dir to the includes for includes2 in the BUILD file will make DWYU happy.
So the issue for this case is, should the current directory taken into account by default,
even if it wasn't specified via includeds ?

Thanks for reporting this issue. Processing such relative includes should indeed work and consequently this is a bug in DWYU.
Theoretically this feature is already supported. A basic tests exists here. Those relative includes are detected correctly. It seems though there are still open edge cases.
I will look into this as soon as I have some spare time.

At first glance, @mjj47 's case can be addressed by simply adding the following line after dwyu.bzl#70:
includes.append(hdr.path.rpartition("/")[-1])

However, it wouldn't cover cases like the following
$ cat > foo.h <<EOF
cat foo.h
#ifndef FOO_H_
#define FOO_H_
int foo();
#endif // FOO_H_
<<EOF
$ cat > foo.cc <<EOF
#include "foo.h"
int foo() { return 42; }
EOF
$ cat > main.cc <<EOF
#include "foo.h"
int main() {
    return foo();
}
<<EOF
$ cat > BUILD <<EOF
cc_library(
    name = "foo",
    srcs = ["foo.cc"],
    hdrs = ["foo.h"],
)
cc_binary(
   name = "use_foo",
   srcs = ["main.cc"],
   deps = [":foo"],
)
EOF

To handle the case above, we seem to add the following line after dwyu.bzl#52, which will cover both @mjj47 's case and the case above.
However, this may raise another issue, What if two deps (listed in a target's deps section or from transitive deps) providing two headers with the same basename? What should we do in this situation?
This is the situations what best practices means:

Make all include paths relative to the workspace directory.
-- From Bazel's best practice for C++
Include the directory when naming header files.
-- From cpplint/cpplint:cpplint.py.

I did some investigation into this issue.
The more I look into this, the more complex it becomes. On a first glance the solutions presented by @storypku seem to resolve the issue. But one can create more complex examples for which they no longer work (e.g. relative includes into sub directories).
The problem seems solvable to me. But I expect it requires a rewrite of the "relative includes" logic to work more general on the file system locations of the header files.

I have locally a prototype which seems to handle this issue
There are still some quirks which have to be resolved and code refactored. I have no ETA due to being quite busy with other things. But fixing this issue is in steady, albeit slow, progress.

The issue should now be resolved with these changes https://github.com/martis42/depend_on_what_you_use/issues
In the next days I will create also a new release containing this fix


ConvLSTM2D layer wrong computation

System information.

Have I written custom code (as opposed to using a stock example script provided in Keras: no
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Ubuntu 20.04
TensorFlow installed from (source or binary): binary
TensorFlow version (use command below): v2.4.0-rc4-71-g582c8d236cb 2.4.0
Python version: 3.8.5

Describe the problem.
There seems to be something wrong with the computation of the ConvLSTM2D layer. I tried to do the computation manually for a simplified example and I come to a different result. I think there might be a bug in the last round of the layer. The issue is illustrated in the example below.
Describe the expected behavior.
The output that I expected from the simple example model is [[[[[   0.], [   8.]]], [[[ 0.],[1053.]]]]], but instead the actual output is [[[[[   0.], [   8.]]], [[[ 512.],[1053.]]]]].
Standalone code to reproduce the issue.
import tensorflow as tf
from tensorflow import keras
from tensorflow.keras import layers
import numpy as np
tf.keras.backend.set_floatx('float64')
model = keras.Sequential([
keras.layers.ConvLSTM2D(1, (1, 2), return_sequences=True, padding='valid', strides=(1,1),recurrent_activation='linear', activation='linear',  input_shape=(2, 1, 3, 1))])
w = model.get_weights()
w[0] = np.array([[[[1, 1, 1, 1]],[[1, 1, 1, 1]]]])
w[1] = np.array([[[[1, 1, 1, 1]],[[1, 1, 1, 1]]]])
w[2] = np.array([0, 0, 0, 0])
model.set_weights(w)
x = tf.constant([[[[[0], [0], [2]]], [[[0], [0], [1]]]]])
print (np.array2string(model.predict(x,steps=1), separator=', '))

@jvishnuvardhan ,
I was able to reproduce the issue in tf v2.5.v2.6 and nightly.Please find the gist of it here.

@rschumi0 Why do you think this is a wrong computation? Can you please check with couple of more computations. Thanks!

@jvishnuvardhan I investigated the intermediate steps of the layer and performed the calculations as described in the reference paper from the documentation. I tried many examples, and in many cases the implementation seems to be fine, but in a number of cases there were unexpected results. I suspect there might be an issue with the dataflow between the rounds of the algorithm, e.g., the inputs or weights might not be passed on as they should be.

@rschumi0 I quickly changed part of weights from
w[1] = np.array([[[[1, 1, 1, 1]],[[1, 1, 1, 1]]]])
to
w[1] = np.array([[[[1, 1, 1, 1]],[[0, 0, 0, 0]]]])
With that change, the output is what you are expecting
[[[[[   0.],
    [   8.]]],

  [[[   0.],
    [1053.]]]]]

Can you please share other cases where you think you got unexpected results. Thanks!

@jvishnuvardhan Sorry, but adopting the weights doesn't help for this issue. There seems to be something wrong with the computation within the layer, so it doesn't make sense to change the weights to get an expected results. It would be important to have a closer look at the implementation of the layer and, e.g., check if the data flow of all variables and weights is correct and if the implementation really follows the algorithm as it was published in the original paper.

I think the result is working as intended.
Please note that the first element in the 2nd timestep result is not 0 since the state from the first step is used as the input state for the second step.
Please make sure to provide detailed justification/math formula about your expected result.


Oscar Basket django.db.models RelatedObjectDoesNotExist : Line has no basket

Django db error when updating basket line.
Issue Summary
I have added extra fields in StockRecord model, same fields is added in basket line model.
i have saved the extra field in db and use it to calculate final total of basket line.
but due to no reason the following error is coming at update function
django.db.models.fields.related_descriptors.RelatedObjectDoesNotExist: Line has no basket.
Hope i got some help

You will need to provide a bit more information for us to be able to help - specifically how you have changed both the StockRecord and basket Line models, and what your update function is doing.

#my stockrecord extended model

from oscar.apps.partner.abstract_models import AbstractPartner, AbstractStockRecord
class StockRecord(AbstractStockRecord):
    extra_field = models.DecimalField(decimal_places=2, max_digits=12, blank=True, null=True)
from oscar.apps.partner.models import *

#my basket line model
from oscar.apps.basket.abstract_models import AbstractLine, AbstractBasket
class Line(AbstractLine):
    extra_field = models.DecimalField(decimal_places=2, max_digits=12, blank=True, null=True)
from oscar.apps.basket.models import *

This how i have extented the models, and i partner/strategy.py

class NoTax(object):
          def pricing_policy(self, product, stockrecord):
              if not stockrecord or stockrecord.price_excl_tax is None:
                 return UnavailablePrice()
            return FixedPrice(
                 currency=stockrecord.price_currency,
               excl_tax=stockrecord.price_excl_tax,
            extra_field=stockrecord.extra_field,
            tax=D('0.00'))


Error on cargo install ravedude

I was trying to follow the instructions here, but I get this error on cargo install ravedude:
error[E0658]: use of unstable library feature 'proc_macro_byte_character'
   --> /Users/5alv1.py/.cargo/registry/src/index.crates.io-6f17d22bba15001f/proc-macro2-1.0.92/src/wrapper.rs:895:21
    |
895 |                     proc_macro::Literal::byte_character(byte)
    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: see issue #115268 <https://github.com/rust-lang/rust/issues/115268> for more information
    = help: add `#![feature(proc_macro_byte_character)]` to the crate attributes to enable
    = note: this compiler was built on 2024-03-21; consider upgrading it if it is out of date

error[E0658]: use of unstable library feature 'proc_macro_c_str_literals'
   --> /Users/5alv1.py/.cargo/registry/src/index.crates.io-6f17d22bba15001f/proc-macro2-1.0.92/src/wrapper.rs:922:21
    |
922 |                     proc_macro::Literal::c_string(string)
    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: see issue #119750 <https://github.com/rust-lang/rust/issues/119750> for more information
    = help: add `#![feature(proc_macro_c_str_literals)]` to the crate attributes to enable
    = note: this compiler was built on 2024-03-21; consider upgrading it if it is out of date

   Compiling scopeguard v1.2.0
   Compiling colored v2.1.0
For more information about this error, try `rustc --explain E0658`.
error: could not compile `proc-macro2` (lib) due to 2 previous errors
warning: build failed, waiting for other jobs to finish...
error: failed to compile `ravedude v0.1.8`, intermediate artifacts can be found at `/var/folders/5n/chk9dp25163_njn2mr4z8myr0000gn/T/cargo-install1c9mEf`.
To reuse those artifacts with a future compilation, set the environment variable `CARGO_TARGET_DIR` to that path.

I'm on macOS 14.6.1 on a M1 Macbook air

I realized this is not the right repo.

I succesfully installed it with
cargo +stable install ravedude

Not sure if it will cause any problems

Hi,
using +stable is fine and even recommended - ravedude is meant to be build with the stable toolchain.
Can you do me a favour and see whether the non-stable toolchain installation works with --locked?

Without the +stable flag and using --locked the installation works

Thanks, this confirms what I expected.  I updated the instructions in the README to hopefully help others avoid running into this...


Does etlas will auto install with eta?

I had install eta 0.0.5b3 follow the blow guide.
http://eta-lang.org/docs/html/getting-started.html
The guide only ask me to install eta from code and then check both eta and etlas.
But after the eta had been installed, the etlas didn't install on my Mac.
I want to know does the etlas will auto install with eta, or I need download  etlas's code and install it?
If the etlas didn't auto install with eta, I think the guide need change.

Please do the installation steps again with 0.0.6b2. We had a breaking change (the build tool was renamed from epm to etlas) and the docs are written for 0.0.6+.


Accuracy and performance fixes for shifting and filter

This PR improves shifting in following ways:

recombine is not called after filter, because it's not needed
left-shifting is triggered when padding reaches 0 (was 1)
shift implementation switched to modulo wrapping instead of clamp to fix accuracy
padding is logged in debug logs during generation/prefill
added assert for checking if we have room for next token

@kdamaszk Please review

LGTM. I ran tests and confirmed good accuracy and performance.


Add ordered list styling for /help/ pages.

This adds a styling that puts the numbers in a Zulip brand green bubble
with white text for the number.

Automated message from Dropbox CLA bot
@brockwhittaker, it looks like you've already signed the Dropbox CLA. Thanks!

This is great!  Here's a screenshot to simplify discussion:

I think I would probably adjust the size a bit:

Maybe make the circles and numbers inside maybe 15-20% smaller
I might indent a bit more (maybe 30px) but have less space between the circle and the start of the text (e.g. 6-8px rather than 10px).

@synicalsyntax check this out, what do you think about those details?

All concerns addressed and fixed up into the commit.

Wow, this looks great, I'm impressed!
I have an issue though. When the number bullets continue onto more than one line, the text isn't indent and shows up under the number, unlike what we have now. Can you indent the text so that they don't go past the number?

For example, in the previous image, the text highlighted in red shouldn't scroll past "2."

@synicalsyntax this was talked about earlier and I think you're right that it should probably be indented so that the text doesn't flow all the way back to the side on the nth lines. I'll look into reworking the CSS to do that.

@brockwhittaker did you forget to push your update to this?

Updated PR with indented lines and better centered text at all zoom levels.

Merged, thanks @brockwhittaker!  This looks a ton nicer :).


Data widget example.

Commit 5119f5f added data() but this example shows how it's not obvious or possible to access the data once the widget has been created.
Looking for suggestions on how to access the data from the widget tree once the widget has been created.

This is sort of why I said that Cushy is the "View" layer if you were to think of a MVC type architecture. It isn't really meant to be the data storage layer -- it's meant to be the interactive representation of your model.
That being said, a WidgetInstance can be cloned cheaply and can be locked and downcasted back to the underlying widget type. So, while you are consuming the widget while building the Stack, you could make_widget() to get a WidgetInstance, store a clone, and then access it that way. However, at the moment you're storing a clone of the data widget -- why would you not just clone the original data and store that instead? That's what feels weird about trying to store data in Cushy -- to create the Data widget, you must provide the data to the widget. And to access the data stored in the hierarchy, you must somehow gain a reference to the correct widget. The same amount of work it takes to store the widget reference could easily store a copy of the data in question instead.
To me the Data widget is exactly what it is described as: a way to ensure some piece of data isn't dropped before widgets that rely on that data not being dropped are dropped themselves. That's what Cushy is using it for internally, and the main reason it exists. It really shouldn't be used by most users, and probably is only useful for exactly how the progress bar is using it: to use widget composition instead of creating a new Widget type and allowing for data to be stored in the hierarchy and kept alive until the composed widget is dropped.


Feature/graphql react codegen

CHANGELOG

added graphql codegen for

typescript-operations
typescript-react-apollo

updated codegen.yml config
generate web/src/graphql/operations.tsx
cleanup unnecessary query declarations
fix db clean up bug
update generate:schema -> generate:graphql

Now with the generated web/src/types/graphql.tsx we can simply use typesafe query/mutation hooks generated from backend/packages/graphql/api rather than declaring twice (on web and backend)
Example:
import { GET_USER_QUERY } from '@web/graphql';

const variables = {
  input: {
    id: 'demo_user_id'
  }
};

const { data, loading, error } = useQuery(GET_USER_QUERY, { variables });

The above can now be written as:
import { useGetUserQuery } from '@web/graphql';

const variables = {
  input: {
    id: 'demo_user_id'
  }
};

const { data, loading, error } = useGetUserQuery({ variables });

Thanks to @capaj for suggesting this improvement

thanks @karanpratapsingh.
This is a great improvement.

Glad you liked it 😁


W6001 does not work with !Sub

cfn-lint version: 0.5.1
Description of issue.
Given the following template:
  GitlabDomain:
    Description: The domain name of the Gitlab server
    Value: !Sub
    - 'gitlab.${zone}'
    - zone: !ImportValue infra-ZonePublic-Name

I get the warning W6001 but I am not using just the imported value but creating a new value based on it. This should not result in a warning.

Nice use case. I'll check it out, missed this. give me a moment

This should be resolved via #293 -- Can you validate, @hoegertn?

Seems to work


usb: using Bluetooth HCI class in composite device leads to conflicts

Describe the bug
Bluetooth Core Specification Version 5.3 Vol 4, Part B: USB Transport Layer, 2.1.1 Controller descriptors:

The Controller configuration consists of two interfaces. The first interface has
no alternate settings and contains the bulk and interrupt endpoints. The second
interface provides scalable isochronous bandwidth. The recommended
configuration for the second interface has four alternate settings that provide
different bandwidth. The default interface is empty so that the device is capable
of scaling down to zero isochronous bandwidth.

Zephyr Bluetooth USB class https://github.com/zephyrproject-rtos/zephyr/blob/02ee85c89321081e172e4966bcbf6e531ecac8bb/subsys/usb/device/class/bluetooth.c#L53-L58 only implements the first interface whereas host drivers expect two interfaces.
Linux kernel btusb driver will claim interface next to the Bluetooth Programming Interface (Class: 0xE0 Subclass: 0x01 Protocol: 0x01) regardless of that interface Class/Subclass/Protocol.
Zephyr implementation does not cause much issue on Linux if Bluetooth class is the only class appearing in CONFIGURATION descriptor. In such case, the usb_ifnum_to_if(data->udev, ifnum_base + 1); will return NULL and therefore btusb won't claim the isochronous interface.
If Zephyr Bluetooth class implementation is used in composite device and Bluetooth is the first interface, then Linux btusb driver will claim both the Bluetooth and one more interface, effectively preveting other composite function from working. Example include Bluetooth + DFU combination, where df-util will fail to claim interface because it is already claimed by btusb.
To Reproduce
Steps to reproduce the behavior:

Combine samples/subsys/usb/dfu with samples/bluetooth/hci_usb to form USB composite device
Try to use dfu-util to switch from DFU Runtime to DFU Mode Interface
Observe dfu-util: Cannot claim interface error

Expected behavior
Other class interfaces are not claimed by btusb driver and therefore DFU works as expected in Bluetooth+DFU composite device.
Impact
Annoyance, but can be showstopper for people who need both DFU and Bluetooth.
Logs and console output
Opening DFU capable USB device...
Device ID 2fe3:000b
Run-Time device DFU version 0110
Claiming USB DFU (Run-Time) Interface...
dfu-util: Cannot claim interface 1: LIBUSB_ERROR_BUSY

Environment (please complete the following information):

OS: Linux 6.1.7
Toolchain: Zephyr SDK 0.15.2
Zephyr 10130d8e6de8c3889f42d498d3de6115db8f2d35

Additional context
The workaround is to add dummy interface without any endpoints at the end of struct usb_bluetooth_config. Such a dummy interface will then get claimed by Linux kernel, however the lack of isochronous endpoints in the interface will result in hci0: invalid SCO descriptors error.
A better solution would be to at least add interface with 2 empty (wMaxPacketSize = 0) isochronous endpoints. Ideally, full isochronous support would be added with alternate configurations with varying wMaxPacketSize values.

@Vudentz would it be possible to change btusb driver so that it does not claim subsequent interface if bInterfaceClass, bInterfaceSubClass, and bInterfaceProtocol do not match codes defined in Bluetooth spec?

I cannot seem to find the hardcoded interface numbers (as referred to in Linux kernel source code) anywhere in Bluetooth Specification. Can it be that it used to that way and it got later removed from the specification? In such case, a patch to linux kernel would have a chance to get accepted.

@desowin @jfischer-no I have a workaround for the claimed interface by btusb on Linux(not on Zephyr).
sudo modprobe -r btusb
sudo dfu-util --alt 1 --download build/zephyr/zephyr.signed.bin
sudo modprobe -a btusb

So it will remove btusb driver temporarily on Linux while dfu-util is claiming its interface. It might be helpful temporarily to someone and hopefully fix this issue soon.

Bluetooth specification since version 4.0 only recommends and no longer requires specific interface numbers.
While earlier Bluetooth versions, i.e. 2.1 + EDR and 3.0 + HS, contain required configuration table in Volume 4 - Host Controller Interface Part B - USB Transport Layer, Bluetooth Core Specification Addendum 2 changes the table from required to recommended configuration.
I tried to remove the hardcoded interface number requirement from Linux btusb driver, but it then failed with
[  216.670590] Bluetooth: hci0: Opcode 0x c03 failed: -32

It turned out that SETUP packet "20 00 00 00 00 00 03 00 03 0c 00" was sent and Zephyr device replied to it with STALL. This is because bluetooth_class_handler is only called when the request wIndex is equal to Interface Number, even if the request is directed to Device (and not Interface).


spike: support validation with dependencies

Problem
With the additional of spatial data there are new validation requirements that go beyond what the current cellxgene-schema can support. There are now fields that depends on the validation and value of other fields. A spike is needed to determine how to add the interdependent fields to the schema.
Requirements

It must support cases where validation depends on other fields being validated first. This is required for spatial data.
It must support using other fields to determine validation process. This is required for spatial data.
It must support custom types. This will allow us to support anndata and dataframes, or add our own types like annotation_mapping

Outcome

a prototype that provided the required functionality
an estimate on the work needed to integrate
why other solution would not work.

Ideas
1 Update existing yaml
The current yaml defined schema does not support the level of functionality needed. New terms could be defined to support interdependent checks but the actual validation logic will still be implement in the python Validator code.
2 Try an off the shelf library
There are python library that exist that can help with validating the structure of data.

Cerberus
Pydantic

I'm limiting this spike to one week.

Current state
The current validator uses a yaml file which defines the schema and a python validator that interprets it. Over time, the validation requirements have grown in complexity. Unfortunately the schema defined in the yaml has not evolved to keep up. This has resulted in complexity being added to the validator when it should be in the yaml. This has made the validator difficult to test and maintain.
There is a severe lack of unit tests for the validator. This is because the validator is difficult to test. The specific rules to test are not well isolated and buried in if-else logic trees.
The current setup is good, but is not well suited for testing and it is reaching its limit in complexity.
Yaml

element_type key word uses parsing logic hidden in the validator. It could be written more clearly and reusably.
complex_rule and it's keys should be represented as a function with its keys as parameters. This would help make testing it easier.
deprecated_columns and reserved_columns should not be used in type: dict
we have a schema that validates and transforms the data which means its user for both validating the anndata and writing the labels.

index:
  unique: true
  type: feature_id
  add_labels:
    - type: feature_id

The yaml schema should be highly readable and configurable, where as the validation code should be written as performant and testable.

Problem with new tools
they will all require thinking about how we will translate the transformation keywords in the yaml. The libraries do support modifying the model at runtime, which means we won't be able to run validation and adding labels separately. More investigation is needed to see how we can work around this.
Cerberus

License: ISC
Website: https://docs.python-cerberus.org/en/stable/
3.1K stars on github

Cerberus is a lightweight and extensible data validation library for Python. Cerberus provides type checking and other validation features to ensure that the data is in the expected format.
Pros

will be able to remove a lot of the if logic in the validator. This will make the code easier to read and test.
Gives us access to validation workflow features we would have to implement ourselves.
unit testing would be limited to verifying customer rules and checks are working
supports checks that depend on other fields using Validator.document
allows us to continue to use the yaml schema and expand on it.
support custom rules and checks
many if the validation rules already follow the cerberus naming convention for example _check_deprecated_columns()

Cons

will need to rewrite the yaml schema to work with cerberus
will need to break down the anndata object into its components to validate each component because Cerberus assumes everything is a Mapping.
We will need to add support for dataframes and numpy arrays and any other nonstandard data types.
only throws errors, no off the shelf support for warnings. We'd need to subclass the error handler to support warnings.

pydantic
license: MIT
website: https://pydantic-docs.helpmanual.io/
lots of community support
18.5k stars on github
lots of examples
Pros

very large community
works with pandera for dataframes
it supports parallelized validation of models.
support validating class objects directly. Don't need to break down the anndata object into its components, but breaking it down will make it easier to test.
support for custom validators

Cons

would need a full rewrite of the validator
would no longer use the yaml schema
ease of testing would depend on how well the anndata object can be broken down into its components
Passing context between models is not straightforward which makes rules that depend on other fields difficult to implement.
not as straightforward for a non python developer to understand the validation rules.
steeper learning curve for the team.

pandera
license: MIT
website: https://www.union.ai/pandera
3K stars on github
integrates with pydantic, mainly used for dataframes.
If pydantic is used then we mine as well use pandera to validate the dataframes.
great expectations
license: Apache 2.0
website: https://greatexpectations.io/
9.4K stars on github
This is a large chain of tools for data validation. I did not have time to evaluate it, but based on the internet it would not be trivial to migrate to this tool, but it would be a good long term solution.
Links

comparing pandera and great expectations

Next steps
What ever course of action we take, we should start by writing a test suite for the current validator. This will help us understand the current behavior and make sure we don't break anything when we migrate to a new tool.

To implement the cerberus refactor it would take 3 Engineers x 2 months.

You may also want to review linkml  which was previously shared by @NoopDog.


svtyper throws exception on cnvnator vcf

When running svtyper on cnvnator.vcf I get this error:
Traceback (most recent call last):
  File "/usr/local/bin/svtyper", line 9, in <module>
    load_entry_point('svtyper==0.7.0', 'console_scripts', 'svtyper')()
  File "/usr/local/lib/python2.7/dist-packages/svtyper/classic.py", line 575, in cli
    sys.exit(main())
  File "/usr/local/lib/python2.7/dist-packages/svtyper/classic.py", line 568, in main
    args.max_ci_dist)
  File "/usr/local/lib/python2.7/dist-packages/svtyper/classic.py", line 265, in sv_genotype
    ciA = confidence_interval(var, 'CIPOS', 'CIPOS95', max_ci_dist)
  File "/usr/local/lib/python2.7/dist-packages/svtyper/parsers.py", line 12, in confidence_interval
    ci = map(int, var.info[tag].split(','))
KeyError: 'CIPOS'

Looking at this line and by investigating the python scripts being used, it seems like it should be the cvnator.ci.vcf file that should be the target of svtyper?
https://github.com/dnanexus/parliament2/blob/master/parliament2.sh#L471
The keys CIPOS and CIEND and several others are needed by svtyper and are not available in the original cnvnator.vcf file. This is according to this bug report in svtyper:
https://github.com/hall-lab/svtyper/issues/64

Thank you for reporting this issue! I will look into this.


Add missing newline to end of script

Scripts being text files should end with a newline character, both by convention and to make it play nice with the cat command.
I'm not experienced in Rust, so I'm not sure if this is the most appropriate place to add the newline character.

Thanks! But I think this is an issue in rattler. It looks like rattler doesn't print a newline after emitting code to execute a command:
https://github.com/mamba-org/rattler/blob/f6a3b9e78e5de8ed72fbad5efda313ca0731bb9c/crates/rattler_shell/src/shell/mod.rs#L306
I think that is wrong and should be fixed to solve this issue!


[feat] Remove languageOptions.parser from presets

Describe the problem
Follow-up #554.
Including languageOptions.parser in presets makes little sense and may result in a version mismatch between @typescript-eslint/parser and @typescript-eslint/eslint-plugin.
Describe the solution you'd like
Remove languageOptions.parser from presets. Also remove @typescript-eslint/parser from peer dependencies.
Alternatives considered
No response
Additional context
No response

TypeScript ESLint suggests installing package typescript-eslint for flat config, which makes the problem worse.


Using the manual_control.py script, pygame displays a black screen

<!--

Thanks for contributing to CARLA!

If you are reporting an issue, please use the following outline:

CARLA version:0.9.15 building from source
Platform/OS:Ubuntu18.04
Problem you have experienced:
hello developers:
When I click play in UE4editor to run Carla, the pygame window that pops up when running python3.8 manual_control.py in another terminal shows a black screen. Here is the picture:
![PixPin_2024-05-16_14-35-46](https://github.com/carla-simulator/carla/assets/51323253/d3b001ed-4dce-47aa-8e9d-bd123c74c185)

When I click play in UE4editor to run Carla, the pygame window that pops up when running python3.8 manual_control.py in another terminal shows a black screen. Here is the picture:

Could you bring us more information on your issue? Which version of CARLA are you using? Are you in WIndows or Linux? Did you build CARLA following the documentation?

I am using version 0.9.15 of carla, running on Ubuntu18.04, and build from source

Could you share the output of the shell where the manual control is running? Are there any errors?
Does the ego vehicle correctly spawn? You can check that for instance by inspecting the scene with the spectator.


Connect only one type of Wallet

I'm trying to enable connect only MetaMask Wallet in my dApp, but the new version of WalletModal doesn't support this option. It seems "includedWalletIds" include not only the selected Wallets (in my case:
final Set<String> includedWalletIds = {
  'c57ca95b47569778a828d19178114f4db188b89b763c899ba0be274e97267d96', // MetaMask
};

"excludedWalletIds" seems work, but V3 doesn't have the option exclude ALL other Wallets (like in V2:
recommendedWalletIds: {
      'c57ca95b47569778a828d19178114f4db188b89b763c899ba0be274e97267d96', // MetaMask
    },

excludedWalletState: ExcludedWalletState.all,

Do you plan any similar options?
Thanks...

Hello @MrCube72 , a fix is coming for your first issue, see here -> https://github.com/WalletConnect/Web3ModalFlutter/issues/56

but V3 doesn't have the option exclude ALL other Wallets (like in V2:
There is no exclude all options, on V3 either you pass a set of included wallets (that would be the only wallets to show) or you pass a set of excluded wallets to hide them).

I'll close this issue as duplicate, keep an eye on https://github.com/WalletConnect/Web3ModalFlutter/issues/56 but the fix is most likely to be shipped today

Hello @MrCube72 ! Issue has been fixed in latest beta
dependencies:
  web3modal_flutter: ^3.0.0-beta18


Study of Committee Rotation to make a document and plan the roadmap.

Following up the initial call some weeks ago.
We have a set of main questions that we want to answer.
Right now I am working on making a comparison table between existing solutions.
The idea is that with this in hand we can draft options for IOTA 2.0+ and decide which ones are the best.
After Nikita and Sebastian are available next week, I plan to schedule a call to discuss the progress and next steps on this.
After the Table is done, I will start a proper document.

Plan is to study Filecoin, Algorand and Witnet
Filecoin and Algorand is (almost) done
Call set up for Monday with Sebastian and Nikita
Maybe get other potential protocols to check
Draft main discussion points for IOTA 2.0
Next plan aside from this is to finish the table (witnet is the last one to check) before the call.

Project is on hold following the new direction.


import fails

Refer to : https://github.com/BuildFire/peoplePlugin/issues/35

This was due to some error in case of fresh data. I have resolved this error now. Please test and let me know if it still doesn't work.


minor: add GetSchemaTypeMapping rest api

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

[X] N
[ ] Y

2. What is the scope of this PR (e.g. component or file name):
pkg/service/rest_server.go

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):
minor: add GetSchemaTypeMapping rest api

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

[ ] N
[ ] Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

[ ] Unit test
[ ] Integration test
[ ] Benchmark (add benchmark stats below)
[ ] Manual test (add detailed scripts or steps below)
[ ] Other

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

1 of 6 (16.67%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.07%) to 64.605%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/service/rest_server.go
1
6
16.67%

Totals

Change from base Build<PHONE_NUMBER>:
-0.07%

Covered Lines:
2612

Relevant Lines:
4043

💛  - Coveralls


Incorrect indentation after multi-line statements

When typing a multi-line statement, VS Code incorrectly indents the lines following it.
https://github.com/mathworks/MATLAB-extension-for-vscode/assets/8674612/2f3ecffe-0beb-442b-b623-4320a3346f66
If you type the same lines in the official MATLAB IDE, this indentation does not occur because MATLAB correctly identifies this indent as part of a mutli-line statement.
https://github.com/mathworks/MATLAB-extension-for-vscode/assets/8674612/2c42fcc9-ad98-421f-86b7-e9800c76807a
This is related to Issue #85, where the extension does not seem to handle multi-line statements correctly in general.

Closing this as a duplicate of #85. The fix for that issue should address this as well.


Toggle focus on the search box

When you open a select on mobile devices, the focus occurs on the search field and the keyboard appears, this is very annoying. I propose to add the ability to disable.

I like to have this functionality also.


Binding SwiftUI not working on iOS 16.3

@Binding var html: String
MarkupEditorView(html: $html)
SwiftUI @Binding or @State
not working on iPhone SE 2020 iOS 16.3

found it on demo app setRawText()


Use pylintrc according to Google Python Style Guide

Use pylintrc according to Google Python Style Guide
See:
https://google.github.io/styleguide/pyguide.html
In addition

updating contribute.rst to refer to the new style guide
fixing 3 minor liner issues as a result of the pylintrc change

We already run pylint

pycodestyle as far as I know is a subset of pylint, Why do we want to enable both?

Changed the pull request to adhare to google python code styling for the meoment
with pycodestyle it is possible to find more easily stupid errors without spending too much time on pylint configuration


about doc

Hello, thank you for this great crate. I just want to point out that there is no example to show that you can configure multiple crates in a row with a comma:
RUST_LOG = "data=debug,hardware=debug"

Also, I lost a lot of time because I had a crate called fan-control, and the correct name to configure it was fan_control, I think it would be good to mention it in the docs.
Thanks

Technically we do describe this syntax

The value of this environment variable is a comma-separated list of logging directives.

but that is easy to miss and showing it in the syntax, maybe with an example, could help.

Oh, looks like we do have examples at the end of the section.   Making tweaks to hopefully catch people's eye more.


NMS.MK.JOBAID.002 - Track usage in pulses

MK service shall maintain the pulses consumed by FLW for MK usage.
(The SRS doesn't have a similar req. for MA but that req. does exist)

Done in sprint 1


Possible to create one RSS for all people you follow?

Thanks so much for making this!
I am hoping to create one single RSS feed that combines all people I follow on Bluesky (I had something similar for Twitter, where I had one RSS feed for everyone I had put on a particular list. RIP).
Right now, it looks like the only way I can follow others by RSS is to create an individual feed for each of their accounts.  Not impossible, but certainly a lot messier in my RSS reader.
Is there a way I could use this project to create one RSS feed for everyone I'm following?

Thank you for creating issue 🥰
My answer is : you can't do that in https://bluestream.deno.dev but you can do that in your own environment and your own credentials.
Please fork and update this project to create your timeline feed.
This project uses getAuthorFeed to get the posts of a specific user. We can retrieve the posts of followees by changing this to getTimeline.
However, this only returns timeline of login user, then password is needed  (this is the limitation of atproto-api 😓  ).
It is difficult to store credentials because this project is RSS feed, so I do not plan to add the feature.


Fix: Form validation runs on blur in New task details page

Details

Form validation runs inadvertently when the page is blurred. This PR fixes that.
Fixed Issues

$ https://github.com/Expensify/App/issues/23552
PROPOSAL: https://github.com/Expensify/App/issues/23552#issuecomment-1652757041
Tests

Login with any account
Press FAB >> Assign task
Move focus to another window (i.e. put the App to background)
Move focus back to the App
Verify that no errors appear in the form

[x] Verify that no errors appear in the JS console

Offline tests

NA
QA Steps

Login with any account
Press FAB >> Assign task
Move focus to another window (i.e. put the App to background)
Move focus back to the App
Verify that no errors appear in the form

[ ] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

https://github.com/Expensify/App/assets/113963320/3c35bdb0-60e9-465e-a38a-3391593042d3

Mobile Web - Chrome

https://github.com/Expensify/App/assets/113963320/1c8811df-c25d-48aa-9f5a-7bcc34c6aae9

Mobile Web - Safari

https://github.com/Expensify/App/assets/113963320/42d1394a-7fa0-4c99-9f2d-76008e7008a8

Desktop

https://github.com/Expensify/App/assets/113963320/aa015912-57d4-47f7-8be4-00069c598a3c

iOS

https://github.com/Expensify/App/assets/113963320/f6aebf39-594b-4c86-8c7e-f5d5aa6c2095

Android

https://github.com/Expensify/App/assets/113963320/7a414913-c531-4932-8d85-2812ff3569b5

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/thienlnam in version: 1.3.51-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/Julesssss in version: 1.3.51-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/thienlnam in version: 1.3.52-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
failure ❌

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/thienlnam in version: 1.3.52-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.52-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Check VSCode Workspace Extensions page

Tasks

[x] Make the VSCode Workspace Extensions page and extensions.json match.

Estimated Time: 20min
Writing the Issue

[x] Write each task for this issue using checkboxes
[x] Write all verbal instructions as tasks
[x] Add labels and assignees

Before Working on the Issue

[x] Assign yourself
[x] Share your screen on Discord
[x] Write which issue you are starting on Slack
[x] Git: Fetch the latest main
[ ] Git: Create a branch with the name of the issue

Pre-PR Checks

[ ] Insure that changes include only what is necessary for this PR
[ ] Implement necessary Unit tests
[ ] Implement necessary E2E tests
[ ] Perform functionality checks

extension.json の内容は VSCode Workspace Extensions ページに全て反映されていました。


Brightcove player not being detected

[X] I've verified and I assure that I'm running youtube-dl 2016.04.06
[X] At least skimmed through README and most notably FAQ and BUGS sections
[X] Searched the bugtracker for similar issues including closed ones

What is the purpose of your issue?

[X] Bug report (encountered problems with youtube-dl)

Description of your issue, suggested solution and other information
Brightcove Player is not being detected on people.com (a major website, ranked 620 on alexa) and ew.com. I'm not sure if this falls under a site support request or bug, but I believe it's a bug because of what I mention at the bottom (and the fact that this player is detected fine on most other sites).
Example page(s):
http://www.people.com/people/videos/0,,20999362,00.html
http://www.people.com/people/videos/0,,20991602,00.html
http://www.people.com/article/greys-anatomy-exclusive-is-meredith-moving-on-mcdreamy
Many more video links: http://www.people.com/people/videos/
http://www.ew.com/article/2016/02/02/supernatural-sneak-peek-winchesters-jody-mills
http://www.ew.com/article/2016/03/11/bates-motel-sneak-peek-norman-threatens-norma
youtube-dl output:
iMac:~ Sean$ youtube-dl -v http://www.people.com/people/videos/0,,20991602,00.html
[debug] System config: []
[debug] User config: []
[debug] Command-line args: [u'-v', u'http://www.people.com/people/videos/0,,20991602,00.html']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2016.04.06
[debug] Python version 2.7.11 - Darwin-15.3.0-x86_64-i386-64bit
[debug] exe versions: ffmpeg 3.0.1, ffprobe 3.0.1, rtmpdump 2.4
[debug] Proxy map: {}
[generic] 0,,20991602,00: Requesting header
WARNING: Falling back on generic information extractor.
[generic] 0,,20991602,00: Downloading webpage
[generic] 0,,20991602,00: Extracting information
ERROR: Unsupported URL: http://www.people.com/people/videos/0,,20991602,00.html
Traceback (most recent call last):
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/generic.py", line 1348, in _real_extract
    doc = compat_etree_fromstring(webpage.encode('utf-8'))
  File "/usr/local/bin/youtube-dl/youtube_dl/compat.py", line 279, in compat_etree_fromstring
    doc = _XML(text, parser=etree.XMLParser(target=etree.TreeBuilder(element_factory=_element_factory)))
  File "/usr/local/bin/youtube-dl/youtube_dl/compat.py", line 268, in _XML
    parser.feed(text)
  File "/usr/local/Cellar/python/2.7.11/Frameworks/Python.framework/Versions/2.7/lib/python2.7/xml/etree/ElementTree.py", line 1642, in feed
    self._raiseerror(v)
  File "/usr/local/Cellar/python/2.7.11/Frameworks/Python.framework/Versions/2.7/lib/python2.7/xml/etree/ElementTree.py", line 1506, in _raiseerror
    raise err
ParseError: not well-formed (invalid token): line 36, column 161
Traceback (most recent call last):
  File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 669, in extract_info
    ie_result = ie.extract(url)
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 323, in extract
    return self._real_extract(url)
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/generic.py", line 2012, in _real_extract
    raise UnsupportedError(url)
UnsupportedError: Unsupported URL: http://www.people.com/people/videos/0,,20991602,00.html

Using Firefox extensions/web tools I was able to get this link from that page which works with youtube-dl (when wrapped in quotes):
http://admin.brightcove.com/viewer/us20151216.1310/BrightcoveBootloader.swf?playerID=3476534560001&playerKey=AQ~~%2CAAAAABjSC6Q~%2CpGevSATpV8E-Iy5Qd4HGKkonZVLcEf1Y&purl=http%3A%2F%2Fwww.people.com%2Farticle%2Fgreys-anatomy-exclusive-is-meredith-moving-on-mcdreamy&%40videoPlayer=4812242623001&adServerURL=http%3A%2F%2Fpubads.g.doubleclick.net%2Fgampad%2Fads%3Fenv%3Dvp%26gdfp_req%3D1%26impl%3Ds%26output%3Dvast%26iu%3D%2F8484%2Fpeo%2Fvideo_bc%2Fnewsembed_bc%26sz%3D1000x1%26unviewed_position_start%3D1%26url%3D[referrer_url]%26correlator%3D[timestamp]&additionalAdTargetingParams=%3Bchann%3DBrightcove&autoStart=&bgcolor=%23FFFFFF&debuggerID=&dynamicStreaming=true&flashID=myExperience4812242623001&height=338&includeAPI=true&isUI=true&isVid=true&originalTemplateReadyHandler=PVonTemplateReady&startTime=1460416356415&templateLoadHandler=PVonTemplateLoad&templateReadyHandler=brightcove["templateReadyHandlermyExperience4812242623001"]&width=600&wmode=transparent
I am guessing something in there is breaking the way youtube-dl detects for this player and perhaps by fixing this it could improve Brightcove detection on other sites too...

Will you add this soon? Still don't work
C:\Users\Desktop\youtube-dl>youtube-dl.exe -f best --all-subs http://ew.com/tv/2017/03/08/guardians-galaxy-cartoon-exclusive-clip/ -v
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['-f', 'best', '--all-subs', 'http://ew.com/tv/2017/03/08/guardians-galaxy-cartoon-exclusive-clip/', '-v']
[debug] Encodings: locale cp1252, fs mbcs, out cp850, pref cp1252
[debug] youtube-dl version 2017.03.07
[debug] Python version 3.4.4 - Windows-10-10.0.14393
[debug] exe versions: ffmpeg N-83034-gf48b6b8, ffprobe N-83096-g6596b34
[debug] Proxy map: {}
[generic] guardians-galaxy-cartoon-exclusive-clip: Requesting header
WARNING: Falling back on generic information extractor.
[generic] guardians-galaxy-cartoon-exclusive-clip: Downloading webpage
[generic] guardians-galaxy-cartoon-exclusive-clip: Extracting information
ERROR: Unsupported URL: http://ew.com/tv/2017/03/08/guardians-galaxy-cartoon-exclusive-clip/
Traceback (most recent call last):
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpvin3ute2\build\youtube_dl\YoutubeDL.py", line 761, in extract_info
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpvin3ute2\build\youtube_dl\extractor\common.py", line 427, in extract
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpvin3ute2\build\youtube_dl\extractor\generic.py", line 2628, in _real_extract
youtube_dl.utils.UnsupportedError: Unsupported URL: http://ew.com/tv/2017/03/08/guardians-galaxy-cartoon-exclusive-clip/

Stop mentioning IDM here. It uses browser to resolve links to the media.

Sorry. I was just saying it since you never fix it.

Nearly*

This is fixed in PR #12005 .

But how did he get it to work with that link? When I try to take the video from http://ew.com/tv/2017/03/08/guardians-galaxy-cartoon-exclusive-clip/
I can get this link: c.brightcove.com/services/mobile/streaming/index/rendition.m3u8?assetId=5352122725001&pubId=219646971&videoId=5352121610001
I can't get it to work with the link yan put up :(

@RuneMagle, I'm afraid your pronouns are confusing me.

But how did he get it to work with that link?

Can't get which "it" to work? And which "he"?

I can't get it to work with the link yan put up :(

Which link?
In any case, #12178 hasn't yet been merged, so this won't work in the mainline. I'm sorry if I was not clear about that. But here's that in action:
pb3:youtube-dl jhawk$ git checkout brightcove-12005
Switched to branch 'brightcove-12005'
Your branch is up-to-date with 'origin/brightcove-12005'.
pb3:youtube-dl jhawk$ python -m youtube_dl -vs 'http://ew.com/tv/2017/03/08/guardians-galaxy-cartoon-exclusive-clip/'
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: [u'-vs', u'http://ew.com/tv/2017/03/08/guardians-galaxy-cartoon-exclusive-clip/']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2017.03.07
[debug] Git HEAD: 34da9a4df
[debug] Python version 2.7.10 - Darwin-14.5.0-x86_64-i386-64bit
[debug] exe versions: ffmpeg git-2017-02-28-7f62368, ffprobe git-2017-02-28-7f62368, rtmpdump 2.4
[debug] Proxy map: {}
[generic] guardians-galaxy-cartoon-exclusive-clip: Requesting header
WARNING: Falling back on generic information extractor.
[generic] guardians-galaxy-cartoon-exclusive-clip: Downloading webpage
[generic] guardians-galaxy-cartoon-exclusive-clip: Extracting information
[generic] Brightcove (new) video detected.
[download] Downloading playlist: Superheroes Clash in Exclusive 'Guardians of the Galaxy' Cartoon Clip
[generic] playlist Superheroes Clash in Exclusive 'Guardians of the Galaxy' Cartoon Clip: Collected 1 video ids (downloading 1 of them)
[download] Downloading video 1 of 1
[brightcove:new]<PHONE_NUMBER>001: Downloading webpage
[brightcove:new]<PHONE_NUMBER>001: Downloading JSON metadata
[brightcove:new]<PHONE_NUMBER>001: Downloading m3u8 information
[brightcove:new]<PHONE_NUMBER>001: Downloading m3u8 information
[download] Finished downloading playlist: Superheroes Clash in Exclusive 'Guardians of the Galaxy' Cartoon Clip
pb3:youtube-dl jhawk$

Well, I though the link yan put up, was one where he just put the video id in that link, but I guess not. How do you get the video? I'm kinda noob at this point...

Well, I though the link yan put up,

I still don't know what link you are referring to, @RuneMagle. Perhaps I missed it, but it would be a lot easier to understand you if you just included the link you were talking about.

How do you get the video?

Well, you can wait for PR #12178 to be merged.
Or you could got to my branch at https://github.com/johnhawkinson/youtube-dl/tree/brightcove-12005 and download it: https://github.com/johnhawkinson/youtube-dl/archive/brightcove-12005.zip

Don't matter what I thought. Clearly it makes no sense. I tried downloading your thing from the link, but I have no idea how to make it work... :(

Can you send the video you got instead, with subs please? I just really want that video. :)

I am having similar problem, try this URL: https://www.matrix-2001.cz/gaia-video/zprava-pro-lidstvo-192#
[debug] System config: [] [debug] User config: [] [debug] Custom config: [] [debug] Command-line args: [u'-v', u'--cookies=cookies.txt', u'https://www.matrix-2001.cz/gaia-video/zprava-pro-lidstvo-192'] [debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8 [debug] youtube-dl version 2018.05.09 [debug] Python version 2.7.14 (CPython) - Linux-4.13.0-39-generic-x86_64-with-Ubuntu-17.10-artful [debug] exe versions: avconv 3.3.4-2, avprobe 3.3.4-2, ffmpeg 3.3.4-2, ffprobe 3.3.4-2, phantomjs 2.1.1, rtmpdump 2.4 [debug] Proxy map: {} [generic] zprava-pro-lidstvo-192: Requesting header WARNING: Falling back on generic information extractor. [generic] zprava-pro-lidstvo-192: Downloading webpage [generic] zprava-pro-lidstvo-192: Extracting information ERROR: Unsupported URL: https://www.matrix-2001.cz/gaia-video/zprava-pro-lidstvo-192 Traceback (most recent call last):   File "/home/xxx/repos/youtube-dl/youtube-dl/youtube_dl/extractor/generic.py", line 2261, in _real_extract     doc = compat_etree_fromstring(webpage.encode('utf-8'))   File "/home/xxx/repos/youtube-dl/youtube-dl/youtube_dl/compat.py", line 2542, in compat_etree_fromstring     doc = _XML(text, parser=etree.XMLParser(target=_TreeBuilder(element_factory=_element_factory)))   File "/home/xxx/repos/youtube-dl/youtube-dl/youtube_dl/compat.py", line 2531, in _XML     parser.feed(text)   File "/usr/lib/python2.7/xml/etree/ElementTree.py", line 1659, in feed     self._raiseerror(v)   File "/usr/lib/python2.7/xml/etree/ElementTree.py", line 1523, in _raiseerror     raise err ParseError: not well-formed (invalid token): line 42, column 22 Traceback (most recent call last):   File "/home/xxx/repos/youtube-dl/youtube-dl/youtube_dl/YoutubeDL.py", line 792, in extract_info     ie_result = ie.extract(url)   File "/home/xxx/repos/youtube-dl/youtube-dl/youtube_dl/extractor/common.py", line 503, in extract     ie_result = self._real_extract(url)   File "/home/xxx/repos/youtube-dl/youtube-dl/youtube_dl/extractor/generic.py", line 3201, in _real_extract     raise UnsupportedError(url) UnsupportedError: Unsupported URL: https://www.matrix-2001.cz/gaia-video/zprava-pro-lidstvo-192


Add Datasets and datastores API swagger

MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Contribution checklist:

[x] I commit to follow the Breaking Change Policy of “no breaking changes
[x] I have reviewed the documentation for the workflow.
[x] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

[x] Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

Adding new API(s)
Adding a new API version
Adding a new service

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

[ ] Removing API(s) in stable version
[ ] Removing properties in stable version
[ ] Removing API version(s) in stable version
[ ] Updating API in stable version with Breaking Change Validation errors
[ ] Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

@ArcturusZhang please review.

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

Hi @ArcturusZhang, made the suggested changes

Hi @achalachal2003 thanks! Now look good to me. But this PR adds new APIs, please wait for ARM's feedback

@pilor  for Arm review

@pilor for Arm review

Reviewers are on a weekly rotation.  https://armwiki.azurewebsites.net/rp_onboarding/process/api_review.html#api-review-on-call  @chiragg4u is the reviewer this week.

@pilor for Arm review

Reviewers are on a weekly rotation. https://armwiki.azurewebsites.net/rp_onboarding/process/api_review.html#api-review-on-call @chiragg4u is the reviewer this week.

Thank you Chris, @chiragg4u for Arm review

Approving, please fix in the newer api-version.

Hi @ArcturusZhang, please review/merge if looks good


Add preface and appendixes

Items added to TOC look like

Could reset the margin on those items in the TOC to be zero as well if desired.
Subscribers look like on small screens

The font is increased on larger screens

The appendix contains the images from CCEL of the greek. I suppose those could be made into actual greek characters via unicode.

Oops, I need to fix my notification settings, I just saw this now. Thanks so much, it looks great!


Make remsh work with quoted cookie

Overview

Allow space and other special characters in cookies.
Testing recommendations

First set the cookie in vm.args, then run the script below:
e.g.: -setcookie 'a b\n\t\xd#{}()[]$&^!-=+?|//c\\d\\\e\\\\f'
or -setcookie "a b\n\t\xd#{}()[]$&^!-=+?|//c\\d\\\e\\\\f"
make release
cd rel/couchdb
./bin/couchdb
./bin/remsh

Related Issues or Pull Requests
fix https://github.com/apache/couchdb/issues/4405

Checklist

[ ] Code is written and works correctly
[ ] Changes are covered by tests
[ ] Any new configurable parameters are documented in rel/overlay/etc/default.ini
[ ] Documentation changes were made in the src/docs folder
[ ] Documentation changes were backported (separated PR) to affected branches

That -E/-r looks great. It makes the expression easier to read and understand.
Is there a difference between -E and -r I checked man sed on macos and freebsd and both seem to have both options and say:
-r	     Same as -E	for compatibility with GNU sed.

It looks like our oldest Linux CentOS 7 doesn't support sed -E would we be able to use -r only?
[root@2dfb04f0d80c /]# sed --help
Usage: sed [OPTION]... {script-only-if-no-other-script} [input-file]...

  -n, --quiet, --silent
                 suppress automatic printing of pattern space
  -e script, --expression=script
                 add the script to the commands to be executed
  -f script-file, --file=script-file
                 add the contents of script-file to the commands to be executed
  --follow-symlinks
                 follow symlinks when processing in place
  -i[SUFFIX], --in-place[=SUFFIX]
                 edit files in place (makes backup if SUFFIX supplied)
  -c, --copy
                 use copy instead of rename when shuffling files in -i mode
  -b, --binary
                 does nothing; for compatibility with WIN32/CYGWIN/MSDOS/EMX (
                 open files in binary mode (CR+LFs are not treated specially))
  -l N, --line-length=N
                 specify the desired line-wrap length for the `l' command
  --posix
                 disable all GNU extensions.
  -r, --regexp-extended
                 use extended regular expressions in the script.
  -s, --separate
                 consider files as separate rather than as a single continuous
                 long stream.
  -u, --unbuffered
                 load minimal amounts of data from the input files and flush
                 the output buffers more often
  -z, --null-data
                 separate lines by NUL characters
  --help
                 display this help and exit
  --version
                 output version information and exit
...

Changed them to sed -r, thanks for double-checking with different systems, Nick.


HARVESTER: Allow dismiss VM insufficient resource quota

Summary
PR Checklist
~- Is this a multi-tenancy feature/bug?
- [ ] Yes, the relevant RBAC changes are at:~
~- Do we need to backport changes to the old Rancher UI, such as RKE1?
- [ ] Yes, the relevant PR is at:~

Are backend engineers aware of UI changes?

[ ] Yes, the backend owner is: @chrisho

Allow dismiss VM insufficient resource quota

Occurred changes and/or fixed issues

Technical notes summary

Areas or cases that should be tested

Areas which could experience regressions

Screenshot/Video

@mergify backport release-harvester-v1.2


Faster solution instead of array_unique()

Ticket is related to this solution
// this can be also solved with
// return count(array_unique($A));

This is result with array_unique()
https://codility.com/demo/results/demoATDHG8-X7Z/
Only 66% for Performance
But according to this article this task can be solved with native php functions keeping good Performance score
return count(array_flip(array_flip(array_reverse($A,true))));

;)

I've tested array_unique approach.
I am getting 100/100, and obviously you got 100/66, only different thing is input, which is larger in your case, so the time is slower. With growing array $A your native function use is increasingly better solution.
Problematic test is large_random1 chaotic sequence of values from [-1M..1M], length=100K:

SOLUTION
Time
Link

count(array_unique($A)) - YOU
0.944 s
https://codility.com/demo/results/demoATDHG8-X7Z/

count(array_unique($A)) - ME
0.516 s
https://codility.com/demo/results/demoGCBB35-KFJ/

count(count(array_flip(array_flip(array_reverse($A,true))))
0.204 s
https://codility.com/demo/results/demo8C3NFT-2D5/

MY CUSTOM CODE
0.320 s
https://codility.com/demo/results/demo8CTQH9-EF6/

Please, can you push your solution, just change:
// this can be also solved with
// return count(array_unique($A));

in
// this can be also solved with
// return count(array_flip(array_flip(array_reverse($A, true))));