Vite tries to aggressively prebundle even things that won't get used in the browser, and confuses itself

Describe the bug
Any import()s in an isomorphic part of the app are aggressively prebundled by Vite, even if they're never ultimately used in the browser (and even if they are inside an if (!browser) { }). This is a problem because when something cannot successfully be prebundled (e.g., if it uses Node APIs with no browser analogue), something within Vite crashes(?) or gets into a bad state, and - even if the offending import() is removed - Vite then does not perform other prebundling that actually is necessary until the server is restarted. This can lead to, for example, imports of CJS modules being left as import ... from '/node_modules/foo/...', which means the browser is being served CJS files when it is expecting ESM files.
Logs
The logs from Vite when it's failing to prebundle the package look like, e.g.:
 > node_modules/@sentry/node/esm/parsers.js:2:9: error: No matching export in "browser-external:fs" for import "readFile"
    2 │ import { readFile } from 'fs';
      ╵          ~~~~~~~~

 > node_modules/@sentry/node/esm/integrations/utils/http.js:3:9: error: No matching export in "browser-external:url" for import "URL"
    3 │ import { URL } from 'url';
      ╵          ~~~

 > node_modules/@sentry/node/esm/integrations/modules.js:2:9: error: No matching export in "browser-external:fs" for import "existsSync"
    2 │ import { existsSync, readFileSync } from 'fs';
      ╵          ~~~~~~~~~~

 > node_modules/@sentry/node/esm/integrations/modules.js:2:21: error: No matching export in "browser-external:fs" for import "readFileSync"
    2 │ import { existsSync, readFileSync } from 'fs';
      ╵                      ~~~~~~~~~~~~

 > node_modules/@sentry/node/esm/integrations/modules.js:3:9: error: No matching export in "browser-external:path" for import "dirname"
    3 │ import { dirname, join } from 'path';
      ╵          ~~~~~~~

 > node_modules/@sentry/node/esm/integrations/modules.js:3:18: error: No matching export in "browser-external:path" for import "join"
    3 │ import { dirname, join } from 'path';
      ╵                   ~~~~

The logs from the browser when it's attempting to load the CJS version of a module as a ESM when Vite gives up and serves that instead look like:
Uncaught (in promise) ReferenceError: exports is not defined
    <anonymous> http://localhost:3000/node_modules/decoders/index.js:3

To Reproduce
My reproduction uses two of the libraries I was seeing this with in a real project. @sentry/node is the library that can't (and shouldn't) be bundled for the browser. decoders is the library that's available only in CJS and that needs to be prebundled for the browser to understand it.
Clone https://github.com/Conduitry-Repros/kit-1570 and run npm install.
Start up the server with npm run dev and check the browser console, where you should see the results of console.log(await import('decoders'));.
Then, open src/routes/index.svelte and uncomment the indicated line. Refresh the browser if necessary. In the Vite console, you should now see errors about not being able to process @sentry/node. In the browser console, you should see errors that result from attempting to load CJS as ESM. If you look in the network tab, you'll see that http://localhost:3000/node_modules/decoders/index.js is being requested (the raw CJS version from the package) rather than the http://localhost:3000/node_modules/.vite/decoders.js you should be getting.
This broken state persists even if you re-comment the import('@sentry/node'). You don't get the prebundled version of decoders again until you restart the server.
Expected behavior
A clear and concise description of what you expected to happen.
Stacktraces
n/a
Information about your SvelteKit Installation:

Diagnostics

The envinfo command hangs for me, I'm guessing because of WSL. This is a separate issue to be looked into, probably.
Firefox 88.0.1, but this shouldn't be relevant
No adapter, for now. This is in dev mode.

Severity
Fairly severe, as it was causing some very confusing behavior. I do have a workaround for now though, which is to use a helper function that I call instead of import():
export default async function serverImport(id) {
    const { createRequire } = await import('module');
    const require = createRequire('/absolute/path/package.json');
    return require(id);
}

This relies on a known absolute path to resolve relative to, which is fine in my case as I'm using Docker. Note that I cannot use import.meta.url as that is a path that looks absolute but is in fact relative to the root of my project. It's /src/whatever/..., not a real path in my whole filesystem.
Additional context
I don't really know enough to be able to tell whether this is a Vite bug or us calling Vite in the wrong way. It failing to prebundle certain dependencies makes sense. Some dependencies just won't work that way. However, it aggressively attempting to prebundle things before they're even requested by the browser seems questionable. And it then getting into a state where it won't prebundle anything else is definitely a problem.

It seems like that's probably a Vite bug. Probably more useful to file a bug there in terms of someone seeing it who might know enough about Vite to fix it.
A good first step would be to see if you can reproduce it in a Vite project without SvelteKit. You can create a new Vite project with npm init @vitejs/app my-svelte-app --template svelte, but that's a client-side only project. If you want an isomorphic project, the best way I know how is probably to start with this one: https://github.com/sveltejs/vite-plugin-svelte/tree/main/packages/playground/vite-ssr

I might be the minority, why not bundle Rollup with svelte again instead of going to someone whom is third party to fix our bugs and issues?
Plus as I understand Rich, whom made svelte also made rollup can tweak it to the communities needs.

I might be the minority, why not bundle Rollup with svelte again instead of going to someone whom is third party to fix our bugs and issues?
Plus as I understand Rich, whom made svelte also made rollup can tweak it to the communities needs.

Same issue while using windicss

Vite uses Rollup, so there are similarities. Using Rollup only is not an option because you'd lose the unbundled dev experience and you certainly don't want to go back to the long reload times while developing.

I've been looking at this again this morning. There's actually a way simpler workaround that I found shortly after opening this issue, which is:
export default function serverImport(id) {
    return import(id);
}

I.e., you can just hide the import from Vite by calling it in another function.
I've also been able to reproduce this from the Svelte vite-ssr template Ben linked above, so I don't think it's something SvelteKit-specific, anyway. It's still possible it's vite-plugin-svelte-specific.
By adding
            optimizeDeps: {
                exclude: ["@sentry/node"],
            },

to my configuration, I'm able to avoid Vite trying to prebundle the dependency for the browser, which means that running the app in development now works even without the workaround of hiding import from Vite. However, in the production build, Vite is trying to look into the @sentry/node dependency for some reason, and is getting tripped up by something.
[commonjs] Unexpected token (228:35) in<EMAIL_ADDRESS>file: /.../node_modules/@sentry/node/esm/handlers.js:228:35
226:     }
227:     if (options.serverName && !event.server_name) {
228:         event.server_name = global.process.env.SENTRY_NAME || os.hostname();
                                        ^
229:     }
230:     if (options.user) {
> Unexpected token (228:35) in<EMAIL_ADDRESS>
I'm guessing this is because of the Vite replacing process.env with ({}) across the board as mentioned in https://github.com/vitejs/vite/issues/3176 although I haven't actually looked into this at all. It remains a mystery why Vite is having Rollup try to bundle this file.

I've opened an issue on Vite's side - https://github.com/vitejs/vite/issues/3715

Would it make sense that this is also happening in reverse. ie. my node build is failing from a client only dep. Node is having an issue with a dynamic import of a video player I'm using.

Would it make sense that this is also happening in reverse. ie. my node build is failing from a client only dep. Node is having an issue with a dynamic import of a video player I'm using.

I'm not sure if it's related since prebundling isn't used in the server build, but I'm guessing it has something to do with third-party side effects handling (similar https://github.com/vitejs/vite/issues/6193#issuecomment-1003417635).

I think the correct solution to this issue is optimizeDeps.exclude as there's no way for Vite to tell a package is node-only. The errors could be better though, which should be covered by https://github.com/vitejs/vite/issues/3715. So I'm closing in favour of that.

:+1: optimizeDeps.exclude worked for me. I'm no longer seeing the issue I mentioned above. I'm guessing that this is because of the fix for the process.env. -> ({}). stuff in SSR that's happened in Vite in the meantime.
I'm fine with this being closed on our end - we can use the Vite issue for tracking more graceful handling of these errors.

@Conduitry Thanks! I feel like the dog in the "I have no idea what I'm doing" meme, but this worked for me.
  optimizeDeps: {
    exclude: ['path', 'fs', 'os', 'perf_hooks', 'util'],
  },

optimizeDeps

According to Vite docs, optimizeDeps.exclude is meant for: Dependencies to exclude from pre-bundling.
That means Vite will not try to include the dependencies you listed (path, fs, etc.) into the final index.js bundle (the file which is gonna be shipped to production.

Sorry, I know this is not related to Svelte, but it's the #1 search result for this Vite issue, so I want to leave this here for Nuxt 3 users:
I ran into this problem, and what worked for me was @Conduitry's trick above (faking Vite out by writing a custom function for importing from server-side code).
export function serverImport(pkg: string) {
  return import(/* @vite-ignore */ pkg);
}


Add clusterNetwork/defaultNetwork into multus.conf

To support CRD/file/directory, add clusterNetwork/defaultNetwork in multus.conf file.
Verified that kubernetes: v1.12.1.
Fix #157, #153, #131

@dcbw @squeed could you please take a look into it?


Kernel Selection (Remote Work)

Enumerate remote kernels - 1/2 day
Keep track of previous servers - 1/2 day

I believe enumerating remote kernels is already possible given the current code. I'm just doing the other part.

Validated


how to use this project

I develop tango AR app using Unity, I want to record the AR video, but I can't find a API to record video in the tango Android device, so I have to use Android API. in the Unity project, I import tango's unity SDK package, so, at Plugins/Android directory, there are a AndroidManifest.xml file and google_unity_wrapper.aar, If I want to use Android API, how to integrate my code into google_unity_wrapper.aar? or, how to use AndoridIntergration directory?

Hi feixiaku! There's no built in support for recording video in the SDK. There are multiple video recording plugins on the Asset Store, we've found all the ones we've investigated to work well.

could you give me a link or the name that you have used plugins' name, so i can use the same one, That's great, thank you

I've seen apps do well with Everyplay (https://www.assetstore.unity3d.com/en/#!/content/16005), and I would expect other video recording plugins to work well too.


Move black configuration to pyproject.toml

Type

[ ] Bugfix
[x] Enhancement
[ ] New feature
[ ] Documentation

Description of the changes
Read the commit list for more information on what has been done in this PR.
If you don't want some from the checks that are done here, let me know and I'll remove them.
If you're not okay with doing the reformatting in the same PR that pre-commit configuration is added in, I can also split this PR in two (or in however many pieces you want).
Using pre-commit is as simple as running this in your (preferably global) environment:
pip install -U pre-commit
And then running pre-commit install in the root of your repository.
From now on, pre-commit will automatically run when you make a commit and will let you know if there are issues with any of the checks it runs.

I totally used wrong title 😬


Thank you for your paper!I want to know where to download pre-training weights

https://cloud.tsinghua.edu.cn/d/c15b25a6745946618462/


Port to mobile devices

Do you plan to port this program to the Android/IOS systems?

I've thought about it a few times, especially given Qt seems to support porting to mobile devices without too big difficulties.
So I think I might do it in the future, but not very soon.
Aren't there already a bunch of apps doing the same thing anyway? (browsing part)

Browsing maybe, but not Group Downloading ^^

I agree, it is convenient to use a computer, but when there is no access to a PC, I would like to do it from mobile devices.
No, no, applications with many packages are non-existent. There is only a single app tied to your website.

Plus, you say there's apps for browsing, do you have any examples? Especially apps that support multiple sources like Grabber.

I've been using Animeboxes for a very long time, it also supports batch downloading but it's not nearly as good as Grabber, I've been using it just for browsing boorus.

given Qt seems to support porting to mobile devices without too big difficulties

FYI, I just built Grabber for Android, and after a few bugs here's the result. The UI is horrible but works:

Porting it properly would require having separate designs for desktop and mobile, using QtWidgets and QML respectively. That would require properly extracting all the logic out of "view" files, as well as re-designing and implementing all parts of the UI, which is a lot of work.

@Bionus Hi, how are you doing with the mobile version? (I need it xDD)

Closing in favor of issue #2147


[5.7.14] Breaking change on eager loading when key is a string

Laravel Version: 5.7.14

Description:
I just upgraded to 5.7.14 (the version released today) and there is a breaking change affecting eager loading. At least in cases where the key is a string containing a period, it converts it to an integer instead of keeping it a string like it did before.
Before, in 5.7.13 and earlier:
... WHERE foo IN ('123.456')

Now, in 5.7.14:
... WHERE foo IN (123)

I narrowed it down to the change in this method: https://github.com/laravel/framework/commit/a4405e91af27429f9e879d8754769cb68eb208d6#diff-c8675355c360b9bd4ef485c30ff5e025R82 Changing that method back to how it was fixes it.
cc @staudenmeir

Did you set protected $keyType = 'string'; in the model?

Ok, that fixed it. Thanks
@driesvints Just a heads up it's still a breaking change--that property hasn't been required in the past. Might be worth a mention in the changelog.

It's mentioned in the documentation:

If your primary key is not an integer, you should set the protected $keyType property on your model to string.

I understand. But it hasn't been required in order for it to work until that commit.

Okay but it was documented. Even if it somehow managed to work before it wasn't meant to work without the $keyType property being set.

Missed out $keyType as well since we use UUID. But we did set $incrementing to false. Thanks for this!

@staudenmeir @driesvints For newcomers, yes it is documented. But for those who use Laravel for years there is no mention in the upgrade guide that you to declare a keyType.
And as most people don't read the whole documentation again after an upgrade, they just don't know about it. For them, 5.7.14 introduces a breaking change.

@rimace this has been in the docs for over a year at least.

This will be changed in the next release: #26622

@driesvints Beside the fact that it was added to the doc about a year after the variable was introduced. What are you suggesting? Not documenting breaking changes in the upgrade guide and instead people should read the whole documentation two times a year?
It was not a breaking change in 5.7.0 or earlier, so nobody documented that in the upgrade guide, and I understand that. But this variable became mandatory in 5.7.14 and I suggest that it should be documented somewhere that it is now mandatory. But I guess it will be over with 5.7.15, lol

Laravel 5.7.15 has been released.


Assertion failed when creating cursor FBO on multi-GPU setup

With latest sources, sway fails to start. Log attached.
sway.log

I don't know nearly enough about wlroots to understand this bug, but in the meantime adding this hack inside of gles2_get_renderer_in_context at least prevents the crash. I'm sure the actual fix is elsewhere though as gles2_get_renderer_in_context is supposed to assume the context is already current, right?
if(!wlr_egl_is_current(renderer->egl)) {
    wlr_egl_make_current(renderer->egl, EGL_NO_SURFACE, NULL);
}

function calls leading up to the crash:
wlr_output_cursor_set_surface -> drm_connector_set_cursor -> drm_fb_lock_surface -> drm_surface_unset_current -> wlr_renderer_bind_buffer -> gles2_bind_buffer -> gles2_get_renderer_in_context

FWIW I see the assert only when external monitors are connected.

I can create a pull request if this is a satisfactory solution. Even with this change, I still get freezes from time to time when hotplugging external monitors. Not sure if that is related to this or some other change. (I haven't kept up with more recent changes to wlroots/sawy as I've not been using sway on a daily basis because of this issue.)

drm_surface_unset_current must only be called after making the surface current. Apparently that's not the case here.

Can you try https://github.com/swaywm/wlroots/pull/2520?


Flaky Test:  KyuubiOperationKubernetesClusterClusterModeSuite

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Search before asking

[X] I have searched in the issues and found no similar issues.

Describe the flaky test
KyuubiOperationKubernetesClusterClusterModeSuite:

Spark Cluster Mode On Kubernetes Kyuubi KubernetesApplicationOperation Suite *** FAILED ***
failKillResponse._1 was true (SparkOnKubernetesTestsSuite.scala:213)

Actions URL
https://github.com/apache/incubator-kyuubi/runs/7625303510?check_suite_focus=true
Parent issue
#1733
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

cc @zwangsheng

As if it were an occasional problem, after killApplication, there is a Pod that lets L killApplication work.


feat: Auto Layout editor for everyone

This PR removes feature flag for Auto Layout so that the new Auto Layout editor is available for all the users.

/build-deploy-preview

/build-deploy-preview

/ok-to-test


haskellPackages.lsp_2_1_0_0: fix build

Description of changes
Now this is successful:
nix build .#haskellPackages.lsp_2_1_0_0

Closes: https://github.com/NixOS/nixpkgs/issues/250091
Things done
Addition to configuration-nix.nix for this package.
Ran
./maintainers/scripts/haskell/regenerate-hackage-packages.sh

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Yeah, haskell-updates currently contains an already fixed update for haskell-language-server which normally also touches lsp. In general fixing packages with _ve_rsi_on does not seem very useful without a specific reason.

No specific need, didn't realize there was a fix already on haskell-updates, thanks @maralorn


Glacier .NET SDK demonstrates way slower upload speed than python. Fix?

Once of our clients has dedicated 5Gbps link to Amazon.
Their python test code (taken from github sample basically) beats my .NET code x3 (700 Mbps vs 2000Mbps). I spent some time trying to fine tune it, even wrote my own treehash generator to make sure not to use slow .NET managed SHA version. And yet..
Then an Amazon rep mentioned in "not so official" conversation that AWS Glacier .NET SDK actually cant match other SDKs in upload speeds and that the Python is the fastest.
Can you acknowledge this? Are you going to "fix" this? I mean 300% difference in throughput - is a shame, wouldn't you agree? [before you ask - no, the client (and few others too) don't want to use S3 with transitioning to Glacier, they want direct access to Glacier]

Should you ask this on .Net SDK? https://github.com/aws/aws-sdk-net

Sorry my bad


More prominent place for the version number of the CKEditor

You have to dig deep to find which version number of the CKeditor is used. Could this info get a prominent place in the documentation? And I am wondering if the option to strip the Word copy paste function automaticly is turned on. From the documentation I read that this is turned on by default from a certain version. Before that you had to use the special button to copy paste from Word. But since users did not use this they turned the option to strip the copy paste from Word by default.
And is my understanding correct that the with the URL in the documentation to create a new specific version of the CKeditor that you get a new version that you just have to drop into the widget to get the widget with the latest version?
Regards,
Ronald

Hi Ronald,

You have to dig deep to find which version number of the CKeditor is used. Could this info get a prominent place in the documentation?

We recently updated the CKEditor to the latest version. I think it is a good idea to include the version number in the documentation.

I am wondering if the option to strip the Word copy paste function automaticly is turned on.

We will check if that is the case. I think it should be automatically on, right?

And is my understanding correct that the with the URL in the documentation to create a new specific version of the CKeditor that you get a new version that you just have to drop into the widget to get the widget with the latest version?

Could you elaborate on that? I don't know which URL you are referring to. We use this repository as the base for the widget on the App Store. So technically yes, if we create a new version of the widget it is placed here first (Releases), then we push a new update to the App Store

In the build-config.js there is a URL: http://ckeditor.com/builder/download/e28e1c17acaeb42364c092d2fe181fc5
It will then use the latest CKeditor with the same options as you used last time to create the version.
So I wondered if I replace the files in the widget with the files I get from that URL I have the widget with the latest CKEditor in them. Or do you need to configure something more to rebuild the widget?
And yes please the auto strip from Word should be turned on.
Thank you very much.
Regards,
Ronald

Ah, like that! Yes, that is true. We include the build-config.js to download all the plugins on the CKEditor website. There is just one exception (this is now done manually), we have created one plugin ourselves mendixlink which is the Microflow button.

Ok, thanks. Then I know what I have to do if I want a new version in a hurry :).
Thank you. And yes the table plugin would be nice to. I needed that last week. I got it to work but this was not something I would as of our clients (most of the time they create their own templates).


Consider increasing frequency that auxiliary data is generated

Today, it is every 24 hours.
With auxiliary data reload time of 1 hour and index reload of 10 minutes, worst case scenario is a customer waiting 25 hours and 10 minutes to see their own appear on a package (either new package ID or ownership changes).
We should consider increasing the frequency that this data is generated.

/cc @mishra14

Related: https://github.com/NuGet/NuGetGallery/issues/3364
This issue tracks increasing the frequency. https://github.com/NuGet/NuGetGallery/issues/3364 tracks handling the case where new IDs should have their own defaulted to the original owner.

Agree, I don't think making user wait for 24+ hours just to see the owner change is fair. Further we don't let the user know that they should expect 24+ hours of delay, it's easy for them to get confused if their change made it through.

@joelverhagen , still relevant?

Not relevant. Ownership changes are immediate - 30 minutes depending on job time and come critieria


refactor(config): use POJO rather than ES6 map

I think I actually prefer this syntax anyway.

:+1:


Fix issue 78

Issue #78
Summary of changes:

updated introductory comments to reflect new data set format

Modified data import code to new data set format

Updated placeholder and input layer tensor shape specification for new data set format

Hi again,
Am I correct that you have not change the corresponding ipynb file ?

Thanks!


[Portal] Fix a small error in commands.py and update test sample file

This checklist is used to make sure that common guidelines for a pull request are followed.

For new extensions:

[ ] My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:
docker run -it microsoft/azure-cli:latest
export EXT=<NAME>
pip install --upgrade --target ~/.azure/cliextensions/$EXT "git+https://github.com/YalinLi0312/azure-cli-extensions.git@master#subdirectory=src/$EXT&egg=$EXT"

Portal

This pr addressed comments in portal breadth coverage after it has been merged.


update match for textmate grammar for underscore prefixed elements

close #6311
Do not consider function or macro prefixed by _ as an unused function/macro

r? @dustypomerleau

Ah, never mind, I just noticed #6320.

Subsumed by #6320.


[PIO-182] Add async methods to LEventStore

This pull request contains following updates:

Add async (non-blocking) methods to LEventStore and LJavaEventStore
Add Scaladoc about scala.concurrent.ExecutionContext.Implicits.global which is used in blocking methods

See also<EMAIL_ADDRESS>

@dszeto @shimamoto Could you take a look?
Chris who raised this issue wants to do adding the asynchrnous processing capability to other storages and engine server following this pull request.

Any chance that this gets merged in develop soon? Would need to base my async work on that

@longliveenduro How do you feel about Scaladoc of LEventStore.scala in this pull request? Is explanation is enough and clear? I'm waiting for someone's review for that.

@takezoe The scaladoc is clear I think.
But after some days of letting this settle and also reading this excellent blog: https://www.beyondthelines.net/computing/scala-future-and-execution-context/
I am not sure if it is really a good idea to use the "standard" Scala Execution Context for the "old blocking" code. Another idea would we (like proposed in the Blog) use a separate Thread pool, make the defaults the same as now (or maybe raise the allowed thread count to bypass/hack the problem from now on a bit for usages of the old code) and make the size of the thread pool configurable like the standard scala thread pool.
For example this blog suggests that a FixedThreadPool for blocking purposes might be a good idea:
https://www.cakesolutions.net/teamblogs/demystifying-the-blocking-construct-in-scala-futures

@longliveenduro Even if we use thread for asynchronous processing, we should use separated thread pools for CPU bound processing and I/O bound processing. The thread pool for CPU bound processing should have threads close to the number of CPU. One for I/O bound processing should have threads which are significantly larger than the number of CPUs.
Anyway, I think that allowing to give an execution context from user side is good strategy because it makes possible to control by users.

@takezoe yes exactly, seperate Threadpools for CPU and I/O bound blocking processing looks like a very good idea for a transition phase. Also looking at the Blogs they suggest a fixed Threadpool instead of a ForkJoin Threadpool (which the "standard" Scala thread pool is) for blocking I/O code.
Anyhow, looking at your PR, you are importing the standard Scala execution context in the methods that still use blocking via Await.result. What about using a separate Threadpool there whose size is either configurable or you pass it as a parameter. Passing as a parameter though is breaking the current contract and is a little bit strange since the method does not return an async instance (e.g. Future) which I would expect from a scala method which needs an ExecutionContext param.
Very interested what you think!

How about we push for deprecating blocking methods? We can update docs to instruct developers to start using non-blocking methods instead.

I'm not sure if deprecating current blocking methods in the next version is good. I would like to see following work by @longliveenduro before making a decision.

Anyway, I'm going to merge. Thanks for all reviews!


Clarify sources of voluntary disruptions

See issue #22391

Okay, I've signed the CLA and am using the correct e-mail address on the commit now...I did just sign it 30 minutes ago... is there a way to re-trigger the CLA check?

Okay, I've signed the CLA and am using the correct e-mail address on the commit now...I did just sign it 30 minutes ago... is there a way to re-trigger the CLA check?

/check-cla

/check-cla

Trying again, after connecting my Github account:
/check-cla

Well I've submitted a support request, because I've followed all the instructions there and can't figure out what the problem is.  If someone wants to just take this minor change and submit it themselves, please feel free! :sweat_smile:

@mltsy , It is not clear what is happening with the CLA.
You could open a new PR (with these changes)?
/close

/reopen

Here you go

Page preview:
https://deploy-preview-26840--kubernetes-io-master-staging.netlify.app/docs/concepts/workloads/pods/disruptions/

/kind cleanup

/lgtm

Ah!  Well that was interesting :smile:   Thanks!


add command to see group details

Add an command that runns Data=$(signal-cli listGroups -d $replyAdress), reacts with an ✅ and runns signal-cli send $replyAdress -m$Data --quote-autor $messageAuthor --quote-timestamp $messageTimestamp.

[ ] add "groupInfo" command
[ ] update wiki

More information: #9

this feature is obsolete if #36 gets added


Clarify Ruby instructions in README.md and docs

Now, we don't need to install Jekyll separately so that part is obsolete. Instead we should mention bundle etc.

Fixed by #17505, IIUC.


Ctrl-a does not work, Ctrl-Shift-a does

Pressing Ctrl and the A key does not produce the byte 0x01, but pressing Ctrl, Shift and the A key does. I am not exactly sure what Ctrl-A produces by itself, because in shell it doesn't seem to do anything but in Irssi it switches windows. I am using Finnish-language Mac OS 9.2 with Finnish keyboard map on a PowerPC G3 system, running both version 0.8.9 and the one-off version created to a keyboard layout issue I had.

thanks for the report, I'll take a look at it.  I would like to add a little debug mode for testing keycodes, since there's definitely some weird behavior in there.


[feature] Archival node

Feature request
We need a simpler node that can take the load off of the main network nodes for handling queries.
It should:

Remain at the last finalised block (soft fork prevention)
Support full Query API (including GraphQL when that's done).
Periodically reverify that its nodes have correct hashes (to prevent data rot and hard forks)
Feature query caching (so responses to similar queries get updated regularly, but the same request from different sources is computed efficiently).
Use the Iroha data model as much as possible.

Motivation
Iroha can be overloaded with queries. To decouple one kind of processing from another we need a way to offload the work.
Also useful to reduce the round-trip time for private blockchains.
Who can help?
@appetrosyan

To avoid confusion, when "staying two blocks behind" in this context means retaining the last finalised block, which depending on how one counts is either one or two blocks behind.

Further this restriction should be refined: in some cases, some blocks can be considered final even though an earlier version of the wsv is retained. This depends on the frequency of peer discovery, the depth of autorecoverable soft-forks and many other parameters which are up for revision.


canned queries for query tool

Kim and I discussed briefly last week, and I just found this list on the wiki, we can refine and add to it. It should include any list in the FAQ

[ ] ANY 'disease' gene
[ ]  All sequence specific transcription factors
[ ]  All deletion allele viable/inviable
[ ] All protein coding genes (ex dubious and transposon)

ANY 'disease' gene

Is that any gene with an annotation to a term from the disease_associated CV?

All sequence specific transcription factors

Could you explain that one?

All protein coding genes (ex dubious and transposon)

Is that the same as querying for a product type of "protein"?

ANY 'disease' gene

Is that any gene with an annotation to a term from the disease_associated CV?

Yes. We used a query for genes annotated to PBO:5000000 in the old FAQ (with link to advanced search).

All sequence specific transcription factors

Could you explain that one?

It's a little complicated. The old FAQ describes and links to two suggested queries (see http://www.pombase.org/faqs/how-can-i-find-transcription-factors-and-their-targets-pombase). I think the one that gets transcription factors is (GO:0000976 OR GO:0003700), but we also suggest (GO:0000978 AND (characterisation status = published)) in case people want to see if there are targets published that we haven't got curated.

All protein coding genes (ex dubious and transposon)

Is that the same as querying for a product type of "protein"?

To get the "ex [i.e. don't include] dubious and transposon", it has to be ((product type = protein) AND NOT (characterisation status = dubious) AND NOT (characterisation status = transposon)). Because reasons.

Thanks.
There is a section in the config file called "predefined_queries" that can be used to configure any query that can be made in the query builder.  My plan is to configure these canned queries there.  What's missing is an easy way to export a query from the query builder.  I've added an issue for that: #492

We should  probably be a little bit more specific about what these terms find in the docs (since it is so confusing!)
We should say that in GO transcription factor are described by two molecular function terms,
a DNA binding activity and a  "transcriptional regulator  activity"
transcription factor activity, sequence-specific DNA binding (GO:0003700)
should find all DNA binding transcription factors.
This will include mitochondrial, Pol I, II and III DNA binding TF-s
To restrict to pol II use
transcription factor activity, RNA polymerase II core promoter proximal region sequence-specific binding (GO:0000982)
(the transcription factor term)
Or
RNA polymerase II core promoter proximal region sequence-specific DNA binding (GO:0000978)
the DNA binding term
(annotations should be equivalent, I check this periodically, they appear to have deviated by 2)

This is implemented now for these two canned queries:

ANY 'disease' gene
All protein coding genes (ex dubious and transposon)

but won't be in the preview until later.

All deletion allele viable/inviable

This one needs a bit of work on the server side.  The web code needs to generate those subsets so that the query builder can use them.  It won't take long so I'll do that next.

All sequence specific transcription factors

I'm still confused by that one.  To make it easier (for me at least) I've added a way to get the JSON representation of a query so I can paste that JSON into the config file.  Once the preview is updated later you'll be able to double click on the query description in the query history table to get a pop-up dialog containing the JSON.  Once it's re-released, I'll ask you to do the query and let me know the JSON.

This is implemented now for these two canned queries:

ANY 'disease' gene
All protein coding genes (ex dubious and transposon)
but won't be in the preview until later.

There is now a "Canned queries" tab in the query builder.  Is that the label we want?

All deletion allele viable/inviable
This one needs a bit of work on the server side. The web code needs to generate those subsets
so that the query builder can use them. It won't take long so I'll do that next.

I only just noticed that this issue is "after public release" so I'm going to work on other things first.

Once the preview is updated later you'll be able to double click on the query description in the query
history table to get a pop-up dialog containing the JSON.

That's working now so if you come up with any other queries to add to the "canned queries" just double click on the query description (the "Query" column in the history) and send me the JSON it shows you.

All sequence specific transcription factors

yes curators should figure out the best way to do this query (there are 2 branches which should be concurrently annotated).
Also, it might help users to have 2 queries

All sequence specific transcription factors
All RNA pol II sequence specific transcription factors

All sequence specific transcription factors
All RNA pol II sequence specific transcription factors

They're easy to add if you can send me the query JSON.

@mah11  done?

can open a new ticket for anything else?


Also needed to install pymongo

This is weird since pymongo is in the setup.py file and so should be install when you "pip install" NSpyre.  ie in these steps:
conda create -n nspyre python=3
activate nspyre
conda install pyzmq
pip install -e .
pip install git+https://github.com/pyqtgraph/pyqtgraph.git


Ampersand and measure name causes display issue in Tabular Editor Measure Editor

Describe the bug
We have a measure named Functional P&L Actuals. And want to edit the model in TE2.
To Reproduce
Steps to reproduce the behavior:

Go to any table
Click on Create New > Measure
Name it P&L
Look at the first line of measure editor

Expected behavior
The measure is named P&L.
Observed behavior
The measure is showing up as PL in Tabular Editor 2:

In Power BI this works fine:

In Excel it works fine as well:

Application specifics

Tabular Editor 2.X version: 2.23.0
Semantic Engine used: [e.g. Power BI Desktop, Azure Analysis Services, SSAS 2019, etc.]
Model Compatibility Level: [e.g. 1400, 1500, 1520, etc.]

Additional context
Add any other context about the problem here.

Hi @fmms
Yes, this looks like a bug, and I am also able to reproduce it on my end.
Interestingly, it only seems to apply to the & character, and all other special characters work fine.
It is an UI bug and will not have any impact on the actual name in the model. The name in the TOM Explorer (1) and in the Properties (2) is the one that is shown to users of the model.

@mlonsk yes it is a display only issue.


Get started cards

Add link to Figma.
Bridget still looking into positioning for status indicator (feels similar to radio button).
Use productive card under the hood.
### Acceptance criteria
- [ ] Determine whether to create new Get Started component
- [ ] Should use clickable variant of productive card
- [ ] Add gradient mixin

Create follow up issue to update remaining novice-to-pro components to use the mixin (currently see gradient repeated in ~8 files).

Questions

Can we implement this using Logical Properties? (where necessary)
Does this need any accessibility testing written?
E2E testing?
Typescript support out of the gate?

Can we implement this using Logical Properties? (where necessary)
+1 — we’re starting to look into them and adopt them in some of the newer work but haven’t really added it as part of acceptance criteria yet. #3556

Does this need any accessibility testing written?
We do a very baseline toBeAccessible() in scaffolding but not sure how much additional testing we need. Definitely open to pulling in some rigor if Dotcom devs have any input. :)

E2E testing?
Currently we’re only doing e2e for avt. But agree we should include this story as part of this initial implementation instead of adding it retroactively.

Typescript support out of the gate?
Probably depends on Cards which haven’t been migrated to .tsx yet.


qa_crowbarsetup.sh: split long lines

Conventional wisdom across the industry is that it is a bad idea to exceed 80 column lines. This is visible in countless areas, from the Linux kernel coding style through to PEP8 and beyond.  Long lines definitely make code harder to read for some people, so even if you don't personally feel it increases readability for you, please still be considerate of other people.
It's not just a matter of taste either.  Some user interfaces do not automatically wrap lines, so in those cases long lines can cause significant usability issues.  For example, when viewing diffs on parts of github, the lack of line wrapping means that you have to use a horizontal scroll bar to see the whole line:

This is a major PITA.
In the case where there is an if statement with a long conditional, it means that the conditional gets broken across multiple lines.  In this case it's more readable if the then is on its own line, so you can clearly see where the conditional ends and the body begins.  This type of approach is advocated in

http://wiki.bash-hackers.org/scripting/style

This requires ignoring a ridiculous bashate rule (E011) which complains if then is not on the same line as the if beginning a conditional.

+1 I agree split lines add to readability

Rebased, added some more line splits, and added a proper justification to the commit message.

Rebased.  I believe I have justified this change and there are no unanswered objections to merging.  If that's not the case then please respond.


No healthchecks to upstreams from Envoy

Describe the bug
No healthchecks from Envoy
Expected behavior
Envoy sends heathchecks to the upstreams
Steps to reproduce the bug
Create a deployment with istio
Version
1.01
Installation
Kubenetes with Helm
Environment
CentOS
Cluster state
Probably does not matter here
Hi, in the documentation: https://istio.io/docs/concepts/traffic-management/, it states that Envoy will perform active healthcheck to the upstreams.
However after inspecting the code and doing the tcpdump in the sidecar container, I found no such behaviour from Envoy:
https://github.com/istio/istio/blob/18bd3e70530f737ec1c9e5666035c691b5893e04/pilot/pkg/networking/core/v1alpha3/cluster.go
I am wondering if I miss anything here?
Thank you.

Same issue. Without the health-checks, we are not able to run gRPC services reliably.

I encountered this situation with an ingress-gateway sending traffic to a dead pod. The problem did solved itself after a while (around 30 min) but I would expect istio to eject bad IPs from the mesh in a timely manner (as in less than a minute).
The problem is two fold:

pilot seems to send an invalid IP for a an endpoint from a now delete pod
the envoy in the gateway doesn't do any sort of eviction if an invalid endpoint get pushed into it's endpoint list

Example of envoy telling endpoints are healthy but really aren't. Note that even though the gateway responded timeout responses, it still flagged those as healthy.
istioctl pc endpoints istio-ingressgateway-67b7cffc4-6sf92 -n istio-system | grep geop
<IP_ADDRESS>:8080        HEALTHY     outbound|80||geop-test.backend.svc.cluster.local
<IP_ADDRESS>:9102        HEALTHY     outbound|9102||geop-test.backend.svc.cluster.local

After investigation, i went through pilot discovery logs  for that IP, this is what i found.
2018-11-20T16:43:16.163577Z     warn    Omitting listener for management address <IP_ADDRESS>_9102 ({%!s(*core.Address_SocketAddress=&{0xc420a38800})}) due to collision with service listener <IP_ADDRESS>_9102 ({%!s(*core.Address_SocketAddress=&{0xc4215cb4c0})})
2018-11-20T16:43:16.166753Z     info    ads     LDS: PUSH for node:geop-test-b58c6d99d-262vt.backend addr:"<IP_ADDRESS>:59956" listeners:58 112472
2018-11-20T16:43:17.496718Z     info    Handle EDS endpoint geop-test in namespace backend -> [{[{<IP_ADDRESS>  0xc4225f4e20 &ObjectReference{Kind:Pod,Namespace:backend,Name:geop-test-b58c6d99d-262vt,UID:456954c7-ecdf-11e8-83a4-0a86a660222e,APIVersion:,ResourceVersion:15461425,FieldPath:,}}] [{<IP_ADDRESS>  0xc4225f4e30 &ObjectReference{Kind:Pod,Namespace:backend,Name:geop-test-679b79f487-h9fj9,UID:60937095-ece3-11e8-83a4-0a86a660222e,APIVersion:,ResourceVersion:15467213,FieldPath:,}}] [{metrics 9102 TCP} {http 8080 TCP}]}] [0xc420f15ec0 0xc420f15f20]
2018-11-20T16:43:17.698556Z     info    ads     EDS: INC PUSH for sidecar~<IP_ADDRESS>~geop-test-b58c6d99d-262vt.backend~backend.svc.cluster.local-349 clusters 62 endpoints 58 empty 4
2018-11-20T16:44:59.733502Z     info    Handle EDS endpoint geop-test in namespace backend -> [{[{<IP_ADDRESS>  0xc420f1a290 &ObjectReference{Kind:Pod,Namespace:backend,Name:geop-test-679b79f487-h9fj9,UID:60937095-ece3-11e8-83a4-0a86a660222e,APIVersion:,ResourceVersion:15467590,FieldPath:,}} {<IP_ADDRESS>  0xc420f1a2a0 &ObjectReference{Kind:Pod,Namespace:backend,Name:geop-test-b58c6d99d-262vt,UID:456954c7-ecdf-11e8-83a4-0a86a660222e,APIVersion:,ResourceVersion:15461425,FieldPath:,}}] [] [{metrics 9102 TCP} {http 8080 TCP}]}] [0xc420c3f6e0 0xc420c3fa40 0xc420c3fec0 0xc420916180]
2018-11-20T16:44:59.785876Z     info    Handling event update for pod geop-test-b58c6d99d-262vt in namespace backend -> <IP_ADDRESS>
2018-11-20T16:44:59.808206Z     info    ads     ADS: "<IP_ADDRESS>:59956" sidecar~<IP_ADDRESS>~geop-test-b58c6d99d-262vt.backend~backend.svc.cluster.local-349 terminated rpc error: code = Canceled desc = context canceled

From that point i must say my knowledge of the inner working of istio is too limited.

Version: 1.03
Installation: Kubenetes with Helm


preparatory commit for #25719

This is a preparatory commit for #25719 based on comment
This commit refactors the worker object to use a global scope when initialized, so that it can be accessed by methods outside the initialize method.
This is a preparatory commit, and can be useful to call methods rather than trigger events to update typing status.

Screenshots and screen captures:

Self-review checklist

[ ] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[ ] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[ ] Each commit is a coherent idea.
[ ] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[ ] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

Maybe you should rename it to compose_box_worker too?

well, this worker object will also be used for the input box for message editing, apart from the compose box. So, will compose_box_worker still be a good name?
How about compose_edit_worker ?

I had been thinking that we might just need independent workers for the different input elements. At least, that's the direction I've been thinking may be required to resolve https://github.com/zulip/zulip/pull/28585#discussion_r1501945112.

Looks like this one enver got the integration review label and got a little lost, sorry about that!


Enable Lexer and Parser object reuse, add 3D and 4D tokens

Parameter is no longed required on Lexer and Parser instantiation.
Parser now creates a single Lexer and stores in a static var.
Modified Parser::parse() to accept a new value in parameter.
Tokens for 3D and 4D geometry added to Lexer.

If there's no objection I'll merge this. I need fccbc0d for geo-obj.


exclude any queries with subqueries from parallelization

Scope & Purpose
Exclude any queries using subqueries from parallelization

[ ] Bug-Fix for devel-branch (i.e. no need for backports?)
[x] Bug-Fix for a released version (did you remember to port this to all relevant release branches?)
[ ] Strictly new functionality (i.e. a new feature / new option, no need for porting)
[x] The behavior in this PR can be (and was) manually tested (support / qa / customers can test it)
[x] The behavior change can be verified via automatic tests

Testing & Verification
This change is already covered by existing tests, such as scripts/unittest shell_server_aql --cluster true.
https://<IP_ADDRESS>/view/PR/job/arangodb-matrix-pr/7749/

Tests blue.


Modify windmill DirectStreamObserver to call isReady only every 10 messages by default

This provides more output buffering which ensures that output is not throttled on synchronization when message sizes exceed 32KB grpc isready limit.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

R: @reuvenlax

This is motivated by excessive onReady overhead observed in #24836

Run Dataflow ValidatesRunnerStreaming

Run Dataflow Streaming ValidatesRunner


Update rb-sys to 0.9.44

This fixes a couple of recent issues with windows builds as we inch towards 3.2

🎉


KeePass 2 file attachments import

Trying to use the converter from KeePass 2 and there are some entries in KP that have file attachments (KP allows them). They don't seem to make it in any form into 1Password, even though attachments seem to be supported in 1P.

btis01,
Please post your question / request on the AgileBits form, in this thead:
https://discussions.agilebits.com/discussion/30286/mrcs-convert-to-1password-utility/p1
and I will follow-up there.

This issue is now closed.  It was resolved by supporting KeePass 2 attachment decoding and file creation.  Discussion at the thread above.


Avoid calling the before_send callback with transaction events

Reading the Tracing documentation I found out that the before_send callback shouldn't be called for the transactions. This PR fixes the behaviour, but it kinda of breaks the BC because users that were relying on this behaviour will not be able to do it anymore. Since this is a bug I consider the BC justified and I don't see any other way to avoid it anyway

Maybe you could point people to traces_sampler in case they were using before_send before?

Do you mean in the CHANGELOG?

Yeah, no sense putting it in the UPGRADE, maybe something like:
- Fix unwanted call to the `before_send` callback with transaction events, use `traces_sampler` instead to filter transactions (#1158)

Makes sense, done!


Provide a function to bind values to a parameter and collect all bound parameter values

resolves #135

I'm inclined to add convenience methods

getParameter()
toCypher()

to the Statement class to avoid going through the collector (and for completeness, through the default renderer).
WDYT?

Could you elaborate on

to avoid going through the collector
From my understanding each visitor is separated and needs to get called explicitly.
Even though I think that the convenience methods would make sense I won't give the Statement more functionality in itself but just keep it as a subject that gets passed over to the parameter and/or render visitor.

I'm inclined to add convenience methods

getParameter()
toCypher()

to the Statement class to avoid going through the collector (and for completeness, through the default renderer).
WDYT?

@michael-simons I agree with the suggestion, but also don't have much pain with the current way of doing things. I am also planning a PR with a pretty-print renderer, so the convenience method would be out of the question for us.

Thanks for your input.
The parameters are a closed use case, keeping it close to the statement makes it possible to reduce the API on the Parameter.
For the renderer, that should be possible in both ways.


Delay between first page render and SPFx Application Customizer availability

Category

[x] Question
[ ] Typo
[ ] Bug
[ ] Additional article idea

On our application customizer extension we always have a ugly delay that is caused by the loading sequence of the modern page. First the page displays some HTML elements and after a few seconds our application customizer page is loaded and the header appears. This leads to a poor user experience because elements of the page jump around.
Observed Behavior
Please see a simple example here, where we only do a console log in the constructor.

There are at least 2-4 seconds where the user sees the vanilla modern layout, before the app customizer renders.
Is there any best practice or example, how to speed up the loading time / sequence of SPFx app customizer components? Within the old world (classic pages) we had direct influence on the sequence scripts are loaded (e.g. Custom Actions loaded in header).
Any hints how to improve this would be appreciated. Thanks in advance!

Due to the customizer is worked on the DOM element, so it should have not any best UX solution now. Maybe we can try add some mask to notified user before the customizer finishes loading.

Actually we have the same problem with loading delay of app customizers. Even if we add some kind of loading overlay to notify the users, this overlay will appear with a delay so that the underlying modern page is visible for a few seconds. Quite confusing for our users.

bringing this back for just a moment to see if the bits suggested by @VesaJuvonen have come through yet.  My current hypothesis is that it has come through for SP Online pieces (in the more recent framework updates) but those updates do not apply to SP On Prem (SP 2019 which is on Framework 1.4.x).  And just a question if this is the case, will there be any effort to help the On Prem case.  Thanks!

I think we observed the web parts starting to load faster than the extensions. That's definitely not due to the way javascript files are loaded, it seems to be a deliberate decision. IMO we should be able to set a priority value for the loading of any given web part or extension, that'd be incredibly useful!

Is this resolved yet ? I created a SPFx app customizer to hide a certain section in the pages. But due to the delay, the sections load first and then get hidden. I believe this is a replacement for custom action. In that case, this should load first. I read that the onInit() function is fired before DOM is loaded.


Warning: Mounting volumes containing files downloaded with Safari in OS X

I encountered an obscure error a few days ago and I felt compelled to publish it where it might help some people.
Here is the story.
For a while I've been facing permissions errors from within containers trying to access certain files and I couldn't work out why this was happening. It only affected files when mounting them to the container, not when added to the container. Further more, when executing a shell inside the container, the files existed and the user could write to the mounted directory.
This bugged me for weeks and I'd reverted to rebuilding the containers whenever I made a change. Strangely, when a friend of mine pulled the code from git and mounted the volume... it worked. I concluded this was an error on my personal machine.. However when he pushed new code it miraculously worked on my machine...
After some inspection I noticed that the file downloaded with safari contained an extended attribute 'com.apple.quarentine'. Removing this made everything work again. And because git strips extended attributes before committing this is why 'git files' worked.
It turns out, when downloading files with Safari on OS X, OS X adds an attribute to refuse access to the file until it has been opened. Now this was causing OS X to refuse access when boot2docker wanted to access the files. SILENTLY. Yay.
So if a warning could be given when mounting 'quarentined' files, it would be fantastic... And perhaps save others the wasted time figuring this out.
Cool.

Nice find! And thanks for looking into the cause!

I think this is worth a docs mention.

@cpuguy83 agreed. Wondering if this should be in the Docker or Boot2Docker docs. I'll have to test if this also affects docker directly (when the build context contains downloaded files), or only when accessing the files via VBox shared volumes.
@alexisvincent in your setup, does this only affect files that are used in a volume? Or also if they are added to an image (ie COPY some-downloaded-file /dest/in/image)?

Only if they are mounted through VBox... Here are a few considerations:

DockerMachine is probably the better place to send this.
User will probably use docker or compose to mount, so if a message should be displayed it should be in those tools not docker-machine.
I'm not sure how the other drivers respond to this (VMWare Fusion for instance...)

Thanks for adding that information! Tough one, I think it's more useful in Boot2Docker than machine (machine also is used with other drivers), but yeah, a mention in machine docs could be useful
@SvenDowideit wdyt? Also, do you know if Fusion shows the same problem?

Awesome. My guess is that it will. I can test it actually...
May take some time

@alexisvincent It has been detected that this issue has not received any activity in over 1 year. Can you please let us know if it is still relevant:

For a bug: do you still experience the issue with the latest version?
For a feature request: was your request appropriately answered in a later version?
Thank you!


Change previous/next month opacity from 2/10 to 3/10

This is a tiny pull request that increases the readability of the new previous/after month display by increasing the opacity from 2/10 to 3/10.
Here is a before/after comparison:

This is less of a fix and more of a personal preference, but I do think the default 2/10 opacity is quite hard to read at a distance on dark mode.

Agreed!


[Feature] - Support Pydantic 2 and remove support for Pydantic V1

This PR updates Flask-Pydantic-Spec to only support Pydantic V2.  After this PR is merged, only Pydantic V2 will be supported by Flask-Pydantic-Spec.
As part of this upgrade, we have decided to fully target OpenAPI 3.1 as the output of the library.  As such, there are a few changes to keep in mind.

It's not valid in OpenAPI 3.1 for a path to not return some kind of response, and if it does, it should be a successful response.  As such, Flask-Pydantic-Spec will now raise an error if there is no response defined for a view.
[ and ] is not allowed in the name of the schema, so we will replace these character with _.
Expands testing to also run against Python 3.12
Updates Flake8 dependency to latest

This would be really awesome! Running into the issue that I can't use this package without downgrading Pydantic to <2

@robyoung , is it realistic to expect this to be merged any time soon and result in a new version?

Sorry, this totally dropped off my radar.

@robyoung , any idea when this will be available on pypi?

@robyoung , what is needed for this PR to be merged and deployed to pypi?

Please merge


pull request for e2e test at 11/11/2016 02:56:08

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

optest/docs/updated_at.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Add croc-hunter code

:star: PR built and available in a preview environment carlossg-croc-hunter-jenkinsx-pr-1 here

:star: PR built and available in a preview environment carlossg-croc-hunter-jenkinsx-pr-1 here


Fixed accessibility issues with close and play buttons

Removals

Removed extra div preventing "Close" button accessibility

Additions

Added tabbing accessibility outlines to both the "Close" and "Play" buttons in video player
Overrode user agent default on "Play" button to align with CFPB standards

How to test this PR

Visit https://www.consumerfinance.gov/consumer-tools/reverse-mortgages/
Tab to play button
Press enter to play the video
Tab to close button
Press enter to close the video

Related [ghe]/CFGOV/platform/issues/4171

@brandon-rusk Check the video debug view across screen sizes. I'm seeing this one main:

And this on this branch:


Human-Computer Interaction

Add Feature for playing against a computer BOT.
BOT must select move by a random selection.

The move made by the BOT will be random???

For now, yes!

There will be two options available for the user either two play with another user or to play with BOT???

Yes. It will be selected before the board formation!


Show Tags on BoxView

In this PR, changes are made to the BoxView component to display tags.

 2.0 BoxView: tags are not showing on the BoxView


configmap-reloader by manual or change the time interval between polls for ConfigMap?

How upload prometheus'rule  by manual  rules-configmap-reloader ?
Because I should wait for moment after change the configmap,I think wait to long...

How upload prometheus'rule by manual rules-configmap-reloader ?

You don't. That ConfigMap is governed by prometheus-operator and shouldn't be edited manually. You should use PrometheusRule objects for storing alerting and recording rules.


Add support for CUDA 10.2

What changes were proposed in this pull request?
Update scripts, source code, and documentation to build and run with CUDA 10.2, as well as adjust presets to load new dependencies from libnd4j.
How was this patch tested?
Builds and runs CUDA examples fine on Fedora 30 from redist artifact.

So, I can build fine using this:
libnd4j/buildnativeoperations.sh -c cpu -a avx2 -h mkldnn -j 8 && libnd4j/buildnativeoperations.sh -c cuda -cc 61 -j 8 && mvn clean install -Dmaven.test.skip -Dmaven.javadoc.skip=true -Dlibnd4j.cuda=10.2 -Dlibnd4j.compute=61 -pl '!libnd4j'

until I hit this:
https://gist.github.com/AlexDBlack/471dff473d3042c6a03a4fb006f4332f
(downloading snapshots when using shell script build also happens on master)
Whereas if I use maven:
mvn install -pl libnd4j -Dmaven.test.skip=true -Dmaven.javadoc.skip=true -Dlibnd4j.cuda=10.2 -Dlibnd4j.compute=61 && mvn clean install -Dmaven.test.skip -Dmaven.javadoc.skip=true -Dlibnd4j.cuda=10.2 -Dlibnd4j.compute=61 -pl '!libnd4j'

I get this:
https://gist.github.com/AlexDBlack/6f82449ae9c74eb5c86d4e3aef693e01
Note the latter command works on master (with 10.1 of course)

Looks like the build is assuming something about the state of the artifacts on the CI server...?

For the first issue, I think it's more that the buildnativeoperations.sh script (when not run through maven) doesn't install to the local maven repository, but we still have a dependency on it. So it fetches it from sonatype instead.
Even though we don't actually need the maven copy during the build, as we should (and are, afaik are) using the output of the manually run build script.

So if I cut out most of the args in the pom.xml for CPU build, I get this (using mvn clean install):
https://gist.github.com/AlexDBlack/e9101d0326fc35bf2d01a443dc62ecab
[INFO] bash C:\DL4J\Git\deeplearning4j\libnd4j/buildnativeoperations.sh --chip cpu
/bin/bash: C:\DL4J\Git\deeplearning4j\libnd4j/buildnativeoperations.sh: No such file or directory

Which doesn't make sense. I've also double checked the PR, everything looks fine to me.
It would be good to know if this is isolated to my machine somehow, or whether it's reproducible elsewhere.

You probably have WSL installed. I've fallen into this recently. So, bash cmd executes /bin/bash from WSL rather than mingw

Yep, I definitely do have WSL (WSL 2 in fact) installed, added fairly recently...

In this case temporary workaround is trivial. In pom.xml replace bash with absolute path to it.

These failures are on master atm.

check_numerics/strictly_increasing are order of exec issues we've discussed before
svd is a sign issue. graph should be modified with abs op following svd
and only mobilenet is something new.


Fix export ConductorHttpClientConfig fields

Pull Request type

[x] Bugfix
[ ] Feature
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes (Please run ./gradlew generateLock saveLock to refresh dependencies)
[ ] WHOSUSING.md
[ ] Other (please describe):

Changes in this PR
When worker initialized with config ConductorHttpClientConfig struct fileds baseUrl, and bearerToken are private, and can only be accessed from the package it is declared in.
This change:

exports baseUrl and bearerToken fields
add new worker constructor function NewConductorWorkerWithConfig

Alternatives considered
Describe alternative implementation you have considered

@blz-ea We are deprecating usage of this go-client in favor of the go-sdk available here. Please take a look.

Closing this PR for now, please open a PR in go-sdk if still relevant.

Awesome, thank you


(Contributing) FAQ

I believe it would be an excellent idea to incorporate a "Contributing FAQ"/"FAQ" or provide examples on "How to X" within our blog/documentation. I think many of the challenges I faced initially are likely to be encountered by others as well (especially now, with a lot of newbies joining).
Examples like

The fundamental steps in the contribution process, including opening issues, assigning tasks, applying labels, creating branches, initiating pull requests, and implementing rebasing techniques, among others.
...?

I believe that such additions would greatly enhance the accessibility and user-friendliness of the CUBOS contribution process, especially when supplemented with additional examples / common issues we've had in the past.
Additionally, this change would simplify the task of the reviewers by reducing the occurrence of minor issues and nitpicks.

We do have a contribution guidelines page, but its kinda hidden 😞 we could also add some links to this type of content to the new issue/PR pages

We do have a contribution guidelines page, but its kinda hidden 😞 we could also add some links to this type of content to the new issue/PR pages

Yeah I totally didnt know this page existed XD

Creating a useful links channel in the discord could also be a good idea


When using VSCode on HDR monitor, VSCode is dim

Issue Type: Bug
VSCode is not respecting the SDR whitelevel setting. Chromium has support for reading this value and boosting the pixel values appropriately, but VSCode/Electron is not doing this. Please contact<EMAIL_ADDRESS>if you have any questions on HDR support.
VS Code version: Code 1.33.1 (51b0b28134d51361cf996d2f0a1c698247aeabd8, 2019-04-11T08:27:14.102Z)
OS version: Windows_NT x64 10.0.18362

Dupe of #68069


Add type annotations in RegexBuilder tests

These changes work around a change to the way result builders are compiled that removes the ability for result builder closure outputs to affect the overload resolution elsewhere in an expression.
Workarounds for rdar://104881395 and rdar://104645543
This should fix the CI errors visible in #626 and #627.

@swift-ci Please test


Winget: adding new repository

I want to see the ability to add new repository(you don't have to implement it)
Description of the new feature/enhancement
you can add new software repository similar to winget-pkg

Proposed technical implementation details (optional)
adding this command: winget addrep [the url of the repository]
using the command above with the url you want, you can add third party repository

I think this is a duplicate of #118 (as well as a few others I'm sure).

The command is winget source add
PS C:\Users\denelon> winget source add -?
Windows Package Manager v0.2.10771 Preview
Copyright (c) Microsoft Corporation. All rights reserved.

Add a new source. A source provides the data for you to discover and install packages. Only add a new source if you trust it as a secure location.

usage: winget source add [-n] <name> [-a] <arg> [[-t] <type>]

The following arguments are available:
  -n,--name  Name of the source
  -a,--arg   Argument given to the source
  -t,--type  Type of the source

More help can be found at: https://aka.ms/winget-command-source
PS C:\Users\denelon>

Duplicate of #118


GPIO OUTPUT

Hi,
Very nice project steve
I'm using this project to manage 2 heater with same method ( PID control ) ,without  Jeelabs Thermo Plug circuit board (1wire and GPIO) and Jeelabs Output Plug (I2C); "the raspberry pi connected directly to SSR relay", but I can't identify GPIO Output (BCM or BOARD) number.
Even after the configuration in config.xml The output PID not working ...And  parameter control only the GPIO control panel PUMP/STIR1...
Please i need help with this issues and thanks any way :+1:

Check that the GPIO pin is not exported to the /sys/class/gpio/
My collide with that.


[Display ERC-721] Implement feature

changed estimate, as it was more complex that I initially thought


POST Params are not there

It seems POSTed params are not passed any more.
This can be seen with errors in postapp and pastebin always saying No empty pastes please.

It look like this is caused by Bailador using keys like psgi.input, when it's now called p6sgi.input (notice the 6).

Same problem here.

Oh, it seems like https://github.com/tadzik/Bailador/pull/44 is supposed to fix it.

Should be fixed, but are there any tests?

There are already plenty of tests with POST.


runtime error: slice bounds out of range

Description
Describe the issue that you're seeing.
caddy server container crashed with panic. hope this might help someone. great project thank you

cdn-in-a-box-caddy-1  | panic: runtime error: slice bounds out of range [862:0]
cdn-in-a-box-caddy-1  |
cdn-in-a-box-caddy-1  | goroutine 21235869 [running]:
cdn-in-a-box-caddy-1  | github.com/corazawaf/coraza/v3/internal/corazawaf.(*bodyBufferReader).Read(0xc047d6cd50, {0xc038774000?, 0x0?, 0x7fce60935688?})
cdn-in-a-box-caddy-1  |         github.com/corazawaf/coraza/v3@v3.0.0-20230117071831-8b909c7fc345/internal/corazawaf/body_buffer.go:98 +0x139
cdn-in-a-box-caddy-1  | io.discard.ReadFrom({}, {0x1f8f960, 0xc047d6cd50})
cdn-in-a-box-caddy-1  |         io/io.go:611 +0x72
cdn-in-a-box-caddy-1  | io.copyBuffer({0x1f97800, 0x2ca05e0}, {0x1f8f960, 0xc047d6cd50}, {0xc05461a000, 0x8000, 0x8000})
cdn-in-a-box-caddy-1  |         io/io.go:413 +0x14b
cdn-in-a-box-caddy-1  | io.(*multiReader).writeToWithBuffer(0xc051094c48, {0x1f97800, 0x2ca05e0}, {0xc05461a000, 0x8000, 0x8000})
cdn-in-a-box-caddy-1  |         io/multi.go:54 +0x125
cdn-in-a-box-caddy-1  | io.(*multiReader).WriteTo(0x19bcd00?, {0x1f97800, 0x2ca05e0})
cdn-in-a-box-caddy-1  |         io/multi.go:45 +0x56
cdn-in-a-box-caddy-1  | io.copyBuffer({0x1f97800, 0x2ca05e0}, {0x7fce601809b8, 0xc047d4bbf0}, {0x0, 0x0, 0x0})
cdn-in-a-box-caddy-1  |         io/io.go:409 +0x16e
cdn-in-a-box-caddy-1  | io.Copy(...)
cdn-in-a-box-caddy-1  |         io/io.go:386
cdn-in-a-box-caddy-1  | net/http.(*transferWriter).doBodyCopy(0xc02cddcdc0, {0x1f97800?, 0x2ca05e0?}, {0x7fce601809b8?, 0xc047d4bbf0?})
cdn-in-a-box-caddy-1  |         net/http/transfer.go:412 +0x4d
cdn-in-a-box-caddy-1  | net/http.(*transferWriter).writeBody(0xc02cddcdc0, {0x1f8e160, 0xc0293ac640})
cdn-in-a-box-caddy-1  |         net/http/transfer.go:375 +0x418
cdn-in-a-box-caddy-1  | net/http.(*Request).write(0xc069109700, {0x1f8e160, 0xc0293ac640}, 0x0, 0x0, 0x0)
cdn-in-a-box-caddy-1  |         net/http/request.go:701 +0xb46
cdn-in-a-box-caddy-1  | net/http.(*persistConn).writeLoop(0xc0595f9b00)
cdn-in-a-box-caddy-1  |         net/http/transport.go:2395 +0x174
cdn-in-a-box-caddy-1  | created by net/http.(*Transport).dialConn
cdn-in-a-box-caddy-1  |         net/http/transport.go:1752 +0x1791

Steps to reproduce
Clear steps describing how to reproduce the issue. Please please please link to a demo project if possible, this makes your issue much easier to diagnose (seriously).
reverse proxy server being hammered by bots
Expected result
What should happen?
Actual result
What happened.

Thanks for reporting this issue. I will check it out later
On Sat, 18 Feb 2023, 10:00 Omar Ramadan, @.***> wrote:

Description
Describe the issue that you're seeing.
caddy server container crashed with panic. hope this might help someone.
great project thank you
cdn-in-a-box-caddy-1 | panic: runtime error: slice bounds out of range
[862:0] cdn-in-a-box-caddy-1 | cdn-in-a-box-caddy-1 | goroutine 21235869
[running]: cdn-in-a-box-caddy-1 |
github.com/corazawaf/coraza/v3/internal/corazawaf.(bodyBufferReader).Read(0xc047d6cd50,
{0xc038774000?, 0x0?, 0x7fce60935688?}) cdn-in-a-box-caddy-1 |
@.**/internal/corazawaf/body_buffer.go:98
+0x139 cdn-in-a-box-caddy-1 | io.discard.ReadFrom({}, {0x1f8f960,
0xc047d6cd50}) cdn-in-a-box-caddy-1 | io/io.go:611 +0x72
cdn-in-a-box-caddy-1 | io.copyBuffer({0x1f97800, 0x2ca05e0}, {0x1f8f960,
0xc047d6cd50}, {0xc05461a000, 0x8000, 0x8000}) cdn-in-a-box-caddy-1 |
io/io.go:413 +0x14b cdn-in-a-box-caddy-1 |
io.(*multiReader).writeToWithBuffer(0xc051094c48, {0x1f97800, 0x2ca05e0},
{0xc05461a000, 0x8000, 0x8000}) cdn-in-a-box-caddy-1 | io/multi.go:54
+0x125 cdn-in-a-box-caddy-1 | io.(*multiReader).WriteTo(0x19bcd00?,
{0x1f97800, 0x2ca05e0}) cdn-in-a-box-caddy-1 | io/multi.go:45 +0x56
cdn-in-a-box-caddy-1 | io.copyBuffer({0x1f97800, 0x2ca05e0},
{0x7fce601809b8, 0xc047d4bbf0}, {0x0, 0x0, 0x0}) cdn-in-a-box-caddy-1 |
io/io.go:409 +0x16e cdn-in-a-box-caddy-1 | io.Copy(...)
cdn-in-a-box-caddy-1 | io/io.go:386 cdn-in-a-box-caddy-1 |
net/http.(*transferWriter).doBodyCopy(0xc02cddcdc0, {0x1f97800?,
0x2ca05e0?}, {0x7fce601809b8?, 0xc047d4bbf0?}) cdn-in-a-box-caddy-1 |
net/http/transfer.go:412 +0x4d cdn-in-a-box-caddy-1 |
net/http.(*transferWriter).writeBody(0xc02cddcdc0, {0x1f8e160,
0xc0293ac640}) cdn-in-a-box-caddy-1 | net/http/transfer.go:375 +0x418
cdn-in-a-box-caddy-1 | net/http.(*Request).write(0xc069109700, {0x1f8e160,
0xc0293ac640}, 0x0, 0x0, 0x0) cdn-in-a-box-caddy-1 |
net/http/request.go:701 +0xb46 cdn-in-a-box-caddy-1 |
net/http.(*persistConn).writeLoop(0xc0595f9b00) cdn-in-a-box-caddy-1 |
net/http/transport.go:2395 +0x174 cdn-in-a-box-caddy-1 | created by
net/http.(*Transport).dialConn cdn-in-a-box-caddy-1 |
net/http/transport.go:1752 +0x1791
Steps to reproduce
Clear steps describing how to reproduce the issue. Please please please
link to a demo project if possible, this makes your issue much easier
to diagnose (seriously).
reverse proxy server being hammered by bots
Expected result
What should happen?
Actual result
What happened.
—
Reply to this email directly, view it on GitHub
https://github.com/corazawaf/coraza/issues/664, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAXOYAVBXS3YJBDFVEXQXKTWYCFRBANCNFSM6AAAAAAVAHORA4
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

This is a weird issue and I guess it happens only because you run bots and at some point during the read you also write and then move towards a file.

Thanks for the fix @jcchavezs. I am seeing this crash a few times per day right now. Would appreciate a release into corazawaf/coraza-caddy when the change is landed.

@kkroo https://github.com/kkroo could you please test with the latest
version of this module to get the errors again?
On Thu, 23 Feb 2023, 19:51 Omar Ramadan, @.***> wrote:

Thanks for the fix @jcchavezs https://github.com/jcchavezs. I am seeing
this crash a few times per day right now. Would appreciate a release into
corazawaf/coraza-caddy when the change is landed.
—
Reply to this email directly, view it on GitHub
https://github.com/corazawaf/coraza/issues/664#issuecomment-1442269140,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAXOYARTOHFDR3QXJCAAWC3WY6WUZANCNFSM6AAAAAAVAHORA4
.
You are receiving this because you were mentioned.Message ID:
@.***>

Just rebuilt from master and report back if I see another crash.
Doesn't look like the fix made it in the latest version though.
github.com/corazawaf/coraza-caddy v1.2.3-0.20230224222231-e5bec900d1d2 github.com/corazawaf/coraza/v3 v3.0.0-20230222164726-1ac270a3257d

As I said, the proposed fix is very unusual logic so we want to be 100% we
are looking at the right code. Please do send me logs if this happens again.
On Sat, 25 Feb 2023, 22:28 Omar Ramadan, @.***> wrote:

Just rebuilt from master and report back if I see another crash.
Doesn't look like the fix made it in the latest version though.
github.com/corazawaf/coraza-caddy v1.2.3-0.20230224222231-e5bec900d1d2
github.com/corazawaf/coraza/v3 v3.0.0-20230222164726-1ac270a3257d
—
Reply to this email directly, view it on GitHub
https://github.com/corazawaf/coraza/issues/664#issuecomment-1445210018,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAXOYAQEHXTALCOX734JHQTWZJ2QHANCNFSM6AAAAAAVAHORA4
.
You are receiving this because you were mentioned.Message ID:
@.***>

cdn-in-a-box-caddy-1  | panic: runtime error: slice bounds out of range [45:0]
cdn-in-a-box-caddy-1  |
cdn-in-a-box-caddy-1  | goroutine 22441553 [running]:
cdn-in-a-box-caddy-1  | github.com/corazawaf/coraza/v3/internal/corazawaf.(*bodyBufferReader).Read(0xc02e3c0b70, {0xc031f20000?, 0x2c6a100?, 0x2c63a78?})
cdn-in-a-box-caddy-1  |         github.com/corazawaf/coraza/v3@v3.0.0-20230222164726-1ac270a3257d/internal/corazawaf/body_buffer.go:111 +0x12a
cdn-in-a-box-caddy-1  | io.discard.ReadFrom({}, {0x1f84c80, 0xc02e3c0b70})
cdn-in-a-box-caddy-1  |         io/io.go:611 +0x72
cdn-in-a-box-caddy-1  | io.copyBuffer({0x1f8cb20, 0x2c94800}, {0x1f84c80, 0xc02e3c0b70}, {0xc02f500000, 0x8000, 0x8000})
cdn-in-a-box-caddy-1  |         io/io.go:413 +0x14b
cdn-in-a-box-caddy-1  | io.(*multiReader).writeToWithBuffer(0xc02e27b6b0, {0x1f8cb20, 0x2c94800}, {0xc02f500000, 0x8000, 0x8000})
cdn-in-a-box-caddy-1  |         io/multi.go:54 +0x125
cdn-in-a-box-caddy-1  | io.(*multiReader).WriteTo(0x19b4760?, {0x1f8cb20, 0x2c94800})
cdn-in-a-box-caddy-1  |         io/multi.go:45 +0x56
cdn-in-a-box-caddy-1  | io.copyBuffer({0x1f8cb20, 0x2c94800}, {0x7fb53ee235b8, 0xc0c52a8870}, {0x0, 0x0, 0x0})
cdn-in-a-box-caddy-1  |         io/io.go:409 +0x16e
cdn-in-a-box-caddy-1  | io.Copy(...)
cdn-in-a-box-caddy-1  |         io/io.go:386
cdn-in-a-box-caddy-1  | net/http.(*transferWriter).doBodyCopy(0xc019535680, {0x1f8cb20?, 0x2c94800?}, {0x7fb53ee235b8?, 0xc0c52a8870?})
cdn-in-a-box-caddy-1  |         net/http/transfer.go:412 +0x4d
cdn-in-a-box-caddy-1  | net/http.(*transferWriter).writeBody(0xc019535680, {0x1f83480, 0xc024ad7200})
cdn-in-a-box-caddy-1  |         net/http/transfer.go:375 +0x418
cdn-in-a-box-caddy-1  | net/http.(*Request).write(0xc08c25c000, {0x1f83480, 0xc024ad7200}, 0x0, 0x0, 0x0)
cdn-in-a-box-caddy-1  |         net/http/request.go:701 +0xb46
cdn-in-a-box-caddy-1  | net/http.(*persistConn).writeLoop(0xc043deeb40)
cdn-in-a-box-caddy-1  |         net/http/transport.go:2395 +0x174
cdn-in-a-box-caddy-1  | created by net/http.(*Transport).dialConn
cdn-in-a-box-caddy-1  |         net/http/transport.go:1752 +0x1791

Thanks for this. I think the issue is the way the middleware is handled vs how coraza expects it to handle. We need to upgrade caddy's middleware and make it somehow with http middleware.


HIVE-25225 : Update column stat throws NPE if direct sql is disabled

Thanks for the quick fix @maheshk114!
Left some comments on the code.
Also we could definitely use some additional tests which could make sure that someone else later does not break this functionality.
Thanks,
Peter

Thanks for the quick fix @maheshk114!
Left some comments on the code.
Also we could definitely use some additional tests which could make sure that someone else later does not break this functionality.
Thanks,
Peter

Thanks Peter, for the review. I have added the tests.


Transport closure results in UNAVAILABLE from client, not INTERNAL

Issues: #9668 #9825 #9037 #9804


Upgrade to tracy-client 0.14

tracy-client 0.14 released recently, compatible with Tracy 0.8.1.

My hope with this PR was to add support for Tracy 0.8.2, but even tracy-client doesn't support that yet. Oops.

Sorry I keep forgetting to come back to this. I'm tempted to skip this version because the changes since 0.14 seem like code cleanup and doesn't really affect the behavior to an end-user. It also doesn't support 0.8.2, which I think is what you were really after. What do you think?

Seems reasonable to me. I'm really after 0.8.2 support, yeah, so this is probably not a very materially-interesting upgrade unless the broader ecosystem wants to upgrade for some other reason.

Wanted to mention 0.18 of tracy-client-sys was recently published and it works with tracy 0.8.2, but doing this:
tracy-client = { version = "0.14", optional = true }
tracy-client-sys = { version = "0.18.0", optional = true }

Doesn't result in actually using the newer tracy-client-sys library. tracy-client needs to be republished for this to take effect. I would ping the author of tracy-client if there is something important in the new code you are wanting to use.
% cargo tree --features="profile-with-tracy"
profiling v1.0.6 (/Users/pmd/dev/rust/profiling)
├── profiling-procmacros v1.0.6 (proc-macro) (/Users/pmd/dev/rust/profiling/profiling-procmacros)
│   ├── quote v1.0.21
│   │   └── proc-macro2 v1.0.43
│   │       └── unicode-ident v1.0.4
│   └── syn v1.0.100
│       ├── proc-macro2 v1.0.43 (*)
│       ├── quote v1.0.21 (*)
│       └── unicode-ident v1.0.4
├── tracy-client v0.14.0
│   ├── once_cell v1.15.0
│   └── tracy-client-sys v0.17.1
│       [build-dependencies]
│       └── cc v1.0.73
│           └── jobserver v0.1.24
│               └── libc v0.2.133
└── tracy-client-sys v0.18.0
    [build-dependencies]
    └── cc v1.0.73 (*)

I'm going to close the PR for now since I think we are going to wait until at least 0.8.2 bindings are available before updating.

After the tracy-client v0.14.1 has released, I think the 0.8.2 tracy binding should work now.


textDirection != null assert in textDirectionToAxisDirection

flutter: ══╡ EXCEPTION CAUGHT BY WIDGETS LIBRARY ╞═══════════════════════════════════════════════════════════
flutter: The following assertion was thrown building
flutter: RawGestureDetector-[LabeledGlobalKey#39376](state:
flutter: RawGestureDetectorState#e8321(gestures: , behavior: opaque)):
flutter: 'package:flutter/src/painting/basic_types.dart': Failed assertion: line 222 pos 10: 'textDirection
flutter: != null': is not true.
flutter:
flutter: Either the assertion indicates an error in the framework itself, or we should provide substantially
flutter: more information in this error message to help you determine and fix the underlying cause.
flutter: In either case, please report this assertion by filing a bug on GitHub:
flutter:   https://github.com/flutter/flutter/issues/new?template=BUG.md
flutter:
flutter: When the exception was thrown, this was the stack:
flutter: #2      textDirectionToAxisDirection (package:flutter/src/painting/basic_types.dart:222:10)
flutter: #3      Viewport.getDefaultCrossAxisDirection (package:flutter/src/widgets/viewport.dart:128:16)
flutter: #4      Viewport.createRenderObject (package:flutter/src/widgets/viewport.dart:139:58)
flutter: #5      RenderObjectElement.mount (package:flutter/src/widgets/framework.dart:4594:28)
flutter: #6      MultiChildRenderObjectElement.mount (package:flutter/src/widgets/framework.dart:5074:11)
flutter: #7      _ViewportElement.mount (package:flutter/src/widgets/viewport.dart:186:11)
flutter: #8      Element.inflateWidget (package:flutter/src/widgets/framework.dart:3052:14)
flutter: #9      Element.updateChild (package:flutter/src/widgets/framework.dart:2855:12)
flutter: #10     SingleChildRenderObjectElement.mount (package:flutter/src/widgets/framework.dart:4972:14)
flutter: #11     Element.inflateWidget (package:flutter/src/widgets/framework.dart:3052:14)
flutter: #12     Element.updateChild (package:flutter/src/widgets/framework.dart:2855:12)
flutter: #13     SingleChildRenderObjectElement.mount (package:flutter/src/widgets/framework.dart:4972:14)
flutter: #14     Element.inflateWidget (package:flutter/src/widgets/framework.dart:3052:14)
flutter: #15     Element.updateChild (package:flutter/src/widgets/framework.dart:2855:12)
flutter: #16     SingleChildRenderObjectElement.mount (package:flutter/src/widgets/framework.dart:4972:14)
flutter: #17     Element.inflateWidget (package:flutter/src/widgets/framework.dart:3052:14)
flutter: #18     Element.updateChild (package:flutter/src/widgets/framework.dart:2855:12)
flutter: #19     SingleChildRenderObjectElement.mount (package:flutter/src/widgets/framework.dart:4972:14)
flutter: #20     Element.inflateWidget (package:flutter/src/widgets/framework.dart:3052:14)
flutter: #21     Element.updateChild (package:flutter/src/widgets/framework.dart:2855:12)
flutter: #22     ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3846:16)
flutter: #23     Element.rebuild (package:flutter/src/widgets/framework.dart:3656:5)
flutter: #24     ComponentElement._firstBuild (package:flutter/src/widgets/framework.dart:3818:5)
flutter: #25     StatefulElement._firstBuild (package:flutter/src/widgets/framework.dart:3960:11)
flutter: #26     ComponentElement.mount (package:flutter/src/widgets/framework.dart:3813:5)
flutter: #27     Element.inflateWidget (package:flutter/src/widgets/framework.dart:3052:14)
flutter: #28     Element.updateChild (package:flutter/src/widgets/framework.dart:2855:12)
flutter: #29     SingleChildRenderObjectElement.mount (package:flutter/src/widgets/framework.dart:4972:14)
flutter: #30     Element.inflateWidget (package:flutter/src/widgets/framework.dart:3052:14)
flutter: #31     Element.updateChild (package:flutter/src/widgets/framework.dart:2855:12)
flutter: #32     ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3846:16)
flutter: #33     Element.rebuild (package:flutter/src/widgets/framework.dart:3656:5)
flutter: #34     ComponentElement._firstBuild (package:flutter/src/widgets/framework.dart:3818:5)
flutter: #35     ComponentElement.mount (package:flutter/src/widgets/framework.dart:3813:5)
flutter: #36     Element.inflateWidget (package:flutter/src/widgets/framework.dart:3052:14)
flutter: #37     Element.updateChild (package:flutter/src/widgets/framework.dart:2855:12)
flutter: #38     SingleChildRenderObjectElement.mount (package:flutter/src/widgets/framework.dart:4972:14)
flutter: #39     Element.inflateWidget (package:flutter/src/widgets/framework.dart:3052:14)
flutter: #40     Element.updateChild (package:flutter/src/widgets/framework.dart:2855:12)
flutter: #41     ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3846:16)
flutter: #42     Element.rebuild (package:flutter/src/widgets/framework.dart:3656:5)
flutter: #43     ComponentElement._firstBuild (package:flutter/src/widgets/framework.dart:3818:5)
flutter: #44     StatefulElement._firstBuild (package:flutter/src/widgets/framework.dart:3960:11)
flutter: #45     ComponentElement.mount (package:flutter/src/widgets/framework.dart:3813:5)
flutter: #46     Element.inflateWidget (package:flutter/src/widgets/framework.dart:3052:14)
flutter: #47     Element.updateChild (package:flutter/src/widgets/framework.dart:2855:12)
flutter: #48     ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3846:16)
flutter: #49     Element.rebuild (package:flutter/src/widgets/framework.dart:3656:5)
flutter: #50     ComponentElement._firstBuild (package:flutter/src/widgets/framework.dart:3818:5)
flutter: #51     ComponentElement.mount (package:flutter/src/widgets/framework.dart:3813:5)
flutter: #52     Element.inflateWidget (package:flutter/src/widgets/framework.dart:3052:14)
flutter: #53     Element.updateChild (package:flutter/src/widgets/framework.dart:2855:12)
flutter: #54     ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3846:16)
flutter: #55     Element.rebuild (package:flutter/src/widgets/framework.dart:3656:5)
flutter: #56     ComponentElement._firstBuild (package:flutter/src/widgets/framework.dart:3818:5)
flutter: #57     ComponentElement.mount (package:flutter/src/widgets/framework.dart:3813:5)
flutter: #58     Element.inflateWidget (package:flutter/src/widgets/framework.dart:3052:14)
flutter: #59     Element.updateChild (package:flutter/src/widgets/framework.dart:2855:12)
flutter: #60     ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3846:16)
flutter: #61     Element.rebuild (package:flutter/src/widgets/framework.dart:3656:5)
flutter: #62     ComponentElement._firstBuild (package:flutter/src/widgets/framework.dart:3818:5)
flutter: #63     ComponentElement.mount (package:flutter/src/widgets/framework.dart:3813:5)
flutter: #64     Element.inflateWidget (package:flutter/src/widgets/framework.dart:3052:14)
flutter: #65     Element.updateChild (package:flutter/src/widgets/framework.dart:2855:12)
flutter: #66     RenderObjectToWidgetElement._rebuild (package:flutter/src/widgets/binding.dart:939:16)
flutter: #67     RenderObjectToWidgetElement.mount (package:flutter/src/widgets/binding.dart:910:5)
flutter: #68     RenderObjectToWidgetAdapter.attachToRenderTree. (package:flutter/src/widgets/binding.dart:856:17)
flutter: #69     BuildOwner.buildScope (package:flutter/src/widgets/framework.dart:2294:19)
flutter: #70     RenderObjectToWidgetAdapter.attachToRenderTree (package:flutter/src/widgets/binding.dart:855:13)
flutter: #71     _WidgetsFlutterBinding&BindingBase&GestureBinding&ServicesBinding&SchedulerBinding&PaintingBinding&SemanticsBinding&RendererBinding&WidgetsBinding.attachRootWidget (package:flutter/src/widgets/binding.dart:736:7)
flutter: #72     runApp (package:flutter/src/widgets/binding.dart:786:7)
flutter: #73     main (package:flutter_shop/main.dart:9:3)
flutter: #74     _runMainZoned.. (dart:ui/hooks.dart:200:25)
flutter: #79     _runMainZoned. (dart:ui/hooks.dart:192:5)
flutter: #80     _startIsolate. (dart:isolate-patch/isolate_patch.dart:300:19)
flutter: #81     _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:171:12)
flutter: (elided 6 frames from class _AssertionError and package dart:async)
flutter: ════════════════════════════════════════════════════════════════════════════════════════════════════
import 'package:flutter/material.dart';
import 'provide.dart';
import 'package:provide/provide.dart';

void main() {
  var counter = Counter();
  var providres = Providers();
  providres..provide(Provider<Counter>.value(counter));
  runApp(Myapp());
}

class Myapp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return Container(
        child: ListView(
      children: <Widget>[
        RaisedButton(
          onPressed: () {
            Provide.value<Counter>(context).countAdd();
          },
          child: Icon(Icons.ac_unit),
        ),
        NewPage()
      ],
    ));
  }
}

class NewPage extends StatefulWidget {
  _NewPageState createState() => _NewPageState();
}

class _NewPageState extends State<NewPage> {
  @override
  Widget build(BuildContext context) {
    return Container(
      child: Provide<Counter>(
        builder: (context, child, counter) {
          return Container(
            child:  Text(
            '${counter.countInt}',
             style: Theme.of(context).textTheme.display1,
          )
          );
        },
      ),
    );
  }
}

provide:
import 'package:flutter/material.dart';

class Counter with ChangeNotifier{
  int countInt = 0;
  countAdd(){
    countInt++;
    notifyListeners();
  }
}

Hi @shenqidebaozi
are you still experiencing this issue with the latest version of Flutter?
If so can you please provide your flutter doctor -v?
Thank you

Without additional information, we are unfortunately not sure how to resolve this issue. We are therefore reluctantly going to close this bug for now. Please don't hesitate to comment on the bug if you have any more information for us; we will reopen it right away!
Thanks for your contribution.


Cassandra 15991

j11 CI
j8 CI

Rebased

CI j11
CI j8

Started but this patch is very large so will take a while to review.
General comments are:

avoid using assertTrue/assertFalse as they produce bad errors (unless you control the errors)
prefer Assertions.assertThat as it produces useful error messages
when validating that the usage hasn't changed, should use the string usage rather than a hash of it, as the hash is harder to know what failed and how to resolve.
WARNING: An illegal reflective access operation has occurred is a bug, so we should fix this rather than add exclusions to the test.
when working with List you already have a forEach method, so no need to create a stream

CASSANDRA-16082 got the +1 from John Meredith so that should merge soon iiuc and I'd be able to rebase + add your POC here soon. #collaborating

@dcapwell I moved the PR to use your with/out forking API as promised and rebased to pull in the latest ToolRunner new uses.


Allow non-deep merge

Right now you deep merge every object.
Output of the following representation could also be useful ("non deep merge"):
{  _Flow__id: [<-5-tuple->],
   _Flow__packets: [
       {  <- packet 1 -> },
       {  <- packet 2 -> },
       {  <- packet . -> },
       {  <- packet n -> }
   ]
}

the -a option does what you want


Add feature

Hi @Drarig29 . I want to add a link to match page for each seed. I check the bracket-viewer.js but i be carefull .
You are a best practise for that ?
Best Regard,

Do your changes as you would do generally. Please try to keep DOM related logic in the dom.ts file. So that the main.ts stays not cluttered.

When there are no warnings you can make a pull request and I will review it 😉

Do your changes as you would do generally. Please try to keep DOM related logic in the dom.ts file. So that the main.ts stays not cluttered.

When there are no warnings you can make a pull request and I will review it 😉

I've not /src  files in my Nuxt project. I've just bracket-viewer. js and bracket-viewer.css. No dom.ts or main.ts .  What i do bad ?

Oh okay I thought you wanted to make the changes on the library.
Well this feature does not exist yet. I speak about it in #38
I can add it for you.
When you say "I want to add a link to match page for each seed", what do you mean by "seed"?
Do you mean each node of the tree? (each match?)

I want say link for each match (participant1 vs participant2)...

Okay, let me do this.

I will add the possibility to set a onMatchClicked callback but the viewer does not come with anything to render a single match. You will have to design such a page manually.
I mean something like this page: https://www.toornament.com/en_US/tournaments/4153340356159348736/matches/4158520239729696775/

Okay, with commit https://github.com/Drarig29/brackets-viewer.js/commit/ae66b72b505cc273e78ca3d089d03f75c027f48b you can now do this:
bracketsViewer.onMatchClicked = match => console.log(match)

I think you'll have enough information with only match.
To test this, change your CDN url to point to the commit:
- src: "https://cdn.jsdelivr.net/npm/brackets-viewer/dist/brackets-viewer.min.js"
+ src<EMAIL_ADDRESS>
If this change suits you, it will be added in the next release of the library :wink:


typo: Exeption -> Exception

@nschonni  sorry this repo is being migrated to https://github.com/aspnet/AspNetDocs


fix: Attempt to analyze file paths in the input immediately

Attempts to immediately send file paths that are specified in the input to file_path_tx

/claim #485

Greptile Summary
This is an auto-generated summary
Hi! Looks like you've reached your API usage limit. You can increase it from your account settings page here: app.greptile.com/settings/usage

Hi @morgante is this the correct logic ?

@morgante maybe I am misunderstanding the problem statement but correct me if I'm wrong.
We should attempt to send the file if it is found in my_input.paths, otherwise we should perform the logging like before, correct ?


Add templated fields

Some fields could be templated to make them dynamic at the moment of triggering a dag

@sebastian-ziegler would you be open to also adding full_refresh? I've been working around it, but if this PR adds a bunch of additional template fields, it'd be nice to add this one too.