StyleCopTester doesn't take stylecop.json into account.

I noticed that the StyleCopTester command line program doesn't take stylecop.json into account.
For example, for this snippet, no violations are found in Visual Studio:
// <copyright file="Program.cs" company="FooBar">
// Copyright (c) FooBar. All rights reserved.
// </copyright>

With stylecop.json being:
{
  "$schema": "https://raw.githubusercontent.com/DotNetAnalyzers/StyleCopAnalyzers/master/StyleCop.Analyzers/StyleCop.Analyzers/Settings/stylecop.schema.json",
  "settings": {
    "documentationRules": {
      "companyName": "FooBar"
    }
  }
}

No errors in VS:

Actual behaviour
However, when I run StyleCopTester, I get:
Loaded solution in 3324ms
Found 4 diagnostics in 2066ms
  CS8019: 2 instances
  SA1636: 2 instances

One of the SA1636 violations is (retrieved using StyleCopTester's /log flag):
some\path\Program.cs(1,4): warning SA1636: The file header copyright text should match the copyright text from the settings.

(The other is in AssemblyInfo.cs.)
Expected behaviour
It would be nice if VS and StyleCopTester produced the same diagnostics:
Loaded solution in 3308ms
Found 2 diagnostics in 2063ms
  CS8019: 2 instances

I actually found out how to fix this issue, so I will be creating a PR shortly.


Changed commands field to a dictionary, our problems are over.

Made changes that prevent the module from taking a few seconds to execute a command when searching for it.
Resolves #43

That build failure was not me.


pkg -> prototype -> component hierarchy is unnecessary complicated

Current way of pulling packages, then specifying components by using prototypes from a package is confusing and I can't see what it buys comparing to a more direct approach where app.yaml specifies components directly.
Something along the lines would achieve same result in a single step AND would allow packages to be updated per component, which is not possible right now:
apiVersion: 0.0.1
kind: ksonnet.io/app
components:
  redis-app:
    gitVersion:  ....
    name: redis
    prototype: redis-stateless
    registry: incubator
registries:
  incubator:
    ...
    uri: github.com/ksonnet/parts/tree/master/incubator

this would create following structure:
components/
  redis-app.jsonnet
  redis-app/
    redis-stateless.jsonnet
    redis.libsonnet (and rest of the files from incubator/redis/)

where redis-app.jsonnet is:
import './redis-app/redis-stateless.jsonnet'

and redis-app/redis-stateless.jsonnet is rendered redis-stateless prototype as it is being rendered now (I believe comments are removed and local params = ... added).
This also solves https://github.com/ksonnet/ksonnet/issues/262 , because prototypes can now reference packages they are part of using relative paths:
local redis = import './redis.libsonnet';

closing due to age. Please open if you want to discuss more.


Fix documenting an example.

It was missing the dependency on the local library.
Fixes #7014.

r? @alexcrichton
(rust_highfive has picked a reviewer for you, use r? to override)

@bors: r+

:pushpin: Commit a59ea45c1a5905699118efaacf001156cf0c9eb3 has been approved by alexcrichton

:hourglass: Testing commit a59ea45c1a5905699118efaacf001156cf0c9eb3 with merge 28adaba748dd492b1730dade700f1ec8140e9084...

:sunny: Test successful - checks-travis, status-appveyor
Approved by: alexcrichton
Pushing 28adaba748dd492b1730dade700f1ec8140e9084 to master...


[DM-32998] Improve robustness

Remove stray assert that was causing failures in data-int and NCSA int
Always delete the Pod and ConfigMap when creating new ones, cleaning up after stranded objects
Ignore 404 errors when deleting a Pod or ConfigMap, since that means it's already gone
Correctly do nothing if the orders are empty for a given order type

Tested on data-dev and this version seems to work properly.


Feature: integration with react native 🌉

Description
Special thanks to:
@nicholasess for the initial idea of using react-native-web
@arojunior for the Proof of concept(#213)
@lucasferreira for the PropsTable fix

Nice!!!

You're just awesome.

Hey
I probably come late to the party but I maintain this plugin:
https://github.com/slorber/gatsby-plugin-react-native-web
If you use it instead your docz plugin you'll also get Expo SDK support out of the box + transpile all major RN designsystem libs. I made a test and was able to run docz with Expo  comp: https://goofy-carson-fc4758.netlify.com/src-components-button
Also something worth exploring is: could you generate an Expo app from your docz MDX files? Take a look at this experiment: https://twitter.com/sebastienlorber/status/1224329774589468672


Install issues -- wrong eckit version, maybe?

Hi all,
I'm part of a team at NOAA who are hoping to translate a neural network (trained in TensorFlow) to Fortran code, so that it can be used for inference inside an NWP model.  Your Infero library looks promising, so we're starting off with that.  However, I've had some problems in getting the Infero library installed, which appear to be bugs in the C++ code.
Specifically, when I run the script 2_install_infero.sh, I get errors about variable types.  It seems that the constructor for TensorFloat (from eckit::linalg) expects the first input argument to be a float, but there's code in Infero that tries to create a new TensorFloat object with the first input arg being a const float.  I've attached the screenshot showing the error messages.
I fixed this problem (by copying each relevant const float to just a float -- at 4 places in infero/src/infero/api/infero-api.cc), but then more errors popped up, as you can see in the second set of screenshots (three of them, because the stack trace was long).
Overall, it seems like my version of Infero is incompatible with my version of eckit.  I have version 1.19.3 of eckit and the newest version of Infero (cloned on Apr 3 2022 from Github -- I don't see a version number associated).  Perhaps I could fix these problems by downgrading eckit to a previous version?
I apologize if this post is missing any crucial details or using weird jargon.  I'm not a C++ programmer, and I don't usually build complicated libraries.  However, this is mission-critical for our project (embedding a U-net that estimates radiative transfer into an NWP model), so any help would be greatly appreciated.
Best,
Ryan

Hi @thunderhoser
Thanks for reporting this.
As you also suggested,  indeed this is most likely an incompatibility with the eckit version you have.
eckit >= 1.19.0 had some changes to the Linear Algebra API, whereas Infero hasn't been updated yet.
Meanwhile can you please check with say eckit 1.18.9?

@antouk can you please have a look at this issue and if that is the case, fix infero to support the latest eckit 1.19 Linear Algebra API?

We should also update the CMakeLists.txt minimal version of eckit to:
ecbuild_find_package( NAME eckit  VERSION  1.19 REQUIRED )

Hi @thunderhoser Thanks for reporting this. As you also suggested, indeed this is most likely an incompatibility with the eckit version you have. eckit >= 1.19.0 had some changes to the Linear Algebra API, whereas Infero hasn't been updated yet.
Meanwhile can you please check with say eckit 1.18.9?

Thanks, @tlmquintino!  I'll try downgrading to 1.18.9 right away and let you know what I find.

@tlmquintino, while I have your attention, I hope you don't mind me asking a question that's off-topic.  Does the Infero library work for the U-net++ or standard U-net architectures?  Thanks!

Hi @thunderhoser Thanks for reporting this. As you also suggested, indeed this is most likely an incompatibility with the eckit version you have. eckit >= 1.19.0 had some changes to the Linear Algebra API, whereas Infero hasn't been updated yet.
Meanwhile can you please check with say eckit 1.18.9?

Thanks, @tlmquintino! I'll try downgrading to 1.18.9 right away and let you know what I find.

It works with eckit 1.18.9!  I got through all three scripts (1_install_deps.sh, 2_install_infero.sh, 3_run_tests.sh), with all tests passing.  I didn't bother with TensorRT, but I did everything else (TFLite, TensorFlow C, ONNX).  Thank you!

@tlmquintino, while I have your attention, I hope you don't mind me asking a question that's off-topic. Does the Infero library work for the U-net++ or standard U-net architectures? Thanks!

Actually Infero itself does not know about architectures -- it's the underlying backends that deal with the model and as far as I know the models we have tested support U-Net. Maybe @antouk can confirm?

@antouk although the issue with @thunderhoser is fixed, I will keep this issue open until we upgrade Infero to support latest eckit.

@antouk although the issue with @thunderhoser is fixed, I will keep this issue open until we upgrade Infero to support latest eckit.

Hi, sure no problem I will upgrade it shortly (along with other changes that are lined up)

@tlmquintino, while I have your attention, I hope you don't mind me asking a question that's off-topic. Does the Infero library work for the U-net++ or standard U-net architectures? Thanks!

Actually Infero itself does not know about architectures -- it's the underlying backends that deal with the model and as far as I know the models we have tested support U-Net. Maybe @antouk can confirm?

Re U-Net model, we have tried Infero with an implementation of a U-net model and as far as I remember all the operations performed by that model were supported, so there is a good chance that it will work also for your case, but needs to be tested.


Replace Collection Intro Modal with a Page

Removed Collection Introduction Modal.
Create Collection Introduction Page - (added route,  controller action, view, and React components).
Modified and renamed React component CollectionDescriptionModal to CollectionIntroLink.
Replaced link to modal with link to Introduction page.
Added some basic css so it doesn't look too bad.

:thumbsup:


feat: Support git in package source

This will add support for git property (as well as related branch, tag and rev) within the binary package definition.
Related to: https://github.com/dustinblackman/cargo-run-bin/issues/9.

@dustinblackman, thank you for such a nice Cargo plugin. It is so helpful. I made this PR in order to make it a little bit more useful for people (like myself) that have dependencies through Git. Could you have a look into this PR, please?

@eduardomourar Sorry bud, I totally missed the notification on this one when you put it up.
PR looks great, awesome job! Thanks a lot of contributing! :D


Validates that given tile coordinates are within valid bounds.

Addresses #183

:+1: looks good to me.

Why do we only throw an error for the tile parameters here?
Every other service (and the tile function itself) simply asserts on isValid, e.g. see:
https://github.com/Project-OSRM/node-osrm/blob/fix/183/src/node_osrm.cpp#L938
Can we make the behavior consistent? That is removing the assertion (which currently will crash Node in debug builds or quietly work / crash libosrm in release builds --- neither is an option) and throwing Javascript errors instead?

I think this is fine as we usually don't use IsValid because it doesn't give us diagnostics of what made it invalid. In this case there is only one source of errors once you established its integers.


feat(contrib/ec2): Set ELB timeout to 1200s

Amazon added support for setting the ELB timeout directly from
CloudFormation on the 24th of December.
This commit removes the documentation which tells the user to change it
manually, as that is no longer needed, and sets it to 1200s.
See: http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-ec2-elb-connectionsettings.html

Thanks for the contribution! Please ensure your commits follow our style guide. This code will be tested once a Deis maintainer reviews it.

I'm so happy they added support for this. Thank you!!
Code LGTM.

Outstanding, this will remove a fiddly manual step that was necessary for EC2. Code LGTM, and thanks again @Blystad.

I tested this manually just to ensure the ELB timeout actually got set to 1200:

LGTM.

Thanks for testing @mboersma!! Now to ship v1.2.0 so we can merge this...


I can't seem to get VMs to attach to an instance_group

I created a manifest using instance_group: nginx in the subnet cloud_properties section of my cloud config, but I don't see new instances being attached to that group.  Are you sure that's wired up correctly internally?
Additionally - it seems weird that ELBs can be attached using vm_types (or vm_extensions, which is even better), but on GCP I have to attach a load balancer to every VM in the network.  It's very common that I'd declare only 1 or 2 large networks, and I don't want all those VMs to have load balancers.  Could we make google's instance_group a cloud_property to a BOSH job (now confusingly called BOSH instance groups)?
Here's what BOSH printed out when I did the deploy, so it clearly understood the change:
> bosh deploy --recreate

Detecting deployment changes
----------------------------
networks:
- name: private
  subnets:
  - range: <IP_ADDRESS>/20
    cloud_properties:
      instance_group: nginx

Then it recreated the VM:
  Started updating job web_server > web_server/0 (18857c48-665f-4600-bd00-c9e6909d6c87) (canary). Done (00:04:51)

But that new web server isn't part of an instance group.  I used CPI version 21, director 257.3, and stemcell 3262.2.
Here's the full network section of my cloud_config:
networks:
- name: private
  type: manual
  subnets:
  - dns:
    - <IP_ADDRESS>
    range: <IP_ADDRESS>/20
    gateway: <IP_ADDRESS>
    azs:
    - us-central1-a
    cloud_properties:
      network_name: cf
      instance_group: nginx
      tags:
      - cf-bosh
    reserved:
    - <IP_ADDRESS>
    - <IP_ADDRESS>-<IP_ADDRESS>
    static:
    - <IP_ADDRESS>

Let me know if I just did something wrong.  Thanks!

I was looking at your default cloud_config.yml in docs, which I now see also includes target_pool and backend_service.  I'll try again soon with backend_service used in vm_extensions.

backend_service worked, my bad!  We might want to remove the docs that still reference instance_group inside cloud_properties.

@dsboulder, sorry for the slow response time here - just got back from vacation. I'll get the docs updated shortly!


BardFlight def airlines(self): TypeError: 'type' object is not subscriptable

💚💜 Thank you for interest. ❤💛
Please make sure to check for more efficient package management. Please prioritize checking existing issues first. I will repay with higher-quality code.
To Reproduce
I get the stacktrace when running flask run and from bardapi import Bard
once I delete: from bardapi import Bard
and comment out all bard related stuff my project works fine. so it's only Bard.
----------Please delete the content above this line, including this line.-------------
Describe the bug
A clear and concise description of what the bug is.
Keep getting the following stacktrace when I ran flask run. I'm using venv and have API key and cookies set up.
It works on another mac but not on mine but no idea how to figure out what the issue is?
Traceback (most recent call last):
File "/Users/benitosanchez/Documents/GitHub/promise/.venv/bin/flask", line 8, in
sys.exit(main())
File "/Users/benitosanchez/Documents/GitHub/promise/.venv/lib/python3.8/site-packages/flask/cli.py", line 1064, in main
cli.main()
File "/Users/benitosanchez/Documents/GitHub/promise/.venv/lib/python3.8/site-packages/click/core.py", line 1078, in main
rv = self.invoke(ctx)
File "/Users/benitosanchez/Documents/GitHub/promise/.venv/lib/python3.8/site-packages/click/core.py", line 1688, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "/Users/benitosanchez/Documents/GitHub/promise/.venv/lib/python3.8/site-packages/click/core.py", line 1434, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "/Users/benitosanchez/Documents/GitHub/promise/.venv/lib/python3.8/site-packages/click/core.py", line 783, in invoke
return __callback(*args, **kwargs)
File "/Users/benitosanchez/Documents/GitHub/promise/.venv/lib/python3.8/site-packages/click/decorators.py", line 92, in new_func
return ctx.invoke(f, obj, *args, **kwargs)
File "/Users/benitosanchez/Documents/GitHub/promise/.venv/lib/python3.8/site-packages/click/core.py", line 783, in invoke
return __callback(*args, **kwargs)
File "/Users/benitosanchez/Documents/GitHub/promise/.venv/lib/python3.8/site-packages/flask/cli.py", line 912, in run_command
raise e from None
File "/Users/benitosanchez/Documents/GitHub/promise/.venv/lib/python3.8/site-packages/flask/cli.py", line 898, in run_command
app = info.load_app()
File "/Users/benitosanchez/Documents/GitHub/promise/.venv/lib/python3.8/site-packages/flask/cli.py", line 313, in load_app
app = locate_app(import_name, None, raise_if_not_found=False)
File "/Users/benitosanchez/Documents/GitHub/promise/.venv/lib/python3.8/site-packages/flask/cli.py", line 219, in locate_app
import(module_name)
File "/Users/benitosanchez/Documents/GitHub/promise/app.py", line 6, in
from bardapi import Bard
File "/Users/benitosanchez/Documents/GitHub/promise/.venv/lib/python3.8/site-packages/bardapi/init.py", line 4, in
from bardapi.core import Bard
File "/Users/benitosanchez/Documents/GitHub/promise/.venv/lib/python3.8/site-packages/bardapi/core.py", line 28, in
from bardapi.models.result import BardResult
File "/Users/benitosanchez/Documents/GitHub/promise/.venv/lib/python3.8/site-packages/bardapi/models/result.py", line 3, in
from bardapi.models.draft import BardDraft
File "/Users/benitosanchez/Documents/GitHub/promise/.venv/lib/python3.8/site-packages/bardapi/models/draft.py", line 5, in
from bardapi.models.tools.flight import BardFlightContent
File "/Users/benitosanchez/Documents/GitHub/promise/.venv/lib/python3.8/site-packages/bardapi/models/tools/flight.py", line 4, in
class BardFlight:
File "/Users/benitosanchez/Documents/GitHub/promise/.venv/lib/python3.8/site-packages/bardapi/models/tools/flight.py", line 17, in BardFlight
def airlines(self) -> list[str]:
TypeError: 'type' object is not subscriptable
Version
OS:
Python:
Bard API:
Using proxy:
Legion:
Code
code line

Error
error message

Same issue, in my case it failed with AWS Beanstalk here is the error:
Oct 23 18:30:39 ip-172-31-13-230 web: Traceback (most recent call last):
Oct 23 18:30:39 ip-172-31-13-230 web: File "/var/app/venv/staging-LQM1lest/lib64/python3.8/site-packages/gunicorn/arbiter.py", line 589, in spawn_worker
Oct 23 18:30:39 ip-172-31-13-230 web: worker.init_process()
Oct 23 18:30:39 ip-172-31-13-230 web: File "/var/app/venv/staging-LQM1lest/lib64/python3.8/site-packages/gunicorn/workers/gthread.py", line 92, in init_process
Oct 23 18:30:39 ip-172-31-13-230 web: super().init_process()
Oct 23 18:30:39 ip-172-31-13-230 web: File "/var/app/venv/staging-LQM1lest/lib64/python3.8/site-packages/gunicorn/workers/base.py", line 134, in init_process
Oct 23 18:30:39 ip-172-31-13-230 web: self.load_wsgi()
Oct 23 18:30:39 ip-172-31-13-230 web: File "/var/app/venv/staging-LQM1lest/lib64/python3.8/site-packages/gunicorn/workers/base.py", line 146, in load_wsgi
Oct 23 18:30:39 ip-172-31-13-230 web: self.wsgi = self.app.wsgi()
Oct 23 18:30:39 ip-172-31-13-230 web: File "/var/app/venv/staging-LQM1lest/lib64/python3.8/site-packages/gunicorn/app/base.py", line 67, in wsgi
Oct 23 18:30:39 ip-172-31-13-230 web: self.callable = self.load()
Oct 23 18:30:39 ip-172-31-13-230 web: File "/var/app/venv/staging-LQM1lest/lib64/python3.8/site-packages/gunicorn/app/wsgiapp.py", line 58, in load
Oct 23 18:30:39 ip-172-31-13-230 web: return self.load_wsgiapp()
Oct 23 18:30:39 ip-172-31-13-230 web: File "/var/app/venv/staging-LQM1lest/lib64/python3.8/site-packages/gunicorn/app/wsgiapp.py", line 48, in load_wsgiapp
Oct 23 18:30:39 ip-172-31-13-230 web: return util.import_app(self.app_uri)
Oct 23 18:30:39 ip-172-31-13-230 web: File "/var/app/venv/staging-LQM1lest/lib64/python3.8/site-packages/gunicorn/util.py", line 359, in import_app
Oct 23 18:30:39 ip-172-31-13-230 web: mod = importlib.import_module(module)
Oct 23 18:30:39 ip-172-31-13-230 web: File "/usr/lib64/python3.8/importlib/init.py", line 127, in import_module
Oct 23 18:30:39 ip-172-31-13-230 web: return _bootstrap._gcd_import(name[level:], package, level)
Oct 23 18:30:39 ip-172-31-13-230 web: File "", line 1014, in _gcd_import
Oct 23 18:30:39 ip-172-31-13-230 web: File "", line 991, in _find_and_load
Oct 23 18:30:39 ip-172-31-13-230 web: File "", line 975, in _find_and_load_unlocked
Oct 23 18:30:39 ip-172-31-13-230 web: File "", line 671, in _load_unlocked
Oct 23 18:30:39 ip-172-31-13-230 web: File "", line 843, in exec_module
Oct 23 18:30:39 ip-172-31-13-230 web: File "", line 219, in _call_with_frames_removed
Oct 23 18:30:39 ip-172-31-13-230 web: File "/var/app/current/application.py", line 3, in
Oct 23 18:30:39 ip-172-31-13-230 web: from bardapi import Bard
Oct 23 18:30:39 ip-172-31-13-230 web: File "/var/app/venv/staging-LQM1lest/lib64/python3.8/site-packages/bardapi/init.py", line 4, in
Oct 23 18:30:39 ip-172-31-13-230 web: from bardapi.core import Bard
Oct 23 18:30:39 ip-172-31-13-230 web: File "/var/app/venv/staging-LQM1lest/lib64/python3.8/site-packages/bardapi/core.py", line 29, in
Oct 23 18:30:39 ip-172-31-13-230 web: from bardapi.models.result import BardResult
Oct 23 18:30:39 ip-172-31-13-230 web: File "/var/app/venv/staging-LQM1lest/lib64/python3.8/site-packages/bardapi/models/result.py", line 3, in
Oct 23 18:30:39 ip-172-31-13-230 web: from bardapi.models.draft import BardDraft
Oct 23 18:30:39 ip-172-31-13-230 web: File "/var/app/venv/staging-LQM1lest/lib64/python3.8/site-packages/bardapi/models/draft.py", line 5, in
Oct 23 18:30:39 ip-172-31-13-230 web: from bardapi.models.tools.flight import BardFlightContent
Oct 23 18:30:39 ip-172-31-13-230 web: File "/var/app/venv/staging-LQM1lest/lib64/python3.8/site-packages/bardapi/models/tools/flight.py", line 4, in
Oct 23 18:30:39 ip-172-31-13-230 web: class BardFlight:
Oct 23 18:30:39 ip-172-31-13-230 web: File "/var/app/venv/staging-LQM1lest/lib64/python3.8/site-packages/bardapi/models/tools/flight.py", line 17, in BardFlight
Oct 23 18:30:39 ip-172-31-13-230 web: def airlines(self) -> list[str]:
Oct 23 18:30:39 ip-172-31-13-230 web: TypeError: 'type' object is not subscriptable

It will be updated to the official version after addressing errors in some type hints and conducting QA on the overall structure. Until then, we appreciate your guidance on any errors encountered after installing the GitHub version.

same problem but my code is very more simple

import os
os.environ["_BARD_API_KEY"] = "my_api_key"
print(Bard.get_answer(" 4 + 4"))

// error:

Traceback (most recent call last):
  File "teste.py", line 1, in <module>
    from bardapi import Bard
  File "/home/matheus_giordani/.local/lib/python3.8/site-packages/bardapi/__init__.py", line 4, in <module>
    from bardapi.core import Bard
  File "/home/matheus_giordani/.local/lib/python3.8/site-packages/bardapi/core.py", line 28, in <module>
    from bardapi.models.result import BardResult
  File "/home/matheus_giordani/.local/lib/python3.8/site-packages/bardapi/models/result.py", line 3, in <module>
    from bardapi.models.draft import BardDraft
  File "/home/matheus_giordani/.local/lib/python3.8/site-packages/bardapi/models/draft.py", line 5, in <module>
    from bardapi.models.tools.flight import BardFlightContent
  File "/home/matheus_giordani/.local/lib/python3.8/site-packages/bardapi/models/tools/flight.py", line 4, in <module>
    class BardFlight:
  File "/home/matheus_giordani/.local/lib/python3.8/site-packages/bardapi/models/tools/flight.py", line 17, in BardFlight
    def airlines(self) -> list[str]:
TypeError: 'type' object is not subscriptable

23-10-28, switched to using the typing module for providing type hints by importing it.

The notation like list[str] is related to type hints available in Python 3.9 and later. However, according to the error message, it appears that this notation is not supported.


"Add a comment" box in article view

Add a sticky textbox for adding a comment to the bottom of the issue view

This should also have mechanisms for quickly changing ticket status and assignee.


[MRG] Reduce repeated code in BinderSpawner

Closes #1015
There should be no change in behaviour for the default BinderSpawner or for the BinderSpawner described in https://binderhub.readthedocs.io/en/latest/authentication.html

I left a few comments but nothing major. Let's see what others think as well.

Thanks for reviewing, I think that's all requested changes made.

This pull request has been mentioned on Jupyter Community Forum. There might be relevant details there:
https://discourse.jupyter.org/t/a-persistent-binderhub-deployment/2865/7

This pull request has been mentioned on Jupyter Community Forum. There might be relevant details there:
https://discourse.jupyter.org/t/a-persistent-binderhub-deployment/2865/9


WIP: Dynamic configuration

What is this PR about
Extract hard-coded cities and roles data to config file. Closes #25.
Notes
The tests are not updated yet.
Config contains list of cities and careers with roles for each career. The file is in YAML format for readability. Convertion to JSON happens at compile time.  Data from this file is exposed in the browser as SalaryCalculator.defaults and can be passed to init as optional second argument. Alternative config can be provided the same way.
Compared to previous version there are following user facing differences:

No role or city is initially selected
The salary display and the breakdown accordion are disabled until both fields are selected. IMO this is a significant improvement. If you prefer, we can make the app select the first item from each list, but we still have to handle a case of empty list.

The URL query parameters take full name of a role or a city
e.g. San Francisco instead of SanFrancisco or Customer Support Associate instead of CustomerSupportAssociate.

The careers and roles are ordered differently
We can change the order simply by reshuffling the YAML file.

Generally looks good, but all user-facing changes have to be fixed. Nothing should change for the user when rewriting the low parts of the system. User changes should come in separate PRs, so they can be discussed and evaluated separately.


components: 'native-image' removed

This PR will remove components: 'native-image', which is no more required in Java 21

Should this fix the release?

Should this fix the release?

I am testing if these warnings are the reasons for the release skip
https://github.com/munishchouhan/wave-cli/actions/runs/7265780430

These warnings are not the reason of release skip
Now I am testing with the new changes we made after the last release
https://github.com/munishchouhan/wave-cli/actions/runs/7266051892

@pditommaso please review


PechaKucha

[ ] Walking around campus
[ ] Studying
[ ] Things I ate

will this come out to 20 images?


Consider adding some Github topics

Consider adding some Github topics: https://github.com/blog/2309-introducing-topics

Added. Missing some?

Perfect! 👍


Don't Merge! PR real time test for target branch full build

Docs Build status updates of commit 6e2d8b3:
:clock10: Full build: the average full build time is 6 min(s) 2 sec(s), this is based on the last 532 build(s) for this repository.

Docs Build status updates of commit 6e2d8b3:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details
Dependent Files

docs-ref-conceptual/testing.md
:white_check_mark:Succeeded
View (azure-cli-latest) View (azure-cli-2017-03-09-profile) View (azure-cli-2018-03-01-hybrid)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


add comment support #529

Fixes issue #529

@ilimei thank you for your contribution - this looks good. Could you do one thing? Please use 2 spaces for indents  - I know it's pedantic but it helps with consistency

@guyonroche sorry for that, i will do it later ^_^

@ilimei after some futher testing, I've started working on some changes...

changing the Cell property name from "comment" to "note" -> this reflects the change in Excel from comments to "Threaded Comments". The old legacy comments are called Notes
It turns out that each note (or comment) requires the addition of a vml drawing for each cell note. Sometimes the design decisions of MS Excel developers astounds me!

Changes are in and published to 1.12.0
@ilimei thanks for your contribution

Hello.

Comment's names in the interface file *.d.ts (and in @types/exceljs module) called 'comment' (not 'note') as before.
Comments are not popupable. They are displayed constantly. But Excel (and Libre Calc) CAN do them popup on cell hover.

Can't you check it please?


v10 Compatability?

I didn't see anywhere mentioned if this is v10 compatible. Is that in the plans?

https://github.com/kandashi/Active-Auras/issues/239#issuecomment-1235379875
Not soon but planned for "eventually"

If you are looking for a v10 version, the open PR's to support it have been built into the following package till it is merged:

Active Auras: https://github.com/MrPrimate/Active-Auras/releases/download/v0.4.22/module.json
Active Token Effects/Lighting: https://github.com/MrPrimate/Active-Token-Lighting/releases/download/v0.4.02/module.json