Review passlib/pwdlib switch and update to fastapi-users v13

Trough fastapi-users, we rely on passlib for password hashing. Despite being a mainstream library, this went unmantained (see e.g. https://github.com/fractal-analytics-platform/fractal-server/issues/1041 and https://foss.heptapod.net/python-libs/passlib/-/issues/190). As a result, we cannot bump versions of fastapi-users (which is not an urgent issue) nor bcrypt (which maybe more of an issue).
The fastapi-users mantainer created a https://frankie567.github.io/pwdlib/, a lightweight passlib replacement. In principle the update is safe, since it goes through hash update:

Password are now hashed using the Argon2 algorithm by default. Passwords created with the previous default algorithm (bcrypt) will still be verified correctly and upgraded to Argon2 when the user logs in.
(https://github.com/fastapi-users/fastapi-users/releases/tag/v13.0.0)

We should double-check this on a test instance of fractal-server, where we first create users with fastapi-users v12, then update to v13 and check how it works.

Switch to main, install, set database and run the app
git switch main

    Switched to branch 'main'
    Your branch is up to date with 'origin/main'.

git log -1 | grep commit

    commit 23eeb72e33c75fd2020db4803b6b584fff0aaf4d

poetry install -E  postgres

    Installing dependencies from lock file

    Package operations: 0 installs, 3 updates, 0 removals

        - Downgrading bcrypt (4.1.2 -> 4.0.1)
        - Downgrading python-multipart (0.0.9 -> 0.0.7)
        - Downgrading fastapi-users (13.0.0 -> 12.1.3)

    Installing the current project: fractal-server (2.3.10)

poetry show pwdlib

    Package pwdlib not found

poetry run fractalctl set-db
poetry run fractalctl start

On psql:
select * from user_oauth;

 id |      email       |                       hashed_password                        | is_active | is_superuser | is_verified | slurm_user | cache_dir | username | slurm_accounts
----+------------------+--------------------------------------------------------------+-----------+--------------+-------------+------------+-----------+----------+----------------
  1 |<EMAIL_ADDRESS>| $2b$12$tcLSYU09v86NrJWeTdKHtu1DfQKC.7k73kJple.ugxe7/kLXYwmTu | t         | t            | t           |            |           | admin    | []
(1 row)

Run fractal-web and register a new user<EMAIL_ADDRESS>with password abcde:
2024-08-28 15:10:55,662 - uvicorn.access - INFO - <IP_ADDRESS>:52522 - "POST /auth/register/ HTTP/1.1" 201
2024-08-28 15:10:55,672 - uvicorn.access - INFO - <IP_ADDRESS>:52522 - "PATCH /auth/users/2/ HTTP/1.1" 200
2024-08-28 15:10:55,678 - uvicorn.access - INFO - <IP_ADDRESS>:52522 - "GET /api/alive/ HTTP/1.1" 200
2024-08-28 15:10:55,685 - uvicorn.access - INFO - <IP_ADDRESS>:52524 - "GET /auth/current-user/ HTTP/1.1" 200
2024-08-28 15:10:55,691 - uvicorn.access - INFO - <IP_ADDRESS>:52522 - "GET /auth/users/ HTTP/1.1" 200

select * from user_oauth;

 id |      email       |                       hashed_password                        | is_active | is_superuser | is_verified | slurm_user |      cache_dir      | username | slurm_accounts
----+------------------+--------------------------------------------------------------+-----------+--------------+-------------+------------+---------------------+----------+----------------
  1 |<EMAIL_ADDRESS>| $2b$12$tcLSYU09v86NrJWeTdKHtu1DfQKC.7k73kJple.ugxe7/kLXYwmTu | t         | t            | t           |            |                     | admin    | []
  2 |<EMAIL_ADDRESS>| $2b$12$0OG81WsaPevJh5ySVrxBve/eyz6GECJjplKofJbumQTNcfEYeTd4q | t         | f            | t           |            | /Users/yuri/Desktop |          | []
(2 rows)

I can (of course) login with both accounts.

Now switch to 1708-review-passlibpwdlib-switch-and-update-to-fastapi-users-v13, install and run the app (the db is already set)
git switch 1708-review-passlibpwdlib-switch-and-update-to-fastapi-users-v13

    Switched to branch '1708-review-passlibpwdlib-switch-and-update-to-fastapi-users-v13'
    Your branch is up to date with 'origin/1708-review-passlibpwdlib-switch-and-update-to-fastapi-users-v13'.

git log -1 | grep commit

    commit f7407c5caad29cf5ec9849c44f422b8eb9918203

poetry install -E postgres

    Installing dependencies from lock file

    Package operations: 0 installs, 3 updates, 0 removals

        - Updating bcrypt (4.0.1 -> 4.1.2)
        - Updating python-multipart (0.0.7 -> 0.0.9)
        - Updating fastapi-users (12.1.3 -> 13.0.0)

    Installing the current project: fractal-server (2.3.10)

poetry show pwdlib

    name         : pwdlib
    version      : 0.2.0
    description  : Modern password hashing for Python

    dependencies
        - argon2-cffi 23.1.0
        - bcrypt 4.1.2

    required by
        - fastapi-users 0.2.0

poetry run fractalctl start

I can still login with both accounts.

Thanks a lot!
The example above (and https://github.com/fractal-analytics-platform/fractal-server/pull/1717) proves that this is a perfectly viable approach to updating.
With @ychiucco we decided to wait a bit longer before committing to a new (critical) dependency, to track its progress and its integration with fastapi-users (e.g. right now the latest fastapi-users does not use the very latest pwdlib - which is anyway a very minor issue).
We should look back at this issue e.g. in one or two months.


[BUG][Spark] Fix flaky test suite org.apache.spark.sql.delta.DeltaSourceDeletionVectorsSuite

Bug
Which Delta project/connector is this regarding?

[x] Spark
[ ] Standalone
[ ] Flink
[ ] Kernel
[ ] Other (fill in here)

Describe the problem
Failed test subsequent DML commands are processed correctly in a batch - INSERT->UPDATE - List((ignoreChanges,true)) *** FAILED ***
CI runs: https://github.com/delta-io/delta/actions/runs/5835475304/job/15827113787, https://github.com/delta-io/delta/actions/runs/5868780845/job/15912353282?pr=1950
Willingness to contribute
The Delta Lake Community encourages bug fix contributions. Would you or another member of your organization be willing to contribute a fix for this bug to the Delta Lake code base?

[ ] Yes. I can contribute a fix for this bug independently.
[ ] Yes. I would be willing to contribute a fix for this bug with guidance from the Delta Lake community.
[x] No. I cannot contribute a bug fix at this time.

@larsk-db Could you please a take look at this test?

Here's another one: https://github.com/delta-io/delta/actions/runs/5900171391/job/16003921031?pr=1987


[Docs]: [Rehaul]- Docker

@harshilp24 - Could you please add estimates to the ticket?

PR is waiting on review, available here

Will make test/video showing steps ASAP

(In final reviews)

Ready to merge once Nikhila is back and able to mark her changes as resolved.

@spark-c - Good to go. Approved the PR.


Add example of a RESTful API.

Example of a REST API that we might use in query. A most basic implementation, not necessarily representative of the actual product, to start the discussion.

 Begin design plan for REST API

Superseded by PR-https://github.com/dirac-institute/trailblazer/pull/46


Bday fixes after23rd

Updating some small areas that people commented on.
Incorporating changes from various contributors.
Signed-off-by: Mary Anthony<EMAIL_ADDRESS>

Looks like we would not be able to merge this PR because of merge conflicts. Please fix them and force push to your branch.

@tiborvass I did rebase I just cherry picked too far back.  I'll fix it.


Do I need to keep the authorization page open all the time？

Do I need to keep the authorization page open all the time？sorry,I don't know much about it

@Jinxhao18 Good question! and YES, you have to keep the web page open. Because VSCode didn't ship with ffmpeg module (See: https://github.com/microsoft/vscode/issues/66050#issuecomment-451548339), I guess it is because Microsoft want to reduce the size of VSCode. Anyway, I have to use the user's browser to play the audios. But as far as I know, there still some ways to let extension play the audio directly, but it will increase the size of the extension.

@Jinxhao18 Good question! and YES, you have to keep the web page open. Because VSCode didn't ship with ffmpeg module (See: microsoft/vscode#66050 (comment)), I guess it is because Microsoft want to reduce the size of VSCode. Anyway, I have to use the user's browser to play the audios. But as far as I know, there still some ways to let extension play the audio directly, but it will increase the size of the extension.

thanks very much for your answer


remove campaign filter from other than approve pages in reqmgr2

Or fix the filter.

@vkuznet, Valentin, could you take a look at this?
i.e. Campaign filter doesn't work.
https://cmsweb.cern.ch/reqmgr2/requests?status=running-open
on approve page it works.
https://cmsweb.cern.ch/reqmgr2/approve

Seangchan, try this PR: https://github.com/dmwm/WMCore/pull/7778
I think I missed to show campaign on a page and it cause the behavior.
It would be nice if you'll add it to your VM and add few requests with
different campaigns to test it.
On  0, ticoann<EMAIL_ADDRESS>wrote:

@vkuznet, Valentin, could you take a look at this?
i.e. Campaign filter doesn't work.
https://cmsweb.cern.ch/reqmgr2/requests?status=running-open
on approve page it works.
https://cmsweb.cern.ch/reqmgr2/approve
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/dmwm/WMCore/issues/7768#issuecomment-292225545


Error when used as a screensaver

Godot version: 3.0
OS/device including version: Win 10
Issue description:
I exported my game as a windows application, but when using it as a windows screen-saver (renaming the file to .scr) or using it in wallpaper engine, it crashes with the same error. When I run it as normal, just the exe and .pck, it works just fine. I also found the error will happen even with a default project consisting of one node and no scripts.
Here is a photo of the error (no scripts, one scene with one node2d, exported as a windows application with default settings, then the exe renamed to scr)

In Windows, a screensaver has various command line parameters to launch different parts (screensaver, configuration tool etc). "/S" is one such parameter.  You'd probably need a way to disable command line parameters in Godot but I don't think that exists. Easiest option may be to write a wrapper frontend.

Using a Godot application as screensaver by simply renaming the binary extension is not supported, as the error shows Windows has specific requirements on what a screensaver application should support.
Eventually I may clean up the argument parsing and make it so that a stray /S won't cause a crash, but in the meantime you need to check Windows documentation on how to create screensavers with thirdparty applications.

I've found to get it to work with wallpaper engine I need to modify the parent window of the godot game's window to a certain PID. Is this possible?

You can probably instance the Godot window as a child of that PID, but that's not really linked to Godot anymore, more to general Windows API usage.


Inverted histogram

The current historgram metric type is a good tool to calculate SLAs or to generally report how much was "good".
But common usecases are e.g. tracking slow or large requests etc. where you want to report how much was "not good". And this is quite cumbersome with a histogram. To get e.g. the rate of requests taking more then 1s you'd need to do:
sum(rate( response_time_seconds_count[5m]))
    - ignoring(le) sum(rate( response_time_seconds_bucket{le="1"} [5m] ))

If you could define a histogram with buckets that contain datapoints that are greater then ("gt") a certain threshold, this query would be much simpler.
E.g. having these buckets:
response_time_seconds_bucket{gt="0"}
response_time_seconds_bucket{gt="0.1"}
response_time_seconds_bucket{gt="0.2"}
response_time_seconds_bucket{gt="0.5"}
response_time_seconds_bucket{gt="1"}

You could track requests > 1s only with:
sum(rate( response_time_seconds_bucket{gt="1"}[5m]))

The {gt="0"} bucket would be similar to the {le="+Inf"} acting as a lower boundary matching all values not already catched by another bucket. The client libraries would need to make sure that a bucket with gt=0 exists.
I think this would be a nice addition to prometheus making some common tasks easier.

Absolute values aren't of much use, it's the ratios that you care about. In that respect there's no particular advantage to one over the other, and having two slightly different ways to get the same data would not be a net benefit to users.

On 22 September 2016 at 09:43, Jean-Pierre Bergamin
<EMAIL_ADDRESS>wrote:

sum(rate( response_time_seconds_count[5m]))

ignoring(le) sum(rate( response_time_seconds_bucket{le="1"} [5m] ))

That's not really a very complicated expression. Check out the
expression for the Apdex score
https://prometheus.io/docs/practices/histograms/#apdex-score . Once
you are at the "usual" complexity level of PromQL expressions, the
simplification introduced by the proposed inverted histogram doesn't
really matter much in relative term. In contrast, introducing a
slightly different metric type is a quite heavy complication, which
would leave a trail through the whole stack, starting at code
instrumentation.
--
Björn Rabenstein, Engineer
http://soundcloud.com/brabenstein
SoundCloud Ltd. | Rheinsberger Str. 76/77, 10115 Berlin, Germany
Managing Director: Alexander Ljung | Incorporated in England & Wales
with Company No. 6343600 | Local Branch Office | AG Charlottenburg  |
HRB 110657B

We graph the ratio of slow requests which ends up in very complicated queries like:
(  sum(rate( backend_http_response_time_seconds_count {instance=~"$instance"} [30s])) by(instance) - ignoring(le) sum(rate( backend_http_response_time_seconds_bucket {instance=~"$instance", le="1"} [30s] )) by(instance)  )
/
(sum(rate( backend_http_response_time_seconds_count {instance=~"$instance"} [30s])) by(instance))

The "gt" buckets could even be mapped to the "le" buckets by the server so that the clients do not need to care about any histogram change.
response_time_seconds_bucket{gt="0"} -> response_time_seconds_bucket{le="+Inf"}
response_time_seconds_bucket{gt="0.1"} -> response_time_seconds_count - response_time_seconds_bucket{le="0.1"}
response_time_seconds_bucket{gt="0.2"} -> response_time_seconds_count - response_time_seconds_bucket{le="0.2"}
etc.

having two slightly different ways to get the same data would not be a net benefit to users.

It would just make using histograms easier to use in most of our usecases: tracking slow and large stuff.

On 22 September 2016 at 13:08, Jean-Pierre Bergamin <
<EMAIL_ADDRESS>wrote:
The "gt" buckets could even be mapped to the "le" buckets by the server so

that the clients do not need to care about any histogram change.
response_time_seconds_bucket{gt="0"} -> response_time_seconds_bucket{le="+Inf"}
response_time_seconds_bucket{gt="0.1"} -> response_time_seconds_count - response_time_seconds_bucket{le="0.1"}
response_time_seconds_bucket{gt="0.2"} -> response_time_seconds_count - response_time_seconds_bucket{le="0.2"}
etc.
If you need this mapping, you can create recording rules to generate those
time series. (Note, however, that it is strongly recommended to let metrics
with the same name always have the same label dimensions. So you inverted
histogram should be named differently from response_time_seconds_bucket.)
(Note also that this doubles the number of time series, which is usually
the resource bottleneck on a Prometheus server already.)

--
Björn Rabenstein, Engineer
http://soundcloud.com/brabenstein

SoundCloud Ltd. | Rheinsberger Str. 76/77, 10115 Berlin, Germany
Managing Director: Alexander Ljung | Incorporated in England & Wales with
Company No. 6343600 | Local Branch Office | AG Charlottenburg  | HRB 110657B


Do you want to have the enhancement of existing game ? 😀 Describe yourself..
Adding a footer in the game
Describe the solution you'd like
I will be adding a responsive footer with social media links
Select program in which you are contributing
GSSoC23
Code of Conduct

[X] I follow CONTRIBUTING GUIDELINE of this project.

please assign me @pa

If you have any doubt you can directly send message on our discord (https://discord.gg/rZb46cCMmK), we have created separate channals for all projects...
Thank you :)

I would like to work on this please assign it to me


chore: update turborepo to v2

Description

Update turborepo to latest v2
Add "terminal UI" to lint and test tasks
Remove package:task prefix from dev-turbo task
Provide env var list for new strict env var default
Remove unnecessary login step from lint and test CI tasks

Screenshots

https://github.com/user-attachments/assets/e6f1517e-1708-4b65-97ba-315172dd74f5
https://github.com/user-attachments/assets/faff0d6e-a4db-4c79-9cd2-050320bf9cc3

:tada: This PR is included in version 1.12.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Fix SyntaxWarning issues with Python 3.8.

A few SyntaxWarning issues are reported when installing the Debian packages with python3.8:

SyntaxWarning: 'bool' object is not callable; perhaps you missed a comma?
SyntaxWarning: "is" with a literal. Did you mean "=="?

Thanks!


test new implementation of vcl::utils::Dims

Test this version with casting operator of OpenCV type cv::Size_.

completed.

Completed & Tested.


TreeView.title comment polish

Refs: #81635
The current description is the following:
"The name of the tree view. It is set from the extension package.json and can be changed later."
I suggest the following to allign better with out other descriptions:
"The tree view title is initially taken from the extension package.json.
Any changes will be properly reflected in the UI." Or mention exactly that it is shown in the title of the view.
We usually do not mention that something can be changed. If there is not readonly keyword that is implicit.

Updating to
		/**
		 * The tree view title is initially taken from the extension package.json
		 * Changes to the title property will be properly reflected in the UI in the title of the collapsible view section.
		 */
		title?: string;


Add molecule tests to kpt Ansible role

The kpt Ansible role is used as helper for some tasks defined in the bootstrap and install Ansible roles. The initial version didn't have unit tests and documentation. This change provides some information and integration tests.

FYI reviewing this currently; any instructions on how to test this out would be helpful. Great to see the e2e job being invoked.

FYI reviewing this currently; any instructions on how to test this out would be helpful. Great to see the e2e job being invoked.

Sure, given this change provides more integration tests, this can be tested through tox tool. In order to run any integration test, the requirements are vagrant, virtualbox and tox tools. Once they are installed, you can run it tox -e kpt for testing kpt Ansible role.

/remove-hold

reviewed the PR to understand the content,(not an expert in molecule) and become familiar.
/lgtm


after clicking full-screen content only resizes if user triggers a tooltip or switches slide

The contents on the chart should automatically adapt to the size after going in and out of full-screen and not wait for the first interaction.
Currently, it works like this.

Duplicate of https://github.com/vizzuhq/vizzu-story-js/issues/44


General error.type definition should clarify that fully qualified exception type name should be used

Area(s)
area:error
What happened?
Description
Common definition of error.type doesn't mention that fully qualified name should be used (when exception type is recorded).
It's specifically important on Python where exception_type.__name__ is not qualified.
Expected Result
Here's how we recommend it in HTTP semconv

[1]: If the request fails with an error before response status code was sent or received, error.type SHOULD be set to exception type (its fully-qualified class name, if applicable) or a component-specific low cardinality error identifier.

Semantic convention version
1.24.0
Additional context
No response

I will send a PR to address this.


Refactored CSS and added switch color scheme to media query.

I think this is our final project.  Merge if you agree!

:shipit:


promtool rules test should report missing rule files

Proposal
promtool test rules ... usability improvement to issue an error when some rule files are not found.
Bug Report
What did you do?

I tested prometheus rule using promtool
I mistyped name of the rule fule specified under key .rule_files (alert.yml instead of alert.yaml)

What did you expect to see?

promtool warning or error that file[s] specified under key .rule_files does not exist

What did you see instead? Under which circumstances?

I spent some time digging into why is my alert not firing even when I confirmed in .promql_expr_test section it should fire
promtool was not showing any warnings/errors on missing files

Environment

System information:

$ uname -srm
Linux 5.0.17-200.fc29.x86_64 x86_64

Prometheus/promtool version:

$ promtool --version
promtool, version 2.12.0 (branch: HEAD, revision: 43acd0e2e93f9f70c49b2267efa0124f1e759e86)
  build user:       root@7a9dbdbe0cc7
  build date:       20190818-13:53:16
  go version:       go1.12.8

Identical with last released promtool version 2.13.0.

Alertmanager version:
Not applicable

Prometheus configuration file:
Not applicable

Alertmanager configuration file:
Not applicable

Logs (promtool):

$ ls ./alert*.yaml
./alert_test_corrected.yaml  ./alert_test_bad.yaml  ./alert.yaml

# valid alert rule file case
$ promtool test rules ./alert_test_corrected.yaml
Unit Testing:  ./alert_test_corrected.yaml
  SUCCESS

# invalid alert rule file case
$ promtool test rules ./alert_test_bad.yaml
Unit Testing:  ./alert_test_bad.yaml
  FAILED:
    alertname:LongTermInfoAlertBecameWarningAlert, time:72h2m0s,
        exp:"[Labels:{alertname=\"LongTermInfoAlertBecameWarningAlert\", app=\"finan...]",
        got:"[]"

$ diff -u ./alert_test_bad.yaml ./alert_test_corrected.yaml
--- ./alert_test_bad.yaml 2019-10-18 15:52:35.481107512 +0200
+++ ./alert_test_corrected.yaml   2019-10-18 10:17:32.537878293 +0200
@@ -1,6 +1,6 @@

 rule_files:
-    - alert.yml
+    - alert.yaml

 evaluation_interval: 1m

There's https://github.com/prometheus/prometheus/pull/6075 for doing what you ask.


Adding in USB from the TempleOS supplemental discs

As I mentioned in the descriptions for the two commits, the conversion scripts don't really change anything. I've also run these through https://techiedelight.com/tools/clike to make it look nicer.

Terry wrote incomplete USB drivers. He stopped working on them since he found them a hassle. I think it would be better to write our own instead.

Ignore what I said above, this PR has been discussed on Discord.


Exit voice heartbeat loop eventually after closing VWS

Expands the WebSocket#close delegation to set a heartbeat-sending flag, similar to what we do in Client.
Fixes #93

Can you squash this?

Done


Is there any mini simulation platform to try?

Do you find a suitable simulation platform?

you can try it with this repo：https://github.com/hilookas/SimplerEnv

I'm also eager to know if there are any other simulators available. The training set I'm using is the bridgeV2. Any comments or advice would be appreciated!

Hi @yuedajiong, @RZFan525, @wangning1234, and @betray12138,
Thank you for your question. We will soon be releasing OpenVLA fine-tuning results for the LIBERO simulation benchmark, along with instructions on how to reproduce the results. Stay tuned!
-Moo Jin

Hi all,
We recently added new experiments for fine-tuning OpenVLA on the LIBERO simulation benchmark (see Appendix E in v2 of the OpenVLA paper on arXiv). We also added instructions to run OpenVLA in simulation and reproduce our results to the README (see the LIBERO Simulation Benchmark Evaluations section).
Hopefully this provides a convenient way for you to try OpenVLA in simulation! Please let me know if you run into any issues.
-Moo Jin


[ENH] WIP: Support >= numpy 2.0

Description of changes
Summarize the changes made by this PR.

Improvements & Bug fixes

numpy 2.0 was not support because of ONNX runtime

New functionality

...

Test plan
How are these changes tested?

[ ] Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes
Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?

#2776  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @spikechroma and the rest of your teammates on  Graphite

Were you able to test this / confirm that onnxruntime released a supporting version to Pypi?
https://github.com/microsoft/onnxruntime/pull/21085

Were you able to test this / confirm that onnxruntime released a supporting version to Pypi?
microsoft/onnxruntime#21085

this is still in wip. let me test it today

Mac and Windows test passing for the
numpy 1.26.0 and onnxruntime 1.19.2
numpy 2.1.1 and onnxruntime 1.19.2

Closing in favor of #2811


bpftune: 0-unstable-2024-05-17 -> 0-unstable-2024-06-07

Diff: https://github.com/oracle/bpftune/compare/83115c56cf9620fe5669f4a3be67ab779d8f4536...04bab5dd306b55b3e4e13e261af2480b7ccff9fc
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 319924 run on x86_64-linux 1

1 package built:

bpftune


Set period and date range returns varying results

I would like to get all the news articles in the past five years, however, the script only returns 99 most recent results. Is there a reason for this? If yes, how can this be tackled?

The period and date range are not always working properly, google is not always return the exact date within the selected range. That is one of google's optional parameter, you may need to do some data cleaning to make sure all the items are in the selected range.


another girlpower

i played a bit with the particle class to promote the advantages of the workflow.
in general, i needed to fix references for vl and the vvvv-modules. didn't pack those changes into the commit, though.
also i needed to modify Renderer (CraftLie).v4p a tiny bit.
note:
iirc. the whole thing was faster here 415ec4e026ad9a024f850380a6e0039ffe2ce97c
i didn't use sprite instead of box here, maybe that'll be better/faster?

iirc. the whole thing was faster here 415ec4e

this is interesting, it should probably have the exact same performance. can you confirm that the performance changes depending on what patch is shown in the VL editor? or none at all... i.e. open the vvvv patch without VL editor open.

in general, i needed to fix references for vl and the vvvv-modules. didn't pack those changes into the commit, though.

did you only need to change references in the .csproj file?
the .v4p and .vl files should find everything when the folder is placed into vvvv/lib/packs with the name "CarftLie.1.0.0"

content should be the repo content...

awesome patch, thx!!!


Fix headless exporting bugs

fixes two bugs. Firs one: on first run (when the config directory can't be found and one with the defaults is created), we don't set the settings variable. This leads headless exporting for android search for the template apk under / and not inside the  ~/.godot/ directory.
The second bug was that if configuration fails, e.g. because that said apk can't be found, the application neither prints an error nor exits. Instead, it hangs.

Fixes parts of #1757. Real error reporting (why and so on) still doesn't happen.

I've tested the second commit now, and think it is safe.

The first bug is a problem for automated build bots like f-droid, because they always start with a clean installation.

nice, thanks!


Increasing timeout and adding retry for notebook test

Description of changes:
Increasing timeout and adding retry for notebook test.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

/approve
/lgtm


Webjars version

A nice idea from wicket-bootstrap implementation of webjars was to use the current to get the latest version of the webjar, so if you modify the pom.xml to get other dependecy you shouldn't modify all the html or templates. Of course this should be optional and if the user wants to use the fixed version string the scripts should be loaded.

I like the idea but I see some improvements (I don't know if it's technical possible or if add some value).
For example now we do:
<link href="${webjarsAt('bootstrap/3.3.1/css/bootstrap.min.css')}" rel="stylesheet">
<script src="${webjarsAt('jquery/1.11.1/jquery.min.js')}"></script>

You propose:
<link href="${webjarsAt('bootstrap/current/css/bootstrap.min.css')}" rel="stylesheet">
<script src="${webjarsAt('jquery/current/jquery.min.js')}"></script>

I prefer a very aggressive approach as:
<link href="${webjarsAt('bootstrap.min.css')}" rel="stylesheet">
<script src="${webjarsAt('jquery.min.js')}"></script>

or
<link href="${webjarsAt('css/bootstrap.min.css')}" rel="stylesheet">
<script src="${webjarsAt('js/jquery.min.js')}"></script>

And don't forget that we must keep pippo-core as slim as possible. If any implementation is a little big for core we must move the code in a new module (maybe it's not case of webjars).

Wow.  I'm not sure if we can safely get that aggressive with the WebJars handler.  The layout is consistent - but only up-to-a-point - especially when looking at the newer Bower WebJars.
Do you mean to search the classpath for a resource matching that name?  Could get expensive.
@danjee How does Wicket's current linking work?  Are they literally depending on <version>current</version> or are they interpreting current in their WebJar integration?

They interpret the current word in java code.

An idea is to use WebJarAssetLocator from webjars-locator-core
<dependency>
    <groupId>org.webjars</groupId>
    <artifactId>webjars-locator-core</artifactId>
    <version>0.25</version>
</dependency>

but again I don't know if it's ok (add some value) to complicate the current (simple) implementation of the  webjars in pippo.

Adding that jar would add quite a few dependencies  - Jackson & friends - to core and break one of our design requirements.
I agree that specifying fixed versions in templates is cumbersome.  Maybe we could adopt something like what @danjee is proposing to make it more palatable.
I'm thinking we could try to locate all pom.properties that are located within org/webjars subdirectories on the classpath.  If we can do that then we can easily create a name-version index to support the proposed current version.
Sadly, WebJars do not export a descriptor file in the same location for all jars.  That would have been quite handy.  Instead we'll have to implement some classpath scanning logic without adding a dependency.

@gitblit I agree. Also, if the implementation is complicated we can abandon this feature.

Assuming no one else has started this, I'll take a stab at this.

I pushed a working implementation of /current/ support in #180.

Thank you! I will update the pippo documentation on webjars.org after the 0.6.0 release.

Also will be great to update the documentation on pippo-site (branch release-0.6.0)


How to assemble lumped mass matrix?

Hi,
may I sincerely ask,  how to assemble lumped mass matrix in mfem?
For the full mass matrix:
mVarf->AddDomainIntegrator(new MassIntegrator(one));
mVarf->FormSystemMatrix(u_ess_tdof_list, A);
Is there any similar function in MFEM like LumpedMassIntegrator
that put all off-diagonal entries on the diagonal ?
Thank you in advance

@YHD17 you can try
AddDomainIntegrator(new LumpedIntegrator(new MassIntegrator));

Thanks a lot.  It works now !


More refactoring of SearchBuilder

Rename params_hash/form_hash to just params
Make rest of SearchBuilder lazy too (don't run search from
#initialize)
Tidy up AlertBuilder to not reinvent the wheel of its parent class

Review app deployed to https://teaching-vacancies-review-pr-2833.london.cloudapps.digital


[BACKLOG-35672] Concat Fields Step throws Exception

:white_check_mark: Build finished in 6m 24s
Build command:
mvn clean verify -B -e -Daudit -amd -pl plugins/core/impl

:exclamation: No tests found!
:information_source:  This is an automatic message

:white_check_mark: Build finished in 5m 48s
Build command:
mvn clean verify -B -e -Daudit -amd -pl plugins/core/impl

:exclamation: No tests found!
:information_source:  This is an automatic message


unix: add constants for PPS devices ioctl's

After trying to implement Pulse Per Second devices
in go, I found that the ioctl values and structs
where not in the unix package yet:
~# strace ppstest /dev/pps0 |& grep ioctl
ioctl(3, PPS_GETPARAMS, 0xbee63b18)     = 0
ioctl(3, PPS_GETCAP, 0xbee63b84)        = 0
ioctl(3, PPS_GETPARAMS, 0xbee63b18)     = 0
ioctl(3, PPS_SETPARAMS, 0xbee63b18)     = 0
ioctl(3, PPS_FETCH, 0xbee63b00)         = 0
ioctl(3, PPS_FETCH, 0xbee63b00)         = 0
ioctl(3, PPS_FETCH, 0xbee63b00)         = 0
ioctl(3, PPS_FETCH, 0xbee63b00)         = 0
ioctl(3, PPS_FETCH, 0xbee63b00)         = 0

This commit should add them.

@googlebot I signed it!


Crashing server on login

Issue description:
try to log into server and it crashes server
What happens:
just log in and time out then crashes server
What you expected to happen:
log in and not crash the server
Steps to reproduce:
1.load minecraft
2.click multiplayer
3.click login
...
Version (make sure you are on the latest version before reporting):

Minecraft:1.10.2
Forge: <IP_ADDRESS>1
Refined Storage:1.2.25

Does this issue occur on a server? [yes/no]
If a (crash)log is relevant for this issue, link it here:
https://pastebin.com/zbJXK5T6
[pastebin/gist/etc link here]

Same as #1240


why not extract expressjs router to independence package?

why not extract expressjs router to independence package，here is a example at https://github.com/i5ting/exr
and in Koa 2.x we can
app.em(function(req, res, next){
  const start = new Date();
  return next().then(() => {
    const ms = new Date() - start;
    console.log(`${req.method} ${req.url} - ${ms}ms`);
  });
})

maybe we can reuse this router

all router usages in expressjs
https://github.com/expressjs/express/blob/master/lib/express.js
exports.Route = require('exr').Route
exports.Router = require('exr').Router

Unless I misunderstand the question, this has already been done in 5.0?
The router part was extracted to pillarjs/router, which is referenced by the 5.0 branch.

@CanisLupusXenonis  thanks for reply, i already see pillarjs/router，code is similar，but can't use directly in express

see here https://github.com/expressjs/express/blob/5.x/package.json

You need the 5.0 branch, not the 5.x branch.
https://github.com/expressjs/express/blob/5.0/package.json

thanks @CanisLupusXenonis


Cannot use nested interfaces to type endpoint output

Describe the bug
This is a follow-up on #1997, which was recently fixed in #4897.
The new BodyValidator type seems to work well, but it doesn't seem to work with interfaces that have properties which are themselves interfaces.
Reproduction
If you prefer a repository: check out this file in flut1/sveltekit-endpoint-output-nested-interfaces-repro
import type { RequestHandler } from "@sveltejs/kit";

interface GetOutput {
    item: { message: string }
}

// No TS error
export const get: RequestHandler<any, GetOutput> = async () => {
    return {
        status: 200,
        body: {
            item: { message: 'hello' },
        },
    };
};

interface Item {
    message: string;
}

interface PostOutput {
    item: Item;
}

// TS error: Type '{ message: string; }' is not assignable to type 'never'.ts(2322)
export const post: RequestHandler<any, PostOutput> = async () => {
    return {
        status: 200,
        body: {
            item: { message: 'hello' },
        },
    };
};

Logs
Output of svelte-check:
sveltekit-endpoint-output-nested-interfaces-repro/src/routes/index.ts:26:14
Error: Type '() => Promise<{ status: number; body: { item: { message: string; }; }; }>' is not assignable to type 'RequestHandler<any, PostOutput>'.
  Type 'Promise<{ status: number; body: { item: { message: string; }; }; }>' is not assignable to type 'MaybePromise<RequestHandlerOutput<PostOutput>>'.
    Type 'Promise<{ status: number; body: { item: { message: string; }; }; }>' is not assignable to type 'Promise<RequestHandlerOutput<PostOutput>>'.
      Type '{ status: number; body: { item: { message: string; }; }; }' is not assignable to type 'RequestHandlerOutput<PostOutput>'.
        The types of 'body.item' are incompatible between these types.
          Type '{ message: string; }' is not assignable to type 'never'.
export const post: RequestHandler<any, PostOutput> = async () => {

System Info
System:
  OS: macOS 12.3.1
  CPU: (8) arm64 Apple M1
  Memory: 111.95 MB / 8.00 GB
  Shell: 5.8 - /bin/zsh
Binaries:
  Node: 16.15.0 - ~/.nvs/default/bin/node
  npm: 8.5.5 - ~/.nvs/default/bin/npm
Browsers:
  Firefox: 100.0
  Safari: 15.4
npmPackages:
  @sveltejs/adapter-auto: next => 1.0.0-next.42
  @sveltejs/kit: next => 1.0.0-next.330
  svelte: ^3.44.0 => 3.48.0

Severity
annoyance
Additional Information
No response

cc'ing @ignatiusmb for visibility

Thank you for the thorough report. Seems like the initial problem of interfaces not having implicit index signatures is still apparent when nested as properties. Changing Item from an interface to a type alias removes the error, so I guess something is not working with the recursive check.


Switch to using dep for dependency management

What this PR does / why we need it:
Glide is no longer actively developed and the Go community
recommendation is to move to the "dep" project for dependency
management.
This migrates our existing glide usage to dep and picks up
the latest vendor package updates.

I'm curious how dep remove so many files from vendor folder compared to glide, it's amazing!


Latest release version tag not updated

Go packaging tools that work with versions (e.g. dep) are picking up the release version v2.0.0 from 2016. The latest code needs to be packaged in a release version that is above 2.0.0 so that it can work with the tools. Is this possible to do ASAP?

@mholt @weingart should we cut one as 2.1.0 release? there are some PRs waiting to be merged around zip slip and symlink, thoughts?

Sure, that's probably a good idea. :+1:

Thanks @weingart for cutting the release.. I have tagged a v2.1.0 to keep compatibility for Go Modules support


Matrix Block Dropdown Groups

First of all, thanks for this great plugin. I was using PMM, but ultimately Neo suited my specific needs. One thing I miss that I'd like to request is dropdown groups:

I was thinking this could be a managed somewhat like so:
![concept_ui]
(https://s3.amazonaws.com/f.cl.ly/items/2L2l1O2t0H3F0c0h1q1q/Image 2016-07-11 at 10.23.05 PM.png)
Thanks again for all your hard work on this!

Well crap! I just realized this is already possible via the "Group" button. I thought it was disabled because of the color. You're awesome!

Haha no worries man, cheers. Maybe I should change the colour of that text...


Node.js 12 deprecated use Node.js 16

Hi @lee-dohm
Our workflow got the following warning:
Node.js 12 actions are deprecated. Please update this action to use Node.js 16.
https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/
Hope u can address this because we are really liking the workflow over at https://github.com/FreeTubeApp/FreeTube/

+1, we are also getting this warning.
It should be resolved once this PR is approved.
https://github.com/lee-dohm/no-response/pull/367


Add a Gitter chat badge to README.md

Dog-Face-Development/Bars now has a Chat Room on Gitter
@willtheorangeguy has just created a chat room. You can visit it here: https://gitter.im/Dog-Face-Development/Bars.
This pull-request adds this badge to your README.md:

If my aim is a little off, please let me know.
Happy chatting.
PS: Click here if you would prefer not to receive automatic pull-requests from Gitter in future.

Adding...

Closed.


Get Aggregation value in Tree Grid.

Using below logic I can iterate my present visible grid.
$scope.gridApi.grid.renderContainers.body.visibleRowCache.forEach(function (row) {
  console.log($scope.gridApi.grid.renderContainers.body.visibleRowCache);
  // my logic
});

But from the above logic I can find no for "groupPriority =  0". How can I able to iterate higher grouping level to lower grouping level .
For better understand see attached screenshot.

The row has a groupLevel on it, that should tell you which grouping you're currently looking at.

Hi Paul.
Kindly refer above attached screenshot for proper understanding.
Current size of $scope.gridApi.grid.renderContainers.body.visibleRowCache is 1 and groupLevel is 0 which is holding data for State INDIA.
Logically in groupLevel is 1 it will hold data corresponding to female(2) and male(4). So how can I iterate $scope.gridApi.grid.renderContainers.body.visibleRowCache for getting data when groupLevel = 1?

What have you already tried - example code perhaps or a plunker?

Request for further information, no further comment for over 3 weeks.  Closing.


Install-PSResource -SkipPublisherCheck parameter

Summary of the new feature / enhancement
We should have a -SkipPublisherCheck parameter for Install-PSResource
Proposed technical implementation details (optional)
No response

I'm closing this issue as a dup of https://github.com/PowerShell/PowerShellGet/issues/519

Would be helpful if I read my own comments before reopening 😓


Feature Request: Options for different blocking with different Restrictions

Currently, it appears as if the only Wall Restriction that this module checks for is Light restriction. If there were options when creating a template to change what restrictions it reads, so it could pass through certain ones but not others, that would be a huge help. For example, if the template is blocked by is Move restrictions, a template would be stopped at a window (having Move restriction but not Light restriction).

Yes, this sounds like a good idea.

See v0.5.0.


Can not install

iMac-5k:test giel$ source venv/bin/activate
(venv) iMac-5k:test giel$ pip install ResponsiveVoice
Collecting ResponsiveVoice
  Downloading https://files.pythonhosted.org/packages/4c/9f/bf606a9a8a1d5f0586c1887ba68998fc4a537b1107f509a64d0043b4002f/ResponsiveVoice-0.3.tar.gz
    ERROR: Command errored out with exit status 1:
     command: /Users/giel/Github/VirtualEnv/test/venv/bin/python3 -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/private/var/folders/zv/008pcbmx0ydf5kq18_tyg_l80000gp/T/pip-install-e5zpwrc1/ResponsiveVoice/setup.py'"'"'; __file__='"'"'/private/var/folders/zv/008pcbmx0ydf5kq18_tyg_l80000gp/T/pip-install-e5zpwrc1/ResponsiveVoice/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' egg_info --egg-base /private/var/folders/zv/008pcbmx0ydf5kq18_tyg_l80000gp/T/pip-install-e5zpwrc1/ResponsiveVoice/pip-egg-info
         cwd: /private/var/folders/zv/008pcbmx0ydf5kq18_tyg_l80000gp/T/pip-install-e5zpwrc1/ResponsiveVoice/
    Complete output (7 lines):
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/private/var/folders/zv/008pcbmx0ydf5kq18_tyg_l80000gp/T/pip-install-e5zpwrc1/ResponsiveVoice/setup.py", line 19, in <module>
        install_requires=required('requirements.txt'),
      File "/private/var/folders/zv/008pcbmx0ydf5kq18_tyg_l80000gp/T/pip-install-e5zpwrc1/ResponsiveVoice/setup.py", line 8, in required
        with open(os.path.join(BASEDIR, requirements_file), 'r') as f:
    FileNotFoundError: [Errno 2] No such file or directory: '/private/var/folders/zv/008pcbmx0ydf5kq18_tyg_l80000gp/T/pip-install-e5zpwrc1/ResponsiveVoice/requirements.txt'
    ----------------------------------------
ERROR: Command errored out with exit status 1: python setup.py egg_info Check the logs for full command output.
(venv) iMac-5k:test giel$ pip3 install ResponsiveVoice
Collecting ResponsiveVoice
  Using cached https://files.pythonhosted.org/packages/4c/9f/bf606a9a8a1d5f0586c1887ba68998fc4a537b1107f509a64d0043b4002f/ResponsiveVoice-0.3.tar.gz
    ERROR: Command errored out with exit status 1:
     command: /Users/giel/Github/VirtualEnv/test/venv/bin/python3 -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/private/var/folders/zv/008pcbmx0ydf5kq18_tyg_l80000gp/T/pip-install-_gpcm345/ResponsiveVoice/setup.py'"'"'; __file__='"'"'/private/var/folders/zv/008pcbmx0ydf5kq18_tyg_l80000gp/T/pip-install-_gpcm345/ResponsiveVoice/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' egg_info --egg-base /private/var/folders/zv/008pcbmx0ydf5kq18_tyg_l80000gp/T/pip-install-_gpcm345/ResponsiveVoice/pip-egg-info
         cwd: /private/var/folders/zv/008pcbmx0ydf5kq18_tyg_l80000gp/T/pip-install-_gpcm345/ResponsiveVoice/
    Complete output (7 lines):
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/private/var/folders/zv/008pcbmx0ydf5kq18_tyg_l80000gp/T/pip-install-_gpcm345/ResponsiveVoice/setup.py", line 19, in <module>
        install_requires=required('requirements.txt'),
      File "/private/var/folders/zv/008pcbmx0ydf5kq18_tyg_l80000gp/T/pip-install-_gpcm345/ResponsiveVoice/setup.py", line 8, in required
        with open(os.path.join(BASEDIR, requirements_file), 'r') as f:
    FileNotFoundError: [Errno 2] No such file or directory: '/private/var/folders/zv/008pcbmx0ydf5kq18_tyg_l80000gp/T/pip-install-_gpcm345/ResponsiveVoice/requirements.txt'
    ----------------------------------------
ERROR: Command errored out with exit status 1: python setup.py egg_info Check the logs for full command output.
(venv) iMac-5k:test giel$ pip3 install responsivevoice
Collecting responsivevoice
  Using cached https://files.pythonhosted.org/packages/4c/9f/bf606a9a8a1d5f0586c1887ba68998fc4a537b1107f509a64d0043b4002f/ResponsiveVoice-0.3.tar.gz
    ERROR: Command errored out with exit status 1:
     command: /Users/giel/Github/VirtualEnv/test/venv/bin/python3 -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/private/var/folders/zv/008pcbmx0ydf5kq18_tyg_l80000gp/T/pip-install-17c0i7jv/responsivevoice/setup.py'"'"'; __file__='"'"'/private/var/folders/zv/008pcbmx0ydf5kq18_tyg_l80000gp/T/pip-install-17c0i7jv/responsivevoice/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' egg_info --egg-base /private/var/folders/zv/008pcbmx0ydf5kq18_tyg_l80000gp/T/pip-install-17c0i7jv/responsivevoice/pip-egg-info
         cwd: /private/var/folders/zv/008pcbmx0ydf5kq18_tyg_l80000gp/T/pip-install-17c0i7jv/responsivevoice/
    Complete output (7 lines):
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/private/var/folders/zv/008pcbmx0ydf5kq18_tyg_l80000gp/T/pip-install-17c0i7jv/responsivevoice/setup.py", line 19, in <module>
        install_requires=required('requirements.txt'),
      File "/private/var/folders/zv/008pcbmx0ydf5kq18_tyg_l80000gp/T/pip-install-17c0i7jv/responsivevoice/setup.py", line 8, in required
        with open(os.path.join(BASEDIR, requirements_file), 'r') as f:
    FileNotFoundError: [Errno 2] No such file or directory: '/private/var/folders/zv/008pcbmx0ydf5kq18_tyg_l80000gp/T/pip-install-17c0i7jv/responsivevoice/requirements.txt'
    ----------------------------------------
ERROR: Command errored out with exit status 1: python setup.py egg_info Check the logs for full command output.
(venv) iMac-5k:test giel$ pip install responsivevoice
Collecting responsivevoice
  Using cached https://files.pythonhosted.org/packages/4c/9f/bf606a9a8a1d5f0586c1887ba68998fc4a537b1107f509a64d0043b4002f/ResponsiveVoice-0.3.tar.gz
    ERROR: Command errored out with exit status 1:
     command: /Users/giel/Github/VirtualEnv/test/venv/bin/python3 -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/private/var/folders/zv/008pcbmx0ydf5kq18_tyg_l80000gp/T/pip-install-_gkayjop/responsivevoice/setup.py'"'"'; __file__='"'"'/private/var/folders/zv/008pcbmx0ydf5kq18_tyg_l80000gp/T/pip-install-_gkayjop/responsivevoice/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' egg_info --egg-base /private/var/folders/zv/008pcbmx0ydf5kq18_tyg_l80000gp/T/pip-install-_gkayjop/responsivevoice/pip-egg-info
         cwd: /private/var/folders/zv/008pcbmx0ydf5kq18_tyg_l80000gp/T/pip-install-_gkayjop/responsivevoice/
    Complete output (7 lines):
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/private/var/folders/zv/008pcbmx0ydf5kq18_tyg_l80000gp/T/pip-install-_gkayjop/responsivevoice/setup.py", line 19, in <module>
        install_requires=required('requirements.txt'),
      File "/private/var/folders/zv/008pcbmx0ydf5kq18_tyg_l80000gp/T/pip-install-_gkayjop/responsivevoice/setup.py", line 8, in required
        with open(os.path.join(BASEDIR, requirements_file), 'r') as f:
    FileNotFoundError: [Errno 2] No such file or directory: '/private/var/folders/zv/008pcbmx0ydf5kq18_tyg_l80000gp/T/pip-install-_gkayjop/responsivevoice/requirements.txt'
    ----------------------------------------
ERROR: Command errored out with exit status 1: python setup.py egg_info Check the logs for full command output.
(venv) iMac-5k:test giel$

packaging issue, now fixed
pip install ResponsiveVoice


Badger 2040 - more readable sans font?

It's somewhat incongruous that a low-resolution device has more serif options than sans-serif ones. It should probably have one low-res-optimized typeface, i.e. a proper "pixel font".
As it is, all sans text looks like Comic Sans, with all that it entails (I'm sure the OpenBSD crowd is very happy, but...).

Progress:

Bitmap fonts "bitmap6" and "bitmap8" are now available in a pre-release build here (must be logged into GitHub) - https://github.com/pimoroni/pimoroni-pico/actions/runs/2065394844
Scale must be an integer >= 1, and text is - slightly frustratingly - orientated from its top left corner. Otherwise it should work more or less the same as the vector fonts.
Will be in v1.18.6 this Friday!

I've just updated the Badger docs (#337) to include the info above so I think we should be good to close this now?


Update rescale_counts.py

Added back function needed for testing to work

I am going to merge this, since it is already pointing to biocore:dev and adds missing functionality needed for the tests to work.


Loading savegame with Prop Anarchy enabled places rocks on top of roads and areas with buildings

By default Prop Anarchy is enabled so upon first load of a savegame there will be rocks on roads and on areas with buildings. I then have to turn Prop Anarchy off using the "A" button and once more load the savegame, this time the rocks will be hidden underneath those objects as it should be. It doesn't matter whether the savegame is loaded from the main menu or from an already running game.
PA enabled prior to loading the savegame:

PA disabled prior to loading the same savegame:

If PA was disabled during savegame load then it also can't be toggled through the bottom "A" button anymore, it will make a clicking sound and not change. It can be enabled through the mod options though, so it's only the GUI button not behaving correctly then.
You might also want to look into the tool tip line duplication, resulting from my multiple savegame load tests I believe:

Mods I am using in case it matters:

ELT I only enable rarely because I consider using it too much of a cheat for making e.g. land levelling not cost any money or soil, but sometimes I want to have a small extra lake somewhere and I use it to place a water source for it, because vanilla game mechanics don't really work for that.


[Menu] Add vertical menu

Add the same behaviour as the original component: https://semantic-ui.com/collections/menu.html#vertical-menu
Please have a look at contributing.md for instructions on how to contribute and submit a PR.

Hello. Can I take this?


It accepts any number and always returns timesFive(5) === 25

Challenge Return a Value from a Function with Return has an issue.
User Agent is: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_10_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/55.0.2883.95 Safari/537.36.
Please describe how to reproduce this issue, and include links to screenshots if possible.
My code:

// Example
function minusSeven(num) {
  return num - 7;
}

// Only change code below this line

function timesFive(num) {
  return num * 5;
}

console.log(timesFive(0));

if you delete the functions, it will still accept the challenge as correct
any number will return -> timesFive(5) === 25

Thank you for reporting this issue.
This is a standard message notifying you that this issue appears to be very similar to issue #9583, so I am closing it as a duplicate.
If you think I'm wrong in closing this issue, please reopen it and add further clarification. Thank you, and happy coding.


Should escape & by default

Using foo\ &bar for the query might run ['sh', '-c', 'rg -H --no-heading --vimgrep --sort-files foo\ &bar'], which then results in an extra entry:

|| sh: bar: command not found

The & gets interpreted by the shell to run everything before it in the background.
(It looks like it gets done when substituting $* (https://github.com/mhinz/vim-grepper/blob/04d659c9e0a57e0c3e989069601d2a98df0386c4/plugin/grepper.vim#L712), but that is only to escape it for substitute after all.)
btw: this is only necessary because of wrapping the cmd in a shell, which could be avoided maybe, even when keeping grepprg as a string by using Python's shlex.split:
diff --git i/plugin/grepper.vim w/plugin/grepper.vim
index ed3e20d..101c6d2 100644
--- i/plugin/grepper.vim
+++ w/plugin/grepper.vim
@@ -733,7 +733,9 @@ function! s:run(flags)
   if has('win32')
     let cmd = 'cmd.exe /c '. s:cmdline
   else
-    let cmd = ['sh', '-c', s:cmdline]
+    let cmd = py3eval(printf(
+          \ '__import__("shlex").split(%s)',
+          \ substitute(string(s:cmdline), "''", '\\''', 'g')))
   endif

   let options = {

(I know you probably do not like this, even when ported to VimL, but wanted to leave it here anyway)

This is expected. The Grepper prompt should act exactly the same as the shell.
For rg foo\ &bar in the shell, you get the same issue. If trying to match the actual string foo &bar, you need to use rg foo\ \&bar, or rg 'foo &bar', or rg "foo \\&bar". Same for the prompt.
The substitute() you quoted above is not meant to put an \ in front of the &. It's needed so that & doesn't get replaced by the matched pattern (:h s/\&):
:echo substitute('rg --foo --bar $* .', '\V$*', 'foo\ &bar', 'g')
:echo substitute('rg --foo --bar $* .', '\V$*', 'foo\ \&bar', 'g')

Thanks for the info.
As mentioned before it is rather inconvenient to have it behave like a shell often.
FWIW, I am using the following currently:
diff --git i/plugin/grepper.vim w/plugin/grepper.vim
index b9b45dc..811d842 100644
--- i/plugin/grepper.vim
+++ w/plugin/grepper.vim
@@ -737,8 +737,24 @@ function! s:run(flags)
   if has('win32')
     let cmd = 'cmd.exe /c '. s:cmdline
   else
-    let cmd = ['sh', '-c', s:cmdline]
+    " NOTE: requires \b to be quoted ("\\bword\\b"), or escaped 4 times
+    " (\\\\bword\\\\b) (instead of 3).
+    try
+      let cmd = py3eval(printf(
+            \ '[__import__("os").path.expanduser(x) '
+            \ .'for x in __import__("shlex").split(%s)]',
+            \ substitute(string(s:cmdline), "''", '\\''', 'g')))
+      " echom printf('%s => %s', s:cmdline, cmd)
+      if cmd is 0
+        " https://github.com/neovim/neovim/issues/8785
+        let cmd = ['sh', '-c', s:cmdline]
+      endif
+    catch
+      echom 'vim-grepper error with shlex.split: '.v:exception.' ('.v:throwpoint.')'
+      let cmd = ['sh', '-c', s:cmdline]
+    endtry
   endif
+  " echom 'vim-grepper: cmd: '.string(cmd)

   let options = {
         \ 'cmd':       s:cmdline,

Just for reference: the "prompt_quote" setting is very useful in this regard: https://github.com/mhinz/vim-grepper/blob/ebe6d1ffd1fb2faada867c56a55f44cbaa0248e3/doc/grepper.txt#L161-L178


feature request: add options to set max_height and min_height globally

Did you check existing requests?

[X] I have searched the existing issues

Describe the feature
Currently it is only possible to set max_height and min_height when calling require('quicker').open({max_height=5}) but not if it is opened with copen or something else.
Provide background
Set max_height globally, so it works even if the quick fix is not opened by this plugin API.
What is the significance of this feature?
nice to have
Additional details
No response

I have been using Telescope.nvim, and you can see in that mapping table they have a <C-q> mapping to send the results to the quickfix list. This is how I usually populate my quickfix list.
I wanted to change the max_height to 20 instead of 10. I tried using qf_helper, but even with max_height = 20 in the qf_helper settings, opening the quickfix list from Telescope sets the height at 10 instead of 20.

Nope, never figured it out yet.


fix: use entry uuid uniformly in return responses

Signed-off-by: Asra Ali<EMAIL_ADDRESS>
Summary

Fixes https://github.com/sigstore/rekor/issues/980
Release Note

Documentation

@priyawadhwa could you please take a look at sharding tests to make sure i didn't omit something purposely tested?

Trying to figure out the json end of line issue with attestations...

Fixed, it was an error handling mistake! I thought !errors.Is would only work on non-nil errors, which is stupid, because it's negated.

@lkatalin could i get your LGTM on this? I'm not sure if I'm breaking this comment. I'm allowing long EntryUUIDs to be passed in
// NOTE: This undoes the change that let people pass in longer UUIDs without
// trouble even if their client is old, a.k.a. it will be able to use the TreeID
// (if present) for routing in the GetLogEntryByUUIDHandler

I'm not sure if I'm breaking this comment. I'm allowing long EntryUUIDs to be passed in

I think that comment addresses an earlier change in which EntryIDs would be shortened to UUIDs since they were unsupported. That should have been fixed in #671, so I think this change is safe.
This LGTM, think it just needs a rebase.

all set! (or I can ninja remove that comment since it seems to no longer apply?)

this change lgtm, I wonder when/if it would be good to update openapi.yaml to only accept the full entryID (80 characters) instead of the 64 character leaf hash we started with.

this change lgtm, I wonder when/if it would be good to update openapi.yaml to only accept the full entryID (80 characters) instead of the 64 character leaf hash we started with.

I'll file a tracking issue for this for some discussion. i THINK people will either have the full entry UUID, OR they will be querying by proposed entry or log index, so i think it will be safe to start restricting but not sure.


API Endpoint

Hey!
Nice Github project. I'm trying to fetch REWE Products for personal purposes as well but the problem is the endpoint i was using was recently closed.
Which API Endpoint are you using for your project?
Best Regards!

You can try to reverse engineer the rewe online shop api.
After looking at it for 1 minute i found that the suggestion function alone gives some good data.
If you dig a little deeper i am sure you will find some better endpoints.
https://shop.rewe.de/api/suggestions?q=searchValue

@MadnessOverflow
I just found something that may help you. Just go on the category of products you want and send the following in the url.
?objectsPerPage=250
250 seems to be the max, but then you can just use any html parser (beautifulsoup for example) and get 250 products in one run, then just increase the page and do it again. It think this should be the best method.


tabular dataset support

Summary
This PR includes,

media type for tabular data
tabular dataset importer
tabular dataset exporter

How to test

Checklist

[x] I have added unit tests to cover my changes.
[x] I have added integration tests to cover my changes.
[x] I have added the description of my changes into CHANGELOG.
[ ] I have updated the documentation accordingly

License

[x] I submit my code changes under the same MIT License that covers the project.
Feel free to contact the maintainers if that's a concern.
[x] I have updated the license header for each file (see an example below).

# Copyright (C) 2023 Intel Corporation
#
# SPDX-License-Identifier: MIT

@jihyeonyi please set the proper milestone for this PR. thanks.


Align zoom levels

Purpose
Align zoom levels between the transition between low to high zoom with the census tract boundary
QA
QA link here
QA spec

[x] when zooming from zoom level 6 to 7 to 8 do the census tract borders show up at the desired time?

looks good thanks @vim-usds

@esfoobar-usds requesting review TY!


Allow Farming Skill to have a +pick option

Currently, we have to use seeds every time to harvest/plant a farming crop. This wastes seeds especially when you want to only collect the plant such as potato cactus or whiteberries for farming. My suggestion is to add in a +pick which will only pick the applicable farming plant off while leaving the bare plant behind. This is to build up herblore supplies reliably over time:
From OSRS Wiki:
While planting the seed requires level 59 Farming, picking the berries does not. Picking one white berry yields 29 experience. Once all berries are picked from the bush, it will produce more berries, approximately 1 per 25 minutes; one seed can produce a minimum of 4 berries, where the Farming level reduces the chance of using up one of the four "lives" of the patch, much like harvesting herb patches.

This has already been requested in #1125


Tag IDs returned big-endian on iOS and little-endian on Android

See the issue title. When an ISO-15693 tag is scanned using an Android NFC reader, the returned tag's ID is a hexadecimal string in little-endian notation. When the same tag is scanned using the same React Native program but compiled for iOS, the returned tag's ID is a hexadecimal string in big-endian notation.
This does not appear to be because the device itself is using big-endian notation. In testing, both devices are little-endian. So it appears to be a quirk with the NFC manager library. The solution, checking if the platform is OS and swapping endianness if so, is relatively simple but this may be something the maintainers wish to investigate since it produces inconsistent output across platforms.

Still an issue as far as I know.


Feat: having a whitelist flag

Hi,
I see the value of having a --env BLACKLIST_SERVICES.
In my case I would like to be more granular way to select only a few services that will be impacted by shepherd. I run about 60 services at the moment and only 3 of them (QA stuff) should be impacted by shepherd.
Example
--env ONLY_SERVICES="webapp1 webapp2 webappdev"
Thanks for your work!

That feature would be a welcome addition from my standpoint. As I currently do not need this myself, I am open for PRs!

I won't do it and it's not a big deal. Closing by still, I would love it :)


Android 13 restricted settings

Is it possible to change the installation method of the apk file using your library so that the system perceives it as installed from Google Play?

did you get any solution for this?

did you get any solution for this?

No


DateTimeOffset for TimeStamp

Great Tool!   Getting around it by converting things but it would be a great add.  Thanks!!

I have looked into it and I am a little bit confused. Do you mean you want to map the  .NET type DateTimeOffset to a PostgreSQL type timestamp without Timezone information? I think it is probably better to explicitly convert it in the mapping.

Closed due to inactivity.

creating a 'PostgreSQLCopyHelper', I have a DateTimeOffset field, How can I map it? Thanks

Reopen to investigate. Could you give me your table and how you expect the DateTimeOffset to be mapped to the column.

Some useful information for the Npgsql Mapping between .NET CLR Types and PostgreSQL:

https://www.npgsql.org/doc/types/datetime.html

I won't be able to look into this before the weekend. For now I suggest: Convert your DatetimeOffset into a UTC time and use a DateTime, because according to document Npgsql will convert it to a UTC anyway.

Defining the 'MapDateTimeOffset', it's works for me
        private static PostgreSQLCopyHelper<TEntity> MapDateTimeOffset<TEntity>(this PostgreSQLCopyHelper<TEntity> helper, string columnName, Func<TEntity, DateTimeOffset> propertyGetter)         {             return helper.Map<DateTimeOffset>(columnName, propertyGetter, NpgsqlDbType.TimestampTz);         }
Then, I can do this:
 .MapDateTimeOffset("created", x => x.Created);
and it works like a charm!!

Cool! Would you mind making a Pull Request to the repository and maybe add some tests?

I have released 2.4.2, which has a new method MapTimeStampTz for mapping between a DateTimeOffset and a column with TimestampTz Data Type.


Is this compatible with React Bootstrap?

Is this compatible with React Bootstrap? (https://react-bootstrap.github.io)

@chris-herring thank you for your interest in our product. Sincerely we didn't test our product with React Bootstrap so we cannot tell you if it is compatible or not. Did you test that yet? you can try to integrate it in React and let us know what issues you've got and maybe we can help you.
Best,
Alex

Hi Alex,
Thanks for the reply. I like the look of your product but I can't invest the time atm to work on React integration.
Thanks
Chris

@chris-herring no worries, we keep this in mind and after we finish to migrate all our products to Angular 2 we can start with React :D
Best,
Alex


[User32] Layered windows lose alpha-blending when maximized/minimized and close animation

Describe the bug
When closing a layered window, either manually with the mouse or by calling DestroyWindow, there is no close animation. In addition, when an alpha-blended window is being maximized or minimized, it looses its transparency during the animation.
Steps to reproduce the bug
Steps to reproduce the behavior:

Create a new Windows Desktop Application in visual studio
Add WS_EX_LAYERED to CreateWindowEx call
Use SetLayeredWindowAttributes to make the window have any opacity value other than 255.
Build & run
Observe how the transparency is lost when maximizing and minimizing the window. Also notice the missing close animation when you close the window.

Expected behavior
The opacity of the window should be kept even when maximizing and minimizing the window, and there should be a close animation as well.
Version Info

Windows 10 version
Saw the problem?

May 2020 Update (19041)
Yes

November 2019 Update (18363)
Yes

May 2019 Update (18362)
Yes

October 2018 Update (17763)
Yes

Simplified repro

Create a new Windows Desktop Application in Visual Studio

Replace InitInstance function with following:
#include <dwmapi.h>
BOOL InitInstance(HINSTANCE hInstance, int nCmdShow)
{
   hInst = hInstance; // Store instance handle in our global variable

   HWND hWnd = CreateWindowExW(WS_EX_LAYERED, szWindowClass, szTitle, WS_OVERLAPPEDWINDOW,
      CW_USEDEFAULT, 0, CW_USEDEFAULT, 0, nullptr, nullptr, hInstance, nullptr);

   if (hWnd == INVALID_HANDLE_VALUE)
       throw;

   if (!SetLayeredWindowAttributes(hWnd, 0, 244, LWA_ALPHA))
       throw;

   #pragma comment(lib, "dwmapi.lib")
   BOOL fDisable = 0;
   if (FAILED(DwmSetWindowAttribute(hWnd, DWMWA_TRANSITIONS_FORCEDISABLED, &fDisable, sizeof(fDisable))))
       throw;

   if (!hWnd)
   {
      return FALSE;
   }

   ShowWindow(hWnd, nCmdShow);
   UpdateWindow(hWnd);

   return TRUE;
}

Compile and execute

Observe window has min/max dwm transitions, but not close transition

Observe window becomes opaque during dwm transitions

Helpful graphics
DWM Close transition not working as expected

DWM Min/Max transitions working as expected

DWM Min/Max transitions appear to start with opaque window state

Been 3 years, layered windows currently still don't have closing animations.


Non-attentive Tacotron by Google

Hi, Google just published a model similar to yours. I just thought it might be interesting for you, in case you haven't read it yet :p
https://openreview.net/pdf?id=CGFN_nV1ql
I think it's particularly interesting the Gaussian way they upsample the encoder outputs, and maybe also the positional encoding.
Best regards!

Cool, didnt read that yet - looks interesting, thanks!


Adjust checkstyle config

After a couple of PR reviews, found that some options should be added:

SingleSpaceSeparator: "Checks that non-whitespace characters are separated by no more than one whitespace."
This prevent things like x instanceof  y where there are two spaces after instanceof (and which GFM eats in comments...). Side-effect: it also forbids horizontal alignment outside of comments, which seems like a reasonable tradeoff.
EmptyBlock: "Checks for empty blocks."
This prevents things like if (conditional) {} else { //code }, where the conditional should be inverted.

I'm deliberately pushing a commit with only the checkstyle config change first to demonstrate that the build fails, and will follow up with the code fixes.

This is now ready for review.


Add Figma sketches to component pages in the portal

All components should have links to the Figma page using the figma prop of the Example component.

[x] Buttons
[ ] Radio buttons
[ ] Checkbox
[ ] Toggle
[ ] Accordion
[ ] Datepicker
[ ] Dropdown
[ ] Typography (?)
[ ] Input
[ ] Textarea
[ ] Message
[ ] Logo (?)
[ ] Loading indicator
[ ] Divider line
[ ] Card
[ ] List
[ ] Hamburger menu

@piofinn maybe this is not relevant anymore? Close?


UnixPb: Add arm64 binaries on MacOS instead of x64 when available

[x] commit message has one of the standard prefixes
[ ] faq.md updated if appropriate
[ ] other documentation is changed or added (if applicable)
[ ] playbook changes run through VPC or QPC (if you have access)
[ ] for inventory.yml changes, bastillion/nagios/jenkins updated accordingly

For jdk 11, 17 and 18, since arm64 binaries are available, it would be best to use those instead of x64 ones

Fixes https://github.com/adoptium/infrastructure/issues/2518


Nils/redis

What does this PR do?
Add default setup and documentation for the Redis log collection.
Motivation
We added a new integration pipeline for Redis logs. The steps to have it activated are now documented.
Testing Guidelines
Send your redis logs to your platform with source: redis and they should be parsed and all the relevant value extracted in attributes.
Versioning

[ ] Bumped the check version in manifest.json
[ ] Bumped the check version in datadog_checks/{integration}/__init__.py
[ ] Updated CHANGELOG.md. Please use Unreleased as the date in the title
for the new section.
[ ] If PR impacts documentation, docs team has been notified or an issue has been opened on the documentation repo

Additional Notes
Anything else we should know when reviewing?

@jyee redisDB was the slug name of the integration. Reverting it to Redis


fix #357 pk auto generated but value is null

Ⅰ. Describe what this PR did
when pk auto generated and  value is null, fescar can not get the pk value .
Ⅱ. Does this pull request fix one issue?

fix #357
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

Codecov Report

Merging #644 into develop will decrease coverage by 0.01%.
The diff coverage is 0%.

@@              Coverage Diff              @@
##             develop     #644      +/-   ##
=============================================
- Coverage       31.9%   31.89%   -0.02%
  Complexity       868      868
=============================================
  Files            226      226
  Lines           8769     8773       +4
  Branches        1053     1053
=============================================
  Hits            2798     2798
- Misses          5658     5662       +4
  Partials         313      313

Impacted Files
Coverage Δ
Complexity Δ

...baba/fescar/rm/datasource/exec/InsertExecutor.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9123896...396f514. Read the comment docs.

Is this ready for review?

Is this ready for review?

yes


Homarr is using the external url instead of the local url when in LAN

Environment
Docker
Version
0.15.3
Describe the problem
i have reverse proxy setup and having internal url .local and external. however when i am on LAN homarr is always using the external url instead of the .local
BTW... this happened even if i use ip address
i will provide the log as needed
Logs
No response
Context
No response
Please tick the boxes

[X] I confirm that I attached the proper logs
[X] I've read the docs
[X] I've checked for duplicate issues
[X] I've tried to debug myself

The internal address is for homarr's use, the link that you as a user will be redirected to is always the external one.
There is a way to construct modular address so it depends on what way you use to access homarr, check out the little ⓘ next to "External Address" for more details.

The internal address is for homarr's internal use (mostly so you can provide homarr a direct unencumbered way to contact the service it's using), the link that you as a user will be redirected to is always the external one. There is a way to construct modular address so it depends on what way you use to access homarr, check out the little ⓘ next to "External Address" for more details.

thanks, but i am not sure if you have answered by question, is it doable to have internal and external links? for example i use Organizr and it allow me to set internal and external links and it open the links based on how im connected

I did but I can understand it's confusing.
The internal address is for homarr's use only. You as the user will always use the external link.
There is a way to make the external link "variable" depending on what address you use to access homarr.
You have more information about that functionnality if you hover the Ⓘ icon next to "external address" in any app.

As discussed, Homarr will not (and never) act as a reverse proxy. Closing.


Separate the logic of applying resources from syncer and make it reusable

What type of PR is this?

/area simulator
/kind cleanup
What this PR does / why we need it:
syncer and oneshotimporter have their own logic of applying resources. They can be generalized and the replaying feature (#395) can use it.
This PR separates that of syncer and makes it a module resourceapplier.
Which issue(s) this PR fixes:

Part of #395
Special notes for your reviewer:
/label tide/merge-method-squash

/ok-to-test
/cc @utam0k @ordovicia

/retest


Frontend: re-serialise static library status

When compiling the swiftmodule from the textual swift interface, ensure that we re-serialise the static or dynamic nature of the module. This is required for proper code generation where the static and dynamic linking is material to symbolic references. This also opens the possibility of optimizations on other platforms via internalisation of the symbols.
Fixes: #77756

@swift-ci please test

@swift-ci please test

@swift-ci please test

@swift-ci please test Windows platfom

@swift-ci please test Windows platform


Implement reset() and halt() functions

Possible implementation of #564
Draft, because it doesn't work as expected, yet.

Unfortunately, I'm yet to find a good way to reset the rp2040 without losing the debug connection.
The current implementation, which just stops core1 an then calls sys_reset does work, but doesn't fully reset the rp2040. Notably, the spinlocks aren't reset.
However, any attempt to also reset the SIO (which hosts the spinlocks) also breaks the debug connection.
I tend to drop the requirement that the debug connection should stay alive, and instead just trigger a full watchdog reset. Any opinions?

For now, I settled on just doing a full reset, even if it breaks the debug connection. I consider a reliable reset more important than the ability to debug through a reset sequence.

Neotron Pico BIOS uses scratchpad registers to detect a core0 reset and forces a SoC reset with the watchdog. probe-rs gets kicked out, but the workaround I found is to flash it from within the USB bootloader - none of my hardware is configured, and so my crowbar routine is neither triggered nor required.

Neotron Pico BIOS uses scratchpad registers to detect a core0 reset and forces a SoC reset with the watchdog. probe-rs gets kicked out, but the workaround I found is to flash it from within the USB bootloader - none of my hardware is configured, and so my crowbar routine is neither triggered nor required.

That's a nice solution, but I don't think it's suitable for the HAL: The firmware might need the scratchpad registers for some other purpose.
Also, what this PR implements is mainly what you do in watchdog_reboot, just without the 10ms delay. If the firmware author makes sure to use it everywhere instead of calling sys_reset, no boot-time workaround is needed. (Of course, the workaround would still be useful in case the incomplete reset was done by the debug probe.)

rebase on 674 I guess?


Menu not accessible

Some issues:

No focus style
A link is used as the button, producing the wrong role for screen reader users (and since the link doesn't point anywhere, it doesn't behave like a link either)
The state (open / closed) is not communicated
Focus is not moved to the menu when it is opened, meaning it is not reachable by keyboard.

Suggested HTML (elided):
<button aria-expanded="false">
  Menu
</button>

(Note that aria-expanded should be switched to true on opening the menu).
So that the menu is reachable by keyboard, focus() should be applied to the first of the menu items on opening the menu. When pressing the close button, the Menu button should be refocused using focus().

The WAI-ARIA Authoring Practices has some more information on how to make menus or menu buttons accessible.

Hi there!  I'm working on this issue with some classmates.
We've gotten varying responses as to whether aria-expanded should be applied to the menu itself or the button, I was wondering if anyone had any input.

@margemcm Hi! aria-expanded goes — perhaps unintuitively to begin with — on the button. That's so, when you focus the button, it tells you whether the thing it controls is expanded or not.
Hope that helps!

Master branch has now moved on to 2.0 design which no longer has any sort of animated/hidden mobile menu.


Add should_finialize(state) to tf.data.experimental.Reducer

Please make sure that this is a feature request. As per our GitHub Policy, we only address code/doc bugs, performance issues, feature requests and build/installation issues on GitHub. tag:feature_template
System information

TensorFlow version (you are using): 1.14.0
Are you willing to contribute it (Yes/No): No

Describe the feature and the current behavior/state.
Current behavior: tf.data.experimental.Reducer will not finalize until the end of a dataset.
Wanted feature: I don't want to reduce the whole dataset. I hope that the Reducer could decide when to finalize based on its state. For example, add the following function inside Reducer and call the function after reduce_func().
def should_finialize(state):
return True   --> stop reducing anymore, call finalize_func, and return results.
return False  --> continue reduce.
Will this change the current api? How?
No. The default should_finialize always returns False. If anyone wants to change this behavior, he needs to override this function.
Who will benefit with this feature?
The tf.data input pipeline will be more versatile with this new feature. It is possible to do more operations without calling a python generator or py_func. For example, we need several different samples from the same class to be in one batch for tf.contrib.losses.metric_learning.triplet_semihard_loss. The labels of a batch may look like the following:
0, 0, 0, 0,
1, 1, 1, 1,
...
15, 15, 15, 15
There are 64 (=16*4) samples in this batch. I cannot find a pure tf.data way to form batches in this way. But with the new feature, we are able to do so.
Any Other info.
It seems that Jiri Simsa @jsimsa is very familiar with tf.data.experimental.Reducer.

I believe that you should be able to achieve this with existing transformations. In particular, I would direct your attention to group_by_reducer, group_by_window, scan and take_while.
If you provide me with a concrete example of input / output behavior, I can provide you a solution based on existing transformations.

Thanks for your help.
Let's suppose I have a dataset composed of (image, label).
image, label
im0, 0
im1, 0
im2, 1
im3, 1
im4, 1
im5, 2
I want to generate a batch containing 4 samples. The first two are sharing the same label, and the last two are sharing the same label. This can be down by the following code, which is what I am using now.
ds = ds.shuffle(6).repeat()
ds = ds.apply(tf.data.experimental.group_by_window(
  lambda im, label: label,
  lambda key, data: data.batch(2),
  2))
ds = ds.apply(tf.data.experimental.unbatch())
ds = ds.batch(4)

But there is a problem with this code. The first and second samples may be exactly the same one, which is what I want to avoid now. I don't want the same example appearing more than once in each window.
Lets' suppose the shuffled stream are
epoch 0: im0, im1, im2, im3, im4, im5
epoch 1: im0, im1, im4, im2, im3, im5
epoch 2: im0, im1, im2, im3, im4, im5
The generated batch should be
batch 0: im0, im1, im2, im3
batch 1: im0, im1, im4, im4
batch 2: im2, im3, im5, im5
...
The third and fourth samples are exactly the same in batch 1 and batch 2. They will not generate any loss for margin-based losses.
What I am expecting is
batch 0: im0, im1, im2, im3
batch 1: im0, im1, im4, im4 im2  (when the second im4 is adding to a window, do not add it)
batch 2: im0, im1, im3, im2
batch 3: im3, im4, ...
The window for im5 will not be filled forever.

You can achieve the desired effect as follows:
import numpy as np
import tensorflow as tf

tf.enable_v2_behavior()

data = (['a', 'b', 'c', 'd', 'e', 'f'],
        np.array([0, 0, 1, 1, 1, 2], dtype=np.int64))

dataset = tf.data.Dataset.from_tensor_slices(data).shuffle(6)

dataset = dataset.apply(tf.data.experimental.group_by_window(
    lambda x, y: y,
    lambda key, x: x.batch(2),
    window_size=2,
))
dataset = dataset.unbatch().batch(4, drop_remainder=True)
dataset = dataset.repeat()

for elem in dataset.take(3):
  x, y = elem
  print(x.numpy(), y.numpy())

Great! Thank you very much.


increase open file limit in systemd service file

The 0.5.3 release notes encourage override the default number of open files to 7-12k,
## number of open files allowed by database
db-open-files-limit: 10000

This will fail if the corresponding systemd limit is also not raised,
LimitNOFILE=20000

This line should be added to the systemd service file.

Hi there,
This is not a standard configuration and hence, we will not add it to the systemd service file (unless it becomes standard). It does seem to me like something that can be documented. Feel free to make a PR against bee, or at any place where you would expect a comment about this, so that it would help people like you to figure out this configuration by themselves.
Tagging @vandot , so he is aware of this and can approve your PR.

I connect this issue with https://github.com/ethersphere/bee/issues/1559

Why one is 10,000 and the other is 20,000? Shouldn't they be the same?

Why one is 10,000 and the other is 20,000? Shouldn't they be the same?

They could be the same. The constraint is db-open-files-limit <= LimitNOFILE

since every platform has different ways to set the number of open files it is up to the users to find the correct way to change the number of maximum open file a process may have on their operating system. The number of maximum open files must be at least <db-open-files-limit>+<statestore open files>+<all open tcp connections>. Since bee uses multiplexed TCP sockets to communicate with peers, this basically means that 1 peer equals one TCP socket file descriptor. so 1000 peers would mean that you would keep another ~1000 (maybe more) file descriptors open for the network sockets. There are also files being kept open by the state store that keeps tabs over the application state (accounting, syncing intervals, peer stat data, and so on)


Update zio schema version

I didn't realise these were done as well in https://github.com/zio/zio-flow/pull/197. I am closing this PR.


feat/register-passenger

Please review before merging.

:tada: This PR is included in version 1.23.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket: