isPhenotype bug(s?)

Hi Rafael and Jason,
In setting up the non-phenotype work, I had pointed you to the vignette VariableClassification.Rmd in the phonto package.
But somehow the examples given there don't all seem to have been copied over -
I draw your attention to this code:
##comments - most variables end with an LC but not all...so we also
look at the description - the SasLabel doesn't work as they abbreviate
##comments in weird ways
g1 = grep("LC$", xx$Variable)
g2 = grep("*[Cc]omment [Cc]ode$", xx$Description)
outPut[union(g1,g2)] = "Comment"
so any variable whose name ends in LC is a comment, and not a phenotype....but looking at the isPhenotype column in the Metadata, these are all labeled as phenotypes.
I did not exhaustively check the other examples of non-phenotypes, but it would be good to ensure that these are synced up.
Not sure if this is you, or Sam, but in this table
Metadata.QuestionnaireVariables
the column named UseConstraints should be named Target...

We added all (missing) regular expressions applicable to SasLabels to our blocklist_regexps.txt. Then, for the expressions in VariableClassification.md that are applicable to variable identifiers (rather than labels), we added to our blocklist_table.csv all the variable-table pairs that match such regular expressions. The tags in the R code are preserved in a Tag column in that table, and then in a Comment column we have the reason for inclusion of that variable in the table—here we include the regular expressions that were used to derive the entries.
As I mentioned, there some exceptions to one of the regular expressions — variables that end in "LC" but that are not comments. For example LB2ALC, VIXPLC). Such variables that are phenotypes but match one of of our non-phenotype patterns are listed in the newly created allowlist.csv.
The next release will include these updates.
Regarding the column names of Metadata.QuestionnaireVariables, it is an import error during the DB build.

closed via a8ba61a and will be in release v3.10.0.


Improve batch summary page for multiple events

Use tables for more compact display
Add timestamps to event information
Ensure events are sorted in chronological order

I'll merge in, as its better than what's there already, but follow up based on the discussion on the issue/ with Tris.


component: drawable canvas

a component that allows users to draw with the mouse cursor or on touch devices -> usually, a native app feature -> one reason more to use a PWA over a native app

http://www.williammalone.com/articles/create-html5-canvas-javascript-drawing-app/#demo-simple

https://github.com/williammalone/Simple-HTML5-Drawing-App/blob/master/html5-canvas-drawing-app.js


Symfony 7 support

The current version of the library is incompatible with Symfony 7. Specifically Chiphpotle\Rest\Normalizer\JaneObjectNormalizer is incompatible with the Symfony interfaces it attempts to implement.
Further incompatibilities may be abound.

I've dug a bit deeper into this, and it's down to several normalisers being incompatible with the interfaces of symfony/serializer version ^7.0.

Thanks for the report I will take a look later today.

Fixed in v0.7.1


Automated cherry pick of #5838: Fix antctl trace-packet arguments missing issue

Cherry pick of #5838 on release-1.13.
#5838: Fix antctl trace-packet arguments missing issue
For details on the cherry pick process, see the cherry pick requests page.

/skip-all


chore(main): Add functionality to search target issues by a comment message

A new switch use_comment_for_issue_matching is added that is instead of finding what's the target issue by the title, does that by the reference comment created in the source issue (issue_created_comment_template). If nothing found by the reference comment, falls back to title search.
Allows a more robust title match (e.g. in cases when there's multiple issues with the same title in the target or when the source title has changed)
By default set to false so the behaviour is backwards compatible (matching by title)

Closing in favor of https://github.com/camunda/issue-sync-action/pull/16


api allows creation of namespaces with dot

Describe the bug
kafkactl apply allows to create a namespace whose name contains a dot, but forbids to use it.
To Reproduce

Create a .yml resource file with

apiVersion: v1
kind: Namespace
metadata:
  name: exam.ple
spec:
  kafkaUser: ....

Apply the resource : creation is accepted
Namespace "exam.ple" created.

Get the namespaces : namespace is listed

Get topics inside this resource : kafkactl -n exam.ple get topics
-> message Failed because resource forbidden (403).

Expected behavior
As this name is invalid, creation should be rejected.
Or dots in names should be accepted, but I suppose it's not because of the confusion it implies (impossible to know if a.b.c is topic c in namespace a.b or topic b.c in namespace a
Environment (please complete the following information):
Kafkactl 1.11.3 + ns4kafka 1.11.8

Related to security rules denying special chars: https://github.com/michelin/ns4kafka/blob/4c23eedddd66909cfd6d1db111ddcb30d2b00b0d/src/main/java/com/michelin/ns4kafka/security/ResourceBasedSecurityRule.java#L32
Going to do additional tests, but "." in namespace names should not be an issue

This makes me realize there's a bug on topic ownership ACL here : https://github.com/michelin/ns4kafka/blob/master/src/main/java/com/michelin/ns4kafka/services/AccessControlEntryService.java#L106
Ns4kafka lets platform teams grant ownership on 2 distinct prefixes (say my.namespace- and my_namespace-). But for Kafka, this is a conflict. https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/common/internals/Topic.java#L108-L110
Unrelated to this PR, the bug was always there. Doesn't sound too critical @loicgreffier

Addressing it in #367


Perf: Skip nodes that have no renderable props.

Add color: 0 to the node and don't provide any texture/image properties and it will be skipped in the render step.

What does this solve? Are frameworks creating many nodes that shouldn't be rendered? How many are being skipped?

@chiefcll if the node has no renderable properties it will be skipped by the render step.
This will allow SolidJS / JSX to add nodes (e.g. div tags) that do have X / Y / zIndex positioning for its children, but have no "renderable properties" that require to be drawn on the screen.
For example:
<ParentNode x=100 y=200 width=500 height=500 zIndex=2>
  <ChildNode x=10 y=10 src="..image">
  <ChildNode ...>
</ParentNode>

It allows you to freely manipulate the ParentsNode world position/width/etc. without it getting actually rendered. Prior to this change even ParentNode would get a GPU Render Pass, just have an empty instruction so the GPU gets the upload but then figures out it doesn't need to draw anything.
By forcing ParentNode to be color=0 from the App Framework like Solid or Blits, you can have the render still do the positioning but skip the rendering portion. For added clarity, that render step is 80% of the resources spent to render that node. Thus increasing FPS.
This helps a lot by avoiding render steps on nested nodes that do not require to be rendered, but are part of the tree for positioning / zIndex / alpha / container-ish logic.

Thanks for the details. That makes sense. Right now solid is defaulting to transparent for the color. I assume with this change we should remove setting the color? Or set the color to 0? I’ll play around 🙂

I think you’re already setting it to 0x0 in Solid by default if there is no image/texture and if color isnt present. Should be plug and play 😃

Probably best to make this calculated during update(). As this PR stands I think there are different types of property assignment that will not trigger the calculation to be done.

What different properties do you anticipate other then color (and variants), texture (and image), shader and text?
And I don't mind changing it to be part of the update() loop but I suspect it would evaluated more often then just at get/sets of select properties. This is because you're going to run update() every frame, while the renderability wont change that frequent. Hence it being more expensive to evaluate in the update() loop then on set.

What different properties do you anticipate other then color (and variants), texture (and image), shader and text?
And I don't mind changing it to be part of the update() loop but I suspect it would evaluated more often then just at get/sets of select properties. This is because you're going to run update() every frame, while the renderability wont change that frequent. Hence it being more expensive to evaluate in the update() loop then on set.

As it stands if the texture/shader/text are updated the renderability is not updated along with it. I'm simply proposing the recalculation of renderability in update() as a separate updateType flag that is lit only when those select properties are changed on a node. It keeps all the logic for what determines the renderability in one easy to understand/debug place, and guarantees that the calculation only happens once even if multiple of those properties are changed at the same time on the node.

What different properties do you anticipate other then color (and variants), texture (and image), shader and text?
And I don't mind changing it to be part of the update() loop but I suspect it would evaluated more often then just at get/sets of select properties. This is because you're going to run update() every frame, while the renderability wont change that frequent. Hence it being more expensive to evaluate in the update() loop then on set.

As it stands if the texture/shader/text are updated the renderability is not updated along with it. I'm simply proposing the recalculation of renderability in update() as a separate updateType flag that is lit only when those select properties are changed on a node. It keeps all the logic for what determines the renderability in one easy to understand/debug place, and guarantees that the calculation only happens once even if multiple of those properties are changed at the same time on the node.

texture and text definitely had renderability checks, however I did forget to hook it into loadShader
Added a new update:

Rebased with latest main
Hooked into update()
Added loadShader hook

Small note on updates vs renderability:
The update function is a result of changes that need to be processed, the renderability is a result of those updates, creating another update state for this felt counter intuitive. Hence keeping it stand alone. That also makes it easier to call into from texture  or shader load/unloads that might be async.
Also the update() function is becoming quite large, chopping it up will make the JIT more likely to graph its callees and optimize those to the moon and back.

Testing this one along with my latest experimental changes. Should be ready to merge this soon.

@wouterlucas I just noticed that one optimization that would be useful here is to also check if the width or height of the Node is 0. In that case it should be not renderable no matter what.

@frank-weindel agree! I’ll add that in about an hour or so.

@frank-weindel  adding a check that checks for width and height per:
    if (!this.props.width || !this.props.height) {
      return (this.isRenderable = false);
    }

actually makes the alpha blending 2 test fail, the rocko figure isn't rendered:

Which is think would be correct, seeing its attributes in examples\tests\alpha-blending.ts:
    renderer
      .createNode({
        x: curX,
        y: curY,
        src: rocko,
        alpha: 1.0,
        parent: sideContainer,
      })
      .once('loaded', sizeToTexture);

However it does mean the behavior changes over previous and the test will need to be adjusted.
If you're okay with that I'll gladly push the change, otherwise let me know what would be a better route.

I'll make a note to revisit it. I think its an important optimization but the texture/image should still load even if the Node is 0x0.


clarifying the difference between CHMO:"assay output" and IAO:"measurement datum"

When comparing the annotations of CHMO:assay output and IAO:measurement datum , I noticed the following:

the textual definitions seem to be expressing the same:

An information content entity that is output by an assay. &
A measurement datum is an information content entity that is a recording of the output of a measurement such as produced by a device

the textual definitions of both differ from the logical ones in terms of the former defining ICE as genus and the latter "data item".
"assay output" has the equivalence to axiom: data item and is_specified_output_of some assay vs this axiom is only provided as editor note from 2009 with question mark on "measurement datum"
the OBI docs also define the subclasses of "measurement datum" very similar to "assay output":

A ‘measurement datum’ class names and models the datum outputs of an assay, and their contextual semantics.

So the main question is:

Why is "meassurement datum" not reused in CHMO instead of minting "assay output"?

I can only imagine because of the need for the equivalence to axiom. But then I wonder, why is this not not provided in IAO (see IAO#225)?

Hmm - I think we should just use 'measurement datum' instead. Should have captured the reasoning for the choice at the time!

Let's wait for what the IAO devs or maybe someone from the OBI team will say to this. But yes, switching to "measurement datum" was also my first idea. IDK though if this will lead to trouble down the road concerning the axiomatization in CHMO.

Concerning the decision in IAO (see https://github.com/information-artifact-ontology/IAO/issues/255#issuecomment-1476592513), I propose to obsolete CHMO:assay output and replace it with IAO:measurement datum once the axiom has been added to IAO.


Remove rich_embed filter

Discord seem to have fixed the bug that allowed user accounts to send embeds. Things that make me think this:

I can't find a valid triggering of the filter in over 2 years
This reddit post says they patched it https://www.reddit.com/r/Discord_selfbots/comments/sa0hc2/discord_embeds_patched/

This makes the rich embed filter no longer necessary. It's had quite a few bugs (mostly relating to twitter) and gives some false positives, so it would be helpful to have it removed.

@wookie184 Just deleting the file will do it? I am unable to find any other reference to the filter.

@wookie184 Just deleting the file will do it? I am unable to find any other reference to the filter.

Yes, that should be all that's required. (the filter's settings will need to be deleted from the database before merging but I can do that using the !filter delete command)

@wookie184 can you review the PR and delete the filter settings.


SQL Server Version feature was implemented in

Can't see what SQL Server Version feature was implemented in

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6f019407-5787-6f54-1027-084e817b6b8e
Version Independent ID: a92541d0-b63a-9603-2a1f-18e210be89e4
Content: FORMAT (Transact-SQL) - SQL Server
Content Source: docs/t-sql/functions/format-transact-sql.md
Product: sql
Technology: t-sql
GitHub Login: @MikeRayMSFT
Microsoft Alias: mikeray

@RichardMooreClear -- thank you for your feedback.  FORMAT was first implemented in SQL Server 2016, and was not in SQL Server 2014.
I am closing this issue now.  You are welcome to @ mention me for any followup.
We hope to hear from you again.

Hi SQL Docs
Are you sure it only started in SQL Server 2016.
Every where else I searched said SQL Server 2012
Kind regards
Richard Moore
<EMAIL_ADDRESS>This e-mail message, including any attachment(s), is intended solely for the addressee or addressees and is strictly confidential or otherwise legally protected.
If you are not the intended recipient of this communication please return this e-mail message and the attachment(s) to the sender and delete and destroy all copies
From: William Anton Rohm<EMAIL_ADDRESS>Sent: Saturday, 12 October 2019 02:52
To: MicrosoftDocs/sql-docs<EMAIL_ADDRESS>Cc: Richard Moore<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/sql-docs] SQL Server Version feature was implemented in (#3223)
@RichardMooreClearhttps://github.com/RichardMooreClear -- thank you for your feedback. FORMAT was first implemented in SQL Server 2016, and was not in SQL Server 2014.
I am closing this issue now. You are welcome to @ mention me for any followup.
We hope to hear from you again.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/MicrosoftDocs/sql-docs/issues/3223?email_source=notifications&email_token=AII6QQNK2NSXEGLWFP3P7J3QOCVMPA5CNFSM4I7T36MKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBASTXY#issuecomment-541141471, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AII6QQPUJQWEXG2AFNYM5NLQOCVMPANCNFSM4I7T36MA.

Hi SQL Docs
Sorry I accidently deleted your reply to below.
But I just found
https://docs.microsoft.com/en-us/previous-versions/sql/sql-server-2012/hh213505(v%3Dsql.110)
So is Format in SQL Server 2012 or not?
We are in the process of converting our existing DB to MS SQL and need to know what min version of SQL Server to advise our customers.
Kind regards
Richard Moore
<EMAIL_ADDRESS>This e-mail message, including any attachment(s), is intended solely for the addressee or addressees and is strictly confidential or otherwise legally protected.
If you are not the intended recipient of this communication please return this e-mail message and the attachment(s) to the sender and delete and destroy all copies
From: Richard Moore
Sent: Monday, 21 October 2019 08:15
To: MicrosoftDocs/sql-docs<EMAIL_ADDRESS>MicrosoftDocs/sql-docs<EMAIL_ADDRESS>Cc: Mention<EMAIL_ADDRESS>Subject: RE: [MicrosoftDocs/sql-docs] SQL Server Version feature was implemented in (#3223)
Hi SQL Docs
Are you sure it only started in SQL Server 2016.
Every where else I searched said SQL Server 2012
Kind regards
Richard Moore
<EMAIL_ADDRESS>This e-mail message, including any attachment(s), is intended solely for the addressee or addressees and is strictly confidential or otherwise legally protected.
If you are not the intended recipient of this communication please return this e-mail message and the attachment(s) to the sender and delete and destroy all copies
From: William Anton Rohm <notifications<EMAIL_ADDRESS>Sent: Saturday, 12 October 2019 02:52
To: MicrosoftDocs/sql-docs <sql-docs<EMAIL_ADDRESS>Cc: Richard Moore <richard.moore<EMAIL_ADDRESS>Mention <mention<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/sql-docs] SQL Server Version feature was implemented in (#3223)
@RichardMooreClearhttps://github.com/RichardMooreClear -- thank you for your feedback. FORMAT was first implemented in SQL Server 2016, and was not in SQL Server 2014.
I am closing this issue now. You are welcome to @ mention me for any followup.
We hope to hear from you again.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/MicrosoftDocs/sql-docs/issues/3223?email_source=notifications&email_token=AII6QQNK2NSXEGLWFP3P7J3QOCVMPA5CNFSM4I7T36MKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBASTXY#issuecomment-541141471, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AII6QQPUJQWEXG2AFNYM5NLQOCVMPANCNFSM4I7T36MA.


feat: rework chunk ordering using Reactor

Contains
This is a rewrite of https://github.com/MovingBlocks/Terasology/pull/4773 to use Reactor for concurrency (see https://github.com/MovingBlocks/Terasology/issues/4798 and https://github.com/MovingBlocks/Terasology/pull/4786). It does the same thing as the old PR, but is a lot simpler and has more reliable concurrency. Performace should be about the same.
How to test
Try flying around the world with this PR - it should be the same as https://github.com/MovingBlocks/Terasology/pull/4773 and much better than normal.

oi, didn't expect this. I'll have to take a look tonight.

I think that conceptually, we have some sort of publisher of relevant-locations-of-chunks at the top, and something that puts chunk data in to a chunk cache at the bottom, and we want some kind of
f(Flux<Vector3ic> locations) {
  Flux<Chunk> fullChunks = locations
     .parallel()
     .map(chunkProvider);
  fullChunks.subscribe(cacheChunk);
}

with maybe some kind of buffering or windowing operator in there if you think we need to tune CHUNKS_AT_ONCE.

That would definitely be nicer, and it's similar to what I tried to do first, but unfortunately it didn't seem to work with our execution model. One problem is that a Flux<Vector3ic> and then a Function<Vector3ic, Chunk> doesn't work well with the RemoteChunkProvider, which would have to maintain another hash map of received chunks. Another is that when there are no more chunks to generate right now and execution pauses, there's no way to wake it up again from the main thread - a possible solution to this is a signal object that the location flux waits on, but that's not very nice either.

I think that the way this implementation of LocalChunkProvider.chunkFlux returns a Flux that looks different to every subscriber is technically fitting within the bounds of the types, but is contrary to the spirit of a Flux stream.

I'm also wondering about this - there's no mention in the Reactor docs that a flux should always emit the same values to each subscriber, but I also can't find any examples that do that.

Another is that when there are no more chunks to generate right now and execution pauses, there's no way to wake it up again from the main thread

This is the part I keep getting stuck on when trying to think about this design.
I might help if I knew more about what the wake-up triggers would be. Every player movement? Or is there some set of relevance regions that we'd observe changes to?

It might help if I knew more about what the wake-up triggers would be. Every player movement? Or is there some set of relevance regions that we'd observe changes to?

It's woken up whenever the relevance region is updated, by calling LocalChunkProvider.notifyRelevanceChanged(). In practice  that's every time the player moves.

@skaldarnar anything else blocking this?

Reactor contains Scheduler.immediate scheduler already

Good idea, thank you! I thought I had tried this but apparently I hadn't, because it seems to work.


Processor: Adjust handling of zero rewards to harvest

Problem
When a holder has no rewards to harvest, the program should ensure that their marginal rate (the current rewards per token minus their last seen rewards per token) is not diminished by attempting to harvest when they are not eligible for any rewards yet. This can occur when the marginal rate is too small to resolve to at least one lamport in eligible rewards.
Summary of Changes
This is a two-part solution. The first commit ensures the last seen rate is only updated when eligible rewards is non-zero. The second introduces an error when eligible rewards are zero.
We can remove the second commit if we don't feel it makes sense, but I felt like attempting to harvest rewards when you aren't eligible for any is a valid error case, and simulating such a transaction would save the caller on fees.

Makes sense to me! It would make sense to do the same on the transfer hook -- what do you think?

Good spot I missed the hook. I've also dropped the error.


Handle invalid IMDB ID returned by Kodi

Issue
I was not getting any OpenSubtitles results for a given movie using this add-on, despite getting results when using the website directly. I debugged a bit why this was the case and it looks like the IMDB ID sent to the OpenSubtitles API is incorrect. It is not an IMDB ID (example: tt14230458), but rather contains a TMDB (themoviedb.org) ID (example: 792307).
By removing the imdb_id query parameter from the OpenSubtitles request, I did get correct results.
Details
IMDB: https://www.imdb.com/title/tt14230458
TMDB: https://www.themoviedb.org/movie/792307-poor-things
last_meta.json:
{
  "year": "2023",
  "season": "",
  "episode": "",
  "tvshow": "",
  "tvshow_year": "",
  "title": "Poor Things",
  "filename": "Poor.Things.2023.2160p.WEB-DL.DDP5.1.Atmos.DV.HDR.H.265-FLUX.mkv",
  "filename_without_ext": "Poor.Things.2023.2160p.WEB-DL.DDP5.1.Atmos.DV.HDR.H.265-FLUX",
  "imdb_id": "792307",
  "filesize": "26944594060",
  "filehash": "c7f7ac5b8e18febb"
}

Request made by the add-on, no results:
curl  -X GET \
  'https://api.opensubtitles.com/api/v1/subtitles?query=Poor%20Things%202023&language=en&type=movie&imdb_id=792307&year=2023&moviehash=c7f7ac5b8e18febb' \
  --header 'Accept: */*' \
  --header 'User-Agent: a4kSubtitles v3' \
  --header 'Api-Key: 7IQ4FYAepMynq20VYYHyj5mVHtx3qvKa' \
  --header 'Authorization: Bearer [omitted]'

Modified request with valid results:
curl  -X GET \
  'https://api.opensubtitles.com/api/v1/subtitles?query=Poor%20Things%202023&language=en&type=movie&year=2023&moviehash=c7f7ac5b8e18febb' \
  --header 'Accept: */*' \
  --header 'User-Agent: a4kSubtitles v3' \
  --header 'Api-Key: 7IQ4FYAepMynq20VYYHyj5mVHtx3qvKa' \
  --header 'Authorization: Bearer [omitted]'

Relevant Kodi logs:
2024-03-21 09:54:23.226 T:2267994    info <general>: service.subtitles.a4ksubtitles: {
                                                     "year": "2023",
                                                     "season": "",
                                                     "episode": "",
                                                     "tvshow": "",
                                                     "tvshow_year": "",
                                                     "title": "Poor Things",
                                                     "filename": "Poor.Things.2023.2160p.WEB-DL.DDP5.1.Atmos.DV.HDR.H.265-FLUX.mkv",
                                                     "filename_without_ext": "Poor.Things.2023.2160p.WEB-DL.DDP5.1.Atmos.DV.HDR.H.265-FLUX",
                                                     "imdb_id": "792307",
                                                     "filesize": "26944594060",
                                                     "filehash": "c7f7ac5b8e18febb",
                                                     "is_tvshow": false,
                                                     "is_movie": true,
                                                     "imdb_id_as_int": 2307,
                                                     "languages": [
                                                       "English"
                                                     ],
                                                     "preferredlanguage": "English"
                                                   }
2024-03-21 09:54:23.235 T:2268019    info <general>: service.subtitles.a4ksubtitles: opensubtitles - [
                                                     {
                                                       "method": "GET",
                                                       "url": "https://api.opensubtitles.com/api/v1/subtitles",
                                                       "params": {
                                                         "query": "Poor Things 2023",
                                                         "languages": "en",
                                                         "type": "movie",
                                                         "imdb_id": "2307",
                                                         "year": "2023",
                                                         "moviehash": "c7f7ac5b8e18febb"
                                                       },
                                                       "headers": {
                                                         "User-Agent": "a4kSubtitles v3",
                                                         "Api-Key": "7IQ4FYAepMynq20VYYHyj5mVHtx3qvKa",
                                                         "Accept": "application/json",
                                                         "Content-Type": "application/json",
                                                         "Authorization": "Bearer [omitted]"
                                                       }
                                                     }
                                                   ]
2024-03-21 09:54:23.236 T:2268020    info <general>: service.subtitles.a4ksubtitles: GET ^ - https://api.opensubtitles.com/api/v1/subtitles, {"query": "Poor Things 2023", "languages": "en", "type": "movie", "imdb_id": "2307", "year": "2023", "moviehash": "c7f7ac5b8e18febb"}
2024-03-21 09:54:23.530 T:2268020    info <general>: service.subtitles.a4ksubtitles: GET $ - https://api.opensubtitles.com/api/v1/subtitles - 200,
2024-03-21 09:54:23.531 T:2268020    info <general>: service.subtitles.a4ksubtitles: {
                                                     "url": "https://api.opensubtitles.com/api/v1/subtitles",
                                                     "count": 0,
                                                     "status_code": 200
                                                   }

Further info I found:
The problematic call returning the TMDB ID instead of the IMDB ID is: https://github.com/a4k-openproject/a4kSubtitles/blob/4dbe9d42cb1500327ba84de0fbd230341f677429/a4kSubtitles/lib/video.py#L310
The OpenSubtitles add-on does not use IMDB ID and even has a message about confusing values being returned:
https://github.com/opensubtitlesdev/service.subtitles.opensubtitles-com/blob/master/resources/lib/data_collector.py#L19-L25
I've also found this comment on the Kodi forums post of the TMDB Python Scraper asking why the TMDB ID is returned for this call above, no response though: https://forum.kodi.tv/showthread.php?tid=344580&pid=3010078#pid3010078
This is the scraper that I am using, it's the default movies scraper available on my Kodi.
I think removing the usage of the IMDB ID should be fine.

I've provided a fix here, I've also adapted the PR description.

Thanks!


Typed actors?

Would it be possible to implement typed actors? I made a small example https://gist.github.com/Pireax/9e65b9188a188e2a35051c2708b837ed, this ignores the whole mailbox, threading, etc so it isn't an exact match but is it possible to implement such a thing? It would allow for safer code.

Typed artors are essentially channels I think http://doc.akka.io/docs/akka/2.3-M2/scala/typed-channels.html
Just use channels...
Hopefully soon we'll have a concurrency theory that unites pi calculus and the actor model.


Optimize calculations

Currently some functions, especially mulSubBoard() take a lot of time to execute, which leads to impossibility of calculating matrix inversions for big sizes. Need to optimize them.
Or at least, add some progress bar to see the progress of matrix inversion. And make it async.

Fixed with last PR.


root-level hooks are not being called partially fixed ref : #39

Hi,
Apologies for the late response wrt issue #39 . Thanks for taking a look and fixing it.
Appears this is partially fixed. When passing the individual file ( node_modules/.bin/mocha-parallel-tests tests/sample.js) it seems to work.
But if we give just the dir path (either node_modules/.bin/mocha-parallel-tests tests/ or node_modules/.bin/mocha-parallel-tests tests/*.js) it does not seem to call the root level hooks.

@tsdaita can you give a more detailed example? A failing test would be even better

The same code provided in the #39 can be used.
When passing the folder (node_modules/.bin/mocha-parallel-tests tests/ ) where both the test file and global hook file are present it does not print the statement from "base : before run!" from the base.js

Did you update mocha-parallel-tests to the latest version? The test here is exactly about your situation and it was fixed.

Hi,
Using the same set of files that I have provided in issue #39, and after
installing the updated version I still see the issue of the global hook not
being called when I pass the folder name. Here is the output.
%>npm install mocha-parallel-tests
└──<EMAIL_ADDRESS>extraneous
Scenario 1:
When invoking the command by passing the actual test file, you can observe
that the print statement from the global hook file is being printed.
%>./node_modules/mocha-parallel-tests/dist/bin/mocha-parallel-tests
tests/sample.js
base : before run!    /*** THIS from the base.js ***/
An afterEach hook
before run!
nested before run!
in some nested contexts

nested it run!
afterEach run!
  ✓ runs after this block

second nested it run!
afterEach run!
  ✓ runs again after this block

2 passing (16ms)
Scenario 2:
Now invoking the command by passing the folder containing the tests, you
can observe that the print statement from the global hook file is not being
printed.
%> ./node_modules/mocha-parallel-tests/dist/bin/mocha-parallel-tests tests/
An afterEach hook
before run!
nested before run!
in some nested contexts

nested it run!
afterEach run!
second nested it run!
  ✓ runs after this block

afterEach run!
  ✓ runs again after this block

2 passing (24ms)
On Fri, Jul 1, 2016 at 4:39 AM, Dmitry Sorin<EMAIL_ADDRESS>wrote:

Did you update mocha-parallel-tests to the latest version? The test here
https://github.com/mmotkina/mocha-parallel-tests/tree/master/test/global-hooks-require
is exactly about your situation and it was fixed.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/mmotkina/mocha-parallel-tests/issues/41#issuecomment-229925748,
or mute the thread
https://github.com/notifications/unsubscribe/AFYaykOAnHjD6WRZmIHtgcfcXwrx5XNrks5qRPx2gaJpZM4JBzxA
.

Oh, got it! The problem is about tests path. Will fix this in #42

Check out<EMAIL_ADDRESS>There's only one exception: console logs are not shown yet: https://github.com/mmotkina/mocha-parallel-tests/pull/43
@tsdaita


Remove Provider Interface

The provider interface can be removed, actually don't know why it even exists lmao

😂 yes pls


Consistent paging for Lucene queries to View queries

Following on from #145 it was pointed out that it would nice to have a consistent paging experience for Lucene queries and the View queries.
As mentioned in https://github.com/cloudant/java-cloudant/issues/145#issuecomment-158069098:

the differences are caused by the Lucene Search pagination being managed by the server providing a bookmark parameter whilst the (Couch) View paging is managed within the client.

We should consider how we might implement a similar experience using the bookmark token.

Hi, just wondering if there is a plan to include this enhancement any time soon?

Hi Cloudant folks... I am also wondering what the plan is for this enhancement. It would be really great if this could get implemented.
Thank you.

@DamianCummins @jcamilli thanks for the feedback. We don't have immediate plans to do this, but knowing that there is demand for it is very helpful and we will reconsider it when next planning.

Continuing to Damain and Jared posts (I belong to the same team), this requirement is becoming important for us, and would request to consider it for a soon-planning/implementation.
Advance Thanks,
Ravi Chamarthy

While some aspects of the view paging (e.g. being Iterable) can be applied to the query paging other aspects are not (e.g. "stateless" paging via  string token). The server currently does not allow for paging backwards from a bookmark token so it is not possible for us to reverse direction in the way we can with a view.
I am tagging this for a future version where it is possible that we can add similar style APIs to the View paging, but the token aspect will not be possible unless the server API changes.

The server API in CouchDB main has taken some steps towards bookmark based paging for views but still no unified pagination style across all query types. This isn't going to be resolved here before EOL - we'll revisit over in IBM/cloudant-java-sdk  if there are more changes to facilitate this.


playWhenReady: true

Hello everyone this bool : playWhenReady: true / false not working always the player autoplay

Thank for your comment I will check this issue as soon as possible.

Hello everyone this bool : playWhenReady: true / false not working always the player autoplay

We have already fixed this issue let's take a look at version 1.0.6 and feel free to reopen this issue if you still occur this issue


allow plugins to require('react')

Related to #619, this PR allows plugin authors to require('react') in their libraries without having to have react as a dependency, and helps avoid "multiple copies of react" errors.
It is a fairly hacky solution to patch the require function, I'm curious to hear if others have suggestions for an alternative implementation.

I would mock Module._load instead of the entire require 💭

I've updated to override _load per @matheuss's suggestion, let me know if other changes are necessary

Hey @mathisonian I'm sorry for the delay.
Module.prototype._load does not exists 😰 Can you change it to Module._load and rebase it? Then I think we can merge 😊

Updated 👍 thanks @matheuss

Thank you! :)


Multiple -f

Fixes #98. This changes some properties of Context (string ComposeFile to []string ComposeFiles and []byte ComposeBytes to [][]byte ComposeBytes) as well as Project (string File to []string Files).
Signed-off-by: Josh Curl<EMAIL_ADDRESS>

I don't think this handles merge the same way as compose. For one, it needs to merge extends, links and volumes_from, which is not done by `extends.

@dnephin If links and volume_from are merged with multiple files the same way as when using extends, I think this will support those. It definitely doesn't merge extends though. I'll address this.

@joshwget I like the approach, took me a bit to notice you are storing [][]byte.
@dnephin Is the merging behavior of extends documented?  From what I understand of this PR is if you do -f a.yml -f b.yml it will evaluate the extends in a.yml and b.yml before merging.  That seems like the correct behavior to me, but I'm not sure what docker-compose is actually doing.

That sounds right

@dnephin I think that addresses all of your original comments then, but please let me know if I missed something!

@joshwget According to the documentaiton compose looks by default for docker-compose.yml and an optionnal docker-compose.override.yml.

Thanks @vdemeester, should be addressed now!

Hum… doesn't seem to work as expected, I'm using the test/fixtures/multiple-composefiles files from the docker/compose project :
# With docker-compose
$ docker-compose -f docker-compose.yml -f compose2.yml up -d
Creating multiplecomposefiles_simple_1
Creating multiplecomposefiles_yetanother_1
Creating multiplecomposefiles_another_1
$ docker-compose -f docker-compose.yml -f compose2.yml ps
Name                  Command   State   Ports
-----------------------------------------------------------
multiplecomposefiles_another_1      top       Up
multiplecomposefiles_simple_1       top       Up
multiplecomposefiles_yetanother_1   top       Up

# With libcompose-cli on this PR
$ libcompose-cli -f docker-compose.yml -f compose2.yml up -d
WARN[0000] Note: This is an experimental alternate implementation of the Compose CLI (https://github.com/docker/compose)
INFO[0000] Project [multiple-composefiles]: Starting project
INFO[0000] [0/1] [yetanother]: Starting
INFO[0000] [1/1] [yetanother]: Started
$ libcompose-cli -f docker-compose.yml -f compose2.yml ps
WARN[0000] Note: This is an experimental alternate implementation of the Compose CLI (https://github.com/docker/compose)
Name                                Command  State          Ports
multiple-composefiles_yetanother_1  top      Up 29 seconds

It only picked that latest one and did no merge :sweat_smile:.

@vdemeester When I try reproducing your example I get results similar to Compose. Would you mind checking this again? :smile:

@joshwget you are right, I might have messed up, it's working as expected :stuck_out_tongue_closed_eyes: ; with docker-compose.override.conf and such.

@joshwget So far, so good :wink:. Few commands on code but it almost work as expected, that's cool :+1: :wink:.
I would add more integration though :

Using the default docker-compose.yml and docker-compose.override.yml
Pointing to one or several files without specifying the project name and verifying that the project name is named based on the first folder.

/ping @joshwget

Carrying into #140, thanks for the hard work @joshwget


Call sample directly

Move backend call logic here.

Codecov Report

Merging #160 into master will decrease coverage by 0.59%.
The diff coverage is 75.55%.

@@            Coverage Diff            @@
##           master     #160     +/-   ##
=========================================
- Coverage   95.63%   95.03%   -0.6%
=========================================
  Files          35       36      +1
  Lines        1672     1713     +41
=========================================
+ Hits         1599     1628     +29
- Misses         73       85     +12

Impacted Files
Coverage Δ

response_operations_ui/common/filters.py
62.5% <62.5%> (ø)

..._ui/controllers/collection_exercise_controllers.py
84.95% <69.23%> (-2.05%)
:arrow_down:

...se_operations_ui/controllers/sample_controllers.py
84.84% <83.33%> (-15.16%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d625611...b2571c4. Read the comment docs.

 Validate sample before loading to ensure no duplicate sampleunitref values exist

Codecov Report

Merging #160 into master will decrease coverage by 0.07%.
The diff coverage is 84.09%.

@@            Coverage Diff             @@
##           master     #160      +/-   ##
==========================================
- Coverage   95.63%   95.55%   -0.08%
==========================================
  Files          35       36       +1
  Lines        1672     1710      +38
==========================================
+ Hits         1599     1634      +35
- Misses         73       76       +3

Impacted Files
Coverage Δ

response_operations_ui/common/filters.py
100% <100%> (ø)

...esponse_operations_ui/views/collection_exercise.py
97.36% <100%> (+0.1%)
:arrow_up:

..._ui/controllers/collection_exercise_controllers.py
86.95% <60%> (-0.05%)
:arrow_down:

...se_operations_ui/controllers/sample_controllers.py
96% <94.11%> (-4%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e56a7c5...9404268. Read the comment docs.

 response-operations-ui should directly call sample service (not via backstage)


automatically create output directory if it doesn't exist

regier@deeplearning-01:~/bliss$ poetry run bliss +experiment=sdss_sleep
Error executing job with overrides: ['+experiment=sdss_sleep']
Traceback (most recent call last):
  File "/home/regier/bliss/bliss/main.py", line 16, in main
    task(cfg)
  File "/home/regier/bliss/bliss/train.py", line 60, in train
    assert Path(p).exists(), f"path {Path(p).as_posix()} does not exist"
AssertionError: path /home/regier/bliss/output does not exist

Set the environment variable HYDRA_FULL_ERROR=1 for a complete stack trace.

Still relevant; I've run into this issue too.


Framework or lib.a not found

Hi,
I want to use this library but I dont wanna use the pod or carthage, I want to include it as a framework or library, but I do not found any framework or library. Can you please guide me for this. I don't wanna include the whole code of your library.

I'm afraid we don't provide support for that. You can compile it locally and figure it out from there if you want, but we aren't able to help with it.


Adopting for OWIN support

Now this project compatible with Owin SelfHost and Owin WbHost

I have make small change for correct working with WebHost.

All good thanks again @AlexDovgan!


Move to a 2 branch system

with a master and a develop branch. commits get made to develop and develop gets merged into master every release

i think this is pretty high priority, i would rather not risk updating the master directory of meower every time a pr is closed. why not use beta.meower.org for the develop branch? that could be a good use of that domain...

should be pretty easy; just create a new branch and set it to the default, tell contributors and ask tnix or whoever manages the domains to set beta.meower.org to the new branch

i think tnix owns the domains, we'll also have to prevent merging directly to master with pr's

made develop branch, trying to get beta.meower.org as a domain for it

also we should probably make a CONTRIBUTING.md that contains info about contributing (probably moving the stuff in the README there) and about this system

mhm, making an announcement to team-announcements about this change

so i guess resolved


Merge 08-04-Set_up_test_Workflow into 08-04-Set_up_run_and_cleanup_functions_in_index.ts

Current dependencies on/for this PR:

main

PR #1

PR #2

PR #3

PR #4

PR #5

PR #6

PR #7   👈

This comment was auto-generated by Graphite.

Graphite Merge Job
Current status: 🔄 Waiting for checks to pass
This pull request is currently waiting for CI and mergeability checks to pass before being merged.
This comment was auto-generated by Graphite.

Job Reference: EFT94l5En3gXiVzw9vT4


Add support for changing the browser storage key prefix

What does this pull request change?
Updated the config, as well as the useBrowserStorage hook to accept a key prefix.
In the config defaults, functionality will remain the same as it is without this code change in order to maintain backwards-compatibility.
Why is this pull request needed?
Some developers may want/need the ability to change the storage key names
Issues related to this change
None

Hi 👋
Thanks for the PR!
What is your use case for this functionality? When will the default prefix not work?

Hi 👋 Thanks for the PR! What is your use case for this functionality? When will the default prefix not work?

I have a set of micro frontends that use the token in storage outside of the react context and we use different naming conventions than what ROCP currently uses for our current QA automated workflows. Internally we are using my fork but I wanted to contribute it as feature here as well.

Hmm okey, not sure I understand.
Could you please be a bit more explicit about why the default storage key won't work?
I just want to understand the problem 🙂

Thanks for the contribution :slightly_smiling_face:


Preparing 1.0.1

Wrapping up the 1.0.1 commit here.
@reactive-streams/contributors,
Planning on shipping on the 9th of August.
Includes https://github.com/reactive-streams/reactive-streams-jvm/pull/389 since 1.0.1-RC2
Sounds good?
√

:+1:


How to evaluate the performance?

System Info / 系統信息
cuda 12.1
pytorch 2.3.1
Who can help? / 谁可以帮助到您？
No response
Information / 问题信息

[X] The official example scripts / 官方的示例脚本
[ ] My own modified scripts / 我自己修改的脚本和任务

Reproduction / 复现过程
My test results are as follows, is this considered good or bad?
[2024-07-19 09:38:21,589] [INFO] [RANK 0]  validation loss at the end of training for test data | loss: 0.000000E+00                | PPL: 1.000000E+00 acc 5.319865E-02 | acc_w/o_case 5.319865E-02 |
Expected behavior / 期待表现
None

Can you run evaluate_cogagent_demo.py correctly without reporting an error?


builds for arm64

@rvantonder would you welcome a PR that builds releases for arm64? We're currently working on this at SG to get it integrated into our new bazel builds and building it in our tool chain is proving complicated.
I'd be happy to do the work and setup the PR.
Dave

hey @davejrt yes you're welcome to! did you have in mind to target with a build command, or adding a Dockerfile build? A Dockerfile for reference. Either way, go for it!

I can do both, ideally we just want to have an archive or a binary on this repo that we can download directly from the releases.


Enable Anisotropic filtering for textures where available

Using standard bilinear filtering for sprite textures in the manner that PIXI currently does, often leads to slightly blurry sprites when a sprite is scaled to a size that is inbetween two mipmaps.
Since part of our app is a WebGL powered photo editor, using PIXI, this is not ideal.  We have previously worked around this issue by modifying PIXI's sprite shader generator to set a negative mipmap LOD bias:
vec4 sample = texture2D(uSampler, vTextureCoord, -0.5);
This ensures that the sprite is always using a slightly higher resolution mipmap.
While this works fine, we have recently realised that WebGL now has good support for anisotropic filtering, which enables us to remove the negative LOD bias and always get perfectly sharp sprites.  Furthermore, performance is significantly better than our previous method since on modern GPU's, anisotropic filtering is pretty much free, or if not, the performance impact is absolutely miniscule.
Support for anisotropic filtering can be checked like so:
 var ext = (
                gl.getExtension('EXT_texture_filter_anisotropic') ||
                gl.getExtension('MOZ_EXT_texture_filter_anisotropic') ||
                gl.getExtension('WEBKIT_EXT_texture_filter_anisotropic')
            );

And can then be set on a per texture basis in the same manner as PIXI currently sets its current linear/nearest filtering in the Texture.minFilter function:
if(ext){
     var max = gl.getParameter(ext.MAX_TEXTURE_MAX_ANISOTROPY_EXT);
     var anisotropy_level = Math.min(this.anisotropic, max);
     gl.texParameterf(gl.TEXTURE_2D, ext.TEXTURE_MAX_ANISOTROPY_EXT, anisotropy_level );
}

Please note than in this example we have simply added an anisotropic property to the Texture object, which accepts values from 0-16.  We then check to see the maximum supported anisotropy level, and apply the chosen level or the highest supported value.
Also, in our hacked function, we only apply this technique if linear filtering is selected for a texture, and if mipmapping is enabled and allowed for said texture (since it wouldn't make any difference without mipmaps anyway).
It would be great to see this added into PIXI as the improvement in scaled sprites is hugely significant.
More info can be found here: https://developer.mozilla.org/en-US/docs/Web/API/EXT_texture_filter_anisotropic

Sounds like a fantastic addition, do you mind putting in a PR for this?

Can we maybe get this in v4 as well?
It seems that this is better solution instead of my PR (#5120) which also caused some problems (#5210).

So, I looked a bit into how anisotropic filtering works in WebGL and how to implement it in PIXI.
So the implementation would look like this:

add the anisotropic WebGL extension to the extensions obj in the ContextSystem
add a new setting in the settings called ANISOTROPIC_LEVEL (default value 16)
add a new variable called anisotropicLevel to the BaseTexture that by default will be set to the default ANISOTROPIC_LEVEL setting
add the logic for setting the anisotropic level after this line

const anisotropicExt = this.renderer.context.extensions.anisotropicFiltering;
if (anisotropicExt && texture.anisotropicLevel > 0 && texture.scaleMode === gl.LINEAR_MIPMAP_LINEAR) {
    const level = Math.min(texture.anisotropicLevel, gl.getParameter(anisotropicExt.MAX_TEXTURE_MAX_ANISOTROPY_EXT);
    gl.texParameterf(texture.target, anisotropicExt.TEXTURE_MAX_ANISOTROPY_EXT, level));
}

If this looks good, I will go ahead and make a PR for it.

What do you guys say?

I've just realized that this issue has been opened 2 years ago. I will go ahead and start a PR for this.

Any idea when this will be rolled out as part of a stable release?

5.1.0 probably within the next week ish? Not too long.

Cool. Thanks!


View name inconsistency

When using Evolutions plugin in dev mode it prepends name with dev_, however when using search it does not. Is there any way to create production view while running in dev mode?

Yes, as the evolution plugin is supposed to have different behavior based on the current environment to help you during development,  it tries to be smart about design doc names and impose the dev_ convention.
If you want to use the same convention with other APIs, you can use
bucket.docName("myAwesomeDoc")

and the behavior will be the same.


Axios auth refresh doesn't work with axios v1.1.3

Whenever i run a build it gives this Writable is not defined error.
I have downgraded axios to version 1.1.2 and it works fine.

I stopped working even on version 1.0.0

Whenever i run a build it gives this Writable is not defined error.

Perhaps you re missing 'stream' module inside your build
// node-modules/follow-redirects/index.js var Writable = require("stream").Writable;
Are you using Vite or Webpack? (I had a similar problem using Vite and needed to install polyfills.)

I have this same problem using Vite

Had the same issue, upgrade to axios 1.2.2 fixed it.
The refresh logic function was called when hitting a 401 but the response.config.headers.Authorization bearer token is not attached to the API call correctly. I got [Object object]: undefined and so the call failed again with 403...

i have the same problem when using Vite.

I've spent several hours looking for a solution, this problem is related to node modules. In my case it was 'url' and 'stream' modules.
I'm found this plugin https://github.com/voracious/vite-plugin-node-polyfills and it fixed problem.

Did anyone figure out a way to work around the problem I mentioned above?

Did anyone figure out a way to work around the problem I mentioned above?
@aichichang did the solution mentioned by @alex-moiseenko work for you?
My security team needs me to upgrade axios and I can't delay it anymore. Just realized it's exactly one year since my comment 😄 . Didn't expect this thread to be this quiet 🤪


Remove log from result

Hi again, when I analyze one file, the log: Analyzing 1 kotlin files: . is always appearing. There's any way to remove this?

Yep, it is one of the processors which gets loaded by default if you use DetektFacade.instance(settings)
Use
private val detektor = DetektFacade.instance(settings,RuleSetLocator(settings).load(),emptyList()) instead.

It works, thank you ! 👍


Help wanted adding a list

I would like to add the Hack-with-Github/Awesome-Hacking list, but have a couple problems.

It's not mine. Therefore I can't edit things like GitHub topics.
Incorrect formatting. Awesome-Hacking does not conform to most of the guidelines required to be on this list, but I don't feel comfortable redesigning their entire list just to have it here.
List of lists. Are lists of other lists of actual things accepted here? Can't really tell.

Thanks!

Fork it, change it, send in a pull request there. Or maybe raise an issue about it (first).

Hmmmm... seems more of a meta list to me (kind of like this list) than a list of awesome items.
There were also previous attempts at adding this list (see #597 for example).
And I know for a fact that these guys are cool and happy to receive contributions (for example, see https://github.com/Hack-with-Github/Awesome-Hacking/issues/2, https://github.com/Hack-with-Github/Awesome-Hacking/pull/3/, https://github.com/Hack-with-Github/Awesome-Hacking/pull/5), so I'm gonna go ahead and agree with @Jogai. You should raise the issue in their repository. :smile:


Casing error in topic in README.md

The example to run mosquitto_sub has a casing error in the topic, it currently reads
mosquitto_sub -p 1883 -t "1.0.0/LOC/SPoT_GPB/#"
I believe this should be
mosquitto_sub -p 1883 -t "1.0.0/LOC/SPOT_GPB/#"

@rwuttke I've updated the main page README.md and https://github.com/rksg/gpb_mqtt_sample_client/blob/master/mqtt_bridge_conf/mosquitto_bridge.conf.sample to reflect the correct settings.
I've also added additional hints to setting up the PSK and PSK-Identity in the file https://github.com/rksg/gpb_mqtt_sample_client/blob/master/mqtt_bridge_conf/mosquitto_bridge.conf.sample in README.md.
Kindly review and let us know if we could spruce it up some more to make it more helpful.

@yeongsheng-tan I've had a look at your additional changes.
The extra hints,

the website to do the conversion is very much appreciated
the clearer spelling out of the topics is definitely clearer

@rwuttke thank you for the prompt feedback.


Fixes compilation break on Windows

This doesn't fix all the tests or make binaries avaiable. It just makes
it possible to compile on windows.
See #105

on second thought I think this shouldn't be a PR as we shouldn't merge anything until there is CI to cover it. Even if e2e tests can't complete, yet due to missing binary, we can run unit tests

closing until ready


Small scale test data for local deployment

Hi, I'm interested in deploying MuMMI on the KAUST IBEX cluster. It is mentioned in the installation doc that there is a small set of test data. Is it now publicly available? If not, is it possible for me to somehow access it so that I can perform a test run?
Many thanks,
Roden

Again on lassen and on summit, we have created a small set of test data, which can be used to launch MuMMI at small scales. This (and the larger dataset) will be made public through NCI website. Until then, we can make this data available upon request.

I guess this line refers to the same data?

MUMMI_RESOURCES: additional resource files (please reach out to get access)

I guess this line refers to the same data?

MUMMI_RESOURCES: additional resource files (please reach out to get access)

Hi Roden, did setting the resources to the test data work for you?

Hi @CthangavUCI, It's a bit long time ago. I don't remember if I got a small test data. I guess not. And if my memory works well, mummi-ras relies on a scheduler other than slurm, which the supercomputer that I can access does not support. I have not gone through porting everything to slurm. So, I do not get a chance to get a run-through yet.


Terminal under OS X doesn't work

It seems that at the moment FileManager preferences have the instructions only for Windows. How do I set up it for OS X?

Oh, sorry, I haven't thought about OSX.
Do you know how to start a terminal from the terminal?

No. I tried to google it but without luck. Maybe this could help https://github.com/wbond/sublime_terminal.

Yep, I try google too, but without any success. sublime_terminal is an alternative. You can install it, I want to add a setting for each command in the side bar context menu to define if they're shown are not.
I tried to look at the code of sublime_terminal but because I cannot try on OS X, it's really hard to understand.
So, I hope this is only a temporary solution (using Terminal), but I'll keep you in touch.

Hello! It's been a while, but I found this (in here)
open -a Terminal

I guess the -a options means application, which would make sense. Could you please try?

Doesn't work. I get this error in the Sublime console:
FileNotFoundError: [Errno 2] No such file or directory: 'open -a Terminal'

Remember that you have access to $cwd in the cmd.


Move cloud vendor specific docs into their own folder.

Changes

Move cloud vendor specific docs into their own folder.
Submitter Checklist
As the author of this PR, please check off the items in this checklist:

[x] Has Docs included if any changes are user facing
[x] Has Tests included if any functionality added or changed
[x] Follows the commit message standard
[x] Meets the Tekton contributor standards (including
functionality, content, code)
[x] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
[ ] Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes
NONE

/lgtm

/lgtm


Add new Discrete Math book

Discrete Mathematics and its Applications (7th Edition) - by Kenneth H. Rosen

@zackharley hey Zack, thanks for send this PR, but I need to refuse your PR because the reviews on Amazon are really bad, sorry.

Wow, I hadn't realized they were that bad. Sorry about that @ericdouglas. I found it pretty useful for the discrete math course I took this past year, but I guess I'm in a minority on that one.


Exclude pre-releases from "latest tag" selection in install/upgrade

Closes https://github.com/marwanhawari/stew/issues/44.
Detect "pre-release" releases and default to installing/upgrading to the latest non-prerelease version.
Install
Before
./stew install syncthing/syncthing
syncthing/syncthing
⬇  Downloading asset: 100% |███████████| (11/11 MB, 3.3 MB/s)
✅ Downloaded syncthing-macos-arm64-v1.28.0-rc.3.zip to /Users/hugo/.local/share/stew/pkg

After
./stew install syncthing/syncthing
syncthing/syncthing
⬇  Downloading asset: 100% |████████████| (10/10 MB, 12 MB/s)
✅ Downloaded syncthing-macos-arm64-v1.27.12.zip to /Users/hugo/.local/share/stew/pkg

Upgrade
Note: syncthing 1.27.12 was installed before running "upgrade"
Before
./stew upgrade syncthing
syncthing
⬇  Downloading asset: 100% |███████████| (11/11 MB, 9.6 MB/s)
✅ Downloaded syncthing-macos-arm64-v1.28.0-rc.3.zip to /Users/hugo/.local/share/stew/pkg

After
./stew upgrade syncthing
syncthing
Error: The latest tag v1.27.12 is already installed

Awesome, I'll review this over the weekend!


fix(config): expose configuration via rxjs exports

We weren't exposing configuration in a meaningful way from the rxjs module, this remedies that

Coverage increased (+0.0004%) to 97.544% when pulling acce22978c75582e4d5df6c4e6a9a5f0456a820c on benlesh:expose-config into dd7c9f1929c9a9314dc27128d847fc660f96435e on ReactiveX:master.


Merging dev branch for solution v.1

Merge the v1 solution for the asked question in my forked repository.

No conflicts, code works. Merging.


Replaced Closure type hint in the DomCrawler component

Merge symfony/symfony#14293 into symfony/symfony#14330

Thanks, merged and rebased.


Wrong biome tag for Frozen Peaks (typo)

Describe the bug
In the biome filter docs: creator/Reference/Content/EntityReference/Examples/Definitions/NestedTables/biome_filter.md
The Tagged Biomes table shows that Frozen Peaks has the "mountain" tag. Instead, it has the "mountains" tag.
Expected behavior
Replace the typo.

The same typo exists for Snowy Slopes. The docs read "mountain", but the actual biome tag is "mountains".

I see it was already fixed for those two, but it needed to be fixed for Cherry Grove, Grove, Jagged Peaks, Meadow, and Stony Peaks.
Thank you for your help! The changes will be apparent after the next document push.
-Nurdle


Frame data has incorrect size (is larger)

Hi! I'm having fun with MKVs, using your crate to demux some of them and extract data. But I noticed that, for a subtitle track from a MKV that is 120MB, it used like 1GB of RAM (which is insane).
So decided to take a look on the first block of the subtitle he crate read and inspect the binary:

In the above screenshot, I selected the contents of the block, the rest is useless data (probably data from other read frames for what I can see). The file size is 484786 bytes, which is reaaaaally huge for a frame of subtitles.
Then, I decided to take a look into your code and I found this piece of code:
https://github.com/hasenbanck/matroska-demuxer/blob/e137a084f0eac7acc0d2fc092e53181c88246606/src/lib.rs#L1564
I decided to modify your code a bit with this steps:

Added a new field in Frame with the size: pub size: usize https://github.com/hasenbanck/matroska-demuxer/blob/e137a084f0eac7acc0d2fc092e53181c88246606/src/lib.rs#L65
Added a new line after this frame.size = size; https://github.com/hasenbanck/matroska-demuxer/blob/e137a084f0eac7acc0d2fc092e53181c88246606/src/lib.rs#L1573

And tried the same code I have but using a slice of data: &frame.data[0..frame.size], and now I have the following binary output:

I think my solution is just a fast workaround to get things done, but ultimately I would like to have a proper way to grab the right data from it. I hope my issue and investigation helps a bit :)
Thanks for the crate!

Could you test the PR I uploaded?

Hi, with the PR it seems to work fine. Thanks!


Flash attention not improves the inference speed for decoder models

Tried the mistral 7b model inference with flash attention and without flash attention as below
import torch
from transformers import AutoModelForCausalLM, AutoTokenizer
device = "cuda"
model_with_flash = AutoModelForCausalLM.from_pretrained(
     "mistralai/Mistral-7B-v0.1",
    torch_dtype=torch.float16,
    attn_implementation="flash_attention_2")
model_with_flash.to(device)

model_without_flash = AutoModelForCausalLM.from_pretrained(
    "mistralai/Mistral-7B-v0.1",
    torch_dtype=torch.float16,
)
model_without_flash.to(device)
tokenizer = AutoTokenizer.from_pretrained("mistralai/Mistral-7B-v0.1")
prompt = "My favourite condiment is"
model_inputs = tokenizer([prompt], return_tensors="pt").to(device)

import time
start = time.time()
generated_ids = model_without_flash.generate(**model_inputs, max_new_tokens=100, do_sample=True)
end = time.time()
print(tokenizer.batch_decode(generated_ids)[0])
print("time taken ",end-start)

start = time.time()
generated_ids = model_with_flash.generate(**model_inputs, max_new_tokens=100, do_sample=True)
end = time.time()
print(tokenizer.batch_decode(generated_ids)[0])
print("time taken ",end-start)

and here is the output
<s> My favourite condiment is without doubt, mayonnaise. A bit of an addiction. My parents were a little concerned.

I’m a classic mayo kinda girl. A dash of Tabasco and there’s no stopping me.

There was that phase when I used to put mayo inside my sandwiches (a habit that was broken back in high school when the food tech teacher banned it). I then discovered how wonderful it was when mixed with my pasta (still do) and then
time taken 3.065387487411499

<s> My favourite condiment is without doubt, mayonnaise. A bit of an addiction. My parents were a little concerned.

I’m a classic mayo kinda girl. A dash of Tabasco and there’s no stopping me.

There was that phase when I used to put mayo inside my sandwiches (a habit that was broken back in high school when the food tech teacher banned it). I then discovered how wonderful it was when mixed with my pasta (still do) and then
time taken 3.07542353211499

Flash attention seems not to help improve the inference speed nor decrease the inference latency.
Is there any change in the method I followed?
versions
Python 3.8.16
cuda 12.2
A100 GPU
flash-attn==2.5.6

You're getting 30 tokens / sec on a 7B model on an A100, far from optimal. That means that your bottleneck is elsewhere and making attention faster (with FlashAttention) is not gonna make a difference.

@tridao
So what should I reconfigure to get the optimal speed?
Is the A100 GPU or the 7B model?

You can take a look at gpt-fast: https://github.com/pytorch-labs/gpt-fast

@tridao
I need to improve the inference speed of the mistral model, and I am referring to the official documentation from Hugging Face - https://huggingface.co/docs/transformers/perf_infer_gpu_one
Even I followed the steps in the official documentation, still why the model does not improve the inference speed?

Sorry I don't do consulting, and not over github issues.


ZMQSocket.socketActivity() keeps getting write notifications

Hi Jonnydee,
When I create a SUB socket on tcp (either localhost or ip) I get continuous notifications on the socketActivity() slot, this prevents QTimer from running correctly.
The source of the continuous calls is in the socketNotifyWrite_ notifier. Inside this call to socketActivity flags() always returns 0 and socketActivity() will be called again immediately flooding the event loop.
I made a small modification to the source to prevent this by disabeling the notifier when flags() returns 0 and enabeling it again if sending fails because sending would block.
Regards,
Jelle

Hello Jelle,
thank you very much for your bugfix. I've integrated it into my repo.
Best regards,
Jonny
Am 08.12.2011 um 00:12 schrieb JelleHissink:

Hi Jonnydee,
When I create a SUB socket on tcp (either localhost or ip) I get continuous notifications on the socketActivity() slot, this prevents timers from running correctly.
The source of the continuous calls is in the socketNotifyWrite_ notifier. flags() returns 0 and will be called again.
I made a small modification to the source to prevent this by disabeling the notifier when flags() returns 0 and enabeling it again if sending fails because sending would block.
Regards,
Jelle
You can merge this Pull Request by running:
git pull https://github.com/JelleHissink/nzmqt master
Or you can view, comment on it, or merge it online at:
https://github.com/jonnydee/nzmqt/pull/1
-- Commit Summary --

Disabled QSocketNotifier for writing when nothing is written

-- File Changes --
M include/nzmqt/nzmqt.hpp (835)
-- Patch Links --
https://github.com/jonnydee/nzmqt/pull/1.patch
https://github.com/jonnydee/nzmqt/pull/1.diff

Reply to this email directly or view it on GitHub:
https://github.com/jonnydee/nzmqt/pull/1

Thanks for merging the change back!
Best regards,
Jelle


PedersenCommitment blackbox function should allow the point at infinity as an output

Consider the code:
 let pedersen_commitment_to_zero = std::hash::pedersen_commitment([0]);
println(pedersen_commitment_to_zero);

executing this code gets the panic
% nargo execute   ~/noir/test_programs/execution_success/pedersen_check gd/issue_4931 + tom-box
The application panicked (crashed).
Message:  should not commit to point at infinity
Location: acvm-repo/bn254_blackbox_solver/src/lib.rs:48

This is because we assume that the pedersen commitment returns a point which lies on the curve
https://github.com/noir-lang/noir/blob/070d7e71d6587679721437dd5b996478bd17ed85/acvm-repo/bn254_blackbox_solver/src/lib.rs#L47-L50
We should update this blackbox function so it has 3 return witnesses so that we can represent the point at infinity.

This is resolved by #5221

this opcode no longer exists.


Update to the Beginner's Cookbook

@gino-m
Fixed the flow of the example scripts by breaking them up, corrected some typos, added links to the scripts again to make it convenient to follow, added a few more figures from the examples, and added a small section on reducers.

@TC25 please be sure to resolve merge conflicts as well (see "Resolve conflicts" below).

I am just seeing changes based on what I added.

Thanks for all the edits, TC! It seems you may have started editing without refreshing your fork with the latest from upstream, so you have a few merge conflicts. Please resolve those so we can merge. Thanks!

@gino-m I think that's everything.

@gino-m
Sorry, I just noticed that for the images showing intersection, difference, and union, the text for intersection and difference were swapped. What is the easiest way to fix it? Can you do it?


Try ClimaTimesteppers branch

This PR tries out https://github.com/CliMA/ClimaTimeSteppers.jl/pull/190

superseded by #2187.


"Cândești-Deal", "Dragodănești", "Valea Mare" are listed in the drop-down menu

Description:
When user writes ”Cândești-Deal”, "Dragodănești" and "Valea Mare" the locations appear in the drop-down menu next to the comune and the county which is a part according to the law.
Precondition:
The website is up an running.

Step 1
Write in the search bar "Cândești-Deal"

Expected results
The location appears in the drop-down menu as "Sat Cândești-Deal, DÂMBOVIȚA (Cândești)".

Step 2
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 3
Write in the search bar "Dragodănești"

Expected results
The location appears in the drop-down menu as "Sat Dragodănești, DÂMBOVIȚA (Cândești)".

Step 4
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 3
Write in the search bar "Valea Mare"

Expected results
The location appears in the drop-down menu as "Sat Valea Mare, DÂMBOVIȚA (Cândești)".


Why is training so slow and GPU utilization so low?

Why is training so slow and GPU utilization so low?

maybe you don't use your GPU to train


Trying to run eslint on non-existant folder

When using master version (commit 598c499f260596c3e94adab15677db44c8d37039 - not the npm package)

@ghamaide you had the same issue, did you?


Run dependabot cli for my local branch

Issue
We only have the budget to include advanced security features to test our vulnerabilities if we release our code to production (aka default branch).
So, I would like to test the dependable CLI against a local copy of my repository before creating my pull requests.
Is this doable? If it is, how can I run it?
Note: Due to security policies, I don't want to expose any credentials on the run.

You can do dependabot update <ecosystem> <org>/<name> --local . and the CLI will load the given directory (. in this case) and use it as the repository. We use the local flag to test without having to push up the changes to GitHub sometimes.
I can't guarantee it will work for every ecosystem as I haven't tested that will all of them, but if you run into problems you're welcome to file an issue.

Thanks for sharing this, @jakecoffman. I saw it working locally even when I used it in a repository outside the organisation or the wrong repository, so it solved this issue.
I have a couple of questions regarding the command and the output.

What is the reason behind using organisation and name for a local test? I am concerned that the CLI may use local GitHub credentials to reach out to the organisation
Could it be customised the final report to include the severity?

Note: I closed the ticket as the questions are unrelated to this issue

It would probably work with a fake org and name. The Dependabot CLI will try to automatically use a credential stored in the environment variable LOCAL_GITHUB_ACCESS_TOKEN, so if that isn't present it won't attempt to use credentials.
The CLI and Updater don't make any calls to the GitHub Advisory Database, so finding advisories and their severity would have to be something scripted after the CLI runs.
Good luck!

That was helpful, thanks @jakecoffman.


moving the sagsettings to main

Hi Neil, there are still a couple of issues we need to solve with the SAG settings but I decided to merge and resolve the conflicts today. If you can review the pull request we can merge onto main and then on release and update the app on the server before next week's meeting.


Some enums updated

Some of the enums have updated with the new release of the OpenAPI spec files.
For example the ActivityModeType now includes Raid and TrialsOfTheNine; however, these updates are not reflected in enums.ts.

I updated the ActivityModeType as well as checked for other changes of the enums which are currently used.


K8s Migration: Containerize Services

Services to containerize

[x] backend-next: Website Next Backend
[ ] frontend-v2: Website v2 Frontend
[x] widget-backend: Widget Backend

[x] widget-docs: Widget Docs
[x] widget-frontend: Widget Frontend

[x] planner: Planner Backend
[x] probe: Probe Service

[x] prometheus: Prometheus DB
[x] grafana: Grafana Dashboard

frontend-v2 is the only piece missing now. Planning to do it todayz

g哦，你打算怎么containerize前端

g哦，你打算怎么containerize前端

Self-contained nginx/caddy seems to be the convention across implementations as they also decouples potential wanted CORS related server configurations :D

frontend-v2 containerization completed. closing


Wifi breaks after reboot then nixos-rebuild won't work (rpi4)

Hi Roberto,
I almost got NixOS working on my Raspberry Pi 4B with 4GB RAM.  I uncommented DISABLE_ZFS_IN_INSTALLER: "y" in docker-compose.yml.  Here is sd-image.nix:
{ lib, ... }: {
  imports = [
    # Select your destination system here. Available choices are:
    # - generic-aarch64
    # - rpi3 (alias for generic-aarch64)
    # - rpi4
    ./rpi4
  ];

  boot.kernelParams = [
    "cma=64M"
    "console=ttyS0,115200n8"
  ];

  # The installer starts with a "nixos" user to allow installation, so add the SSH key to
  # that user. Note that the key is, at the time of writing, put in `/etc/ssh/authorized_keys.d`
  users.extraUsers.nixos.openssh.authorizedKeys.keys = [
    "ssh-rsa ..."
  ];

  # bzip2 compression takes loads of time with emulation, skip it. Enable this if you're low
  # on space.
  sdImage.compressImage = false;

  # OpenSSH is forced to have an empty `wantedBy` on the installer system[1], this won't allow it
  # to be automatically started. Override it with the normal value.
  # [1] https://github.com/NixOS/nixpkgs/blob/9e5aa25/nixos/modules/profiles/installation-device.nix#L76
  systemd.services.sshd.wantedBy = lib.mkOverride 40 [ "multi-user.target" ];

  # Enable OpenSSH out of the box.
  services.sshd.enabled = true;

  # Wireless networking (1). You might want to enable this if your Pi is not attached via Ethernet.
  networking.wireless = {
   enable = true;
   interfaces = [ "wlan0" ];
   networks = {
     "ssid1" = {
       psk = "...";
     };
   };
  };

  # Wireless networking (2). Enables `wpa_supplicant` on boot.
  systemd.services.wpa_supplicant.wantedBy = lib.mkOverride 10 [ "default.target" ];

  # NTP time sync.
  #services.timesyncd.enable = true;
}

I built the installer image, copied it to the SD card, and used it to boot the rpi4.  Wifi worked!  I used SCP to copy over this file to /etc/nixos/configuration.nix:
# https://nixos.org/nixos/manual/options.html
{ config, pkgs, lib, ... }:
{
    boot.loader.grub.enable = false;
    boot.loader.raspberryPi.enable = true;
    boot.loader.raspberryPi.version = 4;
    boot.kernelPackages = pkgs.linuxPackages_rpi4;
    boot.kernelParams = ["cma=64M" "console=ttyS0,115200n8"];
    fileSystems = {
        # There is no U-Boot on the Pi 4 (yet) -- the firmware partition has to be mounted as /boot.
        "/boot" = {
            device = "/dev/disk/by-label/FIRMWARE";
            fsType = "vfat";
        };
        "/" = {
            device = "/dev/disk/by-label/NIXOS_SD";
            fsType = "ext4";
        };
    };
    swapDevices = [{ device = "/swapfile"; size = 1024; }]; # MB
    networking.hostName = "rpi4";
    networking.wireless = {
        enable = true;
        interfaces = ["wlan0"];
        networks = {
            "ssid" = { psk = "psk"; };
        };
    };
    systemd.services.wpa_supplicant.wantedBy = lib.mkOverride 10 [ "default.target" ];  # For wireless.
    time.timeZone = "America/Los_Angeles";
    services.timesyncd.enable = true;
    services.openssh.enable = true;

    #security.sudo.wheelNeedsPassword = false; # Uncomment or set users.users.*.hashedPassword

    # https://nixos.wiki/wiki/FAQ/When_do_I_update_stateVersion
    system.stateVersion = "20.03";

    nix.gc.automatic = true;
    nix.gc.options = "--delete-older-than 30d";

    # To see the dependency tree for system packages:
    # $ nix-store -q --tree /run/current-system/sw
    environment.systemPackages = with pkgs; [
        emacs-nox
        htop
        nano
        nload
    ];

    users.users.user = {
        isNormalUser = true;
        home = "/home/user";
        extraGroups = ["wheel"];  # Allow using sudo
        openssh.authorizedKeys.keys = [
            "ssh-rsa ..."
        ];
        hashedPassword = "...";
    };
}

I logged in with SSH and ran sudo nixos-rebuild switch and rebooted.  Wifi failed to start.  This seems like an instance of https://github.com/NixOS/nixpkgs/issues/82462 .  I tried spent several hours trying to fix it.  Unfortunately, nixos-rebuild switch fails.
[user@rpi4:~]$ sudo nixos-rebuild switch
[sudo] password for user:
building Nix...
building the system configuration...
these derivations will be built:
  /nix/store/7zlnrgw02w24ryxc0hbkih3ylgc29kjw-system-units.drv
  /nix/store/msddg2q6n4s3fpc5fd0mqvhjrapgf3jj-etc.drv
  /nix/store/5a2y00hc3r9gfb4k6x16z3a013v3p1hk-nixos-system-rpi4-20.03post-git.drv
these paths will be fetched (0.01 MiB download, 0.02 MiB unpacked):
  /nix/store/wim4b0fv3yi2a30yxyh8ya2g9cag1wxn-lndir-1.0.3
copying path '/nix/store/wim4b0fv3yi2a30yxyh8ya2g9cag1wxn-lndir-1.0.3' from 'https://cache.nixos.org'...
warning: unable to download 'https://cache.nixos.org/nar/0wn10n5akd3zxdph5bygjm2m3x971khgk2lcjxxdjwsrwyb48bd8.nar.xz': Couldn't resolve host name (6); retrying in 306 ms
warning: unable to download 'https://cache.nixos.org/nar/0wn10n5akd3zxdph5bygjm2m3x971khgk2lcjxxdjwsrwyb48bd8.nar.xz': Couldn't resolve host name (6); retrying in 553 ms
warning: unable to download 'https://cache.nixos.org/nar/0wn10n5akd3zxdph5bygjm2m3x971khgk2lcjxxdjwsrwyb48bd8.nar.xz': Couldn't resolve host name (6); retrying in 1038 ms
warning: unable to download 'https://cache.nixos.org/nar/0wn10n5akd3zxdph5bygjm2m3x971khgk2lcjxxdjwsrwyb48bd8.nar.xz': Couldn't resolve host name (6); retrying in 2172 ms
unable to download 'https://cache.nixos.org/nar/0wn10n5akd3zxdph5bygjm2m3x971khgk2lcjxxdjwsrwyb48bd8.nar.xz': Couldn't resolve host name (6)
cannot build derivation '/nix/store/7zlnrgw02w24ryxc0hbkih3ylgc29kjw-system-units.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/msddg2q6n4s3fpc5fd0mqvhjrapgf3jj-etc.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/5a2y00hc3r9gfb4k6x16z3a013v3p1hk-nixos-system-rpi4-20.03post-git.drv': 1 dependencies couldn't be built
error: build of '/nix/store/5a2y00hc3r9gfb4k6x16z3a013v3p1hk-nixos-system-rpi4-20.03post-git.drv' failed

Apparently, there is no way to update a NixOS installation without Internet access.
Learning the way NixOS configures networking is not enough.  If networking ever fails, to fix it one must also learn how NixOS itself sets up the underlying networking config.  Or reboot from installation media, which is not possible on rpi4.
This is exactly why I don't want to rebuild my system after install.  I want to have one system config, not two.
I don't see how I can continue using NixOS on my rpi4.  I've already spent several hours on this issue.
Good luck with this project.
Best,
Michael

FYI: I still have to read everything but I noticed you left your Wi-Fi data in the second config -- I have censored it and removed it from your issue's history!

Fortunately, the ethernet port still works, with no special config.  And I have connected through the serial console.

Okay, I read everything. First off - I'm incredibly sorry that you had so many issues :( NixOS clearly is still growing and the lack of a comprehensive place where to find docs / troubleshooting info can be frustrating. I experienced this first hand when trying to build an image for my Pi, and it eventually lead me to create this repo. Sometimes it just requires loads of tinkering until you get it working and I understand how that can be incredibly annoying.
That being said, thanks for sharing your experience. I don't have first hand experience with WLAN on my Pi (which is a 3B+, by the way) as I'm using Ethernet, and I'm sure you have tried everything. I want to help you though, so first things first I want to understand what makes it work on the installer and what not. Have you tried enabling hardware.enableRedistributableFirmware = true;? It is enabled by default in the installer and not in the production system, and it contains WiFi drivers.
Also, it should be safe to remove systemd.services.wpa_supplicant.wantedBy = lib.mkOverride 10 [ "default.target" ];  # For wireless. as that is only changed within the installation device.
I completely understand if you just want to burn NixOS and don't wanna troubleshoot anymore, so feel free to just say that if that's the case. Again, thanks for considering the use of this repo!
Have a good day,
Roberto

Setting hardware.enableRedistributableFirmware = true; fixed the wifi!  I rebooted three times to confirm.  Thank you!
Here is my working /etc/nixos/configuration.nix:
# https://nixos.org/nixos/manual/options.html
{ config, pkgs, lib, ... }:
{
    boot.loader.grub.enable = false;
    boot.loader.raspberryPi.enable = true;
    boot.loader.raspberryPi.version = 4;
    boot.kernelPackages = pkgs.linuxPackages_rpi4;
    boot.kernelParams = ["cma=64M" "console=ttyS0,115200n8"];
    hardware.enableRedistributableFirmware = true;  # Includes wifi kernel modules.
    fileSystems = {
        # There is no U-Boot on the Pi 4 (yet) -- the firmware partition has to be mounted as /boot.
        "/boot" = {
            device = "/dev/disk/by-label/FIRMWARE";
            fsType = "vfat";
        };
        "/" = {
            device = "/dev/disk/by-label/NIXOS_SD";
            fsType = "ext4";
        };
    };
    swapDevices = [{ device = "/swapfile"; size = 1024; }]; # MB
    networking.hostName = "rpi4";
    networking.wireless = {
        enable = true;
        interfaces = ["wlan0"];
        networks = {
            "ssid" = { psk = "..."; };
        };
    };
    time.timeZone = "America/Los_Angeles";
    services.timesyncd.enable = true;
    services.openssh.enable = true;

    #security.sudo.wheelNeedsPassword = false; # Uncomment or set users.users.*.hashedPassword

    # https://nixos.wiki/wiki/FAQ/When_do_I_update_stateVersion
    system.stateVersion = "20.03";

    nix.gc.automatic = true;
    nix.gc.options = "--delete-older-than 30d";

    # To see the dependency tree for system packages:
    # $ nix-store -q --tree /run/current-system/sw
    environment.systemPackages = with pkgs; [
        emacs-nox
        htop
        nano
        nload
    ];

    users.users.user = {
        isNormalUser = true;
        home = "/home/user";
        extraGroups = ["wheel"];  # Allow using sudo
        openssh.authorizedKeys.keys = [
            "ssh-rsa ..."
        ];
        hashedPassword = "...";
    };
}

This is great news, thank you for confirming! I'll amend the README and example configuration right now to include that so that no one has to struggle again.


Student grade summary enhancements

As per minutes from the call:

Get rid of item weights in weight column, but show the category weight
Status icons should show up just to the right of the item
Condense to 70% width
Keep “Next Student/Previous Student” visible and scroll inside of it
Pull Course Grade value closer to the label
normal lightbox treatment when in “Grade Summary,” Sexy Shower Glass, when in “Student Review Mode”.

All delivered in PR #183.
Re: " Sexy Shower Glass" -- I have a lovely, even sexy, solution that works nicely in Firefox, Chrome and Safari (https://github.com/steveswinsburg/gradebookNG/compare/master...payten:bringing-sexy-back).  Unfortunately IE versions 9-11 don’t support the CSS blur filter, and with that, the sexiness is sunk.  As such, we'll retain the opaque dark mask when the student view is selected.

Hi @payten ,
This is looking great. The page width, layout, iconography all look great. A few things I noticed:

The weighting for the category is displaying in parentheses next to the category name, while the current subtotal is displaying under the "Grades" column: http://www.screencast.com/t/0kkqcezuQs. Wondering if this might be confusing. Would it make more sense to reintroduce a "Weight" column, to the left of "Grades," which would only show the category weighting, not the item weighting?

In your comment re: the sexy shower glass, are we saying that, because the blur does does not work in IE 9-11, we should stick with the existing dark mask? I know that IE's been replaced in Windows 10 (with Edge?), and I'm wondering if the CSS would be supported there. Since IE's always been a bit of a problem child, is it possible to use the blur for browsers that support it, and default back to the dark mask for the ones that don't?

As referenced in PR #66 , is it possible to introduce an additional confirmation lightbox window that opens on top of the "Student Review" mode when you try to exit out, letting you know that you're about to surface other students' grades?

Re: weighting - yep can pull that column back in.  And that column would be blank for grade item rows?
Re: shower glass - I've created an issue to investigate a mechanism to target CSS to IE9-11 #193 and therefore support a reasonable fallback.  Unfortunately, in implementing Edge for IE10 and 11, they decided to drop support for the old IE filters (including a blur feature) but are yet to provide a replacement (http://www.broken-links.com/2013/11/20/cross-browser-filters-css-svg/) - IE continues to frustrate web developers everywhere!  Btw, this is how it would look in Chrome:

re: close confirmation - I'm not sure about that one, as the modal close action is controlled by Wicket I might need @steveswinsburg to help with this one.  Perhaps we can create a separate issue for this requirement?

I am pretty sure we can open another window on closing, however the
original window would be closed, I dont think we could hook all of the
callbacks in. The simplest way would just be a standard javascript confirm
though.
The other option is to just use one modal for it all, and completely
replace the contents of the first modal window with a confirmation screen,
and then if they click OK, then close it, otherwise load the first panel
contents back in.
On Fri, Aug 21, 2015 at 9:14 AM, Payten Giles<EMAIL_ADDRESS>wrote:

Re: weighting - yep can pull that column back in. And that column would be
blank for grade item rows?
Re: shower glass - I've created an issue to investigate a mechanism to
target CSS to IE9-11 #193
https://github.com/steveswinsburg/gradebookNG/issues/193 and therefore
support a reasonable fallback. Unfortunately, in implementing Edge for IE10
and 11, they decided to drop support for the old IE filters (including a
blur feature) but are yet to provide a replacement (
http://www.broken-links.com/2013/11/20/cross-browser-filters-css-svg/) -
IE continues to frustrate web developers everywhere! Btw, this is how it
would look in Chrome:
[image: screen shot 2015-08-21 at 8 58 41 am]
https://cloud.githubusercontent.com/assets/608337/9397729/fbabe9da-47e2-11e5-9c8b-53fac3eac923.png

re: close confirmation - I'm not sure about that one, as the modal
close action is controlled by Wicket I might need @steveswinsburg
https://github.com/steveswinsburg to help with this one. Perhaps we
can create a separate issue for this requirement?

—
Reply to this email directly or view it on GitHub
https://github.com/steveswinsburg/gradebookNG/issues/186#issuecomment-133208881
.

Hi @payten ,
Just to clarify on where the weight column would appear - GB1 displays it after the "Grade" column:
http://www.screencast.com/t/0XtNHXUjfC
And yes, the items would display as blank, with a percentage appearing at the category-level.

PRs have been submitted for weight column and blur effect.
I've created a new issue as I don't think students currently don't have permission to access category score and weight data from the Gradebook service: #202.

Hi @payten ,
Looks absolutely fantastic. Love the blurring effect, the placement of the weight column, and the close confirmation. A few quick things:

Looks like there's a little bit of visual weirdness occurring with the comments rows when in Student Review Mode:

Can we change the language of the close confirmation dialog box to:
Unreleased grades and other students' data will become visible.

Additionally, it currently looks like the close confirmation appears when a) clicking the "Done" button, and b) selecting the "x" icon in the upper right. Would it be possible to also have it appear when we click the "Grade Summary" link to go back into the instructor review mode? For this particular case, when clicking "Continue" on the confirmation message, you would be taken back to "Grade Summary" screen for that student, rather than the main spreadsheet.

Confirmed!


ADR 109: Internalize specific packages to reduce surface area

Partially addresses #1484, based on #1483.
One concern I have is around the possibility that this PR internalizes certain types that are present in publicly accessible function signatures as parameters or return types. This will take some work to address.

I've already confirmed that the linter being run on the Cosmos SDK main branch doesn't pick up any missing code-related issues at this point.

This PR currently internalizes about 64k lines of code.

PR checklist

[ ] Tests written/updated
[x] Changelog entry added in .changelog (we use unclog to manage our changelog)
[ ] Updated relevant documentation (docs/ or spec/) and code comments

Regarding the use of internal structures as parameters and results in public API, isn't that detected by the linter?

It seems not. See https://github.com/cometbft/go-internalized-example


fix: use the correct GIT_SYNC_MAX_SYNC_FAILURES envvar

What issues does your PR fix?
What does your PR do?
GIT_SYNC_MAX_SYNC_FAILURES is correct env variables. Please refer https://github.com/kubernetes/git-sync#parameters.
Checklist

[x] Commits are signed
[ ] Commits are squashed (only do this if appropriate)
[ ] Chart version bumped (only do this if releasing a new version)
[ ] Chart documentation updated
[x] Passes linting

@kloty thanks!
I will put this in the queue to merge for the next release.


InsecureRequestWarning flooding logs

First off, many thanks for your work! Got my VR200 implemented into HA with ease thanks to it 👍
But after setting everything up, the core logs are being flooded with:

  warnings.warn( /usr/local/lib/python3.9/site-packages/urllib3/connectionpool.py:1013: InsecureRequestWarning: Unverified HTTPS request is being made to host 'nucleo.ksecosys.com'. Adding certificate verification is strongly advised. See: https://urllib3.readthedocs.io/en/1.26.x/advanced-usage.html#ssl-warnings

Short lookup on this url shows<EMAIL_ADDRESS>as owner of the self signed certificate in use.
From all I understand, an unverified HTTPS request is sent towards ksecosys.com as the verification of the selfsigned certificate is not possible. Am I on track?

Could you attach the full stack trace or at least a bigger part of the log?

After disabling homeassistant-vorwerk and restarting, this is how the Supervisor->Core log looks and stays like:

[s6-finish] sending all processes the TERM signal.
[s6-finish] sending all processes the KILL signal and exiting.
[s6-init] making user provided files available at /var/run/s6/etc...exited 0.
[s6-init] ensuring user provided files have correct perms...exited 0.
[fix-attrs.d] applying ownership & permissions fixes...
[fix-attrs.d] done.
[cont-init.d] executing container initialization scripts...
[cont-init.d] done.
[services.d] starting services
[services.d] done.
2021-10-01 16:16:21 WARNING (SyncWorker_0) [homeassistant.loader] We found a custom integration vorwerk which has not been tested by Home Assistant. This component might cause stability problems, be sure to disable it if you experience issues with Home Assistant
2021-10-01 16:16:21 WARNING (SyncWorker_1) [homeassistant.loader] We found a custom integration hacs which has not been tested by Home Assistant. This component might cause stability problems, be sure to disable it if you experience issues with Home Assistant

Just after enabling homeassistant-vorwerk, this appears right below these entries:

/usr/local/lib/python3.9/site-packages/urllib3/connectionpool.py:1013: InsecureRequestWarning: Unverified HTTPS request is being made to host 'nucleo.ksecosys.com'. Adding certificate verification is strongly advised. See: https://urllib3.readthedocs.io/en/1.26.x/advanced-usage.html#ssl-warnings
warnings.warn(
/usr/local/lib/python3.9/site-packages/urllib3/connectionpool.py:1013: InsecureRequestWarning: Unverified HTTPS request is being made to host 'nucleo.ksecosys.com'. Adding certificate verification is strongly advised. See: https://urllib3.readthedocs.io/en/1.26.x/advanced-usage.html#ssl-warnings
warnings.warn(
/usr/local/lib/python3.9/site-packages/urllib3/connectionpool.py:1013: InsecureRequestWarning: Unverified HTTPS request is being made to host 'nucleo.ksecosys.com'. Adding certificate verification is strongly advised. See: https://urllib3.readthedocs.io/en/1.26.x/advanced-usage.html#ssl-warnings
warnings.warn(
[... and so on]

Could not find a stack trace, though. Sorry for not being able to deliver more.

I will look at it, but as far as I understand its only possible to disable this warning by setting an environment variable, which is not possible from inside a integration.

The problem comes from the underlying lib pybotvac. I created a PR there but I'm still waiting for a merge.
As this bug belongs to pybotvac I close it here.