Switch to using Redux Toolkit for store setup and Redux logic

Hi, I'm a Redux maintainer.
I’d specifically like to recommend that you use our new Redux Toolkit package, which is now our recommended approach for writing Redux logic. It includes utilities to simplify several common Redux use cases, including store setup, defining reducers, immutable update logic, and even creating entire “slices” of state at once:
https://redux-toolkit.js.org
It's already written in TypeScript, and the API is designed to minimize the amount of type declarations you'll have to add by hand.
Please let me know if you've got any questions on using it!

Hi Mark!
This looks really cool! I was not aware such a tool existed when I did my research. Will look into it and add it to the repo as soon as I can.

Yeah, it's been out in some form for about a year and a half, but we only put out 1.0 last fall (and renamed it from "Redux Starter Kit" to "Redux Toolkit" to remove confusion about its purpose):
https://blog.isquaredsoftware.com/2019/10/redux-starter-kit-1.0/

Works great, documentation was very clear.
One single question:
Is there a way for a reducer to accept a conditional payload?
For instance, from:
reducers: {
    search: (state, action) => {
      ....
    }
  }

I would like to call search with and without params.
Calling dispatch(search()) gives the error:
(alias) search<ISearchQuery>(payload: ISearchQuery): {
    payload: ISearchQuery;
    type: string;
} (+1 overload)
import search

Calling this {@link redux#ActionCreator} with an argument will return a {@link PayloadAction} of type T with a payload of P If possible, P will be narrowed down to the exact type of the payload argument.

Expected 1 arguments, but got 0.ts(2554)
typings.d.ts(99, 20): An argument for 'payload' was not provided.

Calling search({}) works as intended but feels a bit off.
Anything I've missed?

When using TS, all case reducers should declare the expected action type as (state, action: PayloadAction<SomePayloadType>).
In this case, what you probably want is:
search(state, action: PayloadAction(ISearchQuery | undefined) {}

Related issue:
https://github.com/reduxjs/redux-toolkit/issues/370

I feel dumb now 😄
Thanks a lot!
Closing as fixed in https://github.com/sidetrade-labs/react-redux-typescript/pull/2

Yeah, I actually noticed yesterday that our "Usage with TS" guide page doesn't clearly spell that out.  I need to update it accordingly.

I actually see some issues with the PR (after you'd merged it, I know). Went ahead and left some review comments over there.


boolean operators

Add boolean AND and OR:
let x = true && false; //false
let y = true || false; //true

Has already been implemented


supervisorctl tail senic_hub doesn't print any logs, all logs go only into senic_hub_error.log

Same holds true for nuimo_app.
This regression is probably introduced with updating the logging mechanism and introducing sentry.

Works for me.


delayWhen operator doesn't delay the events if delayDurationSelector returns a Subject.

Bug Report
Current Behavior
The delayWhen operator doesn't delay the events if delayDurationSelector returns a Subject.
Reproduction

https://stackblitz.com/edit/rxjs-qzqjvf

Expected behavior
In the reproducible example, values 1-4 should not be printed.
Environment

RxJS version: ^6.5.1

It's because the subject - that you are using as the notifier - completes. The implementation of delayWhen does not delay if the notifier completes. There is some discussion here relating to this.
I've edited that issue's title to better reflect the problem.

Closing this as a dupe of #3665, as I've had a play with the repro and if the take - that's applied to the observable to whicht the subject is subscribed - is bumped to, say, 100, the delay is applied. So this is the same problem as in the above issue - the subject completes when the take completes its source.

Thank you for looking in to it so quickly!!


Integrate Baidu-warpctc

The code is not ready for merge! (Related to issue #2305)
Just want you to help me review code in plugin/warpctc/ to see if I make large mistakes. (There are many debug logs in code, I will remove them at last)
Current code can run in CPU mode (can run means will not crash, I does not check if results is right).
For GPU mode, it will crash.

Thanks all, I will try all your ideas today.

I add following inferType function
virtual bool InferType(std::vector *in_type,
std::vector *out_type,
std::vector *aux_type) const {
CHECK_LE(in_type->size(), this->ListArguments().size());
in_type->clear();
in_type->push_back(mshadow::kFloat32);
in_type->push_back(mshadow::kInt32);
out_type->clear();
out_type->push_back(mshadow::kFloat32);
return true;
}
I want to make label be int type. In python code, I use symbol.Cast:
label = mx.sym.Cast(data = label, dtype = 'int32')
This works OK under CPU mode.
However, when I switch ctx to gpu, I get following error.
/dl/mxnet/dmlc-core/include/dmlc/logging.h:235: [11:51:03] src/ndarray/ndarray_function.cu:19: Check failed: (to->type_flag_) == (from.type_flag_) Source and target must have the same data type when copying across devices.
I think this occurs when copy label data generated by DataIter from cpu to gpu.  Here, I find to->type_flag_ = 0 (float32) and from->type_flag_ = 4 (int32)

I find this is because, in Copy<cpu, cpu>, it can do type cast:
void Copy<cpu, cpu>(const TBlob &from, TBlob *to,
15                     Context from_ctx, Context to_ctx,
16                     RunContext ctx) {
17   MSHADOW_TYPE_SWITCH(to->type_flag_, DType, {
18     if (to->type_flag_ == from.type_flag_) {
19         mshadow::Copy(to->FlatTo2D<cpu, DType>(),
20                       from.FlatTo2D<cpu, DType>());
21     } else {
22         MSHADOW_TYPE_SWITCH(from.type_flag_, SrcDType, {
23             to->FlatTo2D<cpu, DType>() =
24                 mshadow::expr::tcast(from.FlatTo2D<cpu, SrcDType>());
25         })
26     }
27   })
28 }
But in Copy<cpu, gpu>, it can not do type cast.
So, my problem is while I still can not get int type label after implement InferType.

WarpCTC need label to be a int* in CPU context.
How can I make other symbols in GPU while make label in CPU?

Currently the assumption is that the inputs need to be in the same context, due to the type inference algorithm
The simplest way is to copy the GPU array to CPU during computation on demand. @antinucleon knows how to allocate a cpu temp space.

My main question now is, after I get grad from warpctc, how can I pass that to in_grad in Backward function?

any updates on this ?

CPU works now. I am working on GPU these days.

I have make everything works now (in both CPU and GPU). And I am working on write an example to prove rightness of CTC. Will submit code in next week.

After rebase upstream/master, I find pull request https://github.com/dmlc/mxnet/pull/2358
will cause problem crash when do evaluation. I have commented in https://github.com/dmlc/mxnet/pull/2358.

Changes in #2358 is used to handle data and label with different batch size. n = int(texec.outputs[0].shape[0] / (islice.stop - islice.start)) was a fix to determine how batch size changes.
We would like to know what shape of data and label ctc uses.

in ctc, labels[0].shape[0] <= outputs[0].shape[0].
for example, in lstm, if use Softmaxoutput, the output shape is  seq_len * batch_size * vocab_size, and label shape is batch_size * seq_len.
if use CTC, the output shape is seq_len * batch_size * vocab_size, but the label shape is batch_size * label_len where label_len <= seq_len.

@antinucleon  I do not know why test is fail, seems my changes are unrelated with tests.

Passed CI

@xlvector thank you for your work!
I use your code to run lstm_ocr.py, however the log as follows:
2016-06-14 15:09:02,479 Epoch[0] Batch [50]	Speed: 171.64 samples/sec	Train-Accuracy=0.000000
2016-06-14 15:09:12,709 Epoch[0] Batch [100]	Speed: 156.40 samples/sec	Train-Accuracy=0.000000
2016-06-14 15:09:22,816 Epoch[0] Batch [150]	Speed: 158.31 samples/sec	Train-Accuracy=0.000000
2016-06-14 15:09:33,066 Epoch[0] Batch [200]	Speed: 156.11 samples/sec	Train-Accuracy=0.000000
2016-06-14 15:09:43,257 Epoch[0] Batch [250]	Speed: 157.00 samples/sec	Train-Accuracy=0.000000
2016-06-14 15:09:53,034 Epoch[0] Batch [300]	Speed: 163.65 samples/sec	Train-Accuracy=0.000000
2016-06-14 15:10:02,445 Epoch[0] Batch [350]	Speed: 170.02 samples/sec	Train-Accuracy=0.000000
2016-06-14 15:10:12,615 Epoch[0] Batch [400]	Speed: 157.33 samples/sec	Train-Accuracy=0.000000
2016-06-14 15:10:22,623 Epoch[0] Batch [450]	Speed: 159.87 samples/sec	Train-Accuracy=0.000000
2016-06-14 15:10:32,699 Epoch[0] Batch [500]	Speed: 158.81 samples/sec	Train-Accuracy=0.000000
2016-06-14 15:10:42,825 Epoch[0] Batch [550]	Speed: 158.01 samples/sec	Train-Accuracy=0.000000
2016-06-14 15:10:53,098 Epoch[0] Batch [600]	Speed: 155.75 samples/sec	Train-Accuracy=0.000000
2016-06-14 15:11:03,209 Epoch[0] Batch [650]	Speed: 158.26 samples/sec	Train-Accuracy=0.000000
2016-06-14 15:11:13,375 Epoch[0] Batch [700]	Speed: 157.39 samples/sec	Train-Accuracy=0.000000
2016-06-14 15:11:23,228 Epoch[0] Batch [750]	Speed: 162.40 samples/sec	Train-Accuracy=0.000000
all the "Train-Accuracy" is 0
Is it normal?

@maydaygmail Yes, this is normal. The CTC does not converge in first many iterations.  After revert back to the previous implementation we lose support for slicing a larger batch of label than data batch size.

I can not install Baidu-warpctc on windows. So, this cannot run on windows?

@yuzhuqingyun You can submit a issue to https://github.com/baidu-research/warp-ctc

@precedenceguo Sorry, I find that, if do not revert to previous implement. The training of examples/rnn/lstm_bucket.py will also fail.
So, I think new implements in executor_manager.py does not consider LSTM/RNN case.
@tqchen @antinucleon

Everything is OK now.
Ready for merge.

@xlvector Seems the submodules dmlc-core and mshadow are downgraded. Need to revert these two changes.

I think the example is good to merge after changing back the submodules since it breaks no API.

@sxjscience Is this ok now?

seems scala-test failed only because of network problem:
[ERROR] Plugin org.apache.maven.plugins:maven-dependency-plugin:2.9 or one of its dependencies could not be resolved: Failed to read artifact descriptor for org.apache.maven.plugins:maven-dependency-plugin:jar:2.9: Could not transfer artifact org.apache.maven.plugins:maven-dependency-plugin:pom:2.9 from/to central (https://repo.maven.apache.org/maven2): Connection reset -> [Help 1]

@xlvector I've run the test again. Sometimes Travis fails randomly.

@xlvector  when running lstm_ocr.py，one error happen:
[ERROR]:TypeError:must be sequence of length 4,not 2
I just change the fonts of ImageCaptcha for I cannot find the file (./data/Xerox.ttf)

@Yang507  you can download Xerox.ttf from http://www.webpagepublicity.com/free-fonts/x/Xerox Sans Serif Narrow.ttf and put it in ./data/
Can you paster all error messages?

I use cnn_ocr.py(https://github.com/xlvector/learning-dl/tree/master/mxnet/ocr),
why Train-Accuracy = 0.000000 after batch[1300](and this batch number is always changing when next training)
2016-07-01 12:27:17,341 Epoch[0] Batch [50]     Speed: 181.20 samples/sec       Train-Accuracy=0.000000
2016-07-01 12:27:26,751 Epoch[0] Batch [100]    Speed: 170.05 samples/sec       Train-Accuracy=0.000000
2016-07-01 12:27:36,490 Epoch[0] Batch [150]    Speed: 164.29 samples/sec       Train-Accuracy=0.000000
2016-07-01 12:27:46,196 Epoch[0] Batch [200]    Speed: 164.85 samples/sec       Train-Accuracy=0.000400
2016-07-01 12:27:56,264 Epoch[0] Batch [250]    Speed: 158.92 samples/sec       Train-Accuracy=0.001600
2016-07-01 12:28:05,724 Epoch[0] Batch [300]    Speed: 169.14 samples/sec       Train-Accuracy=0.004000
2016-07-01 12:28:15,906 Epoch[0] Batch [350]    Speed: 157.14 samples/sec       Train-Accuracy=0.001600
2016-07-01 12:28:25,906 Epoch[0] Batch [400]    Speed: 160.00 samples/sec       Train-Accuracy=0.000400
2016-07-01 12:28:35,385 Epoch[0] Batch [450]    Speed: 168.79 samples/sec       Train-Accuracy=0.006800
2016-07-01 12:28:45,341 Epoch[0] Batch [500]    Speed: 160.71 samples/sec       Train-Accuracy=0.023200
2016-07-01 12:28:54,888 Epoch[0] Batch [550]    Speed: 167.60 samples/sec       Train-Accuracy=0.076000
2016-07-01 12:29:04,616 Epoch[0] Batch [600]    Speed: 164.47 samples/sec       Train-Accuracy=0.122800
2016-07-01 12:29:14,225 Epoch[0] Batch [650]    Speed: 166.50 samples/sec       Train-Accuracy=0.161600
2016-07-01 12:29:23,789 Epoch[0] Batch [700]    Speed: 167.30 samples/sec       Train-Accuracy=0.172400
2016-07-01 12:29:33,543 Epoch[0] Batch [750]    Speed: 164.03 samples/sec       Train-Accuracy=0.175200
2016-07-01 12:29:43,938 Epoch[0] Batch [800]    Speed: 153.93 samples/sec       Train-Accuracy=0.242800
2016-07-01 12:29:53,821 Epoch[0] Batch [850]    Speed: 161.88 samples/sec       Train-Accuracy=0.264800
2016-07-01 12:30:03,501 Epoch[0] Batch [900]    Speed: 165.30 samples/sec       Train-Accuracy=0.282400
2016-07-01 12:30:12,893 Epoch[0] Batch [950]    Speed: 170.37 samples/sec       Train-Accuracy=0.305200
2016-07-01 12:30:22,977 Epoch[0] Batch [1000]   Speed: 158.66 samples/sec       Train-Accuracy=0.304000
2016-07-01 12:30:32,574 Epoch[0] Batch [1050]   Speed: 166.72 samples/sec       Train-Accuracy=0.265600
2016-07-01 12:30:42,185 Epoch[0] Batch [1100]   Speed: 166.48 samples/sec       Train-Accuracy=0.000400
2016-07-01 12:30:51,542 Epoch[0] Batch [1150]   Speed: 170.99 samples/sec       Train-Accuracy=0.004800
2016-07-01 12:31:01,694 Epoch[0] Batch [1200]   Speed: 157.61 samples/sec       Train-Accuracy=0.000000
2016-07-01 12:31:11,258 Epoch[0] Batch [1250]   Speed: 167.30 samples/sec       Train-Accuracy=0.000400
2016-07-01 12:31:20,939 Epoch[0] Batch [1300]   Speed: 165.27 samples/sec       Train-Accuracy=0.000000
2016-07-01 12:31:31,098 Epoch[0] Batch [1350]   Speed: 157.51 samples/sec       Train-Accuracy=0.000000
2016-07-01 12:31:40,550 Epoch[0] Batch [1400]   Speed: 169.26 samples/sec       Train-Accuracy=0.000000
2016-07-01 12:31:50,023 Epoch[0] Batch [1450]   Speed: 168.91 samples/sec       Train-Accuracy=0.000000
2016-07-01 12:31:59,475 Epoch[0] Batch [1500]   Speed: 169.27 samples/sec       Train-Accuracy=0.000400
2016-07-01 12:32:08,882 Epoch[0] Batch [1550]   Speed: 170.09 samples/sec       Train-Accuracy=0.000400
2016-07-01 12:32:18,604 Epoch[0] Batch [1600]   Speed: 164.58 samples/sec       Train-Accuracy=0.000000

@livedimg we can discuss in that repos.

@xlvector
[Error]:
begin fit
infer label shape: 128
2016-07-01 09:54:48,300 Start training with [gpu(3)]
infer label shape: 128
infer label shape: 128
infer label shape: 128
iter
Traceback (most recent call last):
File "lstm_ocr.py", line 165, in
batch_end_callback=mx.callback.Speedometer(BATCH_SIZE, 50),)
File "../../python/mxnet/model.py", line 788, in fit
sym_gen=self.sym_gen)
File "../../python/mxnet/model.py", line 221, in _train_multi_device
for data_batch in train_data:
File "lstm_ocr.py", line 66, in iter
img = self.captcha.generate(num)
File "/usr/local/lib/python2.7/dist-packages/captcha/image.py", line 40, in generate
im = self.generate_image(chars)
File "/usr/local/lib/python2.7/dist-packages/captcha/image.py", line 220, in generate_image
self.create_noise_curve(im, color)
File "/usr/local/lib/python2.7/dist-packages/captcha/image.py", line 132, in create_noise_curve
Draw(image).arc(points, start, end, fill=color)
File "/usr/lib/python2.7/dist-packages/PIL/ImageDraw.py", line 164, in arc
self.draw.draw_arc(xy, start, end, ink)
TypeError: must be sequence of length 4, not 2
Thanks!I download the Xerox.ttf from the link and put in my one directory,but the result has the same error.

seems this error is just because of captcha. can you write a test script to make python-captcha work？

@xlvector I also run your cnn_ocr.py(https://github.com/xlvector/learning-dl/tree/master/mxnet/ocr) has the same problem as @livedimg, when I run about four hours, Train-Accuracy-0.000000, Validation-Accuracy=0.000000, I don't know how to deal with it and ask you.

I change the learing rate and make learning rate =0.005,the Train-Accuracy is closed to 1.
The one thing is important for me, I have some captcha images, but I don't know how to put images in code and train it@xlvector, I'm very sorry to interrupt you for the time and thank you for your help.

@xlvector I have download .ttf file and put it into data directory, then I run python lstm_ocr.py it occurs a problem
illusion@illusion:~/mxnet/example/warpctc$ python lstm_ocr.py
begin fit
2016-07-14 15:14:29,809 Start training with [cpu(1)]
iter
Traceback (most recent call last):
File "lstm_ocr.py", line 174, in
batch_end_callback=mx.callback.Speedometer(BATCH_SIZE, 50),)
File "../../python/mxnet/model.py", line 789, in fit
sym_gen=self.sym_gen)
File "../../python/mxnet/model.py", line 221, in _train_multi_device
for data_batch in train_data:
File "lstm_ocr.py", line 67, in iter
img = self.captcha.generate(num)
File "/usr/local/lib/python2.7/dist-packages/captcha/image.py", line 40, in generate
im = self.generate_image(chars)
File "/usr/local/lib/python2.7/dist-packages/captcha/image.py", line 220, in generate_image
self.create_noise_curve(im, color)
File "/usr/local/lib/python2.7/dist-packages/captcha/image.py", line 132, in create_noise_curve
Draw(image).arc(points, start, end, fill=color)
File "/usr/lib/python2.7/dist-packages/PIL/ImageDraw.py", line 164, in arc
self.draw.draw_arc(xy, start, end, ink)
TypeError: must be sequence of length 4, not 2
How can I solve this problem ? thanks for your time

@Yang507  I have meet a same problem with u, when I use captcha.gennerate() method, it occurs a same problem, TypeError: must be sequence of length 4, not 2. How do u do to solve this problem?

@sinmaystar you could input follow commands in your terminal:sudo pip install -U Pillow,then run lstm_ocr.py again, I almost forget it.

@Yang507  just update Pillow package is alright? my pillow version is 2.3.0, what's your pillow package version?

my Pillow version is 3.3 now , I forget if I have Pillow package before I update Pillow@sinmaystar

my Pillow version is 3.3 now , I forget if I have Pillow package before I update Pillow @sinmaystar

@Yang507  can u run this code successfully just right now?  are u sure its Pillow's problem? I have updated Pillow but its still not working

@sinmaystar you can refer to https://github.com/lepture/captcha/issues/7

@Yang507  I have installed Pillow3.3 but it installed in /usr/local/lib/python2.7/dist-packages Ubuntu have Pillow2.3.3 in /usr/lib/python/2.7 and it cant be delete it owned by OS, how do u solve this problem

@xlvector  I have update Pillow and installed successfully but pip list shows Pillow's version is also 2.3.3 and in  /usr/local/lib/python2.7/dist-packages have version 3.3 Pillow package, I cannot use pip uninstall Pillow to delete 2.3.3 version it occurs a problem, this version owned by OS, do u know how to fix this problem?

@xlvector  @Yang507  I have delete Pillow version 2.3.3 manually, pip list show Pillow version is 3.3 but its still occur this error
TypeError: must be sequence of length 4, not 2
is there have any other way to solve it?

@xlvector  I met a same problem with you when I run lstm_ocr.py with my own data(number=18), occur following error:
 Traceback(msot recent call last):
 File "lstm_ocr.py",line 165,in <module>
     batch_end_callback=mx.callback.Speedometer(BATCHSIZE,50))
 File "../../python/mxnet/model.py",line 745,in fit
    self._init_params(dict(data.provide_data+data.provide_label))
 File "../..python/mxnet/model.py",line 486,in _init_params
    assert(arg_shapes is not None)
 AssertionError

I know my data format is not match with the random captcha format, but I don't know how to write a iterator to load my captcha data and train it with lstm_ocr.py, I want to get your help and i'm grateful.

能不能在你的wrapctc的例子里多写点介绍。
一点注释也没有。。。

@thewintersun 其实相比于examples/rnn里面的例子，就改了一行。
一些简单的介绍见 https://zhuanlan.zhihu.com/p/21344595?refer=xlvector

看你的warpctc里的代码， 似乎没有任何地方的代码是和warpctc有关联的，
难道是mxnet在make的时候直接就整合ctc，后续写python代码就不用关心ctc了吗？

@xlvector   The log you train lstm shows the network just take less than 40 minutes to converge and finished just in epoch 0 . So , I wonder do you set  BATCH_SIZE  very big(160 or 320  )? or learning rate a little lower (not 0.005)? I run lstm_ocr.py in GTX980ti, the result isn't very good as yours and  take me about 3 hours.

@anxingle did u run lstm_ocr.py example successfully ?
how do u integrate baidu warp-ctc?
I have installed baidu warp-ctc and do as readme introduction, but it occurs an error:
AttributeError: 'module' object has no attribute 'WarpCTC'
how can I solve this problem

@sinmaystar   Yeah,it's really hard to compile. Do you set $LD_LIBRARY_PATH (let libwarpctc.so in the path)? and edit make/config.mk ,let warpctc_path  contain warp-ctc.
Can you tell me where is your warp-ctc and how about your config.mk and more info?

        I do not set LD_LIBRARY_PATH，I have comment out two lines as introduction says，my warp-ctc and mxnet all in home directory，thanks for your help，tomorrow I will retry it，thanks for your help，if I it does not work，maybe I will ask you again、thanks many！you are very kind
        在2016年07月21日 18:41，安兴乐-siler 写道:@sinmaystar   Yeah,it's really hard to compile. Do you set $LD_LIBRARY_PATH (let libwarpctc.so in the path)? and edit make/config.mk ,let warpctc_path  contain warp-ctc.

Can you tell me where is your warp-ctc and how about your config.mk and more info?
—You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or mute the thread.

@anxingle Where can I find libwarpctc.so file? and how you set $LD_LIBRARY_PATH ?  I can not find libwarpctc.so file after compile warp-ctc

@sinmaystar     in warp-ctc/build . You can use the command to find it:   find  /home/$USER/warp-ctc/   -name libwarpctc.so.  And it shows the message:  /home/a/warp-ctc/build/libwarpctc.so  .    Then you edit the ~/.bashrc,add the  line export LD_LIBRARY_PATH="/home/a/warp-ctc/build:/usr/local/cuda-7.5/lib64:$LD_LIBRARY_PATH"(this is my own path) to the end of the file.

@anxingle  thanks for your help I have run this example successfully.
I am working on add a cnn layer before lstm, so it can extract word features and resist rotate, but I do not know how to add a simple cnn layer before lstm, do u have any suggestions?

When predict  using:
model_load = mx.model.FeedForward.load('ocr',15)
[prob, data1, label1] = model_load.predict(data_val, return_data=True)
get error:
self.ctx[0], grad_reg = 'null', **dict(input_shapes)
ValueError:Input node is not complete
how can I predict  with one picture?

I also meet the error, how do u integrate baidu warp-ctc?
I have installed baidu warp-ctc and do as readme introduction, but it occurs an error:
AttributeError: 'module' object has no attribute 'WarpCTC'
how can I solve this problem

@xlvector 请教个应用方面的问题
mxnet/example/warpctc/lstm_ocr.py
我clone mxnet最新版 0.10.0
提示： Check failed: ishape[real_axis] == static_cast<size_t>(param_.num_outputs) (2400 vs. 80) If squeeze axis is True, the size of the sliced axis must be the same as num_outputs. Input shape=(32,2400), axis=1, num_outputs=80.
我修改成了输入 width, height

self.provide_data = [('data', (batch_size, self.height, self.width))] + init_states
2.img = img.reshape(self.height, self.width)
3.SEQ_LENGTH = 30
但是精度一直为0...
直接运行 toy.py结果就正常。
请问我是哪里忽略了或者修改错误的地方吗？

你好，我用mxnet中的mxnet_predict.py进行预测的时候，好像不支持GPU的选项，只能在CPU下跑，用GPU会卡住，报terminate called without an active exception的错误

mxnet当时只是玩一玩，没深做。
On Fri, Sep 15, 2017 at 2:50 PM, wuchuanying<EMAIL_ADDRESS>wrote:

你好，我用mxnet中的mxnet_predict.py进行预测的时候，好像不支持GPU的选项，只能在CPU下跑，用GPU会卡住，报terminate
called without an active exception的错误
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/apache/incubator-mxnet/pull/2326#issuecomment-329697523,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ATT_GBKViUAVaRdSBma-Oz_pwymots7Aks5sih5IgaJpZM4ItWu7
.


Adding test content

TAG_REVIEWER will you please review this?
[Explanation of the change or anything fishy that is going on]
Fixed Issues
$ GH_LINK
Tests

What unit/integration tests cover your change? What autoQA tests cover your change?
What tests did you perform that validates your changed worked?

QA

What does QA need to do to validate your changes?
What areas to they need to test for regressions?

@Luke9389 - It does not work here either!

@Luke9389 - It does not work here either!


Add plugin context using "with"

(moved from #8)
requires #7
what
Add modifier function to add/manipulate metadata or plugin context data:
db.get("path").with(permissions({user: "rw"})).set(123);
db.get("path").with(owner("userid")).set("my data");

why
This allows to add specific context/options for plugins for different paths.

Difference between plugin context and setting meta data:
plugin context = adding context data for a specific path to be used by plugins, but only locally
metadata = metadata which is synchronized between clients and can be used by plugins but also directly from within .on or .once

I think a lot of the use cases for this might be solved via the new API (#79). So closing for now.


detekt-cli not found

I am using latest version of this action and in some cases (not always) getting the following issue:

It says "adding to path" and when I try to run it I got "detekt-cli: command not found". Any ideas? Going to try using full path for detekt-cli instead as a workaround.

@peter-murray I got some more details about the issue - looks like it happens when detekt-cli is found in the tools cache on the build node, but the location for binary is not properly detected:
This is setup-detekt action with wrong PATH to detekt binary returned:

And here is the structure of the directories under /home/ec2-user/actions-runner/_work/_tool/detekt-cli/1.21.0:

So, the correct detekt path is this case is /home/ec2-user/actions-runner/_work/_tool/detekt-cli/1.21.0/all/detekt-cli-1.21.0/bin/detekt-cli, but the action returns /home/ec2-user/actions-runner/_work/_tool/detekt-cli/1.21.0/all/bin/detekt-cli.
Any ideas why this happening?

Thank you @astelmachonak-nydig that helped in diagnosing the issue. The path returned from the tool cache was not being modified to include the nesting directory that it does include when it resolves from the release archives.
I have updated version v2 of the action to fix this. It should work properly now under that circumstance.

Thanks for the quick fix! Will check it out today and report back.

Looks good on my end, thanks again for the fix!


Update network-policies.md

Add explanation of policy evaluation order from https://github.com/kubernetes/kubernetes/issues/75435

/cc @cmluciano

/assign

Hi @cmluciano can you serve as a technical reviewer for this? Just add a /lgtm when you feel it is technically correct and I'll take care of the rest.  Thanks!

The point is that AS SOON as one policy selects a pod, rules apply.
Whether that is one, two, or 10 additive policies.
On Fri, Nov 1, 2019 at 8:39 AM Sam Darwin<EMAIL_ADDRESS>wrote:

@sdarwin commented on this pull request.
In content/en/docs/concepts/services-networking/network-policies.md
https://github.com/kubernetes/website/pull/17335#discussion_r341628666:

@@ -28,6 +28,8 @@ By default, pods are non-isolated; they accept traffic from any source.

Pods become isolated by having a NetworkPolicy that selects them. Once there is any NetworkPolicy in a namespace selecting a particular pod, that pod will reject any connections that are not allowed by any NetworkPolicy. (Other pods in the namespace that are not selected by any NetworkPolicy will continue to accept all traffic.)
+Network policies do not conflict, they are additive. If policies select a pod, the pod is restricted to what is allowed by the union of those policies' ingress/egress rules. Thus, order of evaluation does not affect the policy result.
just in this context, "If policies select a pod" could almost be worded
"If multiple policies select a pod" , since it's about explaining that
situation, of multiple rules, rather than the case of a single policy.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes/website/pull/17335?email_source=notifications&email_token=ABKWAVCH5XIDTX3AVNA6TDLQRRESPA5CNFSM4JHM3SKKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCKBE6RQ#discussion_r341628666,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABKWAVC4FZIMQHPE62DPV5TQRRESPANCNFSM4JHM3SKA
.

The point is that AS SOON as one policy selects a pod, rules apply. Whether that is one, two, or 10 additive policies.

That is certainly true.
The original sentence was copied verbatim from https://github.com/kubernetes/kubernetes/issues/75435
An issue is that later in the sentences it refers back to "those policies'" which is plural.   If the first part of the sentence switches to singular such as "if any (one) policy", then the later part should switch too.
Example updates:
choice 1: "If any policy selects a pod, the pod is restricted to what is allowed by the union of all applicable policies' ingress/egress rules."
choice 2: "If any policy or policies select a pod, the pod is restricted to what is allowed by the union of all those policies' ingress/egress rules."
perhaps choice 2?

#2 SGTM
On Fri, Nov 1, 2019 at 11:42 AM Sam Darwin<EMAIL_ADDRESS>wrote:

The point is that AS SOON as one policy selects a pod, rules apply.
Whether that is one, two, or 10 additive policies.
That is certainly true.
The original sentence was copied verbatim from kubernetes/kubernetes#75435
https://github.com/kubernetes/kubernetes/issues/75435
An issue is that later in the sentences it refers back to "those
policies'" which is plural. If the first part of the sentence switches to
singular such as "if any (one) policy", then the later part should switch
too.
Example updates:
choice 1: "If any policy selects a pod, the pod is restricted to what is
allowed by the union of all applicable policies' ingress/egress rules."
choice 2: "If any policy or policies select a pod, the pod is restricted
to what is allowed by the union of all those policies' ingress/egress
rules."
perhaps choice 2?
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes/website/pull/17335?email_source=notifications&email_token=ABKWAVHN3F6IXI6OTOJU6DTQRR2BXA5CNFSM4JHM3SKKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEC32B3I#issuecomment-548905197,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABKWAVADC4LBHIEYD74CG7DQRR2BXANCNFSM4JHM3SKA
.

/approve


Reverse the words of a String

💥 Proposal
Example:-
input = I love Java
output = java love I
Have you read the Contributing Guidelines on Pull Requests?
yes

/assign


reload of webview breaks connection handling

If the webview of Capacitor is reloaded (e.g. via dev-server), the plugins looses its internal connection dict/state. isConnection returns false however createConnection fails because the connection still exists on the native side.
I suggest to not handle any state on the JS-side of the plugin (or alternatively to check native connection state on web-startup).

@chriswep hi Chris, Which version of the plugin are you using 2.9.x or 3.0.0 ? Looking at this which i never thought about it, may be the best solution is to provide a command to delete all Native Connection as we need to keep the connection object on the JS-side. So the connections could be re-created from scratch.

i'm using 3.0.0-beta-9, currently developing a typeORM plugin. yes, that's my current workaround to delete a connection before creating it. Its a hack though, since i have no way to determine if a connection exists on native or not (i.e. try .. catch .. ignore).
I could imagine that this could bite a lot of people, esp. while developing. closeAllNativeConnections could help - i would suggest to state in the README that this is needed during development if using a dev-server with reloading. I think a cleaner approach would be to take care that native state is pushed to js on startup. if i'm correct its "just" a list of db-names?

This is addressed in https://github.com/capacitor-community/sqlite/commit/91cadf53e3a7e0cba01a911e3ca9b1a3eb39e2f6 - i found it difficult to wrap my head around the new checkConnectionsConsistency method, so here is my solution for reference. It might be useful for the README:
If using a dev-server with auto-reload, this should be executed before attempting any connections:
CapacitorSQLite.checkConnectionsConsistency({
     dbNames: [],
}).catch((e) => console.log(e));

If i understand correctly, this tells the native side: "i expect no connections to be open". The plugin then closes all open connections as specified. It throws an error though. @jepiqueau i would suggest to rather return a status from the method since the closing of connections is specified and intended behaviour, not an error.

Hi Chriswep,
where should i cann the closeAllNativeConnections or callthe checkConnectionsConsistency method? CheckConnectionsConsistency throws an error for me if i call it before creating or retrieving the connection.
thanks,


Split apart 'build_sources' and 'build'

Objective

Remove 'watch' and 'watch_processed' flag parameters to increase readability.

Solution

Split the 'build' and 'build_sources' functions into functions where each parameter is either true or false and give them fitting names.

Notes
The case where both 'watch' and 'watch_processed' are true is not used and is thus not included.

This will remain a draft until I figure out some way to decrease the duplication and hopefully split the checking out into separate calls. Any help is welcome.


Implement power states, and expose power and instance state in CLI.

Fixes #159, and should be cherry picked to v0.2-devel once merged.

Cherry picked to v0.2-devel.
Pls check I got it right...


Git Bash doesn't show up in select default terminal menu when already installed.

VS Code Version: 1.54.1 (user setup)
Commit: f30a9b7
Date: 2021-03-04T22:40:57.714Z(4 days ago)
Electron: 11.3.0
Chrome: 87.0.4280.141
Node.js: 12.18.3
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT ia32 6.1.7601
OS Version: Windows 7 SP1(Service Pack 1)

Steps to Reproduce:(Make sure Git Bash is installed)

Open VS Code
Open a new terminal
Click on terminal name, a dropdown opens
Select "select default shell"
Git Bash not present

Does this issue occur when all extensions are disabled?:
I have Git Bash installed(in E: drive). But when I try to configure it as default, the option isn't there. I can do it through the settings.json, but I think this should definitely be fixed.
I guess the problem is that VS Code doesn't look for Git Bash in any other place other than the default installation path

Screenshots:
Select default shell menu:

Git Bash Installed Proof:

This is because it's in a non-standard install location, we don't attempt to search the system for it, only standard locations. You can configure it yourself using terminal.integrated.windows.shell and in the next version create a quick launch profile for it so it shows up here:

alright thanks...


[BUG] When using ServiceBusSessionProcessor If OnSessionInitializingAsync throws an exception messages are still processed

Library name and version
Azure.Messaging.ServiceBus 7.9.0
Describe the bug
If user code throws an exception in OnSessionInitializingAsync, the processor still continues with processing messages even though initialization failed.
Expected behavior
If user code throws an exception during initialization seems like the right thing to do is to cancel processing that session.
Actual behavior
During the session initialization step, if the code throws an exception, it is caught at the end of ReceiveAndProcessMessagesAsync  which only logs the event.
Unfortunately, the finally clause only cleans up if the call was successful? CloseReceiverIfNeeded won't clean this up properly anyhow since _threadCount only gets incremented if call to initialize succeeds, which gets skipped and during clean-up it will be -1.
Since call to CreateReceiver happens before the user code _receiver is already assigned.
When the next thread starts, the call to initialization is skipped which causes messages to be processed even though the user code is not initialized properly.
Reproduction Steps

Use ServiceBusSessionProcessor to listen to a session enabled queue.
Throw an exception during SessionInitializingAsync event.

Environment
No response

Thank you for your feedback.  Tagging and routing to the team member best able to assist.

Hi @asanjabi,
OnSessionInitializingAsync is meant to be a hook where you can run logic before processing a session. I think it would be too opinionated of the SDK to assume that an unhandled exception means the session should be skipped. You can catch the exception in your event handler and call ReleaseSession if you want to avoid processing the session. But as you've noted, ReleaseSession is not currently available in the relevant event args. I will submit a PR to fix this.


Why does client side rendering wrong when i add routes from plugins?

HI there,
I have a problem when I need to add a path through a plugin. I will show my coding as below.

<template>

Category: {{ slug }}

</template>

// nuxt.config.js
// ...
plugins: [
    '~plugins/routes'
]

// ~plugins/routes.js
import Category from '~pages/category/_slug.vue'

export default ({ app }) => {
  app.router.addRoutes([
    { path: '/:slug(cat)', component: Category }
  ])
}

when trying to access "/cat" route, why is the result displayed as Category: cat before it is changed to Category: default at the client side?,
But when i try to access "/category/cat" route is normally. Category: cat
How to resolve this problem?

https://github.com/nuxt-community/router-module


Art Installation managers can not change Hebrew name

A complaint received while trying to help one of the art installation managers

Overview of the problem
Changing Art installation name does not work.

Description
When trying to change Hebrew name (which was imported from the Dreams sys.) art inst. managers receives a message that the change was successful but refreshing the page returns the previous name.

Expected behavior
We should either disable editing in the UI, if this is the desired solution or save the changed name to the database. Either way it is a business-rules/product decision.

And the English name?

I think it is disabled for editing.
On Sun, Mar 11, 2018, 14:15 Alex<EMAIL_ADDRESS>wrote:

And the English name?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Midburn/spark/issues/756#issuecomment-372110858, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAkWjEKr3VaVk-NUx2-4jnNfGlA7RFC8ks5tdRVogaJpZM4SlnNG
.

So the two should be aligned


lfs_dir_commit  hangs the LFS

I am using LFS in NRF52832.
Operation:

Create new file.
write data per 500ms, repeat 5 times.
Close the file.

When the operation repeated many times, close file fail. I found lfs_dir_commit hangs.

@NewbieYangbo Have a look at #429
Check the flag LFS_F_OPENED at all file_open and file_close attempts.
Double open leads to endless loop.
Double close leads to endless loop.


Pincher Arm is not moving

Hey, thanks for this great repository!
I'm trying to run Phantom X Pincher Arm on melodic using your repo but the arm doesn't move. After bringup, I launched the pincher_arm_moveit.py, but clicking plan & execute on rviz doesn't move the arm. Although the execution status says succeeded. Any thoughts on what might be going wrong?

Update: Solved by setting the servo ids to 1,2,3,4,5 in arbotix_terminal.


[VS Code] Joining collaboration session: Request was cancelled

Error:
Joining collaboration session: Request was cancelled
Steps to Reproduce:

Version Data

extensionName
VSLS

extensionVersion
0.3.1005

protocolVersion
2.2

applicationName
VSCode

applicationVersion
1.29.1

platformName
Windows

platformVersion
10.0.17134

@doniaGhazy  Thanks for reporting this, can you please attach liveshare logs to help us diagnose the issue. You can get the logs by running "Export liveshare logs" from VSCode command palette. I am closing the issue as duplicate of #1329 . Please add your comments / logs there


Fix errorpone warnings

Problem:
Errorprone warnings during builds are irksome.
Solution:
Fix the errors:

Most of them in tests
The ones involving generic return types are suppressed (TypeParameterUnusedInFormals) as they are part of our public API and I don't think we're changing that now
Switched ConsoleReporterFactory.ConsoleStream enum from containing a non-immutable type (PrintStream) to a function returning that printstream (stdout or stderr)
Use Guava's Splitter instead of String.split in the ByteRange and AssetServlet classes
errorpone detected that the futures were unused in the JerseyClientIntegrationTest.java test, so I collected them as CompletableFutures using jersey rx client (which is backwards incompatible in 2.27, but I can take care of that 👌 ) -- and thus queried for successful completion.

Result:
No more errorprone warnings! No behavior should be changed.

Ah interesting. I'm not sure who to appease in this situation. Using String.split will cause more errorprone warnings and it doesn't seem like those should be suppressed. I, myself, am ambivalent to removing guava.

The link provided in the original post provides this alternative:
String.split(String, int) and setting an explicit 'limit' to -1 to match the behaviour of Splitter.
For my own knowledge, what is the advantage of removing Guava?

@isaki-x Less direct dependencies is better, I believe.

@isaki-x There have been regular questions about the removal of Guava from Dropwizard on the mailing list and on GitHub, as they have (or had, since https://groups.google.com/forum/#!msg/guava-discuss/rX-QXo-67ZU/gLEvfV4CAwAJ) been breaking backward compatibility quite often.
That imposed problems to people using Dropwizard to implement a Spark application, for example.
With the removal of Guava, this use case would be easier to implement, and with Java 8, there's not too much convenience Guava brings to the table and most changes are pretty mechanical.
I'll open a PR for discussing the removal of Guava from Dropwizard 2.x shortly.

@joschi Thanks for the info! I tend to avoid most of the convenience functions in Guava, but I personally am a fan of Guava's multi maps, tables, and immutable collections. If you aren't using those things, I can see why eliminating such a dependency is ideal. And as @alex-shpak has mentioned, fewer direct dependencies can be a very good thing.


example for push/pull progression

hi,
could anyone help me to understand how the progress works ?
the pull/push methods can receive a IProgress object.
this object has a report function, but it wants an integer parameter.
i want something like this:
`Dim tProgress As IProgress(Of Integer) = Nothing
Dim tActProgress As Integer = 0
                Using tService As SyncService = New SyncService(New AdbSocket(New IPEndPoint(IPAddress.Loopback, AdbClient.AdbServerPort)), tWorkerArgs.QuestDevice)
                    Using tStream As Stream = File.OpenWrite(tAPKDestFullPath)
                        tService.Pull(tAPKSourceFullPath, tStream, tProgress, CancellationToken.None)
                        While tActProgress < 100
                            tProgress.Report(tActProgress)

                            SimpleWait(1)
                        End While
                    End Using
                End Using`

would be nice if anyone could help me

I don't know much the VB.NET syntax but basically you create and initialize an IProgress<T> object, with T as the type of progress (in this case, int - Integer in VB.NET-) and assign a method to the EventHandler.

Hope this helps!


Update screenshots "Test Registration & Key Sharing": Add "Thank you"… PR

… screen & match Android and iOS (corona-warn-app#3367)

Update screenshots: Add "Thank you" screen

Update section

Not needed anymore.


[other] Add option to load data to host buffers for SFNO

Description
A large prefetch buffer or validation buffer uses a substantial amount of memory on the GPU. This includes an option to store them on the host.
Info population
Please do not make any changes to the rest of this template. Information will be populated automatically upon submission.
Authors
Authors:
Resources
For technical questions please refer to our forum.

/blossom-ci

/blossom-ci


Send Event: Add default for start and end time

As to help with standardization, use default variables for start and end time.  Propose:
$(startTime)
$(endTime)
NOW

PROPOSED

Now also support timeframe and defaulting to 30m since Keptn 0.7.3


Add native async support client side.

TBD will add descript

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#690  👈
#689
#688
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @rohinb2 and the rest of your teammates on  Graphite


See for example: https://github.com/OpenRefine/OpenRefine-nightly-releases/releases
It would be nice to use your action where I can specify the following:

a repo
a new parameter where I specify keep:3 to keep the 3 latest releases and it then deletes all the older releases (with their attached tag and binary files), completely removing them.

Any chance you could add that option?
Or a brand new action called delete-older-releases ?
I looked around and didn't find something that would work.  But pointers welcome.

@thadguidry Deleting multiple tags and releases contradicts with goal of this action. This action goal is to delete all release of a given tag.
I  making new action to satisfy requirements you mentioned
https://github.com/dev-drprasad/delete-multiple-releases
Its not completed yet. You can keep an eye that repo

@dev-drprasad Awesome!  We are looking forward to it!  Thanks so much!

@thadguidry I released first version of https://github.com/dev-drprasad/delete-older-releases. Please refer README for usage. If you find any issue, do raise an issue


Add onToggleHide callback

Add the onToggleHide callback that will be called with a boolean indicating the visibility state of the player. This callback should be called after user taps on the button:

Player's constructor with the callback:
new MojsPlayer({
  add: timeline,
  onToggleShow(isHidden) {
    if (isHidden) { // do something when player is invisiblie }
    else { // do something when player is visiblie }
  }
});

Please let me know is you are want to help and have any question.

Hi there
https://github.com/legomushroom/mojs-player/pull/11

@legomushroom is this ready to close? curious if you still want help on it.

@weisjohn thanks a lot, this one is merged here: https://github.com/legomushroom/mojs-player/pull/11 , sorry about the confusion.


When add the "devices","radio" and "bluetooth" packages, the added package will disapper in the packages pop up window

Repro steps:

Navigate to https://pxt.microbit.org/beta
Click "Add Package" and choose the "radio"
Then click the "Add Package" again

By design.


Spanish translation request

Hello!
I came to this project and really liked it. I saw there's a branch for Polish, making me think you might want branches for every language. I would want to translate this into Spanish. I'm a native Spanish speaker that has previously worked in translations from English to Spanish in other open-source projects. Tell me if I can start working on it.
If this is not the case, just close this issue.
Thank you in advance.

Hi @JoseDeFreitas Thanks you so much for your feedback & the kind words. Nice to meet you. 🔥 I'm glad to hear this.
Your idea is great, it would be lovely! 🚀 Sure, please feel free. Let's keep in touch.
Best wishes,

Hello Michal 👋. Just created the pull request I mentioned. Thank you for allowing me to work on the translation 👍.

Hello @JoseDeFreitas  once again, thanks a lot for your effort here! That's awesome!! 🔥 My pleasure! ⭐

May I close the issue?

Hello Michal! Yes. The translation has already been made 👌.


Fix exporters GPU CI

Fixing it yet again, this time due to a conflicting onnxruntime and onnxruntime-gpu install.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


Trying to open a scene with missing dependencies spawns empty scene tab and spams errors

Godot version
4.2 rc1
System information
Windows 10.0.19045 - Vulkan (Forward+) - dedicated NVIDIA GeForce GTX 1060 (NVIDIA; <IP_ADDRESS>3) - Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz (8 Threads)
Issue description
https://github.com/godotengine/godot/assets/2223172/654c4aaa-1f45-4ad0-84af-3799fd0dd606
Steps to reproduce

Create scene
Add some resource (e.g. icon.svg)
Save and close the scene
Remove the resource
Try to open the scene
When error dialog appears, choose Close
Interact with Empty scene tab

Minimal reproduction project
N/A

Seems like the empty scene tab no longer appears, but there is a new error:
C:\godot_source\editor/editor_undo_redo_manager.cpp:420 - Condition "!history_map.has(p_idx)" is true.

(after the errors in the video above)


Update syntaxhighlighter.css

Remove !important to work with Word 2016

I meantioned explained it in Issue #2


fix: accessibility improvements

Test URLs:

Before: https://main--bitdefender--hlxsites.hlx.page/solutions/
After: https://link-accessibility-improvements--bitdefender--hlxsites.hlx.page/solutions/

Failing UI Tests are not related to this PR, but rather to #289.

UI tests failures are not related to this PR. Rather to columnar content changes.


Error on show_results

Hello, I'm trying to use your implementation and saving the results to a json file. It works fine when running on my local machine, but when deploying on a server I keep getting:
streamlit_analytics.stop_tracking(save_to_json='path', unsafe_password='somepass')
display.show_results(counts, reset_counts, unsafe_password)
metric() got an unexpected keyword argument 'help'.
I'm running on python 3.7, streamlit 1.9 and analytics 0.4.1.
Thanks for your time and attention.

Ok, I found the error. From version 1.11 onwards st.metric() now accepts a help attribute. Since I'm on 1.9 I had to comment out the help string on the display.py file.


Not intuitive error message when top schema is a $ref

Consider a schema like this:
{
  "$ref":"#/definitions/apredefinedtype",
  "definitions":{
     "apredefinedtype":{
        ...
      }
  }
}

then validation will only point out that there is something wrong in "$ref" if a given Json is invalid to this schema.
Is it possible to produce more intuitive error message to help the user to locate the actual error location?

Below is a complete test:
public void Issue194_refNoIntuitiveErrorMessage()
{
var serializer = new Manatee.Json.Serialization.JsonSerializer();
			// please review following validation code after creating type is done

			var schemaJson = new JsonObject();
			//schemaJson.Add("$schema", "http://json-schema.org/draft-04/schema#");
			schemaJson.Add("$ref", "#/definitions/apredefinedtype");
			schemaJson.Add("definitions", JsonValue.Parse(
						   @"{
							""apredefinedtype"": {
								""type"": ""object"",
								""properties"": {
									""prop1"": {
										""enum"": [
											""ændring"",
											""test""
										],
										""type"": ""string""
									}
								},
								""required"": [""prop1""]
								}
							}"
						   ));

			var actual = new JsonSchema();
			actual.FromJson(schemaJson, serializer);
			var jObject = JsonValue.Parse("{\"prop11\": \"ændring\", \"prop2\": {\"prop3\": \"ændring\"}}");
			var messages = actual.Validate(jObject);
			messages.AssertValid();

	}

How do I get the actual error message of something like "prop1 is required"? So far the validate result messages only has "$ref" in it, below is the messages in Json:
{"IsValid":false,"RelativeLocation":["$ref"],"AbsoluteLocation":null,"InstanceLocation":[],"AnnotationValue":null,"Keyword":"$ref","AdditionalInfo":{},"NestedResults":[]}

With the rework of the JSON Schema implementation, I've left out the error messages in favor of identifying the keyword that failed.  In this way, the you can easily identify the keyword that caused the problem and supply your own error message that is customized for your users.
That said, it looks like identifying the keyword isn't working, so I'll have a look at that.

Okay... The $ref keywords wasn't attaching its nested results to the results object it returned.  I've fixed that and I'm getting this now:
{
  "valid" : false,
  "keywordLocation" : "#/$ref/required",
  "instanceLocation" : "#",
  "keyword" : "required",
  "additionalInfo" : {
      "missing" : [
          "prop1"
        ]
    }
}

Great, that is quick!
Can't wait to see it available in NuGet.

https://www.nuget.org/packages/Manatee.Json/
Version 10.0.5 contains your fix.

There's still a problem in there... it's missing the absoluteLocation which should point directly to the property through the definition.

Okay.  It only does that if you define a base URI (like in the $id property).
Even so, when adding the $id, it didn't build the absolute URI correctly, so I'll be updating that soon.

@lbcsy version 10.1.0 fixes an issue with rendering the absolute URI.


Should not render  as code block

Before: </tr> is rendered as a code block

After: </tr> is now part of the table's HTML

These files are auto-generated, so I think it needs to be handled in the tsconfig-reference package in this monorepo 👍🏻

Thanks for pointing out. Will look into it 😀

Ace! Thanks this looks good to me 👍🏻

Thanks!! 😊


ValueSet-validate-code: FHIRegistry looks up CodeSystem instance and not ValueSet instance leading to ClassCastException

Describe the bug
If the ValueSet-validate-code operation is used to validate some code against some value set, the server falsely returns a CodeSystem isntance during processing even though the correct class to look for is specified. This leads to a ClassCastException and terminates the operation unsuccessfully.
The origin is the org.linuxforhealth.fhir.registry.FHIRRegistry::getResource method.
If requested, I can provide error logs containing the stacktrace.
Environment
I'm using version 5.1.1 of the server.
To Reproduce
Steps to reproduce the behavior:

Post CodeSystem and ValueSet instance to server with same value in url-element (this might and shoudl not matter).
Post ValueSet-validate-code operation with parameters url, code and system to the server (url and system with same value).

Expected behavior
Irrespective of the URL used to identifiy the value set the FHIRRegistry should look up a ValueSet instance and not a CodeSystem instant and process the request properly.

Agree we should do better in this case, but this url field is like the canonical id of this definitional resource and, per the spec, should be globally unique.  In my opinion, it is unwise to use the same canonical uri for both the codesystem and the valueset.

hi @paulolaup , how are you doing? I'm a software engineer and working on FHIR server recently. I was wondering is it possible to ask you how to import a IG package into this FHIR server? If you can share your experience or provide some related links, it would be a big help for me. Thank you so much and have a great one.


added import docs and warning to privilege description

[had to bump the terraform-plugin-docs to v0.5.1 - the old version didn't work for me for some reason] - I'm not a go developer at all, apologies if this is less than optimal.

Thanks. I somehow missed that the older version did not generate the depreciation message to the docs.


Refactor Request: Only rely on IHttpContextAccessor and HttpContext on the edge

I am implementing a background cron job that attempts to mint tokens directly as a means to know that my service is healthy.  My app relys on Azure KeyVault for signing and Redis for storing refresh_tokens.
So I am pushing a request through to probe the health of the entire system.
I am using;
IHostedService and IHttpContextAccessor is not in play here..

To do that I thought I could use all these IService(s) that TokenEndpoint is using.  For the most part the abstractions are very good.
However, reliance on HttpContext deep in default services would have me replace more than I am comfortable replacing.
i.e.
public class DefaultTokenService : ITokenService
{
     public virtual async Task<Token> CreateIdentityTokenAsync(TokenCreationRequest request)
     {
...
           var issuer = Context.HttpContext.GetIdentityServerIssuerUri();
...
     }
}

When you take up your next refactoring effort, can you give thought on pulling IHttpContextAccessor and HttpContext to the edge.  One way is to rely on it only at the edge(TokenEndpoint), by pulling everything you need and pass raw data downstream.
-H

This would be a lot of changes. Are you interesting in submitting a PR? If so, it would have to wait for 3.0 where breaking changes are acceptable.

I can submit a PR for 3.0.


Cannot Install Version "0.58.0" error code "0x80073d02"

Microsoft PowerToys version
"0.58.0"
Running as admin

[X] Yes

Area(s) with issue?
Installer
Steps to reproduce
Wanted to update to 0.58.0 and the update from the software didn't work so i tried to download the installer and still didnt work.
uninstalled completely and try to install again, still didn't work
powertoys-bootstrapper-msi-0.58.0_20220524140804.log
.
✔ Expected Behavior
to install
❌ Actual Behavior
setup failed
Other Software
No response

Looks like /dup #18110, does this help?

Looks like /dup #18110, does this help?

yes! it worked, thank you!


[type:bugfix] fix grpc ci error

fix grpc ci error

Make sure that:

[x] You have read the contribution guidelines.
[x] You submit test cases (unit or integration tests) that back your changes.
[x] Your local test passed ./mvnw clean install -Dmaven.javadoc.skip=true.

for fixing ci error like this:


add support for SLSA provenance verification

example scenario: check if an image was built from a specific repo, with a specific branch/commit, include certain reviewers, etc
https://slsa.dev/provenance/v0.2

thanks for bringing this up @sozercan. Do you think the SLSA provenanace store/verifier experience will be similar to the spdx  example?
In the spdx example, the spdx verifier conifguration specified a list of allowedLicenses. Will the branch reviewer validation for the provenance likely to be specific to individual image verification?

Hi @sozercan ,we had a discussion around this item in our community meeting. We have a item tracking OPA policy integration. We want to build a general json verifier based on OPA Policy integration. (verification as OPA policy). This would avoid building specific verifier that is schema dependent.
Does this align with your vision?

We also discussed another passthrough option where ratify can return a report and keep the decision in keep based on rego policy

Options are different personas here; for ratify, it would be admin while handing in rego is policy author.

This might be something that could be leveraged: https://github.com/slsa-framework/slsa-verifier


The Sink terminal implements SaveMode functions (including SchemaSaveMode and DataSaveMode)

Search before asking

[X] I had searched in the feature and found no similar feature requirement.

Design documentation
https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=263427916
Description
saveMode stands for save mode, and the purpose is to process the table structure and existing data at the target end before synchronizing the task.
saveMode is divided into two types: existing table structure saveMode and existing data saveMode.
SchemaSaveMode：
    RECREATE_SCHEMA ：Will create when the table does not exist, delete and rebuild when the table is saved
    CREATE_SCHEMA_WHEN_NOT_EXIST ：Will Created when the table does not exist, skipped when the table is saved
    ERROR_WHEN_SCHEMA_NOT_EXIST ：Error will be reported when the table does not exist
DataSaveMode：
   DROP_DATA： Preserve database structure and delete data
   APPEND_DATA：Preserve database structure, preserve data
   CUSTOM_PROCESSING：User defined processing
   ERROR_WHEN_DATA_EXISTS：When there is data, an error is reported

Task list

[ ] Jdbc Connector Sink @chl-wxp
[ ] JDBC DB2 Sink
[ ] S3-redshift Connector Sink @chl-wxp
[ ] Iceberg Connector Sink @ic4y
[ ] StarRocks Connector Sink @chl-wxp
[ ] SelectDB Connector Sink @ic4y
[ ] Mongodb Connector Sink @ic4y
[ ] ES Connector Sink @chl-wxp
[ ] Kafka Connector Sink @chl-wxp
[ ] S3 Connector Sink @chl-wxp
[ ] doris Connector Sink  @gnehil
[ ] hive  Connector Sink  @liunaijie
[ ] iotdb Connector Sink
[ ] hbase Connector Sink
[ ] redis Connector Sink @zhibinF
[ ] rocket Connector Sink
[ ] influxdb Connector Sink
[ ] Paimon Connector Sink @Carl-Zhou-CN
[ ] Snowflake Connector Sink @HaoXuAI
[ ] Maxcompute Connector Sink
[ ] ClickHouse Connector Sink  @liunaijie
[ ] ftp Connector Sink

Usage Scenario
No response
Related issues
No response
Are you willing to submit a PR?

[X] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

I am willing to submit a PR about redis Connector Sink.

@chl-wxp  Can you add an example for this feature?

pls assign hive, clickhouse to me. And is there have basic code branch? @chl-wxp

Assign Hive, Clickhouse to you.

assign ftp to me


Slow response of "Choose limit" at [Max Purchase Price] page when switching between "No limit" and "Choose limit"

The Issue
Slow response of "Choose limit" at [Max Purchase Price] page when switching between "No limit" and "Choose limit": "Choose limit" change to "Limit to xxxx LBRY or USD" for some seconds or not changed... and same for vice versa.
Steps to reproduce

Go to [SETTINGS] page
Switch between "No limit" and "Choose limit" for some times (twice or more)

Expected behaviour
"Choose limit" will change to "Limit to xxxx LBRY or USD" or vice versa immediately.
It should work correctly as "Single-click purchasing of content less than..." at below "Purchase Confirmations" parts. The switching is very smooth.
Actual behaviour
"Choose limit" change to "Limit to xxxx LBRY or USD" for some seconds or not changed... and same for vice versa.
System Configuration

LBRY Daemon version: 0.19.1
LBRY App version: 0.21.2
LBRY Installation ID: N/A
Operating system: Windows (Windows-10-10.0.16299)
Wallet (lbryum): 3.2.0

Anything Else
It should work correctly as "Single-click purchasing of content less than..." at below "Purchase Confirmations" parts. The switching is very smooth.
Screenshots
N/A

@tzarebczan also fixed ( I can't recreate this issue on master)

@btzr-io thanks!

@namujan78 I invited you to our early testers group so you can try this out in the redesign.

@tzarebczan Where I can find out the invitation?
By the way, this issue seem was fixed in "App | 0.21.3"

@namujan78 See the #early-testing channel on discord


Roll Packages from f7b12561aeb6 to 687c8a5038c3 (6 revisions)

https://github.com/flutter/packages/compare/f7b12561aeb6...687c8a5038c3
2024-08-12<EMAIL_ADDRESS>[pigeon]: Bump org.jetbrains.kotlin:kotlin-gradle-plugin from 2.0.0 to 2.0.10 in /packages/pigeon/platform_tests/test_plugin/android (flutter/packages#7370)
2024-08-12<EMAIL_ADDRESS>[shared_preferences] Fixes get-all when suite name is used (flutter/packages#7335)
2024-08-12<EMAIL_ADDRESS>[flutter_adaptive_scaffold] Add expanded and extra large breakpoints (flutter/packages#7300)
2024-08-12<EMAIL_ADDRESS>Manual roll Flutter from b12d86157e38 to 9b8470197f42 (8 revisions) (flutter/packages#7366)
2024-08-10<EMAIL_ADDRESS>Manual roll Flutter from 76107bdf509f to b12d86157e38 (14 revisions) (flutter/packages#7358)
2024-08-09<EMAIL_ADDRESS>[shared_preferences] fix cast error and mutable list error with getStringList (flutter/packages#7355)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


Ref undefined

I use nextjs
I can’t access the ref because it is always undefined,
you don’t have to go far to find the assembly, it’s in the documentation
url https://unovis.dev/gallery/view/?collection=Maps&title=Advanced Leaflet Map

Thanks for reporting @sss1337xyz, we'll take a look


Add HEX color support in tastykitchen[ui]

It would be nice to have the option to add HEX color code when manually adding colors in the UI.
I mean here, you can see HEX code when importing a colormap but I am not able to add new colors in HEX format

Huh strange; I thought I supported it~
Would you be interested in contributing a PR? If so, it's here:
https://github.com/ahuang11/tastymap/blob/main/tastymap/ui.py#L418-L447

thanks!


geosearch improvements

add commons pageid to response
parse year from commons?
roll into one search method?
https://tools.wmflabs.org/historicmaps/berlin/index.html#map=16/52.517778/13.396944/200

http://warper.wmflabs.org/maps//geosearch?bbox=11.953785541334,50.570359811792,15.079395892772,52.783856700097&format=json&page=1&operation=intersect

There is a lot of code around for this purpose and we should bring them together.

MapWarper geosearch
Ari's search and layer demo (shown on the project page)
This display

What are the technologies / differences? To me it seems that this one is not a search but a display.
I think we should plan the functionality of these map cards and decide what data they show. In the UI design mockups they are like this:

The actions are accessed through the flyout menu on the top right corner and full metadata through the bottom right corner expanded view.

Here's a layout mockup that leaves a lot of functionality unsolved. But mainly for tuning in purposes:

We may need to split this issue across mapwarper and wikimaps-html projects.
I suggest use this issue to suggest improvements to the current geosearch interface within the mapwarper project that can be done before the new site is created.


allow MacOS OpenGL software  renderer?

Seems to work by simply replacing:

ADD_ATTRIB(NSOpenGLPFAAccelerated);

with

ADD_ATTRIB(NSOpenGLPFARendererID);ADD_ATTRIB(kCGLRendererGenericFloatID);

in src/nsgl_context.m.
An automatic (optional?) fallback would be the best option.
Would be useful for debugging OpenGL apps inside a VM. Or as a fallback for incompatible hardware. For that purpose it would then also be great to have a way to check whether hardware acceleration is in use or not.

Was it throwing a specific error?

error (65545): NSGL: Failed to find a suitable pixel format

when calling initWithAttributes.

I agree that this would be a ggreat feature, I need it for the same reason (testing an app on a MacOS virtual machine)

Is that something that is working today ? Is it possible to of this project in order to run openGL application on MacOS running within a VM ?

Idk on upstream, but if you check my linked PR (https://github.com/WerWolv/ImHex/pull/708) we've been using it in ImHex for a while now

I can answer the last question - when the software renderer is in use, glGetString(GL_RENDERER) after obtaining a valid GL context, reports itself as b'Apple Software Renderer' . On genuine Mac os desktops, we have seen b'Apple M3 Pro' and b'Apple M1' for that field (reported by some skia python users in one of our mac os x specific issues, 214) . So you can read that field to see what actual hardware/software is in use. There is probably a more convenient way.

My interests in this is github's own CI testing (which is headless), and I have no apple hardware nor VM. Looking at the code, I think it is possible to add automatic fall-back? The is no simple way of doing DELETE_ATTRIB, but it seems to be possible to do a REPLACE_ATTRIB. Slight complications of replacing 1 with 2 - I guess if we are sure it was added earlier, we can everything upward by 1, then insert the two in the middle overwriting the previous one.

I have added automatic software renderer retry if the accelerated request fails: https://github.com/glfw/glfw/pull/2571 - can somebody with genuine mac hardware gives it a try to check that accelerated opengl still works?

This is how RGFW supports this feature:
https://github.com/ColleagueRiley/RGFW/blob/d80c8bea40bb1b367941d9b119bbac9f2fa329c3/RGFW.h#L7467

I have added automatic software renderer retry if the accelerated request fails: #2571 - can somebody with genuine mac hardware gives it a try to check that accelerated opengl still works?

Sorry, did not see this earlier.
How can you know if you are using accelerated opengl or not, once the window has opened ?

I have added automatic software renderer retry if the accelerated request fails: #2571 - can somebody with genuine mac hardware gives it a try to check that accelerated opengl still works?

Sorry, did not see this earlier. How can you know if you are using accelerated opengl or not, once the window has opened ?

See https://github.com/glfw/glfw/issues/2080#issuecomment-2145902645


[Bug Report] Not allowing action buttons in single select table

Element UI version
1.4.0
OS/Browsers version
chrome
Vue version
2.4.2
Reproduction Link
https://jsfiddle.net/pj71jkyw/
Steps to reproduce
Make a single selection table and add current-change action. Now make a column and add action buttons like edit or delete. Clicking on action buttons will call the method specified in current-change of table instead of method associated with that action.
What is Expected?
In a single select table where you want to handle row selection. if you have also have actions in that row like edit and delete buttons, they should work and clicking on action buttons should call the method for that action.
What is actually happening?
In a single select table where you want to handle row selection. if you have also have actions in that row like edit and delete buttons, they don't work and clicking on action buttons call the method for row selection instead of that action.

Issues without a reproduction link will be closed directly.


if/elsif/else series of blocks as a special case for implied separator

Does this look okay? Inspired by brian d foy's question (https://stackoverflow.com/questions/45520479/is-perl-6s-uncuddled-else-a-special-case-for-statement-separation).

Cool. Looks helpful.
But why put instead of say?

For this example, it doesn't make a difference, but I've been bitten by the difference a few times.
Compare say 1 .. 5 to put 1 .. 5.
I feel that put is more predictable. It always outputs the .Str value, which is what I would expect. say outputs the .gist of a variable, which occasionally isn't what I would expect.

I'm totally fine sticking with say in this instance, if that is considered preferred by the community.

Well, the docs use say consistently. I think that yes, the example should use whatever the rest of the docs are using, unless there is some specific reason to use something else.
The .gist is supposed to be human-readable, and this is what we want almost everywhere in the docs. If .gist of something is less than awesome, then we should file it as a rakudobug. In case of .., however, you get a range object, so the .gist of it seems to be a bit more transparent. But it probably depends on the way you look at it.

Thanks! Updated puts to says.

Looks fine. By the way, put vs say is an interesting issue, there's a chance that we might want to replace a bunch (not all) of says in the docs with puts. But I think that's a separate issue.

I'm all for doing a say/put refactor, taking into account the few cases where the .gist really is desired.

I wouldn't be so eager to say that there are few cases where .gist is desired, but it's true that some things would be better off with put.

Another thing to note: put is a fairly new addition, so in case of some older parts of the docs put wasn't considered as an option.

I tried to raise the issue of put vs say with @briandfoy after looking at a preview of Learning Perl 6.  The book appears to me to prefer put and use the two a bit interchangeably whereas this discussion seems to me to suggest that say might be a preferred default for introductory examples where there is no reason to expect other software to read the output.

Your understanding is correct. I don't have access to Learning Perl 6 so can't comment on that.
When I say that docs should sometimes use put I'm mostly referring to examples like this (from Proc page):
my $p = run "cat", "-n", :in, :out;
$p.in.say: "Hello,\nworld!";
$p.in.close;
say $p.out.slurp: :close;

It does work… but realistically, how often would somebody need to pipe a gist of something into a process? This is exactly the situation where one is better off with put. In the end, someone will use that example (maybe not knowing about put at all), and there we have a user using .gist when interfacing with other programs.
We can change that example quickly, but I'm interested in seeing a more structured effort to resolve the issue (not just the one snippet that jumped at me).

This is something that should be covered by the STYLE guide, and enforced by the existing editors. (Knowing which context the sample is in isn't something that's going to be easily automatable.)

I created this issue so that we don't have to discuss it on a closed pull request: https://github.com/perl6/doc/issues/1441


added kpc

@dissicisea I am sorry, the domain for Khmelnitsky Polytechnic College is hpk.edu.ua, and the file lib/domains/ua/km/kpc.txt represents a domain kpc.km.ua, which does not exist. If you wish to add hpk.edu.ua, please rename the file to lib/domains/ua/edu/hpk.txt. Thank you!

@dissicisea Thank you for the quick change, but the filename has to be lib/domains/ua/edu/hpk.txt, not lib/domains/ua/km/edu/hpk.txt. Please remove unnecessary subdirectory "km" from there.

@philipto i've renamed, but i have question about jetbrains student license. is any another way to get license if my college doesn't have own e-mail service for students? answer, if you know

@dissicisea Yes, there are three other options. If your college does not provide students with email addresses in hpk.edu.ua domain, adding this domain to this repository does not make any sense. If students of your college don't have emails like<EMAIL_ADDRESS>please DO NOT add this domain to this repository.
Other options to get free licenses from JetBrains are:

ask your teacher to request classroom licenses from JetBrains by email to<EMAIL_ADDRESS>request the licenses using your ISIC card at jetbrains.com/student (if you have ISIC card)
send an email to<EMAIL_ADDRESS>and attach a photo of your student ID ("студенческий билет") where we can see that it is valid (i.e., not expired).

Requesting a license using your student email obtained from the university is the fastest and simplest way.
Please respond whether students at your college have emails in hpk.edu.ua domain, and I'll merge this request if yes.
Thank you!

@philipto college completely does not provide students with e-mail. so, yes, no reason for creating this domain. excuse for troubling and thank you for help


Set cursor to default on disabled button

Okay

Something wrong with build server?

build server is fixed now.

Thanks @crhym3 for fixing.
Code LGTM, thanks @faergeek :)

It was too easy :-)
I'm more interested in my second PR

LGTM, but we should probably be merging this into mdl-1.0 rather than master. I'll see if I can take care of that without asking you for a new PR :)

Merged into mdl-1.0 (thanks for the tip on how to do it with hub, @surma!)


baseUrl is incorrectly generated in child route when id parameter contains whitespace or other special characters

I'm submitting a bug report

Library Version:
1.2.1

Please tell us about your environment:

Operating System:
OSX 10.11.13

Node Version:
6.9.1

NPM Version:
3.10.8

Browser:
Chrome 56.0.29

Language:
ESNext

Current behavior:
When "id" parameter is nested child route contains whitespace or other special characters that encodeURI will encode, the baseUrl in the child route are not calculated correctly.
Expected/desired behavior:

I have an application with following nested child routes defined:
users/:id

access-ctrl

accounts
accounts/:id
others
When account details is displayed, I have links to go back to user details, access control, accounts list page.

When account id is "abc", all the links are created correctly:
Account details page: http://localhost:9000/#/users/user1/access-ctrl/accounts/abc
User details page: http://localhost:9000/#/users/user1
Access control page: http://localhost:9000/#/users/user1/access-ctrl
Account list page: http://localhost:9000/#/users/user1/access-ctrl/accounts
When account is is "test 1", baseUrl becomes empty string for User details and account list page:
Account details page: http://localhost:9000/#/users/user1/access-ctrl/accounts/test 1
User details page: http://localhost:9000/#
Access control page: http://localhost:9000/#/access-ctrl
Account list page: http://localhost:9000/#/accounts
If I encode the whitespace to %20, then User details and and first level child route Access Control links are generated correctly, but not the nested Account list child route:
Account details page: http://localhost:9000/#/users/user1/access-ctrl/accounts/test 1
User details page: http://localhost:9000/#/users/user1
Access control page: http://localhost:9000/#/users/user1/access-ctrl
Account list page: http://localhost:9000/#/users/user1/accounts

What is the expected behavior?
Whitespace and other special characters in "id" parameter should be handled properly. Users should not need to encode special characters. If special characters need to be encoded by the user, then the encoded value should be passed into the nested route instead of decoded value. In my case, even if I did encode the account id, it only works at level 1 child route. By the time it reaches level 2 child route, the id value got decoded and no longer works.

Looking at the source code, the issue is caused by this method. In the method, path is encode, while fragment is not encoded, therefore, this method can return empty string when path has special characters.
NavigationInstruction.prototype.getBaseUrl = function getBaseUrl() {
      var _this = this;
      var fragment = this.fragment;

      if (fragment === '') {
        var nonEmptyRoute = this.router.routes.find(function (route) {
          return route.name === _this.config.name && route.route !== '';
        });
        if (nonEmptyRoute) {
          fragment = nonEmptyRoute.route;
        }
      }

      if (!this.params) {
        return fragment;
      }

      var wildcardName = this.getWildCardName();
      var path = this.params[wildcardName] || '';

      if (!path) {
        return fragment;
      }

      path = encodeURI(path);
      return fragment.substr(0, fragment.lastIndexOf(path));

What is the motivation / use case for changing the behavior?

@mzhang444 Can you create a failing spec(s) for this?  If it is simply to encode the fragment that should be an easy PR.

I think this is the same problem as aurelia/templating-router#60 and should be fixed by #501


Using HUD in iphone4 and IOS7 was not work

Hi,I was used the class in my project, but there's a mistake when i was running my iphone4 and the systemVersion is 7.1.
@jdg
the crash happened here
`dispatch_async(dispatch_get_global_queue(QOS_CLASS_USER_INITIATED, 0), ^{
    // Do something useful in the background
    [self doSomeWork];

    // IMPORTANT - Dispatch back to the main thread. Always access UI
    // classes (including MBProgressHUD) on the main thread.
    dispatch_async(dispatch_get_main_queue(), ^{
        [hud hideAnimated:YES];
    });
});`

please give me some suggestions,Thanks.

Was this in the demo project? What kind of crash did you get? Please provide move details.

Demo in my repositories，just one project-LoginAndRegist. Please open LoginViewController.m and RegisterViewController.m, there are "#warning ...". Thank you.

I don't have an iOS 7.1 device around, so I can't debug this for you. If you can provide the exact crash stack trace / exception message / whatever I might be able to help a bit, but that's just about all I can do.

I'm so sorry, I can't get the exception message, when i want the application crash and get some exception message, but exception pause here in this code:
dispatch_async(dispatch_get_global_queue(QOS_CLASS_USER_INITIATED, 0), ^{
I just get the prompt in here, "Thread 1:EXC_BAD_ACCESS(code=1, address=0x30)".
libdyld.dylibstart:
0x3aa9eab4 <+0>: nop
->  0x3aa9eab6 <+2>: blx    0x3aa9eaf8                ; symbol stub for: vproc_swap_integer
0x3aa9eaba <+6>: trap`
this is Thread 1 -> 19 start.
My English is so poor, so I can't provide many descriptions.

This doesn't look like a MBProgressHUD related issue.

but the MBProgressHUD demo running in the same issue occurred on the iPhone4
发自我的小米手机
在 Matej Bukovinski<EMAIL_ADDRESS>21:48写道：
This doesn't look like a MBProgressHUD related issue.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/jdg/MBProgressHUD/issues/410#issuecomment-240416410, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AT7aBBvZYyuMVHFz2jUiX80qz5LhFQE4ks5qgxE5gaJpZM4JiwyO.

I have the same problem; app crash on [hud hideAnimated:YES] on iphone 4s with iOS 7.1.2. I going to check this today, because my app is in production......

Ok, I'm stupid....
The error was :

Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '-[MBProgressHUD hideAnimated:]: unrecognized selector sent to instance 0x15587ef0'

And the code :
 MBProgressHUD *hud = [MBProgressHUD showHUDAddedTo:self.window animated:YES]<EMAIL_ADDRESS>nil);  [sNetworkCenter syncDataBase:^(bool success) {         [hud hideAnimated:YES]; }];
I have to replace " [hud hideAnimated:YES];" with "[MBProgressHUD hideHUDForView:self.window animated:YES];" and everything work good.

Version 1.1 drops iOS 7.0 support, so closing this.


Fix Windows CI

Failing due to openssl issue

Looks like this link problem came from OpenSSL version update (3.2.0 ->3.2.1) in Chocolatey

This issue can be closed. Now Windows build is green.

closed by #5168, thank you!


#252 Fix for the https://github.com/aelassas/Wexflow/issues/252

This helped me for solving the FileWatcher Open File case.

Does onCreate event fire on large files now without the error?

Yes... Testet in both Windows.Net and .Net core, and works fine with the changes.


request for gradio UI , dataset captioning scripts

Feature request  / 功能建议
@a-r-r-o-w @sayakpaul
it would be great if a gradio UI could be made for fine-tuning CogVideoX.
Users can provide path to videos (no need to upload) , just a path.
Then hit fine-tune lora (it needs to split videos, caption it (say using BLIP), and prepare the dataset for fine-tuning.
Then run fine-tuning on single GPU and get the lora.
Users can also test inference on a different gradio UI by specifying the lora path.
It would be great if you could take this into consideration to make it super user friendly.
I could help as well making the gradio UI, if the data prep and captioning scripts are available.
Motivation / 动机
better UX UI for new comers.
Your contribution / 您的贡献
gradio UI

The repository is supposed to be hackable so, a UI is currently not on our priority. Feel free work on separately and we will try to help. Regarding captioning, see https://github.com/a-r-r-o-w/cogvideox-factory/pull/34/.

@sayakpaul what about a data prep script tho (given a path, it splits into proper chunks and also captions the videos using say BLIP 2) , can we expect that script @a-r-r-o-w

With the existing scripts, it should not be too hard. Feel free to start one if you want. Multi-frame, multi-aspect sampling are already supported. Please read dataset.md doc.

I think it might be interesting and make things easier to work with, considering that all users may not be researchers. I did get a few DMs requesting a UI too, as the different configurations can be hard to understand.
@GeeveGeorge As Sayak mentioned, we are short on time so cannot prioritize, but if you could create a prototype and open a PR, we would be more than happy to help assist. Thanks!


Implement the timer unit

TX-2-Timer-from-UsersHandbook.pdf

The timer unit (sequence 54) is documented in page 4-27 of the User's Handbook.


webview should expose inspectElement method

Feature request:
It would be useful for the webview API to include an inspectElement method like exists in the BrowserWindow API.  Debugging content in a webview would be all the more convenient if this method were available.

:+1:, I'd dig this.

I was slightly surprised a few days ago at this omission; devtools can be opened and closed, so it seemed reasonable to be able to inspectElement. I too would appreciated its addition.

+1


the path "config-root/customresourcedefinitions" does not exist

fork the repo to https://github.com/bvboca

Intall jx on on-premise kubenetes 1.18

Install git operator

The jx boot job keeps failing with:
jx gitops git setup
setup git user  email<EMAIL_ADDRESS>generated Git credentials file: /workspace/xdg_config/git/credentials with username: bvboca email:
jx gitops apply
found last commit message: Merge pull request #1 from bvboca/ChangeNetworkVersion
Change network version
last commit was a merge pull request without changing an ExternalSecret so not regenerating
make regen-none
make[1]: Entering directory '/workspace/source'
make[1]: Nothing to be done for 'regen-none'.
make[1]: Leaving directory '/workspace/source'
using kubectl to apply resources
kubectl apply --force --prune -l=gitops.jenkins-x.io/pipeline=customresourcedefinitions -R -f config-root/customresourcedefinitions
error: the path "config-root/customresourcedefinitions" does not exist
make: *** [versionStream/src/Makefile.mk:287: kubectl-apply] Error 1

Console shows:
Change network version
last commit was a merge pull request without changing an ExternalSecret so not regenerating
make regen-none
make[1]: Entering directory '/workspace/source'
make[1]: Nothing to be done for 'regen-none'.
make[1]: Leaving directory '/workspace/source'
using kubectl to apply resources
kubectl apply --force --prune -l=gitops.jenkins-x.io/pipeline=customresourcedefinitions -R -f config-root/customresourcedefinitions
error: the path "config-root/customresourcedefinitions" does not exist
make: *** [versionStream/src/Makefile.mk:287: kubectl-apply] Error 1
boot Job pod jx-boot-0097a7b8-b96c-4005-8881-674f8d819bbd-5qzgp has Failed
boot Job jx-boot-0097a7b8-b96c-4005-8881-674f8d819bbd has Failed
error: failed to tail the Jenkins X boot Job pods: job jx-boot-0097a7b8-b96c-4005-8881-674f8d819bbd failed

@jstrachan
Hi James, Could you please take a look?
Thanks!

Opened another to track the issue. https://github.com/jenkins-x/jx/issues/7895


Private Image Registry

We have a large number of EKS clusters and our deployments have test environments. To test Falcon sensor deployment as a proper deployment pipeline (think: ArgoCD/Tekton/Kluctl), this causes immediate friction and paper cuts.

So, my question is: Why does the Falcon sensor require a private authenticated registry?
I understand the when images get compromised angle but if significant portion of the time were spent living under the rock then check this out https://docs.sigstore.dev/#why-cryptographic-signing

I am not sure what the request is here. The is a helm chart-only repo. Anything w.r.t. the container images or the CS Falcon registry is out-of-scope of this repo.

Why does the Falcon sensor require a private authenticated registry?

This is both a best practice as well as good security practice for containers and container registries. For EKS with the helm charts, you can easily configure the IAM annotation for ECR access or provide a pull secret token which would then be used as part of the pipeline.

This is both a best practice as well as good security practice for containers and container registries.

I understand fully in this context what is and isn't a good security hygiene.
I am talking about when one needs to pull the image, the guideline is to ensure it is accessed from CrowdStrike's private authenticated registry.
So, my question is: what is the reasoning behind making this registry private? why not cosign, SBOM and make it publicly accessible?

Besides the fact that the sensor is proprietary and the secondary legal requirement for it being in a private registry, Cosign (image verification) and SBOM (dependency list) don't address adversary and counter-adversary operations w.r.t. container images and security sensors.
Closing this issue as out-of-scope for this project. Please contact your CS account for a discussion on this.


Proto changes for host constraints

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 65.787%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
3988

Relevant Lines:
6062

💛  - Coveralls


[WIP] DAMPlab

This PR is to consider whether changes made to DAMP lab aquarium should be incorporated into distribution.

Split into

#376
#377
#378


On Android, How to show Dropbox?

On Android, I have installed Dropbox, Google Drive but not showing on DocumentPicker.show() function. IOS is working perfectly. 👍
Are there any additional configuration(like permission) to showing external app's library?
Thanks.
Originally posted by @webmasterdragon in https://github.com/Elyx0/react-native-document-picker/issues/121#issuecomment-437285242

any solution?

what you're seeing in the picker cannot be configured from this library, the document providers are shown based on what user installed on the device


[BUG] TransformedEnv does not copy env properties

When wrapping an env in TransofrmedEnv, its properties are changed
from torchrl.envs import VmasEnv, RewardSum, TransformedEnv

if __name__ == "__main__":
    env = VmasEnv("balance", num_envs=3)
    print(env._allow_done_after_reset)
    t_env = TransformedEnv(env, RewardSum())
    print(t_env._allow_done_after_reset)

True
False

Is this a generic bug or just specific to _allow_done_after_reset?
Not sure it's really a bug in general, there are instances where one would like to have different attributes in the transformed env and in the env.
For some (eg _allow_done_after_reset?) we can have fallbacks if we're confident that there is no reason for TransformedEnv to have a different behaviour. It's already the case for batch_size, device, run_type_checks and others.
For instance, I can imagine that if one is using the no-op transform she expects the behaviour of _allow_done_after_reset to change.

We can default to the attribute value in the original env and the specific transforms can change it.


Improve readability by packing frequently used variables into namedtuples.

closes #67
Here are a few important guidelines and requirements to check before your PR can be merged:

[ ] There is an informative high-level description of the changes.
[x] The description and/or commit message(s) references the relevant GitHub issue(s).
[x] pre-commit is installed and set up.
[ ] The commit messages follow these guidelines.
[x] The commits correspond to relevant logical changes, and there are no commits that fix changes introduced by other commits in the same branch/BR.  If your commit description starts with "Fix...", then you're probably making this mistake.
[ ] There are tests covering the changes introduced in the PR.

Don't worry, your PR doesn't need to be in perfect order to submit it.  As development progresses and/or reviewers request changes, you can always rewrite the history of your feature/PR branches.
If your PR is an ongoing effort and you would like to involve us in the process, simply make it a draft PR.

@rlouf could you please help diagnose the one failed test test_nuts_mcse? It appears that the MCSE fails for one of the cases in the NUTS sampler. The changes seem fine and do not appear to change behavior so i'm a little confused.

These updates look great; I'm ready to move forward with them.

These updates look great; I'm ready to move forward with them.

I will still need to look into updating the docstrings. @rlouf any thoughts on these changes?

Merged, because these changes are already very helpful.  We can add follow-ups for the docstrings and anything else.


Adding a Metric from command line does not work as documented

When following the documentation I get the following unexpected error:
Traceback (most recent call last):
File "/home/rrowlands/miniconda3/envs/silvimetric/bin/silvimetric", line 8, in
sys.exit(cli())
^^^^^
File "/home/rrowlands/miniconda3/envs/silvimetric/lib/python3.12/site-packages/click/core.py", line 1157, in call
return self.main(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/rrowlands/miniconda3/envs/silvimetric/lib/python3.12/site-packages/click/core.py", line 1078, in main
rv = self.invoke(ctx)
^^^^^^^^^^^^^^^^
File "/home/rrowlands/miniconda3/envs/silvimetric/lib/python3.12/site-packages/click/core.py", line 1688, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/rrowlands/miniconda3/envs/silvimetric/lib/python3.12/site-packages/click/core.py", line 1434, in invoke
return ctx.invoke(self.callback, **ctx.params)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/rrowlands/miniconda3/envs/silvimetric/lib/python3.12/site-packages/click/core.py", line 783, in invoke
return __callback(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/rrowlands/miniconda3/envs/silvimetric/lib/python3.12/site-packages/click/decorators.py", line 45, in new_func
return f(get_current_context().obj, *args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/rrowlands/miniconda3/envs/silvimetric/lib/python3.12/site-packages/silvimetric/cli/cli.py", line 146, in initialize_cmd
storageconfig = StorageConfig(tdb_dir = app.tdb_dir,
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "", line 14, in init
File "/home/rrowlands/miniconda3/envs/silvimetric/lib/python3.12/site-packages/silvimetric/resources/config.py", line 105, in post_init
self.metric_definitions = { m.name: str(m) for m in self.metrics}
^^^^^^
AttributeError: 'list' object has no attribute 'name'

Awesome, thanks for finding that. Can you point me to which line in the docs caused this to fail?

It's the initialize line in this section:
https://silvimetric.com/en/latest/tutorial.html#user-defined-metrics

I kind of suspect it's because this line:
https://github.com/hobuinc/silvimetric/blob/1454d5fe0f19e57982934632f030d5c2e82c4cbd/src/silvimetric/cli/common.py#L81
Is wrapping a list inside another list.

Tested and found to happen on versions 1.2.1 and also 1.2.3

It also seems like combining a custom metrics file with builtin metrics, as specified in the documentation, doesn't work. I'm getting this error:
Error: Invalid value for '--metrics' / '-m': Failed to import metrics from /home/rrowlands/dev/projects/uasdm/silvimetric/pg2/silvimetric_metrics.py.min,max,mean with error Failed to find import file for metrics at /home/rrowlands/dev/projects/uasdm/silvimetric/pg2/silvimetric_metrics.py.min,max,mean
When I get rid of the "min,max,mean" it works.

Yeah, that has changed once or twice through the development process. -m "${METRIC_PATH},min,max,mean" is supposed to work, as well as -m $METRIC_PATH -m min -m max -m mean.
I'll take a look at this.

@rrowlands Hey just FYI, this issue plus a few others you submitted will be fixed in the next release, which is just waiting on a few things to get solidified. If you're interested in getting a working version earlier, you can pip install the main branch of SilviMetric. The documentation still has a few holes in it, but this issue plus #102 should both be fixed there.

I'm going to go ahead and close this issue. If this continues to be a problem for you, feel free to re open with more information