Raspberry PI 4  video flickering

Not sure anyone has tried a Pi 4 yet. I've got a fresh install of Raspbian Lite, I'm trying to display 2x2 @ 4k (3840x2160) resolution
Using the high quality stream from Unifi-video (1080p), it seems to work fine until the 4th stream comes up, and then I get flickering. This doesn't seem to be the video output flickering, but each video flickers: only 1 video stream shows up at a time.
Lowering the quality of the videos seems to fix this: 2 medium quality and 2 high quality streams seemed to work fine, upscaled to 1080p to fit the 4k.
Didn't test it for too long though

Unfortunately I'm having this same issue as @jeffyl. Displaycameras can usually load a few streams before the flickering occurs. I was attempting to output to a 4k TV which at first I thought was the issue, but the issue occurs at 1080p also. Thanks Anonymousdog!

What are your all's gpu memory splits?  Has anyone monitored video memory allocation during these tests?

I have tried up to 768 gpu memory split, higher doesn't work. I read about memory split on the official pi forums and it seems to rather not matter on the 3b and later. I have not monitored the GPU memory usage, not even sure how.

I was experiencing the same issues as well on pi 4. 9 screens on low output to a 1080p TV.
I changed the gpu_mem to 1024 which seem to have solved the problem for me.
https://www.raspberrypi.org/documentation/configuration/config-txt/memory.md
Not sure if this is a fix for everyone but it worked for me.

Those gpu_mem split guidelines were written for older hardware (where
settings above 512 reached diminishing returns via stealing too much system
memory).  The RPi 4 has more overall resources; so, higher splits are
fine.  I would be unafraid to try settings as high as half to two thirds of
total memory.  You're one of the first testing this hardware; so, good luck.
Ensure your testing eliminates as many variables as possible by eliminating
as many network hops as you can, running everything on Gigabit Ethernet and
robust switches.    You should be able to do
better; I've had three (carefully setup) 1080p streams running briefly on
an RPi 3B+.  Reduce the bit rate on your HD feeds if possible.
What kind of DVR are you using?
Thanks,
Andy
On Tue, Jan 28, 2020 at 3:08 PM shark92651<EMAIL_ADDRESS>wrote:

I am trying to configure a RPi4 with 4GB and a 4K TV that I recently
purchased. I am having no luck so far. Just trying to use 2 1920x1080
camera feeds I could only get one to display when I had gpu_mem set to 512.
It would switch back and forth (like a flicker, but only displaying one
feed at a time) between both feeds until ultimately one would go blank and
then the 2nd would display fine. As ahjcheng mentioned above I then tried
setting gpu_mem=1024 and I was able to get 2 1080p feeds to display,
however an attempt to display 4 of them would only display the original 2.
I then tried a lower res substream of 704x480. With this resolution I can
only get 7 or 9 to display when trying a 3x3. I'm not sure if this is just
poor support for 4k displays in the RPi4, an issue with my 4K TV, or what.
The documentation linked above states:
Values of gpu_mem over 512 are not recommended, will provide no
performance improvements, and are untested.
Something did change when I set it to 1024, in that it would allow 2 1080p
streams where when I set it to 512 it would flash back and forth between
the 2. In the end, it is very inconsistent and I can't figure out any
combination of settings that will allow me to display more than 2 streams
at 1080p or more than 7 at D1 (704x480).
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/Anonymousdog/displaycameras/issues/23?email_source=notifications&email_token=AHIYIKN52RE6QCUZ4FU2YPDRACGFNA5CNFSM4IJKFGZKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKEW44I#issuecomment-579432049,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHIYIKO6WZKF2XP3KBKMKLDRACGFNANCNFSM4IJKFGZA
.

I am not  using HD feeds, actually. I am testing with 704x480 substreams and have reduced them to 10 FPS and the lowest bitrate of 256. Despite these changes I cannot display more than 8 feeds.
I am using BlueIris for DVR but I am pulling these RTSP substream feeds directly from the cameras over gigabit network on the same LAN as the cameras.

Can you try pulling them from the DVR (for diagnostic purposes).
Andy
On Mon, Feb 3, 2020, 7:32 PM shark92651<EMAIL_ADDRESS>wrote:

I am not using HD feeds, actually. I am testing with 704x480 substreams
and have reduced them to 10 FPS and the lowest bitrate of 256. Despite
these changes I cannot display more than 8 feeds.
I am using BlueIris for DVR but I am pulling these RTSP substream feeds
directly from the cameras over gigabit network on the same LAN as the
cameras.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/Anonymousdog/displaycameras/issues/23?email_source=notifications&email_token=AHIYIKIZTZMUBSFF6ZLTTHLRBCZSXA5CNFSM4IJKFGZKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKV5JCQ#issuecomment-581686410,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHIYIKNRMUKAXG5EYFSV7HDRBCZSXANCNFSM4IJKFGZA
.


Can't use go get -u on this module with its current latest pseudo-version

This module is currently affected by an issue similar to https://github.com/openzipkin/zipkin-go/issues/114. It can be reproduced with Go 1.12 as follows:
$ export GO111MODULE=on
$ cd $(mktemp -d)
$ go mod init m
go: creating new go.mod: module m
$ go get -u google.golang.org/genproto
...
go: finding github.com/golang/lint latest
go<EMAIL_ADDRESS>parsing go.mod: unexpected module path "golang.org/x/lint"
...
go get: error loading module requirements
$ echo $?
1

To resolve this for this repository, its go.mod file needs to be updated to include newer versions of dependencies, in order to avoid pulling in older module versions that cause this conflict.
I haven't looked into the exact cause for this repo yet. It might be just a matter of waiting for https://github.com/golang/go/issues/30833 to be resolved. I'll investigate more later.
/cc @broady @bcmills

Seems to be an issue with how go modules interprets modules whose names have changed (github.com/x/lint and golang.org/x/lint). Tracking discussion in golang/go#30831.

Since this is a core issue and affects anyone depending on x/lint, I'm closing this in favour of https://github.com/golang/go/issues/30831.

@jadekler while we are waiting for a resoluton, do you mind updating your go.mod to point to the latest<EMAIL_ADDRESS>

@xomaczar What specific error are you seeing, and what version of go-genproto are you using (e.g., via go list -m all), and what version of what dependency is giving you that version of go-genproto (e.g., via go mod graph | grep go-genproto)?
There has been progress in other related issues. See https://github.com/googleapis/google-api-go-client/issues/342#issuecomment-480989557 for example.  You might need to manually change one or more versions in your go.mod though in order to then get back to being able to do go get -u.

@xomaczar Also, do the steps initially reported in https://github.com/google/go-genproto/issues/151#issue-420997066 work for you, or do those exact steps listed there still give you a parsing go.mod: unexpected module path "golang.org/x/lint" error?

+1, I'd also like to know if there are specific issues related to grpc at the moment.

@thepudds yes I can confirm the same error message mentioned by @dmitshur - however it was related to my internal module which was still using an old version of genproto.


Add service for adding event to google component

Breaking Change:
Users that want to use the new service have to reauthenticate with google by removing the existing .google.token file, restarting hass and follow instructions in persistent notification again.
Description:
Related issue (if applicable): fixes #
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#9057
Checklist:

[x] The code change is tested and works locally.
[x] Local tests pass with tox. Your PR cannot be merged unless tests pass
[x] There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

[x] Documentation added/updated in home-assistant.io

Will fix failed build tomorrow. Apparently there's something wrong with my pylint.

Do we store the scopes in the ".google.token" file ? and if so, can we detect if a token does not have the right scopes?

This is from my .google.token file, I have asked some friends if they can look at theirs to see if the scope differs, but I'm guessing it does, so we can look at that somehow?
  "token_response": {     "access_token": "mytoken",     "expires_in": 3600,     "scope": "https://www.googleapis.com/auth/calendar",     "token_type": "Bearer"   },   "scopes": [     "https://www.googleapis.com/auth/calendar"   ],

@isabellaalstrom yeah, that's it. Can you add code that if we load the tokens and see that the scopes are different, we ignore the tokens (logging them out) and forcing them to log in again?
That makes the transition a bit smoother.

Bump?

@balloob I will now schedule this in my calendar so I won't keep on forgetting it. :|

If only there was a service to help create that event

F*ck. What did I do now and how do I fix?


shap_interaction_values for DeepExplainer

Hi, I was giving the DeepExplainer a try for estimating the shap interaction value, but received the following error message:
AttributeError: 'DeepExplainer' object has no attribute 'shap_interaction_values'
Are there plans to include this feature in the SHAP library, or is there a current limit factor for implementing it?

We could implement it, but it is not at the top of the priority list right now. I think it would just involve running the Deep explainer twice for each feature while one input is constrained to either be the current input or the background, then taking the difference. But I'd have to actually write it out in detail to make sure it wouldn't run into any problems because of the recursive approximations used by DeepExplainer. I'll leave this as a todo for now.

is there any plan to add 'shap_interaction_values' to DeepExplainer now ?


Support for modifying timings?

Hello, first of all, thanks for the project, it steps up the usability and automation scene in Linux a lot!
I was wondering if it would be possible to add support to configure the timings that keyd uses in order to consider when a key is held or not.
There's a similar tool for MacOS called Karabiner, and it let's you configure the following parameters:
:alone   80 ; hold for .. ms to register single tap
:held    50 ; If it has been held for this time and no other simultaneous key has been pressed, it considers this as a tap
:delay   0  ; time after which the key press is delayed
:sim     30 ; keys need to be pressed within this threshold to be considered simultaneous

I'm trying to migrate my MacOS workflow to my Linux machine, but currently I'm having trouble due to this, as I use regular keys to enable layers.
For example: holding space enables the symbols layer, so I can press space + t and it will act as the = key, but with the current timings of keyd it makes very difficult to type, as I have to pause in order to type words, as space is constantly triggering the hold if I type too fast.
I'd really love to get this into keyd and of course, I'm volunteering to try implementing it myself, I just would need some guidelines on where to start.
Thanks again!

:alone   80 ; hold for .. ms to register single tap
:held    50 ; If it has been held for this time and no other simultaneous key has been pressed, it considers this as a tap

It is not clear what the difference between these is.

:delay   0 ; time after which the key press is delayed

Can you clarify what this means?
:sim     30 ; keys need to be pressed within this threshold to be considered simultaneous
By which I assume you mean to say that if the overloaded key is struck and another key is struck within a period of 30ms then the secondary function of the first key (e.g activating control) is not activated and it instead behaves as though it were tapped (e.g space).

I'd really love to get this into keyd and of course, I'm volunteering to try implementing it myself, I just would need some guidelines on where to start.

It's not so much the implementation that is the problem as the maintenance.  Adding these sort of configurable timeouts introduces a lot of additional state and needs to be carefully implemented so that it doesn't interfere with the core logic. It can also produce non intuitive behaviour (e.g if I hold my capslock key too long and then release it, it doesn't behave as escape), so it would have to complement rather than replace the existing sequence based tap detection.
For what it is worth the first iteration of keyd had similar timeouts in service of achieving usable home row modifiers. I even tried combining timeouts with a sequence based approach to improve usability (e.g distinguishing between <key1 down> <key2 down> <key2 up> <key1 up> and <key1 down> <key2 down> <key1 up> <key2 up> to try and divine the user's intent). While I was able to improve performance I ultimately concluded that it was impossible to achieve an implementation which completely eliminates accidental keystrokes without negatively affecting typing speed.
Having said that, overloading the space key was one of my more successful experiments. I suspect it has something to do with the frequency and speed at which the spacebar is struck. I had similar success with the backspace key.  This was some years ago, so I don't remember the precise details, but my experiments made it clear that different tap detection mechanisms were desirable depending on the usage pattern of the key.
I'm still unconvinced that supporting a multitude of timeouts is worth the effort given the complexity and limited utility, but if you can furnish your own experience with overloading the space key in particular and the kind of detection that works best, then I am open to considering adding such a feature.
I should note that I am about to release a fairly major patch and would prefer to implement any such functionality after that has achieved stabliity.  You may also want to try kmonad in the meantime.

:alone 80 ; hold for less than .. ms to register single tap
:held 50 ; If it has been held for this time and no other simultaneous key has been pressed, it considers this as a tap

These two define the following:

alone: If I press the key for less than 80ms, it will be a tap, if more, it is a hold
held: If I didn't perform a chord in 50ms, it will go back to tap. E.g. I press space for more than 130ms, it will register as a space tap

:delay 0

This is a config to allow giving the keypress some delay after it has been registered. E.g. I configure this to 1000ms, and the "virtual press" performed by the program will be done 1 second after the keypress has been registered.

Anyways, thanks for the pointers and your concerns, I'll wait for the patch you're mentioning, and in the meantime I'll try kmonad

alone: If I press the key for less than 80ms, it will be a tap, if more, it is a hold
held: If I didn't perform a chord in 50ms, it will go back to tap. E.g. I press space for more than 130ms, it will register as a space tap

Thanks for the clarification. Do you find one more useful than the other? The first one looks like it would introduce undesirable visual latency and the second looks like it would cause a lot of misfires.

:delay 0
This is a config to allow giving the keypress some delay after it has been registered. E.g. I configure this to 1000ms, and the "virtual press" performed by the program will be done 1 second after the keypress has been registered.

Can you explain the utility of this?

Anyways, thanks for the pointers and your concerns, I'll wait for the patch you're mentioning, and in the meantime I'll try kmonad

I just release 0.1.0 which introduces some major changes, though it doesn't involve any timeout logic.

If you are still interested, the latest commit adds some limited support for timeouts.

I'm closing this for now, but feel free to chime in on #34.


Problem with bootstrap modal solved

This pull request includes a

[ x] Bug fix
[ ] New feature
[ ] Translation

If this is related to an existing ticket, include a link to it as well.

Could you please reference the issue that this relates to?

Sorry This is just when i use the template inspinia


Improve coverage of get_network_driver()

Not sure if using napalm-logs to test a real module not having NetworkDriver is correct, or if we should create a specific dummy module to test.  Also test a non-string type to hit 86, napalm_eos to hit cover 94->96 jump.

Looks like a specific package would be better, as napalm-logs isn't Python3 ready. :(

@bewing please remove napalm-logs from the requirements - this is not a regular driver: see the readme (although there's no proper documentation): https://github.com/napalm-automation/napalm-logs

@mirceaulinic The point was to have a napalm_ module that does NOT contain a NetworkDriver() method, to improve test coverage in init.py.  If it's just navel-gazing, I'm OK with rejecting the PR.

@bewing what branch of the code you want to test?

@dbarrosop https://github.com/napalm-automation/napalm-base/blob/develop/napalm_base/init.py#L109

Ok, you can probably use any module already imported. Like the sys module. It doesn't necessarily have to belong to napalm.

Tried that already - if the module doesn't start with napalm_, it's prepended, so passing "sys" means we hit the non-existent module check instead of the "real module, no driver" check

if the module doesn't start with napalm_

We should probably fix that. Maybe we can add a kw argument to avoid prepending?
get_network_driver(name, prepend=True)

Sorry for the delay -- had some spam folder issues.

LGTM @ktbyers @mirceaulinic any comments?


Client Allocation Request for: Mgame

Client Allocation Questions
Core Information

Name: Mgame
Website / Social Media: https://www.mgame.com/
Region: Asia excl. Greater China
DataCap Requested: 30TiB
Addresses to be Notarized: f1wie3vdkcg23eoqhdgnx2kv33yghvjqpafuz7oay
Notary Requested: MasaakiNawatani

@Haileytokencan Please subscribe to notifications for this Issue to be aware of updates. Notaries may request additional information on the Issue.

duplicate request, closing issue.


Fix warning for PHP < 5.6

Check for 0 value before calling array_fill as PHP versions lower
than 5.6 will throw a warning.
Closes #80

Awesome, thank you kindly for merging it in and thanks again for all the time you put into this library.
Best Regards,
Mike

a new release 3.3.5 was released today with your PR merged

Much appreciated.


request_body type in #[path] is not required to exist

It looks like the parameter to request_body is dumbly translated to a string. This means, if you write a non-existant type there, it will happily accept that.
We should emit even just a basic use that ensures the type exists.

@djrenren
request_body is not required as expected, because one might perform a request that does not have a request body as it is not required to exists in schema either.
Yeah, currently there is no validation of any sort regarding the input value. Though this could be improved absolutely. I am currently working on related functionalities so I can take a look at this as well soon.

Related https://github.com/juhaku/utoipa/issues/801


No v0.22.0 tag on GitHub

Can't easily tell what's new since the latest crates.io release.

Thanks!


simplify config

Another suggestion. Would you be willing to accept a PR, that is a breaking change but tries to simplify the settings.
The current approach makes use of a rather complicated set_config.py and parses arguments individually. E.g. mqtt_base_topc: str gets translated into:
mqtt:
  base_topic: str

However, there is nothing stopping us from using this structure right away. I think of something like:
"options": {
    "data_path": "/share/zigbee2mqtt",
    "configuration": {
      "homeassistant": true,
      "permit_join": false,
      "mqtt": {
        "base_topic": "zigbee2mqtt",
        "server": "mqtt://homeassistant"
      }
      "serial": {
        "port": "/dev/ttyACM0"
      }
    }
  ...
}

The advantages are:

set_config.py becomes content independent parser.
easier to implement all options of z2m, because they only need to be defined in config.json of the addon
clear relation between z2m options and there counterpart in the addonn. They have the same name.
Future proof, because naming conflicts between the addon and z2m can be avoided

I think the disadvantages are:

breaking change
nested options (looks complicated, some people don't like it)

I much prefer the look of your proposed schema. The current setup is awkward and is mostly a remnant of a time when zigbee2mqtt configuration looked very different. Breaking change is a major drawback, but I think zigbee2mqtt is fast-moving and we make it very obvious in the changelog/release notes.

okay, then I will sit down and try to make a pr.

I'm making some progress. However the scheme I proposed can't be implemented. As can be seen here the maximum allowed depth of nested dicts is 2. What I proposed had a depth of 3 and is thus not possible.
I therefore removed the configuration layer and have all zigbee2mqtt options right within the first layer.
This makes parsing the config a little harder again, but I still think its the right way of doing it. The config parser would then just pop data_path and devices from the config and parse the rest into the configuration file.

okay, in general it seems to work. I have not found out how to easily pass the pan_id yet, since this is expected to be a hex, but maybe ints work as well.
I was also aiming to remove the setup.py completely, but I don't know yet how to pop values from json files with jq or json2yaml. Python would be easy though. Maybe for now we stick to it and later try to get rid of unnecessary dependencies. Anyhow I'm tired. I make the pr tomorrow.

needs a little help on the z2m side https://github.com/Koenkk/zigbee2mqtt/issues/1148
If this is available, we should be able to get rid of set_config.py

And I put some thought into having all default options shown in the config setting vs, just show some. Pros:

easy to find out what can be changed and how it should be changed

Cons:

harder to manage for us, because default options cant be updated by addon after initial installation
looks bloated for the user and might be confusing

I think by now setting all the default options is not a good idea.

@deisi would you mind testing the changes I've made to dev branch? I added a basic check for a config backup and, if one isn't found, cps $DATA_PATH/configuration.yaml.

@danielwelch
for some reason its not making a backup, but I don't find any error...
it seems any one of the two conditions is always false, even though there is a config file o.O

ah found the mistake
its the first test. Ther is a not too much xD
if [[ ! -f $DATA_PATH/configuration.yaml ]]; then
this should be
if [[ -f $DATA_PATH/configuration.yaml ]]; then
because we want it to back up if there is a file and not if ther is no file.

@danielwelch there is a mini pr now with this.
https://github.com/danielwelch/hassio-zigbee2mqtt/pull/127

Nice, figured it was a dumb logic typo. I’ve merged this, if you could give it a test I’d appreciate it.

currently running. I tested if it backs up a file and does. Lights work from my point of view it is fine.

Great. I'll look to merge this in the next few days. Wondering what the best way to inform everyone about this breaking change is in addition to some README updates and the usual changelog. Despite the breaking changes, I think it's a much cleaner config interface for users and eliminating the python dependency is a huge plus.


(WIP) Pipeline API

Exchanges the implicit global state of the previous Modeling API (using add_factor and add_filter) for an object-oriented API built in a new Pipeline class.
A Pipeline contains two pieces of state:

columns, a dictionary mapping column names to instances of Filter, Factor, or Classifier.
screen, an instance of Filter, which controls what rows, if any, to throw out before providing results back to the user.

The top-level entrypoint into Modelling API calculations is now FFCEngine.run_pipeline.

Still missing on this branch:

[ ] Use pipeline.screen instead of implicitly &ing all Filters.
[ ] Add tests for screen usage.
Fix internal breakage.  (Should be minimal.)


Terraform Plan results displayed as GitHub PR comment

Have the PR plan and Deployment plan ECS tasks display the terraform plan results as a GitHub comment within the associated PR. The comment could be a diff code block that contains the plan. The reason for using the GitHub diff markdown is because diff blocks highlight lines that start with + as green and - as red which is similar to the annotation within Terraform plan outputs. It would be interesting to know if there's a way to incorporate color highlighting for ~ which represents modifications within terraform plans (maybe with terraform-j2md once issue is resolved)
PR Terraform plans
Possible formats could be:
A: All plans could be consolidated within one comment

Each plan can be hidden via GitHub markdown drop downs
Compacts PR so they aren't a bunch of comments to parse through

B: Each plan could be posted within its own comment

Brings benefit of if a voter wants to comment in relation to the plan, they could "Quote reply" to the entire comment rather than specifying within their comment which PR plan they are referring to
To mitigate the issue within option A, the comment could also use the drop-down feature

Execution Terraform plans
Possible formats could be:
A: Each plan could be posted within its own comment using the drop-down feature

Have a markdown header that specifies that this plan is in relation to the execution flow and not the open PR plan

B: Same as option A but instead update the open PR plan comment

Brings benefit of consolidating all plans in relation to one Terraform configuration within one comment
Either could overwrite the open PR plan or create a separate drop-down plan below it that's labeled with the execution ID
Would require ECS tasks to parse PR to match the plan with the existing comment

foo.txt

Resolved in PR #48


Support for custom media upload servers

Fixes #734 .

cc @vitorpamplona

All conflicts resolved now. Should be OK.

Super nice, Thank you @KotlinGeekDev

@vitorpamplona would like to make a follow-up PR on this, to add an "added" status indicator to the hard-coded media servers if they are already present in the user's list.


"Upgrade" option for charts other than longhorn under "Legacy" apps not working

What kind of request is this (question/bug/enhancement/feature request):
bug
Describe the bug:
Upgrade option for charts other than longhorn chart under "legacy" apps is not working in rancher v2.6.3-rc2. After clicking upgrade option, upgrade page is NOT opening, neither it's showing any error page. Please see the steps below.
Rancher Installation option (Docker install/Helm Chart): Docker
Steps to reproduce:

Deploy rancher v2.6.2 and enable legacy feature.(from side-panel -> Global Settings -> Feature Flags -> enable legacy)
Create 1.21.6 downstream k8s cluster.
Goto cluster -> Legacy -> project -> select Project:System form the drop-down -> Launch
Deploy argo-cd, and aws-event-sources chart from catalog on downstream cluster.
Upgrade rancher to v2.6.3-rc2.
argo-cd, aws-event-sources charts would be present under "legacy apps". Click on upgrade option of the chart. Upgrade page would not open, instead it will remain on the same page after the loading screen (attached ss).

I believe this is the same issue as https://github.com/rancher/rancher/issues/35670

This issue seems addressed by https://github.com/rancher/rancher/pull/35711 and I believe no additional UI work is necessary to fix it. I did the same steps in v2.6-head and it worked.

Verified on rancher v2.6-head (e62e1ae)
Rancher Installation option (Docker install/Helm Chart): Docker
Validation steps:

Deploy rancher v2.6.2 and enable legacy feature.(from side-panel -> Global Settings -> Feature Flags -> enable legacy)
Create 1.21.6 downstream k8s cluster.
Goto cluster -> Legacy -> project -> select Project:System form the drop-down -> Launch
Deploy argo-cd, and aws-event-sources chart from catalog on downstream cluster.
Upgrade rancher to v2.6-head

Result:

Able to upgrade the charts under legacy section after upgrading rancher from 2.6.2 to 2.6-head. Working as expected.


Corrected row index usage when exploding packed arrays in vectorized reader

This PR fixes an issue in the vectorized parquet reader with respect to executing the explode function on nested arrays where the array cuts across two or more pages. It's probably possible to minimize this slightly more but I wasn't able to find a reproducer. It's also worth noting that this issue illustrates a current gap in the lower-level unit tests for the vectorized reader, which don't appear to test much related to output vector offsets.
The bug in question was a simple typo: the output row offset was used to dereference nested array lengths rather than input row offset. This only matters for the explode function and then only when resuming the same operation on a second page. This case (and all related cases) are, at present, untested. I added a high-level test and example .parquet file which reproduces the issue and verifies the fix, but it would be ideal if more tests were added at a lower level. It is very likely that other similar bugs are present within the vectorized reader as it relates to nested substructures remapped during the query pipeline.
What changes were proposed in this pull request?
It's a fairly straightforward typo issue in the code.
Why are the changes needed?
The vectorized parquet reader does not correctly handle this case
Does this PR introduce any user-facing change?
Aside from fixing the vectorized reader? No.
How was this patch tested?
Unit test (well, more of an integration test) included in PR
Was this patch authored or co-authored using generative AI tooling?
Nope

Should we have a corresponding JIRA ticket for this fix?

Is this being held up by anything? Any JIRA would be a fairly trivial transliteration of the test case that I added. Note the query and the example parquet file. That example does not work today on production Databricks instances (resulting an ArrayIndexOutOfBoundsException).


reset() => getTotalVolume()

Wouldn't it make sense to clear getTotalVolume() either during the reset() method?

I'd like to reopen this issue in order to find a solution to the problem of wether to reset total values on a call to reset() or not.
Since the FlowMeter library would lose a feature – total values strictly being monotonic (i.e. never losing volume that has been accounted for) during runtime – I'm thinking about adding a third set of values to get instead.
The meaning would be:

get volume and average flow rate since last reset
accumulate the same way total flow rate and volume are accumulated
reset to zero on every call of reset()

I think it would be rather simple to accomplish this, but I can't come up with a good name right now.
It's not a set of current values, but also not a set of total values.
It's inbetween, but the only name I could come up with so far is getVolumeSinceLastReset()...
Issues affected: #13, #21

Hey how can I reset the total volume?I like to the amount of ml it push and after with one button I want to reset it to 0 and I start the measurements again .

Hey @tasosman,
could you achieve your goal by using current volume instead of total volume?
Current volume – and other 'current' values – are affected by a reset(), because they are intermittent (only relevant for one flow event).
Total volume – and other 'total' values – are persistable values, i.e. for bookkeeping or long-term summation/statistics.

Yes I check it when I use current volume is sawing l/s but me use the total so I can see how much ml run ,but I fix that I use what are you take off of your code so I put it back and now I can reset the total volume by using the reset .it is a little only difficult to calibrate my sensor now because I use coffee machine and is passing max 400 ml/minute

Alright, thanks for the feedback.
Yes, modifying the code to also reset the total values is what most people do when they have an application like that.
Well, this thread/issue serves as a place for me to discuss this as a feature request.
So I consider your case another data point in favour of the feature. :)

Come on bro ,xaxaxaxa same passion here of course I have made 3 custom espresso machine and this is one of my last project
Best regards
Anastasios Manolidis

From: Sebastian Kraus @.>
Sent: Wednesday, December 15, 2021 1:16:54 PM
To: sekdiy/FlowMeter @.>
Cc: tasosman @.>; Mention @.>
Subject: Re: [sekdiy/FlowMeter] reset() => getTotalVolume() (#1)
Coffee machines (I'm a LaCimbali Junior user) were one of my initial motivations to create this library, along with garden irrigation.
If you'd like to discuss your sensor and its calibration, please open another issue here.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/sekdiy/FlowMeter/issues/1#issuecomment-994736149, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AJRXTPOS4YYBVH2PBPRU6ELURCBLNANCNFSM4EKD7WNA.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

I will open new one

I'm closing this issue due to inactivity.
If you have new information, please reopen it.


Wrapping text in code blocks to avoid horizontal scrolling

The Information Discrimination section looks very awkward-
https://github.com/axisgroup/evaluation-toolkit/tree/master/1.Following-best-practices

@skokenes help needed

Local editor renders this properly

I don't know if it's possible yet? Someone opened an issue about this a few years ago:
https://github.com/github/markup/issues/168
Looks like there are solutions/extensions on the user side to make reading easier, not necessarily on the creation side though.

@manasvil why do we need code blocks? can we just use quote blocks?

like this
nice thing

using quote blocks can be a little awkward as we also have our own commentary

Manually added line breaks in code blocks


Suggestion: Remove NEXT_PUBLIC Prefix for API Keys in .env File

Problem
The current documentation suggests prefixing API keys with NEXT_PUBLIC for environment variables in Next.js applications. However, this could potentially lead to security vulnerabilities as these keys may inadvertently be exposed to the client side.
Solution
The official Next.js documentation source recommends not using the NEXT_PUBLIC prefix for sensitive environment variables, such as API keys. By removing the prefix, these variables remain private and can only be accessed on the server, minimizing the risk of unintentional client-side exposure.
Reference
Next.js documentation advises against using the NEXT_PUBLIC prefix for sensitive environment variables:
"Since the environment variable API_KEY is not prefixed with NEXT_PUBLIC, it's a private variable that can only be accessed on the server. To prevent your environment variables from being leaked to the client, Next.js replaces private environment variables with an empty string."

After changing my .env file, to change all of the variables in the code, I've used following command in Linux bash:
cd frontend/src/app
for i in $(grep -rl NEXT_PUBLIC) ; do sed -i -E 's/NEXT_PUBLIC_([A-Z_]+)/\1/g' $i ; done


Add Security Policy document with details about reporting vulnerabilities

This PR adds Security Policy in the SECURITY.md file. Once added, this policy should be linked from the other repositories to make it easy to find for users and report security issues privately.

LGTM, but we should probably also change the issue template to direct people to use the email address for security issues.

Yes, but that has to be done in the next step, when linking this in the operators repo. Nobody is opening issues here.

FYI you probably want to ensure it's in .github root folder so it applies
to the whole github org
https://github.blog/changelog/2019-02-21-organization-wide-community-health-files/
On Wed, Dec 16, 2020 at 2:34 AM Jakub Stejskal<EMAIL_ADDRESS>wrote:

@Frawless approved this pull request.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/strimzi/governance/pull/4#pullrequestreview-553457442,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAPSILHYW6ATGSK2TA34QDSVBWIPANCNFSM4U5RYLCQ
.

--
Cheers,
Chris Aniszczyk
http://aniszczyk.org
+1<PHONE_NUMBER>

@caniszczyk Thanks for the link. I did not know about this feature. I will have a look.

This applies for things like CONTRIBUTING.md too :)
np!
On Wed, Dec 16, 2020 at 2:03 PM Jakub Scholz<EMAIL_ADDRESS>wrote:

@caniszczyk https://github.com/caniszczyk Thanks for the link. I did
not know about this feature. I will have a look.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/strimzi/governance/pull/4#issuecomment-746928299, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAPSIKNCDEY5ZIPVCFIIODSVEHBTANCNFSM4U5RYLCQ
.

--
Cheers,
Chris Aniszczyk
http://aniszczyk.org
+1<PHONE_NUMBER>

I moved this to the .github repo. So I will close the PR.


Update streams/documentation/docs/libraries/wasm/getting_started.md

new install method through npm (without the need anymore of clone the streams repo and build it manually)
get_link() method doesn't exist anymore, it was replaced by link attribute

Hi Arnau, i submitted the changes you requested :)


Listing Block template for Page/News Item/Event based on content type.

Still long road to go. Fixes #4765

Added the variation for listing.
Needed thought for migration.

Replicate same things for search.

📚 Documentation preview 📚: https://volto--6055.org.readthedocs.build/

@iFlameing For migration / backwards compatibility, we have 2 options:

Tell users how to run a script to update all existing blocks content with the new names
Add a mapping in the volto settings from old listing variation name to new listing variation name, so that the block can automatically convert old names when it is rendering.

I like option 2 better. It's a lot simpler for users, and still pretty easy to implement.
We'll need a section in the upgrade guide to explain how to configure this mapping if the user wants something other than the default one.

@davisagli pleaser review it once again. I will rename the variable once it is done. Same for default content type. I will register it wit config.register component.

@iFlameing this PLIP/PR is mentioned in the Plone roadmap that is about to being published next week. We should try to put some effort into this. Maybe some folks at the Salamina sprints can help. cc @davisagli @sneridagh @fredvd @jackahl


Visual artifacts in Chrome

This is actually a bug from MathJax, and it has been fixed in newer vesions, so simply updating the version that mathb.in uses should solve the bug.

+1 can this please be done/deployed?

Thanks for bumping up this issue. The latest version of MathJax has been deployed now. This issue should be resolved now.


Patch for Generalization of Image

If the user has a custom dataset loader, say for a CycleGAN, it is inevitable that he will define his own loss functions and extend the train_iter_custom. Hence there he can do whatever he wants with the real_inputs. Also since we do not know the underlying data structure of real_inputs, we cannot define the dimensions of the noise, hence he must do that for us in his function definition.

Codecov Report

Merging #33 into master will increase coverage by 0.33%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #33      +/-   ##
==========================================
+ Coverage   26.62%   26.95%   +0.33%
==========================================
  Files          23       22       -1
  Lines         939      831     -108
==========================================
- Hits          250      224      -26
+ Misses        689      607      -82

Impacted Files
Coverage Δ

losses/boundaryequilibrium.py
0% <0%> (ø)
:arrow_up:

trainer/trainer.py
0% <0%> (ø)
:arrow_up:

models/__init__.py
0% <0%> (ø)
:arrow_up:

test_models.py
100% <0%> (ø)
:arrow_up:

models/autoencoding.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74326b4...78598bc. Read the comment docs.


upgrading django to 1.8?

Is there anything to be done here with these projects? Are you all already using 1.8, perhaps with no problems? I am having problems with it, but I did the upgrade without any deliberation and things are horked. It might just be me. Or not. This is a major version upgrade, after all.
FYI, it appears that 1.8 is an LTS release and 1.7 is not.

We are already on Django 1.8 so I think that's okay.


Add an 'ignorePendingMigrations' configuration option

This adds an 'ignorePendingMigrations' option to suppress validation errors caused by the availability of not-yet-applied migrations (feature request #2128).
My use case is for a CI/CD pipeline - while developers are working on a feature branch they should be able to create and modify migrations for that feature.  However, we should be able to detect and break the build when changes are made to versioned migrations that have already been applied to (e.g.) our production database.  Running flyway validate with ignorePendingMigrations=true supports this scenario and is consistent with the existing ignore*Migrations options.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Not necessary. See #2128

Merged. I had to make some minor adjustments as you had missed a few places where this property had to be carried over (it's not easy to catch them all). Thanks for the PR and thanks for detailing your use case in #2128 .


[Proposal] recipies for some additional documentation

It may have sense to have some folder with all recipies about best practices, like adding sass support and lazy loading etc.
It could be a Wiki for a project, which is right now empty, or just a recepies folder with recipie_name.md files.
Does it make sense? So if anyone have a good practice for some feature adding he may just submit a pull request that add a new recipie in our recepie collection :+1:

Sounds good to me!
There's already a wiki in this repo. Please feel free to set up a structure you think will meet these needs. If there are any issues with this (e.g., if you don't have permission according to GitHub or something), please let me know.


DoubleEndedStream extension

This is a first stab at a skeleton implementation of the DoubleEndedStream extension.
Docs are mostly still outstanding, I'll add them in based on their Stream variation as this evolves.
I also added a dummy "Sample" implementation of DoubleEndedStream for a vec.
While not the worst, this probably needs a better name and place,
possibly even double_ended_stream::from_iter(...)?
Looking forward for any feedback and advice :)
#129

I'm kind of stuck with figuring out how and where to reexport different chunks of the API.
The first thing is that I am not 100% sure what the import structure should look like and then how to map it to files/modles/uses.
Could someone nudge me in the right direction?

@felipesere could you maybe share more details where you're getting stuck? What are you trying to do that isn't working? This is a rather large PR, and I don't have the information quite ready the way you do I think :sweat_smile:

Oops, I accidentally pushed changes onto this branch, then reset the changes with a force push. It should be all good now. If anyone's wondering what had happened; sorry about that!.


./download-models.sh:command not found

When i want to use Model Downloader tool or install pytoch, i need to run follow command in Ubuntu terminal, like
"
$ cd jetson-inference/tools
$ ./download-models.sh
"
or
"
$ cd jetson-inference/build
$ ./install-pytorch.sh
"
but it not work, what should i do now?
thanks for your help

What errors do you receive when you try to run the command?

Hi @zoulu995, what errors do you receive when you try to run the command?
Thanks for your replying.

At first I met this problem. when i enter command $ ./download-models.sh
it return
-bash: ./download-models.sh: /bin/bash^M: bad interpreter: No such file or directory
Then I found the following solutions Online
The reason is that the format of the file is dos, so it's OK to change it to unix.
View the file format, open the file with vim, press ESC key, press Shift + ：, enter "set ff" and return. You can see the file format file format = DOS
Enter "set ff = UNIX" by shift + ： and find no response. That's right.
Fileformat = UNIX can be viewed by shift + colon set FF
But after that，I enter the command $ ./download-models.sh
it return
znqc@znqc-desktop:~/PKU/Zouyuhang/github/jetson-inference/tools$ ./download-models.sh
[jetson-inference]  Checking for 'dialog' deb package...not installed
[jetson-inference]  FOUND_DIALOG=
./download-models.sh: line 553: dialog: command not found
[jetson-inference]  Model selection status:  127
[jetson-inference]  Model selection cancelled.

[jetson-inference]  to run this tool again, use the following commands:

    $ cd <jetson-inference>/tools
    $ ./download-models.sh

And then no matter how I enter this command  $ ./download-models.sh There are still problems like this.
what should i do now .

Hi @zoulu995, try running sudo apt-get install dialog, and then run the script again.
This should be installed by the script for you, but seems like it isn't for some reason.

@dusty-nv  sudo apt-get install dialog fixed for me. Now when I run the script, the dialog shows up. Thank you!


[OFFICIAL] Generated Issue: ErrorException

Please fill out the details below.
Summary: 500 on invalid userid
Steps to reproduce:
Try to execute a GET on https://api.jikan.moe/v4/users/userbyid/2
Additional Details
Jikan Parser Version: 3.0.0.x-dev@a4cf4837ad2c87703db4d7ecb9732cfa59f5c698
PHP: 8.0.15
Redis: Connected
Exception: ErrorException
Code: 0
Message: Undefined array key "url"
Trace: /var/www/jikan-rest/vendor/symfony/http-client/Response/TransportResponseTrait.php on line 129
Request: GET /v4/users/userbyid/2

Please refer to https://github.com/jikan-me/jikan-rest/issues/177


Analyze requirements to determine high level system architecture and design

[x] analysis of high-level requirements has been a success and usage of WebSockets has been understood on how to proceed.
now we're left to the planning of the architecture

Okay, I think there is a need for a bit more info on what will be the architecture.

oh, alright will make sure to add more detail on the planning. had not planned it yet though

[x] finished planning and architecture, more refinements will be added later on


Query columns with special characters not working

Query columns with special characters not working..
I have a below query and is valid query with column names with some special characters like #, $ etc
Select a#
 from b

Now when I format this query it get white space between special character and name. e.g
Select a #  from b
which makes it invalid query. As column name is a#
is there a way we can allow special characters in query or format ignore while formatting so query remains valid.

Try enclosing column name in doublequotes (tested with PG):
CREATE TEMP TABLE DEBUG ("WEIRD#" VARCHAR(32));
INSERT INTO DEBUG ("WEIRD#")
VALUES ('APPLE'),
    ('PEACH');
SELECT *
FROM DEBUG;


Personalizing the config.yaml

Can we create 5 separate personalities with such filename,
config.yaml.discorduser
config.yaml.two
config.yaml.three
config.yaml.four
config.yaml.nochange
I can't think of such personalities right now but I don't like the idea when people are going to use this and learn that by default, it's the "discord regular user" -- it's best to open the varieties of personality and allow us to quickly rename any selected file to 'config.yaml' without taxing my creativity to change how the dialogues should go.

This repo is not taking feature requests, you can talk about potential features in Discord Project Post. Feel free to fork the repo and add your own config.yaml!
Having a neutral default is good though, I will consider that.


StatelessSession.upsert()

Here's a POC for the upsert() method of StatelessSession, but I really need @sebersole to take a look at how I've done this.

Merging this, with very prominent @Incubating annotation.


Feature/add html

HTML code in the body wasn't added on the previous pull. made several mistakes with git commands in terminal.


MSID: 93013 Version: 1 DOI: 2<IP_ADDRESS>7040

"msas": "Structural Biology and Molecular Biophysics"
"msid": "93013"
"preprintDoi": "10.1101/2<IP_ADDRESS>7040"
"Reviewed Preprint posted": "2023-12-20"
"Sent for peer review": "2023-10-11"
"Posted to bioRxiv": "2023-10-07" (link: "Go to bioRxiv": "https://www.biorxiv.org/content/10.1101/2<IP_ADDRESS>7040v2/")
[PLACE PDF URL HERE WHEN AVAILABLE] See step 7
Step 1. Inform bioRxiv
Who can help: @QueenKraken, @nlisgo, @scottaubrey

[x] Manuscript is in data hub index (https://data-hub-api.elifesciences.org/enhanced-preprints/docmaps/v2/by-publisher/elife/get-by-manuscript-id?manuscript_id=93013)

Step 2. Create preview of manuscript
Who can help: @fred-atherden, @nlisgo, @scottaubrey

[ ] Manuscript is available for preview (https://prod--epp.elifesciences.org/preview/93013/v1)

[ ] Trigger import for staging: https://prod--epp.elifesciences.org/import
[ ] Sync data folder with s3://prod-elife-epp-data/data
[ ] Trigger import for staging: https://staging--epp.elifesciences.org/import
[ ] Sync data folder with s3://staging-elife-epp-data/data
[ ] Pull request created to enhanced-preprint-data
[ ] Post link to pull request below

Pull request: [PLACE LINK TO PULL REQUEST HERE]
Detailed instructions: https://github.com/elifesciences/enhanced-preprints-data#add-a-manuscript
Step 3: Awaiting public reviews and QC
Who can help: Production team

[ ] QC passed or QC not needed

Who can help: Editorial team

[x] Public reviews available on sciety (https://sciety.org/articles/activity/10.1101/2<IP_ADDRESS>7040)
[x] Manuscript and editor details at the top of this issue (Supplied by Editorial team)
[x] Reviews returned by EPP - https://prod--epp.elifesciences.org/api/reviewed-preprints/93013/v1/reviews

Example
"msas": "Genetics and Genomics", "Neuroscience"
"msid": "84628"
"version": "1"
"preprintDoi": "10.1101/2<IP_ADDRESS>4241"
"articleType": "Reviewed Preprint"
"status": "Published from the original preprint after peer review and assessment by eLife."

"Reviewed Preprint posted": "2023-01-02"
"Sent for peer review": "2022-10-28"
"Posted to bioRxiv": "2022-11-21" (link: "Go to bioRxiv": "https://www.biorxiv.org/content/10.1101/2<IP_ADDRESS>4241v1")

Editors:
Reviewing Editor
Michael B Eisen
University of California, Berkeley, United States
Senior Editor
Michael B Eisen
University of California, Berkeley, United States

Step 4: Modify manuscripts.json (no PDF)

[ ] Reviewed preprint is published to EPP (https://elifesciences.org/reviewed-preprints/93013)

[ ] Pull request created to enhanced-preprint-client
[ ] Pull request switched to "Ready for review"
[ ] Post link to pull request below

[ ] Request that a doi be registered

[ ] Post link to #enhanced-preprint comment below

Pull request: [PLACE LINK TO PULL REQUEST HERE]
#enhanced-preprint comment thread: [PLACE LINK TO COMMENT HERE]

Instructions to modify manuscripts.json

Visit: https://github.com/elifesciences/enhanced-preprints-client/actions/workflows/publish-manuscript.yaml
Click: Run workflow
Complete the form and click "Run workflow"
A successful run should result in a new pull request at https://github.com/elifesciences/enhanced-preprints-client/pulls
Open the pull request and click the "Ready for review" button to trigger tests
Once the tests pass and you are happy with the changes the PR can be merged

Example pull request: https://github.com/elifesciences/enhanced-preprints-client/pull/334/files
Once the pull request is merged in it should be available a few minutes later.

Request that a doi
Post the following in #enhanced-preprint:
@Fred can you register a doi for https://elifesciences.org/reviewed-preprints/93013

Step 5: Awaiting search reindex

[ ] Reviewed preprint is avaliable on journal homepage (https://elifesciences.org)

The search reindex is triggered once an hour. We need the reviewed preprint to be indexed as the search application serves the journal homepage.

Additional info
If needed, the jenkins pipeline to reindex search can be triggered sooner.
https://alfred.elifesciences.org/job/process/job/process-reindex-reviewed-preprints/

Step 6: Published! Request PDF generation

[ ] Post the link to the PDF url at the top of the issue

[ ] Post link to #enhanced-preprint comment below

#enhanced-preprint comment thread: [PLACE LINK TO COMMENT HERE]
Post the following to the #enhanced-preprint on slack:
@Ryan Dix-Peek please can you generate a PDF for https://elifesciences.org/reviewed-preprints/93013

Step 7: Introduce PDF to data folder and git repo

[ ] PDF is avaliable at https://github.com/elifesciences/enhanced-preprints-data/raw/master/data/93013/v1/93013-v1.pdf

Detailed instructions: https://github.com/elifesciences/enhanced-preprints-data#add-a-pdf
Step 8: Add PDF url to manuscripts.json

[ ] Reviewed preprint PDF is available for download (https://prod--epp.elifesciences.org/reviewed-preprints/93013)

[ ] Pull request created to enhanced-preprint-client
[ ] Pull request switched to "Ready for review"
[ ] Post link to pull request below

[PLACE LINK TO PULL REQUEST HERE]

Instructions to add PDF url to manuscripts.json

Visit: https://github.com/elifesciences/enhanced-preprints-client/actions/workflows/add-pdf-url-to-manuscript.yaml
Click: Run workflow
Complete the form and click "Run workflow"
A successful run should result in a new pull request at https://github.com/elifesciences/enhanced-preprints-client/pulls
Open the pull request and click the "Ready for review" button to trigger tests
Once the tests pass and you are happy with the changes the PR can be merged

Example pull request: https://github.com/elifesciences/enhanced-preprints-client/pull/397/files
Once the pull request is merged in it should be available a few minutes later.

Step 9: Done!

[ ] Kettle is on!

version 1 loaded instead of version 2


Packagist dev-master use Laravel 4

It this a mistake, that dev-master 0faaca3238afdb7e8e6c239f65cb26f353b51209 points to master and not to the develop branch? Still use L4 and throws BadMethodCallException. Call to undefined method [package]
Which version should we use for L5 with composer?

Closing because project is no longer maintained. Thanks.


P.S.A. Packages with explicit agreements in manifests removed

Several packages were passing explicit arguments representing agreements to the installers to achieve a silent install. These packages are being evaluated to see if they will succeed with a non-interactive configuration with those explicit arguments removed. If they will not succeed, they will be removed.
We are working on a short-term solution to display the agreement URL fields via winget show if "--accept-package-agreements" is passed. Otherwise, the user will be prompted.

Affected Packages

[ ] NI.ni-packagemanager
[ ] NhekoReborn.Nheko
[ ] KhronosGroup.VulkanSDK
[ ] ESET.Nod32
[ ] ESET.Security
[ ] Segger.EmbeddedStudioARM
[ ] Rowley.CrossWorks
[ ] nomic.gpt4all
[ ] Microsoft.ServiceFabricRuntime
[ ] veeam.veeam-agent
[ ] XmacsLabs.Mogan
[ ] Zoom.ZoomRooms
[ ] Kingsoft.WPSOffice.CN
[ ] Kingsoft.KingsoftPDF - 1 Version
[ ] Splunk.UniversalForwarder
[ ] VMWare.WorkstationPlayer
[ ] VMWare.WorkstationPro
[ ] Tableau.PrepBuilder
[ ] Tableau.Desktop
[ ] Tableau.Reader
[ ] Tableau.Public
[ ] IDRIX.VeraCrypt
[ ] Bitvise.SSH.Server
[ ] Bitvise.SSH.Client
[ ] Microsoft.PowerBIReportBuilder
[ ] Microsoft.PowerBIDesktopReportServer
[ ] Microsoft.PowerAutomateDesktop
[ ] Microsoft.PowerBI
[ ] Microsoft.SQLServer2012NativeClient
[ ] WHTA.Tamara
[ ] Atlassian.Sourcetree (Wix Installers only)

Removing these packages caused some issues for our organization, as we were relying on some of the packages for automated deployments that started failing while I was on holiday at the end of the year. I think it would have been best to wait until after the holidays to make this change to give everyone some time to make adjustments without running into change freezes or having people out on holiday.

@denelon Are the relevant teams at Microsoft informed about fixing their respective installers?

Any update?

When is the fix (short or long term) coming in? I see the --accept-source-agreements and --accept-package-agreements flag, but how do I implement it in a manifest? (also which is used for which situations).
EDIT: I realize that there is the Agreements parameter, but it is not documented in schema or otherwise. I am trying to implement it in a PR (https://github.com/microsoft/winget-pkgs/pull/136114) but I will just have to use the info from https://github.com/microsoft/winget-cli/issues/200 and https://github.com/microsoft/winget-cli/pull/1347/files#diff-851d289ea5f2ac425d19f54c568328e3557b0928478bed123b4232dd4189c8db to implement it.

When is the fix (short or long term) coming in? I see the --accept-source-agreements and --accept-package-agreements flag, but how do I implement it in a manifest? (also which is used for which situations).
EDIT: I realize that there is the Agreements parameter, but it is not documented in schema or otherwise. I am trying to implement it in a PR (#136114) but I will just have to use the info from microsoft/winget-cli#200 and microsoft/winget-cli#1347 (files) to implement it.

The Agreements section of the manifest is what needs to be added to resolve this issue. However, submitting a manifest with Agreements currently will be blocked as that field requires verified publishers currently. I believe that @denelon is working on a solution to allow the agreements without being a verified publisher, which will allow many of these packages to be re-added

When is the fix (short or long term) coming in? I see the --accept-source-agreements and --accept-package-agreements flag, but how do I implement it in a manifest? (also which is used for which situations).
EDIT: I realize that there is the Agreements parameter, but it is not documented in schema or otherwise. I am trying to implement it in a PR (#136114) but I will just have to use the info from microsoft/winget-cli#200 and microsoft/winget-cli#1347 (files) to implement it.

The Agreements section of the manifest is what needs to be added to resolve this issue. However, submitting a manifest with Agreements currently will be blocked as that field requires verified publishers currently. I believe that @denelon is working on a solution to allow the agreements without being a verified publisher, which will allow many of these packages to be re-added

Oh ok, should I keep my PR as a draft or should I close and re-open once the solution's out?

Guys, any update on this issue?

Hey everyone, we have the updated policy implemented for the community repository. We're now allowing packages to be added back with agreements with explicit switches being passed to installers.

I'm going to go ahead and close this issue since we have the ability to accept these packages back into the community repository, but I will keep this message pinned until the packages have been added back.

All removed packages have been restored. I'm unpinning this issue now.


Suggest map for degenerate foldr

Given:
foldr (\curr acc -> f curr : acc) []

We should suggest map.

Done. Required some changes to the matching code, which lead to a wholesale split/refactor of the unification logic - much cleaner now.


Added python-redis for 14.10 -> 16.10

Updated rosdep python package list for ubuntu 14.10 through 16.10 for the python-redis package.

@josephduchesne Is it possible to add the entry for zesty (17.04) as well ?

Since all the Ubuntu entries are the same it would be easier to just fold it into ubuntu: [python-redis] to avoid any future work on this.

Thank you for iterating on this.


SwapneelM-added-djsce-ac-in

Added D.J. Sanghvi College of Engineering, Mumbai

@SwapneelM Pull request merged. Thank you!


Update 404.html

Added Style to Error Message. The error message is responsive now.

How do i fix travis ci build?


chore(ui): Remove jsx-a11y from ESLint config

Description
~My bad to base on another branch without need :(~ rebased to remove commits
These lint rules apply to HTML elements and attributes, therefore have continually decreasing relevance because continually increasing proportion of UI code renders HTML indirectly via PatternFly elements.
Residue

Remove from devDependencies after change from yarn to npm.

User-facing documentation

[x] CHANGELOG is not needed
[x] documentation PR is not needed

Testing and quality

[x] the change is production ready: the change is GA or otherwise the functionality is gated by a feature flag
[x] CI results are inspected

Automated testing

[ ] added unit tests
[ ] added e2e tests
[ ] added regression tests
[ ] added compatibility tests
[ ] modified existing tests

How I validated my change

yarn lint in ui/apps/platform
yarn build in ui/apps/platform

/test gke-ui-e2e-tests


Revised slope deflection

Theoretically improves player deflection when colliding with slope edges. The old method simply checked for a slope above or below the current position and ignored the slope's aspect angle, resulting in funky behaviour with certain setups. This new method does a slightly more advanced geometry assessment to provide more accurate collision.

I don't have big objections because I don't fully understand the difference between approaches and still waiting for demo video to know the changes :)


ALTO to Flattened JSON word-coordinate data

Make word-coordinate JSON derivative from ALTO, using NDNP sample data as test fixture, and returning JSON output that is equivalent to what we are getting from OCR.
Acceptance criteria

Preserve coordinates for all words
Ignore white space tokens in ALTO
Component or method takes as input ALTO as String or path to file, returns well-formed JSON as String
JSON returned must conform to same object structure as that we are creating from OCR process.

Closing, completed by merge of PR #60.


DS - SnackBar Component Flagship Work Setup

Description
This is a ticket for Product to create an epic and work with Flagship to plan the work.
Notes

Acceptance Criteria

[ ]   Discuss with the team any specifics of implementing this component into the app
[ ]   A ticket has been created for the app teams to install the new component

For this AC:

Discuss with the team any specifics of implementing this component into the app

some technical recommendations from tech discovery (may change during implementation):

Remove bottomOffset from redux and generally remove the SnackBar (app level name, design system is Snackbar) component slice

Design system Snackbar component will handle setting when showing Snackbar (since it is dismissed on navigation, should not need updating height)

Should be able to clean up global.d.ts and src/App.tsx of custom config alongside plugging in the design system Snackbar per documentation
While calling the Snackbar directly via snackbar.show(...) and snackbar.hideAll() will be possible, it is recommended to use design system provided convenience functions when possible as they bake in logic and automatically adjust to changes where manual calls may need more updating
Remove SnackBarConstants from src/constants/common.ts as no longer relevant
Recommend removal of SnackbarMessages typing that mandates success-/error-Msg properties and conditionally includes undo(Error)Msg

Depends on screen, but rarely seems to be beneficial vs just plugging in the translation text--context both from surrounding logic and translation name clarifies what the Snackbar is appearing for

Should be able to clean up appreciable snackbar-related parts of app-level theme

Additional note:

When testing announcing the Snackbar for accessibility, some conflicting behavior with app-level setting focus to the back button was observed as documented on this PR

Unclear how this should be resolved, but something to be cognizant during implementation into flagship

Snackbar accessibility functions correctly with RN 0.74 or higher.  Flagship is currently on 0.73.


Possibility to add sorting option?

Would it be possible to add a sorting option to the wishlist results? I would like to use the discount sort so I can see the top x games with the highest discount on my wishlist

@richardswesterhof Are you referring to the values in this sensor? https://github.com/boralyl/steam-wishlist#sensorsteam_wishlist_your-profile-id

I think you are asking for an option to allow sorting with this custom card: https://github.com/boralyl/steam-wishlist#displaying-in-lovelace
If that's what you are looking for I can add that to the card's repo over here: https://github.com/custom-cards/nintendo-wishlist-card

Great, it would be much easier to add sorting options to the card, so I'll add them there.

@richardswesterhof I added 2 new config options for sorting in the latest release: https://github.com/custom-cards/nintendo-wishlist-card/releases/tag/v2.3.0
Let me know if you have any problems.


feat: extract words from case-styled completeStr  for mocword

The tests describe the details.

Merged.


Fixed alignment and arrangement of blogs styling

Tips

Thank you very much for contributing to Apache Hudi.
Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.

What is the purpose of the pull request
Fixed alignment of blogs and their respective blog pages
(For example: This pull request adds quick-start document.)
Earlier it was like this -

now -

responsiveness -

normal dimensions -

responsiveness -

Brief change log
(for example:)

Modify AnnotationLocation checkstyle rule in checkstyle.xml

Verify this pull request
(Please pick either of the following options)
This pull request is a trivial rework / code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added integration tests for end-to-end.
Added HoodieClientWriteTest to verify the change.
Manually verified the change by running a job locally.

Committer checklist

[ ] Has a corresponding JIRA in PR title & commit

[ ] Commit message is descriptive of the change

[ ] CI is green

[ ] Necessary doc changes done or have another open PR

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

Thanks so much for the contribution, can we have a screenshot here ? To reflect the changes more clearly.

Thanks so much for the contribution, can we have a screenshot here ? To reflect the changes more clearly.

Added the screenshots


Adds setting CMS_INTERNAL_IPS

Implements a means of restricting the toolbar to specific IP address or ranges (if iptools is used).
Includes tests and docs.

:+1:

In -0 on introducing this within 3.2.1, especially with a warning emitted by default

Warning removed.

Rebased

Rebased to develop (3.3)

@mkoistinen looks like the rebase messed up the branch.

It looks like it, yes, but only because the PR is still wanting to merge to 3.2.x.

@mkoistinen afaik you can't.. need to close the pr and open it again targeting the develop branch

I have never seen so many +1's in my life: https://github.com/isaacs/github/issues/18

Closing to move to new target branch ('develop')

Coverage increased (+0.005%) to 89.269% when pulling d0aac0f7b2d72ffceed7560f7c8eb77c4d6b011d on restrict_toolbar_to_internal_ips into 31c4f422a8aab9e06bc12a60415271619de0acf9 on release/3.2.x.


Feature request: another library like DirectML to support non-NVIDIA GPUs

I love this software, but I wish it could do GPU conversion on non-NVIDIA ones.
Is there any plan for it?

I implement a version with DirectML in Aloereed
/
ultimatevocalremovergui-directml. I hope you will give it a try. This implementation works fine with VR Architecture on my Intel Arc A770, but Demucs and training are not available yet.
I'm also looking forward to an official implementation, on the Intel/AMD platform.


CachePanel: monkeypatch Django's caches across sys.modules

Fixes https://github.com/jazzband/django-debug-toolbar/issues/799.
TODO:

[ ] cleanup (consistent naming)
[x] test(s)

This might work, but looks really really evil :-/

Maybe https://github.com/jazzband/django-debug-toolbar/pull/800 would be less intrusive then?
I was not aware that I did another PR already when doing this one..

@blueyed could you please update this PR and fix the conflicts?

Would be good to get a go considering its "evil-ness" before.
/cc @matthiask @aaugustin

Aside from a general feeling that this could cause issues, I don't have a strong opinion on this. If you're ready to support users after this change, you can merge it.

The relevant code has changed a lot in this area. Please resubmit if you still want to work on this. Thanks in advance!


Syntax and examples don't match for NumberBin

The syntax section says NumericBin while elsewhere in the page NumberBin is used. I think they should match!

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 576ea1c7-6792-0059-a5a9-94d49dc89af5
Version Independent ID: a4e9dd71-ce6e-b750-4ae7-6841b0fe93c7
Content: NumberBin - Azure Cosmos DB for NoSQL
Content Source: articles/cosmos-db/nosql/query/numberbin.md
Service: cosmos-db
Sub-service: nosql
GitHub Login: @jcodella
Microsoft Alias: jacodel

@mikaelweave Thanks for your finding, we will look in to it and update as appropriate


stop using debounce and use github's way of rendering markdown.

in create event page, there's a markdown render where it renders out immediately using debounce, it causes cursor mismatch when it gets saved, this task will help mitigate that.


[Steam Wishlist Discount Notifier] Addon doesn't show anything when trying to check wishlist.

Extension name
Steam Wishlist Discount Notifier
Bug Description
Addon doesn't show anything when trying to check wishlist. But notifications work fine. My Steam profile is fully public account.
To Reproduce
Always.
Logs
extensions.log
playnite.log
Screenshots

This is happening to me as well.  The wishlist loaded up correctly on first load, and then never again.  I uninstalled the addon, removed the data folder, and then reinstalled and again no data loaded. Currently using Playnite 10.16


PostgreSQL Sample implementation

Part of #3266

@drostron this is ready for review (small PR :) )


Bump 3.13 to non dev

Doing this PR to also check why tests in #3639 are broken
Summary by Sourcery
Update the testing configuration to use Python 3.13 instead of the development version 3.13-dev in both the GitHub Actions workflow and Nox test sessions.
CI:

Update the GitHub Actions workflow to use Python 3.13 instead of 3.13-dev for testing.

Tests:

Modify the Nox configuration to include Python 3.13 in the Django test sessions, replacing Python 3.11.

I think we can't run Django 4.0 and 3.2 tests with 3.13 as they use the cgi module, which was deprecated and got removed.


Add support for gitea as a remote

Gitea is a popular, lightweight alternative to GitHub or GitLab and becoming increasingly popular. It would be nice to add native support for it as a remote. Currently one has to set up a custom remote and specify all the urls to fully use it.

Sounds like a good idea. Would you mind opening a PR to add it or get it started? I'd be happy to help point in the right direction, etc.

If you could point me to where I should get starter/what needs to be implemented I would be happy to help

I'd be happy to help also!

You can use github as an example to copy from: https://github.com/eamodio/vscode-gitlens/blob/e657def760a118197a9e65a11c8899ddf08e01c2/src/git/remotes/github.ts
And it needs to be added in here:
https://github.com/eamodio/vscode-gitlens/blob/cf5a394f8ec8dbf39c6b4c96022438d08ed12571/src/git/remotes/factory.ts

Can you please verify this fix in tomorrow's insiders edition?
You can install the insiders edition from here. Be sure to disable/uninstall the stable version of GitLens first.

Yes everything seems to work as expected (apart from the problems with tags I already described in the PR).

Hey guys,
in this issue were the avatars treated?
I was studying a Gitea implementation to support its avatars, and I ended up finding this issue.

@AlencarGabriel No, this support for Gitea doesn't include "rich" support which covers avatars.

It's ok.
To implement this it's necessary to adjust in src/avatars.ts and to treat separately as the implementation of GitHub?

Ideally it would be a full "rich" provider implementation similar to GitHub, and the PR for GitLab (that I will be merging in soon)

Understood.
I'll evaluate how avatars work in Gitea, and after the next version comes out, I try to implement the "rich" provider.


one client, several api resources consent issue

if ive setup one client, with several api resources,
ex.
like one site, but i have one administration part and one "user" part, when i try to authenticate against these,
i get to the consent screen, when accepting the consent it will be replaced with the most recent accepted consent, iam guessing the consents should merge with the accepted scopes.
ill try to explain this in a example
Client A, has 2 Resources

Foo Api Resource with Foo Api Scope
Bar Api Resource, with Bar Api Scope

User connects to client A, and requires Foo Api Scope, and needs to accept the consent for the Api scope, the user press ok, and the persisted grant is saved.
here is the faulty behaviour
User connect to Client A, and Requires the Bar Api Scope, and needs to accept the consent since the Bar Api Scope, isnt approved. when this happens the previous Foo Api Scope persisted grant is replaced by the Bar Api Scope, here i guess they should merge instead?

Did look into the code more now, seems that we only get single from the persisted grants, and in the database there are 2 persisted grants, one for the the Foo Api Scope, and one for the Bar Api Scope.

currently investigating what might be the cause, the correct behaviour should be that there should be 2 persisted grants for the user, one with Foo Api Scope, and one grant with Bar Api Scope


pull request for e2e test at 01/11/2017 07:45:14

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


live dash stream

Please follow the guide below

You will be asked some questions and requested to provide some information, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your issue (like this: [x])
Use the Preview tab to see what your issue will actually look like

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2018.06.02. If it's not, read this FAQ entry and update. Issues with outdated version will be rejected.

[ ] I've verified and I assure that I'm running youtube-dl 2018.06.02

Before submitting an issue make sure you have:

[ ] At least skimmed through the README, most notably the FAQ and BUGS sections
[ ] Searched the bugtracker for similar issues including closed ones
[ ] Checked that provided video/audio/playlist URLs (if any) are alive and playable in a browser

What is the purpose of your issue?

[ ] Bug report (encountered problems with youtube-dl)
[ ] Site support request (request for adding support for a new site)
[ ] Feature request (request for a new functionality)
[ ] Question
[ ] Other

The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your issue

If the purpose of this issue is a bug report, site support request or you are not completely sure provide the full verbose output as follows:
Add the -v flag to your command line you run youtube-dl with (youtube-dl -v <your command line>), copy the whole output and insert it here. It should look similar to one below (replace it with your log inserted between triple ```):
[debug] System config: []
[debug] User config: []
[debug] Command-line args: [u'-v', u'http://www.youtube.com/watch?v=BaW_jenozKcj']
[debug] Encodings: locale cp1251, fs mbcs, out cp866, pref cp1251
[debug] youtube-dl version 2018.06.02
[debug] Python version 2.7.11 - Windows-2003Server-5.2.3790-SP2
[debug] exe versions: ffmpeg N-75573-g1d0487f, ffprobe N-75573-g1d0487f, rtmpdump 2.4
[debug] Proxy map: {}
...
<end of log>

If the purpose of this issue is a site support request please provide all kinds of example URLs support for which should be included (replace following example URLs by yours):

Single video: https://www.youtube.com/watch?v=BaW_jenozKc
Single video: https://youtu.be/BaW_jenozKc
Playlist: https://www.youtube.com/playlist?list=PL4lCao7KL_QFVb7Iudeipvc2BCavECqzc

Note that youtube-dl does not support sites dedicated to copyright infringement. In order for site support request to be accepted all provided example URLs should not violate any copyrights.

Description of your issue, suggested solution and other information
Explanation of your issue in arbitrary form goes here. Please make sure the description is worded well enough to be understood. Provide as much context and examples as possible.
If work on your issue requires account credentials please provide them or explain how one can obtain them.

can't parse bbc live dash stream - can you add support for this
C:\Users\U\Desktop\youtube-dl>youtube-dl -v a.files.bbci.co.uk/media/live/manifesto/audio_video/simulcast/dash/uk/dash_abr_hdtv/llnw/bbc_one_hd.mpd
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['-v', 'a.files.bbci.co.uk/media/live/manifesto/audio_video/simulcast/dash/uk/dash_abr_hdtv/llnw/bbc_one_hd.mpd']
[debug] Encodings: locale cp1252, fs mbcs, out cp850, pref cp1252
[debug] youtube-dl version 2018.05.09
[debug] Python version 3.4.4 (CPython) - Windows-10-10.0.17134
[debug] exe versions: none
[debug] Proxy map: {}
WARNING: The url doesn't specify the protocol, trying with http
[generic] bbc_one_hd: Requesting header
WARNING: Falling back on generic information extractor.
[generic] bbc_one_hd: Downloading webpage
[generic] bbc_one_hd: Extracting information
ERROR: No video formats found; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmplwokk3j3\build\youtube_dl\YoutubeDL.py", line 792, in extract_info
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmplwokk3j3\build\youtube_dl\extractor\common.py", line 503, in extract
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmplwokk3j3\build\youtube_dl\extractor\generic.py", line 2283, in _real_extract
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmplwokk3j3\build\youtube_dl\extractor\common.py", line 1193, in _sort_formats
youtube_dl.utils.ExtractorError: No video formats found; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.

Not supported.


It lost something when I using Win2d render

hi, I am using LottieUWP to develop a new uwp application, and I added a new method in your LottieDrawable class,so it can be rendered by win2d CanvasRenderTarget,but it doesnt work well,it lost something(for the following example its eyes).
I create a repository for display the problem:
https://github.com/HHChaos/LottieUwpTest

Added method in LottieDrawable.cs###
public CanvasCommandList GetCanvasImage(ICanvasResourceCreator resourceCreator, float scaleX, float scaleY)
    {
        lock (this)
        {
            var commandList = new CanvasCommandList(resourceCreator);
            using (var session = commandList.CreateDrawingSession())
            {
                var width = _composition.Bounds.Width * scaleX;
                var height = _composition.Bounds.Height * scaleY;
                if (_bitmapCanvas == null || _bitmapCanvas.Width < width || _bitmapCanvas.Height < height)
                {
                    _bitmapCanvas?.Dispose();
                    _bitmapCanvas = new BitmapCanvas(width, height);
                }

                using (_bitmapCanvas.CreateSession(resourceCreator.Device, (float) width,
                    (float) height, session))
                {
                    _bitmapCanvas.Clear(Colors.Transparent);
                    LottieLog.BeginSection("Drawable.Draw");
                    if (_compositionLayer == null)
                    {
                        return null;
                    }

                    _matrix.Reset();
                    _matrix = MatrixExt.PreScale(_matrix, scaleX, scaleY);
                    _compositionLayer.Draw(_bitmapCanvas, _matrix, _alpha);
                    LottieLog.EndSection("Drawable.Draw");
                }

            }

            return commandList;
        }
    }

Hi @azchohfi , HHChaos is my teammate and we are developing the 'Letsdraw' UWP App, Which used Win2D to render hand-drawing and 2d animation. And in this version we added support for Lottie element, so we tried to use LottieUWP and Win2D to render it, but it doesn't work well in HHChaos' issue. So please help us to check if there are some issues in our code, or should we use this method to render it with LottieUWP and Win2D, Thanks!

@azchohfi
This  problem has been solved, you can closed this issue.
The bug appeared to be related to the CanvasCommandList infinite size, and when I replaced it with the CanvasRenderTarget, it work well!

Perfect! Thanks!


Optional middleware

Not all current versions of volkszaehler are still using middleware.php in their path. This PR introduces an optional parameter that allows to set a boolean flag if the URL should be either "{schema}://{host}:{port}/data/{uuid}.json (new) or {schema}://{host}:{port}/middleware.php/data/{uuid}.json (old).
Happy to receive any feedback you may have!

looks good for me

looks good for me


Completed the todo to generate the icon font without icomoon.

Added node/gulp.
Replaced eot with woff2 as that should be better going forward and faster.
Added sample preview HTML generation to see the icons in action.
Addes SASS boilerplate icon generation.

Only one buggered icon:

Fixed the pencil by making it larger. We could probably do the same for all of them to ensure their quality when converted to fonts.  I'd suggest 1000px instead of 15px.
I normalized them in the gulp file but it's nice when they all start that size.

I'd like to match up the numerical codes in the SVG file name some how but I'm not sure the correlation between those and the unicode characters?

@joelpittet This looks good. It’s been a long time since I worked on this though, so I’m not 100% confident evaluating it. Any chance yourself or someone else in the Drupal community would like to take over maintenance of the project?

I'd be happy to take it over until someone else wants to.  How do I go about doing that?

I can transfer ownership easily, but not if you already have a fork of the repo. For the moment, I’ve added you as a contributor.

Now that you’ve merged this, if you delete your fork, I can transfer ownership. Just let me know!

Thanks @ry5n Yeah only did this because I saw the TODO and had the tools laying around and wondered if they still worked:) Fun project!

:)

Deleted, if you want to keep it I can just dev and push here if you prefer.


Create azure_storage_blobs crate from azure_storage::blob

As per: #483
This is work in progress. I've created the new crate, and the main code builds but there is some cleanup to do.  I have moved the blob examples and the unit tests work.
I had similar issues as I did when creating the azure_messaging_queues crate (https://github.com/Azure/azure-sdk-for-rust/pull/493).

A circular reference between the new azure_storage_blobs crate and azure_storage, as StorageClient implemented a list_containers method.  I resolved in a similar way as I did for azure_messaging_queues - created a new service client BaseBlobService (name based on the equivalent object in the Python SDK) in azure_storage_blobs that is just a wrapper around StorageClient, then moved the list_containers method to that.

I'm open to suggestions about the BaseBlobService name.  It is a "client", and all the other clients have Client in the name.  However I opted for matching the Python SDK naming.

Various private or pub(crate) modules/methods in azure_storage that had to be made pub to allow access from the new crate.

Thanks @johnbatty, appreciate your efforts!

I'm open to suggestions about the BaseBlobService name.  It is a "client", and all the other clients have Client in the name.  However I opted for matching the Python SDK naming.

I can't find the BaseBlobService in the Python SDK, but I did find BlobServiceClient which matches .Net and Java.

@thovoll Ah - thanks for the BlobServiceClient tip - I'll change the name to match that.  I didn't pay enough attention to my search, and ended up looking at the "Azure SDK for Python Legacy", which I presume is an outdated release!
https://docs.microsoft.com/en-us/python/api/azure-storage-blob/azure.storage.blob.baseblobservice.baseblobservice?view=azure-python-previous&viewFallbackFrom=azure-python

I'm looking forward to these being split up. There is a conflict.

I've noticed that there are some inconsistencies in the examples for the storage APIs.  I'd like to make them more consistent, so would like to get agreement on the style before I do so.
A typical example that uses storage does this (from identity/examples/device_code_flow.rs):
    let http_client = azure_core::new_http_client();
    let storage_account_client = StorageAccountClient::new_bearer_token(
        http_client.clone(),
        &storage_account_name,
        authorization.access_token().secret() as &str,
    );
    let blob_service_client = storage_account_client.as_blob_service_client();
    let containers = blob_service_client.list_containers().execute().await?;

Another example (from storage_blobs/examples/blob_00.rs):
    let http_client = azure_core::new_http_client();
    let storage_account_client =
        StorageAccountClient::new_access_key(http_client.clone(), &account, &master_key);
    let storage_client = storage_account_client.as_storage_client();
    let blob = storage_client
        .as_container_client(&container)
        .as_blob_client(&blob);

    let response = blob
        .get()
        .range(Range::new(0, 1024))
        .execute()
        .await?;

Issues:

A _client suffix is usually used on most, but not all, variables. Should we do this in all cases?

e.g. in the second example blob is a client - should it be called blob_client?
I'm inclined to use blob_client, as although it is more verbose, it is more consistent and matches this Python SDK example

In most cases we need to create a series of clients, e.g. storage_account_client => storage_client => container_client => blob_client.  If we don't need the intermediate clients, should we chain these calls together to remove the intermediate variables.  e.g. in the second example we could change it to:let storage_client = StorageAccountClient::new_access_key(http_client.clone(), &account, &master_key)
                          .as_storage_client();

Or to take it one stage further:let blob_client = StorageAccountClient::new_access_key(http_client.clone(), &account, &master_key)
                           .as_storage_client()
                           .as_container_client(&container)
                           .as_blob_client(&blob);

To simplify this further I could implement as_container_client(...) for StorageAccountClient to avoid having to include as_storage_client():let blob_client = StorageAccountClient::new_access_key(http_client.clone(), &account, &master_key)
                           .as_container_client(&container)
                           .as_blob_client(&blob);

I'm inclined to take this approach - removing the intermediate variables where possible.

Any thoughts/comments appreciated.

Aside: It is worth noting that the Python SDK has an alternative approach where a BlobClient class can be directly instantiated - but think that is an approach to be discussed outside the scope of this PR.
# Create the client object using the storage URL and the credential
blob_client = BlobClient(storage_url,
   container_name="blob-container-01", blob_name="sample-blob.txt", credential=credential)

@MindFlavor @cataggar I have rebased onto the latest main, and fixed up the remaining issues, so please could you review.
Notes:

There are some references to azure_storage from the new azure_storage_blobs crate, e.g.

azure_storage::response_from_headers macro
StorageClient::blob_url_with_segments(...)
azure_storage::core::parsing_xml (had to change to be pub rather than pub(crate))
azure_storage::core::util (had to change to be pub rather than pub(crate))
azure_storage::core::{copy_id_from_headers, CopyId}
azure_storage::xml::read_xml
azure_storage::{headers::consistency_from_headers, ConsistencyCRC64, ConsistencyMD5}
azure_storage::headers::content_md5_from_headers
azure_storage::core::clients::{AsStorageClient, StorageAccountClient, StorageClient, StorageCredentials}
azure_storage::core::StoredAccessPolicyList
azure_storage::core::shared_access_signature::{...}

I think this is probably specific to Storage Blobs, so can probably be moved into the new azure_storage_blobs crate

I propose that we (I) split out the remaining storage crates and we then review what is left in storage/core and decide whether we can and/or should move that function into the new individual crates (possibly replicating code where necessary).


The script is loaded but the playing status is not displayed

Hello!
The playing status isn't displayed after setting the game name from the userscript. The script is correctly loaded:

I'm using Firefox with Tampermonkey (I already tried with greasemonkey but that doesn't change).

Fixed in 1.6.0.


Excel Tables

Hi,
I haven't found a way to get Excel Tables by name. Is this feature implemented, and if not, is it planned?
Thanks in advance

We offer this in the Pro compendium.  Since companies have paid for the features already, it would be unfair to them if we turned around and made it available as open source.  We have a longer comment in a gist.


Enabling gRPC Web breaks AuthService

Describe the bug
We enabled grpc web, and then the authservice broke
To Reproduce
Steps to reproduce the behavior:

In the Ambassador Module we enabled gRPC web with this

spec:
  config:
    enable_grpc_web: true

This then (not immediately) breaks the AuthService and sets the protocol for the AuthService like so:

spec:
  auth_service: <IP_ADDRESS>:8500
  proto: grpc

This breaks the entire AuthService (nothing load) and anything backed by it doesn't load.
Expected behavior
Enabling gRPC web doesn't change the protocol for the AuthService and break AuthService
I have yet to recover logs but will when it happens again.
Versions (please complete the following information):

Ambassador: 1.8.1
Kubernetes environment: 1.18

Additional context
This happens randomly, is is expected?

Do you see this persisting on 2.x?  Further updates won't be made to v1, but we'll leave this open if persisting.

Looking back, I think this is the intended functionality, the auth service speaks through gRPC. I'll go ahead and close this out


Async support

Since this library is entirely I/O bound, I think it makes sense to support async (tokio).
I'm not familiar with supporting both a blocking implementation and an async one. Should maybe take inspiration from reqwest.

For now (#10) I simply duplicated the code in nut_client::blocking to nut_client::tokio and replaced the types/added async everywhere.
I would like to reduce duplication as much as possible, beyond the core streaming functions. Things like parsing etc. are mostly in cmd but not everything.


Modifying values of dict returned by io.loadmat affects subsequent calls to io.loadmat

In short, there seems to be some state inherent in io.loadmat that causes modifications to it's return values to affect future invocations.  It can be worked around, but it's not immediately obvious.
Reproducing code example:

The matlab files are generated by (matlab)
one = 1
save('test.mat', 'one', '-v4')

edit I've tried running the above code in octave, or generating the file in python using savemat, but can't get the error to occur.  The matlab file is attached if someone without access to matlab wants to investigate:
reproduce.zip
The error is demonstrated by the following code, which loads a mat file, copies a variable, then performs an in-place addition on the original variable.  Re-loading the mat file returns the modified value rather than the correct value.
from scipy import io

fname = 'test.mat'
t = io.loadmat(fname)

# copy for future reference
v = t['one'].copy()

# in place modification of return value
t['one'] += 32

# Reload file
t2 = io.loadmat(fname)

print('original:', v)
print('modified:', t['one'])
print('reloaded:', t2['one'])

assert ((v == t2['one']).all()), "Same variable from same file doen't match itself"

Output:
original: [[1]]
modified: [[33]]
reloaded: [[33]]
Traceback (most recent call last):
  File "bug.py", line 14, in <module>
    assert ((v == t2['one']).all()), "Same variable from same file doen't match itself"
AssertionError: Same variable from same file doen't match itself

When loading a version 4 mat file this issue doesn't occur.  The actual code where this bug manifested loads multiple variables from multiple mat files, and originally appeared as an unrelated variable being modified when a new mat file is loaded.
Scipy/Numpy/Python version information:

1.1.0 1.16.2 sys.version_info(major=3, minor=5, micro=2, releaselevel='final', serial=0)

Workaround
Don't use in-place modification with the dict returned by loadmat, i.e. use
t['one'] = t['one'] + 32

rather than
t['one'] += 32

Possible related to https://github.com/scipy/scipy/issues/7752