[Bug] IsTabStripVisible is not working when using DataTemplate for tabs

Description
Steps to Reproduce

in sample page -> views -> TabItemsSourcePage
set IsTabStripVisible="False"

Expected Behavior
TabView Should Not be visible
Actual Behavior
TabView is visible

Thanks for the report @kdbhalala but unfortunately you left out some important details from the template.
Specifically; what platform did you test this on? Did you test this on iOS, Android, both? Was the problem on both?

I can reproduce, strange tabStripContainer is visually visible even that tabStripContainer.Width = -1 and tabStripContainer.IsVisible= false


Image take in portrait mode is rotated 90 degrees

Hello,
When I take photo in portrait mode a apply "compressWithFile", I end up with compressed image rotated 90 degrees counterclockwise.
Tested platform: Android
Flutter doctor:
[✓] Flutter (Channel unknown, v0.9.5, on Linux, locale en_US.utf8)
• Flutter version 0.9.5 at /opt/flutter-sdk
• Framework revision 020fd590b0 (3 weeks ago), 2018-09-26 14:28:26 -0700
• Engine revision 38a646e14c
• Dart version 2.1.0-dev.5.0.flutter-4cf2d3990b
[!] Android toolchain - develop for Android devices (Android SDK 28.0.1)
• Android SDK at /opt/android-sdk/
• Android NDK location not configured (optional; useful for native profiling support)
• Platform android-28, build-tools 28.0.1
• ANDROID_HOME = /opt/android-sdk/
• Java binary at: /opt/android-studio/jre/bin/java
• Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1024-b01)
✗ Android license status unknown.
[✓] Android Studio (version 3.1)
• Android Studio at /opt/android-studio
• Flutter plugin version 27.1.1
• Dart plugin version 173.4700
• Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1024-b01)
[✓] IntelliJ IDEA Ultimate Edition (version 2018.2)
• IntelliJ at /opt/idea
• Flutter plugin version 29.0.4
• Dart plugin version 182.4505.50
[✓] Connected device (1 available)
• Nokia 6.1 • android-arm64 • Android 8.1.0 (API 27)

In some Android devices, cameras take pictures with angles of 90/180/270, and the libraries compress the original images you gave me.
Conversely, if you don't compress, rendering your pre-compressed image directly to the flutter view in Image. file / Image. memory will rotate as well.

in android you can use the method to get normal image.
    private fun setPictureDegreeZero(path: String) {
        try {
            val exifInterface = ExifInterface(path)

            exifInterface.setAttribute(ExifInterface.TAG_ORIENTATION, "no")
            exifInterface.saveAttributes()
        } catch (e: IOException) {
            // TODO Auto-generated catch block
            e.printStackTrace()
        }

    }

and the library is not use the method

I am taking picture using flutter camera plugin. Then I am using this plugin to compress it and save again to file system for later use. When later shown, it is rotated. I just need it to be positioned correctly.
When I am using native camera app and taking picture in portrait mode, picture is shown correctly in the native gallery app. So problem with unexpected rotation is related to one of the flutter plugins, not the device itself.

Yes, I think your camera plugin need give you the degrees or rotate the image file.
You should ensure that you provide the direction of the picture itself.

Thanks for the info. Well, this problem in flutter camera plugin is well known and there is currently no full fix available (https://github.com/flutter/flutter/issues/16587)
Doable solution would be to have ability to rotate picture during the compression. I have done some research and looks like it is not that hard to implement on both platforms. AFAIK you are using Bitmap on Android side where bitmap can be rotated using:
Matrix matrix = new Matrix();
matrix.postRotate(90);
Bitmap scaledBitmap = Bitmap.createScaledBitmap(bitmapOrg, width, height, true);
Bitmap rotatedBitmap = Bitmap.createBitmap(scaledBitmap, 0, 0, scaledBitmap.getWidth(), scaledBitmap.getHeight(), matrix, true);

on the ios side, there are two possibilities with UIImage. physically rotating the image or changing orientation header in the image. both are described with full code example here:
https://stackoverflow.com/questions/1315251/how-to-rotate-a-uiimage-90-degrees
on the flutter side it means only adding new integer "rotation" parameter to all compress* methods
can you implement this functionality? I have no access to apple device and also missing any experience with Objective C.

It's not hard to rotate pictures. The code for Android / IOS is available. I'll add the optional parameters for rotation in the next version.
But in principle libraries should not provide an automatic rotation scheme, because you don't know if the caller needs you to help him rotate automatically.

I understand your point. May I ask when you plan to release next version?

I would also love to see that resolved, AFAIK there are no reliable way to rotate an image in flutter!
There is a bug in the image package preventing clean rotation on all devices (https://github.com/brendan-duncan/image/issues/72)

link #6

update version 0.1.4


Devstack modular.

Different patches to make devstack more modular.

we should do this in gerritt once we get gerrit updated with devstack's current master


Add a few fixes for user friendliness issues

I messaged the German and Danish translators for links to add to the additional resources. @roel-v, do you have any suggestions for the Dutch version? I put the Dutch Facebook group since I was invited to that.

No just that one Facebook group, afaik that's the only Dutch language projector sewing resource in existence.

Lol, that makes it easy!


Can the app calculate the risk for the region in China?

Hello, excellent app! I just recently came across OpenSHA, can the app calculate the risk for the region in China? Is it possible to set it by latitude and longitude? Thanks.

Hello, we don't currently have any source models (ERFs) implemented for China. You could code one up yourself, or use the app to calculate scenario shakemaps for your own faults.
The GEM project's OpenQuake might have China source models implemented, I suggest you look there.


Windows, visual studio build failure

Vs 2017 latest has a few build errors, some with abseil and some in the main code. Nice to see you are continuing with this library. Paul

Thanks Paul, I will take a look at this

Hi Paul,
Hope you are well.
I've added VS 2019 (passing) to AppVeyor.
Should work on your installation, but to save disk space I don't want to install multiple visual studio versions on my machine.
Sam


bug: has_many() assoc breaks in Neo4j community-3.2.3

Confirmed issue with a new, clean project. Given the following models:
class Person
  include Neo4j::ActiveNode

  class Superhero < Person
  end

  class Supervillian < Person
  end
end

and
class Account
  include Neo4j::ActiveNode

  has_many :in, :owner, type: :ACCOUNT, model_class: ["Person::Superhero", "Person::Supervillian"]
end

Expected Behavior
hero = Person::Superhero.create
#=> #<Person::Superhero uuid: "7f923cbb-1f94-444c-a5fa-6beaeb58e6c0">

account = Account.create
#=> #<Account uuid: "f6f58ce1-5bd6-424a-bf6f-b57b5ab4b699">

account.owner = hero
#=> #<Person::Superhero uuid: "7f923cbb-1f94-444c-a5fa-6beaeb58e6c0">

Actual Behavior
hero = Person::Superhero.create
#=> #<Person::Superhero uuid: "7f923cbb-1f94-444c-a5fa-6beaeb58e6c0">

account = Account.create
#=> #<Account uuid: "f6f58ce1-5bd6-424a-bf6f-b57b5ab4b699">

account.owner = hero
#=> Neo4j::Core::CypherSession::CypherError:   Cypher error:

    Neo.DatabaseError.Statement.ExecutionFailed: Expected
    RegularPlannerQuery(QueryGraph(Set(PatternRelationship(IdName(rel1),(IdName(account4),IdName(result_owner)),INCOMING,List(RelTypeName(ACCOUNT)),SimplePatternLength)),Set(IdName(account4), IdName(result_owner)),Set(),Selections(Set(Predicate(Set(IdName(result_owner)),Ors(Set(HasLabels(Variable(result_owner),List(LabelName(Person::Superhero), LabelName(Person))), HasLabels(Variable(result_owner),List(LabelName(Person::Supervillian), LabelName(Person)))))), Predicate(Set(IdName(account4)),In(FunctionInvocation(Namespace(List()),FunctionName(ID),false,Vector(Variable(account4))),ListLiteral(List(Parameter(ID_account4,Any))))))),Vector(),Set(),Set(),List(DeleteExpression(Variable(rel1),false))),RegularQueryProjection(Map(),QueryShuffle(List(),None,None)),None)

    Instead, got:
    RegularPlannerQuery(QueryGraph(Set(PatternRelationship(IdName(rel1),(IdName(account4),IdName(result_owner)),INCOMING,List(RelTypeName(ACCOUNT)),SimplePatternLength)),Set(IdName(result_owner), IdName(account4)),Set(),Selections(Set(Predicate(Set(IdName(result_owner)),Ors(Set(HasLabels(Variable(result_owner),List(LabelName(Person::Superhero), LabelName(Person))), HasLabels(Variable(result_owner),List(LabelName(Person::Supervillian), LabelName(Person)))))), Predicate(Set(IdName(result_owner)),HasLabels(Variable(result_owner),List(LabelName(Person::Superhero)))), Predicate(Set(IdName(account4)),In(FunctionInvocation(Namespace(List()),FunctionName(ID),false,Vector(Variable(account4))),ListLiteral(List(Parameter(ID_account4,Any))))), Predicate(Set(IdName(result_owner)),HasLabels(Variable(result_owner),List(LabelName(Person)))), Predicate(Set(IdName(result_owner)),HasLabels(Variable(result_owner),List(LabelName(Person::Supervillian)))))),Vector(),Set(),Set(),List(DeleteExpression(Variable(rel1),false))),RegularQueryProjection(Map(),QueryShuffle(List(),None,None)),None)

Additional Info
If the Account model is changed to either of the following (same Person model):
class Account
  include Neo4j::ActiveNode

  has_many :in, :owner, type: :ACCOUNT, model_class: "Person::Superhero"
end

or
class Account
  include Neo4j::ActiveNode

  has_many :in, :owner, type: :ACCOUNT, model_class: false
end

Then account.owner = hero works normally.
Runtime information:
Neo4j database version: 3.2.3
neo4j gem version: 8.2.2 & 8.1.0
neo4j-core gem version: 7.2.3

I definitely want it to support 3.2.  I think the only reason why 3.2 isn't listed in the README is because I haven't gotten around to adding it.  There really should just be a line that says ">= 3.0.0".  I'll change that now

I had a bit of time to look into this and it seems to have something to do with the multiple labels in the model_class.  It also doesn't seem to have anything to do with assignment.  If I do account.owner it also fails.
Though I should also point out that the association is a has_many.  You shouldn't use = for has_many associations with just one object.  Probably the association should be owners and you should do owners = [hero] or owner << hero

When I call to_cypher I get the following:
MATCH (account23907) WHERE (ID(account23907) = {ID_account23907}) MATCH (account23907)<-[rel1:`ACCOUNT`]-(result_owners) WHERE (`result_owners`:`Persona::Superhero`:`Persona` OR `result_owners`:`Persona::Supervillian`:`Persona`)

I think that this is a problem which is a combination of using an Array for model_class along with having models which are inherited because I don't know if this is valid syntax:
`result_owners`:`Persona::Superhero`:`Persona`

But maybe that changed.  Looking deeper...

Looks like this was a reversion of functionality in 3.2.5.  Reported issue https://github.com/neo4j/neo4j/issues/10100
Thanks for catching this!

I just noticed that you said you were using 3.2.3, but I'm not getting this on 3.2.3 (only on 3.2.5).  Is that a typo or is something strange going on?

That's probably a typo. I'll confirm later tonight, but I was under the (incorrect) impression that 3.2.3 was community-latest, and I probably installed Neo4j using community-latest. It's convinient that you misread my mistake as the, apparenty, only value that could confirm this bug :rofl:

Hrmm, if you were using rake neo4j:install then it was probably 3.2.3 because I updated the file which contains the versions a couple of hours after you submitted the issue.  I guess we'll see what you find and see what the Neo4j team says ;)

I can confirm that I'm experiencing the problem specifically in 3.2.3 as well as in 3.2.0 (account.owner = Person::Superhero.create fails with an exception). I haven't tested other versions of 3.2.x, but I'm definitely not experiencing this issue in 3.1.5.
I notice that with the same Person class as above, and a default Job class, the following Account doesn't experience errors when account.owners = Person::Superhero.create
class Account
  include Neo4j::ActiveNode

  has_many :in, :owner, type: :ACCOUNT, model_class: ["Person", "Job"]
end

Though I should also point out that the association is a has_many. You shouldn't use = for has_many associations with just one object. Probably the association should be owners and you should do owners = [hero] or owner << hero

You're right. I didn't put much thought into the association. Though I would expect account.owners = hero to either succeed or raise and exception if it needed to be wrapped [hero]


Speaker icon quickly tapped issue

Overview (Required)

when I tapped speaker icon quickly, SpeakerDetailActivity launch twice
press back button twice then speaker icon is not shown
the icon will be shown by re-bind with scroll or move to other Fragment

This issue is difficult. When I try using shared element transition, I could not fix it 🤔

I guess SpeakerDetailActivity can be single instance so that should we change launch mode?
I'm not sure it will work fine for this problem though....


Support for color blinds

This PR supports better readibility for color blinds.

Codecov Report

Merging #10 into master will not change coverage by %.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #10   +/-   ##
=======================================
  Coverage   82.14%   82.14%
=======================================
  Files           2        2
  Lines          28       28
=======================================
  Hits           23       23
  Misses          5        5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fea8968...61a4e02. Read the comment docs.


Convert quint record operators

Closes #2530

[x] Tests added for any new code
[x] Ran make fmt-fix (or had formatting run automatically on all files edited)
[x] Documentation added for any new functionality
[x] Entries added to ./unreleased/ for any new functionality

Codecov Report

Merging #2535 (fe518e5) into main (09fc0ee) will increase coverage by 0.05%.
The diff coverage is 90.90%.

:exclamation: Current head fe518e5 differs from pull request most recent head 115f347. Consider uploading reports for the commit 115f347 to get more accurate results

@@            Coverage Diff             @@
##             main    #2535      +/-   ##
==========================================
+ Coverage   78.49%   78.54%   +0.05%
==========================================
  Files         441      442       +1
  Lines       15533    15560      +27
  Branches     2484     2518      +34
==========================================
+ Hits        12193    12222      +29
+ Misses       3340     3338       -2

Impacted Files
Coverage Δ

...che/tla/bmcmt/config/CheckerExceptionAdapter.scala
4.00% <0.00%> (-0.09%)
:arrow_down:

...ain/scala/at/forsyte/apalache/io/quint/Quint.scala
88.38% <100.00%> (+0.33%)
:arrow_up:

...n/scala/at/forsyte/apalache/io/quint/QuintIR.scala
100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Thank you for the review!


Add renaming for WidgetExt::set_name and BuildableExt::set_name

Bound to https://github.com/gtk-rs/gir/pull/873

Also for get_name please :)

Oh right.

:+1: once the gir change is in

And regen and merge :) @GuillaumeGomez

Regen is already done. The examples are failing. :) Merging then!


Dependencies and targeting for a custom VS test provider

Hi. I'm looking at writing a custom test provider for VS2022. Briefly, I have two questions:

Should I target .NET or .NET Framework?
Which version of Microsoft.VisualStudio.TestPlatform.ObjectModel should I be using, and from where?

More details:
I originally just tried stubbing ITestRuntimeProvider in a .NET 8 dll project using v17.12.0 of Microsoft.VisualStudio.TestPlatform.ObjectModel, Using a test project with a custom .runsettings file I was able to see that my dll was being loaded but the provider wasn't being instantiated.
Looking at Microsoft.VisualStudio.TestWindow.dll that ships with VS I can see that its built for .NET framework 4.6.2 and gives its AssemblyVersion attribute as <IP_ADDRESS>. So I hypothesized that maybe the test runtime was using the .net framework and couldn't load .NET assemblies. I tried building an ITestRuntimeProvider stub as a framework assembly with v<IP_ADDRESS> of Microsoft.VisualStudio.TestPlatform.ObjectModel from nuget - but this doesn't appear to provide a definition of ITestRuntimeProvider (although VS's private version does).
So now I don't know whether my initial .NET 8 approach was correct,, or whether I should use the framework with a different reference source for the ObjectModel dll. Or something else that I'm currently unaware of.
I'd appreciate any clarification on this. Thanks.

Hello, what is your goal? I am assuming you want to integrate a new testing framework? Or a whole new way of running tests?
You most likely don't want to implement ITestRuntimeProvider. Instead you want to implement test discoverer and test executor. Example of that is here: https://github.com/nohwnd/intent
You should ship it as netstandard2.0. And don't forget to name the dll *.TestAdapter.dll to be discovered.
For object model you should choose the version that is equal to the oldest VS you want to support, and use it as ref (not ship it).


Uncaught Error: Must be attached

I render components which depends on previous components. When select box value change, remove all components after it's component and rerender one component after it. I use client side collection for it.
It works. But when remove components, blaze throws error. Must be attached from https://github.com/meteor/meteor/blob/devel/packages/blaze/domrange.js#L337
Here is reproduction repo (on dynamic-render branch): https://github.com/delgermurun/flow-demo/tree/dynamic-render

@arunoda
I tested it using template (https://github.com/delgermurun/flow-demo/tree/with-template). It also throws error.
So It isn't flow-components's issue.
Anyway, I'd appreciate if you take a look and pointing what  I'm doing wrong (or meteor :P) :).
Thanks.

Looks like a known issue with Meteor: https://github.com/meteor/meteor/issues/2981


feat: refactor filter uses to use a single structured input

So, this shouldn't result in any behavior change(!). But, the diff is hopefully worth it.
We remove all uses of root-level inputs to the filter (which leads to lots of lengthy variable declarations that are hard to DRY), in favor of a more proper structured input. Each of the seven pages which currently use a filter needed to be updated, and many of them were quirky (by passing in a grab bag of variables to the query, not all of which were valid, which now loudly complains, etc.).
This should be carefully QA'ed!
Also, https://github.com/artsy/metaphysics/pull/3041 is a prerequisite for being merged/deployed.

This should be carefully QA'ed!

What's your thoughts on this? Just make a list of URLs to check and run through some filters manually?

I think the acceptance tests will be ❌  until the MP PR is merged.

What's your thoughts on this? Just make a list of URLs to check and run through some filters manually?

Yea, exactly. Might even combine it with the larger filter QA.

Merging this in!


Killing performance of CMD + P panel

Hi, not sure why or how, but when I try to use the CMD + P panel to quick browse to a file my Atom editor grinds to a halt and takes ages to respond.  I need to close the panel to restore performance.  Took me ages to find out why.  Safe mode revealed things worked normally, so I disabled all plugins and added them one by one until I found the culprit.  Turns out the moment I add this plugin the issue occurs.
project-manager 3.3.4
Atom 1.16.0 x64
OS X 10.12.3

I had similar problem. When project-manager was enabled atom startup performance was terrible.
Resolved it by disabling Include Git Repositories in project-manager settings.

Yeah, it could be the search for git repositories if you have many, but there is nothing that should affect cmd+p directly.
The git repositories search could be delayed until the projects list is viewed to fix the performance. Will take a look at it as soon as I have the time for it.


While aiming, display animated thumbnail (Android)

Display in bottom-left corner the thumbnail of the single picture being uploaded, in 2 parts:

top X% solid
bottom (100-X)% faded

Where X is the % of the file that is already uploaded.

Similar to #144, but better


Same image included multiple times fails epubcheck

I used an image (pixel.jpg) several times in a chapter.  When I uploaded the epub file to Leanpub it failed epubcheck with the following error:
duplicate resource: OEBPS/images/pixel.jpg

Ideally asciidoctor-epub would recognize duplicate image files and assign them the same id.

I agree. It's strange that gepub doesn't detect duplicate files (after all, it's the archive manager). I guess we'll need to do it in lieu of that.


WIP on Spear Mastery

Made Spear mastery's  AoO properly trigger for spears only and bonus damage is applied only to that triggered attack.


[checkpoints] Execute a block of transactions / effects within a checkpoint

Currently, execution is done on the basis of a certificate for the current epoch. However, once checkpoints are formed, stored and retrieved a validator or full node may wish to execute a full checkpoint block even from a past epoch and without reference to the full certificate of each transaction.
To enable this we must:

[ ] Order transactions within checkpoints in a canonical causal execution order (not a set). This order should be the same for all validators creating the same checkpoint, and be protected by the collective signature.
[ ] Allow the execution of a block of transactions with reference to a checkpoint block. That includes the corner cases of shared object transactions, where the locks are not created via consensus but instead via the checkpoint.
[ ] Where normally certificates might be stored, store instead a reference to the checkpoint to authenticate the execution. When a cert sync is requested from another node, the checkpoint should be used to provide evidence of execution + correctness.

Execution is partially addressed by #2943 (for the case of an online validator running the checkpoint process), and I have a PR coming soon for syncing at startup (prior to starting checkpoint process).


Consume gasRefund From Potential ethereumjs-vm Addition

This is the same as PR #80 with added tests. Fixes issue #26: estimateGas returns invalid value when tx has a gasRefund.

@davidmurdoch FYI, sometimes you can push directly to the PR branch if they checked the box to "allow reviewers to modify it". no problem though!

@seesemichaelj I used Github's "open this in GitHub Desktop" link on the PR and it automatically created a new branch instead of just opening your branch and so I just rolled with it from there. ¯\_(ツ)_/¯
I'll be sure to do it The Right Way next time.

It might be worth adding a test to check whether our gas estimation accounts for explicit gas stipends properly (e.g. something like mycontract.depth.gas(100000)(y-1))
Relevant docs here.


[BUG] vsock: Mem leak caused by circular referencing

There might be a memory leak bug caused by circular referencing.

VhostUserBackend ==> VhostUserVsockThread ==> VringEpollHandler
^                                                                                V
||                                                                                ||
==================================

There three struct refers to each other using Arc , but no single line is using Weak, which make it a circle.
And all these three struct cannot be dropped properly.
Reproduction Process:

Launch vhost-device-vsock
Launch and kill QEMU or other VMM
Use top -Hp $(pgrep vhost-device-vsock) to watch the threads details

Advice
Maybe we can use Weak<VhostUserBackend> in VringEpollHandler.

yes，I'll send a fix later on.

This is also causing an issue after we merged commit 38caab24c5087551d6ec12d0002df798e5e4f5ac
When the VM reboot or shutdown, we have this error, instead of looping waiting for a new VM
ERROR vhost_device_vsock] Could not create backend: CID already in use by another vsock device

This happens because we have these cyclic references and VhostUserVsockThread::drop() is never invoked. So we don't remove the cid from the map.

@cutelizebin do you have time to work on it? Otherwise, I can take a look ;-)

@cutelizebin was easier than expected, we don't need to keep the VringEpollHandler reference in VhostUserVsockThread. I just sent #499 .
Thanks for reporting this!


proc/native,Makefile: allow compiling on macOS without native backend

On macOS 10.14 Apple changed the command line tools so that system
headers now need to be manually installed.

Instead of adding one extra install step to the install procedure add a
build tag to allow compilation of delve without the native backend on
macOS. By default (i.e. when using `go get`) this is how delve will be
compiled on macOS, the make script is changed to enable compiling the
native backend if the required dependencies have been installed.

Insure that both configuration still build correctly on Travis CI and
change the documentation to describe how to compile the native backend
and that it isn't normally needed.

Fixes #1359

Done.


Link on subdomains gives incorrect results

The Link "Go to all female experts" on the homepage (action cards on the bottom) of both subdomains (vorarlberg and ooe) shows all speakers but should select only the ones of the actual subdomain.

done. thanks to @zaziemo


Size_t-ify libssl

This is a more-or-less complete conversion of the whole implementation of libssl to use size_t for sizes of things where appropriate. It is the second part of two PRs (see #1750 for the first part). A third PR will be required with a small amount of work to join the two halves together (although they can be reviewed and implemented entirely independently).
This introduces SSL_read_ex(), SSL_write_ex() and SSL_peek_ex() which use size_t arguments and return size_t information about the number of bytes read/written. All internal structure members and function arguments have been converted to use size_t where appropriate.
The boundary of this conversion is libssl. This means there are a number of "TODOs" left in the code where we call into libcrypto, and in those locations various type conversions need to take place.
I have not converted other libssl APIs which should probably have been size_t from the start, and instead do the necessary casts/conversions internally where needed. Over time we may want to convert some of those too.

This also should resolve all warnings in the libssl part of the compilation for the VC-WIN6A target on windows - all those warnings were almost exclusively about implicit conversions between size_t and int.

Travis was failing because there were some clashing function error codes introduced by an earlier rebase. New commit pushed to resolve it.

Travis was still failing with a bogus uninit variable warning, and also a shadowed variable declaration warning. New commits added.

How do you print size_t in tests, given some platforms like Windows haven't reached 1999 yet and don't support %zu? Cf. https://github.com/openssl/openssl/pull/1666#issuecomment-255157660

New commits pushed. I think I got all your comments. I made similar changes to the SSL_write() page as you suggested for SSL_read().

I guess I need to submit my review comments or they don't show up.

New commits pushed addressing review feedback.

New commits pushed to remove the unneeded conditions from ssl_read()/ssl_write() in bio_ssl, and to document the HMAC_size() function.

Will start reading the rest in a couple of days; travel tomorrow.

Add a long cast?

Add a long cast?

@richsalz, I think you need to make those comments using the web interface.  By email, this became just a general comment unrelated to anything at all...

Clarified the documentation as per feedback. Also added a commit to fix a travis failure.

New commits pushed to fix VMS issue and hopefully resolve Travis problems once and for all!

It would be good if we could land just the OSSLzu format string separately, to unblock #1666. I'm holding up the next OpenConnect release until I have a coherent story about the payload MTU calculation (I have it working for <= 1.1.0 but would like to know it's future-proof before shipping it).

It would be good if we could land just the OSSLzu format string separately

I pulled it out into #1787

Removed the OSSLzu change from this and rebased to pick it up from master.

Ping? Any more comments on this?

It seems to have merge conflicts now ...

Anyway, I didn't have time to actually look at everything in this patch yet. But I'll try to find some time.

Is this ABI compatible?

Is this ABI compatible?

Yes

It seems to have merge conflicts now ...

I rebased to remove the merge conflicts.

i do not think this is compatible.  size_t can be unsigned,  existing code using int code blow up.

i do not think this is compatible. size_t can be unsigned, existing code using int code blow up.

What specifically is not compatible? Give me an example. All existing APIs remain the same (using int). So externally there is no difference, except there are a small number of additional APIs available where you can use size_t if you want to. This is about the internals of libssl.

size_t can be unsigned

Sorry for the pedanticism, but size_t is required to be unsigned in both C89 and C99.

I rebased this, and fixed some minor merge conflicts due to the TLS1.3 stuff that has gone in so far. Also added a couple of commits to fix the style issues, and the issue noted by @stevelinsell.
@richsalz can you reconfirm?

+1 reconfirm.

Merged. Thanks!


Consume --none-- in Github commenter.

"--none--" is treated as a special string by the build status component, but not by the component which actually posts back to the PR, leading to PRs which look like this:
https://github.com/apache/beam/pull/1706
This change will ensure the PR post follows the same rules and comes into line with the documentation.
Build Status code is here.
Documentation here.

For posterity, here is snapshot of an example referenced in this PR

@jasonkuster Makes sense.
Think you could add test(s) to ensure comments are posted appropriately in both cases (e.g., --none-- or not)?

Tests added. :)
I'm relatively confident that this will work as I think it ought, but if you have any insights my train of thought is below.
'--none--' is originating in GhprbBuildResultMessage, then accessed through GhprbBuildStatus.postBuildComment(). This is piped through the system until it is called by GhprbBuilds.commentOnBuildResult(). commentOnBuildResult is checking for '--none--' and if it sees it just returns early. I understand all of that fine. The one detail I'm still unsure of is the behavior of the line List<GhprbBuildResultMessage> messages = getDescriptor().getMessagesDefault(this); in GhprbBuildStatus.postBuildComment(). As far as I can tell in my config I only have one build result message, so the StringBuilder will only contain '--none--' at the end. That sound right to you?

So, after some reevaluation (and actually running the tests attempting to mock out the right class) it looks like this isn't quite right, and I'm confused as to why.
In GhprbBuilds.commentOnBuildResult() it calls Ghprb.getJobExtensions() to filter down the list of extensions to pull from. getJobExtensions filters on two predicates: Not GhprbProjectExtension AND . In this case,  is GhprbCommentAppender. As far as I can tell, the only class which implements GhprbCommentAppender and not GhprbProjectExtension is GhprbPublishJenkinsUrl.
I dug pretty far into GhprbPublishJenkinsUrl's postBuildComment method and didn't find anywhere where it was appending the build result message. At this point I looked for other uses of repo.addComment(), and found one in GhprbRepository. That usage, though, restricts to only extensions of type GhprbBuildStatus. So at this point I'm pretty confused -- I can't see any way for ghprb to be posting a message which both has PublishJenkinsUrl and also BuildResultMessage. Is there something I'm missing?

@jasonkuster Unfo I won't have time this week to take a closer look, but I wonder if this instantiation would help.

Hi @benpatterson -- this is ready for review again. I figured out the issue with the test -- I was adding the comment appender to the wrong list in the test. Things work now, and I've verified this on a live instance of Jenkins as well.

Ok @jasonkuster thanks for pinging back.
Just letting you know I see this....but for now I'm focusing the cycles I have on the pipelines PR (# 497). Feel free to ping back if you think radio silence is going on for too long.

Sounds good. I'd love to get this in before the next release of the plugin, since this is causing some ongoing pain for my project. Do you know what that timeframe looks like? As long as that happens no worries.
Is there any information I can provide which will make reviewing this change easier for you once you can get to it?

Hey @benpatterson, just following up -- resolved conflicts from #497 here and now this should be good to go. It sounded like you were looking to cut a release soon, is there anything I can do to help ensure this makes it into that release?

Hi @jasonkuster thanks a lot for rebasing! I released the plugin with only that other PR in it, but that was mainly to keep any future troubleshooting very clear. But now that that PR is merged I'll have time to look more closely at this pr.

@benpatterson Makes sense. :) My whole team is excited to get this fixed -- thanks for your help.

@jasonkuster now that I'm looking at this, I have a basic question... What happens when you leave the field blank instead of using '--none--'. I mean, on master. I'm less familiar with this part of the plugin so thought I'd ask.

@benpatterson the fields in question here are the extra status update text fields in the plugin. They let you add additional information in the case that the build has result SUCCESS, UNSTABLE, or ERROR. What the quoted documentation says above is that filling them with the special string "--none--" should cancel posting back to the PR, but it only cancels it for the status indicator (the status inside the "all checks have passed" box above). This also checks inside of the commenting code.
Since they're optional fields, if you leave them blank you get the same behavior as currently happens, just the messages just don't contain "--none--". If you look at the screenshot you posted above it would look the same, just without the "--none--".

@jasonkuster Thanks for answering my question. I'm with you now.
Could you rebase the branch again (I believe the conflict is on the annotation you've added, vs the new signature of the method, which changed on master)? I think we're good to merge once that's done. 👍

@benpatterson rebased on top of current master successfully. Thanks for all your help!

Solid! Thank you @jasonkuster great to get this merged.

Released under v 1.36.1; it'll take 24 hours or so for that to show up on the plugin center.

Excellent; many thanks again. 😄

Somehow this has started to happen again. Has anything recently changed which could have caused this? Example: https://github.com/apache/beam/pull/3281


Allow to parse and evaluate shortcodes after markup is rendered

I’m thinking how to improve support for AsciiDoc syntax, specifically how to allow using standard Asciidoctor macros for cross-document references, code blocks with syntax highlighting provided by Hugo etc. I think that the most feasible way is to write a custom Asciidoctor HTML template (btw, I’m author of asciidoctor-html5s) that will render Hugo shortcodes instead of HTML markup for certain syntax elements (such as xref, listing etc.).
The problem is that this would require parsing, evaluating a substituting shortcodes after rendering the markup. I think that it might be possible once #7297 is implemented. However, this function has been requested multiple times in past years and it’s still not implemented, so it’s probably too complicated.
Maybe there’s some easier way how to achieve what I need? I’d appreciate even some hints how to quickly hack it in the code base (I’ve already looked into it, but I’m a bit lost), so I can start using it (I’m currently considering Hugo and this is a deal breaker).

I'm pretty sure we support that already, that is the difference between {{< and {{%.

Either I’m doing something wrong or it doesn’t work like that.
I have the following document:
= Title

See *document* xref:intro.adoc[].

I modified Asciidoctor backend to render xref macro as {{% relref "<path>" %}}, so Hugo gets the following HTML from asciidoctor:
See document {{% relref "intro.adoc" %}}.

And writes it as-is into output; it doesn’t process the relref shortcode. The same happens when I use {{< instead of {{%.

OK, we talk about different things. Yes, what you ask for is not possible.

Okay, do you know about any other (even hackish) way how to achieve what I’m asking for?


[QUESTION] Does this project sync state to browser history

Does this package sync the redux state on browser navigation? So if a user pressed Back on their browser, it will replace the state to what it was before the navigation change?
I believe this is what syncHistoryWithStore did in react-router-redux and since this is the advised replacement, I was hoping/assuming this would do that?
If not, is there a way I can time travel back to the the redux state before a push was made?

@oniice https://github.com/supasate/connected-react-router#main-features lines 6 and 11 of the readme seem to answer your questions?

✨ Synchronize router state with redux store through uni-directional flow (i.e. history -> store -> router -> components).

🕘 Support time traveling in Redux DevTools.

So the short answer to your question would be: No. It's only the other way around. And in my humble opinion, something like that wouldn't be the concern of this package.
But providing functionality like this should not be that hard to implement writing an own redux-middleware.

So the short answer to your question would be: No. It's only the other way around. And in my humble opinion, something like that wouldn't be the concern of this package.
But providing functionality like this should not be that hard to implement writing an own redux-middleware.

Just for additional info for anyone finding this page, this is a note in the react-router-redux code that seems to confirm it does do something at least similar to connected-react-router:

/**
 * This function synchronizes your history state with the Redux store.
 * Location changes flow from history to the store. An enhanced history is
 * returned with a listen method that responds to store updates for location.
 *
 * When this history is provided to the router, this means the location data
 * will flow like this:
 * history.push -> store.dispatch -> enhancedHistory.listen -> router
 * This ensures that when the store state changes due to a replay or other
 * event, the router will be updated appropriately and can transition to the
 * correct router state.
 */


Question about Newtonsoft.Json dependency

Since for .net web project the probability to use Newtonsoft.Json serializer is pretty high, due to this dependency it could lead to conflicts on serializer version.
I'm new to npoco, so I was just wondering why in v3 you've added such dependency. Can you explain?
Thanks,
Enrico

It is used for the serialized columns, where a complex (class) property can be serialized to json and stored in one column. Also used for snapshotting.

I see, those are surely interesting features. Is there a quick reference?
Can it be pluggable, so anyone can register the preferred serializer in order to avoid conflicts? Or you do use very specific features of Newtonsoft.Json?
Thanks!

If you mark a column with the [SerializedColumn] attribute it will be json'd into that column.
It is sort of pluggable but you still need to take a reference at the moment.
You really shouldn't run into any conflicts with JSON.NET. It only uses Serialize and Deserialize anyways.

I see that you've started a new branch using SimpleJson as default serializer. I think this is good first because Newtonsoft.Json It's bigger than this library and It feels that you're loosing the "easy to go" feeling. Second, having to integrate it in an existing project that uses Newtonsoft.Json 6.x I think that it will probably not compile well.
The best It will be to have it pluggable in the fluent database configuration, so you are free to use an existing version of Newtonsoft.Json or, for example, something like: https://github.com/mgholam/fastJSON
Thanks for watching into it!

fastJSON doesn't support CoreCLR just yet so that's out of the question.

Pay attention because SimpleJson maybe it's too "simple", for example: if you have a sql server timestamp colum mapped to a byte[] the deserialization will fail with an error like: System.InvalidCastException: Invalid cast from 'System.String' to 'System.Byte[]'.
Is it not enough to avoid putting serializers into the library and just throw an exception if there is no concrete implementation of the interface when using json-related features?
Just my opinion.

@schotime is right. SimpleJson doesn't support CoreCLR either and currently from the looks of it there is no plans to. For SimpleJson to be even thought about at this point of time, it will need to support .net core.
The reason why it is so important that CoreCLR is supported is the latest versions of NPoco currently run on .net core.
If you have concerns over JSON.Net versioning then IL merging might be the answer for you.

IL merge it's not an option, sounds more like an hack.
What about deploying two different nuget packages:
NPoco (no serializer depencencies so you have to manually configure the interface implantation, throws an exception when using json stuff and no serializer has been provided)
NPoco.Json (which has a dependency on Newtonsoft.Json or whatever library the maintainer has chosen as default serializer).
Simple and easy to understand, everyone is in control: no hacks.

Seperate library would be about the same level of "hack" but with more work. You could always fork NPoco and give it a go. If it's flexible enough and solves the problem and works with core clr you could always submit a PR.

Otherwise if you're currently having issues with version conflicts with Json.net then you could also try assembly binding redirection

Indeed I did: #261

Removed in 3.2.

Ok, glad to see a change of direction on this.... a much better setup!
Personally I've used fastJSON in some simple scenarios and works quite well. For complex objects maybe will have some problems, but at least you can replace it with a full fledged serializer if needed.
If I understood right, by replacing the serializer will affect no only the [SerializedColumn] but also the snapshoter, right?
Thanks

Will only affect the serialized columns. Fastjson hard coded for
snapshotter.


activation issue (8deefde9cb05b567bfcf425db45f22adbd9c7985)

Description
Getting the following trying to activate the colorscheme after pulling from main.
Error detected while processing /Users/me/.local/share/nvim/site/pack/packer/start/catppuccin/colors/catppuccin.lua:
E5113: Error while calling lua chunk: ...ite/pack/packer/start/catppuccin/lua/catppuccin/init.lua:73: attempt to concatenate field 'catppuccin_flavour' (a nil value)
stack traceback:
        ...ite/pack/packer/start/catppuccin/lua/catppuccin/init.lua:73: in function 'load'
        .../site/pack/packer/start/catppuccin/colors/catppuccin.lua:1: in main chunk

Neovim version
NVIM v0.8.0
Build type: Release
LuaJIT 2.1.0-beta3

Operating system and version
macOS 12.5.1
Catppuccin version / branch / rev
8deefde9cb05b567bfcf425db45f22adbd9c7985
Steps to reproduce
Activate the color scheme
Expected behavior
It activates the colorscheme
Actual behavior
Error detected while processing /Users/gloesch/.local/share/nvim/site/pack/packer/start/catppuccin/colors/catppuccin.lua:
E5113: Error while calling lua chunk: ...ite/pack/packer/start/catppuccin/lua/catppuccin/init.lua:73: attempt to concatenate field 'catppuccin_flavour' (a nil value)
stack traceback:
        ...ite/pack/packer/start/catppuccin/lua/catppuccin/init.lua:73: in function 'load'
        .../site/pack/packer/start/catppuccin/colors/catppuccin.lua:1: in main chunk

Minimal config
N/A

I am guessing you didn't call the setup function?
https://github.com/catppuccin/nvim/blob/main/lua/catppuccin/init.lua#L109

Setup function is now optional https://github.com/catppuccin/nvim/commit/114904fede6915b323413b8d5a38c14a00c7e403

Yep, was probably the issue. Thanks!


Issue #102, experimental: prefix 'unquote_vars:'

... to prevent from adding quotes around resolved variables

Hi @viv816 , this change will allow you to prefix the tags query with unquote_vars: in order to prevent   quoting the variables. Would you like to try it and make sure it fixes your issue?
Basically with this version, you will have to use the tags free text mode as you did previously, and prefix the text with unquote_vars: :
To try this version, I've pushed a docker image with this change for convenience: hawkular/hawkular-grafana-datasource:dev-build (on dockerhub registry). Or you could rebuild the grafana plugin from this PR, as it is more convenient for you. Let me know if you need help for that.
I hope it will work for you.

Adding no-merge label: I'd like to hear from @viv816 before.


docs(changelog): bump to 5.0.0, add token warning

I've increased the version to major, as this kind of a big change asks for one.
Fixes https://github.com/jazzband/django-rest-knox/issues/357
/cc @johnraz

Thanks !

Bit confused by these warnings now. We upgraded to 4.2 a year ago, which broke existing tokens. Will upgrading to 5.0.0 break them again? Or was this warning just added twice to highlight it?

@jmsmkn I'm not sure, and I haven't had the time to test if they will actually break yet.
It might have been a miscommunication and the warning isn't real, but I'm not sure.
If you have some time could you test this and report back here?

It does indeed break them, caused by #272, bit of a pain considering the default is not to use that feature.

Looking through that PR:

Why was sha added? Seems unnecessary.
Why was max_length increased to include CONSTANTS.MAXIMUM_TOKEN_PREFIX_LENGTH? CONSTANTS.MAXIMUM_TOKEN_PREFIX_LENGTH is not considered when saving the token. The TOKEN_KEY_LENGTH was increased in that same PR, which causes the breakage of existing tokens. Can't old-style, shorter token keys be handled when authenticating and then updated to the new longer style?

Hi @jmsmkn @giovannicimolin This MR does not break it. I added tests at the time to ensure that, however the release does.
What breaks the token compatibility is: https://github.com/jazzband/django-rest-knox/commit/b02a1553baff849d0f3a2b83da5dda5bf793157c
I filed an issue here regarding this as well: https://github.com/jazzband/django-rest-knox/issues/357

b02a155 does not break anything as that is just adding a warning to the documentation.
I tested this by generating the tokens with 4.2.0 (which already includes the changes of the salt removal described by b02a155), then installed 5.0.1, migrated, and ran a request against that process.
Both 4.1.0 -> 4.2.0 and 4.2.0 -> 5.0.1 break the tokens.

@jmsmkn Thanks for taking the time to test this 👌🏻
@max-wittig I reviewed the PR and the test there is not testing that a token generated before your change will work after. In order to properly do that you would have to checkout the code at the previous version then at the next etc. So we cannot state strongly that this is not breaking it.
I do trust @jmsmkn carefully tested this manually and I believe there is an actual different breakage between 4.2.0 and 5.0.0.
Now, @jmsmkn if you feel things should be done differently, I think it would be more constructive to open a PR so we can discuss the code and your change proposal rather than hypothetically talking about what could / should have been done.
5.0.1 is out, there is no going back so let’s look ahead and try to avoid breaking changes in the future.
Cheers!

@max-wittig I reviewed the PR and the test there is not testing that a token generated before your change will work after. In order to properly do that you would have to checkout the code at the previous version then at the next etc. So we cannot state strongly that this is not breaking it.

Ahh I see. It just tested that it works when changing the prefix. I wasn't aware of the breakage that I've caused! I'm sorry!

5.0.1 is out, there is no going back so let’s look ahead and try to avoid breaking changes in the future.

Yes that is true. Maybe there needs to be a test in CI using tokens in main and comparing them with any additional PR to see if the tokens still work.

Yes that is true. Maybe there needs to be a test in CI using tokens in main and comparing them with any additional PR to see if the tokens still work.

Added in #362 for tokens from 4.2.0 without prefixes.


I read more code, let's revert this change.

I read more code, let's revert this change.
Originally posted by @JekaMas in https://github.com/maticnetwork/bor/pull/701#discussion_r1086909323

Please submit the correct information, invalid information will cause the issue to close


SynologyDSM sensor does not work

Home Assistant release with the issue: 0.67.1
Last working Home Assistant release (if known): n/a
Operating environment (Hass.io/Docker/Windows/etc.): Docker on Linux
Component/platform: https://www.home-assistant.io/components/sensor.synologydsm/
Description of problem: An error shows up when Home Assistant is starting up, and trying to configure the sensors. No sensors shows up.
Problem-relevant configuration.yaml entries:
platform: synologydsm
host: <IP_ADDRESS>
username: !secret synology_user
password: !secret synology_pass
monitored_conditions:
  - cpu_total_load
  - memory_real_usage
  - network_up
  - network_down
  - disk_smart_status

Traceback (if applicable):
2018-04-24 16:14:37 ERROR (MainThread) [homeassistant.core] Error doing job: Future exception was never retrieved
Traceback (most recent call last):
  File "/usr/local/lib/python3.6/concurrent/futures/thread.py", line 56, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/usr/src/app/homeassistant/components/sensor/synologydsm.py", line 109, in run_setup
    for volume in config.get(CONF_VOLUMES, api.storage.volumes):
TypeError: 'NoneType' object is not iterable

Additional information: Im running a DS411slim with version DSM 6.1.6-15266 Update 1.

I have the same DSM version and same HA version and not experiencing this issue.  Make sure your user is has admin privileges and that the Synology DiskStation is accessible.

Thierry issue is related with python-synology module https://github.com/StaticCube/python-synology/issues/3

I just retested the issue. I had special characters in my password, and not put quotes around it. It tempoarily removed the error, but no sensors came up in home assistant. After a day, I noticed the error appearing again when rebooting home assistant.
2018-04-27 13:36:12 ERROR (MainThread) [homeassistant.core] Error doing job: Future exception was never retrieved
Traceback (most recent call last):
  File "/usr/local/lib/python3.6/concurrent/futures/thread.py", line 56, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/usr/src/app/homeassistant/components/sensor/synologydsm.py", line 109, in run_setup
    for volume in config.get(CONF_VOLUMES, api.storage.volumes):
TypeError: 'NoneType' object is not iterable
2018-04-27 13:36:12 INFO (MainThread) [homeassistant.core] Bus:Handling <Event system_log_event[L]: timestamp=1524836172.476201, level=ERROR, message=Error doing job: Future exception was never retrieved, exception=Traceback (most recent call last):
  File "/usr/local/lib/python3.6/concurrent/futures/thread.py", line 56, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/usr/src/app/homeassistant/components/sensor/synologydsm.py", line 109, in run_setup
    for volume in config.get(CONF_VOLUMES, api.storage.volumes):
TypeError: 'NoneType' object is not iterable
, source=components/sensor/synologydsm.py>

Hello folks, good morning
I'm using DS213 and got the same issue on the original DSM version 5.2.
I was checking the code and doing the follow up then I just decided upgrade the synology before work on the code as well. After reach 6.0 the call api.storage.volumes started works, then I just did the complete upgrade DSM 6.2-23739 and everything is working as expected.
Waldirio

Hello @larry702
Could you share the piece of your configuration configuration.yaml related to the synology ?
Best

Hello
I have (hopefully) sent you the key HA files. I redacted some information that I didn’t think was important but can share it if really necessary.
I also sent screen shots of my two Synology NAS devices. The show I am not using HTTPS and the release of DSM software installed.
Just let me know if I need to send you more.
Regards
Larry Webb
From: waldirio<EMAIL_ADDRESS>Sent: Friday, July 27, 2018 5:32 PM
To: home-assistant/home-assistant<EMAIL_ADDRESS>Cc: larry702<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [home-assistant/home-assistant] SynologyDSM sensor does not work (#14072)
Hello @larry702 https://github.com/larry702
Could you share the piece of your configuration configuration.yaml related to the synology ?
Best
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/home-assistant/home-assistant/issues/14072#issuecomment-408554795 , or mute the thread https://github.com/notifications/unsubscribe-auth/AiRQ6Ahg0BSrEzSvRPbJ2DXvclPbzBemks5uK5TigaJpZM4ThyMv .
--Certified Virus Free by 4SecureMail.com ICSA-Certified Scanner--

Hello @larry702
I didn't receive your message/screens
What I'm asking is the output like below
  - platform: synologydsm
    name: nas
    host: <ip address>
    username: <username>
    password: <password>
    monitored_conditions:
      - cpu_other_load
      - cpu_user_load
      - cpu_system_load

Just to check if you are forcing any configuration which could generate any issue to you.
According to the example above, your Synology should works.
Best

Same problem.
Home Assistant release: 0.74.0
Synology DS1517+ (DSM 6.2-23739 Update 2)
Operating environment: Docker on same Synology trying to monitor
In configuration.yaml:
sensor:
  - platform: synologydsm
    name: Synology
    host: !secret synology_ip
    username: !secret synology_username
    password: !secret synology_pass
    monitored_conditions:
      - cpu_other_load
      - cpu_user_load
      - cpu_system_load

Error:
Error doing job: Future exception was never retrieved
Traceback (most recent call last):
  File "/usr/local/lib/python3.6/concurrent/futures/thread.py", line 56, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/usr/src/app/homeassistant/components/sensor/synologydsm.py", line 113, in run_setup
    for volume in config.get(CONF_VOLUMES, api.storage.volumes):
TypeError: 'NoneType' object is not iterable

Found the problem in my case it was the SSL flag not set.
If not set it will default to TRUE.

Same issue for me after upgrading to 0.79.2.
This was working well, suddenly stopped working. My user is an admin user without access to apps or folders.
This is my config:
camera:
  - platform: synology
    url: https://<IP_ADDRESS>:5001
    username: !secret synology_user
    password: !secret synology_password
    timeout: 15
    verify_ssl: False

I am still having the same issue even though I set the flag to ssl: false

Did you check that HA IP is not blocked by DSM?

I got it to work. There was some issues with my monitored conditions. But I also think a few of the monitored conditions available in the home assistant component are not available for my synology DS157+ it seems
Sent from my iPhone
On Nov 10, 2018, at 4:51 AM, msanchezt <notifications<EMAIL_ADDRESS>wrote:
Did you check that HA IP is not blocked by DSM?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/home-assistant/home-assistant/issues/14072#issuecomment-437572039, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AqJ5o3dvBdcBPOGuSySUAvxIzNzo5egBks5utqGtgaJpZM4ThyMv.

Any progress on this issue? I'm still facing same error code
[homeassistant.core] Error doing job: Future exception was never retrieved
hass nas1 Traceback (most recent call last):
hass nas1 File "/usr/local/lib/python3.6/concurrent/futures/thread.py", line 56, in run
hass nas1 result = self.fn(*self.args, **self.kwargs)
hass nas1 File "/usr/src/app/homeassistant/components/sensor/synologydsm.py", line 113, in run_setup
hass nas1 for volume in config.get(CONF_VOLUMES, api.storage.volumes):
hass nas1 TypeError: 'NoneType' object is not iterable

with this config:
sensor:
  - platform: synologydsm
    entity_namespace: nas
    host: !secret SYNOLOGY_HOST
    port: !secret SYNOLOGY_PORT
    username: !secret SYNOLOGY_USERNAME
    password: !secret SYNOLOGY_PASSWORD
    ssl: false
    # volumes:
      # - volume1
    # disks:
      # - "/dev/sda"
    monitored_conditions:
      - cpu_total_load
      # - memory_real_usage
      # - memory_size
      # - memory_available_swap
      # - memory_total_swap
      # - volume_status
      # - volume_size_total
      # - volume_percentage_used
      # - volume_size_used

The user is hass which I created for this purpose.
I have tried with all permissions set, but still no success.
If I comment out the line with volumes and disks I dont see any error, but no sensor is showing data even after 12 h of waiting.

am receiving the same traceback with homeassistant 0.87 running in virtualenv, user hass in DSM is a member of admin group but has no access to any shares or apps as per documentation of the sensor; NAS is DS216SE and runs DSM 6.2.1-23824 Update 4
Feb 11 15:16:06 pine64 hass[29912]: Traceback (most recent call last):
Feb 11 15:16:06 pine64 hass[29912]:   File "/usr/lib/python3.6/concurrent/futures/thread.py", line 56, in run
Feb 11 15:16:06 pine64 hass[29912]:     result = self.fn(*self.args, **self.kwargs)
Feb 11 15:16:06 pine64 hass[29912]:   File "/home/ubuntu/homeassistant/lib/python3.6/site-packages/homeassistant/components/sensor/synologydsm.py", line 113, in run_setup
Feb 11 15:16:06 pine64 hass[29912]:     for volume in config.get(CONF_VOLUMES, api.storage.volumes):
Feb 11 15:16:06 pine64 hass[29912]: TypeError: 'NoneType' object is not iterable

with the following config excerpt:
  - platform: synologydsm
    host: <ip address>
    username: hass
    password: !secret syndsm_pass
    ssl: false
    monitored_conditions:
      - cpu_total_load
      - memory_real_usage
      - disk_status
      - disk_smart_status
      - disk_temp
      - volume_percentage_used

I do believe I have a fix though. synologydsm sensor assumes two defaults, that ssl is true and that default port is 5001. If you do not have SSL set up, it is not enough to set ssl to false, you also have to specify port as 5000 (DSM uses 5000 for http and 5001 for https).
It might be useful to auto-change default port value in code if ssl is set to false or at the very least amend the documentation - let me know and I'll be happy to put in a PR.

Any progress on this issue? I'm still facing same error code
[homeassistant.core] Error doing job: Future exception was never retrieved
hass nas1 Traceback (most recent call last):
hass nas1 File "/usr/local/lib/python3.6/concurrent/futures/thread.py", line 56, in run
hass nas1 result = self.fn(*self.args, **self.kwargs)
hass nas1 File "/usr/src/app/homeassistant/components/sensor/synologydsm.py", line 113, in run_setup
hass nas1 for volume in config.get(CONF_VOLUMES, api.storage.volumes):
hass nas1 TypeError: 'NoneType' object is not iterable

with this config:
sensor:
  - platform: synologydsm
    entity_namespace: nas
    host: !secret SYNOLOGY_HOST
    port: !secret SYNOLOGY_PORT
    username: !secret SYNOLOGY_USERNAME
    password: !secret SYNOLOGY_PASSWORD
    ssl: false
    # volumes:
      # - volume1
    # disks:
      # - "/dev/sda"
    monitored_conditions:
      - cpu_total_load
      # - memory_real_usage
      # - memory_size
      # - memory_available_swap
      # - memory_total_swap
      # - volume_status
      # - volume_size_total
      # - volume_percentage_used
      # - volume_size_used

The user is hass which I created for this purpose (member of users and administartor group).
I have tried with all permissions set, but still no success.
If I comment out the line with volumes and disks I dont see any error, but no sensor is showing data even after 12 h of waiting.

Check if you have 2 step verification enabled for administrator group in the control panel -> user -> advanced. After disabling this, it worked for me.

Should this issue be considered closed? Or are people still having difficulty?


Fix seccomprofile warning, add tests

More complete security profile definition for GPU burn
Add SeccompProfile warning now that all OCP versions support it (see PR #62)
Add more intermediate test to verify all steps of GPU readiness

NVIDIA-added GPU label
Discovered GPU capacity

/lgtm

/test ?

/test master-branch-gpu-e2e

We should get nvidia-gpu-operator-e2e to pass. This should not fail AFAIK. The master bundle from NVIDIA is in a flaky state at this time, as you already know. So the master-branch-gpu-e2e is less of an issue at the moment.

Amazing! Thanks!
/lgtm


worker.pb.h file not found

I am trying to find the file worker.ph.h file which is included in https://github.com/tensorflow/tensorflow/blob/master/tensorflow/core/distributed_runtime/rpc/grpc_remote_worker.cc
Can I know if need to run any command like below one to generate the file
bazel build tensorflow/cc:cc_ops as indicated in https://github.com/tensorflow/tensorflow/issues/3017 to generate the respective ops files

pb.h files are generated from protocol buffers.
Bazel creates these once you have the dependencies set up correctly.
In this case, "//tensorflow/core:worker_proto_cc", dependency is the correct proto dependency we use.

Yeah when you bazel build it, you can find it by fishing around in the bazel-bin/ or bazel-genfiles/ directory.

Is there any command to build all core files at a time, instead of building
each such files.
On Jun 2, 2017 5:46 AM, "Justine Tunney"<EMAIL_ADDRESS>wrote:

Yeah when you bazel build it, you can find it by fishing around in the
bazel-bin/ or bazel-genfiles/ directory.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/tensorflow/tensorflow/issues/10364#issuecomment-305654551,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AJjYUL_EpBQmVMRk_vnZB65jsQxY0vN0ks5r_1RAgaJpZM4NspUI
.

bazel build //tensorflow/core/...


New Locations

Are you able to add Ulverstone TAS 7315 & West Ulverstone TAS 7315 Along With Devonport TAS 7310?
Much appreciated!

Done


LP stake should be calculated as currently available

In fact, I currently have 300+

The same is true when taking out LP


yii\base\ActionFilter::$only behavior

in methode yii\base\ActionFilter::isActive() to check active action should use $this->only === null instead of empty($this->only). So when we set $only to [] its mean no action will active. Current implementation, when we set $only to [] its mean all action is active.
return !in_array($id, $this->except, true) && (empty($this->only) || in_array($id, $this->only, true));

should change to
return !in_array($id, $this->except, true) && ($this->only===null || in_array($id, $this->only, true));

@mdmunir, 2 years have passed. Whats your current view on your request?

As i said above. I used it when developing (but all my project under development now :D). Instead of remark all behavior i just want to remark only section.
FYI, Currently we can use except = ['*'] to avoid all action. But still better if we check $only === null instead of is_empty($only).

alright. Its debatable with respect to consistency and unfortunately also a BC break. Lets close this one for now, perhabs we will reassess in future releases. Thanks!


Incremental updates

Pull Request Test Coverage Report for Build 102

6 of 6 (100.0%)  changed or added relevant lines in 5 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.003%) to 75.585%

Totals

Change from base Build 99:
-0.003%

Covered Lines:
6529

Relevant Lines:
8638

💛  - Coveralls


remove need for winrmconf.cmd

execute 'winrm create' directly

reviewer: take or close

Looks good to me.


Breaking change in export.rb

In https://github.com/amro/gibbon/commit/0fcffa45b371c7bf40b6d23fc5d3149ad0ac1202#diff-20502efd9163d9cdc91dd052e2faa268L24 and https://github.com/amro/gibbon/commit/589c81f453bbe9a08d975bbf3c9aa0ea2423f296#diff-20502efd9163d9cdc91dd052e2faa268R42 you changed the return type of export.list.
It was an Array of strings (body.lines), now it's an array of array of string (via split_json). This was a breaking change for us and the versioning didn't indicate that (1.1.5 -> 1.1.6). :/
Also your split_json method seems error prone - I haven't had time to test it but I'm pretty sure someone with a name like "My Name {} lololol [][]" will cause problems?
Anyhoo, we've worked around it for now, but I figured I'd flag this. It might be worth using something like Yajl to parse the response's lines, instead of doing a funky split.
I'll try add more to this issue when I have time. :)

@nickmalcolm The versioning is definitely an oversight on my part. I will yank 1.1.6 and re-release it as 1.2.0. I know the damage is already done there - please accept my apologies.
I see your point about split_json(). I'm not sure what to do there other than not handle that error case (or revert streaming support entirely).

All good! I appreciate your hard work :)

This should be good to go. I removed the hack in split_lines(). I couldn't reproduce the lack of a newline. I did keep the type the same, as I mentioned above, because I think having it pre-parsed makes sense.


System.MissingMethodException when using JsonSerializerSettings.TypeNameAssemblyFormat across PCL and non-PCL projects

I am working on a large project where we have multiple solutions, including a .NET 4.5.2 console app and a Windows Store App. We have some core libraries that we share, and in order to do so, we have created them as portable class libraries. This gives a nice and clean architecture with lots of code reuse - all good.
We are using JSON.NET as our main tool for JSON work and have been very pleased for many years. However, after we started using the JsonSerializerSettings.TypeNameAssemblyFormat in our shared PCL libraries, we got a System.MissingMethodException in the .NET 4.5.2 console app when consuming these libraries. I have researched into this, and even though I found people with a similar problem ( see: http://stackoverflow.com/q/27080363/700926 ) I did not find any solution.
Issue Description
I have boiled this down to a demo app that I have attached. I will explain the issue with focus on that.
The demo app contains a solution with two projects:

JsonDotNetDebug (.NET 4.5.2 console app)
JsonDotNetDebug.Portable (PCL targeting Profile 7 / .NET 4.5, ASP.NET Core 1.0, Windows 8)

The PCL contains the following method that is supposed to be re-used among other projects, including the console app in the solution:
using Newtonsoft.Json;

namespace JsonDotNetDebug.Portable
{
    public class Class1
    {
        public JsonSerializerSettings GetJsonSerializerSettings()
        {
            return new JsonSerializerSettings
            {
                /*
                 * Since this mini-API is defined in a PCL, the: "System.Runtime.Serialization.Formatters.FormatterAssemblyStyle"
                 * is not available in mscorlib. Instead, it is located in the Newtonsoft.Json assembly.
                 * See: Newtonsoft.Json/Src/Newtonsoft.Json/FormatterAssemblyStyle.cs
                 * See: https://github.com/JamesNK/Newtonsoft.Json/blob/6d7c94e69fa2f52b91fb22972321cb9b51b9abed/Src/Newtonsoft.Json/FormatterAssemblyStyle.cs
                 */
                TypeNameAssemblyFormat = System.Runtime.Serialization.Formatters.FormatterAssemblyStyle.Full
            };
        }
    }
}

In my console app, I then want to use my mini API to get the JsonSerializerSettings:
using System;

namespace JsonDotNetDebug
{
    // Targets: .NET 4.5.2
    public class Program
    {
        public static void Main(string[] args)
        {
            var c1 = new Portable.Class1();

            /*
             * Throws System.MissingMethodException
             *
             * If I look in ILDASM, I find the following setter in Portable.Class1:
             *
             * instance void [Newtonsoft.Json]Newtonsoft.Json.JsonSerializerSettings
             * ::set_TypeNameAssemblyFormat(valuetype [Newtonsoft.Json]System.Runtime.Serialization.Formatters.FormatterAssemblyStyle)
             *
             * The problem (as I see it) is that the "FormatterAssemblyStyle" is located in the
             * Newtonsoft.Json assembly, but my console app is compiled against full .NET 4.5.2
             * and expects the FormatterAssemblyStyle to be located in mscorlib - hence the exception.
             *
             */
            var jsonSerializerSettings = c1.GetJsonSerializerSettings();

            /*
             * To solve the ambigiuty, I can force the use of the portable
             * Newtonsoft.Json.dll by adjusting packages.config and the *.csproj file.
             *
             * However, since this console app is a full .NET 4.5.2 app, the
             * "System.Runtime.Serialization.Formatters.FormatterAssemblyStyle" will then
             * be available from both the mscorlib and Newtonsoft.Json assembly.
             *
             * This causes a compilation failure, as the compiler don't know
             * which FormatterAssemblyStyle to use (mscorlib vs Newtonsoft.Json).
             *
             * While this can be solved by introducing an extern alias for the
             * Newtonsoft.Json assembly, it does not seem right.
             */
            jsonSerializerSettings.TypeNameAssemblyFormat = System.Runtime.Serialization.Formatters.FormatterAssemblyStyle.Simple;
            Console.Read();
            Console.WriteLine("Done");
        }
    }
}

However, as outlined in the source comments, this breaks at runtime. This is the issue I cannot get my head around. While the stacktrace does not say much (it lacks the assembly name) I have included it for completion:
System.MissingMethodException was unhandled
  HResult=-2146233069
  Message=Method not found: 'Void Newtonsoft.Json.JsonSerializerSettings.set_TypeNameAssemblyFormat(System.Runtime.Serialization.Formatters.FormatterAssemblyStyle)'.
  Source=JsonDotNetDebug.Portable
  StackTrace:
       at JsonDotNetDebug.Portable.Class1.GetJsonSerializerSettings()
       at JsonDotNetDebug.Program.Main(String[] args) in C:\Users\MyUser\Documents\visual studio 2015\Projects\JsonDotNetDebug\JsonDotNetDebug\Program.cs:line 25
       at System.AppDomain._nExecuteAssembly(RuntimeAssembly assembly, String[] args)
       at System.AppDomain.ExecuteAssembly(String assemblyFile, Evidence assemblySecurity, String[] args)
       at Microsoft.VisualStudio.HostingProcess.HostProc.RunUsersAssembly()
       at System.Threading.ThreadHelper.ThreadStart_Context(Object state)
       at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
       at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
       at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
       at System.Threading.ThreadHelper.ThreadStart()
  InnerException:

As I write in the source comments, I can solve this by force-using the portable version of Newtonsoft.Json.dll in all projects, and then declare an extern alias for Newtonsoft.Json.dll, to tell the compiler to always use the FormatterAssemblyStyle located in Newtonsoft.Json.dll.
While this work, it does not seem right to me? In my eyes, I would have liked the "FormatterAssemblyStyle" to be a custom type in its own Newtonsoft.Json namespace (instead of replicating the System.Runtime.Serialization.Formatters inside Newtonsoft.Json.dll), e.g., the namespace could be: Newtonsoft.Json.FormatterAssemblyStyle? This would put a direct requirement on that type, with no risk for ambiguities. But yeah, I guess there is a reason why the project has chosen to replicate the System.Runtime.Serialization.Formatters namespace inside Newtonsoft.Json.dll?
While that is said, I have a feeling that I am missing something really obvious. If that is the case, please let me know where I go wrong, and I will hopefully learn something new :)
I am looking forward to your response.
Thanks for a great project :+1:
Environment info:

Windows 8.1 Enterprise
.NET 4.6.1 installed (app is running .NET 4.5.2)
VS2015 Enterprise, Update 2
Nuget package: Newtonsoft.Json, v. 8.0.3

Attachment Info
For some reason, github won't let me upload a .zip file. So yeah, to get this to work, I have appended a .txt extension.
JsonDotNetDebug.zip.txt

Don't know if the developer reads this but this issue is a real concern.
In a cross-platform solution the best way to ensure that serialization/deserialization behaves consistently for all project is to wrap Netwonsoft.Json with a class that guarantees consistent settings and share it.   As swlasse points out, do that in a Shared Class Library and kaboom.
We considered using swlasse's workaround but we too find manually adjusting project files untenable.
Another idea we dismissed is to create our own private NuGet packages containing our shared class, targeting each environment.  That's a lot of work.  You might well as copy the source around.  So...we decided to use a Shared Project which essentially copies the source by reference into each project that references the project.  Yuck...but it works.
The absolute best answer is for the NewtonSoft.Json package to address the issue.  I would try but the code in this project sets a pretty high bar.  I would probably be embarrassed by the assessment of my pull request.
Lately we find ourselves working on the tools at the expense of our project.  Our decision to essentially use linked source files was made simply to minimize our exposure to the bleeding edge regarding .NET Standard and Core which have a long way to go from a feature and tooling perspective.
The Newtonsoft developers should strongly consider giving this issue a high priority.

Fixed https://github.com/JamesNK/Newtonsoft.Json/commit/ca27a0fc3a4e157d4a584549e2aaa65cfc822f3b


Guide to a good resource

Write guide of what a great resource is with really good examples and convenions to strive for consistency across resources(for curators) (related to - updating form and metadata https://github.com/SFDO-Community-Sprints/sprintys-community-resources/issues/40)

Most recent version of Curator Guide:
https://docs.google.com/document/d/1i8EzoWiQH8932hSI5gor64IQ9ozRucw7tBfvZfeQUFc/edit?usp=sharing

Note that https://github.com/SFDO-Community-Sprints/sprintys-community-resources/issues/55 is a task to turn that version into a GitHub page instead of a Google Doc


Feature request: Container monitoring

I think it would be useful to monitor containers (dockers).

Hello & thank you for creating a feature request!
Unfortunately, this is something that doesn't fit into this project in my opinion, so I don't think I will add it in the near future.


feature: add task update actions in client pkg of golang sdk

Ⅰ. Describe what this PR did
feature: add task update actions in client pkg of golang sdk
Ⅱ. Does this pull request fix one issue?

this fixes one part of #366
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
Ⅳ. Describe how to verify it
none
Ⅴ. Special notes for reviews
none

Codecov Report

Merging #746 into master will decrease coverage by 0.08%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #746      +/-   ##
==========================================
- Coverage   46.85%   46.77%   -0.09%
==========================================
  Files         110      111       +1
  Lines        6321     6332      +11
==========================================
  Hits         2962     2962
- Misses       3125     3136      +11
  Partials      234      234

Impacted Files
Coverage Δ

client/request.go
35.78% <0%> (-1.99%)
:arrow_down:

client/task_update.go
0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c2fced...69c2e84. Read the comment docs.

Could you help to add the mock test of unit test of Client Functions? Like the file: https://github.com/dragonflyoss/Dragonfly/blob/master/client/preheat_info_test.go @zgfh

LGTM


Revert "Add support for data group resource"

Reverts f5devcentral/go-bigip#10
Build is failing in some environments let me check and re commit.

@scshitole what is failing?


custom script for host monitoring

When I open the settings of a host I can setup "custom scripts" to monitor specific metrics in my instance. Is there a way to do this via the API/ this Provider ? Thank you

Hi @MohamedAnouar,
Are you able to provide additional details/screenshots of what you are referring to?
Thanks!

Hello,
I'm trying to configure under the host settings the extension : Custom scripts. After tracing the API calls, I found the following information about the target extension :
extensionId: dynatrace.python.customscripts
extensionType: PYTHON
By tracing the browser calls, I found that the API called to update the extension settings is the following : "/rest/configuration/monitoringextensions/hosts/$HOST_NAME with the extension ID and config in the PUT request data.
Can we use the current version of the provider to configure the extension or  should we wait for a future version ?
Thank you

Hello @MohamedAnouar,
If I'm not mistaken, you're talking about a OneAgent Extension based on the Extension Framework V1 - developed by our Services Team.
Although the public REST API of Dynatrace offers a way to configure these (i.e. the counter part for the URL /rest/configuration/monitoringextensions/hosts/$HOST_NAME you had reverse engineered), we've never implemented any resources for Terraform.
Reasoning behind that was, that the EF1 was expected to get desupported sooner or later ... which coincidentally will be happening in about a month from now.
What you CAN configure using Terraform are Extensions based on the Extensions Framework V2 - for instance using the resource dynatrace_hub_extension_config.
I'm unfortunately not sure whether our Services Team has already migrated the dynatrace.python.customscripts Plugin to Extensions V2. But in case there already exists a replacement, the above mentioned resource should do the trick.
Let me know if there are any further questions and I'll reopen the ticket.


Split functions and algorithms in the Introduction

The introduction to the documentation has a section where the current algorithms and benchmark functions are implemented. Right now, these are very few but in the future the will saturate the document.
I propose the following, split the section like this:

Contents ...

Algorithms
Functions

where each part has its own dedicated file for the increasingly number of algorithms.

Done in #18


ImageScaler is not supported when converting to coreml.

When converting onnx model to coreml (tinyyolo), ImageScaler could not be supported.

see PR #228


fix[release_plz_core]: align changelog line breaks with spec

fixes "empty lines after headings and lists" in changelogs.
Discussed here: https://github.com/MarcoIeni/release-plz/issues/1652
So glad you had that many tests in this part!

@MarcoIeni can you please have a look at the link checker action? I do not understand what is wrong there, maybe just restart the check (Network Error ...)

Note: this PR does not fix MD024.


encoding/base64 decoding is slow

What version of Go are you using (go version)?
Go 1.8
What operating system and processor architecture are you using (go env)?
amd64
What did you do?
On my slow computer, using encoding/base64, I can decode data at ~100MB/s.
It should be much faster as shown by https://github.com/aklomp/base64
I'm planning to work on this in my spare time. This issue tracks this effort.

Also https://github.com/powturbo/TurboBase64 for a fast encoder/decoder that doesn't need assembly.

@dgryski I saw such LUT based and I'm wondering if it's acceptable. What's go philosophy about embedding "large" LUT? Won't such tables trash the L1 when used and penalize the rest of the application?
I have an SSE implementation in the pipe that will be another improvement to CL 38632 but it's limited to amd64.

I saw such LUT based and I'm wondering if it's acceptable.
Strange rumours, but the short scalar "turbob64encs" encoding uses 64 bytes and "turbob64decs" decoding function just uses 80 bytes (from 256 bytes LUT) delivering 2 GB/s in practical szenarios, This is less memory than other SIMD/AVX2 base64 functions. The fast "turbob64dec" function needs in fact less than 1k and is decoding faster than other scalar/SSE functions.

With the two CLs above, the decoder goes from ~500MB/s to ~630MB/s on an 8KiB input. Note that this is on a 2014 ultrabook locked at 70% cpu frequency, to prevent overheating and throttling.
The only remaining bottleneck in the pure Go code that I can see is how it has more bounds checks than needed per decoded chunk of bytes. A couple for every 8 bytes should be enough, but it currently does at least eight. I think if we can fix that via #28942, it should give another nice 5-10% speed-up.


X-WOPI-ValidRelativeTarget header is not documented

@chrisbro-MSFT, is this used? If so, what for?

Yes, it's used.  Described in issue 54.


[Help]Docker build fails

I'm installed the bot into a docker image using
docker build -t username .
the build seemed to be successful, and the image shows up in my list, but after running it with"docker run" I'm getting the following error:
Unhandled exception. System.TypeInitializationException: The type initializer for 'CharacterAI_Discord_Bot.Service.CommonService' threw an exception.
 ---> System.NullReferenceException: Object reference not set to an instance of an object.
   at CharacterAI_Discord_Bot.Service.CommonService.Failure(String logText, HttpResponseMessage response, DiscordSocketClient client) in /app/Service/CommonService.cs:line 252
   at CharacterAI_Discord_Bot.Service.CommonService.GetConfig() in /app/Service/CommonService.cs:line 278
   at CharacterAI_Discord_Bot.Service.CommonService..cctor() in /app/Service/CommonService.cs:line 15
   --- End of inner exception stack trace ---
   at CharacterAI_Discord_Bot.Service.CommonService.get_BotConfig() in /app/Service/CommonService.cs:line 13
   at CharacterAI_Discord_Bot.Program.MainAsync() in /app/Program.cs:line 23
   at CharacterAI_Discord_Bot.Program.Main() in /app/Program.cs:line 16
./entrypoint.sh: line 2:     8 Aborted                 ./CharacterAI_Discord_Bot

I'm new to docker, so I was wondering if I just messed something up or there is a problem with the docker buildfile?
Additional info:

Windows10 22H2
Docker Engine v24.0.2 (WSL edition)

It's not docker error, there's something with you config file

Indeed, I noticed that I forgot to update to the last version and didn't
update the config until now.
Thanks for your help, and sorry for the trouble.
On Sun, 16 Jul 2023 at 09:34, drizzle-mizzle @.***>
wrote:

It's not docker error, there's something with you config file
—
Reply to this email directly, view it on GitHub
https://github.com/drizzle-mizzle/CharacterAI-Discord-Bot/issues/137#issuecomment-1636995501,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJ2SJZ37JQMPXVDEFNX3DDLXQODOVANCNFSM6AAAAAA2LR2BJU
.
You are receiving this because you authored the thread.Message ID:
@.***>


update readme

Update readme to add content on how to use the GitHub Action

Need this PR first: https://github.com/sigstore/cosign-installer/pull/3
/assign @dlorenc

This action is going to be soo good! Thanks @cpanato!

@dlorenc @mbestavros if y'all agree after this I think we can tag a release 1.0.0 or 0.1.0 and publish that to the marketplace.
to publish that some admin of the org/repo will need to accept some things, but that is straight to do, and when creating a new release will have a checkbox to publish that to the marketplace

to publish that some admin of the org/repo will need to accept some things, but that is straight to do, and when creating a new release will have a checkbox to publish that to the marketplace

Yup sounds good!


Closing due to removal of freeroam mode (#1257)


fix: fallback to look at releases when looking for latest release

The current method of finding the latest release for non-manifest repositories is to look through latest commits to find a merged PR that looks like a release-please PR for that component. This adds a fallback to consider manually tagged releases if that commit is on the target branch.
Fixes #1132

Do we still fallback to bootstrap-sha as well, if all methods for looking up a prior release fail?

This path is not using the manifest at all -- this is using the CLI with release-please release-pr --release-type=<type>.


Simplifying the structure and UI

Thanks Sam! @rowan-m, let's take a look at this code again at a later stage together.


reproducible builds

The benefits associated with reproducible builds (and the costs associated with non-reproducible builds) are better explained here:
https://reproducible-builds.org/
tldr; reproducible builds are good and jira-cli would be improved by having reproducible builds.

@realtime-neil if you install the binary using go install, generated SourceDate will be gibberish (example below). It would be nice if we can inject the current date to get an idea of when the build was created. A fair share of users relies on go install to install the tool.
(Version="dev", GitCommit="ffffffffffffffffffffffffffffffffffffffff", SourceDate="1969-12-31T23:59:59+00:00", GoVersion="go1.16.12", Compiler="gc", Platform="linux/arm64")

To reproduce:
go install github.com/ankitpokhrel/jira-cli/cmd/jira@main

What I would propose is:

Add a BuildDate which is a date when the build was created. This will be a date of release for pre-built binaries or current datetime when using go install or brew install jira-cli --HEAD.
Rename SourceDate to CommitDate. Commit date sounds a bit clear to me.
Leave GitCommit and CommitDate empty if we cannot fetch those info for manual installs. On the other hand we will always have a valid value for BuildDate.

Example of how it will look for go install.
(Version="dev", GitCommit="", CommitDate="", BuildDate="2022-01-03T22:25:40+00:00", GoVersion="go1.16.12", Compiler="gc", Platform="linux/arm64")

Let me know you thoughts.

Add a BuildDate which is a date when the build was created. This will be a date of release for pre-built binaries or current datetime when using go install or brew install jira-cli --HEAD.

How do you populate BuildDate with go install without overriding the GOFLAGS?

Using current date as default BuildDate in version.go should do the trick?

@ankitpokhrel do I understand correctly that you want a string literal of the form
2022-01-04T14:25:10+00:00

as the "default" value for the BuildDate ? And that this value should be changed by a human developer within the content of internal/version/version.go immediately prior to a release?
If I understand correctly, then that's easy enough to implement. The hard part is that this creates a "busy work" chore for you to do on every release; i.e., updating the BuildDate each time.

@ankitpokhrel also, with this scheme, assuming that a human never assigns a BuildDate in the future, this means that the CommitDate will always follow the BuildDate --- because committing the change must follow the creation of the change.

What I meant was, we can construct BuildDate in a similar way like we are setting value for SourceDate.

In Makefile we can pass build date as such:
BUILD_DATE = $(shell TZ=UTC date +%Y-%m-%dT%T\Z)

And in .goreleaser.yml we can do:
- -X github.com/ankitpokhrel/jira-cli/internal/version.BuildDate={{.Date}}

If any build system like go install doesn't pass BuildDate we will always have current datetime as a default value.

@ankitpokhrel what you have described is the antithesis of a reproducible build. Even if you were able to "bake in" the value of the BuildDate variable at build time, it would be different for every invocation of go install ./... and/or make install (ignoring object caching).
To have a reproducible build, you need a one-to-one mapping of source code to built artifact. Values injected from the environment that depend on time violate this principle.

Also, the concept of a build date is useless for an artifact that has a reproducible build. A given commit always produces the same artifact, so there's no point in tracking when it was produced.

I think we might be talking about different things here. The idea of reproducible build is one thing and figuring out the closest build when someone reports the issue in the tool is another.
When someone who installed an app using go install creates an issue, the current version output doesn't give the slightest idea of what the user has installed.
(Version="dev", GitCommit="ffffffffffffffffffffffffffffffffffffffff", SourceDate="1969-12-31T23:59:59+00:00", GoVersion="go1.16.12", Compiler="gc", Platform="linux/arm64")

The idea behind build date is just to get a sense of what the user might have possibly installed. It won't be accurate but doesn't hurt to have one IMO. Or, perhaps you have a better idea?

Okay, you're trying to solve the problem where both the GitCommit and the SourceDate are either unknown or ignored. Okay, yes, agreed, if you want to report a BuildDate in that case, then I can absolutely implement it.

Is this what you want? https://github.com/ankitpokhrel/jira-cli/pull/245
It looks weird to me, but it does seem to fulfill your requirements.

@ankitpokhrel here it is in action:
$ go install ./... && jira version && sleep 1 && jira version
(Version="dev", GitCommit="", CommitDate="", BuildDate="2022-01-04T23:34:12+00:00", GoVersion="go1.17.5", Compiler="gc", Platform="linux/amd64")
(Version="dev", GitCommit="", CommitDate="", BuildDate="2022-01-04T23:34:13+00:00", GoVersion="go1.17.5", Compiler="gc", Platform="linux/amd64")

@ankitpokhrel

The idea behind build date is just to get a sense of what the user might have possibly installed.

If you want go build and/or go install to produce a program with embedded version information, then you need to add that information to source control. For a golang project, this could be implemented as
const (
    Version = "0.1.2"
)

or
//go:embed version.txt
var Version string

This, of course, means that a human needs to bump the version for every release.


Draft of test harness interfaces.

Based on https://docs.google.com/document/d/1eANhskKugz8hb09sw0ubdfFoPUL2nn3Eg-uqDzr6l_A/edit#

CC'ing model owners and some other folks. I couldn't find Carole Wu's github username, if someone could cc them for me.
@guschmue @petermattson @tjablin @christ1ne @psyhtest @yzh89 @itayhubara
Ptal.


Quiet ComboBox design fixes

Closes https://github.com/adobe/react-spectrum/issues/1444
✅ Pull Request Checklist:

[ ] Included link to corresponding React Spectrum GitHub Issue.
[ ] Added/updated unit tests and storybook for this change (for new code or code which already has tests).
[ ] Filled out test instructions.
[ ] Updated documentation (if it already exists for this component).
[ ] Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

Pending update to DNA

Closing for now, will reopen if we revisit


Update Notifications Drawer to handle notifications without uri

Description

Short description here *

closes #5593
Self Check:
Strike through any lines that are not applicable (~~line~~) then check the box

[x] Attached issue to pull request
[x] Changelog entry
[x] Code is clear and sufficiently documented
[x] Sufficient test cases (reproduces the bug/tests the requested feature)
[ ] Correct, in line with design
[ ] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: )

Pull request rejected by merge tool. Failed to parse change entry file: Invalid changelog entry file /tmp/tmpbtgcqc22/changelogs/unreleased/5512-invalid-date-orderDetails. Changelog entry files should always end with a .yml extension.

Processing this pull request

Processing #5606.


Cannot read property 'commands' of undefined

Reproduction step

Click any old template in marketplace list
Click "use" button, and show below error

#119 fixes this issues


Setting sandbox to false so that bytecode plugin works is a security threat

Describe the bug
I understand that it was asked to turn the sandbox option to false in order to protect source code using bytecode plugin as it uses the nodevm, however it is kinda dangerous tbh to do so although there are still other options like contextIsolation to prevent render process accessing the main process.
Can we do in any other alternative way so that we no need to set the sandbox value to false for browserWindow options and improving security? may be using something like Jailed/Hermes
https://electron-vite.org/guide/source-code-protection

Electron-Vite Version
2.0.0
Electron Version
32.0.0
Vite Version
Not using specifially in my dependencies, i think it comes with the vite-electron
Validations

[X] Follow the Code of Conduct.
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.

Ubuntu in next version 24.10 releases Security Centre with Prompting for permission, but in 24.04 is not it enabled or installable due experimental nature of snapd(from 24.10) in 24.04 and therefore backport of snapd or such possibility to make snap install security-center and prompting-client is not yet fully possible as stable option...


Refactor: Removed official adapters, added iterators

Changed keyv.options.store to keyv.store,
<Keyv>.iterator() yields an asyncIterator with all entries
Added tests for iterators
Removed official tests
Signed-off-by: Jytesh<EMAIL_ADDRESS>

@Kikobeats Tests pass now, would be wonderful if you could review and let me know about the iterator and adaptor loading

I might wanna merge all this commits into one

that's great 👏


Farming Simulator 17 not start black screen

Software information, settings used etc.
Farming Simulator 17, after updating dxvk to 0.42 with 0.40 replacement method in the /home/linux/.dxvk folder, the black screen in the game, reinstalled dxvk command
:
env WINEPREFIX = / home / linux / .wine / sh /home/linux/.dxvk/setup_dxvk.sh
/home/linux/.wine/drive_c/windows/system32

When the first time installed 0.40, then everything worked. When returning to 0.40 the problem remains.
System information

GPU: AMD Radeon R7 M260, APU with AMD Radeon R5 Graphics
Driver: AMDGPU, radeon
Wine version: 3.5
DXVK version: 0.42

On the Yandex disk page, the language changes in the lower right corner (go to the site from the computer)
Apitrace file(s)

https://yadi.sk/d/HBZmSqNC3USFST

Log files

https://yadi.sk/d/Z72iLgHT3USEqq
https://yadi.sk/d/pXkWNjr23USEo4
https://yadi.sk/d/lTMy7oVm3USEqP

I strongly do not scold you, I'm new to github

Why are you ignoring me ??

The DXVK package can be updated from the AUR (Arch Linux). This solves my problem!


San Angeles does not build.

Cmake errors out and gives error code 42.

I found the issue is due to the GLES/gl.h header not being found.


Bugfix current weather

If you asked for the current weather it was sometimes not updated correctly.

[ ] Ready for review

The whole caching system should be reworked and unified in all methods. It'd be best to rely on native HTTP caching (but make sure it actually works).

Closed because different approach was chosen: #433