Reduce dependencies

In this PR:

Removed the JS dependency on setting breakpoints required by the CSS. I've instead moved the relevant selectors into their appropriate @media blocks.
Removed the external jQuery dependency by rewriting the mobile nav functionality.
Removed the font-awesome dependency. 30KB of CSS and hundreds of kilobytes for fonts is not worth it for one hamburger icon.

Other possible improvements could include using 1 <nav> rather than 2 for the main menu.

I'll pass this one on to the Icelab team, using metaquery is their call - all seems reasonable to me but I'm not familiar with the benefits of using metaquery in the first place - @timriley @libbyberrie @tobydallder

I reckon if the same responsive layout changes have been achieved without metaquery, this is all good!

@raquelxmoss wrote the nav js - can you review the changes to that

Do you know a good casual image diff service? Since this changes the way responsive stuff is done, it'd be good to test it pretty thoroughly, but it can be tough to spot things when doing that manually. I've found percy.io pretty good but doesn't really work for this kind of thing - don't really want to set anything up permanently for this repo

Can you put some screenshots up? Changes if there's anything that's actually changed, or before/after if nothing should have changed

@mermop Will do - thanks!
I'll find a nice SVG replacement for the Menu Icon, and then take some before and after screenies.

Tablet screenshots

Before
After

Thanks for those? Only difference I can see is that the "menu" link is pink now for some reason?

@mermop Yup, I can happily swap it back to the grey.
Made it red so that it matches other links - not sure why it was grey to begin with.

Let's go back to grey for that please :)

@mermop Done :)

Couple of conflicts from merging #29 - will aim to do some testing of this this weekend

@mermop Conflicts resolved

Noting that these changes make the menu animation less nice:

Original menu animation

Changed menu animation

I'll start breaking this up into smaller PRs.


Settings menu items are overlapped

Settings menu items are overlapped when opened from within any level.

Can you provide some extra info? This is how I see them:


Can a model access other collections?

Using standalone Waterline (no global Sails object), can a model access the collections object somehow from a lifecycle event handler or from a custom behaviour function?

@eddieajau, did you find a solution for this?
My suggestion is that in waterline standalone you can also make collections global.

Just make sure the orm is in the scope of the model definitions, and you'll be all set.  In my project my model definition might look like,
module.exports = function(waterline) {

    /* now waterline is in the scope of the model definition */

    return {/* model definition with lifecycle callbacks, etc. */}
}

And I register the models as such,
var waterline = new Waterline();

// If the provided model info is a function, it wants waterline passed to it.
// This is used for lifecycle callbacks to have access to collections, etc.
if (typeof model === 'function') {
    model = model(waterline);
}

waterline.loadCollection(
    Waterline.Collection.extend(model)
);

I've moved onto using Sails proper, but I'd probably go with something like the suggestion from @devinivy if I was to go back to just using Waterline.


Develop a roadmap for Public Cloud Service for 23-24 Fiscal Year - (2/2)

Describe the Issue
The CPF Team requires a product roadmap to be built for fiscal year 23-24
Additional Context

Create a card sorting activity in Optimal using the high level priorities from the step above
Prepare and send out the invite to participate in the card sorting activity to all teams working in Public and Private Cloud (Olena can help get the contacts and to send the email)
Using the ordered priorities from the card sorting exercise, create a roadmap in Mural

Acceptance Criteria
A roadmap to be created in mural in the following format
.
.
.
.
.
.
.
.
.
.
.
Extra Template Info
Definition of Ready
These set of conditions will need to be met in order to bring a ticket into the sprint and start work. Protects the team from unclear requirements.
Issues (Task/Story/Spike) aligned to an EPIC and linked appropriately.
Assigned to the appropriate CPF MEMBER (and is not left blank in ZenHub) at the start of sprint (1st day of the sprint)
Acceptance has been defined for the issue and has been reviewed with CPF team and approved by the necessary approver.
Has been sized and estimated by the delivery team.
Detailed breakdown of the steps required to complete the story in the additional context
Any additional specifications have been documented, reviewed with CPF and approved by the necessary approver.
Acceptance Criteria
A set of pre-defined requirement that need to be met in order to mark the user story as “done”.
It should be testable with no room for interpretation
It should be either “pass” or “fail”
It should be clear enough for business stake holders to understand
As part of the user story, it should be written from the user perspective
A well written acceptance criteria is great for

managing expectations
defining scope
reducing ambiguity
establishing testing criteria for QA
Given (Pre-condition)
When (Action)
Then (Outcome)

Definition of Done
These set of conditions are met for work to be considered as complete on an issue.
All acceptance criteria(s) have been validated.
All the necessary documentation for the issue has been uploaded to Teams.
Functionality has been tested when applicable.
Functionality has been demonstrated to the relevant stakeholders (where applicable).
Story has been scheduled for a Sprint Demo/community update and impacted teams invited to the Demo.
Stories accepted by PO and documented for potential sharing with impacted users.

Documented = Captured in Community Update (CU) deck
Release notes = aspirational goal of providing a bulleted list of features and changes that our users can touch. Was going to store them in our Cloud Pathfinder repo. Can also display to users in the CU

Link to Final Mural Board- Public Cloud Accelerator Service Roadmap 23/24


Question on maximum number of entries

Is there a maximum number of entries right now, would you be interested in maybe adding an option in recent-menu.conf to let us choose how many entries to list?

https://github.com/natural-harmonia-gropius/recent-menu/commit/b100f188eabb33e01eec20f4665250e1e69d9d67

Now do I just make recent-menu.conf in the script-opts folder and add recent_menu-length=20?

length=20 I guess. Haven't used script-opts.

Tried length=4  and it's not working.

recent_menu.conf This will work, but I'm going to remove the line

script-opts/recentmenu.conf
length=4
should works

Ok it's working now just had to delete the old recent.json.
Is there a way I can move the recent.json to script-opts or does it have to be here:

Change the path here, I'll add an option later.

path=~~/script-opts/recent.json

Yup it works, thanks for making this script, I actually made a feature request for this exact feature a while ago tomasklaen/uosc/issues/404.


Question about bitwise operators

Bitwise operators are mysterious to me. What is this code doing? Rounding numbers down if they're not integers?
count = typeof count === 'number' ? (count|0) : 5
quality = typeof quality === 'number' ? (quality|0) : 10

The bitwise OR is a truncation. Converts float to integer - also turning NaN, non finite and non numbers to zero. You will sometimes also see ~~foo which is the same. It doesn't handle big numbers because of overflow.
Probably would have been clearer if I used Math.trunc (ES6) or Math.floor.


Where is chamfer ?

I saw "import chamfer" in "extension/dist_chamfer.py",but I can't find where "chamfer" is.Could you help me?

Thank you very much!Best wishes!
——邱守杰。
ThibaultGROUEIX<EMAIL_ADDRESS>于2019年8月27日周二 上午12:42写道：

The chamfer package is compiled by cd ./extension; python setup.py install.
I compiles the CUDA sources in extension/chamfer.cu.
For more information, you can take a look at
https://pytorch.org/tutorials/advanced/cpp_extension.html
Cheers,
Thibault
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ThibaultGROUEIX/AtlasNet/issues/28?email_source=notifications&email_token=AM3GFMCS7DA3ARYZ3YBFVEDQGQBW5A5CNFSM4IPION2KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5E5XMQ#issuecomment-524934066,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AM3GFMDXIJJMYY6C5PBC323QGQBW5ANCNFSM4IPION2A
.


Rearrange TriangleMesh function to workaround MSVC compiler bug

Closes #59964
So, this bug is a bit weird. One the surface, there should be nothing wrong we the way the code is written other than it perhaps looking a little clunky, but it seems that raycast collision tests totally break when compiling with MSVC with release compiler optimisations (and maybe LLVM too; I'm still looking into this). Changing it to this appears to make it work, whereas previous you couldn't click-select nodes in the 3D viewport. I only noticed the issue with raycast tests, but I added the same change to all the functions for consistency and safety.
I kind of want to look into this more including comparing assembly output since this could be a good test case for a compiler bugs, and the implication of other bugs like this popping up feels concerning.
While this specific line appears to be the culprit for this bug, there are other potentially concerning aspects of these functions including what appears to the stack array leaking, and the fact that while I don't think it should be possible to overrun the stack given how the BVH is generated, it still gives warnings to the effect potential stack overruns.

@SaracenOne
What you discover is VERY INTERSTING.
@lewiji  is able to build the dotnet6 branch and make it works (create csproj and dotnet publish) using Linux e.g. Ubuntu 20.04.
However, we are still struggling with MSVC build (it works partially, we are not able to create csproj, add an instance of c# script etc.)
I really wonder how much your finding here would be relevant to future Godot4 mono MSVC build

Thanks!


Bounces after present

Hi, can you a bounce after presentation?

Should be possible, but not part of the repo.


Track total live bytes for each peer

"live bytes" means those bytes which have been delivered to a handler
which is currently running. This supports a conservative assumption that
a handler uses memory proportional to the amount of bytes given to its
input channel.
The dispatcher thread is of course responsible for reporting the
increments, but spawnHandler does most of the work. Other programs can
inspect the node statistics, held in a SharedAtomic. The idea is that
a QDisc or perhaps the dispatcher thread itself will use this
information to induce an artificial delay on one or all peers in case of
heavy load (lots of live bytes).

@kantp


Workspace - "Find a workspace" text is missing from search bar

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.80-4
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers<EMAIL_ADDRESS>Issue reported by: Applause - Internal Team
Issue found when executing PR https://github.com/Expensify/App/pull/41158
Action Performed:

Open New Expensify app
Sign into a valid account
Click on WS switcher and observe the search bar

Expected Result:
According to the PR, there should be a search bar with the text "Find a workspace"
Actual Result:
There is no text within the search bar
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

View all open jobs on GitHub

@CortneyOfstad  FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

Going to check with the design team on this, as I am not sure if the text was not listed intentionally.

Confirmed with the design team here, that this is not a bug as how it's displayed now is the same as if you're searching for a category (for example) when you submit an expense.
Closing!


Receiving HTTP Error 403: Forbidden in youtube plugin

Looks like the API key stopped working.

Working now?


During a refresh of the Order Page we get an error

@mkanoor Please retest.  If this is still an issue let us know what env you are hitting this on.  Also, recommend that you clear cookies as well.

Works as documented


Cannot change size of dropdown

Just to verify, the issue you're experiencing is that the dropdown does not extend to fill the whole region?  If so, that is expected behavior.
The col-lg-3 class is only applying to the parent, not the dropdown itself.  This is consistent with the behavior of the native select[multiple] element.
However, I did not that the appropriate solution (applying the width styling or a form-control class to the dropdown element itself) does not result in the correct results either.  I'll make an update later which allows you to style the width of the drodown.

Hi!
A posible solution to it's works, as @subhani1249 says, would be change this:

            <button type="button" class="dropdown-toggle" ....></button>

to this:

            <button type="button" class="dropdown-toggle" ....></button>

I only have checked it out with bootstrap v4 and works ok.
It's more semantically correct to use '.dropdown' class attribute. '.btn-group' is not necessary here because you are not grouping buttons.

Class has been changed to  in latest version.

still not able to change width?

Same issue!


How to set up table "mysql.slave_master_info" in master database in mariadb

GRANT SELECT ON mysql.slave_master_info TO 'orc_client_user'@'%';
ERROR 1146 (42S02): Table 'mysql.slave_master_info' doesn't exist
When I checked the error reason in google, might mariaDB has no "mysql.slave_master_info" table,
According to the coordinator's documentation, it supports MariaDB.
How to get I setting it?

Sorry for hjacking your thread. But it seems like our problem could be related.
This is my topology.
[root@kp7-h4 orchestrator]# /usr/local/orchestrator/orchestrator -c topology -i kp7-h1:3306
kp7-h1:3306 [0s,ok,10.6.5-MariaDB-log,rw,ROW]
kp7-h2:3306 [0s,ok,10.6.5-MariaDB-log,ro,ROW,>>,GTID]
kp7-h3:3306 [0s,ok,10.6.5-MariaDB-log,ro,ROW,>>,GTID]
When i try to do a takeover , old slave -> new master , old master -> new slave
[root@kp7-h4 orchestrator]# /usr/local/orchestrator/orchestrator -c graceful-master-takeover-auto -i kp7-h1:3306
2022-02-27 11:20:46 ERROR Error 1146: Table 'mysql.slave_master_info' doesn't exist
2022-02-27 11:20:47 FATAL Replication not running
I am using MariaDB 10.6 .It seems like the old master does not know how to connect to new master.


24hr formatting

Several cities have fully or partially unstandardized time formats in the output files (or at least in the links on the readme). I can't get your docker image up and running on my machine, so I can't replicate or fix the mistakes. Basically for all or a part of the data for each city, the PM indicators in the time/date data is dropped, causing many times to be in 12-hr format.

I think I am hitting a similar issue with time formats.  I did get a docker image up and running but the generate_dataset.py generates exceptions:
loading data and assigning column types
loading file  /data/data/raw/NewOrleans/calls_2011.csv
HERE !!!!
Index(['NOPD_Item', 'Type_', 'TypeText', 'Priority', 'MapX', 'MapY',
'TimeCreate', 'TimeDispatch', 'TimeArrive', 'TimeClosed', 'Disposition',
'DispositionText', 'BLOCK_ADDRESS', 'Zip', 'PoliceDistrict',
'Location'],
dtype='object')
Traceback (most recent call last):
File "/usr/local/lib/python3.6/site-packages/pandas/core/arrays/datetimes.py",
line 1856, in objects_to_datetime64ns
values, tz_parsed = conversion.datetime_to_datetime64(data)
File "pandas/_libs/tslibs/conversion.pyx", line 200, in pandas._libs.tslibs.co
nversion.datetime_to_datetime64
TypeError: Unrecognized value type: <class 'str'>
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "generate_dataset.py", line 18, in
new_orleans.process_data()
File "/data/src/cities/city.py", line 267, in process_data
Geo.process(self)
File "/data/src/features/geo.py", line 149, in process
process_city(city)
File "/data/src/features/geo.py", line 81, in process_city
result = (city.pipe(rename_positional_columns, checkpoint='geo_positional')
File "/data/src/cities/city.py", line 700, in pipe
self.load_raw_data()
File "/data/src/cities/city.py", line 121, in load_raw_data
self.consolidate_all()
File "/data/src/cities/city.py", line 219, in consolidate_all
all_data.append( self.load_and_fix_types(str(file)))
File "/data/src/cities/city.py", line 210, in load_and_fix_types
data[column] = pd.to_datetime(data[column], format=column_date_format)
File "/usr/local/lib/python3.6/site-packages/pandas/core/tools/datetimes.py",
line 724, in to_datetime
cache_array = _maybe_cache(arg, format, cache, convert_listlike)
File "/usr/local/lib/python3.6/site-packages/pandas/core/tools/datetimes.py",
line 152, in _maybe_cache
cache_dates = convert_listlike(unique_dates, format)
File "/usr/local/lib/python3.6/site-packages/pandas/core/tools/datetimes.py",
line 447, in _convert_listlike_datetimes
allow_object=True,
File "/usr/local/lib/python3.6/site-packages/pandas/core/arrays/datetimes.py",
line 1861, in objects_to_datetime64ns
raise e
File "/usr/local/lib/python3.6/site-packages/pandas/core/arrays/datetimes.py",
line 1852, in objects_to_datetime64ns
require_iso8601=require_iso8601,
File "pandas/_libs/tslib.pyx", line 481, in pandas._libs.tslib.array_to_dateti
me
File "pandas/_libs/tslib.pyx", line 620, in pandas._libs.tslib.array_to_dateti
me
ValueError: time data 01/01/2011 04:44:15 AM doesn't match format specified

I have made some progress by editing NewOrleans.py:
was:
DATE_FORMAT = '%Y-%m-%d %H:%M:%S.%f'
to:
DATE_FORMAT = "%m/%d/%Y %I:%M:%S %p"
It's taking along time to process so this may not be the only issue.


[GITLAB] Instructions are wrong for gitlab webhook

I followed the tutorial for the gitlab webhook install. I will comment on each step what I think is the issue.

Ok
Ok
Following steps 4-7 of the github install is misleading. In step 5., there is no way to follow:
- Copy your app's private key to the private_key field.
- Copy your app's ID to the app_id field.
Supposing in the last step that you should not fill that data, but instead the data from this step, I note that in the [gitlab] section in .secrets.toml only contains:

[gitlab]
# Gitlab personal access token
personal_access_token = ""

Also, the deployment_type variable in configurations.toml is present on the [github] section and is not in the options presented by the comment:
[github]
# The type of deployment to create. Valid values are 'app' or 'user'.
deployment_type = "user"

Also, although not mentioned, I think we need to set git_provider="gitlab" (that is how the container worked for me). As last, the default secret_provider is google_cloud_storage, which gives errors if you have not set up the rest of google. I believe the default should be the local secrets, but I did not find how to do it.
5. Ok
6. Ok
I would love some help from someone, because even identifying some of these errors and trying to set everything right, I was not able to make it work (the container runs, but refuses the connections sent by slee):
Error: connect ECONNREFUSED <IP_ADDRESS>:3000
    at TCPConnectWrap.afterConnect [as oncomplete] (node:net:1595:16) {
  errno: -111,
  code: 'ECONNREFUSED',
  syscall: 'connect',
  address: '<IP_ADDRESS>',
  port: 3000,
  response: undefined
}

with no log message.

@okotek

I followed the tutorial for the gitlab webhook install. I will comment on each step what I think is the issue.

Ok
Ok
Following steps 4-7 of the github install is misleading. In step 5., there is no way to follow:
- Copy your app's private key to the private_key field.
- Copy your app's ID to the app_id field.
Supposing in the last step that you should not fill that data, but instead the data from this step, I note that in the [gitlab] section in .secrets.toml only contains:

[gitlab]
# Gitlab personal access token
personal_access_token = ""

Also, the deployment_type variable in configurations.toml is present on the [github] section and is not in the options presented by the comment:
[github]
# The type of deployment to create. Valid values are 'app' or 'user'.
deployment_type = "user"

Also, although not mentioned, I think we need to set git_provider="gitlab" (that is how the container worked for me). As last, the default secret_provider is google_cloud_storage, which gives errors if you have not set up the rest of google. I believe the default should be the local secrets, but I did not find how to do it.
5. Ok
6. Ok
I would love some help from someone, because even identifying some of these errors and trying to set everything right, I was not able to make it work (the container runs, but refuses the connections sent by slee):
Error: connect ECONNREFUSED <IP_ADDRESS>:3000
    at TCPConnectWrap.afterConnect [as oncomplete] (node:net:1595:16) {
  errno: -111,
  code: 'ECONNREFUSED',
  syscall: 'connect',
  address: '<IP_ADDRESS>',
  port: 3000,
  response: undefined
}

with no log message.

Hello Lucas! I am encountering the same error as yours. Did you fix that error and how you solved the google cloud problem? I would appreciate your response! @Lucas-Froguel

What is working for me:
docker-compose.yml
version: '3.2'

services:
  pr-agent:
    image: codiumai/pr-agent:gitlab_webhook
    restart: always
    volumes:
     - ./configuration.toml:/app/pr_agent/settings/configuration.toml
     - ./.secrets.toml:/app/pr_agent/settings/.secrets.toml
    ports:
     - 9101:3000

where configuration.toml has these changes
❯ git diff pr_agent/settings/configuration.toml
diff --git a/pr_agent/settings/configuration.toml b/pr_agent/settings/configuration.toml
index dd863eb..2db3875 100644
--- a/pr_agent/settings/configuration.toml
+++ b/pr_agent/settings/configuration.toml
@@ -1,7 +1,7 @@
 [config]
 model="gpt-4" # "gpt-4-1106-preview"
 fallback_models=["gpt-3.5-turbo-16k"]
-git_provider="github"
+git_provider="gitlab"
 publish_output=true
 publish_output_progress=true
 verbosity_level=0 # 0,1,2
@@ -12,7 +12,7 @@ max_description_tokens = 500
 max_commits_tokens = 500
 max_model_tokens = 32000 # Limits the maximum number of tokens that can be used by any model, regardless of the model's default capabilities.
 patch_extra_lines = 3
-secret_provider="google_cloud_storage"
+#secret_provider="google_cloud_storage"
 cli_mode=false

 [pr_reviewer] # /review #
@@ -121,7 +121,7 @@ push_commands = [

 [gitlab]
 # URL to the gitlab service
-url = "https://gitlab.com"
+url = "https://gitlab.example.com/"

 # Polling (either project id or namespace/project_name) syntax can be used
 projects_to_monitor = ['org_name/repo_name']

and .secrets.toml is
[openai]
key = "<some openai key>"

[gitlab]
# Gitlab personal access token
personal_access_token = "<some personal access token>"
shared_secret = "<some shared secret>"

[github]
deployment_type = "gitlab"

thanks @froque

Thanks @froque .
By the way, in GitLab you should specify a webhook URL with a specific path! (/webhook)
For @froque  example it would be http://youcontainer.com:9101/webhook

in ec2 , I have created instance and using webhook image ,
but getting following issue
ubuntu@ip-172-31-9-150:~$ sudo docker-compose up
[+] Running 2/2
✔ Network ubuntu_default       Created                                                                                0.1s
✔ Container ubuntu-pr-agent-1  Created                                                                                0.1s
Attaching to ubuntu-pr-agent-1
ubuntu-pr-agent-1  | Traceback (most recent call last):
ubuntu-pr-agent-1  |   File "/app/pr_agent/servers/gitlab_webhook.py", line 14, in
ubuntu-pr-agent-1  |     from pr_agent.agent.pr_agent import PRAgent
ubuntu-pr-agent-1  |   File "/app/pr_agent/agent/pr_agent.py", line 9, in
ubuntu-pr-agent-1  |     from pr_agent.git_providers.utils import apply_repo_settings
ubuntu-pr-agent-1  |   File "/app/pr_agent/git_providers/init.py", line 6, in
ubuntu-pr-agent-1  |     from pr_agent.git_providers.github_provider import GithubProvider
ubuntu-pr-agent-1  |   File "/app/pr_agent/git_providers/github_provider.py", line 22, in
ubuntu-pr-agent-1  |     class GithubProvider(GitProvider):
ubuntu-pr-agent-1  |   File "/app/pr_agent/git_providers/github_provider.py", line 132, in GithubProvider
ubuntu-pr-agent-1  |     tries=get_settings().github.ratelimit_retries, delay=2, backoff=2, jitter=(1, 3))
ubuntu-pr-agent-1  |   File "/usr/local/lib/python3.10/site-packages/dynaconf/utils/boxing.py", line 21, in evaluate
ubuntu-pr-agent-1  |     value = f(dynabox, item, *args, **kwargs)
ubuntu-pr-agent-1  |   File "/usr/local/lib/python3.10/site-packages/dynaconf/utils/boxing.py", line 44, in getattr
ubuntu-pr-agent-1  |     return super().getattr(n_item, *args, **kwargs)
ubuntu-pr-agent-1  |   File "/usr/local/lib/python3.10/site-packages/dynaconf/vendor/box/box.py", line 176, in getattr
ubuntu-pr-agent-1  |     raise BoxKeyError(str(E))from _A
ubuntu-pr-agent-1  | dynaconf.vendor.box.exceptions.BoxKeyError: "'DynaBox' object has no attribute 'ratelimit_retries'"
ubuntu-pr-agent-1 exited with code 0
ubuntu@ip-172-31-9-150:~$


Bugfix/miranum console only starts in existing directories

Issue

https://www.notion.so/miragon/Bug-Creating-new-miranum-project-bae2a161edd74968992d4a5223888e67

Description

Miranum Console works if the user has no workspace selected
Refactored the entire miranum console

Checklist

Code is easy to understand
No obvious errors or bugs
CI/CD Pipelines did run successfully
Tests were implemented
Documentation was created

Codecov Report
Base: 63.27% // Head: 63.27% // No change to project coverage :thumbsup:

Coverage data is based on head (85f66ed) compared to base (0da3622).
Patch coverage: 75.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #84   +/-   ##
=======================================
  Coverage   63.27%   63.27%
=======================================
  Files          14       14
  Lines         305      305
  Branches       40       40
=======================================
  Hits          193      193
  Misses         72       72
  Partials       40       40

Flag
Coverage Δ

unittests
63.27% <75.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

libs/miranum-core/src/lib/miranum-core.ts
64.10% <63.63%> (+0.94%)
:arrow_up:

apps/miranum-cli/src/app/shared/fs.ts
90.47% <100.00%> (-0.23%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Control Exclude checkbox in search from extension

When executing search from extension api 2 checkboxes are not exposed:

Preserve Case
Use Exclude Settings and Ignore Files

vscode.commands.executeCommand('workbench.action.findInFiles', {
  query: regexStr,
  isRegex: true,
  triggerSearch: true,
});

Hi @roblourens , I would like to contribute. Can you guide me as to what exactly needs to be done?

Hey @usernamehw , Can you please explain a little more about the issue?

@dhairyanadapara It's possible to trigger a search from extension by using this api:
vscode.commands.executeCommand('workbench.action.findInFiles', {
  query: 'example',
});

And it has good amount of options:
export interface IFindInFilesArgs {
	query?: string;
	replace?: string;
	triggerSearch?: boolean;
	filesToInclude?: string;
	filesToExclude?: string;
	isRegex?: boolean;
	isCaseSensitive?: boolean;
	matchWholeWord?: boolean;
}

But 2 of them are missing:

Preserve Case
Use Exclude Settings and Ignore Files

Thank @usernamehw, got the idea. I will raise a PR to fix the issue ASAP :)

@usernamehw @roblourens  I have raised the PR. If you get time please review :)

@roblourens genuinely didn't notice the existing PR, apologies @dhairyanadapara

Thanks @roblourens :). No problem @rotem-bar.

It great now that it's possible to control it 👍 but why does it called excludeSettingAndIgnoreFiles? Would it possible to have the same name as in label:
- excludeSettingAndIgnoreFiles
+ useExcludeSettingsAndIgnoreFiles

Updated to useExcludeSettingsAndIgnoreFiles as per @usernamehw's suggestion and for consistency with search editor post #108750. Also added these to the keybindings intellisense registry.


[Flaky multikueue e2e test] The connection to a worker cluster is unreliable Should update the cluster status to reflect the connection state

What happened:
The test failed on unrelated branch: https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/kubernetes-sigs_kueue/3445/pull-kueue-test-multikueue-e2e-main/1853747452654391296
What you expected to happen:
No random failures
How to reproduce it (as minimally and precisely as possible):
Use CI
Anything else we need to know?:
End To End MultiKueue Suite: kindest/node:v1.30.0: [It] MultiKueue when The connection to a worker cluster is unreliable Should update the cluster status to reflect the connection state expand_less	1m16s
{Timed out after 5.000s.
The function passed to Eventually failed at /home/prow/go/src/sigs.k8s.io/kueue/test/util/util.go:88 with:
NotFoundError expects an error failed [FAILED] Timed out after 5.000s.
The function passed to Eventually failed at /home/prow/go/src/sigs.k8s.io/kueue/test/util/util.go:88 with:
NotFoundError expects an error
In [AfterEach] at: /home/prow/go/src/sigs.k8s.io/kueue/test/e2e/multikueue/e2e_test.go:178 @ 11/05/24 10:44:58.957
}

/kind flake


Unable to generalize a type variable. It is not unranked.

This issue is very much in the same space as #774 and in particular resulted from an approach along the lines of the DayDict suggested by @amigalemming and others.
I'm modelling a graph with nodes and edges and need dictionaries keyed by edges.  My current code has type annotations of Dict ( comparable, comparable ) a) everywhere, which isn't very readable.  As discussed in #774 you can't (currently) go Dict (Edge comparable) a so I went down the road of implementing an edgeDict module.
Code snippet below:
module EdgeDict exposing (..)

import Dict exposing (Dict)

type EdgeDict comparable a
    = EdgeDict (Dict ( comparable, comparable ) a)

fromList : List ( ( comparable, comparable ), a ) -> EdgeDict comparable a
fromList list =
    Dict.fromList list |> EdgeDict

This fails to compile with
elm-make: It looks like something went wrong with the type inference algorithm.

Unable to generalize a type variable. It is not unranked.

Ironically, if you removed the type declaration for fromList, it does compile while simultaneously warning you to add the type declaration that makes it fail ;)

Here's another simpler example that causes the same error:
test : ( String, comparable ) -> Dict ( String, comparable ) String
test key =
    Dict.insert key "" Dict.empty

Changing it to the following works:
test : comparable -> Dict comparable String
test key =
    Dict.insert key "" Dict.empty

But the following does not (as expected):
test : a -> Dict a String
test key =
    Dict.insert key "" Dict.empty

This appears to be a problem with how comparable is handled specially by the compiler.
comparable should be equivalent to (comparable, comparable) or any combination of Tuples of comparable, e.g. (String, (comparable, Int)).

Based on commit 4b25980d93ada12236c794f35570e197be82f787, this code is going through without errors on my development build!


Support for externally linked gates

This is my preliminary PR for externally linked gates, as suggested here https://github.com/qBraid/qbraid-qir/issues/167.
This is probably not ready to merge, but I figured it's easier if I get some feedback first. I will follow up with a PR for qbraid-qir shortly. With both changes, external gates work in qbraid-qir, at least for my use-case.
With this change pyqasm accepts a list of custom gates, that should not be unrolled into their definition.
e.g. with qasm3_module.unroll(external_gates=["mygate"]), the following QASM would be unrolled into an AST that contains a "mygate" node, rather than the nodes in the definiton of "mygate".
OPENQASM 3.0;
include "stdgates.inc";
gate mygate(p0) _gate_q_0, _gate_q_1 {
  h _gate_q_1;
  cx _gate_q_0, _gate_q_1;
  rz(p0) _gate_q_1;
  cx _gate_q_0, _gate_q_1;
  h _gate_q_1;
}
bit[2] c;
qubit[2] q;
ry(pi/2) q[0];
mygate(pi/2) q[0], q[1];

Hey, thanks for the changes! I've given some comments on this and the linked PR.
The only change I see is making the acceptable external_gates more generic and not confined to user defined custom gates. There may very well be a use case when someone wants to stop the decomposition of, say, a crz gate and pass that in the external_gates list. Since we support that gate natively in our unroller, it would not be possible to specify that in the external_gates variable with the current logic.

Hey, @Sola85 just a heads up - we added some new commits to main so you'll probably need to rebase the PR against it

Hi @TheGupta2012, thanks for the feedback! I hadn't realized that pyqasm unrolls some gates into other gates and therefore thought it didn't make sense to mark non-custom gates as external.
With my last commit, it should be possible to mark any gate as external (I've added a test that tests this for the u3 gate). What is still missing is the unrolling of gates with multiple targets (e.g. u3(0.5, 0.5, 0.5) q[0], q[1];). Currently this doesn't work for external gates (and I think also not for custom gates).
I was wondering if it made sense to offload this unrolling logic into somewhere outside of _visit_*_gate_operation(), since it is identical for all types of gates.

I agree, the unrolling of gates with multiple targets is not handled for custom operations. This is because of the assumption that any custom gate will eventually be broken down into simpler gates with either the user supplied definition or the one present in the maps.py.
We can have something like a _broadcast_gate_operation which will essentially use the same logic present in _visit_basic_gate_operation for decomposing multiple targets but, as you suggested, make it more generic so that it can be used on every gate. This method would return a list of QuantumGate with the qubit arguments transformed according to the op count of gate.
A point to note is that this will only be required when we are dealing with external gates as any non-external gate will eventually be broken down into simpler gates already having this broadcast logic.

Another thing to note is about the qubit depths. We recently added the support for calculating the depth of a quantum program in pyqasm and with this change, there would be some impact on the depth calculation logic.
Eg, if we are unrolling with an external gate custom_1 -
OPENQASM 3.0;
qubit[3] q;
gate custom_1 a {
     h a;
     x a;
}
custom_1 q[0];
custom_1 q[1];

the final unrolled qasm would look like -
OPENQASM 3.0;
qubit[3] q;
custom_1 q[0];
custom_1 q[1];

Inside the depth calculation, we are making a call to unroll before calculating the depth using individual qubits. A couple of points to note here -

Since the final unrolled_qasm only contains custom_1 op, which might very well be the basis gate of a QC, the depth of the program should come out to be 1. But the depth we get is 2 as internally we visit the custom_1 definition and update the qubit depths to 2 -

In [16]: import pyqasm

In [17]: qasm_str = """
    ...: OPENQASM 3.0;
    ...: qubit[3] q;
    ...: gate custom_1 a {
    ...:      h a;
    ...:      x a;
    ...: }
    ...: custom_1 q[0];
    ...: custom_1 q[1];"""

In [18]: mod = pyqasm.load(qasm_str)

In [19]: mod.unroll(external_gates = ["custom_1"])

In [20]: mod.unrolled_qasm.splitlines()
Out[20]:
['OPENQASM 3.0;',
 'include "stdgates.inc";',
 'qubit[3] q;',
 'custom_1 q[0];',
 'custom_1 q[1];']

In [21]: mod.depth()
Out[21]: 2

This is incorrect as we want to get the depth of the current unrolled program and not unroll it yet again.

The _visit_external_gate_operation should also update the qubit depths before returning the resulting gate. Moreover, when it is calling the _visit_basic_gate_operation, qubit depths are implicitly getting updated which is not correct.

This might expand the scope a bit and I think for now you can add a test in tests/qasm3/test_depth.py with a @pytest.mark.skip decorator highlighting this bug. Once this PR merges, I'll create a follow up issue to tackle it.

Changes since my last comment:

I have isolated the broadcasting logic into a separate function which works for basic gates and external gates
There is an additional test for broadcasting external gates
I have added a test for depth-calculation of external gates, but this is currently skipped (and, as you said, could be addressed in a separate issue)

I have not yet extended the broadcasting logic to custom gates i.e. something like
gate mygate() _gate_q_0,  {
  h _gate_q_0;
}
qubit[2] q;
mygate() q;

still does not work. But I think this is also not related to this PR and could be addressed separately

Thanks for working on this @Sola85 , the changes look good!

Thanks for the feedback and thanks for merging!


54 expose keyspace list meta iter

In writing an application that uses the datacake_eventual_consistency it is essential to be able to obtain a list of keyspaces and keys within a keyspace.
Two new functions:
get_keyspace_list - returns a vectors of strings listing all keyspaces in the datacake_eventual_consistency store.  This effectively just exposes the underlying stores implementation.
get_keyspace_keys - rather than returning an iterator to the stores metadata to the, this function collects the keys and returns them as a vector of tuples.
The new functions have associated tests.
Closes #54

I'm not against having these exposed, but we should make it clear in the documentation that they are not guaranteed to be all the values across the cluster, and instead are only what the local-node is aware of.

Do you prefer to just expose the iter_metadata method of the bundle underlying store rather than the method that has already collected them?
I went back and forth.
What I prefer about exposing the iterator rather than a function that already collects the metadata is that it would not effectively duplicate the collection of metadata.
I also like preserving the interface of the Storage trait.
It is really easy to change at this point.
I agree about the documentation comment, however, that is relevant to all get oriented calls in the eventual_consistent store.

Do you prefer to just expose the iter_metadata method of the bundle underlying store rather than the method that has already collected them?

I think for consistency we should just return the metadata iterator, since worse case someone can collect it themselves if they wish, or they can avoid the additional iterations if they just want to loop over the values.

I agree about the documentation comment, however, that is relevant to all get-oriented calls in the eventual_consistent store.

Yes you are very right about that, the docs on the get methods should also be a bit more explicit, that can be a separate PR though I think

Reverted the code to exposing iter_metatdata as discussed above.  PR ready for review.
Thank you!

I am new to Rust and its ecosystem.  Thank you for the pointer to the linter!  (love consistency)


Minimum markers in a cluster?

I have tried to reduce the number of markers in radar_search.json and then to run ClusteringDemoActivity: if there are at least 5 markers then they are shown as a cluster; if there are
less then 5 makers then they are shown as distinct markers regardless the zoom level.
Is it a by-design limit?
Is it a configurable parameter?
Thanks.

OK, I just need to configure DefaultClusterRenderer.


feat(ecs): change the default generation to Amazon Linux v2

This change make CDK consistent with the recommendataion we give customers: https://docs.aws.amazon.com/AmazonECS/latest/developerguide/ecs-optimized_AMI.html. This closes #3005.
BREAKING CHANGE: Previously, the default generation is conditionally set to Amazon Linux v1 if hwType is STANDARD. Now it always default to Amazon Linux v2.

[x] Testing

Unit test added (prefer not to modify an existing test, otherwise, it's probably a breaking change)
CLI change?: coordinate update of integration tests with team
cdk-init template change?: coordinated update of integration tests with team

[x] Docs

jsdocs: All public APIs documented
README: README and/or documentation topic updated
Design: For significant features, design document added to design folder

[x] Title and Description

Change type: title prefixed with fix, feat and module name in parens, which will appear in changelog
Title: use lower-case and doesn't end with a period
Breaking?: last paragraph: "BREAKING CHANGE: <describe what changed + link for details>"
Issues: Indicate issues fixed via: "Fixes #xxx" or "Closes #xxx"

[N/A] Sensitive Modules (requires 2 PR approvers)

IAM Policy Document (in @aws-cdk/aws-iam)
EC2 Security Groups and ACLs (in @aws-cdk/aws-ec2)
Grant APIs (only if not based on official documentation with a reference)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Probably more integ tests that need updating

Probably more integ tests that need updating

Looks like unit tests (and likely integ tests) for other non-ECS services are failing. Will address them

Integration tests in @aws-cdk/aws-events-targets are failing. @hencrice can you run build.sh as there are multiple modules with integ tests/expected files referencing the amazon linux version.
Failure:
@aws-cdk/aws-events-targets: Verifying ecs/integ.event-ec2-task.lit.js against ecs/integ.event-ec2-task.lit.expected.json


Add Scaffolder Sentry Plugin

Hey, I just made a Pull Request!
#15543 Adding a scaffolder Sentry Plugin.
:heavy_check_mark: Checklist

[x] A changeset describing the change and affected packages. (more info)
[x] Added or updated documentation
[ ] Tests for new functionality and regression tests for bug fixes
[x] Screenshots attached (for UI changes)
[x] All your commits have a Signed-off-by line in the message. (more info)

ah, you'll also want to run yarn build:api-reports again and commit the response.

@benjdlambert done

Nice thanks @dpfaffenbauer!

🙌 🎉  from discovering backstage to my first contribution: 9 days.


Missing parent: inconsistent parentage in RNA processing branch

rRNA modification/tNRA modification are under RNA processing
snRNA  modification is not under snRNA processing

GO term ID and label for which you request a new superclass

New superclass (parent) suggested

Reference(s), if appropriate
PMID:nnnnnnn

Also - processing should not be under 'catabolic process'
It should mean biosynthetic process/maturation. But we need to check that the annotations are consistent with this.
Thanks, Pascale

Note the catabolism problem was due to a logical def issue and only appeared recently. Was dealt with in
https://github.com/geneontology/go-ontology/issues/27633

Note that the modification terms have logical defs but the ones which are correctly positioned under their  RNA processing
terms have this relation instantiated so I have done the same for snoRNA. Maybe one day the "RNA modification" terms will go, but this makes everything in the correct place.


Toggling possibility on user interaction

Hi,
I need panes to be toggled on/off, on some user interaction, let's say button click.  As workaround I've manage to achieve this by inline style overriding flex style, which also gives me warning message that I need to divide the shorthand flex command, line by line.
If i'm not overriding the flex style, collapsing of the panes, works only if user starts moving the resize handles.
Current version of the code snippet:
<Fragment>
            {isToggled ? (
              <Panel1
                style={{
                  flex: '95 1 0',
                }}
              >
                {child}
              </Panel1>
            ) : (
              <Panel2
                defaultSize={30}
                minSize={30}
                maxSize={5}
                }}
              >
                {child}
              </Panel2>
            )}
            {index < children.length - 1 && <ResizeHandle /> )}
</Fragment>

Please check out the docs:
https://react-resizable-panels.vercel.app/examples/imperative-panel-api


Roll engine afb9d510c3bb..647a8524b0d7 (9 commits)

https://github.com/flutter/engine/compare/afb9d510c3bb...647a8524b0d7
git log afb9d510c3bb0f1b97980434b41200a2d3491697..647a8524b0d722a4a2ce976adb5ed9c981e61b82 --no-merges --oneline
647a8524b Revert "Switch PlatformViewsController from Activity ref to Application ref. (#9193)" (flutter/engine#9211)
1d4f3372d Roll src/third_party/skia c5fae22bce20..93d0146dc6a1 (1 commits) (flutter/engine#9209)
2a57255fc Roll src/third_party/skia 642178396b09..c5fae22bce20 (3 commits) (flutter/engine#9208)
2bc2cee67 Roll src/third_party/skia 0f809020ecb0..642178396b09 (2 commits) (flutter/engine#9207)
ca572db14 Roll src/third_party/skia e0d90c84e42f..0f809020ecb0 (5 commits) (flutter/engine#9205)
3371da1e0 Add platform_fuchsia.cc for default font on fuchsia (flutter/engine#9204)
782654846 Align fuchsia and non-fuchsia tracing (flutter/engine#9199)
5ea125eaf Switch PlatformViewsController from Activity ref to Application ref. (flutter/engine#9193)
fd4368c85 Skip golden tests on non-Linux OSes (flutter/engine#9198)
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (bmparr@google.com), and stop
the roller if necessary.

Trybots failed. These were the failed builds: https://cirrus-ci.com/task/4521055536807936 , https://cirrus-ci.com/task/5084005490229248 , https://cirrus-ci.com/task/5620567164583936 , https://cirrus-ci.com/task/4916879722807296 , https://cirrus-ci.com/task/6746467071426560 , https://cirrus-ci.com/task/5646955443650560

Commit queue failed; closing this roll.


3rd dOrg Open House planning

[ ] Try align with DAO Rush Week
[ ] Event Schedule
[ ] Define speakers
[ ] Promotional schedule (min 2 weeks)
[ ] Prepare testimonials and review membrane activation funnel

https://www.eventbrite.com/o/dorg-20010113112
These have been happening quarterly. The first was on June 4 and then September 3. So the next one should be in the first week of December.

This is a video of the previous one.
https://www.youtube.com/watch?v=XRFJD2EDykk&t=17s
Any ideas on how we can improve this time?

https://docs.google.com/document/d/17Vv6_uAlWL4Cx4wOlEVbxJQhqsmKCBkgc4IHWIMeceM/edit
This is a Google Doc with options for the possible dates of the Rush Week. We should choose which date would work best for us and vote on it with a comment. Just FYI

https://www.eventbrite.com/e/dorg-open-house-dao-rush-week-tickets-134333325593
Still need to promote and prep slideshow

https://www.eventbrite.com/e/dorg-open-house-dao-rush-week-tickets-134333325593
Still need to promote and prep slideshow


Resolution selection (HLS Video)

How to add option for select the video resolution like youtube player?

show me the screenshort, what effect

I want to play m3u8 video with many resolution using this library, is this lib automate show the video resolution list in the player?
Like this library (Angular Lib for video player) https://videogular.github.io/videogular2/

I can not unstardand your need.
Can you show me the screenshort?

I also have same query, here is screenshot of what I need

I have different urls for all qualities but how I merge them for showing in one player
Example:
SD = "http:// ......SD quality url......."
HD = "http://......HD quality url......."
FHD = "http://......FHD quality url......."
how I add them all in one player and show a quality selector and if someone switch quality, player start buffering from respective url
LIKE: If currently player is playing "SD" video and then I click on "HD" then player starts loading "HD video url" from same SEEK POSITION

see apiacapiactivity in demo, Does it meet your requirements?

thanks, this is exactly what I want
But a little query more, I want this Quality Selector to show in SCREEN_WINDOW_NORMAL also.... for now it is only visible when Player switch to SCREEN_WINDOW_FULLSCREEN
I want to show this in SCREEN_WINDOW_NORMAL also

try to shield the logic

thanks for your help

see apiacapiactivity in demo, Does it meet your requirements?

where is it? i can't find it in demo :(

see apiacapiactivity in demo, Does it meet your requirements?

it don't work correctly after changing quality

yes it has bug now

I want to set multiple of video how to set i don't
Please help me.

How to set quality of videos like auto,1080,720,like this
Please help me

I had made it... quiet easy ::
private void setupPlayer() {
        LinkedHashMap map = new LinkedHashMap();
        map.put("240p", "http://__240p__url__");
        map.put("360p", "http://__360p__url__");
        map.put("480p", "http://__480p__url__");

        JZDataSource jzDataSource = new JZDataSource(map, "Title Of Video");
        jzDataSource.looping = true;
        jzDataSource.currentUrlIndex = "2"; // default qualityIndex [2=480p]
        jzDataSource.headerMap.put("key", "value"); //header
        viewPlayer.setUp(jzDataSource
                , JzvdStd.SCREEN_WINDOW_NORMAL);

        Glide.with(this)
                .load("http://__thumbnail__url__")
                .apply(new RequestOptions().placeholder(R.drawable.spinner))
                .into(viewPlayer.thumbImageView);

        mSensorManager = (SensorManager) getSystemService(SENSOR_SERVICE);
        mSensorEventListener = new Jzvd.JZAutoFullscreenListener();

        Jzvd.setVideoImageDisplayType(Jzvd.VIDEO_IMAGE_DISPLAY_TYPE_ORIGINAL);
    }


Add code coverage workflow.

What does this PR do?
This PR adds a new workflow file to generate code coverage reports and upload the results to codecov. Once the first report is uploaded each PR will have a comment showing the diff with the previous state. The diff will present changes in the following components:

crashtracker
data-pipeline
data-pipeline-ffi
ddcommon
ddcommon-ffi
ddtelemetry
ipc
profiling
profiling-ffi
serverless
sidecar
sidecar-ffi
spawn_worker
trace-mini-agent
trace-normalization
trace-obfuscation
trace-protobuf
trace-utils

Welcome to Codecov :tada:
Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.
Thanks for integrating Codecov - We've got you covered :open_umbrella:


Registered version is very old

Version in Package.toml: 1.0.0
In General: 0.1.0
Can it be updated there?

I was hoping to land https://github.com/JuliaEcosystem/PackageAnalyzer.jl/pull/71 in the same release, but we could just mark that as 2.0 I guess. Review there would help move it along!

1.0 is out!


Added ability to add rules when creating linter

New rules can be added following the:
var Linter = require('ramllint'),
  ramllint = new Linter({
    resource: {
      hint: '/income-tax-documents (good)\n/incomeTaxDocuments (bad)\n/Income_Tax_Documents (bad)',
      id: 'url_format',
      prop: 'relativeUri',
      test: '^\\/([a-z]+(-[a-z]+)*|{[a-z]+([A-Z][a-z]+)*})$',
      text: 'RAML section ({section}) {property} violates: only lowercase letters and dashes allowed. URI Params must be camel cased.'
    }
  });

Updated release tag to 1.2.3
Adding a rule in the same section with a default rule with a matching id replaces
the default rule.

Let me think about this for a little bit. The reason being that the original goal was to allow customization in a single external file (.ramllintrc) similar to ESLint or JSHint. Your change don't seem like a bad idea to possibly allow also however.

Also I should mention that a Version 2 re-write has been nearly finished up and might change the amount of effort you want to put into this version. But since I haven't been back to work on this in a little while now this may be port-able work.

I'd be happy to work on the port to version 2 - I'll look into a PR for that branch. I like where this is going and it definitely addresses a need we have. Is your intention to not do any more releases before version 2? Do you have a doc describing your goals for v2?

I don't have a doc explaining the goals of version 2 but there is a milestone with issues assigned to it. I think it is mostly complete at this point I just haven't had time to do extensive testing.
Thank you for your interest and participation in the project. Sorry I haven't been better at responding lately; priorities have changed a little at work and my focus has been elsewhere. I will try and be better.


Add dependency-plugin-check to build

Add plugin to build that checks the usage of all depended maven plugins if they are still available and if there is a new version available

https://www.versioneye.com


Book page 85 missing code

This code is in cell [22] of the notebook but does not appear on page 85 of the book.
y_train_perfect_predictions = y_train_5
@ageron What is the best way to let you know of items such as this one? I am going through the book in a very methodical, slow manner; hence, I might find things that you might want to know about.

There is one errata page mentioned at book URL page. This one is already
mentioned there.
Check
http://www.oreilly.com/catalog/errata.csp?isbn=0636920052289
On 5 Jun 2017 11:27 p.m., "Julian"<EMAIL_ADDRESS>wrote:

This code is in cell [22] of the notebook but does not appear on page 85
of the book.
y_train_perfect_predictions = y_train_5
@ageron https://github.com/ageron What is the best way to let you know
of items such as this one? I am going through the book in a very
methodical, slow manner; hence, I might find things that you might want to
know about.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/ageron/handson-ml/issues/31, or mute the thread
https://github.com/notifications/unsubscribe-auth/AE1laxKumwlSrcO-rvA2UeJS8JzkUYQEks5sBEGRgaJpZM4NwXQz
.

@Praveen-Gupta OK. Thank you. I will report "errors" I find in the book to the book's page at O'Reilly.

Thanks for your feedback @julianpraxis, and thanks @Praveen-Gupta for the helpful link.
For problems concerning the notebooks, filing a GitHub issue is the best option.  For problems concerning the book, then the errata page that Praveen pointed to is the best option.
You'll find lots of content in the notebook that does not appear in the book. In general, it is on purpose, because the text explains something, and I want to keep the code as concise as possible, for readability. I understand that people may wonder where these "perfect predictions" come from, but if I write "y_train_perfect_predictions = y_train_5" I'm afraid other people may wonder why I'm writing this? The idea was that a perfect model, if you can train one, will give you a diagonal confusion matrix.
Hope this helps,
Aurélien


issue#50-config/boot

Database configuration of connection and boot strap connection

Added php file for accessing the database that is hosting the site.  Then added bootstrap.php which defines a constant for the project root path, includes configuration files, and imports essential controller and model files for a web application


Investigate findings requires slack signup

:tada: This PR is included in version 0.39.0 :tada:
The release is available on:

v0.39.0
GitHub release

Your semantic-release bot :package::rocket:


Supporting sparse semantic retrieval in neural search

Description
Support using sparse encoding model e.g. SPLADE in opensearch. We'll introduce a new sparse encoding doc ingest processor, and a new sparse encoding query clause.
related PR: https://github.com/opensearch-project/ml-commons/pull/1301
Issues Resolved
#230
Check List

[x] New functionality includes testing.

[x] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[x] Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Some integ tests fail because new sparse models in ml-commons are invoked, while the PR in ml-commons haven't been merged.

We have finalized our code, it is ready for review now

The force push aimed to fix DCO

As discussed earlier please the changes should be merged to the feature branch. https://github.com/opensearch-project/neural-search/tree/feature/sparseVectorSupport
Also, could please add the final proposal on the github.

As discussed earlier please the changes should be merged to the feature branch. https://github.com/opensearch-project/neural-search/tree/feature/sparseVectorSupport
Also, could please add the final proposal on the github.

Sure, we'll add our final proposal. Do we need a feature branch? All our works are ensembled in this branch, and I think this is same with creating another branch and sync all commits to it

@zhichao-aws as this is a new feature, hence I don't want to put this change in main before everything is completed. I mentioned the same in the old PR and github issue.
https://github.com/opensearch-project/neural-search/issues/260#issuecomment-1689339940

@zhichao-aws add the entry in the change log about what this change is about.

Also I see the build gradle checks getting failed. Lets make sure that everything is fixed.

Also I see the build gradle checks getting failed. Lets make sure that everything is fixed.

The integ test failed because it depends on the PR in ml-commons, as we use the new ml functions. We can re-run the build after https://github.com/opensearch-project/ml-commons/pull/1301 get merged.

@zhichao-aws can we add documentation on all the public classes and functions.

@zhichao-aws can we add documentation on all the public classes and functions.

Sure


wondering if it makes sense to give the area widget controls more z-index

The issue I'm trying to solve for is when you have a widget that with editing controls that would always be obscured by the Apostrophe menu button or the page menu button. In my specific case, it was the footer:

Without this change, it's basically impossible to edit my footer content.
The change does mean that as you scroll by widget controls will hover over the Apostrophe menu button. This might be something we don't like:

Not sure if this is the best solution, but I think we should figure out a way to make this work that doesn't require doing area/widget specific overrides in the project level

I'm all for a solution that gets away from project level overrides or positioning of controls.
This might be a separate concern, but sometimes i think it would be valuable to remove trash/drag and drop controls as well for globally scoped widgets that are mission critical like the header or footer (i.e. widgets you would never want to delete and in some cases may influence the page tree). I see this as potentially a configuration option in index.js.

Thanks @austinstarin, I would agree that your other concern makes a lot of sense to consider as a separate issue.

I think that this change makes sense based on the other control hovering behavior but imaging project-level changes for things like marquees will always be a concern.
To @austinstarin's other point, a big ++ on that. I often want to remove drag controls from very specific widget configurations where it wouldn't make sense to drag something like a specialized headline or image out a card and into a general area widget.


Add support for Ruby 2.7

Add support for Ruby 2.7 both in Travis and in Grape itself

Ruby 2.7.0 was released December 25, 2019, and has some noisy deprecation messages about wrong usage of keyword arguments.
Grape gem already correctly uses double-splat operator in some places, but not all over the code-base. That must be fixed.
So, what's done here:

Add Ruby 2.7 to Travis matrix, use 2.6.x for Gemfile and rails 5 as it's already done for previous versions.
Fix method signatures and calls that produce deprecation messages for kwargs used.

To see a ton of deprecation messages you can just install Ruby 2.7, checkout current master branch and run test suite. There are still some messages not related to the gem itself that comes from mustermann, multi_json and a few other gems that must be fixed themselves.

Is there any plan to release a gem version that supports ruby2.7 (i.e. with the ruby27 fixes above)?

Is there any plan to release a gem version that supports ruby2.7 (i.e. with the ruby27 fixes above)?

Yes, but at the very least we need to check #1957. Maybe you can help?

https://github.com/ruby-grape/grape/issues/1958


Linkage 'Z' uses the same cluster more than once

Seems to happen a lot?
Traceback (most recent call last):
  File "/Users/chuck/anaconda3/envs/dash/lib/python3.6/site-packages/flask/app.py", line 1982, in wsgi_app
    response = self.full_dispatch_request()
  File "/Users/chuck/anaconda3/envs/dash/lib/python3.6/site-packages/flask/app.py", line 1614, in full_dispatch_request
    rv = self.handle_user_exception(e)
  File "/Users/chuck/anaconda3/envs/dash/lib/python3.6/site-packages/flask/app.py", line 1517, in handle_user_exception
    reraise(exc_type, exc_value, tb)
  File "/Users/chuck/anaconda3/envs/dash/lib/python3.6/site-packages/flask/_compat.py", line 33, in reraise
    raise value
  File "/Users/chuck/anaconda3/envs/dash/lib/python3.6/site-packages/flask/app.py", line 1612, in full_dispatch_request
    rv = self.dispatch_request()
  File "/Users/chuck/anaconda3/envs/dash/lib/python3.6/site-packages/flask/app.py", line 1598, in dispatch_request
    return self.view_functions[rule.endpoint](**req.view_args)
  File "/Users/chuck/anaconda3/envs/dash/lib/python3.6/site-packages/dash/dash.py", line 541, in dispatch
    return self.callback_map[target_id]['callback'](*args)
  File "/Users/chuck/anaconda3/envs/dash/lib/python3.6/site-packages/dash/dash.py", line 498, in add_context
    output_value = func(*args, **kwargs)
  File "/Users/chuck/github/refinery-platform/heatmap-scatter-dash/context/app/app_callbacks.py", line 80, in _update_heatmap
    cluster_cols=self._cluster_cols)
  File "/Users/chuck/github/refinery-platform/heatmap-scatter-dash/context/app/utils/cluster.py", line 30, in cluster
    col_label_order = _order_rows(dataframe.T, cluster_cols)
  File "/Users/chuck/github/refinery-platform/heatmap-scatter-dash/context/app/utils/cluster.py", line 11, in _order_rows
    rows_order = leaves_list(rows_linkage).tolist()
  File "/Users/chuck/anaconda3/envs/dash/lib/python3.6/site-packages/scipy/cluster/hierarchy.py", line 1711, in leaves_list
    is_valid_linkage(Z, throw=True, name='Z')
  File "/Users/chuck/anaconda3/envs/dash/lib/python3.6/site-packages/scipy/cluster/hierarchy.py", line 1421, in is_valid_linkage
    % name_str)
ValueError: Linkage 'Z' uses the same cluster more than once.

Have not seen this recently... closing for now, but feel free to reopen.


Send cancellation

Provide a way for send notifications tasks to be cancelled.

How would this be used, and where would you want to cancel it?
Shouldn't it be enough to send the celery AsyncResult from send_push_notification?

I need this feature to stop currently executing pushy tasks from the admin... if the notification started sending to all devices, some custom action on the admin interface to cancel (revoke) the sending process would be a nice to have feature.
http://docs.celeryproject.org/en/latest/userguide/workers.html#revoking-multiple-tasks


Supporting smaller memory pages

This came up as a discussion at Devcon 4. I think the problem was mentioned by @poemm.
Wasm has a fixed memory page size of 64kb of which a single page is always required due to the nature how the EEI works. This means every single contract on every invocation will use at least 64kb of memory. Most of the time contracts don't actually need that much memory.
It would be a bad idea to fork the wasm spec (resulting in an incompatible ewasm) or silently change VMs used in Ethereum clients to consider the memory page of smaller size (resulting in an incompatible VM).
I propose a way around this: introduce a custom section, which declares the page size. This has one restriction: the declared page size cannot exceed 64kb.
With this restriction in mind the wasm bytecode is fully compatible with every VM, because in "worst" (default) case, it will execute with 64kb page size.
When a VM understands this custom section, it can reduce the page size. If this proposal is accepted, we'd define a fixed page size in ewasm spec (probably something like 4kb or 8kb).
Analysis tools could use this custom section to validate that contracts do not overread memory. Though in the case they do, they would just stop (with all gas consumed) due to bounds read - which they can do today anyhow.

Considering logistics, what changes to existing VM implementations would
this require?
On Tue, Nov 20, 2018, 11:57 Alex Beregszaszi<EMAIL_ADDRESS>wrote:

This came up as a discussion at Devcon 4. I think the problem was
mentioned by @poemm https://github.com/poemm.
Wasm has a fixed memory page size of 64kb of which a single page is always
required due to the nature how the EEI works. This means every single
contract on every invocation will use at least 64kb of memory. Most of the
time contracts don't actually need that much memory.
It would be a bad idea to fork the wasm spec (resulting in an incompatible
ewasm) or silently change VMs used in Ethereum clients to consider the
memory page of smaller size (resulting in an incompatible VM).
I propose a way around this: introduce a custom section, which declares
the page size. This has one restriction: the declared page size cannot
exceed 64kb.
With this restriction in mind the wasm bytecode is fully compatible with
every VM, because in "worst" (default) case, it will execute with 64kb page
size.
When a VM understands this custom section, it can reduce the page size. If
this proposal is accepted, we'd define a fixed page size in ewasm spec
(probably something like 4kb or 8kb).
Analysis tools could use this custom section to validate that contracts do
not overread memory. Though in the case they do, they would just stop (with
all gas consumed) due to bounds read - which they can do today anyhow.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/ewasm/design/issues/161, or mute the thread
https://github.com/notifications/unsubscribe-auth/AHEQh6LQrUdt1O-6W59U3w-wqhLgwUa7ks5uxDSRgaJpZM4Yrh-m
.

Considering logistics, what changes to existing VM implementations would
this require?

You wouldn't change a general VM to do this.  A specialised VM in a consensus client would have extra piece of code to check the custom section and consider pages accordingly.  I think in a well design VM changing the page size shouldn't be more than a few lines.

What would happen with memory.grow and memory.size? Will they still operate (return / receive) on 64k pages?

I think in a well design VM changing the page size shouldn't be more than a few lines.

But this still will entail forking a VM, right?

A summary of what I understand so far: a 64 kb area is used once and for all, and every time a contract ends the amount of data that it declared in its custom section is being zeroed out. If you don't re-use the same area, then you need an allocation and zeroing it out would cost less ( on top of that, most of that page would definitely be in the cache anyway given the short execution time of contracts).
If my assumption is correct then:

it is easy to check if the contract called memory.grow by reading the final size of the memory and charging all gas if that happens.
it is always possible to write beyond the promised boundary. To check that without forking the interpreter(s), we need to scan the entire 64k anyway, thus incurring a cost similar to zeroing it out (remember, CPU caching is as play).

So I'm just wondering if we should bother doing this at all ?

IMO, I don't think that it is worth a hastle.
First, I do think that this is effectively forking of the specification. The specification states that memory instance size is always multiple of 64kb. The immediate effect that memory.size, memory.grow operate on multiples of that size. For example, the platform-dependent code, allocators in particular, already depend on this kind of invariant. So such kind of change would introduce fragmentation to the space, would force the developer audit all dependencies on the fact of compatibility with ewasm and so on.
On the other hand, I don't really think that using 64kb memories is much of a problem. This is a negligable small amount for the current hardware, processing of contracts is not massively parallel (so you probably won't have much more than a single memory instance at a time).

WebAssembly was designed for web apps where run-time dominates set-up time (including zeroing memory). Unfortunately, benchmarks show that many ewasm contracts are dominated by set-up costs.
Since this discussion is about memory, a quick laptop benchmark shows that it takes 10ms to zero 50 64kB pages. So an upper bound on a 200ms block is 500 pages, not counting contract runtime. This hinders scaling goals.
64kB pages are big and awkward. Most OSs use 4kB pages. 1kB would be reasonable for smart contracts. @ehildenb also mentioned curiosity about smaller page sizes, like 1kB or 512 B.
A quick look shows that many implementations set page size as a variable. Of course, an audit is needed before changing this variable.
Firefox: https://hg.mozilla.org/mozilla-central/file/tip/js/src/wasm/WasmTypes.h#l2260
Chromium: https://github.com/v8/v8/blob/fd334b3216488011b368ec4652819e08c38d0d36/src/wasm/wasm-constants.h#L77
I agree that deviating from the Wasm spec presents new problems. But ignoring benchmarks and major bottlenecks presents problems too. So I consider this a major design decision.

Note, that I don't argue that changing the page size constant will be hard (indeed, I would expect that this would be just a constant in most implementation), just that it would introduce some fragmentation.

Since this discussion is about memory, a quick laptop benchmark shows that it takes 10ms to zero 50 64kB pages. So an upper bound on a 200ms block is 500 pages, not counting contract runtime. This hinders scaling goals.

This one implies clearing pages upfront and at once. I was under impression that this could be easily solved by some techniques. The simplest one would be doing it lazily, on the first access to the physical (well, physical as in virtual memory : ) ) page. Do you see any problems with doing that?

This one implies clearing pages upfront and at once. I was under impression that this could be easily solved by some techniques. The simplest one would be doing it lazily, on the first access to the physical (well, physical as in virtual memory : ) ) page. Do you see any problems with doing that?

Not sure how to answer your question without telling the rest of the story.
This problem is not just about page size. For ewasm contracts, set-up time (instantiation including parsing, memory allocation, importing, etc) often dominates run-time. A possible solution: maintain instantiated contracts which are ready to call, and, at each call, zero the memory and globals.
Some possibilities follow to handle memory between calls.

Deviate from the spec and free memory after each call and allocate new pages at each call.
Deviate from the spec and shrink the memory back to the original size after each call.
Disallow memory.grow and allow each precompile to maintain some bounded amount of memory across calls.

In any case, smaller page size is better. Smaller pages also improve the zero-ing bottleneck.
Please correct me if I am missing something.

The simplest one would be doing it lazily, on the first access to the physical (well, physical as in virtual memory : ) ) page. Do you see any problems with doing that?

Having access to physical memory. Not hard to do with a dedicated driver; I think it would be overkill to save 100ms every 50 contract executions.

Some possibilities follow to handle memory between calls.
1. Deviate from the spec and free memory after each call and allocate new pages at each call.

2. Deviate from the spec and shrink the memory back to the original size after each call.

3. Disallow memory.grow and allow each precompile to maintain some bounded amount of memory across calls.

Like I said above, you can also not change the spec and punish any call to memory.grow with claiming all of the account's fund. Then zero-out a 64k page and reset the stack.

The simplest one would be doing it lazily, on the first access to the physical (well, physical as in virtual memory : ) ) page. Do you see any problems with doing that?

Having access to the page table. Not hard to do with a dedicated driver; I think it would be overkill to save 100ms every 50 contract executions.

You don't need that, you can just use calloc which internally tells the OS to lazily zero the pages. Rust does this already with vec![0; n].

How is the calloc going to detect the first access to a page to zero it out?

Because it's implemented with magic in the OS.

ah, magic ok ;)

https://stackoverflow.com/questions/2688466/why-mallocmemset-is-slower-than-calloc

@Vurich I am pretty sure calloc initializes memory up front. It would be lazily called by the VM upon memory access.

I depends on the OS and the libc, But even if most Unices tend to allocate the VM with invalid references and wait for a page fault to fill it with a zeroed-out page, it means that you have underlying allocations which is the opposite of what is being sought.

https://stackoverflow.com/questions/2688466/why-mallocmemset-is-slower-than-calloc

Accordingly, the calloc is faster in that contrived example, because the issue creator doesn't write to memory. I would expect results to be much less impressive if they had written something.

A possible solution: maintain instantiated contracts which are ready to call, and, at each call, zero the memory and globals.

I'm not sure that I follow you here. Do you mean pre-instantiate wasm modules and then keep them in memory in hope that they will be reused at some time?

Smaller pages also improve the zero-ing bottleneck.

But this also implies zeroing wasm pages at once upfront, whether I'm saying that it may be possible to zero each page on the first access.

Having access to the page table. Not hard to do with a dedicated driver;

Well, you don't need a direct access to the page table. As was mentioned before, calloc should do, although I was thinking about catching page faults in a signal handler (since most wasm engines would  contain such a mechanism anyway implementing bound checking).

Accordingly, the calloc is faster in that contrived example, because the issue creator doesn't write to memory. I would expect results to be much less impressive if they had written something.

Yeah, right. But we are not talking about avoiding this cost altogether (since zeroing should happen anyway), but doing this lazily thus distributing cold start cost by running time. Changing the page size to something lower will not avoid this cost altogether as well.

edit: also rust doesn't use anything other than jemalloc unless you explicitly use another allocator.

@jakelang Nit: that's not true in latest versions of rustc : p

I was thinking about catching page faults in a signal handler (since most wasm engines would contain such a mechanism anyway implementing bound checking).

That would make sense yet none of the engines I have looked at do. Though it should be easy to implement.

Changing the page size to something lower will not avoid this cost altogether as well.

I agree. In fact, depending on the allocator, it would tend to increase the amount of page faults thereby slowing the whole thing down.

It would be a bad idea to fork the wasm spec (resulting in an incompatible ewasm)

I'd like to revisit this assumption. A lot of the ideas being discussed in this thread involve deviating from the Wasm spec in one way or another, e.g.:

Deviate from the spec and free memory after each call and allocate new pages at each call.

Deviate from the spec and shrink the memory back to the original size after each call.

Disallow memory.grow and allow each precompile to maintain some bounded amount of memory across calls.

Why is forking the spec necessarily a bad thing? Especially if there are inherent incompatibilities between it and our use case, e.g.:

64kB pages are big and awkward. Most OSs use 4kB pages. 1kB would be reasonable for smart contracts. @ehildenb also mentioned curiosity about smaller page sizes, like 1kB or 512 B.

and

For ewasm contracts, set-up time (instantiation including parsing, memory allocation, importing, etc) often dominates run-time

Wasm obviously wasn't designed for resource-constrained, deterministic, on-chain computation. Maybe we shouldn't be afraid to deviate from the reference spec, although of course we would want to consider and discuss the implications.

TBH, I don't fully understand the idea.

This problem is not just about page size. For ewasm contracts, set-up time (instantiation including parsing, memory allocation, importing, etc) often dominates run-time. A possible solution: maintain instantiated contracts which are ready to call, and, at each call, zero the memory and globals.
Some possibilities follow to handle memory between calls.

I assume that ethereum call is meant here.
I also assume that this talk is mostly about precompiles. Then holding these wasm instances in memory makes more sense, although IMO this won't work for smart-contracts.

Deviate from the spec and free memory after each call and allocate new pages at each call.
Deviate from the spec and shrink the memory back to the original size after each call.

Assuming I get the idea right, then I'm not sure how is this deviating from the spec. These cases can be implemented as instantiating a module once and then using it as a prototype for either efficient cloning or CoW (again, vmem tricks, map memory to the initial instance as long as it's not changed. Copy or zero memory depending on the dirtiness of the page in the prototype instance on the write attempt).
From the spec perspective this can be seen just as copying store contents.

Disallow memory.grow and allow each precompile to maintain some bounded amount of memory across calls.

BTW, this doesn't require disallowing memory.grow explicitly. The same can be achieved via putting limitations on memory imported by the precompile.


TVIRoom number of remote participants is always 0

Before filing an issue please check that the issue is not already addressed by the following:

Video Guides
Changelog.

If this is an issue with the QuickStart itself, file it here. If this is an issue with the SDK or how to do something with the SDK please use twilio-video-ios instead.
Please ensure that you are not sharing any
Personally Identifiable Information(PII)
or sensitive account information (API keys, credentials, etc.) when reporting an issue.

Description
[Description of the issue]
Steps to Reproduce

User 1 connects to RoomA
User 2 connects to RoomA
participantDidConnect not called

Code
let connectOptions = TVIConnectOptions.init(token: payload.twilioAccessToken) { (builder) in
    builder.roomName = payload.roomName
}
twilioLog("Will Connect to room with name \(String(describing: payload.roomName))")

self.room = TwilioVideo.connect(with: connectOptions, delegate:self)```

#### Expected Behavior

participantDidConnect called when the second participants joins
#### Actual Behavior

`participantDidConnect` not called
Even room.remoteParticipants returns 0

#### Reproduces How Often

100%

### Versions

#### Video iOS SDK

[e.g. 1.3.12 via CocoaPods]
- TwilioVideo (2.5.3) Cocoapods
#### Xcode

10.1

#### iOS Version
12.1

#### iOS Device

iPhone X,
iPhone 6S

Hi @wassimseif,
This is a pretty fundamental feature of our Video platform which should work as you describe.
First, you should double check that User 1 and User 2 both didConnectToRoom: events.
Second, note that the identity of each Participant must be unique (recently asked, see https://github.com/twilio/video-quickstart-swift/issues/330), so you should double check that each user gets a token with a unique identity.
If you are not using unique identities, then when User 2 joins, User 1 will be disconnected due to a duplicate identity error.
Regards,
Chris

Hey,
Thanks for the reply. Yes I do understand that this is one of the main features of Twilio Video & most probably I'm doing something wrong.
To double check, this is exactly the flow I'm doing  :

The backend generates a room Id & creates the room using your REST API
The backend generates 2 Acces tokens ( using your REST APIs) & add Video Grants to these tokens
User A gets one of the unique tokens & the generated room ID ( question: Do i connect to room using the room name I generated OR the sid I got back from your create room REST API ?)
User A connects to the room & the didConnectToRoom is called
After a delay of 10 secs, User B gets the other access token & the generated room name
User B connects to room & the didConnectToRoom is called

What I think should happen is that the room:participantDidConnect: delegate implemented on User A should be called notifying him that User B connected to the room, however, it's not called
Also .After a sometime ( 1-2min ) I launch the debugger on User A & print out the number of remoteParticipants in the room but it's always 0.

Hey I'm facing same issue please help me

Hey @MakwanaRohit ,
I got my problem solved. The issue was that when creating the AccessToken from Twilio. You have to send a unique identifier for each token. We were sending a static string.

Closing, since the original request was resolved. @MakwanaRohit, please reopen if you are still having token issues.


Auto search (Search in Files) doesn't start automatically

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.71.2
OS Version: Windows 10

Steps to Reproduce:
The correct behavior:

Set the left tab to be on "Search in Files" tab.
Open a file in the editor.
Press Ctrl + Shift + F
The search process start automatically and immediatly.

The bug:

Set the left tab to be on any other tab which is not the "Search in Files" tab.
Open a file in the editor.
Press Ctrl + Shift + F
The "Search in Files" tab is shown, but it forces me to press the "Enter" key in order to start the search which is very annoying.

Why the search doesn't start automatically as it does when the "Search in Files" tab is already opened?
Thanks.

Maybe explained in #91901

Maybe explained in #91901

Thanks.
They talked about it and mentioned it, but it seems that this feature thah I mentioned here doesn't exist when the side view is not focused on the 'Search' view. The serach is auto triggered only when the 'Search' view is active, when you are on another view the Ctrl+Shift+F only take the word and out it in the serach field, but not trigger it.

@burekas7
I believe that the issue that was mentioned above (https://github.com/microsoft/vscode/issues/91901) talked about the conditions that would trigger a search automatically. But from what I see, you would like a setting that allows you to always trigger a search whenever toggling to the search tab?

@andreamah
Yes

@andreamah
By the way, I have noticed that when I'm using vscode version in Mac Pro it's acting as I described here so the search is triggered automatically no matter on which tab I was of the side menu, it seems that the problem is with the Windows version of vscode or some specific configuration that I have in my Windows version.
Why is that?

it seems that the problem is with the Windows version of vscode or some specific configuration that I have in my Windows version

Do you have "search.seedWithNearestWord": true set on your Mac? Taking a closer look at this, it seems that it's like behavior for running CTRL+SHIFT+F is:

Focusing on the search tab and performing a search when you have new text (by default, this only sets new text when you have something highlighted)
Only focusing on the search tab if you're not introducing any new text.

Setting "search.seedWithNearestWord": true causes search to always run because it sets the search text with the nearest word, even when you don't have something highlighted.

@andreamah
So it seems that in Windows the "search.seedWithNearestWord": true option doesn't cause search to run, it only sets the search text without triggering when the search tab isn't activated.
Windows and Mac have the same settings.json file, and both have this setting enabled:
"search.seedWithNearestWord": true
On Windows when doing the CTRL+SHIFT+F command

When the search bar is not selected: It only set the search text without triggering.
When the search bar is selected before: It set the search text and triggering.

On Mac when doing the CMD+SHIFT+F command:

When the search bar is not selected: It set the search text and triggering.
When the search bar is selected before: It set the search text and triggering.

What other search settings do you have on your windows machine? I can't seem to repro that. Also, which version of vscode are you running?

What other search settings do you have on your windows machine? I can't seem to repro that. Also, which version of vscode are you running?

These are the settings which related to the search in my settings.json:
(Same on both Windows and Mac)
  //=================================================
  //Search settings
  //=================================================
  "search.seedWithNearestWord": true,
  "search.seedOnFocus": true,
  "search.smartCase": true,
  //"search.useIgnoreFiles": true,
  "search.exclude": {
    "**/node_modules": true,
    "**/bower_components": true,
    "**/*.code-search": true
  },

When you say "when the search bar is not selected", what do you mean? Does this mean that it's not on the search tab?

@andreamah
Exactly.

@andreamah
Exactly.
While the search bar is already opened the search start automatically,
While it isn't, it changes to the search bar with the correct text for searching that I stand on it, but unless I press the Enter key the search doesn't start.

What is an example of when the search bar is not opened? can you take a screenshot or screen gif of the issue? I think I'm having trouble understanding the exact situation where the search doesn't start automatically.

@andreamah
I record a short video that describe the issue:
https://www.veed.io/view/f35d1b08-3b92-422a-bae3-ec261acf4d16?panel=share
In the video you can see the side bar on each case as I described above.
Hope it will be more clear now.

I'm trying out the same flow as you and am getting different results (I also pasted in the settings that you shared):

Am I taking the right steps to try to replicate the bug?

@andreamah
Yes, it seems so.
Is there any other guess what kind of other settings or keybinding that can interrupt this on my Windows version?
Look at this:

@andreamah
Yes.
This was the problem, I update the "When" of the extension to be the same as default and now it works:

I don't know why they set it with this condition: && !searchViewletVisible


[Question] Behavior of CosmosClient when httpClientFactory isn't provided during CosmosClient object creation

SDK version: 3.31.0
ConnectionMode: Direct
I am creating CosmosClient like this:
new CosmosClient (
  accountEndpoint
  authKeyOrResourceToken,
  clientOptions: clientOptions);

My clientOptions doesn't provide HttpClientFactory.
According to this line of CosmosHttpClientCore, my cosmosdbClient object will get httpclient created like this:
HttpClient httpClient = new HttpClient(httpMessageHandler);

Does it mean that if my cosmosClient is singleton, it will run into the well known problem A Singleton HttpClient does not respect DNS changes?

Can you clarify exactly what problem in that thread applies to Cosmos DB or what exactly is the known problem (the thread is very long and there are multiple points mentioned)? And if you have experienced it, can you share logs/exceptions?
Cosmos DB uses HTTP and TCP, HTTP is used for Gateway interaction (https://learn.microsoft.com/en-us/azure/cosmos-db/nosql/sdk-connection-modes). Gateway maintains one DNS entry for each available region which maps to a cluster of machines that can serve these requests. The DNS entry is not for a single machine. If a machine in the cluster has an issue, the IP is still valid.
In the event of a regional outage, the IP cannot be connected to, this translates to an HttpRequestException https://github.com/Azure/azure-cosmos-dotnet-v3/blob/master/docs/SdkDesign.md#cross-region-retries, which gets retried and handled. The account endpoints are rediscovered in case new regions were added/removed and the client attempts to connect to the next region.
We have not had any reports of any DNS caching affecting availability based on the service architecture as far as I can recall, and the pattern of having a Singleton client (with a singleton HttpClient) has been there for the past 7+ years.
Please let us know what specific concerns you have and I'll try to clarify.

Tracking investigation through https://github.com/Azure/azure-cosmos-dotnet-v3/issues/3658


Call compodoc binary directly without node

Fix #1961

Won't this not work on Windows? For instance there was recently an issue about webdriver-start not working on Windows's shell because the ./ syntax was invalid, so it was changed to be called with node.
I'm sure @mgechev remembers as it was very recent.

Just made the test for compodoc on Windows 10, Node.js 6.10 and it works fine. It was for that i submit this pull-request.


An error occurred while processing long audio using the provided pretrained model.

audio duration: 23s
error:
File "CodeTalker/main/demo.py", line 187, in test
prediction = model.predict(audio_feature, template, one_hot)
File "CodeTalker/models/stage2.py", line 133, in predict
feat_out = self.transformer_decoder(vertice_input, hidden_states, tgt_mask=tgt_mask, memory_mask=memory_mask)
File "/anaconda3/envs/pytorch/lib/python3.6/site-packages/torch/nn/functional.py", line 5016, in multi_head_attention_forward
raise RuntimeError(f"The shape of the 3D attn_mask is {attn_mask.shape}, but should be {correct_3d_size}.")
RuntimeError: The shape of the 3D attn_mask is torch.Size([4, 600, 600]), but should be (4, 601, 601).

I encountered the same error

Hi, I think the reason for this error is the pre-defined max_seq_len in models.utils.py, and you may change it into a larger number. But I am not sure about the performance in this case (longer audio), thanks for sharing some experience here😃.

Thanks for your reply. I take a try.

@Owen1234560 have you solved this problem? my set is like this:
def __init__(self, d_model, dropout=0.1, period=25, max_seq_len=60000)
then I trained on this set in s1 and s2. however, it also can only process 10 seconds long audio, and will raise error in 20 seconds and longer

@aurelianocyp You may also modify L27 in models.stage2.py self.biased_mask = init_biased_mask(n_head = 4, max_seq_len = 600, period=args.period), by setting max_seq_len accordingly.


fix: Bugcrowd API Import uses legacy dedupe instead of unique id from tool

Fixes https://github.com/DefectDojo/django-DefectDojo/issues/8993 (I think, but parser name and scan type names are confusing/not aligned...)

@Gby56
Thanks for the contribution. Please make PRs against the dev branch, not master.
For details see: https://github.com/DefectDojo/django-DefectDojo/blob/master/readme-docs/CONTRIBUTING.md

Woops sorry I forgot ! Done

Could this PR make it in 2.28.2 btw ?


fix(type-def): expose the type definitions of all exported artifacts

:tada: This PR is included in version 4.0.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


How to remove navbar-default & navbar-inverse?

How to remove navbar-default & navbar-inverse class from navbar? Use case: bootstrap material design navbar custom color. Thanks

Can you elaborate? The navbar always has either the navbar-default or
navbar-inverse class in all 3.x versions AFAIK.
Why would that prevent you from setting a custom color?
On 27 January 2015 at 05:55, Gia<EMAIL_ADDRESS>wrote:

How to remove navbar-default & navbar-inverse class from navbar? Use case:
bootstrap material design navbar custom color. Thanks
—
Reply to this email directly or view it on GitHub
https://github.com/bootstrap-ruby/bootstrap-navbar/issues/8.

Closing due to inactivity...


PR template update: please add to changelog

Added a line to the PR template about adding something to CHANGELOG

Coverage remained the same at 75.385% when pulling 11e133555d80988185f36b758b38aadacd2d1bdc on pr-template-2 into 42f686e710acfadb93dc9325ce302b34089cd49c on development.

Good point, updated the PR.

Would it make sense to add a checklist to the template instead of a series of Y/N questions?

I think it would. Updated the PR


[CLI] api.sweep broken for large sweeps (read timeout)

Description
When running api.sweep with "large" sweeps (actually not that large, just around 180 runs), this error appears:
CommError: HTTPSConnectionPool(host='api.wandb.ai', port=443): Read timed out. (read timeout=9)

I've realized that it also crashes when pressing the download icon in the wandb app, in the table view.
Wandb features
Just using the Python wanb api.
How to reproduce
2 ways:

execute sweep = api.sweep("stardust-r/deep-learning-space-weather-forecasting/inztzkl4")
go to  the sweep in the app (https://wandb.ai/stardust-r/deep-learning-space-weather-forecasting/sweeps/inztzkl4?workspace=user-ecstevenson) and try to download the sweep table.

Environment

OS: Ubuntu 20.04
Environment: Jupyter Notebooks & docker
Python Version: 3.8.5
Wandb version: We've tried the multiple versions, including the most recent 0.10.19

Hey @vrodriguezf , thanks for reporting the issue. I'm trying to reproduce it through the UI right now, but it's downloading just fine for me. You're talking about this download button, and then exporting it as csv, right?

I visualized all columns, to put max strain on it, but it still downloads just fine for me.
Are you using a VPN or something similar?

Thank you for your help @tyomhak . I'm just interested in the run id column, but when I press the download button it takes ages. It's weird that it works for you! I'm not using a VPN, if I take sweeps with less runs it works good.

I have tried again, and now it's definitely not "snappy" for me either. We'll look into this, and see if we can improve the performance. Thanks for reporting! :) will let you know if we have updates.

Thanks! We've been recommended to log less things in each run, we'll try that as well to see if it alleviates the issue

Hi @vrodriguezf, this should now be fixed. Please let us know if you're still experiencing issues.


Detect data nondeterminism and warn in both the log and UX

Right now, if you write a test where the RPC messages are susceptible to data nondeterminism, when we try to inject a fault for those RPCs, we will not actually inject the fault.  To solve the problem, the developer needs to set the dataNondeterminism = true option in the test annotation which alters the search algorithm to deal with this.
However, developers using Filibuster may be unaware that their code contains data nondeterminism.  Therefore, we should warn the developer if we tried to inject faults that we couldn't.  Right now, in the test reporting there is some code that finds places where the RPCs we tried to inject faults on doesn't match the RPCs we observed in the exception.  We should use this information to warn the developer about this and recommend that the data nondeterminism option is used.

Let's resurrect this one.  Can we talk about how to proceed here?


CNCF Website Guidelines Checklist

As per the CNCF Website Guidelines:

[x] 1. Website should be hosted in an open source repo

[x] Hosted in the same organization as the main project

[ ] 2. Reference the origin company correctly
Note: It is OK to say that, e.g., “Prometheus was originally created by Soundcloud” or “Kubernetes builds upon 15 years of experience of running production workloads at Google,” but the origin company should not otherwise be referred to on the project homepage.
[ ] 3. No links or forms for capturing enterprise support leads present.
It is fine to have an enterprise support, commercial partners or similar page.

[ ] If page is present, the companies list is alphabetized or randomized on load.
[ ] If page is present, the vetting of companies listed is complete
Note: Projects are welcome to outsource this vetting to CNCF staff if it becomes a burden.

[ ] 4. Links to companies offering support go to a page that at least mentions support of the project
[ ] 5. Copyright notice present at bottom of page.
Copyright to the project authors or to CNCF, not the origin company.
[ ] 6. CNCF Branding elements

[ ] “We are a Cloud Native Computing Foundation project.” or “We are a Cloud Native Computing Foundation sandbox project.” present (depending on status)
[ ] CNCF logo near the bottom of their project homepage
[ ] (optional) link to KubeCon + CloudNativeCon as the events approach

[ ] 7. Footer contains:
"Copyright The Linux Foundation. All rights reserved. The Linux Foundation has registered trademarks and uses trademarks. For a list of trademarks of The Linux Foundation, please see our Trademark Usage page."

Some of these may not be applicable.


Fixed typo and wrapped in localisation helper

Signed up to https://rfc.stitcher.io/ and noticed there was a small typo on the messages page.
Wrapped it in Laravel's localisation helper as well, hope that's ok!
Thanks. :)

Perfect, thanks!