Use of Libgroove in Volumio?

Hi Andrew,
My name is Steven Ning, I'm one of the developers for the Volumio project, a high fidelity audio system for Raspberry Pi and other tiny boxes (such as UDOO, BBB, etc).
Volumio currently uses a custom compiled version of MPD for playback of local audio files. There are a number of idiosyncrasies with MPD, however, and for the next version of Volumio, we're considering other player options such as Libgroove
I'm a fan of Groove Player, and am currently evaluating Libgroove as a replacement for MPD in Volumio 2.0. Is Libgroove able to perform bit perfect playback of high resolution audio files?
Thanks!

Hi Steven,
The use case you have outlined is a use case that libgroove wants to solve. It might take a couple patches to meet your "bit perfect" requirement but I'm willing to make that happen.
Let me understand the bit perfect requirement in detail with a few questions:

is the user able to modulate the volume? how does replay gain fit into the picture?
is the stream to the hardware playback device expected to change sample rates and bit rates when the song changes?

To explain that second one a bit more, let's say that the hardware playback device supports sample rates 48,000 and 96,000 and sample formats 24-bit integer and 32-bit integer. And now we have these songs queued up:

song 1, 24-bit integer 48,000 hz
song 2, 32-bit integer 192,000 hz

In the ideal scenario, libgroove would open a playback stream to the hardware with 24-bit integer, 48,000 hz, and play song 1. Then it closes the playback stream and opens a new one with 32-bit integer 96,000 sample rate and does DSP to resample the audio to fit the playback rate of the sound card.
Is that right?
Now, what happens when song 1 and song 2 are from the same album and they are supposed to have gapless playback? Closing the hardware playback stream and opening it again with different parameters would cause an audible glitch.
Would it be acceptable for libgroove to open the hardware playback device with sufficiently high quality parameters such as 32-bit integer and 96,000 Hz sample rate, and then resample all audio to fit that format?

The general goal is to render as precisely as possible the PCM data that an audio file encodes. If this is not possible, due to hardware limitation or user action (such as use of software mixer, replay gain, specified downsampling), Volumio would ideally notify the user.

This should be no problem. libgroove already exposes the target playback format and the actual playback format.

I think that the typical user does not use replaygain, and performs volume control at the hardware level to avoid the quality loss associated with PCM rescaling.

Let me propose what I think is a better strategy:
The music player applies a "pregain" to the output to make it quieter. This gives us headroom to turn up the volume without affecting quality. Next, we pre-scan all songs to figure out how loud they are. Finally, the music player adjusts this "pregain" volume up or down depending on how loud the song is, so that the user does not find themselves constantly adjusting the volume knob. If a song is very quiet and needs to be turned up past the pregain volume, there are 2 ways to resolve this: 1. use a dynamic compression filter (a big no-no if you're attempting for bit perfect playback) or 2. let the song play at full volume with no distortion, which the user might think is too quiet.
See this video for more details: Loudness Zen
PCM rescaling, especially at a sample format like 32-bit integer, is not something to be concerned about quality loss. However I suppose if the feature is "bit perfect playback" then it's easier to just have bit-for-bit playback than to convince people that actually that feature is kind of silly.
Anyway, that was just kind of a rant, because libgroove does not impose volume scaling on you; it is a feature that you may choose to use, or not, and if you choose not to use it, then the bits of audio are not affected and no extra CPU processing is used.

For gapless albums, most people rip the tracks in the same format.

Fair point.

As far as resampling goes, would it be through SoX or other library, or do you envision a custom algorithm?

Currently, libgroove depends on libavfilter for resampling.

If two songs with different sample rates or bitrates were played back to back, it would be most straightforward to open playback for each track at the format it specifies.

Alright, so here's the scoop with libgroove:
It's divided into 4 libraries, 2 of which are relevant to your use case.

libgroove (core)
libgrooveplayer
libgrooveloudness
libgroovefingerprinter

I'm confident that you will want to use libgroove with volumio and that it will suit your needs.
libgroove core provides a playlist interface where you put items on it and receive decoded audio buffers. You can specify that you want unmodified, untouched, un-volume-scaled, buffers.
The question here is whether you want to use libgrooveplayer or not. As is, libgrooveplayer is hard coded to open the hardware playback device with 44,100 hz, 16-bit integer, stereo. Obviously this needs to change for bit perfect playback. In addition, libgrooveplayer only opens the hardware playback stream once and leaves it open during playback. So this needs to be modified to close and open the hardware playback device with the exact correct playback parameters.
The only thing that makes this not completely straightforward is dealing with conditions where the hardware device cannot handle the playback parameters exactly. In this situation, we would have presumably been using the feature where audio buffers are not resampled at all in the audio graph, and so missed their chance to get resampled, and we find out too late that we do in fact need to resample because the audio device supports up to 96,000 and the audio file is 192,000.
This could be potentially solved with adding a core feature where instead of specifying only a single playback format, or specifying that you don't care what playback format it has, you could specify a set of rules to apply. So you encode your hardware device's capabilities into a set of rules and the core libgroove audio graph uses that to figure out whether it needs to do any resampling or not. (hopefully not, except in the case where the hardware device can't handle it).

The general goal is to render as precisely as possible the PCM data that an audio file encodes. If this is not possible, due to hardware limitation or user action (such as use of software mixer, replay gain, specified downsampling), Volumio would ideally notify the user.

This should be no problem. libgroove already exposes the target playback format and the actual playback format.

I think that the typical user does not use replaygain, and performs volume control at the hardware level to avoid the quality loss associated with PCM rescaling.

Let me propose what I think is a better strategy:
The music player applies a "pregain" to the output to make it quieter. This gives us headroom to turn up the volume without affecting quality. Next, we pre-scan all songs to figure out how loud they are. Finally, the music player adjusts this "pregain" volume up or down depending on how loud the song is, so that the user does not find themselves constantly adjusting the volume knob. If a song is very quiet and needs to be turned up past the pregain volume, there are 2 ways to resolve this: 1. use a dynamic compression filter (a big no-no if you're attempting for bit perfect playback) or 2. let the song play at full volume with no distortion, which the user might think is too quiet.
See this video for more details: Loudness Zen
PCM rescaling, especially at a sample format like 32-bit integer, is not something to be concerned about quality loss. However I suppose if the feature is "bit perfect playback" then it's easier to just have bit-for-bit playback than to convince people that actually that feature is kind of silly.
Anyway, that was just kind of a rant, because libgroove does not impose volume scaling on you; it is a feature that you may choose to use, or not, and if you choose not to use it, then the bits of audio are not affected and no extra CPU processing is used.

For gapless albums, most people rip the tracks in the same format.

Fair point.

As far as resampling goes, would it be through SoX or other library, or do you envision a custom algorithm?

Currently, libgroove depends on libavfilter for resampling.

If two songs with different sample rates or bitrates were played back to back, it would be most straightforward to open playback for each track at the format it specifies.

Alright, so here's the scoop with libgroove:
It's divided into 4 libraries, 2 of which are relevant to your use case.

libgroove (core)
libgrooveplayer
libgrooveloudness
libgroovefingerprinter

I'm confident that you will want to use libgroove with volumio and that it will suit your needs.
libgroove core provides a playlist interface where you put items on it and receive decoded audio buffers. You can specify that you want unmodified, untouched, un-volume-scaled, buffers.
The question here is whether you want to use libgrooveplayer or not. As is, libgrooveplayer is hard coded to open the hardware playback device with 44,100 hz, 16-bit integer, stereo. Obviously this needs to change for bit perfect playback. In addition, libgrooveplayer only opens the hardware playback stream once and leaves it open during playback. So this needs to be modified to close and open the hardware playback device with the exact correct playback parameters.
The only thing that makes this not completely straightforward is dealing with conditions where the hardware device cannot handle the playback parameters exactly. In this situation, we would have presumably been using the feature where audio buffers are not resampled at all in the audio graph, and so missed their chance to get resampled, and we find out too late that we do in fact need to resample because the audio device supports up to 96,000 and the audio file is 192,000.
This could be potentially solved with adding a core feature where instead of specifying only a single playback format, or specifying that you don't care what playback format it has, you could specify a set of rules to apply. So you encode your hardware device's capabilities into a set of rules and the core libgroove audio graph uses that to figure out whether it needs to do any resampling or not. (hopefully not, except in the case where the hardware device can't handle it).

The music player applies a "pregain" to the output to make it quieter. This gives us headroom to turn up the volume without affecting quality. Next, we pre-scan all songs to figure out how loud they are. Finally, the music player adjusts this "pregain" volume up or down depending on how loud the song is, so that the user does not find themselves constantly adjusting the volume knob. If a song is very quiet and needs to be turned up past the pregain volume, there are 2 ways to resolve this: 1. use a dynamic compression filter (a big no-no if you're attempting for bit perfect playback) or 2. let the song play at full volume with no distortion, which the user might think is too quiet.

Yes, I'm not opposed to the principle of automatic volume adjustment. However, in Volumio, there are two things we would have to fight:

The first is that the system is designed to be used with streaming services (Spotify, Soundcloud, Tidal, etc) in addition to local tracks. It might be tricky for libgroove to perform loudness scan in realtime on limited hardware such as Raspberry Pi. Furthermore, some of these music services would use their own audio renderer (libspotify, etc), for which we would need to impose separate loudness scanning further down the pipe. Otherwise you would have a loudness inconsistency between local tracks and streamed tracks.

The second has to do the the vagaries of human perception (or perhaps the human perception of perception). Many of our users build and test DACs, amplifiers, and speaker systems. Even if a track with replaygain applied is quantitatively identical to the untouched version, a user tweaking a high fidelity system is listening for something to pick on, and may well perceive the adjusted version to be subjectively inferior. We would like a renderer which serves as an unadjusted reference, which a user can be sure plays exactly what is advertised on the box. Then they can tweak the rest of their setup without worry.

I think it is fair to offer the option for replaygain scanning on local files or libgroove-rendered streams, but for the above reasons we would probably ship with it turned off by default.

The question here is whether you want to use libgrooveplayer or not. As is, libgrooveplayer is hard coded to open the hardware playback device with 44,100 hz, 16-bit integer, stereo. Obviously this needs to change for bit perfect playback. In addition, libgrooveplayer only opens the hardware playback stream once and leaves it open during playback. So this needs to be modified to close and open the hardware playback device with the exact correct playback parameters.

The only thing that makes this not completely straightforward is dealing with conditions where the hardware device cannot handle the playback parameters exactly. In this situation, we would have presumably been using the feature where audio buffers are not resampled at all in the audio graph, and so missed their chance to get resampled, and we find out too late that we do in fact need to resample because the audio device supports up to 96,000 and the audio file is 192,000.

This could be potentially solved with adding a core feature where instead of specifying only a single playback format, or specifying that you don't care what playback format it has, you could specify a set of rules to apply. So you encode your hardware device's capabilities into a set of rules and the core libgroove audio graph uses that to figure out whether it needs to do any resampling or not. (hopefully not, except in the case where the hardware device can't handle it).

We're coding the new Volumio as a Node.js application, and would probably hook to libgroove through node-groove. When I call groove.createPlayer(), does this create an instance of libgrooveplayer?
If so, it would be great to allow for adjustable output format. I'm not sure yet what that entails, but plan on familiarizing myself with the libgroove code this week. We could definitely put something in Volumio to enumerate the capabilities of the sound card the user has selected to play through.

We're coding the new Volumio as a Node.js application, and would probably hook to libgroove through node-groove. When I call groove.createPlayer(), does this create an instance of libgrooveplayer?

Yes, that's right.
So I think I understand the use case well enough and I'll see what I can do to get libgroove up to spec on this over the next month.

Hey Andrew, we just made Volumio2 repo public. The code currently uses MPD as the local file player, but let me know when we can start testing out Libgroove for high res files!

Will do. Thanks for the link.

How does volumio want to handle channel layouts? Example:

Sound card supports 6 channels, audio file has 2 channels.
Sound card supports 2 channels, audio file has 6 channels.
Sound card supports 2 channels - front left, front right, audio file has 2 channels which are labeled back left, back right

One more question: do you have a way of testing if bit perfect playback is working? Eventually I'd like to replace the SDL dependency on audio playback with my own code, but for now it would be nice to double check that SDL is not doing any resampling, channel mapping, or sample format conversion.

How does volumio want to handle channel layouts?

Hmm I imagine different users might want to do it differently. Is there a way to make a general syntax for channel mapping, and make it changeable in a config file?

do you have a way of testing if bit perfect playback is working?

I wish I had a way to do this in hardware. Some of our members report that they have DACs that indicate the format of the audio it is receiving. As far as software goes, there are a few options. This page reports that you can read the contents of /proc/asound/card0/pcm0p/sub0/hw_params. Volumio 1.X seems to read /proc/asound/card0/stream0 instead. There is also some external software I have not tested, such as alsa-capabilities, which reads the same files, but outputs in a more user friendly display.

Alright:

libgroove 4.3.0 is released
node-groove 2.4.0 is released

Here's how to use the new API. In this commit diff look at example/playlist.js: https://github.com/andrewrk/node-groove/commit/41d39632823b8e002ef469a14d4d1e6ef4f27129#diff-fb02597f5645c7f2a9285e856f76cac9R11
Here's how it works:
The sound device is opened with default parameters. Pristine audio data is streamed from libgroove core. If the audio data does not match the open sound device parameters, then the sound device is closed and then re-opened with the correct parameters. Care is taken to wait for the existing buffered audio data to flush through the device before closing it and re-opening it.
I believe this issue is solved now. Please open fresh issues if you encounter anything else.


Update internal api path for crashed apps

Tracker: https://www.pivotaltracker.com/story/show/92957598
Signed-off-by: Zach Robinson<EMAIL_ADDRESS>

Closing. We'll have a CAPI-Diego cross-team discussion about the correct path forward for v3 app support before we proceed on this.
cc @zrob @dieucao
Thanks,
Eric


Ooapi work in progress

Changed Module class to use the types of the new API.
Changed a few get/set method patterns to properties, according to guideline:

Convention: get/set methods become properties, the rest of the names I follow literally. I'm putting comments on the top of the C# code with summary.

LGTM.


excludeDuplicateEvents query False

Data Plane API - Pull Request

The query filter "excludeDuplicateEvents" for the Sensor-Events GetAll api was "true" by default. It is being changed to "false".
When the above filter is set to true, only one event per timeStamp is shown in the output and other events of same timeStamp are considered as duplicate. This is not an intuitive behavior and customers might miss multiple events unless they turn this query filter to "false".

API Info: The Basics
Most of the information about your service should be captured in the issue that serves as your API Spec engagement record.

Link to API Spec engagement record issue:

Is this review for (select one):

[ ] a private preview
[x] a public preview
[ ] GA release

Change Scope
This section will help us focus on the specific parts of your API that are new or have been modified. Please share a link to the design document for the new APIs, a link to the previous API Spec document (if applicable), and the root paths that have been updated.

Design Document:
Previous API Spec Doc:
Updated paths:

❔Got questions? Need additional info?? We are here to help!

 Contact us!
The Azure API Review Board is dedicated to helping you create amazing APIs. You can read about our mission and learn more about our process on our wiki.

💬 Teams Channel
💌 email

Click here for links to tools, specs, guidelines & other good stuff
Tooling

Open API validation tools were run on this PR. Go here to see how to fix errors
Spectral Linting
Open API Hub

Guidelines & Specifications

Azure REST API Guidelines
OpenAPI Style Guidelines
Azure Breaking Change Policy

Helpful Links

Azure DevTools Wiki

@JeffreyRichter, per the service team, no customer is onboarded to this API version (it is gated) so I approved the change.


[Fix]:Fixed Typo in Readme

Summary
I have fixed a typo in the Readme file.

@microsoft-github-policy-service agree
@microsoft-github-policy-service agree company="Microsoft"

@bghgary Please review and merge this fix. I am aiming for Hacktoberfest/ Hacksquad and today is the last day. Only a few hours left on 31st October.

Where exactly is the typo? I don't see any changes to the text.

Please note that this project is not at the point where updates are fully
backwards compatibility yet
Please note that this project is not at the point where updates are fully backward compatible yet

This is not a typo. Both "backward compatible" and "backwards compatible" are accepted terminology.
https://en.wikipedia.org/wiki/Backward_compatibility

compatibility  => compatible

compatibility => compatible
@bghgary Please review and merge this fix. I am aiming for Hacktoberfest/ Hacksquad and today is the last day. Only a few hours left on 31st October.


add map type conversion

Description
Adding support for the complex type map. The map type is documented here, the conversion standard to BigQuery type is documented here.
Type of Change

[ ] Bug Fix
[ ] New Feature
[x] Breaking Change
[ ] Refactor
[ ] Documentation
[ ] Other (please describe)

Checklist

[x] I have read the contributing guidelines
[x] Existing issues have been referenced (where applicable)
[x] I have verified this change is not present in other open pull requests
[x] Functionality is documented
[x] All code style checks pass
[x] New code contribution is covered by automated tests
[x] All new and existing tests pass

@crdoconnor Is there anything I can do to make the process of reviewing this PR easier and faster?

Maybe @matsmaiwald knows more?

My apologies I should have looked at this earlier.

LGTM i think it just needs blacking.

It looks like black failed not because of formatting issues but some other problems?

Thank you @manmat ! This should be published on version 0.4.0. Let me know if there are any issues.


NetworkObserver flickers when called multiple times

I've got a beautiful set of operations which create many more operations, but each of them make NetworkObserver an observer of their operation. As far as I can tell, because I'm calling it multiple times, that triggers strange animations.
I've created a GIF from a video that shows the network indicator restarting each time it is called (at least I believe that is what is happening):

It looks like the NetworkObserver was (possibly) loosely based on this SO answer or at least they are using a similar strategy. The main difference between the two is:
NetworkObserver 66-68:
if activityCount > 0 {
    networkIndicatorShouldShow(true)
}

SO Answer:
if (activityCount == 0) {
    [self setNetworkActivityIndicatorVisible:YES];
}

By doing > 0 it is actually triggering networkActivityIndicator.networkActivityIndicatorVisible multiple times. I think by changing that to == 0 it will make sure it only gets triggered once and that the timer is actually updated more than just when the timer finishes.

I have a proposal for how to change those four methods (updateIndicatorVisibility, networkIndicatorShouldShow, networkActivityDidStart, networkActivityDidEnd). I want to run it by @danthorpe before I create a PR with this type of change.
private func showNetworkIndicator {
    if activityCount == 0 {
        networkActivityIndicator.networkActivityIndicatorVisible = true
    }
    activityCount += 1
}

private func hideNetworkIndicator {
    activityCount -= 1
    if activityCount <= 0 {
        networkActivityIndicator.networkActivityIndicatorVisible = false
        activityCount = 0
    }
}

// Public API

func networkActivityDidStart() {
    assert(NSThread.isMainThread(), "Altering network activity indicator state can only be done on the main thread.")
    showNetworkIndicator()
}

func networkActivityDidEnd() {
    assert(NSThread.isMainThread(), "Altering network activity indicator state can only be done on the main thread.")
    hideNetworkIndicator()
}

This does leave out the visibilityTimer aspect. I think it could be worked in, I just don't know what the intention was behind that. If you have a long running activity that doesn't trigger another network observer update (to refresh the timer) it seems like the timer would turn the indicator off after a second. Is it a matter of knowing when an operation cancels and then decrementing the counter (hideNetworkIndicator)?

Hi @ryanjm,
the intention behind the timer is to create a 1 second delay before hiding the indicator when no network request ist running anymore. That is done to prevent it from flickering on and off in situations where you have network operations in sequence.

Hi @ryanjm - thanks for the feedback - definitely think that we need to do something to fix this flickering issue!
Anyway, looking through the code, I think the whole observer, indicator, timer etc could be improved significantly. Additionally, given your animation, and experience with it, it seems like the timer is not working as intended?
I'm was sort of half thinking that changing the whether the network indicator is visible or not should be an Operation. And the network observer can use OperationQueue.mainQueue(). Then, instead of just switching the state to show/hide, we would instead push some operations onto the queue. Something like this for showing the indicator.
[ Delay 0.5 ] <-- [Show] <-- [Delay 0.5]
However, your proposals would also work - the downside is that it complicates the business logic a bit for how the show/hide happens, which is then harder to test. Part of the beauty of Operations, is that we can remove/simplify business logic into small units which we compose or schedule together.
Anyway, pretty happy for your to proceed with a PR as you suggest 😁

Ok, so it sounds like the timer should only be created/set when activityCount == 0.
I'll create a fork and play around with reworking that code / tests to see what I can do to help. With the concept of the timer in mind, I'll see what makes the most sense.
@danthorpe I'm not sure I understand your suggestion about the change to using an Operation. How would you keep track of the current activityCount?


fix(traverse): Prevent traversing Vue instances

What kind of change does this PR introduce? (check at least one)

[x] Bugfix
[ ] Feature
[ ] Code style update
[ ] Refactor
[ ] Build-related changes
[ ] Other, please describe:

Does this PR introduce a breaking change? (check one)

[ ] Yes
[x] No

The PR fulfills these requirements:

[x] It's submitted to the dev branch for v2.x (or to a previous version branch), not the master branch
[ ] When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
[ ] All tests are passing: https://github.com/vuejs/vue/blob/dev/.github/CONTRIBUTING.md#development-setup
[x] New/updated tests are included

If adding a new feature, the PR's description includes:

[ ] A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:
This fixes a bug first discovered in Vuex where storing Vue instances in the Store generates a RangeError: Maximum call stack size exceeded.
Related: https://github.com/vuejs/vuex/issues/1587

If there is another approach for this I'm happy to go that road and suggest an alternative fix or documentation improvement..

I would discourage you from storing Vue instances in the store. It's better for the store to be fully serializable. I think we have already discussed this but couldn't find the discussion in vue repository.

@posva I thought also this should be named in the docs somewhere. So if this PR leads to that new "good practise rule" I am happy also. It should be clear so developers know if its something we can use or not.

Yeah, I understand, I read the issue you posted on Vuex
It is stated in Vue.js Docs: https://vuejs.org/v2/api/#data
The Vuex state property follow the same reactivity rules as Vue data


Add support for Key Vault 7.5-preview.1

Also treats KeyRotationPolicyAction as case-insensitive.

API change check
APIView has identified API level changes in this PR and created following API reviews.
Azure.Security.KeyVault.Administration

@pallavit or @christothes could you sign off? I'd like to get this one done. The API isn't done, yet, but there will be follow-ups. I don't like PRs lingering forever.

Thank you, @christothes!


Added wasCached flag to show it a result was fetched from cache. This…

… can be usefull for the rate limits (max 60 per minute).

Going to look at this PR soon!

I think I'm going to merge this for now, but it will probably be replaced
by something better in a future bc-breaking PSR-6-compatible major version
of the library.
npluis<EMAIL_ADDRESS>schrieb am Do., 8. Okt. 2015 14:26:

… can be usefull for the rate limits (max 60 per minute).
You can view, comment on, or merge this pull request online at:
https://github.com/cmfcmf/OpenWeatherMap-PHP-Api/pull/44
Commit Summary

Added wasCached flag to show it a result was fetched from cache.
This can be usefull the rate limits (max 60 per minute)

File Changes

M Cmfcmf/OpenWeatherMap.php
https://github.com/cmfcmf/OpenWeatherMap-PHP-Api/pull/44/files#diff-0
(23)

Patch Links:

https://github.com/cmfcmf/OpenWeatherMap-PHP-Api/pull/44.patch
https://github.com/cmfcmf/OpenWeatherMap-PHP-Api/pull/44.diff

—
Reply to this email directly or view it on GitHub
https://github.com/cmfcmf/OpenWeatherMap-PHP-Api/pull/44.


Add futimens

Looks like this may not be present on OSX?

This automation is really great :)

Ah looks like Android also doesn't have this function unfortunately :(

Ah I'm rolling up some other PRs, I'll take care of it.

Just to make sure, android does not seem to have  utimes, but it does have utimens


Replace previous box titles with more accessible version

This replaces the previous box titles which required one to type out a lot manually:
> ### {% icon tip %} Tip: Some tip

With a cleaner, "custom element"
> <tip-title>Some tip</tip-title>

Where the icon and styling is done automatically. This is done for all box types, and makes it easier to do bulk updates on them in the future if we need further changes.
It is backwards compatible, old style "icon tip ..." are still functional (until we get e.g. planemo updated + some of #2687 to provide suggestions)
accessibility
There are two a11y reasons to do this:

our previous boxes didn't announce opening/closing, we would have to write a lot of javascript to work around this.
Our previous boxes used an h3 element, which constantly got flagged for incorrect trees of h1/2/3/4/..., having a transition from h1 to h3 is bad, and an h3 inside e.g. an h6 section completely breaks the structure.
We had icons which were completely for decoration in the box titles, it was extremely redundant for screenreaders to read hands on icon Hands-on: title, but we couldn't set aria=false on all of those to make screenreaders ignore them. This allows us to finally do that.

whoo!! :tada:

:100: :1st_place_medal:


Fix - Reduce the haptic feedback vibration to a short bip

cc: @Jag96 Creating a draft PR. Looking forward for your feedback!
Details

Now that my PR is merged into react-native-haptic-feedback, we can use it directly instead of Expensify's fork.
Use the lib junina-de/react-native-haptic-feedback for haptic feedback.
Android
Create a new file: components/PressableWithSecondaryInteraction/index.android.js
Call ReactNativeHapticFeedback.trigger('effectHeavyClick'); for a long press.
iOS
Create a new file: components/PressableWithSecondaryInteraction/index.ios.js
Call ReactNativeHapticFeedback.trigger('selection'); for a long press.
Fixed Issues

$ https://github.com/Expensify/App/issues/4355
Tests / QA

Navigate to a conversation on mobile (iOS, Android).
Long press on a message.
Verify that the haptic feeback is same as slack's long press on a message.

Tested On

[x] iOS
[x] Android

Screenshots
Not Applicable

All checks have passed!

🚀 Deployed to staging by @Jag96 in version: 1.1.11-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by @yuwenmemon in version: 1.1.12-3 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Add RoomTemperature Sensor to CAN HCX

Hi,
Thanks for a very nice implementation! I was able to successfully connect my KM200 into HomeAssistant via your component. There was however one sensor missing. I have Buderus HRC2 as a room regulator connected to CAN bus and the room temperature sensor was missing. This pull request fixes it.
I can also provide bosch scan dump if needed.

HI @zpieslak , sorry I missed your PR because of holidays.
Can you provide bosch_scan, just to to have something to check if somebody else come up with some errors because of this PR.

HI @zpieslak , sorry I missed your PR because of holidays.
Can you provide bosch_scan, just to to have something to check if somebody else come up with some errors because of this PR.

Attached.
bosch_scan.zip

Attached.
bosch_scan.zip

FYI I will release new version of HA component next week.

FYI I will release new version of HA component next week.

Dzięki

Dzięki


Url scan

Is there anyway i can automatically put the url in?

On line 55 in the class you have open, the URL you have in the screenshot is being scanned.

Yes yes i know i mean like any way i can automatically put the url through a text file or something. Instead of hardcoding it?

btw thank you for replying so promptly :D

This is more a general question about C# than this library. However, I'll give a quick example anyway:
static void Main(string[] args)
{
    RunExample().Wait();

    Console.WriteLine("Press a key to continue");
    Console.ReadLine();
}

private static async Task RunExample()
{
    //Read all the urls
    string[] urlArray = File.ReadAllLines("FileWithUrls.txt");

    //Create VirusTotal API. Remember to set the API key
    VirusTotal virusTotal = new VirusTotal("YOUR API KEY HERE");
    virusTotal.UseTLS = false;

    //We scan all the urls in the urlArray
    List<UrlScanResult> scanResults = await virusTotal.ScanUrls(urlArray);

    //Print out all the results
    foreach (UrlScanResult result in scanResults)
    {
        Console.WriteLine(result.Url + " " +  result.ScanDate);
    }
}

There is a bug related to ScanURLs() - Update to version 1.5.1 to fix it.

Thank you for ur reply. May I Noe what is application u like visual studio console application or windows forms or wpf application

Haha okay I know it's a class library just wanna ask another question is: is it possible to make it to an executable file :)

Such that I can call this virustotal automatically

You can download the example included in the VirusTotal.NET package and replace the code, with the code i posted above. In .NET core, you will get a DLL file, which you can run just like an EXE file, by calling dotnet <InsertDllNameHere>. I'm closing this issue, as it is not related to this project.


Account Abstraction support

This is a pass at adding AA support with Keplr, a well supported cosmos and cosmos-kit wallet. This is based on the Metamask example by 0xLarry at https://github.com/larry0x/metamask-cosmos-demo/blob/main/src/index.js

wrong target, hopefully this is ready for primetime soon


Risk Score Calculation Clarification

Summary
This PR is intended at clarifying th description of the total risk score and the combined risk score, as far as I have been able to understand it from the documentation.
Please find below some additional remarks, which I could not address directly in the source of the PR, because the source code of the images is not available or because it is something, which needs discussion before proceeding with it. I‘m happy to supplement the PR with additional commits, if you decide on a thumbs on the „optional“ part.
Changed requested in the figures

Fig. 5. Exposure duration row, 2nd box
D <= 5 should be replaced by 0 < D ≤ 5

Fig. 13: The box „normalized total risk score“ should IMHO be renamed to „Normalized Maximum Total Risk Score“, because what is normalized is the „Maximum Normalized Total Risk Score“.

Topics which need to be verified as part of the Review
I‘ve linked to the file ProtoFormatConverterExtensions.kt  in the Android app repo for the transmission risk score values, but I‘m unsure if this is the appropriate place. Likely, there should also be a link to the Apple App repo, where these values are defined.

The sentence: According to the documentation of the framework, "the attenuation is weighted by the duration at each risk level and averaged for the overall duration" did not make a lot of sense to me at the particular place it was given. I suggest to move it to a bit different place (see PR).

Optional (to discuss)

Fig. 5. I suggest to use the math symbols ≤ and ≥ instead of the computer programming convention of using <= and >= throughout the entire document and in particular Fig. 5.
Let me know, if you want to proceed with this, then I‘ll update my PR accordingly (but cannot change it in the figures)

Updated links to main/master version instead of specific version as suggested by @MichaelPFrey .

Thanks for the PR. We've asked the document owner to review this again.

@tkowark This has been hanging for 17 days now, 11 days since last comment from maintainers. Would be nice if it could get finally reviewed by the person responsible.

Dear @jensjensenjens ,
The changes look really good and we would like to accept them. In combination with the new example in cwa-risk-assessment.md , the overall risk calculation process is hopefully clearer.
Unfortunately, I cannot solve the current merge conflicts by myself as the merge commit is somehow not working. Did you enable that maintainers can push to you branch? If not, could you solve the merge conflict and then we'll merge your additions.
Best regards,
TK
Corona-Warn-App Open Source Team

Thank you very much for the update!

Thanks for integrating this PR! I'm impressed that suggestions are actually being migrated. This project is truly a combined open-source effort.


Bug: Minimap

The minimap does not update correctly when moving the player or exploring new areas of the map. This can cause confusion for the user, as it does not reflect the position or environment in real time.
Steps to reproduce it:

Run the project in Unity.
Start the game and move the character around the map.
Observe how the minimap does not respond or shows incorrect positions.

Expected behavior:
The minimap should accurately reflect the player's position and update in real time as new areas are explored.
Proposed solution:

Verify that the minimap camera is correctly linked to the player.
Review and correct the scripts associated with the minimap system.
Ensure that the map boundaries are defined and synchronized with the minimap system.

My background
As a member of the Dojo Coding community, I have experience in web2 and traditional technologies, as for web3 I have only been working for a few months and I have managed to make a few contributions, however, it is not an impediment for me to do my best in this issue, I will dedicate the necessary effort to contribute to the OSS.
How I plan on tackling this issue
To solve this issue, I will perform the following steps:

Identify the bug by running the project and ask questions to the mainteiners about the bug.
Perform different tests to the erroneous response of the character's position.
Make the necessary changes to reflect the expected behavior.
Test different functionalities to corroborate that the behavior is as expected.
Send my solution for a review by the mainteiners.
Make changes in case the mainteiners tell me to do so.

sure @salazarsebas, if you have any questions, I will be glad to help you.


Registry gas costs

Some of the registry operations (e.g., entity registration/deregistration, unfreezing a node) should probably be changed to cost gas.

Should the gas cost for an entity (re-)registration scale based on how many nodes the entity claims to own?  Alternatively, should the initial node registration (not re-registrations) cost gas (might be hard to do if we want to allow people to update without it costing anything, since the node descriptor goes away)?

Should the gas cost for an entity (re-)registration scale based on how many nodes the entity claims to own?

Yeah that's a good idea. But then there needs to be separate charges for entity-signed node registrations.

Should the node registrations cost gas?
Maybe just the initial node registration?

That would enable the node key to drain the entity's account?

Maybe a combination of "entity registrations cost more gas if it includes more nodes", and "self-signed (vs entity signed) node registrations are gas-less"?

Yeah this makes the most sense -- so entity registrations cost more gas based on the length of the nodes field and entity-signed nodes must pay for gas.


Spotify GUI completely broken

Description
Basically, the GUI for Spotify cannot be interacted with and it looks like it came from a 2005 web page. there is a thingy over the whole GUI as if it's a piece of anti-click film.  Here's the link. It's not as intuitive but hey what can you do.

I'm currently trying everything. Can't for the life of me get this Rainmeter OR the one from Wallpaper Engine to work. It will get the cover art and title/artist, but the Virtualization itself remains dead. Also I manage to break Spicetify, so it won't load even the SpicetifyDefault skin now. Help?

Have you installed and applied the cli through powerShell?

Yes, I did run it as admin as well. I did however, break it somehow, can't change themes now. Not even default, and restore setting does nothing.
And how is it listening in on the audio, is Spicetify doing that? Are there any settings to pick microphones or something?
-Stefan

From: Malik Tillman<EMAIL_ADDRESS>Sent: Wednesday, December 25, 2019 7:55:03 PM
To: marcopixel/Monstercat-Visualizer<EMAIL_ADDRESS>Cc: stefanw1337<EMAIL_ADDRESS>Comment<EMAIL_ADDRESS>Subject: Re: [marcopixel/Monstercat-Visualizer] Spotify GUI completely broken (#270)
Have you installed and applied the cli through powerShell?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/marcopixel/Monstercat-Visualizer/issues/270?email_source=notifications&email_token=ADR3YAXFPWY5NVARSGZHHN3Q2OUAPA5CNFSM4JGBVXMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHURBKY#issuecomment-568922283, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADR3YAT24BSL46FN3PFDYJTQ2OUAPANCNFSM4JGBVXMA.

Did you forget spicetify config inject_css 0 replace_colors 0 when installing Spicetify? If so, try the following steps:

Completely exit and stop Spotify
Open PowerShell as Administrator
Run spicetify config inject_css 0 replace_colors 0
Run spicetify apply
Once Spicetify is done, restart Spotify.

For sound, I believe the visualizer just detects if a song is playing with spicetify's webnowplaying.js extension, and if one is, it detects all audio output from the current audio device. This is why you can pause the song and play a YouTube video and still have the visualizer show all audio.
If you want to change the audio device it detects on, you'd probably have to edit the skin directly.

Closing this issue, please create an issue on the spicetify-cli repo for further help on spicetify.


[Hooks] Alternative state

I would prefere this
Language-level syntax  state foo = 5;
rather than const [foo, setFoo] = useState(5);
The latter feels so cumbersome.

Where is the link with setFoo in state foo = 5;?

I imagine this acting like a proxy, so like setting a normal variable: foo = 5; (yes old browsers are excluded here)
think about it, react is not the only framework, that needs do deal with state. Almost every Web App written in Javascript needs state, so why not integrate it in the language? Frameworks can then implement specific logic, whatever 'state' means to Vue, React ...etc..

Are you suggesting new syntax to JS itself with the state symbol? This isn't the correct place for this.


Account Deletion and Log Out

Allow user to delete their account and to log out.
Data structure

[x] In the SQL database, add a field named isloggedin (boolean value, google how to do that in postgreSQL).
[x] Add that field to all SQL files.
[x] Add that field to ALL server and client models.

Endpoints
Add endpoints for creating (registering), deleting and editing users. Add two further ones for logging in and out. These should be:
For adding, this should return the id if adding was successful.
POST /users

{
    "email": string,
    "name": string,
    "password": string
}

For editing:
PUT /users/:id

{
    "email": string,
    "name": string,
    "password": string
}

For deleting:
DELETE /users/:id
For logging out:
PUT /users/logout/:id
For logging in:
POST /users/login

{
    "email": string,
    "name": string,
    "password": string,
}

yay


how run 'npm ci` instead 'npm i'

Hi, how the plugin may run npm ci commands with arguments instead just npm i?
Thank you a lot!

Hi @shurygindv,
You should be able to override the install script run during the install goal, for example:
<plugin>
  <groupId>com.github.mjeanroy</groupId>
  <artifactId>node-maven-plugin</artifactId>
  <version>0.7.2</version>
  <configuration>
    <installScript>ci</installScript>
  </configuration>
  <executions>
    <execution>
      <id>front:build</id>
      <goals>
        <goal>check</goal>
        <goal>install</goal>
        <goal>build</goal>
        <goal>test</goal>
      </goals>
    </execution>
  </executions>
</plugin>

Let me know if that works, otherwise I'll fix it ;)

It almostly worked! But in some time it threw an error (use your code snippet above)
[ERROR] Cannot execute npm run ci command: it is not defined in package.json (please check file: ../package.json).

@shurygindv I see, I just fixed it, please update to version 0.9.1, it should works ;)


Make throwsException fail for AssertionError

Codecov Report
Base: 100.00% // Head: 100.00% // No change to project coverage :thumbsup:

Coverage data is based on head (b43c1a6) compared to base (edc4c94).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##                main        #8   +/-   ##
===========================================
  Coverage     100.00%   100.00%
  Complexity        54        54
===========================================
  Files              4         4
  Lines            115       116    +1
  Branches          14        14
===========================================
+ Hits             115       116    +1

Impacted Files
Coverage Δ

src/main/java/me/sparky983/spark/Assertion.java
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


TicTacToe Bot doesn't quit game when player leaves Group Chat

http://image.prntscr.com/image/8b1bf4727e4446be9a4cac903b30063f.png

Wrong repoistory, I'm guessing.


Jenkins build server: shutdown AGS and Geoevent windows service on geoevent server

In addition to shutting down AGS windows servers on the dev AGS servers before the data copy we should also shutdown AGS and geoevent windows service on the dev geoevent machine.

Changes made, needs to be verified next build.

Verified.


[release-2.4] updated slo dashboard panel labels

Related issue: https://github.com/open-cluster-management/backlog/issues/17379
Signed-off-by: dislbenn<EMAIL_ADDRESS>

/approve
/lgtm


LLVMPasses: adapt to ba664d9

Adapt to API changes in ba664d9, where AAQueryInfo now requires the
capturing information.  Switch to the new SimpleAAQueryInfo which
maintains the status quo for alias analysis.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

Thanks!


WIP: Kong entities

Adding entity pages for:

Services
Routes
Plugins
Upstreams
Targets - not sure about this one. I think that targets need upstreams to work - should targets be covered under upstreams instead?

After the preview loaded, I learned that new topics don't get generated during a running build, I have to stop, make clean, and restart the build first.

https://deploy-preview-21--kongdeveloper.netlify.app/kong-entities/
Outstanding questions:

How much info is too much? Where do we draw the line on what's info about an entity, and what's something else? For example, the plugins page goes into a lot of detail on many different aspects of plugins. Should all of that info live on different pages, eg:

Plugin entity
Plugin precedence
Plugin scopes
Custom plugins

When there's a lot of content, the entity block gets pushed to the bottom of the page. Should we try to keep the content shorter so that it doesn't get lost? Or allow authors to specify the position of the block?
Seeing some of these longer pages makes me want some kind of table of contents. Wonder if we could generate a collapsible ToC at the top of the page somewhere, and enable it with something like toc: true?

Just tried it again both ways:

Build is already running with make run
Created a certificates.md page, it doesn't appear in the preview
Stopped the build, ran it again with make run, still no certificates page


lib: cmsis_dsp: matrix: tests libraries.cmsis_dsp.matrix.* do not fit in flash on nRF5340DK and nRF9160DK

Describe the bug
The tests:

libraries.cmsis_dsp.matrix.unary_f64
libraries.cmsis_dsp.matrix.unary_f32
libraries.cmsis_dsp.matrix.unary_f64.fpu
libraries.cmsis_dsp.matrix.unary_f32.fpu
fail for nrf5340dk_nrf5340_cpuapp_ns and nrf9160dk_nrf9160_ns.

Additionally, the tests:

libraries.cmsis_dsp.matrix.binary_f16
libraries.cmsis_dsp.matrix.binary_f16.fpu
libraries.cmsis_dsp.matrix.binary_q15
libraries.cmsis_dsp.matrix.binary_q15.fpu
fail for nrf5340dk_nrf5340_cpuapp_ns.

To Reproduce
Steps to reproduce the behavior:

have nrf9160dk_nrf9160 connected
go to your zephyr dir
call ./scripts/twister -T tests/lib/cmsis_dsp/matrix/ -p nrf9160dk_nrf9160_ns --device-testing --device-serial /dev/ttyACM0 -v --inline-logs
See console output with error

Expected behavior
Valid console output
Impact
Not clear
Logs and console output
arm-zephyr-eabi/bin/../lib/gcc/arm-zephyr-eabi/12.2.0/../../../../arm-zephyr-eabi/bin/ld.bfd: zephyr/zephyr_pre0.elf section `rodata' will not fit in region `FLASH'
arm-zephyr-eabi/bin/../lib/gcc/arm-zephyr-eabi/12.2.0/../../../../arm-zephyr-eabi/bin/ld.bfd: region `FLASH' overflowed by 29879 bytes

Environment (please complete the following information):

OS: Ubuntu 20.04.1 LTS
Toolchain Zephyr SDK 0.16.5
Commit SHA or Version used: v3.6.0-rc2-3-g592a7cd6a750

Did these applications fit before in an earlier version of zephyr i.e. before the cmsis-dsp changes?

Did these applications fit before in an earlier version of zephyr i.e. before the cmsis-dsp changes?

I do not know because earlier these test configurations had not run.

Well if they've never fit before then this isn't really a bug, if they do build and fit for older versions of zephyr then this is because of the cmsis-dsp refactoring that seemed to drop a lot of Kconfig options and increased binary size

CC @XenuIsWatching


Support TransformersRecognizer

This library currently supports SpacyRecognizer and StanzaRecognizer but not TransformersRecognizer
As highlighted by @omri374 in https://github.com/microsoft/presidio-research/pull/50#discussion_r1051580199_

Fixed in 0.2.0


Replace kit/v2/sync map

Codecov Report

Merging #356 (eaeeba5) into master (015ea35) will increase coverage by 0.57%.
The diff coverage is 88.70%.

@@            Coverage Diff             @@
##           master     #356      +/-   ##
==========================================
+ Coverage   69.60%   70.17%   +0.57%
==========================================
  Files          67       68       +1
  Lines        5675     5788     +113
==========================================
+ Hits         3950     4062     +112
  Misses       1317     1317
- Partials      408      409       +1

Impacted Files
Coverage Δ

message/status/status.go
0.00% <ø> (ø)

udp/client/clientconn.go
71.42% <ø> (-0.48%)
:arrow_down:

udp/server.go
82.22% <ø> (ø)

dtls/client.go
76.31% <16.66%> (+0.66%)
:arrow_up:

tcp/clientconn.go
68.43% <25.00%> (+0.24%)
:arrow_up:

pkg/connections/connections.go
87.87% <84.61%> (-3.79%)
:arrow_down:

dtls/server.go
84.00% <100.00%> (ø)

net/blockwise/blockwise.go
68.49% <100.00%> (+0.05%)
:arrow_up:

net/blockwise/senderRequestMap.go
85.96% <100.00%> (-2.28%)
:arrow_down:

pkg/sync/map.go
100.00% <100.00%> (ø)

... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 568a42a...eaeeba5. Read the comment docs.


Update README.md

Hi all,
This is just correcting a very small typo that breaks the conda environment activation. The environment file is creating the "cellpose_napari" not the "cellpose-napari" environment
This commit simply fixes the suggested line to activate the environment :) I hope it can be useful

thanks!


Non-conventional use of ng-init

From Google group discussion: https://groups.google.com/forum/#!topic/meanjs/cO5AAAOgVAY
Angular docs for ngInit (https://docs.angularjs.org/api/ng/directive/ngInit#!) say:
"The only appropriate use of ngInit is for aliasing special properties of ngRepeat, as seen in the demo below. Besides this case, you should use controllers rather than ngInit to initialize values on a scope.
But e.g. in list-articles.client.view.html it is being used as below:
<section data-ng-controller="ArticlesController" data-ng-init="find()">

This appears to be a part of the boilerplate that breaks convention and unless there is good reason for that it should arguably be fixed. I'd be happy to do a pull request and fix it myself, though I'm not sure if data-ng-init="find()" should simply be removed or replaced by something else.

In case anyone cares, take a look at the controllers, views and karma tests in this module to see how I changed things: https://github.com/androidfred/ideit/tree/master/public/modules/ideas
TLDR I split the controller, run the initialization methods after declaring them in the controllers, got rid of ng-init and changed the tests slightly.
I'd be happy to do a PR but feedback and agreement from you guys is required first.

In case anyone cares, take a look at the controllers, views and karma tests in this module to see how I changed things: https://github.com/androidfred/ideit/tree/master/public/modules/ideas
TLDR I split the controller, run the initialization methods after declaring them in the controllers, got rid of ng-init and changed the tests slightly.
I'd be happy to do a PR but feedback and agreement from you guys is required first.

I find the proposed changes better than using ng-init, but kind of cumbersome. Couldn't this be delegated to a function that checks the current $state? Will this affect performance in any way?
Like so:
$scope.$on('$stateChangeSuccess', function(event, toState){
  switch (toState) {
    case 'view':
      $scope.findOne();
      break;
    case 'list':
      $scope.findOne();
      break;
    default:
      //Default logic
  }
});

@ikhos I'm not really a fan of doing stuff in the event, because that makes more work for people who want to switch routing and if we decide to move to angular/router in the future.

Thanks for your attention.
As Angular docs say you should use controllers rather than ngInit to initialize values on a scope, and that a controller should contain only the business logic needed for a single view, I hope both these issues are addressed by some other means.

@androidfred Have you explored implementing a resolve on your ui routes? This could help keep your controllers clean of these types of data initializing. I've seen this approach advocated. Personally, I prefer having an init() function in my controllers. It's easier for me to keep track of what data is being loaded when the controller's initialize; without the need to track it down in my route configurations.
I haven't implemented many resolves on my ui routes, as I'm not sure of the performance costs since the route won't load until the resolve finishes.

Resolved by #1126
Please close if this is no longer an issue.

Closing as requested.


record mode add comment

Can be configured to display comments in grid mode, can a similar configuration be given in record mode to display field comments

Hello @FreshSnack
Thanks for the idea.


add unique filter to openstack pool names

could have scenario where different openstack components would
use the same pool, but the logic would create the same pool
more than once
add unique filter to account for this

jenkins test playbook syntax


⚠ Bofrost.de has degraded performance

In 5837c1d, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1388 ms

Resolved: Bofrost.de performance has improved in 98c2c4e after 6 minutes.


chore!: drop support for node 16

BREAKING CHANGE: minimum required version of node increased from 16.0.0 to 18.12.1
Node 16 becomes EOL in September 2023, which is the same time that Yeovil District Hospital NHS Foundation Trust is due to merge with Somerset NHS Foundation Trust. Development will be focused on the merger at that point in time, so this PR preemptively drops support to reduce work load in the future.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
514

Relevant Lines:
514

💛  - Coveralls


libGL error

I'm getting after:
$ chmod a+x Mindmapp-0.7.12.appimage
$ ./Mindmapp-0.7.12.appimage

these errors:
libGL error: pci id for fd 11: 80ee:beef, driver (null)
libGL error: No driver found
libGL error: failed to load driver: (null)
[10:18:47.400] [info] Checking for update

on a VM with Antergos although Mindmapp seems to be working normally.

Hi @hubitor,
can you check if it gives this error with other .appImage applications built with electron-builder?
Do you see this error on physical machine with Antergos and not on VM?

Hi @cedoor,

can you check if it gives this error with other .appImage applications built with electron-builder?

Just checked with Mindomo_v.8.0.40_x64.AppImage (I assume is built with electron-builder) and there is not such an error.

Do you see this error on physical machine with Antergos and not on VM?

I have installed Mindmapp on an Antergos-VM. I saw this error in the console after I run:
$ ./Mindmapp-0.7.12.appimagebut otherwise Mindmapp seems to  be working normally.

Hi @hubitor,
umh, I don't know if Mindomo use electron-builder, but I think the problem is caused by VM software. Are you using Virtualbox?

Hi @cedoor ,

Are you using Virtualbox?

Yes.

Hi @hubitor,
are you installed the Virtualbox Guest Additions?

Hi @cedoor ,

are you installed the Virtualbox Guest Additions?

Yes.
$ pacman -Q | grep virtualbox-guest-dkms
virtualbox-guest-dkms 5.2.18-1

Hi @cedoor ,
I see now that I get a similar error when I open a text file with kate. So it's not mindmapp.

Hi @hubitor,
thank you!


Don't alter Array.prototype.findIndex

@plong0 ^

@aaronroberson it looks like this only fails because of existing test failures.

I am confused about what your concern is as there is an if check around the polyfill.
Please notice that this is the polyfill copied from the MDN documentation on the Array.findIndex page.  You can review the comments on PR #1407 which added the polyfill to see that it was recommended to include the polyfill vs writing a new function.

@plong0 this polyfill actually broke our application and I had to downgrade to 0.14.1

While there is a check, it would be much better to use a Shim over a Polyfill in library code

Hm, that's unfortunate, but it does seem a bit strange that a polyfill would break your app.
As far as using a shim vs a polyfill in a library, from what I understand of them they are meant to serve different purposes.  Since Array.findIndex is becoming a standard feature of newer JS implementations, it seems more appropriate to use the polyfill...  If a polyfill really broke your application, wouldn't that mean your application is already broken in some browsers?

@plong0 basically we didn't expect this property to exist in IE10, but then it suddenly did.  To be fair it broke legacy code in the app, but this could break other things.
Ultimately it comes down to the fact that "polite" libraries shim, and in fact in browserify/webpack land it's best to require a compatibility shim (that dispatches accordingly) even in application code.

Thomas, can you post the exception or stack trace for the error I'm
extremely curious to know how the polyfill could be causing an error
On Thu, Feb 11, 2016, 8:43 AM Thomas Grainger<EMAIL_ADDRESS>wrote:

@plong0 https://github.com/plong0 basically we didn't expect this
property to exist in IE10, but then it suddenly did. To be fair it broke
legacy code in the app, but this could break other things.
Ultimately it comes down to the fact that "polite" libraries shim, and in
fact in browserify/webpack land it's best to require a compatibility shim
(that dispatches accordingly) even in application code.
—
Reply to this email directly or view it on GitHub
https://github.com/angular-ui/ui-select/pull/1428#issuecomment-182950489
.

--
Aaron Roberson
JavaScript Software Engineer
Mobile:<PHONE_NUMBER>
E-mail<EMAIL_ADDRESS><Aaron%20Roberson>
Skype: aaronroberson <file://localhost/skype/aaronroberson%3Fcall>
LinkedIn: http://linkedin.com/in/aaronrobes
http://linkedin.com/in/aaronrobes
GitHub: http://github.com/aaronroberson http://github.com/aaronroberson
Interested in scheduling a meeting? View my calendar and book a time to
talk using https://aaronroberson.youcanbook.me
https://aaronroberson.youcanbook.me**.
I ♥ JavaScript

@aaronroberson it's how adding this prototype effects for loops over arrays. I know you're not supposed to use them, but it's used everywhere in a legacy codebase of ours.

Are you checking for hasOwnProperty in your  for loops? If not,  as
painful as it may be, you need to update your code base.
On Thu, Feb 11, 2016, 8:47 AM Thomas Grainger<EMAIL_ADDRESS>wrote:

@aaronroberson https://github.com/aaronroberson it's how adding this
prototype effects for loops over arrays. I know you're not supposed to use
them, but it's used everywhere in a legacy codebase of ours.
—
Reply to this email directly or view it on GitHub
https://github.com/angular-ui/ui-select/pull/1428#issuecomment-182952683
.

--
Aaron Roberson
JavaScript Software Engineer
Mobile:<PHONE_NUMBER>
E-mail<EMAIL_ADDRESS><Aaron%20Roberson>
Skype: aaronroberson <file://localhost/skype/aaronroberson%3Fcall>
LinkedIn: http://linkedin.com/in/aaronrobes
http://linkedin.com/in/aaronrobes
GitHub: http://github.com/aaronroberson http://github.com/aaronroberson
Interested in scheduling a meeting? View my calendar and book a time to
talk using https://aaronroberson.youcanbook.me
https://aaronroberson.youcanbook.me**.
I ♥ JavaScript

I agree we should update this, but some code depends on not checking hasOwnProperty and some does not. This is a legacy codebase where webpack isolation is helping us to re-factor.
This doesn't mean it's necessarily a good idea to assign to a global variable or prototype in library code.

I think the "Be conservative in what you send, be liberal in what you accept" adage applies quite well here. Code using these arrays should obviously check that it's only getting the properties it needs, but also code modifying the array should probably leave it as-is rather than modifying it.
Another thing to consider is that consistency with what consumers expect is arguably more valuable than doing things the 'modern' way, especially given that 'modern' is incredibly subjective.

I was going to say, "who does a for..in over an array!"... until I found an instance in our code base too that failed over exactly the same thing. Luckily unit tests caught it during the upgrade, and we fixed it.

@aaronroberson we also want to be able to use babel-polyfill and we get a different implimentation of Array.prototype.findIndex depending on which order we load these modules.

Why not use babel during build instead of at runtime in the browser? Seems
you guys are doing a few "non-standard" practices that are causing more
harm then good?
On Tue, Feb 16, 2016, 7:44 AM Thomas Grainger<EMAIL_ADDRESS>wrote:

@aaronroberson https://github.com/aaronroberson we also want to be able
to use babel-polyfill and we get a different implimentation of
Array.prototype.findIndex depending on which order we load these modules.
—
Reply to this email directly or view it on GitHub
https://github.com/angular-ui/ui-select/pull/1428#issuecomment-184738366
.

--
Aaron Roberson
JavaScript Software Engineer
Mobile:<PHONE_NUMBER>
E-mail<EMAIL_ADDRESS>Skype: aaronroberson
LinkedIn: http://linkedin.com/in/aaronrobes
GitHub: http://github.com/aaronroberson

Interested in scheduling a meeting? View my calendar and book a time to
talk using https://aaronroberson.youcanbook.me.
I ♥ JavaScript

@aaronroberson babel runs at build babel-polyfill runs in the browser. It just loads things like core-js

@aaronroberson I don't see the advantage of including a polyfill in this library. I don't see the disadvantage of allowing projects to pollyfill, or working around the lack of a polyfill with a plain function.

@graingert Agreed. Fixed in v0.14.4.

@aaronroberson did you get hacked?

It's more embarrassing than that. I did a bulk invite using Gmail and apparently ever GitHub issue I've replied to from email is not getting spammed.


German translation error in Graph Docs

Link to article:
https://docs.microsoft.com/de-de/graph/
Problem:
In the "Supported platforms" section there's a translation error in the German language: Angular is translated to "Winkel" which doesn't make any sense.

Hello, @Steve2105
Thank you for your feedback.
We are actively reviewing your comments and will get back to you soon.
Kind regards,
Microsoft DOCS International Team

Hello @Steve2105
Thank you for your contribution.
Contributions on translation problems against machine translated content are currently not accepted.
We value your feedback and suggestions on human translated content, which is used to train the machine translation engines, so over time, your contributions will improve the quality of both human and machine translations.
Human translated topics can be distinguished from machine translated topics by the ms.translationtype metadata value “HT” (versus “MT” for machine translated) in the header of each content file.
Many thanks for your support.
Microsoft DOCS Global Experience Team


DOC: any empty directoryies -> empty directories

feel free to ignore... just read awkward to me

Thanks a bunch for your contribution! You wouldn't have needed to update the auto generated files, though: https://github.com/ncw/rclone/blob/master/CONTRIBUTING.md#writing-documentation

Sorry. Just ran my git-sedi command to replace all of them
Next time will exclude non sources


Which commit of llvm-xtensa to use?

I got it working yesterday so far but today I pulled latest changes from llvm-xtensa. They added e.g support for esp8266 - however now I am not able to compile libcore anymore.
So the quick question: which commit should I pick and do you also have problems with the latest changes in llvm-xtensa?

Hi @bjoernQ.
I also have problems to compile code with current HEAD of llvm-xtensa. Now I'm using https://github.com/espressif/llvm-xtensa/commit/bdf572d51d94de5590531c0eee320f7c99c96292, it compiles fine.

Thanks @lexxvir,
would be nice to get head working since it could mean to potentially also target esp8266 but at least I now have a working commit hash - I'll check out that commit and from now on be carefully about pulling changes in llvm-xtensa
Thanks!

I think I got llvm-xtensa head working with Rust - all it needs is cpu: "esp32".to_string(), added to the options in xtensa-none-elf.rs
Hope this helps and works for you

thanks @bjoernQ, I didn't realise espressif have added support for the esp8266 so soon!
I'll add two new targets, xtensa-esp32-none-elf,  xtensa-esp8266-none-elf and then remove xtensa-none-elf as soon as possible.

Hey guys, it has been a while, apologies but I've been super busy.
The changes I suggested have been added in https://github.com/MabezDev/rust-xtensa/commit/ad570c5cb999f62a03156286fdb5d3d1bbd0fb8b, which from my testing now uses the espressif master.
It looks like espressif have started to add object generation to thier fork so I will be playing with that soon.

Thanks - that's great. Looking forward seeing object generation added to their backend - I have a private branch of Rust with some hacks I really want to get rid of once we have object generation in place

Tried the latest version with the current head of the llvm backend but building core fails:
  process didn't exit successfully: `D:\rust_xtensa\rust\build\x86_64-pc-windows-msvc\stage2\bin\rustc --crate-name core D:\rust_xtensa\rust\src\libcore\lib.rs --color always --crate-type lib --emit=dep-info,metadata,link -C opt-level=3 -C panic=abort -C codegen-units=1 -C metadata=24d0b39b385d2852 -C extra-filename=-24d0b39b385d2852 --out-dir C:\Users\bjoern\AppData\Local\Temp\xargo.ldadfFkBvdVm\target\xtensa-esp32-none-elf\release\deps --target xtensa-esp32-none-elf -L dependency=C:\Users\bjoern\AppData\Local\Temp\xargo.ldadfFkBvdVm\target\xtensa-esp32-none-elf\release\deps -L dependency=C:\Users\bjoern\AppData\Local\Temp\xargo.ldadfFkBvdVm\target\release\deps -C save-temps -C link-arg=-nostdlib -C link-arg=-Tesp32.ld -C link-arg=-ucall_user_start_cpu0 -C link-arg=-u__cxa_guard_dummy -C link-arg=-u__cxx_fatal_exception -C link-arg=-uld_include_panic_highint_hdl -C link-arg=-uesp_app_desc -C link-arg=-Wl,--gc-sections -C link-arg=-Wl,-static -C link-arg=-Wl,--start-group -C link-arg=-Trom.ld -C link-arg=-lgcc -C link-arg=-lstdc++ -C link-arg=-lgcov -C link-arg=-Wl,--end-group -C link-arg=-Wl,-EL --sysroot C:\Users\bjoern\.xargo -Z force-unstable-if-unmarked` (exit code: 0x80000003)
error: `"cargo" "build" "--release" "--manifest-path" "C:\\Users\\bjoern\\AppData\\Local\\Temp\\xargo.ldadfFkBvdVm\\Cargo.toml" "--target" "xtensa-esp32-none-elf" "-v" "-p" "core"` failed with exit code: Some(101)

Any idea what could be the cause or what exit code 0x80000003 could mean?
Any idea how I could debug it on my own?

It looks like you're running windows. Error code 0x80000003  looks like it's a windows error code - you get 0x80000003  when there's a double fault in exception handling.
If you're getting it in rustc, the source would probably be something like a panic occuring inside a panic handler.

Closing as the default way to build this fork has changed. See https://github.com/MabezDev/rust-xtensa#using-this-fork


FATA[0120] Failed to run bundle: error waiting for CSV to install: timed out waiting for the condition

Bug Report

What did you do?
I am trying to install the example ansible operator mentioned in the documentation called "memcached-operator" via olm.
What did you expect to see?
memcached-operator needs to be installed.
What did you see instead? Under which circumstances?

Environment
Operator type:

language ansible

Kubernetes cluster type:
vanilla kubernetes and Kind
$ operator-sdk version
user@G7RGSDK3E:~/projects/memcached-operator$ operator-sdk version
operator-sdk version: "v1.31.0", commit: "e67da35ef4fff3e471a208904b2a142b27ae32b1", kubernetes version: "1.26.0", go version: "go1.19.11", GOOS: "linux", GOARCH: "amd64"
$ go version (if language is Go)
user@G7RGSDK3E:~/projects/memcached-operator$ go version
go version go1.20.6 linux/amd64
$ kubectl version
user@G7RGSDK3E:~/projects/memcached-operator$ kubectl version
WARNING: This version information is deprecated and will be replaced with the output from kubectl version --short.  Use --output=yaml|json to get the full version.
Client Version: version.Info{Major:"1", Minor:"25", GitVersion:"v1.25.4", GitCommit:"872a965c6c6526caa949f0c6ac028ef7aff3fb78", GitTreeState:"clean", BuildDate:"2022-11-09T13:36:36Z", GoVersion:"go1.19.3", Compiler:"gc", Platform:"linux/amd64"}
Kustomize Version: v4.5.7
Server Version: version.Info{Major:"1", Minor:"25", GitVersion:"v1.25.2", GitCommit:"5835544ca568b757a8ecae5c153f317e5736700e", GitTreeState:"clean", BuildDate:"2022-09-22T05:25:21Z", GoVersion:"go1.19.1", Compiler:"gc", Platform:"linux/amd64"}
Possible Solution

Additional context
Below are the logs -
FATA[0120] Failed to run bundle: error waiting for CSV to install: timed out waiting for the condition

This is usually due to some misconfiguration resulting in the bundle image being inaccessible. Are you sure you're using the same name and location of the bundle image everywhere? Are you sure the cluster has access to wherever you're hosting the bundle image?

Yes, I fixed the issue. Thanks


RMSProp not converging

Hi,
I updated mxnet last friday (March 17th) and I saw there have been major changes in the RMSProp implementation. I have set the parameters (centered=True, gamma1=0.95) to the values they had before the update, but I'm not able to get the same network I was using to converge as it did before the update.
Any ideas on what might be the reason?

@sxjscience I think the original implementation had bugs.

@rcapobianco I think you can try to train the network with (centered=False, gamma1=0.95). The original implementation of RMSProp has some bugs and we've fixed it.


Correctly write backup blocks

Fixes fsck.vfat complais about the backup blocks:

boot sector is copied to the backup block location
filesystem information is packed into the next logical block
fat backup is written alongside the primary copy

fsck.vfat does not complain about these issues after applying the patch

@deitch I went ahead and renamed backupFSInfoSector to backupBootSector because that's what it is. I hope that clarifies the issue.

Everything you write here makes sense based on that page. I have been trying hard to recall where we got this, but I guess it doesn't matter as long as we get it right.


De-duplicate code for displaying Saturn status for scrimmages and submissions

Unsure it's a good idea to dedupe. RUN should be interpreted as "verifying" in submissions and "running" in matches.

there's also a difference in what "OK!" means -- for matches, it means that it's run; in submissions, you have to look at "accepted" as well for compilation success/failure
given these differences, and the fact that it only occurs twice...we can keep things simple. (De-duped code would have to have some nontrivial machinery)


Enable parallel runs of 64-bit XUnit

This change enables us to run tests in parallel using new xunit2 64-bit runners.
The runner has to be 64-bit because otherwise we OOM. The new runtime with parallel enabled is ~12 minutes.
Some of the tests didn't support 64-bit running or parallel running for one reason or another. Where the fix was simple I did it myself. Otherwise, I filed a bug and disabled the test/assembly.

This is currently a PR into your own fork.  Did you mean to do a PR into dotnet/roslyn instead?

Unfortunately, this repo is a fork of your old git repo, so it doesn't recognize it as a fork of dotnet/roslyn. I just realized this myself :) I will delete this repository and restart on a fork.


trezor-connect version 8 has been deprecated warnings

Current Behavior
We've switched from bnc-onboard to web3-onboard recently and now we see trezor-connect version 8 has been deprecated. Pease start using @trezor/connect version 9 https://www.npmjs.com/package/@trezor/connect warnings on Sentry.
We were able to reproduce it on localhost too, by trying to connect Trezor wallet.
Expected Behavior
No warnings
Steps To Reproduce

@web3-onboard/core ^2.16.2, @web3-onboard/trezor ^2.3.5,
Mainnet on Goerli network (did not test with others)
Choose Trezor when you connect a wallet
Click Scan Accounts to find addresses
Check console, you should see the warning now

What package is effected by this issue?
@web3-onboard/trezor
Is this a build or a runtime issue?
Runtime
Package Version
^2.16.2
Node Version
16.18.1
What browsers are you seeing the problem on?
Chrome
Relevant log output
No response
Anything else?
I don't know if it breaks anything since I don't have a Trezor wallet to test, but it is not hard to upgrade it would be awesome 🙂

Sanity Check

[X] If this is a build issue, I have included my build config. If this is a runtime issue, I have included reproduction steps and/or a Minimal, Reproducible Example.

Thanks so much for bringing this to our attention! The team will take a look as soon as possible.

@alyavasilyeva this has been updated with the latest alpha version of the Trezor package and will be officially released after some testing shortly

@Adamj1232 great, thank you for your quick response!

@alyavasilyeva this has been updated with v2.3.6 of the Trezor package. Thank you for reporting this issue


[azservicebus] Updating test for deferred messages that was originally skipped

Fixing a test that actually turned out to be close to correct. Deferred messages aren't quite like normal messages - settlement functions do work but the effects aren't quite the same as with other messages.
Specifically:

CompleteMessage() removes the message from the 'deferred' area
AbandonMessage() updates the delivery count. The message remains deferred however.

Fixes #15626

/azp run go - azservicebus


Fix: too strict remote transition settings check

PR Description
I've not found any confirmation of previous check in spec, maybe I'm missing something. Without fix I cannot participate in testnets with bellatrix epoch == 0, ttd == 0.
Fixed Issue(s)

Documentation

[x] I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

[x] I thought about adding a changelog entry, and added one if I deemed necessary.

Ok, I finally come to what it should look like. At first we don't need rule remoteTransitionConfiguration.getTerminalBlockHash().isZero()                     == remoteTransitionConfiguration.getTerminalBlockNumber().isZero(), we need it only when terminal block hash is zero, see EIP-3675 other invariant is acceptable.
Note: If TERMINAL_BLOCK_HASH is stubbed with 0x0000000000000000000000000000000000000000000000000000000000000000 then TERMINAL_BLOCK_HASH and TERMINAL_BLOCK_NUMBER parameters MUST NOT take an effect.

And it's not a error, we just ignore it, so I modified it to be warning


Need to add a sentiment también in training

Can I use the "add_extra_data" method in training?. I'm working on a robot that can simulate emotions and I need to add a sentiment tag to every statement.
In the documentation there is no example of how to use that method.
Can you give me an example of use?
And, how can I add that tag in training?

Did you tried using category tag, I think this example will give some idea on how to write a category example https://github.com/gunthercox/chatterbot-corpus/blob/master/chatterbot_corpus/data/english/ai.yml

ChatterBot now supports the ability to add tags to any statement.
For example:
statement.add_tags('sentiment:POS:0.8')

The filter method on the storage adapter can also be used to search for statements that have a given tag.


extensions.json does not use "JSON with comments" mode

testing #39588
create a new file extensions.json in a .vscode folder
result: language mode is JSON
expected: JSON with Comments
That said, comments are allowed in this file along with trailing commas.

If comments are accepted, then all is ok.
As said the language mode is lying here, that's expected.


[Chore] Update pretty-env-logger to 0.5

Hi, please upgrade pretty-env-logger to 0.5
Crate:     atty
Version:   0.2.14
Warning:   unsound
Title:     Potential unaligned read
Date:      2021-07-04
ID:        RUSTSEC-2021-0145
URL:       https://rustsec.org/advisories/RUSTSEC-2021-0145
Dependency tree:
atty 0.2.14
└── env_logger 0.7.1
    └── pretty_env_logger 0.4.0
        └── fred 6.3.0

Updated in https://github.com/aembke/fred.rs/releases/tag/v6.3.1


Note find_packages backwards incompatible change

Also add a test for the new behaviour.

Thanks for the merge!


File System Route API return null

Hi,
I have a problem with gatsby and new File System Route API, it successfully generate pages by slug but graphql query output is null.
File structure:
└── src
├── co-bylo
│   ├── {StrapiAkce.slug}.tsx
{StrapiAkce.slug}.tsx
import React from "react"
import { graphql } from "gatsby"
const CoByloPage = ({ data }: any) => {
  console.log(data)
  return

}

export const query = graphql`
  query TestQuery($id: String) {
    strapiAkce(slug: { eq: $id }) {
      id
      eventName
      content
      slug
    }
  }

export default CoByloPage

Console.log

Thank you for great plugin.

I haven't checked out the new File System Route API, but do you get any data from the allStrapiAkce in the GraphQL explorer on http://localhost:8080/___graphql? And have you enabled preview on the plugin alternatively published the Akce document in Strapi?

Yes I get data in GraphQL explorer and I have enabled preview.
I tried useStaticQuery and I see data:

I checked it and it works! Thank you for great work


Assign a unique identifier when installing or using Gauge

Generate a unique identifier for gauge installation to enable analytics on Gauge.
In the future, if a user opts-in to participate, the team can use this for identifying feature usage, support, and adoption.
Display the identifier when along with the version.
$ gauge -v
Gauge version: 0.8.4 (xxx-xxxx-xxxxx-xxxx)

Plugins
-------
html-report (4.0.0)
java (0.6.1)
python (0.2.0)
ruby (0.4.0)
spectacle (0.1.2)

Where xxx-xxxx-xxxxx-xxxx is the identifier
Generate the identifier, if not available, while running Gauge commands.

[ ] The ID is generated the first time Gauge is installed/updated
[ ] Does not change when Gauge is updated later manually
[ ] Does not change when Gauge is updated later using a package manager
[ ] Works as expected on all supported OS


add ActiveDeadlineSeconds for sparkapplication

fix #686
/assign @liyinan926

@wackxu are you still interested in getting this in?

@liyinan926 Yes, I am sorry that I am so busy and I will do it this weekend


MapSingleton, MapClass of Robotlegs not recognised in Haxe

@peteshand
Hi
I am stuck at a very crucial point and seems like a dead end for me.
I have got many robotlegs mappings in my as3 code like :
m_context.contextInjector.mapSingleton(abc);
m_context.contextInjector.mapSingleton(xyz);
m_context.contextInjector.mapClass(test, test1);
m_context.contextInjector.mapClass(test2, test3);
contextInjector above returns IInjector.
In as3 everything works fine, but in Haxe i get the following error.
Error : IInjector has no field mapSingleton
Same error for mapClass : IInjector has no field mapClass
Haxe does not recognise mapSingleton, mapClass etc… PLEASE HELP

@peteshand
Awaiting your kind response at the earliest. Thanks

Hey there
It could be a DCE (dead code elimination) issue. Are you using openfl, is so can you share you project.xml / application.xml file, or check that you have dce set to 'no'
<!--<haxeflag name="-dce full"/>-->
<!--<haxeflag name="-dce std" />-->
<haxeflag name="-dce no"/>

If that is not the issue can you provide the whole class where you are having problems.


log when Shard Manager is fully started

When start shard manager, we need a log that it is fully initialized.
Now, shard manager logs Shard Manager loaded when it makes ShardManager.live
But, after making ShardManager.live,  it makes api through Server.run.
So I'm confused if it's fully initialized.

As I remember, zio-http didn't have a hook for the that but maybe there is now. I will double check.

https://zio.github.io/zio-http/docs/v1.x/dsl/server/#start-a-zio-http-server-with-custom-configurations
Can we use the make method?

And we need a log that shard manager stop. I saw the redis release log and knew that the server was dead.

Yeah, sounds good!


crypto/tls: Deprecate tls 1.0 and tls 1.1

According to : https://tools.ietf.org/html/draft-ietf-tls-oldversions-deprecate-00

I signed it!

Try again.


uv_udp_init_ex cost 20ms or  more time on linux

Version: I tested on  v1.49.1 v1.48.0
Platform:  Linux   5.10.0

I use mediasoup as WebRTC SFU . However some request cost too much time.
Here is the Code sample:
MS_TIME_TRACE();
err = uv_udp_init_ex(DepLibUV::GetLoop(), reinterpret_cast<uv_udp_t*>(uvHandle), UV_UDP_RECVMMSG | AF_INET);
MS_TIME_TRACE();

it will cost 20~50ms for sometimes.  It's normal in most time.

@ibc You should also be aware of this.

No idea, other than saving all tracing output and going through it when you spot the problem...

it's turn out socket create cause the problem
/* Open a socket in non-blocking close-on-exec mode, atomically if possible. */
int uv__socket(int domain, int type, int protocol) {
  int sockfd;
  int err;

  uint64_t t1=uv_hrtime();

#if defined(SOCK_NONBLOCK) && defined(SOCK_CLOEXEC)
  sockfd = socket(domain, type | SOCK_NONBLOCK | SOCK_CLOEXEC, protocol);
  uint64_t t2=uv_hrtime();
  if (t2-t1>1000000)
    fprintf(stderr,"uv__socket SOCK_NONBLOCK %d\n",t2-t1);
  if (sockfd != -1)
    return sockfd;

  if (errno != EINVAL)
    return UV__ERR(errno);
#endif

log show
uv__socket SOCK_NONBLOCK 22497842  //22ms
uv__socket SOCK_NONBLOCK 42722081  //42ms

😭

That's one syscall so I guess you'll need to dive down to the kernel to find out why :-/

I'll go ahead and close this as not-our-bug. If you're using a LSM, that'd be where I'd start looking first, and otherwise it's time to whip out perf record or perf top.


pasting over selection inserts some other things or nothing

when I make a selection and then paste some text from clipboard (Ctrl+V) over it, it:

inserts nothing and clears the selection OR
inserts the text from clipboard plus some text right from the selection

(Chrome 12)

https://github.com/balupton/mercury/issues/27


Datepicker short month

I'm trying to use short month names in the monthpicker.  I thought it looked straightforward using formatMonth but am not getting any results.
`
@Component({
selector: 'datepicker',
template:

})
export class Datepicker {
public dt:Date = moment('2016-01-01', 'YYYY-MM-DD').toDate();
public monthFormat = "MM"
}`

could you please confirm that this is still an issue? or even better, could you give plunker demonstrating the issue? I tried to reproduce it but [formatMonth] works for me.


Source variables for Etcdctl by default

FEATURE REQUEST / IDEA REVIEW:

Environment:

Cloud provider or hardware configuration: VMware environment

OS (printf "$(uname -srm)\n$(cat /etc/os-release)\n"):

Linux 4.14.19-coreos x86_64
NAME="Container Linux by CoreOS"
ID=coreos
VERSION=1632.3.0
VERSION_ID=1632.3.0
BUILD_ID=2018-02-14-0338
PRETTY_NAME="Container Linux by CoreOS 1632.3.0 (Ladybug)"
ANSI_COLOR="38;5;75"
HOME_URL="https://coreos.com/"
BUG_REPORT_URL="https://issues.coreos.com"
COREOS_BOARD="amd64-usr"

Version of Ansible (ansible --version):

ansible 2.5.0

Kubespray version (commit) (git rev-parse --short HEAD):
daeeae1a

Network plugin used: Calico
Anything else do we need to know:
By default we need to create a manual file to source the Etcd variables so we can use Etcdctl as it should. For instance I need to create a file with some environment variables to change the API version to 3 and setting my Cert, Key and CA file. The files does look like this (/etc/profile.d/etcd_env.sh):
export ETCDCTL_API=3
export ETCDCTL_CACERT=/etc/ssl/etcd/ssl/ca.pem
export ETCDCTL_CERT=/etc/ssl/etcd/ssl/admin-m1.jeffdesc.be.pem
export ETCDCTL_KEY=/etc/ssl/etcd/ssl/admin-m1.jeffdesc.be-key.pem

Without this I can't perform Etcdctl commands. I don't want to source them on every command.
However if we need to deploy this on every asset (master/worker) to use Etcdctl, this can be a little painful/waste of time. In case this is the way to work (instead of sourcing them on every command). I would create a PR for this. But I want some feedback if you guys are behind this idea.

This is not an issue. Adding the env to profile is rather a security concern. I would not recommend it at all.

How are you interacting with this @woopstar? Do you source those variables every time you need them or do you have another mechanism to use them?


Image not loading in Company Communicator V5.0 notification

We have noticed a peculiar issue with  Company Communicator V5.0 notification where the image is not loading in the user app notification card if it is from the below url.
https://s7.gifyu.com/images/TestImage.png
https://s4.gifyu.com/images/TestImage.png
But There is no issue if we use the image url from below location. if you check the url then the host names are different but the domains are same.
https://s10.gifyu.com/images/TestImage.png
https://s9.gifyu.com/images/Format-Background.gif

Hi @EYSue ,
We are closing this as the issue got resolved over the call. Please feel free to reach out to us on the deployment or functionality issues of Company Communicator app by logging the new issue.


tf.fill does not have dtype

tf.fill
Does not provide a dtype keyword like tf.ones, tf.zeros.  Is there a particular reason or is just missing ? You can force it by casting the number but I don't think is clean tf.fill([10,10], np.int16(8)).
EDIT: seems also tf.linspace and tf.range

@rmlarsen Could you take a quick look pls?

Sorry for missing this one. I don't think this is a good change. By leaving the explicit casting outside the op, the user is unable to provide a value that is not  in the range of the desired type, and therefore less likely to be surprised by getting back a tensor with a different value than the one they specified.

Automatically closing due to lack of recent activity. Please reopen when further information becomes available.

Automatically closing due to lack of recent activity. Please reopen when further information becomes available.


print chaos mesh's log when log level is debug

now chaosd will print the log in chaos mesh, most of them only used when debug
maybe we can add a judgement before here, execute it only when log level is debug
https://github.com/chaos-mesh/chaosd/blob/693b6f7cc88bf65746a9d1ba87494879a50ec05d/cmd/main.go#L68

is this open for contribution,please assign

how to test this?


Replace maintainer by label in Dockerfiles

The maintainer instruction is deprecated, see:
https://docs.docker.com/engine/reference/builder/#maintainer-deprecated
Also unified the maintainer value. Please check if this is correct, because in one you used<EMAIL_ADDRESS>in another just lightning.engineering without laolu@, while according to some commits in the repo the email addresses of your companies' engineers seems to be<EMAIL_ADDRESS>

@philippgille needs a rebase to run the tests!

Thanks for having a look at this small and old PR :)
-> Rebased


Title block in templates

In the base template add a title block to let other templates set their own title in the head tag
Go through all templates and fill this title block according to the page they are responsible to show.
You can also use the context sent to the template if it is needed

completed in #123


docs(update): Updating docs for go modules

Why is this PR required? What issue does it fix?:
Updates the docs
What this PR does?:
Updates the developer documentation
Does this PR require any upgrade changes?:
No
If the changes in this PR are manually verified, list down the scenarios covered::
N/A
Any additional information for your reviewer? :
N/A
Checklist:

[ ] Fixes #
[x] PR Title follows the convention of  <type>(<scope>): <subject>
[ ] Has the change log section been updated?
[ ] Commit has unit tests
[ ] Commit has integration tests
[ ] (Optional) Are upgrade changes included in this PR? If not, mention the issue/PR to track:
[ ] (Optional) If documentation changes are required, which issue on https://github.com/openebs/openebs-docs is used to track them:

Codecov Report

Merging #441 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #441   +/-   ##
=======================================
  Coverage   43.63%   43.63%
=======================================
  Files          61       61
  Lines        2947     2947
=======================================
  Hits         1286     1286
  Misses       1559     1559
  Partials      102      102

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cc85a4...6571006. Read the comment docs.

@akhilerm -- can you review and merge this one please.


Screenshots sometimes causes segfault

When in fullscreen the engine crashes at FreeImage_ConvertFromRawBits.
Too big allocation maybe?

Check trelloboard for bugs instread


Swap Detection

On OSX and Linux, there will be an issue created if swap is used.
On Linux it's only if our process uses swap, on OSX it's if the system uses swap.
https://github.com/rethinkdb/rethinkdb/issues/5235

One thing (and possibly the main thing) that will need updating is http://rethinkdb.com/docs/system-issues/

Example issue document:
{
    "critical": false ,
    "description": "The following server encountered a memory problem: the_shadow_local_j4s.

     The message reported is: Data from a process on this server has been placed into swap memory in the past hour. If the data is from RethinkDB, this may impact performance.

    " ,
    "id": "0755df1a-1a62-5b60-88bb-dd8a10c6f87f" ,
    "info": {
        "message": "Data from a process on this server has been placed into swap memory in the past hour. If the data is from RethinkDB, this may impact performance." ,
        "servers": [
            "the_shadow_local_j4s"
        ]
    } ,
    "type": "memory_error"
}

Is there a way to disable this warning? We're intentionally using swap on SSD for our workload. Unless I'm misunderstanding the performance impact, and no swap (with no additional RAM) would be better than some swap?
Obviously trading RAM for swap would be ideal, but we're (1) performing fine already and it's (2) cost-prohibitive for us to scale the RAM on this node.

@coffenbacher There is not currently. RethinkDB can be quite sensitive once parts of it are put into swap, so the warning is usually warranted. For example disconnects due to heartbeat timeouts are extremely common once parts of the rethinkdb process end up in swap.
Could you reduce the RethinkDB cache size to below the default minimum value of 100 MB to maybe reduce the likelihood that it has to go into swap? This would probably give you a better performance trade-off.
Regardless of whether there might be a way to reduce the usage of swap in your use case or not, is this issue getting in your way?

Okay! Great to know. We will adjust our cache size to keep it out of swap - mistaken assumption on my part that some swap is better than no swap.
Either way, the warning wasn't an issue other than being persistently glaring in the UI. It seems it's warranted anyways, so this is correct behavior. Thanks for the help.


use compiler cache in ++ap-slam check

Unfortunately, this still introduces slowness - we're going to have to hold off on this stuff until next week

When you get a chance, can you confirm that this isn't slow so it can go back in?

Will do, the slowness would be at least as noticeable as the event log one
was right?
On Tuesday, 16 August 2016, Raymond Pasco<EMAIL_ADDRESS>wrote:

When you get a chance, can you confirm that this isn't slow so it can go
back in?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/urbit/arvo/pull/243#issuecomment-240233638, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABxXhm4yzVygUOBBkD5fkLGRzOtXVpjIks5qgiIZgaJpZM4JisCR
.

It's supposed to be super slow, yeah

Rebased on top of master and tweaked to not be performing an uncached slot.


Bad Request: Invalid filter clause

I am using POSTMAN to call Microsoft Graph APIs. I am trying to subscribe to presence for multiple users. It is mentioned in document in order to subscribe to changes to multiple user presences use this url  /communications/presences?$filter=id in ({id},{id}...)
Request Url ;https://graph.microsoft.com/beta/subscriptions
Request Type: POST
request body(raw):
{
  "changeType": "updated",
  "notificationUrl": "https://d3a8ebc3581d.ngrok.io/presence-notify/",
  "resource": "/communications/presences?$filter=id in (abcd-efgh-4856-a935-c9a2f685xyz,abcd-efgh-47f8-9d79-eacb0fd6xyz)",
  "expirationDateTime": "2020-09-22T07:37:13Z",
  "clientState": "secretClientState"
}

I am calling this API on behalf of user i.e i am using UserAccessToken. This is Response:
{
    "error": {
        "code": "BadRequest",
        "message": "Invalid filter clause",
        "innerError": {
            "date": "2020-09-21T16:24:50",
            "request-id": "2cf476f0-2270-417f-a987-5c5bbc92a351",
            "client-request-id": "2cf476f0-2270-417f-a987-5c5bbc92a351"
        }
    }
}

P.S: I have changed first few and last few characters of both the user ids. So it's not an issue.

Hey @datasleek
Thanks for reaching out. Here is a few things I'd like you to try to understand the issue better:

Can you try with single quotes around the guids?
Can you try with a single id?(with this pattern)
Can you try with a single id? (with /communications/presences/id)
What happens if you try with IncludeResourceData set to true and the encryptionCertificate?

@datasleek I've raised an internal service issue on this with the engineering group. I'll get back soon on this.

@datasleek please note the ids in the list need to be wrapped by single quote.
Incorrect:
"resource": "/communications/presences?$filter=id in (abcd-efgh-4856-a935-c9a2f685xyz,abcd-efgh-47f8-9d79-eacb0fd6xyz)",
Correct:
"resource": "/communications/presences?$filter=id in ('abcd-efgh-4856-a935-c9a2f685xyz','abcd-efgh-47f8-9d79-eacb0fd6xyz')",


Don't crash when unregistering a feature that doesn't exist

Note: all other features follow the same practice in their unregister() methods -- if the features doesn't exist, do nothing and don't throw errors.

Makes sense to make this consistent.