List of trainers

@elysabethc5 - Do you have a complete list of Connect 5 trainers? Is this stored on a database?

I know I’m not allowed to text but haven’t had internet
I’m be in touch tomorrow first thing
Sent from my iPhone
On 6 Nov 2018, at 15:40, Joe Friel <notifications<EMAIL_ADDRESS>wrote:
Assigned #4https://github.com/techforbetter/connect5/issues/4 to @elysabethc5https://github.com/elysabethc5.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHubhttps://github.com/techforbetter/connect5/issues/4#event-1949292376, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AquzNYGLvH5clgVzdJw5oVSC-fg7Ewf8ks5usa2qgaJpZM4YQs6v.
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/techforbetter/connect5","title":"techforbetter/connect5","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/techforbetter/connect5"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Assigned #4 to @elysabethc5."}],"action":{"name":"View Issue","url":"https://github.com/techforbetter/connect5/issues/4#event-1949292376"}}} [ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/techforbetter/connect5/issues/4#event-1949292376", "url": "https://github.com/techforbetter/connect5/issues/4#event-1949292376", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } }, { "@type": "MessageCard", "@context": "http://schema.org/extensions", "hideOriginalBody": "false", "originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB", "title": "Re: [techforbetter/connect5] List of trainers (#4)", "sections": [ { "text": "", "activityTitle": "Joe Friel", "activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png", "activitySubtitle": "@thejoefriel", "facts": [ ] } ], "potentialAction": [ { "targets": [ { "os": "default", "uri": "https://github.com/techforbetter/connect5/issues/4#event-1949292376" } ], "@type": "OpenUri", "name": "View on GitHub" }, { "name": "Unsubscribe", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n"commandName": "MuteNotification",\n"threadId": 407031471\n}" } ], "themeColor": "26292E" } ]

No worries. Tomorrow is fine. And communicating via comments like you've done is absolutely perfect - you're becoming a Github pro already!

i have spoken with RSPH
we do use ID numbers for the people we train (national connect5 trainers ). they then go on and deliver the trianing in thier organisation or setting and use the same evaluation however, the trainer ID doesnt get passed on and so we are linking the evlaution data up not with ID but with date of training, name of trianer or region trained in. does that make sense ? somehow we need a better system to link email with ID
we might run into information governance problems.  RSPH say they can not give you survey monkey log in as it contains email details . what do you need it for ? might be able to make an argument for it
simialar with the national trianers data base , we do have them all but RSPH might not pass them on. in which case we will have to email everyone and get their permission, which if we have to do it we have to do it

Hi Elysabeth, I'm going to respond across the different issues assigned to you if that's ok just to keep the different topics clear.
Just to check, they are unable to share the list of connect 5 trainers?

i can double check but as i understanding it becasue it contains personal email data the IG means they would need to ask for permission. i am douuble checking this now.

can i just check with you. before i ask RSPH . if you could do you want the national conenct5 trainers list of emails?

Actually we don't desperately need the list now as we've worked out a neater way to link the survey to the trainer by generating a unique url for each survey the trainer sends out. It was just that if we had the names, when the participant enters their name in the survey we could potentially make this an autocomplete feature to help the participant and ensure the name entered is 100% correct.
However, as I say, we've worked out a good way to link via the survey urls so this isn't essential at all!

excellent.


Add more object kinds to sorted installation order

Related to #2199 and #2200, address the following Kubernetes object kinds in Tiller's installation and uninstallation order:

CronJob
LimitRange
ReplicaSet
ResourceQuota
StatefulSet

Furthermore, adjust the installation and uninstallation order to better respect likely dependencies. Bare pods remain a difficult one to place properly in both sequences.
I revised the uninstallation order in particular to be more closely symmetric—at least in several of its runs—with the installation order. It is hard to tell how much of the current two sequences are carefully considered, so let me know if you both agree with my proposed order and whether there are comments that we can add to help future maintainers understand what must be left in place. It's really a topological sort of a graph we haven't defined, but there are several such potential sorts of that graph.

@seh This looks good from a code perspective, but I don't feel comfortable with just me signing off on this. I would like @technosophos or @adamreese's opinions on this when they get back


Feature at least one screenshot with dynamic shadows in the homepage

(ideally dynamic shadows and bloom ;))

Some of the screenshots from the 5.7.0 release post could be good candidates: https://blog.minetest.net/2023/04/08/5.7.0-released/#more-screenshots

I will do it.


Enable Continuous Integration using Circle CI and disable KVM acceleration

This PR will enable CI testing using CircleCI, and disabled KVM acceleration.
The KVM acceleration is unfortunately unavailable inside the container, but it should be fine to disable it anyway.
The script will be slightly slower, but a lot more portable.

For some numbers, I timed the time this script takes with and without acceleration.
With KVM: +- 5 seconds, without: +- 30 - 50 seconds (lot more variety).

Thanks!


Can I integrate it with Angular

I tried to integrate it with my angular code, but I failed.
I think the package is for nodejs, or am I wrong.
Sorry if this issue looks silly.  Can you please guide me with if there is way to integrate it with angular.

Correct, it is only meant for Node.js.
My advice would be to create an API route on your server to generate words.
You could fork it and rework it to run on the client but I wouldn't recommend it since the word lists are  large and would make your app too big!

Thank you so much for responding.
I was going to make an api, but I found one online so I  didn't try it.
https://random-words-api.vercel.app/word


docs: List instances of stage file concepts, dvc run/checkout/repro for example review and update to 1.0

From #1255 :

Create a list of places where the concept of stage file(s) and dvc run/checkout/repro are used...

List of places here, including initial example:
Get Started

[x] https://dvc.org/doc/start/data-pipelines
[x] https://dvc.org/doc/start/experiments
[ ] Several cmd examples/links need updating (see Command Reference section below)

User Guide

[x] https://dvc.org/doc/user-guide/dvc-files-and-directories
[x] https://dvc.org/doc/user-guide/managing-external-data
[x] https://dvc.org/doc/user-guide/external-dependencies
[x] https://dvc.org/doc/user-guide/related-technologies
[x] https://dvc.org/doc/user-guide/large-dataset-optimization
[x] https://dvc.org/doc/user-guide/merge-conflicts
[x] https://dvc.org/doc/user-guide/dvcignore

Use Cases

[x] https://dvc.org/doc/use-cases/versioning-data-and-model-files/tutorial

Install

[x] https://dvc.org/doc/install/completion - #1766

Command Reference

[x] https://dvc.org/doc/command-reference/run
[x] https://dvc.org/doc/command-reference/repro
[x] https://dvc.org/doc/command-reference/remove
[x] https://dvc.org/doc/command-reference/freeze - #1766
[x] https://dvc.org/doc/command-reference/unfreeze- #1766
[x] https://dvc.org/doc/command-reference/update
[x] https://dvc.org/doc/command-reference/dag - #1766
[x] https://dvc.org/doc/command-reference/fetch
[ ] https://dvc.org/doc/command-reference/import - ok, get started examples/links need updating
[ ] https://dvc.org/doc/command-reference/import-url - ok, get started examples/links need updating
[ ] https://dvc.org/doc/command-reference/commit - ok, get started examples need updating
[x] https://dvc.org/doc/command-reference/pull
[x] https://dvc.org/doc/command-reference/params
[x] https://dvc.org/doc/command-reference/params/diff - run example out of date (fixed in #1908)
[x] https://dvc.org/doc/command-reference/push
[ ] https://dvc.org/doc/command-reference/checkout - ok, get started examples need updating
[ ] https://dvc.org/doc/command-reference/metrics - ok, get started example/link needs updating
[x] https://dvc.org/doc/command-reference/metrics/diff
[ ] https://dvc.org/doc/command-reference/metrics/show - references stage file example from get started
[x] https://dvc.org/doc/command-reference/status
[x] https://dvc.org/doc/command-reference/plots/show
[x] https://dvc.org/doc/command-reference/plots/modify
[x] https://dvc.org/doc/command-reference/install - #1766
[x] https://dvc.org/doc/command-reference/config
[ ] https://dvc.org/doc/command-reference/diff - ok, 2nd example needs verification

Second part from #1255, which may be better as second issue:

We should review all those docs to make sure the use of dvc run/etc and YAML examples are updated to 1.0.

(Items in list above will be checked when checked/updated.)

@jorgeorpinel I'll list the issues as shown. Should the second part remain here or be it's own issue?

Nice, thanks @jeremydesroches. Let's keep the 2nd part here for now. I edited the description above a bit.

Hey @jeremydesroches I see all the check boxes are marked now, but only a few are addressed in PR #1766. Can you explain what happened? Thanks

Yes, I reviewed all the items in the list and marked them as follows:

checked off items as when the examples and dvc run/etc applied 1.0 usage
added link to PR "#1766" where I made edits following review
checked off "ok" items but added notes where examples need other updates (out of date with current getting started, etc.)
left unchecked where examples did not apply 1.0 usage and need updates as part of this issue

Got it. Glad to see most of it is done then. Are you planning to finish this one off then? Or would you rather turn to SEO work at this point?

Happy to finish off the updates for the unchecked items. I think the checked items that need getting started references updated should be taken up in a new issue (or an appropriate existing one).

On Sep 13, 2020, at 11:08 PM, Jorge Orpinel<EMAIL_ADDRESS>wrote:

Got it. Glad to see most of it is done then. Are you planning to finish this one off then? Or would you rather turn to SEO work at this point?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

OK. Also the 2nd part may be pending (dvc run/repro and YAML examples).

@jeremydesroches do you think we can finish addressing this issue? The few checkboxes left seem pretty straight-forward.

@jeremydesroches do you think we can finish addressing this issue? The few checkboxes left seem pretty straight-forward.

Yep @jorgeorpinel I'm on it. I'll work through the last unchecked items and verify/update the get started examples.

Hey @jorgeorpinel and @shcheklein, I'm trying to verify the unchecked items here. They all use the getting started example, and there's a new error when I run dvc fetch or dvc checkout after cloning the example repo.
ERROR: failed to pull data from the cloud - Lockfile 'dvc.lock' is corrupted.
I've tried starting over and checked my environment. Did something change with the latest updates to the example repo? I'll work on something else in the meantime. Thanks!

there's a new error when I run dvc fetch or dvc checkout after cloning the example repo.
ERROR: failed to pull data from the cloud - Lockfile 'dvc.lock' is corrupted.

Shot. It looks like the example get started repo isn't compatible with the latest DVC version. I opened iterative/example-repos-dev/issues/17

However that repo is no longer used directly in https://dvc.org/doc/start so you could just follow the steps manually @jeremydesroches, no?
BTW

checkout - ok, get started examples need updating

That command is only used in https://dvc.org/doc/start/data-versioning and seems correct (wouldn't hurt to double check though).

looks like the example get started repo isn't compatible...

@jeremydesroches please install the latest version (1.10.1) BTW. You may need to download from https://github.com/iterative/dvc/releases/ as it seems the download button in the home page has them outdated (#1964)

@jeremydesroches please install the latest version (1.10.1) BTW.

Got it. Thanks for figuring this out for me. Brew is working now too.

@jeremydesroches you can strikethrough or remove the bullets involving "get started" because that will have to be rewritten soon anyway. Is there anything else left here? Thanks

Is there anything else left here?

OK @jorgeorpinel, struck out the "get started" bullets. Nope, nothing left here.

Well, thanks for taking care of it!


dart2js-minified-strong-linux-x64-d8 crashes on language_2/control_flow_collections/for_test

With control flow collection tests unskipped, the dart2js-production-linux-d8 configuration of the dart2js-minified-strong-linux-x64-d8 builder crashes on language_2/control_flow_collections/for_test and then throws an exception when it cannot find the crash dumps. This prevents test approvals, so the builder remains red on all subsequent tryjobs as well as the SDK console.
Example
cc @athomas

A possible workaround is to mark the test as Crash in the status files. It
will still run, but Crash suppresses the core-dump archiver.
On Tue, Apr 2, 2019, 23:15 Mayank Patke<EMAIL_ADDRESS>wrote:

With control flow collection tests unskipped, the
dart2js-minified-strong-linux-x64-d8 builder crashes on
language_2/control_flow_collections/for_test and then throws an exception
when it cannot find the crash dumps. This prevents test approvals, so the
builder remains red on all subsequent tryjobs as well as the SDK console.
Example
https://ci.chromium.org/p/dart/builders/try/dart2js-minified-strong-linux-x64-d8-try/11649
cc @athomas https://github.com/athomas
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dart-lang/sdk/issues/36442, or mute the thread
https://github.com/notifications/unsubscribe-auth/ATEUh-EwXlK7kw6uXqxalLJ6OAG4dE8Vks5vc8hfgaJpZM4cZI4K
.

Update: The failing test code is now isolated here: https://github.com/dart-lang/sdk/blob/11a3dd7332f03c82fc01c19af3e75209ebb725a8/tests/language_2/control_flow_collections/for_non_bool_condition_test.dart#L10-L14
The status file marks this test as Crash:
https://github.com/dart-lang/sdk/blob/11a3dd7332f03c82fc01c19af3e75209ebb725a8/tests/language_2/language_2_dart2js.status#L70-L71


D407 / D405: false positive

D407 [*] Missing dashed underline after section ("TODO")
   |
 3 | / """
 4 | | foo.
 5 | |
 6 | | Follows <https://blah>.
 7 | |
 8 | | TODO:
 9 | | *        nicht beenden
10 | | *        unmaintained
11 | | """
   | |___^ D407

is not detected by pydocstyle.

I get D405 and D407 on that docstring with pydocstyle:
foo.py:1 at module level:
        D100: Missing docstring in public module
foo.py:2 in public function `f`:
        D212: Multi-line docstring summary should start at the first line
foo.py:2 in public function `f`:
        D405: Section name should be properly capitalized ('Todo', not 'TODO')
foo.py:2 in public function `f`:
        D413: Missing blank line after last section ('Todo')
foo.py:2 in public function `f`:
        D407: Missing dashed underline after section ('Todo')

I think it's also "correct" in that TODO is an official Google docstring section header.


set up jobpost api endpoints

Description
Set up job post api endpoints to prep for frontend. No errors so far.
Type of change
Please delete options that are not relevant.

[x] New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] My code has been reviewed by at least one peer
[ ] I have commented my code, particularly in hard-to-understand areas
[x] My changes generate no new warnings
[x] New and existing unit tests pass locally with my changes

We'll need a tags section I believe as well

Thanks @groov1234! Yeah, I'm working on those to be fixed first before this can be merged. I'm trying to get the createsuperuser to work to test again after pulling recent changes.

Excellent testing documentation.  Great work.  Merging PR.

Due to environment issues, closing this pull request.


Decimal value

Is there an way we can represent value in decimals, like 40.5 {unit} ? Cause i need to use it with kg

Its done using prop Fraction digits


GexService.onClose() never is called when reloadAll()

When Get.reloadAll() is called, GetxService recreates with full life circle - calling constructor, onInit, onReady.
But onClose is not called before.
So for example when i subcribe for streams in onInit, i suppose to unsubscribe in onClose, but due to behavior mentioned above no unsubscribing happened and there are their duplications in memory.
Here is my case:
class MyService extends GetxService {
  MyService(){
    debugPrint('$now: MyService.MyService');
  }

  @override
  onInit() {
    super.onInit();
    debugPrint('$now: MyService.onInit, some subscriptions');
  }

  @override
  onClose() {
    debugPrint('$now: MyService.onClose, some unsubscriptions');
  }
}

/// Somewhere earlier
Get.lazyPut(() => MyService())

/// Somewhere in the code
Get.reloadAll();

One can see this here on screenshot:
After MyService was reloaded no onClose was called.

Documentation of GetxService said like this

GetxService is not automatically disposed (nor can be removed with Get.delete()). It is ideal for situations where, once started, that service will remain in memory, such as Auth control for example. Only way to remove it is Get.reset().

so, if you wanna invoke onClose of GetxService, try Get.reset()


Python 3 compatibility

Hi there :)
I like your library, but sadly it is only available for python 2. Can you add support for python 3?
Thanks!

Hi @oxivanisher
I don't have any problems with using this library in python 3.
Could you please show some error  message or something else to help me investigate the problem?

Oh sorry, @pvoznyuk I did not communicate clearly. Can you add it to pip3? ;)

@oxivanisher I can install it via pip3
pip3 install shortnumbers.
Can't you? What does it tell?

I do not know what I did this morning, but now I can find in pip 3.
Sorry for the inconvenience and have a nice evening.


rename all test tags to data-test

Rename all testing tags to data-test for consistency

Your review app has been deployed and is available at 'http://,<IP_ADDRESS>:80'.Learn More about how to test and provide feedback for the app.

Your review app has been deployed and is available at 'http://<IP_ADDRESS>:80'.Learn More about how to test and provide feedback for the app.

Your review app has been deployed and is available at 'http://<IP_ADDRESS>:80'.Learn More about how to test and provide feedback for the app.

Your review app has been deployed and is available at 'http://,<IP_ADDRESS>:80'.Learn More about how to test and provide feedback for the app.


General Grievance: Watch xn--2q1bo2fd4o7uk.net

General Grievance requests the watch of the watch_keyword xn--2q1bo2fd4o7uk\.net. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

xn--2q1bo2fd4o7uk\.net has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Mithical in Charcoal HQ


SAP HANA XS Advanced, Creating an HTML5 Module

Hi!
Validation in last step doesn't work for me. I suppose the right answer is

The button fades away

But all\any answer shows Incorrect message.

No answer was created in the rules file. @Lsubatin Can you fix?

Hi, Thanks for pointing this out. It is fixed now.
Best,
Lucia.


Use find-java-home to find java/javac

OS X by default does not provide JAVA_HOME variable and there's this fairly useful npm pacakge find-java-home to figure out java home on any platform.
Notice that I have a slight hack in this patch:
    JAVA = JAVA_HOME.trim() + '/bin/java';
    JAVAC = JAVA_HOME.trim() + '/bin/javac';

trim() is required since find-java-home probably has a bug and returns value with \n in the end.
I'll try to figure out what's wrong with that and maybe submit PR to find-java-home maintainer, but for now, here's this PR for your consideration.

Thanks for your PR.

I had a closer look at your pull request. I'd like not to pull it in, because

replaces a simple and robust solution (i.e. define JAVA_HOME as an environment variable) with something I cannot test (got no Mac OSX and no Windows either).
adds find-java-home, a dependency with known issues (you mentioned the trim() hack).

I added a hint on where to point JAVA_HOME to on Mac OSX to the documentation (fe7796dd6d0cd8d4b0cfee9c6640f501bc7f0af1).
As far is I know most JDK distributions seem to set this variable.

Hi,

find-java-home looks at JAVA_HOME first and then falls back to alternatives
Mac OSX Java install does not appear to configure it during install

I just didn't want to add extra step for our dev team to run test suite (we use your package to validate some xml documents which is great). We can rely on our own fork though so it's fine, but I thought it's not a bad idea to use find-java-home.


Feature/next/new header

Closes #000 (replace with the issue ID(s) of any related issues that will be closed when this PR is merged)
Description
What does this PR do or fix?
Checklist
Indicate what checks or tests you have completed here. You can copy-paste relevant items from our Pull Request checklist.

Hey guys. Thanks for the comments. I actually didn't change much in the files so it looks like everything you guys want to be reverted was most of the changes anyway. I'll just delete this branch and the pull request.

Yeah, the layout of the header versus the current website has barely changed.
That being said, I think the nav links are more spaced out than they used to be, so your change to the nav-menu's style is still needed.
The pages' JSON updates I suggested are optional. Feel free to add those if you wish, or not. What we show in the pattern library is meant to be examples, not necessarily an exact replica of the Buildit website.


add python3 type annotations

use either; https://github.com/Instagram/MonkeyType
or https://github.com/dropbox/pyannotate
the instagram one seems better since it doesn't generate type comments.

depends on https://github.com/komuw/sewer/pull/73


update document url

[x] Is this related to documentation?
no longer Zend\Stdlib\Hydrator

Thanks, @sasezaki!


New actions to list and remove images

Address https://bugs.launchpad.net/layer-docker-registry/+bug/1808200 with an action that lets operators remove registry images.  This is effectively a wrapper around docker rmi.
Let the people list images while we're at it.  This is effectively docker images.

These actions have been released in charm rev 125, currently in the beta channel:
https://jujucharms.com/u/containers/docker-registry/125

Addressed review comments (🍰  @tvansteenburgh) and updated a bit of action output.  Ready for re-review.
## good listing
$ juju run-action --wait docker-registry/0 images repository=ubuntu
unit-docker-registry-0:
  id: f98c5411-dcc0-4cff-88bf-f558e2c34739
  results:
    output: |
      REPOSITORY          TAG                 IMAGE ID            CREATED             SIZE
      ubuntu              18.04               94e814e2efa8        6 weeks ago         88.9MB
  status: completed
  timing:
    completed: 2019-04-26 21:33:52 +0000 UTC
    enqueued: 2019-04-26 21:33:49 +0000 UTC
    started: 2019-04-26 21:33:52 +0000 UTC
  unit: docker-registry/0

## bad listing
$ juju run-action --wait docker-registry/0 images options=-ouch
unit-docker-registry-0:
  id: 1c98bc5c-d02d-45bc-8a16-1a82dce7c69f
  message: |
    "docker images -ouch" failed with:
    unknown shorthand flag: 'o' in -ouch
    See 'docker images --help'.
  status: failed
  timing:
    completed: 2019-04-26 21:34:14 +0000 UTC
    enqueued: 2019-04-26 21:34:09 +0000 UTC
    started: 2019-04-26 21:34:13 +0000 UTC
  unit: docker-registry/0

## good remove
$ juju run-action --wait docker-registry/0 rmi image=ubuntu:18.04
unit-docker-registry-0:
  id: 9dd49ac6-9dd6-4374-8028-f5c5241b8bcd
  results:
    output: |
      Untagged: ubuntu:18.04
      Untagged: ubuntu@sha256:017eef0b616011647b269b5c65826e2e2ebddbe5d1f8c1e56b3599fb14fabec8
  status: completed
  timing:
    completed: 2019-04-26 21:34:32 +0000 UTC
    enqueued: 2019-04-26 21:34:30 +0000 UTC
    started: 2019-04-26 21:34:32 +0000 UTC
  unit: docker-registry/0

## bad remove
$ juju run-action --wait docker-registry/0 rmi image=ubuntu:18.04
unit-docker-registry-0:
  id: 80ff7494-ed1a-4da8-8f97-3fc371e68f73
  message: |
    "docker rmi ubuntu:18.04" failed with:
    Error: No such image: ubuntu:18.04
  status: failed
  timing:
    completed: 2019-04-26 21:36:38 +0000 UTC
    enqueued: 2019-04-26 21:36:37 +0000 UTC
    started: 2019-04-26 21:36:37 +0000 UTC
  unit: docker-registry/0

## it's gone
$ juju run-action --wait docker-registry/0 images repository=ubuntu
unit-docker-registry-0:
  id: 3c8fc59d-d4d6-4eb9-8393-28734b567605
  results:
    output: |
      REPOSITORY          TAG                 IMAGE ID            CREATED             SIZE
  status: completed
  timing:
    completed: 2019-04-26 21:34:46 +0000 UTC
    enqueued: 2019-04-26 21:34:45 +0000 UTC
    started: 2019-04-26 21:34:45 +0000 UTC
  unit: docker-registry/0


defaultLocale option in i18n.js is not working , always use the en locale

I try to set defaultLocale as other languages, say defaultLocale: 'de', but it is not working, unless I set the locale specially in controller as res.setLocale('de'), it will use the right locale.

Here again!
In my case I am with sails v0.11.2
Seems it is also not loading default local anyway.
I had to solve it with policies again like.
Created: api/policies/lang.js with below codes
module.exports = function(req, res, next) {
    res.setLocale('fr');
    next();
}

Then updated: config/policies.js
'*': [..., 'lang'],

Thanks

How can i load the default route '/' to load with default locale in it
ex: '/' loads http://mywebsite/login
how can i make it to be http://mywebsite/en/login

@jeswinjames24 I'm not sure if i18n-node supports url parsing but if you are interested, you can give sails-hook-gengojs a try. You can turn on url parsing in the options under:
header: { detect: {/*...*/} }. More info about gengo.js can be found at https://github.com/gengojs/gengojs.
Note: I am the author of gengo.js ;).


Only partial logs available via dashboard

Rob Herring reports that:
robher> padovan: There's logs in the link sashal provided, but they don't appear to be the right log. They just end at the u-boot prompt.
4:48 PM
 For what I use KCI for, it's unusable at the moment. I generally just want to get logs for every board that booted my build. With the old dashboard, I just had a (manual) list of log urls to open. Is there a rest API or something to get all the boards which ran and then their logs?
referencing reports like https://dashboard.kernelci.org/tree/29e0b98dc48caa296efa9855b991cc3205470ac4/test/maestro%3A6743f6a1923416c0c994896f?tableFilter={"buildsTable"%3A"all"%2C"bootsTable"%3A"failed"%2C"testsTable"%3A"failed"}&origin=maestro&currentPageTab=treeDetails.boots&diffFilter={"archs"%3A{"arm64"%3Atrue}}&treeInfo={"gitBranch"%3A"linus-next"%2C"gitUrl"%3A"https%3A%2F%2Fgit.kernel.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Fsashal%2Flinus-next.git"%2C"treeName"%3A"sashal-next"%2C"commitName"%3A"v6.12-9661-g29e0b98dc48ca"%2C"headCommitHash"%3A"edca003660f52bcaf5dd409dd80f933459d0b104"}&intervalInDays=7
If you click on the "Logs" on that page there's both an excerpt and a link to a compressed log, however neither of these includes the log messages indicated in the "Issues" on the main page for the test - the logs provided stop before any kernel messages are shown.
It's not clear to me if this is actually a dashboard issue or if the dashboard is faithfully reproducing the data it's getting from the database.

@helen-fornazier


comment: update comment for Scan

Thanks @lucklove Please add DCO to your commit.

@disksing Done


Support more detailed custom RBAC

I propose to prohibit to push the quick sync button. I want the feature to allow any operation (e.g. approve, pipeline sync, etc...), but not allow certain operations. Ultimately, I think this feature will be provided as extending RBAC.  I know it's hard and too complex implementation, but I think this feature is worth to provide. What do you think ?
If this feature is already implemented, I sorry.

We have RBAC based on resources and actions.
The actions supported by PipeCD's RBAC were not as fine-grained as you suggest. I am not quite sure whether to change the current design to satisfy your request (Besides, as you mention, implementation can be hard 😉 ).
So I propose waiting to see other users' reactions on this issue and deciding what to do afterward.


Viro3DObject: sometime does not respond to pinch and drag gesture

Hello Everyone

Development OS: Mac
iOS version (16.1) & Android Version : 9.0
ViroReact version : 2.23.0 and React Native version : 0.66.2
Device(s):iPhone 12 Pro, OPPO A31

Description
I have created an AR scene with ViroReact on both android  and iOS. At starting everything works perfectly on scene but after using is for something all added 3D object on screen just stop responding to pinch and drag but rotation of object can be done.
         <Viro3DObject                 source={modelItem.arUrl}                 type={modelItem.arType}                 materials={modelItem.arTexture ? modelItem.arTexture : 'pbr'}                 resources={modelItem.arResources}                 animation={{                   ...modelItem.arAnimation,                   run: this.state.runAnimation,                 }}                 lightReceivingBitMask={this.props.bitMask | 1}                 shadowCastingBitMask={this.props.bitMask}                 onClickState={this._onClickState(this.props.modelIDProps.uuid)}                 onClick={() => {                   if (modelItem.item) {                     this.props.mediaStore.sound = null;                     this.props.mediaStore.media = modelItem.item;                     this.props.mediaStore.modalVideo = true;                   }                 }}                 onError={this._onError(this.props.modelIDProps.uuid)}                 onRotate={this._onRotate}                 onPinch={(pinchState, scaleFactor, source) => {                   console.log('---------', modelItem.arType);                   this._onPinch(pinchState, scaleFactor, source);                 }}                 onLoadStart={this._onObjectLoadStart(this.props.modelIDProps.uuid)}                 onLoadEnd={this._onObjectLoadEnd(this.props.modelIDProps.uuid)}               />
Any help greatly appreciated.

@sbgiri downgrade viro to 2.22.0 and issues with gesture events should gone or at least should improve in a way...

I am also facing same issue.
I tried to get it fixed by using GestureHandlerRootView of react-native-gesture-handler but got error of attempted to add a non component child of type
so what's solution for this Viro3DObject: sometime does not respond to pinch and drag gesture isuue.


Win doc

documentation only
-details how to get the c++ test dependencies
-protobuf has some new build steps (cmake is now required)
-reflects new run_tests.py changes and directory layout

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

thanks for the review, I made your suggested changes
I don't know whether these build steps/test steps are still current, I haven't been playing with the code for a few months because windows c++ grpc is basically meeting my needs now (thanks!)

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

This PR is currently not up-to-date, are you planning to update it or should I close it for now?

I'm not updating, you look to be still massaging the windows install process.  ping when it's settled and I can try to document again

@larsonmpdx what you suggest makes sense. Thanks!


[stable/external-dns] fixes #15002

What this PR does / why we need it:
https://github.com/helm/charts/issues/15002
Which issue this PR fixes

fixes https://github.com/helm/charts/issues/15002

Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [stable/chart])

/assign @SantoDE

/assign @tompizmor

/ok-to-test
/lgtm


Add b and i alternatives to strong and em

Please add b and i as alternatives to strong and em. I'm using foundation in combination with contentEditable and some browsers produce b and i instead of strong and em.
Please change
em {
  font-style: italic;
  line-height: inherit; }

strong {
  font-weight: bold;
  line-height: inherit; }

to
em, i {
  font-style: italic;
  line-height: inherit; }

strong, b {
  font-weight: bold;
  line-height: inherit; }

I can do this also via my own CSS, but this is an ugly hack and maybe gets broken on updates.
Thanks,
Marc

Despite how dirty this makes me feel (since b and i have been deprecated for years) we went ahead and added them to typography.css. Not your fault, I blame contentEditable. ec520b4321632dc46085d72701b1097ae890b8b7

Awesome, thank you so much. Jep, contentEditable drives me crazy...Not to mention stuff like this:

Cheers Marc


OFF-EP 0002

Resolves #7

I screwed this one up pretty bad. It might be salvageable, but it'll take some crafting. The key error I made is not distinguishing the cut-off method (i.e. tail correction) and long-range dispersion as separate things. They're highly coupled in practice but in principle they are different things. The cut-off method (as I'm using it here, at least) deals with addressing the discontinuity of the vdW potential at the cutoff distance (r_cutoff in the diagram, NOT the entire blue region) and the long-range dispersion correction is something extra added on top. In the original Shirts 2007 paper, they used both a switching function and a long-range dispersion correction. An earlier version of this OFF-EP instead proposed adding <vdW ... method="no-cutoff"/> but I scrapped that at some point in time because ... I'm not sure why. I'm now convincing myself that is a better proposal and instead we should be hashing out the different combinations of settings that should be allowed and when each should be required.
Part of the confusion here is that the spec completely skips the question of how to deal with the cutoff generally - it simply assumes that the the vdW interactions are going to be cutoff at some distance corrected with a switching function. method="no-cutoff" might help here but it still skips over the question of how a cutoff should be corrected, if at all. As examples, I'd rather see things like

<vdW ... method="cutoff" tail_correction="switching" cutoff_distance="" switch_distance="" ... />
<vdW ... method="cutoff" tail_correction="none" cutoff_distance="" ... />
<vdW ... method="no-cutoff" tail_correction="none" ... />
<vdW ... method="pme" ... />

More verbose, but explicit is better than implicit when details matter.
Anyway, that's exploding the scope. Separately from all of this, and something that does not resolve #7, we probably should have an option that simply turns off the dispersion. ="isotropic" simply translates to .setUseDispersionCorrection(True), something that other implementations may not want to do, so we should have a corresponding method that does not do anything. I will attempt to re-scope this proposal to just that and split out the other topics into other OFF-EPs with more sweeping changes.

Here's my understanding of vdW energies:

This diagram roughly captures my (imperfect) understanding. There are many other options not considered in the current OpenMM-centric view; I'll try to hold my tongue on these but I have to note that the current spec is in large part a backmapping of common OpenMM usage.

Would the energy value for the flat region be zero, or the energy value from the rightmost point in the switching region?

It should be zero when no long-range dispersion correction is applied. I think this is only a consequence of the fact that no other options that are currently supported should modify this. Long-term the answer might become "whatever the other options result in it being," along with some safeguards if certain combinations of settings are nonsense.

Which keyword would control this?

I don't think this is something that is exposed and I don't think there's a clean way to support it now. Eventually people may want to do something like a [shifted Lennard-Jones potential], but I'd rather leave that to when we're considering more potential values.
I also have to add that I think these questions are somewhat valid for the "isotropic" option; the spec currently fails to describe it at all:

Attributes in the  tag specify ..., as  well as the distance at which a switching function is applied (switch_width, default: "1.0angstrom"), the cutoff (cutoff, default: "9.0angstroms"), and long-range dispersion treatment scheme (long_range_dispersion, default: "isotropic").

And that's it. If I didn't have OpenMM's boolean toggle for this, I certainly wouldn't know what is intended by this.

The EP mentions that different engines use different switching schemes. Which keyword indicates that we don't want a switching scheme (effectively switching_function(r) = 0)?

None, and once I revamp this EP to only consider the long-range dispersion it should be out of scope. This will require more significant change, something like * <vdW ... method="cutoff" tail_correction="none" cutoff_distance="" ... /> that I suggest above.

I'm inclined to think that our current (admittedly flawed) implementation has long_range_dispersion define the energies to the right of the switching region, and method adds the information for what happens inside the switching region. So I'm cautious about this because the justification for this EP aims to change a single one of these keywords (long_range_dispersion) to get different behavior in both regions.

My reading of the OpenMM docs and paper (equation (1)), which could be totally wrong, imply that the long-range dispersion correction is applied everywhere, not just the purple region. I think this is what's happening in the source code as well. So in principle - though the numbers are probably tiny - even the direct space energy is not simply a 12-6 potential when this is applied.
Nonetheless, I agree with your concerns. I think this justifies a bigger change as I discussed above.

As examples, I'd rather see things like
<vdW ... method="cutoff" tail_correction="switching" cutoff_distance="" switch_distance="" ... />
<vdW ... method="cutoff" tail_correction="none" cutoff_distance="" ... />
<vdW ... method="no-cutoff" tail_correction="none" ... />
<vdW ... method="pme" ... />

+1 for this if (or something like this) if you'd be up for opening a new OFF-EP to discuss.


New global Strategy

The current situation using swarm is not stable enough and produces many non-deterministic problems. The usage of :global before swarm also produced many issues.
Therefore a new solution should be implemented to tackle those issues.

Thoughts from Slack:
tsloughter [7:37 PM]
why not just use a database?

tsutsu [7:38 PM]
@maennchen I’ve always wondered why everything `quantum` does _needs_ to be distributed. It seems to me that there’s an “obvious” factoring `quantum` could do into two components, that allows you to avoid the hardest parts of the distribution problem:

1. one component, a more traditional job [priority-]queue library, serving as the backend for `quantum` to schedule workloads upon, supporting all the things `quantum` currently supports (e.g. jobs with keys where you can’t schedule a second instance of a job that’s already in the queue/in progress.) This part would use `swarm`, in a much simpler way than `quantum` does currently (it’d just be a set of greedy consumers fed by the leader’s queue.)

2. the other component, a cron job _source_—a lighter daemon that just runs in one place (maybe fault-tolerantly, using Erlang’s application failover, but that can be done after-the-fact by integrators who need it) which, upon a crontab entry’s timer firing, _creates_ “job” objects in its job-queue backend. (You could have more than one of these in the cluster, but each one would “own” the jobs it creates, and thus would have its own individual crontab, rather than there being one global crontab.)

This would also allow people to use `quantum` _as_ their jobs library, and so only have one set of jobs infrastructure, which would be _really_ nice. (And maybe things could work the other way as well: if other jobs systems saw `quantum`’s factored jobs library, they’d maybe copy its features, and then they’d become API-compatible enough that the quantum scheduler could offer the option to swap out its own queue backend for one of the existing jobs libraries.)

I feel like, despite this change having little to do with your question as stated, it _might_ be a fix to whatever the headaches are you’re talking about—since you would no longer be trying to do consensus on job _creation_ from a clock source, merely on consumption from a global queue, which is a far more well-studied problem (edited)

tsloughter [7:38 PM]
if you really need distributed state, if eventual consistency is acceptable I'd say checkout lasp and/or riak_core
but a separate database is a good way to go :slightly_smiling_face:

tsutsu [7:45 PM]
but everything I said is wrong _if_ people are trying to use `quantum` to get things to happen “simultaneously” (in a soft-realtime sense) on multiple machines, using `swarm` as the ahead-of-time synchronization primitive to get each node to have a preloaded in-memory schedule. Then they _need_ the schedule itself to be on all the nodes, so that tasks can execute near-instantaneously with locality.

Is `quantum` being used this way? Because I think it _could_ be used this way… but I don’t think I ever saw it listed as an explicit design goal, so you could just say you don’t support that use-case, to release yourself from the burden of the architecture it requires. (edited)

What about using Horde's CRDT for the global execution mode?
As one of the maintainers of Swarm I know that the project is basically in hibernation, there are some open issues that are hard to reproduce / fix and its overall design is also questionable.
Horde seems to have more momentum, and is more modular; I think that it would be possible to replace :global with a Horde.Registry for the global process runner.

@arjan How does Horde manage Handoffs to another node when the node currently running a process shuts down?

It does not have anything special but there is a guide explaining how it can be done using trap_exit. However you need to store the handoff state yourself somewhere. Could be done in the CRDT itself though, if it's not too large.

@arjan How would you implement a Handoff Logic via the CRDT?

When the node is shutting down you could register the handoff state on the CRDT, and then sleep, to give the CRDT some time to propagate, before the local CRDT shuts down.
That means that the CRDT needs to be started in your supervision tree before the process that wants to handoff, because that way you can be sure the crdt is still around when shutting down the proecess.
I am not sure that this works for large number of processes or a large state, but for me it works.
I implemented something like that here. I do not start a separate CRDT but use the Horde.Registry for this.
Maybe @derekkraan has something smart to say about this as well :-)

Correct me if I'm wrong, but Quantum uses swarm to start a single scheduler that executes cron jobs. If this is the case, then perhaps you don't need to hand off state at all. The consequence would be that you possibly run the same job twice (if system clocks aren't synchronized perfectly), or miss a job (if you happen to shut down a node precisely before a job was set to run).
There are other things to consider:

If a node crashes, then there won't be any state to hand off.
Handing off state introduces complexity and possibly bugs. If you somehow persist incorrect state, then a restart won't reset your process to a "known good state" anymore, so it's worth considering whether it's worth the effort.

As an aside, I do think Horde would be a good match for distributed Quantum. Horde.Supervisor would restart the scheduler when a node goes missing or shuts down, and Horde.Registry ensures it's only running anywhere in your cluster once, and provides a way to globally address the scheduler process. Additionally, you can tune the underlying CRDT by passing the appropriate option to Horde.Registry and Horde.Supervisor.

@derekkraan Running a job twice is not really a problem. We have a ClockBroadcaster. If we handoff, we would also handoff this one. This makes sure that time is not jumped over or repeated.
I would like to have a handoff feature at least for non-crash situations so that the system continues to run when for example a deployment is updating in K8S. It's clear to me that this will not solve a case with a crash.
If you want to be sure with a crash, I'd point people to the storage adapter solution that we should release stable at the same time as we release a solution to this particular issue.

@maennchen If you want to replicate the state of the ClockBroadcaster in the cluster so that you can do handoff during deployment scenarios, then you could simply use Horde.Registry.put_meta/3 in the terminate/2 callback of the ClockBroadcaster process (and then a sleep to ensure it has time to propagate), and Horde.Registry.meta/2 in the init/1 callback. You may consider recording a timestamp in the metadata to ensure that you don't accidentally recover from an old record.
If you tune the CRDT with the delta_crdt option, then you can know how long you need to sleep after using put_meta/3 when the process is terminating to ensure that its data has been synced to the other nodes in the cluster.

@c-rack Would you agree to a new major version without clustering support? I would later add it back as a new feature.
I think it would make sense to get out a stable set of features and later improve on them.

I'm thining it would make sense to split of the global part into a new package.
It would work something like this (isntead of use Quantum, ...):
defmodule Acme.Scheduler do
  use Quantum[Horde|Swarm|OtherProvider], otp_app: :acme
end

The module would then do those things:

Start Quantum (the whole thing) only in one place
Start TaskSupervisor everywhere
Register a global name so that it can be used in the whole cluster
Inject a new Quantum.Storage

The new Quantum.Storage would do the following things:

Delegate writes to the cluster state and the original installed storage
When booting quantum, the state would be consumed from the cluster state with a fallback to the original storage

Needed to build a package for horde:

Storage Adapter that uses Horde.Registry.put_meta/3 / Horde.Registry.meta/2
Allow quantum to be started with another global name ({:via, Horde.Registry, Acme.Scheduler})
Allow quantum to be started without TaskSupervisor since it will be run separately
Build QuantumHordethat does the follwoing:

injects the storage into config
injects global name into config
disable task supervisor in config
starts horde supervisor
starts quantum once globally
starts task supervisor everywhere

What do you think about this approach @derekkraan / @arjan?

I think a solution like this makes a lot of sense.
Distributed state is hard to get right, as we all know. Keeping Quantum focused on the single node case is probably good enough for most people, and reduces a lot of complexity from this library.
I was wondering though, what were the exact issues when you were still using global instead of Swarm / Horde? Why did you move away from using it?

@maennchen I think a pluggable approach makes sense. I know of at least one library (commanded/event_store) that uses postgres advisory locks for ensuring that a process only runs in one place in a cluster, and I think that might be a better option for a large percentage of the users of this library for example.

Yeah, I share this sentiment. A CRDT seems quite overkill for what is basically one "singleton-process".

@arjan

I was wondering though, what were the exact issues when you were still using global instead of Swarm / Horde? Why did you move away from using it?

For two reasons:

In the event of a conflict, the states are impossible to merge / hand over since global kills the process and not just terminates it.
Even though we linked to a process, if the node running the process got killed / network problem etc, the termination was not detected by the other nodes and no new process was started.

@maennchen

In the event of a conflict, the states are impossible to merge / hand over since global kills the process and not just terminates it.

This behaviour is configurable in :global via a callback (the third argument) in register_name/3.

Even though we linked to a process, if the node running the process got killed / network problem etc, the termination was not detected by the other nodes and no new process was started.

This seems unlikely. Both links and monitors work in a cluster just fine. If a node is killed (or there is a netsplit), then monitors and links will fire as you would expect.
I recently put together a solution for commanded/event_store to solve this problem, and yesterday extracted that out into its own library, Highlander (docs, blog post).
Perhaps this can serve as inspiration for a solution to the problem of this issue. (Or perhaps it is usable directly)

@derekkraan Thank you for implementing and publishing Highlander. It's a tiny but amazing library. Recently, we are switching from Horde to Highlander for making only one Quantum scheduler process running.
Horde is also incredible, but it's too powerful and hard to control. Maybe cause we're lack of experience, we had to write some glue code to achieve the goal with Horde. But with Highlander, we can achieve the goal just follow the tutorial.
children = [
  supervisor(MyApp.Endpoint, []),
  {Highlander, MyApp.Scheduler}
]

And configure jobs to run under Quantum.RunStrategy.Local.
config :my_app, MyApp.Scheduler,
  run_strategy: Quantum.RunStrategy.Local,
  jobs: [
    ...
  ]

Our new scheduled job system (Quantum 3.0 and Highlander / running on Kubernetes cluster) is still in a staging environment and under testing. The current result is good. We changed the number of pods randomly, but Highlander keeps the scheduler process running and there is only one process in Erlang cluster. 🙂

@ishikawa thanks! I think Highlander is much better suited to this problem than Horde, so it seems like you made a good choice there :+1:. Of course most of the kudos should be directed to the Erlang team, I only repackaged their work (on :global) in a slightly different way.
One thing to watch out for is the behaviour of Highlander when there is a network partition affecting your cluster. Highlander will in that case spawn one scheduler process per partition, and that may or may not break your setup.

@ishikawa Thanks :)
I'll push a new minor version soon that will split the main supervisor into two parts:

Task.Supervisor & Quantum.ExecutorSupervisor
The rest

This will allow to start the first one on every node and the second one via global / Highlander / swarm / horde / etc.
I'm planning to publish a package that uses this interface using global (simple, no conflict resolution), I'd be very happy if others would be provided by the community.

I pushed a draft PR together with a swarm example. I'd love to get some feedback on it from all of you.
Some community packages based on that (hosted either in the quantum org or also independently) would be great to support multiple providers.

This can now be done externally. Therefore I'm closing this issue.
Please open new issues if you implement an alternative adapter and something is missing.

This can also be accomplished with Singleton https://github.com/arjan/singleton


Update option name of pa app export. Closes #5368

Closes #5368

Hi @Saurabh7019 seems like you have some redundant commits in your PR. Could you have a look at it please?

Hi @milanholemans, @Adam-it
Multiple rebases, conflict resolutions, and force pushes have unintentionally included unnecessary commits and files in this pull request. To maintain clarity of the changes and avoid confusion, I am closing this PR and creating a new one.

Luckily we got rid of the v7 branch now :)


Scrolling with PgUp / PgDown using numeric keyboard does not move the cursor

When scrolling using PgUp/PgDown keys on numeric keyboard, the scrolling works fine but the cursor does not move. It needs to move to the new position accordingly.
Thanks!

This is OS X behavior and it does not change from Karabiner.
However, most apps supports option-PgUp/PgDown to scroll with cursor.
#398 changes keypad pgup/pgdown to option-PgUp/PgDown.


Migrate and refactor linkedin authenticator doc

Purpose

The purpose is to move all the documentations to the git. In here we migrated the existing Linkedin outbound authenticator documentation to git.
Source : https://docs.wso2.com/display/ISCONNECTORS/Configuring+LinkedIn+Authenticator

Goals

Keep the documentations in one place.

Release note

Migrated the Linkedin outbound connector documentation to git.
Changed the sample application configuration for testing.

Done the requested changes.


Add header on refresh

Hi
I'd like to be able to add a header on every refresh. The value of the header will be calculated (and unique) every time the refresh endpoint is hit.
I can't see how to do this currently... can anyone help?
many thanks
Matt

I found a workaround: I have subclassed the JwtHttp class, and overridden the request() method – something like this:
class MyHttp extends JwtHttp {
    request(urlOrRequest: string | Request, options: RequestOptionsArgs = {}) {
        // Here is where I modify the headers, before calling `super()`
        return super.request(urlOrRequest, options);
    }
}

It's not an ideal solution, because it affects all HTTP requests. In my use case, that is what I need, but it would be useful to be able to configure the refresh token HTTP request.
Any suggestions @leonardobazico?

Scratch that. I've just discovered that the above method does not work: when the HTTP request is made to refresh the token, the request() method above is not invoked.
So I'm currently at a dead end... @leonardobazico if you've got a moment to have a look, it would be much appreciated. :-)

Ok, so here's one solution to the original problem I described: override the _refreshTheToken() method in the class that I extend from JwtHttp – something like this:
export class MyHttp extends JwtHttp {
    constructor(
        refreshConfigService: JwtConfigService,
        http: Http,
        defOpts?: RequestOptions,
    ) {
        super(portalConfigService, http, defOpts);
    }

    protected _refreshTheToken() {
        // keep a copy of current headers by cloning them
        const savedGlobalHeaders: Array<Object> = this._config.globalHeaders.slice(0);
        // and then add the headers I want here
        this._config.globalHeaders.push('header-name', 'header-value');

        return super._refreshTheToken().do(() => {
            // restore the headers we saved
            this._config.globalHeaders = savedGlobalHeaders;
        });
    }
}

It's a bit messy, but it does the job. @leonardobazico, what do you think?


Query parameter support

It would be great if the router could support query parameters and ignore them when making routing decisions, yet still expose them when route is matched. This would be great way to build permalinks with some preconfigured state (e.g. search/filter form).
This should work for both, BrowserRouter (localhost:8080/route?param=true&param2=true) and HashRouter (localhost:8080/#/route?param=true&param2=true)
Aditionally, arrays could be also supported and parsed properly (localhost:8080/#/route?arrayParam=one&arrayParam=two should result in value of "arrayParam" to setOf("one", "two"))

Indeed, this feature would be handy, although the different encoding formats would be tricky.
Maybe Ktor could share its encoding as a separate artifact.
Also how do you want to consume the parameters? Via Map<String, String? Then you have to valide the types by yourself. Alternative a direct mapping to a data class would be nice too.

After talking with the Ktor team, the new Location feature won't be released as a separate artifact, so I implement a simple, untyped version by myself.

I think Map<String, List<String>> is more than enough to start with. This can then be enchanced in the future to support some typesafe DSLs as well.

BTW, I'm not sure if list is the right way to go. I can't think of a case where you'd want duplicate values in query parameter list. But hey, it might be just me.

@mpetuska Good question, but I was inspired by Ktors query parsing, which uses a List` too, and you can convert any List to a Set ;)


Zerryth/qna parity

Fixes #684, #676.
Also addresses concerns outlined in #554 (cleaner code factoring, unit tests, configuration, tracing, options)
Description

Now throws error outlining that a QnAMakerEndpoint is needed to instantiate QnAMaker
Trace now emits on all calls to qna in getAnswers()
emitTraceInfo() now correctly includes both options that are passed in during QnAMaker instantiation as well as any QnAMakerOptions passed into call to qna service in getAnswers()
Note to being along the lines of parity: the above is a bug that still needs to be fixed on the C# side
bunch of unit tests

Specific Changes

constructor of QnAMaker throws error if no QnAMakerEndpoint
As in C# side, added validateOptions() method

Throws helpful errors needed to send valid request to qna such as for scoreThreshold (must have value between 0 and 1) and top (must be an integer greater than 0)

Updated documentation on strictFilters and metadataBoost
refactored .getAnswers() and its helper methods to not break on unit test where undefined is passed in
exercised clean coding practice of abstracting lower-level processes in .getAnswers() and .queryQnaService() into helper functions to make code more expressive/readable and better organized

getAnswers(): getTrimmedMessageText(), validateOptions(), sortAnswersWithinThreshold()
queryQnaService(): getHeaders(), formatQnaResult()

extracting user's question in getAnswers() and deprecated generateAnswers() now has check to ensure that context has message type before trying to access the text using getTrimmedMessageText()
moved deprecated methods towards the bottom of QnAMaker class file

Testing

beefed up code coverage for qnaMaker.ts

Pull Request Test Coverage Report for Build 2475

80 of 80 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.4%) to 82.611%

Totals

Change from base Build #1660:
0.4%

Covered Lines:
2747

Relevant Lines:
3201

💛  - Coveralls

Steven sent me the Details dump that I currently don't have permission to see myself.
And hmm...it looks like several of the QnAMaker tests are breaking with error "TypeError: expected.test is not a function" and "assert.rejects is not a function"
The latter is confusing, because .rejects() is definitely a part of Node's assert library. Digging...

Alright, working with build engineer Jose on the failing issue.
Tests are passing in Travis, but not in BotBuilder-JS master build, because:
"Azure Devops, due to the locked-down nature of our repositories, is preventing the test build from accessing outside resources - such as QnAMaker."
Investigating, you can see in "Details" that it breaks on unit tests that specifically make a call to QnAMaker service.
Pending Jose's help to see if we can get the connecting-to-the-service issue resolved


Fixing the clipped graphic.

#artist #photoshoprookie

@EricAtMSFT Isn't it still a little clipped at the top?

Trying again....

I think it looks okay now, but the top pixel is still a part of the circle, which makes it difficult for me to know for sure if something above that has been cut off.
Would it be possible if we ensure some space at the top of the logo, so that we can be 100% sure nothing is cut off?

Just view it on my branch. Looks fine to me: https://github.com/Microsoft/OpenAPI.NET/tree/clipped-graphic


DriverSerial now accepts baudrate parameter.

Hey... We said the committer was to merge!

LOL... I believe we did :P
On Thu, Dec 29, 2016 at 10:54 AM, Tom Swirly<EMAIL_ADDRESS>wrote:

Er. Did we? :-D
I'd blame it on short term memory loss from being in Amsterdam, but I
haven't even been able to smoke recently FFS!
On 29 December 2016 at 16:43, Dread<EMAIL_ADDRESS>wrote:

Hey... We said the committer was to merge!
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<https://github.com/ManiacalLabs/BiblioPixel/pull/
87#issuecomment-269648176>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/
AAPdsnltP20AaNZq9xaKiaDBuCAFb0sTks5rM9U6gaJpZM4LXlUU>
.

--
/t
http://radio.swirly.com - art music radio 24/7 366/1000
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ManiacalLabs/BiblioPixel/pull/87#issuecomment-269649731,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA6a6i8mi-525CazulqJ-D9QoaHxQZ1zks5rM9eZgaJpZM4LXlUU
.


Adding eslint-config-keystone

Replacing .eslintrc config options with 'extends'

Related to this an earlier request to include eslint-config-keystone here --> https://github.com/keystonejs/keystone-storage-adapter-s3/issues/2

Thanks Vito. eslint-config-keystone has been included in the latest release.


allow tools to get access to any keyevent

The current shortkey handling for RViz Tools is quite rigid, since it prevents tools from internally using shortkeys that overlay those defined to switch between tools. An issue, I stumbled across various times now and always worked around by choosing 'free' keys, but since those are limited, I would like to a) start a general discussion on the handling of shortkeys and get an idea what the community/the maintainers think about this issues, b) propose a minimal invasive patch that extendes the shortkey handling and c) offer my help to work out a proper shortkey handling.
a) General Discussion
I checked the source code an realized that the shortkeys that call a Tool are placed within the QActions which represent the Tools in the Toolbar and that if a shortkey is pressed the Toolbar deactivates the current tool and activates the tool connected to the QAction/shortkey. This leads to two counter-intuitive behaviors.
At first, it leads to deactivating and directly activating a tool again, if one presses the respective shortkey twice. Suppose a tool gathers some sort of data internally, which is flushed on deactivate(). In the current use case, this data would be lost, while the tool is still active, seem annoying to me. I would rather expect that pressing the shortkey of an inactive tool would activate it, and pressing the shortkey of an already active tool deactivates it and leads back to the default tool. Data might still be lost, but at least the UI would be intuitively stress this, due to the change to default.
Secondly, and more importantly, shortkeys that are meant not to activate a tool, but to support a tools usage are always overriden by the toolbar shortkeys, if those happen to be alike. As an example, consider the 'Select' Tool which features pressing 'f' to focus the camera on the currently selected item. If now another tool registers 'f' as it's shortkey and is added to the toolbar, pressing 'f' while using 'Select' results in switching to the other tool, not in focusing the item. Which is even more annoying, since the internal shortkeys of an active tool should have priority over the switching to another tool.
What do you think? Do you agree?
b) Patch
I cooked up a small patch that would get rid of these problems in a minimal invasive manner. Here's what i did:

The Tool BaseClass was extended by a boolean called 'keep_control_', which indicates if tool want's to get access to all keypresses that occur, even those that would usually activate another tool. By default this boolean is set to false, and thus there is no need for all Tools out there to be changed in any way.

If a shortkey is caught by on of the QActions representing the Tools it is checked whether the current tool want's to keepControl() or not. If so, the shortkey of the QAction is turned into a KeyEvent and handed down to the current tool, so that it can use it for it's purposes. If not, the tool is switched. Or reset to default, if the shortkey happens to be the one of the current tool, which is in fact the method to switch from a "control keeping" tool to any other.

These are the changes that come with the PR. To test the new keep_control_ feature, one can checkout this repository  on the "keepControl" branch, where I extended the tool to declare keep_control_. I would be glad if these changes would be pulled.
c) Designing a proper shortkey management
But I think we could even go farther and develop an even better shortkey handling for RViz Tools. My PR is quite rigid in itself again, since a tool that "keeps control" just get's all key events even if it does not use them at all. I think I would be great if we did the following:
Let the Tool base class declare fields for the keys they operate on, each with a name, description and getter and setter methods. There should be a "primary shortkey" for activation and a set of "secondary shortkeys" for internal usage. Then let's get rid of the shortkeys within the QActions and just use them for directly switching tools by clicking the toolbar and move all Tool related shortkey handling into the handleChar method of the ToolManager. Where should be checked if the pressed key is within the secondary shortkey collection of the current tool. If so it should be passed down to the tool. If not it should be checked if the key deactivates the current tool or activates another and act accordingly. If a key that is both secondary key of the current tool and primary of another this could be mentioned in the status bar, so users are aware of this.
Further the tool manager could keep track of all used keys and detect potential conflicts. With the name, description and getters and setters at hand overview and modification GUI could be implemented to resolve those conflicts or just support custom key layouts, which could be stored in the config files.
I already fooled around with some of these ideas and would offer to develop this functionality of you RViz using people out there think that this would be beneficial for all of us. If so, please feel free to provide any feedback or feature ideas that might be useful to consider.

Thanks for taking the time to put together this pull request and thoughtful description.
I think the technical approach for this first step is solid, and after doing a code review the changes look good too (other than a few stylistic details). One thought I had though was, should we update any of the existing tools to use this new keep control mechanism? For example you mentioned the selection tool which can use f to focus the camera to the item being selected. Should update that tool (and maybe others) to use the new mechanism as part of this pull request?
Pending the above questions and comments, I think I would like to merge this pull request soon so that we can get some soak time on it in the next release.
As for the "future" work you mentioned in section c), I agree with most of it. I think that the finer control over which keys are captured makes sense, but I am not passionate about how it gets done technically, as long as it provides a reasonable interface for tool developers and good usability for users. I also think it is important to provide some feedback to users when the keys collide.
Once this pull request is merged, it would be great if you could continue this conversation in a new issue or pull request and be the champion for this general topic in rviz.
Thanks again for the contribution!

hi wjwwood,
thanks for the kind reply!  I'll get back to this on monday and fix the style issues and check where applying keep control on existing tools makes sense. I wasn't sure if altering the existing tools would be preferred, but I think it's a good idea. I could come up with a little documentation as well, but currently Tools are documented outside the wiki.  I probably can't extend the docs there, right? What's the policy about these external tutorials? Maybe it's better to migrate them into the wiki?
Regarding the future work, I'm happy to prepare a proposal for an extended key handling. I'll try to allocate some time for this asap and create an PR once I'm done.

I now fixed the style issues and renamed the parameters from keepControl to accessAllKeys, which seems to be more suitable name for me. But...
I would recommend not to merge this PR just yet. I just started to work on the "future work" and would like to include one feature: If a tool is selected by clicking the icon in the toolbar, the tool should be changed no matter if the current tool accesses all keys. Currently one has to first deactivate the tool first, before clicking the toolbar allows switching. I was aware of this the other day, and though that's fine, but right now this seems to be a bug to me, considering that we would change commonly used tools like "Select" as well.  I'll fix that today.

237c48994d8dc994c57f12a619ec320d1b0a195b fixes the bug i mentioned above. The shortkey logic is now moved entirely into the tool manager. Which now allows to switch tools via click on the tool bar, even if the current tool has access to all key events.
I further made changed the selection to, it is the only standard rviz tool that currently uses shortkeys internally.

Cool, those changes make total sense to me. I was going to play test it a bit before merging, I'll try to do that today.
Otherwise, are you happy with the current state of the pull request, is it ok to merge from your perspective?

I just tested it out and the tool hotkeys seem to work as expected (so there at least wasn't a regression) as far as I can tell.

Yeah, I'm happy with the PR and would say let's merge it, to give it "soak time" and the like! Can you tell me, when the next release will be happening?

P.S.
Do you have an opinion/advice regarding the documentation?

Can you tell me, when the next release will be happening?

Soon, I have several fixes that need to go in and I want to maximize the time between releasing the next version and a sync of the new packages to the public .deb repository.

Do you have an opinion/advice regarding the documentation?

Honestly I haven't had time to get a handle on the documentation for rviz. There is quite a lot of stuff on the wiki in varying states, but the user guide is probably to most applicable user facing section for this issue:
http://wiki.ros.org/rviz/UserGuide#Tools
The developer documentation is a little more sparse, but there are related tutorials for making new tools:
http://wiki.ros.org/rviz/Tutorials/Plugins%3A New Tool Type
Which actually just redirects to:
http://docs.ros.org/indigo/api/rviz_plugin_tutorials/html/tool_plugin_tutorial.html
I think this last link would be the right place to add documentation about the changes in this pull request. That documentation is generated from:
https://github.com/ros-visualization/visualization_tutorials/blob/indigo-devel/rviz_plugin_tutorials/src/doc/tool_plugin_tutorial.rst
Which is in the visualization_tutorials repository.

Perfect, the last link was exactly what I was looking for. I'll add some docs there.
And thank you very much for proof reading, suggestions and merging!


Update Readme.md

Update link to point at correct location of whitepaper

Hmmm, I appear to lack the coding skill to even help fix a typo.
If any patient persons have the time to explain the test error below, or point me at the right info, then ill be better next time :)
Run make deploy make: *** No rule to make target 'deploy'.  Stop. ##[error]Process completed with exit code 2.

I'm not sure that fix of the link is needed. When I click on "the whitepaper" on https://rhasspy.readthedocs.io/en/latest/ it brings me to the correct location https://rhasspy.readthedocs.io/en/latest/whitepaper/
Or what did you see?
No worries about the make deploy error, that's not your fault. We should fix the makefile. @synesthesiam can you have a look at it?

Oh right, I was looking at the wrong file, the index page on Read the Docs is generated from docs/index.md, but the README should link to the docs directory indeed for the whitepaper, you're correct. I'll merge the PR, thanks!


[SPARK-28683][BUILD] Upgrade Scala to 2.12.9

What changes were proposed in this pull request?
This PR upgrade Scala to 2.12.9.
Release notes:

Faster compiler: 5–10% faster since 2.12.8
Improved compatibility with JDK 11, 12, and 13
Experimental support for build pipelining and outline type checking

More details:
https://github.com/scala/scala/releases/tag/v2.12.9
How was this patch tested?
Existing tests

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/13988/
Test PASSed.

Test build #108914 has started for PR 25404 at commit 839c27e.

Test build #108914 has finished for PR 25404 at commit 839c27e.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/108914/
Test FAILed.

Retest this please.

Test build #108924 has started for PR 25404 at commit 839c27e.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/14000/
Test PASSed.

The failure seems relevant, @wangyum . Could you check the failures?

Test build #108924 has finished for PR 25404 at commit 839c27e.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/108924/
Test FAILed.

Wow that's a weird one, but I played with it and, bizarrely this change in the generate code makes it work:
      } else if ($o2 == null) {
        return -$sortOrder * $nullOrder;
      }

to
      } else if ($o2 == null) {
        return -$sortOrder * ${nullOrder.toString};
      }

I can only guess something goes wrong in string interpolation because nullOrder is a NullOrder and typedef for an Int, and is boxed to Integer somewhere, but something believes it is a String.
... and then I decided to search for open bugs and yep this is it:
https://github.com/scala/bug/issues/11665
We may just need to wait for 2.12.10

Thank you @srowen Let's  wait for 2.12.10.

Hi, All. Let's reuse SPARK-28683 for 2.12.10. I reopened it.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/15441/
Test PASSed.

Test build #110459 has started for PR 25404 at commit e5811fd.

Test build #110459 has finished for PR 25404 at commit e5811fd.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/110459/
Test FAILed.

sbt.ResolveException: unresolved dependency: com.typesafe.genjavadoc#genjavadoc-plugin_2.12.10;0.13: not found
	at sbt.IvyActions$.sbt$IvyActions$$resolve(IvyActions.scala:320)
	at sbt.IvyActions$$anonfun$updateEither$1.apply(IvyActions.scala:191)
	at sbt.IvyActions$$anonfun$updateEither$1.apply(IvyActions.scala:168)

Let's wait for genjavadoc-plugin_2.12.10: https://repo1.maven.org/maven2/com/typesafe/genjavadoc/

OK by me, once the javadoc plugin is available and tests pass. Looks like the problem with string interpolation was resolved.

Thank you, @wangyum and @srowen . Yes. Let's retry when it becomes ready.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/15652/
Test PASSed.

retest this please

Test build #110780 has started for PR 25404 at commit e5811fd.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/15915/
Test PASSed.

Test build #110780 has finished for PR 25404 at commit e5811fd.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/110780/
Test FAILed.

Test build #110781 has started for PR 25404 at commit 075134d.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/15917/
Test PASSed.

genjavadoc 0.14 has released: https://repo1.maven.org/maven2/com/typesafe/genjavadoc/genjavadoc-plugin_2.12.10/0.14/

Test build #110781 has finished for PR 25404 at commit 075134d.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/110781/
Test FAILed.

Finally! Thanks!

Retest this please.

Test build #110793 has started for PR 25404 at commit 075134d.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/15927/
Test PASSed.

Well... that's weird. Lots of tests fail because they get slightly different answers, and almost all look like tests that depend on a seeded random number generator at some level.
Take https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/110781/testReport/test.org.apache.spark/JavaAPISuite/sample/ for example.
  @Test
  public void sample() {
    List<Integer> ints = IntStream.iterate(1, x -> x + 1)
      .limit(20)
      .boxed()
      .collect(Collectors.toList());
    JavaRDD<Integer> rdd = sc.parallelize(ints);
    // the seeds here are "magic" to make this work out nicely
    JavaRDD<Integer> sample20 = rdd.sample(true, 0.2, 8);
    assertEquals(2, sample20.count());
    JavaRDD<Integer> sample20WithoutReplacement = rdd.sample(false, 0.2, 2);
    assertEquals(4, sample20WithoutReplacement.count());
  }

It's seeded, so ought to produce the same answer. This has worked the same way for a long time, giving that particular answer with that particular seed. It's pretty straightforwardly using a java.util.Random, seeded. What could have changed?
At the moment I'm wondering if somehow a compiler or collections change causes the input to be partitioned differently or iterated over differently. Still thinking about it and reviewing the (pretty minor) Scala changes.
One way or the other I don't think we can let the behavior change for a seeded sample, but not clear whether it's some subtle assumption Spark makes or something else going on.

Oh, then, Scala 2.12.10 seems to have a breaking change like that. I agree we should not upgrade if then. I'll take a look today, too. I guess it will end up with reporting another issue to the Scala community. 😞

I'll investigate a little more to narrow down what the difference even seems to be. I think we do need to figure it out eventually because people will want to use 2.12.10 and we want the enhancements.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/110793/
Test FAILed.

test this please

When I take a look at RandomSuite, most of the code is executed thru (generated) Java. IIUC, only setSeed, hashSeed, and next methods in XORShiftRandom are written in Scala...

After tracing this test, I believe MurmurHash3.bytesHash returns a different value between Scala 2.10.8 and 2.10.10. I am investigating the reason.

Test build #110811 has started for PR 25404 at commit 075134d.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/15943/
Test PASSed.

I am curious that this change on 2019/1 may affect the result.
Scala 2.10.8 was released on 2018/12
Scala 2.10.10 was released on 2019/9

Thank you for sharing the investigation result, @kiszk !
It's surprising because the original issue is reported on Jan 15, 2018 .

Hi, All. I'd recommend to use the old one for XORShiftRandom.
@wangyum . Please add MurmurHash3.arraySeed like the following.

core/src/main/scala/org/apache/spark/util/random/XORShiftRandom.scala

   private[random] def hashSeed(seed: Long): Long = {
     val bytes = ByteBuffer.allocate(java.lang.Long.BYTES).putLong(seed).array()
-    val lowBits = MurmurHash3.bytesHash(bytes)
+    val lowBits = MurmurHash3.bytesHash(bytes, MurmurHash3.arraySeed)
     val highBits = MurmurHash3.bytesHash(bytes, lowBits)
     (highBits.toLong << 32) | (lowBits.toLong & 0xFFFFFFFFL)
   }

Hmm. It may be worth of having another PR to make it sure.

Yep before we decide what to do, it's worth seeing whether this is the issue. @dongjoon-hyun to match https://github.com/scala/scala/commit/846ee2b1a47014c69ebd2352d91d467be74918b5#diff-ac889f851e109fc4387cd738d52ce177 don't we need both calls to change bytesHash to arrayHash? I may not have thought about it as much as you have though.

Test build #110811 has finished for PR 25404 at commit 075134d.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/110811/
Test FAILed.

I quickly checked that the failures on catalyst module and DatasetSuite, DataFrameStatSuite, JsonSuite, CSVSuite of sql module. All of them are fixed with that change.

Test build #110844 has started for PR 25404 at commit 57de6c4.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/15977/
Test PASSed.

I applied SPARK-29124 to this PR. Let's see if all tests can pass.

Test build #110844 has finished for PR 25404 at commit 57de6c4.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/110844/
Test FAILed.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/15982/
Test PASSed.

Test build #110854 has started for PR 25404 at commit 57de6c4.

Test build #110854 has finished for PR 25404 at commit 57de6c4.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/110854/
Test PASSed.

Test build #110868 has started for PR 25404 at commit da7b223.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/15995/
Test PASSed.

Test build #110868 has finished for PR 25404 at commit da7b223.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/110868/
Test FAILed.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/16003/
Test PASSed.

Test build #110882 has started for PR 25404 at commit da7b223.

Test build #110882 has finished for PR 25404 at commit da7b223.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/110882/
Test FAILed.

retest this please

Test build #110901 has started for PR 25404 at commit da7b223.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/16019/
Test PASSed.

Test build #110901 has finished for PR 25404 at commit da7b223.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/110901/
Test PASSed.

retest this please

Test build #110911 has started for PR 25404 at commit da7b223.

@dongjoon-hyun ah OK, I see what you did now. By using the equivalent two-arg bytesHash method, the behavior didn't change. But the implementation of two-arg bytesHash didn't change in Scala 2.12.10 so it avoids a behavior change.
Looks promising that tests have passed here once.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/16028/
Test PASSed.

Yes. Right, @srowen !

So, if the last Jenkins run passes, this PR looks ready for me.

SBT (https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/110854/console)
Maven/JDK11 (https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/110901/testReport)
Maven/JDK8 (https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/110911/testReport, Pending)

Hmm. The last test has been running 5 hr 43 min already. It seems that we will hit timeout soon. :(

The last run passed all Scala/Java UTs and moved to Python test.
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  05:24 h
[INFO] Finished at: 2019-09-18T12:39:46-07:00
[INFO] ------------------------------------------------------------------------

LGTM, pending Jenkins

I checked and noticed that the PR Builder timeout 430m. It looks safe. I was confused with the other Jenkins job configurations which are shorter than this.

Test build #110911 has finished for PR 25404 at commit da7b223.

This patch fails from timeout after a configured wait of 400m.
This patch merges cleanly.
This patch adds no public classes.

Hmm. It's weird because it's terminated before the configuration.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/110911/
Test FAILed.

Anyway, this Scala change looks safe to me. I'll merge this to master. Thank you, @wangyum , @srowen , @kiszk !
Please make a backport to branch-2.4.


urllib error persistently occurs

After installing yfinance, everything works fine for a couple of executions of my script. Inevitably, however, I will get this error:
>>> x.info
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/josh/.local/lib/python3.8/site-packages/yfinance/ticker.py", line 138, in info
    return self.get_info()
  File "/home/josh/.local/lib/python3.8/site-packages/yfinance/base.py", line 446, in get_info
    self._get_fundamentals(proxy)
  File "/home/josh/.local/lib/python3.8/site-packages/yfinance/base.py", line 285, in _get_fundamentals
    holders = _pd.read_html(url)
  File "/home/josh/.local/lib/python3.8/site-packages/pandas/util/_decorators.py", line 296, in wrapper
    return func(*args, **kwargs)
  File "/home/josh/.local/lib/python3.8/site-packages/pandas/io/html.py", line 1086, in read_html
    return _parse(
  File "/home/josh/.local/lib/python3.8/site-packages/pandas/io/html.py", line 898, in _parse
    tables = p.parse_tables()
  File "/home/josh/.local/lib/python3.8/site-packages/pandas/io/html.py", line 217, in parse_tables
    tables = self._parse_tables(self._build_doc(), self.match, self.attrs)
  File "/home/josh/.local/lib/python3.8/site-packages/pandas/io/html.py", line 736, in _build_doc
    raise e
  File "/home/josh/.local/lib/python3.8/site-packages/pandas/io/html.py", line 717, in _build_doc
    with urlopen(self.io) as f:
  File "/home/josh/.local/lib/python3.8/site-packages/pandas/io/common.py", line 137, in urlopen
    return urllib.request.urlopen(*args, **kwargs)
  File "/usr/lib/python3.8/urllib/request.py", line 222, in urlopen
    return opener.open(url, data, timeout)
  File "/usr/lib/python3.8/urllib/request.py", line 531, in open
    response = meth(req, response)
  File "/usr/lib/python3.8/urllib/request.py", line 640, in http_response
    response = self.parent.error(
  File "/usr/lib/python3.8/urllib/request.py", line 569, in error
    return self._call_chain(*args)
  File "/usr/lib/python3.8/urllib/request.py", line 502, in _call_chain
    result = func(*args)
  File "/usr/lib/python3.8/urllib/request.py", line 649, in http_error_default
    raise HTTPError(req.full_url, code, msg, hdrs, fp)
urllib.error.HTTPError: HTTP Error 404: Not Found

If I pip uninstall yfinance and re-install it, it works fine again for a little while again and then starts failing again.

I get the same error, but reinstalling doesn't seem to fix it for me.

Seems like ticker.get_info() fails, while ticker.history() for yesterday's prices works fine.

Any fix for this error?

Have anybody fixed it?

Anybody fixed this one yet? For me yfinance was working fine up until today (even yesterday it was all good), now I am persistently seeing 404 errors. At first glance it appears to be related to pandas read_html function. It looks like this function has only been used the once on line 291 of the base.py file.

Hey everyone, for anyone dealing with this issue, I managed to get it to work by updating the base.py file (my version of yfinance is older 0.1.54 and it looks like this may even have been fixed in the most recent version 0.1.59).
Replace the following:
holders = _pd.read_html(url)
With:
r = _requests.get(url,headers={'User-Agent': 'Mozilla/5.0'})
holders = _pd.read_html(r.content)

I had this problem starting yesterday.  I checked my yfinance version and it was 1.54.  Updating yfinance to version 1.6 solved the problem.

Updating my yfinance also fixed my problem.
However, until recently, I have been a devout conda user.  I was disappointed to find that using anaconda to update yfinance did not cause it to update to a newer version.
So, instead, I uninstalled yfinance using conda and then I did this (found via google)...
pip install -i https://pypi.anaconda.org/ranaroussi/simple yfinance
...and then problem solved.  (I am not positive if uninstalling yfinance with conda is a required first step).


Attemts to join via passphare should be rate limited

Attempts to join via a passphrase should be rate limited and denied after a limited number of retries (e.g. 60 sec. pause after 5 retries)
See #856

https://github.com/go-chi/httprate can be used for this. Maybe you could use a specific rate limit by IP and by board id, so a user can only try to join (reloads included) a specific board 5 times every 2 minutes

Already implemented


Acrn boot 2

Those patches will:

allow the grub to pass the kernel cmdline to ACRN sos kernel
enable USB HID (keyboard, mouse) and ethernet in SOS

@rvs

Another question is this: what's the process for the patches you're adding to be merged into acrn and acrn's linux kernel upstream? IOW, when can we expect https://github.com/projectacrn/acrn-kernel and https://github.com/projectacrn/acrn to have those?

Currently, we just provide the flash and boot up test for the ACRN related patches. Currently ACRN based EVE is still not fully functional as XEN based EVE does, but we expect that it will have same test scope as XEN based EVE eventually.  Can EVE try to run the same test level of  Xen based Eve to ACRN-based EVE to figure what functionalities are missing?

+1 from me. This changes works and I can finally play around in a UP2 board.

Excellent!


Feature request: Save button for general preferences

All menues under Configuration has a save/save to pump button except the Preferences menu.
I often find myself accidentally toggling a setting while scrolling in the menu mask and sometimes that makes me feel insecure about what the setting was before scrolling.

Thats a good point - I have noticed the accidental toggle as well a few times.
How about a "lock/unlock" situation, where you can only toggle, when unlocked. Then save, and lock again?


[BUG] - ProtocolParameters not exported from cardano-api

it's possible to query them, but no way to inspect.

Looks like it's exported from .Shelley module