About the baseline experiment pixel-nerf

I'm curious how you did your pixelnerf comparison experiment. Are you directly replacing the natural or rendered images in the nerf with the X-ray images? Or is there another way?

Hi,
We trained pixelNerf from scratch with our data. For that, we modified the dataloader, especially the camera part. You need the camera matrices to train pixelNerf. Since we generated the DRRs using Plastimatch, we referred to their projection geometry and Projection matrix documentation to generated the camera matrices.

thank you for your reply. Do you keep specific X-ray data, camera parameters and loading codes? I haven't done this before, I'd appreciate it if you could share

thank you for your reply. Do you keep specific X-ray data, camera parameters and loading codes? I haven't done this before, I'd appreciate it if you could share

Sure, I thought the link to the data contained the .txt files with the camera poses, but not. I just added that and updated the repo. Please refer to [this link][https://drive.google.com/file/d/1xasjb7Q2nROiwDDeUVHrC6GjIEAm0HRs/view] for the poses and take a look at the dataloader script

the objective of our work was to apply neural radiance fields in medical images, but there are differences compared to "natural images"; color, structures, camera system, availability, etc. So our contribution is an attempt to bridge that gap by using the "most suitable" approach (in that time) to our task. One of my collaborators got very good results with pixelNeRF but using the whole CT volume, you can take a look at the script However, we couldn't manage to make it work with few projections.

I'm very sorry for interrupting so many times. Do you have the email address of this collaborator, I would like to inquire about the ct results of pixelnerf. Because he only uploaded the configuration file, and did not add comments or run commands, etc., so I would not use this configuration file. Or can you tell me, how can I run pixelnerf on ct data? Thank you very much.

And how do you get the value of focal near and far? how to compute？Do these values have an effect on the results？

Hi, We trained pixelNerf from scratch with our data. For that, we modified the dataloader, especially the camera part. You need the camera matrices to train pixelNerf. Since we generated the DRRs using Plastimatch, we referred to their projection geometry and Projection matrix documentation to generated the camera matrices.

From this, it seems that the parameters cx and cy are 0 for the knee and chest images. Is it really like that or I am missing something?

That is correct, both are zero. Basically, the intrinsic parameters are fixed for all chest instances or knees.


Jbuilder not being loaded for isolated packages

I was trying to run unit tests for bullet_train-super_scaffolding when I ran into this error.
I added gem "jbuilder" to the Gemfile and ran bundle install, but still got the same thing.
I ended up adding require "jbuilder" to jbuilder-schema/lib/jbuilder/schema.rb and that solved the problem, but I haven't worked with this gem enough to know if that's a valid solution or not.
/Users/gabriel_zayas/.rbenv/versions/3.0.2/lib/ruby/gems/3.0.0/gems/jbuilder-schema-2.0.3/lib/jbuilder/schema.rb:7:in `<top (required)>': uninitialized constant Jbuilder (NameError)
	from /Users/gabriel_zayas/.rbenv/versions/3.0.2/lib/ruby/gems/3.0.0/gems/bullet_train-api-1.1.15/lib/bullet_train/api.rb:13:in `require'
	from /Users/gabriel_zayas/.rbenv/versions/3.0.2/lib/ruby/gems/3.0.0/gems/bullet_train-api-1.1.15/lib/bullet_train/api.rb:13:in `<top (required)>'
	from /Users/gabriel_zayas/.rbenv/versions/3.0.2/lib/ruby/3.0.0/bundler/runtime.rb:79:in `require'
	from /Users/gabriel_zayas/.rbenv/versions/3.0.2/lib/ruby/3.0.0/bundler/runtime.rb:79:in `rescue in block in require'
	from /Users/gabriel_zayas/.rbenv/versions/3.0.2/lib/ruby/3.0.0/bundler/runtime.rb:57:in `block in require'
	from /Users/gabriel_zayas/.rbenv/versions/3.0.2/lib/ruby/3.0.0/bundler/runtime.rb:50:in `each'
	from /Users/gabriel_zayas/.rbenv/versions/3.0.2/lib/ruby/3.0.0/bundler/runtime.rb:50:in `require'
	from /Users/gabriel_zayas/.rbenv/versions/3.0.2/lib/ruby/3.0.0/bundler.rb:174:in `require'
	from /Users/gabriel_zayas/work/bt/bullet_train-super_scaffolding/test/dummy/config/application.rb:7:in `<top (required)>'
	from /Users/gabriel_zayas/work/bt/bullet_train-super_scaffolding/test/dummy/config/environment.rb:2:in `require_relative'
	from /Users/gabriel_zayas/work/bt/bullet_train-super_scaffolding/test/dummy/config/environment.rb:2:in `<top (required)>'
	from /Users/gabriel_zayas/work/bt/bullet_train-super_scaffolding/test/test_helper.rb:4:in `require_relative'
	from /Users/gabriel_zayas/work/bt/bullet_train-super_scaffolding/test/test_helper.rb:4:in `<top (required)>'
	from /Users/gabriel_zayas/work/bt/bullet_train-super_scaffolding/test/lib/scaffolding/block_manipulator_test.rb:1:in `require'
	from /Users/gabriel_zayas/work/bt/bullet_train-super_scaffolding/test/lib/scaffolding/block_manipulator_test.rb:1:in `<top (required)>'
	from /Users/gabriel_zayas/.rbenv/versions/3.0.2/lib/ruby/gems/3.0.0/gems/railties-7.0.4/lib/rails/test_unit/runner.rb:47:in `require'
	from /Users/gabriel_zayas/.rbenv/versions/3.0.2/lib/ruby/gems/3.0.0/gems/railties-7.0.4/lib/rails/test_unit/runner.rb:47:in `block in load_tests'
	from /Users/gabriel_zayas/.rbenv/versions/3.0.2/lib/ruby/gems/3.0.0/gems/railties-7.0.4/lib/rails/test_unit/runner.rb:47:in `each'
	from /Users/gabriel_zayas/.rbenv/versions/3.0.2/lib/ruby/gems/3.0.0/gems/railties-7.0.4/lib/rails/test_unit/runner.rb:47:in `load_tests'
	from /Users/gabriel_zayas/.rbenv/versions/3.0.2/lib/ruby/gems/3.0.0/gems/railties-7.0.4/lib/rails/test_unit/runner.rb:40:in `run'
	from /Users/gabriel_zayas/.rbenv/versions/3.0.2/lib/ruby/gems/3.0.0/gems/railties-7.0.4/lib/rails/commands/test/test_command.rb:33:in `perform'
	from /Users/gabriel_zayas/.rbenv/versions/3.0.2/lib/ruby/gems/3.0.0/gems/thor-1.2.1/lib/thor/command.rb:27:in `run'
	from /Users/gabriel_zayas/.rbenv/versions/3.0.2/lib/ruby/gems/3.0.0/gems/thor-1.2.1/lib/thor/invocation.rb:127:in `invoke_command'
	from /Users/gabriel_zayas/.rbenv/versions/3.0.2/lib/ruby/gems/3.0.0/gems/thor-1.2.1/lib/thor.rb:392:in `dispatch'
	from /Users/gabriel_zayas/.rbenv/versions/3.0.2/lib/ruby/gems/3.0.0/gems/railties-7.0.4/lib/rails/command/base.rb:87:in `perform'
	from /Users/gabriel_zayas/.rbenv/versions/3.0.2/lib/ruby/gems/3.0.0/gems/railties-7.0.4/lib/rails/command.rb:48:in `invoke'
	from /Users/gabriel_zayas/.rbenv/versions/3.0.2/lib/ruby/gems/3.0.0/gems/railties-7.0.4/lib/rails/commands.rb:18:in `<top (required)>'
	from /Users/gabriel_zayas/.rbenv/versions/3.0.2/lib/ruby/gems/3.0.0/gems/railties-7.0.4/lib/rails/engine/commands.rb:9:in `require'
	from /Users/gabriel_zayas/.rbenv/versions/3.0.2/lib/ruby/gems/3.0.0/gems/railties-7.0.4/lib/rails/engine/commands.rb:9:in `<top (required)>'
	from bin/rails:14:in `require'
	from bin/rails:14:in `<main>'
/Users/gabriel_zayas/.rbenv/versions/3.0.2/lib/ruby/3.0.0/bundler/runtime.rb:66:in `require': cannot load such file -- bullet_train-api (LoadError)
	from /Users/gabriel_zayas/.rbenv/versions/3.0.2/lib/ruby/3.0.0/bundler/runtime.rb:66:in `block (2 levels) in require'
	from /Users/gabriel_zayas/.rbenv/versions/3.0.2/lib/ruby/3.0.0/bundler/runtime.rb:61:in `each'
	from /Users/gabriel_zayas/.rbenv/versions/3.0.2/lib/ruby/3.0.0/bundler/runtime.rb:61:in `block in require'
	from /Users/gabriel_zayas/.rbenv/versions/3.0.2/lib/ruby/3.0.0/bundler/runtime.rb:50:in `each'
	from /Users/gabriel_zayas/.rbenv/versions/3.0.2/lib/ruby/3.0.0/bundler/runtime.rb:50:in `require'
	from /Users/gabriel_zayas/.rbenv/versions/3.0.2/lib/ruby/3.0.0/bundler.rb:174:in `require'
	from /Users/gabriel_zayas/work/bt/bullet_train-super_scaffolding/test/dummy/config/application.rb:7:in `<top (required)>'
	from /Users/gabriel_zayas/work/bt/bullet_train-super_scaffolding/test/dummy/config/environment.rb:2:in `require_relative'
	from /Users/gabriel_zayas/work/bt/bullet_train-super_scaffolding/test/dummy/config/environment.rb:2:in `<top (required)>'
	from /Users/gabriel_zayas/work/bt/bullet_train-super_scaffolding/test/test_helper.rb:4:in `require_relative'
	from /Users/gabriel_zayas/work/bt/bullet_train-super_scaffolding/test/test_helper.rb:4:in `<top (required)>'
	from /Users/gabriel_zayas/work/bt/bullet_train-super_scaffolding/test/lib/scaffolding/block_manipulator_test.rb:1:in `require'
	from /Users/gabriel_zayas/work/bt/bullet_train-super_scaffolding/test/lib/scaffolding/block_manipulator_test.rb:1:in `<top (required)>'
	from /Users/gabriel_zayas/.rbenv/versions/3.0.2/lib/ruby/gems/3.0.0/gems/railties-7.0.4/lib/rails/test_unit/runner.rb:47:in `require'
	from /Users/gabriel_zayas/.rbenv/versions/3.0.2/lib/ruby/gems/3.0.0/gems/railties-7.0.4/lib/rails/test_unit/runner.rb:47:in `block in load_tests'
	from /Users/gabriel_zayas/.rbenv/versions/3.0.2/lib/ruby/gems/3.0.0/gems/railties-7.0.4/lib/rails/test_unit/runner.rb:47:in `each'
	from /Users/gabriel_zayas/.rbenv/versions/3.0.2/lib/ruby/gems/3.0.0/gems/railties-7.0.4/lib/rails/test_unit/runner.rb:47:in `load_tests'
	from /Users/gabriel_zayas/.rbenv/versions/3.0.2/lib/ruby/gems/3.0.0/gems/railties-7.0.4/lib/rails/test_unit/runner.rb:40:in `run'
	from /Users/gabriel_zayas/.rbenv/versions/3.0.2/lib/ruby/gems/3.0.0/gems/railties-7.0.4/lib/rails/commands/test/test_command.rb:33:in `perform'
	from /Users/gabriel_zayas/.rbenv/versions/3.0.2/lib/ruby/gems/3.0.0/gems/thor-1.2.1/lib/thor/command.rb:27:in `run'
	from /Users/gabriel_zayas/.rbenv/versions/3.0.2/lib/ruby/gems/3.0.0/gems/thor-1.2.1/lib/thor/invocation.rb:127:in `invoke_command'
	from /Users/gabriel_zayas/.rbenv/versions/3.0.2/lib/ruby/gems/3.0.0/gems/thor-1.2.1/lib/thor.rb:392:in `dispatch'
	from /Users/gabriel_zayas/.rbenv/versions/3.0.2/lib/ruby/gems/3.0.0/gems/railties-7.0.4/lib/rails/command/base.rb:87:in `perform'
	from /Users/gabriel_zayas/.rbenv/versions/3.0.2/lib/ruby/gems/3.0.0/gems/railties-7.0.4/lib/rails/command.rb:48:in `invoke'
	from /Users/gabriel_zayas/.rbenv/versions/3.0.2/lib/ruby/gems/3.0.0/gems/railties-7.0.4/lib/rails/commands.rb:18:in `<top (required)>'
	from /Users/gabriel_zayas/.rbenv/versions/3.0.2/lib/ruby/gems/3.0.0/gems/railties-7.0.4/lib/rails/engine/commands.rb:9:in `require'
	from /Users/gabriel_zayas/.rbenv/versions/3.0.2/lib/ruby/gems/3.0.0/gems/railties-7.0.4/lib/rails/engine/commands.rb:9:in `<top (required)>'
	from bin/rails:14:in `require'
	from bin/rails:14:in `<main>'

@kaspth Can you please look at this? I'm not sure how that should be.

@gazayas where did you put gem "jbuilder" in the Gemfile, before or after jbuilder-schema?
I think I removed the require "jbuilder" call under the assumption that people would do:
# Gemfile
gem "jbuilder"
gem "jbuilder-schema"

…and then Bundler would've activated and required Jbuilder before Jbuilder::Schema.

Nevermind, I could confirm the issue and shipped the proposed fix in https://github.com/bullet-train-co/jbuilder-schema/commit/b0b2270c4044202de90febc539be8e98899b9c79

No problem, I also just confirmed that tests are passing in the gem, thank you!


WIP: Faster cold cache LSP startup by re-using ASTs for hashing

WIP: Faster cold cache LSP startup by re-using ASTs for hashing. Not yet benchmarked yet, but since parsing is so slow I'm hoping a simple AST pass will be faster.
Improvements:

Files are only parsed once at startup. The AST from pipeline::index is rewritten into an AST for an empty GlobalState which can be used for hashing purposes.
The pass that rewrites the AST does double duty and collects sends and constant references (core::UsageHash), which removes the need for an extra full AST pass.

The main change involved adding a second type of ast::substitute pass that supports lazily adding new names to a GlobalState. (The existing pass is designed to re-use a lookup table constructed for all names in a GlobalState for many passes, whereas the lazy pass only cares about the subset of names in one particular AST.)
TODO:

LSPIndexer should use this same logic for file edits, not just startup.

Motivation

Speed!
Test plan

Covered by existing tests.

We have a policy of testing changes to Sorbet against Stripe's codebase before
merging them. I've kicked off a test run for the current PR.  When the build
finishes, I'll share with you whether or how it failed. Thanks!
Stripe employees can see the build results here:
→ https://go/builds/bui_IqPVAG1icGVhkT
→ https://go/builds/bui_IqPVl1jNr9HTpN

We have a policy of testing changes to Sorbet against Stripe's codebase before
merging them. I've kicked off a test run for the current PR.  When the build
finishes, I'll share with you whether or how it failed. Thanks!
Stripe employees can see the build results here:
→ https://go/builds/bui_IqPVAG1icGVhkT
→ https://go/builds/bui_IqPVl1jNr9HTpN

We have a policy of testing changes to Sorbet against Stripe's codebase before
merging them. I've kicked off a test run for the current PR.  When the build
finishes, I'll share with you whether or how it failed. Thanks!
Stripe employees can see the build results here:
→ https://go/builds/bui_IqPgLtYdP3GxEi
→ https://go/builds/bui_IqPgQRRsxLBZnq

We have a policy of testing changes to Sorbet against Stripe's codebase before
merging them. I've kicked off a test run for the current PR.  When the build
finishes, I'll share with you whether or how it failed. Thanks!
Stripe employees can see the build results here:
→ https://go/builds/bui_IqPgLtYdP3GxEi
→ https://go/builds/bui_IqPgQRRsxLBZnq

We have a policy of testing changes to Sorbet against Stripe's codebase before
merging them. I've kicked off a test run for the current PR.  When the build
finishes, I'll share with you whether or how it failed. Thanks!
Stripe employees can see the build results here:
→ https://go/builds/bui_IqSDpGR1lP5hmV
→ https://go/builds/bui_IqSDT5xfk6TyQS

We have a policy of testing changes to Sorbet against Stripe's codebase before
merging them. I've kicked off a test run for the current PR.  When the build
finishes, I'll share with you whether or how it failed. Thanks!
Stripe employees can see the build results here:
→ https://go/builds/bui_IqSDpGR1lP5hmV
→ https://go/builds/bui_IqSDT5xfk6TyQS

We have a policy of testing changes to Sorbet against Stripe's codebase before
merging them. I've kicked off a test run for the current PR.  When the build
finishes, I'll share with you whether or how it failed. Thanks!
Stripe employees can see the build results here:
→ https://go/builds/bui_IqiNpCNvRTjDVP
→ https://go/builds/bui_IqiNRqqSoa1uUs

We have a policy of testing changes to Sorbet against Stripe's codebase before
merging them. I've kicked off a test run for the current PR.  When the build
finishes, I'll share with you whether or how it failed. Thanks!
Stripe employees can see the build results here:
→ https://go/builds/bui_IqiNpCNvRTjDVP
→ https://go/builds/bui_IqiNRqqSoa1uUs


Update the gpt model from davinci to turbo

Purpose
Switching the default model from davinci to turbo because davinci was depreciated on July 6th and you can no longer deploy with it.
Does this introduce a breaking change?
[ ] Yes
[X ] No
Pull Request Type
What kind of change does this Pull Request introduce?
[X ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

## How to Test
*  Get the code

git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install

* Test the code
<!-- Add steps to run the tests suite and/or manually test -->

## What to Check
Verify that the following are valid
* ...

## Other Information
<!-- Add any other helpful information that may be needed here. -->

Will test this...

It looks like the correct change. @coolcsh Has the search quality degraded on the sample with the change? That's what we experienced for our Python sample, due to gpt35-turbo not generating well formatted search queries.
For example, with davinci-
"Northwind Health Plus" plan benefits comparison standard
With gpt35-turbo-
+Northwind +"Health Plus" +"plan" +"coverage" +"additional benefits"
We havent figured out a better prompt yet.
Another approach is to use the built in datasources parameter, ala
https://github.com/microsoft/sample-app-aoai-chatGPT/blob/main/app.py
Those are both larger changes though!


Combine the two device model files

Change-type: patch
Signed-off-by: Thodoris Greasidis<EMAIL_ADDRESS>
Contributor checklist

[ ] Includes tests
[ ] Includes typings
[ ] Includes updated documentation
[ ] Includes updated build output

@balena-ci I self-certify!


attempt to index field 'BottomButtonFrame' (a nil value)

Open ROBLOX Studio
Open a new place
Click the Test tab and change the emulation device to a mobile device (e.g. iPhone 6)
Click the play button
Hit escape to open up the menu
Click on the "Settings" tab then the "Report" tab then "Help" then "Record"
The following error shows up:

CoreGui.RobloxGui.Modules.Settings.Pages.Help:458: attempt to index field 'BottomButtonFrame' (a nil value)
Stack Begin
Script 'CoreGui.RobloxGui.Modules.Settings.Pages.Help', Line 458
Stack End

This issue was moved to GitBlox/Core-Scripts#28

Ah, this one. I had a fix for it somewhere but didn't get around to committing it. This same issue also makes the wrong type of buttons show up on large touchscreen form factors.

I can't seem to replicate this, as none of my emulators have a record tab.


Update Pitest to 1.5.2

Motivation
The current version bundled version, 1.4.11, does not work in my setup while running the gradle plugin using 1.5.2 works.
I upgraded the gradle version after encountering this error in stackoverflow:
Proposed Solution
Update the pitest bundled version to 1.5.2

I see no problem in upgrading embedded Pitest's version however I don't understand how it would help you. Isn't the issue related to Pitest's Gradle plug-in rather than to Pitest itself?
I actually suspect that Pitclipse does not behave as expected with your project because it is likely not aware of Gradle dependencies. Could you detail what you mean by "does not work" and the error/logs you have when running PIT through Pitclipse?

Hi,
It could be the version of the Gradle plug-in, but I have no way of trying because the version 1.4.X of the plugin/pitest does not work either in Gradle.
By not working I mean that I can run the tests using the PIT Mutation Test Launch configuration, but I get this result:

Here is the console output in Eclipse: https://gist.github.com/ebramirez/a378952fad933659ae8d9a9b46945982

Thank you very much for providing the full log. Tests are wrote with JUnit 5, aren't they? This is not reflected in the configuration you gave in StackOverflow but the logs show dependencies to JUnit Jupiter.
That matters because Pitclipse has to explicitely tell Pitest whether tests are written in JUnit 4 (default) or JUnit 5. The issue is that, currently, Pitclipse doesn't check dependencies fetched by third-parties and likely doesn't detect JUnit 5 in your project's classpath. The same issue has already been reported for Maven: #116.

Thanks for the quick response.
The StackOverflow question is not mine, I just found it while searching for the some guidance.
Yes, the tests a written in JUnit5 and is configured as such in Gradle:
plugins {
   id 'info.solidsoft.pitest' version '1.5.1'
}

pitest {
    junit5PluginVersion = '0.12'
    testSourceSets = [sourceSets.test]
}

How do I configure that in Pitclipse?

How do I configure that in Pitclipse?

Currently you can't: I'll work on this as soon as possible. Meanwhile, a possible workaround might be to add the JUnit 5 library to the project:

Right-click on the project > Build Path > Add libraries...
JUnit > Next
Select JUnit 5 > Finish

But it will likely caused conflicts with the JUnit 5 JARs pulled by Gradle.
Sorry for the inconvience, I'll keep you updated as soon as a fix is available.

I've just deployed a new 2.2.1 version which should detect JUnit 5 even when provided by Gradle (but doesn't embed Pitest 1.5.2 yet). Could you test it and confirm that it does fix the issue?
If it doesn't, would you mind sharing a sample project where the analysis fails?

I can confirm that this works now in Eclipse 4.16.
Thank you very much @echebbi!


⚠ Bofrost.lu has degraded performance

In 77f4b96, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 934 ms

Resolved: Bofrost.lu performance has improved in c69466b after 13 minutes.


Open in iBooks missing on options when I share a pdf

Hi,
I'm sharing a local pdf using the following call:
window.plugins.socialsharing.share(null, null, fileEntry.nativeURL)
Where fileEntry.nativeURL = file:///var/mobile/Containers/Data/Application/40DEAE99-6D19-4505-B403-573029CFC829/Library/NoCloud/337d7eeae6dd818a1d5d7909cd363c83.pdf
On ActionSheet only Mail and Slack options are available, "Open in iBooks" is missing
The path of file is good because I can share it by mail.
To guarantee files permissions are correctly setted I've tried using fileopener2 plugin in place of SocialSharing and the option "Open in iBooks" appears and works
cordova.plugins.fileOpener2.open(fileEntry.nativeURL, 'application/pdf', success, error)
Should I set something else to allow "Open in iBooks" from SocialSharing ?
Thanks for your help

re-Hi,
please any help about this issue ?

Will take a look!

Hi, fileopener2 uses the UIDocumentInteractionController, this plugin uses SLComposeViewController. The latter filters out any app that can't receive an image when a file is passed in. So these are really two different beasts.

Thanks Eddy for your reply,
that means this SocialSharing plugin shouldn't suggest to open on iBooks ?
I've seen mentioned on an old issue #307 that appears on options "open in ibooks", it's why I've tried to find out how to reach it.
And using shareVia it couldn't work ? I've also tested without success.

Ah I see, perhaps that changed in iOS internally then.. I see there's something new in iOS called UIActivityTypeOpenInIBooks so perhaps we will see the revival of iBooks one day. Leaving this open..


Line Chart Component - Typo in Code Sample

Hey Team,
When reading through the docs I got tripped up by the code sample within the Line Chart Component. The index prop has a value of "name", but I believe it should be "year"?
export default LineChart = () => (
  <Card>
    <Title>Population growth rate (1951 to 2021)</Title>
    <LineChart
      className="mt-6"
      data={chartdata}
      index="name"   // <--- Incorrect attribute value.
      categories={["Population growth rate"]}
      colors={["blue"]}
      valueFormatter={dataFormatter}
      yAxisWidth={40}
    />
  </Card>

Keep up the great work on the lib!
Cheers

Thank you for pointing this out, will be fixed asap!


feat(routes): rework ui from login and register page

This PR improves the UI of the login and register pages. Please don't change the design so much this time. 😹
Before
Login

Register

Mobile (Semi responsive)

After
Login

Register

Mobile (Full responsive)

😍 Love it! Thank you very much! 🤯


Godot becomes slow after a while in launching/loading a project/launching a game [scene]

Godot version:

3.0.5, 3.0.6. If it starts in one it also occurs in the other.
OS/device including version:

Windows 10 64-bit
1080 Ti
Drivers: 398.82, not sure if it's a driver-related problem
Issue description:

Since yesterday I've been plagued by a really annoying problem - Godot becomes slow after a while.
It affect launching Godot (Debug window appears immediately, but it takes a 30+ seconds for the project list to appear), loading a project, and launching a game, either in-editor or by itself.
At first happened while I was in already in the editor (So I only noticed it takes a while to launch the game (= main scene), but after I re-launched the editor it continued, and I found out it affect everything else I mentioned.
Restarting my PC fixes it, but it returns eventually. At first I thought it requires that the editor to be open, but today I tried to launch the editor again (after using it yesterday with the bug still not occurring) and it happened.
I'll have to check if it's only related to my game project or not. I'll update you as soon as possible.
Edit: Forgot to mention that it also froze a few times on the "loading a project" part, but I'm not sure if it's due to my lack of patience and would have been able to load it eventually or not.
Steps to reproduce:
Launch Godot at least once, load a project, play around a bit (?), either close or leave it open and then it starts.
Minimal reproduction project:

I'll upload my game project soon if I find out I can't reproduce the problem in another project.

I've spent these few hours in anticipation for it to happen with a different project. It didn't. I'm gonna try and see how long it takes for it to occur with my project, for a better estimate.
@dragmz Could you explain how to enable handle counters for me to verify that?
Also, how is working with the master branch? Is it considered stable? Do I need to compile it myself? Sorry for the newbie questions ;p

@ejnij you can try a nightly build available here: https://hugo.pro/projects/godot-builds/
Don't think you need to look at the performance counters. Just give it a try with a nightly build and see if it still slows down for you.

Related to #20566.

@akien-mga I don't think it's related, in my case it takes quite a while before it happens so it's more logical to be related to what @dragmz said. Anyway, so far it doesn't happen in nightly build, but I'll give it another day just to be safe.
BTW got a problem with the nightly build - I'm trying to export and the executable only shows the splash/loading screen of Godot for a second and then closes. The game/scene works in-editor so I'm not what's the problem. Also, is there any way to hide warnings? (and only show errors?)

BTW got a problem with the nightly build - I'm trying to export and the executable only shows the splash/loading screen of Godot for a second and then closes.

If you're using nightly builds you can't use the templates from stable. You need to get templates for the same version you are using, either by getting from the provider (if they have it) or by compiling yourself.

I can confirm that this bug with the exact behaviour still happens in the latest betas for Godot 4. Everything works fine until after some time project loads are VERY slow and project runs take forever to open the game window. Closing an re-opening Godot does not fix the issue, only restarting the whole PC. After a restart it takes a few until this happens again but eventually, it happens.
Note that for me this is not on Windows.
<EMAIL_ADDRESS>MacBook Pro (13-inch, M1, 2020) 16GB
Godot v4.0.beta6.official

@saaymeen If you can't reproduce this issue in 3.5.1, this is likely the same cause as https://github.com/godotengine/godot/issues/68269.


python3Packages.convertdate: disable on older Python releases

Description of changes
Only Python 3.7 and above is supported.

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

It's not a problem, but I see no reason for detour via staging.


spec: contradiction in the definition of terminating statements

According to https://golang.org/ref/spec#Terminating_statements, the if statement below is a terminating statement by virtue of 1., 3., and 4.:
func main() {
    if true {
        goto L
    } else {
        goto L
    }
L:  println("this gets printed")
}

At the same time, the first sentence reads:

A terminating statement prevents execution of all statements that lexically appear after it in the same block.

The labeled statement, however, gets executed.

You don't need an if to find a contradiction if you read that sentence about preventing execution in that way, just take:
func main() {
	goto L
L:
	println("hi")
}

goto L is terminating due to (1) and yet the println( ) call gets executed.
But really it seems to me that in this sentence:

A terminating statement prevents execution of all statements that lexically appear after it in the same block

"prevents execution" only means that the control is transferred elsewhere. But if the control goes back to these  statements (for example due to a GOTO) then nothing forbids them to be executed.
cc @griesemer

Good point.
Btw, I found the backstory of that sentence: https://github.com/golang/go/issues/23215.

Actually, I think @3bodar has a point - the informal clarification I added in CL 85215 looks incorrect to me, now. The definition clearly says that a goto statement is a terminating statement. Yet, the labeled statement following it is in the same block and it is executed.
The notion of a terminating statement is only used in one place in the spec, for functions returning results. For that purpose, the definition is correct (if a labeled statement is the final statement in a statement list of such a function, that statement list is not terminating, if it's a goto statement, it is terminating). The informal clarification doesn't matter for this.
But the clarification is misleading as it is.

If that's the only role of the concept of terminating statements, something like
"The final non-empty statement in a function declaring result parameters must be a terminating statement."
might make more sense.

@3bodar The spec says that already. The original prose for terminating statements was correct; it's just the additional sub-sentence added with CL 85215, intended to provide some intuition, was imprecise. We can make that more precise, or we can just remove it again.

@griesemer
I see, that is said in the "Function declarations" section.
But even though the proposed change in CL 349172 fixes the incorrect sentence, it seems to me there are a couple issues with it:

when I read the (correct) statement A terminating statement terminates the regular flow of control in a block., it leaves me asking why aren't break and continue terminating statements.
if I understand correctly, https://github.com/golang/go/issues/23215 was about clarifying to the reader the reason why the spec defines the notion in the first place. The changed version does not do that, I think.

So I would suggest a rewording of my original suggestion, to make it fit as an introcutory sentence:
"Terminating statements define the subset of statements permissible as the final non-empty statement in a function declaring result parameters."
This would repeat what is said elsewhere, but if prepended to the currently proposed change, would serve the purpose of clarifying why these are there at all.
P.S. I don't yet have a good grasp of the spec, so I may be making some wrong assumptions. If so, please ignore the above.

"Terminating statements define the subset of statements permissible as the final non-empty statement in a function declaring result parameters." is a fine sentence to start the section - but as a matter of style and to avoid having subtle inconsistencies in the spec we have tried to avoid repeating ourselves. And as you say yourself, the sentence would only explain why this section is here in the first place, and not provide much intuition about the terminating statements.
I agree with you that trying to provide a precise intuitive explanation is likely going to be cumbersome which is why the pending CL doesn't try much in that direction. Let's see what the other reviewers say. We can always just say nothing and revert to the original prose which was correct. The primary goal here is to fix the inconsistency.
An alternative might be to put the definition of "terminating statements" into an appendix of the spec, as it primarily serves as a precise definition for a specific function requirement. Looking forward to the changes for generics, we may have more such sections in the near future which would fit best into an appendix.
But again, let's see what others think.
Thanks.


"SSH2" protocol is implemented in a bad way

Hello!
I'm glad with "SuperPutty" but I've a question:
Why "SSH2" is included as a protocol if Putty needs "-2" parameter to reconigse it?
From Putty documentation:

3.8.1 Starting a session from the command line
   These options allow you to bypass the configuration window and
   launch straight into a session.

   To start a connection to a server called `host':

     putty.exe [-ssh | -telnet | -rlogin | -raw] [user@]host

If you want to use SSH2 you must inform to Putty/KiTTY by using "-2" parameter.

Not sure what you mean, if you setup a putty profile and set Connection->SSH->2 Only 'on', then tell superputty to use that profile, it should use ssh2 by default. have you actually tested it and confirmed it?

But "Quick conenction toolbar" is usefull for this: do quick connections without setuping profiles!
You're have a list where "SSH2" can be selectable while it's false: using your words "a session is needed".


Fix demo link in readme

Amazing project mate! Really love it!
Just noticed the demo link on the readme needs to be updated from http://fiala.uk/atrament.js/demo/ to https://www.fiala.space/atrament/demo/
Cheers!

@matthewhartman thank you for reporting this!  Should have been updated a while ago, will sort it out :)


Hub navigation bellow extension placeholder

Category

[x] Question
[ ] Typo
[ ] Bug
[ ] Additional article idea

Expected or Desired Behavior
The HUB navigation should always be the first element on the page, since it's a link between site collections and therefore it is expected to be the very first item in the page hierarchy. Is it possible to change this behavior or provide a setting with which one could set which would show first?
Observed Behavior
When you load an extension this will make the HUB navigation show after the content of the extension.

No, there is not presently a way to change this behavior. As this is a change/feature request, it should be posted to UserVoice: https://aka.ms/sp-dev-uservoice


Redirect entom enquiries

Contact form: They're currently going to<EMAIL_ADDRESS>but should now be directed towards<EMAIL_ADDRESS>

Entom enquiries updated and released to live.


When the window is not in focus, I need to click twice to open a file.

Does this issue occur when all extensions are disabled?: Yes
VS Code Version: 1.88.0
OS Version: Windows 10
When the window is not in focus, I need to click twice to open a file.
This issue started occurring in version 1.87 and still persists in 1.88.
I upgraded from version 1.86 to 1.87.
Here is a video demonstrating the issue:
https://github.com/microsoft/vscode/assets/19665552/05a889bd-2a9f-4532-b659-174c0bc5fedf
Thanks @lramos15 for fixing https://github.com/microsoft/vscode/issues/206585, but it didn't resolve my issue.

I am not sure if this fix has made it into stable, so you might need to use insiders for now:  You can give our preview releases a try from: https://code.visualstudio.com/insiders/

I am not sure if this fix has made it into stable, so you might need to use insiders for now: You can give our preview releases a try from: https://code.visualstudio.com/insiders/

Thank you very much. The 1.89 insider's version has fixed this issue. When will it be released to the stable version?

First week of May.


Module '${moduleName}' the installed version is invalid : npm install` as a quickfix ?

Hi !
Currently, if there is a mismatch between package.json and the installed version of a package in /node_modules, this error will be shown while hovering the version number:
Module '${moduleName}' the installed version is invalid
However there is no quick fix for it. I'd like to contribute to it by adding two fixes :

npm install ${moduleName} if there are other mismatches
npm install ${moduleName} if there is only this mismatch

How should I go about doing this ? This would be a first contribution to vscode for me and I'm not sure if it's possible to invoke the console with already-filled command from quick fix context ?

Validation support has been removed pls see https://github.com/microsoft/vscode-npm-scripts/issues/172


looking so large in web app

hey Chris, really like your package, I am currently using this in a web project but it's looking so weirdly large, i would like to know if there is an option to manage the size of it, thank you.

Ok. Right now, I see two options here:

If you don't need the dialog, you can implement it as a widget (see example) and just size the parent to your liking.
If you do want to have the dialog, you can use meanwhile a custom one (see also example) and style it accordingly.

I will think about adding parameters for this, but it might take a while.

thank you for now i am using custom one.


Fix int overflow in FixedByteValueReaderWriter

Fix the integer overflow in FixedByteValueReaderWriter
Optimize the performance by replacing byte-by-byte read/write with bulk read/write

Codecov Report

Merging #3385 into master will decrease coverage by 0.07%.
The diff coverage is 77.77%.

@@             Coverage Diff              @@
##             master    #3385      +/-   ##
============================================
- Coverage     70.54%   70.47%   -0.08%
  Complexity        4        4
============================================
  Files           990      990
  Lines         45430    45450      +20
  Branches       6097     6097
============================================
- Hits          32049    32030      -19
- Misses        11275    11311      +36
- Partials       2106     2109       +3

Impacted Files
Coverage Δ
Complexity Δ

.../core/io/util/DictionaryDelegatingValueReader.java
30.76% <0%> (ø)
0 <0> (ø)
:arrow_down:

...pinot/core/io/util/FixedByteValueReaderWriter.java
87.8% <84%> (-7.44%)
0 <0> (ø)

...om/linkedin/pinot/client/PinotClientException.java
33.33% <0%> (-33.34%)
0% <0%> (ø)

...pinot/broker/api/resources/PinotClientRequest.java
23.8% <0%> (-19.05%)
0% <0%> (ø)

...inot/client/JsonAsyncHttpPinotClientTransport.java
58.82% <0%> (-17.65%)
0% <0%> (ø)

...lix/EmptyBrokerOnlineOfflineStateModelFactory.java
86.66% <0%> (-13.34%)
0% <0%> (ø)

...pinot/core/operator/docidsets/OrBlockDocIdSet.java
84.9% <0%> (-13.21%)
0% <0%> (ø)

...ore/query/scheduler/resources/ResourceManager.java
87.09% <0%> (-9.68%)
0% <0%> (ø)

.../predicate/NotEqualsPredicateEvaluatorFactory.java
84.74% <0%> (-6.78%)
0% <0%> (ø)

...impl/dictionary/DoubleOnHeapMutableDictionary.java
75.55% <0%> (-6.67%)
0% <0%> (ø)

... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 526ba5d...7e47037. Read the comment docs.


Unpickling collection.deque fails with ValueError on Python 3.6

======================================================================
ERROR: Make sure we can handle collections.deque
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/private/tmp/jsonpickle/jsonpickle/tests/object_test.py", line 315, in test_deque_roundtrip
    new_deque = jsonpickle.decode(encoded)
  File "/private/tmp/jsonpickle/jsonpickle/jsonpickle/__init__.py", line 152, in decode
    return unpickler.decode(string, backend=backend, keys=keys)
  File "/private/tmp/jsonpickle/jsonpickle/jsonpickle/unpickler.py", line 27, in decode
    return context.restore(backend.decode(string), reset=reset)
  File "/private/tmp/jsonpickle/jsonpickle/jsonpickle/unpickler.py", line 120, in restore
    value = self._restore(obj)
  File "/private/tmp/jsonpickle/jsonpickle/jsonpickle/unpickler.py", line 162, in _restore
    return restore(obj)
  File "/private/tmp/jsonpickle/jsonpickle/jsonpickle/unpickler.py", line 243, in _restore_object
    instance = handler(self).restore(obj)
  File "/private/tmp/jsonpickle/jsonpickle/jsonpickle/handlers.py", line 218, in restore
    factory, args = [restore(i, reset=False) for i in data['__reduce__']]
ValueError: too many values to unpack (expected 2)

----------------------------------------------------------------------

I get the same error running that test on python 3.6.

strangely reduce returns a 4-element tuple on python 3.6, eg:
[<class 'collections.deque'>, ((), 60), None, <list_iterator object at 0x7fad705f8f60>]

https://docs.python.org/3/library/pickle.html#object.__reduce__ states, that the reduce result tuple can contain two till five values. So I think the tuple unpacking jsonpickle does not treat that right, because it always tries to split in two values.

✨ 🍰 ✨

This is broken because SimpleReduceHandler existed to handle the python 2 reduce protocol. In fact, jsonpickle's default handlers already handle the full protocol. I'm going to open a PR to remove this class.


Allow funding for projects with <100 stars

Hi - I run a reasonably popular service called applause button, which is used by a few hundred websites. The number is rising quite rapidly too!
I've had a few people kindly mention that they would like to donate and I'm interested in using Open Collection to achieve that.
However, applause button is more of a service than an open source project. Because of the way it is consumed I don't think many people get to see the GitHub project and as a result they do not 'star' it.
Would it still be possible to use open collective to collect funds for this project?
By the way, I've looked at other services, but like open collective the most - it is clear and simple, has the option for recurring payments, and an API. In the future I'm looking at attributing costs (you can see this in development here via this endpoint that details the top users and their associated cost each day), and matching these to open collective donations. I think it would be an interesting experiment to publicly show consumption next to donation!

OK, you can ignore this - after a quick appeal on twitter, I have > 100 stars :-)
https://twitter.com/ColinEberhardt/status/1099743091983085570


Update MissingH1.md

:x: Validation status: errors

File
Status
Preview URL
Details

Docset5/Test/MissingH1.md
:x:Error

Details

Docset5/Test/MissingH1.md

[Error] Systemic Error :One or more errors occurred.
at System.Threading.Tasks.Task`1.GetResultCore(Boolean waitCompletionNotification)
at Validations.DocFx.Adapter.OnlineServiceMarkdownValidatorProvider.<>c__DisplayClass3_0.<GetValidators>b__0(MarkdownDocument document). @TinaLiuGirl has been notified.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:x: Validation status: errors

File
Status
Preview URL
Details

Docset5/Test/MissingH1.md
:x:Error

Details

Docset5/index.md
:x:Error

Details

Docset5/Test/MissingH1.md

[Error] Systemic Error :One or more errors occurred.
at System.Threading.Tasks.Task`1.GetResultCore(Boolean waitCompletionNotification)
at Validations.DocFx.Adapter.OnlineServiceMarkdownValidatorProvider.<>c__DisplayClass3_0.<GetValidators>b__0(MarkdownDocument document). @TinaLiuGirl has been notified.

Docset5/index.md

[Error] Systemic Error :One or more errors occurred.
at System.Threading.Tasks.Task`1.GetResultCore(Boolean waitCompletionNotification)
at Validations.DocFx.Adapter.OnlineServiceMarkdownValidatorProvider.<>c__DisplayClass3_0.<GetValidators>b__0(MarkdownDocument document). @TinaLiuGirl has been notified.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:warning: Validation status: warnings

File
Status
Preview URL
Details

Docset5/Test/MissingH1.md
:warning:Warning

Details

Docset5/Test/MissingH1.md

[Warning] A space is required after the hash (#) in H1. See http://aka.ms/MarkdownHeadings for more information.
[Warning] Markdown content is not allowed before H1. See http://aka.ms/MarkdownHeadings for more information.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


eval_mask_branch

Should I set  'eval_mask_branch': False when training?
`config.py
Eval.py sets this if you just want to run YOLACT as a detector
'eval_mask_branch': True,`

Do you want masks? If you don't, you should set it to false, but then why are you using YOLACT? That's really only for benchmarking purposes--if you only want boxes you should use YOLOv3 instead.
If you do want masks, leave it true.


raw_sql api doesn't seem to work within axum handler

Bug Description
Hello,
I am setting up an axum web server with a simple route handler. The handler acquires a connection from the connection pool, and then runs some arbitrary statement. Originally, I was using the sqlx::query_as api, and everything was fine. However, out of curiosity, I tried using sqlx::raw_sql, and my code fails to compile with the following error message:
implementation of `sqlx::Executor` is not general enough
`sqlx::Executor<'0>` would have to be implemented for the type `&mut sqlx::PgConnection`, for any lifetime `'0`...
...but `sqlx::Executor<'1>` is actually implemented for the type `&'1 mut sqlx::PgConnection`, for some specific lifetime `'1`

To me, it looks like both the query_as and raw_sql apis use the Executor trait under the hood. So I'm curious as to why the former can successfully resolve the trait implementation for the PgConnection reference while the latter fails.
Minimal Reproduction
use axum::extract::{Path, Query, State};
use axum::response::{Html, IntoResponse};
use axum::routing::{delete, get, get_service, post, put};
use axum::{handler, Extension, Json, Router};
use core::num;
use serde::Deserialize;
use serde_json::json;
use sqlx::pool::PoolConnection;
use sqlx::postgres::PgPoolOptions;
use sqlx::{Executor, Pool, Postgres};
use std::collections::HashMap;
use std::net::SocketAddr;
use std::sync::Arc;

pub struct AppState {
    pub db: Pool<Postgres>,
}

#[tokio::main]
async fn main() {
    // 1) Create a connection pool
    let poolResult = PgPoolOptions::new()
        .max_connections(5)
        .connect("postgres://postgres:postgres@db:5432/mydb")
        .await;

    if (poolResult.is_ok()) {
        let pool = poolResult.unwrap();
        let routes_all = Router::new()
            .merge(routes_hello())
            .with_state(Arc::new(AppState { db: pool }));

        let addr = SocketAddr::from(([127, 0, 0, 1], 9080));

        println!("listening on {:?}", addr);
        axum::Server::bind(&addr)
            .serve(routes_all.into_make_service())
            .await
            .unwrap();
    } else {
        println!("Failed to connect to db: {:?}", poolResult.err());
    }
}

fn routes_hello() -> Router<Arc<AppState>> {
    Router::new().route("/hello", get(handler_test))
}

async fn handler_test(State(state): State<Arc<AppState>>) -> impl IntoResponse {
    testConnection(state).await;
    Html("text response")
}

async fn testConnection(state: Arc<AppState>) -> () {
    let conn_result = state.db.acquire().await;
    if conn_result.is_ok() {
        let res1 = {
            let mut conn = conn_result.unwrap();
            let raw_query = "SELECT * FROM my_table WHERE id = 1"; // Ensure your table and field exist
            let res: Result<sqlx::postgres::PgQueryResult, sqlx::Error> = sqlx::raw_sql(raw_query)
                .execute(&mut *conn) // Dereference the connection to get a mutable reference
                .await;
        };
    }
}

Interestingly, when I invoke raw_sql outside of the handler (e.g. I run it right after creating the connection pool in the main method), there are no issues. So I'm wondering if the reference through the Arc is somehow messing up the lifetime of the PgConnection?
Info
[dependencies]
tokio = { version = "1", features = ["full"] }
async-trait = "0.1"
axum = "0.6"
# -- Serde
serde = { version = "1", features = ["derive"] }
serde_json = "1"
serde_with = "3"

tower-http = { version = "0.4", features = ["fs"] }

sqlx = { version = "0.7", features = ["postgres", "runtime-tokio-native-tls"] }

Database: Using Postgres, v17.
OS: Windows 10
Rust version: rustc 1.81.0 (eeb90cda1 2024-09-04)

Comparing the signature of the sqlx::raw_sql vs sqlx::query (where the latter works), I did notice one thing.
 pub async fn execute<'e, E>(
        self,
        executor: E,
    ) -> crate::Result<<E::Database as Database>::QueryResult>
    where
        'q: 'e,
        E: Executor<'e>,
    {
        executor.execute(self).await
    }

 #[inline]
    pub async fn execute<'e, 'c: 'e, E>(self, executor: E) -> Result<DB::QueryResult, Error>
    where
        'q: 'e,
        A: 'e,
        E: Executor<'c, Database = DB>,
    {
        executor.execute(self).await
    }

I'm still new to Rust, but it seems like the Executor's lifetime in query ('c) is bounded by 'e (what is 'e referring to?). But raw_sql has no such bound. I wonder if the extra bound on the  query method somehow makes the lifetime "resolvable" by the compiler, because it seems like the issue with raw_sql is that the compiler for whatever reason doesn't know the lifetime of the connection reference, and so is asking for an Executor trait impl that can apply to any lifetime rather than a specific lifetime.

You can change this line
let res: Result<sqlx::postgres::PgQueryResult, sqlx::Error> = sqlx::raw_sql(raw_query)
    .execute(&mut *conn) // Dereference the connection to get a mutable reference
    .await;

to
 let res: Result<sqlx::postgres::PgQueryResult, sqlx::Error> =
    conn.execute(sqlx::raw_sql(raw_query)).await;

then it should compile

Thanks @joeydewaal , that worked. I am curious as to why that worked, since it looks both routes end up invoking the Executor trait's execute function.
Why was the latter able to resolve the Executor trait impl on the PgConnection, but the former approach was unable to?

And along the same lines, why is the following able to compile?
let res: Result<sqlx::postgres::PgQueryResult, sqlx::Error> = sqlx::query(raw_query)
    .execute(&mut *conn) // Dereference the connection to get a mutable reference
    .await;


executable permission setting preventing use by users on multi-user Linux system

We're installing INLA on a Linux cluster, via install.packages("INLA",repos=c(getOption("repos"),INLA="https://inla.r-inla-download.org/R/stable"), dep=TRUE), which installs the binary package.
When users try to use it, they get a permission denied error for inla.mkl.run and other INLA executables.
The permissions for the inla and fmesher executables in bin/linux/64bit in the installed package are set to 744 rather than being set to 755. I see that in r-inla/utils/R/updateBin line 10, you change to 755, but perhaps something is causing this not to be done when building the binary package?

Hi Chris!
does this happens also after you instal another binary, with
inla.binary.install()
?

Running inla.binary.install() after the initial install causes the permissions to be set to 755, as desired.

I do not know what is happening when R install the package. no one else has reported this issue, so maybe it is something spesific on your side, like a more restrictive 'umask' value? it is possible to check this at startup and possible fix permissions then? You think this will be a good idea?

I talked with our sysadmin here and here are a few thoughts:

We don't think it is anything about our system specifically. As additional evidence, when I install INLA in a Rocker container, the permissions on the binaries are:

-rwxrw-r-- 1 root staff   774240 Jan 11 20:40 fmesher
-rwxrw-r-- 1 root staff      482 Jan 11 20:40 fmesher.run
-rwxrw-r-- 1 root staff 55268840 Jan 11 20:40 inla.mkl
-rwxrw-r-- 1 root staff     1638 Jan 11 20:40 inla.mkl.run
-rwxrw-r-- 1 root staff     1638 Jan 11 20:40 inla.run

Given the lack of executable permissions except for the user, that suggests that installation on a multi-user system wouldn't work for the various users on the system. But I agree that if INLA had problems on a multi-user system that I would expect this to have been reported before!
2.) We're wondering if it would make sense to set the mode of the binaries to 755 before you create the INLA binary package. Then I would think that mode would be retained when the binary package files are placed on the system of the user.
3.) My colleague thought it sounded 'hacky' to check/fix permissions at startup.
In any event, we manually fixed things here on our system, so this is not a concern for us. Just wanted to let you know in case it was something you wanted to look into.


UDP / TCP output for ESP8266

Hey,
I have developed https://github.com/SciLor/ESP8266_Hyperion_LED-Controller
What would be nice to have an alternative way to send the colors of the LEDs.
The ESP8266 isn't that fast and works over wifi, so it would be nice to only send the colors of the LEDs that have changed.
As UDP an optional keep-alive packet would be nice (just every x seconds) so the device knows hyperion is still there.
A nicer option would be using TCP. So hyperion also knows that there is a receiver and doesn't fires udp packages into the network that arn't needed.

A few thoughts as the author of the UDP driver (which I wrote specifically to send to ESPs) :
The ESP is plenty fast enough - 80 or 160 MHz.
Sending deltas pushes more work on it as it has to piece it back together which will be much slower than a simple byte copy loop.
TCP will lead to poorer performance on nonnperfect networks as it will have to wait for it if order or dropped packets.
Assuming unicast packets, If the ESP drops off the network, it will age out from the arp cache on the Hyperion box and the packets won't hit the air


Failed to deploy pods in kubernetes 1.4

Rancher Version:
master image
Docker Version:
1.12.2
OS and where are the hosts located? (cloud, bare metal, etc):
Ubuntu 16.04
Setup Details: (single node rancher vs. HA rancher, internal DB vs. external DB)
Single node rancher
Environment Type: (Cattle/Kubernetes/Swarm/Mesos)
Kubernetes 1.4
Steps to Reproduce:
Install kubernetes 1.4 from infra catalog
try to deploy any pod
Results:
The pods are stuck in containercreating state and producing this error:
$ kubectl describe pods --namespace=testingress1
Name:		k8testrc1-8fcza
Namespace:	testingress1
Node:		hussein-10acre-1/<IP_ADDRESS>
Start Time:	Thu, 13 Oct 2016 19:22:37 +0200
Labels:		k8s-app=k8test1-service
Status:		Pending
IP:
Controllers:	ReplicationController/k8testrc1
Containers:
  testcontainer:
    Container ID:
    Image:		sangeetha/testnewhostrouting
    Image ID:
    Port:		81/TCP
    State:		Waiting
      Reason:		ContainerCreating
    Ready:		False
    Restart Count:	0
    Volume Mounts:
      /var/run/secrets/kubernetes.io/serviceaccount from default-token-1pc7p (ro)
    Environment Variables:	<none>
Conditions:
  Type		Status
  Initialized 	True
  Ready 	False
  PodScheduled 	True
Volumes:
  default-token-1pc7p:
    Type:	Secret (a volume populated by a Secret)
    SecretName:	default-token-1pc7p
QoS Class:	BestEffort
Tolerations:	<none>
Events:
  FirstSeen	LastSeen	Count	From				SubobjectPath	Type		Reason		Message
  ---------	--------	-----	----				-------------	--------	------		-------
  56m		56m		1	{default-scheduler }				Normal		Scheduled	Successfully assigned k8testrc1-8fcza to hussein-10acre-1
  56m		4s		142	{kubelet hussein-10acre-1}			Warning		FailedSync	Error syncing pod, skipping: failed to "SetupNetwork" for "k8testrc1-8fcza_testingress1" with SetupNetworkError: "Failed to setup network for pod \"k8testrc1-8fcza_testingress1(a2c3b262-9169-11e6-a468-02bcb92f6900)\" using network plugins \"cni\": failed to add IP addr to \"eth0\": file exists; Skipping pod"

Name:		k8testrc1-wn0yy
Namespace:	testingress1
Node:		hussein-10acre-3/<IP_ADDRESS>
Start Time:	Thu, 13 Oct 2016 19:22:37 +0200
Labels:		k8s-app=k8test1-service
Status:		Pending
IP:
Controllers:	ReplicationController/k8testrc1
Containers:
  testcontainer:
    Container ID:
    Image:		sangeetha/testnewhostrouting
    Image ID:
    Port:		81/TCP
    State:		Waiting
      Reason:		ContainerCreating
    Ready:		False
    Restart Count:	0
    Volume Mounts:
      /var/run/secrets/kubernetes.io/serviceaccount from default-token-1pc7p (ro)
    Environment Variables:	<none>
Conditions:
  Type		Status
  Initialized 	True
  Ready 	False
  PodScheduled 	True
Volumes:
  default-token-1pc7p:
    Type:	Secret (a volume populated by a Secret)
    SecretName:	default-token-1pc7p
QoS Class:	BestEffort
Tolerations:	<none>
Events:
  FirstSeen	LastSeen	Count	From				SubobjectPath	Type		Reason		Message
  ---------	--------	-----	----				-------------	--------	------		-------
  56m		56m		1	{default-scheduler }				Normal		Scheduled	Successfully assigned k8testrc1-wn0yy to hussein-10acre-3
  56m		58s		146	{kubelet hussein-10acre-3}			Warning		FailedSync	Error syncing pod, skipping: failed to "SetupNetwork" for "k8testrc1-wn0yy_testingress1" with SetupNetworkError: "Failed to setup network for pod \"k8testrc1-wn0yy_testingress1(a2c3e954-9169-11e6-a468-02bcb92f6900)\" using network plugins \"cni\": failed to add IP addr to \"eth0\": file exists; Skipping pod"

Tested and worked on master image with kubernetes 1.4 deployed from the infra catalog.

Does this fix included in v1.2.0-pre4-rc5 image ?


Sane Infrastructure Setup

Put namespaced Kubernikus instances into the Admin cluster. Use them to build up regional Kubernikus Control Clusters.

Move from Openstack Control Planes to regional virtualized Kubernikus Control Planes
Manage Kubernikus with Kubernikus
Utilise Admin cluster for managing regional Kubernikus Control Planes

This is actually done! \o/


Activate Service worker

Get offline functionality
Get PWA installable banner for this branch.
Faster response times without needing to go to the server twice.

All opposed?
...
I'm gonna merge


[Info] FB blocking hosts file added to hosts.extras repo

Hi @jmdugan , I added your great job hosts file with facebook and other domains blocking to https://github.com/FadeMind/hosts.extras via commit  https://github.com/FadeMind/hosts.extras/commit/a7ae9f69500e59b43951877bac7b46a74574273f
Regards, FadeMind
Thanks for your work!
CC @stevenblack

:+1:


Disable ssh hostkey checking

Currently the ssh client is configured to check the ssh host key of target server.
As the key is not saved, this happens always and is frustrating if several ssh operations have to be done.
Therefore ssh hostkey checking should be disabled.

This will be included in release 6.6.0-b4


[issue 136] - Adding a specific e2e script for the OpenShift CI periodic prow job (and minor fixes/cleanup)

Description

Fix #136
Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] Feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change
[x] Chore (non-breaking change which doesn't affect codebase;
test, version modification, documentation, etc.)

Checklist

[x] Code contributed by me aligns with current project license: Apache 2.0
[x] Pull Request contains a description of the changes
[x] Pull Request does not include fixes for multiple issues/topics
[x] Code is self-descriptive and/or documented
[ ] I have implemented unit tests to cover my changes
[ ] I tested my code in OpenShift

Once https://github.com/openshift/release/pull/48388 is merged and CI checks are green here, we can merge this safely.

/retest

/retest

/retest

/lgtm


Add issue templates for requesting new repository & adding new contributor

Add new issue templates to support the following tasks - similar to enhancement, bug, release
see https://github.com/odpi/egeria-docs/issues/217 for requesting new repository
see https://github.com/odpi/egeria-docs/issues/347 for adding new contributors
The templates will capture required info & provide a checklist of tasks to complete

OK to have templates for requesting a new repo - but I would think the voting process involved in adding new contributors/maintainers should remain private to the maintainers?

Suggestion

we create a new private mailing list for Egeria maintainers only
this is the list used for proposing a new maintainer etc
a github template can help with the checklist for the actions to take once the vote is complete

Initial template for requesting a new repo has been added - to gather info from author, and to provide a checklist to work through. Will refine as we go through adding an entry for the new strimzi connector.

Review comments to be actioned in next iteration of template - from PR https://github.com/odpi/egeria/pull/6325

[ ] template refers to egeria docs 'Add link in egeria docs' -- this should be a link
[ ] under 'Release' note that the release process for the new repo should be updated in usual place (add link)
[ ] The assumptions is a long list, maybe better as a link to process docs. My response - we don't have the process docs yet. Checklist is a quick start. Will raise issue or add here to complete those docs

Review comments to be actioned in next iteration of template - from PR https://github.com/odpi/egeria/pull/6325

[ ] template refers to egeria docs 'Add link in egeria docs' -- this should be a link
[ ] under 'Release' note that the release process for the new repo should be updated in usual place (add link)
[ ] The assumptions is a long list, maybe better as a link to process docs. My response - we don't have the process docs yet. Checklist is a quick start. Will raise issue or add here to complete those docs

As the steps for adding a new contributor are fairly limited, and also since there may be some discussion on a private list (as for maintainers), it doesn't seem necessary to add a new template for this. So closing. See referenced issues for doc updates.


dependencies rules on default environment are not respected on dev

Dependencies pinned on default enviroment are overrided on development env.
I'll use an example to better illustrate a situation:
You are developing a django app and you don't want to use django >= 2, so you install it like this:
pipenv install "django<2"
Then you decide to install django-debug-toolbar and tag it as a development dependency:
pipenv install django-debug-toolbar --dev
The generated Pipfile.lock will have django on default pinned at 1.11.* and on develop it will be locked at 2.*
For now, the way i'm dealing with this copying all non "*" dependencies to develop on Pipfile, so the generated Pipfile.lock will respect it. Not sure if this is indeed a bug or an design decision.
Describe your environment

OS Type: Linux (Ubuntu 16.04.3 LTS)
Python version: 3.6.2
Pipenv version: 9.0.3

Expected result
I expected Pipfile.lock on develop to respect default rules unless they were explicitly overrided on develop.
Actual result
Pipenv.lock overrides the dependencies on default even when they are not specified.
Steps to replicate
Using my example, run pipenv lock with the following Pipfile:
[[source]]

verify_ssl = true
url = "https://pypi.python.org/simple"
name = "pypi"

[packages]

django = "<2"

[dev-packages]

django-debug-toolbar = "*"

Hey @varnion  thanks for the report, this is indeed a bug but we are already tracking this in #1220 and #1255 so I am going to go ahead and close this out for now
in the meantime a workaround is to put django in both sections (ugly I know, sorry for the un-pretty usage)


Fix for error on saving file during digital signing.

Problem:
We have the error: The process cannot access file because it is being used by another process during saving the digitally signed document.
Solution:
As a solution we decided to use file streams for reading the file content during loading the file description/content.
Tests:

Were opened and digitally signed pair files, one of them previously throwing exception during saving with message described above.
Were tested save action after adding all other types of signatures.

Checked digital signing docx file and all other signature types. Also checked with pdf - all works fine


Dependency warnings

When I add the plugin to a cordova project I get some warnings, here is the console output:
$ cordova plugin add cordova-plugin-game --variable APP_ID="000_SOME_NUMBERS_000"
Fetching plugin "cordova-plugin-game" via npm
Installing "cordova-plugin-game" for android
Fetching plugin<EMAIL_ADDRESS>via npm
WARNING: com.google.playservices has been renamed to cordova-plugin-googleplayservices. You may not be getting the latest version! We suggest you cordova plugin rm com.google.playservices and cordova plugin add cordova-plugin-googleplayservices.
Fetching plugin<EMAIL_ADDRESS>via cordova plugins registry
Installing "com.google.playservices" for android
Fetching plugin<EMAIL_ADDRESS>via npm
WARNING: android.support.v4 has been renamed to cordova-plugin-android-support-v4. You may not be getting the latest version! We suggest you cordova plugin rm android.support.v4 and cordova plugin add cordova-plugin-android-support-v4.
Fetching plugin<EMAIL_ADDRESS>via cordova plugins registry
Installing "android.support.v4" for android

@AdrianNostromo
Removed this warning.
Thanks


Bug - Automatic bindable properties work but explicitly doesn't?

Library Version:
aurelia-binding: 1.6.0
aurelia-cli: 0.32.0

Please tell us about your environment:

Operating System:
Windows 10

Node Version:
9.4.0

Yarn Version:
1.3.2

systemjs version
0.20.18

Browser:
all

Language:
TypeScript 2.6.2

Current behavior:
When i place attribute for bindable() and/or computedFrom on my "chosenZipCodes" property, it no longer gets called or the getter doesn't execute at all.. it show undefined at runtime in browser console.
Removing the attribute(s), fixes the problem.
Expected/desired behavior:
Should work the same with or without the exdplicit attrributes.

class myVM {
....
    constructor(private readonly _geoSvc: GeographyService) {
        this.zipOptions = new Array<ListItem<string>>();
        this.selectedZipOptions = new Array<ListItem<string>>();
    }

    public zipOptions: Array<ListItem<string>>;

    public selectedZipOptions: Array<ListItem<string>>;

    @bindable({ defaultBindingMode: bindingMode.toView })
    @computedFrom("selectedZipOptions")
    public get chosenZipCodes(): ReadonlyArray<PostalCode> {
        return this.selectedZipOptions.map(pItem => pItem.metadata as PostalCode);
    }
...
}

Why do you want to decorate a readonly property with bindable toView?
It is the default for almost everything..except input values? those are two-way by default
Looks like overengineering

@bindable will rewrite (not intercept) the property, thus washes away your getter. That's why your getter does not get called. @jdanyow @EisenbergEffect @Alexander-Taran  This could be a good target for <let /> element, where one can do:
element declaration
<!-- zip code.html -->
<template>
  <let chosen-zip-codes.bind='selectedZipOptions | metadataOnly'></let>

  <div repeat.for='zipCode of chosenZipCodes'>${zipCode}</div>
</template>

class myVM {
....
    public selectedZipOptions: Array<ListItem<string>>;

    @bindable({ defaultBindingMode: bindingMode.toView })
    public chosenZipCodes(): ReadonlyArray<PostalCode> {
        return this.selectedZipOptions.map(pItem => pItem.metadata as PostalCode);
    }
...
}

element usage
<!-- app.html -->
<template>
  <require from='zip-code' ></require>
  <zip-code chosen-zip-codes.bind='initChosenZipCodes' ></zip-code>
</template>

So it can be a @bindable, to take initial data passed from element that consumes it in template, while still reacts automatically to internal changes

Actually it can be doned simply via @observable as well, <let/> could help in case there are many declaration, and binding dependencies, but the above could be done via:
class myVM {
....
    @observable()
    public selectedZipOptions: Array<ListItem<string>>;

    @bindable({ defaultBindingMode: bindingMode.toView })
    public chosenZipCodes(): ReadonlyArray<PostalCode>;

    public selectedZipOptionsChanged(selectedZipOptions: Array<ListItem<string>>) {
        this.chosenZipCodes = selectedZipOptions.map(pItem => pItem.metadata as PostalCode);
    }
...
}

@bigopon don't think I like having logic in markup even for convenience reasons.
declaring a variable in markup that you are going to use in view-model..

It helps define how to compute the value of a property in view model based on an expression, just to clarify. But I see your point.

can be closed
maybe add a note to @bindable on the use case for that. what it does and why we need one on vm

@Alexander-Taran - thanks for your response..
To answer your question, the primary reason is to be explicit with the code and minimize auto-magic that newbies to aurelia may not immediately understand or recognize. Though I'm not sure I understand the answer.. I'm saying that if I don't use any property attibutes it DOES execute my custom getter.. are you saying this is not by design? not supported even though it seems to work (for now)?
Second reason I guess was for my understanding on how things work - i wouldn't imagine that you all would make a choice in design that wires up some default behavior that isn't available programmatically/explicitly also.. just out of curiosity, I would still like to know how to replicate a read-only bindable property explicitly..
@bigopon - thanks for the suggestion and response. I mainly wanted to know if I could avoid the extra step of assigning the property. maybe i'm misunderstanding how computed properties work.
thanks!

well aurelia is about conventions that make sense
it is about auto-magic (-:
about not writing boilerplate code
I'm saying that you don't have to decorate your getter with @bindable
it only defines a getter.. and that's enough for it to be read-only AFAIK
and @bindable is for passing parameters inside a vm.
and by default most of binding is done one-way.
input values..(what user can modify) are two-way by default.
what you are trying to do looks like fighting the framework for no reason (-:

Thanks for the clarification. To be (more) clear, i cannot reproduce the default auto-magic behavior? and does this mean every property/field defined in a viewmodel object is automatically wired up to observe changes? that doesn't sound right.. maybe I'm still confused. I appreciate your patience.

i cannot reproduce the default auto-magic behavior?

depends on weather you are a magician (-:
from what I get - @bindable has different reason to be. It is meta.

does this mean every property/field defined in a viewmodel object is automatically wired up to observe changes?

only those that need observation

@bindable marks, and configures, the properties to be the public declarative API of a custom attribute/element. Using it just to get some of the behaviors it introduces will lead to issues at some point, as with everything else when used inappropriately.
Properties marked with @computed should not be part of the public API - Computed Properties usage.
If you just need the somePropertyChanged behavior on properties from the non-publick API use @observable as suggested by @bigopon

can be closed
discussion can continue.
better yet move it to discourse

Closing this since it's more of a question that can be talked through on discourse.


Postable instance for ()

Could we have a Postable instance for ()? I know it seems pretty trivial, but sometimes when I want to do a post request with no data, I feel like typing Text.empty feels cumbersome (and OverloadingStrings prevents "" from working as I would want).
Actually, now that I think about it a little more, I feel like having a data type like this:
data NoPostData = NoPostData

with the appropriate instance would be best. It makes the intent of the calling code more clear.

I am reasonably happy with Text.empty instead, as it's clear what is happening.


[SPARK-18863][SQL] Output non-aggregate expressions without GROUP BY in a subquery does not yield an error

What changes were proposed in this pull request?
This PR will report proper error messages when a subquery expression contain an invalid plan. This problem is fixed by calling CheckAnalysis for the plan inside a subquery.
How was this patch tested?
Existing tests and two new test cases on 2 forms of subquery, namely, scalar subquery and in/exists subquery.
-- TC 01.01
-- The column t2b in the SELECT of the subquery is invalid
-- because it is neither an aggregate function nor a GROUP BY column.
select t1a, t2b
from   t1, t2
where  t1b = t2c
and    t2b = (select max(avg)
              from   (select   t2b, avg(t2b) avg
                      from     t2
                      where    t2a = t1.t1b
                     )
             )
;

-- TC 01.02
-- Invalid due to the column t2b not part of the output from table t2.
select *
from   t1
where  t1a in (select   min(t2a)
               from     t2
               group by t2c
               having   t2c in (select   max(t3c)
                                from     t3
                                group by t3b
                                having   t3b > t2b ))
;

Test build #71314 has started for PR 16572 at commit 24397cf.

Test build #71314 has finished for PR 16572 at commit 24397cf.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71314/
Test PASSed.

cc @hvanhovell.

Note that the diff is better to read using githubs w=1 flag: https://github.com/apache/spark/pull/16572/files?w=1

Note the way the plans inside subqueries are not treated as part of the tree traversal is a common problem. Besides this problem, another was reported in SPARK-19093. Also the way Spark needs to implement a nested call to the Optimizer via the rule OptimizedSubqueries to work on those plans is another instance.
One possible solution is to overwrite the tree traversal (transformUp, transformDown) of class LogicalPlan to include those subqueries' plans.

Test build #71960 has started for PR 16572 at commit 010d27a.

Thank you for your time reviewing this PR.

Test build #71960 has finished for PR 16572 at commit 010d27a.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71960/
Test PASSed.

@nsyca it would be nice to make subquery expression part of tree traversal. It does seem risky to me, a lot functions using traversal maintain some state and do not account for the existence of subqueries, so I am a bit weary of trying this out (as it might break stuff in very subtle ways).

LGTM - merging to master/2.1/2.0. Thanks!

@hvanhovell, I agree it does look risky with this approach. There are a lot of dependencies here. I am pitching in the idea to get your initial thought. Let me do some background and I will share once I have a better idea on this approach.
Thanks again for your time.


[BUG] Failed to install package @tsed/testcontainers-mongo

Describe the bug
Failed to install package @tsed/testcontainers-mongo
To Reproduce
run command "npm install --save-dev @tsed/testcontainers-mongo"
npm error code EUNSUPPORTEDPROTOCOL
npm error Unsupported URL Type "workspace:": workspace:*
npm error A complete log of this run can be found in: /XXXXXXXXXX/.npm/_logs/2024-08-30T14_07_19_742Z-debug-0.log
Expected behavior
package @tsed/testcontainers-mongo to be installed
Code snippets
No response
Repository URL example
No response
OS
macOS
Node version
Node v22.4.1
Library version
v7.80.3
Additional context
No response

:tada: This issue has been resolved in version 7.81.1 :tada:
The release is available on:

v7.81.1
GitHub release

Your semantic-release bot :package::rocket:


feat: Allow editing and deleting invoices

Implement PUT and DELETE for invoices. Should only be allowed for authenticated users after #1.
This should be a straight-forward implementation.

not planned


Truncate long items in the SelectionList

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/32384
PROPOSAL: https://github.com/Expensify/App/issues/32384#issuecomment-1836888387
Tests

[X] Verify that no errors appear in the JS console

Click on Profile -> workspaces -> Create a new workspace and modify the workspace name to be a long one
Click + > New chat > Room
Click Workspace
Verify that the long workspaces names are truncated and ending with ...

Offline tests

Click on Profile -> workspaces -> Create a new workspace and modify the workspace name to be a long one
Click + > New chat > Room
Click Workspace
Verify that the long workspaces names are truncated and ending with ...

QA Steps

[x] Verify that no errors appear in the JS console

Click on Profile -> workspaces -> Create a new workspace and modify the workspace name to be a long one
Click + > New chat > Room
Click Workspace
Verify that the long workspaces names are truncated and ending with ...

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes

[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)

[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

hi @s77rt,

I added the numberOfLines=1 in both the item.text and the item.alternateText
and please notice that I didn't add the tooltip component so let me know if we need to add it.

@abzokhattab Please add the tooltip. It should be similar to that of UserListItem

Okay done, the screenshots were updated.

On Android the text does not take the full available space, but that bug is being worked on here https://github.com/Expensify/App/issues/21219 thus it's not a blocker

@abzokhattab Thanks!

Okay @iwiznia I added some other tests.

🚀 Deployed to staging by https://github.com/iwiznia in version: 1.4.11-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
cancelled 🔪

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/Julesssss in version: 1.4.11-25 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅


Fetch certificate from url

Useful when investigating cross signing with lets encrypt.
$ ./cft https://letsencrypt.org/certs/isrgrootx1.pem
CN:     ISRG Root X1 (signed by locally-trusted root)
Serial: 008210cfb0d240e3594463e0bb63828b00
Pin:    sha256/0b9fa5a59eed715c26c1020c711b4f6ec42d58b0015e14337a39dad301c5afc3
SAN:    <N/A>
Key Usage: KeyCertSign, CRLSign
Valid:  2015-06-04T11:04:38Z..2035-06-04T11:04:38Z (14 years)
CA: true

$ ./cft https://letsencrypt.org/certs/lets-encrypt-x3-cross-signed.pem
CN:     Let's Encrypt Authority X3
Serial: 00a0141420000015385736a0b85eca708
Pin:    sha256/60b87575447dcba2a36b7d11ac09fb24a9db406fee12d2cc90180517616e8a18
SAN:    <N/A>
Key Usage: DigitalSignature, KeyCertSign, CRLSign
Authority Info Access:
        ocsp: http://isrg.trustid.ocsp.identrust.com
        caIssuers: http://apps.identrust.com/roots/dstrootcax3.p7c
Valid:  2016-03-17T16:40:46Z..2021-03-17T16:40:46Z (3 months)
CA: true Max Intermediate: 0


Making the links react to hover

Making the links in footer interactive to hover to enhance the UX.
Please assign me this issue under Hacktoberfest2024

do it, and do share screen shots before pr.

I have added a subtle color change on hover to the links. Should I make a PR now?


[don't merge] use datamodel-codegen to generate classes based on spec

Description
This is to show what it would look like if we used datamodel-code-generator to extract class definitions from the spec. I'm sure the output can be customised a bit more and where it puts the file would need to be decided etc., but I wanted to get some feedback on this rough draft to see if this is something we should work more on.
We can also have a script post-process the output if we think it's useful, but there are some things we want to rearrange.
Reviewer Focus

This PR needs an in-depth review.
Focus on the output generated by the library -- would this make our life easier?
Checklist

[ ] Added or updated tests
[ ] Tests passed locally
[ ] Linted and formatted code -- expected to fail
[ ] Build passed locally
[ ] Updated documentation

@lwjohnst86 As for processing only specific fields, I think not directly with this tool, but we could pre-process the schema in a way similar to how we wanted to do it initially. So download the schema, drop the resources field on the package, and generate classes based on this modified schema. We can have a Python script for this and still call it from the justfile. (And we still have the option to post-process the dataclasses if we want.)
Just two (somewhat related) questions:

What happens with the resources field? I think yesterday we said we wanted to have it on PackageProperties just not populate it with resources by default. But then the definition for PackageProperties would look like:

@dataclass
class PackageProperties:
    ...
    resources: list[ResourceProperties] = field(default_factory=list)

Here, we're still referencing a ResourceProperties class in the type hint. Would we just add this in after the script has run?

We can run codegen on the resource schema and the table schema separately, but wouldn't we end up with the same very large number of dataclasses, just in different files? Because if we drop the table schema field from the resource schema, but then run the script on the table schema as well, then we end up processing the entire resource schema. Same for the package schema and the resources field.

@martonvago it sounds like some preprocessing will be needed on the JSON before giving it to the codegen CLI. Would that make sense?

@martonvago I also forgot to say to include the dataclasses in the __init__.py file :relaxed:


Change to na_ucx.c parsing of address string.

Allow specification device in the string.
Signed-off-by: Joseph Moore<EMAIL_ADDRESS>

Thanks @jgmoore-or I will integrate it while updating the UCX plugin.


Support superscripts in bibtex author names

Implements #2511

This is indeed a very nice addition. Thanks for your contribution. My only question is, do you think displaying these characters in the publications page is useful? I mean, you'll see an asterisk but nothing will tell you what that means unless you open the paper. What do you think about simply removing from their names insted?

That's a good point. My use case is only to use * for shared first authorship and † for corresponding authors. I also noticed that some science papers only use * for corresponding authors (like this and this). For people in my community, it's clear what * and † mean in the author list if they appear at the beginning and back. It may lead to confusion if other superscripts are also used without annotation displayed.
My solution to this is either

Following what the old version of Wowchemy does, use pop-up windows to explain each superscript. But this would require users to maintain a list-like-structured-annotations in the BibTex entry. Like this one
Have a pop-up annotation somewhere in the publication entry saying that * for equal contribution. † for corresponding authors (Let me give it a shoot)

I would like to keep the superscripts instead of simply removing them. Because if the users intend to include them in the BibTex and find that it doesn't work. it would be very frustrating.

I agree with you, I was only giving an easier solution. I like the idea of 2.
About the symbols, these might be a convention in your area of study, but that is not true for all. There are cases that the convention you said is used, sure, like in this paper. But sometimes they indicate something else, like in this one where † means equal advising, or even this one where * means Work done during an internship at Facebook AI Research and † means Corresponding author. There is also the case where numbers or symbols are used to indicate emails. This might change in a per paper basis, so it is kind of hard to create a one legend fits them all here.

I endded up with adding an annotation entry to the BibTex
@inproceedings{Vaswani2017AttentionIA,
  title={Attention is All you Need},
  author={Ashish Vaswani* and Noam M. Shazeer* and Niki Parmar* and Jakob Uszkoreit* and Llion Jones* and Aidan N. Gomez*† and Lukasz Kaiser* and Illia Polosukhin*‡},
  booktitle={Neural Information Processing Systems},
  year={2017},
  bibtex_show={true},
  annotation={* Equal contribution. Listing order is random.
† Work performed while at Google Brain.
‡ Work performed while at Google Research.}
}

This looks really nice. Can you please add a screenshot of how it looks like in dark mode?

Sure! The solid info icon will become white.

Can you make that the pop up also turn dark on dark theme? Maybe use the card color.

Sure, now the popover follows theme colors

@garywei944 just now I realized that you didn't add an example of how to do this in our template. Would you mind modifying a bib reference in our template just to add an example of how this works? This way it is easier for our users to see that this features exists and how it can be implemented for their repo.

Sure, but I see no Albert Einstein's paper is using superscript. Do you
mind me just adding the paper "Attention is all you need" to the
publications?
Best,
Gary
On Wed, Jun 19, 2024 at 1:56 PM George @.***> wrote:

@garywei944 https://github.com/garywei944 just now I realized that you
didn't add an example of how to do this in our template. Would you mind
modifying a bib reference in our template just to add an example of how
this works? This way it is easier for our users to see that this features
exists and how it can be implemented for their repo.
—
Reply to this email directly, view it on GitHub
https://github.com/alshedivat/al-folio/pull/2512#issuecomment-2179248430,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AIC33MQ5IAZIWRG2MDPL6JDZIHA4BAVCNFSM6AAAAABJOR5OHWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNZZGI2DQNBTGA
.
You are receiving this because you were mentioned.Message ID:
@.***>

--
--
Guanghao Wei (Gary), CS M.Eng.
Cornell University in Ithaca, NY - Class of 2023, US
Tel: +1<PHONE_NUMBER>
E-mail: @.** @.**>
Website: https://garywei.dev/ https://garywei.dev/
Acad Profile: https://acad.garywei.dev/ https://acad.garywei.dev/

Idk, maybe just modify one of its references? Change one that has multiple authors and add the * Equal contribution, what do you think?
The good thing about the Attention is all you need is that it has multiple examples though.


Please support Enter shortcut, Experience using it like a web page

When the idea opens the chatgpt page box, it should take over the Enter shortcut key for quick interaction

@fwnan Are you suggesting adding a shortcut for opening the tool window?

@LiLittleCat  No, I suggest pressing the Enter key to transport the issue like a web page, rather than manually clicking the send button now

@LiLittleCat  No, I suggest pressing the Enter key to send the answer like a web page, rather than manually clicking the send button now.

I think so too,This would be very convenient.

Hello @fwnan, @wq287627997,
I've just upgraded to IntelliJ IDEA 2023.2.5 (Ultimate Edition, Build #IU-232.10227.8, released on November 9, 2023). Excitingly, I discovered that the 'Enter' shortcut is now supported by JCEF in this version. Notably, when typing in the input box, the icon at the end lights up, indicating that pressing Enter will send the message. I highly recommend updating to this latest version to see if it addresses your concerns as well.

Additionally, if you're unable to open the plugin in your current version, please refer to https://github.com/LiLittleCat/intellij-chatgpt/issues/29#issuecomment-1824067404 for assistance.

Just wanted to update i upgraded to PyCharm 2023.3.1 (Community Edition) Build #PC-233.11799.298, built on December 12, 2023 and the Enter key to send prompts still doesn't work 😔


Include state load time in post-replay timing info

Add console output for trimmed file state load time. Also, when computing
FPS, account for trimmed state load time (if any) and report as "Replay
FPS".
Example output with trimmed capture file:
Load time:  1.435010 seconds
Total time: 7.576557 seconds
Replay FPS: 285.107319 fps, 6.141547 seconds, 1751 frames, framerange 250-2000

Example output with complete (not trimmed) capture file:
Total time: 6.758087 seconds
Replay FPS: 254.361922 fps, 6.758087 seconds, 1719 frames, framerange 1-1719

Test change has merged.  You should be able to merge this PR without affecting testing.  (In theory, at least. ;-)


Music Player UI needs vue and core

https://play.nativescript.org/?template=play-ng&id=EaETCw&v=15

Looks good! I decreased the duration of the transition a bit to make it feel a little more snappy:
https://play.nativescript.org/?template=play-vue&id=kiAVxk&v=9


No module named model.recommendation_model_launcher_keras

I followed all previous steps in ondevice_recommendation.ipynb
I can't find either model.recommendation_model_launcher_keras in examples repo
but error still exists when I execute this block
!python -m model.recommendation_model_launcher_keras \
  --run_mode "train_and_eval" \
  --encoder_type "cnn" \
  --training_data_filepattern "data/examples/train_movielens_1m.tfrecord" \
  --testing_data_filepattern "data/examples/test_movielens_1m.tfrecord" \
  --model_dir "model/model_dir" \
  --params_path "model/sample_config.json"\
  --batch_size 64 \
  --learning_rate 0.1 \
  --steps_per_epoch 1000 \
  --num_epochs 10 \
  --num_eval_steps 1000 \
  --gradient_clip_norm 1.0 \
  --max_history_length 10

Hi, Did you clone the examples repo from Master branch, if not, you can clone this from Master.
In requirements.txt file, it is mentioned that it requires tensorflow>=2.2 version.
Since, Tensorflow 2.8 is the latest version, could you please upgrade it to Tensorflow 2.8 and try again and let us know the outcome. Thanks!

@sachinprasadhs It worked thanks, It seems that I was pulling from outdated example

Thanks for the confirmation, I will create a PR to update the requirements.txt to include Tensorflow 2.8.

This issue has been automatically marked as stale because it has no recent activity. It will be closed if no further activity occurs. Thank you.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.

This issue has been automatically marked as stale because it has no recent activity. It will be closed if no further activity occurs. Thank you.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.

This error still happen to me. I used tensorflow 2.8.0 screenshot

This error still happens to me. I used tensorflow 2.8.0 screenshot @muja555 @sachinprasadhs Do you have any ideas how to fix it?

I found the recommendation_model_launcher_keras in this repository and it worked! clone this repository instead of the example one.
https://github.com/niap123/ml