[Audit][SPARK-40667] Refactor File Data Source Options

Is your feature request related to a problem? Please describe.
https://github.com/apache/spark/commit/8e853933ba64bb43e02af78198bc36d471efaa18 refactored the File Data Source Options. For example, it moves the BASE_PATH_PARAM from PartitioningAwareFileIndex to FileIndexOptions.
We should move some values to the shim layer of spark340
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context, code examples, or references to existing implementations about the feature request here.

Refactoring this to shim layer of Spark 340 will fix these build errors:
[ERROR] [Error] /home/nartal/spark-rapids/sql-plugin/src/main/scala/org/apache/spark/sql/execution/datasources/rapids/GpuPartitioningUtils.scala:40: value BASE_PATH_PARAM is not a member of object org.apache.spark.sql.execution.datasources.PartitioningAwareFileIndex
[ERROR] [Error] /home/nartal/spark-rapids/sql-plugin/src/main/scala/org/apache/spark/sql/execution/datasources/rapids/GpuPartitioningUtils.scala:87: not found: value BASE_PATH_PARAM
[ERROR] [Error] /home/nartal/spark-rapids/sql-plugin/src/main/scala/org/apache/spark/sql/execution/datasources/rapids/GpuPartitioningUtils.scala:148: not found: value BASE_PATH_PARAM
[ERROR] [Error] /home/nartal/spark-rapids/sql-plugin/src/main/scala/org/apache/spark/sql/execution/datasources/rapids/GpuPartitioningUtils.scala:40: Unused import


Fix: typos

Fix: typos

Wow.  Thanks for catching and fixing the typos. Keep it up. Cheers. Prost.


Change the API of Client::push

Previous to this commit, Client::push would return a Result<String> object. The embedded String would be the URL of the image just pushed to the registry.
There are however more URLs that are returned by an OCI registry upon a successful push: image URL, config URL and manifest URL.
These URLs cab be useful too, hence the code has been changed so that all of them are returned back.
The manifest URL for example can be pretty useful. The URL contains the manifest digest of the image, which can be used to pull the contents in an immutable way.
Having the manifest digest at hand is useful also when a freshly pushed OCI image/artifact has to be signed with something like Sigstore.
In that case, it's a best practice to sign the content by its immutable address, rather than by its tag.
Having the Client::push API return the manifest digest allows safer signing of contents that prevents both race conditions and malicious actors (including the registry).
For more details check this detailed blog post about Sigstore: https://blog.chainguard.dev/zero-friction-keyless-signing-with-github-actions/

Labeling as breaking so we know to call this change out in the next release notes


Support use-case: lint before git add

Is your feature request related to a problem? Please describe.
I usually use a bash function to add and commit all changed and new (and deal with deleted) files, and before I run it, I run super-linter locally on just those changed and new files.  And I just realized why the github superlinter action often finds issues that weren't revealed locally.  It's because it doesn't check untracked files.
Describe the solution you'd like
It would be nice/convenient if there was a way to tell superlinter to check untracked files (that are not git ignored).
Describe alternatives you've considered
I know I could probably split up my add and commit actions to add the new files before linting, but I've been using this workflow for years.  I do include running isort and black on the new files before running superlinter in my lint.sh script, so it's not a common occurrence to encounter discrepancies, so if there's no option to make superlinter check untracked files, I probably won't do anything differently and just occassionally encounter new linting errors from the github actions.
Additional context
I'm basing my assumption that superlinter only checks added files on the absence of a file in the File list to check: output:
2023-10-18 17:08:28 [INFO]   ---------------------------------
2023-10-18 17:08:28 [INFO]   ------ File list to check: ------
2023-10-18 17:08:28 [INFO]   ---------------------------------
2023-10-18 17:08:33 [INFO]   ----------------------------------------------
2023-10-18 17:08:33 [INFO]   Successfully gathered list of files...
2023-10-18 17:08:36 [INFO]   ----------------------------------------------
2023-10-18 17:08:36 [INFO]   ----------------------------------------------
2023-10-18 17:08:36 [INFO]   The script has completed
2023-10-18 17:08:36 [INFO]   ----------------------------------------------

when I run superlinter like this:
docker run --pull=always -e 'FILTER_REGEX_INCLUDE=(DataRepo\/models\/msrun_sequence\.py)' -e LINTER_RULES_PATH=/ -e IGNORE_GITIGNORED_FILES=true -e RUN_LOCAL=true -v /Users/rleach/PROJECT-local/TRACEBASE/tracebase/:/tmp/lint github/super-linter:slim-v4.9.4
slim-v4.9.4: Pulling from github/super-linter

where the new file DataRepo/models/msrun_sequence.py was specified in FILTER_REGEX_INCLUDE.
Note
If this is a request to add a new language, after submitting this issue check out the wiki for more info on how to accomplish that.

check git pre-commit/pre-push hook?
a shell script under .githook and need some git command to activate it each time for a fresh clone

You know, I tried linting new files that are git added, but apparently that doesn't get linted either.  Apparently it only lints committed files? Maybe I made a mistake.  I'll try the pre-commit hook and see if that works, but if I did it correctly in my manual testing, then I don't think pre-commit will work.

Hi @hepcat72 ! This is currently not supported.
What is supported is:

Run against the whole codebase (set VALIDATE_ALL_CODEBASE to true).
Run against the files that changed in the last commit (VALIDATE_ALL_CODEBASE to false, the default).

To partially cover your use case, you would need to set VALIDATE_ALL_CODEBASE to true, and USE_FIND_ALGORITHM to true. This will lint all the files in your workspace, including the newly git added files.
I'll be happy to review a PR to implement this.

PS: to run super-linter locally, you can refer to https://github.com/super-linter/super-linter/blob/main/docs/run-linter-locally.md

Yes, it will work :)

Before I start playing with this, let me ask straight-up... if I use USE_FIND_ALGORITHM=true (with either the regex or all files), would that actually work on untracked files or only files that have been git added?  (I'm not sure that my assumption that it can only check git added files is correct.)

When you set USE_FIND_ALGORITHM=true, you're telling super-linter to completely bypass Git to gather the list of files to lint, and use find instead. In this mode, VALIDATE_ALL_CODEBASE is assumed to be true because there is no way to make assumptions about changed files using find only.
So, to answer your question: USE_FIND_ALGORITHM=true will make super-linter get both tracked and untracked files.


Mac Linking problem with pc simulator in Catalina

This problem was reportedly addressed previously, but with the latest code I'm running into the linking problem again trying to build the simulator.
12:21:34 **** Incremental Build of configuration Debug for project pc_simulator ****
make all
Building target: pc_simulator
Invoking: Cross GCC Linker
gcc  -o "pc_simulator"  ./main.o ./mouse_cursor_icon.o   -lSDL2main -lSDL2 -lm
Undefined symbols for architecture x86_64:
"_demo_create", referenced from:
_main in main.o
"_keyboard_handler", referenced from:
_main in main.o
"_lv_disp_buf_init", referenced from:
_hal_init in main.o
"_lv_disp_drv_init", referenced from:
_hal_init in main.o
"_lv_disp_drv_register", referenced from:
_hal_init in main.o
"_lv_disp_get_scr_act", referenced from:
_hal_init in main.o
"_lv_img_create", referenced from:
_hal_init in main.o
"_lv_img_set_src", referenced from:
_hal_init in main.o
"_lv_img_src_get_type", referenced from:
_ICON_LVGL_runLength_info in main.o
"_lv_indev_drv_init", referenced from:
_hal_init in main.o
"_lv_indev_drv_register", referenced from:
_hal_init in main.o
"_lv_indev_set_cursor", referenced from:
_hal_init in main.o
"_lv_init", referenced from:
_main in main.o
"_lv_mem_monitor", referenced from:
_memory_monitor in main.o
"_lv_task_create", referenced from:
_hal_init in main.o
"_lv_task_handler", referenced from:
_main in main.o
"_lv_tick_inc", referenced from:
_tick_thread in main.o
"_monitor_flush", referenced from:
_hal_init in main.o
"_monitor_init", referenced from:
_hal_init in main.o
"_mouse_handler", referenced from:
_main in main.o
"_mouse_init", referenced from:
_hal_init in main.o
"_mouse_read", referenced from:
_hal_init in main.o
"_mousewheel_handler", referenced from:
_main in main.o
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make: *** [pc_simulator] Error 1
"make all" terminated with exit code 2. Build might be incomplete.
I have the SDL2 libraries from brew.

It appears that LittlevGL is not being linked into your project (but SDL2 is).

gcc -o "pc_simulator" ./main.o ./mouse_cursor_icon.o -lSDL2main -lSDL2 -lm

This should have a lot of lv_xxx.o files as well.

It appears that LittlevGL is not being linked into your project (but SDL2 is).

gcc -o "pc_simulator" ./main.o ./mouse_cursor_icon.o -lSDL2main -lSDL2 -lm

This should have a lot of lv_xxx.o files as well.

This is the project that was from the website. I have not modified the code other than the screen size and colour depth in one header file. I'll see what I can find to fix that. If you have any ideas, I'd appreciate the info. Thanks.

New problem - I added the files back into the project using the import feature this time instead of just copying them and now I have this error:
../lv_drivers/display/fbdev.c:26:10: fatal error: 'linux/fb.h' file not found
#include <linux/fb.h>
I'm on a Mac. Why is it looking for linux files?
Also, I tried defining USE_BSD_FBDEV and that caused its own problems.

You shouldn't need to copy the files into the project. If you download the project, unzip it, and import the whole project into Eclipse, things should work. Manually importing or copying certain files is extremely likely to cause problems.

The lvgl and related directories were empty and it would not compile, so I
copied the files and it compiled.
On Sat, Oct 19, 2019 at 16:41 embeddedt<EMAIL_ADDRESS>wrote:

You shouldn't need to copy the files into the project. If you download the
project, unzip it, and import the whole project into Eclipse, things should
work. Manually importing or copying certain files is extremely likely to
cause problems.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/littlevgl/pc_simulator_sdl_eclipse/issues/51?email_source=notifications&email_token=ABJ53WRQ7BHC4BPUAQF5ZTDQPN5G5A5CNFSM4JCQX6P2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBX5HMQ#issuecomment-544199602,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABJ53WQCDVI2RN5FGERO4OTQPN5G5ANCNFSM4JCQX6PQ
.

--
妇女能顶半边天
-- 毛泽东

The lvgl and related directories were empty and it would not compile.

You must not have downloaded the repository correctly. Can you clone this repository using git clone --recursive and try it?

Sure. I’m in the grocery store at the moment so it will be a bit before I
can do that. Thanks.
On Sat, Oct 19, 2019 at 17:16 embeddedt<EMAIL_ADDRESS>wrote:

The lvgl and related directories were empty and it would not compile.
You must not have downloaded the repository correctly. Can you clone this
repository using git clone --recursive and try it?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/littlevgl/pc_simulator_sdl_eclipse/issues/51?email_source=notifications&email_token=ABJ53WUTAZVISW2GIVDRGHLQPOBM3A5CNFSM4JCQX6P2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBX5YBA#issuecomment-544201732,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABJ53WSV4SMLCLBIZUJD2J3QPOBM3ANCNFSM4JCQX6PQ
.

--
妇女能顶半边天
-- 毛泽东

The lvgl and related directories were empty and it would not compile.

You must not have downloaded the repository correctly. Can you clone this repository using git clone --recursive and try it?

I did the git clone --recursive and I'm receiving the same error:
../lv_drivers/display/fbdev.c:26:10: fatal error: 'linux/fb.h' file not found
#include <linux/fb.h>
^~~~~~~~~~~~
1 error generated.
make: *** [lv_drivers/display/fbdev.o] Error 1
Again, I'm on a Mac so I don't see why I should be using a linux file when there is apparently a BSD option available, but the BSD option causes its own problems with missing files:
../lv_drivers/display/fbdev.c:23:10: fatal error: 'sys/consio.h' file not found
#include <sys/consio.h>
^~~~~~~~~~~~~~
1 error generated.
make: *** [lv_drivers/display/fbdev.o] Error 1
"make all" terminated with exit code 2. Build might be incomplete.

Your comment sparked my memory.
Change this define to a 0 in lv_drv_conf.h and try again.

As far as I recall, someone else reported this issue before but I guess neither @kisvegabor nor I ever fixed the file.

That did it! Thanks.
On Sat, Oct 19, 2019 at 18:39 embeddedt<EMAIL_ADDRESS>wrote:

As far as I recall, someone else reported this issue before but I guess
neither @kisvegabor https://github.com/kisvegabor nor I ever fixed the
file.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/littlevgl/pc_simulator_sdl_eclipse/issues/51?email_source=notifications&email_token=ABJ53WS5LJUYYTRPUDFAAKDQPOLDRA5CNFSM4JCQX6P2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBX63EI#issuecomment-544206225,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABJ53WVGHX4BE34MBZX2NELQPOLDRANCNFSM4JCQX6PQ
.

--
妇女能顶半边天
-- 毛泽东

I fixed it. Thanks!
525e33d


MjSpec.compile() should populate resulting MjModel's XML to enable mujoco.mj_saveLastXML

The feature, motivation and pitch
Currently, the mj_model resulting from mj_model = mj_spec.compile() cannot be saved with mujoco.mj_saveLastXML(mj_model) because the XML information is not stored in the model. It would be useful to be able to save the XML of an MjModel without carrying the MjSpec around.
It feels like this would be as simple as storing the MjSpec.to_xml() into the MjModel, but perhaps I'm overlooking something and this is actually more complicated than I think.
Alternatives
I can save the compiled model with mujoco.mj_saveModel. For debugging purposes, it would be nice to be able to look into the XML. This I can also do by keeping the spec around but it would be more convienient to not have to worry about the spec.
Additional context
Here's a simple test case that fails:
  def test_spec_model_saveLastXML(self):
    spec_1 = mujoco.MjSpec()
    spec_2 = mujoco.MjSpec()
    spec_1.from_string("<mujoco></mujoco>")
    model = spec_1.compile()
    with tempfile.NamedTemporaryFile(suffix=".xml", mode="w+t") as fp:
      mujoco.mj_saveLastXML(fp.name, model)
      spec_2.from_file(fp.name)

    self.assertEqual(spec_1.to_xml(), spec_2.to_xml())

Which gives:
======================================================================
ERROR: test_spec_model_saveLastXML (specs_test.SpecsTest.test_spec_model_saveLastXML)
specs_test.SpecsTest.test_spec_model_saveLastXML
----------------------------------------------------------------------
Traceback (most recent call last):
  File "mujoco/python/mujoco/specs_test.py", line 802, in test_spec_model_saveLastXML
    mujoco.mj_saveLastXML(fp.name, model)
mujoco.FatalError: No XML model loaded

----------------------------------------------------------------------

Why is mj_saveXML not what you want?

In what way is mj_saveXML not what you want?

I have the same issue, the problem is that, mj_saveXML is not binded in python. There are only:
def mj_saveLastXML(filename, m): # real signature unknown; restored from __doc__
    """
    mj_saveLastXML(filename: str, m: mujoco._structs.MjModel) -> None

    Update XML data structures with info from low-level model, save as MJCF. If error is not NULL, it must have size error_sz.
    """
    pass

def mj_saveModel(m, filename, p_str=None, *args, **kwargs): # real signature unknown; NOTE: unreliably restored from __doc__
    """
    mj_saveModel(m: mujoco._structs.MjModel, filename: Optional[str] = None, buffer: Optional[numpy.ndarray[numpy.uint8[m, 1], flags.writeable]] = None) -> None

    Save model to binary MJB file or memory buffer; buffer has precedence when given.
    """
    pass

This is addressed in the notebook. This notebook is not yet finished so we haven't advertised it, but I believe everything should work.
@quagla we should also add a subsection about XML saving to the docs...


Removing Post-Install script

Please consider removing the post-install test runner and notify the user to run the tests as a warning in the console, with the main goal of allowing users to set npm config set ignore-scripts true
Check out https://youtu.be/24tQRwIRP_w?t=930, this is my reason for posting.
Thanks!

We will not. Feel free to ignore scripts and manually build the binary of you wish.


How to compile .ts files

I'm also have the same issue as #20
I have installed the plugin and it works fine for in terms of editing, auto complete etc.
Though it doesn't complie on save or when I call build on the project. There isn't any complie on save option in the GUI as you see below in the screenshots? I just installed it today.
I can compile the main.ts file from the command line no problem. When I save or try build project a progress bar pops up and then nothing. No errors or output at all in the console window. Also just to note, I wasn't sure what type the project had to be, general project, web, javascript? Or does it matter?
System

Mac OSX
Kepler release of Eclipse Java EE IDE for Web Developers.
node v0.10.13
tsc <IP_ADDRESS>

Below are two screen shots

Plus one @Sergio-Mira

hi same issue is still in ubuntu willy


fix(docs): specify pnpm version for building docs

Unlike the UI's package.json, the package.json for the docs site and for the custom plugin it uses were not specifying what version of pnpm to use. As a result, build/deploy of the docs site on Netlify was using their default pnpm version, which was older. Thanks to a recent PR from Dependapot the plugin's pnpm-lock.yaml is no longer compatible with that older pnpm...
This made pnpm ignore the lock file and resolve different versions of some dependencies, which, in turn, was responsible for the recent failed doc site builds on Netlify.
This PR should set things straight again and because the current production docs are built and deployed from the release-0.8 branch, I am going to also backport this.
cc @fykaa this may solve some recent troubles you've had.
cc @rbreeze for node ecosystem sanity check.

When I worked on #2449, I looked into streamlining the NodeJS-related dependencies. This has made me wonder if we should not be more opinionated about how we practice our Node versioning (at least for builds), using e.g. Corepack. Although this is, of course, part of new NodeJS drama.

@hiddeco fwiw, Netlify is using Corepack already.
It's quite possible we might get some mileage out of it ourselves and we should definitely have a look at that, but I think the minimal changes in this PR are a critical stop-gap to get our doc previews, not to mention official doc deployments, working again.

Yes, my comment was more of an observation rather than a request to address this now.


Bug/300

With this patch it we fix #300
I have introduced the core tag yield to transclude the position of the inner html of any riot tag
@tipiirai I' am waiting your review on my patch before merging

Seems good. Good job @GianlucaGuarini

I think I need to compile the inner html with the parent tag like suggested in this comment https://github.com/muut/riotjs/issues/300#issuecomment-93823947 and like React and Vue do.
I will se if I could fix this issue during this weekend


Implement e2e tests in OF operator using KUTTL

Short Abstract
Currently, the E2E tests are using a set of shell scripts that apply a FeatureFlag resource and then retrieve the value of a feature flag via the flagd API to evaluate the response.
These tests could potentially benefit from using KUTTL (https://kuttl.dev/), with which we have made good experiences in KLT (see https://github.com/keptn/lifecycle-toolkit/tree/main/test/integration).
Why
This framework allows to define test cases using Kubernetes manifests that are applied in one step, and then be evaluated using assertions that check for certain conditions being available on kubernetes resources (e.g. the status of a deployment). The framework will also take care of tasks such as isolating test scenarios from each other by running them in separate namespaces, as well as implementing the retry/timeout logic for the evaluation of the assertions.
The validation steps that are currently done via bash scripts can be reused by executing those in a K8s Job - Kuttl can then validate the status of that job.
Also, KUTTL may open the door for more complex e2e test scenarios with an annotated deployment being applied and then asserting if the flagd sidecar has successfully been injected
Tasks

[ ] Migrate the existing e2e test to Kuttl
[ ] Add a command to the Makefile to execute these tests
[ ] Execute these tests in the pipeline

References
A proof of concept for this can be found in the following PR: https://github.com/bacherfl/open-feature-operator/pull/1 - this PR already wires up everything that is needed to also execute the tests in the pipeline, so with some further polishing it should be in a state in which it can be merged

I would like to take this one!


Run-segmentation stops after run-segmentation-on-tile

Hi, I tried out the tool on a mosaic_DAPI_z3.tif file in watershed nucleus mode:
vpt --processes 20 --verbose run-segmentation --segmentation-algorithm ./segmentation.json --input-images "mosaic_(?P<stain>.*?)_z(?P<z>[0-9]+).tif" --output-path out/ --input-micron-to-mosaic ./micron_to_mosaic_pixel_transform.csv
At the end I receive a .parquet for every tile, but not a combined .parquet. Nothing interesting in the log files, just a lot of Dask memory leak warnings.
What went wrong and how can I check if the segmentation was completed?
Thank you!

Hi sorry to revive this.
But I'm also having issues with multiple processes and the run-segmentation, it seems that it does everything for the tiles, but never starts the combining step. Everything works fine with only 1 process though.
Did you figure out the issues or a fix in the end ?

Hello @pakiessling,
Please would it be possible to share with us what you did to move forward?
Thanks

@lguerard @poloarol
I do not remember what the problem was back then.
This is the script I am using succefully vor multiple different vpt versions:
https://gist.github.com/pakiessling/f046eb48a43e77ad634371142be09542

@pakiessling thanks for the tip


New ZK connection built with each REST api request

It appears that the OffsetGetterWeb constructs a new ZkClient with each GET request.
Normally, ZK sessions are long-lived so there is value in amortizing connection setup costs over the life of the app. Re-using the ZkClient should also allow for higher number of API requests per unit time.
I noticed the issue when testing against a modern version of ZooKeeper. Since the ZK libs used by KafkaOffsetMonitor are pre-3.4.0 (and the introduction of the "readOnly" protocol flag), a large number of log messages are being spewed out due to some unfortunate logging code in the ZooKeeper project[1].
There doesn't appear to be a reason why the ZkClient needs to be rebuilt per request. Would you accept a PR with a change to re-use ZkClients connections?
[1] https://github.com/apache/zookeeper/blob/release-3.4.6/src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java#L822

will merge the PR after getting the contributor's agreement :)

Thanks. Agreement sent.


Leaderboar structure

Added the list board
Added the submit
Added flex display to the main container
Added contents display to hide the bullets of the unordered list
Added flex display to the submit container

Hi @OnlyUnknown, Kindly add the key features and future features section in your readme 👍🏿


Unable to verify reddit account

When I go to verify my reddit account the client does nothing when I click the link to open the form.
my log id: a9c3291fce2a04473dab7e1c

I ended up using the command line instead, but doing it through the client still does not work.

we have dupes of this so I'm closing this one. Also, I think we just fixed it, but I'll wait to close them all until comfirmed.


CSS grid

Update to latest bs-platform, Css.re failed to compile for me with this older version.
CSS grid support

https://www.mozilla.org/en-US/developer/css-grid/
https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_Grid_Layout/Basic_Concepts_of_Grid_Layout

Have not included the minmax function and I don't know how to type it
here.
https://developer.mozilla.org/en-US/docs/Web/CSS/minmax

Thank you :)
If you have any thoughts on how to implement minmax that would be great. I tried for an hour and got nowhere :(

Hi @cullophid did you get a chance to take a look?

Thanks!


Attempt to fix #985

Fixes #985?

@yaichenbaum I haven't been able to reproduce this one for a while. Does this actually fix the issue for you? I also doubt SetForegroundWindow() will be effective here because the limitations below apply:

@yaichenbaum I'm pretty sure this won't solve the issue, I remember opening a PR like this and @tsvietOK was still able to reproduce the issue.
Unfortunately I get this bug way to rarely to be able to properly test this.
(Also without a delay mainwindowhandle  will be null most of the time)

@gave92 Luke pointed this out to me, I am closing this PR since it doesn't solve the issue


Storage Applications

What's the Problem?
No function to add storage applications like mega
Solution/Idea
I thought it would be a cool idea to add things like mega to the file explorer like you can normally do, with the mega UI panel, but maybe make it work for this. That's all

Jack Ablett

Alternatives
Using the normal file explorer but Files is way better
Priorities

Capability
Priority

This proposal will allow developers to accomplish W
Must

This proposal will allow end users to accomplish X
Should

This proposal will allow developers to accomplish Y
Could

This proposal will allow end users to accomplish Z
Won't

Files Version
2.1.7
Windows Version
Windows 11
Comments
Very good just this feature :)

sorry didnt realise it did this


Format incomplete phone number

:tada: This PR is included in version 20.1.10 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Update qblox-instruments to version 0.11.2

New PR in here https://github.com/qilimanjaro-tech/qililab/pull/680


Sounds Permission Error

Sounds that have a 0 permissions or "everyone" permission can't actually be played by guests. Only mods and the broadcaster.
I have re-added the offending sounds and made sure the permissions were set to everyone and it has not made a difference.

Try using the "!setsoundperm 0" command, which does not save to settings so you'll have to do it every time you boot Botnak.
I may just hijack this issue to make it the reminder to make it something that gets saved, either in defaults.ini or whatnot.

!setsoundperm to 0 also does not fix the issue even though the bot reports in chat that it has changed to 0. Is there any debugging I can do that may help the issue get resolved?

Was the sound added with a sub+ permission? I mean doing "!addsound soundname soundfile.wav" should make it playable for everyone.
If you can, try to tell me the process of how you're testing these sounds and I will try to recreate it.

I've added the sounds through the GUI not through twitch chat. They are set to everyone. Even manually selected them if the default preset wasn't enough.

Okay so I've found the issue, it's the Settings GUI sound tree which is broken.
I'm pretty much going to be overhauling this GUI for the release of Botnak 2 Episode 2, which I will start soon.
For now, just use the "!addsound" command found here under "moderator commands" and the sounds should be added and work. Also make sure that you have set the default sounds directory, since the chat command uses that directory to add the sounds.

Cool. Thanks.

I'm gonna branch this off as "re-do the sound tree" in another issue report. But the sounds permission will be saved from now on!


Add ToJSON for (Some f)

Perhaps we would want Some.This for backward compatibility.

Already part of <IP_ADDRESS>. Thanks!


Task: Lab #12 Figma Wireframe

Lab 12 Wireframe
Description
This story is the responsibility of the UX team, this is to translate information from the vision document of the new lab based on literacy, this activity will be better explained at a link attached below.

https://docs.google.com/document/d/1IJ8qveZs7ri10F5H7Oqa-CZpFOWwye3dkOYp_wU3-Vw/edit#heading=h.ixapbqs53rap


Provide default arguments for Asn1TreeBuilder.() -> Unit

In some practices we may not use the child node builder.
Asn1.ExplicitlyTagged(34U) { }

https://github.com/a-sit-plus/signum/blob/e8f9bd4a0be5a9018e6e4ffe137b22191b06c1e1/indispensable/src/commonMain/kotlin/at/asitplus/signum/indispensable/asn1/encoding/Asn1Encoding.kt#L191
Maybe it should be changed to?
fun ExplicitlyTagged(tag: ULong, root: Asn1TreeBuilder.() -> Unit = { }): Asn1ExplicitlyTagged {

Personally, I think the intentions are clearer, if the empty lambda needs to be spelled out. After all you are creating an empty structure. Therefore, I think the code should clearly mirror this intent.

@ShiinaSekiu feel free to reopen, if you can present a legit use case


fix PRIVACY.md links

[ ] I have signed the Contributor License Agreement.
[ ] This pull request is related to an issue.

This prevents a 404 when clicking "primary privacy statement" here and here.
Microsoft Reviewers: Open in CodeFlow

@microsoft-github-policy-service agree


add option to show release URL instead of opening it in the browser

closes #120
Signed-off-by: Logan McAnsh<EMAIL_ADDRESS>

Also: Thank you very much for this change!

of course! should I use the default shortcut e.g. -s or do you have something else in mind?

Thank you so much!

Not sure how I missed this, but thanks!!


Icon color

Expected behaviour
Different user icon background colors.
Actual behaviour
they are all green with white initials.
Configuration
Application version: master
PHP version: 7.0.7
PHP SAPI: apache2handler
OS version: Linux 4.4.11-1-ARCH
Database driver: sqlite
Database version: 3.13.0
Browser: Mozilla/5.0 (X11; CrOS x86_64 7978.74.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/50.0.2661.103 Safari/537.36

Hi
I ran into the same problem with #2163. I'm not sure but I think it's because of 64bits and 32bits differences in PHP.
Could you try the solution I used in the mentioned thread and see if this works for you ?

Yes it Works.
Just edit app/User/Avatar/LetterAvatarProvider.php (line 145) :
$max = intval(9007199254740991 / $seed2);
into (per example)
$max = intval(90071992547409 / $seed2);

This issue is now solved in the dev branch.


Data labeler doesn't allow TextData as the input for the predict

General Information:

OS:
Python version:
Library version:

Describe the bug:
Currently, data labeler allows all returned objects from data reader except TextData. This can be fixed by modifying the check_and_validate_data_format function.
To Reproduce:
Run this code
data = dp.Data('some_text_file')
predictions = data_labeler.predict(data)

Expected behavior:
Screenshots:
Additional context:

Currently being handled in PR: https://github.com/capitalone/DataProfiler/pull/55 (not yet merged)


[NO] Updated the Enum lesson with elixir 1.4 changes

Referenced in #701

Thank you @therobinsj!

@doomspork not a big deal but just something I noticed --
These translation branches have PR'd to master rather than my original branch with the english version.
Because of this, in production the translated sections explain/use features that currently do not exist in the basics/enum section now because of this, as 1.4 is not yet released.
I don't think this is a huge deal, but thought it was worth noting as I just thought of it/noticed now.


Validate error handling

I have a basic error handler placed right after registering my app to swaggerExpress as seen below but during a validation fail my error handler never gets called.
      swaggerExpress.register(app);

      // Error Handler Middleware
      app.use(function(err,req,res,next){
        console.log("Using error handler middleware....")
        res.json(err);
      })

i would like to display all the validation error as JSON objects. or intercept all errors and process them using my error handler is this possible?
stack trace
Error: Response validation failed: failed schema validation
   at throwErrorWithCode (/Users/kadjei/projects/swagger/api/node_modules/swagger-express-mw/node_modules/swagger-node-runner/node_modules/swagger-tools/lib/validators.js:121:13)
   at Object.module.exports.validateAgainstSchema (/Users/kadjei/projects/swagger/api/node_modules/swagger-express-mw/node_modules/swagger-node-runner/node_modules/swagger-tools/lib/validators.js:150:7)
   at /Users/kadjei/projects/swagger/api/node_modules/swagger-express-mw/node_modules/swagger-node-runner/node_modules/swagger-tools/middleware/swagger-validator.js:141:22
   at /Users/kadjei/projects/swagger/api/node_modules/swagger-express-mw/node_modules/swagger-node-runner/node_modules/swagger-tools/node_modules/async/lib/async.js:358:13
   at /Users/kadjei/projects/swagger/api/node_modules/swagger-express-mw/node_modules/swagger-node-runner/node_modules/swagger-tools/node_modules/async/lib/async.js:239:13
   at _arrayEach (/Users/kadjei/projects/swagger/api/node_modules/swagger-express-mw/node_modules/swagger-node-runner/node_modules/swagger-tools/node_modules/async/lib/async.js:91:13)
   at _each (/Users/kadjei/projects/swagger/api/node_modules/swagger-express-mw/node_modules/swagger-node-runner/node_modules/swagger-tools/node_modules/async/lib/async.js:82:13)
   at async.forEachOf.async.eachOf (/Users/kadjei/projects/swagger/api/node_modules/swagger-express-mw/node_modules/swagger-node-runner/node_modules/swagger-tools/node_modules/async/lib/async.js:238:9)
   at _asyncMap (/Users/kadjei/projects/swagger/api/node_modules/swagger-express-mw/node_modules/swagger-node-runner/node_modules/swagger-tools/node_modules/async/lib/async.js:357:9)
   at Object.map (/Users/kadjei/projects/swagger/api/node_modules/swagger-express-mw/node_modules/swagger-node-runner/node_modules/swagger-tools/node_modules/async/lib/async.js:340:20)
   at validateValue (/Users/kadjei/projects/swagger/api/node_modules/swagger-express-mw/node_modules/swagger-node-runner/node_modules/swagger-tools/middleware/swagger-validator.js:134:11)
   at ServerResponse.res.end (/Users/kadjei/projects/swagger/api/node_modules/swagger-express-mw/node_modules/swagger-node-runner/node_modules/swagger-tools/middleware/swagger-validator.js:242:9)
   at /Users/kadjei/projects/swagger/api/app.js:84:13
   at Layer.handle_error (/Users/kadjei/projects/swagger/api/node_modules/express/lib/router/layer.js:71:5)
   at trim_prefix (/Users/kadjei/projects/swagger/api/node_modules/express/lib/router/index.js:310:13)
   at /Users/kadjei/projects/swagger/api/node_modules/express/lib/router/index.js:280:7

Hey Kwame! This is absolutely possible. The newest version of the swagger module creates a project that uses an error handler by default to map errors that occur to JSON automatically. Of course, you may remove the onError handler from your pipe definition in the config/default.yaml file if you don't want it there - or you could even add a similar custom one if you'd like.

That said... it looks like I was perhaps so aggressive with catching errors that I'm not allowing connect-based error handles to fire. I'll look into that.

@theganyo thank you for the quick response.
Sounds great i'll look into some specific use cases where these errors occur.

Below are some outputs per "DEBUG=swagger-tools* swagger project start".
That produce a stack trace

Unspecified content type PUSH/POST operations

Request validation: failed +0ms
swagger-tools:middleware:validator   Reason: Invalid content type (application/octet-stream).  These are valid: application/json, application/x-www-form-urlencoded

Failed Schema validation

Response validation: failed +1ms
swagger-tools:middleware:validator   Reason: Failed schema validation

Ok. I've pushed a patch. You'll need to update your dependencies... but since it's a sub-dependency of swagger-express-mw, you might need to actually reinstall that instead of just npm update.

after removing  "swagger-express-mw" as a dependency and  npm install "swagger-express-mw" everything working great.
@theganyo  Thank you.

Great! Thanks!

I have an unrelated question about developing for scalability, i don't know if it's worthy of a new issue. After some frustration about using "$ref" to link definitions/parameters and models i discovered that swagger wasn't build with external references as a part of the core principles. Is this an accurate assumption?

removing and reading swagger-express-mw does not work for me. My existing swagger-node based app doesnt work at all any more because req.swagger doesnt exist any more.
@kadjei : could you please reopen this issue?

@pourquoi42 Have you added the new fitting as specified in the release notes here? https://github.com/theganyo/swagger-node-runner/releases/tag/v0.6.0


Implement workers utility

Provides a utility that can be used to determine if the current thread
is the main Node.js thread or a worker thread, even if worker threads
are not supported.
const { workers } = require('@nearform/node-clinic-common')

console.log(workers.isMainThread)
console.log(workers.threadId)

If workers are not supported on the Node.js version, isMainThread always returns true and threadId always returns 0, otherwise returns the appropriate value.

I'd actually forgotten that workers had been backported to 10.x :-)
As we spoke about on the phone, if we can make it such that clinic gracefully fails when run on an unsupported version, I think we can avoid adding this utility.

Actually, it appears this still may be necessary. worker_threads is behind a flag on 10.x (https://github.com/nearform/node-clinic-doctor/pull/309#issuecomment-608578125)

Confirm, that fix from clinicjs/node-clinic-doctor/pull/309 works, because otherwise I faced this error: clinicjs/node-clinic-doctor/issues/304.
Node version: bash-3.2$ node -v v18.12.0
FYI @jasnell


Function "apply" in preprocess is no more needed?

It seems that function "apply" was removed. For instance, in test_preprocess it was possible to use it in a following manner:
d = preprocess.apply(preprocess.process_traces, [d], [h])
If there is an alternative way to work with multi-component data?

changed to function "multichannel"


Multiple documents by id

Hello, thanks for the amazing library.
I was wondering if I can query multiple documents by id using something similar to firebase.firestore.FieldPath.documentId(). I tried also with geofirestore.FieldPath.documentId() without success.
Can someone point me in the right direction?
Thanks in advance.

So geofirestore only replicates the functionality of a firestore instance (firebase.firestore()) not the firestore namespace (firebase.firestore). So If you want to create FieldPath objects you'll need to use the namespace (firebase.firestore). However you can use a FieldPath object in geofirestore to make a query.
I think that helps, let me know!

Thanks for the quick reply. I tried with:
const query = geocollection
    .where(firebase.firestore.FieldPath.documentId(), "in", [
        "2EELdMWlmpBYpw4l8Jxr",
        "2mvgJlCEXhTcNfeyfm6f",
    ])
    .get()

but I got this error:
index.cjs.js:160 Uncaught FirebaseError: Function Query.where() called with invalid data. Invalid field path (d.[object Object]). Paths must not contain '~', '*', '/', '[', or ']'

If I try this:
const query = firestore
    .collection("collection")
    .where(firebase.firestore.FieldPath.documentId(), "in", [
        "2EELdMWlmpBYpw4l8Jxr",
        "2mvgJlCEXhTcNfeyfm6f",
    ])
    .get()

This obviously works but I get the documents with the default firestore data structure instead of the geofirestore structure.
Am I missing something? Or there is another way to retrieve multiple documents by id?
Thanks.

Can you please create a stackblitz example? Use this as a template if you'd like https://stackblitz.com/fork/geofirestore-issue-sandbox

Hi, I found out that I was stuck at version 3.4.3. With the latest version the problem seems gone. Thanks for your help!


Failed to create IPAs! Exit status: 137

** BUILD SUCCEEDED **

Successfully built Fugu14App
Please open the folder containing your unzipped IPSW now.
Afterwards, open the *largest* dmg in it (containing the root file system)
Press enter once you are done or Ctrl+C to abort...
Please enter the path where the dmg is mounted: /Volumes/AzulC18C66.D54pOS
Creating IPAs...
  adding: Payload/ (stored 0%)
  adding: Payload/Fugu14App.app/ (stored 0%)
  adding: Payload/Fugu14App.app/_CodeSignature/ (stored 0%)
  adding: Payload/Fugu14App.app/_CodeSignature/CodeResources (deflated 69%)
  adding<EMAIL_ADDRESS>(deflated 12%)
  adding: Payload/Fugu14App.app/jailbreakd (deflated 75%)
  adding: Payload/Fugu14App.app/Fugu14App (deflated 77%)
  adding: Payload/Fugu14App.app/Assets.car (deflated 9%)
  adding<EMAIL_ADDRESS>(deflated 10%)
  adding: Payload/Fugu14App.app/com.apple.analyticsd.plist (deflated 25%)
  adding: Payload/Fugu14App.app/utils.js (deflated 70%)
  adding: Payload/Fugu14App.app/setup.js (deflated 75%)
  adding: Payload/Fugu14App.app/runJailbreakd.js (deflated 76%)
  adding: Payload/Fugu14App.app/trustcache (deflated 3%)
  adding: Payload/Fugu14App.app/embedded.mobileprovision (deflated 38%)
  adding: Payload/Fugu14App.app/tar (deflated 59%)
  adding: Payload/Fugu14App.app/bootstrap.tar (deflated 76%)
  adding: Payload/Fugu14App.app/Info.plist (deflated 35%)
  adding: Payload/Fugu14App.app/PkgInfo (stored 0%)
build_ipas.sh: line 26: 59480 Killed: 9               ./pwnify_compiled Payload/Fugu14App.app/Fugu14App "$2/Applications/Spotlight.app/Spotlight"
Failed to create IPAs! Exit status: 137

@AIRBORNE7 I'm having the same issue

Hey mate, I got the same error as you, can you share what you did to fix it?


Per-module logging doesn't work (or is confusing)

trinity Version: git master, commit 2e8f681818c6befb3ecef0247f9380fba7122156
OS: Arch Linux
Python Version (python --version): 3.7.2
Environment (output of pip freeze): MISSING

What is wrong?
When running either of:
trinity --log-level trinity.protocol.eth.ETHPeerPool=DEBUG
trinity --log-level trinity.protocol.eth=DEBUG
trinity --log-level trinity.protocol=DEBUG
trinity --log-level trinity=DEBUG

I'd expect DEBUG-level logging from trinity.protocol.eth.ETHPeerPool to be printed to stdout. This does not happen. All messages are at default level (INFO).
How can it be fixed
Not sure.
This feature was added in non-PR commit 0e760630480a2aa16acf2818f97035c926a34cb2 PR https://github.com/ethereum/py-evm/pull/1158; there are rudimentary tests for proper argument parsing - but not whether the output contains proper lines.
If new tests for this are added, it's perhaps better to use something less likely to change than trinity.protocol.eth.ETHPeerPool.

So I won't get a chance to look into it right now, but IIRC the log levels change which things are written to the debug log. (Totally agree these command line args could use a lot of love, BTW)
So it's likely been used more for adding debug2 messages into the log, or quieting noisy debug messages in the logs.

Did PR #400 address this?

@veox it does and it also added a test to ensure it keeps working!

@veox related https://github.com/ethereum/trinity/pull/659 :)


#42 Allow deletion of ./*

Closes #42

CodeOcean has been updated as well: https://github.com/openHPI/codeocean/commit/8e403ff65ab9da40996dffa56b1a3c44e1e8b2b7


doc: add iWuzHere GPG ID

Seeing as I had to generate a gpg key for the node build wg, I might as well add it here.
Should I check in my pubkey tag after this change is landed?

LGTM, though I'd push the key before landing this change, since you reference the git object name (pubkey-iwuzhere) before it would exist. Not a big deal though.

LGTM

Pushed tag then landed https://github.com/libuv/libuv/commit/5af420669a40974ce91dd66c51f779fd66c19f63


Static compile-time auto performance improver

Now, this is a massive task for something like this - but could be more than worth it in various ways. Before you immediately jump to a conclusion, no, I don't mean something that literally changes the source code: instead, it changes the source result: ie, the code that runs the game (or application).
This is essentially a linter that runs automatically, and could specifically be used when publishing games (or whenever they are requested (ie, a user joining) to improve performance).
I'm not exactly sure how publishing games on Roblox works, but I presume the compiler runs whenever you publish the game, not whenever a user wants to join. This could theoretically only work for server-side scripts (I think?) but could also be run on the client when a user joins. If the linter fails (errors) then it could just not run the linter.
Possible "lints"
For example, this code:
local x = 1
local y = x
print(y)

Could be automatically changed to:
local y = 1
print(y)

This could also effect redundant lints like running tostring, tonumber for no apparent reason.
Why?
This can be done like this, or it can literally be a linter built into Roblox studio. Things like Selene have come close, but from that use case I posted above they do not catch this. This solution could be done, but a linter would be easier. The only reason I'm suggesting it so the user doesn't make any changes is so that this can be internal and not cause a mass of warnings.
Feedback is welcome, this could also be an RFC.

Luau compiler compiles all scripts to bytecode before execution. The bytecode compiler already does a set of program transformations, and this set will of course grow over time.
You can't observe these transformations in a syntactic form (because the road from source to bytecode is one-way short of a decompiler), but you can use --compile command line switch of luau binary (which you can get from Releases) to look at the bytecode for a given program.
For example, for the program you've linked, we remove both x and y locals producing the following bytecode (this results in 2 fewer instructions to execute compared to naive compilation):
/mnt/c/work/luau $ ./luau --compile cf.lua
Function 0 (??):
    3: print(y)
GETIMPORT R0 1
LOADN R1 1
CALL R0 1 0
    4:
RETURN R0 0

So we already do this to some extent. We plan to improve the optimizations we're doing over time, although there's some limitations since optimizations can't change the behavior of the program, which we're thinking through.
Note that we don't currently document all bytecode optimizations but some optimizations are documented on https://luau-lang.org/performance - this page will expand over time.

That's fantastic news! Is there any way I can contribute to this list?

Right now these are mostly done on the fly during codegen in Compiler.cpp; looking for "optimization" comments will lead you to the right code :)
There's going to be some restructuring/refactoring of this code to split it into more manageable units which may make some of the optimizations more easily implementable; this will happen over the next few months.
We currently don't plan on building an actual IR with transformations, mostly because there's not a clear need for that yet and the optimizations are sometimes limited by the semantics as I mentioned.

Cool! I need to learn C++ though, coming from Rust it hopefully shouldn't be too bad.
The only reason I suggested this is because of the fact that scripts can be relatively inefficient in games and cause lower end devices to suffer, this would just be a performance checker and fixer to make sure that it would be efficient as possible.

I think this is called "constant propagation", where the compiler evaluates certain expressions at compile-time if the intermediate states are unobservable and the result will always be the same at runtime.


Test diverging closure coercion

Adds a test for https://github.com/rust-lang/miri/issues/1075. Depends on https://github.com/rust-lang/rust/pull/66827.

@bors r+

:pushpin: Commit 42732cc9bb6cec922b9cc0ef723e97dd0b83bc52 has been approved by RalfJung

:hourglass: Testing commit 42732cc9bb6cec922b9cc0ef723e97dd0b83bc52 with merge 3c0d3439ee692647ee4b7f9a2dd45e40e0f75b3f...

:sunny: Test successful - checks-travis, status-appveyor
Approved by: RalfJung
Pushing 3c0d3439ee692647ee4b7f9a2dd45e40e0f75b3f to master...


ldBar doesn't appear in angular 2 app

Hi,
I have an angular 2 app. I've tried to user loading bar, but it doesn't work.
In my index.html I import js and css files
<link rel="stylesheet" type="text/css" href="plugins/loading.io/loading-bar.css">

and in my experience.component.html I load the bar like this

but nothing happens. I tried it on a single html file, and works fine.
PS: Sorry for my english
PS2: I'm using angular quickstart proyect

do you have a sample repo to play with which I could reproduce this issue?
I'm not quite familiar with Angular2, and I just tried the quickstart project, ldBar looks ok for me.

Any plan to support angular? I am able to inject, but not able to update progress values.

I've published an angular-loading-bar package on npm, with sample code / usage document available here:
http://github.com/loadingio/angular-loading-bar
can you guys try if it works?


Review contributor agreement

Hi, I have a few questions about your contributor agreement. Before I go into these however, you should read various arguments [1] [2] on why this sort of agreement doesn't actually give your company any extra protection and only costs you more administrative overhead.
Specifically now, there are two issues that worry me about this agreement.
(a) You assert that I've agreed to it simply by submitting a pull request or some other trivial action that people do all the time on the internet without these sorts of conditions attached. (It's even more trivial than clicking "I agree" that most people do without thinking.) I therefore have to question both the ethical reasonableness of this assertion, as well as how legally enforceable it is.
(b) In the text "Any contribution we make available under any license will also be made available under a suitable [FOSS license]", the condition "we make available under any license" sounds a bit dodgy. It implies that you get all the benefits (that this agreement gives you) even if you reject my PR, or if you don't release it (but use it privately and internally), or if you release it under no license. The whole point of my contribution would be for the FOSS product, so this condition is disconcerting.

I think these worries are quite personal really. Specifically (b), if a PR is made (I am not sure how having a PR rejected comes into it) then it is part of the GPL code base, but this project may release also under another license to third parties. I do not think it would be possible to prevent the GPL-3.0 always being available etc. So a bit unclear here of the issue.
For (a) I need to look closer at the agreement (lawyers etc. were involved in the creation of this so will check with them perhaps).  The terms are also on every file in the repo in the header. I am not sure either on enforceability of agree buttons/ acceptance criteria, but 100% the intention here is to remove hassle for people. So I suppose you can have scanned signed agreements (again how enforceable etc.).
For me the main issue is this is all GPL-3.0 at least and can never be anything other than that as is, however MaidSafe may license to third parties if appropriate. Also may be licensed as GPL only or another FOSS licence. There are issues whichever way it goes here and the priority is to ensure freedom via GPL and also moving forward.
Ultimately it would be nice to have an answer that will satisfy everyone, but since the early 90's I have never seen such a thing. I don't this this is too far away as is, but of course always looking at improvements. Be good to take these points into the next time we look over licensing, which is important, but also has it's place (is any license really enforceable worldwide etc.)
Again cheers for input and there are some huge threads on the forums about licensing etc. (as you can imagine the debates rage for months and 000#s of posts)./

Understood, "always GPL-3 but perhaps we might license other terms to others []" is good and fine for FOSS projects. Thanks for stating that more clearly! My issue was more with the wording, which at the moment says "If P then [FOSS]", which isn't the same as []. It would be good to clear that up.
Regarding a rejected PR, this is a combination of (a) and (b) together. If the mere act of submitting a pull request implies I've agreed to your terms, then these terms apply even if you later reject the request. Addressing (a) and (b) will address this automatically, I was just pointing out a strange consequence of the wording.

Ah yes both these points are good and well made. We can certainly clear the wording up and ensure, only accepted pull requests fall under these conditions. Thanks again, clarity is always much better and this will certainly aid that.
Nice

Thanks for the comments @infinity0 . I agree that we should make it more clear that we will make any and all contribution available under GPL3, something like: "Any contribution we
make available under any license will also be made available under GPL V3."
Regards rejected PRs. I can't imagine a situation where we would reject a PR and then need to use the code internally, if it was a useful PR we would want to incorporate it, however, to make the wording more comfortable can I suggest that we make a statement along the lines of 'MaidSafe has no rights to  intellectual property from rejected pull requests'?

Hey,

something like: "Any contribution we make available [..]"

Did you forget to edit this? (The text you quoted is exactly what's in the current agreement, with the "Any X [which] Y will be Z" conditional clause.) Based on what @dirvine said in the first post, I think it would be clearer to state "Your contribution will be released under GPL-3; however MaidSafe also reserves the right to re-license it under a different license."
On rejected PRs, it could be simpler to state near the front of the agreement that "this agreement only comes into effect for accepted contributions". Then you don't need to mention rejected pull requests specifically.

No, the current agreement states: 'Any contribution we
make available under any license will also be made available under a suitable FSF (Free Software
Foundation) or OSI (Open Source Initiative) approved license.' - I was just making it clear that it was going to be released under the GPL.
Anyway, I appreciate the suggestions and we will get these changes rolled out across all the libs. Thanks again for your input, much appreciated!

Just two general thoughts not so specific to maidsafe or crust :
There should be an effort to lobby GitHub to make big scary legal stuff appear when you fork or send pull requests to projects with CLAs.
As many CLAs were designed for the iOS situation, we need GPLv3 variants adapted to these App stores with built in CLAs that say basically :

The anyone / the project reserves has right to distribute this program through channels whose
policies conflict with the GPL, such as App stores, subject to the party placing this software
under the distributors license must must themselves incur the distributors obligations under
the GPLv3.  To enforce this, this party must :

not grant the distribution the right to modify the software,
must not agree to automatic license modifications by the distributor,
must publish the source code for the used by the distributor, and
must provide reproducible build instructions for reproducing that exact version from the source.

It'd need a framework for updates similar to the GPL's "or later" clause that let the license creator, like the FSF or EFF, adapt to legal changes by Apple, etc., including possibly pulling thousands of applications off the store if Apple caused a problem for the reproducible build requirement.
Apologies if that's off topic here, but just something that came to mind.  :)

It'd need a framework for updates similar to the GPL's "or later" clause that let the license creator, like the FSF or EFF, adapt to legal changes by Apple

I write code for MaidSafe, but my opinion does NOT reflect MaidSafe opinion.
 Please raise an issue again if required as almost everything in the library and the way it handled things have changed. Closing this.


Dialog: Add transition name as a prop (with default value for reverse compatibility)

I added the transition name as a prop on the dialog component, with a default value of 'dialog-fade'. This way we can fully control the transition of the dialog.

Hi, thanks for contributing.
Customizing Dialog animation does not seem to be a common request, so we may not add a prop to do that. Actually you can do so by overriding its CSS: https://jsfiddle.net/qs0cod48/

@Leopoldthecoder, agreed, but my main concern was about being able to disable the transition.
Other components offer a 'disableTransitions' prop, I could send a PR with an implementation in the dialog, if that fits better? I agree that this would be more consistent than adding the transition name as a prop.

Disabling transitions is actually something we can work on. Maybe we'll try to implement it so that
Vue.use(Element, { transitions: false })

can turn off all popup transitions (Dialog, MessageBox, Select, Dropdown, etc.).
For now you can disable Dialog's transition with CSS: https://jsfiddle.net/qs0cod48/1/ . Note that I also disabled backdrop's transition as well in the demo, otherwise it would look kinda weird.

Sounds very interesting, so we'd store the transitions bool on the ELEMENT config variable...
...

ELEMENT.transitions = opts.transitions || true;

Vue.prototype.$ELEMENT = ELEMENT;

...and then in components we'd check whether or not to add a transition name:
<transition :name="$ELEMENT.transitions ? 'el-zoom-in-center' : ''">
  ...
</transition>

Seems a bit cleaner than overriding the CSS imo, but happy to hear your thoughts!
A note about reverse compatibility: Would you keep the disableTransitions prop on the Tag for example, or strip it out entirely?

Yes, we'll keep Tag's disableTransitions. And it should have a higher priority than $ELEMENT.transitions.

Great, I will send a PR!


[Bug Report] White screen on jmusicbot after updating to java 11

Bug Description
Jmusicbot shows white screen with java 11 installed
Steps to Reproduce
install java adoptium (also tested with java 11)
open jmusicbot
jmusicbot white screen (with already configuration working previously)
Expected Result
open jmusicbot as usual
Debug Output
no output

But os is windows 11. version 0.4.2
Additional Info
No response
Checklist

[X] I have looked for information about this within the documentation
[X] I have searched for similar issues on the issues page
[X] I am using an official release from the releases page

JMusicBot Version
0.4.2

Adding where java and the check that is version 11

This might be a Windows 11 issue. Also, that debug at the end of your command doesn't do anything.

Thanks. at the end i am doing what they told me to do. no gui. working and see the log but on cmd.


Un-deprecate SpringBootStreamHandler:  FunctionInvoker will not work with an AWS Function Kafka Source

Is your feature request related to a problem? Please describe.
I have noticed in the latest spring cloud function (3.2.7) SpringBootStreamHandler is deprecated in favour of FunctionInvoker.
I have AWS Spring Cloud Function projects which are simple sources for emitting data to a Kafka Topic.  In these projects I simply extend SpringBootStreamHandler and define a 'function' bean as such
import org.springframework.cloud.function.adapter.aws.SpringBootStreamHandler;

import lombok.extern.slf4j.Slf4j;

@Slf4j
public class MySpringBootStreamHandler extends SpringBootStreamHandler {

	public MySpringBootStreamHandler() {
		super(FunctionApplication.class);
		log.info("MySpringBootRequestHandler()");
	}

}

@Component(value = "function")
public class MyFunction implements Function<Flux<Map<String, String>>, Flux<String>> {
...
}

This means, programatically, I can specify the AWS function I want to run and the Spring Application main class.
Migrating to FunctionInvoker requires not only having to specify the main class outside of code (manifest) but also specifying a spring.cloud.function.definition.   spring.cloud.function.definition confuses spring cloud streams as it tries to bind to my AWS Lambda function.
Describe the solution you'd like
Either support SpringBootStreamHandler as a lower level route into spring cloud function AWS or allow FunctionInvoker to be overridden to provide the function name   i.e.
public class MyFunctionInvoker extends FunctionInvoker {

	public MyFunctionInvoker() {
		super("myFunctionName")
	}

}

N.B in fact it would be very useful to also specify the main class too i.e.
public class MyFunctionInvoker extends FunctionInvoker {

	public MyFunctionInvoker() {
		super("myFunctionName",FunctionApplication.class)
	}

}

Describe alternatives you've considered
Create and maintain my own Functioninvoker which is not ideal
Additional context
https://github.com/davidmelia/spring-cloud-function-source-only illustrates the issue.

CallMySpringBootStreamHandler calls the deprecated SpringBootStreamHandler handler - all is well
CallFunctionInvoker calls specifying spring.cloud.function.definition (spring streams gets confused) or not specifying spring.cloud.function.definition (spring function aws cannot establish a route)

@davidmelia So, FunctionInvoker is not final so you can extend it. But I believe what you are asking is that it could have an alternative for getting the function definition (other then s.c.f.definition), correct?

Exactly @olegz  - I'm sure there are more use cases than my example above so it would be super useful to be able to programmatically pass in the function definition (and the main class if poss).  This would be a great fallback.

I buy that.
Glad you mentioned it now before the releases. Will address it tomorrow

@davidmelia It's done, there is a new constructor that would take function definition as a parameter and that would take precedence over property-based definition. It was backported to 3.2.x, snapshots are available (3.2.8-SNAPSHOT). Please give it a shot and let me know as we will be releasing 3.2.8 tomorrow.

@olegz just tested and works perfectly.  Thanks


Set stability iterations on Windows tests to 1

The tests with cfg.stabilityIterations checks are important and shouldn't be skipped. If they're too flaky to run 10x, at least run 1x.
I heard a report that service IPs were broken in acs-engine deployments, so I went to check on the test cases and found that they weren't run. This sets it back to run at least once.
Resolves #4245

/hold
Thanks @jsturtevant . Will check and fix it tomorrow

Fixed & tests scheduled

Ok - this is actually failing now. @jsturtevant @daschott and I thought it would fail, and it might be a real bug
STEP: Exposing a internal service for the linux nginx deployment
2018/11/14 16:41:51 $ kubectl expose deployment nginx-dns-kubernetes-southcentralus-1699-3293 --type ClusterIP -n default --target-port 80 --port 80
2018/11/14 16:41:51 #### $ kubectl expose deployment nginx-dns-kubernetes-southcentralus-1699-3293 --type ClusterIP -n default --target-port 80 --port 80 completed in 356.913314ms
STEP: Exposing a internal service for the windows iis deployment
2018/11/14 16:41:52 $ kubectl expose deployment iis-dns-kubernetes-southcentralus-1699-88446 --type ClusterIP -n default --target-port 80 --port 80
2018/11/14 16:41:52 #### $ kubectl expose deployment iis-dns-kubernetes-southcentralus-1699-88446 --type ClusterIP -n default --target-port 80 --port 80 completed in 399.014003ms
STEP: Connecting to Windows from another Windows deployment
2018/11/14 16:41:52 $ kubectl run windows-2-windows-kubernetes-southcentralus-1699-66436 -n default --image microsoft/windowsservercore:1803 --image-pull-policy=IfNotPresent --restart=Never --overrides { "spec": {"nodeSelector":{"beta.kubernetes.io/os":"windows"}}} --command -- powershell iwr -UseBasicParsing -TimeoutSec 60 iis-dns-kubernetes-southcentralus-1699-88446
2018/11/14 16:41:53 #### $ kubectl run windows-2-windows-kubernetes-southcentralus-1699-66436 -n default --image microsoft/windowsservercore:1803 --image-pull-policy=IfNotPresent --restart=Never --overrides { "spec": {"nodeSelector":{"beta.kubernetes.io/os":"windows"}}} --command -- powershell iwr -UseBasicParsing -TimeoutSec 60 iis-dns-kubernetes-southcentralus-1699-88446 completed in 314.919451ms
.
2018/11/14 16:42:29 iwr : The remote name could not be resolved:

'iis-dns-kubernetes-southcentralus-1699-88446'

At line:1 char:1

+ iwr -UseBasicParsing -TimeoutSec 60 iis-dns-kubernetes-southcentralus ...

+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

    + CategoryInfo          : InvalidOperation: (System.Net.HttpWebRequest:Htt

   pWebRequest) [Invoke-WebRequest], WebException

    + FullyQualifiedErrorId : WebCmdletWebResponseException,Microsoft.PowerShe

   ll.Commands.InvokeWebRequestCommand

2018/11/14 16:42:29 $ kubectl delete po -n default windows-2-windows-kubernetes-southcentralus-1699-66436
2018/11/14 16:42:30 #### $ kubectl delete po -n default windows-2-windows-kubernetes-southcentralus-1699-66436 completed in 367.684252ms
2018/11/14 16:42:30 Ran command on 1 of 1 desired attempts with 0 successes

• Failure [102.187 seconds]
Azure Container Cluster using the Kubernetes Orchestrator
/go/src/github.com/Azure/acs-engine/test/e2e/kubernetes/kubernetes_test.go:82
  with a windows agent pool
  /go/src/github.com/Azure/acs-engine/test/e2e/kubernetes/kubernetes_test.go:969
    should be able to resolve DNS across windows and linux deployments [It]
    /go/src/github.com/Azure/acs-engine/test/e2e/kubernetes/kubernetes_test.go:1015

    Expected
        <int>: 0
    to equal
        <int>: 1

    /go/src/github.com/Azure/acs-engine/test/e2e/kubernetes/kubernetes_test.go:1058
------------------------------

with Azure-CNI v1.0.12, k8s 1.12 and 1.13 failed the first attempt. Doing a second run to see if it's consistent or not.
STEP: Connecting to Linux from Windows deployment
2018/11/14 19:52:47 #### $ kubectl delete po -n default windows-2-windows-kubernetes-westus2-69593-1765 completed in 541.202353ms
2018/11/14 19:52:47 Ran command on 1 of 1 desired attempts with 1 successes

2018/11/14 19:52:47 $ kubectl run windows-2-linux-kubernetes-westus2-69593-73235 -n default --image microsoft/windowsservercore:1803 --image-pull-policy=IfNotPresent --restart=Never --overrides { "spec": {"nodeSelector":{"beta.kubernetes.io/os":"windows"}}} --command -- powershell iwr -UseBasicParsing -TimeoutSec 60 nginx-dns-kubernetes-westus2-69593-5913
2018/11/14 19:52:48 #### $ kubectl run windows-2-linux-kubernetes-westus2-69593-73235 -n default --image microsoft/windowsservercore:1803 --image-pull-policy=IfNotPresent --restart=Never --overrides { "spec": {"nodeSelector":{"beta.kubernetes.io/os":"windows"}}} --command -- powershell iwr -UseBasicParsing -TimeoutSec 60 nginx-dns-kubernetes-westus2-69593-5913 completed in 436.065763ms
.
2018/11/14 19:54:24 iwr : The remote name could not be resolved:

'nginx-dns-kubernetes-westus2-69593-5913'

At line:1 char:1

+ iwr -UseBasicParsing -TimeoutSec 60 nginx-dns-kubernetes-westus2-6959 ...

+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

    + CategoryInfo          : InvalidOperation: (System.Net.HttpWebRequest:Htt

   pWebRequest) [Invoke-WebRequest], WebException

    + FullyQualifiedErrorId : WebCmdletWebResponseException,Microsoft.PowerShe

   ll.Commands.InvokeWebRequestCommand

2018/11/14 19:54:24 $ kubectl delete po -n default windows-2-linux-kubernetes-westus2-69593-73235
2018/11/14 19:54:24 #### $ kubectl delete po -n default windows-2-linux-kubernetes-westus2-69593-73235 completed in 580.798093ms
2018/11/14 19:54:24 Ran command on 1 of 1 desired attempts with 0 successes

• Failure [164.412 seconds]

The failed windows <-> Linux traffic issue could be https://github.com/Azure/acs-engine/issues/4188

I took the azure-cni version changes back out. Looks like this will need some more manual testing and maybe a new azure-cni version before it should merge.

Ok - just added the new Azure-CNI v1.0.14 for Windows. let's try again

This needs some manual investigation. All Windows tests failed - the nodes did not join the cluster.

Azure CNI 1.0.14 merged in #4297 , so retesting without that as part of the changelist

Windows Server 2019 merged to acs-engine master, so next attempt this will run on 2019

@PatrickLang does this mean the Dockerfile for kubletwin/pause (notice the typo btw) is also updated? I've found that the Dockerfile is still referencing microsoft registry which doesn't have images for 1809, when it should be updated to the new registry mcr.microsoft.com/windows/nanoserver:1809

The dockerfile in the repo is never used. The setup scripts create one as needed.
Sent from a tiny keyboard
On Nov 29, 2018, at 5:42 PM, David Schott <notifications<EMAIL_ADDRESS>wrote:
@PatrickLanghttps://nam03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FPatrickLang&data=02|01||70c79fb6ca734206f30f08d656651598|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636791389477395408&sdata=QgfmH7T3iTETZrqoQC5f8KyfnqsI9Y9B3eF6OEUDqQ0%3D&reserved=0 does this mean the Dockerfile for kubletwin/pause (notice the typo btw) is also updated? I've found that the Dockerfile is still referencing microsoft registry which doesn't have images for 1809, when it should be updated to the new registry mcr.microsoft.com/windows/nanoserver:1809http://mcr.microsoft.com/windows/nanoserver:1809
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Facs-engine%2Fpull%2F4246%23issuecomment-443060102&data=02|01||70c79fb6ca734206f30f08d656651598|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636791389477395408&sdata=ovKcu4RZJTJTHjmd3G1WPf4yKBBaeVNwAkHhhrbSCo8%3D&reserved=0, or mute the threadhttps://nam03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAK0eF9yj_oi7ySw-b8kM3CH1VfpDG6Z3ks5u0I0CgaJpZM4Yc2iw&data=02|01||70c79fb6ca734206f30f08d656651598|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636791389477395408&sdata=Ez%2BylAs6gifXqI3y4%2BOFe57K8w8aXsSSAK%2FWDjIbrLU%3D&reserved=0.


Extension issue

Issue Type: Bug
Extension Name: remote-wsl-recommender
Extension Version: 0.0.15
OS Version: Windows_NT x64 10.0.19044
VS Code version: 1.70.1

:warning: We have written the needed data into your clipboard. Please paste! :warning:

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.73.1. Please try upgrading to the latest version and checking whether this issue remains.
Happy Coding!

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.73.1. Please try upgrading to the latest version and checking whether this issue remains.
Happy Coding!

Thank you. I will try this now

Closing the issue. If you still see the problem, please add more information here and I will reopen.


[5.3] array max validation rule doesnt give correct msg

Laravel Version: 5.3.10
PHP Version: 7.0.9
Database Driver & Version: NaN
Description:
when u try to upload an image with size bigger than the max value u will get an error of something like The image must be an image..
this only happens in array upload , but in single upload it works as expected.
Steps To Reproduce:

route

Route::post('/', [
    'as'   => 'store.files',
    'uses' => 'StoreController@store',
]);

controller

public function store(Request $request)
{
    $this->validate($request, [
        'image' => 'required|image|max:2048',
    ]);

    foreach ($request->image as $one) {
        $one->store('images', 'public');
    }

    return url('/')->with('success', 'done');
}

form

{{ Form::open(['route' => 'store.files', 'method' => 'POST', 'files'=>true]) }}
    {{ Form::file('image[]',['multiple']) }}

    {{ Form::submit('submit', ['class'=>'btn btn-success']) }}
{{ Form::close() }}

@if (isset($errors))

        @foreach ($errors->all() as $one)

{{ $one }}

        @endforeach

    {{ dd($errors->all()) }}
@endif

You have an error in your Validation statement:
'image' => 'required|image|max:2048',

Should be:
'image.*' => 'required|image|max:2048',

Since the given input is an array.

yeap, thanx

@themsaid btw still no chance to update the docs about the displaying of array validation errors ?

hmmm you can make a PR if you want :)


chore: Refactoring the review step

What this PR does / why we need it:

Making layout updates to the review step

Verification steps

< PROOFOFCONCEPTS > < WIZARD STEP 5>

Ticket Link

https://issues.redhat.com/browse/MGDCTRS-1586

I feel like at least "Connector name" shouldn't wrap:

However I see some of the other fields can get lengthy as I'm re-reviewing the screenshots :smile:  Maybe it'd be better to stick with the default width for now and ignore my comments around wrapping, sound good @Kells512?

I applied the DescriptionList component with the extended width to see what it would look like, but I also noticed a issue with the DescriptionList. Its making the text greyer then the example, and the content in DescriptionListTerm not bold. I'm not sure why it is behaving differently from the pattern fly example. I will attach screenshots of each
PatternFly Example:
https://patternfly-react-main.surge.sh/components/title#default-sizes
Review Step:
https://patternfly-react-main.surge.sh/components/title#default-sizes
https://patternfly-react-main.surge.sh/components/title#default-sizes

I think most likely we could have some local css rule doing that, and probably that rule needs it's specificity improved.  What I would do here is examine the css rules that are getting picked up via the Chrome DevTools.  Most likely there's a css file probably in one of the parent components that's causing this.
Or it could be one of our third party packages, but I'd be more suspicious of our own repo first :smile
Let pull the branch down here and have a peek.

Cool!  I started to look yesterday but then I also had a solid day of calls :smile: so I didn't get to look much :face_with_spiral_eyes:.  Glad you were able to find it!

This also looks really good to me! I'm assuming you were able to fix the CSS specificity issues. The only other thing I think would be good to look at is the data shape property, which appears to have a nested description list to provide the value. The property key and value that display for the data shape property are really far apart.
Here are a few suggestions for addressing this:

Since the text "Consumes" includes the colon ":" you could concatenate the key and value into a single string, e.g. "Consumes: application/octet-stream" with a space between.
You could use the fluid horizontal variant for that one key/value pair so that they display together.

@jgiardino I will try those suggestions now!

Sounds good, thanks folks!  I'll put this in draft for now @Kells512


Removed Base64 encoded fonts

Removed the Base64 encoded fonts to remove this data from the browsers critical path. This has been replaced by standard @font-face declarations. More information of this change can be seen in PR 341 from govuk_template.
I've tested these changes in the example application and they work as expected.

Closing this as this is covered by this PR.


⚠ Samsung has degraded performance

In 52d95e2, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2624 ms

Resolved: Samsung performance has improved in 8318377.


2 errors on line 59

Hi there! I wanted to try your bot. But I get 2 errors.
Unused variable 'content_type'
Unused variable 'chat_type'
May I ask how I can fix this? Thank you!!

Hey!
I'm not shure... i never got those errors...
Do you have telepot installed and everything?
Maybe the problem is just that we are not using the variables? Maybe try to
delete them where I'm setting them?
Greetings from Germany,
Cedric
Am Mi., 13. März 2019 um 21:50 Uhr schrieb ygreq<EMAIL_ADDRESS>
Hi there! I wanted to try your bot. But I get 2 errors.
Unused variable 'content_type'
Unused variable 'chat_type'
May I ask how I can fix this? Thank you!!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/adderou/telegram-forward-bot/issues/8, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AG1vFjUcYqreo7ibfff9rnorzC-kNB1vks5vWWSNgaJpZM4bwIbm
.


rewrite-maven error parse pom.xml

rewrite-maven has error in ResolvedPom.resolveDependencies , it try download maven-core use the version properties ${project.prerequisites.maven}, but the transmitting dependencies has be exclude

Hi @HelloDhero ; it's unclear what you're asking. Please follow this structure when opening issues, and include enough details for us to reproduce the issue:
https://github.com/openrewrite/.github/blob/main/.github/ISSUE_TEMPLATE/bug_report.md


Spectator View connecting but not responding in compositor

Hey Jackson,
I'm working in the SV that you setup for me at Holohack (I'm doing a talk on it at a Hololens Meetup on Thursday).
I followed the instructions that I remembered (and that I found online) -- entered in my Holo's IP and deployed it.  My Hololens and Unity recognize the session -- even to the point that the SV Player that spawns is tracking the movement of my headset, but when I hit play there is no motion in the compositor or the game window.
Any thoughts?  Thanks!

I had the same problem sometimes. For me it helped when the compositor window stays as standalone window.

if you close spectator view window and recreate it from menu, it helps.


Unsubscribe app when extension popup is closed

This PR fixes apps not being unsubscribed when SCC window is closed in the extension mode.
This is to prevent onUpdateListener() to be called when the UI is closed, since it'll try to update a not-existing-anymore UI controls, causing an exception.

Thanks! Only a couple of nits, otherwise looks good.


Valiator for topojson

I have been following the tutorial lets make a map I have only deviated in that  I am trying to make a map for the whole globe. As soon as I get to the first step of plotting data I get an error from within D3 code. The trigger is in this piece of code
svg.append("path")
      .datum(topojson.feature(uk, uk.objects.subunits))
      .attr("d", d3.geo.path().projection(d3.geo.mercator()));

The error is that the code is trying to call call the type of a null object. I have tried a few things but now wonder if the json I have generated is valid. Is there a validator specifically for topojson?
I have found geoJSONlin. Can i use this? is there anything that would fall through?

To clarify this is a copy of the errors as recorded in the browser console(using chrome)
Uncaught TypeError: Cannot read property 'type' of undefined

featureOrCollection @ topojson.v1.js:219

(anonymous function) @ countries.html:19

(anonymous function) @ d3.v3.js:1992

event @ d3.v3.js:504

respond @ d3.v3.js:1945

This is the entire page code at this point
<!DOCTYPE html>
<meta charset="utf-8">
<style>

/* CSS goes here. */

</style>
<body>
<script src="http://d3js.org/d3.v3.js"></script>
<script src="http://d3js.org/topojson.v1.js"></script>
<script>

var width = 960,
    height = 1160;

var projection = d3.geo.mercator()
    .scale(500)
    .translate([width / 2, height / 2]);

var path = d3.geo.path()
    .projection(projection);

var svg = d3.select("body").append("svg")
    .attr("width", width)
    .attr("height", height);

d3.json("countries.json", function(error, uk) {
  svg.append("path")
      .datum(topojson.feature(uk, uk.objects.subunits))
      .attr("d", path);
});

</script>

Finally Changing the JSON source on the page above to 'http://bost.ocks.org/mike/map/uk.json' renders the data correctly. So it my problem has occurred somewhere in the steps to generate the json. I have followed the steps as outlined on the blog several times and always get this error the only warning message is the following when I unzip the files I have downloaded from natural earth

warning [tmp/ne_10m_admin_0_map_subunits.zip]:  515 extra bytes at beginning or within zipfile

Hi @CrowdHailer
the problem is not with the json itself, but with the use of the "subunits" property in the example code.
I had the same issue: I generate a json map for the whole world from http://www.naturalearthdata.com/ ; I try to load it; I get the same error @ line topojson.v1.js:219
The problem is that the topojson.v1.js code is looking for a property "subunits" under "objects", as in 'http://bost.ocks.org/mike/map/uk.json'
{"type":"Topology","transform":{"scale":[0.001546403012701271,0.0010939367048704803],"translate":[-13.69131425699993,49.90961334800009]},"objects":{"subunits":{"type":"GeometryCollection","geometries": ... } }

If you've downloaded a world map, just like I did, chances are your json looks something like this
{"type":"Topology","objects":{"GRAY_HR_SR_OB_DR":{"type":"GeometryCollection" ...} }

Just substitute "subunits" with "GRAY_HR_SR_OB_DR" (or whatever else you have there) in the example code, and map will load fine
d3.json("countries.json", function(error, uk) {
  svg.append("path")
      .datum(topojson.feature(uk, uk.objects.GRAY_HR_SR_OB_DR))
      .attr("d", path);


The filled star is off center in WebKit (Safari) when the page is zoomed in

Safari is lagging with implementation of transform-origin for svg and apparently the current implementation in webkit does not account for page zoom. This can be worked around be using composite transform where origin is emulated by translations.
No zoom:

Max zoom:

Upstream bugs:

Incorrect percent transform-origin when browser is zoomed: https://bugs.webkit.org/show_bug.cgi?id=218300
Transform-origin on SVG breaks when zoom in or out: https://bugs.webkit.org/show_bug.cgi?id=194903


[Bug]: Error creating chat assistant via API

Is there an existing issue for the same bug?

[X] I have checked the existing issues.

RAGFlow workspace code commit ID
6d19294ddc200454f37136635f73c9c803315761
RAGFlow image version
v0.14.1 slim
Other environment information
OS type: Linux

Actual behavior
When I try to create a chat assistant the RAGFlow API always returns this error message:
The dataset 02d23930b7f011efae530242ac130006 doesn't own parsed file

I just created the dataset and document in the same function where I create the chat assistant.
Expected behavior
The chat assistant should be created.
Steps to reproduce
ragflow = RAGFlow(api_key=RAGFLOW_API_KEY, base_url=RAGFLOW_BASE_URL)
dataset = ragflow.create_dataset(name = dataset_name)
doc = dataset.upload_documents([{
    "displayed_name": "Products.txt",
    "blob": b"",
}])[0]
# I will add chunks via the API later
assistant = ragflow.create_chat(
    name = assistant_name,
    dataset_ids = [dataset.id],
    prompt = Chat.Prompt(ragflow, {
        "prompt": system_prompt
    })
)

Additional information
No response

No, the dataset is created the way the script in the bug report does it. I create a dataset, add an empty file, then try to create the assistant.

An empty file can not be parsed, can it?
Try it with another file that has content and use the parse call before trying to access the dataset.

Not in the API documentation. Btw. do I need to call dataset.async_parse_documents([doc.id]) after I added chunks to the document via doc.add_chunk(content)? Anyway, if I call dataset.async_parse_documents([doc.id]) for that empty file I get:
Task has been received.
Page(1~100000001): Start to parse.
Page(1~100000001): [ERROR]Internal server error while chunking: [Errno 2] No such file or directory: Products.txt

That is an OS level error for the file not existing within the RAGFlow docker container? Something seems to be really broken.

And if I use the file body b"Foo Bar\n" and call dataset.async_parse_documents([doc.id]) the file parses successfully, but then when trying to create the assistant I get:
Traceback (most recent call last):
  File "/app/src/bug_repro.py", line 61, in <module>
    assistant = ragflow.create_chat(
                ^^^^^^^^^^^^^^^^^^^^
  File "<@beartype(ragflow_sdk.ragflow.RAGFlow.create_chat) at 0x71e972efad40>", line 127, in create_chat
  File "/usr/local/lib/python3.11/site-packages/ragflow_sdk/ragflow.py", line 133, in create_chat
    raise Exception(res["message"])
Exception: 1048

Oh and getting this in the ragflow-server logs:
ragflow-server | 2024-12-12 06:03:50,826 INFO     17 <IP_ADDRESS> - - [12/Dec/2024 06:03:50] "GET /api/v1/datasets/ca93a178b80b11efb2f50242ac130006/documents?id=ca9dfc0eb80b11efae530242ac130006&page=1&page_size=30&orderby=create_time&desc=True HTTP/1.1" 200 -
ragflow-server | 2024-12-12 06:03:50,832 ERROR    17 (1048, "Column 'rerank_id' cannot be null")
ragflow-server | Traceback (most recent call last):
ragflow-server |   File "/ragflow/.venv/lib/python3.10/site-packages/peewee.py", line 3291, in execute_sql
ragflow-server |     cursor.execute(sql, params or ())
ragflow-server |   File "/ragflow/.venv/lib/python3.10/site-packages/pymysql/cursors.py", line 153, in execute
ragflow-server |     result = self._query(query)
ragflow-server |   File "/ragflow/.venv/lib/python3.10/site-packages/pymysql/cursors.py", line 322, in _query
ragflow-server |     conn.query(q)
ragflow-server |   File "/ragflow/.venv/lib/python3.10/site-packages/pymysql/connections.py", line 563, in query
ragflow-server |     self._affected_rows = self._read_query_result(unbuffered=unbuffered)
ragflow-server |   File "/ragflow/.venv/lib/python3.10/site-packages/pymysql/connections.py", line 825, in _read_query_result
ragflow-server |     result.read()
ragflow-server |   File "/ragflow/.venv/lib/python3.10/site-packages/pymysql/connections.py", line 1199, in read
ragflow-server |     first_packet = self.connection._read_packet()
ragflow-server |   File "/ragflow/.venv/lib/python3.10/site-packages/pymysql/connections.py", line 775, in _read_packet
ragflow-server |     packet.raise_for_error()
ragflow-server |   File "/ragflow/.venv/lib/python3.10/site-packages/pymysql/protocol.py", line 219, in raise_for_error
ragflow-server |     err.raise_mysql_exception(self._data)
ragflow-server |   File "/ragflow/.venv/lib/python3.10/site-packages/pymysql/err.py", line 150, in raise_mysql_exception
ragflow-server |     raise errorclass(errno, errval)
ragflow-server | pymysql.err.IntegrityError: (1048, "Column 'rerank_id' cannot be null")
ragflow-server |
ragflow-server | During handling of the above exception, another exception occurred:
ragflow-server |
ragflow-server | Traceback (most recent call last):
ragflow-server |   File "/ragflow/.venv/lib/python3.10/site-packages/flask/app.py", line 880, in full_dispatch_request
ragflow-server |     rv = self.dispatch_request()
ragflow-server |   File "/ragflow/.venv/lib/python3.10/site-packages/flask/app.py", line 865, in dispatch_request
ragflow-server |     return self.ensure_sync(self.view_functions[rule.endpoint])(**view_args)  # type: ignore[no-any-return]
ragflow-server |   File "/ragflow/api/utils/api_utils.py", line 285, in decorated_function
ragflow-server |     return func(*args, **kwargs)
ragflow-server |   File "/ragflow/api/apps/sdk/chat.py", line 123, in create
ragflow-server |     if not DialogService.save(**req):
ragflow-server |   File "/ragflow/.venv/lib/python3.10/site-packages/peewee.py", line 3128, in inner
ragflow-server |     return fn(*args, **kwargs)
ragflow-server |   File "/ragflow/api/db/services/common_service.py", line 69, in save
ragflow-server |     sample_obj = cls.model(**kwargs).save(force_insert=True)
ragflow-server |   File "/ragflow/.venv/lib/python3.10/site-packages/peewee.py", line 6923, in save
ragflow-server |     pk = self.insert(**field_dict).execute()
ragflow-server |   File "/ragflow/.venv/lib/python3.10/site-packages/peewee.py", line 2011, in inner
ragflow-server |     return method(self, database, *args, **kwargs)
ragflow-server |   File "/ragflow/.venv/lib/python3.10/site-packages/peewee.py", line 2082, in execute
ragflow-server |     return self._execute(database)
ragflow-server |   File "/ragflow/.venv/lib/python3.10/site-packages/peewee.py", line 2887, in _execute
ragflow-server |     return super(Insert, self)._execute(database)
ragflow-server |   File "/ragflow/.venv/lib/python3.10/site-packages/peewee.py", line 2600, in _execute
ragflow-server |     cursor = database.execute(self)
ragflow-server |   File "/ragflow/.venv/lib/python3.10/site-packages/peewee.py", line 3299, in execute
ragflow-server |     return self.execute_sql(sql, params)
ragflow-server |   File "/ragflow/.venv/lib/python3.10/site-packages/peewee.py", line 3289, in execute_sql
ragflow-server |     with __exception_wrapper__:
ragflow-server |   File "/ragflow/.venv/lib/python3.10/site-packages/peewee.py", line 3059, in __exit__
ragflow-server |     reraise(new_type, new_type(exc_value, *exc_args), traceback)
ragflow-server |   File "/ragflow/.venv/lib/python3.10/site-packages/peewee.py", line 192, in reraise
ragflow-server |     raise value.with_traceback(tb)
ragflow-server |   File "/ragflow/.venv/lib/python3.10/site-packages/peewee.py", line 3291, in execute_sql
ragflow-server |     cursor.execute(sql, params or ())
ragflow-server |   File "/ragflow/.venv/lib/python3.10/site-packages/pymysql/cursors.py", line 153, in execute
ragflow-server |     result = self._query(query)
ragflow-server |   File "/ragflow/.venv/lib/python3.10/site-packages/pymysql/cursors.py", line 322, in _query
ragflow-server |     conn.query(q)
ragflow-server |   File "/ragflow/.venv/lib/python3.10/site-packages/pymysql/connections.py", line 563, in query
ragflow-server |     self._affected_rows = self._read_query_result(unbuffered=unbuffered)
ragflow-server |   File "/ragflow/.venv/lib/python3.10/site-packages/pymysql/connections.py", line 825, in _read_query_result
ragflow-server |     result.read()
ragflow-server |   File "/ragflow/.venv/lib/python3.10/site-packages/pymysql/connections.py", line 1199, in read
ragflow-server |     first_packet = self.connection._read_packet()
ragflow-server |   File "/ragflow/.venv/lib/python3.10/site-packages/pymysql/connections.py", line 775, in _read_packet
ragflow-server |     packet.raise_for_error()
ragflow-server |   File "/ragflow/.venv/lib/python3.10/site-packages/pymysql/protocol.py", line 219, in raise_for_error
ragflow-server |     err.raise_mysql_exception(self._data)
ragflow-server |   File "/ragflow/.venv/lib/python3.10/site-packages/pymysql/err.py", line 150, in raise_mysql_exception
ragflow-server |     raise errorclass(errno, errval)
ragflow-server | peewee.IntegrityError: (1048, "Column 'rerank_id' cannot be null")
ragflow-server | 2024-12-12 06:03:50,833 INFO     17 <IP_ADDRESS> - - [12/Dec/2024 06:03:50] "POST /api/v1/chats HTTP/1.1" 200 -

Is there a place where these error codes are documented?

We got it to work doing this:
ragflow = RAGFlow(api_key=RAGFLOW_API_KEY, base_url=RAGFLOW_BASE_URL)
dataset = ragflow.create_dataset(name = dataset_name)
doc = dataset.upload_documents([{
    "displayed_name": "Products.txt",

    # File with some content other than white-space.
    # Otherwise it will say that there is no file later on.
    "blob": b"...\r\n",
}])[0]
# I will add chunks via the API later
assistant = ragflow.create_chat(
    name = assistant_name,
    dataset_ids = [dataset.id],
    prompt = Chat.Prompt(ragflow, {
        "prompt": system_prompt,

        # Explicitly pass empty string for rerank_model.
        # The documentation says this is the default, but the
        # Python client has None as the default which will
        # cause a NOT NULL constraint violation in the
        # ragflow server.
        "rerank_model": "",
    })
)

I don't meet this problem in ragflow:nightly version


Add the Pod

Currently, then repository has members of the MLH team on it, but you should replace them with members of the pod.
You can update information in _data/fellows.yml
You should work on:

[ ] Replacing the images
[ ] Update the names and locations of each fellow
[ ] Update the pod number inside of _config.yml

@grace-omotoso Please how do you suggest I get the images of each team member?
I thought of getting them from their Github profile but a number of us didn't upload and profile picture or specify our location.

@grace-omotoso I'm done adding the images and updating the location, but the images are not responsive, so we're thinking of using a carousel for this. Can we go on with the fix or another issue will be created for that?

Using a carousel will be better. Ideally, do not clog the navbar with the images. Let us have another section for that in the main page. Something like this

Alright...we'll implement this.
Thanks for the sample


Ignore zero sized chunks in auto_chunks

[ ] Closes #xxxx
[ ] Tests added / passed
[x] Passes pre-commit run --all-files

When an array is interspersed with empty chunks, the zero-valued chunks skew the median; this accounts for that while maintaining original behavior if the array only contains empty chunks.
Test cases are yet to be added.

Can one of the admins verify this patch?
Admins can comment ok to test to allow this one PR to run or add to allowlist to allow all future PRs from the same author to run.

ok to test

@jasonkena Do you have a reproducible example that we can run to see how this behaved before and after the change?
Similarly, would you mind adding a test for this new behavior? I see we have two path codes (if/else) and we should cover both of them.


Invalid link of openprompt

Thank you for the great work. I found out that the link of openprompt is broken while reproducing. Thus I install the package from the link: https://github.com/thunlp/OpenPrompt. Nevertheless, I found out that the input of SoftTemplate written in src/train.py seems to be different from those written in the current official github (https://github.com/thunlp/OpenPrompt). Could you please provide the correct version of openprompt that you have used? Thank you very much.

I encounter the same issue.


fix: heading

h1 should be used instead of h4.

This is not necessary I think...

This is not necessary I think...


lint and gofmt tools; not yet added to travis

Signed-off-by: Rajat Chopra<EMAIL_ADDRESS>Two things in the PR:

Re-org hack/build-go.sh so that lint tools can re-use the symlink based GOPATH setup
hack/lint.sh and hack/verify-gofmt.sh

Ultimately we should run hack/{lint,verify-gofmt}.sh with travis, but it cannot be done right now since travis does not support multiple language installs (doing it manually will slow everything).

Could golang be installed at install stage for enabling those checks?

LGTM

hack/lint.sh takes a very long time on my system and eventually hits "deadline exceeded". How long does it take in your system?

Would you mind installing the latest gometalinter and see how long it takes?

Turns out that you need a lot of RAM for gometallinter to work. My VM had 2 GB, and it would simply not complete. On a 16GB system, it works fine. I guess, it won't work in Travis?

Yep, it's very slow on low-memory machine.

For Travis we can just golint maybe.

@rajatchopra
With #115 , travis looks to be working fine.


List::push* fixed; tests added

Current coverage is 91.97%

Merging #959 into master will increase coverage by +0.20% as of 07a0b86

@@            master    #959   diff @@
======================================
  Files           74      74
  Stmts         8884    8888     +4
  Branches      1709    1712     +3
  Methods          0       0
======================================
+ Hit           8153    8175    +22
  Partial        175     175
+ Missed         556     538    -18

Review entire Coverage Diff as of 07a0b86

Powered by Codecov. Updated on successful CI builds.

Thx - you're right!!


“No service”

Okay so this just recently started being an issue when I was jailbroken a month  ago EVERYTHING was fine but now all it keeps saying is “no service you need to update the iPhone in order to use it” but I wanna keep my jailbreak

Do they mean an iOS update or a carrier update?
If it's a carrier update, you can install it without losing the jailbreak (I believe, I've never done one myself). In this case you'd have to go to Settings -> General -> About. Go down the page to Operator / Carrier. Click Operato, wait about 10-15 seconds.There should be an update available for you there

I've been getting that "No service" as well. Started to drop signal all of sudden and I thought I was the only one. It's definitely a bug. I'm using version 3.1.3.

If enable "Reload System Daemons", cellular service is randomly crashing. It happens on my iPhone7(iOS 12.1) often.