DatarecordDuration is only a multiple of 1s

Hi there,
I'm using PyEDFlib to read and write some EDF files, and I'm a bit confused about the DataRecordDuration. Specifically, when I call the writeSamples() method, by default the EDF file is write with a block duration of 1sec of time intervals.
Could someone please clarify what the duration argument of the EDF header actually represents?
Is there any way to use pyedflib to write EDF files with durations that are not a multiple of a second? I tried looking through the documentation and source code but didn't find anything that could help me.
How can I force the number of  NSamples ?
For example:

  sample = np.random.random_sample((1, 1000)) * 100
  with tempfile.TemporaryDirectory() as tmp_dir:
      out_499 = f"{tmp_dir}/out_499.edf"
      pyedflib.highlevel.write_edf(edf_file=out_499, signals=sample, header=highlevel.make_header(),
                                   signal_headers=highlevel.make_signal_headers(list_of_labels=["channel"],
                                                                                sample_frequency=499))
      edf = pyedflib.EdfReader(str(out_499))

      assert edf.getSampleFrequency(0) == 499
      assert edf.getFileDuration() == 3
      assert edf.getNSamples()[0] == 1497 # 499 * 3 why not 998  ?  2*499 ?

      # Complete the 998 to 1497 samples with zeros ???

      out_500 = f"{tmp_dir}/out_500.edf"
      pyedflib.highlevel.write_edf(edf_file=out_500, signals=sample, header=highlevel.make_header(),
                                   signal_headers=highlevel.make_signal_headers(list_of_labels=["channel"],
                                                                                sample_frequency=500))

      edf = pyedflib.EdfReader(str(out_500))
      assert edf.getSampleFrequency(0) == 500
      assert edf.getFileDuration() == 2
      assert edf.getNSamples()[0] == 1000 # 500 * 2

Thanks in advance for your help!

When working with time domain data one often thinks of data in terms of a sample frequency, i.e. how many samples are saved per second, i.e. smp/sec. However, in the EDF format, not only the nominator (smp) but also the denominator (sec) can be set and determines how many samples are saved per block (also called 'record'). So if your signal has a sampling frequency of 50 Hz you could save 50 samples per block and set the DataRecordDuration to 1 second. Alternatively, you could also save 100 samples per block and set the DataRecordDuration to 2 seconds, as 100/2 is also 50 Hz.
You can manually set the DataRecordDuration by calling f.setDatarecordDuration(100000) where f is an isntance of EdfWriter. Note that the value for the function needes to be in units of 10 microseconds, ie. 1 second = 100000
Please note that DataRecordDuration and FileDuration are two different things, the former noting how long a block of data is in the time dimension and the latter denotes how long the entire file is in the time dimension.
Hope that clarifies that a bit?
The current release information unfortunately contains some mistake w.r.t this, however in most cases it should still work.


DNS Private Enums

Hi there, I'm trying to use the wire::DnsPacket functions set_opcode and set_flags which take the Opcode and Flags enums respectively. Unfortunately, the parameter types are enums defined in wire::dns which is private. I've attempted to access them through DnsPacket, DnsRepr, and DnsQueryType, but am unable to. Is there any reason why these are not accessible to the user of DnsPacket?

Probably an oversight. Can you send a PR?


About ResNet regularization

In cifar10-resnet, did it apply weight decay to weights in all layers or just fc layer?

In the code.
On all variables named "W" (no bias, no bn scaling factors) of all layers.

In my comprehension, it means all trainable weights in every layer. Is that right?

It will depend on what you mean by "weights".
As I said, no bias, no bn scaling factors.


[FABG-1035] goroutine leak

I'll try.
In this place (func initializer), not a single line of code is covered by tests.
I had only 15 erroneous executions for 9000 iterations.


Wrong exit code micromamba list foo

It seems that micromamba returns an exit code 1 on
micromamba list foo

(i.e. for an non-existing package), which is inconsistent with conda
Ref https://github.com/mamba-org/provision-with-micromamba/pull/41

Hi @tdegeus. Issues with micromamba behavior that are not docker specific should be posted to the mamba issue tracker.

https://github.com/mamba-org/mamba/issues/1556


Pasting from Windows to Codespaces Terminal doesn't work

When running Harlequin inside a Codespaces Terminal, copy-pasting does not work when moving into and out of the codespace.
for example - the snippet select 1 as test:

[x] from windows -> WSL terminal
[x] from windows -> WSL terminal, ssh connected to codespace
[ ] from windows -> WSL terminal, ssh connected to codespace, running harlequin

I've added xsel and xclip to my docker image, but neither appears to do anything. "Out of the box" Windows Terminal running Ubuntu inside WSL copy+paste works seamlessly.

copying inside harlequin works perfectly, for what its worth, its just bringing data from the clipboard into harlequin (in linux codespace) where it fails.


Clean up code and URL related to advanced Add API backend form

Currently, the Add API backend form allows users to add or edit API backend configurations. Since, we now have the Add API backend wizard, we want to disallow the usage of the advanced form for adding API backend. It will still be used for editing API backeds, in case there is a need for more advanced configurations.

Already cleaned up in the latest develop.


Set the appropriate headers on IssuerAuth.

These headers (x5chain and alg) are required by 18013-5.
Test: Manually tested.

This was accidentally merged w/o review. Closing.


https://m.facebook.com/profile.php?id=100089205943765&device_id=a95a0072-ed72-466a-b41e-f77c7b964578&wtsid=rdr_0j9hWgyWv5AU1PdIJ

Environment

Operating system (including version):
mkcert version (from mkcert -version):
Server (where the certificate is loaded):
Client (e.g. browser, CLI tool, or script):

What you did

What went wrong
https://m.facebook.com/profile.php?id=100089205943765&device_id=a95a0072-ed72-466a-b41e-f77c7b964578&wtsid=rdr_0j9hWgyWv5AU1PdIJ

https://m.facebook.com/profile.php?id=100089205943765&device_id=a95a0072-ed72-466a-b41e-f77c7b964578&wtsid=rdr_0j9hWgyWv5AU1PdIJ

https://m.facebook.com/profile.php?id=100089205943765&device_id=a95a0072-ed72-466a-b41e-f77c7b964578&wtsid=rdr_0j9hWgyWv5AU1PdIJ

https://m.facebook.com/profile.php?id=100089205943765&device_id=a95a0072-ed72-466a-b41e-f77c7b964578&wtsid=rdr_0j9hWgyWv5AU1PdIJ


Results of PSScriptAnalyzer are not shown anymore

I have some Analyze task defined as below. Unfortunately this does not returns the errors or warnings anymore which would be useful.
When invoking PSScriptAnalyzer manually by the commands from the tasks it works perfectly, so I assume it must be something about psake not giving me those.
Function PSakeTask-Analyze {
  $analysis   = Invoke-ScriptAnalyzer -Path $outputDir -Verbose:$false
  $errors     = $analysis | Where-Object { $_.Severity -eq 'Error' }
  $warnings   = $analysis | Where-Object { $_.Severity -eq 'Warning' }

  if (($errors.Count -eq 0) -and ($warnings.Count -eq 0)) {
      "`tPSScriptAnalyzer passed: 0 Warnings || 0 Errors"
  }

  if ($errors.Count -gt 0) {
      Write-Error -Message "PSScript Analyzer failed: Errors found!"
      Write-Host $errors | Format-Table
  }

  if ($warnings.Count -gt 0) {
      Write-Warning -Message "PSScript Analyzer found warnings!"
      Write-Host $warnings | Format-Table
  }
}

Expected Behavior
Output of task regarding errors and warnings of ScriptAnalyzer should be written.
Current Behavior
Output of task (errors and warnings of ScriptAnalyzer) are not shown.
Instead I only get
At /Build/psakeFile.ps1:61 char:5 +     PSakeTask-Analyze +     ~~~~~~~~~~~~~~~~~ [<<==>>] Exception: PSScript Analyzer failed: Errors found!
Steps to Reproduce (for bugs)

Define a Analyze task as shown above
Run task

Your Environment

Module version used:

ModuleType Version    PreRelease Name                                PSEdition ExportedCommands
---------- -------    ---------- ----                                --------- ----------------
Script     4.9.0                 psake                               Desk      {Invoke-psake, Invoke-Task, Get-PSakeScriptTasks, Task…}
Script     1.20.0                PSScriptAnalyzer                    Desk      {Get-ScriptAnalyzerRule, Invoke-ScriptAnalyzer, Invoke-Formatter}

Operating System and PowerShell version:
Windows 10
tried with PS Desktop 5.1 and PS Core 7.1.3

Uhoh...my bad...should not throw before sending output...lol


Fix invalid import syntax

The import syntax here is invalid by spec I believe, but babel allowed it by translating it to a default import + object destructure, in absence of any named exports.
However, JSS has added named exports when going from v3.3.0 to v3.4.0. This is technically a backwards compatible change, so the minor version bump is fine. However, the behavior is breaking in react-modal-dialog when combined with the way babel works. Now that JSS has named exports, import {create} from 'jss' tries to find and bind to the create export which doesn't exist, rather than destructuring the default Jss object into the create variable. Therefore, builds that have installed the latest JSS (v3.4.0) will see this or similar:
TypeError: (0 , _jss.create) is not a function
    at Object.<anonymous> (/usr/src/app/node_modules/react-modal-dialog/lib/useSheet.js:31:27)

This fixes the issue by restoring the behavior in a way that is compatible with default exports. Alternatively, this could also be fixed by just using new instead of create because that's all create does anyway.

@jeffora Thanks for the PR. Sorry it's taken so long to get to a response. I believe that since this is a compile step I don't need to actually do anything to the library that is currently live on npm.


cneira-issue-2280

Add manpage option to lxc

This pull request didn't trigger Jenkins as its author isn't in the whitelist.
An organization member must perform one of the following:

To have this branch tested by Jenkins, use the "ok to test" command.
To have a one time test done, use the "test this please" command.

Those commands are simple Github comments of the format: "jenkins: COMMAND"

You really should read about git rebase :)
I'm sorting out your other pull request first, then I'll try to figure out this one and do the same thing (merge the various commits together into my branch and submit it).

Thanks a lot. My apologies, I'll read about git rebase before submitting
more pulls :)
On Tue, Aug 30, 2016 at 2:03 PM, Stéphane Graber<EMAIL_ADDRESS>wrote:

You really should read about git rebase :)
I'm sorting out your other pull request first, then I'll try to figure out
this one and do the same thing (merge the various commits together into my
branch and submit it).
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/lxc/lxd/pull/2325#issuecomment-243508322, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AEIIdSuJh-OuGpyxswZn_5pkLY1SQQxtks5qlGJ5gaJpZM4JwuLZ
.

Closing in favor of #2328


Fix lambda wrapping edge case.

#386

Codecov Report

Merging #388 (0e46da5) into main (2df4751) will decrease coverage by 0.01%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##             main     #388      +/-   ##
==========================================
- Coverage   87.32%   87.31%   -0.02%
==========================================
  Files          15       15
  Lines        2967     2972       +5
==========================================
+ Hits         2591     2595       +4
- Misses        376      377       +1

Impacted Files
Coverage Δ

padl/wrap.py
90.06% <83.33%> (-0.33%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2df4751...0e46da5. Read the comment docs.


[Feature]About freespace planner and astar_navi

Hello @aohsato, thanks for trying to imporve astar_navi! BTW I have a few questions about how this planner works:

Which branch should I use to perform the astar planner + obstacle avoidance?

Is it not required to use either vector map and waypoint saver methods?

Is it the finall output that we set up a goal wherever on the free areas on the grid map and it will publish a global path and a velocity to the robot until it reaches the goal? Just like a normal 2D slam on ROS Navigation stack, we dont need to create a lane on vector map.

I tried to follow the instructions above but I could not get it working, the astar path wasn't out on Rviz, is that ok that you could upload your testing video on Youtube and share the link here?

Thank you!

@kennedywai Can we move this topic to my issue? Thanks!
https://github.com/CPFL/Autoware/issues/1591


feat(dapp-lib): merge main to dapp-lib

Codecov Report

Merging #222 (032d565) into dapp-lib (86b0be2) will increase coverage by 12.48%.
The diff coverage is 71.27%.

@@              Coverage Diff              @@
##           dapp-lib     #222       +/-   ##
=============================================
+ Coverage     22.45%   34.94%   +12.48%
=============================================
  Files            21       36       +15
  Lines          4301     5205      +904
=============================================
+ Hits            966     1819      +853
- Misses         3335     3386       +51

Impacted Files
Coverage Δ

ckb-contracts/contracts-helper/src/chain.rs
0.00% <0.00%> (ø)

ckb-contracts/tests/src/lib.rs
0.00% <ø> (ø)

ckb-contracts/tests/src/utils/case_builder.rs
0.00% <0.00%> (ø)

ckb-contracts/types/src/eth_lock_event.rs
97.61% <ø> (+1.61%)
:arrow_up:

...b-contracts/types/src/generated/eth_header_cell.rs
2.87% <45.55%> (-12.46%)
:arrow_down:

ckb-contracts/types/src/generated/witness.rs
40.04% <55.00%> (+3.98%)
:arrow_up:

...ts/lib/eth-recipient-typescript-lib/src/adapter.rs
72.50% <71.42%> (+72.50%)
:arrow_up:

ckb-contracts/types/src/hasher.rs
81.81% <81.81%> (ø)

ckb-contracts/eth-spv-lib/src/ethspv.rs
38.04% <100.00%> (ø)

...racts/lib/eth-bridge-lockscript-lib/src/actions.rs
100.00% <100.00%> (+10.48%)
:arrow_up:

... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86b0be2...032d565. Read the comment docs.

remove several unused code use serde::export::XXX, which is not in conformity with custom
please modify monitor module to adapt main branch
better merge only relay comfirmed blocks pr ,  which is missed in this pr


Distribution contact test

Please provide your name and company
Devin McManus, TNTP
Link the issue/feature request which this PR is meant to address

https://github.com/fivetran/dbt_qualtrics_source/issues/7
Detail what changes this PR introduces and how this addresses the issue/feature request linked above.
adds contact_lookup_id to the distribution_contact unique test here: https://github.com/fivetran/dbt_qualtrics_source/blob/36dfc658cee91975d66e38f33c6ad8dc6fecba1b/models/stg_qualtrics.yml#L562-L566
How did you validate the changes introduced within this PR?
Ran test in TNTP development environment
Which warehouse did you use to develop these changes?
TNTP snowflake instance
Did you update the CHANGELOG?

[x] Yes

Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)

[x] Yes

Provide an emoji that best describes your current mood

🤷♂
Feedback
We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.
PR Template

Community Pull Request Template (default)

Maintainer Pull Request Template (to be used by maintainers)

Thanks @dmcmtntp for opening this as well as providing the underlying versioning and changelog updates ! We'll wrap this into an upcoming sprint and get it released!

changes committed!

Thanks for that @dmcmtntp ! I have merged your changes into our branch and am hoping that we will be able to release these changes sometime later this week! We will keep you in the loop.

great, thank you!


Update Connectivity_API.md

What type of PR is this?
Add one of the following kinds:

documentation

What this PR does / why we need it:
This PR updates the API documentation to 0.4.1.
Which issue(s) this PR fixes:
Special notes for reviewers:
Changelog input
 release-note

Additional documentation
This section can be blank.
docs

@bigludo7
The documentation is specific to v0.4.1, and that version didn't follow the design guidelines very well. Some clean up of the error messages was done for 0.5.0-wip, so the next version should be better.
Although this documentation doesn't quite match the error examples given in v0.4.1, it's close enough and I don't see any great value in spending additional effort documenting more exactly something that will anyway be changing soon when v0.5.0 is released.
So I'm tempted to just merge this, consider v0.4.1 finished and then move on with v0.5.0. Let me know what you think.

@eric-murray Got it !
Thanks Eric.
Works for me.


Can't use swagger with RESTEasy

as com.wordnik.swagger.jaxrs.ApiListing.scala (http://goo.gl/qAdni line 23) requires a jersey only class. Can you make it please JAX-RS implementation agnostic?
Thank You!

Hi @vtkstef, swagger-core lib has no dependencies on JAX-RS.  The idea is that we build a module for each framework which implements swagger.  We have done the same for Play and others are working on spring MVC.  You can see here:
http://stackoverflow.com/questions/9188425/spring-rest-api-documentation-using-swagger
Happy to help with implementing support for RESTeasy + swagger

Hi,
I will definitely take up your offer to help us implement a RESTEasy module. RESTEasy is a JAX-RS implementation, so according to the stackoverflow entry you mentioned, all the pieces should be in place already, the first piece ApiListingResource.scala should not have any problems, while the second will have problems because it extends ApiListing, which itself has a direct dependency for com.sun.jersey.api.core.ResourceConfig, Instead of relying on a jersey implementation of ResourceConfig, why don't you have the developer specify in the web.xml the implementation of
javax.ws.rs.core.Application and pull your root resource class info from it?
Ciao
Stefano

Will take a look at enhancing the jax-rs module as you suggested

This work sounds great! However, something to bear in mind here is that not all RESTEasy users will have their own Application implementation. RESTEasy has several mechanisms for auto-scanning for JAX-RS annotated resources without need for a JAX-RS Application implementation. For example, the approach I am used to using has RESTEasy pull REST resources from Spring: http://docs.jboss.org/resteasy/docs/2.0.0.GA/userguide/html_single/index.html#RESTEasy_Spring_Integration.
This is a problem colleagues and I have come up against recently whilst we have been evaluating Swagger. We're exploring a few options so if we come up with any bright ideas we'll update this issue.

I use spring too to configure restpoints via the resteasy spring context listener. But for swagger I would be more than happy to provide it an javax.ws.rs.core.Application implementation without declaring it explictely as a resteasy servlet init param.

Not being a RESTeasy ninja, if someone can port the scala-jaxrs petstore to RESTeasy I can probably get it wired in.  Would love to get this added as a module

Updated link https://github.com/swagger-api/swagger-samples/tree/master/java/java-resteasy


Menu bar overlaps window title

Not too sure what caused this, but I reloaded my window and it seemed to show an overlap on the title bar

Feel free to close if this isn't enough info to file a bug.

Thanks for filing, I couldn't repro myself, but I'm going to leave this open in case others see the same and can provide more info. Also DENDRON!

Thanks for creating this issue! We figured it's missing some basic information, such as a version number, or in some other way doesn't follow our issue reporting guidelines. Please take the time to review these and update the issue.
Happy Coding!

I think I have more info about the bug? Seems that I can reproduce it when I'm really zoomed in and going from window to maximized. I also seem to recreate it easier when I'm on an extension page.

yep, 100% repro, thanks a ton!

this is a regression, so adding as candidate

This happens because before maximizing, the hamburger is shown and after, the menu should have enough space, but title section does not get the memo and doesn't get out of the way

This bug has been fixed in the latest release of VS Code Insiders!
@andreamah, you can help us out by commenting /verified if things are now working as expected.
If things still don't seem right, please ensure you're on version 1259bfe0090ac90afbf5d53335c43761de6bb19f of Insiders (today's or later - you can use Help: About in the command palette to check), and leave a comment letting us know what isn't working as expected.
Happy Coding!

I was not able to reproduce the original issue.


🐛 [Firebase/Analytics] Firebase Analytics report that Mac users use iOS....

Firebase Analytics reports that all my Mac OS users used iOS... I think you mean Mac OS...

Hi @stephane-archer, I think this might be an issue with the underlying firebase-ios-sdk rather than the flutter fire plugins.
Can you try reaching out to firebase support to see if they can offer any assistance?

I tried but they have been not so cooperative saying that Firebase is built for mobile and the web, not Mac OS and desktop experience. so "it's not a bug but a feature"...

Hi @stephane-archer, the macOS implementation is more or less based on the iOS implementation.
Since the flutterfire_plugins are thin wrappers around the native implementations, this would have to be implemented on the native side before we can (if required), implement it on our end.
Please feel free to raise a feature request on the firebase-ios-sdk repo. If you are redirected here, kindly leave a comment below and I will reopen this.
Thank you

"Hi Stephane,
Thanks for the quick update and for providing those details.
Upon further investigation of the issue-at hand and also discussing your case with the team, it appears that the OS should be reported as "Macintosh" rather than "iOS" as stated in the documentation.
As an action on your behalf, I have filed your case along with the details you have shared as a bug report for our engineering team to further investigate the issue at-hand. While our team continues to investigate this behavior, please note that we have yet to provide any details or timelines for the fix. For now, you may keep an eye out on our release notes and official blog to get the latest updates regarding Firebase features and its services, including the bug fixes and enhancements we've rolled out.
Our sincere apologies for the inconvenience this has caused you. Just let me know if you have additional questions or clarifications, I'll be more than happy to help.
Best,
Troy"


Browser-sync not reloading browser after CLI update

I updated Foundation CLI yesterday and now file changes don't update in browser. The browser looks like it's refreshing but it the changes don't come through. I have to refresh the browser manually to see the changes. Thanks-Adolfo

Strange, the CLI just runs the template, it doesn't affect how the template works. When did you create the project? (Asking so I can figure out if you're missing any recent bug fixes to the template.)

Updated on the twelve. I downloaded everything over on the 13th and started a new site. I'm not sure when the new fixes where issued. Could there be something wrong with my node files?

Hi, Here is the response from the folks at Gulp.js: https://github.com/gulpjs/gulp/issues/1489 ... They are saying that is not a gulp.js.

Hi, I reached out to the folks at gulp.js: https://github.com/gulpjs/gulp/issues/1489 and they say it is not a gulp.js issue. Any Ideas?

Oh actually, what types of files are you changing and then not getting a refresh? HTML pages, partials, layouts? Sass? JavaScript?

Hi,
HTML pages and Sass.

I made some adjustments to the Gulpfile, and after thorough testing, every lingering issue with auto-refresh appears to have been resolved. See this comment for an explanation of the fixes, and a link to the relevant commit.
You can update your template through a simple cut-and-paste.

Yes! Thank you so much. That did it! Thanks - Adolfo


Since KSP 1.2.0, in the VAB/SPH, activity level "Neutral" is not displayed correctly in the tool tip.

It appears as "<color=aqua>Neutral".

Thank you for the report. It seems that "aqua" is synonym for "cyan", but for some reason it has stopped working and needs to be replaced by "#00ffffff". It should be an easy fix. I need to recompile the dll. I will upload a fix to Spacedock soon-ish.


Move onItemEnter/onItemLeave listeners onto the items.

Proposed Change:
Move onItemEnter/onItemLeave listeners onto the items.
Add onRowEnter/onRowLeave props
Fixes: #205 205
Change type

[x] Bugfix
[x] New feature

Checklist

[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)

I'm confused why the existing code toggles this.selecting on hover events. I would assume that you wouldn't want these calbacks to fire when selecting. I keep it as it, but it seems incorrect. Can someone please clarify the reasoning.

I'm confused why the existing code toggles this.selecting on hover events. I would assume that you wouldn't want these calbacks to fire when selecting. I keep it as it, but it seems incorrect. Can someone please clarify the reasoning.


Moved kefir to peerDependencies

Moved kefir to peerDependencies like in other calmm repos (karet, karet.util...) so that you don't end up with multiple different packages of kefir, resulting in failing instanceof checks.

Codecov Report

Merging #6 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master     #6   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           1      1
  Lines         155    155
=====================================
  Hits          155    155

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 088bfc7...76a052a. Read the comment docs.

Thanks!


[0.1.0-canary.x] Variants named with a $ prefix don't work

Bug report
Describe the bug
When we create variants with $ prefix in it's name, the variant styles are not generated and attached to stylesheet
For instance, this does not work:
const Button = styled("button", {
  variants: {
    color: {
      $primary: {},
      $white: {}
    }
  }
});

Though, this works
const Button = styled("button", {
  variants: {
    color: {
      primary: {},
      white: {}
    }
  }
});

To Reproduce
Steps to reproduce the behavior, please provide code snippets or a repository:

Go to https://codesandbox.io/s/stitches-disabled-button-forked-06rxp?file=/src/App.tsx

Expected behavior
I don't know if this is a bug or a feature request. But would it be too much to expect variants named similarly as tokens to work OOTB?
Screenshots
N.A.
System information
Environment: CodeSandbox
Additional context
We generate variants for our primitive components like Box, Text from our theme tokens. So, in Text, a variant named color takes values defined in theme.colors
const colorVariants = generateThemeVariants(theme.colors, (token) => ({ color: `$${token}` }))

const Text = styled(Box, {
  variants: {
    color: colorVariants
  }
}

Now we can do
<Text color="primary" /> // without the $

But it get's confusing when used along with css
<Text color="primary" css={{ borderColor: "$primary" }} />

We kinda have to mentally keep track of where to use $ and where not to. For consistency, I'd prefer to make the variants follow the same convention as that of token (where they use name from theme tokens)

We’ve moved away from using $ anywhere outside of tokens, and thus we no longer recommend using $ for non-tokens.

@jonathantneal what about when we want to have a non $ special  character in token. Like % as mentioned in https://github.com/modulz/stitches/issues/525


Fix navbar styles

Environment

Smapp version: develop

Describe the bug

I believe that only selected menu item should be colored in purple, other links should be white.

Hey @brusherru, I think I can solve this. Could you assign to me this issue?


fix: use variable declaration for URLON object

Sometimes project bundled with webpack complies on undefined URLON variable which breaks app.

I think it is caused because webpack defines modules using 'use strict' declaration by default

@vjeux can you please merge this ?

@vjeux thanks ! Can you update npm as well ? :)

@borisirota what's your npm username, I can add you as admin instead :)

@vjeux I can take an npm manage. My npm username is guria.

npm owner list URLON
- guria <****.com>
- vjeux <****.com>

Feel free to make the project better :)

Lowercased package would be great too. Also what about repo access?

@vjeux my npm username is borisirota. Thanks !

@vjeux my username is krishmunot. Thanks! :)

@KrishMunot there's no npm user name: https://www.npmjs.com/~krishmunot
I added borisirota and guria to both urlon and URLON. Have fun with it :)

@vjeux thx. should we create a fork, or continue to "have fun" here?

I can give you commit access here

Would be great, thx

Done :)
Can't wait to see what you do with it :)

@borisirota published<EMAIL_ADDRESS>(lowercased)

@Guria Thanks !

Sorry, @vjeux , I fixed that. My npm exists now - **krishmunot
** Also, I would love to have commit access here too. Thanks!

@krishmunot do you have any actual plans on it? We will have to cooperate to no to mess anything.


FALCON-2171 When feed from multiple colos are replicated, the colo folders get overwritten

Made changes to use the include path to set source and target of Distcp (not just the base directory of feed).
UT added. Manual testing done with single colo. Test on distributed setup pending.

:+1:  Test failure is irrelevant to this patch.


feat: rename packspec field to packspec_version

Might not need a spec version field at all, but can revisit after https://github.com/neovim/packspec/issues/41


Problem with Bot Framework Emulator

Hi All,
I generate very simple bot (using C# template which I downloaded from http://aka.ms/bf-bc-vstemplate), but I'm having issues trying to get the emulator recognize my bot (I use 3.5.23 version of emulator).
Log from emulator:
[20:42:11] Emulator listening on http://[::]:16188
[20:42:16] -> POST Refresh access token failed with status code: 400
[20:42:25] -> POST Refresh access token failed with status code: 400
[20:42:27] -> POST Refresh access token failed with status code: 400
Any idea what’s wrong?

Hi Eric,
Many thanks for quick replay, but I'm afraid that my system clock date and time is OK.
Please see screenshot.

Any other ideas?
Best Regards,
Andrzej

Ok. Just to double-check another way, does the time on your computer match the time on your phone?

Assuming they do match, the next thing to check is your bot's appId and password. Is your bot configured with an appId and password? Here's an auth troubleshooting guide that you might find helpful:
https://docs.botframework.com/en-us/support/troubleshooting-bot-framework-authentication/

Hi Eric,

It's amazing your Time2Respond. Many thanks for your involvement.

Time at my phone is the same as on my computer.

Yes, my bot configured with an appId and password (please see screenshot). But I checked 3-times correctness of them during type them on emulator.

Blank appId and password in code [Web.config] = diffrent type of log error:
[22:31:55] -> POST 401 [conversationUpdate]
[22:31:55] Error: The bot's MSA appId or passsword is incorrect.
[22:31:55] Click here to edit your bot's MSA info.

Any other ideas?
Best Regards,
Andrzej

@andrzejsobczak ,
Instead of downloading the template, please check by using the following nuget package:
https://www.nuget.org/packages/Microsoft.Bot.Builder/
See this thread for more details:
https://github.com/Microsoft/BotFramework-Emulator/issues/51

@andrzejsobczak When trying to connect without MSA, please make sure you've cleared out the appId and password from the bot's configuration in the emulator, in addition to removing them from the bot's web.config. I'm referring to these fields:

Please make sure those two fields are empty before connecting.

Hi Abhishek,
Many thanks for our information.
I have one question: before I import Microsoft.Bot.Builder (using Package Manager Console at my Visual Studio) should I create an empty Project Template for C#? Or in other words: should I open any project at VS before I import Microsoft.Bot.Builder ?
Best Regards,
Andrzej

@andrzejsobczak
Create an empty project with Bot template(or use existing bot project) and update the bot builder version from Visual studio NuGet package to latest version. Try to test it with latest bot emulator (https://docs.botframework.com/en-us/tools/bot-framework-emulator/)

@abhishan many thanks for your help. It works now.
I will close  this issue.

@Kothakapu many thanks for your help. It works now.
I will close  this issue.


Suggest using nightly on E0658

E0658 is "An unstable feature was used." Playground already suggests adding #![feature(...)] on nightly channels; it would be nice for it to suggest switching to nightly too.

Same for https://doc.rust-lang.org/stable/error-index.html#E0554 (not sure what the difference between the two is).

Duplicate of #314


add timeout

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.lifeng seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Rpgle Indentation Problem

Describe the bug
Hi all,
the compiler didn't accept an End-Ds if i declare a Dcl-Ds LikeRec(Myrcd : *All);
starting from this line the indentation control give me all indentation error.
Look at this:

Another problem, if I still disable Rpgle indentation control, it still remain the warning of the indentation problem.

@pabloto Yes, once you disable you will need to restart the editor - hoping to change this in the future.
Also, can you share the snippet of code that I can copy and paste to recreate it? It should be easy to solve.

Hi Liam,
here's a snippet:
`**free
Ctl-Opt  DftActGrp(*no)
ActGrp(*StgMdl)
StgMdl(*SNGLVL)
Expropts(*AlwBlankNum)
Option(*NoUnRef :*SrcStmt :*NoDebugIo)
DatFmt(*Iso) TimFmt(*Iso)
Debug(*Constants)
AlwNull(*UsrCtl)
DftName(TSTLIKEREC)
Text('Test Ds LikeRec');
Dcl-F Employee Keyed ExtFile('SAMPLE/EMPLOYEE') Qualified;
Dcl-Ds DsEmployee LikeRec(Employee.Employee :*ALL);
// ____________________________________________________________________________
Chain '000010' Employee DsEmployee;
If Not %found(Employee);
Return;
EndIf;
Dsply DsEmployee.FirstNme;
Return;
`

Similar to #342?
@worksofliam @pabloto

@SJLennon Yup. Very similar indeed. Easy fix.


[Quick Accent] Move number super and subscripts from Portuguese to All Languages

Description of the new feature / enhancement
The number super and subscripts (₀⁰, ₁¹, ₂², ₃³, ₄⁴, ₅⁵, ₆⁶, ₇⁷, ₈⁸, ₉⁹) are in Portuguese, even though IMO it would make more sense for them to be in All Languages.
Scenario when this would be used?
Typing indexes using Quick Accent.
Supporting information
I couldn't find any supporting evidence that Portuguese uses these characters more than any other language.

@octastylos-pseudodipteros
Your contribution is welcome and thank you for your work on this. Feel free to open a PR. If you have any further questions don't worry to ask them.


Review the Python library Vapory in order to get the images in  POV-Ray.

Vapory enables to pipe the rendered images back into Python and integrates very well in the Python libraries ecosystem
Vapory
Zulko
Zulko - Vapory

http://zulko.github.io/blog/2014/11/13/things-you-can-do-with-python-and-pov-ray/


Provide the ability to manage notes

If we provide the ability to manage notes on an object
To the engineer
Then they will be able to add context to the object as necessary
To validate this, we will:

[x] Demonstrate that a note can be entered
[x] Demonstrate that a note can be retrieved
[x] Demonstrate that a note can be updated
[x] Demonstrate that a note can be deleted
[x] Demonstrate that notes can be searched
[x] Demonstrate that special characters are supported in the note's content
[x] Ensure all tests are passing
[x] Confirm the documentation is up to date

released in 0.4.0


Extend project lint result struct with includes

The Gitlab API exposes a list of (recursive) includes when linting a projects ci configuration. The ProjectLintResult struct representing the API response does not reflect this list, so a user of the SDK cannot use this information from the API. It is also not possible to grab this information via response body parsing outside of the go-gitlab client, as the body is already closed when the client code can access it.
So, in short, this change allows the client code to access the list of includes returned by the Gitlab API.
My only concern is the documentation of the includes type. It is not documented in the api docs of the lint API (see https://docs.gitlab.com/ee/api/lint.html#validate-a-projects-cicd-configuration). Instead, one can find the specification in the openapi spec, see https://gitlab.com/gitlab-org/gitlab/-/blob/master/doc/api/openapi/openapi_v2.yaml?plain=1#L52442. But relying on this spec is inconsistent with the rest of the go-gitlab library...
Please let me know if this still is an acceptable change - and of course whether there is anything else missing (e.g. if further tests are required).
Thank you!

@timofurrer  -what're your thoughts about "undocumented" features that are only in the OpenAPI spec? I believe that OpenAPI spec is auto-generated, so it may include fields that aren't technically meant for "public" use, but it seems to me as long as it's present there it seems reasonable to support it.
I suppose we could open a documentation update MR and see what comes from that too; if it's denied to include in the docs, I don't think we should support it here.

@RicePatrick

I suppose we could open a documentation update MR and see what comes from that too; if it's denied to include in the docs, I don't think we should support it here.

Yes, probably this or an issue. There have been other instances where we asked for doc changes or made the updates. But also, where we've just supported them here. I very much prefer the former though.

Hey @RicePatrick and @timofurrer thanks for joining in!
There is a similar thing with the jobs field, there is an include_jobs attribute documented in the request (see https://docs.gitlab.com/ee/api/lint.html#validate-a-projects-cicd-configuration) but the response in case this attribute is set to true is omitted - so it might be that the documentation (resp. the examples) is just not up to date to the latest api changes..
I have started an issue on Gitlab on this: https://gitlab.com/gitlab-org/gitlab/-/issues/508011
Although I'm not sure if the issue is placed correctly - I'll maybe route this also via our Gitlab Support...

@TheCodear thanks for creating the upstream issue - I've triaged it. Let's see.

Perfect! thanks @timofurrer

@TheCodear we've migrated the repository over to GitLab.com.
Please see https://github.com/xanzy/go-gitlab/issues/2060#issuecomment-2532116371 for more context.


Dockerize, or waiting for external service, in Phusion BaseImage

I found this nifty little utility called dockerize (https://github.com/jwilder/dockerize) that will make the docker container wait for an external service to be made available. For instance, I use it while using docker-compose to make some containers wait until a DB is up and running before starting a backend app.
The downside is that using it as the CMD of the container (ie. dockerize -wait tcp://mysqldb-container:3306 -timeout 60s /sbin/my_init), then my_init no longer reaps zombie processes. Is there any way to get the best of both worlds: using my_init for proper process mgmt but also make the container wait for an external service?
Thanks!

You should run my_init first, and then let my_init run dockerize.


Adds more panel types

See commit messages for details

Hey, I'm going to go through this and see how we can merge this. Can you please leave a comment here with a full explanation of the new panel types and how to use them?
Thanks for taking the time to put this together.


[WIP] Maintenance - do not merge

Cleanup melange. @byronz this ended up running to 15 files... will be a little annoying to merge into the monorepo, my apologies.

@byronz I'll take care of bringing the still-relevant pieces of this over to the dash repo after the merge. Meantime I'll close this PR


Parse kwargs

pass --model-kwargs (and --opt-kwargs for train) through to factory / model __init__ fns for more configurability from cmd line
Update several models to better support dynamic act layer, norm layer, and overlay passed args on cfg
Cleanup along the way, incl some improved model docstrings
in_chans handling in validate/inference.py
bfloat16 handling in benchmark.py

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


Move RangesListFactory out of the internal package

For use-cases with fixed ranges that are reused as satisfies() arguments for different versions, it is necessary to create ranges from strings. IIUC, the only way to do so is via RangesListFactory.create(), but I feel bad using an internal class. So please consider making it non-internal.

It sounds reasonable to me. RangesListFactory should be close to RangesList.


fix: minor text whitespace formatting

fixed minor text whitespace formatting issue in the what is daytona section

Current behavior:

Expected behavior:

https://github.com/daytonaio/docs/pull/96#issuecomment-2258629213
Same comment applies here


Tabbing through address tags on node does not switch focus properly when inputting text

Using Chrome 35 for OS X, I've noticed that when adding address information for a node that tabbing does not switch focus sequentially, i.e. it does not switch from addr:number to addr:street after typing the address number.
This only occurs after inputting text into the fields.

This also happens on Firefox 38 on Linux.

This is fixed in 23b22fd


Error when mask is of the same size as that of the input X

Hi,
First of all, thank you for putting such an easy to use implementation on GitHub.
I'm trying to incorporate the nystrom attention into a legacy codebase, it previously used to provide the input X and the mask (off the same dimensions as X) to a Multi headed Attention Layer.
When I'm trying to integrate nystrom attention with it, it runs alright without the mask.
But, when I pass the mask alongside it, it throws einops rearrange error.
Sorry, if this is a very basic question, but how would you recommend I deal with handling 3D mask (same dimensions as the size of input) in the codebase.
Best,
VB

I got confused with the dimensions, this is fixed now


Dev builds published to Maven central causing automatic upgrades to -alpha

What happened?
Currently the build pipeline pushes pre-release builds to Maven Central and for both Maven and Gradle projects templates there does not seem to be an easy way to specify "use latest except pre-release". As a result, customers end up with projects that pull in "latest" release from Maven Central, and this may be a pre-release published from Pulumi.
This is causing issues like this one: https://github.com/pulumi/pulumi-aws/issues/2658
In addition, pre-releases don't look great on Maven Central.
The proposal is to avoid publishing pre-release to Maven Central all together.
Expected Behavior
User projects pull latest production Java builds.
Steps to reproduce
See referenced issue.
Output of pulumi about
N/A
Additional context
This issue is not specific to AWS but affects all Pulumi providers, but starting here as the most obvious place to file.
Contributing
Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

@t0yv0 I think we have the version range for our Java templates wrong. I currently read this for aws-java:
        <dependency>
            <groupId>com.pulumi</groupId>
            <artifactId>aws</artifactId>
            <version>(,6.0.0]</version>
        </dependency>

Source: https://github.com/pulumi/templates/blob/master/aws-java/pom.xml#L26-L30
Looking at the POM reference documentation for version, what we specify includes v6.0.0:
(,1.0]: Hard requirement for any version <= 1.0.

I think this needs to be updated to [,6.0.0) to exclude 6.0.0.

Oh great catch.

Couple of notes here CC @guineveresaenger
The issue affects not just AWS but every template we have.
Fix 1: fix the templates

maven version plugin will fix maven templates.
For Gradle templates need something similar perhaps.
templates only fix new projects, existing projects continue upgrading to alphas :)

Fix 2: stop publishing alphas to Maven Central

fixes both maven and gradle
fixes projects retroatively
alphas not available easily on Central; perhaps we can push them to another place (like Github artifacts)

Also there's a distinction between dev builds and pre-releases like betas and alphas. I've been told to stop using -SNAPSHOT as it's evil. It think most projects don't push dev builds into Central. Looking at https://mvnrepository.com/artifact/org.jetbrains.kotlin/kotlin-stdlib-common but this one seems to push -RC and -Beta etc. This makes me think that projects using a release version do not automatically upgrade to -Beta or -RC? Would need to test this out, I don't know off the top of my head. Perhaps there's third solution possible here that does not involve 3rd party plugins but is the "canonical" way.

Would a possible option (3) be to use the -SNAPSHOT suffix (docs)? This would probably entail publishing to a "snapshot" repository, since some repositories are unwilling to host snapshots.

I think it's a slightly separate discussion on -SNAPSHOT, but I would like us to avoid SNAPSHOT builds as they are non-deterministic.

Coming back to the original problem, it still is unfortunately the case today. Our generated code for pulumi new aws-java makes this version range:
    <dependencies>
        <dependency>
            <groupId>com.pulumi</groupId>
            <artifactId>pulumi</artifactId>
            <version>(,1.0]</version>
        </dependency>
        <dependency>
            <groupId>com.pulumi</groupId>
            <artifactId>aws</artifactId>
            <version>(6.0.2,6.99-beta]</version>
        </dependency>
    </dependencies>

This resolves to a dev build:
$ mvn dependency:tree
[INFO] Scanning for projects...
[INFO]
[INFO] -----------------------< com.pulumi:2024-07-26 >------------------------
[INFO] Building 2024-07-26 1.0-SNAPSHOT
[INFO]   from pom.xml
[INFO] --------------------------------[ jar ]---------------------------------
....
[INFO] \- com.pulumi:aws:jar:6.42.0-alpha.1718749934:compile
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  0.499 s
[INFO] Finished at: 2024-07-26T14:51:00-04:00
[INFO] ------------------------------------------------------------------------

The two solutions I see here:

we can stop pushing dev builds to Central
or we can stop using version ranges in pulumi/templates but use pinned versions and automate moving the pins forward


[ContainerRegistry] v5.0.0-preview

Update container registry management sdk with latest api spec package-2019-12-preview

@isra-fel I addressed your comments. Thanks. Can you take another look?


Per the Note.. Did lightweight solution load get removed or was the choice of using it removed?

It looked like a band-aid feature and was unfinished.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 50302b6c-c81b-4a07-656c-ff8446a78629
Version Independent ID: b78f187a-0ed7-abf3-2a2c-5f0a77980ced
Content
Content Source
Service: unspecified

@StingyJack the feature was removed.

Here's a blog post about the improved startup performance.


[HDF5 Widget] Example not working (at least under windows)

It does not recognize valid SPEC files. It says file cannot be read as  HDF5, fabio or SpecFile.
File drop does not work either

It is fixed in the last master

DnD is still not working on windows

DnD is fixed by https://github.com/silx-kit/silx/pull/279

But Spec files are not supported. Some changes on https://github.com/silx-kit/silx/pull/251 are expected.
I can split this pull request to merge the part concerning Spec.

You can split the pull request, however, the raised exception should not say "file cannot be read as HDF5, fabio or SpecFile" if you only support HDF5 at this point It should say "file cannot be read as HDF5".

Sounds fine

Closed by #251


[Feature] Rename files -> paths [#tara-label-enhancement] [#tara-label-good first issue]

Is your feature request related to a problem? Please describe.
Given that both files and directories can be added using the files input which seems limited to describing files.
Describe the solution you'd like?
Proposed change here would be renaming files to paths which is more generic and can describe both file based paths and directories.
Describe alternatives you've considered?
No response
Anything else?
No response
Code of Conduct

I agree to follow this project's Code of Conduct

Decided to go down the route of replicating the inputs for just directories.

After much thought this seems like the best approach to prevent confusion with files and directories

Is this a breaking change?

Yes this would be a breaking change.

Don't have much time to work on this closing for now.


Stuff to do edy - Changes to abortion sign to make it look nicer and clearer

I updated the languages to correctly  include the top three languages that people generally speak in the entire world.
I also updated the warning sign when you click abort message to make it look nicer and cleaner.

Good work, Edy.


list of files inaccurate

I'm seeing a weird behavior when running lsp.  When I run lsp in pretty much any directory, the number of files is accurate but I'm seeing lots of repeated filenames.  For example, in a given directory with 100 files, I see 100 files in the list but only one or two filenames, almost like a couple of the names "smear" over everything else.
Below is how to reproduce this problem.  I'm running ubuntu 14.04 LTS x64 and I built lsp using go version xgcc (Ubuntu 4.9.1-0ubuntu1) 4.9.1 linux/amd64.  I ran a simple 'go get ' like the README specifies.
Thanks for the awesome tool.  Hopefully we can fix this.  I'll take a look too but I have zero go programming experience.  =)
To reproduce the problem:

In some directory, create some files:
for i in {1..20}; do touch file$i; done
Run lsp and get this:

                                                  file9  Empty File (Empty File)
                                                  file9  Empty File (Empty File)
                                                  file9  Empty File (Empty File)
                                                  file9  Empty File (Empty File)
                                                  file9  Empty File (Empty File)
                                                  file9  Empty File (Empty File)
                                                  file9  Empty File (Empty File)
                                                  file9  Empty File (Empty File)
                                                  file9  Empty File (Empty File)
                                                  file9  Empty File (Empty File)
                                                  file9  Empty File (Empty File)
                                                  file9  Empty File (Empty File)
                                                  file9  Empty File (Empty File)
                                                  file9  Empty File (Empty File)
                                                  file9  Empty File (Empty File)
                                                  file9  Empty File (Empty File)
                                                  file9  Empty File (Empty File)
                                                  file9  Empty File (Empty File)
                                                  file9  Empty File (Empty File)
                                                  file9  Empty File (Empty File)

               lsp "/tmp/problem", 20 files, 0 directories

I get the same problem on my laptop, Ubuntu Trusty, using go1.4, gvm v1.0.22

Hmmm I just solved it (less than 1 minute, :open_mouth:)
It seems that the bug occurs when you use lsp with a different go version than the one you installed lsp with. Is it possible ? I just re-ran go get github.com/dborzov/lsp with go1.4 and it works now.


Added LLM server classes (support Ollama and LM Studio)

Added LLM server classes (support Ollama and LM Studio)

Added an abstract class LLMServerBase with an abstract method GetChatCompletionAsync in LlmServerBase.cs.
Implemented the LMStudioServer class with the GetChatCompletionAsync method to interact with the LM Studio server in LmStudioServer.cs.
Implemented the OllamaServer class with the GetChatCompletionAsync method to interact with the Ollama server in OllamaServer.cs.
Added a reference to System.Net.Http in the EntwineLLM.csproj project.
Added a type converter (LlmServerConverter) for selecting the LLM server in general options (EntwineLLMOptions.cs).
Modified properties LlmUrl and LlmRequestTimeOut to use values from the selected LLM server in EntwineLLMOptions.cs.
Replaced direct usage of HttpClient with a call to the GetChatCompletionAs

I add fetching models from Ollama or LM Studio. I've test only LM Studio ! It should work with Ollama but I've not installed it yet.

@DevNullx64 can you please update README.md and CHANGELOG.md before merging?


docs: add batch sample

Taking over from https://github.com/googleapis/google-cloud-java/pull/7725, adds a simple batch sample

Thanks for your work, Jesse!


CKEditor Plugin Issues

Hello,
I followed the doc instructions for the CKEditor plugin how-ever after several hours of troubleshooting, no dice.
I also installed a fresh environment with only django-ckeditor and django-content-editor and am having no luck.
Python 3.8, latest Django
Hate to turn to you but I'm hoping that maybe it's just a simple discrepancy between versions or docs. Thanks!

Oh shoot, I think the documented JS has errors.
Does it work if you set default_attrs = {"data-type": "ckeditortype"} instead of the documented default_attrs = {"class": "richtext"} ?
The JS code assumes django-ckeditor, but the Admin and Forms example uses CKEditor from a CDN.

That did it, thanks!


Fix for convert->reinterpret with RGB24

From https://github.com/JuliaGraphics/ColorTypes.jl/pull/56.

Failure on 0.6 is unrelated.


Remove references to RecoveryPolicy, which was incorrectly introduced

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information

[ ] The title of the PR is clear and informative.
[ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
[ ] Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
[ ] If applicable, the PR references the bug/issue that it fixes.
[ ] Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

[ ] I have read the contribution guidelines.
[ ] My spec meets the review criteria:

[ ] The spec conforms to the Swagger 2.0 specification.
[ ] The spec follows the guidelines described in the Swagger checklist document.
[ ] Validation tools were run on swagger spec(s) and have all been fixed in this PR.

@gbowerman,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

No modification for AutorestCI/azure-sdk-for-node

 https://github.com/Azure/azure-sdk-for-ruby/pull/929

 https://github.com/Azure/azure-sdk-for-python/pull/1398


a raft node is crashed, the leader is empty?

when a raft node is crashed, select leader is empty, why no fllower node become the leader？

how many nodes you have in the raft group? only more than half of the nodes are healthy, they can auto elect the new leader.

2 nodes, one is crashed, there are no leader.

according to the definition of raft protocol, it's the right behavior. if you want the other node to be the leader, you have to call "reset_peers" interface to reset the raft group to contains only 1 node.

thks


Close RedisPool when connection to the redis server has failed (To prevent asyncio lock)

This patch closes the RedisPool when the connection to the redis server has failed. We would get an asyncio error when closing the event loop:
Task was destroyed but it is pending!
task: <Task pending coro=<RedisPool._do_close() running at python3.5/site-packages/aioredis/pool.py:102> wait_for=<Future pending cb=[Task._wakeup()]>>

Nice catch.
But, please provide a test:
try connecting to free port, catch error and check that pool is marked closed

@popravich Wait, I am not sure how to test this as create_pool raises an exception when the connection has failed, so it wouldn't return an instance of RedisPool. Hence there is no way to check if the pool is marked closed.
Another approach would be to catch exceptions and return the current state of pool.
What do you think?

Yeah, missed that issue)
Lets do the following:

add logger.debug call after gather in _do_close() with something like this
logger.debug("Closed %d connections", len(waiters))
in test try connecting to unused port
catch exception
run dummy loop iteration (so that _do_closed() finish)
catch that log message
So we'll be sure that coroutine is done.

@popravich Isn't this a little bit inefficient to check? I mean, can't we simply check if the event loop tasks are marked done?.  Something like:
# ... create pool -> close

for task in asyncio.Task.all_tasks(loop):
    assert(task.done()) # All tasks should be "done" if the pool is successfully marked closed

@cynecx this won't work as test itself is a task and is not done until test coroutine is ended.
With logging we'd be able to make even more complex test, for instance start redis server with maxclients=1 and try to create pool with min=2 and catch logs saying that 1 connection has been closed on that error

@popravich Can you review the latest commit. As a asyncio beginner I wasn't sure how to run a loop iteration while being in a loop, so I figured out using asyncio.sleep which seems hacky...
Also I wasn't sure how to catch debug messages, so I went with a logging handler.

Coverage decreased (-0.04%) to 97.219% when pulling 2083f650091d702e5f816b2d5953103f7d5ff7b3 on cynecx:fix_pool into 170f02538fcafd6616e702a9aa73ff7b689cbb59 on aio-libs:master.

Coverage increased (+0.01%) to 97.271% when pulling 2ae6e6f0cabaa5947596b31fa1d09ce11561ec95 on cynecx:fix_pool into 170f02538fcafd6616e702a9aa73ff7b689cbb59 on aio-libs:master.

@popravich Please review the latest commit.

Coverage increased (+0.01%) to 97.269% when pulling 10756dfa46d46f796a4cb5b03d2b3ad0356903a6 on cynecx:fix_pool into 170f02538fcafd6616e702a9aa73ff7b689cbb59 on aio-libs:master.

Coverage increased (+0.01%) to 97.269% when pulling 10756dfa46d46f796a4cb5b03d2b3ad0356903a6 on cynecx:fix_pool into 170f02538fcafd6616e702a9aa73ff7b689cbb59 on aio-libs:master.

Coverage increased (+0.01%) to 97.269% when pulling 10756dfa46d46f796a4cb5b03d2b3ad0356903a6 on cynecx:fix_pool into 170f02538fcafd6616e702a9aa73ff7b689cbb59 on aio-libs:master.

Looks good. Thanks


Non-required property hidden when using oneOf allowing null

I have the following schema.
{
  "required": ["a"],
  "properties": {
    "a": {
      "type": "string"
    },
    "b": {
      "oneOf": [
        {
          "type": "string",
          "enum": ["x", "y", "z"]
        },
        {
          "type": "null"
        }
      ]
    }
  }
}

This works as intended if I feed the editor a startval which looks like this
{
  "a": "",
  "b": null
}

both fields are visible in the editor this way.
However if the startval misses b (or it's simply equal to {})
{
  "a": ""
}

then users are not able to select the value of b.
Experiment here.
Is it possible to specify that b should appear even though it's non-required and not in the startval?
The schema validates JSONs where b is omitted or set to null so validation is not an issue.
I've tried specifying these fields in the defaultProperties array, but that didn't change anything.
I also realize that I could allow users to use the Properties editor button to add the field if they need it, but that's not too user friendly.
The best would be if I could specify that

b should always be visible in the editor, even if it's not required, and
in the editor one would be able to select a value for b or chose to omit it.

Is there a way to do something like this?

I have the same issue...


Enable mountPropagation

Hi - I can't find out how to enable mountPropagation=shared for microk8s.
Ubuntu: 20.04
Microk8s: 1.18
Thanks,
w

Hi @wayneconnolly
Do you follow a guide/tutorial/manual I can look at? What steps do you take and what error do you get?

Hi. I'm trying Longhorn, and also stopped on understanding how to enable mount propagation, which is mandatory for it.
https://longhorn.io/docs/1.1.0/deploy/install/#installation-requirements
Longhorn seems a really viable solution for MicroK8s clusters.

I'm back!
MicroK8s 1.20.1
curl -sSfL https://raw.githubusercontent.com/longhorn/longhorn/v1.1.0/scripts/environment_check.sh | bash
daemonset.apps/longhorn-environment-check created
waiting for pods to become ready (0/1)
waiting for pods to become ready (0/1)
all pods ready (1/1)

  MountPropagation is enabled!

cleaning up...
daemonset.apps "longhorn-environment-check" deleted
clean up complete

Looks like it comes with MountPropagation enabled by default, at least in 1.20.1.


Fix calls to liberr.Wrap with even number of args

As the signature of the function is:
Wrap(err error, kvpair ...interface{})
It expects to get an error and key-value pairs. However, in some places we also pass a message after the error, which breaks this expectation. In this PR those messages are dropped to remain with an odd number of arguments.

That looks good, but did you consider adding another Wrap function with additional string?

I don't see why adding another string - the returned error should be logged with more context (..Error(err, msg, ...)), the error should include the stacktrace and pairs. if one really insists on adding more context there, they could add another pair, e.g., (err, "msg", <msg>)


.github: add 'name' field for the conformance-e2e job

jobs..env.job_name should be the same as the job name. Thus, adding the field 'name' to the job will make sure that connectivity tests junit test results are stored in bigquery for lookerstudio visualization.
Fixes: 12d7643ccd0a ("ci/workflows: add junit reports upload")

/test


chore: double-check revert of 498 and 504 , this time against the master branch

Background
double-checking #508
Changes

Testing

Does this mean the other PR can be closed?

yep, you're bit faster than I 😸 . I closed #510 without merge. If we're going to use this PR, #511, we should also close #508 without merging.

This looks good. (I'll close my PR)


Config system

All the configuration will be handled by the velocity plugin. I have not fleshed this out a lot so all ideas are welcome. Im thinking either yaml or toml for the config system, and maybe some commands to edit the config in real time. Lets toss some ideas around

we have a config system


improve logging

@kevinrue as discussed

[ ] test a mini ruffus pipeline to test how to send an informative error to stdout

@SarahOuologuem

[ ] add numbering to the log files to help understanding the order of the tasks

https://github.com/DendrouLab/panpipes/pull/246

Work in progress: https://github.com/kevinrue/panpipes-logging

The minimal pipeline now successfully write log messages from within the task script script.py to pipeline.log.
The output looks like the second line below, amidst typical pipeline.log contents:
2024-04-03 09:56:03,865 INFO main execution - waiting for 1 jobs to finish
2024-04-03 09:57:27,757 INFO log script - script.py logging to file 'logs/test.out'
2024-04-03 09:57:34,190 INFO main execution - {"task": "__main__.run_script", "engine": ...

I've commented the useful bits that could be reused to do the same in panpipes.
Any question, let me know!

Having thought about it more today, this log message should probably be emitted from the pipeline script rather from the task itself.

it would be issue before the task actually runs, which is safer if the task fails during launch
the pipeline knows explicitly what the log file path is, while the task may not (it emits to stdout and stderr, as far as it's concerned)


build(ci): skipping more builds for deps

v14.0.0 has been released and contains a fix for the issue. Feel free to reopen the issue or to submit a new one if you meet any problems.


<IP_ADDRESS>, <IP_ADDRESS>, <IP_ADDRESS> conditional statement uses also <IP_ADDRESS> var

Question
Is there a good reason for having an Ansible conditional which uses  rule_<IP_ADDRESS>'s variable for rules <IP_ADDRESS>, <IP_ADDRESS>, <IP_ADDRESS> ?  :
  when:
      - ubtu22cis_rule_1_1_2_1 or                                                    # Purpose of this ?
        ubtu22cis_rule_1_1_2_2 or
        ubtu22cis_rule_1_1_2_3 or
        ubtu22cis_rule_1_1_2_4

I imagined that this would ensure the <IP_ADDRESS>, <IP_ADDRESS>, <IP_ADDRESS> task-block will never be executed if rule <IP_ADDRESS> is inactive, respectively when: ubtu22cis_rule_1_1_2_1 is set to false, but  I did not detect in the role other similar approaches.
Was this the initial idea behind it or it's just a super-small inaccuracy related to variables in conditionals?
Environment (please complete the following information):
N/A

hi @ipruteanu-sie
This is a great catch, the first conditional was based on a other baselines where it was classified as level2.
This is not the case on this and you PR is spot on.
Thank you
uk-bolly


How to change item text size?

I see the item TextView is at ms__list_item.xml. And I do not find out where to set the item. Of course, I can set a new adapter to do this.  But maybe a convenient method is better.
Thanks.

Sorry for the delayed reply. I won't be adding a convenience method for this. Pull requests are welcome. You can use your own MaterialSpinnerAdapter and override getView to customize the dropdown. Thanks.


DIR-471 Add mirror form to namespace create dialog

Description

Added new tab to namespace create dialog that makes it possible to create mirror.
Depending on the namespace type (mirror or simple namespace), and mirror auth method (none, ssh, token), the validation schema changes so only valid data can be submitted.
Updated the NodeSchema to be compatible with latest API changes (without this, rendering of non-workflow files in a mirror can fail). There is still work to be done on rendering non-workflow files correctly, but that should be in the scope of another ticket (DIR-475).

Notes for testing and review

Aaron has already created an InfoTooltip component under src/componentsNext/NamespaceCreate/InfoTooltip.tsx in https://github.com/direktiv/direktiv-ui/pull/428/, I think I will use that one when it has been merged and remove the one under src/componentsNext/NamespaceCreate/InfoTooltip.tsx.
We briefly discussed whether a hint should be given when a url is entered and the required format changes between ssh/https. As soon as validation has been triggered once, this is now reflected in the validation errors that are updated when changing criteria. However, I could not conceptualize a good way to check the url field separately before the whole form is validated (mostly in terms of what would make sense UX wise. useForm does offer methods to trigger validation for individual fields, but I think it would be confusing to show only a single error when other fields are theoretically invalid as well, but just haven't been checked yet).
With partially complete / valid inputs, switch between mirror and non-mirror and different auth types. As soon as validation has been triggered once (by submitting with an invalid form), the errors rendered should always appear/disappear according to the different validation criteria.
I have tested token based authentication with a private repository at https://github.com/xbow/direktiv-mirror.git. I will share the access token created for that repository on request.
I have not tested ssh authentication with a real key pair, but the new UI should behave exactly like the old UI. Maybe it is good enough to ask the back-end colleagues to test that everything works correctly after merging.
The back-end accepts invalid data without returning an error. For example. It will create a new namespace even when a wrong SSH key pair is entered (it will just not be populated with any files, I suspect that syncing just fails silently?). This is something we should improve in a later iteration (make the API more verbose regarding errors).

Update 20230804
In 7a057d2dc5fa930e1a57432dcaf361fdac0b0718, I applied css fixes that Aaron added in https://github.com/direktiv/direktiv-ui/pull/428 to this branch. I think that other PR will need some discussion how Storybook should be organized, which I would like to postpone until we have met our milestones for the release; but we should already use these small css fixes now.

Thanks @stefan-kracht, I made the requested changes.
Could you double check that the label width works under OSX? Under Linux, the font is narrower so I didn't have this problem, but I added enough pixels that it should be fine :-).

Could you double check that the label width works under OSX? Under Linux, the font is narrower so I didn't have this problem, but I added enough pixels that it should be fine :-).

👌

Feel free to merge at any time


citing

Hi!
Would like to cite you in my Ph.D. I found
D. Eriksson, D. Bindel, and C. Shoemaker. Surrogate Optimization Toolbox (pySOT). github.com/dme65/pySOT, 2015
on the pySot GitHub site, but nothing on the c++ one. Should I take this? Maybe, a paper arrived in the meantime? ;)

Hi there!
I'm glad you found SOT useful even though I haven't updated it in a while. You can cite it like this:
"D. Eriksson. Surrogate Optimization Toolbox (SOT). github.com/dme65/SOT, 2016"

Done :)


Problems with iOS platform when working on Android and browser

I have used this plugin to create a relatively simple QR scanner application that works perfectly on Android and in the browser. However, I have found that on iOS the plugin did not initialize. The QRScanner object was attached to the window but any calls to its functions, including QRScanner.prepare(), QRScanner.getStatus(), QRScanner.openSettings(), etc. all returned undefined and did nothing. The project built and ran on my iPad with no errors.
Upon further investigation I found that xcode did report some problems during the build process, specifically: Plugin 'QRScanner' not found, or is not a CDVPlugin. Check your plugin mapping in config.xml.
I confirmed that <plugin name="cordova-plugin-qrscanner" spec="2.5.0" /> was present in config.xml and that the version of the plugin was in fact 2.5.0.
I also found that updating my project's html files was not reflected in each new build. This made me suspicious of the integrity of my ios project. So, I ran ionic cordova rm ios followed by ionic cordova add ios. Following this, I have observed that the project does not build successfully but reveals some more specific problems with the plugin's incompatibility. Specifically, the file QRScanner.swift file has 16 problems:

I have attempted to change the SWIFT_VERSION to each of 1.0, 2.0, 3.0 and 4.0 and this has resulted in a few changes in the errors that are reported, but nothing works. I also tried to use the tool to update the code to the latest version of swift but this reported that there were no incompatibilities.

You need to update XCode to latest version

Fixed in 2.6.0 🚀


Fix capitalization for chrony

Thanks for creating the book and youtube series on ansible, I have found them very useful.
I noticed a small inconsistency in the capitalization of chrony in the first playbook, this pull requests removes the capital.

I was scouring the Internet for any official 'is it capitalized or not' references, but I basically found that:

All the official docs and references refer to it as chrony (using monospaced fonts), and sometimes 'chrony', never capitalized
A lot of blog posts and media-related coverage uses Chrony, but that might be due to style-guide issues...

So yeah, it seems more technically correct to not capitalize it, so I'll merge and update the book shortly. Thanks!


Move ILoggingBuilder to Microsoft.Extensions.Logging.Abstractions

I don't want to depend on Microsoft.Extensions.Logging. Please move ILoggingBuilder to Microsoft.Extensions.Logging.Abstractions.
Is there a really good reason why it is in Microsoft.Extensions.Logging?
From where I stand, it is an abstraction.

@davidfowl @muratg
I am working on a large Open Source migration from .NET Framework to .NET Core for DNN (Formerly DotNetNuke). Earlier this year I leveraged the Dependency Injection libraries and configured it which set us up to re-write our logging code using the Logging.Abstractions project.
Currently I have a working implementation using only the Logging.Abstractions project, this uses a fork of log4net that we maintain. The platform is not ready to swap out the Logging implementation for the Microsoft Logging Project, but that will come when we are closer to the ASP.NET Core switch. This slow migration style is necessary to limit breaking changes in how logging is handled in the platform.
I was starting to convert our startup routines mimic behavior of the ASP.NET Core startup and utilize the ILoggerBuilder, when I realized the interface are not in the Logging.Abstractions NuGet. Moving this interface to the Logging.Abstraction project makes a lot of sense to me, and I am willing to make a PR if this is approved.
Questions

Is there any chance we could get this interface moved over to the Logging.Abstractions project? I would be willing to submit a PR
Is there another recommendation you may have?
Should I just pull in the full Logging project even if I'm only using the ILoggingBuilder

Is there any chance we could get this interface moved over to the Logging.Abstractions project? I would be willing to submit a PR

Nope, I still don't think Logging.Abstractions should depend on IServiceCollection. We need to sort this out though. There's a bit of a layering issue introduced here since we added this. However, I don't think the answer is to move it.

Should I just pull in the full Logging project even if I'm only using the ILoggingBuilder

Seems reasonable to do so for this. Are you just wiring a logging provider?

Thanks for the quick response 👍
@davidfowl

Nope, I still don't think Logging.Abstractions should depend on IServiceCollection.

This does make sense, it is a tough problem to solve and I understand we don't want the Logging.Abstraction to take a dependency on the IServiceCollection
@davidfowl

Are you just wiring a logging provider?

Currently I built my own implementations of ILoggerFactory and ILoggerProvider if I pull in the full Logging NuGet I can remove my ILoggerFactory implementation and just take the one provided by the library.
Now that I have spoken with you and thought through this a little more I think this is going to be a much better approach for our long-term migration to .NET Core. This will allow the platform to utilize logging providers the exact same way using the LoggerFactory provided by this library.


[TableHeader]Prop needed for disable sort on a column

Detailed description

Describe in detail the issue you're having.

TableHeader is always showing the caret and no way to disable that.

Is this a feature request (new component, new icon), a bug, or a general issue?

Bug

Is this issue related to a specific component?

TableHeader

What did you expect to happen? What happened instead? What would you like to see changed?

Default to false unless enabled.

What browser are you working in?

all

What version of the Carbon Design System are you using?

5.28.0

What offering/product do you work on? Any pressing ship or release dates we should be aware of?

IAM
Steps to reproduce the issue

Step one
Step two
Step three
etc.

Additional information

Screenshots or code
Notes

Hi @nicoxxie! 👋 Thanks for making this. We have a PR to fix this in #692 if you want to take a look!

@joshblack thanks for the quick turnaround. +1 on the PR


 It would be better to implement a subset of markdown, which also makes more sense to the eye when parsing is turned off.

being implemented in refactor


Optimized layout of options pages according to Visual Studio style

Fix for #1023

The dialog looks great now. Thanks!


What exactly is key.cloud()

Was reading through some of the examples and found the key.cloud() to be an interesting and yet missing part of the documentation.
I only found this information
What exactly is key.cloud() doing?
Perhaps there are some other references I could look into?

That is part of the TFHE API. The transpiler emits code for a single function written against an external API, such as TFHE or OpenFHE. You still have to build the rest of the program.
If you're interested, you may want to check out our next generation compiler, https://github.com/google/heir

@j2kun my query was more: "How does a cloud key function, and what is it?"
Perhaps you have some reference docs on how a cloud key functions enabling such operation on the encrypted data?
As example:
We encrypt the input:
https://github.com/google/fully-homomorphic-encryption/blob/ca42d00e02edde06a6aa8b76b9ced88a0aa20dab/transpiler/examples/hangman/hangman_client_main.cc#L73
We check to see if the letter was in the encrypted state:
https://github.com/google/fully-homomorphic-encryption/blob/ca42d00e02edde06a6aa8b76b9ced88a0aa20dab/transpiler/examples/hangman/hangman_client_main.cc#L83
https://github.com/google/fully-homomorphic-encryption/blob/ca42d00e02edde06a6aa8b76b9ced88a0aa20dab/transpiler/examples/hangman/hangman_api.cc#L18
Reference to how does a cloud key function in this aspect is more my question?
Please excuse my ignorance, I'm just interested in how this works behind the scenes, and the code in the linked repos is quite dense to figure out what key.cloud() is actually doing.


project

You actually named the branch branch
I asked you to make a data class for the Project not just the activity. That should be in the model directory. Not the Project activity.


Setup Drupal VM not working in Windows 7 64 bit !

hi ! i used vagrant and drupal-vm on Window 7 64 bit , i followed step guide when i input "vagrant up" , this make me waiting too long time , but not download libraries ! This my screenshot http://prntscr.com/9ci7bg

I don't support the hyperv provider; you need to make sure to install VirtualBox separately, so Vagrant can bring up the VirtualBox VM.

I forgot install VirtualBox . Would try install VirtualBox !  thank you so much


handle blinds increasing over time

on game creation, pass in the number of minutes before blinds double?
or do we want to allow for different types of increases? maybe too much effort

the admin can do this manually. not on the road map anymore


file type and numbers of file validation for specific resource type

This issue is related to the netCDF resource which requires the user to upload just one file in ".nc" format. It may need some modifications for the "resource creation page" and the "resource landing page" to implement the file validation function.
This issue may also affect the other resource types such as raster or time series which requires the user to upload data in specific file formats.

Tested.  Behavior seems correct now.


Revert "feat(config): replace osm-config with MeshConfig"

Description:
This reverts commit 98bdecaa31c4036f1c190bf48ed13a70dc2c3b42. PR #3198
CI test failed after auto-rebase to main.

Affected area:

New Functionality      [ ]
Documentation          [ ]
Install                [ ]
Control Plane          [ ]
CLI Tool               [ ]
Certificate Management [ ]
Networking             [ ]
Metrics                [ ]
SMI Policy             [ ]
Security               [ ]
Tests                  [ ]
CI System              [ ]
Demo                   [ ]
Performance            [ ]
Other                  [ ]

Please answer the following questions with yes/no.

Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?

No

Codecov Report

Merging #3274 (159d27a) into main (98bdeca) will increase coverage by 0.49%.
The diff coverage is 82.35%.

:exclamation: Current head 159d27a differs from pull request most recent head df87b02. Consider uploading reports for the commit df87b02 to get more accurate results

@@            Coverage Diff             @@
##             main    #3274      +/-   ##
==========================================
+ Coverage   65.44%   65.94%   +0.49%
==========================================
  Files         165      166       +1
  Lines        7655     7782     +127
==========================================
+ Hits         5010     5132     +122
- Misses       2617     2622       +5
  Partials       28       28

Flag
Coverage Δ

unittests
65.94% <82.35%> (+0.49%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

cmd/cli/install.go
64.28% <ø> (-0.22%)
:arrow_down:

pkg/configurator/mock_client_generated.go
0.00% <0.00%> (ø)

pkg/debugger/policy.go
53.84% <0.00%> (ø)

cmd/osm-controller/osm-controller.go
15.78% <20.00%> (ø)

cmd/cli/trafficpolicy_check.go
50.00% <55.55%> (+4.16%)
:arrow_up:

pkg/configurator/client.go
85.90% <85.90%> (ø)

pkg/configurator/methods.go
96.61% <94.73%> (+3.38%)
:arrow_up:

pkg/configurator/crd_client.go
78.50% <95.45%> (-7.10%)
:arrow_down:

cmd/init-osm-controller/init-osm-controller.go
55.00% <100.00%> (ø)

pkg/catalog/fake.go
72.56% <100.00%> (-0.25%)
:arrow_down:

... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98bdeca...df87b02. Read the comment docs.

Sorry, mistakenly pressed "rebase and merge" on PR, and then test failed on main branch.


Routes controller is not exposing routes on microshift 4.14.1

We are not able to reach the service running on a microshift 4.14.1,  in order to run the test we start a microshift cluster 4.14.1 and then deploy and expose a service:
oc create namespace testproj
oc config set-context --current --namespace=testproj
oc apply -f httpd-example.yaml
oc rollout status deployment httpd-example
oc expose deployment httpd-example --port 8080
oc expose svc httpd-example

All pods on the cluster are running
NAMESPACE                  NAME                                       READY   STATUS    RESTARTS      AGE
kube-system                csi-snapshot-controller-66f566d8d8-hp8sc   1/1     Running   0             30m
kube-system                csi-snapshot-webhook-cdb5df49c-gkl2k       1/1     Running   0             30m
openshift-dns              dns-default-98hzt                          2/2     Running   0             30m
openshift-dns              node-resolver-n5dc4                        1/1     Running   0             30m
openshift-ingress          router-default-5f7d6dbf6c-pbjk5            1/1     Running   0             30m
openshift-ingress          routes-controller-cb9c5f4d9-cgvc2          1/1     Running   0             30m
openshift-ovn-kubernetes   ovnkube-master-g88qn                       4/4     Running   0             30m
openshift-ovn-kubernetes   ovnkube-node-jxxsg                         1/1     Running   0             30m
openshift-service-ca       service-ca-6cd65c4cd9-gpj4r                1/1     Running   0             30m
openshift-storage          topolvm-controller-78d7f57c98-jq9dh        5/5     Running   0             30m
openshift-storage          topolvm-node-tqzdp                         4/4     Running   1 (30m ago)   30m
testproj                   httpd-example-7c9fb5b46d-cn8n8             1/1     Running   0             24m

But the service can not be accessed:
curl http://httpd-example-testproj.apps.crc.testing
curl: (6) Could not resolve host: httpd-example-testproj.apps.crc.testing

And checking the routes controller logs  we can see the route is not handle:
oc get route
NAME            HOST                                      ADMITTED   SERVICE         TLS
httpd-example   httpd-example-testproj.apps.example.com   True       httpd-example

oc logs -f routes-controller-cb9c5f4d9-cgvc2 -n openshift-ingress
W1103 08:51:53.126654       1 client_config.go:617] Neither --kubeconfig nor --master was specified.  Using the inClusterConfig.  This might not work.
time="2023-11-03T08:51:53Z" level=info msg="Added service 'kubernetes' of type 'ClusterIP'"
time="2023-11-03T08:51:53Z" level=info msg="Added service 'csi-snapshot-webhook' of type 'ClusterIP'"
time="2023-11-03T08:51:53Z" level=info msg="Added service 'dns-default' of type 'ClusterIP'"
time="2023-11-03T08:51:53Z" level=info msg="Added service 'router-internal-default' of type 'ClusterIP'"
time="2023-11-03T08:52:01Z" level=info msg="Service 'csi-snapshot-webhook' of type 'ClusterIP' changed!"
time="2023-11-03T08:52:01Z" level=info msg="Service 'dns-default' of type 'ClusterIP' changed!"
time="2023-11-03T08:56:53Z" level=info msg="Service 'kubernetes' of type 'ClusterIP' changed!"
time="2023-11-03T08:56:53Z" level=info msg="Service 'csi-snapshot-webhook' of type 'ClusterIP' changed!"
time="2023-11-03T08:56:53Z" level=info msg="Service 'dns-default' of type 'ClusterIP' changed!"
time="2023-11-03T08:56:53Z" level=info msg="Service 'router-internal-default' of type 'ClusterIP' changed!"
time="2023-11-03T08:58:59Z" level=info msg="Added service 'httpd-example' of type 'ClusterIP'"
time="2023-11-03T08:58:59Z" level=info msg="added: httpd-example httpd-example-testproj.apps.example.com"
time="2023-11-03T09:01:53Z" level=info msg="Service 'kubernetes' of type 'ClusterIP' changed!"
time="2023-11-03T09:01:53Z" level=info msg="Service 'csi-snapshot-webhook' of type 'ClusterIP' changed!"
time="2023-11-03T09:01:53Z" level=info msg="Service 'dns-default' of type 'ClusterIP' changed!"
time="2023-11-03T09:01:53Z" level=info msg="Service 'router-internal-default' of type 'ClusterIP' changed!"
time="2023-11-03T09:01:53Z" level=info msg="Service 'httpd-example' of type 'ClusterIP' changed!"

fixed and bundle is released.


Move spring-cloud-azure-native-configuration to sdk/spring-experimental folder

Since spring-native is still an experimental project and the spring-cloud-azure-native-configuration won't be able to GA until the spring-native is GAed, so this PR will create a separate sdk/spring-experimental folder and further experimental projects will stay in this folder and be promoted to the sdk/spring folder once it gets GAed.

Since spring-native is still an experimental project and the spring-cloud-azure-native-configuration won't be able to GA until the spring-native is GAed, so this PR will create a separate sdk/spring-experimental folder and further experimental projects will stay in this folder and be promoted to the sdk/spring folder once it gets GAed.

Can you explain why we don't use a feature branch here? Adding an extra folder called "experimental" looks ugly really.

Since spring-native is still an experimental project and the spring-cloud-azure-native-configuration won't be able to GA until the spring-native is GAed, so this PR will create a separate sdk/spring-experimental folder and further experimental projects will stay in this folder and be promoted to the sdk/spring folder once it gets GAed.

Can you explain why we don't use a feature branch here? Adding an extra folder called "experimental" looks ugly really.

The SDK repo chooses multi-folders over multiple branches, we are following this guideline.


nixos/tests/wine: fix gecko check and diskSize type

Motivation for this change
This fixes the wine test, which currently fails with the following error:
error: A definition for option `virtualisation.diskSize' is not of type `null or positive integer, meaning >0'. Definition values:
       - In `<unknown-file>': "800"
(use '--show-trace' to show detailed location information)

Things done

Built on platform(s)

[x] x86_64-linux nix build -f ./nixos/tests/wine.nix
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[x] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

I ran the tests again including #153932.
The new test winePackages-wayland succeeds, but wineWowPackages-wayland fails:
machine # wine: created the configuration directory '/root/.wine'
machine # 002c:fixme:actctx:parse_depend_manifests Could not find dependent assembly L"Microsoft.Windows.Common-Controls" (<IP_ADDRESS>)
machine # 0048:fixme:actctx:parse_depend_manifests Could not find dependent assembly L"Microsoft.Windows.Common-Controls" (<IP_ADDRESS>)
machine # 0050:fixme:actctx:parse_depend_manifests Could not find dependent assembly L"Microsoft.Windows.Common-Controls" (<IP_ADDRESS>)
machine # error: XDG_RUNTIME_DIR not set in the environment.
machine # error: XDG_RUNTIME_DIR not set in the environment.
machine # wine: Unhandled page fault on execute access to 00007FDA45A0FA80 at address 00007FDA45A0FA80 (thread 0048), starting debugger...

Details
machine # [    6.361949] systemd[1]: Startup finished in 2.790s (kernel) + 3.570s (userspace) = 6.361s.
(finished: waiting for unit multi-user.target, in 7.00 seconds)
machine: must succeed: bash -c 'wine /nix/store/0wqs6a0ifvdw2qkl2y5cim1s01kalap2-hello-i686-w64-mingw32-2.10/bin/hello.exe 2> >(tee wine-stderr >&2)'
machine # wine: created the configuration directory '/root/.wine'
machine # 002c:fixme:actctx:parse_depend_manifests Could not find dependent assembly L"Microsoft.Windows.Common-Controls" (<IP_ADDRESS>)
machine # 0048:fixme:actctx:parse_depend_manifests Could not find dependent assembly L"Microsoft.Windows.Common-Controls" (<IP_ADDRESS>)
machine # 0050:fixme:actctx:parse_depend_manifests Could not find dependent assembly L"Microsoft.Windows.Common-Controls" (<IP_ADDRESS>)
machine # error: XDG_RUNTIME_DIR not set in the environment.
machine # error: XDG_RUNTIME_DIR not set in the environment.
machine # wine: Unhandled page fault on execute access to 00007FDA45A0FA80 at address 00007FDA45A0FA80 (thread 0048), starting debugger...
machine # 0048:err:seh:start_debugger Couldn't start debugger L"winedbg --auto 68 88" (2)
machine # Read the Wine Developers Guide on how to set up winedbg or another debugger
machine # wine: Unhandled page fault on execute access to 00007F09BAE7BA80 at address 00007F09BAE7BA80 (thread 0050), starting debugger...
machine # 0050:err:seh:start_debugger Couldn't start debugger L"winedbg --auto 76 88" (2)
machine # Read the Wine Developers Guide on how to set up winedbg or another debugger
machine # 0040:err:winediag:nodrv_CreateWindow Application tried to create a window, but no driver could be loaded.
machine # 0040:err:winediag:nodrv_CreateWindow The explorer process failed to start.
machine # 002c:err:winediag:nodrv_CreateWindow Application tried to create a window, but no driver could be loaded.
machine # 002c:err:winediag:nodrv_CreateWindow The explorer process failed to start.
machine # [    7.536116] dbus-daemon[750]: [system] Activating via systemd: service name='org.freedesktop.UDisks2' unit='udisks2.service' requested by ':1.2' (uid=0 pid=898 comm="C:\windows\system32\winedevice.exe                " label="kernel")
machine # [    7.550101] systemd[1]: Starting Disk Manager...
machine # [    7.660975] udisksd[907]: udisks daemon version 2.9.4 starting
machine # [    7.683455] dhcpcd[657]: eth0: Router Advertisement from fe80::2
machine # [    7.683902] dhcpcd[657]: eth0: adding address fec0::5054:ff:fe12:3456/64
machine # [    7.684383] dhcpcd[657]: eth0: adding route to fec0::/64
machine # [    7.684762] dhcpcd[657]: eth0: adding default route via fe80::2
machine # [    7.685520] udisksd[907]: Failed to load config files: Failed to get contents of the config dir (/etc/libblockdev/conf.d/)Error opening directory “/etc/libblockdev/conf.d/”: No such file or directory. Using the built-in config
machine # 0084:err:winediag:nodrv_CreateWindow Application tried to create a window, but no driver could be loaded.
machine # 0084:err:winediag:nodrv_CreateWindow The explorer process failed to start.
machine # [    7.822507] dbus-daemon[750]: [system] Activating via systemd: service name='org.freedesktop.PolicyKit1' unit='polkit.service' requested by ':1.3' (uid=0 pid=907 comm="/nix/store/73xsyv7lvx2jdda77n5fhmch7yyq07rv-udisks" label="kernel")
machine # [    7.838972] systemd[1]: Starting Authorization Manager...
machine # [    7.970099] polkitd[911]: Started polkitd version 0.120
machine # [    8.247999] polkitd[911]: Loading rules from directory /etc/polkit-1/rules.d
machine # [    8.248555] polkitd[911]: Loading rules from directory /run/current-system/sw/share/polkit-1/rules.d
machine # [    8.252401] polkitd[911]: Finished loading, compiling and executing 2 rules
machine # [    8.254494] dbus-daemon[750]: [system] Successfully activated service 'org.freedesktop.PolicyKit1'
machine # [    8.255065] systemd[1]: Started Authorization Manager.
machine # [    8.255913] polkitd[911]: Acquired the name org.freedesktop.PolicyKit1 on the system bus
machine # [    8.385818] dbus-daemon[750]: [system] Successfully activated service 'org.freedesktop.UDisks2'
machine # [    8.388403] systemd[1]: Started Disk Manager.
machine # [    8.389523] udisksd[907]: Acquired the name org.freedesktop.UDisks2 on the system message bus
machine # 0084:err:setupapi:SetupDefaultQueueCallbackW copy error 1812 L"@C:\\windows\\system32\\drivers\\wineusb.sys,-1" -> L"C:\\windows\\inf\\wineusb.inf"
machine # 008c:err:winediag:nodrv_CreateWindow Application tried to create a window, but no driver could be loaded.
machine # 008c:err:winediag:nodrv_CreateWindow The explorer process failed to start.
machine # 00ac:err:winediag:nodrv_CreateWindow Application tried to create a window, but no driver could be loaded.
machine # 00ac:err:winediag:nodrv_CreateWindow The explorer process failed to start.
machine # wine: configuration in L"/root/.wine" has been updated.
(finished: must succeed: bash -c 'wine /nix/store/0wqs6a0ifvdw2qkl2y5cim1s01kalap2-hello-i686-w64-mingw32-2.10/bin/hello.exe 2> >(tee wine-stderr >&2)', in 17.16 seconds)
machine: must succeed: bash -c 'wine /nix/store/i68pcsdkflphlk3smpc0n6i348x58xiq-hello-x86_64-w64-mingw32-2.10/bin/hello.exe 2> >(tee wine-stderr >&2)'
machine # error: XDG_RUNTIME_DIR not set in the environment.
machine # wine: Unhandled page fault on execute access to 00007F48B4ADBA80 at address 00007F48B4ADBA80 (thread 0060), starting debugger...
```</details>

Not sure whether this use of Wayland just still needs fixes in packaging. @jmc-figueira ?

@ofborg test wine

@ofborg build nixosTests.wine

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/783