BUG FIX #538

Description
BUG FIX #538 , made modifications to the links.yml workflow file to address the issue with relative links in the README.md.
Here's a summary of the changes:
Added a new step before the link checking process. This step removes the symbolic link (soft link) of README.md in the docs/source directory. This prevents the link checker from incorrectly resolving relative links due to the presence of this soft copy.
In the arguments section of the lychee Link Checker, I've added an exclusion for the file reference to the docs/source/README.md. This exclusion is necessary because even though we've removed the soft link, other parts of the project or external references might still point to this location. By excluding it from the link check, we ensure that the checker doesn't attempt to validate any links that might reference this now-nonexistent soft link. This prevents potential false positives or errors that could arise from references to the removed soft link.
After the link checking is complete, I've added another step to recreate the soft link. This ensures that the repository structure remains intact and doesn't affect other workflows that might depend on the presence of this soft link.
Issues Resolved
Link checker will not fail for adding relative links in readme.md
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

I think we both misunderstood how Lychee works. The .lycheeignore file is for files and URLs found and checked, it's not to exclude files from being checked. So first it reads docs/source/README.md, then it checks URLs in that file and fails because they are incorrect. To exclude a file or a path, you have to use --exclude-path.  Here's the fix: https://github.com/Krish-2505/opensearch-py/pull/4.
However this would create a new problem. We deploy these docs to https://opensearch-project.github.io/opensearch-py/ and the links would then be broken on that site. So we would need to symlink the rest of markdown files. I tried that and ran into more problems trying to generate docs with nox -rs docs.
I propose we just get rid of the symlink and remove README.md from docs/source/index.md, then add the relevant content from README.md to it. Want to do that instead?

ok, then I will remove readme from docs/source. Afterwards, if you could suggest what types of relevant content to add to docs/source, I'll  implement those additions.

The deploy docs job failed above, see https://github.com/opensearch-project/opensearch-py/actions/runs/9545324707/job/26305843780?pr=760. There's a link to this README that needs to be removed.

Afterwards, if you could suggest what types of relevant content to add to docs/source, I'll implement those additions.

You should do this as part of this PR. There was a lot of stuff in the README, pick a minimal set of things that you think will be useful.


Questions about info returned from pqos

Hi,
pqos -sv on my platform returns:
INFO: L3 CAT details: CDP support=1, CDP on=0, #COS=16, #ways=20, ways contention bit-mask 0xc0000

What is the "ways contention bit-mask"?

Does #ways=20 refer to the L3 associativity ways, or the subsets to which L3 can be partitioned? The Intel System Programming Guide states (17.18.2):

Though the representation of CBMs looks similar to a way-based mapping they are independent
of any enforcement implementation (e.g. way partitioning)

I understand that, on my platform, cache partitioning is performed on a way-basis, but this might be
different in future implementations.

Hi, thanks for reaching out to us. Please find answers below.

LLC access mask used by other agents (not CPU cores) in the processor package. In case of intel(R) Xeon(R) Processor that you have it can be DDIO for example.

The line quoted above displays cache information retrieved from cpuid. 'ways' here refers to associativity ways.
As to CBM and cache ways, today most processors implement 1-to-1 mapping between CBM bit and cache way (1 CBM bit = 1 way). You are correct in your thinking that other mappings can be applied in the future, example 1 CBM bit = 2 ways.

Thanks for your reply.
So, regarding the "ways contention bit-mask", I understand that when assigning a cache partition for dedicated use by an application, I should choose from all the LLC subsets apart from those corresponding to the "ways contention bit-mask". That is, 0xfffff - 0xc0000 = 0x3ffff.
Is this correct?

That makes sense. Thanks a lot for the clarification!

Let me close this issue. Feel free to create a new one if you have further questions.


npm audit: 26 vulnerabilities

The latest version of "he" contains some vulnerabilities according to "npm audit":
26 vulnerabilities (8 moderate, 9 high, 9 critical)
I'm not using this package directly but instead it is being referenced through mocha (and I'm using mocha). But I'm just seeing if this project is active enough that perhaps these vulnerabilities will be addressed at some point. I'm certainly no expert with this but it appears that the vulnerabilities are related to packages that need upgrading to newer versions.
I think just having newer packages that update the lodash version will satisfy my vulnerability scanner.

Just as a little note for those that are worried about the above:
When you use this package as a dependency in your project, it won't install the devDependencies in the package.json. As this project doesn't have any regular, non-dev dependencies, there are no vulnerable packages to install in regular use.
You can try this for yourself by running npm install --production and you'll see found 0 vulnerabilities, likewise with npm audit --production. It's a little unfortunate that npm audit checks devDependencies by default.

I think it's a good thing that npm audit checks the devDependencies, too, but it would be smart to mention it in the output. Something like found 0 vulnerabilities for production, 26 vulnerabilities (8 moderate, 9 high, 9 critical) for development would be the best of both worlds.

Although the 26 vulnerabilities for development will only happen if you're a developer of this library itself, which is probably not the case.


Custom transition for stack navigation has stopped working on iPhone X

Current Behavior
I have applied custom transition using stack navigators transition property. It works well on all other versions of iPhone except iPhone X. Please note that I tested it on the simulator.
Expected Behavior
Transitions should work seamlessly on iPhone X.
I am sure support for iPhone X would be in progress and I thought this might help.
Your Environment

software
version

react-navigation
1.0.0-beta.13

react-native
0.47.1

node
8.6.0

yarn
1.1.0

How can we test this? Please supply a reproduction app or, at the least, steps to reproduce this.

Unfortunately, I can't provide you the app but I'll provide you code snippets and GIF of the problem. I'll do it today.

Hey, it was an iPhone cache issue. The transitions are working fine. Apologies for the inconvenience.


fix touch reenabling bug #28

please review, not sure if this breaks something else

I tested this fix locally and this indeed fixed the issue on touch devices, that once sleep was disabled and enabled again, you could not disable it again.
Any reason we can't merge this PR? Is it breaking something else?


feat: Enable jsonencode support for replication config

Description
Enable jsonencode support for replication config
Motivation and Context
locals {
  replication_config = jsonencode({
    role = var.role_arn
    rules = [
      {
        id       = "sync to staging"
        status   = true
        priority = 0

        delete_marker_replication = true

        destination = {
          bucket     = "arn:aws:s3:::test2"
          account_id = "xxxxxx"
          access_control_translation = {
            owner = "Destination"
          }
        }
      },
    ]
  })
}

module "bucket" {
  source                  = "terraform-aws-modules/s3-bucket/aws"
  version                 = "3.6.x"
  bucket                  = "test"
  replication_configuration = var.env == "prod" ? local.replication_config : "{}"
}

Breaking Changes
No.
How Has This Been Tested?

[x] I have updated at least one of the examples/* to demonstrate and validate my change(s)
[x] I have tested and validated these changes using one or more of the provided examples/* projects

[x] I have executed pre-commit run -a on my pull request

Any suggestions on my PR?

Please make sure that the example in examples/s3-replication works. Now it doesn't because of this error:
╷
│ Error: Invalid count argument
│
│   on ../../main.tf line 342, in resource "aws_s3_bucket_replication_configuration" "this":
│  342:   count = local.create_bucket && length(keys(local.replication_configuration)) > 0 ? 1 : 0
│
│ The "count" value depends on resource attributes that cannot be determined until
│ apply, so Terraform cannot predict how many instances will be created. To work
│ around this, use the -target argument to first apply only the resources that the
│ count depends on.


(APS-535) Investigate Flipt for feature flags

This adds an ADR / config for the use of Flipt for easy use of feature flags. This is already used by the integrations team in production, and all the necessary infrastructure is in place.
Assuming we decide to go with this, I have another PR waiting in the wings as a proof of concept.

I've used a similar FS solution in the past and it was really useful so I think it would be good to use one here.
How do you plan that we host Flipt (assuming we're not using the managed version)? could you link me to where the integration team have it setup?


By default, preserve setup.cfg, mypy.ini, and pyproject.toml files

closes #232
Last PR for the day :rofl: Once this batch is done I think we can release 0.2.0

Massive thanks for your reviews! Have merged master, merging now following Girish's approval


Introduce a centralized Gradle configurations for standard libraries

Recently, we came across several configuration changes to the Gradle files that we configured initially to the stdlibs. Change 30+ configuration files is cumbersome and time-consuming work.
To solve this, we can introduce a centralized Gradle configuration file(Or perhaps multiple config files). In this centralized config file, we can add the common configurations such as:

native build
Ballerina test, build, and push phases
unpack jBallerina and stdlib dependencies etc.

Since Gradle support importing other Gradle scripts via HTTP URLs, this will be a straightforward implementation. For more details:

https://stackoverflow.com/questions/2566685/is-there-a-way-to-split-factor-out-common-parts-of-gradle-build
https://docs.gradle.org/current/userguide/userguide_single.html#sec:configuring_using_external_script

I think we can close this now. @BuddhiWathsala

Closing this since the Gradle plugin provides these functionalities.


feat client sdk -Add publication module

there are two possible methods missing from this PR, could you also update TODO file? please keep "method descriptor" ([PQ]) as it will help us later when adding pagination or execute helpers.
- [Q] client.publication.fetch(request)
- [PQ] client.publication.fetchAll(request)
- [Q] client.publication.validateMetadata(request)
- [PQ] client.publication.whoCollected({ publicationId })

- [PQ] client.publication.allForSale({ profileId })
- [Q] client.publication.metadataStatus(request)


Move visualization.

Codecov Report

Merging #15 into master will increase coverage by 1.81%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master      #15      +/-   ##
==========================================
+ Coverage   60.23%   62.04%   +1.81%
==========================================
  Files          51       50       -1
  Lines        2804     2569     -235
==========================================
- Hits         1689     1594      -95
+ Misses       1115      975     -140

Impacted Files
Coverage Δ

src/ConstrainedDynamics.jl
100.00% <ø> (ø)

src/util/util.jl
72.00% <0.00%> (-8.00%)
:arrow_down:

src/util/quaternion.jl
55.00% <100.00%> (-0.74%)
:arrow_down:

src/joints/joint.jl
41.66% <0.00%> (-33.34%)
:arrow_down:

src/joints/rotational0.jl
8.00% <0.00%> (-14.59%)
:arrow_down:

src/bounds/bound.jl
12.50% <0.00%> (-12.50%)
:arrow_down:

src/joints/translational0.jl
0.00% <0.00%> (-12.50%)
:arrow_down:

src/joints/rotational3.jl
72.00% <0.00%> (-4.00%)
:arrow_down:

src/joints/translational3.jl
88.00% <0.00%> (-4.00%)
:arrow_down:

... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a07b2b0...ef5a355. Read the comment docs.


Made main icon smaller to fit in the plugins details page

Just a small change to make the plugins page readable

Where does it show up poorly? It's small for me:

But happy to merge and see.

@cholmes this is how it looks on my Linux machine. Other plugins look fine.

Whoa.
Just cut 0.3.3 release with this in, so hopefully it’s better.
Thanks!
On Thu, Dec 19, 2024 at 6:52 AM Matt Travis @.***>
wrote:

@cholmes https://github.com/cholmes this is how it looks on my Linux
machine. Other plugins look fine.
image.png (view on web)
https://github.com/user-attachments/assets/a8975af8-cee1-43e9-8e69-82424ccecf83
image.png (view on web)
https://github.com/user-attachments/assets/5d9320bb-b38d-4469-a203-845cf8ddacf5
—
Reply to this email directly, view it on GitHub
https://github.com/cholmes/qgis_plugin_gpq_downloader/pull/45#issuecomment-2554428604,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AADDL2INXFGH2KFUGQMQ23L2GLMTPAVCNFSM6AAAAABTUWCK3OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNJUGQZDQNRQGQ
.
You are receiving this because you were mentioned.Message ID:
@.***>


I moved the comment that I made to describe the order of events here.


Energy Dashboard - Register Battery

At first, many thanks for building this integration. The registration of new devices worked like a charm.
When using the River Max as UPS or mainly as pass-through battery, the following configuration is incorrect:
total input energy : Home Battery Storage -> Energy going in to the battery
total output energy : Home Battery Storage -> Energy coming out of the battery
It would add the input and output (that is equal if the battery is fully loaded) to the Energy Dashboard as Battery Charge (IN) and Battery Usage (OUT). But it does not touched the battery at all.
Request to get besides the totals two dedicated sensors for the battery:
Battery input energy = Only in Charge Mode -> Input minus Output (this is what actually flows into the battery)
Battery output energy = Only in Battery Mode (Input OFF/0) -> Output (this is what actually flows out of the battery)

This problem has been resolved in Ver.3. Please wait until release.
If you want to try now, please install pre-release version.
Note: Once you upgrade, you can't downgrade because it is not compatible with Ver.2.


[SafeSnap] Display transaction hashes

Description

Display the full transaction hash on top of the transaction batches
Display each transaction batch hash
Display the transaction of each batch as a JSON compatible with Safe Tasks

Screenshot

@samuveth

@carlosfebres looks great! I'm unsure what the Complete Transaction Hash is and why does it disappear when I add another transaction to the batch?

I'm also a bit confused. I wasn't able to find any of the hashes on etherscan after the transactions were broadcasted and confirmed.

https://rinkeby.etherscan.io/tx/0x7cc6d41d72e9f290afed52fa27474a15454a5e5232a9dfc0690129370b368477
https://rinkeby.etherscan.io/tx/0x1889deebab0c37a80fda8a7044952d3f7dfdf153d707a983d24c16ae76991176
Code-wise there seems to be a lot more going on than just displaying stuff. I'm trying to review these lines now.
@carlosfebres some comments in the code would be helpful.
Side-note: We should use the <script setup> format everywhere, at least for newly added components.

Fill the form then it comes back. It's only displayed when all input is valid.

Oh I see.

Side-note: We should use the <script setup> format everywhere, at least for newly added components.

For existing plugins we agreed that it's alright to continue with options API.

Hmmmmmmmmmmmmmm......... ok. :D

Code-wise there seems to be a lot more going on than just displaying stuff. I'm trying to review these lines now.
@carlosfebres some comments in the code would be helpful.

Hi @mktcode, we need to store the hashes in the proposal data stored in IPFS, The batches of transactions were stored as a bi-dimensional array, I made a refactor to store batches as object and support old proposals.

@carlosfebres looks great! I'm unsure what the Complete Transaction Hash is and why does it disappear when I add another transaction to the batch?

As @mktcode said, the Complete Transaction Hash is only displayed if all transactions are valid.
@samuveth sorry if that's not intuitive, how can we improve it?

First thought: Always show "something".
All valid: show hash
Otherwise: show "form partially filled, complete form to see hash"
You know what I mean? You could even put a gigantic red box above everythign saying "hey... this form will behave weird unless you fill all the fields" That's maybe ugly but clear to the user. Not saying it should be like that but you get the idea?

It just says: "The hash is the keccak of the concatenation of the individual EIP-712 hashes..."
Maybe the individual hashes should be posted there too.
I was also a bit confused at first (had to delete a long pointless comment the other day :D) of what "Complete Transaction Hash" actually refers to in this scenario. It might just be me and I got it by now, but first I thought this is about the hash of the actual transaction the safe executes. I understand now, it's the hashed information about the transactions to be executed, stored in the zodiac module. Maybe we can find some more clear wording for this. "Verification Hash"... "Execution Data Hash"... idk. If you're all fine with it as it is, just ignore me. :D

@mktcode that's all right, showing the hash for each transaction in a batch is not necessary since each batch is executed using a MultiCall contract, and the hash of the MultiCall transaction is the one shown.
Thanks for taking a time to go through the whole flow.

@mktcode @bonustrack if it's all fine, can we merge it?

Well....
https://bafybeiembm4wteag3g2wzeftimy5xl5pdjhwj5pofhlehntwgmt5bt577e.on.fleek.co/#/fabien.eth/proposal/QmV2TVKZmgXHuzT36ockuJ3hwCY31weotgirYTsA18SBDB
I'll leave it as approved because it does not seem to be related to the changes in this pr. Same here:
https://snapshot.org/#/fabien.eth/proposal/QmV2TVKZmgXHuzT36ockuJ3hwCY31weotgirYTsA18SBDB


bundler error

Hi,
I am running ruby 1.9.2 with rake 0.9.2 installed globally and a project with a Gemfile specifying rake 0.8.7, when I run:
$ bundle exec rake -T

I get:
/Users/schmurfy/.rbenv/versions/1.9.2-p290/lib/ruby/gems/1.9.1/gems/bundler-1.0.18/lib/bundler/rubygems_integration.rb:218:in `block in replace_bin_path': can't find executable rake (Gem::Exception)
	from /Users/schmurfy/.rbenv/versions/1.9.2-p290/lib/ruby/gems/1.9.1/bin/rake:19:in `<main>'

it seems  to work however in a project using rake 0.9.2
The problem may be on bundler side but I have seriously no idea.

A better fix for this is:
gem pristine rake

any idea what could have caused this error in the first place ?

No idea. sorry. Feels like a bug in bundler or rubygems

for me it was broken when I switched from rvm to rbenv, since I fixed it everything is fine.

Thanks @chriseppstein gem pristine rake fixed it.

+1 gem pristine rake

+1 ^

+1 gem pristine rake

In my case I had a local .bundle/config that shouldn't have been there...

In my case when i run rspec i got the above error so i find a solution to run it in this way:-
bundle exec rspec


chart-repo-sync: concurrently process charts

Implements a worker pool (hardcoded to 10 workers) to download and process chart icons and tarballs concurrently.
Also changed to process the latest chart tarball of each chart first before going on to process historical chart versions.

Codecov Report

Merging #411 into master will decrease coverage by 1.19%.
The diff coverage is 21.05%.

@@            Coverage Diff            @@
##           master     #411     +/-   ##
=========================================
- Coverage   84.47%   83.27%   -1.2%
=========================================
  Files          26       26
  Lines        1462     1483     +21
=========================================
  Hits         1235     1235
- Misses        176      197     +21
  Partials       51       51

Impacted Files
Coverage Δ

src/api/cmd/chart-repo-sync/sync.go
60.1% <21.05%> (-7.14%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27e3a9e...5c6f228. Read the comment docs.

wrt to the coverage report. If time permits it would be good if we keep it green :)

@migmartri r.e. coverage, it's difficult, I've tried to separate a lot of stuff into separate testable functions, it's the main functions that call these that aren't tested. It would be difficult to fully test syncRepo due to the concurrency, for example.

Merging for now, we can look into this again later


Tab component router integration - active link

Hi,
I am not really sure whether this is actually a bug or it works as expected. But in case it works as per the component expectation correct maybe you can help me to get around it anyway. The issue I am experiencing is about the selected tab (the selected tab which should be shown underlined).
I am using the mdc-tab-bar component and the "to" attribute to work with vue router. If I have a single page and navigate on that page the selected tab always is the correct one. But if I do a full reload of the page (or in other words: if I navigate to that page with a direct link) then always the first tab is the selected one. I would expect the one which is identified as active as per the router-to attribute to be the active one.
I created a sample for this: https://codepen.io/anon/pen/Brmabr - if you click on "Go to bar" you can see that there is a inconsistency between the active router and the selected tab.
I tried to fix this in my component with something like:
          this.$refs.tabs.tabs.forEach((t) => {
            if (t.$el.classList.contains("router-link-active")) {
              var index = this.$refs.tabs.tabs.indexOf(t);
              this.$refs.tabs.foundation.switchToTabAtIndex(index, true);
            }
          });

But this does not seem to work in all cases. If the component is reused due to a navigation I am not able to use that method, it works though for direct links.
Can you please let me know whether you think this is a bug in vue-mdc-adapter? Or whether you at least understand my problem?
Thank you for your help!
What vue-mdc-adapter Version are you using?
0.10.0
What browser(s) is this bug affecting?
Chrome 65.0.3325.181 (but I think it is not depending on browser)
What OS are you using?
Windows 7
What are the steps to reproduce the bug?

Open https://codepen.io/anon/pen/Brmabr
Click on "Go to Bar"
See that the active tab (underlined one) still is "Foo" while the active router link is "Bar" (green one)

What is the expected behavior?
Active tab should be Bar (mdc-tab component should respect navigation).

So I have a had a similar problem (I am not using the router-link or to= functionality in my application, but encounter the same kind of need to set the active tab according to the current route.
My slightly hacky solution was to add a watcher on the current route's name, and when it changes call a method to update the active tab (quite similar to your suggestion above, but by using the route name it is after the route navigation has completed).
I have put an example in https://codepen.io/anon/pen/OvOMxB.
Basically:
add
  watch: {
    '$route.name'(nv) {
      this.setTab();
    },
  },
  methods:{
    setTab(){
      const tabbar = this.$refs.tabbar;
      if (tabbar) {
        const index = tabbar.foundation.getActiveTabIndex();
        if (index !== _tabs[this.$route.name]) {
          tabbar.foundation.switchToTabAtIndex(_tabs[this.$route.name], false);
        }
      }
    }
  }

and modify the routes to have names and a simple map for name to index.
const _tabs = {
  foo: 0,
  bar: 1,
};
const routes = [
  { path: '/foo', name:'foo', component: Foo },
  { path: '/bar', name: 'bar', component: Bar }
]

This appears to give the behaviour you are after I think.

Note: the tab-bar cannot have a selected index outside of the range of tabs so I am not sure if it is possible to have no tab selected.

Hope that helps.

Hi pgbross,
thank you for the immediate response! Yea, that basically helped. I was able to adapt your suggestion to my project and it works fine in all situations I tested.
As you say this feels more like a hack or workaround than a good solution. Do you think it is possible / intended to support this within the tab component itself? For me it feels that the behaviour of the tab component is unexpected.
Thanks!

@albert0815
Glad that helped.
The material-components-web goal is to provide good design for the web based on material design principles and, at least initially, vue-mdc-adapter is integrating that with Vue Using Foundations and Adapters.
To integrate further with third party libraries such as vue-router, vuex etc needs to be carefully considered. For example integrating with the specifics of how vue-router is implemented ties you to that library (I do not know if anyone actually ever uses a different router). If one did integrate such behaviour it may not be what every user of tab-bar wants so how do you override it - ie the library providing access to the Material Design UI is becoming bound with some higher level behaviour. Also as I mentioned in my comment, I happen not to use router-link or to= attributes but have the same requirement so how do you capture the behaviour without the library becoming too opinionated (ie. requiring using the to= to get some behaviour).
I am only commenting as one point of view to illustrate some of the things that need considering.


Pyside error?

Hi, when I run roslaunch envsim visionenv_sim.launch render:=True, it has successfully opened rviz, unity,.. but still got one or two error.

pyside error: ImportError: cannot import name 'libqt_gui_cpp_shiboken'
error in Yaml file

[](url

)
Do  you know what the problem? thanks

For the issue with the yaml file check the variable FLIGHTMARE_PATH.

@ouafi98 I have source it in bashrc,for the 1) errror, when I run the launch_evaluation.bash, it can open like this, but the GUI for controling the drone is not working:

hi

did you resolve the YAML error?
which python version are you using? it seems there is a problem with the python GUI. when you click connect on the GUI, does it work?

@yun-long i havent solved the yaml file error.
I use python3.6, the gui does not have any connect button, it only has off red button like the above image?

can you check what is the output when you do
echo $FLIGHTMARE_PATH  // the output should be  /something/src/agile_flight/flightmare

can you try to config your python executable to the python3
cd <your catkin work space> catkin config -DPYTHON_EXECUTABLE=/usr/bin/python3

@yun-long the gui does not have any connect button, it only has off red button like the above image?

Did you try the 'Connect' button above the red square?

@gorghino yes I tried but nothing happened

@yun-long yes I sourced exactly the my FLIGHTMARE_PATH.
I set up my workspace to work with python3 as well

When I click on the GUI the cmd output like this:

maybe try to upgrade your python to at least 3.7
I have 3.8 it works just fine for me.


minor: update MSRV 1.73

Which issue does this PR close?

Closes #.
Rationale for this change
As per https://github.com/apache/arrow-datafusion?tab=readme-ov-file#rust-version-compatibility-policy its time to bump MSRV to 1.73
Latest stable rustc is 1.77

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

Thanks @Jefffrey for the review


Add review feature and tests

The changes made:

Added an option to add a review to a specific course

Displaying all reviews by specific course

Added an option to edit and delete a review only if it is the user who wrote the review

Add tests for the review view

Add fixtures to the conftest

Resolved #90
comments:
The feature is currently not connected to the course page.
This PR can be merged without the course page for the usage of the feature and later in order for it to appear through the course I will make the necessary adjustments after the course page after will be merged.
In addition, I added fixtures that are in test_for_review_course.py, changes will be made for the test_for_review_course in a separate PR(Not relevant for the feature review)
Create review

Show reviews by course

Overall LGTM,  left you some comments

Overall LGTM, left you some comments
I don't see the comments in the PR.

Overall LGTM, left you some comments
I don't see the comments in the PR.

@galitf

trying to resend comments

Resolved conflicts

LGTM

Please resolve conflicts

Please resolve conflicts

Resolved

Please squash commits

Please squash commits

Done


hangs after login

I'm trying the AngularJS example (from download, not Github).
After social login, I get redirected back to
http://localhost:3000/callback#access_token=<redacted>&expires_in=7200&token_type=Bearer&state=<redacted>
and just see a spinning wheel.
Every login adds another cookie as well, e.g. here after 3 login attempts:

No errors in the console.
Chrome Version 72.0.3626.121 (Official Build) (64-bit)
MacOS Mojave 10.14.3 (18D109)
Am I doing something wrong?
(It worked once before, and I made no changes to the code.)

Seems I am affected by https://github.com/auth0/auth0.js/issues/897

Side note: This might be related to ui-router. If I comment the line $locationProvider.html5Mode(true); and configure my callback to be http://localhost:3000/#/callback then I see the navbar, but as the sample stands it shows only the spinning wheel and no navbar.


HTTP API to check if a clientId is online

When I Push message to APNS，I want to know the user online or offline，if the user online ，i did't push message to APNS

whenever the client is online, to give a retain message to a topic, for example /clientid/state.  if you want to check if the user is online or offline, subscribe to this topic and it will return the according state of that client.

+1. Really critical. Since now Google have doze and apple's APNS it is super critical. Consistent ping drains away battery. 3:30 min is the ping interval we are using since it is getting disconnected to a bigger number. The battery it is consuming is around 10% which is really huge.
This  is important and drafted as a GSOC project for ejabberd, an xmpp server. - https://blog.process-one.net/my-gsoc-2015-project-push-for-xmpp/ .
I don't want to make changes in core so thinking of some design using hooks - like message received.

For anyone interested I have made a fix for GCM - https://github.com/bangarharshit/emqttd/commit/d2ad3320e9d66cc98e316abd7cc2346a116ff300 . Not the best fix, but along with queueing I am also publishing on a topic offline with payload=clientId. One of my java server is always subscribed to it and it is offloading all the heavy work like registration id look-up. May be on_client_offline hook -https://verne.mq/docs/plugin_development.html#on-client-offline is a better solution.


Reduce height of buttons within info bar and adjust margins and padding

This project uses semver, please check the scope of this pr:

[ ] #none# - documentation fixes and/or test additions
[x] #patch# - backwards-compatible bug fix
[ ] #minor# - adding functionality in a backwards-compatible manner
[ ] #major# - incompatible API change

CHANGELOG

Reduced the height of buttons within an info bar from 75px to 60px
Added a right margin of 5px to buttons within an info bar to give them space from their right boundary
Added a 5px padding to the left and right sides of the info bar buttons so that the text of the buttons is not pushed right up against the boundary of the button
Removed padding on the text within the info bar
Reduced the bottom margin on the SVG elements in buttons within an info bar from 10px to 5px

:+1:


Add button to create new Document tab

This button can be disable by property and react to OnCreate method, example.
Example as in browser:

@wieslawsoltes Can I implement this task in your project?

@wieslawsoltes Can I implement this task in your project?

Go ahead, PRs are welcome.

Implemented in vNext branch.


Misleading AttributeError: '_queue.SimpleQueue' object has no attribute 'queue' when compiler fails

There is completely misleading error message when underlying command fails. This is easiest to reproduce by adding invalid commandline switch to gcc profile (eg. open mbed-os/tools/profiles/develop.json and add "-invalid-flag" to "common" array) and then building project with GCC.
The example output without verbose flag is:
$ mbed compile
Building project mbed-os-example-blinky (DISCO_F746NG, GCC_ARM)
Scan: mbed-os-example-blinky
Compile [  0.5%]: mbed_tz_context.c
[ERROR] '_queue.SimpleQueue' object has no attribute 'queue'
[mbed] WARNING: If you're using Python 3 with Mbed OS 5.8 and earlier versions, Python errors will occur when compiling, testing and exporting
---
[mbed] ERROR: "c:\python37\python.exe" returned error.
Code: 1
Path: "C:\work\mbed\mbed-os-example-blinky"
Command: "c:\python37\python.exe -u C:\work\mbed\mbed-os-example-blinky\mbed-os\tools\make.py -t GCC_ARM -m DISCO_F746NG --source . --build .\BUILD\DISCO_F746NG\GCC_ARM"
Tip: You could retry the last command with "-v" flag for verbose output
---
[mbed] WARNING: Using Python 3 with Mbed OS 5.8 and earlier can cause errors with compiling, testing and exporting
---
[mbed] Working path "C:\work\mbed\mbed-os-example-blinky" (program)
--

This misleading error message is made clear by using mbed compile -v
[DEBUG] Output: arm-none-eabi-g++: error: unrecognized command line option '-invalid-flag'; did you mean '-Winvalid-pch'?
Traceback (most recent call last):
File "C:\work\mbed\mbed-os-example-blinky\mbed-os\tools\toolchains\mbed_toolchain.py", line 523, in compile_queue
res['command']
File "C:\work\mbed\mbed-os-example-blinky\mbed-os\tools\toolchains\mbed_toolchain.py", line 650, in compile_output
raise ToolException(stderr)
tools.utils.ToolException: arm-none-eabi-g++: error: unrecognized command line option '-invalid-flag'; did you mean '-Winvalid-pch'?
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "C:\work\mbed\mbed-os-example-blinky\mbed-os\tools\make.py", line 76, in wrapped_build_project
src_dir, build_dir, mcu, *args, **kwargs
File "C:\work\mbed\mbed-os-example-blinky\mbed-os\tools\build_api.py", line 596, in build_project
objects = toolchain.compile_sources(resources, sorted(resources.get_file_paths(FileType.INC_DIR)))
File "C:\work\mbed\mbed-os-example-blinky\mbed-os\tools\toolchains\mbed_toolchain.py", line 459, in compile_sources
return self.compile_queue(queue, objects)
File "C:\work\mbed\mbed-os-example-blinky\mbed-os\tools\toolchains\mbed_toolchain.py", line 527, in compile_queue
if p._taskqueue.queue:
AttributeError: '_queue.SimpleQueue' object has no attribute 'queue'

Internal Jira reference: https://jira.arm.com/browse/MBOCUSTRIA-1479

We had similar issue when there was definition duplicate. Had us confused for a while to realize what broke it. I don't understand why queue attribute failed though. Looks like tools bug.

@desowin Have you figure this out? I am now getting the same error locally for blinky baremetal
mbed-os-example-blinky-baremetal (master -> origin)
mbed compile -m NRF52840_DK -t ARM

Same for py2 and py3. It's just this target that is failing.

cc @ARMmbed/mbed-os-tools

@desowin Have you figure this out?

I am not sure what you mean. I didn't work on fixing this issue. I am not planning on fixing it either.
I have observed the AttributeError in my project (it happened rarely) and then identified how to reproduce the problem. The (in my opinion simplest) way to reproduce the problem is in the issue description.

I think it happens when you run mbed-cli using Python 3 instead of Python 2.7

It is not just for this target. I get the same issue for quite a few targets: And the error is a Python error due to this line: https://github.com/ARMmbed/mbed-os/blob/f06145db13c38f54d9d33b36c8e8859ddd912d9e/tools/toolchains/mbed_toolchain.py#L559

Thank you for the clear explanation, and for providing steps to reproduce this issue. I have tried this on both python2 and python 3; this appears to be a python-3 incompatibility. The codebase is still not completely python-3 compatible I'm afraid. For the moment the workaround is to use a virtual environment with python 2(.7).

Actually it looks like this has been resolved in the next version of mbed-os (5.14.0) which is in release testing now.

Happens in current master:
Compile [  0.1%]: mbed_tz_context.c
'_queue.SimpleQueue' object has no attribute 'queue'
Failed to build library
Memory map breakdown for built projects (values in Bytes):
| name | target | toolchain | static_ram | total_flash |
|------|--------|-----------|------------|-------------|
Traceback (most recent call last):
  File "/Users/septak01/src/mbed-os/tools/test.py", line 325, in main
    status = print_report_exporter.report(build_report)
  File "/Users/septak01/src/mbed-os/tools/test_exporters.py", line 92, in report
    return self.exporter_print(test_summary_ext, print_log_for_failures=print_log_for_failures)
  File "/Users/septak01/src/mbed-os/tools/test_exporters.py", line 345, in exporter_print
    raise Exception("'test_run' did not have a 'result' value")
Exception: 'test_run' did not have a 'result' value
[ERROR] 'test_run' did not have a 'result' value
[mbed] ERROR: "/Users/septak01/.virtualenvs/mbed/bin/python3.7" returned error.
       Code: 1
       Path: "/Users/septak01/src/mbed-os"
       Command: "/Users/septak01/.virtualenvs/mbed/bin/python3.7 -u /Users/septak01/src/mbed-os/tools/test.py -D MBED_TEST_MODE -t GCC_ARM -m K64F --source . --build ./BUILD/tests/K64F/GCC_ARM --test-spec ./BUILD/tests/K64F/GCC_ARM/test_spec.json --build-data ./BUILD/tests/K64F/GCC_ARM/build_data.json -n tests-netsocket* --greentea"
       Tip: You could retry the last command with "-v" flag for verbose output
---

How to resolve this?

Ah.. the problem was that I have ccache setup, but the compiler was not in the PATH.
Well, that is an easy way to replicate this issue.


chore(milestones): Close rc2 milestone

i actually opened up #24 if you're up for LGTMing that one :)

Closing in favor of #24.


Remove QuartzEventScheduler hard dependency on XStream #1685

Provide the ability to construct an instance of the QuartzEventScheduler using the QuartzEventScheduler.Builder without the immediate construction of the EventJobDataBinder on initialisation of the builder.
Delay the defaulting of the EventJobDataBinder to the construction of the QuartzEventScheduler in the single constructor protected QuartzEventScheduler(Builder builder). Delaying the default allows a user to specify an alternative EventJobDataBinder using the builder. If an alternative is set, the default is no longer applied.
The default DirectEventJobDataBinder() references XStream. By specifying an alternative EventJobDataBinder, a user can bypass the XStream hard dependency.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

As a side note, with reference to the supplier of the Serializers in the AxonServerEventStore, I have seen the same pattern in the Serializer in RestCapabilityDiscoveryMode. I'm having some trouble removing the XStream dependency entirely from our codebase due to the RestCapabilityDiscoveryMode class init. The XStreamSerializer is referenced directly, not through a creator method like with the DirectEventJobDataBinder in this PR. The class loader is still trying to load com.thoughtworks.xstream.converters.Converter, I have yet to figure out why.

As a side note, with reference to the supplier of the Serializers in the AxonServerEventStore, I have seen the same pattern in the Serializer in RestCapabilityDiscoveryMode. I'm having some trouble removing the XStream dependency entirely from our codebase due to the RestCapabilityDiscoveryMode class init. The XStreamSerializer is referenced directly, not through a creator method like with the DirectEventJobDataBinder in this PR. The class loader is still trying to load com.thoughtworks.xstream.converters.Converter, I have yet to figure out why.

As a side note, with reference to the supplier of the Serializers in the AxonServerEventStore, I have seen the same pattern in the Serializer in RestCapabilityDiscoveryMode. I'm having some trouble removing the XStream dependency entirely from our codebase due to the RestCapabilityDiscoveryMode class init. The XStreamSerializer is referenced directly, not through a creator method like with the DirectEventJobDataBinder in this PR. The class loader is still trying to load com.thoughtworks.xstream.converters.Converter, I have yet to figure out why.

That's good to know @dean-eastwood.
As it stands, I think there sadly is sufficient other work we need to deal with prior to making the removal of the undesired inclusion of XStream a priority.
If you spot a solution for this, ergo spot the culprit in any of Axon's products, we would very much welcome a pull request to resolve the matter.

As a side note, with reference to the supplier of the Serializers in the AxonServerEventStore, I have seen the same pattern in the Serializer in RestCapabilityDiscoveryMode. I'm having some trouble removing the XStream dependency entirely from our codebase due to the RestCapabilityDiscoveryMode class init. The XStreamSerializer is referenced directly, not through a creator method like with the DirectEventJobDataBinder in this PR. The class loader is still trying to load com.thoughtworks.xstream.converters.Converter, I have yet to figure out why.

That's good to know @dean-eastwood.
As it stands, I think there sadly is sufficient other work we need to deal with prior to making the removal of the undesired inclusion of XStream a priority.
If you spot a solution for this, ergo spot the culprit in any of Axon's products, we would very much welcome a pull request to resolve the matter.

Ignoring the Java11 built, as there's a GHA secret set-up thing we need to deal with.

Ignoring the Java11 built, as there's a GHA secret set-up thing we need to deal with.


RNNCell output: Output and State?

There's something that's really bugging me about the RNNCell protocol: that TimeStepOutput is separate from the State. RNN Cells, at least as far as I've seen them in other languages, will always only return the hidden state, and it's up to another Dense layer (or some counterpart) to make process the hidden state.
In that case, why keep them separate? Why not just say that RNN Cells just return a State?
(please do let me know if I'm overlooking something)

If we use State as Output, both the output and the next state will have to be included as part of State. However, it is not ideal to always pass the last hidden state and the last output as part of Input. @jekbradbury What do you think?

The thing that I’m wondering is why do we need ‘Output’ in the first place? RNN Cells only return States, if I’m not mistaken?

I personally believe that the separation of semantics between State and Output is nice, but indeed not super necessary. It probably eventually comes down to how RNN cells are most frequently used and I think that in deep learning it's very often to have distinct notions of state and output and many people think of them that way. For this reason I would lean more towards keeping them separate.


add: foreign key

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (11679e7) 74.10% compared to head (476c651) 75.18%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #112      +/-   ##
==========================================
+ Coverage   74.10%   75.18%   +1.08%
==========================================
  Files          20       20
  Lines         390      407      +17
  Branches       30       37       +7
==========================================
+ Hits          289      306      +17
  Misses        101      101

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Hydration error

I'm getting an error that is appearing only in the browser (not in the server rendering phase) where it complains about importing fs/promises.
It looks like the file fs.ts is getting imported to the browser bundle.
This makes the app not hydrate and not be able to use js.

Fixed in v2.1.4


caddytls: Fix handling of IP-only TLS configs and empty-SNI handshakes

1. What does this change do, exactly?

Always choose a TLS config during a handshake, even if there is no match. Random selection (as a last resort) is OK; any config should allow the TLS-ALPN challenge to be completed.

Add -default-sni flag. If a ClientHello is received with no ServerName (SNI), then this value will be assumed when matching TLS configs and choosing a certificate.

When no ServerName is given, certificates may be chosen based on a matching IP address of the listener.

Update CertMagic dependency, which supports this new matching logic with a default ServerName.

If SNI is present in a ClientHello but does not match any certificates, a TLS alert is raised (in keeping with previous behavior before this change and other recent changes)

2. Please link to the relevant issues.
Hopefully fixes #2451, fixes #2438, fixes #2414, and fixes #2407
3. Which documentation changes (if any) need to be made because of this PR?
Add note about the -default-sni flag.
4. Checklist

[x] I have written tests and verified that they fail without my change
[x] I have squashed any insignificant commits
[x] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I am willing to help maintain this change if there are issues with it later

Calling on: @fr33tux, @oscartbeaumont, @rmoriz, @whitestrake, and @magikstm if you could help test this please, and ensure it works for you, since I was not able to reproduce all the various issues myself (like the Docker stuff).

Better get @ghoeffner @orenyomtov @Zenexer to try this out while they still have a chance, before it lands -- since they apparently have opinions on the matter. And if not, they would not have made such a stink about it before. So I expect to hear from them, but if not it's on them.

@mholt I can confirm that this change has fixed #2438
Thank you!

@mholt None of this is on me.  You're responsible for the security of your own product.  I reported the vulnerability and provided a fix.  What you do from here is on you.  I don't use Caddy and I'm not going to spend any more time testing and coding for someone who's just going to get angry at me.  If I see another vulnerability while pentesting, I'll report it, but don't expect me to contribute beyond that.

Hi @mholt , awesome work buddy. Here is some feedback about my experience to see if this helps with a couple of deployment issues.
If I may, I think I see several minor issues here that when using -service install should be addressed to make it easier for faster deployment. When using the hook.service, caddy -service install should do the following to fix several issues at once:
When it creates the service (using systemd for example) it should also create a default folder for the SSL certificates and a default for the caddyserver file. Like /etc/caddy/ssl for the ssl files and /etc/caddy for the conf file. (As a bonus it should by default be renamed to caddy.service, not Caddy.service (Capital C there).
The default conf folder is to avoid having to guess or manually add the conf parameter.
The default ssl folder is to avoid having several issues when doing the whole systemd process as a it fails if it cant find the folders.
There should be a default log in /var/log/caddy (default with option to set somewhere else, same for conf and ssl folders).
Did not check but an option to automatically restart if the caddyserver file is updated or changed (same option to check if caddyserver file has correct format, if not, do not restart service but send a warning to the logs. If all is good, automatically restart service)
This are just a couple of things that would help in deployment.

@luisalvarado The service plugin is third-party (not by me), so you might want to take it up over there instead: https://github.com/hacdias/caddy-service

Don't know why it took me more than a week to reply. Thank you @mholt will do.


Use a different index than the blog index.

It'd be cool to be able to put the blog posts and index pages under a subdirectory, then compile the pages (with one named index.html) into the main directory.
This way the site could be generated without a blog part, or as a landing page with separate blog content.

TODO:

Obelisk.Blog.html_filename should take the path into account
Should allow an empty value to just use /index.html
Need to make the appropriate directory, only one time (probably on build)
Next and Previous page links need to take the path into account
Index page links need to take the path into account (in Document.html_filename)

I don't want to be pushy, but what's the status on that one? :grin:

No problem :smile:
Yeah that was the plan, to get these features in and use Obelisk to build it's own site. Still those last couple of items to handle, but I think I want #8 as well before building the site to help manage the documentation and table of contents.


More pub.dev points

Let's get more points in pub.dev by following the flutter analysis

No need for PRs to fix Dart format analisys

Please explain why there is no need to fix this


docs: Update CONTRIBUTING.zh-CN.md

Please make sure these boxes are checked before submitting your PR, thank you!

[x] Make sure you follow Element's contributing guide (中文 | English | Español | Français).
[x] Make sure you are merging your commits to dev branch.
[x] Add some descriptions and refer relative issues for you PR.

doc improvement

Please update the relative docs in other languages

Please update the relative docs in other languages

checked. the docs in other languages are correct

Please check it again. All the same.

Please check it again. All the same.

updated. thanks.


KAFKA-2482: Allow sink tasks to get their current assignment, as well as pause and resume topic partitions.

@Ishiihara, would be nice for you to review this (and other Copycat API patches) in addition to @gwenshap.

LGTM (not a hundred percent familiar with some EasyMock functions but the unit test works fine).


Adding ability to use zone root records

What does this PR (Pull Request) do?
Allowing empty name zone name records.
For example, if your Delivery Service FQDN is test.cdn.isp.net, allow to set an A/AAAA/TXT/CNAME records for that hostname.
At the time of writing this PR, there is no change to the API or Traffic Portal which do not allow empty names. Changes need to be done directly in the database (which does allow empty name).

[x] is not related to any Issue

Which Traffic Control components are affected by this PR?

Traffic Router

What is the best way to verify this PR?
This requires to be able to add a static entry in the database using an empty name.
traffic_ops=> select * from staticdnsentry WHERE host = '';
 id  | host |   address   | type | ttl | deliveryservice | cachegroup |         last_updated
-----+------+-------------+------+-----+-----------------+------------+-------------------------------
 146 |      | <IP_ADDRESS> |   53 | 300 |             437 |            | 2019-11-08 17:59:27.906927+00

Result:
[root@cdn1cdcrs0001 ~]# cat /opt/traffic_router/var/auto-zones/minio.cdn1.coxlab.net.
minio.cdn1.coxlab.net.  300     IN      A       <IP_ADDRESS>
minio.cdn1.coxlab.net.  3600    IN      NS      cdn1cdcrs0001.cdn1.coxlab.net.
minio.cdn1.coxlab.net.  3600    IN      NS      cdn1cdcrs0002.cdn1.coxlab.net.
minio.cdn1.coxlab.net.  86400   IN      SOA     cdn1cdcrs0001.cdn1.coxlab.net. traffic_ops.minio.cdn1.coxlab.net.<PHONE_NUMBER> 28800 7200 604800 30

Dig verification :
# dig +short @cdn1cdcrs0001.coxlab.net  minio.cdn1.coxlab.net A
<IP_ADDRESS>

If this is a bug fix, what versions of Traffic Control are affected?
This is an enhancement
The following criteria are ALL met by this PR

[ ] This PR includes tests OR I have explained why tests are unnecessary
[ ] This PR includes documentation OR I have explained why documentation is unnecessary
[ ] This PR includes an update to CHANGELOG.md OR such an update is not necessary
[x] This PR includes any and all required license headers
[x] This PR ensures that database migration sequence is correct OR this PR does not include a database migration
[x] This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

Additional Information
More changes required in Traffic Ops API and Traffic Portal.

Can one of the admins verify this patch?


Feature request: prioritize object methods and properties over snippets and global vars after a dot

Suggestion:
after a dot alm tends to suggest every autocomplete option in alphabetical order.
Maybe it makes more sense to show methods and properties at the top and snippets and documentation annotations at the bottom when detecting something that looks like
myvar.
I think having methods at the top is specially helpfull, since (in my case at least ) when working with third party libraries it exposes me to the available functions and i can read the names and refresh a bit the functionality provided by the library.

In the same way, when in a comment block, it would be usefull to list all the documentation annotations first.
As always, thanks for your outstanding work.

Completely agree. I had it working at some version of monaco. We have our own custom build : https://github.com/basarat/monaco/blob/2fa914a0bea83ac4aa3fc932f733b3af44c05432/extensions/preBuild.ts#L386-L392 that fixes the order just like you suggested. However its broken over some upgrades of monaco. Will add it back when I have some time :rose:

Note to self: With monaco latest (only on master) import no longer matches the snippet as shown below:

Fix it as I do import a lot

Released with 2.5.0 :rose:


Better drag and drop user experience

I fixed two issues I encountered while trying drag and drops on columns :

The drag destination was off by one want dropping on the tenth column and beyond.
The left/right destination wasn't being updated while dragging over a cell, you had to overdrag to the next cell instead of just passing the midpoint of the current cell you were dragging over to change the left/right target.

I committed the updated dist folder, generated with docker-compose up transpile, but it seems to bundle jSuites unlike the current master.
If this is unwanted, please explain to me how I should have done it and I'll update the pull request.

Thanks, it is better indeed. I have fixed a bug when on the first column and merged manually.

@hodeware Thanks for merging part of my work, but the way you did it leaves a lot to be desired :

You forgot / ignored par of the changes, without telling me why exactly
You didn't elaborate as to why my changes couldn't be merge straight away, leaving me no chance to fix it next time I want to open a PR here.

Now please, could you elaborate as to why this couldn't be merged normally ? I would gladly work on adding those details to the contributing page, or adding a build page, so that everyone's life on this project can be easier.

Hi,
We had some problems with conflicts which leads to this route. But, we undertand the frustration and we will avoid that in the future. I am sorry about that and we are happy to review and fix what is appropriated.

Would you mind to get the current version and make a amend with the things you found missing? That would be much appreciated (we will give priority looking onto that)

2 & 3) We will try to merge things quicker to avoid clash problems in the future.
But just for FYI, your PR had one bug when we trying to move the column zero (first column). When a PR is on the core, requires a lot of testing. I am not saying that is you case, but lot of developers lack on testing before PR which makes our life much harder. The most frequent issue is when testing in combinations with different spreadsheet configurations.
As explained, we will try to merge things quicker and hope get a better process in the future. If you have a different suggestion, on how to address this, just let us know.


Add known issue concerning no indexing during stemcell upgrade

We discovered a minor issue during a stemcell upgrade that should be documented in the release notes

Thanks, @mrdavidlaing !


[staging-next] sage: override python limit on int<->str conversions

Description of changes
Python uses a quadratic algorithm for converting strings to ints and vice-versa. Python 3.10.7 "fixes" that by throwing an exception if asked to convert numbers with more than 4300 digits, which is a disaster for anything Sage-related, but it also adds an escape hatch to override the 4300 limit. This imports an upstream Sage patch to set that limit to 0 (i.e., unlimited).
The Python change was backported (to 3.9.14, 3.8.14 and 3.7.14), so we might need to backport the Sage patch to 22.05 in the future.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

Closing in favor of #189891

Merging to address https://github.com/NixOS/nixpkgs/pull/200361#issuecomment-1315671236


Excluding multiple values from nested json

How to exclude records that have any one of set of bad values of event nested key.
i.e.If event value is bad1 or bad2 or bad3 then the record should be excluded
Below is the config
# Jay - Tailing the Nginx Logs
<source>
        @type tail
        path /var/log/nginx/access.log
        pos_file /var/log/td-agent/nginx-access.pos
        tag nginx.access
        format json
</source>

# Jay - Filter the data before uploading it to kinesis
<filter nginx.access>
        @type grep
        <exclude>
                key $.request_body.event
                pattern bad1
        </exclude>
</filter>

Below is log format
{
  "time_local": "2019-06-04T18:51:03+05:30",
  "remote_addr": "<IP_ADDRESS>",
  "request_time": "0.000",
  "http_referrer": "https://abcd.com/shows",
  "http_user_agent": "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/74.0.3729.169 Safari/537.36",
  "request_id": "7bf3a62064f2c05d56694c3e3d7ca93c",
  "http_true_client_ip": "<IP_ADDRESS>",
  "http_geo_info": "GEO=IN REGION=MH",
  "request_body": "{\"event\":\"ABC\",\"unique_id\":\"f8a68889ff212189f1eeeb94aec9ec10\"}}"
}

How did you solve the problem ?

How did you solve the problem?


Please provide wheels for Python 3.12

Python 3.12 has been released, and it would be great to have ahocorasick_rs wheels for it available at PyPI. Thanks.

Remaining todos:

[ ] Upgrade to PyO3 0.20 where there's official support for Python 3.12 (here's the PR)
[ ] Do the actual release of this package

Packages should be up on PyPI shortly.


Fix: Add type declarations

This PR

[x] adds type declarations

Follows #744.
Follows #745.

Thank you, @chartjes!


Update zh_cn.json

Fixed some incorrect Chinese translations.
Optimize some Chinese language expression. Perhaps it may lead to a different meaning than what the English is intended to express, but it all means the same. 🤔

Thanks for the improvements. They will be part of the next release.


API /positions Device access denied - SecurityException (PermissionsManager:194 < PositionResource:89 < ...)

We have installed Traccar on Windows 2012 R2 server.
We have 2 devices registered and working.  We have 1 iphone registered and working.
We have 1 user account: admin with a non default password.
Using the API these commands work correctly...
POST /api/session  (using params)
GET /api/devices - lists 3 devices
GET /api/users - lists 1 user and token
GET /api/events/{id} - retrieves events correctly
However, this API does NOT work...
GET /api/positions
the /api/positions generates this error...

Device access denied - SecurityException (PermissionsManager:194 < PositionResource:89 < ...)

I can view the devices in the Traccar web app and I am using the Admin account which has access to everything.
It appears that the positions api does not function correctly.  I have checked the Traccar webapp and it does not use the positions API as it uses websockets instead.
I believe this is a bug in the API.

It's not a bug. Make sure that you include "Accept" header in the request.

I already have the header set to
Accept: /
But is still does not work with the same error...

Device access denied - SecurityException (PermissionsManager:194 < PositionResource:89 < ...)

I cannot find any reference to accept header in API documentation.

That's an invalid header value. You have to specify the format that you want the data to be in. For example, you can try application/json.

Yay! That worked, thank you for your help.

I had pass Accept and Header Type correct, even I face same issue.

@tananaev ,
I got same issue also but does not found any solution on this even used same header json. but not solve

@cgsadmin please use forum for discussions. Make sure you provide full request and response.


Wrong rendering of code block inside numbered list

Have you read the Contributing Guidelines on issues?

[X] I have read the Contributing Guidelines on issues.

Prerequisites

[X] I'm using the latest version of Docusaurus.
[ ] I have tried the npm run clear or yarn clear command.
[ ] I have tried rm -rf node_modules yarn.lock package-lock.json and re-installing packages.
[ ] I have tried creating a repro with https://new.docusaurus.io.
[ ] I have read the console error message carefully (if applicable).

Description
The following MD markup:
1)  Some text
    ```jsx
    console.log('Hello World!');
    ```

Should be rendered as this:

Some textconsole.log('Hello World!');

Instead, Docusaurus renders it with ```jsx and ``` printed at the beginning and the end of the code block, and it also does not indent the list item (neither the text, nor the code block).
Note, if 1) is replaced by -  (i.e. bullet list with otherwise the same markup) the markup is rendered correctly (both the indent and the code block), also the code block in the numbered list is rendered fine if less than 4 leading whitespaces is used in the markup.
Steps to reproduce
N/A
Expected behavior
N/A
Actual behavior
N/A
Your environment
N/A
Reproducible demo
No response
Self-service

[ ] I'd be willing to fix this bug myself.

Hey, Docusaurus uses MDX v1 as the Markdown renderer, so please ensure your syntax is valid MDX. Unfortunately, it is not:

1) is common mark syntax, and is not always supported. MDX v1 doesn't support this, but v2 does.
Indentation by four spaces means a code block.

You can test in the MDX playground:


Less allocation for fixed-size binaray decoding

The CI is broken for an unrelated reason

Yes that would be very useful to test indeed, as well as verifying that no buffers are allocated when it is is not needed (by using physical equality).


Explore etcd transaction

It would be nice to update configuration in etcd in atomic way. Currently there's possibility to have inconsistent api configuration in etcd

Not needed for now


Automatically insert Razor into VS on some schedule

Today Razor insertions into VS only happen when we manually trigger them. We should set them to happen automatically so we find out earlier when there's an issue with the insertion and get more frequent updates.

Resolved via #7944


Add button macro

Create a macro for the button component.
Add Nunjucks usage example and table of arguments to the README.
Display the button macro on the example page.

Not sure if relevant but the interface to our button component changes internally if it's a link or not depending on if a href is passed:
https://github.com/alphagov/static/blob/master/app/views/govuk_component/button.raw.html.erb#L6

Thanks @nickcolley! That's a better solution, have revised this to work in the same way.


Add additional languages beyond English, Chinese, Hebrew, Japanese, Polish, German

Windows releases contained Winfile in multiple languages (such as Russian). This project currently has only English language version.

I'll go digging in the NT4 source tree for the other languages.  I'll need help with any new/changed strings.

I can help with the Swedish language version.

Considering Windows is now available in languages in which NT 4.0 wasn't, will there be any additional translation efforts for such languages?

@daviunic you offering?

I could do Czech and Slovakia version if developer would want to translate...

I can help with the Polish resources.
I think it would be rather all languages in one EXE than additional MUI files, wouldn't it?

@ZanderBrown yes, I could do the Slovenian translation.

I have yet to find any translations of the WinFile strings inside Microsoft.
What do folks think about @thecatkitty's idea that all languages are in one EXE?

Makes sense, perhaps we need additional UI to override system language?

I do not think this utility should override system language.

I'd be glad to help if assistance with German is needed.

@Anixx to clarify:
WinFile should use the system language by default, as should all applications, but have the option to manually specify a language use

@ZanderBrown I know no app that provides this feature.

@ZanderBrown I've seen plenty of apps that give you the option to switch to another language or use the default system language.
I'm not arguing either way in this case. I'm just noting that I've seen may apps that do this and many that don't.
This feature will definitely be useful for Windows 7 or older. Windows 7 doesn't let you switch languages on the fly unless you have ultimate. With windows 10, there are more languages to download on demand that ever, and the process is very easy now that it is distributed through the Windows Store, as of Version 1803.
Again, I'm neutral in regards to this point, as it doesn't affect me significantly and, thus, won't be fair for me to just pick a side for the same of it.

I could try to help in translations to Portuguese and Brazilian Portuguese .

How the translation was originally done?

I'm still trying to track down the original translations and the tools used.   What I found thus far (scouring a repo and also asking someone) was the attached file (without the .txt extension).
winfile.tok.txt
I was hoping to find other languages, but this is the think I have found thus far.

Heyo! In the spirit of open source collaboration, I’ll be glad to help out with Spanish and Catalan translations.

I'd be happy to help with Romanian if needed.

Hi folks.  We are in the final stages of getting PR #120 added to master.  If you volunteered to write a translation, you can begin that process using as a guide what @MouriNaruto and @mattn have done.  Don't forget to put it in the lang subdirectory and find the right locale string to use.

We are up to four languages (once I add Polish).  Several folks indicated willingness to help: @magol, @IQBigBang, @NazmusLabs, @daviunic, @mischastik, @bitsbr, @fitojb, and @TheFanatr.
Follow the patterns in recent PR with #143 being the most recent.

I'm able to do French and Bengali. French would be the first one to target.

One thing to note, Right-to-left languages (such as Arabic, Hebrew) use DIALOGEX instead of DIALOG,
and to use EXSTYLE WS_EX_LAYOUTRTL to enable mirrored layout.
Non-dialog mirroring is on its way + Hebrew translation (since the wfw3.1 version)

Thanks @peterooch for solving the RTL issues.  German is in the works by @BaldwinTechnology.
I am looking at applying the change by @malxau for resizable dialogs in a way that doesn't burden all translations.  Thus other translations can proceed.
Those offering: @magol, @IQBigBang, @NazmusLabs, @daviunic, @mischastik, @bitsbr, @fitojb, and @TheFanatr.

@Anixx @craigwi The title of this issue need a change now (or closing it), since we have so many languages other than English now.(Hebrew, Simplified Chinese, Japanese, German, Polish...)
Since we have so many languages, we may be able to create a Translators' List (or so) now.

not even included portuguese Brazil (pt-BR) language file you damn bastards... you click help and winfile doesn't open the help file, instead it goes to microsoft website telling you what to do when a program doesn't open the help file... you retarded people... do it right or do not... bastards...
  China is communist...
Ninguém é obrigado a saber programas pra usar esse lixo, seus merdas... se for assim, devolvam o absurdo que paguei em minha licença do windows... BABACAS!
colocar chinês em vez de português KKKKKKKKKK!!! Quanta idiotice... como se eles fossem baixar essa merda lá na china comunista KKKKKKKKKK... Bando de retardados...


Use global application store to manage dark mode

Closes #134
@lupinitylabs Could you give this a test on your end when the PR Netlify instance has finished deploying?

Works like a charm! 👍

Excellent! Thanks for verifying 👍


[Feat]:  Improve the animation of Testimonial and Sponsor section

What feature?
Add smoother animation to the testimonial and the sponsor section in home page

Show us the magic with screenshots
No response
Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSoC'23 contributor
[X] I want to work on this issue

@Vaishnavi-Patil2211 please assign this


Variable Explorer Shows Works For Only One Script

What steps will reproduce the problem?

Steps to Reproduce:

Create/Open a simple script script (Eg. "folder1/Test1.py")
Run script
Create/Open a new simple script script (Eg. "folder2/Test2.py")
Run new script

Personal Troubleshooting Steps:
In the above steps, I found that Spyder only shows the variables in the first script. I have tried:

Switching the working director to "folder2"
Deleting the orinial script ("Test1.py")
Restarting Spyder

Notes:

Both scripts have variables to show (pandas data frames primarily)
Both scripts in my case share a root folder ("projects/folder1/Test1.py" and "projects/folder2/Test2.py")

Hey @asgardee, thanks for reporting. Could you post a video or animated gif of the problem you're seeing? I really don't understand what's happening in your case.
You can create animated gifs using the Licecap program.

Closing due to lack of response.


[add] gws facility initializer regist_private_gws_facility_plans

Coverage decreased (-0.07%) to 84.902% when pulling 256e95cb283d4d8401b436c37cd0b5d99737b1f4 on pr-gws-facility-duplicate-regist into 6b369acc277ee103036460b15c715b0ae411e855 on master.


vite build error

Steps to reproduce:

npm create vite@latest
choose React, typescript
install libs "ketcher-react": "^2.24.0", "ketcher-standalone": "^2.24.0",
invoke libs in component, for example:

/* eslint-disable @typescript-eslint/no-explicit-any */
import { useEffect, useState } from "react";
import { Ketcher, StandaloneStructServiceProvider } from "ketcher-standalone";
import { Editor } from "ketcher-react";
import "ketcher-react/dist/index.css";
import "./App.css";

const structServiceProvider = new StandaloneStructServiceProvider();

function App() {
  const [isKetcherInitialized, setIsKetcherInitialized] = useState(false); // Track Ketcher initialization
  const [ketcherInstance, setKetcherInstance] = useState<Ketcher | null>(null); // Store Ketcher instance

  useEffect(() => {
    if (ketcherInstance && isKetcherInitialized) {
      try {
        ketcherInstance.setMolecule("");
      } catch (error) {
        console.error("Failed to set SMILES:", error);
      }
    }
  }, [isKetcherInitialized]);

  return (
    <div>
      <Editor
        staticResourcesUrl={""}
        structServiceProvider={structServiceProvider as any}
        errorHandler={(message: string | Error) => {
          console.error("Error in Ketcher:", message);

        }}
        onInit={(ketcher: Ketcher) => {
          // Assign Ketcher instance to window for KetcherLogger to use

          /* eslint-disable-next-line @typescript-eslint/ban-ts-comment */
          // @ts-ignore
          window.ketcher = ketcher;

          setKetcherInstance(ketcher); // Set Ketcher instance in state
          setIsKetcherInitialized(true); // Mark Ketcher as initialized
          try {
            ketcher.setMolecule(''); // Set the default SMILES after initialization
          } catch (error) {
            console.error("Error initializing Ketcher with SMILES:", error);
          }
        }}
      />
    </div>
  );
}

export default App;

Try to build: npm run build

Explanation:
After adding libs:
    "ketcher-react": "^2.24.0",
    "ketcher-standalone": "^2.24.0",

and trying to build my react ts project with vite, I get error:
thread '<unnamed>' panicked at /Users/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/swc_common-0.39.0/src/syntax_pos.rs:702:18:
width 3 given for non-narrow character
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
thread '<unnamed>' panicked at library/core/src/panicking.rs:221:5:
panic in a function that cannot unwind
stack backtrace:
   0:        0x1329fce37 - _napi_register_module_v1
   1:        0x1329899eb - <unknown>
   2:        0x1329d19f2 - _napi_register_module_v1
   3:        0x1329fe442 - _napi_register_module_v1
   4:        0x1329ff8d9 - _napi_register_module_v1
   5:        0x1329fe992 - _napi_register_module_v1
   6:        0x1329fe929 - _napi_register_module_v1
   7:        0x1329fe91c - _napi_register_module_v1
   8:        0x132b4c56c - _napi_register_module_v1
   9:        0x132b4c5e5 - _napi_register_module_v1
  10:        0x132b4c589 - _napi_register_module_v1
  11:        0x132981dfc - <unknown>
  12:        0x100616b40 - __ZN6v8impl12_GLOBAL__N_123FunctionCallbackWrapper6InvokeERKN2v820FunctionCallbackInfoINS2_5ValueEEE
thread caused non-unwinding panic. aborting.
/bin/sh: line 1: 13941 Abort trap: 6           vite build

As I understand, this is trouble : width 3 given for non-narrow character, chatGPT says:

SWC is a Rust-based compiler that Vite uses for code transformation and minification during the build process. The error message:
width 3 given for non-narrow character
indicates that SWC is encountering a character that doesn't fit within its expected character width, possibly due to Unicode characters or certain syntax in the ketcher packages.
Given that the error appears after importing ketcher-react and ketcher-standalone, it's likely that:
SWC cannot process some code within these packages.
The packages might contain non-standard syntax or characters that cause SWC to crash.

my dependencies:
    "react": "^18.2.0",
    "vite": "^5.3.2",

More precisely, there is a bug in the ketcher-react library, without it the build is successful

One more addition:
Here is the problematic line:

Code file with error
After the build, for some reason this import does not work.

I get the same bug, also vite, no errors apparently in build but trying to load site throws this error. npm run start serves a working page, problem is only after build.

After adding libs:
    "ketcher-react": "^2.24.0",
    "ketcher-standalone": "^2.24.0",

and trying to build my react ts project with vite, I get error:
thread '<unnamed>' panicked at /Users/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/swc_common-0.39.0/src/syntax_pos.rs:702:18:
width 3 given for non-narrow character
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
thread '<unnamed>' panicked at library/core/src/panicking.rs:221:5:
panic in a function that cannot unwind
stack backtrace:
   0:        0x1329fce37 - _napi_register_module_v1
   1:        0x1329899eb - <unknown>
   2:        0x1329d19f2 - _napi_register_module_v1
   3:        0x1329fe442 - _napi_register_module_v1
   4:        0x1329ff8d9 - _napi_register_module_v1
   5:        0x1329fe992 - _napi_register_module_v1
   6:        0x1329fe929 - _napi_register_module_v1
   7:        0x1329fe91c - _napi_register_module_v1
   8:        0x132b4c56c - _napi_register_module_v1
   9:        0x132b4c5e5 - _napi_register_module_v1
  10:        0x132b4c589 - _napi_register_module_v1
  11:        0x132981dfc - <unknown>
  12:        0x100616b40 - __ZN6v8impl12_GLOBAL__N_123FunctionCallbackWrapper6InvokeERKN2v820FunctionCallbackInfoINS2_5ValueEEE
thread caused non-unwinding panic. aborting.
/bin/sh: line 1: 13941 Abort trap: 6           vite build

As I understand, this is trouble : width 3 given for non-narrow character, chatGPT says:

SWC is a Rust-based compiler that Vite uses for code transformation and minification during the build process. The error message:
width 3 given for non-narrow character
indicates that SWC is encountering a character that doesn't fit within its expected character width, possibly due to Unicode characters or certain syntax in the ketcher packages.
Given that the error appears after importing ketcher-react and ketcher-standalone, it's likely that:
SWC cannot process some code within these packages.
The packages might contain non-standard syntax or characters that cause SWC to crash.

my dependencies:
    "react": "^18.2.0",
    "vite": "^5.3.2",

I had this problem, found the solution in this vite bug: https://github.com/vitejs/vite/issues/18179#issue-2543316736
npm install -D<EMAIL_ADDRESS>

One more addition: Here is the problematic line:
Code file with error
After the build, for some reason this import does not work.

After solving the first post issue (with npm install -D<EMAIL_ADDRESS>I managed to build successfully. However on opening the site I see the same "Uncaught ReferenceError: require is not defined" on the same bit of code (raphael) in ketcher-react.

May I ask, after vite packaging, the problem of require('raphael') require not defined has been solved? I have exactly the same phenomenon as you

May I ask, after vite packaging, the problem of require('raphael') require not defined has been solved? I have exactly the same phenomenon as you

Unfortunately, the problem is still not solved and there is no feedback from the developers

`
yarn add vite-plugin-commonjs
import commonjs from 'vite-plugin-commonjs';
// vite.config
{
plugins: [react(), commonjs()],
}
`

I have solved the problem ‘the problem of require('raphael') require not defined ’

// 1、 yarn add vite-plugin-commonjs

// vite.config.ts

// 2、import commonjs from 'vite-plugin-commonjs';

{
plugins: [react(), commonjs()],
define: {
    'process.env': {},
    global: 'global',
  },
  build: {
    commonjsOptions: {
      transformMixedEsModules: true,
    },
  },
}

// 3、index.html
  <head>
    <meta charset="UTF-8" />
    <link rel="icon" type="image/svg+xml" href="/vite.svg" />
    <meta name="viewport" content="width=device-width, initial-scale=1.0" />
    <title>Vite + React + TS</title>
         // add script code add to head
    <script>
      var global = window;
    </script>
  </head>

in my case, installing rollup (or overriding it) does not solve the problem. Tell me your version of react, vite? I also tried adding rollup in a new project, which only has ketcher (which I used as an example to reproduce the bug), and it still gives the same error

Hi @hellhorse123
If you can create repository with example we can try to help.

Hi @hellhorse123 If you can create repository with example we can try to help.
This is archive where reproduce the problem:
ketcher-check.zip

However, I don't know how much the above solutions are a crutch, but the following list of steps helped solve this problem:

npm install -D<EMAIL_ADDRESS>(or yarn add<EMAIL_ADDRESS>--dev )
yarn add vite-plugin-commonjs
in file vite.config:

{
plugins: [react(), commonjs()],
define: {
    'process.env': {},
    global: 'global',
  },
  build: {
    commonjsOptions: {
      transformMixedEsModules: true,
    },
  },
}

in file index.html :

  <head>
    <meta charset="UTF-8" />
    <link rel="icon" type="image/svg+xml" href="/vite.svg" />
    <meta name="viewport" content="width=device-width, initial-scale=1.0" />
    <title>Vite + React + TS</title>
         // add script code add to head
    <script>
      var global = window;
    </script>
  </head>

And in my case, was additional problem with cdn plugin in vite.config. I remove react and react-dom from it and all works now

I also encountered this same issue, along with some issues resolving the types for ketcher-standalone that introduced themselves after upgrading to the latest v2.25.0.
It would be great to resolve this issue without having to do an elaborate workaround such as the ones @hellhorse123 and @wiscgazf describe (thanks to both of you, by the way!).
@rrodionov91 @samellis – any idea if we can expect a fix for this issue or has it been resolved?


sub-signatures demand a space before parenthesis

This makes the example compile.

@gfldex - as we discussed on IRC, this looks to me like it's not an issue in the latest version of rakudo - I'll close this PR, but please feel free to re-open if needed.


Simply SEP-31 amount and fee calculation.

According to the simplified amount/fee calculation when quote_id exists discussed at in LucidChart, the amount_in and amount_out will be overriden by the buy_amount and sell_amount of the quote from SEP-31.


Simple cookie parser keeps first cookie with same name, not most recently set

Hi, to help others duplicate this issue, can you please include a code sample and the error you receive? Thanks!

Thanks, fixed. I simplified the implementation to have the simple cookie map populated by the set result of the Cookie Store, which corrects for order, path, etc.

All this fix make lots of trouble! "set-cookie" will be none sence by this fix and many "set-cookie"s are ignored after this fix. Maybe you test more cases to check whether it is fine!

@anonyein

This fix makes lots of trouble! "set-cookie" will be none sence by this fix and many "set-cookie"s are ignored after this fix. You must test more cases to check whether it is fine!

Yeah... I rolled it back in 8dec9c302e2f2d2b5560fefa0d3ed7e1b813e195 and we just keep the last set one.


Proposed DragValue improvement

Is your feature request related to a problem? Please describe.
At the moment drag values are good, but I believe we can make them better. I'm ready to work on this one.
@emilk if you give me the go ahead I can start working on it or part of it depending on what you think will be good for egui.
Describe the solution you'd like
I would like to propose an implementation similar with the ones from Blender.
You can see more in the GIF below, but the key improvements are in order of priority:

[x] On hover display W-E cursor
[x] When shift is pressed and we drag we add or subtract DragValue::speed() / 10
[ ] Add arrows to increase or decrease value, maybe display them only on hover
[ ] When arrows are clicked we add or subtract the amount equal to the value set by DragValue::speed()
[ ] When shift is pressed and we click on the arrows we add or subtract DragValue::speed() / 10
[ ] When we start dragging save cursor position, hide the cursor while dragging, when dragging is done display the cursor at the saved location

Describe alternatives you've considered
Nothing here as my focus is to do my best to help improve egui
Additional context
How Blender does it.

I think this all sounds great! I would like to keep the compactness of the current values, but maybe adding room for thin arrows is fine. I definitely thing they should be hidden until hovered, like in your gif.

Great. I will will start working on this then.

This one:

When we start dragging save cursor position, hide the cursor while dragging, when dragging is done display the cursor at the saved location

I think I will skip it. I mean for desktop it is easy, but to support it on web I think it will be an ugly hack. From my research the mouse API for web gives us, mouse movement, clicks, wheel and mouse locking, but no positioning ability. Also from my brief examination of web_sys it seems that pointer lock API is not exposed, but again I might be wrong. I will move this as the last potential item to implement.

Bummer. I can't figure out how to add the arrows only on hover. I tried a few things, but both the UI and the code were ugly. I'll keep a bit at it.

@emilk For the moment I need to stop on this, but rather than giving up everything I propose those 3 implemented features.

On hover display ResizeHorizontal cursor
When shift is pressed and we drag we add or subtract DragValue::speed() / 10
While dragging display ResizeHorizontal.

Link to PR: https://github.com/emilk/egui/pull/274


Support collapsing long enums as members

What is the feature you'd like to have?
In the Types view, long enums have a arrow so you can collapse them. However, if you make a struct with one member being the enum, it inlines the whole enum into that struct's definition, making it hard to read.
Are any alternative solutions acceptable?
Named enums could just show the name and then allow double click to find the definition, rather than displaying inline.

Not sure if I'm misunderstanding this, was the full definition of test_enum included in the definition of test_struct?
I couldn't get it to show up in versions going back to 3.1.3771-dev.

I think I have to admit to a bit of PEBKAC here, sorry for the incomplete report. You're exactly correct, for some reason I inlined the enum definition while reversing it out.
Here's the screenshot:

And here's the struct definition:
struct parsed_input __packed
{
    char firstword[0x8];
    int64_t padding;
    char rest[0x1ff];
    __padding char _20F[1];
    int32_t rest_len;
    enum : uint32_t
    {
        REIN = 0x1,
        TYPE = 0x2,
        SIZE = 0x3,
        REST = 0x4,
        MLST = 0x5,
        STOU = 0x6,
        LIST = 0x7,
        RMDA = 0x8,
        EPRT = 0x9,
        FEAT = 0xa,
        QUEU = 0xb,
        STOR = 0xc,
        RMD = 0xd,
        CDUP = 0xe,
        PORT = 0xf,
        PASS = 0x10,
        APPE = 0x11,
        NLST = 0x12,
        FREE = 0x13,
        HELP = 0x14,
        VIEW = 0x15,
        QUIT = 0x16,
        MKD = 0x17,
        MLSD = 0x18,
        PASV = 0x19,
        PWD = 0x1a,
        RNTO = 0x1b,
        DELE = 0x1c,
        MODE = 0x1d,
        RETR = 0x1e,
        EXEC = 0x1f,
        CWD = 0x20,
        EPSV = 0x21,
        STRU = 0x22,
        USER = 0x23,
        RNFR = 0x24,
        SYST = 0x25,
        MDTM = 0x26
    } command_enum;
};

... notice a similarity?
If I replace that inline struct with a "normal" enum, it displays exactly as expected.
I reverted to the previous stable and verified this was true then, which was only ~20 builds away from the version I was using at the time, so I'm not sure what I was thinking with that struct definition.
This probably falls into the "WONTFIX, use a proper enum instead" category, unless you think it's worth handling anonymous enums specially. (Do the typelibs for any major platform use anonymous enums a lot?)
Thanks for taking a look!

Thanks for the report! Collapsing type members is tracked by https://github.com/Vector35/binaryninja-api/issues/3758 - closing in favor of that issue


Better docs on integration with nvim-dap

Hey @rcarriga  thank you for creating this awesome plugin, having dap and plugins like this is one the things that motivates me more into switching fulltime into neovim.
Reading through nvim-dap documentation I noticed I could automatically open the UI hooking into DAP's  stopped event
I bet this is something other folks will like to add to their configuration which I think is worth documenting.
Maybe a like snippet like this in the readme:
      local dap = require('dap')

      dap.listeners.before['event_stopped']['rcarriga/nvim-dap-ui'] = function(session, body)
        print('Stopped at breakpoint')
        require("dapui").open()
      end

      dap.listeners.before['event_terminated']['rcarriga/nvim-dap-ui'] = function(session, body)
        require("dapui").close()
      end

I'm using packer and put that into the setup function.

Hey thanks for the feedback! Actually this used to be setup by default but I removed it to allow more  flexibility, never thought to document it, will do :ok_hand:


Add closure compiler and bump webpack

could you provide a description and/or perf measurement gains by the switch?

Closing for now, too many issues to address (tests failing, coverage not working in webpack2, etc.). Will add issue to the backlog though because I saw a 10-20% compression from using the closure compiler.


Add migration guide draft [ECR-2763]

Overview

See: https://jira.bf.local/browse/ECR-2763
Definition of Done

[ ] There are no TODOs left in the code
[ ] Changelog is updated if needed (in case of notable or breaking changes)
[ ] The continuous integration build passes

creating a path for cryptocurrency demo as a migration example.

What do you mean by that? A patch with changes to the demo?

A patch with changes to the demo?

I wonder if Github can show a diff between two revisions for a certain path (i.e., not a diff for all files).


⚠ Adacta-fintech.com has degraded performance

In f05d621, Adacta-fintech.com (https://www.adacta-fintech.com) experienced degraded performance:

HTTP code: 200
Response time: 1729 ms

Resolved: Adacta-fintech.com performance has improved in edfc992 after 7 minutes.


Fix cursor missing issue

Issue: The cursor is missing when the search button is first clicked.
I have reviewed the code and it seems that searchInput.focus() does not work the first time.
To address this, I moving the searchInput.focus() line inside the onload callback function of the loadScript function. This change ensures that the focus is set after the script has finished loading.

Issue on mobile devices：


Include Kotlin DSL samples in wrapper chapter

Context
This builds upon @StefMa's PR to convert the wrapper user manual doc to include Kotlin DSL samples and test them.
Passing branch build
Gradle Core Team Checklist

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation
[ ] Recognize contributor in release notes

Squashed and merged with 0a9743bb776569e9d8c4b71e3fbce9f991d8de82 — Thanks again @StefMa!


Update Portafolio “pycon”

Automatically generated by Netlify CMS

Deploy preview for scot3004 processing.
Building with commit 9489cd23d7fa2afbcb8e695369812d4346788d56
https://app.netlify.com/sites/scot3004/deploys/5e66fbe3a5d7df0008aa33a5


[Icons] catalog2registration changes

catalog2registration will check the flat container for the presence of the icon file in the expected location, if the file is there, put the link to that file in the flat container.
If no file is present iconUrl property is not emitted (or emitted empty).
This depends on new catalog2dnx behavior (#7061) and can only be deployed after catalog2dnx.

Validated orchestrator and jobs using the ValidationJobBase.
Need to check internal jobs now.

Internal jobs validated.


OJ-2727: Changes to enable post merge testing

Proposed changes
What changed

Added @post-merge tag to tests that should be run post merge
Refactor the relying-party page to handle using the core stub rather than the imposter stub within the frontend repo
Imposter stub updated to match the third party stub config

Why did it change
To use cucumber tests post merge
Screenshots

Issue tracking

OJ-2727

Checklists
Environment variables or secrets

[x] Documented in the README
[x] Added to deployment repository
[x] Added to local startup repository

Nice stuff 👍🏾


CGPathAddLineToPoint error

With Xcode 7.2 :
I'm using the view within Interface Builder, everything works great, as expected,
but I get this message in the debugger console on runtime :
Feb  8 18:04:25  MyProject[46206] <Error>: void CGPathAddLineToPoint(CGMutablePathRef _Nullable, const CGAffineTransform * _Nullable, CGFloat, CGFloat): no current point.
No graphical glitch noticed, it appears just once, when drawing the clock for the first time, other draws are OK.

Never noticed this warning before. I'll give it a try and let you know.

@Philoozushi : Should be fixed in 1.1.2 :+1:
https://github.com/notbenoit/EZClockView/releases/tag/1.1.2

Awesome reactivity! :smiley_cat: :+1:
Now it would be nice to update the cocoapod too :wink:

Hell yeah totally forgot, I will update that soon! (I've been using Carthage for a while now)

I updated cocoapods, let me know if you have any trouble!

Yeah, big debate about Cocoapods vs Carthage lately :stuck_out_tongue:
Anyway, the updated Cocoapod works perfectly! :+1:
Thanks again for sharing this good work :smile:


Appstudio update test-component-pac-omto

Pipelines as Code configuration proposal
To start the PipelineRun, add a new comment with content /ok-to-test
For more detailed information about running a PipelineRun, please refer to Pipelines as Code documentation Running the PipelineRun
To customize the proposed PipelineRuns after merge, please refer to Build Pipeline customization

Pipelines as Code CI/test-component-pac-omto-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
6 seconds
init

✅ Succeeded
21 seconds
clone-repository

✅ Succeeded
1 minute
build-container

✅ Succeeded
10 seconds
sast-snyk-check

✅ Succeeded
52 seconds
deprecated-base-image-check

✅ Succeeded
1 minute
inspect-image

✅ Succeeded
3 minutes
clair-scan

✅ Succeeded
1 minute
clamav-scan

✅ Succeeded
8 seconds
sbom-json-check

✅ Succeeded
6 seconds
show-sbom

✅ Succeeded
7 seconds
show-summary

Pipelines as Code CI/test-component-pac-omto-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
6 seconds
init

✅ Succeeded
21 seconds
clone-repository

✅ Succeeded
1 minute
build-container

✅ Succeeded
10 seconds
sast-snyk-check

✅ Succeeded
1 minute
inspect-image

✅ Succeeded
3 minutes
clair-scan

✅ Succeeded
52 seconds
deprecated-base-image-check

✅ Succeeded
8 seconds
sbom-json-check

✅ Succeeded
1 minute
clamav-scan

✅ Succeeded
6 seconds
show-sbom

✅ Succeeded
7 seconds
show-summary

Pipelines as Code CI/test-component-pac-omto-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
8 seconds
init

✅ Succeeded
14 seconds
clone-repository

✅ Succeeded
21 seconds
sast-snyk-check

✅ Succeeded
38 seconds
build-container

✅ Succeeded
52 seconds
deprecated-base-image-check

✅ Succeeded
34 seconds
clamav-scan

✅ Succeeded
8 seconds
sbom-json-check

✅ Succeeded
23 seconds
inspect-image

✅ Succeeded
7 seconds
clair-scan

✅ Succeeded
4 seconds
show-sbom

✅ Succeeded
4 seconds
show-summary


Update Gradle Wrapper from 7.2 to 7.3

Update Gradle Wrapper from 7.2 to 7.3.
Read the release notes: https://docs.gradle.org/7.3/release-notes.html

The checksums of the Wrapper JAR and the distribution binary have been successfully verified.

Gradle release: 7.3
Distribution (-all) zip checksum: 00b273629df4ce46e68df232161d5a7c4e495b9a029ce6e0420f071e21316867
Wrapper JAR Checksum: 33ad4583fd7ee156f533778736fa1b4940bd83b433934d1cc4e9f608e99a6a89

You can find the reference checksum values at https://gradle.org/release-checksums/

🤖 This PR has been created by the Update Gradle Wrapper action.

Need help? 🤔

If something doesn't look right with this PR please file an issue here.

Unable to set all the PR reviewers, check the following usernames are correct:

@bigmichi1

Please refer to the documentation for the reviewers and team-reviewers input parameters.

🤖 This is an automatic comment by the Update Gradle Wrapper action.


Edges should appear in AFrame

Edges(line and polylines) does not work properly with AFrame

Please use entity with line, or use another shape like a cylinder or cube to simulate these lines

Works well
| c shapes eb |
c := RSCanvas new.
shapes := Collection withAllSubclasses collect: [ :cls |
	RSEllipse new
		model: cls;
		draggable;
		size: 5;
		yourself
	 ].

c addAll: shapes.
RSNormalizer color
	from: (Color gray alpha: 0.5);
	to: (Color red alpha: 0.5);
	shapes: shapes;
	normalize: #numberOfMethods.
RSNormalizer size
	shapes: shapes;
	normalize: #numberOfMethods.
eb := RSEdgeBuilder line.
eb canvas: c.
eb connectFrom: #superclass.
RSTreeLayout on: shapes.
shapes do: [ :e | e translateBy: 0 @ 0 ].
c @ RSCanvasController.
c aFrameExporter
	noFloor;
	fileName: 'test';
	exportAndOpen