Update helm chart

Set missing .spec.replica in deployments
Implement missing ingress for github webhook server
Add authSecret.existingSecret
Unset default image.tag as values.yaml is default value for chart, uncommenting image.tag will never make app version to be tag

Just from a quick glance:

This isn't valid yaml in the values.yaml, tag needs a default value or should be commented out, why not latest?

  tag:
  dindSidecarRepositoryAndTag: "docker:dind"
  pullPolicy: IfNotPresent

The enabled: false attribute has been deleted in the values.yaml under authSecret but is still referenced and is needed. If we are going to add support for externally defined secrets (which I'm not a big fan of personally but that is up to the maintainer not me) this should probably be changed to something like createManagerSecret maybe and existingSecret should become managerSecretName with a default value of controller-manager maybe? Then managerSecretName can be general purpose allowing it to be valid for if the secret is being defined within the chart, or it referencing a secret externally defined secret instead?:

authSecret:
  createManagerSecret: false
  managerSecretName: "controller-manager"
  ### GitHub Apps Configuration
  #github_app_id: ""
  #github_app_installation_id: ""
  #github_app_private_key: |
  ### GitHub PAT Configuration
  #github_token: ""

Previously the secret was implemented to be general purpose so it was done in a loop rather than referencing the individual secrets.
What do you think @mumoshu @kimxogus ?

@callum-tait-pbx

When you add repo and install following README.md(not helm install ./charts/actions-runner-controller in directory), user defined values.yaml will override default values.yaml, which means latest will be always default and appVersion-based default value will never be applied, which means the comment # Overrides the manager image tag whose default is the chart appVersion if the tag key is commented out won't work as expected, So I removed that default value. I actually prefer to set explicit default versioned tag like v0.17.0.

Using externally defined secrets(just above https://github.com/summerwind/actions-runner-controller#using-personal-access-token) is already in install guide in README, this is necessary anyway. I left checking .Values.authSecret.enabled for backward compatibility, but as existingSecret style is already generally used since https://github.com/helm/charts used this style, I recommend to use this way.
What if createManagerSecret is false and there's no managerSecretName defined? This chart will do nothing and I believe this will lead users to deploy an in-complete app.
I think setting default name in values.yaml is a good idea. I'll apply that. Thanks.

The docs on the chart.yaml is wrong is seems. I actually removed the appVersion attribute, see https://github.com/summerwind/actions-runner-controller/pull/296 for details why. The values.yaml should be getting used as the default, if the code references the appVersion it should be cleaned up as that isn't there anymore in the chart and the bundles values.yaml should be used instead for default values. I agree setting the version to a pinned value is better for a real deployment but having latest as the default makes sense so someone can just get going. I would expect them to configure their values.yaml for production if deploying the solution which includes version pinning in their values file.

Oh, I couldn't see that appVersion is not defined. Thanks for pointing this out :) It looks weird to me because there's no clue about target(or tested) app version is chart is written for. I agree appVersion is confusing sometime, but I think this has meaning that this provides minimum information about which version this chart targets or tested on.
I'm not a fan of latest, this might lead your app deployed with mismatched version and config. Generally that would be ok, but there's no guarantee that your app won't crash.
What if there's a major version bump with breaking change? App probably crash unless you catch new release and handle it ahead. I'm fine with using major or minor version alias tag(like v0.17), but not with latest.

If it can't find one then it will error and I think it already provides a useful error in that circumstance.

Do you mean this part?

but I think this has meaning that this provides minimum information about which version this chart targets or tested on.

Realistically this is an open source project with loose release versioning maintained by private individuals, when new charts are released the chart is not going to be tested against the stated appVersion and so I think it's a bit misleading using it to define the minimum app version this chart supports. That said, as you saw from my comments on https://github.com/summerwind/actions-runner-controller/pull/296 I'm not especially bothered if we really want to include an appVersion, it just seemed odd to me for this project specifically as helm list will be wrong most of the time.
If we do want to include it again I would just include a comment about it in the chart.yaml to say something like, so it is clear when it needs incrementing:
# This is the minimum summerwind/actions-runner-controller verison that this chart works with.
# Bump this when a new minimum version is needed for this chart version.

If we are going to go down the appVersion route then including | default (cat "v" .Chart.AppVersion | replace " " "") is probably the sensible way of setting the controller version used then.

Do you mean this part?

yeh, I would just have the chart set it to the defined managerSecretName value with a default of controller-manger. This way the key is generic and covers both use cases without complicated logic. If the secret doesn't exist on the cluster then you will get a very easy to understand error.

I think enabled is confusing, so I made create and name variables just like rbac or serviceAccounts. When create is true, secret will be created by chart, and use an external secret with the name otherwise. What about this?

@mumoshu up to you if you want default values to be derived from the values.yaml or you'd rather do it in the templates themselves.

enabled is what you typically see in Helm charts for a flag to determine if something is created or not, some examples (but you'll find them all over github):

https://github.com/jetstack/cert-manager/blob/efbd1a0095e104177f7dea9c0966d9d8b98d5f6f/deploy/charts/cert-manager/templates/cainjector-psp-clusterrole.yaml
https://github.com/prometheus-community/helm-charts/blob/3ab7f9b04e1ab5abd6c0b35268368422436ae3a6/charts/kube-prometheus-stack/ci/01-provision-crds-values.yaml
https://jfrog.com/blog/helm-charts-best-practices/

I'm not sure what is typically used in a circumstance like this where we are supporting creating the secret within the chart as well as actively supporting the secret externally created 🤷♂, if someone who has used Helm more than me could comment that would be wonderful!
I agree that create sounds better in this scenario, especially with the secret no longer necessarily being create by the chart but I do think covention over configuration is the right approach too so if enabled is accepted as the word for conditionally creating something then we should use that.

If we are moving from a generic auth secret implementation (a loop) in the template which was what the maintainer @mumoshu wanted when the work was originally done. Then you could probably make it more reliable. At the moment if the various github ids are provided as an int the secret will fail https://github.com/summerwind/actions-runner-controller/issues/241. This wasn't fixable because enabled is a boolean type. Now that you are targeting individual secrets you could probably make it be able to work with the value in the values.yaml is either an int or a string without it breaking.

@mumoshu I can't comment on all the webhook stuff, I haven't had a chance to use it yet so I have no idea

I see the examples you mentioned are little bit different to this.  When enabled is true, you use those resources or not at all otherwise(e.g. in cert-manager chart, when you set cainjector.enabled false, then you never use cainjector whether it's external or not). But for external secrets, secret is still used and also referenced in deployment, I see this is more similar to service account use cases in many public charts. When create is false, chart don't create service account, but reference external service account when it's name is defined in values.yaml

https://github.com/jetstack/cert-manager/blob/efbd1a0095e104177f7dea9c0966d9d8b98d5f6f/deploy/charts/cert-manager/templates/_helpers.tpl#L37
https://github.com/prometheus-community/helm-charts/blob/3ab7f9b04e1ab5abd6c0b35268368422436ae3a6/charts/kube-prometheus-stack/templates/_helpers.tpl#L59

create vs enable
Let's go with create.
Not saying enable is inappropriate, I can definitely agree create is a bit more appropriate in this case.
Some more context:

To me, create and enabled both works. The former seems to be occasionally used for toggling whether the chart should manage the resource, or the user brings one external to the chart. An example is serviceAccount.create which is seen in many charts. However, I saw some charts using someResource.enabled for toggling resource creation. So both works to me.
I also agree that enabled is commonly/mostly used for toggling a feature at once.

appVersion
I had been thinking about this for a while, and I'd say we'd better NOT use it for now.
See the original definition of appVersion:
https://v2.helm.sh/docs/developing_charts/#the-chart-yaml-file
It does say appVersion: The version of the app that this contains (optional). This needn't be SemVer. and our chart clearly doesn't "contain" or being tied to any specific version of our app(actions-runner-controller). So it is more than confusing alone. helm list showing the App Version regardless of the value of image.tag makes it a bit more confusing. At this point, I think we have no big motivation to use it.
That said, the below comment should better be reattached to the comment for image.tag in our values.yaml:
# This is the minimum summerwind/actions-runner-controller verison that this chart works with.
# Bump this when a new minimum version is needed for this chart version.
appVersion: 0.17.0

I'm not a fan of latest, this might lead your app deployed with mismatched version and config. Generally that would be ok, but there's no guarantee that your app won't crash.

That's really good point - I agree. Considering this and the above, how about making the default image.tag point to a specific semver tag instead?

Other than the above three points, LGTM. Thank you so much for your support @kimxogus and @callum-tait-pbx!

Thanks for reviews @callum-tait-pbx and @mumoshu !
I removed appVersion. Also I forgot to mention that I removed githubWebhookServer.image because both controller and webhook server uses the same image.

Also I forgot to mention that I removed githubWebhookServer.image because both controller and webhook server uses the same image.

Okay- To clarify, the original intention was to build a separate image for the webhook server and allow using that. But I'll just re-add it on demand.


Bug in pySB1.6.0 exporting expressions as Kappa

In pySB 1.6.0 there seems to be an issue exporting expressions (at least as Kappa). If the name of one term in the expression is the stem of the name of a subsequent term, for example: ‘cell_volume’ and ‘cell_volume_fraction’ - the second term gets mangled in the export as shown below. When I change the names of the expression terms to break this condition, the export seems to work as expected.
--- pySB code
Parameter('avogadro', 6.022e23)
Parameter('cell_volume’, 2.25e-12)
Parameter('cell_volume_fraction’, 0.001)
Expression('stochastic', avogadro * cell_volume * cell_volume_fraction)
--- output kappa code
%var: 'stochastic' 'avogadro'*'cell_volume'*'cell_volume'_fraction

--- pySB code
Parameter('avogadro', 6.022e23)
Parameter('alpha', 2.25e-12)
Parameter('beta', 0.001)
Expression('stochastic', avogadro * alpha * beta)
--- output kappa code
%var: 'stochastic' 'avogadro'*'alpha'*'beta'

Thanks for your report - there was indeed a bug in PySB's kappa exporter. I've created a fix which will be incorporated into the next release.


Fix adminjs issues

This fixes issue #111 for the admin page, but there is still an issue with errors on other pages (I'll open a separate issue)
This allows the update button to work, but there the update button does not close the update dialog

Superceeded by PR #117


Add scheduled backups to CNPG

  ...
  backup:
    barmanObjectStore:
      destinationPath: S3_BACKUP_KUSTOMIZED
      s3Credentials:
        accessKeyId:
          name: aws-creds
          key: ACCESS_KEY_ID
        secretAccessKey:
          name: aws-creds
          key: ACCESS_SECRET_KEY
      wal:
          compression: gzip
      data:
          compression: gzip
          jobs: 1
      tags:
        backupRetentionPolicy: "expire"
      historyTags:
        backupRetentionPolicy: "keep"
    retentionPolicy: "30d"

  primaryUpdateStrategy: unsupervised

  storage:
    size: 10Gi
---
apiVersion: postgresql.cnpg.io/v1
kind: ScheduledBackup
metadata:
  name: scheduled-backup
spec:
  schedule: "1 0 0 * * 0"
  suspend: false
  immediate: true
  backupOwnerReference: self
  cluster:
    name: db

Prod backups should be performed daily
{{cookiecutter.project_slug}}/k8s/prod/kustomization.yaml
- patch: |-
    - op: replace
      path: /spec/schedule
      value: "1 0 0 * * *"
  target:
    kind: ScheduledBackup
    name: scheduled-backup


Add org dropdown to import overlay

As a user importing a dashboard or a task,
I should have the ability to choose the org in which to import the resource

blocked on #12496


Add Dependabot

To keep on top of our dependency updates, we should automate it with
Dependabot.

I'd like to merge it. @AlexanderAsmakov your thoughts?

LGFM!


Boot not working with Jetpack 4.5.1

After watching the latest Jetson AI labes, where the new Boot from Usb was announced i moved over to the github to give it a try. Unfortunally it doesn't work for me. After powerup i get the nvidea logo with  a SD-card image with a red dash, meaning no SD card inserted, afterward nothing happening.

Which Jetson are you using, what version of JetPack, and what does your extlinux.conf file look like?

When using the script  ./partUUID.sh to get the PARTID is return a empty string. Also the device was listed as /dev/sda instead of /dev/sda1. I ignored this first and used the disk UUID instead. (RTFM was well done be me, sorry). I started over again and installed gparted to create the partion. This time the device was listed as /dev/sda1 and the script now also return a partUUID. When is used that in the extlinux.conf file, the boot from disk worked fine. I started with a fresh SSD drive, maybe that could ne the reason for the weird behaviour? Thank for youre manual and sorry for bothering you.


ARM64: Build Pipeline -> Dependencies

Meta Issue: #1028
Build Pipeline -> Dependencies
This issue covers the validation of the dependencies within the build pipeline of Garden Linux on ARM64 / AARCH64 architecture.
Tests
Within this issue the following components will be validated and tested:

Build Pipeline

Dependencies
Packages
Podman Support
Secure Boot

Successfully tested and validated.


[WIP] Insert category field to TI db and TI rules and all the detected event structures

Close #315
Close #311
Added category field to ...

TI db and TI rules
All the detected event structures

Merged some detected event structures that share the same fields:

FtpPlainTextFields and BlockListFtpFields -> FtpEventFields
LdapPlainTextFields and BlockListLdapFields -> LdapEventFields
TorConnectionFields and NonBrowserFields -> HttpEventFields

Migration code migrate_0_28_to_0_29_0() is modified:

I've modified the migration code of previous version because the recently released version of review-database is 0.27.x and 0.29.0 and the later versions are not released yet.

Summary by CodeRabbit

New Features

Introduced new event types: BlockListBootp, BlockListDhcp, and SuspiciousTlsTraffic.
Added a category field to detected events for enhanced categorization.
Expanded event data structures with additional fields for richer context (e.g., orig_l2_bytes, resp_l2_bytes).
Created new structures for handling DHCP and BOOTP events.
Enhanced existing structures to include a category field across various event types for dynamic categorization.

Bug Fixes

Updated event handling logic to accommodate new event types and ensure correct categorization.

Documentation

Updated changelog and comments to reflect changes and provide clarity on new functionalities.

Style

Improved formatting for better readability in configuration and data structure definitions.

Tests

Added new test cases to validate the functionality of new event types and categorization features.

Chores

Incremented version number to 0.30.0-alpha.1 to reflect the latest updates and improvements.

@syncpark, just wanted to check in on the status of this PR. I noticed that it was originally intended to close #315 and #311, but it looks like those issues have since been closed by other PRs. Is this PR still relevant, or can we safely close it?


Rate limits documentation

Problem
/flow.access.AccessAPI/GetEventsForHeightRange rate limit reached, please retry later.

Steps to Reproduce
Spam API calls.
Acceptance Criteria
Should report what is current rate limit for calling API or API endpoint should exist to report current rate limiting.
Context
I was playing around with blockchain events processor and since API is limited some calls must be made quite often (due to limited API functionality). It is unclear how often calling API is still acceptable.

Unfortunately SDK can't display this data since it's a configuration dependent on the access node. We should update our documentation to show what are rate limits. Closing in favor of https://github.com/onflow/flow/issues/840


System "cl-edn" not found

I've cloned the repo into my ~/quicklisp/local-projects/ dir and started a slime REPL, however when I run quickload it isn't able to find the system:
* (ql:quickload :cl-edn)

debugger invoked on a QUICKLISP-CLIENT:SYSTEM-NOT-FOUND in thread
#<THREAD "main thread" RUNNING {10005505B3}>:
  System "cl-edn" not found

Can you do ls -ld ~/quicklisp/local-projects and ``ls -l ~/quicklisp/local-projects/cl-edn`?

In your slime repl, try running (ql:register-local-projects) before loading :cl-edn

Also, I just pushed some changes that fix a (probably unrelated) issue.  It turns out that you'll also need to clone https://github.com/fiddlerwoaroof/fwoar.lisputils.git into local-projects before anything works.

Hmm, I just noticed that the group in the second directory listing windows group. Are you running in WSL or on Windows otherwise?

Nope, I'm on macOS.
After futzing around with it some more, I figured out the issue: I had previously installed SBCL + quicklisp on their own, and then switched to using roswell. roswell installs quicklisp and configures it's local projects to live under ~/.roswell/local-projects/.
Sorry for the issue! I'm very new to the Lisp ecosystem.
I'm getting a compile error now but I'll open a separate issue for that.


PandoraTV.KMPlayer64X version 2<IP_ADDRESS>

[ ] Have you signed the Contributor License Agreement?
[ ] Have you checked that there aren't other open pull requests for the same manifest update/change?
[ ] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.2 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

/AzurePipelines cancel

This manifest have to install interactively an will not pass Azure Pipelines.
Convert it as draft until we improve the manifest and could be installed without user's attention.
Related https://github.com/microsoft/winget-pkgs/issues/890#issuecomment-1320877772.

Unable to achieve the following goal. Simply closed this pull request.

PandoraTV.KMPlayer64X needs Microsoft.VCRedist.2010.x86 as a dependency, which is not supported by winget.exe at the moment.
PandoraTV.KMPlayer64X itself HAVE TO manually select the language of installation process. It can't be silenced by -h or --silent switch.

Waiting for another one can create a better manifest for us.


PackageLoading: anchor relative paths for Windows

We currently cannot use .. as a header search path for Windows even though it may be contained within the package root.  This is due to the fact that the path itself was unanchored, and a raw .. would be treated as the drive root which will almost always be outside of the package root.  Construct the absolute path relative to the target root rather than appending, permitting us to form a well-formed path which can be checked for ancestry.

@swift-ci please test

@swift-ci please smoke test

@swift-ci please smoke test

@swift-ci please smoke test

@swift-ci please test Windows platform

@swift-ci please test Windows platform


优化字数限制变化更新

🤔 这个 PR 的性质是？

[ ] 日常 bug 修复
[ ] 新特性提交
[ ] 文档改进
[ ] 演示代码改进
[ ] 组件样式/交互改进
[ ] CI/CD 改进
[ ] 重构
[ ] 代码风格优化
[ ] 测试用例
[ ] 分支合并
[ ] 其他

🔗 相关 Issue

https://github.com/Tencent/tdesign-flutter/issues/384
💡 需求背景和解决方案

📝 更新日志

fix(组件名称): 处理问题或特性描述 ...

[ ] 本条 PR 不需要纳入 Changelog

☑ 请求合并前的自查清单
⚠ 请自检并全部勾选全部选项。⚠

[ ] 文档已补充或无须补充
[ ] 代码演示已提供或无须提供
[ ] Changelog 已提供或无须提供

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.v_szheshi seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Add missing "Byron Assets" heading to OpenAPI docs

Issue Number
ADP-603
Overview
All the /byron-wallets/{walletId}/assets endpoints were missing from the OpenAPI docs. This fixes it.
Comments
Rendered version

whoops.

bors retry

bors r+

The documentation was always there, if you can read swagger.yaml files :stuck_out_tongue_closed_eyes:


Fix *-solaris targets

Fixes #1424.
Adapted from https://github.com/rust-lang/rust/pull/108951 and https://github.com/rust-lang/rust/pull/81229 (with some minor changes to satisfy ShellCheck and account for broken symlinks).
This PR also renames x86_64-sun-solaris to x86_64-pc-solaris, as the former was deprecated in Rust 1.52.0 and removed in Rust 1.76.0, making this a breaking change.

/ci try --target *solaris*

meh, I thought I fixed that...
/ci try --target *solaris


Attempt to get GCM 11.4 to work for ADAS

This initial attempt to get ADAS to use GCM 11.4 now works for main ADAS - cycling and forecasts, but with restrictions.
Two keep components fail:

gcmPert

NNR in GAAS

This branch increments an attempt to fix (2) - but not work yet.
To test (1) please follow he following:
i) build ADAS from this branch
ii)	Create an empty dir
iii)	Cd to the empty dir
ln -s /gpfsm/dnb05/projects/p139/rtodling/tmp.39107/sens.20230722.000000/* .
iv)	mpirun  -np 216 $YOURBIN/GEOSgcmPert.x
The error the Pert gets is:
AGCM_PERTInitialize The current TIME is  2023/07/18 00:00
CFIO: Reading traj1/x50Rrt.traj.lcv.20230718_0000z.nc4 at     20230718
0
CFIO: Reading traj1/x50Rrt.traj.lcv.20230718_0000z.nc4 at     20230718
0
pe=00111 FAIL at line=00452    Shmem_implementation.F90
pe=00111 FAIL at line=00631    Shmem_implementation.F90
pe=00090 FAIL at line=00452    Shmem_implementation.F90
pe=00090 FAIL at line=00631    Shmem_implementation.F90

I'll ping @atrayano as well since he and Ben are the two main Shmem people I think of.
As for the GAAS NNR, do you know which one? I remember when I was helping @patricia-nasa with CMake'ing up AeroApps there were a couple of them...

The shmem error points to code like:
      if(.not.MAPL_ShmInitialized) then
         _RETURN(MAPL_NoShm)
      endif

so I'm guessing Pert needs some update to make it happy as it's like it's trying to use shmem before it's initialized.


Update provider dependencies

Description of your changes
This PR updates the provider dependencies and version in context of switching to the new provider families.
I have:

[x] Read and followed Upbound's contribution process.
[x] Run make reviewable to ensure this PR is ready for review.
[ ] Added backport release-x.y labels to auto-backport this PR, as appropriate.

How has this code been tested

/test-examples


Initial value takes a bit to be properly positioned

Steps to reproduce
Demo: http://angular-slider.github.io/angularjs-slider/
See Toggle slider example
Expected behaviour
This "flicker" shouldn't happen.
Actual behaviour
It happens

Unfortunately, this is due to how angular works. We can't measure the slider dimension before rendering it, thus we can't know where to position the knob up-front.


chore: remove obsolete editorconfig setting

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@75d2e5d). Click here to learn what that means.
Patch has no changes to coverable lines.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff            @@
##             main      #151   +/-   ##
========================================
  Coverage        ?   100.00%
========================================
  Files           ?        20
  Lines           ?       163
  Branches        ?        35
========================================
  Hits            ?       163
  Misses          ?         0
  Partials        ?         0

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Adapt docker installation to new travis images

Remove travis environment, no longer needed

Signed-off-by: Dominik Jall<EMAIL_ADDRESS>

Fixes #1027

rebase and merge with 0a4b14a9ee2dadae62ac4fd79fe23841b6d5165c


[vcpkg] Ignore missing ports in VCPKGs installed database

Computing installation plan...
Error: while loading cmake:x64-windows-static: Port definition not found.
Please run "vcpkg remove cmake:x64-windows-static" and re-attempt.

Is just anoying getting these kind of messages when I reuse vcpkg for different PRs/branches with additional ports.
Or give me an option like --ignore-missing

Related issue: https://github.com/microsoft/vcpkg/issues/10119 .

I think this behavior was fixed.

Unfortunately I am afraid the problem was reintroduced recently, see https://github.com/microsoft/vcpkg/issues/15836 . However it is tracked there, so probably there is no need to re-open this issue.


Lc alink text fix

<your comments for this PR go here >
Have you read Terra's Contributing Guide lately? If not, do that first.
I, the developer opening this PR, do solemnly pinky swear that:

[ ] PR is labeled with a Jira ticket number and includes a link to the ticket
[ ] PR is labeled with a security risk modifier [no, low, medium, high]
[ ] PR describes scope of changes

In all cases:

[ ] Get a minimum of one thumbs worth of review, preferably 2 if enough team members are available
[ ] Get PO sign-off for all non-trivial UI or workflow changes
[ ] Verify all tests go green
[ ] Squash and merge; you can delete your branch after this
[ ] Test this change deployed correctly and works on dev environment after deployment

I think this branch needs to be rebased from the latest develop.


Turbolinks should allow user control of progress bar delay

Turbolinks currently displays the progress bar for requests that take 500ms. I believe that this value should be user-configurable.
While fast page loads are great, 500ms is more than enough to notice a delay. This can lead to a frustrating user experience, as they believe that their click has not worked for half a second before the progress bar shows up. The majority of my page loads do take under 500ms (thankfully), but those that don't can be frustrating for users.
I know that other people obviously has different opinions, so I believe that this option should be (in some way) configurable, either through the approach used by Turbolinks classic, or through a <meta> tag. I'd be happy to submit a patch if the maintainers agree with me.
I know there was some past discussion of ideas similar to this in #44, but it focused more on the virtues of a JS-specific API rather than the ability to set this delay in general.

I’m open to making the 500ms delay configurable. If you’d like to explore that with a pull request, please go ahead!
I don’t think a page-specific setting is appropriate. I can’t see why you’d want the delay to be variable depending on the page, so I’d suggest making it configurable with JavaScript instead of a <meta> tag.
Note that if the app is running inside the iOS or Android adapters, Turbolinks.controller.adapter will not be an instance of Turbolinks.BrowserAdapter, and the app won’t have a progress bar at all. Whatever API we decide on for setting this value will need to work regardless of the current adapter.

Would it be acceptable if the API for setting the progress bar delay simply did nothing on iOS and Android?

Yeah, it should do nothing. Just need to make sure it doesn’t require the user to write a conditional in order to avoid an exception.


Support automatic detection of Kotlin-based subprojects

Related to #37, a root project that is configured by a *.gradle.kts file should automatically detect similar files in subprojects.

Possibly related is importing a module.
Following the sample README.md for importing a project on 0.2.0 works perfectly.
Reproduction steps:
Using IntelliJ 16.1.3 with https://teamcity.jetbrains.com/guestAuth/repository/download/bt345/805470:id/kotlin-plugin-1.1.0-dev-1303.zip

Create a new Empty Project
Open the File -> Project Structure window
Click the "Add" (plus sign) button and select Import Module
Select hello-kotlin project

Expected: Autocomplete/classpath detection in build.gradle.kts
Actual:

Not that this means there isn't any connection, but the issue I observed was Gradle independent of IntelliJ.

I also expected to be able to configure just a subproject (for now) as a *.gradle.kts file, while leaving the root project as a regular Groovy script, but I've yet to figure out how to make that work. I'm basically seeing what @mkobit screenshotted. I'll keep fiddling with my settings.gradle file for now.

Fixed by #37.


MemoryFileSystemError

const SERVER = require("./www/server.bundle").default;
const express = require("express");
const webpack = require('webpack');
const webpackDevMiddleware = require('webpack-dev-middleware');
const webpackHotMiddleware = require('webpack-hot-middleware');
// const webpackHotServerMiddleware = require('webpack-hot-server-middleware');
const app = express();
const PORT = 3000;
const compiler = webpack(require('./build/webpack/prod.js'));
app.use(webpackDevMiddleware(compiler));
app.use(webpackHotMiddleware(compiler.compilers.find(compiler => compiler.name === 'client')));
// app.use(webpackHotServerMiddleware(compiler));
app.use(SERVER);
app.listen(PORT, console.log.bind("listening at http://localhost:" + PORT));

If I uncomment the lines (webpackHotServerMiddleware itself) above, my build errors
/home/cescoferraro/code/go/src/github.com/cescoferraro/spotify/node_modules/webpack-dev-middleware/node_modules/memory-fs/lib/MemoryFileSystem.js:112
			throw new MemoryFileSystemError(errors.code.EISDIR, _path);
         ^
Error
    at MemoryFileSystem.readFileSync (/home/cescoferraro/code/go/src/github.com/cescoferraro/spotify/node_modules/webpack-dev-middleware/node_modules/memory-fs/lib/MemoryFileSystem.js:112:10)
    at MultiCompiler.multiCompiler.plugin.multiStats (/home/cescoferraro/code/go/src/github.com/cescoferraro/spotify/node_modules/webpack-hot-server-middleware/src/index.js:119:33)
    at MultiCompiler.applyPlugins (/home/cescoferraro/code/go/src/github.com/cescoferraro/spotify/node_modules/tapable/lib/Tapable.js:25:14)
    at MultiCompiler.<anonymous> (/home/cescoferraro/code/go/src/github.com/cescoferraro/spotify/node_modules/webpack/lib/MultiCompiler.js:76:10)
    at Compiler.applyPlugins (/home/cescoferraro/code/go/src/github.com/cescoferraro/spotify/node_modules/tapable/lib/Tapable.js:25:14)
    at Watching._done (/home/cescoferraro/code/go/src/github.com/cescoferraro/spotify/node_modules/webpack/lib/Compiler.js:93:17)
    at /home/cescoferraro/code/go/src/github.com/cescoferraro/spotify/node_modules/webpack/lib/Compiler.js:76:18
    at Compiler.emitRecords (/home/cescoferraro/code/go/src/github.com/cescoferraro/spotify/node_modules/webpack/lib/Compiler.js:350:37)
    at /home/cescoferraro/code/go/src/github.com/cescoferraro/spotify/node_modules/webpack/lib/Compiler.js:59:19
    at /home/cescoferraro/code/go/src/github.com/cescoferraro/spotify/node_modules/webpack/lib/Compiler.js:343:11
    at next (/home/cescoferraro/code/go/src/github.com/cescoferraro/spotify/node_modules/tapable/lib/Tapable.js:118:11)
    at Compiler.<anonymous> (/home/cescoferraro/code/go/src/github.com/cescoferraro/spotify/node_modules/webpack/lib/performance/SizeLimitsPlugin.js:115:3)
    at Compiler.applyPluginsAsyncSeries1 (/home/cescoferraro/code/go/src/github.com/cescoferraro/spotify/node_modules/tapable/lib/Tapable.js:122:13)
    at Compiler.afterEmit (/home/cescoferraro/code/go/src/github.com/cescoferraro/spotify/node_modules/webpack/lib/Compiler.js:340:8)
    at Compiler.<anonymous> (/home/cescoferraro/code/go/src/github.com/cescoferraro/spotify/node_modules/webpack/lib/Compiler.js:335:14)
    at /home/cescoferraro/code/go/src/github.com/cescoferraro/spotify/node_modules/webpack/node_modules/async/dist/async.js:356:16

I changed app.use(webpackHotServerMiddleware(compiler)) to
app.use(webpackHotServerMiddleware(compiler, {
	chunkName: 'server'
}));

And now I get. Webpack HMR is working without it
TypeError: Cannot read property 'send' of undefined
    at default_1 (/home/cescoferraro/code/go/src/github.com/cescoferraro/spotify/www/server.bundle.js:59220:13)
    at getServerRenderer (/home/cescoferraro/code/go/src/github.com/cescoferraro/spotify/node_modules/webpack-hot-server-middleware/src/index.js:47:22)
    at MultiCompiler.multiCompiler.plugin.multiStats (/home/cescoferraro/code/go/src/github.com/cescoferraro/spotify/node_modules/webpack-hot-server-middleware/src/index.js:121:30)
    at MultiCompiler.applyPlugins (/home/cescoferraro/code/go/src/github.com/cescoferraro/spotify/node_modules/tapable/lib/Tapable.js:25:14)
    at MultiCompiler.<anonymous> (/home/cescoferraro/code/go/src/github.com/cescoferraro/spotify/node_modules/webpack/lib/MultiCompiler.js:76:10)
    at Compiler.applyPlugins (/home/cescoferraro/code/go/src/github.com/cescoferraro/spotify/node_modules/tapable/lib/Tapable.js:25:14)
    at Watching._done (/home/cescoferraro/code/go/src/github.com/cescoferraro/spotify/node_modules/webpack/lib/Compiler.js:93:17)
    at /home/cescoferraro/code/go/src/github.com/cescoferraro/spotify/node_modules/webpack/lib/Compiler.js:76:18
    at Compiler.emitRecords (/home/cescoferraro/code/go/src/github.com/cescoferraro/spotify/node_modules/webpack/lib/Compiler.js:350:37)
    at /home/cescoferraro/code/go/src/github.com/cescoferraro/spotify/node_modules/webpack/lib/Compiler.js:59:19
    at /home/cescoferraro/code/go/src/github.com/cescoferraro/spotify/node_modules/webpack/lib/Compiler.js:343:11
    at next (/home/cescoferraro/code/go/src/github.com/cescoferraro/spotify/node_modules/tapable/lib/Tapable.js:118:11)
    at Compiler.<anonymous> (/home/cescoferraro/code/go/src/github.com/cescoferraro/spotify/node_modules/webpack/lib/performance/SizeLimitsPlugin.js:115:3)
    at Compiler.applyPluginsAsyncSeries1 (/home/cescoferraro/code/go/src/github.com/cescoferraro/spotify/node_modules/tapable/lib/Tapable.js:122:13)
    at Compiler.afterEmit (/home/cescoferraro/code/go/src/github.com/cescoferraro/spotify/node_modules/webpack/lib/Compiler.js:340:8)
    at Compiler.<anonymous> (/home/cescoferraro/code/go/src/github.com/cescoferraro/spotify/node_modules/webpack/lib/Compiler.js:335:14)

@cescoferraro ah yeah, options.chunkName will allow you to specify the name of the server chunk if not using Webpack's default output name of 'main' -- been meaning to document that.
Looking at your second error I'd presume your server bundle is failing to call res.send -- perhaps because your server bundle is exporting middleware directly instead of exporting a function which in turn returns the middleware, i.e. export default (req, res, next) => res.send('Hello World.'); instead of export default () => (req, res, next) => res.send('Hello World.');?

@richardscarrott head shot! export default  () => (request, response) => {} did the trick!
webpack-hot-server-middleware is just what I wanted! Maybe you could answer my question on SO so more people could get to know great this piece of code is!
Another thing. The README production snippet seams to generate lots of errors on my setup.
https://github.com/60frames/webpack-hot-server-middleware/blame/master/README.md#L148-L152
Somewhy webpack does not like to bundle itself. and importing a webpack config file from the bundle  ends up requiring webpack a lot. I had to keep the production/hmr files separated.

@cescoferraro Glad to hear it's working for you! I'll reply to your SO question shortly :)
Re: the README production snippet -- I don't think your bundle should need to require 'webpack'? If you push up a repo I can review it to see what's going on.

@richardscarrott  const config = require('./webpack.config.js'); will always require webpack, unless you dont use any plugins like new webpack.NamedModulesPlugin()new webpack.NoErrorsPlugin() that would require you to require webpack.
I forgot the error I was getting. I will try again later today.
Here its my build: https://github.com/cescoferraro/spotify

@cescoferraro there shouldn't be any need to bundle webpack.config.js either... I see you've got two entry points in your server webpack config, one for the server renderer middleware and another which is the express app itself -- the intention of the production snippet in the README is to only bundle the server renderer middleware and just run the non-bundled express app, e.g.
.
├── build
│   ├── client.bundle.js // renderToDom
│   └── server.bundle.js // renderToString
├── express.js
└── src
    ├── client.js // becomes client.bundle.js
    └── server.js // becomes server.bundle.js

Then you'd just run the non-bundled express.js -- node express which would contain the production snippet from this README.

@richardsarrott That's what I am doing. I just created the express chunk to see if could bundle everything with webpack to get cool syntax, but you are right. It's not worth it.

@cescoferraro if you still want to use esNext / Typescript you could transpile your code using the babel cli / tsc without bundling, i.e. just convert express.ts into express.js etc.

I ended up doing
entry: {
	server: [env === "production" ? "./src/server" : "./src/middleware"]
},

So with NODE_ENV=production I endup with a single server bundle with all the dependencies. Its  especially good for docker, because instead of doing
FROM  mhart/alpine-node:6
RUN npm init -y
RUN npm i express morgan
WORKDIR /srv/spotify
ADD src/hot.js /srv/spotify/hot.js
ADD www/ /srv/spotify/www
CMD ["node","hot.js"]

I can
FROM  mhart/alpine-node:base-6
WORKDIR /srv/spotify
ADD www/ /srv/spotify/www
CMD ["node","www/server.bundle.js"]

For this the client/middleware/server.tsx files live inside the src dir while I keep a hot.js file on my root.
Not having hmr logic inside the app source code makes sense for me.


bossa: add support for specifying the port

Now that we have a newer version of bossa in the SDK we can use a
version where there -p option works properly.
Signed-off-by: Kumar Gala<EMAIL_ADDRESS>

Looks fine to me based on the BOSSA documentation, but I don't have hardware to test on.


[FEATURE] Add more Backend Frameworks

Add more Backend Languages Framework
Currently, there are only 3 backend frameworks added in the backend roadmap's page. More needs to be added.
Frameworks to be added

[ ] Koa
[ ] Laravel
[ ] Slim
[ ] ASP.NET
[ ] and ASP.NET Core
[ ] Gin
[ ] GORM
[ ] Spring
[ ] Spring Boot
[ ] Rust and Rocket
[ ] .NET Core
[ ] .NET Framework.

Task

create sections for each frameworks in the Frameworks.js file .
add relevant resources for each frameworks.

Things to Note

Read our  contributing guidelines before making your contribution.
only one language per person per pull request.
be as descriptive as possible when naming your links and do not forget to include the author or creator of the content.
Eg. 'Build a food recipe app with fetch API and vanilla JavaScript. ~ GeetProbin'.
do not duplicate resources or sections.
follow the code format or template used.
include the link to the section in the Backend sidebar component file.

Hello @Timonwa do we tweet about this so people can know about it and possibly contribute.

Yes we can. I have been thinking about shceduling tweets to post automatically using a scheduling tool, but I wanted to add more issues first.

Hello, I am a newbie to Open Source, if this issue is still open can I add a framework, this would be a great way to learn for me

Can I add Django Franework

It has been added already. The ones yet to be added are listed in the issue.


[YUNIKORN-2491] Implemented hotlinking to applications page using the query parameters

What is this PR for?
Application details can be hot-linked by passing query parameters of partition, queue, and applicationId. This will autoselect the application and display all of the details.
What type of PR is it?

[ ] - Bug Fix
[x] - Improvement
[ ] - Feature
[ ] - Documentation
[ ] - Hot Fix
[ ] - Refactoring

What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-2624
How should this be tested?
With existing json-db.json these params can be used for testing: ?partition=cluster-2&queue=root.b&applicationId=application-sleep-0002

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 38.77%. Comparing base (440f03b) to head (92b14fa).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #191   +/-   ##
=======================================
  Coverage   38.77%   38.77%
=======================================
  Files           2        2
  Lines          49       49
=======================================
  Hits           19       19
  Misses         27       27
  Partials        3        3

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


allporncomics doesn't work for me anymore

Ripme version: v1.7.93
Java version: Version 8 Update 271
Operating system: Windows 10 Version 1909
Exact URL you were trying to rip when the problem occurred: https://allporncomic.com/porncomic/meet-the-neighbors-rabies-t-lagomorph/
Please include any additional information about how to reproduce the problem:

Expected Behavior
Pics from the gallery should queue and download.
Actual Behavior
I get a red error at the top sayig "Error: no protocol:". I have tried to download the comics individually but the same result shows. I have not downloaded the comics before. Other valid websites still work, but allporncomics has recently shown this error.
Downloading https://allporncomic.com/porncomic/meet-the-neighbors-rabies-t-lagomorph/
Rip complete, saved to C:\Users\aqibn\OneDrive\Documents\rips\allporncomic_meet-the-neighbors-rabies-t-lagomorph
Downloading https://allporncomic.com/porncomic/meet-the-neighbors-rabies-t-lagomorph/2-meet-the-neighbors/
Rip complete, saved to C:\Users\aqibn\OneDrive\Documents\rips\allporncomic_meet-the-neighbors-rabies-t-lagomorph_2-meet-the-neighbors
no protocol:
Downloading https://allporncomic.com/porncomic/meet-the-neighbors-rabies-t-lagomorph/1-meet-the-neighbors/
Rip complete, saved to C:\Users\aqibn\OneDrive\Documents\rips\allporncomic_meet-the-neighbors-rabies-t-lagomorph_1-meet-the-neighbors
no protocol:
Downloading https://allporncomic.com/porncomic/meet-the-neighbors-rabies-t-lagomorph/0-meet-the-neighbors/
Rip complete, saved to C:\Users\aqibn\OneDrive\Documents\rips\allporncomic_meet-the-neighbors-rabies-t-lagomorph_0-meet-the-neighbors
no protocol:

I am also getting the 'no protocol:' error. Here's an example error with debug messages:
Retrieving https://allporncomic.com/porncomic/the-hillbilly-farm-wc-tf/37-the-hillbilly-farm/
Found image url #1:
Got exception while running ripper:
java.net.MalformedURLException: no protocol:
at java.net.URL.(Unknown Source)
at java.net.URL.(Unknown Source)
at java.net.URL.(Unknown Source)
at com.rarchives.ripme.ripper.AbstractHTMLRipper.rip(AbstractHTMLRipper.java:130)
at com.rarchives.ripme.ripper.AbstractRipper.run(AbstractRipper.java:616)
at java.lang.Thread.run(Unknown Source)

Having the same issue. No protocol error.
Navigating the site pages manually, I have noticed that they no longer displaying all the pics at once, instead release more at certain points as you navigate down the page. This is a new behavior.

Same problem here.. Hope the dev will fix this soon.


difftastic: 0.40.0 -> 0.41.0

Diff: https://github.com/wilfred/difftastic/compare/0.40.0...0.41.0
Changelog: https://github.com/Wilfred/difftastic/raw/0.41.0/CHANGELOG.md
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 209806 run on aarch64-linux 1

1 package built:

difftastic


Pull Request Reviews: parse signoffs out of GitHub reviews

This adds a new reviews table, and the various necessary models, getters, setters, etc. to store and retrieve them from the metrics DB.
This also adds the necessary logic to parse signatures (e.g. CR, QA, dev_block) out of the review text, in case people use a GitHub review to sign off on a pull.
QA
I tested this pretty extensively locally, but it's probably a good idea to make sure that signatures in Comments and Reviews play nicely together. Editing and deleting comments and reviews (I couldn't figure out how to delete a review), etc. works as expected.
Closes #146
CC @evannoronha

CR :barber: LGTM

Ha, we can use this pull to test itself:

CR :corn:

@davidrans Can I test this on cominor or should I test it locally first?
If I test it on cominor, how can I run the migrations in metrics db?

@addison-grant and I tested this on https://pulldasher-dev.cominor.com/ using cominor db.

Made a test pull request and tested using the Review Changes (Comment/Approve/Request changes).  Also checked testing with regular comments. All worked fine ✅

Also confirmed that reviews are saved in the reviews table in Metrics db ✅

  reviews table
mysql> SELECT * FROM `reviews` ORDER BY `date` DESC LIMIT 0,1000;
+-------------------------+-----------+--------+-------------------+-------------------+---------------+------------+
| repo                    | review_id | number | body              | state             | user          | date       |
+-------------------------+-----------+--------+-------------------+-------------------+---------------+------------+
| iFixit/server-templates | 675653099 |   3014 | CR :barber:       | approved          | scbarber      |<PHONE_NUMBER> |
| iFixit/pulldasher       | 675653069 |    219 | un_dev            | COMMENTED         | addison-grant |<PHONE_NUMBER> |
| iFixit/pulldasher       | 675652958 |    219 | CR                | COMMENTED         | batbattur     |<PHONE_NUMBER> |
| iFixit/server-templates | 675652848 |   3015 | Nice! CR 2⃣      | approved          | djmetzle      |<PHONE_NUMBER> |
| iFixit/pulldasher       | 675652653 |    219 | dev_bloc          | COMMENTED         | batbattur     |<PHONE_NUMBER> |
| iFixit/pulldasher       | 675651873 |    219 | QA                | COMMENTED         | addison-grant |<PHONE_NUMBER> |
| iFixit/pulldasher       | 675651333 |    219 | CR                | COMMENTED         | addison-grant |<PHONE_NUMBER> |
| iFixit/pulldasher       | 675650395 |    219 | CR                | COMMENTED         | batbattur     |<PHONE_NUMBER> |
| iFixit/pulldasher       | 675649000 |    219 | C                 | COMMENTED         | batbattur     |<PHONE_NUMBER> |
| iFixit/pulldasher       | 675647847 |    219 | test              | APPROVED          | batbattur     |<PHONE_NUMBER> |
| iFixit/pulldasher       | 675646839 |    219 | test              | APPROVED          | batbattur     |<PHONE_NUMBER> |
| iFixit/pulldasher       | 675646148 |    219 | test              | CHANGES_REQUESTED | batbattur     |<PHONE_NUMBER> |
| iFixit/pulldasher       | 675644384 |    219 |                   | COMMENTED         | batbattur     |<PHONE_NUMBER> |
| iFixit/pulldasher       | 675643841 |    219 | test              | COMMENTED         | batbattur     |<PHONE_NUMBER> |
| iFixit/pulldasher       | 675643233 |    219 |                   | COMMENTED         | addison-grant |<PHONE_NUMBER> |
| iFixit/pulldasher       | 675641425 |    219 |                   | APPROVED          | batbattur     |<PHONE_NUMBER> |
| iFixit/pulldasher       | 675641124 |    219 | test              | CHANGES_REQUESTED | batbattur     |<PHONE_NUMBER> |
| iFixit/pulldasher       | 675639895 |    219 |                   | APPROVED          | batbattur     |<PHONE_NUMBER> |
| iFixit/pulldasher       | 675639720 |    219 |                   | COMMENTED         | addison-grant |<PHONE_NUMBER> |
+-------------------------+-----------+--------+-------------------+-------------------+---------------+------------+
19 rows in set (0.00 sec)

QA 👍


Not working if iTerm2 sends text at start

Is there any way to get Kube-Solo to use the window started by tmux and/or be able to configure a non default iTerm2 profile which will be used?

The default Terminal would be easier to be used instead of tmux
The required terminal app could be stored in some settings file and used opening shell scripts

Indeed. Trying to make it work with tmux seems like a bit of a PITA. Another option would be to see if a flag can be passed to open -a iTerm.app "$1"/first-init.command to tell iTerm to ignore the "send text at start" setting. That would probably be ideal. What do you think?

Looks like another way would be to chose a profile called "kube-solo" if it exists and otherwise use the default profile: https://www.iterm2.com/documentation-scripting.html. That way, I could create a "kube-solo" profile which doesn't send text at start.

Oh, looks like there will be a new option in iTerm to "disabled text at start when opening a script" https://gitlab.com/gnachman/iterm2/issues/5288. 👍

ok, cool


Convert signature hash type to enum class

Gives signature hash types a typename, thus adding type safety.
This is a less intrusive alternative to the SigHashType enum wrapper class introduced by ABC. Also this is an alternative to BU's approach to keep both the enum and introduce ABC's class, as done in their DSV PR https://github.com/BitcoinUnlimited/BitcoinUnlimited/pull/1390
This change makes it easier to port signature encoding tests and DSV.

@dagur Could you state something about how this refactor avoids a problem similar to the one that affected ABC?

This change is less bug prone compared to ABC's approach as it does not change the interface.
This line:
flags = SIGHASH_ALL | SIGHASH_FORKID;

is the same with this approach:
flags = SigHashType::ALL | SigHashType::FORKID;

while with ABC it's:
flags = SigHashType().withForkId();

Another example:
bool fHasSingle = (nHashType & ~(SIGHASH_ANYONECANPAY | SIGHASH_FORKID)) == SIGHASH_SINGLE

this approach:
bool fHasSingle = (nHashType & ~(SigHashType::ANYONECANPAY | SigHashType::FORKID)) == SigHashType::SINGLE

ABC is completely different:
bool fHasSingle = nHashType.withAnyoneCanPay(false).withForkId(false).getRawSigHashType() == SIGHASH_SINGLE;

Errors in updating the use of sighash flags are harder to make and easier to spot.


Expose Cache

This attempts to partially resolve #212 and resolves #161 and resolves #237 and resolves #158
Implementation Notes
I updated this to only expose the global cache, I kept the cache interface, adding a way to tell the set, delete and clear methods if you want to notify components reading from the cache, this way mutate can call cache.set and cache.set can also call mutate as a notification method without running on a infinite loop (mutate calls cache.set with this flag as false).
I did this to come back to custom cache once I found a way to let mutate know which cache to call without manually passing it.
~I created a CacheInterface and make the global config create a default instance of the cache, also exported both the interface and the Cache class.~
~I also updated useSWR to read from the cache instance received through the context object.~
~I was not able, yet, to find a way to make mutate and trigger read from the correct cache instance, because they are global my only idea so far was to pass the cache instance as a third argument (probably optional), but that could make it hard to test components using a custom cache for tests and a default cache for the mutate call.~
Missing things
~- useSWRPages is still using global cache (I haven't tried yet to use it here but I believe is the same as mutate and trigger)~
~- mutate is still using global cache~
~- trigger is still using global cache~
Any feedback is welcomed!

Also curious,
looking to hopefully have it fix #237

This should also resolve #158

This PR solves some problems we have with SWR and testing.
Currently we need to skip all tests for components that uses SWR.

Having a way to clear cache is also useful for when one component does an API request and you need another component to update what its displaying and not show its previous data (without having to use ugly callbacks and refs).

Ciao guys, any update on this?

@gabrieledarrigo I’m waiting for Shu to review it

Hi, great job on this PR
However, I feel like we also need to expose getErrorKey and getKeyArgs, otherwise we wouldn't know what key to use

@nulladdict you are right, I move them to the Cache class as a single serializeKey method

@sergiodxa seems we have some conflicts now  :P
Would love to land this in the next release!

@quietshu I fixed the conflicts and also added a keys method to get all cache keys as an array and a subscribe method to know when something changed in the cache. This method will be useful to integrate with SWR from the outside (e.g. subscribe to cache changes to sync with localStorage, then use localStorage to hydrate the cache before the first render)

BTW, @sergiodxa do you think it's a good idea to serialize the key in set, get, has and delete, if the key is not a string? So users don't need to call serializeKey, and all these behaviors can be unified:
useSWR(['api/user', user])
mutate(['api/user', user])
cache.get(['api/user', user]) // instead of cache.get(cache.serializeKey(['api/user', user]))

@quietshu you are right, it will make more sense, and it will still work if the user pass the serialized string directly, and applied it in https://github.com/zeit/swr/pull/231/commits/b4ed2890828b44740d9f8e9ebb52b0ef5bd3699c

Released<EMAIL_ADDRESS>will fully test in prod before marking it as stable (v0.2.0)  🙏

Makes sense, I will try it in production too

I can also test this with the use case I described above. If I don't reply, assume everything worked fine. :slightly_smiling_face:

I tested the feature with my application and it has solved the problem I was having before. Thanks!

I've also tested this in prod, and it works pretty fine for us.
One small thing is that for my use case (clearing out all errors in suspense mode when retry button in my ErrorBoundary is clicked) I had to finesse the error prefix from cache.
I've used something like this:
const [_key, , _errorKey] = cache.serializeKey('key')
const errorKeyPrefix = _errorKey.replace(_key, '')

So I think it might've also been useful to expose the hardcoded err@ prefix

Ciao guys, big up for your work on this!
But, question, does it work with testing?
I'm trying cache.clear in my afterEach block, but it seems that it doesn't work:
import { cache } from 'swr';

afterEach(() => {
  cache.clear()
});

it('should fetch on mount', async () => {
  await act(async () => {
    <Foo id="1" />
  });

  expect(fetch).toHaveBeenCalledWith('1');
});

it('should show an error when fetch fails', async () => {
  (fetch as jest.Mock).mockRejectedValue(new Error('An error occured'));

  await act(async () => {
    mount(
      <Foo id="1" />
    );
  });

  expect(fetch).toHaveBeenCalledWith('1');
  // other assertions that the error message is rendered
});

But the second test doesn't pass because fetch is never called; What am I missing?

@gabrieledarrigo I have the same problem, even with cache.clear, swr returns the result from the previous test.
@sergiodxa @quietshu Do we need to do something special to clear the cache during testing?

@andreoav @gabrieledarrigo I tried it in a test and found the issue, is because the deduping feature of SWR, since not enough time has passed since the last request SWR is reusing the fetch, you can fix it in two ways:

Add dedupingInterval: 0 to the configs of the useSWR call
Wrap the component to test in SWRConfig and set dedupingInterval: 0 there

I recommend to use the second option so your component will still have deduping of requests enabled while running inside your app and you can disable it only for the test.
I will send a PR with an example soon.
Using the example code above something like this should work:
import { SWRConfig, cache } from 'swr';

afterEach(() => {
  cache.clear()
});

it('should fetch on mount', async () => {
  await act(async () => {
    <SWRConfig value={{ dedupingInterval: 0 }}>
      <Foo id="1" />
    </SWRConfig>
  });

  expect(fetch).toHaveBeenCalledWith('1');
});

it('should show an error when fetch fails', async () => {
  (fetch as jest.Mock).mockRejectedValue(new Error('An error occured'));

  await act(async () => {
    mount(
      <SWRConfig value={{ dedupingInterval: 0 }}>
        <Foo id="1" />
      </SWRConfig>
    );
  });

  expect(fetch).toHaveBeenCalledWith('1');
  // other assertions that the error message is rendered
});

@sergiodxa Nice!! I updated my tests and it worked.
I think we should add this to the documentation.

Thanks a lot for your work on this, this is really helpful!
As far as I can tell, this hasn't been released to npm yet, right? Any chance to get a release? Thanks!

@amannn It was released as a beta: https://github.com/zeit/swr/pull/231#issuecomment-590537273

Ah right, thanks!

value={{ dedupingInterval: 0 }}

Thanks so much to share this. I think would be nice to have this kind of info on docs.

So is there a way I can access the cache variable? I want to fetch only once and I want a condition like !cache.has(dataKey) or similar

So is there a way I can access the cache variable? I want to fetch only once and I want a condition like !cache.has(dataKey) or similar

I use this way of calling swr to only have it fetch once.
  return useSWR<string>(API_PICTURES_IMAGE(pictureId), {
    // Images cannot be changed so should never be revalidated
    revalidateOnFocus: false,
    revalidateOnMount: false,
    revalidateOnReconnect: false,
  });

So is there a way I can access the cache variable? I want to fetch only once and I want a condition like !cache.has(dataKey) or similar

@p19ky I use this way of calling swr to only have it fetch once.
  return useSWR<string>(API_PICTURES_IMAGE(pictureId), {
    // Images cannot be changed so should never be revalidated
    revalidateOnFocus: false,
    revalidateOnMount: false,
    revalidateOnReconnect: false,
  });

When I tried it this way, it does not load once. I does not load at all. So what I did to resolve this is the following:
import { cache } from "swr"; //imported cache that is used by SWR

const {
    data: categories,
    error: errorCategories,
    size: sizeCategories,
    setSize: setSizeCategories,
    isValidating: isValidatingCategories,
  } = useSWRInfinite(getKeyCategories, categoriesFetcher, {
    revalidateOnFocus: false,
    revalidateOnMount: !cache.has(() => getKeyCategories()), //only revalidate if there is nothing in cache for my categories Key
  });

I am running into this again and again. Why isn't clearCache not really clearing the deduping cache too?
Wrapping ever single test in SWRConfig is really a chore and makes the test less readable.
Solutions:

export a function to disable deduping globally by default
enhance clearCache to also clear the deduping cache


Achieving Episode-Based Sampling with SliceSampler in TorchRL

In our project, we're employing a SliceSampler to aggregate our training trajectories into a ReplayBuffer. Our primary objective when sampling from this ReplayBuffer is to ensure that the sampled slices commence from the beginning of each episode.
Upon reviewing the documentation of the SliceSampler, we noted a reference to a start signal in relation to the cache_values parameter.
Now the question arises: does this feature align with our requirement? If so, how can we effectively harness it to achieve our desired outcome? Conversely, if it doesn't serve our purpose, are there alternative methods within TorchRL that we can explore to accomplish our goal?
Thank you.

Hey!
Let's take a concrete example: if you have trajectories of length 10, 15 and 20 in your buffer and you want samples of length 12, you could:

sample anything greater than 20
use split_trajectories to separate the trajectories from each other in a [B,T] format
take the first 12 elements

Would that work?
Both utils (split_trajectories and SliceSampler) have had significant developments lately so you may want to use the nightlies for your project.

We are now doing as you suggested, thank you very much :)


Less support

Added .less file for those who are using less instead of scss.

FYI...The latest 'release' of nsPopover v0.6.7 does NOT include the new 'less/ns-popover.less' file.
Not sure if you want to release v0.6.8 or move the tag to the current master branch.

+1 less/ns-popover.less is clearly on master and NOT on 0.6.7

Added to 0.6.8


Fixed can't build ng build --prod

https://github.com/TheKeithStewart/angular-esri-components/issues/18

This looks good.  Thanks for the help, @rrdlpl!!!


fix(cart): a null shipping total should be null instead of zero

PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines: https://github.com/graycoreio/daffodil/blob/master/CONTRIBUTING.md#commit
[x] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?
[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?
The shipping total in daffodil is set to zero even if the total from magento is null. This is a problem, because the shipping total needs to be shown as "FREE" when the shipping total is zero. So the shipping will be shown as "FREE" even though a shipping method hasn't been chosen yet.
What is the new behavior?
The shipping total will be null when the shipping method hasn't been chosen yet.
Does this PR introduce a breaking change?
[ ] Yes
[x] No

I don't think so. Because we'd be throwing an error any time that there is no shipping method defined. I think it makes sense for the shipping total to be numeric or null, because a value of zero is not the same as it not being provided. In other words, we don't have a way to differentiate between no shipping method selected and "Free Shipping". Actually, I think tax should be handled this way too, because we don't currently have a way to differentiate between no tax and zero tax either.

Needs docs, but I'm fine with the behavior.

added docs


Fix signing algorithm to account for null and repeating fields values removal before signing

also hash calculation
TODO:

Unittest blockchain state signing for node declaration variants
Unittest adding node declaration block variants keeping blockchain valid
Add unittests for coin transfer and pv schedule similar to those added for node declaration blocks

Probably, blockchain sync after python -m thenewboston_node.manage ensure_node_declared does not work because of it:
(thenewboston-node-BkWiXaKK-py3.9) dmugtasimov@dmugtasimov-Latitude-E5550 ~/gitrep/thenewboston/thenewboston-node $ python -m thenewboston_node.manage sync_blockchain
2021-10-01 16:06:03,326 INFO Calling FileBlockchain.copy_from(...)
2021-10-01 16:06:03,328 INFO Returned from FileBlockchain.copy_from(...) in 1.829ms
2021-10-01 16:06:05,493 WARNING Block message block_identifier value is invalid: Block message block_identifier must be equal to 49a3fc83cba30ace6afc7817c66786131a0edef8984f056d75770f137996228d
2021-10-01 16:06:05,494 WARNING Block identifier is invalid: Block message block_identifier must be equal to 49a3fc83cba30ace6afc7817c66786131a0edef8984f056d75770f137996228d
2021-10-01 16:06:05,494 WARNING Block message is invalid: Block message block_identifier must be equal to 49a3fc83cba30ace6afc7817c66786131a0edef8984f056d75770f137996228d
2021-10-01 16:06:05,494 WARNING Block number 0 (identifier: 6eeec4da32987d0073216b482e691e3656d3cef960f271daca27ed099c53ddb8) is invalid: Block message block_identifier must be equal to 49a3fc83cba30ace6afc7817c66786131a0edef8984f056d75770f137996228d
2021-10-01 16:06:05,494 WARNING Block is invalid: Block message block_identifier must be equal to 49a3fc83cba30ace6afc7817c66786131a0edef8984f056d75770f137996228d
2021-10-01 16:06:05,494 ERROR Exception in FileBlockchain.add_block(...) after 12.794ms
Traceback (most recent call last):
  File "/home/dmugtasimov/gitrep/thenewboston/thenewboston-node/thenewboston_node/core/logging.py", line 71, in wrapper
    rv = callable_(*args, **kwargs)
  File "/home/dmugtasimov/gitrep/thenewboston/thenewboston-node/thenewboston_node/business_logic/blockchain/base/blocks.py", line 67, in add_block
    block.validate(self)
  File "/home/dmugtasimov/gitrep/thenewboston/thenewboston-node/thenewboston_node/core/logging.py", line 149, in wrapper
    rv = callable_(*args, **kwargs)
  File "/home/dmugtasimov/gitrep/thenewboston/thenewboston-node/thenewboston_node/business_logic/models/block.py", line 135, in validate
    self.message.validate(blockchain)
  File "/home/dmugtasimov/gitrep/thenewboston/thenewboston-node/thenewboston_node/core/logging.py", line 149, in wrapper
    rv = callable_(*args, **kwargs)
  File "/home/dmugtasimov/gitrep/thenewboston/thenewboston-node/thenewboston_node/business_logic/models/block_message.py", line 141, in validate
    self.validate_block_identifier(blockchain)
  File "/home/dmugtasimov/gitrep/thenewboston/thenewboston-node/thenewboston_node/core/logging.py", line 149, in wrapper
    rv = callable_(*args, **kwargs)
  File "/home/dmugtasimov/gitrep/thenewboston/thenewboston-node/thenewboston_node/business_logic/models/block_message.py", line 204, in validate_block_identifier
    validate_exact_value(f'{self.humanized_class_name} block_identifier', block_identifier, expected_identifier)
  File "/home/dmugtasimov/gitrep/thenewboston/thenewboston-node/thenewboston_node/business_logic/validators.py", line 93, in validate_exact_value
    raise ValidationError(upper_first(f'{subject} must be equal to {expected_value}'))
thenewboston_node.business_logic.exceptions.ValidationError: Block message block_identifier must be equal to 49a3fc83cba30ace6afc7817c66786131a0edef8984f056d75770f137996228d
2021-10-01 16:06:05,495 WARNING Could not synchronize blockchain with b8591396e291372070db2c3e57c66e8c28401856e8adf2e53c707f7c9c325dac at http://<IP_ADDRESS>:8555/
Traceback (most recent call last):
  File "/home/dmugtasimov/gitrep/thenewboston/thenewboston-node/thenewboston_node/core/management/commands/sync_blockchain.py", line 37, in handle
    sync_minimal_to_file_blockchain(source, blockchain)
  File "/home/dmugtasimov/gitrep/thenewboston/thenewboston-node/thenewboston_node/business_logic/utils/blockchain.py", line 191, in sync_minimal_to_file_blockchain
    sync_minimal(source, temporary_file_blockchain)
  File "/home/dmugtasimov/gitrep/thenewboston/thenewboston-node/thenewboston_node/business_logic/utils/blockchain.py", line 178, in sync_minimal
    target_blockchain.add_block(block)
  File "/home/dmugtasimov/gitrep/thenewboston/thenewboston-node/thenewboston_node/core/utils/file_lock.py", line 20, in wrap
    rv = f(self, *args, **kwargs)
  File "/home/dmugtasimov/gitrep/thenewboston/thenewboston-node/thenewboston_node/business_logic/blockchain/file_blockchain/block_chunk/base.py", line 100, in add_block
    rv = super().add_block(block, validate)  # type: ignore
  File "/home/dmugtasimov/gitrep/thenewboston/thenewboston-node/thenewboston_node/core/logging.py", line 71, in wrapper
    rv = callable_(*args, **kwargs)
  File "/home/dmugtasimov/gitrep/thenewboston/thenewboston-node/thenewboston_node/business_logic/blockchain/base/blocks.py", line 67, in add_block
    block.validate(self)
  File "/home/dmugtasimov/gitrep/thenewboston/thenewboston-node/thenewboston_node/core/logging.py", line 149, in wrapper
    rv = callable_(*args, **kwargs)
  File "/home/dmugtasimov/gitrep/thenewboston/thenewboston-node/thenewboston_node/business_logic/models/block.py", line 135, in validate
    self.message.validate(blockchain)
  File "/home/dmugtasimov/gitrep/thenewboston/thenewboston-node/thenewboston_node/core/logging.py", line 149, in wrapper
    rv = callable_(*args, **kwargs)
  File "/home/dmugtasimov/gitrep/thenewboston/thenewboston-node/thenewboston_node/business_logic/models/block_message.py", line 141, in validate
    self.validate_block_identifier(blockchain)
  File "/home/dmugtasimov/gitrep/thenewboston/thenewboston-node/thenewboston_node/core/logging.py", line 149, in wrapper
    rv = callable_(*args, **kwargs)
  File "/home/dmugtasimov/gitrep/thenewboston/thenewboston-node/thenewboston_node/business_logic/models/block_message.py", line 204, in validate_block_identifier
    validate_exact_value(f'{self.humanized_class_name} block_identifier', block_identifier, expected_identifier)
  File "/home/dmugtasimov/gitrep/thenewboston/thenewboston-node/thenewboston_node/business_logic/validators.py", line 93, in validate_exact_value
    raise ValidationError(upper_first(f'{subject} must be equal to {expected_value}'))
thenewboston_node.business_logic.exceptions.ValidationError: Block message block_identifier must be equal to 49a3fc83cba30ace6afc7817c66786131a0edef8984f056d75770f137996228d
2021-10-01 16:06:05,495 ERROR Could not synchronize blockchain with the network

https://github.com/thenewboston-developers/thenewboston-node/pull/443

https://github.com/thenewboston-developers/thenewboston-node/pull/444

https://github.com/thenewboston-developers/thenewboston-node/pull/446

The reason for the issue was different. Further implementation of the task should be postponed.


more tests

Coverage remained the same at 82.857% when pulling 463f6fbf79a23ec3a320c821654435243046f804 on test-update into 1d4ea535015514d995ce4b47ae60e1f8df582790 on master.


Feature: window title widget

It would be good to have a "window title" widget showing the active window's title.
Alternatively a "pipe" widget, which would take the information to display from a unix socket would do the job (and more) too.

Done!
The widget name is Title. If you want longer titles to be displayed, you can configure MaxTitleLength. (Note that CenterSpace may need to be increased too.)

That was fast! Thank you!

Maybe not a bug, but I can't figure how to change the font (can make it bold etc, but couldn't set the family).

The font is controlled by font-family in the css. AFAIK the font name is the same as the one you would input into e.g. vscode or the gtk settings ini.


Voting power Guide entry FAQ needs adding to.

This needs beefing up as well as talking about Direct Voters
https://docs.sanchogov.tools/faqs/what-is-voting-power

Added some context to FAQ


Compilation errors and how to solve them?

wtf?

I compile without a module, and it works fine, but compilation does not go with the module!

https://github.com/ZhengPeiRu21/mod-playerbots/issues/167
and I have the same problem, I did everything as I was told and the error above in the screenshot comes out

This should be fixed with the latest updates by Liyunfan, please confirm and close out if resolved.


issues/163: Some tests in nested classes are not exercised when changing related production code not exercised by the tests' top-level class

Skippy appears to not be taking into account that test classes may contain nested classes (e.g. JUnit 5 test classes annotated with @Nested) that in turn may contain test methods of their own (it is not mandatory, but it is usually the case).
Worts case scenario, if the top-level class itself doesn't exercise a production class that has changed, none of the tests would be executed, even if some of the nested classes of that test class do. The net result is that the change in the production class would be undetected.

I took a stab at dealing with nested test classes: https://github.com/skippy-io/skippy/pull/166/files
Thoughts? I'm also curious to see how you would handle the corner case from my previous comment.

Love this PR. I think that there is one remaining problem that can not be solved with the proposed solution:
@PredictWithSkippy
public class LeftPadderTest {

    @Test
    void testSomething() {
        var input = TestConstants.HELLO;
        assertEquals(" hello", LeftPadder.padLeft(input, 6));
    }

    @Nested
    class FirstNestedClass {
        @Test
        void testNothing() {
            assertTrue(true);
        }

    }

}

Resetting of the JaCoCo agent in SkippyTestApi will result in the loss of the execution data for the free-floating test at the top level once the nested class is executed:
    @Test
    void testSomething() {
        var input = TestConstants.HELLO;
        assertEquals(" hello", LeftPadder.padLeft(input, 6));
    }

Not sure yet how to solve that.

Gah, that's right :D
Thanks for the quick reply, I'll definitely check out your solution!

I took a stab at dealing with nested test classes: https://github.com/skippy-io/skippy/pull/166/files
Thoughts? I'm also curious to see how you would handle the corner case from my previous comment.

Left a couple of minor comments, but overall looks quite elegant, should definitely do the trick :D


[TOPIC-GPIO] drivers: gpio: provide typedefs for flags and devicetree properties

This addresses another API change that we should be making (getting rid of signed int as the type holding the configuration flags).  It also adds support for simple preservation of GPIO phandle reference data from devicetree like this:
static const struct gpio_phandle_specifier pin_in =
    DT_INST_0_TEST_GPIO_BASIC_API_IN_GPIOS;

This is particularly useful for sensor gpios but also could be used for LEDs in #21116.

I have no problems with the introduction of gpio_pin_t and gpio_devicetree_flags_t. But I do think we should wait until we start using a typedef for something like the flags. Instead, I would replace the current usage of int with unsigned int and add the two types above that are needed for storage.

I like the typedefs. Tey are more expressive than just a u32_t or whatever.


How to render HTML in the View

How to render HTML in the CSHTML like I asked in here: Render Html code from a property using FluentMail in C# (https://stackoverflow.com/questions/59801013/render-html-code-from-a-property-using-fluentmail-in-c-sharp)

I believe this might help you https://stackoverflow.com/questions/53969819/how-to-call-html-raw-and-html-partial-outside-a-razor-page

I believe this might help you https://stackoverflow.com/a/23603594/8391028


Plugins does not work in Notepad++ 7.7.1

I have updated npp to 7.7.1 version, copied the sqlFormat.dll to then C:\Program Files (x86)\Notepad++\plugins:

and configured the menu

but the menu still doesn´t showing after reboot npp

Hi, I'm using Notepad++ (64bits) and I can see the plugin and as a matter of fact I am able to update it.
So, seeing that you speak spanish as myself:

En el folder Notepad++\plugins tengo un folder que se llama PoorMansTSqlFormatterNppPlugin y dentro de este, también tengo algunos otros DLLs. ¿Ya probaste instalándolo usando el administrador de plugins? Porque el administrador de plugins lo lista y lo instala automáticamente.

Regards.

I also would really like this to work.  Same problem - it just doesn't show up.

I just got it to work.  I installed the 32-bit version; it wouldn't load on 64-bit.  Then I created a folder in the Plugins folder called "sqlFormat" and put the dll into that.

What version of npp are you using?
I already tried with 32 bits version


monitor exporter - add more samples

1)samples related to  exporter options
2) samples exporting traces from storage, servicebus

completed


Feature: Find and use MQTT enabled charting tool

Would be neat if there was a real-time charting tool that would take MQTT messages as input, and plot (nice looking) charts..
Node-RED does this, but the line charts do not currently handle charts covering more than a few thousand data points (at least not in a good way).
Mozaik is looking promising... there might be others too. #

A better option would be to send data to a time series database such as Influxdb, then graf it in for example Grafana.
Butler SOS does exactly this, thus closing this issue.


Woah there!

Hello there!
I was just questioning what you are trying to do with my code. You had withdrawn my name from it so I assume you are not trying to develop it. This was code that I got and it could land you in some legal problems if you try and steal it. I am awaiting your response.
Echo

oh... I am so sorry, I thought I could delete it, how can I put it back?

and so sorry to respond late

and also just to let you know I am most likely not going to be active on github, I had not used it for about 2-3 months, and i just saw this an email that said this, so sry

Ok please delete this repo and all other ones, if you want, you can just delete your account too


Issue with 1.6.1

When the snail update broke AstroModLoader, I deleted all of it from my machine and decided I'd re-download it when/if it got fixed.
Downloaded the updated version, but I can't drag&drop the mods into the loader. Did I mess something up with the install?

This is unlikely a problem with the actual modloader. Please come to the astroneer modding discord get help you resolve this.


Power BI Embedded Hide Page Navigation

Hi everyone,
is it possible to use attribute navContentPaneEnabled=false to hide the pages tab when embedding a report as described Here, please?
It seems as if we don't have enough control when embedding reports the way it is described in the link, as opposed to using the built-in embedding links and simply appending this attribute to the URL as a parameter, or when constructing our own json config web using javascript API.
Thanks

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 715bc26c-2ccd-a040-3c96-d73cde4b982b
Version Independent ID: c793e872-29e4-2e04-b9f4-973c01d4a123
Content: Embed a Power BI report in a model-driven system form - Power Apps
Content Source: powerapps-docs/maker/model-driven-apps/embed-powerbi-report-in-system-form.md
Service: powerapps
GitHub Login: @adrianorth
Microsoft Alias: aorth

Adding @Mark<EMAIL_ADDRESS>and @Monisha<EMAIL_ADDRESS>to this question.  I didn't know the answer and it will require some investigation.

From: WinstonHenry<EMAIL_ADDRESS>Sent: Friday, February 26, 2021 7:25 AM
To: MicrosoftDocs/powerapps-docs<EMAIL_ADDRESS>Cc: Adrian Orth<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: [MicrosoftDocs/powerapps-docs] Power BI Embedded Hide Page Navigation (#2153)
Hi everyone,
is it possible to use attribute navContentPaneEnabled=false to hide the pages tab when embedding a report as described Herehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdocs.microsoft.com%2Fen-us%2Fpowerapps%2Fmaker%2Fmodel-driven-apps%2Fembed-powerbi-report-in-system-form%23embed-with-contextual-filtering&data=04|01|Adrian.Orth%40microsoft.com|59e970f6dda94c026af608d8da59ecbb|72f988bf86f141af91ab2d7cd011db47|1|0|637499427049169259|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=R2NfBybYYFlPGi7JgbbGZAWcNJq0%2FkWbFs%2FhdqKRm3I%3D&reserved=0, please?
It seems as if we don't have enough control when embedding reports the way it is described in the link, as opposed to using the built-in embedding links and simply appending this attribute to the URL as a parameter, or when constructing our own json config web using javascript API.
Thanks

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 715bc26c-2ccd-a040-3c96-d73cde4b982b
Version Independent ID: c793e872-29e4-2e04-b9f4-973c01d4a123
Content: Embed a Power BI report in a model-driven system form - Power Appshttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdocs.microsoft.com%2Fen-us%2Fpowerapps%2Fmaker%2Fmodel-driven-apps%2Fembed-powerbi-report-in-system-form%23prerequisites&data=04|01|Adrian.Orth%40microsoft.com|59e970f6dda94c026af608d8da59ecbb|72f988bf86f141af91ab2d7cd011db47|1|0|637499427049169259|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=W9pEjIU9CGlMUieIT37pJ6pfx5ZkokmjI13XwAteDtM%3D&reserved=0
Content Source: powerapps-docs/maker/model-driven-apps/embed-powerbi-report-in-system-form.mdhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fpowerapps-docs%2Fblob%2Flive%2Fpowerapps-docs%2Fmaker%2Fmodel-driven-apps%2Fembed-powerbi-report-in-system-form.md&data=04|01|Adrian.Orth%40microsoft.com|59e970f6dda94c026af608d8da59ecbb|72f988bf86f141af91ab2d7cd011db47|1|0|637499427049179215|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=%2F%2FUhZOGg4muND4bPQ9OhckDZy0N47DqnUTZIhVdrQJs%3D&reserved=0
Service: powerapps
GitHub Login: @adrianorthhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fadrianorth&data=04|01|Adrian.Orth%40microsoft.com|59e970f6dda94c026af608d8da59ecbb|72f988bf86f141af91ab2d7cd011db47|1|0|637499427049189171|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=8Pv%2F6dlgfVy54%2FpXppAOI%2BcXHTsV2SQNg8a%2BKBEgcYM%3D&reserved=0
Microsoft Alias: aorth

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fpowerapps-docs%2Fissues%2F2153&data=04|01|Adrian.Orth%40microsoft.com|59e970f6dda94c026af608d8da59ecbb|72f988bf86f141af91ab2d7cd011db47|1|0|637499427049189171|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=nJdC5kwO%2BIeGh9ruDqzLKlbMCbVrZ5p4BPd6fRPXOlw%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAFNCINBTLZD2TLHZ35T33D3TA6OK5ANCNFSM4YIOCMMQ&data=04|01|Adrian.Orth%40microsoft.com|59e970f6dda94c026af608d8da59ecbb|72f988bf86f141af91ab2d7cd011db47|1|0|637499427049199127|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=rPpT4RqogQCwfz5kN%2FpW28fDnEKQoDT4PIWqwiQrInw%3D&reserved=0.

We don't currently support setting navContentPaneEnabled, so it will always be enabled.
-m
From: Adrian Orth<EMAIL_ADDRESS>Sent: Friday, February 26, 2021 7:28 AM
To: MicrosoftDocs/powerapps-docs<EMAIL_ADDRESS>MicrosoftDocs/powerapps-docs<EMAIL_ADDRESS>Mark Spilde<EMAIL_ADDRESS>Monisha Rochlani<EMAIL_ADDRESS>Cc: Mention<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/powerapps-docs] Power BI Embedded Hide Page Navigation (#2153)
Adding @Mark<EMAIL_ADDRESS>and @Monisha<EMAIL_ADDRESS>to this question.  I didn't know the answer and it will require some investigation.

From: WinstonHenry <notifications<EMAIL_ADDRESS>Sent: Friday, February 26, 2021 7:25 AM
To: MicrosoftDocs/powerapps-docs <powerapps-docs<EMAIL_ADDRESS>Cc: Adrian Orth <Adrian.Orth<EMAIL_ADDRESS>Mention <mention<EMAIL_ADDRESS>Subject: [MicrosoftDocs/powerapps-docs] Power BI Embedded Hide Page Navigation (#2153)
Hi everyone,
is it possible to use attribute navContentPaneEnabled=false to hide the pages tab when embedding a report as described Herehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdocs.microsoft.com%2Fen-us%2Fpowerapps%2Fmaker%2Fmodel-driven-apps%2Fembed-powerbi-report-in-system-form%23embed-with-contextual-filtering&data=04|01|mspilde%40microsoft.com|e4fd6b59341b4d63a0e908d8da6b09d1|72f988bf86f141af91ab2d7cd011db47|1|0|637499500664915448|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=xRJuo9fDDUnVz61ILQKserUDw%2F0U7gv6QuXxxhk9M9s%3D&reserved=0, please?
It seems as if we don't have enough control when embedding reports the way it is described in the link, as opposed to using the built-in embedding links and simply appending this attribute to the URL as a parameter, or when constructing our own json config web using javascript API.
Thanks

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 715bc26c-2ccd-a040-3c96-d73cde4b982b
Version Independent ID: c793e872-29e4-2e04-b9f4-973c01d4a123
Content: Embed a Power BI report in a model-driven system form - Power Appshttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdocs.microsoft.com%2Fen-us%2Fpowerapps%2Fmaker%2Fmodel-driven-apps%2Fembed-powerbi-report-in-system-form%23prerequisites&data=04|01|mspilde%40microsoft.com|e4fd6b59341b4d63a0e908d8da6b09d1|72f988bf86f141af91ab2d7cd011db47|1|0|637499500664925410|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=G7sMTpEVq3Ruo0YcRSCd1BveARb%2BvJwjO8ar%2BUoZLlQ%3D&reserved=0
Content Source: powerapps-docs/maker/model-driven-apps/embed-powerbi-report-in-system-form.mdhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fpowerapps-docs%2Fblob%2Flive%2Fpowerapps-docs%2Fmaker%2Fmodel-driven-apps%2Fembed-powerbi-report-in-system-form.md&data=04|01|mspilde%40microsoft.com|e4fd6b59341b4d63a0e908d8da6b09d1|72f988bf86f141af91ab2d7cd011db47|1|0|637499500664925410|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=E5zfEVrX0GT6GrcCSkAthEkayZyqyEUXSaaXODX9Tac%3D&reserved=0
Service: powerapps
GitHub Login: @adrianorthhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fadrianorth&data=04|01|mspilde%40microsoft.com|e4fd6b59341b4d63a0e908d8da6b09d1|72f988bf86f141af91ab2d7cd011db47|1|0|637499500664935361|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=aUxxH7xgs9tEeR18Rp1JETDFpdZzUYDSunDrqUn6Lm0%3D&reserved=0
Microsoft Alias: aorth

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fpowerapps-docs%2Fissues%2F2153&data=04|01|mspilde%40microsoft.com|e4fd6b59341b4d63a0e908d8da6b09d1|72f988bf86f141af91ab2d7cd011db47|1|0|637499500664935361|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=lmeP3zv%2BfrdcQhPa6hhaMBoQKoWkbf6mdtmAY3Ck9Uc%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAFNCINBTLZD2TLHZ35T33D3TA6OK5ANCNFSM4YIOCMMQ&data=04|01|mspilde%40microsoft.com|e4fd6b59341b4d63a0e908d8da6b09d1|72f988bf86f141af91ab2d7cd011db47|1|0|637499500664945319|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=4jjrqxQQPbfCsyJGw6nLRWVNdZ%2FirXWS2ACq%2FSTdYTY%3D&reserved=0.


Fix invariant violation if we get a message without piggyback ack while expecting an ack.

Such messages are not allowed per spec, so we should just ignore them.
Fixes https://github.com/project-chip/connectedhomeip/issues/22854

The test failures are somewhat real in the sense that we have tests that manually remove (some but not enough) retrans table entries and then send two messages in a row on the same exchange without having gotten a reply to the first one (which gets dropped in the test).  Those tests need adjusting to deal with this behavior, because they are in fact relying on these messages getting delivered to the other side and the other side responding.   @turon
I tried just clearing all the retrans entries, but then that drops the exchange on the server entirely, and we actually get different behavior because an injected unexpected Status Response message is handled differently depending on whether it matches a closed but still alive exchange or does not match any exchange at all.  In the latter case, InteractionModelEngine::OnMessageReceived responds with a failure Status Response, etc...
@yunhanw-google do you have time to sort out how these tests (TestReadInteraction, TestWriteInteraction, TestCommandInteraction) should handle this?

I decided to fix the tests to make it look like a response from the server had in fact been received and just ignored at the data model layer instead of dropped at the message layer.  That means:

Clearing the "waiting for an ack" state on the client.
Telling the client to send an ack for the right message id to the server when it next sends.


Discrepancy in action/index.cjs After Running npm run build

Hi,
I've noticed that action/index.cjs doesn't seem to be updated in line with the latest build, as running npm run build produces significant differences.
This issue seems to impact the action's behavior with draft pull requests in GitHub Actions, leading to unexpected results.
Steps to Reproduce:

Run npm run build locally.
Compare the output action/index.cjs with the version in the repository.

Expected:

action/index.cjs should match the build output to ensure proper action functionality.

Actual:

There's a noticeable discrepancy, potentially explaining why draft PRs aren't handled as expected.

Could this be looked into? Consistency between the build output and the repository version is crucial for draft PR support.
Thanks,
P.S. Apologies if my English isn't perfect. Thank you for your understanding.

@chibicco Update the action/index.cjs and release v1.0.13. Thank you for pointing out this.

Thank you for your quick response.
We have confirmed that it works in Draft PR :)


Correctly handle modules with imported rather than exported memory

Fixes #9

Deps update was done for ImportSection::functions() which is new in parity-wasm v0.15.4

I've tested this with my own module compiled with and without #![wasm_import_memory], verified both outputs with wasm2wat, and tested both execute in Chrome.

Awesome, thanks!

Thanks. This solves one part of sharing memory between multiple wasm modules.
The next part is being able to relocate the addresses used by a module so that multiple modules don't clobber each other. Do you think relocation should be implemented in rust itself? Or should it be implemented by wasm-gc since it's the "linker"?


Preprod

Fix release 1.11.7

:tada: This PR is included in version 1.12.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


fix yaml linter warning in backend-protocol test yaml

What type of PR is this?
/kind cleanup
/kind test
/area conformance
What this PR does / why we need it:
Fixes the linter warning

./conformance/tests/httproute-backend-protocol-h2c.yaml
11:3      warning  comment not indented like content  (comments-indentation)

Which issue(s) this PR fixes:

N/A
Does this PR introduce a user-facing change?:

NONE

Thanks @dprotaso!
/lgtm
/approve


ionic resources doesn't  work properly with PSD

Short description of the problem:
When i run Ionic resources from the Command line, nothing happens
What behavior are you expecting?
ionic should generate the rousources.
Steps to reproduce:

Create a simple image in Photoshop
Add a new layer, apply a Layer mask
Run ionic resources.

Other information: (e.g. stacktraces, related issues, suggestions how to fix, stackoverflow links, forum links, etc)
Which Ionic Version? 1.x or 2.x
Ionic Framework Version: 1.3.1
Ionic CLI Version: 2.0.0
Using:
Cordova CLI: 6.3.1
Ionic Framework Version: 1.3.1
Ionic CLI Version: 2.0.0
Ionic App Lib Version: 2.0.0
OS:
Node Version: v6.0.0

Close and move to ionic-cli

This issue was moved to driftyco/ionic-cli#1383

Hello, thanks for opening an issue with us! Because this was an issue with the ionic-cli and not the framework I have moved this issue to the appropriate repo. Thanks for using Ionic!


travis: Add codecov

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@88f4b31). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #18   +/-   ##
=========================================
  Coverage          ?   93.22%
=========================================
  Files             ?       29
  Lines             ?     1595
  Branches          ?      150
=========================================
  Hits              ?     1487
  Misses            ?       93
  Partials          ?       15

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88f4b31...0d41bf8. Read the comment docs.