Can't Remove the country Code Through Styles

The country codes (example displayed below) cannot be styled through the provided props.

even when using the countryCodeTextStyles={{display: "none"}} prop everything but the country code is removed.

I don't know where you have gone wrong, but instead of the country code in the above image, it should display flag of the selected country.

not sure either, but can you add  prop to hide them

Sure will add that in the next update


[WIP] Load item and arrow entities from chunk save (#102)

#102

[x] Load item NBT
[x] Load arrow NBT
[ ] Spawn item and arrow into world
[ ] Add tests

What's your idea for spawning the loaded entities?

I'm not decided yet, but here's what I'm thinking:
Since level deserialization is in feather-core, I figure the entities would be stored in the Chunk struct. When ChunkLoadSystem (in feather-server) receives a Reply with a loaded chunk, it fires a ChunkLoadEvent. There could be another system in feather-server that listens on ChunkLoadEvent and spawns the entities depending on their data.
However, consider the case where an an entity is stored in Chunk A. It is added to the world when ChunkLoadEvent is fired for Chunk A. The entity then crosses to Chunk B. Chunk A is later unloaded, and then loaded again. The entity would then be duplicated in the world. Not too sure how to prevent that.

I'm not decided yet, but here's what I'm thinking:
Since level deserialization is in feather-core, I figure the entities would be stored in the Chunk struct. When ChunkLoadSystem (in feather-server) receives a Reply with a loaded chunk, it fires a ChunkLoadEvent. There could be another system in feather-server that listens on ChunkLoadEvent and spawns the entities depending on their data.
However, consider the case where an an entity is stored in Chunk A. It is added to the world when ChunkLoadEvent is fired for Chunk A. The entity then crosses to Chunk B. Chunk A is later unloaded, and then loaded again. The entity would then be duplicated in the world. Not too sure how to prevent that.

Storing entities in Chunk isn't ideal in my opinion, since they aren't needed past when the chunk is loaded (all entities are stored in the World). It would probably be preferable to add a Vec<EntityData> field to chunkworker::Reply.
As for the entity duplication issue, I don't think there's a clean way around this until world persistence is implemented. I plan to do this within the next few weeks, so the issue shouldn't be present for that long.

Codecov Report

Merging #125 into develop will decrease coverage by 0.2%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##           develop     #125      +/-   ##
===========================================
- Coverage    58.76%   58.55%   -0.21%
===========================================
  Files           60       61       +1
  Lines         8230     8259      +29
===========================================
  Hits          4836     4836
- Misses        3394     3423      +29

Impacted Files
Coverage Δ

core/src/save/entity.rs
0% <0%> (ø)

core/src/save/region.rs
0% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02dab41...d7d5c05. Read the comment docs.

Codecov Report

Merging #125 into develop will decrease coverage by 0.2%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##           develop     #125      +/-   ##
===========================================
- Coverage    58.76%   58.55%   -0.21%
===========================================
  Files           60       61       +1
  Lines         8230     8259      +29
===========================================
  Hits          4836     4836
- Misses        3394     3423      +29

Impacted Files
Coverage Δ

core/src/save/entity.rs
0% <0%> (ø)

core/src/save/region.rs
0% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02dab41...d7d5c05. Read the comment docs.

Would it make sense to add the Vec<EntityData> to ChunkLoadEvent, or firing a separate event?

A separate system makes the most sense in this case, yes.

Yeah that's what I'm doing atm, though it's fetching the Util resource lazily. Would that still be beneficial in a separate system, or should I just use Read<'a, Util> directly?

Still a separate system, I think, because the match expression will grow very long.

Oh yeah I'm for sure separating it, I was just wondering if there'd be a purpose in using LazyUpdate in that new system, instead of referencing Util directly. I guess I'm not clear on what LazyUpdate actually does.

Oh, sorry for misunderstanding.
LazyUpdate::exec causes the provided closure to be execute lazily, i.e. at the end of the tick. Its benefit is that you can access any resource or component from the world without specifying system data, but you also lose concurrency by doing this.
If you use the separate system, there shouldn't be a need to use it. The main motivation for utilizing it is if you need access to tons of components which would be unclean to write in a SystemData. (In the issue, I wrote that LazyUpdate should be used, but this was before util::spawn_xx was implemented.)

Hmm so if I add Vec<EntityData> to ChunkLoadEvent, I get an error since Vec doesn't implement the Copy trait. Does that mean I can't pass a Vec in an event?

You should just be able to remove the Copy derive on ChunkLoadEvent (unless there's some reason it's needed).

Ready for review

Thanks!


Support for Dual-Adapter Machines

For a dual-adapter laptop (for example, the Dell XPS 15 9550, which has both an Intel HD Graphics 530 and an NVIDIA GeForce GTX 960M), the startup code can be modified to select the right adapter, as  done, rather crudely, here:
HRESULT DeviceResources::CreateDeviceResources()
{
	ID3D11Device* device = nullptr;
	ID3D11DeviceContext* context = nullptr;
	HRESULT hr = S_OK;
	UINT createDeviceFlags = 0;

	IDXGIFactory1 * pFactory = NULL;
	CreateDXGIFactory1(__uuidof(IDXGIFactory1), (void**)&pFactory);

	UINT i = 0;
	IDXGIAdapter * pAdapter;
	while (pFactory->EnumAdapters(i, &pAdapter) != DXGI_ERROR_NOT_FOUND)
	{
		DXGI_ADAPTER_DESC adapterDesc;
		pAdapter->GetDesc(&adapterDesc);
		if (adapterDesc.Description[0] == 'N') // The NVIDIA adapter
		{
			break;
		}
		++i;
		pAdapter = nullptr;
	}

	// Creates D3D11 device.
	D3D_FEATURE_LEVEL maxSupportedFeatureLevel = D3D_FEATURE_LEVEL_9_1;
	D3D_FEATURE_LEVEL featureLevels[] = {
		D3D_FEATURE_LEVEL_12_1,
		D3D_FEATURE_LEVEL_12_0,
		D3D_FEATURE_LEVEL_11_1,
		D3D_FEATURE_LEVEL_11_0,
		D3D_FEATURE_LEVEL_10_1,
		D3D_FEATURE_LEVEL_10_0,
		D3D_FEATURE_LEVEL_9_3,
		D3D_FEATURE_LEVEL_9_2,
		D3D_FEATURE_LEVEL_9_1
	};
	hr = D3D11CreateDevice(
		pAdapter,
		D3D_DRIVER_TYPE_UNKNOWN, //D3D_DRIVER_TYPE_HARDWARE,
		nullptr,
		createDeviceFlags,
		featureLevels,
		ARRAYSIZE(featureLevels),
		D3D11_SDK_VERSION,
		&device,
		&maxSupportedFeatureLevel,
		&context);

But after selecting the correct adapter, the application still fails here:
NVENCSTATUS CNvHWEncoder::NvEncRegisterResource(NV_ENC_INPUT_RESOURCE_TYPE resourceType, void* resourceToRegister, uint32_t width, uint32_t height, uint32_t pitch, void** registeredResource)
{
    NVENCSTATUS nvStatus = NV_ENC_SUCCESS;
    NV_ENC_REGISTER_RESOURCE registerResParams;

    memset(&registerResParams, 0, sizeof(registerResParams));
    SET_VER(registerResParams, NV_ENC_REGISTER_RESOURCE);

    registerResParams.resourceType = resourceType;
    registerResParams.resourceToRegister = resourceToRegister;
    registerResParams.width = width;
    registerResParams.height = height;
    registerResParams.pitch = pitch;
    registerResParams.bufferFormat = NV_ENC_BUFFER_FORMAT_ABGR;

    nvStatus = m_pEncodeAPI->nvEncRegisterResource(m_hEncoder, &registerResParams);
    if (nvStatus != NV_ENC_SUCCESS)
    {
        assert(0);
    }

where nvStatus is NV_ENC_ERR_DEVICE_NOT_EXIST.
Is there additional initialization that needs to be performed as well?  Or am I just fighting the fact that my NVIDIA card doesn't actually work with nvEncoder?

@dfbaskin I'm using Dell XPS 15 9530 and it's working well. Would it work if you set the global setting in NVIDIA control panel to High-performance NVIDIA processor?

Changing that setting did indeed allow the application to select the NVIDIA adapter by default.  Thanks for that.
However, I'm still getting the NV_ENC_ERR_DEVICE_NOT_EXIST error in the CNvHWEncoder::NvEncRegisterResource function.  Looking for more details about this error, I found:

NV_ENC_ERR_DEVICE_NOT_EXIST
This indicates that device passed to the API call is no longer available and needs to be reinitialized. The
clients need to destroy the current encoder session by freeing the allocated input output buffers and destroying the device and create a new encoding session.

Is it possible that there is some kind of race condition that is generating this error?  It is strange that when I run MultithreadedTestRunner.exe I can sometimes see the 3D rendering for 2-3 seconds before the error is generated.

It's hard to tell since I couldn't reproduce that issue and my Dell laptop is an older version (GeForce GT 750M). Please note that when you run MultithreadedTestRunner app, it uses NVIDIA video codec SDK but the rest of our samples are using NvPipe with CUDA support. If you aren't able to run any of them, there is a possibility with driver issues.

@dfbaskin a few things to check.  First, that you are running an nvidia driver version 375.86 or newer (required for the VideoCodec v7.1 we rely on).  A quick look at the Dell driver support page looks like there is a recent driver update that is well above that.  Second, make sure when you install CUDA that you don't overwrite the video card drivers, as by default it will install a much older driver version.
If you still see the issue present, install FFMPEG and run "ffmpeg -h encoder=h264_nvenc" from a commandline.  This will determine if your GPU has the proper nvencoder hardware present (it should, be we have found a couple of edge cases on laptops that have incomplete or broken nvenc hardware)

So I did the following:

I verified I am using the latest nvidia drivers (v391.24)
I installed CUDA and the 3 patch files and made sure it didn't overwrite the existing drivers.
Ran the CUDA demo files (like nbody.exe, oceanFFT.exe, randomFog.exe) and they worked fine.
Ran the ffmpeg -h encoder=h264_nvenc command and no errors were reported:

Encoder h264_nvenc [NVIDIA NVENC H.264 encoder]:
    General capabilities: delay
    Threading capabilities: none
    Supported pixel formats: yuv420p nv12 p010le yuv444p p016le yuv444p16le bgr0 rgb0 cuda d3d11

Downloaded and built the original DirectX-Graphics-Samples\Samples\Desktop\D3D12Multithreading example, and it ran fine.
Made sure there was no other video software running (like Skype).
Downloaded a fresh copy of the 3DToolKit repo, added the dependencies, and rebuilt (x64/release).  But still seeing the same behavior.

I'll try to dig into it some more.

@dfbaskin Thanks Dave!  Really really helps us narrow down root cause.  I think the next step, if you're able, is to have @anderm or @phongcao dig through a debug session with you to see what we've missed.  Shoot me an email and we'll find time to get this fixed :)

Related to #85


Resolve unused format arguments

Updated three instances where the number of format arguments did not
match number of arguments.
In CompactionCoordinator the compactorAddress was a third argument for
a statement containing only two format arguments. The compactorAddress
was dropped as it did not seem to be necessary.
In AuditedSecurityOperation there were two occasions of mismatched
formats and arguments. In both cases, an additional format argument was
added to allow both the tableName and tableId to be displayed in the
audit log.

Update caused errorprone to flag several issues that i need to look into.


Catch exceptions whilst trying to fetch metadata

Description of the change
The previous way was only handling the case where the metadata fetched
could not be correctly parsed. Now it will also disable the global
cache if the HTTP request fails for any reason.
NOTE
I don't know if I'm on to the right thing here. In my build environment
the metadata URL isn't reachable due to firewalls (and I can't change that
in the short term, unfortunately). Maybe this isn't the right change and
I should open an issue to track all issues related to my use case 😄
Thanks for spago! I'm really enjoying using it 👍
Checklist:

[ ] Added the change to the "Unreleased" section of the changelog
[ ] Added some example of the new feature to the README
[ ] Added a test for the contribution (if applicable)

P.S.: the above checks are not compulsory to get a change merged, so you may skip them. However, taking care of them will result in less work for the maintainers and will be much appreciated 😊

@carlosdagos I'll merge this before it gets too out of sync with master, feel free to open another PR to add support for overriding the metadata URL 🙂
Thank you!


How to apply where filter to eager loading

So I have two tables:
User
u_id | first_name
User_Friend
u_id | friend_id
Now I wish to search for a user's friends by their first name.
Below is a relation I defined in the UserFriend model:
static get relationMappings() {

        return {

            friend: {
                relation: Model.BelongsToOneRelation,
                modelClass: User,
                join: {
                    from: "users.u_id",
                    to: "user_friends.friend_id"
                }
            },
        }
    }

Code for fetching all friends of a user:
const friends = await UserFriends.query().eager("friend").where({ u_id: 2 });
How can I apply a filter here that will get me, friends of u_id = 2, by their first name?

It looks like eager is deprecated, so you might want to try one of the withGraph methods instead.
I think you should be able to use modifyGraph to do the filtering you're describing once the models and relationships are in order.
It looks like you are missing the Friend model from your example, so I am going to assume it exists. This seems like a many to many relation, so you will want to define the "through" relation to make this work.
const friends = await User
  .query()
  .withGraphFetched('friends')
  .modifyGraph('friends', builder => {
    builder.where('name', 'ilike', ...);
  })


Added SNI ( https://en.wikipedia.org/wiki/Server_Name_Indication ) su…

…pport.

I think we also need to add a public method to set hostname, something like
EXP_FUNC bool STDCALL ssl_set_hostname(const SSL *ssl, const char* hostname);

which would validate the length of hostname and call strlcpy to fill the internal structure.

@igrr I added the  ssl_set_hostname function. Check it when you have time.

@Links2004 Very good suggestion. Check the latest commit.


GitHub Webhook URL returns 400 error when APP_DEBUG is 0

Hi,
I noticed that Satisfy returns a 400 error when APP_MODE=prod and APP_DEBUG=0. When switching APP_DEBUG to 1 - it works fine.
I don't see any logs, so it's hard to understand why it happened.
Any thoughts?

HTTP error code 400 means "Bad request". It is expected to get such response if request is not valid.
With debug mode on you get nice error page with stack trace and other info.
The latest master has monolog logger installed. Please upgrade and check /var/log/* for errors. If there is any, then please report as another issue.

Thx for the fix. Can check it in a week

Hi @ramunasd,
Just now was able to test your change - it works fine. Thank you for the fix.

@ramunasd, just after the upgrade to the latest version, Satisfy stopped automatically adding new repositories using the webhook from GitHub. Can it be related to these changes you did recently?

Please make sure your parameters are correct

I checked, and for some reason, the github.auto_add_repo and github.auto_add_repo_type got lost during the update. So I added them back, restarted the web server, and still the same error and the message.
Could you please point me out what could be wrong?
Here is my parameters.yml file:
# This file is auto-generated during the composer install
parameters:
    secret: "my_own_secret"
    satis_filename: '%kernel.project_dir%/satis.json'
    satis_log_path: '%kernel.project_dir%/var/satis'
    admin.auth: false
    admin.users: {  }
    composer.home: '%kernel.project_dir%/var/composer'
    github.secret: "my_github_secret"
    github.auto_add_repo: true
    github.auto_add_repo_type: "github"

You didn't provider exact error message with stack trace. So I can only guess.
It may be two reasons:

You didn't clear the cache and auto-add is still not enabled
github payload does not have any of enabled source types(url types), please refer to config/defaults.yml

@ramunasd, interesting, when i'm enabling debug mode - everything works fine, but when I disabling - the auto-add flag isn't getting applied (debugged). Could you please explain of how the parameters.yml file is cached, and how to flush this cache?


ED2K Search & Crash with AzureWebAPI Hammering

LOG FILE
2017-04-07.zip
Windows Appilcation Event Log.txt
Description
I started with a clean install of Shoko Server <IP_ADDRESS>, an entirely new SQL Server database, and all fresh settings.  Shoko Server appears to be repeatedly hammering the AzureWebAPI for the same ED2K file over and over again.  After an amount of time, the application crashes with the attached Windows Application Event log.

The console status, marked in red above, does not change and hangs until the application crashes.  Meanwhile the Shoko Server logs shows hundreds of repeated entries of it trying to access the AzureWebAPI for the same ED2K.
STEPS TO REPRODUCE
I'm not sure how to specifically reproduce this in another environment, other than trying to submit the ED2K in the same manner to the AzureWebAPI to see what happens.
The steps I take, are:

Start Shoko Server
Watch it initialize
Watch the "Getting file info" not change
See the hammering of the AzureWebAPI in Shoko's logs
Then, after an amount of time, Shoko Server crashes.  The crash is not logged within Shoko's logs, but within Windows Application Event logs.

I should note, The file it is searching for has the following details, and has been tested good with no strange states to prevent it from being interacted with.
ED2K: F988E2B6D2F0A6C62E7773E5C93879BC
Filename: "Those Who Hunt Elves I - Ep 04[a4e].ogm"
Lastly, I'm not running anything else that ties into Shoko Server (e.g. Shoko Desktop, or any other plugins, etc.).

I've noticed this a little, but it's never forever and server breaking. I'll look at it and see if I can find an issue. I do have that exact file scanned correctly.

Something I just noticed after starting Shoko Server up after it crashes:
The "Getting file info from UDP API: #" increments +1, then stops (attached below in red).  Even though that number increment +1, the application is still hammering the AzureWebAPI with the same ED2K value.  It does all this until it crashes again.

Start the application again, and the number increments +1, searches for the same ED2K repeatedly, then crashes again after an amount of time.
I've attached new logs for the day after starting it up again.
2017-04-08.zip

I'm going to install Visual Studio 2017 on my file server to see if I can gleam any facts out of the Just In Time debugging options when Shoko Server crashes.  I'll post the results here, if any, when I'm done.

Don't bother, in already fixing it

I added a timeout


REFACTOR-#5910: remove _dtypes_for_cols internal function as unused

What do these changes do?

[x] first commit message and PR title follow format outlined here

NOTE:  If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

[x] passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
[x] passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
[x] signed commit with git commit -s
[x] Resolves #5910
[ ] tests added and passing
[x] module layout described at docs/development/architecture.rst is up-to-date

@AndreyPavlenko what about these changes?

@AndreyPavlenko what about these changes?

This function is not used.

@ienkovich what about this?

thanks @ienkovich!


Parse error syntax does not raise an error

When parse the expression like:
local xxx = true
if ~xxx then
   print("xxxx")
end

The parser does not report an syntax error.

Can you reproduce with latest git master?

The report provides very little context, but I believe the actual problem was fixed in af602e14ef887f735f64663fd722c6a44729c72c. Closing.


feat: support orgs and folders

What does this PR do?
This change allows us to collect log and REST API info from organizations and folders.
As a result, customers with multiple projects can be set up in 1 step.
This change should not be merged before the code
in repo google-cloud-functions is merged, I have tested the org/folder flow, and
before a deploymentmanager PR is written.
There are no expected breaking changes.
Limitations
Optional - delete this section if it's not necessary
Testing
I have tested that we can set stuff up for the terraflood project.

added some more changes to reduce permissions

i've tested that it works for folders. we can bring in the infra team to test orgs (the observeinc.com Google organization)


Index error on make_animator()

Hello,
I'm facing this issue when I run the colab notebook
ts = 30
anim = make_animator(hist_video, timesteps_per_transition=ts*2)
anim.save(f'/content/drive/MyDrive/fractal/{canonical_name()}.mp4',fps=ts, dpi=dpi)
plt.close('all')

IndexError                                Traceback (most recent call last)

[<ipython-input-43-f9d8f3393ede>](https://localhost:8080/#) in <cell line: 2>()
      1 ts = 30
----> 2 anim = make_animator(hist_video, timesteps_per_transition=ts*2)
      3 anim.save(f'/content/drive/MyDrive/fractal/{canonical_name()}.mp4',fps=ts, dpi=dpi)
      4 plt.close('all')

[<ipython-input-38-a74898fefe2e>](https://localhost:8080/#) in make_animator(history, timesteps_per_transition, reference_scale, cmap)
     39
     40   im2 = ax.imshow(
---> 41       jnp.zeros_like(history[1][0]), extent=em(history[1][1]), origin='lower',
     42       vmin = -1, vmax = 1,
     43       cmap=cmap,

IndexError: list index out of range

My best guess is that you should zoom farther in the interactive exploration cell a couple cells earlier. image_history records the sequence of regions you've looked at interactively. hist_video will then hold a sequence of frames zooming into your most recent location. Then the animation will animate that zoom sequence. But for that to work, you need to have zoomed in far enough in the earlier cell, that the last entry in image_history is zoomed in by several powers of 2 compared to where it was at initialization.

Thank you very much for your answer, but what I am trying to understand is that when I run the notebook as is without making any changes, I get this error. Could it be due to an update coming to the packages?

You need to interactively explore the fractal in the interactive
exploration cell from a few cells earlier. You shouldn't run the next cells
until after you've done that.
On Wed, Mar 20, 2024, 18:48 Mert Cobanov @.***> wrote:

Thank you very much for your answer, but what I am trying to understand is
that when I run the notebook as is without making any changes, I get this
error. Could it be due to an update coming to the packages?
—
Reply to this email directly, view it on GitHub
https://github.com/Sohl-Dickstein/fractal/issues/1#issuecomment-2011037769,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AADZW4EJRGQIX5CGKQSQYHLYZI37HAVCNFSM6AAAAABE5IKLROVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJRGAZTONZWHE
.
You are receiving this because you commented.Message ID:
@.***>


Support k8s gateway api in tenant gateway.

We need to consider using  k8s gateway api in tenant gateway.
Now we use custom TenantGateway CRD to describe kubegems api gateway. But k8s gateway api v1ahpha2 has been released last year(refer to https://github.com/kubernetes-sigs/gateway-api/releases/tag/v0.4.0).
Because nginx hasn't implement gateway api, we can choose one of the following ways:

Choose one of implemention at https://github.com/kubernetes-sigs/gateway-api/blob/master/site-src/implementations.md.
Wait for nginx's implemention, at https://github.com/kubernetes/ingress-nginx/issues/7517

Any further updates? @jojotong

Waiting for ingress-nginx's implement plan.


Config viewer

--print-config to show config in use and it's parameters

This will make integration testing with log viewer easier

Now changed to acs showconfig


[AMBARI-24988] Support provision_action in complex Add Service request.

What changes were proposed in this pull request?
Add request-level support for provision_action to the complex Add Service request.
Host component-level support will be added in a later change.
https://issues.apache.org/jira/browse/AMBARI-24988
How was this patch tested?
Tested requests with each of the 3 provision action types, as well as request without specific provision action.  For start-only, manually pre-installed all required packages.
After the requests completed, queried the service, component, and host component states to verify they are as requested.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/4689/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/4691/
Test PASSed.


ujson: disable escape_forward_slashes by default

otherwise ujson's output is incompatible with other jsonpickle backends
because it escapes the slashes in "py/object" etc.
also moved encoder options defaults to after all of the load_backend
calls, because previously those calls were overwriting the
encoder_options with ((), {}) for every encoder

Thanks, yeah, that's one of the worst defaults ever.


Tx sender

[TXS] Non-interactive headless client #359
. App Summary: https://github.com/OLSF/libra/blob/tx-sender/txs/README.md
. Remaining actions: https://github.com/OLSF/libra/issues/359#issue-806733658 -> Next Actions
Move keygen into a package and update its users: Consolidate terminal password entry #360

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.0 out of 2 committers have signed the CLA.:x: lpgeiger:x: simsekgokhanlpgeiger seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Invoke an alexa skill intent, not only a skill launch

NOTE: For a feature to be created it has to be doable in the Amazon app because we are basically replicating the app for HA. If you can't find it in the app, we probably can't create it here.
Is your feature request related to a problem? Please describe.
I currently use an alexa custom skill for actionable notification and another one for intents. I'd like to use only one.
The problem with this is that alexa skill intents have to be very generic in order to use it with Alexa Actions. This causes a lot of utterances conflicts.
Describe the solution you'd like
If it would be possible to directly launch an intent one custom alexa skill could handle both request made by voice interaction and requests made by Alexa Media Player without utterance conflicts.
The official Alexa REST API allows to do it, but as far as I know this custom component uses an unofficial API and I don't know if this unofficial API allows it.
Describe alternatives you've considered
Additional context

I don't understand the request. Please rephrase or provide a simple example.

Alexa media player allows to trigger a skill. This can be used to launch alexa actions custom skill.
This other custom skill allows to trigger home assistant intents from the custom skill intents (instead of sending events like alexa actions does).
I'm trying to create a skill that merges the functionalities of these two custom skills, and it would be simpler to do it if it were possible to directly invoke an intent via alexa media player.

Can the app do this?

I don't understand. Which app? Do what?


Mounting and auto crawling from S3

Hey
I did mount the S3 drive. I can see the files in the folder via terminal that I upload in my drive but Ambar is not auto parsing them. If I run docker down and then docker up -d it parses those files. This means that the drive is mounted but there is some other issue. It is actually work as a local crawler.
Can you please help me out with this?
Thanks in advance!

Hey Team
Is there any update with the same?


Improve interoperability with other linear algebra crates

It would be nice if rstar had first class support for other geometry crates, e.g. nalgebra or cgmath.
Up to now, users either need to

Implement their own point type (boiler plate / cannot easily use third-party point types due to orphan rule)
Use the built in point type (like [f64; 2], has only limited functionality)

One promising path forward might be adding support for the mint crate crate. Adding Point impls for the mint types should allow to add them to an R-Tree directly. Both  cgmath and nalgebra support mint already.
This issue originated from #25

Could this be closed as fixed with #134 now merged?

Agreed. Let's consider the mint support the canonical integration point as long as nobody asks for direct support of a particular crate like nalgebra.


[DOC] Stale documentations and doc versions

Many sections in the documentation are either

stale (e.g. http://mxnet.io/architecture/overview.html#operators-in-mxnet), or
provide deprecated/broken examples

For (1), I suggest that we maintain versioned documentations with release tags. (Even a simple "last updated" timestamp would help)
For (2), we need broader testing coverage. #5321

Same for examples scripts, i have seen several examples  that do not work out of the box (wrong args called, changed names, missing files) or need to follow some documentation that is not mentioned in the file.


[98] add query for curator comments

Solves: #98
Changes:

Free-text search now is capable of searching through the curator comments
Highlighter now works with combinations of terms (quoted)
DataGuideDialog component content was updated

Screenshots:
Searching for a case with free-text (content in curators comment):

Updated DataGuideDialog content:

Hey @shaileshmahajanBCH
There were some issues regarding the filers and text search combinations. Hopefully I managed to resolve them as well as searching for special characterd.


Add 'surround.vim' as a default plugin

From discussion on discord, I believe it makes sense to include surround.vim in our set of default plugins.
A few things needed here:

Add vim-surround as a submodule in vim\default : https://github.com/tpope/vim-surround
Add an attribution and link in the Bundled Plugins section in our README.md

Do you think there's a way we can expose an option to not load the bundled plugins? It would be good if instead of it being on or off for all plugins we had a hook on activate or somewhere else that specifies the bundled plugins with the default ones explicit on the default config.js.
E.G.
const activate = (oni) => {
  oni.plugins.load("wellle/targets.vim");
  oni.plugins.load("tpope/vim-commentary");
  oni.plugins.load("tpope/vim-unimpaired");
  // ...
};

@badosu - this is great feedback! I agree, I think this would be nicer than the oni.useDefaultPlugins option we have, as it is much more explicit. IMO It's not really clear how the oni.useDefaultPlugins behaves, what the ramifications of changing the value are, etc, and it changes if we decide to bundle a new plugin...
Actually, this is quite a bit in-line with what I'm starting to do with the plugins configuration option here in #1903 - the idea is you'd have a setting like:
"plugins": [
  "welle/targets.vim",
  "tpope/vim-commentary",
  "tpope/vim-unimpaired",
  "oni-plugin-live-preview",
  "oni-plugin-power-mode",
   etc...
]

The setting is actually there in master, but it is not fully implemented yet, so I don't recommend using it (yet). But I think semantically it is close, and with some relatively minor tweaks I believe it could fill this use case.

> Another idea is to not expose on config.js but if the hook is defined to override the default one, so this way we achieve 2 good things: users can have an very straightforward package bundler for when you don't want to inherit your init.vim or use NeoBundle, Plug, etc..; and we allow for minimalists to have a way to not load too much cruft.

Agree 100%. What do you think of using the `plugins` configuration setting for this? By default, we could populate it with our initial set of plugins, but the user could always scrap some.

The other consideration I had was deciding when we should check for updates for plugins. I was thinking about having an API call, like: `Oni.plugins.checkForUpdates()` that could be run in the `activate` method. Do you have any ideas there?

My hope is that we could deprecate the `oni.useDefaultConfig` configuration setting once we both complete the work in #973, and we have a more explicit model for managing the built-in plugins.

@bryphe as far as syntax goes, I prefer the array; less typing is good! For installation and updates I would prefer to have an explicit install and update function available in the config and also in the command palette; this is how Plug works:

@parkerault @bryphe Those are good ideas.
One improvement on that would be to provide a mechanism to specify a locked plugin, by denoting the ref for a plugin. This way we can choose locked versions for the bundled plugins to avoid nasty surprises and also provide flexibility for users.
A way to do it could be by specifying a hash, e.g.:
"plugins": [
  "tpope/vim-commentary",
  ["welle/targets.vim", { ref: 'abranch' }],
  ["tpope/vim-unimpaired", { ref: 'ac04411' }],
   // etc...
]

That reminds me, there are some plugins (vim-prettier off the top of my head) that require post installation setup; Plug handles this with a do block: Plug 'prettier/vim-prettier', { 'do': 'yarn install' }.

Hi!
Can I ask why you've chosen surround.vim over other alternatives? :)
As far as I'm aware, there are a few different attempts at 'surrounds' in vim so I want to know why Tim Pope's was chosen (aside from the fact that he writes some good plugins).
I have a personal preference towards for vim-sandwich? (feels more like the "vim way", has tests, more functionality) and I think if more people were aware of these alternatives, they might get a better shot at the limelight :smile:
Anyway, I guess I'm trying to say it's hard to please all the people all of the time and it's especially difficult when there's a bundled plugin that mimics something you're already using.
Thanks!

@joereynolds So I think that's a good example why we need to provide users a way to avoid loading select bundled plugins.
We can track the plugin load feature in #2020.

Since there is #2020 for the ongoing discussion, should we close this out now that @Muream has added this?

Agree, we can track the remaining issues in #2020 - like being more explicit about what is bundled / making it easy to opt-out / etc.
Thanks @CrossR , will close this out!


issue 2695 fix CONTRIBUTING.md build instructions

Fixes https://github.com/IBM/FHIR/issues/2695
Update instructions in CONTRIBUTING.md to reference the wiki pages
instead of duplicating build commands.

Fixes #2695
Update instructions in CONTRIBUTING.md to reference the wiki pages
instead of duplicating build commands.

Thanks Martin - we'll merge shortly (e.g. today)


next release

Hi, it would be great to publish the next release (0.8.0, I guess) now that we have a couple new API features which I'd like to depend on. Thanks again for this great crate!

It would also be nice to get a new version so we can eliminate the warning about future rustc incompatibilities, which it does look like is fixed in master.

@Kagami I echo the thankfulness for very handy crate. Much appreciated by the rav1e contributors.

Published v0.8.0. Thanks for heads up!


Fix typo: gPRC

gPRC (short perhaps for gRPC procedure remote call?) → gRPC

/milestone 1.23

/kind cleanup

Page preview:
https://deploy-preview-30709--kubernetes-io-vnext-staging.netlify.app/docs/reference/command-line-tools-reference/feature-gates/#feature-gates
/lgtm

/approve

LGTM!

@mehabhalodiya you can reply with “/lgtm” (on a line by itself) to confirm that this change is technically correct

@mehabhalodiya you can reply with “/lgtm” (on a line by itself) to confirm that this change is technically correct

Yes, but thought that /lgtm label is already added, so why not to write LGTM simply instead of label style!

/approve


Multiple chart URLs are not supported in index.yaml

There appears to be an unresolved TODO here:
https://github.com/helm/helm/blame/b0fdb5461fbc7e1b52f61613d3e7a22d85c7a794/pkg/downloader/chart_downloader.go#L241
// TODO: Seems that picking first URL is not fully correct
u, err = url.Parse(cv.URLs[0])

I think the expected behavior is that Helm goes through the list until one resolves. If the first URL does not return 200, should not resolve in error if subsequent URLs work.
apiVersion: v1
entries:
  nginx:
    - created: 2016-10-06T16:23:20.499543808-06:00
      description: Create a basic nginx HTTP server
      digest: aaff4545f79d8b2913a10cb400ebb6fa9c77fe813287afbacf1a0b897cdffffff
      home: https://helm.sh/helm
      name: nginx
      sources:
      - https://github.com/helm/charts
      urls:
      - https://technosophos.github.io/tscharts/nginx-1.1.0.tgz
      - https://some.other.amazing.chart.site.com/nginx-1.1.0.tgz  # <--- this is ignored
generated: 2016-10-06T16:23:20.499029981-06:00

cc @thomastaylor312

I think the expected behavior

That's the intent, yes. I don't believe it was ever implemented, though.
Seems like a good enhancement to the project should someone be willing to go through this.

If we do go through the list... Helm should make sure the chart doesn't just resolve but matches the digest listed on the record, right?

If we do go through the list... Helm should make sure the chart doesn't just resolve but matches the digest listed on the record, right?

Yes. I'm not sure thats being done either.
I can address these issues w/ a PR

checking in here to see what's the status on this ticket.

Excuse me, so this feature has been ignored... right? I believe in some cases, it might still be a useful solution.


chore: remove enable handlebar template config

chore: remove enable handlebar template config
This PR:

Removes all references to enableHandlebarTemplates
Removes deprecated applyLodashTemplates
updates snapshots for tests
remove old tests
rewords current tests a bit

metrics

enableHandlebarTemplates property from the even InitializeWorkspace has been removed.

Pull Request Checklist
Code
Basics

[x] code should follow Code Conventions
[x] circular dependency check: make sure your code is not introducing new circular dependencies in plugin-core.  See Avoiding Circular Dependencies.
[x] sticking to existing conventions instead of creating new ones

eg: if configuration for utilities are already in one module or package, add future utilities there as well

Extended

General

[x] check whether code be simplified
[x] check if similar function already exist in the codebase. if so, can it be re-used?
[x] check if this change adversely impact performance

Operations

[x] when shipping this change, will it just work or will it introduce additional operational overhead due to complicated interface or known bugs?

Architecture

[x] check if code is introducing changes on a foundational class or interface. if so, call for design review if needed

eg: making changes to DNode

Instrumentation
Basics

[x] if you are adding analytics related changes, make sure the Telemetry docs are updated

Extended

[x] can we track the performance of this change to know if it is successful?

eg: see usage for export pod

Tests
Basics

[x] Write Tests
[x] Confirm existing tests pass
[x] Confirm manual testing
[x] Common cases tested
[x] 1-2 Edge cases tested
[x] If your tests changes an existing snapshot, snapshots have been updated

Extended

[x] If you are adding a new language feature (graphically visible in VS Code/preview/publishing), an example is included in the test workspace
CSS

[ ] display is correct for following dimensions

[ ] sm: screen ≥ 576px, eg. iphonex, (375x812)
[ ] lg: screen ≥ 992px
[ ] xxl: screen ≥ 1600px eg. mac (1600x900)

[ ] display is correct for following browsers (across the various dimensions)

[ ] safari
[ ] firefox
[ ] chrome

Docs

[x] if your change reflects documentation changes, also submit a PR to dendron-site and mention the doc PR link in your current PR
[x] does this change introduce a new or better way of doing things that others need to be aware of? if so, an async should be created and a process added in Development or Packages

Close the Loop
Extended

[x]  is this a developer BREAKING change? if another person cloning from this branch will need to adjust their dependencies or mental model of the architecture, then it is. if this is the case, make sure this is communicated according to Close Loop

eg: breaking dev change due to new dependency

closes https://github.com/dendronhq/dendron/pull/3201

docs: https://github.com/dendronhq/dendron-site/pull/605


Add binary for generating dummy tsql files

Replaces ./llib/tests/generate_big.py with a new binary written in Rust named generate_tsql found under ./cli/bin/generate_tsql.rs.
Features that generate_tsql should implement:

[x] write to stdout (done in 369caf6f662b16592f5635f6e7538c9dcaa75b9e)
[ ] generate tables with foreign keys
[ ] generate tables with multiple primary key fields
[x] integrate "dummy generating" logic into ./lib so that other parts can use them without using Command::new (done in 6d8c4a3e7fcc89a596de4c400d38c87bcf1be224)

I rebased the the branch add_benches from main so that the new ci configuration is available in this PR.

Codecov Report

Merging #22 (593da45) into main (c4150ea) will decrease coverage by 10.6%.
The diff coverage is 0.0%.

Additional details and impacted files

Files Changed
Coverage Δ

cli/bin/generate_tsql.rs
0.0% <0.0%> (ø)

cli/src/helper.rs
0.0% <0.0%> (ø)

cli/src/main.rs
0.0% <0.0%> (ø)

lib/src/generate.rs
0.0% <0.0%> (ø)

lib/src/lib.rs
0.0% <0.0%> (ø)

lib/src/parser/mod.rs
0.0% <0.0%> (ø)

lib/src/parser/types.rs
4.2% <ø> (+<0.1%)
:arrow_up:

lib/src/types.rs
0.0% <0.0%> (ø)


Fix cluster provider which failed no ram nodes listed in cluster_status.

This PR fixes the cluster provider which failed when the output of rabbitmqctl cluster_status did not match the regexp passed to the match_pattern_cluster_status private method (in my case information about the ram nodes in the cluster).
To give an example, the ram_nodes private method would raise with the following rabbitmqctl cluster_status output because it looked for ram node information which is not present in my version of rabbitmq when I declare no such nodes.
[{nodes,[{disc,['rabbit@backends-vm','rabbit@failover-1-vm']}]},
 {running_nodes,['rabbit@failover-1-vm','rabbit@backends-vm']},
 {cluster_name,<<"dev">>},
 {partitions,[]}]

This PR make the match_pattern_cluster_status method return an empty string when the cluster_status does not match the provided regexp.

RAM nodes are not necessary in most cases. If node type is currently required by the cookbook, this is a mistake. They should be optional (default to disk), as it is in RabbitMQ.

Yes, ram nodes should be optional but as of version 4.0.0 of this cookbook, the newly-added cluster provider contains code that parses the output of rabbitmqctl cluster_status to look for ram node information. If that information about ram nodes is not present in the output of the subcommand then the chef-run will fail with an ugly NilClass NoMethodError. Hence this PR to make the parsing of rabbitmqctl cluster_status output more robust.
Line affected : https://github.com/jjasghar/rabbitmq/blob/master/providers/cluster.rb#L98

This PR is probably duplicate of #263 ; feel free to merge whatever implementation is best.


Feature request: make v-validate reactive

It appears that v-validate is a literal directive. It would be nice if it were reactive so that you could enable or disable validations under certain conditions. For instance, for a field that is sometimes required.
EDIT
I suppose a workaround (or perhaps what is the intended solution) would be to use a custom validator in this case.

I agree. It would be nice to pass in an expression to the directive so the validate parameter may be dynamic. It would go a long way to allowing an input field to be more generic and re-usable.

I'm going to support at next version.

Is this resolved? Here is a test
https://jsfiddle.net/jLcjzf08/
The rules.required.rule is dynamic, but the error message always show when empty input.
VueValidator version
2.1.4
Vue version
1.0.26

related #217
see more:
https://github.com/vuejs/vue-validator/issues/217#issuecomment-218099304
However, I found the other bug that cannot change the validation message. 😇
https://jsfiddle.net/kazupon/04nso4nm/1/
I'll fix try to it.

It means that I should define a custom validator to make it reactive?

@erguotou520
No.
I checked your reporting issue again.
validation rule and message did not become reactive.
This is bug.
I registered this issue.
https://github.com/vuejs/vue-validator/issues/284

Fixed
https://github.com/vuejs/vue-validator/releases/tag/v2.1.5

I means that I have to custom a validator to realize dynamic required?


notification API design refactor

This PR is depended by https://github.com/RackHD/on-http/pull/410

Remove WIP flag

@RackHD/corecommitters @yyscamper @anhou @WangWinson

*** BUILD #795 ***

test this please

*** BUILD #799 ***

:+1:

:+1:

There is dependency PR, so the Jenkins will never success, I have to force merge this PR.


3rd party autohotkey keyboard layout delayed typing, clunky, sluggish, fine in powershell

A brief description
When using the bone layout via 32bit autohotkey script that uses  DllCall("SendInput,xxx") to send inputs every keyboard input is sluggish. This is especially noticeable when holding backspace, in powershell etc. the cursor stops immediately when releasing the key, in bash on windows continues for quite some characters. It feels like a buffer is filled. Also the combination of capslock+c, which should return | returns ° instead. So I am not sure if the input to the ahk script is triggering the "bug" or the output, I am willing to investigate here.

However everything is working as intended when I start powershell and run bash in it.

Expected results
No sluggish typing, working like powershell.

Actual results (with terminal output if applicable)
sluggish typing

Your Windows build number
OS Name:                   Microsoft Windows 10 Pro
OS Version:                10.0.14393 N/A Build 14393

Steps / All commands required to reproduce the error from a brand new installation
Start bone.exe and start to type. Best to see if you type a long string an press backspace until it auto repeats and depress and watch the cursor.

Strace of the failing command
not applicable

Required packages and commands to install
bone.exe

Disable the BoneLayout inside of the console and enable it with the Linux Locale and Keymap settings.  WSL does very special processing on keyboard input and using sendinput will not work correctly with it.

Thanks for the discussion.
Closing this issue since:

This issue is old and may have been fixed in recent Win10 builds
Linux expects raw keystrokes so preprocessing keystrokes in Windows and then sending them into a Linux instance is likely to get very messy, very quickly. If you want to remap keys, try doing so from within Linux itself, rather than in Windows
This is the WSL issues repo, but this is an issue in Console which has its own Console GitHub Repo
GitHub doesn't allow issues to be moved between repos, preserving posters' identity :(

If you have further asks/issues, please file new issues on our Console GitHub Repo.


[BUG] Various Chains not able to use MAX send

Describe the bug
With various Chains it is not possible to use the max send button:

[ ] AVAX
[ ] OPTIMISM
[ ] BSC

Expected behavior
Possible to use the max button functionality
Additional context
For the L2 it is the same error as in #643 for ETH. Possibly more L2 are affected.
For BSC, BNB send it is possible due to a wrong gas amount usage and calculation. On iOS it prompts 2.5 GWEI and on android it prompts 1.5 GWEI.

https://github.com/vultisig/vultisig-ios/pull/745


Optimize quality and performance

JIMP is pretty neat because it doesn't depend on some binary (makes it easy to run anywhere) but performance degrades quickly with many images.
Also, the resized image quality could be better (noticeable when scaling down 1px lines in transparent PNGs).
These problems could potentially be remedied with using another library/binary. Maybe add a configuration option for the 'engine'.

See http://sharp.dimens.io/en/stable/performance/

JIMP now actually supports different resizing algorithms: https://github.com/oliver-moran/jimp#resize-modes

Yeah, performance goes down the drain as soon as you use this library in a real world scenario. I added a few images already the dev server takes 20x as long to boot up, I'm afraid to add anymore image.

Is there a way for a loader to do on demand loading when running the web pack dev server or do all images need to be processed before web pack can run?

Can we implement caching between dev server sessions to reduce that boot time?

I've had to pull this from my project as it's killing the build. I have about 30 large jpgs that it tries to generate srcset for and it just hangs. Sadly unusable in production at this time. Shame as it's the better one

Yeah, probably a sharp "adapter" would be quite useful. Any thoughts on if this should be optional (use sharp when it's present, otherwise fall back to JIMP) or if we just should drop JIMP because it's too slow in practice?
@sidonaldson how large are your JPGs?
FWIW, we use it in production to generate ~200 regular sized JPGs and PNGs, and the build takes around 5min on Codeship (including all other assets).

If we introduce a bypassOnDebug, what could it be applied to with jimp to reduce the number of operations performed?

👍 for retaining JIMP, for future users which would like to run Webpack compilations in the browser and user responsive-loader there.

I have a dirty WIP branch that's using sharp in case anyone wants to test https://github.com/langri-sha/responsive-loader/tree/sharp. I have about 50mb of images being processed and on my Intel m5 it used to take about 4 minutes with jimp and now it's down to ~15s.
Travis CI will need some tweaking to get sharp built inside their node-js container.

Closed via #29


Refactor how arguments are managed in nose tests

Currently the tests directory is added as the first argument in settings.json by the extension.
It would be better to prefix these directories with the corresponding -w flag.
This makes it easier for us to parse the arguments are remove the directories when running specific tests. When running a specific test, we do not need this first argument (in fact having it in there will cause all tests to run #1473).

We're planning to move away from nose, so closing this.


Problems creating security groups within Asgard

I am getting started with Asgard, and running into a wall early on in the process around creating security groups for an application. I am working with an account w/o Classic, and running in a VPC. The subnets have been given the immutable_metadata tags as described in the Wiki.
All steps are fine up until the security group creation step, what happens is as follows:

Application was created fine
Create SG for application appears to work at first, and in fact, the empty security group does get created in EC2
Asgard brings up the screen for editing the ingress, and on saving the result, complains the security group does not exist. (Which, per item 2, it does, as Asgard did create it ok)
Bringing up the security group list in Asgard, it (usually) does not list the security group, but does see pre-existing ones.
Through some combination of events I have yet to identify, sometimes the security group does appear in the list of security groups, however:
Trying to edit that group when it does show up, gets the same result where it doesn't think it exists.

This is seen in both the binary 1.5 release, as well as builds against the current HEAD.
I've not had time yet to trace through what might be happening, but will follow up with what I find when I do.
Any ideas in the meantime what might be going wrong here?

bump
Exactly the same issue here, which makes Asgard effectively useless. I see that this has been sitting, uncommented on, for 9 months. Is anyone at Netflix paying attention?

Questions @pdehlke , were you using the lastest master? I haven't had a chance to try again since I filed the ticket but the commits from March 20th look like they might have touched some areas that would have improved this (it sure seemed like an issue with caching security groups).
This commit in particular: 80ea2ced0474809e7104001d4da1f8737b6e51f5


Symbol's value as variable is void: help-mode-map

Repo url: https://github.com/clojure-emacs/clomacs
trace:
GNU Emacs 24.4.1
Copyright (C) 2014 Free Software Foundation, Inc.
GNU Emacs comes with ABSOLUTELY NO WARRANTY.
You may redistribute copies of Emacs
under the terms of the GNU General Public License.
For more information about these matters, see the file named COPYING.
cask exec emacs --script test/elisp/clomacs-test.el
UNDERCOVER: error while covering /home/travis/build/clojure-emacs/clomacs/src/elisp/clomacs.el
UNDERCOVER: please open a new issue at https://github.com/sviridov/undercover.el/issues
Symbol's value as variable is void: help-mode-map
UNDERCOVER: No coverage information. Make sure that your files are not compiled?
make: *** [test] Error 255

The same story for local make test run (local Emacs version GNU Emacs 26.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.14.5) of 2017-06-04).
Any ideas how to debug?

Looks suddenly fixed.

Sorry, I wasn't able to find time to properly investigate this issue. Happy to hear that it was resolved.


feat: chat timestamps

Fixes #186
Gets UTC from server-side and converts to local.

conflicts

oh they weren't there a minute ago lol


profile picture addition

Here, I have added my profile picture to the Hacktoberfest2020 repository

This is a pull request I have made to add my profile picture to the repository


Is there a way to initialize a Serial interrupt with arbitrary strings and not just the available delimiters?

It only supports single ASCII letter delimiters currently.

Thanks a lot! How do you add custom delimiters to the list?

You can pass a number and cast it to “delimiters”

What delimiters do you need and for what editor?


Add HTTP middleware support

Resolves #4

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 15 (100.0%)  changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.2%) to 75.941%

Totals

Change from base Build<PHONE_NUMBER>:
0.2%

Covered Lines:
1130

Relevant Lines:
1488

💛  - Coveralls


Ignore expired_token on non-revoke logout

When the user is attempting to logout, telling them their token expired
isn't particularly useful (after all; it's in the state they wanted it
to be...!). So, this patch ensures we don't throw an exception if the
user's token has expired.
However, we still throw one if the user was trying to revoke their
tokens. The assumption here is that silently failing might result in
them thinking their tokens were revoked when in fact they were not.
--
cc @sandersonet @gib

👍


Capture a windowed app

Hi.
I would like to capture windowed apps (non full Desktop) using the great DXGI performance. Given an process and its width and height, is DXGI capable to do it?

As I understand, DXGI is for fullscreen capture-only but if you are ok with performance, you can just cut out the desired rect.


Update package.ts

Task name: DownloadPackageV1
Description: Fix the function resolveLatestVersion
Documentation changes required: N
Added unit tests: N
Attached related issue: https://github.com/microsoft/azure-pipelines-tasks/issues/16003
Checklist:

[X] Task version was bumped - please check instruction how to do it
[X] Checked that applied changes work as expected
new branch with same changes as PR https://github.com/microsoft/azure-pipelines-tasks/pull/16002

@aasim Please review this pull request

Closing for now. If you'd like this change to proceed, please reopen it with additional details of what issue is being addressed by the pull request. Thank you.


[RTM]: add hover rule for lists

This pr adds the hover rule for the lists.

[x] Add for group statistics.

This pr is ready to merge. The pr #117  should be merged as first.


Doesn't compile on C++03 because of delegated ctor

Discovered in https://github.com/microsoft/vcpkg/pull/7429
    ImVec4(const sf::Color & c)                                         \
        : ImVec4(c.r / 255.f, c.g / 255.f, c.b / 255.f, c.a / 255.f) {  \
    }                                                                   \

Delegated ctor is a C++11 feature, so we shouldn't use it. Also funny how no one noticed it for such a long time - guess very-very few people use C++03 now. ¯_(ツ)_/¯

When I build your project, I have this error:
In file included from /Users/scemino/imgui-sfml/imgui-SFML.cpp:2:
/Users/scemino/imgui/imgui.h:198:5: error: delegating constructors are permitted only in C++11
    IM_VEC4_CLASS_EXTRA     // Define additional constructors and implicit cast operators in imconfig.h to convert back and forth between you...
    ^~~~~~~~~~~~~~~~~~~
/Users/scemino/imgui-sfml/imconfig-SFML.h:22:11: note: expanded from macro 'IM_VEC4_CLASS_EXTRA'
        : ImVec4(c.r / 255.f, c.g / 255.f, c.b / 255.f, c.a / 255.f) {  \
          ^~~~~~

Do you have a workaround or a fix for this ?
I build your project on MacOS 10.14.6 with clang 9.1.0.
Tell me if you need more info.
Thank you.

OK I found a workaround I added this line:
set(CMAKE_CXX_STANDARD 11)
after
cmake_minimum_required(VERSION 3.1)
and now it builds :thumbsup:

Hey, can you please check this on C++03 on latest master?
I've tried to fix it (but yeah, I'd recommend on staying on C++11, or better yet on C++17!)

Sorry now I have this, I know it has no link with this issue but...
$ cmake . -DIMGUI_DIR=../imgui -DSFML_DIR=/Library/Frameworks/SFML.framework/Versions/2.5.1 -DBUILD_SHARED_LIBS=ON
-- Found SFML 2.5.1 in /Library/Frameworks/SFML.framework/Resources/CMake
-- Found ImGui v1.73 in /usr/local/include
-- Configuring done
CMake Error at CMakeLists.txt:76 (add_library):
  Cannot find source file:

    /usr/local/include/imgui.cpp

  Tried extensions .c .C .c++ .cc .cpp .cxx .cu .m .M .mm .h .hh .h++ .hm
  .hpp .hxx .in .txx

CMake Error at CMakeLists.txt:76 (add_library):
  No SOURCES given to target: ImGui-SFML

CMake Generate step failed.  Build files cannot be regenerated correctly.

OK I had to remove imgui* files from /usr/local/include and now it builds.
Your commit fixed this issue.

Fixed in the latest commit. The problem was that by installing ImGui-SFML, you installed imgui.h in /usr/local/include and CMake tried to use /usr/local as a search path in FindImGui.cmake, which is something I don't want to have. So, thanks twice!


Add HttpClientHandler-parameter to constructor

We explicitly create an empty instance of HttpClientHandler in our constructor, this makes the API cleaner and easier to use but it's totally unnecessary if the user wants to create its own and use some of its functionality.
Current constructor:
public HttpCachingHandler(IHttpCache cache, ICacheKeyStrategy keyStrategy)
{
    _cache = cache ?? throw new ArgumentNullException(nameof(cache));
    _keyStrategy = keyStrategy ?? throw new ArgumentNullException(nameof(keyStrategy));
    InnerHandler = new HttpClientHandler(); //This should be moved to its own parameter
}

Fixed in https://github.com/joakimskoog/Cashew/commit/f76be90f39ef95a29c088f0225ba689f1710103d


How to get high-definition pictures

This is my code：
plotsr --sr syri.out --genomes genomes.txt -o 1.pdf -S 0.35 --chrord chrom -s 10000 -b pdf -H 12 -W 7 --cfg base.ctg &

I got 134k 1.pdf files:
1.pdf
but this picture doesn't look high definition， how to get the high-definition pictures？ thanks~

Did you mean to say that plotsr generated 134,000 output plot files all names 1.pdf? I do not think that is possible.
Have you tried the example commands in plotsr.sh  (https://github.com/schneebergerlab/plotsr/tree/master/example)? How did the output look?


[examples] Improve and test overview-urdf.py

Python example examples/overview-urdf.py is now executed by make test, using the in-repo ur5 by default.
I grabbed the occasion to make it more similar to the corresponding C++ file concerning the comments and the format of the outputs

Update: I modified example examples/i-inverse-kinematics.cpp to use JacobiSVD instead of BDCSVD. This way it is compatible with all Eigen versions and it can be executed on all systems, with no need of checking it in the CMakeLists


Remove Rubinius

require_llvm and locate_llvm should be removed too.

require_llvm and locate_llvm should be removed too.

Is it really prudent to remove the functions from ruby-build itself? One key feature of ruby-build is that the definition lookup path can be configured, so one can provide their own custom definitions. Even if the rubinius definitions are removed, removing the rubinius-specific functions would break any custom definitions that rely on them. This would be a pretty big compatibility-breaking change. Might there be value in keeping the rubinius functions a while longer? Or perhaps a deprecation phase would be beneficial to warn users that their definitions would break soon (with whatever release would actually remove the functions, assuming the rubinius removal actually moves forward).

What is the reasoning for dropping Rubinius support in ruby-build? I actively use Rubinius and have in the past week installed Rubinius 3.16 via ruby-build. In fact I would have installed the latest version 3.19 if #911 was already merged.

I will close this.
We can passively maintain rubinius. ref. https://github.com/rbenv/ruby-build/pull/1035


D bindings: deterministic sub-struct order

Hopefully it's all good now :sweat_smile:

2 small bonuses:

I found a default parameter in bgfx.h that wasn't in bgfx.idl, so I've added that now.
Corrected sub-structs having extern(C++, "bgfx") instead of just extern(C++). This wouldn't have broken anything before, but could've in a future bgfx API version.


descriptor_test.go:fix test

Signed-off-by: zhouhao<EMAIL_ADDRESS>

This seems like it should be part of #547.  But I think descriptors
should REQUIRED mediaType 1, in which case we'd need neither.

This is also incorrect. Closing.


With cfswrap the path is hard coded to /root/go/bin  (not good)

Rethink how the cfswrap works with a path
I wonder if it would be better to use https://golang.org/pkg/os/exec/

Fixed in #64


Bump version: NirSoft.ChromeCacheView from 2.45 to 2.51

Checklist for Pull Requests

[x] Have you signed the Contributor License Agreement?
[x] Resolve #201813

[!WARNING]
This is an attempt squashing following 2 changes into a single pull request.

Removal of outdated NirSoft.ChromeCacheView version 2.45
Addition of latest NirSoft.ChromeCacheView version 2.51

Manifests

[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[ ] This PR only modifies one (1) manifest
[x] Have you validated your manifest locally with winget validate --manifest <path>?

[x] Does your manifest conform to the 1.9 schema?

Note: <path> is the directory's name containing the manifest you're submitting.
Manual validation

Microsoft Reviewers: Open in CodeFlow

cc @ItzLevvie


[Improvement] Update the Dark Mode button content from text to icon

What to do?
Remove the text of the dark Mode button and add icon to it.
You can check out the icon that I am saying on Reactjs documentation page, Click here to view.

hey can give more info? What does it look like currently and what do you want it to look like?

hey can give more info? What does it look like currently and what do you want it to look like?

Currently, the button look like

I want the button should be like below:

For light mode

For Dark mode

I dont seem to find the button anywhere on the live website. Where it is?

Hey @c00kie123 You can view the button of darkMode on all pages other than index.html

@arpitghura hey i have solved this issue. Can you assign it to me. I'd like to make a pull request.
i added   in practice.html.

similarly, I added  to about and profile page also.
Then i added js to change the icon from moon to sun using
function change (iconID){     if(document.getElementById(iconID).className=="bx bx-moon dark-btn"){       document.getElementById(iconID).className = "bx bx-sun dark-btn";     } else{       document.getElementById(iconID).className = "bx bx-moon dark-btn";     }   }

and called it whenever needed.
here is a video attached to show that its working:
https://user-images.githubusercontent.com/71315985/215354809-5e2c73e5-95be-4ba4-8fbb-fb2a110ff76b.mp4

Hey @chikkibum Welcome to the community. You have done a good job. I will assigned the task to you. You can now create a PR.


Reduce stdout from LIS/AGRMET

In LIS 7.4, reduce the standard output from the LIS/AGRMET Ops runmode.  Specifically, observation QC info should only be written by PET 0.
This should significantly reduce the collective size of the log files.  It is even possible the wallclock time will be reduced since less data is written to the filesystem.

This is still a TODO.  Probably worth doing to reduce output (and resulting runtime penalty).


Adding dummy.txt to storage dirs

Fixing https://github.com/graphite-project/graphite-web/issues/2193
Also, upgrade manual for next release should include instructions to remove all /opt/graphite/storage entries from /opt/graphite/lib/graphite-web-x.x.x-pyx.x.egg-info/installed-files.txt file before the upgrade.

Codecov Report

Merging #2259 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2259   +/-   ##
=======================================
  Coverage   79.58%   79.58%
=======================================
  Files          85       85
  Lines        8848     8848
  Branches     1894     1894
=======================================
  Hits         7042     7042
  Misses       1545     1545
  Partials      261      261

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1e6020...6960f24. Read the comment docs.


Ship logs from paas-billing into Logit

What
Describe what you have changed and why.
How to review
Include the latest build of paas-billing once https://github.com/alphagov/paas-billing/pull/80 is merged.
Make sure the logstash config changes get applied to our Logit stacks.
Who can review
Not @46bit

Woo. Logs from paas-billing in Logit with @source.deployment set to DEPLOY_ENV.


Edpub 1399 & EDPUB-1400: Create Dashboard page for Add/edit form

Description
Create Dashboard page for Add/edit form
Spec
See Ticket: EDPUB-1400
EDPUB-1399
Validation
I have added Inputs and Forms options in the nav bar for ADMINS Can be removed later

got to baseurl/forms
Click on + Add forms to add new forms
Click on Shortname to edit the form
All fields are mandatory before you submit the form.

Blocked by concurrent API PR requested changes: https://github.com/eosdis-nasa/earthdata-pub-api/pull/157#pullrequestreview-2455281043


Remove unused params from NetworkHelperImpl.start method

The contributions of this PR are:

Removed unused params ("User" and "Account") from:

method that does nothing with the variables:
com.cloud.network.router.NetworkHelperImpl.start(DomainRouterVO,
Map<Param, Object>, DeploymentPlan);
method that calls the "NetworkHelperImpl.start" method:
com.cloud.network.router.NetworkHelperImpl.startVirtualRouter(DomainRouterVO,
Map<Param, Object>);
method from the interface :
com.cloud.network.router.NetworkHelper.startVirtualRouter(DomainRouterVO, Map<Param, Object>).

removed _ from variables names: the use of _ at the
beginning of private variables is common in C++ but not in Java;

changed access level of some variables from protected or public to private;

removed unused variables.

Hi @GabrielBrascher .
I think this params are removed in this PR https://github.com/apache/cloudstack/pull/1447
=)
Ty.

Where did you two analyzed that? How did you two find this problem?
How about opening a Jira ticket detailing the problem, so we can have a log of it.
Please, pick one of the PRs and close the other.

@rafaelweingartner
I will open a Jira, the way that I found the problem was described in an answer to Daan Hoogland in the same PR.
Ty

@rafaelweingartner
Done. the Jira is CLOUDSTACK-9343 if you can take a look.
Ty

Thanks for noting @pedro-martins.
As you stated this issue before, I will close mine PR.
Unless you think that another of proposed modifications are worth to keep this PR; I can address this PR to those changes (change of acces level, removal of unused variables and _ from beginning of variables names).

@GabrielBrascher I think it is better to close it.


Add editor with terrain generator and egui integration

Added dotrix_egui crate for integration with EGUI
Added dotrix_terrain crate for terrain generation
Added template for editor application

To try it out run
cargo run --release --bin editor

Great work!
I Implemented your request to Input
Removed some whitespaces, I use VS Code with Strict Whitespace (sidp.strict-whitespace), it's great plugin
and Modified EXPERIMENTAL_TRANSLATION

Great work!
I Implemented your request to Input
Removed some whitespaces, I use VS Code with Strict Whitespace (sidp.strict-whitespace), it's great plugin
and Modified EXPERIMENTAL_TRANSLATION


WPF binary in VMR main

Build: https://dev.azure.com/dnceng/internal/_build/results?buildId=2413372&view=logs&j=fa5c2909-0e29-5671-d5eb-16d6c40e0c4a&t=2a0bd486-3f67-5c59-da0c-b84d88848a4b
A new binary from WPF has been introduced to the VMR's main:
src/wpf/src/Microsoft.DotNet.Wpf/src/Shared/Tracing/resources/MSG00001.bin

@ellahathaway - Can you please investigate?

Build with passing binary scan: https://dev.azure.com/dnceng/internal/_build/results?buildId=2414648&view=results


IndexError: list index out of range for /analysis/dflt/sumary/

I've set up a new Qiita instance in productive mode. The log files repeatedly list the following error. I assume this is due to the fact, that not a single analysis is present yet:
[E 240219 10:15:35 web:1669] Uncaught exception GET /analysis/dflt/sumary/ (<IP_ADDRESS>)
    HTTPServerRequest(protocol='https', host='localhost', method='GET', uri='/analysis/dflt/sumary/', version='HTTP/1.0', remote_ip='<IP_ADDRESS>')
    Traceback (most recent call last):
      File "/home/qiita/miniforge3/envs/qiita/lib/python3.9/site-packages/tornado/web.py", line 1590, in _execute
        result = method(*self.path_args, **self.path_kwargs)
      File "/home/qiita/miniforge3/envs/qiita/lib/python3.9/site-packages/tornado/web.py", line 3006, in wrapper
        return method(self, *args, **kwargs)
      File "/home/qiita/miniforge3/envs/qiita/lib/python3.9/site-packages/qiita_core/util.py", line 83, in wrapper
        return func(*args, **kwargs)
      File "/home/qiita/miniforge3/envs/qiita/lib/python3.9/site-packages/qiita_pet/handlers/analysis_handlers/listing_handlers.py", line 98, in get
        info = self.current_user.default_analysis.summary_data()
      File "/home/qiita/miniforge3/envs/qiita/lib/python3.9/site-packages/qiita_db/user.py", line 500, in default_analysis
        qdb.sql_connection.TRN.execute_fetchlast())
      File "/home/qiita/miniforge3/envs/qiita/lib/python3.9/site-packages/qiita_db/sql_connection.py", line 49, in wrapper
        return func(self, *args, **kwargs)
      File "/home/qiita/miniforge3/envs/qiita/lib/python3.9/site-packages/qiita_db/sql_connection.py", line 336, in execute_fetchlast
        return self.execute()[-1][0][0]
    IndexError: list index out of range
[E 240219 10:15:35 web:2161] 500 GET /analysis/dflt/sumary/ (<IP_ADDRESS>) 51.84ms

I think that one is because the user doesn't have a default analysis, which should be created during the user creation step. Which user are you using and how did you create it?

I have used "sign up" through the Qiita website and manually "verified" the user via setting the user_level to 4

That makes sense, bring back to unverified and use this code (this is what's run when you use the GUI):
from qiita_db.user import User
email =<EMAIL_ADDRESS>User.verify_code(email, User(email).info['user_verify_code'], "create")

works perfectly. Thanks!


std::bad_alloc() in sampler

I am trying to run DeepDive and the following error when the sampler executes. It looks like it could be an internal error, or an out-of-memory error (my machine has 64GB of RAM). If it is the second, is there a workaround that doesn't involve increasing the amount of available memory?
Thanks!
2016-12-21 10:46:10.453492 #################MACHINE CONFIG#################
2016-12-21 10:46:10.453509 # # NUMA Node        : 1
2016-12-21 10:46:10.453528 # # Thread/NUMA Node : 16
2016-12-21 10:46:10.453545 ################################################
2016-12-21 10:46:10.453563
2016-12-21 10:46:10.453580 #################GIBBS SAMPLING#################
2016-12-21 10:46:10.453598 # fg_file            : factorgraph/meta
2016-12-21 10:46:10.453616 # weight_file        : /dev/fd/63
2016-12-21 10:46:10.453634 # variable_file      : /dev/fd/62
2016-12-21 10:46:10.453651 # factor_file        : /dev/fd/61
2016-12-21 10:46:10.453669 # output_folder      : weights
2016-12-21 10:46:10.453685 # n_learning_epoch   : 1000
2016-12-21 10:46:10.453703 # n_samples/l. epoch : 1
2016-12-21 10:46:10.453720 # n_inference_epoch  : 1000
2016-12-21 10:46:10.453737 # stepsize           : 0.01
2016-12-21 10:46:10.453754 # decay              : 0.95
2016-12-21 10:46:10.453765 # regularization     : 0.01
2016-12-21 10:46:10.453794 ################################################
2016-12-21 10:46:10.453806 # IGNORE -s (n_samples/l. epoch). ALWAYS -s 1. #
2016-12-21 10:46:10.453815 # IGNORE -t (threads). ALWAYS USE ALL THREADS. #
2016-12-21 10:46:10.453825 ################################################
2016-12-21 10:46:10.453834 # nvar               : 14745098
2016-12-21 10:46:10.453844 # nfac               : 889500491
2016-12-21 10:46:10.453854 # nweight            : 162212221
2016-12-21 10:46:10.453863 # nedge              : 889500491
2016-12-21 10:46:10.453873 ################################################
2016-12-21 10:46:39.942907 terminate called after throwing an instance of 'std::bad_alloc'
2016-12-21 10:46:39.942999   what():  std::bad_alloc
2016-12-21 10:46:40.410893 process/model/learning/run.sh: line 22: 76438 Aborted                 sampler-dw gibbs -w <(flatten factorgraph/weights) -v <(flatten factorgraph/variables) -f <(flatten factorgraph/factors) -m factorgraph/meta -o weights -l 1000 -s 1 -i 1000 --alpha 0.01 --sample_evidence
2016-12-21 10:46:40.420499 find: ‘pbzip2’ terminated by signal 13

@paidi that does seem like OOM... The log content suggests that you were probably running an old version of DeepDive (v0.8). In an upcoming release (coming soon), we'll introduce a factor graph partitioning feature, where a partitionable factor graph is processed piece by piece in memory. We haven't written up the documentation for this yet, but if you want to try it now using master (git clone and then make build; make install), the "census" example has turned on this feature:
https://github.com/HazyResearch/deepdive/blob/master/examples/census/app.ddlog#L23
https://github.com/HazyResearch/deepdive/blob/master/examples/census/deepdive.conf#L3
In words, you can enable partitioning by changing two places in your DD program

In app.ddlog, add @partition to the appropriate column (e.g., doc_id) of the variable relation.
In deepdive.conf, add sampler.partitions: $NUM_PARTITIONS, where $NUM_PARTITIONS is the number of partitions.

Internally, DeepDive partitions the graph based on the hash value of the column marked with @partition.

Thanks for the quick response! I will try that today.


Roll Flutter Engine from 76a1c64f4e63 to 6a65b8c649c6 (5 revisions)

https://github.com/flutter/engine/compare/76a1c64f4e63...6a65b8c649c6
2024-08-15<EMAIL_ADDRESS>Reverts "[Impeller] migrate blur tests to display list. (#54519)" (flutter/engine#54564)
2024-08-15<EMAIL_ADDRESS>[Impeller] migrate blur tests to display list. (flutter/engine#54519)
2024-08-14<EMAIL_ADDRESS>Roll Fuchsia Test Scripts from J1EXQ2ozMIQEa6F7H... to -XDS8eBA0Le-zCEfW... (flutter/engine#54561)
2024-08-14<EMAIL_ADDRESS>macOS: Refactor create_macos_framework.py (flutter/engine#54557)
2024-08-14<EMAIL_ADDRESS>Roll Fuchsia Linux SDK from MeV5i7xXXFPHF5sBK... to qpfC-GAVZvOwAQU5f... (flutter/engine#54559)
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from MeV5i7xXXFPH to qpfC-GAVZvOw
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


When button disabled but still can click on icon

If you have a button tag that is disabled and you have an icon in it. You can still click on the icon to get the waves effect.

1

http://0.media.dorkly.cvcdn.com/36/35/6603dc5a9292104b44c349b85b5aaf7a-5-crazy-fan-theories-that-make-total-sense.jpg

Under what circumstances? I'm trying to recreate the issue but I can't seem to. Can you post the HTML markup that it doesn't work with?

@coltonfitzgerald The code we used:

      <button id="submitLoginForm" class="btn waves-effect waves-light blue darken-4">Login

    </button>

I've submitted pull #970 as a fix for this.

@lamoni Thank you for the fix!

@TheRinseM gladly!

But here's the thing. (Correct me if I'm wrong) I thought you use the class ".disabled" to disable buttons whereas you are setting the attribute "disabled="true"" with that line of jQuery

Adding class of 'disabled' to buttons actually doesn't stop the waves-effect either.  Assuming someone else doesn't do it, I'll add that check in as well.

Thank you for the fix.

Fixed in 345af00


TypeScript definitions for @styled-system/should-forward-prop

Hi,
I'm using TypeScript with @styled-system/should-forward-prop but can't find any type definitions in @types or within the module itself. TypeScript recommends installing @types/styled-system__should-forward-prop but it's not a package.
Are there type definitions available for the module?
If not I'm happy to attempt a PR.
Thanks

Sorry for the delay on this! If you'd like to add types for this package on Definitely Typed, please feel free to do so. Since that code is in another repo, I'm going to close this issue for the time being

No problem! thanks for getting back to me. I'll take a look at the types in @types.


Questions about project roadmap and adoption

Hi folks,
First of all, thank you for all the work you've done to create this Kotlin Spark API.
My company is evaluating using kotlin-spark-api for our Spark pipelines. As you know, when evaluating a new library, we need to ask ourselves if it is being actively maintained and assess any risks of becoming too dependent on it.
Thus, please allow me to ask the following questions:

What are the future plans for this project?
What is the current status regarding integrating it inside the official Spark API? I see that the SPIP discussions haven't been active since last July
Is the project officially and actively maintained by JetBrains? Is it also being used internally at JetBrains?

I believe that having answers to those questions would be beneficial to my company, other companies or projects that may be wondering the same things when evaluating kotlin-spark-api, and perhaps help reassure people and increase adoption in the short/medium term.
Thanks!

Hi there!
I recently joined Jetbrains to help with the Spark API specifically. This means it is now definitely actively maintained :).
In the short term, we are looking at streamlining the project so that releasing the API for the latest couple of Spark versions, as well as Scala versions, can be done quicker and more easily. It's namely a bit difficult at the moment.
In the long term there are also some ideas for features that are not present yet. Feel free to leave an issue if you think something should be added!
As for the official Spark API, we know as much as you do. Apache probably does not want their project to depend on the Kotlin libraries, so official integration by Apache will likely not be a thing. That said, .NET is also not officially supported by Apache, but there's also a Spark API for that, so if we can keep it as "official" as that, that's good, right?

Hi @Jolanrensen
Congrats on the new gig!
That is great to hear. Thank you for all those precisions


ci: use Go 1.23rc1 for unit and integration tests

Blocked on the resolution of https://github.com/golang/go/issues/68124.


Return complete list of DDL commands for creating foreign keys in SQLite

fixes #3351

@B4nan Could you please review? If this works for you, I could revise all other SQLite commands to follow the same pattern.

@B4nan Could you please review? If this works for you, I could revise all other SQLite commands to follow the same pattern.

Looks very promising. It is unfortunate though that it is not possible to return the generated commands directly from toSQL(). @kibertoad Have you considered changing that function to return a Promise? (Although that would be a rather heavy breaking change)

Looks very promising. It is unfortunate though that it is not possible to return the generated commands directly from toSQL(). @kibertoad Have you considered changing that function to return a Promise? (Although that would be a rather heavy breaking change)

Yes, exactly. Heavily breaking change and one not needed for the majority of cases.

Yes, exactly. Heavily breaking change and one not needed for the majority of cases.

Hence the new metod generateDdlCommands.

Hence the new metod generateDdlCommands.

Finally had some time to review this, it looks good but it there are some issues:

sometimes the meta queries are there (like pragma ...), which I am not interested in
other drivers need to be probably adjusted too, like in mysql the renameColumn now prints show fields from author where field = ?; instead of the actual rename query. also looking at the implementation I would very much like just a rename column query, while it tries to be too smart and fix FKs and indexes too (which I have already handled myself just fine, and wont to have control over those) - could it be at least configurable?
the TS typings are wrong, it says there will be array of strings but its actually array of objects with sql and bindings keys
what is the exact purpose of the pre and post arrays? so far i never seen anything filled in there. would be great if those could be used for the "too smart" queries i mentioned about the mysql's rename column method, so i can just ignore them this way


Figure out how to handle users with empty names

Some thoughts:
Currently users with empty names may appear in the list of users. This happens when a user does not complete the signup process, i.e. fill out their profile with name, email, and student ID.
To avoid this we could, upon user creation, set their name and email to the ones retrieved from GitHub. This would still require users to set their student ID.
However, in many cases a user will not have set a name on GitHub. Additionally, the user would have to go through extra steps to update their name on QuickFeed if it does not match their full name.
Currently a user is restricted from navigating away from the profile form if their user information has not been filled in. This can be circumvented if someone truly wants to, enabling a user to enroll in courses. Additionally, nothing stops a user from sending a CreateEnrollment request using their cookie without having filled in their user information.
To avoid the scenarios in the previous paragraph, we could disallow creation of enrollments where a database user does not have (name, email, student_id) set.
If we allow users to enroll in courses only if their user is valid, and disallow nullifying any of the user (name, email, student_id) fields, we could safely purge incomplete users from our database. This could be done alongside #308

The above stuff sounds good to me. Although, not sure it is worth the extra effort to prevent enrollments... but maybe it is easy (didn't check).
But what if we add a check along these lines in auth.go:
func checkExternalUser(externalUser *externalUser) error {
	if externalUser.Login == "" {
		return errors.New("missing login")
	}
	if externalUser.Name == "" {
		return errors.New("missing name")
	}
	if externalUser.Email == "" {
		return errors.New("missing email")
	}
	return nil
}

We could check that the name has at least two components (first and last name), and that the email is a proper email, and if this check fails, we refuse to create an account on quickfeed. Hopefully the frontend would somehow explain what we didn't like about their GitHub account profile.
We could even require that they use a @uis.no email, but that is perhaps a bit too much.

Yes, I agree with your concerns about privacy. Looks like the best approach would be to implement Canvas integration.


File Handler does not show custom actions on folders

Category

[x] Question
[ ] Documentation issue
[x] Bug

Expected or Desired Behavior
I've configured the file handler manifest as described in the reference by setting a custom action with the folder attribute set to {}, in order to enable the action on folders.
Precisely, the action packaged in my manifest is similar to the following one:
{
  "type": "custom",
  "url": "https://localhost:3000/api/something",
  "displayName": "Do something",
  "shortDisplayName": "Do",
  "icon": {
    "png1x": "https://localhost:3000/icon.png"
  },
  "availableOn": {
    "file": { "extensions": ["*"] },
    "folder": {},
    "allowMultiSelect": true,
    "web": {}
  }
}

Observed Behavior
The action is shown by OneDrive only on files, not on folders.
Steps to Reproduce

Register a file handler with a custom action supporting folders to a specific app registration.
Enable the app on a OneDrive for Business account.
Go to OneDrive on cloud: selecting files the action is available, selecting folders it is not.

Thanks.

Hi, any news about it?

Hi, we've started taking a look into this issue but don't have any status to report yet.  We'll come back with more info as soon as we are able to repro the issue in-house.
Thanks for the bug report!

Hi @JeremyKelley, have you some updates for this issue?

Hi @JeremyKelley, any news?

To help you in the troubleshooting, I reproduced this problem with your official markdown file handler sample.
As you can see, the file handler is enabled since the file https.md has the expected custom icon, but the menu has no custom menu with the action "Add to ZIP file - debug" on the selected folder:

This is the result for GET /_api/v2.0/drive/apps?select=*,promoted&expand=actions.
@JeremyKelley I'm still waiting for your feedback.

As part of a repository clean up effort we are closing older issues. If this issue remains, please: open a new issue, reference this issue, and provide any additional details that may help in resolution. Thank you for your understanding as we work to improve our responsiveness.


feat: Add Log Directive

Related issue(s)
Resolves log statement issue in noir-lang repo: https://github.com/noir-lang/noir/issues/383
Description
This includes a Log directive and the logic in the PWG for solving it.
Summary of changes
I added a Log directive that takes a LogInfo enum. This enum can either be finalized string output or a vector of witnesses whose data has to be fetched when solving the circuit. I then added the logic for printing single values and arrays in the PWG. This logic follows similar logic from acir gen when we can construct a finalized output string.
Dependency additions / changes
(If applicable.)
Test additions / changes
(If applicable.)
Checklist

[ ] I have tested the changes locally.
[ ] I have formatted the changes with Prettier and/or cargo fmt with default settings.
[ ] I have linked this PR to the issue(s) that it resolves.
[ ] I have reviewed the changes on GitHub, line by line.
[ ] I have ensured all changes are covered in the description.

Additional context
(If applicable.)

Out of scope, but noting for reference: We won't be able to have the equivalent of templating just yet. ie format!(" x: {value}")
For that LogInfo would probably need to be Recurisvely defined. We can open up a future issue/PR for this


annotation on shape

Either the implementation and/or the spec in incomplete/buggy on annotations for shapes.
In the spec there is

Annotations provide a format-independent way to provide additional information about elements in a schema. They appear in lists in Shape, OneOf, EachOf and TripleConstraint's annotations.

and there is

[18]    	shapeDefinition 	   ::=    	(extraPropertySet | "CLOSED")* "{" tripleExpression? "}" annotation* semanticActions

However the Shape in the ShexR and json has no property for annotation, but the EachOf can have an annotation. So the shape annotation can be moved the EachOf object.
However when running the following code
PREFIX : <http://hl7.org/fhir/>
PREFIX xsd: <http://www.w3.org/2001/XMLSchema#>

start = @<ObservationShape>

<ObservationShape> {
  :status xsd:integer;
}
// :test "val"

Gives

error parsing input schema:
Error: unknown property: "annotations" in Shape: {"type":"Shape","expression":{"type":"TripleConstraint","predicate":"http://hl7.org/fhir/status","valueExpr":{"type":"NodeConstraint","datatype":"http://www.w3.org/2001/XMLSchema#integer"}},"annotations":[{"type":"Annotation","predicate":"http://hl7.org/fhir/test","object":{"value":"val"}}]}

Additionally I would prefer if the syntax would look like as
<ObservationShape> {
  // :test "val"
  :status xsd:integer;
}

fixed in https://github.com/shexSpec/shex.js/commit/c008d62c0e38677ce8ea8147983b25682f4f5b61
and yeah, your alternative syntax does make more sense.


Prep for distro

Includes "final" original_images and data fixture, with readme tweaks.

@heymonkeyriot Please try:

rename your bakerydemodb
migrate up a fresh db
./manage.py load_initial_data

and let me know if everything is working.
I don't have postgres working yet (coming), but loading up a fresh sqlite seems fine from this end.


chore: correct fix

:tada: This PR is included in version 2.19.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Test case not reported when wrapped in FLET

I discovered a surprising behavior.
I expected these two test cases to be equivalent:
(define-testcase ex1 ()
  (assert-condition (error "example") error))

(define-testcase ex2 ()
  (flet ((wrapper ()
           (assert-condition (error "example") error)))
    (wrapper)))

but running them provides different reports:
> (ex1)
Name: EX1
Total: 1
Success: 1/1 (100%)
Failure: 0/1 (0%)
Condition: 0/1 (0%)
Outcome: Success
#<CONFIDENCE:TESTCASE-RESULT :NAME EX1 :CONFIDENCE::TOTAL 1 :CONFIDENCE::SUCCESS 1 :CONFIDENCE::FAILURE 0 :CONDITION 0 {10026FA963}>

> (ex2)
Name: EX2
Total: 0
Outcome: Success
#<CONFIDENCE:TESTCASE-RESULT :NAME EX2 :CONFIDENCE::TOTAL 0 :CONFIDENCE::SUCCESS 0 :CONFIDENCE::FAILURE 0 :CONDITION 0 {10028CB343}>

How come EX1 correctly reports one successful test while EX2 reports no tests?

Thank you, I'll add this to the test suite, it should definitely work as you mean.
If you feel like having a look by yourself, you can start here
https://github.com/melusina-org/cl-confidence/blob/main/src/testcase.lisp#L185
but I'll give it a close look very soon! Thanks!

I see that we are code-walking here. I suppose that's prone to this kind of error. Could this work be done in macro-expansion instead of code-walking somehow to reduce the potential errors surface?

My $0.02 is that the simplest and most robust approach is to factor code into plain functions, or failing that into plain macros, and only as a last resort into code-walking. Here we could fix the FLET case by beefing up the code walker but it still would be incomplete e.g. not able to follow subroutine calls.
My gut feeling is that there's a simpler solution here where the restarts etc code that needs to be injected into tests/assertions is written in a plain function and the testcase/assertion macros expand into a thin bit of code calling those functions (and the code walker wouldn't be needed.)
I am no fun, I know, suggesting that Lisp's distinguishing features should be used sparingly if at all :grin:

I rewrote the DEFINE-TESTCASE macro to reduce relying on code walking. It only look for defined ASSERTIONS in code so that conditions are detected when arguments are evaluated. (This is a non-breaking change.)
The new version of DEFINE-TESTCASE relies on signals and handlers to instrument the invocation of defined ASSERTIONS.
https://github.com/melusina-org/cl-confidence/blob/3d1509c19d15f08a6bc6c8e5c24070222d758a9c/testsuite/testcase.lisp#L84


Switch to a new iPhone

I've switched to a new iPhone and had the App installed on the old one. If you choose sync Data via Bluetooth to the new iPhone, the Coronawarn-App is there. But you can't enable Risk-Detection.
You can start the App, enable Risk-Detection via Selector.
The only way is to delete the App and Reinstall to enable Risk-Detection. But all Data is lost from  the old iPhone.
I think that's essential, if someone switching the Device.
Hope this helps.
Switch from iPhone7 to iPhone11 - same iOS Version.

Unfortunately, this is currently not supported by neither Google nor Apple. We are tracking this as an idea in the wishlist repository (corona-warn-app/cwa-wishlist#8), but as stated there, this will not be implementable by the Corona-Warn-App but needs to become part of the Exposure Notification Framework.


iOS7  issue

It`s really nice project. but I run this demo use iOS7+ environment, it cause AutoLayout issue. please check it out.

Unfortunately, this project uses the UIPresentationController API, which is only available on iOS 8+.


Naming uniformity: element-animal -> element-subject ?

Other elements are named after their respective primary tables (e.g., lab.Lab and session.Session). element-animal stands out as unique with subject.Subject. The language might also be a minor roadblock for future human-subjects researchers.

Making this changes would be broad in scope across elements, with many small edits across almost all existing workflows. Holding off pending discussion of the best timing for this change.

Thanks @CBroz1.  Good catch.  For human subjects, what do you think would be the best naming scheme for the package, schema, and tables?

To use for human subjects, several tables would become unnecessary (e.g., Cage, SubjectCullMethod). Long term (i.e., U24 Year 3+), I think we could develop an alternate element or schema within the current element with more human-relevant tables, such as medical history. In the short term, I think we should preserve consistency of mapping element name to element primary table.

That sounds good.  I do not think that this will cause backwards incompatibility requiring a migration script (Issue #22).

I'm good with this change

Thanks all.  I will make the updates today for element-animal to element-subject, and will submit for @CBroz1's review.  Then we can rename the repository on GitHub.

We will also need to modify this package on pypi.
@CBroz1, could you please reach out to Raphael to determine who has the credentials and how to do this?

modify this package on pypi.

@kabilar just met with Raphael who suggested the following as our release process

Confirm new name availability ✅  and within-team consensus (flag for Dimitri?)
Issue one more release on old name, inclusive of a readme doc warning disclaimer pointing to the new one. In our current case, this can be a separate PR before merging the outstanding one.
Issue an internal engineering request ticket for Drew (on this first occasion, also include Raphael)

Note: PyPi releases cannot be pulled back only flagged as 'bad' while issuing another.

Thanks @CBroz1.

@dimitri-yatsenko, we are confirming the package name change from element-animal to element-subject.
Will submit new pull requests today.
Once confirmed by Dimitri, please submit the internal ticket for element-subject.  We will not be releasing element-interface on pypi at the present time.

The decision was made to preserve the current naming scheme, discussed here.