update makefile, workflow, and docs

Description of the change:
The purpose of this PR is to:

migrate logic of x.mk into main Makefile and remove x.mk
update .github/workflows/e2e-tests.yml workflow to use main Makefile
update .gitignore to avoid tarfile checkin
add Makefile documentation
update readme documentation with usage and examples
enhance scripts/package_release.sh to run sed correctly on multi platform (linux and Mac)

Motivation for the change:
As a prelude to adding new end to end tests, I wanted the ability to run individual tests. At first glance the main makefile seemed like it had not been updated to use the new BDD tests, and it was pointed out that x.mk makefile was serving this purpose. During the last weekly call it was suggested that we move the make target logic in x.mk to the main makefile.
Reviewer Checklist

[ ] Implementation matches the proposed design, or proposal is updated to match implementation
[ ] Sufficient unit test coverage
[ ] Sufficient end-to-end test coverage
[ ] Docs updated or added to /docs
[ ] Commit messages sensible and descriptive

@benluddy Thanks for the quick review. I made the changes to the PR, but I see that ci/prow/e2e-upgrade and ci/prow/e2e-aws-console-olm failed. Are these the result of common build failures? Also note that DCO is failed... I added a signature to my last commit, but apparently that's not enough. Just wondering if these items are critical, and if so, what would need to be done to resolve them.

@benluddy Thanks for the quick review. I made the changes to the PR, but I see that ci/prow/e2e-upgrade and ci/prow/e2e-aws-console-olm failed. Are these the result of common build failures? Also note that DCO is failed... I added a signature to my last commit, but apparently that's not enough. Just wondering if these items are critical, and if so, what would need to be done to resolve them.

@benluddy Thanks for the quick review. I made the changes to the PR, but I see that ci/prow/e2e-upgrade and ci/prow/e2e-aws-console-olm failed. Are these the result of common build failures? Also note that DCO is failed... I added a signature to my last commit, but apparently that's not enough. Just wondering if these items are critical, and if so, what would need to be done to resolve them.

Neither test failure is related to your changes. The console failure looks to have been a flake (it hit a 503 attempting to download a test dependency), and the upgrade failure is a problem with the downstream test infrastructure.
The DCO check requires all commits in a PR to be "signed off," so you'll need to amend the first commit and rebase in order to satisfy that one.

@benluddy Thanks for the quick review. I made the changes to the PR, but I see that ci/prow/e2e-upgrade and ci/prow/e2e-aws-console-olm failed. Are these the result of common build failures? Also note that DCO is failed... I added a signature to my last commit, but apparently that's not enough. Just wondering if these items are critical, and if so, what would need to be done to resolve them.

Neither test failure is related to your changes. The console failure looks to have been a flake (it hit a 503 attempting to download a test dependency), and the upgrade failure is a problem with the downstream test infrastructure.
The DCO check requires all commits in a PR to be "signed off," so you'll need to amend the first commit and rebase in order to satisfy that one.

@benluddy Don't want to pester you, but I am not sure on the process here... I read through https://github.com/kubernetes/community/blob/master/contributors/guide/owners.md#the-code-review-process but have questions. Should I preemptively do an assignment of an approver or should I wait for a looks good label and then do the assignment of the approver?

@benluddy Don't want to pester you, but I am not sure on the process here... I read through https://github.com/kubernetes/community/blob/master/contributors/guide/owners.md#the-code-review-process but have questions. Should I preemptively do an assignment of an approver or should I wait for a looks good label and then do the assignment of the approver?

@jchunkins Most of the people in OWNERS tend to check in on PRs in need of review from time to time, so I don't think it's strictly necessary to assign a reviewer in order to get a PR approved.
Opened https://github.com/operator-framework/operator-lifecycle-manager/issues/1976 for an apparent flake in some of the test teardown behavior.
/retest

@jchunkins Most of the people in OWNERS tend to check in on PRs in need of review from time to time, so I don't think it's strictly necessary to assign a reviewer in order to get a PR approved.
Opened https://github.com/operator-framework/operator-lifecycle-manager/issues/1976 for an apparent flake in some of the test teardown behavior.
/retest

/test e2e-aws-olm

/test e2e-aws-olm

I think folks have reviewed, but there has not been a LGTM or Approve yet. Just wondering if there is any further work I need to do before this can be merged?

I think folks have reviewed, but there has not been a LGTM or Approve yet. Just wondering if there is any further work I need to do before this can be merged?

/lgtm

/test unit
/test e2e-upgrade

/test e2e-upgrade

Github showed that I had a branch conflict, and I resolved it (just a readme update) and re-ran tests which removed the LGTM comment.
@kevinrizza Can I get a repeat LGTM?
@benluddy Can you approve?

/approve

/lgtm


Issue 74 : Added new dale chall readability

#74
Compute the following equation:
Raw Score = 0.1579 * (PDW) + 0.0496 * ASL
Raw Score = Reading Grade of a reader who can comprehend your text at 3rd grade or below.
PDW = Percentage of Difficult Words
ASL = Average Sentence Length in words
If (PDW) is greater than 5%, then:
Adjusted Score = Raw Score + 3.6365,
otherwise
Adjusted Score = Raw Score
Adjusted Score = Reading Grade of a reader who can comprehend your text at 4th grade or above.
Test cases passed:
Ran 26 tests in 0.086s
OK

@akarsh3007 excellent, thank you 🎉
Could you address the style issues from pycodestyle in the Travis run?
$ pipenv run pycodestyle textstat/
textstat/textstat.py:341:80: E501 line too long (83 > 79 characters)
textstat/textstat.py:352:12: E111 indentation is not a multiple of four
The command "pipenv run pycodestyle textstat/" exited with 1.

$ pipenv run pycodestyle test.py
test.py:232:80: E501 line too long (83 > 79 characters)
The command "pipenv run pycodestyle test.py" exited with 1.

@alxwrd Done.


Send HighFrequency move events always

Even when not hovered. Also don't allow blocking.
Needs testing as InputManager implements this interface (no blocking may have adverse effects).

Unnecessary, found a better method. Let's leave as it was for now.


Adding new connector will not update size of Node

I tried adding new connecter both output and input connector dynamically. Result wasn't good the connectors were going out from the node itself. I used the default css provided in demo .Here is the picture:

Anyone else having this problem? any workaround?

you can modify this by going to flowchat/node.html and add the width to ng-attr-style you can add a attribute to newNod model in app.js that contain the numbre of connector and set the width dynamically

@hachimi, how you create node like (yes, no, maybe). Can you please suggest here.


Customising the UI

The basics are in place and I'm now considering some simple customisation. Do you have any pointers over how to avoid the over-writing of any customisations by subsequent re-generation of the sources? Is it simply a matter of re-applying any customisations with the help of source control?
I'm also wondering whether errors as raised in https://github.com/jaxio/celerio-angular-quickstart/issues/16#issuecomment-271977077 are likely to cause problems - has this issue been fixed yet?
Thanks for a great product!

As long as you can, you should modify the code generation templates.
But at one point manual customization in the generated code is necessary.
Celerio, the code generator, when it detects a manual modification, generates the file in a different folder you may use tools such as araxis merge or win merge to select the generated code snippet that you want.
You may find some useful info here:
http://www.jaxio.com/documentation/celerio/modification.html
in particular:
http://www.jaxio.com/documentation/celerio/modification.html#collisions-and-merging

Thank you - that sounds promising.


Allow Frontends to bind to a Listener for routing

Frontends should be able to bind to a specific listener (e.g. <IP_ADDRESS>:8000) and route those requests to the frontend regardless of the Host header.

cc @klizhentas

For a specific use case, I want to be able to run a java app in a docker container with both http and jmxremote ports exposed randomly, and use vulcand to forward requests to the standard ports to the appropriate port on the back end.

A Port Matcher would resolve this problem


New: Noysi logo

Noysi logo. Cheers
https://www.dropbox.com/s/j3yifdz0yn3lt5l/_icon_N.ai?dl=0

Added 0b0cbcf7f319a23e11d3424fe55eed088d9729b3
Thanks


Export to Garmin, heartrate missing

if you would like to import exported GPX to Garmin Connect (GC), you will notice HR is missing.
this is due to the fact GC accepts HR only as INT, not with values these are exported by default with decimals, like 100.00.
to fix this, just update the line:
f"gpxtpx:hr{int(point.heart_rate)}</gpxtpx:hr>"
Also I have indentified few more "Workout types":
if summary.type == 1:
return "running"
elif summary.type == 6:
return "walking"
elif summary.type == 9:
return "cycling"
elif summary.type == 10:
return "indoor_cycling"
elif summary.type == 16:
return "other"
elif summary.type == 23:
return "indoor_rowing"
elif summary.type == 92:
return "badminton"
elif summary.type == 8:
return "treadmill_running"

Thanks! I added these changes in https://github.com/rolandsz/Mi-Fit-and-Zepp-workout-exporter/commit/daab25d5a776cec25d08f812c01abd81bac1c53c and https://github.com/rolandsz/Mi-Fit-and-Zepp-workout-exporter/commit/471daa1b4d0296b57b8c0f1896cef75c9cd74375.


More flexible view handling.

Currently this is using pure javascript to handle template loading and view rendering.
The template loading is done using the import statement, which is only really supported in chrome. Simple, nice. Not portable.
We need to select a template/render process that has more broad browser support, ideally something flexible enough to let the module user decide how he wants to render the views / load the templates himself?

Ideally this should be able to use different storage options - however for portability it may be best to just target localStorage initially?

I had intended to use chromes chrome.storage.sync - particularly because it has built in event handling for broadcasting data changes - obviously this imposes a limit Im now looking to avoid.


Update goreleaser to v2

coverage: 69.308%. remained the same
when pulling b1ede2e2488acd4f3c21230ce41d752dbd9fb7e3 on goreleaser-v2
into 1dfc44d37b72c1bb67009dfdd055c92ca04bd962 on main.

coverage: 69.308%. remained the same
when pulling d2868020152e701f0bc33095dc89b48a2f5b751f on goreleaser-v2
into 1dfc44d37b72c1bb67009dfdd055c92ca04bd962 on main.


UI refactor issues with context menus and hotbars

Description
The right-click options for survival boxes in bags seem to not work, as well as the "Close UI" options for bags. The "Close UI" did not work for the salvage bag, I am unsure about other bags. Lastly, emergency tanks in the pockets do not seem to have an icon that appears on the left hotbar, and breath masks seem to not appear either.
Reproduction
Attempting to right-click a survival box, no menu appears. Equipping an emergency oxygen tank and breath mask do not make the icons appear on the left for quick use. I have not tried with a normal-sized oxygen tank.
Screenshots
I do not have any screenshots that would suffice.
Additional context
N/A

Already fixed in https://github.com/space-wizards/space-station-14/pull/11867


Add links to Examples in the README

Hey Jason,
I've been eager to try your library for like EVER now, but I never knew where to begin.
I recently integrated Hop.cash into my platform Smartstarter and had the pleasure of working with Jonathan Silverblood's codebase, which makes great use of your library.
I'm looking forward to extending my knowledge of your APIs, but I'm strongly encouraging you to provide a few "practical" examples for the "average" developer to get started. Similar to what BitPay's Bitcore Lib Cash does in their README.
I LOVE that fact that your library is PURE JavaScript.
"THIS IS THE WAY"
As soon as I can make the time, I intend to replace Bitcore Lib Cash with Libauth for my own primary SDK NitoJS.
I've been so frustrated with Bitcore Lib Cash over the years as it really DOESN'T play well with others. Not even other/older versions of itself, I mean srsly wtf is THAT about?? And try adding Bitcore Mnemonic in the same app, because you HAVE to import it first, otherwise it'll error out some cryptic message.
Anyway, I'm happy to contribute to this effort, but I'd like some guidance from you as to "how" to construct these examples. Due to how "low-level" your API is, examples could be quite long. I look forward to connecting soon..
Cheers!
Shomari

Hi Shomari, I got a notification that you linked here from reddit, sorry I missed responding before!
I wrote more about the roadmap for Libauth in this comment – some relevant bits:

Please feel free to send a PR fixing any of the existing infrastructure as you find useful. Just a heads up, I'm going to have to make very deep changes in transaction generation code to support simultaneous compiling of multiple transactions by multiple entities + some other features required for proper support for decentralized application transactions. This is likely to change the TX generation API almost entirely, so you may prefer to just vendor whatever you need directly into your own library for now.
[...]
I've made no attempt to make P2PKH wallets easier to create/use with Libauth (basically every JS library does that well already). Instead I'm working from the most advanced transactions backwards: it's very hard to take a simple P2PKH transaction construction API and make it support more complex compilations using multiple contract types, interactions between inputs/outputs, fee estimation, etc. (I think that's why we still don't have this support in any libraries 10+ years later.) But once this advanced stuff is working, I'll build some simpler P2PKH-specific "shortcut" tooling that makes P2PKH transactions as easy as other libraries.
[...]
I'm working on these changes right now, and I'll be pushing them to the v2 branch as soon as I have something to share. It's a huge effort though, so I expect it may still take me several months. I'll put out Libauth v2 betas and release candidates as soon as this refactor is done.

Most of v2 is already very stable, but once the new transaction creation infrastructure lands, I plan to overhaul https://libauth.org to focus around guides, and the existing generated documentation will just be reference material. I would love to take PRs contributing docs/guides!


Question: What correct way to add index have type GeoPoint ?

Please use the following questions as a guideline to help me answer
your issue/question without further inquiry. Thank you.
Which version of Elastic are you using?
[ ] elastic.v2 (for Elasticsearch 1.x)
[ ] elastic.v3 (for Elasticsearch 2.x)
[ ] elastic.v5 (for Elasticsearch 5.x)
[ x] elastic.v6 (for Elasticsearch 6.x)
Please describe the actual behavior
I want to add index to elastic search mapping like this
{
  "mappings": {
    "business": {
      "properties": {
        "location": {
          "type": "geo_point"
        }
      }
    }
  }
}

But I have failed when add index in go lang, when assign GeoPoint have a struct
	Location  *elastic.GeoPoint     `json:"location,omitempty"`
}

tmpIndex.Location = elastic.GeoPointFromLatLon(lat, lon)

But when add I got a message
elastic: Error 400 (Bad Request): failed to parse [type=mapper_parsing_exception]

Hmm... in the test mapping, it is defined as a geo_point but marked as a string. You can also define it as a *GeoPoint, but then you need to run .Source() to properly serialize into JSON.
But I agree that's not very obvious and marked it as issue #813.


How to reproduce the -P flag functionality in the remote API

What JSON element do I need to include in the /containers/create API call which mimics the -P flag? I tried:
{
	"Image": "foo",
  	"HostConfig": {
  	  	"PublishAllPorts": true
  	}
}

but every container (after being created and started) always has the same port:
"Ports": [
  	{
  	  	"PrivatePort": 8080,
  	  	"Type": "tcp"
  	}
]

I want each container to be provisioned with its own external port number, forwarding to whichever port required inside the container.

I'm looking for a solution for it too.
If I stop/start containers using the Rest API, my containers (with self-signed ports mapping before) are losing these ports mapping. I can access the running services into the containers using the internal ip address but not using my localhost:bound_port.
Apparently, the argument -P or -p are available during the creation container phase, but if we stop and start these containers via API the ports just gone.
If we use the 'docker stop/start ' on the terminal, that works, but not using the Rest API.

on start you need to pass publishAllPorts see https://github.com/docker/docker/issues/7869#issuecomment-54679108


Reset after deleteFile gives status error

Type of issue

[X ] Bug report

Uploader type

[X ] Traditional

Bug Report
Fine Uploader version
5.16.2
Browsers where the bug is reproducible
Chrome
Operating systems where the bug is reproducible
Win. 10
Exact steps required to reproduce the issue
Click to upload the file.
Click button outside of Fine Uploader to delete the file & reset.
All relevant Fine Uploader-related code that you have written
function addTask() {
	var postdata = {};
	postdata.listID = listID;
	$.post('ajax/addTask.php', postdata,
			function(data) {
				uploader.deleteFile(0);
				uploader.reset();
	});
}
//addTask.php copies the file from the upload folder to a network share.

Detailed explanation of the problem
It seems like the reset is trying to happen before the deleteFile is finished.
If I remove the reset, all works fine.

How is this a fine Uploader issue? Don’t call reset until the delete operation completes.

OK, then how can I tell if the delete operation is finished?

Oops sorry, I found the callback events:
https://docs.fineuploader.com/api/events.html


[Core] Set allow-preview from config for extension dynamic installation

Related command

Description

Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change
[Component Name 2] az command b: Add some customer-facing feature

This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] The PR title and description has followed the guideline in Submitting Pull Requests.

[ ] I adhere to the Command Guidelines.

[ ] I adhere to the Error Handling Guidelines.

Core


Figure out branch deploys

I want to deploy the docs for 4.0.3 and keep them available while I'm working on the next iteration.

tag: 4.0.3 should deploy to sphinxawesome.xyz/release/
master should continue to deploy to sphinxawesome.xyz

There should be something in the footer that allows users to navigate to a different version.

Or I can just use the Netlify preview until I'm happy with the results, duh.


More granular control over CRUD options

Hi team,
Currently, it is possible to either have CRUD options or disable them via the MakeReadOnly method. Therefore, making CRUD all or nothing. It would be good if there were options to disable create, but enable read and update for example.
Not sure where to pick up the code exactly, just raising the idea. Let me know, happy to take a look into it.

Closing this issue. Can continue the discussion on the open PR #75


Basic functions with PyWiFi.intefaces not working. (Python 2.7.12 - Win 10)

I am on Windows10 with python 2.7.12
`>>> wifi.interfaces()[0].scan()

wifi.interfaces()[0].scan_results
<bound method Interface.scan_results of <pywifi.iface.Interface instance at 0x0313CAF8>>
wifi.interfaces()[0].scan_results()
Traceback (most recent call last):
File "", line 1, in
File "C:\Python27\lib\site-packages\pywifi\iface.py", line 39, in scan_results
return wifiutils.scan_results(self.__raw_obj)
File "C:\Python27\lib\site-packages\pywifi\win\wifiutils.py", line 30, in scan_results
network['ssid'] += "%c" % bsses[i].dot11Ssid.ucSSID[j]
IndexError: string index out of range
wifi.interfaces()[0].status
<bound method Interface.status of <pywifi.iface.Interface instance at 0x0313CAF8>>
wifi.interfaces()[0].status()
Traceback (most recent call last):
File "", line 1, in
File "C:\Python27\lib\site-packages\pywifi\iface.py", line 74, in status
return wifiutils.status(self.__raw_obj)
File "C:\Python27\lib\site-packages\pywifi\win\wifiutils.py", line 186, in status
data = wifiapi.PDWORD()
AttributeError: 'module' object has no attribute 'PDWORD'`

is the error.

Did you try running pywifi in python3 env? Because I wrote pywifi in python3 env, I am not quite sure it can run on python2 env now

Well.. I was using py2

I'm mostly use py2 because that's what most people use. (Like even most
professionals use it over py3)
On Oct 6, 2016 11:13 AM, "Awk"<EMAIL_ADDRESS>wrote:

Did you try running pywifi in python3 env? Because I wrote pywifi in
python3 env, I am not quite sure it can run on python2 env now
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/awkman/pywifi/issues/8#issuecomment-252011706, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ACCNyfWJaY1xZ7547kLSrGcXC-LDyMWNks5qxR42gaJpZM4KOTdo
.

Any idea if this can be looked into?

After I fix issue #10, I will try to test pywifi under py2.7 and evaluate is it possible to support py2.7. I am not quite sure about how many py3 features now pywifi depends on...

I think what needs to be considered is the way python 2.7 handles imports compared to python 3.X as well as some syntax changes. Might not even be worth going to 2.7 as the differences between the two are quite large.
Heres a handy little article:
http://sebastianraschka.com/Articles/2014_python_2_3_key_diff.html

So should I just continue searching for a py2.7 compatible wifi lib and just close this? Because I need to stay on 2.7 (I have many reasons)

Up to awkman I suppose, whats your aim with the use of this lib?

Well I am mostly interested in being able to get the wifi BSSID around me. So I can make a script to auto connect to some APs. (Like the free ones at McDonalds.)

Im working on something similar as a small project. At its current version the code I linked is quite messy however it gets bssids and ssids and stores then in a dict for easy access. Probably works for 2.7

I can make the current version ( Just now downloaded from repo) load and work by just changing the way that the metaclass is defined.. (Do it the python 2 why that is still correct for python 3).
And it appears to work. (Scan works and scan_results works. Still testing other stuff)

Okay the network_profiles works (Sort of one of the networks around me has a key type that errors it out. WPA2) I also know how to patch it so that status works (Python 2.7 ctypes.wintypes does not have PDWORD but if you copy the line that defines it from cytpes.wintypes on python 3 it works)

@chibill Good news!! Is it convenient for you to send a PR after you finish the modification and test under python 2.7? I would learn from the patch and try to merge it into pywifi!!

I can.  Not sure about the strange stuff with WPA2 it seems odd. (But that exists in. Python3)

I mean the problem with that exists in py3 also

Could you share the error message?

I know why its erroring.   https://github.com/awkman/pywifi/blob/master/pywifi/win/wifiutil.py#L43-L47 Does not contain a value with the key WPA2 (Which is the auth type my schools wifi uses when looking at the xml file)

Oh... I don't start to plan to support other key mgmt type now. That's because I don't have the environment to test them. I think we should add one more key mgmt type like 'OTHER' to skip it.

True..  I wonder how you could handle them. (Why do you use a dict there anyways?)

I didn't consider other auth type at that moment, so I adopted dist here.
I want a unified expression for key mgmt while getting the scan result or assigning the ap profile.
So, I think keep them as integers is better.

Okay. Currently they are only used for network_profiles. And adapting them to use the string directly actually removes so if statements from the add_network_profile. (Would only need to check for if its open)
I will leave that alone as I am just interested in getting it python 2 compatible.

@chibill  Thanks for your idea and PR, I merge your PR now.

Okay. So this can be closed now. :)


Add support for nan/inf in parsing/writing with rapidjson

Can't pass writeFlags to rapidjson::prettyWriter with latest release v1.1.0 of rapidjson-dev, the issue is as described here: https://github.com/Tencent/rapidjson/issues/905#issuecomment-370981353
We would need to build rapidjson from source to capture the latest fixes.
However, PrettyWrite is only used for displaying model configs internally currently, so this should not be an issue.


Fix autohide when cursor is on buttons, change all buttons to blue except hangup

Fixes #237
Fixes #236

@samdutton could you take a look?

LGTM.


add support for .pptx format

Reference Issues/PRs
#12
What does this implement/fix? Explain your changes.
Any other comments?

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 72.08%. Comparing base (4502890) to head (0812921).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev      #31   +/-   ##
=======================================
  Coverage   72.08%   72.08%
=======================================
  Files           4        4
  Lines         154      154
  Branches       42       42
=======================================
  Hits          111      111
  Misses         36       36
  Partials        7        7

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Dear Sadra, I will handle errors and exceptions in the next PR. If it's possible, skip it in this PR
@sadrasabouri


Improved robustness of changed url resolution

I gave this some additional QA time and found that it was not quite robust enough. Depending on if the user provided a trailing slash on path in their gulp config the URLs would sometimes resolve incorrectly. The code now accounts for a trailing slash, no trailing slash and no path at all.

Can you take a look at pull request #15 and the use of url object?  I think it makes creating the url a bit cleaner and is in the standard format for use with the url module.

I am re-working where the paths are generated and how the tests work.  I've created a windows VM that I can run the tests on so that I can get the test suite to work on each OS.
The biggest problem is the the use of symlinks to mimic intermodule dependencies.
Work is being done here until I'm ready to pull: https://github.com/kmcgrath/condensation/tree/develop

Where are you using symlinks? condensation itself is (or was) working ok for me on Windows previously?

Just the tests, not condensation itself.
The test projects contain symlinks to test loading particles from other projects. ProjectC, for instance, has symlink to ProjectA to test the integration of the build with dependencies.

Ah yes. That also prevented me from running mocha in recursive mode as those directories contain js files that are not tests.
I see these sample projects as text fixtures. Is there a node convention for where fixtures go?

They will normally be in a fixtures directory.  The small issue with mocha is that --recursive will look for any .js file and run it as a test.  The integration tests for condensation have fixtures that are .js files.
To accommodate for this, I created a fixtures and tests directory under test.  Now mocha can run with --recursive on test/tests.
You can see the new layout in my personal repo https://github.com/kmcgrath/condensation/tree/develop
I have some re-worked unit tests passing on both linux and windows and I'm almost ready to pull it back into a branch in the SungardAS account.  The end goal is to have the test suite run on both operating systems with each producing paths to files natively.  Then it will not be necessary to fake file paths in unit tests.

Ok. I still think there may be some use in being able to test both scenarios as a mocked unit test as well as having end to end tests validating it but I don't feel very strongly about it.
Do you still need me to go in and refactor it to use a URL object for the base? Should I wait until your pushed back in?

I hope to have these changes pulled over by the end of the weekend.  So hold off on anything until that happens.
I will probably close this pull request and open a new one when that happens.

Closing this pull request to work on the new feature branch: https://github.com/SungardAS/condensation/tree/feature/windows-paths-and-tests
On the new branch the full test suite runs on both Windows and Linux.
Work is being moved to issue #17


Use demucs in container with GPU instead of CPU

First pass at passing the hosts GPU to the container.

Sort out image tagging, right now it's just making an arbitrary image locally
Consider adding a param to specify which model to use
Consider specifying which GPU to pass, if multiple are present?
Improve pytorch versioning so we don't have to delete it and reinstall it

Other things we might as well fix:

Quotes in the file name don't seem to be applied when passing into the docker run command
Makefile is in home directory, but inputs are in /inputs, so you might want to provide: make run track=input/myfile.mp3 but that actually passes data/input/input/myfile.mp3

Tested with RTX 3080, splits 4 segments in about 10 seconds.
re #21

Great work @aavetis , thanks for contributing!
Totally agree, right now we're building the latest version losing previous versions. It would be great to follow semantic versioning: image:<major>:<minor>:<patch>.
The first approach of this repository was building the image every time you ran the make run Makefile target. But it was slow the first time and I decided to move it to Docker Hub. After that, @adefossez improved the performance of the build by having a more lightweight image and removing some of the dependencies.
For all these movements we applied the latest tag to the image so it's good to keep up-to-date with the latest version but the developer cannot specify which version want to use (also talking about the version of the facebook/demucs that right know we always clone the latest version from the main branch).
As you commented, it would be great to have a better organisation in terms of docker images being able to:

Choose which version of the facebook/demucs we want to use (maybe this is not the priority but something to take into account)
Choose which platform: ARM / AMD architectures, supporting the use of Mac M1
Use the Docker Image version similar to a GIT tag in the repository following semantic versioning
Choose between running the Demucs using the GPU or without it

Regarding the previous topics, we could focus on this pull request in the last one "Choose between running the Demucs using the GPU or without it". For the other topics, I'll create different "discussions" for each topic to find the best way to implement them.
To do so, we would need to keep the current Dockerfile version (without GPU) and create another one using the GPU of the host. I guess we could create a folder called docker and there add both Dockerfiles:
docker/
    python.Dockerfile -> current `Dockerfile` without GPU
    nvidia.Dockerfile -> using the GPU

Then in the Makefile we can define 2 targets:

run: using the python.Dockerfile without GPU
run-gpu: using the nvidia.Dockerfile

Thanks again and any doubt let me know 💪🏽

@aavetis - Didn't know if you planned to get back to this soon? Also ran across this and saw you already took a stab at it - thanks for that! Looks like it should be pretty straightforward to organize the way @xserrat suggests.

@chucknelson @aavetis , I'll try to open a pull request soon with an approach to support arm architectures generating docker images using github actions. With that approach, we'll be able to create new images tagged like docker.io/repo:version-gpu to make the setup easier. Thanks for your patience!
BTW, @chucknelson if you want to contribute by opening a new pull request with the suggested changes of this PR, feel free to share it. Then, we can open a discussion with @aavetis 💪🏽

BTW, @chucknelson if you want to contribute by opening a new pull request with the suggested changes of this PR, feel free to share it. Then, we can open a discussion with @aavetis 💪🏽

Sounds good - one thing I was curious about, what's the reasoning behind using a Makefile for the shortcut commands versus something like a normal shell script or maybe node scripts if thinking cross platform?

Thanks for your contribution @aavetis, @chucknelson continued the work you started and we finally merged his PR (https://github.com/xserrat/docker-facebook-demucs/pull/24) adding support for GPU as well as ARM64 and some extra options.
I hope I see you very soon! 💪🏽


Persist spaced repetition

A general solution for spaced repetition training on luks2 encrypted image files placed in $HOME/Persistent (for lack of a better idea now) has been written.
It took me way too long for such a simple feature but it seems like it will pay dividends with #81 where in order to use it a second substantially different passphrase must also be memorized. Without spaced repetition, I didn't feel confident users could quickly memorize two 5 word passphrases to open the Real vs Decoy wallet vaults.
All .img files keep separate intervals based on their success rate, all can be skipped with Esc or 'Cancel' except for Persistent Storage.img since we know they know it and advise them to delete it. Skipping counts as success for the interval adjustment. Starting with the Persistent Storage unlocked is counted as a success for the Persistent Storage interval adjustment.
Intervals are based on due dates, so users will probably be bombarded with training after unlocking their screen or starting Tails after not using it a while until their intervals have grow to be longer than time spent away. Since they on average double each success, this should not be too long.
For example if the interval reaches 30 minutes after Bails is setup, and they follow instructions to test their memory everyday, it will be
60m - Day 2
2h - Day 3
4h - Day 4
8h - Day 5
16h - Day 6
32h -Day 7
Day 8 - no prompt
64h - Day 9
Day 10-12 - no prompt
Day 13 - 128 hours
Day 14-20 - no prompt
Which actually matches our advice: "Everyday at first, then eventually once per week."
and after another success or two we could suggest that they destroy their written copy.
Closes #181

Current issues with this branch:

[ ] Can't skip non-Persistent Storage images.
[ ] Does not shuffle the spaced repetition calls yet.
[ ] Bitcoin Core does not launch if started from an already set up Persistent Storage.
[ ] Have not fully tested from blank installation or the persistence after a reboot.

This is still planned to be worked on after the bails-wallet and codex32 backend upgrades


Prevent workflows code from exploiting pod patch permission to change non-workflow pods

Summary

What change needs making?

Find a way to prevent malicious code from exploiting patch permission of the minimum RBAC privileges.
Details:
The minimum RBAC privileges of workflow includes patch pods permission, this seems to be a potential security issue.
patch permission allows to do actions like kubectl patch pod valid-pod -type='json' -p='[{"op": "replace", "path": "/spec/containers/0/image", "value":"new image"}]', meaning, it allows to change all the images in the namespace, in other words, bring the namespace down.
The problem is even grater since role is set on pod and not on container, so not only that argo's wait container is getting this role, but also user's main container` is getting it. This means any malicious code creeped into the pod can exploit this role.
I'm not sure how this can be done. I can say I tried the solution suggested here and it worked. But it's a big mess to make it work with kustomize, so I wish for a more elegant solution.
Use Cases
Always.

Message from the maintainers:
Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.

I'll bring this up with the team

@simster7 Any update?

I also have some concerns with my Workflow requiring Pod patch permissions. I am developing a system that allows external users to run arbitrary workflows within my system. I have each user segregated into their own Namespace, so it wouldn't be absolutely devastating if they achieved Pod patch access, but it is still something that could potentially wreak havoc on my system.
Currently, I am setting automountServiceAccountToken: false with the executor.serviceAccountName field set. Does this do a workaround similar to the solution @Asaf-m mentioned in his original post? Is there a way the main container can then extract that token from the Argo sidecar and gain unauthorized access?

I think we could address this simply another way. If the pod can patch the workflow, then we could directly update the status.
To avoid conflicts, and to work with node offloading. We would need a new field to store the data in.
Not sure how this scales with many patches. So we could introduce another CRD as discussed here:
https://docs.google.com/document/d/18hg6PTejp1knp5QTaCwP4j4gUTsRu4KDeKHs-4l9shs/edit
This is not a popular issue.

I think we could address this simply another way. If the pod can patch the workflow, then we could directly update the status.
To avoid conflicts, and to work with node offloading. We would need a new field to store the data in.
Not sure how this scales with many patches. So we could introduce another CRD as discussed here:
https://docs.google.com/document/d/18hg6PTejp1knp5QTaCwP4j4gUTsRu4KDeKHs-4l9shs/edit
This is not a popular issue.

@jessesuen
https://kubernetes.io/docs/tasks/debug-application-cluster/determine-reason-pod-failure/#customizing-the-termination-message

The termination message is intended to be brief final status, such as an assertion failure message. The kubelet truncates messages that are longer than 4096 bytes. The total message length across all containers will be limited to 12KiB. The default termination message path is /dev/termination-log. You cannot set the termination message path after a Pod is launched

Moreover, users can set the terminationMessagePolicy field of a Container for further customization. This field defaults to "File" which means the termination messages are retrieved only from the termination message file. By setting the terminationMessagePolicy to "FallbackToLogsOnError", you can tell Kubernetes to use the last chunk of container log output if the termination message file is empty and the container exited with an error. The log output is limited to 2048 bytes or 80 lines, whichever is smaller.

Ohhhh.... interesting!

In v3.1 you will be able run workflows without pod patch, so long as they do not have outputs.

In v3.1 you will be able run workflows without pod patch, so long as they do not have outputs.

@alexec I can see that v3.1.2 is already available but this issue is still Open and I can still see the Patch verb in the installation  file https://github.com/argoproj/argo-workflows/blob/master/manifests/install.yaml
Could please confirm that we are able to run workflows without pod patch?

With the introduction of TaskSet we now have a way to replace pod patch with taskset patch.

We should test some attacks to verify this is true. Much of the pod spec is immutable, is it really true that you can change the image or args?

Notes from PoC:

We can use a seperate CRD to report back results from the wait container to the controller.
This CRD must contain all results, otherwise we get race between pod informer and task result informer.
We can't use taskset, it is not big enough for outputs.

In v3.1 you will be able run workflows without pod patch, so long as they do not have outputs.

Does this refer to global workflow outputs or step outputs? We use step outputs to communicate things between steps, and I don't see how pod/patch is required for that. What's stopping the controller from just creating the workflow pod with the required volumes for passing outputs from main to wait in the first place, and then leaving it like that? Is this really something the sidecar must do?

Correct. Outputs are patched onto the pod using annotations. Not outputs, no need for annotations. You could pass outputs using a volume mounted to all pods in the workflow. This volume would need to be readable from the controller. Not sure if that’s possible.
@jessesuen I think we only need patch for result and logs, exit code is found by controller. We know that we need these in the controller. Maybe we should look at pods/log in more detail.

Reviewing pods/log option:
The current solution the executor capturing logs scales. Consider a 1000 node workflow, each pod captures its own logs. If this was moved to the controller, it would have to do much more work that it currently does. The controller is the wrong place to do heavy lifting as it creates a single point of failure.
On top of this, we don't know where to save the main.log (or any artifact) in the controller, because it does not have get secrets permission (which it needs).
We could write the outputs to the logs, rather than as an annotation, or to the container termination-log, but these all have different problems.
Who else could do this? The agent, but it's just moving the problem.


Make default behaviour blatantly clear in docs

So lazy readers like me see what they're doing wrong :\
It was hard to see, for instance, that Controlling Notebook Execution had any real content apart from its toctree. Putting some subheadings in makes that much more visually apparent. Similarly, the emphasis in usage on ipykernel being the prerequisite for notebook execution minimised the fact that one also needed to clear their notebook output.
Thanks for your patience, and for a neat tool!

Thanks!
Can you please check if it also works for LaTeX output?
At least one link doesn't, since you are linking to the .html file.
Note that the added subheadings also add another level in the sidebar (and in the LaTeX TOC), I'm not so sure if that's really better ...

So is there a better way to link to a sphinx ref? I tried linking to .rst
instead of .html to no success.
I'll look into the toc
On 27 Jul 2017 6:22 pm, "Matthias Geier"<EMAIL_ADDRESS>wrote:

Thanks!
Can you please check if it also works for LaTeX output?
At least one link doesn't, since you are linking to the .html file.
Note that the added subheadings also add another level in the sidebar (and
in the LaTeX TOC), I'm not so sure if that's really better ...
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/spatialaudio/nbsphinx/pull/118#issuecomment-318293810,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAEz6_pr7RGPZC8EPaDzK6JZ_PErUKRKks5sSEjdgaJpZM4Ojx-b
.

I guess it's currently not possible: http://nbsphinx.readthedocs.io/en/0.2.14/markdown-cells.html#Links-to-*.rst-Files-(and-Other-Sphinx-Source-Files)
You can only link to the whole .rst file, but not to a specific anchor.
I think I wouldn't link to "Quick Start" anyway.
IMHO, anything called "Quick Start" should contain only redundant information. Whatever is mentioned in "Quick Start" should also be mentioned in the "normal" usage instructions, therefore a link back to it is not necessary.
If you think there should be some text between "Usage" and "Installation" or between "Installation" and "nbsphinx", I think this could be helpful.
I also don't really like adding those details about clearing the notebooks to the "Quick Start" section.
This should be as minimalistic as possible.
Adding more information makes it less useful.
This is really only for quickly getting you started. And it did, right?
As soon as something doesn't work as expected, you should consult the "real" manual.

Shrug. It's your project. Since evaluating notebooks is something one might
come to expect of nbsphinx from its docs or publicity elsewhere, I think
it's an important note to have in the quick start. It's still pretty
minimalistic.
On 27 July 2017 at 20:29, Matthias Geier<EMAIL_ADDRESS>wrote:

I guess it's currently not possible: http://nbsphinx.readthedocs.
io/en/0.2.14/markdown-cells.html#Links-to-*.rst-Files-(
and-Other-Sphinx-Source-Files)
You can only link to the whole .rst file, but not to a specific anchor.
I think I wouldn't link to "Quick Start" anyway.
IMHO, anything called "Quick Start" should contain only redundant
information. Whatever is mentioned in "Quick Start" should also be
mentioned in the "normal" usage instructions, therefore a link back to it
is not necessary.
If you think there should be some text between "Usage" and "Installation"
or between "Installation" and "nbsphinx", I think this could be helpful.
I also don't really like adding those details about clearing the notebooks
to the "Quick Start" section.
This should be as minimalistic as possible.
Adding more information makes it less useful.
This is really only for quickly getting you started. And it did, right?
As soon as something doesn't work as expected, you should consult the
"real" manual.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/spatialaudio/nbsphinx/pull/118#issuecomment-318324064,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAEz6wrR56YBqxiqL1Sa5VaR8cAp9eXNks5sSGaXgaJpZM4Ojx-b
.

Since evaluating notebooks is something one might come to expect of nbsphinx from its docs or publicity elsewhere, I think it's an important note to have in the quick start.

It indeed is very important.
That's why I'm mentioning it in the very first paragraph of the whole page.
Even before the "quick start" section.

It's still pretty minimalistic.

I think this makes most sense if it is the minimum.
I think I will even remove the pip command, since people might use other means of installing it.
Having 4 points is already too much, three would be nice, but I think I cannot get rid of any of them.
If I add something about clearing outputs, I might as well mention that pandoc has to be installed, and a Jupyter kernel, and ..., and ...
And suddenly I've copied the whole "installation" section to "quick start".
Really, there are only two choices: either minimal or nothing at all.

@jnothman I've taken some of your suggestions to #137, feel free to add comments there.

sorry it got lost in the wash, and thanks for finishing it up


How to get the reviewer Id ?

For the user or a group, which API returns the reviewer Id.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 86ab7853-0733-6d8e-e624-1f0c6cb0d47d
Version Independent ID: 0ae02f69-7880-8430-0e51-fdfc7a5b1a03
Content: Pull Request Reviewers (Azure DevOps Git)
Content Source: docs-ref-autogen/5.0/git/Pull%20Request%20Reviewers.yml
Product: devops
Technology: devops-ref
GitHub Login: @wnjenkin
Microsoft Alias: whjenkin

Facing the same issue - how to get reviewer ids? Tried this API, however still getting 401 status code.


MINOR: some more Javadocs

ping @ymatsuda @ewencp for reviews.

I left a few comments. Otherwise, LGTM.

LGTM


FEAT: Give users a better explanation for why read_ functions are defaulting to pandas.

Is your feature request related to a problem? Please describe.
check_parameters_support in TextFileDispatcher, common to read_csv and other file format readers, can default to pandas for many reasons. Right now users just see UserWarning: Parameters provided defaulting to pandas implementation. This makes it hard for the user to tell what to change, as in #4565. We should give a more informative reason. We can implement that by having check_parameters_support return both a bool and a reason, as omnisci's _read_csv_check_support does.

@noloerino we have test cases checking that we are defaulting to pandas by catching the warning Modin issues, e.g.  checking for a case where read_csv defaults to pandas here. To test for this fix, we should use custom pytest.warns lines to check that we are issuing particular warnings. We can refine the existing warns_that_defaulting_to_pandas checks in the cases in test_io.py, and add new test cases there if we want more coverage.

I see, thanks for the pointers. It seems like test_io.py currently suppresses the defaulting to pandas warning (#3655), so I'll add in the more specific check as well.
Would it be reasonable to add an extra, mandatory error message argument to PandasParser.single_worker_read, and then propagate this change up wherever it's called?

@noloerino that sounds okay to me. I recommend making a PR that implements that, or another solution if that one turns out to not make sense. We can discuss the details on the PR.


Page.RUN not working OnPostReport in BC16

Hi everyone,
I just discovered what I think is a bug in Business Central 16 (Platform 16.0.12630.12758 + Application 16.1.12629.12805).
If I try to run a Page in the "OnPostReport" Trigger of a Report, the Page does not get displayed in BC16. However, if I run the same code in BC15 (Platform 15.0.38951.0 + Application 15.2.39040.0), it works just fine and opens the page.
To reproduce the error, use the below screenshot for a minimal example report.

Hi! Please take a minute to read the guidelines for this repository https://github.com/microsoft/AL and our collection of frequently asked questions https://github.com/Microsoft/AL/wiki/frequently-Asked-Questions .
As this repository is only for issues related to the AL compiler in latest developer preview environment for Dynamics 365 Business Central. We suggest that you open a support case or file a bug in Collaborate, to ensure that all Business Central users benefit from your catch as soon as possible.
To open a support case, you can:

Open a support request to CSS through the PartnerSource portal
Contact your Service Account Manager (SAM) in your local subsidiary to understand what is included in your contract as of support incident and PAH (Partner Advisory Hours). Your SAM might also direct you "step by step" how to open a support request or how to get credentials, if this is the first time for you or your company

If you file the bug in Collaborate, remember to include steps to reproduce the issue, and the Business Central build number and country version you're using.


Add Nong Song:

Song Name
Kyouki right version
Artist Name
idk
Source
Youtube
Youtube Link
https://youtu.be/vQrgg1Lw5y8?si=6R6Y-yKKFDSfWOYG
Direct File Link
No response
Song ID
905108
Start Offset [ms]
9
Extra
use in kyouki elpepe wazaaa

no level named  kyouki elpepe wazaaa so denied


Avoid npm peer dependency warnings when using with React v16

Addresses #20

@acusti When will this be available in a new release version? The latest release (0.3.0) still has this peer dependency error<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none was installed. Thanks.

@dganoff Seems like there’s a number of fixes that people are waiting to see published (like #6). I believe @leozdgao would be the person best suited for that task, though I’m guessing this module is no longer a priority for them. Here’s hoping 🤞

Hi @leozdgao, What's the plan for publishing a new version of this package? Thanks!


refactor: move resolved_toolchain to the main workspace

Similar to https://github.com/bazel-contrib/rules-template/pull/48

Oh, it was to use the toolchain in a genrule, right?

Yes, it's breaking, though I think we could introduce an alias in the old location if we care to. My guess is this is rarely used and the alias is just a bit of cruft.
Yes, exactly, the updated example here is the only way I know of that a user might reference it from code.
The target is also useful on the command-line to "just run the swc binary", so this breaking change would affect people's documentation as much as anything else.

I added the alias so this should be non-breaking AFAIK


Disable trigger

Motivation
We need to release changes for every check to keep what we have in wheel bucket in sync.

@ofek do we still need this?


Changing log messages from "CSharp" to "C#"

Changed from string.Format to string interpolation. Also fixed timer string format.

Looks good merging it.


Integration test validation failure

Proposal
Integration test fails validation after extensions -> appv1 update
Background

error: error validating "/home/runner/workspace/src/github.com/containous/maesh/integration/resources/whoami/whoami.yaml": error validating data: ValidationError(Deployment.spec): missing required field "selector" in io.k8s.api.apps.v1.DeploymentSpec; if you choose to ignore these errors, turn validation off with --validate=false

Closed by #301


chore: npm-check-updates && yarn upgrade

Ran npm-check-updates and yarn upgrade to keep the yarn.lock file up-to-date.

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-5lHf64IXfvmr
Commit ID: 151f4f6ae784ea1c8227b82ee42396e297c472b3
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-5lHf64IXfvmr
Commit ID: 8a118e382b544dc3df01441f83267015f1e3d760
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-5lHf64IXfvmr
Commit ID: a0597280e899cfcf54f1373129a36a89a27d42dd
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository


Allow jobs to be queuable once the existing job starts performing

This is useful when you know that the currently running job might not be
taking into account the most recent updates to some of the data it is
operating on, which can occur when the jobs take some time to run.
For example:

update model
queue job to index in ElasticSearch
job starts performing
another update happens to the model
try to queue job to update index

With the default queue locking mechanism, step 5 will only succeed in
enqueuing a new job if the job that started in step 3 has already
completed. However, if that job hasn't finished, but has loaded the
model with only the changes from step 1, then the changes introduced in
step 4 won't get indexed.
With unlock_while_performing set to true, there can always be a single
pending job in the queue, even when there's also a job running, and so
we can be confident that any un-indexed changes to the model will get
indexed once the final job finishes running.
@federicokeen @andydust what do you think about this as a replacement for the custom locking (e.g. in mubi/ma@82cca6ff4)?

Added one minor thought, otherwise LGTM. 👍  on superseding our various existing lock implementations with this gem.


 Please reinstall.

I get that error after install the extension.
MacOS High Sierra 10.13.5
VSCode 1.24.0

This is the result of the extension modifying the index file, it injects necessary CSS (safely I assure you) so the editor recognizes that it has been compromised. This will not effect the functionality of the editor outside of the scope of the extension.
I will add a notice to the README file explaining this.
For now, the best thing you can do is click the cog on that notification, and click "Don't show again".
I'm not sure if "Don't show again" is exactly what it says. Could you please let me know what it actually is?

In my case the html files modified automatically,every time I open the html files,there are a big amount of data add automatically.Is this for any extension I installed?

This is definitely not something that SmoothType wrote. I suggest taking a look at other extensions that may write to Code's index.html, such as icon packs for the explorer. In older versions, SmoothType wrote to this file, but now it just changes workbench.main.css.
If this extension has written to the file it will look like below.

@santunu23

Hi spikespaz, thank you  there are lots of extension installed on my visual code platform,have to find which one damage.

Hey why does this continue to happen when the extension is uninstalled? How do I make this go away?

All right so apparently to stop this you need to "Disable" smooth scroll with the extension installed and then uninstall the extension. @spikespaz if possible please add this also to the README

@aniforprez I agree that it should be in the README. This extension is deprecated anyway (because its primary feature was mercilessly cored) unless you wish to fine-tune the animation (which isn't available in the built-in settings).
If the issue was the appended [Unsupported] in the titlebar, you could have used my fork of an extension that fixes this issue. There's a VSIX file in the root of that repository.
But alas this extension is (mostly) pointless now. ¯_(ツ)_/¯

Thank you!

[FEATURE REQUEST]
Maybe adding a "Reinstall" button when that corruption message is displayed...

@angelhdz The corruption message shows that VS Code is corrupted because this extension changes core files of the editor. A reinstall button wouldn't help no matter what it re-installs, the extension isn't broken in the first place, and reinstalling VSC would undo changes made by SmoothType.
Please use the new editor.cursorSmoothCaretAnimation option in your user settings; the primary and only feature of this extension has been cored. The only thing that VSC cannot do is change the animation duration, this extension can.
If this is why you require the extension, my only further advice is to use the solutions already given for solving this problem (namely my fork of another extension).
If you do not require customization of the animation duration, uninstall the extension and use the setting built into VSC.
Please consult the readme for more information.


CodeWorld can end up with running program, but no hash in URL

This is probably due to some kind of race condition, possibly when following an existing hash from the URL.  In this case, the hash is first cleared, then reappears when the program starts.  Maybe these happen in the wrong order sometimes?
In any case, the symptom is that sharing doesn't work, because the main URL is just "http://code.world" even though there's a program running.

I haven't seen this in a while, but it's a race condition, so maybe it's still there.  Not sure how to proceed.

Closing until I see it again.

I believe this was caused by clicking the line number link on error messages.


Data Dictionary v1.1

Data Dictionary v1.1 release will include additional variables, data types, ranges, and metrics.

version v1.1 draft edits:
https://www.freecodecamp.org/news/how-to-write-a-good-readme-file/

add project title, project description, describe each tab and that files purpose, more clearly define column header definitions, add info about file size, how many column or rows, and version
for the 'data_range' column in the obs_list : use set standard lab intervals to create the data ranges: https://www.labcorp.com/resource/critical-values
for 'data_metric' column in obs_list: change to 'data_unit' or 'unit'; also pull from the document above
when you get to the data_types part, @steph-sing will fill them in for you, plus a new patterns column

Hi @steph-sing, can you help with the Data Dictionary & Mapping docs? Khushi added the data types, ranges, and units for a subset of variables, but we will need to add them for the rest of the properties. The readme and release notes should be updated as well, I didn't get a chance to implement the changes discussed in our last visit:

add project title, project description, describe each tab and that files purpose, more clearly define column header definitions, add info about file size, how many column or rows, and version

I am happy to hop on a call and clarify any of this as well! Please let me know if this is something you think you can complete by 08/31/2023. If not, I can dedicate some additional time to help out.
Thanks!

Next steps as discussed with Lori on 8/31:
@lorikrammer can you update the sharepoint to reflect the following files:
v1.0_data_dictionary_final (make sure release notes are up to date)
v1.1_data_dictionary_final (make sure release notes include the changeLog from v1.0-1.1)
@steph-sing  will copy v1.1 final, work on it offline, and release back to sharepoint like this:
v1.2_data_dictionary_draft
(we can approve and make minor edits in sharepoint, once approved draft will be replaced as final)
All finals should be Read Only

@steph-sing I've updated the folder based on our discussion today. Please take a look and let me know if you have any questions. the draft version 1.2 should be ready for your edits. Thanks!


Maintainance status?

Hey @GaretJax!
I see that this package hasn't been updated in a while. Is this still actively maintained? If not, would you be OK with transferring maintainership of this project to someone else (either an individual - I am happy to volunteer for that - or an org like jazzband or executablebooks)?

Yes we at https://github.com/executablebooks would most probably be happy to take it on

And obviously still set you as an one of the owners

Hi @pradyunsg, thanks for the offer. I think there have been talks between @evildmp and jazzband in the past about this, but I don't know what the status is there; that would be my preferred solution.
I didn't know about executablebooks @chrisjsewell, but it looks like you do a lot of sphinx indeed, so it may be even a better home.

oh yes a lot lol! and @pradyunsg has been helping us out on the web design side of things which is obviously where this package comes in very handy. We're just integrating into our development process (see https://github.com/executablebooks/sphinx-book-theme/pull/172) so would certainly like to keep it active.
But yeh naturally its entirely up to you, but just let us know if you do want to and I wouldn't foresee any objections 😄

Could we start maybe by adding @pradyunsg (and you @chrisjsewell, don't know how you're organized) to this repo and see how things go? If all goes well, I'm then happy to transfer it to another org.

yep no problem, sounds good to me 👍

Who shall I add?

@pradyunsg you opened the issue so should have first refusal 😊

Sounds great to me!
Please feel free to add me (and @chrisjsewell, if they say they're OK with it) here and we'll take it from there. :)

@pradyunsg you have access as a collaborator to the repo.

Oh awesome! Thank you! ^.^
My next instinctive question is, PyPI access. Would you be willing to give me publish access on PyPI as well? (same username there, https://pypi.org/user/pradyunsg/)

Well we could just move the testing/deployment to GitHub actions.
Then it just requires an API secret being set on the repository 😉
(like https://github.com/executablebooks/MyST-Parser/blob/master/.github/workflows/tests.yml)

We certainly can/should do that, but my concern stems more from a bus factor perspective for this project. :)

I'll give you access in due course @pradyunsg ;-)

Sounds fair to me! ^>^

Damn we will have to refactor our plans to install crypto miners in everybody's Sphinx builds 😅
but seriously - thanks @GaretJax for inviting collaboration on this repo!

LOL
I'm pretty sure we have access to better "targets" if we really wanted to spread crypto miners around. 😂

I knew it!

Ahoy @GaretJax! I think we're almost ready for a release.

Would you be willing to transfer the project to the executablebooks organization?
PyPI access would be nice to have, to actually make the release. 🙃

#93 and #94 await @GaretJax's OK (and PyPI access).

Oh and I also expect you to use myst-parser and sphinx-book-theme for the RTD docs 😉

I don't think this project needs RTD docs. :)

@pradyunsg you have been granted access to PyPI and I approved the two PRs.
I tried to transfer the project but I don't have the rights to create public repos on the executablebooks organisation. It also does not seem possible to grant you more privileges as what you already have here. I also tried to transfer the ownership to yourself (so that you can transfer it to the org), but you already have a fork of the repo.

@GaretJax I've just invited you as a member of executablebooks 😄

Transferred!

🎉 thanks, @pradyunsg we can start crypto mining 😂

@pradyunsg I just gave you maintainer status

@chrisjsewell Could you make me an admin -- I can't see webhooks and don't have the ability to manage protected branches.

@pradyunsg you have been granted access to PyPI and I approved the two PRs.

Awesome! Thank you @GaretJax! ^>^

Note to self: make a release on 1st. :)

sphinx-autobuild 2020.9.1 is out! We're golden. Now, let's see if people report breakages, or if anyone complains. :)

Thanks everyone here! Definitely wouldn't have happened without y'all. ^>^

Thank you @pradyunsg for resurrecting the project! :heart:


Print Right View of a Binary Tree

Given a Binary Tree, print Right view of it. Right view of a Binary Tree is set of nodes visible when tree is visited from Right side.
The right view of following tree is 1 3 7
1
/     \
2        3
/   \     /  \
4     5   6    7
I would like to work on this issue under gssoc in c++ language.
Algo-Tree/Code/C++/

Please assign this to me.


add support for .env files

closes#47
i have made these changes:
1- added django-environ as an optional dependency
you could either make it a required dependency
or make the methods more abstract so users can use whatever parsing tool they want.
2- add one optional parameter to use() and get_settings_instance() methods
if the user provides a path, it will be used
othersie it defaluts to None and methods go as they did before
if a file path is given but the file doesn't exist, fallback to os.environ. (useful for ci/cd when .env file isn't available)
also some safty check just in case, and some docstrings
3- added .idea to .gitignore for pycharm
let me know if you have any thoughts on this

This appears to be branched not from master?

i forked the master
but i used reset once cause i was going wrong
maybe that has made it look confusing
but as you can see in the commits it uses the last commit from the master branch

@funkybob hi
sorry for pinging
but should i proceed?

The diff still shows changes from a branch I've not merged yet.

that's... strange
it shows me that i forked the master branch
i'll look into it


Hover info and autocomplete unavailable in some cases

Update: See comments below about List, Array, and Set. Those are not issues now, only locals are.
Autocomplete and hover info are available for things in the Basics module, but not for things in List, Array, Set, etc. They also are unavailable for local declarations.
Here's some sample code:
module Test exposing (fiveOrLess)

import Html exposing (Attribute)
import Html.Events exposing (keyCode, on)
import Json.Decode

onKeyDown : (Int -> msg) -> Attribute msg
onKeyDown tagger =
    on "keydown" (Json.Decode.map tagger keyCode)

fiveOrLess : List Int -> List Int
fiveOrLess values =
    List.map (min 5) values

In onKeyDown, there is hover info for on, Json.Decode.map, and keyCode (all imported), but not for tagger (local).
In fiveOrLess, there is hover info for max (built-in), but not for List.map (built-in) or values (local).

I'm using elm 0.19.0 on macOS 10.14, VS Code 1.28.1

Are you sure about List.map? "It works on my machine".
You are right about locals though.

Interesting. I was sure when I posted it, but you're right, it's working for me now.
It's still not working for Array or Set, though. 🤔

So, it looks like it doesn't even believe Array and Set are in core... 😕

Array and Set are not default imports so you have to import them
explicitly. See the list here:
https://package.elm-lang.org/packages/elm/core/latest/
tis 11 dec. 2018 kl. 19:14 skrev Rob Yoder<EMAIL_ADDRESS>
So, it looks like it doesn't even believe Array and Set are in core... 😕
[image: screen shot 2018-12-11 at 11 13 45 am]
https://user-images.githubusercontent.com/622513/49820720-e745b780-fd35-11e8-9253-18a8d4c0b1e0.png
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/Krzysztof-Cieslak/vscode-elm/issues/277#issuecomment-446304574,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAmbpQf-Q2VMPQ7KdpQMhNg8BqdDLMeUks5u3_YHgaJpZM4XYrqx
.

--
Skickat från min telefon

Sorry, I edited my comment, but you hadn't seen it. :)

Note that the word List itself still does not autocomplete unless you include an (unnecessary) import List exposing (List) at the top. Since that is necessary for Array, it does autocomplete the word Array.

That's just because type List has no documentation, while type Array does.
See https://package.elm-lang.org/packages/elm/core/latest/List
vs
https://package.elm-lang.org/packages/elm/core/latest/Array

I think you misread. My last comment was referring to autocomplete, not hover info. The word List will autocomplete (show up as a suggestion if I type Li) if I explicitly import it, but if I don't explicitly import it (which I don't need to), it won't autocomplete, even though it's in scope as a default import.
Array works as expected and the same as List when it is imported.


⚠ Bofrost.at has degraded performance

In 51e4985, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1045 ms

Resolved: Bofrost.at performance has improved in caa4ad4 after 8 minutes.


[nrf fromtree] kernel/timeout: revert to signed dticks for timeout storage

The fix to handle long duration timeouts in 150e18de6e1806942 also
changed the duration value from signed to unsigned.  This can cause
delays in processing alarms when timer handlers run longer than a tick
(either due to delays or if there are many of them).  Revert to a
signed representation.

sdk-nrf PR: https://github.com/nrfconnect/sdk-nrf/pull/2913


Missing DLL

This is with the mini installer, the current "pre-release."

Install https://www.microsoft.com/en-us/download/confirmation.aspx?id=46881 (VC Runtime). This solves the problem.

@krisdante Getting 404!  - "We are sorry, the page you requested cannot be found!"

I solved this problem with this article: https://www.smartftp.com/support/kb/the-program-cant-start-because-api-ms-win-crt-runtime-l1-1-0dll-is-missing-f2702.html

Thanks @Stefku  :+1:

If someone feels adventurous, you can test this https://github.com/Stanzilla/cmder/releases/tag/v1.2.1
It should work without any DLLs as is.

@Stanzilla The DLL problem does not exist-by a installation of VC Runtime, or override with the v1.2.1 version,but I got another error-not caused by your forked v1.2.1,the original v1.2 has the same problem(The chinese character says "Join-Path : can not bind parameter to parameter(?) "Path", because the parameter has a null value") :


missing updateState for data?

https://github.com/oasisprotocol/oasis-wallet-ext/blob/f912f132cc22bec5d70541ddf46b90d7d28c6c6d/src/background/service/APIService.js#L556
updateSecPassword updates this data object from the store, but it doesn't call updateState with data. I understand that this isn't necessary because data is a reference to the actual object in the store anyway. but lots of other similar functions do use updateState. I think either one of these must be a mistake.
blocks #1

reexamining issues I opened. this issue remains
corrected description: the method is updateState, not updateData


hi

send .htaccess pls

@laricoins have you figure it out how to use .htaccess ? I am having difficulties too.


decl_module+structs macro weirdness with deriving serialize traits

This is how my decl_module block looks like:
 decl_module! {
        pub struct Module<T: Trait> for enum Call where origin: T::Origin {
               fn commitment_start(origin, bid: Bid<T::AccountId, T::Balance>) -> Result;
        }
}

Bid is defined as:
#[cfg_attr(feature = "std", derive(Serialize, Deserialize, Debug))]
#[derive(Encode, Decode, Clone, PartialEq, Eq)]
pub struct Bid<AccountId, Balance> {
    advertiser: AccountId,
    total_reward: Balance,
}

And Balance is:
pub type Balance = u128;

impl balances::Trait for Runtime {
    /// The type for recording an account's balance.
    type Balance = Balance;

The error I get compiling this is:
^ the trait `_IMPL_DESERIALIZE_FOR_Runtime::_serde::Deserialize<'_>` is not implemented for `<T as balances::Trait>::Balance`

The weird thing is that when it's changed to:
       fn commitment_start(origin: T::Origin, bid: Bid<T::AccountId, T::Balance>, bal: T::Balance) -> Result {

it compiles normally

Hey, could you give me access to the full source code? It clearly looks somehow weird.
In your last line, there is a new third parameter bal, is that by intention or is it just missing from your former declaration?

@bkchr that's my point, when I add the bal as a third argument it compiles; somehow, that makes the first error go away
this is the repo: https://github.com/AdExNetwork/adex-protocol-substrate, I invited you
i've also made a branch https://github.com/AdExNetwork/adex-protocol-substrate/tree/does_not_compile and you can check https://github.com/AdExNetwork/adex-protocol-substrate/compare/master...does_not_compile

I will look into it. Thanks for sharing your code!

 Essentially it was a problem with serde, because it did not added the correct trait bounds.
I updated all your Cargo.toml files to use the master branch. I would recommend that you also push your Cargo.lock to always work against a fixed version of substrate as the project is evolving fast and stuff tends to break.
The fix I pushed is just temporary, I will create a pull request for substrate and after that is merged, you can use Bid with T::Balance again.

Will be fixed by: https://github.com/paritytech/substrate/pull/1057

@bkchr after the last commit that you pushed, I get this:
error[E0603]: module `rand` is private
   --> /home/ivo/.cargo/git/checkouts/rust-libp2p-98135dbcf5b63918/9d91217/protocols/secio/src/lib.rs:258:55
    |
258 |         let (private, _) = secp.generate_keypair(&mut secp256k1::rand::thread_rng())
    |                                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^

error: aborting due to previous error

I tried cargo clean too
any ideas?

@Ivshti did you get the build error on your own project or on building substrate directly? I can not reproduce this error locally. If this error is happening in your project, that links to substrate, I would try a cargo update.
Nevertheless @tomaka do you have seen this build error with libp2p?

@bkchr yeah, it just required a cargo update; it's fine now
anyway, any ideas on how to do Vec<AccountId> ? I checked out https://github.com/serde-rs/serde/issues/723, there seems to be no elegant way to do it

No sorry, I don't have a better solution either at the moment.


Disabling the Better BibTex Initializing popup - possible?

Your question/suggestion:
When Zotero starts up, there's every time a small pop-up window about BibTex initializing and its progress. I find it unnecessarily distracting and would like to disable it. If not entirely (which would also be fine), at least to make it local within the Zotero window rather than a global pop-up that obstructs other windows.
I've searched the Zotero forums and the old issues here, looked at the Better BibTex preferences section too, but couldn't see anything related to this. Is this possible to do, and if not, could it be added as a configurable preference in the future?

I can see whether there's a more subtle way to show load progress, but I'm not removing it entirely. Zotero has a very long startup sequence during which plugins really shouldn't do anything, and I kept getting complaints about the long startup time when I was really only waiting for the all-clear from Zotero.

I understand, I guessed the reason for the pop-up must be something like that. It makes sense to have it on as a default, but providing an option to turn it off - even an "Advanced" preference i.e. an about:config value to set - would be very helpful.
Often, I open Zotero when I come across a useful article, I click the Zotero Connector, and it informs me that Zotero isn't open. At this point, when Zotero is opening, I'm into research mode already, and would really prefer not to be distracted by what looks like an OS notification at a glance. My use case is such that the loading time of plugins is of little concern to me, and an unobtrusive experience is of much more importance. Perhaps this isn't the average use case, but a little option in some corner, available to be tweaked for this use case, would be much appreciated.

I'm looking at a progress bar at the top near the sync button instead, but it's misbehaving.

I actually like BBT's startup prompt. The Zotero desktop client isn't fast at startup, so when I launch Zotero I just Alt+Tab away to other programs. The BBT prompt remains in the foreground and when it disappears I know Zotero is ready.
@digital-carver: I would recommend starting Zotero before you're in research mode and then keeping it open.
@retorquere: I'm not sure new UI options are a good idea. The current feature is working well and other options might introduce new issues, especially given that Zotero's UI keeps evolving. A hidden option in about:config for users who don't like the prompt seems like a good solution to me. Those users would see whether Zotero is ready by watching the citekeys appearing. That should be enough.

To be clear, it is not the loading time of plugins that is the issue. It's zotero that is taking long to load, and I'm just informing of that to set the expectations right. BBT loads much faster than zotero does, once it's allowed to.

A build will drop here shortly, with that installed, you can go into the hidden settings and change startupProgress into progressbar. If that looks OK to you, I can merge to main.

Nice. This is quite unobtrusive and visually has a polished look as well. Thanks for the quick work on this.


TmuxPaneCurrentCommand returns "sh"

I'm using VIM 7.4, Ubuntu 14.04 and Tmux 2.0.
Not working because of this (tmux doesnt recognize that vim is running).

Hi @infokiller, can you provide any additional detail? Specifically,

What does which vim return?
How are you opening vim? (assuming you just run vim, but want to confirm).

I've not see this particular problem, but hoping the above might clarify

Hi @christoomey and thanks a lot for your response.
I just tested it on another computer with very similar configuration (my dotfiles and some of the packages are synced) and the command worked well. I'll check it again on my laptop when I get home and report back.

OK I think I understand what's happening now- this only happens when I'm opening vim with fasd (same as the other issue). I'll merge this one into the other one.


feat(template): update to husky v5

This would be worth not merging before Husky v5 leaves early access and returns to MIT license.

@danielroe Agree with your license comment, I'll hold the pr.


MMM-WatchDog Restart Loop

When MMM-WatchDog is included and the position prop for modules are not set, WatchDog triggers a shutdown and PM2 restarts MM which then causes a restart loop.
This seems to be due to the restart the Page-Selector triggers when it finds modules that don't have positions.

Hi!
Has this issuen been solved? Or is a workaround available?
I'm running into the same issue, that MM constantly restarts a few times and then stops completely. I also have a few modules which have no position prop (e.g. MMM-PIR-Sensor, alert, MMM-Button, MMM-Podcast2, just to name a few).
It stops because Pageselector obviously deletes the config.js. in the config folder then I find instead a file called config.page-selector.temp.js.

I have not found a fix for this issue and I fear there is no easy fix since the modules are well and truly at odds in the way they function. Increasing the timeout might help by making the interval between pings short enough that the restart is not detected as a crash.
The more feasible workaround is to simply define a default position for all modules. That way the mirror never restarts itself in the first place.

Thanks for replying!
I'll try the workaround you described.

Thanks for replying!
I'll try the workaround you described.

Did that work for you? I just installed this module and am running into the same issue with Watchdog crashing after 10 minutes.

Did that work for you?

Unfortunately not. I am currently using a different page switcher module.

Sorry I never got back to you. I've mostly stopped development on this module and just check back in every once in a while to help. Since this issue is so old, I'm just going to close it.
If you still use the module and have a problem you can open a new issue. I have a few days where I can work some stuff out.


Stdlib: Fill descriptions for stdlib Builtin interfaces

Currently the doc generation tool reports that 682 descriptions are missing, which is about 86%.
We need to fill in the descriptions preferably in a priority order.

We need clear descriptions for interface, because interfaces don't have implementations and they are nothing without documentation.

I am leaving related links for this task.
HTML result page: https://shader-slang.com/stdlib-reference/interfaces/index.html
Undocumented items: https://github.com/shader-slang/stdlib-reference/blob/main/summary.txt

@bmillsNV , am I allowed to use Coverall for stdlib documentation?
I gave a try and it worked very well, but I like to double check if I am allowed.

@jkwak-work yes you can use coveralls here.


Questions on training details and enhancement process

Hi,
Thanks for your great work. I have several questions and hope you can clarify it.
For the Storm model in paper, what is the batch size (I saw 8 by default in the codes)? How many epochs did it train (I also saw the earlystopping setting in codes, but I wonder whether it was trained until the max of 1000 epochs, or stopped by earlystopping after 50 patience)?
Besides, I saw "For training, sequences of 256 STFT frames (≈2s) are randomly extracted from the full-length utterances". In this case, when it comes to enhancement, does it segment the whole input into several frames (2s), enhance each frame, and finally concatenate them as the output? Or enhance the whole utterance at the same time?
Also, I just generated the data based on your codes and use the WSJ0+Chime3 checkpoint to denoise the data. However,  the pretrained checkpoint has lower results than article results. I wonder whether the default parameters in the codes are exactly the same as what was used to obtain the results in the paper for both data generation (create_data.py) as well as model training.
Sorry for so many questions. Thanks for your clarifications in advance.

Good question! I also want to know it.
I am a second-year graduate student. I was also researching speech enhancement based on diffusion models.
Can we have a talk?
你好

Hi @TianyuCao thank you for your interest!
The training was interrupted using the early stopping criterion in the code, we did the experiments as in the current version of the code. I recall early stopping was most of the time raised after 200-300 epochs. Batch size was 8 * 4 GPUs =  effective batch size of 32.
For inference, the sequences are not segmented, but entirely fed to the machine. Since the NCSN++ is CNN and Transformer-based, it can perform on arbitrary lengths (with of course, a limited effective receptive field). This means the longer your sequences, the more memory burden on your GPU. But it should not affect performance itself.
W.r.t your reported results: could you share the figures you obtained, as well as the parameters used for inference please? (and also which results you compare to in the paper, i.e. which line in which table).
Thank you

Good question! I also want to know it. I am a second-year graduate student. I was also researching speech enhancement based on diffusion models. Can we have a talk? 你好

I am unable to have a general research discussion at the moment, but invite you to ask any question related to this repository please (i.e. code issues, unexpected behaviour) by raising an issue


SVG support

It would be cool

If I were doing it today, I probably would, but I don't have the original artwork in svg format.
If you'd like to trace it, I'd love to add svgs.

Oh, I thought you generated them on the fly.

They're generated on the fly by combining several layers of images - A random face base, a random smile, a random set of eyes, etc. Take a look at https://github.com/e1ven/Robohash/tree/master/robohash/sets/set1


Added some spaces (std.file documentation)

Few code formatting of the documentation's example, for more readable

Squash the commits, then LGTM

I don't know how I can squash it, bacause I did all changes using browser, I have no local copy of repository/fork, etc.

clone your repo onto a machine, checkout the branch with the patch, squash, push changes to inet

Done. And I hope I done it right.

Yes - you can just click on the commits tab here on github to see the list of commits in your pull request ;-)

auto-tester shows errors. How it can be fixed? Need I worry about it (and to do something for fix)?

Due to a heisenbug, std.allocator fails its tests sometimes. The failure has nothing to do with this PR.

LGTM

Ok, thank you.

Auto-merge toggled on


Canon MX922 printing too light

Deep cleaning didn't seem to help.
Almost all ink level was low

Replacing ink cartridges:

BK, PGBK didn't help.
Then Magenta helped.

Btw I'm printing PDFs with pretty format. PDFs generated from MS Office that didn't include pretty format printed fine.


react-i18next libdef update

No longer require using a Translator type with the translate HOC.
Updated tests to use describe/it
Rather than doing
import { translate, type Translator, type TFunction } from 'react-i18next'
type Props = { s: string }
type PropsWithT = Props & { t: TFunction }
const Comp = ({ s, t }: PropsWithT) => { .... }
const translator: Translator<Props, PropsWithT> = translate()
const TranslatedComp = translator(Comp)

You now do
import { translate, type TFunction } from 'react-i18next'
type Props = { s: string,  t: TFunction }
const Comp = ({ s, t }: Props) => { .... }
const translator = translate()
const TranslatedComp = translator(Comp)

And TranslatedComp will still have the same type information (it knows that t is supplied to Comp through translate, but s still need to be passed).
Took the same approach as the react-router-dom libdef uses to type the withRouter HOC.

Hi, this {| ...TranslatorProps, ...P |} seems to trigger a problem if a component has some non-optional props that are covered by defaultProp, it will says "Property someProp is missing in object type [1] but exists in Props [2]."

@gre Can you open an issue linking to this PR?

Appears to be a limitation with typing HOC's in general. https://github.com/facebook/flow/issues/4644. Flow has no way of knowing what default props you have declared.


Print styles

What is the context of this PR?
Fixes #1102
How to review

Select file >> print in the browser menu
Check all buttons are hidden
Check in different browsers

Ink saving font: http://ecofont.nl/en/products/green/printing/sustainable-printing-using-ecofont-software.html

The summary screen doesn't have a table:

I removed the tables as they was causing text to be cut off. This also made the page sorter; saving paper and ink  🌳  ✌

I agree with @collisdigital that we should restore the tables to preserve the layout.
I would suggest something like the screenshot below where each question has a bottom border but all others are removed and we use padding below each response to give visual structure.
If possible I would like to introduce a reminder for print that would state that these are unsubmitted answers and remind the respondent that there is a remaining action before completion. Using a warning or error panel style to give it a strong presence. I'm also considering reducing the .summary__question colour to #666 - saving ink @bennpearson but also making the answers more prominent.
Whether this is using CSS to insert content or if the content is in the html will require discussion with @hamishtaplin and @bennpearson.
For example:
@media print {     h1.saturn:after {         content:"Please remember to submit these responses.";         font-size:1.3rem;         display:block;         border-left:7px solid #d0121E;         background:#fbecec;         padding:1rem;         margin: 1rem 0 1rem -0.5rem;     }     .summary__items {         border-bottom: 1px solid #999 !important;         border-radius: 0;         padding:0 0 0.5rem 0.5rem;     }     .summary__question {         padding: 0.5rem 0 0 0 !important;     } }

+1 for Ben's design above, @bennpearson can it be done?

Yes this new style looks good. Not sure about putting content into the css though. How about putting it in the schema? That would help with language support too.

Put the content in the template HTML but hide with css?

Yes

Can the inputs be indented as per the visual below and the distance between inputs reduced?

Can we now add a warning panel as per the screenshot below and amend the copy to the following?

Please check your responses carefully before submitting.

Based on our semantic change card, shouldn't that warning be the H1 now?

Good point - I'll review this morning and update.

On mobile when navigation is shown the viewport is grey'd out, this applies on the print out too, please fix!

@bennpearson all done? If so I'll review again with @armstrongb now

Yes please

@hamishtaplin do you approve this one?


User Settings: Text of green alerts sometimes covers the "x"

Steps

Log in to osf.io.
Go to your User Settings.
Add some alternate email addresses (some shorter than others) and confirm them if necessary.
Switch your primary and alternate email addresses.
Notice the green alerts which pop up.

Expected Behavior
I expect that regardless of the length of my email addresses, the text of the alerts will not run into the "x" on the right side of the alert.
Actual Behavior
When email addresses are shorter, the alerts are smaller and text overflows onto the "x" in the alert. I am still able to click the "x" to exit the alert--I just cannot see it very well.
Screenshot

@nanchen47 Can I get this issue?

@lbanner I propose closing this issue in favor of #3700 ; which shows that there might be a bigger sitewide issue here. It might also very well be a regression bug, I'm happy to help with it.

Closing in favor of https://github.com/CenterForOpenScience/osf.io/issues/3700


python3Packages.spacy: 2.0.16 -> 2.0.18

Motivation for this change
Update spaCy to 2.0.18. Also, it seems that we cannot build spaCy on Python 2 anymore, since one of its transitive dependencies (ftfy) does not work with Python 2 anymore.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[x] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

I have moved some of the dependencies to checkInputs since they are only used for unit tests (which are disabled). I also removed two unused dependencies from the spacy derivation.


Uncaught Error: Error from Instagram: The access_token provided is invalid.

Hi there,
I'm new to this, so I might be doing something wrong.
I followed the instructions at: http://instafeedjs.com, but cannot get anything to show up when I load my test html page in a browser.
I think I successfully created a client on the Instagram site and entered the clientId in the html file, but I keep getting this error:
Uncaught Error: Error from Instagram: The access_token provided is invalid.
Appreciate any suggestions.
Thanks,
dr-f

I have this issue too.

You are seeing that error because of new API restrictions that Instagram introduced last November.
Please see #345 for more information.

@stevenschobert somehow, I'm finding this very difficult to understand. #345 mentions that they are able to pull their own feed without the access_token issue.
Should I be able to pull my own feed with a new Instagram ClientId & the same UserId that generated that ClientId?

I've got three sites that were working but now get 'Uncaught Error: Error from Instagram: The access_token provided is invalid.' I haven't changed anything and my instagram clients are the same.

I actually had this working, too, and it just recently stopped working.

any update about this error? I was trying to test instafeed.js but I get the same error

Any update on this?

Any update about this error?

Hey @NickEngmann, what is the lifetime of the token ?, Can I use it forever ?

I don't believe that the generated token has an explicit lifetime, only that Instagram don't guarantee that it will be valid 'forever' - seems to be more of a disclaimer to avoid liability than anything else.  If you're only pulling your own Instagram feed then there seems little else to do.  Your 'app' will be in Sandbox mode and you can pull the last 20 of your own posts.  If you need to use instafeed for a client, you'll need to add them as a sandbox user and have them accept the Sandbox invitation, then log into Instagram and use pixelunion to generate a token for their own userID.

Thanks @NickEngmann worked for me.

with @NickEngmann strategy it worked for me. Just remember to use the full accessToken generated in the accessToken js field

Thank you nick, but can we get tagname not ourself's feed/

Great,  @NickEngmann it worked for me too..
thanks.

I had trouble with this myself.
I followed these instructions and got it to work.

The access token is the token from Step 8. remember to add your client as a sandbox user so you can access their feed.

@jackiboy that url is down. please provide alternative

@jackiboy Thanx for sharing, it was really helpful!

@NickEngmann thanks it worked for me 👍


crypto: only partial validation of Hash argument in RegisterHash

What version of Go are you using (go version)?

$ go version
go version go1.19.1 darwin/amd64
# but please note that it's not relevant, since I'm providing references and links to go1.20.4 below.

Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GOARCH="amd64"
GOOS="darwin"
# other values are irrelevant in this case

What did you do?

Browsing src/crypto/crypto.go, I've noticed that RegisterHash doesn't not validate the Hash argument in the same fashion as the rest of the package.
What did you expect to see?
I expected RegisterHash to validate that the Hash argument is bigger than 0, as the smallest Hash value defined in the package is uint 1 (MD4, which is defined with 1 + iota).
I though that it might be there for a legit use ...
What did you see instead?
Digging in a bit more, and trying to find an explanation or a legit use, I failed, leading me to believe that it's not intentional.
I might be wrong, since I'm not super experienced with the package, but I expect to see a comment addressing the exceptional check if it was by design.

CC @golang/security


Added binary search in c++

What a great code :smile: !
Just a little tip, its good to always put a description on your PRs to make more understandable.
Thank you for contributing! :rocket:

Thank you,
Sure i will put description afterwards. 👍


Very large logback.db size

Hi! We use the plugin for our cordova app. We saw that we got 1 GB of user data of our app and found that it's all because of logback.db. Is there anyway to turnoff logging? or does anyone have an idea what I might have done wrong for the APK?
Thank you!
Your Environment

Plugin version: 2.3.6
Platform: Android
OS version: 9
Device manufacturer and model: Zebra TC57 but I think regardless of device model

Running in Simulator: No
Cordova version (cordova -v): 9.0.0
Cordova platform version (cordova platform ls): 8.1.0
Plugin configuration options:
BackgroundGeolocation.configure({     desiredAccuracy: 10,     stationaryRadius: 5,     distanceFilter: 1,     maxLocations: 1000,     // Android only section     locationProvider: BackgroundGeolocation.DISTANCE_FILTER_PROVIDER,     interval: POLLING_INTERVAL,     stopOnStillActivity: false,     fastestInterval: FASTEST_INTERVAL,     activitiesInterval: FASTEST_INTERVAL,     notificationTitle: 'Background tracking',     notificationText: 'enabled',     notificationIconColor: '#FEDD1E',     notificationIconLarge: 'mappointer_large',     notificationIconSmall: 'mappointer_small'   });

More information: I dig down the database files and it looks like logging_event_property table is not clean up property.
logging_event table contains 7 days of events starting with event_id = 3152088
but logging_event_property still contains event_id = 1

The same for me.... did you manage this meanwhile?
Is this plugin maintained?

For anyone else, constantly increasing storage could be fixed by changing this line in LoggerManager.java:
root.setLevel(Level.TRACE); -> root.setLevel(Level.OFF);
Open in android studio and find java file: /android/capacitor-cordova-android-plugins/src/main/java/com/marianhello/logging/LoggerManager.java
I hope, this will help somebody :)


Home Assistant template error

Hi @Anrolosia !
This error has been showing in my HA logs:
Logger: homeassistant.helpers.template
Source: helpers/template.py:625
First occurred: 6 April 2023 at 16:32:03 (58 occurrences)
Last logged: 11:31:35
Template variable error: 'value_json' is undefined when rendering '{{ value_json.qty_in_shopping_list }}'
Any ideas?

Hey @rachaelbond
This happens when a product is deleted through mqtt, after doing the update to 0.5.0, we all had a bunch of those errors.
It shouldn't happen in a regular usage.
Thanks