bi-directional virtuals population issue

Versions

NodeJS: 10.22.0
Typegoose(NPM): 7.3.4
Typegoose(GIT): commithash
mongoose: 5.7.36
mongodb: 4.0.20 Community

Code Example
Thank you for your work - Typegoose makes life with Mongo and Typescript a breeze :)
I have a strange issue (probably, because I'm trying to do a strange thing).
In my use case, Users can follow each other, and these relations contain additional properties - so I moved them to the separate model Followship.
Followship has followerId and followeeId (both IDs of Users) to define the relation. What I want is an ability to pull the Followships separately and populate Users in them, and also an ability to pull Users with their Followships populated.
So here is how my models look:
User:
@modelOptions({
  schemaOptions: {
    toJSON: { virtuals: true },
    toObject: { virtuals: true }
  }
})
export class User {

  @prop({ required: true })
  public name!: string;

  @prop({unique: true})
  public email!: string;

  @prop()
  public password!: string;

  //
  @prop({
    ref: Followship,
    type: Followship,
    localField: '_id',
    foreignField: 'followeeId',
    justOne: false
  })
  public followers?: Ref<Followship>[];

  @prop({
    ref: Followship,
    type: Followship,
    localField: '_id',
    foreignField: 'followerId',
    justOne: false
  })
  public followees?: Ref<Followship>[];

  public static getById(this: ReturnModelType<typeof User>,
                        id: string
  ): Promise<DocumentType<User> | null> {
    return this.findById(id)
      .select('name email address')
      .populate('followees')
      .populate('followers')
      .exec();
  }
}

Followship:
@modelOptions({
  schemaOptions: {
    toJSON: { virtuals: true },
    toObject: { virtuals: true }
  }
})
export class Followship {
  @prop({ required: true })
  followerId!: ObjectID;

  @prop({ required: true })
  followeeId!: ObjectID;

  @prop({
    ref: User,
    localField: "followerId",
    foreignField: "_id",
    justOne: true
  })
  public follower?: Ref<User>;

  @prop({
    ref: User,
    localField: "followeeId",
    foreignField: "_id",
    justOne: true
  })
  public followee?: Ref<User>;

  @prop()
  seeFirst!: boolean;

  public static getFollowersOfUser(this: ReturnModelType<typeof Followship>,
                                   userId: string
  ): Promise<DocumentType<Followship>[]> {
    return this.find({ followeeId: userId })
      .populate({ path: "follower" })
      .exec();
  }
}

The issue is the following:
When I call User.getById(), I get the User object correctly populated with followers and followees (is there a better term for it in English btw?). But when I call Followship.getFollowersOfUser(), I get the array of Followships - with follower: null.
Debug mode shows, that Followship.getFollowersOfUser() tries to find the User ids in the Followship collection, and obviously fails:
Mongoose: followships.find({ followeeId: ObjectId("5f5836e2de810118a26bddba") }, { projection: {} })
Mongoose: followships.find({ _id: { '$in': [ ObjectId("5f56808196a0b238cf32fcff") ] } }, { skip: undefined, limit: undefined, perDocumentLimit: undefined, projection: {} })

The thing is, that if I remove the virtual fields from User model, Followship.getFollowersOfUser() returns just fine:
Mongoose: followships.find({ followeeId: ObjectId("5f5836e2de810118a26bddba") }, { projection: {} })
Mongoose: users.find({ _id: { '$in': [ ObjectId("5f56808196a0b238cf32fcff") ] } }, { skip: undefined, limit: undefined, perDocumentLimit: undefined, projection: {} })

Am I doing something wrong? Is there any workaround for this? Except using only the User's virtuals
I've seen the #295, but I'm not sure I understand the examples there.
Do you know why it happens?
no

opened an issue on the new repo
https://github.com/typegoose/typegoose/issues/370


Smart Select pushstate?

Hi, Android users are trying to click back on an opened smart select control but that causes app to close (for example), it would be awesome to have smart select change the pushstate like you did for dynamic page (add /#content-1 to the URL, and close the smart select on back, that'd be more easy and needed solution.
Thanks.

Yeah would be great but it isn't possible to do that without changing Framework7.
@nolimits4web needs to help us.

@tinyCoder32 it works as expected when pushState is enabled and Smart Select used as a Page. Otherwise, use onbackbutton cordova callback to close it when you need it

@nolimits4web not if I opened it using JavaScript.
And I don't use Cordova, I open the Smart Select using JavaScript when users click on an icon, pushstate is enabled but not changing.

@nolimits4web
How to initiate smart select as page

@J05HI by adding data-open-in="page" which is the default mode, but that doesn't change pushState when opened from JavaScript, even you can't change it to popup from JavaScript, it always open as page, it will be very useful to have that option in JS too.

Yeah


Proposal: Rename Repo!

Basecoin is not a good name for a framework as this is becoming.
Basecoin is a wonderful name for the executable we use in all the examples.  cmd/basecoin is perfect.
As we work on making this even more extensible as a framework and the basecoin logic just another configuration, we should have a new name for the repo.  Everything under cmd/... should keep the same name and distribution and all.
Also, it would be good to merge all the user-facing (cli) stuff from light-client into this repo, while we move the crypto-verification logic into tendermint itself.
This issue is to discuss new name for a repo that people will import into (hopefully) most of the abci apps built in golang.

Proposal: github.com/tendermint/dapps
It is a tool to build out distributed applications. We want you to build your dapp with this repo. Let's use an established word, I don't think there are other repos with this name.

I think the best one I've come up with is tendermint/haxolotl - hacks meets axolotl. The coolest shapeshifting amphibian.  DApps is an ethereum thing = decentralized application, which is a good starting place. Are there any other cool ways to put a spin on it? Maybe something with scattered in it - that's a cool word that is distributed. tendermint/scatter

I think dapps would be confusing and would mean that we compete with ethereum in google rankings, which at least initially will make it hard for people to google us and find the correct content.
I think scatter is good, since it is easy to pronounce and remember how to type.
I also like spargo.
Also, instead of renaming can we create a new repo with the new name and link it. Otherwise a lot of our search results will be broken as well as our internal links.

I like dapps precisely for the searchability. People know the term and a search for "tendermint dapps" will hit the repo or docs.
I also like haxlotl. A unique term and it does sound cool. Not sure how many people will mis spell it.
Scatter is such a generic term that we won't appear anywhere in search results

Dapps is bigger than ethereum, it is a concept now. Example for searching.
https://www.google.de/search?q=Eos+dapp&oq=Eos+dapp&aqs=chrome..69i57j69i60l3j69i65j69i60.1842j0j4&client=ms-android-sonymobile&sourceid=chrome-mobile&ie=UTF-8
https://www.google.de/search?client=ms-android-sonymobile&ei=PkhGWezrFMfawQKToqHIDA&q=Tezos+dapp&oq=Tezos+dapp&gs_l=mobile-gws-serp.3..33i160k1l2.62525.64611.0.653<IP_ADDRESS>.<IP_ADDRESS>3.2864.0j1j2j5-2j1.6.0....0...1.1j4.64.mobile-gws-serp..6.6.2223.3..0j41j0i10k1.3WxRWYlo2qs

I have always liked the word "Magrathea" from Hitchhikers Guide. It was the planet that built custom planets.  Talk about your large scale framework.

Quarks.

@JBSch this says it all - Quarks are one of the buiding blocks of atoms = great idea. Um really anything from this chart... is there a better one than quarks? https://en.wikipedia.org/wiki/Subatomic_particle#/media/File:Standard_Model_of_Elementary_Particles.svg

Thanks!!
As per the link above, and since there are six different types of quarks, they could be used as sub types or fractions (Like the Wei or the mBTC), Quarks>Tops>Ups>Downs>Bottoms?

Leptons can travel faster than the speed of light (that's pretty cool!) maybe we could name it leptons because are transactions will travel faster than the speed of light (and EMC2 coin) https://github.com/tendermint/basecoin/issues/119#issuecomment-310485488

I like that too. The same idea for subtokens could be applied w/ Lepton building blocks: Electrons>Muons>Taus. 💃  @rigelrozanski

I think quarks - Jae gave the party emoji haha

Hi Guys, great concept, just one possible problem http://www.quark.com/en/ . (They are content automation software and they are also a Gartner Cool Vendor like Tendermint)
It is very difficult to find a name with significance that someone has not already used.

No worries, shouldn't be an issue, especially for smaller elements of larger open source projects. See previous use of other common names like:
Atom (Cisco) - http://www.cisco.com/c/en/us/td/docs/ios/12_0s/feature/guide/fsatom30.html
Atom (Disambig) - https://en.wikipedia.org/wiki/Atom_(disambiguation)
Cosmos (Disambig) - https://en.wikipedia.org/wiki/Cosmos_(disambiguation)

Sounds good!
On Sun, Jun 25, 2017 at 12:41 PM, JBSch<EMAIL_ADDRESS>wrote:

No worries, shouldn't be an issue, especially for smaller elements of
larger open source projects. See previous use of other common names like:
Atom (Cisco) - http://www.cisco.com/c/en/us/td/docs/ios/12_0s/feature/
guide/fsatom30.html
Atom (Disambig) - https://en.wikipedia.org/wiki/Atom_(disambiguation)
Cosmos (Disambig) - https://en.wikipedia.org/wiki/Cosmos_(disambiguation)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/tendermint/basecoin/issues/119#issuecomment-310913420,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AcKTNHelJ2P7_uz5ztrsWvtCsxrJr6Amks5sHo25gaJpZM4N9Uxl
.

--
Hugh Rooney
Strategy Tendermint/COSMOS
Mobile:<PHONE_NUMBER>
<EMAIL_ADDRESS>

So, quarks then?
github.com/tendermint/quarks
If there are no objections, I can close this issue and make a new issue - "Rename Repo to quarks"

I think we can put a good spin on it!
Sent from my iPhone

On Jun 26, 2017, at 2:11 PM, Ethan Frey<EMAIL_ADDRESS>wrote:
So, quarks then?
github.com/tendermint/quarks
If there are no objections, I can close this issue and make a new issue - "Rename Repo to quarks"
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

@ebuchman you didn't like the name?  can you add some more ideas here... otherwise i have to go with the popularity contest....

Basecoin + Tendermint = BaseMint hehehe
(thank you tectract from slack)

I think Quarks doesn't lend itself as a framework name. It sounds more like a product.
What about Lignia or Lignum?

How about RUFF-Blockchains . (Reusable Universal Framework For -
Blockchains) .🤔 . or "Ruffby" for short
On Wed, Jun 28, 2017 at 8:43 AM, Adrian Brink<EMAIL_ADDRESS>wrote:

I think Quarks doesn't lend itself as a framework name. It sounds more
like a product.
What about Lignia or Lignum?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/tendermint/basecoin/issues/119#issuecomment-311648372,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AcKTNEm6WEY5O2y7BnmdU4nSINgm9_p7ks5sIkppgaJpZM4N9Uxl
.

--
Hugh Rooney
Strategy Tendermint/COSMOS
Mobile:<PHONE_NUMBER>
<EMAIL_ADDRESS>

Oh, and Ideally the name of the repo is not too long (like <=6 chars... I find crypto.X or log.X much easier to write than basecoin.X, especially when all the arguments have a type defined there... already have some long function calls.
Most proposed names fit this criteria, just saying...

still think quarks is the best name - not going to get better than the building blocks of atoms

...hmm still thinking it almost seems like basecoin is quickly eating all the cosmos functionality - maybe moving from 0.7 we just rename the repo to cosmos????

Agreed up. Closing this discussion issue for the action issue: #159

Guiana (https://en.wikipedia.org/wiki/Pachira_aquatica Chestnut) ~ money tree
coin roots


Adjust administrative_role privileges to TypeSet

Since privliges should be an unordered list, shouldn't it be a TypeSet instead of a TypeList?
https://github.com/appgate/terraform-provider-appgate-sdp/blob/23c06769b48cd75c3904aaffcb40216fdbdc1656/appgate/resource_appgate_administrative_role.go#L62

Hey!
i don't think its possible to change privileges to schema.TypeSet, since privileges  contain computed values, so we cant compute a correct set hash for it.
I've not found a way for it atleast, if there are, PRs are welcome. For now i think this is a limitation within the terraform-plugin-sdk as Ive seen similiar issues in their repository. we have the same problem in #98


ncmpc: 0.44 -> 0.45

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/ncmpc/versions.
meta.description for ncmpc is: "Curses-based interface for MPD (music player daemon)"
meta.homepage for ncmpc is: "https://www.musicpd.org/clients/ncmpc/"
meta.changelog for ncmpc is: ""
Updates performed

Version update

To inspect upstream changes

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 0.45 with grep in /nix/store/s0n5j11ijkmpr56s2lfnhd1m2qh366lf-ncmpc-0.45

directory tree listing: https://gist.github.com/52125dbb25d8444c83a2a0d3d237cafd

du listing: https://gist.github.com/bcc4c5815cb1e567ea2d60de1c812147

Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
1 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
ncmpc

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/s0n5j11ijkmpr56s2lfnhd1m2qh366lf-ncmpc-0.45 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A ncmpc https://github.com/r-ryantm/nixpkgs/archive/af4e9241e9385477439cefd3e9d4fa7f14a61251.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/s0n5j11ijkmpr56s2lfnhd1m2qh366lf-ncmpc-0.45
ls -la /nix/store/s0n5j11ijkmpr56s2lfnhd1m2qh366lf-ncmpc-0.45/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

ncmpc

Maintainer pings
cc @fpletz for testing.

Result of nixpkgs-review pr 113179 run on x86_64-linux 1

1 package built:

ncmpc


Update package.json. Fix #14

Fix #14

looks like the ui.router module breaks with this update. can you find out the new module name and test with it?

The problem was the file path in node_modules. I've pushed the fix.


[FLINK-13415][docs] Document how to use hive connector in scala shell

What is the purpose of the change
The purpose of this PR is to add docs about how to use hive connector in scala shell via table api.
Brief change log
Document update in scala_shell.md
Verifying this change
This change is a document change, no need test update.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? ( no)
If yes, how is the feature documented? (not applicable )

Hi @zjffdu, I have some concerns about this addition that I have commented on the jira.

Hi @zjffdu any update on this PR? cc @xuefuz @lirui-apache @zjuwangg

@bowenli86 I have updated the PR (move it under hive category), could you help review it ? Thanks

LGTM. BTW, please add the corresponding Chinese doc in the same commit in the future, in this case scala_shell_hive.zh.md. I added it for you this time. Thanks!

Thanks @bowenli86


Add social-friendly URL for Front End role

Description

Adds social tile (and URL redirect to Greenhouse) for the front end role so that we hopefully get more engagements and share-ability on socials.

Checklist

[x] I have read the contribution guidelines
[x] I have considered the performance impact of these changes

running live on the preview here: https://deploy-preview-939--flowforge-website.netlify.app/jobs/frontend-dashboard


For lineChart with coordinate data, labelInterval value is not applied normally.

Version
3.4.0
Development Environment
mac chrome
Current Behavior
For lineChart with coordinate data, labelInterval value is not applied normally.

Combo charts also need verification


Developing collective action campaigns for the neuroimaging community

Project info

Title:

Developing collective action campaigns for the human neuroimaging community
Project lead:

Cooper Smout / @coopersmout
Timezone:

UTC+10
Description:

Academia is trapped in a collective action problem: we all know there are better ways we could be doing things, but feel pressured to 'play the game' in order to survive a competitive career in science. Historically, collective action problems like this have been solved with collective action, i.e. the mass uptake of new behaviours that aim to further the group's interests. More recently, online conditional pledge platforms (e.g., Kickstarter) have demonstrated that collective action can be organised on a global scale with zero risk to users, serving to cut out middle-men and directly benefit the users themselves. At present, however, this strategy has yet to take hold in academia.
Project Free Our Knowledge (FOK) aims to rectify this by organising collective action in the research community. Using our platform, researchers can pledge to support open science practices, subject to there being a critical mass of support for the proposed behaviour. If the threshold is achieved, everyone who has pledged is contacted and directed to carry out the action together, thus motivating cultural change with minimal risk to individuals.
Link to project:
Website
Github
Twitter
Facebook
Mattermost handle:
@cooper_smout
Goals for the OHBM Brainhack

Open up a group discussion to determine everyone's interests
Figure out some focus-groups that are interested in similar objectives
Move into breakout rooms and develop the campaign ideas
Propose new campaigns by clicking 'New Issue' in Github and filling in the template
Return to the group and pitch our proposals
Comment on each others' proposals using the comments thread in Github
If we're happy with any particular proposals, we can also post them to the FOK website to start collecting signatures immediately.

Good first issues:

Read the project README to understand the project background, structure, and ways you can support/follow us
Read through the campaign proposals that have already been proposed and comment/react to any campaigns that you're interested in
If you have an idea for a campaign that hasn't yet been proposed, start thinking about what action you would like people to adopt and how many people you think should do it together. Then we can discuss this when we meet in the hackathon.

Skills:
No skills required, just a healthy desire for change (but would help if people can sign up to Github beforehand)
Chat channel:

hbmhack-fok

-->

Image for the OHBM brainhack website
Project submission
Submission checklist
Once the issue is submitted, please check items in this list as you add under 'Additional project info'
Please include the following above (all required):

[x] Link to your project: could be a code repository, a shared document, etc. See here
[x] Include your Mattermost handle (i.e. your username). If you do not have an account, please sign up here.
[x] Goals for the OHBM Brainhack: describe what you want to achieve during this brainhack. See here.
[x] Flesh out at least 2 "good first issues": those are tasks that do not require any prior knowledge about your project, could be defined as issues in a GitHub repository, or in a shared document, cf here.
[x] Skills: list skills that would be particularly suitable for your project. We ask you to include at least one non-coding skill, cf. here.
[x] Chat channel: A link to a chat channel that will be used during the OHBM Brainhack. This can be an existing channel or a new one. We recommend using the Brainhack space on mattermost, cf. here.
[ ] Provide an image of your project for the OHBM brainhack website

You can also include information about (all optional):

[ ] Someone co-leading the project in the timeslot you have not selected to provide additional visibility.
[ ] Number of participants, cf. here
[ ] Twitter-size summary of your project pitch, cf. here
[ ] Set up a kanban board on your repository to better divide the work and keep track of things, cf here
[ ] Project snippet for the OHBM Brainhack website, cf. here

We would like to think about how you will credit and onboard new members to your project. We recommend reading references from this section. If you'd like to share your thoughts with future project participants, you can include information about (recommended):

[ ] Specify how will you acknowledge contributions (e.g. listing members on a contributing page).
[ ] Provide links to onboarding documents if you have some.

QMENTA has agreed to sponsor the event and provide computational resources through their platform.

[ ] Get in touch with QMENTA through their Brain Innovation Hub Slack space, if you think your project would benefit from their support.

hi @ohbm/project-monitors: My project is ready!
I just couldn't figure out how to link the image, please let me know where to upload this

@matteomancini has already took care of it.


Governance document

Governance document is part of the deliverables that should be produced by the COOS activity.

Decided during 22 Feb. call: assign to Zoltán.

Based on governance documents we analysed, here is our proposal for the content of the governance document:
1.	Introduction:
•	a generic overview and definition of core ontology
•	context of the particular work of the COOS team (?)
•	a few sentences on the aim of this document
2.	Scope and statistical potential:
•	what is its main purpose of ontology, how ontology comes into the “big picture”
•	what does COOS cover (and what not)
•	what is the real potential in ontology for a statistical organisation (why we should consider using it and start investing in the area of ontology)
3.	Basic principles of core ontology governance:
•	leaders of the governance will be listed with their description, definition, which rules the governance activity in this area
4.	Process of core ontology governance:
•	process and process steps for this activity will be determined and the definitions, descriptions as well
•	decision points will be highlighted
5.	Stakeholders, roles, responsibilities:
•	the stakeholders of COOS will be introduced and their tasks and responsibilities
•	this chapter is in close connection with the previous one, which is about the process.
6.	Annex:
•	list of concepts and explanations

QUESTIONS FOR DISCUSSION:

Do we understand governance well? Who are the addressees of the governance document? National Statistial Offices, in our opinion but maybe this is not the opinion of the whole group. Maybe also others?

Communicating the importance, value of ontology in a very easy way is expected I believe. The Executive Board also mentioned this aspect at its last meeting. In my opinion, this communication thing is not part of the governance document (at least not "traditionally" as we have not found any example that contained such material). There are 2 chapters with communcation potential though (1 & 2). So is this something additional to what we have planned for the group? Or should that be part of the governance anyway? Should we open a separate issue for this? Address this later?

I still don't understand what we mean by governance in the COOS context.
Is it going to be different from GSIM, GSBPM and other ModernStats models? Are we talking about change management or something else? Extension mechanisms?

Based on the discussions at our last COOS meeting, we propose to divide the governance document into 3 main parts. Content for each part is added as a discussion forum. Please use the link indicated for each part to access the content. Discussion for each part is ongoing on its dedicated page.

Foundations of COOS: https://github.com/linked-statistics/COOS/discussions/36
Key COOS principles: https://github.com/linked-statistics/COOS/discussions/37
Process, stakeholders, roles, responsibilities of COOS: https://github.com/linked-statistics/COOS/discussions/38

The content of the governance policy has partially been taken over by the Supporting Standards Group. What part do we keep at COOS level?

As we agreed at our last meeting, please find a very first draft version of the ontology in Google Docs here:
Please provide comments to the draft on the Google Docs version: https://docs.google.com/document/d/1nKaAIUdlWqXz-P5AYWHhxYMIugqD8SkWhQU7crtAkME/edit?usp=sharing

Governance document translated to Markdown/HTML.
Proof-reading needed, and figure 1 is missing.

The Google Docs version of the governance document is now final (version "draft 1.0 for internal review"). All comments, changes are included and final. @FranckCo can you help wi the HTML creation again? Sorry for the double work with this...

Zoltan to feed last modifications back in GitHub document.

Here is the new Governance document in Markdown/HTML format. This is fully in-line now with the draft v0.3 version of the documents (as of 28th September 2021).


Add ability to configure ArtifactService gRPC Channel

The purpose of this PR is to support configurable gRPC channels for ArtifactService. We have use cases where we run the ExpansionService in different environments. One example environment is in Google Cloud Run. This requires authenticated gRPC calls with the google cloud token in the gRPC header and transport security enabled vs plaint text. With the current public methods, we can do this for the expand stub with no problem, but not for the artifact stub which would need the same channel configuration.  We ended up monkey patching this to get our use case to work. I am contributing the monkey patch back to beam.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

Also, please attach a Github issue.

@chamikaramj sounds good ill add one later today

@chamikaramj sorry for the late update, went on vacation. Here is the issue ill include it in the PR description as well. I will update this branch with testing now as well.

BTW, how would you use this ?
I don't see a good way to override the DefaultExpansionServiceClientFactory in our API currently.
If there's a way to override this you could setup an integration test that provides required dependencies through a custom ArtifactService.

@chamikaramj you would have to use the External.of constructor with a new implementation ExpansionServiceClientFactory (the one that is visible for testing but it is public)
I can try that, do you have an example?

@chamikaramj thank you, I will update and try that soon!

waiting on author

no time for this sorry, if anyone else is interested they can pick it up 👍


Typo in help for search_datalake

The Example section refers to "# search using regex
search_data_lake(stringr::regex("^a"))"
I think search_data_lake() was the old name for this function and should be revised to search_datalake()?

Done :)


Cleanup readiness and liveness probe configuration

According to K8s documentation https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-startup-probes/#configure-probes, the initialDelaySeconds will be ignored if value of periodSeconds is greater. Removing the ignored fields in Antrea probe configurations to avoid confusion.

Raised issue to Kubernetes.io to fix the documentation https://github.com/kubernetes/website/issues/48519. Closing this PR.