[WIP] Test Istio 1.0.0 integration

Test Bookinfo with Istio + mTLS + L7 policy.
Fix the semantics of WithTimeout's Timeout.
The Go docs specify that a time.Duration "represents the elapsed time between two instants as an int64 nanosecond count." However, TimeoutConfig's Ticker and Timeout fields violated that semantics as they were defined as time.Duration while storing values in seconds.
Fix the timeout handling in WaitForServiceEndpoints, which converted timeouts into billions of seconds.
To prevent such bugs from occurring again, specify clearly that Ticker and Timeout contain seconds, and change their type to int64.
Signed-off-by: Romain Lenglet<EMAIL_ADDRESS>

This change is

test-me-please

test-me-please

test-me-please

Istio 1.0.0 can't be installed on k8s 1.7:
https://jenkins.cilium.io/job/Cilium-PR-Ginkgo-Tests-Validated/5639/execution/node/92/log/?consoleFull
04:27:04     unable to create Istio resources
04:27:04     Expected command: kubectl apply -f  /home/vagrant/go/src/github.com/cilium/cilium/test/k8sT/manifests/istio-cilium.yaml
04:27:04     To succeed, but it failed:
04:27:04     Exitcode: 1
04:27:04     Stdout:
...
04:27:04     Stderr:
04:27:04      	 Error from server (BadRequest): error when creating "/home/vagrant/go/src/github.com/cilium/cilium/test/k8sT/manifests/istio-cilium.yaml": HorizontalPodAutoscaler in version "v2beta1" cannot be handled as a HorizontalPodAutoscaler: no kind "HorizontalPodAutoscaler" is registered for version "autoscaling/v2beta1"
04:27:04     	 Error from server (BadRequest): error when creating "/home/vagrant/go/src/github.com/cilium/cilium/test/k8sT/manifests/istio-cilium.yaml": HorizontalPodAutoscaler in version "v2beta1" cannot be handled as a HorizontalPodAutoscaler: no kind "HorizontalPodAutoscaler" is registered for version "autoscaling/v2beta1"
04:27:04     	 Error from server (BadRequest): error when creating "/home/vagrant/go/src/github.com/cilium/cilium/test/k8sT/manifests/istio-cilium.yaml": HorizontalPodAutoscaler in version "v2beta1" cannot be handled as a HorizontalPodAutoscaler: no kind "HorizontalPodAutoscaler" is registered for version "autoscaling/v2beta1"
04:27:04     	 Error from server (BadRequest): error when creating "/home/vagrant/go/src/github.com/cilium/cilium/test/k8sT/manifests/istio-cilium.yaml": HorizontalPodAutoscaler in version "v2beta1" cannot be handled as a HorizontalPodAutoscaler: no kind "HorizontalPodAutoscaler" is registered for version "autoscaling/v2beta1"
04:27:04     	 Error from server (BadRequest): error when creating "/home/vagrant/go/src/github.com/cilium/cilium/test/k8sT/manifests/istio-cilium.yaml": HorizontalPodAutoscaler in version "v2beta1" cannot be handled as a HorizontalPodAutoscaler: no kind "HorizontalPodAutoscaler" is registered for version "autoscaling/v2beta1"
04:27:04     	 unable to recognize "/home/vagrant/go/src/github.com/cilium/cilium/test/k8sT/manifests/istio-cilium.yaml": no matches for admissionregistration.k8s.io/, Kind=MutatingWebhookConfiguration

test-me-please

test-me-please

test-me-please

The test passes fine locally:
STEP: Creating policies
STEP: Creating policy in file "/home/vagrant/go/src/github.com/cilium/cilium/test/k8sT/manifests/istio-sidecar-init-policy.yaml"
STEP: Creating policy in file "/home/vagrant/go/src/github.com/cilium/cilium/test/k8sT/manifests/cnp-specs.yaml"
STEP: Creating the Bookinfo resources
STEP: Creating resources in file "/home/vagrant/go/src/github.com/cilium/cilium/test/k8sT/manifests/bookinfo-v1-istio.yaml"
STEP: Creating resources in file "/home/vagrant/go/src/github.com/cilium/cilium/test/k8sT/manifests/bookinfo-v2-istio.yaml"
STEP: Waiting for pods to be ready
STEP: Waiting for services to be ready
STEP: Validating DNS resolution
STEP: Validating L7 filtering
STEP: Checking that "reviews-v1-64b6fc464-hsrfp" can connect to "ratings.default.svc.cluster.local:9080/health"
STEP: Checking that "reviews-v1-64b6fc464-hsrfp" cannot connect to "ratings.default.svc.cluster.local:9080/ratings/0"
STEP: Checking that "productpage-v1-856d6f7df4-gxndf" can connect to "details.default.svc.cluster.local:9080/health"
STEP: Checking that "productpage-v1-856d6f7df4-gxndf" cannot connect to "ratings.default.svc.cluster.local:9080/health"
STEP: Checking that "productpage-v1-856d6f7df4-gxndf" cannot connect to "ratings.default.svc.cluster.local:9080/ratings/0"

test-me-please

test-me-please

test-me-please

Weird CI build issue in the post-build scripts, with no logs:
https://jenkins.cilium.io/job/Cilium-PR-Ginkgo-Tests-Validated/5663/
The Istio test itself passed:
https://jenkins.cilium.io/job/Cilium-PR-Ginkgo-Tests-Validated/5663/execution/node/93/log/

test-me-please

Failed CI build because if Istio test:
https://jenkins.cilium.io/job/Cilium-PR-Ginkgo-Tests-Validated/5664/execution/node/93/log/?consoleFull
05:29:28 STEP: Checking that "productpage-v1-856d6f7df4-dbssf" can connect to "details.default.svc.cluster.local:9080/health"
05:29:29 Unable to connect from "productpage-v1-856d6f7df4-dbssf" to "details.default.svc.cluster.local:9080/health":
05:29:29 --2018-08-15 05:29:28--  http://details.default.svc.cluster.local:9080/health
05:29:29 Resolving details.default.svc.cluster.local (details.default.svc.cluster.local)... <IP_ADDRESS>
05:29:29 Connecting to details.default.svc.cluster.local (details.default.svc.cluster.local)|<IP_ADDRESS>|:9080... connected.
05:29:29 HTTP request sent, awaiting response... 503 Service Unavailable
05:29:29 2018-08-15 05:29:29 ERROR 503: Service Unavailable.

When this test fails, it's always because of the lack of connectivity between productpage-v1 and details. The occasional temporary connectivity issues between other pairs of pods resolve quickly.
The details pod is not in a good shape:
05:29:36 cmd: kubectl get pods -o wide --all-namespaces
05:29:36 NAMESPACE      NAME                                        READY     STATUS      RESTARTS   AGE       IP              NODE
05:29:36 default        details-v1-75bb9d6f48-h8ff2                 2/2       Running     1          6m        <IP_ADDRESS>      k8s2

Note that Istio Galley is restarting too, which could cause sidecar configuration issues:
05:29:36 cmd: kubectl get pods -o wide --all-namespaces
05:29:36 NAMESPACE      NAME                                        READY     STATUS      RESTARTS   AGE       IP              NODE
...
05:29:36 istio-system   istio-galley-5669f7c9b-jt8fm                1/1       Running     2          8m        <IP_ADDRESS>     k8s2

Only 2 deployments have a CNP (both L7) applied: ratings and details.
ratings is healthy, but details is not (even after the 5-minute timeout):
05:29:37 cmd: kubectl exec -n kube-system cilium-lnw8v -- cilium endpoint list
05:29:37 ENDPOINT   POLICY (ingress)   POLICY (egress)   IDENTITY   LABELS (source:key[=value])                                                      IPv6                 IPv4          STATUS
05:29:37            ENFORCEMENT        ENFORCEMENT
...
05:29:37 61521      Enabled            Disabled          23331      k8s:app=ratings                                                                  f00d::a0a:0:0:f051   <IP_ADDRESS>   ready
05:29:37                                                            k8s:io.cilium.k8s.policy.istiosidecarproxy=true
05:29:37                                                            k8s:io.cilium.k8s.policy.serviceaccount=default
05:29:37                                                            k8s:io.kubernetes.pod.namespace=default
05:29:37                                                            k8s:version=v1
05:29:37                                                            k8s:zgroup=bookinfo

05:29:36 cmd: kubectl exec -n kube-system cilium-8dkt8 -- cilium endpoint list
05:29:36 ENDPOINT   POLICY (ingress)   POLICY (egress)   IDENTITY   LABELS (source:key[=value])                                                   IPv6                   IPv4          STATUS
05:29:36            ENFORCEMENT        ENFORCEMENT
...
05:29:36 38420      Enabled            Disabled          43978      k8s:app=details                                                               f00d::a0a:100:0:9614   <IP_ADDRESS>    not-ready
05:29:36                                                            k8s:io.cilium.k8s.policy.istiosidecarproxy=true
05:29:36                                                            k8s:io.cilium.k8s.policy.serviceaccount=default
05:29:36                                                            k8s:io.kubernetes.pod.namespace=default
05:29:36                                                            k8s:track=stable
05:29:36                                                            k8s:version=v1
05:29:36                                                            k8s:zgroup=bookinfo

test-me-please

On the other hand, when you feel confident, we need to test in other versions of kubernetes like 1.8/1.9/1.10 ;-)

On the other hand, when you feel confident, we need to test in other versions of kubernetes like 1.8/1.9/1.10 ;-)

That shouldn’t matter re the Istio integration.

test-missed-k8s

test-me-please

test-me-please

test-me-please

@rlenglet What is holding this up?

test-me-please

I tried running the CI test with a Pilot image that includes https://github.com/istio/istio/pull/8088, but that didn't work. There are still endpoints that don't get ready (it seems like ratings this time):
https://jenkins.cilium.io/job/Cilium-PR-Ginkgo-Tests-Validated/5824/execution/node/93/log/

test-me-please

test-me-please

test-me-please

CI build failed:
https://jenkins.cilium.io/job/Cilium-PR-Ginkgo-Tests-Validated/5880/execution/node/93/log/?consoleFull
This time, both details and ratings are not-ready. Pods are restarted:
kubectl get pods -o wide --all-namespaces" exitCode: 0 duration: 443.737051ms stdout:
NAMESPACE      NAME                                        READY     STATUS      RESTARTS   AGE       IP              NODE
default        details-v1-75659bb6fb-8gmjs                 2/2       Running     2          9m        <IP_ADDRESS>     k8s2
default        productpage-v1-5f8b56f47d-zlgrk             2/2       Running     1          9m        <IP_ADDRESS>     k8s2
default        ratings-v1-dc77fbd64-q2lxq                  2/2       Running     2          9m        <IP_ADDRESS>      k8s2
default        reviews-v1-85f556cbc4-5wcm4                 2/2       Running     0          9m        <IP_ADDRESS>      k8s1
default        reviews-v2-555b6f8d98-tccq9                 2/2       Running     0          9m        <IP_ADDRESS>      k8s2

test-me-please

test-me-please

Build failed due to environment issues:
https://jenkins.cilium.io/job/Cilium-PR-Ginkgo-Tests-Validated/5910/flowGraphTable/
00:10:56.974     k8s1-1.11: E: Unable to fetch some archives, maybe run apt-get update or try with --fix-missing?
00:10:56.974 The SSH command responded with a non-zero exit status. Vagrant
00:10:56.974 assumes that this means the command failed. The output for this command
00:10:56.974 should be in the log above. Please read the output to determine what
00:10:56.974 went wrong.
00:10:56.974
00:10:56.974         ===================== ERROR - VM PROVISION FAILED =====================
00:10:56.974
00:10:56.974         Unable to provision and start VM "k8s1-1.11": exit status 1", vm, err
00:10:56.974
00:10:56.974         =======================================================================

test-me-please

test-me-please

Weird failure due to environment again, this time in runtime tests:
https://jenkins.cilium.io/job/Cilium-PR-Ginkgo-Tests-Validated/5918/flowGraphTable/
The k8s tests were successful, including the Istio test from this PR.

test-me-please

CI build failed with a new kind of failure:
https://jenkins.cilium.io/job/Cilium-PR-Ginkgo-Tests-Validated/5919/execution/node/93/log
00:51:27.390 cmd: kubectl get pods -o wide --all-namespaces
00:51:27.390 NAMESPACE      NAME                                        READY     STATUS      RESTARTS   AGE       IP              NODE
00:51:27.390 default        details-v1-75659bb6fb-7st2x                 1/2       Error       1          8m        <IP_ADDRESS>     k8s2
00:51:27.390 default        productpage-v1-5f8b56f47d-kflzr             2/2       Running     1          8m        <IP_ADDRESS>     k8s2

The details pod is in error.
It's known to Cilium, but not-ready:
00:51:27.390 cmd: kubectl exec -n kube-system cilium-kzhd6 -- cilium endpoint list
00:51:27.391 ENDPOINT   POLICY (ingress)   POLICY (egress)   IDENTITY   LABELS (source:key[=value])                                                    IPv6                   IPv4          STATUS
00:51:27.391            ENFORCEMENT        ENFORCEMENT
...
00:51:27.391 60064      Enabled            Disabled          21812      k8s:app=details                                                                f00d::a0a:100:0:eaa0   <IP_ADDRESS>   not-ready
00:51:27.391                                                            k8s:io.cilium.k8s.policy.istiosidecarproxy=true
00:51:27.391                                                            k8s:io.cilium.k8s.policy.serviceaccount=default
00:51:27.391                                                            k8s:io.kubernetes.pod.namespace=default
00:51:27.391                                                            k8s:track=stable
00:51:27.391                                                            k8s:version=v1
00:51:27.391                                                            k8s:zgroup=bookinfo

@rlenglet can you please post the WithTimeout fix as a separate PR? I believe it would be beneficial to get it in ASAP to help with CI-runs which have lots of failures and result in timeouts.

@ianvernon I split that into https://github.com/cilium/cilium/pull/5369.

@rlenglet thanks !!

test-me-please

test-me-please

test-me-please

test-me-please

test-me-please

Test failed in CI because Istio's istio-telemetry service isn't ready within 5 minutes:
https://jenkins.cilium.io/job/Cilium-PR-Ginkgo-Tests-Validated/6971/execution/node/94/log/?consoleFull
01:13:27.585 • Failure in Spec Setup (BeforeEach) [399.289 seconds]
01:13:27.585 K8sIstioTest
01:13:27.585 /home/jenkins/workspace/Cilium-PR-Ginkgo-Tests-Validated/src/github.com/cilium/cilium/test/ginkgo-ext/scopes.go:351
01:13:27.585   Istio Bookinfo Demo [BeforeEach]
01:13:27.586   /home/jenkins/workspace/Cilium-PR-Ginkgo-Tests-Validated/src/github.com/cilium/cilium/test/ginkgo-ext/scopes.go:351
01:13:27.586     Tests bookinfo inter-service connectivity
01:13:27.586     /home/jenkins/workspace/Cilium-PR-Ginkgo-Tests-Validated/src/github.com/cilium/cilium/test/ginkgo-ext/scopes.go:383
01:13:27.586
01:13:27.586     Service "istio-telemetry" is not ready after timeout
01:13:27.586     Expected
01:13:27.586         <*errors.errorString | 0xc420e06160>: {
01:13:27.586             s: "Timeout reached: could not get service endpoints",
01:13:27.586         }
01:13:27.586     to be nil
01:13:27.586
01:13:27.586     /home/jenkins/workspace/Cilium-PR-Ginkgo-Tests-Validated/src/github.com/cilium/cilium/test/k8sT/istio.go:107

I'll retry with limiting the test to checking the status of only 2 Istio services: istio-statsd-prom-bridge and istio-pilot.

test-me-please

test-me-please

The test passed in the CI:
https://jenkins.cilium.io/job/Cilium-PR-Ginkgo-Tests-Validated/6986/execution/node/88/log/

test-me-please

test-me-please

The test failed in CI:
https://jenkins.cilium.io/job/Cilium-PR-Ginkgo-Tests-Validated/6988/execution/node/94/log/?consoleFull
This time, the Istio pods didn't even come up. That's an issue with Istio, not the test.
01:33:09.829 K8sIstioTest
01:33:09.829 /home/jenkins/workspace/Cilium-PR-Ginkgo-Tests-Validated@2/src/github.com/cilium/cilium/test/ginkgo-ext/scopes.go:351
01:33:09.830   Istio Bookinfo Demo [BeforeEach]
01:33:09.830   /home/jenkins/workspace/Cilium-PR-Ginkgo-Tests-Validated@2/src/github.com/cilium/cilium/test/ginkgo-ext/scopes.go:351
01:33:09.830     Tests bookinfo inter-service connectivity
01:33:09.830     /home/jenkins/workspace/Cilium-PR-Ginkgo-Tests-Validated@2/src/github.com/cilium/cilium/test/ginkgo-ext/scopes.go:383
01:33:09.830
01:33:09.830     Istio pods are not ready after timeout in namespace "istio-system"
01:33:09.830     Expected
01:33:09.830         <*errors.errorString | 0xc420c02fd0>: {
01:33:09.830             s: "Timeout reached: timed out waiting for pods with filter -l istio to be ready",
01:33:09.830         }
01:33:09.831     to be nil
01:33:09.831
01:33:09.831     /home/jenkins/workspace/Cilium-PR-Ginkgo-Tests-Validated@2/src/github.com/cilium/cilium/test/k8sT/istio.go:100

test-me-please

Unrelated failure in runtime tests:
https://jenkins.cilium.io/job/Cilium-PR-Ginkgo-Tests-Validated/6990/execution/node/92/log/?consoleFull
01:00:16.866 RuntimeMonitorTest With Sample Containers
01:00:16.866   multiple monitors
01:00:16.867   /home/jenkins/workspace/Cilium-PR-Ginkgo-Tests-Validated/src/github.com/cilium/cilium/test/ginkgo-ext/scopes.go:383
01:00:16.867 STEP: Setting PolicyEnforcement=default
01:00:22.687 === Test Finished at 2018-10-05T05:31:37Z====

Retrying.

test-me-please

Successful CI build: https://jenkins.cilium.io/job/Cilium-PR-Ginkgo-Tests-Validated/6991/

This PR is ready for review and merging.

test-missed-k8s

test-me-please

@eloycoto I addressed your comments. Thanks!

test-me-please

Unrelated CI failure in the k8s 1.8 test:
https://jenkins.cilium.io/job/Cilium-PR-Ginkgo-Tests-Validated/7070/
01:05:01.233 K8sPolicyTest
01:05:01.234 /home/jenkins/workspace/Cilium-PR-Ginkgo-Tests-Validated/src/github.com/cilium/cilium/test/ginkgo-ext/scopes.go:351
01:05:01.234   Basic Test
01:05:01.234   /home/jenkins/workspace/Cilium-PR-Ginkgo-Tests-Validated/src/github.com/cilium/cilium/test/ginkgo-ext/scopes.go:351
01:05:01.234     Validate to-entities policies
01:05:01.234     /home/jenkins/workspace/Cilium-PR-Ginkgo-Tests-Validated/src/github.com/cilium/cilium/test/ginkgo-ext/scopes.go:351
01:05:01.235       Validate toEntities All [It]
01:05:01.235       /home/jenkins/workspace/Cilium-PR-Ginkgo-Tests-Validated/src/github.com/cilium/cilium/test/ginkgo-ext/scopes.go:383
01:05:01.235
01:05:01.235       HTTP egress connectivity to google.com from pod "app3-bf49c776d-2q5dp"
01:05:01.235       Expected command: kubectl exec -n default app3-bf49c776d-2q5dp -- curl -s -D /dev/stderr --fail --connect-timeout 3 --max-time 8 http://www.google.com/ -w "time-> DNS: '%{time_namelookup}(%{remote_ip})', Connect: '%{time_connect}',Transfer '%{time_starttransfer}', total '%{time_total}'"
01:05:01.235       To succeed, but it failed:
01:05:01.235       Exitcode: 126
01:05:01.235       Stdout:
01:05:01.235        	 OCI runtime exec failed: exec failed: container_linux.go:348: starting container process caused "process_linux.go:90: adding pid 27298 to cgroups caused \"failed to write 27298 to cgroup.procs: write /sys/fs/cgroup/cpu,cpuacct/kubepods/besteffort/pod50fb7930-cb61-11e8-9820-080027b66966/0dd2549e2396fad8cb09af59ba6b57f47011faf24b1c170ba98ed1dbc5122f4e/cgroup.procs: invalid argument\"": unknown
01:05:01.235
01:05:01.235       Stderr:
01:05:01.235        	 command terminated with exit code 126
01:05:01.235
01:05:01.235
01:05:01.235
01:05:01.235       /home/jenkins/workspace/Cilium-PR-Ginkgo-Tests-Validated/src/github.com/cilium/cilium/test/k8sT/Policies.go:697

test-me-please

Successful CI build:
https://jenkins.cilium.io/job/Cilium-PR-Ginkgo-Tests-Validated/7073/

test-me-please

Latest CI build failed:
https://jenkins.cilium.io/job/Cilium-PR-Ginkgo-Tests-Validated/7075/
Two bookinfo Cilium endpoints (details /endpoint 22344 and ratings/endpoint 33165) don't get ready in time:
00:38:57.442 STEP: Creating the istio-system namespace
00:38:57.442 STEP: Creating the Istio resources
00:38:57.442 STEP: Waiting for Istio pods to be ready
00:40:20.515 STEP: Waiting for Istio service "istio-statsd-prom-bridge" to be ready
00:40:20.515 STEP: Waiting for Istio service "istio-pilot" to be ready
00:40:20.515 STEP: Waiting for DNS to resolve Istio service "istio-statsd-prom-bridge"
00:40:20.516 STEP: Waiting for DNS to resolve Istio service "istio-pilot"
00:40:20.516 STEP: Creating policy in file "/home/vagrant/go/src/github.com/cilium/cilium/test/k8sT/manifests/istio-sidecar-init-policy.yaml"
00:40:20.516 STEP: Creating policy in file "/home/vagrant/go/src/github.com/cilium/cilium/test/k8sT/manifests/cnp-specs.yaml"
00:40:20.516 STEP: Creating resources in file "/home/vagrant/go/src/github.com/cilium/cilium/test/k8sT/manifests/bookinfo-v2-istio.yaml"
00:40:20.516 STEP: Creating resources in file "/home/vagrant/go/src/github.com/cilium/cilium/test/k8sT/manifests/bookinfo-v1-istio.yaml"
00:42:43.953 STEP: Waiting for Bookinfo pods to be ready
00:42:43.953 STEP: Waiting for Bookinfo endpoints to be ready
00:47:38.417 === Test Finished at 2018-10-09T05:53:32Z====
00:48:11.734 ===================== TEST FAILED =====================
...
00:50:20.772 K8sIstioTest
00:50:20.772 /home/jenkins/workspace/Cilium-PR-Ginkgo-Tests-Validated/src/github.com/cilium/cilium/test/ginkgo-ext/scopes.go:351
00:50:20.772   Istio Bookinfo Demo
00:50:20.772   /home/jenkins/workspace/Cilium-PR-Ginkgo-Tests-Validated/src/github.com/cilium/cilium/test/ginkgo-ext/scopes.go:351
00:50:20.773     Tests bookinfo inter-service connectivity [It]
00:50:20.773     /home/jenkins/workspace/Cilium-PR-Ginkgo-Tests-Validated/src/github.com/cilium/cilium/test/ginkgo-ext/scopes.go:383
00:50:20.773
00:50:20.773     Endpoints are not ready after timeout
00:50:20.773     Expected
00:50:20.773         <*helpers.SSHMetaError | 0xc4209fcbe0>: Error: Timeout reached: Endpoints are not ready after timeout
00:50:20.773     Extended info: 	Cilium Pod: cilium-dm45b 	Endpoint: 869 	Identity: 38906	 State: ready
00:50:20.773     	Cilium Pod: cilium-dm45b 	Endpoint: 2425 	Identity: 129	 State: ready
00:50:20.773     	Cilium Pod: cilium-dm45b 	Endpoint: 13344 	Identity: 4	 State: ready
00:50:20.773     	Cilium Pod: cilium-dm45b 	Endpoint: 17164 	Identity: 8353	 State: ready
00:50:20.773     	Cilium Pod: cilium-dm45b 	Endpoint: 17564 	Identity: 128	 State: ready
00:50:20.773     	Cilium Pod: cilium-dm45b 	Endpoint: 22344 	Identity: 35921	 State: not-ready
00:50:20.773     	Cilium Pod: cilium-dm45b 	Endpoint: 29750 	Identity: 128	 State: ready
00:50:20.773     	Cilium Pod: cilium-dm45b 	Endpoint: 36303 	Identity: 719	 State: ready
00:50:20.773     	Cilium Pod: cilium-dm45b 	Endpoint: 41903 	Identity: 16538	 State: ready
00:50:20.773     	Cilium Pod: cilium-dm45b 	Endpoint: 44902 	Identity: 23144	 State: ready
00:50:20.773     	Cilium Pod: cilium-dm45b 	Endpoint: 52811 	Identity: 15141	 State: ready
00:50:20.773     	Cilium Pod: cilium-dm45b 	Endpoint: 53403 	Identity: 34038	 State: ready
00:50:20.773     	Cilium Pod: cilium-dm45b 	Endpoint: 57455 	Identity: 46419	 State: ready
00:50:20.773     	Cilium Pod: cilium-dm45b 	Endpoint: 60749 	Identity: 26609	 State: ready
00:50:20.773     	Cilium Pod: cilium-xx9nh 	Endpoint: 15933 	Identity: 4	 State: ready
00:50:20.773     	Cilium Pod: cilium-xx9nh 	Endpoint: 20038 	Identity: 25315	 State: ready
00:50:20.773     	Cilium Pod: cilium-xx9nh 	Endpoint: 31676 	Identity: 9215	 State: ready
00:50:20.773     	Cilium Pod: cilium-xx9nh 	Endpoint: 33000 	Identity: 41387	 State: ready
00:50:20.773     	Cilium Pod: cilium-xx9nh 	Endpoint: 33165 	Identity: 37372	 State: not-ready
00:50:20.773     	Cilium Pod: cilium-xx9nh 	Endpoint: 35713 	Identity: 35405	 State: ready
00:50:20.773     	Cilium Pod: cilium-xx9nh 	Endpoint: 45865 	Identity: 2260	 State: ready
00:50:20.773     	Cilium Pod: cilium-xx9nh 	Endpoint: 51624 	Identity: 128	 State: ready
00:50:20.773     	Cilium Pod: cilium-xx9nh 	Endpoint: 55484 	Identity: 21304	 State: ready
00:50:20.773     	Cilium Pod: cilium-xx9nh 	Endpoint: 63566 	Identity: 128	 State: ready
00:50:20.773
00:50:20.773
00:50:20.773     to be nil
00:50:20.773
00:50:20.773     /home/jenkins/workspace/Cilium-PR-Ginkgo-Tests-Validated/src/github.com/cilium/cilium/test/k8sT/istio.go:284

However, all endpoints become ready just after the test times out.
Nearly all the bookinfo pods have been restarted, including the reviews pods which have no policy enforced:
00:48:12.084  	 NAMESPACE      NAME                                        READY   STATUS      RESTARTS   AGE     IP              NODE   NOMINATED NODE
00:48:12.084 	 default        details-v1-55dc568444-qrqdg                 2/2     Running     1          7m54s   <IP_ADDRESS>     k8s2   <none>
00:48:12.084 	 default        productpage-v1-77f9448886-h9xm7             2/2     Running     0          7m53s   <IP_ADDRESS>      k8s2   <none>
00:48:12.084 	 default        ratings-v1-79b777f868-7p6cc                 2/2     Running     1          7m54s   <IP_ADDRESS>     k8s1   <none>
00:48:12.084 	 default        reviews-v1-5996f4668-hjr8g                  2/2     Running     1          7m54s   <IP_ADDRESS>     k8s2   <none>
00:48:12.084 	 default        reviews-v2-bbb79fb98-lhtr8                  2/2     Running     1          7m54s   <IP_ADDRESS>     k8s1   <none>

This indicates a priori that the Istio sidecar proxy can't get configured and dies.

test-me-please

test-me-please

test-me-please

test-me-please

test-me-please

Unrelated k8s 1.12 test failure in the CI:
https://jenkins.cilium.io/job/Cilium-PR-Ginkgo-Tests-Validated/7126/execution/node/94/log/?consoleFull
Connectivity to google.com timed out:
01:31:16.237 K8sPolicyTest
01:31:16.237 /home/jenkins/workspace/Cilium-PR-Ginkgo-Tests-Validated/src/github.com/cilium/cilium/test/ginkgo-ext/scopes.go:351
01:31:16.237   Basic Test
01:31:16.237   /home/jenkins/workspace/Cilium-PR-Ginkgo-Tests-Validated/src/github.com/cilium/cilium/test/ginkgo-ext/scopes.go:351
01:31:16.237     Validate to-entities policies
01:31:16.238     /home/jenkins/workspace/Cilium-PR-Ginkgo-Tests-Validated/src/github.com/cilium/cilium/test/ginkgo-ext/scopes.go:351
01:31:16.238       Validate toEntities All [It]
01:31:16.238       /home/jenkins/workspace/Cilium-PR-Ginkgo-Tests-Validated/src/github.com/cilium/cilium/test/ginkgo-ext/scopes.go:383
01:31:16.238
01:31:16.239       HTTP egress connectivity to google.com from pod "app2-85b74b9c79-5hwbr"
01:31:16.239       Expected command: kubectl exec -n default app2-85b74b9c79-5hwbr -- curl -s -D /dev/stderr --fail --connect-timeout 3 --max-time 8 http://www.google.com/ -w "time-> DNS: '%{time_namelookup}(%{remote_ip})', Connect: '%{time_connect}',Transfer '%{time_starttransfer}', total '%{time_total}'"
01:31:16.239       To succeed, but it failed:
01:31:16.239       Exitcode: 28
01:31:16.239       Stdout:
01:31:16.239        	 time-> DNS: '0.000000()', Connect: '0.000000',Transfer '0.000000', total '3.513887'
01:31:16.239       Stderr:
01:31:16.239        	 command terminated with exit code 28
01:31:16.239
01:31:16.239
01:31:16.239
01:31:16.239       /home/jenkins/workspace/Cilium-PR-Ginkgo-Tests-Validated/src/github.com/cilium/cilium/test/k8sT/Policies.go:697

Starting a new CI run.

test-me-please

Successful CI build:
https://jenkins.cilium.io/job/Cilium-PR-Ginkgo-Tests-Validated/7127/
Starting another one to be sure.

test-me-please

Unrelated k8s 1.8 test failure:
https://jenkins.cilium.io/job/Cilium-PR-Ginkgo-Tests-Validated/7138/execution/node/93/log/
01:09:01.766 K8sPolicyTest
01:09:01.766 /home/jenkins/workspace/Cilium-PR-Ginkgo-Tests-Validated/src/github.com/cilium/cilium/test/ginkgo-ext/scopes.go:351
01:09:01.766   Basic Test
01:09:01.766   /home/jenkins/workspace/Cilium-PR-Ginkgo-Tests-Validated/src/github.com/cilium/cilium/test/ginkgo-ext/scopes.go:351
01:09:01.767     Allows traffic with k8s default-allow egress policy [It]
01:09:01.767     /home/jenkins/workspace/Cilium-PR-Ginkgo-Tests-Validated/src/github.com/cilium/cilium/test/ginkgo-ext/scopes.go:383
01:09:01.767
01:09:01.767     Egress connectivity should be allowed for pod "app2-75f77ffdbf-mcv7b"
01:09:01.767     Expected command: kubectl exec -n default app2-75f77ffdbf-mcv7b -- curl -s -D /dev/stderr --fail --connect-timeout 3 --max-time 8 http://www.google.com/ -w "time-> DNS: '%{time_namelookup}(%{remote_ip})', Connect: '%{time_connect}',Transfer '%{time_starttransfer}', total '%{time_total}'"
01:09:01.767     To succeed, but it failed:
01:09:01.767     Exitcode: 28
01:09:01.767     Stdout:
01:09:01.767      	 time-> DNS: '0.000000()', Connect: '0.000000',Transfer '0.000000', total '3.520778'
01:09:01.767     Stderr:
01:09:01.767      	 command terminated with exit code 28
01:09:01.767
01:09:01.767
01:09:01.767
01:09:01.767     /home/jenkins/workspace/Cilium-PR-Ginkgo-Tests-Validated/src/github.com/cilium/cilium/test/k8sT/Policies.go:659

The Istio test passed.
Starting another build.

test-me-please

Another unrelated CI build failure:
https://jenkins.cilium.io/job/Cilium-PR-Ginkgo-Tests-Validated/7146/execution/node/94/log/?consoleFull
01:45:42.176 K8sHealthTest
01:45:42.176 /home/jenkins/workspace/Cilium-PR-Ginkgo-Tests-Validated/src/github.com/cilium/cilium/test/ginkgo-ext/scopes.go:351
01:45:42.176   checks cilium-health status between nodes [It]
01:45:42.177   /home/jenkins/workspace/Cilium-PR-Ginkgo-Tests-Validated/src/github.com/cilium/cilium/test/ginkgo-ext/scopes.go:383
01:45:42.177
01:45:42.177   Expected
01:45:42.177       <string>: Connection timed out
01:45:42.177   to be empty
01:45:42.177
01:45:42.177   /home/jenkins/workspace/Cilium-PR-Ginkgo-Tests-Validated/src/github.com/cilium/cilium/test/k8sT/Health.go:112

The Istio test passed.
Starting another build.

test-me-please

Unrelated k8s 1.8 test failure:
https://jenkins.cilium.io/job/Cilium-PR-Ginkgo-Tests-Validated/7153/execution/node/93/log/
00:34:19.226 K8sHealthTest
00:34:19.226 /home/jenkins/workspace/Cilium-PR-Ginkgo-Tests-Validated/src/github.com/cilium/cilium/test/ginkgo-ext/scopes.go:351
00:34:19.227   checks cilium-health status between nodes [It]
00:34:19.227   /home/jenkins/workspace/Cilium-PR-Ginkgo-Tests-Validated/src/github.com/cilium/cilium/test/ginkgo-ext/scopes.go:383
00:34:19.227
00:34:19.227   Expected
00:34:19.227       <string>: Connection timed out
00:34:19.227   to be empty
00:34:19.227
00:34:19.227   /home/jenkins/workspace/Cilium-PR-Ginkgo-Tests-Validated/src/github.com/cilium/cilium/test/k8sT/Health.go:112

The Istio test passed.
Starting another build.

test-me-please

Unrelated k8s 1.12 test failure:
https://jenkins.cilium.io/job/Cilium-PR-Ginkgo-Tests-Validated/7156/execution/node/94/log/
01:21:31.641 K8sPolicyTest
01:21:31.644 /home/jenkins/workspace/Cilium-PR-Ginkgo-Tests-Validated/src/github.com/cilium/cilium/test/ginkgo-ext/scopes.go:351
01:21:31.644   Basic Test
01:21:31.644   /home/jenkins/workspace/Cilium-PR-Ginkgo-Tests-Validated/src/github.com/cilium/cilium/test/ginkgo-ext/scopes.go:351
01:21:31.644     Allows traffic with k8s default-allow egress policy [It]
01:21:31.645     /home/jenkins/workspace/Cilium-PR-Ginkgo-Tests-Validated/src/github.com/cilium/cilium/test/ginkgo-ext/scopes.go:383
01:21:31.645
01:21:31.645     Egress connectivity should be allowed for pod "app2-85b74b9c79-clkts"
01:21:31.645     Expected command: kubectl exec -n default app2-85b74b9c79-clkts -- curl -s -D /dev/stderr --fail --connect-timeout 3 --max-time 8 http://www.google.com/ -w "time-> DNS: '%{time_namelookup}(%{remote_ip})', Connect: '%{time_connect}',Transfer '%{time_starttransfer}', total '%{time_total}'"
01:21:31.645     To succeed, but it failed:
01:21:31.645     Exitcode: 28
01:21:31.645     Stdout:
01:21:31.645      	 time-> DNS: '0.000000()', Connect: '0.000000',Transfer '0.000000', total '3.521273'
01:21:31.645     Stderr:
01:21:31.645      	 command terminated with exit code 28
01:21:31.645
01:21:31.645
01:21:31.645
01:21:31.645     /home/jenkins/workspace/Cilium-PR-Ginkgo-Tests-Validated/src/github.com/cilium/cilium/test/k8sT/Policies.go:659

The Istio test passed.

I had 4 successful Istio test runs in a row.
I'm merging this PR as-is.


Question(mux-player-react): Is it possible to hide the player controls.

Is it possible to hide the video player controls similar to the controls prop in mux-video-react?

@tronic-chris not currently, but we're looking at ways to customize the existing controls. Stay tuned for more updates.


Wrap serialization errors as DevicePortalException for easier catching

I'd like to get others' feedback on if this is a good change or not.
Basically, the approach would be to try and catch and rethrow more errors as DevicePortalException so that callers of WDPW can more consistently catch exceptions and diagnose issues with the wrapper.
It is a slight breaking change for anyone that was expecting SerializationException before though.

This is related to issues #245 and #246


how to use it for other datasets?

just build the dataset in some format?
or need to rewrite the graph?

Hi @flydragon2018,
you could simply write a version of the network and fit it on your dataset.
Check here the code on how to make a graph for MNIST.


adding a origin to Origins directly should throw a error

It should be made clear that this code doesn't work. With an error/warning message when setting options.Origins to an empty set. Or the error: "Fully qualified origin {} of {} not equal to fully qualified original origin {,} ({})" could be elaborated to remind the user of checking how the HashSet had been inited
Services.AddFido2(options=>{
        //...
        options.Origins = new HashSet<string>();
        options.Origins.Add("http://localhost:5091");
       //...
})

I agree that this is a confusing behavior. I would welcome a PR to improve this.

We could just change the type from ISet to IReadOnlySet, stopping users from changing the origins after setting them and only allowing them to assign a new set. This way, you can see it immediately when implementing it instead of having to check the exception at runtime.

@Regenhardt Yeah I think that could work since HashSet derives from IReadOnlySet


ValueError: need at least one array to concatenate

When I train my own dataset  by: python tools/train.py configs/faster_rcnn_r50_fpn_1x.py --work_dir works
Then, It show the error :2019-12-06 11:27:45,332 - INFO - Start running, host: dachen@dachen-MRC-WX0, work_dir: /home/dachen/mmdetection/work_dirs/faster_rcnn_r50_fpn_1x 2019-12-06 11:27:45,332 - INFO - workflow: [('train', 1)], max: 12 epochs Traceback (most recent call last):   File "tools/train.py", line 110, in <module>     main()   File "tools/train.py", line 106, in main     logger=logger)   File "/home/dachen/Documents/mmdetection/mmdet/apis/train.py", line 60, in train_detector     _non_dist_train(model, dataset, cfg, validate=validate)   File "/home/dachen/Documents/mmdetection/mmdet/apis/train.py", line 232, in _non_dist_train     runner.run(data_loaders, cfg.workflow, cfg.total_epochs)   File "/home/dachen/conda/lib/python3.7/site-packages/mmcv/runner/runner.py", line 358, in run     epoch_runner(data_loaders[i], **kwargs)   File "/home/dachen/conda/lib/python3.7/site-packages/mmcv/runner/runner.py", line 260, in train     for i, data_batch in enumerate(data_loader):   File "/home/dachen/conda/lib/python3.7/site-packages/torch/utils/data/dataloader.py", line 278, in __iter__     return _MultiProcessingDataLoaderIter(self)   File "/home/dachen/conda/lib/python3.7/site-packages/torch/utils/data/dataloader.py", line 709, in __init__     self._try_put_index()   File "/home/dachen/conda/lib/python3.7/site-packages/torch/utils/data/dataloader.py", line 826, in _try_put_index     index = self._next_index()   File "/home/dachen/conda/lib/python3.7/site-packages/torch/utils/data/dataloader.py", line 318, in _next_index     return next(self._sampler_iter)  # may raise StopIteration   File "/home/dachen/conda/lib/python3.7/site-packages/torch/utils/data/sampler.py", line 200, in __iter__     for idx in self.sampler:   File "/home/dachen/Documents/mmdetection/mmdet/datasets/loader/sampler.py", line 63, in __iter__     indices = np.concatenate(indices) ValueError: need at least one array to concatenate
Anyone can solve it ?

If you think the bug is caused by the codebase and want to report it here, please use the Error Template especially tell us what you do to the code.
Otherwise, you could google or baidu, because this bug is normal for np.concatenate, for example, thie link.

https://github.com/open-mmlab/mmdetection/issues/210


feat: implement list command UX

According to: https://github.com/notaryproject/notation/blob/main/specs/commandline/list.md
Updated list command output
Signed-off-by: Junjie Gao<EMAIL_ADDRESS>

Codecov Report

Merging #414 (bc649f3) into main (f747031) will decrease coverage by 0.70%.
The diff coverage is 5.71%.

:exclamation: Current head bc649f3 differs from pull request most recent head d81b6b1. Consider uploading reports for the commit d81b6b1 to get more accurate results

@@            Coverage Diff             @@
##             main     #414      +/-   ##
==========================================
- Coverage   34.60%   33.90%   -0.71%
==========================================
  Files          23       23
  Lines        1254     1283      +29
==========================================
+ Hits          434      435       +1
- Misses        809      837      +28
  Partials       11       11

Impacted Files
Coverage Δ

cmd/notation/registry.go
0.00% <0.00%> (ø)

cmd/notation/list.go
25.37% <5.88%> (-16.74%)
:arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


recommend_from_interactions --exclude doesn't work properly

recommend can gets rid of 14 correctly,but recommend_from_interactions  doesn't work properly.

Who can tell me how to make it work ? Many thanks!

Just use the movieID column of the exclude_pairs SFrame, and the movieID column of ob as well.
The real bug here is that the recommend_from_interactions should not accept user information as part of either parameter and should instead error out.  Essentially, all the user data is dropped and not handled consistently, which is causing this issue.

Just use the movieID column of the exclude_pairs SFrame, and the movieID column of ob as well.
The real bug here is that the recommend_from_interactions should not accept user information as part of either parameter and should instead error out. Essentially, all the user data is dropped and not handled consistently, which is causing this issue.

Thanks for your reply!As shown below, recommend_from_interactions still can't rule out movieid 14.
Also,I would like to make a personalized recommendation system，if I don't use the userId，dose the result of recommendation have personality? Please help me...

@znation  Please assign this ticket to me as I would like to try fixing it and contribute .Thanks in advance!

Hi @dhivyaaxim, sure, thanks for your help!


wasm: update V8 to v<IP_ADDRESS>.

 Any plans on bumping these?
*WARNING* antlr4_runtimes has a newer release than 4.8@<2020-01-20 21:04:29> : 4.9.1@<2021-01-05 19:22:06>
*WARNING* com_github_wasm_c_api has had 13 commits since d9a80099d496b5cdba6f3fe8fc77586e0e505ddc@<2019-11-14 16:27:46>
*WARNING* com_github_wasmtime has a newer release than v0.21.0@<2020-11-05 16:14:30> : v0.22.1@<2021-01-19 15:12:39>
*WARNING* com_github_wavm_wavm has had 23 commits since e289ba654fe51655ab080819fd85ed9c936aae6e@<2020-09-17 02:57:59>
*WARNING* emscripten_toolchain has a newer release than 2.0.8@<2020-10-24 17:42:23> : 2.0.9@<2020-11-16 22:58:38>
*WARNING* emscripten_toolchain has a newer release than 2.0.8@<2020-10-24 17:42:23> : 2.0.10@<2020-12-04 16:53:37>
*WARNING* emscripten_toolchain has a newer release than 2.0.8@<2020-10-24 17:42:23> : 2.0.11@<2020-12-17 22:47:38>
*WARNING* emscripten_toolchain has a newer release than 2.0.8@<2020-10-24 17:42:23> : 2.0.12@<2021-01-09 15:25:52>
*WARNING* io_bazel_rules_rust has had 17 commits since aa7c6938cf1cc2973bc065c7532f89874bf09818@<2020-12-04 08:49:46>
*WARNING* proxy_wasm_cpp_host has had 3 commits since 6dab125d7a668c7158848b6f48c67fd827c952e6@<2020-12-16 07:09:20>
*WARNING* proxy_wasm_rust_sdk has had 2 commits since 802cab2eabc1da106d8b8b7be2c7278b2bfadfbd@<2020-12-05 00:12:31>

lgtm /deps

There are a bunch of deps that are out of date in the WASM / Rust space. Any plans on bumping these?
*WARNING* antlr4_runtimes has a newer release than 4.8@<2020-01-20 21:04:29> : 4.9.1@<2021-01-05 19:22:06>
*WARNING* com_github_wasm_c_api has had 13 commits since d9a80099d496b5cdba6f3fe8fc77586e0e505ddc@<2019-11-14 16:27:46>
*WARNING* com_github_wasmtime has a newer release than v0.21.0@<2020-11-05 16:14:30> : v0.22.1@<2021-01-19 15:12:39>
*WARNING* com_github_wavm_wavm has had 23 commits since e289ba654fe51655ab080819fd85ed9c936aae6e@<2020-09-17 02:57:59>
*WARNING* emscripten_toolchain has a newer release than 2.0.8@<2020-10-24 17:42:23> : 2.0.9@<2020-11-16 22:58:38>
*WARNING* emscripten_toolchain has a newer release than 2.0.8@<2020-10-24 17:42:23> : 2.0.10@<2020-12-04 16:53:37>
*WARNING* emscripten_toolchain has a newer release than 2.0.8@<2020-10-24 17:42:23> : 2.0.11@<2020-12-17 22:47:38>
*WARNING* emscripten_toolchain has a newer release than 2.0.8@<2020-10-24 17:42:23> : 2.0.12@<2021-01-09 15:25:52>
*WARNING* io_bazel_rules_rust has had 17 commits since aa7c6938cf1cc2973bc065c7532f89874bf09818@<2020-12-04 08:49:46>
*WARNING* proxy_wasm_cpp_host has had 3 commits since 6dab125d7a668c7158848b6f48c67fd827c952e6@<2020-12-16 07:09:20>
*WARNING* proxy_wasm_rust_sdk has had 2 commits since 802cab2eabc1da106d8b8b7be2c7278b2bfadfbd@<2020-12-05 00:12:31>

lgtm /deps

/lgtm deps

/lgtm deps

There are a bunch of deps that are out of date in the WASM / Rust space. Any plans on bumping these?
*WARNING* antlr4_runtimes has a newer release than 4.8@<2020-01-20 21:04:29> : 4.9.1@<2021-01-05 19:22:06>
*WARNING* com_github_wasm_c_api has had 13 commits since d9a80099d496b5cdba6f3fe8fc77586e0e505ddc@<2019-11-14 16:27:46>
*WARNING* com_github_wasmtime has a newer release than v0.21.0@<2020-11-05 16:14:30> : v0.22.1@<2021-01-19 15:12:39>
*WARNING* com_github_wavm_wavm has had 23 commits since e289ba654fe51655ab080819fd85ed9c936aae6e@<2020-09-17 02:57:59>
*WARNING* emscripten_toolchain has a newer release than 2.0.8@<2020-10-24 17:42:23> : 2.0.9@<2020-11-16 22:58:38>
*WARNING* emscripten_toolchain has a newer release than 2.0.8@<2020-10-24 17:42:23> : 2.0.10@<2020-12-04 16:53:37>
*WARNING* emscripten_toolchain has a newer release than 2.0.8@<2020-10-24 17:42:23> : 2.0.11@<2020-12-17 22:47:38>
*WARNING* emscripten_toolchain has a newer release than 2.0.8@<2020-10-24 17:42:23> : 2.0.12@<2021-01-09 15:25:52>
*WARNING* io_bazel_rules_rust has had 17 commits since aa7c6938cf1cc2973bc065c7532f89874bf09818@<2020-12-04 08:49:46>
*WARNING* proxy_wasm_cpp_host has had 3 commits since 6dab125d7a668c7158848b6f48c67fd827c952e6@<2020-12-16 07:09:20>
*WARNING* proxy_wasm_rust_sdk has had 2 commits since 802cab2eabc1da106d8b8b7be2c7278b2bfadfbd@<2020-12-05 00:12:31>

Thanks!
We should upgrade antlr4_runtimes (cc @kyessenov) and com_github_wasmtime (cc @mathetake), but I don't see too much value in chasing every commit in other repositories.
Also, we're using the version of com_github_wasm_c_api pinned in com_github_wasmtime, so we shouldn't be divering from that, even if there is more recent version available.

 Any plans on bumping these?
*WARNING* antlr4_runtimes has a newer release than 4.8@<2020-01-20 21:04:29> : 4.9.1@<2021-01-05 19:22:06>
*WARNING* com_github_wasm_c_api has had 13 commits since d9a80099d496b5cdba6f3fe8fc77586e0e505ddc@<2019-11-14 16:27:46>
*WARNING* com_github_wasmtime has a newer release than v0.21.0@<2020-11-05 16:14:30> : v0.22.1@<2021-01-19 15:12:39>
*WARNING* com_github_wavm_wavm has had 23 commits since e289ba654fe51655ab080819fd85ed9c936aae6e@<2020-09-17 02:57:59>
*WARNING* emscripten_toolchain has a newer release than 2.0.8@<2020-10-24 17:42:23> : 2.0.9@<2020-11-16 22:58:38>
*WARNING* emscripten_toolchain has a newer release than 2.0.8@<2020-10-24 17:42:23> : 2.0.10@<2020-12-04 16:53:37>
*WARNING* emscripten_toolchain has a newer release than 2.0.8@<2020-10-24 17:42:23> : 2.0.11@<2020-12-17 22:47:38>
*WARNING* emscripten_toolchain has a newer release than 2.0.8@<2020-10-24 17:42:23> : 2.0.12@<2021-01-09 15:25:52>
*WARNING* io_bazel_rules_rust has had 17 commits since aa7c6938cf1cc2973bc065c7532f89874bf09818@<2020-12-04 08:49:46>
*WARNING* proxy_wasm_cpp_host has had 3 commits since 6dab125d7a668c7158848b6f48c67fd827c952e6@<2020-12-16 07:09:20>
*WARNING* proxy_wasm_rust_sdk has had 2 commits since 802cab2eabc1da106d8b8b7be2c7278b2bfadfbd@<2020-12-05 00:12:31>

Thanks!
We should upgrade antlr4_runtimes (cc @kyessenov) and com_github_wasmtime (cc @mathetake), but I don't see too much value in chasing every commit in other repositories.
Also, we're using the version of com_github_wasm_c_api pinned in com_github_wasmtime, so we shouldn't be divering from that, even if there is more recent version available.

We have a comment for com_github_wasm_c_api noting the pinning so we are all good there - https://github.com/envoyproxy/envoy/blob/main/bazel/repository_locations.bzl#L621-L622. In addition to antlr4 and wasmtime that you note, it would be good to bump emscripten where we are 4 releases behind

We have a comment for com_github_wasm_c_api noting the pinning so we are all good there - https://github.com/envoyproxy/envoy/blob/main/bazel/repository_locations.bzl#L621-L622. In addition to antlr4 and wasmtime that you note, it would be good to bump emscripten where we are 4 releases behind


How to detect no records scenarios when observing childevents

observeChildEvents return flowables which do not complete when there are no records in database. If I have to show an emptyview how do I go about it? How do I check if there are no records in database.

observeChildEvents is a Flowable. If it's call onComplete  when there is no data. Your Flowable will be disposed and even if you recieve new items they will not be emmited. This is how Firebase works too without the library wrapper.
You open a listener for listen childs, if there is no childs, there is no callbacks.
If you wanna show a "there is no data" message or something like that. I suggest you to use observeSingleEventListener which is a Maybe and will return onComplete if there is not data.
Anyway, the result that you will have using a observeChildEvents that calls onComplete if there is not data will be the same, because your subscription will be dispose after onComplete


opensearch-s3-access-check failing

:nut_and_bolt: Description: What code changed, and why?
aws-opensearch-s3-bucket-access check is failing for AWS with AWS Managed Services, modified the trigger check.

:chains: Related Resources
:+1: Definition of Done

Modified the trigger check to pass the aws-opensearch-s3-bucket-access

:athletic_shoe: How to Build and Test the Change
:white_check_mark: Checklist
All PRs must tick these:

[X] I have read the CONTRIBUTING document.
[X] All commits signed-off for the Developer Certification of Origin.

With occasional exceptions, all PRs from Progress employees must tick these:

[X] Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
[X] Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
[X] Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
[X] Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
[X] Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

[X] Tests added/updated? (all new code needs new tests)
[ ] Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.
:camera: Screenshots, if applicable
Before the check is failing with the following error

After

I have tested in AWS with AWS managed- working fine
In OnPrem with AWS Managed-If we are not providing access_key and secret_key config parser is returning error, same with onPrem chef-managed.


Route  Resource config  Controllers Class does not exist.

Route config
Route::resource('product', \Modules\Admin\Http\Controllers\ProductController::class);
Illuminate\Contracts\Container\BindingResolutionException
Target class [Modules\Admin\Http\Controllers\Modules\Admin\Http\Controllers\ProductController] does not exist.

@githublirui how did you solve it?


Add a set of tests for the React-based UI

Currently there are sadly, zero tests. Would love some help getting a set of these in place for the frontend

a baseline of this has been implemented, coverage not where we want yet, will open a different ticket for that.


Bitcode error on Xcode10

When building our project for our enterprise we come across this issue with bitcode:
Bundle only contains bitcode-marker
We are manually installing the framework to improve build times. We have the suggested run script in our build phase and this was fine with Xcode 9.4.. The only difference is the new build system in Xcode 10.
2018-06-27 12:22:43.217 xcodebuild[34625:6042695] [MT] IDEDistribution: -[IDEDistributionLogging _createLoggingBundleAtPath:]: Created bundle at path '/var/folders/jd/5thvvccs3l10mnxr5sr4bxfr0000gn/T/BBCiPlayer-Enterprise_2018-06-27_12-22-43.205.xcdistributionlogs'.
error: exportArchive: Failed to verify bitcode in OptimizelySDKiOS.framework/OptimizelySDKiOS:
error: Bundle only contains bitcode-marker /var/folders/jd/5thvvccs3l10mnxr5sr4bxfr0000gn/T/XcodeDistPipeline.VTn/Root/Payload/BBCiPlayer-Enterprise.app/Frameworks/OptimizelySDKiOS.framework/OptimizelySDKiOS (armv7)

Error Domain=IDEFoundationErrorDomain Code=1 "Failed to verify bitcode in OptimizelySDKiOS.framework/OptimizelySDKiOS:
error: Bundle only contains bitcode-marker /var/folders/jd/5thvvccs3l10mnxr5sr4bxfr0000gn/T/XcodeDistPipeline.VTn/Root/Payload/BBCiPlayer-Enterprise.app/Frameworks/OptimizelySDKiOS.framework/OptimizelySDKiOS (armv7)

" UserInfo={NSLocalizedDescription=Failed to verify bitcode in OptimizelySDKiOS.framework/OptimizelySDKiOS:
error: Bundle only contains bitcode-marker /var/folders/jd/5thvvccs3l10mnxr5sr4bxfr0000gn/T/XcodeDistPipeline.VTn/Root/Payload/BBCiPlayer-Enterprise.app/Frameworks/OptimizelySDKiOS.framework/OptimizelySDKiOS (armv7)

}

** EXPORT FAILED **

@Winnie90 we believe this is fixed with the release of 2.1.2. Please let us know if you are still having problems.

hi thomaszurkan-optimizely
could you please tell me how you fix this error?
same error happened in my project.

During making of build uncheck the Rebuild from Bitcode. option and add the following script under Build phases.

@AM-lu
What version of the sdk?
What version of xcode?
How are you installing sdk (carthage/cocoapods)?
How are you building the sdk?
Assume this is for release?
Thanks!

hi
@thomaszurkan-optimizely
First of all, I must say I am not a user of optimizely.
In my Project, we use another different SDK,
All is work well until Xcode9, but when I update to Xcode10, try to archive my app, the similar error was happen.
error: Bundle only contains bitcode-marker

@AM-lu  where you able to solve this? I'm encountering the same issue.

I'm going to go ahead and close this since we are not having problems with the latest version of xcode 10 and we have made a fix. Please feel free to reopen if you feel this was an error.


Above 5.4.3, Spyder launch stuck at "Launching code analysis"

Issue Report Checklist

[x] Searched the issues page for similar reports
[x] Read the relevant sections of the Spyder Troubleshooting Guide and followed its advice
[x] Reproduced the issue after updating with conda update spyder (or pip, if not using Anaconda)
[ ] Could not reproduce inside jupyter qtconsole (if console-related)
[x] Tried basic troubleshooting (if a bug/error)

[x] Restarted Spyder
[x] Reset preferences with spyder --reset
[x] Reinstalled the latest version of Anaconda
[x] Tried the other applicable steps from the Troubleshooting Guide

[x] Completed the Problem Description, Steps to Reproduce and Version sections below

Problem Description
I have been running Spyder for many years. It works perfectly with 5.4.2, when updating to 5.4.3 or 5.4.4, launch gets stuck on "Launching code analysis"
What steps reproduce the problem?

Launch Spyder >5.4.3
It gets stuck

Personal note: I have been installing the last version of Spyder on Ubuntu 22.04.2 LTS through Anaconda on the laptops of my students, it works.
What is the expected output? What do you see instead?
I would expected Spyder to launch, it gets stuck.
Paste Traceback/Error Below (if applicable)
spyder-debug.log
Versions

Spyder version: > 5.4.3
Python version:  3.11.4
Qt version: 5.15.8
PyQt version: 5.15.7
Operating System name/version: Ubuntu 22.04.2 LTS

Dependencies
I cannot access the Menu since Spyder does not launch. Here is the conda environment I created to perform the final test (mamba create -n spyder-env python=3 spyder)
mamba_env.txt
For the Devs who are going to check this, thanks a lot for all your work. I really enjoy working with Spyder.

Hey @mmontarges, thanks for reporting. I tried to reproduce your problem in a Python 3.11, conda-forge environment, but I was unable to.
However, reading carefully your debug file, it seems Spyder is not hanging when loading the Code Analysis plugin but the Pythonpath manager one.
Do you have the PYTHONPATH environment variable set in your system? You can check that by running the printenv command in a terminal and looking for it.

For the Devs who are going to check this, thanks a lot for all your work. I really enjoy working with Spyder.

And thanks a lot for your kind words! We really appreciate users letting us know that.

@mmontarges, sorry for the delay in answering back. Please open a terminal, start IPython and run there:
In [1]: from spyder.utils.environ import get_user_env
In [2]: env = get_user_env()
In [3]: env

After doing that, are you experiencing a hang too?

Hi @ccordoba12
No problem, before today I would not have had the time. Perfect timing. Yes IPython hangs on line 2.

Ok, that's what I thought. Thanks for the confirmation.
@mrclary, what could we do about this in the 5.x branch? At least we should prevent the subprocess that tries to get the user env vars to hang.

@mrclary, what could we do about this in the 5.x branch? At least we should prevent the subprocess that tries to get the user env vars to hang.

We could update get_user_env_variables to provide a timeout with Popen.communicate. However, I don't know if this will resolve the issue because I cannot reproduce it on my Ubuntu VM. I'd really like to know what is causing it to hang.

We could update get_user_env_variables to provide a timeout with Popen.communicate

Ok, that's good ro know.

I don't know if this will resolve the issue because I cannot reproduce it on my Ubuntu VM.

We can ask @mmontarges to apply the change on his system and check.

I'd really like to know what is causing it to hang.

Since the implementation changed completely in master, I don't know if it's worth it to put more effort into finding the cause. In addition, it's quite important to provide a fix for 5.5 since this is making Spyder hang at startup.

@mmontarges, could you check if the following fixes the issue for you?
Add a timeout to proc.communicate by modifying line 75 of /home/mmontarges/Softwares/Anaconda/envs/spyder-env/lib/python3.11/site-packages/spyder/utils/environ.py.
            stdout, stderr = proc.communicate(timeout=2)

Hi @mrclary, indeed this fix solves the problem. Thank you !

@mrclary, could we reduce that timeout to 0.5? I guess that getting the user env vars should be really fast, so if it takes more than 0.5 sec, then we can be sure that it hanged. Besides, a 0.5 sec delay at startup is almost unnoticeable, but a 2 sec one surely is.

I'll submit a PR on the 5.x branch for this. And, yes, we can set the timeout to whatever is appropriate.


Updates for ISXD dropped frames, ROI signal extraction, and misc. features

NEW

ciapkg.signal_extraction.computeSignalsFromImages: CIAtah package wrapper for applyImagesToMovie.
@ciatah: added the ciatah alias for calciumImagingAnalysis class.

Updated

getRegistrationSettings:  Add support for user canceling the input. Added support for calculating dropped frames if entire frame of a movie is a set value.
modelPreprocessMovieFunction: Added support for calculating dropped frames if entire frame of a movie is a set value. Changed order so that dropped frames calculated before dF/F.
viewMovie: Added support for viewing movies from disk.
applyImagesToMovie - Finished updating to allow read from disk and binning. Added support for weighted computation of signals based on pixel values in each image.

Tested on Matlab 2019b, Windows 10. Merging.


Downloading: An Important Note About A Cloud Guru and Linux Academy Courses ...

Executing for https://linuxacademy.com/cp/modules/view/id/432

Trying to log in ... *
←[92m~ Logged in! ~←[0m
Getting lesson links...
Course name detected as Managing Microsoft Azure Applications and Infrastructure with Terraform
Enumerating links and sources ...
Commencing download ...
Downloading: An Important Note About A Cloud Guru and Linux Academy Courses ...
ERROR: Unsupported URL: https://linux
academy.com/cp/ssologin
ERROR: Unsupported URL: https://linuxacademy.com/cp/ssologin
Downloading failed. Perhaps, the cookies have expired.

I already did the mentioned solution but still occurs for every course I download

Hello , I get the same error, looks like you can only down the courses which you have either purchased or part of community courses..

Sorry for the late response. I think your right, that is the last day of my subscription in Linux Academy. I might have not seen it prior to downloading.


Migration to Gradle Version Catalog

Superseded by https://github.com/micronaut-projects/micronaut-multitenancy/pull/128


#168 Improve testkit for Java usage

Other than that, LGTM. Thanks!

I have also addressed some codacy issues in unit tests.


Substitute arbitrary username examples with built-in system environment variables

Code of Conduct

[X] I have read and agree to the GitHub Docs project's Code of Conduct

What article on docs.github.com is affected?
https://github.com/github/docs/blob/main/content/authentication/connecting-to-github-with-ssh/generating-a-new-ssh-key-and-adding-it-to-the-ssh-agent.md
What part(s) of the article would you like to see updated?
The guide provides an arbitrary username when it could instead refer to a built-in system variable that asserts the correct path required.
%USERPROFILE% will point to the current users profile, whereas C:\Users\YOU\ is far less sufficient to use from the end-user trying to read and troubleshoot their issue with the article.
The most prominent example that needs to be changed is here, in which the user would need to make extraneous modifications to the command before running it.
By replacing arbitrary username placeholders with built-in system environment variables as substitutes, it will slightly improve the convenience of the end-user following the instructions in the article. It makes it much faster to troubleshoot problems
Additional information
No response

@loonaticx Thank you for opening an issue and linking it to your PR! ✨

Dont know how to solve this

Closing this issue - linked PR has been closed for inactivity 💛


G27 Shifter Support.

Add additional configurability to ShifterAnalog to support.
Also add concept of ButtonSink so that classes can get button status.

GUI Screenshot (on macOS):


Not able to use the feature

I want to upload my run results to Zephyr but  I am getting the below error
Basic authentication with passwords is deprecated.
Here is the reporter configs
['playwright-zephyr', {
host: 'https://------.atlassian.net/jira',
user<EMAIL_ADDRESS>password: 'ABCDE@123',
authorizationToken:'563556353563hdsdgh',
projectKey: 'KEY'
}]
Please help

Hello. Could you change this PR? https://github.com/elaichenkov/playwright-zephyr/pull/11 For me now it return 500 so I have no idea if it works

Finally, I've added support for the Cloud API. So, please, update the library to the 1.0.3 version and add cloud reporter into your playwright.config.ts file:
// playwright.config.ts
import { PlaywrightTestConfig } from '@playwright/test';

const config: PlaywrightTestConfig = {
  reporter: [
    ['playwright-zephyr/lib/src/cloud', {
      projectKey: 'JARV', // <-- Replace with your project key
      authorizationToken: process.env.ZEPHYR_AUTH_TOKEN, // <-- Replace with your authorization token
    }],
  ],
}


Periodic Features

Summary
Create periodic features such that there is no discontinuity in feature space where there shouldn't be one. E.g the 365 day of year should be adjacent to the 1st. I would imagine the API would work similar to the specification of categorical features with the additional component of the mimimum and maximum feature value that are equivalent. (E.g hour 0 and 24 of day are the same.)
Motivation
I primarily work with timeseries forecasting and common features we use are hour of day, day of week or day of year. If we take the day of year for example and I use the feature the the 365 day is not adjacent to the 1st day in feature space, but is it is in actuality. The model has to learn these days are likely to be similar rather than starting from that prior.  I am often in the position where I have some data for Jan to say May, my prediction for December would have the day of year feature being built off May's data when in fact it should be more like Jan. This would also provide an additional constraint that should help the model fit better in the case of hour of day or day of week. Other periodic features could be angle.
Description
From a user perspective I imagine that we specify which features are periodic and what is the min and max feature values that are equivalent e.g 0 and 24 for hours. This could be done by passing a Dict[feature_name, Tuple[minval, maxval]] in the same way as the categorical features are defined.
Internally in the tree algorithm, in order to split the periodic feature, 2 leaf boundaries would have to be defined initially for a given feature, so the best pair of boudaries would be chosen. After which I imagine the algorithm working as it currently does.
In the hour of day example the optimum first split might be defined with hours 3 and 12, in which case one leaf is hour 3<h<12 and the other is 12<h<24 & 0<h<3.
If linear_tree=True then only one initial split would be required to fit a linear relationship.
References
Periodic constraints have been implemented in the pygam package.
https://pygam.readthedocs.io/en/latest/notebooks/tour_of_pygam.html

Closed in favor of being in #2302. We decided to keep all feature requests in one place.
Welcome to contribute this feature! Please re-open this issue (or post a comment if you are not a topic starter) if you are actively working on implementing this feature.

@Fish-Soup
Workaround: https://www.reddit.com/r/MachineLearning/comments/box3go/d_how_can_neural_nets_deal_with_cyclical_values/enltinf?utm_source=share&utm_medium=web2x&context=3

@candalfigomoro
I've seen that workaround, it's oknwhennyoubhavr  complete days for the range. Buy in my case in often don't have say the second part of the year. And you can get the features creating like thr reverse pattern in the second half of the year.
Thanks though I might try it put again and see how it peforms.


[eas-cli] return an informative error if rollout channel dne

Checklist

[x] I've added an entry to CHANGELOG.md if necessary. You can comment this pull request with /changelog-entry [breaking-change|new-feature|bug-fix|chore] [message] and CHANGELOG.md will be updated automatically.

Why
giving a non-existent channel to eas channel:rollout does-not-exist results in a non-informative error.
How
Confirm the channel is defined at the call site and throw an informative error if it is not.
Since we know the channel is defined, we can simplify the types passed through the code.
Test Plan
Tested affected rollout routes in a demo repo.

/bug-fix  return an informative error if rollout channel does not exist

/bug-fix return informative error when running 'eas channel:rollout' with a channel that does not exist

/changelog-entry bug-fix return informative error when running 'eas channel:rollout' with a channel that does not exist

Make sure to add a changelog entry. Previously, you used the wrong command. Take a look at my previous comment - it didn't work because only the PR author can add changelog entries.

/changelog-entry bug-fix return informative error when running 'eas channel:rollout' with a channel that does not exist


Add additional CAs to admin kubeconfig even when status URLs set.

We discovered that in situations where the status URLs get set, but at a time when the additional CAs were not configured properly, the cluster goes into a state where it's admin kubeconfig will never be updated. Because it lacks the correct CAs, the cluster is permanently marked unreachable and hive cannot communicate with it.
This fix adjusts the admin kubeconfig reconciliation such that it always runs even if status URLs are already set. The postProcessAdminKubeconfig method was broken down as it mixed implicit updates with updates the caller was expected to do, and we require different assumptions regarding the status URLs. Methods renamed to be more clear as to what they're actually doing.
Added two tests which only check that we copied the kubeconfig data to the raw field, indicating that the additional CAs would be added if any were configured, when the status URLs are set and not set. There did not appear to be any coverage of this functionality beforehand.

This looks good for resolving the issue on hive-int.
Long term, the controller should only have one place where it adjusts the kubeconfig. Also, the controller should have the same behavior for the console and API URLs, where the controller enforces that the values are correct in the status and not just present.
/lgtm


Improve scripting

Simplify package scripts and allow disabling some targets

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Update the lesson plan

Update the lesson plan for week 1 and comment on weeks 2-4

Okay I have started to update the plan for week 1 in commit https://github.com/symmy596/Advanced_Practical_Chemistry_Teaching/commit/1dc7ff8ef2e0d561b54073386128a2a20fc677d4. Currently I have the application of MD in the first week to be to use it to look at the ideal gas law with pylj. Obviously this might not be ideal as they will be going on to look at solid things (transport properties, etc.) Another option might be to use the (now working as of commit https://github.com/arm61/pylj/commit/4dc1c59941d7edf99158238af56b695d7fb17fe9) MSD plotting feature in pylj to see the difference between solid liquid and gas or something like that. Thoughts?
I am going to go back (probably tomorrow) and comment on weeks 2-4

Okay commit https://github.com/symmy596/Advanced_Practical_Chemistry_Teaching/commit/455ae899bb8ef965bcad8ce314cb8355690b7f2c has another pass at week 1 and some changes to week 2.

right commit https://github.com/symmy596/Advanced_Practical_Chemistry_Teaching/commit/a1f09195282ae6bafde2caee8aa6f102c3e9c7d0 has some work on the week 3 for the lesson plan

So commit https://github.com/symmy596/Advanced_Practical_Chemistry_Teaching/commit/b2149b6dfe91edbcb08bbf5b9f443166987be026 see me finishing the pass of the lesson plan. @symmy596 if you wanna go through it and change things/change back the stuff of yours I changed and then close this issue once you are happy


[help]I can't shutdown ipad when utm crashed

Hi, crash occurred when I have updated the latest version of 0.8. Now I can't do anything with it. It shows white screen, and I even can't reboot or shutdown. How should I do? Just wait for the battery running out of power? Be anxious!
Can anyone help me?

IPad Pro with version 13.4.1

press vol up, vol down, then hold power button until apple logo shows

press vol up, vol down, then hold power button until apple logo shows

It doesn't work, I have tried more than 10 times. It only lock and unlock, and siri works but no app can be open.

The utm shows white screen, and can't be switched to desktop or any other apps(and settings)

just make sure you quickly press up+down then keep holding the power button for a really long time and don’t release it until logo shows

just make sure you quickly press up+down then keep holding the power button for a really long time and don’t release it until logo shows

It really doesn't work... I don't know why the version 0.8 makes so big bug (maybe ipados's bug)

I guess wether the system panel or function is restricted when the bug occurs

just make sure you quickly press up+down then keep holding the power button for a really long time and don’t release it until logo shows

It really doesn't work... I don't know why the version 0.8 makes so big bug (maybe ipados's bug)

Leave it just running out of power
Maybe only this method.


Relative paths in tsconfig extends not supported

Summary
Relative paths in the tsconfig extends field don't appear to work. If I adjust the path to be relative to the cwd, things work as expected.
Happy to open a PR if that'd be helpful. Thanks!

Reproduction steps
Adjust the extends field in a tsconfig file to use a relative path. Run Skott, and observe exceptions when reading tsconfig.

Expected result:
Actual result:
Standard questions
Please answer these questions to help us investigate your issue more quickly:

Question
Answer

skott installed version?
0.35.3

Operating system?
Mac

Would you consider contributing a PR?
Yes

Node.js version (node -v)?
v20.11.1

Hello @rmunch,
Thanks for reporting the issue!
Could you please provide me a concrete example of a not working config (the one you opened the issue for) vs the working config? Just to make sure that there is no quiproquo regarding the issue to fix (most of the time relative paths are misleading).
Thanks

@rmunch,
I'm not sure I understood the problem, I might be missing details, here is a working example with skott working extends from tsconfig.json using a relative path to tsconfig.alias.json
For me to be able to solve the issue I would need the configuration you're using that is all the tsconfig and what you're trying to achieve.

I see, in that case the outcome will probably depend on the directory where skott is run.
It should probably be documented somewhere, but currently skott is not really supporting the run from a directory where files are relying on path aliases references or definitions located in parent directories. What you describe to me seems like you're running skott from a sub-package and this sub-package references a tsconfig in a parent directory (which seems to be the root of the repository, usually where a tsconfig.base.json lives).
In the case you're describing, running skott from the root directory where path alias references live and then target the sub directory using --cwd=<dir> (to narrow the analysis to files located in <dir>) should work. In other words running skott from ../ that is in the same directory as tsconfig.alias.json should work, as there are only references starting with the cwd as a base reference (nothing goes outside): cd ../ && skott --cwd=<package>
While as I user I would expect both ways to work out of the box, having all resolution cases working with path aliases support  indeed comes with a lot of edge cases and challenges. Also, some design decisions don't allow me an easy fix, but rather needing more or less a wide re-design, you can read a bit more there if you're interested.


hwmv2: boards: Fix variants and revisions

Fixes revisions and variants which do not have the soc name in the filenames

Moved to https://github.com/zephyrproject-rtos/zephyr/pull/69671


It is hard to understand where has the "AccountController" in previous version has gone to ,and what replaces it.

It is hard to understand where has the "AccountController" in previous version has gone to ,and what replaces it.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 804e24dd-7e30-8cf5-2c99-1ffacb4582f6
Version Independent ID: 3e25547b-e2c9-6634-2c38-2a77207f17d4
Content: Scaffold Identity in ASP.NET Core projects
Content Source: aspnetcore/security/authentication/scaffold-identity.md
Product: aspnet-core
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

See The 2.1  Migration doc/Changes to authentication code

Thanks a lot !
also : How come that for Asp.NET WebAPI projects you can use Individual Authentication using local storage and the template "forces" you to use Active Directory B2C ?

How come that for Asp.NET WebAPI projects you can use Individual Authentication using local storage and the template "forces" you to use Active Directory B2C ?

@blowdart  Can you answer? that's probably worth documenting.  cc/ @CamSoper

Bug - you shouldn't be scaffolding identity into an API project :)

Sorry, I gave wrong description.
How come that for MVC project you can use Identity with local storage
And for WebApi you must use AD ?
What do you mean “bug”?
We have been using Identity in WebAPI for years , there is even a pluralsight course on this topic ( approx 2015)

Because WebApi shouldn't be authenticated with cookies, it should be with JWT. When we moved to Core the JWT service went away. It's planned to come back in some form soon.


Replace WYSIWYG editor

Oscar currently uses the bootstrap-wysiwyg HTML editor.  However, this is causing a number of problems.
For example, it doesn't support IE7 which is a requirement for lots of Tangent projects (sadly).
Related tickets:

https://github.com/tangentlabs/django-oscar/issues/730
https://github.com/tangentlabs/django-oscar/issues/344

Hello.
There is any resolutions for this issue?
As I understand CKEditor didn't be integrated.

Yes - see the commit that closed this issue. We switched to using TinyMCE.


Add WhatsApp share button for QuoteVerse

Adding a WhatsApp share button can allow users to share the quote and link of QuoteVerse with other people.
Would really appreciate it if you assign me this issue under Hacktoberfest 2023.

sure why not, just follow:

star the repo,
make a clone of the repo
do neccessary changes
make a PR

Assign this issue to me under Hcktoberfest, As I already worked on these issues. So assign this to me.

Assign this issue to me under Hcktoberfest, As I already worked on these issues. So assign this to me.
dear @Kapileswar-Moharana ,
as it is already assigned to someone, you can contribute on other issues or add a new issue with feature adding or bug fixing.
but first of all read the rules first

if the assigned person doesnt get his job done with in 48 hours,
we will ask you to do so .
happy hacktoberfest 🥳

Assign this issue to me under Hcktoberfest, As I already worked on these issues. So assign this to me.
dear @Kapileswar-Moharana ,
as it is already assigned to someone, you can contribute on other issues or add a new issue with feature adding or bug fixing.
but first of all read the rules first

if the assigned person doesnt get his job done with in 48 hours, we will ask you to do so . happy hacktoberfest 🥳

Okay Then

Kindly check #28  and merge it


Scaling a dynamically added svg is not aligned with the background!

Hello,
Currently, I am working on an application that draws freehand overlay, saves the overlay to a file. Then, reload the saved overlay from the file to the webpage.
I managed to draw the first overlay and save the 'svg' element to my machine as a text file. However, when reopening the saved overlay again after clearOverlays() the saved overlay does not align with the background image unless the image is in the original zooming size. The problem I am facing is that when zooming in/out the image, the overlay keeps its original size while the image behind is resizing correctly. Bellow is code segments of the process, any help or suggestion is appreciated. Two screenshots of the process are attached, the 1st is after drawing the overlay, while the 2nd is after saving and reloading the overlay.
show the image and start drawing the overlay
this.viewer = OpenSeadragon({
            id: "seadragon-viewer",
            prefixUrl: "//openseadragon.github.io/openseadragon/images/",
            tileSources: [{
                type : 'image',
                url: 'back_image.jpg'
                 }]
            });
            viewer.initializeAnnotations();

Saving the drown overlay:
<button type="button" onclick="save_mask()">Save mask</button>
            <script>
                function save_mask() {
                    var svgElement = document.getElementsByTagName('svg');
                    // let height =  svgElement[0].style.height;
                    // let width =  svgElement[0].style.width;
                    let clonedSvgElement = svgElement[0].cloneNode(true);

                    function download(filename, text) {
                        var element = document.createElement('a');
                        element.setAttribute('href', 'data:text/plain;charset=utf-8,' + encodeURIComponent(text));
                        element.setAttribute('download', filename);
                        element.style.display = 'none';
                        document.body.appendChild(element);
                        element.click();
                        document.body.removeChild(element);
                        }
                        download('mask.svg', clonedSvgElement.outerHTML);
                }
            </script>

Here, when I get the fixed size of the loaded overlay:
<script type="text/javascript">
                function readSingleFile(e) {
                var file = e.target.files[0];
                if (!file) {
                    return;
                }
                var reader = new FileReader();
                        reader.onload = function(e) {
                            var contents = e.target.result;
                            displayContents(contents);
                        };
                    reader.readAsText(file);
                }
                function castString2HTML(str) {
                    let temp = document.createElement('div');
                    temp.innerHTML = str;
                    let htmlObject = temp.firstChild;
                    return htmlObject;
                }
                function displayContents(contents) {
                    var element = document.getElementById('file-content');
                    new_svg = castString2HTML(contents);
                    viewer.clearOverlays();
                    viewer.addOverlay(new_svg);
                }
                document.getElementById('file-input')
                .addEventListener('change', readSingleFile, false);
            </script>

So, You only need the SVG path so next time you load the image, want to load the SVG path too?
You are using addOverlay & clearOverlays which is not related to openseadragon-annotations.
const annotations = new OpenSeadragon.Annotations({ viewer });

using annotations you can use getAnnotations() to get path data and setAnnotations(data) to set annotation data on image load

Thank you for your reply. Exactly, that what I am looking for, saving SVG path and reloading it to the same position and scale.
Well, changing this line:
viewer.addOverlay(new_svg);
to the following seems to solve the issue of scaling a reloaded annotation (SVG path):
new_overlay_width = viewer.source.width;
new_overlay_height = viewer.source.height;
viewer.addOverlay({
        element: new_svg,
        location: viewer.viewport.imageToViewportRectangle( new OpenSeadragon.Rect( 0, 0, new_overlay_width, new_overlay_height) )
        });
}

I will give it a try using getAnnotations() and setAnnotations(data) instead, thank you for suggestion.

Thank you @iangilman . Is there any way to assign a class and a stroke-color to each freehand annotation? Once I do viewer.initializeAnnotations();  The class name and stroke-color and width are automatically fixed.
const annotations = new OpenSeadragon.Annotations({ viewer }); gave me the following error:
Uncaught TypeError: OpenSeadragon.Annotations is not a constructor. I use viewer.initializeAnnotations();  instead if I am not mistaken.

@magednasan I'm not familiar enough with https://github.com/Emigre/openseadragon-annotations to know how much it can be customized or how to call it. You might try filing an issue on that repository. Doesn't look like the owner is really maintaining it, but there may be other people there who know. Also, it doesn't look like there's a lot of code in it, so you might be able to augment it fairly easily by poking around in the code.

Thank you @iangilman, I was able to modify the plugin to meet my needs. The plugin itself exports only three functions: { get, set, clean}. I managed to customized the code to export more, such as: { get_color, set_color, get_mode, set_mode, set_class, get_class} for each <path> in the <svg>.

@magednasan Excellent! You might consider making a pull request with the changes to that project... Even if the owner isn't maintaining it, other people might value the code.


Update Bullet joint properties upon resets

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

15 of 15 (100.0%)  changed or added relevant lines in 2 files are covered.
7 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.06%) to 89.479%

Files with Coverage Reduction
New Missed Lines
%

vulp/actuation/BulletInterface.h
7
73.33%

Totals

Change from base Build<PHONE_NUMBER>:
0.06%

Covered Lines:
1735

Relevant Lines:
1939

💛  - Coveralls


Eventual BG with 1 decimal in the app and in the watch app

Use targetFormatter instead of numberFormater for eventualBG in the app, since this has the appropriate maximumFractionDigits = 1

Change eventualFormatter to use maximumFractionDigits = 1 instead of 2 on the watch

Resolves #319

Eventual BG as presented with this patch:
52,8 mmol/L to the left, 951 mg/dL to the right (random numbers from sim phone/watch/CGM and pump)

@bjornoleh there is a glucoseformatter also in ./FreeAPS/Sources/Modules/Home/View/Header/CurrentGlucoseView.swift which should fit perfectly for this issue

But I suppose my solution is a minimal and acceptable change, isn't it?

Totally!
As per discussion of targets and rounding errors leading to changed targets after multiple unit switches, I suspect that using https://github.com/nightscout/Trio/blob/20ba334b2c3b62ba296e67695bc015c4e5c868d4/FreeAPS/Sources/Modules/Home/View/Header/CurrentGlucoseView.swift#L13 would not lead to these. I think @polscm32 already centralized all formatters in Helpers at one point in some branch, which I guess is something we should also do. It only popped into my mind when viewing this PR as there are some inconsistencies in how rT.variables are handed over from oref to swift. Some are "convert_bg functioned" some always in md/dL - I think I am partly responsible for that and started fixing it, so I stumbled across glucoseformatter just this week.

@mountrcg , perhaps you can write up an issue about this for later?


Connecting to a newer ruby/debug is failing without a clear error message

Using nova-ruby/debug with Nova 11 appears to be broken.
Setup:

chruby as ruby version manager
ruby 3.3.0
Nova 11.9
rdbg 1.9.2

Trying to connect to an open / listening rdbg session receives a The extension “Ruby Debug” experienced an error.
It works when connecting manually via rdbg -a.
I've already tried to use different versions of Nova, it does not appear to be an issue with the Nova version, but with a newer rdbg version?

Update; debugging using the source of this extensions led me to:

it is failing while verifying if there are any open sockets (helpers.js in resolveRubyDebugSocketPath). rdbg is failing with exit code 1, but without any message.

Update:
If I change resolveRubyDebugSocketPath to not use a shell, (i.e. shell: false) it works :O


Display featured jobs on Jobs Page

Feature
Why is this feature being added?

To highlight specific job opportunities for both our community, and potential funders. If we can spotlight specific job opportunities, specifically ones that we can provide a direct reference for, we could help get vets into jobs a bit more easily.
What should your feature do?
We are still scoping this out, so the following requirements are in flux.  @hollomancer @ksmacleod99 @dmarchante please add anything else from recent Slack discussion:
MVP:

Job sponsors can request Job Openings to be posted on a board at https://operationcode.org/jobs - the same page we currently have the ZipRecruiter job search

Job Openings can be requested via email or Slack (contact info should be posted on site somewhere)

Job Openings data can be maintained in static JSON hardcoded in front-end repo (similar to the first iteration of Code Schools / Team Member data)
PeopleOps (@ksmacleod99) or other personnel will coordinate adding/updating/deleting of Job Openings data with our dev team
Front-end React app will display the Job Openings data above the searchable ZipRecruiter job results

[x] Needed: Mockup or minimal wireframe (see comment below)

Post-MVP Ideas:

A form could be created to allow job sponsors to request a new Job Opening be added to our page (possibilities: Google Forms, a form in our front-end app, or something similar to the PyBot form in development for requesting Code Schools by @wimo7083 ).
Back-end will store Job Openings from sponsors, and expose to front-end via API.
Allow admins to perform CRUD actions on Job Openings via Admin Dashboard.
Automate removal of Job Openings after a specific time interval (30 days, for example), so that PeopleOps doesn't have to manually remove them after following up with job sponsors
Integrate this page somehow with Slack #job_board channel

@jjhampton - re:

@hpjaj How difficult would it be to add a table to the DB for 'job postings', so we could perform CRUD actions on sponsored job postings as described above via Admin Dashboard?

Np at all.

What attributes would you be looking for on a JobPosting db table?
Would there be any relationships to any other db tables?

Wondering if that data could be exposed via API to a front-end React component, which could fetch them via http call and then display on our page.

Can you pls expand on this?

@hpjaj re: 'Can you pls expand on this? Do you just mean endpoints that the BE exposes to the FE for the CRUD actions?' - Yes, that's correct. Mainly an API endpoint to GET featured/highlighted Job Openings, so the FE can then display them on the page.  I'm envisioning the other CRUD actions (create, update, delete) could be handled via Admin Dashboard.

@jjhampton - Gotcha. Questions for you:

What attributes would you be looking for on a JobPosting db table?  Here are some ideas.  Additions/removals/changes?

title
source
location
description
status

Would there be any relationships to any other db tables?

@hpjaj Those attributes look pretty good for a minimal set of requirements.
For location, perhaps we could have individual city/ locality / country attributes instead for eventual sorting/filtering/searching? (example: 'Detroit', 'Michigan', 'USA').
Is source the organization which is sponsoring the Job Opening and requesting it to be posted on our board?
We could probably also use a url that would link to an external website of the sponsor where they could list additional details.
I'm thinking that  description could be a "catch-all" attribute that sponsors could use to display any additional info of their choosing, things like compensation, benefits, employment type, job requirements, etc.  If any of those pieces of data seem to repeat themselves, we can move them to a separate attributes later.
re: 'Would there be any relationships to any other db tables?' - not sure about this myself - cc @hollomancer @ksmacleod99

@jjhampton @hollomancer - What is the priority level for this feature set?
If the priority level is low, and since this is not fully teased out yet, it would make sense to hold off on any BE work until the client-side MVP is in place.
If the priority level is higher, they can be done in parallel, and I can create an issue (or update https://github.com/OperationCode/operationcode_backend/issues/363) for a contributor to get started with what we have discussed here.
If the priority level is high, I can do the above, as well as do the work myself.
Thoughts?

My gut reaction is to replicate the data model Ziprecruiter currently has as an MVP. Priority level is a bit higher, as we were discussing getting a design for the client-side MVP started by the end of this week.

np, I'll take care of it myself.  We can always update the db table, if/when needs be.

Self-assigning, I'm going to start work on creating a rough design for this tomorrow night.

Rough draft design - listing out the 'Featured Jobs' above the searchable 'Search All Jobs' area:

looks great to me!

Perfect!

@jjhampton how are we looking on this?

Also @hollomancer is this truly a high priority? @hpjaj have you built out the BE for this?

First entries;
Gitlab
Technical Product Marketing Manager - https://jobs.lever.co/gitlab/022890d6-549a-48fe-8891-51c13b8d1137
Senior Database Engineer - https://jobs.lever.co/gitlab/8b711f1c-d378-4383-a027-bac550aeee6d
Field Marketing Manager - APAC - https://jobs.lever.co/gitlab/f53275a2-bac6-43c8-9a7f-a1d3021c9521

Closed via #985


Feature Request - Code/API documentation tool

Hey I am liking SuperAGI but I want few of my use cases to be full-filled like writing full documentation of the project along with API documentation with HTTP request,response (API contracts) by reading my code from github
But as of now I guess this whole case is not supported would love to see such use cases being to be solved.
This feature could actually make superagi more useful for my use-case.

Hey, we are adding the GitHub tool in the next release which will allow you to interact with your GitHub repos. We already have a coding tool for writing codes and documentations.


Fixing 1 minute shift to timestamps

I thought I fixed this in July, but it seems the fix was not complete. This pull request should truly resolve the 1 minute shift in timestamps when a recording start at the full minute (0 seconds past the minute).
Additionally, I tidied up function R/get_starttime_weekday_meantemp_truncdata.R, which had Europe/London as backup timezone. Elsewhere in GGIR I replaced this by "" (local timezone) previously, but clearly I forgot to do it in this function.

hi @m-patterson , would you mind reviewing this? I thought I fixed this bug in July, but it turned out that I didn't really fix it. So, this pull request should be the real fix. For most of our analyses it doesn't matter too much if there is a 1 minute bias in the timestamp, but it is still nice to have it correct.


Ucob Timelines

Been in Ucob for a couple days now, i noticed that timelines for Twintania phase and Nael phase are pretty much messed up due to dps push, it doesn't count skipped mechanics and goes on with normal timeline even if the party skips mechanics.

This is a duplicate of #1394.  Can you attach a network log there?


Formatting code changes 'default val' and 'override val' to 'member val'

This:
type Entity() =
    abstract Id : int with get, set
    default val Id = 0 with get, set

and this:
type Entity() =
    abstract Id : int with get, set
    override val Id = 0 with get, set

becomes this (and cannot be compiled):
type Entity() =
    abstract Id : int with get, set
    member val Id = 0 with get, set

I think this is a very rarely used language feature though.

Thanks for the bug report. I'll take a look.


Add workflow to run uv lock

Description
Build on top of https://github.com/cookiecutter/cookiecutter-django/pull/5356 to add a uv lock workflow
Checklist:

[ ] I've made sure that tests are updated accordingly (especially if adding or updating a template option)
[ ] I've updated the documentation or confirm that my change doesn't require any updates

Rationale

Opened from work repo


Download the kubeconf file from the created Kubernetes cluster

When we run airy create a new Kubernetes cluster will be created, either on the local machine or in the cloud. We need to download the kubeconf file for the CLI to be able to access the cluster.

this is also part of the issue where we introduce airy create?

Actually no. this is provider dependent based on how we envision airy create to work. The code of this command will dependent on a valid kube.conf so each create provider we write (just invented this name... don't have anything better than "call things what they do") will be responsible for fetching this information and pass it down to the create command.
I will close this issue then as it's redundant (and can't be done separated from the providers)


Phone String

Hi,
Jeff OIAA -
I was under the impression the 'conference URL' had the phone string format  -
PhoneNumber,,ZoomID#,,Passcode#
My laptop can't dial out, but when I use the PHONE button from the site on my phone, it displays all number together without the symbols and doesn't work.
This is how most all 'one touch' dial ins were set up and I followed suit. Is this not correct? If correct, how can it be made to work?
thank you

@mattbylett if you could pull and redeploy this issue should be fixed now ✅

Thanks Josh - will do 👌
We help businesses develop integrated ecommerce digital solutions
Matthew Bylett
Founder Think New Ltd
022 029 2881
On Sun, 13 Oct 2024 at 7:24 AM, Josh Reisner @.***>
wrote:

@mattbylett https://github.com/mattbylett if you could pull and
redeploy this issue should be fixed now ✅
—
Reply to this email directly, view it on GitHub
https://github.com/code4recovery/online-meeting-list/issues/72#issuecomment-2408651579,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHNVISISBI7EOVFRONXQ5HDZ3FSMJAVCNFSM6AAAAABP2UFIEKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBYGY2TCNJXHE
.
You are receiving this because you were mentioned.Message ID:
@.***>

Pulled and deployed - ready for testing

thanks @mattbylett !
@twn2twn let us know if that fixes it or if not what meeting to test it on, thanks

Works for me! thank you both, Jeff B
On Sat, Oct 12, 2024 at 2:36 PM mattbylett @.***> wrote:

Pulled and deployed - ready for testing
—
Reply to this email directly, view it on GitHub
https://github.com/code4recovery/online-meeting-list/issues/72#issuecomment-2408654942,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BGUR4JZ6ABHE7NKGCX7GUEDZ3FT2XAVCNFSM6AAAAABP2UFIEKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBYGY2TIOJUGI
.
You are receiving this because you authored the thread.Message ID:
@.***>