don't use @trusted functions nested in @safe functions

Experience with this has led to the conclusion it is not a good practice.

This should probably specify "non-static @trusted nested functions," since those are the ones that have access to the enclosing scope.

What is this "experience"? Immediately invoked @trusted lambdas are often used to emulate @trusted blocks, which are helpful for writing correct templated trusted code, and have also worked out nicely in Rust.

This should probably specify "non-static @trusted nested functions," since those are the ones that have access to the enclosing scope.

@RazvanN7 this needs to be fixed in order to be technically correct according to non-static nested function behaviour and the rationale presented in this best practice.

@ljmf00 Yes, that is why I did not merge it already.

Where is the DIP for this?

Where is the DIP for this?

I don't think a "Best Practice" need a DIP.

I don't think this suggestion is very well-motivated, though, particularly as it goes against what some others (including myself) would consider best practice for templated code.

I don't think this suggestion is very well-motivated, though, particularly as it goes against what some others (including myself) would consider best practice for templated code.

The growing consensus is that system code should only be done in @system blocks/functions. The idea is to make @trusted have the same safety checking as @safe currently does, and to not allow unsafe operations in @trusted code.

The idea is to make @trusted have the same safety checking as @safe currently does, and to not allow unsafe operations in @trusted code.

Well, that's then definitely a change of a magnitude that should be well-researched and motivated (i.e. go through the DIP process). (If I understand your point correctly, @trusted lambdas are @system blocks!)

The idea is to make @trusted have the same safety checking as @safe currently does, and to not allow unsafe operations in @trusted code.

Well, that's then definitely a change of a magnitude that should be well-researched and motivated (i.e. go through the DIP process). (If I understand your point correctly, @trusted lambdas are @system blocks!)

Yes, and because of that, it is far too easy to whitewash your code with @safe when it is anything but.
This thread provides some additional context<EMAIL_ADDRESS>

There is one place where you do not want to obey this: high-quality templates. There are often cases where you want to do something @trusted, but if you marked the whole function that way it'd also be @trusted when the function uses unsafe member function from types it's instanced with. And trying to design an internal @safe interface for a library like Phobos to avoid the @trusted nested function pattern would like double the code size.
I'm afraid that this advice in the spec would mislead Phobos / Vibe.D / Mir developers. Please be more specific.

Again, the plan is for @trusted to have the same safe-ty checking as @safe.  Meaning - if accepted - doing unsafe things in @trusted code will (eventually) be an error unless explicitly put in  @system.

There is one place where you do not want to obey this: high-quality templates.

Illustration of the problem:
import std.range;

auto right(Range)(Range r)
   if(isInputRange!Range && is(ElementType!Range : int))
{  import core.stdc.stdlib;

   auto ptr = (() @trusted => malloc(10))();
   scope(exit) () @trusted {ptr.free;}();

   int result;
   foreach(e; r)
   {  /+ some calculations using mallocated buffer... +/
   }

   return result;
}

auto wrong(Range)(Range r) @trusted
   if(isInputRange!Range && is(ElementType!Range : int))
{  import core.stdc.stdlib;

   auto ptr = malloc(10);
   scope(exit) ptr.free;

   int result;
   foreach(e; r)
   {  /+ some calculations using mallocated buffer... +/
   }

   return result;
}

struct UnsafeRange
{  private int* ptr;

   ref front(){return *ptr;}
   auto popFront(){ptr++;}
   auto empty(){return *ptr == 0;}
}

@safe void main()
{  int goodThisCompiles = [1,2,3,4].right;
   int goodAlsoCompiles = [1,2,3,4].wrong;

   //int goodDoesNotCompile = UnsafeRange(new int(5)).right;
   int uhOh = UnsafeRange(new int(5)).wrong;
}

Again, the plan is for @trusted to have the same safe-ty checking as @safe. Meaning - if accepted - doing unsafe things in @trusted code will (eventually) be an error unless explicitly put in @system.

Okay, this works, albeit it causes a lot of need to migrate code with relatively little benefit.
But this is not a very public plan yet - It's the first time I even heard of it. Having an advice like the one discussed given on spec is a bit early IMO.

auto right(Range)(Range r)
   if(isInputRange!Range && is(ElementType!Range : int))
{  import core.stdc.stdlib;

   auto ptr = (() @trusted => malloc(10))();
   scope(exit) () @trusted {ptr.free;}();

   int result;
   foreach(e; r)
   {  /+ some calculations using mallocated buffer... +/
   }

   return result;
}

That code is invalid. You're effectively just marking free as @trusted. But free does not have a safe interface, so it cannot be @trusted. It can only be @system. Walter is calling out that kind of @trusted as wrong.
There is obviously a desire (maybe a need) to use @trusted like that, but it's not currently allowed by the language. Which is why people are exploring @system blocks, changing the semantics of @trusted, etc.

There is obviously a desire (maybe a need) to use @trusted like that, but it's not currently allowed by the language.

This is a problem with the language spec, not the code. An immediately-invoked @trusted lambda does not need to have a safe interface in order to be memory-safe at all possible call sites because it only has one call site, and the safety of that single call site can be proven based on local knowledge.
(The same logic applies to all nested functions: since all of their call sites are known at compile time, the memory safety of those call sites can be proven by exhaustion.)

This is a problem with the language spec, not the code. An immediately-invoked @trusted lambda does not need to have a safe interface in order to be memory-safe at all possible call sites because it only has one call site, and the safety of that single call site can be proven based on local knowledge.

That's fine. But someone has to do the work and write that down in the spec (and get it past Walter). Before then, the language doesn't allow it. The rules for @trusted must be solid, not open for interpretation.
Also, I'm not convinced that treating @trusted that way is a good idea. It makes @trusted even more complicated. It adds a gotcha: one cannot simply refactor a nested @trusted function to a free function. Some version of the @system blocks idea can probably provide the feature more cleanly.

Also, I'm not convinced that treating @trusted that way is a good idea. It makes @trusted even more complicated. It adds a gotcha: one cannot simply refactor a nested @trusted function to a free function. Some version of the @system blocks idea can probably provide the feature more cleanly.

You may well be right with regular functions, perhaps even with your average template. But for Phobos, or other such high-quality template libraries, the alternatives are worse:
1: no @safe for the client code even when the code can obviously be.
2: false @trusted
3: Horrible code bloat to design an internal @safe interface. Just consider how much more complicated the example I provided would be that way.

Also, I'm not convinced that treating @trusted that way is a good idea. It makes @trusted even more complicated. It adds a gotcha: one cannot simply refactor a nested @trusted function to a free function. Some version of the @system blocks idea can probably provide the feature more cleanly.

You may well be right with regular functions, perhaps even with your average template. But for Phobos, or other such high-quality template libraries, the alternatives are worse:
1: no @safe for the client code even when the code can obviously be.
2: false @trusted
3: Horrible code bloat to design an internal @safe interface. Just consider how much more complicated the example I provided would be that way.

You forgot the one true alternative even though you quoted it: A new, safer @trusted with @system blocks (or some other iteration of that general idea).
You don't like @trusted as it is in the spec, and for good reason. But if we're going to change it, we might as well do it right.

You forgot the one true alternative even though you quoted it: A new, safer @trusted with @system blocks (or some other iteration of that general idea).
You don't like @trusted as it is in the spec, and for good reason. But if we're going to change it, we might as well do it right.

In the long run I agree. I'd hope for a more backwards-compatible change than the one they're currently planning, but otherwise the system block idea sounds good.
But since it's still just a plan, I think in the short run it's just best to say that the safe interface requirement applies only for non-local symbols. That's how @trusted and @safe are used in practice anyway.
And Walter is backing this PR up with experience, not with spec compliance. This is why I don't want this change to be merged in the present form, at least not before the @system blocks idea has been accepted as a DIP.

But since it's still just a plan, I think in the short run it's just best to say that the safe interface requirement applies only for non-local symbols. That's how @trusted and @safe are used in practice anyway.

I'm afraid that the devil is in the details, and even a quick fix would need significant effort to make any sense. That effort would be better spent on the long run. But I wouldn't mind seeing a spec PR that proves me wrong. If allowing the current usage of @trusted is actually easy, go for it.

And Walter is backing this PR up with experience, not with spec compliance. This is why I don't want this change to be merged in the present form, at least not before the @system blocks idea has been accepted as a DIP.

I think I get what you're saying: This "best practice" is basically telling everyone that they're doing @trusted wrong.  And that's of course not where we want to be.
But as far as I'm concerned, we're already there. The spec already forbids all the nested @trusted functions that don't have safe interfaces. Repeating it as a "best practice" doesn't change anything. All "best practices" are ultimately meaningless.

That's fine. But someone has to do the work and write that down in the spec (and get it past Walter). Before then, the language doesn't allow it. The rules for @trusted must be solid, not open for interpretation.

I agree, and in fact I am working on writing up an alternative formulation of the rules which handles both nested and non-nested functions sensibly. I'll post something on the forums when I have a complete draft ready.

I think I get what you're saying: This "best practice" is basically telling everyone that they're doing @trusted wrong.  And that's of course not where we want to be.

Yes, that is roughly what I meant.

But as far as I'm concerned, we're already there. The spec already forbids all the nested @trusted functions that don't have safe interfaces.

I think you are right about that, unfortunately.

Repeating it as a "best practice" doesn't change anything. All "best practices" are ultimately meaningless.

Hmm. It's rarely bad to advocate for spec compliance in best practices. But it increases the risk that people mark their templates @system with no technical need to do so. And there is no way here for a spec-breaking program to break in future, because Phobos would break also with no realistic migration path.
So as dirty as the conclusion is, the spec must advocate against itself here, not for. Until Paul's changes and/or @system blocks get through of course.


Cannot read property 'time' of undefined

Hi
I have this issue at the moment

This is my workflow

Was an issue from my side

Hi @KateHavrenko - I'm having the same issue. What was your solution?

@pm-pp did you get any news about this?


Explain the possible parameters when webpack.config.js exports a function

This adds a table of possible --env arguments and how they translate into  the env parameter.
It also mentions the second parameter, argv, and gives an example of detecting if -p or --optimize-minimize was given.

@skipjack Thanks for your help, I rebased and updated based on your suggestions, let me know if you'd like me to change anything else.

@skipjack Updated:

Capitalized "Environment Options"
Removed the blank space between list items
Rename the title to "Exporting a Function" and fixed up the link
I also noticed I forgot to surround the environment examples with backticks, so I added those

@jennings thanks! Awesome work on this as well as #1489. If you're interested in contributing regularly, I would be happy to invite you to the organization. I feel like we're finally getting this repo into a good place but there is still a little ways to go with the backlog before we can fully focus on cleaning things up, reviewing the content, and organizing it all properly.
Anyways any time you can spare is definitely appreciated.

@skipjack Thanks :)
I do want to contribute more. I'm not certain yet how much time I can devote to it, but, I can give it a shot. Anything specific you would want me to go after? I saw #1258, it seems like most topics in your checklist have been "claimed".
I'm fairly new to webpack, but I don't mind learning something new in order to improve the docs.

Yeah #1258 is pretty close to completion as you can see in this comment. The ones left are somewhat advanced so I don't know if that would be a good start.
If you could pick up any of the miscellaneous issues though that would be great and feel free to comment on them to discuss direction, e.g. where the new content might go if it's not obvious or just general thoughts on how the issue can be resolved.


How to get inside the virtual machine

Which feature do you think can be improved?
You can enter the container through the crictl exec command. What command should I use if I want to enter the virtual machine?
How can it be improved?
Can enter the virtual machine
Additional Information
Anything else to add?
Before raising this feature request
Have you looked at the limitations document?

https://github.com/kata-containers/documentation/blob/master/Developer-Guide.md#set-up-a-debug-console
initrd images already have a shell, you only need to add agent.debug_console in the kernel cmdline and run socat in the host.

(beat me to it....) Also note @free2k - generally not being able to get into the VM is a security feature, so is not normally enabled by default.

@devimc @grahamwhaley Thank you for your answers. I'm just curious and want to take a look at the virtual machine ~


State Token Too Long

I am thus far unable to integrate with the UltraCart API as I'm getting an error with description;
"The state parameter cannot exceed 250 characters."
Is there a way to make State Tokens shorter and ensure they do not cross the 250 limit?

I tried to replicate the problem, but didn't get an error about the state parameter length. I've published my code as a sample:
https://github.com/gsuitedevs/apps-script-oauth2/blob/master/samples/UltraCart.gs
Are you using a different UltraCart API? (It looks like they have a few).

Thanks for the response @erickoledadevrel
After seeing your code (which is basically the same as mine) I realised the problem is not where I thought. The background is that I'm creating a Google Data Studio connector, and even though it uses this OAuth2 library, it seems that it is using a longer State Token than what the library would generate.
Turns out my code works just fine if I do it directly as in your sample (I did a similar 'run' function in the same project), but fails in Data Studio. Data Studio seems to be creating state tokens in excess of 300 characters!

Is Data Studio generating a completely different redirect URI, or is it still the /usercallback URI but with a longer state token?

The authorization URIs generated have the same parameters, including the redirect uri, except that Data Studio has a longer state token

I'm not sure what Data Studio is doing, but it sounds like the problem lies there and not in this library. Closing for now.


Value overflow on sbiret?

Binary Encoding chapter defines sbiret.value as long.
Extension DBCN functions Console Write and Console Read first parameter num_bytes is unsigned long.
The number of bytes written/read is returned in sbiret.value.
If a value greater than LONG_MAX is used as argument for num_bytes , what is the expected behavior?

Overflow on sbiret.value?
Caller should clamp the argument to LONG_MAX?
Callee should only operate up to LONG_MAX bytes per call?
Caller should consider Binary Encoding's definition of struct sbiret{} only as a general suggestion, but each extension can have an actual different definition of it?
Something else?

I know the question is a bit pedantic, but maybe relevant for other/future extensions where the possible amount of data "worked on" and its reporting may be less forgiving.
I did not check the remaining documentation to see if other such cases exists...

The spec also says
"This is a non-blocking SBI call and it may do partial/no writes if the debug console is not able to accept more bytes."
Thus, the caller is supposed to verify the number of bytes returned and make multiple calls if it doesn't match num_bytes.
That's why #3 is what callee should do.
Cc: @avpatel @jones-drew : We should add this to the kvm-unit-test DBCN test.
I checked the openSBI implementation which allows more than LONG_MAX. So that should be fixed if my understanding above is correct.

The spec also says "This is a non-blocking SBI call and it may do partial/no writes if the debug console is not able to accept more bytes."
Thus, the caller is supposed to verify the number of bytes returned and make multiple calls if it doesn't match num_bytes.
That's why #3 is what callee should do. Cc: @avpatel @jones-drew : We should add this to the kvm-unit-test DBCN test.

Yup, I got Cade to implement the basic write buffer test with a loop on num_bytes. Also, I started writing a couple more tests to see what happens when we cross page boundaries and, for 32-bit, what happens when we use addresses > 4G or cross from under 4G address ranges into 4G address ranges (that found a couple opensbi bugs that I still need to patch)

I checked the openSBI implementation which allows more than LONG_MAX. So that should be fixed if my understanding above is correct.

The spec doesn't say anything about limits on num_bytes, which means up to ULONG_MAX being allowed is implied. So SBI implementations should ensure that base_addr + num_bytes isn't greater than HIGHEST_PHYSICAL_ADDRESS and return INVALID_PARAM if it is.
I'm not sure about #3, I feel like using unsigned long for the parameters at the SBI interface level, just as the ecall uses xlen wide registers, is fine. The expected limits on each parameter should be specified though, allowing SBI implementations to know how to validate the input registers and S-mode to implement wrappers which use appropriate types.

@jones-drew : I am not sure what's your suggestions here. Unless we modify the calling convention, SBI implementation can't return the correct number of bytes read/written via sbiret if it is > LONG_MAX.
We can provide a clarification about the limitation in the spec but don't we still need to fix the current behavior in the implementation to comply with the spec ?

I checked the openSBI implementation which allows more than LONG_MAX. So that should be fixed if my understanding above is correct.

I agree with this interpretation, assuming from the context in your comment that the fix is to write fewer bytes, not return an error.

The spec doesn't say anything about limits on num_bytes, which means up to ULONG_MAX being allowed is implied.

It's allowed for the implementation to accept num_bytes values > LONG_MAX. It is not allowed for the implementation to actually write more bytes than LONG_MAX, because then it would be unable to fulfill the requirement to return number of bytes written. Therefore, if num_bytes is > LONG_MAX, the implementation must write only a portion of the input memory to the console.

I checked the kvmtool and qemu-kvm implementation as well. Both doesn't check the size of the num_bytes and just return whatever bytes written/read (> LONG_MAX). It is unlikely that a caller would invoke that large buffer for a debug console. However, we should fix the behaviors for spec compliance.

Reading the spec again, there are more instances there are more instances of the overflow scenario. E.g. sbi_mpxy_send_message_with/without_response also returns the number the number of bytes written will be returned through sbiret.value.
PMU sbi_pmu_counter_get_info also assumes unsigned long return value but it describes the bitfields explicitly. There shouldn't be any problem with it.
Keeping these in mind and future extensions where similar case arise, @avpatel  suggested to allow unsigned long as return value. The calling convention says
"SBI functions must return a pair of values in a0 and a1, with a0 returning an error code" This will remain true. However, we can change the analogous C structure to something like this
struct sbiret {
long error;
union {
long value;
unsigned long uvalue;
};
};
This will allow backward compatibility as well.

I think we can go further if we want. From reading through the spec again, I don't see any function that wants to return a negative number in spirit.value, but as you mentioned there are several that want to use all XLEN bits for an unsigned value (or a raw CSR value). So we could skip the union and have just unsigned long value;. What is the likelihood that some future SBI function will want to return a negative value?

IMO, I do not think there is any need for -ve values to be returned in sbiret.value. -ve values are usually attributed with error and we have sbiret.error for that. However, changing definition of the sbiret.value from long to unsigned long may indicate breaking ABI (even though the ABI says return values are provided in a0 and a1). The language around the "analogous C structure" is bit ambiguous anyways. That's why, the union option allows it to be backward compatible while providing the necessary clarification for the current and future extensions. @avpatel @jones-drew Wdyt ?

Some future SBI function returning signed sbiret.value is very unlikely but possible. In addition to backward compatibility, the union option is more future proof but we will certainly need to change DBCN and MPXY to use sbiret.uvalue in-place of sbiret.value.

I agree we should continue to allow signed sbiret.value. For example, the FWFT features are given full freedom over their sbiret.value's and, especially when considering platform specific features, it's not possible to know if unsigned values will always be sufficient.

Sounds good. I will send a patch with the union suggestion.


move to Dokku

@rultor release, tag is 0.3.3

@rultor release, tag is 0.3.3

@yegor256 OK, I will release it now. Please check the progress here

@rultor release, tag is 0.3.3

@yegor256 Done! FYI, the full log is here (took me 5min)

Job gh:yegor256/threecopies#21 is not assigned, can't get performer

This job is not in scope


Add SubwordEnd, SubwordStart commands

VSCode by default includes several options for word navigation:
cursorWordLeft
cursorWordRight
cursorWordEndRight
cursorWordEndRightSelect
cursorWordStartLeft
cursorWordStartLeftSelect
etc.

It would be nice to have similar commands in this extension, e.g.
subwordNavigation.cursorSubwordRight
subwordNavigation.cursorSubwordEndRight
subwordNavigation.cursorSubwordEndRightSelect
subwordNavigation.cursorSubwordStartRight
subwordNavigation.cursorSubwordStartRightSelect
etc.

instead of just *SubwordRight, *SubwordLeft.
Hopefully this isn't too difficult to add since the basic navigation is already in place.

Oh wow, I never answered this? In my head I did. Sorry.
So if I read this correctly you'd like the option to be able to choose to skip over whitespace/underscores and in what direction? Rather than how it stops at both sides now?

Hello, is this being looked into by any chance?


Sublime Text 3 hangs with any hx file

Sublime Text 3 hangs when I trying to open any .hx file or executing "Haxe: Choose Build Targed". plugin_host.exe runs haxe --wait 6001 eating CPU and causes editor to become unresponsive. No any info in console.

I've tried ST3 clean installation and portable version, install bundle through Package Control and directly to /Packages from git — the problem still exists.
Sublime Text 3 build 3083 x86 on Windows 7
Haxe 3.1.3
UPD: ST2 also affected

Please try to edit line 991 in HaxeComplete.py:
while prev != f and ( project_folder is None or project_folder in f ):

To:
while False:

Yes, this helps

Thanks, I'll try to fix that line.

Please test.

I'm able to reproduce this on another Windows machine and it's kinda weird :D
Drop large xml somewhere in file path (or just disk root) and you should see something like this:
self.find_hxml("D:\test\Breakout\source")
self.find_nmml("D:\test\Breakout\source")
self.find_yaml("D:\test\Breakout\source")
self.find_hxml("D:\test\Breakout")
self.find_nmml("D:\test\Breakout")

<Found D:\test\Breakout\Project.xml>

self.find_yaml("D:\test\Breakout")
self.find_hxml("D:\test")
self.find_nmml("D:\test")
self.find_yaml("D:\test")
self.find_hxml("D:\")
self.find_nmml("D:\")

<Found D:\large.xml - got stuck parsing it>

Interesting, :D.
@clemos, should we check the size of *.xml files?

Yeah I guess it would be a good idea :/ 100k is probably already huge for a build file....

Long lines in xml files cause this issue.
Added a limit in 200 characters per line.


frontend: improvements of Send component

After #2955
Refactoring the Send component I noticed these as either improvements or required preparation for the refactor. The commits are quite small and I don't think they need to be tested individually, just test HEAD of the PR, I can also squash them all into one "Send component improvements" commit ?
Please review each commit individually.
Putting the result of the proposal request into the state changes the most:
be190c667e638cad6bf975d427be3c8fadcd641a
But it also fixes a bug that exists on master right now, to reproduce:

Type some value X into the amount field. It will show Y in the fiat field.
Deleted some part of the address, to make it invalid.
Type in the amount field again it will show Y' and X'.
Click on send all, now it shows Y but in fiat still X'.

After this commit there will never be any proposedStuff in case the last proposal (and thus partially our current state) is invalid. To prevent this the "send all" checkbox is disabled on address/fee errors. And we fallback on the last typed amount/fiat in case we end up in the state of sendAll = true but proposalResult = undefined.
In case you think we should reset the custom fee I can drop this:
9c6765387c165e122b8248889f82a53908f2cf43
But it will let us remove the handler function later and only pass the state setter when we refactor Send to functional in case we don't reset the custom fee.

(rebased onto #2955)

Is it ready to be reviewed? :) @NicolaLS

Yes, please review the commits individually and ignore the first two as they belong to the other PR. I know this is not great for review (having commits from another PR) but I thought since they are small changes it would be nice if this could be reviewed simultaneously.

rebased on #2955 2955

Ideally, this PR should be a refactoring only and not change the behavior.

But it also fixes a bug that exists on master right now, to reproduce:

The bug fix should be it's own PR.

I cherry-picked some of the commits into PR https://github.com/BitBoxSwiss/bitbox-wallet-app/pull/3091


Mopidy-iris: init at 2.14.3, and related packages

first PR to this repo
Motivation for this change
Adds Mopidy-Iris, a frontend extension for Mopidy. Some packages had to be added/bumped along the way.
I was not sure where to put mopidy-local-images - but decided to place it in the same location as all other mopidy-* packages reside. fetchPypi(not sure which of fetchFromGitHub and fetchPypi is the preferred solution) in the mopidy-iris is used due to the release being un-compiled source(also see jaedb/Iris#39), this eases the process a little bit.
Things done

[ ] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

hmm... 2 builds pass and one fails after 49 min with
The log length has exceeded the limit of 4 MB (this usually means that the test suite is raising the same exception over and over).

The job has been terminated

in the middle of qt compilation. Any way to fix this?

I opened pull requests for all related packages and will rebase once they get merged, maybe this will fix the extra-long travis build. There seem to be a clash in requests version somewhere, though. I does not build on my machine once I change requests2 in spotipy to requests. master build does not allow requests2 to be used, as it's deprecated.

Don't be worried about failing travis-ci build.

@Mic92

any update on this?

Thanks!


Easily switch nodes to use workers

Polish the current worker setup. A subnetwork whose nodes are sent to a worker should be able to only copy/shader an attribute buffer (as opposed to transfer a whole geometry, which can be very slow)

Can you repeat what you're requesting in more detail? What is the problem being solved?
Typically performance feature enhancements need a target goal because workers typically makes code slower.. but can use more of the cpu's threads.

The goal is indeed to improve performance. It could be any of the following situations:

we allow some operations to perform in parallel on multiple CPUs.
we send a long operation to a worker, even if that means it taking longer overall. Freeing the main thread is still benefitial as it can then be used for other unrelated javascript code (for instance, any CSS/UI/vuejs/react update that is not tied to the 3D scene )
we have the full scene running in a worker, maybe with offscreen canvas, and therefore the main thread is free from any webgl work. We would only need to send user events to the worker.

My current thinking is that an easy way for a user to configure which nodes should be sent to a worker would be to wrap them inside a subnet, toggle a parameter useWorker on that subnet, and the node would:

create a worker based on the given nodes
know how to query the inputs from the main thread and send the result back
know if the data that needs to be sent is a full hierarchy of objects, or only a single buffer attribute
know if some data may not be possible to send (for instance a particle system that is on the GPU), and display a relevant error message.

You could then have middle to large scenes have different groups of nodes in different subnets, each using a different CPUs. This would make it easy to use as many thread as possible.
In order to test this, you could create any node tree with a large input geometry. Or you could also test with the sop/attribTransfer node, which can take a long time by itself when both inputs are large geometries, as each point of the first input will check each point of the second input.
And note that my comment above mentions "the current worker setup", but that's is not existing anymore, as I have not worked on it since then. My knowledge of workers being pretty shallow, this would need to be started from scratch.


Shopping list tests

🙋♀ Hello @PabloBona, I'm sending you this PR for your review.
I added a new functionality to the recipe-app that I would like to merge into the dev branch. Thanks in advance for the feedback and improvements 🙇♀🙇♀.
🎯Milestones:
📌 Write unit test for shopping list.
📌 Write integration test for shopping list.
⚠ Additionally I made some changes that consisted of 🚨:
🏁 Fix form bug
🏁 Modify some validations on the models.
🏁 Delete unnecessary view files.
🏁 Delete unnecessary actions from the controllers.
🎖 General Requirements:

No linter errors.
Documented work
Gitflow

All test passed, no stranges characters
@AndreaM2429
You can do the final PR if you want


Connect to OData Service on Cloud Foundry Using SAP Cloud SDK

Tutorial URL: https://developers.sap.com/tutorials/s4sdk-odata-service-cloud-foundry.html
Please specify the step you are referring to step 11 - supply credentials as a file: credentials.yml
Hi gurus,
I am on the verge to conclude this tutorial, however, I´ve got an issue with credentials being provided on a separate file.
The issue is:
"com.sap.cloud.sdk.testutil.TestConfigurationError: Failed to parse property 'test.credentials' with value '/secure/local/path/credentials'. Have you specified an existing file or configuration in either JSON or YAML format?
at com.sap.cloud.sdk.tutorial.BusinessPartnerServletTest.(BusinessPartnerServletTest.java:48)"
I have the file in place: /secure/local/path/, and the file is a valid one (copied and pasted from the tutorial). See next:
credentials - Copy.zip
I googled a bit about this issue, but I could not find any suitable result.
Also, just in case, I am attaching the project.
simpleCFApp - Copy.zip
BR,
Pietro

Hi Pietro,
this might depend a bit on which OS you are using.  Also /secure/local/path/ is just an example/placeholder.
An easy solution is also to just put your credentials file in the root folder of your project. Our testutil logic will look for it there automatically and you can just omit the -Dtest.credentials=/secure/local/path/credentials.yml parameter altogether. But be sure to add it to your .gitignore so that you don't accidentally push sensitive data into your git repository.

Hi @MatKuhr,
The issue has been solved.
By seating the file in root folder, test class issue the following issue:
"No credentials found for alias 'ERP_001'. Make sure to specify credentials in the Java system property 'test.credentials' or in src/test/resources/credentials.yml (alternatively: credentials.yaml, credentials.json):"
By moving the file into the folder suggested, it worked out smoothly.
I thank you for the support.
BR,
Pietro


chore(docs): refactor links to bracket syntax

:tada: This PR is included in version 3.0.0 :tada:
The release is available on:

npm package (@master dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Cannot write video metadata to JSON file

Checklist

[X] I'm asking a question and not reporting a bug/feature request
[X] I've looked through the README
[X] I've read the guidelines for opening an issue
[X] I've searched the bugtracker for similar questions including closed ones

Question
When i try to get url links , this error comes. How to avoid this? Or this can't be handled ? BTW i dont wamt to download video, i need only video urls.
Verbose log
No response

Hello, i get the error logs. It is saying file name too long error. How to skip this error?
:~$ youtube-dl --write-info-json -v --skip-download https://www.youtube.com/watch?v=id
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['--write-info-json', '-v', '--skip-download', 'https://www.youtube.com/watch?v=id']
[debug] Encodings: locale UTF-8, fs utf-8, out utf-8, pref UTF-8
[debug] youtube-dl version 2021.12.17
[debug] Python version 3.8.10 (CPython)
[debug] exe versions: none
[debug] Proxy map: {}
[youtube] id Downloading webpage
[debug] Default format spec: best/bestvideo+bestaudio
[info] Writing video description metadata as JSON to: तेरा मुझसे है पहले का नाता कोई - teraa mujhase hai pahale kaa naataa koii 6_15PM-id.info.json
ERROR: Cannot write metadata to JSON file तेरा मुझसे है पहले का नाता कोई - teraa mujhase hai pahale kaa naataa koii 6_15PM-id.info.json
Traceback (most recent call last):
File "/.local/lib/python3.8/site-packages/youtube_dl/YoutubeDL.py", line 1900, in process_info
write_json_file(self.filter_requested_info(info_dict), infofn)
File "/.local/lib/python3.8/site-packages/youtube_dl/utils.py", line 1829, in write_json_file
tf = tempfile.NamedTemporaryFile(**compat_kwargs(args))
File "/usr/lib/python3.8/tempfile.py", line 679, in NamedTemporaryFile
(fd, name) = _mkstemp_inner(dir, prefix, suffix, flags, output_type)
File "/usr/lib/python3.8/tempfile.py", line 389, in _mkstemp_inner
fd = _os.open(file, flags, 0o600)
OSError: [Errno 36] File name too long: 'तेरा मुझसे है पहले का नाता कोई - teraa mujhase hai pahale kaa naataa koii 6_15PM-id.info.json.3rtfd9i2.tmp'

Use -o to set a smaller filename


remove lgtm tool, since github PRs support this

LGTM

Current coverage is 74.10% (diff: 100%)

Merging #110 into master will increase coverage by 0.17%

@@             master       #110   diff @@
==========================================
  Files            53         53
  Lines          2298       2298
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits           1699       1703     +4
+ Misses          519        515     -4
  Partials         80         80

Powered by Codecov. Last update dcfeffb...129c6ee


Conflict with ckgedit

When markdowku and CKG Edit are both enabled, switching between DW Edit and CKG Edit causes duplication of ordered and unordered list items.
Examples:
- login with your Username and Password
becomes
* - login with your Username and Passwordlogin with your Username and Password
* The VPN Client will sometimes Auto Connect
becomes
* * The VPN Client will sometimes Auto ConnectThe VPN Client will sometimes Auto Connect
A messy workaround for this is to prevent markdowku from lexing unordered list items on the edit page itself. I think this breaks the Preview functionality for unordered list items, but at least doesn't mangle page content.
function connectTo($mode) {
    if($_GET['do']!='edit'){
        ...
    }
}

As I don't use CKG Edit myself (it messes with other syntax extensions, too), I don't know how to address this issue properly. Happy to accept pull requests.


option to disable the initrd

Since I'm using a custom kernel with everything needed to boot compiled in, I'd like to disable the initrd.

Just a tip: such edge case issues normally get resolved only if you submit a PR :)

How do you activate the system without initrd? E.g. symlinking /etc,
setting booted-system, etc.
On Sun, Feb 22, 2015 at 6:54 PM, Carter Charbonneau <
<EMAIL_ADDRESS>wrote:

Since I'm using a custom kernel with everything needed to boot compiled
in, I'd like to disable the initrd.
—
Reply to this email directly or view it on GitHub
https://github.com/NixOS/nixpkgs/issues/6520.

--
NixOS Linux http://nixos.org

Currently initrd generation is already disabled for containers (see system/boot/stage-1.nix). This could be turned into an explicit option.

@fread2281 are you interested in creating a pull request? I can help you implement it if you have any questions.


Update to Node.js 10.2.1

Coverage remained the same at 71.824% when pulling 621c3bad2e164ff6a5f53298c1f28dc8c1de05ef on update/node-10-2-1 into b2043e22a58ed9ee23214728b0a6e63b51e2453f on master.


Fix server name hash maxSize default value

This change is

Coverage decreased (-0.04%) to 46.578% when pulling 4d7a2803719d1e4e4833a880d0bff723e316a29f on aledbf:fix-ServerNameHashMaxSize into d13328b205c8ef504f0ee347b0b578becb7a8726 on kubernetes:master.


Anti message revoke

I've already implemented this, and it has nothing to do with jailbreak
https://github.com/InterestingDarkness/EdgeGPT

Default not is creative.It's balanced.The website also is balanced.
Why free sydney?If you free it,it will going crazy!
Restore the ImageGen.py.
It can't merge to the head.
I'll to try it.

There will be another separate branch in my repo, including anti message
revoke only
2023年5月1日(月) 15:13 VMTask @.***>:

Default not is creative.It's balanced.The website also is balanced.
Why free sydney?If you free it,it will going crazy!
Restore the ImageGen.py.
It can't merge to the head.
I'll to try it.
—
Reply to this email directly, view it on GitHub
https://github.com/acheong08/EdgeGPT/issues/356#issuecomment-1529427884,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A2BC5K52YMXC5SIGWHEFGLDXD5PCVANCNFSM6AAAAAAXRP4PSY
.
You are receiving this because you authored the thread.Message ID:
@.***>

But something can merge to the head.

https://www.bilibili.com/read/cv23006229's Uploader is you?

https://www.bilibili.com/read/cv23006229's Uploader is you?

No, I just want Bing spider to fetch the link


Coin Lockup Transfer Connect/Disconnect Logic

Current dependencies on/for this PR:

feature/coin-lockups

PR #678

PR #679

PR #680

PR #681

PR #682

PR #683   👈

This comment was auto-generated by Graphite.


the document is so confusing on regex query

https://influxdb.com/docs/v0.9/query_language/spec.html

I tried but failed for many times before I searched the issues and found the correct way:
=~ /recommend/
or did I find the wrong document?

Please open issues about the documentation on the docs repo
I've opened an issue for you: https://github.com/influxdb/influxdb.com/issues/313
The document you are looking at is a formal definitions document for the InfluxQL parser. It does not give syntax.


Uncaught TypeError: a.PrePassConfiguration is not a constructor

code: https://codepen.io/wilfrem/pen/zYWpxrB
error summary
When exec new MToonMaterial(), MToonMaterial access not exported member PrePassConfiguration.
how to reproduce

open the codepen.
check console.

:tada: This issue has been resolved in version 4.0.6 :tada:
The release is available on:

GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:


Questions about coordinates axis and pose bounds

Hi, I have some questions about your released code:

In your code, you correct the rotation matrix from up left forward to up right backward, may I know why the 7Scenes dataset coordinate axis looks like this? and why do you need to correct the axis?
https://github.com/ActiveVisionLab/direct-posenet/blob/1dfbe32125878402eda551950867086b1e3010ab/dataset_loaders/load_7Scenes.py#L323
I understand that for the NeRF (LLFF dataset), we need to correct the rotation matrix from OpenGL right up backward to COLMAP OpenCV right down forward.

Why need to correct the axis using M*([R|T]*M)? how to derivate it?
https://github.com/ActiveVisionLab/direct-posenet/blob/1dfbe32125878402eda551950867086b1e3010ab/dataset_loaders/load_7Scenes.py#L331

You set the pose bounds for near=0.5 and far =2.5, may I know why you choose these values? Is this value the same for 7 scenes (heads, stairs, chess, ...)?

Hope for your reply, thank you very much!

Q. 1. & 2.:
Thanks for your question. Since I didn't know which coordinate system 7-Scenes dataset was using, I tried to re-align the 7-Scenes GT poses to the NeRF's myself. The way I did it is to align 7-scenes dataset's coordinate -> colmap coordinates -> NeRF coordinates.
It looks like something like this (Note the camera frustum should also be aligned even though I didn't show it in the picture):

all_poses = flip_M@(all_poses@flip_M) was just a heuristic combination that works correctly for camera position and camera frustum's orientation to training a NeRF model.
Fortunately, we only need to do it once despite being a tedious process to align dataset.
Q.3.:
The near/far bounds were manually selected by estimating the bounds to the camera. As we stated  in the paper, we set 7-scene's near and far bounds [bn, bf] to [0.5, 4] except for the Heads, which was [0.5, 2.5]
I recall there's a paper summarizing the scene's size for 7-Scenes though I don't remember exactly which paper.

Hi @chenusc11, thanks a lot for your detailed reply, but I am still confused about some issues:
To Q1:
From your answer, we know that you align the 7-scenes dataset's coordinates (unkonw) -> colmap coordinates (right, down, forward) -> NeRF coordinates (right, up, backward), which follows operations as below:
(1) all_poses = flip_M @ (all_poses @ flip_M)  # bug here M*([R|T]*M)
(2) dirs = torch.stack([(i - W * .5) / focal, -(j - H * .5) / focal, -torch.ones_like(i)], -1)
While in the NeRF, the author align the llff dataset's coordinates (down, right, backward) -> OpenGL (right, up, backward) -> COLMAP (right, down, forward), which follows operations as below  (refer to nerf_pl) :
(1) poses = np.concatenate([poses[..., 1:2], -poses[..., :1], poses[..., 2:4]], -1)
(2) directions = torch.stack([(i-cx)/fx, -(j-cy)/fy, -torch.ones_like(i)], -1)
Does it mean that your final coordinates are different from NeRF used?
To Q2:
From my naive idea, the flip_M is the rotation matrix used to transfer coordinates x, y, z to x, -y, -z, thus all_poses @ flip_M can simply do it, but why do you use flip_M left multiply all_poses @ flip_M again?

Q1:
I'm not familiar with nerf_pl's implementation since my NeRF was based on the nerf-pytorch repo. This repo was an exact pytorch replicate from the official NeRF, which was in Tensorflow.
I believe my 7-scene's dataset is converted to exactly the same as what the official NeRF/nerf-pytorch is using.
Q2:
Although it's been a long time since I was implementing this, I think this was inspired by mirror matrices. When I was aligning my coordinate system with NeRF's, I found out that I need to take a mirror-like transformation in order to make the camera ray shooting at the correct direction.
In this case, flip_M on the right side is actually flip_M.T
I think it will make more sense if you can draw the camera rays to see what happens before and after the conversion. For example: draw something like this, and see what happens before and after transformation.

Very thanks for your patience and reply again, I recalculate the coordinate transformation and found you are right.


Update 'github-pages.yaml' Workflow - Fix several warnings & enable Caching pip packages

Type of Change

[x] Refactoring
[x] CI/CD improvement

Description
This PR Makes github-pages.yaml Workflow more mountable/readable, also makes git-revision-date-localized-plugin plugin work by pull all commit history (see references for more info), and make github-pages.yaml generate no warnings*.. Except for nodejs warning, which can be resolved by updating actions/setup-python to v5.. but it can't be done at the moment, as it's pinned to use v4 or less, reason behind this version pinning is unclear...
Nonetheless, these changes should make github-pages.yaml workflow cache the results (downloads) of packages specified in the new requirements.txt file, which's a common file used in Python Environments, which specifies every package to install, and what version to use, using PackageName==SpecificVersion Syntax.
Testing
Ran this GitHub Action manually on this PR Branch, and it works as expected.

[!NOTE]
The first run would take much longer then next runs.. as it's compressing & using GitHub's Built-in functionality of Caching between Workflow Runs, more info can be found in references below.

Impact
Won't have a much impact on building/deploying the Docs website.. it'll shave a few seconds here & there, but IMHO it's better than nothing, and lowering Runtime Usage is always a good thing.
Issue related to PR

Resolves #2417

Additional Information (References)

Fetch all history for all tags and branches - actions/checkout
About caching workflow dependencies - GitHub Docs
Caching packages dependencies - actions/python-setup
Python Requirements.txt – How to Create and Pip Install Requirements.txt in Python - freecodecamp.org
How do I remove all packages installed by pip? - StackOverFlow
How to properly disable warnings and set logging to error for every library mkdocs uses? - mkdocs/mkdocs GitHub Discussion

Checklist

[x] My code adheres to the coding and style guidelines of the project.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly in hard-to-understand areas.
[ ] I have made corresponding changes to the documentation.
[x] My changes generate no errors/warnings/merge conflicts.

@ChrisTitusTech


Use Sentry for blueslip.error(), remove server-side ingestion of browser errors.

Self-review checklist

[ ] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[ ] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[ ] Each commit is a coherent idea.
[ ] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[ ] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

I just added a couple doc changes in, looks like while you were mid-review.

My one remaining uncertainty is whether there's anything else related to cross-realm/system bots that needs to be further removed in relation to ERROR_BOT. I think the answer is no; ./scripts/get-django-setting CROSS_REALM_BOT_EMAILS did not contain ERROR_BOT.

Other than the linter error, lgtm modulo @andersk should probably check the webpack configuration change.


Update menu bar icon for Macs with a retina display

It appears that the current menu bar icon for Fanny is rather pixelated, especially when compared to a few other apps I use. If possible, it'd be great to see a high resolution icon in a future version if Fanny. I've attached a screenshot to show the comparison of Fanny to some other apps.

Thanks!

Updated. Thank you for pointing this out.

It appears that Fanny app doesn't work on Mac right now. I've attached a screenshot to show the bug


Add documentation for build java-object

Signed-off-by: Taras Drozdovskyi<EMAIL_ADDRESS>Description
Due to the lack of a description of how to set up the environment for building a java-object, an error arose when building for the android platform. This PR only covers setting up the environment for a successful java-object build.
An example how to edge-orchestration works for the android platform will be prepared later in another branch (due to the complexity of this task).
Type of change

[x] Extending documentation

How Has This Been Tested?
How to test is described in the edge-home-orchestration-go/doc/platforms/x86_64_linux/x86_64_android.md
Example
1. Describe the reproduction procedures freely.
2. Or list up the test description like :
  - [ ] Unittest
  - [ ] Execution of Container
  - [x] Execution on top of Android

Test Configuration:

Firmware version: Ubuntu 16.04, etc.)
Hardware: x86-64
Toolchain: Recommended versions
Edge Orchestration Release: Baobab

Checklist:

[x] My code follows the style guidelines of this project
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings

@tdrozdovsky Build succeeded. Please add the "Co-authored-by<EMAIL_ADDRESS>into your recent commit.

@MoonkiHong I've added the t25kim as co-author.

@MoonkiHong I've added t25kim as co-author.

@tdrozdovsky Please rectify one of the co-authors, which is you.


added support for UsernamePasswordMultiBinding

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests


Bring heterogeneous-hello-world back up to date.

Reintroduced heterogeneous-hello-world into the premake

No longer uses compiled bytecode for entry point, instead a loadModule
call is hardocoded with the slang file name.

Entry point is, similarly, hardcoded for now.

Added a bypass to slang-legalize-types for an unneeded GPUForeach check

You need to run .\premake.bat vs2019 to update the solution/project files.
Please also change the absolute include path to avoid build failures on CI servers.

Can you remove the old experimental/heterogeneous-hello-world or modify premake5.lua to point to experimental/heterogeneous-hello-world instead of example/heterogeneous-hello-world ?


Typo fix in basic-stateful-set.md

Typo fix in basic-stateful-set.md

@mohansethu1983 :wave: any chance you're able to sign the CLA? If there's no response on this PR over the next 7 days, the next reviewer may close the PR.
Let me know if we can help! Thanks!

/check-cla

@mohansethu1983 👋 Please feel free to reopen this PR when you're ready to sign the CLA.
/close


Add refactors and changes to stop breaking windows

Refactor image and font file loader rules into a single loader with a better regex
Refactor reporters in karma config
Change css loader rules. One for app css, one for 3rd party vendor css
Add escaped quotes in linting scripts from package.json to avoid breaking windows

Hi @egervari, Here's all the changed mirrored from the vux repo you mentioned to me. Is there anything else that I missed?

After replacing the AoT loader as indicated and squashing, :shipit:


Handle ecr latest manifest delay

Issue #, if available:
Description of changes:
Add retry around latest/release manifest diff to handle cases where public.ecr has not updated the latest tag manifest immediately.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/lgtm

/approve


Release for symfony 5.2

Hello,
Symfony 5.2.0 released (https://symfony.com/blog/symfony-5-2-0-released), but there is no new release in this repository for it. Do you have plans about release of website-skeleton with new version of symfony?
Thank you in advance.

Released.

Thank you


license & doc & ci improvements

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (main@d266035). Click here to learn what that means.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main       #5   +/-   ##
=======================================
  Coverage        ?   73.14%
=======================================
  Files           ?        5
  Lines           ?      324
  Branches        ?        0
=======================================
  Hits            ?      237
  Misses          ?       87
  Partials        ?        0

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


RDPWrap Improvement Suggestion

Dear @binarymaster,
I would like to give you a improvement suggestion to your already excelent tool RDPWrap.
In order to maintain RDPWrap up to date, I've scheduled a daily Update.bat on all the machines I do support. However, in case of a Windows release upgrade, I'm obliged to TeamViewer each machine in order to reinstall RDPWrap.
To solve this, I suggest you to fire the Install function in case one Update fail because RDPWrap is not installed. Let say, if I started an RPDWrap Update, this mean I expect RDPWrap is already installed.
Take a look at RDPWInst.dpr, lines 1217-1218.
I hope to be contributing with you to make RDPWrap even better.
Kind regards

I think this could be done by just modifying update.bat to run RDPWInst -i -o right after RDPWInst -w.
If wrapper is installed, it would run update. If not, update will fail, but installation would start.

Thanks for your attention.
Regards.


Preformatting data before conversion

          Hi, sorry if this is not the right place to ask my question, but it seems that the issue title fits with my case.

I must read a CSV exported from MySQL and it seems that there are strange "\N" string values in some columns that I suspect that are representing null reference values.
My problem is that when I try to use the CastToInt isn't working because I don't know how to pre-transform this "\N" into a nullable integer.
// my DTO class
#[MapCell(column: 1, cast: CastToInt::class)]
private ?int $museumLegacyId;

[ERROR] Unable to cast the given data \N to a int.
Originally posted by @davidromani in https://github.com/thephpleague/csv/issues/237#issuecomment-1853616552

@davidromani a Reader::addFormatter method was introduced in a recent minor version. You can use that function to formatter your records before accessing. Which gives you the opportunity to convert your \N in a proper null value.

There are many ways to make it more simple but I wanted to make it readable.
$formatNull = function (array $record) : array {
   $res = [];
   foreach ($records as $offset => $value) {
       if ($value === "\N" {
            $value = null;
       }
       $res[$offset] = $value;
   }

   return $res;
};

$reader->addFormatter($formatNull);

Then you can continue whatever you were doing.


Create FSM for Plate docking task

Implement FSM for TAC Plate docking task.

First draft is finished, not been able to test anything yet.


Add libboost-filesystem-dev

debian: https://packages.debian.org/stretch/libboost-filesystem-dev
fedora:https://apps.fedoraproject.org/packages/boost-filesystem
ubuntu:https://packages.ubuntu.com/bionic/libboost-filesystem-dev

For gentoo this is probably: https://packages.gentoo.org/packages/dev-libs/boost; but to be compatible with the regular boost key (https://github.com/ros/rosdistro/blob/master/rosdep/base.yaml#L292), this should probably be dev-libs/boost[python]


[Request - Product] Meilisearch

Full and short name of product
Meilisearch
A lightning-fast search engine that fits effortlessly into your apps, websites, and workflow.
Does this product have LTS versions? What are the intervals between each LTS version?
No, it is still below 1.0
What is the website for the product and for its version information?
https://github.com/meilisearch/meilisearch
https://www.meilisearch.com/

I found the version docs at https://www.meilisearch.com/docs/learn/update_and_migration/versioning

Meilisearch only maintains the latest engine release. Currently, there are no EOL (End of Life) or LTS (Long-Term Support) policies.

Automation can be done from GitHub Releases at https://github.com/meilisearch/meilisearch/releases

Considered stable with the v1 release in February: https://blog.meilisearch.com/v1-enterprise-ready-stable/


rvm do ruby --version was removed

If I run the rvm:check or deploy:check tasks I get the following failed output:
#> cap staging deploy:check
DEBUG [7dcfdae8] Running /usr/local/rvm/bin/rvm version as <server>
DEBUG [7dcfdae8] Command: /usr/local/rvm/bin/rvm version
DEBUG [7dcfdae8]    rvm 1.27.0 (latest) by Wayne E. Seguin<EMAIL_ADDRESS>Michal Papis<EMAIL_ADDRESS>[https://rvm.io/]
DEBUG [7dcfdae8]
DEBUG [7dcfdae8] Finished in 3.330 seconds with exit status 0 (successful).
rvm 1.27.0 (latest) by Wayne E. Seguin<EMAIL_ADDRESS>Michal Papis<EMAIL_ADDRESS>[https://rvm.io/]
DEBUG [a09777ec] Running /usr/local/rvm/bin/rvm current as <server>
DEBUG [a09777ec] Command: /usr/local/rvm/bin/rvm current
DEBUG [a09777ec]    system
DEBUG [a09777ec] Finished in 0.599 seconds with exit status 0 (successful).
system
DEBUG [2174bae7] Running /usr/local/rvm/bin/rvm  do ruby --version as <server>
DEBUG [2174bae7] Command: /usr/local/rvm/bin/rvm  do ruby --version
DEBUG [2174bae7]    `rvm do ruby --version` was removed, use `rvm 1.9.2,1.9.3 do ruby --version` or `rvm all do ruby --version` instead.
(Backtrace restricted to imported tasks)
cap aborted!
SSHKit::Runner::ExecuteError: Exception while executing as <server>: ruby exit status: 1
ruby stdout: `rvm do ruby --version` was removed, use `rvm 1.9.2,1.9.3 do ruby --version` or `rvm all do ruby --version` instead.
ruby stderr: Nothing written

SSHKit::Command::Failed: ruby exit status: 1
ruby stdout: `rvm do ruby --version` was removed, use `rvm 1.9.2,1.9.3 do ruby --version` or `rvm all do ruby --version` instead.
ruby stderr: Nothing written

Tasks: TOP => rvm:check

@foomip did you find a solution?

@foomip did you got any solution?

@foomip  did you got any solution?


Question: Normalize fastq files separately or merge?

Hi! I want to assemble a transcriptome and have RNASeq data from multiple individuals and tissues. Would you recommend to run ORNA on a single fastq file pair, where I merge all fastq files into one, or on each individual/tissue separately? I would think the former to reduce the dataset the most?

Hi,
it depends a bit on what you want to do. Do you want to compare the expression of assembled transcripts between individuals and tissues? If yes, I would recommend to run ORNA on all the data (by merging into one fast as you suggest) and produce one large joined assembly. This would simplify the expression/detection comparison later. For this I would recommend to use the quality based sorting mode that we introduced with ORNA-q ( a parameter to use with ORNA), because you will have a lot of good-quality reads that you want to prioritise to get a good assembly (see our latest paper in Scientific reports).
Definitely, if you merge all datasets into one fastq it will reduce the most, in terms of absolute space and you are likely to pick up more lowly expressed transcripts from individual datasets.
Hope that helps,
Marcel

Thanks! I'll merge the files then.


Private Repositories

I am missing the possibility to check private GitHub repositories on goreportcard.com. Am I not seeing something or does it just not work (yet)?

@zwerch unfortunately this isn't available right now. @hermanschaaf and I have discussed it before, but we've put it off for a few reasons:

It's probably going to take us a while to build
Security implications (we go get repos right now, which stores them on disk. We'd want to be extra careful about private repos)
We don't know how many people want it. You count of course, and maybe 2 or 3 other people have asked us for it

We'll leave this open for others to comment on if it's something they want, and if enough people request it we'll probably end up building it.
Thanks!

I have similar requirements ,but not for the private GitHub repositories. We want to run goreportcard in our local network , and check repos from private git server (like gitlab or phabricator) , the question is , if we want to go get the repo , we need enter the username and password

@wangkirin ah, that is an interesting use case, thanks for bringing that up. I wonder if we could sort that out with setting a username/pw as environment variables or something like that?

@shawnps
Yes, that's what I mean.: )

Concerning the username/password stuff, doesn't GitLab or whatever other platform deployed locally have something similar to Github's deploy keys?  If you configure them on your server go get will work flawlessly, right? Or am I missing something? Clear text password doesn't seem like a secure option to me.

Running my own instance of goreportcard to check private repos is something I'm interested in.

Also using private repositories. In order to use go get on them we've used git config --global url."git@private.local:".insteadOf "https://private.local/", which lets go get use the deploy keys we set up. This is on a gitlab repository. Could there be some project level configuration that is overwriting the global?
Obviously interested in private repos as well.

@shawnps Any update on this issue?

Hi @franzwilhelm and anyone else interested in this,
From the thumbs up reactions on @Nalum's comment it looks like quite a few people are interested in running their own instance of GRC to check private repos. I'll start to think about it. There are a few things I imagine I'll need to consider:

GitHub Enterprise support
Non-GitHub private repos like @Archosian mentioned
Probably most common: go get private GitHub repo

On top of this we might be able to offer the ability to check private repos on goreportcard.com for people who don't want to run their own instance internally.
The first thing I'll probably try to do is the ability for people to run their own instance, and check private GitHub repos.

I was able to use this locally on my private repos. Setting the insteadof git config did the trick. Haven't tested a remote setup yet, but I assume that with a valid deploy key will work.
I tested it with GitLab.com private repos.

@nalum did you manage to make it work with a remote private repo?

I haven't had time to check. As soon as I do I'll let you know.

Any updates on this? I'd love to see that feature for gerrit and gitlab.

I tested the method @Archosian mentioned. Its working.  :smile:
I am thinking about adding an oAuth module infornt of this tool, which will enable my gitlab or other private repo users to access tool and yet the tool is not open source. Any suggestions?

The following Dockerfile will let you run against a private gitlab with a self signed certificate:
`FROM golang:1.8-alpine
SSH key for getting code
ARG SSH_KEY
hostname for internal github/gitlab server
ARG GIT_HOST
most of this is verbatim from the project.  openssl is added
RUN apk update && apk upgrade && apk add --no-cache git make openssl openssh
trust repo's self signed cert
RUN echo | openssl s_client -showcerts -servername $GIT_HOST -connect $GIT_HOST:443 2>&1 | sed -ne '/BEGIN\ CERTIFICATE/,/END\ CERTIFICATE/ p' > /usr/local/share/ca-certificates/$GIT_HOST.pem && update-ca-certificates
stage ssh key and accept repos's host key
RUN mkdir -p /root/.ssh && chmod 700 /root/.ssh && echo "$SSH_KEY" > /root/.ssh/id_rsa && chmod 600 /root/.ssh/id_rsa && ssh-keyscan -H $GIT_HOST > /root/.ssh/known_hosts
configure git to use ssh over https
RUN git config --global url.git@$GIT_HOST:.insteadOf https://$GIT_HOST/
Install app dependencies
RUN go get github.com/gojp/goreportcard && go get golang.org/x/tools/go/vcs
RUN /go/src/github.com/gojp/goreportcard/scripts/make-install.sh
WORKDIR $GOPATH/src/github.com/gojp/goreportcard
EXPOSE 8000
CMD ["make", "start"]`
Build with: docker build --build-arg SSH_KEY="$SSH_KEY" --build-arg GIT_HOST=<your git host> .
It's basically just the goreportcard dockerfile rearranged and with the key and git config stuff added.

#134 can be a viable workaround for most use cases here.

If you don't need self signed certs or self hosted GitHub and don't want to bake SSH into the container, my solution was some quick modification to the Dockerfile:
RUN apk update && apk upgrade && apk add --no-cache git make openssh \
        && go get golang.org/x/tools/go/vcs \
        && ./scripts/make-install.sh \
        && git config --global url."git@github.com:".insteadOf<EMAIL_ADDRESS>\
        && mkdir /root/.ssh && echo "StrictHostKeyChecking no " > /root/.ssh/config

Then run with a passwordless SSH key mounted into the container at runtime: -v $(HOME)/.ssh/id_goreportcard_rsa:/root/.ssh/id_rsa.
Another, more long term alternative would be to replace Git command line calls with src-d/go-git and provide configuration for either basic auth or SSH via environment variables.

We used self-hosted Gitlab, I think at least for self-hosted Gitlab, you needn't care about ssh key or certs at all. The runner itself will automatically do that for you.
My question is, is there an official docker image on dockerhub.com? At least I didn't find it. That will be all I need to run goreportcard for our private repo.

For the folks on GitLab, another option is to run goreportcard in CI, something like:
goreportcard:
  before_script:
  # Or build a custom docker image
   - curl -L https://git.io/vp6lP | sh
   - go get github.com/gojp/goreportcard/cmd/goreportcard-cli
  script:
   - goreportcard-cli -t 90

In the productiongo book is stated:
" You can try it on
goreportcard.com if your source code is open source, or run the server locally to make use of the
tool on your internal network or private repositories."
How ist that possible.
I don't have gitlab, I have a simple git project?

Hi @idefixcert,
It's possible to use the CLI on your git project:
https://github.com/gojp/goreportcard#command-line-interface

Has there been any further progress on something like a GRC docker container which can access a private Gitlab (or other) repo, so that you can set up links to the self-hosted reports in a browser?


Feature/nwps-upgrade-14-7-2

Hi - config / readme updated for  upgrade to 14.7.2.

Hi @Raq-HEE - Thanks for the PR, it looks good, approved 👍
Made another commit 741ef7265f8918a83c7ff65e27db4e39f4be0040 which removes <log4j2.version>2.16.0</log4j2.version> override as it has already been inherited from the parent pom (com.onehippo.cms7:hippo-cms7-enterprise-release:14.7.2) and will ensure we inherit the latest log4j versions released by the brXM release going forward. Thanks!


Error:unexpected character '\n' after patch version number

I encountered the same issue as in #19.
When running a test, I get the message:
typst-test ran into an unexpected error, this is most likely a bug
Please consider reporting this at https://github.com/tingerrr/typst-test/issues/new
    Error:unexpected character '\n' after patch version number

Here is what I did:
cargo install typst-test --git https://github.com/tingerrr/typst-test
typst-test init
typst-test add test-1
typst-test run test1

The installation command gives the following warning:
   Compiling typst-test v0.1.0 (/Users/xxx/.cargo/git/checkouts/typst-test-af24935a6e1ceb4c/97b1839/crates/typst-test)
warning: variants `RootNotFound` and `InitNeeded` are never constructed
   --> crates/typst-test/src/project/mod.rs:398:5
    |
396 | pub enum Error {
    |          ----- variants in this enum
397 |     #[error("project not found: {0:?}")]
398 |     RootNotFound(PathBuf),
    |     ^^^^^^^^^^^^
...
404 |     InitNeeded,
    |     ^^^^^^^^^^
    |
    = note: `Error` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
    = note: `#[warn(dead_code)]` on by default

warning: `typst-test` (bin "typst-test") generated 1 warning

I ran the commands in several of my packages and even downloaded some other packages and always got the same error message.
I tried the ci-semi-stabel branch with no luck. The ci-semi-stable tag works for me, though.

The warnings are unrelated, they're there because those errors are not used in release mode, there are more checks in debug mode where they are used.
As stated in #19, I can't reproduce the issue, @keyneston, could you tell me if you're on macOS too? I'm testing on Linux, perhaps it is platform specific.
I don't know how this could happen though, this would imply that on macOS, somehow at the time semver::Version::parse is called, there's spurious newline at the end of its input.

It would be great if you could try running a debug version with RUST_BACKTRACE=full, because I can't really follow the error path through reasoning alone, it seems.

I get this:
           Stack backtrace:
              0: std::backtrace::Backtrace::create
              1: std::backtrace::Backtrace::capture
              2: anyhow::error::<impl core::convert::From<E> for anyhow::Error>::from
              3: typst_test::util::command::parse_stdout
              4: typst_test::cmd::run_tests
              5: typst_test::cmd::run
              6: typst_test::main_impl
              7: typst_test::main
              8: std::sys_common::backtrace::__rust_begin_short_backtrace
              9: std::rt::lang_start::{{closure}}
             10: std::panicking::try
             11: std::rt::lang_start_internal
             12: _main
``

I dont know rust, but from looking through the code, code the problem be a call to typst --version to get the Typst version here? The output on my machine is
typst 0.11.1

There is a newline at the end. I think this is added by the Fish shell I'm using. Maybe trimming whitespace before parsing the version number would do the trick?

The stack trace explains it, I'll see to fixing it soon when I'm back home. Thanks!


Admin Role needed to see the device license?

Hello,
What admin role is needed to see the device license.
License admin is not enough. I can only see them with global admin.
Thx
[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: e52eb9c1-1755-bec5-4ad8-6df59779e041
Version Independent ID: 10e4cf5d-ea61-806e-f226-1e14265eabe1
Content: Device-based licensing for Microsoft 365 Apps for enterprise - Deploy Office
Content Source: DeployOffice/device-based-licensing.md
Service: o365-proplus-itpro
GitHub Login: @nicholasswhite
Microsoft Alias: nwhite

@MJP-MSFT   Can you help with this? Thanks.

@herwigkeirsebilck You can also try Office Apps Admin Role or Security Admin. The Apps Admin Center(config.office.com) is enabled for Global Reader, Office Apps Admin, Security Admin, and Global Admin


move fulfill logic to condition, instead of the fulfillment

As an introduction, here is my own original paragraph that was the source of inspiration for this ticket, as written in #293:

Imagine bob soft-forks Rivine and adds a new fulfillment version, unknown to others, which can fulfill any condition without doing anything, this allows Bob to take all UTXO of the entire network, for other nodes this is not an issue as they see this new fulfillment version as unknown, and thus fulfill it by default as well, this could be fixed with a giant future fork, but it has major consequences. Basically, currently the smart-wallets branch code allows anyone at any time to hijack a free fulfill version. Big security flaw in my design!

Here is the gist of it. Fulfillments currently have a fulfill logic, and thus they decide how they fulfill a certain condition. It seemed questionable to me from the beginning, even though I designed and implemented it, but never questioned it enough. However, it is clearly the opposite world. A condition states the conditions requires in order to spend an output, and thus it follows that it should have the fulfill method, as to be able to dictate how to fulfill it. Having this now as part of the Fulfillment interface instead is a joke!

This is by the way not a new security issue, fulfillments used to be called InputLocks, and they also were the ones deciding how to fulfill, not the unlock hashes, thus this issue has always been there ever since we allow fulfillment soft-forks.


Add timeline of changes element

What
Add a timeline of recent changes to the landing page to communicate to users what rules are changing or have recently changed, and what they need to do differently from what date.
Why
We know that users are struggling to find out what has recently changed, and this impacts how likely they are to follow the rules, and how confident they feel that the landing page is up to date and relevant.
We hope that this timeline element will help users:

understand what's changed
feel confident that the information is up to date
ultimately comply with new rules and help prevent the spread of covid

https://trello.com/c/XUyYJ8lt/813-24-sept-landing-page-add-timeline-of-changes-element

Will need content sign off by @helengds before we merge

@leenagupte - thanks for the review - I've addressed the things you raised

Reminder to not merge this until @helengds has signed off


Add webp support to texture loader

Objective

This PR adds webp image format support to TextureLoader behind an optional feature webp

Solution

Since webp support in image crate is very limited (e.g. lack of ALPH support), it uses FFI bindings to libwebp instead.

I think there are places where we document our features
We need to do this for this one (we should also mention that it uses native libraries, so will be more difficult to build for someone)

Didn't find an easy answer with a quick read, is the link to libwebp static or dynamic?

if dynamic, it will need player to have libwebp built on their system for this feature
if static, released Bevy game with this feature will need to include https://chromium.googlesource.com/webm/libwebp/+/refs/heads/main/COPYING which is not obvious or easy to find

@mockersf It's statically linked, regarding license, could you please point me to where I should put up a notice, code doc or feature doc?

we don't have a good place yet for that, I guess for now mentioning this in #1885 when it gets merged should be enough

So, this PR is stale ... but here is what could happen given the status in current bevy.
From looking at the source code, I see that we are enumerating WebP (incl many others) in enum ImageFormat: https://github.com/bevyengine/bevy/blob/main/crates/bevy_render/src/texture/image.rs#L31
However, there is no actual asset loader enablement for it (and a few of the other formats listed there btw).
It is lacking here: https://github.com/bevyengine/bevy/blob/main/crates/bevy_render/src/texture/image_texture_loader.rs#L20
and here: https://github.com/bevyengine/bevy/blob/main/crates/bevy_render/src/texture/mod.rs#L39
For anyone wanting to pick this up, you could look at the places linked above, as well as the code that was in this PR, for reference. It seems like it should be relatively straighforward to bring this up to date to current bevy.

This has been superceded by #8220.


Remove minAllowed.cpu for all components

What this PR does / why we need it:
Remove all minAllowed.cpu values from VPA objects. Our tests didn't show harmful side effects of removing these and in many cases VPA did recommend values lower than the minAllowed. Therefore, we start saving resources if we switch to the VPA recommendation for CPU.
We don't do this for memory, as it is not compressible and would lead to more/faster OOMKills.
Release note:

Removed `minAllowed.cpu` from all VPA objects

Can you please rerun make generate

Can you please rerun make generate

done, thanks for the ping!


ARROW-15210: [Python] Pyarrow compute functions convert args with __arrow_array__.

LGTM! Thanks for fixing this @coady!

@coady Can you rebase this on git master to fix CI failures?

@jorisvandenbossche @coady Does one of you want to move this PR forward?

Closing because it has been untouched for a while, in case it's still relevant feel free to reopen and move it forward 👍


Struggling with mapping readonly ICollection property

Discussed in https://github.com/MapsterMapper/Mapster/discussions/688

Originally posted by akordowski March 24, 2024
Hi everyone!
I am currently struggling with the mapping of a readonly ICollection property. I followed the instructions but I can't make it work. The readonly collection is not populated with the mapped content. What am I making wrong? Have anyone an idea how I can make it work?
Here the code:
Programm.cs
var config = TypeAdapterConfig.GlobalSettings;
config.Scan(typeof(ChannelMapping).Assembly);
config.Default.UseDestinationValue(m => m.SetterModifier == AccessModifier.None &&
                                        m.Type.IsGenericType &&
                                        m.Type.GetGenericTypeDefinition() == typeof(ICollection<>));

var channelSrc = new MapsterTest.Objects.Source.Channel
{
    ChannelId = "123",
    Thumbnails = new MapsterTest.Objects.Source.ThumbnailDetails
    {
        Default = new MapsterTest.Objects.Source.Thumbnail
        {
            Url = "https://www.youtube.com/default.jpg"
        },
        Medium = new MapsterTest.Objects.Source.Thumbnail
        {
            Url = "https://www.youtube.com/medium.jpg"
        },
        High = new MapsterTest.Objects.Source.Thumbnail
        {
            Url = "https://www.youtube.com/high.jpg"
        }
    }
};

// Thumbnails are mapped correctly to a collection
var thumbnailsDest = channelSrc.Thumbnails.Adapt<ICollection<MapsterTest.Objects.Destination.Thumbnail>>().ToList();

// channelDest.Thumbnails collection is empty
var channelDest = channelSrc.Adapt<MapsterTest.Objects.Destination.Channel>();

ThumbnailMapping.cs
public class ThumbnailMapping : IRegister
{
    public void Register(TypeAdapterConfig config)
    {
        config.ForType<Objects.Source.ThumbnailDetails, ICollection<Objects.Destination.Thumbnail>>()
            .MapWith(src => MapThumbnailDetails(src).ToList());
    }

    private static IEnumerable<Objects.Destination.Thumbnail> MapThumbnailDetails(Objects.Source.ThumbnailDetails thumbnailDetails)
    {
        yield return MapThumbnail(thumbnailDetails.Default, "Default");
        yield return MapThumbnail(thumbnailDetails.Medium, "Medium");
        yield return MapThumbnail(thumbnailDetails.High, "High");
    }

    private static Objects.Destination.Thumbnail MapThumbnail(
        Objects.Source.Thumbnail thumbnail,
        string thumbnailType) =>
        new()
        {
            Type = thumbnailType,
            Url = thumbnail.Url.Trim(),
        };
}

Channel.cs (Destination)
public class Channel
{
    public string ChannelId { get; set; } = default!;
    public ICollection<Thumbnail> Thumbnails { get; } = new List<Thumbnail>();
}

Thumbnail.cs (Destination)
public class Thumbnail
{
    public string Type { get; set; } = default!;
    public string Url { get; set; } = default!;
}

Channel.cs (Source)
public class Channel
{
    public string ChannelId { get; set; } = default!;
    public ThumbnailDetails Thumbnails { get; set; } = default!;
}

ThumbnailDetails.cs (Source)
public class ThumbnailDetails
{
    public Thumbnail? Default { get; set; }
    public Thumbnail? Medium { get; set; }
    public Thumbnail? High { get; set; }
}

Thumbnail.cs (Source)
public class Thumbnail
{
    public string Url { get; set; } = default!;
}

@akordowski I have the same issue. Did you ever find a solution?
This project is starting to look abandoned — no commits since September 2023, and no release since then. And issues opened are not answered... Is it time to move on to a different mapper?

This is how I solved the problem. It's far from being an optimal solution but it works. It was a special case, but it might give you an idea. Hope it helps you.
public class SrcClassMapping : IRegister
{
    public void Register(TypeAdapterConfig config)
    {
        config
            .ForType<DestClass, ICollection<SrcClass>>()
            .MapWith(src => MapCollection(src, null))
            .MapToTargetWith((src, dest) => MapCollection(src, dest));
    }

    private static ICollection<SrcClass> MapCollection(
        DestClass? destObj,
        ICollection<SrcClass>? srcCollection)
    {
        srcCollection ??= new List<SrcClass>();

        if (destObj is null)
            return srcCollection;

        // Custom mapping

        return srcCollection;
    }
}

@akordowski Great, thanks! Will give it a try


Pin 'protobuf==3.0.0-alpha-1'.

Works around https://github.com/google/protobuf/issues/333.

Changes Unknown when pulling c39a34e1767a285bf37150a1233565f0aa49b84b on tseaver:pin-protobuf-3.0.0-alpha-1 into ** on GoogleCloudPlatform:master**.

@dhermes I'd like to merge this ASAP, and then rebase the other PR branches which broke due to protobuf-3.0.0-alpha1

LGTM

FYI @jgeewax @dhermes: Until https://github.com/google/protobuf/issues/333 is fixed (with a release to PyPI), other open PRs are going to need to rebase on this change if they get new changes.


Bug fix setting ec2 User. Extend Identity type

Fixes a bug where setting User in .ssh/config wasn't working.
Also extends the Identity type in transport/ssh.go. Currently, when using 'wash exec' on an ec2 instance, the hostname is derived automatically because it can be fetched from the instance metadata. Similarly, with these changes, the user often isn't required to define IdentityFile or User in ~/.ssh/config. The new fields in the Identity type are:

IdentityFile. The ssh key name is fetched from metadata and appended to make an educated guess that the user's private key is ~/.ssh/keyname.pem

FallbackUser, currently hardcoded to be the default user for Amazon Linux AMI instances, "ec2-user". (A further enhancement is planned to scrape the default user name from console output -- eg "centos" or "ubuntu" -- and use that for FallbackUser.)

Signed-off-by: Eric Boutilier<EMAIL_ADDRESS>Contributions to this project require sign-off consistent with the Developers Certificate of Origin. This can be as simple as using git commit -s on each commit.

Thanks for putting this together!


Add a reference to a Hive

Allows for a Runner to associate a device with a Hive

I'd rather we modeled this association a bit more flexibly. i.e. with an association table.


fixes typo in line 1769, changes "bracket" to "brackets"

Pre-Submission Checklist

[x] Your pull request targets the staging branch of FreeCodeCamp.
[ ] Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
[x] You have only one commit (if not, squash them into one commit).
[ ] All new and existing tests pass the command npm run test-challenges. Use git commit --amend to amend any fixes.

Type of Change

[x] Small bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds new functionality)
[ ] Breaking change (fix or feature that would change existing functionality)
[ ] Add new translation (feature adding new translations)

Checklist:

[ ] Tested changes locally.
[x] Closes currently open issue (replace XXXX with an issue no): Closes #XXXX

Description

@LeeWarnock, unfortunately 2 pull requests were created at the same time. The other pull request author (@sergroja) already asked if he could fix that issue. I will have to accept his insead, sorry about that :disappointed:

thanks @atjonathan for the explanation. I'll just have to be quicker next time.

@LeeWarnock, no worries man, sorry about that :sob:

lol, making me laugh @atjonathan, I'm happy to be a part of this community! Are pull requests the only way to become a member?

@LeeWarnock, you mean a core team member of freecodecamp? You would need to talk to @BerkeleyTrue about that. Active contributing and helping out in chat rooms, repo, and other freecodecamp related projects are all factors.


ActiveSupport 5.0 breaks fastlane installation

Because it requires a Ruby version that is not shipped with OS X.
Fixes #5294

Changes Unknown when pulling 7ce4fbca14d1bd6463cd0e7a5f3cb7cdc6af08e3 on fcy:fcy/fix-installation into ** on fastlane:master**.

Thanks for the PR, however this doesn't actually fix the underlying issue, since this is the development dependency. Instead we'll patch the XcodeProj gem to lock the version 👍


[ZEPPELIN-3065] Personalized mode does not allow multiple users to run the same paragraph at the same time

What is this PR for?
In personalized mode, if user A is running a paragraph and user B starts running the paragraph before user A's run has completed then user A's paragraph will remain stuck in the "running" state. Furthermore, all messages from user B's run be appended to the output for user A.
What type of PR is it?
Bug Fix
Todos

[ ] - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/ZEPPELIN-3065

How should this be tested?

Simultaneously run same paragraph using two separate users in both personalized mode. Both users should get the results.
CI passed:
https://travis-ci.org/srehmann/zeppelin/builds/566330819

Screenshots (if appropriate)
Questions:

Does the licenses files need update? No
Is there breaking changes for older versions? No
Does this needs documentation? No

@srehmann , Thank you for your contribution. :-)
Please change

What is this PR for?
[ZEPPELIN-3065] Personalized mode does not allow multiple users to run the same paragraph at the same time

to description in https://issues.apache.org/jira/browse/ZEPPELIN-3065
E.g,

What is this PR for?
In personalized mode, if user A is running a paragraph and user B starts running the paragraph before user A's run has completed then user A's paragraph will remain stuck in the "running" state. Furthermore, all messages from user B's run be appended to the output for user A.

Description updated :)

@srehmann , You need to go to https://travis-ci.org, Open the automated test of zeppelin,
Every time you submit your code, travis-ci.org will execute the test case.
Need to wait for all test cases to pass, In order to merge the code.

Do i need to do something pr wait for the ci cycle completion?

You only need to wait for the end of the CI, and then paste the address of your PR CI in the content of the PR.
You can refer to my PR: https://github.com/apache/zeppelin/pull/3407
If the test case reported in the CI did not pass, you need to check the cause of the error. Generally there are the following situations:

If it is not caused by your code, you can repeat the failed test items in travis, sometimes more than a few times, to pass.
If it is a problem caused by your code, then you need to solve it.
If you add new features, you need to add the corresponding test cases to protect and verify your code, avoid the code you add, and be modified by others later.

Although it seems that these are a bit of a hassle, I believe it will help you with your programming.
We need a little patience. :-)

In addition, due to the release of the new version of the latest mysql, there are some test cases in travis-ci, can not pass, we have contacted the mysql community, need to wait for the solution, in order to pass travis-ci.
So, your current travis ci may fail, you can pay attention to the zeppelin community's mail, and the travis ci will return to normal, there will be an email notification. At that time, you need to re-execute travis ci and then update the travis address in the PR.

In addition, due to the release of the new version of the latest mysql, there are some test cases in travis-ci, can not pass, we have contacted the mysql community, need to wait for the solution, in order to pass travis-ci.
So, your current travis ci may fail, you can pay attention to the zeppelin community's mail, and the travis ci will return to normal, there will be an email notification. At that time, you need to re-execute travis ci and then update the travis address in the PR.

Yup. I can see from the logs that there's some mysql issue, not related to the fix I did. I will be waiting till the issue is resolved between travis and mysql :)
Once tests are passed, I will update CI address in the PR.
Thanks a lot @liuxunorg

@srehmann
The travis problem has been solved, you can execute the following command：
git fetch upstream
git checkout ZP3065
git rebase upstream/master
git push -f origin ZP3065:ZP3065

Rebase your branch to the latest code base.
Wait for travis to pass and resubmit your code.

@srehmann
However, I think, Can you add a corresponding test case to ensure the correctness of your code?
There are a lot of test cases in zeppelin. You can find code that is similar to yours. Change to a test case that meets your requirements.
I know to add test cases, There may be a little trouble, But this will ensure the correctness of your code. And can let others not destroy your code.
Can you try adding test cases?

@srehmann
The travis problem has been solved, you can execute the following command：
git fetch upstream
git checkout ZP3065
git rebase upstream/master
git push -f origin ZP3065:ZP3065

Rebase your branch to the latest code base.
Wait for travis to pass and resubmit your code.

Done.

@srehmann
However, I think, Can you add a corresponding test case to ensure the correctness of your code?
There are a lot of test cases in zeppelin. You can find code that is similar to yours. Change to a test case that meets your requirements.
I know to add test cases, There may be a little trouble, But this will ensure the correctness of your code. And can let others not destroy your code.
Can you try adding test cases?

May I add a test case even if the CI is passed? You will merge once test cases are defined or is it merged even without test cases?

CI passed successfully. I have updated the CI link in the PR.

@srehmann CI passes or fails, Before the code is merged, You can modify the code multiple times.
So, you can continue to add test cases. :-)

I will try.

@srehmann ping? :-)

How do I proceed with writing the test case? In terms that my fix is not lost for merge?
Follow this:

git fetch upstream
git checkout ZP3065
git rebase upstream/master
git push -f origin ZP3065:ZP3065

???

Btw, I can see a very close related test case already present. Though the test case was working fine, but not the actual code :-)

@srehmann You can put the screenshot of the running interface after fixing the code in the PR, which can also help review code. :-)

Screenshots from zeppelin?

@srehmann  Thanks for the contribution.
Will merge if no more comments.


Can't install

Atom 1.34.0, Win 7
When I try to install this package, it animates "Install" button for some time, then animation stops and that's all. The package is not installed. Tried several times, with Atom restarting as well.

Hi, installing on Windows requires that you download and install Git. I got the latest here :
https://git-scm.com/download/win
Please note this is different from the Github desktop.
I installed using command :
apm install structure-view
Try that.

Thanks. So, I close this issue as resolved.


💡 [Feature]: Refactor scaffolding form to smaller components

🎯 Aim of the feature
The aim is to refactor the scaffolding form to a smaller and more reusable components.
We could use the gallery view as example
📷 Images (if possible) with expected result

🤔 Additional remarks or comments
No response

Hi @Adam-it , May I attempt this?

Hi @Adam-it , May I attempt this?

Totally!!!
All yours 👍. You Rock 🤩
Let me know if you will need any help along the way, currently the build process is a build hacky

I think I accidentally unassigned myself. I would still like to work on it and would appreciate it if you could reassign it to me.

Also, could you please let me know if there is anything special that needs to be done to be able to debug the extension? My code changes are reflecting but the breakpoints are not currently binding when I hit F5.

Trying exactly that. Debugging the TypeScript classes are working correctly, but breakpoints in React components are unbound. Anyway, it's not that urgent for my current task, I will look into it later.

The PR was merged.
This refactor will be part of the next minor release.
@Saurabh7019 thank you for your awesome work 👏👏👏. You Rock 🤩
As soon as this is merged to main you will also show up as a contributor to the repo 👍

As soon as this is merged to main you will also show up as a contributor to the repo

Thank you so much. :)
It's truly an honor. I'm looking forward to continuing to contribute to this amazing project.


[CodeCompletion] Consolidate parameter list processing functions

There were 2 functions to output argument list. Consolidate them and consistently use it from every call like production (i.e. function call, constructor call, enum with associated values, subscript)
Also:

Display mapped result type for subscriptfunc foo(x: [Int]) {
   x #^COMPLETE^#
}

should display Int instead of Element.
Don't suggest duplicated result for:class C {
    func foo(arg: Int, optArg: Int = 1) {}
}
C.#^COMPLETE^#

Mitigate wrong argument label emission for:class C {
  func foo(x: Int) { }
  static func test() {
    self.foo(#^COMPLETE^#
  }
}

This used to end up with foo(x: <#C#>)

As side effects (I think these are good for consistency.):

Instance method (func methodName(x: Int) -> ...) on meta type:

sourcetext: methodName(<#T##TheType#>) → methodName(<#T##self: TheType##TheType#>)
description: methodName(self: TheType) (same)

Subscript (subscript(index: IndexType) -> ...) results:

sourcetext: [<#T##IndexType#>] → [<#T##index: IndexType##IndexType#>]
description: [index: IndexType] → [IndexType]

@swift-ci Please smoke test

@swift-ci Please smoke test

@swift-ci Please smoke test

@benlangmuir Could you review this?

@swift-ci Please smoke test


fix(SupportedDeviceTable): model name/number wrapping

fixes #427
Before
https://github.com/seamapi/react/assets/11449462/bbbc610e-62af-4e94-ab23-2905c2bbf4fb
After
https://github.com/seamapi/react/assets/11449462/245daea9-f228-4fcb-a7fe-26d9e7db9b48

@miken-seam can you take a look?


Apple will stop accepting submissions of apps that use UIWebView APIs，please change，thank you

Apple will stop accepting submissions of apps that use UIWebView APIs，please change，thank you

Duplicate of #4428

mark


Make StepChain parentage cherrypy thread more verbose

Fixes #9537
Status
In development
Description
Work in progress
Is it backward compatible (if not, which system it affects?)
yes
Related PRs
none
External dependencies / deployment changes
none

Superseeded by https://github.com/dmwm/WMCore/pull/9657


2 Hapoop applications started when using Python Interactive windows with PySpark

Hi all,
I have set up a jupyter notebook with pySpark. When I connect to the jupyter server using VS Code Python interactive window, it spins up 2 applications. While it is simple to kill one of them, I wonder if there is a setting that I could change.
Thanks in advance.
Pong

Thanks for reporting this issue. However, please could you be kind enough to fill in the issue template. E.g. OS, Python, and other such information.
Also, please could you provide instructions to replicate this issue.

I believe @pongwoo  is referring to the two python processes that startup? One of this is the 'restart' session. It's so restarts happen instantaneously.
There's no way to disable this at the moment.

@rchiodo Thank you Rich. And I apologize for not using the template in the beginning. It is exactly what I am referring to. Would this be an option that the developers are willing to consider?
Again, thank you for confirming this.

Whether or not we add an option to disable it will probably depend upon how many people up vote this issue.


As a user I want to see a larger view of book images with any captured annotations so that I can see images in more detail.

Includes

larger version of page image
deep zoom option for page image (toggle on/off)
display annotation details with corresponding zones on the page (toggle on/off, not available in deep zoom)
navigation to other pages
only includes overview images, insertions, and annotated pages

@kevinglover I have a new canvas detail view and template that I think provides all the data and functionality you need to build out the page according to the design.  Please look it over when you get the chance and let me know if you have what you need.

@kevinglover  I've modified the template so that only corresponding references are displayed.  There aren't many in the database, but that was the only way that seemed reliable enough.  If you want an example to work with as you're finishing the styles on that page, try page [49] of Saussure's Cours de linguistique générale .
Let me know if you need anything else from me on this one - I think the remaining work is all yours.