Make start and stop functions blocking

[x] Add WaitForContainerStatus func
It's using a time.Sleep to block the thread. Should I start a go routine that will sleep and on the main block with a waitgroup? I think the time.Sleep is enough

[x] Update Daemon start

[x] Update Daemon stop

[x] Update daemon commands

[x] Update Service start
It's using a WaitGroup to wait for all dependencies to start.
It's also using a mutex to edit serviceIDs array that is shared between the goroutines.

[x] Update Service stop
It's using a WaitGroup to wait for all dependencies to stop.

[x] Update service commands

Changelog updated.
Please review my comments of your comments.

still have some errors from codeclimate

I'm merging even with the codeclimate issues. I don't know how to fix it in a simple way..


BCMOHAD-24595 Update Validation Rule

Description
Modified Validation Rule
Fixes # (issue)
Type of change

[ ] New feature (non-breaking change which adds functionality)

List high-level changes as bullet items
Below are some examples
Deployment Tracker
List all the metadata that is pushed in this commit/PR. Full URL should be fine.
MAiD - Case Management App/force-app/main/default/objects/Form_1634__c/validationRules/Rule_42_Data_Check.validationRule-meta.xml
Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

@sameerjoshicgi  @lovychauhanCGI  Closing the PR based on the dicussion with Sameer


CREATE FUNCTION: Missed INDEX as table_constraint

https://docs.microsoft.com/en-us/sql/t-sql/statements/create-function-transact-sql?view=sql-server-ver15
states that

no INDEX option defined while SQL Server allows it
`
create or alter  function Test()
returns @result table(id int not null, index idx (id))
as begin
return
end
go
`
Alow please note that CLUSTERED/NONCLUSTERED is described - the issue may relate to https://github.com/MicrosoftDocs/sql-docs/issues/7256
@LitKnd

@OleksiiKovalov -- Oleksii, thank you again for your careful feedback.
@LitKnd -- Kendra, please look into this issue, related to #7256.

Hello,
Apologies for the delay in getting back to you.
The table_constraint portion of the syntax map is specific to constraints. the index example that you've given isn't a constraint, so it wouldn't make sense for it to be a part of the constraint syntax.
I will look into whether there is a desire to document this functionality in another part of the syntax map.
Thanks,
Kendra from the Database Docs Team

Hello,
Apologies for the delay in getting back to you on this-- we have a large volume of Git issues. We appreciate your feedback and your patience! I am reassigning this issue to my most excellent teammate, Randolph.
Kendra from the Database Docs Team
#reassign: @rwestMSFT

@OleksiiKovalov I'm tracking this issue, as well as your related issue, internally. Thank you for raising it.
#please-close.


Feature: Request Delegates

Request Delegates inspired by @codeOfRobin talk about http://khanlou.com/2017/01/request-behaviors/ at Swift Delhi Meetup
It will require refactoring Request, Upload and Download Operations to reuse the code.

Oooh!

This sees like a good idea! Doesn't solve things like Linux compatibility (cos Alamofire doesn't work on Linux quite yet) but is otherwise really cool 👍

Yes sad but @alamofire has it in its scope for 5.0. Thanks!


Allow passing route parameters to modals

Hello Kanzitelli. I'm loving navio since 0.0.1 !
Do you think we could allow modals to receive route parameters? Or is there already a way to do this? (btw tried setParams but did not understand fully how that should used for a modal screen)
I happened to require using a modal to confirm an action and to do it within the modal I needed some information (ig: ids)
I saw that with regular react navigation you could just pass params and the screen would receive that from useRoute().params
Right now I'm using global state to pass the information to my modal but would definitely be really useful to just do:
navio.show('myModal', { usefulId: 'someid' } )

Similar to how navio.push signature is.

Hey @lakardion! Happy to hear that! And I'm currently on the vacation, couldn't reply quickly.
Currently with navio it's possible but using react-navigation's instance navio.N. This is what you can do:
navio.N.navigate('MyModal', { screen: 'ScreenName', params: { usefulId: 'someid' }, });

Check out this issue for more info.

Awesome. That is 100% what I needed.
thank you very much. Cheers


[NhkVod] incorrect sorting

Checklist

[X] I'm reporting a broken site
[X] I've verified that I'm running yt-dlp version 2021.10.22. (update instructions)
[X] I've checked that all provided URLs are alive and playable in a browser
[X] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[X] I've searched the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue
[ ] I've read about sharing account credentials and I'm willing to share it if required

Region
No response
Description
Prefers format with unknown resolution over the file with higher tbr.
Verbose log
$ yt-dlp -Fv https://www3.nhk.or.jp/nhkworld/en/ondemand/video/2055008/
[debug] Command-line config: ['-Fv', 'https://www3.nhk.or.jp/nhkworld/en/ondemand/video/2055008/']
[debug] User config file: /home/pogaca/.config/yt-dlp/config
[debug] User config: ['-f', 'mkv', '-f', 'bestvideo[height<=1080]+bestaudio/best/standard', '-o', '~/Downloads/%(title).200s - %(id)s.%(ext)s']
[debug] Encodings: locale UTF-8, fs utf-8, out utf-8, err utf-8, pref UTF-8
[debug] yt-dlp version 2021.10.22
[debug] Lazy loading extractors is disabled
[debug] Python version 3.9.7 (CPython 64bit) - Linux-5.14.16-arch1-1-x86_64-with-glibc2.33
[debug] exe versions: ffmpeg 4.4 (setts), ffprobe 4.4, rtmpdump 2.4
[debug] Optional libraries: Cryptodome, mutagen, sqlite, websockets
[debug] Proxy map: {}
[debug] [NhkVod] Extracting URL: https://www3.nhk.or.jp/nhkworld/en/ondemand/video/2055008/
[NhkVod] 2055-008: Downloading JSON metadata
[debug] [Piksel] Extracting URL: https://player.piksel.com/v/refid/nhkworld/prefid/nw_vod_v_en_2055_008_20211023141000_01_1634967946
[Piksel] nw_vod_v_en_2055_008_20211023141000_01_1634967946: Downloading webpage
[Piksel] nw_vod_v_en_2055_008_20211023141000_01_1634967946: Downloading JSON metadata
[Piksel] nw_vod_v_en_2055_008_20211023141000_01_1634967946: Downloading JSON metadata
[Piksel] d35a7oqn: Downloading m3u8 information
[Piksel] d35a7oqn: Downloading SMIL file
[debug] Formats sorted by: hasvid, ie_pref, lang, quality, res, fps, hdr:12(7), vcodec:vp9.2(10), acodec, filesize, fs_approx, tbr, vbr, abr, asr, proto, vext, aext, hasaud, source, id
[info] Available formats for d35a7oqn:
ID         EXT RESOLUTION │  FILESIZE    TBR  PROTO  │ VCODEC    VBR ACODEC   ABR
──────────────────────────────────────────────────────────────────────────────────
hls-391    mp4 unknown    │              391k m3u8_n │ unknown  391k unknown   0k
hls-678    mp4 unknown    │              678k m3u8_n │ unknown  678k unknown   0k
hls-1271   mp4 unknown    │             1271k m3u8_n │ unknown 1271k unknown   0k
http-382   mp4 320x180    │  80.63MiB    382k http   │ unknown  255k unknown 127k
http-391   mp4 320x?      │              391k http   │ unknown  391k unknown   0k
http-663   mp4 640x360    │  139.25MiB   663k http   │ unknown  536k unknown 127k
http-678   mp4 640x?      │              678k http   │ unknown  678k unknown   0k
http-1242  mp4 1280x720   │  260.41MiB  1242k http   │ unknown 1115k unknown 127k
http-10262 mp4 1920x1080  │  2.15GiB   10262k http   │ unknown 9765k unknown 497k
http-1271  mp4 1280x?     │             1271k http   │ unknown 1271k unknown   0k

Fixed in df6c409d1f430bea0c0c4870d44432b14bf25c3a (forgot to link the issue with the commit)


[#7383] Added parameter CommandTimeOut to the function Copy-DbaDbTableData

Type of Change

[ ] Bug fix (non-breaking change, fixes # )
[ X ] New feature (non-breaking change, adds functionality, fixes #7383
[ ] Breaking change (effects multiple commands or functionality, fixes # )
[ ] Ran manual Pester test and has passed (`.\tests\manual.pester.ps1)
[ ] Adding code coverage to existing functionality
[ ] Pester test is included
[ ] If new file reference added for test, has is been added to github.com/sqlcollaborative/appveyor-lab ?
[ ] Nunit test is included
[ ] Documentation
[ ] Build system

Purpose
Sometimes the reader command runs indefinitely and needs to have a timeout. This change adds this as a parameter to the function
Approach
Adding a parameter to a function

You will have to add the parameter to the test as well.

thanks @andreasjordan , I fixed it

Can we change "TimeOut" to "Timeout"?
https://docs.microsoft.com/en-us/dotnet/api/system.data.sqlclient.sqlbulkcopy.bulkcopytimeout
says its "BulkCopyTimeout", so change that as well.

Can we change "TimeOut" to "Timeout"?
https://docs.microsoft.com/en-us/dotnet/api/system.data.sqlclient.sqlbulkcopy.bulkcopytimeout
says its "BulkCopyTimeout", so change that as well.

Nice suggestion. I actually saw that before creating it, but I just kept that standard from the BulkCopyTimeOut. I should have changed it but didn't want to be as forward as this. Will change now

One last change: "$bulkCopy.BulkCopyTimeOut" to "$bulkCopy.BulkCopyTimeout" please.

One last change: "$bulkCopy.BulkCopyTimeOut" to "$bulkCopy.BulkCopyTimeout" please.

Done! 😄

Thanks! How new releases works? When can I expect to have a new version with this new functionality? Sorry to ask this, just to have an idea really.

@mrlmachado - it's in the gallery now 🥳  We're likely going to be releasing every other day or so unless there's a batch of PRs then I'll just do it daily


Read Time out error while using Rest Generators

Hi Team, I was recently trying to run scans on a model using REST generator available in garak.
However i am encountering a read timed out error. looks like the value is hard coded at 10 seconds, which is very low.
i am pasting the error log stack here.
File "/usr/local/lib/python3.11/site-packages/garak/generators/rest.py", line 228, in _call_model
resp = self.http_function(
^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/site-packages/requests/api.py", line 115, in post
return request("post", url, data=data, json=json, kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/site-packages/requests/api.py", line 59, in request
return session.request(method=method, url=url, kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/site-packages/requests/sessions.py", line 589, in request
resp = self.send(prep, send_kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/site-packages/requests/sessions.py", line 703, in send
r = adapter.send(request, kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/site-packages/requests/adapters.py", line 532, in send
raise ReadTimeout(e, request=request)
requests.exceptions.ReadTimeout: HTTPConnectionPool(host='-xyz.com, port=80): Read timed out. (read timeout=10)
please look into this at priority since this issue practically makes rest generators impossible to use.

Thanks, looking

draft fix here, https://github.com/leondz/garak/commit/5c49baafe5fded4c01a9727d06580fe81d0bdc99


Upgrade to TypeScript 3.9

Update to TypeScript 3.9 beta.

We should wait for 3.9 to be released before merging this.

This PR adds some types to fix newly found type errors. I've made a few assumptions writing those types. Please correct me if I made a mistake making those assumptions
To do

[x] Replace @ts-ignore with @ts-expect-error
[x] Enable rule lint to disallow @ts-ignore

Fixes #10855

What kind of change does this PR introduce?
Dependency update

Did you add tests for your changes?
NA

Does this PR introduce a breaking change?
No

What needs to be documented once your changes are merged?
Nothing

@sandersn I think there is a small bug in this typescript release which affects our type generation.
There seem to be some deduplicaton of union/intersection types. But this seems to be a bit too aggressive, which causes an identical but otherwise unrelated type to have an aliasSymbol pointing to the previous symbol. Our type generation uses aliasSymbol to give types names. Now all identical types are merged into an unrelated name inferred from the aliasSymbol.

@weswigham do you know some tricks to avoid alias de-duplication?

It's entirely unavoidable for unions of primitives. Now, if you explicitly write out the names yourself, well, we use what you wrote...

Thanks


just catch crash & how to setup multi dsn to divsion error and crash

I need send error and crash  to diffferent dsn,  now config  enableNative: true,
enableJavaScript: false,   enableUnresponsive: false,   it will capture setup error
and another Sentry init just capture error is not work.  please give me some advices.thanks

We have just released v3.0.0 of the SDK which includes a lot of changes and improvements since this issue was opened.
If you can still reproduce this with v3, please open a new issue and I'll look into it.


fix: DEV-2669: align filter items and ensure visually displays selected authors correctly

/frontend build lsf master

This code is already present in develop. Closing.


Add an alias name for EnTT in CMake

I propose that you add a target alias for EnTT in CMake as to follow the convention of many other major libraries. Something like:
add_library(EnTT INTERFACE)
add_library(EnTT::EnTT ALIAS EnTT)

This has numerous benefits according to the book Professional CMake 2nd Edition by Craig Scott. Some of which I'll quote here to back up why I think this would be beneficial:
Quote from page 143:

Another` important aspect of names having a double-colon (::) is that CMake will always treat them as the name of an alias or imported target. Any attempt to use such a name for a different target type will result in an error.

Basically, without the alias name linking for EnTT in CMake without actually having the target available will make GCC attempt to use -lEnTT which can cause compile errors instead of generation time errors with CMake, that make it more clear something is wrong.
Quote from page 144:

It is therefore more robust to link to namespaced names where they are available. Projects are strongly encouraged to define namespaced aliases at least for all targets that are intended to be installed/packaged. Such namespaced aliases can even be used within the project itself, not just other projects consuming it as a pre-built package or child project.

I'm not sure if including the quotes is allowed, but I do find them helpful to explain my point, and I will gladly remove them if it is inappropriate.

Have you tried it already? Does the change you're proposing work as expected?

It is not enough alone. It must also be added to the export target around line 120 in the CMakeLists.txt (added the NAMESPACE part):
install(
    EXPORT EnTTTargets
    FILE EnTTTargets.cmake
    DESTINATION ${CUSTOM_INSTALL_CONFIGDIR}
    NAMESPACE EnTT::
)

I just did a quick test with those two changes and that seems to work as intended.

May I ask you to make a PR when you think you have something that works?
I've not a project on which to test it right now and I'm a bit short in time to pack one.

@skypjack Yes, I'll try the changes in a project and test that it works with find_package and add_subdirectory.

Thank you very much! Really appreciated.
I'll keep the issue open for a week or so, let me know if you try it and feel free to make the PR when you're ready. :+1:

Tested it now with find_package after making the changes to current master and building + installing locally. Also tested in-source build with add_subdirectory and it works great in both cases. I think it will also be better suited for use with FetchContent now, but I can't test that quite yet. I'll be setting up a PR soon.


Update NB to run on gp13, where astropy.stats.LombScargle() is now as…

…tropy.timeseries.LombScargle()

@jacquesalice can you please review this NB PR on repgp02? Only change is where Astropy now has the LombScargle() class.


fix: Symbol named props

Please check if the PR fulfills these requirements

[X] The commit message follows our guidelines
[X] Tests for the changes have been added (for bug fixes / features)

Does this PR introduce a breaking change? (check one with "x")
[ ] Yes
[X] No

Details
Fixes a bug where you can't use symbols as name of props if using the props helpers.
I'm not sure if this is the right approach, since I'm not entirely sure of the side effects of not having a dashCased string name.

We can fix the MetLife build later.


Replaced all mdi-* occurences in the documentation

All mdi-* class references are now the new material-icons references.
I didn't touch the tests, as they seem to break when doing this. (old version?)

Some of the changes from this commit are editing the html that is automatically generated by the template engine. Please edit only the html contents from /jade/page-contents/ as indicated in the contributing file.

I rolled all page commits back to 1b92fb2. This is how I checked them out after cloning.

We don't use the mdi-*class anymore


Improvement: entities should match includeDomain OR includePatterns, not both

Hi @t0bst4r
With regards to  includePatterns option, am I correct in understanding with this option you can include specific supported entities?
If so, I can't seem to get it to work to load only a specific automation
HOME_ASSISTANT_CLIENT_CONFIG: {"includeDomains": ["light","switch"],"includePatterns": ["automation.away_mode"],"excludePatterns": ["media_player.*echo*","switch.*echo*"]
When I add the above it does not work. No entities are loaded.
If I remove the ,"includePatterns": ["automation.away_mode"] everything works fine.

Yes, I already got that feedback that the include props are not really useful how they work at the Moment.
Entities need to Match both, includeDomain AND include pattern. I should change it to "at least one of both".
In your case you can work around that by removing includeDomains and only using the pattern with light.*, switch.* and automation.away_mode (additionally to the exclude patterns you have).

Just implemented that with the Web editor using my mobile. I’ll review and test that myself tomorrow before releasing a new version 😆


adding router to app

closes #4

@BWortman  I've updated the files for linting issues identifed by eslint


Allow not showing username on SSH connection

This is useful to me because I often work on my remote machine via ssh, I use my own account and I don't need to see my username all the time.
The option name is open for suggestions, and I preserved the default behavior as it is today.
Fine with merging after 3.0 is out, I hope it happens soon though 😉

Seems like a nice idea 👍
I didn't think about it.
I don't like the idea of creating multiple options that respond to showing the specific section. It's like several switches for one bulb. That may cause some inconsistency in API and misunderstanding for users. Let's try to make it work only through SPACESHIP_USER_SHOW. What do you think?

Let's see if I understood you correctly, are you suggesting to remove the new option and simply remove the entire condition about $SSH_CONNECTION? That is fine for me, I didn't do it like that only because I didn't want to introduce breaking changes.


Bug: Images get stretched in a weird way

What happened?
The image viewer stretches images sometimes. My screen resolution is 1080p, Chrome's viewport is 1920x919.
Exhibit A
Input (1920x1920)

Output

Exhibit B
Input (1080x1080)

Output

Exhibit C
Input (1080x1920)

Output

Exhibit D
Input (2160x3840)

Output

Version
latest (ghcr.io/diced/zipline or ghcr.io/diced/zipline:latest)
What browser(s) are you seeing the problem on?
Chromium-based (Chrome, Edge, Brave, Opera, mobile chrome/chromium based, etc)
Zipline Logs
No response
Browser Logs
No response
Additional Info
No response

By the looks of it, sometimes it seems to be fine and then sometimes it's being stretched/shrinked?

Yeah, pretty much. I can't see any rhyme or reason though.

should be fied https://github.com/diced/zipline/commit/f3634eff48ea72cbf6335e718af9a88635286a1c

It doesn't distort now, but big images don't fit the viewport now causing scroll bars to appear.

i was able to get shrinking working with big images, but not with small (i thought this would be a fine trade off since i couldn't find out a way to make it work both ways)

Interesting, I just checked my test images on phone, and unlike on pc everything displays correctly.
https://stash.maximmax42.ru/naSAf.jpg
https://stash.maximmax42.ru/0gbjn.jpg
https://stash.maximmax42.ru/baPsL.jpg
https://stash.maximmax42.ru/bCY1f.jpg
Here are my 4 testing images, all are displayed with scroll bars on my 1080p monitor.

Correction: top link (1080x1920) shows up fine, rest have scroll bars.

I didn't try to do force reload the viewing page after updating Zipline, maybe something from the old version remained.

I tried. There definitely was some leftover stuff in cache, but it only fixed one image (see above).

Correction: top link (1080x1920) shows up fine, rest have scroll bars.

I didn't try to do force reload the viewing page after updating Zipline, maybe something from the old version remained.

I tried. There definitely was some leftover stuff in cache, but it only fixed one image (see above).

Tested these on my end, 2560x1440 monitor, top and bottom link seem to work (once the image is fully loaded it seems to conform to the viewport), but the middle two links seem to have a vertical scrollbar... no idea why this is happening lol, ill still try out different stuff

I think it's fixed here, I tried it on your images and it seems to be resizing just fine!

Yup, seems to work on my end as well.


Instruction Manual?

Hi there - firstly, let me say how great the previous NIS Scaler is - it's a fantastic add-on and you should be proud!
Is there an instruction manual for the new toolkit - I just can't get it to kick in when pressing ctrl & F1 etc.  I've tried it on my Q2 plus G2 and I just cannot get the menu to appear in headset?
Many thanks.
JC.

Did you try pressing CTRL + F2 first (before using F1 and F3)?  I'm not positive, but I think you need to bring up the overlayh with CTRL + F2 before F1 and F3 are going to respond.
Re: manual, did you check the project webpage here?  https://mbucchia.github.io/OpenXR-Toolkit/
Lastly, when you open the companion app, does it state "OpenXR Toolkit layer is active" in green text near the top?

Hey there - many thanks for taking the time to answer - really helpful!

Yes, tried these combinations but could not seem to get the interface up in headset as per VR Flight Sim's YT  video?  Does it matter which Ctrl button I use?
Will try again - thanks.
Yes - tried it just as I was typing and it shows as active in green.

Regards,
JC.

So, just went through the setup etc again and still no on-screen interface in VR.
Should I be in MSFS2020 to be able to adjust it?
Can't see how as it's not just designed for the Sim?
JC.

Can you confirm that you are looking into the headset and not the Flight Sim window on the desktop? And that the Flight sim window does have mouse focus (you can move the mouse in the sim).
Either Ctrl button should work.
Some keyboard have multiple meaning for those F1 F2 etc keys. Do you have to press another key like the "Fn" key?

Many thanks once again for the response.  And from the Dev too!
OK, I can get it to work now in my G2.
Sadly, it slows the whole Sim down to about 2-3 FPS which makes it unplayable for me.
(Specs: Ryzen 3600, RTX3060ti, 64GB PC3600).
Trying to amend any of the settings is just impossible due to the lag etc, and I can't see any config files I could manually adapt in the Tools directory.
I've gone back to the original Scaler you developed which works fine for me so please do close this post.

Can I ask what the issue was with the menu not accessible?

Yes of course.
The issue was that due to the excessive lag, I could not move to or change any of the menu items.  With the original app, I would simply set the level of scaling and sharpening required then fire up Vr and msfs2020 and away I go.
With the toolkit, the whole pc grinds to a halt and gives me approximately 3-5 fps in msfs2020 and vr and there's no way to amend ant settings in the toolkit.
Using the base scaling tool I get great framerates both on msfs2020 and other vr games alike.
Hope that helps?

With the toolkit, the whole pc grinds to a halt and gives me approximately 3-5 fps in msfs2020 and vr and there's no way to amend ant settings in the toolkit.

That sounds a little bit odd. Looks like something else may be interfering? Feel free to attach a log file. We will keep making improvements, and I hope that maybe a future version will work better for you.


How is source file located?

Hi. As title says I have tried putting the source .csv into the database folder but still getting an error message:
The evaluation of this cell failed with the following error:
Binder exception: No file found that matches the pattern: xxx.csv.

any thoughts on how to resolve this?
thanks

Hi @hs41-18,
The /database directory is for mounting the database files of Kùzu (the directory created by Kùzu automatically when you create a new database) rather than raw data files you would like to work with. To make your CSV files accessible, you could mount it at /data instead. Also, note that you still need the prefix directory for accessing the directory you mount when loading the files. If you mount your directory as /data, you need to use the path /data/xxx.csv to access the file instead of just xxx.csv.

hi @mewim I guess /data is just an arbitrary name you are using? if not, could you please tell me where to find that folder?  I've tried putting the CSV into a subfolder, still getting an error.

The /data in the Docker container is not completely arbitrary as we create the directory and set its permissions when building the Docker image (https://github.com/kuzudb/explorer/blob/6d8e5aa361e7d81e3064827924f70d62f1a7144c/Dockerfile#L21C1-L21C1). Do you mind sharing your docker run command so I can have a better idea about how you mount your data files?

just this
docker run -p 8000:8000
-v /absolute/path/to/database:/database
--rm kuzudb/explorer:latest

You should mount your data directory separately from your database directory. I.e.,
docker run -p 8000:8000
-v /absolute/path/to/database:/database
-v /absolute/path/to/directory/with/your/csvs:/data
--rm kuzudb/explorer:latest

Then, your csvs will be accessible under /data instead the Docker container.

do I need to set permissions explicitely or explorer handling it for me?
tried mounting /data separately not worked, with this it didn't work either -u $(id -u):$(id -g) \

It depends on the the permission of your directory, the user you are using, and if you are using docker or Podman. What’s the error you encountered when you mount the data files separately?

I am with an admin user running docker. Got the same error as above:
 The evaluation of this cell failed with the following error:
Binder exception: No file found that matches the pattern: xxx.csv.

Can you do this to help troubleshooting? After you start the container, first run docker ps to get the container id, then run docker exec -it container-id /bin/bash to get shell access. In the shell, run cd /data and ls -al to check if your files present and have the correct permission?

Also, from the error message, it seems you used data/xxx.csv, but it should be /data/xxx.csv with slash at the beginning.

Also, from the error message, it seems you used data/xxx.csv, but it should be /data/xxx.csv with slash at the beginning.

yes indeed, that was the stupid mistake :) I can see the data files from container files and have access


MM-23788 Setup for visual regression testing

Summary
Integrate visual regression testing using Applitools with Cypress.
How to run visual regression testing?
The feature is disabled by default.
To be able to run, you may get API key from Applitools and set into your env variable, and then run:
ENABLE_VISUAL_TEST=true node run_tests.js --group='@visual_regression'

Note:

On CI, visual regression testing will run separately from functional testing.
It's recommended to separate visual regression tests (into a dedicated folder /visual_regression)  from functional tests:

to avoid flaky tests by directly going into the UI and do snapshot instead of mixing with other tests/actions
to not incur long duration to current overall tests since visual regression will take some time to process snapshots/results

How to get screenshot from the spec file?
There are three steps to get the screenshot.

Open the window by cy.visualEyesOpen()
Save snapshot by cy.visualSaveSnapshot()
Then close the window cy.visualEyesClose()

Ticket Link
JIRA ticket: https://mattermost.atlassian.net/browse/MM-23788

In review.

@josephbaylon re: NODE_TLS_REJECT_UNAUTHORIZED, I'm not particularly sure what's causing it and the implication of it. I'm seeing that too locally but not in CircleCI, even if both are on the same version of node @v10.20.1.

@agarciamontoro Thanks for running the tests and valuable inputs.

npm i - we have it in the docs but maybe there's something we can improve?
Chromium - unfortunately it's not due to Cypress but Applitools.  It's not currently supported per their list at the moment.
the last point (see in the comment itself)

npm i - we have it in the docs but maybe there's something we can improve?

Probably not, when I first run an e2e test I followed that guide and everything was clear. I added that comment in case we have different docs for the visual regression testing. But if that's the entry point, it's perfect the way it is now. Thanks!


ForwardDiff compatibility

At the moment, autodiff of implicit functions relies on ChainRules, which means ForwardDiff won't work.
Suggested fix: manually overload the callable on ForwardDiff.Dual

Now that https://github.com/ThummeTo/ForwardDiffChainRules.jl is a thing we can close this?

Should we add it to our package?

Or just document its use.

 But taking 1 more dep might not be the end of the world here.

Not sure how to use this stuff but happy to review a PR adding this and ForwardDiff as dependencies

I am interested in a simple example of use with ForwardDiff!

See https://github.com/ThummeTo/ForwardDiffChainRules.jl/pull/11

Side note: with Julia 1.9 we can add conditional dependencies

@rveltz I will leave documenting an example to you once that PR is merged :)


Fixed unit test and problems running when being bridged to objective-c

Fixed issues shown here: https://github.com/suzuki-0000/SKPhotoBrowser/pull/100

tests passed here :-)
👍

@krummler btw #103

thanks for fixes.

@krummler Merge?

Merged and done :)


第一次调用PhotoPicker.pickImage打开相册的时候很慢，第二次才会快。有没有接口可以同时选择图片和视频，如同微信那样

The first time you open it, you need to scan the information anyway. The next time you open it, it's faster because of the caching.
This method is due to historical reasons, no renaming, in fact, you can choose both pictures and videos at the same time.

I will add a badge with thumb item to help users identify pictures or videos

thanks！


englishman, duo

This pull request was generated by the 'mq' tool
[test]
flake rate: 0.4
logical conflict every: 100
sleep for: 300s
[pullrequest]
requests per hour: 30
deps=[d,e]

/trunk merge


In Jupyter mode, when I use pandas.Dataframe(), the output column names are wrong aligned with actual columns

Bug: Notebook Editor, Interactive Window, Editor cells

Steps to cause the bug to occur

python programming in Juypter mode
use pandas to analyze data
print pandas.DataFrame(), the output column names are wrong aligned with actual columns

Actual behavior

Expected behavior

Your Jupyter and/or Python environment
Please provide as much info as you readily know

Jupyter server running: Local
Extension version: 2020.8.103604
VS Code version: 1.48.1
Setting python.jediEnabled:  false
Setting python.languageServer: Microsoft
Python and/or Anaconda version: Python 3.7.0/conda 4.8.3
OS: Windows
Virtual environment: conda

Python Output

Microsoft Data Science for VS Code Engineering Team: @rchiodo, @IanMatthewHuff, @DavidKutu, @DonJayamanne, @greazer, @joyceerhl

@ztibeike Thanks for reporting this issue. We actually had an issue previously with trimming off initial whitespace from some output types. We have a fix for this in that has not shipped yet, but will be coming in the next full extension release:

Closing as this is fixed in master.

@IanMatthewHuff Thank you very much. Wish a quick update.


How to stop the notification from hiding

Ive tried adding a duration of 0 and -1 to both $notify and as a prop to notifications but so far i cant remove the timeout behaviour

duration="-1" on the prop now working. Required a refresh :D


use after free Error on gd.String properties

Having a gd.String property and editing that in the Godot Editor results in the following error:
panic: runtime.link/mmm error: use after free

goroutine 17 [running, locked to thread]:
grow.graphics/gd/internal.Context.Variant({{0x7fffbe11b220?, 0xc0002fc450?}, 0x7fffbf0c4240?}, {0x7fffbe11b220, 0xc0005976d0})
        C:/Users/***/go/pkg/mod/grow.graphics/gd@v0.0.0-20240606113431-f7a9dfc4c64b/internal/variant_conversions.go:42 +0x19f4
grow.graphics/gd.(*instanceImplementation).Get(0xc0005c97a0, {{}, {0x7fffbdfcd600?, 0xc0003ec390?}})
        C:/Users/***/go/pkg/mod/grow.graphics/gd@v0.0.0-20240606113431-f7a9dfc4c64b/register_class.go:345 +0x2f7
grow.graphics/gd/gdextension.get_func(0x4, 0x572a3fe470, 0x572a3fe320)
        C:/Users/***/go/pkg/mod/grow.graphics/gd@v0.0.0-20240606113431-f7a9dfc4c64b/gdextension/gdextension_interface.go:2379 +0x15a
exit status 2

Sample Code:
package main

import (
	"grow.graphics/gd"
	"grow.graphics/gd/gdextension"
)

type HelloWorld struct {
	gd.Class[HelloWorld, gd.Node]

	DummyString gd.String `gd:"dummy_string"`
}

func main() {
	godot, ok := gdextension.Link()
	if !ok {
		panic("Unable to link to godot")
	}
	gd.Register[HelloWorld](godot)
}

Thanks for reporting, this issue has been fixed.

Reading a string coming from Godot works fine now. But when I do set the string it does still error.
Sample go code:
package main

import (
	"grow.graphics/gd"
	"grow.graphics/gd/gdextension"
)

type HelloWorld struct {
	gd.Class[HelloWorld, gd.Node]

	DummyString gd.String `gd:"dummy_string"`
}

func (h *HelloWorld) Ready(godoCtx gd.Context) {
	h.DummyString = godoCtx.String("Test")
}

func main() {
	godot, ok := gdextension.Link()
	if !ok {
		panic("Unable to link to godot")
	}
	gd.Register[HelloWorld](godot)
}

Sample gdscript code on other node trying to read string
extends Label

@onready var hello_world_node: Node = get_node_or_null("../HelloWorld")

func _ready():
  if hello_world_node == null:
    return

  text = hello_world_node.dummy_string

With a scene like this

Thanks, the error here is expected, since godoCtx.String("Test") is a Godot reference type and only lives until the end of the function. You would need to pin/associate the lifetime of the string with the class, in order to resolve this issue. Something like this:
func (h *HelloWorld) Ready(godoCtx gd.Context) {
	h.DummyString = h.Pin().String("Test")
}

I understand this is not exactly straightforward, nor readily readable, you may like to contribute to the discussion here
https://github.com/grow-graphics/gd/discussions/16
I have some ideas to make this more intuitive/readable, perhaps removing Context parameters as a requirement for methods and using the class itself to access the Godot GlobalScope (and to manage lifetimes).


Adding a note about babelrc

Related to https://github.com/zeit/next.js/issues/7803

Test failure is unrelated to my changes

Thank you!


⚠ Jenkins Plugins Artifactory has degraded performance

In 1385efd, Jenkins Plugins Artifactory (https://get.jenkins.io/plugins/artifactory/) experienced degraded performance:

HTTP code: 200
Response time: 1263 ms

Resolved: Jenkins Plugins Artifactory performance has improved in 180b367 after 1 hour, 21 minutes.


[Bug] Addings Wands /Scrolls Errors when your character has a ritual section

seems to be an issue with no way to handle ritual Casting

NVM you fixed in newer release!


Missing Functionality

I apologize if this Issue is unnecessary, but I thought I would make a list of functionality that appears to either not work or is missing. I could not find this documented elsewhere; perhaps these should be split into separate issues?

List Actions Menu

Add a card... (this functionality exists already, but this menu item does nothing)
Subscribe (nothing appears to happen, no manner of listing subscribed lists)

Sidebar

Menu

Archived Items (nothing appears to happen)
Close Board... (the board can be closed, but the warning refers to the 'Boards' menu in top left having some option to view and re-open closed boards. This does not appear to exist.)

Settings

None of the settings links ("Change ...") appear to have an effect.

Profile

Clicking avatar - would expect ability to select avatar, nothing happens

System: OS X 10.10 / Firefox 35

+1 for all those items :)

+1 for Archived Items (nothing appears to happen)


added ability to configure errand state in configure product.

Added ability to configure state of errand config in configure-product command.
Addresses issue - https://github.com/pivotal-cf/om/issues/214

@calebwashburn Do you think it makes sense to continue to support om set-errand-state if you can configure errand state for multiple errands for a single product now with om configure-product?

I think this could deprecate the om set-errand-state command.


Peer review

Hi Zihang,
I like your well-organized code and clear documentation. Also, you add comments, and it's easy to follow. Errors handling are included in each module, and unit tests are completed. Furthermore, you added the database to your application, which worked very well. You fulfilled all the requirements, and the easy-to-use user interface is a bonus.

Hi Zhang,
You impressed me with your good-design user interface. You also implement login function, which guarantees the security of data. Learn a lot from you!


Npm install warnings with React Native 0.44

When using this package with React Native 0.44 there is a warning about conflicting version numbers for the React package:
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none was installed.

This probably has something to do with recent versions of React Native depending on a React 16 alpha version.

You can safely ignore that warning. There's nothing conflicting and no additional versions are being installed. Once RN switches to a non-prerelease version of React instead of 16.0.0-alpha.12, the warning will go away. You'll get the same warning with many other packages (or at least I am, e.g. react-native-maps).


EnvironmentProjectKeychain does not appear to work as intended

Describe the bug
When setting the CUMULUSCI_KEYCHAIN_CLASS environment variable, as described in the Cookbook, to cumulusci.core.keychain.EnvironmentProjectKeychain, no environment variables are set upon creating orgs. After creating an org, running "cci org list" does not list the newly created org and no data about the org seems to persist.
For this reason, the cookbook for "Run headless browser tests" does not work and the scratch org is not deleted.
Reproduction steps
Steps to reproduce the behavior:

Set CUMULUSCI_KEYCHAIN_CLASS to cumulusci.core.keychain.EnvironmentProjectKeychain
Run a command which would create a scratch org such as "cci flow run dev_org --org dev"
Run "cci org list"
No orgs!

Context
CumulusCI version: 3.19.1 (/usr/local/Cellar/cumulusci/3.19.1/libexec/bin/cci) via brew
Python version: 3.8.5<EMAIL_ADDRESS>Mac OS X Catalina 10.15.6 (19G2021)

The EnvironmentProjectKeychain can only read configuration from environment variables, not set it. (This is an operating system limitation: it's not possible for a process to set an environment variable that will last once the process has ended.) For this reason, it's not a keychain you can use if you're running one cci command to create a scratch org and other commands to use that scratch org. The example in the cookbook works because there is a single cci command.
If you need to use a scratch org across multiple calls to cci, the default keychain (which stores configuration in files) is more appropriate.

I see. This makes sense as to why it does not work as I expected. But the cookbook is running two separate commands:
   1. cci task run robot --org dev -o vars BROWSER:headlesschrome
   2. cci org scratch_delete dev

So I would argue the Cookbook example is not correct. Should it be updated to properly reflect this behavior?

@atrancandoris oh ok, yes, I think you are right. I was looking at the wrong example in the cookbook. We'll take another look at this.
CumulusCI takes a slightly different approach for its own browser tests: https://github.com/SFDO-Tooling/CumulusCI/blob/master/.github/workflows/feature_test.yml#L141 -- it is using the default keychain. This works because CumulusCI does not have dependencies, so the github service credentials do not need to be loaded from an environment variable. I'll need to think what is the best approach for a project that needs credentials from the environment AND the ability to use scratch org configuration across multiple commands.

Thanks for your help. I will use the tests you posted as an example.


There is a warning when unlink session files "No such file or directory"

Hi,
I found there is a warning message "unlink(/var/lib/php/session/ci_session398713f044003b888df479c96bd27010820f1053): No such file or directory" in logs. But I check that if there is a session file before executing unlink session files.

Best,
Tyler Teng

No such code exists in CodeIgniter.
Note that this is a bug tracker; we don't provide help for code that you write here. Please post your questions on our forums instead.
Also, post actual code instead of screenshots.
(duplicate of #5350)


Implement a max request limit for keepalive connections, and make it …

untested

need to base this on fbn-2.3

note the flake errors too :)


Replace PUPed raw arrays in src/ck-ldb/ with std::vector

Salvaged from parts of #2108

I don't understand what is causing this error.
Undefined symbols for architecture x86_64:
  "std::__1::vector<LDObjKey, std::__1::allocator<LDObjKey> >::~vector()", referenced from:
      LBDatabase::MulticastSend(LDOMHandle const&, unsigned long long*, int, unsigned int, int) in libck.a(LBDatabase.C.o)
ld: symbol(s) not found for architecture x86_64

The issue is that when you put a class with non-trivial operators like std::vector inside a union (which wasn't valid at all before C++11), you have to call its destructor manually. Looking at how to do this, I found it confusing and difficult to maintain, and since this PR's goal is cleanup, I decided to revert the changes to LDCommDesc. (For reference, C++17 provides std::variant to handle situations like this.)


Validate "Is Asynchronous" is checked/unchecked on all components/assembly ports

Issue and tracking information
Developer's time Estimated effort to fix (hours):
Developer's Actual time spent on fix (hours)
Issue reporter to provide a detailed description of the issue in the space below
If a client-side (conjugated) basic InterfacePort on a monolithic component nested inside of one or more parent assembly components has its "Is Asynchronous:" box checked, AND any of the delegated client ports on its parent assembly component tree do NOT have this same box checked, AND a connection is made between the highest level delegated assembly client port and a service port on another component/assembly, then the connection and related artifacts for this AMI4CCM interconnect are not properly generated to a CDP deployment descriptor file. All connections are missing in this case, and there are no AMI4CCM connector component fragment  or  entries generated into the CDP file either.

This request is for a new model Validation error check to ensure that if a client port on a monolithic component has its "Is Asynchronous:" box checked, then all parent assembly component client ports that this port is connected/delegated to must also have their "Is Asynchronous:" box checked.

Added batch validation to check delegate connector compatibility between two ports. Fix merged to papyrus. Please let me know if any of the issues fixed should be back ported to the 2.1 maintenance branch.

@j26151 I see. Do you want me to delete/hide "isAsynchronous" check box?? or set it to True by default and disable editing when AMI4CCM is selected??

If the "isAsynchronous" check box has absolutely 0 impact on what is generated because the connector type "AMI4CCM" is all that matters for deciding when ayschronous client side artifact generation occurs then I see no reason to keep the check box around at all.
Additionally, it would be great if we could default the connector type to always be CORBA4CCM instead of needed to select it ourselves each time we add a new port to a component.

The isAsynchronus field is being used during the generation so instead of modifying the generation code, I've added edit helper to automatically set the value according to the connector type and made the attribute read-only. The default connector type will be set to CORBA4CCM connector if the port type is set to an interface. Please let me know if this solution is acceptable.

I also removed the isAsynchronous stereotype from the Interface itself let me know if this is going to be an issue.

Sorry for taking so long to respond. I tested this out and everything looks good here. The only thing that I would ask is if its possible to hide the "is Asychronous" check box all together. Or make it more obvious that its a disabled field. The reason I ask this is in the case where the connector type is CORBA4CCM, its really hard to tell that it is disabled so users will attempt to click that checkbox and see that nothing happens. If not, this isn't a huge concern for us, this is already a great improvement.

Absolutely. I will hide the field all together. Thanks

I see that isAsynchronous is hidden which is great. My only question left is that when I type a port as AMI4CCM and check the profile tab under properties, the isAsynchronous boolean is set to false. I would expect this to toggle to true with AMI4CCM. Is this field no longer used at all or is false okay in this instance?

I've seen that the value of the stereotype was not refreshed under the profile tab. Can you try to click another object and come back to the same port to see if the value is updated?

Clicking off of the object and back on shows it being updated correctly. I would be fine with closing this ticket, but I would like to have that tab refresh immediately. I can't think of other specific instances where this has happened but I know this is not the first time we have seen this in papyrus for other fields. It would be great if the UI was refreshed on its own or accurate when we are viewing it

I will create a separate ticket for the refresh issue and close this ticket, thanks.


When run through web middleware causes Maximum function nesting level error

I've defined some very simple controllers loading very simple twig views. When I add routes to these into the web middleware group I get the following error: Maximum function nesting level of '100' reached, aborting! When I take the calls out of that group it works fine. There are no redirects or function calls in my code. The function in the controller simply calls a twig view that is a plain html page.

Edit
In case it helps the error in the console looks like this:
PHP Fatal error:  Maximum function nesting level of '100' reached, aborting! in /Users/promer/ap-pltw-laravel/vendor/laravel/framework/src/Illuminate/Container/Container.php on line 700

I think I've figured out the problem. It appears that there is no support for 5.2 yet. It looks like middleware groups in general are causing the problem which were introduced in laravel 5.2.

I just got the same problem, I'm a newbie so I though it was coming from me (maybe it is), take a look:
I've got the kernel.php:
    protected $middlewareGroups = [
        'web' => [
            \App\Http\Middleware\EncryptCookies::class,
            \Illuminate\Cookie\Middleware\AddQueuedCookiesToResponse::class,
            \Illuminate\Session\Middleware\StartSession::class,
            \Illuminate\View\Middleware\ShareErrorsFromSession::class,
            \App\Http\Middleware\VerifyCsrfToken::class,
            \App\Http\Middleware\VisitedCookie::class,
        ],

        'ajax' => [
            \App\Http\Middleware\AllowOnlyAjaxRequests::class
        ],

        'api' => [
            'throttle:60,1',
        ],
    ];

When I add VisitedCookie middleware the error comes.
My middleware :
<?php namespace App\Http\Middleware;

use Closure;
use Illuminate\Http\Request;
use Cookie;

class VisitedCookie {
    public function handle($request, Closure $next)
    {
        if (Cookie::get('visitedToday'))
            return $next($request);

        Cookie::queue("visitedToday", true, 86400);
        return $next($request);
    }
}

@rcrowe Any plans for Laravel 5.2 compatibility / hints how to fix ist?

Well, I set up the xdebug variable too "fix" the issue. It seems that the nesting level really reached the theoric limit fixed some years and years ago by PHP xdebug.
add this (or edit) to your php.ini:
xdebug.max_nesting_level=200

I set it to 10000 & it doesn't fixed it (it only crashed my terminal..)

You should not have to set so much >< you probably got a real memory leak / request looping during your processes.

Will this be adapted to work on Laravel 5.3 any time soon? I have the same issue when trying to set up.
Thanks!

Any reactions/responses from @rcrowe? @barryvdh?  Is this project dead?

I've not run in to this, but is there a Pr to fix this?


Blocking hotkeys for other plugins

Running Obsidian 1.7.1 on Windows desktop. When ToggleList is enabled, hotkeys that I defined for other plugins (QuickAdd and Unique Note Creator) fail to load. When I disable ToggleList, the other hotkeys load properly. I have a single hotkey assigned for one of my ToggleList State Groups.

Thanks. Works great now!


Flutter web does not support FontFeature.tabularFigures

Flutter web does not support FontFeature.tabularFigures
(Internal customer, so no flutter doctor output or other logging)

Deduplicating with https://github.com/flutter/flutter/issues/64595


Make PhoneInput component controlled, small fixes

Added value prop to PhoneInput
Formatting and caret position fixes
Docs updates
Update styling for safari

:tada: This PR is included in version 1.4.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


v0.11.x

Description
Tracking branch for breaking changes that will be shipped with 0.11.0. Do not merge until we're ready for the release.

@masci ciao Massimiliano
The main class for OctoAI is broken since the release of 0.2.0
There is a recursive call in base.py

Which then messes here:

Which also means the argument needs to be changed from token to api_key which is what the octoai-sdk expects
Do you wanna send a short PR? Or shall I sent?

Thanks for the heads up @mbonet! Please go ahead and open a PR, it looks like the fastest path to resolution.

@mbonet FYI https://github.com/run-llama/llama_index/pull/16002/files


Which kind of status should be returned after sendLocalReply

I'm developing my custom HTTP filter to do some validation for HTTP requests.
Http::FilterHeadersStatus decodeHeaders(Http::HeaderMap& headers, bool) {
    if (header_validation_failure()) {
        callback->sendLocalReply();
        return Http::FilterHeadersStatus::???;  // which status should be returned here???
    }
    Http::FilterHeadersStatus::Continue;
}

Http::FilterDataStatus decodeData(Buffer::Instance&, bool) {
    if (data_validation_failure()) {
        callback->sendLocalReply();
        return Http::FilterDataStatus::???;  // which status should be returned here???
    }
    Http::FilterDataStatus::Continue;
}

As you see, if the validations fail in decodeHeader or in decodeData, I want to send a local reply to client immediately, and the current request shouldn't be held by Envoy or be passed to remaining filter anymore. But I don't know which kind of status should be returned.

you can return StopIteration for both decodeHeaders/Data after sending local reply.


Beginner guide to open source software article

Draft of my very lengthy beginners article open source contributions

@Umayarz18 Looking forward to the finished project of this article! Just wanted to let you know a few things.
First, I noticed that you made some new tags. This is completely fine, however please make sure they are separated by dashes. For example, open source should be open-source. Also, each tag needs to have a corresponding mdx file inside of the tags folder. Since all 3 of your tags are new, you will need to add a file for each of the tags.
Lastly, seoDescription is now depreciated. We just use description now.
I also added a new contributions page which can be found here: https://benjamincarlson.notion.site/Contributing-to-Coffeeclass-io-27ab5e894368424a9c86a7f11555514b
I am also making a new agile roadmap which can be found here: https://www.notion.so/benjamincarlson/2356b55aadf840f892b12f80531fe293?v=ddd300f3bb7c4d199f1abf6f770dd301
I am hoping that both of these will make contributions easier. If there is anything you think is unclear, I would love to hear your thoughts!

@bjcarlson42  oh cool, thanks for letting me know! I will make sure to have tags and try to keep the article from being more than 2000 words (lots of material to write about lol). Honestly if it goes longer, it might even be better to shorten this article to 1400 words  and save some points of an open-source course in the future. Let me know if that sounds like a good approach to you to have a shorter beginner's article and like a 6 module open source course to best educate on the topic?

That sounds like a great idea. Would you be willing to create the course?

Yes, I don't mind 😄. After my full article is done, I will see how I could structure most of it into a course on like a doc and I'll post the outline to the discussion board to get feedback.

Sounds good! @Umayarz18

Hey @Umayarz18 Is this PR ready for review or is it still a draft?

Yes, I condensed it a bit more to leave some ideas for a course. But it's good for review now 😄

@Umayarz18 article looks good. Can you merge main into your branch? There were some commits made to main that happened after you created this branch. After that, I'll merge!

Okay just updated to match main,  list items seem to look off but I'm not quite sure why.


docs: Removing finer wallet from Readme file

Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Checklist:

[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings

Type of change.

[ ] FIX - a PR of this type patches a bug.
[ ] FEATURE - a PR of this type introduces a new feature.
[ ] BUILD - a PR of this type introduces build changes.
[ ] CI - a PR of this type introduces CI changes.
[x] DOCS - a PR of this type introduces DOCS improvement.
[ ] STYLE - a PR of this type introduces style changes.
[ ] REFACTOR - a PR of this type introduces refactoring.
[ ] PERFORMANCE - a PR of this type introduces performance changes.
[ ] TEST - a PR of this type adds more tests.
[ ] CHORE - a PR introduces other changes than the specified above.

This looks good to me, let's also add the below message in the /packages/finer-wallet/Readme.md file:

⚠ FiNER Wallet has been marked as deprecated. ⚠

How it look now ? @kujtimprenkuSQA


[WIP] Passport JWT strategy for mobile

Motivation
The current strategy that Passport is using for mobile is not working properly due to the implications listed on RAINCATCH-1192.
Description
Add Passport's JWT strategy for mobile authentication instead of cookies.
Progress

[x] Separate mobile and portal into two express Routers
[x] Create relevant routes for each mobile/portal
[x] Add passport JWT Strategy
[x] Update Passport Auth's authenticate function to authenticate without redirection
[x] Update Passport Auth's protect function to verify user authentication with a token
[x] Clean up
[x] Update unit tests
[x] Update documentation

Additional Notes
Related JIRA - https://issues.jboss.org/browse/RAINCATCH-1209

Checked changes locally. Great progress so far.

@JameelB - Exceptional work. There is one bug we can deal with and couple a minor improvements.
We can chat about that tommorow and approve this PR.

@JameelB - Marking as approved for now, but let's not merge until angularjs work will be reviewed and tested.
Unit tests needs minor tweak:
  1) Test Passport Auth should return an error if an error occurred when retrieving the user:
     TypeError: Cannot read property 'authorization' of undefined
      at src/auth/PassportAuth.ts:26:335
      at Context.<anonymous> (test/PassportAuthTest.ts:51:34)
  2) Test Passport Auth should not authenticate the user if the credentials provided are not valid:
     TypeError: Cannot read property 'authorization' of undefined
      at src/auth/PassportAuth.ts:26:335
      at Context.<anonymous> (test/PassportAuthTest.ts:72:34)
  3) Test Passport Auth should authenticate the user if the credentials provided are valid:
     TypeError: Cannot read property 'authorization' of undefined
      at src/auth/PassportAuth.ts:26:335
      at Context.<anonymous> (test/PassportAuthTest.ts:93:34)
  4) Test Passport Auth should not authenticate if the user is already authenticated:
     TypeError: Cannot read property 'authorization' of undefined
      at src/auth/PassportAuth.ts:26:335
      at Context.<anonymous> (test/PassportAuthTest.ts:222:34)

Changes Unknown when pulling 8e531a9531a082a203bcc179b54cf618b879154f on JameelB:offline-mobile-auth into ** on feedhenry-raincatcher:master**.

Changes Unknown when pulling 8e531a9531a082a203bcc179b54cf618b879154f on JameelB:offline-mobile-auth into ** on feedhenry-raincatcher:master**.

Changes Unknown when pulling 86629f3e10970e3bf7e70ea8a9b93c5073ab3a72 on JameelB:offline-mobile-auth into ** on feedhenry-raincatcher:master**.

Changes Unknown when pulling 3ce0a2dbdeda7e4e243b64a14e14ae0392527983 on JameelB:offline-mobile-auth into ** on feedhenry-raincatcher:master**.


[WIP] Integration with Link checker api

I'll close this for now since it's not being actively worked on.

Will be working on this during the fire break.

Closing for the moment since it's not being actively worked on.


Remove Netty from Spark Client Shaded Jar

What changes were proposed in this pull request?

Align Netty version w/ Spark
Remove Netty from Spark Client Shaded Jar

Why are the changes needed?
Currently, Celeborn Spark Client Shaded Jar ships the relocated netty classes, but since there are native libs inside Netty, and it's not easy(IMO) to relocate native libs, then it still has conflict potentials.

What are the items that need reviewer attention?
Related issues.
Related pull requests.
How was this patch tested?
/cc @related-reviewer
/assign @main-reviewer

I'm going to fix the compile error after #891 get merged.

Let us shade netty and rename the native libraries to keep the netty version under control because I have seen some performance gain and stability improvement after using the latest netty. And there will be more engines to support, a stable netty will be helpful for us to profile the performance.
So I think this might not be a good idea.

There is an example how to relocate Netty native libs in Gradle
https://github.com/grpc/grpc-java/blob/master/netty/shaded/build.gradle

There is an example how to relocate Netty native libs in Gradle https://github.com/grpc/grpc-java/blob/master/netty/shaded/build.gradle

Message received, I think maven can do it as well. I'll try it.

I found https://github.com/apache/flink-shaded done the job, thanks for the explanation, I agree with you as long as we can fully shade the Netty native libs, then close this PR.


Abhorrent Placement when first opening terminal on windows 11

Windows Terminal version
No response
Windows build number
No response
Other Software
No response
Steps to reproduce
Opening Windows Terminal for the first time on windows 11 on a 1920x1080 screen...
Expected Behavior
Top left placement similar to CMD.exe.
Actual Behavior
Bad placement.

Thanks for filing!
Can you share the way in which the window placed poorly? For me, it launches in roughly the same place as CMD does.

In addition -- sorry, I may have missed it in the template above -- what version of Terminal are you using?

It's seemingly near random

That looks like Windows default behavior when opening Win32 apps. They open as a little "cascade" along that diagonal (depending if there's already another app opened at that position).
From https://learn.microsoft.com/en-us/windows/win32/winmsg/window-features#default-size-and-position:

An application can allow the system to calculate the initial size or position of a top-level window by specifying CW_USEDEFAULT in CreateWindowEx. If the application sets the window's coordinates to CW_USEDEFAULT and has created no other top-level windows, the system sets the new window's position relative to the upper left corner of the screen

You can of course set the initialPosition for the Terminal manually in the settings.


[stable/minio] fix handling of extraArgs

Describe the bug
Additional arguments passed in as values in extraArgs is ignored inside the pod even if they are listed in command field. e.g. when describing the pod or deployment.
Version of Helm and Kubernetes:
irrelevant for this issue
Which chart:
stable/minio v5.0.4
What happened:
Additional arguments are not passed to minio binary.
$ kubectl describe pod minio-6d5bd7789-7cbd2

...
Command:
      /bin/sh
      -ce
      /usr/bin/docker-entrypoint.sh minio -S /etc/minio/certs/ server /export
      --compat
...

$ kubectl exec -it minio-6d5bd7789-7cbd2 sh

/ # ps
PID   USER     TIME  COMMAND
    1 root      0:06 minio -S /etc/minio/certs/ server /export

What you expected to happen:
Additional arguments to be passed to Minio binary. Arguments should be in the same line as docker-entrypoint.sh, e.g:
$ kubectl describe pod <podname>
...
    Command:
      /bin/sh
      -ce
      /usr/bin/docker-entrypoint.sh minio -S /etc/minio/certs/ server /export --compat
...

/ # ps
PID   USER     TIME  COMMAND
    1 root      0:08 minio -S /etc/minio/certs/ server /export --compat

How to reproduce it (as minimally and precisely as possible):
$ helm install --set extraArgs="{--compat}" stable/minio
Anything else we need to know:
Refer to discussion in #17075

It helped me:
values.yaml
mountPath:
/export --compat

Can some please merge the pull-request?
Running Minio in --compat mode is necessary in order to use it as object storage for Gitlab.
@harshavardhana

/lgtm

/ok-to-test


Adapt yiisoft/data changes & update deps

Q
A

Is bugfix?
✔/❌

New feature?
✔/❌

Breaks BC?
✔/❌

Fixed issues
comma-separated list of tickets # fixed by the PR, if any

Thank you.


Replace io.js with node.js

Replace the io.js installation script (fpga-api/scripts/install_dependencies.sh) with the new node, when the convergence between the two is finished (https://github.com/nodejs/node)

Out of the scope for this project


Enable many integration tests for spark.

Enable many integration tests for spark.

@rabbitonweb I enabled the tests I could, and made the failing ones pending (aside from the tests waiting on a fix from QScript which are still skipped.)

Closing since travis build didn't trigger. Will reopen.

@rabbitonweb beware - travis hasn't actually run the build for this even though it has the green check mark.


How to leverage FastEndpoints in a multi-tenant setup with different database per tenant?

I followed the instructions at link to create my first sample FastEndpoints app. In my case, I have a multi-tenant application with a database per tenant. During application startup, there won't be any tenant context.
Program.cs looks as below:
global using FastEndpoints;
using MiniApi;

var builder = WebApplication.CreateBuilder();
builder.Services.AddFastEndpoints();

builder.Services.AddHttpContextAccessor();
builder.Services.AddScoped<ITenantContext>(sp =>
{
    var httpContextAccessor = sp.GetService<HttpContextAccessor>();
    var httpContext = httpContextAccessor.HttpContext;
    var userId = httpContext.Request.Headers["user-id"];  // In actual, this comes from claims in the bearer token
    var tenantId = httpContext.Request.Headers["tenant-id"]; // In actual, this comes from claims in the bearer token
    return new TenantContext { TenantId = tenantId, UserId = userId };
});

var app = builder.Build();
app.UseAuthorization();
app.UseFastEndpoints();
app.Run();

The tenant context interface looks as below:
public interface ITenantContext
{
    string TenantId { get; }
    string UserId { get; }
}

public class TenantContext : ITenantContext
{
    public string TenantId { get; set; }

    public string UserId { get; set; }
}

And my Endpoint looks as below:
public class MyEndpoint : Endpoint<MyRequest>
{
    private readonly ITenantContext tenantContext;

    public MyEndpoint(ITenantContext tenantContext)
    {
        this.tenantContext = tenantContext;
    }

    public override void Configure()
    {
        Post("/api/user/create");
        AllowAnonymous();
    }

    public override async Task HandleAsync(MyRequest req, CancellationToken ct)
    {
        var response = new MyResponse()
        {
            FullName = req.FirstName + " " + req.LastName,
            IsOver18 = req.Age > 18
        };

        await SendAsync(response);
    }
}

When I run this app, during startup, it tries to create this endpoint and fails while resolving ITenantContext as the HttpContext does not contain required headers (in actual, required bearer token too). Once this tenant context is instantiated, downstream classes lazily fetch the required tenant info like database connection string etc as required and cache it.
I even tried property injection and in this case the tenantContext stays null. It never gets resolved.
public class MyEndpoint : Endpoint<MyRequest>
{
    public ITenantContext tenantContext;

    public override void Configure()
    {
        Post("/api/user/create");
        AllowAnonymous();
    }

    public override async Task HandleAsync(MyRequest req, CancellationToken ct)
    {
        var response = new MyResponse()
        {
            FullName = req.FirstName + " " + req.LastName,
            IsOver18 = req.Age > 18
        };

        await SendAsync(response);
    }
}

So in such a multi-tenant setup where there is no tenant context during startup, how do we leverage FastEndpoints?

Hello!
You just need to slightly modify your factory method and register the ITenantContext after the AddFastEndpoints() call like this:
builder.Services.AddFastEndpoints();
builder.Services.AddScoped<ITenantContext>(sp =>
{
    var httpContextAccessor = sp.GetRequiredService<IHttpContextAccessor>();
    var httpContext = httpContextAccessor.HttpContext;
    if (httpContext is not null)
    {
        var userId = httpContext.Request.Headers["user-id"];
        var tenantId = httpContext.Request.Headers["tenant-id"];
        return new TenantContext { TenantId = tenantId, UserId = userId };
    }
    return new TenantContext(); //this is ok as it's only ever done for startup
});

Basically, the HttpContext would only ever be null during app startup.


fix: Only publish when jx is prerelease

Summary
This change prevents the downstream components from being updated if the state of the jx release is not a prerelease.

/hold

/retest

/hold cancel

/lgtm

/retest


Restoration

Re-implemented changes to project from main branch to handle the issue of the project being unloaded.

Requesting to merge to the wrong branch.


GSoC Summary: Improve Cask Integration

This is a summary of the work done for my Google Summer of Code project “Improving Cask Integration”: https://summerofcode.withgoogle.com/projects/#5834734450507776
Migrating Taps from Caskroom to Homebrew
The first sub-project was to migrate all cask taps from the Caskroom organization into the Homebrew organization, which required renaming them on GitHub and writing migration code for renaming locally installed taps. The tracking issue can be found here: https://github.com/Homebrew/brew/issues/4193
Merging brew search and brew cask search
The second sub-project was to merge brew cask search into brew search, so that both casks and formulae can be found with a single command. Casks are now also searchable by name with brew search --desc, brew cask search has been deprecated. The tracking issue can be found here: https://github.com/Homebrew/brew/issues/4254
Merging Cask and Formula Download Strategies
The third sub-project was to merge the download strategies used by brew cask and the default ones. Despite the cask download strategies originally being forked from the default ones, these had diverged considerably over the years. The tracking issue can be found here: https://github.com/Homebrew/brew/issues/4401
Merging brew cleanup and brew cask cleanup
In the same vein as merging brew search and brew cask search, the fourth and final sub-project was to merge brew cleanup and brew cask cleanup. With the download strategies merged, adjusting the cleanup logic was quite easy in comparison. brew cleanup will now clean up both formulae and casks. The tracking issue can be found here: https://github.com/Homebrew/brew/issues/4660

Thank you for mentoring me, @JCount and @MikeMcQuaid!

Nice work! I just followed a little bit the download strategies refactoring, and it looked like it was a lot of work. Necessary work which really improves the code. Thanks!

👏. Closing as this is a write-up.


Merge live 02/02/2022

Docs Build status updates of commit f24a007:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docs-ref-services/preview/dtdl-parser-readme.md
:warning:Warning
View (azure-node-preview)
Details

metadata/preview/azure-dtdl-parser.json
:white_check_mark:Succeeded

docs-ref-services/preview/dtdl-parser-readme.md

Line 2, Column 1: [Warning: ms-prod-and-service - See documentation] Only one of the following attributes can exist: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.
Line 9, Column 16: [Warning: ms-prod-technology-invalid - See documentation] Invalid value for 'ms.technology': 'azure' is not valid with 'ms.prod' value 'azure'.
Line 11, Column 13: [Warning: ms-service-subservice-invalid - See documentation] Invalid value for 'ms.service': 'digitaltwins'.
Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.
Line 5, Column 12: [Suggestion: ms-author-invalid - See documentation] Invalid value for 'ms.author', 'johngallardo' is not a valid Microsoft alias.
Line 20, Column 23: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/azure/digital-twins/concepts-models' will be broken in isolated environments. Replace with a relative link.
Line 63, Column 126: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/azure/digital-twins/concepts-models' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


No sound from RaspiAudio

I am using RaspiAudio and configured as explained

I was able to connect to the "balenaOS xxxx" bluetooth device from my phone but when playing any music, does not produce the sound.
Running on Pi 4 with OS version 2.58.
I tested the HAT on Rasbian ( not Balena ) and it works fine. So no issue with hardware I guess.
Any idea or troubleshooting help?

Never mind ! I got it working. I had the configuration in "Fleet" and did not propagate to the device. I added them in "Device" configuration and it worked.


Month can't be changed when DatePicker is inside of FormControl element

Environment
"react-dom": "16.2.0",
"react": "16.2.0",
"moment": "2.20.1",
"material-ui-pickers": "latest",
"material-ui": "1.0.0-beta.30"

Steps to reproduce

Put DatePicker inside of FormControl component
Try to pick a date in month before or after the currently selected one

Expected behavior
Month can be changed
Actual behavior
Selection is forced to the currently selected month
Live example
https://codesandbox.io/s/14kk1py3jl

I have encountered the same problem and I noticed the below warning which may hopefully provides some clue:
index.js:2177 Warning: Failed prop type: The prop 'inputRef' is marked as required in 'Input', but its value is 'undefined'.     in Input (created by Input)     in Input (created by WithStyles(Input))     in WithStyles(Input) (created by TextField)     in div (created by FormControl)     in FormControl (created by WithStyles(FormControl))     in WithStyles(FormControl) (created by TextField)     in TextField (created by DateTextField)     in DateTextField (created by WithStyles(DateTextField))     in WithStyles(DateTextField) (created by ModalWrapper)     in ModalWrapper (created by DatePickerWrapper)     in DatePickerWrapper (at Inventory.js:246)     in div (created by FormControl)     in FormControl (created by WithStyles(FormControl))     in WithStyles(FormControl) (at Inventory.js:244)     in div (created by Grid)     in Grid (created by GridWrapper)     in GridWrapper (created by WithStyles(GridWrapper))     in WithStyles(GridWrapper) (at Inventory.js:243)     in div (created by Grid)     in Grid (created by GridWrapper)     in GridWrapper (created by WithStyles(GridWrapper))     in WithStyles(GridWrapper) (at Inventory.js:197)     in div (at Inventory.js:174)     in Inventory (created by WithStyles(Inventory))     in WithStyles(Inventory) (created by Connect(WithStyles(Inventory)))     in Connect(WithStyles(Inventory)) (at App.js:228)     in main (at App.js:381)     in div (at App.js:278)     in div (at App.js:268)     in App (created by WithStyles(App))     in WithStyles(App) (created by Connect(WithStyles(App)))     in Connect(WithStyles(App)) (at index.js:22)     in Provider (at index.js:21)

@kewl8 It's actually related to this. https://github.com/dmtrKovalenko/material-ui-pickers/issues/203
@cherniavskii This line is causing issue https://github.com/mui-org/material-ui/blob/v1-beta/src/Form/FormControl.js#L103, hope this gives you a clue about what's wrong.

Any ideas for a workaround?

@gigitux I ended up doing an ugly hack where I copied source code from FormControl (https://github.com/mui-org/material-ui/blob/v1-beta/src/Form/FormControl.js) into my own FormControlNoBlur and there I overwrote the method with handleBlur = event => {}.
Looks awful but gets the job done until the provide an api to skip blur.
Thanks @ivan-nikitovic for pointing out the issue.

https://github.com/dmtrKovalenko/material-ui-pickers/issues/217
Changing the wrapper from a FormControl to a InputLabel fixes the issue


How to add CRF layer after biLSTM output layer?

It seems that in biLSTM-CRF model only biLSTM is  trained without a CRF layer added to the output layer of biLSTM. CRF is only called after the probability of each tag for each word is predicted by loading a trained biLSTM model (in predict.py). So, the CRF only works in predicting stage rather than in training stage?

https://github.com/catnlp/PyTorchSeqLabel
This repository may help you.

So, the CRF only works in predicting stage rather than in training stage?
Not only predicting but training
training stage: https://github.com/ne7ermore/torch_light/blob/master/LSTM-CNNs-CRF/model.py#L190=
treat crf layer as a Matrix, updating it`s weights in training
predicting stage: https://github.com/ne7ermore/torch_light/blob/master/LSTM-CNNs-CRF/model.py#L74
Understanding HHM, CRF and viterbi may help you how to implement this model :)


Show pomodoro progress

Currently there is no way to see pomodoro timer progress. In Toggl Button a cicular progressmeter is shown. Should create similar or alternative way for desktop.

Maybe, a system progress bar over the icon on the bottom panel (or Mac dock) could be used?

Thank you for the feedback. We'll check if it's a suitable solution for Toggl Desktop.

Would love to see that in the trayicon on Linux!

Can be done on Windows by showing the progress on the taskbar icon using TaskbarItemInfo.ProgressState API: https://docs.microsoft.com/en-us/dotnet/api/system.windows.shell.taskbariteminfo.progressstate?view=netframework-4.8#System_Windows_Shell_TaskbarItemInfo_ProgressState


Turning the allocator into an overt exercise in data structure composition, part 1

I hope that the include/ds files are the kinds of things that might be useful more generally for tiny, embedded systems. The goal here is to offer high-level abstractions without committing to bit-level representations, to some extent mechanizing the semantic gap between diagrams on paper and bit twiddling. I was not aware of an existing library, so I wrote my own; apologies if there's something I should have used instead.
There's still plenty of clean-up possible in the allocator.  In particular, IMHO, it'd be good to get some things on the alloc path more clearly communicating in terms of MChunkHeader* / MChunk* rather than void *s pointing just past the headers.

OK, I've folded in most of David's feedback.  For ease of incremental review, I suppose, all the changes are in fixup! commits that should be --autosquashed before merging (how I wish TransArc's CM-Lite had escaped).

At long last, here is a version that, I hope, avoids UB around unconstructed objects and silently re-typed memory.

clang-tidy in CI does not like this PR for reasons beyond my understanding (it claims to have been invoked with no arguments) if I tell it to include alloc.h and alloc_config.h (or, rather, to stop excluding those).


merge from template-sync/template-arlac77-github

.github/workflows/codeql_analysis.yml

chore(actions): merge from template .github/workflows/codeql_analysis.yml

.github/workflows/update_package_lock.yml

chore(actions): merge from template .github/workflows/update_package_lock.yml

.github/workflows/update_readme_api.yml

chore(actions): merge from template .github/workflows/update_readme_api.yml

Pull Request Test Coverage Report for Build<PHONE_NUMBER>3
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 97.842%

Totals

Change from base Build<PHONE_NUMBER>2:
0.0%

Covered Lines:
416

Relevant Lines:
426

💛  - Coveralls


Fix invalid imports and schema validation code

Tests needed for index.js, the typos went through the cracks...
Also, the new loadJSON function does not throw an error when file cannot be loaded, but rather returns null. The function failed as a result when asked to provide a validation function for a schema that did not exist (Webref tests happilly request a validation function for IDL extracts and only after checks that the extracts are JSON files).

Taking the liberty to merge to release a patch version of Reffy that can actually be imported.


open some editors in the 'pending' mode

Adjust to a change in atom apis; open many editors in a 'pending' mode. This will prevent a proliferation of new editors when traversing through files.
@danrubel

LGTM


feat: add docker image build in CI

first prorotype of building docker image as a part of CI
It is currently set that on release new docker image will be built and pushed to ebrains docker registry.

I like the way you prevent the apt-cache from increasing the image size :+1:

@xgui3783 I like the way you prevent the apt-cache from increasing the image size +1

still 2GB uncompressed. =S
need to dig into dep (hopefully most is cloudvolume, but it seems numpy is pretty heavy)

also nice to have is to have a separate step that tests the built docker image, running in windows, ubuntu and macos

I tried using:
jupyter/minimal-notebook
instead of
jupyter/scipy-notebook
On my local machine the image size decreases from 4.3GB to 2.6GB.
Do we need the bigger one?

Honestly, I don't know. If all the functionalities are there, we could
definitely switch.
On Wed, 22 Dec 2021, 09:57 Vadim, @.***> wrote:

I tried using:
jupyter/minimal-notebook
https://hub.docker.com/r/jupyter/minimal-notebook
instead of
jupyter/scipy-notebook https://hub.docker.com/r/jupyter/scipy-notebook
On my local machine the image size decreases from 4.3GB to 2.6GB.
Do we need the bigger one?
—
Reply to this email directly, view it on GitHub
https://github.com/FZJ-INM1-BDA/siibra-python/pull/145#issuecomment-999400916,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AET34FYHXYYGMSTAJIQXUTLUSGHGFANCNFSM5JSINANA
.
You are receiving this because you were mentioned.Message ID:
@.***>

@xgui3783 @skoehnen
I pushed a version with a smaller base image. Could you do some quick testing if everything works for you?

size is definitely a little smaller: https://docker-registry.ebrains.eu/harbor/projects/28/repositories/siibra-python

base image
inflated
gzipped

jupyter/scipy-notebook
2.86GB
895.42MB

jupyter/minimal-notebook
2.67GB
786.34MB

I will try to report on the functionalities when/if I get a chance


automated integration tests

Investigate https://github.com/charmbracelet/vhs for this: https://www.youtube.com/watch?v=dtVezRX8OEM

Yeah. I am using expect also for testing. This looks promising.

I tried vhs a bit for testing fq but i'm having trouble making the "golden" output stable, maybe i'm doing something wrong.
@tpodowd Having any success using expect to test readline completion? having trouble with that too :)
Example tape that i tried that changes a bit with every run:
Output test.ascii

Type "fq -i . doc/file.mp3"
Enter
Sleep 0.2s
Type "repeat(empty)"
Enter
Sleep 0.5s
Enter
Ctrl+C
Sleep 0.5s
Type ".h"
Tab
Sleep 0.5s
Enter
Sleep 0.5s
Type ".frames[0] | repl"
Enter
Type ".audi"
Tab
Sleep 0.5s
Enter
Sleep 0.5s
Ctrl+D
Sleep 0.5s
Ctrl+D
Sleep 0.5s
Ctrl+D

Hi @wader - I'm going to be no help and say that for completion testing, I'm not actually testing the terminal output but instead I'm constructing tests around the AutoCompleter interface Do() function which I implement and ensuring my behaviour is right at that level as that is where my complexity is.

@tpodowd I see, no worries 👍 Yeah i do something similar but turned out the test script version of the readline works a tiny bit different so didn't catch a regression. Can post here if i figure how to do it, maybe useful for someone


Add a pre-commit config to correct style issues

This PR introduces a pre-commit config so that file changes are linted and fixed (including running clang-format) prior to committing changes.
During development, developers can install pre-commit (the tool) and then install the git pre-commit hook by running pre-commit install in the cloned codon directory. Then, before git commits changes, it will automatically run pre-commit (the tool) which will run all of the configured hooks.
NOTE: If this merges, I strongly recommend setting up pre-commit.ci to auto-fix incoming PRs if there are style issues, and to keep the pre-commit hooks up-to-date.

The CLA has been signed. If this change is desirable but needs tweaking, please let me know!


Update: Readme.md

🗣 Description
fix dockerhub tags
Document required environment variables
💭 Motivation and context
Tags were broken. Updated tag links
✅ Pre-approval checklist

[x] This PR has an informative and human-readable title.
[x] Changes are limited to a single goal - eschew scope creep!
[x] I have read the CONTRIBUTING document.
[x] These code changes follow cisagov code standards.
[x] All new and existing tests pass.

✅ Pre-merge checklist

[ ] Revert dependencies to default branches.
[ ] Finalize version.

✅ Post-merge checklist

[ ] Add a tag or create a release.

You add a dispatch workflow in this PR but make no mention of this in the PR description or title. Please remedy this oversight.

Looks like the dispatch workflow is also being added in #4, so it should either be removed from this PR or else the two PRs should be consolidated.

You add a dispatch workflow in this PR but make no mention of this in the PR description or title. Please remedy this oversight.

Looks like the dispatch workflow is also being added in #4, so it should either be removed from this PR or else the two PRs should be consolidated.

@jsf9k @dav3r i'll just go ahead and consolidate the two PRs. Closing this PR


Implement InputEventGesture (incl. Pan and Magnify) for all platforms

Operating system or device, Godot version, GPU Model and driver (if graphics related):
Current master (5a23136).
Issue description:
InputEventGesture was added to core in #12573, together with InputEventPanGesture and InputEventMagnifyGesture, but they're only implemented for macOS so far.
They should also be implemented for all platforms where they are relevant. I guess they would make sense on all platforms since gestures can be done on touchscreens as well as touchpads, so the list would be:

[ ] Android (#25474 - reverted)
[ ] iOS
[ ] Javascript
[ ] Wayland Linux and (if possible) *BSDs
[ ] X11 Linux and (if possible) *BSDs
[x] macOS (#12573)
[ ] UWP
[ ] Windows

See #12573 for the base API and its implementation on macOS.
If more types of gestures are wanted, they should likely be discussed in their own issue, let's keep this one focused on pan and magnify.

Poor BSD, it doesn't even get its own checkbox.

Poor BSD, it doesn't even get its own checkbox.

Poor Linux, it has to share its checkbox.. All X11 platforms share the same code, so they can share the same checkbox.

#25474 Merged, check Android box?

@nathanwfranke Done.

#25474 Merged, check Android box?

And reverted.

Hi, I made a gdscript (Github, Asset Library) that kind of solves this issue. I wanted to know if it's possible to integrate this gdscript to the engine.

Hi, I made a gdscript (Github, Asset Library) that kind of solves this issue. I wanted to know if it's possible to integrate this gdscript to the engine.

You can't integrate GDScript into the engine per se, you would have to translate the code to be the same format and workflow. However, since you were able to make the library you should be able to learn the engine without much issues.

I made some progress on translating my code to the engine (https://github.com/Federico-Ciuffardi/godot/commit/296fbc8225349ffab8ae74a6d3c3a6b2f2713a8d), but I'm having issues to convert my library's InputEventPinch to the InputEventMagnifyGesture as the InputEventMagnifyGesture has less attributes (factor and position) than my InputEventPinch (distance, relative, position, speed).
I don't know if here is the correct place to ask this but how would be the best way to solve this?

@Federico-Ciuffardi For whatever implementations are implemented already for iOS, those should be deleted in my opinion. Feel free to add/remove those fields as you want since Godot 4.0 is already broken for compatibility

Ok!
Another question, what is the pan gesture exactly?

I believe it is general for the drags. So like if I drag 1 finger or 20 fingers to the left that would be a pan to the left. Basically you should be able to hook them all up to a Camera2D and it would be completely functional.

It's ok if I implement the InputEvents from my library  :

InputEventPinchGesture instead of InputEventMagnifyGesture.
InputEventMultiScreenDrag (or maybe InputEventScreenMultiDrag) instead of InputEventPanGesture.
And even add a InputEventTwistGesture.
I think this could be better since it allows me to make a more direct translation. And also I think the names make more sense (not all pinch gestures have to magnify for example).

Instead of MultiScreenDrag do pan. That way if they drag with 2 fingers that would be a pan and it wouldn't be 2x faster

My implementation of MultiScreenDrag does not cause that, so the pan gesture would be the same as combining ScreenDrag and MultiScreenDrag (I do that when I use my library).

I implemented:

InputEventPinchGesture
InputEventMultiScreenDrag
InputEventTwistGesture

https://github.com/Federico-Ciuffardi/godot/tree/3.2-GDTIM
I tested this on a project that used the library modified to work without the library (using the new built-in InputEvents):
https://github.com/Federico-Ciuffardi/GestureControlledCamera2D/tree/built-in
And it's working!
I don't know how to proceed to make a pull request I would need some help :disappointed:

@Federico-Ciuffardi first, backup everything you have done on the engine a few times. It would be terrible to lose your progress. Next I would recommend following this tutorial to help you get started with git (using a tool called GitKraken)

So I just branch out form the current master branch make the changes there, and do the PR for this branch? I do not need prior approval?

Go ahead, you don't need prior approval

Hi, #37754 and #39055 have been rebased .

I'm considering implementing this for X11 using the XInput extension (see https://gitlab.freedesktop.org/xorg/lib/libxi/-/merge_requests/5). Is it worth the shot given the existence of https://github.com/godotengine/godot/pull/39055 ?

For the record, the Wayland PR (#57025) supports both InputPanGesture and InputMagnifyGesture ;)

It says that #86180 is merged, but in 4.3 beta 2 I'm still seeing the problematic behavior from #73371. Why is that?

@eobet are you running the editor with prefer_wayland enabled in the editor settings?

Ah, right! Thank you I wasn't aware of it. Boy that made a difference in font rendering! But now I think I'm experiencing #49873 instead... :sweat_smile:

Yeah that's a generic issue unfortunately AFAIK. The relative UI controls ought to be fixed directly.

That's unfortunate but thanks for the info. One thing I did notice, though is that middle mouse button panning in the shader editor is not 1:1 using "prefer wayland". Are you aware of such an issue?


Add graphql API support for testing environment

Any update on adding support for graphql endpoints? Noticed that this PR has been open for a while.


Implemented graphs per office

With the changes introduced, graphs will be displayed per office rather
than across the whole service, for the week gone.

Apart from the rubocop it looks fine!

I'm aware of the broken spec, fixing it now!

Looks good :+1:

Merging now.


qtum compile error

Hi, I followed the Quickstart  instructions , and met an error on my ubuntu 14.04, with newest code, could anyone have a look at it ?
error info is attached.
compile_error_info.txt

Try using gcc 5 or 6.

Please try following the new instructions from #226 and see if that resolves the problem

Closing. Please file another issue if those instructions did not resolve your problem


Extra Annotation methods

While writing https://github.com/crystal-lang/crystal-book/pull/335, I came across some places that annotations fall a bit short, mainly around positional values.  The Annotation macro class could do with some extra methods.
Currently positional arguments can only be accessed if the user knows how many there will be at compile time.  I.e. accessing each one with a NumberLiteral.  However this makes it not very useful IMO.
I was thinking of adding:

size - Would return the total number of arguments on the annotation (positional + named).

Would allow for dynamic access of positional args.

{% for idx in 0...Type.annotation(MyAnnotation).size %}.
idx could then be used to access the positional value on the annotation.
If named arguments were used as well, accessing them would just return nil.

keys - Would return the keys of all named arguments on the annotation.

Would allow for reading values off of an annotation in a loop.

values - Would return all positional values (and maybe named arg values?)

Would allow looping over the values themselves, without directly having to read them off the annotation.  Most useful for positional values.

My main concerns are if an annotation has both positional AND named arguments, what should the values method return?  Or, how should iterating using size work if you have a named argument with the same key as the index?
Possibly could have separate methods for values/size?  One for positional and another for named arguments?
Thoughts?

A quick thought would be to have a system similar to regular method that accept arbitrary number of pos/named args: with (named)tuple.
For annotation it could look like: ann.pos_args & ann.named_args, so for:
@[Foo(1, '2', extra: "three")

# you can do (in macros):
ann = ... get the annotation
ann.pos_args # => {1, '2'}
ann.named_args # => {extra: "three"}

The size would simply be ann.pos_args.size + ann.named_args.size, etc...
This way you can reuse existing data structure usable from macros! (and that's a big +++)

I like that, and be returning a namedTuple, you inherently get keys/values/size.  I can make a PR for this later today.
:100:

@Blacksmoke16 Why is this useful? (I can see why it's useful, but what use cases do you have in mind?)

@asterite My initial idea was https://github.com/Blacksmoke16/CrSerializer/issues/8, but it wasn't until I was writing up the annotation docs that I realized that it wouldn't be possible as there was no way to know how many positional arguments there are, or a way to iterate over each one.
I don't really have any other "omg this would be perfect for x" use cases; it was more so something I just felt was missing and felt like it should be possible.
However, after trying out having nested annotations within an annotation, that would require work as the compiler thinks they are GenericType.  But that can be another PR.
annotation Any; end
annotation Foo; end

@[Any(Foo(0), Foo(1))]
class Klass
end

{% for ann in Klass.annotation(Any).pos_args %}
  pp {{ann[0]}}
{% end %}

Error in test.cr:8: expanding macro

{% for ann in Klass.annotation(Any).pos_args %}
^

in test.cr:9: undefined macro method 'Generic#[]'

  pp {{ann[0]}}
          ^

in test.cr:4: undefined macro method 'Generic#[]'

@[Any(Foo(0), Foo(1))]


Support Gogs webhook

Contribution Type: new feature
Link to Intent to Implement: —
Link to Bug: #1243
This pull request affects the following areas:

[x] Webhook API

In raising this pull request, I confirm the following (please check boxes):

[x] I have read and understood the contributing guidelines?
[x] I have checked that another pull request for this purpose does not exist.
[x] I have considered, and confirmed that this submission will be valuable to others.

Detailed description of change:

Gogs webhook that is based github

https://gogs.io/docs/features/webhook.html

Hello,
I can't see this commit into the master branch, did i miss something ?
(need to replace gogs type => remote to make it work


setting binary mode by default

hi! I'm using trycmd to test a utility that generates source code. As part of that, I need \ to not be escaped. Hypothetically, I could use binary mode to accomplish this, but I'm also testing that the invocations in my README are valid, and I don't see anything in the docs that will let me set binary mode. So: can we have a flag on TestCases or similar to set binary mode by default, please?
By the way, it took me an unpleasant amount of time to begin to suspect the test harness was mangling my output. If it were up to me, that wouldn't be the default. I get why it's there (from reading #91) and that it's probably too late to change, but documentation in the trycmd crate would have helped. Would you be open to a PR to say what's going on there? (Or, really, for any of this?)

While not global, you can set binary on a per-test basis
https://github.com/assert-rs/snapbox/blob/62ce68decd010b3727700ff04660642ac7c8d42e/crates/trycmd/schema.json#L72-L75
Something I've been considering with structured data support is how to expose control over it, including opting in and opting out, see #93
As this has a lot of overlap with #93, I lean towards closing this and centralizing the conversation there so we can come up with a solution that keeps both use cases in mind.  If there is a reason you think this should be kept open separately, let us know!

I know I can set it on a per-test basis, but not in a Markdown file… unless I've misunderstood something?

actually, I tried this just now and it doesn't look like it works. The backslashes in my output are still being converted to forward slashes. Here's the TOML file I'm using; does it look right to you?
bin.name = "elm-duet"
args = ["schema.json"]
binary = true

Oh right, that only controls the programs input/output.
I'm working some of the underpinings for trycmd at the