[WIP] Support external/pre-provisioned authoritative cluster DNS

What does this PR do?
Allow to provision DNS server(s) once, when only update its records for consequent provision playbook runs, for example is scaling up/down.
Also allow to not provision DNS servers as the part of the Heat stack and go with fully external DNS.
How should this be manually tested?
Fully external DNS server:

Deploy s DNS server and populate an inventory file (e.g. inventory/external_dns.yaml) with its nsupdate data
Run provision openstack with app nodes count of 1 and dns nodes count of 0, and add<EMAIL_ADDRESS>for the ansible-playbook commands used
Finish e2e (it shall pass)
Run provision openstack with app nodes count of 2 and dns nodes count of 0 and add<EMAIL_ADDRESS>for the ansible-playbook commands used
Finish e2e (it shall pass)
Check if all app nodes' FQDNs are resolvable via your external DNS

Pre-provisioned with Heat stack DNS server:

Provision a DNS server as a member of Heat stack then populate an inventory file (e.g. inventory/external_dns.yaml) with its nsupdate data provided in the post-provision playbook debug output
Run provision openstack with app nodes count of 1 and dns nodes count unchanged, and add<EMAIL_ADDRESS>for the ansible-playbook commands used
Finish e2e (it shall pass)
Run provision openstack with app nodes count of 2 and dns nodes count unchanged, and add<EMAIL_ADDRESS>for the ansible-playbook commands used
Finish e2e (it shall pass)
Check if all app nodes' FQDNs are resolvable via your external (pre-provisioned) DNS

Is there a relevant Issue open for this?
Who would you like to review this?
cc: @tomassedovic @oybed PTAL

What works: (pre-provisioned DNS server from a heat stack) it updates its records with unchanged secrets for consequent provision openstack playbook runs.
What doesn't work yet: nslookup for cluster domain does not resolve via the configured DNS server's floating IP (NXDOMAIN). So the example external_nsupdate_keys I use for testing is wrong, it seems. Need help with this @tomassedovic @oybed please.

You can also update and use this example playbook to test the dynamic updates.

When I scale the app nodes 1->2, cluster nodes can resolve the new node FQDN after the nsupdates done via the external server. But the new app nodes, even though has the mirror configuration to the app-node-0, can't resolve cluster nodes names. I have to debug this.

@bogdando Ahh, yes, you have hit a bit of a bug in the dns implementation in infra-ansible. Basically the ACLs needs to be updated on the bind server, but this doesn't happen with just adding a new private record through the use of the dns role (and nsupdate underneath). The solution may be to open up the ACLs a bit more as right now they are entered as /32 entries. If we knew the subnet size, we could just add the entire subnet as a private portion of the setup. I'll take a look to see if we can come up with a solution to automatically detect the subnet size and pass that to the dns-server role.

@oybed thanks! we have the openshift cluster subnet defined in the inventory vars. But yeah, we need a generic solution for the dns modules

@bogdando Looked into the missing ACL a bit more; the code should be idempotent, so you should be able to add new instances and just re-run the dns-server role to get the ACL updated - i.e.: these lines:
https://github.com/openshift/openshift-ansible-contrib/blob/master/playbooks/provisioning/openstack/post-provision-openstack.yml#L56-L57
I've also submitted an enhancement PR against the dns-server to ensure that any minor changes will restart the server to ensure the configuration is running correctly:
https://github.com/redhat-cop/infra-ansible/pull/63

@oybed I hoped to not invoke the dns-server role w/o need, like this. It takes time, and is not idempotent IIRC, as it regens the secrets on each run

@bogdando  this won't work when using both a provisioned and external DNS (i.e.: provisioned for internal use and external for external use). Also the role is idempotent - it only generates secrets if not found (and to force a new key you just have to delete the proper key before a re-run). .

So the private/public_dns_server is auto-detected OK, but duplicating nsupdate_server_private/public logic spoils this up. I think the latter must be just removed. @tomassedovic @oybed perchance, do you know how come we have those duplicating vars?

With the https://github.com/openshift/openshift-ansible-contrib/pull/623/commits/c24d4f65af16b2728e20e80a380496c64d7cd9cf it works for me. We'll have a call with @oybed to discuss the details as it is not clear why these complex changes are needed and what is already works out of box/what does not.

Yeah, so now it works. The only thing is that debug message does not expand the updated fact, it keeps showing the original inventory value I passed in:
    "external_nsupdate_keys": {
        "private-openshift.cluster.lc": {
            "instack": true,
            "public_access": true
        },
        "public-openshift.cluster.lc": {
            "instack": true
        }
    }

While in fact, dynamic updates are sent with the autocompleted nsupdate data for my pre-provisioned instack DNS server:
TASK [dns-server-detect : set_fact] **********************************************************************************************************************************************
Tuesday 22 August 2017  18:49:17 +0200 (0:00:00.047)       0:02:22.367 ********
ok: [localhost] => {"ansible_facts": {"external_nsupdate_keys": {"private": {"instack": true, "public_access": true}, "public": {"instack": true, "key_algorithm": "HMAC-SHA256", "key_secret": "iiVksjYRCiIeazZudkKOlzgmyhUjmIzIic/67Uk6Xbs=", "server": "<IP_ADDRESS>"}}}, "changed": false}

TASK [dns-server-detect : set_fact] **********************************************************************************************************************************************
Tuesday 22 August 2017  18:49:17 +0200 (0:00:00.048)       0:02:22.415 ********
ok: [localhost] => {"ansible_facts": {"external_nsupdate_keys": {"private": {"instack": true, "key_algorithm": "HMAC-SHA256", "key_secret": "mm7iy41AN054T3FXqgpOGHFE7qZRWEMzR8Pq3Efp5vg=", "public_access": true, "server": "<IP_ADDRESS>"}, "public": {"instack": true}}}, "changed": false}

which is odd, but not a fatal thing to fix.

@oybed @tomassedovic the 'allow custom public key names' commit is needed for OSP 10 ref arch compatibility. Here is an example output for the mixed instack/OSP10 external DNS case: https://pastebin.com/QpMrm4EC .  And an example inventory vars used for that deploy.
So this works now \o/
I updated the how-to test scenarios in the caption. So try this out please.

Only dynamic updates work as expected. And e2e fails as the cluster hosts get a public IP for the private nameserver. I use public_access: true for my external control node, so the private_dns_nameserver gets the public IP for sending updates to the private view. This is expected, but doesn't fit internal use for cluster hosts. They need a private IP.

e2e passes for me

I'll revise the changes once again

reworked as https://github.com/openshift/openshift-ansible-contrib/pull/690


MRG, FIX, ENH: First_samp support and simulation tests

Reference issue
Fixes #9120.
What does this implement/fix?
Modified mne.simulation.raw.simulate_raw() and mne.simulation.source.SourceSimulator to properly interpret first_samp parameter.  Adding events to a SourceSimulator would not account for any sample offsets, such that the resulting raw data created with simulate_raw() would have shifted event-aligned waveforms regardless of the first_samp argument.
Additional information
In order to properly effect the sample offset change, I reinterpreted the duration argument  of the SourceSimulator constructor to more intuitively match the first and last sample indices.
This PR also corrects a small inconsistency with HPI coils whereby an arbitrary entry was made if the first HPI data point wasn't at time = 0.

The stc paramter types for simulate_raw() need to be updated (originally mentioned by @agramfort)
I have already applied a number of other small suggestions & changes

Sorry - I 've been traveling and I just saw these comments.  Thank you for the additional suggestions and changes, @agramfort and @hoechenberger.  I'll look over the current code state and resolve anything outstanding.

Perfect! Please ping me once you're done :)

Thank you, @NeuroLaunch!

Whoops, seems I merged too soon :<


builder macro to make example test output table

If a different test function is generated for each folder (or hlog file), the utest output will be vastly more helpful as you'll be able to see at a glance which examples are broken

builder macros can't add utest test functions so this won't work


Add the ability to discard history more flexibly

Currently the only way to discard history is via the historic tag. One problem with this approach is that sometimes you do not have control over the update being sent to the editor, thus making it impossible to append any tags to the change.
My proposal is to allow a discardHistory option to be passed to registerHistory which allows a more dynamic way to prevent history from being pushed.
Example below:
https://github.com/facebook/lexical/assets/27902567/1cacdc9a-0dec-4244-80c5-9f2c30361e4e

I don't think you need a PR to do this, I haven't tested this or thought too much about what the current or redoStack should be but something along these lines ought to work
import { useState, useRef } from 'react';
import {createEmptyHistoryState, HistoryPlugin} from '@lexical/history';

export default function DiscardHistoryPlugin({ discard = false }: { discard: boolean }) {
  const [history, setHistory] = useState(createEmptyHistoryState);
  const historyRef = useRef(history);
  useEffect(() => {
    if (discard) {
      // save a copy of the history from before discard=true
      historyRef.current = {...history};
    } else {
      // restore the history redoStack & undoStack unless the initial state was discard=false
      setHistory((curHistory) => curHistory === historyRef.current ? curHistory : { ...historyRef.current, current: curHistory.current });
    }
  }, [discard]);
  return (<HistoryPlugin history={history} />);
}

I don't think you need a PR to do this, I haven't tested this or thought too much about what the current or redoStack should be but something along these lines ought to work
import { useState, useRef } from 'react';
import {createEmptyHistoryState, HistoryPlugin} from '@lexical/history';

export default function DiscardHistoryPlugin({ discard = false }: { discard: boolean }) {
  const [history, setHistory] = useState(createEmptyHistoryState);
  const historyRef = useRef(history);
  useEffect(() => {
    if (discard) {
      // save a copy of the history from before discard=true
      historyRef.current = {...history};
    } else {
      // restore the history redoStack & undoStack unless the initial state was discard=false
      setHistory((curHistory) => curHistory === historyRef.current ? curHistory : { ...historyRef.current, current: curHistory.current });
    }
  }, [discard]);
  return (<HistoryPlugin history={history} />);
}

Honestly, not sure I follow you here. That snippet is not accomplishing the goal of this PR. Also, it should probably trigger an infinite loop once you pass history as a dependency.

I don't think you need a PR to do this, I haven't tested this or thought too much about what the current or redoStack should be but something along these lines ought to work
import { useState, useRef } from 'react';
import {createEmptyHistoryState, HistoryPlugin} from '@lexical/history';

export default function DiscardHistoryPlugin({ discard = false }: { discard: boolean }) {
  const [history, setHistory] = useState(createEmptyHistoryState);
  const historyRef = useRef(history);
  useEffect(() => {
    if (discard) {
      // save a copy of the history from before discard=true
      historyRef.current = {...history};
    } else {
      // restore the history redoStack & undoStack unless the initial state was discard=false
      setHistory((curHistory) => curHistory === historyRef.current ? curHistory : { ...historyRef.current, current: curHistory.current });
    }
  }, [discard]);
  return (<HistoryPlugin history={history} />);
}

Honestly, not sure I follow you here. That snippet is not accomplishing the goal of this PR. Also, it should probably trigger an infinite loop once you pass history as a dependency.
The problem is that there is no way to intercept editor changes when discard = true to prevent them from being pushed to the undoStack.

Closing this PR due to staleness! If there are new updates, please reopen the PR.


custom canvas painter

In canvas mode, danmaku just stroke and fill the text, but in many scenes, there is a need to draw some other element, like image, rectangle, triangle...
Can we add a paint function in cmt which can custom the canvas draws like this:
danmaku.emit({
  width: 50,
  height: 50,
  paint: function (ctx) {
    ctx.drawImage(img, 0, 0)
  }
 })

and in commentCanvas.js:
  if (typeof cmt.paint === 'function') {
    cmt.paint(ctx);
  } else {
    if (style.strokeStyle) {
      ctx.strokeText(cmt.text, strokeWidth, baseline);
    }
    ctx.fillText(cmt.text, strokeWidth, baseline);
  }

The render option of emit API is available in v1.3.0, you can find details in README.


KAFKA-8977: Remove MockStreamsMetrics since it is not a mock

Removed the references to MockStreamsMetrics since it actually was not a mock, instead used Mockito to mock the implementations. With this, we achieve better isolation of unit tests. In some unit tests the StreamsMetricsImpl implementation is used to assert the values and hence cannot be mocked. However, MockStreamsMetrics is removed from the majority of the unit tests where it is referenced.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

@cadonna could you please have a look at this PR ?

@cadonna i have addressed the comments, could you please have a look

Hi @cadonna ,
As per the comment, I've setup mocks and verified the calls on it, also addressed other comments as well, please have a look.

@cadonna i've addressed the changes and fixed merge conflicts, could you please take a look

@joobisb Could you please fix the compilation errors?

@joobisb Could you please fix the compilation errors?

@cadonna done

@joobisb any updates?


[tryceratops] Add BaseException to raise-vanilla-class rule (TRY002)

Fixes #12612

Code looks good to me. We only have to decide on https://github.com/astral-sh/ruff/issues/12612#issuecomment-2263942167

This makes sense to me. It's unfortunate to deviate from tryceratops here, but I think it definitely makes sense to include BaseException as well as Exception.
Should we also include ExceptionGroup and BaseExceptionGroup, though? (That's a genuine question that I'm not sure the answer to -- I haven't had much opportunity to use these fancy new features yet! It might be that they belong in this rule, or it might be that they deserve their own rule... not sure.)

Let's land this for now, we can tackle the ExceptionGroup and BaseExceptionGroup issues as a followup. I think this is a strict improvement.
Thanks @epenet!


Monomorphization of 'cached_statement'

For context, see: https://matklad.github.io/2021/09/04/fast-rust-builds.html#Keeping-Instantiations-In-Check
This PR attempts to preserve the API used by the statement_cache, but attempts to monomorphize over the underlying QueryFragment + QueryId type.
The generics in the statement cache appear to be:

The DB backend
The QueryFragment + QueryId type

Although it probably makes sense to preserve being generic over the backend, duplicating this code for each query type results in a noticeable binary bloat. In a debug build of https://github.com/oxidecomputer/omicron , this change reduces the binary size by ~620 KiB.
I'm putting forward this PR as a bit of an experiment -- I think there are many other spots (for example, over the connection types) where we're generic over the QueryFragment + QueryId types, and for which we generate a significant amount of code for each query. I think, in the limit, it should be possible to generate this code "once per backend", and monomorphize more of the "per-query" codepaths.

Thanks for opening this PR :+1:. I think this might be a good idea, but we really need to make sure that we don't regress performance over that. I've triggered a benchmark run on the CI and the results there look fine. See for example https://github.com/diesel-rs/diesel/actions/runs/6097519380/job/16545313665?pr=3778 (The critcmp step has the results). Now that's running on the CI and therefore it's likely noisy. So it might be worth to run the benchmarks again locally and verify these results (maybe even with the instruction count mode?).
Other than that: I also rebased the PR to fix the unrelated CI failures. The remaining CI failure was introduced with the change (essentially clippy being pedantic about things).

I've pushed another commit that fixes the perf based instruction count benchmark metrics.
You can run these benchmark from the diesel_bench folder via
# once for master
DATABASE_URL=/tmp/test.db cargo +stable bench --no-default-features --features="sqlite instruction_count fast_run" -- --save-baseline master
# for the change, should show changes
DATABASE_URL=/tmp/test.db cargo +stable bench --no-default-features --features="sqlite instruction_count fast_run" -- --baseline master

There are features for the other backends as well. instruction_count enables the perf based metrics, without that wall time is used. fast_run disables certain benchmark sizes.
These metrics show a slight regression:

 Benchmark results
bench_trivial_query/diesel/1
                        time:   [6198.2000 cycles 6198.2246 cycles 6198.2550 cycles]
                        change: [+1.3840% +1.3970% +1.4146%] (p = 0.00 < 0.05)
                        Performance has regressed.
Found 12 outliers among 100 measurements (12.00%)
  5 (5.00%) high mild
  7 (7.00%) high severe
bench_trivial_query/diesel_boxed/1
                        time:   [12299.9480 cycles 12303.6940 cycles 12309.0331 cycles]
                        change: [+0.8329% +0.8780% +0.9180%] (p = 0.00 < 0.05)
                        Change within noise threshold.
Found 21 outliers among 100 measurements (21.00%)
  12 (12.00%) high mild
  9 (9.00%) high severe
bench_trivial_query/diesel_queryable_by_name/1
                        time:   [25007.8800 cycles 25042.6383 cycles 25057.8212 cycles]
                        change: [+0.5276% +0.6429% +0.6825%] (p = 0.00 < 0.05)
                        Change within noise threshold.
Found 9 outliers among 100 measurements (9.00%)
  1 (1.00%) low severe
  5 (5.00%) high mild
  3 (3.00%) high severe
Benchmarking bench_trivial_query/diesel/10000: Warming up for 3.0000 s
Warning: Unable to complete 100 samples in 5.0s. You may wish to increase target time to 8.4s, enable flat sampling, or reduce sample count to 50.
bench_trivial_query/diesel/10000
                        time:   [23800830.4051 cycles 23800974.1808 cycles 23801127.5047 cycles]
                        change: [-0.0083% -0.0023% +0.0040%] (p = 0.50 > 0.05)
                        No change in performance detected.
Found 9 outliers among 100 measurements (9.00%)
  3 (3.00%) high mild
  6 (6.00%) high severe
Benchmarking bench_trivial_query/diesel_boxed/10000: Warming up for 3.0000 s
Warning: Unable to complete 100 samples in 5.0s. You may wish to increase target time to 8.4s, enable flat sampling, or reduce sample count to 50.
bench_trivial_query/diesel_boxed/10000
                        time:   [23808058.6217 cycles 23808192.7746 cycles 23808328.0193 cycles]
                        change: [+0.0002% +0.3030% +0.8429%] (p = 0.18 > 0.05)
                        No change in performance detected.
Found 7 outliers among 100 measurements (7.00%)
  2 (2.00%) high mild
  5 (5.00%) high severe
Benchmarking bench_trivial_query/diesel_queryable_by_name/10000: Warming up for 3.0000 s
Warning: Unable to complete 100 samples in 5.0s. You may wish to increase target time to 9.3s, enable flat sampling, or reduce sample count to 50.
bench_trivial_query/diesel_queryable_by_name/10000
                        time:   [27274391.3732 cycles 27424965.6166 cycles 27491082.4160 cycles]
                        change: [-1.1312% -0.3410% -0.0696%] (p = 0.18 > 0.05)
                        No change in performance detected.
Found 19 outliers among 100 measurements (19.00%)
  1 (1.00%) low severe
  18 (18.00%) high severe

bench_medium_complex_query/diesel/1
                        time:   [23138.9929 cycles 23142.9749 cycles 23147.0767 cycles]
                        change: [+1.0488% +1.0920% +1.1364%] (p = 0.00 < 0.05)
                        Performance has regressed.
Found 5 outliers among 100 measurements (5.00%)
  3 (3.00%) high mild
  2 (2.00%) high severe
bench_medium_complex_query/diesel_boxed/1
                        time:   [38380.0018 cycles 38425.1353 cycles 38470.8968 cycles]
                        change: [+0.9967% +1.1475% +1.2910%] (p = 0.00 < 0.05)
                        Change within noise threshold.
bench_medium_complex_query/diesel_queryable_by_name/1
                        time:   [81003.7369 cycles 81011.5802 cycles 81018.9495 cycles]
                        change: [+0.6097% +0.6162% +0.6236%] (p = 0.00 < 0.05)
                        Change within noise threshold.
Benchmarking bench_medium_complex_query/diesel/10000: Warming up for 3.0000 s
Warning: Unable to complete 100 samples in 5.0s. You may wish to increase target time to 8.7s, enable flat sampling, or reduce sample count to 50.
bench_medium_complex_query/diesel/10000
                        time:   [22916615.1137 cycles 22984558.8302 cycles 23015564.6610 cycles]
                        change: [-0.4260% -0.1848% -0.0017%] (p = 0.09 > 0.05)
                        No change in performance detected.
Found 12 outliers among 100 measurements (12.00%)
  2 (2.00%) low severe
  3 (3.00%) high mild
  7 (7.00%) high severe
Benchmarking bench_medium_complex_query/diesel_boxed/10000: Warming up for 3.0000 s
Warning: Unable to complete 100 samples in 5.0s. You may wish to increase target time to 9.0s, enable flat sampling, or reduce sample count to 50.
bench_medium_complex_query/diesel_boxed/10000
                        time:   [23030128.6204 cycles 23030384.0231 cycles 23030632.6621 cycles]
                        change: [-0.0215% -0.0051% +0.0092%] (p = 0.54 > 0.05)
                        No change in performance detected.
Found 15 outliers among 100 measurements (15.00%)
  6 (6.00%) high mild
  9 (9.00%) high severe
Benchmarking bench_medium_complex_query/diesel_queryable_by_name/10000: Warming up for 3.0000 s
Warning: Unable to complete 100 samples in 5.0s. You may wish to increase target time to 9.7s, enable flat sampling, or reduce sample count to 50.
bench_medium_complex_query/diesel_queryable_by_name/10000
                        time:   [27989809.7144 cycles 27990302.2189 cycles 27990831.0977 cycles]
                        change: [-0.3170% -0.2651% -0.2129%] (p = 0.00 < 0.05)
                        Change within noise threshold.
Found 9 outliers among 100 measurements (9.00%)
  6 (6.00%) low mild
  1 (1.00%) high mild
  2 (2.00%) high severe

bench_loading_associations_sequentially/diesel/bench_loading_associations_sequentially
                        time:   [3869630.0091 cycles 3870933.5961 cycles 3872166.2909 cycles]
                        change: [-0.0627% -0.0260% +0.0085%] (p = 0.17 > 0.05)
                        No change in performance detected.
Found 2 outliers among 100 measurements (2.00%)
  1 (1.00%) low severe
  1 (1.00%) low mild

bench_insert/diesel/1   time:   [20369.7704 cycles 20371.3994 cycles 20373.5267 cycles]
                        change: [+0.9084% +0.9501% +0.9948%] (p = 0.00 < 0.05)
                        Change within noise threshold.
Found 2 outliers among 100 measurements (2.00%)
  2 (2.00%) high mild
bench_insert/diesel/100 time:   [464065.9954 cycles<PHONE_NUMBER> cycles<PHONE_NUMBER> cycles]
                        change: [+0.0345% +0.1594% +0.2846%] (p = 0.00 < 0.05)
                        Change within noise threshold.
Found 6 outliers among 100 measurements (6.00%)
  3 (3.00%) low mild
  1 (1.00%) high mild
  2 (2.00%) high severe

I should probably add that the bench_trivial_query/diesel/1 really stresses the query builder performance as that one runs with < 500ns per iteration for the sqlite backend. Nevertheless it would be great if we can slightly tweak the change to not regress that benchmark.

Thanks for the tips on running the benchmarks. After collapsing the function cache_statement function I'm seeing the following:
bench_trivial_query/diesel/1
                        time:   [7513.5419 cycles 7513.5760 cycles 7513.6181 cycles]
                        change: [+0.6409% +0.6560% +0.6727%] (p = 0.00 < 0.05)
                        Change within noise threshold.
Found 14 outliers among 100 measurements (14.00%)
  6 (6.00%) high mild
  8 (8.00%) high severe
bench_trivial_query/diesel_boxed/1
                        time:   [13601.5529 cycles 13606.8259 cycles 13612.3762 cycles]
                        change: [+0.0768% +0.1424% +0.2082%] (p = 0.00 < 0.05)
                        Change within noise threshold.
Found 1 outliers among 100 measurements (1.00%)
  1 (1.00%) high mild
bench_trivial_query/diesel_queryable_by_name/1
                        time:   [45657.2723 cycles 45721.3604 cycles 45783.4704 cycles]
                        change: [+0.1898% +0.3402% +0.5006%] (p = 0.00 < 0.05)
                        Change within noise threshold.
Found 2 outliers among 100 measurements (2.00%)
  2 (2.00%) low mild
bench_trivial_query/diesel/10000
                        time:   [25514648.0319 cycles 25514763.6448 cycles 25514877.8544 cycles]
                        change: [-0.0020% -0.0009% +0.0002%] (p = 0.13 > 0.05)
                        No change in performance detected.
Found 1 outliers among 100 measurements (1.00%)
  1 (1.00%) low mild
bench_trivial_query/diesel_boxed/10000
                        time:   [25520424.0499 cycles 25520545.0000 cycles 25520664.7091 cycles]
                        change: [-0.0045% -0.0038% -0.0031%] (p = 0.00 < 0.05)
                        Change within noise threshold.
Found 4 outliers among 100 measurements (4.00%)
  3 (3.00%) low mild
  1 (1.00%) high mild
bench_trivial_query/diesel_queryable_by_name/10000
                        time:   [29056280.9355 cycles 29059091.6455 cycles 29062285.6926 cycles]
                        change: [-0.1017% -0.0762% -0.0520%] (p = 0.00 < 0.05)
                        Change within noise threshold.
Found 12 outliers among 100 measurements (12.00%)
  2 (2.00%) high mild
  10 (10.00%) high severe
bench_medium_complex_query/diesel/1
                        time:   [26607.8522 cycles 26612.4192 cycles 26616.8591 cycles]
                        change: [+0.7455% +0.8051% +0.8669%] (p = 0.00 < 0.05)
                        Change within noise threshold.
Found 6 outliers among 100 measurements (6.00%)
  3 (3.00%) high mild
  3 (3.00%) high severe
bench_medium_complex_query/diesel_boxed/1
                        time:   [41745.1819 cycles 41782.9852 cycles 41821.8198 cycles]
                        change: [+0.2140% +0.3290% +0.4513%] (p = 0.00 < 0.05)
                        Change within noise threshold.
bench_medium_complex_query/diesel_queryable_by_name/1
                        time:   [151545.4151 cycles<PHONE_NUMBER> cycles<PHONE_NUMBER> cycles]
                        change: [+0.1531% +0.2241% +0.2975%] (p = 0.00 < 0.05)
                        Change within noise threshold.
Found 1 outliers among 100 measurements (1.00%)
  1 (1.00%) high mild
bench_medium_complex_query/diesel/10000
                        time:   [26583961.0174 cycles 26586573.8940 cycles 26589168.5516 cycles]
                        change: [+0.0561% +0.0669% +0.0786%] (p = 0.00 < 0.05)
                        Change within noise threshold.
bench_medium_complex_query/diesel_boxed/10000
                        time:   [26597067.0640 cycles 26599956.1780 cycles 26602904.5400 cycles]
                        change: [+0.0553% +0.0662% +0.0781%] (p = 0.00 < 0.05)
                        Change within noise threshold.
Found 3 outliers among 100 measurements (3.00%)
  3 (3.00%) high mild
bench_medium_complex_query/diesel_queryable_by_name/10000
                        time:   [31474268.8008 cycles 31477961.2672 cycles 31481803.1718 cycles]
                        change: [+0.0479% +0.0629% +0.0774%] (p = 0.00 < 0.05)
                        Change within noise threshold.
Found 2 outliers among 100 measurements (2.00%)
  2 (2.00%) high mild

bench_loading_associations_sequentially/diesel/bench_loading_associations_sequentially
                        time:   [4218133.4062 cycles 4218710.5240 cycles 4219253.4612 cycles]
                        change: [+0.5893% +0.6085% +0.6295%] (p = 0.00 < 0.05)
                        Change within noise threshold.
Found 4 outliers among 100 measurements (4.00%)
  1 (1.00%) low severe
  3 (3.00%) low mild

bench_insert/diesel/1   time:   [23336.2704 cycles 23339.1313 cycles 23341.4995 cycles]
                        change: [+0.4308% +0.5060% +0.5516%] (p = 0.00 < 0.05)
                        Change within noise threshold.
bench_insert/diesel/100 time:   [471449.7597 cycles<PHONE_NUMBER> cycles<PHONE_NUMBER> cycles]
                        change: [+0.9371% +1.1286% +1.3177%] (p = 0.00 < 0.05)
                        Change within noise threshold.
Found 8 outliers among 100 measurements (8.00%)
  5 (5.00%) low mild
  3 (3.00%) high severe

I think these results make sense -- it's performing a very minor amount of dynamic dispatch, so for a "single query case" I wouldn't expect performance to be better. For a significant number of distinct queries, however, it should reduce code size, which could relieve some pressure from the instruction cache by simply producing less code.


Is there a document or any others that explains the basis and source of all validators?

Is there a document or any others that explains the basis and source of all validators?
For example, to indicate that a validator is from section x.x.x of the RFC.

Hi @zzzsz,
For the CABF S/MIME and TLS BR validations, there are finding_metadata.csv files in the source tree.
More easily discoverable citations are planned to resolve #64.

Closing; better documentation will be provided as part of #64.


vNEXT Proposal: Demos should use the default config profile

Overview
Currently we have some custom configuration profiles for the demo examples. Ideally we'd like new users who are starting out to not have to choose profiles when they press configure the first time.
Currently if you download the sdk and the examples, you'll need to assign the correct profile if more than the default exists because Diagnostics has it's own custom configuration profile. ( a confused new comer had to ping me to ask which the right one was ).

Ideally most/all of our demo scripts should use the default configuration profiles and should be created with that in mind.

I do like the idea of dynamically adding speech commands.
Likely the input actions won't have to be updated to make demos work correctly.


How to create a mutiple chrome webdriver instances

As a part of my project I need to create multiple sessions so I am trying to create multiple webdriver instance to create multiple session. When I try to create a new instance using new WebDriverTestCase().getDriver(), it is opening in the same chrome browser instead of opening in new window.
Is there any method available in QAF to create multiple chrome driver instances in multiple windows instead of opening in the same window

Will you please explain your use case, What you are trying to achieve? Do you want to run your test in parallel or within the test you need to open multiple browser session?

Within the test I need to open multiple browser session. As per my test scenario, I need to test the error message once I reached the threshold by opening multiple sessions and login.
I have tried to open tabs and open windows but both of the method are sharing the same session instead of creating multiple sessions.

It looks like performance test and not a functional test for that you should use performance testing tools like JMeter.
If that is not the case you can create new driver using UiDriverFactory.get(ArrayList<LoggingBean> commandLog, String[] stb) and make sure you are calling UiDriverFactory.tearDown(UiDriver driver) for each created driver instance once you are done.

Is there a way to configure the multiple devices from the properties file?
Will I have 2 separate reports? I need one flow report

@hadasshani yes you can have multiple devices configured in properties.
Closing inactive issue. Please post question in user group.


Twitter account for Spaceship ZSH

Is your feature request related to a problem? Please describe.
Thanks to @salmanulfarzy we have a pretty comprehensive changelog. However, I feel like we need a place for posting updates about the project, getting feedback and answering support questions.
Describe the solution you'd like
I think I'd be great to have a Twitter account for Spaceship ZSH. It can be managed by me, @salmanulfarzy and @maximbaz. What do you, guys, think?

Sounds great for product updates with crediting authors 👍

i find a telegram group a better way to exchange

Sounds nice :) however I'm not registered on Twitter / Telegram, so I won't promise a big involvement from myself, I like the good old Github 😄

I thought about gitter and after sometime on gitter with repositories. Apart from it's awesome integration with GitHUb, learned discussions get diverged on GitHub or Gitter. So to get a complete picture of something users and contributors had to check both of them. So I rarely check them nowadays.
With twitter, We could do updates and some basic support questions, For anything more that I would prefer GitHub.

With twitter, We could do updates and some basic support questions, For anything more that I would prefer GitHub.

I share the same point of view.

Here we go: https://twitter.com/SpaceshipZSH
Now we need to add a badge in README to let people know about it. Also, @salmanulfarzy, I'd love to mention this account in the next release notes.

Twitter suspended our account:

Setting the date of the initial commit as a birth date of @SpaceshipZSH was a bad idea. Now the account is blocked because it's younger than 13 years old 🤦♂
— https://twitter.com/denysdovhan/status/1067784435972669441

I've already contacted support, sent them my passport to prove I'm not 13 yo. Waiting for their answer.

We are back again. Welcome to https://twitter.com/SpaceshipZSH


Handle undefined value for location

At my current location, the plugin will print two values for locations as below:
[[undefined]]
[[{city name}]]
The undefined values will create unwanted pages so I want to filter them.
It should be easy enough so I would like to work on this issue.
However I don't know where to start, since I can't change the code directly on my app.

I've bullt an API endpoint to fetch the weather forecast and location data, so I think I'll need to fix this in that API. The plugin should work properly after that. Will update this issue once I have made that fix.

@khoadng I've updated the API to better handle undefined locations. Please let me know if this resolves your issue.

I've also updated the plugin with a new setting to exclude the location field if you'd like. Please update to version 0.2.0 if you'd like to try that option.


fix: add localhost to asset canister's CSP

This MR adds http://localhost:* as connect-src into the asset canister's CSP. This will enable browsing the asset canister at http://<canister-id>.localhost:<port> in most browsers.

I wonder if we should also add https://localhost - remember the safari issue that has been recently discussed @adamspofford-dfinity @krpeacock ?

It wouldn't hurt

extending e2e test with multiple schemas (localhost:, 127..., <can-id>.localhost:) would also strengthen the reliability of FE canister for local deployments (future work necessary for testing mainnet deployments)

https://github.com/dfinity/sdk/actions/runs/7166344405/job/19521096556#step:7:146
https://github.com/dfinity/sdk/blob/master/.github/workflows/e2e.yml#L186-L190

@mraszyk lemme know if you want to contribute on that front as well

extending e2e test with multiple schemas (localhost:, 127..., <can-id>.localhost:) would also strengthen the reliability of FE canister for local deployments (future work necessary for testing mainnet deployments)

https://github.com/dfinity/sdk/actions/runs/7166344405/job/19521096556#step:7:146
https://github.com/dfinity/sdk/blob/master/.github/workflows/e2e.yml#L186-L190

@mraszyk lemme know if you want to contribute on that front as well

I wouldn't mind if you could please update the e2e tests.

@smallstepman Do you want to extend e2e tests as part of this MR or do you have a separate ticket for that?


Improve visualisation of Unspecified Record object as interestedParty

Problem description
When the test data below is pasted into the Visualiser, the 'unknown person' icon is used.  Visually, this suggests that there is an unknown individual with the given interest in the subject. However this is not what is conveyed in the data. In this case, the interested party is exempt from disclosure (and that interested party may be a company, not an individual). There are also other reasons that no interested party may be reported
Suggested solution
Use this icon from BOVS instead:

Test data
[
  {
    "statementID": "1dc0e987-5c57-4a1c-b3ad-61353b66a9b7",
    "statementType": "entityStatement",
    "isComponent": false,
    "statementDate": "2017-11-18",
    "entityType": "registeredEntity",
    "name": "CHRINON LTD",
    "foundingDate": "2010-11-18",
    "identifiers": [
      {
        "scheme": "GB-COH",
        "id": "07444723"
      }
    ],
    "addresses": [
      {
        "type": "registered",
        "address": "Aston House, Cornwall Avenue, London, N3 1LF",
        "country": "GB",
        "postCode": "N3 1LF"
      }
    ],
    "jurisdiction": {
      "code": "GB",
      "name": "United Kingdom of Great Britain and Northern Ireland (the)"
    },
    "publicationDetails": {
      "publicationDate": "2018-11-18",
      "bodsVersion": "0.3",
      "publisher": {
        "name": "CHRINON LTD"
      }
    }
  },
  {
    "statementID": "26e786f0-54c5-497d-a52d-b83439ce3dad",
    "statementType": "entityStatement",
    "isComponent": false,
    "statementDate": "2018-01-05",
    "entityType": "arrangement",
    "name": "Joint shareholding",
    "publicationDetails": {
      "publicationDate": "2018-11-18",
      "bodsVersion": "0.3",
      "publisher": {
        "name": "CHRINON LTD"
      }
    }
  },
  {
    "statementID": "676ce2ec-e244-409e-85f9-9823e88bc099",
    "statementType": "ownershipOrControlStatement",
    "isComponent": false,
    "statementDate": "2018-01-05",
    "subject": {
      "describedByEntityStatement": "1dc0e987-5c57-4a1c-b3ad-61353b66a9b7"
    },
    "interestedParty": {
      "describedByEntityStatement": "26e786f0-54c5-497d-a52d-b83439ce3dad"
    },
    "interests": [
      {
        "type": "shareholding",
        "directOrIndirect": "direct",
        "beneficialOwnershipOrControl": false,
        "startDate": "2018-01-01",
        "share": {
          "exact": 100
        }
      }
    ],
    "publicationDetails": {
      "publicationDate": "2018-11-18",
      "bodsVersion": "0.3",
      "publisher": {
        "name": "CHRINON LTD"
      }
    }
  },
  {
    "statementID": "c222fe05-2bf3-4cc0-b126-f665109d7211",
    "statementType": "ownershipOrControlStatement",
    "isComponent": false,
    "statementDate": "2018-01-05",
    "subject": {
      "describedByEntityStatement": "26e786f0-54c5-497d-a52d-b83439ce3dad"
    },
    "interestedParty": {"reason":"interestedPartyExemptFromDisclosure"},
    "interests": [
      {
        "type": "shareholding",
        "directOrIndirect": "direct",
        "beneficialOwnershipOrControl": true,
        "startDate": "2018-01-01",
        "share": {
          "exact": 50
        }
      }
    ],
    "publicationDetails": {
      "publicationDate": "2018-11-18",
      "bodsVersion": "0.3",
      "publisher": {
        "name": "CHRINON LTD"
      }
    }
  },
  {
    "statementID": "c222fe05-2bf3-4cc0-b126-f665109d7211",
    "statementType": "ownershipOrControlStatement",
    "isComponent": false,
    "statementDate": "2018-01-05",
    "subject": {
      "describedByEntityStatement": "26e786f0-54c5-497d-a52d-b83439ce3dad"
    },
    "interestedParty": {"reason":"interestedPartyExemptFromDisclosure"},
    "interests": [
      {
        "type": "shareholding",
        "directOrIndirect": "direct",
        "beneficialOwnershipOrControl": true,
        "startDate": "2018-01-01",
        "share": {
          "exact": 50
        }
      }
    ],
    "publicationDetails": {
      "publicationDate": "2018-11-18",
      "bodsVersion": "0.3",
      "publisher": {
        "name": "CHRINON LTD"
      }
    }
  }
]

Arg! Just realised this issue already existed on sprint 2, @codemacabre . Closing in favour of https://github.com/openownership/visualisation-tool/issues/157 and consolidating things there. Will add 157 to second sprint.


Add Fedora 39 builder

The builder will be used to build nightly and release versions of ponyc targetting Fedora 39.
No release notes are being added at this time, nor is RELEASE_PROCESS.md being updated as until a nightly runs, we can't be sure this will fully work.
The docker image created for the builder can almost certainly be trimmed down in size, but I am not a Fedora/DNF expert. I am looking to the requester of Fedora 39 support to assist with trimming the image down.

Oh wow, you got around to this already. Thank you!

@13r0ck See the Zulip conversation I started for us. I'd appreciate any tips on trimming the image size down via dropping dnf caches or whatever else. Also, if Fedora changes the versions of dependencies by major versions during a Fedora version (like if the clang version might change from say 17 to 18 on a rebuild) then that would be good to address as well.
So... locking versions (if needed because major jumps might happen) and trimming image size down would both be PRs that would be happily accepted (separate PRs please, if needed ).

The first nightly will run tonight, if everything works, I'll give it a test run in a Fedora 39 container and would appreciate you downloading manually from cloudsmith and trying out as well.
The next scheduled ponyc release is at the end of the month, so once Ponyup is updated, it would be "all nightlies" until the next release when you can also get release builds.


fix: also build manpage for cargo.md

What does this PR try to resolve?
Generate manpage for the main cargo command.
How should we test and review this PR?
Run mdbook serve src/doc and check the modified page.
Additional information
This was found during reviewing #14336

@bors r+

:pushpin: Commit 96767be00dd5ca35e1874e5cd0f5ccb7801ba2b7 has been approved by epage
It is now in the queue for this repository.

:hourglass: Testing commit 96767be00dd5ca35e1874e5cd0f5ccb7801ba2b7 with merge 88b4b3bcd3bbb66873734d97ae412a6bcf9b75ee...

:sunny: Test successful - checks-actions
Approved by: epage
Pushing 88b4b3bcd3bbb66873734d97ae412a6bcf9b75ee to master...


Make exporter from eggdrop brain format to something parseable

Eggdrop's (old Bender's) factoid DB is in the format:
keyword => fact1 | fact 2 | fact 3

Make a converter that outputs bender's old brain in a format parseable by new bender:
keyword:
- value: fact1
  origin: nick
  created: 2020-04-04T19:35:08
- value: fact2
  origin: nick
  created: 2020-04-04T19:36:22

or similar json:
{
  "keyword":
    [{
      "value":"fact1",
      "origin":"nick",
      "created":"2020-04-04T19:36:22"
    },
    {
      "value":"fact2",
      "origin":"nick",
      "created":"2020-04-04T19:36:25"
    }]
}

Misses:

Convert incoming charset
Support stored IRC/shell formatting escapes

Obsolete. Not worth the effort any more


Highlight blank lines in modified multiline strings

let x =
  "
foo

bar
"

let x =
  "
foo

novel
"

Currently the blank line is confusingly shown as unchanged.

We probably also want to show novel in bold, to distinguish it from foo. foo should still be red though, as it's part of a changed string value.


job_sheet null not "none"

also cleanup printer to use icpc-banner on server side.

I guess we should probably just remove all the bits about job_sheet, since we aren't using cups banner pages anymore.

Done.


[WIP] add instructions to README.md

Thanks for hacking on this, FYI the tests are a little flaky right now. Namely Node 14 on macos, so ignore, I disabled the branch protection policy for now.

@jamesdaniels this still requires a maintainer to approve before it can be merged. Can you take a look and merge?

Skipping tests and review and merging since it's only README changes per David's request.


Improve mocks by overriding no such method

:scroll: Description
There are a couple of handwritten mocks which override each method, even those we don't care for.
Instead of overriding each method, we should override noSuchMethod so we don't have to update the mocks in case unrelated stuff gets added or removed
:bulb: Motivation and Context
Fixes issue #747
:green_heart: How did you test it?
Waiting for test results by Codecov Report
:pencil: Checklist

[x] I reviewed submitted code
[ ] I added tests to verify changes
[x] I updated the docs if needed
[ ] All tests passing
[x] No breaking changes

Is there any way to run all the test at once locally?
Also in tests results it shows that some tests failed but not which tests failed. Would it be possible to know which test files actually failed?

@AliAkberAakash

I have added a class no_such_method_provider.dart to every module separately. I'm not sure if this could be improved by using a single file.

No need to care about it, it'd be possible by having a new module and use it as a dev_dependencies, but this class won't change anyway so all good to duplicate it.

Is there any way to run all the test at once locally?

No, but you can make your own script to enter each folder and run tests, e.g.
cd dart
dart test
cd ..
cd flutter
flutter test
...

Also in tests results it shows that some tests failed but not which tests failed. Would it be possible to know which test files actually failed?

It should be written in the output of the tests, check your tooling maybe?
The idea is that you also remove not used methods from the mock classes, e.g. MockHub (mock_hub.dart) could remove the methods clone, lastEventId, startTransaction etc... since they are not being used in this mock.

The idea is that you also remove not used methods from the mock classes, e.g. MockHub (mock_hub.dart) could remove the methods clone, lastEventId, startTransaction etc... since they are not being used in this mock.

Is there any easy way to find out which methods are not being used? Or do I need to manually check it?

The idea is that you also remove not used methods from the mock classes, e.g. MockHub (mock_hub.dart) could remove the methods clone, lastEventId, startTransaction etc... since they are not being used in this mock.

Is there any easy way to find out which methods are not being used? Or do I need to manually check it?

Manually check I believe, they likely have empty methods or do nothing.

It should be written in the output of the tests, check your tooling maybe?

I was checking the output in Codecov that is set up for this project. When I make a PR to this repo and someone approves the workflows I get notifications of test results. I see that some tests are failing but cant see which test. I have added an image for reference, its from my previous PR to another issue.

Just scroll up the output log, you will see it, you can likely search for [E] too.

@marandaneto Hi, I have removed all empty functions from the mocks. I have also removed all functions from MockPlatformMockPlatform class in dart module. I have run all tests locally and they passed.

I think I have removed all unused code from the mock classes.

@AliAkberAakash

info - test/mocks/mock_hub.dart:3:8 - Unused import: 'package:sentry/src/noop_hub.dart'. Try removing the import directive. - unused_import
info - test/mocks/mock_platform_checker.dart:1:8 - Unused import: 'package:sentry/src/platform/platform.dart'. Try removing the import directive. - unused_import
info - test/mocks/mock_platform_checker.dart:4:8 - Unused import: 'mock_platform.dart'. Try removing the import directive. - unused_import

Please fix that and we are able to merge it :)

Done :D

Codecov Report

Merging #756 (334528b) into main (d0a3e77) will increase coverage by 5.11%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #756      +/-   ##
==========================================
+ Coverage   90.53%   95.65%   +5.11%
==========================================
  Files         104        2     -102
  Lines        3328       46    -3282
==========================================
- Hits         3013       44    -2969
+ Misses        315        2     -313

Impacted Files
Coverage Δ

dart/lib/src/sentry_user_feedback.dart

flutter/lib/src/sentry_flutter.dart

dart/lib/src/protocol/sentry_stack_frame.dart

dart/lib/src/sentry_options.dart

dart/lib/src/protocol/sentry_package.dart

...ib/src/environment/_web_environment_variables.dart

dart/lib/src/protocol/contexts.dart

flutter/lib/src/sentry_asset_bundle.dart

dio/lib/src/failed_request_interceptor.dart

dart/lib/src/transport/http_transport.dart

... and 92 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0a3e77...334528b. Read the comment docs.

Done :D

Still

info - test/mocks/mock_hub.dart:4:8 - Unused import: 'package:sentry/src/noop_hub.dart'. Try removing the import directive. - unused_import

I recommend you run the analyze, format, test, and build locally before submitting PRs, so we avoid this back and forth :)
Thanks for doing it.

Sorry about that. I'm not familiar with workflows so I can't see this analysis locally. I will be more careful and check them manually.

@marandaneto  Thanks a lot for merging it and guiding me throughout the process. I need to be a lot more careful about my code structure and need to check thoroughly before pushing. Looking forward to contributing more.

@marandaneto Thanks a lot for merging it and guiding me throughout the process. I need to be a lot more careful about my code structure and need to check thoroughly before pushing. Looking forward to contributing more.

Very glad that you are helping out, keep 'em coming, thanks.


Poison damage

There are no indicators for poison damage. The indicator should be shown to the player that has applied the poison either by a splash/lignering potion or by tipped arrow.

I am also thinking of giving poison damage indicators an extra damage format so you can make them green.

closed by #19


Help request and question

Hello
I have a problem.
I'm trying to figure out how your script works for ckeditor.
In my test phase (ck.html file), I get an error:
Uncaught TypeError: $ is not a function
I have the impression that, when loading the remote file
https://knowzero.github.io/tinymce4-languagetool/languagetool/include/languagetool.min.js
The latter does not take into account the jquery previously loaded.
I seek to understand your source code in order to translate it into pure javascript, without any third-party libraries
Could you tell me how to understand your code?
I thank you in advance.
leknoppix
NB: Sorry, my English is a bit rusty.

Hi, the issue is that the CKEditor was mostly used as an example for the flexibility of the languagetool js library, but I have not updated the CKEditor plugin example since demoing it.
To fix your issue, in the ck.html file, add the $ sign to the new LanguageTool deceleration as so:
var LT = new LanguageTool( editor.config, $ );
and add:
LT.setFunction('window',function () {
return editor.window;
});

This should make it work properly.
And yes, at the time browser support was terrible and I was lazy so I opted for jquery. I was planning to eventually rewrite the whole thing without jquery as vanilla, but the project I needed to use languagetool for got delayed and I never got around to doing it.

Hello and thank you for this answer.
I set it up locally. I will try to translate the jquery code to vanilla javascript
I still have some errors, I feel that despite disabling scayt, I get new errors:
GEThttps://loader.webspellchecker.net/sproxy_fck/sproxy.php?plugin=fck2&customerid=1:ua3xw1-2XyGJ3-GWruD3-6OFNT1-oXcuB1-nR6Bp4-hgQHc-EcYng3-sdRXG3-NOfFk&cmd=script&doc=wsc&schema=22
[HTTP/2 403 Forbidden 413ms]

and
Uncaught ReferenceError: DefaultParams is not defined

I continue to do my research because for the project that I am in progress, I would like to couple my wysiwyg with a mini spell checker.
I will come back, if you wish, to this topic to give news of progress, and of course, I will send you a pull request to your repository.

I uploaded the changes to ck.html, to confirm first does this work for you:
https://knowzero.github.io/tinymce4-languagetool/ck.html
Though to note if you plan to do a pull request with removal of jquery, you should test to make sure it works for TinyMCE4 as well. Generally it shouldn't be a problem and should work on both if you port it. That said, the TinyMCE4 version has extra features that were not yet set up for the CK version. Such as the bottom bar and the dialog. So that you don't get confused what the extra code is for in the js library.

Hello and thank you for coming back.
The modified ck.html code no longer has an error concerning the "$".
I get, whether with my development code (my laptop) or yours (online version), the same error:
GEThttps://loader.webspellchecker.net/sproxy_fck/sproxy.php?plugin=fck2&customerid=1:ua3xw1-2XyGJ3-GWruD3-6OFNT1-oXcuB1-nR6Bp4-hgQHc-EcYng3-sdRXG3-NOfFk&cmd=script&doc=wsc&schema=22
[HTTP/2 403 Forbidden 413ms]

In my research, I found that it corresponded to another plugin named "wsc". Being pretty busy lately, I'll look a little later and analyze your code.

The weird thing is, I don't get that error. I tried both firefox and chromium and none get that error. Do you by chance have some sort of browser extension that may be interfering? Try with a private/incognito window that has no plugins and see if you get same result.

I think I know where the confusion lies!
You are clicking on the ABC spellcheck correct?(That is the ckeditor spellchecker) But that isn't how the demo works. The demo is set to spell check after every line or after you type a period, exclamation mark. Aka on the go.
If you want to configure it for manual spellchecking, check the tinymce example for config options. Same if you want to do dialog spellchecking. There is also option to have it on the go spellcheck after every word.

@leknoppix -  Since a month has passed, can I consider this issue addressed and close the issue?


migration tasks don't let me overwrite the name of the schema_migrations table

This is the case where I'm migrating from AR to sequel, and the table has a different schema. Instead of force-update it, I could just use an alternative table, if I use the Migrator API correctly and am able to pass the :table directive. See http://sequel.jeremyevans.net/rdoc/classes/Sequel/Migrator.html#method-c-run
Here's where it's used within sequel_rails: https://github.com/TalentBox/sequel-rails/blob/master/lib/sequel_rails/migrations.rb#L6-L10

Same problem here. Did you by any chance solve it?

If I did, I don't remember how :/ sorry about that.

No worries. I opted to not use the gem and write the DB tasks myself


fix(lexical-html): allow dom to be passed to generateHtmlFromNodes

This solves using this method in Next.js for example, that does not handle JSDOM well when on the server side.
issue #3616 & #3097

requires a lot more work to make it work than expected


Support different set of assets depending on platform and flavor parameters

Need to expose flavor parameters to support different set of assets depending on --flavor xxx (#21682)
Need to expose platform parameters to support different set of assets dependeint on --target-platform xxx (#8230)

Manifest files are loaded in following order

pubspec.yaml
assets.yaml
assets-<platform>.yaml
assets-<flavor>.yaml (only for local package)
assets-<platform>-<flavor>.yaml (only for local package)

assets, fonts and  use-material-design parameters are overridden at each loaded file.
When an assets file is not present, the next one is loaded without overriding parameters from previous steps.
Assets file format is the same as pubspec.yaml.

TODO

[ ] Add --flavor options in packages/flutter_tools/gradle/flutter.gradle
[ ] Add --flavor option in packages/flutter_tools/bin/xcode_backend.sh

See sample project here:
https://github.com/sestegra/flutter_assets_flavors
Feel free to comment.

This would be a great advantage for Flutter. Any updates?

Working through our backlog:
This is a good proposal, and I agree that it would be great to have both https://github.com/flutter/flutter/issues/8230 and https://github.com/flutter/flutter/issues/21682 supported.
I don't think this PR is the way to go about doing so however. I see a lot of opportunities where we could accidentally end up caching the wrong assets, failing to delete older assets, or not copying them as needed. It may work incidentally as we disabled most build caching, but as I work to re-enabled this in the next few months it will become another issue.
The second concern is that with the current build system this will lead to more build invalidations than necessary. For example, switching flavors would cause build/flutter_assets to get overwritten, and so switching back would lose the cache.
Finally, this PR has no tests. We simply cannot accept major feature additions without tests. I'm going to close this PR , but I would love to solve it differently this year.

@jonahwilliams @sestegra Any news?


[RottenTomatoes] fix: update rotten tomatoes regex and extraction

Description of your pull request and other information
Fix broken extractor (rottentomatoes) by extracting video info from embedded json on the page. Additionally the valid url regex was extended to include the default movie trailer as described in #6729.
Fixes #6729
Template

Before submitting a pull request make sure you have:

[x] At least skimmed through contributing guidelines including yt-dlp coding conventions
[x] Searched the bugtracker for similar pull requests
[x] Checked the code with flake8 and ran relevant tests

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

[x] I am the original author of this code and I am willing to release it under Unlicense
[ ] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

[x] Fix or improvement to an extractor (Make sure to add/update tests)
[ ] New extractor (Piracy websites will not be accepted)
[ ] Core bug fix/improvement
[ ] New feature (It is strongly recommended to open an issue first)

I think links like this https://www.rottentomatoes.com/m/toy_story_3 need to be extracted as playlists
and links like this https://www.rottentomatoes.com/m/toy_story_3/trailers/VycaVoBKhGuk extracted as videos


[build] fix compile faild in ppc64le platform

Fix data type, and function call, it's improper in VSX (Vector Scalar Extensions) instruction set in ppc64le to avoid build failure.

Hi @veblush :
Could you please take a look of this request if when you have time. I have test it can build pass in PPC64.
Thank you!

Thanks for the PR but we don't modify this module as it's a copy of https://github.com/Cyan4973/xxHash. Would you try using the latest version of xxhash.h there instead?


Add telemetry data definition and telemetry data API

This change is to simplify adding new telemetry/data on the ot-br side by

declaring the data definition so we can easily review, align and merge telemetry data in the e2e system.
reusing the data API so feature owner doesn't need to re-implement and test the IPC API for each telemetry data.

Detail telemetry data definition and extractions will be defined in the proto file in next changes.

The unit test is made in tests/dbus/test_dbus_client.cpp.

@zhanglongxia @Irving-cl I wonder if you have any comments on the implementation of the WpanStats.


PEAR-1846 - Applied custom gene/mutation filters are displayed 5 times in Mutation Frequency

Description
Prevents modal contents from rendering when the modal is closed to stop requests from firing multiple times
Checklist

[ ] Added proper unit tests
[ ] Left proper TODO messages for any remaining tasks
[ ] Scanned for web accessibility with aXe, and mitigated or documented
flagged issues

Screenshots/Screen Recordings (if Appropriate)

looks good! 👍 👍 👍 👍 👍


no odometry data，how to add imu data to cartographer 2d slam？

Hello,
now, i have no odometry data, just use imu and one rplidar to run cartographer 2d slam,
my question is:
1、if i just use one rplidar,  can i get  the result like the web publish 2d data ?  https://google-cartographer-ros.readthedocs.io/en/latest/data.html
2、 how can i add imu data to cartographer?
now i add imu data to cartographer below.
when i keep imu,laser,and base_link still, get the result below:
https://github.com/duandongbin000/mySlam/blob/master/Screenshot from 2019-01-0802-46-42.png
when i move imu,laser,and base_link , get the result below:
https://github.com/duandongbin000/mySlam/blob/master/Screenshot from 2019-01-0802-49-46.png
this is my configure file:
https://github.com/duandongbin000/mySlam/blob/master/imu.launch
https://github.com/duandongbin000/mySlam/blob/master/rplidar.launch
https://github.com/duandongbin000/mySlam/blob/master/rplidar_2d.urdf
https://github.com/duandongbin000/mySlam/blob/master/rplidar_slam.launch
https://github.com/duandongbin000/mySlam/blob/master/rplidar_slam.lua
bagfile : https://drive.google.com/open?id=10jbbFi4MeFGkD2MgiQGWulDDj_M8vtoz
`E0110 05:41:42.833030  1459 rosbag_validate_main.cc:131] Input contains transform message from frame_id "map" to child_frame_id "base_link". This is almost always output published by cartographer and should not appear as input. (Unless you have some complex remove_frames configuration, this is will not work. Simplest solution is to record input without cartographer running.)
W0110 05:41:42.835559  1459 rosbag_validate_main.cc:103] frame_id imu_link time<PHONE_NUMBER>329098627: IMU linear acceleration is 0.906778 m/s^2, expected is [3, 30] m/s^2. (It should include gravity and be given in m/s^2.) linear_acceleration<PHONE_NUMBER> -0.00341797 0000.906738
W0110 05:41:42.836872  1459 rosbag_validate_main.cc:103] frame_id imu_link time<PHONE_NUMBER>363351228: IMU linear acceleration is 1.02101 m/s^2, expected is [3, 30] m/s^2. (It should include gravity and be given in m/s^2.) linear_acceleration -0.0175781 00.0415039 0001.02002
W0110 05:41:42.837472  1459 rosbag_validate_main.cc:103] frame_id imu_link time<PHONE_NUMBER>403365582: IMU linear acceleration is 0.974981 m/s^2, expected is [3, 30] m/s^2. (It should include gravity and be given in m/s^2.) linear_acceleration -0.0209961 00.0351562 000.974121
W0110 05:41:42.851753  1459 rosbag_validate_main.cc:352] frame_id "map" on topic /scan_matched_points2 has serialization time<PHONE_NUMBER>.193658190 but sensor time<PHONE_NUMBER>.092375100 differing by -0.101283 s.
E0110 05:41:44.577162  1459 rosbag_validate_main.cc:365] Average IMU linear acceleration is 0.995768 m/s^2, expected is [9.5, 10.5] m/s^2. Linear acceleration data should include gravity and be given in m/s^2.
E0110 05:41:44.578286  1459 rosbag_validate_main.cc:389] IMU data (frame_id: "imu_link") has a large gap, largest is 0.109802 s, recommended is [0.0005, 0.005] s with no jitter.
I0110 05:41:44.578856  1459 rosbag_validate_main.cc:398] Time delta histogram for consecutive messages on topic "/imu" (frame_id: "imu_link"):
Count: 2846  Min: 0.000053  Max: 0.109802  Mean: 0.046448
[0.000053, 0.011028)	                    	Count: 2 (0.070274%)	Total: 2 (0.070274%)
[0.011028, 0.022003)	                    	Count: 6 (0.210822%)	Total: 8 (0.281096%)
[0.022003, 0.032978)	                 ###	Count: 382 (13.422347%)	Total: 390 (13.703444%)
[0.032978, 0.043952)	          ##########	Count: 1446 (50.808151%)	Total: 1836 (64.511597%)
[0.043952, 0.054927)	                    	Count: 66 (2.319044%)	Total: 1902 (66.830643%)
[0.054927, 0.065902)	                ####	Count: 559 (19.641602%)	Total: 2461 (86.472244%)
[0.065902, 0.076877)	                 ###	Count: 376 (13.211525%)	Total: 2837 (99.683769%)
[0.076877, 0.087852)	                    	Count: 7 (0.245959%)	Total: 2844 (99.929726%)
[0.087852, 0.098827)	                    	Count: 0 (0.000000%)	Total: 2844 (99.929726%)
[0.098827, 0.109802]	                    	Count: 2 (0.070274%)	Total: 2846 (100.000000%)
E0110 05:41:44.579696  1459 rosbag_validate_main.cc:382] Point data (frame_id: "laser_link") has a large gap, largest is 0.162345 s, recommended is [0.0005, 0.05] s with no jitter.
I0110 05:41:44.579974  1459 rosbag_validate_main.cc:398] Time delta histogram for consecutive messages on topic "/scan" (frame_id: "laser_link"):
Count: 1739  Min: 0.048163  Max: 0.162345  Mean: 0.076037
[0.048163, 0.059582)	                    	Count: 6 (0.345026%)	Total: 6 (0.345026%)
[0.059582, 0.071000)	                  ##	Count: 167 (9.603220%)	Total: 173 (9.948246%)
[0.071000, 0.082418)	        ############	Count: 1039 (59.746983%)	Total: 1212 (69.695229%)
[0.082418, 0.093836)	              ######	Count: 518 (29.787233%)	Total: 1730 (99.482460%)
[0.093836, 0.105254)	                    	Count: 6 (0.345026%)	Total: 1736 (99.827484%)
[0.105254, 0.116673)	                    	Count: 1 (0.057504%)	Total: 1737 (99.884995%)
[0.116673, 0.128091)	                    	Count: 0 (0.000000%)	Total: 1737 (99.884995%)
[0.128091, 0.139509)	                    	Count: 0 (0.000000%)	Total: 1737 (99.884995%)
[0.139509, 0.150927)	                    	Count: 0 (0.000000%)	Total: 1737 (99.884995%)
[0.150927, 0.162345]	                    	Count: 2 (0.115009%)	Total: 1739 (100.000000%)
E0110 05:41:44.580665  1459 rosbag_validate_main.cc:382] Point data (frame_id: "map") has a large gap, largest is 0.228151 s, recommended is [0.0005, 0.05] s with no jitter.
I0110 05:41:44.580884  1459 rosbag_validate_main.cc:398] Time delta histogram for consecutive messages on topic "/scan_matched_points2" (frame_id: "map"):
Count: 870  Min: 0.130426  Max: 0.228151  Mean: 0.152068
[0.130426, 0.140198)	                    	Count: 8 (0.919540%)	Total: 8 (0.919540%)
[0.140198, 0.149971)	             #######	Count: 299 (34.367817%)	Total: 307 (35.287357%)
[0.149971, 0.159743)	        ############	Count: 540 (62.068966%)	Total: 847 (97.356323%)
[0.159743, 0.169516)	                    	Count: 19 (2.183908%)	Total: 866 (99.540230%)
[0.169516, 0.179289)	                    	Count: 2 (0.229885%)	Total: 868 (99.770119%)
[0.179289, 0.189061)	                    	Count: 0 (0.000000%)	Total: 868 (99.770119%)
[0.189061, 0.198834)	                    	Count: 0 (0.000000%)	Total: 868 (99.770119%)
[0.198834, 0.208606)	                    	Count: 0 (0.000000%)	Total: 868 (99.770119%)
[0.208606, 0.218379)	                    	Count: 0 (0.000000%)	Total: 868 (99.770119%)
[0.218379, 0.228151]	                    	Count: 2 (0.229885%)	Total: 870 (100.000000%)
`
why the scan frame cannot be transformed to submap frame?

@duandongbin000 did you get it to work without IMU? Currently struggling to get the SLAM part working with my rplidar a1


📝 Add documentation for pre-commit and code linting

Awesome! I tweaked the docs to simplify them a bit, in case we change things we would have less to update. :sweat_smile: Now this is ready! :rocket:
Thanks! :cake:


Added Guide on how to get wireguard configs from Windscribe VPN

In my opinion, it would make sense to restructure the README a bit.
We can link to separate guides for different VPN providers at the top of the README and then link back to the README at the end of each guide.
If you're okay with this, I would be happy to add the required changes to this PR or make a new one.

That's awesome! Thank you for contributing that. I definitely agree that the VPN provider config steps should be split out, and I'd happily accept a PR with that change.

Looks great, thank you!


Extension causes high cpu load

Issue Type: Performance
Extension Name: LiveServer
Extension Version: 5.5.1
OS Version: Darwin x64 17.7.0
VSCode version: 1.32.3

:warning: Make sure to attach this file from your home-directory: /Users/alprod81/ritwickdey.LiveServer-unresponsive.cpuprofile.txt :warning:
Find more details here: https://github.com/Microsoft/vscode/wiki/Explain:-extension-causes-high-cpu-load

When you're getting this issue? after load of vscode or after clicking to Go Live ?
Is this happen every-time ? or random ?
Please reply here https://github.com/ritwickdey/vscode-live-server/issues/278
Duplicate of https://github.com/ritwickdey/vscode-live-server/issues/278


Why the tests run twice?

The question is probably addressed to @SamoylovMD, since he has enabled the JUnit 4. I'm pretty sure, every test runs twice. Can we fix it?

Sorry for that :) Missed "Run All Tests" option in my IDE and reinvented the wheel.


please provide a precompiled dll

Ideally one that allows setting the DLL path to inject via ENV variables or commandline args or a config file similar to https://github.com/NeighTools/UnityDoorstop?tab=readme-ov-file#doorstop-environment-variables

https://github.com/techiew/UniversalProxyDLL/releases/tag/precompiled-dll

Awesome !


Added examples to M.Q.Arrays.Any documentation

Add example function for Arrays.Any

Docs Build status updates of commit fc9df00:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

api/qsharp/microsoft.quantum.arrays.any.yml
:white_check_mark:Succeeded
View (qsharp-preview)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit bff5e36:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

api/qsharp/microsoft.quantum.arrays.any.yml
:white_check_mark:Succeeded
View (qsharp-preview)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 899348b:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

api/qsharp/microsoft.quantum.arrays.any.yml
:x:Error

Details

:x:Error

Details

api/qsharp/toc.yml
:warning:Warning

Details

api/qsharp/microsoft.quantum.arrays.any.yml

[Error]

Unable to load file 'qsharp/microsoft.quantum.arrays.any.yml' via processor 'QSharpType': Schema validation failed. Please validate the file and make sure it conforms to schema 'QSharpType' (https://static.docs.com/ui/latest/schemas/QSharpType.schema.json):
Invalid type. Expected String but got Object. Path 'seeAlso[0]'.

Line 138: [Error] W:\515t-s\.optemp\packages\opbuild.scripts.1.84.4\tools\opbuild\docset.prebuild.ps1 failed to execute

api/qsharp/toc.yml

[Warning] Unable to find file with uid "microsoft.quantum.arrays.any" referenced by TOC file "~/qsharp/toc.yml"

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 87b2dd2:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

api/qsharp/microsoft.quantum.arrays.any.yml
:x:Error

Details

:x:Error

Details

api/qsharp/toc.yml
:warning:Warning

Details

api/qsharp/microsoft.quantum.arrays.any.yml

[Error] Unable to load file 'qsharp/microsoft.quantum.arrays.any.yml' via processor 'QSharpType': qsharp/microsoft.quantum.arrays.any.yml is not in supported format: (Line: 54, Col: 3, Idx: 1542) - (Line: 54, Col: 4, Idx: 1543): While scanning for the next token, find character that cannot start any token.

Line 138: [Error] W:\1nhb-s\.optemp\packages\opbuild.scripts.1.84.4\tools\opbuild\docset.prebuild.ps1 failed to execute

api/qsharp/toc.yml

[Warning] Unable to find file with uid "microsoft.quantum.arrays.any" referenced by TOC file "~/qsharp/toc.yml"

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 897d6e1:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

api/qsharp/microsoft.quantum.arrays.any.yml
:x:Error

Details

:x:Error

Details

api/qsharp/toc.yml
:warning:Warning

Details

api/qsharp/microsoft.quantum.arrays.any.yml

[Error] Unable to load file 'qsharp/microsoft.quantum.arrays.any.yml' via processor 'QSharpType': qsharp/microsoft.quantum.arrays.any.yml is not in supported format: (Line: 54, Col: 11, Idx: 1550) - (Line: 54, Col: 50, Idx: 1589): While parsing a block mapping, did not find expected key.

Line 138: [Error] W:\2wp3-s\.optemp\packages\opbuild.scripts.1.84.4\tools\opbuild\docset.prebuild.ps1 failed to execute

api/qsharp/toc.yml

[Warning] Unable to find file with uid "microsoft.quantum.arrays.any" referenced by TOC file "~/qsharp/toc.yml"

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 739d71a:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

api/qsharp/microsoft.quantum.arrays.any.yml
:white_check_mark:Succeeded
View (qsharp-preview)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 3e661ce:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

api/qsharp/microsoft.quantum.arrays.any.yml
:white_check_mark:Succeeded
View (qsharp-preview)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

https://github.com/microsoft/QuantumLibraries/pull/232 has been merged, and this API page will be updated next week as part of the February release. I'll close this PR, since it was created primarily for preview purposes. Thank you again for your contribution!


Uploaded /file with swarm-tag-uid doesn't update tag

Summary
Uploaded a file with the /file API and included a swarm-tag-uid header with a UID received from a POST to /tags.  Subsequently querying the tag status with /tags/UID doesn't seem to change the values.  I get the following:
curl http://<IP_ADDRESS>:8080/tags/2110529053
{"total":0,"split":10,"seen":10,"stored":10,"sent":0,"synced":0,"uid":2110529053,"name":"unnamed_tag_1605822913","address":"","startedAt":"2020-11-19T16:55:13.9823185-05:00"}
Steps to reproduce

Create a tag UID via POST to /tags
Upload a file with a POST to /file and include the returned UID in a swarm-tag-uid header.
Poll the tag by GETting /tags/UID

Expected behavior
I expected at least the "sent" and "synced" values to update.
Actual behavior
"sent" and "synced" (and "total") remain 0.  Address is also not populated, but I'm not sure if it should have changed to the CID?
I'm trying to find a way to determine if an uploaded file has been split and successfully sent/synced to the network.

Actually, I just realized that the file(s) I'm sending have already been uploaded to this node before, so it is likely that they won't be sent again.
But what is the actual expected behavior of the tag in the event that chunks of the file (like a file that shares some duplicate content with another file) have already been uploaded?  How can a client watching a tag's values know that the file has been fully processed?

Pushed new files and got the tag statuses shown below.  So the new questions are:
What is "seen"?  And why does it always seem to be 1?
And the 3rd tag is either not done pushing or it actually did share a chunk with some other previous file?  I'll check that one again when the pusher finally catches up with my uploading.
curl http://<IP_ADDRESS>:8080/tags/1699341019
{"total":0,"split":5,"seen":1,"stored":5,"sent":4,"synced":4,"uid":1699341019,"name":"unnamed_tag_1605824879","address":"","startedAt":"2020-11-19T17:27:59.4186194-05:00"}
curl http://<IP_ADDRESS>:8080/tags/520575113
{"total":0,"split":5,"seen":1,"stored":5,"sent":4,"synced":4,"uid":520575113,"name":"unnamed_tag_1605824982","address":"","startedAt":"2020-11-19T17:29:42.7809947-05:00"}
curl http://<IP_ADDRESS>:8080/tags/2659129244
{"total":0,"split":5,"seen":1,"stored":5,"sent":3,"synced":3,"uid":2659129244,"name":"unnamed_tag_1605825033","address":"","startedAt":"2020-11-19T17:30:33.1313959-05:00"}

Ok, I stopped uploading more and more files, waited for the pusher to finish up and queried the 3rd tag again and it appears to have finished, if "seen" is added to "sent" and "synced" to get "split" and "stored".  Strange that "total" insists on remaining zero...
curl http://<IP_ADDRESS>:8080/tags/2659129244
{"total":0,"split":5,"seen":1,"stored":5,"sent":4,"synced":4,"uid":2659129244,"name":"unnamed_tag_1605825033","address":"","startedAt":"2020-11-19T17:30:33.1313959-05:00"}

The 'tags' API comes up misunderstood at the moment. There is an overall issue #918 that aims to "simplify" general feel of it.
Details about what each field means can be found in the file pkg/tags/tag.go :
Total  int64 // total chunks belonging to a tag
Split  int64 // number of chunks already processed by splitter for hashing
Seen   int64 // number of chunks already seen
Stored int64 // number of chunks already stored locally
Sent   int64 // number of chunks sent for push syncing
Synced int64 // number of chunks synced with proof

I mentioned some things on other issues maybe, however in relation to this one:

split is incremented during processing of a file (uploaded content) into chunks
after the chunks is stored, the stored is implemented
in case some chunk was already present in local storage (uploaded again or common section), the seen is incremented

in that case synced will not be incremented

otherwise (chunk was just added), that chunk will be moved to a queue which will distribute chunk to other peers

each time chunk is sent to some other peer, the seen is incremented

the seen count happens for each sending of chunk
it may happen that whole process does not complete, and this seen value may be increased above maximum number of chunks that were created

once the chunk is pushed to some other peer, and is confirmed as received, the synced field is incremented

the total will only be changed once the 'tag' is marked that done splitting happened; at that point value of split will be copied into total, and (optional) address added to tag

if the user directly creates tag manually, then "done splitting" action must be manual also (via PATCH /tags/{id} request)
if the tag is created automatically (during upload to some endpoint), once syncing process completes, it will update total and address tag values

Back to the issue, when uploading something, if split == seen + synced it can be said that content is pushed to the network.
Total will not be changed in described steps until tag is manually PATCH-ed, which will mark it complete.
After uploading something, the split will represent number of chunks for that content, seen and synced will be incremented (depending on local chunks present), and in the end addition of those two values should be equal to split.
The sent may be incremented above split as is represents actual sending of chunk to peers.
If you just care about state of "single" file upload (or any other structure apart from chunk), you can just upload, without creating tag before, and use tag ID from response header to check state of the upload (it should have total once completed).

The 'tags' API comes up misunderstood at the moment. There is an overall issue #918 that aims to "simplify" general feel of it.
Details about what each field means can be found in the file pkg/tags/tag.go :
Total  int64 // total chunks belonging to a tag
Split  int64 // number of chunks already processed by splitter for hashing
Seen   int64 // number of chunks already seen
Stored int64 // number of chunks already stored locally
Sent   int64 // number of chunks sent for push syncing
Synced int64 // number of chunks synced with proof

I mentioned some things on other issues maybe, however in relation to this one:

split is incremented during processing of a file (uploaded content) into chunks
after the chunks is stored, the stored is implemented
in case some chunk was already present in local storage (uploaded again or common section), the seen is incremented

in that case synced will not be incremented

otherwise (chunk was just added), that chunk will be moved to a queue which will distribute chunk to other peers

each time chunk is sent to some other peer, the seen is incremented

the seen count happens for each sending of chunk
it may happen that whole process does not complete, and this seen value may be increased above maximum number of chunks that were created

once the chunk is pushed to some other peer, and is confirmed as received, the synced field is incremented

the total will only be changed once the 'tag' is marked that done splitting happened; at that point value of split will be copied into total, and (optional) address added to tag

if the user directly creates tag manually, then "done splitting" action must be manual also (via PATCH /tags/{id} request)
if the tag is created automatically (during upload to some endpoint), once syncing process completes, it will update total and address tag values

Back to the issue, when uploading something, if split == seen + synced it can be said that content is pushed to the network.
Total will not be changed in described steps until tag is manually PATCH-ed, which will mark it complete.
After uploading something, the split will represent number of chunks for that content, seen and synced will be incremented (depending on local chunks present), and in the end addition of those two values should be equal to split.
The sent may be incremented above split as is represents actual sending of chunk to peers.
If you just care about state of "single" file upload (or any other structure apart from chunk), you can just upload, without creating tag before, and use tag ID from response header to check state of the upload (it should have total once completed).

The 'tags' API comes up misunderstood at the moment. There is an overall issue #918 that aims to "simplify" general feel of it.
Details about what each field means can be found in the file pkg/tags/tag.go :
Total  int64 // total chunks belonging to a tag
Split  int64 // number of chunks already processed by splitter for hashing
Seen   int64 // number of chunks already seen
Stored int64 // number of chunks already stored locally
Sent   int64 // number of chunks sent for push syncing
Synced int64 // number of chunks synced with proof

otherwise (chunk was just added), that chunk will be moved to a queue which will distribute chunk to other peers

each time chunk is sent to some other peer, the seen is incremented

the seen count happens for each sending of chunk
it may happen that whole process does not complete, and this seen value may be increased above maximum number of chunks that were created

once the chunk is pushed to some other peer, and is confirmed as received, the synced field is incremented

Back to the issue, when uploading something, if split == seen + synced it can be said that content is pushed to the network.

After uploading something, the split will represent number of chunks for that content, seen and synced will be incremented (depending on local chunks present), and in the end addition of those two values should be equal to split.
The sent may be incremented above split as is represents actual sending of chunk to peers.

I believe the comments stating "seen" above should actually be "sent"?  Except for the completion test of seen+synced.

The 'tags' API comes up misunderstood at the moment. There is an overall issue #918 that aims to "simplify" general feel of it.
Details about what each field means can be found in the file pkg/tags/tag.go :
Total  int64 // total chunks belonging to a tag
Split  int64 // number of chunks already processed by splitter for hashing
Seen   int64 // number of chunks already seen
Stored int64 // number of chunks already stored locally
Sent   int64 // number of chunks sent for push syncing
Synced int64 // number of chunks synced with proof

otherwise (chunk was just added), that chunk will be moved to a queue which will distribute chunk to other peers

each time chunk is sent to some other peer, the seen is incremented

the seen count happens for each sending of chunk
it may happen that whole process does not complete, and this seen value may be increased above maximum number of chunks that were created

once the chunk is pushed to some other peer, and is confirmed as received, the synced field is incremented

Back to the issue, when uploading something, if split == seen + synced it can be said that content is pushed to the network.

After uploading something, the split will represent number of chunks for that content, seen and synced will be incremented (depending on local chunks present), and in the end addition of those two values should be equal to split.
The sent may be incremented above split as is represents actual sending of chunk to peers.

I believe the comments stating "seen" above should actually be "sent"?  Except for the completion test of seen+synced.

@ldeffenb I could not see your comment on GitHub, but did see it from the email.
You are correct in your comment, I was taken by the flow, and did make mistake. I have updated my comment accordingly (while also leaving original text with strikethrough).

@ldeffenb I could not see your comment on GitHub, but did see it from the email.
You are correct in your comment, I was taken by the flow, and did make mistake. I have updated my comment accordingly (while also leaving original text with strikethrough).


Sql projects table designer description issues

Create a new table and open it in designer, add description to "Id" and hit save, added description is not showing up for me.
redundant GO line in sql file after publishing description

description edit/deletion not working

More details:

descriptions are never getting added for columns, but do get added for the table and indexes. For primary key, foreign key, check constraints, the description gets added if it's added the same time as the object, but if a description is added later, it isn't actually added when publishing.
extra GO isn't consistently added. Seems like it's only happening for primary keys, foreign keys, and check constraints.
table and index descriptions get updated and deleted, but constraint, primary key, and foreign key descriptions do not.


updated the link to release of apache/log4j repo

Why:
Closes #6165

What's being changed:

Check off the following:

[x] I have reviewed my changes in staging (look for the deploy-to-heroku link in your pull request, then click View deployment).
[x] For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

[ ] This pull request impacts the contribution experience

[ ] I have added the 'writer impact' label
[ ] I have added a description and/or a video demo of the changes below (eg. a "before and after video")

Thanks so much for opening a PR @adityatheoctocatdev! We're waiting on confirmation from engineering what the right change is and then we'll get back to you on this PR ✨

@adityatheoctocatdev It looks like it'll be a while before the engineering team can prioritize this work. I'll leave this open for now though 💛

👋 We did some content restructuring that resulted in a conflict with your PR. It looks like we may not have access to check out your fork. Let us know if you need a hand resolving the conflict!

👋 We did some content restructuring that resulted in a conflict with your PR. It looks like we may not have access to check out your fork. Let us know if you need a hand resolving the conflict!
The new location of the file is: content/github/setting-up-and-managing-your-github-profile/customizing-your-profile/personalizing-your-profile.md

I have resolved merge conflicts ✨.

What is it you think this has to see implimented involved.
On Wed, May 12, 2021, 6:36 PM Janice @.***> wrote:

Thanks so much for opening a PR @adityatheoctocatdev
https://github.com/adityatheoctocatdev! We're waiting on confirmation
from engineering what the right change is and then we'll get back to you on
this PR ✨
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/github/docs/pull/6243#issuecomment-840138118, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ATVUGROUFFZTLBBQUGWNBL3TNL7HZANCNFSM44ULXMSQ
.

--Diese Nachricht wurde von meinem Android Mobiltelefon mit GMX Mail gesendet.

@sarahs & @heiskr I have fixed the merge conflicts.

@adityatheoctocatdev Thanks for fixing the merge conflicts! We're still waiting on the engineering team to resolve a few things (and it may be a while before they can prioritize it) before we review this PR 💛

: andymckay/labeler@e6c4322d0397f3240f0e7e30a33b5c5df2d39e90


Igonchar/tdi 42396 fix jackson version

What is the current behavior? (You can also link to an open issue here)
Jackson version was set in incorrect place
What is the new behavior?
Jackson upgrade is done correctly
Please check if the PR fulfills these requirements

[ ] The commit message follows Talend standard
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features) ?
[ ] The code coverage on new code >75%
[ ] The new code does not introduce new technical issues (sonar / eslint)

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build / CI related changes
[ ] Other... Please describe:

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:
https://jira.talendforge.org/browse/TDI-42396

Pull request test result: failure :x:

The build was ok on Jenkins... but due to Jenkins restart there were a lot of builds and set_status job was lost
https://ci-common.datapwn.com/job/components_pull-request_master/5/consoleFull


Submitting additional files to be merged - 7 file (_I.gds to _O.gds)

Hello, Submitting additional files to be merged - 7 file (_I.gds to O.gds) Note for the TE paperclip I see the following error: "Radius [EBeam_VATamma] Not enough space to accommodate the desired bend radius for the waveguide." During the zoom call on 07 Oct Prof said it was OK to have this error and it can be waived. I waive the 'radius' error for the paperclip spiral.
Please merge the files into main gds.

The layout verification error is due to failure due to the error "Radius [EBeam_VATamma] Not enough space to accommodate the desired bend radius for the waveguide."
This happens only for the spiral paperclip and I do not know how to overcome. Prof did say that this error is acceptable and we can submit the device.


HHH-13030 Upgrade hibernate-orm-modules WildFly version

https://hibernate.atlassian.net/browse/HHH-13030

@fax4ever does it solve the issue you were talking about, about jipijapa and such?

From what I've understood, with this patch we will generate WildFly modules distribution suitable just for WildFly 14, unfortunately breaking the compatibility with WildFly 13. I think that the current jipijapa module could be potentially compatible just with a single version of WildFly. So maybe we have to think more before to merge it. I agree with @yrodiere's idea to move the issue on 5.4.x branch, in order to keep the 5.3.x consistent with WildFly 13.

Merged, thanks.

Thanks!


gtmOnSuccess and gtmOnFailure must be called once and only once

https://github.com/adless-tech/google-tag-manager-no-ads/blob/6dcea8d2065a0ac112713256d44b231f8e9ad505/template.tpl#L134
This method calls gtmOnFailure, but never calls gtmOnSuccess at the end. This is likely to be a bug.

The call is actually superfluous; removed it entirely as gtmOnXXX should only be handled in onRejectServices, which is always called.

Apologies for leaving this waiting so long. Your template has been merged into gallery and should be available soon.


Refactor code builder

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
Attention: Patch coverage is 95.34314% with 19 lines in your changes missing coverage. Please review.

Project coverage is 89.66%. Comparing base (2f6453c) to head (217a32b).
Report is 1 commits behind head on main.

Files with missing lines
Patch %
Lines

packages/generate/code-builder/_literal.ts
77.50%
9 Missing :warning:

packages/generate/code-builder/generate.ts
87.71%
7 Missing :warning:

...ckages/generate/_generate_dynamic_route_handler.ts
93.75%
1 Missing :warning:

...ckages/generate/_generate_static_routes_handler.ts
96.66%
1 Missing :warning:

packages/generate/resolver.ts
92.85%
1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #18      +/-   ##
==========================================
+ Coverage   88.58%   89.66%   +1.08%
==========================================
  Files          95      103       +8
  Lines        2120     2323     +203
  Branches      292      315      +23
==========================================
+ Hits         1878     2083     +205
+ Misses        238      236       -2
  Partials        4        4

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


wslpath output not correct  for ramdisk drive

Please fill out the below information:

Microsoft Windows [版本 10.0.17763.379]

What you're doing and what's happening:  (Copy&paste the full set of specific command-line steps necessary to reproduce the behavior, and their output. Include screen shots if that helps demonstrate the problem.)

wslpath output not correct
$ wslpath -w -a test
\Device\ImDisk0\test
$ df -h
Filesystem      Size  Used Avail Use% Mounted on
rootfs          476G   47G  429G  10% /
none            476G   47G  429G  10% /dev
none            476G   47G  429G  10% /run
none            476G   47G  429G  10% /run/lock
none            476G   47G  429G  10% /run/shm
none            476G   47G  429G  10% /run/user
C:              476G   47G  429G  10% /c
O:              954G  4.7G  950G   1% /o
X:              128M   45M   84M  35% /x

the correct result should be: X:\test
X: drive is a ramdisk created by  ImDisk

I have had similar trouble. #3588 , Some operation failed when dealing with ramdisk, The reason may be that ImDisk emulates disk volumes rather than complete disks,  as mentioned by the author in Imdisk. Full disk emulation like Arsenal Image Mounter should work. The strategy I finally choose is to use a vhdx and the Unified Write Filter (UWF) to emulate ramdisk.

Yeah, it is going to be the "same". From #3588:

Maybe it is just a badly formed filter driver, which is spiritually dupe other issues.

I'll hold this open, but the hard fact is WSL doesn't support all third-party IFS, and quoth "it's unlikely [the devs] will get to all of them". The constructive path forward is to contact the purveyors of Imdisk and let them know about the problem, and they can in turn contact MSFT directly with questions if they have any. Which they probably won't need to do, once they take a look at the fail.

Maybe fixed at build 18252?

Allow path translation on volumes without a volume GUID.
https://docs.microsoft.com/en-us/windows/wsl/release-notes#build-18252-skip-ahead

For those still facing this issue in 1909:
Make your drive Fixed and not Removable.
WSL doesn't seem to like removable drives.


Add remark-lint support

We need to expand paths for the plugins,
because Remark cli expects plugins (and node_modules dir) to be in the
same directory from which the cli runs.
Since we are running the cli from a temp directory, it can't find the
plugins, unless we use absolute paths.
Additionally, the plugins must be provided by their full name
(i.g. remark-lint-list-item-indent). Remark cli supports dropping
remark- prefix, so one could add a plugin as lint-list-item-indent,
but that only works if the node_modules dir (where plugins are
installed) is in the same directory from which cli is ran.
Because we're expanding plugin paths to absolute, full path, that
doesn't work.
We should document this on Hound's config page.

@gylaz isn't this the same issue that we solved with NODE_PATH in the stylelint linter??
https://github.com/houndci/linters/pull/102#discussion_r110201524

@blackjid That's a great point! I haven't thought of it and Remark documentation never mentioned it. Let me try it out and I'll report back.

@blackjid That worked perfectly! Thanks a lot for chiming in :)