Valid URL does not pass validation

Is there a good reason why the following URL does not pass validation:
https://sub.domain.net:5008/
?

Traceback (most recent call last):
File "/opt/venv/lib/python3.7/site-packages/lnurl/core.py", line 24, in encode
return Lnurl(_url_encode(url))
File "/opt/venv/lib/python3.7/site-packages/lnurl/types.py", line 161, in init
self.url = url if url else self.get_url(bech32)
File "/opt/venv/lib/python3.7/site-packages/lnurl/types.py", line 165, in get_url
return parse_obj_as(Union[OnionUrl, ClearnetUrl], _lnurl_decode(bech32))
File "/opt/venv/lib/python3.7/site-packages/pydantic/tools.py", line 35, in parse_obj_as
return model_type(root=obj).root
File "/opt/venv/lib/python3.7/site-packages/pydantic/main.py", line 400, in init
raise validation_error
pydantic.error_wrappers.ValidationError: 2 validation errors for ParsingModel[Union[lnurl.types.OnionUrl, lnurl.types.ClearnetUrl]]
root
URL host invalid, top level domain required (type=value_error.url.host)
root
URL scheme not permitted (type=value_error.url.scheme; allowed_schemes={'https'})

Can't reproduce. Seems to be a pydantic issue. What version of pydantic is this?

pydantic v1.8.1
lnurl v0.3.6
I posted the URL format entered into the browser that triggers the error. If this URL format passes on your tests (not reproducible) then perhaps the URL scheme/format being passed onto lnurl is changed on route - I am using a HTTPS->TOR proxy.
I get HTTP response 426 on
https://sub.domain.net:5008/lnurlp/api/v1/links?all_wallets=
message | "LNURLs need to be delivered over a publically accessible https domain or Tor."
If there was a log of the failed URL, or if it was included in the error msg -  that would help clear this up.

@eillarra ?

@damanic Can you provide more background?
The URL is valid and it gets properly validated:
(py-lnurl) eillarra % python
Python 3.7.7 (default, Apr  9 2020, 15:17:23)
[Clang 11.0.3 (clang-1<IP_ADDRESS>)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import lnurl
>>> lnurl.encode('https://sub.domain.net:5008/')
Lnurl('LNURL1DP68GURN8GHJ7UM4VGHXGMMDV95KUTNWV46R5DFSXQUZ77KU4XL', bech32=Bech32('LNURL1DP68GURN8GHJ7UM4VGHXGMMDV95KUTNWV46R5DFSXQUZ77KU4XL', hrp='lnurl', data=[13, 1, 26, 7, 8, 28, 3, 19, 7, 8, 23, 18, 30, 28, 27, 21, 12, 8, 23, 6, 8, 27, 27, 13, 12, 5, 20, 22, 28, 11, 19, 14, 12, 21, 26, 3, 20, 13, 9, 16, 6, 0, 28, 2, 30]), url=ClearnetUrl('https://sub.domain.net:5008/', scheme='https', host='sub.domain.net', tld='net', host_type='domain', port='5008', path='/'))

LNURL detects the ClearnetUrl type correctly.
My guess is there is some issue in your LNbits configuration. I remember that you have to be careful when proxying https addresses with LNbits or it is possible that LNbits is not receiving the https part correctly; so in your case, even if the address is https, internally LNbits is encoding a http address, hence the lnurl exception.

@eillarra
I think we can now say with some confidence that the URL I enter into my browser to access LNbits is not the exact URL being considered by LNbits internally, after it has been routed through my proxy.
Background:

TOR only Umbrel Node running LNBits
Clearnet VPS running a TOR proxy : https://github.com/damanic/socatorssl

Can you think of a simple method I can use to log the URL being considered by LNbits so I can confirm the exact URL string that is failing to validate.  And/or point me to the method used to pull in the clients access point/url?
In the meantime I will try to generate a resuable lnurl-pay address via command line. Thanks!

Based on the link you mentioned before, you can check here what is the URL you are trying to encode, just to be sure:
https://github.com/lnbits/lnbits/blob/master/lnbits/extensions/lnurlp/models.py#L31
If you have access to the code I would start debugging there.
In the LNbits Telegram channel you will probably find somebody that had this same proxy issue before.


Cannot create items that set specific origins in alpha.9

In 1.13.0-alpha.8
I run command
/give @s minecraft:stick[origins:origin=[{origin: "origins:shulk", layer: "origins:origin"}]]

this works in changing my origin to shulk
In 1.13.0-alpha.9
I run command
/give @s minecraft:stick[origins:origin=[{origin: "origins:shulk", layer: "origins:origin"}]]

this opens the choose origin GUI

This should now be fixed in 1.13.0-alpha.11


Question on code: online/offline

While not an issue, hoping someone can help.
How is the $online false set if not driven use user code.  Ie what sets the online state from true to false when the device has disconnected/lost power?  Can someone explain?  I'd like to replicate in code for something else, so it uses the homie model of showing is a device is connected.
It looks like the true status is set as a retained message to the $online topic with the QOS set to At Least once?  I just can't figure out how the broker knows the device has gone and sets the $online to false.

Hi - I believe it has something to do with the "Last Will and Testament"
concept from MQTT, but I cannot quickly locate an example
Typos courtesy of my iPhone

I saw the posting of the true status in the boot-normal.cpp.   And it looked like it was retained.  The 1 before retained I thought was the at least once.
But I replicated that in c# and the true was set but it didn’t set to false when I exited.

From: Jeremy McNamara <notifications<EMAIL_ADDRESS>Sent: Monday, November 13, 2017 16:25
Subject: Re: [marvinroger/homie-esp8266] Question on code: online/offline (#423)
To: marvinroger/homie-esp8266 <homie-esp8266<EMAIL_ADDRESS>Cc: psyciknz <github<EMAIL_ADDRESS>Author <author<EMAIL_ADDRESS>Hi - I believe it has something to do with the "Last Will and Testament"
concept from MQTT, but I cannot quickly locate an example
Typos courtesy of my iPhone
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/marvinroger/homie-esp8266/issues/423#issuecomment-343800109, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AFGkc11I_GlWC28yQoYc046GDusNskS1ks5s17aTgaJpZM4QbMQM.

Figured it out, you helped with the LWT guidance.  So for the client I was using, setting the last will and testament was part of the connection.  And you set the $online to false as LWT.
Then as part of connecting you create a $online true.  And so on disconnection (forcibly) the LWT takes effect.
Thanks, interesting exercise.


Bump BSK to pull in updates to PrivacyConfigurationData initializer

Task/Issue URL: https://app.asana.com/0/1177771139624306/1203216978682724/f
Description:
Update BSK to pull in macOS-only changes. No functional changes to the iOS app.

Steps to test this PR:

Ensure that unit tests pass

Internal references:
Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM

Thanks @bwaresiak, I added a task for iOS here: https://app.asana.com/0/414709148257752/1203712610938752/f


Fix: correct np-opto locations before clipping

fixes #138

@alejoe91 Is there anything that needs to be changed with the compression process (lines 94-124)?


Get rid of legacy builders

Details:

Get rid of legacy builders and their headers (builders.hpp and subgraph_builders.hpp)

Tickets:

CVS-117139

build_jenkins

build_jenkins


Generate Attention Scores on dnalongcat finetuned models

Hi, I'm currently running step 5.1 which is to generate attention scores. When using a model finetuned on max seq length = 2048 and a batch size of 8 I run into the following error.
ValueError: could not broadcast input array from shape (32,12,512,512) into shape (8,12,2048,2048)
I assume this has something to do with the shape of storing of kmers in the finetuning of the model = [maxseqlength/512, 512].
Is there a quick fix for this?
Cheers

Hi @mitchgill16 , I encountered the same issue.
I don't think it is possible can compute the attention scores for an input of len 2048.
Longer sequence (N x 512) are handled by performing inference N times.
This means you get N attention matrices of shape 512x512.
You cannot broadcast (32,12,512,512) into shape (8,12,2048,2048), as you don't know how the first subsequence of len 512 attends to the remaining N-1 sequences.
@israa-alqassem FYI


Using custom components in grid cells

Here's a brief snippet of code from a test I'm running up:
import {NGXCButton} from '../../../common/components/ui.jsx';

class GridTest extends Component {

render() {
		const ActiveAction = <NGXCButton btnText='Active' active={true} />

		const columnMeta = [{
			columnName: 'name',
		}, {
			columnName: 'shortStatus',
			displayName: 'Status'
		}, {
			columnName: 'id',
			customComponent: ActiveAction
		}];

		return (
			<Griddle
				columns={['name', 'shortStatus', 'id']}
				columnMetadata={columnMeta}
				useExternal={true}
				externalSetPage={this.setPage}
				externalChangeSort={this.changeSort}
				externalSetFilter={this.setFilter}
				externalSetPageSize={this.setPageSize}
				externalMaxPage={this.props.maxPages}
				externalCurrentPage={this.props.currentPage}
				results={this.props.campaigns}
				resultsPerPage={this.props.resultsPerPage}
				externalSortColumn={this.props.sortColumn}
				externalSortAscending={this.props.sortAscending}
				showFilter={true}
				showSettings={true}
			/>
		);
	}
}

Given that this doesn't work in the browser, am I right in saying there's no way of including an existing component in a column?

If you take a look at Custom Columns section http://griddlegriddle.github.io/Griddle/customization.html you will clearly see that you can include custom components. However I've run into similar issues as you've described when it comes to external data.

get rid of the column property on the griddle and add column names as displayName to objects you've defined under columnMeta.
If it still behaves the same render Griddle only once you have received results.

Thanks for the update.
However (and this is meant more as a note to other readers who come up against this issue):
If I get rid of the column property on the griddle, I get this: https://puu.sh/qMtYU/f40c59efdb.png.
Assuming this is because our api returns more than we need and the Griddle doesn't use columnMetadata as a definition of the only columns it should render, if I manipulate the returned data to strip out everything else, I get this: https://puu.sh/qMu3g/5a2d4d1134.png.
Neater, but still no custom component: https://puu.sh/qMvam/fdf6d01f47.png
This did work though (some code removed for brevity):
`
const ActiveAction = React.createClass({
render() {
return ;
}
});
	const columnMeta = [{
		columnName: 'name',
		displayName: 'name'
	}, {
		columnName: 'shortStatus',
		displayName: 'Status'
	}, {
		columnName: 'id',
		displayName: 'id',
		customComponent: ActiveAction
	}];

	return (
		<Griddle
			columnMetadata={columnMeta}
			results={this.props.campaigns}
		/>
	);

`
So I have to wrap my NGXCButton element in a call to React.createClass in order for the Griddle to successfully render it into a cell.
Not sure if this is considered a bug, a shortfall in features or just expected convention - at least I have something I can work from :)

Thanks for documenting this! This is something that is going to be a lot nicer in 1.0 (unfortunately I've been a bit delayed in releasing this newer version)

Looking forward to 1.0 .....soon....? :)

Well :) I'm trying -- Just moved and getting ready to welcome a new baby into the world. We will see -- it's fairly close BUT trying to get the API solidified a bit more so we're not recommending basing plugins on an API that we later decide is not going to work. Also we'd like to give time for people to work with the beta a bit (when that's available) to get more eyes on everything.


Auth Mechanism and Authorization order done

Changed the order as discussed and implemented advanced settings for auth mechanism

Add and use the isLogged flag and not the username and password != null condition

The last comment I made is not resolved yet, also don't push the .dart_tool and .idea directories and other generated files

Yeah, almost done, I'm resolving one issue, it actually gave an error

@bmerchant22 i have added the isLogged functionality to it and it works fine

Also, delete the .dart_tool, .flutter plugins and dependencies

@bmerchant22 oh sorry, done now, it shows its able to merge with base branch

Also, when a person logs out, set the isLogged flag to false

It becomes null, I had tried that yesterday, it works perfectly fine without issues
The logout button will delete all the things in the secure storage


Fix missing image in test documentation

I looked at how other tracks are linking to images in their docs and it seems like linking to GitHub
is the way to got.
fixes #175

@ErikSchierboom Looks like this was supported in earlier Exercism versions but support was dropped?
There is the same issue in the Swift track and there exists a PR to fix it: https://github.com/exercism/swift/pull/401

And thanks for the link to the Scala PR. That one has now been merged.


fix(STONEINTG-689): skip update if *StatusAdapter fails

If we fail to create object with *StatusAdapter, we should skip update of PR status. This error is usually non-recoverable it only retriggers reconciliation and blocks other updates.
Maintainers will complete the following section

[ ] Commit messages are descriptive enough (hints)
[ ] Code coverage from testing does not decrease and new code is covered (check the PR coverage on codecov)
[ ] Controllers diagrams are updated when PR changes controllers code  (if applicable)

/test integration-service-e2e


Hiding total bars between the changes

Hi there, love your visual!
So i typically don't use your visual with anything in the category, but I recently had to because I'm comparing 2 different time periods and the Date field needed to be added in order for values to show up. When that happens I get what I want, but the inner total bars aren't really needed, I just need the starting/ending total, and then the differences between the measure's I've brought in?
Any way to hide the 3 middle total bars?

Thanks again for the great visual!

@laky27 ,
Can you send me a screenshot of how the visualisation pane looks like?
The only way you can have multiple pillars is either

by defining them in the "Define Pillars" section
or you have 2 or more measure and 2 or more categories.
or you have 2 or more measure and 1 category.

Can you remove multiple measures or categories if you have them. I think for what you need, you need 1 category and 2 measures. Each measure will become a pillar (one at start and one at the end) with categories coming in the middle.
Thanks
Nishant

@laky27 Is this still an issue? if so, can you send me the screenshot I requested earlier.

Closing as haven't received a response to my earlier query. If this is still an issue, please open a new issue and attached a screenshot explaining the issue and I will be happen to look into it


Ckeditor problem

after import of Your css from https://cdnjs.cloudflare.com/ajax/libs/materialize/1.0.0-rc.2/css/materialize.min.css in the css of  http://typesetter5.bplaced.net/Bootstrap-materialize -- the insert-link of ckeditor was so much restyled so that i could not choose target=_blank, and i had to got into the sourcecode.
With Mui-css i had the same problem, but they publised a version which did not conflict with existing css and had no global variables. @import url(//cdn.muicss.com/mui-0.9.39/extra/mui-noglobals.min.css);
which does not cause such restylings.  Can You do the same ?

Did you already test the 1.0.0 release?


⚠ Bofrost.hr has degraded performance

In 4ffd0c4, Bofrost.hr (https://www.bofrost.hr) experienced degraded performance:

HTTP code: 200
Response time: 5312 ms

Resolved: Bofrost.hr performance has improved in 290d3c9.


Lost connection to device when running FFI function

Steps to Reproduce

Run flutter run.

Expected results:
Function to be called normally and debugger to not crash
Actual results:
Debugger is crashing with Lost connection to device and
Service protocol connection closed.
[        ] Lost connection to device.
[   +3 ms] DevFS: Deleting filesystem on the device
(file:///Users/netgfx/Library/Developer/CoreSimulator/Devices/FE46F603-32A7-4BF2-8434-554F0C93CE3F/data/Containers/Data/Application/D052B5E0-0A00-4502-9DF1-52B3EBC43C69/tmp/approver_7laBYLb6/approver_7l/)
[ +255 ms] Ignored error while cleaning up DevFS: TimeoutException after 0:00:00.250000: Future not completed
[   +3 ms] "flutter run" took 46,301ms.
[ +221 ms] ensureAnalyticsSent: 215ms
[   +3 ms] Running shutdown hooks
[        ] Shutdown hook priority 4
[   +2 ms] Shutdown hooks complete
[        ] exiting with code 0

Logs

[ +726 ms] executing: /usr/bin/xcrun simctl install FE46F603-32A7-4BF2-8434-554F0C93CE3F /Users/mixalisdobekidis/PROJECTS/7LApprover/approver_7l/build/ios/iphonesimulator/Runner.app
[+2045 ms] executing: /usr/bin/plutil -convert json -o - /Users/mixalisdobekidis/PROJECTS/7LApprover/approver_7l/build/ios/iphonesimulator/Runner.app/Info.plist
[   +6 ms] Exit code 0 from: /usr/bin/plutil -convert json -o - /Users/mixalisdobekidis/PROJECTS/7LApprover/approver_7l/build/ios/iphonesimulator/Runner.app/Info.plist
[        ]
{"CFBundleName":"approver_7l","DTSDKName":"iphonesimulator13.7","DTXcode":"1170","CFBundleIcons~ipad":{"CFBundlePrimaryIcon":{"CFBundleIconFiles":["AppIcon60x60","AppIcon76x76"],"CFBundleIconName":"AppIcon"}},"UILaun
chStoryboardName":"LaunchScreen","DTSDKBuild":"17H22","CFBundleDevelopmentRegion":"en","CFBundleVersion":"1","BuildMachineOSBuild":"19G2021","DTPlatformName":"iphonesimulator","CFBundlePackageType":"APPL","CFBundleSh
ortVersionString":"1.0.0","CFBundleSupportedPlatforms":["iPhoneSimulator"],"UIMainStoryboardFile":"Main","CFBundleInfoDictionaryVersion":"6.0","CFBundleExecutable":"Runner","DTCompiler":"com.apple.compilers.llvm.clan
g.1_0","UISupportedInterfaceOrientations~ipad":["UIInterfaceOrientationPortrait","UIInterfaceOrientationPortraitUpsideDown","UIInterfaceOrientationLandscapeLeft","UIInterfaceOrientationLandscapeRight"],"MinimumOSVers
ion":"13.0","CFBundleIdentifier":"com.example.approver7l","UIDeviceFamily":[1],"CFBundleSignature":"????","DTPlatformVersion":"13.7","CFBundleIcons":{"CFBundlePrimaryIcon":{"CFBundleIconFiles":["AppIcon60x60"],"CFBun
dleIconName":"AppIcon"}},"DTXcodeBuild":"11E801a","LSRequiresIPhoneOS":true,"UISupportedInterfaceOrientations":["UIInterfaceOrientationPortrait","UIInterfaceOrientationLandscapeLeft","UIInterfaceOrientationLandscapeR
ight"],"UIViewControllerBasedStatusBarAppearance":false,"DTPlatformBuild":"17H22"}
[   +2 ms] executing: /usr/bin/xcrun simctl launch FE46F603-32A7-4BF2-8434-554F0C93CE3F com.example.approver7l --enable-dart-profiling --enable-checked-mode --verify-entry-points --observatory-port=0
[ +530 ms] com.example.approver7l: 23771
[        ] Waiting for observatory port to be available...
[+1150 ms] Observatory URL on device: http://<IP_ADDRESS>:54458/kSuN4sknSUY=/
[  +25 ms] Caching compiled dill
[ +136 ms] Connecting to service protocol: http://<IP_ADDRESS>:54458/kSuN4sknSUY=/
[ +142 ms] Successfully connected to service protocol: http://<IP_ADDRESS>:54458/kSuN4sknSUY=/
[        ] Waiting for iPhone X 13 to report its views...
[   +5 ms] Waiting for iPhone X 13 to report its views... (completed in 4ms)
[   +8 ms] DevFS: Creating new filesystem on the device (null)
[  +12 ms] DevFS: Created new filesystem on the device
(file:///Users/mixalisdobekidis/Library/Developer/CoreSimulator/Devices/FE46F603-32A7-4BF2-8434-554F0C93CE3F/data/Containers/Data/Application/D052B5E0-0A00-4502-9DF1-52B3EBC43C69/tmp/approver_7laBYLb6/approver_7l/)
[   +5 ms] Updating assets
[ +205 ms] Manifest contained wildcard assets. Inserting missing file into build graph to force rerun. for more information see #56466.
[  +10 ms] Syncing files to device iPhone X 13...
[   +5 ms] Scanning asset files
[   +3 ms] <- reset
[        ] Compiling dart to kernel with 0 updated files
[   +1 ms] <- recompile package:approver_7l/main.dart c69e9ef4-a75e-477f-af70-8949a610ff0c
[        ] <- c69e9ef4-a75e-477f-af70-8949a610ff0c
[ +210 ms] Updating files
[  +90 ms] flutter: length of list: 11
[   +7 ms] DevFS: Sync finished
[        ] Syncing files to device iPhone X 13... (completed in 318ms)
[   +1 ms] Synced 1.8MB.
[   +1 ms] <- accept
[   +1 ms] Connected to _flutterView/0x7ff07c823620.
[   +2 ms] Flutter run key commands.
[   +2 ms] r Hot reload. 🔥🔥🔥
[   +1 ms] R Hot restart.
[        ] h Repeat this help message.
[        ] d Detach (terminate "flutter run" but leave application running).
[        ] c Clear the screen
[        ] q Quit (terminate the application on the device).
[        ] An Observatory debugger and profiler on iPhone X 13 is available at: http://<IP_ADDRESS>:54458/kSuN4sknSUY=/
[ +472 ms] flutter: just before get tasks
[ +167 ms] Service protocol connection closed.
[        ] Lost connection to device.
[   +3 ms] DevFS: Deleting filesystem on the device
(file:///Users/mixalisdobekidis/Library/Developer/CoreSimulator/Devices/FE46F603-32A7-4BF2-8434-554F0C93CE3F/data/Containers/Data/Application/D052B5E0-0A00-4502-9DF1-52B3EBC43C69/tmp/approver_7laBYLb6/approver_7l/)
[ +255 ms] Ignored error while cleaning up DevFS: TimeoutException after 0:00:00.250000: Future not completed
[   +3 ms] "flutter run" took 46,301ms.
[ +221 ms] ensureAnalyticsSent: 215ms
[   +3 ms] Running shutdown hooks
[        ] Shutdown hook priority 4
[   +2 ms] Shutdown hooks complete
[        ] exiting with code 0

info • Unused import: 'components/styles.dart' • lib/DetailsView.dart:1:8 • unused_import
   info • Unused import: 'dart:async' • lib/components/MainCompletedList.dart:1:8 • unused_import
   info • Unused import: 'package:intl/intl.dart' • lib/components/MainCompletedList.dart:3:8 • unused_import
   info • Unused import: 'package:percent_indicator/percent_indicator.dart' • lib/components/MainCompletedList.dart:5:8 • unused_import
   info • This class (or a class that this class inherits from) is marked as '@immutable', but one or more of its instance fields aren't final: MainCompletedListWidget.list •
          lib/components/MainCompletedList.dart:13:7 • must_be_immutable
   info • Unused import: 'dart:async' • lib/components/MainDetailsView.dart:2:8 • unused_import
   info • Unused import: 'package:intl/intl.dart' • lib/components/MainDetailsView.dart:3:8 • unused_import
   info • Unused import: 'package:percent_indicator/percent_indicator.dart' • lib/components/MainDetailsView.dart:6:8 • unused_import
   info • Unused import: '../utils.dart' • lib/components/MainDetailsView.dart:8:8 • unused_import
   info • This class (or a class that this class inherits from) is marked as '@immutable', but one or more of its instance fields aren't final: MainDetailsViewWidget.details • lib/components/MainDetailsView.dart:12:7
          • must_be_immutable
   info • Avoid using braces in interpolation when not needed • lib/components/MainDetailsView.dart:37:19 • unnecessary_brace_in_string_interps
   info • This class (or a class that this class inherits from) is marked as '@immutable', but one or more of its instance fields aren't final: MainPendingListWidget.list • lib/components/MainPendingList.dart:13:7 •
          must_be_immutable
   info • The value of the field '_visible' isn't used • lib/components/MainPendingList.dart:22:7 • unused_field
   info • The value of the field '_diff' isn't used • lib/components/MainPendingList.dart:23:7 • unused_field
   info • This class (or a class that this class inherits from) is marked as '@immutable', but one or more of its instance fields aren't final: PDFWidget.payload • lib/components/PDFWidget.dart:11:7 •
          must_be_immutable
   info • The declaration '_localFile' isn't referenced • lib/components/PDFWidget.dart:30:23 • unused_element
   info • This class (or a class that this class inherits from) is marked as '@immutable', but one or more of its instance fields aren't final: TimetrackingBlock.details • lib/components/TimetrackingBlock.dart:9:7 •
          must_be_immutable
   info • Unused import: 'package:approver_7l/utils.dart' • lib/components/styles.dart:1:8 • unused_import
   info • Unused import: 'dart:typed_data' • lib/main.dart:3:8 • unused_import
   info • Unused import: 'dart:math' • lib/main.dart:4:8 • unused_import
   info • Unused import: 'package:approver_7l/sampleData.dart' • lib/main.dart:9:8 • unused_import
   info • Unused import: 'components/PDFWidget.dart' • lib/main.dart:13:8 • unused_import
   info • Unused import: 'components/DismissibleButton.dart' • lib/main.dart:17:8 • unused_import
   info • Unused import: 'package:path_provider/path_provider.dart' • lib/main.dart:25:8 • unused_import
   info • Unused import: 'package:pdf_render/pdf_render_widgets2.dart' • lib/main.dart:26:8 • unused_import
   info • Unused import: 'dart:io' • lib/main.dart:27:8 • unused_import
   info • Unused import: 'package:open_file/open_file.dart' • lib/main.dart:28:8 • unused_import
   info • Unused import: 'package:flutter/services.dart' • lib/main.dart:29:8 • unused_import
   info • Duplicate import • lib/main.dart:32:8 • duplicate_import
   info • Unused import: 'dart:io' • lib/main.dart:34:8 • unused_import
   info • The value of the field '_counter' isn't used • lib/main.dart:106:7 • unused_field
   info • The value of the field '_color' isn't used • lib/main.dart:108:7 • unused_field
   info • The value of the field '_tabController' isn't used • lib/main.dart:115:17 • unused_field
   info • The declaration '_navigateToLogin' isn't referenced • lib/main.dart:177:3 • unused_element

[✓] Flutter (Channel stable, 1.20.3, on Mac OS X 10.15.6 19G2021, locale en-GR)
    • Flutter version 1.20.3 at /Users/netgfx/SDK/flutter
    • Framework revision 216dee60c0 (10 days ago), 2020-09-01 12:24:47 -0700
    • Engine revision d1bc06f032
    • Dart version 2.9.2

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
    • Android SDK at /Users/netgfx/Library/Android/sdk
    • Platform android-30, build-tools 30.0.2
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.7)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.7, Build version 11E801a
    • CocoaPods version 1.9.3

[✓] Android Studio (version 4.0)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 49.0.2
    • Dart plugin version 193.7547
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)

[✓] VS Code (version 1.49.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.14.1

[✓] Connected device (2 available)
    • iPhone (mobile) • 21a54e701c409f46af355cc927962aa6002a8798 • ios • iOS 13.6.1
    • iPhone X 13 (mobile) • FE46F603-32A7-4BF2-8434-554F0C93CE3F     • ios • com.apple.CoreSimulator.SimRuntime.iOS-13-4 (simulator)

I have setup some rust binary that does http request and returns a string like this:
let _resp = ureq::post(&url)
                .set("Content-Type", "application/json")
                .send_json(serde_json::from_str(&data).unwrap());

and returns CString::new(response).unwrap().into_raw()
From Flutter i have this:
typedef getFunction = Pointer<Utf8> Function();
typedef getFunctionFFI = Pointer<Utf8> Function();

final DynamicLibrary approverNative = DynamicLibrary.process();

final getFunction rustGetJSON = approverNative
      .lookup<NativeFunction<getFunctionFFI>>("get_requests")
      .asFunction();

And then
Future<void> didChangeDependencies() async {
    super.didChangeDependencies();

   final Pointer<Utf8> resultJSON = rustGetJSON();
   print("- Result pointer:  $resultJSON");
}

At which point the App is crashing the debugger. The weird thing is that the App continues to work and when the App runs from the XCode nothing abnormal happens.

/cc @dcharkes @mkustermann

Hi @netgfx,

The weird thing is that the App continues to work and when the App runs from the XCode nothing abnormal happens.

That is pretty strange indeed.
Could you please upload a minimal repro so that I can take a look?

@dcharkes I will try to, but unfortunately the API endpoint that the Rust function is calling is behind VPN. I will try to mockup the response. Do you have some preference where to upload?

You can just make a Github repo.

until I set up the repo this is a crash report when running the App on an iOS device.
Runner  15-9-20, 2-26 PM.crash.zip

Without additional information, we are unfortunately not sure how to resolve this issue.
We are therefore reluctantly going to close this bug for now.
Please don't hesitate to comment on the bug if you have any more information for us; we will reopen it right away!
Thanks for your contribution.


ExtraUtils2 RF Power Duplication

Using the following setup: http://i.imgur.com/0OI2ThS.png
Magmatic Generator from ExtraUtils2 hooked up to a Flux Plug, and two EnderIO capacitor banks setup with Flux Points. The Plug/Points share the same network.
The magmatic gen produces 40rf/t , for a total of 100,000rf for one bucket of lava.
Expected result: both capacitor banks should store a combined total of 100,000 rf after dumping a bucket of lava in the gen.
Observed result: both capacitors receive 40rf/t each and both end up with 200,000 rf, effectively duping the power.
This issue does not occur when the flux plug is not directly adjacent to the magmatic gen. Using a conduit to transfer power from the generator to the plug distributes the power properly.
version FluxNetworks-1.10.2-1.0.8
in modpack Sky Factory 3
running on a local smp server

Fixed in dev


Redmine: upgrade to v.3.2.2

Hi, if you want I can also add a commit for the image's 3.2.2 release (VERSION, Readme, etc).

thanks for the PR. I was holding off the release to fix #174


updating parent of image does not invalidate image ID for created images

When an image has beed built for a given cloud, further updates to (for example) the parent image does not invalidate the referenced image ID of the created image.  This makes it impossible to change the image definition once it has been built.

Demo is done. Waiting on the code review.


jpype#1091: allow null characters in strings when convertStrings=True

Previously, PyUnicode_FromString(str.c_str()) was used when convertStrings=True. If the string contains null bytes, this will terminate the string early. To allow strings with null bytes to be returned, PyUnicode_FromStringAndSize(str.c_str(), str.length()) is now used instead, which create a Unicode object from the pointer with the given length (instead of the position of the first NULL character), thus allowing null bytes in the string.
Fixes #1091

You should add tests using a mixture of Nulls with international characters (16 and 32 byte encoded) to make sure that it properly handles all cases.

Done; included tests that test strings with null bytes that SHOULD be 16 byte encoded/ 32 byte encoded.

LFTM


Missing implementation of preprocess function in 272-paint-by-example.ipynb notebook

I was going through the code in the notebook: 272-paint-by-example.ipynb, I could not find the implementation of preprocess function used in the prepare_latents method of the class OVStableDiffusionInpaintingPipeline

This is definitely missing. Please look into it.

Hi @anujonthemove
I managed to run the notebook:

The only thing that I need to modify is the grdio version: %pip install gradio==3.50.2
Once installed, restart kernel & run the cells.

Thanks for getting back to me. Yes, I know that the notebook works fine with gradio version 3.50.2 because the latest versions don't have the sketch tool for the Image component yet.
Just wanted to point out that the notebook doesn't have the preprocess function, but it still runs smoothly. The reason is that the process_latent function wraps up just before preprocess kicks in, so it doesn't impact anything.
I noticed the same thing in the 236-stable-diffusion-v2-infinite-zoom.ipynb notebook. On the flip side, the 225-stable-diffusion-text-to-image.ipynb notebook has it sorted.
If needed, I can fix it, double-check, and send in a pull request.

@anujonthemove please submit your changes in a pull request and we can discuss your proposed changes there. Refer to https://github.com/openvinotoolkit/openvino/blob/master/CONTRIBUTING.md for guidelines.


Optional JSON-encoded query parameters

Now the library can truly claim to offer "Fully typed RPC-like client"
I think the main point of discussion would be the opinionated approach of the selective encoding format of root-level strings.
The implementation, as is, will not JSON encode (i.e. surround with double quotes) a root-level string unless it clashes with a JSON reserved word or is a number.
const query = { foo: 'foo', nested: { bar: 'bar' }  };
// ?foo=foo&nested={"bar":"bar"}

const query = { foo: 'true' };
// ?foo="true"

const query = { foo: true };
// ?foo=true

const query = { foo: '123' };
// ?foo="123"

const query = { foo: 123 };
// ?foo=123

I think it's nice because this leaves the URL looking like regular query strings in the majority of use cases. This is also how swagger encodes root-level strings even if we specify the MIME type as application/json

this is sick!

I really like this approach! I'm going to review now, however I notice there is a merge conflict @Gabrola - If it's simple I'll try fix it now.

Codecov Report

Merging #115 (cef58d2) into main (7811904) will increase coverage by 1.63%.
The diff coverage is 95.83%.

@@            Coverage Diff             @@
##             main     #115      +/-   ##
==========================================
+ Coverage   82.94%   84.57%   +1.63%
==========================================
  Files           9        9
  Lines         170      188      +18
  Branches       38       44       +6
==========================================
+ Hits          141      159      +18
  Misses         19       19
  Partials       10       10

Impacted Files
Coverage Δ

libs/ts-rest/next/src/lib/ts-rest-next.ts
76.66% <83.33%> (+1.22%)
:arrow_up:

libs/ts-rest/core/src/lib/client.ts
80.00% <100.00%> (ø)

libs/ts-rest/core/src/lib/query.ts
97.36% <100.00%> (+1.71%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Cheers mate! ♥


A question about hosting

In the readme you say that the connection has to be over HTTPS, but wouldn't it also work when hosting the site locally through, for example, expressJS? If it does then I'd say it is worth adding an expressJS server.js file as well as a package.json with the proper configuration.
The latter ofc is assuming you have some basic NodeJs knowledge or don't mind learning it

I can't try it right now, but it appears to also work when loaded from the local filesystem (the WebUSB permission prompt appears), so a web server might not even be necessary.

I'm in the same boat for not being to test. I want to be careful with my device and if anything I want to wait until this summer when I should be getting a 3D printer to print one of those things to easily short the pins

You could easily host this on Github pages and get free HTTPS. Heck, @atlas44 could simply turn on Pages support for this repo and then this whole script would just work immediately via https://atlas44.github.io/web-fusee-launcher


Type error in forked repo

Just forked the loom-js repo (need the ability to manage nonces on our server), and I'm getting one error. Any ideas?
src/plasma-cash/plasma-cash-tx.ts:45:30 - error TS2345:
      Type 'Buffer' is not assignable to type 'EncodeScalarInput'.
        Type 'Buffer' is not assignable to type 'import("safe-buffer").Buffer'.
          Property 'prototype' is missing in type 'Buffer'.
45     return '0x' + rlp.encode(data).toString('hex')

(not a blocker; I can edit out the line for now, and everything builds fine)

@paulbarclay does the issue persists?

Yes, nothing appears to be changed after merging the latest commit. If it's working in pure JS, it's a bit of a miracle - rlp.encode(data) uses the Buffer class from "safe-buffer", but the Buffer in this.slot.toArrayLike(Buffer as any, 'be') as Buffer, is the Buffer interface from Node. They're almost identical, but they're not set up the same, they don't inherit the and they don't have all the same fields.


Add ability to optionally exclude sub-plays found in tasks/main.yml.

I'd like to be able to set up the plays so we can optionally exclude any of the items. If I need to run just a part of each of the defined "include" sub-plays in tasks/main.yml I can add those to a post playbook. This seems a simple first step that should not break any existing configs, but create an opportunity to enable a bit more functionality.
I would really appreciate your feedback on this idea.
How this could work
For example, you could exclude any of the parts in the role by simply declaring a variable in the top-level playbook:
    - name: hardening baseline
      hosts: hardened
      become: yes

      roles:
        - ansible-role-hardening
        - ansible-role-hardening-post

      vars:
        no_include_sudo: true
        no_include_sshconfig: true
        no_include_aide: true
        no_include_suid: true

        # no_include_adduser = true
        # no_include_aide = true
        # no_include_apparmor = true
        # no_include_apport = true
        # no_include_auditd = true
        # no_include_compilers = true
        # no_include_cron = true
        # no_include_ctrlaltdel = true
        # no_include_disablefs = true
        # no_include_disablemod = true
        # no_include_disablenet = true
        # no_include_extras = true
        # no_include_firewall = true
        # no_include_fstab = true
        # no_include_hosts = true
        # no_include_issue = true
        # no_include_journalconf = true
        # no_include_limits = true
        # no_include_lockroot = true
        # no_include_logindconf = true
        # no_include_logindefs = true
        # no_include_motdnews = true
        # no_include_mount = true
        # no_include_packagemgmt = true
        # no_include_packages = true
        # no_include_password = true
        # no_include_path = true
        # no_include_post = true
        # no_include_postfix = true
        # no_include_pre = true
        # no_include_prelink = true
        # no_include_resolvedconf = true
        # no_include_rkhunter = true
        # no_include_rootaccess = true
        # no_include_sshconfig = true
        # no_include_sudo = true
        # no_include_suid = true
        # no_include_sysctl = true
        # no_include_systemdconf = true
        # no_include_timesyncd = true
        # no_include_umask = true
        # no_include_users = true

Hi @itd, I like the idea but I don't really know with which granularity. no_include_pre is not defined will for example break a lot of things further down.
Double negatives is also almost always confusing, e.g. instead of no_include_suid: false it should be include_suid: false.

Thanks for the feedback. I do agree on the double negatives. I'll rework that. With regard to breaking items further down the chain I can see that with this rather ham fisted approach. I've seen it done with finer granularity where each individual play has a conditional:
Include_PLAY_NAME is true
although it might be that some of the play names could be returned for clarity. Would you be open to this approach? I'll return this and submit a pull request that demonstrates that for your review.

Absolutely, submit a PR and let's have a discussion about it.


Crop regen

Crop/Stick/Rock regen shouldn't happen on protected chunks

Actually we do already test for that, so nevermind


Create an SAPUI5 App from the Command Line

Tutorial URL: https://developers.sap.com/tutorials/cp-cf-sapui5-local.html
Please specify the step you are referring to: Step 5
It should be mentioned that a login to CF is required.

Hi @alteraugem,
thanks for your feedback. This particular tutorial is part of a larger tutorial group in which the login is described in the first tutorial.
Hence, I'm closing the issue. Feel free to reopen it if something is not clear.


Update workflows to skip builds for markdown-file-only changes

What problem does this PR solve?
Issue Number: N/A
Problem Summary:

The entire GitHub workflow is run, even for changes that do not require a build, such as for markdown file changes. This PR is an example of the entire workflow being run for an update to the oncall.md file. It takes approximately 30 minutes for the entire Github CI workflow to run and developers commit a standalone markdown file change at least 2 times per month.

What is changed and the side effects?
Changed:

Update GitHub workflow files to skip the ci-linux and ci-macos workflows for pushes and pull requests when the only changes are to markdown files. The result is less time spent waiting for builds to pass on both pushes and pull requests for Markdown file changes, which currently takes 30 minutes. Now, only the license check should run, which takes under 2 minutes.

Side effects:

Performance effects(性能影响): N/A

Breaking backward compatibility(向后兼容性): No

Check List:

Please make sure your changes are compilable(请确保你的更改可以通过编译).
When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
Please follow Contributor Covenant Code of Conduct.(请遵循贡献者准则).

LGTM


BART models not working

Hello,
I am unable to use any of the BART models, I'm getting the following:
panic: runtime error: slice bounds out of range [:768] with capacity 0

goroutine 1 [running]:
github.com/nlpodyssey/cybertron/pkg/converter/bart.Convert[...]({0xc000028900, 0x19}, 0x0)
	/home/bot/Documents/2023/cybertron/pkg/converter/bart/convert.go:99 +0x1471
github.com/nlpodyssey/cybertron/pkg/converter.Convert[...]({0xc000028900, 0x19}, 0x15)
	/home/bot/Documents/2023/cybertron/pkg/converter/converter.go:33 +0x175
github.com/nlpodyssey/cybertron/pkg/tasks.loader[...].convert(0xcc49c0)
	/home/bot/Documents/2023/cybertron/pkg/tasks/loader.go:278 +0x158
github.com/nlpodyssey/cybertron/pkg/tasks.loader[...].load(0xcc49c0)
	/home/bot/Documents/2023/cybertron/pkg/tasks/loader.go:91 +0x15c
github.com/nlpodyssey/cybertron/pkg/tasks.Load[...](...)
	/home/bot/Documents/2023/cybertron/pkg/tasks/loader.go:44
main.main()
	/home/bot/Documents/2023/cybertron/examples/textgeneration/main.go:28 +0x1b2

What model are you trying to use exactly and with what command?

My bad I was trying to use facebook/bart-large for the task textgeneration which is unsupported.


[Bug] Service definition does not match DID spec for type and serviceEndpoint

Bug description
The definition of the service type currently defines the type field as a string, and the serviceEndpoint as a Url
https://github.com/iotaledger/identity.rs/blob/8a97e95ae549c5e78d32336739eb349f49e977f8/identity-did/src/service/service.rs#L25-L27
The spec defines these properties to also allow set of elements
https://www.w3.org/TR/did-core/#service-properties
Expected behaviour
The service type should match the spec.
Actual behaviour
The service type only supports single strings.

In our case we store a set, with alternative endpoints to query if one is down.

A Service now allows ordered sets and maps for the serviceEndpoint field but not nested maps. This change is currently only on the dev branch until the next version release.
Sample code using the Wasm bindings to add a new Service with a set of endpoints:
let serviceJSON = {
  id: doc.id + "#linked-domain",
  type: "LinkedDomains",
  serviceEndpoint: ["https://iota.org/", "https://example.com/"],
};
doc.insertService(Service.fromJSON(serviceJSON));

or with a map:
let serviceJSON = {
  id: doc.id + "#linked-domain",
  type: "LinkedDomains",
  serviceEndpoint: {
    "origins": ["https://iota.org/", "https://example.com/"]
  },
};
doc.insertService(Service.fromJSON(serviceJSON));

Please comment here or open a new issue if there are any problems. Thank you.

@cycraig are there plans to support sets of strings for the type? We have no need for it at the moment, but I came across a comment in our code regarding this issue from @obany.

are there plans to support sets of strings for the type?

I forgot that was even a problem! Thanks for the report, will open a PR for it SoonTM.


install_supervisor.sh container script unable to locate package supervisor

Describe the bug
The build_dev.sh container build script uses a number of install scripts.  The script install_supervisor.sh fails with:
unable to locate package supervisor
This can be fixed with an apt-get -y update before the apt-get -y install
To Reproduce
Steps to reproduce the behavior:

Remove any old docker images to start fresh
run ./build_dev.sh dev.x86_64.dockerfile from docker/build

Screenshots

Desktop (please complete the following information):

OS: Ubuntu 18.04

Additional context
I created a pull request to fix this issue

code merged and close this issue, thanks!


[Impeller] ImageFiltered causing artefacts to appear on iOS

Is there an existing issue for this?

[X] I have searched the existing issues
[X] I have read the guide to filing a bug

Steps to reproduce
Run example code on iOS and Android and compare it.
Expected results
I expect no artefacts to appear inside the image when the ListView is scrolled.
Actual results
See Video
Code sample
Code sample
import 'dart:ui';

import 'package:flutter/material.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      home: Scaffold(
        appBar: AppBar(
          backgroundColor: Colors.blue,
          title: const Text('Image Filtered'),
        ),
        body: Column(
          children: [
            Stack(
              children: [
                ClipRect(
                  child: ImageFiltered(
                    imageFilter: ImageFilter.blur(
                      sigmaX: 10,
                      sigmaY: 10,
                    ),
                    child: Image.network(
                      'https://fastly.picsum.photos/id/730/1200/600.jpg?hmac=5K1V2ccArXmNO_SBJHrzrtk3K0ADaPIILWCaPDyV3P4',
                      width: double.infinity,
                      height: 100,
                      fit: BoxFit.cover,
                    ),
                  ),
                ),
                Align(
                  alignment: Alignment.topRight,
                  child: Container(
                    height: 100,
                    width: 100,
                    color: Colors.red,
                    child: const Center(
                      child: Text('100x100'),
                    ),
                  ),
                )
              ],
            ),
            Expanded(
              child: ListView.builder(
                itemCount: 100,
                itemBuilder: (context, index) {
                  return Text('Hello world $index');
                },
              ),
            )
          ],
        ),
      ),
    );
  }
}

Screenshots or Video

Screenshots / Video demonstration
https://github.com/flutter/flutter/assets/45172447/062707c3-6d38-4a3f-aa47-2f7ba6f6850e

Logs
Logs
[Paste your logs here]

Flutter Doctor output
Doctor output
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 3.16.3, on macOS 14.1.1 23B81 darwin-arm64, locale en-DE)
[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
[✓] Xcode - develop for iOS and macOS (Xcode 15.0.1)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2022.2)
[✓] Android Studio (version 2021.3)
[✓] Android Studio (version 2022.1)
[✓] VS Code (version 1.84.2)
[✓] Connected device (4 available)
[✓] Network resources

Thanks for the report @tobiasbentin
I verified the same using latest master and it seems to be working as expected, as shown below:
https://github.com/flutter/flutter/assets/67046386/e1e3a529-ff6e-450e-9963-98a9e77681ec
Since it is fixed on master, per our triage policy, I'll close this as resolved. The fix should be available in next stable release.

Awesome, thank you @darshankawar !


Winning a Joust with King's Elekk marks your revealed card twice

The Hunter card King's Elekk uses the Joust mechanic to reveal a minion in each deck. If yours costs more, you draw it. When I played my King's Elekk and won the Joust, HSTracker marked the revealed card off twice in my deck list. At that point, even though I had only drawn the one Savannah Highmane, both were marked as played, with one in hand.
Please let me know if you need  a screenshot to clarify, I can try to take one the next time I see it happen.

Actually, it occurs to me, the problem is really that revealing the card marks it as played. I played another game this morning where I played the King's Elekk and lost the Joust. The Houndmaster card that was revealed was marked as played even though I didn't get to draw it. So then when I did eventually draw my first Houndmaster, my deck list incorrectly showed that there were no more left in my deck to draw.

Same on my side. Joust should not be included.

Same issue!


Select Command with Names Displayed

Updated Select / Nusmods / Insta Commands to display names when select person

Coverage decreased (-0.04%) to 85.349% when pulling 6aff7fc617fd7c218f50c636bfd28d0b2f4a7379 on awarenessxz:v1.5_Code_Enhancement into 5a94962fd556abf8e742de857c41a883bef49702 on CS2103AUG2017-W14-B2:master.


babel-plugin-jest-hoist: NodeJS v12 global.process and global.Buffer not enumerable

🐛 Bug Report
In the v12 of NodeJS, they changed the list of enumerable globals. Most notably process and Buffer are no longer enumerable. So this makes tests fail if global mock implementations use any of them.
To Reproduce
Steps to reproduce the behavior:

Upgrade to the latest node:
> npm install -g node

Create a test file test.js like:

jest.mock('./a', function() {
  return process;
});

Run test
npx jest ./test.js

This will fail with
babel-plugin-jest-hoist: The module factory of `jest.mock()` is not allowed to reference any out-of-scope variables.
    Invalid variable access: process
    Whitelisted objects: Array, ArrayBuffer, Boolean, DataView, Date, Error, EvalError, Float32Array, Float64Array, Function, Generator, GeneratorFunction, Infinity, Int16Array, Int32Array, Int8Array, InternalError, Intl, JSON, Map, Math, NaN, Number, Object, Promise, Proxy, RangeError, ReferenceError, Reflect, RegExp, Set, String, Symbol, SyntaxError, TypeError, URIError, Uint16Array, Uint32Array, Uint8Array, Uint8ClampedArray, WeakMap, WeakSet, arguments, console, expect, isNaN, jest, parseFloat, parseInt, require, undefined, global, clearInterval, clearTimeout, setInterval, setTimeout, queueMicrotask, clearImmediate, setImmediate.
    Note: This is a precaution to guard against uninitialized mock variables. If it is ensured that the mock is required lazily, variable names prefixed with `mock` (case insensitive) are permitted.

Expected behavior
It is expected for jest to know about globals.
Run npx envinfo --preset jest
Paste the results here:
System:
    OS: macOS Mojave 10.14.4
    CPU: (4) x64 Intel(R) Core(TM) i7-6660U CPU @ 2.40GHz
  Binaries:
    Node: 12.1.0 - /usr/local/bin/node
    Yarn: 1.15.2 - /usr/local/bin/yarn
    npm: 6.9.0 - /usr/local/bin/npm
  npmPackages:
    jest: file:../../../node_modules/jest => 24.8.0

Suggested fix
I can suggest a quick and fair IMO fix. In https://github.com/facebook/jest/blob/master/packages/babel-plugin-jest-hoist/src/index.ts instead of
Object.keys(global).forEach(name => {
  WHITELISTED_IDENTIFIERS.add(name);
});

do
Object.getOwnPropertyNames(global).forEach(name => {
  WHITELISTED_IDENTIFIERS.add(name);
});

A PR #8429 submitted.
Quick workaround
For referencing process or Buffer in mock, you can use global like
jest.mock('./a', function() {
  return global.process;
});

#8429


Don't hold the GIL when calling anything in core

Looks mostly good; I think all my comments felt minor.
Even if just on your local machine, is this something we want to test five times, twenty times, a hundred times, or more?

Repeating offline statements: my local machine's been running this on repeat for the past two hours. :-) Running with a thousand iterations, and I guess we'll know by tomorrow.

Current Python mac,opt failure on Jenkins is a transient build failure.

'_ssl.c:574: The handshake operation timed out'; I agree.

How'd the thousand iterations turn out?

No freezes having to do with the change, as far as I can tell. There was the already known pipe-buffer-deadlock issue we discussed earlier this afternoon, but that was it.

No further comments; this looks good.
In accordance with Keeping The Build Green Going Forward this will require a rerun of the basic tests, right?

Ayep. I can't press the button from the DMV, though. -.-'

Python is green.

Merging this as it should further decrease python flakiness.


Implement resources for account, session and utility

I've started dipping my toes into this again. I'm not sure if this is the right solution as it doesn't use enif_alloc_resource. This seems to return a reference to the location in memory for the account. I'm guessing this means it won't be automatically garbage collected as we will need to call enif_release_resource manually.
Edit: can confirm this is the case: enif_alloc (BEAM specific implementation of malloc) is probably a good call as we'll want to manually release the memory.
Edit2: I'm not sure using enif_alloc with enif_make_resource is safe...
Edit3: Now sure we need enif_alloc_resource.
I'm starting with a thin wrapper, we can add another layer which abstracts memory management in future.
Edit4: Got resources to work (I think), not sure what the API should look like in this case.
Re-memory-abstraction: perhaps things like account_size should be abstracted in init_account for example?
@fancycade I'm punching above my weight on this, some guidance would be highly appreciated.

Okay a few thoughts. First I will claim I am no expert, as a lot of these specifics are new to me as well.
alloc_resource seems like the way to go. What you did in init_account seems correct based on the documentation. I think we want to avoid manual memory deallocation as much as possible. So the alloc_resource + make_resource + release_resource combo is the key according to this. From my understanding this will deallocate during garbage collection. I'm still a little confused by the static resources, but hey, what do I know.
IMO, it might be good to start with just account, before we get to session and utility. I really like the python-wrapper as a reference. Going with that, I think it makes sense to try to replicate the README examples in the tests as a type of guiding light.
If you want I can take a swing at this over the weekend.

From my understanding this will deallocate during garbage collection. I'm still a little confused by the static resources, but hey, what do I know.

You mean the static resource types e.g., static ErlNifResourceType* account_resource;?

IMO, it might be good to start with just account, before we get to session and utility. I really like the python-wrapper as a reference. [...] For now the Olm module can be the wrapper, and then we can build convenience features with that.

Agreed!

If you want I can take a swing at this over the weekend.

I'll keep working on it and we can reevaluate then 👍

Replaced with #14


Calling the parent click handler

Is it possible to invoke the parent's click behavior when providing a click function?
E.g., when the special d3plus_other is clicked I would like to default behavior.
.mouse({
	"click" : function(dp, d3viz) {
		if (dp.my_id == "d3plus_other") {
			return true;
		} else if

Currently we've worked around this by returning true/false and changing D3plus to run its click code on true. I would very much like to avoid changing anything in the original library though.

If I'm understanding this correctly: Do you want to be able to invoke the default click behavior, given a certain condition?

Yes, under some condition I do not want to provide behavior, default is fine (e.g. zooming into the other rectangle in a tree-map)

closed in favor of #447


Web component host reset

I've been using this reset with web components (via LitElement). In doing so, I've found that the reset (both  unset: all and display: revert) causes a lot of problems related to styling the :host (shadow root) selector.
Problem
Research suggests that the specificity for the :host selector is intended to make it act as the default style for a custom element. Therefore, it is expected to be overridden by any other styles.
That places the shadow root in quite an awkward position following a reset. After all, the purpose of a reset is to strip browser styling. After that, any user-authored styling (including the defaults of custom elements) should be respected.
Solution
My solution is to add display: contents !important to the :host selector in each component. Then, if a custom root is desired, it can be implemented as a separate class, applied to a container element (like a div).
/* Pass through root */
:host {
	display: contents !important;
}

/* Custom root */
.container {
	display: flex;
}

This solution is ideal in my case, because I don't like that shadow roots participate in the document layout in the first place; I prefer the pass-through behavior of React fragments (<></>).
Related
Related external links:

Is it possible to increase specificity host selector shadow root custom element?
Why do element selectors supersede the :host selector in custom elements with shadow DOM

If I am reading this correctly, the issue descried above is discussing the use of the-new-css-reset within a component. It appears that it also can occur when using it in a page that is consuming a web component.
For example,
<script type="module"<EMAIL_ADDRESS>/>
<ion-icon name="heart" />

displays a heart inline, where as
<link rel="stylesheet"<EMAIL_ADDRESS>/>
<script type="module"<EMAIL_ADDRESS>/>
<ion-icon name="heart" />

displays a huge heart.

I too am running into this problem and its making it very difficult to even consider using this reset as a result. I wish there was a way to include the :host selector in the  where clause like so :where(:not([elements here] , :host):not([other stuff]))
Anyone else find a way around this? The reset does a 90% good job for my design system needs but this is a big 10% problem

If I am reading this correctly, the issue descried above is discussing the use of the-new-css-reset within a component. It appears that it also can occur when using it in a page that is consuming a web component.

This is also my experience. My workaround was to reset the relevant properties manually, e.g:
ion-icon {
    fill: currentcolor;
    height: 1em;
    width: 1em;
}


Problems with CA_CERTS

I need to user certs with my ES connection.  In the code it appears as though ca_certs is accepted in the constructor but goes unused.  Is that correct?  Is this a bug or am I not correctly using ca_certs?

I think the solution here is to support an ssl_context in the TCPConnector.  I'd suggest doing this by adding ssl_context as a top level parameter in the constructor for AIOHttpConnection

@quasiben Thanks for the feedback. ca_certs is being deprecated. But hasn't been removed yet.
Though I missed adding the ability to use ssl_context to the TCPConnector.
Thanks for the feedback will get on this.

This has been fixed in https://github.com/elastic/elasticsearch-py-async/pull/30


About ko-kr FormatCode incorrect Issue

I'm a korean developer.
I am using xlsjs(v0.7.5).
I expected the correct formatcode about ("yyyy-mm-dd") date Format.
But always rendered data is mm/dd/yy that is formatcode 14...
In . ECMA-376
ko-kr "yyyy-mm-dd" formatcode is 34, 35, 52, 53, 55, 56
I want to get correct formatcode about "yyyy-mm-dd" ko-kr date Format.
Is there I missing step on locale setting at sheetjs??
I'm waiting your Response

Discussion at https://github.com/SheetJS/js-xlsx/issues/200


[DeveloperHub] config readme.python

https://github.com/Azure/sdk-release-request/issues/3200

/azp run


Notebook Getting Started Bug Tracking

Note: This is a temporary issue just for bug discussion / tracking. Should be closed after this iteration.
As of 7/7/2022 this is my current groupings of the Getting Started bugs.
Python Extension install / Jupyter Extension install
•	Don't show the "Notebooks might need to be restarted" prompt after Python Extension is installed (or at all?)
•	Install kernels from the marketplace only lists Jupyter
•	Extension dependency issues when building python dev containers
•	Don't notify the user to reload after installing the extension
•	Impossible to run any notebook without Python extension when RAW isn't supported
Python / pip install
•	Change our "Install Python" command to use the Python contributed command
•	Install Python shows up if in remote mode
•	Selecting install from prompt when missing pip fails because pip is not available
•	Zmq Not supported and requiring Python for Jupyter (5897 dupe?)
IPyKernel Install
•	Consider adding a More Info button to the modal dialog prompt requiring users to install ipykernel
•	installing ipykernel looks successful after hitting permission denied
•	Change prompt text that requires users to upgrade ipykernel to a newer version
•	Reword ipykernel installation message
•	Unclear why "Ipykernel setup required for this feature" is showing up for new setups and trying to run-by-line
•	Identify kernels that have ipykernel installed to kernels picker.
•	Version 2 of "I installed ipykernel 6, but I still can't use run-by-line"
•	I installed ipykernel 6 to try run-by-line, but I don't want to have to restart the kernel.
•	I misread the modal dialog about installing ipykernel 6. I thought it was telling me to install with pip.
•	Option to change kernel sends me down a rabbit hole
Performance
•	building of wheel taking a long time
•	Mitigate slow kernel discovery (API adoption, placeholder kernels, measurements)
Initial Suggested Kernel
•	2.x python kernel suggested but no longer supported
•	Automatically disconnect local conda kernel and switch to dummy kernel. (Probably fixed)
•	Auto picked kernel after running 'Connect to Github' is .NET (remote)
•	Allow a machine to configure the default Python interpreter version
•	Preferred Python Notebook Kernel
•	Losing selected kernel when installing python extension
•	Jupyter notebooks not using Python in current path
•	Show available kernels rather than languages in Create New Blank Notebook UI
Notifications / Prompts
•	If Python is missing server auto starter tries to run and pops up the "Needs Python Extension" modal
•	Wall of notifications
•	Notification overload when installing ipykernel
Remote
•	Remote jupyter server failures are not diagnosable
•	ModuleNotFound errors on remote could indicate that files are not copied to the remote machine
•	Consider treating Notebooks in remote repositories like they are in untrusted workspaces
Jupyter Starting
•	Cannot resolve starting jupyter if active interpreter doesn't support jupyter
•	Kernels using 32-bit Python environments installed via conda does not work
•	Jupyter interpreter can be invalid and break things
•	Ship our own Jupyter to eliminate configuration problems
Environment setup / configuration
•	Investigate a method to create or suggest a virtual environment with ipykernel + needed packages for a given notebook
•	Create a 'blessed' environment that has known modules installed
•	Consider adding a blessed basic environment to install with the Jupyter extension
Basic Initial Workflow (everything works, something very basic in work flow is confusing)
•	Set new notebook folder location
Tutorials / Docs / Walkthroughs
•	"Run by line" tutorial is hard to navigate
•	Walkthrough text is not localized
•	'Select a kernel' walkthrough step button does nothing
•	Jupyter Notebook Tutorial
Aggregate / Grouping issues
•	Making it easy to get started with the Jupyter extension
•	Proposal for proxy kernels (as it's more of a broad work item)
•	Notebook getting started experience challenges/questions
•	Improvements to getting started experience for DS
Not "Getting Started" issues
•	If I open an ipynb and then select a kernel for it, opening a Python terminal should activate the same environment

https://github.com/microsoft/vscode-jupyter/issues/10552 should probably be added here as well.

Closing meta issue.


Automated cherry pick of #7722: update host status to unknown on host offline

Cherry pick of #7722 on release/3.3.
#7722: update host status to unknown on host offline

/lgtm
/approve


Save the coordinates and time when releasing cursor

Otherwise, we won't have a reference to when the trajectory could have started.

While we are here, clean up the way add_current_coordinates gets bound/unbound. Set fake_cursor's attribute, don't pass it, don't handle listeners in mousetracking.


Cannot read property 'statements' of undefined when installing @ngtoolkit/universal

I'm submitting a...

[x] Bug report
[ ] Feature request
[ ] Documentation issue or request

In package

[ ] @ng-toolkit/init
[ ] @ng-toolkit/serverless
[x] @ng-toolkit/universal

Current behavior
Trying to install @ng-toolkit/universal in an existing Angular 6 project.
I get the following error when installing - Cannot read property 'statements' of undefined.
The modules are not installed.
I then have tried installing with Yarn. however this only installs the modules and doensn't run the post install scripts.
Expected behavior
Should install completely with no errors.
Minimal reproduction of the problem with instructions

Example repository

What is the motivation / use case for changing the behavior?

Environment

Angular CLI version 6.0.0
NPM 6.1.0
@angular-devkit/architect         0.6.0
@angular-devkit/build-angular     0.6.8
@angular-devkit/build-optimizer   0.6.8
@angular-devkit/core              0.6.8
@angular-devkit/schematics        0.6.8
@angular/pwa                      0.6.8
@ngtools/webpack                  6.0.8
@schematics/angular               0.6.8
@schematics/update                0.6.0
rxjs                              6.2.1
typescript                        2.7.2
webpack                           4.8.3

Browser:
- [ ] Chrome (desktop) version XX
- [ ] Chrome (Android) version XX
- [ ] Chrome (iOS) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] Safari (iOS) version XX
- [ ] IE version XX
- [ ] Edge version XX

For Tooling issues:
- Node version: XX
- Platform:

Others:

I encountered the same error.
My environment is:
_Angular CLI: 6.0.8
Node: 8.11.2
OS: win32 x64
Angular: 5.2.11
... animations, common, compiler, compiler-cli, core, forms
... http, platform-browser, platform-browser-dynamic
... platform-server, router
Package                           Version
@angular-devkit/architect         0.6.8
@angular-devkit/build-angular     0.6.8
@angular-devkit/build-optimizer   0.6.8
@angular-devkit/core              0.6.8
@angular-devkit/schematics        0.6.8
@angular/cli                      6.0.8
@angular/language-service         4.4.6
@ngtools/webpack                  6.0.8
@schematics/angular               0.6.8
@schematics/update                0.6.8
rxjs                              5.5.5
typescript                        2.9.2
webpack                           4.8.3_

@maciejtreder - be great to get some help on this.

Same here!

Same error.
Angular CLI: 6.0.8
Node: 8.9.3
OS: darwin x64
Angular: 6.0.7
... animations, common, compiler, compiler-cli, core, forms
... http, language-service, platform-browser
... platform-browser-dynamic, router
Package                           Version
@angular-devkit/architect         0.6.8
@angular-devkit/build-angular     0.6.8
@angular-devkit/build-optimizer   0.6.8
@angular-devkit/core              0.6.8
@angular-devkit/schematics        0.6.8
@angular/cdk                      6.3.3
@angular/cli                      6.0.8
@ngtools/webpack                  6.0.8
@schematics/angular               0.6.8
@schematics/update                0.6.8
rxjs                              6.2.1
typescript                        2.7.2
webpack                           4.8.3


Provider Config UI: Notify system of updated provider configuration at runtime

Alert the system of updated provider configuration at runtime (to avoid restart to re-load the settings).
This will be very important when we move the providers out to individual service processes

Fixed with #319 by restarting the web app


How to add newer angularjs release into baiducdnstatic?

How to add newer angularjs release into baiducdnstatic?
the latest angularjs reached 1.3.11

http://cdn.code.baidu.com/about#how

已经更新了

the 1.3.* branches is abit outofdate


Add a detailed Mixin tutorial in advanced area.

I wrote a Mixin tutorial. I also warn the readers that they should use Events rather than Mixin for safety.

Thanks for your recommendations. I have improved and changed most of the pages I uploaded. Please review them and contact me if there are any mistakes.

Thanks for your concern and recommendations, which are really helpful for me. I am only a college student and a beginner at Minecraft modding actually. I wrote those documents based on my development experience. Sorry for my incomplete document contribution. I am a little tired these days and I am afraid that I cannot answer some of your questions. You can close this PR if this bothers you and I will continue to study in the future. Again, thanks for your patience.

It's fine. If you don't have the time to contribute or address the issues, then you're welcome to leave it alone or close at a later point in time depending on if you ever wish to come back to this.


Increment version for support releases

Increment package version after release of Azure.ResourceManager.Support

API change check
API changes are not detected in this pull request.


In v3.8.0, ETA()/AdaptiveETA() does not work as expected

When I use ETA()/AdaptiveETA(), what I get is "Elapsed Time" rather than "ETA".
For example, when I run example with command python2 example.py eta, what I get is
Skipping with_example
Skipping with_example_stdout_redirection
Skipping basic_widget_example
Skipping file_transfer_example
Skipping custom_file_transfer_example
Skipping double_bar_example
Skipping basic_file_transfer
Skipping simple_progress
Skipping basic_progress
Skipping progress_with_automatic_max
Skipping progress_with_unavailable_max
Skipping animated_marker
Skipping counter_and_timer
Skipping format_label
Skipping animated_balloons
Skipping animated_arrows
Skipping animated_filled_arrows
Skipping animated_wheels
Skipping format_label_bouncer
Skipping format_label_rotating_bouncer
Skipping with_right_justify
Skipping exceeding_maximum
Skipping reaching_maximum
Skipping stdout_redirection
Skipping stderr_redirection
Skipping negative_maximum
Skipping rotating_bouncing_marker
Skipping incrementing_bar
Skipping increment_bar_with_output_redirection
Skipping eta_types_demonstration
Skipping adaptive_eta_without_value_change
Skipping iterator_with_max_value
Running: eta
Test:   0% | ETA: ETA:  --:--:-- | AbsoluteETA: Estimated finish time:  ----/--/-- --:--:-- | AdaptiveETA:Test:   4% | ETA: Elapsed Time: 0:00:00 | AbsoluteETA: Elapsed Time: 0:00:00 | AdaptiveETA: Elapsed Time: Test:   6% | ETA: Elapsed Time: 0:00:00 | AbsoluteETA: Elapsed Time: 0:00:00 | AdaptiveETA: Elapsed Time:

Fixed by your own pull request. Thanks!

In v3.9.0, AdaptiveETA will not decrease as time goes on.
For example, when I run the example with python2 examples.py eta, the AdaptiveETA value will be stuck at 00:00:04.
But what I expected is that it will decreases its value as time goes on, just as what ETA does.

You were right, I made a pretty silly mistake with the values by using the delta instead of the total value when calculating the remaining items.
Thanks for the help :)


Catchup on old merges

Minor fixes I spotted in reviewing recent merges. Huge thanks to @politas and @pjf for going through them.
Seeing you guys push some merges fills me with determination.

Nice catches!


add FlushStatus enum

Summary
Update the ChannelState to include a FlushStatus enum, as per the spec for channel upgradeability. Please note that the naming for the different flushing states is still under discussion.

For Admin Use

[ ] Not duplicate issue
[ ] Appropriate labels applied
[ ] Appropriate contributors tagged/assigned

completed in #3702


Rename error result change when source does not exist

What version of Go are you using (go version)?
go1.8
What operating system and processor architecture are you using (go env)?
GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH=""
GORACE=""
GOROOT="/Users/jeff/external/golang"
GOTOOLDIR="/Users/jeff/external/golang/pkg/tool/darwin_amd64"
CC="clang"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/tn/09dglcts0b9gc5111hnf0_dm0000gn/T/go-build647286002=/tmp/go-build -gno-record-gcc-switches -fno-common"
CXX="clang++"
CGO_ENABLED="1"
What did you do?
run this program under go1.7 and go1.8
package main

import (
	"fmt"
	"os"
)

func main() {
	os.Mkdir("destination", 0755)
	os.Create("destination/nonempty")
	err := os.Rename("doesnt-exist", "destination")
	fmt.Println(os.IsNotExist(err), err)
}

https://play.golang.org/p/v4gGML3VCP
What did you expect to see?
the same output
What did you see instead?
$ go1.7 run main.go
true rename doesnt-exist destination: no such file or directory
$ go1.8 run main.go
false rename doesnt-exist destination: file exists

Fixing issue #14527 in CL https://golang.org/cl/31358 caused this (it checks if the destination is a directory before attempting the rename). There are many places in my code base where I optimistically attempt to migrate some old directory path to a new one, and all of them will have to include a check that the old directory exists first to maintain idempotency.

Yes, this was intentional.
https://golang.org/doc/go1.8#os says:

On Unix systems, os.Rename will now return an error when used to rename a directory to an existing empty directory. Previously it would fail when renaming to a non-empty directory but succeed when renaming to an empty directory. This makes the behavior on Unix correspond to that of other systems.

The fix that works on both Go 1.7 and Go 1.8 is to write instead:
	err := os.Rename("doesnt-exist", "destination/doesnt-exist")

You misunderstand. The difference is that in go1.7 the error that is returned is that the source does not exist, and in go1.7 the error that is returned is that the destination already exists. That semantic change caused bugs for me, and so I was hoping to maintain the property that if you attempt to rename with a source that doesn't exist, that check is performed first. The mv command has this property, for example.

To be clear, I'm fine with go1.8 erroring because the destination already exists, it would just be good if it errored that the source does not exist first to maintain compatibility with go1.7.

Gotcha.
But now that the behavior has changed in a released version of Go, I'm not sure how much good (or harm) it does to change it again. We've never documented the precedence of errors between the two possible failure cases.
The only reliable thing to do is stat your source file first, before the rename.
I can reopen for a decision, but I don't see a great answer.

/cc @rsc @ianlancetaylor

The only reliable thing to do is stat your source file first, before the rename.

Doesn't sound very reliable due to potential race condition, though.

Then do it afterwards, or afterwards also to disambiguate between the two possible errors. Like I said, we've never documented which of the src error vs dest error is returned first if both are bogus.

I think this is not important enough to fix for Go 1.8.1. I don't mind if someone feels strongly and wants to add an Lstat of oldname for Go 1.9.


Compilation will fail when the type error is automatically deduced

The example is when I use the gfx-hal library, I encountered the following situation：
`    let (instance, surface, adapter) = {
let instance = backend::Instance::create(APP_NAME, 1).expect("Backend not supported");
let surface = unsafe {
instance
.create_surface(&window)
.expect("Failed to create surface for window")
};
let adapter = instance.enumerate_adapters().remove(0);
    (instance, surface, adapter)
};`

The plugin deduces the type of surfae as ()，And the subsequent calls about the surface all showed errors, even when I directly performed cargo build in the terminal, there was an error.

It's not exactly clear to me how a rust-analyzer type inference bug can cause cargo build to fail when run from a terminal. Can you prepare a repository showing the issue?

I describe it in more detail：
When I write this code on vscode，the first derivation goes like this:
let surface:() = unsafe {     instance.create_surface(&window).expect("Failed to create surface for window") };
In the subsequent code, there are error prompts for surface calls，But it's not a big deal. It usually runs normally directly on the terminal useing -cargo run- .
But when I use -cargo run- directly this time, the errors I get are consistent with the errors I get from derivation.
It wasn't until I commented out the above code, and then uncommented again, so that the derivation type was deduced correctly after refreshing.

If you actually write let surface: (), that will of course give type errors. I don't see how that's related to rust-analyzer, though.


Package request: raptor ("Call Of The Shadows", game)

Project description
Reversed-engineered source port from the game Raptor: Call Of The Shadows.
Metadata

homepage URL: https://github.com/skynettx/raptor
source URL: https://github.com/skynettx/raptor
license: gpl2
platforms: linux,darwin

Oops. Superseeded by: https://github.com/NixOS/nixpkgs/issues/361555


⚠ Bofrost.lu has degraded performance

In 85eafe4, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 2943 ms

Resolved: Bofrost.lu performance has improved in 60fff97 after 40 minutes.


Issue 7: Import fails. Blank Screen. No Error Messages.

Problem  with file name sanitization from title. Imported pre-built file sanitizer.
Note: not a JS developer, don't know much about NPM. Please verify changes.

Wow, google keep has added a bunch of refinements to it's interface since I last opened it. Interesting.
I'm trying to look for annotations though and I can't find anything related to annotations. Can you fill me in please.

In regard to the filename sanitisation, did this actually fix your import issue?
Valid filenames are different on different operating systems. Do you know if this operation takes that into account? I know from other obsidian discussions that some users don't want to be limited by restrictions that aren't relevant to their platform.
I don't think that's a great the approach personally as it can create unexpected cross platform issues in the future for people, but I can't quite tell for certain from filename-santitize's npm page. Do you know?

Also, thanks for writing the file extension stripping function too :)

In regard to the annotations, here's json export I jsut created where I tried to switch on and add everything I could see as possible in keep. No annotations.
Does this come from a novel workflow that I'm not aware of?
T_h_is _is a name.json.zip

Yes, it did fix my import issue.
From: https://github.com/parshap/node-sanitize-filename, it is cross-platform compliant.
Additional thought:
The issue with Obsidian becoming unresponsive if the problem is not fixed is that there is an infinite loop created by calling the function recursively in the catch block. Even with the fix, the possibility exists that without some kind of check, an infinite loop could be created. I’d suggested that there should be a max number of “version” beyond which the function will just bail out and error.
From: Dale de Silva @.>
Sent: Friday, July 21, 2023 7:35 PM
To: daledesilva/obsidian_google-keep-import @.>
Cc: thesamim @.>; Author @.>
Subject: Re: [daledesilva/obsidian_google-keep-import] Issue 7: Import fails. Blank Screen. No Error Messages. (PR #9)
In regard to the filename sanitisation, did this actually fix your import issue https://github.com/daledesilva/obsidian_google-keep-import/issues/7 ?
Valid filenames are different on different operating systems. Do you know if this operation takes that into account? I know from other obsidian discussions that some users don't want to be limited by restrictions that aren't relevant to their platform.
I don't think that's a great the approach personally as it can create unexpected cross platform issues in the future for people, but I can't quite tell for certain from filename-santitize's npm page. Do you know?
—
Reply to this email directly, view it on GitHub https://github.com/daledesilva/obsidian_google-keep-import/pull/9#issuecomment-1646357924 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ABIRYKIEQU7CY5MCH7BIPQTXRMN3FANCNFSM6AAAAAA2TJ3CNI .
You are receiving this because you authored the thread.Message ID: @.***>

Welcome.
From: Dale de Silva @.>
Sent: Friday, July 21, 2023 7:35 PM
To: daledesilva/obsidian_google-keep-import @.>
Cc: thesamim @.>; Author @.>
Subject: Re: [daledesilva/obsidian_google-keep-import] Issue 7: Import fails. Blank Screen. No Error Messages. (PR #9)
Also, thanks for writing the file extension stripping function too :)
—
Reply to this email directly, view it on GitHub https://github.com/daledesilva/obsidian_google-keep-import/pull/9#issuecomment-1646358027 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ABIRYKPNH22U4DHOVB6HQC3XRMN4TANCNFSM6AAAAAA2TJ3CNI .
You are receiving this because you authored the thread.Message ID: @.***>

Out of the 831 keep notes I have, 700 of them have annotations.
I think that they are notes that I’ve shared to Keep on Android. It looks like “annotations” is how they keep track of information required to show the associated web sites.
Here are a couple of examples.
From: Dale de Silva @.>
Sent: Friday, July 21, 2023 7:51 PM
To: daledesilva/obsidian_google-keep-import @.>
Cc: thesamim @.>; Author @.>
Subject: Re: [daledesilva/obsidian_google-keep-import] Issue 7: Import fails. Blank Screen. No Error Messages. (PR #9)
In regard to the annotations, here's json export I jsut created where I tried to switch on and add everything I could see as possible in keep. No annotations.
Does this come from a novel workflow that I'm not aware of?
T_h_is _is a  https://github.com/daledesilva/obsidian_google-keep-import/files/12135312/T_h_is._is.a._name_.json.zip name.json.zip
—
Reply to this email directly, view it on GitHub https://github.com/daledesilva/obsidian_google-keep-import/pull/9#issuecomment-1646362175 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ABIRYKMSXKEX6LNIWJJM5Z3XRMPZBANCNFSM6AAAAAA2TJ3CNI .
You are receiving this because you authored the thread.Message ID: @.***>

Strangely, the Google Keep API (https://developers.google.com/keep/api/reference/rest/v1/notes) does not document annotations at all.
From: Sami Mikhail @.>
Sent: Saturday, July 22, 2023 11:13 AM
To: 'daledesilva/obsidian_google-keep-import' @.>; 'daledesilva/obsidian_google-keep-import' @.>
Cc: 'Author' @.>
Subject: RE: [daledesilva/obsidian_google-keep-import] Issue 7: Import fails. Blank Screen. No Error Messages. (PR #9)
Out of the 831 keep notes I have, 700 of them have annotations.
I think that they are notes that I’ve shared to Keep on Android. It looks like “annotations” is how they keep track of information required to show the associated web sites.
Here are a couple of examples.
From: Dale de Silva @.*** @.> >
Sent: Friday, July 21, 2023 7:51 PM
To: daledesilva/obsidian_google-keep-import @. @.> >
Cc: thesamim @. @.> >; Author @. @.***> >
Subject: Re: [daledesilva/obsidian_google-keep-import] Issue 7: Import fails. Blank Screen. No Error Messages. (PR #9)
In regard to the annotations, here's json export I jsut created where I tried to switch on and add everything I could see as possible in keep. No annotations.
Does this come from a novel workflow that I'm not aware of?
T_h_is _is a  https://github.com/daledesilva/obsidian_google-keep-import/files/12135312/T_h_is._is.a._name_.json.zip name.json.zip
—
Reply to this email directly, view it on GitHub https://github.com/daledesilva/obsidian_google-keep-import/pull/9#issuecomment-1646362175 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ABIRYKMSXKEX6LNIWJJM5Z3XRMPZBANCNFSM6AAAAAA2TJ3CNI .
You are receiving this because you authored the thread.Message ID: @.*** @.***> >


[Quantize Finetuning & Compiling]AssertionError: 'bias' should not be None.

Hi,
I quantized our custom resent50 model, but it had big accuracy loss when doing evaluation. Therefore, I referred to the user guide to do Quantize Finetuning and the final model had a little accuracy loss. However, there was an error during model compiling (there was no error at compiling before finetuning step). The error message is as below:
 **************************************************
* VITIS_AI Compilation - Xilinx Inc.
**************************************************
[INFO] Namespace(inputs_shape=None, layout='NHWC', model_files=['./compal_model/quantized/quantized.h5'], model_type='tensorflow2', out_filename='./compal_model/vai_c_output_ZCU102//compal_tf2_resnet50_org.xmodel', proto=None)
[INFO] tensorflow2 model: compal_model/quantized/quantized.h5
/opt/vitis_ai/conda/envs/vitis-ai-tensorflow2/lib/python3.7/site-packages/xnnc/translator/tensorflow_translator.py:1752: H5pyDeprecationWarning: dataset.value has been deprecated. Use dataset[()] instead.
  value = param.get(group).get(ds).value
[INFO] parse raw model     : 99%|▉| 124/125 [00:00<00:00, 45718.50it/s]
Traceback (most recent call last):
  File "/opt/vitis_ai/conda/envs/vitis-ai-tensorflow2/bin/xnnc-run", line 33, in <module>
    sys.exit(load_entry_point('xnnc==1.3.0', 'console_scripts', 'xnnc-run')())
  File "/opt/vitis_ai/conda/envs/vitis-ai-tensorflow2/lib/python3.7/site-packages/xnnc/__main__.py", line 194, in main
    normal_run(args)
  File "/opt/vitis_ai/conda/envs/vitis-ai-tensorflow2/lib/python3.7/site-packages/xnnc/__main__.py", line 178, in normal_run
    in_shapes=in_shapes if len(in_shapes) > 0 else None,
  File "/opt/vitis_ai/conda/envs/vitis-ai-tensorflow2/lib/python3.7/site-packages/xnnc/xconverter.py", line 131, in run
    xmodel = CORE.make_xmodel(model_files, model_type, _layout, in_shapes)
  File "/opt/vitis_ai/conda/envs/vitis-ai-tensorflow2/lib/python3.7/site-packages/xnnc/core.py", line 104, in make_xmodel
    model_files, layout, in_shapes=in_shapes, model_type=model_t
  File "/opt/vitis_ai/conda/envs/vitis-ai-tensorflow2/lib/python3.7/site-packages/xnnc/translator/tensorflow_translator.py", line 97, in to_xmodel
    model_name, raw_nodes, layout, in_shapes, model_fmt, model_type
  File "/opt/vitis_ai/conda/envs/vitis-ai-tensorflow2/lib/python3.7/site-packages/xnnc/translator/tensorflow_translator.py", line 163, in create_xmodel
    xmodel = cls.__create_xmodel_from_tf2(name, layers, layout, in_shapes)
  File "/opt/vitis_ai/conda/envs/vitis-ai-tensorflow2/lib/python3.7/site-packages/xnnc/translator/tensorflow_translator.py", line 1121, in __create_xmodel_from_tf2
    xnode.bias = param.get(wrapper_name).get("bias:0")
  File "/opt/vitis_ai/conda/envs/vitis-ai-tensorflow2/lib/python3.7/site-packages/xnnc/ir/xnode.py", line 2974, in bias
    assert bias is not None, "'bias' should not be None."
AssertionError: 'bias' should not be None.

How to solve it?
Thanks

Hi @hill19850213
Thank you for your feedback. It probably be a bug.
Could you please share the quantized model so that we can test it and find a work round for it. Thank you.

Hi @qianglin-xlnx ,
Can I send private message to you?
Thanks
Sitting

Hi @qianglin-xlnx ,
Can I send private message to you?
Thanks
Sitting

Sure. Your email is?

Hi @qianglin-xlnx ,
My mail is<EMAIL_ADDRESS>Thanks
Sitting

I've already reported this error internally - its scheduled to be fixed in 1.4

Hi @foolmarks ,
When do Xilinx release vitis ai 1.4?
Hi @qianglin-xlnx ,
I hope you can find the workaround.

Hello, Sorry for reopening the issue!!
Since we are not sure about Vitis 1.4 release, is there any workaround to solve this problem!
Thanks in advance

@zackdilan
I believe something is in the works - pls ping me again mid next week.


fix: Upgrade url-parse version to 1.5.1+ to fix CVE-2021-27515 #380

Bump url-parse dependency due to vulnerability in the versions before 1.5.0
Description
Upgrade url-parse version to 1.5.1+ to fix CVE-2021-27515 #380
Motivation and Context

#380
https://advisories.gitlab.com/advisory/advnpm_url_parse_CVE_2021_27515.html

Types of Changes

[x] Bug fix (non-breaking change which fixes an issue)

Checklist

[ ] I have added tests to cover my changes.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] My code follows the code style of this project.
[x] My commits and the title of this PR follow the Conventional Commits Specification.
[x] I have read the contributing guidelines.

Thanks for this PR @p01. It seems like a few more test are failing.
On another note, the post fix of / seems like it could be a breaking change.

Closing in favor of #426. Currently blocked by a regression introduced in v1.5.x.


PR popup appears even where there's already a PR for that branch

This popup:

If I click on it, I'm brought to the compare page where GitHub shows me that there's already a PR:

That's actually a GitHub feature, we just move it around. GitHub bug

You can report it to GitHub here: https://github.com/contact


not wrote profile any more。

Warning: The set-output command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
and then not Wrote IOS_APP_DEVELOPMENT profile  any more。。

I get the below
Run<EMAIL_ADDRESS>bundle-id: ***
api-key-id: ***
issuer-id: ***
profile-type: IOS_APP_STORE
api-private-key: specified
api-private-key-file:
token-duration:
3 profiles found.
Wrote IOS_APP_STORE profile ***
Wrote IOS_APP_STORE profile ***
Wrote IOS_APP_STORE profile ***

Warning: The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-[11](https://github.com/QR-Transactions-Inc/app/actions/runs/4236446102/jobs/7361274108#step:3:12)-github-actions-deprecating-save-state-and-set-output-commands/

Then during the build stage I get
/Users/runner/work/app/app/platforms/ios/***.xcodeproj: error: There are no accounts registered with Xcode. Add your developer account to Xcode (in target '***' from project '***')
xcodebuild: Command failed with exit code 65
/Users/runner/work/app/app/platforms/ios/***.xcodeproj: error: No profiles for 'com.***.***' were found: Xcode couldn't find any iOS App Development provisioning profiles matching 'com.***.***'. (in target '***' from project '***')

@guotao @sudarshann
Please update to v1.0.8.
It should be fixed to output without set-output.

Thanks @poad. 1.0.8 fixed set-output. But still I get the error with no accounts registered with xcode and no profiles. Any idea how that can be fixed?

I use ionic framework and the below is the build command and yes it does have allowProvisioningUpdates
/Applications/Xcode_13.2.1.app/Contents/Developer/usr/bin/xcodebuild -workspace ***.xcworkspace -scheme *** -configuration Release -destination generic/platform=iOS -archivePath ***.xcarchive -allowProvisioningUpdates archive CONFIGURATION_BUILD_DIR=/Users/runner/work/app/app/platforms/ios/build/device SHARED_PRECOMPS_DIR=/Users/runner/work/app/app/platforms/ios/build/sharedpch "EMBEDDED_CONTENT_CONTAINS_SWIFT = YES" ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES=NO "LD_RUNPATH_SEARCH_PATHS = "@executable_path/Frameworks""

@poad  If had found the issue. It seems your action is doing its job perfectly of downloading the provision profiles. I had not downlowed the certificates. I ended up following this doc
https://docs.github.com/en/actions/deployment/deploying-xcode-applications/installing-an-apple-certificate-on-macos-runners-for-xcode-development
I had provided the provisioning profile manually and certifcate and it worked. Any way thanks your action worked good. in future  I will try to integrate your action for provision profile and the github reference only for certifcates when I get more time on this.
Any way good job with our action.

@guotao Problem solved?
If the problem has been resolved, I will try to close it, so please let me know if it has been resolved.


Handle URLs in article when creating AI replies

See analysis here:
https://g0v.hackmd.io/WwinEyGBRYmi_iKu8cSprQ#202342-Release-issues
Modification to ChatGPT prompts

make prompt date less specific So that the chatbot don't give replys to specific to a certain date, such as on the april fool's day.
add genAIReply script that calls createAIReply
[CreateAIReply] implement and test URL resolution

Coverage: 88.376% (+0.2%) from 88.154% when pulling 6e971fa6aaa323e4c8e923596c39b44291df0177 on ai-reply-prompts into 7e8d7af676468760027f473af21d7880e20d0f22 on master.


Disable swarm unique id on slave

CI broke on older ruby, net-http-persistent 3.0 requires ruby 2.1, adding this change as well.

I've restarted the failed travis job.  It looks like the build slave went away mid-output.


Make brains1 build again

Some first steps here:
https://github.com/datomusic/duo-imxrt/commit/f3d33974d557f262bcb9f3c01f6ba869b875067e


Mattermost as a notification channel

I'm following in the footsteps of issue :smiley: . Are there plans to integrate with mattermost?

Best method of integration, i suppose, Web hook.
Web hook will satisfy everyone

I am interested in working on it. Do we have any plans to integrate it ?

webhook also needed: telegram, rocketchat, grafana oncall are not covered for example

webhook integration pr: https://github.com/coroot/coroot/pull/167

I can actually confirm that WebHook integration works with Rocketchat, so I assume with Mattermost too , so I`m guessing this could be closed


API showqueries=1 now shows parameters

It makes debugging a bit nicer. Rather than seeing WHERE "Column" = ? you can see the parameters as a separate following list.

Makes sense, are the parameters quoted?
params: "foo","bar, baz","bam" or params: foo,bar,baz,bam?

nope. ;D

Ok now it does.

Would it not be possible just to replace the ? in place so it looks more like a real query... which would be much more helpful for debugging...

@dhensby I considered that but I prefer having them separate - it’s more verbose, but it’s more obvious that the query is parameterised. Doctrine’s DBAL does the same (in fact, you have to manually output the SQL and the parameters separately)

I understand that it's clearer that the query is parametrised, but is that really important?? We can just say (parametrised) at the beginning or end of the log.
I'm not sure than having to manually associate Nth param with Nth ? is easy or helpful and also the reasoning "but others do it that way" doesn't convince me.
One of the things I used the query logging for is to be able to copy and past into a MySQL terminal to see outputs, errors, etc. This is made significantly more difficult by parametrising like this.

As another thought, you could just have ?showqueries echo  out "Using MySQLPDODatabase with parametrised queries" or something

A string replacement to produce what looks like a raw SQL query implies that “this is the SQL string that’s being run” when it technically isn’t, however I’m not sure in which scenario a parameterised query wouldn’t actually match up to its find+replace equivalent? I know that they do escaping etc, but do DBMSs ever transform the values of parameters before execution in a way that would render this sort of debugging useless?
You’re probably right that this is much less useful to those using ?showqueries to copy + paste SQL for debugging though. If the find+replace version of the query is essentially equivalent to the parameterised one (at least for the purposes of debugging in development) then I don’t see a problem with adding that functionality.

The DB layer should know to expect an int or a string or a date, so it'll quote the value accordingly, which we wouldn't be doing for this, I guess...


Verification and Validation

Next steps.
Fixes two bugs really. The summit example @manstis did picked these both up.
This PR adds support for:

BRL condition/column
Action/column cell having a null value
Action/column cell having no value
Action/column cell having more than one values

@Rikkola Nice small PR for me to start my day with ;-)

@manstis Hehe, have to keep pushing these, but I think this is the last one with this big impact.
Again, only one who needs this ATM is me and I have it locally, so no hurry.

@Rikkola 3 failing tests (not sure why they should fail.. unless related to something in your PR?) Could you please confirm everything passes locally for you (with the latest fetch from master)?

Jenkins please retest this.

Could be that my merges broke something when I cherry picked from one topic branch to another. Checking.

Ok. I see them. I broke something not related to V&V.

Same 3 also fail in master.
(Still doesn't mean I didn't break them)

Fix on the way.

Works on Idea, fails in CLI.
Could be this.
https://groups.google.com/forum/embed/#!topic/mockito/LCWH3ykLJtA

Or not. Something similar.

@Rikkola a few trivial-ignorable comments (mainly FYI)... when green I'll +1 and merge.

@Rikkola let me check the failing tests from CLI here too (w/o your PR.. I can fix as appropriate)

@Rikkola probably this "Actually the issue is that the anonymous class is not public, it is compiled by the Sun compiler as a package visible class" as the test sub-classes a class with a package-protected method and then spies on the sub-class.

Ah, I checked the class, but not the method. Well spotted.

Fixed formatting and the iterator. I still need to rebase once #208 is in.

Jenkins please retest this.

@Rikkola #208 is merged.

+1 to merge.