[$250] Room-User is allowed to invite via mentions invalid number.

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.66-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4513241
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by:  Applause-Internal team
Action Performed:

Go to https://staging.new.expensify.com/home
Tap on a room report
Enter @+91 and send the message
Tap invite
Note invited message
Tap header--members---invite
Enter +91
Note no options to select and invite the contact is shown

Expected Result:
User must not be allowed to invite via mentions invalid number.
Actual Result:
User is allowed to invite via mentions invalid number.
Tapping header -- members -- invite, user unable to invite +91 but via mentions can invite.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[x] Android: mWeb Chrome
[ ] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
https://github.com/Expensify/App/assets/115492554/85b3296d-0c3e-41d8-8651-15ed91f8e1d3

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01cdf72ac69795bc85
Upwork Job ID:<PHONE_NUMBER>411239424
Last Price Increase: 2024-05-09
Automatic offers:

hungvu193 | Reviewer | 0
nkdengineer | Contributor | 0

Issue OwnerCurrent Issue Owner: @

We think this issue might be related to the #vip-vsb.

@lschurr I want to discuss about the expected behavior here. In this case, when we sent a invalid phone number, the whisper message shouldn't be displayed or it's displayed but we can't click the Invite button?

I'm not 100% sure - Would you mind starting a Slack thread to discuss @hungvu193?

I raised on slack:
https://expensify.slack.com/archives/C01GTK53T8Q/p1714617971723469

Coming from Slack, I think we should handle this issue from BE, @lschurr can you please add the Internal label?

Asked in the Slack thread about best ways to move forward here. I think we need an Eng volunteer to assign this to.

I'll pick this up, I think it'll be a quick fix.

Notes for myself:
Looks like we have a couple ways in Web for validating a phone number, though we should probably only have 1. We also have ways of validating it from the client; one way to validate it is via a command called IsValidPhoneNumber (which doesn't appear to be used ever in App) but we also have ways that leverage other libraries as shown here. Auth doesn't seem to have methods for validating phone numbers, which seems odd to me.
Another funny thing is that we also seem to be making accounts for these invalid phone numbers. Like when you comment @+91 it actually creates an account with the username<EMAIL_ADDRESS>even though we would reject making that account if a user tried to sign up with it. Not sure if we care about that or not. We probably don't care.
It seems like this will be easiest to fix in Web. But that may be problematic because I think these actionable mention whispers are made in Auth. We may need to port over our TwilioUtils.php file to Auth, or at least partly port it. That would take a little bit of time. But I think that would be the "best" solution since a Web solution will probably end up being quite hacky. Those are my thoughts after doing an initial inspection.
Will return to this tomorrow.

Ugh, this is more complicated than expected. Twilio uses the E164 format as their standard for what is and isn't a valid phone number, but this standard actually doesn't have a minimum number of digits necessary for it to be valid. See https://www.twilio.com/docs/api/errors/21211. This means that I don't think we can actually say that these phone numbers are invalid.
So, technically, +91 is a valid phone number. And if you can believe it, according to the leading SMS api in the world, even + is a valid phone number. Kinda ridiculous.
I tested this by directing hitting Twilio's api using our own TwilioUtils->isValidPhoneNumber method in Web
.
But we don't allow numbers like that to make accounts! If you type +94 into the login page it'll tell you that's not a valid number!

The reason is because we use the awesome-phonenumber npm package to partly validate our phone numbers. And for some reason it seems to understand that +94 is not a valid phone number, probably due to a very long if/else chain checking country code against phone number length. For example, Sweden only has to have 7 digits in their phone numbers (source).
Funnily enough this package is actually based off a C++ package from Google called libphonenumber. So we could download that into our C++ layer and start using that, but this is getting a little ridiculous.

So here's my take: lets fix this is in the frontend. I would have preferred to fix this in the backend but the only place in our stack that has logic that considers +94 to be an invalid phone number is in the frontend. There is no existing logic in the backend that considers +94 to be invalid, and knowing whether or not a phone number is invalid is actually surprisingly tricky due every country doing it slightly differently.

For what its worth for debugging this, I noticed in our post request to the server when we add a comment we format the comment with an <mention-user> tag. Find the logic that does that and make sure we are validating the number in the same way we do on the login screen and I think this will be a straightforward fix on the frontend:

Using the awesome-phonenumber lib to validate whether it's a valid phone number before deciding to treat it as a mention on the client sounds good to me.

Proposal
Please re-state the problem that we are trying to solve in this issue.
User is allowed to invite via mentions invalid number.
Tapping header -- members -- invite, user unable to invite +91 but via mentions can invite.
What is the root cause of that problem?
We don't check the phone number of mention is valid or not before deciding to treat it as mention
https://github.com/Expensify/expensify-common/blob/a018512b1e0fce4d4b5a61c00ca826b8887007ad/lib/ExpensiMark.js#L200
What changes do you think we should make in order to solve the problem?
We should use awesome-phonenumber lib to check the phone number of mention is valid or not

Create a isValidPhoneNumber function in Str

import {parsePhoneNumber} from 'awesome-phonenumber';
isValidPhoneNumber(phone) {
    return parsePhoneNumber(phone).possible;
},

Get the phone number from mention and check if it's not valid, we will not return this as mention

if (!Str.isValidMention(match) || (phoneRegex.test(g2) && !Str.isValidPhoneNumber(mention))) {
    return match;
}

https://github.com/Expensify/expensify-common/blob/a018512b1e0fce4d4b5a61c00ca826b8887007ad/lib/ExpensiMark.js#L200
Or we can bring this check into isValidMention function
What alternative solutions did you explore? (Optional)
NA
Result
https://github.com/Expensify/App/assets/161821005/87110db5-acda-4e40-a4da-19d3f4f21d13

what is considered a valid phone number in the app? For example, are the slashes allowed?

what is considered a valid phone number in the app? For example, are the dashes allowed?

@roitman-g When you go to https://new.expensify.com and try to login using a phone number, any phone number that you can type into the login field without triggering a form error is a valid phone number. The logic for what is and isn't a valid number is dictated by https://www.npmjs.com/package/awesome-phonenumber.

I'll review this one soon

@nkdengineer I don't think your solution works, checkout this video:
https://github.com/Expensify/App/assets/16502320/2db27022-cca7-4e62-a31a-4208c94ec38e

@hungvu193 Missed to remove the SMS domain before checking valid phone number with awesome-phonenumber. I updated proposal https://github.com/Expensify/App/issues/41078#issuecomment-2102153310.
About the bug phone number doesn't appear as mention in composer, it also happens in main so I think it should be fixed in a separate issue.

const mention = g2.slice(1);
if (!Str.isValidMention(match) || (phoneRegex.test(g2) && !Str.isValidPhoneNumber(mention))) {
return match;
}

@hungvu193 Sorry I missed a line when add pseudo code in my proposal, we should slice the @ character first. I updated https://github.com/Expensify/App/issues/41078#issuecomment-2102153310
https://github.com/Expensify/App/assets/161821005/2e83214c-6800-4a1e-ae18-e1be7d3e2a74
https://github.com/Expensify/App/assets/161821005/ea1447ed-df07-4167-be45-d959f43ad6e9

This won't work when you tried to type a number with expensify.sms format, ie<EMAIL_ADDRESS>https://github.com/Expensify/App/assets/16502320/891c9504-4fb8-4b10-995b-7aa4d4e140e2

@hungvu193 Thanks for your feedback, this case doesn't work because phoneRegex.test(g2) has maximum 14 character after @ and will return false when we type<EMAIL_ADDRESS>Updated proposal https://github.com/Expensify/App/issues/41078#issuecomment-2102153310 to also fix this case
https://github.com/Expensify/App/assets/161821005/debd7b25-b218-4d38-ac76-356cba5522e2

Did you miss some steps or codes? The latest proposal updated broke the mention.
https://github.com/Expensify/App/assets/16502320/d3191c2b-169c-4a46-8738-b5daea25291d

@hungvu193 Sorry it's wrong typo I updated again https://github.com/Expensify/App/issues/41078#issuecomment-2102153310.

I see. The only problem is the inconsistency of mention with sms domain between the composer and after it's being sent:
https://github.com/Expensify/App/assets/16502320/d74fcf71-c577-4529-8e01-4e9efa70bb3a

@hungvu193 I believe this can be fixed when we bump the expensify-comon version in react-native-live-markdown

nkdengieer 's proposal here looks good to me.
cc @blimpich

@hungvu193 we have open PR here

waiting for merge freeze to be over

Same as last update I believe.

PR is still open

We are close to fixing, held up because merge freeze / slush. I'd like to wait till we are back to a normal deploy schedule to merge this.

Not overdue, waiting for merge freeze to be over.

Expensify-common PR is merged, but shouldn't be considered fixed until we have updated App to have the corresponding PR to update its commons' version. @nkdengineer please feel free to raise that 2nd PR

Update: reproducing the exact issue locally is a bit of a pain since there are two other bugs occurring in this same general flow:

when a submitter submits to an approver who is an admin, then the email actually shows "pay" instead of "approve" and doesn't group the IOU preview amounts
when submitting multiple normal IOUs between normal users if two IOUs are stacked on top of each other in the product then in the email the subject will have the report total but the IOU preview will have only the first IOU amount

The actual original bug described in the description of this issue, from what I can tell, is when we create a request to a approver who is not an admin on a policy with a smart scanned receipt sometimes the IOU preview will display $0.00 when it should display a non-zero value. A initially persuasive idea is that this is all due to smart-scanning taking longer than 10 minutes, which is how long it takes for the NotifyOfflineUserAboutActivity job to kick in and send this email. However, it seems that this bug is reproducible even when smartscanning finishes in time (link). So I'm actually not 100% sure why this is happening.
Here's my plan:
I'm gonna report bug #1 that I found up there since I think that is actually a different issue and I'm gonna fix bug #2 as part of this issue. My hope is that fixing bug #2 will fix this issue since they seem to be very closely related.
If that doesn't work I'll start adding logs to get a better idea of what is going on here.

Bump @nkdengineer , do you have any ETA for the bump version?
Also as you mentioned here, we probably need to update react-native-live-markdown as well?

I'm going to create PR today.

I created a PR for react-native-live-markdown here https://github.com/Expensify/react-native-live-markdown/pull/360 but having some problem when run build parser.

Can you please raise a discussion on slack about your issue?

I resolved the problem now. The PR is here https://github.com/Expensify/react-native-live-markdown/pull/360

@hungvu193 I create an additional PR here https://github.com/Expensify/expensify-common/pull/714 to fix the preview mention with invalid phone number.

Thank you. I'll take a look tomorrow

[x] The PR that introduced the bug has been identified. Link to the PR: No offending PR
[x] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
[x] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
[x] Determine if we should create a regression test for this bug.

We don't need regression test for this one imo, this was how our markdown worked, we can treat this issue as a improvement.

@hungvu193 The PR to bump Expensify-common in live-markdown here

@hungvu193 The App PR is here.

Payment summary:

Contributor: @nkdengineer $250 (paid in Upwork)
Reviewer: @hungvu193 $250 (paid in Upwork)

It's not a blocker from our PR here. Ref: https://github.com/Expensify/App/issues/44085#issuecomment-2181139931.

Great! Closing this one out since it's paid.


Switch frontend l10n implementation to i18next

https://issues.redhat.com/browse/AAH-2081

If it helps, here's my checklist of things we need to test with i18next..

simple strings

works with "key" but will it work with whole sentences? (i18next might be separating things by . and : by default)
does it try to do too much/too little escaping? (is <div>{t('4 < 5')}</div> showing a <, or nothing or a doubly-escaped >?)
what happens for unknown strings (fallback to the original string) - technically, I think this means falling back to the 'dev' language, so we should test if it still works in production (=CI)

interpolation

check escaping in interpolated values
unless there's a way to keep using template strings, we might need a linter rule to check for issues like t('Foo {{bar}}',  { baz: "not bar" })

plurals

what's the syntax, how much do we need to change ours?
how does the plural format look when extracted in the json? (for conversion, even the po converter might not understand lingui flavor plural syntax)

deferred translations (lingui defineMessage)

what's the syntax, does the extractor handle it correctly
(or do we need to fake it by having a t with forced translation to the original language? (or a PR to convert them to functions with normal translations))

react

does it make sense to have our own Trans component that calls the hook so we don't have to always pass in t?
is escaping consistent between t and Trans?
does it re-render on language change? (we don't change languages at runtime, but rendering components might happen before the dynamic import finishes - make sure it either waits before rendering, or switches when ready (import just returns a Promise, so you can just add a .then that returns a new promise that resolves with a large  timeout to test this))

template strings

if we can make t`template ${'strings'}`  work, switching would be easier (probably needs the extractor parser to know about them, rest is easy)

extraction - there seem to be multiple parsers, use the same one as ansible-ui, if possible
pseudolocalization - preserve french quotes, the browser language detector plugin may be able to read the same cookies
(* conversion - there may already be a plugin to convert po to json)
(later: think about using namespaces to keep framework strings in a separate json)

diff --git a/package.json b/package.json
index 3cd792c0..2c10692a 100644
--- a/package.json
+++ b/package.json
@@ -76,7 +76,7 @@
         "eslint": "eslint --ext .js,.jsx,.ts,.tsx src/ config/ test/",
         "eslint:fix": "eslint --ext .js,.jsx,.ts,.tsx --fix src/ config/ test/",
         "gettext:compile": "lingui compile",
-        "gettext:extract": "lingui extract",
+        "gettext:extract": "lingui extract; i18next",
         "lint": "npm-run-all lint:*",
         "lint-fix": "npm-run-all lint:*:fix",
         "lint-setup": "npm-run-all lint:*:setup",

Closing, we'll stick with lingui after all :)


InvalidStateError: Failed to read the 'error' property from 'IDBRequest': The request has not finished.

It happens only in safari in some cases when I try to getItem.
I already have saved some data using many keys, but then when setItem is executed I got error
I use try/catch but console.log is never executed
try {
    await localforage.setItem(storageKey, preparedData)
  } catch (e) {
    console.log(e)
  }

Do you have updates on this? I have the same error.

Unfortunately not.

@lincolnthree Nop, I use localforage for Apollo persistent caching in the browser. This error still occurs randomly after initialization and also while using it.

I determined it has nothing to do with Ionic Storage :( This seems like a Safari bug, but I have no idea to be honest.

I suppose it's also possible that localForage could be improperly waiting for the IDB request, but... that seems less likely.

Bumping this thread: @lincolnthree JW if you had any success finding this issue. It happens on my development environment only in Safari when trying to store Files or Blob types in localForage and only after I force quit the application and attempt to run a setItem or removeItem on the keys that contain the Files / Blobs

@danbunkr Unfortunately not. Sorry :(


Will 3.0 include support for Reading?

Maybe it has not been developed yet but I do not see how to read a file with 3.0.

Hey, import/reading has been planned for 3.1 release

ok. that will make it a bit difficult for me to test 3.0 in production but I'll find a way.

Currently can't really promise any timelines on 3.1 / importing. We are first developing what ever we need for our own projects. So things can go fast suddenly, but difficult to predict :)

I understand. Maybe if I get desperate I'll start to write that functionality.

You could for now simply create an own "SomeImport" class and add a ->import() method and handle it directly with PhpSpreadsheet. And then when we release it, you would be able to rewrite your Import class to ours.

Yea I was thinking of something like that. I've honestly only given it an hour of thought so I need to get educated on how PhpSpreadsheet works first. In one of my projects I have to import a lot of csv data and using the CustomValueBinder functionality is critical to me. It will take some time but I'll come up with something.


Nil Using getHistoryByQuery

I absolutely love your work!
In the programmer mode, I am trying to track high/low patterns.  I saw your recommendation to use getHistoryByQuery method to obtain that.  However, every time I try I get a "[string "chunk"]:27: attempt to index local 'myData' (a nil value)" error.
To get the last game's roll value, I was using this query that works in the Firefox SQLite Manager:
SELECT * FROM bet m WHERE m.betid IN (SELECT max(s.betid) FROM bet s)
Since that was not returning a result, I scaled it back to:
SELECT * FROM bet
The query above should return similar results as the getHistory() method, but it returns the nil value error.  The odd thing is that when I use getHistory(), I get the data, but it is not in order and I am concerned about the amount of IO that gets consumed when pulling all rows.
This is the function that I am using
function getLastLucky ()
  local pSQL = "SELECT * FROM bet m WHERE m.betid IN (SELECT max(s.betid) FROM bet s);"
  local myData = getHistoryByQuery(pSQL)
  print("My Data:  "..myData[1].Roll)
  return myData[1].Roll
end

This seems that it should work.  Could you take a look and see if this makes sense to you?
I'm thinking this may be a bug, but I'm not sure.  I don't know lua good enough to be able to know for sure.  I've been trying for about three hours now to get this to work.  :-(
Thanks!

There is a bug in some of the sql helper functions, I will get them fixed.
Though I do need to mention that you don't need to query the db to get the bet info for your latest bet. You can use the lastBet object. It's the same object type that gets returned in the gethistory functions.
You should only use the getHistory functions if you need to get a list of bets, or bets from longer ago.

Seuntjie900,
Thank you very much!
The rational behind the SQL query is related to finding the last Roll/Lucky value that was posted to the DB.  It doesn't seem to be one of the live variables, so it needs to be pulled from the DB.
I would like to run some statistics on the values of the Roll values.  Maybe something there for some sites, but most likely not.
Thanks again and I'm looking forward to the next version.

Seuntjie900,
That was exactly what I was looking for!!  I didn't realize what members the "Bet" object would expose in lua.  I guess I don't necessarily need the SQL at this point, but maybe down the road.  I appreciate you looking into addressing that.
Again, thank you so much for this project.  I really appreciate your work and dedication.


unix relative path issue

dvc repro failing due to some relative path issue in unix system. Same work fine in windows. Below is the error. File is placed at the correct location and related python works fine if ran independently.

Yes Agreed. Its not required.


Add bootstrap modals for inlines actions

Add bootstrap modals for inlines actions (add, edit, delete) instead of add the forms directly in the same page (cleaner).

Fixed: e4e3f0b0b924544f2cb90305fc3c17d5d8dccb0b


Spam filtering

Currently emails are treated as spam. That should be fixed.

That's duplicate of #799


ONTOP With Large Data

Hi,
I'm using ONTOP API in a java project to generate triples from postgres database and have the following code :
try (   QuestOWL reasoner  = factory.createReasoner(ontology, config) ;
        QuestOWLConnection conn  = reasoner.getConnection() ;
        QuestOWLStatement st  = conn.createStatement() ;
        QuestOWLResultSet rs  = st.executeTuple(query) ;   )
{
      int columnSize = rs.getColumnCount() ;

      while ( rs.nextRow() )  {

        for (int idx = 1; idx <= columnSize; idx++)  {

               OWLObject binding = rs.getOWLObject(idx) ;
                ...
                ...
        }
      }
}

I wonder how ONTOP behave with a very large volume of data..
Do I expect problems like OutOfMemoryError ?
A way to stream data from database ?
Regards.
R

Out-of-memory error can happen with very large volume of data. We still do not have a way to stream data from database, issue #122 has already been opened regarding this subject.

Any idea, timewise, as to when streaming will be available for Oracle database drivers?

I'm sorry but  I cannot provide a date. We want to support it, but at the moment it is not between our priorities.

I think that if you modify the code as:
QuestOWL reasoner  = factory.createReasoner(ontology, config) ;
QuestOWLConnection conn  = reasoner.getConnection() ;
conn.setAutoCommit(false);
QuestOWLStatement st  = conn.createStatement() ;
st.setFetchSize(1000);
QuestOWLResultSet rs  = st.executeTuple(query) ;
"streaming" answers will be enabled

Does questOWLStatement.setFetchSize works ?

Hi @rac021 , it is not working yet. We did some investigation and found that different JDBC drivers behavior differently (I don't remember the details now). So we probably could not guarantee the right behavior following the proposal  of @dbilid .

Thank you @ghxiao
For the moment I hack my own "streamer" by playing with LIMIT - OFFSET in the OBDA files.
Waiting for the version of ONTOP that supports it.

As mentioned in #122, streaming is now activated by default in the version4 branch. It is still very fresh and needs to be further tested. It is based on the novel jdbc.fetchSize property in replacement of the setFetchSize(...) method (which has been removed).
We are now working on also making the novel SPARQL endpoint "stream-compliant".
I am now closing this old issue but feel free to re-open it.


[fb-package] Fix failing contingency CI due to readr version change

Description
Prevent survey CI from updating to new major release of readr. A couple bugs (apparently spurious compilation errors on install  and failure to write empty files) cause test failures. I've filed issues and hopefully those are fixed in the next minor version; will keep an eye on future readr releases.
Changelog

Remove path argname. Argument will by default use the new file arg.
Exclude readr from being updated in Actions workflow.

Just so I understand, does the cache in CI not have the new major version yet, since I don't see a pinned version anywhere? If so, how did that happen if it's currently set to always update? Certainly there was some CI run in the last day that would've triggered it.

does the cache in CI not have the new major version yet

Nope, the cache has the old version of readr (1.4.0). A new version of the cache is only saved once a month (more on this below). When the cache is loaded, any packages in it that are out of date are updated to their newest versions. However, those updates only apply to the current run. Once a cache with a given name (key) is created, it can't be overwritten, so package updates aren't saved anywhere.
For clarity, I'll explicitly install the 1.4.0 version.
On monthly caching: thinking about it more, it makes more sense to move this to daily versioning. I was initially trying to minimize the number of times we would have to run the full install process (since it takes a long time), but with restore keys cache updates are incremental. I'll make a separate PR for that.


[BUG] Refreshing the chat page displays encrypted messages

Description
If you refresh the chat screen a couple of times, it'll change the message(s) to this sort of encrypted version of the message. Refreshing again will change it back to its normal text but then it can be replicated again after a couple more refreshes.
Screenshots

Additional information
You can replicate this issue by sending any message in the chat and then refresh the page a couple of times.
🥦 Browser
Brave
👀 Have you checked if this issue has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Contributing Guidelines?

[X] I have read and understood the rules in the Contributing Guidelines

Are you willing to work on this issue ?
Yes I am willing to submit a PR!

thanks for wanting to contribute. Make sure to read the issue description carefully and ask if you have questions on the discord server. Follow the rules here, or your PR won't be accepted and will be closed. Good luck!

I suggest, we decrypt the message before displaying it and if we don't have the keys atm, we use a loading screen to let the users know it's loading

My apologies, I got tied up with work and wasn't able to work on this the last couple of days. I am just getting back on it to try and resolve this issue. Is there a way I can have a couple of extra days to get this completed? If not, no worries. I will try to complete it within the next day or so.

My apologies, I got tied up with work and wasn't able to work on this the last couple of days. I am just getting back on it to try and resolve this issue. Is there a way I can have a couple of extra days to get this completed? If not, no worries. I will try to complete it within the next day or so.

no problem, you get 4 days extra.

Awesome, thank you 😎

@Dun-sin I don't think I'll be able to find the fix for this issue in time so please go ahead and unassign me. I will continue to try and find a solution but I don't want to hold up another developer that may want to put in a pull request for this issue. Sorry for the inconvenience. I look forward to contributing more but I've run out of time on this one.

@Dun-sin I don't think I'll be able to find the fix for this issue in time so please go ahead and unassign me. I will continue to try and find a solution but I don't want to hold up another developer that may want to put in a pull request for this issue. Sorry for the inconvenience. I look forward to contributing more but I've run out of time on this one.

thanks for trying, do come back when you think you want to try again

@Dun-sin
Can i try? basically I want to contribute to open source projects.but i don't know where to start from I know JavaScript and reactJs.
can you please guide me how can I start contributing to open source??

@Dun-sin Can i try? basically I want to contribute to open source projects.but i don't know where to start from I know JavaScript and reactJs. can you please guide me how can I start contributing to open source??

I would not recommend this issue to a beginner to open source or coding in general, but first contribute to this → https://github.com/firstcontributions/first-contributions
and come back and try to contribute to this

I can work on this issue. If you have no problem, please assign it to me.


Error redirection forbidden

Whenever the feed's link redirects us a RuntimeError is generated.
>> PodcastReader.new("http://canaltech.com.br/rss/podcast/")
RuntimeError: redirection forbidden: http://canaltech.com.br/rss/podcast/ -> https://canaltech.com.br/rss/podcast/
>>

Thanks for this Marcelo, I'll have a look tomorrow - couple of things with a quick look:

The current test doesn't seem to fail if I remove the added redirection code?
I was wondering if we could do without the extra dependency and just use something like the redirect behaviour shown here instead: https://twin.github.io/improving-open-uri/

Thanks for this Marcelo, I'll have a look tomorrow - couple of things with a quick look:

The current test doesn't seem to fail if I remove the added redirection code?
I was wondering if we could do without the extra dependency and just use something like the redirect behaviour shown here instead: https://twin.github.io/improving-open-uri/

@kule

I will have to investigate if ShamRack is redirecting for real or if the problem was with a specific kind of redirection.

I looked at it, but it seemed quite an unnecessary workaround.

OpenURI itself does not seem an appropriate dependency, it would be interesting to have an injected dependency to handle the XML download, that would be my next step. I was handling the redirection with the dependency temporarily.

@kule

I will have to investigate if ShamRack is redirecting for real or if the problem was with a specific kind of redirection.

I looked at it, but it seemed quite an unnecessary workaround.

OpenURI itself does not seem an appropriate dependency, it would be interesting to have an injected dependency to handle the XML download, that would be my next step. I was handling the redirection with the dependency temporarily.


Upgrade RN Version (0.70.2)

📄  Description:
Upgrade template version from 0.67.2 to 0.70.2
https://react-native-community.github.io/upgrade-helper/?from=0.67.2&to=0.70.2

📌  Notes:
New upgrade contains new RN architecture.
The idea is that when the time comes we will be able to switch to the right architecture right away.

⚠   Disclaimer :
It would be nice if someone can test it with the Mac that has the M1 chip.

✔  Performed Tasks:

Upgrade RN version

⏯  Demo:
iOS
https://user-images.githubusercontent.com/89869262/194895468-42a67d3d-0bb5-4aaf-8503-bf04aa5b2d95.mp4
Android
https://user-images.githubusercontent.com/89869262/194895423-1abc7663-901c-456a-92b6-2fedc40f3b7d.mov

If you run watchman watch-del-all && rm -rf node_modules/ && npm cache verify && npm install --legacy-peer-deps and after that run npm run android the App dont launch
* What went wrong:
A problem occurred evaluating settings 'rntemplate'.
> Could not read script<EMAIL_ADDRESS>as it does not exist.


Publish latest release on currently supported Linux distributions

Some of our releases for Linux haven't been updated in years. We need to update these releases, operationalize the process where possible, and update release docs for how to do it.
Tagging thread in #139.

Is this why following the installation guide for Ubuntu doesn't work (there is no package mssql-cli to install)?

Could be. Haven't had a chance to look yet, but plan to this month.
Moving forward we'll make sure to update all supported packages at a regular cadence.


Device tunnel example missing

User and device tunnels are mentioned but only an example for creating a user tunnel. Can this be completed to include both?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 69495659-b738-98e6-48a5-e8884fc5604d
Version Independent ID: 08bc7902-2c0d-59ae-021a-510ad170bc44
Content: Configure an Always-On VPN user tunnel - Azure VPN Gateway
Content Source: articles/vpn-gateway/vpn-gateway-howto-always-on-user-tunnel.md
Service: vpn-gateway
GitHub Login: @cherylmc
Microsoft Alias: cherylmc

@vitorpereira, Thanks for the feedback! We are taking a look into this and will get back to you soon.

@cherylmc Can you please look into this? Thank you!

All set. Just added the link to the device doc from the user doc. :-) #please-close.


Plugin Install not working in Windows Version 1.2.1

Hey,
installing plugins isn't working in Version 1.2.1 on Windows 10.
It works fine in Version  1.1.0 but it gets automatically updated to 1.2.1.
It's a fresh install, I only added 'hyperterm-atom-dark' to the plugins.
Any ideas?
Cheers!
Hyper 1.2.1
Electron 1.4.7
win32 x64 10.0.14393

Most likely a dupe: #1513
Try specifying a shell in your config, if it's the same issue then that should work as a temporary fix ✌

I tried shell: 'C:\\Windows\\System32\\cmd.exe', as well as shell: 'C:\\Windows\\System32\\bash.exe'. Both work, but plugins don't get installed.

Try building hyper from master and see if its fixed

Oh well, I was too fast, it actually works with the cmd.exe. Sorry.

Maybe close this since it's a dupe?


Validating publisher/signer of signed image in Docker/Notary (Docker Content Trust)

Need a mechanism via 'docker trust' or notary APIs/CLIs to validate that a particular signer has signed a particular image.
e.g.
$ docker trust inspect **--signer gwaines.pub** admin-2.cumulus.wrs.com:30093/wrcp-gwaines/hellokitty:v1.0

// which would validate that the hellokitty:v1.0 image is signed by the gwaines.pub public key.
NOTE that 'docker trust inspect' currently shows the signer's name and key ID (see below) ... but UNCLEAR how that ID can be compared against gwaines.pub .
$ docker trust inspect admin-2.cumulus.wrs.com:30093/wrcp-gwaines/hellokitty:v1.0
[
    {
        "Name": "admin-2.cumulus.wrs.com:30093/wrcp-gwaines/hellokitty:v1.0",
        "SignedTags": [
            {
                "SignedTag": "v1.0",
                "Digest": "204eb3b0cf6108a25c428bc5c9c82d76f9191dbe65de82426a4255214c1819ae",
                "Signers": [
                    "gwaines"
                ]
            }
        ],
        "Signers": [
            {
                "Name": "gwaines",
                "Keys": [
                    {
                        "ID": "135d386a1d25a9062e7faaeb9e0aa10f5880ab70b4390c17a186872e97e01789"
                    }
                ]
            }
        ],
...

I don't think this is a job for the registry - this seems like a feature request for the docker command line.


Spec for Hash#any?

Looks great, thank you for your contribution! :+1:
Hash#any? only exists since 2.2. Before, Enumerable#any? is used which has the same behavior, so in this case we don't need any particular version guard.

Thanks! How would I know if I need a version guard, and how should I put one in if I do?

the CI would fail most likely :)
Like this.


Confirmed memory leak when runInNewContext is true

Version
2.3.4
Reproduction link
https://github.com/geekdada/vue-hackernews-2.0
Steps to reproduce
$ yarn
$ MICRO_CACHE=false node --expose-gc --inspect server
$ ab -n 50 -c 20 http://<IP_ADDRESS>:8080/

Stimulate a garbage collection before dump memory heap.
What is expected?
All Vue$3 instances not being in use are garbage collected.
What is actually happening?
As opposite.

My heap dump file can be found here: http://d.pr/f/H0ypK

Hi, thanks for your report!
Can you explain your changes, why you made them and how they relate to the memory leak? That would be helpful.

You can see the commit history.

Global mixin as a plugin; 2. Global component as a plugin;
The tricky part is I was unable to find how they related to the leak, plus there will be no leak if I turn off any of them.

李一航 Roy Li
On Tue, Jun 20, 2017 at 4:03 AM, Thorsten Lünborg<EMAIL_ADDRESS>wrote:
Hi, thanks for your report!
Can you explain your changes, why you made them and how they relate to the memory leak? That would be helpful.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub [https://github.com/vuejs/vue/issues/5922#issuecomment-309557127] , or mute the thread [https://github.com/notifications/unsubscribe-auth/ADH4YnbHr2VJ_9FoMUMGtl80gDwMWObTks5sFtP5gaJpZM4N-Q1I] .

Global mixins will lead to memory leaks when you use runInNewContext: true AND externalizing Vue.

With runInNewContext: true the mixin registration code will be called again on every render
When Vue is externalized, the same mixin gets registered over and over again.

This is why you should be careful when using runInNewContext: true and also why we recommend using 'once' or false instead.

@yyx990803 I have made a plugin for registering global mixin, see here: https://github.com/geekdada/vue-hackernews-2.0/blob/master/src/util/mixin.js
Does this auto-prevent duplicate registration when using runInNewContext: true?


Design System >Elements > Payment Card > Default > Label and button alignment issue.

Describe the bug
Label and button alignment issue.
Steps to reproduce bug

Go to 'https://dev-react.raaghu.ai/ & https://stage-react.raaghu.ai/'
Navigate to 'Components>Premium Support'

Actual result-
Label and button alignment issue.
Screenshots

Expected result-
Label and button alignment should be proper.
Desktop (please complete the following information):
-OS: [Windows 10 Enterprise]
-Browser [ edge]
-Version [ 125.0.2535.92]

Only PAY NOW button issue for my side label issue already fixed verify with @rameshwarkamandar

Pay Now button alignment issue

Pay Now button alignment issue is resolved.

Label alignment issue still exist.

Pay Now button alignment issue still exists on stage.

Fixed on stage


Failed to load content! Delimiter

Everything worked fine , with some trial and error got the libraries scanned and saw the duplicates, removed all of them and now getting this error. Cannot seem to figure out what this is.
With Debugging I can see the screenshot below, but cannot finetune where the error might be

+1 same error

narrowed it down to the library that is giving an issue and I think it's a naming issue of a library with a ' in the name perhaps.. seems something like that..
I've deleted the library from plex and re indexed it , issue still remains but the sync was working in the beginning for a bit..

I had the same issue and was able to fix it. There is a file that gets created called db.json that is missing a "}" character at the end of it. After modifying the file to fix the missing character this error was fixed.

I had the same issue and was able to fix it. There is a file that gets created called db.json that is missing a "}" character at the end of it. After modifying the file to fix the missing character this error was fixed.

I had the same issue and was able to fix it. There is a file that gets created called db.json that is missing a "}" character at the end of it. After modifying the file to fix the missing character this error was fixed.

This fix also worked for me, added a } at the end of the file and everything functioned again.  Wound up with error after refresshing page while delete was being performed.  Not sure if that triggered the issue.


Refactor hl attrs to not override default colors

If the foreground or background colour keys are not specified, the plugin forcefully sets the colours to be the theme's default foreground/background colours. This means that if the text colour was changed by syntax hl, then it would become white.
This is useful for underlining something without changing the colour - notably for use with quick-scope or vim-current-word:
  highlight QuickScopePrimary guifg=NONE guisp='#afff5f' gui=underline ctermfg=NONE cterm=underline
  highlight QuickScopeSecondary guifg=NONE guisp='#5fffff' gui=underline ctermfg=NONE cterm=underline

Hopefully this does not cause any problems! I'm lucky to have figured this out :slightly_smiling_face:
Do you think the above snippet should be added to the readme?
Finally, do you think the default underline "vimSpecialColor" should be changed to something more neutral, like the foreground colour?
Another quick thought, further down for the "reverse" attr, should the colours be read then inverted from the colour keys instead of just default foreground/background colour?

I just followed API instructions here i believe:
["hl_attr_define", id, rgb_attr, cterm_attr, info]
	Add a highlight with `id`  to the highlight table, with the
	attributes specified by the `rgb_attr` and `cterm_attr` dicts, with the
	following (all optional) keys.

	`foreground`:	foreground color.
	`background`:	background color.
	`special`:	color to use for underline and undercurl, when present.
	`reverse`:	reverse video. Foreground and background colors are
			switched.
	`italic`:	italic text.
	`bold`:		bold text.
	`strikethrough`:  struckthrough text.
	`underline`:	underlined text. The line has `special` color.
	`undercurl`:	undercurled text. The curl has `special` color.
	`blend`:	Blend level (0-100). Could be used by UIs to support
			blending floating windows to the background or to
			signal a transparent cursor.

	For absent color keys the default color should be used. Don't store
	the default value in the table, rather a sentinel value, so that
	a changed default color will take effect.
	All boolean keys default to false, and will only be sent when they
	are true.

	Highlights are always transmitted both for both the RGB format and as
	terminal 256-color codes, as the `rgb_attr` and `cterm_attr` parameters
	respectively. The |ui-rgb| option has no effect effect anymore.
	Most external UIs will only need to store and use the `rgb_attr`
	attributes.

	`id` 0 will always be used for the default highlight with colors defined
	by `default_colors_set` and no styles applied.

	Note: Nvim may reuse `id` values if its internal highlight table is full.
	In that case Nvim will always issue redraws of screen cells that are
	affected by redefined ids, so UIs do not need to keep track of this
	themselves.

	`info` is an empty array by default, and will be used by the
	|ui-hlstate| extension explained below.

But since vscode is not neovim, i don't think it would break something. So... probably safe to merge?

Interesting! From how I interpret the "sentinel" section however, it seems to say that the default (as in the current colour of the text) should not be overridden.
I'm pretty sure vim's behaviour aligns with this PR, as NONE does not mean select foreground/background, it means don't change.

Before this is merged, I have a change to vimSpecialColor that will make it match vim's behaviour.

I tested with neovim, and if some text has an underline without a special color, the color of the text is used, not the foreground color, nor some random fixed color.
If you are alright with this change I am ready to merge.

go

Is this error normal?

tests are far from ideal, so sometimes this happens


DUPLO-15103 Bug Fix Plugin crashed when creating opensearch with the warm_enabled set to true

Overview
Fixed plugin crash while creating opensearch resource when warm enabled set to true
Summary of changes
Fix bug related to creating duplo_aws_elasticsearch resource when warm enabled true due to nil pointer exception
This PR does the following:

Created object for DuploElasticSearchDomainColdStorageOptions struct and assigned to ColdStorageOptions attribute by reference to handle nil pointer exception for duplo_aws_elasticsearch resource

Created object for DuploStringValue struct and assigned to WarmType attribute by reference to handle nil pointer exception
for duplo_aws_elasticsearch resource

Testing performed

[ ] Using unit tests
[ ] Manually, on my local system
[ ✔] Manually, on a remote test system

Describe any breaking changes

...

Task linked: DUPLO-15103 TF Provider plugin crashed when creating opensearch with the warm_enabled set to true.


[Discussion] Demonstrate failing test for camel <> underscore conversion

These tests do not agree: underscore to camel conversion and camel to underscore conversion
If I'm reading correctly they use the same data and changing area51_controller Iike I did should cause two tests to fail but only one test fails. This means that words with numbers can only be converted one way: address_1 will go address1 but address1 will not go back to address_1. I suggest using numbers as boundaries so that Area51Controller becomes area_51_controller. Thoughts?
Related issue https://github.com/ngenworks/rest_framework_ember/issues/22

I don't think we can change underscore() to use numbers as word boundaries. If we did that, then converting "address1" to camelcase and back to underscore would return "address_1", which would also break things in your use case.
One solution to your problem might be that camelcase() would ignore underscores that precede a character that cannot be uppercased. For example,

camelcase("address_1") == "address_1"
camelcase("_address") == "_address"
camelcase("special__guest") == "special_Guest"

But I'm not sure if that would be good idea either, since we promote in README that inflection is a port of Ruby on Rails' inflector, and that would make inflection's behavior different from RoR's inflector.
And anyway, as the documentation says for underscore() (and vice versa for camelize()):

As a rule of thumb you can think of underscore() as the inverse of camelize(), though there are cases where that does not hold:

So it is documented that underscore(camelize(some_string)) == some_string might not always hold.


support community-specific notification sounds

with #532, we introduced a notification sound of a lion, meant for LEU.zuerich community
Each community should be able to specify their own sound as already specified in #497

This is the folder structure that we upload to IPFS per community: https://github.com/encointer/encointer-node/tree/master/client/test-data/leu.zuerich.
So similar to how we fetch the community icon: https://github.com/encointer/encointer-wallet-flutter/blob/4bcc7ae875bab20c1f373ccde5d135722dd35703/lib/service/ipfs/http_api.dart#L82
We can fetch the notification sounds. This notification sounds should then be used for the notification. The static notification sound shall be replaced with the custom one from the community. Here: https://github.com/encointer/encointer-wallet-flutter/blob/a30a921edf2bd9d7bceeeabdc97db2763df31574/lib/service/notification.dart#L89
Tasks:

[ ] fetch the sounds from IPFS
[ ] cache it in the app
[ ] use it in the notifications:

[ ] Use incoming balance sound when we notice that our balance increased
[ ] Use successful extrinsic sound when we send an extrinsic (note for LEU these two are currently the same)
[ ] This will be checked by me: Shall we use the system default sound other messages? Or use one of the above two?

So according to the folder structure you can change this code with:
 String getIconsPath(String cid) {
    return '$cid/$communityIconName';
  }

 String getIconsPath(String cid) {
    return '$cid/incoming_balance_transfer';
  }

Hello!
Can not find community specific notification sound.

We have found an issue here. Apple requires all notifications sounds to be present in the assets folder, which means that they need to exist at compile time. Hence, we need to include assets for all existing communities in the binary. This will naturally only scale to a certain point.

I will close this, as we have a manual workaround for now.


fix(Modal|Portal|Popup): use proposed value for open in onOpen & onClose callbacks

WIP
DO NOT MERGE

Codecov Report

Merging #4030 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4030      +/-   ##
==========================================
- Coverage   99.84%   99.84%   -0.01%
==========================================
  Files         186      186
  Lines        3255     3253       -2
==========================================
- Hits         3250     3248       -2
  Misses          5        5

Impacted Files
Coverage Δ

src/addons/Portal/Portal.js
100.00% <100.00%> (ø)

src/modules/Modal/Modal.js
100.00% <100.00%> (ø)

src/modules/Popup/Popup.js
98.75% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6768a7d...50c8a3d. Read the comment docs.

Released in<EMAIL_ADDRESS>🚢


only load show_subprocess_widget when in notebook

Fixes #316, #278
Changes proposed in this pull request:

Only load show_subprocess_widget when in notebook

@giulioungaretti

We need a bit more, so I will close this and open another that fixes all of this.


Fix traffic backend, get and delete api methods

Codecov Report

Merging #1159 (300bb46) into refactor-with-go (c36bb87) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head 300bb46 differs from pull request most recent head 1539809. Consider uploading reports for the commit 1539809 to get more accurate results

@@                Coverage Diff                @@
##           refactor-with-go    #1159   +/-   ##
=================================================
  Coverage             49.62%   49.62%
=================================================
  Files                    99       99
  Lines                  5088     5088
  Branches                 41       41
=================================================
  Hits                   2525     2525
  Misses                 2304     2304
  Partials                259      259

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Mention Sonatype user tokens

I was very recently reminded of those. Using them should be a bit more secure (these tokens can be revoked, only when logged the actual user and password on the Sonatype UI).

cc @jameskoch (who mentioned those tokens to me)


Add more parallelization during job finialization

Parallelize the following: (1) moving file from task output dir to final output dir; (2) cleaning task output dir and task staging dir.

Renamed ParallelStateSerDeRunner to ParallelRunner, and add two methods: deletePath() and renamePath().
Moved ParallelRunner from gobblin-runtime to gobblin-utility, since gobblin.util.JobLauncherUtils depends on it, but gobblin-utility cannot depend on gobblin-runtime.
ParallelRunnerTest has to stay in gobblin-runtime, since it depends on gobblin.runtime.TaskState.

@liyinan926 please review.

For ParallelRunnerTest, you can change TaskState to WorkUnitState and move it to under gobblin-utility.

@liyinan926 updated javadoc. Couldn't change TaskState to WorkUnitState since WorkUnitState doesn't have setStartTime or setEndTime.

It's fine to delete setStartTime and setEndTime.

@liyinan926 Updated. Now both BaseDataPublisher and JobLauncherUtils uses a map from Fs URI to ParallelRunner, which enables different tasks to share the same ParallelRunner if they use the same FileSystem. Also updated the unit test for ParallelRunner.

Updated.

LGTM.


Add documentation for the code repair and transpile tasks

awesome! will merge after https://github.com/symflower/eval-dev-quality/pull/226 is in

Closing in favor of #264 and #226


Support for INTO OUTFILE

Is the INTO OUTFILE feature currently supported? I could not find this from the current documentation.
What I want to do is like:
SELECT *
INTO OUTFILE 'c:/some-folder/users-2022-02-10.csv'
FIELDS ENCLOSED BY '"' TERMINATED BY ',' ESCAPED BY '"'
LINES TERMINATED BY '\r\n'
FROM `users`;

No not really, you can use SelectRaw.


Debugger stopped working after some changes

Environment data
dotnet --info output:
.NET Command Line Tools (1.0.4)
Product Information:
Version:            1.0.4
Commit SHA-1 hash:  af1e6684fd
Runtime Environment:
OS Name:     Windows
OS Version:  10.0.15063
OS Platform: Windows
RID:         win10-x64
Base Path:   C:\Program Files\dotnet\sdk\1.0.4
VS Code version:
1.14.2
C# Extension version:
1.11.0
Steps to reproduce
Attach a breakpoint - Start debugging
Expected  behavior
Breakpoint should remain red after build.
Breakpoint should be hit.
Actual behavior
Breakpoint is greyed after build, with message: "No symbols have been loaded of this document".
Breakpoint doesn't hit.
The debugger used to work when I created the project, but it stopped working after some changes. I tried to delete and create task.json and launch.json again, no luck. The debugger works in a brand new project, though. I probably have done something that "broke" the thing but I have no idea what.
Useful Info:

I tried to set <DebugType>portable</DebugType> in .csproj, nothing changes.
Debugger works fine in VS2017.

Current packages:
<Project Sdk="Microsoft.NET.Sdk.Web">
  <PropertyGroup>
    <TargetFramework>netcoreapp1.1</TargetFramework>
  </PropertyGroup>
  <ItemGroup>
    <PackageReference Include="AutoMapper" Version="6.1.1" />
    <PackageReference Include="Dapper" Version="1.50.2" />
    <PackageReference Include="Microsoft.AspNetCore" Version="1.1.2" />
    <PackageReference Include="Microsoft.AspNetCore.Cryptography.KeyDerivation" Version="1.1.2" />
    <PackageReference Include="Microsoft.AspNetCore.Mvc" Version="1.1.3" />
    <PackageReference Include="Microsoft.Extensions.Logging.Debug" Version="1.1.2" />
    <PackageReference Include="System.Data.Common" Version="4.3.0" />
    <PackageReference Include="System.Data.SqlClient" Version="4.3.1" />
    <PackageReference Include="xunit" Version="2.3.0-beta2-build3683" />
    <DotNetCliToolReference Include="dotnet-xunit" Version="2.3.0-beta2-build3683" />
  </ItemGroup>
</Project>

@fabioluz if you look in the debug console, do symbols load?
If they do, what message do you get if you hover over your breakpoint?

No, they don't load. This is what appears in the debugger console: https://pastebin.com/j69yg8aG
When I hover over the breakpoint, I get the message "No symbols have been loaded for this document".

Are you trying to set a break point in RF.dll? If so, it looks like it is still building a Windows PDB.
WARNING: Could not load symbols for 'RF.dll'. 'c:\Projects\RF\bin\Debug\netcoreapp1.1\RF.pdb' is a Windows PDB. These are not supported by the cross-platform .NET Core debugger.

Yeah, it is building an RF.pdb. I'm not sure what it means or how I can avoid it.

I am on vacation this week, but there is information about portable PDBs in the wiki for this project.

@fabioluz, it might be worth deleting RF.* and rebuilding the project with the portablepdb flag set.
https://github.com/OmniSharp/omnisharp-vscode/wiki/Portable-PDBs

@rajkumar42 @gregg-miskelly According to the docs, portable-pdbs should be enabled by default in my case. If I "force" portable-pdb by setting  <DebugType>portable</DebugType> in the .csproj, I get the error The preLaunchTask 'build' terminated with exit code 1.
For some reason it's still building a Windows PDB. Could it be one of my dependencies?


soc: nordic: handle -include for IAR

CMakeLists.txt uses the C compiler parameter -include, for IAR this is --preinclude.

@RobinKastberg this need rebasing to get past the unrelated CI failure


Column not found ?

Hi when i install this forum on a blank project, its work perfectly, but on my project, doesn't work..
I have this error :
SQLSTATE[42S22]: Column not found: 1054 Champ '' inconnu dans order clause (SQL: select * from chatter_discussionwherechatter_discussion.deleted_at is null order by `` desc limit 15 offset 0)
Can you help me ?
(The error is probably under my eyes...)
Thanks!

Similar issues
(2/2) QueryException
SQLSTATE[42S22]: Column not found: 1054 Unknown column '' in 'order clause' (SQL: select * from chatter_discussion where chatter_discussion.deleted_at is null order by `` desc limit 50 offset 0)

@aecy so I fix the issue on my side; you need to update your chatter.php add the following
'order_by' => [
'posts' => [
'order' => 'created_at',
'by' => 'ASC'
],
'discussions' => [
'order' => 'last_reply_at',
'by' => 'DESC'
]
],


[QUESTION]: Dell CSI Operator to CSM

How can the Team help you today?
On the following document :
https://dell.github.io/csm-docs/docs/csidriver/upgradation/drivers/operator/
It say the following :
The Dell CSI Operator is no longer actively maintained or supported. It will be deprecated in CSM 1.9. It is highly recommended that you use CSM Operator going forward.
But there is no document link which describe how to move from Dell CSI Operator to Dell CSM.

Hi @yoyz.  There is a feature in place to handle this in our next milestone: https://github.com/dell/csm/issues/996.
Can you provide some information on your current setup/configuration - CSI Driver/Platform, Container Orchestrator, etc.  Just to help understand your particular migration use case.

Hi @gallacher !
Thanks for this feature !
The platform is a dell powerstore.
It use dell-csi-operator-certified.v1.12.0 on top of openshift 4.12.

@yoyz, in the context of the CSI Operator, are you using the OpenShift UI or CLI?

@yoyz, in the context of the CSI Operator, are you using the OpenShift UI or CLI?

Hello, we are using both the web UI and CLI of OpenShift, depending on the specific task that we need to perform.

@gallacher we both work together on this topic.

Migration of CSI operator to CSM will be documented in the upcoming release.


StaticRouter adds leading slash to relative links

Version
4.1.1
Expected Behavior
StaticRouter should not add a leading slash to my relative <Link>s
Actual Behavior
StaticRouter adds a leading slash to my relative <Link>s and causes React to NOT reuse the server-rendered markup.
The behavior is due to:
This

We don't support relative links....yet! See #5127


.newgold issue, makes new piles of gold each time.

the newgold function stacks gold in a new pile rather than placing it in existing piles. For players when selling at vendors they notice this when eventually they have several piles of gold in their bag.

This also seems to happen with anything using serv.newitem i_baseid,amount,

closing issue, argument added for newgold.


Make registration instructions more explicit

I lost 10 minutes trying to figure out what was wrong as I got a rather obscure error when getting this order wrong.

thx


placeholder overlapping label when using floating labels on chrome

On Chrome Floating Labels overlap the Placeholders set for the FormInputs

codepen.io/kxc0re/pen/abEzBRa
OS: Windows 10
Browser: Chrome v99.0.4844.51
related:
https://github.com/twbs/bootstrap/issues/32800
potential fix:
hiding the placeholder on unfocused form-inputs with shown placeholder:
.form-floating > .form-control:placeholder-shown:not(:focus)::placeholder {
  color: transparent;
  text-shadow: none;
}

or a specific version for chrome-based browsers ::-webkit-input-placeholder
firefox doesn't seem to have that issue since its not showing the placeholder at all, which i would also consider a bug

Is this ever going to be fixed? For me, it is only broken in Chrome when using "v-model=" instead of "value=". Also, when v-model is bound to a reactive which gets set to a value via an API call during onMount, and an exception is thrown during the call, it works correctly.


Unparsable Date should default to today's date, not Dec. 31 1899

Should update boostrap-datetimepicker.js parseDate().
Currently the date is set to:
date = new Date(0, 0, 0, 0, 0, 0, 0), // which is Dec. 31, 1899

change to:
date = new Date(), // which is today's date

This should resolve a bunch of current reported 1899 Year issues: https://github.com/smalot/bootstrap-datetimepicker/issues?utf8=✓&q=is%3Aissue is%3Aopen 1899

I agree with this.  My app allows the user to switch field types on a table filter.  We've seen an issue where we saw the 1899 when a stale date M dd, yyyy was present when the user loaded date time format M dd, yyyy HH:ii p.
Had to call reset as a fix, but it would have nice to have this.
Or an else statement to if (parts.length === format.parts.length) { that falls back on a new date object

It would be nice if it was possible to pass the default reset date as an option for unparsable dates


configs must be namespaced to the deployment

2 deployments of the same chart version on one swarm. -> they use the same config
update one deployment (with config update) -> imka tries to delete the old config and fails

solved with prot-3


Rescale predictive_gradients when normalizer=True

Hello,
I was expecting model.predictive_gradients to return the gradients of model.predict, but it looks like it actually returns the gradients of model._raw_predict.  When normalizer=True, the user has to correct the results of model.predictive_gradients manually.  (See code below.)
This is problematic when model.predictive_gradients is used in an acquisition function in the context of Bayesian Optimization or Experimental Design, as in GPyOpt or Emukit.
The easy solution is to edit the docstring of model.predictive_gradients to make clear that normalization is not included.  A more durable solution is to rescale the output of model.predictive_gradients, similar to model.predict or model.predict_quantiles.  (I suspect that model.predict_jacobian has the same problem but I haven't checked.)
If I am missing anything, please let me know.
Thanks,
Antoine
import numpy as np
import GPy

np.random.seed(2)

X = np.random.rand(15,3)
Y = np.random.rand(15,1)

normalize_Y = True
ker = GPy.kern.RBF(input_dim=X.shape[1])
model = GPy.models.GPRegression(X=X, Y=Y, kernel=ker,
                                normalizer=normalize_Y)

x = np.array([[-0.3, 0.1, 0.5]])
mu, var = model.predict(x)
mu_jac, var_jac = model.predictive_gradients(x)

# Finite-difference approximation
eps = 1e-8
mu_jac_num = np.zeros(x.shape[1])
var_jac_num = np.zeros(x.shape[1])
for ii in range(x.shape[1]):
    x_eps = x + eps*np.eye(1, x.shape[1], ii)
    mu_eps, var_eps = model.predict(x_eps)
    mu_jac_num[ii] = (mu_eps-mu)/eps
    var_jac_num[ii] = (var_eps-var)/eps

print('MU')
print(mu_jac.ravel())
print(mu_jac_num.ravel())
if normalize_Y:
    print(mu_jac.ravel() * model.normalizer.std)

print('VAR')
print(var_jac.ravel())
print(var_jac_num.ravel())
if normalize_Y:
    print(model.normalizer.inverse_variance(var_jac).ravel())

I think you're right.
Any news or commits related to this?

Not that I know of.  I'll see if I can make a push request in the next few days.
Along the same lines, I think most people would expect that evaluating posterior_covariance_between_points between a point x and itself should return the same thing as model.predict(x)[1].  Currently this is not the case because posterior_covariance_between_points does not account for likelihood noise or normalization.

Closing as #806 was merged to devel.

@ablancha Does that also affect the calculation of the posterior mean and covariance? My code is entirely based on the assumption that this package can accurately calculate the posterior mean and covariance when normalizer is True. You may respond here if you will.

Amir, the posterior mean and variance are fine when normalizer=True.  The only problem was with the gradients of the posterior mean and variance when normalizer=True, in that the gradients did not match those computed by finite differences of model.predict. Before the fix, the following snippet would raise an error, which it shouldn't.  (Again, the culprit in the below is model.predictive_gradients, not model.predict.)
Let me know if this helps.
import numpy as np
import GPy
from GPy.models import GradientChecker

N, M, Q = 10, 15, 3
X = np.random.rand(M,Q)
Y = np.random.rand(M,1)
x = np.random.rand(N, Q)
model = GPy.models.GPRegression(X=X, Y=Y, normalizer=True)
gm = GradientChecker(lambda x: model.predict(x)[0],
                     lambda x: model.predictive_gradients(x)[0],
                     x, 'x')
gc = GradientChecker(lambda x: model.predict(x)[1],
                     lambda x: model.predictive_gradients(x)[1],
                     x, 'x')
assert(gm.checkgrad())
assert(gc.checkgrad())


Different, configurable contract execution times

#524
Added 3 configuration parameters:
trans-exectution-time - in chain_plugin, used for push_transaction and accept_transaction
rcvd-block-trans-exectution-time - in chain_plugin, used for push_block, accept_block, and chain_controller initialization of block and replay
create-block-trans-execution-time - in producer_plugin for maybe_produce_block
wasm_interface::init still uses fixed value - (figured you would comment in this review if that should have its own config value)
Made default values to be used in unit tests.

I had envisioned these would be properties on the controller and not something passed into every push()/apply() call.
I would have used the skip_flags (which shouldn't really be called skip flags) to indicate the "mode" and then based on the mode the WASM interface can pick the proper runtime.

I will put all the different execution times in chain_plugin and pass into chain_controller.

@bytemaster If I use the skip flags, the issue is that I have 3 states to convey in a flag, so I will have the ambiguity of being able to set 3 flags, where only one of them will be used.
Also, I'm assuming that you want _skip_flags used until wasm_interface needs to be called.
I was passing the time to address the eventual issue that we will have once we add multi-threading, but I guess we will need to address the same issue with _skip_flags anyways.

Another ambiguity with the flags is that when we get to calling wasm_interface::get().apply(...), at least one of those flags needs to be set, so I guess I will default to the shortest duration if one isn't set.

Made requested changes and squashed commits.


better sin_sum

This makes sin_sum work for summing an arbitrary number of elements and retain accuracy for large inputs (>1e15), and uses this improvement to remove the edge cases in bessely and besselj. Performance and accuracy information to come.

Probably also worth switching out
https://github.com/JuliaMath/Bessels.jl/blob/a94bb7f854985c7f97ee24760cf25b0b23c9754d/src/asymptotics.jl#L40-L52
I haven't tested thoroughly if that section is the cause or not but this is related to https://github.com/JuliaMath/Bessels.jl/issues/37

To do that properly I would have to restructure this a little bit to make it possible to get the sin and cos sum simultaneously.

Ya I think the error is coming before that anyway but it's been a while since I've looked at that function. This is great on my tests the accuracy was similar and was faster.
I do think this function is generally useful enough to be in base because so many people naively will compute sin(x + y) which loses lots of precision.... but I'm obviously bias :smile:

I understand where you're coming from, but the problem of errors not being composable isn't really solvable by adding random functions to base.

Ps. Totally fine to merge whenever you are ready!

I want to do some benchmarks on the 24 to 1e15 region first to make sure I haven't regressed anything.

I also think I can get rid of the two separate inputs which would be a bit cleaner.

I've done the benchmarking and cleanup that I wanted, so I think this is now good to go. The only thing I'm not 100% happy with in this version is that sin_sum of Float32s will now lose a little accuracy since it accumulates into a Float64 which can incur some inaccuracy since floatmax(Float32) is 3.4f38 (but doing the reduction this way is ~20x faster than the  method this uses for Float64.

OK, I'm finally relatively happy with the Float32 version of the reduction. It still can lose some precision, but it's a lot better than before while maintaining relatively decent speed when you don't have large arguments.

@oscardssmith I was fixing the Float32 case (which drastically improves accuracy) but was noticing that the garbage collector was running.
For Float64 case.
# master
julia> @benchmark besselj0(x) setup=(x=rand()*50 + 15.0)
BenchmarkTools.Trial: 10000 samples with 995 evaluations.
 Range (min … max):  28.635 ns …  1.378 μs  ┊ GC (min … max): 0.00% … 94.85%
 Time  (median):     65.963 ns              ┊ GC (median):    0.00%
 Time  (mean ± σ):   60.570 ns ± 44.076 ns  ┊ GC (mean ± σ):  2.31% ±  3.27%

  ▇    ▄                          ▂▇█▅▂          ▁▁▁      ▁▁▁ ▂
  █▁▆▄▁█▁▄▃▃▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁█████▇▆▃▃▁▁▄▁▁▇███▇▆▆▄▅████ █
  28.6 ns      Histogram: log(frequency) by time      93.2 ns <

 Memory estimate: 0 bytes, allocs estimate: 0.

Then the Float32 case I was actually getting allocations.
# on my test branch
julia> @benchmark besselj0(x) setup=(x=Float32(rand()*50 + 15.0))
BenchmarkTools.Trial: 10000 samples with 982 evaluations.
 Range (min … max):  60.338 ns …  1.372 μs  ┊ GC (min … max): 0.00% … 95.17%
 Time  (median):     63.087 ns              ┊ GC (median):    0.00%
 Time  (mean ± σ):   66.210 ns ± 48.384 ns  ┊ GC (mean ± σ):  3.00% ±  3.91%

  ▁▄▅▇██▇▆▄▂▁                      ▁▁                   ▁▁▁   ▂
  ████████████▇▅▃▄▁▁▁▁▁▃▁▁▁▁▁▁▃▃▁▅█████▇▆▆▄▅▅▅▄▃▁▁▁▅▆▆██████▇ █
  60.3 ns      Histogram: log(frequency) by time      90.4 ns <

 Memory estimate: 80 bytes, allocs estimate: 4.

The benchmarks on tagged version
# Bessels v0.2.8
julia> @benchmark besselj0(x) setup=(x=Float32(rand()*50 + 15.0))
BenchmarkTools.Trial: 10000 samples with 998 evaluations.
 Range (min … max):  15.738 ns … 28.151 ns  ┊ GC (min … max): 0.00% … 0.00%
 Time  (median):     16.074 ns              ┊ GC (median):    0.00%
 Time  (mean ± σ):   16.054 ns ±  0.319 ns  ┊ GC (mean ± σ):  0.00% ± 0.00%

                         ▂▄▂                ▁▆█▄
  ▁▁▂▂▂▂▂▂▂▂▂▁▂▂▂▂▂▂▂▂▂▃▅███▅▃▁▁▁▁▁▁▂▂▂▃▄▅▆▇████▆▃▂▂▃▄▅▆▆▆▄▃▂ ▃
  15.7 ns         Histogram: frequency by time        16.2 ns <

 Memory estimate: 0 bytes, allocs estimate: 0.

julia> @benchmark besselj0(x) setup=(x=rand()*50 + 15.0)
BenchmarkTools.Trial: 10000 samples with 998 evaluations.
 Range (min … max):  16.520 ns … 32.577 ns  ┊ GC (min … max): 0.00% … 0.00%
 Time  (median):     16.916 ns              ┊ GC (median):    0.00%
 Time  (mean ± σ):   17.940 ns ±  1.976 ns  ┊ GC (mean ± σ):  0.00% ± 0.00%

  █▅ ▂    ▁                                    ▆
  ██▂█▇▁▁▁█▆▂▁▂▁▁▁▁▁▁▂▂▂▂▂▂▂▂▂▂▂▂▂▂▂▂▁▁▁▂▁▁▁▁▁▁█▁▁▁▁▁▁▁▁▁▃▂▁▃ ▃
  16.5 ns         Histogram: frequency by time        22.6 ns <

 Memory estimate: 0 bytes, allocs estimate: 0.

Presumably you introduced a type instability somewhere.

Ill look closer but I get the allocation pulling out the rem_pio2_sum

using Base.Math: sin_kernel, cos_kernel, sincos_kernel, rem_pio2_kernel, DoubleFloat64, DoubleFloat32
function rem_pio2_sum(xs::Vararg{Float64})
    n = 0
    hi, lo = 0.0, 0.0
    for x in xs
        if abs(x) <= pi/4
            s = x + hi
            lo += (x - (s - hi))
        else
            n_i, y = rem_pio2_kernel(x)
            n += n_i
            s = y.hi + hi
            lo += (y.hi - (s - hi)) + y.lo
        end
        hi = s
    end
    while hi > pi/4
        hi -= pi/2
        lo -= 6.123233995736766e-17
        n += 1
    end
    while hi < -pi/4
        hi += pi/2
        lo += 6.123233995736766e-17
        n -= 1
    end
    return n, DoubleFloat64(hi, lo)
end

julia> @benchmark rem_pio2_sum(x, y, z) setup=(x=rand(); y = rand(); z = rand())
BenchmarkTools.Trial: 10000 samples with 995 evaluations.
 Range (min … max):  26.606 ns …  1.319 μs  ┊ GC (min … max): 0.00% … 95.97%
 Time  (median):     29.220 ns              ┊ GC (median):    0.00%
 Time  (mean ± σ):   32.298 ns ± 47.517 ns  ┊ GC (mean ± σ):  6.02% ±  4.00%

   ▃▅████▄▃▅▅▃ ▁▁                     ▁                  ▁▁▁▁ ▂
  ███████████████▆▄▁▁▁▃▁▁▁▁▁▁▁▁▁▄▄▆▇▇█████▇▆▇▆▆▄▄▅▄▁▄▁▆▇▆████ █
  26.6 ns      Histogram: log(frequency) by time      54.7 ns <

 Memory estimate: 80 bytes, allocs estimate: 4.


Selecting/removing one user selects/removes all the user on split bill group page

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Go to staging dot on web chrome
Create a new group with multiple new users that you have not chatted before
Click on + in the group and select split bill
Enter amount and click on save/continue
On the split money page, notice there are multiple users in green checkmark selected.
Select the first user and notice all the other users are removed
Again, select any user and notice all the users are selected

Expected Result:
Selecting/removing one user  should not selects/remove all the user on split bill group page
Actual Result:
Selecting/removing one user selects/removes all the user on split bill group page
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.3.29-0
Reproducible in staging?: yes
Reproducible in production?: no
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/93399543/f94f1ad4-5253-40bb-bd4b-e88d6a95590b
https://github.com/Expensify/App/assets/93399543/fba375a5-8caf-4087-82c1-3901d4b8de87
Expensify/Expensify Issue URL:
Issue reported by: @priya-zha
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686991867243109
View all open jobs on GitHub

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

Reproduced:

The selectedParticipants here:
https://github.com/Expensify/App/blob/a1611f9ec8f070faaf705ccc1579e2499f3beabc/src/components/MoneyRequestConfirmationList.js#L153
are missing the login:

@Beamanator do you know if that is expected? I see that the text contains the email. These accounts did not exist when I created the group with them.

it seems like in Onyx personalDetails we have two entries for the accounts created with the group, for example:

The account appears under a real ID (11033541), missing the login key, and under a front end generated ID<PHONE_NUMBER>836459) which does have the login information.
Debugging, I see that the participant is passed around with the real ID 11033541, so when we look in personalDetails for the login information, it is just not there.

When I created a group w/ a user that didn't exist yet, I saw __fake__ in the LHN (mentioned in linked issue ^). I also noticed I see this in Onyx:

And this too, due to optimistic accountIDs:

Which also leads to Hidden showing in the report participants page (I know this has been reported elsewhere, i just want to add for complete investigation):

PR up for this: https://github.com/Expensify/App/pull/21113

@zanyrenney I think this just needs payment handling.
@s77rt reviewed the PR https://github.com/Expensify/App/pull/21113 which was fixing this deploy blocker

I'll be out of office next week, I don't think you need any action from me 👋

Going to chat to @Beamanator to understand the latest here!

Hi there! After discussing internally, seeing as technically @s77rt s77rt & @narefyev91 both helped test & review that PR and you are both C+ we will be paying out $500 to each of you for your contributions as:

s77rt tested, but not on all platforms and left some good reviews
narefyev91 tested on all platforms but didn't really review as fully

Payment on upwork sent for reporting bonus and C+ work from @s77rt . Closing this one out!


⚠ ClamAV has degraded performance

In 83853cb, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 238 ms

Resolved: ClamAV performance has improved in 171bad6.


How to store the rendered image from canvas ?

Hi niklasvh,
I am developing a website on PHP(Codeigniter). In that i am using html2canvas tool to capture screen shot of a website. Its working fine. But need to to store the image in my web server ?
Is it possible with this tool?

I have used your code. It shows:
Uncaught (in promise) DOMException: Failed to execute 'toDataURL' on 'HTMLCanvasElement': Tainted canvases may not be exported.
at http://localhost/Blog/:313:24
at

Hi @deb54, "tainted canvases" are a result of cross-domain images. For Internet security reasons, trying to use an image from a different domain in a canvas causes problems. There are two html2canvas options, useCORS and proxy, which are designed to try to get around that problem. They're not perfect solutions though - you can read more over at #951 and #592.

Thanks, eKoopmans. Actually, me trying to save the total div as an image. Now I have faced two new problems, after converting Html to canvas the image size is fixed, i can't resize the canvas, if I resize then it appears blank.

Hi all, storing canvas.toDataUrl() in CodeIgniter:
Jquery, Ajax, download htm2canvas.min.js
  ```

html2canvas($('#targetDiv')[0]).then(function(canvas) {
var dataUrl = canvas.toDataURL();
var newDataURL = dataUrl.replace(/^data:image/png/, "data:application/octet-stream"); //do this to clean the url.
$("#saveBtn").attr("download", "your_pic_name.png").attr("href", newDataURL); //incase you want to create a download link to save the pic locally.
    $.ajax({
        'type': 'post',
        'url': 'link_to_function_in_controller',
        data: {
            //you can more data here
            'img':newDataURL
        },
        success: function(data){
            console.log(data);
        },
        error: function(data){
            console.log(data);
        }
    });

    });

// in your codeigniter controller
$img = $this->input->post('img'); //get the image string from ajax post
$img = substr(explode(";",$img)[1], 7); //this extract the exact image
$target=time().'_img.png'; //rename the image by time
$image = file_put_contents($_SERVER['DOCUMENT_ROOT'].'/imagefolder/'.$target, base64_decode($img)); //put the image where your image folder directory is located
        $data = array(
            'Image' => $target, //note you can add more data
            'date_inserted' => mdate('%Y-%m-%d %H:%i:%s', now())
        );

        $result = $this->model_image->post_image($data); //post_image() here should be your function in codeigniter model layer that handles the database, while the model_image is the model name itself where post_image() draws its properties from


Show hover cards when issue numbers are followed by )

We'd like to have code comments like // TODO(#123456), but a trailing space (or other whitelisted character) is needed for the hover cards to appear, like // TODO(#123456 ).
Looks like \) could be added to the final capture group here: https://github.com/microsoft/vscode-pull-request-github/blob/74e02d29f31fed271d46682a5651e2ff143c35a3/src/issues/util.ts#L16
Not sure if there are other usage patterns that would be false positives with that character allowed.

Perhaps the final capture group be broadened to just be a word boundary (\b)?

@alexr00 can you comment on whether this would make sense (either adding \) or replacing the whole thing with \b)?

I added ) to the expected characters in the regular expression.

Thanks!


Looking to make use of Powershell Core (pwsh) in tasks over PowerShell

Environment
VSTS

Agent - Hosted or Private:
Mixed of Hosted and Private & multi OS
Private will be Server 2016 and have PowerShell Core installed

Issue Description
Ideally want to be able to make use of the changes added in #7913 to enable use of PowerShell Core in build tasks over using PowerShell.
There is currently no option to allow me to pick it to use pwsh in the PowerShell Task UI
cc @bergmeister

@kilasuit As far as I can tell, an agent currently checks out version 2.136.0 of the PowerShellV2 task and by looking into it, it does not have the updated script of the master branch in it, therefore I can only conclude that this task still has not been published to the marketplace yet, which is why we do not see the option in the UI yet. Thanks for raising this again.

@bergmeister @kilasuit releases/M140 branch has the changes you need: https://github.com/Microsoft/vsts-tasks/tree/releases/m140/Tasks/PowerShellV2
The deployments for 140 has started. It will take some time to be completed for all accounts.

@ShreyasRmsft thanks for the update. Do you have any idea as to the maxium amount of time this may be to end up seeing this in our AzDO tenants?

140 is scheduled to reach the last set of accounts today

Thanks for the update. I can't see the update yet but will wait and confirm once it has

@ericsciple Any update on the rollout of 2.140? The PowerShell versions in my accounts are still on 2.136

What is the account name? I think there is one scale unit in the last deployment ring that did not get updated...

@bergmeister sorry something got missed. Although the changes for the powershell task is in releases/m140 branch, they did not get propagated to the deployment manifest files.
M141 includes the changes. M141 is on Rings 0-2, and rolling to ring 3 tomorrow. We typically progress 1 ring every day or so. So I wouldn't expect the changes to hit your account before Thursday or Friday.
If you want the change sooner, you can checkout the releases/m141 branch, build the powershell task and upload it to your account using TFX.

@kilasuit @xenalite
I see the option now in my Azure DevOps instances

Can confirm this is in mine as well


Webeditor does not work with paper1.15

If I start the web editor with /lp editor all the link that I get only shows me:

LuckPerms Logo
LuckPerms
Web Permissions Editor
To start a new editor session, please use
/lp editor
/lp user  editor
/lp group  editor

all is not an argument.
Just use /lp editor and show us the output of it.
Also, what version of LP are you using?

First of all. If it gives you a link then it works in the server meaning there’s another issue.
Can you please post the link it gives you?

I use Luckyperms v4.4.1. I had tied /lp editor  /lp group default editor  /lp editor all all of them gave me the same result.

lp editor
[18:13:59 INFO]: [LP] Preparing a new editor session. Please wait...
[18:13:59 INFO]: [LP] Click the link below to open the editor:
[18:13:59 INFO]: https://luckperms.github.io/editor/#HY8jgwcDRp
lp
[18:16:17 INFO]: [LP] Running LuckPerms v4.4.1.
[18:16:17 INFO]: [LP] Use /lp help to view available commands.

I use Luckyperms v4.4.1. I had tied /lp editor /lp group default editor /lp editor all all of them gave me the same result.

lp editor
[18:13:59 INFO]: [LP] Preparing a new editor session. Please wait...
[18:13:59 INFO]: [LP] Click the link below to open the editor:
[18:13:59 INFO]: https://luckperms.github.io/editor/#HY8jgwcDRp
lp
[18:16:17 INFO]: [LP] Running LuckPerms v4.4.1.
[18:16:17 INFO]: [LP] Use /lp help to view available commands.

LuckPerms, not LuckyPerms
The link works for me, so it is most likely an issue on your end.
Make sure your browser doesn't block javascript and that you use a supported one (i.e. Chrome, Opera, Firefox)

Loads for me. This means your browser or your personal internet connection is the issue.
See if you can access https://bytebin.lucko.me/HY8jgwcDRp

Btw we also recommend you update LP to v5 (https://luckperms.net/)

I know now what my issue was. I use piehole a DNS-server that blocks ads and tracking scripts. It somehow blocked some scripts. I was wondering before why I never noticed the updates on luckyperms.net
Thank you for your quick help <3

LuckPerms, not LuckyPerm


Bug 2094807: fix hw dropdown

📝 Description
when trying to add HW device, and no devices are configured to the cluster, the dropwdown still shows the group headers
🎥 Demo
before:
no devices:

only mediated devices:

after:
no devices:

only mediated devices:

both PCI host and mediated devices:

Signed-off-by: Aviv Turgeman<EMAIL_ADDRESS>

/lgtm


Flagged messages in overview

Is it possible to get my flagged messages in this overview?
I work with a system where incoming mails are handled with the flag system and non-support items are created through tasks in outlook. I could create a task per email but the mail would lose it's history and only keep a copy of the email as far as I can see (creating an extra copy).
Completing an email in the completed tab could run a quickstep for actions and editing could open the mail.
Thanks in advance

This would be a killer feature for me.
@evrenvarol Your Outlook Taskboard is amazing and this is what I've been searching for a long long time. Please consider adding also the To Do List items (those are the "flagged messages" from above). Thanks!

Hi, sorry for my late response as i was on holiday last 2 weeks. Personally I'm not using flagged mails in my workflow, but I can definitely see the benefit.
As @czpopi mentioned, flagged items are not tasks and they don't actually remain in the main Tasks folder. Since we are using Task folders to define task lanes, moving a flagged mail item to one of these lanes/folders is actually creating a task object automatically. So the object changes from a flagged mail to a task (with the mail attached).
I can think 3 different options at the moment:

I can change the BACKLOG lane from Tasks folder to To Do list, so it displays tasks as well as flagged mails. However if you move flagged mails to other lanes (i.e. In Progress), it automatically creates a task object with the original mail attached.
I can add an additional lane called "Flagged Mails", so flagged mails appear there but they won't be draggable. Not really sure if this would be good for kanban style workflow.
I can completely re-write the taskboard to use categories as task lanes as @czpopi suggested. This may solve both problems, however we will be losing mobile support as iOS Reminders does not support categories.

Let me know your thoughts..

I think the option 1 is feasible, only thing I'm not sure what would be the User Experience - mainly if the task is completed, would the flagged related email be also completed?
Option 2 is imho not supporting what you achieved with current release.
Option 3 is almost the needed solution, but no support throughout other platforms is blocker.
There could be 4th option - have two products one with tasks and folders, then the second for flagged items and categories. But that is hard for extension, keeping the two products up to date.
So .. for me Option 1 at the moment

Option 1 is probably the best.
Personally I'd prefer option 3 as I only use it in Outlook but I understand cutting compatibility isn't something to take lightly.
Option 4 isn't really an option as maintaining 2 products generally means 2 badly maintained projects when a new person doens't take charge of the new project.

Going with standard always brings the benefit in future. So looking forward for the next release! in case of testers needed, let me know ;)

+1 for Option 1.
@evrenvarol , do you plan to implement it in nearest future?

In my workflow i am moving mails to the Task Folder which automatically asks to create a Task. I find this to be very convenient. What is not solved (in outlook) is a fast way ta add a related mail to a Task.
Sounds like option 1 could work but i guess break at least my workflow.
Option 2 i would definitely downvote.
In general i would try to clearly separate mails and Tasks. So i recommend to leave as is.

Going with option 1 sounds best to me. Breaking it down I suggest I see 2 options, 1b) preferred
1a) Show both, eventually sorted by type
1b) In 2 sections of BACKLOG lane
Making it draggable the following would be great:
If moved to COMPLETED the email will be marked as "Completed" as well.

@rheer Thanks for the input.
I actually did not know the drag-and-drop feature and that is what was meant in option 1 to simulate, when dragging task from Backlog to next folders. the Option 1 shall not break your workflow, but extend it by one more task type to be visible in Backlog column, together with tasks. Unfortunately your workflow works just in the Outlook, while on other platforms (like iPhone) you can only flag emails directly and that is why we propose option 1.
@Shrekmachine I could find myself in both, i'd let it to be decided on @evrenvarol by what is easier to implement.

Options (1) and (2) break the kanban workflow, the original item would either not move between lanes or change to a different type, so ideally option 3 would be the best solution. I don't know if this thread and related work is still "alive" though.

Here is a version that shows emails in your inbox instead of tasks.  You have to create the folder structure under your inbox.  It also groups by conversation and shows unread in bold.
If you only want it to show flagged emails, just revert line 165 in app.js to its original form.
outlook-taskboard-master.zip

Here is a version that shows emails in your inbox instead of tasks. You have to create the folder structure under your inbox. It also groups by conversation and shows unread in bold.
If you only want it to show flagged emails, just revert line 165 in app.js to its original form.
outlook-taskboard-master.zip

Hello, thanks for your version with inbox instead of tasks. I would like to only show flagged emails but revert line 165 to its original form dont works for me "var tasks = getOutlookFolder(path, owner).Items.Restrict(restrict);" ==> all columns empty..
What could i have done wrong ?
There is no page for this fork ?


Require directoryOrFile argument when not piping stdin

This also includes creating a number of tests that run with a github workflow to ensure we don't introduce bugs into the CLI with any later changes.
closes #381

I wanted to use TestCli for recreating/testing #392, so I included that in this PR.
closes #392


MeilisearchCommunication Error SSL: WRONG_VERSION_NUMBER

Description
I use a dockerized version of meilisearch. When using the hostname to connect, it fails.
Expected behavior
Supposed to connect.
Current behavior
Getting an SSL WRONG VERSION
Screenshots or Logs
File "/opt/.venv/lib/python3.12/site-packages/meilisearch/_httprequests.py", line 64, in send_request
raise MeilisearchCommunicationError(str(err)) from err
meilisearch.errors.MeilisearchCommunicationError: MeilisearchCommunicationError, HTTPSConnectionPool(host='meilisearch', port=7700): Max retries exceeded with url: /indexes (Caused by SSLError(SSLError(1, '[SSL: WRONG_VERSION_NUMBER] wrong version number (_ssl.c:1000)')))

Environment (please complete the following information):
OS: Docker, python:3.12-bookworm
Meilisearch version: v1.7.6
meilisearch-python version: 0.31.0

Can I see your configuration for connecting to meilisearch? My guess is that it doesn't resolve the custom hostname on the network.

I would google the meilisearch SSL version it expects and make sure that's installed. If you're using Mac its easy enough to install through Brew. I'm not sure on windows.


CPU and Energy issue persists for me :(

Hi,
I posted this earlier.

As it was not the case on your system, I don't know what the reason is.
Could you have a look into that? If you need additional files (or reports) please let me know which ones and how to send you.
It is not that huge of an issue but I wonder why the process on my system is so dominant.
I didn't skip tracks, just listened to music track by track.

I updated the source code.
CPU performance should be a lot better now.
On baseline 2016 Macbook Pro: cpu should be around 0.4% and around 2% when you skip to the next song.
Energy impact should also be around 0.4
download
Let me know if it's better

Hey 😮 😃
seem to be much better on my MacBook Pro as well!
Really good job!

I'll close it for now, and see if I can optimize it a little more later on

Hello! Sorry to resurrect this issue, but with version 1.9 installed I've noticed similar CPU usage stats. What I've found is that this seems to depend on whether or not the bar display is scrolling.
With scrolling:

W/o scrolling:

This is on macOS Mojave 10.14.2


userinfo

Enter http://localhost:5000/user/username And then go to the index.html （The username already exists in the database ）

Closing this issue, as it does not apply anymore.


ReadDir cannot handle S3 key with invalid XML characters

For S3 key with invalid XML characters, ReadDir fails with failed to decode REST XML response s3=SerializationError

Specifically which characters are invalid?  ASCII 1-10?

My understanding is characters less than ASCII 24.


fix: freeze dependencies of docs build

Reported upstream - https://github.com/NiklasRosenstein/pydoc-markdown/issues/323

Good job, thanks @janbuchar


add debug logs for migrations

Description:
I have added some debug logs for migrations.
If I missed on some of the logs do let me know, I'll add them.
Fixes #477
Checklist:

[x] I have formatted my code using  goimport  and  golangci-lint.
[x] All new code is covered by unit tests.
[x] This PR does not decrease the overall code coverage.
[x] I have reviewed the code comments and documentation for clarity.

@kailashchoudhary11 - Similarly, we can add error log for the rollback method in redis. Also, currently we are providing logger to user with only Info and Error functionalities. Refer here: https://github.com/gofr-dev/gofr/blob/development/pkg/gofr/migration/logger.go We can also add methods for Debug, Notice, Warn, Fatal. (reference: https://github.com/gofr-dev/gofr/blob/development/pkg/gofr/logging/logger.go#L22)

Will work on adding those methods in the next PR. can you raise an issue for the same?

@kailashchoudhary11 - I thought you skipped this, so have already created another PR for this.

@kailashchoudhary11 - I thought you skipped this, so have already created another PR for this.

Ah okay 🥹 , Is there anything else to work on? or I can do the changes in using-migrations example.


ci(package): build speed improvements

Coverage remained the same at 97.872% when pulling fcacc0ea0ac84f542957945f465947e7e6783fab on build-improvements into c28df72103a332e7f1296fa6d1ca8b3a41989e86 on master.


SQL Logical Plan Drops ordering within UDAFs

Describe the bug
SQL supports ordering within an aggregate function, e.g. SUM(a order by b desc). DataFusion's logical planner does correctly identify this for built-in aggregates, e.g. sum(), max(), min(). However, for UDAFs, it seems to be dropped.
I've written up an example here: https://github.com/ArroyoSystems/arrow-datafusion/blob/92e92b9e971bc407b39de2ce8c9bc793355168f7/datafusion-examples/examples/simple_udaf.rs#L174.
The output is
built-in aggregate Logical plan, has ORDER BY:
Projection: SUM(t.a) ORDER BY [t.a DESC NULLS FIRST]
  Aggregate: groupBy=[[]], aggr=[[SUM(t.a) ORDER BY [t.a DESC NULLS FIRST]]]
    TableScan: t
UDAF Logical plan, missing ORDER BY:
Projection: geo_mean(t.a)
  Aggregate: groupBy=[[]], aggr=[[geo_mean(t.a)]]
    TableScan: t

To Reproduce
Register a UDAF, write a query with ordering inside it, and inspect the logical plan.
Expected behavior
The UDAF expression should have a non-empty order_by clause.
Additional context
No response

Thank you for the report @jacksonrnewhouse  -- I hope to investigate more fully at some point. Any additional debugging insight you have would be most helpful

Okay, I think I've found where this is happening and come up with a patch at https://github.com/ArroyoSystems/arrow-datafusion/pull/new/bugfix_7531. Where should I be writing a test for this?

Nice find @jacksonrnewhouse !

Where should I be writing a test for this?

I would suggest somewhere in https://github.com/apache/arrow-datafusion/blob/main/datafusion/core/tests/user_defined/user_defined_aggregates.rs

I think we may be close to / done fixing this as part of https://github.com/apache/datafusion/issues/8708


Update centos_manual_config.md

The current extras/flannel (flannel-0.5.5-1.el7) package changed the keys used for etcd configuration, see:
https://git.centos.org/blobdiff/rpms!flannel/7e924c9cf84caaf230f6a50c2a5ad5b0b6d93a9a/SOURCES!flanneld.service

This change is

Related issue #2086

@eriknelson perhaps you could add in the comment that the key changed for that version of flannel just in case someone is using an outdated package.

@foxish @apelisse I removed myself from OWNERS in this repository, why does it keep assigning things to me?

I can see that you're in the OWNERS file here: https://github.com/kubernetes/kubernetes.github.io/blob/master/docs/getting-started-guides/centos/centos_manual_config.md in the top metadata of that markdown file. I think we definitely need the bot to respect people who remove their assignment explicitly. I recently saw the same behavior elsewhere as well.
/cc @grodrigues3

sigh, I guess I'll make another PR removing myself...
On Mon, Jan 9, 2017 at 2:48 PM, Anirudh Ramanathan<EMAIL_ADDRESS>
wrote:

I can see that you're in the OWNERS file here:
https://github.com/kubernetes/kubernetes.github.io/blob/
master/docs/getting-started-guides/centos/centos_manual_config.md in the
top metadata of that markdown file. I think we definitely need the bot to
respect people who remove their assignment explicitly. I recently saw the
same behavior elsewhere as well.
/cc @grodrigues3 https://github.com/grodrigues3
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes/kubernetes.github.io/pull/2133#issuecomment-271432800,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAnglopMEpReLU__WrkCqdsZBd60wZFAks5rQrk2gaJpZM4La9dw
.


AnandBotkule

-[x ]andnmf
-[x ] nnnf
-[x] hjkd
-[ ] hjd

[ ]

[ ]

[ ] Turn on GitHub Pages
[ ] Outline my portfolio
[ ] Introduce myself to the world

anan