Action fails due to "too many 403 error responses"

This happens sometimes, the last time it happend was in a dependabot PR.
Action configuration:
      - name: Publish Unit Test Results
        uses<EMAIL_ADDRESS>        if: always()
        with:
          files: results.xml

The output of the action:
2021-11-17 13:37:23 +0000 - publish-unit-test-results -  INFO - reading results.xml
2021-11-17 13:37:23 +0000 - publish -  INFO - publishing success results for commit 99aa12eb1178be560ee201031bed471b82c408c6
2021-11-17 13:37:23 +0000 - publish -  INFO - creating check
Traceback (most recent call last):
  File "/usr/local/lib/python3.6/site-packages/requests/adapters.py", line 449, in send
    timeout=timeout
  File "/usr/local/lib/python3.6/site-packages/urllib3/connectionpool.py", line 859, in urlopen
    **response_kw
  File "/usr/local/lib/python3.6/site-packages/urllib3/connectionpool.py", line 859, in urlopen
    **response_kw
  File "/usr/local/lib/python3.6/site-packages/urllib3/connectionpool.py", line 859, in urlopen
    **response_kw
  [Previous line repeated 7 more times]
  File "/usr/local/lib/python3.6/site-packages/urllib3/connectionpool.py", line 836, in urlopen
    retries = retries.increment(method, url, response=response, _pool=self)
  File "/usr/local/lib/python3.6/site-packages/urllib3/util/retry.py", line 574, in increment
    raise MaxRetryError(_pool, url, error or ResponseError(cause))
urllib3.exceptions.MaxRetryError: HTTPSConnectionPool(host='api.github.com', port=443): Max retries exceeded with url: /repos/**ORG**/**REPO**/check-runs (Caused by ResponseError('too many 403 error responses',))

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/action/publish_unit_test_results.py", line 292, in <module>
    main(settings, gha)
  File "/action/publish_unit_test_results.py", line 103, in main
    Publisher(settings, gh, gha).publish(stats, results.case_results, conclusion)
  File "/action/publish/publisher.py", line 65, in publish
    check_run = self.publish_check(stats, cases, conclusion)
  File "/action/publish/publisher.py", line 232, in publish_check
    output=output)
  File "/usr/local/lib/python3.6/site-packages/github/Repository.py", line 3645, in create_check_run
    input=post_parameters,
  File "/usr/local/lib/python3.6/site-packages/github/Requester.py", line 355, in requestJsonAndCheck
    verb, url, parameters, headers, input, self.__customConnection(url)
  File "/usr/local/lib/python3.6/site-packages/github/Requester.py", line 454, in requestJson
    return self.__requestEncode(cnx, verb, url, parameters, headers, input, encode)
  File "/usr/local/lib/python3.6/site-packages/github/Requester.py", line 529, in __requestEncode
    cnx, verb, url, requestHeaders, encoded_input
  File "/action/publish_unit_test_results.py", line 125, in throttled_gh_request_raw
    return gh_request_raw(cnx, verb, url, requestHeaders, input)
  File "/usr/local/lib/python3.6/site-packages/github/Requester.py", line 555, in __requestRaw
    response = cnx.getresponse()
  File "/usr/local/lib/python3.6/site-packages/github/Requester.py", line 133, in getresponse
    allow_redirects=False,
  File "/usr/local/lib/python3.6/site-packages/requests/sessions.py", line 590, in post
    return self.request('POST', url, data=data, json=json, **kwargs)
  File "/usr/local/lib/python3.6/site-packages/requests/sessions.py", line 542, in request
    resp = self.send(prep, **send_kwargs)
  File "/usr/local/lib/python3.6/site-packages/requests/sessions.py", line 655, in send
    r = adapter.send(request, **kwargs)
  File "/usr/local/lib/python3.6/site-packages/requests/adapters.py", line 507, in send
    raise RetryError(e, request=request)
requests.exceptions.RetryError: HTTPSConnectionPool(host='api.github.com', port=443): Max retries exceeded with url: /repos/**ORG**/**REPO**/check-runs (Caused by ResponseError('too many 403 error responses',))

Can you run the action with:
with:
  log_level: DEBUG
  root_log_level: DEBUG

to see the timings and frequency of API calls?
Are there other actions running in the workflow that call the GitHub API?
Is the repo public?

its not a public repo, we don't have any other action using the API. just regular/plain build actions.

If DEBUG output does not provide useful insights into the underlying issue, you could try and set higher values for the following options:

seconds_between_github_reads (default is 0.25)
seconds_between_github_writes (default is 2)

Encountered this issue when creating PR from a fork repo.
Seems to affect v1.23+.
Possibly related to https://github.com/EnricoMi/publish-unit-test-result-action/commit/e33a08005f155bbbdf95270a103294fa4d90d6c1, but occurs even if the event_file parameter (or any other parameter) is not used.
Reverting to v1.22 solves the issue.
Example PR demonstrating this behavior:
https://github.com/graphql-java-kickstart/graphql-spring-boot/pull/737

Encountered this issue when creating PR from a fork repo.

This is a great observation. It turns our that only the composite action is behaving this way. Can you try this fix please:
- name: Publish Unit Test Results
  uses: EnricoMi/publish-unit-test-result-action/composite@branch-treat-empty-input-strings-as-none

@danni-m can you confirm that you only see this issue for PRs from fork repositories, for those PRs it fails consistently (as in always) and that you are running the action as a composite action (i.e. via uses: EnricoMi/publish-unit-test-result-action/composite@...)?

@EnricoMi I tried, and I  can confirm that the fix works

@EnricoMi I tried, and I can confirm that the fix works

Thanks for testing. Merged into master, to be released soon.

I've the same problem on every dependabot PRs, so this has something to do with the special environment in which dependabot PR runs.
A workaround is to manually rebuild, since in this way it became a "normal" PR.
ref https://github.blog/changelog/2021-02-19-github-actions-workflows-triggered-by-dependabot-prs-will-run-with-read-only-permissions/

@gionn have you followed the instructions on dependabot branches in the README.md?

@danni-m the same question for you, did you follow the dependabot specific instructions in the README.md?

@gionn have you followed the instructions on dependabot branches in the README.md?

sorry, found that later 👯

@EnricoMi I didn't, will try it out, thanks!

OK, in that case the 403 that you are seeing are those "Resource not accessible by integration" 403 errors that are not retry-able.
There is some improvement in master (#202) that will be released in the next v1 release that will not retry this particular 403 but genuine rate limit exceeded errors only, which are retry-able. Closing then as the source of the 403 is understood.


[Bug] Down arrow is not working if suggestion dropdown inside snippet only have one item

Reproducible in vscode.dev or in VS Code Desktop?

[X] Not reproducible in vscode.dev or VS Code Desktop

Reproducible in the monaco editor playground?

[ ] Not reproducible in the monaco editor playground

Monaco Editor Playground Link
https://microsoft.github.io/monaco-editor/playground.html?source=v0.35.0#XQAAAAJeBQAAAAAAAABBqQkHQ5NjdMjwa-jY7SIQ9S7DNlzs5W-mwj0fe1ZCDRFc9ws9XQE0SJE1jc2VKxhaLFIw9vEWSxW3yscw88CE_XEgGR9Ivd8w3mjpSjZSOKE1xhLc1lhytLzTgHexlZdf13AMmb8eWCqPBcz0ifSqHTfhIHUQQZh3WL4dej8ii7Di1rWv30U56tLLpyEnLGYJN5LChcnzNw6oMDYL4hixkD22ehHpv6594EMs6dJ9P1TYZqJVwAACKjltTzi4D0cADCfK3Io7A_VavD7eK_AwOwZybAyNom2JgPgXBKJrJSQlas-hAE8rHloJ9c1Q8oYCEGTJXhDO5dsK8vMuVdxGPoS1E9rYBmveYEGUTA_BD0jjKRMtBUL4mBtRsNjpdBds59C22m2kWnJy_vNoDo0mPRoiF2I5F-_f4AvyjOf5x3OVk0Cd4y_c9TyLOldsuGAbDyUFujS6UAVf5b0oSr_k7WjOUJZDXj1oRWVYFwLp7M3ryVnGR-TON8vKAKLTQiNn2QT5PFmonEuf5s8KD503xQU4d_aIIbeYBGGg1q2M0iHP6sBFtZrPAS6us2B_MYutA_v-Wo-nKSdJRx96jOzSq8r2k1-EYN1UujXB7QZQEeP8YJrwRlHyeifZcTSTuRSxNtsS00FypOGLikPdCzTyzdyJJrLOoHVxnwijxuoN9G6DO96son9PoB_KqFTzJ-Q7t09uKHQb7dbA9zWrGiv_FXfHAA
Monaco Editor Playground Code
function createSuggestions (range) {
  const kind = monaco.languages.CompletionItemKind.Snippet;
  const insertTextRules = monaco.languages.CompletionItemInsertTextRule.InsertAsSnippet;

  return [
    {
      label: 'line',
      kind,
      detail: 'Line',
      insertText: 'Line 1: $1\nLine2: $2\n',
      insertTextRules,
      range,
    },
    {
      label: 'while-do',
      kind,
      detail: 'Inline note',
      insertText: 'note: \'${1:}\'',
      insertTextRules,
      range,
    },
    {
      label: 'for-each',
      kind,
      detail: 'For each loop',
      insertText: 'Some snippet text',
      insertTextRules,
      range,
    },
    {
      label: 'for-in',
      kind,
      detail: 'For in loop',
      insertText: 'Some snippet text',
      insertTextRules,
      range,
    },
  ];
}

monaco.languages.registerCompletionItemProvider("json", {
	provideCompletionItems: function (model, position) {

		var word = model.getWordUntilPosition(position);
		var range = {
			startLineNumber: position.lineNumber,
			endLineNumber: position.lineNumber,
			startColumn: word.startColumn,
			endColumn: word.endColumn,
		};
		return {
			suggestions: createSuggestions(range),
		};
	},
});

monaco.editor.create(document.getElementById("container"), {
	value: '',
	language: "json",
});

Reproduction Steps

Type li
Press Tab
Type wh
Press Down arrow

The cursor goes to the next line

Actual (Problematic) Behavior
When the suggestion dropdown inside a snippet's tabstop only has 1 item, pressing Down arrow will go to next line instead of selecting that item
Expected Behavior
Press Down arrow should select the suggestion item when it has only 1 item.
Additional Context
If the suggestion dropdown has more than 1 item, it can be selected using Up/Down arrow. For example:

Type li
Press Tab
Type fo
Press Down arrow

Result:

I can reproduce.

Just adding that we're currently running into this also occurring with completions outside the context of within-snippet completion.
vscode's selectNextSuggestion doesn't appear to be supported in monaco so we cannot create some kind of custom keybinding for this. Any suggested-if-hacky workarounds until/if this is fixed?
Let me know if this worth another issue.

Details if they're useful:

We're trying to implement the exact same requirements that #709 has.
We've gotten close by combining {suggest: {selectionMode: "never"}} with a custom enter keybinding for acceptSelectedSuggestion when editorTextFocus && suggestWidgetVisible && suggestWidgetHasFocusedSuggestion
But when a single completion item of any kind (in or out of ongoing snippet completion/tab stops/etc) is left, it cannot be selected by any keyboard means.

Thanks!


Make a central repo for project ideas

Could be the main website repo, once it is separate.
Could keep research links in there, in a new folder.
Export bookmarks in git?

Notes repo created!


Show active menu item

We should indicate the currently active menu item by making it blue

resolved with https://github.com/blockstack/docs.blockstack/commit/66b1a5a9cdea9827394baeaf2ce13130ddf3aa58


Add support for bmp

Since GD in PHP 7.2 now supports BMP I figured I'd submit a PR to enable this functionality.

Any plan to merge?

Hi. Will this commit merged?

I would love having bmp format support too


[Feat]: Ability to customize service name per container/port

What feature?
I'd like to have the ability to rename/customize the service name that is given to a particular container/port combination.
For example a docker-compose file like this:
services:
  service-a:
    ports:
    - 8080:8080
    - 8081:8081

Gives two urls:
https://service-a-ui-8080-<branch>-<random>.livecycle.run/
https://service-a-ui-8081-<branch>-<random>.livecycle.run/

I'd like the ability to override the urls to anything I would like: i.e.
# for service-a 8080
https://api-<branch>-<random>.livecycle.run/

# for service-a 8081
https://metrics-<branch>-<random>.livecycle.run/

Ideally, this would still work with the service discovery and PREEVY_BASE_URL documented here
Describe the solution you'd like
The existing preevy.expose label could be augmented to support an optional prefix of name=
Example:
preevy.expose: api=8080,metrics=8081

The only downside I can think of is if you might have multiple containers that would define a specific url, and this would have to be caught and have an error thrown (i.e. if two containers specified an api port to expose). This is an example of an invalid config:
services:
  service-a:
    ports:
    - 8080:8080
    labels:
      preevy.expose: api=8080
  service-b:
    ports:
    - 7777:7777
    labels:
      # both containers use api, this would be invalid
      preevy.expose: api=7777

Describe alternatives you've considered

Currently the only way I can think of doing this is to rename my containers

Additional context
See https://livecyclecommunity.slack.com/archives/C05S50C9Z5F/p1707144759493989
Add screenshots
No response
Record

[X] I agree to follow this project's Code of Conduct

@aleclerc-cio please see #426 for a broader discussion of container labels, feedback welcome!


Camera - Right mouse button needed to rotate camera

This give the posibility of select elements in the simulation screen without moving the screen

Hide mouse cursor only when right mouse button is pressed


Add an .upsert() that abstracts on top of .onConflict() and .onDuplicateKeyUpdate()?

The two don't differ much in API:
await db
	.insertInto('pet')
	.values({
		name: 'Catto',
		species: 'cat',
	})
	.onConflict((oc) => oc
		.column('name')
		.doUpdateSet({ species: 'hamster' })
	)
	.execute()

await db
	.insertInto('pet')
	.values({
		name: 'Catto',
		species: 'cat',
	})
	.onDuplicateKeyUpdate({ species: 'hamster' })

Here's a pseudo-prototype:
class InsertQueryBuilder<Table> {
	upsert(keyColumn?: PrimaryKey<Table>, newValues: Updateable<Table>) {
		if(this.db.dialect instanceof PostgresqlDialect) {
			return this.onConflict(oc => oc
				.column(keyColumn | this.table.primaryKey)
				.doUpdateSet(newValues)
			)
		} else if(this.db.dialect instanceof MysqlDialect) {
			return this.onDuplicateKeyUpdate(newValues)
		}
	}
}

Of course it's oversimplified, but is this feasible?

Hey 👋
Kysely has a WYSIWYG design philosophy - trying to be as close as possible to writing SQL.
Your proposal doesn't align with that, and cannot be part of a builder's API.
We do have a place for QoL helper functions, and shipped some JSON helpers in recent releases.
This proposal is a good candidate for that, but we need to figure out if it can be solved for the wide enough range of cases and in a type-safe way.

My problem with adding more and more ORM features in the helpers folder is that, even though they are written as "helpers" and meant as second class citizens, people will start to think of them as official parts of the library. They won't understand the distinction between the core and the helpers.
So soon we'd just have an oddly organized crappy ORM 😄

Alright, I'm fine with this "query builder and no more" mindset ;) This issue is a rather random thought, won't blame you for not considering it.


webpack 5.0.0-rc.1 regression --watch CLI option broke

Bug report
What is the current behavior?
Looks like there is a regression between rc.0 and rc.1.
Adding the --watch option to the webpack CLI stopped working in rc.1 and now returns the following error:
/myproject/node_modules/webpack-cli/bin/cli.js:281
				throw err;
				^

Error: A 'callback' argument need to be provided when the 'watch' option is set
    at webpack (/myproject/node_modules/webpack/lib/webpack.js:140:10)
    at f (/myproject/node_modules/webpack/lib/index.js:31:15)
    at processOptions (/myproject/node_modules/webpack-cli/bin/cli.js:272:16)
    at /myproject/node_modules/webpack-cli/bin/cli.js:364:3
    at Object.parse (/myproject/node_modules/webpack-cli/node_modules/yargs/yargs.js:576:18)
    at /myproject/node_modules/webpack-cli/bin/cli.js:49:8
    at Object.<anonymous> (/myproject/node_modules/webpack-cli/bin/cli.js:366:3)
    at Module._compile (internal/modules/cjs/loader.js:1076:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1097:10)
    at Module.load (internal/modules/cjs/loader.js:941:32)
    at Function.Module._load (internal/modules/cjs/loader.js:782:14)
    at Module.require (internal/modules/cjs/loader.js:965:19)
    at require (internal/modules/cjs/helpers.js:88:18)
    at Object.<anonymous> (/myproject/node_modules/webpack/bin/webpack.js:132:2)
    at Module._compile (internal/modules/cjs/loader.js:1076:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1097:10)
    at Module.load (internal/modules/cjs/loader.js:941:32)
    at Function.Module._load (internal/modules/cjs/loader.js:782:14)
    at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:72:12)
    at internal/main/run_main_module.js:17:47

Rolling back to rc.0 makes the error go away.
If the current behavior is a bug, please provide the steps to reproduce.
Using any webpack.config.js file run webpack --watch instead of the regular webpack command
What is the expected behavior?
webpack --watch should work without any errors as it does with rc.0.
Other relevant information:
webpack version: 5.0.0-rc.1
Node.js version:  14.10.1
Operating System: macOS
Additional tools: N/A

What is version of webpack-cli?

webpack-cli 3.3.12 and 4.0.0-rc.0 both produce the same error.

@EvHaus Thanks

Let's revert this change to a deprecation instead

I can see the same issue without having a config file.
webpack -w in.js -o out.js
[webpack-cli] Error: A 'callback' argument need to be provided when the 'watch' option is set
[webpack-cli] TypeError: Cannot read property 'compilers' of undefined

Thanks for the report. Fix is on the way and I'll publish a new RC after that.

fix in 5.0.0-rc.2

Confirmed. 5.0.0-rc.2 fixes the problem for me.


ReRanker model registred bu not found

Hi,
This is not an issue but llmware is little bit cryptic when working with model that are not part of the modelCatalog.
As far as I can see, there are jinaai reranker models : turbo_en and tiny_en in the modelCatalog.
I want to load a new one in the modelCatalog.
Can someone show me how to proceed. I'm new to llmware api.
I tried this but it said llmware.exceptions.ModelNotFoundException: 'jinaai/jina-reranker-v2-base-multilingual' could not be located
LLMWareConfig.set_home("D:\\path-to-llmware_data_folder\\")  # where under` jina-reranker-v2-base-multilingual `folder I put the model
hf_model_name = "jinaai/jina-reranker-v2-base-multilingual"
os.environ["HF_TOKEN"] = "my_hf_token"
ModelCatalog().register_new_model_card.register_sentence_transformer_model(model_name=hf_model_name,embedding_dims=384,context_window=8192,link="https://huggingface.co/jinaai/jina-reranker-v2-base-multilingual",display_name="jina-reranker-v2-base-multilingual")
reranker_model = ModelCatalog().load_model("jina-reranker-v2-base-multilingual")

Any insight

@arcontechnologies - thanks for the message and sorry that you ran into this issue.   Generally, just about any model from HF can be used in llmware, but it requires a single one line step first to 'register' the model in the llmware ModelCatalog- and then once registered, the model can be used in a first-tier way just by referencing the model_name.    For the general case with HF, please look here.
The Jina Reranker is a new capability - to add a Jina model, you can add a new model card as follows:

# fill in the dictionary entry with the relevant details - hopefully straightforward

  my_new_jina_model = {"model_name": 'my_favorite_jina_model', "display_name": "jina-multi",
  "model_family": "HFReRankerModel",
  "model_category": "reranker", "model_location": "hf_repo", "embedding_dims": 384, "context_window": 8192,
  "link": "https://huggingface.co/jinaai/jina-reranker-v2-base-multilingual", "custom_model_files": [],
  "custom_model_repo": ""
  "hf_repo": "jinaai/jina-reranker-v2-base-multilingual"}

ModelCatalog().register_new_model_card(my_new_jina_model)

Once you complete that step, you can use the model with .load_model("my_favorite_jina_model") -> the most important attributes to get right are the hf repo, embedding dims and context window.
Hope that makes sense - and please ping back with any questions/clarifications.

@doberst  Thank you so much for the quick answer. I'll follow the instructions.


Support for Xiao ESP32C3

Hi and let me star by saying AWESOME project.
Did play a bit with other boards with glow, but would love to try and make this work on micro board - Xiao ESP32C3.
Am I right thinking that D10 pin could be used instead of D7/D13

This would make everything really compact. And it indicator is ditched, could almost fit in case for sensor board. (in terms of size).
Link to the board is here:
https://wiki.seeedstudio.com/XIAO_ESP32C3_Getting_Started/

Expect you to be able to use that GPIO pin without any problems 😉


Add GitHub Action to detect unlocalized labels in PRs

Detect any Labels that don't have text="# or text="{ (for data strings) and alert PR author + reviewers about it.

Could also do something like
for script in **/*.js; do
	if [ "$(head -n 1 "$script")" != 'use strict;' ]; then
		echo "$script" 'not in strict mode'
		exit 1
	fi
done
exit 0

though maybe we wanna just add linting at that point

Use strict can be done by ESLint.
This should also detect setting (label).text =  in JavaScript files

There's some numeric strings we do that this isn't appropriate for. To me, spotting this stuff is what code review is for. Doing a regex in CI that detects this sounds hard to get right, and more effort than it's worth. I think we should close this issue.

Yeah alright. I'll close this and disable issues for this repo finally.


Update to 4.3.0 not possible - rutorrent breaks

Support guidelines

[X] I've read the support guidelines

I've found a bug and checked that ...

[ ] ... the documentation does not mention anything about my problem
[ ] ... there are no open or closed issues that are related to my problem

Description
Wanted to update to 4.3.0 but it breaks. Had to revert and am now using     image: crazymax/rtorrent-rutorrent:4.2.9-0.9.8_2-0.13.8_2
in compose.yml.
Expected behaviour
Rutorrent to work
Actual behaviour
Many error messages, I have a screen shot
[15.05.2024 21:59:06] WebUl started.
[15.05.2024 21:59:07]JS error: [http://<IP_ADDRESS>:8080/: 3015] Uncaught ReferenceError: injectCustomElementCSS is not defined
[15.05.2024 21:59:071 Bad response from server: (404 [error,listl) < html>  < title >404 Not Found  ‹center> 404 Not Found  nginx
page -->  <!-- a padding to disable MSIE and Chrome friendly error page -→>

Steps to reproduce
1 set compose.yml to latest
2 pull & start
3 doesnt work
Docker info
Client: Docker Engine - Community
 Version:    26.1.0
 Context:    default
 Debug Mode: false
 Plugins:
  buildx: Docker Buildx (Docker Inc.)
    Version:  v0.14.0
    Path:     /usr/libexec/docker/cli-plugins/docker-buildx
  compose: Docker Compose (Docker Inc.)
    Version:  v2.26.1
    Path:     /usr/libexec/docker/cli-plugins/docker-compose

Server:
 Containers: 8
  Running: 6
  Paused: 0
  Stopped: 2
 Images: 99
 Server Version: 26.1.0
 Storage Driver: overlay2
  Backing Filesystem: extfs
  Supports d_type: true
  Using metacopy: false
  Native Overlay Diff: true
  userxattr: false
 Logging Driver: json-file
 Cgroup Driver: systemd
 Cgroup Version: 2
 Plugins:
  Volume: local
  Network: bridge host ipvlan macvlan null overlay
  Log: awslogs fluentd gcplogs gelf journald json-file local splunk syslog
 Swarm: inactive
 Runtimes: io.containerd.runc.v2 runc
 Default Runtime: runc
 Init Binary: docker-init
 containerd version: e377cd56a71523140ca6ae87e30244719194a521
 runc version: v1.1.12-0-g51d5e94
 init version: de40ad0
 Security Options:
  apparmor
  seccomp
   Profile: builtin
  cgroupns
 Kernel Version: 6.1.0-20-amd64
 Operating System: Debian GNU/Linux 12 (bookworm)
 OSType: linux
 Architecture: x86_64
 CPUs: 4
 Total Memory: 31.2GiB
 Name: dsrvxxii
 ID: 30913477-cafc-44ba-86d0-1eafd7a92d18
 Docker Root Dir: /var/lib/docker
 Debug Mode: false
 Experimental: false
 Insecure Registries:
  <IP_ADDRESS>/8
 Live Restore Enabled: false

Docker Compose config
No response
Logs
will have to get back on this

Additional info
No response

Yep, having the exact same issue here. latest fails to work with a 404, 4.2.9-0.9.8_2-0.13.8_2 works fine

Hello @dstyp @SnorreSelmer There are two steps required to upgrade to latest.

Clear your web browser cache.
Set RU_REMOVE_CORE_PLUGINS environment variable to false. The 404 error is caused by removing the httprpc plugin from the previous version of the docker container. This is now required for ruTorrent v4.3.0, as we dropped support for rpc.

Please do not hesitate to ask, if you have any further questions about this version upgrade. There are very significant and impactful changes to the docker container. It highly recommended to invest 15 minutes of your time into upgrading.

Set RU_REMOVE_CORE_PLUGINS environment variable to false.

@stickz Let me know if we should add this to the changelog or feel to open a PR 👍

@dstyp @SnorreSelmer Please pull the latest ruTorrent v4.3.1 docker image @crazy-max just tagged. This will automatically resolve your problem. You'll receive a warning instead and ruTorrent v4.3.1 will load successfully.

@stickz @crazy-max great stuff just in time for the weekend. Thank you for the efforts! 🙏⭐


Message for constraints on hosted workflows don't seem to quite work

Bug Report
Expected behaviour
Webservice should reject duplicates
Actual behaviour
The add hosted workflow dialogue was hanging with no-end. Hit the register button a few times and ended up with duplicates. Verified that they have actual different ids

Not entirely related but...in general, the button that was just hit should be disabled when it's still doing something.

Agreed, should be a ui fix as well

This seems to be constrained now but the message is not shown

I seem to still be able to register a tool with a duplicate name.

@agduncan94 what do the two records in the database table look like?

In discussion: this seems to be a mismatch between the production/staging database and a hibernate created one

Constrained and message shown properly
DockstoreAPI - 1.5.0-beta.2
DockstoreUI - 2.2.0-beta.0


Replace Dimension Door card with potion

Remove the Wanderer's card Dimension Door. Add a new potion for the
Scroll of Dimension Door. The behavior for travel is implemented.
Currently, the potion has a limitation that it must be used during an
encounter before seeing the map.
Resolves #44 and #46.
I think because it works enough to let people play with and balance the effects, it's worth putting in. Stuff still to do:

It's not friendly to use, in that players would want to click it when looking at the map. That's currently not possible.
Remove logic for extra travel range if that's never going to be used.
It needs to be updated to look like a scroll. I haven't looked at all into laying the groundwork for those textures.

Pushed an update with a hack that allows it to be used when looking at the map (making it extend FruitJuice) - the patches required to emulate it were worse. Agreed that we don't need the scroll art to merge. Thanks!

I really like this idea. I had discarded it, but I think I should change my metric to be closer to: what’s less hack code. This is less than the probably three patches, and two of them might have been nasty, raw ones, for making it work otherwise.
I guess in the world of modding StS, everything’s a hack.
One thing I hadn’t checked, because I didn’t have this working, does the reachability check update if you drink it on the map? I’ll pull master and give it a try.

From: Dan Bjorge<EMAIL_ADDRESS>Sent: Thursday, November 7, 2019 10:36:50 PM
To: dbjorge/jorbs-spire-mod<EMAIL_ADDRESS>Cc: Frenoss<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [dbjorge/jorbs-spire-mod] Replace Dimension Door card with potion (#110)
Pushed an update with a hack that allows it to be used when looking at the map (making it extend FruitJuice) - the patches required to emulate it were worse. Agreed that we don't need the scroll art to merge. Thanks!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/dbjorge/jorbs-spire-mod/pull/110?email_source=notifications&email_token=ABPGUZSS5QNKGBEF5NF3HRLQSUCIFA5CNFSM4JJ6TXOKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDO4KQI#issuecomment-551404865, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABPGUZXRCHLLTH7SFIYETOLQSUCIFANCNFSM4JJ6TXOA.

Oh wow, it just works.

From: Aaron Schrader<EMAIL_ADDRESS>Sent: Thursday, November 7, 2019 11:48:04 PM
To: dbjorge/jorbs-spire-mod<EMAIL_ADDRESS>dbjorge/jorbs-spire-mod<EMAIL_ADDRESS>Cc: Author<EMAIL_ADDRESS>Subject: RE: [dbjorge/jorbs-spire-mod] Replace Dimension Door card with potion (#110)
I really like this idea. I had discarded it, but I think I should change my metric to be closer to: what’s less hack code. This is less than the probably three patches, and two of them might have been nasty, raw ones, for making it work otherwise.
I guess in the world of modding StS, everything’s a hack.
One thing I hadn’t checked, because I didn’t have this working, does the reachability check update if you drink it on the map? I’ll pull master and give it a try.

From: Dan Bjorge<EMAIL_ADDRESS>Sent: Thursday, November 7, 2019 10:36:50 PM
To: dbjorge/jorbs-spire-mod<EMAIL_ADDRESS>Cc: Frenoss<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [dbjorge/jorbs-spire-mod] Replace Dimension Door card with potion (#110)
Pushed an update with a hack that allows it to be used when looking at the map (making it extend FruitJuice) - the patches required to emulate it were worse. Agreed that we don't need the scroll art to merge. Thanks!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/dbjorge/jorbs-spire-mod/pull/110?email_source=notifications&email_token=ABPGUZSS5QNKGBEF5NF3HRLQSUCIFA5CNFSM4JJ6TXOKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDO4KQI#issuecomment-551404865, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABPGUZXRCHLLTH7SFIYETOLQSUCIFANCNFSM4JJ6TXOA.


Definie address type in reverse geocoding?

Thanks for the super simple, easy to use package. Is there any way to define the address type when doing a reverse geocoding request? In particular I'm hoping to get a street_address
See: https://developers.google.com/maps/documentation/javascript/geocoding#GeocodingAddressTypes

The types[] field you point in your link is in the response object, not to add in a request.
The geocoding api will give you all types available in the response for the result places.


feat(metric): improve backfill metrics

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?

Resolve https://github.com/risingwavelabs/risingwave/issues/15174
Unify no shuffle backfill and arrangement backfill metrics.

Checklist

[ ] I have written necessary rustdoc comments
[ ] I have added necessary unit tests and integration tests
[ ] I have added test labels as necessary. See details.
[ ] I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features #7934).
[ ] My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
[ ] All checks passed in ./risedev check (or alias, ./risedev c)
[ ] My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)

[ ] My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

[ ] My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

LGTM


File uploads using multipart/form-data

Support the common file upload method that uses multipart/form-data.

fixed in https://github.com/linkeddata/ldnode/commit/bf78e7791ddd7d40a0541498a0fe25cc5c974e90


Update README.md to clarify about Multiplayer

Clarified changes to the official game to include Multiplayer.

This has been addressed in #252


pyspider retry not work

I use pyspiser with proxy to crawl some web,because of using proxy i got some 404.But pyspider didn't retry it so i can't get next page .Does pyspider retry not work with 404 page?If so,how to make it retry 404 page

retry should works on 404 pages, it works for me .


Correct function for rest api template

Adding functionality to provide brokerConfig parameters in ActiveMQ Artemis scaler from restAPITemplate.
In reference  to #2097
Checklist

[x] Commits are signed with Developer Certificate of Origin (DCO - learn more)
[x] Tests have been added
[ ] A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
[ ] A PR is opened to update the documentation on (repo) (if applicable)
[ ] Changelog has been updated

Fixes #2097

@ahmelsayed @zroubalik PTAL

Hi @zroubalik , @tomkerkhove , @balchua I've added the functionality to parse out the parameters from restApiTemplate. PTAL
Now there are two options.

we add a check to throw an error to users not to provide both restApiTemplate & brokerConfig in metadata.
we just mention this information in our scaler's document because when we provide restAPITemplate the code doesn't try to search values of the parameters from config.

what do you suggest?

I was wondering if there is a need to verify the restApiTemplate here.  I don't know how much maintenance this will incur and keeping it up to date.
Since a wrong path and request parameters will yield some http errors.

I was wondering if there is a need to verify the restApiTemplate here. I don't know how much maintenance this will incur and keeping it up to date.
Since a wrong path and request parameters will yield some http errors.

Hi @balchua I've added verification if the parameters are given or not for the parser. If the parsing path is wrong and not valid generally the code will throw Error .Can you share any Example case for the wrong restAPITemplate so we can make sure it doesn't raise concern later on.

Hi @Ritikaa96  just an invalid endpoint will do.
I also recall someone tried to hook this up to ActiveMQ classic, which worked since the jmx output is similar to artemis.  But the rest API template is different.  The discussion was posted in slack.
Is this something that keda would like to have?
Generally I don't have objections on validating the url like what you did.  I was just wondering if this will be too much of a maintenance burden.

Hi @balchua @tomkerkhove @zroubalik , as we discussed in #2097 , the above change goes with allowing only one way at a time to provide the borkerConfig. If the use causes more maintenance issues then maybe we can go for second option and remove restApiTemplate from metadata.
Furthermore, restApiTemplate is generated using brokerConfig no matter if we have provided it in metadata acc to scaler code here
this function's references are getMetrics & isActive from artemis code already.
Please let me know what you think about removing restApiTemplate altogether as its already been generated from the default template.

Hi @Ritikaa96 just an invalid endpoint will do.
I also recall someone tried to hook this up to ActiveMQ classic, which worked since the jmx output is similar to artemis. But the rest API template is different. The discussion was posted in slack. Is this something that keda would like to have? Generally I don't have objections on validating the url like what you did. I was just wondering if this will be too much of a maintenance burden.

I just checked the code for ActiveMQ Classic and the parser is just the same there. The maintenance concern might stay for the ActiveMQ classic code too. Am I missing something here? Please let me know.

I didn't look at the details of activemq classic carefully tho.
I am not sure about the deprecation policy of KEDA, coz removing the restApiTemplate will break existing installations when they upgrade.
A PR to include activemq classic. 😃
https://github.com/kedacore/keda/pull/2121

I didn't look at the details of activemq classic carefully tho.
I am not sure about the deprecation policy of KEDA, coz removing the restApiTemplate will break existing installations when they upgrade.
A PR to include activemq classic. smiley #2121

@balchua yes i saw the code and changes. mostly are same, at least the restApiTemplate parser is so the real question is that if this change is acceptable or the maintainers wants to have some other changes because either way the code having both restapitemplate and broker config from metadata at the same time seems redundant as it is regenerated through the  brokerConfig params while getting the metrics and also checking for the active state.

@balchua I see. I might be wrong but it seems like we are still using the same default template to access the endpoint either way. as per this code here .
the queueMessageCount function is called upon by GetMetrics and IsActive functions. this function here call to getMonitoringPoint everytime without an exception which generate the endpoint in our default template form. So either way we are using the same template for endpoint.
func (s *artemisScaler) getQueueMessageCount() (int, error) {
	var monitoringInfo *artemisMonitoring
	messageCount := 0

	client := s.httpClient
	url := s.getMonitoringEndpoint()
......

func (s *artemisScaler) IsActive(ctx context.Context) (bool, error) {
	messages, err := s.getQueueMessageCount()
........

func (s *artemisScaler) GetMetrics(ctx context.Context, metricName string, metricSelector labels.Selector) ([]external_metrics.ExternalMetricValue, error) {
	messages, err := s.getQueueMessageCount()

	if err != nil {
		artemisLog.Error(err, "Unable to access the artemis management endpoint", "managementEndpoint", s.metadata.managementEndpoint)
		return []external_metrics.ExternalMetricValue{}, err
	}
.......

func (s *artemisScaler) getMonitoringEndpoint() string {
	replacer := strings.NewReplacer("<<managementEndpoint>>", s.metadata.managementEndpoint,
		"<<queueName>>", s.metadata.queueName,
		"<<brokerName>>", s.metadata.brokerName,
		"<<brokerAddress>>", s.metadata.brokerAddress)

	monitoringEndpoint := replacer.Replace(s.metadata.restAPITemplate)

	return monitoringEndpoint
}

@balchua If the monitoring is done by the default restApi content anyways then it is possible the current users are only utilising the same for now which makes it redundant to regenerate the same API that's given by metadata.
To include possibly different restAPI , we can do something like this perhaps:
func (s *artemisScaler) getQueueMessageCount() (int, error) {
	var monitoringInfo *artemisMonitoring
	messageCount := 0

	client := s.httpClient
        if s.metadata.restApiTemplate != " " {
         url:= s.metadata.restApiTemplate
         }
	else {
          url := s.getMonitoringEndpoint()
        }

	req, err := http.NewRequest("GET", url, nil)

	req.SetBasicAuth(s.metadata.username, s.metadata.password)
......

What do you think? it will include every restAPITemplate's value, and our code won't regenerate the url without needing it.

@Ritikaa96 i am ok with your proposal.  So in short, if a user uses the restApiTemplate (its no longer a template in this case) it is up to the user to verify the validity of the endpoint provided.
I think this is fine to me.

@balchua If the monitoring is done by the default restApi content anyways then it is possible the current users are only utilising the same for now which makes it redundant to regenerate the same API that's given by metadata. To include possibly different restAPI , we can do something like this perhaps:
func (s *artemisScaler) getQueueMessageCount() (int, error) {
	var monitoringInfo *artemisMonitoring
	messageCount := 0

	client := s.httpClient
        if s.metadata.restApiTemplate != " " {
         url:= s.metadata.restApiTemplate
         }
	else {
          url := s.getMonitoringEndpoint()
        }

	req, err := http.NewRequest("GET", url, nil)

	req.SetBasicAuth(s.metadata.username, s.metadata.password)
......

What do you think? it will include every restAPITemplate's value, and our code won't regenerate the url without needing it.

@balchua  thank you , so should i update the current code to this above ?

Yes for me. 😃

Looking good, could you please note this change in Changelog?

Hi @zroubalik , what do you think about the discussion above? I just tried, as per the discussion with @balchua , to make the repetitive regeneration of restAPiTemplate conditional but then if restAPITemplate is not valid it would throw an error for sure and it will depend on the user to confirm their input was correct.
Please let me know after you go through the discussion.

@zroubalik PTAL. I've added the change in CHANGELOG. I'd also like to know what is your opinion about the discussion above. My first preference would be having broker config parameters when restAPITemplate is not provided as to when we regenerate the monitoringEndpoints , we use our default endpoint as a reference which guarantees that the format of restAPITemplate in use is the same in all cases. So in this case, if restAPITemplate has a different content, even then GetMetrics and isActive regenerate the default restAPITemplate as per the code leaving the original API as redundant information.


[TRI-1363] feat: Allow cancelling job runs from the TriggerClient

Is your feature request related to a problem? Please describe.
There is currently no way to cancel a job run programmatically.
Describe the solution you'd like to see
It would be great if there was an instance method exposed on TriggerClient that allowed cancelling a run:
await client.cancelRun(runId)

This will require a new endpoint POST /api/v1/runs/$runId/cancel.  It should use the CancelRunService which is used when cancelling a run from the dashboard. The response body should be the same response as the GET /api/v1/runs/$runId endpoint.
Describe alternate solutions
N/A
Additional information
No response
TRI-1363

hey, i would like to take up this issue :)

done!

a bit of management and head's up would be cool to not do the same issue someone else is doing! @ericallam

this makes me unsure if i want to do other issues that i think i can do right now because:

i feel like me making a PR first does not matter anymore.
someone else would make a PR and you wouldn't work with mine, without much explanation behind your decision.

what do you think?


Touch not working

Hello,
Does touch work to place the pieces? It seems to only work to zoom in and out but not to move and place the pieces?
Also, I have installed node 14.7.3 and am getting errors when building. Is that the only requirement to build?
Thanks

Currently, I am using Node.js version 14.17.5. I am not sure if that could be the source of your issue.
Regarding the placement of pieces, I don't quite understand what you are referring to. To move the pieces, you need to click on the list of countries and then click on the map in the correct location. In touch mode for mobile devices, it works similarly, but of course, the piece is not dragged since there is no mouse.

Thanks, any way to have the piece dragged by touch when touching it and panning the map when not touching the pieces?
I am getting this error now.
Its return type 'ReactNode' is not a valid JSX element.
49 |   return (
50 |     <React.Fragment>

51 |       <Modal
|        ^^^^^
52 |         show={showIn}
53 |         onHide={handleClose}
54 |         size="sm"

I appreciate your help!

The error message "Its return type 'ReactNode' is not a valid JSX element" typically means that the component is returning a type that React does not recognize as a valid JSX element. Specifically, ReactNode is a broad type that encompasses anything that can be rendered in React, but there is some mismatch causing React not to recognize it as a valid JSX element in this context.
Here’s a breakdown of what might be causing this issue and how you can troubleshoot it:

Check Imports: Ensure that all imports are correct. Specifically, React and React.Fragment should be properly imported.
import React from 'react';
import Modal from 'your-modal-component-path'; // Adjust based on where your Modal component is imported from

Ensure Props Are Correct: Verify that the props (showIn and handleClose) are correctly defined and used.

Validate the Return Type: Ensure that the component is returning valid JSX. Here’s a basic example:
import React from 'react';
import Modal from 'your-modal-component-path'; // Adjust based on where your Modal component is imported from

const MyComponent = ({ showIn, handleClose }) => {
  return (
    <React.Fragment>
      <Modal
        show={showIn}
        onHide={handleClose}
        size="sm"
      >
        {/* Modal content */}
      </Modal>
    </React.Fragment>
  );
};

export default MyComponent;

Check if Modal is a Valid Component: Ensure that Modal is a valid React component. If Modal is imported from an external library, make sure the import and usage are correct according to the library’s documentation.

Update Dependencies: Sometimes, such errors can be due to version incompatibilities. Ensure all your dependencies are up-to-date.

Look for Errors Elsewhere: Sometimes the issue is not exactly where the error message indicates. Review the entire component to ensure there are no other issues.

If you are not sure which component exactly is causing the problem, try isolating the issue by removing components or adding them back one at a time. Here’s how you can attempt to reproduce and identify the problem:

Isolate the Modal Component: Create a simple test case with only the Modal component to see if it works in isolation.
import React from 'react';
import Modal from 'your-modal-component-path'; // Adjust based on where your Modal component is imported from

const TestModal = () => {
  const [show, setShow] = React.useState(true);
  const handleClose = () => setShow(false);

  return (
    <React.Fragment>
      <Modal
        show={show}
        onHide={handleClose}
        size="sm"
      >
        Test Content
      </Modal>
    </React.Fragment>
  );
};

export default TestModal;

Check Parent Components: Ensure that the issue is not stemming from the parent components that render this Modal.

Log and Debug: Add console logs or use React DevTools to inspect the props and component tree to ensure everything is being passed and rendered as expected.

If after these steps you still encounter issues, providing more code or a more detailed context might help in pinpointing the exact problem.

It seems like you're experiencing an issue with touch functionality for placing pieces. Let me explain the current behavior and why implementing a different type of drag-and-drop might not be feasible with the current setup.
Currently, the functionality works as follows:
Selecting from the List: When you select a piece from the list, it gets anchored to the cursor.
Placing the Piece: The cursor then acts as the point where the piece is placed on the map.

In the current implementation, the pieces are not directly on the map. Instead, they are part of a layer that follows the cursor. This design means that the pieces are not interactable on the map itself but are always relative to the cursor’s position.
Changing this behavior to allow a different type of drag-and-drop would likely require significant changes to the core functionality, particularly in the CursorCore and AnimatedCursor functions. These functions are responsible for the cursor behavior and how pieces are attached to and moved with the cursor.
Given this setup, implementing touch functionality to drag and drop pieces directly on the map, as you might be requesting, isn't straightforward with the current design. The pieces are not elements on the map but are part of the cursor’s layer, making the requested behavior difficult to achieve without a major overhaul.
I hope this clarifies the situation. If you have any other questions or need further assistance, feel free to ask!


code-block table should be wrapped in a <div> tag

(Original issue 925 created by None on 2013-11-11T02:14:41.552192+00:00)
In the document of HtmlFormatter, there is an example output snippt when linenos option is set to "table". In this example, the <table> tag is wrapped in a <div> tag with "highlight" class.
But current implementation doesn't output the wrapper <div>. It generates a bare <table> tag with class "<cssclass>table".
Without the wrapping <div>, it's hard to styling the table. Say, you cannot easily limit the height of table and make a scroll bar when the number of lines is too large.
I hope that the wrapper <div> could be, at least, generated by some configuration.

(Original comment by calfzhou on 2013-11-11T03:16:23.401856+00:00)
Checked the history of html.py. In the earliest version, the <table> is wrapped by a <div>, but commit 6c43f98 removed the <div>.
Looking forward to get the <div> back.
You could give the wrapper <div> a width: 100%; overflow: auto; style, then the whole table could be scroll-able. At least, linenos can vertically scroll with code content. Without the div, I have no idea to limit the table's height and make the two columns scroll synchronously.

There is issues with width too, i.e. long lines stretch the table a lot and no scroll bars. I see that MediaWiki instead uses linenos=inline and then replaces those numbers with css pseudo elements to avoid being selected. In that way long lines are wrapped.

Not sure why this issue got auto-closed while the PR is still open ...


Remove base_run_inference in TFX-BSL and use inference.base in Beam

TFX-BSL has shared code for a base run_inference implementation.
This is duplicate code and TFX-BSL should be able to use Beams run_inference.

Imported from Jira BEAM-14268. Original Jira may contain additional context.
Reported by: Ryan.Thompson.
Subtask of issue #21435

@ryanthompson591 can this one be closed out now?

Yes, this should be closed. TFX-BSL recently released this change.

.close-issue


components(::ProductDomain) -> factors(::ProductDomain)?

I think using components for ProductDomain is a mistake, as it means something completely different. I propose calling it factors

The intended purpose of components was to create a generic interface for "composite" objects which is different from getindex, and which does not depend on the nature of the composition. That does not prevent objects from using additional names (as in factors(d::ProductDomain) = components(d) or the other way around), but using different names for different composite objects makes it less useful.

In other words, `components' does not mean anything specific to me, it is just a generic way to discover that an object somehow depends on other objects - regardless of what the relation is.

Using different names makes it more reliable and avoids bugs

But you'd have to come up with lots of names, one for each type of composite object, and remember them :-)
You can still implement factors for a ProductDomain, separately from having components. As long as you know you're working with a product domain, calling factors will catch cases where the domain is not like expected (if that's the type of bugs you're thinking of).
The main use case for components so far has been display. The fact that all composite objects implement components mean that I can display everything with the same generic code. Like this:
julia> using DomainSets: ×

julia> ((0..1)^2 ∪ (2..3) × (3..4.0)) × UnitDisk()
D × UnitDisk()

D = ((0.0..1.0) × (0.0..1.0)) ∪ ((2.0..3.0) × (3.0..4.0))

The only difference between a product domain and a union is × versus ∪.

I agree that it a good idea to define factors for product domains, even if it is functionally equivalent to components. How about:
nfactors(d::ProductDomain) = ncomponents(d)
factors(d::ProductDomain) = components(d)
factor(d::ProductDomain, I...) = component(d, I...)

closed by #93


clearApproval should not fire event

Because this function is called only from _burn and _transfer in which cases also Transfer is emitted, clearApproval should only set state to 0 (might be more gas efficient to do it conditionally).
According to spec (https://github.com/ethereum/EIPs/blob/master/EIPS/eip-721.md)
    ///  When a Transfer event emits, this also indicates that the approved
    ///  address for that NFT (if any) is reset to none.
    event Approval(address indexed _owner, address indexed _approved, uint256 indexed _tokenId);

OZ also does it incorrectly, but "slightly" better.
https://github.com/OpenZeppelin/openzeppelin-solidity/blob/07020e954475a4fdd36e0252e88717b60f790b71/contracts/token/ERC721/ERC721BasicToken.sol#L300-L303

Hm, yes, I think this is a valid reasoning based on the EIP comment. @fulldecent can you comment on this?

You are correct.
Here is a similar discussion for reference:
https://github.com/ethereum/EIPs/pull/841#pullrequestreview-129848814

Alright, to the PR ...

I can’t see the context here. Is there a PR?

@fulldecent the PR for this is in progress and will be ready by tomorrow. I will ask you to check that just to be sure it's aligned with the standard.

Yes, got it! clearApproval should not emit. We are currently emitting a superfluous event.

#101


netmask in vagrant file

Hi,
I think netmask needs to be set in vagrant file as some of the VMs not in the default subnet (<IP_ADDRESS>).
With the default settings, cd VM can't connect to serv-disc- VMs. Add subnet <IP_ADDRESS> fixes this for me.

Vagratfile, as it is now, works well in most combinations. I tested it on my laptops with OS X, Windows, and Ubuntu. That does not mean that it'll work with all hosts configs.
I'm glad that you managed to fix it and that it now works in your host.


Possible mixup in the recommendations

Hello there, based on my testing, unless I am missing something, there might be a mixup in the recommendations:
Either of these methods will work for the end-to-end scenario. We recommend that you use the first method in most cases. You should use the second method only if you are trying to:
Assign a group to multiple Azure AD or Azure resource roles and have users activate once to get access to multiple roles.

If for exemple you assign a group to two roles as eligible (method 2), with persistent members, the assignments show up independently of one another, with "Group" in the "Type" field. The assignee still has to activate either roles individually.
However, if you assign a group to two roles as permanent (method 1), with eligible members (PAG), the assignee activates his group membership and then actives all roles assigned to the group in one request.
Wouldn't that mean that method 1 is more advisable for this scenario? (Assign a group to multiple Azure AD or Azure resource roles and have users activate once to get access to multiple roles.)

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3f2bcbe3-6edd-c413-390b-ae70b8dc3bbb
Version Independent ID: 0b0b0feb-26a1-68cb-18dc-4f3fc7c96f3a
Content: What's the difference between Privileged Access groups and role-assignable groups - Azure AD
Content Source: articles/active-directory/privileged-identity-management/concept-privileged-access-versus-role-assignable.md
Service: active-directory
Sub-service: pim
GitHub Login: @curtand
Microsoft Alias: curtand

@matflol
Thanks for your feedback! I've assigned this issue to the author who will investigate and update as appropriate.

Hi @matflol
Thanks for your contribution! Yes, both are method 1. I updated the text to point that out correctly. I had accidentally switched them.
#please-close


Use std:: versions of isinf and isnan

For whatever reason, accessing the C versions of these functions doesn't work under GCC-5.4 on Ubuntu 16.04. This works for me and should be more portable, but YMMV if this is important.

Hi!
I've just compiled the program with the following compiler:
$ g++-5 --version
g++-5 (Ubuntu 5.4.1-2ubuntu1~14.04) 5.4.1 20160904
Copyright (C) 2015 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
Could you please:

Show your --version.
Try to use global namespace instead of std, i.e. replace std::isinf with ::inf. And remove cmath. Does this work for you?


Values are not fully hooked up

Only half of the values are connected and we need to complete the rest in order to capture the full value of the conversions from Legacy to Containerized to Cloud.
We need a bit more research to complete these pieces.

https://www.ericsson.com/en/blog/2020/3/autoscaling-value-state-detection-cognitive-cloud

Autoscaling - state detection can perform with 1/10th idle time vs value observation (typical)

https://www.logicworks.com/blog/2017/12/common-mistakes-misconceptions-auto-scaling-aws/

Autoscaling is typically for high-availability and redundancy, not elastic scaling
Cost - can autoscale with instance/cost falls below specified value - "nice to have" scaling!
Time/schedule based scaling, e.g. Mon-Fri 5 PM peak, scale accordingly, plus on demand

@DerekRoberts you brought up energy usage and I like that.  Let's go into that and see if you can tie in how green the energy sources are.

https://www2.gov.bc.ca/gov/content/industry/electricity-alternative-energy/energy-efficiency-conservation
BCGov Energy Targets - super vague

Adding to the Renewable Energy Research:
"In 2018, 37.9 percent of the electricity consumed across IBM's operations came from renewable sources."
https://www.ibm.com/ibm/environment/climate/renewable_energy.shtml


[BEAM-4519] Java SDK passes the staging session token artifact staging service.

The artifact staging service gRPC protocol was recently changed to allow
the staging service to serve multiple manifests.  This implements the
corresponding changes in the client code, as well as a few related
server-side cleanup tweaks.
Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

It will help us expedite review of your Pull Request if you tag someone (e.g. @username) to look at it.

R: @angoenka, @jkff, @bsidhom

LGTM thanks!


Samsung S21: Noisy AI Inference Results with App Animations in PlayService/GPU Mode

System information

Android Device information :
samsung/o1qzhx/o1q:12/SP1A.210812.016/G9910ZHU2CVG2:user/release-keys
TensorFlow Lite in Play Services SDK version :
'com.google.android.gms:play-services-tflite-support:16.0.1'
'com.google.android.gms:play-services-tflite-gpu:16.1.0'
Google Play Services version
23.16.13(190408-527363516)

I followed the tutorial from
https://www.tensorflow.org/lite/android/play_services#java_6.
Everything seemed fine on almost all devices. However, our test team recently attempted to test our app on the Samsung S21 and discovered that the AI inference results are noisy when there are animations on the app's GUI. This issue only occurs in the PlayService/GPU scenario. If I switch to standalone mode, everything works well. We also found that setting "android:hardwareAccelerated" to false in the AndroidManifest.xml can produce stable results, but it's obviously not a reasonable solution. Has anyone else experienced a similar issue? I would appreciate any advice or suggestions.

This issue originally reported by @JeremyJian  has been moved to this dedicated repository for LiteRT to enhance issue tracking and prioritization. To ensure continuity, we have created this new issue on your behalf.
We appreciate your understanding and look forward to your continued involvement.

Original Issue: https://github.com/tensorflow/tensorflow/issues/60704


Honor success and fail messages

This PR enable to customize success and fail messages provided through successMessageInput and failMessageInput hidden inputs.

Hi @brandonkelly @angrybrad
We have a project going live which should benefit from that enhancement. Do you think you will be able to give a feedback shortly or should we use our fork in the meantime?
Thank you for your help.

@juban just tagged 2.4.0 with this. did it separately because it required a bump in the craft/cms requirement to 3.5.0 and needed a changelog entry.
https://github.com/craftcms/guest-entries/blob/v2/CHANGELOG.md#240---2020-05-06

@angrybrad Perfect. Thank you.


Adding Carthage Support

What is in this PR:

Move the main base64 to Example project
Update podspec
Create workspace for carthage with shared scheme for carthage support

Needs to bump the version number and tag it in master branch

Thank you!

I should have checked this better before merging in, now we have duplicated files, two "Source" folders and no "Carthage" file present.


Would script about model "Magolor/deepex-ranking-model" be released?

Thank you for great work in zero-shot IE. Where can I find the related script about the pre-training about Magolor/deepex-ranking-model

As we've mentioned in our README，we will release this script later. Thanks very much for your interest!

@cgraywang @HaoyunHong @jesseLiu2000 When will this model be released?

Sorry this has indeed been released on https://huggingface.co/Magolor/deepex-ranking-model/tree/main. The path Magolor/deepex-ranking-model refers to the HuggingFace repo rather than a local directory.


Building the u2f file

Hi,
I was wondering if there is a guide on how to build the u2f file for the non-W version of this. The whole thing is very nice, and it would be great to track my changes in a GitHub and deploy the firmware instead of tinkering with the interpreter :)  Would save me from accidentally overwriting things on the device without saving them locally.

This thread over on the main pimoroni-pico repo might help?
https://github.com/pimoroni/pimoroni-pico/issues/770


package.json: Update author URL

Change author URL to new link
Closes https://github.com/SuriyaaKudoIsc/animate-a-name/issues/8

I see someone else has made a similar PR, and before I did. I will close this if necessary.

Duplicate of #10

@supergr35 I'm going to close this PR. Can you solve this issue please: #7?


[EUWE] Update dependancies

We should look at updating the dependancies for the EUWE branch.
See: https://www.bithound.io/github/ManageIQ/manageiq-ui-service/euwe

let's just skip this.  we might be opening a pandoras box by doing this.


Add permission node for job helppages

Description of new idea or improvement on existing one
Currently entering /jobs will give users a 6 Page overview of every command the plugin supports.
I would request moving these helppages to the command /jobs help and adding the permission node jobs.command.help.
This way you can negate the permission and there wouldn't be an easy way to find bugs or glitches to abuse through commands.
I imagine the following commands to look like this:
/jobs
[Jobs] Subcommand required.
/jobs help
-------- ==== Jobs ==== -------
All 6 pages of those juicy commands
------- << Prev 1/6 Next >> -------

help page is filled with commands you have access too. So regular player will only get ~3 pages of those by default while OP gets all 6. Its just convenience for players to know what they can actually use. There is no real need currently to separate any of those as its already separate by your personal access to those commands.


pull request for e2e test at 12/05/2016 20:26:02

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Issue with basic policy allowing ingress traffic from nginx nodes in another namespace.

Expected Behavior
Pods in webserver namespace allow traffic in from nginx-ingress namespace
Current Behavior
The policy works if I just open the ingress port. However, if I restrict the policy to only accept traffic from certain namespace or pods within that namespace, I receive a 504 error when making the request.
Steps to Reproduce (for bugs)
nginx-ingress namespace has label service=nginx-ingress
webserver pods are in webservers namespace with labels:
app.kubernetes.io/instance=test
app.kubernetes.io/name=webserver
If I apply this policy it does not work:
netpol.txt
If I apply this policy it works fine.
netpol-work.txt
Your Environment
Azure AKS - basic install.

Calico version 3.8
Orchestrator version (e.g. kubernetes, mesos, rkt): 1.16.13
Operating System and version: Ubuntu 16.04

I couldn't find anything that said I had to do something specific to configure Calico - basically a base configuration was applied by AKS when you create the instance.

Hi @JRolfe-Gen, I think the issue here is that the value of your namespaceSelector uses matchLabels which I do not think we currently have support for. Can you try namespaceSelector: service == 'nginx-ingress' instead and see if that works?


resign for adhoc deployment include beta-reports-active when it shouldn't

It looks like code changes for #94 leave beta-reports-active entitlement in adhoc deployments which is not allowed.
Aug 21 01:18:29 chrish-iPhone installd[4241] <Error>: entitlement 'beta-reports-active' has value not permitted by provisioning profile 'Test Bible AdHoc'
Aug 21 01:18:29 chrish-iPhone installd[4241] <Error>: entitlement 'beta-reports-active' has value not permitted by provisioning profile 'XC Ad Hoc: *'
Aug 21 01:18:29 chrish-iPhone installd[4241] <Error>: 0x603000 -[MICodeSigningVerifier performValidationWithError:]: 188: Failed to verify code signature of <MIExecutableBundle : path = /private/var/mobile/Library/Caches/com.apple.mobile.installd.staging/temp.hVcgQk/extracted/Payload/ScriptureApp.app identifier = org.kalaam.test.ScriptureApp type = User App> : 0xe8008016 (Entitlements found that are not permitted by provisioning profile)
Aug 21 01:18:29 chrish-iPhone installd[4241] <Error>: 0x603000 -[MIInstaller performInstallationWithError:]: Verification stage failed

https://github.com/KrauseFx/sigh/blob/master/lib/sigh/resign.rb#L29
Changes for always passing -r yes to resign.sh causes an issue for AdHoc signing.  I have a fix for this and #158.  It is in resign.sh.  Should I do a PR for your repo or the upstream?


Add lunar_strategy_dsa Repository

Please pull this awesome Repository in!

As this is not a project GitHub repo, but that of an individual, we cannot add this to casperecosystem.io. Therefore closing this PR without actioning it.


Sometimes filter disappear when combining filters

Describe the bug
Sometimes filter disappear when combining more than two filters.
To Reproduce
Steps to reproduce the behavior:

Go to demo dashboard
Click on some dimension on sankey chart on top-left.
Click on some value on 'Sales' filter. (eg. set maximum value to 5,000)
Select another filter like 'Profit' and set value. (eg. set maximum value to 3,000)
See error - Sankey chart disappeared like screenshot below.

Expected behavior
Sankey chart never disappear whenever another filter is set.
Screenshots

Normal status

Sankey chart disapeared after two filters are set
Desktop (please complete the following information):

OS: macOS Mojave (10.14)
Browser: Chrome (69.0.3497.100)

@eltriny 데이터가 있는데도 표시가 안되네요. 확인 부탁드립니다.

fixed in #945


Avoid panic on type assert.

Fixes #22766
Be clearer about type assertion to avoid a runtime panic in the off chance a MergeAccumulators isn't followed by a PCollection.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

R: @jeffreyoldham

Thanks.


run-command Crashing; Clue? None ASCII Characters injected into output

Okay, this one has been head scratcher for some time. This CI started failing some time ago and initially I thought that I had messed up the paths of the test files. However, I spent a considerable amount of time running the same matlab commands locally as well as pouring over the locations of test files in the CI.
I'm yet to be able to track things down, but I do sometimes notice non-ASCII characters appearing in the output of the runner:
  No such file or directory:
  /home/runner/work/PET2BIDS/PET2BIDS/ecat_validation/synthetic_ecat_integer_16x16x16x4.v.gz
  failed to convert:Invalid file identifier. Use fopen to generate a valid file
  identifier.Ø failed to convert:$ failed to convert:A

I'm not sure if it's related, but I'm hoping that there's some strange locality or other setting that is messing up my paths within my runner.
Willing to try and submit a PR or keep hacking away on my end to try and diagnosis this if you're able to view/review.
Thanks

@bendhouseart This doesn't look like an error that would be related to matlab-actions/run-command in particular. You might consider trying to print out more information about the state of the file or directory when this issue occurs to further debug.
Side note: You might also consider upgrading to V2 of setup-matlab and run-command. V1 was deprecated.


Crash in yr_object_set_integer

Hello！I have find crash in yr_object_set_integer, there is stack trace:

it’s not safe to use assert, call _yr_object_lookup with OBJECT_CREATE possible return nullptr, when yr_malloc failed in yr_object_structure_set_member. Stack trace:

You are right, the assert can trigger in a low memory condition. Is that what you mean?

@plusvic Whether you should consider returning ERROR_INSUFFICIENT_MEMORY to replace assert, because the probability of encountering insufficient memory when scanning a large number of samples is high and assert will cause the process to coredump

@plusvic GoodJob！Thx~


Remove 'Rk' from components

What do you think about removing "Rk" from components for simplicity like react-native base components?
NativeBase, React Native Elements use this approach
<RkText rkType="hero"></RkText>
<Text type="hero"></Text>

Hello @periabyte actually there is a reason to use Rk prefix. Sometimes u may need both RkText and Text component and in order to avoid this ambiguity, we define those prefixes.
But in case you want to use Text component - you can wrap our RkText in your own Text component and use it.

@periabyte you can also alias imports:
import { RkText as Text } from 'react-native-ui-kitten'

It might be nice to at some point have react-native-ui-kitten/unprefixed for applications that are pervasively ui-kitten based eventually, but that seems like more trouble than it's worth atm


feature/1-add-xml-parsing-and-parameter-replacement

sierra should be able to:

Parse a .argos input file
Given a path like "params.occupancy_grid.pheromone.rho" (maybe
something a little different dependeng what xml python parsing
looks like), it should be able to replace any value in the .argos
file with any other value.

OBE. London already did this.


Jekyll Template with side navigation

The default template for github pages is overly simple, and focused on blog content.
As we have more content, such as the "What is SCITT", the libraries and the content from https://github.com/ietf-scitt/use-cases/blob/main/scitt-components.md, we'll need a more robust navigation model.
Does someone want to help with a basic left hand navigation? I'm assuming we'd need to update some file that provides the links, and not just auto-magical.
Definitely open to better design options.
The ones I'm most familiar with are:

oras
helm
Notary

@SteveLasker any screenshots of the kind of sidebar UI you are hoping for? I can take a stab at this.

Thanks, @OR13
What do you think about https://oras.land ?

Top and side navigation, where we must add the links to a file, and there's no magical TOC entries with even more mysterious ordering...

@SteveLasker I did some experiments with storing meta data directly next to containers, a while back:
https://github.com/transmute-industries/public-credential-registry-template/blob/main/docs/public-container-registry.md

Resolved with #21, thank you @OR13 for all the help


Fix typehints, cleanup unused imports and docstrings

Fixes: #13

once you merge this one, check out and merge #15.


DOC: sudo required in ARM wheel builds

May be related to manylinux image now being based on Alpine.

@tbirdso FYI, this is now required. However, I run into Eigen build errors.
Could you please take a look at rebasing https://github.com/InsightSoftwareConsortium/ITK/pull/3471 , get it green, so we can keep it green and not run into this?

Yes, will take a look


New File Extension

I would like to enable syntax highlighting for a non-standard filetype.
Something along these lines -
au! BufRead,BufNewFile *.ci set filetype=ci
Where would I include this?

Please see:
https://github.com/amix/vimrc#how-to-include-your-own-stuff


add documentation & tests

Add documentation and tests for spartan/polynomial.rs.

EqPolynomial: multilinear extension polynomial of $eq$
MultilinearPolynomial: multilinear polynomial
SparsePolynomial: sparse representation of multilinear polynomial

Remove duplicate get_bits in SparsePolynomial::evaluate.

The main branch in PSE fork is currently following upstream. A lot of these things would be useful in our hypernova (WIP) branch though so could also target this if you want :) https://github.com/privacy-scaling-explorations/Nova/tree/hypernova

Thank you! I have read the two papers ccs and hypernova, which are very revolutionary works. I'm learning by reading code, and even though I haven't understood many of them, I am very willing to contribute code to the hypernova branch.

@CPerezz this should've been merged to hypernova branch

Ohh damn!!! Let me rebase on here and also move the commit to the other branch!

Fixed this up here https://github.com/privacy-scaling-explorations/Nova/pull/15
@wangtsiao WDYT about pushing this PR to upstream too? https://github.com/microsoft/Nova/pulls


createrawtransaction missing 'data' support

I've started this page for instructing users how to send custom beacons on the Gridcoin blockchain: https://grcnode.co.uk/beacon.html
Forum thread: https://cryptocointalk.com/topic/44611-monitoring-selfburn-addresses-for-custom-beacons/?p=208479
The issue lies in "Step 2: Create the raw transaction." - the following command is accepted by the client, but the output transaction does not include OP_Return/hex encoded data:
gridcoinresearchd createrawtransaction [{"txid":txid,"vout":n,"data":"<Hex encoded data>"},...] {address:amount,...}
The createrawtransaction command is documented as:
gridcoinresearchd createrawtransaction [{"txid":txid,"vout":n},...] {"data":"<Hex encoded data>", address:amount,...}
But the above does not work, it returns an error stating that the hex encoded data isn't a valid address.
Looks like the createrawtransaction command requires 'data' support:
https://github.com/bitcoin/bitcoin/commit/627468d2ea1f4d5dea9561fe77aaf53f3a83b4d2
https://github.com/bitcoin/bitcoin/commit/d7078533ebd32bb5071f4dba8e3d9c5a3b1f0d4c
https://github.com/bitcoin/bitcoin/pull/3128
https://github.com/bitcoin/bitcoin/commit/005609539b2184a474ffe9ebfe883984c900a3fb
With the data support, we can easily add OP_Return hex encoded data to transactions & extend the project rain feature to any external cryptocurrency system (side chains).
Edit: Peercoin inherited the following relevant commits:
https://github.com/ppcoin/ppcoin/commit/1df628cb2789067da32d37926aceadaad76aeb03
https://github.com/ppcoin/ppcoin/commit/ac8be966243525c21ffd071dc23bcab01f4c33d4

Unable to create an op_return transaction without data support in createrawtransaction.

Looking into this now.

After the next release when you test this take a look at script.cpp line 1511.  Ppcoin returns a 1 for nulldata while bitcoin returns a -1.  I coded this as a -1.  The only other questionable issue is sending rawdata to an invalid address (bitcoin appears to support this).  I merged that feature in; so that will also need tested.

gridcoinresearchd createrawtransaction '[{"txid":"bfc7ab3793680ef73e45b2c0ed1b8091eeb21f89ae7bc7f7cf3262cc90214c29","vout":0}]' '{"S2YKdCFvTAWKLgwsFQCJDSMNPbw1a5HJB4":0.2, "data":"00010203"}'
error: {"code":-8,"message":"Data must be hexadecimal string (not '')"}

Oh great :)

I was able to get the command working but had to make a code change.  Im still not sure if the entire process will work, but hopefully this will be a step in the right direction.
Go ahead and grab <IP_ADDRESS>-leisure and you should be able to issue the command now.

Excellent, it works!
gridcoinresearchd createrawtransaction '[{"txid":"fff30a59f89acc91a1d8e21f075d1b571d812336a71b086cd92b461c6214b845","vout":1}]' '{"data":"4752432d5241494e3a20414c5445524e415449564520414444524553532f4143434f554e54"}'

01000000d4d61b570145b814621c462bd96c081ba73623811d571b5d071fe2d8a191cc9af8590af3ff0100000000ffffffff010000000000000000276a254752432d5241494e3a20414c5445524e415449564520414444524553532f4143434f554e540000000000

gridcoinresearchd signrawtransaction 01000000d4d61b570145b814621c462bd96c081ba73623811d571b5d071fe2d8a191cc9af8590af3ff0100000000ffffffff010000000000000000276a254752432d5241494e3a20414c5445524e415449564520414444524553532f4143434f554e540000000000
{
    "hex" : "01000000d4d61b570145b814621c462bd96c081ba73623811d571b5d071fe2d8a191cc9af8590af3ff0100000048473044022037485bbc12d59fa5dca3943e6f9961898ff3719dcc27d705334d6d5b42e0186d0220616f2300187fa8cd32575cf0eb0616e69e3eb76c5fdb374a4f191b7be6dd138c01ffffffff010000000000000000276a254752432d5241494e3a20414c5445524e415449564520414444524553532f4143434f554e540000000000",
    "complete" : true
}

gridcoinresearchd sendrawtransaction 01000000d4d61b570145b814621c462bd96c081ba73623811d571b5d071fe2d8a191cc9af8590af3ff0100000048473044022037485bbc12d59fa5dca3943e6f9961898ff3719dcc27d705334d6d5b42e0186d0220616f2300187fa8cd32575cf0eb0616e69e3eb76c5fdb374a4f191b7be6dd138c01ffffffff010000000000000000276a254752432d5241494e3a20414c5445524e415449564520414444524553532f4143434f554e540000000000
31709dd630170aeec6b88db2475cbad2845c714b926f080468f455ecdad142cd

gridcoinresearchd gettransaction 31709dd630170aeec6b88db2475cbad2845c714b926f080468f455ecdad142cd
{
    "txid" : "31709dd630170aeec6b88db2475cbad2845c714b926f080468f455ecdad142cd",
    "version" : 1,
    "time" :<PHONE_NUMBER>,
    "locktime" : 0,
    "hashboinc" : "",
    "vin" : [
        {
            "txid" : "fff30a59f89acc91a1d8e21f075d1b571d812336a71b086cd92b461c6214b845",
            "vout" : 1,
            "scriptSig" : {
                "asm" : "3044022037485bbc12d59fa5dca3943e6f9961898ff3719dcc27d705334d6d5b42e0186d0220616f2300187fa8cd32575cf0eb0616e69e3eb76c5fdb374a4f191b7be6dd138c01",
                "hex" : "473044022037485bbc12d59fa5dca3943e6f9961898ff3719dcc27d705334d6d5b42e0186d0220616f2300187fa8cd32575cf0eb0616e69e3eb76c5fdb374a4f191b7be6dd138c01"
            },
            "sequence" :<PHONE_NUMBER>
        }
    ],
    "vout" : [
        {
            "value" : 0.00000000,
            "n" : 0,
            "scriptPubKey" : {
                "asm" : "OP_RETURN 4752432d5241494e3a20414c5445524e415449564520414444524553532f4143434f554e54",
                "type" : "nulldata"
            }
        }
    ],
    "amount" : 0.00000000,
    "fee" : -73.60565618,
    "confirmations" : 6,
    "blockhash" : "a9bffd8d497ed9fa93e52859a246d9e1921caeb953bc36a8fcb5c6e6cf86c885",
    "blockindex" : 2,
    "blocktime" :<PHONE_NUMBER>,
    "txid" : "31709dd630170aeec6b88db2475cbad2845c714b926f080468f455ecdad142cd",
    "time" :<PHONE_NUMBER>,
    "timereceived" :<PHONE_NUMBER>,
    "details" : [
        {
            "account" : "",
            "address?" : "1Wh4bh",
            "category" : "send",
            "amount" : 0.00000000,
            "fee" : -73.60565618
        }
    ]
}


MRR calculation

Hi @apoorvumang!
In issue #8 you mentioned that to calculate the metrics reported in the paper you used code from eval_accelerate.py. For me, it is still not clear how you calculated MRR because all the functions in eval_accelerate.py seems to be related to Hits@k metrics. Nevertheless, you reported MRR values for both Wikidata5M and Wikidata90M. Can you please elaborate on how one can evaluate the model in terms of the MRR metric? From what I found in evaluate.py it seems not feasible to run model inference #of entities (5M) * len(test dataset) times.
Thank you for your support.

Hi, thanks for your interest.
As mentioned in #8, please try the following:

Switch to branch apoorv-dump instead of main. This contains the latest code but is not cleaned, hence the large number of files.
In this branch, use eval_accelerate.py to evaluate (use sample size > 200). This saves all the generated predictions and scores to a scores file.
Use notebook filtered_eval_from_scores.ipynb which uses these saved scores to evaluate MRR etc. I would suggest you go through the notebook to see the exact way these are calculated (if you see any issues please do contact me)

The notebook contains the logic for MRR calculation from raw scores. Predictions are sorted by score, then 'seen' entities are removed from the prediction list (filtering), and then the rank of the correct entity is used to calculate MRR.

In this branch, use eval_accelerate.py to evaluate (use sample size > 200). This saves all the generated predictions and scores to a scores file.

@apoorvumang, I am sorry, did you mean beam_size or num_predictions instead of sample size? I didn't manage to find such parameter in your code and would like to make sure I understood you correctly. Also, what were other parameters equal to in your settings (like length_penalty, max_output_length, length_normalization, and of course # predictions and beam size)?

I meant num_predictions=200 with beam_size=1 . Rest were all left default

hi, @apoorvumang
As you said, I set (num_reduction) to 10 in (eval_accelerate. py), which has caused my CUDA memory to exceed (30G). How do I set 200?
Thank you for your support！


Take over mode

This PR allows volar to start in ts files.
"volar.takeOverMode.enabled": {
  "type": ["boolean", "string"],
  "enum": ["auto", true, false ],
  "enumDescriptions": [
    "Auto enable take over mode when built-in TS extension disabled.",
    "Alway enable take over mode.",
    "Never enable take over mode."
  ],
  "default": "auto",
  "description": "Take over language support for *.ts."
},

But there is one problem.
This doesn't works :)

Note: it is a client problem, everything is ok on the server

One problem I face is that I try to do the checks in on_client_configuration_ready,
so even if I have for example "volar.takeOverMode.enabled": "auto" and I have LSP-typescript installed,
And I know I removed the typescript languguage object:
		{
			"languageId": "typescript",
			// ST3
			"scopes": ["source.ts"],
			"syntaxes": ["Packages/TypeScript Syntax/TypeScript.tmLanguage"],
			// ST4
			"document_selector": "source.ts",
			"feature_selector": "source.ts",
		},

in this line here:
and the configuration object at the end of on_client_configuration_ready looks like this:
configuration {'initializationOptions': {'languageFeatures': {'codeAction': True, 'documentLink': False, 'typeDefinition': True, 'documentHighlight': True, 'hover': True, 'semanticTokens': False, 'diagnostics': True, 'signatureHelp': True, 'renameFileRefactoring': False, 'codeLens': False, 'schemaRequestService': False, 'callHierarchy': False, 'definition': True, 'references': True, 'completion': {'getDocumentNameCasesRequest': False, 'defaultTagNameCase': 'both', 'defaultAttrNameCase': 'kebab', 'getDocumentSelectionRequest': False}, 'rename': True}, 'typescript': {}, 'documentFeatures': {'selectionRange': True, 'documentFormatting': {'defaultPrintWidth': 90}, 'linkedEditingRange': False, 'documentColor': True, 'foldingRange': True, 'documentSymbol': True}}, 'env': {}, 'command': ['${node_bin}', '${server_path}', '--stdio'], 'ignore_server_trigger_chars': False, 'settings': {'volar.takeOverMode.enabled': True}, 'experimental_capabilities': {}, 'auto_complete_selector': '', 'languages': [{'languageId': 'vue', 'document_selector': 'text.html.vue | source.ts', 'feature_selector': 'text.html.vue | source.ts'}], 'enabled': True}

LSP-volar is still started in *.ts files, even though I expect it not to...
One way to solve the problem is to move these check to is_allowed_to_start...
but the configuration object there is not as simple as the one in on_client_configuration_ready, it looks like this:
configuration ClientConfig(tcp_port=None, init_options=DottedDict({'documentFeatures': {'linkedEditingRange': False, 'documentColor': True, 'selectionRange': True, 'documentSymbol': True, 'documentFormatting': {'defaultPrintWidth': 90}, 'foldingRange': True}, 'languageFeatures': {'references': True, 'codeLens': False, 'diagnostics': True, 'rename': True, 'documentHighlight': True, 'definition': True, 'signatureHelp': True, 'schemaRequestService': False, 'hover': True, 'documentLink': False, 'typeDefinition': True, 'completion': {'defaultTagNameCase': 'both', 'getDocumentNameCasesRequest': False, 'getDocumentSelectionRequest': False, 'defaultAttrNameCase': 'kebab'}, 'renameFileRefactoring': False, 'semanticTokens': False, 'codeAction': True, 'callHierarchy': False}, 'typescript': {'serverPath': '/Users/codetribe/Library/Caches/Sublime Text/Package Storage/LSP-volar/14.17.6/server/node_modules/typescript/lib/tsserverlibrary.js'}}), command=['${node_bin}', '${server_path}', '--stdio'], name='LSP-volar', experimental_capabilities={}, file_watcher={}, priority_selector='(text.html.vue | source.ts)', status_key='lsp_LSP-volar', auto_complete_selector='', settings=DottedDict({'volar': {'preferredAttrNameCase': 'auto-kebab', 'codeLens': {'scriptSetupTools': False, 'references': True, 'pugTools': False}, 'takeOverMode': {'enabled': True}, 'preferredTagNameCase': 'auto', 'autoCompleteRefs': True, 'completion': {'autoImportComponent': True}}}), path_maps=None, disabled_capabilities=DottedDict({}), schemes=['file'], env={}, selector='(text.html.vue | source.ts)', enabled=True)

So I am not sure, what would be the best way to tell the server to not start in ts files.
Any ideas?

@rchl if you have time could you take a look at his?

Found out the issue, I accidentally have overridden my configuration in LSP-volar.sublime-settings file.

One way to solve the problem is to move these check to is_allowed_to_start...
but the configuration object there is not as simple as the one in on_client_configuration_ready, it looks like this:

Why specifically is a problem with that?

I cannot guarantee that I will read the correct project data in cases where the user start ST and there are multiple windows.
I will try to push the changes and record a video just so you get the point.

I cannot guarantee that I will read the correct project data in cases where the user start ST and there are multiple windows. I will try to push the changes and record a video just so you get the point.

is_allowed_to_start at least gives you a project window to check. Why is is_allowed_to_start problematic?

Why is is_allowed_to_start problematic?

While there is a way to override the languages, this doesn't work:
 @classmethod
    def is_allowed_to_start(..., configuration):
        if not workspace_folders or not configuration:
            return
        # ...
        languages = filter_out_languages()
        configuration = configuration.from_config(configuration, {
            "languages": languages
        })

I am overthinking this functionality.
I think that this feature should be just enabled for project folders!
I can then remove the on_client_configuration_ready  code,
I can then remove the volar.takeOverMode.enabled.
This is all the user needs:
{
	"folders":
	[
		{
			"path": "."
		}
	],
	"settings": {
		"LSP": {
			"LSP-volar": {
				"selector": "source.vue | source.ts | source.tsx | source.js | source.jsx"
			},
			"LSP-typescript": {
				"enabled": false
			}
		}
	}
}

What do you think?

If you have a different approach, feel free to suggest,
I just concluded that I didn't want to write any code for this to work :)

While there is a way to override the languages, this doesn't work:

It would have to be more something like config.selector = 'blabla'. At least for ST4.

Thanks for the review!


Add country restriction option

This pull request adds new option countryRestriction to restrict location lookup to defined countries.
Example: countryRestriction: 'us,ch' (Restrict adress lookup to United States of America and Switzerland)

Merged into upstream.


Update for 4.19

Is there any plan to update this packager for 4.19? Is it just changing the version select to accommodate for 4.19?
Jakeday's kernel now supports 4.19.

Done. Check the releases section, or run the commands to build the kernel on your machine.


Gulp clean

R: @jeffposnick @addyosmani @gauntface
The tests for appcache behaviour project has some fairly gnarly dependencies on previous tests that I haven't touched in this PR but should be addressed at some point.
Fixes #50 #51

This should be working on the next travis build (Previous issue was passing tests, but selenium-assistant and gulp did not play well).

@jeffposnick @addyosmani

👍


Fix issue with merge conflicts when data was not present

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

Snapshot stored with reference name:
refs/pull/14283/merge
Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14283/merge/index.html
To test a playground add it to the URL, for example:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14283/merge/index.html#WGZLGJ#4600
Links to test babylon tools with this snapshot:
https://playground.babylonjs.com/?snapshot=refs/pull/14283/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/14283/merge
https://gui.babylonjs.com/?snapshot=refs/pull/14283/merge
https://nme.babylonjs.com/?snapshot=refs/pull/14283/merge
To test the snapshot in the playground with a playground ID add it after the snapshot query string:
https://playground.babylonjs.com/?snapshot=refs/pull/14283/merge#BCU1XR#0


Global actor method from protocol doesn’t inherit to the implementation

Description
The inherited MainActor implementation doesn't run on the main thread.
Mac and Linux have got different results.
on Mac:
title: Task.detached, isMainThread: true
title: Task, isMainThread: false

on Linux:
title: Task.detached, isMainThread: false
title: Task, isMainThread: false

Reproduction
main.swift
Example 1:
protocol Pro1 {
    func foo(title: String) async
}

protocol Pro2: Pro1 {
    @MainActor
    func foo(title: String)
}

struct ST: Pro2 {
    func foo(title: String) {
        print("title: \(title), isMainThread: \(Thread.isMainThread)")
    }
}

let s = ST()

if #available(macOS 10.15, *) {
    Task.detached { // on mac, it is true. on linux, it is false.
        await s.foo(title: "Task.detached")
    }

    Task {
        await s.foo(title: "Task")
    }
}

dispatchMain()

Example 2:
@main
struct Entrance {
    static func main() async throws {
        print("is on main thread: \(Thread.isMainThread)")
        let s = ST()

        if #available(macOS 10.15, *) {
            print("entering tasks.")

            s.foo(title: "default")

            Task.detached {
                await s.foo(title: "Task.detached")

            }

            Task {
                s.foo(title: "Task")
            }
        }
        while true {}
    }
}

$ swift run

Expected behavior
I believe It should run on main thread.
Environment
swift-driver version: 1.87.1 Apple Swift version 5.9 (swiftlang-<IP_ADDRESS>.108 clang-15<IP_ADDRESS>)
Target: arm64-apple-macosx13.0
Swift version 5.9.1 (swift-5.9.1-RELEASE)
Target: aarch64-unknown-linux-gnu
Additional information
No response

A detached task makes absolutely no guarantees about where it will run, and it definitely is not inheriting execution context.
Dispatch on macOS may decide to reuse a thread because it is not busy rather than spin up a new thread to service the task -- which is I think that you're observing here I think?


Remove AllowSetExpandedTypes temporary feature flag

This code was meant to be temporary and should be removed.
        /// <summary>
        /// This is specific for Cards team and it is a temporary feature.
        /// It will be soon deleted.
        /// </summary>
        [Obsolete]
        internal static Features PowerFxV1AllowSetExpandedTypes
        {
            get
            {
                var ret = PowerFxV1;

                ret.SkipExpandableSetSemantics = true;

                return ret;
            }
        }

Just for reference, this was originally included in https://github.com/microsoft/Power-Fx/pull/1765.


Could you please implement --tile option in code?

With RTX 3060 I am unable to denoise images >4Mpx...For very low resolutions, results are impressive.
Thank you

Try this
https://github.com/cszn/SCUNet/blob/3d5c19e93ab5723b28a839fe57ee274dd6ae6daa/main_test_scunet_real_application.py#L99

I uncommented # in this line you mentioned, but same Cuda out of memory error. Exactly in same MB as before uncommenting. Tried also smaller number like refield=8, min_size=128, same error and same Mb out of... please suggest me what to do ...
Thanks

Same problem here. Any updates?

OK. I read the code and have understood it. You should uncomment this line as well as comment the next line. @zelenooki87


Node.js  Loaders Team Meeting 2024-11-19

Time
UTC Tue 19-Nov-2024 19:00 (07:00 PM):

Timezone
Date/Time

US / Pacific
Tue 19-Nov-2024 11:00 (11:00 AM)

US / Mountain
Tue 19-Nov-2024 12:00 (12:00 PM)

US / Central
Tue 19-Nov-2024 13:00 (01:00 PM)

US / Eastern
Tue 19-Nov-2024 14:00 (02:00 PM)

EU / Western
Tue 19-Nov-2024 19:00 (07:00 PM)

EU / Central
Tue 19-Nov-2024 20:00 (08:00 PM)

EU / Eastern
Tue 19-Nov-2024 21:00 (09:00 PM)

Moscow
Tue 19-Nov-2024 22:00 (10:00 PM)

Chennai
Wed 20-Nov-2024 00:30 (12:30 AM)

Hangzhou
Wed 20-Nov-2024 03:00 (03:00 AM)

Tokyo
Wed 20-Nov-2024 04:00 (04:00 AM)

Sydney
Wed 20-Nov-2024 06:00 (06:00 AM)

Or in your local time:

https://www.timeanddate.com/worldclock/fixedtime.html?msg=Node.js+Foundation+Loaders Team+Meeting+2024-11-19&iso=20241119T1900
or https://www.wolframalpha.com/input/?i=07PM+UTC%2C+Nov+19%2C+2024+in+local+time

Links

Minutes Google Doc: https://docs.google.com/document/d/1YmF3w-1MBsYa1LdzN3_wiF-3D28aVcP-sDvDTJ2X_gs/edit

Agenda
Extracted from loaders-agenda labelled issues and pull requests from the nodejs org prior to the meeting.
nodejs/node

ESM Hook deadlocks since 21.2.0 a3e09b3 #50948

nodejs/loaders

Proposal: Moving hooks on thread #205

nodejs/package-examples

Bootstrapping the initiative: TODOs? #2

Invited

Loaders team: @nodejs/loaders

Observers/Guests
Notes
The agenda comes from issues labelled with loaders-agenda across all of the repositories in the nodejs org. Please label any additional issues that should be on the agenda before the meeting starts.
Joining the meeting

link for participants: https://zoom.us/j/97506450082

For those who just want to watch: https://www.youtube.com/c/nodejs+foundation/live

I'll be on an aeroplane during this time


task._end.format('MMM D') does not work

https://frappe.io/gantt
Custom HTML in popup
const end_date = task._end.format('MMM D');
task._end is a Date object, it does not have the format method

@lambdaq you can use task.end and format with new Date() ;)

Changing the line to
const end_date = moment(task._end).format('MMM D');
will fix the error

In fact, you could use date_utils inside the library... but yeah, moment makes more sense.


Turkish readme Translation

Hi. I translated the readme file to Turkish language.  I don't know if there's anything else to do. Yoroshiku.