Unable to install mxnet in R 3.5.0

Note: Providing complete information in the most concise form is the best way to get help. This issue template serves as the checklist for essential information to most of the technical issues and bug reports. For non-technical issues and feature requests, feel free to present the information in what you believe is the best form.
For Q & A and discussion, please start a discussion thread at https://discuss.mxnet.io
Description
Installation error on RStudio R 3.5.0
Error:   unable to access index for repository https://apache-mxnet.s3-accelerate.dualstack.amazonaws.com/R/CRAN/GPU/bin/windows/contrib/3.5:
cannot open URL 'https://apache-mxnet.s3-accelerate.dualstack.amazonaws.com/R/CRAN/GPU/bin/windows/contrib/3.5/PACKAGES'
Command Run:
cran <- getOption("repos")
cran["dmlc"] <- "https://apache-mxnet.s3-accelerate.dualstack.amazonaws.com/R/CRAN/"
options(repos = cran)
install.packages("mxnet")
(Brief description of the problem in no more than 2 sentences.)
Environment info (Required)
R version 3.5.0 (2018-04-23) -- "Joy in Playing"
Copyright (C) 2018 The R Foundation for Statistical Computing
Platform: x86_64-w64-mingw32/x64 (64-bit)
Package used (Python/R/Scala/Julia):
(I'm using R 3.5.0)
For R user, please provide R sessionInfo():
SessionInfo():

sessionInfo()
R version 3.5.0 (2018-04-23)
Platform: x86_64-w64-mingw32/x64 (64-bit)
Running under: Windows 7 x64 (build 7601) Service Pack 1

Matrix products: default
locale:
[1] LC_COLLATE=English_United States.1252  LC_CTYPE=English_United States.1252
[3] LC_MONETARY=English_United States.1252 LC_NUMERIC=C
[5] LC_TIME=English_United States.1252
attached base packages:
[1] stats     graphics  grDevices utils     datasets  methods   base
loaded via a namespace (and not attached):
[1] compiler_3.5.0 tools_3.5.0
Build info (Required if built from source)
Compiler (gcc/clang/mingw/visual studio):
MXNet commit hash:
(Paste the output of git rev-parse HEAD here.)
Build config:
(Paste the content of config.mk, or the build command.)
Error Message:
(Paste the complete error message, including stack trace.)
no package 'knitr' was found

install.packages('mxnet')
Installing package into ‘\homedrive$/Shreyans.Bathiyan/R/win-library/3.5’
(as ‘lib’ is unspecified)
Warning in install.packages :
package ‘mxnet’ is not available (for R version 3.5.0)
Error: invalid version specification ‘NA’
In addition: Warning message:
In utils:::packageDescription(packageName, fields = "Version") :
no package 'knitr' was found
cran <- getOption("repos")
cran["dmlc"] <- "https://apache-mxnet.s3-accelerate.dualstack.amazonaws.com/R/CRAN/GPU"
options(repos = cran)
install.packages("mxnet")
Error in install.packages : Updating loaded packages

Restarting R session...

install.packages("mxnet")
Installing package into ‘\homedrive$/Shreyans.Bathiyan/R/win-library/3.5’
(as ‘lib’ is unspecified)
also installing the dependencies ‘bindr’, ‘brew’, ‘colorspace’, ‘utf8’, ‘gtable’, ‘reshape2’, ‘lazyeval’, ‘assertthat’, ‘bindrcpp’, ‘pkgconfig’, ‘R6’, ‘BH’, ‘plogr’, ‘digest’, ‘yaml’, ‘hms’, ‘XML’, ‘Rook’, ‘dichromat’, ‘plyr’, ‘munsell’, ‘labeling’, ‘viridisLite’, ‘cli’, ‘crayon’, ‘pillar’, ‘tidyselect’, ‘ggplot2’, ‘gridExtra’, ‘dplyr’, ‘downloader’, ‘glue’, ‘htmltools’, ‘htmlwidgets’, ‘igraph’, ‘influenceR’, ‘purrr’, ‘RColorBrewer’, ‘readr’, ‘rlang’, ‘rstudioapi’, ‘rgexf’, ‘scales’, ‘tibble’, ‘tidyr’, ‘viridis’, ‘stringi’, ‘Rcpp’, ‘DiagrammeR’, ‘visNetwork’, ‘data.table’, ‘jsonlite’, ‘magrittr’, ‘stringr’

Warning in install.packages :
unable to access index for repository https://apache-mxnet.s3-accelerate.dualstack.amazonaws.com/R/CRAN/GPU/bin/windows/contrib/3.5:
cannot open URL 'https://apache-mxnet.s3-accelerate.dualstack.amazonaws.com/R/CRAN/GPU/bin/windows/contrib/3.5/PACKAGES'
There is a binary version available but the source version is later:
binary source needs_compilation
stringi  1.1.7  1.2.2              TRUE
Binaries will be installed
Package which is only available in source form, and may need compilation of
C/C++/Fortran: ‘mxnet’
Kindly help me installing mxnet package.

@nswamy  Could you help to add label R and installation? Thanks!

I too am having difficulty installing mxnet r package after updating to R 3.5.0.
The error is that it cannot download the package - the address is incorrect or sth. please see log below:
R version 3.5.0 (2018-04-23) -- "Joy in Playing"
Copyright (C) 2018 The R Foundation for Statistical Computing
Platform: x86_64-w64-mingw32/x64 (64-bit)
R is free software and comes with ABSOLUTELY NO WARRANTY.
You are welcome to redistribute it under certain conditions.
Type 'license()' or 'licence()' for distribution details.
R is a collaborative project with many contributors.
Type 'contributors()' for more information and
'citation()' on how to cite R or R packages in publications.
Type 'demo()' for some demos, 'help()' for on-line help, or
'help.start()' for an HTML browser interface to help.
Type 'q()' to quit R.
[Workspace loaded from C:/R_work/RCA_GSP_failure/APAC_setl_status/.RData]

cran <- getOption("repos")
cran["dmlc"] <- "https://apache-mxnet.s3-accelerate.dualstack.amazonaws.com/R/CRAN/"
options(repos = cran)
install.packages("mxnet")
Installing package into ‘C:/Users/xbbnk69/Documents/R/win-library/3.5’
(as ‘lib’ is unspecified)
Warning in install.packages :
unable to access index for repository https://apache-mxnet.s3-accelerate.dualstack.amazonaws.com/R/CRAN/bin/windows/contrib/3.5:
cannot open URL 'https://apache-mxnet.s3-accelerate.dualstack.amazonaws.com/R/CRAN/bin/windows/contrib/3.5/PACKAGES'
Package which is only available in source form, and may need compilation of C/C++/Fortran: ‘mxnet’
installing the source package ‘mxnet’

trying URL 'https://apache-mxnet.s3-accelerate.dualstack.amazonaws.com/R/CRAN/src/contrib/mxnet_0.10.1.tar.gz'
Warning in install.packages :
cannot open URL 'https://apache-mxnet.s3-accelerate.dualstack.amazonaws.com/R/CRAN/src/contrib/mxnet_0.10.1.tar.gz': HTTP status was '404 Not Found'
Error in download.file(url, destfile, method, mode = "wb", ...) :
cannot open URL 'https://apache-mxnet.s3-accelerate.dualstack.amazonaws.com/R/CRAN/src/contrib/mxnet_0.10.1.tar.gz'
Warning in install.packages :
download of package ‘mxnet’ failed

version
_
platform       x86_64-w64-mingw32
arch           x86_64
os             mingw32
system         x86_64, mingw32
status
major          3
minor          5.0
year           2018
month          04
day            23
svn rev        74626
language       R
version.string R version 3.5.0 (2018-04-23)
nickname       Joy in Playing
sessionInfo()
R version 3.5.0 (2018-04-23)
Platform: x86_64-w64-mingw32/x64 (64-bit)
Running under: Windows >= 8 x64 (build 9200)

Matrix products: default
locale:
[1] LC_COLLATE=English_United States.1252  LC_CTYPE=English_United States.1252    LC_MONETARY=English_United States.1252
[4] LC_NUMERIC=C                           LC_TIME=English_United States.1252
attached base packages:
[1] stats     graphics  grDevices utils     datasets  methods   base
loaded via a namespace (and not attached):
[1] compiler_3.5.0 tools_3.5.0    yaml_2.1.19

@sergeykolychev

@marcoabreu Sorry, I am a perl maintainer not R

For CPU, you can install with :
install.packages("https://s3.ca-central-1.amazonaws.com/jeremiedb/share/mxnet/CPU/mxnet.zip", repos = NULL)
For GPU:
install.packages("https://s3.ca-central-1.amazonaws.com/jeremiedb/share/mxnet/GPU/mxnet.zip", repos = NULL)
@marcoabreu Is it possible for replace the official repo at "https://apache-mxnet.s3-accelerate.dualstack.amazonaws.com/R/CRAN/" with the above compilation for Windows. The current ones are quite dated.

I just updated to R 3.5 and suddenly all of my MXnet code doesnt work with random errors.
@jeremiedb is there anything that needed to change in your Windows compilation for the change to R 3.5?
The identical code worked with your compiled mxnet code with the R 3.4.4

@jeremiedb 's mxnet (CPU) link above seems to be broken. Installing leads to the error:
Error in rawToChar(block[seq_len(ns)]) :
embedded nul in string: 'PK\003\004\024\0\0\0\0\0\xea\026\xadL\0\0\0\0\0\0\0\0\0\0\0\0\006\0\0\0mxnet/PK\003\004\024\0\0\0\0\0\xe9\026\xadL\0\0\0\0\0\0\0\0\0\0\0\0\v\0\0\0mxnet/demo/PK\003\004\024\0\0\0\b\0\xf0\x9e\xabL\xd5\\aY\xa0\0\0\0\xfc'

@jakobetzel , could you provide details on your R version and operating system? Those pre-built binaries are for Windows. I just re-tried an installation of the CPU versoin and worked fine on R 3.5 and Win10.

@jeremiedb I do apologise, I was trying to install on Ubuntu. Sorry for inconveniences.

@jeremiedb any chance you have a pre-built binary package of mxnet for R 3.5.0 for Mac / Linux folks? Been trying everything else so am a little desperate now. Thanks in advance!

@jeremiedb I'd love to have your pre-built package to be on DMLC's CRAN image. Also, I have some questions regarding your compilation. Could you please ping me at my email (hetong007 [at] gmail)? Thanks!

@onlyphantom For R 3.50 on Mac, you can use this tar

@anirudhacharya A better way is to update maintain it at https://apache-mxnet.s3-accelerate.dualstack.amazonaws.com/R/CRAN/

@onlyphantom I don't have access to Mac, but for Linux, following the instruciton should work fine (at least on Ubuntu). If you have an issue on Linux, let me know, I might be able to hlep.

@onlyphantom I've updated the official S3 bucket. Please retry the installation on OS X, and feel free to comment if you can't install it by
cran <- getOption("repos")
cran["dmlc"] <- "https://apache-mxnet.s3-accelerate.dualstack.amazonaws.com/R/CRAN/"
options(repos = cran)
install.packages("mxnet")

Could you help me installing MXNET in R 3.5.0 on OS? I tried to install MLProjects/mxnet_1.3.0.tar.gz but it says ackage ‘mxnet’ was built under R version 3.5.1

@jeromejh  R 3.5.1 was released a few days ago. Can you please update it from https://cran.r-project.org/bin/macosx/ ?

I did just right now. But it still doesn't work. Very frustrating. Could you help me?

@jeromejh please paste

the error information
your sessionInfo() output

@jeromejh you need to update your openblas with brew install openblas, or other package manager that you are familiar with.

I just tried to update it like https://gist.github.com/bmmalone/1b5f9ff72754c7d4b313c0b044c42684 but it still doesn't work..

please try brew install openblas, if you have brew installed.

I'm sorry but where can I run it? In R?

please run brew install opencv as well.

Thank you so much. Not it works! I appreciate it!

HI,
In my case is not yet resolved
brew install openblas
brew install opencv
cran <- getOption("repos")
cran["dmlc"] <- "https://apache-mxnet.s3-accelerate.dualstack.amazonaws.com/R/CRAN/"
options(repos = cran)
install.packages("mxnet")
library("mxnet", lib.loc="/Library/Frameworks/R.framework/Versions/3.5/Resources/library")

Error: package or namespace load failed for ‘mxnet’:
 .onLoad failed in loadNamespace() for 'mxnet', details:
  call: dyn.load(file, DLLpath = DLLpath, ...)
  error: unable to load shared object '/Library/Frameworks/R.framework/Versions/3.5/Resources/library/mxnet/libs/libmxnet.so':
  dlopen(/Library/Frameworks/R.framework/Versions/3.5/Resources/library/mxnet/libs/libmxnet.so, 10): Library not loaded: /usr/local/opt/openblas/lib/libopenblasp-r0.3.1.dylib
  Referenced from: /Library/Frameworks/R.framework/Versions/3.5/Resources/library/mxnet/libs/libmxnet.so
  Reason: image not found

> sessionInfo()
R version 3.5.1 (2018-07-02)
Platform: x86_64-apple-darwin15.6.0 (64-bit)
Running under: macOS Sierra 10.12

Matrix products: default
BLAS: /System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vecLib.framework/Versions/A/libBLAS.dylib
LAPACK: /Library/Frameworks/R.framework/Versions/3.5/Resources/lib/libRlapack.dylib

locale:
[1] en_US.UTF-8/en_US.UTF-8/en_US.UTF-8/C/en_US.UTF-8/en_US.UTF-8

attached base packages:
[1] stats     graphics  grDevices utils     datasets  methods   base

other attached packages:
[1] shiny_1.1.0

loaded via a namespace (and not attached):
 [1] tidyselect_0.2.4   Rook_1.1-1         purrr_0.2.5        colorspace_1.3-2   htmltools_0.3.6
 [6] viridisLite_0.3.0  yaml_2.2.0         XML_3.98-1.16      rlang_0.2.2        pillar_1.3.0
[11] later_0.7.4        glue_1.3.0         RColorBrewer_1.1-2 bindrcpp_0.2.2     bindr_0.1.1
[16] plyr_1.8.4         stringr_1.3.1      munsell_0.5.0      gtable_0.2.0       visNetwork_2.0.4
[21] htmlwidgets_1.2    httpuv_1.4.5       DiagrammeR_1.0.0   Rcpp_0.12.18       xtable_1.8-3
[26] readr_1.1.1        scales_1.0.0       promises_1.0.1     jsonlite_1.5       rgexf_0.15.3
[31] mime_0.5           gridExtra_2.3      brew_1.0-6         ggplot2_3.0.0      hms_0.4.2
[36] digest_0.6.16      stringi_1.2.4      dplyr_0.7.6        grid_3.5.1         influenceR_0.1.0
[41] tools_3.5.1        magrittr_1.5       lazyeval_0.2.1     tibble_1.4.2       crayon_1.3.4
[46] tidyr_0.8.1        pkgconfig_2.0.2    downloader_0.4     assertthat_0.2.0   rstudioapi_0.7
[51] viridis_0.5.1      R6_2.2.2           igraph_1.2.2       compiler_3.5.1

@kmezhoud This two lines are supposed to run in your command line console:
brew install openblas
brew install opencv

@hetong007 Yes

@kmezhoud  Can I have your output from brew info openblas? It seems to me that your installation of openblas is not valid, or not 0.3.1, however it is the latest version from brew on my system.

@hetong007
 brew install openblas
Updating Homebrew...
==> Auto-updated Homebrew!
Updated 2 taps (homebrew/cask, homebrew/core).
==> Updated Formulae
checkbashisms                                  kakoune                                        sphinx-doc

Warning: openblas 0.3.3 is already installed and up-to-date
To reinstall 0.3.3, run `brew reinstall openblas`

@kmezhoud Try to link your openblas installation to v0.3.1 with the following statement and then try library(mxnet) on an R console
ln -sf /usr/local/opt/openblas/lib/libopenblasp-r0.3.3.dylib /usr/local/opt/openblas/lib/libopenblasp-r0.3.1.dylib

@anirudhacharya it works now 👍
Many thanks

I also have a problem to install openblas on Mac for R and CPU @ v1.3.0.
The err message is here.
$ brew install<EMAIL_ADDRESS>Error: No available formula with the name<EMAIL_ADDRESS>==> Searching for a previously deleted formula (in the last month)...
Warning: homebrew/core is shallow clone. To get complete history run:
  git -C "$(brew --repo homebrew/core)" fetch --unshallow

Error: No previously deleted formula found.
==> Searching for similarly named formulae...
Error: No similarly named formulae found.
==> Searching taps...
==> Searching taps on GitHub...
Error: No formulae found in taps.
$ ln -sf /usr/local/opt/openblas/lib/libopenblasp-r0.3.* /usr/local/opt/openblas/lib/libopenblasp-r0.3.1.dylib
ln: /usr/local/opt/openblas/lib/libopenblasp-r0.3.1.dylib: No such file or directory

And when I library the pkg, the err message is here.
library(mxnet)
#> Error: package or namespace load failed for 'mxnet':
#>  loadNamespace()里算'mxnet'时.onLoad失败了，详细内容：
#>   调用: dyn.load(file, DLLpath = DLLpath, ...)
#>   错误: 无法载入共享目标对象‘/Library/Frameworks/R.framework/Versions/3.5/Resources/library/mxnet/libs/libmxnet.so’：:
#>   dlopen(/Library/Frameworks/R.framework/Versions/3.5/Resources/library/mxnet/libs/libmxnet.so, 10): Library not loaded: /usr/local/opt/openblas/lib/libopenblasp-r0.3.1.dylib
#>   Referenced from: /Library/Frameworks/R.framework/Versions/3.5/Resources/library/mxnet/libs/libmxnet.so
#>   Reason: image not found

Created on 2018-10-24 by the reprex
package (v0.2.0).

@JiaxiangBU could you try running just brew install openblas and then run the softlink command.

Hi @anirudhacharya, I tried this code, and the command told me to reinstall it.
$ brew install openblas
Updating Homebrew...
==> Auto-updated Homebrew!
Updated 3 taps (homebrew/cask-versions, homebrew/core and homebrew/cask).
==> New Formulae
shellz
==> Updated Formulae
advancecomp     evince          imagemagick@6   pdfpc           tippecanoe
arangodb        grafana         jbake           planck          vault
ark             httpd           minizinc        skafos
bluepill        imagemagick     node-build      terraform-docs

Warning: openblas 0.3.3 is already installed and up-to-date
To reinstall 0.3.3, run `brew reinstall openblas`

Here is the result of re-installation.
brew reinstall openblas
==> Reinstalling openblas
==> Downloading https://homebrew.bintray.com/bottles/openblas-0.3.3.high_sierra.
Already downloaded: /Users/vija/Library/Caches/Homebrew/downloads/eeb066071ee951d9d6d73d9df42678ead1f37f52cb769b884d8a69cf1eecd66f--openblas-0.3.3.high_sierra.bottle.tar.gz
==> Pouring openblas-0.3.3.high_sierra.bottle.tar.gz
==> Caveats
openblas is keg-only, which means it was not symlinked into /usr/local,
because macOS provides BLAS and LAPACK in the Accelerate framework.

For compilers to find openblas you may need to set:
  export LDFLAGS="-L/usr/local/opt/openblas/lib"
  export CPPFLAGS="-I/usr/local/opt/openblas/include"

For pkg-config to find openblas you may need to set:
  export PKG_CONFIG_PATH="/usr/local/opt/openblas/lib/pkgconfig"

==> Summary
🍺  /usr/local/Cellar/openblas/0.3.3: 21 files, 115.5MB

And I get this error.
$ ln -sf /usr/local/opt/openblas/lib/libopenblasp-r0.3.* /usr/local/opt/openblas/lib/libopenblasp-r0.3.1.dylib
ln: /usr/local/opt/openblas/lib/libopenblasp-r0.3.1.dylib: No such file or directory

I think there is a file I miss. Becuase I don't specify the version of openblas.
I am still working on it.


Redirect component kills infinite redirect loop (good thing) which masks the issue (bad thing)

Version
4.0.0
Test Case
https://codepen.io/anon/pen/dWGwwY
Steps to reproduce
Code pen example has this issue shown when visiting About page twice!. Click About > Home > About.
Have some logic in your app that redirects the page if a certain parameter isn't set, or set wrong. Upon visiting the page a second time you might step into that redirect unintentionally. This is a simple logic error caused by the developer, fair enough. However, the Redirect component seems to swallow this without notifying the developer, causing great pain and anguish in trying to track down how a page is now blank
Expected Behavior
Maybe a console log in ENV=development that 'Redirect did not cause a change to URL' or something like that?
Actual Behavior
Pain.
Anguish.
(both great)

Alright, just for anyone else that reads this, this is the issue:

A <Route> matches a location and renders.
One of the child components that gets rendered is a <Redirect>.
That <Redirect> redirects back to the same route.
When the <Route> re-renders, instead of mounting the<Redirect> just updates.
There is no update behavior for the <Redirect> because it is assumed that a <Redirect> should never actually update.

What this means is that if the <Redirect> is the only thing that is rendered, you will end up with a blank screen.
I'm not really sure that a fix is necessary, but if we were to address it, the easiest approach would probably be to add a componentDidUpdate method to <Redirect> that calls warning.
componentDidUpdate() {
  warning(false, 'A <Redirect> should never update.')
}

Hello, could I take this on as a beginner commit?

No need to ask, just submit a PR 😄

@Dustin-RW @pshrmn The case of redirecting to the same route should definitely warn, blank pages are a frustrating dev experience (just had it and spent 2 hours getting to a similar conclusion as @pshrmn before reading this issue).
But... there's another case...
https://www.webpackbin.com/bins/-KjU_CGVVfWDb1M3jCXV
See Root.js:
function Root() {
  console.log(window.location.pathname);

  return (
    <Switch>
      <Redirect exact from="/" to="/hello" />
      <Redirect exact from="/hello" to="/hello/world" />

      <Route exact path="/hello/world" component={ Hello } />
    </Switch>
  )
}

The redirects will actually change the URL, but since Switch creates a clone of the child (Redirect in this case), and the previous child was also a Redirect, there's no logic on props change, and Redirect renders null, that's why we get a blank area.
So in Redirect.js, we can add a componentWillReceiveProps and:

If the props are the same, warn as @pshrmn mentioned
If the props are not the same, callthis.perform()

Questions:

Does this.isStatic play a role in this case?
componentWillReceiveProps vs. componentDidUpdate, which would be better in this case?

@Dustin-RW Are you on it, or do you want me to handle it?

@pshrmn I'd like to take this, can you answer my questions in the comment above?

isStatic should not matter here. isStatic is only used for server rendering, where there are no post-render lifecycle events. Since this is an issue with multiple renders, it should be client-side only.

componentDidUpdate would be better. This is because it mirrors componentDidMount, and it doesn't require a perform rewrite (you would have to pass nextProps/nextContext if done from cWRP in order to redirect using the new props).

As a temporary fix,  you could set a key on your <Redirect>s so that you are creating a new <Redirect> instead of re-using the existing one.
<Switch>
  <Redirect
    exact
    from="/"
    to="/hello"
    key="from-root"
  />
  <Redirect
    exact
    from="/hello"
    to="/hello/world"
    key="from-hello"
  />
  <Route exact path="/hello/world" component={ Hello } />
</Switch>

key worked, btw.
Opened a PR.

Is there any movement on this PR? It looks to have been good to go for almost 3 weeks. Having an issue #5231 and hoping that this PR with using Keys will be able to solve the problem. Having extreme difficulties getting clarity from multiple channels of communication so this would be nice to try.

@wsfuller Done https://github.com/ReactTraining/react-router/pull/5162#issuecomment-308269859 :-)

@alexilyaev Thank you so much! Been really struggling with this problem for the past several days pulling out hair


ol.interaction.Translate doesn't fire any event

I've tried the following code but neither fires anything:
var drag = new ol.interaction.Translate({
	features: collection
});
map.addInteraction(drag);

drag.on('change:active', function(evt){
	console.info(evt);
});
drag.on('change', function(evt){
	console.info(evt);
});

http://jsfiddle.net/jonataswalker/ugtc5ada/

What kind of notifications are you expecting? Do you want events on "translate start" and "translate end"?

"translate start" and "translate end" is exactly what I'm looking for. I'd like to know coordinates of dragging move.

I know there are other options but shouldn't ol.interaction.Translate fire at least the 'change:active' event?

change:active is triggered when setActive is called.

I see, but is there a way to know when "translate ended"?

There's no easy way. We need to add "translatestart" and "translateend" events.

Until now we have (as far as I know) three options to drag things on map:

ol.interaction.Modify
subclassing ol.interaction.Pointer - example
ol.interaction.Translate

I was thinking on write some code and contribute with a PR. Would ol.interaction.Translate the main method on this matter?

You cannot drag polygons and lines using ol.interaction.Modify. The drag-features.html example shows how to create a custom interaction, I guess it should be renamed custom-interactions.html or something I guess.

All right. I'll try to write these translate events.
Thanks for now.


[Arc] Unable to fetch latest data

Extension
https://raycast.com/the-browser-company/arc
Description
Error:
Error: Command failed with exit code 1: osascript
659:669: execution error: Arc got an error: Can’t get window 1. Invalid index. (-1719)
    at A_ (/Users/vatsal/.config/raycast/extensions/606e26d8-b3c5-4760-8001-dccce1b872c4/search.js:31:3082)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async hs (/Users/vatsal/.config/raycast/extensions/606e26d8-b3c5-4760-8001-dccce1b872c4/search.js:65:1463)

Steps To Reproduce

Raycast version: 1.72.1
Arc version 1.40.1
use search arc command

Current Behaviour
When using search arc command, it gives an error/warning: "Failed to fetch the latest data"
From what I can tell, there is no issues as the command still indexes all relevant window (including this one which I am using to write this bug report).

Expected Behaviour
Should simply show all latest search results without throwing the error/warning.

Never mind. Issue solved by updating arc to v 1.41

I can replicate this issue reliably if I don't have any Arc windows open. Using Arc Version 1.41.0 (49440)

I can replicate this issue reliably when using "Search Spaces" if Arc is running but I don't have any Arc windows/tabs open. Using Arc Version 1.41.0 (49440)

Yes, indeed, I could reproduce this issue reliably if

Arc is closed.
Arc is running but there are no windows open.


Support custom types

This implements #993. Originally, I thought it'd be possible to do this simply by having the custom type extend Virtus::Attribute, but a) it turned out to not be that easy and b) I figured it'd be better to define a pattern for this that isn't directly coupled to Virtus.
So, my change allows you to take any class and coerce parameters into it. All that's required is that the class implement a from_param class method. This name is arbitrary, but I feel it matches up with the intent of the change... totally open to suggestions, though. As a quick example:
class Color
  attr_reader :value
  def initialize(color)
    @value = color
  end
  def self.from_param(value)
    raise "Invalid color" unless %w(blue red green).include?(value)
    new(value)
  end
end

# ...

params do
  required :color, type: Color, default: Color.new('blue')
end
get '/stuff' do
  # params[:color] is already a Color.
  params[:color].value
end

# /bin/sh
$ curl localhost:9292/api/stuff?color=red
"red"

Things to consider:

If coercion fails, it's hard to tell why. The global rescue inside CoerceValidator#coerce_value hides any errors inside the coercion method with a "is invalid" message. This is probably acceptable for a first pass, though.
Should my tests be in param_scope_spec or coerce_spec? I'm leaning towards the latter, even though they're currently in the former.
Is there a better/cleaner approach here than checking for the existence of the from_param method?

This is great. Needs a CHANGELOG entry, please.
I am not in love with the name from_param. Can we brainstorm better names? Maybe coerce?
That said, I think the constructor should also be the coercer. This avoids the whole interface problem and allows you to use pretty much any type, no?
class Color
    attr_reader :value
    def initialize(value)
        fail 'Invalid color' unless %w(blue red green).include?(value)
        @value = value
    end
end

Thanks for the feedback! Using the initializer would be clean, but also a bit limiting. It's fine if you're creating the custom type from scratch for just this purpose, but it would restrict you if you wanted to use an existing class as a type. Suppose you already had a Color class which initializes with R, G, and B values, for example.
Let me know what you think. If we go with the extra-class-method approach, I think coerce is a pretty good name.

It could just be Monday, but I don't see why it wouldn't work with an existing class, care to provide an example?  :)

Maybe I'm misunderstanding, but suppose we already have a Color class used by the rest of our API, like so:
class Color
  def initialize(r, g, b)
    @r, @g, @b = r, g, b
  end
end

The constructor takes three integer arguments, so it couldn't directly be used to coerce the value. However, if we add a ::coerce method like so:
class Color
  def self.coerce(param)
    @r, @g, @b = param.unpack('A2A2A2').map(&:hex)
  end
end

Then you could hit endpoints like /api/pixel?color=FF0000 and it would parse the color param into the same thing as Color.new(255,0,0).

In the example above you would still have to extend Color with a coerce method that doesn't respect the original wishes of Color, is it worse to rewrite an initializer?
Some library gives you Color:
class Color
  def initialize(r, g, b)
    @r, @g, @b = r, g, b
  end

  def to_s
    "#{@r}|#{@g}|#{@b}"
  end
end

you open it up:
class Color
  alias_method :_initialize, :initialize
  def initialize(* args)
    if args.length == 3
      _initialize(*args)
    elsif args.length == 1
      @r, @g, @b = args.first.unpack('A2A2A2').map(&:hex)
    else
      fail 'Oh no.'
    end
  end
end

And:
2.0.0-p598 :183 >   Color.new(10, 20, 55)
 => #<Color:0x007f8e5595ceb0 @r=10, @g=20, @b=55>
2.0.0-p598 :184 > Color.new('FFCC11')
 => #<Color:0x007f8e55965718 @r=255, @g=204, @b=17>

Now that I wrote it I think it's worse.
Ruby actually has a way to deal with this for many times, eg. DateTime. I think the method should be called parse, not coerce, this is how most classes support parsing a String into an instance of themselves.

Yeah, parse definitely expresses the intent of the method, and aligns with existing Ruby standards. My only concern is that my implementation would then directly set the coercer for types that already respond to parse, like DateTime and Date. Granted, that's all Virtus' coercible gem does anyway, so it should be fine. And, I did a quick check and none of the other common types (Integer, Float, Hash, Array) support the parse method.
I'll push up a change to make it parse instead of from_param. Let me know what you think.

See comments above and squash your commits, please.

@dblock changes made. I'm not entirely sure the ParameterTypes module is worth it, as-is, so let me know what you think.
Part of the problem is, Grape delegates coercion directly to Virtus, and Virtus' coercion logic is pretty complex -- for example, if you specify a type which has included Virtus.model, Grape will handle it just fine (this is why the "complex type" logic as referenced in #1043 happens to actually work). So, deciding up-front whether or not we'll be able to coerce a given type is almost impossible. It might be a good long-term decision to start enforcing a list of allowed types, in order to decouple Grape from Virtus' inner workings. But that's not for this PR.

This is great. If you want to address any of the above in a future PR, please feel free. Merging.


[Feature]: add option to delete task

What kind of feature do you want?
add option to Task menu delete task.
it just remove task symbols in markdown - [ ] task -> task #gt-deleted
Additional questions

[X] I want to work on this feature request

Additionally, it would be useful to add an archive feature to move denied or delayed tasks for reduce computation, such as changing - [/] not important task  -> - not important task #gt-done, #gt-denied or #gt-delayed.


Does this plugin support the "replies" collection?

Sending an ActivityPub request to
https://www.draky.net/wordpress/2019/11/15/bonjour-tout-le-monde/
which has this plugin installed, returns good looking AP, but without the "replies" collection
https://www.w3.org/TR/activitystreams-vocabulary/#dfn-replies
This makes it impossible to enumerate the comment thread.
I'm wondering if it's implemented?
Thanks
- John

It is not yet implemented.
Do you know a platform that is already consuming the replies-collection?

Ah, ok - thanks for getting back.
There is a new open standard for podcast episode comments that relies on the existing basic Fediverse protocol (ActivityPub, Webfinger, http signatures for auth) for sending and displaying replies to a root comment post associated with that episode.
Info site here: https://podcastsocial.org/
Underlying rss feed tag spec, and open source components to make it easier for existing podcast apps to send and display them.
For displaying comments, it relies on being able to enumerate comments by parsing the standard replies collections
recursively.  Mastodon supports paged collections in its replies implementation, but replies can also be modeled inline if that's easier.
For sending comments, it relies on standard s2s federation inReplyTo the target object.  Is this supported?  I'm getting a 406 error (see below for the gory details) when POSTing to the inbox url using my custom software.  Replying from a Mastodon instance does not seem to work either.
I was really excited when I saw your plugin, the idea of a podcaster being able to use a WordPress site as the venue for their comments instead of, say, Mastodon, is that WP is already very popular in the podcasting community, and it would presumably provide additional moderation options for these incoming comments.
POST https://example.com/wp-json/activitypub/1.0/users/1/inbox
date: Thu, 24 Feb 2022 14:36:26 GMT
signature: keyId="https://sender.com/path/to#main-key",algorithm="rsa-sha256",headers="(request-target) host date digest",signature="<base64>"
digest: SHA-256=<base64>
content-type: application/activity+json

{
  "@context": "https://www.w3.org/ns/activitystreams",
  "id": "https://sender.com/path/to/activity",
  "type": "Create",
  "actor": "https://sender.com/path/to/actor",
  "object": {
    "id": "https://sender.com/path/to/object",
    "type": "Note",
    "published": "2022-02-24T14:35:34.151Z",
    "attributedTo": "https://sender.com/path/to/actor",
    "inReplyTo": "https://example.com/myfirstarticle/",
    "contentMap": {
      "und": "Hello!"
    },
    "to": [
      "https://www.w3.org/ns/activitystreams#Public"
    ],
    "cc": [
      "https://example.com/author/admin/"
    ]
  },
  "published": "2022-02-24T14:35:34.151Z"
}

results in
406
content-type: text/html; charset=iso-8859-1

<title>Not Acceptable!</title>
Not Acceptable!

An appropriate representation of the requested resource could not be found on this server. This error was generated by Mod_Security.

The plugin should accept replies from all big plattforms. The inReplyTo has to be the permalink of the blogpost.
See: https://github.com/pfefferle/wordpress-activitypub/blob/44c652eba8174368c9fdc2ca33e02fd2afbe436d/includes/rest/class-inbox.php#L410

Yep, we're using the article permalink for inReplyTo.
Test article: https://lehman-family.com/jstest/
(also is the AP "id" returned when requesting with accept: application/json)
But replying doesn't seem to work, even from Mastodon, paging @Lehmancreations for question about security setup on that site

This is not yet implemented, but it is planned!

Alright, verified that the 406 response received was due to the shared WP host's custom security filter.  They tweaked their secret algorithm and the AP payloads are now allowed through. Phew!
One small nitpick remains on incoming comments: your implementation should use the appropriate contentMap lang string (usually only one) as the content text.  It currently appears to only recognize the content string property.  They are actually the same conceptual field in the AP model.
My implementation can include a redundant string property on outgoing requests (Mastodon does this too as a workaround for outgoing), but it's not required, Mastodon/Pleroma use contentMap just fine if no content is provided for incoming.
Anyway this is exciting!  A fediverse option with fine-grained, pre-emptive moderation is a big deal.
While sending works, we won't be able to promote this plugin as a solution, though, until the replies collection is implemented, in order to support the read scenario.
I understand this might not be a trivial thing to implement, especially if you do it with paged collections for scalability (to support a post with thousands of comments), but this would be much appreciated by several folks interested in pointing people to existing fediverse endpoints on platforms that people are already using.
Let me know if I can help in any way, I haven't done PHP in 20 years, but happy to help test on the AP client side.

I second @johnspurlock's comment Would love to be able to use this plugin in a podcasting setting but would need the replies collection. This would be totally awesome to have cross app comments in podcasting and have the root comment be on our own website were the episode is based. I hope you consider adding the replies collection.

@mediaformat still eagerly awaiting this - any news on this front?

@johnspurlock yes, it is planned as part of #142

@johnspurlock yes, it is planned as part of #142

Excellent! Thank you

👀

keep

As I learned today the replies Collection is also used by by client application like some iOS and android apps.
@pfefferle which url should the replies Collection have for a WordPress post?
I got interested in implementing this, but got stuck fast, as I stumbled upon the issue whether it is a good practice to leak internal user-ids to an API.

I would use an API endpoint for this. Something like /activitypub/1.0/posts/1/replies or similar?!?

Related: Mobilizon announces every reply with the application actor. Any reasons not to do that (with at least if comments are manually accepted)?

I assume the 1 is the WordPress Post-ID? Seems it should be totally possible to not include the user in the replies Collection of a post like Mastodon does.

Exactly!

And in leaking the internal Post-ID I don't see any problem.

The Short URL is using the post ID, so I wouldn't see an issue here. (Even the User-ID is propagated by the default WordPress API btw.)

👀

I would use an API endpoint for this. Something like /activitypub/1.0/posts/1/replies or similar?!?

I did not remember that comment, but chose the same design for my draft in #876. This probably confirms that it's a good idea to do it this way.

@Menrath implemented that, so I will close this for now! please re-open if still an issue!


Presence of init.py breaks test discovery

Environment data

VS Code version: : 1.60.2
Extension version (available under the Extensions sidebar): v2021.9.1246542782
OS and version: Codespace 💫
Python version (& distribution if applicable, e.g. Anaconda): 3.8.6
Type of virtual environment used (N/A | venv | virtualenv | conda | ...): N/A
Relevant/affected Python packages and their versions: None
Relevant/affected Python-related VS Code extensions and their versions: N/A
Value of the python.languageServer setting: XXX

[NOTE: If you suspect that your issue is related to the Microsoft Python Language Server (python.languageServer: 'Microsoft'), please download our new language server Pylance from the VS Code marketplace to see if that fixes your issue]
Expected behaviour
Tests are detected.
Actual behaviour

Steps to reproduce:
Run this in a Codespace / devcontainer: https://github.com/JEFuller/vscode-python-import-bug/tree/main
Observe running from console works:
@davetapley ➜ /workspaces/vscode-python-import-bug (main) $ python -m unittest
.
----------------------------------------------------------------------
Ran 1 test in 0.000s

OK

Observe error in sidebar:

And in Python output:
Logs

Output for Python in the Output panel (View→Output, change the drop-down the upper-right of the Output panel to Python)

> /usr/bin/python3 ~/.vscode-remote/extensions/ms-python.python-2021.9.1246542782/pythonFiles/testing_tools/unittest_discovery.py ./test test_*.py
cwd: /workspaces/vscode-python-import-bug
> /usr/bin/python3 ~/.vscode-remote/extensions/ms-python.python-2021.9.1246542782/pythonFiles/testing_tools/unittest_discovery.py ./test test_*.py
cwd: /workspaces/vscode-python-import-bug
Error 2021-10-05 17:11:33: Error discovering unittest tests:
 Failed to import test module: test_app
Traceback (most recent call last):
  File "/usr/lib/python3.8/unittest/loader.py", line 436, in _find_test_path
    module = self._get_module_from_name(name)
  File "/usr/lib/python3.8/unittest/loader.py", line 377, in _get_module_from_name
    __import__(name)
  File "/workspaces/vscode-python-import-bug/test/test_app.py", line 3, in <module>
    from app import Foo
  File "/workspaces/vscode-python-import-bug/app.py", line 1, in <module>
    from models import db
ImportError: cannot import name 'db' from 'models' (/workspaces/vscode-python-import-bug/test/models/__init__.py)

This is caused by the existence of test/models/__init__.py.
If you rm test/models/__init__.py in the repro repo the the test will be detected ✅

@karthiknadig well that's embarrassing, thanks and sorry! 🙈


Bad argument help for type of optional argument

First Check

[X] I added a very descriptive title to this issue.
[X] I used the GitHub search to find a similar issue and didn't find it.
[X] I searched the Typer documentation, with the integrated search.
[X] I already searched in Google "How to X in Typer" and didn't find any information.
[X] I already read and followed all the tutorial in the docs and didn't find an answer.
[X] I already checked if it is not related to Typer but to Click.

Commit to Help

[x] I commit to help with one of those options 👆

Example Code
import typer
from typing import Optional

def main(name: Optional[str] = typer.Argument(None)):
   if name:
       typer.echo(f'Name: {name}')

if __name__ == '__main__':
    typer.run(main)

Description
For optional arguments Typer shows their metavar instead of type in argument help. For above example instead of TEXT we get [NAME] in argument help.
Operating System
macOS
Operating System Details
No response
Typer Version
0.6.1
Python Version
3.10
Additional Context
No response

You can manually specify the metavar like this:
import typer
from typing import Optional

def main(name: Optional[str] = typer.Argument(None, metavar='name')):
    if name:
        typer.echo(f'Name: {name}')

if __name__ == '__main__':
    typer.run(main)

Yes, but this is erasing the problem.

I would say that issue is caused by logic in here: https://github.com/tiangolo/typer/blob/7f44e6db6267efa87918e8700212de41a7fbdc3e/typer/rich_utils.py#L367-L377
# Column for a metavar, if we have one
metavar = Text(style=STYLE_METAVAR, overflow="fold")
metavar_str = param.make_metavar()

# Do it ourselves if this is a positional argument
if (
    isinstance(param, click.Argument)
    and param.name
    and metavar_str == param.name.upper()
):
    metavar_str = param.type.name.upper()

To reiterate the exact issue - following code:
import sys, typer
sys.argv[1:] = ['--help']
@typer.run
def example(*,
            arg1: int,
            arg2: int = 42,
            arg3: int = typer.Argument(...),
            arg4: int = typer.Argument(42),
            arg5: int = typer.Option(...),
            arg6: int = typer.Option(42),
            arg7: int = typer.Argument(42, metavar='metaarg7'),
            arg8: int = typer.Argument(42, metavar='ARG8'),
        ):
    pass

Produces following help message:
Usage: Example.py [OPTIONS] ARG1 ARG3 [ARG4] metaarg7 ARG8

Arguments:
 *    arg1      INTEGER   [default: None] [required]
 *    arg3      INTEGER   [default: None] [required]
      arg4      [ARG4]    [default: 42]
      arg7      metaarg7  [default: 42]
      arg8      INTEGER   [default: 42]

Options:
    --arg2      INTEGER   [default: 42]
 *  --arg5      INTEGER   [default: None] [required]
    --arg6      INTEGER   [default: 42]

The usage example works as intended and documented - for each argument a metavar is displayed.
The issue is in rest of help message. As the code is written - the second column is designed to contain metavar. But due to condition metavar_str == param.name.upper() in most cases it actually contains type name instead of metavar. It is also true for options.
While this condition is core of the issue it probably was added quite reasonably - because metavar column is not really useful. Similarly to OP, I would also prefer changing this column to just always contain type.


Failed to download: too many colons in address

I've built mcdex-0.9.5 on ubuntu w/ the current go snap (installed via sudo snap install go --classic) and have the following error when trying to download any modpack:
$> mcdex pack.install aoe age-of-engineering
-- /home/<usr>/.minecraft/mcdex/pack/aoe --
Starting download of modpack: https://minecraft.curseforge.com/projects/263897/files/2503175/download
2019/03/02 09:53:36 Failed to download aoe: Get https://minecraft.curseforge.com/projects/263897/files/2503175/download: dial tcp: address 2606:4700::6813:9284:443: too many colons in address

It's unclear whether you mean for it to be using ipv6.

I'm experiencing this too.

Can you please run:
ping minecraft.curseforge.com
and let me know what you get back? There's no specific IPv4/6 code in mcdex and I just validated it works on a fresh Ubuntu install. My suspicion is that this is your network configuration, but that ping should tell us more. :)

I added <IP_ADDRESS>          minecraft.curseforge.com to /etc/hosts and it downloads fine; here's the ping output.
ping minecraft.curseforge.com
PING minecraft.curseforge.com (<IP_ADDRESS>) 56(84) bytes of data.
64 bytes from minecraft.curseforge.com (<IP_ADDRESS>): icmp_seq=1 ttl=57 time=16.10 ms
64 bytes from minecraft.curseforge.com (<IP_ADDRESS>): icmp_seq=2 ttl=57 time=19.1 ms

Without that, it's this:
ping minecraft.curseforge.com
PING minecraft.curseforge.com(2606:4700::6813:9284 (2606:4700::6813:9284)) 56 data bytes
64 bytes from 2606:4700::6813:9284 (2606:4700::6813:9284): icmp_seq=1 ttl=57 time=67.0 ms
64 bytes from 2606:4700::6813:9284 (2606:4700::6813:9284): icmp_seq=2 ttl=57 time=22.1 ms

@osmarks I just had a PR submitted that resolved this issue. I'll be cutting a new release later today with this change incorporated. :)


Using TCK Tested JDK builds of OpenJDK

The AdoptOpenJDK has been discontinued since July 2021 (https://adoptopenjdk.net). Switching the distribution to Azul Zulu. When using Zulu you get all the latest updated (TCK Tested) builds for all versions of OpenJDK.
Please see more details at Foojay.io:
https://foojay.io/today/github-actions-with-java-part-2/

@ronmamo
What was reason for this PR getting closed?


Python conflict when also depending on esy-python

I think that esy-python just needs to be updated here, but I'm not exactly sure.

Whats the error message?
The ideal solution would be making tagged releases IMO. Do you use this package regularly? I can figure something if so

Yeah, it it a hash conflict because I think esy-python had some Windows fixes.

Do you use this package regularly? I can figure something if so

I am trying to use esy-python, esy-cmake and esy-ninja to get https://github.com/grain-lang/binaryen.ml to build properly without using global installs (like we discussed in my esy PR), but I keep having resolution and path issues 😬

Done! Let me know if all is well 👍


Server crashing in a specific and strange way

Basically, when an ejector shoots an arrow and a player is using equipment that, for example, gives an effect to the attacker.
EX: The player is wearing a helmet that causes blindness to whoever attacks him, but he was attacked by a piston, so the server simply crashes.

Crash issues must provide a crash report

crash-2023-10-07_00.34.49-server.txt

i think this one might be better
crash-2023-10-07_00.33.48-server.txt

This crash is coming out of a mixin: at net.minecraft.world.entity.LivingEntity.handler$cpe000$d(LivingEntity.java:23550) I do not know what mod the mixin is from, so you'll have to root-cause it on your own.


Components line number in dom

Current Behavior
After upgrading from tamagui 1.76.0 to 1.86.0 components file name and  line numbers in DOM are disappeared, is there any way to restore them? I tried using setupDev, but it shows info for only very few components (I can't screenshot because while I press ALT for 800ms I cannot use the shortcut to take screenshots)
Expected Behavior
Components line number are present in the DOM like in 1.76.0
Tamagui Version
1.86.0

Platform (Web, iOS, Android)
web

Reproduction
Inspect the dom to find a component file name and line number, you can't find it

System Info
System:
    OS: macOS 13.4
    CPU: (16) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
    Memory: 567.45 MB / 16.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 18.18.2 - ~/.nvm/versions/node/v18.18.2/bin/node
    Yarn: 3.2.3 - ~/.nvm/versions/node/v16.17.0/bin/yarn
    npm: 9.8.1 - ~/.nvm/versions/node/v18.18.2/bin/npm
  Browsers:
    Brave Browser: <IP_ADDRESS>
    Chrome: 120.0.6099.216
    Firefox: 113.0.1
    Firefox Developer Edition: 113.0
    Safari: 16.5
  npmPackages:
    @babel/runtime: ^7.18.9 => 7.21.0
    @manypkg/cli: ^0.19.1 => 0.19.2
    @next/bundle-analyzer: ^13.0.6 => 13.2.3
    @rnx-kit/metro-config: ^1.3.3 => 1.3.5
    @svgr/webpack: ^6.5.1 => 6.5.1
    @types/react: ^18.0.15 => 17.0.21
    @types/react-native: ^0.71.3 => 0.70.8
    @typescript-eslint/eslint-plugin: latest => 5.54.0
    @typescript-eslint/parser: 6.5.0 => 6.5.0
    change-case: ^4.1.2 => 4.1.2
    eslint: ^8.21.0 => 8.35.0
    eslint-plugin-react: latest => 7.32.2
    eslint-plugin-react-hooks: ^4.6.0 => 4.6.0
    eslint-plugin-valtio: ^0.6.2 => 0.6.2
    get-yarn-workspaces: ^1.0.2 => 1.0.2
    handlebars: ^4.7.7 => 4.7.7
    husky: ^8.0.0 => 8.0.3
    image-size: ^1.0.2 => 1.0.2
    next-transpile-modules: ^10.0.0 => 10.0.0
    patch-package: ^6.5.0 => 6.5.1
    postinstall-postinstall: ^2.1.0 => 2.1.0
    prettier: 2.8.8 => 2.8.8
    pretty-quick: ^3.1.3 => 3.1.3
    react-toastify: ^9.1.3 => 9.1.3
    react-zoom-pan-pinch: ^3.1.0 => 3.1.0
    setimmediate: ^1.0.5 => 1.0.5
    turbo: ^1.4.2 => 1.8.3
    typescript: ^5.1.6 => 5.2.2

Sorry about that. Can you set me up with a repro? I see them generally it's likely specific to your setup.


Skip domain check for replayDomain for decision checking

Pull Request Test Coverage Report for Build 194

4 of 9 (44.44%)  changed or added relevant lines in 2 files are covered.
14 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.06%) to 73.289%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

internal/internal_task_handlers.go
1
3
33.33%

internal/worker.go
3
6
50.0%

Files with Coverage Reduction
New Missed Lines
%

internal/internal_activity.go
3
72.0%

internal/internal_utils.go
11
89.44%

Totals

Change from base Build 193:
-0.06%

Covered Lines:
8179

Relevant Lines:
11160

💛  - Coveralls


trafficserver-8.0.6 issue in Ubuntu-20.04

HI
I have installed trafficserver with version 8.0.6 in Ubuntu-20.06.
For testing, tried curl command like curl -x http://trafficserer-ip:trafficserverport google.com. Command not responding after executing this command.
Issue: existing code traffic with broken pipe
Can anyone please advise.

Please help on this issue.

Can you attach logs and configs to this issue?

Please make sure you have turn off this option: https://docs.trafficserver.apache.org/admin-guide/files/records.config.en.html#proxy-config-url-remap-remap-required .

HI bryancall,
Yes, I have make this 0 already.

Hi randall,
There is no logs coming, command is not coming.
Like this coming.

Sorry,I was asking for trafficserver logs. I'm not sure where they would be in your environment. systemd possibly?

Hi Randall,
Thanks for the response.
I have enabled logs and enabled debug logs, But no logs are writing in the diag.log and manager.log.

Can you pass -v to the curl command?

Issue: existing code traffic with broken pipe

Where did the "broken pipe" come from?

Hi maskit,
Thanks for the update.
Please find the below attachment for both curl -x and curl -v -x

It seems like curl was able to connect to some server. If the IP address and port number are correct, you should see some debug log from traffic server.
Can you try this setting below? With this, you should see a lot of debug logs even without any connections.
CONFIG proxy.config.diags.debug.tags STRING .*

If you still don't see any errors with this, you are probably looking at a wrong log file.

Hi maskit,
I have enabled debug logs like this below.
CONFIG proxy.config.diags.debug.enabled INT 1
CONFIG proxy.config.diags.debug.tags STRING http|dns
I have configured logs path also in the traffic server, but its not updating and not generating squid.log.
We have tuned few OS parameters in Ubuntu, is this causing any issues ?

Are you seeing any error messages?  Can you post your logging.yaml file and records.config?


HeadObjectOperationDeserializer throwHeadObjectError throws wrong S3Exception("Failed to parse response as restXml error") when payload was not null but empty

Describe the bug
private fun throwHeadObjectError(context: ExecutionContext, call: HttpCall, payload: ByteArray?): kotlin.Nothing {
    val wrappedResponse = call.response.withPayload(payload)
    val wrappedCall = call.copy(response = wrappedResponse)

    val errorDetails = try {
        if (payload == null) {
            if (call.response.status == HttpStatusCode.NotFound) {
                S3ErrorDetails(code = "NotFound")

            } else {
                S3ErrorDetails(code = call.response.status.toString())

            }
        } else {
            parseS3ErrorResponse(payload)

        }
    } catch (ex: Exception) {
        throw S3Exception("Failed to parse response as restXml error").also {
            setS3ErrorMetadata(it, wrappedCall.response, null)
        }
    }
    val ex = when(errorDetails.code) {
        "NotFound" -> NotFoundDeserializer().deserialize(context, wrappedCall, payload)
        else -> S3Exception(errorDetails.message)
    }

    setS3ErrorMetadata(ex, wrappedResponse, errorDetails)
    throw ex
}

Regression Issue

[X] Select this option if this issue appears to be a regression.

Expected behavior
must throws NotFound exception when receive status 404
Current behavior
when receive status 404,  sometimes payload is not null but empty.
when payload is not null, try to parse payload then throw S3Exception("Failed to parse response as restXml error")
Steps to Reproduce
head object from removed object
Possible Solution
No response
Context
No response
AWS SDK for Kotlin version
aws.sdk.kotlin:s3:1.3.70
Platform (JVM/JS/Native)
JVM
Operating system and version
Windows 11

Hello, I'm unable to reproduce the behavior you mention. Calling headObject for a removed object results in NotFound().
    S3Client {
        region = "us-west-2"
    }.use { s3 ->
        s3.headObject {
            bucket = "..."
            key = "should-not-exist"
        }
    }

Could you verify as well?


Search'N'Pick

Description of the bug
After blueprints load, sit at collating forever. Never received this before.
Steps To Reproduce
Search'n'pick > wait for blueprint load > collating forever
Expected Behavior
search'n'pick > wait for blueprint load > search stuff freely
Log Files
No response
Save File
No response
Screenshots
No response
Settings
No response
Toybox Version
1.5.4.c
Operating System
No response
What game are you using Toybox on?
Pathfinder Wrath of the Righteous
Game Version
2.1.4w
Anything else?
No response

Hi! Stepping in after some testing; This is definitely an issue. I have 16 GB ram, to preface.
These logs were from subsequent tests, in which the first (GameLogFullPrev) was 5 minutes, and the second (GameLogFull) was 30. Both appear to end on almost the exact same sequence, which appears to be immediately after the loading of the last blueprint alphabetically (Sosiel_VictimCounter, BlueprintUnlockableFlag, 597ecdcfecf342c4a8c5d1d5c3fc15d5) followed by the entering and exiting of pauses as I exit the game.
GameLogs.zip

Yes, I am. Sorry for the late reply, got the notif on my phone and forgot to actually reply.

Every time for me. It loads the blueprints as normal, once finished it says Collating... indefinitely. Eventually the game will crash. It's a new bug with the newest version, because before now I have never seen Collating before. I've got 32GB RAM, gfx 3070, and ver 2.1.4w of the game.
Sorry, where are logs stored? I will be happy to provide one. Thank you for your work and time.

GameLogFull.txt
Player.log
Looks like reinstall does the trick. I had to fully delete it ( remove from cache in modfinder as well ) and it came up fully functional.

GameLogFullPrev.txt
GameLogFull.txt
Player.log
Just rolled back to 1.5.1 for now. All working there at least.


Fix bot owner dropdown partially hidden in Manage bot modal.

Steps to reproduce -

Login as Iago in development environemnt.
Open organization settings and go to Bots section.
Click on "pencil" icon for any of the bot.
Click on the owner dropdown.

CZO discussion - https://chat.zulip.org/#narrow/stream/9-issues/topic/dropdown.20in.20bot.20edit.20modal
The dropdown opened is not visible completely as shared below -

@zulipbot claim

@zulipbot claim

@zulipbot claim

This is fixed in #25446 after changing the dropdown to use tippy.


Gracefully handle WHOIS errors such as nonexistent domains

Add error handling for WHOIS errors like nonexistent domains.

Maintain list of encountered errors
Output successful domain lookups like normal
Afterward, output a warning message with encountered domains and errors logged to stderr

Closes #5.


Node2vec for weighted graphs

Description
Our current implementation of biased random walks used for the node2vec algorithm assume that the graph is unweighted. In other words, transition probabilities do not take edge weights into account assuming that all edges have weight 1.0. The original node2vec paper allows for edge weights.
We should extend our biased random walker to take edge weights into account.
User Story
As a: Research Engineer and Data Scientist
I want: to apply the node2vec representation learning algorithm on weighted graphs
so that: I can tackle a larger range of graph problems.
Done Checklist (Development)

[ ] Produced code for required functionality
[ ] Branch and Pull Request build on CI
[ ] Branch and Pull Request pass unit tests on CI
[ ] Branch and Pull Request pass integration tests on CI
[ ] Peer Code Review Performed
[ ] Code well commented

@PantelisElinas should it be a modification to the Biased Random Walker class (which would look for link weights, or use default weights of 1 if no weights are specified), or a new class?

Hi @youph and @habiba-h
I don't think we need a new walker for this. We should probably just add a flag, parameter to the run() method, to the existing one as to whether it should use edge weights or not. The default should be "False" so that current functionality and tests are not effected. Specifying "False" would automatically assume edges have weight 1 so the code doesn't need to be changed.
In the implementation, we should make sure not to check the value of the above flag for every edge we calculate the transition probability for 'cause such a check might increase running time (that is already not the best.)
We might have to assume that an edge has a weight property with a known label, e.g., "weight", or else we might want to allow the caller to specify the label name as another parameter with a default value such as "weight".
Regards,
P.


LANTERN-593: Added logging for the automatic populatedb prod cron job

Pull requests into this repository require the following checks to be completed by the submitter and reviewers.
Submitter:

[x] Administrative tasks are complete.

This pull request describes why these changes were made.
The JIRA ticket links to this PR.
The JIRA ticket for this PR is:

[x] Tests are complete.

Tests are included and test edge cases.
Tests have been run locally and pass.

[x] Code review has been performed.

Code diff has been done and checked to ensure only expected code is being committed.
A linter for the language has been run.

Primary Reviewer:

[ ] Code works.

Code has been run locally and the basic functionality affected by the PR has been checked.
Edge cases have been checked to ensure behavior is as expected.

[ ] Code review has been performed.

Code is maintainable, reusable, efficient, and correct.
Code accomplishes the tasks purpose.
Code follows style guidance appropriate for the language, including passing linter checks.
Code is well commented (which does not mean verbosely commented).

[ ] Tests are complete.

Tests are included and test edge cases.
Tests have been run locally and pass.

Merger:
Prior to merging, ensure that all checks have been completed. Delete the branch after the merge
is complete.

@rishi-salunkhe-mettle Reviewed and Approved, please assign within Mettles for Github PR Reviewer approval


Open Requests for Examples/Authenticators

Running list of requests for examples. I don't personally have any experience with these APIs so PRs/comments are appreciated.

Google Contacts API (https://github.com/VBA-tools/VBA-Web/issues/185)
Salesforce Bulk API (https://github.com/VBA-tools/VBA-Web/issues/172)
Sending Email Gmail (with attachments) (https://github.com/VBA-tools/VBA-Web/issues/246)
Windows Auth / Sharepoint Auth (https://github.com/VBA-tools/VBA-Web/issues/314)
Open-ID (https://github.com/VBA-tools/VBA-Web/issues/254)

Authenticator for Sharepoint w/WinAuth
Hope it works as well as it has for me


Tag dtl and dch files with their resource class

(this makes them visible to quick load, should fix #2226)

Hey @iscke, thanks you so much for this, this sounds awesome!

I like this, but I'd need someone to test if this actually works, e.g @zaknafean.

Testing out PR #2405 is good! The UI for Timeline COULD get a bit wild, but its a great and simple QoL.
https://github.com/user-attachments/assets/d358a7c3-ed85-426a-875d-8cee50b76ada
Cons:
UI gets a bit annoying to deal with when you have alot of timelines. I think this is more a godot issue rather than an implementation. I do not believe that should prevent merging at this time.
https://github.com/user-attachments/assets/eb93b65c-f3fa-4ca5-90cd-decbf4bbb965


Unload Assests and speed up loading

Unloads old song resources on refresh (No more increasing RAM usage)
Only loads new songs when returning from BeatSaver menu (Speeding up load time)
Pressing 'r' on the main menu still does a full refresh
Known Issues:
Doesn't take redownloaded songs into account on refresh

I've done something similiar in the refactoring branch, which will merge with main when the next Beat Saber update goes live.


Update sites.yml

https://gtmetrix.com/reports/auslandsguru.com/ozgHfmZK/

This PR is:

[x ] Adding a new domain
[ ] Updating existing domain size
[ ] Changing domain name
[ ] Removing existing domain from list
[ ] Website code changes (512kb.club site)
[ ] Other not listed

[x ] I used the uncompressed size of the site
[ x] I have included a link to the GTMetrix report
[ x] The domain is in the correct alphabetical order
[ x] This site is not an ultra lightweight site
[ x] The following information is filled identical to the data file

I confirm that I have read the FAQ section, particularly the two red items around minimal pages and inappropriate content and I attest that this site is neither of these things.

[ x] Check to confirm

- domain:
  url: https://auslandsguru.com/
  size: 12.6
  last_checked: 2023-10-05

GTMetrix Report: https://gtmetrix.com/reports/auslandsguru.com/ozgHfmZK/

Do you mind fixing the alphabetical order?

Fixed alphabetical order


modsecurity package not found

Hi,
I'm trying to install modsecurity for apache server on command line but getting "No package found" error
Commands I've tried are,
Ubuntu 14.04 server:
"sudo apt-get install libapache2-modsecurity"
"sudo apt-get install libapache2-mod-security"
centOS:
"sudo yum mod_security"
I'm trying it from few days and unable to install modsecurity.
I also tried,
$ apt-cache search modsecurity
and
$ yum search modsecurity
but not getting...
here I attached a pic of terminal

you see to be all over a bunch of different OS's in general here is the breakdown.... on RHEL based OS's modsecurity is typically refereed to as mod_security. so the command would be 'yum install mod_security'. In general the search functionality doesn't work very well as the description doesn't have the word 'ModSecurity' in it the only thing that comes up is mod_security_crs (when you do yum search modsecurity). If you can still not install it obviously check your repo's :)... But I just looked and its still in there (not that i'd expect it to go anywhere :-P )


Some perf suggestions

First of all, great work on this site! This is amazing. After running the site through https://www.webpagetest.org/easy I noticed a few things that could be changed to make the site load even faster:

First, this seems to be a known issue but the images seem a little large. Serving them as webp's in supported browsers could help alot here along with compressing those images.
Second, it currently looks like all below the fold images are being loaded up front, therefore blocking critical assets like JS and CSS from loading. I built this component https://github.com/ionic-team/ionic-pwa-toolkit/blob/b45f22d7508b429a66d763287959dd2fde2243fe/src/components/lazy-img/lazy-img.tsx which automatically lazy loads below the fold images. This component should work great on this site.
Third, I would look into using <link rel='preload' to preload critical assets (JS and CSS). Let me know if you have any questions about how to implement this.

Also one other thing I noticed was that the fonts being used here are pretty large and are blocking text rendering. Id check out the font display CSS rule https://developers.google.com/web/updates/2016/02/font-display and use the fallback strategy. This will ensure that users on good networks get the web font but users on slow connections will not be blocked from reading text until that web font has loaded


Token Refresh Offset

Summary
We are moving the token refresh offset from AccessToken to TokenCredential, to keep the originality and correctness of the expiresAt() getter on AccessToken.
On top of refreshing the token at an offset before expiry, we are also allowing the current non-expired token to be used if a proactive refresh fails. The proactive refresh will be attempted again next time some thread needs to get a token. To prevent too many refresh attempts, there will also be a timeout in place.
Proactive token refresh design
Initial token acquisition
The initial token acquisition will be done by the first thread entering the getToken() and all other threads will subscribe to a publisher that will emit the token once acquired.
For the first thread, once the token is acquired, it's cached and sent to the publisher. The entire operation on this thread is atomic.
When a valid token is in cache
When multiple threads are reading from the cache, at any given time one thread will check the token validity and if any proactive token refresh should happen. If not, it simply falls back to the cached token with minimal performance hit.
Proactive token refresh
When a thread is checking the validity of a token, shouldRefresh predicate may return true before the token expires. The token is considered "about to expire" for our customer and this thread is responsible for doing a proactive token refresh.
If the refresh succeeds, the cached token will be updated. If the refresh fails, no error will be raised (will be logged) and the currently cached token will continue to be used. The next refresh attempt will not be allowed until 30 seconds later - the next thread coming in within 30 seconds will not attempt a proactive token refresh.
Likewise, these are all happening on one thread at any given time. All the others are simply getting the cached token emitted by the publisher.
After token expires
If proactive token refreshes keep failing, or a token hasn't been checked until the currently cached token has expired, the next thread calling getToken() will be responsible for acquiring a new token. If there is a 30 seconds refresh timeout currently in place, since there are no more available tokens to fallback to, the thread will wait for the timeout to be over to attempt another token refresh.
If the refresh fails at this point, we have run out of available tokens, thus raising an error to the downstream.

@jianghaolu I think you may need to rebase with master. The changes in version_client.txt that are in this PR are already in master but the versions in the pom files in your fork aren't going to match which is going to cause the analyze step to fail.

Thanks @JimSuplizio pulling in master.

Moved to https://github.com/Azure/azure-sdk-for-java/pull/13029


class of values Photo.HDR shadows the parameter constant Photo.HDR

Perhaps the constants should be renamed Photo.HDR_PHOTO, following Photo.WDR_PHOTO?
https://github.com/KonradIT/gopro-py-api/blob/4176ba03e386be5d6477e8aad1006d6ac50c99a8/goprocam/constants.py#L457

I'm away from a computer, can you make a pull request with your suggestion?

Done, PR #46


XCloud Update

 Created from VS Code using CodeStream

Hello ~~ @aldoyh

Sorry, I thought I was pushing to the forked repo! 😁


[netdata] get the list or count of RLOC16s of border routers

This commit adds a new method in NetworkData to find the list of
RLOC16 of all border routers providing external IPv6 connectivity. A
border router is considered to provide external IPv6 connectivity if
it has added at least one external route entry without nat64 flag, or
an on-mesh prefix with default-route and on-mesh flags set. It also
adds a method to count the number of border routers. The methods
allow filtering based on the border router device role, including
devices in any role, or in router role only or in child role only.
This commit also updates test_network_data unit test to validate
the behavior of the newly added methods.

This is related to SPEC-1033.

In the new push, updated the code to reflect the discussions in SPEC-1033.
In particular we count border routers that "provide IPv6 connectivity" (defined as adding either an external route entry without NAT64 flag, or an on-mesh prefix with default-route and on-mesh flags)


Remove BigInt, switch everything to {ui}128.

This removes BigInt from the host and adds u128 and i128, also switching the builtin token contract to use i128 as its integer type.

The TryFromVal impls look fine at a glance. I pushed some tiny change because of unnecessary conversion that existed, but otherwise still lgtm. Is there anything holding us back from merging this now?


"Apply" button is broken (sending both uris and fetch)

The uris and fetch fields can't be PUT to the API at the same time. This produces an uncaught 400 error when the user clicks on the apply button.
We need to make sure we are not sending both fetch and uris when applying an app's older version.

I pontificated a little about this in a comment on a PR here

Yep, thanks for linking the original discussion!

@pierlo-upitup @philipnrmn  can we close this issue?

@aquamatthias –  @philipnrmn is on it.

Edited the original ticket to add clear acceptance criteria.

The question is: is the fix version still 0.15?

I would say that we should release a 0.15.n bugfix release after this is merged.

Note – this bug has a quickfix in branch release/0.15.5 ready to be released.

Hi folks,
it seems that this bug is back on marathon 1.3.3 / marathon-ui 1.1.5, by applying an old version of an app's configuration I get a 400 Bad request in the web developer tools with the following response:
    "message": "Invalid JSON",
    "details": [
        {
            "path": "",
            "errors": [
                "You cannot specify both uris and fetch fields"
            ]
        }
    ]
}```

What do we need to do to reopen this issue?


YARN-11191. Fix potentional deadlock in GlobalScheduler refreshQueues

Change-Id: I4ca3998748494c1148b1ef79b33500eecae02a97

Description of PR
Jira: YARN-11191
Original PR: https://github.com/apache/hadoop/pull/4726
The investigation and the fix was done by @yb12138, see the Original PR for further details.
I fixed the leftover review comments and I slightly modified the new test code to actually test
the refreshQueues. The new test fails without the fix.
How was this patch tested?
I created a sample application for demonstration:
import java.util.concurrent.locks.LockSupport;
import java.util.concurrent.locks.ReentrantReadWriteLock;

public class Main {

  static final long start = System.currentTimeMillis();

  public static void main(String[] args) {
    ReentrantReadWriteLock queue = new ReentrantReadWriteLock();
    ReentrantReadWriteLock preemption = new ReentrantReadWriteLock();

    Thread schedulerThread = new Thread(() -> {
      log("queue.readLock().lock()");
      queue.readLock().lock();
      try {
        Thread.sleep(5 * 1000);
      } catch (InterruptedException e) {
        e.printStackTrace();
      }
      log("preemption.readLock().lock()");
      preemption.readLock().lock();
      log("preemption.readLock().unlock()");
      preemption.readLock().unlock();
      log("queue.readLock().unlock()");
      queue.readLock().unlock();
    }, "SCHEDULE");

    Thread completeThread = new Thread(() -> {
      try {
        Thread.sleep(1000);
      } catch (InterruptedException e) {
        e.printStackTrace();
      }
      log("queue.writeLock().lock()");
      queue.writeLock().lock();
      log("queue.writeLock().unlock()");
      queue.writeLock().unlock();
    }, "COMPLETE");

    Thread refreshThread = new Thread(() -> {
      try {
        Thread.sleep(2 * 1000);
      } catch (InterruptedException e) {
        e.printStackTrace();
      }
      log("preemption.writeLock().lock()");
      preemption.writeLock().lock();
      log("queue.readLock().lock()");
      // OUTPUT_A
      queue.readLock().lock();
      // OUTPUT_B
      //while (!queue.readLock().tryLock()) {
      //  LockSupport.parkNanos(10000);
      //}
      log("queue.readLock().unlock()");
      queue.readLock().unlock();
      log("preemption.writeLock().unlock()");
      preemption.writeLock().unlock();
    }, "REFRESH ");
    schedulerThread.start();
    completeThread.start();
    refreshThread.start();

    try {
      schedulerThread.join();
      completeThread.join();
      refreshThread.join();
    } catch (InterruptedException e) {
      throw new RuntimeException(e);
    }
  }

  static void log(String what) {
    System.out.printf("%04d %s %s%n", System.currentTimeMillis() - start, Thread.currentThread().getName(), what);
  }
}

OUTPUT_A deadlock happens.
0005 SCHEDULE queue.readLock().lock()
1007 COMPLETE queue.writeLock().lock()
2006 REFRESH  preemption.writeLock().lock()
2006 REFRESH  queue.readLock().lock()
5042 SCHEDULE preemption.readLock().lock()

OUTPUT_B deadlock does not happen. (tryLock)
0003 SCHEDULE queue.readLock().lock()
1003 COMPLETE queue.writeLock().lock()
2003 REFRESH  preemption.writeLock().lock()
2004 REFRESH  queue.readLock().lock()
2005 REFRESH  queue.readLock().unlock()
2005 REFRESH  preemption.writeLock().unlock()
5026 SCHEDULE preemption.readLock().lock()
5027 SCHEDULE preemption.readLock().unlock()
5027 SCHEDULE queue.readLock().unlock()
5027 COMPLETE queue.writeLock().unlock()

For code changes:

[x] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'YARN-11191. Your PR title ...')?
[ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

LGTM

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
7m 33s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
32m 59s

trunk passed

+1 :green_heart:
compile
0m 34s

trunk passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
compile
0m 32s

trunk passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
checkstyle
0m 31s

trunk passed

+1 :green_heart:
mvnsite
0m 38s

trunk passed

+1 :green_heart:
javadoc
0m 36s

trunk passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
javadoc
0m 29s

trunk passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
spotbugs
1m  7s

trunk passed

+1 :green_heart:
shadedclient
20m 27s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 28s

the patch passed

+1 :green_heart:
compile
0m 30s

the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
javac
0m 30s

the patch passed

+1 :green_heart:
compile
0m 26s

the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
javac
0m 26s

the patch passed

+1 :green_heart:
blanks
0m  1s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 25s
/results-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 2 new + 139 unchanged - 0 fixed = 141 total (was 139)

+1 :green_heart:
mvnsite
0m 26s

the patch passed

+1 :green_heart:
javadoc
0m 26s

the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
javadoc
0m 27s

the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
spotbugs
1m 11s

the patch passed

+1 :green_heart:
shadedclient
20m 39s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
89m 55s

hadoop-yarn-server-resourcemanager in the patch passed.

+1 :green_heart:
asflicense
0m 24s

The patch does not generate ASF License warnings.

182m 42s

Subsystem
Report/Notes

Docker
ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6732/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6732

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 8af00fba70d5 5.15.0-94-generic #104-Ubuntu SMP Tue Jan 9 15:25:40 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / aeb1b430e30affd6549348feda637ba93b45a298

Default Java
Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6732/1/testReport/

Max. process+thread count
914 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6732/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Thanks @tomicooler, LGTM

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 20s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
33m 18s

trunk passed

+1 :green_heart:
compile
0m 36s

trunk passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
compile
0m 32s

trunk passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
checkstyle
0m 32s

trunk passed

+1 :green_heart:
mvnsite
0m 35s

trunk passed

+1 :green_heart:
javadoc
0m 38s

trunk passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
javadoc
0m 32s

trunk passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
spotbugs
1m 10s

trunk passed

+1 :green_heart:
shadedclient
20m 37s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 25s

the patch passed

+1 :green_heart:
compile
0m 32s

the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
javac
0m 32s

the patch passed

+1 :green_heart:
compile
0m 29s

the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
javac
0m 29s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 22s

the patch passed

+1 :green_heart:
mvnsite
0m 29s

the patch passed

+1 :green_heart:
javadoc
0m 25s

the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
javadoc
0m 26s

the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
spotbugs
1m 11s

the patch passed

+1 :green_heart:
shadedclient
20m 45s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
90m  8s

hadoop-yarn-server-resourcemanager in the patch passed.

+1 :green_heart:
asflicense
0m 25s

The patch does not generate ASF License warnings.

176m 11s

Subsystem
Report/Notes

Docker
ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6732/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6732

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux e28442f7b76e 5.15.0-94-generic #104-Ubuntu SMP Tue Jan 9 15:25:40 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 73c01ccb77ca85cd83785726b55841fe8b94e973

Default Java
Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6732/2/testReport/

Max. process+thread count
941 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6732/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

_ Prechecks _

+1 :green_heart:
dupname
0m 01s

No case conflicting files found.

+0 :ok:
spotbugs
0m 01s

spotbugs executables are not available.

+0 :ok:
codespell
0m 01s

codespell was not available.

+0 :ok:
detsecrets
0m 01s

detect-secrets was not available.

+1 :green_heart:
@author
0m 00s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m 00s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
106m 35s

trunk passed

+1 :green_heart:
compile
6m 48s

trunk passed

+1 :green_heart:
checkstyle
5m 43s

trunk passed

+1 :green_heart:
mvnsite
6m 51s

trunk passed

+1 :green_heart:
javadoc
6m 25s

trunk passed

+1 :green_heart:
shadedclient
174m 58s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m 23s

the patch passed

+1 :green_heart:
compile
4m 06s

the patch passed

+1 :green_heart:
javac
4m 06s

the patch passed

+1 :green_heart:
blanks
0m 00s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
2m 38s

the patch passed

+1 :green_heart:
mvnsite
3m 57s

the patch passed

+1 :green_heart:
javadoc
3m 27s

the patch passed

+1 :green_heart:
shadedclient
190m 26s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
asflicense
6m 36s

The patch does not generate ASF License warnings.

502m 33s

Subsystem
Report/Notes

GITHUB PR
https://github.com/apache/hadoop/pull/6732

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
MINGW64_NT-10.0-17763 0cbe62357619 3.4.10-87d57229.x86_64 2024-02-14 20:17 UTC x86_64 Msys

Build tool
maven

Personality
/c/hadoop/dev-support/bin/hadoop.sh

git revision
trunk / 73c01ccb77ca85cd83785726b55841fe8b94e973

Default Java
Azul Systems, Inc.-1.8.0_332-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6732/1/testReport/

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6732/1/console

versions
git=2.44.0.windows.1

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Thanks for the patch @tomicooler and @slfan1989 @p-szucs for the review, merging to trunk. @tomicooler can you please check if a backport is possible to the branches 3.3 and 3.4?


PermissionKeys

i have added a Permission key to  PermissionKeys "to be used as intellisense"
 [PageAuthorize(PermissionKeys.HomePagePeViewpages)]     public class DashboardController : Controller     {
on PermissionKeys class
 public const string HomePagePeViewpages = "PnpTools:DashBoard:View";
but its not showing in the Permissions page ? tried rebuilding /transform templates rebuild but its not showing

You need to add the to the site.texts.invariant.json file in MyProject.Web

Does other keys e.g. PnpTools:Test showing?

the keys are in the invariant json file, and others are showing

Seems like PageAuthorize attribute is not located
In UserPermissionRepository.cs, find code below:
                    foreach (var type in assembly.GetTypes())
                    {
                        ProcessAttributes<PermissionAttributeBase>(result, type, x => x.Permission);
                        ProcessAttributes<ServiceAuthorizeAttribute>(result, type, x => x.Permission);

                        foreach (var member in type.GetMethods(BindingFlags.Instance | BindingFlags.Public))
                        {
                            ProcessAttributes<PermissionAttributeBase>(result, member, x => x.Permission);
                            ProcessAttributes<ServiceAuthorizeAttribute>(result, member, x => x.Permission);
                        }
                    }

Replace with this:
                foreach (var type in assembly.GetTypes())
                {
                    ProcessAttributes<PageAuthorizeAttribute>(result, type, x => x.Permission);
                    ProcessAttributes<PermissionAttributeBase>(result, type, x => x.Permission);
                    ProcessAttributes<ServiceAuthorizeAttribute>(result, type, x => x.Permission);

                    foreach (var member in type.GetMethods(BindingFlags.Instance | BindingFlags.Public))
                    {
                        ProcessAttributes<PageAuthorizeAttribute>(result, member, x => x.Permission);
                        ProcessAttributes<PermissionAttributeBase>(result, member, x => x.Permission);
                        ProcessAttributes<ServiceAuthorizeAttribute>(result, member, x => x.Permission);
                    }
                }

that was the issue
ProcessAttributes(result, member, x => x.Permission);
was missing
to avoid this again should i allwasy check UserPermissionRepository.cs what was the reason ?

I forgot to traverse PageAuthorize, that was the reason, will be fixed in next template


InstallingPythonLibrary.md

How to install Peter Todd's Library

Good work @Olliecad1 thanks. Would be nice to see some more formatting as well if you get time, you can also include screen grabs and separate code out eg: sudo setup.py install
Looks all good for now though!


Clicking "External URL" opens the external URL in 2 tabs.

Likelihood: High
Impact: Low
Steps to reproduce: Visit the exchange site, and click the "External URL" button on any listed asset.

I have tried unsuccessfully (on vanilla Chrome, latest) to replicate this. Can you provide an exact link on which this happens?

Closing this, but feel free to reopen if you can replicate the issue and document steps taken.


update README.md

Some things have changed and need to be added to the README.
/cc #67 for otel-cli span background --wait and the --tp-carrier changes
also should add homebrew example to setup

Hey @tobert , could you help me understand these changes? I can publish spans with --timeout 60, however when using --wait it's timing out waiting for a unix socket. I looked through the code and it seems like it's waiting for a socket before executing net.Listen.
$ otel-cli span background --sockdir ./ --fail --verbose --wait
2022/10/05 12:18:01 timeout after 1s while waiting for span background socket 'otel-cli-background.sock' to appear
exit status 1

Never mind. After reading https://github.com/equinix-labs/otel-cli/pull/73 I see that --wait should only be used after we started a background span with a specified timeout to avoid race conditions.


sample_data_loader.py is failing while publishing to Elasticsearch

$ python example/scripts/sample_data_loader.py
WARNING:databuilder.publisher.elasticsearch_publisher:received no data to upload to Elasticsearch!

Found out Neo4j nodes do not have relations. Investigating...

Could this be related to "there and back again"
https://github.com/lyft/amundsenfrontendlibrary/blame/0271eee08f5ee0479b0950b3d8a5de4f376bcdb3/docker-amundsen.yml#L8
Now returned to original state by
https://github.com/lyft/amundsenfrontendlibrary/pull/168
CC @feng-tao

@jinhyukchang more than a month has passed since you reported this. Do you still see something that needs acting on for this issue or should it just be closed?

@jornh Thanks for reminding me. We can close this issue.


Decomposition tree - Improvment Request

Hi All,
Please can I ask if it would be possible to make the Data Bar Color have the option to apply colour based upon an attribute rule. For eample a Project has meta data relationg to its, approval status, lifecyce or current status (RAG). It would be great to have the option to color code the 'Data Bars' based upon this meta data, thanks in advance for considering this,

Thanks for your comment, @HaydnMilton. This issue has been assigned to the doc author for review.

Thanks for your comment, @HaydnMilton.
This looks like product feedback or a product question, rather than documentation feedback. You can submit product feedback or feature ideas by going to Power BI Ideas.
You can also engage with the Power BI engineering team by being active in the Power BI Community.


Item metadata fixes

This pull request fixes a few issues with item metadata and tags:

Default values for primitive and always present metadata
Nullable annotation for optional metadata
Exception when reading a mapped tag with default value null

LGTM. Just need to test the Tag default value change (probably in TagTest)


How to input 𝄫(double flat) and 𝄪(double sharp) in REPL or vscode?

I read Unicode input documentation, and I realized there is no shortcut to input these two symbols.
So... How did you enter these two characters? If it's copy and paste, maybe I think we need an equivalent convenience.

Yes I think I copied and pasted. There is a way to add new latex abbreviations to the REPL, but I don't remember exactly how right now.

I've added commonly used musical Unicode completions to Julia Repl, which are expected to be available in the next version.
These two symbols can be entered via \flatflat and \doubledouble.
I think when the next Julia is released, we can modify the [compat] entry and then close the issue.

Great thanks! I woukd have chosen the names doubleflat and doublesharp, which is what they are called at least in the UK.

Great thanks! I woukd have chosen the names doubleflat and doublesharp, which is what they are called at least in the UK.

I chose this naming at first, but the maintainers of Julia recommend the current naming due to the discoverability of the symbols. 😺


fix: no longer showing group separators

To improve the usability of our numeric input, we're going to no longer show thousand group separators inside the input box. These can be confusing to users when they go to edit the value, and simply aren't something that's commonly done elsewhere in the industry.

Codeowners file not adding the new group? 🤔

Yeah I just made a fix to it... maybe it was case sensitive. Changed it to @BrightspaceUI/gaudi-dev from @BrightspaceUI/Gaudi-Dev.


Added head pose estimation model

I think we don't have to, for now the repository is configured to store .bin and .blob files in LFS - which should be responsible for most of the space needed in zoo


Enable excel in public swagger

Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Contribution checklist:

[ ] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and have all been fixed in this PR.
[ ] The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

[ ] Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

[ ] If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

/azp run automation - sdk

Can one of the admins verify this patch?

/azp run automation - sdk

/azp run automation - sdk

@yuzhangyi do you want to merge this PR?

/azp run automation - sdk

/azp run automation - sdk

@qianwens , please help merge this change, thanks!


Don't wait until the logo is visible before starting animation.

Before:

After:

super cool :ship:


Classify nullability of scalar functions

Summary of the changes / Why this improves CrateDB
This enforces a scalar to be one of nullable, non_nullable, or neither. There are no functional changes at all. The assert will prevent one from accidentally dropping nullability feature.
Checklist

[x] Added an entry in the latest docs/appendices/release-notes/<x.y.0>.rst for user facing changes
[x] Updated documentation & sql_features table for user facing changes
[x] Touched code is covered by tests
[x] CLA is signed
[x] This does not contain breaking changes, or if it does:

It is released within a major release
It is recorded in the latest docs/appendices/release-notes/<x.y.0>.rst
It was marked as deprecated in an earlier release if possible
You've thought about the consequences and other components are adapted
(E.g. AdminUI)

Thanks for reviewing @matriv . Signature.scalar() is a shortcut for creating a signature and scalar implementations can forget to use it. I think b8be9d8f9bb5581418d1f3f0611561efae98b5b5 is required as a prerequisite.

TODO: Scalar.NO_FEATURES is used to override the default DETERMINISTIC feature which could also be refactored to be more explicit.

Please review again @matriv, Thank you!

Thank you @matriv please review the new changes.

I'm sorry but I don't really see how this improves things? In some ways this makes things worse as the nullability parameter to scalar can by any feature. E.g. instead of:
Signature.scalar(
      "translate",
      Feature.CONDITIONAL,
      DataTypes.STRING.getTypeSignature(),
      DataTypes.STRING.getTypeSignature(),
      DataTypes.STRING.getTypeSignature(),
      DataTypes.STRING.getTypeSignature())
  .withFeature(Feature.DETERMINISTIC),

You could write:
Signature.scalar(
      "translate",
      Feature.DETERMINISTIC,
      DataTypes.STRING.getTypeSignature(),
      DataTypes.STRING.getTypeSignature(),
      DataTypes.STRING.getTypeSignature(),
      DataTypes.STRING.getTypeSignature())

So all this does is enforce that there's at least one feature.
Can't we leave the API as is, but only verify that a scalar definition has a nullability specification within the Builder?

https://github.com/crate/crate/pull/16270 handled it better, closing.


allow multiple elements via data-bs-target selector

Prerequisites

[X] I have searched for duplicate or closed feature requests
[X] I have read the contributing guidelines

Proposal
Using data-bs-toggle="collapse" I would like to show one element, while hiding another.
Like this:
data-bs-toggle="collapse" data-bs-target="#toshow, #tohide"
This results in Bootstrap doesn't allow more than one instance per element
Motivation and context
One can imagine a modal options dialog containing links to colofon and disclaimer which are hidden by default.
Clicking such a link should hide the options dialog and show the colofon or disclaimer, either of which has been clicked.

Still testing, one is a collapse, the other a modal, looking into https://getbootstrap.com/docs/5.0/components/modal/#toggle-between-modals...

changed to several modals, works nicely, also found https://getbootstrap.com/docs/5.0/components/collapse/#multiple-targets


Highlight Mentions in Stream

Make tweets that mention the current user standout in the stream, like Tweetbot makes the background in a different color.
Not sure if changing the color is the best option since the user can customize how the stream looks.

This was fixed by https://github.com/sindresorhus/refined-twitter/pull/43.


PHPMD Warning When Using Compact With Quotes (Not Apostrophe)

It seems that this usage causes a bit of headache for PHPMD:
$variable = "test";

return view("scenery", compact("variable"));

any news about this ?

ping

Thanks for the report, we are happy to accept a PR to fix this.