Azure Resource deployment Task Failure

Hi Team
I have been using “Azure resource Manager deployment” Task in VSTS to deploy the template using release manager. I am facing an issue with template where it fails with below observation:

In VSTS release, Override template parameters shows below error. I have selected the file using browse button only. See attached 1.jpg and 2.jpg

I went ahead and deployed it and it failed with below error:

2017-05-18T06:45:27.3061795Z ##[section]Starting: Service Bus:Create/Update Service Bus Alert
2017-05-18T06:45:27.3216637Z ==============================================================================
2017-05-18T06:45:27.3216637Z Task         : Azure Resource Group Deployment
2017-05-18T06:45:27.3216637Z Description  : Deploy, start, stop, delete Azure Resource Groups
2017-05-18T06:45:27.3216637Z Version      : 2.1.0
2017-05-18T06:45:27.3216637Z Author       : Microsoft Corporation
2017-05-18T06:45:27.3216637Z Help         : More Information
2017-05-18T06:45:27.3216637Z ==============================================================================
2017-05-18T06:45:27.6341731Z f5178d01-fb27-4c59-a0b5-2f0f4b69bc1a exists true
2017-05-18T06:45:27.6341731Z Checking if the following resource group exists: DeliveryOrderServiceOperationSIT.
2017-05-18T06:45:28.6490528Z Resource group exists: true.
2017-05-18T06:45:28.6490528Z Creating deployment parameters.
2017-05-18T06:45:28.6490528Z ##[error]Error: Ensure the Template file is valid. Task failed while parsing with following error: Unexpected token /
2017-05-18T06:45:28.6490528Z ##[section]Finishing: Service Bus:Create/Update Service Bus Alert
The same template works If I try to deploy using Powershell :
PS D:\Deepak\myWork\VSTS\SC-SCS-SC-DCS-DeliveryOrder\Operations\DCServices.Operations\Deployment\bin\Debug> .\Deploy-AzureResourceGroup.ps1 -StorageAccountName '' -ResourceGroupName 'DeliveryOrderServiceOperationSIT' -ResourceGroupLocation 'eastus2' -TemplateFile 'D:\Deepak\myWork\VSTS\SC-SCS-SC-DCS-DeliveryOrder\Operations\DCServices.Operations\Deployment\ServiceBus\createAlert.azuredeploy.json' -TemplateParametersFile 'D:\Deepak\myWork\VSTS\SC-SCS-SC-DCS-DeliveryOrder\Operations\DCServices.Operations\Deployment\ServiceBus\createAlert.azuredeploy.parameters.json' -ArtifactStagingDirectory '.' -DSCSourceFolder '.\DSC'  -Verbose
VERBOSE: Performing the operation "Replacing resource group ..." on target "".
VERBOSE: 12:02:16 PM - Created resource group 'DeliveryOrderServiceOperationSIT' in location 'eastus2'
ResourceGroupName : DeliveryOrderServiceOperationSIT
Location          : eastus2
ProvisioningState : Succeeded
Tags              :
ResourceId        : /subscriptions/c2403b7f-d35b-405a-bccf-d954202081ef/resourceGroups/DeliveryOrderServiceOperationSIT
VERBOSE: Performing the operation "Creating Deployment" on target "DeliveryOrderServiceOperationSIT".
VERBOSE: 12:02:21 PM - Template is valid.
VERBOSE: 12:02:27 PM - Create template deployment 'createAlert.azuredeploy-0518-0632'
VERBOSE: 12:02:27 PM - Checking deployment status in 5 seconds
VERBOSE: 12:02:33 PM - Resource Microsoft.OperationalInsights/workspaces/savedSearches 'DeliveryOrderServiceOperationSIT-la/alert|dcservices-deliveryorder-servicebus-sit-scheduled  message in transactional queue greater than threshold-p3' provisioning status
is succeeded
VERBOSE: 12:02:33 PM - Resource Microsoft.OperationalInsights/workspaces/savedSearches 'DeliveryOrderServiceOperationSIT-la/alert|dcservices-deliveryorder-servicebus-sit-deadletter messgae in retry error queue greater than threshold-p1' provisioning status i
s succeeded
VERBOSE: 12:02:33 PM - Resource Microsoft.OperationalInsights/workspaces/savedSearches 'DeliveryOrderServiceOperationSIT-la/alert|dcservices-deliveryorder-servicebus-sit-subscription deleted-p1' provisioning status is succeeded
VERBOSE: 12:02:33 PM - Resource Microsoft.OperationalInsights/workspaces/savedSearches 'DeliveryOrderServiceOperationSIT-la/alert|dcservices-deliveryorder-servicebus-sit-deadletter messgae in transactional queue greater than threshold-p3' provisioning status
is succeeded
VERBOSE: 12:02:33 PM - Resource Microsoft.OperationalInsights/workspaces 'DeliveryOrderServiceOperationSIT-la' provisioning status is succeeded
VERBOSE: 12:02:33 PM - Checking deployment status in 5 seconds
VERBOSE: 12:02:39 PM - Resource Microsoft.OperationalInsights/workspaces/savedSearches/schedules 'DeliveryOrderServiceOperationSIT-la/alert|dcservices-deliveryorder-servicebus-sit-no telemetry data from service bus-p2/schedule-wd3jnzp2nimfg' provisioning sta
tus is succeeded
VERBOSE: 12:02:39 PM - Resource Microsoft.OperationalInsights/workspaces/savedSearches/schedules 'DeliveryOrderServiceOperationSIT-la/alert|dcservices-deliveryorder-servicebus-sit-active message in retry error queue greater than threshold-p2/schedule-tnouiwy
3hcnjc' provisioning status is succeeded
VERBOSE: 12:02:39 PM - Resource Microsoft.OperationalInsights/workspaces/savedSearches/schedules 'DeliveryOrderServiceOperationSIT-la/alert|dcservices-deliveryorder-servicebus-sit-active message in transactional queue greater than threshold-p3/schedule-lmqv7
ln5yuun4' provisioning status is succeeded
VERBOSE: 12:02:39 PM - Resource Microsoft.OperationalInsights/workspaces/savedSearches/schedules/actions 'DeliveryOrderServiceOperationSIT-la/alert|dcservices-deliveryorder-servicebus-sit-scheduled  message in retry error queue greater than threshold-p2/sche
dule-mcwsnfzb4amdu/alert-mcwsnfzb4amdu' provisioning status is succeeded
VERBOSE: 12:02:39 PM - Resource Microsoft.OperationalInsights/workspaces/savedSearches/schedules 'DeliveryOrderServiceOperationSIT-la/alert|dcservices-deliveryorder-servicebus-sit-scheduled  message in retry error queue greater than threshold-p2/schedule-mcw
snfzb4amdu' provisioning status is succeeded
VERBOSE: 12:02:39 PM - Resource Microsoft.OperationalInsights/workspaces/savedSearches 'DeliveryOrderServiceOperationSIT-la/alert|dcservices-deliveryorder-servicebus-sit-no telemetry data from service bus-p2' provisioning status is succeeded
VERBOSE: 12:02:39 PM - Resource Microsoft.OperationalInsights/workspaces/savedSearches 'DeliveryOrderServiceOperationSIT-la/alert|dcservices-deliveryorder-servicebus-sit-active message in retry error queue greater than threshold-p2' provisioning status is su
cceeded
VERBOSE: 12:02:39 PM - Resource Microsoft.OperationalInsights/workspaces/savedSearches 'DeliveryOrderServiceOperationSIT-la/alert|dcservices-deliveryorder-servicebus-sit-scheduled  message in retry error queue greater than threshold-p2' provisioning status i
s succeeded
VERBOSE: 12:02:39 PM - Resource Microsoft.OperationalInsights/workspaces/savedSearches 'DeliveryOrderServiceOperationSIT-la/alert|dcservices-deliveryorder-servicebus-sit-active message in transactional queue greater than threshold-p3' provisioning status is
succeeded
VERBOSE: 12:02:39 PM - Resource Microsoft.OperationalInsights/workspaces/savedSearches/schedules/actions 'DeliveryOrderServiceOperationSIT-la/alert|dcservices-deliveryorder-servicebus-sit-scheduled  message in transactional queue greater than threshold-p3/sc
hedule-6lwqd2xvjaepi/alert-6lwqd2xvjaepi' provisioning status is succeeded
VERBOSE: 12:02:39 PM - Resource Microsoft.OperationalInsights/workspaces/savedSearches/schedules/actions 'DeliveryOrderServiceOperationSIT-la/alert|dcservices-deliveryorder-servicebus-sit-subscription deleted-p1/schedule-phius24y2u22i/alert-phius24y2u22i' pr
ovisioning status is succeeded
VERBOSE: 12:02:39 PM - Resource Microsoft.OperationalInsights/workspaces/savedSearches/schedules/actions 'DeliveryOrderServiceOperationSIT-la/alert|dcservices-deliveryorder-servicebus-sit-deadletter messgae in retry error queue greater than threshold-p1/sche
dule-czl27dwni52ks/alert-czl27dwni52ks' provisioning status is succeeded
VERBOSE: 12:02:39 PM - Resource Microsoft.OperationalInsights/workspaces/savedSearches/schedules/actions 'DeliveryOrderServiceOperationSIT-la/alert|dcservices-deliveryorder-servicebus-sit-deadletter messgae in transactional queue greater than threshold-p3/sc
hedule-725tn5kdfx4lw/alert-725tn5kdfx4lw' provisioning status is succeeded
VERBOSE: 12:02:39 PM - Resource Microsoft.OperationalInsights/workspaces/savedSearches/schedules 'DeliveryOrderServiceOperationSIT-la/alert|dcservices-deliveryorder-servicebus-sit-subscription deleted-p1/schedule-phius24y2u22i' provisioning status is succeed
ed
VERBOSE: 12:02:39 PM - Resource Microsoft.OperationalInsights/workspaces/savedSearches/schedules 'DeliveryOrderServiceOperationSIT-la/alert|dcservices-deliveryorder-servicebus-sit-scheduled  message in transactional queue greater than threshold-p3/schedule-6
lwqd2xvjaepi' provisioning status is succeeded
VERBOSE: 12:02:39 PM - Resource Microsoft.OperationalInsights/workspaces/savedSearches/schedules 'DeliveryOrderServiceOperationSIT-la/alert|dcservices-deliveryorder-servicebus-sit-deadletter messgae in retry error queue greater than threshold-p1/schedule-czl
27dwni52ks' provisioning status is succeeded
VERBOSE: 12:02:39 PM - Resource Microsoft.OperationalInsights/workspaces/savedSearches/schedules 'DeliveryOrderServiceOperationSIT-la/alert|dcservices-deliveryorder-servicebus-sit-deadletter messgae in transactional queue greater than threshold-p3/schedule-7
25tn5kdfx4lw' provisioning status is succeeded
VERBOSE: 12:02:40 PM - Checking deployment status in 5 seconds
VERBOSE: 12:02:46 PM - Resource Microsoft.OperationalInsights/workspaces/savedSearches/schedules/actions 'DeliveryOrderServiceOperationSIT-la/alert|dcservices-deliveryorder-servicebus-sit-no telemetry data from service bus-p2/schedule-wd3jnzp2nimfg/alert-wd3
jnzp2nimfg' provisioning status is succeeded
VERBOSE: 12:02:46 PM - Resource Microsoft.OperationalInsights/workspaces/savedSearches/schedules/actions 'DeliveryOrderServiceOperationSIT-la/alert|dcservices-deliveryorder-servicebus-sit-active message in retry error queue greater than threshold-p2/schedule
-tnouiwy3hcnjc/alert-tnouiwy3hcnjc' provisioning status is succeeded
VERBOSE: 12:02:46 PM - Resource Microsoft.OperationalInsights/workspaces/savedSearches/schedules/actions 'DeliveryOrderServiceOperationSIT-la/alert|dcservices-deliveryorder-servicebus-sit-active message in transactional queue greater than threshold-p3/schedu
le-lmqv7ln5yuun4/alert-lmqv7ln5yuun4' provisioning status is succeeded
DeploymentName          : createAlert.azuredeploy-0518-0632
CorrelationId           : 8f0c0390-0df2-4f89-84ff-8247ead18083
ResourceGroupName       : DeliveryOrderServiceOperationSIT
ProvisioningState       : Succeeded
Timestamp               : 5/18/2017 6:32:42 AM
Mode                    : Incremental
TemplateLink            :
TemplateLinkString      :
DeploymentDebugLogLevel :
Parameters              : {[omsWorkspaceName, Microsoft.Azure.Commands.ResourceManager.Cmdlets.SdkModels.DeploymentVariable], [workspaceRegion, Microsoft.Azure.Commands.ResourceManager.Cmdlets.SdkModels.DeploymentVariable], [omsSku,
Microsoft.Azure.Commands.ResourceManager.Cmdlets.SdkModels.DeploymentVariable], [environmentName, Microsoft.Azure.Commands.ResourceManager.Cmdlets.SdkModels.DeploymentVariable]...}
ParametersString        :
Name             Type                       Value
===============  =========================  ==========
omsWorkspaceName  String                     DeliveryOrderServiceOperationSIT-la
workspaceRegion  String                     East US
omsSku           String                     free
environmentName  String                     SIT
serviceResourceGroupName  String                     DeliveryOrderServicesSIT
componentName    String                     DCServices
serviceLine      String                     DeliveryOrder
alertNotificationEmail  String<EMAIL_ADDRESS>txnQueueOMSQuery  String                     (Name_s=AllDeliveryOrders or Name_s=deliveryOrder)
errorQueueOMSQuery  String                     (Name_s=NonRetriableDeliverOrders or Name_s=RetriableDeliverOrders or Name_s=deliveryordererror)
azureComponentName  String                     ServiceBus
Outputs                 : {}
OutputsString           :
Please help.
Thanks
Deepak Sanghi

@dewanymca can you confirm is it due to the fact that your template file contains comments? We are working on adding support for template file containing comments which we hope to deploy by next week. In the meantime as a work-around you can remove any comments from your file. @ds-ms who is looking at it.

Yes,it was because of comments only. Let me know once fix is deployed.

https://github.com/Microsoft/vsts-tasks/pull/4344
This issue has been fixed. Will be rolled out in a couple of weeks.


Installation procedure

Document installation procedure

Thanks a lot for this pull request ! I only have one thing to note: the twatch-lib is present in the repository as a git submodule, so you only need to execute the following command to clone the repository and fetch the correct version of this component:
git clone --recurse-submodules https://github.com/virtualabs/hackwatch.git

Thanks, I have learned somthing. I will update it.

Fixed


Unable to start, Error:serf_signals.lua:59 ... serf_compatible

Summary
when i run /usr/local/bin/kong start -c /etc/kong/kong.conf.default
details:
ulimit is currently set to "1024". For better performance set it to at least "4096" using "ulimit -n"
migrating core for database kong
core migrated up to: 2015-01-12-175310_skeleton
core migrated up to: 2015-01-12-175310_init_schema
core migrated up to: 2015-11-23-817313_nodes
core migrated up to: 2016-02-29-142793_ttls
core migrated up to: 2016-09-05-212515_retries
core migrated up to: 2016-09-16-141423_upstreams
core migrated up to: 2016-12-14-172100_move_ssl_certs_to_core
core migrated up to: 2016-11-11-151900_new_apis_router_1
core migrated up to: 2016-11-11-151900_new_apis_router_2
core migrated up to: 2016-11-11-151900_new_apis_router_3
core migrated up to: 2016-01-25-103600_unique_custom_id
core migrated up to: 2017-01-24-132600_upstream_timeouts
core migrated up to: 2017-01-24-132600_upstream_timeouts_2
migrating key-auth for database kong
key-auth migrated up to: 2015-07-31-172400_init_keyauth
migrating galileo for database kong
galileo migrated up to: 2016-04-15_galileo-import-mashape-analytics
migrating acl for database kong
acl migrated up to: 2015-08-25-841841_init_acl
migrating ip-restriction for database kong
ip-restriction migrated up to: 2016-05-24-remove-cache
migrating hmac-auth for database kong
hmac-auth migrated up to: 2015-09-16-132400_init_hmacauth
migrating jwt for database kong
jwt migrated up to: 2015-06-09-jwt-auth
jwt migrated up to: 2016-03-07-jwt-alg
migrating oauth2 for database kong
oauth2 migrated up to: 2015-08-03-132400_init_oauth2
oauth2 migrated up to: 2016-07-15-oauth2_code_credential_id
oauth2 migrated up to: 2016-12-22-283949_serialize_redirect_uri
oauth2 migrated up to: 2016-09-19-oauth2_api_id
oauth2 migrated up to: 2016-12-15-set_global_credentials
migrating basic-auth for database kong
basic-auth migrated up to: 2015-08-03-132400_init_basicauth
basic-auth migrated up to: 2017-01-25-180400_unique_username
migrating response-ratelimiting for database kong
response-ratelimiting migrated up to: 2015-08-03-132400_init_response_ratelimiting
response-ratelimiting migrated up to: 2016-08-04-321512_response-rate-limiting_policies
migrating rate-limiting for database kong
rate-limiting migrated up to: 2015-08-03-132400_init_ratelimiting
rate-limiting migrated up to: 2016-07-25-471385_ratelimiting_policies
31 migrations ran
Error: /usr/local/share/lua/5.1/kong/cmd/utils/serf_signals.lua:59: attempt to concatenate upvalue 'serf_compatible' (a table value)
Run with --v (verbose) or --vv (debug) for more details
/usr/local/bin/kong start -c /etc/kong/kong.conf.default --vv
2017/03/17 06:34:06 [verbose] running datastore migrations
2017/03/17 06:34:06 [verbose] migrations up to date
2017/03/17 06:34:06 [verbose] serf agent not running, deleting /usr/local/kong/pids/serf.pid
2017/03/17 06:34:06 [debug] searching for 'serf' executable
2017/03/17 06:34:06 [debug] serf version: ''
2017/03/17 06:34:06 [debug] Serf executable not found at serf
2017/03/17 06:34:06 [verbose] could not start Kong, stopping services
2017/03/17 06:34:06 [verbose] leaving serf cluster
2017/03/17 06:34:06 [verbose] left serf cluster
2017/03/17 06:34:06 [verbose] stopping serf agent at /usr/local/kong/pids/serf.pid
2017/03/17 06:34:06 [debug] sending signal to pid at: /usr/local/kong/pids/serf.pid
2017/03/17 06:34:06 [debug] no pid file at: /usr/local/kong/pids/serf.pid
2017/03/17 06:34:06 [verbose] serf agent stopped
2017/03/17 06:34:06 [verbose] stopped services
Error:
/usr/local/share/lua/5.1/kong/cmd/start.lua:34: /usr/local/share/lua/5.1/kong/cmd/utils/serf_signals.lua:59: attempt to concatenate upvalue 'serf_compatible' (a table value)
stack traceback:
[C]: in function 'error'
/usr/local/share/lua/5.1/kong/cmd/start.lua:34: in function 'cmd_exec'
/usr/local/share/lua/5.1/kong/cmd/init.lua:88: in function </usr/local/share/lua/5.1/kong/cmd/init.lua:88>
[C]: in function 'xpcall'
/usr/local/share/lua/5.1/kong/cmd/init.lua:88: in function </usr/local/share/lua/5.1/kong/cmd/init.lua:45>
/usr/local/bin/kong:5: in function 'file_gen'
init_worker_by_lua:40: in function <init_worker_by_lua:38>
[C]: in function 'pcall'
init_worker_by_lua:47: in function <init_worker_by_lua:45>
Additional Details & Logs

Kong version (0.10.0)

Any suggestion? tks~

thx for the report. The problem is that Kong cannot find Serf (a dependency). But printing the error message generates the error.
The error you should have gotten is; could not find 'serf' executable. Kong requires version 0.7.0 to 0.8.1 (you can tweak 'serf_path' to your needs)
hth

fix is in #2218, closing this.

@Tieske tks~
I runexport KONG_SERF_PATH="/usr/local/bin/serf" ,then it's works!
By the way, it's also works by setting /usr/local/bin/ in PATH .

0.10 version still generating this error
Error: /usr/local/share/lua/5.1/kong/cmd/start.lua:22: could not find 'serf' executable. Kong requires version 0.7.0 to 0.8.1 (you can tweak 'serf_path' to your needs)

@manyixu that is the correct error, and you can, as suggested in the message, tweak the serf_path setting.


CastToNullableType: allow casting null keyword

Fix a false positive for CastToNullableType for casting a literal null to a nullable type. This can be necessary when providing null as a function argument where the incoming type is parameterized. In this case using e.g. null as? String is less meaningful and generates a compiler warning that the cast cannot succeed.

Thanks for the fix!


Consider updating the source?

Just want to see the changes since 0.2 :)

There really hasn't been any other than the minor bugfixes, I have been very busy with life so have not had much time to do anything, expect things to speed up again in December though

Do you need and help with bugfixing?

the big TODO right now is the oxygen system, and better recipes for things


Fix a case where vDSP is missing a cast

Also update availability information to use macOS instead of OSX, reorder CMakeLists.txt alphabetically, and rename ContiguousCollection.swift to AccelerateBuffer.swift.
Fixes rdar://problem/50076962

@swift-ci please smoke test


Building the Project

"npm run build" - Command not present. Can you please add it.

Hey, @jenasubodh
It was removed in v0.8.0 (release notes: https://github.com/diegohaz/rest/releases/tag/v0.8.0)
Just deploy the root directory.

Hey @diegohaz thanks for your quick reply. Great Generator by the way ....


Errors when going through the examples notebook

Pathways errors.docx
Hello,
I tried going through the examples notebook this morning, and encountered some errors (see attached). I did not change any of the code in the notebook.
Any fixes to these issues?
Thanks in advance!

Lasse Poulsen

Hi @lassekp,

this is only a warning because one field of the data package descriptor does not conform to the validation rules. Although annoying, it can be ignored.
Right. This is because the class PathwaysDataPackage is not just yet in the stable release/main branch of premise. To use it, you have to install the pathways branch of premise, like so: pip install git+https://github.com/polca/premise.git@pathways This will install that specific version of premise which contains that class, which allows generating pathways-compatible data packages containing premise databases inside.
Indeed, for some reason, that double_counting argument disappeared. We're working on re-implementing this now. I will let know you when that happens.

Thanks @romainsacchi.
I installed the specific Premise version, which fixed the issue - However, now I get a new error when trying to create a database (attached). I dont have this specific excel-file that it is searching for, and I can't seem to find it on the Premise github either. Should it be looking for the yml file instead?

Indeed, it seems I forgot to declare it in the packaging setup. As a quick fix, you can download the missing files from here and paste them into your folder.


docker中无法连接mongo

docker pull mongo
里面版本是  version:3.6
启动mongo的时候加了 --auth参数后,无法连接mongo
MongoDB shell version: 3.2.11
connecting to: test
2017-12-11T17:48:32.086+0800 W NETWORK  [thread1] Failed to connect to <IP_ADDRESS>:27017, reason: errno:111 Connection refused
2017-12-11T17:48:32.086+0800 E QUERY    [thread1] Error: couldn't connect to server <IP_ADDRESS>:27017, connection attempt failed :
connect@src/mongo/shell/mongo.js:229:14
@(connect):1:6
exception: connect failed

I am kind of same issue , "docker-compose ps" shows me that my mongo docker is running  at **<IP_ADDRESS>:27012->27017/tcp  **
but when I Try to connect via shell or software it doesnt work nor my apps .. its started with recent pull not sure whts wrong

You're going to have to be a lot more specific about how you're attempting to connect to the running container in order for folks to help debug.  Additionally, if you're on Windows or Mac OS, you might have additional complications (especially if you're still using Docker Toolbox), where you'll need to connect to the IP of your VM.
In the future, these sorts of questions/requests would be more appropriately posted to the Docker Community Forums, the Docker Community Slack, or Stack Overflow, and a new issue (or even PR!) filed here once it's determined that it's definitely a problem with the image and not simply an issue with local configuration, environment, or usage.  Thanks!

@sajidunnar @tianon thanks ,I found the wrong reason ,docker run  Parameter error

Can you plz share with me as well how tonfix that ?
On 14-Dec-2017 5:54 PM, "xhochipe"<EMAIL_ADDRESS>wrote:
@sajidunnar https://github.com/sajidunnar @tianon
https://github.com/tianon thanks ,I found the wrong reason ,docker run
Parameter error
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/docker-library/mongo/issues/221#issuecomment-351703078,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AATGECFWVJAN9Gqvulto-RDqkYEuZH1Kks5tARqZgaJpZM4Q9H2O
.


Php

momo developer API  in PHP

Good morning @Zakaria16! We appreciate your contributions, now reviewing your PR.

@all-contributors please add @Zakaria16 for code content documentation and examples

Great 💯

Thanks


revisit handling of auto-value

it seems like the shared-config injects auto-value annotations into the compiler annotation path, which differs from our approach.

Fixed in #742


Autoplay only one video at a time based on scrolling behavior

This PR introduces new logic for SingleSubVC around video autoplay. Only one video will play at a time, and the video will only autoplay when it's mostly visible on screen.
There's still more to do on this PR:

We should make sure I didn't break non-autoplay behavior.
I'm not sure how this feels to use on iPad.
There's a bit of ugly flashing when the videos start, since videos don't start loading as soon as they're visible after this PR.
When you tap on a video to start playing it inline, does that work correctly with these changes?
We should call updateAutoPlayVideos when the view controller is first presented. Right now it only runs when the scroll position changes.

[ ] We should make sure I didn't break non-autoplay behavior.
[ ] I'm not sure how this feels to use on iPad.
[ ] There's a bit of ugly flashing when the videos start, since videos don't start loading as soon as they're visible after this PR.
[ ] When you tap on a video to start playing it inline, does that work correctly with these changes?
[ ] We should call updateAutoPlayVideos when the view controller is first presented. Right now it only runs when the scroll position changes.

My changes/other things

[ ]  Progress dot gets hidden

Left a few issues, #883  and #884

Awesome work!


Non-existing config file not causing execution failure (or even a warning), but a run with defaults

What happened:
When running with a --config parameter pointing to a non-existing file ...
./anchore-k8s-inventory --config idontevenexist.yaml
k8-inventory is not failing or issuing at least a warning.
This causes a run with all default settings, so potentially very far from the intended settings.
What you expected to happen:
The command to just fail, as I wanted to explicitly run a certain config and fail otherwise.
How to reproduce it (as minimally and precisely as possible):
./anchore-k8s-inventory --verbose --verbose --verbose-inventory-reports --config idontevenexist.yaml
[2024-08-26 10:44:42] DEBUG Application config:
configpath: k8s-inventory/idontexist.yaml
quiet: false
log:
  structured: false
  levelopt: debug
  level: ""
  file: ""
clioptions:
  configpath: k8s-inventory/idontexist.yaml
  verbosity: 2
dev:
  profile-cpu: false
kubeconfig:
  path: ""
  cluster: ""
  cluster-cert: ""
  server: ""
  user:
    userconftype: 0
    type: ""
    client-cert: ""
    private-key: ""
    token: ""
kubernetes:
  request-timeout-seconds: 60
  request-batch-size: 100
  worker-pool-size: 100
namespaces: []
kubernetes-request-timeout-seconds: -1
namespace-selectors:
  include: []
  exclude: []
  ignore-empty: false
account-routes: {}
account-route-by-namespace-label:
  key: ""
  default-account: ""
  ignore-missing-label: false
missing-registry-override: ""
missing-tag-policy:
  policy: digest
  tag: UNKNOWN
runmode: 0
mode: adhoc
ignore-not-running: true
polling-interval-seconds: 300
inventory-report-limits:
  namespaces: 0
metadata-collection:
  nodes:
    include-annotations: []
    include-labels: []
    disable: false
  namespaces:
    include-annotations: []
    include-labels: []
    disable: false
  pods:
    include-annotations: []
    include-labels: []
    disable: false
anchore:
  url: ""
  user: ""
  password: ""
  account: admin
  http:
    insecure: false
    timeout-seconds: 10
verbose-inventory-reports: true

[2024-08-26 10:44:42]  INFO anchore-k8s-inventory is starting up...
[2024-08-26 10:44:42]  INFO Starting image inventory collection
[2024-08-26 10:44:42] DEBUG using kube config from ~/.kube/config
[2024-08-26 10:44:42] DEBUG Fetching namespaces took 243.545319ms

[...]

Giving it a config file that actually exists
./anchore-k8s-inventory --verbose-inventory-reports --config config.yaml
that config is used
[2024-08-26 10:47:34] DEBUG Application config:
configpath: config.yaml

[...]
namespace-selectors:
  include: []
  exclude:
  - thisconfigfilewasparsed
  ignore-empty: false

[...]

Anything else we need to know?:
Environment:

kai version (use kai version):
OS (e.g: cat /etc/os-release or similar):

@frittentheke thanks for the bug report, I have confirmed the issue we'll get this addressed for the next release

fixed in v1.6.3


DISCUSSION PR: Add environ to gcloud package to augment user agent

See #566.
This should not be merged (uses lots of pragma: NO COVER), it is just a quick and dirty way to go about it.
The App Engine import is innocuous, but the Compute Engine metadata server HTTP should not happen every single time gcloud is imported (or any sub-package / sub-module). This is the thing I want to discuss.

Changes Unknown when pulling cf587248490e8c70c66a839d6a94b3a9a2188790 on dhermes:fix-566 into ** on GoogleCloudPlatform:master**.

Changes Unknown when pulling 53245100f0a66a3d0b5c449ad9fb57635c6fb1fb on dhermes:fix-566 into ** on GoogleCloudPlatform:master**.

Making an HTTP request at import time is Just Wrong (TM).  We should either make an instance of a class with a property which computes __environ__ lazily (maybe __version__ too?), or else ditch the dunder-variable and use a helper function (which could cache the result in a private module global).

I like it. Will re-work with this in mind. I'm a little scared of what unit tests will look like.

Coverage decreased (-0.02%) to 99.98% when pulling 1d4c4de92bed25d6e0fac0b2c9461f54b619aa9e on dhermes:fix-566 into d858ff041192657c483e24fb904aade41996bf09 on GoogleCloudPlatform:master.

@tseaver I changed to using a lazy loading property with __str__ defined. I have yet to write tests because I want to discuss (made bogus pragma no cover to avoid).
I also debated using a default USER_AGENT on the class and then on Connection instance creation set a specific user agent? This could be difficult in tests if we create a lot of Connections (I'm not sure if we do).
Why can't GCE be detected without an HTTP request? Bah!
I'm a bit hesitant with this current approach since we have a if self._user_agent is None check before every single HTTP request. This is making me lean back towards setting at import time; the 0.1 second timeout will make it virtually imperceptible.

Another thing I wanted to do: set gcloud-python/0.3.0-regression-test for regression tests. (This can be done without this PR.)

Something like Pyramid's @reify decorator eliminates the lookup overhead.

Maybe we should allow applications to pass in a string to be added to the agent?

I like the reify approach, I'll go down that path and ping you again.

Allow them to pass a string, that sounds good. I debated just leaving this methods and asking people to set themselves, but realized people don't care about the user-agent. The reason we (or Google) would want the environ set is so we can get more information about how our library is used in the wild.

@tseaver PTAL. I held off on

allowing a custom user agent
setting one during regression tests

Will cover in another PR if you're OK with that.

Coverage remained the same at 100.0% when pulling 2f3f5dcb11db80aede8d37df9755cc1edf1ba4f1 on dhermes:fix-566 into d858ff041192657c483e24fb904aade41996bf09 on GoogleCloudPlatform:master.

Also I had to add a pragma: NO COVER on the use of the reify decorator. Rather than marked as a partial branch, running coverage html results in it being marked as exit. @tseaver any idea what that means?

Coverage remained the same at 100.0% when pulling b9266089eea7ff365bced277fbf44b290a166904 on dhermes:fix-566 into d858ff041192657c483e24fb904aade41996bf09 on GoogleCloudPlatform:master.

Deferring the "custom" agent stuff is fine by me.

Or move the logic down into the user_agent method and have the decorator just cache the result of calling in in the instance dict.

We want to leave the logic outside of Connection so that

branching stops occurring after first call (hence the reify pattern)
Connection can re-use the environ found without having to make another HTTP request

I'm fine with hard-coding user_agent as the name or with living the pragma: NO COVER.

I was thinking more of something like this gist.

Is there something inherently wrong with the way I've currently constructed it?
Also, what is app_id doing in the gist? I'm not sure if a unique user agent per user is a bad thing? (i.e. I don't know what tool Google uses to determine where traffic comes from)
What happens to Connection.user_agent here? It seems people should be able to just hack it with a string if they like. This ends up requiring something like Connection.user_agent.user_agent

Is there something inherently wrong with the way I've currently constructed it?

Using a decorator to wrap a no-op function smells bad to me.

What is app_iddoing in the gist?

I was addressing https://github.com/GoogleCloudPlatform/gcloud-python/pull/573#issuecomment-72117904.  If there were "well known" apps which used the feature, then one might be able to pick their traffic out of the logs.

What happens to Connection.user_agent here?

I had assumed that it would just use the value of gcloud_environment.user_agent (which would be the instance holding the cached / computed value.

Yes I think wrapping the no-op smells too, I'd rather just hard code the property name as user_agent (it's already a big clue by the name of the class)
I figured https://github.com/GoogleCloudPlatform/gcloud-python/pull/573#issuecomment-72117904 would be more free form
Assigning Connection.user_agent = gcloud_environment.user_agent at definition time will cause reify to make the HTTP request and we're back in the same situation of an HTTP during import

I figured #573 (comment) would be more free form.

It seemed useful to me to preserve the "library" info along with the application-specific tag.

Assigning Connection.user_agent = gcloud_environment.user_agent at definition time will cause reify to make the HTTP request and we're back in the same situation of an HTTP during import.

I hadn't meant to force it at import time;  rather, I would use @reify to wrap Connection.user_agent().

Where do you envision this class living?
RE: preserving UA string, I was planning to add a kwarg to Connection and just append (as your gist does)
Did you mean to have gcloud_environment = GCloudEnvironment() (instead of the class) in your gist?
Do we actually want the GCloudEnvironment class to be public, or just for demonstration purposes?

@tseaver Rebased on top of #580. Can we resume the conversation?

Coverage remained the same at 100.0% when pulling fd08c4211fb011a7e60bca89dabfacf3a9f3dbd8 on dhermes:fix-566 into 9518db72b4d0eefca887304d11e8fc37be17f514 on GoogleCloudPlatform:master.

Where do you envision this class living?

gcloud/environment.py?

RE: preserving UA string, I was planning to add a kwarg to Connection and just append (as your gist does)

Did you mean to have gcloud_environment = GCloudEnvironment() (instead of the class) in your gist?

Yes:  the whole notion requires an instance to hold the cached computed values.

Do we actually want the GCloudEnvironment class to be public, or just for demonstration purposes?

I don't care about the class, per se.  I was assuming that the instance might be part of the API, assuming apps might care about using its methods in the same way that the connection does.

I'm not sure about the use case:  won't the user have already handled an exception in the case that the transaction commit failed, or else have aborted it directly?
On the implementation:  handling two state fields seems awkward:  there are nonsensical combinations of them (_status is None, but _commit_success is True, etc.).  ISTM it would be better just to have self._status always be an integer, with values ranging from 0 ("initial"), 1 ("in progress"), 2 ("aborted"), 3 ("committed").

@tseaver That last comment meant for #595?


Webpack API / compatibility

I was trying to integrate Closure Compiler to my Advanced Boilerplate.
My setup currently looks super simple:
      ifProdClient(new ClosureCompilerPlugin({
        options: {
          compilationLevel: "SIMPLE"
        }
      })),

I have some kind of factory producing the actual webpack config. That's the reason why there is the ifProdClient() call.
Effects I saw:

A ton of outputs (=hundreds) regarding some 3rd party dependencies I include about some JSDoc comments (I don't care about) e.g. main-LeExkXKk.js:19675 (JSC_PARSE_ERROR) Parse error. illegal use of unknown JSDoc tag "category"; ignoring it @category Lang without mentioning any source file (wouldn't it be useful to reverse map based on the existing source map?)

A lot of messages regarding "JSC_UNREACHABLE_CODE" - I figure these are mostly regarding some conditionals based on process.env in the original code which are evaluated into true/false in the compiled code.

No support for my vendor chunk. Maybe this is some kind of parse error as their are other messages e.g. warnings coming from the processing of the vendor package. But the output file is just the Webpack original code. The only error message here looks like: vendor-QRGMGbNu.js:29608 (JSC_INVALID_NO_SIDE_EFFECT_ANNOTATION) @nosideeffects may only appear in externs files. render: 'DEFINE_ONCE',

I wonder about unreachable code for catch clauses. How could it actually figure this out?

Duplicated polyfills and infrastructure in different places. There should be definitely an option to prevent adding these. I either use Babel polyfill / Babel helper or some remote service like polyfill.io. I definitely don't want to bake all these things into my code. And definitely not into every chunk again.

It does not seem to "like" the "default" export handling of Webpack: main-LeExkXKk.js:9704 (JSC_USELESS_CODE) Suspicious code. This code lacks side-effects. Is there a bug? return !(0, _deepEqual2.default)(this.props, nextProps);

I wish, based on what I read, Closure Compiler JS would be in a better state. Right now it seems that there are so many issues, in such a simple boilerplate project, that I could not suggest anyone from the typical Webpack users to care about.
I wonder if there is actually any progress happening on improving the situation.
It does not help to claim that something could be used as some kind of drop-in replacement (presentations/conferences) to Uglify/Babili when even the most basic things are not working. Some good ES6 compatible (input and output) compressor would be really appreciated.
As far as I understand this project it's basically cross-compiled from Java. If these issues are more about the original Java implementation, feel free to forward them.

BTW: This is the source code for the vendor chunk:
import "intl"
import "isomorphic-fetch"

import "react"
import "react-dom"
import { BrowserRouter } from "react-router"
import "react-intl"

nothing special.

Hello @swernerx, you could work around points 1 and 2 in your original post if CC would use the webpack API to raise its errors and warnings instead of just dumping them to stdout. Since you're using webpack2 with a big configuration, I guess you're already processing webpack's error and warning arrays at some point, and you could then at least suppress these meaningless messages. See pull request https://github.com/google/closure-compiler-js/pull/70

For proper webpack support, use the https://github.com/webpack-contrib/closure-webpack-plugin plugin


Invalid URL

cy client v.<IP_ADDRESS> Windows 7 Professional  7601 SP1
Unable to download any album. Tried both x86 and x64 versions,

Is your album public?

I just copied and pasted the url into the downloader and it's working flawlessly for me

It could be because you're on windows 7 however. I don't know if the downloader supports such an old OS.

It's working for me. Download the latest version again just incase something went wrong.

I go exactly same issue at Win 10. I have downloaded latest version cy client several times and every time i get "invalid url" error.

I got exactly same issue at Win 10. I have downloaded latest version cy client several times and every time i get "invalid url" error.

Clear browser cache and try to reopen the album on your web browser. If it was deleted, then the downloader will report "invalid url". Cyberdrop does have an issue with albums still opening after being deleted due to cache. I will still look into it and see if it's something else.

One other thing is that you need to make sure you are using a .me url and not a .to url. The downloader only downloads from the .me not the .to, but if it's a .me and still saying invalid then it might have been deleted and in that case I can't do anything about that.

Cache cleared, album is active and domain is .me - still invalid url. In fact i tested on 16 albums and result is always the same.

Cache cleared, album is active and domain is .me - still invalid url. In fact i tested on 16 albums and result is always the same.

That's really odd... I'm having no issues myself and tested with two different computers. Must be something to do with your OS or environment. I honestly can't think of anything that could cause that.

@Bastek I will be releasing a hotfix for this issue. Let me know if it fixes your problem.

@Anequit Sure, could you make .exe with hotfix included?

@Anequit Sure, could you make .exe with hotfix included?

I'll release hotfix as update so you'll be able to download the latest version from the releases page

Sadly, the issue is still there. Win 10 pro 10.0.19043, Microsoft .NET Runtime 5.0.12 (x64). I tested on album mentioned in this discussion: https://cyberdrop.me/a/GfiuT4es

@Anequit Sure, could you make .exe with hotfix included?

I'll release hotfix as update so you'll be able to download the latest version from the releases page

still doesn't work man

Have the same problem

@izqalan Yes, all albums are accessible via browser and it loads instantly with no issues at all.

I'm out of town right now but when I get home I'll add some better logging so that we can narrow down what's going wrong

Same error on (Windows 10 21H2, Windows 11 22000.384)

https://github.com/izqalan/cy-client/releases/tag/v2.2.4

https://github.com/izqalan/cy-client/releases/tag/v2.2.4

I tried again with 27 download urls and issue is still the same.

What is it telling you now?

Exactly the same: invalid url.

I see... I left in a piece of code that I forgot to remove, so I'll push a new version with that fix.

https://github.com/izqalan/cy-client/releases/tag/v2.2.5

Unknown webscraper error. Please report this to the github repository.

Thanks, this will help narrow down the cause of the issue.

https://github.com/izqalan/cy-client/releases/tag/v.2.2.6

Unknown webscraper error. Please report this to the github repository. Input string was not in a correct format.
I tested on album mentioned in this discussion: https://cyberdrop.me/a/GfiuT4es

I believe I've identified the issue, so I'm going to work on patching it today.

https://github.com/izqalan/cy-client/releases/tag/v2.2.7

In a CMD prompt can you type "dotnet --info" and then copy and paste it here?

This issue should now be fixed.

You're right, this issue is now fixed! Thank you for your time and effort!

You're right, this issue is now fixed! Thank you for your time and effort!

It's my job to find the solution to the issue, thank you for helping me find the issue.


Not Working

Normally, my pc shows my manufacturer's (Lenovo) logo. I wanted to change it, and then, i used HackBGRT. Everything looked fine at installion but when i rebooted, instead of logo i gave, its changed to windows default logo (btw im using Windows 11). There is what i get when i enabled debug mode:

System Information:

My config.txt:
config.txt
bcdedit result:

Icon i used (Zipped it as github not supports .bmp):
hydro.zip
Can someone help me about it?

Your bmp is not 24-bit. Please try with version 2.0.0 which converts the image automatically when installing. (You can even use a PNG or such, and it will be converted when installing.)


ImageColumn checking image existence causes component rendering to become very very slow

Package
filament/tables
Package Version
v3.0.94
Laravel Version
10.33.0
Livewire Version
v3.1.0
PHP Version
PHP 8.1.26
Problem description
I'm using R2 (cloudflare s3 storage) to  host my app's images. I have problem rendering component which use ImageColumn. Checking the profiler, I discovered the cause was because method Filament\Tables\Columns\ImageColumn@getImageUrl checked for the existence of the image before displaying it, it called an http request, so it make rendering slow...
Let see demo in the attachments:

When use ImageColumn:

Profiler shown

When I comment out the ImageColumn

Filament\Tables\Columns\ImageColumn@getImageUrl

Expected behavior
It should not take ~820ms to render a simple component.
Steps to reproduce
I've posted in problem description yet.
Reproduction repository
https://github.com/filamentphp/filament/tree/3.x/packages/tables
Relevant log output
No response

there is a method called checkFileExistence that you can use like follow:
ImageColumn::make('thumbnail')
             ->circular()
             ->checkFileExistence(false)
             ->extraImgAttributes(['loading' => 'lazy']);

there is a method called checkFileExistence that you can use like follow:
ImageColumn::make('thumbnail')
             ->circular()
             ->checkFileExistence(false)
             ->extraImgAttributes(['loading' => 'lazy']);

Thank you!


[BUG] Can't create network after enable vlan network

Describe the bug

To Reproduce
Steps to reproduce the behavior:

enable vlan network
go to network page

Expected behavior

can create vlan network
Log

$ kubectl -n harvester-system get nn
NAME                   DESCRIPTION   NODENAME          TYPE   NIC
harv-test-vlan                       harv-test         vlan   eth0
harvester-bqqq9-vlan                 harvester-bqqq9   vlan   eth0
harvester-gs8sh-vlan                 harvester-gs8sh   vlan   eth0

$ kubectl -n harvester-system get nn harvester-gs8sh-vlan -oyaml
apiVersion: network.harvester.cattle.io/v1alpha1
kind: NodeNetwork
metadata:
  creationTimestamp: "2021-04-15T18:00:17Z"
  finalizers:
  - wrangler.cattle.io/harvester-nodenetwork-controller
  generation: 1
  labels:
    network.harvester.cattle.io/nodename: harvester-gs8sh
  name: harvester-gs8sh-vlan
  namespace: harvester-system
  ownerReferences:
  - apiVersion: v1
    kind: Node
    name: harvester-gs8sh
    uid: 54202984-5745-4c85-92d8-9f3a24f8322a
  resourceVersion: "40227"
  uid: 244eaf6b-173a-4619-afa8-02ae0d527558
spec:
  nic: eth0
  nodeName: harvester-gs8sh
  type: vlan
status: {}

$ kubectl -n harvester-system logs -f harvester-network-controller-2nrld
I0416 00:32:46.140912       1 controller.go:64] regular reset node network
I0416 00:42:48.150263       1 controller.go:84] node network configuration harvester-gs8sh-vlan has been changed, spec: {Description: NodeName:harvester-gs8sh Type:vlan NIC:eth0}
I0416 00:42:48.152347       1 vlan.go:81] start to setup VLAN network
I0416 00:42:48.157325       1 vlan.go:114] setup VLAN network successfully
time="2021-04-16T00:42:48Z" level=error msg="error syncing 'harvester-system/harvester-gs8sh-vlan': handler harvester-nodenetwork-controller: update status of nodenetwork harvester-gs8sh-vlan failed, error: nodenetworks.network.harvester.cattle.io \"harvester-gs8sh-vlan\" is forbidden: User \"system:serviceaccount:harvester-system:harvester-network-controller\" cannot update resource \"nodenetworks/status\" in API group \"network.harvester.cattle.io\" in the namespace \"harvester-system\", requeuing"

$ kubectl get po -o custom-columns='NAME:metadata.name,IMAGES:spec.containers[*].image'
NAME                                                    IMAGES
cdi-apiserver-69f7f84fcf-fmwtq                          quay.io/kubevirt/cdi-apiserver:v1.31.0
cdi-deployment-bcb6f8d7b-6qqz7                          quay.io/kubevirt/cdi-controller:v1.31.0
cdi-operator-7bd77cf84d-c9mrw                           quay.io/kubevirt/cdi-operator:v1.31.0
cdi-uploadproxy-66c9989744-9lh2j                        quay.io/kubevirt/cdi-uploadproxy:v1.31.0
harvester-7786c78794-bmfd9                              rancher/harvester:v0.2.0-rc2
harvester-7786c78794-cdwr6                              rancher/harvester:v0.2.0-rc2
harvester-7786c78794-k28mw                              rancher/harvester:v0.2.0-rc2
harvester-network-controller-2nrld                      rancher/harvester-network-controller:v0.1.3-rc1
harvester-network-controller-dq2b6                      rancher/harvester-network-controller:v0.1.3-rc1
harvester-network-controller-manager-7489446bc8-gbfwj   rancher/harvester-network-controller:v0.1.3-rc1
harvester-network-controller-manager-7489446bc8-n8dg7   rancher/harvester-network-controller:v0.1.3-rc1
harvester-network-controller-r9h5j                      rancher/harvester-network-controller:v0.1.3-rc1
harvester-promote-harvester-bqqq9-f7bhx                 busybox:1.32.0
harvester-promote-harvester-gs8sh-7trt6                 busybox:1.32.0
virt-api-85956875c5-9vfgm                               quay.io/kubevirt/virt-api:v0.38.1
virt-api-85956875c5-j6qzm                               quay.io/kubevirt/virt-api:v0.38.1
virt-controller-bf47f858f-qkwnb                         quay.io/kubevirt/virt-controller:v0.38.1
virt-controller-bf47f858f-zmrhg                         quay.io/kubevirt/virt-controller:v0.38.1
virt-handler-2j5jb                                      quay.io/kubevirt/virt-handler:v0.38.1
virt-handler-fxdvc                                      quay.io/kubevirt/virt-handler:v0.38.1
virt-handler-s5cjn                                      quay.io/kubevirt/virt-handler:v0.38.1
virt-operator-56b578d5dd-gk5n5                          quay.io/kubevirt/virt-operator:v0.38.1

$ kubectl get clusterroles.rbac.authorization.k8s.io harvester-network-controller -oyaml
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRole
metadata:
  annotations:
    meta.helm.sh/release-name: harvester
    meta.helm.sh/release-namespace: harvester-system
  creationTimestamp: "2021-04-15T17:00:49Z"
  labels:
    app.kubernetes.io/managed-by: Helm
  name: harvester-network-controller
  resourceVersion: "901"
  uid: ffd6a00e-daf6-4062-ab44-bc2c204ae4ef
rules:
- apiGroups:
  - network.harvester.cattle.io
  resources:
  - clusternetworks
  - nodenetworks
  verbs:
  - get
  - watch
  - list
  - update
  - create
  - delete
- apiGroups:
  - k8s.cni.cncf.io
  resources:
  - network-attachment-definitions
  verbs:
  - get
  - watch
  - list
  - update
- apiGroups:
  - ""
  resources:
  - nodes
  - configmaps
  - events
  verbs:
  - get
  - watch
  - list
  - update
  - create

$ kubectl get crd nodenetworks.network.harvester.cattle.io -oyaml
apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
  creationTimestamp: "2021-04-15T17:00:45Z"
  generation: 1
  name: nodenetworks.network.harvester.cattle.io
  resourceVersion: "696"
  uid: b57bb7be-e589-4385-b962-41471df19857
spec:
  conversion:
    strategy: None
  group: network.harvester.cattle.io
  names:
    kind: NodeNetwork
    listKind: NodeNetworkList
    plural: nodenetworks
    shortNames:
    - nn
    - nns
    singular: nodenetwork
  scope: Namespaced
  versions:
  - additionalPrinterColumns:
    - jsonPath: .spec.description
      name: DESCRIPTION
      type: string
    - jsonPath: .spec.nodeName
      name: NODENAME
      type: string
    - jsonPath: .spec.type
      name: TYPE
      type: string
    - jsonPath: .spec.nic
      name: NIC
      type: string
    name: v1alpha1
    schema:
      openAPIV3Schema:
        properties:
          apiVersion:
            description: 'APIVersion defines the versioned schema of this representation
              of an object. Servers should convert recognized schemas to the latest
              internal value, and may reject unrecognized values. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#resources'
            type: string
          kind:
            description: 'Kind is a string value representing the REST resource this
              object represents. Servers may infer this from the endpoint the client
              submits requests to. Cannot be updated. In CamelCase. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#types-kinds'
            type: string
          metadata:
            type: object
          spec:
            properties:
              description:
                type: string
              nic:
                type: string
              nodeName:
                type: string
              type:
                enum:
                - vlan
                type: string
            required:
            - nodeName
            type: object
          status:
            properties:
              conditions:
                items:
                  properties:
                    lastTransitionTime:
                      description: Last time the condition transitioned from one status
                        to another.
                      type: string
                    lastUpdateTime:
                      description: The last time this condition was updated.
                      type: string
                    message:
                      description: Human-readable message indicating details about
                        last transition
                      type: string
                    reason:
                      description: The reason for the condition's last transition.
                      type: string
                    status:
                      description: Status of the condition, one of True, False, Unknown.
                      type: string
                    type:
                      description: Type of the condition.
                      type: string
                  required:
                  - status
                  - type
                  type: object
                type: array
              networkIDs:
                items:
                  type: integer
                type: array
              networkLinkStatus:
                additionalProperties:
                  properties:
                    conditions:
                      items:
                        properties:
                          lastTransitionTime:
                            description: Last time the condition transitioned from
                              one status to another.
                            type: string
                          lastUpdateTime:
                            description: The last time this condition was updated.
                            type: string
                          message:
                            description: Human-readable message indicating details
                              about last transition
                            type: string
                          reason:
                            description: The reason for the condition's last transition.
                            type: string
                          status:
                            description: Status of the condition, one of True, False,
                              Unknown.
                            type: string
                          type:
                            description: Type of the condition.
                            type: string
                        required:
                        - status
                        - type
                        type: object
                      type: array
                    index:
                      type: integer
                    ipv4Address:
                      items:
                        type: string
                      type: array
                    mac:
                      type: string
                    master:
                      type: string
                    promiscuous:
                      type: boolean
                    routes:
                      items:
                        type: string
                      type: array
                    state:
                      type: string
                    type:
                      type: string
                  type: object
                type: object
              physicalNICs:
                items:
                  properties:
                    index:
                      type: integer
                    name:
                      type: string
                    usedByManagementNetwork:
                      type: boolean
                  type: object
                type: array
            type: object
        type: object
    served: true
    storage: true
    subresources: {}
status:
  acceptedNames:
    kind: NodeNetwork
    listKind: NodeNetworkList
    plural: nodenetworks
    shortNames:
    - nn
    - nns
    singular: nodenetwork
  conditions:
  - lastTransitionTime: "2021-04-15T17:00:45Z"
    message: no conflicts found
    reason: NoConflicts
    status: "True"
    type: NamesAccepted
  - lastTransitionTime: "2021-04-15T17:00:45Z"
    message: the initial names have been accepted
    reason: InitialNamesAccepted
    status: "True"
    type: Established
  storedVersions:
  - v1alpha1

Environment:

Harvester ISO version:  v0.2.0-rc2
Installation Mode: ISO
Underlying Infrastructure: vm

Additional context
Add any other context about the problem here.

seems the RBAC is missing nodenetwork.status permission

as a temporary workaround users can patch the network-controller image to v0.1.4 with
kubectl patch daemonset harvester-network-controller -n harvester-system -p \
  '{"spec":{"template":{"spec":{"containers":[{"name":"network","image":"rancher/harvester-network-controller:v0.1.4"}]}}}}'

this will be fixed in https://github.com/rancher/harvester/pull/700

validate on 0.2.0-rc3


Drop List Width

What is the best way to set the width of a Drop List? If I style the input with a width, that messes up the display and doesn't effect the list itself. I can't see how to send a width in to the "helper". Thanks!

no response, closing issue


Add Strings

Coverage remained the same at 100.0% when pulling df25ad07490254579cfbd72404a68740917898cd on add-strings into 65df4e7fa0e0510adf8faeff755907afb000f533 on master.


Check robots.txt

Now it contains something... no idea what it is. Read, why the hell do I need it and how to configure it properly.

Done.


Update eslint-plugin-node rules

Coverage remained the same at 100.0% when pulling 74c6194196cd09a2369f90b5c0b1695a33890ea3 on update-node-rules into 9eb4991d5c4f0729392695af5d2e2bdb92400940 on master.


Add workaround for overrides

Workaround #793

I'm closing this PR in favor of https://github.com/alexandrevilain/temporal-operator/pull/875 @yujunz  :)


added support for smembers.watch command

#1132

@anchalsingh25 are you still working on this PR? Are you blocked by anything?


use $response in Plugin event method if possible

fixed some PHPDoc namespaces
removed some "use namespace" which are not needed

Thanks! Is this lots of manual work or do you have some sort of tool to aid with this?

It's manual work, with the help of the IDE PHPStorm. It shows errors on the right side in yellow or red. I also run specific "Inspections" to search for problems, and then went over all results.
Some things, like "unnecessary long class name", can be fixed by the IDE. Or creating an import of a long class name, and shortening all occurrences in the code. They are called "quick fixes".
There are many more things to do, like shortening class names, but I'm not sure if you have a limit. If one long class name is just used once, do you want an import of that?
Also there are many problems with "@return void". It's wrong in many places, but to fix that you also have to fix the return statements, add return statements where they are missing in some code paths.
Maybe I can create a list, where I'm not sure how to fix it, and you can have a look? Or can I mark those lines in GitHub somewhere (create a comment or so)?
Which IDE are you using?
I'm currently preparing a migration from 1.6 to 3.1, changing all our Plugins and Backends, reading code, and while doing that I'm trying to fix things... The biggest problem is our database migration with millions of table rows, which will take many hours. I will have to optimize the migration scripts to decrease the time needed for that.


Instructions to use the Github app

I have posted a StackOverflow question&answer describing what has worked for me to get staticman up and running
https://stackoverflow.com/questions/54898580/how-to-use-staticman-with-react-gatsby/54898581#54898581
I guess the staticman api url will change when the app goes official? I haven't been able to find any doc describing this, so until it is updated, maybe this helps somebody like myself one day ago :)
*and, if there's any mistake, please correct it

See https://github.com/eduardoboucas/staticman/issues/243#issuecomment-453754860 for details.


Not working with langchain due to changes and migration to langchain experimental

As of today I am using langchain perfectly with other projects. Just testing chemprop minimum script
from chemcrow.agents import ChemCrow

chem_model = ChemCrow(model="gpt-4-0613", temp=0.1, verbose=True)
chem_model.run("What is the molecular weight of tylenol?")

Get the error
/home/stephany/.local/lib/python3.9/site-packages/langchain/__init__.py:34: UserWarning: Importing SerpAPIWrapper from langchain root module is no longer supported. Please use langchain.utilities.SerpAPIWrapper instead.
  warnings.warn(
/home/stephany/.local/lib/python3.9/site-packages/langchain/__init__.py:34: UserWarning: Importing LLMChain from langchain root module is no longer supported. Please use langchain.chains.LLMChain instead.
  warnings.warn(
/home/stephany/.local/lib/python3.9/site-packages/langchain/__init__.py:34: UserWarning: Importing PromptTemplate from langchain root module is no longer supported. Please use langchain.prompts.PromptTemplate instead.
  warnings.warn(
Traceback (most recent call last):
  File "/home/stephany/.local/lib/python3.9/site-packages/chemcrow/agents/chemcrow.py", line 46, in __init__
    self.llm = _make_llm(model, temp, verbose, openai_api_key)
  File "/home/stephany/.local/lib/python3.9/site-packages/chemcrow/agents/chemcrow.py", line 12, in _make_llm
    llm = langchain.chat_models.ChatOpenAI(
  File "/home/stephany/.local/lib/python3.9/site-packages/langchain/load/serializable.py", line 97, in __init__
    super().__init__(**kwargs)
  File "/home/stephany/.local/lib/python3.9/site-packages/pydantic/v1/main.py", line 341, in __init__
    raise validation_error
pydantic.v1.error_wrappers.ValidationError: 1 validation error for ChatOpenAI
__root__
  Did not find openai_api_key, please add an environment variable `OPENAI_API_KEY` which contains it, or pass  `openai_api_key` as a named parameter. (type=value_error)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/stephany/test_query/latest/testing.py", line 3, in <module>
    chem_model = ChemCrow(model="gpt-4-0613", temp=0.1, verbose=True)
  File "/home/stephany/.local/lib/python3.9/site-packages/chemcrow/agents/chemcrow.py", line 48, in __init__
    raise ValueError('Invalid OpenAI API key')
ValueError: Invalid OpenAI API key

Hi there!
The messages you get regarding langchain version are simply warnings, and do not affect execution at the moment.
The error you are getting is a ValidationError related to your openai_api_key.

Did not find openai_api_key, please add an environment variable OPENAI_API_KEY which contains it, or pass  openai_api_key as a named parameter. (type=value_error)

You can also pass it as an argument to ChemCrow.
from chemcrow.agents import ChemCrow:

chem_model = ChemCrow(
    model="gpt-4-0613",
    temp=0.1,
    openai_api_key="sk-...",
    verbose=True
)
chem_model.run("What is the molecular weight of tylenol?")

Can you please try that and let me know how it works :)


reenable unittests

I think the functions around cas testing should use is and !is instead of == and !=, for floating point and class reference comparison. Because cas operation don't case the value equivalence.

Interesting, didn't knew that "NaN is NaN" evaluates to true.
Your right then, I'll put it on my list.

@dawgfoto , I've posted #115 to replace == to is. Please refer it.


Add new user page is not intuitive after pressing add

Expected behavior:
After adding a new, the next page should either be an edit user page for the user you just added, OR clear out the fields and remain an add user page
Actual behavior:
User is added, but the page remains titled "New User".   Not intuitive, as any edits to that page will edit the user you just created.
Steps to reproduce:

Navigate to the new user page, either directly from the sidebar menu, or the button on the users list page.
enter data to create a new user and press "add"
Note the page title.

Screenshots (if applicable):

OS and Browser:
OSX  10.10.5  Chrome 54.0.2840.98

@jkleinsc ...just to let you know!

@Anisha1234 I think you should change the title of the edit page in this workflow vs. change the location of the successful add event. Is that helpful?


resolve issues with new cacert feature

Moved cacert copy clause from kubernetes/pre-install to kubernetes/node role
Replaced content option with src option as the OS_CACERT points to a file

Just got my notice that my CNCF was signed and received.

can you explain why this change is required ?

When I tried to use this to deploy a cluster within my openstack environment it exhibited 2 problems.  The first was that the Write cacert file step bombed because openstack_cacert was not defined.  This step was located in the kubernetes/preinstall role and this variable is defined in the kubernetes/node role.   Moving this to the kubernetes/node role resolved the issue.
The second thing was the copy: command specified a content: option rather than a src: option.  The openstack_cacert variable is derived from the OS_CACERT environment variable, which is a filename-path pointing to a file which contains your CA chain.  As written, the resulting openstack-cacert.pem file contained the path from my local workstation rather than the content of my CACERT file.

ci check this

/lgtm


find_child method doesn't find a child by name after changing it's parent

Tested versions
reproducible in v4.2.2.stable.arch_linux
System information
Godot v4.2.2.stable unknown - Manjaro Linux #1 SMP PREEMPT_DYNAMIC Mon Jun 10 09:50:04 UTC 2024 - X11 - GLES3 (Compatibility) - AMD Radeon RX 7600 (radeonsi, navi33, LLVM 17.0.6, DRM 3.57, 6.9.3-3-MANJARO) () - AMD Ryzen 5 5600G with Radeon Graphics (12 Threads)
Issue description
when I print 	print_debug(player.get_children())
I see
[Head:<Node3D#30349984988>, CollisionShape3D:<CollisionShape3D#30400316699>]
but player.find_child("Head") returns null
Steps to reproduce
Node3D [Car]

Camera3D

CharacterBody3D [Player]

Node3D [Head]

Camera3D

move the CharacterBody3D to the Car (Player.get_parent().remove_child(Player) and Car.add_child(Player))
and set the active camera to Cars camera (not required)
then move Player back to root
try to find Head Player.find_child("Head") -> result is null.
Minimal reproduction project (MRP)
later

Does it work with find_child("Head", "", true, false)?

find_child("Head", "", true, false) says too many arguments, but it works like this (I suppose that what you meant to check): find_child("Head", true, false)

Meant find_children my bad, but yes find_child("Head", true, false)

got it, I checked also other variants:
find_child("Head", false, false) - works
find_child("Head", true, false) - works
find_child("Head", true, true) - doesn't
find_children("Head", "", false, true) - doesn't
find_children("Head", "", false, false) - works

Then it's expected, you haven't set the owner, the last argument filters only for owned nodes:

If owned is true, only descendants with a valid owner node are checked.

I see, thank you very much @AThousandShips !
IMO: I have to say that it's counterintuitive. I never before was setting owner and it's unclear why it's true by default in find_child.
it is very contradicting when you clearly see it in the tree but find_child gives you null result nevertheless it IS still a child and it is in the tree but the owner is not set...
if so player.get_children() should also give null result and have a owned argument otherwise it's misleading.

Please open a proposal for that, this is not a bug, but the argument can't be changed to false by default without breaking compatibility so won't happen in 4.x I'd say

The owner is reset on changing the parent, everything works as designed, so it's something to discuss as a proposal for changing behaviour, not something that's broken or a bug, see here, if you want the owner to be preserved use reparent instead


Styles output representation in README

I saw something in some of code snippets in README.md. e.g. in glamorousComponentFactory section
In this code snippet:
const UnstyledComp = ({ className, children }) => <div className={`${className} other-class`}>{children}

const MyStyledComp = glamorous(UnstyledComp)({ margin: 1 })

<MyStyledComp>content</MyStyledComp>
// rendered output: <div class="<glamor-generated-class> other-class">content

// styles applied: {margin: 1}

This part is unclear:
// styles applied: {margin: 1}

When we are applying styles with CSS classes and not with JS objects, why we should represent applied styles with objects? In reality the styles applied are like this margin: 1px; not {margin: 1}. This is what we are passing in to get that out.

You're right, that could be more clear.
If you'd like to make a PR to update the README, that'd be great. It'd be great to also change it on the coming glamorous website. You can change it for the website here: https://github.com/kentcdodds/glamorous-website/blob/master/pages/api/content/glamorous-component-factory.md

I'd love to @paulmolluzzo. I will do it tomorrow.


Icons not showing up on Firefox

Hello, I'm tryng to use Freelance template for a simple html project. The template works fine with Chrome and Edge (didn't try Safari yet), but Firefox appearently can't load the star icon in the divider and the "+" icon that should appear on the portfolio items when the mouse is over them. The issue is not caused by some editin on the code, since it also happens with the original template. I'm running Firefox Quantum 68.0.1, updated it a few days ago.
Could anyone please help me? I'm not super skilled, I just know some HTML and CSS, so please rmember this when answering.
Thank you very much!

Hi, I experience almost the same problem over here with Firefox (60.9.0 ESR).
The star and the magnifier (what you called "+" sign)  icons are actually characters from "Font Awesome" font family, corresponding to the codes "\f005" and "\f00e" respectively.
What I did

installed Hugo 0.57.2
added freelancer theme git submodule add URL PATH
copied config.toml & projects/ from the example site
tested it locally hugo server -D
generated the website hugo
uploaded files to the remote server via ftp

What I expect
To see the same result on the remote server as I got with the local server, namely the star & magnifier icons.
What I get
In my case, with Firefox for GNU+Linux Desktop, I noticed two behaviors

on the local server at "localhost:1313" everything is well displayed, I can see the star and magnifier, behaving as intended.
on the remote server, different characters are displayed instead of the two icons (as shown on the pictures).

Workaround
One work around would be to make images (.png) of the two icons and load them, instead of relying on the font package.
Origin of the problem
I wonder if this has to do with freelancer theme, because I get the same odd display when I visit FontAwesome's website and search for these two icons.
Image 1: the magnifier icon is missing, and replaced by something else

Image 2: the star icon is missing, and replaced by something else

It looks like this was either an issue with Font Awesome or a previous version of the theme. I just tested in Firefox and it looks like the icons are working fine. I am thinking that this was fixed whenever Font Awesome was updated, possibly in the Font Awesome 5 update. Closing this since I don't see any problems in Firefox at the moment. If it's happening in Hugo, it would be a compatibility issue between Font Awesome and Hugo which would be outside the scope of this project.


Reorganization of the design of property groups

Description of the enhancement requested
Originally, property groups were only used to find COPYBOOKs / INCLUDEs to display them in the editor.
Subsequently, information on build options has been introduced, which is problematic as expressed in our other requests (# 97, # 98).
Due to the multiplication of informations managed in property groups, it is necessary to multiply groups.
The current shema separates the "local" and "mvs" declarations, which forces all other properties to be repeated identically in separate groups.
It might have been better to combine the "local" and "mvs" declarations in the same group sharing the same other properties.
The organization of a property-groups could approach this proposal (zapp.yaml format):
property-groups:
  - name: property-group-name
    language: cobol
    scope:
      - programs:
        - "path-and-mask-filter-1"
        - "path-and-mask-filter-2"
      - branches:
        - "name-mask-filter-1"
        - "name-mask-filter-2"
    compileOptions: option1, option2
    - type: local
      syslib:
      - "** / COPYBOOK"
      - "** / INCLUDES"
    - type: mvs
      syslib:
      - "HLQ1.SYSLIB.COBCOPY"
      - "HLQ2.SYSLIB.COBCOPY"
      libraries:
       - name: MYFILE
         locations:
         - "HLQ1.MYFILE.COPY"
         - "HLQ2.MYFILE.COPY"

New and modified properties:

scope: property group selection mechanism for a set of programs and / or set of Git branches,
programs: array of selection filters based on the name and location of the programs in the Workspace
branches: array of selection filters based on Git branch name
type: becomes an array
syslib: becomes a sub-property of the type
libraires: becomes a sub-property of the type

Scoping of the property groups we have discussed as well, but felt that we have to explore more use cases to get it right.
Branches would not be part of such scoping as we would rather expect different versions of the zapp file in respective branches. This should be orthogonal to zapp as we would not want to assume users using a specific SCM either.

For us, the build is conditioned by two types of information:

the nature of the program, which determines the compilation procedure and linkedit,
the target deployment environment.

The target deployment environment is determined by the Git branch used.
The compilation and linkedit procedure is determined by the characteristics of the program.
The zapp file being in principle shared, each merge between branches would replace one version by another ... or else the zapp file would have to be ignored from Git tracking, which would oblige each developer to redefine it in their Workspace, (with all the risks errors that this implies).


Get and set object values by path

Background
This came up in #18 as an implementation detail, but I think it's incredibly useful in its own right.
Sample use cases and prior art:

Mavo.subset()
Lodash’s set() and unset() functions (and their various permutations)
Underscore’s get()
Bliss’s $.value()

I pushed two util functions a few days ago (getByPath() and setByPath() but I think we should clean up the code, make it more flexible, and expose at the top level.
Some design decisions, requirements, questions below.
Signature
Function names
I’m leaning towards the simple get() and set() that are already established in prior work. Is there anything else we may want to save the names get() and set() for?
Arguments
Strawman:

get(obj, path [, options])
set(obj, path, value [, options])

Might be worth to later have overloads that allow specifying value, path as part of the options object, but don't see compelling motivation to include that in the MVP.
Should there be a way to set value via a function that takes the path and current value as parameters? Or is it encroaching too much into transform() territory at this point?
Path structure
Data type
Paths should be provided as arrays, we don’t want to deal with string parsing and trying to distinguish paths from property names. Strings/numbers should be accepted as well, but they’re just a path of length 1.
We may want to also support objects to provide additional metadata (see below).
Predicates
It seems obvious that entirely literal paths will not suffice (at the very least we need wildcards).
Should we just use JSON Path?  First it's overkill for these use cases, and second once you go beyond literal property names + wildcards, the syntax becomes cryptic AF. And despite its complexity, there are some pretty common use cases like case insensitivity it doesn’t seem to support.
So since we can’t just use JSON Path, what do we use? What predicates do we want to support? Examples:

Wildcards (any property at this level)
Case-insensitive property names?
Alternatives? (e.g. "foo or bar")
Ranges of numbers? (e.g. "top 3 items")
Property queries (e.g. "get items with id=foo") — essentially the path version of CSS :has(), so we'd probably want to frame it that way, i.e. "children that match this path", so I’ll call them child queries from now on
Property names that start/end with a given string?
Property name regex?

We generally want to keep the MVP simple until use cases emerge, but it helps to take these things into account at the design stage so that the API has room to expand.
As mentioned above, wildcards are certainly needed.
Case-insensitive matching might be worth to include in the MVP, since at least the Mavo use cases need it.
The rest we can probably ship without and add as needed.
Syntax for predicates
So that begs the question, how do we express these predicates?
Special syntax. This works decently for some of them:

Wildcards: *
Alternatives: foo|bar
Number ranges: 0-3 or 0 .. 3
Property queries: id=foo

However, but there is no obvious fit for any of the others. Also, inventing a new microsyntax has several drawbacks:

The larger the syntax space for special syntax, the more challenging to distinguish it from literal property names. How do you do the escaping? Backslashes? How do you distinguish a literal "\*" property then? More backslashes? It's backslashes all the way down!
Devs would need to use string concatenation when the criteria is variable, which is awkward. E.g. Mavo paths support property queries like id=foo and I now think that's a terrible idea and we dropped that kind of support from get() (it's now only supported in mv-path, which being an HTML attribute it only takes strings so it can't take anything more structured).
It forces you to come up with syntax for things where there is no obvious syntax to use, resulting in a cryptic language.

So instead, I think we should go with an approach of strings for literals + wildcards as the only exception, since these are very common and have a very obvious syntax. Anything else would require making that part of the path an object literal.
This means even if we only ship wildcard as the only predicate, we need to support object literals at least to escape that and specify that something is a literal property name. If we have that escape hatch, we could in the future explore more options to add syntax for certain things where a readable syntactic option is obvious, as a shortcut (e.g. "foo|bar" for alternatives)
Predicate schema
Strawman for all of the above predicates (even though we don't plan to implement them all):

Path: string | (string | PathSegment)[]
PathSegment: Object with keys (all optional):

name: Literal property name (string) but maybe could also be a RegExp?
ignoreCase (boolean)
range: Numerical range (number[2] or {from, to} or even {gt, gte, lt, lte}?)
or: Alternatives ((string | PathSegment[]))
has: Return only children for which this would be non-empty (Path)
startsWith
endsWith
regexp

Notes:

ignoreCase is special. All other criteria are independent, but ignoreCase affects how other criteria work, i.e. is a modifier rather than a predicate:

name: from strict equality to equality after .toLowerCase()
regexp: Adds the i flag if not present
startsWith/endsWith: applies .toLowerCase() before matching
or and has: inherits to any path segments that don't have their own ignoreCase
Are there any other modifiers that we may conceivably want to support in the future (so we can take them into account in the design)?

Multiple independent criteria can be specified, and the result is the intersection. This way, since we already have or complex logical criteria can be created by just nesting these. 😁
Should we also handle arrays as sugar for {or: array}?

How do predicates work with set()?
Setting is only an issue for the last part of the path — until then it's still a getting task.
So if the last part of the path is a…

Wildcard: Set every property that exists?
Alternatives: Set every property among the alternatives or only those that already exist on the object?
Numerical ranges: set every number in the range?
Child queries: 🤷🏽♀ Replace these objects with the value?
Regexps or Starts/ends with: 🤷🏽♀🤷🏽♀🤷🏽♀

Return value

One ore more values? For static paths, there can only be a single return value. However, when predicates are involved, there could be multiple, and it's impossible to tell whether one or more values are expected.
Array or object subset?: when returning multiple values, how much of the original object structure do we want to preserve? There are use cases for getting a completely flat array, and use cases for subsetting the object, i.e. using the path as an allowlist of properties while preserving the original object structure.

Following the design principle that function return values should not vary wildly based on the options passed, perhaps we actually need more than just a single get() function:

get(): Array of all values
first(): First value only
subset(): Subset of object

Or perhaps get() for one value and getAll() for multiple?
Options for the whole path
These will be passed to the functions as part of the options dictionary.

Case insensitive matching (when we want it for the whole path)
set() only: What object to create when part of the path doesn’t exist? {} by default. Might be useful to take a function to customize based on the path.
We definitely don't want to throw if the path doesn't exist, since avoiding that is one of the primary reason to use such a helper. Is there value in having an opt-in to stricter handling?

Here are some of my thoughts on everything above:

Function names

I also think these are the simplest applications of getting and setting, just getting and setting arbitrary nodes, so I'm on board with get and set as names, I'm not sure if there are any other applications that they would fit better in as a name.

Or perhaps get() for one value and getAll() for multiple?

I like this so that we're not returning a single node in the generic case and an array in the case where wildcards/other more complex operations were involved.

How do predicates work with set()?

I think by default set should only set paths if they exist, including the case where a wildcard/other expression comes into play, then it should set all matching and existing paths. Then we can allow an optional param, something along the lines o.setNonexistent, which would enable an author to tell us to set a path even if it does not exist.
But now that I'm thinking about it, setting a non-existent path is challenging because we do not know for sure how to add nodes to their tree structure. For example, what if their node is a custom class? We couldn't simply create objects/properties to create this path. So we'll have to think about this case more. Maybe this is a sign that this may be a use case that we should wait on verifying that we need need to support it?

Predicate schema

I like the idea of having this since it provides flexibility to add new operations and features in the future, and would allow us to start with simple and common usecases first and add new ones as they arise

Let’s start simple. Paths are arrays with values:

string | number: wildcard or property name
{} (empty object): same as wildcard
{name: string | number}: literal name (i.e. {name: "*"} is not a wildcard).

Thoughts?

Wrt setting, the idea is we'd use {} as a default, but users can customize it

Let’s start simple. Paths are arrays with values:

string | number: wildcard or property name
{} (empty object): same as wildcard
{name: string | number}: literal name (i.e. {name: "*"} is not a wildcard).

Thoughts?

I like it, it's simple and easy to understand

@LeaVerou A few more clarifying points on get before implementing:

Should this function be calling context.getChildProperties in the case of a wildcard?
Should this function be checking that a key in the path is actually a valid key of that node (i.e. checking that context.isNode(node[key])) before exploring further?
In the case where node is something like {left: {name: "leaf1"}, right: {name: "leaf2"}}, and path is ["*", "nonexistentKey"], should it return [] since after the wildcard nothing matched nonexistentKey (meaning the path was not valid)?
In the case where there are no wildcards in the path, and the path does not exist, should it return undefined or null?

Just wanted to get your opinion on these things, for 1-3, my answer would be yes, it should do those things, and for 4, I would lean toward returning undefined.

After thinking about this some more, I wonder if we could get rid of all this complexity and just have an array of properties that point to one or more children. The nodes that have a single children property (or whatever it's called) are basically special cases of how children work in ASTs, since there you have nodes that point to single children OR arrays of children.
The only wart is how to figure out whether node[childProperty] points to a single child node or a data structure containing many children, but that's what isNode() is for!

After thinking about this some more, I wonder if we could get rid of all this complexity and just have an array of properties that point to one or more children. The nodes that have a single children property (or whatever it's called) are basically special cases of how children work in ASTs, since there you have nodes that point to single children OR arrays of children. The only wart is how to figure out whether node[childProperty] points to a single child node or a data structure containing many children, but that's what isNode() is for!

I like this idea much better than having a wildcard operator and all the complex syntax for defining it versus "*" as a standard key

So if I'm understanding your idea correctly, get would look like function get(node, path) where path is Array<string | number>, and among those properties could be something like children, where itself is not a node, but contains node since it's either an object or an array, in which case we'd return all of them.
For set(node, path, value), it would be similar, except one question I have is what to do if the path ends with a type that's not a node but contains them, for example, path = ["children"]. In this case, should it set all nodes inside children to value?

It means get() and set() are not on the critical path any more.

@adamjanicki2 what happened with this? Being able to set how to get from parent to children in a more generic way is pretty essential.

@adamjanicki2 what happened with this? Being able to set how to get from parent to children in a more generic way is pretty essential.

What does this mean? Are you referring to general set/get functions or something else?


Feature/manage instance service

This is an optional setting to manage the db2 instances service with systemd. It is disabled by default to retain backward compatibility to previous configurations.

Ok, never mind, I just fixed it in the current PR. I also added the possibility to set the service ensure and enable parameters per instance. The service is enabled by default to make sure it starts up on server reboot, but puppet does not try to start it by default (so it does not interfere with maintenance etc).
Please let me know if there are additional concerns.

@crayfishx is it possible that we can get this PR merged and a new release? Let me know if there is anything missing.


Upgrade python version in official tensorflow docker image

Using docker image from tensorflow official website
https://www.tensorflow.org/install#run-a-tensorflow-container
Installs python2.7 default, which is planned to be deprecated near in future.

DEPRECATION: Python 2.7 will reach the end of its life on January 1st, 2020. Please upgrade your Python as Python 2.7 won't be maintained after that date. A future version of pip will drop support for Python 2.7. More details about Python 2 support in pip, can be found at https://pip.pypa.io/en/latest/development/release-process/#python-2-support

This issue is  request to provide updated python version with docker image.

@rabinandan
Please, go through the below link and see if it helps you.Thanks!
https://github.com/tensorflow/tensorflow/issues/30057

Yes, It helped me.
Thank You.

Are you satisfied with the resolution of your issue? Yes No


[Storage] [Blobs] Updated Changelog to include disposing stream made from wrapping BinaryData on Upload

Updating Changelog to reflect changes in this PR https://github.com/Azure/azure-sdk-for-net/pull/44510

API change check
API changes are not detected in this pull request.


⚠ Jenkins Plugins Artifactory has degraded performance

In 5b3081b, Jenkins Plugins Artifactory (https://get.jenkins.io/plugins/artifactory/) experienced degraded performance:

HTTP code: 200
Response time: 1254 ms

Resolved: Jenkins Plugins Artifactory performance has improved in acd4ff6 after 12 minutes.


Added commentary on example advanced

I am working on the commentary of the advanced example.  I'll see where I can get to, and then I'll ask someone to review the commentary.
@nielsenmb I'll also need to check that the .ipynb pulls through into the docs well.  Is there a docs compile command that needs to be run to check this?
@ojhall94 Could you look over the stuff I have written already on lightkurve?
TODO:

[ ] Explain KDE prior
[ ] Explain asy_peakbag
[ ] Explain peakbag
[ ] Add comparison with literature values.
[ ] Spell check

Anyone got advice on spell checking markdown?

If you install the latest version of Sphinx you can check if it compiles
locally.
For RTD you need to make sure that the imported packages (numpy, scipy
etc.) are in the requirements.txt file in the PBjam root directory,
otherwise readthedocs can't find the packages. RTD will automatically build
a new version after you make a commit/merge.
So far the only issue I have had with notebooks is if they are corrupted
(e.g. due to mistakes during conflict resolution), then Sphinx and RTD get
stuck with no error messages when they're building the html. If your ipynb
runs fine locally it should also run fine on RTD.
On Thu, 18 Jul 2019 at 09:58, Guy Davies<EMAIL_ADDRESS>wrote:

I am working on the commentary of the advanced example. I'll see where I
can get to, and then I'll ask someone to review the commentary.
@nielsenmb https://github.com/nielsenmb I'll also need to check that
the .ipynb pulls through into the docs well. Is there a docs compile
command that needs to be run to check this?
@ojhall94 https://github.com/ojhall94 Could you look over the stuff I
have written already on lightkurve?
TODO:

Explain KDE prior
Explain asy_peakbag
Explain peakbag
Add comparison with literature values.
Spell check

Anyone got advice on spell checking markdown?
You can view, comment on, or merge this pull request online at:
https://github.com/grd349/PBjam/pull/110
Commit Summary

Added commentary on example advanced - more to come

File Changes

M docs/example-advanced.ipynb
https://github.com/grd349/PBjam/pull/110/files#diff-0 (195)

Patch Links:

https://github.com/grd349/PBjam/pull/110.patch
https://github.com/grd349/PBjam/pull/110.diff

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/grd349/PBjam/pull/110?email_source=notifications&email_token=AEJWO36CHJQLP5UKP6UHJRDQAAWC3A5CNFSM4IEYOU22YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4G76JKWA,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEJWO374FO66JUPIF3XZHHDQAAWC3ANCNFSM4IEYOU2Q
.

I'm just going through, fixing typos, checking stuff, improving minor things.
.ipynb's don't vibe well with merging I think. Ill try and push this fast so theres no conflicts.

Done, looks good and runs through for me!

Oops nope, I get an error with pbag.sample:
TypeError: function() got an unexpected keyword argument 'tolerance'

This could be a Theano thing--- I'm running 1.0.4. I don't know if this is an easy fix, should I open a separate issue?

Oops nope, I get an error with pbag.sample:
TypeError: function() got an unexpected keyword argument 'tolerance'

This could be a Theano thing--- I'm running 1.0.4. I don't know if this is an easy fix, should I open a separate issue?

I forgot to take that out.  Funny - it ran for me and just ignored it as if a kwarg.  Not sure why yours is different but it can be taken out anyway.  (did you set advi=True?)

Nope, just ran the example notebook as it appears in the branch. Weird! I'm on Python 3.7.3, could be a Python thing.

I got this error too just now.
Only when running example-star though, example-session works fine...

Please could you review and do a quick spell check for me :)


Check username and password

Hi there,
I want to use your project for controlling the bot via a Discord embed. But when I enter my username and password, which are 100% correct, the error says it's wrong.
Is this about Aternos blocking access? Or can someone help me out with this?

channel = self.bot.get_channel(1183762570776162344)
        client = Client()
        client.login(username='jensbierpens', password='notmyrealpassword')

        aternos = client.account

        servers = aternos.list_severs()
        server = None
        for i in servers:
            if i.subdomain == 'armandtest123':
                server = i

        print(server)

I'm now getting this error by just restarting.

Will this be getting fixed?

Same error

I'm now getting this error by just restarting.
Will this be getting fixed?

I think it flagged aternos's bot check and it couldnt pass the cloudflared bot check so it got blocked


Trivial: Fix declaration/implementation mismatches

Reviews: @josh-ripple, @ximinez

Looks innocent enough. :+1:

Where's the beef?

I see what you did there. Obviously correct - compare to the declarations in LedgerHistory.h.
:+1:


callback for stylesheet loaded

Currently I can add a tier, and that will call Tier.init(), which may retrieve a remote stylesheet.
In my case, I add some tiers, then want to call retrieve Tier Data on it and then render it. However, by the time it is calling Kspace.startFetchesFor, the stylesheet may not be downloaded, which cases an early exit.
if (styleFilters)
    wantedTypes = styleFilters.typeList();

...
if (wantedTypes === undefined) {
return false;
}
Is there any way we can make this wait for stylesheet to be retrieved first?
Another option is to abstract the creation of the Tier to the rendering of it, similar to how we did  abstracted the tier data retrieval to its rendering. At the moment, the tier creation ends up calling:                 tier.browser.refreshTier(tier);
This can be changed to adding a callback.
I could do this by changing:
Browser.prototype.addTier = function(conf) {
to
Browser.prototype.addTier = function(conf, callback) {
where the callback is optional, and it will default to the default refresh renderer.
If I get a callback on adding Tiers (when the stylesheet is loaded), then I can manage when to call to retrieve the data.
Let me know if you have any other ideas.

The reason we've got this somewhat-nasty state machine is that some back ends have the ability to filter features e.g. by type (primarily DAS, but there are other uses for this stuff as well), so it's important to get the stylesheet before initiating any fetches.
What I'd ideally like to see would be "headless tiers" (along the lines of what we've discussed previously) implemented with their own class(es), which can fetch stylesheets or not as they choose (I guess with the stylesheet-fetching code factored out a bit).  That's probably not something to rush, though.
A quick solution might be, when creating dummy tiers to support your feature fetches, to bypass the stylesheet fetching process entirely.  The easy way to do this would be to include a minimal JSON stylesheet within the tier configuration, e.g.:
     b.addTier({
           name: 'dummy',
           bwgURI: '/foo.bw',
           style: [{type: 'default, style: {glyph: 'BOX'}}]
    });

This should be installed during tier creation without any async shenanigans, and you're ready to go.
If this doesn't work for you then certainly go ahead and add the callback to notify when the tier is ready, but do mark it as a temporary thing, since it seems like it's making the async problems worse, not better.

Actually, rather than taking a callback when creating a tier, why not return a Promise instead (which will yield the newly-constructed Tier once it's ready)?

OK great, I'm actually using promises already in my code (for the callback in my fix) anyway to determine when the tier stylesheets have been loaded. So I'll move the promise to Dalliance instead. I guess something like this will be needed even when the tier is headless, if the backend can filter by features. Thanks.

Just clarifying that this change will be 'api' breaking. Currently Browser.prototype.addTier returns a Tier object. I'll make it return a Promise that resolves the new tier (once stylesheet is loaded).