Cherry-picks for 1.11.2 release

Going through all of the candidate commits and (especially) bumps for 1.11.2.
This must not be merge-squashed!

?
!

🔵
There is a matching commit with the same subject; this was probably correctly cherry-picked but not detected

🟥
Don't cherry-pick New major features and changes, project website, github actions not run on branch

🔶
In progress, to verify

🟢
Do cherry-pick Version bumps for CVE and fixes, bug fixes, minor release improvements

⚔🟢
Do cherry-pick (merge conflict)

🔥
Follow-up JIRA maintenance

master

Commit
Subject

131f2c503b
Preparing for 1.12.0-SNAPSHOT (#1356)
🟥 Version specific

6c2e3700b6
AVRO-3241 [Java] Publish SNAPSHOT artifacts (#1385)
🟥 Version specific

13de1f06ea
Merge branch 'fd-remove-redundant-generic-hints' of https://github.com/Fokko/avro into Fokko-fd-r...
??? Probably unnecessary

d5b85d820f
Merge branch 'Fokko-fd-remove-redundant-generic-hints'
???

5b003cba08
AVRO-3242 Add config for TravisCI on Linux ARM64 (#1380)
🟥 TravisCI only

2e68b3ff4f
Minor non-functional cleanup.
🟥 Mistaken commit immediately reverted

4209b14b87
AVRO-2624 Revert casting to super type
🟥 Revert of below

6603e7777e
AVRO-3285: Upgrade JavaCC plugin and library (#1447)
🔵34e75a3995

bdb7fadefe
Bump commons-cli from 1.4 to 1.5.0 in /lang/java (#1470)
🔵Bump 4b60d817a0

100574019b
AVRO-3344 Deprecating DataBlock (#1494)
🟥 C# Delete file

18d74959d7
AVRO-3345 Made Magic readonly in DataFileConstants (#1495)
🟥 Improvement

5d2f01a1ea
The dotnet stuff isn't installable via deb packages on aarch64/arm64. Use the dotnet installer to...
???

443614c12a
Adjust how dotnet stuff is added to Docker container, add browserify since we claim to support it...
???

11595499d6
AVRO-3386: [PHP] Pin composer to a common version 2.2.5 (#1532)
???

d7f9b9072c
Fix a typo in javadoc
🟥 Unimportant

9b83acd4c7
Bump reload4j from <IP_ADDRESS> to 1.2.19 in /lang/java (#1556)
🔵Bump 065fb7d721

a5ba8b4452
Bump Mockito to 4.3.1
🔵Bump f89c79dff3

5a8c87a96d
Update from the Ubuntu repositories before installing the dependencies
???

ad585c29ef
AVRO-3388: Extra codecs in C# (#1536)
🔵b796146cf4

bdbb2a0379
AVRO-3431: CI: Cancel in-progress workflows if there are new commits in PR (#1577)
🔵307adc0c3a

9cd3c0e6df
Bump grpc.version from 1.44.0 to 1.44.1 in /lang/java (#1572)
🔵Bump ae77f72f93

7ec12f99c3
Bump netty-bom from 4.1.72.Final to 4.1.74.Final in /lang/java (#1581)
🔵Bump dcb2b06e84

a4e42112ce
Bump grpc.version from 1.44.1 to 1.45.0 in /lang/java (#1612)
🔵Bump 26daa9e937

d44ed5ae2f
Bump jetty.version in /lang/java (#1633)
🟥 Bump (superceded to jetty.version 9.4.50)

fee1a73979
Add an entry for Rust to Github keywords/labels
🟥 Unnecessary

387f497285
AVRO-3487: Update Jackson to <IP_ADDRESS> (#1640)
🔵94bbb7bcaf

f0b183f277
Configure Dependabot to check for Rust updates daily
🟥 (GitHub actions Rust)

8cc6650d6d
Bump zstd-jni from 1.5.1-1 to 1.5.2-2 in /lang/java (#1663)
🔵Bump<PHONE_NUMBER>

64c8da735d
Bump grpc.version from 1.45.0 to 1.45.1 in /lang/java (#1671)
🔵Bump 25cc1b6f85

76e55d8775
AVRO-2870: Avoid throwing from destructor in DataFileWriterBase (#921)

95440c4c5b
AVRO-3510: Do not hardcode the PHP Composer installer Sha384 in TravisCI (#1678)
🟥 TravisCI only

e429672ba6
Bump maven-bundle-plugin from 5.1.4 to 5.1.6 in /lang/java (#1699)
🔵Bump b015fe3a22

285858f7d9
Bump netty-bom from 4.1.75.Final to 4.1.77.Final in /lang/java (#1694)
🔵Bump c290e1da80

b821b223c6
Bump hadoop-client from 3.3.2 to 3.3.3 in /lang/java (#1697)
🔵Bump 872038d4da

5ad0008486
Bump jackson-bom from <IP_ADDRESS>20326 to 2.12.7 in /lang/java (#1703)
🔵Bump fff979a316

051249634a
AVRO-3530: Rust: Use dependency-review-action for Rust (#1714)
🟥 (GitHub actions Rust)

a8ee8778df
AVRO-3534: Rust: Use dependency-review-action only for pull_request events (#1717)
🔵440ab18b09

5a80e32e6b
AVRO-3076: Fix incorrect Javadoc regarding custom coder defaults (#1715)
🔵87778e6c56

5af6e43fa0
Bump netty-bom from 4.1.77.Final to 4.1.78.Final in /lang/java (#1724)
🔵Bump 77258c88c9

e42a570fe5
Bump jetty.version in /lang/java (#1737)
🔵Bump 96de1933d9

2c80b563a3
AVRO-3589: Update github actions versions (#1789)
🟥 (GitHub actions bumps)

816f025d3c
Bump actions/setup-node from 2 to 3 (#1791)
🟥 (GitHub actions JS bump)

e9c10d552c
Bump github/codeql-action from 1 to 2 (#1792)
🟥 (GitHub actions C# bump)

7c99739a40
Bump postcss-cli from 9.1.0 to 10.0.0 in /doc (#1754)
🟢 Bump

7825226b1d
Add myself to the list of committers (#1808)
🟥 (Project-only website)

e233f2ff89
AVRO-3623: Update the PR template (#1851)
🟥 (GitHub PR template)

859645d4a5
AVRO-3628: [Java] JUnit 4.x tests are not executed (#1863)
🔵d75abd5915

eb2b19d0e0
AVRO-3624: Add apache links (#1870)
🟥 (Headers/Footers, so maybe?)

8e965fae15
Bump commons-text from 1.9 to 1.10.0 in /lang/java (#1898)
🔵Bump 8e8a547cb8

77692d8c14
Bump actions/setup-dotnet from 2 to 3 (#1899)
🟥 (GitHub actions C#/Java bump)

1027938c46
AVRO-3639: Add fleet.toml and .cargo/config.toml to gitignore
🟢 Clean-up on build

627b005493
AVRO-3644: handle java.util.Optional as a nullable value (#1915)
🟥 New feature 1.12.0

5a0fb0ffce
Update blog to invite Martin Grigorov (#1865)
🟥 (Project-only website)

016323828f
AVRO-3650: [C++] Fix build on Manjaro (#1920)
🟥 New feature marked 1.12.0

efb977928a
Bump commons-compress from 1.21 to 1.22 in /lang/java (#1943)
🟥 Bump (Merged with ant)

edd59e166c
Bump jackson-bom from <IP_ADDRESS>21012 to 2.14.0 in /lang/java (#1944)
🟢 Bump

73d208fa64
AVRO-3653: [CI] Remove Travis-ci config files (#1948)
🟥 TravisCI only

e93a2ab345
Bump actions/dependency-review-action from 2 to 3 (#1958)
🔵Bump c68b531839

41fb846ec3
Bump mockito-core from 4.8.1 to 4.9.0 in /lang/java (#1976)
🔵Bump e8556562d6

b8937526d3
Bump Maven plugin versions and maven version for the docker based build (#1983)
⚔🟢 Bump

44d32c001c
Bump jackson-bom from 2.14.0 to 2.14.1 in /lang/java (#1987)
🟢 Bump

e3dc0ea60d
AVRO-3670: Add NET 7.0 support (#1956)
⚔🟢 (priority) Asked on JIRA AVRO-3670

95acbd5c43
Bump jetty.version in /lang/java (#2007)
🔵Bump bb40b2a025

5016cd5c3f
Fix minor warnings from rust 1.66.0 (#2018)
🔵280326e51a

cd6eb11335
docs: fix small error (#2025)
🟥 (Project-only website)

43b5d7e3c1
Bump mockito-core from 4.9.0 to 4.10.0 in /lang/java (#2021)
🔵Bump e261852e9e

12fdbc55ab
AVRO-3697: [ruby] Test against Ruby 3.2 (#2041)
🔵5d940daac9

b1de7a6a1b
Bump mockito-core from 4.10.0 to 4.11.0 in /lang/java (#2044)
🔵Bump f8c49a0961

62f45ecc90
AVRO-3696: Replace tox-wheel with standard tox (#2040)
🔵787df564b1

05099c3263
AVRO-3278: [ruby] Drop support for Ruby 2.6 (#2045)
🟥 Asked not to backport on JIRA

6743a41d33
AVRO-3611: fix generator

08adf9140f
AVRO-3611: update comment

bf8cde0f66
AVRO-3611: add constants

c28dbe9f7d
AVRO-3649: default for union inside union

e4e1633077
AVRO-3579: JUnit5 migration step 2

b2aeb2adbc
AVRO-3579: change comment

27eaf7038b
AVRO-3527: Optim hashcode

1f7bfc4470
avro-3527: GenericData, extract hashcode logic in inner class

0dcb351689
AVRO-3701 Add github action to validate maven 4 build compatibility (#2036)
🟢 (GitHub actions workflow, but also pom.xml)

be4c37a9eb
Add myself to the list of committers (#2047)
🟥 (Project-only website)

82fc40bbc5
AVRO-3700: Publish Java SBOM artifacts with CycloneDX
🟢

a7ad5ac585
AVRO-3700: Move CycloneDX configuration to Java specific project (#2049)
🟢

8f06f2b5a0
Bump cyclonedx-maven-plugin from 2.7.3 to 2.7.4 in /lang/java (#2051)
🟢 Bump

ee27a1fa9c
Bump ant from 1.10.12 to 1.10.13 in /lang/java (#2059)
🔵Bump 976ecbe950

41e330a14a
Bump maven-checkstyle-plugin from 3.2.0 to 3.2.1 in /lang/java (#2071)
🔵Bump 5b1e1ebc4f

d22e55501c
Bump maven-plugin-plugin from 3.6.4 to 3.7.1 in /lang/java (#2070)
🔵Bump 026129ac4c

9b7230210c
Bump maven-surefire-plugin from 3.0.0-M7 to 3.0.0-M8 in /lang/java (#2067)
🔵Bump 3d2761da15

d2083c340d
Bump jackson-bom from 2.14.1 to 2.14.2 in /lang/java (#2069)
🟢 Bump

52d670f72d
AVRO-3712: Fix build by initializing union (#2079)
🟢

1998f9ee81
AVRO-3701: Bump Maven 4 to 4.0.0-alpha-4
🟥 (GitHub actions Java bump)

5d9fbb286f
AVRO-3701: Bump Maven 4 to 4.0.0-alpha-4
🟥 (GitHub actions Java bump)

12adf0bc57
AVRO-3715: [Java] Oracle JDK 18 no longer exists
🟥 (GitHub actions Java)

f84392d47c
AVRO-3715: [Java] CycloneDX is not reproducible by design.
🟥 (GitHub actions Java)

0b17623c1c
AVRO-3715: [Java] plugin-tools-javadoc 3.7.0 does not exist.
🟢 (priority) (🔥Ping PR#2178)

ebeeebb4da
Bump maven-enforcer-plugin from 3.1.0 to 3.2.1 in /lang/java
🟢 Bump

2d54b9ea5b
Bump netty-bom from 4.1.87.Final to 4.1.89.Final in /lang/java
🟥 Bump already merged with 34ac34942a

f3cd30131b
Bump zstd-jni from 1.5.2-5 to 1.5.4-1 in /lang/java
🟢 Bump

35f531d16e
Bump snappy-java from <IP_ADDRESS> to <IP_ADDRESS> in /lang/java
🟢 Bump

5883a4d9e6
Bump grpc.version from 1.52.1 to 1.53.0 in /lang/java
🟢 Bump

6459ec00bf
[C++] Fix compiler warnings
🟢

74bd287cff
AVRO-3715: [Python] Fix lint issues (reformat code).
🟢 (priority) (🔥Ping PR#2178)

72e38dc8ff
AVRO-3715: [Python] Fix type issues
🟢 (priority) (🔥Ping PR#2178)

ad5cf6857e
AVRO-3713: [Java] Fix Map synchronization regression
(🔥 Missing Fix Version)

fa0bb70980
AVRO-3717: [Java] Fix NPE when basic type with Nullable annotation.
(🔥 Missing Fix Version)

30c4cbfde5
AVRO-3690: [Java] Fix flaky test ‘testMultipleFieldAliases’
(🔥 Missing Fix Version and Assigned to)

101048de5b
AVRO-3684: [Java] testAppendStream test
🟥 Commit and revert

8565b87c12
Revert "AVRO-3684: [Java] testAppendStream test" (#2108)
🟥 Commit and revert

2a246049ac
AVRO-3690: Fix spotless problem (#2107)
See above

536dcc35c2
AVRO-3690: [Java] Fix testMultipleFieldAliases test (#2109)
See above

0f4cdc0cb9
AVRO-3718: [Java] Fix flaky NettyServer test (#2110)
🟥 (🔥 Missing Fix Version)

dd4385ba2a
Bump cyclonedx-maven-plugin from 2.7.4 to 2.7.5 in /lang/java (#2112)
🟢Bump

95fec21c31
Bump maven-surefire-plugin from 3.0.0-M8 to 3.0.0-M9 in /lang/java (#2114)
🔵Bump 879620925b

5548c9dff7
Bump protobuf-java from 3.21.12 to 3.22.0 in /lang/java (#2111)
🔵Bump 34ac34942a

e7d9be91ef
AVRO-2404: Remove now obsolete Apache Rat workaround (#2119)
🟢 (if it cherry-picks)

2231b77a61
Bump maven-plugin-plugin from 3.7.1 to 3.8.1 in /lang/java (#2127)
🟢 Bump

b6eb0f7794
Bump zstd-jni from 1.5.4-1 to 1.5.4-2 in /lang/java (#2126)
🟢 Bump

389fb2acb1
Bump plexus-utils from 3.5.0 to 3.5.1 in /lang/java (#2125)
🟢 Bump

b9fd71a730
Bump jetty.version in /lang/java (#2122)
🟢 Bump

197a0ecaa0
AVRO-2943 improve GenericRecord MAP type comparison
🟢 (🔥 Ping on JIRA)

c2e6e13194
AVRO-3721: add method to JsonProperties
🟥 New feature

5c0b17dec3
AVRO-2943 Add new GenericData String/Utf8 ARRAY comparison test (#2137)
🟢 (🔥 Ping on JIRA)

b6178acc7a
Bump maven-surefire-plugin from 3.0.0-M9 to 3.0.0 in /lang/java (#2151)
🔵Bump 91fee3d854

ace4d5d2e5
AVRO-3264: Improvements to the project section of the Avro website (#2145)
🟥 Project website

5acb6d619b
Bump grpc.version from 1.53.0 to 1.54.0 in /lang/java
🟢 Bump

a8d5f1b562
Bump hadoop-client from 3.3.4 to 3.3.5 in /lang/java
🟢 Bump

5f4f406dc3
Bump netty-bom from 4.1.89.Final to 4.1.90.Final in /lang/java
🟢 Bump

96c2d8419e
Bump reload4j from 1.2.24 to 1.2.25 in /lang/java
🟢 Bump

4fbd448fec
Add RollForward prop (#2162)
🟥 New feature

8e0513c95d
Bump maven-enforcer-plugin from 3.2.1 to 3.3.0 in /lang/java
🟢 Bump

6bdd8b2fd8
Bump netty-bom from 4.1.90.Final to 4.1.91.Final in /lang/java
🟢 Bump

7aca93124e
Bump cyclonedx-maven-plugin from 2.7.5 to 2.7.6 in /lang/java
🟢 Bump

0c53710f51
Bump extra-enforcer-rules from 1.6.1 to 1.6.2 in /lang/java
🟢 Bump

6f0692f965
Add NET 7 SDK to Dockerfile (#2193)
⚔🟢 Yes (priority)

1b67705bfd
Bump maven-plugin-plugin from 3.8.1 to 3.8.2 in /lang/java
🟢 Bump

327ce13cc4
Bump maven-checkstyle-plugin from 3.2.1 to 3.2.2 in /lang/java
🟢 Bump

842e192ccd
Bump zstd-jni from 1.5.4-2 to 1.5.5-2 in /lang/java
🟢 Bump

0b5859adce
Bump cyclonedx-maven-plugin from 2.7.6 to 2.7.7 in /lang/java
🟢 Bump

3b6c6cc43d
Bump jackson-bom from 2.14.2 to 2.15.0 in /lang/java
Bump 🟥 Reverted later

96cd2074a6
Bump cyclonedx-maven-plugin from 2.7.7 to 2.7.8 in /lang/java
🟢 Bump

61b5c17703
Bump junit5.version from 5.9.2 to 5.9.3 in /lang/java
🟢 Bump

c0a06b6c88
Bump netty-bom from 4.1.91.Final to 4.1.92.Final in /lang/java
🟢 Bump

15bda5f0a8
Bump grpc.version from 1.54.0 to 1.54.1 in /lang/java
🟢 Bump

6c900f41a0
Bump protobuf-java from 3.22.2 to 3.22.3 in /lang/java
🟢 Bump

61e74e5927
AVRO-3737: fix memcheck test (#2213)
🟢 Yes (priority)

c8eec97dd0
Bump maven-surefire-plugin from 3.0.0 to 3.1.0 in /lang/java
🟢 Bump

7f8a3813ea
Bump protobuf-java from 3.22.3 to 3.22.4 in /lang/java
🟢 Bump

f7ad78b4d5
Revert "Bump jackson-bom from 2.14.2 to 2.15.0 in /lang/java"
🟥 Revert

c2ae949a16
AVRO-3747: [Rust] Set is_human_readable hint to false for Value (#2202)
🔵107c903fac

1b9b0858e6
AVRO-3759: Add extra types for RecordSchema, EnumSchema, FixedSchema and DecimalSchema (#2241)
🔵47fd3b600d

fc6af3dde7
Bump protobuf-java from 3.22.4 to 3.23.1 in /lang/java (#2246)
🟢 Bump

aa1b878a7c
Bump zstd-jni from 1.5.5-2 to 1.5.5-3 in /lang/java (#2244)
🟢 Bump

2919020ddf
Bump maven-gpg-plugin from 3.0.1 to 3.1.0 in /lang/java (#2218)
🟢 Bump

493188cd62
Bump grpc.version from 1.54.1 to 1.55.1 in /lang/java (#2229)
🟢 Bump

3dbf0a0409
AVRO-3736: [Ruby] Preinstall gems in ubertool docker (#2191)
🟢 Yes (priority)

57f1d52784
AVRO-3766: [Rust] Print friendlier errors when test cases fail (#2263)
🔵1969b8f51d

79e5033578
AVRO-3766: [Rust] Fix the formatting
🔵54b426a4bb

24fa855db6
Bump protobuf-java from 3.23.1 to 3.23.2 in /lang/java (#2259)
🟢 Bump

cc094e5b70
Bump extra-enforcer-rules from 1.6.2 to 1.7.0 in /lang/java (#2267)
🟢 Bump

ace5ffd0d9
Bump zstd-jni from 1.5.5-3 to 1.5.5-4 in /lang/java (#2279)
🟢 Bump

087672e526
Bump snappy-java from <IP_ADDRESS> to <IP_ADDRESS> in /lang/java (#2255)
🟢 Bump

43c39e45b5
Bump cyclonedx-maven-plugin from 2.7.8 to 2.7.9 in /lang/java (#2243)
🟢 Bump

167ca07375
Bump build-helper-maven-plugin from 3.3.0 to 3.4.0 in /lang/java (#2233)
🟢 Bump

53ad6c4cc6
Bump netty-bom from 4.1.92.Final to 4.1.93.Final in /lang/java (#2256)
🟢 Bump

branch-1.11

Commit
Subject

622343fdc7
Preparing for 1.11.0
🟥 Version specific

b9977c7b3a
Preparing for release 1.11.1
🟥 Version specific

4b60d817a0
Bump commons-cli from 1.4 to 1.5.0 in /lang/java (#1470)
🔵Bump bdb7fadefe

34e75a3995
AVRO-3285: Upgrade JavaCC plugin and library (#1447)
🔵6603e7777e

065fb7d721
Bump reload4j from <IP_ADDRESS> to 1.2.19 in /lang/java (#1556)
🔵Bump 9b83acd4c7

fa8938faef
AVRO-3273: Support older versions of maven

f89c79dff3
Bump Mockito to 4.3.1
🔵Bump a5ba8b4452

b796146cf4
AVRO-3388: Extra codecs in C# (#1536)
🔵ad585c29ef

307adc0c3a
AVRO-3431: CI: Cancel in-progress workflows if there are new commits in PR (#1577)
🔵bdbb2a0379

ae77f72f93
Bump grpc.version from 1.44.0 to 1.44.1 in /lang/java (#1572)
🔵Bump 9cd3c0e6df

dcb2b06e84
Bump netty-bom from 4.1.72.Final to 4.1.74.Final in /lang/java (#1581)
🔵Bump 7ec12f99c3

26daa9e937
Bump grpc.version from 1.44.1 to 1.45.0 in /lang/java (#1612)
🔵Bump a4e42112ce

94bbb7bcaf
AVRO-3487: Update Jackson to <IP_ADDRESS> (#1640)
🔵387f497285

8847826577
Bump zstd-jni from 1.5.1-1 to 1.5.2-2 in /lang/java (#1663)
🔵Bump 8cc6650d6d

25cc1b6f85
Bump grpc.version from 1.45.0 to 1.45.1 in /lang/java (#1671)
🔵Bump 64c8da735d

b015fe3a22
Bump maven-bundle-plugin from 5.1.4 to 5.1.6 in /lang/java (#1699)
🔵Bump e429672ba6

c290e1da80
Bump netty-bom from 4.1.75.Final to 4.1.77.Final in /lang/java (#1694)
🔵Bump 285858f7d9

872038d4da
Bump hadoop-client from 3.3.2 to 3.3.3 in /lang/java (#1697)
🔵Bump b821b223c6

fff979a316
Bump jackson-bom from <IP_ADDRESS>20326 to 2.12.7 in /lang/java (#1703)
🔵Bump 5ad0008486

87778e6c56
AVRO-3076: Fix incorrect Javadoc regarding custom coder defaults (#1715)
🔵5a80e32e6b

77258c88c9
Bump netty-bom from 4.1.77.Final to 4.1.78.Final in /lang/java (#1724)
🔵Bump 5af6e43fa0

440ab18b09
AVRO-3534: Rust: Use dependency-review-action only for pull_request events (#1717)
🔵a8ee8778df

96de1933d9
Bump jetty.version in /lang/java (#1737)
🔵Bump e42a570fe5

3a9e5a789b
Preparing to build 1.11.1
🟥 Version specific

ecdeda8fd9
Preparing for release 1.11.2
🟥 Version specific

a60b748c16
AVRO-3001 AVRO-3274 AVRO-3568 AVRO-3613: Add JSON encoder/decoder for C#
🔥 Needs to be reverted?

d75abd5915
AVRO-3628: [Java] JUnit 4.x tests are not executed (#1863)
🔵859645d4a5

8e8a547cb8
Bump commons-text from 1.9 to 1.10.0 in /lang/java (#1898)
🔵Bump 8e965fae15

c68b531839
Bump actions/dependency-review-action from 2 to 3 (#1958)
🔵Bump e93a2ab345

e8556562d6
Bump mockito-core from 4.8.1 to 4.9.0 in /lang/java (#1976)
🔵Bump 41fb846ec3

bb40b2a025
Bump jetty.version in /lang/java (#2007)
🔵Bump 95acbd5c43

280326e51a
Fix minor warnings from rust 1.66.0 (#2018)
🔵5016cd5c3f

e261852e9e
Bump mockito-core from 4.9.0 to 4.10.0 in /lang/java (#2021)
🔵Bump 43b5d7e3c1

5d940daac9
AVRO-3697: [ruby] Test against Ruby 3.2 (#2041)
🔵12fdbc55ab

f8c49a0961
Bump mockito-core from 4.10.0 to 4.11.0 in /lang/java (#2044)
🔵Bump b1de7a6a1b

787df564b1
AVRO-3696: Replace tox-wheel with standard tox (#2040)
🔵62f45ecc90

976ecbe950
Bump ant from 1.10.12 to 1.10.13 in /lang/java (#2059)
🔵Bump ee27a1fa9c

5b1e1ebc4f
Bump maven-checkstyle-plugin from 3.2.0 to 3.2.1 in /lang/java (#2071)
🔵Bump 41e330a14a

026129ac4c
Bump maven-plugin-plugin from 3.6.4 to 3.7.1 in /lang/java (#2070)
🔵Bump d22e55501c

3d2761da15
Bump maven-surefire-plugin from 3.0.0-M7 to 3.0.0-M8 in /lang/java (#2067)
🔵Bump 9b7230210c

879620925b
Bump maven-surefire-plugin from 3.0.0-M8 to 3.0.0-M9 in /lang/java (#2114)
🔵Bump 95fec21c31

34ac34942a
Bump protobuf-java from 3.21.12 to 3.22.0 in /lang/java (#2111)
🔵Bump 5548c9dff7

91fee3d854
Bump maven-surefire-plugin from 3.0.0-M9 to 3.0.0 in /lang/java (#2151)
🔵Bump b6178acc7a

107c903fac
AVRO-3747: [Rust] Set is_human_readable hint to false for Value (#2202)
🔵c2ae949a16

47fd3b600d
AVRO-3759: Add extra types for RecordSchema, EnumSchema, FixedSchema and DecimalSchema (#2241)
🔵1b9b0858e6

1969b8f51d
AVRO-3766: [Rust] Print friendlier errors when test cases fail (#2263)
🔵57f1d52784

54b426a4bb
AVRO-3766: [Rust] Fix the formatting
🔵79e5033578

can https://github.com/apache/avro/pull/1961/files#diff-81e6b7f1817db3ef20759b0621e9ef232e5fbbd818cd61fa1ee748dc8750a2d1 be included?

@tooptoop4 I think it is: https://github.com/apache/avro/commit/b2185451bb942048ff443fa6dcd3d83ab2403dce

OK, it's only been 24h, but I really want to get this moving -- I've rebased and pushed these changes to branch-1.11, so we can start finalising the remaining open PRs and JIRA.  If I've made a mistake, we can always revert!  Thanks.


Clarify prebuilt Windows installation instructions.

Closes #1643
Closes #1636

I'd tweak the phrasing a little bit, but good to clarify these things!

Suggestions on specific tweak @killerswan ?

@killerswan updated. merge if you are happy with em.

Hmm.  The first link goes to a page with Visual Studio 2017 -- https://www.visualstudio.com/vs/community/ -- though I don't know (a) if that works too or (b) where to download a free 2015.

Maybe @kulibali or someone has tried 2017?
Otherwise LGTM now!

@killerswan hmmm... those are the links we already had. :(

Alright well, I think this is good to merge and we can always improve more.

@kulibali should "2015" in the README be changed to "2015 or later"?

I haven't tried 2017 yet; it's on my todo list.

I'm going to merge this then and we can improve later as needed or if @kulibali comes up with better language.


[TEST] Add clone method checks

Ensure when a step meta is cloned, that it contains all of the same information as XML or Repository serialization.

http://wingman.pentaho.com:8080/job/wingman/18/

This wingman job failed ^^

http://wingman.pentaho.com:8080/job/wingman/20/

http://<IP_ADDRESS>:8080/job/wingman/41/

Build Commands:
Build:

ant -Dtestreports.dir=bin/reports/unit-test -Djunit.jvmargs=-XX:PermSize=256m -f engine/build.xml clean-all resolve jacoco && ant -Dpentaho.coding.standards.version=1.0.4 -Dtestreports.dir=bin/reports/integration-test -Djunit.jvmargs=-XX:PermSize=256m -f engine/build.xml jacoco-integration checkstyle publish-local

Cleanup:
rm -r ~/.ivy2/local || echo no publish local to remove
Changed files:
engine/test-src/org/pentaho/di/job/entry/loadSave/LoadSaveTester.java
engine/test-src/org/pentaho/di/trans/steps/loadsave/LoadSaveTester.java
Unit test coverage change:
org.pentaho.di.core.auth.core.impl.DefaultAuthenticationConsumerFactory:

Branch Change : -7.14%
Complexity Change : -7.69%

org.pentaho.di.job.entries.abort.JobEntryAbort:

Complexity Change :  + 5.88%
Instruction Change :  + 3.14%
Line Change :  + 3.77%
Method Change :  + 6.25%

org.pentaho.di.job.entries.addresultfilenames.JobEntryAddResultFilenames:

Complexity Change :  + 1.69%
Instruction Change :  + .68%
Line Change :  + 1.18%
Method Change :  + 4.76%

org.pentaho.di.job.entries.checkfilelocked.JobEntryCheckFilesLocked:

Branch Change :  + 1.39%
Complexity Change :  + 1.75%
Instruction Change :  + 1.10%
Line Change :  + 1.85%
Method Change :  + 4.76%

org.pentaho.di.job.entries.connectedtorepository.JobEntryConnectedToRepository:

Complexity Change :  + 3.45%
Instruction Change :  + 1.47%
Line Change :  + 2.27%
Method Change :  + 5.26%

org.pentaho.di.job.entries.copyfiles.JobEntryCopyFiles:

Branch Change :  + .62%
Complexity Change :  + .82%
Instruction Change :  + .47%
Line Change :  + .85%
Method Change :  + 2.38%

org.pentaho.di.job.entries.copymoveresultfilenames.JobEntryCopyMoveResultFilenames:

Complexity Change :  + .85%
Instruction Change :  + .36%
Line Change :  + .58%
Method Change :  + 1.89%

org.pentaho.di.job.entries.createfile.JobEntryCreateFile:

Complexity Change :  + 3.23%
Instruction Change :  + 1.28%
Line Change :  + 1.89%
Method Change :  + 5.00%

org.pentaho.di.job.entries.createfolder.JobEntryCreateFolder:

Complexity Change :  + 3.85%
Instruction Change :  + 1.64%
Line Change :  + 2.41%
Method Change :  + 6.25%

org.pentaho.di.job.entries.delay.JobEntryDelay:

Complexity Change :  + 3.70%
Instruction Change :  + 1.69%
Line Change :  + 2.44%
Method Change :  + 5.56%

org.pentaho.di.job.entries.deletefile.JobEntryDeleteFile:

Complexity Change :  + 3.45%
Instruction Change :  + 1.45%
Line Change :  + 2.17%
Method Change :  + 5.56%

org.pentaho.di.job.entries.deletefiles.JobEntryDeleteFiles:

Branch Change :  + 1.25%
Complexity Change :  + 1.64%
Instruction Change :  + 1.06%
Line Change :  + 1.78%
Method Change :  + 4.76%

org.pentaho.di.job.entries.deletefolders.JobEntryDeleteFolders:

Branch Change :  + 1.02%
Complexity Change :  + 1.35%
Instruction Change :  + .92%
Line Change :  + 1.53%
Method Change :  + 4.00%

org.pentaho.di.job.entries.deleteresultfilenames.JobEntryDeleteResultFilenames:

Complexity Change :  + 2.78%
Instruction Change :  + 1.26%
Line Change :  + 1.96%
Method Change :  + 4.76%

org.pentaho.di.job.entries.dostounix.JobEntryDosToUnix:

Branch Change :  + .50%
Complexity Change :  + .73%
Instruction Change :  + .47%
Line Change :  + .80%
Method Change :  + 2.78%

org.pentaho.di.job.entries.filecompare.JobEntryFileCompare:

Complexity Change :  + 1.96%
Instruction Change :  + .93%
Line Change :  + 1.46%
Method Change :  + 4.76%

org.pentaho.di.job.entries.fileexists.JobEntryFileExists:

Complexity Change :  + 4.55%
Instruction Change :  + 2.08%
Line Change :  + 2.90%
Method Change :  + 6.25%

org.pentaho.di.job.entries.folderisempty.JobEntryFolderIsEmpty:

Complexity Change :  + 2.86%
Instruction Change :  + 1.26%
Line Change :  + 1.82%
Method Change :  + 4.55%

org.pentaho.di.job.entries.folderscompare.JobEntryFoldersCompare:

Complexity Change :  + 1.08%
Instruction Change :  + .44%
Line Change :  + .75%
Method Change :  + 3.33%

org.pentaho.di.job.entries.ftpput.JobEntryFTPPUT:

Complexity Change :  + .83%
Instruction Change :  + .32%
Line Change :  + .52%
Method Change :  + 1.75%

org.pentaho.di.job.entries.ftpsget.FTPSConnection:

Branch Change : -1.56%
Complexity Change : -1.37%
Instruction Change : -.23%

org.pentaho.di.job.entries.ftpsput.JobEntryFTPSPUT:

Complexity Change :  + 1.18%
Instruction Change :  + .42%
Line Change :  + .70%
Method Change :  + 2.13%

org.pentaho.di.job.entries.mailvalidator.JobEntryMailValidator:

Complexity Change :  + 3.12%
Instruction Change :  + 1.22%
Line Change :  + 1.82%
Method Change :  + 4.76%

org.pentaho.di.job.entries.movefiles.JobEntryMoveFiles:

Branch Change :  + .25%
Complexity Change :  + .37%
Instruction Change :  + .23%
Line Change :  + .41%
Method Change :  + 1.54%

org.pentaho.di.job.entries.msgboxinfo.JobEntryMsgBoxInfo:

Complexity Change :  + 4.55%
Instruction Change :  + 2.54%
Line Change :  + 3.23%
Method Change :  + 5.26%

org.pentaho.di.job.entries.pgpverify.JobEntryPGPVerify:

Complexity Change :  + 2.70%
Instruction Change :  + 1.28%
Line Change :  + 1.87%
Method Change :  + 4.76%

org.pentaho.di.job.entries.ping.JobEntryPing:

Complexity Change :  + 1.85%
Instruction Change :  + .68%
Line Change :  + 1.17%
Method Change :  + 4.35%

org.pentaho.di.job.entries.sendnagiospassivecheck.JobEntrySendNagiosPassiveCheck:

Complexity Change :  + 1.41%
Instruction Change :  + .61%
Line Change :  + .90%
Method Change :  + 2.50%

org.pentaho.di.job.entries.simpleeval.JobEntrySimpleEval:

Complexity Change :  + .43%
Instruction Change :  + .20%
Line Change :  + .32%
Method Change :  + 2.08%

org.pentaho.di.job.entries.snmptrap.JobEntrySNMPTrap:

Complexity Change :  + 1.96%
Instruction Change :  + .61%
Line Change :  + .97%
Method Change :  + 2.94%

org.pentaho.di.job.entries.sql.JobEntrySQL:

Complexity Change :  + 1.64%
Instruction Change :  + .82%
Line Change :  + 1.29%
Method Change :  + 3.85%

org.pentaho.di.job.entries.syslog.JobEntrySyslog:

Complexity Change :  + 2.94%
Instruction Change :  + 1.11%
Line Change :  + 1.64%
Method Change :  + 3.70%

org.pentaho.di.job.entries.talendjobexec.JobEntryTalendJobExec:

Complexity Change :  + 3.23%
Instruction Change :  + 1.15%
Line Change :  + 1.82%
Method Change :  + 4.76%

org.pentaho.di.job.entries.telnet.JobEntryTelnet:

Complexity Change :  + 4.17%
Instruction Change :  + 1.69%
Line Change :  + 2.50%
Method Change :  + 4.76%

org.pentaho.di.job.entries.unzip.JobEntryUnZip:

Complexity Change :  + .40%
Instruction Change :  + .16%
Line Change :  + .30%
Method Change :  + 1.59%

org.pentaho.di.job.entries.waitforfile.JobEntryWaitForFile:

Complexity Change :  + 1.54%
Instruction Change :  + .66%
Line Change :  + 1.09%
Method Change :  + 3.70%

org.pentaho.di.job.entries.webserviceavailable.JobEntryWebServiceAvailable:

Complexity Change :  + 5.00%
Instruction Change :  + 1.84%
Line Change :  + 2.63%
Method Change :  + 6.25%

org.pentaho.di.job.entries.writetofile.JobEntryWriteToFile:

Complexity Change :  + 2.44%
Instruction Change :  + 1.02%
Line Change :  + 1.53%
Method Change :  + 4.17%

org.pentaho.di.job.entries.writetolog.JobEntryWriteToLog:

Complexity Change :  + 3.12%
Instruction Change :  + 1.57%
Line Change :  + 2.41%
Method Change :  + 4.76%

org.pentaho.di.job.entries.zipfile.JobEntryZipFile:

Complexity Change :  + .52%
Instruction Change :  + .20%
Line Change :  + .35%
Method Change :  + 2.04%

org.pentaho.di.repository.kdr.KettleDatabaseRepositoryCreationHelper:

Branch Change :  + 1.64%
Complexity Change :  + .69%
Instruction Change :  + 2.43%
Line Change :  + 3.70%

org.pentaho.di.trans.step.StepMeta:

Instruction Change : -.19%
Line Change : -.27%

org.pentaho.di.trans.steps.autodoc.AutoDocMeta:

Complexity Change :  + 1.89%
Instruction Change :  + .60%
Line Change :  + .99%
Method Change :  + 2.50%

org.pentaho.di.trans.steps.changefileencoding.ChangeFileEncodingMeta:

Complexity Change :  + 3.12%
Instruction Change :  + 1.05%
Line Change :  + 1.63%
Method Change :  + 3.70%

org.pentaho.di.trans.steps.clonerow.CloneRowMeta:

Complexity Change :  + 2.44%
Instruction Change :  + .77%
Line Change :  + 1.47%
Method Change :  + 3.70%

org.pentaho.di.trans.steps.cubeinput.CubeInputMeta:

Complexity Change :  + 3.70%
Instruction Change :  + 1.60%
Line Change :  + 2.22%
Method Change :  + 4.76%

org.pentaho.di.trans.steps.cubeoutput.CubeOutputMeta:

Complexity Change :  + 4.55%
Instruction Change :  + 2.11%
Line Change :  + 2.90%
Method Change :  + 5.26%

org.pentaho.di.trans.steps.delay.DelayMeta:

Complexity Change :  + 3.23%
Instruction Change :  + 1.29%
Line Change :  + 2.25%
Method Change :  + 5.56%

org.pentaho.di.trans.steps.detectlastrow.DetectLastRowMeta:

Complexity Change :  + 5.26%
Instruction Change :  + 2.64%
Line Change :  + 3.70%
Method Change :  + 6.25%

org.pentaho.di.trans.steps.edi2xml.Edi2XmlMeta:

Complexity Change :  + 4.35%
Instruction Change :  + 1.55%
Line Change :  + 2.94%
Method Change :  + 5.88%

org.pentaho.di.trans.steps.excelinput.ExcelInputMeta:

Branch Change :  + .60%
Complexity Change :  + .51%
Instruction Change :  + 2.61%
Line Change :  + 2.30%
Method Change :  + .88%

org.pentaho.di.trans.steps.excelwriter.ExcelWriterStepField:

Complexity Change :  + 3.45%
Instruction Change :  + 3.65%
Line Change :  + 4.00%
Method Change :  + 3.45%

org.pentaho.di.trans.steps.excelwriter.ExcelWriterStepMeta:

Branch Change :  + 2.56%
Complexity Change :  + 1.57%
Instruction Change :  + 1.18%
Line Change :  + 1.27%
Method Change :  + 1.14%

org.pentaho.di.trans.steps.execprocess.ExecProcessMeta:

Complexity Change :  + 2.94%
Instruction Change :  + 1.15%
Line Change :  + 1.72%
Method Change :  + 3.85%

org.pentaho.di.trans.steps.fieldschangesequence.FieldsChangeSequenceMeta:

Complexity Change :  + 2.70%
Instruction Change :  + 3.32%
Line Change :  + 3.94%
Method Change :  + 4.35%

org.pentaho.di.trans.steps.fieldsplitter.FieldSplitterMeta:

Complexity Change :  + 1.67%
Instruction Change :  + 9.23%
Line Change :  + 7.11%
Method Change :  + 2.13%

org.pentaho.di.trans.steps.fileexists.FileExistsMeta:

Complexity Change :  + 3.33%
Instruction Change :  + 1.36%
Line Change :  + 2.02%
Method Change :  + 4.17%

org.pentaho.di.trans.steps.filelocked.FileLockedMeta:

Complexity Change :  + 4.17%
Instruction Change :  + 1.78%
Line Change :  + 2.60%
Method Change :  + 5.00%

org.pentaho.di.trans.steps.filestoresult.FilesToResultMeta:

Complexity Change :  + 5.56%
Instruction Change :  + 3.36%
Line Change :  + 4.88%
Method Change :  + 5.88%

org.pentaho.di.trans.steps.flattener.FlattenerMeta:

Complexity Change :  + 3.70%
Instruction Change :  + 1.30%
Line Change :  + 2.56%
Method Change :  + 5.56%

org.pentaho.di.trans.steps.formula.FormulaMeta:

Branch Change :  + 8.82%
Complexity Change :  + 6.06%
Instruction Change :  + 9.04%
Line Change :  + 7.69%
Method Change :  + 6.25%

org.pentaho.di.trans.steps.formula.FormulaMetaFunction:

Complexity Change :  + 4.35%
Instruction Change :  + 1.76%
Line Change :  + 2.82%
Method Change :  + 4.76%

org.pentaho.di.trans.steps.getfilenames.GetFileNamesMeta:

Complexity Change :  + 1.22%
Instruction Change :  + 3.87%
Line Change :  + 3.04%
Method Change :  + 1.75%

org.pentaho.di.trans.steps.getrepositorynames.GetRepositoryNamesMeta:

Complexity Change :  + 2.63%
Instruction Change :  + 6.11%
Line Change :  + 4.79%
Method Change :  + 3.70%

org.pentaho.di.trans.steps.getslavesequence.GetSlaveSequenceMeta:

Complexity Change :  + 4.55%
Instruction Change :  + 1.74%
Line Change :  + 2.94%
Method Change :  + 4.76%

org.pentaho.di.trans.steps.getsubfolders.GetSubFoldersMeta:

Complexity Change :  + 1.96%
Instruction Change :  + 3.14%
Line Change :  + 3.02%
Method Change :  + 3.03%

org.pentaho.di.trans.steps.jobexecutor.JobExecutorMeta:

Complexity Change :  + .57%
Instruction Change :  + .20%
Line Change :  + .38%
Method Change :  + .96%

org.pentaho.di.trans.steps.mergejoin.MergeJoinMeta:

Complexity Change :  + 2.44%
Instruction Change :  + 4.91%
Line Change :  + 5.93%
Method Change :  + 4.00%

org.pentaho.di.trans.steps.mysqlbulkloader.MySQLBulkLoaderMeta:

Complexity Change :  + 1.06%
Instruction Change :  + 2.19%
Line Change :  + 2.06%
Method Change :  + 1.85%

org.pentaho.di.trans.steps.normaliser.NormaliserMeta:

Branch Change :  + 4.76%
Complexity Change :  + 5.00%
Instruction Change :  + 3.88%
Line Change :  + 4.26%
Method Change :  + 5.26%

org.pentaho.di.trans.steps.normaliser.NormaliserMeta.NormaliserField:

Complexity Change :  + 4.00%
Instruction Change :  + 4.00%
Line Change :  + 4.55%
Method Change :  + 10.00%

org.pentaho.di.trans.steps.numberrange.NumberRangeMeta:

Complexity Change :  + 3.23%
Instruction Change :  + .95%
Line Change :  + 1.63%
Method Change :  + 4.17%

org.pentaho.di.trans.steps.olapinput.OlapInputMeta:

Complexity Change :  + 2.86%
Instruction Change :  + 1.25%
Line Change :  + 1.75%
Method Change :  + 3.57%

org.pentaho.di.trans.steps.randomccnumber.RandomCCNumberGeneratorMeta:

Complexity Change :  + 2.50%
Instruction Change :  + 5.43%
Line Change :  + 5.11%
Method Change :  + 3.57%

org.pentaho.di.trans.steps.randomvalue.RandomValueMeta:

Complexity Change :  + 2.17%
Instruction Change :  + 4.41%
Line Change :  + 5.13%
Method Change :  + 5.00%

org.pentaho.di.trans.steps.replacestring.ReplaceStringMeta:

Complexity Change :  + .96%
Instruction Change :  + 5.96%
Line Change :  + 4.80%
Method Change :  + 2.22%

org.pentaho.di.trans.steps.reservoirsampling.ReservoirSamplingMeta:

Complexity Change :  + 4.35%
Instruction Change :  + 2.69%
Line Change :  + 3.85%
Method Change :  + 6.25%

org.pentaho.di.trans.steps.selectvalues.SelectValuesMeta:

Branch Change :  + 1.55%
Complexity Change :  + 1.47%
Instruction Change :  + 2.10%
Line Change :  + 2.36%
Method Change :  + 2.56%

org.pentaho.di.trans.steps.selectvalues.SelectValuesMeta.SelectField:

Complexity Change :  + 10.00%
Instruction Change :  + 9.76%
Line Change :  + 6.25%
Method Change :  + 10.00%

org.pentaho.di.trans.steps.sortedmerge.SortedMergeMeta:

Complexity Change :  + 2.86%
Instruction Change :  + 5.37%
Line Change :  + 5.56%
Method Change :  + 5.26%

org.pentaho.di.trans.steps.ssh.SSHMeta:

Complexity Change :  + 1.52%
Instruction Change :  + .55%
Line Change :  + .80%
Method Change :  + 2.00%

org.pentaho.di.trans.steps.switchcase.SwitchCaseMeta:

Branch Change :  + 3.85%
Complexity Change :  + 3.17%
Instruction Change :  + 3.17%
Line Change :  + 2.70%
Method Change :  + 2.70%

org.pentaho.di.trans.steps.switchcase.SwitchCaseTarget:

Complexity Change :  + 50.00%
Instruction Change :  + 50.00%
Line Change :  + 33.33%
Method Change :  + 50.00%

org.pentaho.di.trans.steps.symmetriccrypto.symmetriccryptotrans.SymmetricCryptoTransMeta:

Complexity Change :  + 1.85%
Instruction Change :  + .84%
Line Change :  + 1.29%
Method Change :  + 2.56%

org.pentaho.di.trans.steps.textfileinput.TextFileInputMeta:

Branch Change :  + .53%

org.pentaho.di.trans.steps.textfileoutput.TextFileField:

Complexity Change :  + 3.23%
Instruction Change :  + 2.84%
Line Change :  + 3.28%
Method Change :  + 3.23%

org.pentaho.di.trans.steps.textfileoutput.TextFileOutputMeta:

Branch Change :  + 1.69%
Complexity Change :  + 1.34%
Instruction Change :  + 1.15%
Line Change :  + 1.19%
Method Change :  + 1.11%

org.pentaho.di.trans.steps.uniquerows.UniqueRowsMeta:

Complexity Change :  + 2.70%
Instruction Change :  + 5.25%
Line Change :  + 5.22%
Method Change :  + 3.70%

org.pentaho.di.trans.steps.uniquerowsbyhashset.UniqueRowsByHashSetMeta:

Complexity Change :  + 3.45%
Instruction Change :  + 5.16%
Line Change :  + 5.75%
Method Change :  + 4.35%

org.pentaho.di.trans.steps.univariatestats.UnivariateStatsMeta:

Branch Change :  + 7.14%
Complexity Change :  + 5.26%
Instruction Change :  + 6.77%
Line Change :  + 6.25%
Method Change :  + 5.88%

Integration test coverage change:
org.pentaho.di.trans.steps.http.HTTPMeta:

Complexity Change :  + 1.47%
Instruction Change :  + 3.97%
Line Change :  + 3.70%
Method Change :  + 1.96%

org.pentaho.di.trans.steps.httppost.HTTPPOSTMeta:

Complexity Change :  + 1.33%
Instruction Change :  + 4.08%
Line Change :  + 4.09%
Method Change :  + 1.72%

org.pentaho.di.trans.steps.rest.RestMeta:

Complexity Change :  + .98%
Instruction Change :  + 4.01%
Line Change :  + 3.54%
Method Change :  + 1.52%

I love this PR. Well done @matthewtckr


WIP: Set proper account types + pubkeys

2 problems solved with this PR:

Cosmos pubkeys can be stored under EthAccounts. This isn't a problem for the chain but is a problem for Cosmos wallets getting the wrong account type when querying the account number + sequence - they error out despite the value being in the returned type
EVM Txs do not assign a pubkey, but they increment the account's sequence. This is not a problem for the chain but it is confusing and seems like bad behavior

Closed in favor of a branch with a better implementation.


Exclude instantiations from statistics?

A few of the structs in my code #[derive(valuable::Valuable)] from valuable. Those derives show up on the report as not-covered, which is not something I want.
Am I missing something here, or is this not supported?

Sorry, by accident I made this issue in the wrong repository.


LEGO: Pull request from lego/hb_04604851-bac4-4681-9f74-73de611d6e48_20210815033330895 to main

LEGO: Pull request from lego/hb_04604851-bac4-4681-9f74-73de611d6e48_20210815033330895 to main with localized lcls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.003%) to 41.407%

Totals

Change from base Build<PHONE_NUMBER>:
0.003%

Covered Lines:
26401

Relevant Lines:
57845

💛  - Coveralls


3d line display for each layer

Do you have any plan to add 3d layer display in your viewer?
Now each layer is display as a line, it do not look clearly in slices 3d view.

Well I have been playing with thicker lines but ran into issues so I've
parked that for now.
I'd like a real 3d look to be implemented at some point but I cannot say
when I get around to it.
If you, or anyone else, would want to contribute in this area I'd be happy
to help wherever I can.
Op ma 13 jul. 2020 16:33 schreef JIN Tao<EMAIL_ADDRESS>
Do you have any plan to add 3d layer display in your viewer?
Now each layer is display as a line, it do not look clearly in slices 3d
view.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/remcoder/gcode-preview/issues/14, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AADQWUTFJW66W2NU6AWFJBLR3MLNFANCNFSM4OYRNXPA
.


[bug] Fix parsing of latest OLSR jsoninfo format

OLSR jsoninfo plugin has changed the JSON output format in some of the "newer" releases. This adds support for parsing that - while remaining backward compatible.

I've ported the links2 OLSR data into the new format and changed to run every testcase that has been using it to run for both the old and new format. This should give decent test coverage. Hope this is what you were after.

ping @nemesisdesign

Thanks @wnagele :+1:


What game other than CartPole-v0 is the A2C agent good at?

Hi,
I've been working with the a2c example agent you provide, and haven't found any game other than CartPole-v0 that it can learn well. Is there any other game that it is good at?
Thank you so much.
Best,
Karin

Hi, you can try lunarlander for instance. But the hyper-parameters will have to be correctly tuned. In one of our paper, we are using it for ProcGen also.
Keep me in touch
Ludovic

Hi Ludovic,
Thank you so much for your quick reply. Can you also show me which parameters to tune and how to tune them for lunarlander? Thank you very much again!
Best,
Karin

Hi,
I wonder if the Pong example under a2c complete folder works? It seems I need to change the data type of variable "input" (in A2CAtariAgent) to float for it to run, and it still has a value error after running for a short period of time. Thank you very much.
Best,
Karin


Missing FLEXGlobalsRowFileBrowser globalsRow

Missing FLEXGlobalsRowFileBrowser item in FLEX menu - "File Browser"
add
[self globalsEntryForRow:FLEXGlobalsRowFileBrowser],
in

(NSArray<NSArray<FLEXGlobalsTableViewControllerEntry *> *> *)defaultGlobalSections

I have this fixed on another branch. In a couple of days I'll have it all merged into master, keep an eye out. I'll close this issue then.


Avoid duplication of functionality that can be done by Astropy

Some of the functionality implemented in pyregion can be replaced by functionality in astropy. For example, region_numbers.py contains a lot of code for parsing and formatting of sexagesimal coordinates which could probably be replaced by Angle.

This can be closed now that kapteyn is removed, isn't it?

I'm closing this old issue now.
It's probably mostly implemented by #100.
@sargas or @astrofrog - If you still have any specific suggestions for things that can be improved in pyregion by re-using stuff from astropy, please re-open or file a new issue.


Correct typo

Codecov Report

Merging #2054 into master will decrease coverage by 4.58%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2054      +/-   ##
==========================================
- Coverage   51.04%   46.45%   -4.59%
==========================================
  Files         176      172       -4
  Lines       14065    14032      -33
==========================================
- Hits         7179     6519     -660
- Misses       5841     6535     +694
+ Partials     1045      978      -67

Impacted Files
Coverage Δ

cmd/restic/cmd_stats.go
3.73% <ø> (ø)
:arrow_up:

internal/backend/b2/b2.go
0% <0%> (-80.69%)
:arrow_down:

internal/backend/swift/swift.go
0% <0%> (-78.45%)
:arrow_down:

internal/backend/gs/gs.go
0% <0%> (-73.61%)
:arrow_down:

internal/backend/azure/azure.go
0% <0%> (-69.46%)
:arrow_down:

internal/backend/swift/config.go
36.95% <0%> (-54.35%)
:arrow_down:

cmd/restic/cmd_mount.go
12.98% <0%> (-44.16%)
:arrow_down:

internal/archiver/file_saver.go
81.57% <0%> (-4.39%)
:arrow_down:

internal/backend/s3/s3.go
60.15% <0%> (-2.26%)
:arrow_down:

internal/restic/node.go
39.52% <0%> (-1.31%)
:arrow_down:

... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d203ae3...d2ee58f. Read the comment docs.

@fd0 yep, Hacktoberfest


Add ARM build logic

Adds Graviton 2 publishing support to Lambda Extension

LGTM as well (I was able to build both locally)


CI: Lift Kolibri's path to Endless Key app's root path

Endless Key app is composed with an Electron app as the frontend and Kolibri as the backend. Kolibri is installed under the Electron app's src path originally: resources/app/src.
However, Endless Key app's Windows App Cert Kit cannot scan the file whose full path name exceeds length 259. Otherwise, the scan breaks due to exceptions.
So, move Kolibri to Endless Key app's root path. Hope this action ease the length limitation.
https://phabricator.endlessm.com/T34780

I merged in advance!


Clarify the process for decommissioning a pool when the decommission key is from the outside

Currently we support adding a pool decommission key, but the process on how decommissioning works isn't clear. We should solve this before mainnet.

The process as I see it:

The staking wallet generates a message/transaction to be signed (in address, not strictly necessary). Make sure to include the decommission public key in that message. The message can have a enum serialization format so that it can be upgraded. (Maybe with a QR Code)
We copy this message, and paste it in the wallet that owns the decommission key
If no broadcast is enabled (since it's a cold wallet), the user has to copy the result and broadcast it (maybe enable QR Code)

Functions:

authorizepooldecommission (print a message explaining how to proceed)
authorizepooldecommissionandbroadcast

implemented in #1448


Missing header "age" for "valid-for-minute" response in cache filter.

Title: Not getting "age" header for "valid-for-minute" resonse in cache filter.
Description: After 30 sec resending curl request (curl -i localhost:8000/service/1/valid-for-minute) In cache filter for response type "valid-for-minute" not getting age header.
ref : https://www.envoyproxy.io/docs/envoy/v1.17.1/start/sandboxes/cache#valid-for-minute

Describe the issue.

[optional Relevant Links:] https://www.envoyproxy.io/docs/envoy/v1.17.1/start/sandboxes/cache

Any extra documentation required to understand the issue.

Hi @ankatare, First response from service1_1  (curl -i localhost:8000/service/1/valid-for-minute) will contains no age header as expected. After that, any request from service1 will be served cache filter for 60s will have age header.
I have verified the above. Please see service1 log
service2_1     |   stored_response = yaml.load(open('/etc/responses.yaml', 'r')).get(response_id)
service2_1     | <IP_ADDRESS> - - [17/Mar/2021 15:12:00] "GET /service/2/valid-for-minute HTTP/1.1" 200 -
service2_1     | <IP_ADDRESS> - - [17/Mar/2021 15:13:01] "GET /service/2/valid-for-minute HTTP/1.1" 304 -
service2_1     | <IP_ADDRESS> - - [17/Mar/2021 15:13:03] "GET /service/2/valid-for-minute HTTP/1.1" 304 -

Please LMK how you're producing?

Description: After 30 sec resending curl request (curl -i localhost:8000/service/1/valid-for-minute) In cache filter for response type "valid-for-minute" not getting age header.

@mk46 yeah. next and subsequent request < 60 Sec for service_1 should have age header (i.e. cached response).

also it seems working fine now on latest code. Thanks !!!

We can close this now as it is non repro on latest code.


Major refactoring  * reduce the number of classes by using generics where possib

@jmazzitelli sorry that this took so long and sorry, that I have no more time today to rebase and fix the remaining compilation issues. I'd prefer to put more comments into the code before you start a real review but your early comments are welcome too :)

@jmazzitelli 1267d9f is the state where compiles and both unit and itests are passing. I am going to write comments into the code now.

In fb5eabd brings better class and package names and some class movements among packages

There's no many files, git hub won't show me the diff of MonitorService for me to comment on it. But bootStorageAdapter.getUrl() (which is the url attribute of storageAdapter) can be explicitly defined by the user in standalone.xml or not. It used to be "url" was the only way to specify the hawkular server URL, but then we introduced the ability to define the outbound socket binding. So now if you specify the outbound socket binding you don't have to specify URL. In this new code (lines 115 and following) it doesn't seem to take into account that URL might be specified by the user. We actually could take that out of standalone.xml (since really we want to support the "official" way WildFly subsystems should define output connections - and that's with outbound socket bindings, not with URLs) but I think our tests and other things still use the URL attribute. In any event, I think this code no longer works the way it did - what if the user specifies the URL attribute explicitly in standalone.xml - does that still work? (remember, tenantID is NOT specified in his use-case - that is only used when in METRICS only mode - in the standard hawkular mode, the url can be specified, but tenantID is not).
Separately, in the same file, if we are in HAWKULAR mode, you cannot override or set tenantID manually - if the user does, we need to log a warning, and we should override it with what accounts tells us is our tenant ID. If we fail to get a tenantID from accounts, we should error out like we did before or better, maybe we just keep retrying if we failed to connect to accounts (but if we did connect to accounts and just got authentication failure, we need to error out) - the hawkular credentials determines what our tenant ID when in HAWKULAR mode. If the hawkular server can't tell us what our tenant ID is, don't let the user try to hijack or use a tenant ID that isn't confirmed by hawkular server (this is lines 157-194).

About 24572a4 :

rebased on top of the current master
it brings JavaDoc
it brings a little bit better use of type params - e.g. EndpointService now has just three type params compared to five in the previous iterartion.

There's so many files, git hub won't show me the diff of MonitorService for me to comment on it.

Hm... indeed. To work it around I can only think of commenting here, eventually with a link to a line from the given commit, like I do later in this post.

But bootStorageAdapter.getUrl() (which is the url attribute of storageAdapter) can be explicitly defined by the user in standalone.xml or not. It used to be "url" was the only way to specify the hawkular server URL, but then we introduced the ability to define the outbound socket binding. So now if you specify the outbound socket binding you don't have to specify URL. In this new code (lines 115 and following) it doesn't seem to take into account that URL might be specified by the user.
We actually could take that out of standalone.xml (since really we want to support the "official" way WildFly subsystems should define output connections - and that's with outbound socket bindings, not with URLs) but I think our tests and other things still use the URL attribute. In any event, I think this code no longer works the way it did - what if the user specifies the URL attribute explicitly in standalone.xml - does that still work? (remember, tenantID is NOT specified in his use-case - that is only used when in METRICS only mode - in the standard hawkular mode, the url can be specified, but tenantID is not).

Ah, a good catch! I think I have understood how I broke the old logic. The block starting at https://github.com/ppalaga/hawkular-agent/blob/24572a4f46c1e8c90c45fd64b6a5ddfec5d3be98/hawkular-wildfly-monitor/src/main/java/org/hawkular/agent/monitor/service/MonitorService.java#L133
should be executed only if bootStorageAdapter.getUrl() returned null, right?
Fixed here https://github.com/ppalaga/hawkular-agent/commit/cbb4733465b818e0f12834e525a91b8c0405989a#diff-6bc5e02300bbc2e87957a09fae5dc676R133

Separately, in the same file, if we are in HAWKULAR mode, you cannot override or set tenantID manually - if the user does, we need to log a warning, and we should override it with what accounts tells us is our tenant ID. If we fail to get a tenantID from accounts, we should error out like we did before or better, maybe we just keep retrying if we failed to connect to accounts (but if we did connect to accounts and just got authentication failure, we need to error out) - the hawkular credentials determines what our tenant ID when in HAWKULAR mode. If the hawkular server can't tell us what our tenant ID is, don't let the user try to hijack or use a tenant ID that isn't confirmed by hawkular server (this is lines 157-194).

Yes, added both the warning https://github.com/ppalaga/hawkular-agent/commit/cbb4733465b818e0f12834e525a91b8c0405989a#diff-6bc5e02300bbc2e87957a09fae5dc676R201 and the exit https://github.com/ppalaga/hawkular-agent/commit/cbb4733465b818e0f12834e525a91b8c0405989a#diff-6bc5e02300bbc2e87957a09fae5dc676R435

@jmazzitelli 599b952 brings an untested aggregation for DMR. The aggregation for JMX and Platform is missing. I must break now.

@jmazzitelli would you please have a look esp. at the last commit? I hope I did the aggregation logic right.
Otherwise this is ready to be merged from my PoV


Add Unit Converter Activity

Add Unit converter activity to the activities
It will let users convert

Length
Weight
I am working to add more units soon (temprature, digital storage unit, speed etc)

The user interface is kept simple for the sake of accessibility.
Suggestions are welcomed.
Looking forward to adding more such activities soon.

Interesting but I'm not sure to see a pedagogical interest of this activity for children between 6 to 12.
They more learn about a specific unit without needing a conversion.
On weight, an activity to learn how to determine a specific weight using a scaleboard - like in GCompris Scaledboard activity - could be more interesting.

@llaske thank you for giving it a thought. I build this activity for students because as they grow up, they start to know about different units and get curious to know how they all are related to each other. Personally, when I was a kid I used to take my mother's phone to find conversions.
Moreover, some countries use imperial units while some use the metric system so it will be helpful for them to get familiar with them.
Please give this a thought.
I would love to hear your feedback

Conversions could be interesting in a pedagogic activity, it's why I pointed you the Scalesboard activity. But just a converter has no pedagogic value.

@llaske I totally agree with you and I am now working on to make them more interesting and engaging.
I appreciate your help and suggestion

I am closing this PR for now, I will update the activity with interactive and engaging stuff.


Signature sharing across maps

It'd be nice to be able to share signatures across maps.
Use case: tons of farmholes on different maps, would like to know their signatures when we roll into them.

+1 we would love this feature too :)

What I do is lock the holes I want into a corner of the map so if I suddenly have a connection going to that corner the I know I have connected to one of those holes. This is the easiest way to do it and it doesn't take anything extra other than adding the signatures to the map and pinning them. It is very effective and you can have them out of the way, for me it is the lower left corner.

@CalMatar that's not really what we're saying here

@porowns then what are you saying, please explain.

If I have wormhole A on map A, and wormhole A on map B, the signatures are not shared, despite having access to both maps. It would be nice for the signatures to be shared, or a way to share them.

I am still confused by what you mean "shared". If you have multiple maps and you enter information on one map in a signature that information is available on any other map you have that signature on. At least that was the case for the maps that I had prior to me losing my WH. I can not currently log in so I can not test anything at this time but we used to do this on both the public PF and a private server on multiple maps. We had our main hole and several "friend" holes we had pinned that we came across from time to time that the information was only entered into one map but was on all affected maps, or at least I remember it being that way.

the information was only entered into one map but was on all affected maps

Just checked it again - it does not affect other maps ;-). We would like to share intel (structures and free text notes) between maps

^^ can confirm that this is the behavior we have as well.

Is this is on the Public Pathfinder or is this on a private server on separate login maps?

we have that on our self hosted pf too,
if we have 2 maps and on both maps is the same WH and we add signatures on one map its not shown on the other map.

This issue happens when you export a map and import it into another one - signatures are not preserved. Almost defeats the purpose.


Drop 2.11 support

With Ammonite having dropped 2.11 support, almond sticked to 1.6.7 when on scala 2.11. With https://github.com/lihaoyi/Ammonite/pull/990 (coursier used via coursier-interface rather than by the main coursier API), the Ammonite API is going to depart even more from 1.6.7, making the 2.11 build even harder to maintain here.
Maybe dropping 2.11 support could be a good idea. I'll probably remove it soon, unless anyone opposes.

I guess supporting only the latest two major Scala versions is quite reasonable given that Ammonite does the same.

Not so much in context of Spark. Most of people using spark do so in context of hadoop distributions like cloudera or hortonworks and in such case it's not trivial to upgrade spark version to 2.4.x to be able to use Scala 2.12. Dropping 2.11 means almond and spark-ammonite become unusable to everyone who is still bound to Spark <= 2.3 and I guess it's an awful lot of people using Spark at all.

2024 update: 2.12 is now the standard for Spark. 2.13 is optional. Next major version of Spark will move to 2.13 min supported version.
2.11 is gone. Ticket can be closed.


Cloudfront with S3

I have created an application that downloads from the S3 client .
I would now like to make the application download from cloudfront but as far as I can tell cloudfront does not contain methods to help me do this e.g. specify the range or receive the download progress updates.
Does anyone have a clue how one would go about doing this, I was hopping that I would still have to keep my S3 code because it works just need to tell it to download from cloudfront.

Hello,
The cloudfront API is primarily a config/control-plane API rather than a data plane one.  Once configured, you would use regular http requests to pull your data rather than an S3 client.  In theory you could probably use the http client we provide in core for these requests, but there may be some tweaks needed in order to make the requests just right.

Ok thanks for the reply .Looks like I have a lot of work to do, to get my application working the same way as it is while downloading from s3 directly.
I have some other projects so this will have to wait for now, but I will definitely work on it in the future.


Alerts are not being forwarded

None of the alerts are being received by my VPS. Any idea what could cause these issues?

Hi, be sure to take a look at your firewall. You might have to open corresponding ports.

Yes, that was the issue. Thanks a lot for your help!

HI

Ok

Ok

Hola

Hola

Hola

Hola

test

test

test

test

test

test


Strange behavior on insert with returning(*) and case conversions

I've been experiencing some strange behavior when inserting to postgres and performing case conversions going to and from the database.
Please see the test project I have put together: https://github.com/mitchellporter/objectionjs-insert
I have two tests in the linked project. Here is the first one:
it.only('should save to the database BUT returns duplicate snake_case keys for some reason', function (done) {

      JiraAgileBoardVersion
        .query()
        .insert(validJson)
        .returning('*')
        .then(item => {
          console.log('item: ' + util.inspect(item));
          done();
        })
        .catch(err => {
          console.log('error: ' + err);
          done(err);
        });

});

When I run the above code, the insert is successful, but when I log item it has duplicate keys. It will have some snake_case versions of a few keys, and then also have camelCase versions of those same keys. What's strange is when I perform my camel case conversion in $parseDatabaseJson and log the results, everything looks perfect, but then right after that $afterInsert fires and the json now has the duplicate keys.
Here is an example of what item logs as with the duplicate keys. You will notice that there are BOTH snake case and camel case fields for jira_id, board_id, and jira_project_id, when the expected result is to only have camel case fields:
{
  self: 'http://www.example.com/jira/version/10000',
  jira_id: 10000,
  board_id: 1,
  name: 'Version 1',
  description: 'A first version',
  archived: false,
  released: true,
  releaseDate: '2015-04-20T01:02:00.000+10:00',
  jira_project_id: 10000,
  id: 9,
  createdAt: 2017-07-07T01:09:07.991Z,
  updatedAt: 2017-07-07T01:09:07.991Z,
  jiraId: 10000,
  boardId: 1,
  jiraProjectId: 10000,
  rawJson: null
}

You can see all of this by setting up the project and running the tests, I'm logging everything with before and after json results in all of the Model methods.
If you look at the second test I wrote, you'll see that instead of using returning(*), I'm using the less efficient way and performing a second query for the new instance that I just finished inserting. When I log the fetched item in this case the duplicate keys are not there and everything works perfectly.
The only way I've found to fix the first test that uses returning(*) is by manually deleting the unwanted duplicate snake case fields in $afterInsert, but this feels gross and like it's not actually solving the problem.

Also I did notice with a quick search prior to posting this that it looks like someone else was experiencing the same thing: https://github.com/Vincit/objection.js/issues/200
After looking through that , I'm either not understanding the problem/solution, it's slightly different, or the same but not actually being solved.
Also, please let me know if there's anything I can do in the future to make test projects easier to setup and use. I want to make it as easy as possible for you to take a look at this.
As always thanks for the help.

Why are you some snake cased and some camel cased properties to the insert method? Also why do you set snake cased properties in $parseJson? $parseJson is called when a model instance is created from a non-db object. I'm pretty confused about what you are trying to camelize and when...

Your json schema also contains snake cased properties. Are you sending and receiving snake cased json to the outside world from your API? You only want to use camel case in in code but snake case everywhere else? In that case you also need to run camelizeKeys and decamelizeKeys in $parseJson and $formatJson respectively.

Something like this:
class JiraAgileBoardVersion extends Model {
          static get tableName() {
            return 'jira_agile_board_versions';
          }

          static get jsonSchema() {
            return {
              type: 'object',
              required: ['jiraId', 'boardId'],
              properties: {
                self: { type: 'string' },
                jiraId: { type: 'integer' },
                boardId: { type: 'integer' },
                jiraProjectId: { type: 'integer' },
                name: { type: 'string' },
                description: { type: 'string' },
                archived: { type: 'boolean' },
                released: { type: 'boolean' },
                release_date: { type: 'string' },
                rawJson: { type: 'object' }
              }
            };
          }

          $formatDatabaseJson(json) {
            json = super.$formatDatabaseJson(json);
            var new_json =  decamelizeKeys(json);
            return new_json;
          }

          $parseDatabaseJson(json) {
            var new_json = camelizeKeys(json);
            return super.$parseDatabaseJson(new_json);
          }

          $parseJson(json, opt) {
            if (json.id) {
              json.jira_id = json.id;
              delete json.id;
            }

            if (json.projectId) {
              json.jira_project_id = json.projectId;
              delete json.projectId;
            }

            return super.$parseJson(camelizeKeys(json), opt);
          }

          $formatJson(json) {
            return super.$formatJson(decamelizeKeys(json));
          }
        }

I now have it working thanks to your code sample and details thanks.

Your json schema also contains snake cased properties. Are you sending and receiving snake cased json from your API? Do you only want to use camel case in in code but snake case everywhere else? In that case you also need to run camelizeKeys and decamelizeKeys in $parseJson and $formatJson respectively.

I would like to only use snake case for the column names in the database. In our application code, and in all of our json responses to API clients, I would like to use camel case. Sometimes when we receive json payloads from third party services like jira for example, the payload can use camel case or snake case. We don't have control over it.
Most of our models are being created directly from json that's coming from these third party services. Am I correct that if the jira json payload uses camel case, that the model's jsonSchema property should implement camel case as well? This means that I could pass jsonSchema validation, but still fail to save to the database if I don't convert the camel case to snake case to match the db column names.
Does all of that sound right?

Also, if you wouldn't mind offering general advice, have you ever seen a project where snake case is used as the database naming convention, but camel case is used in application code, or does this seem strange to you? I've always just used snake case everywhere for my REST API's, but the team I currently work with prefers to use snake case for db naming and camel case everywhere else, which is why all of these conversions are necessary.
Thanks.

$parseDatabaseJson is only called when parsing database rows into model instances. This method is called as the very first thing.
$formatDatabaseJson is only called when converting model instances to database rows. This method is called as the very last thing.
$parseJson is called whenever a model instance is created (except when creating one from a database row). This is called before validation. Objects passed to insert, update, patch etc. are always converted into model instances first and therefore $parseJson gets called.
$formatJson is called whenever a model is converted into JSON using toJSON() or $toJson. Note that JSON.stringify automatically calls toJSON and for example res.send(model) (express.js) will call JSON.stringify for model.

So yes, if you insert an object with snake_cased properties, you need to either have a conversion in $parseJson or have your jsonSchema properties also in snake_case.
Using snake_cased column names is very common, but I don't know why... There is no good reason to do that and it only causes problems and confusion. Off course sometimes the database already exists and developers don't have control over this, but otherwise I would simply use the same casing in database and code.

@koskimas Thank you for such a detailed replied. I fully understand everything now. Cheers! 🍻


Uncaught Error: Channel has been shut down

Hi @pozil, thanks for all your work on this client!
Today I saw the following issue coming by, when reconnecting to a replayid from a few hours before. In the meantime the schema had slightly changed, since then the client was not able anymore to avro decode the earlier events. These resulted all in clear 'EventParseError' errors; which is for now fine.
But the app still crashed on an uncatched error. I have put the stacktrace below:
/dist/node_modules/salesforce-pubsub-api-client/node_modules/@grpc/grpc-js/src/internal-channel.ts:835
      throw new Error('Channel has been shut down');
      ^

Error: Channel has been shut down
    at InternalChannel.createCall (/dist/node_modules/salesforce-pubsub-api-client/node_modules/@grpc/grpc-js/src/internal-channel.ts:835:13)
    at ChannelImplementation.createCall (/dist/node_modules/salesforce-pubsub-api-client/node_modules/@grpc/grpc-js/src/channel.ts:166:33)
    at getCall (/dist/node_modules/salesforce-pubsub-api-client/node_modules/@grpc/grpc-js/src/client-interceptors.ts:349:24)
    at getBottomInterceptingCall (/dist/node_modules/salesforce-pubsub-api-client/node_modules/@grpc/grpc-js/src/client-interceptors.ts:480:16)
    at <anonymous> (/dist/node_modules/salesforce-pubsub-api-client/node_modules/@grpc/grpc-js/src/client-interceptors.ts:574:7)
    at getInterceptingCall (/dist/node_modules/salesforce-pubsub-api-client/node_modules/@grpc/grpc-js/src/client-interceptors.ts:576:10)
    at ServiceClientImpl.makeUnaryRequest (/dist/node_modules/salesforce-pubsub-api-client/node_modules/@grpc/grpc-js/src/client.ts:312:64)
    at ServiceClientImpl.<anonymous> (/dist/node_modules/salesforce-pubsub-api-client/node_modules/@grpc/grpc-js/src/make-client.ts:189:15)
    at Object.callback (/dist/node_modules/salesforce-pubsub-api-client/dist/client.cjs:943:24)
    at Object.onReceiveStatus (/dist/node_modules/salesforce-pubsub-api-client/node_modules/@grpc/grpc-js/src/client.ts:356:28)

Node.js v20.11.1

Do you know a way this can also be catched into an error event?

Hi @rjruigrok looking at the stack trace that you provided this seems related to the error with custom channel (client fails to retrieve the schema because the custom channel topic doesn't expose a schema ID).
The latest version should address this.

Hi @rjruigrok did the issue persist with the latest client?


add missing repository field

currently npm doesn't link back to the repo/github

Thanks for this!


Cannot access OpenRouter models

Another member of our team is able to access an OpenRouter model using his Python client.  Here are the parameters (in Java-speak).
String userKey = "<user key for openrouter>";
String model = "mistralai/mistral-7b-instruct:free";
String baseURL ="https://openrouter.ai/api/v1/";

Below are two variations of code I have used.  With the above parameters, I get an HTTP 404 when the final line in each variant is executed.  If I use the parameters
      String userKey = "<user key for openai>";
      String baseURL = "https://api.openai.com/";
      String model = "babbage-002";

then both of the following at least get to the point of demanding more money.
This one uses #454
        OkHttpClient okHttpClient = OpenAiService.defaultClient(userKey, Duration.ofSeconds(10));
        Retrofit retrofitX = OpenAiService.defaultRetrofit(okHttpClient, OpenAiService.defaultObjectMapper()).newBuilder()
                .baseUrl(baseURL)
                .build();
        OpenAiApi openAiApi = retrofitX.create(OpenAiApi.class);
        OpenAiService service = new OpenAiService(openAiApi, okHttpClient.dispatcher().executorService());
        System.out.println("\nCreating completion...");
        CompletionRequest completionRequest = CompletionRequest.builder()
                .model(model)
                .prompt("Somebody once told me the world is gonna roll me")
                .echo(true)
                .user("testing")
                .n(3)
                .build();
        System.out.println("\nCompletionRequest built");
        service.createCompletion(completionRequest).getChoices().forEach(System.out::println);
        System.out.println("\nCompletion created");

Here is another one I saw somewhere.
        ObjectMapper mapper = OpenAiService.defaultObjectMapper();
        OkHttpClient client = OpenAiService.defaultClient(userKey, Duration.ofSeconds(30))
                .newBuilder()
                .build();
        Retrofit retrofit = null;
		try {
			retrofit = OpenAiService.defaultRetrofit(client, mapper)
			        .newBuilder()
			        .baseUrl(new URL(baseURL))
			        .build();
		} catch (MalformedURLException e) {
			return;
		}
        OpenAiApi api = retrofit.create(OpenAiApi.class);
        OpenAiService service = new OpenAiService(api);

        System.out.println("\nCreating completion...");
        CompletionRequest completionRequest = CompletionRequest.builder()
                .model(model)
                .prompt("Somebody once told me the world is gonna roll me")
                .echo(true)
                .user("testing")
                .n(3)
                .build();
        System.out.println("\nCompletionRequest built");
        service.createCompletion(completionRequest).getChoices().forEach(System.out::println);

@stevevestal  since this repo had no merge for a long time. I think you can try my repo.


Creating a thread does not survive a refresh

When creating a thread and typing some text if a background refresh occurs, sometimes you loose all the text. This does not happen on other convo buffers due to some careful programming. re-implement that into the create comment refresh

cc @joestringer this is now fixed, thanks for making me aware!


en - Fix typo - Stereo photo setting description

Fix typo in stereo photo setting description.

Good catch, thanks for the fix!


[Question:] How to capture intensity or perceived loudness of a given audio file at regular intervals

If  you are playing a song on your laptop, As you increase the volume from 0 to 100, the audio becomes louder and louder.
Say I have an .mp3 or .wav , how do I capture this ^ perceived loudness/intensity at regular intervals (may be 0.1 second) in the audio using python speech features?
Any advice is appreciated.
Thanks
Vivek

the amplitude of the waveform is the loudness. So so measure the loudness every 0.1 seconds you get the amplitude at that point in time. Maybe you want something else?

Do you mean that Loudness is nothing but Amplitude per second?

Loudness is a perceptual quality of audio related nonlinearly to the audio
waveform. You can approximate it quite well by squaring the time domain
waveform, summing the result and taking the logarithm (cube root can also
work here). If you are interested in rough perceptual loudness per second,
that will do if you sum over 1 second segments of your audio.
On Thu, 29 Dec 2022, 4:35 pm Venkat Sai Subash Panchakarla, <
@.***> wrote:

Do you mean that Loudness is nothing but Amplitude per second?
—
Reply to this email directly, view it on GitHub
https://github.com/jameslyons/python_speech_features/issues/61#issuecomment-1367101731,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAM7KQPL5ZM4XT35RK5CJYTWPUWKHANCNFSM4E7PSCVQ
.
You are receiving this because you modified the open/close state.Message
ID: @.***>


Grayscale images compatibility issue

Hello, when I cloned the repo and tested on the grayscale images, I received error saying "RuntimeError: Given groups=1, weight of size [64, 3, 7, 7], expected input[1, 1, 100, 100] to have 3 channels, but got 1 channels instead"

I misread


knexSnakeCaseMappers for camelCase1

Hi,
Just want to say I appreciate your efforts on this library and I have enjoyed using it thus far!
I have a use case for conversion for a variable like camelCase1 to write to my DB as camel_case_1, however, I'm noticing that the current implementation of snakeCase converts said variable from camelCase1 to camel_case1.
I tried out the lodash implementation of snakeCase which gives me the desired result. Another option that would elicit the desired effect for me would be changing the conditional here from:
if (char === upperChar && upperChar !== lowerChar) { ... }

to:
if (char === upperChar) { ... }

But of course I am not entirely sure of the use cases you have run into and are trying to support on your end.
I tried playing around with configuring knexSnakeCaseMappers but realized that knexIdentifierMappers (which is where I would pass in my own choice of camel/snakeCase functions) is not being exported.
Please let me know what you think, I'd be more than happy to discuss and open a PR based on our conversation!

@dwoowb seems like a good idea.
The current knexSnakeCaseMappers implementation goes like:
1.  If the current character is not an underscore,
    and the previous character is not an underscore,
    the character is pushed to the stack.

2.  If the current character is not an underscore,
    and the previous character *is* an underscore,
    the character is uppercased and pushed to the stack.

3.  If the current character *is* an underscore, it is ignored.

Adding conditions to handle numbers could work. I would wait to see what @koskimas thinks first, though!

I can add a config parameter for this. We need to use this special function instead of for example the lodash functions so that things like joinEager work correctly.

@heisian @koskimas thanks for the quick response! That makes sense @koskimas, yeah that would be great.
Just to make sure I'm on the same page as you, two questions.
Would this mean I would be able to configure knexSnakeCaseMappers to use the snake/camelCase functions of my choosing like lodash for instance?
Two, if functionality like joinEager relies on the current implementation of snakeCase would that mean passing in lodash's _.snakeCase potentially break the joinEager functionality?

@dwoowb You cannot use the lodash version because it behaves in undesired ways with aliases objection uses internally. I can add an option like underscoreBeforeNumbers: true. You would be able to use it like this:
knexSnakeCaseMappers({
  underscoreBeforeNumbers: true
})

Would that work?

Gotcha, yes I think that would fit my use case nicely! Thank you :)

@koskimas not intending to pressure you at all (as it hasn't even been a week yet) but do you have any rough ETA on this? Also, if you'd like to allow me to take a crack at it, it'd be my pleasure :)

@dwoowb sorry for the delay. I'll try to fix this during the nex week.

Hi @koskimas, do you have any updates on this? Please let me know if I can help in any way 😃

@dwoowb I finally found time to fix it. I'll release 1.2.6 in a couple of hours with this fix.

1.2.6 is now released. Give it a go and let me know if it works as you'd expect.

@koskimas that works perfectly, thank you!


build: Add support for Python 3.12

About
By refreshing a few dependencies, the package seems to also work on Python 3.12.
Details
The patch has been validated on behalf of a CI run on another patch.

https://github.com/pyveci/pueblo/pull/47

@amotl Can you merge main into your branch?

Hi Edgar,
I've rebased on top of main, and the outcome was that effectively, none of my changes were needed any longer, and the patch has been amendend correspondingly.
Unfortunately, I can't provide an updates poetry.lock file, because I am still on Poetry 1.6.1, which renders a largely different output. Can I ask you to take over the branch and add an updated poetry.lock file before merging?
With kind regards,
Andreas.

Thanks for merging!


Slider mouse dragging is broken on touch-capable devices

On my touch-enabled laptop running the latest Chrome, Slider responds only to touch dragging and appears to ignore the mouse.
This is due to https://github.com/mikepb/react-draggable/issues/5 and is fixed by https://github.com/mikepb/react-draggable/pull/6, so assuming that PR is accepted, the fix here should be trivial (just update react-draggable2).

@motiz88 Are we still waiting for react-draggable2 to get released?

@motiz88, I think we don't need react-draggable dependency at all. Have a look at my PR https://github.com/callemall/material-ui/pull/1825.

@motiz88  bug was fixed in PR #1825 and merged, please retest and close.


LFS-126: Rename the project

Everything should be tested to make sure that nothing got broken because of all the renames. I didn't test how docker and docker-compose works with the new changes, and if any further edits to the "running with docker" documentation are needed.
Next steps:

rename and move the whole project/repo to data-team-uhn.
rename the JIRA project
update CI and other github actions

Features to be tested:
@IntegralProgrammer

[x] Builds Docker image with mvn clean install
[x] Test Running with Docker - Test/Development Environments from README.md
[x] Test Running with Docker - Production Environments from README.md
[x] Test Running with Docker-Compose from README.md (Oak File System, Sharded Mongo, External Mongo)
[x] Test upgrade_cards_image.py
[ ] Test upgrade_demo_site.sh
[ ] Test Cardiac Rehab manual data export
[ ] Test Cardiac Rehab automated nightly data export
[ ] Test Cardiac Rehab date obfuscation
[x] "CARDS is loading..." splash screen
[ ] Vocabularies Ignore (ignores vocabulary terms when installing from BioPortal)
[ ] LDAP Authentication
[x] demo runMode (Demo warning banner and github Sling user)
[ ] CSV data import
[ ] Form last modified date
[ ] Form completion status

@sashaandjic

[ ] Cardiac Rehab Questionnaires
[ ] "Test" runMode Questionnaires
[ ] Cards4Kids Questionnaires
[ ] Cards4LFS Questionnaires
[ ] Quick Search Bar
[ ] Page Not Found
[ ] Form / Subject Deletion
[ ] Form / Subject Pagination
[ ] Form / Subject Filtering
[ ] Form serializers (.simple.json, .deep.json, etc...)
[ ] Vocabulary installation (from BioPortal, from local files)
[ ] BioPortal API Key setting (from environment variable, from web interface)

@acrowthe

[ ] Cardiac Rehab data import script (cardiac-rehab-resources/clinical-data/util/import.py)
[ ] Cards4Kids data import script (kids-resources/clinical-data/util/heartCentreData.py). Please test with latest version being developed locally as I understand this version is quite different from the one in this (LFS-126) branch.

Next page and Last page buttons on in the selection dialog no longer work.

Next page and Last page buttons on in the selection dialog no longer work.
I also observed this problem in LFS-1234 branch. dev branch is OK.

Unrelated to renaming and fixed by @sdumitriu in #687 .

2 problems with Somatic variants:

Unable to create Somatic variants from patient and tumor charts - the questionnaire isn't listed in the selection dialog

on tumor region chart clicking on a + button gives error

@IntegralProgrammer here is my list with checks

[ ]  Cardiac Rehab Questionnaires
[ ]  "Test" runMode Questionnaires
[ ]  Cards4Kids Questionnaires
[ ]  Cards4LFS Questionnaires
[ ] Quick Search Bar
[ ]  Page Not Found
[ ]  Form / Subject Deletion - logged 2 bugs LFS-1243 and LFS-1244 (resolved in PR
[ ]  Form / Subject Pagination
[ ]  Form / Subject Filtering
[ ] Form serializers (.simple.json, .deep.json, etc...)
[ ]  Vocabulary installation (from BioPortal, from local files)
[ ]  BioPortal API Key setting (from environment variable, from web interface)

[ x]  Cardiac Rehab data import script (cardiac-rehab-resources/clinical-data/util/import.py)
[ x]  Cards4Kids data import script (kids-resources/clinical-data/util/heartCentreData.py). Please test with latest version being developed locally as I understand this version is quite different from the one in this (LFS-126) branch.

Import scripts tested. Will be fully functional once the repo is renamed to cards and moved


State has no primary constructor , App crashing

Hi, I am facing the "State has no primary constructor" crash issue on Release Build. and we initialized all state properly but crashing for some user.  i am using mvrx 1.2.1
Fatal Exception: java.lang.RuntimeException: Unable to start activity ComponentInfo{MainActivity}: java.lang.IllegalStateException: HomeScreenActivityState has no primary constructor!        at android.app.ActivityThread.performLaunchActivity + 2447(ActivityThread.java:2447)        at android.app.ActivityThread.handleLaunchActivity + 2509(ActivityThread.java:2509)        at android.app.ActivityThread.access$900 + 175(ActivityThread.java:175)        at android.app.ActivityThread$H.handleMessage + 1382(ActivityThread.java:1382)        at android.os.Handler.dispatchMessage + 102(Handler.java:102)        at android.os.Looper.loop + 135(Looper.java:135)        at android.app.ActivityThread.main + 5425(ActivityThread.java:5425)        at java.lang.reflect.Method.invoke(Method.java)        at java.lang.reflect.Method.invoke + 372(Method.java:372)        at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run + 928(ZygoteInit.java:928)        at com.android.internal.os.ZygoteInit.main + 723(ZygoteInit.java:723)

The cause of this issue seems to be this line in PersistState.kt
KClass.primaryConstructor property does not work well with proguard. I faced this issue in my own library as well, but was able to work around it by doing: klass.constructors.first(). Not sure if this is the best solution though.

Hi, something new about the solution?

Is there any update about this issue?
I'm facing exactly the same problem, occur in version mvrx 1.3.0 also


Scrollbars don’t respect safe area

If you view Excalidraw on an iPhone X-style device in landscape mode, you’ll notice that the notch and rounded corners cut off parts of the scroll bars. I would like the canvas itself to scroll into the corners of the device because otherwise it would look weird, but the scrollbars should be inset by max(var(--padding), env(safe-area-inset-right)) from the edge to avoid getting cut off.

They also don’t respect the top/bottom bars. They should be appropriately inset.