set-required-approvals@v1 blocking PR after 2 approvals received

Describe the bug
set-required-approvals@v1 blocking PR after 2 approvals received
To Reproduce
Steps to reproduce the behavior:

The .cm automation file

.cm automation file
# -*- mode: yaml -*-

manifest:
version: 1.0

automations:
estimated_time_to_review:
  if:
    - true
  run:
    - action: add-label@v1
      args:
        label: "~{{ calc.etr }} min review"
        color: {{ 'E94637' if (calc.etr >= 20) else ('FBBD10' if (calc.etr >= 5) else '36A853') }}
needs_one_review:
  if:
    - {{ not has.sensitive_files }}
    - {{ is.quick_review }}
    - {{ approvals.zero }}
  run:
    - action: add-label@v1
      args:
        label: ⏳ Waiting for 1 reviewer
        color: '#73067C'
    - action: add-reviewers@v1
      args:
        reviewers: [Popmenu/mobile-app-devs]
        unless_reviewers_set: true
needs_two_reviews:
  if:
    - {{ is.long_review or has.sensitive_files }}
    - {{ approvals.ltTwo }}
  run:
    - action: add-label@v1
      args:
        label: {{ '⏳ Waiting for 2 reviewers' if (approvals.zero) else '⏳ Waiting for 1 reviewer' }}
        color: '#73067C'
    - action: add-reviewers@v1
      args:
        reviewers: [Popmenu/mobile-app-devs]
        unless_reviewers_set: true
deleted:
  if:
    - {{ has.deleted_files }}
  run:
    - action: add-label@v1
      args:
        label: 🗑 Deleted files
        color: '#DF9C04'
missing_sc_ticket:
  if:
    - {{ not sc_ticket.comment }}
  run:
    - action: add-label@v1
      args:
        label: 🎫 Missing SC Ticket
        color: '#FBCA02'
unresolved_threads:
  if:
    - {{ pr.status == 'open' }}
    - {{ pr.unresolved_threads > 0 }}
  run:
    - action: add-label@v1
      args:
        label: 🚨 Unresolved thread(s)
        color: '#EC560D'
sensitive_file_change_review:
  if:
    - {{ has.sensitive_files }}
  run:
    - action: set-required-approvals@v1
      args:
        approvals: 2
two_reviews:
  if:
    - {{ is.long_review or has.sensitive_files }}
  run:
    - action: set-required-approvals@v1
      args:
        approvals: 2
do_not_merge:
  if:
    - {{ has.do_not_merge_label }}
  run:
    - action: request-changes@v1
      args:
        comment: |
          Merging is blocked while "Do Not Merge" label is added
ready_to_merge_one_approval_pr:
  if:
    - {{ not has.sensitive_files }}
    - {{ is.quick_review }}
    - {{ not has.do_not_merge_label }}
    - {{ approvals.gtZero }}
  run:
    - action: add-label@v1
      args:
        label: ✌ Ready to merge
        color: '#219944'
ready_to_merge_two_approval_pr:
  if:
    - {{ is.long_review or has.sensitive_files }}
    - {{ not has.do_not_merge_label }}
    - {{ approvals.gtOne }}
  run:
    - action: add-label@v1
      args:
        label: ✌ Ready to merge
        color: '#219944'

calc:
etr: {{ branch | estimatedReviewTime }}
has:
deleted_files: {{ source.diff.files | map(attr='new_file') | match(term='/dev/null') | some }}
sensitive_files: {{ files | match(list=sensitive) | some }}
do_not_merge_label: {{ pr.labels | match(term='Do not merge') | some }}
is:
safe_change: {{ (source.diff.files | isFormattingChange) or (files | allDocs) or (files | allTests) or (files | allImages) }}
quick_review: {{ files | length <= 7 and calc.etr <= 5 }}
long_review: {{ files | length > 7 or calc.etr > 5 }}
approvals:
zero: {{ pr.approvals | length == 0 }}
gtZero: {{ pr.approvals | length > 0 }}
gtOne: {{ pr.approvals | length > 1 }}
ltTwo: {{ pr.approvals | length < 2 }}
sc_ticket:
comment: {{ pr.comments | match(attr='content', term='Shortcut Story') | some }}
sensitive:
- App.tsx
- AppRoot.tsx
config:
ignore_files:
  - 'yarn.lock'
  - 'ios/*.lock'
  - 'android/*.lock'
  - 'src/graphql/schema.json'
  - 'src/__generated__/types.ts'
  - 'src/i18n/messages/*.json'
  - '__tests__/**/*.snap'

PR URL
Describe your PR relevant content
Add relevant commit SHA

Expected behavior
After receiving 2 approvals, set-required-approvals@v1 should pass and no longer block the PR from being merged
Screenshots

Additional context
This was working fine previously and I don't recall any recent changes to our .cm that may have introduced our issue

@matthewparavati we implemented some bug fixes in recent weeks and I want to check in to see if this is still a problem for you. Are you still encountering this problem?
If so, we'll dedicate some engineering resources to solving this in the next couple of weeks.

@matthewparavati we implemented some bug fixes in recent weeks and I want to check in to see if this is still a problem for you. Are you still encountering this problem?
If so, we'll dedicate some engineering resources to solving this in the next couple of weeks.

@BenLloydPearson thanks for the update!
Even when raising the issue, I don't think it was a regular occurrence, only intermittently.
With that being said, I can't remember it occurring very recently.
If you guys have put out some bug fixes and others haven't reported recent, similar issues, I am fine if y'all want to mark as completed and  close this issue.
I can always open a new one if I see it pop up again!


fix: remove conan bincrafters repo and add jsonrpccpp with external_p…

Remove bincrafters repo from conan dependencies. Add jsonrpccpp library with externalProject and remove it from conan. Fir some building cache issues

prnet cleaned-up successfully


how to start such a project ?

Hi,
I'm French (sorry bad English)  and I have a a school project to train autonomous model cars for real races . Here the link https://ajuton-ens.github.io/CourseVoituresAutonomesSaclay/
What i want to know is how to approach the task ? I'm planning to use gymnasium and stable-baselines3  for training. However, I find that you manage to show the progress of the IA really well, something I hope to achieve.
So the big questions : how many hours have you put in it ? From witch angle do you start the project ?
Your project already inspired mine so I will start working to hopefully have a car that make a least one lap.
Thank you for your amazing work !

Hi!
That's a very big project! It will be very challenging to do reinforcement learning directly on a real car because it requires a huge number trials, and would probably crash a ton during the process.
One approach is to train first using a car simulator and then use that model as a starting point for the real car.
One very cool approach which learns its own simulation of the environment is "dreamer":
https://www.youtube.com/watch?v=xAXvfVTgqr0
https://github.com/danijar/dreamerv3
Overall, my advice would be to start as simple as possible, manually programming the car to follow the course, and gradually test out more sophisticated methods. Traditional approaches are very hard to beat in this area.
Hope that's helpful!

thanks !
we are using webots for the simulation so we have a platform to train our models so i think your approach and mine will be pretty similar. Anyway, thanks for the video, it was very insightful


Timeseries plots

I've been playing with tplot for a few days now building a command-line tool to show some usage data, basically I've created a CLI connecting pandas.read_csv to tplot. This has turned out really well and the plots look great in the terminal.
Any thoughts on the best way to handle timeseries/datetime on the x-axis? One approach might be for the user to just cast the timestamps to Unix epoch times, but that's not very human readable on the axis labels. Do you have any sense of how much of a challenge it would be to construct a label formatter on the x-axis to show dates and times nicely (like months+days, or hours+minutes)?
Just sharing ideas, thanks.

Right now I'm just forcing parsed date times to unix epochs in seconds and let you scale by day/hour/min in either direction as an offset. This isn't ideal though, it would be awesome to have x-axis labels properly deal in dates, etc.

That's definitely a good suggestion! Shouldn't be too difficult to handle Datetime objects properly (scaling using epoch time and labeling with human-readable text). I'll try to have a look at it in the next week or so.
Also: wonderful to see tplot being used for cool stuff, that figure looks great!

Progress continues on a better interface. I think with good time series labeling this could look really great.

Handling datetime objects is more difficult than I thought. I figured I could just use epoch timestamps to plot everything as numbers and show the datetime as a string for the axis tick labels, but that beaks the assumption that tick labels and their values are the same - something that is pretty fundamental to how tplot is set up.
There's also the issue of the interval between ticks. tplot creates ticks at round(ish) intervals like 1, 2, 5, 10, 20, 50, 100, etc. This doesn't work for a lot of situations with datetimes: tplot might decide on a 100 000 second tick interval, which is a nice round number in seconds (and epoch timestamps are in seconds), but measured in days that's roughly 1.1574074 - yuck! Depending on what timescale you're plotting, tick intervals end up looking arbitrary. And then there's units of time that have a variable length, such as months or years (leap days). Time is complicated.
Maybe there are existing open source implementations for getting an appropriate time interval given a set of dates and times, and solutions for any other peculiarities that come up. But unless there's significant interest from a lot of people, I don't think it's worth trying to support datetime objects. It could potentially add a lot of complexity, and I'd like to keep tplot simple.
Your current solution of converting datetimes to a manually chosen time interval (e.g. number of days) seems like the best approach. If you really need to handle datetime objects with all the complexity they bring, there are enough feature-rich plotting libraries out there that can do pretty much whatever you want, including plotting date intervals nine ways to Sunday.
Sorry to get your hopes up!


Linked table

Adds links in popup window ala https://github.com/luciopaiva/witchcraft/issues/20

Excellent addition, @ehershey. Thanks for you contribution!


Init sigs.k8s.io/bom and add presubmits

go.mod: Init sigs.k8s.io/bom
Add presubmits

Signed-off-by: Stephen Augustus<EMAIL_ADDRESS>/assign @puerco @Verolop
cc: @kubernetes-sigs/release-engineering
ref: https://github.com/kubernetes/test-infra/pull/24428

/retest

this initial PR will fail because there is nothing to test/lint :)

this initial PR will fail because there is nothing to test/lint :)

/override pull-bom-test
/override pull-bom-verify

/skip pull-bom-test
/skip pull-bom-verify

/lgtm

Manually merging...


The amount of memory and CPU Kade Engine consumes can get out of control real quick

I've had some issues with Kade Engine running slower than usual, so today I decided to check for what was happening a few times. I ended up finding out the engine itself was taking quite a bit of CPU and Memory from my PC.

Mostly seems to happen when assets are loading, on the title screen and on specific situations, then yet again when choosing a week, this can happen for a second:

Though that's not even the most worrying thing. The average performance while playing a full week is the one shown in the following picture. Note that this was taken while running THE TUTORIAL WEEK.

KE sure has potential to be the best out of them all, but all of its features cause it to be poorly optimized. It's quite literally one of the only things it's missing as of now. Thanks for checking out on this.
EDIT: Right after finishing a week you're left with this on the title screen:

I fail to see how 1gb of memory is a lot of memory.
this is memory that an average game instance uses on vanilla as well (probably more honestly)
also with 1.8 it should be minimized


Initial bits for .NET Aspire release 9.0-rc1

Summary
Initial bits for .NET Aspire release 9.0-rc1
Fixes #1813

Internal previews

📄 File
🔗 Preview link

docs/whats-new/dotnet-aspire-9-release-candidate-1.md
docs/whats-new/dotnet-aspire-9-release-candidate-1

docs/whats-new/index.yml
docs/whats-new/index

docs/whats-new/toc.yml
docs/whats-new/toc

My review is in progress...


Added #include  xor_single.cpp for fixing compiling error

@bee-san @Cyclic3 This PR fixes the following error both for C and Python building:
cmake --build . -t ciphey_core_py --config Release

[ 10%] Swig compile /home/athena/toast/CipheyCore/py/python.i for python
[ 10%] Built target ciphey_core_py_swig_compilation
[ 20%] Building CXX object CMakeFiles/ciphey_core.dir/src/ausearch.cpp.o
[ 30%] Building CXX object CMakeFiles/ciphey_core.dir/src/ciphers/caesar.cpp.o
[ 40%] Building CXX object CMakeFiles/ciphey_core.dir/src/ciphers/vigenere.cpp.o
[ 50%] Building CXX object CMakeFiles/ciphey_core.dir/src/ciphers/xor_single.cpp.o
/home/athena/toast/CipheyCore/src/ciphers/xor_single.cpp: In function ‘void ciphey::xor_single::xor_prob_table(ciphey::prob_table&, key_t)’:
/home/athena/toast/CipheyCore/src/ciphers/xor_single.cpp:20:17: error: ‘exchange’ is not a member of ‘std’
   20 |       if (!std::exchange(is_on[i], true)) {
      |                 ^~~~~~~~
/home/athena/toast/CipheyCore/src/ciphers/xor_single.cpp:4:1: note: ‘std::exchange’ is defined in header ‘<utility>’; did you forget to ‘#include <utility>’?
    3 | #include <iostream>
  +++ |+#include <utility>
    4 |
make[3]: *** [CMakeFiles/ciphey_core.dir/build.make:118: CMakeFiles/ciphey_core.dir/src/ciphers/xor_single.cpp.o] Error 1
make[2]: *** [CMakeFiles/Makefile2:87: CMakeFiles/ciphey_core.dir/all] Error 2
make[1]: *** [CMakeFiles/Makefile2:121: CMakeFiles/ciphey_core_py.dir/rule] Error 2
make: *** [Makefile:137: ciphey_core_py] Error 2

Project ceased in favour of https://github.com/bee-san/Ares


[FEATURE REQ] Simplify the connection related properties for blob checkpoint store in Spring Cloud Azure Event Hubs libraries

Context
When using Storage Blob as the checkpoint store in Spring Cloud Azure Event Hubs libraries, we provide multiple connection related properties to specify the target server entity to connect to. However, in some cases, the usage of those properties may be redundant and cloud be simplified.
The default and simplest usage case is that:
spring:
  cloud:
    azure:
      eventhubs:
        processor:
          checkpoint-store:
            container-name: ...
            account-name: ...
            account-key: ....

However, when there are requests to specify the Storage endpoint, e.g., the server is in Azure China cloud, then developers need to provide properties like:
spring:
  cloud:
    azure:
      eventhubs:
        processor:
          checkpoint-store:
            container-name: ...
            account-name: ...
            endpoint: https://<account-name>.blob.core.chinacloudapi.cn
            account-key: ....

where the endpoint property actually contains the information of account-name but we still require the account-name property to be configured.
Similar cases happen for the property of connection-string, the Storage connection string contains information about the endponit, account name and others. But let's still use the use case that a developer wants to connect to a Storage server in Azure China cloud, then required properties are:
spring:
  cloud:
    azure:
      eventhubs:
        processor:
          checkpoint-store:
            container-name: ...
            account-name: ...
            endpoint: https://<account-name>.blob.core.chinacloudapi.cn
            connection-string: ...

or
spring:
  cloud:
    azure:
      profile:
        cloud-type: azure_china
      eventhubs:
        processor:
          checkpoint-store:
            container-name: ...
            account-name: ...
            connection-string: ...

where multiple properties are required but provide redundant information.
Goal
We should simplify the required properties for the above cases and avoid that developers need to configure multiple properties but provide similar information .

nice catch, I think this is because we didn't aware of the different format that the endpoint support.
Nor we dont' have a clear definition of what value is expected for the checkpoint-store.endpoint
check this and this as example, and compare to our doc about this properties https://microsoft.github.io/spring-cloud-azure/current/reference/html/index.html#configuration-3


Unify data loaders and eval scripts; allow arbitrary image size

@FangjinhuaWang in the interest of expedience I'm including all remaining changes in a single PR. Outlining here the main changes in the repo:

Unified the data loaders so now there's only one MVSDataset needed. I kept dtu_yao.py for backwards compatibility so the training can still work in the existing way. That's just legacy now and could be removed in subsequent PR.
Intrinsics and extrinsics are provided separately (not as a projection matrix) from the data loader and only for the desired image size. The parameters needed for each stage are now calculated internally in the module. This simplifies the loader and also makes it easier to handle arbitrary image sizes.
Module can now work for any image size (not just multiples of 8). Inside the module the image is stretched (slightly) to the nearest multiple of 8 and then after the PatchMatchNet process is complete the output maps are brought back to the original image size. This also means that the most recent change in data_io can be reverted and use a single max_dim instead of tuple.
As a consequence of handling arbitrary image sizes the model can now also work for multi-camera setups with different intrinsics and/or orientation.
Unified the evaluation scripts to use the new data loader so there's no need for a new eval for each of eth, dtu, tanks, and custom
Cleanup and updates of the train.py and eval.py scripts to use unified data loader. Existing training script renamed to train_dtu.py for backwards compatibility; still uses the dtu_yao data loader. This could be removed in subsequent PR.
Added support scripts to convert datasets and make them compatible with unified data loader (convert_dtu_dataset.py and convert_eth_dataset.py); need to be applied once in the DTU and ETH3D data before using the new train and eval scripts. The converted datasets could replace the existing ones distributed with the repo
Added support script to export PatchMatchNet output as a colmap workspace to be used for fusion (colmap_output.py). Also did minor updates in colmap_input.py script.
Updated the list text files (used in train and eval) to be compatible with the new format of the data loader.
Updated the checkpoints that are now one for parameters only (checkpoints/params_000007.ckpt used in Python) and one for the TorchScript module (checkpoints/module_000007.pt used in colmap and python)

Note that all these changes have been tested in both training and evaluation with the DTU dataset and also the evaluation has been tested with custom colmap datasets with single and multi-camera setups.

Maybe README.md should be updated at the same time after the last merge.


How to make the HelloWorld work with "jni_bind_release.h"?

Here is what I have:
HelloWorld.java
package com.test;

public class HelloWorld {

    public void sayHello(String msg) {
        System.out.println("Hello from Java: " + msg);
    }
}

Compile it:
$ javac com/test/HelloWorld.java

The Google JNI-BIND C++ code:
#include "jni_bind_release.h"

// 1: Setup JNI Bind in your OnLoad call (needed only once).
std::unique_ptr < jni::JvmRef < jni::kDefaultJvm >> jvm;

extern "C" {
    JNIEXPORT jint JNICALL JNI_OnLoad(JavaVM * pjvm, void * ) {
        jvm.reset(new jni::JvmRef < jni::kDefaultJvm > (pjvm));
        return JNI_VERSION_1_6;
    }
}

int main() {

    // 2: Define the class
    static constexpr jni::Class kClass {
        "com.test.HelloWorld",
        jni::Method {
            "sayHello",
            jni::Return < void > {},
            jni::Params < jstring > {}
        }
    };

    // 3: Use the class
    jni::LocalObject < kClass > obj {}; // Constructs new instance.

    obj("sayHello", "a cool string from C++");

    return 0;
}

I have the JNI-BIND sources inside a local jni_bind folder. So to compile the code above I do on a Mac:
$ tree -L 1
.
├── HelloWorld.cpp
├── com
└── jni_bind

$ tree com
com
└── test
    ├── HelloWorld.class
    └── HelloWorld.java

C++ compilation:
$ clang++ -std=c++17 -I./jni_bind -I"$JAVA_HOME/include"
-I"$JAVA_HOME/include/darwin/" HelloWorld.cpp -o HelloWorld

And it compiles fine, great!
But now when I run it, I get a segmentation fault because it is not able to find the ./com/test/HelloWorld.class file to load.
$ ./HelloWorld
zsh: segmentation fault  ./HelloWorld

Setting the CLASSPATH does not work either:
$ CLASSPATH=. ./HelloWorld
zsh: segmentation fault  CLASSPATH=. ./HelloWorld

Perhaps I have to set JavaVMOption with -Djava.class.path=. to pass to its embedded JVM? But how would I go about doing that?

Very nice project! Congratulations for the hard and meticulous work you did there. I'm maintaining a GitHub repo (JavaToCppAndBack) with an assortment of examples of Java to C++ and C++ to Java integration. I would love to include a JNI-BIND HelloWorld there eventually!

That is very kind, I appreciate the compliment!  It has been a tremendous amount of work so it is nice that it is getting closer to being in people's hands.  I'd love to be used by other projects, although to start i imagine that would be done most simply through the Bazel/WORKSPACE mechanisms.
If you would like to file a new issues for "Distribution to third party projects" that would be great, although, realistically I'm afraid I need to address other issues for the 1.0 release.  In the meantime, any mentions/stars help the project gain traction which I would be very grateful for 🙂

For anyone trying to use this project for native code only usage and needs to get the classpath to work, I guess we can initiate the JavaVM ourselves with the correct classpath.
void run(JavaVM *jvm) {
  jni::JvmRef<jni::kDefaultJvm> jvm_ref = jni::JvmRef<jni::kDefaultJvm>(jvm);
  // ...
}

int main(int argc, char **argv) {
  std::string classpath = "-Djava.class.path=example.jar";

  JavaVMOption options[1];
  options[0].optionString = classpath.data();

  JavaVMInitArgs init_args = {
      .version = JNI_VERSION,
      .nOptions = 1,
      .options = options,
      .ignoreUnrecognized = false,
  };

  JavaVM *jvm;
  JNIEnv *env;
  if (JNI_CreateJavaVM(&jvm, (void **)&env, (void *)&init_args) != JNI_OK) {
    return 1;
  }

  run(jvm);
  return 0;
}

I'm not 100% percent sure if this is the correct use of the library, but it works for my purpose of using Java classes in C++.

Ah, this is similar to the unreleased binary I have.  If you manage to add it as a binary in the tree as a pull request I'd love to add your work to the tree.  Realistically I don't think I have time to do this myself.

Ah, this is similar to the unreleased binary I have. If you manage to add it as a binary in the tree as a pull request I'd love to add your work to the tree. Realistically I don't think I have time to do this myself.
(Also, apologies, I missed this comment when you posted it).

By adding a binary, do you mean adding an example to README or creating some compilation unit that uses classpath and invokes Java methods from C++?

Let me try to take some time this weekend and open source the existing code we have.  I took a stab last night but it's more than an hour's work.
By binary, I mean, add a cc_binary target, which obviously is Bazel specific.  I'm sure there's a way you could do it in CMAKE or whatever, but for now the project mostly focuses on header only, or using Bazel.
As I said, I have an internal binary which runs with no Java entrypoint, but sadly it references locations of solibs for the JVM that are Google specific, and thus not useful for open source.

Ok, I put some time into this and I've got something that's at least partially there.
https://github.com/google/jni-bind/pull/343
Unfortunately, on my machine, when I launch it I immediately see the following failure:
Error occurred during initialization of VM
Unable to load native library: /usr/local/buildtools/java/jdk-sts/lib/libjava.so: undefined symbol: JVM_GetClassFileVersion, version SUNWprivate_1.1

I haven't polished this code at all so buyer beware.  This works with our internal tooling, but somehow I'm getting a different result from my Bazel invocation.  I would figure it's accessing the same solibs so I'm not sure what's going on.

This won't ever be a priority beyond other tasks, so I'm closing this as not planned also.
I've uploaded the code so anyone is free to go play with this themselves.  I hope they do! It's a very cool feature.


Error logger - server not responding

Describe the bug
Http endpoint returns ECONRESET for all requests
To Reproduce
Not known. Might be the error appeared after HA update.
Expected behavior
Normal http response.
Screenshots
s6-rc: info: service legacy-services successfully started
Traceback (most recent call last):
File "/usr/lib/python3.9/runpy.py", line 197, in _run_module_as_main
return _run_code(code, main_globals, None,
File "/usr/lib/python3.9/runpy.py", line 87, in _run_code
exec(code, run_globals)
File "/usr/local/lib/python3.9/dist-packages/emhass/web_server.py", line 15, in
from emhass.command_line import set_input_data_dict
File "/usr/local/lib/python3.9/dist-packages/emhass/command_line.py", line 20, in
from emhass.forecast import forecast
File "/usr/local/lib/python3.9/dist-packages/emhass/forecast.py", line 15, in
import pvlib
File "/usr/local/lib/python3.9/dist-packages/pvlib/init.py", line 3, in
from pvlib import (  # noqa: F401
File "/usr/local/lib/python3.9/dist-packages/pvlib/clearsky.py", line 14, in
import h5py
File "/usr/lib/python3/dist-packages/h5py/init.py", line 21, in
from . import _debian_h5py_serial as _h5py
File "/usr/lib/python3/dist-packages/h5py/_debian_h5py_serial/init.py", line 46, in
from ._conv import register_converters as _register_converters
File "h5py/_debian_h5py_serial/_conv.pyx", line 1, in init h5py._debian_h5py_serial._conv
File "h5py/_debian_h5py_serial/h5t.pyx", line 293, in init h5py._debian_h5py_serial.h5t
File "/usr/local/lib/python3.9/dist-packages/numpy/init.py", line 333, in getattr
raise AttributeError("module {!r} has no attribute "
AttributeError: module 'numpy' has no attribute 'typeDict'
s6-supervise emhass: warning: unable to spawn ./finish: Permission denied
Home Assistant installation type

Home Assistant OS

Your hardware

OS: HA OS
Architecture:  armv7, aarch64

EMHASS installation type

Add-on

Additional context
Add any other context about the problem here.

I have the exact same error after EMHASS update.

it should be solved, upgrade to add-on v0.5.2 when it is available.
Please close the issue if everything goes back to normal

I saw a different error message when trying to install the latest EMHASS version yesterday. Will try 0.5.2 and report back if that version doesn't fix that problem as well.

In new version I see this error when accessing htt endpoint.
2023-12-19 14:20:00,164 - web_server - ERROR - Exception on /action/publish-data [POST]
Traceback (most recent call last):
File "/usr/local/lib/python3.11/dist-packages/pandas/core/indexes/base.py", line 3653, in get_loc
return self._engine.get_loc(casted_key)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "pandas/_libs/index.pyx", line 147, in pandas._libs.index.IndexEngine.get_loc
File "pandas/_libs/index.pyx", line 176, in pandas._libs.index.IndexEngine.get_loc
File "pandas/_libs/hashtable_class_helper.pxi", line 7080, in pandas._libs.hashtable.PyObjectHashTable.get_item
File "pandas/_libs/hashtable_class_helper.pxi", line 7088, in pandas._libs.hashtable.PyObjectHashTable.get_item
KeyError: 'optim_status'

Ok I also had this same error message myself when installed the new version. You just have to go to the webui and manually update your optimization results. Also while there update the ML forecaster if you are using that. Then manually publish the optimization results. Go back to the logger, the errors should be gone.
This was just because the saved results needed to be updated as we added a new column to the results DataFrame containing the optimization status.

Did you manage to apply the solution on my previous post? That should solve it. Closing the issue for now but reopen if needed.

Hi. Sorry for late answer, I was not home.
Yes, I can confirm that it helped solve the bug.


control the order of transforms

use case:
var aliasify = require('aliasify');
var myTransform = require('my-custom-transform');
...
b.transform(aliasify);
b.transform(myTransform);

I expect that files being compiled go through aliasify before running through myTransform.
I tried switching the order of lines 4 and 5, and i get the same result, which is myTransform is being applied first.
Is there a way to control this? if not, would you consider implementing it?
Thanks

It looks like this is supposed to ensure the order of the transforms. Do you have some code that demonstrates this?

Thanks for commenting @jmcantrell. @andrepadez What browserify version and OS? As @jmcantrell noted, they are supposed to be applied in the order added. Can you please create a repo that reproduces the problem?

I am experiencing this issue, I believe, when using hbsfy and aliasify together. I want to reference a partial inside a handlebars template using an alias. Hbsfy will convert my partial references into require(...) invocations, which should let aliasify further convert them. However, when I put console.logs in both hbsfy and aliasify they were dumping out logs at the same time, suggesting hbsfy was not complete before aliasify started working.
This is my configuration:
  var browserify = require('browserify');
  var b = browserify();
  b.add('./app/init');
  b.transform('hbsfy', { traverse: true });
  b.transform('aliasify');

{
  "aliasify": {
    "aliases": {
      "app": "./app"
    }
  }
}

and I'm referencing this alias in my templates:
  {{> app/myPartial.hbs }}

I'm getting this error:
Error: Cannot find module 'app/myPartial.hbs' from '/other/dev'

and the logs were interlaced:
aliasify - /other/dev/myView.js: replacing app/myFile.js with ./../myFile of function require
var partial$0 = require('app/myPartial.hbs');
aliasify - /other/dev/mySecondView.js: replacing app/mySecondFile.js with ./../mySecondFile of function require

Here is the issue on hbsfy: https://github.com/epeli/node-hbsfy/issues/56
I'm using browserify version 13.0.0

Perhaps there is some asynchronous aspect to some of these transforms? Perhaps the hbsfy function will end before it has completed updating the files? It doesn't look like browserify handles promise resolution for transforms, and it's expected that everything is completed when the transform returns.

Hi @kentmw, transforms are stream based so inherently async, but of course they run in sequence on a given file. Maybe it has something to do with this: options.jsFilesOnly. Anyway, I'm closing this issue because no one has provided a repro. I suspect your problem has to do with how those two transforms interact rather than something fundamental about how Browserify transforms work. Stackoverflow is one place you can try for help. If you're able to isolate a bug in Browserify's transform handling, please open a new issue with a minimal repro. If you need help getting started see miniminirepro/browserify. Thanks!

@kentmw Take a look at the appliesTo option -- maybe it'll help you. Not sure how that interacts with the other option of the underlying lib, jsFilesOnly. If it doesn't work out, you could try my pathmodify plugin.

I modified jsFilesOnly in my downloaded node_modules/aliasify/aliasify.js, and it worked. At least, it worked in my case. I'll try out the appliedTo option, and move this conversation over to the aliasify project. Thank you so much for your help!


loguniform with negative lower bound causes error

I'm trying to use nni with lightgbm and when setting lambda_l1 or lambda_l2 with loguniform it crashes when the lower bound is set below 0.  Here is the json:
     ...
"lambda_l1": {
        "_type": "loguniform",
        "_value": [-3, 1]
    },
    ...

Setting  "_value": [2, 5]makes it work but for negative values it doesn't for some reason.
Here is the dispatcher log:
Traceback (most recent call last):
  File "/Users/username/Library/Python/3.7/lib/python/site-packages/nni/msg_dispatcher_base.py", line 102, in command_queue_worker
    self.process_command(command, data)
  File "/Users/username/Library/Python/3.7/lib/python/site-packages/nni/msg_dispatcher_base.py", line 160, in process_command
    command_handlers[command](data)
  File "/Users/username/Library/Python/3.7/lib/python/site-packages/nni/msg_dispatcher.py", line 101, in handle_request_trial_jobs
    params_list = self.tuner.generate_multiple_parameters(ids)
  File "/Users/username/Library/Python/3.7/lib/python/site-packages/nni/tuner.py", line 52, in generate_multiple_parameters
    res = self.generate_parameters(parameter_id)
  File "/Users/username/Library/Python/3.7/lib/python/site-packages/nni/hyperopt_tuner/hyperopt_tuner.py", line 256, in generate_parameters
    total_params = self.get_suggestion(random_search=False)
  File "/Users/username/Library/Python/3.7/lib/python/site-packages/nni/hyperopt_tuner/hyperopt_tuner.py", line 375, in get_suggestion
    new_trials = algorithm(new_ids, rval.domain, trials, random_state)
  File "/usr/local/lib/python3.7/site-packages/hyperopt/tpe.py", line 870, in suggest
    return rand.suggest(new_ids, domain, trials, seed)
  File "/usr/local/lib/python3.7/site-packages/hyperopt/rand.py", line 24, in suggest
    domain.s_rng: rng,
  File "/usr/local/lib/python3.7/site-packages/hyperopt/pyll/base.py", line 913, in rec_eval
    rval = scope._impls[node.name](*args, **kwargs)
  File "/usr/local/lib/python3.7/site-packages/hyperopt/pyll/stochastic.py", line 44, in loguniform
    draw = rng.uniform(low, high, size=size)
  File "mtrand.pyx", line 1307, in mtrand.RandomState.uniform

When looking at the input arguments to rng.uniform I get low=nan and high=0.0

Hello @FerusAndBeyond.  The loguniform definition is here.
You could see a vairiable in "loguniform" distribution means "the variable value is a value drawn from a range [low, high] according to a loguniform distribution like exp(uniform(log(low), log(high)))".
The log function doesn't support negative input, so as the "loguniform".

@xuehui1991 You're right, thanks. I read it from this page where it says differently: "Which means the variable value is a value drawn according to exp(uniform(low, high)) so that the logarithm of the return value is uniformly distributed". Those two pages should be synced.

@FerusAndBeyond  Thank you for your suggestion. We may need to update our wiki recently~


Prims Algorithm #351

Prims Algorithm #351

@tarun26091999 Review the same. Thanks

@OjusWiZard he was assigned to give Java solution only.

@Vishal-Singh-1996 But the issue is for C++ and the added code is in java

@OjusWiZard ......Yeah But I asked to @tarun26091999 to contribute this code or would like to do in Java and he assigned me to do this in java and also add a Java tag...Pls review it

@tarun26091999 pls review it


Fixes for issues #70, #80, #89 and #92

Refactored List sorting logic to make relevant CQL types comparable and removed static members.
Refactored Equal and Equivalence logic to access operation within CQL type classes and correctly evaluate Code and Concept.
Fixed and cleaned up tests resulting from refactoring and added/enhanced sorting tests.

Since this pull request overlaps with pull request #88, please note that the latter fixes both Equal() and Equivalent() for Code types, and updates the EquivalentEvaluator documentation concerning Code, and it includes a set of new tests for all the permutations of the 4 attributes, in both older Java/CQL and newer XML versions.  I did not see any Code tests in pull request #93 nor the documentation fix so you can/should take those.


Composer Error to install the bagisto-reward-points

Hi
I've installed the latest Bagisto and when I try to install the "bagisto-reward-points" package with this command
composer require bagisto/bagisto-reward-points
it returns the below error:
In PackageDiscoveryTrait.php line 356:

 Could not find package bagisto/bagisto-reward-points. It was however found
  via repository search, which indicates a consistency issue with the repository.

How can I fix it?

was it fixed ? any solution ?


Show workflows events in the UI like Argo CD does

Summary
Make it easier to debug workflow failures by surfacing relevant Kubernetes events.

Message from the maintainers:
Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.

Duplicate of #3673.


FactoryBot::DuplicateDefinitionError when defining the same-named sequence in the same-named trait in distinct factories

After upgrading to 5.0, I'm seeing this error:

Sequence already registered: from_api_id (FactoryBot::DuplicateDefinitionError)

This code previously worked in 4.x. I've looked at the release notes, but there's nothing obvious there about this (at least to me as a casual user of factory_bot).
Steps to reproduce
Gemfile
# frozen_string_literal: true

source "https://rubygems.org"
gem "factory_bot", "~>5"

example.rb
require 'factory_bot'

User = Struct.new(:id)
Company = Struct.new(:id)

FactoryBot.define do
  factory :user, class: User do
    trait :from_api do
      sequence(:id, '1')
    end
  end

  factory :company, class: Company do
    trait :from_api do
      sequence(:id, '1')
    end
  end
end

$ bundle exec ruby example.rb
Traceback (most recent call last):
	18: from example.rb:6:in `<main>'
	17: from /Users/shep/.rvm/gems/ruby-2.5.3/gems/factory_bot-5.0.0/lib/factory_bot/syntax/default.rb:7:in `define'
	16: from /Users/shep/.rvm/gems/ruby-2.5.3/gems/factory_bot-5.0.0/lib/factory_bot/syntax/default.rb:49:in `run'
	15: from /Users/shep/.rvm/gems/ruby-2.5.3/gems/factory_bot-5.0.0/lib/factory_bot/syntax/default.rb:49:in `instance_eval'
	14: from example.rb:13:in `block in <main>'
	13: from /Users/shep/.rvm/gems/ruby-2.5.3/gems/factory_bot-5.0.0/lib/factory_bot/syntax/default.rb:18:in `factory'
	12: from /Users/shep/.rvm/gems/ruby-2.5.3/gems/factory_bot-5.0.0/lib/factory_bot/syntax/default.rb:18:in `instance_eval'
	11: from example.rb:14:in `block (2 levels) in <main>'
	10: from /Users/shep/.rvm/gems/ruby-2.5.3/gems/factory_bot-5.0.0/lib/factory_bot/definition_proxy.rb:174:in `trait'
	 9: from /Users/shep/.rvm/gems/ruby-2.5.3/gems/factory_bot-5.0.0/lib/factory_bot/definition_proxy.rb:174:in `new'
	 8: from /Users/shep/.rvm/gems/ruby-2.5.3/gems/factory_bot-5.0.0/lib/factory_bot/trait.rb:12:in `initialize'
	 7: from /Users/shep/.rvm/gems/ruby-2.5.3/gems/factory_bot-5.0.0/lib/factory_bot/trait.rb:12:in `instance_eval'
	 6: from example.rb:15:in `block (3 levels) in <main>'
	 5: from /Users/shep/.rvm/gems/ruby-2.5.3/gems/factory_bot-5.0.0/lib/factory_bot/definition_proxy.rb:122:in `sequence'
	 4: from /Users/shep/.rvm/gems/ruby-2.5.3/gems/factory_bot-5.0.0/lib/factory_bot.rb:105:in `register_sequence'
	 3: from /Users/shep/.rvm/gems/ruby-2.5.3/gems/factory_bot-5.0.0/lib/factory_bot.rb:105:in `each'
	 2: from /Users/shep/.rvm/gems/ruby-2.5.3/gems/factory_bot-5.0.0/lib/factory_bot.rb:106:in `block in register_sequence'
	 1: from /Users/shep/.rvm/gems/ruby-2.5.3/gems/factory_bot-5.0.0/lib/factory_bot/decorator/disallows_duplicates_registry.rb:6:in `register'
/Users/shep/.rvm/gems/ruby-2.5.3/gems/factory_bot-5.0.0/lib/factory_bot/decorator.rb:10:in `method_missing': Sequence already registered: __from_api_id__ (FactoryBot::DuplicateDefinitionError)

Ruby Versions:

ruby 2.5.3p105 (2018-10-18 revision 65156) [x86_64-darwin18]
ruby 2.6.0p0 (2018-12-25 revision 66547) [x86_64-darwin18]

macOS 10.14.3

Thanks for the issue! That does seem unexpected. I'll try to look into this before the end of the week.

It occurred to me that this is probably because of #1164.

Seems reasonable:

We register them with __#{factory_name}_#{sequence_name}__

We register them with __#{factory_name}_#{sequence_name}__

I don't think that is really true. We register them with @definition.name, which could be either a factory name or a trait name.

I don't think that is really true

You should have a stern talking-to with the developer that opened that PR then 😉

Thanks!

@composerinteralia there is an odd corner case where raising this error causes problems:
Scenario:

you're in a lengthy transition to break down a monolith
some of the code and factories were already pulled-out into an internal gem 🎉
you're working in another repo, something odd breaks, caused by a factory in that gem
copying that factory code over into your current repo could help with setting a breakpoint,
but FactoryBot will throw an error when it encounters the second definition introduced by the gem 😢

Is there a clever way to recover from FactoryBot::DuplicateDefinitionError and just ignore the second definition?

@composerinteralia Could this be optionally just print an error message to the console, and ignore the second definition?
Perhaps print the FILE location of the second definition?
https://github.com/thoughtbot/factory_bot/blob/893eb67bbbde9d7f482852cc5133b4ab57e34b97/lib/factory_bot/decorator/disallows_duplicates_registry.rb#L6

@tilo I think it'd be best to to either open a separate issue or add a comment on an open issue (https://github.com/thoughtbot/factory_bot/issues/968 perhaps, especially as it relates to https://github.com/thoughtbot/factory_bot/pull/1064).
This particular issue was for a bug where we incorrectly raised a DuplicateDefinitionError. We've fixed that particular bug, so additional comments on this issue may get lost.


Bump Roslyn version to 2.8.0

Ship room approved yo

Waiting for the CI on my PRs in all of the related repos to complete


SSL cert hot reload (PEM files)

Hey folks,
Have been looking forward to the introduction of SSL cert hot reloading, described here -
https://github.com/opendistro-for-elasticsearch/opendistro-build/blob/master/release-notes/release-notes-odfe-1.6.0.md
https://github.com/opendistro-for-elasticsearch/security/pull/238
Currently testing v1.6.0 and find that the SSL cert hot reloading feature is not working in my case.
Just checking - has this been tested with SSL certs in Java keystores only, or does it also work for the reloading of SSL certs stored in PEM files?
Running Opendistro v.1.6.0 with correct plugin versions -
GET _cat/plugins

escdr-test-001 opendistro-job-scheduler        <IP_ADDRESS>
escdr-test-001 opendistro-knn                  <IP_ADDRESS>
escdr-test-001 opendistro_alerting             <IP_ADDRESS>
escdr-test-001 opendistro_index_management     <IP_ADDRESS>
escdr-test-001 opendistro_performance_analyzer <IP_ADDRESS>
escdr-test-001 opendistro_security             <IP_ADDRESS>
escdr-test-001 opendistro_sql                  <IP_ADDRESS>

SSL cert for transport and https is currently loaded -
    # openssl s_client -connect <IP_ADDRESS>:9200 -showcerts | openssl x509 -noout -text

depth=2 O = Digital Signature Trust Co., CN = DST Root CA X3
verify return:1
depth=1 C = US, O = Let's Encrypt, CN = Let's Encrypt Authority X3
verify return:1
Certificate:
    Data:
        Version: 3 (0x2)
    Signature Algorithm: sha256WithRSAEncryption
        Issuer: C = US, O = Let's Encrypt, CN = Let's Encrypt Authority X3
        Validity
            Not Before: Apr 29 06:16:43 2020 GMT
            Not After : Jul 28 06:16:43 2020 GMT

I replace the SSL cert on disk with an updated version - same issuer, same hostname, only major difference is the expiry date.
When I check the SSL certs API endpoint with a user with ‘admin_all’ privileges, there is no response -
GET <IP_ADDRESS>:9200/_opendistro/_security/api/ssl/certs
When I attempt to reload the certs, there is no response
The SSL cert is not reloaded.
Before I look into this much further - just checking if this feature works with PEM files as well as keystores?
PUT <IP_ADDRESS>:9200/_opendistro/_security/api/ssl/transport/reloadcerts
PUT <IP_ADDRESS>:9200/_opendistro/_security/api/ssl/http/reloadcerts

SSL hot reloads is enabled in elasticsearch.yml -
 opendistro_security.ssl_cert_reload_enabled: true
Cheers

Hi @gplechuck,
Thanks for question. This feature should work for both pem and keystore files.
To enable SSL hot reload you should ensure that the pem files are in the same filepath specified by elasticsearch.yml.
While making the request to get cert details/reload certificates you need to authenticate the request with the admin cert and key  -
Eg:
curl -k -XGET --key admin-key.pem --cert admin.pem https://<IP_ADDRESS>:9200/_opendistro/_security/api/ssl/certs
curl -k -XPUT --key admin-key.pem --cert admin.pem https://<IP_ADDRESS>:9200/_opendistro/_security/api/ssl/http/reloadcerts
curl -k -XPUT --key admin-key.pem --cert admin.pem https://<IP_ADDRESS>:9200/_opendistro/_security/api/ssl/transport/reloadcerts
Let me know if this works for you.

Hi @debjanibnrj ,
Works like a charm, thanks . I was not authenticating the request with the admin cert and key .
Very nice feature, will take the pain out of automating node restarts (safely) when SSL certs are automatically renewed in large cluster.

Hi. I am also trying to get this to work , testing on v <IP_ADDRESS>, however i get a 401 Unorthorized when  using the admin key and cert.  The same admin certificate any key do work and allow me to update security config  (securityadmin.sh)

Is there a similar command for kibana?

@2ps Open Distro for Kibana does not support this feature as far, as I know

I feel like I should comment here for someone else who might be struggling with this:   https is required for these api functions, not optional.  You must hit an https-enabled rest port for this to work, otherwise it'll silently fail without any message.
http:// no good.
https:// is what you need.
opendistro_security.ssl.http.enabled: true


CoreOS and locksmithd/update engine

So while you've disabled locksmithd, you haven't disable update-engine, which means it will still get updates and if you happen to restart coreos will automatically upgrade it.
I'd recommend something like this:
sudo systemctl disable locksmithd
sudo systemctl stop locksmithd
sudo systemctl mask locksmithd

sudo systemctl disable update-engine
sudo systemctl stop update-engine
sudo systemctl mask update-engine
sudo systemctl restart docker # Restarting docker to ensure its ready. Seems like its not during first usage.

Thank you @dispalt! I have deployed this and we're all set to go!


why did my key expired

config
var cache *bigcache.BigCache

func init() {
	config := bigcache.Config{
		Shards: 1024,
		LifeWindow: 1 * time.Hour,
		CleanWindow: 0,
		MaxEntriesInWindow: 1000 * 10 * 60,
		MaxEntrySize: 500,
		Verbose:      false,
		HardMaxCacheSize: 8192,
		OnRemoveWithReason: func(key string, entry []byte, reason bigcache.RemoveReason) {
			logger.Debugf("bigCache lost something, key:[%s], entry:[%s], reason:[%v]", key, string(entry), reason)
		},
		Logger: logger.GetLog(),
	}
	var err error
	cache, err = bigcache.NewBigCache(config)
	if err != nil {
		log.Fatalf("pCache init failed: %v \n", err)
	}
}

I use CleanWindow=0, it means always not expired?, but when i see the debug log, show like this
{"level":"debug","ts":"2022-11-22T19:06:38.606+0800","caller":"logger/std.go:29","msg":"bigCache lost something, key:[/platform_gateway_chonglou_rule/gw-object/clientAuth], entry:[\ufffd\ufffd\u0010\u0000\u001echonglou/model/rule.ClientAuth\ufffd\ufffd\u0003\u0001\u0001\nClientAuth\u0001\ufffd\ufffd\u0000\u0001\u0005\u0001\u0007Enabled\u0001\u0002\u0000\u0001\u000cAuthEndpoint\u0001\u000c\u0000\u0001\rRequestHeader\u0001\u000c\u0000\u0001\tTokenType\u0001\u000c\u0000\u0001\nAuthPrefix\u0001\u000c\u0000\u0000\u0000\u0004\ufffd\ufffd\u0001\u0000], reason:[1]"}

I just hope my cache never expired, how can i do? thx )
Environment:

Version (git sha or release<EMAIL_ADDRESS>OS (e.g. from /etc/os-release or winver.exe): CentOS Linux 7 (Core)
go version: 1.19

Or in other words, Is there something wrong with my conf

Does it expire after 1 hour? If so then set LifeWindow: 0 and that will prevent eviction.
https://github.com/allegro/bigcache/blob/0c7635518190a7d4053a104bb329b98837727eeb/config.go#L9

I double checked on this and it looks like in your case it wont work. 0 means everything will be imiedietally evicted so you need to use some bigger value.

wow, i update LifeWindow: 10 * 365 * 24 * time.Hour and try it again.
Actually in my project i just want use bigCache like Map now, Whether to add a property in bigcache.Config like NeverLost ?

It's complicated. In your configuration you have LifeWindow and HardMaxCacheSize. What bigcache should do if you need more memory than HardMaxCacheSize? Currently it will evict the oldest entry and replace it with new one. You can set HardMaxCacheSize to 0 to allow it growing infinitely but I don't recommend that :)
https://github.com/allegro/bigcache/blob/982ec3b09cacb9936b88dcfdaed329870065cf23/config.go#L25-L32

thx, u r right  :)


Add imports linting

Description

This PR add a pre-commit hook linting imports. I start thinking how to fix it next time I got failing tests because I import from PyQt5 instead of qtpy (auto import feature of IDE) and push it to repository and wasting calculation time
Type of change

[ ] Bug-fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

References

How has this been tested?

[ ] example: the test suite for my feature covers cases x, y, and z
[ ] example: all tests pass with my change

Final checklist:

[ ] My PR is the minimum possible work for the desired functionality
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] If I included new strings, I have used trans. to make them localizable.
For more information see our translations guide.

I like this idea, I havn't look at details yet, but makes sense to me. Curious how others feel

I like this idea as well :)
Is this ready to go @Czaki ?

I'm not opposed to it if others like it (don't really care personally)


Localization

Localization IDs added to MCM options, Messages, and the ViewModel
English and Japanese language files added

Of course, you can remove Japanese files if you dislike including foreign language text. I just hope to make useful mods localizable

Thank you for adding this, it looks great! I'll work on adding localization support to my other mods as well.


⚠ Bofrost.nl has degraded performance

In dfe6fc0, Bofrost.nl (https://www.bofrost.nl) experienced degraded performance:

HTTP code: 200
Response time: 1260 ms

Resolved: Bofrost.nl performance has improved in b0852de.


"Chainlink contract library" link is broken on the site

On this url: https://docs.chain.link/docs/request-and-receive-data/
the "Chainlink contract library" link is broken (404).

There's no link that points to the Chainlink contract library. Which one would it be?

It is. It's in this sentence, in the public/live url I provided. "Whether your contract requires sports results, the latest weather, or any other publicly available data, the Chainlink contract library provides the tools required for your contract to consume it."

fixed


Problem using configurations when running multiple sites on the same VPS webserver ...

It would seem that if I have multiple sites sitting on a production VPS, I'm going to have problems with environmental settings like "DJANGO_AWS_ACCESS_KEY_ID" as such items will generally vary from project-to-project.
For your consideration, I'd recommend a changing the convention to include the project name as well (e.g, "DJANGO_PROJECTNAME_AWS_ACCESS_KEY_ID").
Thanks.

Thanks for the recommendation, but isolating environment variables should be easy enough to accomplish without blowing up the env variable names.
Some options:

use envdir or
the soon to be released support for dotenv files, see 01e3f5837f3d0fed215d4e697425072219fdd964

I also opened #87 to document using Apache to set the environment variable in an isolated manner, in case your VPS is set up with that.


Simulation Interval Efficiency

As per the simulation interval: https://github.com/gamestdio/colyseus/blob/master/src/Room.ts#L65
Might it be worth taking an approach similar to node-gameloop for efficiency?

Hey, I'm cleaning up the old issues. We would need some benchmark to validate if node-gameloop is actually more efficient. I don't wanna put too many dependencies on this project.
Feel free to submit a PR if you'd like to! Cheers!


horizontal scrollbar?

is there an easy way to add horizontal scrollbar to the existing scrollbar directive?

We've just released LumX v1.0.0rc1. The scrollbar component has been removed.


Adding the name to the var file and use the loop

@fideloper Can you please review these changes, I think it's much cleaner. Thanks

That looks good! I'm gonna wait on this a bit, as it makes some things inconsistent (in terms of code style) in this repo vs other ones here. Ideally I'd go and change all of them, which isn't something I have time for at the moment.
(I'd rather the "style" be consistent in reduce surprises for people, however I do like this!)


Correction for raw affiliation Le Mans University, Laboratory "Movement, Interactions, Performance" (UR 4334), Faculty of Sciences and Technologies, Department of Sport Sciences, Le Mans, France

Correction needed for raw affiliation Le Mans University, Laboratory "Movement, Interactions, Performance" (UR 4334), Faculty of Sciences and Technologies, Department of Sport Sciences, Le Mans, France
raw_affiliation_name: Le Mans University, Laboratory "Movement, Interactions, Performance" (UR 4334), Faculty of Sciences and Technologies, Department of Sport Sciences, Le Mans, France
new_rors: 01mtcc283;04q2ax456
previous_rors: 01mtcc283
works_examples: W4380300847
contact: 15a53e190308be7dd25471d3fafc1028:9c4a80e56e6283b3bc26a37793b75e @ univ-nantes.fr

This issue was accepted and ingested by the OpenAlex team on 2024-11-18. The new affiliations should be visible within the next 7 days.


AIP-191 File names must not contain version numbers

AIP-191 states The version must not be used as a filename, because this creates bizarre imports in client libraries. Filenames such as v3.proto or v1beta1.proto are prohibited. but the linter does not enforce this requirement.
https://google.aip.dev/191#file-names

This is already linted for https://linter.aip.dev/191/filenames
It's enforcement internally is another problem however...


Use ephemeral Docker instances for the integration tests

A nice to have would be having ephemeral Docker instances (postgres) for the integration tests.
I noticed that after being run more than once these tests can start to fail.
Something like https://github.com/ory/dockertest integrated as part of the tests could be a good option.

Done, by the linked PR. Thanks for the suggestion!

Done, by the linked PR. Thanks for the suggestion!


Pagination control (clicking on arrows) also changes the "show changes" checkbox

Pagination controls changed. Cant reproduce


private endpoint for functions

From Enterprise-Scale-APIM created by cykreng: cykreng/Enterprise-Scale-APIM#36
add privatelinks to the backend functions

@cykreng  can you please assign it to me - I guess, it is covered by my backend PR. thx

Should be fixed with PR #47


Add BitSet, Timestamp, Proxy and Throwable native serializers

Wow, cool :)

There is a another commit relating to class loading with the proxy I.e.  Actually using it.  I am not sure best way to do it so I will do a pull request and get your feedback.


Implement RFC-040 and solve the oft requested recursive library loading problem

https://github.com/chef/chef-rfc/blob/master/rfc040-on-demand-cookbook-libraries.md

I would be really interested by having this one.
Our use case is the following:
we often add a libraries/kitchen_patch.rb file to override attributes values or library code for kitchen/chefspec.
The idea is that a cookbook should not require any modification by users when used in kitchen/chefspec. It allows us to mock interaction with some external api to avoid every user to rewrite the same mocking code in cookbooks depending on this one.
However, because of library loading (instead of require) and alphabetical loading of files, this technique is harder to implement.
We are either forced to move the file to zz_kitchen_patch (very unelegant) or patch the original libraries to detect they've already been loaded once and skip other loading (reimplementing require logic).

john left the company and its not on anyone's radar at all.
i don't know why i put it high priority, its certainly not being treated that way.

ok thx for the update @lamont-granquist


Add Breakpoint at runtime

It is impossible to add a breakpoint at runtime.  Debugger will ignore it. Only after restart bebugger will stop at it.

Checked this today on d123c89c5802777e02402108d9271ed2f29368fe build and it seems it's solved now.


Custom schemas/refinements

Just a heads up that I'd hope we could add a mechanism for refinements/customs schemas at some point.
However, I think this would be blocked by https://github.com/colinhacks/zod/issues/2515

Named Superrefinements whould be possible with a functionsdictionary
have tested it on the deserialization branch
looks like that:

If you are interessed i can make a pull request

Named Superrefinements whould be possible with a functionsdictionary have tested it on the deserialization branch
looks like that:
If you are interessed i can make a pull request

Looks to me to be a very good solution, at least if Zod is not going to support named effects so as to avoid the need for passing options to zerialize... I'm curious as to how you're doing the function comparison (function object identity or string comparison)

@rebeccaEller Do you think you could submit a PR?


Repo sync for protected CLA branch

The pull request is created from privateToPublic-push-CLA-signedCommits637607114610318888 to privateToPublic-push-CLA-signedCommits to fix git push error for protected CLA branch

Docs Build status updates of commit 7bf090d:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error-GitBranchDeletedOrForcePushed] Cannot sync git repo to specified commit because branch privateToPublic-push-CLA-signedCommits637607114610318888 has been deleted or has been force pushed

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Sync SSL Stream test

Fix the bug on the detached thread wolfSSL-Server for testing

fixed: https://github.com/harsath/Blueth/commit/72bb7f6d79e0787df757cb0fda40593de1d4b376


404 Not found BIG TIME

I don't know how to explain but either ubuntu deleted some things from their archive, or the link is incorrect.

Have you tried proxy network it? @yldbouk

It seems you try to fetch updates for Ubuntu Lucid Lynx (10.04). But its support expired at the 29 April 2015 for servers. So Lucid packages aren't available anymore. Look here for active distributions.


[DO NOT MERGE] Dummy PR for running perf

Will run perf mem record via ssh.

Closing, can resurrect if needed


fix: ZeRO3 does not work with MoE models

Deepspeed #4966
#1998

Perhaps this should be placed in patcher.py

Deepspeed can now automatically add leaf modules

LGTM!

@hiyouga hey， the full finetune for mixtral with lora is still hang for nccl time out.....

@xs1997zju see https://github.com/hiyouga/LLaMA-Factory/issues/1683

@hiyouga  export NCCL_P2P_LEVEL=NVL it does't work, do u have ever successfully full-finetune the mixtral-8x7b with zero-3? I mean, full-finetune, not lora..

https://github.com/hiyouga/LLaMA-Factory/issues/2315
solved here


Feature Request:

Hey @SeydX,
is it possible that you show the pollen forestcast with Air Quality?
https://support.tado.com/de/articles/3405556-was-ist-der-raumluft-komfort-skill

That was the fastest enhancement I've ever had 🤣👍👌

😄😄😄


fs.realpathSync.native fails when on a RAM disk on Windows

I see the comment further down wrapping a different part of the realpathSync function in a try/catch for this case, but the top part also fails when in this situation.
If I change the code to this:

function realpathSync(filepath) {
	if (typeof fs.realpathSync.native === 'function') {
		try {
			return fs.realpathSync.native(filepath);
		} catch (err) {
			/* Probably RAM-disk on windows. */
		}
	}

	const fsBinding = process.binding('fs');

	if (fsBinding.realpath) {
		try {
			return fsBinding.realpath(filepath, 'utf8');
		} catch (err) {
			/* Probably RAM-disk on windows. */
		}
	}

	return fs.realpathSync(filepath);
}

Then the 2nd part of the function (the one with the existing comment) makes node completely crash due to this line:
fsBinding.realpath(filepath, 'utf8');

npm[145404]: src\node_file.cc:1425: Assertion `(argc) >= (3)' failed.
 1: 00007FF6A7380EFA v8::internal::GCIdleTimeHandler::GCIdleTimeHandler+4810
 2: 00007FF6A735A296 node::MakeCallback+4518
 3: 00007FF6A735A34F node::MakeCallback+4703
 4: 00007FF6A731E762 uv_loop_fork+31394
 5: 00007FF6A7B8ADD2 v8::internal::OptimizingCompileDispatcher::Unblock+60562
 6: 00007FF6A7B8C26D v8::internal::OptimizingCompileDispatcher::Unblock+65837
 7: 00007FF6A7B8B2C9 v8::internal::OptimizingCompileDispatcher::Unblock+61833
 8: 00007FF6A7B8B1AB v8::internal::OptimizingCompileDispatcher::Unblock+61547
 9: 000002F70B1DC5C1

Essentially, under this condition you'd want to skip both of the above attempts and fallback to fs.realpathSync(filepath)

Oh, it aborts? 😞 Would you be able to put together a PR the prevents this?

New PR #39

It's work...
function realpathSync(filepath) {
    if (typeof fs.realpathSync.native === 'function') {
        try {
            return fs.realpathSync.native(filepath);
        } catch (err) {
            /* Probably RAM-disk on windows. */
            return fs.realpathSync(filepath);
        }
    }

    const fsBinding = process.binding('fs');

    if (fsBinding.realpath) {
        try {
            return fsBinding.realpath(filepath, 'utf8');
        } catch (err) {
            /* Probably RAM-disk on windows. */
        }
    }

    return fs.realpathSync(filepath);
}

on one to fix the only bug?

Apart from using a Windows RAM disk, this optimization module breaks under Contrast Security which hides fs.realpathSync.native.  Versions of Node 10 and above changed their "process binding" realpath from sync to async, so getting to line 36 throws the hard abort.
https://github.com/SimenB/realpath-native/blob/7d20312e49bbe283b51df5020bb0b093049b736e/index.js#L36
$ nvm use 9.9.0
Now using node v9.9.0 (npm v5.6.0)

$ node -e 'fs = require("fs"); fsBinding = process.binding("fs"); console.log(fsBinding.realpath(".", "utf8"))'
/Users/USER/DIR

$ nvm use 10.0.0
Now using node v10.0.0 (npm v5.6.0)

$ node -e 'fs = require("fs"); fsBinding = process.binding("fs"); console.log(fsBinding.realpath(".", "utf8"))'
node[4727]: ../src/node_file.cc:1170:void node::fs::RealPath(const FunctionCallbackInfo<v8::Value> &): Assertion `(argc) >= (3)' failed.
 1: node::Abort() [/Users/USER/.nvm/versions/node/v10.0.0/bin/node]
 2: node::InternalCallbackScope::~InternalCallbackScope() [/Users/USER/.nvm/versions/node/v10.0.0/bin/node]
 3: node::fs::RealPath(v8::FunctionCallbackInfo<v8::Value> const&) [/Users/USER/.nvm/versions/node/v10.0.0/bin/node]
 4: v8::internal::FunctionCallbackArguments::Call(v8::internal::CallHandlerInfo*) [/Users/USER/.nvm/versions/node/v10.0.0/bin/node]
 5: v8::internal::MaybeHandle<v8::internal::Object> v8::internal::(anonymous namespace)::HandleApiCallHelper<false>(v8::internal::Isolate*, v8::internal::Handle<v8::internal::HeapObject>, v8::internal::Handle<v8::internal::HeapObject>, v8::internal::Handle<v8::internal::FunctionTemplateInfo>, v8::internal::Handle<v8::internal::Object>, v8::internal::BuiltinArguments) [/Users/USER/.nvm/versions/node/v10.0.0/bin/node]
 6: v8::internal::Builtin_Impl_HandleApiCall(v8::internal::BuiltinArguments, v8::internal::Isolate*) [/Users/latypil/.nvm/versions/node/v10.0.0/bin/node]
 7: 0x3c81dc58427d
Abort trap: 6

https://github.com/nodejs/node/blob/v10.0.0/src/node_file.cc#L1170
Since it's impossible to catch the abort or to find the internal method's contract, I wonder if the optimization of using the native realpath should be dropped in the sync case?  I.e. call fs.realpathSync(".", "utf8") on the above line.

Never mind, the latest Contrast version seems to correctly expose fs.realpathSync.native.

I've published a v3 and deprecated it - all current releases of node supports fs.realpath.native now, so this module is no longer needed.


Update version 1.0.0 of the plugin to the Godot asset library

Is this planned for the 3.2 release of Godot?

The plugin is available in the asset store: https://godotengine.org/asset-library/asset/500


Support for F13 - F24 keys

In the ESP32-BLE-Keyboard library, F13 - F24 are available. It would be nice to implement those too.

https://github.com/DustinWatts/FreeTouchDeck/commit/3edb26dfe430ba7a8ee9319d4e2ef16aa5c5b34f Adds support for F13-F24.
*Note: MacOS only goes up to F20


How to block if it doesn't contain keyword

How do I block elements if it doesn't contain keywords instead of the default 'blocking if it contains'?

Indeed, how do you do that?... Tried the regex !(.keyword to be contained.)    and... it didn't work(!)...
Does the regex work?!...

Nevermind, I actually did it with Regex. I checked both „Complete Match” and „Regex” and then used something like this:
^((?!keyword).)*$
by the way, for some reason the escaping char can't be added there (this char:   \   )


License

Hi @AndreyG,
Thanks for the great work you've done on this project so far, it looks seriously awesome!
I'd be interested in playing around with some of your code, but I'm hesitant to do so without their being a license on the repo -- would you be able to add one? MIT would be awesome, if you'd be happy with that.
Thanks!

Thanks for the interest. MIT looks ok for me.


[v25] - [ ERROR ] runJest: TypeError: runCLI is not a function

🐛 Bug Report

[ ERROR ] runJest: TypeError: runCLI is not a function
To Reproduce
Steps to reproduce the behavior:
Repo: https://github.com/adaept/ae-icon5-component
C:\ae\adaept.com\_components_\ae-icon5-component>npm test

><EMAIL_ADDRESS>test C:\ae\adaept.com\_components_\ae-icon5-component
> stencil test --spec --e2e

[14:29.4]  @stencil/core v1.9.0-14
[14:29.4]  testing e2e and spec files
[14:29.4]  build, aeicon5component, dev mode, started ...
[14:30.9]  transpile started ...
[14:31.4]  transpile finished in 514 ms
[14:31.7]  copy started ...
[14:32.3]  generate styles started ...
[14:32.3]  bundling components started ...
[14:32.4]  generate styles finished in 146 ms
[14:34.6]  bundling components finished in 2.31 s
[14:38.8]  copy finished (2462 files) in 7.05 s
[14:38.8]  build finished in 9.40 s

[14:39.0]  jest args: --e2e --spec --max-workers=4

[ ERROR ]  runJest: TypeError: runCLI is not a function

npm ERR! Test failed.  See above for more details.

C:\ae\adaept.com\_components_\ae-icon5-component>

Downgrade to 24.9 shows this result:
C:\ae\adaept.com\_components_\ae-icon5-component>npm test

><EMAIL_ADDRESS>test C:\ae\adaept.com\_components_\ae-icon5-component
> stencil test --spec --e2e

[20:34.8]  @stencil/core v1.9.0-14
[20:34.9]  testing e2e and spec files
[20:34.9]  build, aeicon5component, dev mode, started ...
[20:35.7]  transpile started ...
[20:36.5]  transpile finished in 848 ms
[20:36.9]  copy started ...
[20:37.4]  generate styles started ...
[20:37.4]  bundling components started ...
[20:37.7]  generate styles finished in 326 ms
[20:40.0]  bundling components finished in 2.57 s
[20:40.6]  copy finished (2462 files) in 3.72 s
[20:40.8]  build finished in 5.92 s

[20:40.9]  jest args: --e2e --spec --max-workers=4
 FAIL  src/components/ae-icon5-component/ae-icon5-component.spec.ts
  ● Test suite failed to run

    Your test suite must contain at least one test.

      at node_modules/@jest/core/build/TestScheduler.js:242:24
      at asyncGeneratorStep (node_modules/@jest/core/build/TestScheduler.js:131:24)
      at _next (node_modules/@jest/core/build/TestScheduler.js:151:9)
      at node_modules/@jest/core/build/TestScheduler.js:156:7
      at node_modules/@jest/core/build/TestScheduler.js:148:12
      at onResult (node_modules/@jest/core/build/TestScheduler.js:271:25)

Test Suites: 1 failed, 1 total
Tests:       0 total
Snapshots:   0 total
Time:        3.48s
Ran all test suites.

npm ERR! Test failed.  See above for more details.

C:\ae\adaept.com\_components_\ae-icon5-component>

The component has an empty spec test file so the report from
jest 24.9 is correct.
The error message from jest 25 is inaccurate and misleading.
Ref: https://github.com/ionic-team/stencil/issues/2168
Expected behavior

Better error report that matches the situation.
Link to repl or repo (highly encouraged)

envinfo

24.9
C:\ae\adaept.com\_components_\ae-icon5-component>npx envinfo --preset jest
npx: installed 1 in 10.129s

  System:
    OS: Windows 10 10.0.18363
    CPU: (4) x64 Intel(R) Core(TM) i7-3540M CPU @ 3.00GHz
  Binaries:
    Node: 12.13.0 - C:\Program Files\nodejs\node.EXE
    Yarn: 1.17.3 - C:\Program Files (x86)\Yarn\bin\yarn.CMD
    npm: 6.13.4 - C:\Program Files\nodejs\npm.CMD
  npmPackages:
    jest: 24.9.0 => 24.9.0

25
C:\ae\adaept.com\_components_\ae-icon5-component>npx envinfo --preset jest
npx: installed 1 in 3.091s

  System:
    OS: Windows 10 10.0.18363
    CPU: (4) x64 Intel(R) Core(TM) i7-3540M CPU @ 3.00GHz
  Binaries:
    Node: 12.13.0 - C:\Program Files\nodejs\node.EXE
    Yarn: 1.17.3 - C:\Program Files (x86)\Yarn\bin\yarn.CMD
    npm: 6.13.4 - C:\Program Files\nodejs\npm.CMD
  npmPackages:
    jest: 25.1.0 => 25.1.0

This is due to how stencil import runCLI here: https://github.com/ionic-team/stencil/blob/45821831683d0a468b1e38a3179b4c03c2acba7a/src/testing/jest/jest-runner.ts#L31. This was changed in https://github.com/facebook/jest/pull/8874/files#r317470510
They can change their import from const { runCLI } = require('jest-cli'); to const { runCLI } = require('@jest/core');. That package started shipping in 24.3.0, so it should probably be a fallback if runCLI is not found from jest-cli package to support all releases of Jest 24.


Update pricing details on the support tiers

The developer support was recently changed to be the greater of $29 or 3% of your bill.
Also change from "at least 10%" to "up to 10%" in the next paragraph. No support plan adds more than 10% to your bill.

The pricing detail page might be a good link to include as it explains it with some examples: https://aws.amazon.com/premiumsupport/pricing/
Is it worth mentioning that older accounts can still get the original pricing if they already had it set up?

👍 Thanks!


Obtaining FCI hamiltonian for "larger" systems.

I am having trouble accessing a hamiltonian matrix for larger systems that still should be manageable memory wise, and can't find any info on this error. I'll include the relevant code below, but basically the fci.spin_direct1.pspace()[1] function kills my kernel when run for minimal basis H10, but works fine for minimal basis H8. Is there a way to improve this function's performance? If not, is there another way to generate the hamiltonian matrix in a sparse form for bigger systems? Relevant code below:
def create_ham_and_amps2(mol):
mol_UCC = pyscf.M(
atom = mol,
basis = 'sto3g',
unit = "B"
)
elec_num = sum(mol_UCC.nelec)
myhf = mol_UCC.HF()
myhf.kernel()
mymp2 = myhf.MP2()
mymp2.kernel()#run mp2
C = myhf.mo_coeff #molecular coefficient matrix
h1=np.matmul((C.T),np.matmul((myhf.get_hcore()),(C)))
h2=ao2mo.kernel(mol_UCC,C)
h2=ao2mo.restore(8,h2,mol_UCC.nao_nr())
Ham = fci.direct_spin1.pspace(h1, h2, mol_UCC.nao_nr(), elec_num, np=70000)[1] #creates Hamiltonian
nspatorbs = int(mol_UCC.nao_nr())
return elec_num,nspatorbs,Ham,mymp2.t2,myhf.energy_nuc(),h1,h2
atom_string = 'H 0 0 0;H 0 0 1;H 0 0 2;H 0 0 3;H 0 0 4;H 0 0 5;H 0 0 6;H 0 0 7;H 0 0 8;H 0 0 9'
elec_num,nspatorbs,Ham,doubles_amps,nuclear_en,h1,h2 = create_ham_and_amps2(atom_string)

# Size of the FCI Hamiltonian matrix in memory
((8 choose 4)^4)*8/1e6 = 192 Mb # Minimal basis H8
((10 choose 5)^4)*8/1e9 = 32.3 Gb # Minimal basis H10

These are two very, very different things that you are asking your computer to do.
The Hamiltonian-vector product can be accessed by the absorb_h1e and contract_2e functions:
x = # some vector in FCI space
h2eff = fci.direct_spin1.absorb_h1e (h1, h2, mol_UCC.nao_nr (), mol_UCC.nelec, .5)
hx = contract_2e (h2eff, x, mol_UCC.nao_nr (), mol_UCC.nelec) # Hamiltonian-vector product


Integration Test: flaky debug breakpoints

From https://monacotools.visualstudio.com/DefaultCollection/Monaco/_build/results?buildId=66506&view=logs&j=a5e52b91-c83f-5429-4a68-c246fc63a4f7&t=a83823bd-5dbd-5313-d0d6-a425f162cca0
 1) Debug breakpoints:
     Error: Timeout of 60000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves.
      at listOnTimeout (internal/timers.js:531:17)
      at processTimers (internal/timers.js:475:7)

@bpasero thanks for filling this.
I pushed a potential fix for this. The problem is that I am using a command palette action that needs the editor to have focus, and I believe when integration tests are running that the editor can loose focus.
Now I am just reasgning focus to the editor to make sure.
If the fix does not solve the issue I am fine with removing testing this focus related commands, since they might not be the best thing for integration tests.


Wrong spacing in side by side view

Precondition: You're a registered user with saved credit card(s).
Reproduce:
1 Log in
2 Go to Account > Payment Settings

Issue: There is an extra line, when Firefox browser window is in "side-by-side" view.

It was not clear to me what exactly was labeled as a bug here. I assume it refers to "Credit Card" breaking into two lines when the page content resizes due to the width of the stores displayed viewport being at the lg breakpoint (standard >991px and <1200px) on a desktop PC browser view. If that is the case I recommend closing and reopening this issue under a new name and description for the sake of clarity. If this is the reported issue it is still present as of v2.2


Fix e2e test and enable channel error

This PR combines two significant issues. It fixes the e2e-test, which was not working, and the issue that the channel error was not being simulated.

This change is

Wait, I got the error in e2e-test. the log file size might be a problem.
e2e-test An error occurred while provisioning resources (Error Type: Disconnect).
--
[e2e-test](https://github.com/sfc-aqua/quisp/actions/runs/3468661312/jobs/5794726778)
An error occurred while provisioning resources (Error Type: Disconnect).

@res6idue could you check this PR? I merged the disabled logger and fix the test.sh


Implement ActiveRecord::RecordNotFound interface

We should include model, id and primary_key
attributes too to have the same interface as ActiveRecord::RecordNotFound.
This would make it possible to do something like this
rescue_from ActiveRecord::RecordNotFound, ActiveHash::RecordNotFound, :render_not_found

def not_found
  render_error :record_not_found, message: "#{exception.model} not found.", status: :not_found
end

@ChrisBr I would vote to update the specs to rspec 3. There's a conversion tool called transpec I've used in the past that worked well: https://github.com/yujinakayama/transpec

@ChrisBr I would vote to update the specs to rspec 3. There's a conversion tool called transpec I've used in the past that worked well: https://github.com/yujinakayama/transpec

I think this is a bit outside scope of this PR? 🤔

@ChrisBr Oh, definitely, I was just suggesting that happen first in a separate PR, then go from there.
I'm actually trying to do it now but am running into some sort of bundler conflict....

@ChrisBr Can you either update, or if you don't have the time, I may be able to rebase this for you and merge.

Can you either update, or if you don't have the time, I may be able to rebase this for you and merge.

Rebased @kbrock 👍

@kbrock I think we need to update the RSpec version in the gemfiles directory too.
https://github.com/zilkey/active_hash/pull/213

rerunning the builds and hoping that we will be all set on that one soon

rerunning the builds and hoping that we will be all set on that one soon

Seemed to work 👍 Thanks for a lot of merges the last couple of days 👏👏👏

thanks for helping us move forward.
You've been giving us some good stuff


Add support for optionally post-rendering hooks

Fixes #7891; fixes #10961.
This PR adds support for optionally post-rendering hooks.
I opted to implement this by adding two new CLI flags: --post-renderer-hooks and --post-renderer-hooks-args. Why?

It retains full backwards compatibility: we default to not post-rendering hooks.

It gives users the ability to customize their main manifests and hooks in separate ways. One example of where this might be useful is if somebody is using kubectl-kustomize as their post-renderer to add a new resource to their chart. We would duplicate the new resource in the hooks manifest if we reused that post-renderer as-is, which does not seem like a good idea.

Two remaining possible issues with this implementation are:

It repeatedly re-execs the hooks post-renderer against each hook manifest, which may incur a perf penalty.
Some post-renderers may want to apply different transforms for different hooks and may find parsing the comment added to the hook manifests to be challenging.

But I think these issues are fine to ignore for now: users can use the Go library or write a custom plugin if they want finer-grained control.
If applicable:

[ ] this PR contains documentation
[x] this PR contains unit tests
[x] this PR has been tested for backwards compatibility

I don't think the double run is a good idea. In one run the post-renderer doesn't know about hooks and in the second run it knows only about hooks. There are likely use-cases where the post-renderer wants to know about all resources at once.
I think there is no need to duplicate the --post-renderer and post-renderer-args flags. Rather, it would be simpler to add a --post-render-hooks flag that adds hooks to the data sent to the post-renderer. If the post-renderer wants to adapt its behaviour depending on whether a given resource is a hook or not, it can check the resource for Helm hook annotations to make a decision.


feat(comp: divider): add divider component

link #32
PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines
[x] Tests for the changes have been added/updated or not needed
[x] Docs and demo have been added/updated or not needed

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Component style update
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

What is the new behavior?
Other information

@danranVm 麻烦安排review

经过我们其他的几个 reviewer 的讨论，建议去掉 position 的 string 类型，只支持 left center right
十分抱歉，:cry:

@danranVm @Pupils-web 麻烦重新review

@LaamGinghong  感谢你的 PR, LGTM


[SR-6361] Fix Data.withUnsafeMutableBytes() for slices with length < range.lowerBound

Update to overlay to match changes done to Data.swift that are approved in PR to swift-corelibs-foundation requested by @phausler:
https://github.com/apple/swift-corelibs-foundation/pull/1314
This PR will fix fatal error: UnsafeMutableRawBufferPointer with negative count when using Data.withUnsafeMutableBytes() for slices with length < range.lowerBound
Resolves SR-6361.
Thank you!

@swift-ci please test and merge

Thank you very much for following up on this!

@phausler swift-ci was unable to find macOS machine, maybe it's correlated to the maintenance that happened at 6pm PST, can we try again?

@swift-ci please test


Menu Indicator not scrolling upon select function calling

I am facing an issue with this, issue when I select 3rd page and change tab from tabBarController now I want to switch back 1st tab and 1st Page through select Method it selects first page, but menu indicator not going to first page position.
I tried following on viewWillAppear
pagingViewController.select(index: 0, animated: true)
Thanks.

Hi @sinhaGIT! This should be fixed in #371 🙂 You can target the master branch for now. Will release a new version soon!


local tls: add ca cert export and documentation

https://phabricator.wikimedia.org/T378691
This adds a makefile target to easily export the local CA certiface that gets used to self-sign the locally used TLS certificates. This can get used to circumvent browser warnings.

I'm super confused right now - I thought I was able to import the certificate into firefox yesterday but now it doesnt seem to work?!

for some reason the CA cert in the secret is not a CA cert but the same cert as the one in data.tls.crt - I have no idea if this changed now since yesterday somehow but I'm 99% sure I was able to import it into firefox, but I also have no idea what could've changed now.

I can only imagine I made a mistake yesterday. But I found a way to do this now https://cert-manager.io/docs/configuration/selfsigned/#bootstrapping-ca-issuers
This will require a chart update though.

adjusted this accordingly and the new chart PR is here: https://github.com/wbstack/charts/pull/184

sorry, this should be it's own PR but now slipped in. I was curious how hard it would be to get argocd now locally a valid cert, and it required only very few changes, so I added it (requires one more chart change though to set the namespace https://github.com/wbstack/charts/pull/185)


Enhanced Delete of Points Method in API: Removing Parameter

I have modified the delete method by removing the requirement to include points: in the parameters. Now, if neither points: nor filters: are provided, an error will be generated. This change is in line with the guidelines provided in the delete_points documentation.

@Jhonnyr97 Thank you!


"boon" spell causing tons of issues

Hello,
The way the "boon" spell now works is causing tons of various issues. When the spell ends (because it is cancelled or you run out of mana), the effects given by boon are not withdrawn, you are in fact rollbacked to the state you were in before you cast the spell. That means, if you had poison 1:30 before casting the spell, then you cast it and then un-cast it after one minute, you will be rollbacked to your poison effect that lasts 1:30 again.
Even more annoying : when you activate Boon, and then electrify a creeper with chainlightning, and the creeper explodes, when Boon will end the creeper will actually spawn back to life !
Of course feel free to tell me if there is a way to fix this on our end.

I would just disable the spell for now. Spells.yml:
boon:
  enabled: false

I think I'll rather modify it to make it work like it worked before (just adding effects for a set amount of time), waiting for a solution for this.

Should be easy enough- something like this is how it used to work:
https://github.com/elBukkit/MagicPlugin/blob/1.8/src/main/resources/defaults/spells.defaults.yml#L377


Update to the latest build conventions

coverage: 93.704%. remained the same
when pulling 473531efe842755737fe03072415a6bdc98ef9f2 on build
into ad09b201cc1174402633bf2a3b81ad3dfd01ae90 on main.


Oldest version of jQuery library that is supported

Dealing with a corporate website - they're using 1.8.14 which doesn't seem to work. It'll be difficult to get them to upgrade to the latest because of all the other jQuery plugins they're using. I tried 1.11 locally and it works great but wondering if there's something that can be done for a legacy library version.

Seems to work fine for me with 1.8.3 and even back to 1.6.4.
See this fiddle: https://jsfiddle.net/liabru/cqnvgvxd/
Can you provide more information or a fiddle on the issue you're seeing?

I'm going to close this and assume you got it working, otherwise please respond with more info. Thanks.


mint non functional on hyprland

I dont know how to word the title better but mint doesnt work on hyprland
if you need any more info from me ask :3
the log file doesnt seem to have alot of info but I'll send it anyways
drg-mod-integration.log

can confirm

can confirm
after a bit of talking on discord someone told me I can fix this by launching it in the terminal with env -u WAYLAND_DISPLAY ./drg_mod_integration

I dont know if I should close the issue or not
but it does work setting the env

duplicate of #184


Automation of assembly and unit testing

Implement the processes of automatic assembly and launch of unit tests for branch 0.20 with a trigger for pull request

I am looking at how to do this with GitHub actions.  AWS CodeBuild is another option I am very familiar with and can use github as a repository as a fallback.

I have a github actions yaml file created in my repo which complete make + make check + make deploy: https://github.com/tawmaz/pocketnet.core/blob/master/.github/workflows/makecheck.yml
Here is a test run against the old reindexer build: https://github.com/tawmaz/pocketnet.core/runs/4723888680?check_suite_focus=true
It needs a few tweaks to upload the resultant file and speed up the build.  Right now it takes about an hour to complete.

https://github.com/pocketnetteam/pocketnet.core/pull/141

Here is the first successful automated build + testrun for the pocketnet.core repo: https://github.com/pocketnetteam/pocketnet.core/actions/runs/1681403579
It will run automatically for pull requests and can also be invoked manually through the Actions tab.


cat client for erlang

hi~
###erlang语言的cat客户端：
https://github.com/glasses1989/erlcat
需要的话，可以贡献出来；

建议提交PR发自我的iPhone------------------ Original ------------------From: GlassesMan<EMAIL_ADDRESS>Mon,Apr 22,2019 3:40 PMTo: dianping/cat<EMAIL_ADDRESS>Subscribed<EMAIL_ADDRESS>Re: [dianping/cat] cat client for erlang (#1673)hi~
###erlang语言的cat客户端：
https://github.com/glasses1989/erlcat
需要的话，可以贡献出来；
—You are receiving this because you are subscribed to this thread.Reply to this email directly, view it on GitHub, or mute the thread.
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/dianping/cat","title":"dianping/cat","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/dianping/cat"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"cat client for erlang (#1673)"}],"action":{"name":"View Issue","url":"https://github.com/dianping/cat/issues/1673"}}}
[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/dianping/cat/issues/1673",
"url": "https://github.com/dianping/cat/issues/1673",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]

👍刚看了下，建议完善下API的使用文档，给我提交PR

👍刚看了下，建议完善下API的使用文档，给我提交PR

https://github.com/dianping/cat/pull/1694


Does not work with Jira 8.4 because of API change

Please see here https://developer.atlassian.com/server/jira/platform/jira-rest-api-examples/
It does not work anymore with Jira 8.4+  because the URL format has been changed.

Thank you for solving this mystery for me.
I'm creating a new project, phpexperts/jira-speaker, but it's going to be extremely feature incomplete. Basically only things I need, which right now is issue creation...


Upload files

when you choose to upload files. search is not showing up in the modal.
truncating file names.

width has been increased and file truncation is prevented.


chore: Move Dependabot to monthly

There is also a "weekly" cadence, but I figured since there aren't weekly releases of the package that it is probably OK to reduce the frequency/noise of these PRs

I appreciate the idea and the contribution, but I actually like having it daily. It makes it easier to keep up with changes and when it comes time to release, I never need to worry about how out of date things are. I'd like to leave this as is please. Thank you!


node rm can be applied on not only active node

In docker's original code, docker node rm --help shows that --force flag's description is Force remove an active node.
While I think --force can not only be used for active node, but paused node, and drain node as well.
As a result, I tried to change this flag description.
Here are some examples that removing drain node and pause node without --force are not OK.
root@ubuntu:~# docker node update --availability=pause 34pn48fgq7bf4gg1zhm8d4pok
34pn48fgq7bf4gg1zhm8d4pok
root@ubuntu:~# docker node ls
ID                           HOSTNAME  STATUS  AVAILABILITY  MANAGER STATUS
34pn48fgq7bf4gg1zhm8d4pok    ubuntu    Ready   Pause
bs7spdbpogrny2oywi5q1nrl0 *  ubuntu    Ready   Active        Leader
root@ubuntu:~# docker node rm 34pn48fgq7bf4gg1zhm8d4pok
Error response from daemon: rpc error: code = 9 desc = node 34pn48fgq7bf4gg1zhm8d4pok is not down and can't be removed

And
root@ubuntu:~# docker node update --availability=drain 34tisc44r4uj70qbiac5loaoh
34tisc44r4uj70qbiac5loaoh
root@ubuntu:~# docker node ls
ID                           HOSTNAME  STATUS  AVAILABILITY  MANAGER STATUS
34tisc44r4uj70qbiac5loaoh    ubuntu    Ready   Drain
bs7spdbpogrny2oywi5q1nrl0 *  ubuntu    Ready   Active        Leader
root@ubuntu:~# docker node rm 34tisc44r4uj70qbiac5loaoh
Error response from daemon: rpc error: code = 9 desc = node 34tisc44r4uj70qbiac5loaoh is not down and can't be removed

- What I did
- How I did it
- How to verify it
- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)
Signed-off-by: allencloud<EMAIL_ADDRESS>

/cc @aaronlehmann @thaJeztah @mstanleyjones

cc @diogomonica
I think the intended meaning of "active" here was that it's still connected. I guess this is a bit confusing because "active" is also an availability state.

@aaronlehmann

I think the intended meaning of "active" here was that it's still connected.

May be confusing as well if we mention that, because if a node looses connectivity we can remove it as well ("connected" here means: joined?)

LGTM

:tada:


[v0.17] Update glutin, winit

Cherry pick 734a4fdcb710c89aca52a1a774de18403ef8011f to release support for glutin 0.13 / winit 0.11
PR checklist:

[x] tested examples with the following backends: gl

@alexheretic which of those do you need published? all of them?

Just gfx_window_glutin will do
On 2 Mar 2018 19:25, "Dzmitry Malyshau"<EMAIL_ADDRESS>wrote:
@alexheretic https://github.com/alexheretic which of those do you need
published? all of them?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/gfx-rs/gfx/pull/1866#issuecomment-370026378, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ACOT19vhDXHuQK3ZNmo5npo5BmiBpr47ks5taZzDgaJpZM4SZpo8
.

https://crates.io/crates/gfx_window_glutin/0.21.0

@kvark Thank you!