linebreak-style .eslintrc.js

Fix for eslint error when working on windows. Without this rule code for people on windows looks like this:

Since we have people working on different OS and code editors I think we should use this rule.
https://eslint.org/docs/rules/linebreak-style#windows

Dear Bill Gates, please fix windows es lint issues


Maplibre.Offlinemanager async call problem

Hello,
We found a strange thing (maybe a bug?), when we tried to use MapLibreGL.offlineManager.createPack function.
Example code snippet:
await MapLibreGL.offlineManager.createPack({
name: 'offline',
styleURL: OFFLINE_MAP,
bounds: offlineBBox,
minZoom: 5,
maxZoom: 22
}, (pack, progressStatus) => {
console.log(progressStatus.percentage);
}, (err) => {
console.log("Error happened");
});
console.log("When I called");
We call this code snipppet from async function.
The problem is the following. "When I called" console.log is the first thing, which was written to console output instead of progress status.
We  don't understand why don't wait "await" keyword the createPack async function return.
Thank you for your help.

The task of creating pack is done. But it does not mean the pack is downloaded. I think this is intentional behaviour as the user might anyway leave the app while the pack is downloading. So it is not a reliable to wait for if anyway.


Directline webchat not working in React Strict Mode

Is it an issue related to Adaptive Cards?
No
Is this an accessibility issue?
No
What version of Web Chat are you using?
Latest production
Which distribution are you using Web Chat from?
NPM
Which hosting environment does this issue primarily affect?
Web apps
Which browsers and platforms do the issue happened?
Browser: Edge (latest), Browser: Chrome (latest), Browser: Firefox (latest)
Which area does this issue affect?
Others or unrelated
What is the public URL for the website?
No response
Please describe the bug
Minimizable web chat example from samples is not working in React Strict Mode.
conversations API is getting cancelled
React Version: 18.2.0
NodeJS: 18.19.1
Do you see any errors in console log?
No response
How to reproduce the issue?

Navigate to samples of webchat from this repo
Go to minimizable-webchat sample
Add React Strict Mode
Install the node modules and start the application
You will see conversations API getting cancelled.

What do you expect?
Bot should start and conversations API should succeed.
NOTE: Bot works if React Strict Mode is removed.
What actually happened?
Bot shows "connecting..." and not starting. (Attached screenshot for the same)
Do you have any screenshots or recordings to repro the issue?

Adaptive Card JSON
No response
Additional context
No response

I've also encountered this with a brand new project using react 18.2.66 as per the README, using bot framework 4.16.0

Can also confirm that this is a problem with React 18.3.1 with bot framework 4.18.0

Is there any update on this issue or workaround to solve it


Support for receivers without positional parameters?

On one of the things I'm working on, blinker.py seems like a perfect solution -- if I could connect receivers that don't take any positional or keyword arguments. That way, I could integrate blinker without having to add an empty positional just to provide access. The necessary modification for this seems fairly light-weight and potentially useful in several cases -- but I'm wondering if it might create unforeseen problems.
In blinker/base.py:
def _get_ret_val(func, val, **kwargs):
    try:
        ret_val = func(val, **kwargs)
    except TypeError:
        if val is None:
            ret_val = func(**kwargs)
        else:
            raise
    return ret_val

Then, adding it to the final statement in Signal.send...
    def send(self, *sender, **kwargs):
        if len(sender) == 0:
            sender = None
        elif len(sender) > 1:
            raise TypeError('send() accepts only one positional argument, '
                            '%s given' % len(sender))
        else:
            sender = sender[0]
        if not self.receivers:
            return []
        else:
            return [(receiver, _get_ret_val(receiver, sender, **kwargs))
                    for receiver in self.receivers_for(sender)]

The only problem with this I can think of is that None sender might carry special significance; does it?
(Apologies in advance if this is not the place to ask these questions; I'm a bit new to this!)

I don't plan to add this sort of signature checking. Receiver functions are intended to get the sender as the first positional argument, and that keeps the API and implementation simple. If you want to reuse an existing function for a receiver without changing its signature, you can write a fairly trivial wrapper for it.
from functools import update_wrapper

def as_receiver(f):
    def wrapper(sender, **kwargs):
        return f(**kwargs)
    return update_wrapper(wrapper, f)

my_receiver = as_receiver(my_func)
my_signal.connect(my_receiver)


Numpy-style docstrings

In these python files make sure that all functions have numpy-style docstrings:
_ai_github_utilities.py
_github_utilities.py
The code in the Python files should stay the same otherwise.

git-bob solve

This message was generated by git-bob 0.1.0, an AI-based assistant.
Hi @github-actions[bot],
thanks for reaching out! Unfortunately, I'm not allowed to respond to you directly.
I need approval from a repository member: @haesleinhuepf
Best,
git-bob

This message was generated by git-bob 0.1.0, an AI-based assistant.
I created a branch with a potential solution here. I will attempt to send a pull-request.

We MUST make sure that the Python code remains the same, and only the docstrings are updated to numpy-style.
git-bob solve

This message was generated by git-bob 0.1.0, an AI-based assistant.
I created a branch with a potential solution here. I will attempt to send a pull-request.

This message was generated by git-bob 0.1.0, an AI-based assistant.
I created a branch with a potential solution here. I will attempt to send a pull-request.

This message was generated by git-bob 0.1.0, an AI-based assistant.
I created a branch with a potential solution here. I will attempt to send a pull-request.

This message was generated by git-bob 0.1.0, an AI-based assistant.
I created a branch with a potential solution here. I will attempt to send a pull-request.

This message was generated by git-bob 0.1.0, an AI-based assistant.
I created a branch with a potential solution here. I will attempt to send a pull-request.


Pycon2016 tutorial; added tests

Coverage increased (+1.1%) to 37.931% when pulling d1a0ab8367e5bdd115af141d53fc9873359749bf on kojoidrissa:pycon2016 into a5390a50b6e8ab83c47c6c64c379c4daf10aa4dc on keeppythonweird:master.


Allow CI jobs to describe/list/pull from s3 bucket

/assign @tzneal @upodroid

@tzneal @upodroid will merge this by hand once you lgtm. failures are flakes unrelated to PR


fixing hyperlinks in python tutorial

Description
Update broken hyperlinks here:
https://mxnet.apache.org/api/python/docs/tutorials/deploy/run-on-aws/use_ec2.html#run-on-an-ec2-instance
For preview:
http://<IP_ADDRESS>/api/python/docs/tutorials/deploy/run-on-aws/use_ec2.html#run-on-an-ec2-instance
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.

[X] Changes are complete (i.e. I finished coding on this PR)
[X] Code is well-documented:
[X] To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@mxnet-bot run ci [unix-gpu]


Separate "Additional trust bundle" for proxy and disconnected settings

https://github.com/stolostron/backlog/issues/22693

/test lint-check-unittests-sonarcloud

/cc @jeswanke


"/device:GPU:0" or "/device:XLA_GPU:0"  ?

When XLA is enabled with  TF_XLA_FLAGS=--tf_xla_auto_jit=2, should I see "/device:GPU:0" or "/device:XLA_GPU:0" in  Tensorflow output ?

You should ignore the XLA_GPU devices in the log output.  They are a legacy way to use XLA that we don't recommend for end users.
If TF detected a /device:GPU:0 then you're good to go.  If not, TF (with or without TF_XLA_FLAGS=--tf_xla_auto_jit=2) will not use a GPU.

@sgambient Please close this thread if it solves your question. Thanks!

Thanks, that  addresses by concern.


I am not able to use this code in my current project i.e. Using react 16.4.1.

Can you please provide some steps in how to include this in a project using React 16.4.1?

Closed due to duplicate #1


Suggestions for improving challenge style guide

Issue Description

Currently, the Contributing Style Guide does not include information on obtaining a unique challenge ID. The appropriate way to obtain the ID would be to run the MongoDB ObjectId() method. In addition, the style guide could have an example/description on how to format the seed files. Having such information in the style guide would be beneficial for campers editing challenges for the first time.

Yup, good idea. Could we not use a generator for this? I mean we have had an editor in the past, but it is now deprecated.
But a generator should be fairly good and a handly tool to implement that will generate an id and check that its unique among all of the available challenges.


Ory CLI: Authentication in Automated Workflows

Preflight checklist

[X] I could not find a solution in the existing issues, docs, nor discussions.
[X] I agree to follow this project's Code of Conduct.
[X] I have read and am following this repository's Contribution Guidelines.
[X] This issue affects my Ory Cloud project.
[X] I have joined the Ory Community Slack.
[X] I am signed up to the Ory Security Patch Newsletter.

Describe your problem
We want to use the CLI in automated workflows (e.g. in CI/CD and automated end-to-end tests) to manage test projects. To do so, we need a way to do non-interactive auth.
Describe your ideal solution
Option A
Command Line Arguments for username and password for "ory auth"
Option B
Environment Variables for username, password and project are detected and used automatically by the CLI
Option C
Similar to B), but using Environment Variables for Personal Access Token and project
Workarounds or alternatives
N/A
Version
Cloud
Additional Context
No response

+1 for this
As a work around, you can generate the .ory-cloud.json file using the interactive auth flow then store that and use (i.e. mount it into the Docker container like I'm doing)
Configuring the client via environment variables or a PWA would be ideal though (option b or c in @kmherrmann's post)

Here's an example bash script that authenticates using the API and generates a config file. The resulting config file can be mounted to a container running ory cli, for example. This is definitely not suitable for production and needs cleaning up if part of a build pipeline.
#!/usr/bin/env bash
set -o nounset
set -o errexit

kratos_initiate_api_auth_flow() {
  local kratos_base_url="${1}"

  local action_url=$(curl -s -X GET \
      -H "Accept: application/json" \
      "${kratos_base_url}/self-service/login/api" | jq -r '.ui.action')

  echo -n "${action_url}"
}

kratos_post_flow_payload() {
  local action_url="${1}"
  local payload="${2}"

  local session=$(curl -s -X POST \
      -H  "Accept: application/json" \
      -H "Content-Type: application/json" \
      -d "${payload}" \
      "${action_url}" | jq)

  echo -n "${session}"
}

kratos_create_session() {
  local kratos_base_url="${1}"
  local kratos_user="${2}"
  local kratos_password="${3}"

  local action_url=$(kratos_initiate_api_auth_flow "${kratos_base_url}")
  local payload="{\"identifier\": \"${kratos_user}\", \"password\": \"${kratos_password}\", \"method\": \"password\"}"

  local session=$(kratos_post_flow_payload "${action_url}" "${payload}")

  echo -n "${session}"
}

kratos_whoami() {
  local kratos_base_url="${1}"
  local kratos_session_token="${2}"

  local identity=$(curl -s -H "Authorization: Bearer ${kratos_session_token}" \
  "${kratos_base_url}/sessions/whoami" | jq)

  echo -n "${identity}"
}

create_ory_cli_config() {
  local session="${1}"

  local kratos_session_token=$(echo -n "${session}" | jq -r '.session_token')
  local kratos_session_id=$(echo -n "${session}" | jq -r '.session.id')
  local kratos_session_email=$(echo -n "${session}" | jq -r '.session.identity.traits.email')

  echo -n "{\"session_token\": \"${kratos_session_token}\", \"session_identity_traits\": {\"ID\": \"${kratos_session_id}\", \"email\": \"${kratos_session_email}\"}}"
}

kratos_base_url="${1}"
kratos_user="${2}"
kratos_password="${3}"

session=$(kratos_create_session "${kratos_base_url}" "${kratos_user}" "${kratos_password}")

if [[ $(echo -n "${session}" | jq -r '.ui.messages') = "null" ]]
then
  echo -n $(create_ory_cli_config "${session}") > "${HOME}/.ory-cloud.json"
else
  local compacted_messages=$(echo -n "${messages}" | jq 'map(select(.type=="error")) | map(.text)' | jq -c -r '.[]')
  echo "Failed to create a session. The following error messages were reported:"
  while IFS= read -r error; do
    echo "${error}" > /dev/stderr
  done <<< "${compacted_messages}"
  exit 1
fi

Awesome, thank you!
We will be fixing this by using OAuth2 for the CLI. There is already some progress on this, but it takes a bit of time to finish it completely.

This is now possible with workspace api keys!


add statusIconLabel to FlashBar to provide an accessible alternative …

Description
Our form field errors have an error icon that currently has no text equivalent. This PR adds a prop to provide a text alternative.

add statusIconLabel prop to FlashBar which creates an aria-label wrapper around the status icon
update Permutations page to use new prop
Add test to ensure the prop renders an aria-label around the icon

How has this been tested?
Tested manually, ran Axe Core against permutation page, visual regression test, npm test
To test, check the Form Fields permutation page with a screen reader and observe that there is now a text equivalent associated with the error icon
Documentation changes
[Do the changes include any API documentation changes?]

[X] Yes, this change contains documentation changes.
[ ] No.

Related Links
fixes AWSUI-18967

Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness

[X] Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
[X] Changes do not include unsupported browser features, see CONTRIBUTING.md.
[X] Changes were manually tested for accessibility, see accessibility guidelines.

Security

[ ] If the code handles URLs: all URLs are validated through the checkSafeUrl function.

Testing

[ ] Changes are covered with new/existing unit tests?
[X] Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Hi @jorycunningham . Could you check the a11y tests failure? Seems that some pages using flashbar are missing statusIconLabel.

Hi @jorycunningham  I think the a11y test failed because we have Flashbar in many pages in applayout. Could you check them? Also seems that we miss one in flashbar permutation. You can also check the a11y test locally npm run test:a11y.


Throw exception if Blazor task cannot be honored

Throw exception if Blazor task cannot be honored.
Improvement are:

[x] Failed task in native will now throw in the Blazor corresponding task
[x] Impossibility to connect through socket to native will now throw in the Blazor corresponding task
[x] Inner exception message from native is transferred to the Blazor thrown exception if catched.

This way, it seem now impossible that a given started task may hang forever if something wrong happen on one side.

Already done.


chore: Hide filter bar for no filters & show edit button to owners only

SUMMARY
Following changes were applied to the Filter Bar:

Hide Filter bar where there are no filters
Show edit button for dashboard owners only

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Hide Filter bar where there are no filters
before:

after:

Show edit button for dashboard owners only
before:

after:

TEST PLAN
Verify manually:
Open Dashboard with no filters applied
You should see filter bar hidden at the beginning
Open Dashboard in which you not the owner (and you are not admin)
You should not see edit icon in the Filter bar
ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Changes UI
[ ] Requires DB Migration.
[ ] Confirm DB Migration upgrade and downgrade tested.
[ ] Introduces new feature or API
[ ] Removes existing feature or API

Codecov Report

Merging #52 (1ac43eb) into dashboard-native-filters (c529840) will decrease coverage by 0.93%.
The diff coverage is n/a.

@@                     Coverage Diff                      @@
##           dashboard-native-filters      #52      +/-   ##
============================================================
- Coverage                     64.15%   63.22%   -0.94%
============================================================
  Files                           461      461
  Lines                         28386    28371      -15
============================================================
- Hits                          18211    17937     -274
- Misses                        10175    10434     +259

Flag
Coverage Δ

python
63.22% <ø> (-0.94%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

superset/db_engines/hive.py
0.00% <0.00%> (-85.72%)
:arrow_down:

superset/databases/commands/create.py
32.65% <0.00%> (-59.19%)
:arrow_down:

superset/db_engine_specs/hive.py
54.08% <0.00%> (-29.97%)
:arrow_down:

superset/views/database/mixins.py
59.64% <0.00%> (-22.81%)
:arrow_down:

superset/db_engine_specs/presto.py
69.76% <0.00%> (-12.53%)
:arrow_down:

superset/db_engine_specs/mysql.py
79.59% <0.00%> (-12.25%)
:arrow_down:

superset/databases/commands/update.py
85.71% <0.00%> (-8.17%)
:arrow_down:

superset/databases/dao.py
94.11% <0.00%> (-5.89%)
:arrow_down:

superset/databases/api.py
83.67% <0.00%> (-5.31%)
:arrow_down:

superset/views/database/validators.py
78.94% <0.00%> (-5.27%)
:arrow_down:

... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c529840...1ac43eb. Read the comment docs.

Thanks @villebro, that's good remark! I have improved toggleDashboardFiltersOpen function, let me know if it is ok now.


how to get spring.oauth2.sso.resource.jwt.keyValue

Hi!
I've implemented the auth server, config server and got everything up and running.
But I'm having troubles with the public private keys.
I've generated a new keystore with
keytool -keystore keystore.jks -genkey -alias client
has the application.yml value spring.oauth2.sso.resource.jwt.keyValue got something to do with the keystore i created, and how do I get the https://github.com/spring-cloud-samples/sso/blob/master/src/main/resources/application.yml#L25-L27 value?

The keyValue is a PEM-encoded public key (or key pair for an auth server). You can export it from your keystore or you can curl it from an auth server that's using your keystore (if it's exposing the endpoint), e.g. this one: https://github.com/spring-cloud-samples/authserver.


Broken Link

@jayonthenet commented on Fri Oct 04 2019
Please have a look at section 5 https://docs.microsoft.com/de-de/azure/cloudfoundry/how-cloud-foundry-integrates-with-azure#5-open-service-broker - the link to the tile on Pivotal network is broken (https://network.pivotal.io/products/azure-open-service-broker-pcf/)

Dokumentdetails
⚠ Bearbeiten Sie diesen Abschnitt nicht. Er ist für die Verknüpfung von docs.microsoft.com zum GitHub-Artikel erforderlich.

ID: 6c9ac04f-e205-f3c5-8b7e-9c629cc115e2
Version Independent ID: 4c54cb04-3ac6-7fbe-cc80-efb88da8b94f
Content: Integration von Cloud Foundry in Azure
Content Source: articles/cloudfoundry/how-cloud-foundry-integrates-with-azure.md
Service: virtual-machines-linux
GitHub Login: @ningk
Microsoft Alias: ningk

@srvbpigh commented on Fri Oct 04 2019
Hello, @jayonthenet
Thank you for your feedback.
We are actively reviewing your comments and will get back to you soon.
Kind regards,
Microsoft DOCS International Team

Hi team, please check this issue.
Thanks!

Thanks for the feedback! We are currently investigating and will update you shortly.

I have created a PR with the update and changes will be live shortly.
https://pivotal.io/platform/services-marketplace/data-management/microsoft-azure
Thanks for bringing this to our attention. We will now close this issue. If there are further questions regarding this matter, please tag me in a comment. I will reopen it and we will gladly continue the discussion.


Fact Checks - When we increase the Records Per page to 100, it is not displaying all 100 Fact checks in First page

Fact Checks - When we increase the Records Per page to 100, it is not displaying all 100 Fact checks in First page

@sshankaramanchi How are you changing this limit?


Help/break mode is not showing sometimes in device display

Sometimes Help/break mode is not showing in the device display. when operators punch bundle cards, it shows error. when we restarted or updated the firmware, we've seen device was in help/break mode. for this operators gets confused.

Just like No OP screen, always send break/help message to screen when in break/help mode


Not updating the dict for some reason?

So I am a bit confuse on why this isn't working. While I understand that you can't change things in "ram" why does this  not work?
self.settings = SqliteDict( f'database/devices/{id}/{id}.sqlite', tablename=id, autocommit=True )
self.settings.update( copy.deepcopy( default_settings.default_device_settings ) )
self.settings["profile"] = settings < different settings just a {lots of objects} I tried both = and .update
self.settings["profile"]["device_id"] = id < id has to exist other wise the above wouldn't work, but I can confirm there is an entry here
print(self.settings["profile"]["device_id"]) < says this either blank or does not exist. Why though? I updated the entry. Far as I understand it sqlitedict should like this?
I understand there is a beware section - but if someone can point me in the right direction to make this work still that be great. I am not sure if I am just falling into the beware section and not understanding how to get out of it.

Ok after a bit more testing it looks like SqliteDict does not support nested dicts past the first key. So for example:
self.settings["profile"] = {"device_id": id} < works fine
self.settings["profile"]["device_id"] = id < does not

Sqlitedict supports all (pickleable) Python objects, including nested dicts.
Check out the BEWARE section in https://github.com/RaRe-Technologies/sqlitedict/#documentation for how to store mutable objects.

You need to update the beware section for more examples.


Wrong mask generation in rtc_alarm_get_time in RV-8263 driver

Describe the bug
The mask can be wrong if the alarm register is set to a MAX value because the alarm bit is the highest in the alarm register.
Possible fix
Change the code from
	if (value[0] <= MAX_SEC) {
		timeptr->tm_sec = bcd2bin(value[0]) & SECONDS_BITS;
		(*p_mask) |= RTC_ALARM_TIME_MASK_SECOND;
	}

to
	if (value[0] < MAX_SEC) {
		timeptr->tm_sec = bcd2bin(value[0]) & SECONDS_BITS;
		(*p_mask) |= RTC_ALARM_TIME_MASK_SECOND;
	}

for each alarm field.

@jakubtopic do you agree with this?


Preserve clipboard contents on exit on GNOME 3.34 and later

Fixes #4

Feel free to change this from a draft to a normal PR. I'd be happy to merge it.

I managed to get back to this a bit later than I wanted to, sorry for the delay.

I updated your top comment so the related issue will get closed automatically.


Feature/animation attribute

Ran into a use case where I needed to separate the key attribute for other functionality so I added the animationAttr prop to be able to customize the animation attribute that is used on each child.
I also updated the README for this attribute, the browser logos, and added in a test around this new prop

Coverage increased (+29.0%) to 90.52% when pulling 505a3ebbd08062f79f7cd3951b3ed6dbeb547dcc on LoganArnett:feature/animation-attribute into d29a382328e79546d7a2d088cc1b66d2c196bc48 on react-component:master.

Why adding this?


Inject io.Writer to the SourceRunner instead of using an internal io.WriteCloser

Leave the close and flush details to the user. This way it easily use specific writers and be used in different contextes without changing any internals.

Accidentally used main for the PR, so the 3rd commit is unrelated..
Anyway: the 3rd commit essentially just add some error checks, and a help function to wrap http request to make sure the body is closed properly.


[bug]: unable to sweep funds > non-mandatory-script-verify-flag (Invalid Schnorr signature)

Hello, after my last channel was co-op closed few days ago from remote, i want to sweep all my funds and i get this message
FAIL: [lncli] rpc error: code = Unknown desc = unable to broadcast sweep transaction: unmatched backend error: -26: non-mandatory-script-verify-flag (Invalid Schnorr signature)
the bug was mentioned here  https://github.com/raspiblitz/raspiblitz/issues/3364 by @openoms  and @guggero  but cant find any further infos to this issue.
i have a  raspberry pi 4 /4gb and raspiblitz v1.10 with Linux raspberrypi 6.1.21-v8+
bitcoind v25.0.0 + lnd 0.17.3-beta

Could you join https://lightning.engineering/slack.html and post a message there (and/or send me a dm), it could be easier to help interactively?

alright, thx

@stakoholic

What date was the lnd instance / wallet first created?  or if you're not certain, the earliest possible creation date
Was it created on the raspberry pi?

@dstadulis yes it was created on the raspi and the creation date was at least 2 years ago

@stakoholic was the creation date before March 2022?

looked up for the first tx and it was August 2020


pr-pull: add commit message trailers for pull requests with approved reviews

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[x] Have you written new tests for your changes? Here's an example.

[x] Have you successfully run brew tests with your changes locally?

Prior to the suite of new pr-* commands, a core maintainer who merged a pull request via the brew pull command would have their information added to a commit via a Signed-off-by trailer. (This still happens if a maintainer runs brew pr-pull on their own machine and the git pushes the result, e.g. https://github.com/Homebrew/homebrew-core/commit/1143c8a2e88b9cd595fd27fe78417874d6778ff1)
Currently, however, if you let BrewTestBot automerge a pull request by writing an approving review, that approval is lost during the merge process. This is undesireable from both a "provenance" and a "crediting contributors" perspective.
This pull request addresses the situation by adding a new Approved-by trailer when running brew pr-pull, which uses the GitHub API to get a list of approving reviews for the pull request in question. For example, this pull request and subsequent commit message would have instead been merged as:
mame 0.222

Closes #56952.

Approved-by: Sean Molenaar<EMAIL_ADDRESS>Signed-off-by: BrewTestBot<EMAIL_ADDRESS>
Pinging @Homebrew/core for thoughts, especially on two issues:

This pull request restricts the list of who will be added to the trailers to members of the Homebrew organization. Should this be expanded to anyone who has contributed to Homebrew, or everyone? (Currently this is restricted to MEMBER and OWNER associations)

Do we want Approved-by or something else, like Signed-off-by? The Linux kernel uses Reviewed-by for something similar, though I note we don't use Signed-off-by in the same way as the kernel either.

It would also be great if a few maintainers tested this with brew pr-pull on a pull request, just in case I missed something when testing it myself.

This pull request restricts the list of who will be added to the trailers to members of the Homebrew organization. Should this be expanded to anyone who has contributed to Homebrew, or everyone? (Currently this is restricted to MEMBER and OWNER associations)

I think restricting to members is reasonable!

2. Do we want Approved-by or something else, like Signed-off-by? The Linux kernel uses Reviewed-by for something similar, though I note we don't use Signed-off-by in the same way as the kernel either.

I'm fine with either but would favour something that's used by other projects.

2. Do we want Approved-by or something else, like Signed-off-by? The Linux kernel uses Reviewed-by for something similar, though I note we don't use Signed-off-by in the same way as the kernel either.

I would suggest changing to say Signed-off-by for the review and Completed-by (or Closed-by, Published-by, Merged-by, Committed-by...) for what currently says Signed-off-by.
So in your example:
mame 0.222

Closes #56952.

Signed-off-by: Sean Molenaar<EMAIL_ADDRESS>Completed-by: BrewTestBot<EMAIL_ADDRESS>
To me, the phrase Signed-off-by implies approval, so I think it makes sense for it to list the members who approve. Then, if someone else (or BrewTestBot) is the one to actually merge, it makes sense for them to be listed separately. I think this wording makes that distinction clearer.

I agree with @Rylan12 about the Signed-off-by. Do we even need BrewTestBot as a -By line? It's implicit in the commit authoring.

Do we even need BrewTestBot as a -By line? It's implicit in the commit authoring.

Small but important correction: this person isn't listed as an author but as a committer. This is fine if you only use the GitHub UI but if you use the command line, it doesn't show the committer by default.
Here's an example (https://github.com/Homebrew/homebrew-core/commit/dffc1a4b03ae222e3eec95676383ebcff309426d):
The GitHub UI clearly shows both the author and the committer:

Running the default git log, however, only shows the author:

While you're right that there is some duplicate information, I still think it's a good idea to have both lines so there's never any doubt or confusion, regardless of the tool you use.

Should we just use Signed-off-by for everyone? I'm reading the kernel docs again and it says:

The Signed-off-by: tag indicates that the signer was involved in the development of the patch, or that he/she was in the patch's delivery path.

Arguably both the maintainer approving it and the maintainer / robot merging it are involved in the patch's delivery path.

Fair point. I think I would still argue that having separate tags for reviewers and mergers is clearer, but it's probably not significant enough to warrant going against a convention.
Either way, the important information is there and, in a situation where more clarity is needed, there is also a link to the PR which can clear things up.

Running the default git log, however, only shows the author:

@Rylan12 git show --pretty=fuller gives you more info:

@Rylan12 git show --pretty=fuller gives you more info:

Ahh, good point! I knew you could customize the output but I didn't realize there were easy, builtin ways that do it without requiring a long, complicated, format definition
I'd still prefer leaving the Signed-off-by string in the commit description, mainly for ease of use and because it will still show up in the default git log, but its good to know this command. Thanks!

Personally I don't think it makes sense to have the Signed-off-by ever by a non-human. If @BrewTestBot pulls it: it should reflect the people who ✅d the PR. If it's not from a PR: it shouldn't have a Signed-off-by.

Yeah, I don't think we're at the level yet where I'd consider @BrewTestBot a sign-off. Maybe in a couple of years with a couple of AI based GSoC projects.
Regarding the kernel doc, I think the bot is the delivery path here so we're following that rule regardless.

Gonna merge this since some of my autosquash work depends on this pull request. Thanks for the feedback everyone!


Add JSON value access support in query module

Add JSON value access support.
Example:
q select key, json(value)['data'] where key ^= 'k' & int(json(value)['filter']['number']) > 10
q select key, json(value)['list'][1] where key ^= 'k'

By the way, error report system has refactored. It will provide better error report.

Thank you


[Bug] SGLang v0.4.0 with AMD MI300X

Checklist

[X] 1. I have searched related issues but cannot get the expected help.
[X] 2. The bug has not been fixed in the latest version.
[X] 3. Please note that if the bug-related issue you submitted lacks corresponding environment info and a minimal reproducible demo, it will be challenging for us to reproduce and resolve the issue, reducing the likelihood of receiving feedback.
[X] 4. If the issue you raised is not a bug but a question, please raise a discussion at https://github.com/sgl-project/sglang/discussions/new/choose Otherwise, it will be closed.
[X] 5. Please use English, otherwise it will be closed.

Describe the bug
SGLang v0.4.x AMD MI300X Workload Debug
Bug report:

hip vllm version update
rocm_vllm v0.6.5 deps on outlines==0.1.11
triton compiler error with decode attention

Share AMD MI300X workable workload below
Reproduction
docker image: rocm/vllm-dev:20241218
pip uninstall vllm
git clone https://github.com/ROCm/vllm.git rocm_vllm & cd rocm_vllm
python setup.py develop & cd ..
git clone https://github.com/sgl-project/sglang.git & cd sglang
vim python/pyproject.toml +21 "orjson", "outlines>=0.1.7", "outlines-core>=0.1.17"
vim python/pyproject.toml +30 vllm==0.6.5.dev411+gd08b78b5.rocm634
vim python/sglang/srt/constrained/outlines_backend.py +23 from outlines_core.fsm.json_schema import build_regex_from_schema
vim python/sglang/srt/layers/attention/triton_ops/decode_attention.py +405 BLOCK=32 -> BLOCK=16
pip install -e "python[all_hip]"
one-batch:
python -m sglang.bench_one_batch --batch-size 32 --input 128 --output 32 --model /data/deepseekv2-lite/ --dp 1 --tp 1 --trust-remote-code
server-client:
python3 -m sglang.launch_server --model-path /data/deepseekv2-lite/ --disable-radix-cache --trust-remote-code --tp 2 --enable-dp-attention --mem-fraction-static 0.78
python3 -m sglang.bench_serving --backend sglang --dataset-name random --random-input 1 --random-output 32 --random-range-ratio 1 --num-prompts 1000
Environment
rocm/vllm-dev:20241218
sglang/main commit d95a5f5bf53c639975a426381e0f11aa4099c076
ROCm/vllm/main commit d08b78b50c94239beca3701d286c6d6202b44bd9

nice fix to support deepseek-v2 inference.
as the base image rocm/vllm-dev:20241218 has rocm/vllm installed version as 0.6.5.dev407+gd9fed263.rocm634 , no need to rebuild from source, just change one line in pyproject.toml, make things even simpler.
srt_hip = ["sglang[runtime_common]", "torch", "vllm==0.6.5.dev407+gd9fed263.rocm634"]

Follow the https://github.com/sgl-project/sglang/pull/2601


css rules not applying on different theme class

So i have a set of css rules to handle light mode ( or default)
example:
.featured[min-width = 451px]{
font-size; 14px;
}

this works fine for the default theme, but then i have a css rule to handle dark mode, ex:
.darktheme .featured[min-width = 451px]{
font-size; 20px;
}

and now my styling doesnt work, i talked to some peers and apparently the JS logic to apply the rules might not work when there are non standard classes in front of the parent class. Is there any previous issues about this? can someone guide me on a way to fix it, i assume the issue lies in ElementQueries.JS under the "ApplyRules" function. I'd appreciate any help on fixing this issue.

It might be that "darktheme" is added after styles were already applied. In this case you have to call "ElementQueries.init();" again.

It might be that "darktheme" is added after styles were already applied. In this case you have to call "ElementQueries.init();" again.

Not sure about that. Both default and dark mode have similar class structure, default theme has theme-default, and dark them has theme-dark on the parent div class.
The only difference is that when we call the styling we dont specify .theme-default since theyre the default one, its only when we want different styling for .theme-dark that they stop being applied. Not sure if im explaining correctly but basically both theme-default and theme-dark are loaded identically.

is darktheme added via JavaScript (React/Vue/Angular/jQuery) ?


Error Making Request to Radarr

Found your repo from the issue raised on MattDGTL's repo. I am running the script through Python directly. I set the Radarr and Sonarr url and API keys through environment variables. Sonarr works perfectly fine and is successfully cleaning, but every time the script gets to Radarr, I get this error with the response seeming to be empty (or None). Both Radarr and Sonarr are set up the same way on the local system on localhost:7878 and localhost:8989, but only Radarr has this issue.
2024-04-21 06:57:09,733 [INFO]: ✨ Finished cleaning Sonarr
2024-04-21 06:57:09,734 [INFO]: 👀 Checking Radarr
Traceback (most recent call last):
File "C:\Users\Da Server\AppData\Local\Programs\Python\Python39\lib\site-packages\requests\models.py", line 971, in json
return complexjson.loads(self.text, **kwargs)
File "C:\Users\Da Server\AppData\Local\Programs\Python\Python39\lib\json_init_.py", line 346, in loads
return _default_decoder.decode(s)
File "C:\Users\Da Server\AppData\Local\Programs\Python\Python39\lib\json\decoder.py", line 337, in decode
obj, end = self.raw_decode(s, idx=_w(s, 0).end())
File "C:\Users\Da Server\AppData\Local\Programs\Python\Python39\lib\json\decoder.py", line 355, in raw_decode
raise JSONDecodeError("Expecting value", s, err.value) from None
json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "C:\Users\Da Server\Desktop\arr-cleaner-main\main.py", line 37, in make_api_request
return response.json()  # Parse JSON response
File "C:\Users\Da Server\AppData\Local\Programs\Python\Python39\lib\site-packages\requests\models.py", line 975, in json
raise RequestsJSONDecodeError(e.msg, e.doc, e.pos)
requests.exceptions.JSONDecodeError: Expecting value: line 1 column 1 (char 0)
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "C:\Users\Da Server\Desktop\arr-cleaner-main\main.py", line 100, in
loop.run_until_complete(main())
File "C:\Users\Da Server\AppData\Local\Programs\Python\Python39\lib\asyncio\base_events.py", line 647, in run_until_complete
return future.result()
File "C:\Users\Da Server\Desktop\arr-cleaner-main\main.py", line 91, in main
await remove_stalled_downloads(RADARR_API_URL, RADARR_API_KEY, 'Radarr')
File "C:\Users\Da Server\Desktop\arr-cleaner-main\main.py", line 54, in remove_stalled_downloads
queue = await make_api_request('get', queue_url, api_key, {'page': '1', 'pageSize': await count_records(api_url, api_key)})
File "C:\Users\Da Server\Desktop\arr-cleaner-main\main.py", line 74, in count_records
queue = await make_api_request('get', queue_url, api_key)
File "C:\Users\Da Server\Desktop\arr-cleaner-main\main.py", line 42, in make_api_request
if e.response.status_code == 404:
AttributeError: 'NoneType' object has no attribute 'status_code'

Hmmmmmmmmm, I'll try to aid you the best I can 😄 (I'm not super proficient in Python but let's try to break it down)
It seems to me based on this part:
if e.response.status_code == 404:
AttributeError: 'NoneType' object has no attribute 'status_code'

that the e.response object is null? Is it possible you could share your .env without exposing any keys or sensitive data? To me it seems like the response is not going through so it is not responding anything... So perhaps the url is incorrect? 😋
My ENV looks like this:

Also, I would just mention that I do recommend using https://github.com/ManiMatter/decluttarr, as it includes more features than my fork 😄 If we are not able to solve this, I recommend you check it out

So I checked the urls and they appear to be configured correctly. However, I did check out Decluttarr and that appears to be working for me at the moment, so I'm good if you want to close this issue 😄


Handler function missing third parameter in both javascript/bot and javascript/web of sample k.direct-line-token

Is it an issue related to Adaptive Cards?
No
Is this an accessibility issue?
No
What version of Web Chat are you using?
Latest production
Which distribution are you using Web Chat from?
Unrelated
Which hosting environment does this issue primarily affect?
Web apps
Which browsers and platforms do the issue happened?
Browser: Edge (latest)
Which area does this issue affect?
Protocol or service
What is the public URL for the website?
No response
Please describe the bug
In sample k.direct-line-token, the javascript web and bot project server routes and handlers were not functioning as expected, causing issues with server startup and request handling.
Environment:

npm 8.19.4
node v16.20.1

Do you see any errors in console log?
# npm start

><EMAIL_ADDRESS>start
> node-dev --no-notify --respawn .

AssertionError [ERR_ASSERTION]: Handler [handler-1 on POST /api/messages] is missing a third argument (the "next" callback) but is not an async function. Middleware handlers can be either as
ync/await or callback-based.Callback-based (non-async) handlers should accept three arguments: (req, res, next). Async handler functions should accept maximum of 2 arguments: (req, res).
    at Chain.add (/Users/ram/Documents/bot/BotFramework-WebChat/samples/01.getting-started/k.direct-line-token/javascript/web/node_modules/restify/lib/chain.js:79:16)
    at forEach (/Users/ram/Documents/bot/BotFramework-WebChat/samples/01.getting-started/k.direct-line-token/javascript/web/node_modules/restify/lib/router.js:211:15)
    at Array.forEach (<anonymous>)
    at Router.mount (/Users/ram/Documents/bot/BotFramework-WebChat/samples/01.getting-started/k.direct-line-token/javascript/web/node_modules/restify/lib/router.js:203:14)
    at Server.serverMethod [as post] (/Users/ram/Documents/bot/BotFramework-WebChat/samples/01.getting-started/k.direct-line-token/javascript/web/node_modules/restify/lib/server.js:1779:33)
    at Object.<anonymous> (/Users/ram/Documents/bot/BotFramework-WebChat/samples/01.getting-started/k.direct-line-token/javascript/web/src/index.js:27:8)
    at Module._compile (node:internal/modules/cjs/loader:1198:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1252:10)
    at Object.nodeDevHook [as .js] (/Users/ram/Documents/bot/BotFramework-WebChat/samples/01.getting-started/k.direct-line-token/javascript/web/node_modules/node-dev/lib/hook.js:54:7)
    at Module.load (node:internal/modules/cjs/loader:1076:32)
(node:68169) [DEP0111] DeprecationWarning: Access to process.binding('http_parser') is deprecated.
(Use `node --trace-deprecation ...` to show where the warning was created)
[ERROR] 00:02:19 AssertionError: Handler [handler-1 on POST /api/messages] is missing a third argument (the "next" callback) but is not an async function. Middleware handlers can be either a
sync/await or callback-based.Callback-based (non-async) handlers should accept three arguments: (req, res, next). Async handler functions should accept maximum of 2 arguments: (req, res).

How to reproduce the issue?
This issue reproduces in both javascript/web and javascript/bot in sample sample k.direct-line-token:
javascript/web

Navigate to the root javascript/web project directory.
Run npm i then npm start to start the server.
Send a request to the /api/messages route.
Observe the error related to the missing third parameter in the handler function.

javascript/bot

Navigate to the root javascript/bot project directory.
Run npm i then npm start to start the server.
Send a request to the /api/messages route.
Observe the error related to the missing third parameter in the handler function.

What do you expect?
Requests to the /api/messages route should be handled without errors.
What actually happened?
Received an error indicating the missing third parameter (next callback) in the handler function for the following files:

javascript/bot: createBot.js.
javascript/web: botMessages.js.

Do you have any screenshots or recordings to repro the issue?
No response
Adaptive Card JSON
No response
Additional context
This issue pertains to how Restify expects handler functions to be structured. The function should either be an async function with (req, res) or a callback-based function with (req, res, next).

🔗 Related Issues: #4871, #4872, #4873
I've identified these issues are all related to the k.direct-line-token sample. I'm currently working on a fix to address all three issues together.


How to get base64 data?

The documentation only talk about how to get FILE URI. What If I want to get DATA URL?

Base64 was discussed in #14.  Please look there for several different solutions.


fix: progress buffer color

Types of changes

[ ] New feature
[x] Bug fix
[ ] Documentation change
[ ] Coding style change
[ ] Component style change
[ ] Refactoring
[ ] Performance improvement
[ ] Test cases
[ ] Continuous integration
[ ] Typescript definition change
[ ] Breaking change
[ ] Others

Background and context
fix #257
Solution
add bufferColor props
How is the change tested?

Changelog

Component
Changelog(CN)
Changelog(EN)
Related issues

Progress
设置 color 属性后正常显示进度
Display progress normally after setting color property
Close #257

Checklist:

[x] Test suite passes (npm run test)
[x] Provide changelog for relevant changes (e.g. bug fixes and new features) if applicable.
[x] Changes are submitted to the appropriate branch (e.g. features should be submitted to feature branch and others
should be submitted to main branch)

Other information

@jihainan Hi~，感谢PR。这个轨道条的样色变量需要调整一下，bufferColor之后会给缓冲区域进行使用，没有注释掉放出来早了。这里可以增加一个trackColor的属性

👌 那这里就关闭了。


[ddc] extension type method calls for static interop in expression evaluation fail at runtime

Example
// @dart=3.2

@JS()
library debug_static_interop;

import 'dart:async';
import 'dart:js_util';
import 'dart:js_interop';

import 'package:js/js.dart' hide JS;

@JSExport()
class Counter {
  int value = 0;
  @JSExport('increment')
  void renamedIncrement() {
    value++;
  }
}

@JS('JSCounter')
extension type JSCounterView(JSObject _) implements JSObject {
  external int get value;
  external void increment();
}

void main() {
  Timer.periodic(const Duration(seconds: 1), (Timer t) {
    var dartCounter = Counter();
    var jsCounter = JSCounterView(createDartExport<Counter>(dartCounter));

    jsCounter.increment();
    dartCounter.renamedIncrement();

    print('Dart: ${dartCounter.value}'); // Breakpoint
    print('JS: ${jsCounter.value}');
  });
}

Repro:

add a breakpoint on the line commented with // breakpoint
try evaluating jsCounter.value

Expected: 1
Actual: TypeError: dart.global.JSCounterView|get#value is not a function
Details:

Dart  expression jsCounter.value is compiled to

(function(t, dartCounter, jsCounter) {
    const dart_sdk = require('dart_sdk');
const dart = dart_sdk.dart;
    const web__main = require('web/main');
    const main = web__main.web__main;
    return dart.global['JSCounterView|get#value'](jsCounter);
  }(
    t,
    dartCounter,
    jsCounter
  ))

I suspect that
return dart.global['JSCounterView|get#value'](jsCounter);

should be
return  return main['JSCounterView|'](jsCounter).value;

The likely culprit here is that js_util_optimizer.dart didn't run on the new expression. DDC sees that it's an external method that hasn't been resolved, and therefore tries to resolve it using package:js-style logic, but it doesn't work.


Highlight: fix queries picked from the command window

When selecting a query from the command window (Ctrl-f), s:prompt_op
should be set to 'cr', but there is no  key event in this case.
So, do the opposite: catch Esc and Ctrl-c.

After this commit, <esc> won't cancel the prompt anymore.

Updated.

When selecting a query from the command window

Can you give a concrete example? I can't seem to see any differences.

Here you are.
vim ./grepper.vim
:Grepper
git> let
'let' is highlighted
:Grepper
git> endif
'endif' is highlited
:Grepper
git>
Ctrl-f and pick 'let'
now 'let' is not highlighted

This only happens when picking a query from the command window (Ctrl-f). Its because there is no '<CR> has been pressed' event in this case, but input() returns the selected query. In other words
<CR> mapping can't be used to detect that a query has been submitted. A not-empty input() result can be used for that, but it is used for a  search.

Does this work for you as well?
diff --git i/plugin/grepper.vim w/plugin/grepper.vim
index cd1d418..859ec1d 100644
--- i/plugin/grepper.vim
+++ w/plugin/grepper.vim
@@ -768 +768 @@ function! s:prompt(flags)
-  let mapping_cr   = maparg('<cr>', 'c', '', 1)
+  let mapping_esc  = maparg('<esc>', 'c', '', 1)
@@ -774 +774 @@ function! s:prompt(flags)
-  cnoremap <cr> <end><c-\>e<sid>set_prompt_op('cr')<cr><cr>
+  cnoremap <esc> <c-\>e<sid>set_prompt_op('cancelled')<cr><c-c>
@@ -801 +801 @@ function! s:prompt(flags)
-  let s:prompt_op = 'cancelled'
+  let s:prompt_op = 'cr'
@@ -813 +813 @@ function! s:prompt(flags)
-    cunmap <cr>
+    cunmap <esc>
@@ -817 +817 @@ function! s:prompt(flags)
-    call s:restore_mapping(mapping_cr)
+    call s:restore_mapping(mapping_esc)

Note that the <esc> mapping does <c-c> at the end now.

Yes, this trick works fine. But I don't like the idea of Ctrl-c interrupt ever leaving this function. If we catch it, we also have to clear a:flags.query to signal that the search is to be aborted. Maybe s:prompt should return a boolean for clariry. Running a <cword> search on an empty query is handy (less shortcuts to memorize), but it's not obvious without looking at the code))

Yea, the whole prompt code is a complete mess and could use some refactoring. The empty input -> cword thing was an early requested feature and is documented at :h grepper-intro.
Anyway, can you change this PR to the following diff:
diff --git i/plugin/grepper.vim w/plugin/grepper.vim
index cd1d418..c4f0b91 100644
--- i/plugin/grepper.vim
+++ w/plugin/grepper.vim
@@ -768 +768 @@ function! s:prompt(flags)
-  let mapping_cr   = maparg('<cr>', 'c', '', 1)
+  let mapping_esc  = maparg('<esc>', 'c', '', 1)
@@ -774 +774 @@ function! s:prompt(flags)
-  cnoremap <cr> <end><c-\>e<sid>set_prompt_op('cr')<cr><cr>
+  cnoremap <esc> <c-\>e<sid>set_prompt_op('cancelled')<cr><c-c>
@@ -801 +801 @@ function! s:prompt(flags)
-  let s:prompt_op = 'cancelled'
+  let s:prompt_op = 'cr'
@@ -808,0 +809,2 @@ function! s:prompt(flags)
+  catch /^Vim:Interrupt$/
+    let s:prompt_op = 'cancelled'
@@ -813 +815 @@ function! s:prompt(flags)
-    cunmap <cr>
+    cunmap <esc>
@@ -817 +819 @@ function! s:prompt(flags)
-    call s:restore_mapping(mapping_cr)
+    call s:restore_mapping(mapping_esc)

This should be fine now, I guess?

Yes, it works. I'll update this PR.

Do we? Seems to work fine without it.

Well, it was late at night... Yet another trick: Ctrl-c clears the string returned by set_prompt_op ))
Maybe it's better to express it explicitly, something like
return a:op == 'cancelled' ? '' : getcmdline() in set_prompt_op (and not use <c-c>)?
<c-c> also doesn't throw an interrupt. So we catch only 'true' Ctrl-c interrupts. Hope neovim behaves the same way.

Same as what?

As it was before - without <c-c>. It's still slow. I now nothing about those timeouts, don't ask me.
I'm preparing an updated PR...

Well, it was late at night...

:)

 also doesn't throw an interrupt. So we catch only 'true' Ctrl-c interrupts.

Yup, it's the difference between :h ctrl-c and :h c_ctrl-c. Both is covered in the latest diff.
In a follow-up commit we can silence the mappings to avoid the flashing of set_prompt_op('cancelled') for a blink of an eye.

As it was before - without . It's still slow. I now nothing about those timeouts, don't ask me.

When you have ambiguous mappings, Vim has to wait for further key presses to know which mapping is meant exactly. <esc> is a special case since a lot of escape sequences in terminal emulators start with, well, <esc>.
That's why we temporarily set the timeout to 100 msec (here) before calling input() and restore it afterwards. If it's noticeably slower for you, we should figure out a solution in another issue.

Thanks for the explainations.

If it's noticeably slower for you, we should figure out a solution in another issue.

It certainly looks more as 1 sec than 100 msec.
The commit has been updated.

The commit has been updated.

Thanks!

It certainly looks more as 1 sec than 100 msec.

Is :map <esc> showing any mappings? Does it help to do :set timeout timeoutlen=400? (This applies to all mappings and is just for testing purposes.)

Is :map  showing any mappings?

Yes. I'm running GNU screen and there are <Esc>[200~ mappings for the bracketed paste support. If I run vim in a pure xterm (without screen), Esc is fast. Setting timeouts in a screen session does take effect, but it's rather small.
BTW. I added whitespace removal to the original commit mostly to suppress nusty errors when submitting a line containing whitespace only. It was right after s:prompt return and before the empty() check which triggers cword search. Is it a wrong place?

I added whitespace removal to the original commit mostly to suppress nasty errors when submitting a line containing whitespace only.

Put such things into separate commits and describe in the commit message why they are needed. :)

I'm running GNU screen and there are [200~ mappings for the bracketed paste support. If I run vim in a pure xterm (without screen), Esc is fast. Setting timeouts in a screen session does take effect, but it's rather small.

It's been ages since I last used screen, but when using such "middleware" between terminal emulator and application, it needs to adjust its timeouts as well. Does putting maptimeout 5 in your .screenrc help?

Put such things into separate commits and describe in the commit message why they are needed. :)

Looks like you've already done that. Thanks.

Does putting maptimeout 5 in your .screenrc help?

No.

Did you try it together with :set timeout timeoutlen=300? Otherwise there's nothing else I can do from the plugin side.

:set timeout timeoutlen=300 works but shortcuts feel a bit awkward.


Generate a QR code to export all account details as JSON

This pull request addresses issue #559.
Export button:

QR code:

JSON output:

The export button can be at the bottom with the back and delete buttons, also we can open the QR code on another screen where we can give the option to download the QR code

Sure, that sounds good. I will make the changes accordingly.

@yogeshpaliyal I have changed the feature like you suggested. Please have a look :)
Export button on bottom nav bar:

Generated QR code in a popup screen:

Ability to save the QR code to gallery:

Thank you for approving my PR! However, I notice the PR check CI pipeline has failed and the changes were not merged due to the use of deprecated gradle features. I haven't changed any build scripts though. How can we fix this?

@divyampahujaa checks failed due to spotless
Please run these command
./gradlew spotlessApply
./gradle spotlessKotlinApply

@yogeshpaliyal I ran those commands. The issue was with using wildcard imports. I have changed the imports to address this.

Cool thanks

Pr Merged thanks @divyampahujaa for the contribution ❤, will look for other contribution.


fix: Replace property checking with hasOwnProperty wrapper

closes #68
Shoot, well, I realized this problem is due to a change I made in my ESLint fix way back when haha. I switched from using .hasOwnProperty for all of the key checking to simply checking object[key]. This was to follow the no-prototype-builtins ESLint rule. The problem with this being that it includes prototype properties like constructor. Anyway, I made a little helper function to check if an object has a property without including prototypes that still obeys this ESLint rule:
/**
 * A helper function to check if an object has a key value, without including prooerties from the prototype chain.
 *
 * @see https://eslint.org/docs/latest/rules/no-prototype-builtins
 * @param {object} obj An object to check for a key.
 * @param {string} key A string represeing a key to find in the object.
 * @returns {boolean} Whether the object contains the key or not.
 */
function objectHas(obj, key) {
  return Object.prototype.hasOwnProperty.call(obj, key);
}

Also, I noticed that a bunch of files got slightly normalized by running prettier --write ., so I included them here as well, but I can remove those changes if you want me to.

thanks for catching this one! And no worries on the prettier updates, let's keep them


Validate that online recall info is a valid url

https://trello.com/c/DnB0oCdm/1120-corrective-action-online-recall-info-bug
Description
Prior to this PR, users could enter anything into the corrective action online recall information box. This change ensures that users can only enter valid URLs.
The next step after deployment of this PR will be to sanitize the 50 or so existing corrective actions with online recall information to make sure they are valid URLs

Checklist:

[ ] Have you documented your changes in the pull request description?
[ ] Does the change present any security considerations?
[ ] Is any gem functionality overloaded? Eg: Devise controller methods being overloaded.
[ ] Has acceptance criteria been tested by a peer?
[ ] Has the CHANGELOG been updated? (If change is worth telling users about.)

General testing (author)

[ ] Test without JavaScript
[ ] Test on small screen

Accessibility testing (author)

[ ] Works keyboard only
[ ] Tested with one screen reader
[ ] Zoom page to 400% - content still visible
[ ] Disable CSS - does content make sense and appear in a logical order?

@KyleMacPherson  I think we need a URL validator that can detect the URL pattern. eg. asos.com is also a valid URL


Self Updater - text misaligned

The "A Steam client update has been downloaded." text in the self-updater notification pop-up isn't displaying properly - some kind of misalignment?
See below:

Some examples of normal version (from google, it updated when i restarted to see the normal version, duh):

It's the same while the update is downloading:


Proper way to check if Array

Is there a way of checking if a variable is an array that will properly transpile?

With the most latest transpiler from ccxt:
if (Array.isArray (foobar))
    foobar[0] = foobar[1];  // or whatever


Improves assert_delivered_email and adds assert_delivered_with

Resolves #74.

Any updates on that one? 😸

@paulcsmith ^

@optikfluffel I guess this is related with #233, am I right ?

@jbernardo95 Thanks for tackling his. Just a few small comments and then I'll merge this in!
Also,  I think that feature is somewhat related, but I would probably test token generation in a unit test. It's easier to isolate. Then you could use this new function you wrote to just test the subject and skip the body in integration tests

@paulcsmith Updated !
CircleCI seems to be stuck...

@paulcsmith Done, let's see if this helps.

@paulcsmith It didn't help, this seems to be a CircleCI <> GitHub issue.
The other new PR I submitted isn't getting any status either. Checked back at CircleCI and it seems to not be getting GitHub notifications of new code.

@jbernardo95 I'll have to figure this out some other time. It appears to be working fine though so I'll merge this in. Thank you so much!


error in docs?

I can't read the line 215 of this I mean I don't understand what it means exactly. I think I know what the whole part means tho.

The comments are meant to be read as a whole block ;)

so we have:

the scroll event's default behavior (scrolling) will happen immediately, instead of waiting for onScroll to complete in case it contains event.preventDefault()

In case what contains  event.preventDefault? what will happen in that case?
The way I understand this sentence it means:

If the scroll event contains event.preventDefault(), the scroll event's default behavior (scrolling) will happen immediately, instead of waiting for onScroll to complete.

But AFAIK preventDefault and passive should never be used together. And also AFAIK the consequent here is true regardless of the antecedent.


Edited key terms table with new definitions

Issue #481
Updated definitions in Key Terms table
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

thanks @keithhc2


difference in subtype fvs subclass for int and float

Is this intended behavior?
#Python 3.6.2 | packaged by conda-forge | (default, Jul 23 2017, 23:01:38)
#Type 'copyright', 'credits' or 'license' for more information
#IPython 6.2.1 -- An enhanced Interactive Python. Type '?' for help.

In [1]: import pytypes

In [2]: issubclass(int, float)
Out[2]: False

In [3]: pytypes.is_subtype(int, float)
Out[3]: True

nm saw this is part of the numeric tower stuff.  It might be worth explicity calling it out somewhere in the readme.

Yes that is numeric tower according to PEP484. Same with float and complex. You can turn it of via pytypes.check_numeric_tower=False or so (cannot look it up properly right now)


some problems with using roadhog

Hi,
when update my version to 6.0.0,  I use roadhog to pack my code , it will be interrupt by errors, as follow:
     Can't resolve '@babel/runtime/helpers/esm/objectWithoutPropertiesLoose' in 'd:\myproject\wb-tsnode\build_modules\node_modules\react-redux\es\connect'

but I can see the module exist in node_modules, version 5.0.7 is OK, please give me some help .

This seems like a problem with roadhog, not our project. Please go to them for support.


Any plan on adding a user profile page?

It would be a great addtion with plenty of "demand".
This repo is great, thanks!

what do you think of this showcase: https://emkelley.github.io/EK-Bulma-Templates/
btw. I'm kinda hoping owner shall one day create official repo where other makers of bulma templates,
such as that one, shall share their templates under one official bulma templates organization

@diomed Well, i think it is beautiful. Wish there was a profile template.

Oh, you meant if a user profile would have that design? Yes, it will be great.

I would like to work on this issue to create a portfolio template. @dansup you can assign this to me.

Are you starting this? @mubaidr

Yes, I am ready to work on this.

Well, i guess that you forked it and submitted a pr?

No. I am asking if there is need to add portfolio template then I can work and create one.
I have not yet completed this task.

Oh, i see. I think there is a need, but also for a profile template especially. Thanks brother.

Progress: https://github.com/dansup/bulma-templates/pull/83

This should be closed. @dansup

@GabMic what is a profile layout, then? I did ask you to provide some kind of example, but you didn't.


updated whitepapers section

resolves #230

Note, for the whitepapers, suggest that:

update the top text to say "Read the Lakehouse Storage Systems Whitepapers"
update the description text to "These whitepapers dive into the features of Lakehouse storage systems and compare Delta Lake, Apache Hudi, and Apache Iceberg. They also explain the benefits of Lakehouse storage systems and show key performance benchmarks."
update the left link to say "Analyzing and Comparing Lakehouse Storage Systems"
update the left graphic to be a screenshot of Figure 1 of the paper, including the caption
update the right link to say "Lakehouse: A New Generation of Open Platforms that Unify
Data Warehousing and Advanced Analytics"
update the right graphic to be a screenshot of Figure 2 of the paper including the caption
at the bottom of the graphic, please add a text link to the paper Delta lake: high-performance ACID table storage over cloud object stores

Thanks @dev-smart-ui  - one small nit, could we make the bottom text from "Delta lake: high-performance ACID table storage over cloud object stores" to "Delta Lake: high-performance ACID table storage over cloud object stores" and put the text in a blue button similar to the "Read the whitepaper"?  Otherwise, looks great!

@dev-smart-ui - can you please make the change Denny requested?  Let me know when this is done - thanks!!


106 update api

Resolves #106
After conversing offline with @xavijam we agreed to go with following the pattern of adding the public API on the previously returned model (like done for widget.remove(), i.e. having a widgetModel is an obvious prerequisite to be able to update it.
E.g. having a category widget:
var catWidget = dashboard.widgets.createCategoryWidget({
  title: 'Testing testing…',
  aggregation: 'count'
})

Then one can update it by, probably not too surprisingly:
catWidget.update({
  title: 'Bazinga!',
  collapsed: true,
  aggregation: 'sum'
}) // => true

Only white-listed attributes are sent through, so trying to update something that's not valid would return false:
catWidget.update({
  whatever: 'bazinga!'
}) // => false

@xavijam @javierarce does this work for you?
BTW, this solves the problem in the scope of this project, but changing attributes are not reflected on the actual on the dataviews, e.g. try changing a formula's operation from min to max in the populated example. We'll probably have to review all dataviews and make sure they're reactive on attrs changes, to have this fully working, but that can be resolved separately/later. cc @alonsogarciapablo

TODOS

[x] implement update
[x] fix attrs not reflected in UI :point_right: #117
[x] fix dataview attrs changes not being reflected on widgets, the issue is fixed in https://github.com/CartoDB/cartodb.js/pull/1048, need to update the cartodb.js ref here once that's merged

why creating a new method that does exactly the same than Backbone.Model.set?
For me this PR does not make any sense without adding the dataviews bindings

It does not do the same:

It hides away the dataview so it's not exposed publicly (in the same way as for widgets.createFooModel methods).
It makes sure only attrs that are intended to be updated are set, and on the appropriate model.

My point here is not about functionality, is about flexibility: you just can not create a public api without knowing what you need externally. You only will know what you need when you finish this #117 (which is top priority right now).
When you are editing models things get weird usually and you need to expose things you wouldn't think in advance. Editing is hard

@xavijam updated after fixing #117 as well as https://github.com/CartoDB/cartodb.js/issues/1040, can you review again please?

Code :+1:


Android UI Tests fail on GitHub actions but pass locally

Description
My All UI android test fail on Github action but when I run the tests locally, all tests pass.
Expected behavior
All tests should pass
Actual behavior
All UI tests are failing
Repro Details
Workflow Result:
https://github.com/TheReprator/Wipro/actions/runs/979383000
Repo: https://github.com/TheReprator/Wipro
Branch: codeCoverage
workflow: non_master_push.yml
Looking forward for a solution.
Regards,
Vikram Singh

Hello @TheReprator. Thank you for your report. We will take a look.

Hello @TheReprator,
I tried to find a simple way to reproduce the issue, but with no luck. Maybe you already have some repo where it is possible to easily reproduce the issue or you can write exact steps to start your tests locally.
We're looking forward to your reply.

Hello @TheReprator,
I'm going to close the issue until further clarifications from your side.
In case of any questions, feel free to contact us.


Contacts filter text box input is broken

If I start writing anything on the "Filter" box right over the My contacts list on the left column, the text shows here in this very place I'm writing this message.

It was caused by a request to auto-select the chat textarea on the first character typed, but the CSS element selector is not accurate enough.


Update MD file on new branch 2017-12-08_01-50-34

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

split/updateTestRef1.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.