[fix][test] Fix flaky test LeaderElectionTest.revalidateLeaderWithinSameSession

Fixes #21535

Motivation
The test should Provide Consistent Answer .Test revalidateLeaderWithinSameSession failed too many times.

Modifications
We are calling the method once store the object and check both the conditions . In this way at both conditions we are checking the same Object.

Verifying this change

[x] Make sure that the change passes the CI checks.

Documentation

[ ] doc
[ ] doc-required
[x] doc-not-needed
[ ] doc-complete

Matching PR in forked repository
PR in forked repository:

@lhotari  could you please review the pr

This PR is 544 commits behind the master. Could you merge the master branch?

This PR is 544 commits behind the master. Could you merge the master branch?

@BewareMyPower I'll close and reopen this PR to trigger a new PR build. In Pulsar CI, the PR build will always merge the master branch before running the PR build.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 74.52%. Comparing base (bbc6224) to head (d45a1bc).
Report is 595 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff              @@
##             master   #22383      +/-   ##
============================================
+ Coverage     73.57%   74.52%   +0.95%
- Complexity    32624    34428    +1804
============================================
  Files          1877     1934      +57
  Lines        139502   144980    +5478
  Branches      15299    15838     +539
============================================
+ Hits         102638   108049    +5411
+ Misses        28908    28646     -262
- Partials       7956     8285     +329

Flag
Coverage Δ

inttests
27.54% <ø> (+2.96%)
:arrow_up:

systests
24.52% <ø> (+0.20%)
:arrow_up:

unittests
73.88% <ø> (+1.03%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.
see 635 files with indirect coverage changes


1801203: Fixed missing or incorrect code tags.

Fixed missing or incorrect code tags. No code or content changes made.
1801203

Docs Build status updates of commit 63746b8:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs-ref-conceptual/use-cli-effectively.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 63746b8:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs-ref-conceptual/use-cli-effectively.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit d38e6fb:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs-ref-conceptual/use-cli-effectively.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit d38e6fb:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs-ref-conceptual/use-cli-effectively.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Fix error when trying to get the access token for Ballerina Central the first time you perform a ballerina push

Purpose

Fixes https://github.com/ballerina-platform/ballerina-lang/issues/11219

Goals

The access token of a first time user will be automatically updated after he/she logs into to Ballerina Central

Automation tests
Tests cannot be written for this scenario as the default browser is opened automatically during this process for the user to sign up to Ballerina Central.
Security checks

Followed secure coding standards in http://wso2.com/technical-reports/wso2-secure-engineering-guidelines? yes
Ran FindSecurityBugs plugin and verified report? yes
Confirmed that this PR doesn't commit any keys, passwords, tokens, usernames, or other secrets? yes

Need to write test cases for this - https://github.com/ballerina-platform/ballerina-lang/issues/11232


Can't change some things (colors, title, background-color, ...)

Hello,
I use vue2-editor in project but is broken.
When I try to take color, when I release, the popup close imediatly.
You can check the GIF to see what happened.
Other problem, can't edit on firefox and safari.
Thanks for help
Check the GIF :
https://share.getcloudapp.com/6qu5v5yY

Ok fix.. The editor was in  tag..


Count and Say (LeetCode)

Aim

Details
I would like to solve count and say in C++ language under LGMSOC'21
Programming language

[ ] C
[x] C++
[ ] Java
[ ] Python

@ravikr126 @Amit366 Kindly assign me this issue under LGMSOC'21.

Hi,
I want to implement this in java as apart of LGM-SOC'21.
@ravikr126 @Amit366 Please assign it to me. Thankyou!!


format codes

use 4 spaces to replace TAB
and thank you for your effort!

Well, it's more appropriate to open an issue before submitting a PR... plus, work is done on the development branch.
However, I will check that branch for unnecessary tabs in files where spaces are used.

I'm not going to touch getopt.h and catch.hpp since they intentionally have tabs.


Whisper unstability

Hi, STT (Whisper) is the biggest use-case for me. I think it's probably the most important feature for now until I can use it reliably.
Hopefully, it's the same for everyone as it's the starting point for using TTSVoiceWizard.
Anyway, there is what I find using the latest v.1.5.0 from the github main.
In the Log View, I see the new "Whisper Debug: ..." output. When STT mode is on, it will always shows randomly shows one of the followings.  I think it's clear what it means.
(A) "Listening"  (listening and there is no sound input)
(B) "Listening, Voice" (listening and sound input is detected)
(C) "Listening, Transcribing" (processing recorded voice)
But the problem is that they do no accurately represent what's really happening, and the behaviors are bit random.
Here are my observations. (I always launch it from VS Debug but I think the behaviors are the same from .exe)

When STT is first activated, it will always start at (B) although there is no voice input. And it will stuck at (B) until speak several times. (yes, I waited sufficient time until ggml model loads) And when it unfreezes from (B), it will output several strings bunched up that I spoke into.
After the initial hiccups, it will become more responsive.  However, sometimes (A), (B), (C) will cycle through on it's own without any sound inputs.
I then, wait until it stabilizes to (A), and then start speaking again. It will sometimes go to (B) immediately, and sometimes it doesn't. And it will start cycle through (A), (B), (C) on it's own again.

Here is another observation/question.
I see the following logs in VS Console Output.

It seems to recreate the same threads infinitely.
Can you please tell me what these threads are for?
Perhaps the unstability is related to these thread constantly being recreated?
Many thanks.

The log will now let you know when Whisper is starting up and when it is actually ready for audio. Although audio recording during startup will still be processed after fully started as you observed. https://github.com/VRCWizard/TTS-Voice-Wizard/releases/tag/v1.5.1

The states (A,B,C) should definitely be not be random. I mentioned to you in discord that you can turn on Filtered Text Appears in Log to see when Whisper heard sounds that were not voices. Although for the state any sound picked up shows as Listening, Voice. When "Listening, Transcribing" appears if you have Filtered Text Appears in Log enabled something should always appear in log.

^^^

Threads exiting
What does it mean:
https://stackoverflow.com/a/12410591

How to remove the spam:
https://stackoverflow.com/a/19199801

Thanks for the info.
I'll let you know once I know if I can find ways to improve.
BTW, regarding #4, I understand it's thread exiting. What is the thread about? It doesn't tell me anything about the thread itself. If you can point out the thread on the source, I'll take a look to understand it better.
Perhaps, I was thinking... it might be better if the thread is to stay on the loop instead of exiting if it were to recreate itself infinitely??


Reject uploads based on their Exif data

Type of issue
feature request
Uploader type
S3
Feature request details
The ability to reject uploads based on their Exif data
Detailed description of the feature
I have a situation where having a taken_at time stamp is absolutely necessary. The problem with the S3 implementation is that I wont know that the exif data isn't there until after the user has "successfully" uploaded their images. It would be great if I could block the upload in the same manner as the file size or resolution restrictions that already exist.

The quickest way to accomplish this is to check the EXIF data yourself either before submitting the file to the uploader or in an onSubmit callback handler.

The quickest way to accomplish this is to check the EXIF data yourself either before submitting the file to the uploader or in an onSubmit callback handler.

I posted some example code as an answer to your Stack Overflow question that should allow you to achieve this using Fine Uploader API and the exif-js library. So, I'm going to close this feature request in favor of that approach.


Editor problem

I am using the editor with standard settings and I encounterded the following problem. Is there any other way to change the height/width? I change the settings, the width/height of the box changes but not the area where you can write

A css conflict.


Filter scoped modules correctly

Fixes microsoft/license-checker-webpack-plugin#25
A valid node module name is either \w+ or @\w+/\w+ never @\w+.
This is enough of a hairy internal implementation detail that filter should probably not be exposed even as an (undocumented) option. But leaving alone for now as changing the pattern has been a useful workaround.
There are some other implications from the webpack 5 changes to fileDependencies and the current code behaviours but those will need a bit more discussion to address I think.

Thank you so much for this!! 🙂
FYI, I think the tests will break when using Yarn PnP, since then there won't be a node_modules folder.

This fixes the problems described in #45 and #43 for me. If anyone else cares, this PR can also be used as a workaround by adding the filter definition from it into your LicenseCheckerWebpackPlugin options, like this:
    new LicenseCheckerWebpackPlugin({
      allow: "(Apache-2.0 OR BSD-2-Clause OR BSD-3-Clause OR MIT OR 0BSD)",
      filter: /(^.*[/\\]node_modules[/\\]((?:@[^/\\]+[/\\])?(?:[^@/\\][^/\\]*)))/,
      ...

Would still be better if this could be merged and released :)

anychance microsoft will actually review this?

Part of the issue may the that the maintainer now works at twitter not ms. Maybe @unindented could suggest a former colleague I could bug about taking over package?

Part of the issue may the that the maintainer now works at twitter not ms. Maybe @unindented could suggest a former colleague I could bug about taking over package?

Have same issue with vuejs:
 ERROR  HookWebpackError: Cannot find module<EMAIL_ADDRESS>        Require stack:
        - node_modules\license-checker-webpack-plugin\src\licenseUtils.js
        - node_modules\license-checker-webpack-plugin\src\index.js
        - vue.config.js
        - package.json


TypeError: Interpreter.nativeGlobal.Number is not a function

I get this error when I run this code:
moveForward(Number(10));
This happens in my Node React app where I install the Interpreter with npm.
But when I tested it by downloading and linking the interpreter manually everything works without any problems.
Is this a problem in my environment or something in npm module?

It's not easy to answer like this without having the bigger picture about where is moveForward defined, etc. If you could paste more context for the code that could help.
That being said this package is not an official package published by the js-interpreter maintainer, it's maintained by me because I also wanted to have the npm package. But it's basically a wrapper around the code directly cloned from the original source without changing anything extra so I would assume this should be identical to using the original js-interpreter code as long as they are pointing to the same commit hash.
I will have to update this to point to the latest hash, although I don't see any changes in the original repo that might be making difference in this behavior.

I've updated the package with the most recent changes in the original repo, however, all those changes were documentation/demo file changes and won't have any behavioral impact.

Well scratch that, I'm actually able to reproduce this on both npm and the original repo version. I'll reply in the issue you opened in the original repo: https://github.com/NeilFraser/JS-Interpreter/issues/214

@shbobur The NPM package is transitioning. I will have a look at this as soon as possible.
In the meantime, would you be able to see what the result is if you use https://www.npmjs.com/package/js-interpreter-npm ?
This is out of curiosity, and it is likely to have the same problem (or other problems). However, I would be curious to know if it does "just work".
Thanks.

@myuzio I forgot to mention, thank you for maintaining it during this time. I will try and make sure it will be possible to use it with CLI and maintain your existing code. I am assuming there are people out there who are counting on it to work.

Anyone has any idea how to solve the problem?
I found a solution but it doesn't work as expected!

@ali-hosseini-fs we are in between switching things around. Things will be clearer soon. Have you tried following advice here?  https://github.com/mercmobily/JS-Interpreter/issues/14#issuecomment-898881949

I checked it, seems it's working!
let me pass it to our qa team ;-)

Ok please!
On Thu, Sep 2, 2021, 5:59 PM Ali(Ako) Hosseini @.***>
wrote:

I checked it, seems it's working!
let me pass it to our qa team ;-)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/mercmobily/JS-Interpreter/issues/14#issuecomment-911480683,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAQHWXTHXWUDWIS4NJDTZY3T75DHNANCNFSM5A45HMHA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Please do report back, I am very keen on knowing the outcome. The original
poster of this ticket seems to have disappeared.
Merc.
On Thu, 2 Sept 2021 at 18:01, Tony Mobily @.***> wrote:

Ok please!
On Thu, Sep 2, 2021, 5:59 PM Ali(Ako) Hosseini @.***>
wrote:

I checked it, seems it's working!
let me pass it to our qa team ;-)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/mercmobily/JS-Interpreter/issues/14#issuecomment-911480683,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAQHWXTHXWUDWIS4NJDTZY3T75DHNANCNFSM5A45HMHA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

It will take some days to test by our qa team! so far everything works fine.
I'm gonna revert after they did check it.

one of the problems that I encountered in both of packages is this

Hi,
I assume that's because of dependency.
I will make sure that is sorted out ASAP, whatever it takes.
Merc.
On Sun, 5 Sep 2021, 4:17 pm Ali(Ako) Hosseini, @.***>
wrote:

one of the problems that I encountered in both of packages is this
[image: ksnip_20210905-124559]
https://user-images.githubusercontent.com/81898967/132120300-7263f850-5e07-4da0-b079-a240ebe36e0e.png
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/mercmobily/JS-Interpreter/issues/14#issuecomment-913107954,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAQHWXXCWNSUKY4BD6KJ5WDUAMRQDANCNFSM5A45HMHA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

it is related to latest npm version.

Hi,
Wait a sec... about the second problem:

one of the problems that I encountered in both of packages is this

If you run 'npm install vm', do you still get the problem?
On Sun, 5 Sept 2021 at 17:10, Ali(Ako) Hosseini @.***>
wrote:

it is related to latest npm version.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/mercmobily/JS-Interpreter/issues/14#issuecomment-913114687,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAQHWXWY2GTENHHU43QL3IDUAMXY5ANCNFSM5A45HMHA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

No i just installed vm-browserify and applied it's suggested config on that error log and problem fixed.
check this out

Also I deployed it to npm as a temporary patch.
It's working but cli not works. so in my case we are not using it.
I just added self instead of this in the submodule repo (check line 180).
basically I forked both of repos and deploy it under our company's scope on the npm.

I did those things just as a temporary solution.
By the way, Thanks


fix Matrix related problem

split viewMatrix into view+model (project skipped now)
remove useless code
reset default rotation, especially for plane (Matrix4.CreateRotationY(-90.0f) is strange because this API need radius rather than angel)
fix a scale problem I introduced before:

conflicts resolved

I tested some files, like this one
https://mega.nz/#!7cdGXCBI!maiM3MxnCCpK1HHlbDjtf1gxyql1PEfNPkXhjHdjjZI
Looks like there are some bug needs to be fixed

Fixed in another PR


Allow toggling the UI to save some space on phones

I found your app on the Pureref forums about an Android port, and am very grateful for it 😊 Cross-compatibility or not it already does everything I need and I have faced no stability issues!
However would you please consider letting us hide the top and bottom buttons bars? On a tablet they're fine, but when using the app to draw on a phone in split-screen view they take up a lot of space.
Maybe a single button to toggle the UI in one corner like a lot of the painting apps have? Or a hidden gesture like three or four finger tap? What do you think?

Interesting, I hadn't considered that use-case, since I primarily use physical mediums or an external tablet. It should be fairly simple to implement, though.

I normally draw on a PC myself; only used to do sketching on the phone when outdoors for studies or when bored. But over the lockdown that went out the window and I got into "virtual" outdoor sketching instead, which is where my use-case comes in 😀.
Not to rush you, but I would be very much obliged if you added in the toggle in the future. And thanks for the app in the first place too!

I pushed 1.1.0 with this feature.
Does it work for you?

This is perfect, thank you very much!

Just a note: the UI resets to visible anytime the app's "window" resizes. This is not at all a problem when using it, but I'm mentioning it in case it's a bug.


New version: gjergj.testmyapp 0.0.73

Checklist for Pull Requests

[x] Have you signed the Contributor License Agreement?
[ ] Is there a linked Issue?

Manifests

[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] This PR only modifies one (1) manifest
[x] Have you validated your manifest locally with winget validate --manifest <path>?

[x] Does your manifest conform to the 1.6 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Automated with GoReleaser
Microsoft Reviewers: Open in CodeFlow

Hi @Gjergj,
The package didn't pass a Defender or similar security scan. This might be a false positive and we can rescan tomorrow.
(Automated response - build 877.)

Automatic Validation ended with:

Installation failed with exit code -1978335187
2024-04-24 05:57:36.000 [FAIL] Installer failed security check. Url: https://github.com/Gjergj/testmyapp/releases/download/v0.0.73/testmyapp_Windows_x86_64.zip Result: 0x80004005

(Automated response - build 877.)

Hi @Gjergj,
The package didn't pass a Defender or similar security scan. This might be a false positive and we can rescan tomorrow.
(Automated response - build 877.)

@stephengillie do you think we could run this today again?
This has been reported a couple of times already, what can I do to investigate more?
Would I be possible to whitelist this in Win Defender?

@wingetbot run

Hi @Gjergj,
The package didn't pass a Defender or similar security scan. This might be a false positive and we can rescan tomorrow.
(Automated response - build 877.)

Automatic Validation ended with:

Installation failed with exit code -1978335187
2024-04-26 08:30:31.038 [FAIL] Installer failed security check. Url: https://github.com/Gjergj/testmyapp/releases/download/v0.0.73/testmyapp_Windows_x86_64.zip Result: 0x80004005

(Automated response - build 877.)


Import Error

Hi @wannaphongcom ,
just installed the latest version of pythainlp on Redhat linux from the git sources.
When I try to use it I have the following problem:
import pythainlp
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/lib/python2.7/site-packages/pythainlp-1.1-py2.7.egg/pythainlp/__init__.py", line 6, in <module>
    from pythainlp.romanization import *
TypeError: Item in ``from list'' not a string

From a quick web search it seems like there could be a python 2 / 3 issue with "unicode_literals".
Happy to get any feedback on how to solve this.
Cheers, Gerhard

fix in https://github.com/wannaphongcom/pythainlp/tree/develop

Hi,
hmm,
now the next error when running the test script:
mæw
Traceback (most recent call last):
File "test_gerhard.py", line 24, in
b=texttoeng(b)
File "/home/gerhard/pythainlp/pythainlp/change/init.py", line 33,
in texttoeng
a = six.u(a)
File "/usr/lib/python2.7/site-packages/six.py", line 621, in u
return unicode(s.replace(r'\', r'\\'), "unicode_escape")
TypeError: decoding Unicode is not supported
seems like "a" is already unicode.
do you have a python2.7 environment for testing?
Thanks, Gerhard
On 2017-03-30 14:07, Wannaphong Phatthiyaphaibun wrote:

Closed #16 https://github.com/wannaphongcom/pythainlp/issues/16.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/wannaphongcom/pythainlp/issues/16#event-1021756707,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AX3qjvgvWY0tMdNv2aLWwZi_63mtM9GXks5rq1SqgaJpZM4MmEpm.

@gwohlgen I have not a python2.7 environment for testing.

@gwohlgen  Now , PyThaiNLP support python 2.7 in https://github.com/wannaphongcom/pythainlp/commit/ad41eff8f41a08493f6484de456d68e07dfed292 .
test in https://travis-ci.org/wannaphongcom/pythainlp/jobs/217228168


Interface hierarchy for generated types

SBE Tool currently generates MessageEncoder and MessageDecoder interfaces in the sbe:messageSchema-defined package. The tool also ensures that flyweights generated for each sbe:message implement either MessageEncoder or MessageDecoder.
I am currently developing a library for storing SBE data in the LMDB embedded key-value store (via LMDBJNI), but have encountered several difficulties in evolving this into a general-purpose library of value to others:

The generation of interfaces in end user projects prevents them from being referenced by a general-purpose library. One alternative is to provide a code generator for end user projects, although this is a lot of extra work, not to mention inconvenient for end users to configure and use. Alternately I could model all interfaces using Object, but this has adverse impacts around self-documentation, type safety and reflection overhead.
Flyweights generated for sbe:composite types do not declare any interface. This prevents them from being referenced in interfaces. There are uses for composites as first-class citizens, for example as keys in an ordered map (particularly given the lack of versioning that a composite implies and its non-reliance on a messageHeader that would impact key ordering via its version field).
There is no way of referencing a message or a composite as a top-level type that is independent of its encoder or decoder. This prevents symmetric interfaces that regularly need to reference both the encoder and decoder flyweights for a given type (as shown in my PoC below).

To explore what might be feasible, I have produce a proof of concept project. It shows:

A potential Agrona interface hierarchy that would provide a foundation for third party libraries that need to expressively reference SBE generated types and flyweights
A type-safe DAO interface and implementation that illustrates use of the proposed Agrona hierarchy
The SBE generated “car” types, with manual changes to reflect the proposed Agrona hierarchy (note such changes are minimal: (a) the current MessageEncoder and MessageDecoder are no longer generated, (b) the currently-generated flyweights would instead refer to a single Agrona interface (see example), and (c) there is a need to generate a new zero method Type class for each sbe:composite and sbe:message)

I am not advocating for this exact solution, but rather seeking discussion on whether pull requests that modify SBE Tool and Agrona to achieve something along these lines would be reasonable. Of course I’m happy to prepare PRs, but preferred some initial discussion first.
As an aside, I’ll be happy to release the resulting LMDB solution if we can resolve the third-party referencing challenges mentioned above. I expect it will be useful for SBE users seeking fast, embedded, key-ordered storage for their SBE types. The introduction of interfaces such as these would also enable others to build similar SBE-aware libraries.

Would a simple solution be to optionally generate the schema specific interface?

@mjpt777, do you mean SBE Tool having an option to generate the org.agrona.sbe package and associated interfaces in the user's sbe.output.dir? It would work, but it feels unusual to generate static .java files versus just putting them in a versioned JAR dependency. Or do you mean something else?

It could be as simple as an option to not generate any interfaces?

Adding an sbe.generate.interfaces (?) option to SBE Tool has some advantages:

It's simple
It can default to false, meaning no change from today aside from removing the currently-generated MessageEncoder and MessageDecoder (and I'd imagine anyone using those two interfaces would benefit from the new interface model anyway)
It means only modifying SBE, not Agrona
It gives time for the interfaces to evolve, stabilise and demonstrate utility without creating any release coupling between SBE and Agrona

If you are happy with this, I can produce a PR. Or if you have other comments on the interface hierarchy etc, please feel free.

Yes. I think it is the best way to begin with. We can then have time to discuss what makes the most sense longer term.
BTW I think it is great that SBE gets used with LMDB :-)

Issue links:

#160 contained original request for interfaces
#334 contained initial interface implementation
#350 is the PR for this functionality

Adding the empty Structure interfaces adds a lot of complexity to this and the JavaDoc does not help explain why. Could you either update the JavaDoc to include an example of why these are need to consider dropping this interfaces and just using the Flyweights/Encoders/Decoders interfaces?

I'm happy to provide a PR with more JavaDocs, but if you are finding Structure adding a lot complexity it's perhaps appropriate to consider whether it's worth keeping at all.
My Java annotation processor generates (at compile time) concrete DAO implementations that persist SBE types to LMDB. Here is an example:
import baseline.CarStructure;
import baseline.EngineStructure;

@GenerateDao(maxMessageLength = 2048, key = EngineStructure.class, value = CarStructure.class)
public interface CarDao {
}

As shown, @GenerateDao relies on Structure so it can express the key and value types, with the former constrained to a CompositeStructure and the latter to a MessageStructure (we don't want the SBE message header for a key, as it would impact LMDB key sort order).
In reality I am having to use string concatenation to arrive at the encoder and decoder types anyway within the annotation processor:
    String key = info.keyStruct.getQualifiedName().toString();
    String val = info.valStruct.getQualifiedName().toString();
    assert key.endsWith(STRUCTURE);
    assert val.endsWith(STRUCTURE);
    key = key.substring(0, key.length() - STRUCTURE.length());
    val = val.substring(0, val.length() - STRUCTURE.length());
    .....
    map.put("keyStruct", info.keyStruct.getQualifiedName().toString());
    map.put("keyEncoder", key + ENCODER);
    map.put("keyDecoder", key + DECODER);
    map.put("valStruct", info.valStruct.getQualifiedName().toString());
    map.put("valEncoder", val + ENCODER);
    map.put("valDecoder", val + DECODER);
    map.put("interface", info.iface.getQualifiedName().toString());

As such, it's not an issue in my use case to abolish Structure and change the annotation to require the key to be a CompositeDecoderFlyweight and the value a MessageDecoderFlyweight. It's a small hack in that we are referring to the decoder when we really want to refer to the type, but it's not major issue if you feel Structure adds complexity to the interface hierarchy or output package directory.
If you like I can submit a PR with JavaDocs for Structure interfaces, or a PR which removes Structure, or you are welcome to remove it if you prefer. I don't mind; just let me know.

Thanks for the clarification. This helps a lot.
I think it would be best to drop the Structure interfaces and keep the Flyweights. This will reduce the complexity and avoid the need for overlapping interfaces.
As a separate point have you considering using the id field as your key to flyweight lookup in the map? It would be more efficient and you could use primitive maps.
If you could do a PR to remove that Structure interfaces then that would be much appreciated. I can then move the remaining interfaces to Agrona to simplify further.

I'll submit a PR removing it early next week (weekend here now).
Thanks for the map ID suggestion. I usually use primitives everywhere, but in this case the map is an input to the Mustache template library which goes off and writes the resulting Java source code. The map keys are needed in the template file, such as private {{keyEncoder}} keyEncoder;. I started writing the source code out directly within the annotation processor, but moving it to a template made it much easier to incrementally refactor the generated code.

New interfaces are now in Agrona.

Thanks!


dev-mongo branch todo's

This is relation to https://github.com/galaxyproject/cloudlaunch/issues/49 as one possible avenue for implementing the new launcher. This branch is based on the following stack: Django, Django Rest Framework, MongoDB, Django Rest Framework Mongoengine. The following is a fluid list of current tasks:

[ ] Figure out how to POST a nested field (e.g., an Application with a Category)
[ ] Define the models
[ ] Integrate Django Social Auth
[ ] Setup testing with Travis
[ ] Write setup docs
[ ] Decide how the Admin side of things will be handled given no default Django Admin site
[ ] Add a Celery task queue

After experimenting with the specified software stack, a conclusion was that much of those projects are in flux, have very limited documentation, and they don't necessarily integrate well with one another re. support for their native features. With that, a decision was made not to pursue this avenue for the time being and revert to the relational model. See https://github.com/galaxyproject/cloudlaunch/issues/52 and the dev branch for more on that effort.


Write Spladder/Alt-Splice Pipeline

variant calling ~ 1h / single thread / 1G RAM
AS calling ~ 2.5 h / single thread / 5G RAM
QC run ~10min / single thread / < 1G RAM

I would suggest to lump variant calling and QC together.
As input data, I have currently used the hg38 Reference genome downloaded from ensembl and as annotation the Gencode V23 comprehensive. Let me know when you need more information.
Full list of dependencies:
Variant calling step:
Requirements:

samtools - version 1.3

Pre-requisits:

index genome.fa with: samtools faidx <genome.fa>
(this needs to be done only once and the genome.fa and the index can be provided as input files)

Call:

samtools-1.3 mpileup -f [genome.fa] -l [position_file] -v [alignment.bam] -t DP,SP,INFO/AD,INFO/ADF,INFO/ADR,INFO/DPR,SP > [output.vcf]

Resources:

time: ~ 1h
memory: ~ 300MB
disk space: only for result file ~ 10MB

Source:
http://www.htslib.org/download/
Alternative splicing step:
Requirements:

python 2.7
pysam
h5py
numpy
scipy

Pre-requisits:

needs genome.fa
needs annotation.gtf

Call:

python spladder.py --insert_ir=y --insert_es=y --insert_ni=y --remove_se=n --validate_sg=n -b [alignment.bam] -o [outdir] -a [annotation.gtf] -v y -c 3 -M merge_graphs -T y -n [readlength] -P y -p n --sparse_bam y
(we can set the read length to constant 50 for now - this will only influence some filter criteria and should be fine - unless you have a large fraction of 32bp reads in your sets, which is unlikely)

Resources:

time: ~ 2-3h
memory: ~ 4 GB
single CPU
disk space: ~ 1GB

Source:
https://github.com/ratschlab/spladder
QC tool:
Requirements:

python 2.7
pysam
pandas
scipy
numpy

Pre-requisits:

needs pre-processed annotation table - will be provided by us

Call:

checkBias_2.0.py -o [outfile-prefix] -n [alignment.bam] -v -a [annotation.gtf] -m [annotation.preprocessed.m53]

Resources:

time: ~20min
memory: < 1GB
disk space: negligible

Source:

https://github.com/KjongLehmann/m53

Waiting on closure of #112.

Rewritten and rebased, just need to do a test run.


Docs - Romanian translation corrections were made. Previous translation was inaccurate

[X] I have read freeCodeCamp's contribution guidelines.
[X] My pull request has a descriptive title (not a vague title like Update index.md)
[X] My pull request targets the master branch of freeCodeCamp.
[X] None of my changes are plagiarized from another source without proper attribution.
[X] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

@RandellDawson from what I've seen most of the English version of the README.md has changed, and it no longer corresponds with any of the previous versions there are for the Romanian README.md; The corrections I made back in October concern the grammatical aspect of the Romanian version that was published, since it was a poor translation, most likely done using Google.
I'd advise the deletion of the current file, or if you want to keep it, accepting the grammatical corrections; However, as said, it is not a translation of the CURRENT English README.md. (I'd translate this myself, but I do not have the time at the moment)

@rebelliovs Since you do not have the time currently, are you OK with us closing this PR?  You can always create a new PR at a later date with a complete translation.

@RandellDawson feel free to close it.


Your form element should have the background-color of green.

Challenge http://freecodecamp.com/challenges/waypoint-use-an-id-attribute-to-style-an-element has an issue. Please describe how to reproduce it, and include links to screenshots if possible.

#cat-photo-element {
background-color: green;
}

all is good but the issue is
Your form element should have the background-color of green.
I think that it's no good!

Hello,
Your code is an example of using ID selector to add background:
#cat-photo-element {
  background-color: green;
}

The solution for this challange is doing the same but with different ID like:
#cat-photo-form {
  background-color: green;
}

@Dmytro Yarmak
Right
thank's!
2015-09-03 10:28 GMT+03:00 Dmytro Yarmak<EMAIL_ADDRESS>
Hello,
Your code is an example of using ID selector to add background:
#cat-photo-element {
background-color: green;
}
The solution for this challange is doing the same but with different ID
like:
#cat-photo-form {
background-color: green;
}
—
Reply to this email directly or view it on GitHub
https://github.com/FreeCodeCamp/FreeCodeCamp/issues/3013#issuecomment-137359557
.

--
ד"ר משה לוי
רופא פסיכיאטר
מנהל יחידת טיפול יום חיב"ה

@navyvel Apologies, you've probably got wrong Dmytro. You need  @dmytroyarmak

@navyvel if your problem is solved feel free to close this issue, thanks!

ok
2015-09-03 14:56 GMT+03:00 Arsen Melikyan<EMAIL_ADDRESS>
@navyvel https://github.com/navyvel if your problem is solved feel free
to close this issue, thanks!
—
Reply to this email directly or view it on GitHub
https://github.com/FreeCodeCamp/FreeCodeCamp/issues/3013#issuecomment-137416523
.

--
ד"ר משה לוי
רופא פסיכיאטר
מנהל יחידת טיפול יום חיב"ה

Hi! please check the snapshot. I have followed the instructions correct, but it still shows the error: "Your form element should have the background-color of green".

@saatishq It looks like you copied and pasted from the sidebar, which contains thin-space characters that invalidate your CSS markup. Try deleting that #cat-photo-form CSS declaration and typing it yourself.
Thanks and happy coding!

@saatishq and @ltegman Issue is not with Copy pasting, but rater with position of the id in the style. Move it in top of style, problem resolved. If you keep the id at the end of the style - problem is there

Can I get a shot of the form element section?

I have sorted the issue out. Thanks :)
On Mon, Mar 7, 2016 at 1:32 AM, Flyfisher57<EMAIL_ADDRESS>wrote:

Can I get a shot of the form element section?
—
Reply to this email directly or view it on GitHub
https://github.com/FreeCodeCamp/FreeCodeCamp/issues/3013#issuecomment-193008723
.

I don't know if this is the right place to ask or not, but why is it, when the code is placed at the top, it works but when placed at the bottom of the style section, it errors?

I am running into the same issue. I have typed in on top, did not resolve the issue. please help.

@ZGulman  .. the key to solving the issue is, delete the custom lines and type it all over again. do not copy-paste any of the codes from the left panel. Hope it helps.

I'm having the same problem I've tried delete and retyping it and moving it to the top. Is there something in the form or Id area I should be typing in?

Add this code before the end of  -------->  #cat-photo-form {background-color: green;}
worked for me. :)

it says make sure your form id has an attribute to me

@Francesqua it work ,thanks dear.

@saatishq  can u please give the screenshot of the assignment which has been done completly

@iqu440 the issues area is not for discussing solutions to the coding challenges. Please ask for help in the help chat room

the most important thing is to read what is ask, not about to copy and past, clear example this exercise
show you this  #cat-photo-element {
background-color: green;
but is asking you to do give the FORM... here is
#cat-photo-FORM {
background-color: green;
}
READ FIRST AND THEN WORK :)

All in the details thanks for the help

diegsoto6, thanks for making me see that.  I can't believe I didn't notice after looking at it for so long.

thanks s


Faster

This code is a slight speed improvement.

Pull Request Test Coverage Report for Build 100

0 of 0   changed or added relevant lines in 0 files are covered.
248 unchanged lines in 5 files lost coverage.
Overall coverage decreased (-87.5%) to 0.0%

Files with Coverage Reduction
New Missed Lines
%

pylj/sample.py
2
0.0%

pylj/mc.py
33
0.0%

pylj/md.py
55
0.0%

pylj/util.py
74
0.0%

pylj/pairwise.py
84
0.0%

Totals

Change from base Build 97:
-87.5%

Covered Lines:
0

Relevant Lines:
285

💛  - Coveralls


Week 24 Hacks

Night at the Museum

[x] Night at the Museum Blog link

Runtime Links
Frontend
Backend
CPT Review

[ ] Video
[ ] Written Response

Accomplishments
Challenges and Struggles
Github Analytics:
Frontend

Backend

Profile

Extra:

[x] Deployment Guide link
[x] Joint Deployment Guide link

Struggles and Challenges:

Getting started with SQLAlchemy and sqlite.db
Getting Data to show and be formatted correctly on our site

Peer Grade

Item
Self
P1 (Justin)
P2 (Sachit)
AVG

Observe Team project quality,  runs on cross domain, performs all evaluations without crashing
0
0
0

Observe, Individual UI contains inputs that are validated for garbage, data cleaned (ie validate DOB or Password)
0.5
0.5
0.5

Observe, Individual UI contains actions for Create, Read,
0.5
0.5
0.5

Observe, Individual UI contains actions for Update, Delete (above requirement)
0
0
0

Individual code quality, review and observe comments in every function, class, or method reviewed.
0.5
0.5
0.5

BE review, observe if  Individual API handles error conditions (ie duplicate user id)
0
0
0

BE review,  observe if Individual API contains GET and POST methods
1
1
1

BE review, observe that Individual code contains database operations that support Create, Read
0
0
0

BE review, observe that Individual code contains database operations that support Update, Delete (above requirement)
0
0
0

Team review ticket 1 point.  Participation of Individuals, 75% of individuals completed college board requirements with a crossover score on each of 6 criteria.
0.5
0.5
0.5

Review Ticket / Presentation
0.5
0.5
0.5

Runtime Links
0.5
0.5
0.5

Technical Achievements, backend focus
0
0
0

Guides for Review (include Blog)
0
0
0

Video
0
0
0

GitHub analytics
0.5
0.5
0.5

Bonus, substitute and personal achievement for .5 more
0.5
0.5
0.5


Allow running agent from command-line

:tada: This issue has been resolved in version 2.1.0 :tada:
The release is available on:

GitHub Release
NuGet Package
Chocolatey Package


syntax error, unexpected ':', expecting '(' [BUG]

Version information

Laravel: v#.#.#
Voyager: v#.#.#
PHP: #.#
Database: [type] [version] (e.g. MySQL 8.0)

Description

A clear and concise description of what the bug is.
Steps To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.

This happens when i try to extend a edit-add view
I just make a directory and copy the edit-add file from voyager (did not make any changes in the view) and it throws me an error

Issue template is not optional.  Please fill out all of the requested information, then this can be reopened.

@fletch3555 Sorry for lack of information at first

Issue template is not optional. Please fill out all of the requested information, then this can be reopened.
Sorry for the lack of information at first

What file did you copy from? Because that's definitely not the default BREAD edit-add file: https://github.com/the-control-group/voyager/blob/1.2/resources/views/bread/edit-add.blade.php#L195

I copied it from here. The file with random letters and number is not generated by me.
I deleted the file with random letters and it worked.
Thanks for the help and time. :)

The "file with random letters and number" is a cached view.  Make sure you always clear the view cache (artisan view:clear I believe) as part of your view troubleshooting steps.


Update foundation-datepicker.js

Added Swedish language (sv)

Could you please update also the readme file? Thanks :)

Yes, I will give it a shot!
Regards
Andreas

12 jun 2015 kl. 11:54 skrev Peter Beňo<EMAIL_ADDRESS>Could you please update also the readme file? Thanks :)
—
Reply to this email directly or view it on GitHub.


HandInteractionExamples Scene Performance Issues

Describe the bug
The HandInteractionExamples scene currently falls below 60fps on HoloLens 2 when the entire scene is in view. This is likely due to the complexity of the scene (too many draw calls). We should spend some time to reduce the complexity of the scene by increasing batching and instancing usage.
To reproduce
Steps to reproduce the behavior:

Launch HandInteractionExamples on HoloLens 2
Walk away from the scene content until all of it is in view.
Examine the frame rate.

Expected behavior
Frame rate is 60fps at all viewing locations.
Screenshots

Target Platform (please complete the following information)

HoloLens
HoloLens 2

Fixed with recent scene changes.


docs(build): update target url

updates the URL to something that will work directly from github for those not wanting to clone the repo

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


ImpressionGroup().redetectOptions  no work

var impressionGroup: ImpressionGroup = {
let impression = ImpressionGroup.init {(_, index: IndexPath, view, state) in
}
impression.redetectOptions = [.leftScreen]//no work
UIView.redetectOptions = [.leftScreen]//usefull
return impression
}()

Thank you


[Python] --additional-data false removes ALL properties on generated Python code models

What are you generating using Kiota, clients or plugins?
API Client/SDK
In what context or format are you using Kiota?
Nuget tool
Client library/SDK language
None
Describe the bug
foreach ($spec in $specs) {

    $spec.languageSettings | ForEach-Object {
        $language = $_.language
        $namespace = $_.namespace
        $output = $_.output

        Write-Host "Generating for $($spec.url)"

        docker run -v ${PWD}/examples:/app/output mcr.microsoft.com/openapi/kiota:1.14.0 generate `
            --output /app/output/$language/$output `
            --language $language `
            --namespace-name $namespace `
            --openapi $($spec.url) `
            --exclude-backward-compatible true `
            --log-level Debug `
            --clean-output `
            --additional-data false `
            --class-name ApiClient
    }
}

The generated Python code with --additional-data false breaks the generated python
Expected behavior
To not remove the fields... see example of running the generator a 2nd time with Git history showing the changes...

How to reproduce
Generate with the flag set to true and then generate again with it set to false.
Open API description file
Seems to be any openapi specification, as it occurs with all 3 openapi documents I am dealing with.
Kiota Version
1.14.0
Latest Kiota version known to work for scenario above?(Not required)
No response
Known Workarounds
Unknown, will have to ensure the flag is still set to true for Python only.
Configuration
Win11 running docker mcr.microsoft.com/openapi/kiota:1.14.0
Debug output
Click to expand log
```

Hint: use the info command to get the list of dependencies you need to add to your project.
Example: kiota info -d "https://developer.icis.com/portals/api/sites/icis-live-portal/liveportal/apis/lnganalyticsapi/download_spec" -l Java
Hint: use the --include-path and --exclude-path options with glob patterns to filter the paths generated.
Example: kiota generate --include-path "**/foo" -d "https://developer.icis.com/portals/api/sites/icis-live-portal/liveportal/apis/lnganalyticsapi/download_spec"
Generating for https://developer.icis.com/portals/api/sites/icis-live-portal/liveportal/apis/lnganalyticsapi/download_spec
info: Kiota.Builder.KiotaBuilder[0]
Cleaning output directory /app/output/Python/lnganalytics
dbug: Kiota.Builder.KiotaBuilder[0]
kiota version 1.14.0
dbug: Kiota.Builder.KiotaBuilder[0]
cache file /tmp/kiota/cache/generation/5A0BABF09B68A6E28F55D7E23347DD3239C41A4BE33096C5882D067794222D1B/download_spec not found, downloading from https://developer.icis.com/portals/api/sites/icis-live-portal/liveportal/apis/lnganalyticsapi/download_spec
info: Kiota.Builder.KiotaBuilder[0]
loaded description from remote source
dbug: Kiota.Builder.KiotaBuilder[0]
step 1 - reading the stream - took 00:00:00.6836112
warn: Kiota.Builder.KiotaBuilder[0]
OpenAPI warning: #/paths/~1basinTightnessScenarios/get/responses/200/content/application~1vnd.api+json/example/data/0/id - Data and type mismatch found.
warn: Kiota.Builder.KiotaBuilder[0]
OpenAPI warning: #/paths/~1basinTightnessScenarios/get/responses/200/content/application~1vnd.api+json/example/data/0/attributes/created - Data and type mismatch found.
warn: Kiota.Builder.KiotaBuilder[0]
OpenAPI warning: #/paths/~1basinTightnessScenarios/get/responses/200/content/application~1vnd.api+json/example/data/0/attributes/month - Data and type mismatch found.
warn: Kiota.Builder.KiotaBuilder[0]
OpenAPI warning: #/paths/~1basinTightnessScenarios/get/responses/200/content/application~1vnd.api+json/example/data/1/id - Data and type mismatch found.
warn: Kiota.Builder.KiotaBuilder[0]
OpenAPI warning: #/paths/~1basinTightnessScenarios/get/responses/200/content/application~1vnd.api+json/example/data/1/attributes/created - Data and type mismatch found.
warn: Kiota.Builder.KiotaBuilder[0]
OpenAPI warning: #/paths/~1basinTightnessScenarios/get/responses/200/content/application~1vnd.api+json/example/data/1/attributes/month - Data and type mismatch found.
warn: Kiota.Builder.KiotaBuilder[0]
OpenAPI warning: #/paths/~1basinTightnessScenarios~1{id}/get/responses/200/content/application~1vnd.api+json/example/data/id - Data and type mismatch found.
warn: Kiota.Builder.KiotaBuilder[0]
OpenAPI warning: #/paths/~1basinTightnessScenarios~1{id}/get/responses/200/content/application~1vnd.api+json/example/data/attributes/created - Data and type mismatch found.
warn: Kiota.Builder.KiotaBuilder[0]
OpenAPI warning: #/paths/~1basinTightnessScenarios~1{id}/get/responses/200/content/application~1vnd.api+json/example/data/attributes/month - Data and type mismatch found.
warn: Kiota.Builder.KiotaBuilder[0]
OpenAPI warning: #/paths/~1cargoes/get/responses/200/content/application~1vnd.api+json/examples/example/value/data/0/attributes/originDetails/mass - Data and type mismatch found.
warn: Kiota.Builder.KiotaBuilder[0]
OpenAPI warning: #/paths/~1cargoes/get/responses/200/content/application~1vnd.api+json/examples/example/value/data/0/attributes/originDetails/volume - Data and type mismatch found.
warn: Kiota.Builder.KiotaBuilder[0]
OpenAPI warning: #/paths/~1cargoes/get/responses/200/content/application~1vnd.api+json/examples/example/value/data/0/attributes/originDetails/energyContent - Data and type mismatch found.
warn: Kiota.Builder.KiotaBuilder[0]
OpenAPI warning: #/paths/~1cargoes/get/responses/200/content/application~1vnd.api+json/examples/example/value/data/0/attributes/destinationDetails/mass - Data and type mismatch found.
warn: Kiota.Builder.KiotaBuilder[0]
OpenAPI warning: #/paths/~1cargoes/get/responses/200/content/application~1vnd.api+json/examples/example/value/data/0/attributes/destinationDetails/volume - Data and type mismatch found.
warn: Kiota.Builder.KiotaBuilder[0]
OpenAPI warning: #/paths/~1cargoes/get/responses/200/content/application~1vnd.api+json/examples/example/value/data/0/attributes/destinationDetails/energyContent - Data and type mismatch found.
warn: Kiota.Builder.KiotaBuilder[0]
OpenAPI warning: #/paths/~1cargoes/get/responses/200/content/application~1vnd.api+json/examples/example/value/data/1/attributes/originDetails/mass - Data and type mismatch found.
warn: Kiota.Builder.KiotaBuilder[0]
OpenAPI warning: #/paths/~1cargoes/get/responses/200/content/application~1vnd.api+json/examples/example/value/data/1/attributes/originDetails/volume - Data and type mismatch found.
warn: Kiota.Builder.KiotaBuilder[0]
OpenAPI warning: #/paths/~1cargoes/get/responses/200/content/application~1vnd.api+json/examples/example/value/data/1/attributes/originDetails/energyContent - Data and type mismatch found.
warn: Kiota.Builder.KiotaBuilder[0]
OpenAPI warning: #/paths/~1cargoes/get/responses/200/content/application~1vnd.api+json/examples/example/value/data/1/attributes/destinationDetails/mass - Data and type mismatch found.
warn: Kiota.Builder.KiotaBuilder[0]
OpenAPI warning: #/paths/~1cargoes/get/responses/200/content/application~1vnd.api+json/examples/example/value/data/1/attributes/destinationDetails/volume - Data and type mismatch found.
warn: Kiota.Builder.KiotaBuilder[0]
OpenAPI warning: #/paths/~1cargoes/get/responses/200/content/application~1vnd.api+json/examples/example/value/data/1/attributes/destinationDetails/energyContent - Data and type mismatch found.
warn: Kiota.Builder.KiotaBuilder[0]
OpenAPI warning: #/paths/~1cargoes~1{id}/get/responses/200/content/application~1vnd.api+json/example/data/attributes/originDetails/mass - Data and type mismatch found.
warn: Kiota.Builder.KiotaBuilder[0]
OpenAPI warning: #/paths/~1cargoes~1{id}/get/responses/200/content/application~1vnd.api+json/example/data/attributes/originDetails/volume - Data and type mismatch found.
warn: Kiota.Builder.KiotaBuilder[0]
OpenAPI warning: #/paths/~1cargoes~1{id}/get/responses/200/content/application~1vnd.api+json/example/data/attributes/originDetails/energyContent - Data and type mismatch found.
warn: Kiota.Builder.KiotaBuilder[0]
OpenAPI warning: #/paths/~1cargoes~1{id}/get/responses/200/content/application~1vnd.api+json/example/data/attributes/destinationDetails/mass - Data and type mismatch found.
warn: Kiota.Builder.KiotaBuilder[0]
OpenAPI warning: #/paths/~1cargoes~1{id}/get/responses/200/content/application~1vnd.api+json/example/data/attributes/destinationDetails/volume - Data and type mismatch found.
warn: Kiota.Builder.KiotaBuilder[0]
OpenAPI warning: #/paths/~1cargoes~1{id}/get/responses/200/content/application~1vnd.api+json/example/data/attributes/destinationDetails/energyContent - Data and type mismatch found.
warn: Kiota.Builder.KiotaBuilder[0]
OpenAPI warning: #/paths/~1charters/get/responses/200/content/application~1vnd.api+json/examples/example/value/data/0/attributes/startDateEarliest - Data and type mismatch found.
warn: Kiota.Builder.KiotaBuilder[0]
OpenAPI warning: #/paths/~1charters/get/responses/200/content/application~1vnd.api+json/examples/example/value/data/0/attributes/startDateLatest - Data and type mismatch found.
warn: Kiota.Builder.KiotaBuilder[0]
OpenAPI warning: #/paths/~1charters/get/responses/200/content/application~1vnd.api+json/examples/example/value/data/0/attributes/endDateEarliest - Data and type mismatch found.
warn: Kiota.Builder.KiotaBuilder[0]
OpenAPI warning: #/paths/~1charters/get/responses/200/content/application~1vnd.api+json/examples/example/value/data/0/attributes/endDateLatest - Data and type mismatch found.
warn: Kiota.Builder.KiotaBuilder[0]
OpenAPI warning: #/paths/~1charters/get/responses/200/content/application~1vnd.api+json/examples/example/value/data/1/attributes/startDateEarliest - Data and type mismatch found.
warn: Kiota.Builder.KiotaBuilder[0]
OpenAPI warning: #/paths/~1charters/get/responses/200/content/application~1vnd.api+json/examples/example/value/data/1/attributes/startDateLatest - Data and type mismatch found.
warn: Kiota.Builder.KiotaBuilder[0]
OpenAPI warning: #/paths/~1charters/get/responses/200/content/application~1vnd.api+json/examples/example/value/data/1/attributes/endDateEarliest - Data and type mismatch found.
warn: Kiota.Builder.KiotaBuilder[0]
OpenAPI warning: #/paths/~1charters/get/responses/200/content/application~1vnd.api+json/examples/example/value/data/1/attributes/endDateLatest - Data and type mismatch found.
warn: Kiota.Builder.KiotaBuilder[0]
OpenAPI warning: #/paths/~1charters~1{id}/get/responses/200/content/application~1vnd.api+json/example/data/attributes/startDateEarliest - Data and type mismatch found.
warn: Kiota.Builder.KiotaBuilder[0]
OpenAPI warning: #/paths/~1charters~1{id}/get/responses/200/content/application~1vnd.api+json/example/data/attributes/startDateLatest - Data and type mismatch found.
warn: Kiota.Builder.KiotaBuilder[0]
OpenAPI warning: #/paths/~1charters~1{id}/get/responses/200/content/application~1vnd.api+json/example/data/attributes/endDateEarliest - Data and type mismatch found.
warn: Kiota.Builder.KiotaBuilder[0]
OpenAPI warning: #/paths/~1charters~1{id}/get/responses/200/content/application~1vnd.api+json/example/data/attributes/endDateLatest - Data and type mismatch found.
warn: Kiota.Builder.KiotaBuilder[0]
OpenAPI warning: #/paths/~1forecasts/get/responses/200/content/application~1vnd.api+json/examples/example/value/data/0/attributes/publishDate - Data and type mismatch found.
warn: Kiota.Builder.KiotaBuilder[0]
OpenAPI warning: #/paths/~1forecasts/get/responses/200/content/application~1vnd.api+json/examples/example/value/data/0/attributes/startDate - Data and type mismatch found.
warn: Kiota.Builder.KiotaBuilder[0]
OpenAPI warning: #/paths/~1forecasts/get/responses/200/content/application~1vnd.api+json/examples/example/value/data/0/attributes/endDate - Data and type mismatch found.
warn: Kiota.Builder.KiotaBuilder[0]
OpenAPI warning: #/paths/~1forecasts/get/responses/200/content/application~1vnd.api+json/examples/example/value/data/1/attributes/publishDate - Data and type mismatch found.
warn: Kiota.Builder.KiotaBuilder[0]
OpenAPI warning: #/paths/~1forecasts/get/responses/200/content/application~1vnd.api+json/examples/example/value/data/1/attributes/startDate - Data and type mismatch found.
warn: Kiota.Builder.KiotaBuilder[0]
OpenAPI warning: #/paths/~1forecasts/get/responses/200/content/application~1vnd.api+json/examples/example/value/data/1/attributes/endDate - Data and type mismatch found.
warn: Kiota.Builder.KiotaBuilder[0]
OpenAPI warning: #/paths/~1forecasts~1{id}/get/responses/200/content/application~1vnd.api+json/example/data - Data and type mismatch found.
warn: Kiota.Builder.KiotaBuilder[0]
OpenAPI warning: #/paths/~1forecastValues/get/responses/200/content/application~1vnd.api+json/examples/example/value/data/0/attributes/date - Data and type mismatch found.
warn: Kiota.Builder.KiotaBuilder[0]
OpenAPI warning: #/paths/~1forecastValues/get/responses/200/content/application~1vnd.api+json/examples/example/value/data/1/attributes/date - Data and type mismatch found.
warn: Kiota.Builder.KiotaBuilder[0]
OpenAPI warning: #/paths/~1forecastValues~1{id}/get/responses/200/content/application~1vnd.api+json/example/data - Data and type mismatch found.
warn: Kiota.Builder.KiotaBuilder[0]
OpenAPI warning: #/paths/~1netbacks/get/responses/200/content/application~1vnd.api+json/example/data/0/attributes/created - Data and type mismatch found.
warn: Kiota.Builder.KiotaBuilder[0]
OpenAPI warning: #/paths/~1netbacks/get/responses/200/content/application~1vnd.api+json/example/data/0/attributes/costAtOrigin - Data and type mismatch found.
warn: Kiota.Builder.KiotaBuilder[0]
OpenAPI warning: #/paths/~1netbacks/get/responses/200/content/application~1vnd.api+json/example/data/0/attributes/bunkerPrice - Data and type mismatch found.
warn: Kiota.Builder.KiotaBuilder[0]
OpenAPI warning: #/paths/~1netbacks/get/responses/200/content/application~1vnd.api+json/example/data/0/attributes/absoluteProfit - Data and type mismatch found.
warn: Kiota.Builder.KiotaBuilder[0]
OpenAPI warning: #/paths/~1netbacks/get/responses/200/content/application~1vnd.api+json/example/data/1/attributes/created - Data and type mismatch found.
warn: Kiota.Builder.KiotaBuilder[0]
OpenAPI warning: #/paths/~1netbacks/get/responses/200/content/application~1vnd.api+json/example/data/1/attributes/costAtOrigin - Data and type mismatch found.
warn: Kiota.Builder.KiotaBuilder[0]
OpenAPI warning: #/paths/~1netbacks/get/responses/200/content/application~1vnd.api+json/example/data/1/attributes/bunkerPrice - Data and type mismatch found.
warn: Kiota.Builder.KiotaBuilder[0]
OpenAPI warning: #/paths/~1netbacks/get/responses/200/content/application~1vnd.api+json/example/data/1/attributes/absoluteProfit - Data and type mismatch found.
warn: Kiota.Builder.KiotaBuilder[0]
OpenAPI warning: #/paths/~1netbacks~1{id}/get/responses/200/content/application~1vnd.api+json/example/data/attributes/created - Data and type mismatch found.
warn: Kiota.Builder.KiotaBuilder[0]
OpenAPI warning: #/paths/~1netbacks~1{id}/get/responses/200/content/application~1vnd.api+json/example/data/attributes/costAtOrigin - Data and type mismatch found.
warn: Kiota.Builder.KiotaBuilder[0]
OpenAPI warning: #/paths/~1netbacks~1{id}/get/responses/200/content/application~1vnd.api+json/example/data/attributes/bunkerPrice - Data and type mismatch found.
warn: Kiota.Builder.KiotaBuilder[0]
OpenAPI warning: #/paths/~1netbacks~1{id}/get/responses/200/content/application~1vnd.api+json/example/data/attributes/absoluteProfit - Data and type mismatch found.
warn: Kiota.Builder.KiotaBuilder[0]
OpenAPI warning: #/paths/~1transactions/get/responses/200/content/application~1vnd.api+json/example/data/0/attributes/transactionOrder - Data and type mismatch found.
warn: Kiota.Builder.KiotaBuilder[0]
OpenAPI warning: #/paths/~1transactions/get/responses/200/content/application~1vnd.api+json/example/data/0/attributes/price/high - Data and type mismatch found.
warn: Kiota.Builder.KiotaBuilder[0]
OpenAPI warning: #/paths/~1transactions/get/responses/200/content/application~1vnd.api+json/example/data/0/attributes/startDate - Data and type mismatch found.
warn: Kiota.Builder.KiotaBuilder[0]
OpenAPI warning: #/paths/~1transactions/get/responses/200/content/application~1vnd.api+json/example/data/0/attributes/endDate - Data and type mismatch found.
warn: Kiota.Builder.KiotaBuilder[0]
OpenAPI warning: #/paths/~1transactions/get/responses/200/content/application~1vnd.api+json/example/data/1/attributes/transactionOrder - Data and type mismatch found.
warn: Kiota.Builder.KiotaBuilder[0]
OpenAPI warning: #/paths/~1transactions/get/responses/200/content/application~1vnd.api+json/example/data/1/attributes/startDate - Data and type mismatch found.
warn: Kiota.Builder.KiotaBuilder[0]
OpenAPI warning: #/paths/~1transactions/get/responses/200/content/application~1vnd.api+json/example/data/1/attributes/endDate - Data and type mismatch found.
warn: Kiota.Builder.KiotaBuilder[0]
OpenAPI warning: #/paths/~1transactions~1{id}/get/responses/200/content/application~1vnd.api+json/example/data/attributes/transactionOrder - Data and type mismatch found.
warn: Kiota.Builder.KiotaBuilder[0]
OpenAPI warning: #/paths/~1transactions~1{id}/get/responses/200/content/application~1vnd.api+json/example/data/attributes/price/high - Data and type mismatch found.
warn: Kiota.Builder.KiotaBuilder[0]
OpenAPI warning: #/paths/~1transactions~1{id}/get/responses/200/content/application~1vnd.api+json/example/data/attributes/startDate - Data and type mismatch found.
warn: Kiota.Builder.KiotaBuilder[0]
OpenAPI warning: #/paths/~1transactions~1{id}/get/responses/200/content/application~1vnd.api+json/example/data/attributes/endDate - Data and type mismatch found.
warn: Kiota.Builder.KiotaBuilder[0]
OpenAPI warning: #/paths/~1vessels/get/responses/200/content/application~1vnd.api+json/example/data/0/attributes/capacity - Data and type mismatch found.
warn: Kiota.Builder.KiotaBuilder[0]
OpenAPI warning: #/paths/~1vessels/get/responses/200/content/application~1vnd.api+json/example/data/1/attributes/capacity - Data and type mismatch found.
warn: Kiota.Builder.KiotaBuilder[0]
OpenAPI warning: #/paths/~1vessels~1{id}/get/responses/200/content/application~1vnd.api+json/example/data/attributes/capacity - Data and type mismatch found.
warn: Kiota.Builder.KiotaBuilder[0]
OpenAPI warning: #/components/schemas/CargoModel/properties/attributes/properties/originDetails/properties/mass - The format integer is not supported by Kiota for the type number and the string type will be used.
warn: Kiota.Builder.KiotaBuilder[0]
OpenAPI warning: #/components/schemas/CargoModel/properties/attributes/properties/originDetails/properties/volume - The format integer is not supported by Kiota for the type number and the string type will be used.
warn: Kiota.Builder.KiotaBuilder[0]
OpenAPI warning: #/components/schemas/CargoModel/properties/attributes/properties/originDetails/properties/energyContent - The format integer is not supported by Kiota for the type number and the string type will be used.
warn: Kiota.Builder.KiotaBuilder[0]
OpenAPI warning: #/components/schemas/CargoModel/properties/attributes/properties/destinationDetails/properties/mass - The format integer is not supported by Kiota for the type number and the string type will be used.
warn: Kiota.Builder.KiotaBuilder[0]
OpenAPI warning: #/components/schemas/CargoModel/properties/attributes/properties/destinationDetails/properties/volume - The format integer is not supported by Kiota for the type number and the string type will be used.
warn: Kiota.Builder.KiotaBuilder[0]
OpenAPI warning: #/components/schemas/CargoModel/properties/attributes/properties/destinationDetails/properties/energyContent - The format integer is not supported by Kiota for the type number and the string type will be used.
warn: Kiota.Builder.KiotaBuilder[0]
OpenAPI warning: #/components/schemas/ForecastValueModel/properties/relationships/properties/forecast/properties/data/properties/id - The format string is not supported by Kiota for the type string and the string type will be used.
warn: Kiota.Builder.KiotaBuilder[0]
OpenAPI warning: #/components/schemas/TransactionModel/properties/attributes/properties/transactionOrder - The format int is not supported by Kiota for the type number and the string type will be used.
warn: Kiota.Builder.KiotaBuilder[0]
OpenAPI warning: #/components/schemas/VesselModel/properties/attributes/properties/capacity - The format int is not supported by Kiota for the type number and the string type will be used.
dbug: Kiota.Builder.KiotaBuilder[0]
step 2 - parsing the document - took 00:00:00.1319134
dbug: Kiota.Builder.KiotaBuilder[0]
step 3 - updating generation configuration from kiota extension - took 00:00:00.0001077
dbug: Kiota.Builder.KiotaBuilder[0]
step 4 - filtering API paths with patterns - took 00:00:00.0028528
dbug: Kiota.Builder.KiotaBuilder[0]
step 5 - checking whether the output should be updated - took 00:00:00.0201661
dbug: Kiota.Builder.KiotaBuilder[0]
step 6 - create uri space - took 00:00:00.0020808
dbug: Kiota.Builder.KiotaBuilder[0]
InitializeInheritanceIndex 00:00:00.0023986
dbug: Kiota.Builder.KiotaBuilder[0]
CreateRequestBuilderClass 00:00:00
dbug: Kiota.Builder.KiotaBuilder[0]
MapTypeDefinitions 00:00:00.0088460
dbug: Kiota.Builder.KiotaBuilder[0]
TrimInheritedModels 00:00:00
dbug: Kiota.Builder.KiotaBuilder[0]
CleanUpInternalState 00:00:00
dbug: Kiota.Builder.KiotaBuilder[0]
step 7 - create source model - took 00:00:00.0911265
dbug: Kiota.Builder.KiotaBuilder[0]
108ms: Language refinement applied
dbug: Kiota.Builder.KiotaBuilder[0]
step 8 - refine by language - took 00:00:00.1090963
dbug: Kiota.Builder.KiotaBuilder[0]
step 9 - writing files - took 00:00:01.2042072
dbug: Kiota.Builder.KiotaBuilder[0]
cache file /tmp/kiota/cache/generation/5A0BABF09B68A6E28F55D7E23347DD3239C41A4BE33096C5882D067794222D1B/download_spec is up to date and clearCache is False, using it
info: Kiota.Builder.KiotaBuilder[0]
loaded description from remote source
dbug: Kiota.Builder.KiotaBuilder[0]
step 10 - writing lock file - took 00:00:00.0142189
Generation completed successfully
dbug: Kiota.Builder.KiotaBuilder[0]
Api manifest path: /app/apimanifest.json
Hint: use the info command to get the list of dependencies you need to add to your project.
Example: kiota info -d "https://developer.icis.com/portals/api/sites/icis-live-portal/liveportal/apis/lnganalyticsapi/download_spec" -l Python
Hint: use the --include-path and --exclude-path options with glob patterns to filter the paths generated.
Example: kiota generate --include-path "**/foo" -d "https://developer.icis.com/portals/api/sites/icis-live-portal/liveportal/apis/lnganalyticsapi/download_spec"
</details>

### Other information

_No response_

Thanks for raising this @pjmagee
It looks like this issue only affect python at the moment as the other languages do not seem to exhibit this behaviour.
The cause here looks be that python properties are written by the CodeMethodWriter rather than the property writer(not exactly sure of the reason why here) which expects the presence of the CodeMethodKind.Constructor method in order to write the types.
When the additionalproperties are not present, the constructor is not added as the model does not have any property with a default value(additionalData).
To fix this we probably need to either have the python refiner have the constuctor forceAdd the constructor for model types by passing the Boolean parameter here as well as the Class kinds that may not need the default constructor.
https://github.com/microsoft/kiota/blob/72e70baf817fa9c4783347985ee37f3fa88d3e9b/src/Kiota.Builder/Refiners/CommonLanguageRefiner.cs#L234


Can this be used in webpack?

I have noticed that for vue 2 you use runtime/installComponents but not for vue 3. Was wondering why. Also is this only for vue cli or can I use it with webpack too?
Thank you!

Hey @MrHBS
To answer your first question, the Vue component API is different between 2 and 3, there are fewer edge cases you need to account for in 3. If you are having issues with it please make an issue.
As for working in webpack in general, not out of the box, you could in theory hook up the loader though but it requires some knowledge of webpack.
The code you'd use is this bit, where the loader is the vue2 or vue3 loader depending on what you're using.
api.chainWebpack((webpackConfig) => {
    webpackConfig.module
      .rules
      .get('vue')
      // add our custom components loader before the vue-loader
      .use('components')
      .loader(require.resolve('./loader'))
      .options(pluginOptions)
      .before('vue-loader')
      .end()
  })

If you want to go down that path you're probably better off forking the package and getting it to work to your use case.

Just to make it clear I don’t need the runtime/installComponents if I am doing Vue 3 only right? It seems all the loaders I see (vuetify-loader, chakra-loader, etc) use that. Thank you so much! @harlan-zw

Just to make it clear I don’t need the runtime/installComponents if I am doing Vue 3 only right? It seems all the loaders I see (vuetify-loader, chakra-loader, etc) use that. Thank you so much! @harlan-zw

They're all for Vue 2. Vue 3 shouldn't need it. Through my testing I didn't run into any issues.
Read my article I wrote on how this work (linked in read me) if you're interested in where the differences would be


Cannot find module 'playwright-core'

Thank you for this library, I have found playwright to be superior to puppeteer and would prefer to use it on AWS.
Unfortunately currently I am getting an error whenever I try to use it, including the simple demo code in the README.
internal/modules/cjs/loader.js:638
    throw err;
    ^

Error: Cannot find module 'playwright-core'
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:636:15)
    at Function.Module._load (internal/modules/cjs/loader.js:562:25)
    at Module.require (internal/modules/cjs/loader.js:692:17)
    at require (internal/modules/cjs/helpers.js:25:18)
    at Object.<anonymous> (E:\Nodejs\AllTheComps\playwright\dev\node_modules\playwright-aws-lambda\dist\src\chromium.js:5:20)
    at Module._compile (internal/modules/cjs/loader.js:778:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:789:10)
    at Module.load (internal/modules/cjs/loader.js:653:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:593:12)
    at Function.Module._load (internal/modules/cjs/loader.js:585:3)

The offending line is:
const playwright = require("playwright-core");
I'm developing on Windows but this happened on Lambda as well. I have npm install'd playwright-core, it definitely exists in node_modules

@BusDriver01 playwright-core is a peer dependency, so it does not come packaged with this module. Can you make sure that you installed it into your project as a direct dependency and not a dev dependency? Are you bundling your lambda somehow?

I installed both modules via npm: npm install playwright-core playwright-aws-lambda --save
Previously I had installed the full playwright -- could that be causing a conflict?
In node_modules, there are 3 related directories: playwright, playwright-aws-lambda, and playwright-core

Having the same issue.

Anyone found a solution for this? Facing same issue

This error is due to the issue in the core package. In version 1.1.0 the playwright-core package does not contain anymore a valid index.js / entrypoint.
1.0.2<EMAIL_ADDRESS><-- expected
1.1.0<EMAIL_ADDRESS><-- actual

Temporary Solution is to downgrade to 1.0.2

@sanudatta11 thanks for looking into this. Disappointing that the Playwright team shipped a breaking change like this in a minor version...The reason I chose to use playwright-core originally is to avoid the browser(s) post install process in the main playwright package. The playwright-core package only contained the core JS logic used to drive the underlying browsers.

Was going to write that this bug has been reported at playwright but I see you've participated in that thread already. Hope we'll see a fix very soon, the PR has been submitted. Thanks again @austinkelleher and @sanudatta11  !


UWP build is broken

hkeyholder.hpp(37): error C2039: 'RegCloseKey': is not a member of '`global namespace'' (compiling source file telemetry_policy.cpp)
hkeyholder.hpp(37): error C3861: 'RegCloseKey': identifier not found (compiling source file telemetry_policy.cpp)

(It is HKeyHolder)

Solution:
After
#pragme once

Add this:
#include "azure/core/platform.hpp"
And then, after
#if defined(AZ_PLATFORM_WINDOWS)
#if !defined(WIN32_LEAN_AND_MEAN)
#define WIN32_LEAN_AND_MEAN
#endif
#if !defined(NOMINMAX)
#define NOMINMAX
#endif

#include <windows.h>

Add this:
#if !defined(WINAPI_PARTITION_DESKTOP) \
    || WINAPI_PARTITION_DESKTOP // See azure/core/platform.hpp for explanation.

and then add the corresponding
#endif

@RickWinter, this one is blocking release, still not assigned, I can implement it by EOD, but late.

If you are fine with that - assign to me, I know how to fix it.

Do not attempt to use WINAPI_PARTITION_DESKTOP check before you include windows.h, and do not include windows.h until you check for AZ_PLATFORM_WINDOWS, and do not check AZ_PLATFORM_WINDOWS until you include azure/core/platform.hpp.

Is there a way we can spread this guidance more broadly to the team so we know how to use the windows.h correctly in all cases? Do we have other usages that need to be corrected?

@ahsonkhan - it is, already: https://github.com/Azure/azure-sdk-for-cpp/blob/master/sdk/core/azure-core/inc/azure/core/platform.hpp#L9-L42
Plus, every comment that checks for UWP sends the reader to go read that comment.


Change getNumberOf -> getNumbersOf in SampledSpanStore.

Codecov Report

Merging #378 into master will not change coverage.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master     #378   +/-   ##
=========================================
  Coverage     91.49%   91.49%
  Complexity      583      583
=========================================
  Files            97       97
  Lines          2305     2305
  Branches        208      208
=========================================
  Hits           2109     2109
  Misses          142      142
  Partials         54       54

Impacted Files
Coverage Δ
Complexity Δ

...a/io/opencensus/trace/export/SampledSpanStore.java
86.48% <100%> (ø)
1 <0> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75291d2...954b012. Read the comment docs.


Cell Rendering issue displays [Object object]

I'm submitting a ...  (check one with "x")
["x"] bug report => search github for a similar issue or PR before submitting
[ ] feature request
[ ] support request => Please do not submit support request here, instead see https://github.com/ceolter/ag-grid/blob/master/CONTRIBUTING.md#question

Current behavior

"I am trying to render each cell of Connection Column with hoverable dropdown
For this i am using cell renderer function in the following way  "
"
var gridOptions = {
columnDefs: [
{headerName: 'Connection', field: 'Applicationaccess',minWidth:350,filter:'text',filterParams:{
     filterOptions:['equals','contains']

    },cellClass: 'all_grid_cell conn_cell',cellRenderer:function(params){

    var p=params.value;
    var $wrapper_div = $("<div>",{"class":"w3-dropdown-hover"});
    var $newlink=$("<a>",{"href":"javascript:void(0)","class":"link w3-white","text":p});
    $newlink.appendTo($wrapper_div);
    var $ediv = $("<div>",{"class":"w3-dropdown-content w3-bar-block w3-border"});
    var x=['meet','meeeeet','meeeeeeeet'];
    for(i=0;i<x.length;i++){
      var $btn=abc(x[i]);
      $btn.appendTo($ediv);
    }
    $ediv.appendTo($wrapper_div);
    return $wrapper_div;

    }} "

"function abc(x){
var $btn=$("",{"class":" w3-bar-item w3-button","text":x});
return $btn;
}  "
Expected behavior

However it is just showing [Object object] in the Connection Columns]
Minimal reproduction of the problem with instructions

What is the motivation / use case for changing the behavior?

Please tell us about your environment:

Windows 7

ag-Grid version: 10.0.1

Browser:

Chrome

Language: [all | TypeScript X.X | ES6/7 | ES5]

Realized i was return a jquery object rather than a javascript object
Solution is to return $wrapper_div[0]


Partial match keyword arguments

Subject of the issue
It would be nice to do
class Dummy
  def self.foo(a:, b:)
  end
end

it 'works with kword args' do
  expect(Dummy).to receive(:foo).with(keyword_args_including(a: 1))
  foo(a: 1, b: 2)
end

In other words, not having to specify all the keyword arguments on a receive expectation.
Your environment

Ruby version: 2.7.1
rspec-expectations version: all

Actual behavior
You can do something like
it 'works with kword args' do
  expect(Dummy).to receive(:foo).with(hash_including(a: 1)) # won't work
  expect(Dummy).to receive(:foo).with(array_including(hash_including(a: 1))) # also won't work
  foo(a: 1, b: 2)
end

This will fail, as internally the first argument turns into an array with one has in it, i.e. [{ a: 1, b: 2 }].

Yeah this needs a new matcher, because keywords are not a hash or an array :joy:

@JonRowe oh what are they? Then? :).
Do you know where it is in the codebase? Maybe I can take a stab at it

@yagudaev sure, a pull request is welcome.
Wondering, what is the case where you only match some of those kwargs, and not all?

@pirj I was trying to test an email method receives a to argument fallback even if say the user was deleted/not present.
Something like
class AcceptedInviteMailer
  def perform
   to = invite.created_by
   to = invite.organization.admins if invite.created_by.discarded

    Email.deliver(to: to, subject: "#{invite.email} accepted your request to join #{invite.organization.name}", body: body)
  end
end

class Email
  def self.deliver(to:, subject:, body:, options: {})
  end
end

describe AcceptedInviteMailer do
  context 'when invite author is an active user' do
     it 'sends an email to the user' do
        expect(Email).to receive(:deliver).with(including_keyword_args(to: 'author@example.com'))
    end
  end

  context 'when invite author is an inactive user' do
     it 'sends an email to all organization admins as a fallback' do
        expect(Email).to receive(:deliver).with(including_keyword_args(to: ['admin@example.com']))
    end
  end
end

Something along those lines is what I wanted to write. Other fields are irrelevant in that specific test.

Thanks for the comprehensive explanation and example!
We actually allow the same for positional arguments, e.g. with(1, any_args) does match both foo(1) and foo(1, :bar, :bazz), so why not do the same with kwargs.
I guess even though there's probably not much use for keyword_args_including outside of rspec-mocks, it fits better rspec-expectations.

@JonRowe oh what are they? Then? :).

They are keyword arguments, they are there own thing. The thing is that Ruby interprets them in different ways, a **kwargs argument is a hash, (I believe) but thats the point where they become one, thus if you do this:
def my_method(a: a, b: b)
end

expect(self).to receive(:my_method).with(a: a, b: b)
my_method(a: 'a', b: 'b')

It looks like a hash from the tests perspective, but it is not a hash to the method, and it is ambiguous when calling the method (from Rubies perspective and indeed this is where the warning come from in later Rubies).

@JonRowe thanks or the explanation.
What would a matcher psedu code look like for that to only match on a key argument only (leaving b to be any value)?

Was able to test keyword args using this way:
describe "#thing" do
  let(:something) { instance_double(Something) }
  before do
    allow(Something).to receive(:new).and_return(something)
  end
  it "initializes something" do
    subject

    expect(Something).to have_received(:new) do |*args, **kwargs|
      expect(kwargs).to match({a: :b})
    end
  end
end

This was actually closed in #1394, On Ruby 3 with automatically checks kw args vs hashes, but its not released, I will try to cut a release soon.

I just asked about something very related on Stack Overflow: https://stackoverflow.com/questions/73309031/partially-match-kwargs-in-rspec-have-receivedfoo-withmy-keyword-once
I can't just do
    expect(Something).to have_received(:new) do |*args, **kwargs|
      expect(kwargs).to match({a: :b})
    end

since the method can be called with multiple kwargs, and I want to assert that it's called with a specific subset of kwargs once.
So this works, but is misleading (since I don't want to allow a hash arg, only kwargs):
expect(Something).to have received(:foo).with(a_hash_including(my_kwarg: "hello")).once

Is there anything in RSpec for this currently?

I still don't see anything in the docs to specify matching keyword arguments:
https://relishapp.com/rspec/rspec-mocks/v/3-12/docs/setting-constraints/matching-arguments
What is the correct way to do this?

What is your scenario, @ddoherty03 ? A PR to improve docs is welcome.

I am trying to stub as follows:
    def self.split_factors(comm, as_of: Date.current, force_update: false)
    ...
    end

In my spec, I have tried this, based on the above:
    allow(Fmv).to receive(:split_factors)
                    .with(amzn, keyword_args_including(as_of: Date.current)) {
      {Date.parse('2022-06-06') => BigDecimal('20.0')}
    }

And I get " NoMethodError:
undefined method `keyword_args_including'"
Looking through the above docs, I find nothing about how to spec keyword arguments.  Am I missing something obvious?

Would the following work?
    allow(Fmv).to receive(:split_factors)
                    .with(amzn, as_of: Date.current) {
      {Date.parse('2022-06-06') => BigDecimal('20.0')}
    }

Currently keyword argument matching requires all keywords just like positional arguments do, but you've provided a default so as long you're not calling it with the extra value, @pirj's example should work fine for you.

@pirj and @JonRowe, many thanks.  That did it for me.  I ended up writing a custom matcher, but your comments got me unstuck.  As for the issue, an example or two using keyword arguments would be really helpful on the examples page here:
https://relishapp.com/rspec/rspec-mocks/v/3-12/docs/setting-constraints/matching-arguments

You are welcome, @ddoherty03. A PR to improve docs is welcome.

I've added some extra docs / scenarios over in rspec/rspec-mocks#1526 would this have helped you @ddoherty03 ?

@JonRowe, yes that would have helped.  Many thanks.


WL-5116 Fix for bad merge.

We only want to export the display ID when it’s a custom export.

Good spot, corrected, and the header that was wrong as well.


BasicOTA not working on ESP32

Hi,
I have the following issue with BasicOTA on my ESP-WROOM 32.
I just modified the field "ssid" and "password" with my wifi logs.
When i run it, i get this output on Serial monitor

ets Jun  8 2016 00:22:57
rst:0x10 (RTCWDT_RTC_RESET),boot:0x13 (SPI_FAST_FLASH_BOOT)
configsip: 0, SPIWP:0xee
clk_drv:0x00,q_drv:0x00,d_drv:0x00,cs0_drv:0x00,hd_drv:0x00,wp_drv:0x00
mode:DIO, clock div:1
load:0x3fff0018,len:4
load:0x3fff001c,len:956
load:0x40078000,len:0
load:0x40078000,len:13076
entry 0x40078a58
Booting
E (21) wifi: misc_nvs_load 43 ret=4364
E (22) wifi: wifi_init 1408 ret=4364
Ready
IP address: <IP_ADDRESS>

I added nvs_flash_init() in app_main as mentioned in #1478, but still not fixing the problem.
However, a new Network port is available on Arduino IDE, but when i try to upload a new sketch i get the following message (without asking any password)

Sending invitation to <IP_ADDRESS> ..........
18:44:39 [ERROR]: No response from the ESP
18:44:39 [ERROR]: No response from the ESP

Thanks for your time and your help.

please try make erase ，then try make flash again

@Dawge Could you help share if any updates for this issue? Thanks.

@Dawge Hi, feel free to reopen the issue, thanks.


How to send data

How to send or store data. Compare to File and TCP writer in Java.

Here is a big and full tutorial on writing and storing data in files.


[Bug]: dark mode in home page

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
dark mode is not looking good in home page i want to improve it
Add Screenshots

What browsers are you seeing the problem on?
No response
Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC contributor
[X] I want to work on this issue
[X] I'm willing to provide further clarification or assistance if needed.

@mansiruhil13  it will not effect his work, but for the safety purpose i will startmy work when he done the changes

@mansiruhil13 it will not effect his work, but for the safety purpose i will startmy work when he done the changes

but dark theme also has toggle and translator.

current darkmode is looking good, i don't think so it need further modifications now, so i m closing this issue.


HTTP/Core Comm Error Notifications

With this PR, errors when communicating with the core are now signalled to the user using the notification system.

@michaelkleinhenz snapshot fabric8-ui is deployed and available for testing at https://fabric8-ui-fabric8-ui-pr-1684-fabric8-planner.int.rdu2c.fabric8.io

@michaelkleinhenz snapshot fabric8-ui is deployed and available for testing at https://fabric8-ui-fabric8-ui-pr-1684-fabric8-planner.int.rdu2c.fabric8.io

@nimishamukherjee @michaelkleinhenz We need to remove all the error message text from the iteration modal and add show it by the notification system.

@michaelkleinhenz @nimishamukherjee @vikram-raj the iteration modal should still have errors in the form - we should not stray away from that. This design (http://www.patternfly.org/pattern-library/forms-and-controls/errors-and-validation/) uses both the validation errors and field error messages.

@nimishamukherjee the notification is coming up because there was a http error. So that the notification is coming up is fine, we need to look why there is a http error in that case.

And that error seems to have no reason attached (hence the "undefined"). But I'll add something that prevents undefined values to be displayed.

Ok, done, if the httpError is empty, there is no more an "undefined". Still, we need to look why there is an http error on that action. But this is unrelated to this PR.

@michaelkleinhenz snapshot fabric8-ui is deployed and available for testing at https://fabric8-ui-fabric8-ui-pr-1684-fabric8-planner.int.rdu2c.fabric8.io


Unable to use hellosign.embedded.getEditUrl in test mode

Unsure/unable to pass test_mode: 1 to the getEditUrl method.
Getting a log from API that locked templates cannot be accessed, but the template was created with test mode = 1 see bottom here.
Is it possible to test this method before putting in production?
 hellosign.embedded
    .getEditUrl(templateIdGoesHere)
    .then(result => etc

templates have been created with test_mode = 1
const opts = {
    test_mode: 1,
   ...
  };
  hellosign.template
    .createEmbeddedDraft(opts)

Talking to API Team today, all templates created in test mode are locked and unable to be edited.

Hey @NickFoden, glad our API Support team helped you out :) Let us know if you have any other issues!


Correct the cursor invalidation region

Depending on the line rendition, and whether the cursor is over a wide
character or not, it's possible for the width to take up anywhere from 1
to 4 cells. And when it's more than 1 cell wide, part of the cursor may
end up off screen. However, our bounds check requires the entire cursor
to be on screen, otherwise it doesn't render anything, and that can
result in cursor droppings being left behind. This PR fixes that.
The bounds check that is causing this issue was introduced in #13001 to
fix a debug assertion.
To fix this, I've removed the bounds checking, and instead clip the
cursor rect to the boundaries of the viewport. This is what the original
code was trying to do prior to the #13001 fix, but was mistakenly using
the Viewport:Clamp method, instead of TrimToViewport. Since this
implementation doesn't require a clamp, there should be no risk of the
debug assertion returning.
Validation Steps Performed
I've confirmed that the test case in #14657 is now working correctly,
and not leaving cursor droppings behind. I've also tested under conhost
with buffer sizes wider than the viewport, and confirmed it can handle a
wide cursor partially scrolled off screen.
Closes #14657

Excellent fix, thanks!


GRAPE Pulse Optimization Implementation

Implemented the GRAPE method.

Surfaced the IR Transformation service.

Added a simple unit test.

This commit is combined from commits from working branch. I forgot to sign off on one commit.
Tested by: unit testing here and unit testing + example on QuaC
Signed-off-by: Thien Nguyen<EMAIL_ADDRESS>

This looks great. @tnguyen-ornl covered under UT Battelle MLA


Add convert scripts for weight of controlnet

Convert scripts for converting weights of (partial) ControlNet.
Except cond_stage model due to mismatch keys.

hold until pr#90 is settled

[outdated] hold until pr#90 is settled

PR#90 has been merged.

does it function without cond?

After converting, we have to load the base model (to load the weights of FrozenClip model) first then load this converted model to function normally.

does it function without cond?

After converting, we have to load the base model (to load the weights of FrozenClip model) first then load this converted model to function normally.

can you point to the code where it's loading twice? I don't seem to find it in i2i.py

does it function without cond?

After converting, we have to load the base model (to load the weights of FrozenClip model) first then load this converted model to function normally.

can you point to the code where it's loading twice? I don't seem to find it in i2i.py

For now, this part is done manually. Should I add this part to the convert codes? It will require an additional input (path to the base weights file of ms).

does it function without cond?

After converting, we have to load the base model (to load the weights of FrozenClip model) first then load this converted model to function normally.

can you point to the code where it's loading twice? I don't seem to find it in i2i.py

For now, this part is done manually. Should I add this part to the convert codes? It will require an additional input (path to the base weights file of ms).

Maybe add to i2i: --vae and --clip, with a same base ckpt as default.

Update accordkingy


Make error reason for disallowed legacy sigalg more specific

The internal error reason is confusing and indicating an error in OpenSSL and not a configuration problem.
Fixes #19867
I am proposing this as a bug fix to be backported to 3.0 because the current error reason is actually causing reports as #19867.

OTC question: Is this acceptable as bug fix for 3.0?

This pull request is ready to merge

Merged three places.

Hmm... this was supposed to be discussed within OTC. I'll reopen this just in case OTC decides to revert it.

OTC: No objections to treating this as bug fix and merging to 3.1 and 3.0.


style is not applied

github-hide-files button's style is not applied. Here is capture image below:

I am trying to know what is cause of problem and fix it.

Which style does not work? Please be a little more specific.

I am talking about content.css. In this CSS, you use table selector but Github is not use table tag anymore so I think we have to write new CSS.

@arthurvr Is this button style working in your browser ?

I create a PR. https://github.com/sindresorhus/github-hide-files/pull/12

Closing as this is fixed in https://github.com/sindresorhus/github-hide-files/pull/12.


Add created_at Datetime Column To Migrations

Add executed_at date time column to the migrations table and fill it with the current time when the migration is run.
This sort of feature will be extremely helpful for larger teams to know when a particular migration ran. Having the date time will help with debugging if there is a bad migration. The time can then be used to correlate other things happening throughout the app or figure out who ran the migration.
Having access to more information without the user having to do anything seems like a win-win. Upgrading to Laravel 12 means they would have to add the column, but that is a simple migration and it's been done before when the ID column was added.

Why not stick with the created_at naming?

Why not stick with the created_at naming?

Sounds fine to me. My thought process was the name executed is a bit more descriptive, but people are definitely used to created_at.

Does anyone have an idea why the tests are failing?
Even if I removed my changes the tests were failing.

how is the backwards compatibility on this? will this force everyone to update their migrations table?
I think it would be good if the code could keep working even created_at column is missing.

Could you achieve this without any code changes by using $table->timestamp('created_at')->useCurrent()?


Test runner script with environment variables

This obviates the need to use template variables in the run.sh
script all together by replacing them with default environment
variables that can be used similarly. However, it avoids the
additional complexity for users to understand how templates
works (although it isn't too difficult, it adds another layer...)
Fixes #680.

Codecov Report

Merging #682 (df1c23f) into master (30556b3) will increase coverage by 0.09%.
The diff coverage is 95.83%.

@@            Coverage Diff             @@
##           master     #682      +/-   ##
==========================================
+ Coverage   23.24%   23.33%   +0.09%
==========================================
  Files          70       70
  Lines       10319    10322       +3
==========================================
+ Hits         2399     2409      +10
+ Misses       7592     7587       -5
+ Partials      328      326       -2

Flag
Coverage Δ

unittests
23.33% <95.83%> (+0.09%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

ci/clone_repositories.go
0.00% <ø> (ø)

ci/run_tests.go
17.64% <0.00%> (ø)

ci/docker.go
64.11% <100.00%> (+0.21%)
:arrow_up:

ci/parse_script.go
100.00% <100.00%> (+25.00%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30556b3...df1c23f. Read the comment docs.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

23 of 24 (95.83%)  changed or added relevant lines in 3 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.07%) to 25.898%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

ci/run_tests.go
0
1
0.0%

Files with Coverage Reduction
New Missed Lines
%

ci/clone_repositories.go
1
0%

Totals

Change from base Build<PHONE_NUMBER>:
0.07%

Covered Lines:
2776

Relevant Lines:
10719

💛  - Coveralls