Question about 'StateNotifierProvider.overrideWith....'  behavior.

flutter_riverpod 1.0.0-dev.6
What difference overrideWithValue and overrideWithProvider, their have same behaviour?
I have a StateNotifierProvider and used it in TabBar, when I changed the tab, the CounterStateNotifier should dispose and print CounterStateNotifier dispose..
It work when use overrideWithProvider,  but not withoverrideWithValue.
overrideWithValue doesn't seem to work, CounterStateNotifier not override.
import 'package:flutter/material.dart';
import 'package:flutter_riverpod/flutter_riverpod.dart';

void main() {
  runApp(const ProviderScope(
    observers: [SimpleObserver()],
    child: MyApp(),
  ));
}

class SimpleObserver extends ProviderObserver {
  const SimpleObserver();
  @override
  void didDisposeProvider(ProviderBase provider, ProviderContainer containers) {
    print('didDisposeProvider: ${provider.name ?? provider.runtimeType}');
    super.didDisposeProvider(provider, containers);
  }
}

class MyApp extends StatelessWidget {
  const MyApp({Key? key}) : super(key: key);

  @override
  Widget build(BuildContext context) {
    return const MaterialApp(
      home: MyHomePage(),
    );
  }
}

class MyHomePage extends StatelessWidget {
  const MyHomePage({Key? key}) : super(key: key);

  @override
  Widget build(BuildContext context) {
    return DefaultTabController(
      length: 2,
      child: Scaffold(
        appBar: AppBar(
          bottom: const TabBar(tabs: [
            Tab(text: 'first'),
            Tab(text: 'second'),
          ]),
        ),
        body: TabBarView(
          children: [
            ProviderScope(overrides: [
              // overrideWithValue doesn't seem to work
              counterProvider.overrideWithValue(CounterStateNotifier(0)),
              // counterProvider.overrideWithProvider(
              //     StateNotifierProvider.autoDispose(
              //         (ref) => CounterStateNotifier(0))),
            ], child: const CounterPage()),
            Container(),
          ],
        ),
      ),
    );
  }
}

class CounterPage extends ConsumerWidget {
  const CounterPage({Key? key}) : super(key: key);

  @override
  Widget build(BuildContext context, WidgetRef ref) {
    int count = ref.watch(counterProvider);
    return Row(
      mainAxisAlignment: MainAxisAlignment.center,
      children: [
        ElevatedButton(
            onPressed: ref.read(counterProvider.notifier).increment,
            child: const Text('increment')),
        const SizedBox(width: 12),
        Text('$count'),
      ],
    );
  }
}

final counterProvider =
    StateNotifierProvider.autoDispose<CounterStateNotifier, int>(
        (_) => throw UnimplementedError());

class CounterStateNotifier extends StateNotifier<int> {
  CounterStateNotifier(int state) : super(state);

  void increment() => state++;

  @override
  void dispose() {
    print("CounterStateNotifier dispose.");
    super.dispose();
  }
}

log: use overrideWithValue
flutter: didDisposeProvider: AutoDisposeStateNotifierProvider<CounterStateNotifier, int>
flutter: didDisposeProvider: _AutoDisposeNotifierProvider<CounterStateNotifier>

log: use overrideWithProvider
flutter: didDisposeProvider: AutoDisposeStateNotifierProvider<CounterStateNotifier, int>
flutter: CounterStateNotifier dispose.
flutter: didDisposeProvider: _AutoDisposeNotifierProvider<CounterStateNotifier>

overrideWithProvider acts as a full provider. The result is cached, the notifier is disposed, and you get to use ref.listen/ref.watch
overrideWithValue does not. It neither caches the value not disposes the notifier, and you can't use ref features.
To be correct, your snippet using overrideWithValue has a bug.
If you used hot-reload, using overrideWithValue like you did, you would lose your counter state, and would need a StatefulWidget to fix it:
class MyHomePage extends StatefulWidget {
  const MyHomePage({Key? key}) : super(key: key);

  @override
  State<MyHomePage> createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  final firstTabCounter = CounterStateNotifier(0);

  @override
  void dispose() {
    firstTabCounter.dispose();
    super.dispose();
  }

  @override
  Widget build(BuildContext context) {
    return DefaultTabController(
      length: 2,
      child: Scaffold(
        appBar: AppBar(
          bottom: const TabBar(tabs: [
            Tab(text: 'first'),
            Tab(text: 'second'),
          ]),
        ),
        body: TabBarView(
          children: [
            ProviderScope(overrides: [
              counterProvider.overrideWithValue(firstTabCounter),
            ], child: const CounterPage()),
            Container(),
          ],
        ),
      ),
    );
  }
}

On the other hand, by using overrideWithProvider, this isn't a problem.

@rrousselGit What means "result is cached", your comment make me event more confused 😂.
In my opinion, overrideWithValue wrap notifier in a ValueProvider, so it loses the ability to dispose, ValueProvider seems to only dispose itself.
And now I seem to know why overrideWithValue in my Snippet didn't reset the counter back to zero.
Because the TabBarView holds a reference to the ProviderScope. When the Tab is switched, the reference will not be released, but its state will be rebuilt. But overrides are already stored in ProviderScope, so when rebuilding ProviderScopeState, the first overrides is always used. So if I want to apply the new overrides, I can wrap the ProviderScope with a Builder.
In addition, hot-reload throws an exception because ProviderScopeState needs to update overrides, and if the state of ValueProvider changes, it will notify the Listener to rebuild the Widget, which happens in the build function.
Are all the above correct? Reading the source code is a bit difficult for me 😭.

This is correct.
In a way, the fact that your original snippet "works" is more of a coincidence.


cargo sometimes complains about placeholder Cargo.toml name = "{package_name}"

But usually it doesn't.
Step 1: repro consistently.
Step 2: fix.

One possible fix: change the Cargo.toml to some placeholder like .Cargo.toml or Cargo.toml_ and then, when copying templates over, find-and-replace to the proper name.

0c43430


[AIRFLOW-81] Add ScheduleBlackoutSensor

Make sure you have checked all steps below.
Jira

[x] My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"

https://issues.apache.org/jira/browse/AIRFLOW-81
In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.

Description

[x] Here are some details about my PR, including screenshots of any UI changes:
After reviewing some of the older jira issues, I found one that could be simply solved via a sensorOperator as Chris suggested in the comments. This operator and test should be good enough to close out an ancient issue that hasn't gotten a lot of traction

Tests

[x] My PR adds the following unit tests OR does not need testing for this extremely good reason:

Adds three test which validate the functionality of sensor properly returning true, false and error handling.
Commits

[x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters (not including Jira issue reference)
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

Documentation

[x] In case of new functionality, my PR adds documentation that describes how to use it.

When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.

Code Quality

[x] Passes git diff upstream/master -u -- "*.py" | flake8 --diff

@andscoop In your PRs, please replace AIRFLOW-XXX with the actual Jira issue this PR addresses, which is AIRFLOW-81 in this case. This way, we can link a PR to a JIRA. Pls update your other Jiras accordingly.

@criccomini What do you think of this? There is definitely a need for this type of functionality (e.g. scheduled maintenance windows). Is a sensor the way to go? Won't we be blocking celery workers?
CC @bolkedebruin @Fokko

Codecov Report

Merging #3702 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3702   +/-   ##
=======================================
  Coverage   77.56%   77.56%
=======================================
  Files         204      204
  Lines       15766    15766
=======================================
  Hits        12229    12229
  Misses       3537     3537

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3157287...8d2e1e1. Read the comment docs.

I must say that it would be nice if there will be a way that the "blackout" won't be Airflow wide.. For example if it would be possible to exclude specific pools that will continue to be scheduled.

The blackout should be on dag level. For example block the execution for the interval.
I fully agree with @bolkedebruin that we should use a smarter way of defining our periods. As Bolke is mentioning, Airflow is using Pendulum under the hood, and it would be nice to leverage the Period: https://pendulum.eustace.io/docs/#period
What do you think @andscoop?

@Fokko I think that is the correct way to solve this issue - with the trade off that it will involve

@Fokko I think that is the more complete solution in this case, it will just involve more thought around start_date and end_date and how they interact with the new "periods" feature described above. While potentially not significant, this new feature will likely add more logic to the scheduler loop and that trade-off needs to be considered.
With the maintainers' blessing, I can take this one and move forward with the feature as discussed.

@andscoop Why would this make it more complex?


Update MyGet badge

Changed MyGet badge to more useful and better looking NuGet one by shields.io

Old:
New:


Plotting broken for any /home/x temp path

Any temp path that isn't the default form of /mnt/x will completely break the path handling and result in 'Only read x of y bytes at offset z. Error 1' as soon as the third table begins plotting, resulting in bizarre directories like /home/<username>/~/<temp directory name>. This seems to mean that you can only use absolute paths which are not in a user's home directory as paths which are in a user's home directory will instead by used as relative paths to the current working directory.

I'm not sure I follow.  If you're saying that only absolute paths, not
relative, or ~ initiated paths, work, then I'm not surprised, but also
not sure we want to go there since it seems it might be hard to get it
working properly across all paths.
but it sounds like you're saying something more?
On Mon, May 3, 2021 at 9:32 AM Patrick Beart @.***>
wrote:

Any temp path that isn't the default form of /mnt/x will completely break
the path handling and result in 'Only read x of y bytes at offset z. Error
1' as soon as the third table begins plotting, resulting in bizarre
directories like /home//~/. This seems to
mean that you can only use absolute paths which are not in a user's home
directory as paths which are in a user's home directory will instead by
used as relative paths to the current working directory.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/ericaltendorf/plotman/issues/222, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARPZIFTWENA35AYUJSFGILTTL3FYJANCNFSM44BDVQ7A
.


3.1.1 generates migrations even flag SIMPLE_HISTORY_DATE_INDEX has false value

I am trying to upgrade a project to 3.1.1 and I have set SIMPLE_HISTORY_DATE_INDEX=False. Idealy it should not generate any new migration but it is making few. Although migration does not have any index change but lots of ordering changes.
To Reproduce
Steps to reproduce the behavior:

Install 3.1.1.
set SIMPLE_HISTORY_DATE_INDEX=False
Run make migrations.

Expected behavior
It should not generate any new migration.
Actual behavior
It generates a migration. Although there is no index change but it is adding many changes in lots of tables.
 migrations.AlterModelOptions(
            name='historicalcourse',
            options={'get_latest_by': ('history_date', 'history_id'), 'ordering': ('-history_date', '-history_id'), 'verbose_name': 'historical course', 'verbose_name_plural': 'historical courses'},
        ),

Those model option changes in your migrations are unfortunately unavoidable, as there have not been implemented any settings to disable them. The SIMPLE_HISTORY_DATE_INDEX setting is unrelated, and instead controls how the history_date field is indexed.
Closing, as potentially requesting implementing settings to disable the mentioned model options, seems out of scope for this issue. Please reopen if you disagree 🙂


Remote Error while SSH

Trying to ssh on unix server bash
Logs:
[19:45:57.997] Log Level: 2
[19:45:58.015]<EMAIL_ADDRESS>[19:45:58.015] win32 x64
[19:45:58.019] SSH Resolver called for "ssh-remote+ilhp040", attempt 1
[19:45:58.020] SSH Resolver called for host: ilhp040
[19:45:58.020] Setting up SSH remote "ilhp040"
[19:45:58.121] Using commit id "cd9ea6488829f560dc949a8b2fb789f3cdc05f5d" and quality "stable" for server
[19:45:58.126] Install and start server if needed
[19:46:00.109] Checking ssh with "ssh -V"
[19:46:00.505] > OpenSSH_for_Windows_8.0p1, LibreSSL 2.6.5
[19:46:00.510] Using SSH config file "C:\Users\aadeshr.ssh\config"
[19:46:00.510] Running script with connection command: ssh -T -D 3924 -F "C:\Users\aadeshr.ssh\config" ilhp040 bash
[19:46:00.523] Terminal shell path: C:\WINDOWS\System32\cmd.exe
[19:46:01.141] >
[19:46:01.142] Got some output, clearing connection timeout
[19:46:03.574] > Password:
[19:46:24.678] >

[19:46:25.949] > P4USER  : aadeshr

P4CLIENT: aadeshr_ilhp040_825-Dev
Login to P4...
[19:46:26.106] > Login to P4...   User aadeshr logged in.

[19:46:26.407] > bash: Command not found.

[19:46:26.766] "install" terminal command done
[19:46:26.767] Install terminal quit with output: bash: Command not found.
[19:46:26.767] Received install output: bash: Command not found.
[19:46:26.770] Resolver error: bash not found
[19:46:26.781] ------

Does the remote have bash available and on the PATH?


avoid warnings

as per title

Codecov Report

Merging #137 (08557f4) into master (14733fe) will increase coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #137      +/-   ##
==========================================
+ Coverage   35.48%   35.52%   +0.04%
==========================================
  Files         120       24      -96
  Lines       11230     2246    -8984
  Branches     7240     1448    -5792
==========================================
- Hits         3985      798    -3187
+ Misses        660      132     -528
+ Partials     6585     1316    -5269

Flag
Coverage Δ

unittests
35.52% <ø> (+0.04%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...include/joint_trajectory_controller/tolerances.hpp

...s/test/test_load_joint_group_effort_controller.cpp

...test/test_load_joint_group_position_controller.cpp

...int_trajectory_controller/test/test_trajectory.cpp

...mand_controller/src/forward_command_controller.cpp

...ory_controller/src/joint_trajectory_controller.cpp

...nt_state_controller/src/joint_state_controller.cpp

...test/test_load_joint_group_velocity_controller.cpp

...mand_controller/src/forward_command_controller.cpp

...int_trajectory_controller/test/test_trajectory.cpp

... and 134 more

Codecov Report

Merging #137 (08557f4) into master (14733fe) will increase coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #137      +/-   ##
==========================================
+ Coverage   35.48%   35.52%   +0.04%
==========================================
  Files         120       24      -96
  Lines       11230     2246    -8984
  Branches     7240     1448    -5792
==========================================
- Hits         3985      798    -3187
+ Misses        660      132     -528
+ Partials     6585     1316    -5269

Flag
Coverage Δ

unittests
35.52% <ø> (+0.04%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...include/joint_trajectory_controller/tolerances.hpp

...s/test/test_load_joint_group_effort_controller.cpp

...test/test_load_joint_group_position_controller.cpp

...int_trajectory_controller/test/test_trajectory.cpp

...mand_controller/src/forward_command_controller.cpp

...ory_controller/src/joint_trajectory_controller.cpp

...nt_state_controller/src/joint_state_controller.cpp

...test/test_load_joint_group_velocity_controller.cpp

...mand_controller/src/forward_command_controller.cpp

...int_trajectory_controller/test/test_trajectory.cpp

... and 134 more


[Release] Stage to Main

https://github.com/adobecom/milo/pull/2411
https://github.com/adobecom/milo/pull/2451
https://github.com/adobecom/milo/pull/2436
https://github.com/adobecom/milo/pull/2444
https://github.com/adobecom/milo/pull/2431
https://github.com/adobecom/milo/pull/2427
https://github.com/adobecom/milo/pull/2421
https://github.com/adobecom/milo/pull/2376
https://github.com/adobecom/milo/pull/2375
https://github.com/adobecom/milo/pull/2416

common base root URLs
Homepage : https://www.stage.adobe.com/
BACOM: https://business.stage.adobe.com/fr/
CC: https://www.stage.adobe.com/creativecloud.html
Blog: https://blog.stage.adobe.com/
Acrobat: https://www.stage.adobe.com/acrobat/online/sign-pdf.html
Milo:

Before: https://main--milo--adobecom.hlx.live/?martech=off
After: https://stage--milo--adobecom.hlx.live/?martech=off

Testing can start @adobecom/miq-sot @adobecom/bacom-sot @adobecom/homepage-sot @adobecom/creative-cloud-sot @adobecom/document-cloud-sot

Skipped merging 55: "fooPR" due to failing checks

Skipped merging 55: "fooPR" due to failing chec2ks

Skipped merging 55: "fooPR" due to failing chec2ks

Skipped merging 55: "fooPR" due to failing checks


Use more restrictive IAM policy

Objective
Use more restrictive IAM policy
Why
Help AWS users to audit and adjust IAM permissions to enable features.
For instance, it will be easier for users who don't collect log information (collect-logs-size=false) to remove unnecessary IAM permissions.
Today, we don't specify parameters to collect AWS RDS maintenances, so we can't limit resource for rds:DescribePendingMaintenanceActions action, but we may support in the future.
How

Update IAM policies
Fix typo in README

Release plan

[ ] Merge this PR

I created https://github.com/qonto/prometheus-rds-exporter/issues/96 to fix the issue with rds:DescribePendingMaintenanceActions IAM permission

#sre

For Qonto's review: The policy is successfully deployed in our different AWS accounts.

#sre


Ignore flake8 B023 rule

After the last pre-commit update which updated flake8, rule B023 has been raising false positives. We can ignore that rule till there  is an upstream fix for it.
Environment:

Python version: Any
Preprocessy version: Any
Jupyter Notebook or Python Script: Both

Fixed with #164


[travis] switch cc1352 build to cmake

@FiveDimensions, this PR is showing a lot of commits from master. Can you rebase this PR?


Add classNames.icon option

What has been done ✅:
I added an icon property to the classNames toast option. This allows users to style the <div data-icon=""> element using tailwind. This would be very useful to give the icon common styles like width/height:
<Toaster
  toastOptions={{
    unstyled: true,
    classNames: {
      icon: "size-6"
    },
  }}
/>

Currently, I have to add the size-6 classname to each icon in my icons override:
<Toaster
  icons={{
    error: <ExclamationCircleIcon className="size-6" />,
    warning: <ExclamationTriangleIcon className="size-6" />,
    info: <InformationCircleIcon className="size-6" />,
    success: <CheckCircleIcon className="size-6" />,
  }}
/>

It looks like this is a duplicate of #372. I think this one can be closed since that one has already been merged.


Make this module compatible with Streams2/3

I don't think it is very difficult changing through's dependency by through2's...but maybe I'm wrong

Substack has 534 modules so he's busy. The code is MIT-licensed though so you're welcome to fork and improve if you "don't think it's very difficult". :)

Yes, I know. But I only wanted to know if Substack planned to "officially" maintain this module or not.

fwiw, having had the same issue, I found that http://highlandjs.org has a better maintained emit-stream implementation.


riscv/common/espressif: Fix spi slave driver

Summary
In the current version, the ESP32-C6 does not behave correctly when sending data while operating in SPI Slave mode. This commit addresses the issue by ensuring proper data transmission. Additionally, Espressif's SPI controller uses a single buffer functioning as both TX and RX, which differs from other MCU manufacturers such as ST and Silicon Labs, as discussed and illustrated in the images below. With this commit, the SPI Slave behavior is expected to be appropriate on Espressif's RISC-V devices.
Impact
This change affects the operation of SPI Slave mode on Espressif's ESP32-C6 devices. Users utilizing SPI Slave configurations will be able to send data consistently and as expected, aligning with the behavior of SPI controllers from other MCU manufacturers. This improvement enhances interoperability and reliability of SPI communications in projects relying on these devices. Furthermore, the unified TX/RX buffer simplifies maintenance and ensures compatibility with future firmware and hardware updates.
For more details about compatibility, please take a look on https://github.com/apache/nuttx/issues/13855
You will see that the Espressif SPI controller has only one buffer to TX and RX data, so is necessary driver clear buffer if it have no data to be sent.
Below you can see behavior from stm32f4 mcu:

And below you can see behavior from esp32gg12 mcu:

Testing
To verify the effectiveness of this change, the spislv configuration available for the esp32c6-devkitm and esp32c6-devkitc kits was used. The tests involved sending data via SPI and observing that the master only receives the data being sent by the slave. The following environments and tools were utilized during testing:
Build Host: [Specify the operating system, CPU, compiler, etc.]
Verification Target: Espressif's RISC-V devices, specifically the esp32c6-devkitm and esp32c6-devkitc kits.
Testing Procedure:
    Configure the mentioned kits in SPI Slave mode using the spislv configuration.
    Send a sequence of data via SPI from the master.
    Verify on the master that only the data sent by the slave is received correctly.
Results: After the commit, the data sent by the slave was correctly received by the master as expected, without inconsistencies or data loss.

Build and runtime logs before and after the change were analyzed to ensure that the SPI Slave behavior meets the expected outcomes.
Se results below:

Below I fixed only 2 bytes as answer:

Now only two bytes are send.

[Experimental Bot, please feedback here]
Fill In The Commit Message: This PR contains a Commit with an Empty Commit Message. Please fill in the Commit Message with the PR Summary.
This PR summary mostly meets the NuttX requirements but is missing some crucial details. Here's a breakdown and suggestions for improvement:
Strengths:

Clear Problem Description: The summary clearly explains the issue with ESP32-C6 SPI Slave mode.
Solution Explanation: It describes how the commit addresses the problem.
Visual Aids: The images effectively illustrate the difference in SPI buffer behavior.
Testing Explanation:  It outlines the testing procedure and provides visual confirmation of the fix.

Weaknesses:

Missing Issue References:  While it mentions an issue number, it needs a proper link to the NuttX issue tracker.
Incomplete Impact Assessment: The impact section lacks specifics.  It mentions user impact and improved interoperability, but doesn't detail how users might need to adapt (if at all) or what the compatibility implications are.  The "anything else to consider" is also left blank.
Insufficient Testing Details: While test results are shown, critical details are missing from the "Testing" section:

Build Host Details: The OS, CPU architecture, and compiler used for building are not specified.
Before/After Logs:  Actual log output is missing.  Screenshots are helpful, but full logs are essential for thorough review.  The screenshots are also difficult to interpret without context.  Explain what is being shown.
Specific Test Cases: Describe the exact data sent and received.

Recommendations for Improvement:

Add Issue Link: Include a direct link to the related NuttX issue (e.g., https://github.com/apache/nuttx/issues/13855).

Elaborate on Impact:

User Impact: If there's no user impact, state "NO" explicitly.  If there is an impact, explain what users need to do differently.  For example, do they need to change configuration settings?
Build Impact: Specify "NO" or detail any changes to the build process.
Hardware Impact:  Clearly state which architectures/boards/drivers are affected.  You mention ESP32-C6, but be explicit.
Documentation Impact:  If documentation needs updating, either state that an update is provided in the PR or explain what documentation needs to be changed.
Security Impact:  Explicitly state "NO" if there's no security impact.
Compatibility Impact: While you link to an issue, summarize the key compatibility aspects in the PR itself. Explain backward/forward compatibility in detail.
Anything Else:  If there's truly nothing else to consider, state "None."

Improve Testing Details:

Build Host: Provide complete details (OS, CPU, compiler version).  Example: Build Host: Linux (Ubuntu 22.04), x86_64, GCC 11.2.0
Target: Be specific. Example: Target: esp32c6-devkitm (sim), esp32c6-devkitc (hardware)
Logs: Replace the screenshots with text-based logs showing the SPI communication before and after the change. Explain what each part of the log represents.
Test Data:  Provide the exact data sequence sent by the master and the expected/received data from the slave.  For example:  "Master sent: 0x12 0x34 0x56. Slave responded (before): 0x00 0x00 0x00 0x00. Slave responded (after): 0x12 0x34."

By addressing these points, the PR will be much clearer, easier to review, and more likely to be accepted.

Please @eren-terzioglu and @tmedicci, take a look.

Hi @FelipeMdeO , thanks for submitting! I have some questions:

Why the master device receives (in the first transmission) 09 0a 0b 0c? Is this expected?
What would happen if you write more bytes in the slave's transmit buffer than the number of bytes to be received? For instance, suppose you write 01 02 03 04 05 06 and the master device sends 4 bytes. I'd expect that the answer would be 01 02 03 04 as the response and 05 06 to be transmitted in the next exchange. Is that true?

Hi @FelipeMdeO , thanks for submitting! I have some questions:
1. Why the master device receives (in the first transmission) `09 0a 0b 0c`? Is this expected?

2. What would happen if you write more bytes in the slave's transmit buffer than the number of bytes to be received? For instance, suppose you write `01 02 03 04 05 06` and the master device sends 4 bytes. I'd expect that the answer would be `01 02 03 04` as the response and `05 06` to be transmitted in the next exchange. Is that true?

Hello @tmedicci , sorry, I generate images without "reload" master app, so screen have information from old test. Data in top of second image is related bottom of  first image. Also, I change spi slave example to send always a know data, see PR https://github.com/apache/nuttx-apps/pull/2819 ( I will fix PR issues as soon as possible ).
I changed spislv example (I think will be better change this example to receive data to send as parameter ;] ) to always queue 8 bytes, look results :

I updated the example to allow user choose data to send:
https://github.com/apache/nuttx-apps/pull/2820


[WIP] Port integration tests to remill semantics branch

Port integration tests to remill semantics branch

Referring this over to Issue #280 and closing this issue.


Clone InitialHouseMeasure when cloning Scenario

When cloning Scenario, InitialHouseMeasure should now be cloned.
Same for destroying a scenario.

When cloning a scenario, the following steps are now taken:
1. Clone scenario with new name. scenarioparametersId and gameversionId stay the same.
2. For the scenario, clone the questions, using the new scenarioId.
   3. For each question, clone the questionitems, using the new questionId.
4. For the scenario, clone the welfaretypes, using the new scenarioId.
5. For the scenario, clone the newsitems using the new scenarioId.
   6. For each newsitem, clone the newseffects using the new newsitemId; link to the old communityId.
7. For the scenario, clone the measurecategories using the new scenarioId.
   8. For each measurecategory, clone the measuretypes using the new measurecategoryId.
      9. For each measuretype, clone the initialhousemeasures using the new measuretypeId
         (and the same houseId).

When deleting a scenario, the following steps are taken:
1. Check whether the scenario has an associated group; if yes, throw exception.
2. For the scenario, for each newsitem
   3. For the newsitem, for each newseffects:
      - delete the newseffects
   - delete the newsitem
4. For the scenario, for each question:
   5. For the question, for each questionitem:
      - delete the questionitem
   - delete the question
6. For the scenario, for each welfaretype:
   - delete the welfaretype
7. For the scenario, for each measurecategory:
   8. For the measurecategory, for each measuretype:
      9. For the measuretype, for each initialhousescenario:
         - delete the initialhousescenario
      - delete the measuretype
   - delete the measurecategory
- delete the scenario

Tested cloning and destroying, and both worked correctly.


Issue with Make

Hello, I have the following problems when I make：
OS: Ubuntu 18.04.4 LTS
GCC/G++ version: 6.5
CMAKE version: 3.10.2
CUDA version: 9.0
aim@aim:~/YX/GPU_BTREE/GpuBtree-test/build$ make
[ 25%] Built target test_search
[ 50%] Built target test_map
[ 75%] Built target gtest
[ 87%] Building NVCC (Device) object unittests/CMakeFiles/btree_map_test.dir/btree_map_test_generated_btree_map_test.cu.o
/home/aim/YX/GPU_BTREE/GpuBtree-test/build/googletest-src/googletest/include/gtest/internal/gtest-internal.h(1214): error: no instance of function template "testing::irnal::IndexSequence<I...>>::Apply [with I=<0UL>]" matches the argument list
argument types are: (__nv_bool ()(), __nv_bool ()())
detected during:
instantiation of class "testing::internal::ElemFromList<N, T...> [with N=1UL, T=<__nv_bool, __nv_bool>]"
(1228): here
instantiation of class "testing::internal::FlatTupleElemBase<testing::internal::FlatTuple<T...>, I> [with T=<__nv_bool, __nv_bool>, I=1UL]"
(1241): here
instantiation of class "testing::internal::FlatTupleBase<testing::internal::FlatTuple<T...>, testing::internal::IndexSequence<Idx...>> [with Idx=<0UL, 1UL>
(1281): here
instantiation of class "testing::internal::FlatTuple<T...> [with T=<__nv_bool, __nv_bool>]"
/home/aim/YX/GPU_BTREE/GpuBtree-test/build/googletest-src/googletest/include/gtest/internal/gtest-param-util.h(807): here
instantiation of class "testing::internal::ValueArray<Ts...> [with Ts=<__nv_bool, __nv_bool>]"
/home/aim/YX/GPU_BTREE/GpuBtree-test/build/googletest-src/googletest/include/gtest/gtest-param-test.h(360): here
1 error detected in the compilation of "/tmp/tmpxft_000005be_00000000-6_btree_map_test.cpp1.ii".
CMake Error at btree_map_test_generated_btree_map_test.cu.o.cmake:279 (message):
Error generating file
/home/aim/YX/GPU_BTREE/GpuBtree-test/build/unittests/CMakeFiles/btree_map_test.dir//./btree_map_test_generated_btree_map_test.cu.o
unittests/CMakeFiles/btree_map_test.dir/build.make:425: recipe for target 'unittests/CMakeFiles/btree_map_test.dir/btree_map_test_generated_btree_map_test.cu.o' failed
make[2]: *** [unittests/CMakeFiles/btree_map_test.dir/btree_map_test_generated_btree_map_test.cu.o] Error 1
CMakeFiles/Makefile2:368: recipe for target 'unittests/CMakeFiles/btree_map_test.dir/all' failed
make[1]: *** [unittests/CMakeFiles/btree_map_test.dir/all] Error 2
Makefile:140: recipe for target 'all' failed
make: *** [all] Error 2

Hi @LYXDF, I looked up the error message and it seems like you need to upgrade GCC. Could you try to upgrade to GCC 7 or higher? CUDA 9.0 should be enough to compile the code.
Let me know if you are still getting compilation errors.

Hi @LYXDF, I looked up the error message and it seems like you need to upgrade GCC. Could you try to upgrade to GCC 7 or higher? CUDA 9.0 should be enough to compile the code.
Let me know if you are still getting compilation errors.

I tried gcc4.8/gcc5/gcc6/gcc7 respectively, and they were the same mistakes.Finally, I changed cuda9 to cuda10, and then it could run. So I guess it's the CUDA version of the problem. The same kind of error is discussed in this website.
https://github.com/FLAMEGPU/FLAMEGPU2_dev/issues/299


Create GPIOPin Component

Would this include analogue input functionality (only present on a subset of GPIO pins), or would that be a separate component?


Problem keyboard

Steps to Reproduce

...
...
...

Target Platform:
Target OS version/browser:
Devices:
Logs

When i open the keyboard in app, my custom bottom bar is hide with this..

I would like add that i have already test with the package keyboard_action but its not the solution because the package add a navbar with the color grey and i don't want this

Hi @iso57
I'm not sure to understand the issue
can you please provide your updated  flutter doctor -v
and a minimal code sample
or the steps to reproduce the problem.
Thank you


A typo on website

there is a message says

You've successfully installed Depedabot on ...

missing an n letter

Well that's embarrassing! Fix deploying now - thanks!


Update static portion of the container URLs in CI

Part of #815

We should have way to parametrize the SLE Micro version so we do not need to do all this changes every time we bump the underlaying OS, however I leave it for a separate issue.


Filter list of results in apply enum to only display options that match selected constant

When analyzing Windows binaries in particular, it is often indispensable to rename certain numeric constants to an appropriate preprocessor macro / enum name. In Ghidra, this can be realized by using the Apply Enum operation on the numeric constant. However, the list of suggested definitions is not limited to those that match the selected constant, making it near impossible in certain cases to find the correct name unless the analyst is able to discern the name by a separate lookup elsewhere. The case of Windows' ERROR_ constants is a good example:

I think it would be great improvement to display only enums in the Apply Enum dialog that actually contain an entry matching the selected constant, improving the usability of this very vital feature by magnitudes.

For everyone who is similarly new to Ghidra as myself, I will comment briefly about what I just realized: The "Set Equate" action can be used to do something very similar to what I am requesting and might be what you are looking for. I will leave this issue open anyway because I think it would still be an enhancement to the "Apply Enum" feature to filter out impossible options.

We have decided not to change the feature at this time.  Admittedly, it is a bit awkward to use in its current form.   For 9.1, the Apply Enum action will only be enabled over a selections, which we hope will entice uses to use the Set Equate instead for single equate assignments.

Makes sense. As stated in my second comment, I figured out the "Set Equate" a bit too late, but it is probably the better choice in many cases. Thanks for having a look!


Improve type hinting by using overloads

Proposed changes
Ran into some issues regarding type hinting. To solve this, added some overloading to help with type hinting! This should not be a breaking change.
Types of changes
What types of changes does your code introduce to Appium?
Put an x in the boxes that apply

[x] Bugfix (non-breaking change which fixes an issue), not necessarily a bug though, but more like convenience issue..
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Minor Update (if none of the other choices apply)

Checklist

[x] I have read the CONTRIBUTING doc
[x] I have added tests that prove my fix is effective or that my feature works (not needed, 100% pass)
[x] I have run pre-commit and unit tests and all pass locally with my changes

Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Thank you, if you find more stuff to fix please do. I am not a big fan of mypy tediousness and that is why it's not in pre-commit, in particular if you run mypy you will see more errors related to types and overloads. Feel free to push more fixes for that so I can add mypy to pre-commit and ensure full compatibility in the future.


network-policy-provider: updating cilium documentation for v1.4.0

Signed-off-by: André Martins<EMAIL_ADDRESS>

I checked the updates on : https://deploy-preview-12627--kubernetes-io-master-staging.netlify.com/docs/setup/independent/create-cluster-kubeadm/
and
https://deploy-preview-12627--kubernetes-io-master-staging.netlify.com/docs/tasks/administer-cluster/network-policy-provider/cilium-network-policy/
I checked the updated content against the official document: https://docs.cilium.io/en/stable/kubernetes/
The updates look good to me.

/assign @Bradamant3

@Bradamant3 could you please take a look and state your approval on this.

thanks for the update @aanm
added a couple of minor comments.

@neolit123 Thank you for the review! I have made the required changes.

@neolit123 I'm a Cilium core contributor. Is there is anyway of which I can add myself as the maintainer of that file?

@aanm
for approval only SIG docs can approve.
in terms of reviewers on top of the file there should be a list of people and i think you can add yourself there.

@aanm
for PR approval only SIG docs can approve.
in terms of reviewers on top of the file there should be a list of people and i think you can add yourself there.

:smile: It turns out I am already there

/approve


Facebook.com

Type of issue
Code doesn't work
Description
[Escriba sus comentarios aquí]
Stanleybermudez
Page URL
https://learn.microsoft.com/es-es/dotnet/api/azure.resourcemanager.appcontainers.models.containerappfacebookconfiguration?view=azure-dotnet&wt.mc_id=searchAPI_azureportal_inproduct_rmskilling&sessionId=331513383642497ba870d8244450bed3
Content source URL
https://github.com/Azure/azure-docs-sdk-dotnet/blob/master/xml/Azure.ResourceManager.AppContainers.Models/ContainerAppFacebookConfiguration.xml
Document Version Independent Id
30f1868d-4778-3ac6-6235-1c77f6db1176
Article author
@azure-sdk
Metadata

ID: a8dd8014-bcae-5099-fcfc-7a8cd1864789
Service: azure

I'm unclear as to whether this was a legitimate attempt to report an issue or spam.   Because there is no actionable context here, the linked resource has no code that would meet the classification of "Code doesn't work", and there were duplicates of this exact same text opened, I'm going to close this as spam.
Apologies if I've misunderstood.   If this is an attempt to report a legitimate problem, please open a new issue and provide context for the end-to-end scenario.


Order preserving scrolling and sorting

In scan helper, it is not clear what is the "preserved order" that is maintained if preserve_order is set to True. Can you elaborate on the matter? Is it equivalent to run a scrolling without set the the type to scan?
Furthermore, for the sort parameter of scroll to have an effect I guess the preserve_order must be set to True. Is it correct?

Both your assumptions are correct. If you can think of how to make the documentation clearer I would be happy to hear it. Thanks!

Maybe something along these lines maybe?

Remark on order: Note that by default scan does not return results in any pre-determined order. In order to have an order in the returned documents, when scrolling, the scan type has to be disabled; to that end use preserve_order=True and pass a value to the sort parameter.

I will add it there, with the appropriate warning - it can really eat a lot of resources if you decide to do this. Which is exactly counter to the spirit of scan.
Thanks for the question and the suggestion!

Added in 756298a36021ef24529115f01df6e8a4bce1567a


TLS connections (#2)

tls connection with user cert
stop script, redis state script
configurable certificate paths, readme changes, renaming to Hnodes
master crawler modification
cert issue command for openssl

UtACK.  Thanks!


Fix theme name in a sample config file

Fix theme name in a sample config file

Thanks! I always get those two confused...


PowerShell Gallery version not up to date

When will the PowerShell Gallery be updated with the latest?

Who pushes this? @dlwyatt ? @smurawski ?

Looks like Steve set it up, and he's the only owner listed at the moment:  http://www.powershellgallery.com/packages/cChoco/

@smurawski if you can share the key I'll look to setup an appveyor ci process to push up the version when new changes are merged in
Sound like a good plan?

@lawrencegripper what's your username for powershellgallery?  I'll add you as a maintainer.

lawrencegripper, same as here, should do the trick

@lawrencegripper Added to powershellgallery, you should have a notification from there - and after that, release at will

Thanks just setting up the CI build now to validate the DSC resources and push up to powershell gallery. @smurawski to setup the webhook so it kicks off after merging PRs/Changes I need to access the repo settings. Can you alter the permissions or add in the webhook for me?
I've emailed you the web hook, so go for whichever is easier.

@lawrencegripper I made you an admin on the repo, so let me know if that works for you.

Thanks that's perfect, have added the hook so now push should trigger quick test of the resource using xDSCResourceDesigner and publishing to PSGallery


Support for touch?

Is support for touch events in mobiles planned?
L.

Are there any plans to update it to include touch?


Introduce Resource Validator [API-level validation]

Introduce Resource Validator [API-level validation]
Motivation [related to #358]
Current validation of entities approach is very limited and hidden. It allows us to pretty much check only entity properties for validity.
The intent of this change is to expand on the term "validate" and allow making API-level validation, or in other words to validate whether specific POST/PATCH/DELETE requests are valid.
This way we can make custom validation checks prior to actually executing the POST/PATCH/DELETE operation.
Examples of such use cases are:

Platform entities should not be deleted if Service Instance entities exist
Broker entities should not be deleted if Service Instance entities associated with one of the broker's catalog exist
Broker's catalog should not allow removal of one of its Service Plan entities if Service Instance entities associated with this service plan exist

Approach
A new interface ResourceValidator is introduced. Every base controller will have one.
type ResourceValidator interface {
	ValidateCreate(ctx context.Context, repository storage.Repository, object types.Object) error
	ValidateUpdate(ctx context.Context, repository storage.Repository, object types.Object) error
	ValidateDelete(ctx context.Context, repository storage.Repository, object types.Object) error
}

The idea is that just before passing the current object for Creation/Update/Deletion to a controller's repository to execute the request, the corresponding ValidateCreate, ValidateUpdate and ValidateDelete will be called.
There is a DefaultResourceValidator for controllers which don't require custom validation logic.
If someone wants to create a custom API validator for some resource, he only has to implement ResourceValidator and provide that implementation to the specific API controller.
Use case example
Broker's catalog should not allow removal of one of its Service Plan entities if Service Instance entities associated with this service plan exist. This means we need to introduce a BrokerValidator and define it's ValidateUpdate method to check what's needed.
Here's an example error message if the validation fails:
{
  "error": "ExistingReferenceEntity",
  "description": "Error executing ServiceBroker request: Could not delete ServicePlan due to one or more existing ServiceInstance reference entities with ID(s): [57bd8c39-d736-4089-aa5c-8a28e0f5d749,e3f8db5b-4425-4a4c-8bc5-95825f785d26,095d0237-ad89-4ef5-8f15-c09216bb52c9]"
}

Pros/Cons of such an API-level validation approach
Pros:

Can have custom validation logic for each API type
Gives access to violation IDs (in cases such as foreign key violation constraints, eg. deleting a Platform with Service Instances)
Save valuable time troubleshooting

Cons:

Possible race conditions - validation DB calls are not in the same transaction as the requested CUD operation. [we should think of a way to move this API-level validation a little further down (eg. somewhere right after the start of the interceptor chain) - this way we can ensure that no race conditions will occur]. If we cannot mitigate this - we can at least combine this approach with #358 and in this way when a race condition does occur, the client will receive 400 Bad request with both entity and violation entity - they just won't have the violation IDs in the response message.
Extra DB calls (unavoidable, requiring to do custom validation pretty much guarantees that this will happen)
Will have to call Validate method manually in certain places

Note
This change allows us to remove the hidden Validate() invocation from the BytesToObject() implementation. If this new validation approach is adopted, the other repos need to be updated.
Pull Request status

[x] Initial implementation
[x] Integration tests

Coverage decreased (-0.6%) to 87.863% when pulling d676e8fcd075cdfb26b719706fd071f38ea0bb89 on api-validator into b6a3b7004a04a8bf0c46dacb61cfe9c9b15347e9 on master.

Closing this as team decided the feature is not yet needed.


Type system is loaded multiple times in tests

In Jest, every single test file gets its own context. The implication of that for deCDK tests is that the jsii type system is loaded multiple times. As we add more assemblies (e.g, for the alpha modules), the total running time becomes unworkable.

Hmm. I thought that's why we cache it here 🤔
https://github.com/cdklabs/decdk/blob/main/test/util.ts#L15-L21
Did you observe the caching not working as expected?

Did you observe the caching not working as expected?

Yes. The cache works within the same test file. But each test file has its own context, so it starts from a clean slate. In particular, from _cachedTS == undefined.


Lifecicle Event not Triggered on Navigating Back

Ionic:
ionic (Ionic CLI)             : 4.9.0 (/usr/local/lib/node_modules/ionic)
Ionic Framework               : @ionic/angular 4.0.1
@angular-devkit/build-angular : 0.13.8
@angular-devkit/schematics    : 7.2.4
@angular/cli                  : 7.2.4
@ionic/angular-toolkit        : 1.3.0
Cordova:
cordova (Cordova CLI) : 8.1.2<EMAIL_ADDRESS>Cordova Platforms     : browser 5.0.4
Cordova Plugins       : cordova-plugin-ionic-keyboard 2.1.3, cordova-plugin-ionic-webview 3.1.2, (and 10 other plugins)
System:
NodeJS : v10.15.3 (/usr/bin/node)
npm    : 6.9.0
OS     : Linux 4.15
As you can see I have very fresh Ionic version 4.
I have a standard Tab App.
Also I have created a separate Page  . Inisde that page I have a function
goBack(){
  this.navCtrl.navigateForward('/tabs/tab2');

}

But when I do it like this , the function
ionViewDidEnter()    does not work. It fires only once.

Hi there,
Thanks for the issue. Can you provide a repository with the code required to reproduce this issue?
Thanks!

It's a known bug which is just popping over and over since a year. For example #16834
When you will  take time to understand what is the problem  and fix it ??? You don't need a  repo code. Just generate a standard tabbed app.  put in there the  ionViewDidEnter()  function. Then generate a page out of tab with ionic generate page. From there make a function which  makes
this.navCtrl.navigateForward('/tabs/tab2');  In the case where you fo to Tab2 from other tabs the  ionViewDidEnter will work, in case you go back from other pages it will not.

also #8958 the same issue

Hi there,
Thanks for the follow up. I am going to close this since this is a duplicate of #16834 like you mentioned. Please follow that thread for updates. We appreciate your patience as we work to resolve this issue.
Thanks!

yes, but seems you just abandoned the tickets I mentioned. When you can give a fix for this?

Hi there,
We have not abandoned it, and we are going to prioritize it appropriately. Additionally, we don't usually give estimates on issue resolution.
Thanks!


Polyfill prototype.at

In my case, I using uFuzzy in React Native (Android)
When we search the long char, we got errors like:
p.at is not a function. (In 'p.at(-1)', 'p.at' is undefined)

I'm not sure this is a good idea to add polyfill something like
if (!String.prototype.at) {
  String.prototype.at = function (n) {
    // ToInteger() abstract op
    n = Math.trunc(n) || 0;
    // Allow negative indexing from the end
    if (n < 0) n += this.length;
    // OOB access is guaranteed to return undefined
    if (n < 0 || n >= this.length) return undefined;
    // Otherwise, this is just normal property access
    return this[n];
  };
}

Any suggestion? thanks.

@leeoniya Are going to change and release this?


feat: add Report an issue screen

It closes #931

@brusherru , I checked this moment, seems like because the info that we're sending from 1 computer and 1 env, is similar to what we are sending again and again. In User Feedback category, we will be having different right now

but unfortunately for event , all User Feedbacks will be grouped

Is there anyway (must be) for this category to be sent as an email notification to a specific email?
We currently handle all "tech support" via Discord and an email address.
We gonna need current "tech support" to be able to get these notifications.
Alternatively, I guess we can give current tech-support access to Sentry and teach them to look for this grouping.
Thoughts / ideas?

@oriya , let me check how can I configure this pipeline so, discord + email or just email will be ok for us?

email should be fine :) and thank you!

Hey @brusherru , the last changes have already been approved by @oriya, so what we have

Client can send unique feedback only once by version ( it is called a fingerprint, it is how the Sentry identifies unique/not unique errors )
Other events and messages grouped into 1  for this client
Added Alert tracker, that finds new events with the specific match by event/message content, and I'm sending it to our support team where they can find any information.

For Other events I will be sending personal once a week or two, because, for duplicate events and messages I cannot define this alert, Sentry doesn't have such an event, on every event update
Cleaned up Sentry issues and grouped it, right now we have only a few issues that need to check, a few of them are Windows, that issue on which u working right now


Remove inline code margin

This PR added this margin, but it messes with the line height of paragraphs across the board that have inline code blocks. I couldn't find where it was originally used. @Scotchester do you remember? Can it be removed?
Removals

Removes margin above inline code blocks.

Testing

npm run build && npm start and view the component pages vs the live site.

Screenshots
Before:

After:

I believe the intent was to make sure that full block code examples had some margin above them, and I probably just didn't consider/notice that it would apply to inline code, as well. Is there a way to scope it to blocks of code only?

We may not need to remove it now that #640 is in. I'll release and update the docs and we can check.

Docs updated, yeah doesn't look like we need to remove this at this time.


verify chart name when perform release update

This change is

This seems to make it illegal to update from one chart to another. This is a breaking change.
By design, Helm lets you do this:
$ helm install -n foo mychartOne
$ helm upgrade foo mychartTwo

This patch seems to make that impossible, which will break a number of existing uses of Helm.

I'm assuming this is related to #2404 . I think the PR #2677 is also trying to implement the same thing. As I said there a few minutes ago, it would be fine with me to provide a flag to turn this feature on (helm upgrade --no-chart-swap or something like that), since I can see how some people would like to ensure that a chart is not replaced by another chart during an upgrade.
But again, the bottom line is that we cannot break backward compatibility. And some of us do intentionally change a release from one chart to another. It's not a feature we can just remove.

close this pr, as #2677 has a better impl :)


Gradle + Gradle plugin update

This upgrade seems to work fine with sample apps. Tests don't work in Android Studio 4.2.2, but they don't work on master branch either.

Checked against tests using gradle wrapper and it seems to work fine 👍


Increase versionCode range

Version code range too small and it gets me an headache. Some build tool make it automatically and use next formula: 2.1.4 goes to 201042 where last digit used for different architectures (as you can see it bigger than 65535).
I have rewrited my app on Godot and have a big problem to increase version that I already have.

Needs to cherry-pick into 3.0

Please make a PR against the master branch then, the cherry-pick workflow is from master to 3.0, we don't cherry-pick from 2.1 usually.


This is both bad practices I believe.

Scoped styles - add specificity to the base styling, making it hard to be overwritten. E.g. .dropdown-item[data-xxx] has specificity of 2.

Element styles - Even if this is scoped, it still inherits project's base styling. E.g. input[data-xxx] inherits project's input styles.

Ideally this project classes should be neutral. Examples like:
.vue-tel-input {}
.vti__iti-flag {}
.vti__selection {}
.vti__dropdown-menu.show {} // Keep this to minimum
.vti__input {}
.vti__ul {}

This way all the styles:

Are scoped to the project name
Does not inherit default input styles
Are easy to overwrite.

@pxwee5 Thanks for your help as always, it's available in v4.0.0.


Support LLVM 4.0 postfixed versions

Debian-based distributions allow you to install multiple versions of LLVM in parallel, allowing you to access them individually using postfixed llvm-config versions (ie llvm-config-3.8 or llvm-config-3.9).
Ubuntu (Xenial) added packages for LLVM 4.0 with -4.0 postfix (under llvm-4.0 package).
Crystal supports and uses 3.9 or 3.8, but no option for 4.0.
This change makes sure LLVM 4.0 is also tried first.
Before this change (with LLVM 4.0 installed):
$ make crystal
Using /usr/bin/llvm-config-3.8 [version=3.8.0]
...

$ bin/crystal --version
Using compiled compiler at `.build/crystal'
Crystal 0.23.0+177 [12ed6df] (2017-09-20)

LLVM: 3.8.0
Default target: x86_64-pc-linux-gnu

After this change (with LLVM 4.0 installed)
$ make crystal
Using /usr/bin/llvm-config-4.0 [version=4.0.0]
...

$ bin/crystal --version
Using compiled compiler at `.build/crystal'
Crystal 0.23.0+177 [12ed6df] (2017-09-20)

LLVM: 4.0.0
Default target: x86_64-pc-linux-gnu

Thank you for the continuous support and work on Crystal and looking forward your comments!
❤ ❤ ❤

@luislavena Thank you! ❤


Fix issue with SIGTERM is not properly handled if INITSYSTEM not enabled.

Connects to https://github.com/resin-io-library/resin-rpi-raspbian/pull/48

I realised we have a much bigger problem here. The behaviour we observe when we use fg instead of wait is actually the default behaviour. For example, the following script will never respond to SIGTERM:
#!/bin/bash

set -m

function signal_handler() {
	echo "signal handler"
}
trap signal_handler SIGTERM
sleep 1000

The problem though is that while we can use wait to be able to respond to signals that arrive to the container, we're currently ignoring any child process that is re-parented to PID 1 (i.e entry.sh) because its parent crashed. This breaks expectations because Docker users expect orphaned processes to be reparented to their own PID 1.
I think it would be a good idea to integrate tini in our images until we upgrade docker on devices to 1.13 which has this feature built-in.

@petrosagg indeed, we need tini in our base images, I will integrate it in our base images when I'm back next week. At the moment, can we merge this PR as a temporary fix?


Remove HasMinimalVulnerabilitiesCheck

Is your feature request related to a problem? Please describe.
We need to remove the code that we have in place to perform the container image vulnerability check (HasMinimalVulnerabilitiesCheck). The current implementation only works for RHEL-8 based images and was disabled.
For container image certification, we are instead going to utilize Clair to scan the images once they have been pushed to a repository on Quay and preflight will no longer include a vulnerability check.
Describe the solution you'd like.
Remove the container vulnerability check functionality.
Additional context.
Further information can be found in #99.

@bcrochet @jomkz Unless I'm missing something, I don't think this is in the code base anymore. There is nothing in the policies here or in the engine here.

I believe that this was fully removed when we migrated to crane engine, closing as there is nothing to do here.


"styles.css not found" error on update

On updating, I got
app.js:1 GET https://github.com/OfficerHalf/obsidian-collapse-all/releases/download/1.2.0/styles.css 404 and then Collapse All: styles.css not found.

Huh interesting. It isn't breaking things though right?

Nope, everything seems to be working as expected, though if there was some weirdness in how it looked I wouldn't necessarily expect to notice, I don't pay a lot of attention to that.

I'm not able to reproduce this. It seems like obsidian is looking for a styles.css file and not finding it even though I don't provide one and never have. Not sure why.

I can reproduce it if I uninstall the plugin and then reinstall, it doesn't happen on load.

Okay, I reproduced it like that. However, this is definitely a bug with obsidian, not my plugin. This happens with any plugin that provides no css; I was able to reproduce the same thing with https://github.com/denolehov/obsidian-git


Set first api_version

Are we OK to:

merge open non-draft PRs
add a git tag 2023-07 (or 2023-08)

?
Then I can start upstreaming __dataframe_consortium_standard__ methods which defer to the dataframe-api-compat package (or at least, try to)

as per today's discussion - once #223 is in, let's push a 2023-08-beta tag
Is there anything else that needs doing here for releases?

I can't think of other things. Please go ahead and push the tag @MarcoGorelli! You did most of the implementation work here, so I'd say you get to do the honours for tagging the first beta as well here:)


Test: root.json w/ targets role threshold = 0

See: [PRO-3186](https://advancedtelematic.atlassian.net/browse/PRO-3186

Closed via fbb7d03b


Protect against extracting files outside the destination directory.

Fixes https://github.com/marmelroy/Zip/issues/245

+1 on the new release!

I'm leaving that up for @marmelroy, I'm personally referencing the main branch in my projects.


Document has a wrong link

Describe the bug
On page https://docs.powerloom.io/docs/Protocol/Specifications/protocol-state

A link for data market redirects to a wrong url which is https://docs.powerloom.io/docs/protocol/data-sources/
It shows 404 because proper link is https://docs.powerloom.io/docs/Protocol/data-sources/

I found many links redirecting to 404.
I created PR

hey @SeungjinPark2, thanks for catching this. Could you please follow the guidelines in the issue and PR template?

Hi @SwaroopH, I've done to edit issue, pr.

Closing this since it has been clarified in detail in issue #36


[Animation/useScrollTrigger] Animation triggered by scrolling to predefined Component

I did not find a way to "bind" the useScrollTrigger function to a specific Component or section/area of a page other than the window itself.
Here is the relevant code:
export interface UseScrollTriggerOptions {
  disableHysteresis?: boolean;
  target?: Node | Window;
  threshold?: number;
}

When passing a Node or reference to a Node a crash occurs. The documentation is unclear about how to use the useScrollTrigger function for things other than interactions with an AppBar.

[x] I have searched the issues of this repository and believe that this is not a duplicate.

Summary 💡
It should be possible to pass a reference to a Component that would set the useTriggerScroll returned value to True once users scroll to this Component.

Examples 🌈
A page contains a Grid of Cards wrapped in an Animation component that should get trigger when users scrolls to this section. See the following code snippet:
const ref = React.useRef(null);
const scrollTrigger = useScrollTrigger({
  disableHysteresis: true,
  target: ref,
});

<Grid container spacing={2}>
  {services.map((service) => (
    <Grid key={uid(service)} item md={4} sm={6} xs={12}>
      <Grow
        mountOnEnter
        in={scrollTrigger}
        timeout={2048}
      >
        <Card
          ref={ref}
          className={classes.card}
          elevation={2}
        >
          <CardHeader --- REDACTED ---/>
          <CardContent --- REDACTED --->
            --- REDACTED ---
          </CardContent>
          <CardActions --- REDACTED --->
            --- REDACTED ---
        </Card>
      </Grow>
    </Grid>
  ))}
</Grid>

Motivation 🔦
Animations in web design are keys to get users engagements and make website more lively and interesting to browse. Having an easy way to implement onScroll animations, or having more details on the doc on how to achieve this is needed.

tip: target expects a DOM node.

@oliviertassinari I would suggest adding an example on the Doc, to illustrate how to implement this.

@aress31 Then you are not looking at the right component. useScrollTrigger is about the scroll containers, not about its content. See #16359.


Investigate potential pandas 2.0 speedup

I'm already using pandas 2.0 and it should be installed by default - can we close this issue?

https://github.com/NinaWie/dav_hut_finder/blob/bae48fb823196eb161e825897756c607b0bd6e9a/backend/pyproject.toml#L20
you are right, geopandas 1.0.1 installs pandas 2.2.3, I probably confused the two packages


Workaround for VS2017 does not work

I tried to 'Debug a Consumption plan C# Functions bot' with Visual Studio 2017 with no success. I think the documentation is missing a point or the tool chain has changed.
Steps I did

download my Azure Function Bot and unzip it.
download messages.csproj and put into the messages folder

When I run dotnet restore I get:
C:\Program Files\dotnet\sdk\2.1.402\NuGet.targets(114,5): warning : Kein wiederherzustellendes Projekt gefunden! [C:\Use
rs\sschoof\Source\Repos\dgHelperFunction\Bot.sln]

(the german means: "no project to restore found")
Opening the project in VS 2017 and add the project to the sln does also not help.
If I run the debughost.cmd I get compile errors for missing the Micrsoft.Bot Namespace.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3691ca29-1a48-7842-8536-5f86d5ef0908
Version Independent ID: 08ea18f3-3fe9-14a8-d08a-6bbc2b33b42d
Content: Debug a bot built using Bot Service - Bot Service
Content Source: articles/bot-service-debug-bot.md
Product: bot-framework
GitHub Login: @v-ducvo
Microsoft Alias: v-ducvo

For the C# Functions bot, on Visual Studio 2017 15.8 I tried your workaround and received this error while trying to run debughost.cmd and received this error:
'func' is not recognized as an internal or external command,
operable program or batch file.
----------------------------------------------------------------------
To fetch your bot service settings run the following command:
    func azure functionapp fetch-app-settings [YOUR_BOT_SERVICE_NAME]
----------------------------------------------------------------------

Ok, that worked, this can be closed.

My project still is still not working. Can you explain how you restore the nuget packages?

@StefanSchoof - you can the link below to report this issue to the support team. https://stackoverflow.com/questions/tagged/botframework

I created a question: https://stackoverflow.com/questions/52474528


Set Difference does not give the correct result

Import the attached file into the group editor.
query.txt
And then try to do R - S. It will produce the wrong result. Then if you do R (anti-join) S it will produce the correct result. When all columns from 2 relations are identical, these two operations should produce the same results. However, they do not.

In relax/src/db/exec/Table.ts I believe this method is written incorrectly and is the reason for set difference not working.
static rowEqualsRow(rowA: Tuple, rowB: Tuple) {
    if (rowA.length !== rowB.length) {
        return false;
    }

    for (let i = 0; i < rowA.length; i++) {
        let found = false;
            for (let j = 0; j < rowB.length; j++) {
                if (rowA[i] === rowB[j]) {
                    found = true;
                }
            }

            if (!found) { return false; }
        }

    return true;
}

This is the correct implementation I believe. However, someone should probably test it first
static rowEqualsRow(rowA: Tuple, rowB: Tuple) {
    if (rowA.length !== rowB.length) {
        return false;
    }

    let match = true;
    for (let i = 0; i < rowA.length; i++) {
        if (rowA[i] !== rowB[i]) {
           match = false;
           break;
        }
    }

    return match
}

Fixed with 454bcc


🐛 Use pure Decimal for _IMMUTABLE_TYPES without Annotated as it breaks instance and class checks

🐛 Use pure Decimal for _IMMUTABLE_TYPES without Annotated as it breaks instance and class checks
This makes this test pass:
pytest tests/unit/test_model_type_validation.py -k test_mutable_types_mutables

This is amazing thank you :grinning: :fire:


Import latest gtest to third_party to be able to use gmock

+1 - thanks ;)

Rebased as 6f40e5ddcaf59b2cae317a5e245ffc236e2f2adc


TRE Services - Upgrade and Documentation

The TRE resources all need to be upgraded as new versions are released. When deploying services via the deployment pipeline or via manual steps the same result can be seen and the services are not updated.
Resource upgrade isn't currently implemented. See https://github.com/microsoft/AzureTRE/issues/141
There are conversations currently about upgrading resources and how this should be approached (#1744) but, at the moment there is nothing in the documentation on the best approach when upgrading/ re-deploying an existing service.
For example, our Firewall is on version 0.4.0 and re-deployment causes the above error.
 Is the best approach to deploy a second firewall and then delete the existing to ensure there is no downtime
 for this shared service?

Describe the bug
Upgrading TRE services fails, mainly an issue with shared services that do not want to be deleted each time there is a new version.
The main cause of concern is lack of documentation on the topic. Best practices for re-deployment, particularly for a firewall, is required.
Steps to reproduce

Have a pre-existing TRE with shared services deployed.
Upgrade the porter version of one of these shared services, such as nexus.
run make deploy-shared-service DIR=./AzureTRE/templates/shared_services/sonatype-nexus-vm/ BUNDLE_TYPE=shared_service PROPS="--ssl_cert_name nexus-ssl"
See the above error of Resource upgrade isn't currently implemented.

@JaimieWi at the moment the only way to upgrade is to access cosmos and update the version of the template. Then if carry out an update operation on the resource it will get the new version of the bundle.
I'm going to add a generic issue to document accessing cosmos when need to "break glass".
Hopefully we will have #1744 resolved before too long.

@marrobi Ah ok great, thank you! I had seen that might be a solution but wasn't sure it was the best thing to do! I will start the process for updating each service now :)

Added #2901
Will close this, @JaimieWi  if need further help, let us know.


make build-and-push-images fails on M1

For me make build-and-push-images fails. Below is an excerpt
make build-and-push-images
cd scripts && ./build-and-push-images.sh
Building image localhost:5000/ods/ods-buildah...
[+] Building 1.6s (18/18) FINISHED
...
Building image localhost:5000/ods/ods-finish...
...
Building image localhost:5000/ods/ods-go-toolset...
...
Building image localhost:5000/ods/ods-gradle-toolset...
...
Building image localhost:5000/ods/ods-helm...
[+] Building 9.6s (15/21)
 => [internal] load build definition from Dockerfile.helm                                                                                0.0s
 => => transferring dockerfile: 2.18kB                                                                                0.0s
 => [internal] load .dockerignore                                                                                0.0s
 => => transferring context: 2B                                                                                0.0s
 => [internal] load metadata for registry.access.redhat.com/ubi8/ubi-minimal:8.4                                                                                0.5s
 => [internal] load metadata for registry.access.redhat.com/ubi8/go-toolset:1.16.12                                                                                0.5s
 => [builder 1/9] FROM registry.access.redhat.com/ubi8/go-toolset:1.16.12@sha256:287d341349331a19866a2862a55e0cc5c412f21a86ba80629f59579ef6a38c03                                                                                0.0s
 => [internal] load build context                                                                                0.0s
 => => transferring context: 419.82kB                                                                                0.0s
 => [stage-1 1/7] FROM registry.access.redhat.com/ubi8/ubi-minimal:8.4@sha256:c536d4c63253318fdfc1db499f8f4bb0881db7fbd6f3d1554b4d54c812f85cc7                                                                                0.0s
 => CACHED [stage-1 2/7] RUN microdnf install skopeo-1.4* git-2.27* tar-1.30* && microdnf clean all                                                                                0.0s
 => CACHED [builder 2/9] RUN mkdir -p /tmp/helm     && cd /tmp     && curl -LO https://get.helm.sh/helm-v3.5.2-linux-amd64.tar.gz     && tar -zxvf helm-v3.5.2-linux-amd64.tar.gz -C /tmp/helm     && mv /tmp/helm/linux-amd64/helm  0.0s
 => CACHED [builder 3/9] COPY go.* .                                                                                0.0s
 => CACHED [builder 4/9] COPY cmd cmd                                                                                0.0s
 => CACHED [builder 5/9] COPY internal internal                                                                                0.0s
 => CACHED [builder 6/9] COPY pkg pkg                                                                                0.0s
 => CACHED [builder 7/9] RUN cd cmd/deploy-with-helm && CGO_ENABLED=0 go build -o /usr/local/bin/deploy-with-helm                                                                                0.0s
 => ERROR [builder 8/9] RUN mkdir -p /tmp/sops     && cd /tmp/sops     && curl -LO https://github.com/mozilla/sops/releases/download/v3.7.1/sops-3.7.1-1.x86_64.rpm     && yum install -y sops-3.7.1-1.x86_64.rpm     && sops --ver  9.0s
------
 > [builder 8/9] RUN mkdir -p /tmp/sops     && cd /tmp/sops     && curl -LO https://github.com/mozilla/sops/releases/download/v3.7.1/sops-3.7.1-1.x86_64.rpm     && yum install -y sops-3.7.1-1.x86_64.rpm     && sops --version:
#15 0.235   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
#15 0.235                                  Dload  Upload   Total   Spent    Left  Speed
100   660  100   660    0     0   2608      0 --:--:-- --:--:-- --:--:--  2608
100 12.7M  100 12.7M    0     0  6871k      0  0:00:01  0:00:01 --:--:-- 8347k
#15 2.383 Updating Subscription Management repositories.
#15 2.383 Unable to read consumer identity
#15 2.387
#15 2.387 This system is not registered with an entitlement server. You can use subscription-manager to register.
#15 2.387
#15 4.460 Red Hat Universal Base Image 8 (RPMs) - BaseOS  283 kB/s | 570 kB     00:02
#15 6.616 Red Hat Universal Base Image 8 (RPMs) - AppStre 1.1 MB/s | 2.3 MB     00:02
#15 8.737 Red Hat Universal Base Image 8 (RPMs) - CodeRea 6.9 kB/s |  13 kB     00:01
#15 8.897 Error:
#15 8.897  Problem: conflicting requests
#15 8.897   - package sops-3.7.1-1.x86_64 does not have a compatible architecture
#15 8.898 (try to add '--skip-broken' to skip uninstallable packages or '--nobest' to use not only best candidate packages)
------
executor failed running [/bin/bash -o pipefail -c mkdir -p /tmp/sops     && cd /tmp/sops     && curl -LO https://github.com/mozilla/sops/releases/download/v${SOPS_VERSION}/sops-${SOPS_VERSION}-1.x86_64.rpm     && yum install -y sops-${SOPS_VERSION}-1.x86_64.rpm     && sops --version]: exit code: 1
make: *** [build-and-push-images] Error 1

The above is from the second run. The full log from the first run is at build-and-push-images.log
Here is some info about the machine
uname -a
Darwin <host-name-redacted> 21.2.0 Darwin Kernel Version 21.2.0: Sun Nov 28 20:28:41 PST 2021; root:xnu-8019.61.5~1/RELEASE_ARM64_T6000 arm64

 docker version
Client:
 Cloud integration: v1.0.22
 Version:           20.10.11
 API version:       1.41
 Go version:        go1.16.10
 Git commit:        dea9396
 Built:             Thu Nov 18 00:36:09 2021
 OS/Arch:           darwin/arm64
 Context:           default
 Experimental:      true

Server: Docker Engine - Community
 Engine:
  Version:          20.10.11
  API version:      1.41 (minimum version 1.12)
  Go version:       go1.16.9
  Git commit:       847da18
  Built:            Thu Nov 18 00:34:44 2021
  OS/Arch:          linux/arm64
  Experimental:     false
 containerd:
  Version:          1.4.12
  GitCommit:        7b11cfaabd73bb80907dd23182b9347b4245eb5d
 runc:
  Version:          1.0.2
  GitCommit:        v1.0.2-0-g52b36a2
 docker-init:
  Version:          0.19.0
  GitCommit:        de40ad0

I believe docker build builds for the os platform by default (arm64) and succeeds for ods-buildah, ods-finish, ods-go-toolset, ods-gradle-toolset but fails for ods-helm

I relaxed locally build-and-push-images.sh so it continues with the next image if one fails. The other build that fails is for the ods-node16-typescript-toolset.
See build-and-push-ts-image.log for the full log.

Until finding a fix so that images run natively on M1 added fix so that helm and typescript images are build for platform linux/amd64 (see commit c45c2e68) for details.
Building for linux/amd64 on M1 is much slower than directly on a Intel based Mac:

helm: M1 456.6s vs Intel 95.1s
typescript: M1 469.6s vs Intel 120.6s

However after a make install-ods-tasks-kind to deploy the tasks make test-tasks now the TestTaskODSDeployHelm PASSes. All other tests fail as they require bitbucket, sonarqube or nexus.  See related issues linked above.

Thanks for experimenting with this and reporting all of it. That doesn't look too promising :(
Let me try to summarise:

our own images work except Helm and Typescript
external images do not work except Postgres

Correct?
I guess for (1) we could try to adapt the Dockerfile to make them build also for arm64. I think this should be doable. For example, we can install sops via go install<EMAIL_ADDRESS>and Helm offers a arm64 release. The Dockerfile could automatically select the correct binary based on a build arg maybe? We could use ARGs aligned with https://docs.docker.com/engine/reference/builder/#automatic-platform-args-in-the-global-scope, even if we do not use buildx (locally we could but we also need to ensure it still works within the BuildConfig context).
For (2) we could open issues in the GitHub repos of the official images to see if support for arm64 is possible/planned? For example for Nexus, I found https://github.com/klo2k/nexus3-docker, which uses the official Dockerfile with a few alterations.

@michaelsauter Your summary is correct.
I agree with your proposals but not sure yet whether a build-arg is needed -- need to educate myself first a bit more. But perhaps others have more multi platform docker experience already..

Cool. I've made the small suggested change in #364.
I am aware of the following four ways to build for multiple architectures:

Using methods like in #364 that do not hardcode an architecture
Using commands like uname to figure out the architecture dynamically (I don't particularly like it because it can be brittle and will duplicate logic between `Dockerfiles)
Using a build arg as suggested
Using a different Dockerfile per architecture (I don't particularly like it because it increases maintenance effort)

https://github.com/docker-library/official-images#multiple-architectures has some suggestions regarding conditional in the RUN commands to target various userspace architectures, to quote dpkg --print-architecture or apk -print-arch to detect the userspace architecture. Only use uname for architecture detection when more accurate tools cannot be installed.
It also links to https://github.com/docker-library/golang/blob/b879b60a7d94128c8fb5aea763cf31772495511d/1.16/buster/Dockerfile#L24-L68

Also this could sometimes be of relevant: https://github.com/sixeyed/diamol/tree/master/ch16/lab

Article Faster Multi-Platform Builds: Dockerfile Cross-Compilation Guide - Docker Blog has a section about predefined variables such as BUILDPLATFORM and TARGETPLATFORM.

Tried out a fix for ods-deploy as shown in commit 1638d40 but getting this on the M1 mac:
→ ./build-and-push-images.sh --image helm
Building image localhost:5000/ods/ods-helm...
[+] Building 2.5s (21/21) FINISHED
 => [internal] load build definition from Dockerfile.helm                                                                                0.0s
 => => transferring dockerfile: 2.06kB                                                                                0.0s
 => [internal] load .dockerignore                                                                                0.0s
 => => transferring context: 2B                                                                                0.0s
 => [internal] load metadata for registry.access.redhat.com/ubi8/ubi-minimal:8.4                                                                                0.6s
 => [internal] load metadata for registry.access.redhat.com/ubi8/go-toolset:1.16.12                                                                                0.6s
 => [builder 1/9] FROM registry.access.redhat.com/ubi8/go-toolset:1.16.12@sha256:287d341349331a19866a2862a55e0cc5c412f21a86ba80629f59579ef6a38c03                                                                0.0s
 => [stage-1 1/7] FROM registry.access.redhat.com/ubi8/ubi-minimal:8.4@sha256:c536d4c63253318fdfc1db499f8f4bb0881db7fbd6f3d1554b4d54c812f85cc7                                                                   0.0s
 => [internal] load build context                                                                                0.0s
 => => transferring context: 5.93kB                                                                                0.0s
 => CACHED [stage-1 2/7] RUN microdnf install skopeo-1.4* git-2.27* tar-1.30* && microdnf clean all                                                                                0.0s
 => CACHED [builder 2/9] RUN mkdir -p /tmp/helm     && cd /tmp     && curl -LO https://get.helm.sh/helm-v3.5.2-linux-arm64.tar.gz     && tar -zxvf helm-v3.5.2-linux-arm64.tar.gz -C /tmp/helm     && mv /tmp/h  0.0s
 => CACHED [builder 3/9] COPY go.* .                                                                                0.0s
 => CACHED [builder 4/9] COPY cmd cmd                                                                                0.0s
 => CACHED [builder 5/9] COPY internal internal                                                                                0.0s
 => CACHED [builder 6/9] COPY pkg pkg                                                                                0.0s
 => CACHED [builder 7/9] RUN cd cmd/deploy-with-helm && CGO_ENABLED=0 go build -o /usr/local/bin/deploy-with-helm                                                                                0.0s
 => CACHED [builder 8/9] RUN go install<EMAIL_ADDRESS>   && sops --version                                                                                0.0s
 => CACHED [builder 9/9] RUN go install<EMAIL_ADDRESS>   && age --version                                                                                0.0s
 => CACHED [stage-1 3/7] COPY --from=builder /usr/local/bin/deploy-with-helm /usr/local/bin/deploy-with-helm                                                                                0.0s
 => CACHED [stage-1 4/7] COPY --from=builder /usr/local/bin/helm /usr/local/bin/helm                                                                                0.0s
 => CACHED [stage-1 5/7] COPY --from=builder /usr/local/bin/sops /usr/local/bin/sops                                                                                0.0s
 => CACHED [stage-1 6/7] COPY --from=builder /usr/local/bin/age /usr/local/bin/age                                                                                0.0s
 => ERROR [stage-1 7/7] RUN mkdir -p $HELM_PLUGINS     && HELM_DATA_HOME=${HELM_PLUGINS%/*} helm plugin install https://github.com/databus23/helm-diff --version v${HELM_PLUGIN_DIFF_VERSION}     && HELM_DATA_  1.8s
------
 > [stage-1 7/7] RUN mkdir -p $HELM_PLUGINS     && HELM_DATA_HOME=${HELM_PLUGINS%/*} helm plugin install https://github.com/databus23/helm-diff --version v${HELM_PLUGIN_DIFF_VERSION}     && HELM_DATA_HOME=${HELM_PLUGINS%/*} helm plugin install https://github.com/jkroepke/helm-secrets --version v${HELM_PLUGIN_SECRETS_VERSION}     && ls -lah $HELM_PLUGINS     && sops --version     && age --version:
#21 1.722 No prebuild binary for linux-arm64.
#21 1.722 Failed to install helm-diff
#21 1.722 	For support, go to https://github.com/databus23/helm-diff.
#21 1.722 Error: plugin install hook for "diff" exited with error
------
executor failed running [/bin/sh -c mkdir -p $HELM_PLUGINS     && HELM_DATA_HOME=${HELM_PLUGINS%/*} helm plugin install https://github.com/databus23/helm-diff --version v${HELM_PLUGIN_DIFF_VERSION}     && HELM_DATA_HOME=${HELM_PLUGINS%/*} helm plugin install https://github.com/jkroepke/helm-secrets --version v${HELM_PLUGIN_SECRETS_VERSION}     && ls -lah $HELM_PLUGINS     && sops --version     && age --version]: exit code: 1

For helm-diff there is already a PR at https://github.com/databus23/helm-diff/pull/267

@henrjk Nice. Actually, this is resolved via a different PR in master? https://github.com/databus23/helm-diff/pull/294

The build issue in the typescript tooling is because Chrome is not available on arm64, except for macos while our image needs it for linux. It would be good if FE/cypress experts see whether we could switch to Chromium which would/should be available on linux/arm64 as well.
Details are in the log reported in https://github.com/opendevstack/ods-pipeline/issues/360#issuecomment-1002955210

@henninggross @netzartist @m-apsolon any thoughts on whether using Chromium is viable?
This issue could be relevant.


Rework to use OctoKit in order to use paginate method

Remove the dependency to GitHub library which has been replaced by OctoKit and use paginate method in order to get all the comments instead of the first X ones only.

@vbouchet31 Thanks for your work!
However, I no longer use this tool.
If you are ok, I want to transfer this repository.
Also, Do you have npm account?

Hi @azu . I don't have a npm account. It is my first contribution to a node project. However, given it is not a too visible and too sensitive tool, I am fine taking the risk of maintaining it if you wish. (I may regret this words later ;-) ).
I will create an account and let you know.

https://www.npmjs.com/~vbouchet31

Nice! I've invited you to npm and this repo.

After merging this PR, you can publish a new version to npm.
Updating Package
Almost Node.js project use semantic versioning.
This change is "fixes".
So, you can use npm version patch command to update package's version.
After update the package's version, you can publish the new package to npm via npm publish command.

npm-version | npm Docs
Updating your published package version number | npm Docs

Commands:
# you need to login to npm first time
$ npm login
# update package.json
# Following command will do 1.2.2 → 1.2.3 and git tag
$ npm version patch
# publish to npm
$ npm publish


Client React UI SDK: Wallet provider wrapper for useAuth core (part 2)

Description
This contains the changes for adding the smart wallet state within the useAuth hook from auth core by creating a wrapper provider and extending functionality of auth core.
Hooks added to React UI:

useAuth extends regular auth core useAuth hook but adds wallet context.
CrossmintAuthProvider extends regular AuthProvider from core but adds context provider and createWallet function.

Test plan
Nextjs demo flow (part 1)  all works as expected using this PR's changes

Few annotations i'm bumping as a reminder:

https://github.com/Crossmint/crossmint-sdk/pull/660#discussion_r1719103468
https://github.com/Crossmint/crossmint-sdk/pull/660#discussion_r1719102923
https://github.com/Crossmint/crossmint-sdk/pull/660#discussion_r1718960995


Reason: Message must be shorter than 262144 bytes.

Hi dear author, I am trying your solution. However, I still get the same error Message
Reason: Message must be shorter than 262144 bytes.
Here is my sqs client configuration
var (
	client *sqsextendedclient.Client
)

func init() {

	cfg, err := config.LoadDefaultConfig(context.TODO())
	if err != nil {
		logging.Logger.Error("failed to get CFG: 28",
			zap.Error(err),
		)
	}

	// S3 Bucket
	s3Bucket := os.Getenv("STORAGE_S3_BUCKET")

	// Extended SQS Client
	// create a new sqsextendedclient with some options
	client, _ = sqsextendedclient.New(
		sqs.NewFromConfig(cfg),
		s3.NewFromConfig(cfg),
		// Get the bucket name
		sqsextendedclient.WithS3BucketName(s3Bucket),
		// set the threshold to 2gb
		sqsextendedclient.WithMessageSizeThreshold(2097152),
	)
}

Appreciated much if you can help me. Thanks expert.

Hey @jktan0504, thanks for trying out the library! In your initiation, it looks like you set the message threshold to 2 GB (sqsextendedclient.WithMessageSizeThreshold(2097152)). Unfortunately, AWS has a hard limit and will only accept messages up to 256 KiB (look under the Message Size section). They accept payloads up to 2 GB (so you can batch together multiple 256 KiB messages in a SendMessageBatch call), however it is currently impossible for any single message to exceed 256 KiB.
If you remove that line (configuring the message threshold to 2 GB), the default message size threshold is set to the maximum possible (256 KiB). That should result in sending your messages as expected.


test_string_dictionary_merge has different results in different platforms

Describe the bug

I ran test_string_dictionary_merge both in linux x86_64 and macos aarch64 platforms and got different results. It succeeded in linux x86_64 whose values' len is 33 and failed in macos aarch64 whose values' len is 32. It's because interner.intern produces different results  when build interleave indices for new values array.
To Reproduce

Run cargo test both in above 2 platforms.
Expected behavior

The test can successfully pass in both platforms.

Yes, it's expected, but the test will failed. Maybe we should introduce conditional compilation in this test?

label_issue.py automatically added labels {'arrow'} from #5461


Possible incorrect autocomplete syntax.

I'm facing the following problem, trying to autocomplete a durative-action creates the following template.
(:durative-action action_name
    :parameters ()
    :duration (= ?duration 1)
    :condition (and
        (at start (and
        ))
        (over all (and
        ))
        (at end (and
        ))
    )
    :effect (and
        (at start (and
        ))
        (at end (and
        ))
    )
)

The planner I'm using to evaluate the domain starts acting weirdly using this syntax, with multiple errors and even crashes.
The following part causes the weird behaviour, for example:
:effect (and
        (at start (and
            (example ?a ?b)
            (not (example2 ?a ?b))
        ))
    )

Changing it to the following, works as intended:
:effect (and
        (at start (example ?a ?b))
        (at start (not (example2 ?a ?b)))
    )

NOTE: I faced this issue as I'm being introduced to PDDL at college, and the planner we are using is LPG-td-1.0. I'm not sure if the PDDL syntax allows this usage of the :effect section, as I couldn't find anything in the PDDL documentation using the syntax in this extension. If this is part of the standard PDDL syntax then it would be great to know in order to let the people at the college know.
Thanks in advance.

Thanks for reporting this. I did not try LPG. Yes, it is quite possible that different planners implement the PDDL parsing differently. The syntax suggested by the auto-completion snippet is compliant with the published PDDL BNF syntax. But that does not help you, I know.
I can offer two solutions:

you can add your own more suitable snippets using the VS Code custom user snippet mechanisms described here
I simplify the snippet to be relevant to more planners, including LPG (while keeping the snippets useful for most users)

Related:
I would like to get your feedback on the support for LPG planner command-line switches and its plan format parsing. Please try the new version of the extension (best if you configure your LPG executable using the configuration facility now provided).
2.19.4
Support for LPG planner
The LPG Planner uses slightly different format for the plans. Now those plans are parsed and visualized.
LPG command-line options are also presented in the drop down, while invoking the planner:

Thanks a lot for the reply! I will give it a try and report you back the results. (It will take me a few days to test it however.)
How would I go installing the 2.19.4 version? I've always installed vscode extensions through the extensions menu, but the latest version listed there is 2.19.3.

My mistake. The update did not get pushed to the Microsoft marketplace. Fixing it now...

There were some build reliability issues, but now the 2.19.4 is in the marketplace and your version should update upon next two VS Code reloads.

Thanks for the extension of PDDL, it's excellent. The LPG planner is what I have been looking for to solve the duration-action problems, it's great that the newest version supports that.
However, I'm confused about how to get the LPG Application (you showed in the video above), whenever I enter the LPG website, I can only get lots of code to be compiled. How can I get this LPG application? Please help.
Thank you in advance. @jan-dolejsi @mariohackandglitch

I found the binaries on this site: https://lpg.unibs.it/lpg/
Although the windows build from there was not behaving correctly (spawning endless number of subprocesses).

So how did you solve the problem? The windows version can't be built correctly but the Linux version is ok......


Upgrade composer.lock with the PHP 7.2 version

Changed log

Upgrading the composer.lock file with the PHP 7.2 version, and the command outputs are as follows:

Loading composer repositories with package information
Info from https://repo.packagist.org: #StandWithUkraine
Updating dependencies
Lock file operations: 0 installs, 1 update, 0 removals
  - Upgrading corneltek/getoptionkit (2.6.1 => 2.7.0)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 0 installs, 1 update, 0 removals
  - Downloading corneltek/getoptionkit (2.7.0)
  - Upgrading corneltek/getoptionkit (2.6.1 => 2.7.0): Extracting archive
Package phpunit/php-token-stream is abandoned, you should avoid using it. No replacement was suggested.
Generating autoload files
27 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
No security vulnerability advisories found

The failed tests in the 7.3 version is as follows:
1) PhpBrew\Tests\Extension\KnownCommandTest::testGithubPackage
CurlKit\CurlException:  at [https://api.github.com/repos/phalcon/cphalcon/tags:The requested URL returned error: 403]

/home/runner/work/phpbrew/phpbrew/vendor/corneltek/curlkit/src/CurlKit/CurlDownloader.php:156
/home/runner/work/phpbrew/phpbrew/src/PhpBrew/Downloader/PhpCurlDownloader.php:33
/home/runner/work/phpbrew/phpbrew/src/PhpBrew/Downloader/BaseDownloader.php:44
/home/runner/work/phpbrew/phpbrew/src/PhpBrew/Extension/ExtensionDownloader.php:58
/home/runner/work/phpbrew/phpbrew/tests/PhpBrew/Extension/KnownCommandTest.php:51
phpvfscomposer:///home/runner/work/phpbrew/phpbrew/vendor/phpunit/phpunit/phpunit:97

It seems that the error is igored in the Travis CI build. Maybe it can also ignore in the GitHub action.


Missing icons in the sidebar

VSCode Version: 1.20
OS Version: Windows 10

Steps to Reproduce:

Don't know what caused this
Only one icon at a time is being shown in the sidebar (Explorer, SCM, Debug, Extensions, Search)
When I choose one of the  (Explorer, SCM, Debug, Extensions, Search) from the view menu, its icon is shown in the sidebar than others are hidden.

Reproduces without extensions: Yes

Dup of https://github.com/Microsoft/vscode/issues/40531
As a workaround right click -> enable all the views
And let me know if you would like to do a live debugging session with me via skype


[VS Code] Starting collaboration session: Could not connect to the server. Live Share requires openssl 1.0 for authentication, please verify you have the dependency installed.

I am having an issue with using live share on visual studio code insiders. I always get this error:
%0A%0A%23%23 Error:%0AStarting collaboration session: Could not connect to the server. Live Share requires openssl 1.0 for authentication, please verify you have the dependency installed.%0A%0A%23%23 Steps to Reproduce:%0A1.%0A2.%0A%0A||Version Data|%0A|-:|:-|%0A|**extensionName**|VSLS|%0A|**extensionVersion**|1.0.311|%0A|**protocolVersion**|2.2|%0A|**applicationName**|VSCode|%0A|**applicationVersion**|1.35.0-insider|%0A|**platformName**|Linux|%0A|**platformVersion**|4.4.0-17763-Microsoft|

Hi @lrubens, thanks for the feedback! This is a dup of https://github.com/MicrosoftDocs/live-share/issues/2206, let's move our discussion there. What is the Linux distro you are using?

Hi @lrubens, thanks for the feedback! This is a dup of #2206, let's move our discussion there. What is the Linux distro you are using?

I am using ubuntu 18.04 using the Windows Subsystem for Linux feature on my windows laptop. Also, I'm using microsoft visual studio code insiders instead the regular one in order to use the remote - wsl extension.

Sorry it is actually dup of https://github.com/MicrosoftDocs/live-share/issues/2201, moving your comment there


E605: Exception not caught: NERDTree.FileAlreadyOpenAndModifiedError

I had a file open and modified and accidentally went to open the same file split. I got the following error:
Error detected while processing function 15_openEntrySplit..70:
line   47:
E605: Exception not caught: NERDTree.FileAlreadyOpenAndModifiedError: /path/to/file.cpp is already open and modified.
Error detected while processing function 15_openEntrySplit:
line    6:
E171: Missing :endif
This is easily repeatable with other files.

Just started getting this bug as well.


[PROPOSAL] Selection Sort Algorithm in Rust

Requesting the maintainers to assign this issue to me, and I will start working on it shortly.


Fix spelling and broken links

1. Fixed just a minor spelling error
ansiRegexRefence → ansiRegexReference
2. I found some links in source code broken, so  replaced them with the archived ones.

http://ascii-table.com/ansi-escape-sequences.php
http://ascii-table.com/ansi-escape-sequences-vt-100.php

↓

https://web.archive.org/web/20090204053813/http://ascii-table.com/ansi-escape-sequences.php
https://web.archive.org/web/20090227051140/http://ascii-table.com/ansi-escape-sequences-vt-100.php

Merged, thanks!


Add check for +Inf and -Inf value

Signed-off-by: Akash Srivastava<EMAIL_ADDRESS>

Codecov Report

Merging #22 into staging will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff            @@
##           staging      #22   +/-   ##
========================================
  Coverage    90.55%   90.55%
========================================
  Files            2        2
  Lines          233      233
========================================
  Hits           211      211
  Misses          17       17
  Partials         5        5

Impacted Files
Coverage Δ

metrics/metrics.go
76.31% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 577606c...f2c9169. Read the comment docs.