HELP, Very serious, Skype account BANNAED/LOCKED/BLACKLIST by skype offical.

Hi Terrance, I've followed your project for quite some time. It helps a lot, so many thanks first.
Yet recently I got into trouble with skype official locking my account (forever, not the kind that requires verification code). FYI, I used email to sign in, and usually send about 2000 report messages a day to my clients.
At first skype notified me about abnormal, yet I can still log in.
Recently I was banned from login and then banned again, time to time after I register a new account, or even after I managed to retrieve my account from skype service (I was happy at first),  YET I was just send like about just 100 of messages a day, still, locked, banned. This could be deadly for my work, I almost quit. (sad)
Have you ever have similar issue, what's your advice?  Perhaps it's about adding too much new contacts, or sending to much msgs （some are sent to strangers）
Do appreciate your work, thanks.
Account type
I used email to register and login, thus perhaps a Microsft account?
Conversation details

Steps to reproduce

Result or traceback

I've not had any of my accounts suspended, nor have I heard of others in this situation, but I've also not sent that volume of messages, nor do I send messages to non-contacts (which if done frequently is very likely to be treated as spam).
Account automation in general is likely frowned upon (building a custom client is a reasonable use case, bulk-sending unsolicited messages is not), and in any case it sounds like you should be using the official bot framework for this.
If you've had multiple accounts suspended now then they're likely applying closer scutiny to your IP address or some other identifying piece of information.

Got your message，thanks. I'll consider ur advice and infos. I am a vessel broker，so not for spamming～


OpenARC setup with other milters

Could someone please explain the recommended setup of OpenARC with Postfix? What is the required or recommended sequence of milters doing SPF, DKIM, DMARC, and ARC?
Currently I’m using the following milters in Postfix:
smtpd_milters =
  unix:spf/spf-milter.sock
  unix:opendkim/opendkim.sock
  unix:opendmarc/opendmarc.sock
  unix:spamassassin/spamassassin-milter.sock

Where does OpenARC fit in? It has to be after OpenDKIM and before OpenDMARC, is that right? (And can it be made to work at all in the current state?)

The answer seems to be yes, the OpenARC milter should be just before OpenDMARC, because OpenDMARC will consume Authentication-Results added by OpenARC to override a failing DMARC check. See here:
https://github.com/trusteddomainproject/OpenDMARC/blob/rel-opendmarc-1-4-0-Beta1/opendmarc/README#L192-L208
To make it work with OpenDMARC, you also have to add the following setting to the OpenDMARC configuration, where community_sealer_whitelist is the whitelist provided in project trusteddomainproject/ARC_Community_Sealers.
DomainWhitelistFile /path/to/community_sealer_whitelist

Then it should work, at least for verification.

The answer seems to be yes, the OpenARC milter should be just before OpenDMARC, because OpenDMARC will consume Authentication-Results added by OpenARC to override a failing DMARC check. See here:
https://github.com/trusteddomainproject/OpenDMARC/blob/rel-opendmarc-1-4-0-Beta1/opendmarc/README#L192-L208
To make it work with OpenDMARC, you also have to add the following setting to the OpenDMARC configuration, where community_sealer_whitelist is the whitelist provided in project trusteddomainproject/ARC_Community_Sealers.
DomainWhitelistFile /path/to/community_sealer_whitelist

Then it should work, at least for verification.

Just to add to this, I think the ordering depends on what you are doing. If you are forwarding and sealing messages, then I think OpenDMARC should be before OpenARC, so that OpenARC can include the results from OpenDMARC in its signature.


fix(text-field): Update package.json

Codecov Report

Merging #38 into fix/button/package-json-update will not change coverage.
The diff coverage is n/a.

@@                      Coverage Diff                       @@
##           fix/button/package-json-update     #38   +/-   ##
==============================================================
  Coverage                            98.3%   98.3%
==============================================================
  Files                                  16      16
  Lines                                 412     412
  Branches                               29      29
==============================================================
  Hits                                  405     405
  Misses                                  7       7

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc0355d...fda82fb. Read the comment docs.


Create UI Mockup for Alerts Page

About the Alerts Page:

Users should receive alerts for items that require restocking or have reached low stock levels.
Alerts should be customizable based on inventory thresholds defined by the user or admin.

Task:

[ ] Design an interface displaying notifications for low stock or restocking needs, with customizable alert thresholds.

Started making it.

Tasks Done Today:

Added sample alerts on the notifications page


Bump golang.org/x/net to v0.33.0

What type of PR is this?
(bug)
What this PR does / why we need it?
This PR updates the golang.org/x/net dependency to more recent version
Pre-checks (if applicable):

[x] Tested latest changes against a cluster

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 46.54%. Comparing base (d7a0fe3) to head (b1c9bbf).

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #192   +/-   ##
=======================================
  Coverage   46.54%   46.54%
=======================================
  Files           9        9
  Lines         752      752
=======================================
  Hits          350      350
  Misses        392      392
  Partials       10       10

/lgtm


FingerPrintLockExample

感谢提交 Pull Requests！
Thanks for submitting a pull request.

Security Check : 1cf4de5398f38a7e108641b83a437ef89ae743f7

auto build success,number:262

autotest fail,number:1805


Leaflet NPM Package contains different code than Github Repo does

Checklist

[X] I've looked at the documentation to make sure the behavior isn't documented and expected.
[X] I'm sure this is an issue with Leaflet, not with my app or other dependencies (Angular, Cordova, React, etc.).
[X] I've searched through the current issues to make sure this hasn't been reported yet.
[X] I agree to follow the Code of Conduct that this project adheres to.

Steps to reproduce
Using Leaflet's NPM package at version 1.7.1

Create a Marker using L.marker([xxx, yyy], options) (bonus points for using a custom Icon or other options according to the documentation)
Add it to the map
Click on the Marker
Observe (hopefully) an error pointing to the Marker.js for this.options.icon.options being undefined

It seems like if there was really a problem with Markers in 1.7.1 then someone would've pointed it out by now, but that makes it all the more baffling.
Expected behavior
I can use Markers out of the box, with custom Icons or any other Marker options, without an error being thrown.
Current behavior
I have a bug that concerns Markers, but points to a potential issue(?) in the Marker.js code from the NPM package. The jist of that is when I download the leaflet npm package (1.7.1 specifically, but it appears in 1.9.3 as well), I see in  ...\node_modules\leaflet\src\layer\marker\Marker.js there is a _panOnFocus() function near the bottom of the file.
However, looking at the repo here on github, that code isn't present. This isn't the only instance of extra code appearing in there but its the best example.
That seems strange to me. Why is there extra code there?
The result of that, which I'm seeing as a bug with my Markers, is when I create a marker using L.marker([xxxx, yyyy], options) and click on it on my map, I get an error from _panOnFocus() pointing to this.options.icon.options where this appears to be a Marker. But this.options is just true. Its not an object. Its just the boolean true`.
Then obviously it throws an error. And I'm just baffled as to why and what's going on to make that happen. There's something in there causing a problem and I'm not sure what it is. But mostly I'm not sure why its there at all.
However, if I just make a custom Marker myself by extending Layer and using the same Marker.js code as it appears here in Github (without the extra code npm has) then my Markers work beautifully. Other existing code that references this.options.whatever.... all resolves fine.
I do have other packages from npm for leaflet that I entertain could've been causing this but if I'm seeing this code in the leaflet node modules folder then it seems unlikely.
package.json looks like this for leaflet modules. Yes its an old app.
  ...
  "leaflet": "^1.7.1",
    "leaflet-draw": "^1.0.4",
    "leaflet-editable": "^1.2.0",
    "leaflet-mouse-position": "^1.2.0",
    "leaflet.path.drag": "^0.0.6",
...

Minimal example reproducing the issue
No response
Environment

Leaflet version: 1.7.1
Browser (with version): Chrome 113.0.5672.93
OS/Platform (with version): Windows 11

I'm looking at<EMAIL_ADDRESS>, and _panOnFocus is nowhere to be seen. I'm also looking at https://github.com/Leaflet/Leaflet/blob/v1.7.1/src/layer/marker/Marker.js , and there's no _panOnFocus either.
Please double-check your claim that the NPM package has different code.

It's not in the GitHub repo anywhere I've found. All the devs in my team can see it in the leaflet folder that gets loaded into node-modules when doing an npm install and that's the only time we've found it. Just bizarre.
Using the code as it is on GitHub and making our own Marker with it works beautifully. It just seems to be that the node module packing coming down is different than everything else we're seeing.
I will see if I can get a repro in a jsfiddle or something as well.

_panOnFocus was not in 1.7.1 #8042

All the devs in my team can see it in the leaflet folder that gets loaded into node-modules when doing an npm install and that's the only time we've found it.

If your devs are running npm install<EMAIL_ADDRESS>and are getting something different than https://www.npmjs.com/package/leaflet/v/1.7.1?activeTab=code , then it sounds like a problem in your side.

I have no clue if I'm wrong but the v1.9.4 in github and in bower, only have the css file and the images directory but npm has the css file, the images file, the js files and the js map files.
Maybe anything I can't see?


fix #45 When fetching star counts, add a value check.

Fixes https://github.com/responsively-org/website/issues/45

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.takumi-hasebe seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Express checkout on product page error - products with attributes

Hello,
I am having problems when using express checkout on product pages. It works fine with products that have no attributes. But if product haves attributes, the pop up window for EC immediatelly closes and nothing happens. Shopping cart EC works fine.

Hello,
Thank you for your message.
We can not reproduce this issue on our test environments.
Please contact our support team via PrestaShop Addons?
We will be glad to help you!
Best regards,
202 ecommerce


The trained_models connt be loaded

There was an error when I loaded the training model

there was a mistake in trained_model_path in the how to run part of readme, i fixed it.
I ran the following snippet on tf 2.5.0 which gave no error.  please try the following snippet to load the model and evaluate and let me know if there was any error.
run evaluate.py on trained_models
The trained models weigths are available in the drive folder trained_models. Copy the model you want to use into your project directory like shown below. Then you can evaluate the trained_model like below.

python evaluate.py --dataset rwf2000 --vidLen 32 --batchSize 4 --mode both --lstmType sepconv --fusionType M --weightsPath "/content/violenceDetection/model/rwf2000_model"


Incorrect data after app goes in the background

When an iOS app goes in the background, it looses network after a while (about 90 seconds according to my tests with the simulator).
If new rows are then created in a Supabase table that the app listens to, the app doesn't receive the data (which is expected).
When the app reconnects after idling, it starts receiving table addition events (which is expected), but it emits a representation of the data without the events that happened while is was offline (which is not expected).
I looked a bit at the code and can see that supabase-flutter manages its own cache, and that it manages internal representations of a table on atomic events like "INSERT" for example.
Maybe a solution could be to fetch the whole table after a reconnection? Or maybe to pass a reference to the previous message for all atomic events, so that the app can ensure that it hasn't missed one?
See video below for an example: the "third message" is ignored, and an incorrect representation of the messages list is emitted.
https://github.com/supabase/supabase-flutter/assets/1177483/5b44500b-d3eb-476b-8946-f02d4029c8f4
Steps to reproduce the behavior:

Listen to a table

supabase.from('messages').stream(primaryKey: ['id']).listen((event) {
  setState(() {
    _messages = event.map(Message.fromJson).toList();
});

Move the app to the background
Wait 1:30 minute
Add a row in the supabase table
Bring the app to the foreground
Add a row in the supabase table

Expected behavior
The stream emits a correct representation of the data.
Version:
I am on MacOS
dart pub deps | grep -E "supabase|gotrue|postgrest|storage_client|realtime_client|functions_client"
│   ├── supabase_flutter 2.0.0-dev.1
│   │   ├── supabase 2.0.0-dev.1
│   │   │   ├── functions_client 2.0.0-dev.0
│   │   │   ├── gotrue 2.0.0-dev.0
│   │   │   ├── postgrest 2.0.0-dev.0
│   │   │   ├── realtime_client 2.0.0-dev.1
│   │   │   ├── storage_client 2.0.0-dev.0

Thanks for testing this, as I was wondering what the behaviour in this case is.
How have you fixed it?
I assume the solution is, in the case of Flutter, to add a life cycle state listener and when the app is in foreground again, refetch the data of all streams again.
Just to be sure: I assume that the stream behaves the same as an on change listener, right?

@dippa-1 I haven't fixed it, instead I decided not to use supabase for now. It should be not the responsibility of the user of this library to fix it, I guess that the supabase is aware of that and plans to address this issue some time in the future.

indeed this stream supabase.from('messages').stream(primaryKey: ['id'])  closes after app stays in background for a while and then comes back to foreground.

With #1019 being merged now, these issues should be solved now. You can try them by upgrading supabase_flutter to 2.7.0. If you still experience any issues, please create a new issue.


Incorrectly labeled computer

I may be wrong, and this may be overkill for a GitHub issue, but there is a mislabeling in Routing level of the Basics section. The task is described as sending a packet from Bob's computer to Carol's computer. When I created a packet with the srcip being Bob, the packet came out of Alice's computer and won the level. So it think Bob and Alice has their names swapped. Upon further investigation, I can't get the packet animation to leave Bob's computer at all.

Sorry for Necroposting but, the computers are labeled correctly. You have to set, when adding a packet, where it was sent from.
Example:
Sent from:

Alice
Bob
Carol

You have to choose Bob.
To answer why you win is because you set the "srcip" to "Bob" so the program thinks its coming from Bob


Deadlock detection does not work

F.ex. Crash-tester has deadlocking enabled:
handler.deadlockWatchdogInterval = 8;
But when I press "Deadlock main  queue" or "Deadlock pthread" app deadlocks, but deadlock handler is never called.
runMonitor is never called due to KSCrashDeadlockMonitor is never initialised.
It looks like kscrashsentry_installDeadlockHandler must be called manually? If, yes I do not know when and what to put as KSCrash_SentryContex*context parameter?

I've noticed this as well.

@lukaszmargielewski  It turns out you can enable it as below, but it won't get installed if running in the debugger. You can verify its installation by setting the log settings to DEBUG in your processor macros.
    KSCrash *crash = [KSCrash sharedInstance];
    crash.handlingCrashTypes = KSCrashTypeAll;
    crash.deadlockWatchdogInterval = 5;

    // Setup Crash Reporting
    KSCrashInstallationHockey* installation = [KSCrashInstallationHockey sharedInstance];
    [installation addConditionalAlertWithTitle:NSLocalizedString(@"Crash Detected", @"")
                                       message:NSLocalizedString(@"The app crashed last time it was launched. Send a crash report?", @"")
                                     yesAnswer:NSLocalizedString(@"Sure!", @"")
                                      noAnswer:NSLocalizedString(@"No thanks", @"")];

    installation.appIdentifier = [OTRSecrets hockeyLiveIdentifier];
    [installation install];
    [installation sendAllReportsWithCompletion:^(NSArray *filteredReports, BOOL completed, NSError *error)
    {
        if (error) {
            NSLog(@"Error sending KSCrashInstallationHockey reports: %@", error);
        } else {
            NSLog(@"Sending %d KSCrashInstallationHockey reports.", (int)filteredReports.count);
        }
    }];


Provide JSON dependency for plugins.

Plugins will quite often need to work with JSON, especially when working with web services. We should provide a JSON dependency in SpongeAPI so plugins don't need to shade the same dependency over and over again. I think there are basically 2 options:

GSON: This is included in Minecraft already so there would be no additional dependency to shade - there is basically no change for our implementation when we would provide this for plugin developers.
Jackson
...?

I vote Jackson. I've been using it forever and I love it.

Personal preference shouldn't be a factor, I think that practicality here is more important. While I have used both and like both, Gson is shaded with Minecraft and does not need to be distributed further.

I agree with @gratimax here, we should try to keep our distribution as small as possible, if plugin authors want something special they can still package these dependencies together with their plugins.

imo jackson is preferable because it provides more flexibility in how json is parsed and represented. Also take a look at configurate-json and configurate-gson.

gson 2.2.4 is already in the classpath for both implementations use it

I feel like you've closed this prematurely. Sure, Gson is on the classpath, but we haven't answered the question of if it should be an API dependency...

This comes with the assumption that every Minecraft implementation is bundled with GSON. :|

@jamierocks If not, they can just include it when implementing our API.

I was merely pointing out not to include GSON, because Minecraft has it. You should pick the one developers want...

@jamierocks This is pretty much personal preference. If plugin authors want to use a different library they are free to do so, but we provide GSON because we have it already available. We bundle quite a lot of dependencies already, there is no real need for 20MB+ JARs just to bundle every dependency a developer could ever need.


Mark Repositories as belonging to the "Commons"

To discuss

Are repositories within the opendp org, other than the library, considered as part of the commons?
How can we "mark/label" these repositories--perhaps a badge?
Where should a description of the commons live? In this repository?

Q: Where should a descriptions of the commons live?
A: https://docs.opendp.org/en/stable/opendp-commons/index.html

Org vs commons?

Are repositories within the opendp org, other than the library, considered as part of the commons?

It surprised me, but no: Salil writes:

However, the OpenDP Commons should
include the OpenDP Library, but not SmartNoise.  It is more about community
ownership and governance rather than the nature of the software itself.

How to identify?

How can we "mark/label" these repositories--perhaps a badge?

Using a github "topic" would be good: We could link to a complete list. My previous lab, for example.
Where to describe?

Where should a description of the commons live? In this repository?

I'd prefer to leave the description of the opendp commons to the project site. Better to do it in just one place, and do it clearly. The current description of commons on the project site could

have a diagram which accurately indicates what is in the commons. (SmartNoise is not.)
Use the github topic to link to a full list.
Include an operational definition: If this is meaningful, we should be able to say what it is.

opendp
dp-creator
dp-logger

The three repos are tagged.
People can use that link, but as discussed, github repo topics are not something we can control: Anyone can add opendp-commons to their repo. If this is a concern, then you'll need to make use of the organization. One possible way to explain the relationship between projects would be create an organization README, but I think the status quo is fine.
from the github docs:

Create a public repository called .github. Once created, add a /profile/README.md. The README will appear on your organization's profile, visible to anyone.

Closing!


Customize dynamic import paths when compiling JS

Fixes #2500
It doesn't work for TypeScript yet. Got some things to set up before I can properly test it.

Oof there's a test failure w/ path concatenation in some cases. Will fix.

This PR does break some of the tests, unfortunately. Looks like in certain cases, the output directory gets doubled.


SAS-764: renaming of tooblox actions

Replaced by #8491

Please don't merge this yet. We'll let you know once we've released a new version of conversational UI to the Marketplace

This PR is replaced by https://github.com/mendix/docs/pull/8491.


ValueError: Unable to create group (name already exists)

Hi
I'm trying to convert darknet Yolov4-tiny weights to tensorflow weights by running save-model.py script. but I'm facing the following error:
Traceback (most recent call last):
  File "save_model.py", line 58, in <module>
    app.run(main)
  File "/home/danial/.local/lib/python3.6/site-packages/absl/app.py", line 300, in run
    _run_main(main, args)
  File "/home/danial/.local/lib/python3.6/site-packages/absl/app.py", line 251, in _run_main
    sys.exit(main(argv))
  File "save_model.py", line 54, in main
    save_tf()
  File "save_model.py", line 51, in save_tf
    model.save(FLAGS.output)
  File "/home/danial/.local/lib/python3.6/site-packages/tensorflow_core/python/keras/engine/network.py", line 1171, in save
    signatures)
  File "/home/danial/.local/lib/python3.6/site-packages/tensorflow_core/python/keras/saving/save.py", line 109, in save_model
    model, filepath, overwrite, include_optimizer)
  File "/home/danial/.local/lib/python3.6/site-packages/tensorflow_core/python/keras/saving/hdf5_format.py", line 103, in save_model_to_hdf5
    save_weights_to_hdf5_group(model_weights_group, model_layers)
  File "/home/danial/.local/lib/python3.6/site-packages/tensorflow_core/python/keras/saving/hdf5_format.py", line 619, in save_weights_to_hdf5_group
    g = f.create_group(layer.name)
  File "/home/danial/.local/lib/python3.6/site-packages/h5py/_hl/group.py", line 68, in create_group
    gid = h5g.create(self.id, name, lcpl=lcpl, gcpl=gcpl)
  File "h5py/_objects.pyx", line 54, in h5py._objects.with_phil.wrapper
  File "h5py/_objects.pyx", line 55, in h5py._objects.with_phil.wrapper
  File "h5py/h5g.pyx", line 161, in h5py.h5g.create
ValueError: Unable to create group (name already exists)

any idea what's causing this and how to fix it?

Using tensorflow 2 solved the problem 🎉


Copy MathOptLMO

Added method to copy an instance of MathOptLMO.

Codecov Report

Merging #270 (41e791f) into master (4c7d454) will increase coverage by 0.83%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #270      +/-   ##
==========================================
+ Coverage   69.84%   70.67%   +0.83%
==========================================
  Files          14       14
  Lines        1847     1927      +80
==========================================
+ Hits         1290     1362      +72
- Misses        557      565       +8

Impacted Files
Coverage Δ

src/moi_oracle.jl
79.31% <0.00%> (-12.69%)
:arrow_down:

src/norm_oracles.jl
95.79% <0.00%> (-1.77%)
:arrow_down:

src/oracles.jl
86.59% <0.00%> (-1.14%)
:arrow_down:

src/polytope_oracles.jl
98.87% <0.00%> (-1.13%)
:arrow_down:

src/types.jl
67.02% <0.00%> (-0.87%)
:arrow_down:

src/fw_algorithms.jl
77.30% <0.00%> (-0.26%)
:arrow_down:

src/function_gradient.jl
97.05% <0.00%> (-0.17%)
:arrow_down:

src/FrankWolfe.jl

src/pairwise.jl
65.25% <0.00%> (ø)

src/blended_cg.jl
50.93% <0.00%> (+0.54%)
:arrow_up:

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c7d454...41e791f. Read the comment docs.


Add support for damage on weapons

In GitLab by @Asacolips on Oct 4, 2022, 17:40
Summary
Damage on characters is currently controlled via a central damage field in the section with ability scores. This works OK for most use cases due to class-based damage, but weapons with tags that affect the damage in varying ways (+1 damage, piercing 1, etc.) aren't currently supported.
Acceptance Criteria

[ ] Implement a method to roll damage from weapons directly
[ ] Add a way to quickly toggle whether or not a given item is equipped, similar to how spell preparation currently works.

In GitLab by @Asacolips on Jun 5, 2023, 16:40
Implemented in 1.7.0


Severe distortion of point clouds observed by Livox mid360

When I use Livox mid360 and VLP-16, Ouster-64 to simultaneously face the same flat wall, the point cloud observed by Mid360 is a point cloud with severe curvature distortion, which is significantly different from the other two point clouds. This is not the case when using Livox avia. I don't know if there is a problem with my configuration.

当我使用Livox mid360和VLP-16，Ouster-64同时面对同一面平整的墙壁时，Mid360观测到的点云是有弧度的失真严重的点云，和其他两个点云对比明显。当使用Livox avia时则没有这种情况。不知道是不是我哪里配置有问题。

Interesting, do you have any screenshots from your comparison?

maybe your issue is related to https://github.com/Livox-SDK/livox_laser_simulation/issues/3 ?

Here are the pictures. The red point cloud is given by OUSTER-64 while the white is given by Livox Mid360. The red one can be seen as the true value. @georgflick


Getting IR Camera Image and passing it to Python code

Describe the bug

I am trying to use Azure Kinect DK's V3. IR Camera output for use in a deep learning application. My deep learning code is written in Python. Azure Kinect Sensor SDK has provided references in C and C++ only. Hence, I am compelled to get the IR capture using C Reference and send the obtained image buffer (output of k4a_image_get_buffer function) to the Python code via TCP sockets.
The following .BMP image is being obtained. On saving this as .png a completely black image is being saved.

Python and C code Used
C code to use the Sensor SDK to obtain IR capture and send it to the Python Code.
#include "stdafx.h"

#pragma comment(lib,"ws2_32.lib") //Winsock Library
#pragma comment(lib, "k4a.lib")
#include "k4a/k4a.h"
#include <stdio.h>
#include <winsock2.h>
#include <Windows.h>

#include <string.h>
#include <WS2tcpip.h>

int main() {
	k4a_device_t device = NULL;
	k4a_capture_t capture;
	int32_t TIMEOUT_IN_MS = 1349400;
	k4a_device_open(K4A_DEVICE_DEFAULT, &device);
	k4a_device_configuration_t config = K4A_DEVICE_CONFIG_INIT_DISABLE_ALL;
	config.camera_fps = K4A_FRAMES_PER_SECOND_30;
	config.color_format = K4A_IMAGE_FORMAT_COLOR_MJPG;
	config.color_resolution = K4A_COLOR_RESOLUTION_2160P;
	config.depth_mode = K4A_DEPTH_MODE_NFOV_UNBINNED;
	k4a_device_start_cameras(device, &config);

	k4a_device_get_capture(device, &capture, TIMEOUT_IN_MS);

	k4a_image_t image = k4a_capture_get_ir_image(capture);

	int height = k4a_image_get_height_pixels(image);
	int width = k4a_image_get_width_pixels(image);

	uint8_t * imgData = k4a_image_get_buffer(image);

	const uint32_t arr_size = width * height;
	WSADATA wsa;
	SOCKET s;
	WSAStartup(MAKEWORD(2, 2), &wsa);
	s = socket(AF_INET, SOCK_STREAM, 0);
	const char* server_name = "localhost";
	const int server_port = 7000;

	struct sockaddr_in server_address;
	InetPton(AF_INET, _T("<IP_ADDRESS>"), &server_address.sin_addr.s_addr);
	server_address.sin_family = AF_INET;
	server_address.sin_port = htons(server_port);

	connect(s, (struct sockaddr *)& server_address, sizeof(server_address));

	//send array size
	send(s, (char *)&height, sizeof(int), 0);
	printf("sent array size");
	Sleep(3);
	send(s, (char *)&width, sizeof(int), 0);
	printf("sent array size");
	Sleep(3);

	//send array
        uint8_t v8 = 0;
	for (size_t i = 0; i < arr_size; ++i)
	{
		v8 = imgData[i];
		send(s, (char *)&v8, sizeof(uint8_t), 0);  //(char *)&
	}
	printf("sent array values");

	// close the socket
	closesocket(s);
	WSACleanup();
	k4a_image_release(image);
	k4a_device_close(device);
	return 0;
}

Python Code for receiving the image buffer and displaying the image.
import socket
import struct
from sys import getsizeof
import numpy as np
from PIL import Image

TCP_IP = '<IP_ADDRESS>'
TCP_PORT = 7000
BUFFER_SIZE =1024  # Normally 1024, but we want fast response

s = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
s.bind((TCP_IP, TCP_PORT))
s.listen(1)

conn, addr = s.accept()
print('Connection address:', addr)
flag = 0

while 1:
    if(flag==0):
        height = conn.recv(BUFFER_SIZE)
        height = int.from_bytes(height, "little")
        if not height: break
        print("received data height: ", height)
        flag = 1
    elif(flag == 1):
        print("flag == 1")
        width = conn.recv(BUFFER_SIZE)
        width = int.from_bytes(width, "little")
        if not width: break
        print("\nreceived data width: ", width)
        flag = 2
    else:
        print("else")
        #f = open('picture_out.txt', 'w+')
        array = np.arange(height*width)
        col = 0
        for i in range(height*width):
            v8 = conn.recv(1)
            if not v8: break
            array[col] = struct.unpack('B', v8)[0]
            col += 1
        flag = 0
        array =  array.reshape(height, width)
        print(array)
        img = Image.fromarray(array)
        img.save('my.png')
        img.show()
conn.close()

Expected behavior

A clearer image is required which can be saved as .png or .jpg The image should just as the IR Camera image as shown in the Kinect Viewer Tool. I am not sure what is the mistake I am doing.  Any help is highly appreciated. Are there any other sample examples of capture are also helpful. Please advice.

Desktop (please complete the following information):

OS with Version:  Windows 10 Pro 1803
SDK Version:   Azure Kinect Sensor SDK v1.1.0
Firmware version:
Device Serial Number:<PHONE_NUMBER>12
Current Firmware Versions:
RGB camera firmware:      1.6.98
Depth camera firmware:    1.6.70
Depth config file:        6109.7
Audio firmware:           1.6.14
Build Config:             Production
Certificate Type:         Microsoft

@MrudulaSatya the k4a_capture_get_ir_image function return a k4a_image_t contains the type of image format K4A_IMAGE_FORMAT_IR16 (search k4a_image_format_t in the https://microsoft.github.io/Azure-Kinect-Sensor-SDK/master/index.html), and the buffer size should be height * stride_bytes (you can use the k4a_image_get_stride_bytes to get the stride_bytes). Another way is you can cast the buffer to uint16_t* and index using width and height. Later if you need to convert the IR16 image to grayscale, you may need to normalize it with some dynamic range that appropriate to your visualization. Let us know whether that solved your issue and whether the current API documents help you here (or will talk to the team to improve the documents)

Still receiving a granulated image.
Steps performed -

Changed the buffer size to stride_bytes * height
Normalized the image using opencv.normalize function. Tried various parameter configurations.

Could you please tell how the k4a Viewer is able to display such clear IR images? What is the image processing going behind it? I feel if I perform the same image processing, I also might end up getting such quality IR images.
It would really help fast-forward my job if you could provide some sample example code snippets to accomplish this task.
Any clue/help will be highly appreciated in this regard.
Thank you

The depth data from the camera uses 16-bit unsigned pixels. It looks like your python code is interpreting each byte as a pixel.

@MrudulaSatya , as I mentioned, the IR image is uint16_t data, even you fixed the buffer size with the right stride for the copy, through the socket, you still need to cast the buffer to uint16_t* in your client and then if you want to do just linear mapping from uint16_t to grayscale by using some min/max value you prefer. The azure kinect viewer code is open sourced, here is the link to the function ColorizeGreyscale (https://github.com/microsoft/Azure-Kinect-Sensor-SDK/blob/develop/tools/k4aviewer/k4adepthpixelcolorizer.h), you can search this function in the k4aviewer source code under tools

@MrudulaSatya , please let us know whether the information we provided in this thread helped you solve your issue. Also, related to your ask for the example code, the k4aviewer source code which displays the clean IR is a good example you can take a look (it is under tools/k4aviewer).

This is C code i am using to get a proper IR image -

#include "stdafx.h"

#pragma comment(lib,"ws2_32.lib") //Winsock Library
#pragma comment(lib, "k4a.lib")
#include "k4a/k4a.h"
#include <stdio.h>
#include <winsock2.h>
#include <Windows.h>
#include <opencv2/highgui/highgui.hpp>
#include <string.h>
#include <WS2tcpip.h>
using namespace cv;

int main() {
	k4a_device_t device = NULL;
	k4a_capture_t capture;
	int32_t TIMEOUT_IN_MS = 1349400;
	k4a_device_open(K4A_DEVICE_DEFAULT, &device);
	k4a_device_configuration_t config = K4A_DEVICE_CONFIG_INIT_DISABLE_ALL;
	config.camera_fps = K4A_FRAMES_PER_SECOND_30;
	config.color_format = K4A_IMAGE_FORMAT_COLOR_MJPG;
	config.color_resolution = K4A_COLOR_RESOLUTION_2160P;
	config.depth_mode = K4A_DEPTH_MODE_NFOV_UNBINNED;
	k4a_device_start_cameras(device, &config);

	k4a_device_get_capture(device, &capture, TIMEOUT_IN_MS);
	k4a_image_t image = k4a_capture_get_ir_image(capture);
	int height = k4a_image_get_height_pixels(image);
	int width = k4a_image_get_width_pixels(image);
	int strides = k4a_image_get_stride_bytes(image);
	printf(" height: %d , %d ", height, width);
	printf("stride: %d", strides);
	uint8_t * imgData = k4a_image_get_buffer(image);
	uint8_t * imgdata2 = (uint8_t*)malloc(strides*height*sizeof(uint8_t));
	for (int i = 0; i < strides*height; i++) {
		uint16_t pixelValue = *((uint16_t*)(imgData + i));
		uint8_t nv = static_cast<uint8_t>((pixelValue - 0) * (double(65535) / (65535- 0)));
		imgdata2[i] = nv;
	}
	const cv::Mat img(cv::Size(strides, height), CV_8U, imgdata2);

	cv::namedWindow("foobar");
	cv::imshow("foobar", img);
	cv::waitKey(0);

	k4a_image_release(image);
	k4a_device_close(device);
	return 0;
}

Obtained image:

Could you please guide me through the image processing that need to be done in order to show a proper IR image?
Thank you!

Thank you very much @rabbitdaxi  My problem is solved.


-m option not documented in mbusd's man page

Hi,
I was looking for a configuration option for serial parity bits and only found it in the source code. Maybe it should be added to the man page as well.
Best regards & thanks for the good work

Hmm, but -m option description should be already present in man page: https://github.com/3cky/mbusd/blob/master/doc/mbusd.8.in#L52-L53
Also it should be described in command help (-h). Could you check that mbus is compiled using latest sources?

Yep. I accidently used an older version that was still sitting in my download directory. Sorry about that.
Anyway, thanks for the quick reply :)

OK, no problem! :)


Merge some fork improvements

It will be interesting to merge some of the fork improvements.
This one is the best candidate: https://github.com/danielbair/create-dmg.
Uses improvements from https://github.com/schoeps/create-dmg.

#66


Assign current and future Zowe Docs articles for V3 tracking

Assign ownership of all current and future articles to tech writers. This helps the Doc Squad aware of who is in charge of shepherding a particular topic or article through the Zowe V3 doc upgrade process.

Zowe Docs content has been assigned to individual writers/SMEs to determine what changes, if any, are needed to make the content ready for Zowe V3


Blog where you list down all your projects / research work

What projects have I worked upon? What tech stack have I used in them? What is my level of understanding?

https://jovian.ai/ayushxx7/numpy-array-operations


PoC: Accept partial fill for bids

Description
Add 2 new modals when we accept a bid:

1 modal to confirm the cancelation of the bid
1 modal with a form to select the quantity we want to accept (if there is more than one quantity available)

This allows having partial fill even on the bids.
How to test
Place a bid requesting multiple editions on an ERC1155, then connect to an account(s) that can fill this bid (even partially), then accept the bid. You should have a popup with a form to let you choose how much you want to accept
TODO:

[ ] Improve text as this is just a PoC and I haven't spent any time on the text, just copied from the checkout page
[ ] Check actual balance of the user accepting the bid

@EmmanuelDrouin I would like some confirmation in terms of flow/ux from this proof of concept

Got error 500 on all deployment, waiting for this to be back to normal to start testing this PR ;)

You should be good to go now, the branch was not up to date

 Partial fill for Bids


/photos thumbnail has different color

The original image and the thumbnail of it always have a different color, which is confusing and makes one think the example code has some problems.

That's a good point 👍 I'll see what can be done.

I've greatly enjoyed this service so far, but also felt like it could benefit from having the same color for the thumbnail and full size images. I updated the data file accordingly, let me know if that's adequate. It seems like that's all there is to it.

@shortstuffsushi Thank you :+1:  :) merging it


npm run build gives errors

Maybe just on my computer, but I get this on a freshly cloned copy of this repo:
$ npm run build

><EMAIL_ADDRESS>build C:\temp\react-redux-typescript-starter-kit
> npm run build:app && npm run build:vendor

><EMAIL_ADDRESS>build:app C:\temp\react-redux-typescript-starter-kit
> npm run _jspm-build-app -- --skip-source-maps --minify

><EMAIL_ADDRESS>_jspm-build-app C:\temp\react-redux-typescript-starter-kit
> jspm build src/app - bundle-config.vendor.js dist/app.js "--skip-source-maps" "--minify"

module.js:457
    throw err;
    ^

Error: Cannot find module 'C:\Temp\react-redux-typescript-starter-kit\node_modules\jspm\jspm.js'
    at Function.Module._resolveFilename (module.js:455:15)
    at Function.Module._load (module.js:403:25)
    at Module.runMain (module.js:590:10)
    at run (bootstrap_node.js:394:7)
    at startup (bootstrap_node.js:149:9)
    at bootstrap_node.js:509:3

Forget about it, forgot to run npm install after I cloned the repo! I still have trouble getting the build to run in my project that is based on this starter but that is probably related to some changes I made outside of the starter-kit. Sorry for the non-issue!


Fails to load extension at startup: java.lang.ClassCastException

Proposal
When registering the extension in the Standalone context, the extension loading fails with this error:
Exception in thread "main" java.lang.ClassCastException: class org.wiremock.extensions.state.StandaloneStateExtension cannot be cast to class com.github.tomakehurst.wiremock.extension.Extension (org.wiremock.extensions.state.StandaloneStateExtension and com.github.tomakehurst.wiremock.extension.Extension are in unnamed module of loader 'app')
        at com.github.tomakehurst.wiremock.extension.Extensions.load(Extensions.java:182)
        at java.base/java.util.stream.ReferencePipeline$3$1.accept(Unknown Source)
        at java.base/java.util.stream.ReferencePipeline$3$1.accept(Unknown Source)
        at java.base/java.util.ArrayList$ArrayListSpliterator.forEachRemaining(Unknown Source)
        at java.base/java.util.stream.AbstractPipeline.copyInto(Unknown Source)
        at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(Unknown Source)
        at java.base/java.util.stream.StreamSpliterators$WrappingSpliterator.forEachRemaining(Unknown Source)
        at com.google.common.collect.CollectSpliterators$FlatMapSpliterator.lambda$forEachRemaining$1(CollectSpliterators.java:378)
        at java.base/java.util.Spliterators$ArraySpliterator.forEachRemaining(Unknown Source)
        at com.google.common.collect.CollectSpliterators$FlatMapSpliterator.forEachRemaining(CollectSpliterators.java:374)
        at java.base/java.util.stream.AbstractPipeline.copyInto(Unknown Source)
        at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(Unknown Source)
        at java.base/java.util.stream.ForEachOps$ForEachOp.evaluateSequential(Unknown Source)
        at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(Unknown Source)
        at java.base/java.util.stream.AbstractPipeline.evaluate(Unknown Source)
        at java.base/java.util.stream.ReferencePipeline.forEach(Unknown Source)
        at com.github.tomakehurst.wiremock.extension.Extensions.load(Extensions.java:72)
        at com.github.tomakehurst.wiremock.core.WireMockApp.<init>(WireMockApp.java:99)
        at com.github.tomakehurst.wiremock.WireMockServer.<init>(WireMockServer.java:70)
        at com.github.tomakehurst.wiremock.standalone.WireMockServerRunner.run(WireMockServerRunner.java:70)
        at wiremock.Run.main(Run.java:23)

Reproduction steps
Run:
java -cp wiremock-state-extension-standalone-0.0.4.jar:wiremock-standalone-3.0.0-beta-11.jar wiremock.Run --global-response-templating --extensions org.wiremock.extensions.state.StandaloneStateExtension

References
Wiremock version used: https://repo1.maven.org/maven2/org/wiremock/wiremock-standalone/3.0.0-beta-11/wiremock-standalone-3.0.0-beta-11.jar

the parameter --extensions org.wiremock.extensions.state.StandaloneStateExtension is not needed. The plugin should be discoverable via the ServiceLoader interface. For me, it starts fine with java -cp wiremock-state-extension-standalone-0.0.4.jar:wiremock-standalone-3.0.0-beta-11.jar wiremock.Run --global-response-templating. Can you check whether it works for you as well?

When running this: java -cp wiremock-state-extension-standalone-0.0.4.jar:wiremock-standalone-3.0.0-beta-11.jar wiremock.Run --global-response-templating, I am getting this error:
Exception in thread "main" com.github.tomakehurst.wiremock.standalone.MappingFileException: Error loading file /home/wiremock/./mappings/test-state.json:
Unrecognized field "withServeEventListener" (class com.github.tomakehurst.wiremock.stubbing.StubMappingCollection), not marked as ignorable
        at com.github.tomakehurst.wiremock.standalone.JsonFileMappingsSource.loadMappingsInto(JsonFileMappingsSource.java:123)
        at com.github.tomakehurst.wiremock.core.WireMockApp.loadMappingsUsing(WireMockApp.java:250)
        at com.github.tomakehurst.wiremock.core.WireMockApp.loadDefaultMappings(WireMockApp.java:246)
        at com.github.tomakehurst.wiremock.core.WireMockApp.<init>(WireMockApp.java:129)
        at com.github.tomakehurst.wiremock.WireMockServer.<init>(WireMockServer.java:70)
        at com.github.tomakehurst.wiremock.standalone.WireMockServerRunner.run(WireMockServerRunner.java:70)
        at wiremock.Run.main(Run.java:23)

As for test-state.json, i've used the example provided in the readme.md:
{
  "request": {
    "method": "POST",
    "url": "/test",
    "headers": {
      "content-type": {
        "contains": "json"
      },
      "accept": {
        "contains": "json"
      }
    }
  },
  "response": {
    "status": 200,
    "headers": {
      "Content-Type": "application/json"
    },
    "jsonBody": {
      "id": "{{randomValue length=32 type='ALPHANUMERIC' uppercase=false}}",
      "firstName": "{{jsonPath request.body '$.firstName'}}",
      "lastName": "{{jsonPath request.body '$.lastName'}}"
    }
  },
  "withServeEventListener": [
    {
      "name": "recordState",
      "parameters": {
        "context": "{{jsonPath response.body '$.id'}}",
        "state": {
          "id": "{{jsonPath response.body '$.id'}}",
          "firstName": "{{jsonPath request.body '$.firstName'}}",
          "lastName": "{{jsonPath response.body '$.lastName'}}"
        }
      }
    }
  ]
}

There was a bug in the documentation: withServeEventListener -> serveEventListeners . Your example should therefore be:
{
  "request": {
    "method": "POST",
    "url": "/test",
    "headers": {
      "content-type": {
        "contains": "json"
      },
      "accept": {
        "contains": "json"
      }
    }
  },
  "response": {
    "status": 200,
    "headers": {
      "Content-Type": "application/json"
    },
    "jsonBody": {
      "id": "{{randomValue length=32 type='ALPHANUMERIC' uppercase=false}}",
      "firstName": "{{jsonPath request.body '$.firstName'}}",
      "lastName": "{{jsonPath request.body '$.lastName'}}"
    }
  },
  "serveEventListeners": [
    {
      "name": "recordState",
      "parameters": {
        "context": "{{jsonPath response.body '$.id'}}",
        "state": {
          "id": "{{jsonPath response.body '$.id'}}",
          "firstName": "{{jsonPath request.body '$.firstName'}}",
          "lastName": "{{jsonPath response.body '$.lastName'}}"
        }
      }
    }
  ]
}

That was it, the extension loads properly now 👍

merged.


[Feat]: Add a temporary spell slot / point consumer

I feel like we should provide a temporary solution to actors consuming spell slots/points and exertion for 0.9.0 while we implement a proper resource consumer in 1.0.0

Closing in favor or a more specific issue.


Added ThreadLocalScopeManager

Impact

[ ] Bug fix (non-breaking change which fixes expected existing functionality)
[X] Enhancement/New feature (adds functionality without impacting existing logic)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Description
By default, Liquibase uses SingletonScopeManager which is designed to be a single scope regardless of threads going on in the application. That works fine for single-threaded applications and use cases in a multi-threaded application, but for other multi-threaded applications it does not work.
This adds a liquibase.ThreadLocalScopeManager class which custom integrations can use to replace the default SingletonScopeManager with a call to Scope.setScopeManager(new ThreadLocalScopeManager()).
Things to be aware of

Code and tests are based on https://github.com/bvremmeinfor/liquibase-threading-demo as well as discussion in #2248.
New class is only used via external integration work

Things to worry about

Is there more areas of the code that is not thread safe?

The test is a relatively complete "end to end" test that hits a lot of the main Factories, but there can always be problems elsewhere
We can address them after this is released if/when anyone finds cases

Additional Context
Fixes #2018
Fixes #2248

The failing pro-tests and test-harness tests are unrelated to this change

Hi @nvoxland, this looks good! Now there is hope :-)
Tested on https://github.com/bvremmeinfor/liquibase-threading-demo/tree/liquibase_pr_3240_test branch using snapshot build of #3240 (with public ThreadLocalScopeManager constructor).
Could simplify code in test project and use official implementations. Nice!
Repeated stress tests performed - 100% success.
Thank you!


[BugFix] fix bug when apache doesn't return the version in response header

What does this PR do?

This patch fixes https://github.com/DataDog/integrations-core/issues/5266.
Motivation

Additional Notes

Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] PR title must be written as a CHANGELOG entry (see why)
[ ] Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
[ ] PR must have changelog/ and integration/ labels attached

Thanks for your patch. I'll think we'll go ahead with #5252.


Fix variable failure from xref without format

Signed-off-by: Robert D Anderson<EMAIL_ADDRESS>I have an external link without a specified @format. This is to a DITA topic so defaulting to dita is fine for the value.
The topicpull step sets format with a variable, and expects an xs:string result:
<xsl:variable name="format" as="xs:string"
           select="dita-ot:get-link-format(.)"/>

However, the function call does not pass in a default, and the function itself (with or without the default) is set to return optional xs:string?. My test case below returns an empty value, and results in the build error:
[topicpull] Failed to transform document: An empty sequence is not allowed as the value of variable $format
The fix just updates the variable to expect an optional value, which is what the function already declares.
Test document:
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE topic PUBLIC "-//OASIS//DTD DITA Topic//EN"  "topic.dtd">
<topic id="topic" xml:lang="en-us">
<title>Test external DITA xref</title>

Try this out: <xref
href="https://www.ibm.com/support/knowledgecenter/SSFHJY_1.0.6/using/text/document/d_changing_the_default_file_format.dita"
scope="external"/>

</topic>

The PR should go to either a bug fix branch or develop, not master. Please change the target branch.

Yeah, it was intended for 2.5.4 but we don't have that yet so I did it against master. I need to create the branch and fix that...

Created hotfix/2.5.4 and changed the PR to target that.


com.sap.cloud.sdk.datamodel:odata-generator-maven-plugin:5.14.0-SNAPSHOT doesn't exist in Central maven repo

Issue Description
Hi there! I'm planning to setup cloud-sdk-java in my local env. to have a better understanding on datamodel components(generating OData client). But I'm facing an issue where com.sap.cloud.sdk.datamodel:odata-generator-maven-plugin:5.14.0-SNAPSHOT maven dependency doesn't exist. Any hints or alternative solutions?
Important information:

Maven Dependency for cloud-sdk-java

Impact / Priority
Affected development phase: Development
Impact:Blocked
Timeline: Have to prepare "code ready examples by 6 weeks"
Error Message
Cannot resolve plugin com.sap.cloud.sdk.datamodel:openapi-generator-maven-plugin:5.14.0-SNAPSHOT

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for SAP Cloud SDK - Parent POM 5.14.0-SNAPSHOT:
[INFO]
[INFO] SAP Cloud SDK - Parent POM ......................... SUCCESS [  6.195 s]
[INFO] Archetypes - Parent POM ............................ SUCCESS [  0.907 s]
[INFO] Archetypes - SAP CP Cloud Foundry + Spring Boot 3 .. SUCCESS [  0.018 s]
[INFO] SAP Cloud SDK - Modules and Dependencies BOM ....... SUCCESS [ 11.591 s]
[INFO] Cloud Platform - Parent POM ........................ SUCCESS [  0.023 s]
[INFO] Cloud Platform - Core .............................. SUCCESS [  0.650 s]
[INFO] Business Technology Platform - Security ............ SUCCESS [  4.107 s]
[INFO] Cloud Platform - Tenant ............................ SUCCESS [  0.044 s]
[INFO] (Internal) Test Utilities .......................... SUCCESS [  0.068 s]
[INFO] Business Technology Platform - Caching ............. SUCCESS [  0.026 s]
[INFO] Cloud Platform - Resilience API .................... SUCCESS [  0.025 s]
[INFO] Business Technology Platform - Connectivity ........ SUCCESS [  0.106 s]
[INFO] Connectivity - Apache HTTP Client 4 ................ SUCCESS [  0.187 s]
[INFO] Connectivity - Zero Trust Identity Service ......... SUCCESS [  0.644 s]
[INFO] Cloud Platform - Resilience4j ...................... SUCCESS [  0.359 s]
[INFO] Cloud Platform - Resilience API and Default Implementation SUCCESS [  0.039 s]
[INFO] OAuth2 Connectivity ................................ SUCCESS [  0.130 s]
[INFO] Cloud Platform - Servlet Jakarta compatible ........ SUCCESS [  0.020 s]
[INFO] Cloud Platform - Connectivity SAP BTP Cloud Foundry  SUCCESS [  0.034 s]
[INFO] Core Features of the SAP Cloud SDK ................. SUCCESS [  0.025 s]
[INFO] (Deprecated) Business Technology Platform - SAP BTP Cloud Foundry SUCCESS [  0.017 s]
[INFO] (Deprecated) Cloud Platform - Connectivity SAP BTP Cloud Foundry SUCCESS [  0.019 s]
[INFO] Deploy with Confidence Connectivity ................ SUCCESS [  0.016 s]
[INFO] Apache version 5 Http Client integration ........... SUCCESS [  0.027 s]
[INFO] (Deprecated) Cloud Platform - SAP Deploy with Confidence on Cloud Foundry SUCCESS [  0.018 s]
[INFO] Data Model - Parent POM ............................ SUCCESS [  0.006 s]
[INFO] Data Model - Fluent Result ......................... SUCCESS [  0.007 s]
[INFO] Data Model - OData Services - Client ............... SUCCESS [  0.020 s]
[INFO] Data Model - OData Services - Parent POM ........... SUCCESS [  0.006 s]
[INFO] Data Model - OData Services - Core ................. SUCCESS [  0.021 s]
[INFO] Data Model - Metadata Generator (Beta) ............. SUCCESS [  0.178 s]
[INFO] OData Utility ...................................... SUCCESS [  0.015 s]
[INFO] Data Model - OData Services - Generator ............ SUCCESS [  0.439 s]
[INFO] Data Model - OData Services - Generator Maven Plugin SUCCESS [  2.113 s]
[INFO] OData VDM - Sample API ............................. SUCCESS [  0.052 s]
[INFO] Data Model - OData V4 Services - Parent POM ........ SUCCESS [  0.007 s]
[INFO] Data Model - OData V4 Services - Core .............. SUCCESS [  0.036 s]
[INFO] Data Model - OData V4 Services - Generator ......... SUCCESS [  0.216 s]
[INFO] Data Model - OData V4 Services - Generator Maven Plugin SUCCESS [  0.054 s]
[INFO] OData V4 VDM - Sample API .......................... SUCCESS [  0.053 s]
[INFO] Data Model - SOAP Queries .......................... SUCCESS [  1.081 s]
[INFO] Data Model - OpenAPI Services - Parent POM ......... SUCCESS [  0.013 s]
[INFO] Data Model - OpenAPI Services - Core ............... SUCCESS [  0.149 s]
[INFO] Data Model - OpenAPI Services - Generator .......... SUCCESS [  1.605 s]
[INFO] Data Model - OpenAPI Services - Generator Maven Plugin SUCCESS [  0.090 s]
[INFO] Data Model - OpenAPI Services - Sample API ......... SUCCESS [  0.035 s]
[INFO] SAP Cloud SDK - Modules BOM ........................ SUCCESS [  0.005 s]
[INFO] SAP S/4HANA - Parent POM ........................... SUCCESS [  0.006 s]
[INFO] SAP S/4HANA - Core ................................. SUCCESS [  0.009 s]
[INFO] SAP S/4HANA - Connectivity ......................... SUCCESS [  0.015 s]
[INFO] SAP S/4HANA - RFC Queries .......................... SUCCESS [  0.196 s]
[INFO] ------------------------------------------------------------------------

Project Details

SDK Version:

Link to GitHub repo:
Project type, for example:

[ ] CAP Project
[X] SDK Maven Archetype
[ ] None of the above:

Platform:

[ ] Cloud Foundry
[ ] Deploy with Confidence (Cloud Foundry)
[ ] None of the above:

Checklist

[X] Checked out the documentation and Stack Overflow
[X] Description provided with all relevant information
[X] Exception and stack trace provided
[X] Attached debug logs
[X] Attached dependency tree
[ ] Provided Cloud SDK version & link to relevant source code

The issue is difficult to understand, but I'm assuming:

You are building the SAP Cloud SDK locally on your computer.

Did you use mvn install? Otherwise the compiled artifacts will not be available in your local ~/.m2 (default) repo.

You are invoking the odata-generator-maven-plugin.

Do you run it on same machine where the mvn install was running?

SNAPSHOT version cannot be found

Can you double check whether there a JAR file for odata-generator-maven-plugin somewhere deep in your local ~/.m2 directory?


Create a 5:32 Decoder

Design: 25 points

can u pls assign this to me @sujith27pes

!assign @sujith27pes 60

!withdraw

please assign this to me

!assign @tvs-tanmay


Log with target instead of module path by default?

Thelog macro sets the target to the module path by default but only allows users to override the target.  By using the target instead of the module path in the default formatter an end user could trivially modify the default format.
Thoughts?

I'm not certain I understand the full implications of this change. @KodrAus wdyt?

It sounds like it is confusing that we're using the module path instead of the target, especially since they're usually the same.
I'd be happy to change the default format to use the target instead.

It sounds like it is confusing that we're using the module path instead of the target, especially since they're usually the same.
I'd be happy to change the default format to use the target instead.


TypeScript support for type-checking

I've successfully used swc to compile typescript files, that's great. I'm thoroughly impressed!
However, I noticed it compiled "wrong" typescript. Example:
function foo(): string {
}

^ is invalid typescript (the function actually returns void), but this will still compile fine with swc.
I'm assuming this is a lot more complicated to make happen. You'd have to check keep track of the type signature of every function and variables to compare and check type validity.

@kdy1 have you evaluated how much a moving target typescript really is?

@sledorze I didn't, but in one blog post they said they co-operated with babel team to make babel understand typescript. So I think trancompiler is not that hard to follow.
I'm not sure about type system though. Type system of typescript seems to be changing frequently..

@kdy1 yes the type system is changing frequently and is not sound, full of corner cases; I'm guessing that it's a herculean job..

Typescript's type system gets new improvements with every minor version release.  I don't see how it'd be a viable strategy for an alternative implementation to keep up with them - even if you have enough resources to keep up, you'd have to match it quirk for quirk to actually be compatible.
A lot of people separate transpiling and typechecking in their tools anyway - with some webpack plugins (awesome-typescript-loader) even forking separate processes to report typecheck errors outside the normal rebuild flow.  So I don't think this is a necessary feature, though certainly a project that just tried to speed up typescript's typechecking would be appreciated.

That makes sense! I didn't realize it changed so often. Now I just wish typescript would want to contribute and use this instead of their own checker.
Feel free to disregard this issue :)


Major search is buggy

clicking on 2 digit code yields nothing

http://beta.datausa.io/search/?
4 digit course doesn't display everything

Double scroll bars present for 6 digit code level

Expanding on this- all selections of industries/occupations have this issue.


Feature: Delete profile

Type of feature
🍕 Feature
Current behavior
There is no method showing a way to delete your profile or remove your user.
I faced this when I was trying to reproduce: https://github.com/open-sauced/insights/issues/1296
Suggested solution
Add a delete option in the settings.
https://insights.opensauced.pizza/user/a0m0rajab
Additional context
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Contributing Docs

[ ] I agree to follow this project's Contribution Docs

I second this @a0m0rajab
I indeed craved this feature in 'development', I needed it because I wanted to test out the onboarding experience again.
I deleted the OAuth app from my GitHub, but obviously wasn't enough, because my user data already existed on the DB, so onboarding over again wasn't possible, unless this data gets deleted.
This one is for sure gonna need api update

I'd like to work on this, though I think this issue should be moved to https://github.com/open-sauced/api

Hold off on work on this one at the moment. Will provide an update when necessary

This will be completed in #1990


Create login

Log in with username/e-mail and password.
Superadmins can be redirected to the back end. If no site is selected for users, present them with a site selection. If has only access to one site, redirect to this site immediately.

@sascha11110 closing this issue. Please reopen if this is premature.


Is it possible to implement a n-1 relationship bringing only one value instead of the array?

Hey, thanks for this lib. I was doing one myself but yours is way better.
Is there a way to custom the name or even the return for this? I am trying to fetch n-1 relationship in a way like below:
    let items = await query.withRelations(
      knex('users'),
      'userId',
      'userId',
    );

    items = items.map(({ users, ...item }) => {
      return {
        ...item,
        user: users[0],
      };
    });

You may see that I did the map to treat the way I want it back. How do you think we can tackle it in a good way? I can implement it and send a PR if you think that's a good idea.

Hi, thank you for a great suggestion. Your idea sounds interesting. If you create a pull request for this, I'm happy to merge it!
If you make this library (including the current implementation fix) TypeScript friendly more, it should be nice (not mandatory for now).
Also, don't forget to write a test. Thanks!

Hey @acro5piano I am playing around with it in order to propose a code. There are also two other scenarios that it would be good but I am still without answer for them. How would you solve it?!

several relations:

    const item = await query
      .first()
      .withRelations(connection('users'), 'userId')
      .withRelations(connection('agents'), 'userId')

This one gives error: query.first(...).withOne(...).withOne is not a function
I guess it happens as the function returns the object instead of the this.

nested items:

return query
      .withRelations(connection('agents'), 'agentId')
      .withRelations(
        connection('users'),
        'agents.userId',
      )

@ericmaicon Hi, sorry for my slow response.

I think you need to pass two arguments to withRelations in general.
Current API seems no to allow it. Let me check.

I'll try to work on them.

@ericmaicon
Hi, I've implemented the feature and also did a lot of refactoring the code.
v2.0.0 introduces withHasOneRelation method. In your case, it works like the following code. Can you try it?
let items = await query.withHasOneRelation(
  knex('users'),
  'userId',
  'userId',
  { as: 'user' }
);

I think it solves almost everything I am trying to implement.
The only thing I think is missing is the nested with*Relation. I can't use that twice in the same query as you are using the .then.
https://github.com/acro5piano/knex-with-relations/blob/main/src/knex-extends/withHasOneRelation.ts#L31
I was trying to solve it below before send a PR:
knex.QueryBuilder.extend(
  'withOne',
  function withOne(this, query: Knex.QueryBuilder, fieldName: string) {
    if (!this._relations) {
      this._relations = [];
    }

    this._relations.push({
      query,
      fieldName,
      name: fieldName.replace('Id', ''),
      single: true,
    });

    return this;
  },
);

knex.QueryBuilder.extend(
  'withMany',
  function withMany(this, query: Knex.QueryBuilder, fieldName: string) {
    if (!this._relations) {
      this._relations = [];
    }

    this._relations.push({
      query,
      fieldName,
      name: pluralize(fieldName.replace('Id', '')),
    });

    return this;
  },
);

const _then = QueryBuilder.prototype.then;

QueryBuilder.prototype.then = async function then(onFulfilled, onRejected) {
  const rows = await _then.call(this, onFulfilled, onRejected);

  if (this._relations) {
    ....
  }

  return rows;
}

I was facing problem on the rows though. It wasn't return the results for me.


router.navigate trigger: false behaving oddly in child routers.

http://plnkr.co/edit/rlrl44myolUbvedl5Sit?p=preview

Navigate to the Child Router.

Notice that the Activate Count is 2.

Click the Click Me! button.

Notice that the Activate Count is 3

should be 2 since activate shouldn't have been called.

Click the Click Me! button.

Notice that the Activate Count is 3

this is inconsistent with the previous click

Click the Welcome nav button in the Child Router.

Notice that the Activate Count is 4

unclear if this is expected... seems like not since I am already on the welcome page

Click the Click Me! button.

Notice that the Activate Count is 5

it seems that navigating away from the page and back resets it to the broken behavior

@Zoltu I see that this issue is from a while back. Is the current version still causing a problem?

Ok, I took a look. The reason you are seeing that behavior is that you actually have two different routes and you are switching back in forth between them, even though the map to the same module. As a result you get activations.

@EisenbergEffect Is there a workaround for this?

Note: I just re-read my instructions and I realized that you can better see the problem by clicking between the Child Router nav button and the Click Me! button.  If you click either of them twice in a row there is no counter bump.  If you alternate between them it bumps every time.

When I navigate to the route child-router it ends up routing to child-router/welcome due to that being the default route for child-router.  So the initial route is child-router, the final route is child-router/welcome.  Once on that page I then navigate to welcome from within child-router which will take me back to child-router/welcome.  This results in another activation.
Am I correct in understanding that activation depends on the original route rather than the final route?  This is unexpected behavior.  I would expect activation to depend on the final route, not the initial route.
The current behavior is problematic because the welcome page doesn't know about the full routing system, it only knows about its own route (welcome).  The fact that it is in a child router should be something that it shouldn't need to know anything about.  With the current behavior though, it seems I am forced to have my views know about the routing system which seems like a really bad pattern to fall into because it destroys isolation of components.
My real-world scenario is that the page needs to update the query string as the user interacts with the page so they can always get back to the current state they left at by just bookmarking the page or copying the URL.  In order to update the page, I am doing this.router.navigate('this-view-name?${queryString}', { trigger: false }).  Currently though, this causes activate to be called again the first time the user touches the page which currently has side effects that are problematic when the page is already activated.  After the first touch they can interact with the page without problem.


ansible-language-server: init at 1.0.2-next.0

Description of changes
Freeing the ansible-language-server from the annoying node package set.

Things done

Built on platform(s)

[x] x86_64-linux
[x] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

I believe this broke evaluation and is blocking unstable-* channels: https://hydra.nixos.org/log/ivq96d98h26vk1nmidlrh8135i6zhkbz-nixpkgs-tarball-23.05pre432505.20902ee4d67.drv
On a quick glance, overrides.nix keeps referencing stuff removed from node-packages.nix.


TextStyle of the actual text is not changing

when i specify the style field for changing the textStyle it happens nothing and the textStyle is not changing.
its working for setting the more and less textStyle but not for the text itself.

Can you provide a minimal code please?
I just run the example code changed the color and pressed hot reload (which equals to setState call) and it worked

yes i tryed and its not working. So i just experimented some stuff right now.
As you see when i have the style like this, getting it from Theme style: Theme.of(context).textTheme.titleSmall?.copyWith(color:Colors.amber),
its not working, but if i do it like this not getting it from Theme its actually working style: TextStyle(color: Colors.amber),
but in otherhand specifying the moreStyle and lessStyle as you see its working.
i am wodering why is it not the case with style field as well?
      text,
      trimMode: TrimMode.Line,
      trimLines: 2,
      trimCollapsedText: 'mehr',
      trimExpandedText: ' wenig',
      style: Theme.of(context).textTheme.titleSmall?.copyWith(color:Colors.amber),
      moreStyle: Theme.of(context)
          .textTheme
          .titleSmall
          ?.copyWith(fontWeight: FontWeight.bold),
      lessStyle: Theme.of(context)
          .textTheme
          .titleSmall
          ?.copyWith(fontWeight: FontWeight.bold),
    );```

so somehow i have to do it like this instead of copying the textStyle and just change the color.
        color: Colors.amber,
        fontSize: Theme.of(context).textTheme.titleSmall?.fontSize,
        fontFamily: Theme.of(context).textTheme.titleSmall?.fontFamily,
      ),```

Here is a minimal code, and it seems everything is working as intended:
import 'package:flutter/material.dart';
import 'package:readmore/readmore.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return const MaterialApp(
      debugShowCheckedModeBanner: false,
      home: DemoApp(),
    );
  }
}

class DemoApp extends StatefulWidget {
  const DemoApp({super.key});

  @override
  State<DemoApp> createState() => _DemoAppState();
}

class _DemoAppState extends State<DemoApp> {
  bool isAmber = false;

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(),
      floatingActionButton: ElevatedButton(
        onPressed: () => setState(() => isAmber = !isAmber),
        child: const Text('Change style'),
      ),
      body: ReadMoreText(
        'Flutter is Google’s mobile UI open source framework to build high-quality native (super fast) interfaces for iOS and Android apps with the unified codebase.',
        trimMode: TrimMode.Line,
        trimLines: 2,
        colorClickableText: Colors.pink,
        trimCollapsedText: 'Show more',
        trimExpandedText: 'Show less',
        moreStyle: const TextStyle(fontSize: 14, fontWeight: FontWeight.bold),
        style: isAmber ? Theme.of(context).textTheme.titleSmall?.copyWith(color: Colors.amber) : const TextStyle(color: Colors.yellow),
      ),
    );
  }
}

yes for the style it works when i secify it as TextStyle() directly, but not like this Theme.of(context).textTheme.titleSmall?.copyWith(color: Colors.amber) copying the textStyle from Theme


[Features] Enable partitioned variable assignments

PartitionedVariable cannot use assign, assign_add and assign_sub functions in graph mode. In this pull request, I have enabled these functions in graph mode. This is the first step to enable variables partitioner usage in distribution strategy.

@ebrevdo @theweiho Any coding style and design review comments are welcome. @yuefengz This maybe the first step to enable variable partitioned usage in distribution strategy

Thank @wangsiyu for the work.
@yuefengz  @ebrevdo @theweiho any feedback from your sides are highly appreciated.
Talk is cheap, show the code.
Siyu directly made this PR to ensure the communication could be more efficient.

Unrelated failures? @ebrevdo @theweiho I noticed master branch also failed with these unitest especially in  XLA.

@alextp Hi, Alexandre. The PR seems to be duplicated with tf 2.0 tensorflow/community#11 , right?

symbols like tf.assign* will be removed in favor of methods in tf.Variable

Could you make a comment or reassign? Should we accept the PR or reject?

Sorry，I am confused. These assign* methods have already implemented in PartitionedVariable class and I think it convents to 2.0？

@alextp
Hi Alex,
I am also a little bit puzzled as to your comments.
It is appreciated if you could directly comment on our code commit so it would be  easier to ensure we are on the same page.
Thanks.

I meant this NotImplementedError: https://github.com/tensorflow/tensorflow/blob/master/tensorflow/python/ops/variables.py#L2400
If we can replace this error with an implementation of assign, assign_add, etc for PartitionedVariable this will be more 2.0-friendly.

@alextp I have refined the coding style according to @facaiy . Please review again. Thanks.

Any update for me？


Get new commits.

Fix typos and whatnot (#731)
use init for colorscheme (#715)
README.md: update neo-tree example - remove legacy setting (#744)
feat: allow treesitter defaults to be overwritten from custom directory (#732)
chore: rename  to  for consistency (#719)
Added folke/neodev.nvim for proper nvim api completion and annotation (#754)
Use cmp-nvim-lua as nvim-cmp source for neovim Lua API (#696)
Revert "Use cmp-nvim-lua as nvim-cmp source for neovim Lua API (#696)" (#755)
doc: add info about timeoutlen (#691)
Add / cmp mapping to scroll cmp docs (#750)
Move friendly snippets to dependencies of LuaSnip (#759)
doc: add note about advanced luasnip features
fix: disable ts indenting for Ruby
Update README.md (#763)
conform: disable autoformat on save for specified filetypes (#694)
README: additional install recipes for various OS (#767)
assign table to filetype in lua_ls config comment (#770)
feat: add linter plugin (#699)
Some suggestions and capitalised a few words (#771)
Add nvim-nio as dependency for nvim-dap-ui (#774)
Update README.md (#781)
README: wrap long lines (#784)
fix #799 (#800)
Add instructions to quit :lazy. Fixes #761

Test comment from neovim.


Flex the width for the notifications badge

Description
This change proper renders notifications with 3 digits or more.

Types of Changes

[x] Bug fix (non-breaking change that fixes an issue)
[ ] New feature (non-breaking change that adds functionality)
[ ] Documentation update
[ ] Breaking change (could cause existing functionality to not work as expected)
[ ] Other changes (non-breaking changes that does not fit any of the above)

Breaking changes include:

Removing a public function or component or prop
Adding a required argument to a function
Changing the data type of a function parameter or return value
Adding a new peer dependency to package.json

Changes
This change allows the notification badge to expand upon 3 or more digits inside. Otherwise the text was not readable.
Before:

After:

Note: the underline is due to a mouse hover.
With only one digit:

How to Test-Drive This PR

(step1)

Checklists

General

[ ] Changes are covered by test cases
[ ] CHANGELOG.md updated with a short description of changes (not required for documentation updates)

Accessibility Compliance
You must check off all items in one of the follow two lists:

[ ] There are no changes to UI

or...

[ ] Changes were tested with a Screen Reader (iOS VoiceOver or Android Talkback) and had no issues
[x] Changes comply with WCAG 2.0 guidelines levels A and AA
[x] Changes to common UI patterns and interactions comply with WAI-ARIA best practices

Localization

[ ] Changes include a UI text update in the Retail React App (which requires translation)

I'm getting an exception when signing the CLA.

I already signed the CLA, but the check is not coming up. Maybe I could open a new PR and we close this one?

That usually fixes the CLA bot, go ahead and try it!

Change has been merged. Thanks for the contribution @leobalter !


Store tags directly in Value class

Fixes #2775.
Also:

removed "Boxed" word
frForceBoxed is still useful but renamed to frWithTags
removed BaseValue.clone() method because it wasn't doing anything (I hope...), but added a few helper methods on BaseValue for "copy with new tags" operations
converted Value.publicName() to a getter, as a minor memory optimization

Two more things to consider:

we probably rename SqValue.tag to type to avoid the confusion
should value.isEqual compare tags? I think it usually shouldn't, e.g. 5 -> Tag.name("1") == 5 -> Tag.name("2") should be true, but it's less clear in case of uniq.

I'm going to go ahead and merge this, I could use it for my other PRs.


drone terraform refresh not found

Great work... Thanks for repo...  do we have any plan to enable  "refresh" command?   right now i´m getting
time="2020-07-09T16:21:56Z" level=info msg="Drone Terraform Plugin Version" Revision=
valid actions are: fmt, validate, plan, apply, plan-destroy, destroy.  You provided refresh

Yes, seems like it's be a good command to support.  Open to a PR to support it.  Adding tests as well help PRs get reviewed/approved if you open one.  😛


HBASE-24120 Flakey Test: TestReplicationAdminWithClusters timeout

When remove peer happens, it may interrupt ReplicationSourceShipper thread.
interruptOrAbortWhenFail will throw out a RunTimeException which is not handled
and will abort Region Server. The solution is not to throw out a RunTimeException.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 26s
Docker mode activated.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
6m 37s
the patch passed

+1 :green_heart:
compile
1m  8s
the patch passed

+1 :green_heart:
javac
1m  8s
the patch passed

+1 :green_heart:
shadedjars
5m 46s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 40s
hbase-server in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
167m 13s
hbase-server in the patch passed.

200m 14s

Subsystem
Report/Notes

Docker
Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1441/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1441

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 540e127276af 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 0e30e00c56

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1441/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1441/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1441/1/testReport/

Max. process+thread count
3429 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1441/1/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Please give me sometime to review. Usually I do not like to manually create a RuntimeException and throw it as it is an anti pattern(the only exception is validation), so there must be some reasons why we do it here. Let me try to figure out.
Thanks.

Please give me sometime to review. Usually I do not like to manually create a RuntimeException and throw it as it is an anti pattern(the only exception is validation), so there must be some reasons why we do it here. Let me try to figure out.
Thanks.

👍 would appreciate your analysis here Sir.

OK, skimmed HBASE-20561, the goal there was to avoid the region server to be aborted...
I think the RuntimeException was used to skip all the following code and propagate it soon to the most top level of code, as the operation is failed, we should not execute the following code any more, a simple return will make the upper layer think the operation is succeeded, which is incorrect.
Now the code at the top level will abort the region server? Maybe that's the place need to be fixed.
If RuntimeException is too general, maybe we could introduce a special exception and throw it, and at some places we catch it and just ignore it and quit.

If RuntimeException is too general, maybe we could introduce a special exception and throw it, and at some places we catch it and just ignore it and quit.

From my read, it seems like propagating the InterruptException is a reasonable course of action. The run loop appears to handle it properly.

OK, skimmed HBASE-20561, the goal there was to avoid the region server to be aborted...
I think the RuntimeException was used to skip all the following code and propagate it soon to the most top level of code, as the operation is failed, we should not execute the following code any more, a simple return will make the upper layer think the operation is succeeded, which is incorrect.

Look back the code, you are right, ignore and continue is not the right way to handle it.

Now the code at the top level will abort the region server? Maybe that's the place need to be fixed.
If RuntimeException is too general, maybe we could introduce a special exception and throw it, and at some places we catch it and just ignore it and quit.

I do think RuntimeException is too general, can we just define a special exception which extends RuntimeException and let the top level to catch and handle it?
I will put a new patch based on your feedback. Nice comments, I will quote your comments to the code as well, thanks!

If RuntimeException is too general, maybe we could introduce a special exception and throw it, and at some places we catch it and just ignore it and quit.

From my read, it seems like propagating the InterruptException is a reasonable course of action. The run loop appears to handle it properly.

Indeed, that is my first approach. I tried to rethrow the InterruptedException from communication layer, the nit is that there will be lots of methods which needs to throw InterruptedException in their signature. Especially in shipEdits(), it catches all exceptions and it needs to rethrow InterruptedException as a special case. @ndimiduk , what do you think?

Thanks for the very nice comments/dicussions here, @Apache9 , @ndimiduk and @saintstack , I will put another patch based on the comments. There is another case popped up, which is a NullPointerException caused by InterruptedException, I will take a close look and include that handling in the patch as well.

@Apache9 @ndimiduk @saintstack
I updated the patch based on Duo's comments. Manually throws out ReplicationException with cause as IntteruptedException in ZKReplicationQueueStorage#setWALPosition to make sure the path exercised as expected. Please review.
Going to address the other issue separately.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 31s
Docker mode activated.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
5m 53s
the patch passed

+1 :green_heart:
compile
1m  3s
the patch passed

+1 :green_heart:
javac
1m  3s
the patch passed

+1 :green_heart:
shadedjars
5m  9s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 40s
hbase-server in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
116m 34s
hbase-server in the patch passed.

147m 18s

Subsystem
Report/Notes

Docker
Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1441/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1441

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 544f308cbe6a 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 80d4a09ddc

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1441/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1441/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1441/2/testReport/

Max. process+thread count
3894 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1441/2/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  0s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+1 :green_heart:
mvninstall
7m  1s
master passed

+1 :green_heart:
compile
1m  5s
master passed

+1 :green_heart:
shadedjars
5m 42s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 43s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
6m 51s
the patch passed

+1 :green_heart:
compile
1m  6s
the patch passed

+1 :green_heart:
javac
1m  6s
the patch passed

+1 :green_heart:
shadedjars
5m 48s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 40s
the patch passed

_ Other Tests _

-1 :x:
unit
134m 27s
hbase-server in the patch failed.

166m 46s

Subsystem
Report/Notes

Docker
Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1441/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1441

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux aa3a0eb3c5e6 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 80d4a09ddc

Default Java
1.8.0_232

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1441/2/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1441/2/testReport/

Max. process+thread count
3949 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1441/2/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Test failures are mostly due to "Unable to create native thread", will address the comments and kick off a new run later.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 37s
Docker mode activated.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
6m  3s
the patch passed

+1 :green_heart:
compile
1m  7s
the patch passed

+1 :green_heart:
javac
1m  7s
the patch passed

+1 :green_heart:
shadedjars
6m 44s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 50s
hbase-server in the patch failed.

_ Other Tests _

-1 :x:
unit
131m 48s
hbase-server in the patch failed.

163m 33s

Subsystem
Report/Notes

Docker
Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1441/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1441

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 749430b85ef2 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 80d4a09ddc

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1441/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1441/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1441/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1441/3/testReport/

Max. process+thread count
3512 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1441/3/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 17s
Docker mode activated.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
7m 25s
the patch passed

+1 :green_heart:
compile
1m 26s
the patch passed

+1 :green_heart:
javac
1m 26s
the patch passed

+1 :green_heart:
shadedjars
8m 16s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 57s
hbase-server in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
226m  7s
hbase-server in the patch passed.

266m 32s

Subsystem
Report/Notes

Docker
Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1441/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1441

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux e32e6dcdf1e9 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / d6451a8e2b

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1441/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1441/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1441/4/testReport/

Max. process+thread count
3295 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1441/4/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.


Deployment

#User Story
As a boot camp student,
I want the prework notes to be structured on a webpage,
So that I can easily find and read the information.
##Acceptance Criteria
GIVEN a Prework Study Guide website,
WHEN I visit the website using the URL,
THEN I can access my website from any browser

Successfully deployed a pre-work study website