Kelp Moss is only placeable in normal stone

Description
Kelp Moss is placeable only in normal stone, though it should be placed only in Kelp Rock tiles.
Reproduction steps
1 - Get Kelp Moss.
2 - Attempt to place it on Kelp Rock.
3 - Re-attempt to place it on normal stone.
Screenshots
No response
Logs
No response

Moss tiles seem to be entirely hardcoded in Player.PlaceThing_Tiles(), given the flag:
if (!canUse || ((tile.active() || flag) && (!Main.tileCut[tile.type] || tile.type == 484) && (tile.type < 373 || tile.type > 375) && tile.type != 461 && createTile != 199 && createTile != 23 && createTile != 2 && createTile != 109 && createTile != 60 && createTile != 70 && !Main.tileMoss[createTile] && !TileID.Sets.BreakableWhenPlacing[tile.type]) || !ItemTimeIsZero || itemAnimation <= 0 || !controlUseItem)
{
    return;
}

Perhaps a patch would be necessary, or some other workaround?

Alternative fix:
Override ModItem.UseItem, and manually check for the tile over the player's cursor placement, and replace if it meets the given requirements.
Downsides:
Does not display item icons as placeable items normally do.

Note: I accidentally closed this lmfao


Pages: misleading description about deprecated code highlighter pygments

Code of Conduct

[X] I have read and agree to the GitHub Docs project's Code of Conduct

What article on docs.github.com is affected?
https://docs.github.com/en/pages/setting-up-a-github-pages-site-with-jekyll/about-github-pages-and-jekyll#syntax-highlighting
What part(s) of the article would you like to see updated?
Currently the section "Syntax highlighting" says

By default, code blocks on your site will be highlighted by Jekyll. Jekyll uses the Rouge highlighter, which is compatible with Pygments. Pygments has been deprecated and not supported in Jekyll 4.

This may mislead readers that GitHub Pages already uses Jekyll 4, while actually it still uses Jekyll 3.9.3. See

Dependency versions | GitHub Pages https://pages.github.com/versions/
https://github.com/github/pages-gem/issues/651

Additional information
What "Pygments has been deprecated and not supported in Jekyll 4." (added in https://github.com/github/docs/commit/724a274245fa9e90df3f5d19114e4efb91de506f) said is true, but it's not the appropriate reason. pgyments was deprecated because GitHub Pages wanted to, not because the version of Jekyll used by GitHub Pages dropped support for it.
Pygments support was dropped

by GitHub Pages in https://github.com/github/pages-gem/commit/10b6ca7cb889188c7afb51010a52cfcc633ff1e5 committed on 2015-10-27 and shipped with github-pages gem package v44 on 2016-02-02 and
by Jekyll in https://github.com/jekyll/jekyll/commit/4707017936ce0dd600bf6e0c339960058c524edf committed on 2018-09-27 and shipped with Jekyll v4.0.0 on 2019-08-20, which is 3.5 years later.

👋 @muzimuzhi Thanks so much for opening an issue! I'll get this triaged for review ✨

Ok

Ok

@muzimuzhi 👋 Thanks for opening this issue and contributing to our Docs, we really appreciate it. It looks like these two sentences can be removed completely:

Jekyll uses the Rouge highlighter, which is compatible with Pygments. Pygments has been deprecated and not supported in Jekyll 4.

You or anyone else is welcome to open a PR. 🔨

Help

@sophietheking Actually I think the compatibility bit is important, so I've kept it in #31808 — otherwise agree.

@janbrasna Agreed with you. And thank you.


Region condition breaks with new column "pages"

Describe the Bug

While testing we noticed that the region conditions breaks on the test cms. This is due to the large amount of data.
Steps to Reproduce

Go to network management on the test server
Click on 'Region condition'
See that loads forever and finally doesn't return anything

Expected Behavior

A CSV file should be downloaded
Actual Behavior

Nothing, infinite loading
Additional Information

This is probably due to the way I have implemented this. It might make sense to try it via a Database Query instead

We did a little bit of testing and have an informed guess, that this will not be a problem on our productive system

Tested successfully on cms-test. Export completed in ~5:30 minutes.


fixing the export bug

I redid it, and it looks better now (only 1 commit) I hope. I closed the previous PR.

Thanks, and sorry for the delay from before!


Usage guide

A usage guide would be really helpful here! I've been trying to understand the sort of commands I can send across, and am struggling.
Say I need to call a binary in a remote adb device. How would I do so?
Essentially all I want to do is call the following ->

connect via adb.
call ./path/to/my_binary

You can check this for usage example:
RemoteReader.java
ADB protocol documentation might be useful as well:
protocol.txt

Thanks!

Hi, I am trying to do the same as you, but I cannot understand how the RemoteReader example helped you ?


Create Users:Mailaddress option

The current mailaddress domain is fixed liferay.com.
Like Gmail  user+001<EMAIL_ADDRESS><EMAIL_ADDRESS>are same user.
When testing mail sending, it is useful if tool can create option rule to generate a mail address.
Thank you very much!

Hi @hanchenglin , I added this functionality in 33ead80fcb70c6458a04c6a0a09b00bf28d1e8c8, will be released in the next version.


Proposal: Dedicated section for FavIcons Resource

Currently, there are 3 favicons resources inside "Online Design Tools".
Since they are pretty specific and also a generator (2 of them), it should make sense to move them to a new dedicated section that's easier to look for.
Also, when building web apps/sites, favicons are sufficiently important enough that you need to give some more attention.

Good idea! Will be added.


[BYOC] Add example of Composite + Annotate for DNNL fused op

This is a reimplementation of #4741 based on the new annotator support for composite added in #5261. This is the first real use case of composite in the code base. It is purely for demonstration purpose and not intended to be used for performance critical scenarios.
Due to the manually inlined tensors in c codegen, full mobilenet execution is disabled in the test. I tried but it took more than 5GB of RAM and compilation didn't finish in a reasonable time. The related issue discussed in https://discuss.tvm.ai/t/external-codegen-constant-tensors-in-c-codegen/5890/

Please review @zhiics @mbaret @comaniac @trevor-m

@tqchen I got segfault in CI that is not related to this PR. Can you have a look?
https://ci.tvm.ai/blue/organizations/jenkins/tvm/detail/PR-5272/1/pipeline

Also added support for conv2d + relu pattern. This shows how easy to add a new pattern and support it in the codegen.

@tqchen Can you have a look at CI problem? https://ci.tvm.ai/blue/organizations/jenkins/tvm/detail/PR-5272/7/pipeline/152

Please try to retrigger https://github.com/apache/incubator-tvm/issues/5285

Yes I got that error too, but also there is a problem on i386 CI causing segfault from crt. https://ci.tvm.ai/blue/organizations/jenkins/tvm/detail/PR-5272/7/pipeline/152. This PR https://github.com/apache/incubator-tvm/pull/5280 also had the same segfault from i386.

Although I still feel this is a bit ad-hoc, it should be fine for now as we only use DNNL as an example to demonstrate external codegen.

What is still ad-hoc? I think I explained the motivation clearly in the original PR #4741 and the current impl using composite is the best we could do.

What is still ad-hoc? I think I explained the motivation clearly in the original PR #4741 and the current impl using composite is the best we could do. Wanting fused op support in external codegen is a natural and @alexbooth already finds it useful.

Sorry for being unclear. The motivation of using fused ops to demonstrate composite functions is definitely clear. What I meant was the general implementation of DNNL codegen as I've mentioned in #4741, so I'm good with this PR.

@masahi please rebase when you get a chance

@masahi just a reminder, probably don't rebase again the master, other changes are here as well

Yes I'm working on fixing it. Resolving conflict turned out a bit complicated, so I wanted to start fresh.

@zhiics @comaniac The change to the vm/compiler.cc that moved second fusion before Inline has been reverted in #5277. Should I bring it back in this PR?

@zhiics @comaniac The change to the vm/compiler.cc that moved second fusion before Inline has been reverted in #5277.

Hey sorry for that. Yes that was a mistake. When I was rebasing to the master, the commit that decouples DNNL and VM part was reapplied, so #5288 was reverted as you pointed out. If possible, would you cherry-pick it back in this PR? Thanks!

@comaniac Done. Please take a look at the last commit

Changes to multi output support in dnnl/codegen.cc has also been reverted in #5277, but I've already integrated that change in this PR last night.

Changes to multi output support in dnnl/codegen.cc has also been reverted in #5277, but I've already integrated that change in this PR last night.

Yes I've also checked that those diffs are in this PR as well. Thanks.

Thanks @zhiics @comaniac


ecr.PutImage returns not alphanumeric exception when using "-" in name

Hi,
I get this exception:
ecr.PutImage\n  File "/usr/local/lib/python2.7/dist-packages/troposphere/init.py", line 83, in init\n    self.validate_title()\n  File "/usr/local/lib/python2.7/dist-packages/troposphere/init.py", line 198, in validate_title\n    raise ValueError('Name "%s" not alphanumeric' % self.title)\nValueError: Name "crud-demo" not alphanumeric", "stdout": "", "stdout_lines": [], "warnings": []}
But I can create the repository via the console with the same name (crud-demo)
Version: 1.9.2

It would be best to post a snippet of your code for better diagnosis. But I suspect this is a duplicate of the FAQ described in these issues: #344 and #311. The title (first parameter to PutImage) must be alphanumeric only. The repositoryName used for PutImage can contain additional characters.

Hi,
Thanks for the prompt response!
You are absolutely right - my mistake. Now it works perfectly.
Thanks!


better javascript/Node.js/es6 syntax highlighting

From @xpepermint on July 15, 2016 18:44

VSCode Version: Code 1.3.1 (e6b4afa53e9c0f54edef1673de9001e9f0f547ae, 2016-07-12T13:31:10.994Z)
OS Version: Darwin x64 15.5.0

Motivation
It seems that nobody deeply cares about Javascript/Nodejs syntax highlighting. VSCode does a better job then other text editors (e.g. Atom) but it's not perfect. VSC could be the #1 choise for javascript developers if some common syntax highlighting bugs were fixed.
Steps to Reproduce
Example 1:
let from = neki;
from = a; // is a variable and should be in white color like other variables

Example 2:
exports.myVar = async (ctx, next) => {} // this is all in white but exports and async should be e.g. in red or blue

Example 3:
t.me = 1;
t.is = 2; // `is` is in blue but should be the same color as the above (1)
t.in = 3; // `in` is in blue but should be the same color as the above (1)
t.of = 4; // `of` is in blue but should be the same color as the above (1)

Copied from original issue: Microsoft/vscode#9366

Is the fix planned to be in a milestone in the not too distant future?

We are working on updating our syntax highlighting. please bear with us for a little bit longer.

Alrighty.

cool


readonly conflicts with default (and rule_filter)

This allows using default and readonly on the same field. See #268 for details.
Furthermore, this PR introduces a new feature called rule_filter to solve #268 in an (in my opinion) elegant way. I'm not sure if this feature will be ever used externally, but just in case I wrote some documentation for it. Briefly speaking, it allows to do the following:
>>> schema = {'name': {'type': 'string', 'maxlength': 10}}
>>> v = Validator(schema, rule_filter=lambda f: f != 'maxlength')
>>> v.validate({'name': 'Johanna-Maria'}, schema)
True

i have several here. i hope to write them up until Monday.

This looks good to me!

just a short summary of my concerns:
while i think this pr approaches a valid problem, i think it's still not sufficent and may be a burden in the end.
the whole normalization/validation/rules dispatching logic/andwewantitalltobecustomizable thing needs proper attention for too long. it shouldn't be continued to just fix things up when lacks of design become obvious. introducing new attributes now that may later be unnecessary doesn't make it easier as they will have to be dealt with for legacy reasons.
my current plan is to dig through issues and code (history) on Friday to come up with proposals in a broader frame. it will simply take some hours, i couldn't spare yet.
and most certainly, lambdas as confuguration values should be avoided.

I understand your concerns and am of course happy with finding a better solution. We don't have to rush here. Some things I noticed when digging into this:

Validation and normalization are completely separate, but the methods are in the same class. Maybe split the functionality in two (or even more) classes?
Recursing down the document structure is implemented in two different ways for validation and normalization. Maybe this can be done the same way.

Maybe we can have one base class for doing all the recursing stuff ("walking" the document) and calling somehow registered rule handlers? This class could be the base for both a Validator class and a Normalizer class and then we could combine two Validators and one Normalizer to get what we need, which is validating some fields before normalization and then validate again afterwards.
A lot of maybes here and I am nowhere as deep into codebase and prior design decisions as you are @funkyfuture, so I think it's best to leave this up to you and maybe I can help with the actual implementation later.

first thing i will do is to comprehend the problems with the current implementation, then propose design changes. i'll be happy to get your feedback on that as you already dove into parts of a solution.

okay, i'm clearly overthinking things here. at least for the particular issue in question.
what about the following? let's consider readonly a normalization rule as it is used to control a document's shape that will be used further down the line in business logic. thus its evaluation can be placed before default's in the normalization block. makes that sense?
if this approach worked, further cluttering of evaluation blocks and more properties that determine evaluation order can be avoided. (yes, afair i introduced those, but i consider them rather hacky.)
nonetheless i got some impulses that resulted in ideas for a possible 'next generation' of how we define rules (dependencies and other properties) and control their evaluation order. but having ideas is one thing, having time to act on them is another.

I'm not sure about readonly being a normalization rule as it will never change the document. All other normalization rules do that. Furthermore this would break backwards compatibility as readonly would not be checked anymore if somebody calls validate with normalize=False.
If your concern for this issue is mainly the introduction of a new feature (rule_filter), how about considering it just for internal use and not document it (for the public API)? This way we could allow using readonly with default without breaking anything and at the same time not introduce a new feature that we have to support in future releases.

I'm merging this. Eve (which is the main reason why Cerberus was born in the first place :smile:) needs support for readonly with default. We can always refine later, if needed.

Maybe we can at least remove the section in the documentation so we're not pointing users to use a feature we're not sure about? I'd leave the comments/docstrings in the code as they will help future coders to understand what rule_filter does.

Maybe we can at least remove the section in the documentation so we're not pointing users to use a feature we're not sure about? I'd leave the comments/docstrings in the code as they will help future coders to understand what rule_filter does.

👍

I will do this and rebase on master tonight!

imo, you could even drop that property and 'hardcode' the evaluation order.
what are you going to do with the testcases? (they have to be refactored anyway.) though they make hardly sense and are irritating with a non-public feature, they are very usable for a later finer-grained customization mechanic. maybe mark them with @pytest.skip for now?

I'm merging this. Eve (which is the main reason why Cerberus was born in the first place :smile:) needs support for readonly with default.

but Cerberus has emancipated from Eve, there are numerous other uses in the real world. and the users have contributed for a more general library. the readonly rule is actually so specific that it should be defined in a custom validator.
Eve shall prosper, and Cerberus shall be capable to support this. but imo its heritage is not an argument for exclusive hot fixes and workarounds. we should take Eve's needs as an impulse to improve a generally usable, configurable validation library that is unique in the Python ecosystem.

the readonly rule is actually so specific that it should be defined in a custom validator.

@dkellner do you think that would be feasible?

imo, you could even drop that property and 'hardcode' the evaluation order.

I don't think we can (easily) hardcode the evaluation order. We need a way to pass the information to child validators that they should only process certain rules (the ones to process before normalization). We need to validate all readonly fields (including subdocuments) before normalization, because normalization will recurse itself, too. Of course we can implement the recursion again without leveraging child validators, but I'd consider that rather hacky.

what are you going to do with the testcases? (they have to be refactored anyway.) though they make hardly sense and are irritating with a non-public feature, they are very usable for a later finer-grained customization mechanic. maybe mark them with @pytest.skip for now?

I'd keep them even for a non-public feature. The test-cases for using readonly with default are hardly enough to cover everything rule_filter can do, so maybe we won't notice if it breaks due to future changes. We can remove them when we toss rule_filter itself? I don't mind the rewrite for py.test ;).

the readonly rule is actually so specific that it should be defined in a custom validator.

Can we really use custom validators or custom rules here? They are both called after normalization. As far as I know, there is currently no "native" way to validate before normalization.
@funkyfuture By the way, I absolutely agree with you that there are use cases for Cerberus apart from Eve and that changes we introduce here should be reasonable in that regard. I myself use it in a non-Eve project, too.

In my opinion, it all leads to the question if we see pre-normalization-validation as a feature in Cerberus itself, or if we think this should be handled by the application (e.g. by splitting the schema and using two different Validators). Personally I would prefer the former, as it would allow to have one schema to describe your data even if it contains auto-generated fields the user should not be able to set. How do you think about this?

In my opinion, it all leads to the question if we see pre-normalization-validation as a feature in Cerberus itself, or if we think this should be handled by the application (e.g. by splitting the schema and using two different Validators). Personally I would prefer the former, as it would allow to have one schema to describe your data even if it contains auto-generated fields the user should not be able to set. How do you think about this?

I agree that it should/could be a Cerberus feature.

@dkellner have you considered to include the readonly logic in an overriding method that handles default?

Yes I did but I have the same concerns as implementing it as a "standalone" normalization rule (see https://github.com/nicolaiarocci/cerberus/pull/272#issuecomment-252505459). Nevertheless I will play around with that idea later today or tomorrow and actually show some code. Maybe it's a "good" compromise solution.

OK, here's some code: https://github.com/dkellner/cerberus/tree/normalize-readonly . I've implemented readonly as normalization rule, as suggested by @funkyfuture before (https://github.com/nicolaiarocci/cerberus/pull/272#issuecomment-252313758). I actually quite like the solution, except the (admittedly subtle) breaking change that readonly won't be validated anymore if somebody is using normalize=False. And the (maybe philosophical) question if we can consider readonly a normalization rule regarding its nature of not changing the document.
If you both agree that this is a way to solve this problem here, I'm going to update the docs in that branch and create a PR.

Well, it works and... implementation is pretty straightforward. I would tag it an acceptable compromise.

some points:
there's a misunderstanding, i didn't mean that readonly should be a normalization rule, but its logic could be integrated in the handling of default. so, in this case, the readonly key in the schema would provide extra config for default (like allow_unknown to schema for example).
you can extend the readonly (validation) rule so it doesn't run a second time if a readonly error has already been filed by the default rule, using the schema or document error tree. if there is no error, it possibly (in case that a default rule was processed) has to run a second time. imo it's okay as it is a compromise to put functionality into a framework that isn't fit for it and the readonly logic is lightweight.
as one cerberus' paradigm is to be non-blocking, i don't agree that a failing normalization skips validation.
the tests consider nested schemas and expected errors, perfect! :-D
a diff-view for reviewing would be great.

@funkyfuture Ah, got it. :) One more question about the non-blocking paradigm: so right now it stops validating if some "priority" rule fails, and readonly is one of them. If readonly now is a normalization rule, should we stick to that behaviour and implement a special case for that? I find the current behaviour somewhat confusing (when validation will stop and when it will just continue adding more errors to an already invalid field).

to clarify, i don't  think readonly needs to be abandoned as validation rule. (i think it should be abandoned at all, because it's eve-specific. but there's that legacy thing.)
i mean the following as pseudo-code:
def normalize_default(...):
    if do_readonly_logic(...) == 'failed':
        self.error(..., READONLY_FIELD, ...)
    else:
        do_default_logic(...)

def validate_readonly(...):
    # don't re-evaluate if an error was already submitted by default during normalization
   if READONLY_FIELD in self.document_error_tree.fetch_errors_from(self.document_path + (field,)):
        return
   ...

the aborting priority_rules make sense as a user can assert that a value is not None (nullable) and has a certain type (type), so the following tests do not fail due to TypeError or ValueError. the reasoning for readonly is that a field that shouldn't be there at all, doesn't need to be validated.

Hm, but this is not enough. You should not run readonly validation at all if there was normalization before - it will always fail on fields having both default and readonly (which is the whole point of this issue). But I will look at the code again, remove the part that skips validation after failed normalization and try to find a nice way to make a failing readonly stop validation for that field.

okay, you can test whether default is defined for that field in validation as well.

See #282


Change Undercurl Style

Is there a way to change the style of the curlies? They are kinda ugly. I'd prefer them to be like elongated w's or v's (vvvvvvvvv).
EDIT: I just noticed the squigglies are being drawn manually, I'll take a shot at it this week if I find time!

I'm planning to rewrite the rendering part, I just wanted something working for now, and I'm kind of busy these days. Feel free to implement something yourself, I'll leave this issue open, in case you have questions.

Hey, is there any advance on it? I was playing around with the drawing but can't get it to look beauty :confused:

I got them working but I didn't like them, a lot of trial and error is needed to get the angle visually pleasing (not to mention line thickness). After spending an hour on this, I figured it's not worth the time. The original squigglies looked better so I ended up reverting to the initial state.

I'll take another shot at it, I'll post progress as I go.
This is a code to mimic simple underlines:

You replace everything below // Draw waves with:
        XPoint *points = xmalloc(sizeof(XPoint) * 2);
        points[0] = (XPoint) {
          .x = wx,
          .y = wy + wh/2
        };
        points[1] = (XPoint) {
          .x = ww * charlen,
          .y = 0
        };
        XDrawLines(xw.dpy, XftDrawDrawable(xw.draw), ugc, points, 2, CoordModePrevious);

        free(points);

Here is the result if the line changes angle once at each character.

here's the code:
        int npoints = charlen + 1;
        XPoint *points = xmalloc(sizeof(XPoint) * npoints);
        points[0] = (XPoint) {
          .x = wx,
          .y = wy + wh
        };
        for (int i = 1; i < npoints; i++) {
          points[i] = (XPoint) {
            .x = ww,
            .y = i % 2 ? -wh/2 : wh/2,
          };
        }
        XDrawLines(xw.dpy, XftDrawDrawable(xw.draw), ugc, points, npoints, CoordModePrevious);

        free(points);

And here's when we have two angle changes per character:

You replace everything below // Draw waves with:
        int npoints = charlen * 2 + 1;
        XPoint *points = xmalloc(sizeof(XPoint) * npoints);
        points[0] = (XPoint) {
          .x = wx,
          .y = wy + wh
        };
        for (int i = 1; i < npoints; i++) {
          points[i] = (XPoint) {
            .x = ww/2,
            .y = i % 2 ? -wh/2 : wh/2,
          };
        }
        XDrawLines(xw.dpy, XftDrawDrawable(xw.draw), ugc, points, npoints, CoordModePrevious);

        free(points);

wow, looking really nice, thank you so much for sharing this! :heart:

@hexoctal is there any standard to make lines thicker in x? I tried googling a bit, but didn't find anything. A workaround I came up with is drawing the same lines a pixel below (I don't know if this is good). Also, can you check if I cleaned the memory properly. I think I did, but I got some artifacts once when developing, and I'm sure if that's my fault or some other patch I have.
Also, would you mind accepting this as a PR? A user could choose in the config.h which style to use.

Hi! First of all I am so sorry for being so late! Github didn't show me any notifications even though I'm subscribed to this issue, and it's only after I randomly checked my emails that I saw your comments :confused:
For line width, you can modify it using GC components like you would do with cap style and fill. Look higher, where ugc is created. But the problem is that xlib do not have subpixel rendering capabilities, so the width is an integer. 1 is what this is already set to and 2 is way too thick...
Something I found to improve the quality of the underline is the angle used. Here is what the lines look like with a 45°, 1 pixel width at different sizes:

And yes, as you can see, the line is too thin, but a width of 2 gives this:

Taking for example the curly underline of firefox right in this comment text area, the lines when at 1 pixel width are drawn as follow:

But XLib does it like this:

This makes the joints look spiky and lines too thin. A solution to this could be as you said to draw the line twice:

So with all this, this is what we could conclude to draw straight lines as curly underlines:

Keep angle of lines at 45° otherwise the lines look weird depending on the font size
Adapt the width of the line to the size of the font (A bit tricky as we cannot use floating precision)
Draw the lines twice to imitate a width of 1.5 for small font sizes with an offset of 1 pixel to the right

I put all this together and got the following results:

Which I find looks quite good and clean, I'm gonna fix the width of the underline to match its word, and also work on a solution to update a single wave when a redraw is needed, this is a little more delicate as the 45° angle removes the convenience of having 1 wave per character:

Anyway tell me what you think about these results. I'll post an update as soon as I fix the length and redraw problem!

Also @MasterMedo what kind of artifact was it? It could be a conflict with another patch

When I first started the issue I also went for the 45 degree angle and got stuck on this exact thing: connecting two independent waves.
Artifacts I had were xlines drawn from 0,0 to my cursor in neovim. I must've forgot to comment some line because I haven't seen them since.

So after a while, I implemented everything for this style. Here are some screenshots:

I fixed the problem of wave connection by using an absolute grid for the underline that do not use the text coordinates but the screen coordinates (Came up with the idea after observing Firefox's underline). It works pretty well.
Tell me what you think of this, and if any of you have remarks or observations like the width, height and sol on...
 I'm also gonna add the option to choose between the 3 different styles in the config file.

Can you put it in a pull request draft, so I can check it out?
It definitely looks promising. How did you get screen coordinates, I tried using the grid with character coordinates, but that didn't work with unicode.
Pretty cool idea for the third style.

Sure, will do as soon as possible, maybe tomorrow.
I get the coordinates using the variable winx and winh, they are already present in st.

I added a new development branch with the new patch, so check it out.
https://github.com/hexoctal/st-undercurl/tree/develop
It's little rough around the edges for now but enough for testing it. Change the style of the underline in the config.def.h. Don't forget to delete the generated config.h before recompiling.

Hey, I'm trying to test it out but I'm getting errors like this one:
x.c: In function ‘xdrawglyphfontspecs’:
x.c:1725:26: error: ‘Glyph_’ doesn't have a member called ‘ucolor’
 1725 |                 if ((base.ucolor[0] >= 0) &&
      |                          ^

Should I try with an unpatched version of st? :thinking:
Regards

Oh, forgot to add a file to the patch! I'll fix it right away!

I just checked and the patch works correctly. I noticed that the name of the struct in your comment is "Glyph_" with an underscore, so you might have a patch that's causing troubles... Try it with an unpatched version first. It would be helpful if you could find which patch causes this problem too.

Works for me! I like the spiky version most, probably going to stick to that one. I like the threshold variable, although I think it would be more clear if you called it width (e.g. 10/threshold).

Threshold is just how often should the underline width increase. By default it is 40 which means that the line width increase by 1 pixel every time the terminal font increases by 40px. I didn't really intend to have it as a config though so I'll move it somewhere else. I made this system to imitate a 0.5 increase in width as Xlib do no have subpixel rendering.

In neovim, things words containing non-latin characters e.g. čćđšž curl one character too much:

I suspect this has nothing to do with your code though. Because in shell (fish) this doesn't happen:

I can't seem to reproduce the issue inside or outside of neovim.

Initially I suspected that the end of line special character was the culprit, but that wasn't the case too.

So I believe that it is caused by a plugin. I get dimensions from st itself, so whatever is causing this is probably modifying a core part of st. :man_shrugging:

I updated the master branch with the new patch. If everything is good, we'll close this issue.


cargo publish

The version on crates.io doesn't compile because of a recent warning-turned-error about Sized, but the git HEAD does.

I just published v0.3.0.
I probably should have updated the README w.r.t. stuff such as #46, but I went ahead and did the least-effort thing.

What's The Right Thing To Do with https://crates.io/crates/rust-sqlite now that this is retired? (ref #46)


Majander2024

Publication DOI or URL
Raw data available here: PRJEB62647
Additional context
No response

Closed by PR #1144.


refactor: encapsulate setUpMemory method in Memory structure

Current State
Currently, the setUpMemory function:
https://github.com/keep-starknet-strange/ziggy-starkdust/blob/00ee0d18d6bd2b2fdf05b54f0f27ae85cf231824/src/vm/memory/memory.zig#L798-L844
resides outside the Memory structure. This function operates directly on a Memory instance via a pointer passed as the first argument.
Proposed Improvement
To streamline the structure and logical flow of our codebase, it's suggested to incorporate the setUpMemory function into the Memory structure itself. This integration would align more closely with the architecture, enhancing readability and encapsulation.

i can take this up

i can take this up

Assigned


Review Azure AD B2C Settings

Ensure Azure AD B2C is setup correctly:

Do we need the AD Tenant in Sandbox subscription. If not, delete it. If so, move it to Prod Sub so it doesn't accidentally get deleted
Find a way to get redirect Urls to handle signins after going to event details page

Evaluate the B2C Settings to make sure that any page a user goes to that requires sign in can go to the sign in screen, and then route back to the screen the user selected.


Drop rdfs:label property in Ontology

Since we already have two more name-like attributes for each property, csvw:name and the local name in the CLDF namespace, an additional rdfs:label seems superfluous, considering that the other names are fairly human readable as well.
Addresses #54

Fine with me. In some cases it might be helpful to write these labels in full in the comment/description, otherwise fine with me.
However, note that this still does not solve most of the 'inconsistencies' noted in issue #54.

I realize this. #54 is just a bit too big to be addressed in one go. I'm in the process of breaking it down into independent issues.


Working on Ghosts of Saltmarsh

Just a heads up, I'm working on adding Ghosts of Saltmarsh. There are some issues in KFC with things that are in multiple sources that I've been meaning to deal with for a while, and this is the first time since adopting my new strategy of one sheet per source that I'm being forced to confront them, so I need to make appropriate updates.
Hopeful to have it out some time this weekend. Just wanted to give a heads up to prevent duplicated effort.

http://kobold.club/5e-monsters/sheet-check.html?name=Ghosts of Saltmarsh&sheetid=1dQE6OCpSytS9GvQivNXdQGMe-f2GeVbqTtuJ53ylu7E


test_flush may panic (very rarely so)

thread 'location::tests::test_flush' panicked at 'called `Result::unwrap()` on an `Err` value: Error { repr: Os(2) }', /Users/rustbuild/src/rust-buildbot/slave/stable-dist-rustc-mac/build/src/libcore/result.rs:729

Happened only once, couldn't reproduce.

Fixed in 5b6dcad792eeb0b54d5526fcfbe9b8b7c994161d


Add a way to manually change data type

The inference we added in #194  is very likely to be incorrect.
For example, if we have input quiz data that has score as integer from 0 to 5 … it might be categorized as ordinal.
However, we can add this later.

Duplicated of https://github.com/uwdata/voyager2/issues/73


Add example for STAC search query extension to README

Regarding STAC API extensions, the README says:

The STAC endpoint implements the query, filter, fields, and sort extensions, all of which are bound to the search endpoint as used with POST requests, with fields and sort additionally bound to the features endpoint.
Fields contained in the item properties must be prefixed with properties., ex properties.dea:dataset_maturity.

From this information, I figured that to limit my results by maximum cloud cover, I need to POST to /stac/search with a body like this:
{
    "query": {
        "properties.eo:cloud_cover": {
            "lte": 10
        }
    }
}

But the numberMatched of the returned result is the same as when I omit this query. This leaves me wondering that maybe my JSON is wrong? Adding an example to the README explaining how to use the query API would really help to rule this out, as right now I'm not sure whether it's a problem with my request or my data. I tried various variants of the request (e.g. adding "gte": 0), but none seems to do anything. But also my data does have the eo:cloud_cover attribute, which also is included in the properties of the returned features, so I don't really see a problem there either...

Hi @christophfriedrich,
This is due to an issue with how our STAC API is currently implemented; we are aware of the issue and looking to fix it.
In short, first all datasets that match the time/collection/bbox/etc parameters are being retrieved, and then the query extension is filtering the result. Hence why it doesn't affect numberMatched; however, the datasets actually being returned will all correctly have eo:cloud_cover <= 10.
The best workaround for the time being would probably be to set limit=1000 (to avoid/reduce pagination) and check the length of features rather than the value of numberMatched.

Sorry, I should have been clearer in my explanation - but yes, that's the essence of the problem. If you paginate through the results you will eventually manage to retrieve all matching datasets but obviously that's not ideal. And unfortunately, all the extensions are essentially broken in the same way for the exact same reason.
Fixing this is my top priority but unfortunately I can't give you an exact timeframe as I anticipate it might require some larger changes to the underlying design/logic that I'll have to look into - but hopefully it won't take more than a week or two.
Apologies for the inconvenience and thank you for raising!

Hi, thanks for working on this @Ariana-B -- is there a roadmap on when a release can be expected that incorporates your fixes? :)

Unfortunately I'm not certain - that's dependent on when @omad is able to provide a review, as well as other fixes needing to be incorporated into the next release.


[python] Add support interpreter version 310 and 311-dev

Add CI running in python interpreter verison 3.10 and 3.11-dev
Upgrade setup-python from v2 to v4
Change package version to dev
Change package status from alpha to beta

Make a test for python interpreter version 3.10 and 3.11

Codecov Report

Merging #11170 (68a3444) into dev (8b50578) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev   #11170      +/-   ##
============================================
- Coverage     40.26%   40.24%   -0.03%
+ Complexity     4926     4924       -2
============================================
  Files           982      982
  Lines         37522    37556      +34
  Branches       4124     4123       -1
============================================
+ Hits          15110    15113       +3
- Misses        20879    20907      +28
- Partials       1533     1536       +3

Impacted Files
Coverage Δ

...che/dolphinscheduler/api/python/PythonGateway.java
19.81% <0.00%> (-1.84%)
:arrow_down:

...dolphinscheduler/remote/future/ResponseFuture.java
81.96% <0.00%> (-1.64%)
:arrow_down:

...inscheduler/api/service/impl/UsersServiceImpl.java
72.11% <0.00%> (-0.39%)
:arrow_down:

...pache/dolphinscheduler/common/utils/DateUtils.java
74.83% <0.00%> (-0.17%)
:arrow_down:

...api/service/impl/ProcessDefinitionServiceImpl.java
31.73% <0.00%> (-0.13%)
:arrow_down:

.../dolphinscheduler/plugin/task/datax/DataxTask.java
0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us.

It seems we fail to install py4j with python 3.10 and 3.11-dev in windows OS:

https://github.com/apache/dolphinscheduler/runs/7783348932?check_suite_focus=true
https://github.com/apache/dolphinscheduler/runs/7783349336?check_suite_focus=true

PTAL @hiSandog @jieguangzhou


Metrics: move back the check by one minute

@wshearn it looks like it likes this PR. Do I need you to do a review of this before merging into prod?

👍 give ya a +1 anyways


Valve.Newtonsoft.Json avoids building Hololens UWP project

We have a project that supports AR and VR. VR (Valve) uses the Valve.Newtonsoft.Json.dll built for .Net 3.5. This dll is not supported in UWP (Hololens) and causes missing assemblies for UWP. Is there a way to get a version compiled for .Net 4.7 (unity .Net version 4.x)
Else We need to replace "using Valve.Newtonsoft.Jason" with "using Newtonsoft.Json" in all SteamVR files using it for the hololens project.

We might be able to upgrade the build target for that. As a temporary workaround you could also compile newtonsoft yourself. We just namespaced it for our project to avoid collisions.


update DO, implement SET BIT

(Must have branched the wrong base. Too many commits in here. Sorry)


Remove deprecated functions from fuel_tools8

This includes moving LocalCache.hh from public headers as a follow up to #109
Signed-off-by: Michael Carroll<EMAIL_ADDRESS>

LGTM, There are two tests failing on windows

They have been failing some time (here is the bump to ign-common5) https://build.osrfoundation.org/job/ign_fuel-tools-pr-win/112/#showFailuresLink
I will open an issue to track this

https://github.com/ignitionrobotics/ign-fuel-tools/issues/231


For SELECT filter ng-options, use track by instead of selectAs

This fixes the dropdown view when initializing the dropdown value’s "term" or when setting the "term" value programmatically such as during table restore state.
For an example of how it affects ui-grid, please see this plnkr.  For the plnkr, I've modified the Company field to be an object instead of a string and display multiple properties for that object in the column cells.  I want an initial filter selection to be set so I set the term to be "{name: 'Oulu Incorporated', country: 'US'}".  Although the table is properly filtered, the filter dropdown is blank.  This is because Angular's ng-options determines that the term is not the identical reference to the option value.  This problem is also encountered when doing a restoreState.  Technically, we could fix this by adding a track by expression but AngularJS does not fully support "track by" and "selectAs" as per https://github.com/angular/angular.js/issues/6564.  Angular core team does not appear to be planning to fix this.
A workaround is described in that ticket, plnkr.  That workaround was used for this second plnkr and contains the fix in this pull request.  Note that the initial value shows up in the dropdown, the table is properly filtered on that initial value, and that other dropdown options work as well.
Please note that this is a breaking fix for existing users of dropdown SELECT filters if they are using cell values that are objects and not strings.  The initializing term must be the entire selectOption object instead of just the value portion.  Also, when comparing the searchTerm to the cellValue in the condition function, the searchTerm.value must be used instead of just searchTerm.

Closing this since a better implementation for searchOption filter comparison is coming.


[RFC] [Hybrid Script] A hybrid script backend

Sorry to change my mind again and again, and I will never use the term "finally". Making ideas is endless.
An IR Dumper #2288 , is more heavy-weighted than I supposed before.
I now decide to break this issue into 2 steps:
~We already have Halide's IRPrinter to do a statical sanity check, and also the lowered IRs are too low-level to give good readability. Overall, what I want becomes something which is both runnable and gives full control to the IR body.~

The current Halide IRPrinter has bad support to the double-name thing.
This is because currently, TVM uses "unique pointer" to differentiate objects.
For example, these 2 tensors below share the same name, but they are essentially two different tensors.
However, if users use these 2 tensors to build a module, and see the lowered body, it will be extremely confusing. IRPrinter just dumps these tensors without checking double-name.

a = tvm.placeholder(shape)
b = tvm.placeholder(shape)

Also, he current IRDump dumps results of each pass to files whose suffixes are .cc. I guess the point of doing this is to borrow the syntax highlight of .cc. However, the contents dumped have nothing to do with C, so I believe migrating the text format to Python, and using Python suffix will be better.

~Thus,~ What's more, dumping IR as Python snippet will not suffice. Dumping a complete hybrid script function will be highly desirable.
Something which is both runnable and contains its source code is exactly what module is in TVM.
Finally, I decided to extend a hybrid module looks like this:

#sch is a schedule of abitary op node
with tvm.target.create('hybrid'): #this with stmt is required by special lower passes
    module = tvm.build(sch, tvm_args) #a hybrid module is returned
hybrid_op = module(*tvm_args) #hybrid compilation
np_res = module(*np_args) #software emulation

https://github.com/dmlc/tvm/pull/2477


Leave interpreting attribute values to the renderer

This is a PR for #27 which changes the default behaviour of attribute values.
Now it will leave the interpreting of the attribute values to the renderer, such like

 will pass attributes as {x: null} to the renderer instead of {x: 'null'} as it does before this PR.
An important note may be that null and undefined as values, with virtual-dom (^2.1.1), removes the attribute entirely, while false instead throws an exception because it attempts to do some entity serialization.
Behaviour is different using hyperscript which simply makes an attribute with an empty string value instead.

Because of the potentially breaking changes I'm thinking this might need a semver bump to 3.x.x

Hi @substack @JamesKyburz 👋
Do you have any plans to merge this?

This is a pretty major issue in hyperx in my opinion.
It is definitely worth bumping the version and getting it out.

I think if you pass a plain object to the tag it passes it on to the renderer. i.e.:


disable auto import completion option

Type: Bug
Behaviour
Expected vs. Actual
Expected: do not offer auto-import completions when the option is not enabled
Actual: auto-import completions are the top recommended options
Steps to reproduce:

Un-check "Offer auto-import completions"

Type sp in a python file

Diagnostic data

Python version (& distribution if applicable, e.g. Anaconda): 3.9.18
Type of virtual environment used (e.g. conda, venv, virtualenv, etc.): Conda
Value of the python.languageServer setting: Default

Output for Python in the Output panel (View→Output, change the drop-down the upper-right of the Output panel to Python)

XXX

User Settings

languageServer: "Pylance"

testing
• pytestEnabled: true

Extension version: 2023.12.1
VS Code version: Code 1.85.1 (0ee08df0cf4527e40edc9aa28f4b5bd38bbff2b2, 2023-12-13T09:48:06.308Z)
OS version: Darwin x64 23.1.0
Modes:

System Info

Item
Value

CPUs
Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz (16 x 2400)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: enabled

Load (avg)
3, 3, 3

Memory (System)
32.00GB (0.85GB free)

Process Argv
--crash-reporter-id d307ec99-355a-400e-ba4d-0cec23c6aabc

Screen Reader
yes

VM
0%

A/B Experiments
vsliv368:30146709
vsreu685:30147344
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
vslsvsres303:30308271
vserr242:30382549
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vshan820:30294714
vstes263:30335439
vscoreces:30445986
vscod805cf:30301675
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
vsaa593cf:30376535
pythonvs932:30410667
py29gd2263:30899288
vscaat:30438848
vsclangdf:30486550
c4g48928:30535728
dsvsc012cf:30540253
azure-dev_surveyone:30548225
282f8724:30602487
f6dab269:30613381
showlangstatbar:30737416
962ge761:30917236
fixshowwlkth:30771522
showindicator:30805244
pythongtdpath:30769146
i26e3531:30792625
welcomedialog:30910333
pythonnosmt12:30797651
pythonidxpt:30866567
pythonnoceb:30805159
asynctok:30898717
dsvsc013:30795093
dsvsc014:30804076
dsvsc015:30845448
pythontestfixt:30902429
pyreplss1:30897532
pythonmypyd1:30879173
pythoncet0:30885854
2e7ec940:30885897
pythontbext0:30879054
dsvsc016:30899300
dsvsc017:30899301
dsvsc018:30899302
aa_t_chat:30882232
cp7184c:30925681

we shouldn't offer when it is off. I just tried it and it works as expected. there are multiple level of settings (folder, workspace, user, machine and etc). make sure the option is off fully, not off in one place but on in another place.

Thank you for checking it.

I checked all 3 settings, and it is off (user, workspace, folder)
I uninstalled and reinstalled
I tried installing the prerelease version

But those completions still come up. A couple questions

I have several extensions installed, does screenshot above look like the auto import options created by pylance? are we sure that it's not another common extension (like the MS Python extension)
is it possible that the settings file could get corrupted? is there a way I can check or reset this?
anything else I can check to debug this, or logs I can look at?

@cidersec Can you try disabling the Pylance extension and reloading the window? Then we can know if this is coming from Pylance or not.
It'd also be helpful if you could share any other settings you may have starting with python.analysis.
Our logs can be found in the Python Language Server output channel. This is what shows up when auto imports are enabled and you accept the suggestion:

I disabled it and verified that it was coming from Pylance, but that prompted me to uninstall and reinstall for good measure and it stopped displaying those options. I should have thought to try that before, but thanks so much for the suggestion, you made my week :)


xWebAdministration: OptIn to "Common Tests - Validate Example Files" Dsc Resource Meta Test

Pull Request (PR) description
This PR opts in to the Common Tests - Validate Example Files Dsc Resource meta test.
To pass this test, the following examples had their configurations renamed to match their file name:

Sample_xIisHandler_Remove32Bit
Sample_xIisMimeTypeMapping_RemoveVideo
Sample_xIISServerDefaults
Sample_xSSLSettings_RequireCert
Sample_xWebApplication
Sample_xWebConfigKeyValue_RemoveAppSetting
Sample_xWebsite_NewWebsiteFromConfigurationData
Sample_xWebsite_RemoveDefault
Sample_xWebsite_WithSSLFlags

The following examples had their parameters corrected:

Sample_WebApplicationHandler
Sample_xWebConfigPropertyCollection_Remove
Sample_xWebsite_WithSSLFlags

The following examples had their support module PSDscResources swapped to PSDesiredStateconfiguration:

Sample_xIisFeatureDelegation_IisConfigurationPathFormat
Sample_xIisFeatureDelegation_IisModulePathFormat

The following example had its configuration data merged into the example file:

Sample_xWebsite_NewWebsiteFromConfigurationData

All examples had their layout formatting corrected if required.
This helps move the module towards passing the HQRM requirements.
This Pull Request (PR) fixes the following issues
None
Task list

[ ] Added an entry under the Unreleased section of the change log in the README.md.
Entry should say what was changed, and how that affects users (if applicable).
[ ] Resource documentation added/updated in README.md.
[ ] Resource parameter descriptions added/updated in README.md, schema.mof
and comment-based help.
[ ] Comment-based help added/updated.
[ ] Localization strings added/updated in all localization files as appropriate.
[x] Examples appropriately added/updated.
[ ] Unit tests added/updated. See DSC Resource Testing Guidelines.
[ ] Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
[ ] New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is

Codecov Report

:exclamation: No coverage uploaded for pull request base (dev@e3779ae). Click here to learn what that means.
The diff coverage is n/a.

@@          Coverage Diff           @@
##             dev     #431   +/-   ##
======================================
  Coverage       ?   90.77%
======================================
  Files          ?       17
  Lines          ?     2438
  Branches       ?        0
======================================
  Hits           ?     2213
  Misses         ?      225
  Partials       ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3779ae...4369a11. Read the comment docs.

Can this PR be reviewed please?


Message Menus

Hi! I tried implementing Message Menus. https://github.com/SlackKit/SlackKit/issues/95
Thanks.

This looks great, thanks for the PR!


[Bug] Axis Pointer for connected charts is not visible if chart series0 is outside the zoom range

Version
5.5.0
Link to Minimal Reproduction
https://codepen.io/Sarra-Khazri/pen/LYoKLaM?editors=0010
Steps to Reproduce
Hover on each points in chart 1 and chart 2 to see the behavior of axis pointer
Current Behavior
when i zoom on y and the series with zero values are outside the zoom range, the chart's axisPointer will be invisible it is the same issue described https://github.com/apache/echarts/issues/17074
The system seems to only determine whether there is data based on seriesIndex=0. If there are two or more series in the chart, and the series0 data is out of the coordinate system, the series1 data will still not have an axisPointer in the coordinate system,

thank you.
Expected Behavior
I want to have the axis pointer always visible on x axis even there is zoom  y on others charts and points are not in zoom range
Environment
OS:windows
- Browser: chrome
- Framework: -

Any additional comments?
The system seems to only determine whether there is data based on seriesIndex=0. If there are two or more series in the chart, and the series0 data is out of the coordinate system, the series1 data will still not have an axisPointer in the coordinate system,

I want to have the axis pointer always visible on x axis even there is zoom y on others charts and points are not in zoom range

Axis pointer is dependent on tooltip, which is dependent on point.
When point is invisible, there is no tooltip, thus no pointer. Logical, no?

I want to have the axis pointer always visible on x axis even there is zoom y on others charts and points are not in zoom range

Axis pointer is dependent on tooltip, which is dependent on point. When point is invisible, there is no tooltip, thus no pointer. Logical, no?

Hello @helgasoft, i think that the sync is not working correctly even there is point as you mentionned can you check please my screenshots

Ok, I see one exception to the rule "no visible point == no pointer". The leading (mouse) chart pointer is displayed when there is a null-data point (example 1)
But this does not explain your example 3, where the pointer for 6/21 does not show up in the first chart even though it has data for that day.
So yes, I agree, the pointer algorithm is not very clean.


dataAccesses function doesn't know about the extractFromUVCI function yet

The certlogic-js/validation/dataAccesses function doesn't handle the new extractFromUVCI operation yet.

Fixed by PR #60


The remote name could not be resolved: 'localworker.blob.core.windows.net'

The remote name could not be resolved: 'localworker.blob.core.windows.net' getting an error while action execute

I'm seeing this too


Allow non-polymorphic ("private") extension of base classes

🔍 Search Terms
private non-polymorphic non-assignable inheritance extension subclass change method signature of base class
✅ Viability Checklist

[X] This wouldn't be a breaking change in existing TypeScript/JavaScript code
[X] This wouldn't change the runtime behavior of existing JavaScript code
[X] This could be implemented without emitting different JS based on the types of the expressions
[X] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
[X] This isn't a request to add a new utility type: https://github.com/microsoft/TypeScript/wiki/No-New-Utility-Types
[X] This feature would agree with the rest of our Design Goals: https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals

⭐ Suggestion
I would like to write an ES6 class that does not inherit the typing of its base class (and thus doesn't expose any properties or methods defined in the base class, unless they are overridden in the subclass). In C++ I would call this "private inheritance", but in short: I would like to be able to use the implementation of a class (by using the super keyword in a method) without declaring my instances to be assignment-compatible.
📃 Motivating Example
To the best of my knowledge, there are currently no ways to express this in TypeScript. In pure JavaScript, I can write the following:
export class MyTuple extends Array {
  constructor(...args) {
    super();
    this.push(...args);
    Object.freeze(this);
  }
}

Instances of the MyTuple class, despite extending the Array prototype, don't conform to the Array contract, as all of the mutation methods will throw a TypeError. Even worse, direct array element assignment will silently fail, as assignment to a read-only property is simply ignored. However, the only way to get TypeScript to output this JS code is to use a TypeScript class declaration, and these always propagate the base class typings.
In this particular case, the class is a better match for the ReadonlyArray interface, so ideally I could write the following in TypeScript:
export class MyTuple<T> extends private Array<T> implements ReadonlyArray<T> {
  constructor(...args: readonly T[]) {
    super();
    this.push(...args);
    Object.freeze(this);
  }
}

💻 Use Cases

What do you want to use this for?
In my current project, I'm writing a variable-dimensionality geometry library in which the Point class is a specialization of Array<number>. Point is a generic class with the signature Point<Dims extends number>, so a 2D point is a Point<2>, a 3D point is a Point<3>, etc. Using Array as the base class provides a number of advantages, like being able to use .map() in order to create a new Point with the same dimensionality, based on the existing. However, most of the Array functionality shouldn't be exposed to consumers; in particular, anything that modifies the length of the array or creates an array of different length (push, slice, etc) would cause improper typing.
What shortcomings exist with current approaches?
Well, first off, the return type of .map() is incorrect because of #10886; it and all the other copy-instantiating methods should return a Point but instead return number[]. I can't use declare to override the method signature directly because of #38008 and #48290, and TS won't allow me to override it as a property because the types don't match.
What workarounds are you using in the meantime?
I'm removing the typing entirely by casting Array to a dummy constructor of Object:export class Point<Dims extends number = 2> extends (Array as new () => Object) implements PointLike<Dims> {

Previously I'd been casting it to a constructor of readonly number[], but that didn't work because, as mentioned above, I need to declare map() as a method that returns a Point, and the existing number[] return signature can't be cast to a Point derived from readonly number[]. So now I'm casting it to Object, which comes with a fairly serious drawback: I can no longer use the super keyword in my methods, because TS now thinks that super is type Object, and I can't even correct it - the super keyword can't have a type assertion applied to it, as mentioned in #41034.

Now I go to write a lot of type assertions and // @ts-expect-error comments, because so far as I can tell, there is no other way around this.

This is also possibly related to #4628. Not in the sense that my issue is affected by static inheritance, but because if this issue were resolved by the addition of something like the extends private mechanism described here, that could also be used to resolve 4628, by allowing decoupling of inherited members vs exposed members.

It occurs to me that one radical way to solve this problem would be to add some syntax that allows you to suppress creating the interface portion of the class altogether. Then you could simply define the interface separately with whatever subset of the actual functionality you want to expose, and then the ES6 class definition just gets matched against that interface, rather than generating the interface itself.
...Huh. This actually feels like a useful and actionable feature. You could rewrite the original example like this:
// This line is the only definition of the MyTuple<T> type
export interface MyTuple<T> extends ReadonlyArray<T> { }
// A private class is one whose types are not visible to the outside. It has signature { } or possibly object.
export private class MyTuple<T> extends Array<T>
// This one implements the MyTuple<T> interface to ensure that it matches its public API
    implements MyTuple<T> {
  constructor(...args: readonly T[]) {
    super();
    this.push(...args);
    Object.freeze(this);
  }
}

What do you think?

@dmchurch You can use a class expression to make it "private".
// This line is the only definition of the MyTuple<T> type
export interface MyTuple<T> extends ReadonlyArray<T> { }
// A private class is one whose types are not visible to the outside. It has signature { } or possibly object.
export const MyTuple = class<T> extends Array<T>
// This one implements the MyTuple<T> interface to ensure that it matches its public API
    implements MyTuple<T> {
  constructor(...args: readonly T[]) {
    super();
    this.push(...args);
    Object.freeze(this);
  }
}

Note that you MUST NOT use the name MyTuple for the class expression. Use any other name or anonymous instead, otherwise the interface MyTuple<T> declared in the outer scope will be shadowed.

I was looking for something similar, I wanted my subclass to be a readonly array. After playing with all the possibilities I managed frankenstein this together from the bits an pieces on StackOverflow and this repos issues.
function ReadonlyArrayCtor(): { new <T>(...items: readonly T[]): ReadonlyArray<T> } {
    return Array as any;
}

export class MyTuple<T> extends ReadonlyArrayCtor()<T> {
    constructor(...args: readonly T[]) {
        super(...args);
        Object.freeze(this);
    }
}

let vec = new MyTuple(1, 2);

vec[1] = 100; // error

Playground
Kinda works. But couldn't make it an actual tuple though. Even casting the constructor factory to readonly [number, number] did not limit the subclass to only 2 indexes. I guess extends broadens the type to have "at least two".
function ReadonlyArrayCtor(): { new (x: number, y: number): readonly [number, number] } {
    return Array as any;
}

export class MyTuple<T> extends ReadonlyArrayCtor() {
    constructor(x: number, y: number) {
        super(x, y);
        Object.freeze(this);
    }
}

let vec = new MyTuple(1, 2);

let x = vec[0]
let y = vec[1]
let z = vec[2] // no error

vec[1] = 100; // error

Playground


Initial project feedback

Hello, do you perhaps have a demo video that has been uploaded so that we can view it. Looking at the deployed application, I seemed to be getting a lot of errors (javascript one) when trying to interact with it.
The faucet triggers ok. but everything else doesn't seem to work. I tried the LINK token as well as all the ones in your provided txt file.

Hello, I have worked through this week to fix the UI. Now it should work as intended.
The link to the video recording is now on README.md.

Closed.


Hook up Dropbox and Google Drive uploading

I've hooked up the relevant code for this and deployed to staging. But it seems that both Dropbox and Gdrive don't allow referrers from non-production URLs, so I can't fully test this yet. I've not used these services before, is it easy to setup staging versions?

Great, will update for staging and test this out.

Update: Dropbox referrer URL updated, tested, and it works.
Google upload failed because we're missing the API key, https://github.com/hotosm/oam-catalog/blob/oauth-login/worker/process-image.js#L29.
Next step, add google drive API key back into config.

Added the API key as a variable in the config and it works, fix in https://github.com/hotosm/oam-catalog/pull/113


kube-controller IPAM gc controller should gc Evicted status POD leaked IP .....

IPAM gc controller will release leaked IP that Pod not find in cluster,
An Evicted Status Pod evicted by kubelet is an "Stable" status ,  it is safe to gc leaked IP about it auto ....
Evicted Status Pod will  clean by kube-controller-manager podgc manager  when "failed" status pod num > 12500 (default),  it maybe more  IP resource ....
When use "ipReservation" it maybe more  serious ....
Expected Behavior
IPAM gc controller should gc Evicted status POD leaked IP
Current Behavior
// ipam.go
// func allocationIsValid

        ......

	// Check to see if the pod actually has the IP in question. Gate based on the presence of the
	// status field, which is populated by kubelet.
	if p.Status.PodIP == "" || len(p.Status.PodIPs) == 0 {
		// The pod hasn't received an IP yet.
		log.Debugf("Pod IP has not yet been reported, consider allocation valid")
		return true
	}

        /*
        ##############
	if p.Status.Phase == v1.PodFailed && p.Status.Reason == "Evicted" {
		logc.Debugf("Pod has failed with Evicted. Allocation no longer valid")
		return false
	}

	// should think this evicted Status as  no longer valid ....
	#################
        */
        .......

Steps to Reproduce (for bugs)

create POD with calico CNI ....
evict pod by kubelet with disk or mem pressure , down kubelet or machine,  or change CNI config  make  POD clean up failed ....

Your Environment

Calico 3.19 , 3.25
Orchestrator version (e.g. kubernetes, mesos, rkt):  kubernetes
Operating System and version: Linux kernel 4.19

@gaopeiliang could you provide me an example of a full pod yaml in an evicted state? It would help me understand the state a bit better.
e.g.,
kubectl get pod evicted-pod -o yaml

@gaopeiliang could you provide me an example of a full pod yaml in an evicted state? It would help me understand the state a bit better.
e.g.,
kubectl get pod evicted-pod -o yaml

yes .....
calicoctl_3_25 ipam check --allow-version-mismatch --show-problem-ips

...   ...   ...
<IP_ADDRESS> leaked; attrs Main:k8s-pod-network.4ed2ba44a06814adca57e97b869da7d5b27547f2e6b93b36a923d36618cd2b29 Extra:namespace=kube-system,node=x.x.x.x,pod=vm-k8s-stack-kube-state-metrics-7fffddf6bb-xtn7g,timestamp=2022-06-06 12:05:14.766219271 +0000 UTC

get pod -o yaml

apiVersion: v1
kind: Pod
metadata:
  annotations:
    cni.projectcalico.org/podIP: ""
    cni.projectcalico.org/podIPs: ""
    k8s.v1.cni.cncf.io/network-status: |-
      [{
          "name": "k8s-pod-network",
          "ips": [
              "<IP_ADDRESS>"
          ],
          "default": true,
          "dns": {}
      }]
    k8s.v1.cni.cncf.io/networks-status: |-
      [{
          "name": "k8s-pod-network",
          "ips": [
              "<IP_ADDRESS>"
          ],
          "default": true,
          "dns": {}
      }]
  creationTimestamp: "2022-06-06T12:05:13Z"
  generateName: vm-k8s-stack-kube-state-metrics-7fffddf6bb-
  labels:
    app.kubernetes.io/component: metrics
    app.kubernetes.io/instance: vm-k8s-stack
    app.kubernetes.io/managed-by: Helm
    app.kubernetes.io/name: kube-state-metrics
    app.kubernetes.io/part-of: kube-state-metrics
    app.kubernetes.io/version: 2.3.0
    helm.sh/chart: kube-state-metrics-4.4.3
    pod-template-hash: 7fffddf6bb
  name: vm-k8s-stack-kube-state-metrics-7fffddf6bb-xtn7g
  namespace: kube-system
  ownerReferences:
  - apiVersion: apps/v1
    blockOwnerDeletion: true
    controller: true
    kind: ReplicaSet
    name: vm-k8s-stack-kube-state-metrics-7fffddf6bb
    uid: 6386eb99-5e9a-4799-9643-897329e9faaf
  resourceVersion: "69565652"
  uid: 004704bb-d133-42ac-90bd-1e51516ab18d
spec:
  containers:
  - args:
    - --port=8080
    - --resources=certificatesigningrequests,configmaps,cronjobs,daemonsets,deployments,endpoints,horizontalpodautoscalers,ingresses,jobs,limitranges,mutatingwebhookconfigurations,namespaces,networkpolicies,nodes,persistentvolumeclaims,persistentvolumes,poddisruptionbudgets,pods,replicasets,replicationcontrollers,resourcequotas,secrets,services,statefulsets,storageclasses,validatingwebhookconfigurations,volumeattachments
    - --telemetry-port=8081
    image: k8s.gcr.io/kube-state-metrics/kube-state-metrics:v2.3.0
    imagePullPolicy: IfNotPresent
    livenessProbe:
      failureThreshold: 3
      httpGet:
        path: /healthz
        port: 8080
        scheme: HTTP
      initialDelaySeconds: 5
      periodSeconds: 10
      successThreshold: 1
      timeoutSeconds: 5
    name: kube-state-metrics
    ports:
    - containerPort: 8080
      name: http
      protocol: TCP
    readinessProbe:
      failureThreshold: 3
      httpGet:
        path: /
        port: 8080
        scheme: HTTP
      initialDelaySeconds: 5
      periodSeconds: 10
      successThreshold: 1
      timeoutSeconds: 5
    resources: {}
    terminationMessagePath: /dev/termination-log
    terminationMessagePolicy: File
    volumeMounts:
    - mountPath: /var/run/secrets/kubernetes.io/serviceaccount
      name: vm-k8s-stack-kube-state-metrics-token-g4g7r
      readOnly: true
  dnsPolicy: ClusterFirst
  enableServiceLinks: true
  nodeName: <IP_ADDRESS>
  preemptionPolicy: PreemptLowerPriority
  priority: 0
  restartPolicy: Always
  schedulerName: default-scheduler
  securityContext:
    fsGroup: 65534
    runAsGroup: 65534
    runAsUser: 65534
  serviceAccount: vm-k8s-stack-kube-state-metrics
  serviceAccountName: vm-k8s-stack-kube-state-metrics
  terminationGracePeriodSeconds: 30
  tolerations:
  - effect: NoExecute
    key: node.kubernetes.io/not-ready
    operator: Exists
    tolerationSeconds: 300
  - effect: NoExecute
    key: node.kubernetes.io/unreachable
    operator: Exists
    tolerationSeconds: 300
  volumes:
  - name: vm-k8s-stack-kube-state-metrics-token-g4g7r
    secret:
      defaultMode: 420
      secretName: vm-k8s-stack-kube-state-metrics-token-g4g7r
status:
  message: 'The node was low on resource: ephemeral-storage. Container kube-state-metrics
    was using 1147172Ki, which exceeds its request of 0. '
  phase: Failed
  reason: Evicted
  startTime: "2022-06-06T12:05:13Z"

Gotcha- thanks for that.
I agree the GC should handle this. Looks like Evicted pods may have their IPs scrubbed in the API (unlike some other forms of failed pods) and so the GC won't currently handle them.


Is "gfx.downloadable_fonts.woff2.enabled" privacy concern?

When gfx.downloadable_fonts.woff2.enabled is set to "false" then some web pages doesn't show navigation and other icons. Instead there is just a empty placeholder without functionality meaning.
Is there any concern not to set it back to default, that's the value "true"?

so where do you think the font came from .. a 3rd party .. how about someone like google kindly giving the world awesome font .. they did it for a reason

Idk about privacy, IMO it's disabled because of potential security issues. Startpage "woff exploit"

It would be great if someone makes an addon similar to Decentraleyes but for the most commonly used fonts.

You can do something about font awesome ... https://github.com/FortAwesome/Font-Awesome
I've installed in my WIndows, just not sure how to make requests for it use local .. or even checked if its doing anything. The linux guys I think posted a solution.. IDK

Nah... I have valid cases where I need those fonts.
I will enable this setting and deal with it though uBO /\.woff2(|\?.*)$/$third-party or /\.(ttf|woff|woff2)(|\?.*)$/$third-party

@crssi
IMO 1st-party fonts are even less trustworthy than fe. from fonts.googleapis.com, but the uBlock filters are a nice idea nonetheless and could be adjusted for other uses as well. Thank you

@earthlng sometimes I forget that I am browsing only sandboxed. ;)

@earthlng
I have over complicated uBO rule... this one if far better:
*$third-party,font

This tor fingerprint uses CSS + WOFF

This tor fingerprint uses CSS + WOFF

yeah but only for the page output, no?
For the fingerprint it only looks at window.navigator, getTimezoneOffset() and chrome://torbutton/locale/aboutTor.properties. And that fingerprint only detects the TBB version.

tor-fingerprint.js has two fingerprint variables.

Yes I saw that but it still doesn't use CSS or WOFF anywhere, does it?
btw, getTimezoneOffset now always returns 0, accessing chrome://torbutton/locale/aboutTor.properties is blocked and will always return an error object, and window.navigator will likely remain largely the same for all future versions. The only thing that will probably change is window.navigator.userAgent.
That means this fingerprint PoC is now basically an unnecessarily elaborate userAgent detector. xD

new-fonts.css calls the content of webfonts folder.


Cant enter anywhere

I Just cant read any hentai and also i cant log in

Today NHentai changed the site behaviour, so I will need to rewrite some part of the code.
The login and related settings probably will be removed because now for that procedure a ReCaptcha is required

Yeah,cant read cant log in

Is addition of recaptcha to the app not possible? I will miss being able to sync to my account.

I can't use their recaptcha because this isn't an official app

@Dar9586 maybe you could try webview inside the app so users can login?

Yesterday and today I tried to use the webview, but even if I log-in and copy all the cookies into the app the site will not show any user related data, like I didn't make the login. Maybe there is some protection to avoid it, but because of that it doesn't seem possible to use it.

Is addition of recaptcha to the app not possible? I will miss being able to sync to my account.

I can't use their recaptcha because this isn't an official app

@Dar9586 maybe you could try webview inside the app so users can login?

Yesterday and today I tried to use the webview, but even if I log-in and copy all the cookies into the app the site will not show any user related data, like I didn't make the login. Maybe there is some protection to avoid it, but because of that it doesn't seem possible to use it. (I think that it is a cloudflare protection feature)

Did you try changing User-Agent value to something like windows chrome like this: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/74.0.3729.169 Safari/537.36 ? idk if this will help trying to contribute as much as possible lol

Is addition of recaptcha to the app not possible? I will miss being able to sync to my account.

I can't use their recaptcha because this isn't an official app

@Dar9586 maybe you could try webview inside the app so users can login?

Yesterday and today I tried to use the webview, but even if I log-in and copy all the cookies into the app the site will not show any user related data, like I didn't make the login. Maybe there is some protection to avoid it, but because of that it doesn't seem possible to use it. (I think that it is a cloudflare protection feature)

Did you try changing User-Agent value to something like windows chrome like this: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/74.0.3729.169 Safari/537.36 ? idk if this will help trying to contribute as much as possible lol

The app use a custom user agent, I changed the web view to the same user-agent and the login worked (so it has not been blacklisted), the problem is that I can't use the login data of the web view inside the app. In the web view I have a limited access to the configuration but I tried make all of them  similar to the app configuration without success.
I reinplemented the online code, now it is only disabled, and I will try to use other method to execute the login. But it could require some time

Hmm maybe you can try an headless webview process to gather the data? put an setting to enable it making an headless webview constantly running may cause performance issues


Eliminated speed_limit and vehicle_only params

Removed from client API
Removed from GUI
Updated these in test_cloud (along with other test cloud calls)

Should be in sync with this PR in Cloud: https://github.com/santosfamilyfoundation/SantosCloud/pull/97


Implement usage of caseless GitLab group and project names

Currently only GitLab project and group names are accepted as composer packages, with the following valid chars a-z0-9_.- (the letters only in lowercase)
Next version will also support upper case letters A-Za-z0-9_.-
But beware! This may result in some problems! Composer does not support this format. So there is the need to converting a project full path to lower case. So Foo/Bar will be used as composer package name foo/bar but Foo/bar can be a different GitLab project but not a different composer package

Done!
Add a new configuration property caseless. If you set it to true also gitlab projects with upper case letters in group and/or project name, can be used.


OAK-6911 - Provide a way to tune inline size while storing binaries

Changes have been committed to SVN.


Add more reliable way to detect keyboard interrupts

Hi!
Hats off to you for throwing this library together, it's a pleasure to use.
I'm using your library for a project of mine. In my usage, I don't really care if the user hit esc to exit the fuzzy finder or ctrl-c, they're the same as far as I'm concerned. However, in order to ignore keyboard interrupts, I have to match on the error description directly, which is cumbersome at best. Here's how I deal with it in my application
fn remap_picker_result<T>(result: Result<Option<T>, io::Error>) -> Result<Option<T>, io::Error> {
    match result {
        Ok(data) => Ok(data),
        Err(err) => {
            // There is no way to other way do this without producing a copy.
            // The library guarantees that this wil be the message for a keyboard interrupt.
            // So, while brittle, it does work.
            #[allow(deprecated)]
            if err.kind() == io::ErrorKind::Other && err.description() == "keyboard interrupt" {
                Ok(None)
            } else {
                Err(err)
            }
        }
    }
}

The docs do state that "keyboard interrupt" will be the message, so I suppose it's part of the contract, but I would love the ability to either

Reliably detect if ctrl-c was hit, vs esc (I imagine there are some applications where such differentiation would be useful)
The ability to tell nucleo-picker to treat esc and ctrl-c as equivalent. That is, Picker::pick() should return Ok(None) for both.

Glad you enjoy using the library! If esc is pressed, the picker returns Ok(None), so (1) is already handled, at least as far as I understand what you mean. But (2) is definitely not possible in a non-brittle way (though what you've written is definitely fine in the short term; I promise I won't break this!); and also precludes more general solutions such as the option to ignore ctrl-c entirely.
This is a sensible request in my opinion, though I do need to think about the best way to handle this. I am eventually planning to allowing customization of keybindings in some form which would definitely be one solution. Another option would be a customizable on_abort callback which hooks directly into the internal Abort event.
One reason I have been putting this off is that eventually I want to incorporate better restart handling that does not require closing and re-opening the picker interface (which is the only possible solution currently). So I do not feel that the internal event handling is ready to be made public yet.

Event handling implementation is tracked in #43

Thanks so much for the thoughtful reply! One note

(1) is already handled, at least as far as I understand what you mean.

It's not quite there; sorry if I was unclear. Right now, I can tell if esc was pressed, but there is no non-brittle way to say "the picker was closed because a user hit ctrl-c" vs "the picker was closed because they hit esc". I could imagine a hypothetical API looking like
enum Error {
  IOError(io::Error)
  UserCancelled
  KeyboardInterrupt
}

impl <T, R: Render<T>> Picker<T, R> {
  fn pick(&mut self) -> Result<T, Error>
}

Then, a consumer could match on UserCancelled or KeyboardInterrupt, and handle each case as they wish (e.g. mark the operation non-fatally aborted). This would obviously be a breaking change, but it serves to illustrate the point :)


Azure blob offload cannot connect to older instance of azurite

Describe the bug
Running an older instance of azurite, after updating the Azure blob client libraries we can no longer connect:
Caused by: java.util.concurrent.ExecutionException: com.azure.storage.blob.models.BlobStorageException: Status code 400, "<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<Error>
  InvalidHeaderValue
  <Message>The value for one of the HTTP headers is not in the correct format.
RequestId:9ac1dcdd-f371-47b1-bad5-d04060811be4
Time:2022-08-09T23:06:16.790Z</Message>
  <HeaderName>x-ms-version</HeaderName>
  <HeaderValue>2021-06-08</HeaderValue>
</Error>"

Need to provide a way to specify the service version when constructing the Azure Blob client.
Environment
Which version of IBM FHIR Server? 5.0.0-SNAPSHOT
To Reproduce
Run older azurite container with newer client.
Expected behavior
The FHIR server should be able to connect.
Additional context
Mostly an issue with bit rot in local test environments. Updating the container would probably address this, but we should also allow configuration to control the service version used by the client, as offered by the blob client API.

Also found that the payload offload parse call was ignoring the elements variable so no subsetting was supported, causing integration test failures with the Azure e2e updated added to the CI pipeline.

I updated the demo env locally to use an old version of azurite (3.10.0).  After this the fhir-server image was crashing during startup.  I then updated the config to specify the specific API version supported by azurite 3.10.0 (2020-04-08) and it started working again.
I then proceeded to create a Patient resource (with payload still offloading enabled) and then read it back out with an _elements=identifier filter.  This is working as expected.


Verify notation AWS Signer plugin installation

Verify notation AWS Signer plugin installation during image build.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/approve


Global search spawn error (v1.54.3)

Trying to run a global search immediately fails and renders the following error:

Threads for a couple similar-seeming issues suggested checking that the file at the indicated URL actually exists which I have confirmed.

VS Code Version: 1.54.3 (Universal)
OS : Darwin x64 ~19.6.0~ 20.3.0 / Big Sur 11.2.3 (upgraded OS during troubleshooting)
Commit: 2b9aebd5354a3629c3aba0a5f5df49f43d6689f8
Date: 2021-03-15T11:57:12.728Z
Electron: 11.3.0
Chrome: 87.0.4280.141
Node.js: 12.18.3
V8: <IP_ADDRESS>-electron.0

Steps to Reproduce:

Simply run any global search

Does this issue occur when all extensions are disabled?: Yes

Is there any reason you wouldn't have permission to access that binary? Can you run it from a terminal?

Is there any reason you wouldn't have permission to access that binary? Can you run it from a terminal?

None that I'm aware of.  When I run from terminal it seems to at least execute:
$. /rg
error: The following required arguments were not provided:
    <PATTERN>

USAGE:

    rg [OPTIONS] PATTERN [PATH ...]
    rg [OPTIONS] [-e PATTERN ...] [-f PATTERNFILE ...] [PATH ...]
    rg [OPTIONS] --files [PATH ...]
    rg [OPTIONS] --type-list
    command | rg [OPTIONS] PATTERN

For more information try --help

Did you install VS Code in an unusual way or as a different user?

Not that I am aware of; certainly not as a different user.  I recently re-installed VS Code for troubleshooting purposes but did so strictly through the the normal download/install flow.

Please do the following

Run the command "Set log level" and change it to "Trace"
Run the search again
Show the search-related messages in the "Log (Window)" output panel

I think the next possibility is that the problem is with one of those folders. Do you get the same error when searching other folders?
You can also try running the exact command yourself to see if you get the same result. For example,
cd /Users/jlow/Dev/random-scripts
/Applications/Visual Studio Code.app/Contents/Resources/app/node_modules.asar.unpacked/vscode-ripgrep/bin/rg --hidden --case-sensitive -g '**/*.tsx/**' -g '**/*.tsx' -g '!**/.git' -g '!**/.svn' -g '!**/.hg' -g '!**/CVS' -g '!**/.DS_Store' -g '!**/node_modules' -g '!**/bower_components' -g '!**/*.code-search' --max-filesize '17179869184' --no-ignore-parent --follow --crlf --auto-hybrid-regex --regexp 'test' --no-config --no-ignore-global --json -- '.'

Ok looks like your intuition was correct.  Removing the problem folder solved the issue.  Thanks for your help, @roblourens.

Great, out of curiosity, where did the issue come from?

The cockroachdb/ui and dsa paths broke search.  I don't have the slightest clue as to why but adding/removing each of them toggles search between broken/working state.


ODBC temp tables issue

If we create temp table via:
SQLPrepareW
SQLExecute

temp table will be deleted after execute (statement lifetime). I couldnt find any information in docs about this.
But if we create temp table via:
SQLExecDirect
temp table will be alive to end of session (session lifetime). So it works how it described it docs.
There are two different behaviors for temp tables depends on how you execute queries. I think it should be documented somewhere.

@Jihadist -- Anton, thank you for your feedback.  Are you following a particular learn.microsoft.com article?  Meanwhile, please consider these resources:

SQL Server on Microsoft Q&A
DBA Stack Exchange
Stack Overflow

@WilliamAntonRohm I tried to google it but no results

@Jihadist -- Anton, thank you for your follow-up.  This repo is solely for documentation issues, and this seems implementation-related.  To which "docs" are you referring?

temp table will be alive to end of session (session lifetime). So it works how it described it docs.
There are two different behaviors for temp tables depends on how you execute queries. I think it should be documented somewhere.

To which "docs" are you referring?

https://learn.microsoft.com/en-us/sql/odbc/reference/syntax/sqlprepare-function
https://learn.microsoft.com/en-us/sql/odbc/reference/syntax/sqlexecdirect-function
https://learn.microsoft.com/en-us/sql/t-sql/statements/create-table-transact-sql

This is an implementation-specific issue with the ODBC library, and is outside of the scope of CREATE TABLE documentation.
#please-close

This is an implementation-specific issue with the ODBC library
Nope, it works the same with all microsoft odbc drivers. Can it be mentioned somewhere in docs?

@rwestMSFT -- Randolph, please look into this potential documentation issue.

@Jihadist The ODBC API specification doesn't document driver-specific implementations. (I know, it can be confusing since it's hosted by Microsoft and we also produce ODBC drivers for SQL Server.)
This is documented by the ODBC driver implementation for SQL Server ODBC drivers. Here is a reference:

Prepared statements cannot be used to create temporary objects on SQL Server.

https://learn.microsoft.com/en-us/sql/relational-databases/native-client-odbc-queries/executing-statements/prepared-execution?view=sql-server-ver16
Regards,
David


Quaternion: Use template type instead of single hardcoded type

Fixes #135

Coverage remained the same at 100.0% when pulling c22050b38df33a23bad2b5c9f96804e608b99fed on kamilritz:fix_type into 9a30828a0a1d79e87fd09653bb9f936d7ca0ba17 on PX4:master.


[kmac] err_chk state not consistent with the sha3 pad state

Hi Eunchan,
I want to confirm with behavior with you regarding the en_unsupported_modestrength usage.
Here is my sequence:
1). Set the en_unsupported_modestrength to 0 and set incorrect mode strength.
2). Issue start command -> SW err_code gives ErrUnexpectedModeStrength. (This is what we expect)
And we expect the sha3 engine to ignore this cmd start, and this is correct as well.
But in u_errchk, the state machines accept the cmd start and goes to MsgFeedstate.
===> This is NOT what I expect.
3). Continue to stream in kmac message -> SW err_code gives ErrSwPushMsgFifo. (This is what we expect as well)
4). Issue process cmd -> Here design does not return an error.
===> This is not what I expect.
I think it would make more sense to align the u_errchk/st with the sha3 engine state.
Please let me know what you think!

Thanks! I will check the design and fix the behavior


Can't open Go file with chinese characters

As a developer,
I want to be able to see if my w and W implementation works in non-ASCII text files,
so that I can fully test it.
The program is currently panicking because of the Bounds.Base going to far. Looks like a classic byte count instead of rune count problem.

No longer implemented


Fixed typo in stepper pages and docs

Fixed typo in stepper pages and docs
And fixed small typo in data table pages and gauge docs

Thanks, merged!


Optimizing SSR Bundle size

Hello. This actually is a story behind one of our nuxt based production applications, some workarounds was used to make ssr bundle smaller and much much more faster. All of them are implemented in nuxt-helpers/optimize.js and tested against nuxt 0.9.9.
About one week ago just after first deployment, i just figured out that SSR is really slow (~8req/sec with 1 worker) so the first thing i have checked was big ssr bundle size (~800kb), thanks to super useful nuxt extend function, i have enabled BundleAnalyzerPlugin for server side like this :
extend (config, {isServer}) {
    if (isServer)  config.plugins.push(new BundleAnalyzerPlugin({}));
}

The result was shucking

sass and css files where bundled
They are really useless for server-side and just make things much slower. unfortunately without some hacks it is not possible to remove them from bundle. so i have used ignore-loader plugin to bypass vue loader :
  ['scss', 'css'].forEach(function (ext) {
            config.module.rules[0].query.loaders[ext] = 'ignore-loader';
   });

vendors are not externalized
We are just externalizing direct dependencies in package.json (like vue documentation example) but if we have indirect dependencies like nuxt-helpers they will be loaded into SSR bundle and have to parsed/loaded on each request! Simple workaround was adding nuxt.js vendors to externals too :  config.externals = _.uniq(config.externals.concat(nuxt.build.vendor));
unnecessary babel presets
If you look in bundle analyzer result again, you will see big core-js and regenerator runtimes packaged with bundle. As a first attempt i just tried to externalize them like other vendors, but unfortunately this won't work and will throw run-time errors as they should be required by default. Worst than it babel is compiling many lines of code into older js syntax which makes code slower, many of them (including async/await are now enabled in modern & stable node.js releases and are much much much faster than babel compiled code.  I have used this workaround to reduce amount of presets and just compiling a modern SSR bundle :)  It would be great if nuxt.js just has a built-in option to enable this optimization.
The result

Bundle size is now about 9x smaller (under 100kb), it is much faster because no vendors are included and are cached and much much faster because of using modern native async/awaits. I can't exactly remind but SSR was handling ~150requests/sec with 4 workers using optimizated version. 😎
Extra 1
I was also tried new vue ssr bundle format with no luck (mentioned problems just exists and code splitting didn't helped a lot)
Extra 2
Also during last hack i have found a bug in nuxt extend function! base.config.js is applying defaults to bable options on original object. so if some one changes anything shared in  extend for server, it will be applied to client options too! Although no one should do this it can be easily fixed and prevented by extending on a new object like this : defaults({}, this.options,...

Hi @pi0 thank you for your implication with nuxt.js. I will take a deeper look at it and come back to your later.
Actually, I am implementing Vue 2.2 which will let us add the CSS used by the rendered components directly in the <head> so the CSS might be needed in the server bundle.

@pi0 what was your "workaround" to compile against modern node and native async/await feature?
your link is not-found now.

The 0.10 release it out ✋
@pi0 do you mind checking again an give me a feedback now? 😃

@Atinux Congratulations for this release :)  I'm going to experiment new features and upgrade things :) Will come back soon.

@Atinux  As first attempt i started migration of static BootstrapVue docs. Generated html files are so HUGE  (~176kb each) including entire Bootstrap css.
I then tried moving imports from css in nuxt.config to layout files (with import directive) but still same behavior... Is it an expected one? And if so what is your suggestion? :(

@pi0 for the html files, only one needs to be loaded by the browser, and gzipped, the size is 26.9KB.
What about using your CDN to include the bootstrap CSS instead?
nuxt.config.js
module.exports = {
  head: {
    link: [
      { type: 'text/css', rel: 'stylesheet', href<EMAIL_ADDRESS>},
      { type: 'text/css', rel: 'stylesheet', href<EMAIL_ADDRESS>},
  }
}

I need to remove the warning for the moment, actually I was thinking of letting the option for the user but extracting the CSS does not help to improves the performances and getting closer to PWA.

@Atinux I Agree :)) It was my bad resisting on new technology just because older one WORKS :)) Closing this PR to keep Issues clean. Will provide a fresh report next week when I've researched enough about available solutions :)
Thanks for your hard work on awesome Nuxt ;)

Thanks to you for helping us to make Nuxt.js better :)


Add model support to Menu GateFilter

Pass a model to the Gate for authorizing actions.
Larvel Documentation:
if (Gate::allows('update', $model)) {
    // The current user can update the post...
}

Usage:
$event->menu->add([
    'header' => 'HEADER',
    'can' => 'update',
    'model' => $model
]);

closes #125

Thanks you very much! Congratulations to your first merged PR ;-)


Need a test for signing out during indexing

Test to make sure that if you sign out during indexing, and then sign in to a different account, all old data is cleared and no data from the original account gets pulled.

Closing this issue since the signout mechanism has been updated: now it's an async call, that waits for all of the processing queues to get drained.
Thanks!


libtxt: crashes

Running the "TextSpan Fuzzer" feature of the dev/manual_tests/text.dart test (see #12791) crashes the engine in a few seconds.
This is critical for stability. It's not a regression; the old text rendering code crashed a lot also.
(The test doesn't yet try to avoid running out of memory, because right now the test doesn't run long enough for that to happen. In due course we'll have to update the test to avoid crashing due to OOM.)

@jason-simmons Assigning this to you since you said this is what you were working on.

This should be stable now


build instructions for ios

Do you have a guide how to compile this as a fat library for all required ios architectures (x86_64, armv6, armv7, ...)?

Hey @mlostekk you can use cmake.

brew install cmake
navigate to the dir that you cloned libsamplerate
then follow the instructions here https://cmake.org/cmake/help/latest/manual/cmake-toolchains.7.html#cross-compiling-for-ios-tvos-or-watchos OR make use of this repo https://github.com/leetal/ios-cmake which has already some predefined flags for different iOS Platforms for example the -DPLATFORM=OS64COMBINED will build a FAT library for Device & Simulator arch only for (x86_64, arm64). Regular cmake variables/flags/options can be used as well. Note that the flag mentioned as an example will not include armv7... or any older arch types.

Thanks @Katko !

Hey @erikd I was using GitHub repo mentioned above to build libsamplerate but I stumbled upon an issue with some unsigned code. I am sharing below the error message and the environment used. Looks like it is something coming from one of the test files in libsamplerate any ideas how to resolve it?
Error
Check dependencies
Code Signing Warning: "snr_bw_test" isn't code signed but requires entitlements. It is not possible to add entitlements to a binary without signing it.
Code Signing Error: Code signing is required for product type 'Application' in SDK 'iOS 12.4'

** BUILD FAILED **

Environment
cmake version 3.15.2
Xcode 10.3

snr_bw_test is a program in the test suite. I know nothing about iOS dev.


Adding last version node-sass in example project

I have follow your suggestion  and adding the last node-sass version in the package.json file within the example folder has helped me.
Here is the pull request.
Thanks again for your help!

Sorry, I accidentally merged https://github.com/lookback/meteor-emails/pull/99 before this one: would you mind rebase/merge in master into your branch? Thanks so much.

I did that in PR #101 - as I caused the problem to begin with, its the minimum.
Maybe its worth to push to atmosphere after this.
So it fixes the problem for all those who depend on the package via atmosphere. At the moment their apps fail to run.

Ok, cool. Closing in favour of https://github.com/lookback/meteor-emails/pull/101.
@droka Yep, will push to Atmosphere.


PI-8971 Empty register page with loading indicator

Pull Request Test Coverage Report for Build 1774

0 of 7 (0.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.06%) to 42.163%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pages/routes.js
0
3
0.0%

pages/Register/index.jsx
0
4
0.0%

Totals

Change from base Build 1769:
-0.06%

Covered Lines:
1513

Relevant Lines:
3453

💛  - Coveralls