Feature/settings drawer back button

Button on the left

Button on the right

Which layout do you prefer? Button on the left or right of the drawer?

Which layout do you prefer? Button on the left or right of the drawer?

I would pick the right one. But still, this design does not seem harmonious to me. I think that if we are going to put the X there, we should center our content.
How many more options like these would we have in the future? I am asking this because if it is going to increase the number it might be interesting to move to accordions. Like this one:

Another option could be to have two buttons exit and save changes.  And we can actually save the preference of the user on the local storage since we don't have a database.

Button on the left

Button on the right

Which layout do you prefer? Button on the left or right of the drawer?

ahh the good old mac vs windows debate, as a windows user, i prefer it on the right.

Another option could be to have two buttons exit and save changes. And we can actually save the preference of the user on the local storage since we don't have a database.

Do we need the save changes button?  I think the settings are automatically saved  in onSettingsChange, where saveSettings will save it in local storage.

Another option could be to have two buttons exit and save changes. And we can actually save the preference of the user on the local storage since we don't have a database.

Do we need the save changes button? I think the settings are automatically saved in onSettingsChange, where saveSettings will save it in local storage.

Ya, i agree with auto save. It seems to be the trend for modern apps.

Updated changes

Updated changes

What do you think about adding a centered title, and left the content to the left as it were (sorry for this =/ )?  Like:
          Settings             [X]
----------------------------------
Trajectory Animations
----------------------------------
  op1  op2
  op3  op4

With this config, we will not have an empty white space looking like it's missing something

Updated with headings. Also included some unit tests for trajectory animations file so as to appease codecov complaining.

added more spacing between traj groups.

added more spacing between traj groups.

Thanks for the changes, it looks better!

Hi @ChawinTan , I really appreciate your proactivity and these tests, but a suggestion for next time, the tests that are not related to your changes or to the PR could you do it in another branch? What happens is the following: unfortunately, I will not be able to merge your changes from the drawer to the master because I left you some comments about the dashboard and trajectories tests.
HTH,

Got it. So if codecov is failing due to files that are not related to my branch, it's okay to merge the branch with codecov failing and then resolving the errors in a separate branch?
Will move the tests to a separate branch in the meantime

Got it. So if codecov is failing due to files that are not related to my branch, it's okay to merge the branch with codecov failing and then resolving the errors in a separate branch?
Will move the tests to a separate branch in the meantime since codecov is failing again

It seems to me that we can merge it if the new features that are in the PR has their corresponding tests. The reviewer is going to realize that. We will continue to have codebot errors due to the technical  debt that we are having (with test), little by little we will fix that.


License of trained weights?

Hi! I can see that the code is licensed under the MIT license.
Does this also apply to the weights of the trained model?

Hi, thanks for asking. The model is trained on data from Google Street View, therefore the MIT license doesn't apply to the weights of the trained model

I think this is worth mentioning in the LICENSE. For example it would mean that anyone using your model for e.g. the image matching challenge would be automatically disqualified.
I'm also wondering about the data from google street view, from my recollection they do not allow creating datasets:

Source: https://www.google.com/intl/en-GB_ALL/permissions/geoguidelines/
Am I misinterpreting what google is saying in these guidelines?


fix: display icons in the toolbox for extension categories

This PR displays the custom icons for extension categories instead of a color swatch in the toolbox.

Yep, exactly.


fix: range balance strategy not like reference

https://kafka.apache.org/31/javadoc/org/apache/kafka/clients/consumer/RangeAssignor.html

@njhartwell thanks for working on this. Are you happy to sign the Shopify CLA under your GitHub username?


doc: document lack of client caching

My implementation of OPStorage now depends upon behavior that is not currently documented.  This change simply documents that behavior.
Why would I do this?  Well, I want to pass additional information from the /authorize request though such that the LoginURL is completely different.   I do this by pulling information out of the http.Request before op.Authorize sees the request.  I add that info to the request Context and then use that information when handling the GetClientByClientID call so that I can later adjust what LoginURL does.   Yes, that's a bit hacky, but it's all good as long as the returned client is never cached.

Thanks for your PR. Can you please rebase against current main, so that the Go 1.20 test is run as part of merge requirements.

Thanks for your PR. Can you please rebase against current main, so that the Go 1.20 test is run as part of merge requirements.

done


Introduce the Ellipsis on long text in the card

Is your feature request related to a problem? Please describe.
Introduce the Ellipsis on long text in the card and hover on the text it will show the full text
Describe the solution you'd like.
using Ellipsis property
Describe alternatives you've considered.
using Ellipsis property  and same
Add any other context or screenshots about the feature request here.
No response

someone working on same issue


net/http: RoundTrip unexpectedly changes Request

https://go-review.googlesource.com/c/go/+/234894 causes (*http.Transport).RoundTrip to return a different *http.Request in the *http.Response than was passed to it, under some circumstances.
func main() {
        req, err := http.NewRequest("GET", "http://google.com/", bytes.NewBuffer([]byte{0, 1, 2}))
        if err != nil {
                log.Fatal(err)
        }
        resp, err := http.DefaultTransport.RoundTrip(req)
        if err != nil {
                log.Fatal(err)
        }
        fmt.Println(req == resp.Request) // false, where it used to be true.
}

The documentation for (http.Response).Request says, "Request is the request that was sent to obtain this Response." While this doesn't precisely specify that it's the exact *Request passed to RoundTrip, that's probably close enough to consider this an incorrect API change.
Discovered because this breaks code which keeps a map of *http.Requests.

Even prior to this change, RoundTrip would change the Request, but only when calling GetBody to rewind the body:
https://go.googlesource.com/go/+/0e617d3d5c7e89b1ad1b0285fc77314b8d056211/src/net/http/transport.go#588
Tracking the history of this behavior, I believe it originates with https://golang.org/cl/33971, which causes the HTTP2 transport to replace the request when retrying.
My first thought was that it seems odd to replace the entire *Request rather than just updating its Body field, but the http.RoundTripper documentation states:

RoundTrip should not modify the request, except for consuming and closing the Request's Body.

Replacing the *Request in RoundTrip only under unusual circumstances (when calling GetBody to reset the body) is error-prone; users may depend on the *Request passing through unchanged, and only encounter infrequent errors. I think the *Request should be replaced consistently, or never.
My inclination is to say that "never" is the right answer, since it causes the least disruption to existing users.
If that's the case, we could:

Change the RoundTripper contract to permit changing the request Body when GetBody is called. I think this is reasonable behavior, but I'm not certain if this would be consistent with our compatibility guarantees.
Temporarily replace the request Body, but put the original one back before returning.
Create a new Request when retrying, but return the original in the Response.

Requests are read-only data, immutable. I believe iis allowed today to call RoundTrip from multiple goroutines using the same request (provided Body = NoBody or nil). Mutating the Request would break that, introducing races.
The main time that Requests change and the reason Response records the final Request is when http.Client.Do follows redirects. That's the time when you most often need to look at the Response - to find out what the final fetched URL even was (if you care). Since they can change in Do, I'm not convinced it's important they can't change in RoundTrip.
Maybe we can say that the Response returned by RoundTrip always returns the original Request? I'm not sure. It's either that or decide the tests are broken. You can't mutate in place.
/cc @bradfitz

We'd only need to mutate the Request if the Body is neither NoBody nor nil, which are the cases where you aren't allowed to call RoundTrip from multiple goroutines.


[WIP] Generate API reference using documented decorator

Puts documented values into a private global index
Test that public values are marked as documented
Test that private values are not marked as documented

Couple of questions (I don't know the answers)

Why not try to do this by blacklisting and not whitelisting and use module name?
Do we care about module path not matching category?

It makes me uncomfortable to see so many files changed just to categorize objects. I think this is a fairly unusual approach for documenting python packages. If you want to do automatic reference doc generation with whitelisted class/object names you can definitely do that using only sphinx features.
Have you profiled if there's any impact on the time it takes to do import cirq with this change?
I think this is what @dabacon was suggesting, but you can probably just comb through all the public classes and use the module to indicate the category. You could even have an "exceptions" dictionary to re-categorize things (like e.g. for functions in utility modules)

I think this is a fairly unusual approach for documenting python packages.

This approach solves a few problems at the same time.

We need a way to associate docstrings with global constants.

We need to ensure the API list is kept up to date as new objects are added. This change includes a test asserting that the set of all the things passed into documented equals the set of all things found by scraping.

We need to categorize objects in a way that's not directly tied to the implementation details. For example, we may split gates into "basic" and "advanced" or merge the study package and the simulation package into just "simulation". The user-exposed categories are not necessarily the same as the internal-developer categories, which makes sense since they have different goals.

(3) could be solved reasonably well with a special annotation within the doc string.
(2) could be solved reasonably well by auto-generating the API.rst file by scraping. I do like that this approach makes it so explicit which values are top-level values.
For (1) I have no idea how to do it other than with the approach here. I guess we could try to find the source code where the constant is defined and parse out the comment right before it... ugh. We could limit this idea to just the constants instead of also decorating the functions.
Regardless of whether we do it with a decorator or a docstring section, we will need to touch all these files. This is a project-spanning issue.

For (1), there's some discussion on #2471
For (2), you could check that the set of all things listed in api.rst equals the set of all things found by scraping
(3) is already solved by headings / autosummarys in api.rst

Regardless of whether we do it with a decorator or a docstring section, we will need to touch all these files. This is a project-spanning issue.

I think this speaks to a philosophical design choice that maybe someone can come up with a name for. Should objects know how they're documented (ie their doc category) or should the documentation system keep a registry of how things are documented. I naturally gravitate towards the latter in these decisions because I find that it keeps things more modular. For example: It would be easier to rip out the linalg module and vendor it into an otherwise unrelated project because you wouldn't have to shim, remove, or port the documentation annotations.
A perhaps-controversial decision of a similar flavor happened in my pyquil days. Since the simulator and compiler were separate projects it was impossible to get the unitary matrices for named gates. Instead of teaching each gate its matrix, I added a separate module that included a mapping from a gate to its matrix

anyways, autodoc is kinda garbage so if we need to put something in like this then fine; but I think it is rather unusual and we should consider all options

Obsoleted.


[7.x] Make $queue null by default in getQueue method

Resubmittion of #29946
DocBlock says that null is allowed in public getQueue method, but it requires to pass null value explicitly. I'm making this PR because all other public methods which allows null value has default null value.
For example here is another one method in one of the Queue classes:
/**
 * Get the size of the queue.
 *
 * @param  string|null  $queue
 * @return int
 */
public function size($queue = null)
{
    $queue = $this->getQueue($queue);

    return $this->getConnection()->eval(
        LuaScripts::size(), 3, $queue, $queue.':delayed', $queue.':reserved'
    );
}

This doesn't actually fix any existing bugs or problems. The way this method is used it doesn't make sense to have a null default value.


xclip not building

It builds on one of my Macs but not on the others. I get this error:
==> Installing xclip from homebrew/homebrew-x11
==> Downloading https://downloads.sourceforge.net/project/xclip/xclip/0.12/xclip
Already downloaded: /Library/Caches/Homebrew/xclip-0.12.tar.gz
==> ./configure --prefix=/usr/local/Cellar/xclip/0.12
==> make install
) _X_ATTRIBUTE_PRINTF(2,3);
^
14 errors generated.
make: *** [xclip.o] Error 1
make: *** Waiting for unfinished jobs....
Warning: It appears you have MacPorts or Fink installed.
Software installed with other package managers causes known problems for
Homebrew. If a formula fails to build, uninstall MacPorts/Fink and try again.
READ THIS: https://git.io/brew-troubleshooting
If reporting this issue please do so at (not Homebrew/homebrew):
https://github.com/homebrew/homebrew-x11/issues
MacPorts is also installed on the computer where it works, so that can't be it. I have uninstalled homebrew and reinstalled it, and it still doesn't compile. Any help?

READ THIS: https://git.io/brew-troubleshooting

Please read this and provide all of the requested diagnostics, thanks!

OK, so I read that unbrewed dylib files can cause issues, and running "brew doctor" does show unbrewed dylib files, but I installed them all manually from things separate from Homebrew.
I uninstalled all of them (and reinstalled the homebrew versions) and brew doctor only mentioned the existence of MacPorts (the computer on which xclip compiles on also has it though). Yet I still have the same issue. Here's what I get from "brew install -v xclip":
Marcels-Mac:lib marceljj$ brew install -v xclip
==> Installing xclip from homebrew/homebrew-x11
==> Downloading https://downloads.sourceforge.net/project/xclip/xclip/0.12/xclip-0.12.tar.gz
Already downloaded: /Library/Caches/Homebrew/xclip-0.12.tar.gz
==> Verifying xclip-0.12.tar.gz checksum
tar xf /Library/Caches/Homebrew/xclip-0.12.tar.gz
==> ./configure --prefix=/usr/local/Cellar/xclip/0.12
checking for gcc... clang
checking for C compiler default output file name... a.out
checking whether the C compiler works... yes
checking whether we are cross compiling... no
checking for suffix of executables...
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether clang accepts -g... yes
checking for clang option to accept ISO C89... none needed
checking for a BSD-compatible install... /usr/bin/install -c
checking how to run the C preprocessor... clang -E
checking for grep that handles long lines and -e... /usr/bin/grep
checking for egrep... /usr/bin/grep -E
checking for ANSI C header files... yes
checking for X... libraries , headers
checking for gethostbyname... yes
checking for connect... yes
checking for remove... yes
checking for shmat... yes
checking for IceConnectionNumber in -lICE... yes
checking for strip... strip
checking for sys/types.h... yes
checking for sys/stat.h... yes
checking for stdlib.h... yes
checking for string.h... yes
checking for memory.h... yes
checking for strings.h... yes
checking for inttypes.h... yes
checking for stdint.h... yes
checking for unistd.h... yes
checking X11/Xmu/Atoms.h usability... no
checking X11/Xmu/Atoms.h presence... yes
configure: WARNING: X11/Xmu/Atoms.h: present but cannot be compiled
configure: WARNING: X11/Xmu/Atoms.h:     check for missing prerequisite headers?
configure: WARNING: X11/Xmu/Atoms.h: see the Autoconf documentation
configure: WARNING: X11/Xmu/Atoms.h:     section "Present But Cannot Be Compiled"
configure: WARNING: X11/Xmu/Atoms.h: proceeding with the preprocessor's result
configure: WARNING: X11/Xmu/Atoms.h: in the future, the compiler will take precedence
checking for X11/Xmu/Atoms.h... yes
checking X11/Intrinsic.h usability... no
checking X11/Intrinsic.h presence... yes
configure: WARNING: X11/Intrinsic.h: present but cannot be compiled
configure: WARNING: X11/Intrinsic.h:     check for missing prerequisite headers?
configure: WARNING: X11/Intrinsic.h: see the Autoconf documentation
configure: WARNING: X11/Intrinsic.h:     section "Present But Cannot Be Compiled"
configure: WARNING: X11/Intrinsic.h: proceeding with the preprocessor's result
configure: WARNING: X11/Intrinsic.h: in the future, the compiler will take precedence
checking for X11/Intrinsic.h... yes
checking for XmuClientWindow in -lXmu... yes
configure: creating ./config.status
config.status: creating Makefile
==> make install
clang -g -O2 -Wall  -DPACKAGE_NAME="xclip" -DPACKAGE_TARNAME="xclip" -DPACKAGE_VERSION="0.12" -DPACKAGE_STRING="xclip\ 0.12" -DPACKAGE_BUGREPORT="" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_LIBXMU=1 -o xclib.o -c xclib.c
clang -g -O2 -Wall  -DPACKAGE_NAME="xclip" -DPACKAGE_TARNAME="xclip" -DPACKAGE_VERSION="0.12" -DPACKAGE_STRING="xclip\ 0.12" -DPACKAGE_BUGREPORT="" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_LIBXMU=1 -o xcprint.o -c xcprint.c
clang -g -O2 -Wall  -DPACKAGE_NAME="xclip" -DPACKAGE_TARNAME="xclip" -DPACKAGE_VERSION="0.12" -DPACKAGE_STRING="xclip\ 0.12" -DPACKAGE_BUGREPORT="" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_LIBXMU=1 -o xclip.o -c xclip.c
mkdir -p /usr/local/Cellar/xclip/0.12/share/man/man1
/usr/bin/install -c -m 644 xclip.1 xclip-copyfile.1 /usr/local/Cellar/xclip/0.12/share/man/man1
In file included from xclip.c:28:
In file included from /opt/X11/include/X11/Xmu/Atoms.h:35:
/opt/X11/include/X11/Intrinsic.h:1178:3: error: expected function body after function declarator
) _X_SENTINEL(0);
^
/opt/X11/include/X11/Intrinsic.h:1322:3: error: expected function body after function declarator
) _X_SENTINEL(0);
^
/opt/X11/include/X11/Intrinsic.h:1389:3: error: expected function body after function declarator
) _X_SENTINEL(0);
^
/opt/X11/include/X11/Intrinsic.h:1396:3: error: expected function body after function declarator
) _X_SENTINEL(0);
^
/opt/X11/include/X11/Intrinsic.h:1420:3: error: expected function body after function declarator
) _X_SENTINEL(0);
^
/opt/X11/include/X11/Intrinsic.h:1472:3: error: expected function body after function declarator
) _X_SENTINEL(0);
^
/opt/X11/include/X11/Intrinsic.h:1495:3: error: expected function body after function declarator
) _X_SENTINEL(0);
^
/opt/X11/include/X11/Intrinsic.h:1569:3: error: expected function body after function declarator
) _X_SENTINEL(0);
^
/opt/X11/include/X11/Intrinsic.h:1590:3: error: expected function body after function declarator
) _X_SENTINEL(0);
^
/opt/X11/include/X11/Intrinsic.h:1601:3: error: expected function body after function declarator
) _X_SENTINEL(0);
^
/opt/X11/include/X11/Intrinsic.h:1612:3: error: expected function body after function declarator
) _X_SENTINEL(0);
^
/opt/X11/include/X11/Intrinsic.h:1627:3: error: expected function body after function declarator
) _X_SENTINEL(0);
^
/opt/X11/include/X11/Intrinsic.h:1642:3: error: expected function body after function declarator
) _X_SENTINEL(0);
^
/opt/X11/include/X11/Intrinsic.h:1865:3: error: expected function body after function declarator
) _X_ATTRIBUTE_PRINTF(2,3);
^
14 errors generated.
make: *** [xclip.o] Error 1
make: *** Waiting for unfinished jobs....
Warning: It appears you have MacPorts or Fink installed.
Software installed with other package managers causes known problems for
Homebrew. If a formula fails to build, uninstall MacPorts/Fink and try again.
==> Formula
Tap: homebrew/homebrew-x11
Path: /usr/local/Library/Taps/homebrew/homebrew-x11/xclip.rb
==> Configuration
HOMEBREW_VERSION: 0.9.5
ORIGIN: https://github.com/Homebrew/homebrew
HEAD: db091b65a57e983c76316ae312773a8697f5a7a6
Last commit: 9 hours ago
HOMEBREW_PREFIX: /usr/local
HOMEBREW_CELLAR: /usr/local/Cellar
CPU: quad-core 64-bit penryn
OS X: 10.10.3-x86_64
Xcode: 6.3.1
CLT: <IP_ADDRESS>.1.1429149539
Clang: 6.1 build 602
MacPorts/Fink: /opt/local/bin/port
X11: 2.7.7 => /opt/X11
System Ruby: 2.0.0-p481
Perl: /usr/bin/perl
Python: /usr/local/bin/python => /usr/local/Cellar/python/2.7.9/Frameworks/Python.framework/Versions/2.7/bin/python2.7
Ruby: /usr/bin/ruby
Java: 1.8.0_45
==> ENV
HOMEBREW_CC: clang
HOMEBREW_CXX: clang++
MAKEFLAGS: -j4
CMAKE_PREFIX_PATH: /usr/local
CMAKE_INCLUDE_PATH: /usr/include/libxml2:/opt/X11/include:/opt/X11/include/freetype2:/System/Library/Frameworks/OpenGL.framework/Versions/Current/Headers
CMAKE_LIBRARY_PATH: /opt/X11/lib:/System/Library/Frameworks/OpenGL.framework/Versions/Current/Libraries
PKG_CONFIG_LIBDIR: /usr/lib/pkgconfig:/usr/local/Library/ENV/pkgconfig/10.10:/opt/X11/lib/pkgconfig:/opt/X11/share/pkgconfig
ACLOCAL_PATH: /usr/local/share/aclocal:/opt/X11/share/aclocal
PATH: /usr/local/Library/ENV/4.3:/opt/X11/bin:/usr/bin:/bin:/usr/sbin:/sbin
Error: xclip 0.12 did not build
Logs:
/Users/marceljj/Library/Logs/Homebrew/xclip/01.configure
/Users/marceljj/Library/Logs/Homebrew/xclip/01.configure.cc
/Users/marceljj/Library/Logs/Homebrew/xclip/02.make
/Users/marceljj/Library/Logs/Homebrew/xclip/02.make.cc
/Users/marceljj/Library/Logs/Homebrew/xclip/config.log

Sorry if the formattings off, I'm not good at it. :P
Thanks for your help so far, and I hope I can get this issue resolved.

Can you do brew gist-logs xclip please? It'll clear up the formatting and provide other useful brew information. Thanks!

Sorry, I can't - I reinstalled OS X, but on the plus side it compiled with a new install. I guess I just messed up something by myself. Thanks for the help though!

No worries, Glad it's working now! Thanks for closing the bug report :tada:


[UI][FEATURE] Support V2 Backing Image in UI

Is your feature request related to a problem? Please describe (👍 if you like this request)

When creating backing image, users should be able to select if the "Data Engine" is v1 or v2 backing image

refer to the "Data Engine" in the volume creation

In the backing image UI page, we should have a new field "Data Engine"
In the backing Image UI page, if the backing image is v2, we should not allow users to download it (currently not support)

Note:
The "DataEngine" should be supported in the API after this PR merged: https://github.com/longhorn/longhorn-manager/pull/3295
e.g.
CREATE
HTTP/1.1 POST /v1/backingimages
Host: localhost:8080
Accept: application/json
Content-Type: application/json
Content-Length: 49

{
"expectedChecksum": "",
"name": "",
"sourceType": "",
"dataEngine": "v1",
}

GET
{
    "data": [
        {
          ...
            "dataEngine": "v2",
            "deletionTimestamp": "",
            "diskFileStatusMap": {
                "c13bbeb6-815a-439a-bb80-2fa4820b62c8": {
                    "dataEngine": "v2",
                    "lastStateTransitionTime": "2024-11-29T07:41:17Z",
                    "message": "",
                    "progress": 100,
                    "state": "ready"
                }
            },
          ...
            "minNumberOfCopies": 1,
            "name": "parrot-qcow2",
            "nodeSelector": null,
            "parameters": {
                "url": "https://longhorn-backing-image.s3-us-west-1.amazonaws.com/parrot.qcow2"
            },
...
            "size": 33554432,
            "sourceType": "download",
            "type": "backingImage",
            "uuid": "43a479a3"
        }
    ],
    "links": {
        "self": "http://localhost:8080/v1/backingimages"
    },
    "resourceType": "backingImage",
    "type": "collection"
}

Describe the solution you'd like

Describe alternatives you've considered

Additional context

Hi @houhoucoop
Sorry for late update
But for this ticket, may I add one new spec ?

When Restore BackupBackingImage, can you help to add a new option DataEngine which has v1, v2 option? Just like creating backing image.

The API request payload Example
{
"dataEngine": "v1", // or "v2"
"secret": "",
"secretNamespace": "",
}

You can use this image for development: jackfantasy/longhorn-manager:update_restore_api
Thanks!

Move back to Implement since we need https://github.com/longhorn/longhorn/issues/9880#issuecomment-2559501498.

Verified pass on longhorn master(https://github.com/longhorn/longhorn-ui/commit/f903b6a4b724a7e05cce1509d5465e48d98c6967), v1.8.x(https://github.com/longhorn/longhorn-ui/commit/47c97e0dc42f0431909e6992ccb42884332bd648) with test steps

[x] User are able to select Data Engine when create a backing image
[x] Show Data Engine info on the table
[x] Disable Download options for v2 backing image
[x] Disable bulk action Download if user select one of v2 backing image
[x] Selective data engine option when restore backing image


minor(session): add option params to set MaxComPacketSize

some SEDs are apparently unable to handle some Properties() Session
Manager method request arguments gracefully if they exceed the values
supported by the TPer.
e.g., as of FW version E2MU110, if Micron 7450 family devices are passed
HostProperties.MaxComPacketSize of >128kB (and possibly the related
Max*PacketSize values) on Properties() invocation, the subsequent
IF-RECV calls might sporadically fail with EINVAL (22) error.
the recommended vendor workaround is to always pass in a value <= 128kB
to HostProperties.MaxComPacketSize, regardless of host capabilities.
this patch adds option params to core.NewControlSession() and
locking.Initialize() allowing to override the MaxComPacketSize value.
issue: LBM1-20784

hey @ChriMarMe
I don't see any merge button.
Might there is a need to update permissions?


Can't change latex-to-pdf compiler for org

[X] I have searched the FAQ and the documentation for solutions.
[X] I have searched the issue tracker for similar issues (the closed issues too).
[X] I have searched the Discourse for any errors and solutions.
[X] I can reproduce my issue on the latest commit of Doom Emacs.
[X] I have read How to Debug Issues and found no solution.

What did you expect to happen?
I need to change latex compiler from pdflatex to xelatex. I've expected that changing org-latex-compiler and/or org-latex-compilers variables and/or setting #+LATEX_COMPILER org header will change my latex compiler.
What actually happened?
Latex compiler didn't change. pdflatex is used instead of xelatex.

Describe your attempts to resolve the issue
I've searched all standard ways of changing latex compiler for org's export.
I've set variables in my config.el:
(after! org
  (setq org-latex-compiler 'xelatex)
  (setq org-latex-compilers '("xelatex")))

Also I've set header #+LATEX_COMPILER: xelatex in my org file.
After that, I've synced my configuration with doom sync and confirmed that those variables is set.

Googling "doom emacs change org compiler" and "doom emacs change latex compiler" gives nothing useful up to 3d page.
Setting those variables in vanilla emacs works as expected.
Steps to reproduce
In my init.el those flags is set for latex and org:
(org +brain +dragndrop +gnuplot +noter +pomodoro +present +pretty +roam)
(latex +lsp +cdlatex +latexmk)

System Information
https://pastebin.com/sptznH9H

Evaluating (setq org-latex-compiler "xelatex") (via SPC ;) in an org buffer and then running the export (via SPC m e l o) works for me.

Update: problem appears only if Body only switch is on (space m e C-b in default configuration).
After setting Body only to off export works as expected - xelatex is used.


accessing a deleted entity seg fault

from visii import *
import visii

visii.Initialize()
a = visii.Entity_Create("john")
print(a.to_string())
visii.Entity_Delete("john")
print(a)
print(a.to_string())

The API has changed a bit since this issue was initially created. However, this should be fixed now, at least for entities.


pull request for e2e test at 11/13/2016 15:26:09

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

optest/docs/updated_at.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


For object detection, what are the temperature , topp and topk value is set for this model. Also ...

HI Vikhyat,
For object detection, what are the temperature , topp and topk value is set for this model. Also would like to know what is the your general recommendation of the image size and aspect ratio. I have used the playground from hugging face and this model performs well there. May I know what is the secret ingredients added to this model ?
Thank you and expecting your reply soon.
Ramesh Rajamani

Ignore the above issue ...I have not converted it to the Base64, instead i have passed the URL. Now I am getting the proper results...Kudos to the moondream team.

@rameshrajamani hey, can you provide the code for object detection. I tried looking but another guy had an issue with model.detect() method. So it would be great if you share the code snippet.
Thanks 😊


Issue69: Use scenetree on descendant nodes

Allows accessing the scene tree from descendant nodes #69.

I am not sure how to run the tests. There seem to be broken tests no main. However, I was able to test the generator in another project.

Awesome, thanks for this.  Can be tricky to find the time for new features :(
Let me know when you're happy with it, I'll merge to a branch (rather than main), run/add new tests, etc :)

The only thing I would change, is generating the scene tree class separately from the partial script class. I'll create a PR for the feature branch.

Here's the follow-up PR #83. I am happy with it now. 😁

Ok, great.  New pre-release nuget contains SceneTree on sub-node changes with type-safe root access (via Get() and implicit conversion).


Delete Duplicate Token Information due to automerge

I'm submitting a ...
[ X] bug report
[ ] feature request
[ ] question about the decisions made in the repository
[ ] question about how to use this project

Summary

During my initial pull request automerge worked no problem, however i identified that Phantom dont like more than x amount of characters for the symbol so had to update the symbol. Since this property is identified as delete the automerge failed, had to create a new record and automerge accepted the same, the problem is now we have a duplicate record on the token list.
Can we please delete the token info for 3LechesCake and leave the valid one TresLeches since looks like is an acceptable symbol globally.
I suggest automerge to allow initial pull to be updated for better token info, or to use the TrustWallet Method of updating each token info on their info.json.

Other information (e.g. detailed explanation, stack traces, related issues, suggestions how to fix, links for us to have context, eg. StackOverflow, personal fork, etc.)

can i get the pull for the nft completed D2m2WoHKXdahVwA6gUxqfuCgxbUWv1S9y2p4mMRqnuWi

looks like no updates, will check back later.

Did you pay the fast track fee?

Looks like it merged now and is not duplicate, Going to close this issue for now and hope it gets merged to main.


Link for "Windows App SDK" broken

The link for "Windows App SDK" under the "Related links for WinUI 3" is broken and ends up at a 404.

Document details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1ea32f1f-67e6-12f4-7aa0-602184a377fd
Version Independent ID: 3adf7079-1ead-0e1a-0af9-7de72d30117f
Content: Windows UI Library (WinUI) - Windows apps
Content Source: hub/apps/winui/index.md
Product: reunion
Technology: winui-conceptual
GitHub Login: @Karl-Bridge-Microsoft
Microsoft Alias: kbridge

Thanks @DeanBilotti - the links should be fixed shortly.


Rustcargo

include!(concat!(env!("OUT_DIR"), "/generated.rs"));cargo:rustc-flags=-l static:foo -L /path/to/foo
cargo:root=/path/to/foo
cargo:libdir=/path/to/foo/lib
cargo:include=/path/to/foo/include[package]
...
build = "build/compile.rs"# Each target triple has a namespace under the global target key and the
libs key is a table for each native library.

Each library can specify a number of key/value pairs where the values must be
strings. The key/value pairs are metadata which are passed through to any
native build command which depends on this library. The rustc-flags key is
specially recognized as a set of flags to pass to rustc in order to link to
this library.
[target.i686-unknown-linux-gnu.ssl]
rustc-flags = "-l static:ssl -L /home/build/root32/lib"
root = "/home/build/root32"
[target.i686-pc-windows-gnu.dependencies.crypt32]
git = "https://github.com/user/crypt32-rs"
[target.i686-pc-windows-gnu.dependencies.winhttp]
path = "winhttp"https://github.com/user/crypt32-rs

Patch


Experiment executing Drush commands against a runtime

This requires #51 and possibly #26 so we have somewhere to put the button.
php-cgi-wasm provides the wasm_sapi_cgi_putenv function. To run a command line object we'll need to set argv as an array. Per https://emscripten.org/docs/porting/connecting_cpp_and_javascript/Interacting-with-code.html this is possible with something like:
php.ccall(
	'wasm_sapi_cgi_putenv'
	, 'number'
	, ['array']
	, [arg1, arg2, arg3]
)

The problem is that php-cgi-wasm doesn't support running an arbitrary script, only php-wasm. And we cannot set argv with php-wasm.
It also looks like php-wasm doesn't support running a specific file. The soyuka/php-wasm does with phpw https://github.com/soyuka/php-wasm/blob/main/source/phpw.c#L65-L91
void phpw(char *file)
{
  setenv("USE_ZEND_ALLOC", "0", 1);
  if (EMBED_SHUTDOWN == 0) {
	  php_embed_shutdown();
  }

  php_embed_init(0, NULL);
  EMBED_SHUTDOWN = 0;
  zend_first_try {
    zend_file_handle file_handle;
    zend_stream_init_filename(&file_handle, file);
    // file_handle.primary_script = 1;

    if (php_execute_script(&file_handle) == FAILURE) {
      php_printf("Failed to execute PHP script.\n");
    }

    zend_destroy_file_handle(&file_handle);
  } zend_catch {
    /* int exit_status = EG(exit_status); */
  } zend_end_try();

  phpw_flush();
  php_embed_shutdown();
  EMBED_SHUTDOWN = 1;
}

If php-wasm had a function like phpw, we could execute vendor/bin/drush. But it'd also need to be updated to accept arguments for argv

I tried a simple script:
<?php

$stdErr = fopen('php://stderr', 'w');

set_error_handler(function(...$args) use($stdErr, &$errors){
    fwrite($stdErr, print_r($args,1));
});

$flavor = file_get_contents('/config/flavor.txt');
unlink('/config/flavor.txt');

require "/persist/$flavor/vendor/drush/drush/drush.php";

Executed via:
const flavor = event.target.dataset.flavor;

const php = new PhpWeb({ sharedLibs, persist: [{ mountPath: '/persist' }, { mountPath: '/config' }] });
await php.binary;
php.addEventListener('output', event => console.log(event.detail));
php.addEventListener('error', event => console.log(event.detail));

await sendMessage('writeFile', ['/config/flavor.txt', flavor]);

const exportDbPhpCode = await (await fetch('/assets/export-db.php')).text();
console.log(await php.run(exportDbPhpCode))

It fails with:
[preflight] Drush is designed to run via the command line.

That is because \Drush\Config\Environment::verifyCLI fails. The php_sapi_name() function returns embed and not cli.

It looks like the script could bootstrap Drupal itself and then use \Drush\Sql\SqlBase::create to get an object and dump. Essentially creating \Drush\Commands\sql\SqlCommands::dump without running the command.
$sql = SqlBase::create($options);
$return = $sql->dump();

Although I haven't tried executing \Symfony\Component\Process\Process in php-wasm


vfs: reduce directory cache cleared by poll-interval

What is the purpose of this change?
Reduce the number of nodes purged from the dir-cache when ForgetPath is called by poll-interval. This is done by only forgetting the cache of the received path and invalidating the parent folder cache by resetting *Dir.read.
The parent will read the listing on the next access and reuse the dir-cache of entries in *Dir.items.
Was the change discussed in an issue or in the forum before?
This change is inspired by a discussion in the forums, but not argued otherwise.
https://forum.rclone.org/t/share-your-rclone-mount-command-here/4601/12
Checklist

[x] I have read the contribution guidelines.
[x] I have added tests for all changes in this PR if appropriate.
[x] I have added documentation for the changes if appropriate.

[x] I'm done, this Pull Request is ready for review :-)

Reduce the number of nodes purged from the dir-cache when ForgetPath is called by poll-interval. This is done by only forgetting the cache of the received path and invalidating the parent folder cache by resetting *Dir.read.
The parent will read the listing on the next access and reuse the dir-cache of entries in *Dir.items.

That is a great idea.
I've given the code a once over and I can't see anything obviously wrong with it, so I'll merge it now - thank you :-)


AnimationPlayer.play_backwards() calls keyframe methods twice

Tested versions
reproduced in 4.2.1.stable
not reproduced in 3.5.3.stable, 4.0.4.stable, 4.1.3.stable
System information
Godot v4.2.1.stable unknown - Arch Linux #1 SMP PREEMPT_DYNAMIC Fri, 05 Jan 2024 16:20:41 +0000 - Tty - Vulkan (Forward+) - dedicated NVIDIA GeForce GTX 1070 (nvidia; 545.29.06) - Intel(R) Core(TM) i7-6700 CPU @ 3.40GHz (8 Threads)
Issue description
Animations with "Call Method" tracks work normally when playing forward, but when playing backwards, a single method keyframe results in 2 method calls.
Steps to reproduce
Run the attached project. The buttons in the top left call play() and play_backwards():
func hello():
  print("hello")

func play():
  print("play")
  $AnimationPlayer.play("blah")

func play_backwards():
  print("play_backwards")
  $AnimationPlayer.play_backwards("blah")

The "blah" animation spins the sprite and calls hello() once. When playing forward, Godot prints:
play
hello

But backwards:
play_backwards
hello
hello

Minimal reproduction project (MRP)
animation-callback-test.zip

Dupe of #86147, Already fixed by #86227 in 4.2.2.


BUG: scipy.stats.powerlaw, why should x ∈ (0,1)? x can exceed 1

Describe your issue.
In current version scipy 1.5.3, I'm generating samples and I find that when x exceed 1, the powerlaw pdf is suddenly 0, I think you must have miss read the powerlaw distribution, it is defined on x > 0 area, not between 0 and 1.
Reproducing Code Example
a=0.5
powerlaw.pdf(x=0.99, a=a)
powerlaw.pdf(x=1.0, a=a)
powerlaw.pdf(x=1.01, a=a)

### Error message

```shell
Simply return 0 when x > 1.0

SciPy/NumPy/Python version information
version scipy 1.5.3

@xiasummer, take another look at the documentation.  The distribution implemented by scipy.stats.powerlaw is, in fact, supported on [0, 1] (assuming that the loc and scale parameters have their default values 0 and 1, respectively).
If you want a distribution with a power-law PDF that is supported on [1, ∞), you can use scipy.stats.pareto.
It is impossible for a distribution with a power-law PDF to be supported on [0, ∞), because, depending on the power, the integral of the PDF diverges at x=0 or as x → ∞.

I think we could improve a bit the documentation then.

Hey @WarrenWeckesser, I was trying to solve this issue. The documentation clearly states that loc and scale parameters can scale and shift the distribution in the way you showed. Should we add an example like above in the doc for better understanding?

@NamamiShanker documentation improvement are always welcomed, feel free to open a PR to clarify things.

I would consider this closed if we mentioned that other power law type distributions are available, and link to them in "see also". I don't think this warrants overriding the default distribution documentation. That could also be improved, perhaps, but that would be a separate issue.


Renames semi-auto ValueClassCodecs to UnwrappedCodecs

Addresses the naming remarks made in #661 (I fully agree, ...Unwrapped... is way better/more consistent).
PR at the same time increases the decoding test coverage by including a failure case.

Codecov Report

Merging #744 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #744   +/-   ##
=======================================
  Coverage   86.73%   86.73%
=======================================
  Files          73       73
  Lines        2299     2299
  Branches       90       91    +1
=======================================
  Hits         1994     1994
  Misses        305      305

Impacted Files
Coverage Δ

.../main/scala/io/circe/generic/extras/semiauto.scala
100% <100%> (ø)
:arrow_up:

...rce/generic/extras/decoding/UnwrappedDecoder.scala
100% <100%> (ø)

...rce/generic/extras/encoding/UnwrappedEncoder.scala
100% <100%> (ø)

.../core/shared/src/main/scala/io/circe/Decoder.scala
90.03% <0%> (-0.35%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81cd582...ae06a54. Read the comment docs.

Thanks @pjan!


[Rough draft] Ideas to allow more graphs, power, and simplicity

The code here is super rough, I only did this for the states page, etc, but here's some ideas.

Rather than having 8 graphs showing 9 pieces of data see if we can collapse to a single "best" view and an advanced view that lets the user make whatever they want to make. I thought doubling had to be a separate graph too, but now I see #75 so that's exciting!
If the objects in UnitedStates.js all exposed a consistent object, then we could use the same "At a glance"/"Detailed"/"Doubling" views for all of them (I didn't do this yet) and intelligently hide graphs like "Hospitalizations" when the object doesn't have any info on it
Rather than showing the high level summary on all pages, only show it on the at a glance page. If the user is looking at the additional graphs, they've probably already seen those numbers so may as well not show it
Rather than showing the area charts as a different graph than the line charts, just let the user pick what they want
I don't know what to do with log, I think I'll put it to the right of "Line"/"Area" but it makes me sad.
Adding margin to the state/county/whatever name and making it larger makes the page feel like it can breathe
Using Paper elements gives depth to the page so it's clearer what options affect what sections
Tried to make the colors more consistent, that red accent isn't working for me (probably should change it to blue in the map but...)

What do you think?
The original view, just slightly changed

The detailed tab

The detailed tab when selecting "area"

Oh I forgot to think too hard about cumulative data, not quite sure what to do with that yet. One option would be able to have a toggle next to each thing in the legend.
So it'd read like

Confirmed (cumulative)

and cumulative would be grayed out or colored depending on if it was enabled. There's probably something better we could do though, just haven't thought of it.

I like a lot of the concepts that you laid out and you pointed out one of
the things that I wanted to do but haven't, that is the unify all the data
under AllData.json a number of places that I haven't done are :

county_gps (that really shouldn't have hospital data)
test data
some projection data (peak death, later on peak hospitalization)
future (I'm going to pull int he social distancing scores from onecast)

Other comments:

I like folding the summary into At a glance a lot.
I want a section on projections
want a place to show how the curve is getting flattened, how we know
when we are beating the epidemic.
I don't know if all the graphs can be unified under Details since some
graph will have more specialized details, like the hospitalization will
need ICU beds/beds as reference, and possibly marry the Peak
Hospitalization graph for the future? Some people want to see daily and
some people want to see new. Maybe we can use complete data unification as
a goal, but allow flexibility of working through one graph at a time and
allow customization.
I'm a bit surprised that you merged the Graph/Map section with the
tables. I kept them separate because one is graph the other is data. Not
opposed to trying the new way, but it was getting super crowded up to for
mobile.
btw, I really really like NYT's layout of their GUI, maybe we can copy
elements of their design.

On Sun, Apr 12, 2020 at 2:54 PM April Schleck<EMAIL_ADDRESS>wrote:

Oh I forgot to think too hard about cumulative data, not quite sure what
to do with that yet. One option would be able to have a toggle next to each
thing in the legend.
So it'd read like

Confirmed (cumulative)

and cumulative would be grayed out or colored depending on if it was
enabled. There's probably something better we could do though, just haven't
thought of it.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/xunhuang/covid-19/pull/76#issuecomment-612681703, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAFSGF4LZ2UDFBJ4URPUTWTRMIZ77ANCNFSM4MGSIBHQ
.

I'm pretty lazy so I was thinking about just using the County/Metro/State etc objects to give a consistent interface rather than updating the data, but fixing the underlying thing sounds better!

is this the existing "Peak Death" section or something new? I meant to have "Projected deaths" or something in my detailed view providing the info from Peak Death, just forgot. When you say a section, do you mean a tab? So like "At a glance", "Projections", "Detailed", etc?
do you have some ideas on how you would show that? Would that also need to be a separate tab?
hmm you definitely have a better sense of things than me, but I was thinking about just showing it together and letting the user adjust as necessary. Is the ICU info already shown? Also, sorry for the dumb question: what's the difference between daily and new?
Yeah, I don't have a strong opinion here. I think I was just adjusting margins and got mad that it looked attach to my graphs, so did something random. Removing it makes the page really short, I'm happy to leave it where it is today. In my defense putting it as a tab allows me to test small screen sizes better :)
do you have a link to this? Is it this? I like that page but it's a story and I don't know that it'd fit well for us.

What do you think are the right next steps here?

I can't believe I didn't include think, yes, it's that one, fo the state :
https://www.nytimes.com/interactive/2020/us/california-coronavirus-cases.html#county
As new steps, how about this?

adopt the new design you put out.
a. At a glance (current cases)
b. Details (show the recovery & death, test, hospitalization) in
another level tab like Maps.
c. double
d. Peak death (which I will change to projection when I have more like
this https://covid19.healthdata.org/projections
https://covid19.healthdata.org/projections?fbclid=IwAR2QB2ziCbLyEASRupPdUegRpZNtnwQ3NyIUNvE7Lah0WK9Mq1H2tQag1sc.)
Maybe doubling time can go there too after it loses novelty.
e. map
move the Counties/Capita back to the table below, at least for now.

the flattening the curve ideas:

https://observablehq.com/@yy/covid-19-confirmed-vs-new-cases
https://observablehq.com/@yy/covid-19-confirmed-vs-new-cases?fbclid=IwAR38wjrv0GnCdM85u68dKBZc9qjEmPhjtmvB_BKsW8A6hjca5ZvUPLv8tbE
this one
[image: image.png]

I do have ICU capacity information as hospital data, but currently not
shown.
On Sun, Apr 12, 2020 at 3:36 PM April Schleck<EMAIL_ADDRESS>wrote:

I'm pretty lazy so I was thinking about just using the County/Metro/State
etc objects to give a consistent interface rather than updating the data,
but fixing the underlying thing sounds better!

is this the existing "Peak Death" section or something new? I meant
to have "Projected deaths" or something in my detailed view providing the
info from Peak Death, just forgot. When you say a section, do you mean a
tab? So like "At a glance", "Projections", "Detailed", etc?
do you have some ideas on how you would show that? Would that also
need to be a separate tab?
hmm you definitely have a better sense of things than me, but I was
thinking about just showing it together and letting the user adjust as
necessary. Is the ICU info already shown? Also, sorry for the dumb
question: what's the difference between daily and new?
Yeah, I don't have a strong opinion here. I think I was just
adjusting margins and got mad that it looked attach to my graphs, so did
something random. Removing it makes the page really short, I'm happy to
leave it where it is today. In my defense putting it as a tab allows me to
test small screen sizes better :)
do you have a link to this? Is it this
https://www.nytimes.com/interactive/2020/us/coronavirus-us-cases.html?
I like that page but it's a story and I don't know that it'd fit well for
us.

What do you think are the right next steps here?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/xunhuang/covid-19/pull/76#issuecomment-612686690, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAFSGF6LJTBYMHKW2HOMHATRMI7ATANCNFSM4MGSIBHQ
.

btw, I looked at file sizes from the build directory build/static/js, 20M in that directory! if we want to  reduce that, we need to take a much deeper dive. the AllData.json uncompressed is 8M and compressed is 5M.


I must restart the tira-host container on a betaweb to make the tira host recognize new virtual machines

When I create a new virtual machine, I still have to stop/start the tira-host docker container so that I can work with the VM in the frontend. But after restarting, it works fine.

Should be fixed by commit from #159, will check it.


Websocket decrypting the message support

Hi Right now
websocket allows the encrypted payload to be passed thru to the client.
Can we get the fields how client is using to manage decryption and also update in the websocket document
https://pulsar.apache.org/docs/en/client-libraries-websocket/#consumer-endpoint
as of know this are the fields

and the above mentioned "key" ("Original routing key set by producer") is actually the '(aes) encrypted data key' ?
https://github.com/apache/pulsar/issues/10021

@kjaggann I will try to follow up on this issue

The issue had no activity for 30 days, mark with Stale label.


Add mocked tests: get_backup_policy

Overview
Enhance test coverage by adding mocked test for the function that retrieves the backup policy for an existing droplet - get_backup_policy.
Mocked tests do not act against the real API so no real resources are created.
To run mocked tests, run: make test-mocked
Instructions

Clone this repo.
If you haven't already, install Python (version: >= 3.7.2) through their official installer.
CD into the directory and run make install
Open file: tests/mocked/test_droplets.py
Add a mocked test with the name test_get_backup_policy for droplets.get_backup_policy.

Note: The function implementation can be found in src/pydo/operations/_operations.py.

@loosla get_backup_policy method is in DropletOperations. I think we need to add test case in test_droplets.py. Can you please confirm. Also, please assign it to me.

Thank you for catching that! I’ve updated the description.

@loosla thanks. Created PR. Please review.


Feature/private key

Allow reinterpreting an Asn1Element that successfully parsed as Asn1EncapsulatingOctetString as an Asn1PrimitiveOctetString

This is a behavioural change!

Make Asn1Integer an Asn1Encodable<String>
PEM Encoding

Introduce PemEncodable interface, derived from Asn1Encodable
Introduce PemDecodable interface, derived from Asn1Decodable

Add Private Key Representation to indispensable

Parsing of PEM and DER-encoded private keys
Introduce SignatureAlgorithm.signerFor(privateKey) to create signers backed by (previously parsed, or manually constructed) private keys
Export of private keys from ephemeral signers (and only ephemeral signers) in combination with a new @SecretExposure annotation

If iOS permits it, the EphemeralSigner should be able to export its private key. If we later on add support for encrypted private key representations, this will become even more relevant

If iOS permits it, the EphemeralSigner should be able to export its private key. If we later on add support for encrypted private key representations, this will become even more relevant

this works. what we need now is a strategy to null out byte arrays containing private key data:

The export of ephemeral keys part is easy: just manually null out the source, once the private key object exists. do we have other critical code paths?

It's always the P521 curve…

If iOS permits it, the EphemeralSigner should be able to export its private key. If we later on add support for encrypted private key representations, this will become even more relevant

this works. what we need now is a strategy to null out byte arrays containing private key data:
* The export of ephemeral keys part is easy: just manually null out the source, once the private key object exists. do we have other critical code paths?

Moved this to #207. Suddenly making things mutable is exactly the pandora's box you'd assume it would be. Waiting for an answer from the toolkit guys, how they handle it.

Yes, the ios interop file is copy-pasted. we need a strategy to not pollute the public API and still share code between modules. Maybe group it into an object with some foo to make it conveniently usable?!


Fix some bugs in the shell scripts.

Hello.
This PR contains some fixes:

Due to the lack of quotes in addmailuser's usage, it didn't actually display the usage.
generate-ssl-certificate did not use the fqdn, but only the short hostname.
Permission errors in scripts.

Hi @vifino, thanks for that!


kbs-types: Add a key type field for publick keys

Both EC and RSA JWK-formatted public keys must specify a key type through the kty type.
See https://www.rfc-editor.org/rfc/rfc7518.html#section-6 for further reference.

cc @tylerfanelli @slp

This PR itself looks fine to me, but I wonder if we should start thinking about refactoring TeePubKey to a format that fits EC fields such as crv, x and y. What do you think?

I think it makes sense.
As this is likely to be a breaking change, could we tag a 0.4.0 and then work on adding EC support to the KBS types?

@slp @crobinso @tylerfanelli any chance to get this PR merged soon?

@katexochen @sameo Would we still like a 0.4.0 release before EC support?

@tylerfanelli Yes, that would be great! Thanks :)

@tylerfanelli Yes, that would be great! Thanks :)

Agreed, thanks in advance @tylerfanelli

@tylerfanelli could you also publish v0.4.0 to crates.io?

@katexochen My mistake, I forgot all about that. Done.


BROOKLYN-460: Brooklyn Camp syntax for adding tags to an entity spec

services:
- type: BasicApplication
  brooklyn.tags: [tag1, tag2]

brooklyn.tags adds NamedStringTag to an entity spec.
Tags can be inspected via REST API /v1/applications/<appId>/entities/<entityId>/tags

@bostko (cc @tbouron) Thinking about this more, I'm not sure what types we should support for tags. Maybe accepting any object is a bad idea, as it might make subsequent features harder to support (e.g. support for looking up / processing tags).
On the other hand, locking down the types to be just strings without a good reason seems too extreme.
Looking at the REST api (org.apache.brooklyn.rest.resources.EntityResource.listTags()), it turns the tags into json via the standard mechanism. It can therefore handle non-string types. if you use something that does not have a good json representation, then it becomes a lot less useful. But arguably that's the user's problem (presumably they had a reason for putting the object in the tags in the first place).

@bostko it's worth adding this test (which passes), for use of a DSL expression in the tags:
    @Test
    public void testTagWithDslValue() throws Exception {
        Entity app = createAndStartApplication(
                "services:",
                "- type: " + BasicApplication.class.getName(),
                "  brooklyn.tags:",
                "  - $brooklyn:literal(\"myval\")");
        assertTrue(getTagsEventually(app).contains(BrooklynTags.newNotesTag("myval")));
    }

+1 for supporting arbitrary objects, but making strings very easy to add.
What about DSL in tags? This is a prerequisite for supporting objects, but on the other hand tags need to be evaluated at the time the entity is constructed which restricts DSL quite a bit. Need to be careful not to set the DSL object itself as a tag.

Given that there's lots of discussion above, can I +1 the suggestion by @m4rkmckenna to take this to the mailing list as a proposal and invite discussion there?

@aledsage @bostko I think we should insert the object as is, without wrapping it in CampBrooklynTag. The wrapper doesn't provide any useful functionality and in fact could lead to unexpected behaviour - the user is no longer able to control the type of the tag which defeats the purpose.

LGTM. Haven't checked if all of @aledsage's comments are addressed - there's at least one re getTagsEventually so can you double check that. A couple of minor comments from me as well.

+1 LGTM; have run some tests successfully, and have checked back through all of @aledsage's and @neykov's comments, which are all addressed.
Will merge.


cura: 4.7.1 -> 4.8.0

I've added the new dependencies (pynest2d & libnest2d) but pynest2d won't build because its build target also installs it into python's site_packages folder and I have no idea how to handle that.
However, I also wanted to discuss whether switching to an AppImage wrapper might be more appropriate, as that's what Ultimaker's official release is. Ultimaker seem to be a bit lax in their release tagging convention, too, which makes maintaining the package a bit more painful (libnest2d doesn't even have a release tag on the latest version, which is used by pynest2d).
Currently I use appimage-run to run Cura 4.8.0 and it runs flawlessly.

Motivation for this change
Ultimaker released a new version of Cura
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

@gebner Turns out updating Cura to 4.8.0 wasn't as easy as I thought it'd be. What are your thoughts on switching to an AppImage wrapper?

I'd strongly prefer continuing to build from source.

Haha I thought that might be the case

Looking at the previous update PR, it looks like you need to upgrade liburanium, libsavitar, libarcus and curaengine as well.

Once I got the pynest2d bit sorted, I was going to move on to those, but thanks for pointing them out (now I have a clear list to work off haha)
Thanks for your help @lopsided98 ! I'll continue on this after work.

Beyond the 2 issues mentioned above, this upgrade works for me and slices my test file fine.

I get now:
hash mismatch in fixed-output derivation '/nix/store/6xjdlcbfv2wckgmv8jy0vnwrpfiwwx3l-source':
  wanted: sha256:0hi9w1fsnazlr0vvxdr3alsdb8m1vjjfp5zhmlz4kyyxhsy3bc33
  got:    sha256:1wyzx4fxbyd0mvf3x4p7crcnp38hgfr4zd3cc40nk9c0c51awplv
cannot build derivation '/nix/store/hn1f0rnw3fgvd583nkqawpwprpzsk6z3-cura-4.8.0.drv': 1 dependencies couldn't be built

That's odd, I wonder why I didn't get the same error. I've updated the SHA. Thanks for testing!

That's odd, I wonder why I didn't get the same error. I've updated the SHA. Thanks for testing!

Perhaps you did the update, putting in that SHA and it was right at the time, and then changed the URL/version again but forgot to update the SHA, and it didn't re-download it to re-hash it because fetchFromGitHub produces a fixed-output derivation that downloads only when you don't already have that SHA.
I didn't have the SHA, so for me it downloaded. This is a common pitfall.

`cura: Fix SHA for fdm_materials

Please fix up the wrong commit using git rebase --interactive (e.g. here or here) and force-pushing, so that the wrong one doesn't make it into the history.

Perhaps you did the update, putting in that SHA and it was right at the time, and then changed the URL/version again but forgot to update the SHA, and it didn't re-download it to re-hash it because fetchFromGitHub produces a fixed-output derivation that downloads only when you don't already have that SHA.
I didn't have the SHA, so for me it downloaded. This is a common pitfall.

Ah that makes sense. I'll keep that in mind.

Please fix up the wrong commit using git rebase --interactive (e.g. here or here) and force-pushing, so that the wrong one doesn't make it into the history.

Sure, will do after work.

Hmm, did you change anything else in the last push?
Now nixpkgs-review pr --checkout commit 103941 gets me a segfault on NixOS:
Program terminated with signal SIGSEGV, Segmentation fault.
#0  0x00007f1cba3e1f00 in ?? ()
   from /nix/store/kp6123kw78q7x8g5gbv6215sh7j0hs0k-python3.7-sip-4.19.24/lib/python3.7/site-packages/sip.so
warning: File "/nix/store/xbwr3krv4kkyv5h8ici7vkpnsx5w3cv3-gcc-9.3.0-lib/lib/libstdc++.so.6.0.28-gdb.py" auto-loading has been declined by your `auto-load safe-path' set to "$debugdir:$datadir/auto-load:/nix/store/vran8acwir59772hj4vscr7zribvp7l5-gcc-9.3.0-lib".
(gdb) bt
#0  0x00007f1cba3e1f00 in ?? () from /nix/store/kp6123kw78q7x8g5gbv6215sh7j0hs0k-python3.7-sip-4.19.24/lib/python3.7/site-packages/sip.so
#1  0x00007f1cba3e2c1c in ?? () from /nix/store/kp6123kw78q7x8g5gbv6215sh7j0hs0k-python3.7-sip-4.19.24/lib/python3.7/site-packages/sip.so
#2  0x00007f1cbaeaaa7d in PyInit_Arcus () from /nix/store/2y1gfczpqz1yjgwsx5hwbp1mnvjyj1js-python3.7-libarcus-4.8.0/lib/python3.7/site-packages/Arcus.so
#3  0x00007f1cc8790c3f in _PyImport_LoadDynamicModuleWithSpec () from /nix/store/cqh3nsk4z8lc960g8yqvz5nf2f6qx9v0-python3-3.8.6/lib/libpython3.8.so.1.0
#4  0x00007f1cc87904e5 in _imp_create_dynamic () from /nix/store/cqh3nsk4z8lc960g8yqvz5nf2f6qx9v0-python3-3.8.6/lib/libpython3.8.so.1.0
#5  0x00007f1cc86d0f47 in cfunction_vectorcall_FASTCALL () from /nix/store/cqh3nsk4z8lc960g8yqvz5nf2f6qx9v0-python3-3.8.6/lib/libpython3.8.so.1.0
#6  0x00007f1cc86ab1b0 in PyVectorcall_Call () from /nix/store/cqh3nsk4z8lc960g8yqvz5nf2f6qx9v0-python3-3.8.6/lib/libpython3.8.so.1.0
#7  0x00007f1cc8718504 in _PyEval_EvalFrameDefault () from /nix/store/cqh3nsk4z8lc960g8yqvz5nf2f6qx9v0-python3-3.8.6/lib/libpython3.8.so.1.0
#8  0x00007f1cc8711e81 in _PyEval_EvalCodeWithName () from /nix/store/cqh3nsk4z8lc960g8yqvz5nf2f6qx9v0-python3-3.8.6/lib/libpython3.8.so.1.0
#9  0x00007f1cc86aa5de in _PyFunction_Vectorcall () from /nix/store/cqh3nsk4z8lc960g8yqvz5nf2f6qx9v0-python3-3.8.6/lib/libpython3.8.so.1.0
#10 0x00007f1cc8717383 in _PyEval_EvalFrameDefault () from /nix/store/cqh3nsk4z8lc960g8yqvz5nf2f6qx9v0-python3-3.8.6/lib/libpython3.8.so.1.0
#11 0x00007f1cc86aa54a in _PyFunction_Vectorcall () from /nix/store/cqh3nsk4z8lc960g8yqvz5nf2f6qx9v0-python3-3.8.6/lib/libpython3.8.so.1.0
#12 0x00007f1cc8713228 in _PyEval_EvalFrameDefault () from /nix/store/cqh3nsk4z8lc960g8yqvz5nf2f6qx9v0-python3-3.8.6/lib/libpython3.8.so.1.0
#13 0x00007f1cc86aa54a in _PyFunction_Vectorcall () from /nix/store/cqh3nsk4z8lc960g8yqvz5nf2f6qx9v0-python3-3.8.6/lib/libpython3.8.so.1.0
#14 0x00007f1cc8712e33 in _PyEval_EvalFrameDefault () from /nix/store/cqh3nsk4z8lc960g8yqvz5nf2f6qx9v0-python3-3.8.6/lib/libpython3.8.so.1.0
#15 0x00007f1cc86aa54a in _PyFunction_Vectorcall () from /nix/store/cqh3nsk4z8lc960g8yqvz5nf2f6qx9v0-python3-3.8.6/lib/libpython3.8.so.1.0
#16 0x00007f1cc8712e33 in _PyEval_EvalFrameDefault () from /nix/store/cqh3nsk4z8lc960g8yqvz5nf2f6qx9v0-python3-3.8.6/lib/libpython3.8.so.1.0
#17 0x00007f1cc86aa54a in _PyFunction_Vectorcall () from /nix/store/cqh3nsk4z8lc960g8yqvz5nf2f6qx9v0-python3-3.8.6/lib/libpython3.8.so.1.0
#18 0x00007f1cc8712e33 in _PyEval_EvalFrameDefault () from /nix/store/cqh3nsk4z8lc960g8yqvz5nf2f6qx9v0-python3-3.8.6/lib/libpython3.8.so.1.0
#19 0x00007f1cc86aa54a in _PyFunction_Vectorcall () from /nix/store/cqh3nsk4z8lc960g8yqvz5nf2f6qx9v0-python3-3.8.6/lib/libpython3.8.so.1.0
#20 0x00007f1cc86aa178 in object_vacall () from /nix/store/cqh3nsk4z8lc960g8yqvz5nf2f6qx9v0-python3-3.8.6/lib/libpython3.8.so.1.0
#21 0x00007f1cc86ab3e1 in _PyObject_CallMethodIdObjArgs () from /nix/store/cqh3nsk4z8lc960g8yqvz5nf2f6qx9v0-python3-3.8.6/lib/libpython3.8.so.1.0
#22 0x00007f1cc872b7c4 in PyImport_ImportModuleLevelObject () from /nix/store/cqh3nsk4z8lc960g8yqvz5nf2f6qx9v0-python3-3.8.6/lib/libpython3.8.so.1.0
#23 0x00007f1cc87168ac in _PyEval_EvalFrameDefault () from /nix/store/cqh3nsk4z8lc960g8yqvz5nf2f6qx9v0-python3-3.8.6/lib/libpython3.8.so.1.0
#24 0x00007f1cc8711e81 in _PyEval_EvalCodeWithName () from /nix/store/cqh3nsk4z8lc960g8yqvz5nf2f6qx9v0-python3-3.8.6/lib/libpython3.8.so.1.0
#25 0x00007f1cc8711b83 in PyEval_EvalCodeEx () from /nix/store/cqh3nsk4z8lc960g8yqvz5nf2f6qx9v0-python3-3.8.6/lib/libpython3.8.so.1.0
#26 0x00007f1cc87886ab in PyEval_EvalCode () from /nix/store/cqh3nsk4z8lc960g8yqvz5nf2f6qx9v0-python3-3.8.6/lib/libpython3.8.so.1.0
#27 0x00007f1cc87994b8 in run_eval_code_obj () from /nix/store/cqh3nsk4z8lc960g8yqvz5nf2f6qx9v0-python3-3.8.6/lib/libpython3.8.so.1.0
#28 0x00007f1cc8799453 in run_mod () from /nix/store/cqh3nsk4z8lc960g8yqvz5nf2f6qx9v0-python3-3.8.6/lib/libpython3.8.so.1.0
#29 0x00007f1cc8665140 in PyRun_FileExFlags () from /nix/store/cqh3nsk4z8lc960g8yqvz5nf2f6qx9v0-python3-3.8.6/lib/libpython3.8.so.1.0
#30 0x00007f1cc8664f13 in PyRun_SimpleFileExFlags () from /nix/store/cqh3nsk4z8lc960g8yqvz5nf2f6qx9v0-python3-3.8.6/lib/libpython3.8.so.1.0
#31 0x00007f1cc87a1386 in Py_RunMain () from /nix/store/cqh3nsk4z8lc960g8yqvz5nf2f6qx9v0-python3-3.8.6/lib/libpython3.8.so.1.0
#32 0x00007f1cc87a0cf9 in Py_BytesMain () from /nix/store/cqh3nsk4z8lc960g8yqvz5nf2f6qx9v0-python3-3.8.6/lib/libpython3.8.so.1.0
#33 0x00007f1cc81a8dbd in __libc_start_main () from /nix/store/2wrfwfdpklhaqhjxgq6yd257cagdxgph-glibc-2.32/lib/libc.so.6
#34 0x000000000040107a in _start ()

Hmm, did you change anything else in the last push?

I've looked through the commits and the only change I can see is the fdm_materials, but I'll do a diff against the old branch to be sure.

Now nixpkgs-review pr --checkout commit 103941 gets me a segfault on NixOS:

Last weekend I was able to run Cura by just building it with nix-build and running the result. I'll have a closer look when I have time (hopefully tonight).

Please prefix Python packages with python3Packages..

Please prefix Python packages with python3Packages..
Done

I attempted to figure out what was causing the seg fault, but I'm really out of my depth with this issue.
If I use nix-build and run the result, it works fine. However running it in the nix-review shell causes a seg fault as @nh2 showed.
I'm very confused.

@poita66 If you can show that the previous (current master) version also segfaults in nix-review, then at least it's not a regression, so we could merge it irrespective of that (and if you find that, it'd be great to add a comment in the code because I'll definitely forget it for the next upgrade :) ).

Thanks!


Update links for renaming repository from onnx-script to onnxscript

We may need to coordinate renaming with the pytorch repo or the pytorch ci will start to fail

https://github.com/pytorch/pytorch/pull/99572

Fortunately github redirects the link. I think we are good

Please allow me to reopen this PR to re-trigger new Azurepipelines CI

@justinchuby GitHub does a really good job of redirecting the old repo to the new across API endpoints, Git, and web.


Exception filtering

I'm currently using sentry-swift in combination with raven-js on a React Native app.  When the JS bundle throws a global exception, it bubbles out to the native half of the application.  Every JS crash ends up emitting two Sentry events (one for JS, another for native).
The native message is along the lines of RCTFatalException: Unhandled JS Exception: <message>
It'd be really nice if we could filter events (via a callback?), or at least via a message prefix.

@nevir I like the idea of this! I will look into adding that in for you 😊

Awesome, thanks!

Hey there,
I know I am a little late to the party, but we added callback block before sending an event to the server ... maybe it helpful for you.
Checkout the latest release 1.3.0 https://docs.sentry.io/clients/cocoa/advanced/#change-event-before-sending-it


Add the decision tree columns inclusion/exclusion in the lookup table

Add the decision tree columns inclusion/exclusion in the lookup table

...and if you want to know how to make and view the lists there are separate functions (in the modules/tidy_tables.py), for compiling each of the 4 indicators from the lookup csv. These functions are also embedded in the "whisp_risk" function for creating default input lists.
I will add the above info to the readme when i document the risk indicator aspects.


homebrew formula

👍

@avelino per https://github.com/bcicen/ctop/issues/33, the homebrew formula can be updated as below to provide build from source:
class Ctop < Formula
  desc "Top-like interface for container metrics"
  homepage "https://bcicen.github.io/ctop/"
  url "https://github.com/bcicen/ctop/archive/v0.4.1.tar.gz"
  sha256 "bc10b774dad0bc7ef0be41bcfb36c774fc28dafa789b2f43f1ecdb5b75390867"

  depends_on "go" => :build
  depends_on "glide" => :build
  bottle :unneeded

  def install
    ENV["GOPATH"] = buildpath
    ENV["GLIDE_HOME"] = HOMEBREW_CACHE/"glide_home/#{name}"
    dir = buildpath/"src/github.com/bcicen/ctop"
    dir.install Dir["*"]
    cd dir do
      system "glide", "install"
      system "go", "build", "-o", bin/"ctop"
    end
  end

  test do
    system "#{bin}/ctop", "-v"
  end
end

@bcicen release 0.4.1 not exist glide file
[ERROR] Failed to find glide.yaml file in directory tree: Cannot resolve parent of /

Generate new release pls

Sure, code-only 0.4 release with glide published here.
url: https://github.com/bcicen/ctop/archive/v0.4.1-deps.tar.gz
sha256: 39c4247a7c6715bc45db078769419ff9bdab1219378ac39cb97febbc0130dbf5

Looks like ctop is available on Homebrew now. 😎
http://braumeister.org/formula/ctop
Simply brew install ctop

added to readme as well; thanks @avelino!

I am using by brew btw. Thanks for your efforts guys.


License?

What license is this under?

Hello, license for this is GPL 3
http://www.gnu.org/licenses/gpl-3.0.html

None of your files have any Licensing applied so only the README.md file is licensed.


XmlPoke task not updating an element value

Repro:

Create a xml file called 'test.xml' with following content

<Product>
  <Name>Book</Name>
</Product>

Create a project file called 'test.proj' with following content

<Project>
    <Target Name="Test">
        <XmlPoke
            XmlInputPath="test.xml"
            Query="/Product/Name"
            Value="Car"/>
    </Target>
</Project>

Run dotnet msbuild /t:Test

Expected
<Product>
  <Name>Car</Name>
</Product>

Actual
<Product>
  <Name>
  </Name>
</Product>

Environment Info
Microsoft (R) Build Engine version <IP_ADDRESS>922 for .NET Core
Copyright (C) Microsoft Corporation. All rights reserved.

dotnet --info
.NET Command Line Tools (2.0.0-preview2-006082)

Product Information:
 Version:            2.0.0-preview2-006082
 Commit SHA-1 hash:  6453cb4e15

Runtime Environment:
 OS Name:     Windows
 OS Version:  10.0.15063
 OS Platform: Windows
 RID:         win10-x64
 Base Path:   C:\Users\kichalla\.dotnet\x64\sdk\2.0.0-preview2-006082\

Microsoft .NET Core Shared Framework Host

  Version  : 2.0.0-preview2-25309-07
  Build    : 41f5fc94eedc889f086800c23f35bf14a8c75a9f

This is deeply, deeply confusing. I reproduce your reported behavior, and tried stepping through it in a debugger to see where things were going wrong. In XmlPoke, we navigate to XPath matches, and then assign the InnerXml of the match to the specified value:
iter.Current.InnerXml = _value.ItemSpec;

In the debugger, this completes without errors, but sets iter.Current.InnerXml to nothing, instead of the requested value. I tried to step through the implementation of XPathNavigator.InnerXml but couldn't figure out why it wasn't right.
I tried to reproduce this in a standalone app to send a bug report to CoreFX, and I got a different error when reproducing the situation:
using System;
using System.Xml;
using System.Xml.XPath;

namespace ConsoleApp1
{
    class Program
    {
        static void Main(string[] args)
        {
            XmlDocument xmlDoc = new XmlDocument();

            xmlDoc.LoadXml(@"<Product>
  <Name>Book</Name>
</Product>");

            //xmlDoc.FirstChild.FirstChild.InnerXml = "Car";

            XPathNavigator nav = xmlDoc.CreateNavigator();
            XPathExpression expr = nav.Compile("/Product/Name");

            XPathNodeIterator iter = nav.Select(expr);
            iter.MoveNext();

            Console.WriteLine(iter.Current.InnerXml);

            iter.Current.InnerXml = "Car";

            Console.WriteLine(iter.Current.InnerXml);
        }
    }
}

produces
S:\work\innerxml_assignment\ConsoleApp1\ConsoleApp1>dotnet run
Book

Unhandled Exception: System.Xml.XmlException: Data at the root level is invalid. Line 1, position 1.
   at System.Xml.XmlTextReaderImpl.Throw(Exception e)
   at System.Xml.XmlTextReaderImpl.ParseRootLevelWhitespace()
   at System.Xml.XmlTextReaderImpl.ParseDocumentContent()
   at System.Xml.XmlTextReaderImpl.Read()
   at System.Xml.XPath.XPathNavigator.BuildSubtree(XmlReader reader, XmlWriter writer)
   at System.Xml.XPath.XPathNavigator.AppendChild(XmlReader newChild)
   at ConsoleApp1.Program.Main(String[] args)

Ok, that's confusing. So I tried running MSBuild with dotnet exec path\to\fresly\built\msbuild.dll and see the same error!
s:\work\xmlpoke>dotnet\dotnet.exe exec S:\msbuild\bin\Debug-NetCore\Windows_NT_Deployment\\MSBuild.dll test.proj
Waiting for debugger to attach (s:\work\xmlpoke\dotnet\dotnet.exe PID 27052).  Press enter to continue...

Microsoft (R) Build Engine version <IP_ADDRESS> for .NET Core
Copyright (C) Microsoft Corporation. All rights reserved.

Build started 5/17/2017 5:52:28 PM.
Project "s:\work\xmlpoke\test.proj" on node 1 (default targets).
s:\work\xmlpoke\test.proj(3,9): error MSB3735: Error while executing poke operation with the Value parameter "Car". Data at the root level is invalid. Line 1, position 1.
Done Building Project "s:\work\xmlpoke\test.proj" (default targets) -- FAILED.

Build FAILED.

"s:\work\xmlpoke\test.proj" (default target) (1) ->
(Test target) ->
  s:\work\xmlpoke\test.proj(3,9): error MSB3735: Error while executing poke operation with the Value parameter "Car". Data at the root level is invalid. Line 1, position 1.

    0 Warning(s)
    1 Error(s)

Time Elapsed 00:00:00.87

This makes me suspect an issue with the different runtime that the CLI provides for us.

This definitely seems related to .NET Core. I had the same issue when running dotnet build from the command line, but I noticed I didn't have the issue when building from Visual Studio 2017. The version appears the same, but dotnet is .NET Core and VS is .NET Framework.
> dotnet msbuild /version
Microsoft (R) Build Engine version 15.3.409.57025 for .NET Core
Copyright (C) Microsoft Corporation. All rights reserved.

15.3.409.57025

C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\MSBuild\15.0\Bin>msbuild /version
Microsoft (R) Build Engine version 15.3.409.57025 for .NET Framework
Copyright (C) Microsoft Corporation. All rights reserved.

15.3.409.57025

I still seem to be seeing this problem 3 year later...


Allow Modules in sub directories

everest-core has many different modules now and it is hard to find out the type of a module, e.g. if it is a hardware driver or a simulation module etc.
This PR allows to move modules into subfolders in the source tree. Upon install, the modules will still be installed flat into one folder. Two modules are moved to a deprected folder as an example. All other modules are not moved as this would create a lot of conflicts with other branches. Moving into a new structure needs to be a coordinated effort, but this adds the basis to be able to do that.

See #279

Replaced by PR279


Ignore the NotNull/NotBlank/NotEmpty annotations in multiple validation annotations cases

As we known, there's a limitation in generating random value with multi-validation annotations.
But it must be a way to optimize this functionality.
There are some suggestions:

just ignore the NotNull/NotBlank/NotEmpty annotations, because Handling these annotations are unnecessary for generating random value

always use the first annotation in the field so that users can choose anyone themselves

Thank you for these suggestions, but none of them would solve the issue. Here is why, consider the following example:
class Person {
    @NotBlank
    @Size(min = 5, max = 10)
    @Pattern(regexp = "a*b")
    String name;
}

I understand we could ignore NotBlank here, but the issue is still present on how to generate a random valid value according to the remaining two annotations (ie a String conform to the regexp a*b and having a length in [5,10] range). Basically, ignoring NotNull/NotBlank/NotEmpty does not work as soon as you have more than two annotations on the field.

Always using the first annotation would not work since Field#getDeclaredAnnotations does not specify in which order annotations are returned. And even if the order of returned annotations is consistent (according to 1 and 2) , taking the first annotation only might not be sufficient. In the previous example, this means I need to choose between either @Size or @Pattern, but I want both.

In sum, the issue with multiple validation annotations is that Easy Random provides a handler per annotation. It is not possible to statically interpret multiple validation contraints (imagine all the combinations..) and return a randomizer that generates a random value that is valid according to the combined validation logic. Some alternatives have been described in #418 and #351.
I'm closing this issue for now but feel free to add a comment if needed.


How to modify different class label order of the export yolo format classes.txt ?

RT. How to modify different class label order of the export yolo format classes.txt ?
for example, the default different class label order for classes.txt:
clash
crack
crush

what i want the different class label order for classes.txt is as following:
crack
crush
clash

Hi @JohnTian
You need to modify your local version of label-studio-converter _get_labels method. categories list contains classes names with indexes - you can modify it to get different order.

Hi @JohnTian You need to modify your local version of label-studio-converter _get_labels method. categories list contains classes names with indexes - you can modify it to get different order.

Thanks a lot. I will check it later.

https://github.com/heartexlabs/label-studio/issues/3653
https://github.com/heartexlabs/label-studio/issues/3324
https://github.com/heartexlabs/label-studio/issues/2886
https://github.com/heartexlabs/label-studio/issues/1115
https://github.com/heartexlabs/label-studio/issues/737

https://github.com/heartexlabs/label-studio/issues/2886#issuecomment-1238008483

@makseq I am afraid this still does not work (version 1.7.2)
<View>
  <Image name="image" value="$image" zoom="true" zoomControl="true"/>
  <RectangleLabels name="label" toName="image">

  <Label value="person" category="0" background="#0000FF"/><Label value="head" category="1" background="#FF0000"/></RectangleLabels>
</View>

But the generated file classes.txt has its content like this:
head
person

My understanding is that because category=0 is for person, person should be first class in classes.txt file.

@TrueWodzu It work for version 1.7.3 dev

Perfect, will wait for the official release. Thank you.


Fix using bin/OSX directory to bin/macOS

This is a fix for #21

I am trying to use your fork with packer to see if I can fix this issue. I can't get the your fork to load, do you know how to do that @wantyapps ?

I am trying to use your fork with packer to see if I can fix this issue. I can't get the your fork to load, do you know how to do that @wantyapps ?

you need to uninstall your current installation first because packer stores the plugin 'user/repo' as 'repo'.  so packer will not notice a change, e.g., from 'tj/nlua' to 'telescopicjohnson/nlua'. if you delete the former, quit nvim, add the latter, quit nvim, then packer install you should be good to go.
fwiw, the pull request i just made fixes this also plus a few other things for wiggle room.

thanks for letting me know @klooj!
So I need to uninstall everything and reinstall it?

not everything, just the nlua plugin. so comment out tj/nlua and run packersync. then add newjawn/nlua and run packersync. you'll likely need to exit vim in between.

@keblek To uninstall the plugin, remove "use 'tjdevries/nlua.nvim'" (similar, will probably not look the same) re-open nvim, and run the command ":PackerClean". You can now install my fork


My Business API v4.x Support?

Since the Google My Business API v3.3 will be "sunsetted" on the 10th of may 2018 and this gem does not support any newer version yet - it would be nice to know if there is any attempt to release a version with My Business API v4.x support in time?
https://developers.google.com/my-business/content/sunset-dates

Duplicate of #662


feat: add a bootc snapshot

This adds the bootc binary to the image. It can be used in conjuction with rpm-ostree and will end up on the base image in the future anyway but adding it now so we can test
Thank you for contributing to the Universal Blue project!
Guidelines
In this project we follow Semantic PRs and Conventional Commits to describe features and fixes we made. It would be nice if you did too. Not sure what this all means? Here are some examples. Did you already use this? Awesome, thanks again!

Good catch!


chore(release): 1.143.0

See CHANGELOG

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v2
Commit ID: 3ee356b97c365cbd984e610ef26f8d22c594d3cb
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v2
Commit ID: 811c3d86a93681a6b527798e90444f9c11a524eb
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v1
Commit ID: 811c3d86a93681a6b527798e90444f9c11a524eb
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository


Add to awesome-yazi

Hi, cool plugin!
Would you like to add it to awesome-yazi? It would be amazing addition to the list! Please make a PR in the repo following the guidelines mentioned there. :)
Thank you!

Done in https://github.com/AnirudhG07/awesome-yazi/pull/31 :rocket:

Thanks


feat: 🎸 skip log when no migrations run

Description
updates HTTP log in entrypoint.sh and doesn't log for 0 migrations being ran
Breaking Changes

JIRA Link

Checklist

[ ] Updated the Readme.md (if required) ?

:tada: This PR is included in version 9.7.0-alpha.13 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


feat(ISV-5447): add multi-arch and sha info to release note images

This is ready for review, but depends on https://github.com/konflux-ci/release-service-utils/pull/333/ to be merged first so that the multiarch field is populated before merge.

If you are adding things to releaseNotes the schema needs to be updated https://github.com/konflux-ci/release-service-catalog/blob/development/schema/dataKeys.json

Thanks @johnbieren, added the schema.

My PTO is starting tomorrow, so @jedinym from my team will be taking over getting this PR merged.

If you are adding things to releaseNotes the schema needs to be updated https://github.com/konflux-ci/release-service-catalog/blob/development/schema/dataKeys.json

This is added during the release pipeline. I thought the schema only covers what's there at the start, but apparently I was wrong. What's the purpose of having releaseNotes.content.images there? It will never be validated, no?

If you are adding things to releaseNotes the schema needs to be updated https://github.com/konflux-ci/release-service-catalog/blob/development/schema/dataKeys.json

This is added during the release pipeline. I thought the schema only covers what's there at the start, but apparently I was wrong. What's the purpose of having releaseNotes.content.images there? It will never be validated, no?

The releaseNotes stuff is unique. We don't overwrite. We =+ https://github.com/konflux-ci/release-service-catalog/blob/development/tasks/populate-release-notes-images/populate-release-notes-images.yaml#L111
A user could define the same stuff the task is adding for them. I don't know why they'd want to, but they could. So, if a field could be provided by the user, I think it should be in the schema

If you are adding things to releaseNotes the schema needs to be updated https://github.com/konflux-ci/release-service-catalog/blob/development/schema/dataKeys.json

This is added during the release pipeline. I thought the schema only covers what's there at the start, but apparently I was wrong. What's the purpose of having releaseNotes.content.images there? It will never be validated, no?

The releaseNotes stuff is unique. We don't overwrite. We =+ https://github.com/konflux-ci/release-service-catalog/blob/development/tasks/populate-release-notes-images/populate-release-notes-images.yaml#L111 A user could define the same stuff the task is adding for them. I don't know why they'd want to, but they could. So, if a field could be provided by the user, I think it should be in the schema

I'm not completely sure I buy this argument - it seems to me that being theoretically able to set this already in the RPA is more of a side effect. I'm not even sure if that should be allowed at all - it should say what was actually included in that release, right? So users shouldn't really be able to say that something extra is being released too when it's not. Or am I missing something?

I replied on the ticket, but why are we adding new fields to the advisories? Shouldn't this be driven by prodsec? Maybe it already is, but I haven't seen it

Good point. I completely missed the fact that this will also add these fields to the resulting advisory json.

If you are adding things to releaseNotes the schema needs to be updated https://github.com/konflux-ci/release-service-catalog/blob/development/schema/dataKeys.json

This is added during the release pipeline. I thought the schema only covers what's there at the start, but apparently I was wrong. What's the purpose of having releaseNotes.content.images there? It will never be validated, no?

The releaseNotes stuff is unique. We don't overwrite. We =+ https://github.com/konflux-ci/release-service-catalog/blob/development/tasks/populate-release-notes-images/populate-release-notes-images.yaml#L111 A user could define the same stuff the task is adding for them. I don't know why they'd want to, but they could. So, if a field could be provided by the user, I think it should be in the schema

I'm not completely sure I buy this argument - it seems to me that being theoretically able to set this already in the RPA is more of a side effect. I'm not even sure if that should be allowed at all - it should say what was actually included in that release, right? So users shouldn't really be able to say that something extra is being released too when it's not. Or am I missing something?

I am referring to adding it to the Release data section, not ReleasePlanAdmission

What difference does it make? I understand that if you create a manual Release then you know the snapshot and so you can enter correct data about images in the snapshot into the Release data section, but those would then be duplicated in our task anyway. So not sure what the point would be.

If you are adding things to releaseNotes the schema needs to be updated https://github.com/konflux-ci/release-service-catalog/blob/development/schema/dataKeys.json

This is added during the release pipeline. I thought the schema only covers what's there at the start, but apparently I was wrong. What's the purpose of having releaseNotes.content.images there? It will never be validated, no?

The releaseNotes stuff is unique. We don't overwrite. We =+ https://github.com/konflux-ci/release-service-catalog/blob/development/tasks/populate-release-notes-images/populate-release-notes-images.yaml#L111 A user could define the same stuff the task is adding for them. I don't know why they'd want to, but they could. So, if a field could be provided by the user, I think it should be in the schema

I'm not completely sure I buy this argument - it seems to me that being theoretically able to set this already in the RPA is more of a side effect. I'm not even sure if that should be allowed at all - it should say what was actually included in that release, right? So users shouldn't really be able to say that something extra is being released too when it's not. Or am I missing something?

I am referring to adding it to the Release data section, not ReleasePlanAdmission

What difference does it make? I understand that if you create a manual Release then you know the snapshot and so you can enter correct data about images in the snapshot into the Release data section, but those would then be duplicated in our task anyway. So not sure what the point would be.

Because you want an image in your advisory that is not part of your snapshot or isn't mapped or something. I don't know. I am just saying it is a possible use case so it should be in the schema

I replied on the ticket, but why are we adding new fields to the advisories? Shouldn't this be driven by prodsec? Maybe it already is, but I haven't seen it

@johnbieren If I understand correctly, the new fields in the advisory are not the intention here. They are only a side effect of adding additional data for the update-component-sbom task. I will refactor this PR to avoid that issue.

I replied on the ticket, but why are we adding new fields to the advisories? Shouldn't this be driven by prodsec? Maybe it already is, but I haven't seen it

@johnbieren If I understand correctly, the new fields in the advisory are not the intention here. They are only a side effect of adding additional data for the update-component-sbom task. I will refactor this PR to avoid that issue.

Thank you!

@mmalina @johnbieren I refactored the PR to avoid changing the advisories. It's ready for review, thanks. I'd like to merge this before #627.

@johnbieren @mmalina I implemented your requested changes.

Note that stage Pyxis is down ATM, so e2e will fail right now.

@mmalina Pyxis is up, could you please run the tests?

/ok-to-test

Let's see if it is enough to start the tests.

E2E passed and this is approved. It is going to be competing with some other PRs for the rebase thing before merging, but now that we can rebase via UI, I will handle rebasing and merging this today. @wcheang this is ready to be merged, right?

@johnbieren wcheang is on holiday, I took over this PR. It is ready to be merged.
Just a heads-up, rebasing via the UI will remove signatures from commits.

@johnbieren wcheang is on holiday, I took over this PR. It is ready to be merged.
Just a heads-up, rebasing via the UI will remove signatures from commits.

thanks for the heads up. Yeah, we removed the signed commit requirement because having our contributors rebase 90x with us unable to help :slightly_smiling_face: so now we can rebase for you

/ok-to-test

/ok-to-test

/ok-to-test


Problem with batch inserting of string values

Even when using the provided example code, binding multiple string values does not seem to work properly, whereas binding multiple integer or float values is no problem.
Insert Result when running the example code:
column x | column y | column z
==============================
'this'   |  1       | 1.1
''       |  2       | 2.2
''       |  3       | 3.3
''       |  4       | 4.4

Note that only the first string value is actually inserted.
The code is compiled with Visual Studio 2013, Windows 8.1 64 Bit.
Postgres database is accessed via postgresql ODBC driver.

I promise to take a look at this ASAP. If there's one thing I wish I could refactor about nanodbc it's the string binding code, so it doesn't surprise me there's an issue here. Sorry for any inconvenience :(

Here is complete test case that confirms the bug (tried with ODBC Driver 11 for SQL Server).
// add to test/base_test_fixture.h
    void batch_insert_string_test()
    {
        auto conn = connect();
        create_table(conn, NANODBC_TEXT("batch_insert_string_test"), NANODBC_TEXT("(s varchar(60))"));
        auto const insert = NANODBC_TEXT("insert into batch_insert_string_test(s) values (?);");
        auto const select = NANODBC_TEXT("select s from batch_insert_string_test");

        std::size_t const strings_size = 5;
        nanodbc::string_type::value_type strings[strings_size][60] =
        {
            NANODBC_TEXT("first string"),
            NANODBC_TEXT("second string"),
            NANODBC_TEXT("third string"),
            NANODBC_TEXT("this is fourth string"),
            NANODBC_TEXT("finally, the fifthstring")
        };

        nanodbc::statement stmt(conn);
        prepare(stmt, insert);
        stmt.bind_strings(0, strings);

        nanodbc::transact(stmt, strings_size);
        {
            auto result = execute(conn, select);
            std::size_t i = 0;
            while (result.next())
            {
                REQUIRE(result.get<nanodbc::string_type>(0) == strings[i]);
                ++i;
            }
        }
    }

@lexicalunit I think, #214 might be an improvement or at least work around this issue.

I think I found where the bug may be hiding.
The bind_parameter method calls SQLBindParameter with parameter_size used for both, column size and (input) buffer size. This leads to problems with character data
For example, when batch inserting two values into varchar(60) column, SQLDescribeParam during prepare_bind determines that parameter_size=60.
Then,

char data[2][60] = { "first string", "second string" } works OK because parameter_size is the same as actual buffer size.
char data[2][40] = { "first string", "second string" } leads to buffer overrun since ODBC reads the data assuming its elements are 60 bytes long, while they are only 40.

The bind_strings takes the data element length, but later it is ignored (search for line std::size_t, // length) and never passed to bind method.
In order to fix it, I think, we need to change the bind_strings and bind signatures and pass the actual buffer length.

I think your analysis is correct.
This is at least partially addressed in https://github.com/lexicalunit/nanodbc/pull/214/files#diff-e08e69e2fefb6b4be6b4af787c247da6R1923, we now pass the input length to bind_parameter() rather than the result returned.

According to MSDN, ColumnSize parameter of SQLBindParameter
specifies the size of the column, the length of that data, or both.  For character/binary data type sets SQL_DESC_LENGTH descriptor.
The SQL_DESC_LENGTH is described as:

A numeric value that is either the maximum or actual character length of a character string or binary data type.
It is the maximum character length for a fixed-length data type,
or the actual character length for a variable-length data type.

My conclusion: for character/binary data types, actual data length is never larger maximum (column size as defined in table schema), role of column and buffer (data) size is sematically identical. However, their values are NOT identical.
While the column size is expected to be size in number of characters (sets SQL_DESC_LENGTH), the buffer size is expected to be number of bytes (sets SQL_DESC_OCTET_LENGTH descriptor).
Obviously, we can't expect size of character is 1 byte.
If my understanding above is correct and to be on safe side, we need to pass both values, column size and buffer size, separately.

I believe #220 has fixed this issue. If not, please re-open.