Create Operator to install Ortelius into K8s

Need an Ortelius Operator and publish it to OperatorHub.io

no longer needed


which.ps1: Non-extant $command generates errors

If something like 'which dfsdfjsaf' is entered with this function errors are returned. Desired behavior would be nothing returned to user, just like the actual 'which' command.

Issue has been resolved in latest version.


feat: option to limit CRs the operator watches

Fixes #453

@csviri @metacosm this is a POC for #453 and about using the mocked kubernetes server for testing

@csviri @metacosm any feedback on this PR ?

I started looking into it. Will review today.

Also will try to take a look, but little busy from now on today :-/


Invoke-WebRequest in PS Core throws a terminating error in situations where a non-terminating error is issued in Windows PowerShell

Note: I don't know if the change - a breaking one - was intentional. If so, it's worth documenting.
Arguably, the new behavior is less surprising.
Update: The change in behavior seems to come from the underlying [System.Net.HttpWebRequest] class, but it's still worth getting clarity on how PowerShell should behave.
Steps to reproduce
Try to access a redirected URL without allowing redirections.
In Windows PowerShell, you get a non-terminating error that still returns a response object that can be acted on, so as to determine the redirection target URL:
(Invoke-WebRequest -Method HEAD http://cnn.com -MaximumRedirection 0 -ErrorAction Ignore).Headers.Location

Expected behavior
If the behavior were consistent, PS Core and Windows PowerShell would output the redirection target URL:
http://www.cnn.com/

Actual behavior
Windows PowerShell: as expected.
PowerShell Core: a statement-terminating error is thrown, causing -ErrorAction Ignore to be ignored and no object to be returned.
Invoke-WebRequest : Response status code does not indicate success: 301 (Moved Permanently).
....

The workaround is to trap the error / inspect $Error[0] and examine its .Exception.Response property: $Error[0].Exception.Response.Headers.Location).
Environment data

PowerShell Core v6.0.0-beta.5 on macOS 10.12.6
PowerShell Core v6.0.0-beta.5 on Ubuntu 16.04.3 LTS
PowerShell Core v6.0.0-beta.5 on Microsoft Windows 10 Pro (64-bit; v10.0.15063)
Windows PowerShell v5.1.15063.483 on Microsoft Windows 10 Pro (64-bit; v10.0.15063)

System.Net.Http.HttpResponseMessage.IsSuccessStatusCode  only considers 200-299 as success. Invoke-WebRequest is evaluating that and then generating a terminating error if IsSuccessStatusCode is false. I think their definition of "success code" is literally the 200 responses. 100-299 are "not errors". Not all "not errors" are "successes" but all "successes" are "not errors".
I guess in the case of your example, wouldn't a 301 with -MaximumRedirection 0 technically be a terminating error? I mean, I understand that you are attempting to retrieve where the page is redirecting, but under normal circumstances if you told it not to redirect and it tried to redirect, wouldn't that be an error?

@markekraus:
Thanks for the background info.
Yes, as I've said the terminating error arguably makes more sense, but the issue is that the behavior has changed - namely in the underlying  System.Net.HttpWebRequest class, from what I can tell:
# OK in Windows PowerShell, error in PS Core.
$req = [System.Net.HttpWebRequest]::Create('http://cnn.com'); $req.AllowAutoRedirect = $false; $req.GetResponse().ResponseUri.AbsoluteUri

Do you know anything about that? Was the old behavior considered a bug that is now fixed?
Either way, action is needed, even if it only means documenting the change.
I suppose another option would be for Invoke-WebRequest to mask the change.

From what I can tell there is an entirely new philosophy at play in the new System.Net.Http.HttpResponseMessage which is in use in Core. It is meant to be strongly typed and rigid. I would not be surprised if this new behavior is entirely intentional. I don't know if they were addressing specific problems or not.
It probably does warrant a documentation note. But, then, there are a bunch of changes in behavior between 5.1 and 6.0 in the WebRequest cmdlets (like the headers dictionary values no being a [System.String[]] instead of just a string and strict request header and user-agent validation is now default). Not sure how or where to document all of those differences.

Is this just going to be documented or will there be a change? Is it intended that running this with -ErrorAction SilentlyContinue will still produce the exact same error and not give me any value whatsoever? Imho that would not be good.

@ericwj Hmm looks like I missed documenting this as a breaking change. I will update the doc when I have a chance or you can submit a PR for it as well.
Ultimately, this is by design and while an unintended consequence of moving to HttpClient, it fixes broken/poorly-designed behavior in previous versions. What I do have planned for a future version (possibly 6.2.0) is to add the ability to specify what status codes to treat as success. There are many instances where you need check the content of a 404 from a REST API as it contains valuable information in JSON.
The 3XX status codes could be treated as success.
I have some possible designs listed in #6157

I understand the design, I don't understand it does not matter what the value of -ErrorAction is.

@ericwj:
This is a general issue: The -ErrorAction common parameter applies to nonterminating errors only; it has no effect on statement-terminating errors, which are what Invoke-WebRequest now reports in the situations discussed.
Note that the $ErrorActionPreference preference variable still applies, however - see this doc issue.

I think the default action of throwing a terminating error is bad. For example, I'm writing a module to use with HDFS which happens in a 2 part interaction. The first put request returns a 307, I need to look at that response to get the location header and make sure it was a 307, not something else like a 400 or 500. Then I send a new request with possibly different headers and body content, so I can't just follow the redirection. I need to be able to see the response code from the first request, make sure it was a 307 and then move on. In PS v5, I was able to do this with the -ErrorAction parameter. This should be the same behavior in PS Core.

So, this is a terminating error because, well,, this is a terminating error. When the result is not successful the command terminates and doesn't process further. A non-terminating error only makes sense when the command continues. This is a common pattern (as far as I can tell) with Invoke cmdlets. When a response is successful there is more processing done on the response. That's why the command terminating early is properly a terminating error.
As for the testing of 300 level response codes (and others), this will be addressed in another manner by allowing users to either treat all status as successful or to supply what response codes should be considered successful. There are plenty of situations where even a 404 needs to be tested.
For general use, if a user supplies a -MaximumRedirection and the redirects go beyond that count, that is an error and in the case of these cmdlets, a terminating one. Instead of thinking about it from a testing or grabbing location headers perspective, think about it from a normal user's perspective. They are saying "do not go more than this many hops" if the last hop in that count is not successful, then they would be expecting an error, not a successful response without what they are looking for. Now the burden is on them to test the status code to see if it was really a successful call or not.

I also need this feature to check about an HTTP 303 response. From this thread as well as https://github.com/PowerShell/PowerShell/issues/6157#issuecomment-365796222 there seem to be at least two solutions:

Provide an option to treat all status as success, like -TreatsAllStatusAsSuccessful or -IgnoreStatusError.
Provide an option to specify the successful statuses (besides the standard ones like 2xx?). Note that we may need range here, like 300-399 or 3xx.

I would prefer the first one. It’s easy to implement, and we don’t need to discuss whether to allow default successful statuses. User can write their own logic to decide whether status is success.

I can concur/pile on here; especially in the situations where, for example, (AD FS or other types of) logins are in place - the initial response would give a redirect (to a login page) Since 30x is treated as an error, you can't login in that case because in order to login - you need to follow that redirect. So, please do provide a way to be able to set a range of HTTP codes as correct.

It works correctly adding the -SkipHttpErrorCheck flag to Invoke-WebRequest

@iSazonov I think we can close this


Create aliases on DAG components.

Previous alias commit logic would frequently result in PFS states that
violated the key provenance invariant, which could lead to surprising
behavior. This change creates alias commits on entire connected
components of the provenance graph, rather than just on those branches
upstream of changes.
This results in more alias commits being created, which affects the
output of list commit  and can lead to running a job after
restarting a pipeline in cases where that would not have happened
before.
Note that rewinding to states before this change is not prevented and
can still cause problems.

Closing this pr, as it's obsolete (after discussing with @acohen4).


Stop app from refreshing contents when orientation is changed

http://www.dreamincode.net/forums/topic/258387-dont-reload-app-when-orientation-changes/

Fix committed but not yet committed


HBASE-28085 Configurably use scanner timeout as rpc timeout for scanner next calls

Adds a new hbase.client.use.scanner.timeout.for.next.calls config, defaulting to false. When true, ClientScanner (for HTable) will use the scanner timeout for next() calls like AsyncTable does. As with AsyncTable, other calls (openScanner, closeScanner, renewLease) continue to use readRpcTimeout.
Adds a new test in TestClientScannerTimeouts to verify old and new behavior.
I wonder if we should enable this by default in branch-2, and disable by default in 2.5.x. Open to opinions.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 40s
Docker mode activated.

-0 :warning:
yetus
0m  4s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
2m 28s
branch-2 passed

+1 :green_heart:
compile
0m 17s
branch-2 passed

+1 :green_heart:
shadedjars
4m 48s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 16s
branch-2 passed

_ Patch Compile Tests _

-1 :x:
mvninstall
0m 40s
root in the patch failed.

-1 :x:
compile
0m 17s
hbase-client in the patch failed.

-0 :warning:
javac
0m 17s
hbase-client in the patch failed.

-1 :x:
shadedjars
2m  7s
patch has 17 errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 14s
the patch passed

_ Other Tests _

-1 :x:
unit
0m 17s
hbase-client in the patch failed.

12m 54s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5402/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5402

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux edbe8ef139b6 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 3b34bc2aad

Default Java
Temurin-1.8.0_352-b08

mvninstall
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5402/1/artifact/yetus-jdk8-hadoop2-check/output/patch-mvninstall-root.txt

compile
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5402/1/artifact/yetus-jdk8-hadoop2-check/output/patch-compile-hbase-client.txt

javac
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5402/1/artifact/yetus-jdk8-hadoop2-check/output/patch-compile-hbase-client.txt

shadedjars
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5402/1/artifact/yetus-jdk8-hadoop2-check/output/patch-shadedjars.txt

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5402/1/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-client.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5402/1/testReport/

Max. process+thread count
64 (vs. ulimit of 30000)

modules
C: hbase-client U: hbase-client

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5402/1/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 38s
Docker mode activated.

-0 :warning:
yetus
0m  5s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
3m 34s
branch-2 passed

+1 :green_heart:
compile
0m 25s
branch-2 passed

+1 :green_heart:
shadedjars
5m 19s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 21s
branch-2 passed

_ Patch Compile Tests _

-1 :x:
mvninstall
0m 51s
root in the patch failed.

-1 :x:
compile
0m 17s
hbase-client in the patch failed.

-0 :warning:
javac
0m 17s
hbase-client in the patch failed.

-1 :x:
shadedjars
2m 12s
patch has 17 errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 14s
the patch passed

_ Other Tests _

-1 :x:
unit
0m 17s
hbase-client in the patch failed.

14m 59s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5402/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5402

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 47af5a1b4e7f 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 3b34bc2aad

Default Java
Eclipse Adoptium-11.0.17+8

mvninstall
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5402/1/artifact/yetus-jdk11-hadoop3-check/output/patch-mvninstall-root.txt

compile
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5402/1/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-client.txt

javac
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5402/1/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-client.txt

shadedjars
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5402/1/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5402/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-client.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5402/1/testReport/

Max. process+thread count
77 (vs. ulimit of 30000)

modules
C: hbase-client U: hbase-client

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5402/1/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 11s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
3m 54s
branch-2 passed

+1 :green_heart:
compile
1m 12s
branch-2 passed

+1 :green_heart:
checkstyle
0m 29s
branch-2 passed

+1 :green_heart:
spotless
1m  7s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
1m 29s
branch-2 passed

_ Patch Compile Tests _

-1 :x:
mvninstall
1m 17s
root in the patch failed.

-1 :x:
compile
0m 54s
hbase-client in the patch failed.

-0 :warning:
javac
0m 54s
hbase-client in the patch failed.

+1 :green_heart:
checkstyle
0m 26s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

-1 :x:
hadoopcheck
1m 32s
The patch causes 17 errors with Hadoop v2.10.2.

-1 :x:
hadoopcheck
3m  5s
The patch causes 17 errors with Hadoop v3.2.4.

-1 :x:
hadoopcheck
4m 19s
The patch causes 17 errors with Hadoop v3.3.5.

+1 :green_heart:
spotless
0m 41s
patch has no errors when running spotless:check.

-1 :x:
spotbugs
0m 13s
hbase-client in the patch failed.

_ Other Tests _

+1 :green_heart:
asflicense
0m 10s
The patch does not generate ASF License warnings.

18m 38s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5402/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5402

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux ac81b526db00 5.4.0-152-generic #169-Ubuntu SMP Tue Jun 6 22:23:09 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 3b34bc2aad

Default Java
Eclipse Adoptium-11.0.17+8

mvninstall
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5402/1/artifact/yetus-general-check/output/patch-mvninstall-root.txt

compile
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5402/1/artifact/yetus-general-check/output/patch-compile-hbase-client.txt

javac
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5402/1/artifact/yetus-general-check/output/patch-compile-hbase-client.txt

hadoopcheck
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5402/1/artifact/yetus-general-check/output/patch-javac-2.10.2.txt

hadoopcheck
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5402/1/artifact/yetus-general-check/output/patch-javac-3.2.4.txt

hadoopcheck
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5402/1/artifact/yetus-general-check/output/patch-javac-3.3.5.txt

spotbugs
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5402/1/artifact/yetus-general-check/output/patch-spotbugs-hbase-client.txt

Max. process+thread count
78 (vs. ulimit of 30000)

modules
C: hbase-client U: hbase-client

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5402/1/console

versions
git=2.34.1 maven=3.8.6 spotbugs=4.7.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 50s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m  9s
branch-2 passed

+1 :green_heart:
compile
3m 33s
branch-2 passed

+1 :green_heart:
checkstyle
0m 56s
branch-2 passed

-1 :x:
spotless
0m 44s
branch has 1 errors when running spotless:check, run spotless:apply to fix.

+1 :green_heart:
spotbugs
2m 40s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 35s
the patch passed

+1 :green_heart:
compile
3m  8s
the patch passed

+1 :green_heart:
javac
3m  7s
the patch passed

+1 :green_heart:
checkstyle
0m 54s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
13m 25s
Patch does not cause any errors with Hadoop 2.10.2 or 3.2.4 3.3.5.

+1 :green_heart:
spotless
0m 41s
patch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
2m 36s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 21s
The patch does not generate ASF License warnings.

38m  6s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5402/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5402

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux 21c5dee73c48 5.4.0-152-generic #169-Ubuntu SMP Tue Jun 6 22:23:09 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 3b34bc2aad

Default Java
Eclipse Adoptium-11.0.17+8

spotless
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5402/2/artifact/yetus-general-check/output/branch-spotless.txt

Max. process+thread count
78 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5402/2/console

versions
git=2.34.1 maven=3.8.6 spotbugs=4.7.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 40s
Docker mode activated.

-0 :warning:
yetus
0m  4s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m  8s
branch-2 passed

+1 :green_heart:
compile
0m 53s
branch-2 passed

+1 :green_heart:
shadedjars
4m 45s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 37s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 12s
the patch passed

+1 :green_heart:
compile
0m 55s
the patch passed

+1 :green_heart:
javac
0m 55s
the patch passed

+1 :green_heart:
shadedjars
4m 43s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 35s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
7m 51s
hbase-client in the patch passed.

+1 :green_heart:
unit
205m 30s
hbase-server in the patch passed.

235m 32s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5402/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5402

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 136f98a8d376 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 3b34bc2aad

Default Java
Temurin-1.8.0_352-b08

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5402/2/testReport/

Max. process+thread count
4499 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5402/2/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 43s
Docker mode activated.

-0 :warning:
yetus
0m  5s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m  9s
branch-2 passed

+1 :green_heart:
compile
1m  7s
branch-2 passed

+1 :green_heart:
shadedjars
5m 31s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 43s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 48s
the patch passed

+1 :green_heart:
compile
1m  7s
the patch passed

+1 :green_heart:
javac
1m  7s
the patch passed

+1 :green_heart:
shadedjars
5m 25s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 41s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
8m 12s
hbase-client in the patch passed.

+1 :green_heart:
unit
209m 57s
hbase-server in the patch passed.

244m 30s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5402/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5402

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux dd0c73b0fc90 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 3b34bc2aad

Default Java
Eclipse Adoptium-11.0.17+8

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5402/2/testReport/

Max. process+thread count
4923 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5402/2/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 49s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 58s
branch-2 passed

+1 :green_heart:
compile
3m 12s
branch-2 passed

+1 :green_heart:
checkstyle
0m 55s
branch-2 passed

+1 :green_heart:
spotless
0m 41s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
2m 17s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 36s
the patch passed

+1 :green_heart:
compile
3m 10s
the patch passed

+1 :green_heart:
javac
3m 10s
the patch passed

+1 :green_heart:
checkstyle
0m 54s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
13m 14s
Patch does not cause any errors with Hadoop 2.10.2 or 3.2.4 3.3.5.

+1 :green_heart:
spotless
0m 42s
patch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
2m 34s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 19s
The patch does not generate ASF License warnings.

36m 52s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5402/3/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5402

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux 23a6eae5c60a 5.4.0-152-generic #169-Ubuntu SMP Tue Jun 6 22:23:09 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 3b34bc2aad

Default Java
Eclipse Adoptium-11.0.17+8

Max. process+thread count
78 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5402/3/console

versions
git=2.34.1 maven=3.8.6 spotbugs=4.7.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 41s
Docker mode activated.

-0 :warning:
yetus
0m  5s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 34s
branch-2 passed

+1 :green_heart:
compile
0m 52s
branch-2 passed

+1 :green_heart:
shadedjars
4m 47s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 37s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 19s
the patch passed

+1 :green_heart:
compile
0m 53s
the patch passed

+1 :green_heart:
javac
0m 53s
the patch passed

+1 :green_heart:
shadedjars
4m 44s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 35s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
7m 54s
hbase-client in the patch passed.

+1 :green_heart:
unit
204m 51s
hbase-server in the patch passed.

235m 38s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5402/3/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5402

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux bd6860a7919b 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 3b34bc2aad

Default Java
Temurin-1.8.0_352-b08

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5402/3/testReport/

Max. process+thread count
4714 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5402/3/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 42s
Docker mode activated.

-0 :warning:
yetus
0m  6s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 58s
branch-2 passed

+1 :green_heart:
compile
1m  1s
branch-2 passed

+1 :green_heart:
shadedjars
5m  7s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 39s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 35s
the patch passed

+1 :green_heart:
compile
1m  0s
the patch passed

+1 :green_heart:
javac
1m  0s
the patch passed

+1 :green_heart:
shadedjars
5m  3s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 38s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
8m  4s
hbase-client in the patch passed.

+1 :green_heart:
unit
202m 58s
hbase-server in the patch passed.

235m 41s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5402/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5402

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 5b2a84c32d3c 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 3b34bc2aad

Default Java
Eclipse Adoptium-11.0.17+8

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5402/3/testReport/

Max. process+thread count
4908 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5402/3/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 42s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m  4s
branch-2 passed

+1 :green_heart:
compile
3m 10s
branch-2 passed

+1 :green_heart:
checkstyle
0m 50s
branch-2 passed

+1 :green_heart:
spotless
0m 44s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
2m 14s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 42s
the patch passed

+1 :green_heart:
compile
3m 10s
the patch passed

+1 :green_heart:
javac
3m 10s
the patch passed

+1 :green_heart:
checkstyle
0m 52s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
14m 18s
Patch does not cause any errors with Hadoop 2.10.2 or 3.2.4 3.3.6.

+1 :green_heart:
spotless
0m 42s
patch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
2m 29s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 16s
The patch does not generate ASF License warnings.

37m 28s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5402/4/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5402

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux 12254cd35be0 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / e8cbc3faeb

Default Java
Eclipse Adoptium-11.0.17+8

Max. process+thread count
76 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5402/4/console

versions
git=2.34.1 maven=3.8.6 spotbugs=4.7.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 37s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 51s
branch-2 passed

+1 :green_heart:
compile
0m 59s
branch-2 passed

+1 :green_heart:
shadedjars
4m 55s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 38s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 29s
the patch passed

+1 :green_heart:
compile
0m 59s
the patch passed

+1 :green_heart:
javac
0m 59s
the patch passed

+1 :green_heart:
shadedjars
4m 55s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 36s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
8m  1s
hbase-client in the patch passed.

+1 :green_heart:
unit
200m 14s
hbase-server in the patch passed.

232m  9s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5402/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5402

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 24db69add81a 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / e8cbc3faeb

Default Java
Eclipse Adoptium-11.0.17+8

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5402/4/testReport/

Max. process+thread count
5016 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5402/4/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 53s
Docker mode activated.

-0 :warning:
yetus
0m  6s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 43s
branch-2 passed

+1 :green_heart:
compile
1m  5s
branch-2 passed

+1 :green_heart:
shadedjars
5m 10s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 43s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 37s
the patch passed

+1 :green_heart:
compile
0m 58s
the patch passed

+1 :green_heart:
javac
0m 58s
the patch passed

+1 :green_heart:
shadedjars
5m 37s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 46s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
8m 11s
hbase-client in the patch passed.

+1 :green_heart:
unit
210m 15s
hbase-server in the patch passed.

243m 38s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5402/4/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5402

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 9da3e24f6bd3 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / e8cbc3faeb

Default Java
Temurin-1.8.0_352-b08

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5402/4/testReport/

Max. process+thread count
4686 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5402/4/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

I pushed a small addition for completeness. Will merge once the pre-commit comes back green.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 55s
Docker mode activated.

-0 :warning:
yetus
0m  5s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 18s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 45s
branch-2 passed

+1 :green_heart:
compile
1m  4s
branch-2 passed

+1 :green_heart:
shadedjars
5m 23s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 38s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 29s
the patch passed

+1 :green_heart:
compile
1m  5s
the patch passed

+1 :green_heart:
javac
1m  5s
the patch passed

+1 :green_heart:
shadedjars
5m 27s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 43s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
8m 18s
hbase-client in the patch passed.

+1 :green_heart:
unit
229m 24s
hbase-server in the patch passed.

263m 37s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5402/5/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5402

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 78166a7ec89f 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / ddb297bca6

Default Java
Temurin-1.8.0_352-b08

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5402/5/testReport/

Max. process+thread count
4603 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5402/5/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 42s
Docker mode activated.

-0 :warning:
yetus
0m  6s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 28s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 48s
branch-2 passed

+1 :green_heart:
compile
0m 59s
branch-2 passed

+1 :green_heart:
shadedjars
4m 53s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 37s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 32s
the patch passed

+1 :green_heart:
compile
1m  0s
the patch passed

+1 :green_heart:
javac
1m  0s
the patch passed

+1 :green_heart:
shadedjars
5m 34s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 51s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
8m 39s
hbase-client in the patch passed.

+1 :green_heart:
unit
268m 49s
hbase-server in the patch passed.

302m 59s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5402/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5402

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 494028ccb660 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / ddb297bca6

Default Java
Eclipse Adoptium-11.0.17+8

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5402/5/testReport/

Max. process+thread count
4759 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5402/5/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Spotless succeeded but failed with a process-related issue at the end. I checked it locally as well just in case. Tests are passing. Merging.


Complete Listener keeps firing

I was using the audio.complete(function() {});  and noticed that the handler will keep firing until new audio is loaded.. is that working as expected?
Thanks
Rob

you can use a bool value to check if it entered the first time. then reset it while playing the next audio

Personally, to solve this issue (and for many other reasons), I set the "currentTime", the "progress" etc. to 0 when the audio is complete.

PR for this would be good

@Graphfx how and where are you setting that?

My fix for the problem, call destroy function in callback function
.controller('my',function(ngAudio){
var sound =ngAudio.load("assets/voiceover-122308-asset.mp3");
sound.play();
sound.complete(function(audio){
audio.destroy();
console.log('done');
})
})

Complete event is firing multiple time at start of track and firing unlimited times at end of track.


move_topic_to_stream: Fix position of error message and change its color scheme in night theme

Fixes #20210
Testing plan: Manual
GIFs or screenshots:
Earlier :

Now:

Hey @timabbott , can you please review the changes.


conveRT dependency (tensorflow_text) not installed by default

Rasa version: 1.8.1
Python version: 3.7.4
Operating system (windows, osx, ...): MacOS Catalina 10.15.3
Issue: tensorflow_text package necessary for conveRT, but is not installed by default.
Error (including full traceback):
2020-04-28 15:37:39 WARNING  rasa.nlu.test  - Training model 'conveRT' failed. Error: Not all required importable packages are installed. To use this pipeline, you need to install the missing dependencies. Please install the package(s) that contain the module(s): tensorflow_text

Command or request that led to error:
rasa train

Content of configuration file (config.yml) (if relevant):
# Configuration for Rasa NLU.
# https://rasa.com/docs/rasa/nlu/components/
language: "en"

pipeline:
  - name: ConveRTTokenizer
  - name: ConveRTFeaturizer
  - name: RegexFeaturizer
  - name: LexicalSyntacticFeaturizer
  - name: CountVectorsFeaturizer
  - name: CountVectorsFeaturizer
    analyzer: "char_wb"
    min_ngram: 1
    max_ngram: 4
  - name: DIETClassifier
    epochs: 100
  - name: EntitySynonymMapper

# Configuration for Rasa Core.
# https://rasa.com/docs/rasa/core/policies/
policies:
  - name: MemoizationPolicy
  - name: TEDPolicy
    max_history: 5
    epochs: 100
  - name: FormPolicy
  - name: MappingPolicy
  - name: "FallbackPolicy"
    nlu_threshold: 0.5
    core_threshold: 0.5
    fallback_action_name: "action_default_fallback"

Thanks for raising this issue, @melindaloubser1 will get back to you about it soon✨
Please also check out the docs and the forum in case your issue was raised there too 🤗

This is the intended behaviour to keep Rasa as lightweight as possible, since not all pipelines require tensorflow _text. To install Rasa with the dependencies for ConveRT, you can do pip install "rasa[convert]" or to install all optional dependencies, pip install "rasa[full]"


protocol.md

hi，there,where to find the file named "protocol.md"?

Looks like this file is in another repository and was renamed to protocol.rst: https://github.com/odriverobotics/ODrive/blob/e89d71a7d70b6415a3bdcaacc6a90a1a21f26105/docs/protocol.rst


Yoroi not detected

Hello
What wallets are detected?
I have Yoroi and Yoroi Nightly installed, yet when I go to https://meshjs.dev/apis/browserwallet neither are detected.

@magick93 Talk to Cardano  Support on the Cardano Live Support so that your issue can be looked into.

Hi @Gns7077DEV - isnt the issue due to this PR not being merged - https://github.com/MeshJS/mesh/pull/48 ?

You should create chat with the support sent to you for more knowledge and procedures to solve the issue .

@jinglescode - please see above.

Hey @magick93, thanks for reporting. For Yorio, I am not detecting it either. But I would like you to do something and confirm with me.

open a browser tab, with that browse that has Yoroi installed
right click and inspect element
go to Console tab
type window.cardano
see what wallets are "found"

HI @jinglescode
This is what I get:

@jinglescode - is the problem that yoroi is missing from this list? https://github.com/MeshJS/mesh/blob/main/packages/module/src/common/constants.ts#L481-L483

@magick93. Your screenshot is good, this meansyoroi is on your device. And yes, we just have to add yoroi into SUPPORTED_WALLETS.

Thanks @jinglescode - I've added a PR - https://github.com/MeshJS/mesh/pull/105

Hi, @magick93 unfortunately Yoroi doesn't fully support the CIP-30 specs.
Adding yoroi to the array of supported wallets isn't enough 😅
we have to make changes to the BrowserWallet class too


Add a bunch more info to the cw-vesting README

Got overridden in a force push: https://github.com/DA0-DA0/dao-contracts/compare/1920dd74e90712ac235b8bb07e13786caf4b8f59..65e098695e68eb9597414651da0e33d044beffd2

Codecov Report
Base: 90.65% // Head: 90.65% // No change to project coverage :thumbsup:

Coverage data is based on head (99bf79a) compared to base (02dcf94).
Patch has no changes to coverable lines.

:exclamation: Current head 99bf79a differs from pull request most recent head 41fa085. Consider uploading reports for the commit 41fa085 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #631   +/-   ##
=======================================
  Coverage   90.65%   90.65%
=======================================
  Files          56       56
  Lines        4835     4835
=======================================
  Hits         4383     4383
  Misses        452      452

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


test: No warnings

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

[x] Make sure to open an issue as a bug/issue before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
[x] Ensure the tests and linter pass
[x] Code coverage does not decrease (if any source code was changed)
[x] Appropriate docs were updated (if necessary)

Fixes #2 🦕
This builds-on/includes #8, which builds-on/includes #7.

Note there are some commits to address comments made on https://github.com/googleapis/python-bigquery/pull/972 :)

Coverage failure to be addressed in https://github.com/googleapis/python-db-dtypes-pandas/pull/11

@googlebot I consent.


slight problem with delay_out

Hi guys, to get my unit tests running with your testbench generator, I had to make this small change to process_inputs.py ... basically adding null bytes to the end of the input file, not the beginning ... it looks like maybe there was a slight error in the processing of the delay_out parameter, which I think does not get used in standard testing, but which I need for e.g. linebuffer unit tests...please verify that this will not break anything for you, and approve the pull...thanks!
PS FYI here's a pointer to my travis test which uses this branch https://travis-ci.org/StanfordAHA/CGRAGenerator

p.s. I like the change from 0 -> b'\0' I think it makes it more clear (i.e. pythonic!).

@leonardt haha not my idea; whatever version of python I was using at the time (3.6.5) gave me a type-check error...apparently because file was opened with "wb" property...?
% python --version
Python 3.6.5 :: Anaconda, Inc.

% python process_input.py $v/io/s2in_s0out.io.json /tmp/tmp$$ /tmp/tmp$$2.raw
Traceback (most recent call last):
  File "process_input.py", line 9, in <module>
    delay_in, delay_out = [int(x) for x in sys.argv[3].split(",")]
  File "process_input.py", line 9, in <listcomp>
    delay_in, delay_out = [int(x) for x in sys.argv[3].split(",")]
ValueError: invalid literal for int() with base 10: '/tmp/tmp267722.raw'

can you clarify the meaning of the delay_out parameter?

When I'm testing a 9-deep line buffer, I give the harness an input file containing ten pixels 'range(0,10)' and expect to see the same ten pixels in the output file, except delayed by nine cycles.  But the simulation is going to stop when it exhausts the ten input pixels and I will only get one garbage-pixel out unless I can 1) make the simulation run for another nine cycles (thus the need for an extra nine NULL/garbage pixels at the end of the input file), and 2) drop the first nine garbage pixels coming out (which I guess happens in process_output...?)
Anyway, on my end I set delay=(0,9) (delay_in=0, delay_out=9) in hopes that this means a) start processing input pixels immediately (no delay on input) and b) drop the first 9 output pixels before writing output file and c) continue writing output for 9 cycles after (non-garbage/NULL) input has been exhausted.
Does this make sense?

Makes sense to me!


Targets in the build file but not in the yaml file. Added them. Let's…

… see

Coverage remained the same at 99.815% when pulling 1f71ece6e4c8fbed178bd764ac5d0285e7575ee0 on basvodde:master into f90fb28d20f8ebb02e39c9b201cf33a0b6409690 on cpputest:master.


Document update: Enabling Microsoft Teams Apps and sideloading

I guess the documentation here for Setup Tenant may be outdated. I had to go to the Microsoft Teams admin center to enable sideloading. This may be helpful to update for anyone new trying it out.
Thank you.

@rabwill - thanks for noticing. Feel free to suggest an update by creating a pull request.

Happy to take this up  ! Thank you

Added to Wiki with 2.14.0


Fix E2E health check url is not correct

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:

(or)
Pull Request Notice
Pull Request Notice
If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 41.24%.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev   #16227      +/-   ##
============================================
- Coverage     41.26%   41.24%   -0.02%
+ Complexity     5122     5120       -2
============================================
  Files          1397     1397
  Lines         44055    44055
  Branches       4666     4666
============================================
- Hits          18178    18172       -6
- Misses        24097    24102       +5
- Partials       1780     1781       +1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Training

What about the training size

hi @ucasyjz
Thank you for your interest. We have released our training scripts and configurations for both PowerPaint-v1 and PowerPaint-v2 here. Please check it for more details.


Running graphical interface

the README.md says :
Run CAMP FHIR using our new graphical user interface

How does one do that ?
G

Please, is there an answer to this yet @gkowalski?

Not that I've heard or figured out using the code. I've been more concerned with my other ticket that I can't even get this to compile :-(


Card not working, only picture shown

Checklist:

[X] I updated to the latest version available
[X] I cleared the cache of my browser

Release with the issue:
v 5.6.5
Last working release (if known):
none, newly installed today
Browser and Operating System:
Chrome 94.0.4606.61 (Official Build) (64-bit) (cohort: Stable) on Windows 10
Description of problem:
With the config below, I only get a nice picture of my scale, but no data.
Without the picture config, I only get a empty rectangle
  - type: custom:body-miscale-card
    entity: bodymiscale.martijn
    image: /local/pictures/miscale2.jpg
    model: true

The entity works fine:

Javascript errors shown in the web inspector (if applicable):
None as far as I can see. Only related thing I see in the inspector is this:

  - type: custom:body-miscale-card
    entity: bodymiscale.martijn
    image: /local/pictures/miscale2.jpg
    model: true

hello, add the following elements:
show_name: true
show_state: true
show_attributes: true
show_toolbar: true
show_body: true
show_states: true
show_buttons: true

Normally you should have a configuration card.

Great, that works.
I have my lovelace on full yaml mode, so I don't have configuration cards.


[opentelemetry] deployment to greenhouse is failing, because of opentelemetry vendor tests

Deployment of OpenTelemetry is failing, after we have added our own chart testing.
During deployment our tests are rolled out, but also the vendor own tests are executed, which are failing.

Should be fixed with https://github.com/cloudoperators/greenhouse-extensions/pull/428, thanks to @ibakshay


updating react and react-dom to 15.6.1

react-dom 15.4.2 seems to have disappeared from unpkg, so have upgraded external and local to 15.6.1
not sure if this is actually helpful but having got it all working on my dev environment with 15.6.1, figured I'd submit a PR

it's about now I guess I should probably work out how to run the tests...

Oh I see that the tests have v15.4.2 hardcoded... I guess that's the likely culprit

Thanks @ned2 ! It seems like this issue was temporary from unpkg: https://github.com/unpkg/unpkg-website/issues/54 and that it is resolved. I don't think that changing the version will help us in the future here.
I've seen 2 issues since launch with Unpkg so I might consider loading these resources from a different CDN.


Exchange numerator and denominator names in Rational.new arguments

The rational-numbers exercise has the test
fn test_add_two_positive_rational_numbers() {
	r1 := Rational.new(1, 2)
	r2 := Rational.new(2, 3)

	assert r1.add(r2) == Rational.new(7, 6)
}

This is clearly saying that one half plus two thirds is seven sixths. All good.
In Rational.new we should call the first argument the numerator and we should call the second argument the denominator.
Line 7 of rational_numbers.v currently shows the two argument names with the wrong ordering. We should fix line 7.
All 4 of the current community solutions { autf, david82, metalim, keiraville } show the correct ordering: numerator, denominator
In the example solution file example.v, we could replace numerator with denominator and replace denominator with numerator.

Yep! I didn't catch that, thank you! Once someone makes a PR for this, it'll be an easy approve


[WIP] Rollup config, and jest integration tests against builds

This needs a check-in / review.

Changes the rollup config to build for ems, cjs, and umd. package.json module will point at the ems, and main will point at index, which redirects to cjs.

Jest will run the integration tests against each of the bundles. These tests will fail, because they're importing files from lib. We can change these to use all public API. Probably should not enable these tests right now.

made me lol


Fix bug - dropdown data.id mapping to element value and failing

SUMMARY:
data.value now maps to element value instead of to element id, and data.id maps to element id.
BUG:
When creating a dropdown on a , there are no ids assigned to the item elements. The value data parameter gets silently dropped, as s don't have a value param, unlike perhaps  elements. This means that there is no way to know which element is selected by the user, other than using the data.name field, which is not a good design.
PROPOSAL:
I propose to add an id param to the item elements, while also maintaining the value param to maintain backwards compatibility.
Good design patterns suggest that all select-able elements on the client must maintain ids that map to those in the database. Mapping can occur either directly or indirectly, on the client or on the server.

I have not checked yet, you would need to be a legacy system in mind, otherwise, it would break lot of users relying in the updates of the master.

I have not checked yet, you would need to be a legacy system in mind, otherwise, it would break lot of users relying in the updates of the master.

Yes. It will break apps that rely on the value field, if its a select element.
One thing to keep in mind is that most users may be happy with the change, and it probably won't be a big headache for them to fix.


Provide option for Log Message to be before Changed Paths.

I thought I had already issues a pull request, but apparently not.  So much for waiting patiently...
The purpose of this change is that often the log message is more interesting than the list of change files.  When there are a lot of changed files, its a pain to scroll down to the log message.  I'd like the option of putting the log message at the top.
Now I wasn't sure how to go about testing this change.

Hey @bencoman! We're going to be evaluating the email service on the whole internally since there are a lot of competing ideas on how to get these suggestions in. I'm going to close this PR for now. Thanks!


Trim() is not releasing all unused bytes

The RoaringArray's keys and values arrays are extended with some extra space according to code.
The space is not recovered after RoaringBitmap.trim() call. This could cause huge heap usage while building millions of bitmaps.
The unit tests shows how to easily waste 5292 bytes per one bitmap.

+1

Will be part of next release.


the default values of VSECM_MINIKUBE_CPU_COUNT and VSECM_MEMORY on minikube-start.sh are too high

Make sure those values work work a laptop with 2 cpu cores and 2-4gigs of memory, by default.

Could you assign to me @v0lkan ?

@sahinakyol it’s yours; have fun.

@v0lkan  Apparently, those values has implemented before;
https://github.com/vmware-tanzu/secrets-manager/blob/3e808223bbaf196c5ca8a33cec7a97d509747ff9/hack/minikube-start.sh#L14
https://github.com/vmware-tanzu/secrets-manager/blob/3e808223bbaf196c5ca8a33cec7a97d509747ff9/hack/minikube-start.sh#L15
Improvement idea;
minikube-start.sh
#!/usr/bin/env bash

# /*
# |    Protect your secrets, protect your sensitive data.
# :    Explore VMware Secrets Manager docs at https://vsecm.com/
# </
# <>/  keep your secrets… secret
# >/
# <>/' Copyright 2023–present VMware, Inc.
# >/'  SPDX-License-Identifier: BSD-2-Clause
# */

# Minikube might need additional flags for SPIRE to work properly.
# A bare-metal or cloud Kubernetes cluster will not need these extra configs.
minikube start \
    --extra-config=apiserver.service-account-signing-key-file=/var/lib/minikube/certs/sa.key \
    --extra-config=apiserver.service-account-key-file=/var/lib/minikube/certs/sa.pub \
    --extra-config=apiserver.service-account-issuer=api \
    --extra-config=apiserver.api-audiences=api,spire-server \
    --extra-config=apiserver.authorization-mode=Node,RBAC \
    --memory="$MEMORY" \
    --cpus="$CPU" \
    --insecure-registry "<IP_ADDRESS>/24"

echo "waiting 10 secs before enabling registry"
sleep 10
minikube addons enable registry
kubectl get node

VSecMDeploy.mk
CPU ?= 2
MEMORY ?= 4096

# Removes the former VSecM deployment without entirely destroying the cluster.
clean:
	./hack/uninstall.sh

# Completely removes the Minikube cluster.
k8s-delete:
	./hack/minikube-delete.sh
# Brings up a fresh Minikube cluster.
k8s-start:
	@CPU=$(CPU) MEMORY=$(MEMORY) ./hack/minikube-start.sh

We can directly close this issue or I can create pull request with the proposed improvement.

I liked the improvement idea.
Maybe we can even let the env vars configure it:
CPU ?= $(or $(VSECM_MINIKUBE_CPU_COUNT),2)
MEMORY ?= $(or $(VSECM_MINIKUBE_MEMORY),4096)

@sahinakyol, you can add the change, test it, and if everything looks fine, we can merge.
Thanks a lot.

Closing.


GROUP BY GROUPING SETS support

We used "GROUPING SETS" and parser gives error for this.
Additionally, GROUP BY ROLLUP and GROUP BY CUBE may be supported with this, their syntax is similar.
A DB2 SQL sample using "GROUPING SETS":
SELECT WEEK(SALES_DATE) AS WEEK,
DAYOFWEEK(SALES_DATE) AS DAY_WEEK,
SALES_PERSON, SUM(SALES) AS UNITS_SOLD
FROM SALES
WHERE WEEK(SALES_DATE) = 13
GROUP BY GROUPING SETS ( (WEEK(SALES_DATE), SALES_PERSON),
(DAYOFWEEK(SALES_DATE), SALES_PERSON))
ORDER BY WEEK, DAY_WEEK, SALES_PERSON
http://pic.dhe.ibm.com/infocenter/db2luw/v10r1/index.jsp?topic=%2Fcom.ibm.db2.luw.sql.ref.doc%2Fdoc%2Fr0059215.html
It is also supported by SQL Server and Oracle:
http://blogs.msdn.com/b/craigfr/archive/2007/10/11/grouping-sets-in-sql-server-2008.aspx
http://www.oracle-base.com/articles/misc/rollup-cube-grouping-functions-and-grouping-sets.php

We just ran into this issue in DB2.  Any chance that this would be added in 2.0?
Thanks!

Some sample SQL statements:
SELECT COL_1, COL_2, COL_3, COL_4, COL_5, COL_6 FROM TABLE_1 GROUP  BY GROUPING SETS((COL_1, COL_2, COL_3, COL_4), (COL_5, COL_6))) (basic example)
SELECT COL_1,  	COL_2,  	COL_3,  	EXTRACT(YEAR FROM my_function(COL_3)) AS Extracted_Year,  	QUARTER(my_function(COL_3)) AS Extracted_Quarter,  	EXTRACT(MONTH FROM my_function(COL_3)) AS Extracted_Month FROM TABLE_1 WHERE 	EXTRACT(YEAR FROM my_function(COL_3)) > EXTRACT(YEAR FROM CAST(COL_4 AS DATE)) - 3 	AND EXTRACT(MONTH FROM my_function(COL_3)) <= EXTRACT(MONTH FROM CAST(COL_4 AS DATE)) GROUP BY 	GROUPING SETS( 		(COL_1, COL_2, COL_3, EXTRACT(YEAR FROM my_function(COL_3)), EXTRACT(MONTH FROM my_function(COL_3))), 		(COL_1, COL_2, COL_3, EXTRACT(YEAR FROM my_function(COL_3)), QUARTER(my_function(COL_3))), 		(COL_1, COL_2, COL_3, EXTRACT(YEAR FROM my_function(COL_3))), 		(COL_1, CASE WHEN COL_2 = '1234' THEN 'FOO' ELSE 'BAR' END) 	)  (more complex sample; includes statements such as function, case, etc in the grouping set)
I don't have any examples of GROUP BY ROLLUP / GROUP BY CUBE in my report library, unfortunately.

Is it right, that grouping sets are any list of expressions including an empty expression?

According to https://docs.oracle.com/cd/E49933_01/server.770/es_eql/src/reql_aggregation_grouping_sets.html :

The GROUPING SETS syntax is:
GROUPING SETS(groupingSetList)
where groupingSetList is a single attribute, a comma-separated list of multiple attributes, CUBE, ROLLUP, or () to specify an empty group. The empty group generates a total. Note that nested grouping sets are not allowed.
For example:
GROUP BY GROUPING SETS(a, (b), (c, d), ())

From that, I would say that the empty expression is allowed.
Even if some DBs do not accept it, I feel that it should still parse correctly.


Report a problem is not available

If "Visual Studio interface" cannot be opened, how do you "Report new problem"?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2386e67e-a67b-de55-db57-e29a83dcb410
Version Independent ID: 6247fba9-4255-9a59-c206-0e8547e12335
Content: How to report a problem with Visual Studio
Content Source: docs/ide/how-to-report-a-problem-with-visual-studio.md
Product: visual-studio-windows
GitHub Login: @TerryGLee
Microsoft Alias: tglee

Thank you for presenting this scenario to us! This is something that we are aware of and trying to find a way to mitigate, while still keeping the actionability of reports that we get with the Feedback Tool.
As a workaround, you can also report a problem from the Visual Studio Installer.
Please also see https://developercommunity.visualstudio.com/idea/398744/problems-cannot-be-reported-when-the-ide-doesnt-wo.html
As a side note, please log suggestions and problems about the product through Developer Community or the Feedback Tool. This is a medium that is used for problems about docs, and it's harder to track and make the connection.
Maria Ghiondea
Visual Studio Feedback System

Closing as a dupe of #2887 .


Problem about training

I tried to train the segmentation model, but I met a problem:
Traceback (most recent call last):
  File "tools/train.py", line 87, in <module>
    main()
  File "tools/train.py", line 76, in main
    train_model(
  File "/media/bit202/文件&程序等/Yingqun.Liu/bevfusion/mmdet3d/apis/train.py", line 49, in train_model
    model.cuda(),
  File "/home/bit202/anaconda3/envs/bevf/lib/python3.8/site-packages/torch/nn/modules/module.py", line 680, in cuda
    return self._apply(lambda t: t.cuda(device))
  File "/home/bit202/anaconda3/envs/bevf/lib/python3.8/site-packages/torch/nn/modules/module.py", line 570, in _apply
    module._apply(fn)
  File "/home/bit202/anaconda3/envs/bevf/lib/python3.8/site-packages/torch/nn/modules/module.py", line 570, in _apply
    module._apply(fn)
  File "/home/bit202/anaconda3/envs/bevf/lib/python3.8/site-packages/torch/nn/modules/module.py", line 570, in _apply
    module._apply(fn)
  [Previous line repeated 2 more times]
  File "/home/bit202/anaconda3/envs/bevf/lib/python3.8/site-packages/torch/nn/modules/module.py", line 593, in _apply
    param_applied = fn(param)
  File "/home/bit202/anaconda3/envs/bevf/lib/python3.8/site-packages/torch/nn/modules/module.py", line 680, in <lambda>
    return self._apply(lambda t: t.cuda(device))
RuntimeError: CUDA error: out of memory
CUDA kernel errors might be asynchronously reported at some other API call,so the stacktrace below might be incorrect.
For debugging consider passing CUDA_LAUNCH_BLOCKING=1.
--------------------------------------------------------------------------
Primary job  terminated normally, but 1 process returned
a non-zero exit code. Per user-direction, the job has been aborted.
--------------------------------------------------------------------------
--------------------------------------------------------------------------
mpirun detected that one or more processes exited with non-zero status, thus causing
the job to be terminated. The first process to do so was:

  Process name: [[39800,1],0]
  Exit code:    1
--------------------------------------------------------------------------

I really want to know how to solve it. I used two 3090 to train, and I have changed two files into:
extra_compile_args["nvcc"] = extra_args + [
            "-D__CUDA_NO_HALF_OPERATORS__",
            "-D__CUDA_NO_HALF_CONVERSIONS__",
            "-D__CUDA_NO_HALF2_OPERATORS__",
            # "-gencode=arch=compute_70,code=sm_70",
            # "-gencode=arch=compute_75,code=sm_75",
            # "-gencode=arch=compute_80,code=sm_80",
            "-gencode=arch=compute_86,code=sm_86",
        ]
        sources += sources_cuda

and
samples_per_gpu: 2
  workers_per_gpu: 2

Could someone help me? Thank you.

If you are training the fusion model, 24G memory on 3090 is not enough. We train on 48G A6000s. A new version of this codebase (in which we will replace the spconv backend) should be able to support batch_size=2 under 24G memory. Please stay tuned.

Thank you for your reply!  I'm looking forward to the new version of this codebase.
------------------ 原始邮件 ------------------
发件人:                                                                                "mit-han-lab/bevfusion"                                                                                @.>;
发送时间: 2023年2月10日(星期五) 凌晨0:12
@.>;
<EMAIL_ADDRESS>主题: Re: [mit-han-lab/bevfusion] Problem about training (Issue #299)
If you are training the fusion model, 24G memory on 3090 is not enough. We train on 48G A6000s. A new version of this codebase (in which we will replace the spconv backend) should be able to support batch_size=2 under 24G memory. Please stay tuned.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>

Closed due to inactivity. Please feel free to reopen if you feel it necessary.

If you are training the fusion model, 24G memory on 3090 is not enough. We train on 48G A6000s. A new version of this codebase (in which we will replace the spconv backend) should be able to support batch_size=2 under 24G memory. Please stay tuned.

Thank you for your work! I'm wondering if torch.cuda.amp can help to save memory and maintain the results of the training


Fix compile issue in ARM X64 and with Ninja

What type of PR is this：

[x] bug
[ ] feature
[ ] enhancement
[ ] refactor
[ ] others

Which issues of this PR fixes ：

Fixes #
Problem Summary(Required) ：

Fix compile issue in ARM X64 and with Ninja. It has been verified in my local environment:
Linux ubuntu-linux-20-04-desktop 5.13.0-44-generic #49~20.04.1-Ubuntu SMP Wed May 18 16:03:17 UTC 2022 aarch64 aarch64 aarch64 GNU/Linux

Is it necessary add -G "${CMAKE_GENERATOR}" ? CMake can detect enviroment CMAKE_GENERATOR

Is it necessary add -G "${CMAKE_GENERATOR}" ? CMake can detect enviroment CMAKE_GENERATOR

I think the special settings seem to be clearer and simpler?


Filter chip: Jumping on selection

Description
As the filter chip is currently implemented it will change size on selection/de-selection.
This can cause content to move and change the layout in unintended ways.
Suggestion is to only move the content inside the filter chip. To not affect the space around it.
Who will benefit from this feature?
No response
Anything else?
Moving content :

Not moving content :

@astrit Could you have a look at this one when you have a moment?

Hi @Fredrik-Oberg ,
I will check this and sync with the design as well as on the second example the text is moving to create the space, perhaps we could do something like that. Will let you know asap.
✌


Update QuestPDF to net6.0 and 2022.4.1

net3.1 -> 6.0
QuestPDF 2022.3.0 -> 2022.4.1

Thank you for this improvement!
P.S. I am very sorry for the delayed reply. A lot is going on in my personal life: highly positive yet time-consuming events. I hope that you understand 😁


capturePage doesn't work

Error:
{ Error: javascript error:
    at executeAsync(<Function>, , "require") - C:\Git\ArchitectTests\node_modules\spectron\lib\api.js:311:17
  message: 'javascript error:',
  type: 'RuntimeError',
  seleniumStack:
   { status: 17,
     type: 'JavaScriptError',
     message: 'An error occurred while executing user supplied JavaScript.',
     orgStatusMessage: 'javascript error: \n  (Session info: content shell=)\n  (Driver info: chromedriver=2.25 (e0da1e9caa7c8 f3da3519963a9ea32abba43c7c8),platform=Windows NT 6.3.9600 x86_64)' } }

Spectron: 3.6.0
Electron: <IP_ADDRESS>
Code to run:
var fs =require('fs-extra');
var Application = require('spectron').Application;

var app = new Application({
    path: config.pathToSA,
    args: constants.SAArgs
});

app.start().then(() => {
    app.client.getWindowCount().then((value) => {
        if (value > 1) {
            // Switch to main window from dev window
            return app.client.windowByIndex(1);
        } else {
            return true;
        }
    }).then(() => {
        app.browserWindow.capturePage().then(function (imageBuffer) {
            fs.writeFile('page.png', imageBuffer)
        }).catch((err) => {
            console.log(err);
        })
    });
});

At first I thought that it's caused by not enabled https://github.com/electron/spectron#node-integration but there is if

if your Electron application has nodeIntegration set to false

And the nodeIntegration is set to true by default. So I assume there is no action needed. Tested on both Linux and Windows.
Is there a bug or is something wrong with my set-up? Thank you

+1

I managed to save the screenshot by calling the Electron functions directly in the App and using the App to save the screenshot for me.
var path = 'C:/Users/Petr/Documents/test.png';
return app.client.execute((path)=>{
    var cw = xx.remote.getCurrentWindow();
    cw.capturePage(function(image){
        xx.fs.writeFile(path, image.toPng())
    })
}, path);

I still don't know why it doesn't work from Spectron API


Touches pass through overlay Views in Android, but not iOS

Description
There is a discrepancy between event propagation in iOS and Android.
On Android: You can have have two "overlay" views that span the whole view, containing some control elements. All control elements are tappable, as long as they don't overlap.
On iOS: The same configuration results in the top view acting like a glass that prevents any interaction with the elements on the bottom view.
In other words, transparent Views do propagate touch events to underlying Views in Android, but not in iOS.
I personally prefer Android's behavior.
Reproduction
https://snack.expo.io/SkBZGASx-
On Android: You can tap on both the green and red box.
On iOS: You can only tap on the green box.
Solution
Add pointerEvents='box-none' to overlay Views.
https://snack.expo.io/BkVomRrlb
Additional Information

React Native version: 0.44
Platform: both iOS and Android
Operating System: N/A

Updated the reproduction link.
Also, added my workaround in "Solution" section.

It sounds like we should try to make these both behave the same, and look to the web for the correct default. PR welcome for this, it will be a breaking change for whichever platform changes.

Any updates on this?

I am having exactly the same issue. Please do take a look at the problem. Thank you very much!

Any news on this matter?

I still experience the same issue with 0.59, the touch event is still being propagated to lower layer views when in Android.

Using RN 0.56 and this also happens (only in iOS, which is irksome).
Workaround seems to work but is a pain as i have to use it on every level of nested view.

Still an issue on 0.61.2. @brentvatne Could we please get this one reopened?

I am finding the pointerEvents solution isn't working in my case. I'm placing an absolutely positioned overlay on top of a React Navigation modal. Per the docs it seems this is actually the correct behavior, as it says box-none only has an impact on subviews. No mention that it would or should affect views with a lower z-index (views appearing behind an absolutely positioned overlay).

'box-none': The View is never the target of touch events but its subviews can be.

However adding a low zIndex won't help since the overlay needs to be on top.

I found this issue as well, any solutions?


Remove references to torchtext.legacy from PyTorch Lightning

What does this PR do?
This PR resolves #10597 by deprecating references to torchtext.legacy from Lightning. As discussed in the issue, we add version checks for now to load the torchtext legacy components. In future, this code should be completely removed.
Fixes #10597
Does your PR introduce any breaking changes? If yes, please list them.
No

Before submitting

[x] Was this discussed/approved via a GitHub issue? (not for typos and docs)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together?
[ ] Did you make sure to update the documentation with your changes? (if necessary)
[ ] Did you write any new necessary tests? (not for typos and docs)
[x] Did you verify new and existing tests pass locally with your changes?
[x] Did you list all the breaking changes introduced by this pull request?
[ ] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

[ ] Is this pull request ready for review? (if not, please submit in draft mode)
[x] Check that all items from Before submitting are resolved
[ ] Make sure the title is self-explanatory and the description concisely explains the PR
[ ] Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?
Make sure you had fun coding 🙃

@carmocca @awaelchli As suggested by you folks, I changed to rank_zero_deprecation from rank_zero_warn. It seems like the unit tests fail when they encounter the depreciation warning. What is your guidance to fix that?

It seems like the unit tests fail when they encounter the depreciation warning. What is your guidance to fix that?

This was because some tests emitted the deprecation warning. In our test suite, we require each deprecation warning to be caught explicitly. I added these missing calls and will check back once test run completes here.

Seems like all tests passed. @Borda @awaelchli @carmocca @ananthsub Could any of you with write access merge these changes?

Yep, I can confirm everything is fine with this PR. We are currently investigating issues with our CI hanging tests which impacts this PR as well but is unrelated. Apologies and thanks for the patience. I will come back to the PR and rerun tests

Hi @awaelchli ,
Thanks for the quick fix, may I know which version will contain this fix?
We are blocked by this issue in MONAI:
https://github.com/Project-MONAI/tutorials/issues/530
Thanks in advance.

Hi @abhinavarora ,
Currently, I fixed the PyTorch version to 1.10.2 as a workaround in the tutorial and didn't see the issue anymore.
Will update it when you guys released a new version.
Thanks.


Package maps not in GOROOT

Hello,
When running the code listed in the README, I get the following errors;
../../../go/pkg/mod/github.com/bom-squad/protobom@v0.3.0/pkg/sbom/externalreference.go:5:2: package maps is not in GOROOT (/usr/lib/go-1.19/src/maps)
../../../go/pkg/mod/github.com/bom-squad/protobom@v0.3.0/pkg/sbom/diff.go:4:2: package slices is not in GOROOT (/usr/lib/go-1.19/src/slices)

My version of go is go1.19.8 linux/amd64 - do I need a newer go?

Upgraded to go1.22.3 and that solved the issue.

Correct! protobom needs go 1.22 (perhaps we should note that somewhere in the docs :) )
https://github.com/protobom/protobom/blob/8e47a21ca3e44629f5938219e0de5b72c342b9d3/go.mod#L1-L4


Event entity is not created

Description
Event entity is not created
Reproduction Steps
Setup according to default install procedure with C325WB.
Event integration using Webhook / long-polling: doesn't matter - the same result.
Expected behavior
Event entity should be automatically created when motion is detected for the first time (as per README)
If applicable, add error logs.
2024-09-16 12:02:32.201 DEBUG (MainThread) [custom_components.tapo_control] [initOnvifEvents] Creating onvif connection...
2024-09-16 12:02:32.252 DEBUG (MainThread) [custom_components.tapo_control] [initOnvifEvents] Connection estabilished.
2024-09-16 12:02:32.253 DEBUG (MainThread) [custom_components.tapo_control] [initOnvifEvents] Getting device information...
2024-09-16 12:02:32.274 DEBUG (MainThread) [custom_components.tapo_control] [initOnvifEvents] Got device information.
2024-09-16 12:02:32.274 DEBUG (MainThread) [custom_components.tapo_control] setupOnvif - entry
2024-09-16 12:02:32.274 DEBUG (MainThread) [custom_components.tapo_control] Setting up onvif...
2024-09-16 12:02:32.274 DEBUG (MainThread) [custom_components.tapo_control] setupEvents - entry
2024-09-16 12:02:32.275 DEBUG (MainThread) [custom_components.tapo_control] Detected base_url schema: http
2024-09-16 12:02:32.275 DEBUG (MainThread) [custom_components.tapo_control] Detected base_url schema: http
2024-09-16 12:02:32.276 DEBUG (MainThread) [custom_components.tapo_control] Using HTTPS: False
2024-09-16 12:02:32.276 DEBUG (MainThread) [custom_components.tapo_control] Webhook enabled: True
2024-09-16 12:02:32.276 DEBUG (MainThread) [custom_components.tapo_control] Using Webhooks: True
2024-09-16 12:02:32.276 DEBUG (MainThread) [custom_components.tapo_control] Setting up events...
2024-09-16 12:02:32.276 DEBUG (MainThread) [custom_components.tapo_control] WSPullPointSupport: True
...
2024-09-16 12:02:36.893 DEBUG (MainThread) [custom_components.tapo_control] Creating binary sensor entity.
2024-09-16 12:02:36.897 ERROR (MainThread) [homeassistant] Error doing job: Task exception was never retrieved (None)
Traceback (most recent call last):
  File "/config/custom_components/tapo_control/utils.py", line 1374, in update_listener
    await setupOnvif(hass, entry)
  File "/config/custom_components/tapo_control/utils.py", line 1431, in setupOnvif
    hass.data[DOMAIN][entry.entry_id]["eventsSetup"] = await setupEvents(
                                                       ^^^^^^^^^^^^^^^^^^
  File "/config/custom_components/tapo_control/utils.py", line 1467, in setupEvents
    ].createBinarySensor()
      ^^^^^^^^^^^^^^^^^^^^
  File "/config/custom_components/tapo_control/binary_sensor.py", line 188, in createBinarySensor
    for event in events.get_platform("binary_sensor")
                 ^^^^^^^^^^^^^^^^^^^
AttributeError: 'bool' object has no attribute 'get_platform'

Device Firmware
1.1.17 build 240529 rel.57938n
Integration Version
5.6.1
Using stream component
Yes
Does camera work via official integrations?
Yes
Camera has all attributes filled out in developer tools
Yes
HASS Environment
Home Assistant Green
Search for similar issues
Yes
Additional information
Cam IP: <IP_ADDRESS>, Home Assistant IP: <IP_ADDRESS>, local HTTP without TLS, on the same subnet

Only the official Tapo app + Home Assistant. In Home Assistant, there are two integrations interacting with the camera: WebRTC and this integrations. The WebRTC integration is set up using tapo:// protocol (docs).

I think this might be cause by the webrtc integration. I do not believe it is needed as long as you do not need 2 way talk, you can simply use a card something like this:
type: custom:webrtc-camera
intersection: 1
entity: camera.living_room_sd
background: true
digital_ptz:
  persist: false
ptz:
  service: button.press
  data_left:
    entity_id: button.living_room_move_left
  data_right:
    entity_id: button.living_room_move_right
  data_up:
    entity_id: button.living_room_move_up
  data_down:
    entity_id: button.living_room_move_down
shortcuts:
  - name: Privacy Mode
    icon: mdi:eye-outline
    service: switch.toggle
    service_data:
      entity_id: switch.living_room_privacy
  - name: Home
    icon: mdi:home
    service: script.set_living_room_camera_home
  - name: Home
    icon: mdi:palm-tree
    service: script.set_living_room_camera_away
style: >-
  .shortcuts {left: unset; top: 30px; left: 5px; display: flex; flex-direction:
  column; gap: 12px;}

Closing due to inactivity.


[9.x] Load relationships using LazyCollection

Hello everyone,
This will be my first contribution to the Laravel Framework.
This PR adds the ability to enable loading a relation using LazyCollection, why?
Motivation
I'm working on a project that has a lot of data, our database has data since 1970.
On the table where we are fetching the main info has almost 300k records, over that we can load using the standard lazy() method of the model, but when we add the lazy loading of relations through with(...) we were facing memory issues, because we are loading relations up to 3 levels depth. For example, the first relation has between 130 and 150 records per parent, below that we have the second relation that has 25-50 records.
On some processes that runs once per month, we process a bit chunk of data from the database for reporting and other stuff. We tried to optimize the loading times using LazyCollection on the referenced relations. We see that loading a big resultset of data takes more time than loading in chunks (it's not much, but the CPU is happy that can wait waiting for next chunk 😄). Also as mentioned, we were getting memory.
Examples
Instead of changing the core functionality of Relation, I added a modifier to enable lazy on a single relation on demand:
// get all Lands that where sold in the last month
$lands = SoldLand::with([
    // load all installments that were pay
    'installments' => fn($installment) => $installment->isPay()->with([
        // load payments of installments (load relation using LazyCollection)
        'payments' => fn($payment) => $payment->asLazy(),
    ]),
])->soldInLastMonth()->lazy();

Breaking changes
This PR will break libraries that extends functionality over Illuminate/Database.

Sorry about the force push, I had a wrong GPG key configured

Thanks for your pull request to Laravel!
Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.
If possible, please consider releasing your code as a package so that the community can still take advantage of your contributions!
If you feel absolutely certain that this code corrects a bug in the framework, please "@" mention me in a follow-up comment with further explanation so that GitHub will send me a notification of your response.


Twitch Chat Replay, only first 30 seconds get downloaded

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2<IP_ADDRESS>. If it's not read this FAQ entry and update. Issues with outdated version will be rejected.

[x] I've verified and I assure that I'm running youtube-dl 2<IP_ADDRESS>

Before submitting an issue make sure you have:

[x] At least skimmed through README and most notably FAQ and BUGS sections
[x] Searched the bugtracker for similar issues including closed ones

What is the purpose of your issue?

[x] Bug report (encountered problems with youtube-dl)

If the purpose of this issue is a bug report, site support request or you are not completely sure provide the full verbose output as follows:
$ youtube-dl -v --skip-download --write-sub https://www.twitch.tv/videos/124677335
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['-v', '--skip-download', '--write-sub', 'https://www.twitch.tv/videos/124677335']
[debug] Encodings: locale cp1252, fs mbcs, out cp850, pref cp1252
[debug] youtube-dl version 2<IP_ADDRESS>
[debug] Python version 3.4.4 - Windows-7-6.1.7601-SP1
[debug] exe versions: ffmpeg 3.2, ffprobe 3.2
[debug] Proxy map: {}
[twitch:vod] 124677335: Downloading vod info JSON
[twitch:vod] 124677335: Downloading vod access token
[twitch:vod] 124677335: Downloading m3u8 information
[info] Writing video subtitles to: LoL - H2k-Gaming vs. Hong Kong Esports - Group A Decider Game 3 - IEM Katowice 2017 [2_2]-v124677335.rechat.json
<end of log>

Description of your issue, suggested solution and other information
Only the first messages are being saved to file. According to this forum post at discuss.dev.twitch.tv the API only sends out a 30 second window after the requested timestamp.
So hundreds requests must be made, also there has to be a time delay or users might get banned from Twitch, AFAIK.
There's a python script that sucessfully downloads an entire chat replay in human readable plain text omitting the uninteresting JSON details. The developer commented in his code that he has to account for duplicate lines which will be sent when requesting the 30 second snippets, just FYI.

This is a bit out of date as apparently the host rechat.twitch.tv being used is no longer valid since at least October 2017. The API has changed completely.
https://github.com/PetterKraabol/Twitch-Chat-Downloader/issues/23#issuecomment-334568102

So seems currently youtube-dl can't download chat for Twitch :cry:
I'm getting
[info] Writing video subtitles to: v377500213.rechat.js
WARNING: Unable to download subtitle for "rechat": Unable to download webpage: <urlopen error [Errno -2] Name or service not known> (caused by URLError(gaierror(-2, 'Name or service not known'),))

For the time being, use Twitch Chat Downloader by Petter Kraabøl: https://github.com/PetterKraabol/Twitch-Chat-Downloader
It's an extra step but it's pretty advanced and does the job.


Enable automerge

@conda-forge-admin, please add bot automerge

Hi! This is the friendly automated conda-forge-webservice.
I just wanted to let you know that I added bot automerge in conda-forge/pyinaturalist-feedstock#2.


[Bug] CSS import fails parsing in some cases

Describe the bug
CSS imports in a project using vite/webpack fails to get parsed by extension
To Reproduce
@import 'modern-normalize/modern-normalize.css';

:root {
  --foo: red;
}

The above CSS will fail to get parsed.
Expected behavior
Either make this functional or gracefully ignore such imports, as such imports
can be defined in Extension settings as well.

Also fails with something like this
@custom-selector :--root :root, :after, :before;

@layer variables {
  @layer colors {
    :--root {
      --something: rgba(17, 17, 17, 1);
    }
  }

This is fixed in v2.6.0.
@TommySorensen I couldn't replicate your issue on my system. I tried testing this in this example: https://github.com/willofindie/vscode-cssvar/blob/main/examples/basics/theme.css#L24, but it was working fine for me.
Can u try to replicate this into a small repro, and open a new issue, if it's still not fixed? Thanks


feat: Commit Bundle Object

Description & motivation
A PR to build off of #1785
The idea of the Bundle object is to replicate the Commit Overlay  feature used in the web viewer as a Base type object for designers + devs to utilize within their commits. The bundle object is similar to the Model or Container  but instead of grouping all the objects it holds a list of references that point to a stream and a reference object.
A couple of use cases that sparked this idea:

Custom tools / apps that are built on top of Speckle rely heavily on the standard Object converter but need to link different model objects together in order to compose a specialized model scenario. This would allow for developers to rely on a standard Speckle object rather than standing up their own kit and converter for grouping together sets of different objects.
Designers tend to utilize Branches as a way to separate different focuses of modeling work, but there is a bump in the process when they try to layer in all the necessary commits or objects they need to visualize the model (sometimes I've seen this info written down on slack messages or gh panels 😱 ). The bundle could act as a simple object for designers to rely on when passing around settings for model compositions.

Changes:

Bundle object added to Objects
BundleItem object added to Core
ProgressReport supports collecting bundle data with BundleReferenceArgs
This logic would mainly impact the receive calls. I implemented a basic version of this in the ReceiveSyncComponent in GH, which shows that this would be a pretty big change for conversion logic across all connectors.

To-do before merge:

[ ] Connectors would need to check the ProgressReport and converters would need to be adapted to support the new object type.
[ ] Review if this object should sit in the Objects.Organization namespace

Screenshots:

Validation of changes:
Here is a tested prototype, working in C# and the GH connector
Checklist:

[x] My pull request follows the guidelines in the Contributing guide?
[x] My pull request does not duplicate any other open Pull Requests for the same update/change?
[x] My commits are related to the pull request and do not amend unrelated code or documentation.
[x] My code follows a similar style to existing code.
[x] I have added appropriate tests.
[ ] I have updated or added relevant documentation.

Hey @haitheredavid, thanks for the PR!
We've just returned from our retreat (some people are still traveling actually), but we'll get to this asap :)
In the meantime, if you could please remove any whitespace changes and fix indentation where needed (we use just 2 spaces), it'll make review easier.
Cc @clairekuang as she was involved with the organization classes

Hey @haitheredavid! Just bumping this up since we never heard back from you ;) Let's find a spot to have a quick video-call about this ;)

@tecomi all cleaned up now :) No longer passing commits with Hide white space now
@AlanRynne I'm down to chat! sometime next week?

I'm closing this for now @haitheredavid. Hopefully the alternatives using the reference object worked for you!
If the ref object didn't do the trick for you, feel free to continue this discussion on the issue you opened, which will remain open for now ;)


Go: don't use the sync/atomic package unless absolutely necessary

It turns out there's an alignment "bug" that triggers when you use sync/atomic on structures that aren't aligned according to the platform rules.
https://golang.org/pkg/sync/atomic/#pkg-note-BUG
https://github.com/golang/go/issues/599
This causes subtle cross-platform bugs, and is not worth the complexity for non-critical paths.

There is now a vet pass called atomicalign that should detect those issues. We should use that.
(see https://github.com/golang/go/issues/11891#issuecomment-455085965)
(see https://godoc.org/golang.org/x/tools/go/analysis/passes/atomicalign)

@lukedirtwalker : In that case we'd want to have automated testing on at least arm, otherwise we won't know when it breaks.

Oh, even worse - bazel doesn't support arm as a host platform, so we can't actually build on an arm vm => can't do automated testintg.

Unfortunately atomicalign only finds errors for 64-bit unaligned access and thus cannot be used for the 32-bit ARM case.

Closing as unactionable. However, note that we have 0 uses of sync/atomic in the code base at the moment, so it looks like this is already avoided by us never needing such low-level concurrency optimization primitives.

Closing as unactionable. However, note that we have 0 uses of sync/atomic in the code base at the moment, so it looks like this is already avoided by us never needing such low-level concurrency optimization primitives.


Question: parse text with both MiniMessage tags and legacy color codes

I'm seeking a way to parse text that have both MiniMessage tags and legacy color codes.
I tried deserializing it with the legacy serializer, serializing it, and then deserializing it again with the MiniMessage parser, but the legacy serializer escapes the MiniMessage tags.
Anyone can say me how can I make work both MiniMessage tags and legacy color codes?

This is not a feature we support now, or will ever support.


[Flaky Tests] Make PersistentTopicE2ETest#testBrokerConnectionStats tests stable.

Fixes #10150
Motivation
Make PersistentTopicE2ETest#testBrokerConnectionStats tests stable.
Need to update docs? r)

[x] no-need-doc
(Please explain why)

/pulsarbot run-failure-checks


Scratching an image with alpha channel doesn't completely remove the mask

Hi Joe,
when scratching a coupon-image that uses an alpha-channel, it's only possible to scratch the areas with no transparency. When scratching over a transparent area, the mask stays there; it does however count correctly towards the scratchPercent.
Sample Image
Scratched Sample
This used to work fine in 1.0.15, so it must have been a regression in the last two committs.

Hi, Jan
After 1.0.15 version, I change the scratch mode because of lag problem on iOS 10 device~
So the coupon transparent area will cause this problem~
A good way to solve this problem is to change transparent pixel to white pixel.
Hence, I add processPixels method to solve this issue~
You can find code in master branch, or update it by CocoaPods(ver 1.1.3)~

Hi Joe,
this solved it! Thank you very much for your help.
Jan