Integration with Tasker (Enhancement Request)

It would be very, very helpful to me if I could enable and disable the notification using Tasker.  Tasker provides a facility to control 3rd party apps in this way, if the app is coded to allow it.

Thank you for the suggestion! I shall look into this. 👍

Thanks!
  From: Seht<EMAIL_ADDRESS>
To: seht/volumenotification<EMAIL_ADDRESS>Cc: Meyer20171<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Sent: Thursday, February 9, 2017 2:48 AM
Subject: Re: [seht/volumenotification] Integration with Tasker (Enhancement Request) (#12)
Thank you for the suggestion! I shall look into this. 👍 —
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@Meyer20171, please could you post your scenario how you will benefit from enabling/disabling Volume notification by Tasker? I am just curious and Tasker user too :)

The app, Volume Notification, isn't something I need all the time. I have various tasker profiles that set my desired volume levels for places I frequent, such as home and work. So when I'm in those locations, I would prefer to not display the notification from this app (I've got too many always-on notifications already).
But when I'm not in those locations, I want to turn on the volume notification, so I can quickly make adjustments. I drive a convertible, so the app is really handy to raise or lower volumes depending on whether the top is up or down.

I see your reason clearly now. Thank you very much!
I am glad that I have two permanent notifications from AccuBattery and Weather app, so I have the notification from VU with lowest priority on the bottom of the screen just next to my thumb finger on my 5.5" display :)

I've exposed a foreground service, it's a step closer! :-)

i'm planning an update to include a tile feat that opens App LInks / Urls . That should also solve this, although this apps's notification has been deprecated - it will only support tiles - moving fwd. thanks again for your contribution


Avoid the reload of plugins when editor has started.

When starting VSCode and a plugin has an update, it will tell me immediately that a reload is needed. Examples of this is when you're using nightly versions of things like the Typescript plugin.
Avoiding a plugin update reload would be preferable if you just started the editor.
I can see why this might be tricky implementation wise, as this is probably a matter of timings. As in when things are loaded and checked versus when the editor itself starts, so VSCode probably doesn't know a reload is needed until too late.
But I want to create this feature request anyway since I didn't find anything similar.

If we would to ever support this, I think it needs to be behind a setting. I would personally not want the startup speed to be slowed down by checking for extension updates.

We closed this issue because we don't plan to address it in the foreseeable future. If you disagree and feel that this issue is crucial: we are happy to listen and to reconsider.
If you wonder what we are up to, please see our roadmap and issue reporting guidelines.
Thanks for your understanding, and happy coding!

Would it be possible to avoid reloading after an extension updates altogether or is that a whole can of worms?


T9 (v0.3) Feedback

Your milestones are showing issues only from v0.3. It looks as though the product didn't exist at v0.2! Please record the older issues as well, assign it the person who did them and close them (unless github has some mechanism that stops these retrospective additions).

Please add class diagrams and seq, interaction diagrams (where  appropriate) to the Dev guide.
[To be Updated]

compiled in issue #114  for documentation


Rumbu13 patch 2

Sinonime la lumini si testele aferente
Mersi pentru cuvinte ignorate

Very outdated and most relevant changes have been included. Closing


User profile popup

Whenever you hover over a username in the arguments, you should be shown a popup with its relevant user data: name, avatar, social links, reputation

I may not have the eye of a designer, but I worked on this prototype during my lunch break. What do you think would be better colors, or maybe a more efficient way to organize the elements of the popup?

It's definitely a start :) The people at Tighten are helping with the design, so as far as I'm concerned you can send this as a PR, and we can iterate on it later ;)


moved the random string generator from k3s pkg to helpers pkg

Tasks description
Purpose: for it to be used by entire ksctl core
and can be helpful for setting hostnames for newly created VMs
Issues
Completed Issue(s)

NONE

Related Issue(s)

#277

Solution
created to be used throughtout core and other parts
Note to reviewers

[ ] Ran Tests locally
[x] Checked Contribution's guidelines

cc @Horiodino I have added this commit so that you can use this for the hostname thing
once this is merged use this in the init scripts for all the VMs created
template be like
${vm-role}-${index}-${genRandomString(5)}

make sure to handle the error


[CPU] Move 'vector.shape_cast' lowering to the end of LLVMCPUVectorLowering

Errr... I saw that 40% regression and almost quite on this PR. I decided to look at the generated IR just in case it was something obvious just to realize that the MLIR generated before and after is identical... Is that 40% really noise? _

I think they are not noise because the recent runs are all below 500 ms

There was a 40% regression on PoseNet on Pixel 6 that is now gone. Which benchmark is that screenshot from?

There was a 40% regression on PoseNet on Pixel 6 that is now gone. Which benchmark is that screenshot from?

I clicked on the benchmark name and it navigated me to the dashboard. The screenshot is PosetNet on Pixel 4.
https://perf.iree.dev/serie?IREE?063cc508375929ba7962110dbc3b0675dc03731cc30ea96d54fd6bf53b4cfd96

If the 40% regression disappeared after re-run (and we also checked the binaries are the same), then it's likely the noise. Although 40% noise is pretty abnormal...


Why it was removed from Jetbrains?

Markdown Navigator and Markdown support no one can support table

You have to enable it in the options.


bind => on

This work has the eventual goal of exposing a teardown fn inside of lazyload.
On single page applications where your DOM is transient and you do not have the saving grace of a page reload between each navigation, it is desirable to be able to tear down event listeners because they cause nodes to be retained and never garbage collected.
This PR initially migrates us from bind => on, and bind => one
The next steps will be to namespace all of the events and then expose an .destroy fn
refs:
https://github.com/tuupola/jquery_lazyload/pull/194
https://github.com/tuupola/jquery_lazyload/issues/96
https://github.com/tuupola/jquery_lazyload/pull/135
https://github.com/tuupola/jquery_lazyload/issues/62
https://github.com/tuupola/jquery_lazyload/pull/133
Profling:
https://www.youtube.com/watch?v=OLWEyH7_4e0

Thx again for the great work!

Better late than never. Thanks!


Does this project support hash mode?

I used the hash mode but it didn't take effect and the route did not jump normally

Yes, both single-spa and single-spa-vue support hash mode. I am very confident that this works correctly with single-spa, but have not tried it with single-spa-vue. However, it should work.
Could you please provide a repo that demonstrates the problem?

I use<EMAIL_ADDRESS>used the hash mode but it didn't take effect and I observed that router-view is not loaded correctly.  Cause the route cannot jump normally.  used history mode is a success.  demo @joeldenning

Thanks for the repository that demonstrates the problem. The bug was in using location.pathname instead of location.hash. See https://github.com/blacklisten/single-spa-demo/pull/1 which shows the fix. For more information, see the following links:

https://developer.mozilla.org/en-US/docs/Web/API/Location
https://developer.mozilla.org/en-US/docs/Web/API/Location/hash
https://developer.mozilla.org/en-US/docs/Web/API/Location/pathname


Add volume control for sounds

From @gitpet (#143):

Thanks for the ticker sound! I love using it. I just wish it was possible to reduce the timer tick sound volume independently from the other sound notifications, since it's too loud and can become stressful.

From Babak on CWS:

Ability to configure the volume and duration of alerts

From benlind on GitHub:

I would like a way to adjust the volume of all the sound effects (especially the "when complete" sounds).

From Ricardo on CWS:

It only lacks a sound volume bar.

From Jason on CWS:

My only gripe is that I can't reduce the volume of the timer ticking sound. I really want the ticking on, but it's too loud. However I don't want to just turn my system sound down, because then the alarms will be too quiet.

Volume control for timer tick and alert sounds
Store in sync settings

@schmich I support your idea for volume control.
It appears that it was added and then removed. Can you explain what was the challenges that lead to the removal?

@GrooveCS It was never added. I was originally against it since I didn't want to bloat the extension with yet more settings, but it's apparent that it's needed now. I'm planning to add it for sure, it's just a matter of priority.

+1


didSelectItemAt not called for UICollectionView inside FloatingPanel

Short description
This issue seems similar to #222, but for collection views.
My content view controller has a UICollectionView, which should call the didSelectItemAt delegate method when an item is tapped, but it is not called. I have verified that the content view controller works as expected when it is not inside a floating panel.
Expected behavior
Actual behavior
Steps to reproduce
Code example that reproduces the issue
fileprivate func setupPickerPanel() {
        floatingPanel = FloatingPanelController()
        floatingPanel.delegate = self
        floatingPanel.surfaceView.cornerRadius = 20
        floatingPanel.surfaceView.shadowHidden = false

        contentVC = ContentViewController()
        floatingPanel.set(contentViewController: contentVC)
        floatingPanel.track(scrollView: contentVC.collectionView)
}

Environment
Library version
1.7.0
Installation method

[ ] CocoaPods
[ ] Carthage
[ ] Git submodules
[x] Swift Packages

iOS version(s)
13.1.2
Xcode version
11.1

For my UICollectionView, didSelectItemAt gets called,  but performSegue inside a floating panel does not work...
Environment
Library version
1.7.0
Installation method

[x] CocoaPods

iOS version(s)
13.2
Xcode version
11.2.1

For my UICollectionView, didSelectItemAt gets called, but performSegue does not get called inside a floating panel.
Environment
Library version
1.7.0
Installation method
CocoaPods
iOS version(s)
13.2
Xcode version
11.2.1

Isn't didSelectItemAt always called on any panel states in your case? Or only after dragging a panel? This is because #222 is that didSelectItemAt sometimes isn't called after dragging a panel.

I hope this improvement on 1.7.1 would have an effect on this issue.

Thank you so much for looking into this! Unfortunately, the fix doesn't seem to work. didSelectItemAt is never called regardless of panel state.

@eospi
Hmm it's weird. I try to repo this by a content view controller including UICollectionView, but didSelectItemAt is called propely. Moreover, I know an app using FloatingPanel which contains a collection view and it also works well.

It looks like a tap gesture recognizer on my main view controller was interfering with the floating panel. When I remove that recognizer, it works! Is there a way to use a floating panel with other gestures on the main view?

Hi, it's not the lib's issue(I could repro this by adding a tap gesture). The problem is resolved using UIGestureRecognizerDelegate as below.
    func gestureRecognizerShouldBegin(_ gestureRecognizer: UIGestureRecognizer) -> Bool {
        if gestureRecognizer is UITapGestureRecognizer {
            let loc = gestureRecognizer.location(in: floatingPanel.view)
            return floatingPanel.surfaceView.frame.contains(loc) == false
        }
        return true
    }

That fixes it. Thanks so much for your help and the library!


fix(_redirects): correct redirects following IA work

IA was missing a bunch of redirects to avoid broken links.

FYI @cloudjumpercat


Add add_middleware interface

This PR adds an add_middleware method to the apps and ConnexionMiddleware to easily add middleware to the stack. Before, the only way to do this was to pass in a complete middleware stack.
The default position to add the new middleware is right before the ContextMiddleware, which is the final middleware in the stack. Another position can be selected by passing in a MiddlewarePosition enum, which defines some positions which make sense.
Since we can no longer assume that the whole middleware stack is defined when initializing the ConnexionMiddleware, we need to delay building the middleware stack until the ConnexionMiddleware is actually called. This also means we need to delay registering the APIs and error handlers. This is now all done in the _build_middleware_stack method.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

36 of 43 (83.72%)  changed or added relevant lines in 3 files are covered.
8 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.3%) to 93.583%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

connexion/middleware/main.py
32
39
82.05%

Files with Coverage Reduction
New Missed Lines
%

connexion/apps/abstract.py
1
90.91%

connexion/middleware/main.py
7
80.15%

Totals

Change from base Build<PHONE_NUMBER>:
-0.3%

Covered Lines:
3354

Relevant Lines:
3584

💛  - Coveralls

Yes, I went for this approach instead of leveraging the starlette Middleware class since I think:

Just passing the middleware and options to add_middleware is a more user-friendly interface than having to wrap it into a separate class first
partials are Python builtin functionality that cover our need for providing options as part of the middleware stack.

Happy to hear if you don't agree.


Python 3 compatibility

Hey,
I wanted to ask if you are open for Python 3 compatibility. I've already made it running for me locally. After some further checks if it's still compatible with Python 2.7, I could do a PR 🙂

Hey @fsonntag,
We probably will not extend for Python 3 compatibility if it adds any non-negligible overhead to the codebase, as Snorkel is still an in-development research project and we value keeping things (somewhat) simple :)
However, if you are close to a PR, we'd love to see it and if the changes required are fairly lightweight, we might be open!
And either way, thanks so much for your help here!!
-Alex

@fsonntag I would encourage a PR :)

@fsonntag I would encourage a PR

Check to make sure we didn't break anything with the big merge we just did from dev into master, but closing this for now- thanks for all the great help here!

Seems like text.decode('string_escape', errors='ignore') has been introduced in a few places since and it doesn't work with python3

+1 for Python3 compatibility.


new import set topic

https://harness.atlassian.net/browse/CDS-50041
Harness Developer Pull Request
Thanks for helping us make the Developer Hub better. The PR will be looked at
by the maintainers.
What Type of PR is This?

[ x] Issue
[ ] Feature
[ ] Maintenance/Chore

If tied to an Issue, list the Issue(s) here:

https://harness.atlassian.net/browse/CDS-50041

House Keeping
Some items to keep track of. Screen shots of changes are optional but would help the maintainers review quicker.

[ ] Tested Locally
[ ] Optional Screen Shoot.

Preview environment: https://ci.pr.harness.io/pr-300

Preview environment: https://ci.pr.harness.io/pr-300

@naman-goenka I incorporated your feedback. Great stuff. Thanks.
Please approve this PR so I can merge it.

Preview environment: https://ci.pr.harness.io/pr-300

Preview environment: https://ci.pr.harness.io/pr-300

Preview environment: https://ci.pr.harness.io/pr-300


Fix odd character at end of a line and add Win32/xLinuix-LH to AO8/J9…

… release pipeline

Taking an executive decision to force this through since it just plain doesn't work just now and can't really get any worse ;-)


After training and testing, the ply file generated by the test cannot be opened

Excuse me, is the ply file in the generated test/s3dis_preds containing point cloud x, y, z coordinates? Why can't the resulting ply file open? And is your point cloud forecast results can send me a copy? My mailbox is<EMAIL_ADDRESS>thank you!

The generated ply files contain the predictions and the labels. You can read these files using the function read_ply in helper_ply.py. Besides, we have provided the visualization.py for visualization, and it can also help you understand how to use the ply files.

Thank you very much for your reply. I didn't notice you when browsing the document. Now I have seen the visualization results of point cloud. Thank you again for your reply!
------------------ 原始邮件 ------------------
发件人:                                                                                "leofansq/SCF-Net"                                                                                @.>;
发送时间: 2021年7月15日(星期四) 晚上10:06
@.>;
<EMAIL_ADDRESS>主题: Re: [leofansq/SCF-Net] After training and testing, the ply file generated by the test cannot be opened (#3)
The generated ply files contain the predictions and the labels. You can read these files using the function read_ply in helper_ply.py. Besides, we have provided the visualization.py for visualization, and it can also help you understand how to use the ply files.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.


Highlighted news cards on homepage update content and formatting.

I think my edits for the cards on the research page made the cards on the homepage look not as good. It thought I had checked them, but I must have not checked them on my final edits. We could just make separate card types for each page.

We also need to update which cards are show. The news is pretty old. Highlight some newer content or write new news content.

I'm making new highlight cards. What are the things can be improved for the formatting?


Error Message when installing package in R

install_github("maxmind/libmaxminddb")
Error: Failed to install 'unknown package' from GitHub:
HTTP error 404.
Not Found

Did you spell the repo owner (maxmind) and repo name (libmaxminddb) correctly?

If spelling is correct, check that you have the required permissions to access the repo.

I don't know what install_github is, but it is not a supported method of installing this library. I'd suggest you follow up with the author of that installer.


feat: load admin_static to static in templste imports

simple change to import static instead of the deprecated admin_static

Hi, would it be possible to merge this?
This has been deprecated since django 2.1: https://docs.djangoproject.com/en/2.1/releases/2.1/#features-deprecated-in-2-1


release: v5.0.0

I want to include<EMAIL_ADDRESS>
https://github.com/hexojs/hexo-log/pull/125
https://github.com/hexojs/hexo-log/pull/126

Suspended by: https://github.com/hexojs/warehouse/pull/143


Change output of code analysis to show the full names of the pylint messages.

Issue Report Checklist

[ ] Searched the issues page for similar reports
[ ] Read the relevant sections of the Spyder Troubleshooting Guide and followed its advice
[ ] Reproduced the issue after updating with conda update spyder (or pip, if not using Anaconda)
[ ] Could not reproduce inside jupyter qtconsole (if console-related)
[ ] Tried basic troubleshooting (if a bug/error)

[ ] Restarted Spyder
[ ] Reset preferences with spyder --reset
[ ] Reinstalled the latest version of Anaconda
[ ] Tried the other applicable steps from the Troubleshooting Guide

[ ] Completed the Problem Description, Steps to Reproduce and Version sections below

Problem Description
We should change the output of the code analysis to show full names of the messages as they are clearer to read when used for message control in the code, and using the numeric versions for that purpose is deprecated. E.g. pointless-statement for W0104.
What steps reproduce the problem?

What is the expected output? What do you see instead?
Paste Traceback/Error Below (if applicable)

PASTE TRACEBACK HERE

Versions

Spyder version:
Python version:
Qt version:
PyQt version:
Operating System name/version:

Dependencies

PASTE DEPENDENCIES HERE

@CAM-Gerlach can you help us fix this please?

@juanis2112 Sure thing!


Use vector index node count estimates when planning TopK queries

This commit introduces a new interface: Plan.CostEstimator. This allows to plug external cost estimators into the query planner. Therefore, the code in Plan is decoupled from the actual storage / indexing machinery and can be easily tested. We also don't leak index-specific stuff to the Plan.
Currently, CostEstimator implementation estimates the expected number of visited DiskANN index nodes, depending on the limit and total number of indexed rows. This is achieved by iterating through all vector indexes involved in the query and summing their estimates.

select passage from coherebench.embeddings_table
where language='sq'
order by embedding ann of random_float_vector(1024, -1, 1)
limit 1

There is a bug here, I'm assuming initially that it just affects what's logged and not the actual execution.  The Filter in the first candidate plan should log Filter language = 'sq' instead of the ANN expression.
TRACE [ReadStage-1] 2024-07-08 09:11:51,043 Plan.java:299 - Optimizing plan:
Limit 1 (rows: 1.0, cost/row: 114.9, cost: 524.0..638.9)
 └─ Filter embedding ANN 3eb3
     └─ Fetch (rows: 1.0, cost/row: 114.9, cost: 524.0..638.9)
         └─ AnnSort (keys: 1.0, cost/key: 10.0, cost: 524.0..534.0)
             └─ LiteralIndexScan of embeddings_table_language_idx using Expression{name: language, op: EQ, lower: (sq, true), upper: (sq, true), exclusions: []} (sel: 0.008578431, step: 1.0) (keys: 126.0, cost/key: 1.0, cost: 10.0..136.0)

TRACE [ReadStage-1] 2024-07-08 09:11:51,045 Plan.java:310 - Candidate query plan:
Limit 1 (rows: 1.0, cost/row: 13403.5, cost: 6250.0..19653.5)
 └─ Filter embedding ANN 3eb3
     └─ Fetch (rows: 116.6, cost/row: 115.0, cost: 6250.0..19653.5)
         └─ AnnScan (keys: 117.0, cost/key: 10.0, cost: 6250.0..7420.0)

            // Assume independence (lack of correlation) of subplans.

Fixing this is going to be fun. :)

Tests are passing, committed.
I will create followup tickets for further improvements.


Question: Do you think to add a window interface in the future ?

Hi,
I ask if in the future you think to add a window interface and/or a easy command line:
TecoGAN.exe my_input.mp4 my_output.mp4 (options)
To be honest I find it a bit complicate to use at the current state
Thanks !

This might be what you are looking for:
https://github.com/Sanaxen/tecoGAN_app
On Sun, Jul 18, 2021, 23:50 luca2125 @.***> wrote:

Hi,
I ask if in the future you think to add a window interface and/or a easy
command line:
TecoGAN.exe my_input.mp4 my_output.mp4
To be honest I find it a bit complicate to use at the current state
Thanks !
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/thunil/TecoGAN/issues/107, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFSYSFCVH3C7N2GM2RZW3ADTYNEB5ANCNFSM5ASRC6WA
.


Docs for OS installation partitioning

docs for PR
https://github.com/RackHD/on-tasks/pull/213
https://github.com/RackHD/on-http/pull/285
@RackHD/corecommitters @RackHD/rackhd_dev

:+1:

:+1:


Transloco with MatSortModule (material)

I'm submitting a...

[ ] Regression (a behavior that used to work and stopped working in a new release)
[x] Bug report
[ ] Performance issue
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request
[ ] Other... Please describe:

Current behavior
I'm using angular material table with the matSort. When my table is inside the directive transloco, the sort doesn't work (no effect when I click on the arrow) :

{{ t("hello") }}

    <ng-container matColumnDef="position">
      No.
      {{ element.position }}
    </ng-container>

When my table is out of *transloco, the sort works :

{{ t("hello") }}

    <ng-container matColumnDef="position">
      No.
      {{ element.position }}
    </ng-container>

Expected behavior
Use transloco with mat-table and mat-sort for be able to translate my table headers.
I suppose the problem is on transloco side, but I may be wrong and it's on material side (or I'm missing something else ...).
Minimal reproduction of the problem with instructions
https://stackblitz.com/edit/transloco-material-table?file=src/app/app.component.html
Environment

Angular version: 10.0.1 - 10.1.3

Browser:
- [x] Chrome (desktop) version 85.0.4183.121
- [ ] Chrome (Android) version XX
- [ ] Chrome (iOS) version XX
- [x] Firefox version 73.0.1
- [ ] Safari (desktop) version XX
- [ ] Safari (iOS) version XX
- [ ] IE version XX
- [x] Edge version 85.0.564.51

For Tooling issues:
- Node version: v12.18.3
- Platform:  Windows

Hi, @M-Blobby looking at your case, seems like you have asynchronous problem, pay attention that in your afterViewInit method this.sort is undefinded.
This is due to the translation didn't finish to load and therefor your view is not up in AfterViewInit.
this problem can be resolved in many way... one of them would be replacing
  @ViewChild(MatSort) sort: MatSort;

with this
  @ViewChild(MatSort) set sort(sort: MatSort) {
    this.dataSource.sort = sort;
  };


Quotas

It is not clear which are the actual quotas. Although it is stated that cpu is up to 20, we are able to create a container app of 2 cpu that scales to 30. Also it would be nice to know what  your plans are in terms of scaling. Will the limit of 20 cpu be increased in the near future?

We are working to increase the quotas. In the meantime, you can open a support ticket to increase the quotas.

Watching / waiting for this one.. quotas are the last big limitation for us to start transitioning from app service

Bump

I have increased my quotas. Thanks for your time.

We are working to increase the quotas. In the meantime, you can open a support ticket to increase the quotas.

Where would we land in terms of quota? Because it's a question I am getting quite often.


Updtr changes the specifity defined in package.json

After running updtr, some of the packages I had specified in my package.json have changed in their specifity. updtr has changed some of them to be more specific and some of them to be less specific as before. Here's the output of git diff package.json after running updtr:
     "extend": "^3.0.0",
-    "gulp-angular-templatecache": "^1.8.0",
+    "gulp-angular-templatecache": "^2.0.0",
     "gulp-autoprefixer": "^3.1.0",
     "gulp-bootlint": "^0.8.0",
-    "gulp-changed": "1.3.0",
+    "gulp-changed": "^1.3.2",
     "gulp-clean-css": "^2.0.4",
     "gulp-csso": "^2.0.0",
-    "gulp-header": "1.8.2",
-    "gulp-htmllint": "^0.0.8",
+    "gulp-header": "^1.8.2",
+    "gulp-htmllint": "0.0.8",
     "gulp-htmlmin": "^2.0.0",
     "gulp-typescript": "^2.7.5",
-    "gulp-uglify": "^1.1.0",
+    "gulp-uglify": "^2.0.0",
     "gulp-util": "^3.0.4",
     "inquirer": "^1.0.3",
-    "karma": "^0.13.19",
+    "karma": "^1.2.0",
     "karma-chai": "^0.1.0",
-    "karma-coverage": "1.1.0",
+    "karma-coverage": "^1.1.1",
     "karma-mocha": "^1.0.1",
-    "karma-mocha-reporter": "2.0.4",
+    "karma-mocha-reporter": "^2.1.0",
     "karma-ng-html2js-preprocessor": "^1.0.0"

For some of them it added a ^ and for some of them it removed it. I think we should have a flag that allows to either keep the existing specifity or replace it with the recommended one instead. By default, I would expect it to keep the existing specifity.

--save-exact ?

Thanks, @djhi but that's not what i mean. --save exact always overwrites with the most specific version possible (i.e. without any ~ or ^ prefixed). What I would expect on the other hand is that my current specifity is kept. That means:

if my version is prefixed with a ~, the ~ is still there after the upgrade
if my version is prefixed with a ^, the ^ is still there after the upgrade
if my version is not prefixed, it won't be prefixed after the upgrade
and so on...

You can find all the different possibilities of how to specify version ranges in package.json here: https://docs.npmjs.com/files/package.json#dependencies.

I also have a quite similar problem : If the upgrade fails, the specifity is changed,
for example if I have :
"xmldom": "0.1.19",
do updtr, if it fails, it will look :
"xmldom": "^0.1.19",

Fixed with the rewrite


it can't update the code file if /add multi files

Issue
If I only /add one file, then the chat can update the code of that file, if I add more files, it outputs the entire code of that file and lets me update it manually, even if I ask it to update the specified file.
How to get it to follow my instructions to continue updating files?
Version and model info
aider v0.51.1
model: deepseek-coder

Thanks for trying aider and filing this issue. This doc may be helpful:
https://aider.chat/docs/troubleshooting/edit-errors.html


getPreviousMessagesByTimestamp has max. limit of 200 msgs and doesn't support pagination

Hello,
I'm using Sendbird SDK and I found out that getPreviousMessagesByTimestamp method has maximum limit of 200 messages, and doesn't support pagination.
Is there another method with unlimited maximum to use or is there any other method that supports pagination in the SDK.
Also we're facing this problem in Android SDK as well.

Hey @enasaz9 can you show me sample code of how you are trying to do this? In both iOS and Android? Also could you provide SDK version numbers?

@AlexPrestonSB , This is a sample code for the method and response
`guard let channel = self.channel else { return }
channel.getPreviousMessages(byTimestamp: timestamp, limit: 201, reverse: !initial, messageType: .all, customType: nil) { (msgs, error) in
if error != nil {
self.isLoading = false
            return
        }

        guard let messages = msgs else { return }

}`
Error Print out:
▿ Optional

some : Error Domain=Length of value is not valid. "prev_limit length must be between 0 and 200." Code=400110 "(null)"

@enasaz9 Ah okay. So there is a limit of 200 for the prev_limit. I realized it is not in all documentation so I will file a ticket to make sure this is updated.
Regarding the pagination, the easiest thing to do is use the last message in the list's timestamp as the parameter for the timestamp in the next call. (There is a param isInclusive, so you don't get duplicates.)

If you do not need to query by timestamp, you can use what is referenced here: https://docs.sendbird.com/ios/group_channel#3_load_previous_messages

Unfortunately we need to use query by timestamp.
Could you please provide sample code for your pagination solution?

Hey @enasaz9,
I don't have any sample code to provide you. I can describe the behavior for you. What I would do is design a method that takes a timestamp, and maybe a limit as a parameter(Kinda optional as you  can just hard code 200). This method should simply retrieve x amount of messages. It could mostly be what you'd have above. I'm assuming you'd have a method to handle scrolling, or swiping down to refresh. But once you get to the last element in the view, you can take that time stamp and pass it to your method to get messages.


Update setup.sh to support linux systems

The AWS CLI installation lines in setup.sh file works only for MacOS. The following change works in Ubuntu systems:
if ! command -v aws &> /dev/null
then
    OS="$(uname -s)"
    case "${OS}" in
        Linux*)
            curl "https://awscli.amazonaws.com/awscli-exe-linux-x86_64.zip" -o "awscliv2.zip"
            unzip awscliv2.zip
            sudo ./aws/install
            ;;
        Darwin*)
            curl "https://awscli.amazonaws.com/AWSCLIV2.pkg" -o "AWSCLIV2.pkg"
            sudo installer -pkg AWSCLIV2.pkg -target /
            ;;
        *)
            echo "Unsupported OS: ${OS}"
            exit 1
            ;;
    esac
fi

Model_manager is a fantastic initiative. I would love to see how this evolves.
Please create a discord channel as well.

Fixed in the most recent branch and thank you for checking us out. I'll reach out when we put together a discord / community!


Update the master branch

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (9a2e1ee) 67.84% compared to head (475c754) 86.71%.
Report is 2 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff             @@
##           master      #17       +/-   ##
===========================================
+ Coverage   67.84%   86.71%   +18.86%
===========================================
  Files          11       12        +1
  Lines         395      399        +4
===========================================
+ Hits          268      346       +78
+ Misses        127       53       -74

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


security issues

Hello!
I can run sudo linux commands in any shell in the ChatGPT-4 servers cluster.
I'd rather not write the details here, but if anyone wants to know how I do it, just email me and I'll give you a full explaining answer of what I'm talking about.

Please report it here: https://openai.com/blog/bug-bounty-program
Thank you!

Thanks for your answer Ted.
Now I need go to the bed, and I can't write the problem, because it go to take a little bit time to me, but tomorrow I will write where you have said.
Anyway, good night.

-------- Original Message --------
From: Ted Sanders @.>
Apparently from: @.
To: openai/openai-cookbook @.>
Cc: jc-rm @.>, Author @.***>
Subject: Re: [openai/openai-cookbook] security issues (Issue #363)
Date: Thu, 20 Apr 2023 21:32:43 -0700

Please report it here: https://openai.com/blog/bug-bounty-program
Thank you!
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>


[Snyk] Fix for 1 vulnerabilities

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to fix one or more vulnerable packages in the `npm` dependencies of this project.
Changes included in this PR

Changes to the following files to upgrade the vulnerable dependencies to a fixed version:

package.json

Vulnerabilities that will be fixed
With an upgrade:

Severity
Priority Score (*)
Issue
Breaking Change
Exploit Maturity

741/1000  Why? Mature exploit, Has a fix available, CVSS 7.1
Uninitialized Memory Exposure npm:base64url:20180511
Yes
Mature

(*) Note that the real score may have changed since the PR was raised.
Check the changes in this PR to ensure they won't cause issues with your project.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
🛠 Adjust project settings
📚 Read more about Snyk's upgrade and patch logic

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.

prueba snyk

prueba


[BUG] make metric precomputed in distances sklearn tests

Reference Issues/PRs
See #1189 (fixes it I think, @MatthewMiddlehurst)
Sets kernel to precomputed in SVM distance test for pairwise.

I think the KNN test also has the same issue.
It would be good to test predict with a different dataset and n_cases IMO.

I think the KNN test also has the same issue.
It would be good to test predict with a different dataset and n_cases IMO.

changed them round, take a look


Add a .travis.yml to test on travisci

Change-type: patch

Why are you using travis instead of circle?

Travis allows easily selecting the node version and running tests against multiple node versions, whilst it's possible to do on circle with a lot of heavy lifting it's really easy to do with travis (it's what the sdk/cli use, presumably for the same reason)

The SDK & CLI do both use it, but largely for historical reasons. Moving them to circle isn't very high on my todo list, and I haven't really played with it at all yet, but it is in the plan.


Docker

Instead of fighting with Ubuntu server configuration, why not put the website into a Docker container and deploy an instance of that?

Done


Avoid tenant validation hitting VMDB::Config

These validations of the logo attachment, are not needed in test, and end up
calling VMDB::Config.new for each test using this helper method.
We can bypass this by using use_config_for_attributes => false.
This is a more surgical solution over #6975.

@Fryguy came up with this idea as an alternative to #6975.
@kbrock, note, we do Tenant#seed a lot outside of this helper method in our tests... I'm not sure why this is needed and if we can avoid do similar things to avoid this validation calling slow VMDB::Config on each test.
I don't believe any of these outside of the possible ones in tenant_spec that actually test the logo file need to do the slow validations.
spec/controllers/application_controller/tenancy_spec.rb:3:    Tenant.seed
spec/controllers/application_controller/tenancy_spec.rb:24:    #     Tenant.seed
spec/controllers/miq_ae_class_controller_spec.rb:541:      FactoryGirl.create(:miq_ae_domain, :tenant => Tenant.seed)
spec/controllers/miq_ae_class_controller_spec.rb:553:      domain = FactoryGirl.create(:miq_ae_domain, :tenant => Tenant.seed)
spec/controllers/ops_controller/ops_rbac_spec.rb:6:      Tenant.seed
spec/controllers/ops_controller/ops_rbac_spec.rb:156:        @tenant = Tenant.seed
spec/controllers/report_controller_spec.rb:1190:      Tenant.seed
spec/factories/miq_ae_domain.rb:11:    tenant { Tenant.seed }
spec/factories/tenant.rb:5:    parent { Tenant.seed }
spec/factories/user.rb:36:      tenant { Tenant.seed }
spec/helpers/application_helper/toolbar_builder_spec.rb:2578:      @record = FactoryGirl.create(:tenant, :parent => Tenant.seed)
spec/helpers/application_helper/toolbar_builder_spec.rb:2929:      Tenant.seed
spec/lib/miq_automation_engine/miq_ae_domain_spec.rb:4:  let(:root_tenant) { Tenant.seed }
spec/lib/miq_automation_engine/miq_ae_service_model_spec.rb:83:    let(:tenant) { Tenant.seed }
spec/lib/miq_automation_engine/models/miq_ae_datastore/legacy_xml_import_spec.rb:21:    Tenant.seed
spec/lib/miq_automation_engine/models/miq_ae_datastore_spec.rb:33:    Tenant.seed
spec/lib/miq_automation_engine/models/miq_ae_yaml_import_export_spec.rb:15:    @tenant = Tenant.seed
spec/lib/miq_automation_engine/service_methods/miq_ae_service_spec.rb:6:      Tenant.seed
spec/models/ext_management_system_spec.rb:226:        tenant1  = Tenant.seed
spec/models/miq_expression/miq_expression_spec.rb:338:      Tenant.seed
spec/models/miq_expression/miq_expression_spec.rb:809:        Tenant.seed
spec/models/miq_expression/model_details_spec.rb:5:      Tenant.seed
spec/models/miq_group_spec.rb:289:      tenant = Tenant.seed
spec/models/mixins/tenancy_mixin_spec.rb:3:    Tenant.seed
spec/models/rbac_spec.rb:3:  let(:default_tenant) { Tenant.seed }
spec/models/service_template_catalog_spec.rb:3:    Tenant.seed
spec/models/tenant_spec.rb:13:    Tenant.seed
spec/models/tenant_spec.rb:28:      Tenant.seed
spec/models/tenant_spec.rb:50:      Tenant.seed
spec/models/vm_or_template_spec.rb:481:    before { Tenant.seed }
spec/requests/api/collections_spec.rb:203:      Tenant.seed
spec/requests/api/tenants_spec.rb:2:  let!(:root_tenant) { Tenant.seed }
spec/support/automation_example_group.rb:15:          Tenant.seed
spec/support/evm_spec_helper.rb:124:    Tenant.seed
spec/support/miq_automate_helper.rb:67:    Tenant.seed
spec/views/dashboard/login.html.haml_spec.rb:11:      allow(view).to receive(:current_tenant).and_return(Tenant.seed)
spec/views/dashboard/login.html.haml_spec.rb:21:      allow(view).to receive(:current_tenant).and_return(Tenant.seed)
spec/views/dashboard/login.html.haml_spec.rb:39:      allow(view).to receive(:current_tenant).and_return(Tenant.seed)
spec/views/dashboard/login.html.haml_spec.rb:49:      allow(view).to receive(:current_tenant).and_return(Tenant.seed)

@kbrock, note, we do Tenant#seed a lot outside of this helper method in our tests... I'm not sure why this is needed and if we can do similar things to avoid this validation calling slow VMDB::Config on each test, that would be great... I honestly don't know why we need to call VMDB::Config at all on Tenant.seed.

It is odd to spend effort speeding up an operation that is only run 1 time ever per customer. So we can either speed up execution of Tenant.seed or we can not run it so many times. (e.g.: pre-seed the database, though there are probably other possibilities here)

It would be nice if we could speed up VMDB::Config - I am getting hit by this a lot in reports and other places.

I don't believe any of these outside of the possible ones in tenant_spec that actually test the logo file need to do the slow validations.

Agreed.
Will this also speed up the calls to local_miq_server?
:shipit:

It is odd to spend effort speeding up an operation that is only run 1 time ever per customer. So we can either speed up execution of Tenant.seed or we can not run it so many times. (e.g.: pre-seed the database, though there are probably other possibilities here)

Agreed.  This is a test-only optimization.

It would be nice if we could speed up VMDB::Config - I am getting hit by this a lot in reports and other places.

Yes.

Will this also speed up the calls to local_miq_server?

Local calls remote so yes.  Again, this is only test that has this issue.  I was seeing slow controller and api tests and this was the first thing I saw.  It didn't make sense to keep seeing time spent in Psych on each test where they were doing Tenant.seed.


{Freeway-Bug}[Adaptive Cards- Product Video] :  There should be a functionality to customize font color, size, type etc. for ‘Captions’ in video player.

Target Platforms
Other
SDK Version
1.6
Application Name
Adaptive Cards
Problem Description
Test Environment:
URL: https://adaptivecards.io/
OS Version: Dev (OS Build 27695.1000)
Browser Version: Version 130.0.2849.1 (Official build) dev (64-bit)
Screen Reader: Narrator
Repro steps:

Open the above URL in the edge dev browser.
Navigate to the 'Sample' option and press enter key to activate it.
Press tab key and navigate to the 'Product Video' link and press enter key to activate it.
Press tab key and navigate to Play button and press enter key to activate play button.
Observe the issue.

Actual Result:
Users don’t have the option to change the color, font size, width, height, etc., of the captions provided in video player present on the Adaptive Card application.
There should be a feature to change/update these things for caption:
Font family
Font opacity
Font casing (some prefer all upper-case)
Font size
Font color
Background color (including none)
Background opacity
Number of lines
Positioning
Outlining
Expected Result:
The above customizations are highly desirable, this should be applicable to ‘Captions’ provided in video player present on the application. Where user controls are provided for volume adjustment, the user controls for customizing captions should be provided at the same menu level.
Example:
PFA for reference: Can You Save Taxes By Transferring Money Into Your Wife's Account ? | Watch (msn.com)
Note:
Same issue is repro throughout the application for the video player.
User impact:
Deaf low vision users who want to characterize the captions (including, for example, giving users the ability to change text size, text font, and color) would face difficulty seeing the options if there is no option to characterize the captions.
Where information and communication technology (ICT) displays captions, it shall provide a way for the user to adapt the displayed characteristics of captions to their individual requirements,
MAS Reference link:
Caption characteristics - Liquid (microsoft.com)
Have feedback to share on Bugs ? please tag bug as “A11yRCA” and add your feedback in the comment section
Screenshots

Card JSON
NA

Sample Code Language
No response
Sample Code
No response

Hi @vagpt,
My team uses HTML's video element for this. Do you have any guidance on customizations here? I do not believe we have control over the caption styling.


Gridplot -> Figure

closes #457
This PR breaks everything :smile:

[x] Gridplot renamed to Figure
[x] Plot is removed in favor of just doing Figure() since the default shape=(1, 1), i.e. "gridplot" with a single subplot
[x] Frame merged into Figure
[x] RecordMixin -> FigureRecorder

record is now an instance of Figure, use composition instead of inheritance, I haven't tested that this works yet, right now it's still a very experimental feature

[x] _frame module renamed to output, some reorganization of what is public/private within that module to make it more logical
[x] updated all the examples and tests
[x] update ImageWidget

Still need to do this for ImageWidget, waiting for #459 , rest of it is good to go and tests are passing on my end :partying_face:

when reviewing don't be scared by the size of the diff, it's mostly stuff being moved around, and the changes to the examples are mostly renaming stuff from plot -> figure, gridplot -> figure :smile:

Idea: if figure.shape == (1, 1), should be make figure.__getitem__ just pass to subplot.__getitem__ so the user doesn't have to do figure[0, 0] :thinking:


[Performance]: GPU utilization is low when running large batches on H100

Proposal to improve performance
Hi all, I'm running vicuna 13B on H100 using fp8, and I find when batch size is large, say 64 or 96, the gpu utilization is low, about 60%, this is an important cause for the low performance.
I did some analysis, part of this is caused by the schedule and post process of requests.
Do you have any plans for improving this?

Report of performance regression
No response
Misc discussion on performance
No response
Your current environment (if you think it is necessary)
The output of `python collect_env.py`

definitely, it is listed in https://github.com/vllm-project/vllm/issues/5805

definitely, it is listed in #5805

Do you have any idea about how to optimize it?
In my knowledge, python code can only run on 1 cpu core because of GIL, so how can we parallelize the post process and the decoding process ?
I'll spend some time trying to improve this, do you have any advice?  thank you.

@sleepwalker2017 btw could you please share the command when profiling vLLM using Nsight?
Thanks!

@sleepwalker2017 btw could you please share the command when profiling vLLM using Nsight?

The command is nothing special, I think it's only nsys profile python xxx.py. you can refer to nsys manual to see the usage.

@sleepwalker2017 btw could you please share the command when profiling vLLM using Nsight?

The command is nothing special, I think it's only nsys profile python xxx.py. you can refer to nsys manual to see the usage.

Thanks for your quick reply. I see. It seems that you were using nsys to profile a single .py script. I thought that you were benchmarking the service.

For  benchmarking the server, I will add nvtx marker to control the code start and end domain, just before and after .step


Update dev config file

Description
In https://github.com/openshift/autoheal/pull/67 we changed the config file format for extraVars, this PR update the dev config file, for the new format.
Screenshots
before

after

@nimrodshn @zgalor @moolitayer @elad661 @jhernand . Please review.

figured it out, we're not approvers in OWNERS file.
@moolitayer @jhernand please review.


added a check fo / to reduce FP fix #37

Now look for http:/ instead of just http: to reduce FP from things like the TS syntax someMethod(http: SomeType)

close #37


py3 compat: enableDebug and auto-resize, update tox file and pep8

This makes enableDebug() compatible with python3 and adds testcases. Added option to disable the debug again. Configured tox file to run tests on all active python implementations. Made flake8 pass and updated auto-resize raw_input to support python3.

Coverage increased (+1.2%) to 91.213% when pulling b62df8cfdc99972fc5ba4c5dbd773f28473259f2 on piotr1212:master into ec4aea6dac24e2879a3449bbb236deac1383fcfe on graphite-project:master.

Coverage increased (+1.2%) to 91.213% when pulling b62df8cfdc99972fc5ba4c5dbd773f28473259f2 on piotr1212:master into ec4aea6dac24e2879a3449bbb236deac1383fcfe on graphite-project:master.

Coverage increased (+2.0%) to 91.977% when pulling d0bd4dee70343824fe3786961da6705761ad86a4 on piotr1212:master into ec4aea6dac24e2879a3449bbb236deac1383fcfe on graphite-project:master.

Coverage increased (+2.0%) to 91.977% when pulling d0bd4dee70343824fe3786961da6705761ad86a4 on piotr1212:master into ec4aea6dac24e2879a3449bbb236deac1383fcfe on graphite-project:master.

Coverage increased (+2.0%) to 91.977% when pulling d0bd4dee70343824fe3786961da6705761ad86a4 on piotr1212:master into ec4aea6dac24e2879a3449bbb236deac1383fcfe on graphite-project:master.

Coverage increased (+2.0%) to 91.977% when pulling d0bd4dee70343824fe3786961da6705761ad86a4 on piotr1212:master into ec4aea6dac24e2879a3449bbb236deac1383fcfe on graphite-project:master.

Coverage increased (+2.0%) to 91.977% when pulling d0bd4dee70343824fe3786961da6705761ad86a4 on piotr1212:master into ec4aea6dac24e2879a3449bbb236deac1383fcfe on graphite-project:master.

Coverage increased (+2.0%) to 91.977% when pulling d0bd4dee70343824fe3786961da6705761ad86a4 on piotr1212:master into ec4aea6dac24e2879a3449bbb236deac1383fcfe on graphite-project:master.

Coverage increased (+2.0%) to 91.977% when pulling 4df8aa624dc13581f7b5e20c763858e14d2597ce on piotr1212:master into ec4aea6dac24e2879a3449bbb236deac1383fcfe on graphite-project:master.

Coverage increased (+2.0%) to 91.977% when pulling 4df8aa624dc13581f7b5e20c763858e14d2597ce on piotr1212:master into ec4aea6dac24e2879a3449bbb236deac1383fcfe on graphite-project:master.

Not sure how to get around the ugly global redefinitions which codacy complains about without changing too much.

Nah, codacy is just a recommendation, not a mandatory thing. Looks good.

LGTM

Merging that.


How are emulators running in parallel?

Hi, thank you for open sourcing this work!
I am trying to understand how emulators running in parallel is working. The bsize argument specifies how many AndroidEmulator emulators should be running in parallel within the one BatchedAndroidEnv. In batch_interact_environment, the agent only gets an action and takes a step if accelerator.is_main_process. I would have thought that an agent in each emulator would want to do this?
Also, what does the parallel argument do? Can bsize=8 and parallel=single work together?

Thanks for your question.

Can bsize=8 and parallel=single work together? I've added some notes in the multi-machine setup guide:

Note that bsize in the configuration files means the number of parallel emulators on each machine. When there are multiple worker machines collecting trajectories parallely, the total number of parallel emulators will be the sum of bsize on each machine.

So yes, bsize=8 works perfectly with parallel=single. It also works with parallel=worker if you're run on multiple worker machines.

What does the parallel argument do? Parallel defines multi-machine emulation or not. If you run emulators on a single machine, set parallel: single. If you run on multiple machines, set parallel: host for the host machine (that aggregates the trajectories and trains the model) and set parallel: worker for the worker machines (that run emulators to collect data).

In batch_interact_environment, the agent only gets an action and takes a step if accelerator.is_main_process. I would have thought that an agent in each emulator would want to do this? accelerator is for multi-gpu training, it has nothing to do with emulation.

Pardon me, but what do you mean by "take random steps"?

Sorry, not "random", just take steps working towards the current_prompt, like my code is trying to do. I am mostly wondering if the agent takes steps in each of the 8 emulators in parallel. And if so, how to make that happen?

In our implementation, each machine has bsize emulators. Each emulator is an Android environment to interact with. The agent interacts with each emulator parallelly. Steps are taken sequentially in each emulator. All steps in each emulator construe a trajectory. The illustration below might help you.


Not getting any result on top stories

Question
I'm not getting any results on top stories with keywords that have top stories on serp. I even edited the code and saw that there are urls, but somehow got lost on the parsing process.
I was using as keywords "Lionel Messi" and "Joe Biden".
Thanks
Other details
No response
Checklist

[X] I am running the latest version.
[X] I checked the documentation and found no answer.
[X] I have searched the existing issues and made sure this is not a duplicate.
[X] I have provided sufficient information.

Haven't touched the stories parsing code in a long time, so there's probably something broken there. I'm guessing Google is using js to dynamically render these things but I could be wrong, maybe it's still possible to extract them.


Send RST stream with PROTOCOL_ERROR when receive DATA frame after cancel stream

Following log on http / 2 server, I noticed that okhttp3.12.8 sent RST stream with PROTOCOL_ERROR when receiving DATA frame after canceling the stream.
This doesn't seem to be true for the HTTP / 2 specification, but only for SPDY in the Stream state: closed section (https://http2.github.io/http2-spec/#StreamStates):
HTTP / 2 specification:
"If this state is reached as a result of sending a RST_STREAM frame, the peer that receives the RST_STREAM might have already sent - or enqueued for sending - frames on the stream that cannot be withdrawn. An endpoint MUST ignore frames that it receives on closed streams after it has sent a RST_STREAM frame. An endpoint MAY choose to limit the period over which it ignores frames and treat frames that arrive after this time as being in error. "
SPDY specification (SPDY Protocol - Draft 3 https://www.chromium.org/spdy/spdy-protocol/spdy-protocol-draft3-1#TOC-2.3.7-Stream-close):
"If an endpoint receives a data frame after the stream is closed, it must send a RST_STREAM to the sender with the status PROTOCOL_ERROR."
This is causing the server to acknowledge an error, wasting sending / receiving RST frames on client / server.
I have tried to find this error in Okhttp's Change log but have not seen it. So, I hope Okhttp can reconsider this if it has never been mentioned. Thanks.

Seems like something we should fix.


Get credentials from GCP/Azure when needed

Closes #180
Closes #179
This pull request adds two flags (gcp-autologin-for-gcr and azure-autologin-for-acr) for autologin on GCP and Azure to their container registries.
This has been tested on GKE clusters with workload identities enabled and default service account.
This has been tested on an AKS w Managed Identities.
Further refactoring could be done to move implementation details of various cloud providers into a dedicated package.
Signed-off-by: Somtochi Onyekwere<EMAIL_ADDRESS>

This is a note for later but I think it would be better to get these implementations out of the controller, maybe moved to internal.

I've done some testing against the image somma/image-reflector-controller:test-autologin-c34c7cf34b1 on both Azure and GKE, and the feature was working all around for me.
$ flux get image policy -A
NAMESPACE       NAME    READY   MESSAGE                                                                                LATEST IMAGE
podinfo-staging podinfo True    Latest image tag for 'acrkingdontest.azurecr.io/stefanprodan/podinfo' resolved to: 5.0.0        acrkingdontest.azurecr.io/stefanprodan/podinfo:5.0.0

and on GCP:
$ flux get image policy -A
NAMESPACE               NAME    READY   MESSAGE                                                                 LATEST IMAGE
podinfo-production      podinfo True    Latest image tag for 'gcr.io/dx-kingdon/podinfo' resolved to: 5.0.0     gcr.io/dx-kingdon/podinfo:5.0.0

The testing involved was to follow basically the first half of the Image Update guide: create an ImageRepo and ImagePolicy, pointed at the private repository. Remove the flag to confirm that access does not happen without the newly added feature. When the flag is present, there should be no secretRef or other access management required, it should "just work."
I created the Azure cluster in an existing Resource Group through the portal with a "System-Managed Identity" and associated the cluster with a Container Registry on the same RG. I used Azure CNI and Calico policy enforcement, which probably doesn't matter, (but just to be complete) with Kubernetes 1.21 under the hood. The image repo created was definitely private. I used the Quickstart guide from Azure docs to "build and push" some example Podinfo images FROM stefanprodan/podinfo:5.0.0.
https://docs.microsoft.com/en-us/azure/container-registry/container-registry-quickstart-task-cli
The Dockerfiles for example are in here: https://github.com/kingdonb/bootstrap-repo/tree/main/apps/base/podinfo - they are very sparse. I just needed two images so I could confirm they were both discovered successfully when the ImageRepo is reconciled.
I did the same test on GCR basically, creating a GKE cluster with Workload Identity enabled, then building the same images from the tutorial for Google Cloud Build. This testing method made it possible for me to avoid using my local network or any local build nodes 👍 I placed the images in a new repository in the same project-id that my cluster was created in. I assume this is using the new "Artifact Registry" protocol but I haven't looked deeply into it yet. (Maybe separate validation is still needed for that.) I just used the most obvious docs and searched for anything that I didn't know, I'm only marginally familiar with both cloud vendors.
https://cloud.google.com/build/docs/building/build-containers
The Workload Identity automatically authorized the project repository in the same workspace (project) and as I was able to push images with the gcloud client, that were then discovered without issue by the image-reflector-controller, with a set of manifests in and centered around this one: https://github.com/kingdonb/bootstrap-repo/blob/main/apps/production/podinfo/imagerepo.yaml
After confirming these both worked successfully with the flags:
https://github.com/kingdonb/bootstrap-repo/blob/75fc7f8822f1850d4046700ce4281c39ac5e4bfd/clusters/gke-geekingdon/flux-system/kustomization.yaml#L16
and
https://github.com/kingdonb/bootstrap-repo/blob/75fc7f8822f1850d4046700ce4281c39ac5e4bfd/clusters/aks-kuberkingdon/flux-system/kustomization.yaml#L16
I'm happy to report the feature works without issue on both of these! Removing the flag made for an authentication error that looked reasonable, (I didn't capture it.) I'll be repeating the testing later today, in case there are any questions or issues in the critical path that other reviewers wanted to make sure are properly addressed. Please let me know.

Could you please also resolve the conflicts?

I have some surprising results after testing further on GKE,
I created a new cluster and enabled Workload Identity, but the reflector controller can no longer reach the auth, or something else has gone wrong:
{"level":"error","ts":"2021-11-23T20:02:18.456Z","logger":"controller-runtime.manager.controller.imagepolicy","msg":"Reconciler error","reconciler group":"image.toolkit.fluxcd.io","reconciler kind":"ImagePolicy","name":"podinfo","namespace":"podinfo-production","error":"version list argument cannot be empty"}
{"level":"info","ts":"2021-11-23T20:02:21.686Z","logger":"controller-runtime.manager.controller.imagerepository","msg":"Logging in to GCP GCR for gcr.io/dx-kingdon/podinfo","reconciler group":"image.toolkit.fluxcd.io","reconciler kind":"ImageRepository","name":"podinfo","namespace":"podinfo-production"}
{"level":"error","ts":"2021-11-23T20:02:21.878Z","logger":"controller-runtime.manager.controller.imagerepository","msg":"Reconciler error","reconciler group":"image.toolkit.fluxcd.io","reconciler kind":"ImageRepository","name":"podinfo","namespace":"podinfo-production","error":"GET https://gcr.io/v2/dx-kingdon/podinfo/tags/list?n=1000: DENIED: Failed to read tags for host 'gcr.io', repository '/v2/dx-kingdon/podinfo/tags/list?n=1000'"}
{"level":"info","ts":"2021-11-23T20:03:59.667Z","logger":"controller-runtime.manager.controller.imagerepository","msg":"Logging in to GCP GCR for gcr.io/dx-kingdon/podinfo","reconciler group":"image.toolkit.fluxcd.io","reconciler kind":"ImageRepository","name":"podinfo","namespace":"podinfo-production"}
{"level":"error","ts":"2021-11-23T20:03:59.693Z","logger":"controller-runtime.manager.controller.imagepolicy","msg":"Reconciler error","reconciler group":"image.toolkit.fluxcd.io","reconciler kind":"ImagePolicy","name":"podinfo","namespace":"podinfo-production","error":"version list argument cannot be empty"}
{"level":"error","ts":"2021-11-23T20:03:59.875Z","logger":"controller-runtime.manager.controller.imagerepository","msg":"Reconciler error","reconciler group":"image.toolkit.fluxcd.io","reconciler kind":"ImageRepository","name":"podinfo","namespace":"podinfo-production","error":"GET https://gcr.io/v2/dx-kingdon/podinfo/tags/list?n=1000: DENIED: Failed to read tags for host 'gcr.io', repository '/v2/dx-kingdon/podinfo/tags/list?n=1000'"}

This while the images can be deployed in the cluster, so apparently the project association is correct, something else has gone wrong.
I suspect this is probably a configuration error, although I'm not sure what can have gone wrong, I have the flag enabled and my image is at:
images: # []
- name: ghcr.io/fluxcd/image-reflector-controller
  newName: docker.io/somma/image-reflector-controller
  newTag: test-autologin-c34c7cf34b1

but the registry cannot be scanned for ImageRepository resources. Is there somewhere else to check for debugging errors?

@SomtochiAma sent me some docs about Workload Identity that I hadn't seen before. It looks like my previous test was not using workload identity, but the default service account instead. I will go back and repeat it after I work out my Workload Identity issues to confirm. Anyway just to add to this report, my configuration issue is definitely a configuration issue.

I am adding some notes here for testing this on GCP. I will write more detailed documentation next and make a commit.

Enable Workload Identiy on the cluster (Docs: https://cloud.google.com/kubernetes-engine/docs/how-to/workload-identity#enable_on_cluster. If you have an existing cluster, don't forget to migrate applications to workload identity. See https://cloud.google.com/kubernetes-engine/docs/how-to/workload-identity#migrate_applications_to
Create a GCP service account that has access to GCR
Bind the GCP service account to the image-reflector-controller service account (Docs)
Customize the flux manifest so that it uses the image from this pull request and also annotates the image-reflector-controller service account with the  iam.gke.io/gcp-service-account label

Example of gotk-patches.yaml
apiVersion: apps/v1
kind: Deployment
metadata:
  name: image-reflector-controller
  namespace: flux-system
spec:
  template:
    spec:
      containers:
      - name: manager
        image: somma/image-reflector-controller:test-autologin-d5255a590
        args:
          - --events-addr=http://notification-controller.flux-system.svc.cluster.local/
          - --watch-all-namespaces
          - --log-level=info
          - --log-encoding=json
          - --enable-leader-election
          - --gcp-autologin-for-gcr
---
apiVersion: v1
kind: ServiceAccount
metadata:
  name: image-reflector-controller
  namespace: flux-system
  annotations:
    iam.gke.io/gcp-service-account<EMAIL_ADDRESS>

The bootstrap docs along with #193 should be placed in https://fluxcd.io/docs/guides/image-update/#imagerepository-cloud-providers-authentication

It's noted elsewhere, but following up that I have tested GKE Workload Identity to connect with gcr.io registries successfully
However I was not able to get artifact registry working through workload identity, even after separately granting the role for role/artifactregistry.reader I still get this error:
podinfo-artifact-registry	False	GET https://us-central1-docker.pkg.dev/v2/token?scope=repository%3Adx-kingdon%2Fgeekingdon-images%2Fpodinfo%3Apull&service=us-central1-docker.pkg.dev: DENIED: Permission "artifactregistry.repositories.downloadArtifacts" denied on resource "projects/dx-kingdon/locations/us-central1/repositories/geekingdon-images" (or it may not exist)	                         	False

I guess the culprit is here: https://github.com/fluxcd/image-reflector-controller/pull/194/files#diff-922fcbfbe2565443329918a2b0d49b2b03588007ec6464a20d3feb824f3f80a2R735-R737
it needs to match pkg.dev as well (and possibly others), else artifact registry won't be considered as the same as container registry. I'm giving it a shot and testing it on my own, I think I have everything I need to compile a version of image-reflector-controller 👍

The other thing I might want to add to the docs:
gcloud projects add-iam-policy-binding <PROJECT> --member<EMAIL_ADDRESS>--role roles/artifactregistry.reader
gcloud projects add-iam-policy-binding <PROJECT> --member<EMAIL_ADDRESS>--role roles/containerregistry.ServiceAgent

It was not very difficult to discover these roles, but we can help the users by spelling it out.
I'm not sure I have selected the minimal roles either. There is no containerregistry.reader and after applying both (and possibly some others), I wind up with this set of bindings which seems like it might likely be in excess of what I needed:
Updated IAM policy for project [dx-kingdon].
bindings:
- members:
  -<EMAIL_ADDRESS>  role: roles/artifactregistry.reader
- members:
  -<EMAIL_ADDRESS>  role: roles/artifactregistry.serviceAgent
- members:
  -<EMAIL_ADDRESS>  role: roles/cloudbuild.builds.builder
- members:
  -<EMAIL_ADDRESS>  role: roles/cloudbuild.serviceAgent
- members:
  -<EMAIL_ADDRESS>  role: roles/compute.serviceAgent
- members:
  -<EMAIL_ADDRESS>  role: roles/container.serviceAgent
- members:
  -<EMAIL_ADDRESS>  -<EMAIL_ADDRESS>  role: roles/containerregistry.ServiceAgent
- members:
  -<EMAIL_ADDRESS>  -<EMAIL_ADDRESS>  role: roles/editor
- members:
  -<EMAIL_ADDRESS>  role: roles/owner
- members:
  -<EMAIL_ADDRESS>  role: roles/pubsub.serviceAgent
etag: BwXVjQ36L8E=
version: 1

Someone who knows GCP well enough to say how to select the minimal roles should review that information for correctness.

@SomtochiAma can you please rebase and run make fmt.

@SomtochiAma can you please open a new PR to address @squaremo comment, sorry I missed it.


Create galileimirandola.txt

Website: https://www.galileimirandola.edu.it

@alessiocelentano Pull request merged. Thank you!


findReplaceFilter can't be set to delete characters

If the replace is an empty string, then the replacement doesn't work

This appears to only be an issue when chaining together findReplaceFilters where the first filter attempts to delete chars.


API proposal: special-cased whitelisting for certain attributes?

Hi, would you be open to allowing specific whitelisting rules for certain attributes? It's common to want to want to allow certain styles or css classes.
So the rule:
  font: {
    style: {
       color: true
    },
   'class': {
      myclass: true
   }
  }

Would turn:  into .
So HTMLJanitor would basically have special-cased rules for certain attributes, such as 'style' and 'css' that happen to have multi-part values. There might be some others.
Let me know if you're open to this and I can file a PR.

ping @rrees

Yeah, this seems reasonable. I'm not sure we have this detailed a use-case so I didn't feel qualified to comment. Feel free to build the PR.
From a code point of view I think this set of functionality might make the single spec file unmanageable so it might be sensible to have all the rule-based functionality out in its own spec.


add new car profile and libs for unidb

Issue
Lua profile supports unidb.
Duplicate car.lua and rename car-unidb.lua.
Duplicate the folder of lib and rename lib-unidb.
Since almost half of files in lib folder need to be changed, instead of duplicate each of them in original folder, duplicate the whole folder.

@hellotechx  It looks good to me. But please:

mention the issue link the PR for in PR description(link it in "linked issue" in right panel will result to close the issue automatically once the PR merged)
mark milestone this PR for

One more question, could you please also write basic maintain/modify rules in the profiles/README.md instead of commit a empty one? Next time then always append changes when have anything change related Lua, right?

@wangyoucao577
Linked.
README.md will be updated with traffic signal since I haven't figure out the content/format for this PR.
There are two coming PRs.
One is revert PR#67
One is traffic signal + README.md updated

Remove the empty README for this PR.
Will add it back in coming PR.

Then the car-unidb.lua will only invoke functions from lib-unidb/, and car.lua will only invoke functions from lib/, right?

Then the car-unidb.lua will only invoke functions from lib-unidb/, and car.lua will only invoke functions from lib/, right?

Yes. Eventually any pattern of xxx-unidb.lua should only invoke lib-unidb/*
Any pattern of xxx.lua should only invoke lib/*

Then the car-unidb.lua will only invoke functions from lib-unidb/, and car.lua will only invoke functions from lib/, right?

Yes. Eventually any pattern of xxx-unidb.lua should only invoke lib-unidb/*
Any pattern of xxx.lua should only invoke lib/*

This could be the most important rule in the next README.md. It looks good to me.
@CodeBear801  Please help to review and approve it if you're ok with it a.s.a.p. @hellotechx  is ready to improve .lua for traffic_signals and stop_sign.

Great.  @hellotechx, please add a file changelog.md to record our changes compare with original script.
It will contain information like:
- change xxx value from yyy to zzz for mmm purpose
- add new attribute of hhh for eee purpose
...


Update the group policy path

The path in local group policy is now "Computer Configuration\Administrative Templates\System\Device Guard" (at least in 10.0.19041), updating docs to match what is in local group policy.

#sign-off


Updating the link for API documentation on kubernetes.io

@bgrant0607 @vmarmol

LGTM. Thanks. The old documentation was very, very, very out of date.


Add KotlinConf talk recording link to README

Messages

:book:

Thank you very much for making our website better :heart:!

  Generated by :no_entry_sign: dangerJS against 98f3337b845289c44d169a4290d7743646667a07


Trivy Operator crashes large clusters

What steps did you take and what happened:
We ran trivy operator installed through the Helm chart version 0.25.0 on an OKD 4.15 cluster with ~1200 non-system pods, most of them running with two containers or more. We expected this to create quite some load on the cluster and customized the installation this way:
excludeNamespaces: "kube-system,openshift-*"
operator:
  vulnerabilityScannerEnabled: true
  sbomGenerationEnabled: true
  # disable config, rbac, infra and compliance scanner
  configAuditScannerEnabled: false
  rbacAssessmentScannerEnabled: false
  infraAssessmentScannerEnabled: false
  clusterComplianceEnabled: false

What did you expect to happen:
We expected this to take quite a while to complete and initially results looked good. At some point load on etcd got exceedingly high and leader changes started to occur. This led to a complete crash of the API and the cluster had to be restored from a recent etcd backups. We managed to take a snapshot before starting recovery and the etcd cluster grew from ~380MB to ~1.2Gi
We would need to scale the control-plane significantly to accommodate trivy-operator and also consider deploying it in a production cluster to be too dangerous.
Are there any options to reduce the footprint of CRs? In general I feel that trivy-operator relies too much on etcd as an actual data storage and that isn't in line with kubernetes design philosophy.

@bo0ts thanks for the report!
we should investigate it.
Did this issue happen before or it was introduced in Chart v0.25.0?

If I understand correctly, this is expected by Trivy Operator's design which relies exclusively on CRDs (etcd) to store scans output. If that is the issue then it isn't a bug, but enhancement request, and I'm afraid we are not planning to change the fundementals of trivy operator at this point in time.

Did this issue happen before or it was introduced in Chart v0.25.0?

This was the first version we installed so I do not know if this is a regression.

If I understand correctly, this is expected by Trivy Operator's design which relies exclusively on CRDs (etcd) to store scans output. If that is the issue then it isn't a bug, but enhancement request, and I'm afraid we are not planning to change the fundementals of trivy operator at this point in time.

That's a pity. What's the alternative? Using trivy with custom scripting?

That's a pity. What's the alternative? Using trivy with custom scripting?

Allow me to ellaborate: Trivy Operator's purpose is to be a Kubernetes Operator for Trivy. Kubernetes Operators' design is centered around Kubernetes Resources (CRDs). Kubernetes Resources have limitations imposed by Kubernetes, etcd, or your cluster configuration. That's part of the deal of being a Kubernetes native operator.
If there are suggestions for incrementally improving Trivy Operator within it's current design and scope (Kubernetes Operator, CRDs), than we can consider (it would help if it's a PR).
Alternatively if you don't need/want a Kubernetes Operator but just a solution for scanning kubernetes workloads, you can roll your own orchastration for Trivy like you suggested, or consider a commercial offering that is built for scale such as Aqua Security

Trivy. Kubernetes Operators' design is centered around Kubernetes Resources (CRDs). Kubernetes Resources have limitations imposed by Kubernetes, etcd, or your cluster configuration. That's part of the deal of being a Kubernetes native operator.

I think that is stretching the concept of an operator, but this is expected to happen given that it is such a flexible concept.
Another (and IMO more common)  way to think about operators is to represent concepts of the application as custom resource definitions and instances of those concepts as custom resources. The operators task then is to reflect custom resources in the application and reflect application state back into the status of the custom resource. Consider the rabbitmq-topology operator where there are CRDs for RabbitMQ objects like a RabbitMQ instance, User, Queue, or VHost. The operator then makes sure custom resources have an associated representation in the "real" world. No one would expect the custom resource to hold any queue messages or other application state.
The current design effectively (ab)uses the control-plane as a data-store for trivy (and maybe out of necessity because trivy has no built-in data-plane). I'd rather have an actual data-store for trivy and would let the operator handle the scheduling of scans (You could think of custom resources like a TrivyStore, Scan, ScanSchedule, ClusterScan, ClusterScanSchedule,...).
I assume you would consider that out of scope of the current design?

Did this issue happen before or it was introduced in Chart v0.25.0?

@bo0ts could you give another version a try? We're curious if the latest version changed anything significant.

Did this issue happen before or it was introduced in Chart v0.25.0?

@bo0ts could you give another version a try? We're curious if the latest version changed anything significant.

@simar7 it doesn't look like the issue depends on the latest version. there are a few similar issues about etcd problem.

I'd rather have an actual data-store for trivy and would let the operator handle the scheduling of scans ... I assume you would consider that out of scope of the current design?

yes, this is currently out of scope for Trivy Operator open source project

yes, this is currently out of scope for Trivy Operator open source project

Too bad, but understandable. Let's close this.


Updated PR runner to use MacOS-latest

Problem
The OS for the GitHub Action test runner currently runs Ubuntu, causing different results for E2E test runners compared to local dev environments.
Solution
Use MacOS-latest as test runner OS.

Tests

[ ] I have tested this change on VSCode
[ ] I have tested this change on JetBrains

License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

So, let's also move the publish to macos latest too


ability to shut off annotating permissions so it can be done at a hig…

…her level

Looks good, merging.


Use imagej-mesh for reading/writing meshes

https://github.com/imagej/imagej-plugins-io-mesh

Closed via 60894c9c1407260700e9818dae1454671ee95298.


Method getTime() does not exist issue with TYPES.DateTime

I believe it is around line 261 of file data-types.js or 182 in the source.
The parameter.value.getTime() has no method, because parameter.value is just a literal number value. Parameter.value needs to be inserted into a new object in the same manner as what is done in DateTime2 aka "time = new Date(+parameter.value)".
Once I made that change to DateTime in data-types.js everything worked properly.

You're trying to pass a number as a date value? If so, that's not supported by tedious, nor do I expect we would accept such a merge request. Tedious should support either Date objects or date-string literals as date parameters. If you've found a bug in that, then please post code.

Ah, ok I see what you are saying. I was passing a literal number that was properly formatted just as a test. Didn't think about creating a date object before passing it directly.


Verousca: Precourse, Week 1

GitHub

[x] 🥚 Creating Issues: You can create a new issue in a GitHub repository using an issue template. You can correctly use labels, milestones, and assignment to make your issue findable.
[x]  🥚 Searching Issues: You can find issues in a repository by label, author, and milestone.
[x]  🥚 Project Boards: You can use issues on a GitHub project board to track your class assignments and help your classmates when they need it.

HYF Workflows:

[ ]  🥚 Check-Ins: You can use the check-in template to track your module learning objectives, your weekly progress (and to post a retrospective at the end of the module). You create one check-in issue per module in the class repo and each Thursday you add a check-in comment to it and the label for the corresponding week. After review, we add the checked label. No need to remove previous labels either. So as an example, after a 5 week module, you would have 5 comments and 5 labels added by you.
[ ]  🥚 Deliverables: You can create an issue for this module's deliverable and track your progress on the class project board. Each week, there are different assignments/deliverables. If it is an individual project, you create your own deliverable issue for it in the class repo. If it is a group project, the entire group creates 1 issue together in the class repo.
[ ]  🥚 Asking for Help: You can use the help-wanted template in your class repository's Discussion board to ask for help, and to help your classmates when they are blocked.
Your Computer:
[x]  🥚 File System Management: You can create and organize a new folder in your personal computer for the materials you will study at HYF.

Visual Studio Code:

[x] 🥚 Install and manage extensions
[x]  🥚 Open a folder for editing
[x]  🥚 Create new files/folders inside of the folder
[x]  🥚 Edit files and save changes

Hi, @Verousca You are supposed to add "checkin questions" and answer them. This was yesterday's task. Please do your task on time and finish your check-in. If you have trouble on something, please ask on discord.

I Need Help With:
A beter understanding on how GitHub operates.
What went well?
Installing the extensions on VS Code was smooth
What went less well?
Clearly understanding and navigating through Github. At the moment I can only do some stuff but I don't feel like I clearly get it.
Lessons Learned
Navigating through the software during my free time actually helps my engagement with it.
Sunday Prep Work
I am still in the prepping process for Sunday


Training takes much more time after load saved model(pretrained model)

Click to expand!
Issue Type
Performance
Source
source
Tensorflow Version
tf 2.10
Custom Code
Yes
OS Platform and Distribution
Ubuntu 18.04
Mobile device
No response
Python version
3.9
Bazel version
No response
GCC/Compiler version
No response
CUDA/cuDNN version
No response
GPU model and memory
Nvidia A10G x4
Current Behaviour?
Hi all. I have started to train a custom model with my custom dataset. An epoch takes 20 minutes. When I save & load trained model and start training from pretrained model one epoch takes 1 hour to train. I am using multiple GPUs & Tensorflow Saved Model format(.pb). Why this is happening? I have encounter this issue many times and I assume that it is normal but is that normal?

Standalone code to reproduce the issue
strategy = tf.distribute.MirroredStrategy()
    print(f'Number of devices: {strategy.num_replicas_in_sync}')

    with strategy.scope():
        model = model.create_model() # Call model

        # Compile model with 3 different loss with 3 different coeffs.
        model.compile(
            optimizer=Adam(learning_rate=1e-2),
            loss=[
                tf.keras.losses.MeanSquaredError(reduction=tf.keras.losses.Reduction.SUM),
                tf.keras.losses.MeanSquaredError(reduction=tf.keras.losses.Reduction.SUM)
            ],
            loss_weights=[3.0,0.02],
            metrics=['accuracy']
        )
    callbacks = [tf.keras.callbacks.ModelCheckpoint(
                    filepath=model_save_path,
                    save_weights_only=True,
                    verbose=1,
                    monitor='loss',
                    mode='min',
                    save_best_only=False),
        tf.keras.callbacks.LearningRateScheduler(scheduler),
        tf.keras.callbacks.CSVLogger('./model_save/training.log')]
    model.summary()

Hi @dasmehdix ,
Ideally there should not be much variation in training time when same model being reused on same inputs.But if there is some customizing done on the reloaded model architecture then it might affect training time.If you can share the complete code that may be helpful for us to check the problem.
Thankyou!


fix docker build

#135 - fix docker build

This change is

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.28%. Comparing base (f93ddc4) to head (1fe9986).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #136      +/-   ##
==========================================
- Coverage   88.14%   87.28%   -0.87%
==========================================
  Files         273      269       -4
  Lines       16050    15538     -512
==========================================
- Hits        14148    13562     -586
- Misses       1902     1976      +74

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Existing error:
310.3 Building wheels for collected packages: sacremoses
310.3   Building wheel for sacremoses (setup.py): started
310.6   Building wheel for sacremoses (setup.py): finished with status 'done'
310.6   Created wheel for sacremoses: filename=sacremoses-0.0.53-py3-none-any.whl size=895239 sha256=6ebf61b8a2d67522865e62e21780330febea4dfb15a19f117f907f7480ba9e39
310.6   Stored in directory: /tmp/pip-ephem-wheel-cache-yv62bzgp/wheels/23/9c/68/179ccbdb91b8111e62b7518d3cf19e1f6af16440f1c146f93e
310.6 Successfully built sacremoses
311.2 Installing collected packages: sortedcontainers, sentencepiece, pytz, mpmath, xxhash, urllib3, tzdata, typing-extensions, tqdm, sympy, sil-thot, safetensors, rpds-py, regex, pyyaml, python-dateutil, pyparsing, pyjwt, pyarrow, psutil, propcache, pillow, pathlib2, packaging, orderedmultidict, nvidia-nvtx-cu12, nvidia-nvjitlink-cu12, nvidia-nccl-cu12, nvidia-curand-cu12, nvidia-cufft-cu12, nvidia-cuda-runtime-cu12, nvidia-cuda-nvrtc-cu12, nvidia-cuda-cupti-cu12, nvidia-cublas-cu12, numpy, networkx, multidict, markupsafe, json-stream, joblib, jmespath, idna, fsspec, frozenlist, filelock, dynaconf, dill, click, charset-normalizer, certifi, attrs, aiohappyeyeballs, yarl, triton, sacremoses, requests, referencing, pandas, nvidia-cusparse-cu12, nvidia-cudnn-cu12, multiprocess, jinja2, furl, botocore, aiosignal, s3transfer, nvidia-cusolver-cu12, jsonschema-specifications, huggingface-hub, aiohttp, torch, tokenizers, jsonschema, boto3, transformers, datasets, clearml, accelerate
315.5   Attempting uninstall: pyparsing
315.5     Found existing installation: pyparsing 3.1.1
315.5 ERROR: Cannot uninstall pyparsing 3.1.1, RECORD file not found. Hint: The package was installed by debian.
------

pyproject.toml line 62 at r1 (raw file):
Previously, mshannon-sil wrote…
Unless I'm missing something, it looks like urllib3 was added to the pyproject.toml, but removed from the poetry.lock file.

That's how it was resolved.  I don't know about the urllib3 issue - I just added it from the direction of @TaperChipmunk32.

The docker images are creating now.  They are all running much faster too!

pyproject.toml line 62 at r1 (raw file):
Previously, mshannon-sil wrote…
That's how it was resolved. I don't know about the urllib3 issue - I just added it from the direction of @TaperChipmunk32.

This was the error from the build in actions: "The urllib3 package has the following compatible candidates [Package('urllib3', '1.26.20')];  but, the exporter dependency walker previously elected urllib3 (2.2.3) which is not compatible with the dependency urllib3 (>=1.25.4,<1.27). Please contribute to poetry-plugin-export to solve this problem."

dockerfile line 66 at r3 (raw file):
Previously, mshannon-sil wrote…
This environment variable CLEARML_AGENT_SKIP_PIP_VENV_INSTALL should be unnecessary, since you're already skipping the python env install with the other environment variable, and according to the documentation it's supposed to take a path to an existing python environment rather than a boolean value: https://clear.ml/docs/latest/docs/clearml_agent/clearml_agent_env_var/

done

dockerfile.cpu_only line 45 at r3 (raw file):
Previously, mshannon-sil wrote…
Same comment as in the regular dockerfile.

done


Add more tips for setting up environment

Some tips to help setting up the environment, as discussed here

Ah, I forgot -- add yourself to AUTHORS -- commit, squash and force push again.
Otherwise it looks good !

Add myself to authors :)

You need to rebase in order to resolve the conflict

Could you rebase and resolve the conflict ?

So sorry I missed the message, I think the conflict is resolved now.

Rebased, and merged.
Thanks for your contribution !


Falldamage rule ignored at specific heights (dedicated server)

I tested various heights (level surface) and found that at specific heights the boat would break even with the falldamage rule set to false.
Sometimes it wont break as long as you're moving.
Affected jumpforce values (tested with .1 steps, from 0-1.5):

0.6 (4 blocks)
0.8 (7.5 blocks)
1 (12 blocks)
1.1 (14.5 blocks)
1.2 (17 blocks)
1.5 (27 blocks)

Sometimes changing values by .01 fixes the issue.
You need to tap W again after landing to break the boat.
Only breaks when jumping. Falling from same heights doesn't break the boat.
Might be a desync issue. Server is overspec and I have low ping if that helps.
Thoughts:
Jumping probably brings you to certain decimal heights that just kill the boat anyway because it accelerates to a specific speed. Just falling from equal heights (flat values) might work fine because it doesn't accelerates to that specific downwards acceleration that ignores the gamerule and therefore destroys the boat.
But all in all a really really fun mod. I wish we had it back then when friends still had time to play.

nvmd fixed it with https://modrinth.com/mod/boat-break-fix
Still would be nice if that feature would be fixed in the future.

my theory here is the boat is breaking serverside, obu prevents it from happening on the client but if the server says the boat breaks then it breaks. something like boat-break-fix works here because it runs on the server too. I could do something similar for obu but its really made for other mods and/or plugins to take advantage of rather than being used standalone

I ran obu for testing reasons on the server. Would be nice if running commands from the server console would set them default globaly. Something like if server executes command it applies to @a as default even on reconnect or first join.


How does the host application obtain the name of the called constructor for foreign classes?

Consider this foreign Wren class:
foreign class Unicorn {
  construct new(name) {}
  construct brown(name) {}
}

The docs say:

When you create an instance of a foreign class by calling one its constructors, Wren invokes the allocate callback you gave it when binding the foreign class. Your primary responsibility in that callback is to tell Wren how many bytes of raw memory you need. You do that by calling:
void* wrenSetSlotNewForeign(WrenVM* vm,
int slot, int classSlot, size_t size);

I don't see any way to get the name of the constructor being called though. For example (given the script above), in the host application, how do I know that the script is calling the new or the brown constructor above so I can perform the appropriate initialisation?

You don't. Your class shouldn't depend on the constructor called to know how much memory it should take, otherwise you have an issue (can't find my words) and should probably split the class (e.g. having a field that is of type ClassA is new and ClassB is brown).

Thank you for clarifying.
I'm in the process of making bindings for Wren for an obscure language (Xojo), not C, so I've been using the memory passed to the VM in the class allocator as a pointer to the instance in the host application not the number of bytes the instance will use.
I think what I'll do is when I design the Wren API for my app I will just use the same name for all constructors (e.g: new).
Presumably I'm able to get access to the number of parameters passed to the constructor or is that not possible either?

If I remember well you have access to the parameters and so their counts, thought you MUST not alter the stack more than returning the newly created instance.
That said there is a way to circumvent the limitation, if you really need to create objects of different size with the same object interface. Thought I would not recommend it.

If I remember well you have access to the parameters and so their counts, thought you MUST not alter the stack more than returning the newly created instance.

That's great to hear.

That said there is a way to circumvent the limitation

Do tell...

foreign class Unicorn {
  static new(name) {
     var instance = new_(0, name)
     // finish to initialize instance here
     return instance
  }
  static brown(name) {
     var instance = new_(1, name)
     // finish to initialize instance here
     return instance
  }
  construct new_(id, name) {
    _name = name
  }
}

That way you can change your allocation based on the identifier passed, I used a number for simplicity, but can be anything you can retrieve from the VM without modifying the stack (like a string).

There is a limitation I forgot, you can't have member variables in vanilla wren. but you still have the possibility to use getter/setters.

Thanks @mhermier, I think this is the solution.


IOS safari support

This plugin works great for every device except for IOS running devices. Please fix it for IOS

If you look at the docs:

iOS plays video from a browser only in the native player. So video for iOS is disabled, only fullscreen poster will be used.

Either way, on iOS it's not going to be within the background since it's going to play natively.


UI Testing

Usability testing, maybe with external people?

UI Test Plan.pdf

UI Test Report.pdf


[bug 1228958] Change wording in registration message.

PEP8 fix.

@johngian can you sign this please  :P

r+


Update project to Webpack 2.2

Webpack is used here for development of plugin itself. In your own project you can use webpack 2.2