Segfault in H5FD__free_cls with netcdf 4.91.

I'm testing updating Fedora to netcdf 4.9.1 and I'm seeing a new failure when running the tests for the octave-netcdf package.  This might be tricky to track down, but I'm not seeing the failure with the current netcdf 4.9.0 package.  HDF5 is remaining constant at 1.12.1.
The segfault occurs when exiting:
(gdb) bt
#0  0x00007fffcee93eb0 in ?? ()
#1  0x00007ffff5522b63 in H5FD__free_cls (cls=0x555555f09810) at ../../src/H5FD.c:188
#2  0x00007ffff557e57a in H5I__mark_node (key=0x0, _udata=<synthetic pointer>, _info=0x5555555a6c60) at ../../src/H5Iint.c:393
#3  H5I_clear_type (type=<optimized out>, force=false, app_ref=<optimized out>) at ../../src/H5Iint.c:339
#4  0x00007ffff5522af8 in H5FD_term_package () at ../../src/H5FD.c:147
#5  0x00007ffff5466e54 in H5_term_library () at ../../src/H5.c:377
#6  0x00007ffff546771d in H5_term_library () at ../../src/H5.c:460
#7  0x00007ffff546772d in H5close () at ../../src/H5.c:989
#8  0x00007ffff79077dd in octave::load_save_system::~load_save_system (this=<optimized out>, this=<optimized out>) at libinterp/corefcn/load-save.cc:274
#9  0x00007ffff78f75b5 in octave::interpreter::~interpreter (this=<optimized out>, this=<optimized out>) at libinterp/corefcn/interpreter.cc:661
#10 0x00007ffff703ae47 in std::default_delete<octave::interpreter>::operator() (this=<optimized out>, __ptr=0x5555555c62f0) at /usr/include/c++/12/bits/unique_ptr.h:95
#11 std::default_delete<octave::interpreter>::operator() (__ptr=0x5555555c62f0, this=<optimized out>) at /usr/include/c++/12/bits/unique_ptr.h:89
#12 std::unique_ptr<octave::interpreter, std::default_delete<octave::interpreter> >::~unique_ptr (this=<optimized out>, this=<optimized out>) at /usr/include/c++/12/bits/unique_ptr.h:396
#13 octave::application::~application (this=<optimized out>, this=<optimized out>) at libinterp/octave.cc:296
#14 0x0000555555556590 in octave::cli_application::~cli_application (this=<optimized out>, this=<optimized out>) at libinterp/octave.h:377
#15 main (argc=<optimized out>, argv=<optimized out>) at src/main-cli.cc:122
(gdb) up
#1  0x00007ffff5522b63 in H5FD__free_cls (cls=0x555555f09810) at ../../src/H5FD.c:188
188         if (cls->terminate && cls->terminate() < 0)
(gdb) list
183
184         /* If the file driver has a terminate callback, call it to give the file
185          * driver a chance to free singletons or other resources which will become
186          * invalid once the class structure is freed.
187          */
188         if (cls->terminate && cls->terminate() < 0)
189             HGOTO_ERROR(H5E_VFL, H5E_CANTCLOSEOBJ, FAIL, "virtual file driver '%s' did not terminate cleanly",
190                         cls->name)
191
192         H5MM_xfree(cls);
(gdb) print cls
$1 = (H5FD_class_t *) 0x555555f09810
(gdb) print *cls
$2 = {name = 0x7fffcef4c0d0 <error: Cannot access memory at address 0x7fffcef4c0d0>, maxaddr =<PHONE_NUMBER>854775807, fc_degree = H5F_CLOSE_WEAK, terminate = 0x7fffcee93eb0, sb_size = 0x0, sb_encode = 0x0, sb_decode = 0x0,
  fapl_size = 0, fapl_get = 0x0, fapl_copy = 0x0, fapl_free = 0x0, dxpl_size = 0, dxpl_copy = 0x0, dxpl_free = 0x0, open = 0x7fffcee97280, close = 0x7fffcee97230, cmp = 0x7fffcee94170, query = 0x7fffcee93ed0, get_type_map = 0x0,
  alloc = 0x7fffcee93f40, free = 0x0, get_eoa = 0x7fffcee93f70, set_eoa = 0x7fffcee93fa0, get_eof = 0x7fffcee93fd0, get_handle = 0x7fffcee94060, read = 0x7fffcee97610, write = 0x7fffcee940f0, flush = 0x7fffcee94000, truncate = 0x0,
  lock = 0x7fffcee94020, unlock = 0x7fffcee94040, fl_map = {H5FD_MEM_SUPER, H5FD_MEM_SUPER, H5FD_MEM_SUPER, H5FD_MEM_DRAW, H5FD_MEM_DRAW, H5FD_MEM_SUPER, H5FD_MEM_SUPER}}
(gdb) print *cls->terminate
Cannot access memory at address 0x7fffcee93eb0
(gdb) print cls->terminate
$3 = (herr_t (*)(void)) 0x7fffcee93eb0

(gdb) up
#3  H5I_clear_type (type=<optimized out>, force=false, app_ref=<optimized out>) at ../../src/H5Iint.c:339
339                 if (H5I__mark_node((void *)item, NULL, (void *)&udata) < 0)
(gdb) print *item
$6 = {id =<PHONE_NUMBER>03423489, count = 1, app_count = 1, object = 0x555555e33f50, marked = false, hh = {tbl = 0x55555558ebf0, prev = 0x55555558eb90, next = 0x0, hh_prev = 0x0, hh_next = 0x0, key = 0x5555555a6c60, keylen = 8,
    hashv =<PHONE_NUMBER>}}

valgrind:
==166== Jump to the invalid address stated on the next line
==166==    at 0x32D48EB0: ???
==166==    by 0x6D5F579: UnknownInlinedFun (H5Iint.c:393)
==166==    by 0x6D5F579: H5I_clear_type (H5Iint.c:339)
==166==    by 0x6D03AF7: H5FD_term_package (H5FD.c:147)
==166==    by 0x6C47E53: H5_term_library.part.0 (H5.c:377)
==166==    by 0x6C4872C: H5close (H5.c:989)
==166==    by 0x55597DC: octave::load_save_system::~load_save_system() (load-save.cc:274)
==166==    by 0x55495B4: octave::interpreter::~interpreter() (interpreter.cc:661)
==166==    by 0x4C8CE46: UnknownInlinedFun (unique_ptr.h:95)
==166==    by 0x4C8CE46: UnknownInlinedFun (unique_ptr.h:89)
==166==    by 0x4C8CE46: UnknownInlinedFun (unique_ptr.h:396)
==166==    by 0x4C8CE46: octave::application::~application() (octave.cc:296)
==166==    by 0x10A58F: UnknownInlinedFun (octave.h:377)
==166==    by 0x10A58F: main (main-cli.cc:122)
==166==  Address 0x32d48eb0 is not stack'd, malloc'd or (recently) free'd
==166==
fatal: caught signal Segmentation fault -- stopping myself...
==166==
==166== Process terminating with default action of signal 11 (SIGSEGV)
==166==    at 0x6A8EB94: __pthread_kill_implementation (in /usr/lib64/libc.so.6)
==166==    by 0x6A3DAED: raise (in /usr/lib64/libc.so.6)
==166==    by 0x6A3DB9F: ??? (in /usr/lib64/libc.so.6)
==166==    by 0x32D48EAF: ???
==166==    by 0x6D5F579: UnknownInlinedFun (H5Iint.c:393)
==166==    by 0x6D5F579: H5I_clear_type (H5Iint.c:339)
==166==    by 0x6D03AF7: H5FD_term_package (H5FD.c:147)
==166==    by 0x6C47E53: H5_term_library.part.0 (H5.c:377)
==166==    by 0x6C4872C: H5close (H5.c:989)
==166==    by 0x55597DC: octave::load_save_system::~load_save_system() (load-save.cc:274)
==166==    by 0x55495B4: octave::interpreter::~interpreter() (interpreter.cc:661)
==166==    by 0x4C8CE46: UnknownInlinedFun (unique_ptr.h:95)
==166==    by 0x4C8CE46: UnknownInlinedFun (unique_ptr.h:89)
==166==    by 0x4C8CE46: UnknownInlinedFun (unique_ptr.h:396)
==166==    by 0x4C8CE46: octave::application::~application() (octave.cc:296)
==166==    by 0x10A58F: UnknownInlinedFun (octave.h:377)
==166==    by 0x10A58F: main (main-cli.cc:122)

There are quite a lot of iterations through the loop in H5I_clear_type before the segfault.  I have no idea what other information would be useful for tracking this down.

You should try with the newly released hdf5-1.14.0. If fixes a lot of bugs, perhaps this is one of them.

Interesting; is this happening on particular hardware? I'm trying to get our big-endian machine back online to try to track down the other issue you've reported, @opoplawski, and if this is also on specific hardware, let me know.  Thanks!

Seems to happen on all - and definitely on x86_64.

Thanks! That will make the issue easier to track down.  Looking at the traces you provided, I'm trying to pin down at what point a function in libnetcdf is being called?  I'm trying to grab the latest octave release, I assume this test is failing as part of the regular suite of tests, I will see if I can replicate it locally.

Presumably netcdf calls are made during the tests, but at the point of the crash I think we're just closing down the HDF5 library.
I'm afraid this is multiple levels deep - it's not the tests from octave, but from the octave-netcdf package https://gnu-octave.github.io/packages/netcdf/
later I'll try to see if it's sensitive to updating hdf5.

Could it be that both netcdf-c and octave are shutting down the HDF5 library? The netcdf-c one succeeds, and then the octave attempt fails?

I've at least stripped it down to a simple reproducer in octave with the netcdf package installed:
octave -H -q --no-window-system --no-site-file --eval "pkg('load','netcdf');import_netcdf;ncid = netcdf.create('test-netcdf.nc','NC_CLOBBER'); netcdf.close(ncid);"

So it really does seem to be something to do with library tear down in the octave environment as we aren't doing much else.  It also crashed without the netcdf.close(ncid) call, but then you don't get a valid netcdf file.   Since octave is built with HDF5 support, it calls H5close() on exit.  But it still seems like the HDF5 state must be getting corrupted somehow for it to segfault.
I've also just discovered that I've still been building netcdf with -DH5_USE_110_API though I suspect that probably hasn't been needed for ages.  I'm doing some rebuilds without that and with hdf5 1.12.2 and 1.14.0 and will report those results when done.  octave isn't built with and H5_*_API defines so it would be good to make that consistent.

Any chance of running your program with valgrind?

The valgrind output is the same as before - see the initial comment.

Dropping -DH5_USE_110_API didn't have any effect.

Some time ago I changed the netcdf-c code so that it does not depend on H5_USE_110_API or any other macro redefinition schemes that they use at HDF5. Simpler to just call the desired functions directly, and not worry about the redefines of their APIs (a misguided approach, IMO).
Is there a way of telling if the HDF5 library has been closed down?

Still seeing this with netcdf 4.9.2

Investigating.  Thanks!

The same (or very similar?) bug has just been reported for Debian (and reproduced on Ubuntu 23.10) which are using older netcdf and hdf libraries :
https://savannah.gnu.org/bugs/?64999
On my Ubuntu 23.10 (when compiled with -Og -ggdb3):
Thread 1 "octave-gui" received signal SIGSEGV, Segmentation fault.
0x00007fffe01301b0 in ?? ()
(gdb) thread apply all bt
<...deleted...>
Thread 1 (Thread 0x7fffeb8bf880 (LWP 343770) "octave-gui"):
#0  0x00007fffe01301b0 in ??? ()
#1  0x00007ffff38fefec in H5FD__free_cls (cls=0x7fffc8119a30) at ../../../src/H5FD.c:188
#2  0x00007ffff395c288 in H5I__mark_node (key=0x0, _udata=<synthetic pointer>, _info=0x5555555c0550) at ../../../src/H5Iint.c:340
#3  H5I_clear_type (type=<optimized out>, force=false, app_ref=<optimized out>) at ../../../src/H5Iint.c:286
#4  0x00007ffff38fef90 in H5FD_term_package () at ../../../src/H5FD.c:147
#5  0x00007ffff3845f1c in H5_term_library () at ../../../src/H5.c:338
#6  0x00007ffff38463e1 in H5close () at ../../../src/H5.c:1006
#7  0x00007ffff75182e1 in octave::load_save_system::~load_save_system (this=this@entry=0x7fffc80022c0, __in_chrg=<optimized out>) at ../libinterp/corefcn/load-save.cc:271
#8  0x00007ffff74f4b9c in octave::interpreter::~interpreter (this=this@entry=0x7fffc8001470, __in_chrg=<optimized out>) at ../libinterp/corefcn/interpreter.cc:635
#9  0x00007ffff6d6fccb in std::default_delete<octave::interpreter>::operator() (this=this@entry=0x7fffffffddf8, __ptr=0x7fffc8001470) at /usr/include/c++/13/bits/unique_ptr.h:99
#10 0x00007ffff6d6fcf1 in std::unique_ptr<octave::interpreter, std::default_delete<octave::interpreter> >::~unique_ptr (this=0x7fffffffddf8, __in_chrg=<optimized out>) at /usr/include/c++/13/tuple:125
#11 0x00007ffff6d6d34c in octave::application::~application (this=this@entry=0x7fffffffdbf0, __in_chrg=<optimized out>) at ../libinterp/octave.cc:298
#12 0x00005555555566fa in octave::qt_application::~qt_application (this=0x7fffffffdbf0, __in_chrg=<optimized out>) at ../libgui/src/qt-application.h:61
#13 main (argc=1, argv=<optimized out>) at ../src/main-gui.cc:164
(gdb)

This is with
libnetcdf-dev/mantic,now 1:4.9.2-2ubuntu1 amd64
libhdf5-103-1/mantic,now 1.10.8+repack1-1ubuntu1 amd64
Dmitri.

Not sure how much help it is, but I notice that netcdf built with -DENABLE_BYTERANGE=OFF does not seem to have the issue

Is there a test program that produces this error but does not use octave?

Issue is that octave load/unloads Hd5, and when netcdf is unloaded it has not unregstered the new class which is now not in memory.
Adding a finalize call for the HTTP class  fixes the crash.

Something about this bothers me. It seems to me the problem is caused by octave, and it should
be their responsibility to unload hdf5 and netcdf in the correct order.

Also, I have a feeling that this is going to be an ongoing issue because there is at least one other
H5FD plugin (H5FDcore). Also, what about filter plugins?

Something about this bothers me. It seems to me the problem is caused by octave, and it should be their responsibility to unload hdf5 and netcdf in the correct order.

I can make octave unload netcdf before closing, however since netcdf isnt cleaning up itself on unload (ie: unregistering things it registered) the issue isnt fixed. As when octave (and kdf5 closes later on) it still had references to the netcdf class that is no longer in memory.

HDFCore is loaded within the hdf5 library isnt it? - therefor owned by hdf5, so will be there for the lifetime of the hdf5 library being loaded.

For the hdf5filter.c, it looks like the coe already as a unregister call done within nc4_global_filter_action

Thank you for fixing this!  Looks good here.


GValueToV8 not able to handle some Object types

When implementing NonGIClosure (name due to change), I tried to use GValueToV8 to convert objects which are non-introspected. It fails when WrapperFromGObject is called without object_info.
You can find the test implementation here.
Again, segfault comes from g_irepository_find_by_gtype being called with invalid gtype, see https://github.com/romgrk/node-gtk/issues/179.

In PyGObject, the function pyg_value_as_pyobject handles the conversion. The implementation is here. Of course, there is a distinction between basic types and structured types. The latter (which cause the issue above) are handled in value_to_py_structured_type, see here.


Move scenario test code to ballerina-platform/ballerina-scenario-tests repository, test on dev and move to prod

Description:
$Subject

Done on this branch. Will be merged to master once HTTP tests are added.
https://github.com/ballerina-platform/ballerina-scenario-tests/tree/scenario-tests


refactor(admob): add snippets from quickstart-android

As discussed in firebase/quickstart-android#1247, we're moving the admob snippets to this repo.
Snippets added in this PR:

Filename
Snippets added

MainActivity.kt

ads_on_create,load_banner_ad, instantiate_interstitial_ad, create_interstitial_ad_listener, display_interstitial_ad, request_new_interstitial, add_lifecycle_methods

MainActivity.java
ads_on_create,load_banner_ad, instantiate_interstitial_ad, create_interstitial_ad_listener, display_interstitial_ad, request_new_interstitial, add_lifecycle_methods

activity_main.xml
define_ad_layout

build.gradle
gradle_play_config

There are snippets in AndroidManifest.xml which were kept in the quickstarts repo.
I also noticed that the AdListener.onAdFailedToLoad(int) method used here was deprecated in favor of AdListener.onAdFailedToLoad(LoadAdError), so I replaced it.

@rosariopfernandes this is great thank you! I'll make the changes on the doc site to point to these.

@rosariopfernandes this is great thank you! I'll make the changes on the doc site to point to these.


typo

This PR does not affect the produced WebAssembly code.

On Sun, Jun 20, 2021 at 2:58 PM Claudio Russo @.***>
wrote:

@.**** approved this pull request.
Thanks again!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/dfinity/motoko/pull/2615#pullrequestreview-687932423,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADZBJWFYGWPSFL7AJIAMTU3TTY24NANCNFSM467Q7D2Q
.

Incorporated into #2619


sbt and maven output different packaged jar names

This causes problems with the bin/fac script, which uses a hard-coded path to the packaged jar.

Resolved by PR #340


docs: shorten the description for clarity.

Change the first two sentences from
"Lambda Expressions are ideally used when we have something simple to be done an we are more interested in quickly getting the job done rather than formally naming the function. Lambda expressions also known as anonymous functions."
to instead read:
"Lambda Expressions are used when an operation only has to be performed once, meaning that there is no need for defining a function as it will not be used again. Lambda expressions also known as anonymous functions, as they are not named (defined). "

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

Reworded opening explanation to improve clarity.

Thank you for your contribution to the page! 👍
We're happy to accept these changes, and look forward to future contributions. 📝


Feature request: user permissions

Hello,
I am looking for an application that is able to share expenses between a group of people. I found your solution and it looks very promising to me, especially the incoming e2e encryption and the planned multilingual support.
However, I have a question: why does the application not provide user permissions? That is, a user can accidentally or voluntarily delete/edit all other users' data. Are you going to add a permission so that every user, except the administrator, can only edit their own data.
Thank you

This looks to be a duplicate of #76


can not use v-show in slot tag

Vue.js version
2.0.0-rc.6
Vue.component('test', {
  template: '
<slot v-show="isshow"></slot>
',
  data: function(){
     return {
       isshow: false
     }
  }
})

What is Expected?
when i use this component like this it will render nothing
<test>i am test</test>
What is actually happening?
text rendered
but if i change v-show to v-if  it works fine

I think this is because that's a text element and the style display: none cannot be applied to it. So basically it's intended but I'm still unsure.
You can just use v-if

Hello @soluty,
thank you for your filing this issue.
Please follow the guidelines on how to report an issue. In particular, provide an example on www.jsfiddle.net (or a similar service) that reproduces the problem.
Thank you.

@posva I agree. You can't apply display: none to text, it needs a surrounding element.
This should work with v-show:
<test>
  i am test
</test>

This is intended, <slot> is an abstract element, there's no target to apply v-show to.
(FYI this never worked even in 1.0)

you can't use v-show on
but you can put your slot inside a div end then use v-show inside your div like that `

`


:four_leaf_clover: Proposal: DevLake Plugin Improvement

What would you like to added? Why is this needed?
See #513 for the details

@warren830 Would you like to have a try?

Requirements: make the plugin for DevLake production-ready.
For example:

use a helm chart to manage DevLake installation instead of YAML
use Go helmclient to install instead of kubectl apply
adjust the amount of numbers of pods of all the deployments so that there is no single point of failure and enough redundancy
MySQL persistent storage. Local, or other storage? If local, make sure that deleting the MySQL pod won't lose any data.
Other improvements, for example, add more parameters so that the usage of the plugin can be customized.

Hello, I want to try to make this, can you assign it to me?


Add config option to disable dependency on the Gradle check task

Fixes https://github.com/detekt/detekt/issues/5965

They use a sourceSets option which allows defining:

If I'm reading this right, it seems like they don't allow to run checkstyle without being connected to the check/build task (i.e. you specify the sourceSets to be inspected and they will run during check).
Our case is a bit different as we want to allow to run detekt even when not being hooked to check right?

but our plugin has a task per sourceset for the "plain" detekt tasks, so configuring per sourceset would be much more flexible.

Also, I think every single Gradle project only has one check task. Currently, only one detekt task is added to check task. Although I find one issue replacing detekt to detektMain but even after that only one task gets added to check

it seems like they don't allow to run checkstyle without being connected to the check/build task

It's just the task dependencies that are affected by that option:
https://github.com/gradle/gradle/blob/v8.1.1/subprojects/code-quality/src/main/groovy/org/gradle/api/plugins/quality/internal/AbstractCodeQualityPlugin.java#L196-L224
The tasks are still created and enabled and can be run directly. They're just not added as dependents of check.

I think every single Gradle project only has one check task. Currently, only one detekt task is added to check task.

Yes, that's how it is today, but I'm working on a proposed change to the plugin that would change this. Also - if you add the sourceSets option, then you could add additional detekt source set dependencies to the check task much more easily in the meantime.

Hi, @3flex I think when sourceSet.getTaskName(taskBaseName, null); returns detekt here https://github.com/gradle/gradle/blob/1cf537a851c635c364a4214885f8b9798051175b/subprojects/code-quality/src/main/groovy/org/gradle/api/plugins/quality/internal/AbstractCodeQualityPlugin.java#LL217C40-L217C82 then check  task will depend on detekt o/w not. Let me know if I am correct or not.
So you are suggesting if we want to remove detekt from check we need to set the sourceSet to empty for detekt. Right? I am still not clear on what the end-to-end config will look like.

but I'm working on a proposed change to the plugin that would change this.

If in your work you are also addressing https://github.com/detekt/detekt/issues/5965 then feel free to assign this to yourself. And I will close this PR

Let me know if I am correct or not.

Detekt doesn't extend AbstractCodeQualityPlugin so the behaviour of that class isn't directly relevant to the current Detekt Gradle Plugin behaviour - apologies if I've misunderstood your comment.
The work I'm doing will eventually lead to a fix but it won't be ready that quickly since it's dependent on some changes being made for detekt 2.0. I think this PR is fine in the meantime though with the way the plugin is currently implemented.

it's just that the flag may get removed again quite quickly in favour of a new parameter.

I would vote to don't add it then as it's going to be yet another breaking change for the user which we'll have to explain how to migrate from

I'm not 100% sure if that means closing this PR or not. But most likely it will not be in 1.23.0 so I changed the milestone.

I don't think this PR will be necessary in 2.0 as we will remove the dependency on check altogether if I recall correctly.

Let me close this PR. Ideally, code from this PR should not be needed in the final solution. if needed @3flex can look into it


⚠ Bofrost.fr has degraded performance

In 15ba3da, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 990 ms

Resolved: Bofrost.fr performance has improved in 58c73c2.


Pantalla admin-Voluntarios y educadores

The main objective with this issue it is that the users log in as administrators can see the volunteers and educators of the NGO as well as accepting the new requests.
In order to complete it, use the data provided by the backend mora specifically by the partners API.

Story Points: 5
See the discussion in Frontend S2
Powered by Parabol


Uses new styles.

I downloaded the Feature-66 branch and the e2e works, why Travis is failing?

I downloaded the Feature-66 branch and the e2e works, why Travis is failing?

In which resolution did you run the tests? Is it the same used in Travis? Many of the tests seem to be failing because an element is not clickable, maybe with the change in height of the AllergyDialogParameters component some elements fall out of the screen.

I downloaded the Feature-66 branch and the e2e works, why Travis is failing?

In which resolution did you run the tests? Is it the same used in Travis? Many of the tests seem to be failing because an element is not clickable, maybe with the change in height of the AllergyDialogParameters component some elements fall out of the screen.

Thank you @josepvilabadillo. The problem is not related to the resolution. It is because of the animation that we have added for the modals:
.cdk-overlay-pane {
&:not(.fullscreen) {
animation: scaleUp .2s;
}
}
Seems that there is an issue with Protractor as it is not able to click in a button in a modal while in the animation.


Get curated extensions from create-eth repository

https://github.com/scaffold-eth/create-eth/pull/155 should be merged before merging this.

Thanks for tackling this Damu!! Adding extensions will be much smoother now ♥
Should we use this PR to filter out external extensions uploaded to bg app (/builds) that may be duplicated as curated? Or create a new PR instead?
Something like this could do the job:
const formattedExtensions = data
      .filter((ext: any) => !ext.branch.includes("scaffold-eth/create-eth-extensions"))
      .map((ext: any) => {
        const githubUrlParts = ext.branch.split("/");
        const githubUsername = githubUrlParts[3];
        const repoName = githubUrlParts[4];

        let installCommand = `npx create-eth@latest -e ${githubUsername}/${repoName}`;

        if (githubUrlParts.length > 5) {
          const branch = githubUrlParts[6];
          installCommand = `${installCommand}:${branch}`;
        }

        return {
          name: ext.name,
          description: ext.desc,
          github: ext.branch,
          installCommand,
          builder: ext.builder,
          coBuilders: ext.coBuilders || [],
          youtube: ext.videoUrl || null,
        };
      });

Maybe we can do it after merging this PR.

@Pabl0cks @carletex https://github.com/scaffold-eth/create-eth/pull/155 is merged now (and published to create-eth), can we merge this?

Thanks @damianmarti and all for testing nd review 🙌
Just pushed a small tweak at https://github.com/scaffold-eth/scaffoldeth.io/pull/40/commits/e6f84c431507a2350d185eac81a53328eb67a909 so that we take in consideration the version if provided by crated extension json and extensionFlagValue for constructing installCommand since it will be the actual truth for sure as discussed in https://github.com/scaffold-eth/create-eth/pull/161/


Swap two numbers

Write ruby code for swapping two numbers.
BONUS: Do this using two variables only

Assign me I will do it

I'll do it.

@yash-sharma13
@dhananjay425
@Mudrikaa29
Assigned.


[Create New Issue]:

Description
Description:Euclid algorithm and extended Euclid algorithm
Domain
Competitive Programming
Type of Contribution
Documentation
Code of Conduct

[X] I follow Contributing Guidelines & Code of conduct of this project.

/assign


Fix lsp-ui-sideline-actions-icon for EMACS27+

What did you expect to happen?
Icon is displayed in front of code-action
What actually happened?
No Icon is shown, error-message is: "[lsp-ui-sideline]: Error with actions icon: (error Invalid image specification)"
Proposed solution:
lsp-ui-sideline-actions-icon expects an icon-file so set it to lsp-ui-sideline-actions-icon-default in case of EMACS27+

My bad! This was fixed in de924da. Thanks for bringing it to my attention!


alert-relabel list should not be a pointer

/lgtm

/lgtm
Required to unblock the kube rebase, monitoring team will handle the type change.
Since this is the list type, has no effect on the schema. Should always have been considered optional

/lgtm


Support copy files to a subdirectory in app directory

This PR gives a solution for issue #630. Now it's possible to use syntax like:
[start]
  onlyIncludeFiles = [
    '...',
    { from = './templates/index.html.hbs', to = './templates/index.html.hbs' }
  ]

so index.html.hbs is copied inside a templates subdirectory inside the app directory. That's an example that currently fails when using Rocket.
I have an example of a Rocket service that doesn't work on Railway.app because templates' files are copied just in the app directory instead of the template folder.

[X] Tests are added/updated
[X] Docs are updated

I'm definitely in favor of just making onlyIncludeFiles work with directories like a normal person would expect :)

@flybayer Files are copied by Docker, using a --from= then I can not know if ./something is a file without extension or a directory to append to destination or not. I'm not sure if doing COPY --from=0 ./something {app}/something will work for files and for directories. If that could work, I can add that change in few minutes. 😄

I see, I was trying to keep compatibility with current behaviour thinking that maybe it's a problem a breaking change. Then I'll do some breaking changes and that will simplify the changes also. Thx for feedback.

In the past we have just never included files from anywhere but the root of the app. I do agree with @flybayer in that the current behavior is unintuitive.

Maybe also almost uses in the past include the full app directory, that case was not affected by behavior of Docker's COPY.
I have the changes done and I'm reviewing tests. In a little I'll update my branch.

The tests are also failing because the rust musl example is looking for the compiled binary at the incorrect location. That should be a fairly straightforward fix, but lmk if you would like some help updating it!


Syntax highlighting incorrect when using tick; Alphabet'First

On the frontpage the following line of code is incorrectly highlighted:
Put_Line ("Learning Ada from " & Alphabet'First & " to " & Alphabet'Last);

The text between the two single quotes is green, as if this is a string literal.

This is a known problem: the ace editor Ada syntax highlighter currently doesn't understand attributes.


vscode cant fetch metadata (rust-analyser)

I'm trying out wasm-bindgen but vscode (rust-analyser) is stuck at "Fetching: metadata" when I add
[dependencies]
wasm-bindgen = "0.2.74"
to my toml file.
There are no other dependencies.
The issue goes away if I remove the dependency.
Is this a known issue?

I assume you resolved this somehow?

I assume you resolved this somehow?

Yes, it was just normal behaviour. There is some step named like "updating indexes" that takes really long when you dont update cargo frequently.


Split the screen in half

Thanks for the help @kwcantrell, let's close this for the time being. That being said, the code is representative of what we need to split the screen in half.


Prevent isURL call when magicPasteLinks is disabled

For some reason isUrl regex is to slow for big urls with @ in path when paste as text only (cmd + shift + v/ctrl + shift + v)
Example of url: https://example.com/example/abcdedfghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ1234567890@abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ
I changed position of magicPasteLinks check to prevent the issue when this feature is disabled (my case)

@joaovitoras Thank you for the contribution


Adding 'onLongPress' to DataRow, improving DataTable widget.

Description
In the current version of flutter (stable and master), the DataTable widget doesnt' have a "LongPress" event entry into DataRow list. I'm just puting this entry into DataRow class and propagating this until reach the '_buildDataCell' method, where I add the event into 'InkWell' or 'TableInkWell'
Related Issues
There no Related Issues
Tests
No behavior changed, just added new event into existing widget's event
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[X] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[X] I signed the CLA.
[X] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[X] I read the Tree Hygiene wiki page, which explains my responsibilities.
[X] I updated/added relevant documentation (doc comments with ///).
[X] All existing and new tests are passing.
[X] The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
[X] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.

[X] No, no existing tests failed, so this is not a breaking change.
[ ] Yes, this is a breaking change. If not, delete the remainder of this section.

[ ] I wrote a design doc: https://flutter.dev/go/template Replace this with a link to your design doc's short link
[ ] I got input from the developer relations team, specifically from: Replace with the names of who gave advice
[ ] I wrote a migration guide: Replace with a link to your migration guide

This PR has not been updated in a while, so I am going to close it for now. @renenucci feel free to re-open this PR when you are ready to return to it and address the feedback above. Thanks for the contribution! :)


Quickstart edits.

Goals:

Remove the use of a webserver for our examples, but make our examples clear enough that web programmers will be able to easily integrate them
Remove the "Why use Oso?" section from the intro
Shrink the body of actor_has_role_for_resource by hardcoding the roles in the policy
Remove implies from the policy
Cut most of the text that explains the policy in detail (e.g. the structure of resource data), even if we leave some policy code unexplained.
Give examples of when is_allowed will be true and when it will be false [I skipped this, hoping it would be clear from context]
Move register_class into an earlier section
Delete the Calling back into your [Python/JavaScript] code section.

This is the Python code only. I also removed the "Complete Running Example" section, because I believe we don't have a complete example yet!

@dhatch Take a look! If this looks good, I'll do the conversion to Node.


Implement settings functionality

This is eventually going to be merged but the idea for this PR is that it's going to take the settings in the user's account and apply it throughout the website.
As of right now, the functionality works just for the profile page but the plan is to make a common file that returns the settings object so that it can be passed to every webpage.
You will probably run into an error but in order to see the working changes, comment out the common.js link the in the header partial.

Since someone other than @sderacy needs to review this, I can review and merge, but I wanted to let you look over the changes and try running it before I do. Let me know what you think.

Nice job Payton! I can just merge it if you're good with it. Moving forward from this, I'm probably gonna try to implement the settings functionality now.


⚠ Bofrost.lu has degraded performance

In b0db00b, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 927 ms

Resolved: Bofrost.lu performance has improved in c11facf.


Develop a New Dark Theme for Our App

Description:
We want to offer users the option to switch to a dark theme in our app. Your task is to create a new dark theme design and implement it using CSS. Ensure a smooth transition between light and dark themes.

Difficulty: intermediate
Estimated Time: 4-5 hours

Hey Jayesh
Response:
Thank you for your willingness to contribute to this project and work on implementing the dark theme! Your plan sounds great, and we appreciate your enthusiasm.
If you encounter any challenges or have questions during the implementation, don't hesitate to reach out for assistance. We're here to support you and ensure a smooth contribution process.
Please keep us updated on your progress, and once your work is ready for review, create a pull request so that we can provide feedback and merge it into the project.
Feel free to ask any questions or request clarifications as needed. We look forward to your contributions! 😊


Add initial LJ fitting function

Least square function should be working.
Still need to figure out how to call the scf and mp2 energies and incorporate wavefunction classes

Also need to add tests

It looks like you have both a project and quest folders in here. Can you please delete the project folder.

Ill pull that in once thats done, please work on adding good docs and the like after this is through.

Done.
We will work on documentation from now on

@bzhang25 Please ping me when you are ready for this to go in!

Made all suggested changes, added docs

[ ] add tests

[ ]  put in plot function

[ ] make sure function calls to scf and mp2 are correct

Just added tests/test_lj.py


working in the CLI once running

please excuse me if these are basic docker questions vs hassio questions.
I got this up and running very easily on my NUC. I'm used to managing my yaml files from a CLI within the filesystem of my RPI (typically I use Nano), but so far I see that none of my normal CLI commands (including nano) are available from the bash shell within the container.
(Note: I got to the bash shell with this command sudo docker exec -t -i homeassistant /bin/bash). Even the typical hassio CLI commands don't seem to be available.
Any suggestions?

Thank you for reaching out.  We use GitHub for tracking issues, not for providing support.
If you are in need of support, you should try our Community Forum or join our Discord chat server.
You are more likely to get the answer you are looking for in those places.
Thanks! 👍


Updates travis build to trusty, to get a newer JDK

See https://github.com/travis-ci/travis-ci/issues/3259

appears to have a recent JDK, now.
$ java -Xmx32m -version
java version "1.8.0_66"
Java(TM) SE Runtime Environment (build 1.8.0_66-b17)
Java HotSpot(TM) 64-Bit Server VM (build 25.66-b17, mixed mode)


Update zio-interop-reactivestreams to 1.3.2

Updates dev.zio:zio-interop-reactivestreams from <IP_ADDRESS>-2 to 1.3.2.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "dev.zio", artifactId = "zio-interop-reactivestreams" } ]

labels: library-update

Superseded by #122.


Introduce DapperScrollbars

Closes #12903
Closes #12630
Closes #12629
Changes
Introduce DapperScrollbars wrapper for react-scrollbars-custom package as a replacement for FancyScrollbars & react-custom-scrollbars
Implement DapperScrollbars in higher level components as well as areas that were problematic with FancyScrollbars
Style DapperScrollbars to mostly match the appearance of FancyScrollbars except for that the scrollbar track is slightly visible in DapperScrollbars (useful for discerning which scroll component is being used at a glance).
Preview

Gotchas

Partially because the underlying library works a little differently, dropdowns with a menu that is wider than the button must now be explicitly passed a width rather than it being automatically determined. After reviewing the UI this only is needed in a few places.

Tech Debt:

https://github.com/influxdata/influxdb/issues/12960 (Replace FancyScrollbars with DapperScrollbars so we're not supporting both)
Sometimes the scrollbar flickers before disappearing on dropdown menus that don't have enough contents to scroll
All the styles to customize the appearance of DapperScrollbars are relying on !important to override some of the inline styles injected by the library

The library has an option to not inject any inline styles, which allows for more customization, but it doesn't work as expected

Checklist:

[ ] CHANGELOG.md updated with a link to the PR (not the Issue)
[x] Rebased/mergeable
[x] Tests pass
[ ] http/swagger.yml updated (if modified Go structs or API)
[ ] Sign CLA (if not already signed)

Would this help with any of these: #12989 #12987 #12986

@OfTheDelmer it would close #12989


Uncaught TypeError: Cannot read properties of undefined (reading 'length')     at Map (Map.jsx:19:1)

I followed the tutorial but about a week after completing I cant seem to get the 'length' property to work with the GoogleMapReact component without getting this error back. Looking forward to feedback.

How were you able to solve this?
I've been getting the "Cannot read properties of undefined (reading 'length')" error which I believe is the same error that was resolved here.


feat(Consents): Migrating old consent data to new consents

Please delete this line and the text below before submitting your contribution.

Thanks for contributing! If this contribution is for instructor training, please send an email to<EMAIL_ADDRESS>with a link to this contribution so we can record your progress. You’ve completed your contribution step for instructor checkout just by submitting this contribution.
Please keep in mind that lesson maintainers are volunteers and it may be some time before they can respond to your contribution. Although not all contributions can be incorporated into the lesson materials, we appreciate your time and effort to improve the curriculum.  If you have any questions about the lesson maintenance process or would like to volunteer your time as a contribution reviewer, please contact The Carpentries Team at<EMAIL_ADDRESS>

Testing that it is filled in:
>>> from consents.models import *
>>> from workshops.models import *
>>> person_1 = Person.objects.create(
            personal="Neville",
            family="Longbottom",
<EMAIL_ADDRESS>            username="longbottom_neville",
            # # Setting old terms to True to ensure it doesn't affect anything.
            may_contact=True,
            publish_profile=True,
            data_privacy_agreement=True,
            lesson_publication_consent="yes-github"
        )
>>> person_1
<Person: Neville Longbottom<EMAIL_ADDRESS>>>> [ (c.term.slug, str(c.term_option)) for c in Consent.objects.filter(person=person_1).active().select_related("term", "term_option")]
[('privacy-policy', 'None'), ('may-contact', 'None'), ('public-profile', 'None'), ('may-publish-name', 'None')]
>>> exit()
(env) ➜  amy git:(1881/migrate-old-consent-data-to-new-consents) ✗ python manage.py migrate              Operations to perform:
  Apply all migrations: admin, auth, autoemails, consents, contenttypes, dashboard, django_comments, extrequests, fiscal, reversion, sessions, sites, social_django, workshops
Running migrations:
  Applying consents.0006_auto_20210614_1234... OK
(env) ➜  amy git:(1881/migrate-old-consent-data-to-new-consents) ✗ python manage.py shell
>>> from workshops.models import *
>>> from consents.models import *
>>> person_1 =<EMAIL_ADDRESS>>>> [ (c.term.slug, str(c.term_option)) for c in Consent.objects.filter(person=person_1).active().select_related("term", "term_option")]
[('privacy-policy', ' (agree)'), ('may-contact', ' (agree)'), ('public-profile', ' (agree)'), ('may-publish-name', 'Yes, and only use my GitHub Handle (agree)')]

Ensure they're going to the correct values:
>>> person_2 = Person.objects.create(
            personal="Person",
            family="Two",
<EMAIL_ADDRESS>            username="person2",
            may_contact=False,
            publish_profile=True,
            data_privacy_agreement=False,
            lesson_publication_consent="unset"
        )
>>> [ (c.term.slug, str(c.term_option)) for c in Consent.objects.filter(person=person_1).active().select_related("term", "term_option")]
>>> [ (c.term.slug, str(c.term_option)) for c in Consent.objects.filter(person=person_2).active().select_related("term", "term_option")]
[('privacy-policy', 'None'), ('may-contact', 'None'), ('public-profile', 'None'), ('may-publish-name', 'None')]
>>> exit()
(env) ➜  amy git:(1881/migrate-old-consent-data-to-new-consents) ✗ python manage.py migrate consents 0006
Operations to perform:
  Target specific migration: 0006_auto_20210614_1234, from consents
Running migrations:
  Applying consents.0006_auto_20210614_1234... OK
(env) ➜  amy git:(1881/migrate-old-consent-data-to-new-consents) ✗ python manage.py shell
>>> from workshops.models import *
>>> from consents.models import *
>>> person_2 =<EMAIL_ADDRESS>>>> [ (c.term.slug, str(c.term_option)) for c in Consent.objects.filter(person=person_2).active().select_related("term", "term_option")]
[('privacy-policy', 'None'), ('may-contact', ' (decline)'), ('public-profile', ' (agree)'), ('may-publish-name', 'None')]

Test that if a term is missing, the migration does not fail:
>>> from workshops.models import *
>>> from consents.models import *
>>> person_3 = Person.objects.create(
            personal="Person",
            family="Three",
<EMAIL_ADDRESS>            username="person3",
            may_contact=True,
            publish_profile=True,
            data_privacy_agreement=True,
            lesson_publication_consent="yes-orcid"
        )
>>> [ (c.term.slug, str(c.term_option)) for c in Consent.objects.filter(person=person_3).active().select_related("term", "term_option")]
[('privacy-policy', 'None'), ('may-contact', 'None'), ('public-profile', 'None'), ('may-publish-name', 'None')]
>>> term = Term.objects.get(slug="may-publish-name")
>>> term.archive()
>>> exit()
(env) ➜  amy git:(1881/migrate-old-consent-data-to-new-consents) ✗ python manage.py migrate consents 0006
Operations to perform:
  Target specific migration: 0006_auto_20210614_1234, from consents
Running migrations:
  Applying consents.0006_auto_20210614_1234... OK
(env) ➜  amy git:(1881/migrate-old-consent-data-to-new-consents) ✗ python manage.py shell
>>> from workshops.models import *
>>> from consents.models import *
>>> person_3 =<EMAIL_ADDRESS>>>> [ (c.term.slug, str(c.term_option)) for c in Consent.objects.filter(person=person_3).active().select_related("term", "term_option")]
[('privacy-policy', ' (agree)'), ('may-contact', ' (agree)'), ('public-profile', ' (agree)')]

If a term option is missing the migration does not fail.
>>> from consents.models import *
>>> from consents.models import *
>>> person_4 = Person.objects.create(
            personal="Person",
            family="Four",
<EMAIL_ADDRESS>            username="person4",
            may_contact=False,
            publish_profile=True,
            data_privacy_agreement=True,
            lesson_publication_consent="yes-orcid"
        )
>>> [ (c.term.slug, str(c.term_option)) for c in Consent.objects.filter(person=person_4).active().select_related("term", "term_option")]
[('privacy-policy', 'None'), ('may-contact', 'None'), ('public-profile', 'None')]
>>> term = Term.objects.get(slug="may-contact")
>>> term.options
<TermOptionQuerySet [<TermOption:  (agree)>, <TermOption:  (decline)>]>
>>> term.options[1]
<TermOption:  (decline)>
>>> term.options[1].archive()
>>> exit()
(env) ➜  amy git:(1881/migrate-old-consent-data-to-new-consents) ✗ python manage.py migrate consents 0006
Operations to perform:
  Target specific migration: 0006_auto_20210614_1234, from consents
Running migrations:
  Applying consents.0006_auto_20210614_1234... OK
(env) ➜  amy git:(1881/migrate-old-consent-data-to-new-consents) ✗ python manage.py shell
>>> from workshops.models import *
>>> from consents.models import *
>>> person_4 =<EMAIL_ADDRESS>>>> [ (c.term.slug, str(c.term_option)) for c in Consent.objects.filter(person=person_4).active().select_related("term", "term_option")]
[('privacy-policy', ' (agree)'), ('may-contact', 'None'), ('public-profile', ' (agree)')]

note for @pbanaszkiewicz  my linter doesn't appear to run on the file.

note for @pbanaszkiewicz my linter doesn't appear to run on the file during pre-commit. Is it still working?
Oh I see. Maybe it skips migrations locally but not when github actions is run
black................................................(no files to check)Skipped
flake8...............................................(no files to check)Skipped
isort....................................................................Passed
[1881/migrate-old-consent-data-to-new-consents e1847b95] Changed lint issues
 1 file changed, 9 insertions(+), 9 deletions(-)

Thanks for this report. I created this issue: https://github.com/carpentries/amy/issues/1987


[Bug] Blurry old toasts

As you see in the above picture the old toasts appear to be blurry even when focusing them. The issue probably has to do with not clearing the blur effect styling of the components once we hover on them.

Where are you getting this output? I just tried it on svelte sonner site but cant figure out how to replicate this

It is from the documentation where you render a toast. It is also blurry from my perspective.

For me all of them are blurry. Image also from the docs page:

That is so weird. I am not able to replicate the issue. I'll try it on my windows machine.

I solved it with this:
<Toaster
toastOptions={{
style: { filter: 'blur(0)' },
}}
/>

Related https://github.com/emilkowalski/sonner/issues/334#issuecomment-1946105419


fix #6702: return correct required privileges

Required for all non-trivial PRs

[ ] Rebased/mergable
[ ] Tests pass
[x] CHANGELOG.md updated

Change SelectStatement to return required privileges for all Sources.

Seems fine otherwise. I want to revisit at some point the use of the RequiredPrivileges() method in general because I think that it's checking query authorization in the wrong place, but this should work for this issue and 1.0.

👍 on green.


Scales requires a plugin in order to create a node

If intended, panel should reflect that.
If not, then Scales needs a patch or the panel should send something instead.
https://github.com/PufferPanel/Scales/issues/9

Shouldn't need a plugin to create a node, you do need one to make a server though.
Forgot to add to the installer, but I will be shipping some default server plugins with PufferPanel (that are included with Scales).

Still, if it is a constraint that exists, the panel should reflect that. If you delete all plugins for example, it should still apply.

It will become quite obvious when you try to add a server and you can't select anything from the drop-down box. Feel free to submit a PR to add in a little notice if you want though.
I still have no idea how you managed to get that error, unless you sent a blank plugin, in which case we need to look at Scales error handling for that.

This issue was "fixed" by changing how Scales handles installing server and such.


⚠ Samsung has degraded performance

In 3afc4a1, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2309 ms

Resolved: Samsung performance has improved in 5a17a1b.


Make TestOwner can parse globs from test names

Also added a test for glob parsing

Need to update godep after #1843

hummm I screwed up my branch again... Let me open another one properly...


Fix KeyEvent binary compatibility

Fix binary compatibility with pre-1.6.10. Broken in #1245

Please either ignore the failing web test, or rebase on the jb-main.


PB-5792: Add OCP upgrade test for Px-Backup

What this PR does / why we need it:

[x] Add test PXBackupClusterUpgradeTest to upgrade OCP for Px-Backup
[x] Move printK8sCluterInfo() and getClusterNodesInfo() to common.go and make them public
[x] Add ExportSourceKubeConfig() and ExportDestinationKubeConfig() to export kubeconfig to KUBECONFIG
env to use PX helpers moved earlier
[x] Add SwitchBothKubeConfigANDContext() to common.go

Successful run: https://aetos.pwx.purestorage.com/resultSet/testSetID/580101
Which issue(s) this PR fixes (optional)
Closes #PB-5792
Special notes for your reviewer:

How about renaming all instances of 'OCP' to 'Cluster' in the logs, including the PR title?

There is an error at the end of the test case in the aetos link attached.

It's mostly the log collection logic which is returning the error:
[tests.collectPxBackupLogs:#6950] - Error in getting px-backup namespace. Err: can't find PxBackup service [px-backup] from list of services

We'll need to make changes to it which we can do in the next PR if you are okay.


Issue: FHIR bulk loader functionality not picking up .ndjson files from Azure blob storage.

We have a container in blob storage where we are putting our ndjson files. As soon as the file comes into the container, the FHIR bulk loader should pick it up and load it in FHIR server. It was working fine before our service principal client secret got expired and we found out that our blob storage access key got expired. We have updated these both since in the key vault and still we are facing the issue that the FHIR bulk loader is not picking up the ndjson files from the container.

@saurabhmandel - we've just made a commit that should fix your issue with .ndjson files not being picked up from Azure blob storage. Please pull the latest code and try again.

Hi Eric Howard,
Just I have one question regarding this latest code just want to make sure that I am doing it correctly, I have pulled the latest repo as you mentioned so do I need to deploy a completely new FHIR bulk loader service or after pulling the latest code it will just work with old one ?
Thanks,
Saurabh

From: Erik Howard @.>
Sent: Tuesday, October 17, 2023 8:43 PM
To: microsoft/fhir-loader @.>
Cc: Saurabh Rawat @.>; Mention @.>
Subject: Re: [microsoft/fhir-loader] Issue: FHIR bulk loader functionality not picking up .ndjson files from Azure blob storage. (Issue #55)
@saurabhmandelhttps://github.com/saurabhmandel - we've just made a commit that should fix your issue with .ndjson files not being picked up from Azure blob storage. Please pull the latest code and try again.
—
Reply to this email directly, view it on GitHubhttps://github.com/microsoft/fhir-loader/issues/55#issuecomment-1766624820, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BDCZYBU2ZL7WRAGHMGSJFG3X72OAHAVCNFSM6AAAAAA5V4S6OKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONRWGYZDIOBSGA.
You are receiving this because you were mentioned.Message ID: @.***>

@saurabhmandel You will need to redeploy a new FHIR bulk loader service. Let us know if that works!

@saurabhmandel I will close this issue for now, please re-open if the issue persists!


Feature: unittest your function

This PR adds an ability to write unittests for functions.
Fn CLI offers a very first compatibility barrier between your code and Fn server
by allowing developers to perform black-box testing using the following CLI call with a function's folder:
fn test

This CLI call depends on test.json file that contains an input and the output data for the black-box testing.
Starting v0.0.33 FDK-Python will provide a testing framework that allows performing unit tests of your function's code.
The framework is an extension to testtools testing framework, coding style remain the same, so, write your tests as you've got used to.
Here's the example of the test suite:
from fdk import fixtures
from fdk.tests import funcs

class TestFuncToTest(fixtures.FunctionTestCase):

    content = "OK"

    def setUp(self):
        super(TestFuncToTest, self).setUp(
            self.content, funcs.content_type)

    def tearDown(self):
        super(TestFuncToTest, self).tearDown()

    def test_response_data(self):
        self.assertResponseConsistent(
            lambda x: x == self.content,
            message="content must be equal to '{0}'"
            .format(self.content)
        )

    def test_response_header_presence(self):
        self.assertInHeaders(
            "content-type",
            message="header 'content-type' "
                    "must be present in headers")

    def test_response_header_value(self):
        self.assertInHeaders(
            "content-type", value='application/xml',
            message="header 'content-type' "
                    "must be present in headers with the exact value")

As you may see, the framework provides new assertion methods like:

assertInHeaders - allows to assert header(s) presence in response
assertInTime - allows asserting the time necessary for a function to finish
assertNotInTime - allows asserting the time within a function was not able to finish
assertResponseConsistent - allows asserting function's response content consistency by accepting a callable object that must return a boolean value that states the consistency

Closes: #17

The very final version of func.yml may be:
import fdk
import ujson

from fdk import fixtures

def handler(ctx, data=None, loop=None):
    name = "World"
    if data and len(data) > 0:
        body = ujson.loads(data)
        name = body.get("name")
    return {"message": "Hello {0}".format(name)}

class TestFuncWithData(fixtures.FunctionTestCase):
    content = ujson.dumps({"name": "John"})

    def setUp(self):
        super(TestFuncWithData, self).setUp(
            self.content, handler, fn_format="json")

    def tearDown(self):
        super(TestFuncWithData, self).tearDown()

    def test_response_with_data(self):
        def assert_data(data):
            return {"message": "Hello John"} == data

        self.assertResponseConsistent(
            assert_data,
            message="content must be equal to '{0}'"
            .format({"message": "Hello John"})
        )

    def test_in_time(self):
        self.assertInTime(1)

class TestFuncWithoutData(fixtures.FunctionTestCase):
    content = ""

    def setUp(self):
        super(TestFuncWithoutData, self).setUp(
            self.content, handler, fn_format="cloudevent")

    def tearDown(self):
        super(TestFuncWithoutData, self).tearDown()

    def test_response_without_data(self):

        def assert_data(data):
            return {"message": "Hello World"} == data

        self.assertResponseConsistent(
            assert_data,
            message="content must be equal to '{0}'"
            .format({"message": "Hello World"})
        )

    def test_in_time(self):
        self.assertInTime(1)

if __name__ == "__main__":
    fdk.handle(handler)

this might end up being a part of the boilerplate for faster testing.


Update dependencies

Changes
Go to 1.17, Shipwright Build to 0.7.0, Tekton to 0.30.0, Kubernetes to 1.21. Other small changes:

Removed the shp build from the unit test action. It is not needed there, and the build happens in the e2e suite anyway.
Fixed map_value_test.go to not expect an order of the stringified map.

Submitter Checklist

[ ] Includes tests if functionality changed/was added
[ ] Includes docs if changes are user-facing
[x] Set a kind label on this PR
[x] Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.
Release Notes
Update compile and test dependencies

/approve
/lgtm


[Enum Request] Table 7000005 - Field 6 "Dealing Type"

Hello,
we need to be able to extend the options of field 6 - "Dealing type" in table 7000005 - "Bill Group".
Could you please change it into an enum?
(The same field is in table 7000006 - "Posted Bill Group" and table 7000007 - "Closed Bill Group")
Thanks

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: .


VS Code 1.94.0-insider: Value is not accepted.

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version: 1.94.0-insider
OS Version: 23H2 (22631.4112)

Steps to Reproduce:

Install PowerShell and WSL extensions
Connect to WSL
Enter the settings of vscode insider
Check whether powershell.powerShellAdditionalExePaths and powershell.powerShellDefaultVersion exist.
In fact, the PowerShell extension cannot be enabled in WSL of vscode insider. Therefore, adding the PowerShell option in "settingsSync.ignoredSettings" will issue a warning: Value is not accepted.

In fact, the PowerShell extension cannot be enabled in WSL of vscode insider. Therefore, adding the PowerShell option in "settingsSync.ignoredSettings" will issue a warning: Value is not accepted.

It's not clear what the issue is. Can you please explain?

The problem is solved in the latest version of vscode-insider


Mindfulness and Meditation Programs

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when I have overloaded work and I get anxious. In that case, some deep breathing exercises are really helpful.
Describe the solution you'd like
Offer guided mindfulness and meditation programs led by certified instructors or mindfulness coaches.
Provide audio and video sessions tailored to different skill levels, durations, and meditation techniques to promote relaxation and stress reduction.
Describe alternatives you've considered
Offer stress reduction tools and relaxation techniques, such as guided imagery, progressive muscle relaxation, breathing exercises, and biofeedback games. Incorporate interactive features and feedback mechanisms to enhance engagement and effectiveness.
Please assign me this issue under GSSOC'24.

@aditikhare16 kindly elaborate.

@aditikhare16 kindly elaborate.

We can add a feature for guided and timed multiple meditative exercises, yoga in general, yogas for specific purposes, etc.

@aditikhare16 assigned


WinUI 3 Desktop - Binding does not work

In WinUI 3 Preview 1 Desktop - Binding markup extensions are not working correctly in some cases (see comments in XAML). Mode OneWay should be implicit, and all bellow mentioned bindings should work properly.
Steps to reproduce the bug
  <StackPanel>
    <!--  MyTextBox1 x:Bindng works. Text is updated from VM  -->
    <TextBox x:Name="MyTextBox1" Text="{x:Bind ViewModel.NewProductName, Mode=TwoWay, UpdateSourceTrigger=PropertyChanged}" />
    <!--  MyTextBox2 Binding does not work. Text is not updated from VM  -->
    <TextBox x:Name="MyTextBox2" Text="{Binding ViewModel.NewProductName, Mode=TwoWay, UpdateSourceTrigger=PropertyChanged}" />

    <!--  Command x:Bind works  -->
    <Button Command="{x:Bind ViewModel.AddNew}" Content="Add (works)" />
    <!--  Command Binding does not work  -->
    <Button Command="{Binding ViewModel.AddNew, Mode=OneWay}" Content="Add (does not work)" />

    <!--  Command Binding on nested property does not work  -->
    <Button Padding="5"
            Command="{Binding ViewModel.ListViewModel.ClearFilter, Mode=OneWay}"
            Content="Reset" />
    <!--  Command x:Bind on nested property does not work without Mode  -->
    <Button Command="{x:Bind ViewModel.ListViewModel.ClearFilter}" Content="xBindWithoutMode" />
    <!--  Command x:Bind on nested property works with explicit Mode OneWay.  -->
    <Button Command="{x:Bind ViewModel.ListViewModel.ClearFilter, Mode=OneWay}" Content="xBindWithOneWayMode" />
  </StackPanel>

  public sealed partial class ProductsView : UserControl
  {
    public ProductsView()
    {
      this.InitializeComponent();

      var productsEntityChangesViewModel = App.Kernel.Get<ProductsEntityChangesViewModel>();

      ViewModel = productsEntityChangesViewModel;
    }

    public static readonly DependencyProperty ViewModelProperty = DependencyProperty.Register(nameof(ViewModel), typeof(ProductsEntityChangesViewModel), typeof(ProductsView), new PropertyMetadata(null));

    public ProductsEntityChangesViewModel ViewModel
    {
      get { return GetValue(ViewModelProperty) as ProductsEntityChangesViewModel; }
      set { SetValue(ViewModelProperty, value); }
    }
  }

NuGet package version:
[Microsoft.WinUI 3.0.0-preview1.200515.3]

Device form factor
Saw the problem?

Desktop
Yes

Mobile

Xbox

Surface Hub

IoT

@tomasfabian thanks for the report, can you clarify what does not work means.  You are seeing the wrong value, or no value at all, ect. Any additional feedback to help us understand the issue fully. Thanks.

@StephenLPeters not at all, I'm glad that I can help the WinUI team.
I'm attaching a solution which simulates the above mentioned issues. By not working I mean that the textbox text is not refreshed in the UI and the button commands are not executed or CanExecute is not evaluated.
Steps to reproduce the issues in the sample:
Buttons are reseting the property value in the VM bound to the corresponding TextBox.Text

first section in the example demonstrates that the MyTextBox2.Text is not refreshed in the UI. Button with content "Command is not executed" does not call MyViewModel.AddNew.Execute.

the second section demonstrates a nested ViewModel set only after a user action, in this case after "Set Nested ViewModel" button clicked. Before this action all bellow buttons should be disabled, but they are active. After the NestedViewModel property was initialized, only the button with x:Bind and Mode=OneWay can be executed.

Bindings.zip
Hopefully this will help.
I also found a problem with ObservableCollection notifications, but it has already been reported in another issue.

@Ratcha9 thx for your insight.
I converted a WPF app to a WinUI 3 Desktop app. That's why I also tested "legacy" bindings. WPF doesn't have x:Bind. The default mode in .Net Framework < 4.5 was TwoWay, if I remember it correctly. Nowadays it is OneWay (also in .Net Core WPF) AFAIK.
UWP mode OneTime is maybe too restrictive, at least for MVVM apps. For ICommands its unusable as I found out. On the other hand it could be good enough for MVU refreshes, but I didn't try it.
I didn't set the DataContext, I expected a default Binding. Is it something similar to WPF, where it was necessary to set the Content of ContentControls?
      <ContentControl Content="{Binding}"
                      ContentTemplate="{TemplateBinding RightSideContentTemplate}" />

@StephenLPeters I tried to override the default BindMode based on the UWP documentation @Ratcha9 posted.
<UserControl x:Class="Bindings.Views.TestUserControl"
             x:DefaultBindMode="OneWay"

Please try it out in the solution I attached. In the TestUserControl it enabled the button with content xBindWithoutMode, but only for one time. Actually the "xBindWithOneWayMode" button was disabled after first click, too. Thank you

@StephenLPeters my mistake. It was disabled due to CanExecute. It works correcly, I apologize.

Hey no problem, if I'm reading the thread right does that mean your issue is resolved or are there still outstanding issues beyond the "OneTime is maybe not the correct default" issue?

My experience is that legacy bindings do not update the target property, when the the PropertyChanged event is raised, regardless of setting the DataContext property or not.

@StephenLPeters  {Binding} still doesn't work for me. The initial value is correct, but it does not update.
You may examine https://github.com/Ratcha9/winui_inpc.

@StephenLPeters I think that the "UWP" x:Bind works correctly in case that OneTime is the default mode (chosen for performance reasons). I didn't have experience with x:Bind. We all should realize that we are coming from different target frameworks. I'm a big fan of unification.... so I'm super excited....
I still think that the "classical" Bindings are not working correcly.

I still think that the "classical" Bindings are not working correcly.

@tomasfabian I'm ramping up on this thread now. Can you clarify that? I get the confusion over the default of OneTime (certainly that one has tripped me up many times). This issue was raised against WinUI3 preview - do you observe the same behavior with inbox UWP XAML (not using WinUI3)? As in, are you seeing a regression relative to UWP, or a lack of unification relative to where you started (WPF)? That matters for us in if this is a bug report (regression from inbox XAML), or a feature request (unification needed, yes please).

@chrisglein we provided you example solutions, you can try them.

I still think that the "classical" Bindings are not working correcly.

I further investigated this issue. It looks like that the bound view model property initially sets the value in the UI with OneTime mode. After that the bound view model property is only refreshed from the UI like in OneWayToSource mode. The direct update of VM property does not refresh the UI anymore.
In my opinion in case of "classical" Bindings the view doesn't hook/listen to the PropertyChange event, even if I explicitly set TwoWay or OneWay binding in the XAML.
I tried the same code in Blank app (Universal Windows) and there it is working perfectly. So from this point of view it looks like a regression bug.
Hopefully this will help.

This command was not bound neither. I don't know whether it is due to the dependency property or because it is a nested property. But this one doesn't work neither in UWP:
<Button Command="{Binding ViewModel.Update}"/>

public static readonly DependencyProperty ViewModelProperty = DependencyProperty.Register(nameof(ViewModel),
          typeof(MainViewModel),
          typeof(MainPage),
          new PropertyMetadata(null));

        public MainViewModel ViewModel
        {
          get => GetValue(ViewModelProperty) as MainViewModel;
          set => SetValue(ViewModelProperty, value);
        }

And commands bound to null values shouldn't be disabled?

https://github.com/Ratcha9/winui_inpc.

Hi, I was trying to run  https://github.com/Ratcha9/winui_inpc but it fails on launch. Any idea?

This is fixed in WinUI3 Preview2. Thanks!


Able to apply multiple filters

Fixes issue #50

It looks like you can apply multiple filters, but if there aren't any movies with the select filter, all movies show up. Please fix and resubmit.

Still need to fix open issue. Creating new issue so this can close.


Missing values support for inference

Description
This PR is a continuation of oneDAL missing values support from scikit-learn-intelex side.
Changes proposed in this pull request:

Changing the logic of all three model builders (XGBoost/LightGBM/Catboost) to extract information about desired behavior in case of missing values and pass it to oneDAL.
Removing checking for missing values, as far as it produced false positive results and is not required now.

I think these changes depend on onedal 2023.2 version, so please add versioning here as well

/intelci: run

/intelci: run

Restarted CI, after update of oneDAL master:
https://ecmd.jf.intel.com/commander/link/jobDetails/jobs/edf64f3e-f3af-f15d-aeed-a4bf010d0e2e


Update readme with specific esp32 version

Update the readme for the OpenGlass firmware with the specific version of Expressif Arduino esp32 platform to install

C:\Users\Franci Penov\src\OpenGlass\firmware>arduino-cli compile -u -p COM6 -b esp32:esp32:nora_w10:PSRAM=opi
Sketch uses 979353 bytes (74%) of program storage space. Maximum is 1310720 bytes.
Global variables use 48788 bytes (14%) of dynamic memory, leaving 278892 bytes for local variables. Maximum is 327680 bytes.
esptool.py v4.5.1
Serial port COM6
Connecting...
Chip is ESP32-S3 (revision v0.2)
Features: WiFi, BLE
Crystal is 40MHz
MAC: 74:4d:bd:95:bb:88
Uploading stub...
Running stub...
Stub running...
Changing baud rate to 921600
Changed.
Configuring flash size...
Flash will be erased from 0x00000000 to 0x00003fff...
Flash will be erased from 0x00008000 to 0x00008fff...
Flash will be erased from 0x0000e000 to 0x0000ffff...
Flash will be erased from 0x00010000 to 0x000fffff...
Compressed 15104 bytes to 10430...
Writing at 0x00000000... (100 %)
Wrote 15104 bytes (10430 compressed) at 0x00000000 in 0.3 seconds (effective 438.4 kbit/s)...
Hash of data verified.
Compressed 3072 bytes to 146...
Writing at 0x00008000... (100 %)
Wrote 3072 bytes (146 compressed) at 0x00008000 in 0.1 seconds (effective 316.3 kbit/s)...
Hash of data verified.
Compressed 8192 bytes to 47...
Writing at 0x0000e000... (100 %)
Wrote 8192 bytes (47 compressed) at 0x0000e000 in 0.1 seconds (effective 530.6 kbit/s)...
Hash of data verified.
Compressed 979712 bytes to 593853...
Writing at 0x00010000... (2 %)
Writing at 0x0001b928... (5 %)
Writing at 0x00028def... (8 %)
Writing at 0x000344cd... (10 %)
Writing at 0x00041fed... (13 %)
Writing at 0x00047af2... (16 %)
Writing at 0x0004d536... (18 %)
Writing at 0x00052ee0... (21 %)
Writing at 0x000588e9... (24 %)
Writing at 0x0005e3a2... (27 %)
Writing at 0x00063ae1... (29 %)
Writing at 0x00068cfa... (32 %)
Writing at 0x0006e068... (35 %)
Writing at 0x000733ce... (37 %)
Writing at 0x00078427... (40 %)
Writing at 0x0007e3c9... (43 %)
Writing at 0x00084067... (45 %)
Writing at 0x00089994... (48 %)
Writing at 0x0008f2ef... (51 %)
Writing at 0x00094a88... (54 %)
Writing at 0x0009a113... (56 %)
Writing at 0x000a0c9c... (59 %)
Writing at 0x000a6720... (62 %)
Writing at 0x000ac09d... (64 %)
Writing at 0x000b28e8... (67 %)
Writing at 0x000b8235... (70 %)
Writing at 0x000bd866... (72 %)
Writing at 0x000c2ea7... (75 %)
Writing at 0x000c8679... (78 %)
Writing at 0x000cdfd5... (81 %)
Writing at 0x000d418c... (83 %)
Writing at 0x000dc4f1... (86 %)
Writing at 0x000e4d8d... (89 %)
Writing at 0x000ed39b... (91 %)
Writing at 0x000f26f4... (94 %)
Writing at 0x000f7ef8... (97 %)
Writing at 0x000fd9f6... (100 %)
Wrote 979712 bytes (593853 compressed) at 0x00010000 in 7.6 seconds (effective 1026.1 kbit/s)...
Hash of data verified.

Leaving...
Hard resetting via RTS pin...

Used library      Version Path
I2S               1.0     C:\Users\Franci Penov\AppData\Local\Arduino15\packages\esp32\hardware\esp32\2.0.17\libraries\I2S
ESP32 BLE Arduino 2.0.0   C:\Users\Franci Penov\AppData\Local\Arduino15\packages\esp32\hardware\esp32\2.0.17\libraries\BLE

Used platform Version Path
esp32:esp32   2.0.17  C:\Users\Franci Penov\AppData\Local\Arduino15\packages\esp32\hardware\esp32\2.0.17

@WeldFire can you merge, as I don't have permissions. Or maybe @Bentlybro or @kodjima33?

I ran the command: arduino-cli core install<EMAIL_ADDRESS>and got the following output:
Error during install: Platform<EMAIL_ADDRESS>not found: required version 2.0.17 not found for platform esp32:esp32

How do I fix this?


fix #14

This is the pull request to fix issue #14.
It applies the fix provided by @vien20010, which was later approved by @arcress0.
The problem is a bug in the GetUserInfo-function, resulting in users of ipmiutil not being able to change the password of an ipmi-user

This was included in ipmiutil-3.1.9-2 but needs to be merged here.


Parallel unit ID handling in Modbus RTU

I'm submitting a ...  (check one with "x")
Problem

( x ) unexpected behavior

Current behavior
Modbus RTU (serial mode) encounters timeout issues when using multiple slaves and when "Unit ids in parallel" is enabled in modbus-client (which is enabled by default). Issue is solved when this option is disabled.
Expected behavior
As far as I know, Modbus RTU slaves should be addressed sequentially, not in parallel. Therefore this feature should not be allowed in serial mode.
Minimal reproduction of the problem with instructions

Configure for RTU operation.
Leave "Unit ids in parallel" checked.
Try to address multiple slaves at the same time.

Your Environment
Please tell us about your environment:

( x ) I am using just the Node-RED package and got modbus-serial package installed with it

Device :

( x ) Raspbian: custom

node-red-contrib-modbus version: v5.13.1

Node: (min. 10.x)
node --version = v12.16.3

it should get switched off on change to serial, but it should be free to configure

could reopen with a PR

I am trying to use multiple solo temperature controllers in series with 1 rs485 - usb. I'm not getting any errors in node red but I'm also not getting outputs. I am trying to extract data using the correct unitids and the correct parameter. Any ideas why?

a) do not use parallel unit-ids option - this just for TCP
b) try to start with one, then two etc.
c) try to play with the delay of the queue to send the messages with some delay like 200 (ms)


Enable assertions

Codecov Report
Base: 45.73% // Head: 45.73% // No change to project coverage :thumbsup:

Coverage data is based on head (d69d7ad) compared to base (6bb5032).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #155   +/-   ##
=========================================
  Coverage     45.73%   45.73%
  Complexity      413      413
=========================================
  Files           108      108
  Lines          2038     2038
  Branches        223      223
=========================================
  Hits            932      932
  Misses         1061     1061
  Partials         45       45

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Prepare telemetry-generator build step is broken

See

https://github.com/microsoft/FluidFramework/pull/20097/files
https://dev.azure.com/fluidframework/internal/_build/results?buildId=245676&view=results

Was this perhaps fixed in #20113? cc @alexvy86

Was this perhaps fixed in #20113? cc @alexvy86

Indeed. We should be fine now Vlad, and we have an ADO item tracking the creation of a new pipeline that builds telemetry generator so this kind of issue can't slip through again.


[DOCFIX] change English punctuation to Chinese punctuation

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/800/
Test FAILed.


Implement md option to multiscale calculation and some relating modifications

MD option (use_ehrenfest_md=y) became available with multi-scale calculation.
Then, new input keywords was implemented:
set_ini_coor_ver=y/n
read_wfn_k_ms=y/n
which enable to read atomic coordinates, velocities, and ground state wave-function of each macro-grid point separately.
For convenience to treat tons of input/output files, directory structure was changed: these all files are put in "multiscale" directory and the files for each macro-grid point are put in "MXXXXXX" (e.x. M000001/, M000002/ ; macro-grid point index) and files along time evolve are put in "RT_Ac".

Thank you, I will send the modified test routine...


Right click to copy object

It would be really nice in the Log monitor if upon right clicking part of the application state to have the option to copy the selected object / children as an object.. thoughts?

Yes, it's something which would be great to have, and was suggested in https://github.com/gaearon/redux-devtools-log-monitor/issues/60 as well. If you want to contribute to the implementation, it should be done in react-json-tree as I wrote there.
Closing in favour of that issue as it's not related directly to this repo.


docs: Use uv in readthedocs, RtD AddOn migration

Overview
Description of the changes proposed in this pull request:
Use uv in a custom RtD build (at least, until it's available as a standard option in RtD). This is noted in the RtD documentation as a standard recipe: LINK.
Impact: build times are now reduced by 50s, or 26% faster than before.
Before:

After:

Discussion
Side effect: ReadtheDocs addon will be enabled by default as a result of using build commands (though, it's going to be the default for ALL sphinx projects from 7th October 2024 anyway, even without build command being used). Read more about the migration plan here.
There is a note there about having to update conf.py in the above migration plan (Section LINK), I'm not sure whether it applies to us or not, but without it, the doc build still seems to run fine and produce the correct output (?)
So I've left out that change for now.

Should we consider using a lockfile to pin all dependencies and transitive dependencies, as recommended by the ReadTheDocs guide to reproducible builds?
We could create the locked dependencies with:
uv pip compile pyproject.toml --extra docs -o docs/requirements-docs.txt

We would also want to remove exact dependency pins in pyproject.toml, as these would now represent constraints rather than exact pins.

Going further: should we consider using a lockfile to pin all dependencies and transitive dependencies, as recommended by the ReadTheDocs guide to reproducible builds?

Sure, I think that's a good idea!


"I encountered a failure when installing software on Windows. The log is as follows:

[Errno 13] Permission denied: 'C:\Program Files\Wladislav Radchenko\Wunjo\app_packages\functorch\_C.cp310-win_amd64.pyd'

Hi. You have installed Wunjo for admin root, but open by user root, this reason why you get permission not found, because user bot have permissions to download torch in folder created admin. You have 2 way:

Reinstall Wunjo only for current user (not for all).
Navigate to the Wunjo directory app, open the console, and enter the following command:  icacls * /grant:r "Users:(R,W)" /T, where Users this name of user group.


gpu_config.mk is not found

Sorry for the repetitiveness.
In 19.2, it says to rename gpu_config.mk, but gpu_config.mk does not exist.

Sorry for the late response. I've pushed cpu_config.mk and gpu_config.mk in tvm_rpc app directory. This config just fitted my previous experiments, so you may need to change something. The detailed tutorial is at https://tvm.apache.org/docs/how_to/deploy_models/deploy_model_on_android.html.


RFC: Add option to instrument functions with specific calls in them

As a first solution for #198 I added the option to instrument functions that have specific calls in them. I.e. instrument all functions that make a call to bar where bar can be set on the command line.
I can't think of other use-cases than #198, right now, but there might be some hence this question to check if there's interest and I should post the PR.
(For #198 I realized that may be better solved by unwinding the stack upon a trace callback)

So I believe this could be accomplished relatively easily by inspecting the control-flow-graph dyninst provides for each function. I'll look into it and get back to you

Just to emphasize yes I know it can be done, I have a patch already would you be interested in it?

Yeah! I love contributions, feel free to open a PR.


Another server that uses harbor

Hey there, I've been a pretty avid Harbor user and I noticed on your Spigot page you have a "servers that use harbor" category.
I host a server called Friends Vanilla, whose goal is to stay online for a lifetime. Would you want to add it?
https://www.friendsvanilla.net/
The server IP is friendsvanilla.net
If not I totally understand, was just wondering if you wanted another server to add to your list ;)

Is the server a publicly joinable server

Yes it is, and while it is in beta right now everyone can join and we are accepting new players. Similarly, I am almost completed with being in beta and it will be releasing fully (aka I will begin advertising) in about a month or two.
It is fully joinable and playable by anyone right now, however.

I've added your server to the Harbor page. Sorry about the wait!

No problem! Thanks for considering :)


[Feature] 垂直桑基图如何设置节点的水平位置呢？How to custom node's horizontal position on a vertical sankey?

What problem does this feature solve?
如何实现垂直桑基图的两侧节点靠边？nodeGap只能统一设置
What does the proposed API look like?
--

Yes, it is annoying that the nodeGap could not set for individual columns but only could be set uniformly across each column which create something informative like the below one:

Instead if we can do it on inidividual column or automatically set to identify proper node gaps for each column, it will be very likely be more useful.

@gmhhope

@gmhhope
Thank you. I will think about it


Superforms and sveltekit-flash-message integration examples

I am currently using superforms and have been playing around with sveltekit-flash-messages at the same time, according to https://superforms.rocks/flash-messages the two projects should work seamless between each other, but do you have a working sample of such a project? I browsed through you list of playgrounds, but only found normal superforms projects. This would help a lot.
Thanks!
Ben

Unfortunately sveltekit-flash-message doesn't play well with Stackblitz, but using it is just as simple as setting it up and throw its redirect function. Here's a gist: https://gist.github.com/ciscoheat/ad9e5c6279fb3502514df1964f67c577
That should work in most cases, but if you need some form-specific integration, see if the documentation helps.

Managed to work it out based on documentation.


Finish styling of the cocktails page

The cocktails page needs some fine tuning like margin/padding between blocks and handling the different breakpoints for all recipes correctly

also, there's some bugs with the load more functionality.
initially, missing one in the middle:

when you load more, missing two:

press load more again, now seems to look right.
then you press load more again,again one missing:

press again, two missing.
press again, now really interesting: one is doubled!

when the load more button is pressed, it stays in hover mode until you click into the white area of the page.

Right, the loading function needs some improvement, too

@RemoLiechti I created a separate issue for the button as it is a general problem. #52


[ENH] Allow the Compare window to be resized and look at a Diff tool rather than a line by line config

🔵 Describe the bug:
The Compare window doesn't keep buttons inside it while resizing.
(Extra low priority of course.. )
🔵 To reproduce: (Steps to reproduce the behavior)

Go to https://wowlazymacros.com/t/bam-holy-paladin-gse3-one-button-with-mouseover-heals/24822
Copy the macro
Import it in GSE 3
Import it one more time, at this moment, you should see the Compare window
Resize the window

🔵 Screenshots:
https://user-images.githubusercontent.com/1732773/125202059-406d8300-e272-11eb-9be7-a56c0b3f2317.mp4
🔵 Expected behavior:
Buttons should stay inside the Sequence Debugger window when resizing.
Desktop
OS: Windows 10 64bits pro
Hardware: nvidia GTX 1070 8GB - driver: 471.11
Game Version
World of Warcraft Shadowlands version <IP_ADDRESS>335 (French language)
GSE Version
Version: 3.0.28-3-gb3bf7ef

This window was never written with resizing in mind.  The bug is that you are able to resize it.  It needs to be rewritten to allow for resizing in general.
It might also be worth showing the differences rather than the whole objects.

Other changes in #1450 will over take this and replace it.


Prevent off-heap memory explosion when request is stacking.

If request is stacking (e.g sentry server is down),  new ClientRequest will be added to agent.requests[]  and each ClientRequest uses Buffer. As clientRequest not consumed, process memory usage will explosive growth even though V8 memory usage is low.

Oh, this looks good. :)
Would it be possible to add a test for this, please? I'll review the code better in the morning.

@benvinegar thoughts on this? It seems reasonable to me, but not sure if there's a better pattern or some semaphore type thing we can just pull in instead?
I wasn't familiar with this internal globalAgent object, which is pretty neat. Not sure if we should leverage that like in this patch, or if we should keep track of it ourselves inside the transport. Or if it matters.

The implementation of the patch seems sound, but we need tests before accepting. I also think, stylistically, we need a few things:

Fix mismatched indentation.
No underscore prefixed var names.

@MaxBittker – can you add a test and see if we can get this landed?

status is that it's applied to master locally and passes existing tests, i just need to figure out how to write a new test for this

Moved to https://github.com/getsentry/raven-node/pull/369


[Sanjeev] Fix the Unknown file extension ".ts" error in Playwright test caused by "type: module"

Fix for #223

It worked for me also, I have node v16.15.1 on Mac

Hi folks. I ran the procedure yesterday and all went smooth. It seems that we need to find the problem on Sanjeevs configuration. Could it be, that he has installed Playwright before and chosen the javascript option? Just an idea, I have no clue if this is an issue.
Screenshot from the Playwright installation docu.

Let us know, if you need further help 👍

Sveltekit applications are ES-Modules

@ISanjeevKumar thank you for raising but lets keep vanilla Sveltekit configuration as it will create other problems, we can help debug your issue in EddieHub Discord http://discord.eddiehub.org


Update PinMappingsDB.md (#270)

Update PinMappingsDB.md

Update PowerShell.md

Update PowerShell.md

Update PinMappingsDB.md

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

windows-iotcore/connect-your-device/PowerShell.md
:white_check_mark:Succeeded

windows-iotcore/learn-about-hardware/PinMappings/PinMappingsDB.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Removed windows warnings

Signed-off-by: ahcorde<EMAIL_ADDRESS>

Builds have more than 200 warning build on Windows. This PR remove all of them

Argh, I forgot that #59 still had 4 C4251 warnings coming from ignition::rendering::MeshDescriptor which I couldn't figure out how they slipped through the pragmas.
[92.250s]   Building Custom Rule C:/Jenkins/workspace/ign_sensors-pr-win/ws/ign-sensors/test/integration/CMakeLists.txt
[92.359s]   air_pressure_plugin.cc
[98.156s]   air_pressure_plugin.obj : MSIL .netmodule or module compiled with /GL found; restarting link with /LTCG; add /LTCG to the link command line to improve linker performance
[98.359s]   Generating code
[103.656s]   Finished generating code
[103.875s]   INTEGRATION_air_pressure_plugin.vcxproj -> C:\Jenkins\workspace\ign_sensors-pr-win\ws\build\ignition-sensors4\bin\Release\INTEGRATION_air_pressure_plugin.exe
[105.516s]   Building Custom Rule C:/Jenkins/workspace/ign_sensors-pr-win/ws/ign-sensors/test/integration/CMakeLists.txt
[105.641s]   altimeter_plugin.cc
[111.453s]   altimeter_plugin.obj : MSIL .netmodule or module compiled with /GL found; restarting link with /LTCG; add /LTCG to the link command line to improve linker performance
[111.641s]   Generating code
[117.172s]   Finished generating code
[117.391s]   INTEGRATION_altimeter_plugin.vcxproj -> C:\Jenkins\workspace\ign_sensors-pr-win\ws\build\ignition-sensors4\bin\Release\INTEGRATION_altimeter_plugin.exe
[119.063s]   Building Custom Rule C:/Jenkins/workspace/ign_sensors-pr-win/ws/ign-sensors/src/CMakeLists.txt
[119.234s]   RenderingSensor.cc
[119.234s]   RenderingEvents.cc
[119.234s]   ImageGaussianNoiseModel.cc
[119.234s]   ImageNoise.cc
[120.703s] C:\Jenkins\workspace\ign_sensors-pr-win\ws\install\ignition-rendering4\include\ignition\rendering4\ignition/rendering/MeshDescriptor.hh(69,35): warning C4251: 'ignition::rendering::v4::MeshDescriptor::meshName': class 'std::basic_string<char,std::char_traits<char>,std::allocator<char>>' needs to have dll-interface to be used by clients of struct 'ignition::rendering::v4::MeshDescriptor' (compiling source file C:\Jenkins\workspace\ign_sensors-pr-win\ws\ign-sensors\src\RenderingSensor.cc) [C:\Jenkins\workspace\ign_sensors-pr-win\ws\build\ignition-sensors4\src\ignition-sensors4-rendering.vcxproj]
[120.703s] C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.24.28314\include\xstring(4448): message : see declaration of 'std::basic_string<char,std::char_traits<char>,std::allocator<char>>' (compiling source file C:\Jenkins\workspace\ign_sensors-pr-win\ws\ign-sensors\src\RenderingSensor.cc) [C:\Jenkins\workspace\ign_sensors-pr-win\ws\build\ignition-sensors4\src\ignition-sensors4-rendering.vcxproj]
[120.703s] C:\Jenkins\workspace\ign_sensors-pr-win\ws\install\ignition-rendering4\include\ignition\rendering4\ignition/rendering/MeshDescriptor.hh(73,38): warning C4251: 'ignition::rendering::v4::MeshDescriptor::subMeshName': class 'std::basic_string<char,std::char_traits<char>,std::allocator<char>>' needs to have dll-interface to be used by clients of struct 'ignition::rendering::v4::MeshDescriptor' (compiling source file C:\Jenkins\workspace\ign_sensors-pr-win\ws\ign-sensors\src\RenderingSensor.cc) [C:\Jenkins\workspace\ign_sensors-pr-win\ws\build\ignition-sensors4\src\ignition-sensors4-rendering.vcxproj]
[120.703s] C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.24.28314\include\xstring(4448): message : see declaration of 'std::basic_string<char,std::char_traits<char>,std::allocator<char>>' (compiling source file C:\Jenkins\workspace\ign_sensors-pr-win\ws\ign-sensors\src\RenderingSensor.cc) [C:\Jenkins\workspace\ign_sensors-pr-win\ws\build\ignition-sensors4\src\ignition-sensors4-rendering.vcxproj]

Argh, I forgot that #59 still had 4 C4251 warnings coming from ignition::rendering::MeshDescriptor which I couldn't figure out how they slipped through the pragmas.

yeah I noticed that too. Looks like it's from RenderingSensor.cc but also didn't see why the pragmas didn't work there. I thought the easy way to fix it is to update ign-rendering..

I thought the easy way to fix it is to update ign-rendering..

Yeah I also thought this while working on https://github.com/ignitionrobotics/ign-gui/pull/112 and https://github.com/ignitionrobotics/ign-sensors/pull/59, but the number of warnings on ign-rendering looked a bit overwhelming (almost 20k). So I thought that temporarily suppressing warnings from ign-rendering on the downstream libraries would give us more green builds with lower effort. I haven't actually looked at ign-rendering to triage those warnings though. Maybe it's not so difficult to get rid of all 20k of them :sweat_smile:

I resolved conflicts after merging #60, hoping to see the windows build fixed, but it now has 4 new warnings from ign-rendering

Removed Windows warnings in ign-rendering https://github.com/ignitionrobotics/ign-rendering/pull/183

Do we need a ign-rendering release ?

Removed Windows warnings in ign-rendering

Thanks for picking that up again! :bowing_woman:

Do we need a ign-rendering release ?

I don't think that's needed, because we don't generate binaries for Windows. Let's retrigger CI

Windows is green!


feat: add links to current notifications

What it solves
Adding links to current notifications
How this PR fixes it
All current notifications that could have links added to them, i.e. when a Safe requires an update, now receive and render links.
How to test it

Open a Safe that requires an update and observe the notification now including a link.

Screenshots

Looks good.
The link is also for the notifications that indicates that there is a tx pending to be confirmed.


add jwt issuer support in adapter

add jwt issuer support in adapter

Codecov Report
Patch coverage has no change and project coverage change: +25.40 :tada:

Comparison is base (2064c03) 34.08% compared to head (1ab3671) 59.48%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1172       +/-   ##
===========================================
+ Coverage   34.08%   59.48%   +25.40%
===========================================
  Files         260       33      -227
  Lines       32033     2705    -29328
  Branches     7980     1560     -6420
===========================================
- Hits        10917     1609     -9308
+ Misses      20872     1096    -19776
+ Partials      244        0      -244

Flag
Coverage Δ

adapter
?

admin-domain-service
56.82% <ø> (+0.44%)
:arrow_up:

backoffice-domain-service
50.29% <ø> (ø)

idp-domain-service
80.10% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 230 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Improve Group #30

Q
A

Is bugfix?
❌

New feature?
✔

Breaks BC?
✔

Tests pass?
✔

Related to issue #30

@xepozz @roxblnfk I updated the PR, it's ok?. Thanks!

Thanks!


Entity Drops don't work with SpongeForge

This is a simple fix that would be much appreciated by every server running sponge and RFTools Dims. Instead of directly adding the drop directly it needs to be added to the LivingDropsEvent. I can fix this with a simple patch on the server side but I'd much rather see a permanent fix. I'll follow this up with a PR.
Problem Code: https://github.com/McJty/RFToolsDimensions/blob/master/src/main/java/mcjty/rftoolsdim/ForgeEventHandlers.java#L162

Merged