Alternative to bulk insert

When we are running an online index rebuild at the same time as this sink is performing inserts, there are locks preventing them from running concurrently. No inserts are being performed during the index rebuild. Our analysis points to the cause being that the inserts are performed as bulk inserts by SqlBulkCopy.

One alternative to bulk insert would be to send the data in a table-valued parameter to a stored procedure.
Another would be to do it like the audit version with a multi-row insert. Something like:

INSERT INTO dbo.tablename
VALUES (@p1, @p2, ...),
(@p21, @p22, ...)

What do you think about adding one of these as an alternative to the current bulk insert? I'm guessing that due to compatibility and not everyone having the same requirements as me, any change would be opt in.

Probably a typo in your question -- first you say you're rebuilding at the same time the sink is inserting, then in the next sentence you say no inserts are being performed during the rebuild. If there are locks without inserts, there has to be an open transaction or something of that sort.
That being said, SQL Server actually has a type of lock that is specific to bulk operations (BU, for bulk update), although it is escalated to an exclusive table lock if the table has indexes. If your only log index is the default table's clustered primary key for id you could just do away with it. (Do you ever really search for a range of log IDs?)
It's probably obvious, but bulk inserts are used both for batching behavior and for performance reasons. A bulk insert eliminates a lot of (repetitive) overhead associated with calling a proc or sending inserts.  Only low-volume logging situations would probably be appropriate for those approaches, in which case you might as well use an audit sink (with the added understanding that an audit sink also will not hide exceptions).
SQL is full of weird stuff that doesn't perform the way it seems it ought to (read about how SQL CASE statements differ from switch...case for a prime example). Multi-row inserts is one of those oddities. I've seen tests that show they can be up to two orders of magnitude slower than the equivalent series of individual inserts. Why? So far I haven't seen anyone explain it...
Table-valued parameters are implemented as real tables materialized (written to) tempdb before the data goes anywhere else. In a logging scenario you definitely don't want to write everything twice.

Yeah, I can see how I was not being clear with that first paragraph.
The application is trying to write to the database at the same time as the maintenance scripts are performing index rebuilds. The result is that the open transactions for the inserts as well as the index rebuild wait on locks taken by other transactions. In one case we had a few inserts waiting on the index rebuild, which in turn, was waiting on an insert.
We do have an additional index, apart from the clustered primary key. Unless a clustered index and a non-clustered index have different effects on whether an exclusive table is taken, removing just the clustered index won't solve the locking problem. The non-clustered index is used when we search the logs, so I think it will have to stay.
The performance characteristics of bulk insert vs. single insert vs. table-valued parameters (TVP) seem complex. For us, the bulk insert uses more CPU than single inserts when there are about 40 rows in a batch. I don't know exactly how bulk insert compares to TVP, but when possible, we use TVP instead of multiple single inserts. TVPs are more efficient as soon as we insert more than a handful of rows. In addition to the locks that a bulk insert takes, it also uses a noticeable amount of CPU to query the collation during the preparation stage of the bulk insert. Both the locks and the CPU usage are issues for us.
This is probably one of those areas where what's best in one case is not in another. For us, the CPU is a limiting factor, while disk and network latency are very low. A TVP being written to tempdb before anything else has never been an issue for us.
What is considered a low-volume situation is quite subjective. We currently log approximately 50 rows/second, the maximum we have written with this sink was over 200 rows/second in average, but that was a bit too much, so we had to reduce the volume. In that case it was not just the CPU consumption that was too high, the storage space needed was also an issue.
We do use the audit sink for audit logging, where a transaction must not complete without the corresponding audit event having been committed to the database. It could work as a substitute for the normal sink. However, in addition to not hiding exceptions, the audit sink will wait for the event to reach the database before returning. If we want to make the logging fire-and-forget, so our application won't wait for those events, we can always wrap the audit sink, one way or another.
The idea of multi-row insert can be scrapped. After what you have said, I don't think it will be an improvement for anyone and it is not my first choice either. But I'm still interested in the idea of using a stored procedure with a TVP. What are your thoughts about that? Like I said previously, this will not be a better alternative for every user of this library…

I've asked one of our SQL DBAs about this, but meanwhile the MSDN article below is an interesting read. The two take-aways are that TVPs are recommended over bulk operations only when you're doing more than simple inserts (not the case for a logging scenario) and clustered identity PKs can be a problem:
https://blogs.msdn.microsoft.com/sqlcat/2013/09/23/maximizing-throughput-with-tvp/
I'm on the fence about the id column. There is a related discussion in #69.

My DBA agreed with the MSDN advice -- stick with bulk inserts. He agreed if we can avoid a clustered index on id that should fix the deadlocks, although regular locking is basically unavoidable.
I have a PR pending, and there is a seemingly-abandoned PR that I'll probably close and reproduce, but after that I'm going to propose in #69 that id is optional, and clustered indexing is optional. I really wanted to clean up a few more bugs before looking at new features but I think we can get some planning going.

The article links to a download of a PDF that has the full version of the article. That version doesn't say directly that SqlBulkCopy is better for simple inserts, but it is implied. I write this mainly for the benefit of someone else later reading this...
I will talk to my DBA about removing the clustered index. We will have to check if we really need a clustered index as well as what non-clustered indexes are necessary.
Our main focus is to reduce the risk of deadlocks, while maintaining high performance inserts. And we want to be able to read the latest logs without having to wait forever.
It looks like we don't have to wait for any code change if we make the modifications in the database table ourselves, so with that said and with the discussion going in #69, maybe this issue has served its purpose... Should I close it?

@GunnarHakansson I see you tagged into #69, I agree, we can close this.


chore: Remove unused binary nethealth

nethealth doesn't seem to be used or referenced anywhere anymore.
/cc @wangzhen127 @vteratipally

/lgtm

/lgtm


Is this project still being maintained?

I'm curious if this project is still being maintained as the last commit was in 2020. Would love to help out!

I'm not actively working on it myself but happy to provide commit access to anyone that wants to.
There may be folks on the Discord working on it too. See the readme for a link


Excepting initializing BuildTracker

Following the example from initializing BuildTracker, but it throws the following error:
I/flutter (11578): ══╡ EXCEPTION CAUGHT BY FLUTTER FRAMEWORK ╞═════════════════════════════════════════════════════════
I/flutter (11578): The following assertion was thrown:
I/flutter (11578): `TrackingBuildOwnerWidgetsBindingMixin` is required (<WidgetsFlutterBinding>)
I/flutter (11578): 'package:noob/src/build_tracker/build_tracker.dart':
package:noob/…/build_tracker/build_tracker.dart:1
I/ViewRootImpl@da141ad[FlutterActivity](11578): [DP] cancelDraw io.flutter.embedding.android.FlutterActivityAndFragmentDelegate$2@75849c1  isViewVisible: true
I/flutter (11578): Failed assertion: line 114 pos 9: 'WidgetsBinding.instance is TrackingBuildOwnerWidgetsBindingMixin'
I/flutter (11578):
I/flutter (11578): When the exception was thrown, this was the stack:
I/flutter (11578): #2      BuildTracker.enabled=
package:noob/…/build_tracker/build_tracker.dart:114
I/flutter (11578): #3      new BuildTracker
package:noob/…/build_tracker/build_tracker.dart:53

same issue


iOS - Pulling and pushing plural strings dict creates a duplicate

Pulling and pushing plurals with a strings dict creates a duplicate key with "||localized_key_format" appended.
I start off the following (plural) copy in Phrase:

Pull
$ phraseapp pull
Downloaded EN to Localizable.stringsdict

Result:
$ cat Localizable.stringsdict

<?xml version="1.0" encoding="UTF-8"?>
<plist version="1.0">
  <dict>
    <key>my_plural_bicycles_key</key>
    <dict>
      <key>NSStringLocalizedFormatKey</key>
      <string>%#@localized_format_key@</string>
      <key>localized_format_key</key>
      <dict>
        <key>NSStringFormatSpecTypeKey</key>
        <string>NSStringPluralRuleType</string>
        <key>NSStringFormatValueTypeKey</key>
        <string>d</string>
        <key>one</key>
        <string>bicycle</string>
        <key>other</key>
        <string>bicycles</string>
      </dict>
    </dict>
  </dict>
</plist>

Push:
$ phraseapp push
Uploading Localizable.stringsdict... done!

Pull again:
$ phraseapp pull
Downloaded EN to Localizable.stringsdict

Result:
The key is now duplicated:
$ cat RPX/Base.lproj/Localizable.stringsdict

<?xml version="1.0" encoding="UTF-8"?>
<plist version="1.0">
  <dict>
    <key>my_plural_bicycles_key</key>
    <dict>
      <key>NSStringLocalizedFormatKey</key>
      <string>%#@localized_format_key@</string>
      <key>localized_format_key</key>
      <dict>
        <key>NSStringFormatSpecTypeKey</key>
        <string>NSStringPluralRuleType</string>
        <key>NSStringFormatValueTypeKey</key>
        <string>d</string>
        <key>one</key>
        <string>bicycle</string>
        <key>other</key>
        <string>bicycles</string>
      </dict>
      <key>localized_format_key</key>
      <dict>
        <key>NSStringFormatSpecTypeKey</key>
        <string>NSStringPluralRuleType</string>
        <key>NSStringFormatValueTypeKey</key>
        <string>d</string>
        <key>one</key>
        <string>bicycle</string>
        <key>other</key>
        <string>bicycles</string>
      </dict>
    </dict>
  </dict>
</plist>

Also in Phrase:

We have decided to close all GitHub issues and, instead, handle them through our Customer Support. We think this shift will allow us to offer proper prioritization of issues as well as a more appropriate response time that would be expected from Phrase products.
We apologize for any inconveniences this may cause. If you believe your issue is still relevant or has a high priority, please contact<EMAIL_ADDRESS>and we can take more direct action toward finding a solution.


fix list

Description
Fixes #144
Include a summary of your changes.
Changes
List the changes made to achieve the feature or fix the bug.

Change limit

Screenshots

Add screenshots that show your changes
How Has This Been Tested?
Check ballot with a lot of voters
Checklist:

[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] My changes generate no new warnings
[ ] I have executed manual tests that prove my fix is effective or that my feature works

No, we cant  know max-limit (


PR previews

Would great to have deploy previews in PRs to help prevent things like #247.
Looks like this is an internal alpha feature of the GitHub deploy-page action, but if recall correctly there's a way to do this.

Nevermind.  Looks like we already have something like this it just didn't fail loudly.
Probably fine as is.


Fail to install the package with the latest pdm

Describe the bug
The package seems to not work correctly with the latest version of pdm. This leads to a failure when incorporating with pre-commit.
To Reproduce
Steps to reproduce the behavior:

Run the command:

$ pip install git+https://github.com/frostming/pofmt.git

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.

System (please complete the following information):

pofmt version: main
Python version: 3.11.3
OS: Windows

Additional context
Add any other context about the problem here.

Thanks for the quick fix! 👍


git push builder error

Hi,
I encountered the following error when trying to push to Deis:
Counting objects: 3, done.
Delta compression using up to 8 threads.
Compressing objects: 100% (2/2), done.
Writing objects: 100% (3/3), 260 bytes | 0 bytes/s, done.
Total 3 (delta 1), reused 0 (delta 0)
/home/git/builder: eval: line 116: unexpected EOF while looking for matching ``'
/home/git/builder: eval: line 117: syntax error: unexpected end of file
To ssh://git@deis.*******.com:2222/*******.git
   5da89aa..1531fdd  HEAD -> master

Does anyone know how I can debug this? It only affects the current app, not newly created ones.

This looks very similar to https://github.com/deis/deis/issues/2980 and https://github.com/deis/deis/issues/3994. What does deis config:list look like?

Ah, looks like the exact same issue. Alright, consider this a duplicate!


Fixed custom env file path section in the doc for better understanding

We should at least provide a small example to help people for a better understanding.

@bashleigh We've been already discussed it on #127. Therefore, I didn't open another issue on this PR on purpose.

Hey! Thanks for the PR @jeffminsungkim. I like the idea! Could you make it a separate section aimed directly at using the different staging environment files please? :) Does that make sense?
So underneath the section you edited, add in a new subtitle like using different env files and add your example there? :)
Keeps things nice a separate because someone might have a different path like /var/www/.env instead of /var/www/app/.env or whatever. Or they could have different files OR they could have different file name for different stages and a custom path. Know what I mean?

@bashleigh That makes sense. Sure, I'm happy to make one. 😀

@bashleigh Please tell me if anything needs to be improved.

@bashleigh Hey, I don't think I have permission to merge.😥

@jeffminsungkim no wonder nobody merges their PRs when I approve them :joy:


Complete branch coverage for more files

In the further pursuit of full coverage for Rubocop/RSpec this solves for additional files, leaving 14 branches across 9 files left to address after this.

[!NOTE]
We remove a safe operator from a method used in a node matcher here, since it should always get a node, right?

Reconciled with:

https://github.com/rubocop/rubocop-rspec/pull/1989

Status report:

Before submitting the PR make sure the following are checked:

[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Updated documentation.
[x] Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
[x] The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

If you have created a new cop:

[ ] Added the new cop to config/default.yml.
[ ] The cop is configured as Enabled: pending in config/default.yml.
[ ] The cop is configured as Enabled: true in .rubocop.yml.
[ ] The cop documents examples of good and bad code.
[ ] The tests assert both that bad code is reported and that good code is not reported.
[ ] Set VersionAdded: "<<next>>" in default/config.yml.

If you have modified an existing cop's configuration options:

[ ] Set VersionChanged: "<<next>>" in config/default.yml.

Surprisingly little duplication between this and #1989 :yay:

@bquorning @ydah I reconciled this with #1989 and it should be ready to go!

The Ruby head CI failure comes down to how rocket hashes are spaced in the parser.

The Ruby head CI failure comes down to how rocket hashes are spaced in the parser.

See https://github.com/rubocop/rubocop-rspec/blob/00b6c0387652f8f5140465f92b3299a746e9d18d/spec/rubocop/rspec/hook_spec.rb#L77-L83 for inspiration on how to work around that.


[Question] Replace Text > Global Match option?

What does the Global option do in Replace Text do?

@jaminroe it would look for the pattern repeatedly in a string


Add check for unused translations

Port https://github.com/Shopify/dawn-internal/pull/532 to a check

Requires a lot of structural changes in theme tools for a very small fix - high effort/low priority. Deprioritized for now


Show bonding events in the Transactions page

User Story
Let's say Jocelyn B. open the Cosmos UI after a week of not using it. She remembers that she should have 10,000 ATOM (from participating in the fundraiser). But her Balances page only shows 5,000 ATOM. She checks the Transactions page and it says that she's only sent 1,500 ATOM from her wallet. So where did the other 3,500 ATOMs go? She freaks out and wonders if someone stole her balance.
Well, she staked it. But she completely forgot about doing that, because she has a busy life. It doesn't help that the UI doesn't have an easily accessible place to see where those ATOMs went.
Proposal
We don't have an area in the UI where we show the history of user-initiated bonding events. I propose that we show bonding events as txs in the Transactions page.

@mappum @faboweb ideally i think all transactions should appear in the tx history. is this possible?

This is possible. We would need to switch on transaction type and need another design for delegation transactions.
But I want to question if this is the best way to display these information. The two transaction types have different contexts and it might information overload the user. If we decide to go this way, I propose we add at least filtering options to the transactions page.

we should consider including tx histroy on the send page and on the staking page (filtered by tx type). this is fairly common in wallets like coinbase where each denomination's "wallet" displays the total, some actions (buy, sell, send), and the corresponding tx history.
good points fabo. i think the tx histroy page (which should display all tx's with filters) can be done in a way where transaction types are obvious enough that it is not overloaded (see screenshot below as an example of multiple tx types in the same history).

One additional challenge is, that delegation txs have some kind of time variable. I.e. unbonding only happens after x days and only after manually finishing the process (see #808)

that delegation txs have some kind of time variable

my understanding based on #808 is that two tx's are required for unbonding. so we could / should show both. tx history should already include time and date. i think this is cool!

emails would rely on a centralized system, wouldn't it?

The endpoints are available on a newer SDK version. Note: I created suggestions to improve here: https://github.com/cosmos/cosmos-sdk/issues/1637

See #1010, we could use the current Tags being used at each module to check the tx type

To clarify: This contains of implementing the designs from #913 plus querying the new /stake/delegators/{addr}/txs endpoint to get all txs, which are then shown in the tx-history.

shouldn't block on tx designs - just use what we have already
but here is a first pass https://sketch.cloud/s/xKnxA/all/voyager-ui/transaction-history


Fix for Issue #51: problems with the ref hook - [merged]

In GitLab by @ggcr on Nov 16, 2022, 10:23
Merges Mouse_Multiselection_Fix -> master

In GitLab by @ jberlin on Nov 16, 2022, 10:38
marked this merge request as ready

In GitLab by @ggcr on Nov 16, 2022, 10:23
requested review from @ jberlin

In GitLab by @ggcr on Nov 16, 2022, 10:30
marked this merge request as draft

In GitLab by @ jberlin on Nov 16, 2022, 10:38
mentioned in commit 2aa292d5dca4f21776a6d124968eddc03f3133a8

In GitLab by @ggcr on Nov 16, 2022, 10:39
Something is still missing with this, whenever I get why I'll inform you.

In GitLab by @ jberlin on Nov 16, 2022, 10:41
Hi @ggcr ok, I will then postpone the deploy until all is in place


lossless-json internals bleed to display

Hello,
While working on json tree display in redis-commander, I noticed that some undesirable data appears in tree. (See pic below, losslessNumber and isLosslessNumber are definitely not mine.)
I suspect it comes from lossless-json. If you are trying to only solve the BigInt issue with JSON, this solution is simple and elegant and does not require a special parser. I noticed you're working on it these days, so it may just be a temporary issue, I just bring it to your attention. You get to this when you're trying to view a tree of a redis string value (not ReJSON), string value that contains valid json, and json that contains numeric values; problem does not exhibit when json has string only values).
Best regards.

Tested with latest version itself i do not see this behaviour myself. There big number support is fully working since 0.8.0 without a problem, just displaying the number in blue (as number, not string).
Can you please send me the data stored inside Redis when you get it with redis-cli or similar.
best regads

Hi.
Add a key of this string with the following content: (sorry, number roundings from imperial to metric conversion!)
{
    "acmodel": "ACJ320neo (Corporate Jet version)",
    "properties": {
      "length": 37.57269599999999,
      "wingspan": 35.798759999999994
    }
}

and hit «View mode tree»:

oh - you are right, there is a problem. Just tested with large integers not displayed right as javascript "number" before and they are working now...
Did not test with floats...

updated code and fixed version is available on github master branch and as latest docker image on Github Registry.
Do you mind checking with your data?

Looks ok to me. With npm.
Could you explain why yarn does not work for you? (I'm a yarn guy.)
P.

i think it is an old restriction no one reevaluated.
It was connected to the locations yarn installed packages to - not every time inside the local "node_modules" folder. That together with the way packages where loaded/located to send them to the browser (as client side js) did not work reliably.
The code to get the path to the package files for sending it to the browser was changed and it might work now with yarn again...


A11y_ML .NET Model Builder_ Scenarios_ Info and Relationships: Proper control type is not provided for "Feedback" control

“Check out Accessibility Insights! - Identify accessibility bugs before check-in and make bug fixing faster and easier.”
GitHubTags:
#A11yMAS; #A11yTCS; #Win32; #DesktopApp; #BM-VisualStudioClient-Win32-Jul21; #A11ySev2; #Visual Studio; #WCAG1.3.1;
Environment Details:
Microsoft Visual Studio Enterprise 2022 Preview Version 17.0.0 Preview 1.1
Repro Steps:

Open Visual Studio Enterprise 2022 Preview
Create a new .Net Core Console App (C#)
Tab to "Solution Explorer" and right click on the project (Shift + F10) and then from the expanded list Select "Add" and then from the list items select "Machine learning"
Tab till "Feedback" control and verify the control type for the feedback control using Accessibility Insights for desktop

Actual Result:
Proper control type is not provided for "Feedback" control. Control type is given as "Text"
Expected Result:
Since feedback is an actionable control control type should not be "Text". Proper control type should be provided for the control
User Impact:
Screen Reader users will get confused if proper control type is not given for the controls

@SaisreeDandamudi the narrator says  "Feedback", are we expected to say " Feedback button.." or are we expect it to say " feedback ......any actionable control"?

@zewditu the role of 'Feedback' control should be defined, role of feedback should defined as button.

Validate on  rel/candidate build <IP_ADDRESS>1903. See issue 1627 for instructions for install.

Issue is fixed. Control type for feedback control is defined as button. Issue is fixed

#Closed;


Cannot use model for inference: vocabulary indices are not consecutive

Describe the bug
I cannot use the model after it has been trained, it only predicts one of two classes. And the probabilites are set to nan.
I recieve thousands of warning such as:
@akutuzov
edit: if model_name = "ltgoslo/norbert"is set to any other hugginface model e.g KB/bert-base-swedish-cased it works fine.
Saving vocabulary to outputs/vocab.txt: vocabulary indices are not consecutive. Please check that the vocabulary is not corrupted!
Saving vocabulary to outputs/vocab.txt: vocabulary indices are not consecutive. Please check that the vocabulary is not corrupted!
Saving vocabulary to outputs/vocab.txt: vocabulary indices are not consecutive. Please check that the vocabulary is not corrupted!

There seems to be something that is broken in the vocabulary, since this code works fine with any other Bert model on huggingface.
>>> model.predict(["Hejsan hur är läget?"])
([0], array([[nan, nan]]))

To Reproduce
import pandas as pd
from simpletransformers.classification import ClassificationModel

df = pd.read_csv('/home/norway_sentiment.csv')

train_df = pd.DataFrame(df[0:8000])
eval_df = pd.DataFrame(df[8000:])

train_args = {
    'reprocess_input_data': True,
    'overwrite_output_dir': True,
#    'evaluate_during_training': True,
    'max_seq_length': 128,
    'num_train_epochs': 1,
#    'evaluate_during_training_steps': 100,
    'train_batch_size': 64,
    'n_gpu': 1,
}

model_name = "ltgoslo/norbert"

model = ClassificationModel('bert', model_name, args=train_args, cuda_device=1)
model.train_model(train_df)
result, model_outputs, wrong_predictions = model.eval_model(eval_df)

Expected behavior
model.eval_model(eval_df)should report metrics.
Error
/home/tim/anaconda3/envs/transformers-source/lib/python3.7/site-packages/sklearn/metrics/_classification.py:870: RuntimeWarning: invalid value encountered in double_scalars
  mcc = cov_ytyp / np.sqrt(cov_ytyt * cov_ypyp)
Traceback (most recent call last):
  File "eval_sent.py", line 28, in <module>
    result, model_outputs, wrong_predictions = model.eval_model(eval_df)
  File "/home/tim/anaconda3/envs/transformers-source/lib/python3.7/site-packages/simpletransformers/classification/classification_model.py", line 911, in eval_model
    eval_df, output_dir, multi_label=multi_label, verbose=verbose, silent=silent, wandb_log=wandb_log, **kwargs
  File "/home/tim/anaconda3/envs/transformers-source/lib/python3.7/site-packages/simpletransformers/classification/classification_model.py", line 1079, in evaluate
    result, wrong = self.compute_metrics(preds, model_outputs, out_label_ids, eval_examples, **kwargs)
  File "/home/tim/anaconda3/envs/transformers-source/lib/python3.7/site-packages/simpletransformers/classification/classification_model.py", line 1285, in compute_metrics
    fpr, tpr, thresholds = roc_curve(labels, scores)
  File "/home/tim/anaconda3/envs/transformers-source/lib/python3.7/site-packages/sklearn/utils/validation.py", line 63, in inner_f
    return f(*args, **kwargs)
  File "/home/tim/anaconda3/envs/transformers-source/lib/python3.7/site-packages/sklearn/metrics/_ranking.py", line 914, in roc_curve
    y_true, y_score, pos_label=pos_label, sample_weight=sample_weight)
  File "/home/tim/anaconda3/envs/transformers-source/lib/python3.7/site-packages/sklearn/metrics/_ranking.py", line 697, in _binary_clf_curve
    assert_all_finite(y_score)
  File "/home/tim/anaconda3/envs/transformers-source/lib/python3.7/site-packages/sklearn/utils/validation.py", line 63, in inner_f
    return f(*args, **kwargs)
  File "/home/tim/anaconda3/envs/transformers-source/lib/python3.7/site-packages/sklearn/utils/validation.py", line 124, in assert_all_finite
    _assert_all_finite(X.data if sp.issparse(X) else X, allow_nan)
  File "/home/tim/anaconda3/envs/transformers-source/lib/python3.7/site-packages/sklearn/utils/validation.py", line 106, in _assert_all_finite
    msg_dtype if msg_dtype is not None else X.dtype)
ValueError: Input contains NaN, infinity or a value too large for dtype('float64').

Desktop (please complete the following information):

Ubuntu 20.04, CUDA Version: 11.0, GeForce GTX Titan X

Hi,
We test NorBERT using the HuggingFace [Transformers](https://github.com/huggingface/transformers) library. You seem to be using simpletransformers, which is less mainstream.
Can you provide steps to reproduce the error with the Transformers?

does that mean the developers of NorBERT do not currently want to support use of the model using the simpletransformers library?

@oe Not necessarily.
It just means we had not encountered any issues like that with Transformers. To find the source of the problem, it could be useful to first check whether the problem exists in Transformers as well, or is ts simpletransformers-specific.

@akutuzov Thanks for your reply! I have not tried with the Transformers library. Do you have any code snippet I could try for binary classification with PyTorch?
Would be so greatful if it could work in simpletransformers thou, the rest of the huggingface models do work there.

@timpal0l I've just ran a simple classification task using NorBert and simpletransformers.
It went OK, in the sense that the classifier was trained and I received meaningful predictions:
In [24]: result, model_outputs, wrong_predictions = model.eval_model(test_data)
INFO:simpletransformers.classification.classification_model:{'mcc': 0.3311525398694757, 'tp': 37, 'tn': 3, 'fp': 7, 'fn': 2, 'auroc': 0.7461538461538462, 'auprc': 0.9173416742981831, 'eval_loss': 0.568481581551688}
In [26]: predictions
Out[26]: [0]
In [27]: raw_outputs
Out[27]: array([[0.43196979, 0.36896741]])

Can you try to re-download NorBert?
However, I confirm the existence of "Saving vocabulary to outputs/vocab.txt: vocabulary indices are not consecutive. Please check that the vocabulary is not corrupted" warnings, although they do not seem to influence the result much.
Investigating it now.

@timpal0l I've just ran a simple classification task using NorBert and simpletransformers.
It went OK, in the sense that the classifier was trained and I received meaningful predictions:
In [24]: result, model_outputs, wrong_predictions = model.eval_model(test_data)
INFO:simpletransformers.classification.classification_model:{'mcc': 0.3311525398694757, 'tp': 37, 'tn': 3, 'fp': 7, 'fn': 2, 'auroc': 0.7461538461538462, 'auprc': 0.9173416742981831, 'eval_loss': 0.568481581551688}
In [26]: predictions
Out[26]: [0]
In [27]: raw_outputs
Out[27]: array([[0.43196979, 0.36896741]])

Can you try to re-download NorBert?
However, I confirm the existence of "Saving vocabulary to outputs/vocab.txt: vocabulary indices are not consecutive. Please check that the vocabulary is not corrupted" warnings, although they do not seem to influence the result much.
Investigating it now.

That is interesting. Could you provide me the full script and your library versions / cuda driver / os version. I have tried on various machines, with all the latest libraries.
from simpletransformers.classification import ClassificationModel, ClassificationArgs
import pandas as pd
import logging

logging.basicConfig(level=logging.INFO)
transformers_logger = logging.getLogger("transformers")
transformers_logger.setLevel(logging.WARNING)

# Preparing train data
train_data = [
    ["Aragorn was the heir of Isildur", 1],
    ["Frodo was the heir of Isildur", 0],
]
train_df = pd.DataFrame(train_data)
train_df.columns = ["text", "labels"]

# Preparing eval data
eval_data = [
    ["Theoden was the king of Rohan", 1],
    ["Merry was the king of Rohan", 0],
]
eval_df = pd.DataFrame(eval_data)
eval_df.columns = ["text", "labels"]

# Optional model configuration
model_args = ClassificationArgs(num_train_epochs=1)

# Create a ClassificationModel
model = ClassificationModel(
    "bert", "ltgoslo/norbert", args=model_args
)

# Train the model
model.train_model(train_df)

# Evaluate the model
result, model_outputs, wrong_predictions = model.eval_model(eval_df)

# Make predictions with the model
predictions, raw_outputs = model.predict(["Sam was a Wizard"])

I note that even the running loss during training is set to Running Loss:       nan

Have you re-downloaded NorBERT?

Have you re-downloaded NorBERT?

I believe so yes.
(simpletransformers) tim@gpu:~$ cd
(simpletransformers) tim@gpu:~$ cd .cache/
(simpletransformers) tim@gpu:~/.cache$ ls
huggingface
(simpletransformers) tim@gpu:~/.cache$ rm -rf huggingface/

There is nothing saved elsewhere to the best of my knowledge when downloading it from huggingface.
No difference when downloading it again.

The code below works perfectly for me. train.csv and test.csv are simple comma-separated text files with a binary label in the first column and a sentence in the second column. I am running it on a CPU, but  if need be, can test on a GPU as well. But it is highly unlikely this will make any difference.
from simpletransformers.classification import ClassificationModel, ClassificationArgs
import pandas as pd
import logging

logging.basicConfig(level=logging.INFO)
transformers_logger = logging.getLogger("transformers")
transformers_logger.setLevel(logging.WARNING)

train_data = pd.read_csv("train.csv")
test_data = pd.read_csv("test.csv")

train_data.columns = ["labels", "text"]
test_data.columns = ["labels", "text"]

model_args = ClassificationArgs(num_train_epochs=2)

model = ClassificationModel("bert", "ltgoslo/norbert", use_cuda=False, args=model_args)

model.train_model(train_data)

result, model_outputs, wrong_predictions = model.eval_model(test_data)

predictions, raw_outputs = model.predict(["Ny vokalist og ny start for norsk punks mest lovende ."])
print(predictions)
print(raw_outputs)

The code below works perfectly for me. train.csv and test.csv are simple comma-separated text files with a binary label in the first column and a sentence in the second column. I am running it on a CPU, but if need be, can test on a GPU as well. But it is highly unlikely this will make any difference.
from simpletransformers.classification import ClassificationModel, ClassificationArgs
import pandas as pd
import logging

logging.basicConfig(level=logging.INFO)
transformers_logger = logging.getLogger("transformers")
transformers_logger.setLevel(logging.WARNING)

train_data = pd.read_csv("train.csv")
test_data = pd.read_csv("test.csv")

train_data.columns = ["labels", "text"]
test_data.columns = ["labels", "text"]

model_args = ClassificationArgs(num_train_epochs=2)

model = ClassificationModel("bert", "ltgoslo/norbert", use_cuda=False, args=model_args)

model.train_model(train_data)

result, model_outputs, wrong_predictions = model.eval_model(test_data)

predictions, raw_outputs = model.predict(["Ny vokalist og ny start for norsk punks mest lovende ."])
print(predictions)
print(raw_outputs)

Yes training on CPU seems to work. Would be great if it could work on GPU in the future.
Thanks!

So the same code does not work for you when running on a GPU, with everything else the same?

So the same code does not work for you when running on a GPU, with everything else the same?

Exactly, it only works with use_cuda=False, if running on GPU, the loss is nanwhile training. Does it work for you? If you try on google colab or something..?

Confirmed, when running on GPU, simpletransformers fails to fine-tune. PyTorch issues this warning:
UserWarning: Detected call of lr_scheduler.step() before optimizer.step(). In PyTorch 1.1.0 and later, you should call them in the opposite order: optimizer.step() before lr_scheduler.step().  Failure to do this will result in PyTorch skipping the first value of the learning rate schedule. See more details at https://pytorch.org/docs/stable/optim.html#how-to-adjust-learning-rate
Looks like simpletransformers calls PyTorch in some incorrect way when using GPU. Not sure this is related to the NorBERT itself.
In this repository you can find examples of it being used for POS tagging and binary sentiment classification.  They do not use simpletransformers though.
Later I will look more into what the issue with simpletransformers can be about. For the time being, I guess you can just use transformers itself.

@timpal0l also note a similar issue here:
https://github.com/ThilinaRajapakse/simpletransformers/issues/983

If you find an answer to the GPU + simpletransformers issue before us, please drop a message here :)
By the way, the "vocabulary indices are not consecutive" error is fixed now. It was caused by duplicate entries in the vocabulary. Now it makes even more sense to re-download the model from HuggingFace.
Thanks for reporting this, much appreciated!

For reference @timpal0l , here is a minimal example of finetuning NorBERT for binary classification using raw PyTorch and Transformers:
https://github.com/ltgoslo/NorBERT/blob/main/utils/finetuning_example.py
Confirmed to work fine on a GPU.


Added CosmosDB-based AssetIndex  integrationtest to i-test workflow

I-Tests need to be enabled explicitly by adding a job to the workflow file.

@bscholtes1A I noticed that we hadn't enabled this test. can you review this PR?

@bscholtes1A I noticed that we hadn't enabled this test. can you review this PR?

Hi @paullatzelsperger
thanks for spotting! I think we also need to add the cosmos federated cache node directory, could you please add it?
Sorry that I missed that in the first place.

@bscholtes1A done.

@bscholtes1A done.

I dont have the button to approve, but for me that s ready for merge!


add a switchOnError() operator

Does basically what the name says. It switches to another observable and silences the error.
This should pass the outer observable as an argument to the callback.

This might be a silly operator since catchError basically does this already. I need to think about the use cases more.


Readme more appealing more information about how to contribute and sco friendly

@Anupkjha2601 please assign me this and then see the looks


Is there a way to avoid to use !important CSS mode?

Is there a way to avoid to use !important CSS mode?
Can we move outerDivClass to the end?
I need my css classes to override yours.
Am I wrong?

Could you clarify? outerDivClass already comes after class multiselect. Or do you mean after all other classes?
<div
- class="multiselect {outerDivClass}"
  class:readonly
  class:single={maxSelect == 1}
  class:open={showOptions}
+ class="multiselect {outerDivClass}"
  on:mouseup|stopPropagation={() => setOptionsVisible(true)}
  use:onClickOutside={() => setOptionsVisible(false)}
  use:onClickOutside={() => dispatch(`blur`)}
>

I mean after all others.

I just noticed that Svelte always applies the conditional classes last, no matter in what order I specify them. So now I'm not sure if this issue is actually solved and if not, how it can be solved.
  <MultiSelect
    id="fav-web-tool"
    options={webFrameworks}
    bind:selectedLabels={selectedWeb}
    bind:activeOption={activeWeb}
    maxSelect={6}
    {placeholder}
    {filterFunc}
    liActiveOptionClass="foobar"
  />

@frederikhors Will release a new version tomorrow. Perhaps you can let me know if this problem persists.

Ok. I'll try ASAP.

Pleas re-open it.

I just released v3.3.0 with all the changes we discussed. Let me know how it works for you.

I will try in a few hours.

I tried with the 4.0.0. This is still an issue.

@frederikhors doesn't it work to be more specific in the css, for instance adding a class in your statements that is outside the svelte component?

Yep maybe. But I need to try, and I cannot right now.

@frederikhors Have you had a chance to try @egdegauperaa's suggestion? If so does it help?

We can close. I don't have time right now. I'll re-open if this is still an issue. Thanks both.


ADSENSE 2 Place  an 336x280 ad in the search page

See Adsense Technical specification for details

Initially, I think this should be in the bottom right-hand corner of the search box, with a top level with the top of the search button

Change my mind ... I don't think we need this at all, as we are moving to the active view advert.  I'll close this one.


Font size issue - Chrome

On Chrome, the font size drop down does not work properly.
It changes the font sizes, regardless of what you select, to 16.
The font can then be changed back to the original size by using the 'remove font style' button.
The font size works on Firefox and IE

Thank you for reporting.
However, font-size issues are up to summernote, not django-summernote. Ref : https://github.com/summernote/summernote/issues?utf8=✓&q=font-size


Right click launch edge from taskbar not loading default user profile

Environment (please complete the following information):

OS: Windows 11
Extension version: 2.1.5

Describe the bug:

After installing the extension and successfully executing the "Launch Edge and attach DevTools" launch configuration generated by the extension in my project, opening Microsoft Edge via right-clicking on the taskbar icon and selecting "New window" or "New inPrivate window" opens the browser profile created by the extension, instead of my default user browser profile.
Repro steps:

Open any folder inside Visual Studio Code (can even be an empty folder)
Go to the Microsoft Edge Tools tab and click "Generate launch.json"
Go to the run and debug tab and run the "Launch Edge and attach DevTools" configuration (i.e. not the headless version, so that it opens up the actual Microsoft Edge browser)
Exit out of the debug task and close Visual Studio Code
If Microsoft Edge is pinned to the taskbar, right click the taskbar Microsoft Edge icon and select "New window" to open a new Edge browser instance

If you don't have it pinned to the taskbar, searching for edge in the windows menu and selecting the "New window" option from there also works

Expected behavior:
The default user profile that is normally used when opening Microsoft Edge should be loaded.
Additional context:
To get my user profile path I enter "edge://version/" into the search url of Microsoft Edge, and for my default profile the path is something like "C:\Users\foo\AppData\Local\Microsoft\Edge\User Data\Default"
However when I launch the browser via the method I described above, the profile path shown in the "edge://version/" page is instead something like "c:\Users\foo\AppData\Roaming\Code\User\workspaceStorage\dd5084dfa1c8ebf459345d31c6af6a03\ms-vscode.js-debug.profile\Profile 1"
This behaviour persists upon restarting as well, I have tried the following things with no luck:

Repairing/reinstalling Microsoft Edge
Uninstalling Visual Studio Code entirely

AB#51737617

Thank you for reaching out and providing these details. Let me make sure this is seen and prioritized by our team.

Our dev team tried the reproduce the steps but things worked as expected. We were not able to repro the issue you are experiencing.
It might be that you've used a browser session that VSCode had opened for web browsing and you might have unadvertedly updated your shortcut.
If there is a bug somewhere in there, it would need to be tracked under the main VS Code repository as we rely on the mechanism they provide to launch Edge.
So, I'm closing this issue for now.

Ok thanks for the update!


split longname only at slicechar not followed by a forward slash

This fix enables the use of sliceChars (dot, tilde, hash) in your project's folder names and outputs the correct name in case a static module is defined inside a folder whose name contains a sliceChar. Fixes issue #1157

Please could you consider the pull request, that would be very useful since the JsDoc is pretty broken then. Thanks in advance.


Twine on Travis isn't getting TWINE_XXX variables

Need to print third-party process logs in case of failure for upload and other tasks.
related to #531

BUILD FAILED - Error while executing Twine ['upload', '/home/travis/build/pybuilder/pybuilder/target/dist/pybuilder-0.12.0.dev/dist/pybuilder-0.12.0.dev20171123180925.tar.gz', '/home/travis/build/pybuilder/pybuilder/target/dist/pybuilder-0.12.0.dev/dist/pybuilder-0.12.0.dev20171123180925-py2-none-any.whl']. See /home/travis/build/pybuilder/pybuilder/target/reports/distutils/twine_upload.log for full details:
	  0%|          | 0.00/128K [00:00<?, ?bytes/s]
	  6%|6         | 8.19K/128K [00:00<00:02, 58.8Kbytes/s]

	Uploading distributions to https://upload.pypi.org/legacy/
	Uploading pybuilder-0.12.0.dev20171123180925-py2-none-any.whl
	HTTPError: 403 Client Error: Invalid or non-existent authentication information. for url: https://upload.pypi.org/legacy/


oracle certificate under scripts directory is expired

The certificate in the scripts directory is expired, therefore virtual box guest addition does not install properly.

Sorry, did not realise the issue is already reported - https://github.com/joefitzgerald/packer-windows/issues/230


add missing sounds detected in phoible and pbase

These sounds are marked as <?>, and should each time be manually added, when running the clts --data=phoible loadmeta

with the next PR, the missing sounds will have disappeared, so this can then be closed.

obsolete now


Display the number of currently unlocked fortunes in the stats

As the title suggests, two things I thought might be useful in the new version of Cookie Monster:

The number of Fortunes unlocked this ascension, akin to what's done for the various seasonal cookies. (It has been suggested elsewhere, I believe, to have a unique tone for when they pop up.)
2. The random drop chance. This is something that I have been trying to work out manually for a while now (and apparently was once suggested many moons ago), but it would be nice to have the random drop percentages from the CC code surfaced in the Stats interface like the Lucky golden cookie stats and other things. When you're down to your last couple of eggs/reindeer cookies/ghost cookies/garden drops (if you need those), okay, what odds am I actually working with? What effect are my green rots having? Et cetera. (I believe fortunes were reported to be a flat 1%/2%, unaffected by other things, but those poking about in the code would know better than me.) Edit by @DanielNoord: This is a duplicate of #25

Thanks as always for the work you put into this.

Your first request would be pretty easy to add, but your 2nd one might not be that easy.  I will probably add the first request soon, but the 2nd request may be a bit.

We have actually implemented point 1. Point 2 could be part of #25. Therefore closing this.


KEP-2170: Create model and dataset initializers

Fixes: https://github.com/kubeflow/training-operator/issues/2210
I created model and dataset initializers.
Initially, we will only support HF for the demo purposes.
I will create dedicated issue to support more providers.
/assign @kubeflow/wg-training-leads @varshaprasad96 @akshaychitneni @deepanker13 @helenxie-bit @Electronic-Waste @saileshd1402  @kannon92

Pull Request Test Coverage Report for Build<PHONE_NUMBER>3
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>9:
0.0%

Covered Lines:
77

Relevant Lines:
77

💛  - Coveralls

Should we consider unit or e2e tests for this?

Should we consider unit or e2e tests for this?

Yeah, I will open dedicated issue for it.

I wonder if we can add some comment somewhere to let users know we only support downloading models/datasets from HuggingFace now?

Yes, we are planning to add supported dataset and model providers to the website.
Additionally, I will create tracking issue to support more providers (S3, GCS, etc.)

Are there any other comments before we can move forward with this initial PR ?
/assign @kannon92 @Electronic-Waste @deepanker13 @varshaprasad96 @saileshd1402


an argument of "--" causes formatting issues

Issue Type: Bug
regexp -inline -all -- {\S+} $string
The "--" in the above expression causes all lines below to become mostly orange, as if they were in quotes. If I comment the above line or change the "--" to something else, the formatting looks okay. Please fix!
VS Code version: Code 1.48.1 (3dd905126b34dcd4de81fa624eb3a8cbe7485f13, 2020-08-19T17:12:13.244Z)
OS version: Windows_NT x64 10.0.19041

Hi, thanks for the quick response. Here is more info. The language is Tcl. I am using an extension to highlight the Tcl. Looks like the issue is most likely with that extension and not with the base VS Code. Here is my code for completeness but likely this is probably the wrong place to report the bug.
Tcl testcase for issue in VS Code:
Version: 1.54.3 (system setup)
Commit: 2b9aebd5354a3629c3aba0a5f5df49f43d6689f8
Date: 2021-03-15T10:55:45.459Z
Electron: 11.3.0
Chrome: 87.0.4280.141
Node.js: 12.18.3
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.19041
regexp -- {-[a-z]+} "some string"
puts "this syntax highlighting following the previous regexp is not working properly"
set foo bar
puts "highlighting is still showing orange"
comments are still orange instead of green
puts "comment out regexp line above to see highlighting fixed"

@ryuanchen thanks for the additional info. As you say, since VS Code doesn't have any built in support for Tcl, this issue is coming from the extension that provides this support.


Implement the Bowe-Gabizon SE snark

https://eprint.iacr.org/2018/187.pdf

@imeckler 	this is done right?

Yes !


[BACKLOG-22892] - when sending export, the resources should be found …

…in zip rather than repository.  do not include repository config when sending to slave server

Build Completed
:fire: This pull request has some issues. It would be preferable to fix them in order for it to be just perfect. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
mvn -B -fn -f 'pom.xml' -pl 'engine' -P '!assemblies' -Dsurefire.runOrder=alphabetical -Daudit -amd clean install

Cleanup Commands
mvn -B -f 'pom.xml' -pl 'engine' -P '!assemblies' -amd build-helper:remove-project-artifact

Changed files
  engine/src/main/java/org/pentaho/di/trans/Trans.java

Unit Test Coverage
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.

:warning: Coverage Changes (click to expand)
org.pentaho.di.core.injection.bean.BeanInjector

Branch Change: -0.7% :small_red_triangle_down:
Complexity Change: -1.2% :small_red_triangle_down:

org.pentaho.di.job.entries.getpop.MailConnectionMeta

Branch Change: -1% :small_red_triangle_down:
Complexity Change: -1.5% :small_red_triangle_down:
Instruction Change: -0.3% :small_red_triangle_down:

org.pentaho.di.trans.steps.dimensionlookup.DimensionLookupMeta

Branch Change: -1.8% :small_red_triangle_down:
Complexity Change: -1.1% :small_red_triangle_down:
Instruction Change: -0.4% :small_red_triangle_down:
Line Change: -0.3% :small_red_triangle_down:

org.pentaho.di.trans.steps.excelwriter.ExcelWriterStepMeta

Branch Change: -1.3% :small_red_triangle_down:
Complexity Change: -0.7% :small_red_triangle_down:

org.pentaho.di.trans.steps.replacestring.ReplaceStringMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.sort.SortRowsMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.sortedmerge.SortedMergeMeta

Instruction Change: -0.2% :small_red_triangle_down:

org.pentaho.di.trans.steps.textfileinput.TextFileInputMeta

Branch Change: -0.5% :small_red_triangle_down:

Build Completed
:fire: This pull request has some issues. It would be preferable to fix them in order for it to be just perfect. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
mvn -B -fn -f 'pom.xml' -pl 'engine' -P '!assemblies' -Dsurefire.runOrder=alphabetical -Daudit -amd clean install

Cleanup Commands
mvn -B -f 'pom.xml' -pl 'engine' -P '!assemblies' -amd build-helper:remove-project-artifact

Changed files
  engine/src/main/java/org/pentaho/di/trans/Trans.java

Unit Test Coverage
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.

:warning: Coverage Changes (click to expand)
org.pentaho.di.job.entries.ftpsget.JobEntryFTPSGet

Branch Change: -0.6% :small_red_triangle_down:
Complexity Change: -0.5% :small_red_triangle_down:
Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.step.StepMeta

Branch Change: -0.7% :small_red_triangle_down:
Complexity Change: -0.6% :small_red_triangle_down:
Instruction Change: -0.2% :small_red_triangle_down:
Line Change: -0.3% :small_red_triangle_down:

org.pentaho.di.trans.steps.csvinput.CsvInputMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.datagrid.DataGridMeta

Branch Change: -2% :small_red_triangle_down:
Complexity Change: -1.7% :small_red_triangle_down:
Instruction Change: -0.2% :small_red_triangle_down:

org.pentaho.di.trans.steps.groupby.GroupByMeta

Branch Change: -1% :small_red_triangle_down:
Complexity Change: -1% :small_red_triangle_down:
Instruction Change: -0.1% :small_red_triangle_down:
Line Change: -0.3% :small_red_triangle_down:

org.pentaho.di.trans.steps.setvalueconstant.SetValueConstantMeta

Instruction Change: -0.2% :small_red_triangle_down:

org.pentaho.di.trans.steps.sort.SortRowsMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.tableoutput.TableOutputMeta

Branch Change: -0.9% :small_red_triangle_down:
Complexity Change: -0.8% :small_red_triangle_down:

org.pentaho.di.trans.steps.salesforceupsert.SalesforceUpsertMeta

Instruction Change: -0.1% :small_red_triangle_down:

@pentaho/ackbar @pentaho/r2d2 @mdamour1976
please review.  I tried a few different scenarios running on slave servers and pentaho servers both connected and not connected to a repository.  all those worked


Using Fragments within dialog

Hello,
Is there a way to use Fragments within the dialog?
I've been trying to add a view with a FrameLayout element and calling FragmentManager methods to fetch and change views but it says something about IllegalStateException, view has already a parent or something like that.
I'm trying to make a dialog with tabs...
I went for TabHost but I got different problems with deprecated classes.
I went for ViewPager and PagerTabStrip but it's not the UX I was required to implement.
So I decided to make all by hand with Fragments but I cannot communicate with a FrameLayout for content within your dialog. The FragmentManager mess up with the hierarchy I think...
I'd appreciate any clues about this issue.

DialogPlus is meant to use for simple cases, in your case if the content is not so complex, maybe you can imitate the tab selection manually by yourself. You can directly pass the resource id to dialogplus and access the views.

How can I access a FrameLayout within the view attached with ViewHolder? Last time a tryed it came a IllegalStateException trying to attach a fresh new Fragment into de FrameLayout within the layout saying it already has a parent...
This requirement has been so harsh to implement... I'm opting to do it almost all manually. I'd like to know if there is any resource of yours explaning the logic behind the use of Fragments in DialogPlus. Maybe I can reuse most of your code but I'm not such a seasoned Android developer...

Here is pair of screenshot with what I am supposed to replicate:

Since tabs are fixed there is no problem catching their click events. The problem is replacing the frame where the NumberPickers are...
That blue background is the calling Activity (but just cropped).

Assuming that your layout is R.layout.dialog and you set it like below.
dialog.setContentHolder(new ViewHolder(R.layout.dialog))

you can get it back by using
dialog.getHolderView();  //this will return the inflater layout

you can also get specific views by using findViewById
dialog.findViewById(R.id.header_text)

Thank you. I ended up hidding and showing subviews in the main view with View.GONE and View.VISIBLE.
I know it's not the most elegant solution but it does the job just fine.
What a nightmare has been trying to add tabs to a dialog. Closing issue.


Swich to node-databox lib

ah, great to see our own lib in action :)
==
Hamed        http://www.eecs.qmul.ac.uk/~hamed/
On 3 March 2017 at 16:59, Yousef Amar<EMAIL_ADDRESS>wrote:

@yousefamar requested changes on this pull request.
Marvellous! One small thing is that the time series write is already
wrapped in a {data: data} object internally, sou you only need to pass
data (else it turns into {data:{data:data}}. https://github.com/me-box/
node-databox/blob/master/lib/time-series.js#L30
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/me-box/databox-driver-twitter-stream/pull/10#pullrequestreview-25020208,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACy0r1kvqgtZjqMbGNyOSnczCYMkeICXks5riEcNgaJpZM4MSfCC
.


Search doesn't work correctly

Hello!
It's a great useful app, but there is an issue with search in items.
I will just leave screenshots. It would be great if you could fix it.

I've also noticed issues with search. I'll search for the first part of a string and it won't appear but I can scroll down to find it.
eg searching for "2bacc" when I have 2bacc5268dffdfb7686228796ef847772fcb335e in my history and it does not appear as the first result (or anywhere near the top)
Also loving the app, super useful!