Move to scijava org

To be more consistent.

@ctrueden once moved to the scijava org, would you consider shipping the kernel by default with Fiji?

would you consider shipping the kernel by default with Fiji?

Sure, if that is what you want. As usual, you can make your decision based on the Fiji contribution requirements. I think SciJava Jupyter Kernel is well in line with them already. One question to discuss might be whether it brings in too many MBs worth of dependencies, but I am not extremely concerned about that. In the (not-too-near) future, I think ImageJ will ultimately have a more granular plugin installation workflow which mitigates that issue.

Great. I think that would be a good idea. Let's do that after the move.
About the deps, the big ones are coming from Beakerx and should be removed from the base kernel at some point (I am pushing on that direction).

What needs to be done:

Move the GitHub repo (only @ctrueden can do that)
Rename all the repo URLs to https://github.com/scijava/scijava-jupyter-kernel
Update the conda forge repo: https://github.com/conda-forge/scijava-jupyter-kernel-feedstock
Update the Wiki page https://imagej.net/Scijava_Jupyter_Kernel
Add the dependency into the Fiji pom.xml: (only @ctrueden can do that)

@ctrueden if you can take care of 1, I have free time until tomorrow to do tasks up to 4.
Then you can do 5 whenever you want in the future.
(tell me if you think more things need to be done)

I do not have admin access to this repo, so I cannot move it. If you click Settings, can you transfer it to scijava org?

Add scijava-jupyter-kernel to the SciJava BOM: https://github.com/scijava/pom-scijava/commit/5c938a1211f167742b1d0de0b95f10ea95b1caad

You are admin now.

Thanks! I'll take care of the other stuff.

@ctrueden last thing, I need you to enable Travis (need to be admin for that).

Now done.

Looks like you got Travis enabled, eh? Great!


Missing argument, coder:

now any other problems solved, but have a new one :D
i install with cocoa pods, import in app delegate copy the test code but get this error: Missing argument, coder:

i was the ugly, sry. I found the problem its my fault, I start learn Swift in a couple of weeks ago. I close this section, its solved thx

What was your problem? Have the same problem myself.

sry i don't remember, maybe i download an other version from it. i can check it for u at the end of the next week, now I'm not home to check it :/

Okay, thanks a lot. I'd appreciate it a lot if you did send the solution when you get a chance.
Cheers

I also have the same problem :/


RBAC Plugin: Validate the inclusion of both a (cluster)role and (cluster)rolebinding.

If a role is specified without a binding (or vice versa), we should throw an intelligent error instead of silently erroring (which is what happens now).

Consider all scenarios between (cluster)roles and (cluster)rolebindings and determine error handling for each
Update the documentation to describe our behavior

REQUIRES FURTHER DESIGN

More things to check, should we only allow (cluster)role/rolebinding to avoid user applying other type of files?


Add database, table and 4 animal

In this pull request, I have been able to :

Add database vet_clinic
Add table animals
Add all animals to the table

@franclobo
Sorry, I don't understand what 'you have submitted a project, that has not been edited according to the current project.' mean. Can I get more information? what mistake did I make?

@franclobo Sorry, I don't understand what 'you have submitted a project, that has not been edited according to the current project.' mean. Can I get more information? what mistake did I make?

Hello @Trast00, I mean "You have submitted a project, that has a README file that has not been edited according to the current project."


STORM-1071 Task Message format to include source task id

As part of gathering inputs for Resource Aware Scheduler, understanding the tuple network characteristics between tasks would be helpful.
The present implementation of TaskMessage includes only the destination task id and message. Including the source task id to it would help us understand the task-task (component/component) network bandwidth characteristics. It shall also avoid the deserialization of message to retrieve the source task id from the serialized tuple message.

I see I should be updating netty_unit_test.clj to prevent the Travis CI build failures. I shall push an update soon.

I see with present changes, when I performed the unit test, netty test-basic and test-large-msg work fine but test-batch fails if we go over 1000 messages. I could also see org.apache.maven.plugin.MojoExecutionException: Clojure failed.


Do not early return when no relevant code owner exists

Fixes #39
I'd like to have a test but this doesn't really fit into the existing unit tests.

The tests pass locally, what does it mean by unexpected token? 🤔

Hah, no idea about that jest error - maybe a weird npx issue?
I think I'd prefer if the label code just moves up above the return instead, mainly so that it's still really obvious that it's not going to accidentally do any work in the fn if no users are found

I think I'd prefer if the label code just moves up above the return instead, mainly so that it's still really obvious that it's not going to accidentally do any work in the fn if no users are found

Isn't it obvious as the code still return inside if (!ownersWhoHaveAccessToAllFilesInPR.length)?

👍🏻


When creating an index, a mapping name is now required.

This is the minimum change we need in order to carry on supporting G-Cloud indexes (i.e. being able to create them). A script of some sort (potentially a refactoring of this one, i.e. the G-Cloud services indexing script) will follow for indexing DOS opportunities.
https://trello.com/c/5oIKvS1s/100-search-service-for-briefs-plus-indexing-script

I think Sam beat you to the draw on this one.  He did a more thorough job than you 😛
for the record, I would have done it this way too 😄

We'd better discuss


Moving elb (7) resources to v1beta1 version

…_policy, aws_proxy_protocol_policy, aws_load_balancer_listener_policy, aws_lb_ssl_negotiation_policy, aws_load_balancer_backend_server_policy, aws_load_balancer_policy resources

Description of your changes
Add new 7 resources in the elb group:

aws_app_cookie_stickiness_policy
aws_lb_cookie_stickiness_policy
aws_lb_ssl_negotiation_policy
aws_load_balancer_backend_server_policy
aws_load_balancer_listener_policy
aws_load_balancer_policy
aws_proxy_protocol_policy

Fixes #45
I have:

[x] Run make reviewable test to ensure this PR is ready for review.

How has this code been tested
Manually as Depends on ELB with a manual intervention as it requires a certificate in Issued State
aws_lb_ssl_negotiation_policy

aws_load_balancer_backend_server_policy

aws_load_balancer_listener_policy

aws_load_balancer_policy

Manually and Uptest
aws_app_cookie_stickiness_policy
aws_lb_cookie_stickiness_policy
aws_proxy_protocol_policy

/test-examples="examples/elb/appcookiestickinesspolicy.yaml"

/test-examples="examples/elb/lbcookiestickinesspolicy.yaml"

/test-examples="examples/elb/proxyprotocolpolicy.yaml"


OrientDB v3.2.0 server side javascript function throws exception

OrientDB Version: 3.2.0
Java Version:  1.8, also tested with java 13
OS: windows
tested with
Expected behavior
the size of the OMultiCollectionIterator instance should be returned and no exceptions should be thrown.
Same script used to work prior to 3.2.0 (e.g. works fine in 3.1.7)
Actual behavior
javax.script.ScriptException: org.graalvm.polyglot.PolyglotException: TypeError: invokeMember (size) on com.orientechnologies.common.collection.OMultiCollectionIterator@1876bfd6 failed due to: Unknown identifier: size --> org.graalvm.polyglot.PolyglotException: TypeError: invokeMember (size) on com.orientechnologies.common.collection.OMultiCollectionIterator@1876bfd6 failed due to: Unknown identifier: size
Steps to reproduce
Create two vertices and add some edges between the vertices
Create a javascript function that takes the edges as an input parameter
inside the function, return items.size() or try to call any method on the OMultiCollectionIterator class.
Call that function from studio,
e.g. select countSize(outE("EdgeClassName")) from VertexClassName

Same here. This is a key feature at the lib, but the last version does not works.

Hi,
Do you have an example function for this case ?
Regards

just create a javascript function in the studio. then within the function put this line
select countSize(outE("EdgeClassName")) from VertexClassName

with orient v 3.2.9 adding below line in the config solves the problem.

Hi @holocentric-bmsnext  ,
Can you specify what exactly needs to be added to the config, it would really help. Thanks!

Hi,
looking at the issue I guess has been enough to add the package in the list of allowed packages in the orientdb-server-config.xml something like this:
...
        <handler
                class="com.orientechnologies.orient.server.handler.OServerSideScriptInterpreter">
            <parameters>
                <parameter name="enabled" value="true"/>
                <parameter name="allowedLanguages" value="SQL,gremlin,groovy"/>
                <!--  Comma separated packages  allowed in JS scripts eg. java.math.*, java.util.ArrayList -->
                <parameter name="allowedPackages" value="com.orientechnologies.common.collection.OMultiCollectionIterator"/>
            </parameters>
        </handler>
...

but I do not know if @holocentric-bmsnext actually did that.
Regards

Hi,
Sorry forgot to paste the config changes here.
adding this line fixed the problem

@tglman,
Hi,
In case, I'm using OrientDB embedded mode, I got the same problem regarding java.lang.ClassNotFoundException: org.graalvm.polyglot.PolyglotException
What should I configure? Bro?


Single quote in dashboard name not properly escaped

In index.html the dashboard name is not properly escaped and opens up an injection possibility!
                    cookieJarProvider.describe({
                        label:     'buildMonitor.' + hashCodeOf('Someone's Dashboard'),
                        shelfLife: 365
                    });

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

Thanks, good catch! Would you like to submit a PR addressing the issue?

I had a short look at the plugin's code and it looks like this is not the only place missing a correct character escaping strategy. Probably one has to review all jelly templates.

Cool, thanks for looking into this! I'd be happy to help if you'd like to submit a PR?

Actually dashboard name is perfect place to put some JS changes in plugin. For example we use it to put our projects icons into bars and some additional cool changes that we need. So while fixing this issue it would be good to make Custom JS field in settings to put such changes instead of dashboard name.


Sanitize json modules

Not all valid JSON is valid JS. http://timelessrepo.com/json-isnt-a-javascript-subset

Is there any reason why we shouldn't just replace these four characters?

@terinjokes Modularize everything! But sure. I could just inline the regexp if you want.

Sorry, the module name was throwing me off. :~)

@terinjokes Get this one out too?


Access to include or copy members with a click like ardí.

Hello guys,
First of all code for i rules and it's fantastic.
I just want to know if there's a way to access with a click the include or copys of members declared in a program.
Best Regards,

You should be able to:

right click on the copy and go to definition
control+click with your cursor

Great!! Thanks!! 🙌🏻


Only update competition participants if an array was supplied

This PR fixes a bug where Edit Competition would reset participants even if the consumer did not supply a value for participants.
Closes #1077

How does this behave when null is passed instead of undefined?

How does this behave when null is passed instead of undefined?

null and undefined will essentially work in the same way because they are both falsy. an empty array or filled array will both be truthy, and thus trigger the participations if block in the execute function.
I'm just not a fan of undefined and prefer explicit nulls.


Almost identical datasets, huge performance difference

Describe the bug
I am struggling to understand (huge) performance difference between two datasets that are almost identical.
Steps to reproduce the bug
Fast (normal) dataset speed:
import cv2
from datasets import load_dataset
from torch.utils.data import DataLoader

dataset = load_dataset("beans", split="train")

for x in DataLoader(dataset.with_format("torch"), batch_size=16, shuffle=True, num_workers=8):
    pass

The above pass over the dataset takes about 1.5 seconds on my computer.
However, if I re-create (almost) the same dataset, the sweep takes HUGE amount of time: 15 minutes. Steps to reproduce:
def transform(example):
    example["image2"] = cv2.imread(example["image_file_path"])
    return example

dataset2 = dataset.map(transform, remove_columns=["image"])

for x in DataLoader(dataset2.with_format("torch"), batch_size=16, shuffle=True, num_workers=8):
    pass

Expected behavior
Same timings
Environment info
python==3.10.9
datasets==2.10.1

Do I miss something here?

Hi!
The first dataset stores images as bytes (the "image" column type is datasets.Image()) and decodes them as PIL.Image objects and the second dataset stores them as variable-length lists (the "image" column type is datasets.Sequence(...))), so I guess going from arrow bytes -> NumPy -> decoding as PIL.Image -> PyTorch is faster than going from arrow list -> NumPy -> PyTorch.
To store image bytes in the second example, you can do the following:
def transform(example):
    example["image2"] = cv2.imread(example["image_file_path"])
    return example

features = dataset.features.copy()
del features["image"]
features["image2"] = datasets.Image()
dataset2 = dataset.map(transform, remove_columns=["image"], features=features)

for x in DataLoader(dataset2.with_format("torch"), batch_size=16, shuffle=True, num_workers=8):
    pass

Thanks, @mariosasko. I could not understand why a (decoded) sequence should be MUCH slower than an encoded image (that must be decoded every time). At any rate, I tried you suggestion. It made the map step to run extremely slow (consumes all the 16GB of memory and starts swapping)
I tried also the easiest (as I see it) scenario, where images are kept as bytes, but it made things even worse: not only it was extremely slow, but also crashes

def transform(example):
    example["image2"] = cv2.imread(example["image_file_path"]).tobytes()
    return example

dataset2 = dataset.map(transform, remove_columns=["image"])

for x in DataLoader(dataset2.with_format("torch"), batch_size=16, shuffle=True, num_workers=8):
    pass

Resource temporarily unavailable (src/thread.cpp:269)
Output exceeds the size limit. Open the full output data in a text editor
---------------------------------------------------------------------------
RuntimeError                              Traceback (most recent call last)
File ~/virtenvs/py310/lib/python3.10/site-packages/torch/utils/data/dataloader.py:1133, in _MultiProcessingDataLoaderIter._try_get_data(self, timeout)
   1132 try:
-> 1133     data = self._data_queue.get(timeout=timeout)
   1134     return (True, data)

File ~/virtenvs/py310/lib/python3.10/multiprocessing/queues.py:113, in Queue.get(self, block, timeout)
    112 timeout = deadline - time.monotonic()
--> 113 if not self._poll(timeout):
    114     raise Empty

File ~/virtenvs/py310/lib/python3.10/multiprocessing/connection.py:257, in _ConnectionBase.poll(self, timeout)
    256 self._check_readable()
--> 257 return self._poll(timeout)

File ~/virtenvs/py310/lib/python3.10/multiprocessing/connection.py:424, in Connection._poll(self, timeout)
    423 def _poll(self, timeout):
--> 424     r = wait([self], timeout)
    425     return bool(r)

File ~/virtenvs/py310/lib/python3.10/multiprocessing/connection.py:931, in wait(object_list, timeout)
    930 while True:
--> 931     ready = selector.select(timeout)
    932     if ready:
...
-> 1146     raise RuntimeError('DataLoader worker (pid(s) {}) exited unexpectedly'.format(pids_str)) from e
   1147 if isinstance(e, queue.Empty):
   1148     return (False, None)

RuntimeError: DataLoader worker (pid(s) 195393) exited unexpectedly
Resource temporarily unavailable (src/thread.cpp:269)
Resource temporarily unavailable (src/thread.cpp:269)
Resource temporarily unavailable (src/thread.cpp:269)
Resource temporarily unavailable (src/thread.cpp:269)
Resource temporarily unavailable (src/thread.cpp:269)

Correction: the beans dataset stores the image file paths, not the bytes.
For your use case, I think it makes  more sense to use with_tranform than map and lazily decode images with cv2.imread when accessing an example/batch:
import cv2

def transform(batch):
    batch["image2"] = np.stack([cv2.imread(image_file_path) for image_file_path in batch["image_file_path"]])
    return batch

dataset = dataset.with_transform(transform)

This is incorrect.
Did you try to run it?  dataset[0] returns a tensor of numbers. dataset2[0]
returns the same tensor, but after a few long seconds.  Looping over a
thousand of images cannot take 15 minutes.
On Fri, 24 Mar 2023 at 19:28 Mario Šaško @.***> wrote:

Correction: the beans dataset stores the image file paths, not the bytes.
For your use case, I think it makes more sense to use with_tranform than
map and lazily decode images with cv2.imread when accessing an
example/batch:
import cv2
def transform(batch):
batch["image2"] = np.stack([cv2.imread(image_file_path) for image_file_path in batch["image_file_path"]])
return batch
dataset = dataset.with_transform(transform)
—
Reply to this email directly, view it on GitHub
https://github.com/huggingface/datasets/issues/5669#issuecomment-1483084347,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AASS73SHRWXIQX6SCYCJ7ITW5XDUDANCNFSM6AAAAAAWFSHWEM
.
You are receiving this because you authored the thread.Message ID:
@.***>

Thanks, @mariosasko
My question remain unanswered though. Why is maped dataset is so slow? My understanding is that a dataset of numpy arrays should be must faster than a dataset that has to decode images into numpy arrays every time one accesses an item.


[HACBS-74]-adding clair vulnerability policies

Rego file consisting of vulnerabilities check:
Sample output:
./conftest test --policy clair-vulns.rego test-index.json -o json
        {
                "filename": "test-index.json",
                "namespace": "main",
                "successes": 1,
                "failures": [
                        {
                                "msg": "The packages musn't have any high vulnerabilities! Packages with high vulnerabilities: bind-libs, bind-libs-lite, bind-license, bind-utils, glib2, gnutls, nettle, openssl-libs, python3-bind, systemd, systemd-libs, systemd-pam"
                        },
                        {
                                "msg": "The packages musn't have any low vulnerabilities! Packages with low vulnerabilities: bash, libdb, libdb-utils, libpcap, openssl-libs, systemd, systemd-libs, systemd-pam"
                        },
                        {
                                "msg": "The packages musn't have any medium vulnerabilities! Packages with medium vulnerabilities: bind-libs, bind-libs-lite, bind-license, bind-utils, brotli, cryptsetup-libs, curl, cyrus-sasl-lib, expat, glib2, glibc, glibc-common, glibc-minimal-langpack, gnupg2, gnutls, krb5-libs, libarchive, libcurl, libgcrypt, libsolv, libssh, libssh-config, libxml2, lz4-libs, p11-kit, p11-kit-trust, pcre2, platform-python, platform-python-pip, python3-bind, python3-gobject-base, python3-libs, python3-libxml2, python3-pip, python3-pip-wheel, python3-rpm, rpm, rpm-build-libs, rpm-libs, sqlite-libs, systemd, systemd-libs, systemd-pam, vim-minimal"
                        }
                ]
        }
]```

There is also fifth type of vulnerability: `Unknown` but it is not currently something that needs to be taken care of at the moment.

@dirgim @Dannyb48 @staticf0x @hongweiliu17 PTAL

Should this already also adhere to the standardized format like in #6 ?

Should this already also adhere to the standardized format like in #6 ?

Depends if this output fits our desires, good point. I think that current output format is sufficient enough, however I would like to hear opinion from rest of the team.

I think we can first merge this PR and we can include the changes to the output as part of #6

lgtm


Test failures on Travis

Results :
Failed tests:
  DateTimeTest.testDateTimeEquals:135 null expected:<20050101T093000[]> but was:<20050101T093000[Z]>
  DateTimeTest.testToString:97 Incorrect string representation expected:<19840417T031534[]> but was:<19840417T031534[Z]>
  PeriodTest.testTimezone:414 null
Tests run: 1274, Failures: 3, Errors: 0, Skipped: 0

The tests references all appear to reference Calendar.getInstance(), which depends on the system default TimeZone and Locale. If I read correctly, the default Locale on Travis hosts is UK, not US.

Fixed by @douglm in d9b9008.


Feature Suggestion: Public API for discovering what packages have been affected since last release

When developing in a monorepo it is very easy to have many many packages that don't, at least directly, rely upon each other. Since this is common, it is very easy to make a change in a standalone package and be forced to have your CI (TravisCI, CircleCI, etc) running all of your tests for very long period of time.
Either with direct support by Northbrook, or via an official plugin, it should be possible to only run tests for the packages that have been changed, and also for packages that directly rely upon it to make sure nothing has broken, but tests for unchanged or unaffected packages should not need to be run.
TODO

[x] Implement #5  - Better commit handling
[x] Develop a system for tracking what packages have been updated
[ ] Write tests
[x] Implement

I think the best way to handle this is a public API that allows plugins to query this information.

Finished!


Add .toBePositive (#29)

What
Adding the currently unimplemented .toBePositive matcher

Why
Currently unimplemented

Notes
Housekeeping

[x] Unit tests
[x] Documentation is up to date
[x] No additional lint warnings
[x] Add yourself to contributors list (yarn contributor)

Codecov Report

Merging #56 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master    #56   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           8     10    +2
  Lines          40     49    +9
  Branches        5      7    +2
=====================================
+ Hits           40     49    +9

Impacted Files
Coverage Δ

src/matchers/toBePositive/index.js
100% <100%> (ø)

src/matchers/toBePositive/predicate.js
100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0803d80...a56fe68. Read the comment docs.

Good job @hydrabolt


no card display

hello, I put the card as an example, with a birthday test on 2/09 but the card is not displayed. However I put this in the map:
Sensor.yaml

platform: anniversary
name: events
multiple: true
anniversaries:

event: "Schumi"
date: "1969-09-23"
event: "Quentin"
date: "1999-09-24"
icon: mdi:cake-variant
event: "Chazz birthday"
date: "2000-09-02"
icon: mdi:cake-variant
event: "Frank the tank"
date: "1998-8-18"

Card:
type: conditional
conditions:

entity: binary_sensor.event_in_15d
state: 'on'

in edit mode, the card is present, with the birthday, but in normal mode, it disappears
What is the cause ?
thanks.

Did you define the binary_sensor used by the conditional card?

Anyway I removed the conditional card part from the README example as it caused confusion and it's unrelated to the custom integration

what then is the best example of a map to use? do you have a card code?

ok, i see.
it takes birthdays over how many days?

The card code from the updated README will display you events as shown in the README images (it requires custom button card). But the UI/frontend part is out of scope of this custom integration, which runs on the backend.

The state of the sensor will be the number of days till the first upcoming event.

ok, spotless.
Where can I change the color of the circle where the number of days is?

Check out the background-color part in the notification section of custom_fields.

ok, thanks.
Good Job


Google Assistant error

Home Assistant release with the issue:

0.100.1
Last working Home Assistant release (if known):
Unknown
Operating environment (Hass.io/Docker/Windows/etc.):

Docker on Ubuntu
Integration:

https://www.home-assistant.io/integrations/google-assistant
Description of problem:
After enabling report states on the cloud panel getting error in the log.
Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):

Traceback (if applicable):
Error doing job: Task exception was never retrieved
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/components/google_assistant/report_state.py", line 29, in async_entity_state_listener
    entity_data = entity.query_serialize()
  File "/usr/src/homeassistant/homeassistant/components/google_assistant/helpers.py", line 279, in query_serialize
    deep_update(attrs, trt.query_attributes())
  File "/usr/src/homeassistant/homeassistant/components/google_assistant/trait.py", line 1308, in query_attributes
    ERR_NOT_SUPPORTED, "Querying state is not supported"
homeassistant.components.google_assistant.error.SmartHomeError: Querying state is not supported

Additional information:

After upgrade to 0.100.2 error still persist
Log Details (ERROR)
Sun Oct 13 2019 12:02:38 GMT+0300 (Moscow Standard Time)
Error doing job: Task exception was never retrieved
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/components/google_assistant/report_state.py", line 69, in _async_report_all_states
    entities[entity.entity_id] = entity.query_serialize()
  File "/usr/src/homeassistant/homeassistant/components/google_assistant/helpers.py", line 279, in query_serialize
    deep_update(attrs, trt.query_attributes())
  File "/usr/src/homeassistant/homeassistant/components/google_assistant/trait.py", line 1308, in query_attributes
    ERR_NOT_SUPPORTED, "Querying state is not supported"
homeassistant.components.google_assistant.error.SmartHomeError: Querying state is not supported

Can confirm this still exists on 0.100.2

Having this same problem in 0.103.4


Properly use TrackingListener in transforms that do not consume their operands

#12681 simplified the effects of IREE transforms to avoid always consuming the input handle and thus improve usage.
This was however lacking proper tracking now that the nested handles were not automatically invalidated anymore.
The revision fixes this oversight.
Fixes #12759
This also requires an upstream cherry-pick to properly pass RewriterBase for IR rewrites in VectorTransferOpTransforms:
553cebde0669aa98bb0624d9203b008c6e02f40e

@stellaraccident could you patch this and rerun where you observed the flake ?

@stellaraccident could you patch this and rerun where you observed the flake ?

The flake was just at an unrelated head presubmit that had already landed and subsequently passed. I'd estimate a 1/50 failure rate or so. So i don't have a reliable way to repro.

sync'ed offline w/ @ftynse to get the check API in a better state, addressed.


JAVA-2967: Add support for OSS Cassandra peers_v2 columns

CASSANDRA-16999 adds information about an SSL-enabled CQL port to peers_v2.  Goal of this PR is to transparently support this implementation as well as DSE 6.8.x (which we already added support for).

Closing for the same reason as #1910.
CASSANDRA-16999 is now marked as "Won't Fix" as the single port for encrypted and unencrypted traffic is the answer going forward.  Closing this for now; we can always revisit if attitudes change.


generated always as not work on mysql

GORM code
type User struct {
	ID        string //`gorm:"default:uuid_generate_v3()"` // db func
	FirstName string
	LastName  string
	Age       uint8
	FullName  string `gorm:"->;type:GENERATED ALWAYS AS (CONCAT(FirstName,' ',LastName));default:xyz;"`
}

func init() {
	configure.Connect() // connect the db
	db = configure.GetDB()
	db.AutoMigrate(&User{})
}

Description
GENERATED ALWAYS AS not working. mysql actual sql work perfectly
CREATE TABLE contacts (
id INT AUTO_INCREMENT PRIMARY KEY,
first_name VARCHAR(50) NOT NULL,
last_name VARCHAR(50) NOT NULL,
fullname varchar(101) GENERATED ALWAYS AS (CONCAT(first_name,' ',last_name)),
email VARCHAR(100) NOT NULL
);
version:
gorm.io/driver/mysql v1.3.6
gorm.io/gorm v1.23.8
mysql- 8.0.30
Error
Error 1064: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'GENERATED ALWAYS AS (CONCAT(FirstName,' ',LastName)) DEFAULT 'xyz',PRIMARY KEY (' at line 1
Related issue
#3887

@jinzhu did you notice it?


should past contributors access

See, for example https://github.com/HumanCellAtlas/metadata-schema/settings/access.
Many past team members have permissions there.
 Or do we need to have a discussion about removing permissions for past team members?

@amnonkhen I would suggest either we do something about it now or we close the ticket. How does that sound?

If we need to resurface this ticket we can do it in the future. More than a ticket I'd say that we actively remove people when we identify and can. So I will close the ticket that has been lingering here for quite a while. I have removed all past members of the HCA team from the DCP/HCA shared Google drive where I have permissions to remove people. Someone with permissions will need to do the same for AIT. I see that slack is up to date. Maybe a dev can remove permissions for past staff in Ingest (wrangler permissions)


Update eth-abi calls

What is needed?
Stop using eth-abi deprecated methods
Background
Last version of eth-abi did a big refactor so we need to adapt: https://eth-abi.readthedocs.io/en/latest/release_notes.html#id1
Related issues
https://github.com/ethereum/eth-abi/issues/206

Closed by #416


ios: search screen overlaps bottom bar when transitioning from favorites

I think this happens after performing a search

STR:

click search (foot nav)
select any existing result (eg 7up)
click back (top left)
footer nav appears transparent on top of results

Thanks for the reproducible case!
I've narrowed down the SwiftUI behavior, the bug doesn't happen if I remove the search bar, so it happens with a VStack containing a View and a List but not just a List by itself a or VStack contaning just a List.
Verified this with the countries display on the far right tab, which is just a List but adding a Text field before it in a VStack exhibits the same behavior.


Interactive job: sometimes output to stdout is repeated, sometimes skipped.

https://github.com/NLeSC/Xenon/issues/599
Triggered when output happens to both stderr and stdout: Sometimes when output is expected at stdout, I receive output on stderr containing the last chunk that was sent to stderr. The output that was sent to stdout is then dropped. This leads me to suspect that this is a bug in Xenon-GRPC rather than Xenon itself.

Fixed in synchronization-of-streams branch by @jmaassen


Ensure ipywidgets are synced between editors

For #10606
See below

@rchiodo Adding syncing editors in old webview was easy, very easy.
I added it to test this feature rather than doing in custom editor branch.
We can discuss the solution, if required.

Codecov Report

Merging #10717 into ds/ipyWidgets will not change coverage by %.
The diff coverage is 0.00%.

@@              Coverage Diff               @@
##           ds/ipyWidgets   #10717   +/-   ##
==============================================
  Coverage          60.76%   60.76%
==============================================
  Files                580      580
  Lines              31448    31448
  Branches            4470     4470
==============================================
  Hits               19109    19109
  Misses             11367    11367
  Partials             972      972

Impacted Files
Coverage Δ

...ient/datascience/interactive-ipynb/nativeEditor.ts
11.28% <0.00%> (ø)

src/client/datascience/types.ts
100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fd67d3...ce0afce. Read the comment docs.


Ingress + Gateway always returns 404

Bug description
We have a setup based on https://istio.io/latest/docs/tasks/traffic-management/ingress/kubernetes-ingress/. So we use Ingress + Gateway to route traffic into the cluster. But the request always returns 404 from istio-envoy
$ kubectl get gateways.networking.istio.io istio-ingressgateway -o yaml
apiVersion: networking.istio.io/v1beta1
kind: Gateway
metadata:
  name: istio-ingressgateway
  namespace: istio-system
spec:
  selector:
    app: istio-ingressgateway
    istio: ingressgateway
  servers:
  - hosts:
    - '*'
    port:
      name: https
      number: 443
      protocol: HTTPS
    tls:
      credentialName: secret-name
      mode: SIMPLE

$ kubectl get ingresses -n monitoring external-thanos-ingress -o yaml
apiVersion: extensions/v1beta1
kind: Ingress
metadata:
  annotations:
    kubernetes.io/ingress.class: external-istio
  labels:
    app: auth-proxy
  name: external-thanos-ingress
  namespace: monitoring
spec:
  rules:
  - host: prometheus.development-01.netent.tech
    http:
      paths:
      - backend:
          serviceName: auth-proxy
          servicePort: 8088
status:
  loadBalancer:
    ingress:
    - ip: REDACTED

$ curl -k -v https://prometheus.development-01.netent.tech/
...
* Connection state changed (MAX_CONCURRENT_STREAMS ==<PHONE_NUMBER>)!
< HTTP/2 404
< date: Wed, 10 Jun 2020 16:58:13 GMT
< server: istio-envoy

Debug information - https://gist.github.com/caulagi/a675c517e32e72128d37f1f4dee1ac3b
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[x] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Expected behavior
curl -k -v https://prometheus.development-01.netent.tech/ to give 401 response (for unauthenticated requests to this service)
Steps to reproduce the bug
Using the example yamls above.
Version (include the output of istioctl version --remote and kubectl version and helm version if you used Helm)
$ istioctl version --remote
client version: 1.6.1
control plane version: 1.6.0
data plane version: 1.6.0 (2 proxies)

$ kubectl version
Client Version: version.Info{Major:"1", Minor:"15+", GitVersion:"v1.15.11-dispatcher", GitCommit:"f2a77f678d6baccda27740d700f6cba2754dfacf", GitTreeState:"clean", BuildDate:"2020-04-21T04:44:03Z", GoVersion:"go1.12.17", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"15+", GitVersion:"v1.15.7-gke.32", GitCommit:"4ce968103257586ffc7adc1b3fb93f640875c2fc", GitTreeState:"clean", BuildDate:"2020-03-06T01:30:29Z", GoVersion:"go1.12.12b4", Compiler:"gc", Platform:"linux/amd64"}

How was Istio installed?
We first installed operator and configure operator to install istio
Environment where bug was observed (cloud vendor, OS, etc) - in our own data center and we use F5 loadbalancer

It didn't work for me when I tried 1.6.0 and 1.6.1 but I can make this work if I used the gateway istio-system/istio-autogenerated-k8s-ingress as described in https://github.com/istio/istio/issues/23989

The problem is you have configured your Ingress for HTTP traffic only, but are sending TLS. The ingress spec is notoriously vague, but I am pretty sure based on https://kubernetes.io/docs/concepts/services-networking/ingress/#tls, https://cloud.google.com/kubernetes-engine/docs/concepts/ingress-xlb#setting_up_https_tls_between_client_and_load_balancer, and https://kubernetes.github.io/ingress-nginx/examples/tls-termination/, Ingress will only serve on HTTPS if a tls config is provided. This makes sense to me, as we need to know what cert to use
Based on this i think this is a user configuration issue (and possibly docs?) not a bug in Istio. Does that make sense to you?

Closing as I think there is Working As Inteded. Thanks!


Hash Collision and biological vulnerability

The MD5 hash is vulnerable because collision chances are great. There have been an unimaginable number of unique dna profiles of dna based organisms.

estimate of collision of md5 from full sequence dna is 1 in 20,689,655,172

https://preshing.com/20110504/hash-collision-probabilities/

odds of having the same dna
https://preshing.com/20110504/hash-collision-probabilities/

There's probably a trillion unique alive DNA right now. The chances of a hash collision is much more than it appears.
MD5 is not sufficient.


Gd pwr service

I am not sure why I am here, I think this is something for USB expert? @tmon-nordic ?


[FRONTEND] Support mixed-precision inputs in triton.ops.matmul.

Support only combinations of float32 with float16 or bfloat16 for now. Shouldn't change anything for cases when input types match.
That's a follow-up to the comment in my other PR: https://github.com/openai/triton/pull/1746#issuecomment-1579630016.

Thank you!


bump semver from 5.7.1 to 5.7.2

updated-dependencies:

dependency-name: semver dependency-type: indirect ...

Thanks for your contribution but this dependency bump is not needed at the moment.


Bug 2011785: Show Validating instead of Unknown for the first 30 seconds of missing status on a plan CR

https://bugzilla.redhat.com/show_bug.cgi?id=2011785
Currently when the plan.status property is missing, we assume there is a problem and show Unknown in the status column on the plans table. It appears that in some circumstances this can be normal, if the controller is taking a few seconds to catch up and validate the newly created plan CR. This PR shows a spinner with "Validating" if there is no status data available for a plan at first.

However, the status field can also be empty because of some unknown problem, and I didn't want it to be possible for a plan to get stuck showing "Validating" forever in that case. After 30 seconds of status data continuing to be missing, the message will change to "Unknown" with a warning icon as is displayed today.

@vconzola are you ok with the word "Validating" being used here? that's what is happening when a plan is first created and not yet known to be Ready.


[Agent] Fix mongodb log

This PR is for:

Agent

Fix mongodb log
Steps to reproduce the bug
Changes to fix the bug
Affected branches

main

Checklist

[ ] Added unit test to verify the fix.
[ ] Verified eBPF program runs successfully on linux 4.14.x.
[ ] Verified eBPF program runs successfully on linux 4.19.x.
[ ] Verified eBPF program runs successfully on linux 5.2.x.

@mickeyzzc , please help review this PR if it is convenient.


Add userId on Card interface

Add userId on Card interface

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


real time segmentation using trained model with ScanNet

Hello.
I wonder if there is a way to show the semantic segmentation results in real time.
The order I think is as follows.

get a point cloud from camera(ex. zed)
convert file format for input of model and put it in a trained model
get inference results and show them through library

Thanks in advance

Close due to inactivity.


How to allow unauthorised call from client

I'm not sure this is an issue or just me being in the dark.
I have a registration page which should communicate with the feathers backend unauthorised (the user has still to be made).
When dispatching to
this.$store.dispatch('users/create', {})
the client reports an error
TypeError: Cannot convert undefined or null to object
populate-access-token.js:9
at Function.assign ()
at Object.eval (webpack-internal:///./node_modules/@feathersjs/authentication-client/lib/hooks/populate-access-token.js:9:12)
at promise.then.hookObject (webpack-internal:///./node_modules/@feathersjs/commons/lib/hooks.js:142:73)
This is correct, since the call to app.get('accessToken') will result in undefined.
After updating populate-access-token.js to
:
if (app.get('accessToken')) {
Object.assign(hook.params, { accessToken: app.get('accessToken') });
}
:
the code seems to work as I want.
I'm thinking this is not the way to do this. Surely this is a common use case, so what am I missing here? Any advice is appreciated.

A recipe for anonymous authentication has been added to the Feathers cookbook.


no way to format time-picker value to utc/gmt (instead of local time)

TuSimple/naive-ui version (版本)
2.14.0
Vue version (Vue 版本)
3.1.2
Browser and its version (浏览器及其版本)
Chrome 91.0.4472.114
System and its version (系统及其版本)
Windows 10
Node version (Node 版本)
Reappearance link (重现链接)
https://codesandbox.io/s/cool-monad-7we80?file=/src/Demo.vue
Reappearance steps (重现步骤)
Observe the formatted value
Expected results (期望的结果)
Being able to set the format to utc/gmt
Actual results (实际的结果)
The value is formatted using the user local time
Remarks (补充说明)
Here's a discussion about date-fns and utc formatting: https://github.com/date-fns/date-fns/issues/1401

I'm testing this: https://github.com/marnusw/date-fns-tz#readme

so in my case it seems to be enough to use utcToZonedTime() on the date before converting it to a timestamp

So after researching some more I found that by simply stripping the UTC timezone information (Z) from the date:
1970-01-01T09:00:00.000Z
=>
1970-01-01T09:00:00.000
date-fns treats the date as it were local. This way it doesn't transform it in any way when formatting.

As far as I understand, you only want to format time to utc? Or you want to select time (hours, minute, second) as utc.

So after researching some more I found that by simply stripping the UTC timezone information (Z) from the date:
1970-01-01T09:00:00.000Z
=>
1970-01-01T09:00:00.000
date-fns treats the date as if it were local. This way it doesn't transform it in any way when formatting.
This is what I'm using to convert the date string (1970-01-01T09:00:00.000Z) to a valid time-picker value:
parseInt(format(parseISO(value.slice(0, -1)), 'T'), 10)

(format and parseISO are from date-fns)
I tested changing hour/timezone on my pc and the time stays the same (as intended)

Please provide a format pattern string & expected output string.

let's take this timestamp:
32400
(naive, like js, uses milliseconds not seconds, so it's actually 32400000, but it doesn't really matter)
if you put that timestamp here, you get this:

I want 9 AM. Naive gives me 10 AM, cause it uses my local time to adjust the value.
I'm not talking about format patterns, etc. The feature is to have an option to pass a timestamp and not have the value be adjusted depending on the user's local time.
Here  I describe the way I fixed it for my case. I.e. I made the input date in local time (and not utc) so there was no conversion made

let's take this timestamp:
32400
(naive, like js, uses milliseconds not seconds, so it's actually 32400000, but it doesn't really matter)
if you put that timestamp here, you get this:

I want 9 AM. Naive gives me 10 AM, cause it uses my local time to adjust the value.
I'm not talking about format patterns, etc. The feature is to have an option to pass a timestamp and not have the value be adjusted depending on the user's local time.
Here  I describe the way I fixed it for my case. I.e. I made the input date in local time (and not utc) so there was no conversion made

You want to click at 9 AM and get 9 AM (GMT) or click at 10 AM (local) and get 9 AM (GMT)?

when I click 9 am I want to get 9 am. When I put a value in the vmodel I want it to be that value and not be changed to my local time

when I click 9 am I want to get 9 am. When I put a value in the vmodel I want it to be that value and not be changed to my local time.  No conversions

You can make a function for this that will set the value of your component in hours & minutes
const hourToTimeStamp = (hours: number, minutes: number = 0) => {
  const now = Date.now()
  const result = new Date(now).setHours(hours, minutes, 0, 0)
  return result
}

Hi so have been having the same problem because I this gets the local time (with the +1 hour) right from the start but i found another way to resolve this issue, I simply used value-format and formatted-value.
After sending the data you will be getting the time has a string in the format you picked in the value:format, so you can do whatever you want with it at that point on.
<n-time-picker value-format="HH:mm:ss" v-model:formatted-value=""/>

<script setup>
var timeValue = '00:00:00';
</script>

just posting here for the next person needing help on this matter :)

format="yyyy-MM-dd'T'HH:mm:ssXXX"

@07akioni Can you add the same for a date picker?


Library size and TLS

Can we please check again that the libraries with TLS enabled are not crazy big?

Hmm - the iOS sizes are bigger:

35MB for arm
17MB for x86 (simulator)

I'll have to look how big the end result is.


Http or tcp/ip?

when using HTTP. I am losing reactivity. Although I am waiting for the exact moment when the data ends up in state?
What could be the problem?

P.S. I can remove the demo and send the source code

+++ I have the same issue.


Security issue with 'Remember' option at login

I couldn't find a discussion here on GitHub about this issue, and please close the issue if this is not the right place to discuss this.
In my opinion the way the password remember option is implemented now, is highly insecure. As HA is handling home automation including alarm systems etc., security should be of a high concern.
The way it works now:
As soon as the user logs in, an entry is added to localstorage of the browser, containing the plaintext password. At each request this password is send using the header X-HA-access.
The problem with this approach is that the password is stored and send in plain text every request. On an insecure network it is then very easy to obtain someones password. A TLS connection already helps a lot, but it's still possible using known attacks to read localstorage data, or request headers.
The way it could (or should) work:
There are several approaches used in general, but they all work a bit like this:

User sends request to log in to HA
Server generates a hash and stores it in a database, and set's a cookie with the hash
The next time a user sends a request, the server compares the hash from the cookie with the one from the database to see whether the user is authenticated.

The hash should be renewed at least every session, but it seems that HA is not even using sessions, so then e.g. each x requests. Also the hash should be unique per device.
More information: https://stackoverflow.com/questions/1354999/keep-me-logged-in-the-best-approach

I agree with your assessment 100% the plaintext password storage for login and remote API calls into HA is something that needs to be addressed as many HA instances contain a great deal of sensitive data and control for various devices within the home.
Ideally some type of hashed password exchanged followed by HA returning session cookies to the browser with the implementation of a refresh mechanism for said tokens/cookies would be preferred.
Feel free to write or modify any code in HA to that end to facilitate better security, as I feel PRs getting the developer communities attention far quicker than issues.

FWIW, I just created a PR for session cookies at #12146, though there are several steps remaining after that PR to bring about the authentication discussed in this issue.

I think this can be closed now the new auth system is implemented.


Updates

Nice, we do need to get Phentom to sign off on the license though.
On Mon, Apr 6, 2015 at 1:42 PM erocs<EMAIL_ADDRESS>wrote:

Merged #1 https://github.com/Civcraft/modmail_ticketmanager/pull/1.
—
Reply to this email directly or view it on GitHub
https://github.com/Civcraft/modmail_ticketmanager/pull/1#event-274355835
.

He added the license in his repo.


Add support for other hardware accelerators

What does this PR do?

Add support for other hardwares, such as Ascend NPU accelerator, while maintaining the original code logic and only adding a new hardware judgment branch.
         if torch.cuda.is_available():
             device = torch.device(f"cuda:{rank}")
             dtype = torch.float16 if dtype is None else dtype
+       elif is_torch_npu_available():
+           device = torch.device(f"npu:{rank}")
+           dtype = torch.float16 if dtype is None else dtype
         else:
             device = torch.device("cpu")
             dtype = torch.float32 if dtype is None else dtype

The initialization of the new hardware is placed in server/text_generation_server/utils/import_utils.py like transformers project.
import importlib.util

def is_torch_npu_available(check_device=False):
    "Checks if `torch_npu` is installed and potentially if a NPU is in the environment"
    if importlib.util.find_spec("torch_npu") is None:
        return False

    import torch
    import torch_npu

    if check_device:
        try:
            # Will raise a RuntimeError if no NPU is found
            _ = torch.npu.device_count()
            return torch.npu.is_available()
        except RuntimeError:
            return False
    return hasattr(torch, "npu") and torch.npu.is_available()

Ascend NPU is an AI processor that support AI frameworks like PyTorch, TensorFlow, which has already integrated by transformers, accelerate, deepspeed and other popular LLM related software and tools.
Use Cases
The models we have validated include Baichuan, Bloom, T5, Galactica, Llama2, OPT, Starcoder, Vicuna.  The actual supported models will be more, as the NPU has already been integrated into the transformers
The NPU hardware environment is as follows:
+------------------------------------------------------------------------------------------------+
| npu-smi 23.0.rc2                 Version: 23.0.rc2                                             |
+---------------------------+---------------+----------------------------------------------------+
| NPU   Name                | Health        | Power(W)    Temp(C)           Hugepages-Usage(page)|
| Chip                      | Bus-Id        | AICore(%)   Memory-Usage(MB)  HBM-Usage(MB)        |
+===========================+===============+====================================================+
| 0     910B1               | OK            | 89.2        46                0    / 0             |
| 0                         | 0000:C1:00.0  | 0           0    / 0          26723/ 65536         |
+===========================+===============+====================================================+
| 1     910B1               | OK            | 93.3        50                0    / 0             |
| 0                         | 0000:01:00.0  | 0           0    / 0          4329 / 65536         |
+===========================+===============+====================================================+
| 2     910B1               | OK            | 87.0        48                0    / 0             |
| 0                         | 0000:C2:00.0  | 0           0    / 0          4330 / 65536         |
+===========================+===============+====================================================+
| 3     910B1               | OK            | 100.9       49                0    / 0             |
| 0                         | 0000:02:00.0  | 0           0    / 0          4329 / 65536         |
+===========================+===============+====================================================+
+---------------------------+---------------+----------------------------------------------------+
| NPU     Chip              | Process id    | Process name             | Process memory(MB)      |
+===========================+===============+====================================================+
| 0       0                 | 2902853       | text-generation          | 22420                   |
+===========================+===============+====================================================+
| No running processes found in NPU 1                                                            |
+===========================+===============+====================================================+
| No running processes found in NPU 2                                                            |
+===========================+===============+====================================================+
| No running processes found in NPU 3                                                            |
+===========================+===============+====================================================+

Example of Baichuan2-7B-Chat
launching a model server
text-generation-launcher --model-id /data/models/Baichuan2-7B-Chat/ --max-input-length 128 --port 8081 --trust-remote-code

log info
2023-10-10T01:24:12.945445Z  INFO text_generation_launcher: Args { model_id: "/data/models/Baichuan2-7B-Chat/", revision: None, validation_workers: 2, sharded: None, num_shard: None, quantize: None, dtype: None, trust_remote_code: true, max_concurrent_requests: 128, max_best_of: 2, max_stop_sequences: 4, max_top_n_tokens: 5, max_input_length: 128, max_total_tokens: 2048, waiting_served_ratio: 1.2, max_batch_prefill_tokens: 4096, max_batch_total_tokens: None, max_waiting_tokens: 20, hostname: "ascend-2", port: 8081, shard_uds_path: "/tmp/text-generation-server", master_addr: "localhost", master_port: 29500, huggingface_hub_cache: None, weights_cache_override: None, disable_custom_kernels: false, cuda_memory_fraction: 1.0, rope_scaling: None, rope_factor: None, json_output: false, otlp_endpoint: None, cors_allow_origin: [], watermark_gamma: None, watermark_delta: None, ngrok: false, ngrok_authtoken: None, ngrok_edge: None, env: false }
2023-10-10T01:24:12.945499Z  WARN text_generation_launcher: `trust_remote_code` is set. Trusting that model `/data/models/Baichuan2-7B-Chat/` do not contain malicious code.
2023-10-10T01:24:12.945632Z  INFO download: text_generation_launcher: Starting download process.
2023-10-10T01:24:15.834308Z  INFO text_generation_launcher: Files are already present on the host. Skipping download.

2023-10-10T01:24:16.352181Z  INFO download: text_generation_launcher: Successfully downloaded weights.
2023-10-10T01:24:16.352443Z  INFO shard-manager: text_generation_launcher: Starting shard rank=0
2023-10-10T01:24:19.411855Z  WARN text_generation_launcher: We're not using custom kernels.

2023-10-10T01:24:19.417047Z  WARN text_generation_launcher: Could not import Flash Attention enabled models: No module named 'vllm_cache_ops'

2023-10-10T01:24:19.419766Z  WARN text_generation_launcher: Could not import Mistral model: No module named 'dropout_layer_norm'

2023-10-10T01:24:26.359116Z  INFO shard-manager: text_generation_launcher: Waiting for shard to be ready... rank=0
2023-10-10T01:28:36.507459Z  INFO shard-manager: text_generation_launcher: Waiting for shard to be ready... rank=0
2023-10-10T01:28:46.513610Z  INFO shard-manager: text_generation_launcher: Waiting for shard to be ready... rank=0
2023-10-10T01:28:47.324267Z  INFO text_generation_launcher: Server started at unix:///tmp/text-generation-server-0

2023-10-10T01:28:47.414188Z  INFO shard-manager: text_generation_launcher: Shard ready in<PHONE_NUMBER>66s rank=0
2023-10-10T01:28:47.500971Z  INFO text_generation_launcher: Starting Webserver
2023-10-10T01:28:47.521717Z  WARN text_generation_router: router/src/main.rs:166: Could not find a fast tokenizer implementation for /data/models/Baichuan2-7B-Chat/
2023-10-10T01:28:47.521768Z  WARN text_generation_router: router/src/main.rs:169: Rust input length validation and truncation is disabled
2023-10-10T01:28:47.521774Z  WARN text_generation_router: router/src/main.rs:194: no pipeline tag found for model /data/models/Baichuan2-7B-Chat/
2023-10-10T01:28:47.582463Z  INFO text_generation_router: router/src/main.rs:213: Warming up model
2023-10-10T01:29:20.191046Z  WARN text_generation_router: router/src/main.rs:224: Model does not support automatic max batch total tokens
2023-10-10T01:29:20.191073Z  INFO text_generation_router: router/src/main.rs:246: Setting max batch total tokens to 16000
2023-10-10T01:29:20.191078Z  INFO text_generation_router: router/src/main.rs:247: Connected
2023-10-10T01:29:20.191085Z  WARN text_generation_router: router/src/main.rs:252: Invalid hostname, defaulting to <IP_ADDRESS>

request
curl <IP_ADDRESS>:8081/generate \
    -X POST \
    -d '{"inputs":"role: user, content: 解释一下“温故而知新”","parameters":{"max_new_tokens":50}}' \
    -H 'Content-Type: application/json'

response
{"generated_text":"这句话的含义\n\n\"温故而知新\"这句话出自《论语·为政》，是孔子的一句名言。它的意思是通过回顾和复习过去的知识，可以发现新的知识和道理。这句话强调了学习和成长的过程，即不断地回顾和总结过去的"}

Before submitting

[ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
[x] Did you read the contributor guideline,
Pull Request section?
[ ] Was this discussed/approved via a Github issue or the forum? Please add a link
to it if that's the case.
[x] Did you make sure to update the documentation with your changes? Here are the
documentation guidelines, and
here are tips on formatting docstrings.
[ ] Did you write any new necessary tests?

Who can review?

@Narsil

@Narsil @OlivierDehaene Can you help review the code?

What does this PR do?
Add support for other hardwares, such as Ascend NPU accelerator, while maintaining the original code logic and only adding a new hardware judgment branch.
         if torch.cuda.is_available():
             device = torch.device(f"cuda:{rank}")
             dtype = torch.float16 if dtype is None else dtype
+       elif is_torch_npu_available():
+           device = torch.device(f"npu:{rank}")
+           dtype = torch.float16 if dtype is None else dtype
         else:
             device = torch.device("cpu")
             dtype = torch.float32 if dtype is None else dtype

The initialization of the new hardware is placed in server/text_generation_server/utils/import_utils.py like transformers project.
import importlib.util

def is_torch_npu_available(check_device=False):
    "Checks if `torch_npu` is installed and potentially if a NPU is in the environment"
    if importlib.util.find_spec("torch_npu") is None:
        return False

    import torch
    import torch_npu

    if check_device:
        try:
            # Will raise a RuntimeError if no NPU is found
            _ = torch.npu.device_count()
            return torch.npu.is_available()
        except RuntimeError:
            return False
    return hasattr(torch, "npu") and torch.npu.is_available()

Ascend NPU is an AI processor that support AI frameworks like PyTorch, TensorFlow, which has already integrated by transformers, accelerate, deepspeed and other popular LLM related software and tools.
Use Cases
The models we have validated include Baichuan, Bloom, T5, Galactica, Llama2, OPT, Starcoder, Vicuna. The actual supported models will be more, as the NPU has already been integrated into the transformers
The NPU hardware environment is as follows:
+------------------------------------------------------------------------------------------------+
| npu-smi 23.0.rc2                 Version: 23.0.rc2                                             |
+---------------------------+---------------+----------------------------------------------------+
| NPU   Name                | Health        | Power(W)    Temp(C)           Hugepages-Usage(page)|
| Chip                      | Bus-Id        | AICore(%)   Memory-Usage(MB)  HBM-Usage(MB)        |
+===========================+===============+====================================================+
| 0     910B1               | OK            | 89.2        46                0    / 0             |
| 0                         | 0000:C1:00.0  | 0           0    / 0          26723/ 65536         |
+===========================+===============+====================================================+
| 1     910B1               | OK            | 93.3        50                0    / 0             |
| 0                         | 0000:01:00.0  | 0           0    / 0          4329 / 65536         |
+===========================+===============+====================================================+
| 2     910B1               | OK            | 87.0        48                0    / 0             |
| 0                         | 0000:C2:00.0  | 0           0    / 0          4330 / 65536         |
+===========================+===============+====================================================+
| 3     910B1               | OK            | 100.9       49                0    / 0             |
| 0                         | 0000:02:00.0  | 0           0    / 0          4329 / 65536         |
+===========================+===============+====================================================+
+---------------------------+---------------+----------------------------------------------------+
| NPU     Chip              | Process id    | Process name             | Process memory(MB)      |
+===========================+===============+====================================================+
| 0       0                 | 2902853       | text-generation          | 22420                   |
+===========================+===============+====================================================+
| No running processes found in NPU 1                                                            |
+===========================+===============+====================================================+
| No running processes found in NPU 2                                                            |
+===========================+===============+====================================================+
| No running processes found in NPU 3                                                            |
+===========================+===============+====================================================+

Example of Baichuan2-7B-Chat
launching a model server
text-generation-launcher --model-id /data/models/Baichuan2-7B-Chat/ --max-input-length 128 --port 8081 --trust-remote-code

log info
2023-10-10T01:24:12.945445Z  INFO text_generation_launcher: Args { model_id: "/data/models/Baichuan2-7B-Chat/", revision: None, validation_workers: 2, sharded: None, num_shard: None, quantize: None, dtype: None, trust_remote_code: true, max_concurrent_requests: 128, max_best_of: 2, max_stop_sequences: 4, max_top_n_tokens: 5, max_input_length: 128, max_total_tokens: 2048, waiting_served_ratio: 1.2, max_batch_prefill_tokens: 4096, max_batch_total_tokens: None, max_waiting_tokens: 20, hostname: "ascend-2", port: 8081, shard_uds_path: "/tmp/text-generation-server", master_addr: "localhost", master_port: 29500, huggingface_hub_cache: None, weights_cache_override: None, disable_custom_kernels: false, cuda_memory_fraction: 1.0, rope_scaling: None, rope_factor: None, json_output: false, otlp_endpoint: None, cors_allow_origin: [], watermark_gamma: None, watermark_delta: None, ngrok: false, ngrok_authtoken: None, ngrok_edge: None, env: false }
2023-10-10T01:24:12.945499Z  WARN text_generation_launcher: `trust_remote_code` is set. Trusting that model `/data/models/Baichuan2-7B-Chat/` do not contain malicious code.
2023-10-10T01:24:12.945632Z  INFO download: text_generation_launcher: Starting download process.
2023-10-10T01:24:15.834308Z  INFO text_generation_launcher: Files are already present on the host. Skipping download.

2023-10-10T01:24:16.352181Z  INFO download: text_generation_launcher: Successfully downloaded weights.
2023-10-10T01:24:16.352443Z  INFO shard-manager: text_generation_launcher: Starting shard rank=0
2023-10-10T01:24:19.411855Z  WARN text_generation_launcher: We're not using custom kernels.

2023-10-10T01:24:19.417047Z  WARN text_generation_launcher: Could not import Flash Attention enabled models: No module named 'vllm_cache_ops'

2023-10-10T01:24:19.419766Z  WARN text_generation_launcher: Could not import Mistral model: No module named 'dropout_layer_norm'

2023-10-10T01:24:26.359116Z  INFO shard-manager: text_generation_launcher: Waiting for shard to be ready... rank=0
2023-10-10T01:28:36.507459Z  INFO shard-manager: text_generation_launcher: Waiting for shard to be ready... rank=0
2023-10-10T01:28:46.513610Z  INFO shard-manager: text_generation_launcher: Waiting for shard to be ready... rank=0
2023-10-10T01:28:47.324267Z  INFO text_generation_launcher: Server started at unix:///tmp/text-generation-server-0

2023-10-10T01:28:47.414188Z  INFO shard-manager: text_generation_launcher: Shard ready in<PHONE_NUMBER>66s rank=0
2023-10-10T01:28:47.500971Z  INFO text_generation_launcher: Starting Webserver
2023-10-10T01:28:47.521717Z  WARN text_generation_router: router/src/main.rs:166: Could not find a fast tokenizer implementation for /data/models/Baichuan2-7B-Chat/
2023-10-10T01:28:47.521768Z  WARN text_generation_router: router/src/main.rs:169: Rust input length validation and truncation is disabled
2023-10-10T01:28:47.521774Z  WARN text_generation_router: router/src/main.rs:194: no pipeline tag found for model /data/models/Baichuan2-7B-Chat/
2023-10-10T01:28:47.582463Z  INFO text_generation_router: router/src/main.rs:213: Warming up model
2023-10-10T01:29:20.191046Z  WARN text_generation_router: router/src/main.rs:224: Model does not support automatic max batch total tokens
2023-10-10T01:29:20.191073Z  INFO text_generation_router: router/src/main.rs:246: Setting max batch total tokens to 16000
2023-10-10T01:29:20.191078Z  INFO text_generation_router: router/src/main.rs:247: Connected
2023-10-10T01:29:20.191085Z  WARN text_generation_router: router/src/main.rs:252: Invalid hostname, defaulting to <IP_ADDRESS>

request
curl <IP_ADDRESS>:8081/generate \
    -X POST \
    -d '{"inputs":"role: user, content: 解释一下“温故而知新”","parameters":{"max_new_tokens":50}}' \
    -H 'Content-Type: application/json'

response
{"generated_text":"这句话的含义\n\n\"温故而知新\"这句话出自《论语·为政》，是孔子的一句名言。它的意思是通过回顾和复习过去的知识，可以发现新的知识和道理。这句话强调了学习和成长的过程，即不断地回顾和总结过去的"}

Before submitting

[ ]  This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
[x]  Did you read the contributor guideline,
Pull Request section?
[ ]  Was this discussed/approved via a Github issue or the forum? Please add a link
to it if that's the case.
[x]  Did you make sure to update the documentation with your changes? Here are the
documentation guidelines, and
here are tips on formatting docstrings.
[ ]  Did you write any new necessary tests?

Who can review?
@Narsil

Hi. How much throughput acceleration can be provided on the Ascend 910B?

Is it possible to start on all npu devices?

Is it possible to start on all npu devices?

Hi @BrightXiaoHan, this PR is only tested on 910B.

Currently we're not going to include this code.
We do support alternate backends, however we try to make it as fast as possible, usually meaning a dedicated backend like https://github.com/huggingface/optimum-neuron/tree/main/text-generation-inference
Or support in this repo when the modified code is minimal (like AMD).


unocss config for setting  arrays of globs/pattern to watch with outfile name?

I'm using unocss cli
and for me to generate css from html i need to do this
 "unocss": "unocss \"layouts/**/**/*.html\" --watch -o ./assets/css/uno.css",

is there a way i can passed multiple instance of
paths to watch and output file name?
is there a unocss.config for this?
i dont wanna end up with my solution like this
 "uno-home": "unocss \"layouts/index.html\" --watch -o ./assets/css/home.css",
"uno-blog": "unocss \"layouts/blog/*.html\" --watch -o ./assets/css/blog.css",
"css-watch": "run-p uno-home uno-blog"

just to generate a css for home.css, blog.css
and watch 2 instance in parallel to create 2 files....
i think it would be great if we can pass on the unocss.config.ts/js
an array of path patterns to watch and paths to output the file css
I think it has good usecase for jamstacks , espcially hugo framework...
but the config now dont have that features

I am working on this


Add rke2 agent/server log directories

Added default rke2 agent/server logs for now, if there's a way to detect custom --data-dir locations it'd be great to accurately detect these.

Thanks @dkeightley
LGTM


createObjectURL to avoid tainted canvas

To avoid error when using getImageData (The canvas has been tainted by cross-origin data)
consider adding source as objectURL:
//  HTML: <video playsinline muted autoplay loop></video>
function loadAsObjectURL(video, url){
  const xhr = new XMLHttpRequest();
  xhr.responseType = 'blob';
  xhr.onload = (response) => video.src = URL.createObjectURL(xhr.response);
  xhr.onerror = () => { /* Houston we have a problem */};
  xhr.open('GET', url, true);
  xhr.send();
  video.onload = () => URL.revokeObjectURL(target.src);
}

const video = document.querySelector('video');
video.addEventListener('loadedmetadata', ()=> {
  seeThru.create(video);
});
loadAsObjectURL(video, '../video.mp4');

Test https://codepen.io/jakob-e/pen/RZypBp

Thanks for the info. Would you mind opening a PR with that info against the README (just like for #39)? That's be super helpful and much appreciated.

Solved via #41


CloudWatchLogsAddon: setting logRetentionDays param does not work and not set cloudWatchLogs.logRetentionDays when creating CloudWatch Log Groups

Describe the bug
When adding CloudWatchLogsAddon and setting parm logRetentionDays does not work. When respective CloudWatch LogGroups are created no retention is set a.k.a all log groups are set with never expire.
const addOn = new blueprints.addons.CloudWatchLogsAddon({
  namespace: 'aws-for-fluent-bit',
  createNamespace: true,
  serviceAccountName: 'aws-fluent-bit-for-cw-sa',
  logGroupPrefix: '/aws/eks/<your-cluster-name>',
  logRetentionDays: 90
});

Expected Behavior
When adding CloudWatchLogsAddon and setting parm logRetentionDays  when respective CloudWatch LogGroups are created retention for all log groups must be set to expire in number of days specified in param logRetentionDays.
Current Behavior
When adding CloudWatchLogsAddon and setting parm logRetentionDays does not work. When respective CloudWatch LogGroups are created no retention is set a.k.a all log groups are set with never expire.
const addOn = new blueprints.addons.CloudWatchLogsAddon({
  namespace: 'aws-for-fluent-bit',
  createNamespace: true,
  serviceAccountName: 'aws-fluent-bit-for-cw-sa',
  logGroupPrefix: '/aws/eks/<your-cluster-name>',
  logRetentionDays: 90
});

There are 2 problems why this is happening:

Lack of persimmons which allow logs:PutRetentionPolicy and logs:DeleteRetentionPolicy
in this file https://github.com/aws-quickstart/cdk-eks-blueprints/blob/69d730e538be47189a63e92bf5799e51c1792ae2/lib/addons/cloudwatch-logs/iam-policy.ts#L7

in addon code CloudWatchLogsAddon we set wrong param cloudWatchLogs.log_retention_days check here https://github.com/aws/eks-charts/blob/2ca1cb467a7ded4a608ab314b5cecf04dc7d758c/stable/aws-for-fluent-bit/templates/configmap.yaml#L140C42-L140C73 it should be cloudWatchLogs.logRetentionDays

Reproduction Steps
Just try to execute code from example page https://aws-quickstart.github.io/cdk-eks-blueprints/addons/cloudwatch-logs/
Possible Solution
I will provide PR with needed changes to fix this
Additional Information/Context
No response
CDK CLI Version
2.99.1 (build b2a895e)
EKS Blueprints Version
1.12.0
Node.js Version
v18.15.0
Environment details (OS name and version, etc.)
Mac OS Ventura - Version 13.6.2
Other information
No response

@shapirov103 please take a look into this when you have time


Switch out tslint (deprecated) for eslint

Should be an easy swap to eslint from tslint (deprecated).
Work

[ ] Install eslint as a dev dependency
[ ] Use eslint in place of tslint within the project

Extra info

https://code.visualstudio.com/api/advanced-topics/tslint-eslint-migration

Hello @ryanluker, I would be happy to try myself and help with this task 🤚

@timagixe Thanks a bunch, take a first stab at it and let me know where you get to.
The tslint-eslint-migration link I added above is probably a good first step 👍🏻.

Hi @ryanluker, I did some progress here #368. Please take a look at it whenever you have a chance.


Python dependencies

Hi,
I'm trying to run your code but I'm having some issues with the dependencies.
I'm using the provided Dockerfile in the cslam_experiments repo, however I'm still encountering issues with numpy.
This is the error I get when I try to launch the cslam_lidar.launch.py
[INFO] [launch]: All log files can be found below /root/.ros/log/2024-11-26-11-36-37-224912-lmmartinez-INVETT-2984504
[INFO] [launch]: Default logging verbosity is set to INFO
[INFO] [loop_closure_detection_node.py-1]: process started with pid [2984505]
[INFO] [lidar_handler_node.py-2]: process started with pid [2984507]
[INFO] [pose_graph_manager-3]: process started with pid [2984509]
[pose_graph_manager-3] [INFO] [1732620997.263394780] [r0.cslam_pose_graph_manager]: Visualization enabled.
[pose_graph_manager-3] [INFO] [1732620997.266485814] [r0.cslam_pose_graph_manager]: Initialization done.
[lidar_handler_node.py-2] [INFO] [1732620998.245610024] [r0.cslam_map_manager]: Initialization done.
[loop_closure_detection_node.py-1] [INFO] [1732620998.356071917] [r0.cslam_loop_closure_detection]: Using ScanContext.
[loop_closure_detection_node.py-1]
[loop_closure_detection_node.py-1] A module that was compiled using NumPy 1.x cannot be run in
[loop_closure_detection_node.py-1] NumPy 2.0.2 as it may crash. To support both 1.x and 2.x
[loop_closure_detection_node.py-1] versions of NumPy, modules must be compiled with NumPy 2.0.
[loop_closure_detection_node.py-1] Some module may need to rebuild instead e.g. with 'pybind11>=2.12'.
[loop_closure_detection_node.py-1]
[loop_closure_detection_node.py-1] If you are a user of the module, the easiest solution will be to
[loop_closure_detection_node.py-1] downgrade to 'numpy<2' or try to upgrade the affected module.
[loop_closure_detection_node.py-1] We expect that some modules will need time to support NumPy 2.
[loop_closure_detection_node.py-1]
[loop_closure_detection_node.py-1] Traceback (most recent call last):  File "/Swarm-SLAM/install/cslam/lib/cslam/loop_closure_detection_node.py", line 107, in <module>
[loop_closure_detection_node.py-1]     lcd = LoopClosureDetection()
[loop_closure_detection_node.py-1]   File "/Swarm-SLAM/install/cslam/lib/cslam/loop_closure_detection_node.py", line 97, in __init__
[loop_closure_detection_node.py-1]     self.glcd = GlobalDescriptorLoopClosureDetection(
[loop_closure_detection_node.py-1]   File "/Swarm-SLAM/install/cslam/local/lib/python3.10/dist-packages/cslam/global_descriptor_loop_closure_detection.py", line 142, in __init__
[loop_closure_detection_node.py-1]     import cv2
[loop_closure_detection_node.py-1] AttributeError: _ARRAY_API not found
[loop_closure_detection_node.py-1] Traceback (most recent call last):
[loop_closure_detection_node.py-1]   File "/Swarm-SLAM/install/cslam/lib/cslam/loop_closure_detection_node.py", line 107, in <module>
[loop_closure_detection_node.py-1]     lcd = LoopClosureDetection()
[loop_closure_detection_node.py-1]   File "/Swarm-SLAM/install/cslam/lib/cslam/loop_closure_detection_node.py", line 97, in __init__
[loop_closure_detection_node.py-1]     self.glcd = GlobalDescriptorLoopClosureDetection(
[loop_closure_detection_node.py-1]   File "/Swarm-SLAM/install/cslam/local/lib/python3.10/dist-packages/cslam/global_descriptor_loop_closure_detection.py", line 142, in __init__
[loop_closure_detection_node.py-1]     import cv2
[loop_closure_detection_node.py-1] ImportError: numpy.core.multiarray failed to import
[ERROR] [loop_closure_detection_node.py-1]: process has died [pid 2984505, exit code 1, cmd '/Swarm-SLAM/install/cslam/lib/cslam/loop_closure_detection_node.py --ros-args -r __node:=cslam_loop_closure_detection -r __ns:=/r0 --params-file /Swarm-SLAM/install/cslam_experiments/share/cslam_experiments/config/kitti_lidar.yaml --params-file /tmp/launch_params_wahswam5'].

Do you have any insight on what could be done to solve this?

The Problem
NumPy Version Mismatch: The error message clearly states that a module was compiled using NumPy 1.x and is now being run with NumPy 2.0.2, which may cause crashes. Some modules need to be recompiled with NumPy 2.0 to support both 1.x and 2.x versions properly.
cv2 Import Issue: There's also an issue when trying to import cv2. It seems that the _ARRAY_API is not found, and further down, it shows that numpy.core.multiarray failed to import. This could be related to the NumPy version problem or potentially an issue with the installation or configuration of cv2 itself.
Possible Solutions
Option 1: Downgrade NumPy
Explanation: As suggested in the error message, one straightforward solution could be to downgrade NumPy to a version less than 2.0. This would ensure that the modules compiled with NumPy 1.x can run without issues related to the version mismatch.
Steps:
First, identify the virtual environment (if any) where your project is running. If you're using Docker, make sure you're in the correct container environment.
Then, use the package manager (usually pip) to uninstall the current version of NumPy. For example, if you're in a virtual environment activated by source activate myenv (replace myenv with your actual environment name), you would run:
bash
复制
pip uninstall numpy
Next, install a version of NumPy less than 2.0. You can specify the version explicitly. For example, to install NumPy 1.24.3:
bash
复制
pip install numpy==1.24.3
Option 2: Recompile the Affected Modules
Explanation: The error mentions that some modules may need to be recompiled with pybind11>=2.12 to support both NumPy 1.x and 2.x versions. This option is a bit more involved but might be necessary if downgrading NumPy is not a viable solution for your specific use case.
Steps:
First, ensure that pybind11>=2.12 is installed in your environment. If not, install it using pip:
bash
复制
pip install pybind11>=2.12
Then, you'll need to identify the specific modules that are causing the issue. From the error message, it seems that cslam/global_descriptor_loop_closure_detection.py is one of the affected modules. You may need to look into the source code of these modules and find out how they are built and compiled.
If the modules are part of a larger project with a build system (e.g., CMake, Makefile, etc.), you'll need to follow the appropriate build procedures to recompile them with the updated dependencies (including the correct version of NumPy and pybind11). This could involve modifying build configuration files, running build commands, etc. The exact steps will depend on the specific build system used by the project.
Option 3: Check and Update cv2 Installation
Explanation: The issues with importing cv2 might be independent of the NumPy problem or could be related in some way. It's worth checking the installation of cv2 to ensure it's correct and up to date.
Steps:
First, uninstall the current version of cv2 if it's already installed. You can use pip to do this:
bash
复制
pip uninstall cv2
Then, reinstall cv2. The installation process might vary depending on your system and the specific requirements of your project. For example, if you're using OpenCV, you might need to install it from source or use a precompiled package. One common way to install OpenCV for Python is through the opencv-python package. You can install it using pip:
bash
复制
pip install opencv-python
After reinstalling cv2, try running your project again to see if the import issues are resolved.
In summary, the main issues seem to be related to NumPy version compatibility and potentially an incorrect installation or configuration of cv2. By trying one or more of the above solutions, you should hopefully be able to get your project running smoothly.

Thank you @coisi-s for the detailed debug instructions.
Compatibility of the python versions really depends on your system installation. The most common offenders are cv2, numpy and networkx.
Swarm-SLAM is not really tied to a specific version as long as all your python packages are compatible with each other.


Updated "Sample Usage" in hooks/index.md

Platforms affected
What does this PR do?
Updated "Sample Usage" of hooks.
What testing has been done on this change?
Checklist

[ ] Commit message follows the format: "GH-3232: (android) Fix bug with resolving file paths", where GH-xxxx is the GitHub issue ID & "android" is the platform affected.
[ ] Added automated test coverage as appropriate for this change.

Was this broken before?

I successfully use context.opts.platforms in the after_prepare hook of cordova-plugin-exclude-files. I wouldn't rule out the possibility that this is different for different types of hooks though. In fact, I think I noticed that once. If that's the case, we should fix the inconsistency.

I've used it with the after_plugin_install and got the error "indexOf is not a function"

Just took a look at the code and can confirm that for after_plugin_install, platforms are at opts.cordova.platforms. IMHO, that also means that this PR is not the solution to our problem.
Instead, we should consolidate the contexts passed to the different hooks. Anyone know if there's documentation for that?

Hooks are handled in lib, so this should probably be converted into an issue for lib.


Tests with node 16

Testing if I can reproduce in node 16.

@lszomoru node 16 here works while it fails for me locally with v16.17.1. Any ideas?
Related, I did comment on a similar looking issue for onnxruntime.

@digitarald, not really sure 🤷🏻♂


Fixed light theme in Delete Your Account Page

Description

Fixed light theme in Delete Your Account Page

Related Issues

Closes #1391

Screenshots / videos (if applicable)

hey @sezallagwal please update sync fork and share screen record of your chnages. Thank You!

@mdazfar2 i did it


docs: update code of conduct links

Changed code of conduct links to link correctly on the contributing guidelines page

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Exactly what we're looking for. Thanks, @MattIGolden!


feat: Added support for user-defined labels on cloud monitoring's Service and ServiceLevelObjective objects

This PR was generated using Autosynth. :rainbow:
Synth log will be available here:
https://source.cloud.google.com/results/invocations/4d3ccb2e-d627-413c-8553-abfae39b7ca7/targets

[ ] To automatically regenerate this PR, check this box. (May take up to 24 hours.)

PiperOrigin-RevId: 393200011
Source-Link: https://github.com/googleapis/googleapis/commit/354d0763e7e4ce7ab370790ffba0c3c25b1420c3
feat: Added support for logs-based alerts: https://cloud.google.com/logging/docs/alerting/log-based-alerts
fix: mark required fields in QueryTimeSeriesRequest as required

This change is being rolled back.
https://critique-ng.corp.google.com/cl/394685376
Wait for the roll back to come in before merging so no release with the breaking change goes out.

This has not been rolled back yet. Dan is working on this. Do not merge for now.


How to remove ptr/data type operation

If you press P on a line and turn an "addr" into an "addr *". How can you undo this operation without using the undo functionality?
I cannot find any way to undo a pointer. I also cannot find how to set a data type back to "addr"
Every time you click data -> x it assigns another level of pointer to the line. Where are the inverse operations to "remove pointer" ?
There is nothing in the ghidra cheat sheet I can see.

Ok it seems addr is "undefined data type". I think I understand it now


Nunjucks file icon

There's no current icon for the Nunjucks templating engine.
Here's a link to the main page.
For the icon we can take inspiration from Atom's icon for Nunjucks.

Filetypes:

.njk (official extension)
.nunjucks
.nunjs
.nunj
.njs
.nj

Are they any particular guidelines for icons? I can do up something

Transparent background, 32x32. Take some of the icons.zip file as example and it will suffice.

@robertohuertasm Good enough? Took same inspiration from atom.

Ready to be released in 1.6.0

Already released in 1.6.0


Adds part 2 & 3 of network policy blog series

Thanks for the addition but PR: #480 already added this, just waiting for approval from Bill to merge!


ISPN-8798 Allow ByteString lengths up to 255.

https://issues.jboss.org/browse/ISPN-8798
@tristantarrant Please backport to 9.1.x.  We'll need a prompt 9.1.6.Final release containing this fix, or else we'll need to revert back to 8.2.x for WF12. :(

Integrated in master and 9.1.x, thanks Paul!


Adds an option to set a timeout for service invocation

Description
Adds an option to set a timeout for http and grpc
Issue reference
https://github.com/dapr/dotnet-sdk/issues/1007
Checklist

[x] Code compiles correctly
[x] Created/updated tests
[x] Extended the documentation

@holopin-bot @elena-kolevska Thanks Elena! 😁

hi guys, first of all thank you for this PR. I've build this version locally and it solved what I needed. Any idea on when this will be included in the release sir @philliphoff ?

@taufan-mft It should be part of the v1.14 Dapr release. You can follow its progress in its release planning issue here: dapr/dapr#7605

thanks a lot! @philliphoff


PlaceholderFactory likes to pretend it doesn't exist at times.

I've had this problem for a few months now, and it seems random for when it happens.
It seems that PlaceholderFactory likes to act like it isn't a class which with give errors saying it cannot be found. This only happens in VS as Unity will compile and run, but VS will not compile which will lead to me not being able to debug.
It seems like PlaceholderFactory is the only class that gives trouble as other classes in Zenject - even in the same file - will not give any errors.  I've fixed this by exiting Unity, deleting all my sln/vsprog files, and running Unity again. This will work for a time until the problem randomly comes back.
I'm free to dig deeper into this, but I'm not sure where to start as it is very random.

I think it is specific to visual studio, have tried it with latest visual studio on Windows10?  Mac Visual studio is very buggy.

Hey! Yes, I have the latest Visual Studio of 2019 (16.2.5). It's interesting because it's always from Zenject/PlaceholderFactory. No other library gives me this issue.

Here is the output:
------ Rebuild All started: Project: Assembly-CSharp-Editor-firstpass, Configuration: Debug Any CPU ------
error CS0009: Metadata file 'C:\XXX\Temp\UnityVS_bin\Debug\Zenject.dll' could not be opened -- Could not find a part of the path 'C:\XXX\Temp\UnityVS_bin\Debug\Zenject.dll'.
------ Rebuild All started: Project: Assembly-CSharp-Editor, Configuration: Debug Any CPU ------
error CS0009: Metadata file 'C:\XXX\Temp\UnityVS_bin\Debug\Zenject.dll' could not be opened -- Could not find a part of the path 'C:\XXX\Temp\UnityVS_bin\Debug\Zenject.dll'.
========== Rebuild All: 3 succeeded, 5 failed, 0 skipped ==========
Deleting all project/sln files fixes this issue, but it eventually comes back.

Use Rider its amazing BTW... but its paid...

On Linux with VSCode, I'm getting The type or namespace name 'PlaceholderFactory<>' could not be found (are you missing a using directive or an assembly reference?). I'm using Zenject; in the script this is coming from, and other Zenject classes. Haven't been able to get it working, tried deleting the .sln, tried reinstalling Extenject from Assets Store with everything checked, so I have to avoid using PlaceholderFactory :grimacing:

What unity and visual studio version are you on? I haven't had this problem in a long time, but I have no idea what fixed it.

just updated. ^ I'm not using Visual Studio, I'm using VSCode


AWS CloudTrail - Azure Native

Fixes #
Proposed Changes

Azure native Sentinel Data connector to ingest AWS CloudTrail Logs from centralized AWS S3 bucket - Receiving CloudTrail Log Files from Multiple Accounts

How about that.


Export the table issue content of the version comparison

As tester,
I want an export of the table content of the version comparison
in order to prepare my exhaustive test scenarii.

done by the PR #3


Add GLTF Scene Loader

Using the library cgltf, implements a GLTF scene laoder for BigWheels's scene graph.
Also, defines an interface for generic scene loaders, in case we come up with other ways of storing and loading scenes.

This code now being orphaned, and quite self contained (we don't break bigwheels by bringing it in), I would be fine to merge this as-is (minus the small fixes), and iterate from there, as long as this compiled on all 3 platforms.

@Keenuts ehh - I don't mind trying to address the comments directly in this PR, that way nothing slips through unaddressed. I don't think this PR is needed too immediately

@Keenuts can you re-review discussions above?


Ignoring root files generated by tests

BEGINRELEASENOTES

Ignoring root files generated by tests
ENDRELEASENOTES

Good idea, I think @jmcarcell  also planned to deploy a centrally managed .gitignoreto all repos from somewhere, we should take care to also get this into that.

Yeah I forgot about those root files, there may be more in other repos. I just synced the .gitignore from https://github.com/key4hep/key4hep-dev-utils/blob/main/defaults/.gitignore in all the repos. If that's fine we can close this PR


Add resources ReclaimSpaceCronJob and ReclaimSpaceJob

Short description: Add resources ReclaimSpaceCronJob and ReclaimSpaceJob
More details:
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for reviewer:
Bug:

/verified

rename the title, add description.

/verified

/verified

/verified

/verified

/verified

/verified

/verified

/verified

/verified


Fix filename decoding issue for zip files archived by macOS

this is how I fix https://github.com/jupyterlab-contrib/jupyter-archive/issues/74

well, I found this is not a good way to solve this problem
but anyone need this temporarily solution can refer my fork


input width will not adjust to 100%

I am attempting to adjust the width of the react-datepicker input box and surprisingly have found little information out there and am unable to effect it's width.  I would just like to make the input width 100% of it's containing div.
Expected behavior
The width should expand to the width of it's parent container.
My react-datepicker
<div className="myContainer">
  <DatePicker
    className="myDatePicker"
    fixedHeight
    readOnly={true}
    isClearable={false}
    placeholderText="My date"
    selected={this.props.defaultValue}
    onChange={(date) => this.props.handleDateChange(date)}
  />
</div>

Expected behavior
The following should result in the myDatePicker being the same width as the parent myContainer, but the width remains unchanged.
.myContainer {
  display: flex;
  flex-wrap: nowrap;
  flex-direction: row;
  flex: 1 1 0px;
}

.myDatePicker {
  width: 100%;  // note: if I change this value to a fixed value (such as 500px) then the width is effected
}

Closest Alternative attempt
The closest attempt was this, but it effects the width of the popup as well, causing it to stretch beyond the length of the entire screen, so this does not work as a solution either:
.myContainer div {
  width: 100%;
}

I have tried all of the following
.myDatePicker {
  width: 100%;
}

.myDatePicker * {
  width: 100%;
}

.react-datepicker__day-name, .react-datepicker__day {
  width: 10.9em;
}

/* .myContainer div:not(.react-datepicker-popper, .react-datepicker__week) { */
/* .myContainer .react-datepicker__input-container, .myContainer, .myContainer .react-datepicker-wrapper, .myContainer { */
/* .myContainer.react-datepicker__input-container, .container, .container.react-datepicker-wrapper, .container {  */
 .react-datepicker__input-container, .react-datepicker-wrapper, .container {
  width: 100%;
}

.container .react-datepicker__input-container, .container, .container .react-datepicker-wrapper, .container div {
  width: inherit;
}

.react-datepicker__input-container {
  width: 100%;
}

.container .react-datepicker-wrapper .react-datepicker-wrapper,
.container div:not(.react-datepicker-popper *) {
  width: 100%;
}

.container, .myDatePickerWrapper, .container .react-datepicker-wrapper, .container .react-datepicker__input-container {
.myDatePicker, .myDatePickerWrapper, .container .react-datepicker-wrapper, .container .react-datepicker__input-container {
  background: red;
  width: 100%;
  & :global .react-datepicker__input-container {
    width: 100%;
  }
}

.container, .react-datepicker-wrapper, .react-datepicker__input-container {
  width: 100%;
}
.myDatePicker, .react-datepicker-wrapper, .react-datepicker__input-container {
  width: 100%;
}

Actual behavior
The date picker remains the same length, unless a specific px value is set for the width.
Is this a bug?  Does anyone understand how to set the input width to 100% for react-datepicker?

Here is a codepen showing the issue - https://codepen.io/anon/pen/bjxENG

This is what worked for me.  By default, the Manager class is null.. give it a class name, then you can apply css to it.
Go to node_modules > react-datepicker > es > index.js > line 2456:
Change:
return React.createElement(
  Manager,
  null,         // NOTE: change this line
  React.createElement(
    Target,
    { className: "react-datepicker-wrapper" },
    targetComponent
  ),
  popper
);

To:
return React.createElement(
  Manager,
  { className:"react-datepicker-manager" },  // NOTE: changed this line to contain a className
  React.createElement(
    Target,
    { className: "react-datepicker-wrapper" },
    targetComponent
  ),
  popper
);

Then you can apply css like this to make the width 100%:
.myContainer .react-datepicker-manager,
.myContainer .react-datepicker-wrapper,
.myContainer .react-datepicker__input-container {
  width: 100%;
}

I was able to achieve this by setting the wrapper and input-container to be display: block (instead of the default display: inline-block)
.react-datepicker-wrapper, .react-datepicker__input-container {
  display: block;
}

You might want to check out the 'custom input' or 'portal inline version' in the docs
https://reactdatepicker.com/#example-30
https://reactdatepicker.com/#example-41

I'm using Semantic UI React and would like to set the input field to 100%, but am unable to do so. The previous solutions mentioned here do not work and have not found any solution in the docs.

There is to react-datepicker-wrapper & react-datepicker__input-containerwhich are set to be display: inline-block. It could be nice to have control on that. This example https://reactdatepicker.com/#example-30 doesn't work because it embed the futur custom input in a display-block element

@cmonkey03 Forcing <Form.Field style={{ width: "100%" }}> and setting .react-datepicker-wrapper, .react-datepicker__input-container { 	display: block !important; } as @lorenz068 suggested worked for me in Semantic UI React.

I was able to achieve this by setting the wrapper and input-container to be display: block (instead of the default display: inline-block)
.react-datepicker-wrapper, .react-datepicker__input-container {
  display: block;
}

display: block !important;

Adding important works for me.
Thanks

For me this works:
.react-datepicker-wrapper, .react-datepicker__input-container { display: block; }
.MyClass .react-datepicker-wrapper .react-datepicker__input-container input { width: 100% }

SOLUTION
.react-datepicker-wrapper, .react-datepicker__input-container { display: block; }
.MyClass .react-datepicker-wrapper .react-datepicker__input-container input { width: 100% }

.react-datepicker-wrapper, .react-datepicker__input-container { display: block !important; } .react-datepicker-wrapper .react-datepicker__input-container input { width: 100% }
adding !important worked for me!

This is how I solved this:

}
            />

    simply by adding a div around the DatePickerWrapper and giving it a custom width :)


qrcodegen: init at 1.6.0

Motivation for this change
Library is used in notcurses #106993
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Agreed, near as I can tell, none of those things exist in the package as deployed by upstream.

Agreed, near as I can tell, none of those things exist in the package as deployed by upstream.

Yup. That's why I am OK with the current form of the PR (and gave the green review). This is something for later.


"Message Result chan not found" on the 128th request

I have a strange error - I have a few hundred queries to run, each only differing in the basedn used. Every time I run the app, the 128th query fails with the same message:
Sending message 128
Receiving message<PHONE_NUMBER>
Message Result chan not found (possible Abandon), MessageID:<PHONE_NUMBER>

Every message before this succeeds, and I can confirm by seeing
MessageID: 127, ok: true
...
Sending message 127
Receiving message 127
...

I'm happy to send more information if needed, but does this give you any idea why the 128th query fails?

I believe this has to do with a bad cast but I am dealing with the same issue only in the mavricknz/ldap version of this. It is actually down in the asn1.ber library


Pre-Publish Checklist: Check cover image size

Feature Description
This is a follow-up to #4910 / #5086.
Since #5105 has been merged, we now pass the necessary information about the story cover image size in the API and handle it in useLoadStory, which means this item is unblocked:

Story portrait cover size too small (less than 640 x 853) or wrong aspect ratio (not 3:4)

Note: When updating the cover image, the right image size is not yet saved, see #5228. That likely needs updating.
Alternatives Considered

Additional Context

Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance Criteria

Implementation Brief

@swissspidy looks like this was implemented last week?

Yeah, I think this is a bug bash dupe!

Yep


servicebusexplorer: persist config file

added config file to be persisted in updates

Relates to #1313

[x] I have read the Contributing Guide.

/verify

/verify