Dynamic/Variant errors on insert (Code: 117. DB::Exception:)

Describe the bug
Some internal structures are incorrect when insert in Dynamic/Variant.
Steps to reproduce

insert into datatypes like:

"Map(String, Variant(String, UInt128, Bool))",
"Map(String, Dynamic)",

Expected behaviour
Insert successfully done.
clickhouse-connect and/or ClickHouse server logs
Variant:  Code: 117. DB::Exception: Invalid version for SerializationVariant discriminators column.: While executing Native. (INCORRECT_DATA) (version <IP_ADDRESS>1)
Dynamic: Code: 117. DB::Exception: Invalid version for Dynamic structure serialization: 4: While executing Native. (INCORRECT_DATA) (version <IP_ADDRESS>1)
Configuration
Environment

clickhouse-connect version: 0.8.10
Python version: 3.11/3.12
Operating system: linux

ClickHouse server

ClickHouse Server version: 24.11, 25.1.1 (from git repo)

Thanks for the report -- it looks like you have the problem on both 24.11 and 25.1 -- I assume the behavior is the same on both?

Yes, tested on both:

<IP_ADDRESS>7
<IP_ADDRESS>1


Support getting topic names and message types

🎉 New feature
Summary
Support returning a list of topics and their message types using the websocket server.
Test it
Run the websocket server, and request "topics-types". You can test using https://gitlab.com/ignitionrobotics/web/app/-/merge_requests/111
Checklist

[X] Signed all commits for DCO
[ ] Added tests
[ ] Added example and/or tutorial
[X] Updated documentation (as needed)
[ ] Updated migration guide (as needed)
[X] codecheck passed (See contributing)
[X] All tests passed (See test coverage)
[X] While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

LGTM! Works as intended.

@osrf-jenkins run tests please.


Fixed a problem with the datasource setter

plus changed 'datasource' to 'dataSource'

@pleasantlight Thanks!


Need good documentation and example of possible issues with activity and fragments lifecycles

Hi,
we were happy to find library but we found lack of warning about memory leaks with Action and Event listeners.
It is hard to write best example since many apps are using different approaches. But it would be nice to have example and documentation that warns you about possible references that leads to memory leaks.

agreed, the documentation should be more complete


Client magic methods break IDE autocompletion

Hello!
Consider this code:
<?php

namespace MyApp;

use GuzzleHttp\ClientInterface;

class ApiHandler
{
    /**
     * @var ClientInterface
     */
    protected $httpClient;

    /**
     * @param ClientInterface $httpClient
     */
    public function __construct(ClientInterface $httpClient)
    {
        $this->httpClient = $httpClient;
    }

    public function foo($data)
    {
        $response = $this->httpClient->post('foo');
    }
}

In the example above IDE has no idea what is the post() method and what is the type of the $response object. This really complicates my work, cause I need to manually introduce ad-hoc type annotations everywhere.
Maybe we should add those methods to the interface statically?
Thanks!

Those methods won't be added to the ClientInterface, but I'd be happy if you added them to Client. I also recommend that you use the request and send methods instead of relying on these methods.

This is a none issue and could be easily solved by php docblocks.
see the link below :
http://stackoverflow.com/questions/15634021/how-to-document-magic-call-and-callstatic-methods-for-ides
http://www.phpdoc.org/docs/latest/references/phpdoc/tags/method.html#examples

@imanghafoori1 that's a nice solution, thank you. Will keep it in mind ; )

Happy to help you that.
I am currently working on core Laravel Framewok files to provide IDE auto-completion.
It also worked very well for laravel-form-builder package.

why you define the variable as ClientInterface in docblock? Just set it to GuzzleHttp\Client to highlight all available method.

I've been wondering the same thing and I have some concerns about this.
@mtdowling Why won't these methods be added to the interface? What was the intent of the interface? Was it ever intended to be used in user land or is an internal thing?
@imanghafoori1 that does indeed solve the IDE problem but not the deeper problem that lies underneath.
The idea behind interfaces is that you can type hint for them and then pass any class that implements that interface to the method that hints for it. This also means that you must not call any method on the object you got passed that is not defined on the interface because it breaks the contract!
As soon as you call methods that are not defined in the interface the type hint is completely useless because the code doesn't follow the contract defined in said type hint.

Why won't these methods be added to the interface?

The most important reason is that it would be a breaking change for anyone whose implemented the interface.
I recommend using the request method and not coupling with the concrete Client class.

The whole idea behind interfaces in any programming language is to aid
programmers as human beings.
Some modern languages like python do not have anything like interfaces at
all.
And It is proven that large and enterprise applications are possible to
build without any problem because of lacking "interfaces".
So do not get heavily concerned with them.
در تاریخ ۱۹ آوریل ۲۰۱۶ ۲:۱۷ قبل‌ازظهر، "Michael Dowling" <
<EMAIL_ADDRESS>نوشت:

Why won't these methods be added to the interface?
The most important reason is that it would be a breaking change for anyone
whose implemented the interface.
I recommend using the request method and not coupling with the concrete
Client class.
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/guzzle/guzzle/issues/1235#issuecomment-211595911


OCI8/PDO_OCI: The process '/usr/bin/bash' failed with exit code 1

Describe the bug
We just observed today a new issue on doctrine/dbal, specifically with oci8
Version

[ ] I have checked releases, and the bug exists in the latest patch version of v1 or v2.
[x] v2
[ ] v1

Runners

[x] GitHub Hosted
[ ] Self Hosted

Operating systems
Ubuntu 20.04.2
PHP versions
8 and 7.4
To Reproduce
  phpunit-oci8:
    name: "PHPUnit on OCI8"
    runs-on: "ubuntu-20.04"
    needs: "phpunit-smoke-check"

    strategy:
      matrix:
        php-version:
          - "7.4"
          - "8.0"

    services:
      oracle:
        image: "wnameless/oracle-xe-11g-r2"
        ports:
          - "1521:1521"

    steps:
      - name: "Checkout"
        uses: "actions/checkout@v2"
        with:
          fetch-depth: 2

      - name: "Install PHP"
        uses: "shivammathur/setup-php@v2"
        with:
          php-version: "${{ matrix.php-version }}"
          extensions: "oci8"
          coverage: "pcov"
          ini-values: "zend.assertions=1"

      - name: "Install dependencies with Composer"
        uses: "ramsey/composer-install@v1"

      - name: "Run PHPUnit"
        run: "vendor/bin/phpunit -c ci/github/phpunit/oci8.xml --coverage-clover=coverage.xml"

      - name: "Upload coverage file"
        uses: "actions/upload-artifact@v2"
        with:
          name: "${{ github.job }}-${{ matrix.php-version }}.coverage"
          path: "coverage.xml"

  phpunit-pdo-oci:
    name: "PHPUnit on PDO_OCI"
    runs-on: "ubuntu-20.04"
    needs: "phpunit-smoke-check"

    strategy:
      matrix:
        php-version:
          - "7.4"
          - "8.0"

    services:
      oracle:
        image: "wnameless/oracle-xe-11g-r2"
        ports:
          - "1521:1521"

    steps:
      - name: "Checkout"
        uses: "actions/checkout@v2"
        with:
          fetch-depth: 2

      - name: "Install PHP"
        uses: "shivammathur/setup-php@v2"
        with:
          php-version: "${{ matrix.php-version }}"
          extensions: "pdo_oci"
          coverage: "pcov"
          ini-values: "zend.assertions=1"

      - name: "Install dependencies with Composer"
        uses: "ramsey/composer-install@v1"

      - name: "Run PHPUnit"
        run: "vendor/bin/phpunit -c ci/github/phpunit/pdo_oci.xml --coverage-clover=coverage.xml"

      - name: "Upload coverage file"
        uses: "actions/upload-artifact@v2"
        with:
          name: "${{ github.job }}-${{ matrix.php-version }}.coverage"
          path: "coverage.xml"

Expected behavior
No crash
Screenshots/Logs
https://github.com/doctrine/dbal/pull/4620/checks?check_run_id=2459951167#step:4:9
Additional context
That's context you already know, but there has been a release yesterday :wink:
Are you willing to submit a PR?
sorry, no.

@greg0ire The links to download the latest oracle's client and sdk are randomly resolving to older versions.
I have added a fix to handle that in https://github.com/shivammathur/setup-php/commit/9149639a33b1aac7b78d53f2858f5bb95adf79a1
Restart your workflow, it should run correctly now.
Test workflow: https://github.com/shivammathur/test-setup-php/actions/runs/788181361/workflow

Thanks, it does fix the issue!


Replacing SortBy with custom partitioner

Replacing bulkInsert sortby with custom partitioner such that;

Single output spark partition doesn't have records from more than one hoodie partition.
Trying to fit as many records with same hoodie partition as we can from same input spark partition into output spark partition.
@vinothchandar, @prazanna ,@n3nash , @jianxu

Can you make the partitioner pluggable?  Also could you share the performance analysis you did, since thats core aspect of this PR

and please merge both the commits together..

whats special about 4, that makes it work for all workloads ? >> Nothing special I just wanted to ensure that number of buckets are some multiple of output partitions.

Attaching the results
With SortBy

With UpsertPartitioner

@vinothchandar is it ok to limit the scope of this PR to just enable user to define their own partitioner for bulkInsert api? And keeping sortBy as the default way for bulkInsert? That way it is zero impact for existing users. Let me know what you think. I will open another issue to fix UpsertPartitioner random issue.

yeah that plan sounds good, Will review both PRs sometime this week

Spoke with @vinothchandar offline. Updated the PR. Now we are going to let users define their own partitioner logic.


reserved type names being used in CSharp generation

if you have a schema named integer, kiota will generate a model for that in CSharp. The issue is that is conflicts with the type name under System. We already have excluded the shorthands (like int) but it's not enough. @andrueastman would you mind putting together a PR to exclude type names under system please so we don't have conflicts?

Acknowledging this one @baywet


Implement GitHub PR Issue Checker Workflow

Fixes: #756
Usage:

When a pull request is created or edited, the workflow automatically triggers.

The workflow checks for:

A non-empty PR description.
A valid issue reference format (Fixes #<issue-number> or Fixes #NEW).

If either check fails, the PR will be marked as failing, and the author will receive clear error messages in the PR comments.
If all checks pass, a confirmation message will indicate that the PR is valid.

Note: Kindly add all the labels added to the issue, to this PR!

@smog-root it's coming like this.

@smog-root it's coming like this.

the user needs to use Fixes (#number of issue) to work!


Draft spec for pangeneset-based gene list translation UI

Initial thoughts here: https://github.com/legumeinfo/website-ui-specs/tree/main/pangeneset-based-gene-id-translation
feel free to propose changes in this issue or signify your consent (silence by the end of the week will imply consent).
Minor note, I tried using @sdash-github's plantuml for UI mockup (as described here: https://plantuml.com/salt); not sure if we'll decide to adopt this for more complex cases, but it seemed worth a try. If nothing else, it reminded me what a PITA specifying UI layout through use of nested tables can be (one of the reasons I never became a web developer, I think, though I know that's no longer the way...)

How important is it that the UI match what you've mocked up? It'll be easier (and stylistically consistent with our existing components) if the entire form, including the gene list, is above the results table.
Also, note that the GraphQL endpoint that was previously prototyped for this only returns genes with no notion of what genes corresponds to what input genes. This can be remedied by either introducing new types into the GraphQL API or requesting the output genes' pan gene sets and their genes and then doing some post-processing. Neither is ideal. An alternative is to revise the GraphQL endpoint such that it gets pan genes for a single input gene. The UI element would then send multiple requests to this endpoint when the form is submitted  - one for each gene in the input list.
The second option of the second bullet is probably the most canonical way to support this query in GraphQL, but the first option of the second bullet is probably the most pragmatic as it sets us up for .
Perhaps this belongs under "future enhancements"; do you want the table to be sortable by one or more columns?

It's not important to match the UI layout, that just seemed compact to me.
Having the actual correspondences between input genes and results is critical. The intermine queries I had specified did this, will have to double-check if they can be adapted to work with the "ONE OF" constraint instead of "IN LIST".
Not sure what your third paragraph refers to- seems like your thought got truncated there?
Sortable tables are always appreciated, but I think it's OK to leave that for a future enhancement.

I second all parts of the response by @adf-ncgr.
Regarding sorting: I'd say it's not even an enhancement in this case. My vote is to plan for "never sort."
The main requirements are:

Accept an input list of gene IDs and a target annotation accession+version
Return a table* that indicates correspondences between the input IDs, a pangene ID, and the target accession.
The table* needs to have a syntax that allows for one-to-null and one-to-many relationships.
Downloadable result (this might be OK to handle as a future enhancement, but it will be immediately desired)

Caveat regarding table* for the output: other structures might be acceptable, but a table is what will be most familiar to users. The additional wrinkle is representing one-to-many relationships, e.g.
Q1 pan9 A
Q2 pan8 B
Q3 pan1 none
Q4 pan2 C, D, E

Also, we'll need to be able to report an error message for query genes not found

Having the actual correspondences between input genes and results is critical. The intermine queries I had specified did this, will have to double-check if they can be adapted to work with the "ONE OF" constraint instead of "IN LIST".

Right. My point is that just because we can craft an intermine query that will give us all the results in one request doesn't mean it translates well into GraphQL. The most canonical way to handle this in GraphQL is via filtering. This would make our API more expressive, rather than more esoteric.

The additional wrinkle is representing one-to-many relationships, e.g.
Q1 pan9 A
Q2 pan8 B
Q3 pan1 none
Q4 pan2 C, D, E

@adf-ncgr's example in the UI spec handles the  one-to-many relationship by adding multiple rows for an input gene if it has multiple output genes - one row for each output gene. You're example here adds a single row and puts all of the output genes into the third column. Which way should this be handled? I lean towards what's currently in the spec as it prevents horizontal overflow when a particular input gene has many result genes.

Also, we'll need to be able to report an error message for query genes not found

The generic search component that this web component will be built on already supports this, although this particular error should be mentioned in the spec as it's specific to this component.

Not sure what your third paragraph refers to- seems like your thought got truncated there?

Sorry about that; remnants of a discarded thought. I edited it out.

Right. My point is that just because we can craft an intermine query that will give us all the results in one request doesn't mean it translates well into GraphQL. The most canonical way to handle this in GraphQL is via filtering. This would make our API more expressive, rather than more esoteric.

I'm confused. Didn't we implement the ONE OF constraint specifically for this purpose? The GraphQL page you linked seems fairly similar if you're talking about this bit:
query {
  queryPost(filter: {
    id: ["0x1", "0x2", "0x3", "0x4"],
  }) {
    id
    title
    text
    datePublished
  }
}

Regarding how to handle 1-to-many, I don't feel super-strongly about it, but my argument for doing it in the 1 row = 1 gene pair style is that if we were to augment the rows with additional info about the corresponding pair (e.g. "allelic" info like gene length) this would seem more natural.
Regarding query genes not found, I'm not completely sure how to deal with it in this context. I think @StevenCannon-USDA is referring to input tokens that do not match genes in the database, regardless of whether they belong to pangenes or correspond to genes in the target annotation via these pangenes. It almost seems like this would require the list to be validated separately, similar to how intermine list builder currently works. Could this be relegated to future enhancement land?

I lean towards what's currently in the spec as it prevents horizontal overflow when a particular input gene has many result genes.
Yes, that's fine by me.
Regarding query genes not found, ... I think @StevenCannon-USDA is referring to input tokens that do not match genes in the database
Right. It will not be uncommon for someone to enter funky stuff -- say, with splice variants, or coming from two different annotations, or wrongly prefixed. It would be nice to at least report which items aren't in the indicated query set. But it could be "relegated to future enhancement land" if implementation is a can'o'worms.

I'm confused. Didn't we implement the ONE OF constraint specifically for this purpose?

Sam implemented the ONE OF constraint as a prototype. It never got merged (or scrutinized) because we didn't make it this far in the discussion.

The GraphQL page you linked seems fairly similar if you're talking about this bit: <code>

That's not the bit I was referring to but it could be used to handle multiple input genes in a single request. What I'm really interested in is "While fetching nested linked objects, you can also apply a filter on them."
query {
  getGene(id: "...") {
    name
    panGeneSets {
      identifier,
      genes(filter: {
        genus: "...",
        species: "...",
        strain: "...",
        assembly: "...",
        annotation: "..."
      }) {
        identifier
      }
    }
  }
}

The implementation details of this would be to add assembly and annotation parameters to our existing gene search endpoint and updating the genes field of the PanGeneSet type to expose the necessary constraints.

Regarding query genes not found... It almost seems like this would require the list to be validated separately, similar to how intermine list builder currently works. Could this be relegated to future enhancement land?

If we take the "one-request-per-input-gene" approach I'm advocating here then reporting which genes weren't found becomes trivial since the GraphQL server throws an error when a gene can't be found for the given identifier.

Ok, I think I understand the commentary so far.   And I think I have few observations:
For SoyBase, I think we want to allow use of the "secondary id" ie, glyma.01g00100.  In the specification, you have to enter the query genus, species, assembly, and strain, so why do you need to use the full yuck as a query as it can be constructed on the fly?
For the output, I think the full yuck is grudgingly acceptable. The pangene_set id needs to be a link to the pangene report page.
Depending on the level of difficulty, ie If it is relatively easy, the download capability should be engineered in the 1.0 version. Granted people are not going to be using this tool to convert the names of hundreds of genes, but the need to copy-n-paste out of HTML tables should be avoided.
@StevenCannon-USDA @adf-ncgr  @alancleary @jd-campbell

For the output, I think the full yuck is grudgingly acceptable. The pangene_set id needs to be a link to the pangene report page.

As with the other web components, linking is a post-graphql, pre-web component step, i.e. the links are site specific and inserted after the data is fetched right before it's displayed. You link things wherever you want!

Depending on the level of difficulty, ie If it is relatively easy, the download capability should be engineered in the 1.0 version.

This is separate functionality that should be encapsulated in it's own component or utility script. We can pursue it in tandem with this UI element but it needs its own spec.

Granted people are not going to be using this tool to convert the names of hundreds of genes...

I bet you $1 they do.

If we take the "one-request-per-input-gene" approach I'm advocating here then reporting which genes weren't found becomes trivial since the GraphQL server throws an error when a gene can't be found for the given identifier.

I'm only concerned that one request per input gene won't be very performant, but could be convinced otherwise if you can prototype it (because you know you'll win that $1 bet with @maxglycine when I come up to the plate)

For SoyBase, I think we want to allow use of the "secondary id" ie, glyma.01g00100. In the specification, you have to enter the query genus, species, assembly, and strain, so why do you need to use the full yuck as a query as it can be constructed on the fly?

What you are specifying in the proposed UI is the target genus, species, assembly, and strain, not the query. It's possible that we should do similar for the query, but the current spec would allow mixed source inputs (which might not be all that useful, admittedly).

I'm only concerned that one request per input gene won't be very performant, but could be convinced otherwise if you can prototype it (because you know you'll win that $1 bet with @maxglycine when I come up to the plate)

OK. I'll see what I can come up with!

If we are concerned that users will try to "convert" names en masse from one assembly to another, I am OK with telling them there is a limit of say 50 per request to make it too painful to execute.
@alancleary @adf-ncgr @StevenCannon-USDA @jd-campbell

@maxglycine I think we ought to be able to handle 100s if not 1000s of genes whatever approach we decide to adopt here since this will (I hope) lay the foundation for other list-oriented services where imposing draconian limits might defeat the purpose (e.g. gene set enrichment analysis). Just my 2c though.

I agree with @adf-ncgr in that we need to preserve the linkage between the gene model name query and all of its related "pan" genes.  Whether that is multiple rows for each query gene model name ie:
glyma.Wm82.gnm4.ann1.glyma.01g00100PanGene1
glyma.Wm82.gnm4.ann1.glyma.01g00100PanGene2
...
...
or
glyma.Wm82.gnm4.ann1.glyma.01g00100PanGene1,PanGene2,...

Good Example from MaizeGDB
Ethy talked about it and demoed her creation for MGDB yesterday at AgBioData meeting. It is at:
Panagene work at MGDB with an example

This can be a good model for us to keep in mind as we make progress and for future development at LIS+.
It is backed by real community feedback and use.
Liked these [query page](https://maizegdb.org/pan_gene_center/pan_gene):(Advance search)  features.

Simple search allows you to find pan-genes by locus symbol, gene model ID, transcript ID, or protein ID.
Many contains/excludes/associated with genemodels, loci, %annotations
Textboxes(pre-filled) for annotations to include/exclude
Link to external tools.
Brief description of the this pangene analysis in maize
Definations(A great help for students/ removal of ambiguity is usage/ for non-maize visitors)

Liked these result-page features (in the collapsible headings) as very informative to put the result in context.

Pan-gene alignment
The phylogenetic tree (view of the result pangene sets)
3rd party comparative viewers (with succinct-specific info about how to use it)

(Other features like download, function, proteins, SNPs, etc.: we are aware of them or are going to include them).
My intention here is mainly for future development and not for the first prototype we will work on.
I think @StevenCannon-USDA and @maxglycine  are aware of this MGDB work but @adf-ncgr may not yet be.

Impressed because it looks so complete a tool !!

Hi everyone,
I prototyped a way of doing pangene list queries per gene by adding arguments to the genes fields of the PanGeneSet type in the GraphQL server. You can now get a list of pangenes for a specific gene by querying for that gene and filtering the genes of its pangene sets:
# query
query PangeneListQuery($identifier: ID!, $genus: String, $species: String, $strain: String, $assembly: String, $annotation: String) {
  gene(identifier: $identifier) {
    results {
      panGeneSets {
        genes(genus: $genus, species: $species, strain: $strain, assembly: $assembly, annotation: $annotation) {
          identifier
        }
      }
    }
  }
}

Here are the variables I used to verify the functionality: I'm sure someone here can come up with a more interesting pangene set to test this on:
{
  "identifier": "phavu.G19833.gnm1.ann1.Phvul.001G000200",
  "genus": "Phaseolus",
  "species": "vulgaris",
  "strain": "G19833",
  "assembly": "gnm1",
  "annotation": "ann1"
}

These changes have been pushed to the pangene-list branch in the graphql-server repo. Queries can be run by starting the server (npm start) and then going to http://localhost:4000/ in your web browser to use the Apollo Sandbox.

Very nice initial implementation, @alanclery! (June 18).
My feeling is that this would be quite acceptable as a first-pass solution - though putting a limiter on the number of queries would be important if performance is poor beyond some number.
Another feature that I think will be desired (albeit at the cost of some additional UI complexity and more development time) is to handle inputs that lack the full yuck, i.e. Glyma.01G002100 as an alternative to glyma.Wm82.gnm4.ann1.Glyma.01G002100. (Rex's earlier comment regarding "secondary id" is for this feature)
One way this could be accomplished is to provide two forms of this page -- one, taking unprefixed IDs, would have 10 specification fields -- five for the query and five for the target.
Alternatively, provide an optional sixth input field on this page, in which the user can provide a prefix string to be added to the query elements, e.g. glyma.Wm82.gnm4.ann1.
Of those two options, the second one looks better to me at the moment.
(I'll add: the reason that Glyma.01G002100 can't be used as-is without further specification is that it is found in three different annotations (glyma.Wm82.gnm2.ann1, glyma.Wm82.gnm4.ann1, glyma.Wm82.gnm5.ann1). In that case, the genes happen to correspond (they all belong to Glycine.pan5.pan27993); but there are cases where the unprefixed genes from different annotations are not the "same gene.")


Prevent .arrow file getting in an invalid state and generate different .arrow based on parse_func

🔧 Improve caching behavior for parse functions
🎯 Changes

🗃 Moved parse_func hash out of cache folder naming
📝 Use parse_func hash as the .arrow dataset filename instead
🔄 This allows regenerating datasets from cached responses when only the parse function changes
⚠ Added more helpful error messages for invalid parse functions
🧹 Added automatic cleanup of corrupted .arrow files to prevent cache getting stuck

✨ Benefits
Now you can:

Iterate on your parse function without re-running expensive LLM calls
Get clear guidance when your parse function returns invalid data
Avoid getting stuck with corrupted cache files

Closes #51
Closes #40

Can we merge into dev instead of main since dev is our "staging" branch now?

Merging into dev now.

Actually is this all better handled upstream? (we can add this in addition)
We can have some asserts on the output of parse_func which check if valid rows are being returned and raise exceptions there.

Handled row validation upstream to give specific feedback to the user

LGTM with handling validation upstream


Add Seaborn diagnostic

Description
This PR adds a diagnostic that provides a high-level interface to seaborn, a Python data visualization library based on matplotlib. This diagnostic is highly customizable (every seaborn plotting function is supported).
For this diagnostic, the input data is arranged into a single pandas.DataFrame, which is then used as input for the Seaborn function defined by the option seaborn_func.
In addition, this PR

adds a new category in the recipe doc for general-purpose diagnostics.
retires the deprecated seaborn.set() in favor of seaborn.set_theme() in all diagnostic that use it. seaborn.set is an alias of seaborn.set_theme, so this does not change any functionality.

Link to documentation: https://esmvaltool--3155.org.readthedocs.build/en/3155/recipes/recipe_seaborn.html
Example figure:

Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

[x] 🛠 This pull request has a descriptive title
[x] 🛠 Code is written according to the code quality guidelines
[x] 🛠 Documentation is available
[x] 🛠 Tests run successfully
[x] 🛠 The list of authors is up to date
[x] 🛠 Any changed dependencies have been added or removed correctly
[x] 🛠 All checks below this pull request were successful

New or updated recipe/diagnostic

[x] 🧪 Recipe runs successfully
[x] 🧪 Recipe is well documented
[x] 🧪 Figure(s) and data look as expected from literature
[x] 🛠 Provenance information has been added

To help with the number of pull requests:

🙏 We kindly ask you to review two other open pull requests in this repository

In my understanding, esmvaltool/diag_scripts/shared provides code that can be used within a diagnostic, but not as a diagnostic (i.e., called within a recipe). Since the seaborn diagnostic can be called from the recipe, I think it should not got there.
I will also add 1/2 more example plots (PDF) which can be produced with this diagnostic, so please do no merge just yet :sweat_smile:

Ok I guess this pne then falls in the validation recipes/diag category - a utility of sorts still. We should probably create a dedicated repo for these types. Please do add more plots, they look marvellous 🦄

Just added another example to the recipe and the doc:

This can be merged now from my side :rocket:


changed: bumped version of @affinidi/wallet-core-sdk

changed: bumped version of @affinidi/wallet-core-sdk

What is the purpose of this PR?
Merging it won't trigger any publishes, because versions of packages themselves are not changed.
Even if they were, clean install of wallet-browser-sdk will install the latest version of wallet-core-sdk matching ^6.0.0 (and 6.0.2 matches it) anyway.

What is the purpose of this PR?
Merging it won't trigger any publishes, because versions of packages themselves are not changed. Even if they were, clean install of wallet-browser-sdk will install the latest version of wallet-core-sdk matching ^6.0.0 (and 6.0.2 matches it) anyway.

Yes, that is correct for clean install, but in case someone already fetched 6.0.0 to be sure that proper version will be installed better pin 6.0.2 for confidence.


update of pyside version and bugfix

updated to pyside6-6.4.3
fixed maximize bug

not needed anymore


Suggestion: Card Holder Name

Hi,
I saw that there was a possible integration of the zip code, but in Europe, this feature is not very useful, for cons, the holder name is important. Is there a possibility to integrate?
Thanks
Robert

Please see #111


Scan QR code

What is the reason to have this "feature" in Geocaching application?

This is not support forum. We are running full support over emal and facebook. And it's not issue also. Closing.

https://www.userscripts.org/scripts/show/95134
I don't like your use of quotes because it already implies that this is not a good feature. If you want to create a bad mood, please go somewhere else. Thanks.

Maybe if you did explain this feature in manual, I didn't need to quote. I didn't know about this until your post.
I see now it is a good feature. I am sure I am not only one who didn't know what is it for. Thanks

Anyway I wanted to try it and installed Geocache QR Code for Greasemonkey on my FF 3.6.23 and it don't show the code.

You are right. I filed a bug against the script: https://www.userscripts.org/topics/90969

This script I didn't know. another use is to 'send' a cache to QR-Code on your phone and let someone else scan it. Much faster then searching for the gc.code manually.

Also the manual is not from us.

That's unfortunate.
But you could simply include https://www.userscripts.org/scripts/show/95134 link in change log. I don't think many people know about this useful feature.

It isn't limited to this Greasemonkey script.

Meanwhile, the script is working again (you need to update it).

Ok, where can I find (as ordinary user) more information?

https://market.android.com/details?id=cgeo.geocaching - There you have our "developers website entered"
http://www.cgeo.org/ - Our website
http://faq.cgeo.org/ - dummy questions like this
And one think is true. There is no link to manual from our page - only in c:geo itself
http://appmanualreader.sourceforge.net/manuals/cgeo/cgeo-help-en.html
or our redirect
http://manual.cgeo.org

Maybe I ask dummy questions, but FAQ does say nothing about what "Scan QR code" do. So again, where can I get that information?

It scans QR-codes. If you see one, you can scan it and if it contains a GC-code, it opens the cache. That's all.

But you said that it is not limited only to Greasemonkey script...I was expecting that you will tell me about more functions. No bother.

1 day ago from me:
This is not support forum. We are running full support over emal and facebook. And it's not issue also. Closing!

I was just trying to help. Whatever.


I Can't Download it

Hi,
excuse me for the disturb but i can't download your resource.
When i try to downloading it by clicking "Download via external ec..." on spigot, i'm brought to you site but there is an error.
Forbidden
You don't have permission to access /rp/docs/download.php on this server.

Let me check that, thank you.

Works again. I'm sorry


Fix broken headings in Markdown files

GitHub changed the way Markdown headings are parsed, so this change fixes it.
See bryant1410/readmesfix for more information.
Tackles bryant1410/readmesfix#1

Apparently everyone has made these pull requests...
These are all the same: #99, #98, #97, #96, #95, #94

Fixed by #93


Release v0.5.0

@JuliaRegistrator register
Release notes:

Add parameter name and description to model specification by @ConnectedSystems in https://github.com/open-AIMS/ADRIA.jl/pull/273
Adjust coral growth rate for size class 6 by @ConnectedSystems in https://github.com/open-AIMS/ADRIA.jl/pull/274
Remove references to Input Set by @ConnectedSystems in https://github.com/open-AIMS/ADRIA.jl/pull/275
Fix: calculate distance between sites by @ConnectedSystems in https://github.com/open-AIMS/ADRIA.jl/pull/276
Simplify display of model spec by @ConnectedSystems in https://github.com/open-AIMS/ADRIA.jl/pull/278
Parametric ResultSet by @ConnectedSystems in https://github.com/open-AIMS/ADRIA.jl/pull/279
Consolidate normalize by @ConnectedSystems in https://github.com/open-AIMS/ADRIA.jl/pull/280
Changes to site selection functions by @Rosejoycrocker in https://github.com/open-AIMS/ADRIA.jl/pull/282
Changes to address bug in site_selection example (addresses issue #285 ) by @Rosejoycrocker in https://github.com/open-AIMS/ADRIA.jl/pull/286
Consolidate Named array types to use NamedDims+AxisKeys by @ConnectedSystems in https://github.com/open-AIMS/ADRIA.jl/pull/287
Reduce allocations in load_domain() by @ConnectedSystems in https://github.com/open-AIMS/ADRIA.jl/pull/288
Add criteria parameter which indicates whether distance sorting is used. by @Rosejoycrocker in https://github.com/open-AIMS/ADRIA.jl/pull/290
Add function n_locations() to determine number of sites/reefs/clusters by @ConnectedSystems in https://github.com/open-AIMS/ADRIA.jl/pull/291
Miscellaneous cleanup by @ConnectedSystems in https://github.com/open-AIMS/ADRIA.jl/pull/293
Fix bug causing implausible juvenile indicator values by @ConnectedSystems in https://github.com/open-AIMS/ADRIA.jl/pull/294
CompatHelper: add new compat entry for AxisKeys at version 0.2, (keep existing compat) by @github-actions in https://github.com/open-AIMS/ADRIA.jl/pull/297
Adjust samples when use of distance thresholds is turned off by @ConnectedSystems in https://github.com/open-AIMS/ADRIA.jl/pull/295
Additional safety checks for sampling by @ConnectedSystems in https://github.com/open-AIMS/ADRIA.jl/pull/298
Adds sampler which can sample only parameters needed for site selection by @Rosejoycrocker in https://github.com/open-AIMS/ADRIA.jl/pull/299
Fix error mapping continous samples to discrete values by @ConnectedSystems in https://github.com/open-AIMS/ADRIA.jl/pull/305
Adds function which calculates sites selection frequency for a set of provided samples by @Rosejoycrocker in https://github.com/open-AIMS/ADRIA.jl/pull/301
Adjust shelter volume to remove hardcoded index and leverage NamedDimsArray by @ConnectedSystems in https://github.com/open-AIMS/ADRIA.jl/pull/306
Fix initial slice potentially not including lowest value by @ConnectedSystems in https://github.com/open-AIMS/ADRIA.jl/pull/307
Clean up Project.toml + Precompile by @ConnectedSystems in https://github.com/open-AIMS/ADRIA.jl/pull/309
Initial indicative visualization by @ConnectedSystems in https://github.com/open-AIMS/ADRIA.jl/pull/318
Fix function extension issues by @ConnectedSystems in https://github.com/open-AIMS/ADRIA.jl/pull/319
Better check for constancy in RSA by @ConnectedSystems in https://github.com/open-AIMS/ADRIA.jl/pull/320
Update exploration tool to latest ADRIA API by @ConnectedSystems in https://github.com/open-AIMS/ADRIA.jl/pull/321
Additional docs for Domain/ResultSets by @ConnectedSystems in https://github.com/open-AIMS/ADRIA.jl/pull/322
Add capability to fix factors in place by @ConnectedSystems in https://github.com/open-AIMS/ADRIA.jl/pull/325
Initial ReefMod interface and functionality by @ConnectedSystems in https://github.com/open-AIMS/ADRIA.jl/pull/326
Correct issue with size of NamedDims array for storing ranks in run_site_selection() by @Rosejoycrocker in https://github.com/open-AIMS/ADRIA.jl/pull/310

Registration pull request created: JuliaRegistries/General/81714
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.5.0 -m "<description of version>" 9378df91fba1a35e48fd729d46d53da70a85d98b
git push origin v0.5.0


Restore GetAwaiter behavior of TaskBlockingExpressionVisitor.

And corresponding changes to task lifting and Include compiler.

No tests?

@smitpatel Used heavily by existing tests.


Lecture 2 Slide 25 - incorrect indexing

Dense BoW is "[0,0,0,1,1,0,1,0,0,**0,**2, ...]" but should be [0,0,0,1,1,0,1,0,0,2, ...]
(Note: Created this issue before but used wrong account)

Very well spotted! Thank you. 2 points for a challenging find.


[CWS] remove fim_enabled need on windows

What does this PR do?
Before 7.54 (while windows frim was in beta), we gated fim on a specific config flag fim_enabled to allow the process based rules to go GA with frim disabled.
Now that we are confident in windows frim we can move to the same way it's done on linux, i.e. runtime_security_config.enabled enables everything.
Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

/merge


Allow styles in the date input field

This change will give more liberty to the user when using the input for the date. It allows to apply styles to the input by using the prop input-classes:

It is compatible with the current version clear-button prop can still be used.

have eslint error @gorkau


Specify state-specific ReCom/Gerrychain parameters

The state-by-state requirements are public in ALARM:

https://arxiv.org/abs/2206.10763
https://github.com/alarm-redist/fifty-states/tree/main/analyses

I have cloned the repo.

Maybe this?
https://arxiv.org/abs/2206.10763

They are pulled into a document here.

We're creating "vanilla" ensembles


Nullable primary keys (MySQL version 5.7)

An error occurred while migrating a data model which inherits another data model. The migration tries to add a nullable primary key column which is not allowed for MySQL version 5.7 and above

This issue has been resolved in version 0.1.5. A primary key column always treated as non-nullable column


method_missing no longer supported in Chef 13

apt-repo relies on method_missing:
       NoMethodError
       -------------
       private method `method_missing' called for cookbook: server_base, recipe: go :Chef::Recipe

       Cookbook Trace:
       ---------------
         /tmp/kitchen/cache/cookbooks/apt-repo/libraries/apt-repo.rb:7:in `rescue in dont_clone_resource'
         /tmp/kitchen/cache/cookbooks/apt-repo/libraries/apt-repo.rb:3:in `dont_clone_resource'
         /tmp/kitchen/cache/cookbooks/apt-repo/definitions/apt-repo.rb:41:in `block in from_file'
         /tmp/kitchen/cache/cookbooks/apt-repo/definitions/ppa.rb:33:in `block in from_file'
         /tmp/kitchen/cache/cookbooks/server_base/recipes/go.rb:3:in `from_file'

       Relevant File Content:
       ----------------------
       /tmp/kitchen/cache/cookbooks/apt-repo/libraries/apt-repo.rb:

         1:  module AptRepo
         2:    # ugly hack to prevent resource cloning
         3:    def self.dont_clone_resource(recipe, resource_type, resource_name, &block)
         4:      recipe.resources(resource_type => resource_name)
         5:    rescue Chef::Exceptions::ResourceNotFound
         6:      # Chef uses method missing magic
         7>>     recipe.method_missing(resource_type, resource_name, &block)
         8:    end
         9:  end
        10:

       System Info:
       ------------
       chef_version=13.7.16
       platform=ubuntu
       platform_version=16.04
       ruby=ruby 2.4.3p205 (2017-12-14 revision 61247) [x86_64-linux]
       program_name=chef-client worker: ppid=97;start=20:48:50;
       executable=/opt/chef/bin/chef-client

This is now removed from Chef 13 and apt-repo no longer works with the latest versions of Chef - https://github.com/chef/chef-rfc/blob/master/rfc052-missing-method-missing.md

Thanks for the bug report, @rjlee.
I am not currently using Chef for any projects, so I will have to look into this.

@rjlee Could you give the latest master branch a shot?
In the long run you might be better off using the official apt cookbook. I stopped using Chef myself quite some time ago, which is why I have not updated this project for so long.


Host should not return a redirect source file from getSourceFile

🐞 Bug report
Command (mark with an x)

- [x] build

Is this a regression?

Yes and No
Description
When building the project in watch mode any subsequent  build after the first one generates this error:
ERROR in Debug Failure. False expression: Host should not return a redirect source file from `getSourceFile`

The reason seems to be that TypeScript has a way of identifying identical type definition files from different paths and adds something called redirectInfo. Since TS 2.8 (i think) the compiler throws an error when you add the original file instead instead of it's redirect target, so the build fails.
This is happening in both Angular 7 and when using Ivy in Angular 8.
console.log(sf.fileName);
console.log(sf['redirectInfo'].redirectTarget.fileName);
--------------------------
<EMAIL_ADDRESS><EMAIL_ADDRESS>--------------------------

Source of the problem:
angular/packages/compiler-cli/src/transformers/program.ts
tmpProgram.getSourceFiles().forEach(sf => {
    if (this.hostAdapter.isSourceFile(sf.fileName)) {
    	sourceFiles.push(sf.fileName); <!-- When adding a file with a redirectTarget we get an error later on
    }
    if (TS.test(sf.fileName) && !DTS.test(sf.fileName)) {
        tsFiles.push(sf.fileName);
    }
});

Possible fix:
tmpProgram.getSourceFiles().forEach(sf => {
    if (this.hostAdapter.isSourceFile(sf.fileName)) {
    	// Not sure why there isn't defintions for this
    	if ((sf as any)['redirectInfo']) {
         	sf = (sf as any)['redirectInfo'].redirectTarget;
      	}
    	sourceFiles.push(sf.fileName);
    }
    if (TS.test(sf.fileName) && !DTS.test(sf.fileName)) {
        tsFiles.push(sf.fileName);
    }
});

This also happens in:
angular/packages/compiler-cli/src/ngtsc/typecheck/src/context.ts
for (const originalSf of originalProgram.getSourceFiles()) {
    const sf = this.transform(originalSf);
    sfMap.set(sf.fileName, sf);
    if (!sf.isDeclarationFile && this.opMap.has(originalSf)) {
        interestingFiles.push(sf);
    }
}

Can be fixed by the same strategy:
for (const originalSf of originalProgram.getSourceFiles()) {
    const sf = this.transform(originalSf);
	if ((sf as any)['redirectInfo']) {
     	sf = (sf as any)['redirectInfo'].redirectTarget;
  	}
    sfMap.set(sf.fileName, sf);
    if (!sf.isDeclarationFile && this.opMap.has(originalSf)) {
        interestingFiles.push(sf);
    }
}

🔬 Minimal Reproduction

npm i
npm run dev
Go to http://localhost:8888
Change any source code to trigger the watcher to rebuild
Profit!
-->

🔥 Exception or Error

ERROR in Debug Failure. False expression: Host should not return a redirect source file from `getSourceFile`

🌍 Your Environment

@angular/*: 8.0.0-rc.4
@angular/cdk: 8.0.0-rc.1
@angular/material: 8.0.0-rc.1
@angular/http: 8.0.0-beta.10
@angular-devkit/build-optimizer: 0.800.0-rc.4
rxjs: 6.5.2
ts-node: 8.1.0
typescript: 3.4.5
webpack: 4.31.0
webpack-cli: 3.3.2

Anything else relevant?

Duplicate, but without repro steps and in the wrong issue tracker: https://github.com/angular/angular/issues/22524
I've been monkey patching "program.js" for a long time and have not met any problems with the solution suggested above.

Hi @JonWallsten, thanks for reporting this however as you mentioned this issue is being tracked in https://github.com/angular/angular/issues/22524, which is the correct issue tracker for compiler and compiler-cli issues.

@alan-agius4 Ah, that's too bad, then I guess I'll have to keep monkey patching. No one over at angular/angular seems to care about the issue.


CAMEL-18473: correct knative CloudEvent time format (#8306)

cherry-pick for PR https://github.com/apache/camel/pull/8306

Since camel 3.18.2 is still on vote. I don't know if it"s possile to push to the camel-3.18.x branch yet ?


SW-5122 Make the ToDo name fluidly shrink with an ellipsis

#2522  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @nickgraz and the rest of your teammates on  Graphite


Add space to registry key

The Windows NT registry key was missing a space, and it was also referred to as a 'hive', instead of a 'key'.

Good point, I am fairly sure that HKEY_ is a shortened form of HIVE_KEY so that would mean that only the top level is a hive.

https://docs.microsoft.com/en-us/windows/win32/sysinfo/registry-hives


perf(db): decode and decompress directly from borrowed data instead

Change decode<B: Into<Bytes>>(...) to decode<B: AsRef<[u8]>>(...)
Change decompress<B: Into<Bytes>>(...) to decompress<B: AsRef<[u8]>>(...)
But the real change is in the way we get our data from libmdbx-rs.
So far, if a page is dirty, libmdbx-rs copies it right away. (allocation 1)
https://github.com/paradigmxyz/reth/blob/main/crates/storage/libmdbx-rs/src/codec.rs#L31-L39
We then take that data and as far as I can see, we always decode it right away as well. Which involves further allocations.  So why not skip allocation 1 whether it's dirty or not ?
Before:

After:

It should make all stages faster, especially ones that spend most of their time reading from the db:
Benchmarks

Codecov Report

Merging #2050 (b0a7853) into main (7c1bd7c) will decrease coverage by 27.37%.
The diff coverage is 84.61%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@             Coverage Diff             @@
##             main    #2050       +/-   ##
===========================================
- Coverage   72.83%   45.47%   -27.37%
===========================================
  Files         428      428
  Lines       52481    52503       +22
===========================================
- Hits        38227    23875    -14352
- Misses      14254    28628    +14374

Flag
Coverage Δ

integration-tests
19.46% <24.61%> (+0.04%)
:arrow_up:

unit-tests
36.20% <84.61%> (-30.88%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

crates/storage/db/src/abstraction/table.rs
0.00% <ø> (ø)

crates/storage/db/src/tables/utils.rs
50.00% <53.84%> (-35.30%)
:arrow_down:

crates/storage/db/src/tables/models/mod.rs
69.69% <55.55%> (-0.90%)
:arrow_down:

crates/storage/codecs/src/lib.rs
64.35% <100.00%> (-29.62%)
:arrow_down:

crates/storage/db/src/tables/codecs/compact.rs
86.95% <100.00%> (ø)

crates/storage/db/src/tables/codecs/scale.rs
100.00% <100.00%> (ø)

crates/storage/db/src/tables/models/accounts.rs
83.58% <100.00%> (-10.54%)
:arrow_down:

...rates/storage/db/src/tables/models/integer_list.rs
100.00% <100.00%> (ø)

crates/storage/db/src/tables/models/sharded_key.rs
100.00% <100.00%> (ø)

...torage/db/src/tables/models/storage_sharded_key.rs
100.00% <100.00%> (ø)

... and 1 more

... and 201 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@onbjerg PTAL and merge if good

In general LGTM, but I am unsure why we need the feature flag? Should we not just use this everywhere?

Yeah I think probably just a bit scary to remove that code? We hsould be using this everywhere

yeah that was the rationale, but open to remove the flag


I tried your Version 15 but can't compile

Arduino: 1.8.8 (Windows 10), Board: "WeMos D1 R1, 80 MHz, Flash, 4M (3M SPIFFS), v2 Lower Memory, Disabled, None, Only Sketch, 921600"
sketch\GfxUi.cpp: In member function 'void GfxUi::drawBmp(String, uint8_t, uint16_t)':
GfxUi.cpp:208:53: error: no matching function for call to 'Adafruit_ILI9341::writePixel(uint16_t)'
           _tft->writePixel(_tft->color565(r,g,b));

                                                 ^

sketch\GfxUi.cpp:208:53: note: candidate is:
In file included from sketch\GfxUi.cpp:7:0:
C:\Users?????\Documents\Arduino\libraries\Adafruit-GFX-Library-master/Adafruit_SPITFT.h:212:8: note: virtual void Adafruit_SPITFT::writePixel(int16_t, int16_t, uint16_t)
void writePixel(int16_t x, int16_t y, uint16_t color);
    ^

C:\Users?????\Documents\Arduino\libraries\Adafruit-GFX-Library-master/Adafruit_SPITFT.h:212:8: note:   candidate expects 3 arguments, 1 provided
exit status 1
no matching function for call to 'Adafruit_ILI9341::writePixel(uint16_t)'
This report would have more information with
"Show verbose output during compilation"
option enabled in File -> Preferences.
This is the Display I have, and connected is everything as you stated in your list here. so soldering is correct.
https://www.aliexpress.com/item/32418555703.html?spm=a2g0s.90423<IP_ADDRESS>424c4dsTXapU

Hi @dansche...
This version (v15) is quite old now and as noted in the README, was based on the WeatherUnderground data, which no longer provides free API's.  So, unless you have a paid API, you won't be able to run this one.  Instead, if you want to try the OpenWeatherMap re-write, try my v17 here:
https://github.com/fowlerk/ESP8266-Color-Weather-Station-v17
Pay close attention to the core and library versions noted in the README...I suspect the error you're getting is related to a change in the Adafruit GFX library for a newer version than I used.  A similar error was reported on v17 recently, and once recompiled with the version noted, it compiled fine.
I have not had time to track down the changes made to the latest library which caused the problem in order to correct it.


[Feature] Commandline accessibility added up!

Have added the command line accessibility. The program runs seamlessly using a file.vic.
Install the package
git clone https://github.com/capjamesg/visionscript.git

cd visionscript

pip install -e .

Sample usage :
❯ vscript --file prog.vic

Sample output :
Tree(Token('RULE', 'expr'), [Tree(Token('RULE', 'load'), [Token('STRING', '"photo.jpg"')]), Token('EOL', '\n')])
Tree(Token('RULE', 'expr'), [Tree(Token('RULE', 'detect'), [Token('STRING', '"person"')]), Token('EOL', '\n')])
Tree(Token('RULE', 'expr'), [Tree(Token('RULE', 'say'), []), Token('EOL', '\n')])

['person'] 0.85 [          0      16.443      112.96      170.44]

known issue
Though it has some minor issue while running in console mode
sample input :
❯ vscript --repl console

Welcome to VisionScript!
Type 'Exit[]' to exit.
Read the docs at https://visionscript.org/docs
For help, type 'Help[FunctionName]'.
--------------------
>>> Load["photo.jpg"]

Error :
File "~/visionscript/visionscript/lang.py", line 815, in main
    activate_console(parser)
  File "~/visionscript/visionscript/lang.py", line 771, in activate_console
    tree = parser.parse(code.lstrip())
  File "~/visionscript/env/lib/python3.7/site-packages/lark/lark.py", line 645, in parse
    return self.parser.parse(text, start=start, on_error=on_error)
  File "~/visionscript/env/lib/python3.7/site-packages/lark/parser_frontends.py", line 96, in parse
    return self.parser.parse(stream, chosen_start, **kw)
  File "~/visionscript/env/lib/python3.7/site-packages/lark/parsers/earley.py", line 274, in parse
    raise UnexpectedEOF(expected_terminals, state=frozenset(i.s for i in to_scan))
lark.exceptions.UnexpectedEOF: Unexpected end-of-input. Expected one of:
        * EOF
        * SPACE
        * EOL

Thank you for your contribution! I am closing this PR since I have refactored the CLI and added many new functionalities. If you see any deficiencies in the current CLI that could be worked on, we can pick up the discussion!


Add push action support to PushNotificationIOS

This fixes some issues I've had with the PushNotificationIOS library.
The biggest change is adding support for push actions.
Currently it's impossible to schedule a silent local notification, since empty
notification sounds are replaced with the default sound. This commit deprecates
this use of the API in favor of passing an explicit sound name and adding a
getDefaultSoundName() method.
Test plan: This code is already running in our production app; just cleaned up
to merge upstream.

By analyzing the blame information on this pull request, we identified @JAStanton and @nicklockwood to be potential reviewers.

@nicklockwood @JAStanton ping. If this diff is too hefty I can take some time to break it up, just let me know thanks!

I just looked through it, looks good from my perspective but I'm no FB Engineer :). I wasn't aware of the latest OS changes to push notifications. Sounds like UILocationNotification will be around for a while but it'll be deprecated, also looks like the new local notifications will have the ability to pop an alert / sound / badge while the app is running. That's new, but only if you use the notification manager interface? Does that sound right?
Either way thanks for putting this together!

Spot on - this diff just exposes more of the existing ios 9 notification API. UILocationNotification should work fine in ios10, though it'll be deprecated. At some point PushNotificationIOS will need more work to support the new UserNotification framework & features (like showing notifications while the app is in the foreground).
Thanks for taking a look!

It's been a while since the last commit was reviewed and the labels show this pull request needs review. Based on the blame information for the files in this pull request we identified @JAStanton as a potential reviewer. Could you take a look please or cc someone with more context?

Sorry for the delay here, let me see if I can find someone to review this.

Can you take care of the conflicts first?

Going to close this for now as I'm afraid it's gotten stale, and it's less useful now that there's a new push API on iOS


[4594] Add new guidance pages

Context
Trello: https://trello.com/c/SHnCG4gJ/4594-create-page-for-dates-and-deadlines-for-the-2022-to-2023-academic-year
This is the new guidance page 'Dates and deadlines'. I have used an ERB template because the page is predominantly a table. This is probably better suited to HTML.
I have not put the content in translations files but can do so if necessary.
Changes proposed in this pull request

new route 'guidance/dates-and-deadlines'
new controller method def dates_and_deadlines
new ERB file 'guidance/dates_and_deadlines.html.erb'

Guidance to review

ERB file instead of markdown because the page is a table and not longform content
No translation files added - can change if we think we need them

Important business

[ ] Does this PR introduce any PII fields that need to be overwritten or deleted in db/scripts/sanitise.sql?
[ ] Does this PR change the database schema? If so, have you updated the config/analytics.yml file and considered whether you need to send 'import_entity' events?

NB: Please notify the #twd_data_insights team and ask for a review if new fields are being added to analytics.yml

 Create page for ‘Dates and deadlines for the 2022 to 2023 academic year’


Issue with RootPackageLoader.php on line 162

I tried using composer to install your dependencies but got the error: require-dev.mikey179/vfsStream is invalid, it should not contain uppercase characters. Please use mikey179/vfsstream instead.

I discovered it was an internal error within my composer.json file. I have successfully installed it.


Can't install on symfony 3.2

Problem 1
- Conclusion: remove cboden/ratchet v0.3.6
- Conclusion: don't install cboden/ratchet v0.3.6
- don't install gos/web-socket-bundle 1.8.x-dev|don't install cboden/ratchet v0.3.6
- don't install gos/web-socket-bundle v1.8.0|don't install cboden/ratchet v0.3.6
- don't install gos/web-socket-bundle v1.8.1|don't install cboden/ratchet v0.3.6
- don't install gos/web-socket-bundle v1.8.2|don't install cboden/ratchet v0.3.6
- don't install gos/web-socket-bundle v1.8.3|don't install cboden/ratchet v0.3.6
- don't install gos/web-socket-bundle v1.8.4|don't install cboden/ratchet v0.3.6
- don't install gos/web-socket-bundle v1.8.5|don't install cboden/ratchet v0.3.6
- Installation request for cboden/ratchet ^0.3.6 -> satisfiable by cboden/ratchet[v0.3.6].
- Installation request for gos/web-socket-bundle ^1.8 -> satisfiable by gos/web-socket-bundle[1.8.x-dev, v1.8.0, v1.8.1, v1.8.2, v1.8.3, v1.8.4, v1.8.5].

Hi,
Show me your composer file

@AntoineTesson ,thank you ,  I am using sylius composer file?

Hey,
It's not related to symfony 3.2 specially. You can't use cboden/ratchet as websocket register a fork of this repository with the same namespace.
https://github.com/GeniusesOfSymfony/Ratchet
It's the same as the original (same namespace, a BC on internal class only), plus tweaks to make it work properly with this bundle.
Remove cboden/ratchet from your composer file, this bundle will install ratchet for gos.

@ProPheT777 ,  thank  for your help ,  it works now.


Firefox #1146442 is fixed since v52

See comment 8 and the subsequent ones:
https://bugzilla.mozilla.org/show_bug.cgi?id=1146442#c8
I also did some manual testing and can confirm this is fixed for sure since v52 (but not in v51)

Ping @philipwalton

@philipwalton this can be merged as well.

Thanks!


fix(entities-plugins): ai-proxy-advanced form

Summary

This is a temporary workaround for the issue that the ai-proxy-advanced plugin cannot be created if users don't provide config.embeddings or config.vectordb.
KM-675

Ideally yes, we should keep them consistent. But it is not easy to do given the current implementation, as we are copying the payload so that it can be transformed. Will revisit if necessary.


Swagger spec is invalid

Issue description
The swagger spec contains a number of errors and cannot be used for codegen. I tested the version on master as well as the 4.0.7 tag.
Steps to reproduce

Copy the swagger spec (by either downloading it or ctrl+c and ctrl+v, or importing from the url)
Paste it into editor.swagger.io or any other swagger validator or codegen
Observe the big wall of errors

Information to attach
Here are all the errors output by the swagger command line tool

The swagger spec is available for API documentation purposes only (effectively for https://linuxcontainers.org/lxd/api/master/) and not for use with code generation. LXD actively relies on a bunch of things which swagger cannot represent (protocol over websocket, TLS based authentication, ...).

Closing as we're not aiming for a valid spec but instead for a spec which generates the output we want for our online doc.
In an ideal world, both would be the same, but it's currently not the case and fixing most of the reported issues would actually regress the API documentation that we generated.
It looks like some of what we're doing (like examples for parameters) is supported by some of the swagger tools because of OpenAPI 3.0 supporting those features. Unfortunately the tooling on the Go side currently doesn't make it easy for us to just generate OpenAPI 3.0 instead, so we'll be stuck with what we have now for a little while longer at least.


Can't config_save for a second time on UWB boards

On the UWB boards I can change parameters and store them to flash using the config_savecommand in the shell. But if I want to change more parameters and save again, the command returns OK. while discarding the new changes and loading the previous config.

Not sure if we keep this in sync. I would make the issue on https://github.com/cvra/robot-software/issues


idea/proposal: resources and component parameters for systems

This is a proposed API change to make it a bit nicer to work with entity components.
Instead of the arguments to the system call, systems provide the components you've asked for like this:
move = world.system({ Position, Velocity, Timing }, function(entity, p, v, t)
  -- p == entity[Position], v, t similarly
end

So you don't need to dereference like entity[Position] or declare a local variable, which saves a couple of tokens per use.
I had a go at keeping the ... functionality but it felt a bit nasty, so instead I've implemented resources (with a nod to Bevy)
which are global objects that show up in all entities via their metatable (for example Timing in the above). So there's no need to pass things directly to systems in the update function.
The additions make PECS 46 tokens longer, but coincidentally in the particles example 46 tokens are saved with the simpler syntax. So I'd expect an overall saving for any more complex game.
The naive metatable approach has the performance drawback that queries check for the existence of resources on every entity, which they don't really need to do. But this happens only when entities are created or components rearranged, and this can likely be optimized if needed.

yeah, global variables are better. all you actually need to share data between entities is this
local timing = world.component{shared=TIMING}```

I do still like having the component variables automatically provided, because I'm guaranteed to need them, but I don't think that on its own is worth breaking the API


expect does not time out when there is no data

the expect function does not time out when there is no incoming data.

fixed by #4

In what cases did this happen? I get a timeout routinely when there is no incoming data.


Unnecessary imports or not shortened class names

In FileReader example from AskBayou:
import java.io.BufferedReader;
...

public class TestIO {

  void read(String file) {
...
        br1 = new java.io.BufferedReader(fr1);
...
}

Fully qualified name used in try-block for class which is already imported.

Fixed in 12abc4adce395c71e182d6e4245b1ff21679f4b3.


[WIP] Upgrade to haproxy 1.8.1

Use haproxy's new master worker, remove old iptables / sleep / lock hacks.

:bangbang: BREAKING CHANGE: If you are using a custom HAPROXY_HEAD template, you must remove "daemon" and add  "expose-fd listeners".

Require testing and a maybe way to auto fix custom HAPROXY_HEAD templates before merging.

Can one of the admins verify this patch?

@vixns Aside from the lack of testing and HAPROXY_HEAD configurations, any reasons why you would consider this incomplete (WIP)?  Based on my rough testing, it looks like it works.  Thinking about cutting a beta build.

haproxy 1.8 is still young and buggy with h2, we should wait for a few more minor versions. I'm still using it only on testing environments.
I think merging this PR may be sufficient as an alpha build, along a small release note.
More testing and documentation are required before reaching beta quality.

FYI @vixns I'm merging this to a new branch.  Gonna add some quick handling of the daemon and expose stuff, and cut a build.


github repo clean up

I've completed the process of changing 12 repositories from public to private. I've also maintained a list of the repositories that were updated to private status. I'm currently reviewing additional repositories to identify any that are empty.
Report sheet - https://docs.google.com/spreadsheets/d/1sTKyop1a662JchZk4JDcQVJWZ7x1xMoEXoqbRHt8_fQ/edit?gid=0#gid=0

On Aug 19-30 iteration i have completed the below items. Since the iteration is ended up and there are some tasks to taken care. I am closing this card and in the current iteration.
Completed Details
I've completed the process of changing 12 repositories from public to private. I've also maintained a list of the repositories that were updated to private status. I'm currently reviewing additional repositories to identify any that are empty.
Report sheet - https://docs.google.com/spreadsheets/d/1sTKyop1a662JchZk4JDcQVJWZ7x1xMoEXoqbRHt8_fQ/edit?gid=0#gid=0
Pending Details []

[working on more repo audit for cleanup]

No work on this week beucase of working on Win Room


Drag and drop is not working

mantine-react-table version
v0.9.3
react & react-dom versions
v18.2.0
Describe the bug and the steps to reproduce it
when i using props about column or row drag with other library called react-dnd-treeview or react-arborist, drag and drop is not working. i think react-dnd is conflicting. could you please check this bug?
Minimal, Reproducible Example - (Optional, but Recommended)
.
Screenshots or Videos (Optional)
No response
Do you intend to try to help solve this bug with your own PR?
None
Terms

[X] I understand that if my bug cannot be reliably reproduced in a debuggable environment, it will probably not be fixed and this issue may even be closed.

There was a duplicate convo a while ago in the mui version of this library https://github.com/KevinVandy/material-react-table/issues/102
There are some solutions discussed here https://github.com/react-dnd/react-dnd/issues/3304
This is an issue caused by react-dnd itself


WIP: RHODS: allow creating prepared clusters on demand

/test ods-jh-on-ocp

/test help

/test ods-get-cluster

/test jh-on-single

/test ods-jh-on-single
On Mon, Jul 11, 2022 at 8:51 PM openshift-ci[bot] @.***>
wrote:

@kpouget https://github.com/kpouget: The specified target(s) for /test
were not found.
The following commands are available to trigger required jobs:

/test 4.10-e2e-mlperf-ssd-pr-test
/test 4.10-gpu-operator-e2e
/test 4.10-images
/test 4.7-gpu-operator-e2e
/test 4.7-images
/test 4.7-test-commit
/test 4.8-gpu-operator-e2e
/test 4.8-images
/test 4.8-test-commit
/test 4.9-gpu-operator-e2e
/test 4.9-images
/test 4.9-test-commit
/test gpu-operator-e2e
/test images
/test nfd-images
/test nfd-operator-e2e-master
/test ods-get-cluster
/test ods-images
/test ods-jh-on-ocp
/test ods-jh-on-osd
/test ods-jh-on-single
/test ods-plot-jh-on-ocp
/test ods-plot-jh-on-osd
/test test-pr
/test test-pr-no-cluster

In response to this
https://github.com/openshift-psap/ci-artifacts/pull/425#issuecomment-1180749693
:
/test jh-on-single
Instructions for interacting with me using PR comments are available here
https://git.k8s.io/community/contributors/guide/pull-requests.md. If
you have questions or suggestions related to my behavior, please file an
issue against the kubernetes/test-infra
https://github.com/kubernetes/test-infra/issues/new?title=Prow issue:
repository.
—
Reply to this email directly, view it on GitHub
https://github.com/openshift-psap/ci-artifacts/pull/425#issuecomment-1180749730,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABZVQIUFPSOQ6EM4A3SCIILVTRUJJANCNFSM53GUJTZA
.
You are receiving this because you were mentioned.Message ID:
@.***>

/test ods-jh-on-single

Test passed at 5/5
but I the artifacts of 3/5 Pods have been correctly exposed :/
Will merge with this collect=no-image-except-failed-and-zero instead of:
    if [[ "$ODS_CI_NB_USERS" -le 5 ]]; then
        collect=all
    else
        collect=no-image-except-failed-and-zero
    fi

/test ods-get-cluster

On Mon, Jul 11, 2022 at 1:31 PM openshift-ci[bot] @.***>
wrote:

@kpouget https://github.com/kpouget: The specified target(s) for /test
were not found.
The following commands are available to trigger required jobs:

/test 4.10-e2e-mlperf-ssd-pr-test
/test 4.10-gpu-operator-e2e
/test 4.10-images
/test 4.7-gpu-operator-e2e
/test 4.7-images
/test 4.7-test-commit
/test 4.8-gpu-operator-e2e
/test 4.8-images
/test 4.8-test-commit
/test 4.9-gpu-operator-e2e
/test 4.9-images
/test 4.9-test-commit
/test gpu-operator-e2e
/test images
/test nfd-images
/test nfd-operator-e2e-master
/test ods-get-cluster
/test ods-images
/test ods-jh-on-ocp
/test ods-jh-on-osd
/test ods-plot-jh-on-ocp
/test ods-plot-jh-on-osd
/test test-pr
/test test-pr-no-cluster

In response to this
https://github.com/openshift-psap/ci-artifacts/pull/425#issuecomment-1180293688
:
/test help
Instructions for interacting with me using PR comments are available here
https://git.k8s.io/community/contributors/guide/pull-requests.md. If
you have questions or suggestions related to my behavior, please file an
issue against the kubernetes/test-infra
https://github.com/kubernetes/test-infra/issues/new?title=Prow issue:
repository.
—
Reply to this email directly, view it on GitHub
https://github.com/openshift-psap/ci-artifacts/pull/425#issuecomment-1180293789,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABZVQIXX27BQKKVFF26GAYDVTQAWJANCNFSM53GUJTZA
.
You are receiving this because you were mentioned.Message ID:
@.***>


Alias for TCSH

This is kind of an issue, kind of a solution...

It looks like proper tcsh support is more involved, and needs changes made to shells.py
I've done a fork, and I'll look at getting a pull request together

Ok, cool =)

Hmm - the one thing I can't get working is re-writing of the tcsh history. Even though loads of places mention ~/.history, this doesn't seem to be the active history file. Other than that, it's all working, though

I'll put in a pull request - you can grab or not as you'd like


Cannot decompressFromUTF16 strings received from Safari

Hi,
I'm using lz-string4java to decompress UTF16 strings, created with the original Javascript library LZString, on a webpage. These strings are then sent via XMLHttpRequests.
On Chrome, Firefox, etc., everything works as expected. On Safari, the UTF16 is correctly received from the XMLHttpRequest, but when I try to decode the content with LZString.decompressFromUTF16, the lz-string4java library fails, and I got a "null" as result.
I think Safari handles UTF16 differently from other browsers, and, in fact, I noticed small differences for some characters, between the javascript UTF16 string, and the actual UTF16 string passed to lz-string4java.
Is this a bug on lz-string4java, or a limitation of Safari UTF16 implementation?

Can u pass the test with your string in rufus.lzstring4javarhinotest.LZStringTest?
If pass, it maybe something wrong with safari.
then you can ask for javascript version lz-string?
@pieroxy

One of the common problem with UTF transmission is that some kind of normalization can take place. Many characters appear twice and are considered equivalent from a "string" perspective. Since LZ-String use those strings as a kind of binary transport, swapping two characters breaks the binary stream and the string cannot be decompressed.
The proper way to get bytes out of the browser is to use compressToEncodedURIComponent as discussed in https://github.com/pieroxy/lz-string/issues/60
It might be slightly less efficient, but it works reliably as it uses only ASCII characters. The corresponding decompressFromEncodedURIComponent is in lz-string4java.

So far there is no any further progress on pieroxy's issue 60 mentioned above.
I think I should close this issue down


Avoid duplicated .NET names in model generation (Fix #50)

A better approch to solving issue #50 is just to create a naming container and add an auto incremented suffix in case of duplicates. This way, we don't have to do the "+" and "-" hacks in the naming construction.
I took the opportunity to separate the Nullability question to a separate method as well because the rules are not that trivial.
This PR is a better alternative to #59 and I'm going to close #59 .

this is a very big change, please add some tests here

Indeed. I’ll add tests later this week.
Le lun. 27 mars 2023 à 11:32, Patrick @.***> a écrit :

this is a very big change, please add some tests here
—
Reply to this email directly, view it on GitHub
https://github.com/patricoos/PortaCapena.OdooJsonRpcClient/pull/62#issuecomment-1484728075,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAMT6TF4CHTJU4EPUJU3AEDW6FGCTANCNFSM6AAAAAAWHOHFZ4
.
You are receiving this because you authored the thread.Message ID:
@.***>


deprecate support for a custom downburst config

We don't think this is being used anymore so we're gonna deprecate this feature and remove the unused code.
See, http://tracker.ceph.com/issues/10625

Tests failed for this pull request.
Refer to this link for build results: http://jenkins.ceph.com/job/teuthology-pull-requests/811/

Tests passed for this pull request.
Refer to this link for build results: http://jenkins.ceph.com/job/teuthology-pull-requests/812/

Tests passed for this pull request.
Refer to this link for build results: http://jenkins.ceph.com/job/teuthology-pull-requests/815/


Luis service retry when throttled

Hi,
It looks like LuisService will hit the LUIS endpoint without checking for throttling or implementing any retry/backoff:
 protected virtual async Task MessageReceived(IDialogContext context, IAwaitable<IMessageActivity> item)
        {
            if (this.handlerByIntent == null)
            {
                this.handlerByIntent = new Dictionary<string, IntentActivityHandler>(GetHandlersByIntent());
            }

            var message = await item;
            var messageText = await GetLuisQueryTextAsync(context, message);
            var tasks = this.services.Select(s => s.QueryAsync(messageText, context.CancellationToken)).ToArray();
            var winner = this.BestResultFrom(await Task.WhenAll(tasks));  // << this line
...

https://github.com/Microsoft/BotBuilder/blob/883990627c89eb034ce1cb4d756f82869b4a2669/CSharp/Library/Dialogs/LuisDialog.cs#L206
Having recently stress tested LUIS (and we do have an Azure subscription with the higher limit) we've received a 429 StatusCode response with a Retry-After header set to "1" (i.e., stop what you're doing for a second, and let me take a breather); is there nothing already in the BotFramework for handling this, or should we implement our own retry logic over the LuisDialog's MessageReceived method?
Ta!

You can achieve this by implementing an ILuisService that implements the retry logic with exponential back off when querying the Luis API: https://github.com/Microsoft/BotBuilder/blob/master/CSharp/Library/Luis/LuisService.cs#L65


Initialization routine from dynamic link library (DLL) not completed

System:
Windows 10 64bit
SerialPort module compiled using VS2013 (no errors)
node -v
v4.2.1
python -V
Python 2.7.10
Upon var serialPort = require("serialport"), the console outputs:
Uncaught Error: Routine di inizializzazione della libreria di collegamento dinamico (DLL) non riuscita.
C:\Users\Domingo\dev\hookninja\node_modules\serialport\build\serialport\v2.0.1\Release\node-v46-win32-x64\serialport.node
Translated into English: Initialization routine from dynamic link library (DLL) not completed
Seems a problem in 64bit systems, any ideas?

I have found that I am able to make this work starting using node, but it will not work if I start this with electron. Are you trying to use electron or similar with this?
I am also on a 64 bit system, but with serialport v2.0.2.

Trying this: http://electron.atom.io/docs/v0.34.0/tutorial/using-native-node-modules/#the-easy-way - to see if that makes a difference... - doesn't work on windows. The other build options - I can't make them work on windows yet.

+1

We're experiencing similar symptoms. require("serialport") working fine on Node but when we try to use Electron we get the same error. Has anybody worked this out? Going to continue diving into gyp and pre-gyp today.


QuTiPv5 Paper Notebook: JAX

This adds the JAX examples from the paper to the tutorials. I combined the mesolve, count stat. and gradient calculation into one notebook as they are closely related.
TODO:

[x] References
[x] Tests
[ ] Maybe some nice plots rather than just numbers? I am open for ideas

Although it is ready for review, we should still wait until an official arXiv link is available to the QuTiP 5 paper as this reference link is blank at the moment.

[ ] Include official url to QuTiP 5 paper

Seems like JAX 0.4.36 breaks something in qutip-jax, so tests will fail for a while


Fix take(predicate) TypeScript error

Q
A

Fixed Issues?
Fixes #1871

Patch: Bug Fix?
👍

Major: Breaking Change?

Minor: New Feature?

Tests Added + Pass?
👍

Any Dependency Changes?

Discussion

[ ] The take(isMyAction) test was updated to use an actions union in hopes to match a use-case more similar to that in the real-world.
[x] The ActionSubPattern type definition was updated/corrected to allow the test to pass.

I must admit, I am pretty new to TypeScript, so any comments, suggestions and insight into the greater impact of these changes will be greatly appreciated.
cc: @Andarist, @vasilii-kovalev, @osoftware, @aikoven

Given the recent discussions in #1871, please let me know if you would like me to update the tests to utilize a union of action types.

@gilbsgilbs could you maybe take a look at this?

Actually, now that TypeScript generator support is improved, and #1892 is merged, I am wondering if we should allow the action itself to be returned from the predicate so that the action returned from take() and passed to the saga in take*(pattern, saga) can be determined without the use type guards.
What do you think @Andarist @gilbsgilbs?

Could you elaborate? Preferably with a simple code that would use the proposed pattern.

I took a quick look at the TypeScript tests in v1.1.1 and I could not reproduce #1871. With respect to my https://github.com/redux-saga/redux-saga/pull/1895#issuecomment-535592284, it looks like take* is already working as suggested.
🥇@gilbsgilbs

@marcandrews doesn't the line your pointed out rely on an implicit any type? This test did already exist before I moved the files around.


argparse, abstract base classes & other improvements

Implements some of the changes proposed at https://github.com/Kartones/mazes-for-programmers-python-src/pull/4 keeping current project linting and coding style settings (python-like namings, double quotes, etc.).
Missing are initially the new pixel_exporter and matplotlib colormaps. They will be probably added at a separate pull request.

/cc @MarcinKonowalczyk
As I mention this are only part of the changes. I've decided to drop the logging code as it is not being used and while step counting and repeated visits could be useful, the book might still talk about it (haven't checked) and for the time being I'd rather not add so complex things when there are still algorithms to add.
I will implement the pixel renderer and check if matplotlib changes are interesting too.


encapsulated algorithms

some warnings about deleting pointers exist

Sorry it took so long for me to review. I noticed that you basically copy and modify the original algorithms, creating this deprecated shadow system on top of the active code. Can you instead merge the files together so there is one single codebase?

I haven't had a chance to look deeper into the new commit, but I did notice that you are including a few binary files. This is because I didn't add a .gitignore file to this repo, so please add the C++ default one (https://github.com/github/gitignore/blob/master/C%2B%2B.gitignore) and remove the binary files you have in the current commit.


[FEATURE]: Messaging / Queue component.

Is your feature request related to a problem? Please describe.
To create some form of message bus, where users can create events, that can be queued, and then can be picked up.
Describe the solution you'd like
So far, the idea I have in mind is to utilise fibres, where we offer in-memory as a default, but additionally can add other transports, then from here, we can then write code to support them, most likely using fibres, how this will work I am not sure, as of course, we will most likely want database access, so there may be some level of resource sharing inside of the fibre so it can call and retrieve in memory data of the main process.

So we have fibres that could be called by tasks, this part then becomes not useful, so closing this as not being done.


[Question] "No images to push" on running action

Hi all, sorry if this isn't the right place to ask or if I'm doing something obviously wrong, but I just created an action to deploy my TypeScript Nodejs app to Heroku and I've hit a wall.
I'm trying to deploy my project on a push event on the master branch. Before calling the Heroku CLI, I build my app into my dist directory.
When I run the action below, I get this error:
Run actions/heroku@master
/usr/bin/docker run --name e959fba43cacc1550c4b8b85486f7a064e9056_e973d1 --label e959fb --workdir /github/workspace --rm -e HEROKU_API_KEY -e INPUT_ARGS -e HOME -e GITHUB_REF -e GITHUB_SHA -e GITHUB_REPOSITORY -e GITHUB_ACTOR -e GITHUB_WORKFLOW -e GITHUB_HEAD_REF -e GITHUB_BASE_REF -e GITHUB_EVENT_NAME -e GITHUB_WORKSPACE -e GITHUB_ACTION -e GITHUB_EVENT_PATH -e RUNNER_OS -e RUNNER_TOOL_CACHE -e RUNNER_TEMP -e RUNNER_WORKSPACE -e ACTIONS_RUNTIME_URL -e ACTIONS_RUNTIME_TOKEN -e GITHUB_ACTIONS=true -v "/var/run/docker.sock":"/var/run/docker.sock" -v "/home/runner/work/_temp/_github_home":"/github/home" -v "/home/runner/work/_temp/_github_workflow":"/github/workflow" -v "/home/runner/work/Hangar/Hangar":"/github/workspace" e959fb:a43cacc1550c4b8b85486f7a064e9056 container:push -a american-hangar web
 ▸    No images to push
##[error]Docker run failed with exit code 1

I have the heroku/heroku image specified in my package.json, but I feel like I'm missing something really obvious. Do I need my own docker image??
Here's my action:
name: Deploy

on:
  push:
    branches:
      - master
      # Deploy on hack branches (keeps env clean and prevents data loss on deploy)
      - hack/*

jobs:
  build:
    runs-on: ubuntu-latest
    strategy:
      matrix:
        node-version: [10.x]
    steps:
    - uses: actions/checkout@v1
    - name: Use Node.js ${{ matrix.node-version }}
      uses: actions/setup-node@v1
      with:
        node-version: ${{ matrix.node-version }}
    - name: npm install and build
      run: |
        npm i
        npm run build

  release:
     runs-on: ubuntu-latest
     steps:
     - uses: actions/checkout@master
     - name: login
       uses: actions/heroku@master
       env:
         HEROKU_API_KEY: ${{ secrets.HEROKU_API_KEY }}
       with:
         args: container:login
     - name: push
       uses: actions/heroku@master
       env:
         HEROKU_API_KEY: ${{ secrets.HEROKU_API_KEY }}
       with:
         args: container:push -a american-hangar web
     - name: release
       uses: actions/heroku@master
       env:
         HEROKU_API_KEY: ${{ secrets.HEROKU_API_KEY }}
       with:
         args: container:release -a american-hangar web

Got the exact same problem with a virtually identical workflow file

@antonioalmeida we ended up bailing from Actions in favor of a “Deploy to Heroku” button for our use case, but if you need CD, I’d recommend using Webhooks. If you really want to use Actions, we got it 90% of the way there with the Actions in that project I linked to above.

And you absolutely need a Dockerfile in your repo. Feel free to copy what we have there.


Toasts don't fire the onClose callback when close button is clicked.

Example : https://solid-libs.github.io/solid-bootstrap/components/toasts
Clicking close on any of the dismiss buttons does not dismiss the toast.
Tracing the close button click event, the call eventually reaches this empty function and no further callbacks seem to get triggered : https://github.com/solid-libs/solid-bootstrap/blob/main/packages/bootstrap/src/ToastContext.tsx#L9
When using autohide, the callback is correctly fired with (e?: MouseEvent | KeyboardEvent) and the event is undefined as expected.

Thanks for reporting this.  It should be resolved in 1.0.20

Wow thank you for the quick response !
This library has been a lifesaver.


Refact warmup waiting

What this does
Teleoperate is allowed when record reset_environment is used, but teleoperate is not allowed when using policy.
Replace warmup with reset_environment
Removed the condition that would cause reset_environment not to be entered during resume
How it was tested
python lerobot/scripts/control_robot.py record   \
    --robot-path lerobot/configs/robot/three_camera_koch.yaml   \
    --fps 30   \
    --repo-id bingcm/tape_grab_three_30hz  \
    --tags experiment  \
    --warmup-time-s 5   \
    --episode-time-s 20   \
    --reset-time-s 4   \
    --num-episodes 200  \
    --push-to-hub 0  \
    --single-task test \
    --local-files-only 1 \

    --resume 1 # if test resume

pytest result
174 passed, 137 skipped, 8 warnings in 193.28s (0:03:13)

Hi @Cadene, Could you please review this PR? Thanks!


Request History View

[ ] List of processed demands, either automatically or manually (via the "requests to process" view)
[ ] Add more responses to a demand that has already been responded to
[ ] Filter by data subject, date
[ ] #135

I'm going to do a redesign of the DCI UI as I think this and #130 can be the same view, with a toggle for "show processed requests". I also need to add something to display alerts

Requires new endpoints for timeline, answered and canceled requests as discussed with @m4rk055 yesterday


Overlapping shells for OnionPartitioning

As of now, the shells use to define the OnionPartitioning are non-overlapping.
Cross-matching 2 data sets with this implementation will unavoidably lead to miss pairs at the borders.
One idea would be to make overlapping shells as
// To be in OnionPartitioning.scala, LinearOnionPartitioning(...)
// Add overlapping shells -- e.g. 1% (to be defined)
val extension : Double = 0.01
for (pos <- 0 to numPartitions - 1) {
  // Inner radius must be greater than 0 (or equal to 0)
  val innerRadius = math.min(0.0, pos * dZ * (1 - extension))
  val outerRadius = (pos + 1) * dZ * (1 + extension)

  val shell = new ShellEnvelope(center, innerRadius, outerRadius)
  grids += shell
}

Then this algo should include the rejection of the duplicates between shells

Not directly this algo (which just defines the grid elements), but I agree we should include in PixelCrossMatch the required method to filter cross-match duplicates.


Corrected few minor typos in Readme.md

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


ctrl+c does not stop ulpload

Operating System: macOS Sierra 10.12.3
Go: go1.8 darwin/amd64
slackcat: slackcat version 1.1, build

If an upload has been started and on uses ctrl+c to stop the upload it doesn't.

file upload aborting on multiple signals has been added to the latest release


Sample Rules File for Group Members

This is the initial work for policy scanner to support group/members.  I am not sure what should be the resource id, so would love feedback on that.

Coverage remained the same at 70.367% when pulling df013af86964e50049f84929ac7b6cb36648878c on scangroups into 9a425bae3af8cca7ad8be938d7f698ef65f42f3a on master.

Adding cla: yes label, as the PR author is a googler at the time of this PR was created.


Added the code for printing the matrix in wave form

Related Issue
#1375
Proposed Changes
Added the code for printing a matrix in wave form.
Checklist

[x] ✅ My code follows the code style of this project.
[x] 📝 My change requires a change to the README.
[x] 👀 I have read the CONTRIBUTING document.

For a given 2D integer array/matrix of size m x n(where m is the number of rows and n is the number of columns), print the matrix in wave order, i.e. print the first column top to bottom, next column bottom to top, and so on.

[x] New feature (non-breaking change which adds functionality)

Output Screenshots

Screenshot #1
Screenshot #2

Test case 1
Test case 2

 |

@Mrjoy832 Please review my PR.

@siddhi-244 Done the changes. Please review.


nesting bug: CSS with inline SVG + pseudo elements or data-attributes selector

System:

OS: macOS 10.15.3
CPU: (8) x64 Intel(R) Core(TM) i7-7820HQ CPU @ 2.90GHz
Memory: 294.83 MB / 16.00 GB
Shell: 5.7.1 - /bin/zsh

Binaries:

Node: 10.11.0 - /usr/local/bin/node
Yarn: 1.10.1 - /usr/local/bin/yarn
npm: 6.9.0 - /usr/local/bin/npm

npmPackages:

styled-components: ^5.0.1 => 5.0.1

You can see that the ::before pseudo-element are rendered on each button, but on the second button not showing up. If you inspect the CSS generated by styled-components, you'll see why. (More details in "Actual Behavior" below.)
https://codesandbox.io/s/styled-components-base-2opl8
Expected Behavior
button::before {
  content:"";
  ...
}

button[data-name="like"]::before {
  background-image: url(here LIKE encoded inline SVG);
}

button[data-name="dislike"]::before {
  background-image: url(here is DISLIKE encoded inline SVG);
}

Actual Behavior
button::before {
  content:"";
  ...
}

button[data-name="like"]::before {
  background-image: url(here LIKE encoded inline SVG);
}

button[data-name="like"]::before[data-name="dislike"]::before{
  background-image:url(here is DISLIKE encoded inline SVG);
}

I used this SVG encoder, so there are no special characters in a string.
https://yoksel.github.io/url-encoder/

It works as expected with non svg urls, but i can't understand what's wrong with encoded one.
What characters can brake parser?

Same nesting bug happens with any attribute selector even without pseudo elements:
&[data-rate="like"] {
    background-image: url(here is LIKE encoded inline SVG);
}

&[data-rate="dislike"] {
    background-image: url(here is DISLIKE encoded inline SVG);
}

You can get around the issue by using extending styles feature for the pseudo-elements into Like and Dislike components.
Here is a working example:
https://codesandbox.io/s/styled-components-base-4moi8?file=/index.js

@OttlikG Yeah, i know, but in that case i don't need data attributes at all.
I don't want to write conditions in reusable button rendering, when i can just pass the data-attribute right to the styles.
Is there any other workaround for it? Is it styled-components issue at all?

This is likely an issue with how stylis perceives your input there. Generally, you can try to base64 encode with url('...') values for instance, but otherwise there isn't much we can do to resolve this. I believe the upgrade to stylis@4 may fix this though once it's dropped into styled-components.
For now, I'll go ahead and close this, since there's not much we can do to fix this on our end. But rest assured, you're not doing anything wrong, it's likely stylis that in v3 can't parse this.