minify turns "a?.b instanceof c" into  "a?.binstanceof c"

Describe the bug
With the minify option a?.b instanceof c becomes a?.binstanceof c.
(Sorry if already reported)
Input code
`a?.b instanceof c`

Config
{
  "jsc": {
    "parser": {
      "syntax": "typescript",
      "decorators": true,
      "tsx": false
    },
    "transform": {
      "decoratorVersion": "2022-03"
    },
    "target": "es2022",
    "loose": false,
    "minify": {
      "compress": false,
      "mangle": false
    }
  },
  "module": {
    "type": "commonjs"
  },
  "minify": true,
  "isModule": true
}

Playground link (or link to the minimal reproduction)
https://play.swc.rs/?version=1.7.42&code=H4sIAAAAAAAAA8tMU9BItNdLUsjMKy5JzEtOzU9TSNZUqOZSUEjOzyvOz0nVy8lP11DPSM3JyVfX5KpVQAUAQu8VekAAAAA%3D&config=H4sIAAAAAAAAA1VQQQ6DMAy78wqU8yYhdtsfdt29KgEV0aZKijSE%2BPta1jK4JbYTW16ruoZRNDzrNY5x8YoF%2BdgjIosL6hMRCItH0Wx8gFthO9TEKhBLVASe8WCCpKNeTYI7tP0YCKyc9MT2bHK8eSOLIZfs2qZt780DrteKBwyJRkmCnAQmIsHilzFrnOmXs40m6xlFrsIkVW6Y8Jq3yq5gqZt3MneUekgJ4jdLbhT4K4tjaQKMvMp1wqrtC7NZO0JzAQAA
SWC Info output
No response
Expected behavior
There needs to be a space before instanceof
a?.b instanceof c
Actual behavior
There is no space before instanceof and it is a syntax error.
Version

= 1.7.42

Additional context
Noticed as from version 1.7.42 terser can no longer minify https://mozilla.github.io/pdf.js/

I think https://github.com/swc-project/swc/pull/9675 is the cause cc @CamWass

Oh. Sorry, #9675  was 1.7.40

Changeset was the cause of 1.7.40 vs 1.7.42 and it seems like I didn't review carefully enough. Sorry for the inconvinience.

I think this is a serious issue so I triggered 1.9.1 publish pipeline.
https://github.com/swc-project/swc/actions/runs/11703603896


Design Test Virtualisation

Ensuring !pip install commands work without contaminating the test environment in the general case requires some thought -- requirements:

When running against system packages e.g. in a github actions runner, you want the notebook's virtualenv to fall back to --system-site-packages
When running locally in a venv, you may prefer to clone the virtualenv from which pytest is running.
When running in a conda environment, you either want to clone the conda environment, or create a virtualenv that falls back to it.
How do we test this behaviour? Some integration test running in a docker container?

Closing as this would be better solved with an autouse fixture

hi @bkanuka, there already exists a fixture for running a pytest test case in a venv (see this repo: https://github.com/man-group/pytest-plugins)
My assumption was you can find a solution where it is an autouse fixture such that adding venv as an nbmake feature is redundant.
If you find this isn't the case it would be helpful to understand where the gap is -- we could then reopen this.


Module 1.3 Assignment

👋 for this assignment, please include a screenshot demonstrating git diff and git diff --staged

Hi! @arelia , it's done 😄 , thanks for the review.


[DNM] Improve tidbMapTable logic

Since some users might want to run the spark job repeatedly, it is not appropriate to use createTempView for tidbMapTable logic

/run-all-tests

/run-all-tests

/run-all-tests

/run-all-tests

/run-all-tests

/run-all-tests

/run-all-tests

/run-all-tests

/run-all-tests


Question: Does this library support locking api's in redis-py library?

I think the api in redis-py library for lock uses multiple commands. Will this be safe on redis cluster?

@noorul If you are refering to the feature with MULTI/EXEC that enables batches of commands to be executed then the answer is, it depends on the use case.
If you are using normal commands then MULTI/EXEC should be supported and safe to use. If you are using pipelines then it is not really supported that good becuase pipelines is hard to work with in a cluster version of redis.
@noorul Please explain more in detail what you are refering to and possible post a usecase that you want to have and i can answer if it is supporte dor not.

@noorul if you're asking about the lock function that returns a <redis.lock.LuaLock at 0x...> then that depends on Lua scripting, SETNX, PEXPIRE, GET, PTTL and DEL working in the cluster... All of those are fine in a cluster environment to the best of my knowledge, so the functionality should be the same as on a single Redis instance

@noorul I would refer to the response from @AngusP on this.
Closing this issue.


Mediapipe installation isssue

Hi, I'm trying to install mediapipe on ubuntu 20.04, through compiling and creating wheel (linux_aarch64.whl).
However I'm getting this error while compiling :
ERROR: /home/muhammad/mediapipe/mediapipe/calculators/image/BUILD:691:11: Compiling mediapipe/calculators/image/affine_transformation_runner_opencv.cc failed: (Exit 1): gcc failed: error executing command /usr/bin/gcc -U_FORTIFY_SOURCE -fstack-protector -Wall -Wunused-but-set-parameter -Wno-free-nonheap-object -fno-omit-frame-pointer -g0 -O2 '-D_FORTIFY_SOURCE=1' -DNDEBUG -ffunction-sections ... (remaining 67 argument(s) skipped)
Use --sandbox_debug to see verbose messages from the sandbox
mediapipe/calculators/image/affine_transformation_runner_opencv.cc: In member function 'virtual absl::lts_20210324::StatusOrmediapipe::ImageFrame mediapipe::{anonymous}::OpenCvRunner::Run(const mediapipe::ImageFrame&, const std::array<float, 16>&, const mediapipe::AffineTransformation::Size&, mediapipe::AffineTransformation::BorderMode)':
mediapipe/calculators/image/affine_transformation_runner_opencv.cc:148:12: error: could not convert 'out_image' from 'mediapipe::ImageFrame' to 'absl::lts_20210324::StatusOrmediapipe::ImageFrame'
return out_image;
^~~~~~~~~
Target //mediapipe/modules/holistic_landmark:holistic_landmark_cpu failed to build
Use --verbose_failures to see the command lines of failed build steps.
After a little bit of research, I found out that, I have to replace 'return out_image;' but don't know the correct phrase to replace it.

I have the same issue building from master on Jetson Xavier NX - Ubuntu 18.04
@monit-org did you resolve it yet?

No. I'm still waiting for the response. Checking every day that I'll get any answer.

Similar to the explanation and the solution described in https://github.com/google/mediapipe/issues/1733#issuecomment-828661652, you probably want to upgrade the gcc version.

@monit-org which version did you try to build? I had this issue on master, but was able to build it when checkout to 0.8.4. Now I face some other error, but the compilation passed

return absl::StatusOrmediapipe::ImageFrame ( mediapipe::ImageFrame(std::move(out_image)));

return absl::StatusOrmediapipe::ImageFrame ( mediapipe::ImageFrame(std::move(out_image)));

return absl::StatusOrmediapipe::ImageFrame ( mediapipe::ImageFrame(std::move(out_image)));

return absl::StatusOrmediapipe::ImageFrame ( mediapipe::ImageFrame(std::move(out_image)));
Its work for me


thick lvm instead of thin

Hello!
Is there a possibility to add support for lvm thick backend storage instead of lvm thin?
We are having some perfomance issues with thin backend on random writes which are normal for databases
I've found similiar question in lunixcontainers maillist, but unfortunately there is no answer.. (https://lists.linuxcontainers.org/pipermail/lxc-users/2016-March/011234.html)

We could add a key on the storage pool level to switch this behavior off. @stgraber?

Yeah, a lvm. key would be fine with me.

Are you planning on implementing this feature in the nearest future?
We are thinking about implementing this and then submitting a pull request.
At the same time we think it might take us a long time to implement it.
On the other hand we see that you added this feature to a "later" milestone that has no deadline.
We need this feature in our production and it would be great if you could give us any time-frame.
Thank you.

@OmAsana, in fact I'm working on this right now. There are some caveats though. Without thin pools LVM has the same problem as zfs namely that you cannot remove the origin logical volume as long as it has dependent snapshots. That's a case I need to handle.

So, another thing to think about is that snapshots of snapshots are not allowed for non-thinpool based logical volumes. This means we cannot create a logical volume for the image, then snapshot the image to create a new container from it and then create another snapshot for the container. In short:
lxc launch images:ubuntu/xenial xen1
lxc snapshot xen1

would not be possible. Afaik, LVM also does not offer the concept of a "clone" similar to zfs.
However, there's an obvious way around this:

Do not import the image into a non-thinpool storage pool, i.e. do not create a storage volume for the image itself in the pool. Instead, on container creation, create an empty logical volume for the container and rsync the contents of the compressed image files into it. Container snapshots will then work out of the box.
For creating containers from snapshots (i.e. lxc copy a/snap0 b) we'd need the same strategy as for creating containers from images. We create an empty logical volume and rsync the contents of the snapshot over into it.
All of this is of course less space-efficient than thinpools so this should be mentioned in the docs. @stgraber, what do you think?

Sounds good to me.

I should have something today or tomorrow. Need to figure out the (non-live) migration story for this one.


Add automerge capability

Blocked by https://github.com/pascalgn/automerge-action/issues/191#issuecomment-1617744694

Maybe the action failes, because the workflow is not present in the default branch. I will merge to try.


Data Table codesandbox example not working

At https://material-ui.com/components/tables/#data-table, if you go to the codesandbox https://codesandbox.io/s/0iyrn, the sandbox throws an error.
it appears the package.json is missing "@material-ui/core": "latest"

[x] The issue is present in the latest release.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯

The sandbox does not load
Expected Behavior 🤔

The sandbox should load
Steps to Reproduce 🕹

Steps:

go to https://codesandbox.io/s/0iyrn

Context 🔦
n/a
Your Environment 🌎

n/a

@brno32 Thanks for reporting the issue. I had forgotten about this case. What do you think about this fix?
diff --git a/docs/src/modules/utils/helpers.js b/docs/src/modules/utils/helpers.js
index 970477d98b..c8b34b72e1 100644
--- a/docs/src/modules/utils/helpers.js
+++ b/docs/src/modules/utils/helpers.js
@@ -97,6 +97,10 @@ function includePeerDependencies(deps, versions) {
     newDeps['@material-ui/core'] = versions['@material-ui/core'];
   }

+  if (newDeps['@material-ui/data-grid']) {
+    newDeps['@material-ui/core'] = versions['@material-ui/core'];
+  }
+
   if (window.muiDocConfig) {
     newDeps = window.muiDocConfig.csbIncludePeerDependencies(newDeps, { versions });
   }

Do you want to work on it? :)

@brno32 Thanks for reporting the issue. I had forgotten about this case. What do you think about this fix?
diff --git a/docs/src/modules/utils/helpers.js b/docs/src/modules/utils/helpers.js
index 970477d98b..c8b34b72e1 100644
--- a/docs/src/modules/utils/helpers.js
+++ b/docs/src/modules/utils/helpers.js
@@ -97,6 +97,10 @@ function includePeerDependencies(deps, versions) {
     newDeps['@material-ui/core'] = versions['@material-ui/core'];
   }

+  if (newDeps['@material-ui/data-grid']) {
+    newDeps['@material-ui/core'] = versions['@material-ui/core'];
+  }
+
   if (window.muiDocConfig) {
     newDeps = window.muiDocConfig.csbIncludePeerDependencies(newDeps, { versions });
   }

Do you want to work on it? :)

Do you want to work on it? :)

Sure! I'll dig around

Do you want to work on it? :)

Sure! I'll dig around


First call to plan_rfft trashes the input

On a fresh new session on official release of Julia v1.7.1 on Windows 10 with FFTW.version giving v"3.3.10"
using FFTW
A = ones(18);
p = plan_rfft(A, flags = FFTW.MEASURE);
A

outputs
18-element Vector{Float64}:
 0.0
 0.0
 0.0
 ⋮
 0.0
 0.0
 0.0

Vector of length 17 and smaller seem to be fine, lengths 18 and longer seem to be trashed.
Matrix inputs are trashed as well, again on a new session
using FFTW
A = ones(18,2)
p = plan_rfft(A, flags = FFTW.MEASURE);
A

outputs
18×2 Matrix{Float64}:
 0.0  1.0
 0.0  1.0
 0.0  1.0
 ⋮
 0.0  1.0
 0.0  1.0
 0.0  1.0

I did not observe trashing when I omitted flag = FFTW.MEASURE.
Second call to plan_rfft in the same session seem to work fine.
plan_fft seemed to be fine.

Yes, this is normal.  FFTW.MEASURE runs several FFTs using the input array to time different algorithms and pick the fastest, which overwrites the input array (and the output array, if any).

Weird why this is seen with plan_rfft, but not with plan_fft.
Could Julia copy the input argument as is done in plan_bfft if PRESERVE_INPUT flag is not available?
https://github.com/JuliaMath/FFTW.jl/blob/v1.4.5/src/fft.jl#L758-L759

Fair enough the behavior is documented

Passing FFTW.MEASURE or FFTW.PATIENT may cause the input array A to be overwritten with zeros during plan creation.


Docs - Publishing - Added PowerShell Examples

Your pull request was against the docs branch, and it was really really out of date. I manually pulled in the changes and pushed them to main (see https://github.com/binwiederhier/ntfy/commits/main). It looks wonderfully. Thank you.
Next time ensure you are up-to-date locally before creating a branch (git pull upstream main).

That's odd as I pulled it just before the edit, but will do! ---- On Fri, 18 Mar 2022 19:06:21 +0000  @.***  wrote ----
Your pull request was against the docs branch, and it was really really out of date. I manually pulled in the changes and pushed them to main (see https://github.com/binwiederhier/ntfy/commits/main). It looks wonderfully. Thank you.
Next time ensure you are up-to-date locally before creating a branch (git pull upstream main).
—Reply to this email directly, view it on GitHub, or unsubscribe.Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you authored the thread.Message ID: @.***>

I don't know I think you pulled from docs which was many months old.

Ahh sorry about that. ---- On Fri, 18 Mar 2022 20:07:45 +0000  @.***  wrote ----
I don't know I think you pulled from docs which was many months old.
—Reply to this email directly, view it on GitHub, or unsubscribe.Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you authored the thread.Message ID: @.***>

No worries. The merge conflicts were easy to solve. You did the hard work.

Anytime, can't see the changes in the docs yet though do you have to restart it to reflect?  ---- On Fri, 18 Mar 2022 20:12:23 +0000  @.***  wrote ----
No worries. The merge conflicts were easy to solve. You did the hard work.
—Reply to this email directly, view it on GitHub, or unsubscribe.Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you authored the thread.Message ID: @.***>

The docs are baked into the app, so I'd have to rebuild and create a release for it to show up. I only do that if I have significant changes. So it'll likely be a couple of weeks before it shows up (unless there's something significant before that).


Make Vmdb::Settings::Walker a independent module

The code in Vmdb::Settings::Walker was simply vanilla hash traversal code that was used to modify the values found in the settings, or any other settings like hash (usually password decryption/encryption).
This code was also used independently of the of the main Vmdb::Settings class, in things like the fix_auth tool, but when loaded prior to the Vmdb::Settings, if autoloading was enabled, the main class would never be loaded because the empty class is technically defined in the
lib/vmdb/settings/walker.rb file.
The changes done here are as follows:

Changes the Vmdb::Settings::Walker to be a nested module only (no class definitions).  While the file path hasn't changed, the module is now Vmdb:SettingsWalker (slightly breaks normal conventions)
Changes the method definitions to be within a ClassMethods module that are then extended by the outer module to allow it to behave the same as it had (a module with top level class methods that could be called without needing Vmdb::Settings).
Update all callers to use the changed namespace instead, and extend where needed
In Vmdb::Settings specifically, removed duplicate method definitions now that extending the the ClassMethods module defined the same methods

Links

Semi related to this effort:  https://www.pivotaltracker.com/story/show/146936263
PR dependent on these changes:  https://github.com/ManageIQ/manageiq/pull/15336

Steps for Testing/QA
The application boot and tests booting should be mostly sufficient in confirming that this functions as expected.  Running the tools/fix_auth.rb will also be a good idea.

@miq-bot assign @Fryguy
@miq-bot add_labels refactoring
@Fryguy I assume that you will have the biggest opinion about this change.  Feel free to assign others or remove yourself as you see fit.


Added Catalan support (TODO: improve interpunct handling)

Added the Catalan alphabet:
"ca": "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyzÀÈÉÍÏÒÓÚÜÇàèéíïòóúüç"
There is, though, one special case that is a bit tricky: the interpunct, "·". In Catalan, "l·l" (sometimes misspelled as "l.l" or "l•l") belongs to the alphabet, but the rest of the letters with "·" don't. For instance, "r·r" does not belong to the alphabet. Provisionally, perhaps we could consider "·" as another character of the alphabet?

Provisionally, perhaps we could consider "·" as another character of the alphabet?

I have no strong opinion about it. Probably, we still should add it because the goal isn't to detect wrong combinations. For example, we say nothing if the text has "bd" or other improbable pair in English text. There are more smart language detection solutions out there, we just make things a bit simpler :)

Provisionally, perhaps we could consider "·" as another character of the alphabet?

I have no strong opinion about it. Probably, we still should add it because the goal isn't to detect wrong combinations. For example, we say nothing if the text has "bd" or other improbable pair in English text. There are more smart language detection solutions out there, we just make things a bit simpler :)

Makes sense. I have added the interpunct in the last commit. Do you need further action from my end to be able to merge it with the main branch? Just for you to know, I'm planning to use this library in https://github.com/TeMU-BSC/corpus-cleaner, and I needed support for Catalan. Thanks for your library.

Released in 2.0.3. Good luck! :)


fix(crux-ui): submit hook

Add useSubmit hook which implements a custom submit ref for formik submits. This should reduce (or even fix) submit flakyness.
Add missing @TeamSlug params to HTTP controllers

Codecov Report
All modified lines are covered by tests :white_check_mark:

Comparison is base (6ba7977) 26.27% compared to head (5ccff27) 26.27%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #816   +/-   ##
========================================
  Coverage    26.27%   26.27%
========================================
  Files           70       70
  Lines         7345     7345
========================================
  Hits          1930     1930
  Misses        5264     5264
  Partials       151      151

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Unknown cihper suite

Hi!
There is an unknown cipher suite with a duplicate Iana value in the CipherSuite class:
https://github.com/tls-attacker/TLS-Attacker/blob/5fe4faf6e06e4422c20b01c3f756c7bc7cf1d0b8/TLS-Core/src/main/java/de/rub/nds/tlsattacker/core/constants/CipherSuite.java#L372
We could not find a definition for TLS_PSK_DHE_WITH_AES_256_CCM_80.
Best regards
Matthias

Ah thanks! Coincidentally I stumbled across the same issue a few weeks ago. I think this is a merge error. Its fixed in >6.0.0


Unable to see Gift option in F&F list.

Tested on dev app v2.0.5(376)

Verified this issue on staging app v2.0.5(377)


Octavia LB CI Job is failing

Is this a BUG REPORT or FEATURE REQUEST?:

Uncomment only one, leave it on its own line:
/kind bug
/kind feature

What happened:
cloud-provider-openstack-acceptance-test-lb-octavia is failing , It would be difficult for openlab team to provide octavia as a service, the job needs to be moved on devstack
What you expected to happen:
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?:
Environment:

openstack-cloud-controller-manager version:
OS (e.g. from /etc/os-release):
Kernel (e.g. uname -a):
Install tools:
Others:

/assign @lingxiankong

/remove-lifecycle stale

still not enabled


Create C3c-fbstate-unity

Test

hi

i want new c3c file for me

Hi I Created New C3c Fb State And Fixed Do You Need It


Refactor schema

Refactor schema to account for new v4 features

redundant https://github.com/oceanprotocol/ocean-subgraph/issues/208


Can't add multiple Tiles Collision Shapes with different physics_layer

Describe the bug
I'm trying to setup a Tile with two different collision rectangles. One is on the physics_layer 0, the other should be on the physics_layer 1 (which has different collisions layer, etc).
When importing my map, only the first rectangle (physics_layer = 0) shows up. An error is raised in the console output :
scene/resources/tile_set.cpp:5431 - Index p_polygon_index = 1 is out of bounds (physics[p_layer_id].polygons.size() = 1).

The map is still imported, but there is no collision rectangle for the physics_layer 1
To Reproduce

Create a map in Tiled, edit the tilemap to add collision shapes to some tile
Create a basic rectangle without any property, this will be the collision rectangle for physics_layer 0
Create another rectangle, this time adding the int property physics_layer and setting it to 1. This rectangle should be imported as a collision rectangle for physics_layer 1
Go to Godot and import that map using YATI, you should get the error

scene/resources/tile_set.cpp:5431 - Index p_polygon_index = 1 is out of bounds (physics[p_layer_id].polygons.size() = 1).

Additionally, you can check that the tile you worked on has no collision shape/polygon on physics_layer 1.

Expected behavior
The collision rectangle/polygon should be imported on physics_layer 1 for that tile.
Screenshots
Screenshots of the Tiled setup :

Screenshot of the resulting import in Godot :

Desktop

OS: Linux - Ubuntu 20.04 (LTS)
Version: 1.6.3 - GDScript
Godot Version: 4.2.1 stable
Tiled Version: 1.10.2

Example map (zipped)
Here's a small example.

The white tile has no collision rectangle
The black tile is setup with only one collision rectangle on physics_layer 0 and is imported properly
The red tile is setup with only one collision rectangle on physics_layer 1 and is imported properly
The blue tile is setup with collisions rectangles on both physics_layer 0 and 1 and only the collision rectangle for physics_layer 0 is imported.

mini.zip

That's exactly what I did :-)
I will release the fix tomorrow together with another change.

Fixed in released version 1.6.5


Rename Chain to ChainHandle

Minor thing, feel free to throw it away if not needed since it came from my reading session with hydra code.

I have nothing against the Handle suffix. If you want it, let's use it on all handles. :)

I have nothing against the Handle suffix. If you want it, let's use it on all handles. :)

I'll add more to this pr then 😁

On second thought I'll close this one without merging. Pretty much everything is a handle in Hydra code so it doesn't make too much sense renaming a bunch of types.


deal with child elements messing up order of p/span

@pauljz
Fixes an issue when dealing with a paragraph/span with multiple child links which contained glossary terms in the link text.
Previously would insert child elements first, then deal with the text, so all links with glossary terms would be inserted at the start (or after the first chunk with no matching words), e.g.

I think this is possibly the same issue as https://github.com/pauljz/autoabbr/issues/4

Yep, this fixes #4 too. Thanks!


Optional Datepicker / Manual entry

The datepicker is great but some uses like to enter date manually.
Is it possible to make the datepicker optional ? For example, by triggering the picker with a click on a small calendar icon next to the field.
User could then choose between entering the date manually or using the picker.

Ok, I found a way to do it with additional JS :
// Activate the picker
$('#exampleInputDatePicker1').pickdate();
// Disable the opening on click and focus
$('#exampleInputDatePicker1').off("focus");
$('#exampleInputDatePicker1').off("click");
// Remove the readonly attr for the field
$('#exampleInputDatePicker1').removeAttr("readonly")

Now, add a calendar icon, or any other element you want to use to trigger the picker, either directly in your code or inserting it with JS. And bind a click event on it :
$("#PickerOpener").on("click", function(e){
    var picker = $('#exampleInputDatePicker1').pickadate( 'picker' )
    picker.open()
    e.stopPropagation()
  })

e.stopPropagation() is important as it prevents the click to close the picker...
Note that since we removed the readonly attribute for the field, it can be completed manually - Up to you to validate the format when manually entered.

I close the issue since it's resolved.
Being able to set the picker as optional could however be a nice feature.


Flesh out AuthorizationTokenType

Currently, our AuthorizationTokenType only contains EMAID and EXTERNAL values.  Add a more complete set of values that cover the various use cases.

Can we just use the AuthEnum class instead? Or is AuthorizationTokenType doing something else


Remove pointless statements

If we have the following code in our JSX components:
if (process.env.COMPILER === 'react') {
  console.log('i am in react');
}
if (process.env.COMPILER === 'vue') {
  console.log('i am in vue');
}

the compiled code in, for example, Vue component, will be:
if ('vue' === 'react') {
  console.log('i am in react');
}
if ('vue === 'vue') {
  console.log('i am in vue');
}

which doesn't make much sense. So we need to walk through such simple literal conditions and remove/modify them to:
in react we should have only:
console.log('i am in react');

and in vue:
console.log('i am in vue');

Fixed in https://github.com/phenomejs/phenome/commit/2268a252c1205d396b9b99e34dad76b2227bd699


Interactive Message Response Size Handling

Overview
You can see the original context here

Botkube has interactive message system where you can select resource interactively and take actions e.g. select one of the pods and see logs. If the response size of pod list is too big, we return it as Slack attachment (which is expected, since Slack has plain text size limit).
You can see an example below.

Acceptance Criteria

Provide configuration for reducing the size of resource list to work with interactive messages.
(Maybe) If resource list size is more then 4K, trim first 4K and show only that part with a message visible to end user.

Reason

For big k8s clusters, there might be lots of resources and we will see attachments while working with interactive messages.

I can help with this issue @huseyinbabal

@huseyinbabal  when we recieve log file the new logs are appended at top or below ?

As we discussed 1-to-1, we can limit resources limit by line as 100, and it can be configurable via kubectl config section.
Pagination is out of context now.


Bower - branch rather than repo?

I love this project -- it definitely makes it easy to do releases. The one downside is having to create a separate repo for bower.
Would it be possible to push the bower files to a separate branch in the same repo (similar to what GitHub Pages does for creating docs for a repo)?

Hi :smiley:
It's a nice idea - at the first look. :+1:
But I've got a question:
how then the versioning should be handled ?
As far as I understand the Bower marks versions by git tags
and as far as I know git tags are set for the whole repo.
$ git checkout one-branch
$ git tag -l
// and same tags we will get
$ git checkout another-branch
$ git tag -l

With a dedicated bower repo - it is simple - each version has their own tag - pointing to specific commit
https://github.com/react-bootstrap/react-bootstrap-bower/tags
and all works fine.
If we save Bower package into e.g. bower-repo branch..
then there will be some kind of conflict between npm and bower tags.
What do you think ?
:cherries:

I'd agree with @AlexKVal on this one. In the main source repo I like to have the mainline branch tagged with the npm version of the release. Unfortunately Bower has not really been well though out and is too tightly coupled to the git repo, along with other concerns that I don't want to mention here so as to avoid any kind of war between npm and bower. Suffice it to say though the tight coupling of Bower to the github repo is why the separate repo is the best option to go with.


In tflite, how to use the same memory to serve different models with exactly the same structure

Hello Everyone,
We have an image classification application where we built different squeezenet models with the exact same model structure.
In the app, we use the model one at a time. In order to save memory and avoid memory fragmentation, we plan to completely reuse the memory, both for storing the static model weights, and for storing the dynamic intermediary tensors. We loaded the 1st model, created the interpreter as usual:
_model = tflite::FlatBufferModel::BuildFromFile(model_filename.c_str());
tflite::InterpreterBuilder(*_model, resolver)(&_interpreter);
_interpreter->AllocateTensors();

One way to achieve the memory reuse is to modify the model weights on-the-fly. However, the problem is that after the model is built, all the tensors holding weights are of type TfLiteAllocationType::kTfLiteMmapRo. I could read the weights correctly. But modifying the data of these tensors always result in a segment fault:
auto tsr = _interpreter->tensor(index);
std::cout << (float)(*tsr->data.data) << std::endl; // this works
*tar->data.data = 0.01f; // this always causes segment fault

Does anyone know if there are workarounds to achieve this ?
Many thanks !

@captainst TensorFlow Lite (TFLite) doesn't have a built-in mechanism to directly share memory between different models loaded in separate interpreters. Model quantization is the recommended approach for this issue, kindly refer to this guide.
Thank you!

@captainst TensorFlow Lite (TFLite) doesn't have a built-in mechanism to directly share memory between different models loaded in separate interpreters. Model quantization is the recommended approach for this issue, kindly refer to this guide. Thank you!

Thank you! I only need to load one model at a time. So I don't need separate interpreters. Since all the models are of the same structure, I want to use one interpreter to serve all the models, one at a time. If I could find a way to manipulate the weights and quant params inside each tensor.
I'll do some further experiments to see. Thank you again.

@captainst Is there any update on this issue?
Thank you!

Hi @sushreebarsa
I made some investigations through the subgraph and arena_planner, and found that tflite does not provide no an such interface for the moment. I managed to use interpreter->SetCustomAllocationForTensor to mount an external allocated memory to each tensor. This is a technical viable approach, but in this case we loose the efficiency of memory usage provided by arena_planner. The amount memory we needed to provide externally is 2x to 4x, which does not make practical sense.
A more intelligent solution could be to make arena_planner use a memory pool provided externally. This could help to greatly alleviate the memory fragmentation problem, when we need to load and off-load different models frequently. This involves some modifications to arena.
For the moment I would think that the issue being closed. Probably we could contribute with PR when it is done from our side.


Cleanups for Lasagna exercise and basics concept from feedback.

Fixes #1745
Fixes #1763

This should include reordering the sections in the docs for this so that variables are explained before functions as suggested by @SaschaMann in #1756.

@SaschaMann @angelikatyborska - this PR should address your feedback about the basics concept/exercise.
If you have time to have a look and let me know what you think then any further feedback that you have would be very welcome!


[core] Add writing different data for keys in lookup file store benchmark

Purpose
Linked issue: close #3861
Tests
no
API and Format
no
Documentation
no

+1


Why a token is needed for /authorize?

Hi,
As far as I know (I'm not an OAuth2 expert, so please let me know if I'm wrong), the steps for AuthorizationCodeFlow should be as:

User sends a request using the front channel to /authorize with data about the client like client_id, scope, redirect_uri, etc.
The authorization server validates the client info and redirects the user to the login page, possibly showing a consent page afterward.
If the user successfully logs in and accepts the consent info, he will be redirected back to the application with a code.
The application makes a back channel request to the authorization server to exchange the code for a token at /token.

But it looks like you require a token even for the first step (request to /authorize):
In the validate_request method of ResponseTypeBase (inside the aioauth/response_type.py), there is this final check which ensures there is a user object in the request:
async def validate_request(self, request: TRequest) -> Client:
    # ...

    if not request.user:
        raise InvalidClientError[TRequest](
            request=request, description="User is not authorized"
        )

    return client

and also in the tests of the demo project you provided, you first generate a token and attach it to the request to the /authroize URL:
@pytest.mark.asyncio
async def test_authorization_code_flow(
    http_client: TestClient, user: "User", client: "Client"
):
    access_token, _ = get_jwt(user)

    response = await http_client.get(
        "/oauth2/authorize",
        query_string={
            "response_type": "code id_token",
            "client_id": client.client_id,
            "redirect_uri": client.redirect_uris[0],
            "scope": "openid email profile",
            "nonce": "73Ncd3",
        },
        headers={"Authorization": f"Bearer {access_token}"},
        allow_redirects=False,
    )

    # ...

How can I work around this issue?
Thank you in advance for your help. Please let me know if there's any additional information needed on my end.

Hello,
As per the principles of the Authorization Code Flow, users need to be authenticated before initiating requests to the /authorize endpoint.
In the example above, indeed, I am explicitly passing the user using their JWT token in the header, indicating to the /authorize endpoint that the user is authenticated.
In your scenario, it appears that users should be automatically redirected to the login page from the /authorize endpoint in case their session is not active.


Showing a message instead of including the receipts

Summary

This PR adds the option instead of showing the receipts, in case they are too large to show a message instead. Avoiding that way a limit error on the size of the release notes file.
Use Cases

Related issue

https://github.com/paketo-community/ubi-base-stack/issues/13 close after emerging this PR

Checklist

[x] I have viewed, signed, and submitted the Contributor License Agreement.
[x] I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
[x] I have added an integration test, if necessary.
[x] I have reviewed the styleguide for guidance on my code quality.
[x] I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@mhdawson finished with adding the limit suggestion, I set it to 16 array length as it is approximately something less than 5000 chararacters.


The devicemotion events are blocked by feature policy

Magento version: <IP_ADDRESS>
Plugin version: 2.14.1
Description
On /checkout/onepage/
With every iframe load of credit card fields, the following warning is printed:
The devicemotion events are blocked by feature policy
Do you need access to the device accelerometer during checkout? 🤔

I have same issue


[Bug] Adapt to multiple versions of FlinkKubeClient

What changes were proposed in this pull request
Issue Number: close #2188
Adapt to multiple versions of FlinkKubeClient.
Brief change log
Adapt to multiple versions of FlinkKubeClient
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts

Dependencies (does it add or upgrade a dependency): no

Hi @wolfboys @monrg , I have updated the PR, please help take a look in your free time, thanks~
It just addressed the multiple flink versions, didn't address other issues in #2229 .

Thanks for your contribution, LGTM, but I don't have the k8s environment,  @monrg @daixiaoyu please help to test it. thanks.


Valid license add-ons

I am working with a tenant that has Microsoft 365 E3 subscription + the Microsoft 365 E5 Insider Risk Management add-on as stated in the "Before You Begin" section, but get license error messages when trying to create or manage Communication Compliance policies in the Compliance center. We are a CSP but cannot find the E5 Compliance add-on listed to add to the tenant instead, can the license requirements please be clarified?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 42670ffb-8024-7cc2-cb1b-27cec02cc223
Version Independent ID: fa22f173-b62e-93cb-62f2-e6ad0b4739d8
Content: Get started with communication compliance - Microsoft 365 Compliance
Content Source: microsoft-365/compliance/communication-compliance-configure.md
Service: o365-seccomp
GitHub Login: @robmazz
Microsoft Alias: robmazz

Is there any update available for this issue please - I have tenants that cannot go ahead with Teams until this is clearly understood. (PS, apologies for the double posting)

@James-MCT  Thank you for your feedback. I have double-checked and the license requirements are correct (Microsoft 365 E3 subscription + the Microsoft 365 E5 Insider Risk Management add-on). I would recommend contacting support for this issue. @mypil  can you provide @James-MCT  with the support contact information?
Thanks
Sri

@James-MCT - You can open a service ticket in your tenant so they can help resolve your technical issue.
Thank you for engaging with the community here for the docs.


New version

Hi
thank you for this useful tool
but this doesn't work on new versions
can you update this perfect tool please?

yes we need this to target .net 4.8 instead of 4.0


myjenkins/Dockerfile: Reset to user "jenkins"

The Dockerfile defaulted to user ${user} which was not defined.
See https://github.com/jenkinsci/docker#installing-more-tools
Signed-off-by: Gianpaolo Macario<EMAIL_ADDRESS>

Tested locally.
LGTM, merging


HALF : half

Hi @NripeshN Good Morning,
I'd love to work on this issue, assign please 🙃

I would appreciate the opportunity to take on this task. Please consider assigning it to me, as I am confident in my ability to handle it effectively.

To assign issues to yourself please read this documentation: https://github.com/CrossGL/crosstl/blob/main/CONTRIBUTING.md#-assigning-or-creating-issues

@CrossGL-issue-bot assign me


foundU Documentation - Modified sso configuration image

The old configuration.png contains a rather sensitive information about our testing server. So I am proposing a new configuration screenshot with a generic information.

@fluxodesign : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Add an export service handler which logs all the SpanData.

Codecov Report

Merging #286 into master will decrease coverage by 0.38%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master     #286      +/-   ##
============================================
- Coverage     94.15%   93.76%   -0.39%
  Complexity      440      440
============================================
  Files            77       77
  Lines          1710     1716       +6
  Branches        102      103       +1
============================================
- Hits           1610     1609       -1
- Misses           73       79       +6
- Partials         27       28       +1

Impacted Files
Coverage Δ
Complexity Δ

...om/google/instrumentation/trace/TraceExporter.java
38.46% <0%> (-32.97%)
3 <0> (ø)

...oogle/instrumentation/trace/TraceExporterImpl.java
90% <0%> (-1.67%)
6% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3830c09...3b2b2bf. Read the comment docs.


PHYSFS_platformGrabMutex causes EXC_BAD_INSTRUCTION in iOS 10 simulator

This bug report was migrated from our old Bugzilla tracker.
These attachments are available in the static archive:

Copied error dump from XCode (physfs-error.txt, text/plain, 2017-04-19 17:27:15 -0400, 1085 bytes)

Reported in version: all
Reported for operating system, platform: MacOS X, Macintosh
Comments on the original bug report:
On 2017-04-19 17:27:15 -0400, Tyler Funk wrote:

Created attachment 3579
Copied error dump from XCode
This issue is occurring when attempting to run LÃVE 2D on the iOS simulator. I posted in their forums, and they were convinced it was a PhysicsFS issue, not a LÃVE issue.
I am using the physfs.framework provided in the love-osx-frameworks-0.10.zip download located here: https://love2d.org/sdk/
If you have questions or need more information, please let me know. The crash does not provide much of a stack trace but I'll do what I can.
LÃVE version: 0.10.1
XCode version: 8.3.2 (8E2002)
iOS Simulator version: 10.0
iOS Simulation: iPhone 6s - iOS 10.3 (14E269)

You can probably close this one - I think LÖVE 0.10 used physfs 2.0, and a lot has changed in both LÖVE and physfs since then. I haven't reproduced this locally recently, at least.


Fix referrer truncation edge cases

Reviewer:

Description:
#530
Steps to test this PR:

Automated tests:

[ ] Unit tests
[ ] Integration tests

Reviewer Checklist:

[ ] Ensure the PR solves the problem
[ ] Review every line of code
[ ] Ensure the PR does no harm by testing the changes thoroughly
[ ] Get help if you're uncomfortable with any of the above!
[ ] Determine if there are any quick wins that improve the implementation

PR Author Checklist:

[ ] Get advice or leverage existing code
[ ] Agree on technical approach with reviewer (if the changes are nuanced)
[ ] Ensure that there is a testing strategy (and documented non-automated tests)
[ ] Ensure there is a documented monitoring strategy (if necessary)
[ ] Consider systems implications

Looks good to me! The logic changes here also need to be reflected in injected-content-scripts/fingerprint-protection.js, so that the JS API returns the same thing as the header.

@Charlie-belmer I think this already the case as that code uses the value created by the function I changed in the PR:
https://github.com/duckduckgo/duckduckgo-privacy-extension/blob/70ed6eab778a958a8c91009a5bdb43cc84242189/shared/js/injected-content-scripts/fingerprint-protection.js#L109-L116

I think you're right - as mentioned in Asana, I was thinking about line 115 here, where it creates a new referrer if there is some issue using Origin. This should already include the port, so we should be OK here.


No notification if trying to save private playbooks on MM Team Edition

Hi,
I just started to play around with playbooks when I noticed a quite confusing thing. When I create a private playbook on a MM Team Edition server and try to save it, nothing is happening. I was lucky because I could see the following in the server logs:
{"timestamp":"2022-03-11 09:50:32.562 +01:00","level":"warn","msg":"public error message: Not authorized; internal details: private playbooks are not available with your current subscription: not covered by current server license","caller":"app/plugin_api.go:931","plugin_id":"playbooks"}
but for all the other users, that might be quite a negative user experience.
Maybe you could show a popup, that private playbooks are not available for MM Team Edition, right when you try to create them or even "disable" them completely, if the right license is not available.

Hello! This was fixed in 1.24.1 up, the UI should look like this:

Can you check which version you're running (found in System Console > Plugins) please? If you're on 1.24.1 or 1.25.0 and still having this issue I'll make sure to bring it up with the team.
Thanks for the report!

Thanks for the quick response! You are right, we are currently on 1.23.0. However, I don't see any way to update it. Is there a way to do it manually or do I have to wait, until its shown in the marketplace? Btw, we are using the current ESR version of MM.

There's a few options for updating, here are some I typically use:

if you use mmctl and have already authenticated with your server, you should be to simply run

mmctl plugin install-url --force https://github.com/mattermost/mattermost-plugin-playbooks/releases/download/v1.25.0/playbooks-1.25.0.tar.gz

via manual upload

If a newer version is available in the marketplace, there should be an upgrade link in the same System Console plugin section.

I might be overlooking some interaction with Team Edition or ESR that means 3 isn't an option in this case, but 1 or 2 should definitely work for you. Let me know if you have trouble though.

@bujinin, right now we're primarily focussing on shipping Playbooks as a pre-packaged plugin, with the intention to upgrade it alongside your regular Mattermost upgrade process. As a result, it isn't listed in the marketplace.
In the future, the product won't be implemented as a plugin, but will be shipped in the core by default.

I'm going to close this issue for now, but please feel free to re-open if you need any more help.


Replicate issue #239 by testing node-webkit on travis

replicated at Line 323: https://travis-ci.org/rvagg/nan/jobs/47320440#L323

neato, +1 from me then

Something is broken here. Modules don't seem to register, as if there's a strange mix of versions somewhere.
https://travis-ci.org/rvagg/nan/jobs/47439294

gyp info using<EMAIL_ADDRESS>gyp info using<EMAIL_ADDRESS>| linux | x64
gyp info chdir test
gyp http GET http://node-webkit.s3.amazonaws.com/v0.11.5/nw-headers-v0.11.5.tar.gz

it's compiling against 0.11.5 headers even though it's on 0.10.32. @springmeyer any hints here? Do you use node-webkit?


How to add a custom coloured two column table?

What would be the easiest way of reproducing such a custom coloured two-column table as shown below?

Definitely willing to figure this out on my own just need a hint in the right direction!
Website: https://dfrieds.com/

Modify the CSS to style the table element and friends differently.
https://mmistakes.github.io/minimal-mistakes/docs/stylesheets/#customizing

Also, that site isn't built with tables. Inspect the HTML and you'll see it's just wrapper divs and some unordered lists. Looks like they're using Bootstrap for the grid and their panel component for styling.


TensorRT-LLM Support

We tried to deploy 6.7B instruct model with TensorRT-LLM and Triton Inference Server. The model seems not giving correct generation but only repeating certain characters all the time.
Any instructions about TensorRT-LLM deployment or plans in the future? Thank you.

Sorry, we haven't yet studied TensorRT-LLM and Triton Inference Server, so we can't provide help now.

Hi @anxietymonger, could you share your build script by any chance? I'm trying the following (I took my codellama build script and changed the rotary_scaling and rotary_base), but the engine is just outputting nonsense.  Which script exactly? And did you have to convert the model weights to any specific format before the build?


Convert this project to rails engine

Hi,
Would be nice if this project is rails engine and anyone could mount the engine in their rails project !
http://guides.rubyonrails.org/engines.html
Regards

Most of the functionality for CSVlint.io is powered by the CSVlint gem - which can be included in rails or ruby projects. What would be the benefit of making a rails engine rather than using a gem (asking as someone curious to learn more)


Can you support 'workbench.action.closeFolder'

I have a test that needs to be able to do this:
await vscode.commands.executeCommand('workbench.action.closeFolder');

But when I do something goes screwy and the test auto-restarts in a new vs instance or something.

This is because the window reloads, resulting in a new extension host -- the extension host where tests are running gets torn down. It's not feasible to support this case.

I figured it would be something like that, well if this one gets fixed then I won't need closeFolder:
https://github.com/microsoft/vscode-test/issues/130


IFFE Pattern and no var app

Reference for IFFE Pattern:
http://angularjs.learnwebtutorials.com/javascript-iffe-angularjs.html
No var app = angular.module, this is not necessary

Thanks @movibe
Good addition. I only updated the formatting a bit.

Thanks @beeman.
I am use Webstorm for fomatter code and you?


Why can't omnisharp/vscode load this sln file?

Issue Description
Trying to use vscode (with WSL remote development extention) with this project https://github.com/Azure/azure-functions-host doesn't work
Steps to Reproduce
git clone https://github.com/Azure/azure-functions-host
cd azure-functions-host
code .

Expected Behavior
To be able to select between WebJobs.Script.Tests.E2E.sln and WebJobs.Script.sln
Actual Behavior
Only WebJobs.Script.Tests.E2E.sln works. Changing to WebJobs.Script.sln throws this error
your 131072x1 screen size is bogus. expect trouble

and nothing happens.
Deleting WebJobs.Script.Tests.E2E.sln and restarting vscode, causes it to not even recognize the project as C#. Copying all the content from WebJobs.Script.sln to WebJobs.Script.Tests.E2E.sln makes it work fine.
Logs
I don't see any logs that seem to relate to the issue other than the screen size error mentioned above
I see this in Log (Window) output
[2020-02-14 15:15:11.947] [renderer1] [error] TreeError [CustomView] Tree element not found: [object Object]: Error: TreeError [CustomView] Tree element not found: [object Object]
    at t.ObjectTreeModel.getElementLocation (file:///C:/Users/ahmel/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:135:14)
    at t.ObjectTreeModel.expandTo (file:///C:/Users/ahmel/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:134:295)
    at reveal (file:///C:/Users/ahmel/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:1071:612)
    at q.reveal (file:///C:/Users/ahmel/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:1088:349)
    at U.reveal (file:///C:/Users/ahmel/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:5049:44)
    at p.reveal (file:///C:/Users/ahmel/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:3583:570)
    at file:///C:/Users/ahmel/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:3582:706
    at processTicksAndRejections (internal/process/task_queues.js:89:5)

OmniSharp log

Starting OmniSharp server at 2/14/2020, 3:24:36 PM
    Target: /home/ahmed/repos/azure-functions-host/WebJobs.Script.Tests.E2E.sln

OmniSharp server started with Mono 6.8.0.
    Path: /home/ahmed/.vscode-server/extensions/ms-vscode.csharp-1.21.11/.omnisharp/1.34.11/omnisharp/OmniSharp.exe
    PID: 8469

[info]: OmniSharp.Stdio.Host
        Starting OmniSharp on ubuntu 18.4 (x64)
[info]: OmniSharp.Services.DotNetCliService
        DotNetPath set to dotnet
[info]: OmniSharp.MSBuild.Discovery.MSBuildLocator
        Located 2 MSBuild instance(s)
            1: Mono 16.3 - "/usr/lib/mono/msbuild/Current/bin"
            2: StandAlone 16.3 - "/home/ahmed/.vscode-server/extensions/ms-vscode.csharp-1.21.11/.omnisharp/1.34.11/omnisharp/.msbuild/Current/Bin"
[info]: OmniSharp.MSBuild.Discovery.MSBuildLocator
        Registered MSBuild instance: Mono 16.3 - "/usr/lib/mono/msbuild/Current/bin"
            CscToolExe = csc.exe
            CscToolPath = /home/ahmed/.vscode-server/extensions/ms-vscode.csharp-1.21.11/.omnisharp/1.34.11/omnisharp/.msbuild/Current/Bin/Roslyn
[info]: OmniSharp.Cake.CakeProjectSystem
        Detecting Cake files in '/home/ahmed/repos/azure-functions-host'.
[info]: OmniSharp.Cake.CakeProjectSystem
        Could not find any Cake files
[info]: OmniSharp.MSBuild.ProjectSystem
        Detecting projects in '/home/ahmed/repos/azure-functions-host/WebJobs.Script.Tests.E2E.sln'.
[info]: OmniSharp.MSBuild.ProjectManager
        Queue project update for '/home/ahmed/repos/azure-functions-host/test/WebJobs.Script.Tests.E2E/WebJobs.Script.Tests.E2E.csproj'
[info]: OmniSharp.WorkspaceInitializer
        Project system 'OmniSharp.Script.ScriptProjectSystem' is disabled in the configuration.
[info]: OmniSharp.WorkspaceInitializer
        Invoking Workspace Options Provider: OmniSharp.Roslyn.CSharp.Services.CSharpFormattingWorkspaceOptionsProvider, Order: 0
[info]: OmniSharp.MSBuild.ProjectManager
        Loading project: /home/ahmed/repos/azure-functions-host/test/WebJobs.Script.Tests.E2E/WebJobs.Script.Tests.E2E.csproj
[info]: OmniSharp.WorkspaceInitializer
        Invoking Workspace Options Provider: OmniSharp.Roslyn.CSharp.Services.RenameWorkspaceOptionsProvider, Order: 100
[info]: OmniSharp.WorkspaceInitializer
        Invoking Workspace Options Provider: OmniSharp.Roslyn.CSharp.Services.ImplementTypeWorkspaceOptionsProvider, Order: 110
[info]: OmniSharp.WorkspaceInitializer
        Invoking Workspace Options Provider: OmniSharp.Roslyn.CSharp.Services.EditorConfigWorkspaceOptionsProvider, Order: 200
[info]: OmniSharp.WorkspaceInitializer
        Configuration finished.
[info]: OmniSharp.Stdio.Host
        Omnisharp server running using Stdio at location '/home/ahmed/repos/azure-functions-host' on host 8232.
[info]: OmniSharp.MSBuild.ProjectManager
        Successfully loaded project file '/home/ahmed/repos/azure-functions-host/test/WebJobs.Script.Tests.E2E/WebJobs.Script.Tests.E2E.csproj'.
[info]: OmniSharp.MSBuild.ProjectManager
        Adding project '/home/ahmed/repos/azure-functions-host/test/WebJobs.Script.Tests.E2E/WebJobs.Script.Tests.E2E.csproj'
[info]: OmniSharp.MSBuild.ProjectManager
        Update project: WebJobs.Script.Tests.E2E

C# log

no output

Environment information
VSCode version: 1.42.1
C# Extension: 1.21.11
Mono Information
        OmniSharp using global mono :6.8.0
Dotnet Information
.NET Core SDK (reflecting any global.json):
 Version:   3.1.101
 Commit:    b377529961
Runtime Environment:
OS Name:     ubuntu
OS Version:  18.04
OS Platform: Linux
RID:         ubuntu.18.04-x64
Base Path:   /usr/share/dotnet/sdk/3.1.101/
Host (useful for support):
Version: 3.1.1
Commit:  a1388f194c
.NET Core SDKs installed:
2.2.402 [/usr/share/dotnet/sdk]
3.0.102 [/usr/share/dotnet/sdk]
3.1.101 [/usr/share/dotnet/sdk]
.NET Core runtimes installed:
Microsoft.AspNetCore.All 2.2.8 [/usr/share/dotnet/shared/Microsoft.AspNetCore.All]
Microsoft.AspNetCore.App 2.2.8 [/usr/share/dotnet/shared/Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 3.0.2 [/usr/share/dotnet/shared/Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 3.1.1 [/usr/share/dotnet/shared/Microsoft.AspNetCore.App]
Microsoft.NETCore.App 2.2.8 [/usr/share/dotnet/shared/Microsoft.NETCore.App]
Microsoft.NETCore.App 3.0.2 [/usr/share/dotnet/shared/Microsoft.NETCore.App]
Microsoft.NETCore.App 3.1.1 [/usr/share/dotnet/shared/Microsoft.NETCore.App]
To install additional .NET Core runtimes or SDKs:
https://aka.ms/dotnet-download

Visual Studio Code Extensions

Extension
Author
Version

azure-account
ms-vscode
0.8.8

better-toml
bungcip
0.3.2

code-spell-checker
streetsidesoftware
1.7.22

csharp
ms-vscode
1.21.11

gitlens
eamodio
10.2.1

Go
ms-vscode
0.13.0

gotestexplorer
premparihar
0.1.11

java
redhat
0.55.1

kotlin
fwcd
0.2.11

prettier-vscode
esbenp
3.20.0

python
ms-python
2020.2.63072

rest-client
humao
0.23.1

rust
rust-lang
0.7.0

support
nuke
0.2.1

vscode-azurefunctions
ms-azuretools
0.20.2

vscode-docker
ms-azuretools
0.10.0

vscode-java-debug
vscjava
0.24.0

vscode-java-dependency
vscjava
0.8.0

vscode-java-pack
vscjava
0.8.1

vscode-java-test
vscjava
0.22.1

vscode-maven
vscjava
0.21.0

vscode-proto3
zxh404
0.4.2

vscode-swift-development-environment
vknabel
2.8.3

vscode-typescript-tslint-plugin
ms-vscode
1.2.3

vscodeintellicode
VisualStudioExptTeam
1.2.5

@ahmelsayed Sorry you are having troubles. I followed your instructions, also added a dotnet restore WebJobs.Scripts.sln before opening VS Code, and didn't have any trouble. Have you tried disabling other extensions to ensure we are the ones throwing an error?

I did dotnet restore, and disabled all extensions but the WSL extension and C#.
I still see the your 131072x1 screen size is bogus. expect trouble  error when trying to switch from WebJobs.Script.Tests.E2E.sln to WebJobs.Script.sln and this error in Log (Window) which I don't know if it's related.
[2020-02-18 14:55:30.179] [renderer1] [error] net::ERR_CONNECTION_RESET: Error: net::ERR_CONNECTION_RESET
[2020-02-18 14:59:43.036] [renderer1] [error] An unknown error occurred. Please consult the log for more details.

Environment information
VSCode version: 1.42.1
C# Extension: 1.21.11
Mono Information
        OmniSharp using global mono :6.8.0
Dotnet Information
.NET Core SDK (reflecting any global.json):
 Version:   3.1.101
 Commit:    b377529961
Runtime Environment:
OS Name:     ubuntu
OS Version:  18.04
OS Platform: Linux
RID:         ubuntu.18.04-x64
Base Path:   /usr/share/dotnet/sdk/3.1.101/
Host (useful for support):
Version: 3.1.2
Commit:  916b5cba26
.NET Core SDKs installed:
2.1.804 [/usr/share/dotnet/sdk]
2.2.402 [/usr/share/dotnet/sdk]
3.0.102 [/usr/share/dotnet/sdk]
3.1.101 [/usr/share/dotnet/sdk]
.NET Core runtimes installed:
Microsoft.AspNetCore.All 2.1.16 [/usr/share/dotnet/shared/Microsoft.AspNetCore.All]
Microsoft.AspNetCore.All 2.2.8 [/usr/share/dotnet/shared/Microsoft.AspNetCore.All]
Microsoft.AspNetCore.App 2.1.16 [/usr/share/dotnet/shared/Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 2.2.8 [/usr/share/dotnet/shared/Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 3.0.2 [/usr/share/dotnet/shared/Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 3.1.1 [/usr/share/dotnet/shared/Microsoft.AspNetCore.App]
Microsoft.NETCore.App 2.1.16 [/usr/share/dotnet/shared/Microsoft.NETCore.App]
Microsoft.NETCore.App 2.2.8 [/usr/share/dotnet/shared/Microsoft.NETCore.App]
Microsoft.NETCore.App 3.0.2 [/usr/share/dotnet/shared/Microsoft.NETCore.App]
Microsoft.NETCore.App 3.1.2 [/usr/share/dotnet/shared/Microsoft.NETCore.App]
To install additional .NET Core runtimes or SDKs:
https://aka.ms/dotnet-download

Visual Studio Code Extensions

Extension
Author
Version

csharp
ms-vscode
1.21.11

@ahmelsayed I found this related issue in the VSCode repo - https://github.com/Microsoft/vscode/issues/35798
The error is not our and from the brief look at the OmniSharp log in your gif, it seems that things are loading properly.

The WSL situation makes it look like this open VS Code issue - https://github.com/microsoft/vscode/issues/75932

Sorry for not getting back to you earlier. The project loads fine when using vscode on Windows, only when accessing it from WSL like in the gif. I'll keep an eye on the issue, though I still don't really understand why it accepts the sln file if it's renamed, but not with its original name.

I think I'm getting the same error in version 1.22.0.
When trying to select a project or solution in a Remote WSL accessing a WSL 2 distro I get:
Command 'OmniSharp: Select Project' resulted in an error (your 131072x1 screen size is bogus. expect trouble )

@victoralvesp Sorry you are running into this, but thank you for reporting. I'll reopen and take a look at what we might have missed.

I found a workaround: if you rename the project/solution so it is the first in OmniSharp: Select Project command list and restart omnisharp, it'll start with the correct selected project/solution

Hi... getting the same issue on 1.22.0 with Remote-WSL as @victoralvesp


Cmsplugin tabs style

This PR provides greater styling capabilities by wrapping entire plugin contents in a div.

 Fix formatting problem in catalog product descriptions on TSS production.

Like it.


Vite HMR bug when text child no wrap tag

Describe the bug
When I modify the text in div  like this：

  this is some text

and vite hmr show me an error in Console:
【Cannot set properties of null (setting 'nodeValue') in the function setText】the vnode's el is null，
When modify the text to wrap by a  tag like this and  hmr work normally：

   this is some text

Reproduction
https://stackblitz.com/edit/vitejs-vite-3aqfqb?file=_gitignore,main.js,App.vue,vite.config.ts&terminal=dev
Steps to reproduce
npm i
npm run dev

change file App.vue some text
hmr show Cannot set properties of null (setting 'nodeValue') in the function setText，
System Info
System:
    OS: Windows 11 10.0.22000
    CPU: (6) x64 Intel(R) Core(TM) i5-8400 CPU @ 2.80GHz
    Memory: 2.60 GB / 15.87 GB
  Binaries:
    Node: 14.21.3 - E:\nvmlink\node.EXE
    Yarn: 1.22.17 - ~\AppData\Roaming\npm\yarn.CMD
    npm: 6.14.15 - E:\nodejs\npm.CMD
    pnpm: 7.9.5 - ~\AppData\Local\pnpm\pnpm.EXE
  Browsers:
    Chrome: 119.0.6045.105
    Edge: Spartan (44.22000.120.0), Chromium (119.0.2151.44), ChromiumDev (Active code page: 65001)
    Internet Explorer: 11.0.22000.120
  npmPackages:
    @vitejs/plugin-vue: ^4.4.0 => 4.4.0
    vite: ^4.5.0 => 4.5.0

Used Package Manager
npm
Logs
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

Seems to be working fine now with latest version of deps.

Closing as cannot reproduce


[Help] Custom certificate error on NPM. December 2023

Hello to all
I need your help please. I really I need it.
After following with some possible solutions I found here and in youtube as well.
I keep remain the same bug... I know this is not new... but here I am with this problem.
Upload failed: Certificate Key is not valid (Command failed: openssl pkey -in /tmp/9223da04-a086-40ba-8e69-981d283108e1/tmp -check -noout 2>&1 )
Also I tried with this: https://serverok.in/nginx-proxy-manager-certificate-key-is-not-valid#google_vignette
but nothing happen.
I have the latest version available at December 13, 2023.
Repository jc21/nginx-proxy-manager
URL: https://hub.docker.com/r/jc21/nginx-proxy-manager
By the way my custom certificate is from Cloudflare.

Any help is very appreciate.
Thanks.
Regards.

I have the same problem.
Any news?

Commenting to keep this alive, until this becomes a configurable item.


Game Crash Fabric 1.20.1

crash-2024-09-14_21.20.08-client.txt

can you please tell me exactly the steps to reproduce this crash

I'm not sure of the exact cause, but it happened while I was inside a bastion in the nether

did it crash in the config screen on just while you were playing?


[#182] Fix: Lint is not working properly in CoroutineTemplate's CI

#182
What happened 👀
Lint is not working properly in CoroutineTemplate's CI
Insight 📝
TODO.
Proof Of Work 📹
TODO.

We will move to this PR.

@Wadeewee please remember to remove the unused branch as well


updated validations.py python script

Closes: #1
Updated validations.py python script.
Fixed the behavior of validate_user function in validations.py.
Fixes #<issue_number_goes_here>

It's a good idea to open an issue first for discussion.

[ ] Tests pass
[ ] Appropriate changes to README are included in PR

complted a qwiklabs coursera assignment


Where's the default priority gas price=3gwei set in cat send?  Could you document all default values and alert people in the cast send --help? blindly calling caused much more spent in gas, 1000x times more than in Metamask

wonder where's the default priority-gas-price set? I was calling cast send blindly without a gas price cap, then found it costs 1000x times gas cost than the regular Metamask transaction gas cost, then I read again from etherscan to compare where was the gas cost spent, found the cast send was using Max Priority: 3 Gwei, while most other regular Metamask transactions were using 0.0009409gwei, then I tried again with
    $ cast send --priority-gas-price=0.0009409gwei ...

which can indeed makes comparable gas cost transactions to Metamask,
Originally posted by @tx0c in https://github.com/foundry-rs/foundry/issues/2134#issuecomment-2041248606
Could you document all default values and alert people in the cast send --help?

It is estimated using the provided RPC URL

no, it's not right @onbjerg ; the estimation RPC call only gives the base gas price, it does not give priority gas price,

https://ethereum.org/en/developers/docs/apis/json-rpc/#eth_gasprice
https://ethereum.org/en/developers/docs/apis/json-rpc/#eth_estimategas

as a workaround, I always call cast send with --priority-gas-price=1wei just put the minimum 1wei in priority instead of 3gwei,
$ cast send --priority-gas-price=1wei --gas-price=0.1gwei

it works saving gas; but I believe the cast tool need a fix


Generate JWT token using dynamic configuration

Here is how I am generating a JWT token in my symfony application:
`public function createAccessToken(string $username, array $payload = []): array
{
$user = JWTUser::createFromPayload($username, $payload);
    $token = $this->jwtManager->createFromPayload($user, $payload);
    $payload = $this->jwtManager->parse($token);

    return [
        'token' => $token,
        'expireAt' => date(DATE_RFC3339_EXTENDED, $payload['exp'])
    ];
}`

I have set the configuration
lexik_jwt_authentication:     secret_key: '%kernel.project_dir%/config/jwt/private.pem'     public_key: '%kernel.project_dir%/config/jwt/public.pem'     pass_phrase: '%env(JWT_PASSPHRASE)%'     token_ttl: '%env(JWT_TTL)%'
and it all worked fine, until I have the need to generate a JWT token with dynamic configurations. Is it possible to achieve this somehow, I could not find anything in the documentation. I want to be able to pass the secret_ket and public_key + pass_phase in runtime ?
Ideas and workarounds are welcome  :)

Hi @destructivecreator,
Why your client side does not just parse the exp claim for your expiration date ? A JWT payload is just a JSON string in a base64url format. Moreover, you can customize the data returned in the payload as described here and use the regular generation process.


Is there ways to emit data from client (socket.io-client) to laravel-echo-server?

Guys, I'm using laravel-echo-server and socket.io-client. I'm having a problem that is to emit from client. I search any possibility but still not found. I found Echo.connector.socket.emit('EVENT_NAME', 'CHANNEL', { /* DATA OBJECT */ }); but when I console.log , there is no emit and how to listen from server? any help pls.

It is dificult (may be impossible) to emit event to server.
The answer is simple you have to use API calls from front-end to laravel backend. Then from laravel backend emit events as you are doing before.

It is dificult (may be impossible) to emit event to server.
The answer is simple you have to use API calls from front-end to laravel backend. Then from laravel backend emit events as you are doing before.

Thanks for reply, I tried everything. Now using api calls


feat: add C implementation for stats/base/dists/cauchy/mode

Resolves #3484.
Description

adds C implementation for @stdlib/stats/base/dists/cauchy/mode along with relevant tests, benchmarks and examples

This pull request:

Progresses: https://github.com/stdlib-js/stdlib/issues/3484

Questions

Any questions for reviewers of this pull request?

No.
Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.
Checklist

Please ensure the following tasks are completed before submitting this pull request.

[x] Read, understood, and followed the contributing guidelines

@stdlib-js/reviewers

@Planeshifter  , done the changes !

@Planeshifter  tests are getting failed should i revert eps package in manifest ?


not working for dolphin browser

dolphin show pop-up like this:
Tampermonkey detected a problem which prevents the add-on from running properly.
Please report this to<EMAIL_ADDRESS>if it persists. Thanks. Close

Huh...
A browser for iOS...
Not sure if @Apostolique made this useable with the Dolphin Browser...
Heck, I've never even heard of this browser before.

You can see in bot.jlynx.net it has an option for Android and its need dolphin browser.


I'm getting $digest max iterations reached by redirecting with $window.location.href

I've also tried with window.location.href and $location.path() with same results. I've scoured stackoverflow for fixes and none have panned out. I've tried wrapping the call within $evalSync and that doesn't work either. The only thing I've found to work is wrapping it within a setTimeout, which is not reliable.
Interesting too is that the bug is only present when the app is initially loading, the redirect works fine afterwards.
Any help would be greatly appreciated.

Can you please provide a demo of the code that reproduces this issue?

I'll do my best to put together a minimized sample over the weekend and post a link here. Thanks for the quick response.

Closing because we don't have a repro scenario :( Feel free to reopen when you can provide one.


Honor the MIT license

electron-sudo is a heavily refactored fork of sudo-prompt and still retains several portions of copyrighted content copied verbatim from there.
electron-sudo used to include the sudo-prompt license, but this has recently been removed, along with all reference to sudo-prompt.
I would appreciate it if you continue to honor the MIT license terms by at least including the sudo-prompt license in your project.

@jorangreef At this moment electron-sudo uses only adopted from sudo-prompt bundled applet. I added a link to author, thanks for the tip.

OS X, uses bundled applet (inspired by Joran Dirk Greef)

@automation-stack I can point you to several other places where you are using sudo-prompt content without including the required MIT license. Your inclusion of any content whatsoever is enough to obligate you to include the entire MIT license file as directed.

@jorangreef Please point to me all other places where electron-sudo uses sudo-prompt content, i will fix this.

@jorangreef Added MIT license for adopted component
https://github.com/automation-stack/electron-sudo/tree/master/src/bin/applet.app

Thanks, I see you've now removed the Concurrency section from the README. There is still https://github.com/automation-stack/electron-sudo/blob/master/src/lib/sudoer.js#L114 but you're welcome to it. All the best with your open source work.

@jorangreef Yes, concurrency approach in electron-sudo was changed to separate prompt on each call on all supported platforms.


NumberFormatException when deserializing a 128-bit integer

Using "com.lihaoyi" %% "ujson" % "0.6.6"
val json = ujson.read("{'foo':<PHONE_NUMBER>4989161181883157038606177750}")

yields:
28291041994989161181883157038606177750
java.lang.NumberFormatException:<PHONE_NUMBER>4989161181883157038606177750
	at ujson.util.Util$.parseLong(Util.scala:57)
	at ujson.util.Util$.parseIntegralNum(Util.scala:23)
	at ujson.Js$.visitNum(Js.scala:181)
	at ujson.Js$.visitNum(Js.scala:77)
	at ujson.Parser.parseNum(Parser.scala:171)
	at ujson.Parser.rparse(Parser.scala:404)
	at ujson.Parser.parse(Parser.scala:330)
	at ujson.Parser.parse(Parser.scala:325)
	at ujson.SyncParser.parse(SyncParser.scala:23)
	at ujson.StringParser$.transform(StringParser.scala:28)
	at ujson.StringParser$.transform(StringParser.scala:27)
	at ujson.Transformable$fromTransformer.transform(Transformable.scala:13)
	at ujson.package$.transform(package.scala:2)
	at ujson.package$.read(package.scala:4)

Looks like this just affects ujson's AST. Workaround: the http://www.lihaoyi.com/upickle/#OtherASTs probably handle it properly. I know play-json represents all numbers as BigDecimal.
https://tools.ietf.org/html/rfc8259#section-6 and https://tools.ietf.org/html/rfc8259#section-9 indicate that parsers may reject large numbers, although all other implementations on JSONTestSuite handle them. This limitation would be surprising.
Out of curiosity, I ran ujson through https://github.com/nst/JSONTestSuite/commit/5b47b778b9a2b87007fe6500b6c919737c46008d. Here are the results (excluding expected passes/rejections):

Would be nice for @lihaoyi to weigh in. If this limitation is intentional, seems to me like it should be documented somewhere.

It seems to me that the ujson AST is not correct. Would it be possible to fix it rather than suggesting to switch to an alternative AST?

This seems like a parser issue, nothing to do with the AST

I might be wrong but it seems to me that the only way to represent JSON numbers in the AST is to use ujson.Num, which only supports Double values. Am I missing something?
It seems that the parser already has a visitFloat64String.

The uJson AST is designed to mimic the Javascript AST, which takes only numbers. If you want something else, use a different AST (or don’t use an AST, like uPickle)

Note that unlike other JSON libraries, ujson.Value isn’t blessed in any way, so if you use a uJson with a different AST you need not worry about ujson.Value tradeoffs at all. In fact, internally uPickle defines its own IndexedValue AST for cases where we need the source indices and non-lossy temporary storage of the incoming JSON, so don’t feel bad about defining your own AST for your own use case

Thanks for the clarification!

This still occurs on latest master
scala> ujson.read("28291041994989161181883157038606177750")
ujson.read("28291041994989161181883157038606177750")java.lang.NumberFormatException:<PHONE_NUMBER>4989161181883157038606177750
  at upickle.core.CharUtils$.parseLong(CharUtils.scala:177)
  at upickle.core.CharUtils$.parseIntegralNum(CharUtils.scala:128)
  at upickle.core.ParseUtils$.parseIntegralNum(ParseUtils.scala:29)
  at ujson.Value$.visitFloat64StringParts(Value.scala:184)
  at ujson.Value$.visitFloat64StringParts(Value.scala:126)
  at upickle.core.Visitor.visitFloat64CharParts(Visitor.scala:62)
  at upickle.core.Visitor.visitFloat64CharParts$(Visitor.scala:61)
  at ujson.Value$.visitFloat64CharParts(Value.scala:126)
  at ujson.CharParser.visitFloat64StringPartsWithWrapper(CharParser.scala:176)
  at ujson.CharParser.parseNumTopLevel(CharParser.scala:216)
  at ujson.CharParser.parseTopLevel0(CharParser.scala:342)
  at ujson.CharParser.parseTopLevel(CharParser.scala:323)
  at ujson.CharParser.parse(CharParser.scala:72)
  at ujson.StringParser$.transform(StringParser.scala:28)
  at ujson.StringParser$.transform(StringParser.scala:27)
  at ujson.Readable$fromTransformer.transform(Readable.scala:16)
  at ujson.package$.transform(package.scala:4)
  at ujson.package$.$anonfun1(package.scala:10)
  at upickle.core.TraceVisitor$.withTrace(TraceVisitor.scala:18)
  at ujson.package$.read(package.scala:10)
  ... 32 elided

The basic problem appears to be that we are using a parseLong fast-path inside ujson.Value.visitFloat64StringParts. This is only valid for numbers of a certain digit-length. We should be checking for numbers larger than that length, and falling back to the toDouble slow path for thoser


[main] Update actions

including version numbers -dprotaso
/cc knative-sandbox/eventing-writers knative-sandbox/serving-writers
/assign knative-sandbox/eventing-writers knative-sandbox/serving-writers
Produced by: knative-sandbox/knobots/actions/update-actions
Details:

/lgtm
/approve


Add support for using sceneform sdk as a dynamic module

Currently, Sceneform sdk does not support and cannot be used as a dynamic module to make use of the https://developer.android.com/guide/playcore/feature-delivery to reduce app size.
This PR resolves https://github.com/SceneView/sceneform-android/issues/441 bug.
I have made changes as described at https://developer.android.com/guide/playcore/feature-delivery#resource-uri for supporting dynamic module.
@ThomasGorisse , @RGregat, @grassydragon, @nvictornvictor, Please have a look at it. This change allows to use the sdk as an Android dynamic modules without impacting the current behavior.
Testing:

Verified that all the sample applications work correctly with these new changes.
Verified that https://github.com/SceneView/sceneform-android/issues/441 issue is resolved after applying the PR changes

Hi!
Thank you for the pull request!
We haven't made new releases for Sceneform in a while since we are now focusing more on Sceneview that is being developed in Kotlin: https://github.com/SceneView/sceneview-android
Are you expecting us to release a new version of Sceneform including your changes?

Thank you for reviewing the request.
It would be of great help if it is possible to release a new version of
Sceneform with these changes. This would allow developers who are on java
version to make use of Android dynamic modules to help them in reduction of
apk size.
Thanks,
Mrunal
On Tue, Jun 6, 2023 at 10:09 PM Nikita Zaytsev @.***>
wrote:

Hi!
Thank you for the pull request!
We haven't made new releases for Sceneform in a while since we are now
focusing more on Sceneview that is being developed in Kotlin:
https://github.com/SceneView/sceneview-android
Are you expecting us to release a new version of Sceneform including your
changes?
—
Reply to this email directly, view it on GitHub
https://github.com/SceneView/sceneform-android/pull/450#issuecomment-1579903473,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAICCN6C3BGPRGUSOVIBSVTXKAEHZANCNFSM6AAAAAAYWDLXZA
.
You are receiving this because you authored the thread.Message ID:
@.***>

--
Cheers,
Mrunal

Hello @ThomasGorisse , @RGregat, @grassydragon, @nvictornvictor,
Would anyone be able to help with merging the change and releasing the sdk?

Hi!
I'll merge it and try try to release this week.

Thanks @grassydragon for helping with the merge. Do you know when the release will be available on maven? I see that the release is being tagged but not yet available on maven.

Hi!
I'll remind Thomas about releasing an update (he is the only one who can do that).

@grassydragon , Would it be possible to connect with Thomas to help release the sdk?

Hi!
Yes, I'll remind him again about that. I'm really sorry about the delay, probably, Thomas was busy and missed my message. You can also join our Discord server so we can communicate with Thomas together.


Service Worker added for offline documentation

In a recent document discussing the "Design System and Frontend documentation" there was a question about where the documentation should sit. One of the options was "All documentation lives in the Design System and the main Frontend README is just a link to the Get started guide in the Design System". The only risk listed with this approach was "Users who clone the repo or download the zip from GitHub won’t have access to offline documentation." This PR has been created to solve this issue for Design System users who require documentation while they are offline.
A service worker has been added with all the heavy lifting done using Workbox. Workbox is built into the metalsmith build pipeline. Workbox handles the file manifest and looks for changes between builds. Once a change is detected, the manifest is updated. Old cache is cleared and replaced with the newest version.
It is now possible to view all the DS docs while offline. There may be considerations around when this PR is merged as a service worker does add another level of caching that can sometimes complicate development. The level of debugging available in the console for 3.1.0 of Workbox has been vastly improved so a developer gets a much clearer picture of what is happening. We could hide all this behind a 'development' / 'production' check or even a simple boolean to disable when required.

You can preview this change here:
Built with commit 409d43d05bf7aa37eec4592eb04891b0c7591536
https://deploy-preview-247--govuk-design-system-preview.netlify.com

Hey Matt, thanks for this awesome contribution.
What network strategy does workbox use?
I imagine we'd want a 'network first, fail to cache' approach? This ensures people always see the most up-to-date content. Stale content could refer to older versions of GOV.UK Frontend which would be problematic.

Good point @nickcolley, I'll add in the runtimeCaching caching option and set to network first. I can't see what the default is for Workbox so best to be explicit.

Looks good based on those tests above, we noticed that there's a runtime cache that caches Analytics.
If possible it would be good to avoid this, as it might make Google Tag Manager unpredictable.

Any feedback on this PR @36degrees? Don't want to merge until you've looked over it.

From testing, Chrome downloads 23.1MB of data on first page load (as tested in incognito mode). Would this also happen if a user visits from a mobile phone on their perhaps-limited data plan? I don't think that's OK.

Yes, very good point. And this raises questions on how SW's actually handle this issue. I haven't seen a setting that only allows downloading on a wi-fi network rather than a data plan. This also raises the question of what experience do we want an offline user to have? Is it better to have no offline experience at all than a slightly broken one (missing images for example)? Personally I was thinking it would be useful to have the full set of documentation to refer to while working remotely (commuting on a train for example), but maybe that isn't the case?
We have the ability to define routes and include / exclude any type of asset, as well as defining different caching strategies where required. It also raises the question of what is taking up the 23.1MB and can this be optimised in anyway.

We don't understand the implications that this will have on analytics - how will offline views be recorded? If users 'come back online' at a later date (e.g. they come online on a Monday after being offline whilst travelling on a Friday) will the statistics for the Friday then change 'retrospectively'? Is this behaviour something that's going to cause headaches for the performance analysts?

At the moment offline tracking isn't enabled. If this is a requirement then there is a module in Workbox that can be enabled. A custom dimension would be setup in GA so we could distinguish between and online / offline user.

Two main problems that are causing the increased cache size is:

Images. CSS and JavaScript files are being duplicated multiple times
Many of the duplicated CSS files contain their own copy of the Base64 encoded font files

The Base64 encoded fonts are 200KB. After investigation changing the font loading strategy reduces the cache size by 72%. Duplicated assets still need to be investigated.

Closing for the moment. Will reopen again once I have an update.

Adding a small comment from x-gov slack. Gavin Wye from MoJ asked:

Is there a way I can get the design system to run locally so I can work when I don’t have an internet connection?

Looks like there is a user-need for this in the future.

There has been significant progress with this branch as the following changes made by the DS team have really helped reduce the overall size of the asset precaching:

Group examples and their assets in directories by @alex-ju
Update to Frontend 0.0.31 by @36degrees
Stop metalsmith-permalinks from duplicating files in build output

The fonts are no longer included via Base64 encoding, and assets that were repeated across the codebase multiple times have been reduced almost completely.
The only assets that are now repeated across the codebase are:

images/govuk-crest-2x.png
assets/images/govuk-crest-2x.png
images/govuk-crest.png
assets/images/govuk-crest.png
images/govuk-logotype-crown.png
assets/images/govuk-logotype-crown.png
components/fieldset/address-wrapper/index.css
patterns/addresses/multiple/address-wrapper.css

The cost of these repeating assets is very small, only 14KB in total.
All these changes have had a huge effect on the amount of data being pre-cached. A reduction of 79%, from 23.1MB to 4.9MB. This is to store the whole of the Design System documentation and assets for offline usage.

The largest single asset that is now being pre-cached is the application.js file which comes in at 320KB. See the image below for more information on the largest assets.

A preview of the Design System using the Service worker and offline mode can be viewed here.

@Nooshu it looks like the assets are not being GZIPed?

I think we'd want to have a simple test plugin that checks the assets in the workbox manifest for sanity and breaks the build if it is very odd.

The only assets that are now repeated across the codebase are:
images/govuk-crest-2x.png
assets/images/govuk-crest-2x.png
images/govuk-crest.png
assets/images/govuk-crest.png
images/govuk-logotype-crown.png
assets/images/govuk-logotype-crown.png
components/fieldset/address-wrapper/index.css
patterns/addresses/multiple/address-wrapper.css

Addressed in #315

Rebased #315 and can confirm the duplicate images have been removed from the service worker manifest. The CSS files still exist:

components/fieldset/address-wrapper/index.css
patterns/addresses/multiple/address-wrapper.css

After discussion with @igloosi and testing in a new incognito window it can be seen that the data that is transferred across the network is 1.4MB in total (201 files):

This is then cached and uncompressed to around 7.6MB in the browser:

These figures have been confirmed on multiple devices.

@nickcolley good point about the URL, I'll add that to the list now.

500KB limit has now been added to workbox-config-cli.js, any file over this size will be ignored by the precache manifest.

I think we'd want to have a simple test plugin that checks the assets in the workbox manifest for sanity and breaks the build if it is very odd.

@nickcolley I'e added a very simple set of checks that output a warning to the console if the total file size or the total number of files increases over a certain threshold. The previous state is written to a file in the filesystem, this seemed like a fairly simple way to store this state, but I'm open to iseas of how to improve this.
It doesn't fail the build at the moment, it just shows a warning (screenshot below).

Removed the need to use the Google CDN to serve Workbox. Following the guide here and using the CLI command: workbox copyLibraries lib/workbox/ the required files are now copied to the deploy directory on build.

Started to investigate the use or routing to allow different caching strategies to be used and a different cache per type of asset. Commit investigation here Only the HTML files are being precached, with all other assets sitting in a separate cache.

Images in govuk-ds-cache-images using a staleWhileRevalidate strategy. Two requests are made one to the network one to the cache. Cache is used if available then replaced in the background if there is an update from the network.
CSS / JS in govuk-ds-cache-css-js using a networkFirst strategy. Asks the network for the request first then falls back to the cache if network unavailable. Useful for assets that update often.
Fonts in govuk-ds-cache-fonts' using a cacheFirst` strategy. Once cached the files won't be updated again, but since the fonts are revisioned a new version once added will have a totally different name.

Added offline detection functionality. When a users connection is dropped a small red tag will be shown in the bottom right corner of the DS. This is to tell the user they are using the cached version of the DS. This tag will be removed when the connection is reestablished.
The design uses the same styles as the "beta" tag only with a different BG colour. I expect the design to be changed and the actual code structure to be changed in the future as required. See screenshot for a preview:

Rebased branch with all the changes from the 1.0.0 release week.
Upgraded WorkBox to 3.3.0 which includes a couple of new features for cache maintenance. I've included the purgeOnQuotaError setting for images and CSS and JS since they will most likely be the largest assets in the cache in the future.
Changed CSS / JS to use a cacheFirst strategy since we are fingerprinting these files so the cache will be updated every time a new version is released. Old cache expires after 7 days.

I've just reviewed the latest setup with all the 1.0.0 changes and HTML only being precached. With GZip compression enabled the total initial download with the SW enabled is 848KB. This setup allows a user to access all pages offline, all functional with the fonts and JS. There may be a few images missing since these aren't being precached.

I've been investigating the possibility of implementing a "kill switch" for the service worker. This is in the unlikely event that something odd happens in the SW and there is a need to kill it in client browsers, as this isn't something we would expect a user to do.
Fortunately this requirement is already part of the service worker specification as of 2016. Essentially the service worker JS file sits outside of the standard browser cache. When a user navigates to a page that sits under the service worker scope or when the service worker is woken up, it will make a request to the server and look for an updated service worker JS file. If it finds an update it will update this in the background without the user even knowing it happened.
There is a great writeup here by Jeff Posnick:

...browsers will always go to the network if the age of the service-worker.js entry in the HTTP cache is greater than 24 hours. So, functionally, there's no difference in using a max-age of 1 day or 1 week or 1 year—they'll all be treated as if the max-age was 1 day.

Browser vendors want to ensure that developers don't accidentally roll out a "broken" or buggy service-worker.js that gets served with a max-age of 1 year, leaving users with what might be a persistent, broken web experience for a long period of time. (You can't rely on your users knowing to clear out their site data or to shift-reload the site.)

It is still recommended that a max-age Cache-Control header is set for the service-worker.js file of some very short time period, 1 minute or even 0, but this can be relaxed if there are no plans to update the service worker very often.


Active fluid coolers being fed with water don't count for Water Coolers as synergies with other coolers

I've built a reactor that relies on synergies for a bit, and decided to test whether the Active fluid coolers counted as Water Coolers (for example, trying to make a Diamond Cooler work).
They do not.
I do not know if this is an intended feature, or just a bug, so I'll report it anyway just to be sure.
I've provided two screenshots, the hotter reactor is the one with Active fluid coolers, and the cooler reactor is the one with Water Coolers in the places of Active fluid coolers.

Hope this can get fixed/marked as intended

This is intended, or at least was never implemented - it should explain on the tooltip ;)


Slightly improve the BaseViewer.{firstPagePromise, onePageRendered, pagesPromise} functionality

Slightly improve the BaseViewer.{firstPagePromise, onePageRendered, pagesPromise} functionality
There's a couple of issues with this functionality:

The respective PromiseCapability instances are not being reset, in BaseViewer._resetView, when the document is closed which is inconsistent with all other state.
While the default viewer depends on these promises, and they thus ought to be considered part of e.g. the PDFViewer API-surface, they're not really defined in a particularily user-visible way (being that they're attached to the BaseViewer instance inline in BaseViewer.setDocument).
There's some internal BaseViewer state, e.g. BaseViewer._pageViewsReady, which is tracked manually and could instead be tracked indirectly via the relevant PromiseCapability, thus reducing the need to track state twice since that's always best to avoid.

Please note: In the existing implementation, these promises are not defined until the BaseViewer.setDocument method has been called.
While it would've been simple to lift that restriction in this patch, I'm purposely choosing not to do so since this ensures that any Promise handlers added inside of BaseViewer.setDocument are always invoked before any external ones (and keeping that behaviour seems generally reasonable).

Initialize the textLayerFactory once in BaseViewer.setDocument, rather than repeating it for every page
For reasons that I don't even pretend to understand, the textLayerFactory property is determined for every single page in the PDF document.
Given that the TextLayerMode should be consistent for all pages in a document, we obviously could/should define textLayerFactory just once instead.

/botio-linux preview

Preventing double state-tracking is always a good thing. Thanks!


fix: make encryption key optional for custom auth wallets

Problem solved
Short description of the bug fixed or feature added

PR-Codex overview
This PR focuses on making the encryptionKey optional for custom authentication in in-app and ecosystem wallets, enhancing flexibility and security in handling sensitive data.
Detailed summary

Updated SingleStepAuthArgsType to make encryptionKey optional for both jwt and auth_endpoint strategies.
Removed hardcoded encryptionKey references in various page.mdx files.
Updated documentation to emphasize not hardcoding the encryptionKey.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

#5341  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @joaquim-verges and the rest of your teammates on  Graphite


Require opt-in to enable optimizations

Checklist

[*] Updated CHANGELOG.md describing pertinent changes.
[*] Updated README.md with pertinent info (may not always apply).
[*] Squash down commits to one or two logical commits which clearly describe the work you've done. If you don't, then Dodd will :).

This requires the user to explicitly enable optimizations through --optimize or by using the optimize option in Trunk.toml for potentially expensive optimizations to run.
This option is sorely needed, because optimizations might be enabled through static configuration in a <link data-wasm-opt="z"> statement in index.html, but you don't necessarily want that to run while working locally. So without another toggle you constantly have to edit your index.html file instead.
This is also a breaking change.
It might also be desirable to implicitly enable optimizations if --release is specified, but in that case I'd like to have a --no-optimize option as well, because I sometimes want to enable release builds while developing locally without optimizing as well. I'd prefer to add this separate to this PR though, because I haven't fully wrapped my head around the config module yet and how to best make multiple options interoperate.

@udoprog optimizations are actually disabled by default (as of now), and even after #146 lands, optimizations can be disabled by setting data-wasm-opt="0" (https://trunkrs.dev/assets/#rust).
Long-term, I would say what we actually want to do is stand on the shoulders of giants and follow this pattern: https://rustwasm.github.io/wasm-pack/book/cargo-toml-configuration.html (profile based controls over optimizations and levels).
I would say that we should close this, as it is not needed.

@udoprog optimizations are actually disabled by default (as of now), and even after #146 lands, optimizations can be disabled by setting data-wasm-opt="0" (https://trunkrs.dev/assets/#rust).

This is the editing being referred to. I've had instances where I've accidentally left data-wasm-opt="0" in the release build.
I'm glad you have a long term idea. But please consider accepting a shorter term fix initially that can be nuked once the long term is in place. This would significantly improve my experience working with trunk.

@udoprog sorry about the very late response on my part. Your points here are definitely valid, and I like the path that you've mentioned about associating wasm-opt with --release profile, however providing a --no-opt option to disable wasm-opt even for --release mode would just be the same as disabling wasm-opt entirely, no?
Anyway, take a look at the discussion over here: https://github.com/thedodd/trunk/issues/197