forge verify-contract does not work on bartio

Component
Forge
Have you ensured that all of these are up to date?

[X] Foundry
[X] Foundryup

What version of Foundry are you on?
forge 0.2.0 (7f41280 2024-11-30T00:24:04.195299000Z)
What command(s) is the bug in?
forge verify-contract
Operating System
macOS (Apple Silicon)
Describe the bug
I'm having issues verifying contracts that I already deployed on the bartio Berachain testnet network.
I've created a sample repo that only has the original foundry init . files and went through the steps below.
You can see the repo here: https://github.com/burrbear-dev/beratrail-verify?tab=readme-ov-file#deploy
forge --version
forge 0.2.0 (7f41280 2024-11-30T00:24:04.195299000Z)

# this WORKS : deploys correctly on BARTIO and verifies the contract
forge script script/Counter.s.sol:CounterScript \
  --account X_DEPLOYER2 \
  --rpc-url ${BARTIO_RPC_URL} \
  --broadcast \
  -vvvvv \
  --verify --verifier custom \
  --verifier-url 'https://api.routescan.io/v2/network/testnet/evm/80084/etherscan' \
  --verifier-api-key "verifyContract" \
  --chain 80084

# this deploys the contract but the verification steps fails:
forge create script/Counter.s.sol:CounterScript --broadcast \
  --rpc-url ${BARTIO_RPC_URL} --account X_DEPLOYER2 --verify --verifier custom \
  --verifier-url 'https://api.routescan.io/v2/network/testnet/evm/80084/etherscan' --verifier-api-key "verifyContract" \
  --chain 80084

[⠊] Compiling...
No files changed, compilation skipped
Enter keystore password:
Deployer: 0x235A2ac113014F9dcb8aBA6577F20290832dDEFd
Deployed to: 0xA4f4C07A01F7995587044c9F1f97440DF3dBbFBe
Transaction hash: 0xfe1f2d0bdd5da8a5e5a1e79ac9e2f252b3d5d597cda34f00f2fe7b42a1370ca4
Starting contract verification...
Waiting for custom to detect contract deployment...
Start verifying contract `0xA4f4C07A01F7995587044c9F1f97440DF3dBbFBe` deployed on 80084
Compiler version: 0.8.13

Submitting verification for [script/Counter.s.sol:CounterScript] 0xA4f4C07A01F7995587044c9F1f97440DF3dBbFBe.
Submitted contract for verification:
        Response: `OK`
        GUID: `adf0d2da-0853-569c-9727-8d1efb714e1f`
        URL: https://api.routescan.io/v2/network/testnet/evm/80084/address/0xa4f4c07a01f7995587044c9f1f97440df3dbbfbe
Contract verification status:
Response: `NOTOK`
Details: `Error: contract does not exist 80084 0xA4f4C07A01F7995587044c9F1f97440DF3dBbFBe`

# Trying to verify the contract deployed above (but where verification failed) does not work (?!)
❯ forge verify-contract 0xA4f4C07A01F7995587044c9F1f97440DF3dBbFBe src/Counter.sol:Counter --watch \
  --verifier custom --verifier-url 'https://api.routescan.io/v2/network/testnet/evm/80084/etherscan/api/' \
  --verifier-api-key "verifyContract" \
  --chain 80084 -vvvvv --rpc-url $BARTIO_RPC_URL
Start verifying contract `0xA4f4C07A01F7995587044c9F1f97440DF3dBbFBe` deployed on 80084

Submitting verification for [src/Counter.sol:Counter] 0xA4f4C07A01F7995587044c9F1f97440DF3dBbFBe.
Submitted contract for verification:
        Response: `OK`
        GUID: `5fe8e033-fe0e-591e-a796-bff70a63a613`
        URL: https://api.routescan.io/v2/network/testnet/evm/80084/etherscan/address/0xa4f4c07a01f7995587044c9f1f97440df3dbbfbe
Contract verification status:
Response: `NOTOK`
Details: `Error: Compilation successful, but bytecode does not match with deployed bytecode for address 0xA4f4C07A01F7995587044c9F1f97440DF3dBbFBe, please check your parameters`

# another try, this time with more specific params for compiler and evm version
# in case forge verify-contract has a but and does not pick them up from the foundry.toml
# also no go :(
❯ forge verify-contract 0xA4f4C07A01F7995587044c9F1f97440DF3dBbFBe src/Counter.sol:Counter --watch \
  --verifier custom --verifier-url 'https://api.routescan.io/v2/network/testnet/evm/80084/etherscan/api/' \
  --verifier-api-key "verifyContract" \
  --num-of-optimizations 200 --evm-version "cancun" --compiler-version "0.8.13" \
  --chain 80084 -vvvvv --rpc-url $BARTIO_RPC_URL

Start verifying contract `0xA4f4C07A01F7995587044c9F1f97440DF3dBbFBe` deployed on 80084
Compiler version: 0.8.13
Optimizations:    200

Submitting verification for [src/Counter.sol:Counter] 0xA4f4C07A01F7995587044c9F1f97440DF3dBbFBe.
Submitted contract for verification:
        Response: `OK`
        GUID: `14c8391f-684f-5bec-8088-66db9ce58e6a`
        URL: https://api.routescan.io/v2/network/testnet/evm/80084/etherscan/address/0xa4f4c07a01f7995587044c9f1f97440df3dbbfbe
Contract verification status:
Response: `NOTOK`
Details: `Pending in queue`
Warning: Verification is still pending... (7 tries remaining)
Contract verification status:
Response: `NOTOK`
Details: `Pending in queue`
Warning: Verification is still pending... (6 tries remaining)
Contract verification status:
Response: `NOTOK`
Details: `Error: Compilation successful, but bytecode does not match with deployed bytecode for address 0xA4f4C07A01F7995587044c9F1f97440DF3dBbFBe, please check your parameters`

Thank for your report! Something wrong with the verifier URL in forge create, it shows
URL: https://api.routescan.io/v2/network/testnet/evm/80084/address/0xa4f4c07a01f7995587044c9f1f97440df3dbbfbe hence contract not found, whereas right URL should be https://api.routescan.io/v2/network/testnet/evm/80084/etherscan/address/0xa4f4c07a01f7995587044c9f1f97440df3dbbfbe (etherscan missing), hence the failure
also this one
https://github.com/foundry-rs/foundry/blob/7f41280ee071193557f73f16bae9aee9a5548ee8/crates/verify/src/etherscan/mod.rs#L128-L133
should probably be
args.verifier.verifier_url.clone().unwrap_or(etherscan.address_url(args.address))

in order to show real verification URL

also this one
https://github.com/foundry-rs/foundry/blob/7f41280ee071193557f73f16bae9aee9a5548ee8/crates/verify/src/etherscan/mod.rs#L128-L133
should probably be
args.verifier.verifier_url.clone().unwrap_or_else(|| etherscan.address_url(args.address))

in order to show real verification URL

This is not true, the client is already instantiated correctly https://github.com/foundry-rs/foundry/blob/0045384f1087897b2665506e95808f022776a5a7/crates/verify/src/etherscan/mod.rs#L264-L266

@burrbear-dev verifiy fails because you used forge create to deploy script/Counter.s.sol:CounterScript contract but you verify a different one src/Counter.sol:Counter - hence the bytecode does not match with deployed bytecode error. You need to either forge create src/Counter.sol:Counter and verify as forge verify-contract 0x... src/Counter.sol:Counter or if you deploy the script with forge create script/Counter.s.sol:CounterScript then verify it as forge verify-contract 0x... script/Counter.s.sol:CounterScript (just checked and all works OK).


Consider adding a .RUNFILEDIR attribute

With the use of run when not in a directory next to the Runfile, it would be nice to have a convenient way to make paths relative to the primary Runfile.
It's possible to do this already, but it's awkward in that it requires shell code, and it needs to be duplicated into each step that requires it, e.g:
deploy-reviewer:
    RUNFILEDIR=$(dirname "${RUNFILE}")
    cd "${RUNFILEDIR}/foo"
    # ... actually do useful things

If, instead, we could do this, IMHO it becomes quite a bit nicer with many different commands:
EXPORT RUNFILEDIR := ${.RUNFILEDIR}

deploy-reviewer:
    cd "${RUNFILEDIR}/foo"
    # ... actually do useful things

On the subject of attributes, with includes being a thing now, it might also be convenient to have attributes for the paths relevant for the imported Runfile, to be able to more easily make reusable things. The included Runfile may be in many directories all over the place, and want to make use of some resources right next to it: the included Runfile is in a better position to be able to define where that is, than the primary Runfile is, in my opinion.
This can be split off to a separate issue, if preferred.

Howdy!  Let's start with a bit of devil's advocate:
The simplest (current) way to get the RUNFILE dir is likely:
Runfile
export RUNFILE=${.RUNFILE}

main:
   echo ${RUNFILE%/*}

A re-usable RUNFILEDIR can be achieved in two lines:
Runfile
export RUNFILE=${.RUNFILE}
export RUNFILEDIR=$(dirname ${RUNFILE})

main:
    echo $RUNFILEDIR

That said, I've actually also been grinding on .RUNFILEDIR attribute since the discussion of Sub-Module Support in #50
Honestly I use this value in the code constantly so its already handy, so its ease vs value ratio makes it a no-brainer ...
But wait, there's more ...

it might also be convenient to have attributes for the paths relevant for the imported Runfile

Indeed I can see much value in included runfiles having easy access to their containing folder path.
But now we fall into one of (the two) hardest things: Naming Things
It feels like we want to be able to capture the following:

The primary runfile's Full Path
The primary runfile's Containing Folder Path
The current (included or primary) runfile's Full Path
The current (included or primary) Containing Folder Path

It also feels like we want to enable consistent usage of the variables, regardless if a runfile is primary or an included, ie.
We likely don't want the primary to have to use .RUNFILE, but includes having to use .INCLUDEDRUNFILE (or sumesuch) for the same concept.
Q: Could a runfile be a Primary runfile in one context, but an Included runfile in a different context?
If YES: Then the variables we create (and name) should represent the the same concept in both contexts.
If NO: Then an Include file knows its an include file, so we can have include-specific variables that are only valid in that context.
Q: Synonyms for Primary ?
"Primary" is a big word, could we get by with a smaller word like:

main
root
???

Using "main" for discussion: We could introduce the following:

Attribute
Description

.RUNFILE
Current runfile full path  (changes current behavior)

.RUNFILE.DIR
Current runfile directory

.RUNFILE.MAIN
Primary runfile full path. Matches .RUNFILE within primary file iteself

.RUNFILE.MAIN.DIR
Primary runfile directory. Matches .RUNFILE.DIR within primary file iteself

Alternatively, we could invert them:

Attribute
Description

.RUNFILE
Primary runfile full path  (current behavior)

.RUNFILE.DIR
Primary runfile directory

.RUNFILE.CURRENT
Current runfile full path. Matches .RUNFILE within primary file iteself

.RUNFILE.CURRENT.DIR
Current runfile directory. Matches .RUNFILE.DIR within primary file iteself

Additionally, CURRENT could be replaced with something like SELF

Attribute
Description

.RUNFILE
Primary runfile full path  (current behavior)

.RUNFILE.DIR
Primary runfile directory

.RUNFILE.SELF
Current runfile full path. Matches .RUNFILE within primary file iteself

.RUNFILE.SELF.DIR
Current runfile directory. Matches .RUNFILE.DIR within primary file iteself

( although "self" feels more like programming and less like scripting )
Ok so if we used the first method, what would you use as the names for "PRIMARY" ?
And if we used the second method, what would you use as the names for "CURRENT"?
Thanks for starting the discussion !
-TW

@rburchell  me fears github emails are still routing to your /dev/null ?

I think root is more meaningful than primary or main. Regarding current or self, it could also be this or here. Anyway, I prefer hierarchy to be .SELF.RUNFILE... as later on more attributes to .SELF could be added. Another option is to never have a prefix for the current one, i.e. .RUNEFILE to always be the current one and instead add .ROOT.RUNFILE... as it will be the least frequently used option... maybe.

@TekWizely No, I got the notification, but simply didn't have enough time to respond at the moment, a lot going on in life. Good that it got solved, though.

@TekWizely No, I got the notification, but simply didn't have enough time to respond at the moment, a lot going on in life. Good that it got solved, though.

LOL Thanks for the note, I was contemplating sending an email get proof of life :)
I hope you like the design decisions we made to for new attributes !


Refactor add_reviewer function

Breakdown add_reviewer method into multiple simpler methods

Refactored the method to do the following:

Each method now performs a single task, making the code more modular and easier to understand.
Methods are named descriptively to indicate their purpose.
Code duplication is reduced by extracting common functionalities into separate methods.
The main add_reviewer method now orchestrates the process by calling smaller methods for each task.

The changes for this issue can be checked at - https://github.com/NidhayPancholi/expertiza/commit/b325810d67da2a03d3ccb15458926d0049fdb9eb
Reviewed and closing issue.


fix: update examples to<EMAIL_ADDRESS>

coverage: 99.245%. remained the same
when pulling 46d91bcdf4556823515e661022a5eeae47049a7e on rc-update-examples-20240711
into 10766f29fd6437551ff096f6df69d95ee7e654c5 on master.


Provide a fix-it that inserts omitted generic parameters when they can't be inferred.

Explanation: If someone tries to use a generic type without providing generic arguments, they'll get an error about how the generic parameters couldn't be inferred. In these cases, the most helpful thing to do is insert reasonable default types or placeholders. Provide a note with a fix-it, and auto-apply that fix-it during migration.

Scope: Affects failure diagnosis for generic types without generic arguments, in both type and expression position.

Issue: rdar://problem/27087345

Reviewed by: @nkcsgexi

Risk: Medium-low. Only fires during error diagnosis, but it is looking up a fair amount of information to do its work, which could mean exposing latent bugs. Most likely, though, the worst that will happen is it generates a bogus fix-it at some point.

Testing: Added compiler regression tests, verified that the originally reported case now gets useful fix-its.

@swift-ci Please test


Re 153

By submitting pull requests to this repo, I agree to the Contributor License Agreement which can be found at: https://github.com/cpanel/elevate/blob/main/docs/cPanel-CLA.pdf

The only difference between this and my RE-153 is that the elevate-cpanel file has been generated.  The rest of this is just from where this branch is behind main.


When installing a newer version of a package, elm-package.json is not updated.

$ elm package install elm-community/elm-lazy-list
Some new packages are needed. Here is the upgrade plan.

  Upgrade:
    elm-community/elm-lazy-list (1.0.1 => 1.1.0)
    elm-lang/core (4.0.1 => 4.0.2)

Do you approve of this plan? [Y/n] y
Starting downloads...

  ● elm-community/elm-lazy-list 1.1.0
  ● elm-lang/core 4.0.2

Packages configured successfully!

$ git diff elm-package.json
$

The updated versions of core and lazy-list are downloaded but the updated restrictions are not added to elm-package.json. This is a potential bug surface; I was updating lazy list because 1.1.0 adds a function that I depend on. If someone pulls down my changes and already has the old version installed, they're in for a rude surprise!
Elm-package 0.17.1.

How to solve this:
"There are no versions of elm-community/elm-lazy-list that work with Elm
0.18.0. Maybe the maintainer has not updated it yet."

@esousa77: Easy, switch from elm-community/elm-lazy-list (which is deprecated) to elm-community/lazy-list (which is the new name of that package).


Class cast exception Firebird dbs when they contain a table with a BOOLEAN domain (which is not a reserved word)

This issue is the same as a closed issue - 8793.
I commented on that issue, but not sure if it will see the light of day, so am creating a new issue here. On the original issue the problem could not be reproduced, and the issue was waiting for a response which didn't happen so it got closed.
The exception is org.jkiss.dbeaver.model.impl.jdbc.struct.JDBCDataType cannot be cast to org.jkiss.dbeaver.ext.firebird.model.FireBirdDataType
Running Firebird server 2.5
DB Beaver 7.2
Original issue version <IP_ADDRESS>005171753 (May 18, 2020)
The server version does not have the native concept of a Boolean type. I have (as many users do) created a BOOLEAN domain which is a Char(1) type.
It seems all the tables I open that has a column with a DOMAIN of BOOLEAN specified gets this error. Other tables open fine.
This used to work, but can't recall in which version :-)...
e.g.
CREATE DOMAIN BOOLEAN AS
CHAR(1) CHARACTER SET NONE
DEFAULT 'F'
NOT NULL
CHECK (Value in ('T',  'F'))
COLLATE NONE

then
CREATE TABLE TEST_TABLE (
    ID             INTEGER NOT NULL,
    TEST_BOOLEAN   BOOLEAN NOT NULL /* BOOLEAN = CHAR(1) DEFAULT 'F' NOT NULL CHECK (Value in ('T',  'F')) */,
    TEST_OTHER     VARCHAR(64) NOT NULL
);

Opening this table with or without data causes
org.jkiss.dbeaver.model.impl.jdbc.struct.JDBCDataType cannot be cast to org.jkiss.dbeaver.ext.firebird.model.FireBirdDataType
Other domains are fine so seems to be with a DOMAIN named BOOLEAN (which is not a reserved word in Firebird 2.5 at least) causes issues.

@cfnz as quick workaround - i think, it might work if you name the boolean other - d_boolean, for example

@cfnz can you sent logs of error?

can't reproduce on Firebird 2.1 and Firebird 2.5

Strange. I again created the table and got the error. However, I was creating the table in an existing database.
Creating a new database, adding the domain and table, and it works, so it is not as clean a test case as I thought.
It is still the case however where opening other tables without that domain seems to work, but with that domain and it fails (but it works in a clean DB, sigh...). The issue is in multiple existing DBs (though they have similar content), so it is not just the one DB. I will see if I can narrow down something in those DBs over and above using the BOOLEAN domain.
Here is the .log file content:
!SESSION 2020-09-16 09:37:48.266 -----------------------------------------------
eclipse.buildId=unknown
java.version=1.8.0_212
java.vendor=Azul Systems, Inc.
BootLoader constants: OS=linux, ARCH=x86_64, WS=gtk, NL=en_NZ
Command-line arguments:  -os linux -ws gtk -arch x86_64

!ENTRY org.jkiss.dbeaver.model 2 0 2020-09-16 09:38:02.805
!MESSAGE Can't fetch database data types
!SUBENTRY 1 org.jkiss.dbeaver.model 2 0 2020-09-16 09:38:02.805
!MESSAGE SQL Error [335544914] [22001]: arithmetic exception, numeric overflow, or string truncation; string right truncation [SQLState:22001, ISC error code:335544914]
!SUBENTRY 2 org.jkiss.dbeaver.model 2 0 2020-09-16 09:38:02.805
!MESSAGE arithmetic exception, numeric overflow, or string truncation; string right truncation [SQLState:22001, ISC error code:335544914]
!STACK 0
java.sql.SQLException: arithmetic exception, numeric overflow, or string truncation; string right truncation [SQLState:22001, ISC error code:335544914]
	at org.firebirdsql.gds.ng.FbExceptionBuilder$Type$1.createSQLException(FbExceptionBuilder.java:539)
	at org.firebirdsql.gds.ng.FbExceptionBuilder.toFlatSQLException(FbExceptionBuilder.java:304)
	at org.firebirdsql.gds.ng.wire.AbstractWireOperations.readStatusVector(AbstractWireOperations.java:140)
	at org.firebirdsql.gds.ng.wire.AbstractWireOperations.processOperation(AbstractWireOperations.java:204)
	at org.firebirdsql.gds.ng.wire.AbstractWireOperations.readSingleResponse(AbstractWireOperations.java:171)
	at org.firebirdsql.gds.ng.wire.AbstractWireOperations.readResponse(AbstractWireOperations.java:155)
	at org.firebirdsql.gds.ng.wire.AbstractFbWireDatabase.readResponse(AbstractFbWireDatabase.java:211)
	at org.firebirdsql.gds.ng.wire.version10.V10Statement.processFetchResponse(V10Statement.java:488)
	at org.firebirdsql.gds.ng.wire.version10.V10Statement.fetchRows(V10Statement.java:467)
	at org.firebirdsql.jdbc.FBStatementFetcher.fetch(FBStatementFetcher.java:196)
	at org.firebirdsql.jdbc.FBStatementFetcher.next(FBStatementFetcher.java:127)
	at org.firebirdsql.jdbc.AbstractResultSet.next(AbstractResultSet.java:363)
	at org.jkiss.dbeaver.model.impl.jdbc.exec.JDBCResultSetImpl.next(JDBCResultSetImpl.java:272)
	at org.jkiss.dbeaver.ext.firebird.model.FireBirdDataTypeCache.loadObjects(FireBirdDataTypeCache.java:71)
	at org.jkiss.dbeaver.ext.firebird.model.FireBirdDataTypeCache.loadObjects(FireBirdDataTypeCache.java:1)
	at org.jkiss.dbeaver.model.impl.jdbc.cache.JDBCObjectCache.getAllObjects(JDBCObjectCache.java:73)
	at org.jkiss.dbeaver.ext.generic.model.GenericDataSource.initialize(GenericDataSource.java:440)
	at org.jkiss.dbeaver.ext.firebird.model.FireBirdDataSource.initialize(FireBirdDataSource.java:125)
	at org.jkiss.dbeaver.registry.DataSourceDescriptor.connect(DataSourceDescriptor.java:844)
	at org.jkiss.dbeaver.runtime.jobs.ConnectJob.run(ConnectJob.java:70)
	at org.jkiss.dbeaver.runtime.jobs.ConnectJob.runSync(ConnectJob.java:98)
	at org.jkiss.dbeaver.ui.actions.datasource.DataSourceHandler.connectToDataSource(DataSourceHandler.java:106)
	at org.jkiss.dbeaver.ui.actions.datasource.UIServiceConnectionsImpl.initConnection(UIServiceConnectionsImpl.java:64)
	at org.jkiss.dbeaver.model.navigator.DBNDataSource.initializeNode(DBNDataSource.java:157)
	at org.jkiss.dbeaver.model.navigator.DBNDatabaseNode.getChildren(DBNDatabaseNode.java:199)
	at org.jkiss.dbeaver.model.navigator.DBNDatabaseNode.getChildren(DBNDatabaseNode.java:1)
	at org.jkiss.dbeaver.model.navigator.DBNUtils.getNodeChildrenFiltered(DBNUtils.java:70)
	at org.jkiss.dbeaver.ui.navigator.database.load.TreeLoadService.evaluate(TreeLoadService.java:49)
	at org.jkiss.dbeaver.ui.navigator.database.load.TreeLoadService.evaluate(TreeLoadService.java:1)
	at org.jkiss.dbeaver.ui.LoadingJob.run(LoadingJob.java:87)
	at org.jkiss.dbeaver.ui.LoadingJob.run(LoadingJob.java:71)
	at org.jkiss.dbeaver.model.runtime.AbstractJob.run(AbstractJob.java:105)
	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:63)
Caused by: org.firebirdsql.jdbc.FBSQLExceptionInfo: arithmetic exception, numeric overflow, or string truncation
!SUBENTRY 3 org.jkiss.dbeaver.model 2 0 2020-09-16 09:38:02.805
!MESSAGE arithmetic exception, numeric overflow, or string truncation
!STACK 0
org.firebirdsql.jdbc.FBSQLExceptionInfo: arithmetic exception, numeric overflow, or string truncation
!SUBENTRY 4 org.jkiss.dbeaver.model 2 0 2020-09-16 09:38:02.806
!MESSAGE string right truncation

!ENTRY org.jkiss.dbeaver.model 4 0 2020-09-16 09:38:20.487
!MESSAGE org.jkiss.dbeaver.model.impl.jdbc.struct.JDBCDataType cannot be cast to org.jkiss.dbeaver.ext.firebird.model.FireBirdDataType
!SUBENTRY 1 org.jkiss.dbeaver.model 4 0 2020-09-16 09:38:20.487
!MESSAGE org.jkiss.dbeaver.model.impl.jdbc.struct.JDBCDataType cannot be cast to org.jkiss.dbeaver.ext.firebird.model.FireBirdDataType
!STACK 0
java.lang.ClassCastException: org.jkiss.dbeaver.model.impl.jdbc.struct.JDBCDataType cannot be cast to org.jkiss.dbeaver.ext.firebird.model.FireBirdDataType
	at org.jkiss.dbeaver.ext.firebird.model.FireBirdTableColumn.<init>(FireBirdTableColumn.java:42)
	at org.jkiss.dbeaver.ext.firebird.model.FireBirdMetaModel.createTableColumnImpl(FireBirdMetaModel.java:317)
	at org.jkiss.dbeaver.ext.generic.model.TableCache.fetchChild(TableCache.java:140)
	at org.jkiss.dbeaver.ext.generic.model.TableCache.fetchChild(TableCache.java:1)
	at org.jkiss.dbeaver.model.impl.jdbc.cache.JDBCStructCache.loadChildren(JDBCStructCache.java:129)
	at org.jkiss.dbeaver.model.impl.jdbc.cache.JDBCStructCache.getChildren(JDBCStructCache.java:221)
	at org.jkiss.dbeaver.ext.generic.model.GenericTableBase.getAttributes(GenericTableBase.java:153)
	at org.jkiss.dbeaver.ext.firebird.model.FireBirdTable.getAttributes(FireBirdTable.java:77)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.jkiss.dbeaver.model.navigator.DBNDatabaseNode.extractPropertyValue(DBNDatabaseNode.java:867)
	at org.jkiss.dbeaver.model.navigator.DBNDatabaseNode.access$1(DBNDatabaseNode.java:848)
	at org.jkiss.dbeaver.model.navigator.DBNDatabaseNode$PropertyValueReader.run(DBNDatabaseNode.java:907)
	at org.jkiss.dbeaver.model.navigator.DBNDatabaseNode$PropertyValueReader.run(DBNDatabaseNode.java:1)
	at org.jkiss.dbeaver.model.exec.DBExecUtils.tryExecuteRecover(DBExecUtils.java:168)
	at org.jkiss.dbeaver.model.navigator.DBNDatabaseNode.loadTreeItems(DBNDatabaseNode.java:534)
	at org.jkiss.dbeaver.model.navigator.DBNDatabaseNode.loadChildren(DBNDatabaseNode.java:424)
	at org.jkiss.dbeaver.model.navigator.DBNDatabaseNode.getChildren(DBNDatabaseNode.java:201)
	at org.jkiss.dbeaver.model.navigator.DBNDatabaseNode.getChildren(DBNDatabaseNode.java:1)
	at org.jkiss.dbeaver.model.navigator.DBNUtils.getNodeChildrenFiltered(DBNUtils.java:70)
	at org.jkiss.dbeaver.ui.navigator.itemlist.ItemListControl$ItemLoadService.evaluate(ItemListControl.java:256)
	at org.jkiss.dbeaver.ui.navigator.itemlist.ItemListControl$ItemLoadService.evaluate(ItemListControl.java:1)
	at org.jkiss.dbeaver.ui.LoadingJob.run(LoadingJob.java:87)
	at org.jkiss.dbeaver.ui.LoadingJob.run(LoadingJob.java:71)
	at org.jkiss.dbeaver.model.runtime.AbstractJob.run(AbstractJob.java:105)
	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:63)

The dbeaver-debug.log file is
> Start Eclipse IDE UI Application [org.eclipse.ui.ide.application 1.3.600.v20200116-2127]
> Start Eclipse e4 Workbench SWT [org.eclipse.e4.ui.workbench.swt 0.14.900.v20200213-1442]
> Start Eclipse Application Services [org.eclipse.e4.core.services 2.2.200.v20200127-0814]
> Start Eclipse Contexts [org.eclipse.e4.core.contexts 1.8.400.v20191217-1710]
> Start Eclipse UI Application Services [org.eclipse.e4.ui.services 1.3.700.v20190930-1643]
> Start EMF Common [org.eclipse.emf.common 2.18.0.v20191225-1014]
> Start EMF Ecore [org.eclipse.emf.ecore 2.21.0.v20200127-1342]
> Start EMF XML/XMI Persistence [org.eclipse.emf.ecore.xmi 2.16.0.v20190528-0725]
> Start Eclipse UI Dependency Injection [org.eclipse.e4.ui.di 1.2.800.v20200128-0855]
> Start Eclipse e4 Workbench Add-ons [org.eclipse.e4.ui.workbench.addons.swt 1.3.800.v20191212-1231]
> Start Expression Language [org.eclipse.core.expressions 3.6.700.v20200212-1751]
> Start Eclipse e4 Workbench SWT Renderer [org.eclipse.e4.ui.workbench.renderers.swt 0.14.1100.v20200217-1217]
> Start Eclipse Bindings Support [org.eclipse.e4.ui.bindings 0.12.800.v20191216-0805]
> Start Eclipse Dependency Injection Extensions [org.eclipse.e4.core.di.extensions 0.15.500.v20200106-1259]
> Start Eclipse CSS SWT Support [org.eclipse.e4.ui.css.swt 0.13.900.v20200203-0840]
> Start Eclipse CSS SWT Theme Support [org.eclipse.e4.ui.css.swt.theme 0.12.600.v20200124-0005]
> Start DBeaver UI [org.jkiss.dbeaver.ui <IP_ADDRESS>008302047]
> Start Help System Core [org.eclipse.help 3.8.700.v20191212-1123]
> Start Equinox Provisioning Core [org.eclipse.equinox.p2.core 2.6.300.v20200211-1504]
> Start Equinox Provisioning Operations API [org.eclipse.equinox.p2.operations 2.5.700.v20191211-1713]
> Start Equinox Provisioning Platform Automatic Update Support [org.eclipse.equinox.p2.ui.sdk.scheduler 1.4.600.v20200221-0754]
> Start Equinox Provisioning Metadata [org.eclipse.equinox.p2.metadata 2.4.700.v20191213-1911]
> Start Equinox Provisioning Update Checker [org.eclipse.equinox.p2.updatechecker 1.2.300.v20200222-1600]
> Start Equinox Provisioning Engine [org.eclipse.equinox.p2.engine 2.6.600.v20200110-2121]
> Start Equinox Provisioning Metadata Repository [org.eclipse.equinox.p2.metadata.repository 1.3.400.v20191211-1528]
> Start Equinox Provisioning Repository [org.eclipse.equinox.p2.repository 2.4.700.v20200110-2121]
> Start Equinox Provisioning UI Support [org.eclipse.equinox.p2.ui 2.5.800.v20200213-1530]
> Start DBeaver SQL Model [org.jkiss.dbeaver.model.sql <IP_ADDRESS>008302047]
> Start Default Text Editor [org.eclipse.ui.editors 3.13.100.v20200130-1507]
> Start Text Editor Framework [org.eclipse.ui.workbench.texteditor 3.14.100.v20200212-1049]
> Start DBeaver UI Editors - Base [org.jkiss.dbeaver.ui.editors.base <IP_ADDRESS>008302047]
> Start DBeaver UI Editors - SQL [org.jkiss.dbeaver.ui.editors.sql <IP_ADDRESS>008302047]
> Start DBeaver UI Editors - Data [org.jkiss.dbeaver.ui.editors.data <IP_ADDRESS>008302047]
> Start DBeaver Sample Database [org.jkiss.dbeaver.ext.sample.database <IP_ADDRESS>008302047]
> Start DBeaver Tip of the day [org.jkiss.dbeaver.ext.ui.tipoftheday <IP_ADDRESS>008302047]
> Start File Buffers [org.eclipse.core.filebuffers 3.6.900.v20200117-0616]
> Start DBeaver ER Diagram [org.jkiss.dbeaver.ext.erd <IP_ADDRESS>008302047]
> Start Team Support Core [org.eclipse.team.core 3.8.900.v20200211-0946]
> Start DBeaver Generic Plug-in [org.jkiss.dbeaver.ext.generic <IP_ADDRESS>008302047]
> Start DBeaver Firebird Support [org.jkiss.dbeaver.ext.firebird <IP_ADDRESS>008302047]
> Start Equinox Java Authentication and Authorization Service (JAAS) [org.eclipse.equinox.security 1.3.500.v20200114-1637]
> Start GEF (MVC) [org.eclipse.gef <IP_ADDRESS>606061308]
> Start Draw2d [org.eclipse.draw2d <IP_ADDRESS>606061308]

With further testing it seems related to the size of the database structure though I have not determined when it fails, but if I half the structure (tables, procedures, etc - no data), it will work, but if if gets too big in structure, it will fail.

OK, took a bit of figuring, but here is a DB script that causes the error from scratch.
Looks like the real error is the first exception (Can't fetch database data types as above) which is not shown to the user (unless the error log is open). You then go and open a table with, say a BOOLEAN domain, whose information was not properly loaded because of the first exception, and then you get the Class Cast exception.
A reasonably nasty looking but legit computed by column causes the issue. The computed by column uses an external function (FreeAdhocUDF) which I don't think is the cause of the issue... I tried to remove it from the example to make it simpler, but I think it simplified and shortened it too much and it then worked.
The full DB script is shown below which causes the issue on a new DB.
SET SQL DIALECT 3;

SET NAMES NONE;

CREATE DATABASE 'test-db:Quick_Test_8.fdb'
USER 'SYSDBA'
password 'masterkey'
PAGE_SIZE 16384
DEFAULT CHARACTER SET NONE COLLATION NONE;

/******************************************************************************/
/****                     User defined functions (UDF)                     ****/
/******************************************************************************/
DECLARE EXTERNAL FUNCTION F_ENCODEDATE
    INTEGER,
    INTEGER,
    INTEGER
    RETURNS DATE FREE_IT
    ENTRY_POINT 'encodedate' MODULE_NAME 'FreeAdhocUDF';

/******************************************************************************/
/****                               Domains                                ****/
/******************************************************************************/
CREATE DOMAIN BOOLEAN AS
CHAR(1)
 DEFAULT 'F'
NOT NULL
CHECK (Value in ('T',  'F'));

CREATE DOMAIN CURRENCY AS
NUMERIC(18,2)
DEFAULT 0
NOT NULL;

CREATE DOMAIN INT_ID AS
INTEGER;

/******************************************************************************/
/****                          Stored procedures                           ****/
/******************************************************************************/
SET TERM ^ ;

CREATE PROCEDURE NWD_SEL_NUM_WORKING_DAYS (
    START_DATE_TIME TIMESTAMP NOT NULL,
    END_DATE_TIME TIMESTAMP NOT NULL,
    HOLIDAY_REGION_ID INTEGER NOT NULL)
RETURNS (
    NUM_WORKING_DAYS INTEGER NOT NULL)
AS
BEGIN
  SUSPEND;
END^

SET TERM ; ^

/******************************************************************************/
/****                                Tables                                ****/
/******************************************************************************/
CREATE TABLE TABLE_THAT_CREATES_THE_FAILURE (
    BUSINESS_UNIT_ID       INT_ID NOT NULL,
    CALENDAR_YEAR          INTEGER NOT NULL,
    CALENDAR_MONTH         INTEGER NOT NULL,
    SALES                  CURRENCY,
    BUDGET                 CURRENCY,
    FORECAST               CURRENCY,
    PERCENT_THROUGH_MONTH  COMPUTED BY (iif(F_Encodedate(Calendar_Year, Calendar_Month, 1) < F_Encodedate(extract(year from current_date), extract(month from current_date), 1), 1,
    iif(F_Encodedate(Calendar_Year, Calendar_Month, 1) > F_Encodedate(extract(year from current_date), extract(month from current_date), 1), 0,
    ((select Num_Working_Days from Nwd_Sel_Num_Working_Days(F_Encodedate(Calendar_Year, Calendar_Month, 1), current_date, 2)) + 0.00) / (select Num_Working_Days from Nwd_Sel_Num_Working_Days(F_Encodedate(Calendar_Year, Calendar_Month, 1), F_Encodedate(Calendar_Year, Calendar_Month, extract(day from dateadd(1 month to F_Encodedate(Calendar_Year, Calendar_Month, 1))-1)), 2))))),
    TIME_STAMP             TIMESTAMP
);

CREATE TABLE TABLE_THAT_SHOWS_THE_FAILURE (
    ID                       INT_ID NOT NULL,
    TIME_STAMP               TIMESTAMP,
    WAS_ON_HOLD              BOOLEAN NOT NULL
);

Confirmed it is not the external function, you can comment that out and cast the dates (replace the problem column with the below) and it still fails.
    PERCENT_THROUGH_MONTH  COMPUTED BY (iif(cast (Calendar_Year || '/' || Calendar_Month || '/01' as date) < cast(extract(year from current_date) || '/' || extract(month from current_date) || '/01' as date), 1,
    iif(cast(Calendar_Year || '/' || Calendar_Month  || '/01' as date) > cast(extract(year from current_date) || '/' || extract(month from current_date)  || '01/' as date), 0,
    ((select Num_Working_Days from Nwd_Sel_Num_Working_Days(cast(Calendar_Year  || '/' || Calendar_Month  || '/01' as date), current_date, 2)) + 0.00) / (select Num_Working_Days from Nwd_Sel_Num_Working_Days(cast(Calendar_Year || '/' || Calendar_Month  || '01/' as date), cast(Calendar_Year || '/' || Calendar_Month  || '/' || extract(day from dateadd(1 month to cast(Calendar_Year || '/' || Calendar_Month  || '01/' as date))-1) as date), 2))))),

Not sure if this issue gets re-looked at after been tagged "Can't Reproduce"... should I file another request or can the "Can't Reproduce" tag be taken off given the latest info (and put back on if it still can't be reproduced - which I am hoping will not be the case)?

@cfnz I still can't reproduce on our Firebird database, i will try another database... or, you can try sent here yours database test-db:Quick_Test_8.fdb

Just ran the script above (with the altered PERCENT_THROUGH_MONTH so I didn't need the user defined function), tested (still fails) then zipped (not backed up) the file and attached.
I am running against a Firebird 2.5.6 database SuperClassic. Also, just downloaded Firebird 2.5.9 and installed on a fresh Ubuntu box, created the database from the script on that and still had the error.
So one other thing that could be different is the jdbc driver. I am using jaybird-4.0.1.java8.jar. (Have tried some other versions a while ago (can't recall which ones) and still had the error.)
Hopefully you can replicate, if not, I can test some more.
Quick_Test_8.fdb.zip

verified

@cfnz thanks for the test base, it helped a lot in finding the error. I hope. you will be able to test the changes in version 7.2.2, it will be released next Monday

Thanks for that, can also confirm it closes the issue :-)


Buffer(0) drops interiors of valid shape

Expected behavior and actual behavior.
The shape in this file shape.txt is valid according to is_valid, so we expect buffer(0) to have no effect on the shape, instead we're seeing some of the interiors are dropped:

Steps to reproduce the problem.
import shapely.wkt

with open('shape.txt', 'r') as f:
    geom = shapely.wkt.loads(f.read())

assert geom.is_valid
assert geom.equals(geom.buffer(0))

Operating system
Ubuntu 18.04.5 LTS
Shapely version and provenance
Installed with conda:
shapely, 1.7.1, py38hc7361b7_1, conda-forge

I can't say that I know what's going on here specifically, but it looks like the dropped interior rings are all clustered in one area, down in the bottom right of the problem polygon.

I can't say that I know what's going on here specifically, but it looks like the dropped interior rings are all clustered in one area, down in the bottom right of the problem polygon.

Thanks @tomplex, is it possible that the problem is with is_valid rather than buffer? Just trying to find the root of the problem.

Thanks @tomplex, is it possible that the problem is with is_valid rather than buffer? Just trying to find the root of the problem.

Hi @wikusbrinkNearmap,
This geometry is valid according to GEOS and JTS. Buffering this polygon in JTS did not drop rings, so I suspect it's an issue with the GEOS implementation specifically.

Hi @wikusbrinkNearmap,
This geometry is valid according to GEOS and JTS. Buffering this polygon in JTS did not drop rings, so I suspect it's an issue with the GEOS implementation specifically.

Can you post the result of:
python -c "import shapely.geos; print(shapely.geos.geos_version)"

Can you post the result of:
python -c "import shapely.geos; print(shapely.geos.geos_version)"

Can you post the result of:
python -c "import shapely.geos; print(shapely.geos.geos_version)"

I get (3, 8, 1)

Can you post the result of:
python -c "import shapely.geos; print(shapely.geos.geos_version)"

I get (3, 8, 1)

Thanks. I submitted a ticket to the GEOS tracker regarding this issue.
For now, I would suggest only buffering invalid geometries, or you could install Shapely from source using the master branch and access the validation.make_valid function, if that is your end goal.

Thanks. I submitted a ticket to the GEOS tracker regarding this issue.
For now, I would suggest only buffering invalid geometries, or you could install Shapely from source using the master branch and access the validation.make_valid function, if that is your end goal.

Thanks. I submitted a ticket to the GEOS tracker regarding this issue.
For now, I would suggest only buffering invalid geometries, or you could install Shapely from source using the master branch and access the validation.make_valid function, if that is your end goal.

Thanks Tom, appreciate it.

Thanks. I submitted a ticket to the GEOS tracker regarding this issue.
For now, I would suggest only buffering invalid geometries, or you could install Shapely from source using the master branch and access the validation.make_valid function, if that is your end goal.

Thanks Tom, appreciate it.

This does look like an issue with the GEOS buffer algorithm.  And it's a tricky one.

This does look like an issue with the GEOS buffer algorithm.  And it's a tricky one.

This seems to work with the latest GEOS version (3.11.1):
In [31]: import shapely.wkt
    ...:
    ...: with open('../Downloads/shape.txt', 'r') as f:
    ...:     geom = shapely.wkt.loads(f.read())
    ...:

In [32]: geom
Out[32]: <POLYGON ((4096 1824, 4095 1825, 4083 1836, 4075 1839, 4052 1837, 4042 1823,...>

In [33]: geom.is_valid
Out[33]: True

In [34]: geom.equals(geom.buffer(0))
Out[34]: True

In [35]: shapely.geos_version
Out[35]: (3, 11, 1)

It seems that the latest shapely version 2.0.6 as of 2024/10/02, that uses GEOS 3.11.4, still has this bug:
In [1]: import shapely.wkt

In [2]: with open('shape.txt', 'r') as f:
   ...:     geom = shapely.wkt.loads(f.read())
   ...:

In [3]: geom.is_valid
Out[3]: True

In [4]: geom.equals(geom.buffer(0))
Out[4]: False

In [5]: shapely.geos_version
Out[5]: (3, 11, 4)

shape.txt

Is there a specific reason why you use geom.buffer(0) instead of shapely.make_valid(geom)?

Not sure about @zhanlilz but we stumbled over this in geopandas prior to the v1.0.0 release (that switched buffer(0) to make_valid in the overlay code).

@theroggy, make_valid returns geometrycollection while buffer(0) will fix invalid geoms and return the intended geometry type. This is handy when using geopandas.GeoSeries.buffer(0).
However, I've noticed that make_valid also incorrectly drops interiors. I need to dig out this shape and share it here.

@theroggy, make_valid returns geometrycollection while buffer(0) will fix invalid geoms and return the intended geometry type.

In the upcoming next minor version of shapely make_valid will get some extra options, including one that will make sure that only geometries of the original imput geometry are returned.

That is huge for us @theroggy! Thanks for the update.


Issue #221

Pull Request: Fix Footer Positioning ISSUE: #221
Description
This pull request addresses an issue with the footer's positioning on the page. The footer was previously overlapping other elements due to the main tag having an absolute positioning style, which broke the natural flow of the layout.
Changes Made

Removed absolute positioning from the main tag, allowing the footer to display correctly without overlapping other content.
Ensured the footer aligns properly with the rest of the page elements, improving layout consistency and user experience.
Previously the scroll to the top button used to get hidden by the hero image now since the flow is returned to normal it is no longer hidden

@jaison-jai-john deployment is not visible and please resolve conflicts


Add back SSH popup

It would be nice to provide users quick access to their public IP, port and SSH password via a small popup in the bottom right of the IDE

@nol166 Why was this closed? Does this functionality already exist? Are we planning on making this a coder-hosted option only?

It doesn't relate to the open source binary, only the ide.coder.com hosted version. TLDR: wrong repo


D3 zoom not working with mousewheel in safari Version 10.0 (Mac)

The issue is reproduced only in Safari (FireFox, Chrome works as expected).
I'm using last version of D3 (4.2.2 and 4.4)
The problem that D3 wheel zoom works only on g element and doesn't work over svg element. Note dbClick zoom works over svg.
Steps of reproduce (Safari):

Mouse over on red rect and start wheel zoom

zoom works

Mouse over on svg element near of red rect

zoom doesn't work

Note: there is exists some zones in svg (left and top) where zoom works. This illustration described in stackoverflow link.
Reproduce of issue: https://bl.ocks.org/mbostock/91b75091873d06add0666f35c2e6afb4
JS fiddle for any case: https://jsfiddle.net/vbabenko/5shshq97/7/
Solution to fix:
If you want the SVG to receive the event on all browsers, you must put some content in the SVG to capture the wheel event. Here is a fixed test case: https://bl.ocks.org/mbostock/9e3fed7a5904991e7973a87628d9f84d
comments taken from the ticket https://github.com/d3/d3/issues/3035

Closed per https://github.com/d3/d3/issues/3035#issuecomment-266066432

https://bugs.webkit.org/show_bug.cgi?id=226683


Issues with Xpath patterns

Just trying your v2 script, I think there are a few issues:

adwordsUrl and title for ad is always coming blank
The news results are not being scraped, always empty array

@sameerpanjwani  Thanks for reporting
That's possible because v2 is not finished yet. I should tell it in the readme. By the way I keep your issue opened until I fix it !

Closing the issue because it is replaced by https://github.com/serp-spider/search-engine-google ;)


Do not invalidate RCTInstance if jsbundle failed to load

Summary:
With this diff we will not be invalidating the RCTInstance in case of jsbundle loading error.
This change will allow us to to show the RedBox error message. We couldn't do that previously because we weren't able to instantiate the "RedBox" module for the the RCTTurboModuleRegistry that was in invalid state together with RCTInstance.
Changelog: [iOS][Fixed] - Show RedBox error message if Metro instance is not running.
Differential Revision: D54364278

Closing as abandoned internally


bug(mat-select): "mat-select-trigger" breaks the view with 'mat-chip-list' component

Is this a regression?

[X] Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was
13.1.1
Description
With a new update, it started to break the view which is not expected for multiple selections.
Demo: https://stackblitz.com/edit/angular

Reproduction
Provided a demo in description in StackBlitz
Expected Behavior
Should work as it was previously in 13.1.1 or somehow handle it )
Actual Behavior
Broken view of the mat-select component.
Environment

Angular:
CDK/Material:
Browser(s):
Operating System (e.g. Windows, macOS, Ubuntu):

Chips inside of a select are not an interaction pattern we support, because it doesn't make sense in terms of accessibility. It happened to work in the past by accident.


Avoid overwriting user-set ignored warnings

Current implementation overwrites any user-set warnings, this PR resolves that.

Coverage increased (+0.07%) to 95.489% when pulling 98fec46297d034a566cd5f172d425e306f870292 on chapsule:patch/ignored-warnings into 44c8ec6057ed08aef8e99cddbe13992a43ac5d51 on xgfe:master.

But I will remove these code soon.


Wrap  KeyError from fetch_refspec into SCMError.

fix: #154

Wrap KeyError from fetch_refspec into SCMError.
Modify the test to test this change.

Looks like also suffer from the https://github.com/iterative/py-template/pull/92


extract packadge goes wrong it seems

hi it's me again :))
i found this after re-downloading

any idea?? .-.

May I know which version do you have right now?
Is it 1.69.7 or 1.69.8?

1.69.8, the newest, i think i upgrade the launcher around this morning after it release

Alright, we found this issue as a bug in recent version (1.69.8)
We are currently fixing this and hopefully, get a patch pushed very soon.

Hi @ibeez11,
A new patch 1.69.10 already pushed with the fix for your issue.
Please your update your launcher and try again

alright, i got that update notification, thanks a lot for the information :))
hope there's will be less bug so u and ur team can take a rest :))


How to play video and audio simultaneously

First I want to thank you, because I like to use your Adapter.
I use it to play YouTube Videos in 720p30 directly without advertisements (url2play).
If I want to have a higher video quality, YouTube splits up the media. E.g. there is a webm 1080p60 video and a webm 160k audio file like seen in this table:
https://gist.github.com/sidneys/7095afe4da4ae58694d128b1034e01e2
So I ask you to help me playing a video and an audio file on the chromecast simultaneously. Somehow it has to be possible, because the YouTube app does it similar while streaming.

However, if you want to combine video and audio streams then maybe look at FFmpeg. I imagine there is a way to tell it to do what you want. Ie. take this video stream + that audio stream and serve up a output stream with them synchronised and combined. You can then send that combined stream that to any device you like, right?


WIP: add and use global definedness cache

Part of #3126
Scope:
Estimate:

Review checklist
The author performs the actions on the checklist. The reviewer evaluates the work and checks the boxes as they are completed.

[ ] Summary. Write a summary of the changes. Explain what you did to fix the issue, and why you did it. Present the changes in a logical order. Instead of writing a summary in the pull request, you may push a clean Git history.
[ ] Documentation. Write documentation for new functions. Update documentation for functions that changed, or complete documentation where it is missing.
[ ] Tests. Write unit tests for every change. Write the unit tests that were missing before the changes. Include any examples from the reported issue as integration tests.
[ ] Clean up. The changes are already clean. Clean up anything near the changes that you noticed while working. This does not mean only spatially near the changes, but logically near: any code that interacts with the changes!

Not much difference between this and master, can't find any new hotspots in the profile.
TODO: replace other isDefined with new, stateful isDefined


support to create dynamodb resource by cloudformation

add support to create dynamodb resource by cloudformation.

Coverage decreased (-0.01%) to 93.005% when pulling 359632aaec0e86eac5388669b7fb7995b9dd5b31 on koxudaxi:create_dynamodb_resource_by_cloudformation into 2a5f7e15a7bc748c1148dae922cb1a9f8672dcbe on spulec:master.

Great work :smile:

Thank you for your quick merge.
I will implement other feature 😁


307808132 Invalid text in gazetteer? (Ali)

Issue reported by AH001 at 2024-10-02 14:15:32 UTC
Time: 2024-10-02T13:15:52+00:00
Session ID: eab012a4b15dd704af68bfc41e5c927b
Problem Page URL: /freecen2_places/66fd2f20b18f7cf8bfbaef57?locale=en
Previous Page URL: https://www.freecen.org.uk/freecen2_places/66fd2f20b18f7cf8bfbaef57/edit?locale=en
Reported Issue:
Invalid text allowed in gazetteer but not in csv??, although place is in gazetteer it is shown as a warning, ie not in gazetteer, in csv.
Sweden Soderhamn

I do not understand the problem here.
The invalid text is presumably the dots over the o in the place name. The anglicised version is also recorded. A search to match a place of birth will presumably match the anglicised name.
We are aware that UTF8 has not been implemented on the csv collection. There is a story that covers this.
Characters that are not currently recognised are appearing in the Gazetteer and that is deliberate. Irish names in particular require this to be able to record the Gaelic name. We are collecting these names so that the Gazetteer is comprehensive and will not need to be revisited.
In this case the place name is in Sweden and the letter o is recorded correctly.
This issue will be addressed during development of POB searching as UTF8 is implemented.
Geoff
From: Vino-S @.>
Sent: Wednesday, 16 October 2024 7:16 PM
To: FreeUKGen/FreeCENMigration @.>
Cc: Geoff J @.>; Assign @.>
Subject: Re: [FreeUKGen/FreeCENMigration] 307808132 Invalid text in gazetteer? (Ali) (Issue #1813)
Assigned #1813 https://github.com/FreeUKGen/FreeCENMigration/issues/1813  to @geoffj-FUG https://github.com/geoffj-FUG .
—
Reply to this email directly, view it on GitHub https://github.com/FreeUKGen/FreeCENMigration/issues/1813#event-14672074858 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AKCPIFO3LTU5JIN65RG5R53Z3YVDLAVCNFSM6AAAAABPIDHOK6VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJUGY3TEMBXGQ4DKOA .
You are receiving this because you were assigned.  https://github.com/notifications/beacon/AKCPIFMUUDFFHWSUW54VFKTZ3YVDLA5CNFSM6AAAAABPIDHOK6WGG33NNVSW45C7OR4XAZNWJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XKUY3PNVWWK3TUL5UWJTYAAAAAG2UGDBVA.gif Message ID: @.*** @.***> >

I do not understand the problem here.
The invalid text is presumably the dots over the o in the place name. The anglicised version is also recorded. A search to match a place of birth will presumably match the anglicised name.
We are aware that UTF8 has not been implemented on the csv collection. There is a story that covers this.
Characters that are not currently recognised in csv and vld files are appearing in the Gazetteer and that is deliberate. Irish names in particular require this to be able to record the Gaelic name. We are collecting these names so that the Gazetteer is comprehensive and will not need to be revisited.
In this case the place name is in Sweden and the letter o is recorded correctly in the Gazetteer.
This issue will be addressed during development of POB searching as UTF8 is implemented.
Geoff
From: Vino-S @.>
Sent: Wednesday, 16 October 2024 7:16 PM
To: FreeUKGen/FreeCENMigration @.>
Cc: Geoff J @.>; Assign @.>
Subject: Re: [FreeUKGen/FreeCENMigration] 307808132 Invalid text in gazetteer? (Ali) (Issue #1813)
Assigned #1813 https://github.com/FreeUKGen/FreeCENMigration/issues/1813  to @geoffj-FUG https://github.com/geoffj-FUG .
—
Reply to this email directly, view it on GitHub https://github.com/FreeUKGen/FreeCENMigration/issues/1813#event-14672074858 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AKCPIFO3LTU5JIN65RG5R53Z3YVDLAVCNFSM6AAAAABPIDHOK6VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJUGY3TEMBXGQ4DKOA .
You are receiving this because you were assigned.  https://github.com/notifications/beacon/AKCPIFMUUDFFHWSUW54VFKTZ3YVDLA5CNFSM6AAAAABPIDHOK6WGG33NNVSW45C7OR4XAZNWJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XKUY3PNVWWK3TUL5UWJTYAAAAAG2UGDBVA.gif Message ID: < @.> @.>

The decision that the implementation of UTF-8 should be progressed confirms that the characters in Gaelic, Scandinavian etc alternative names are correct.
T believe that this story should be closed

Closing


How to add placeholder to a Text?

I want to add a placeholder to a Text

how this closed ? its dont even have any anwser


Combat window - Add close button

Request for adding a close button after combat validation (for now, user has to close using window's upper right close button).

Relevant ! Thank you 👍


New output format

There should be one file per snippet.
The file should be a zip-file with a guid as a filename and ".nss" as ending.
Structure:
[Guid].nss
└> Version
└> Dependencies
└> Variables
└> Template
└> Code

Enables to open .nss file by a doubleclick

The filename will not be a guid - less data to read when opening only one snippet


No warning when a use selects a launch template which specifies instance type and enables spot instance

What kind of request is this (question/bug/enhancement/feature request): bug
Steps to reproduce (least amount of steps as possible):

Create a hosted EKS cluster
Select a custom AWS Launch template (This will have instance type set)
Check Spot instances, select spot instance types
Deploy the cluster
Cluster is stuck in updating state with error: InvalidRequestException: Cannot specify instance types in launch template and API request { RespMetadata: { StatusCode: 400, RequestID: "a1453cde-67b4-4b5f-88c0-4acad15a1acb" }, ClusterName: "sowmya-spot-custom-25", Message_: "Cannot specify instance types in launch template and API request", NodegroupName: "sow-spot-2" }

Can we add a note/warning in the UI that when user selects an AWS launch template and Spot instances "instance template should not specify an “instance type.” "
Environment information

Rancher version (rancher/rancher/rancher/server image tag or shown bottom left in the UI): 2.5-head - commit id: 2ae4cf11
Installation option (single install/HA): single

Cluster information

Cluster type (Hosted/Infrastructure Provider/Custom/Imported): Hosted EKS
Kubernetes version (use kubectl version):

1.18 (Any)

Hmm I didn't test this scenario when I made a previous fix for when a user select spot instances without a template. I'll add logic to handle this coming down from the launch template. The instance type will get set null before save and you should see the help text that that field wont be sent, same as the other scenario I mentioned.

Verified on 2.5-head commit id: 8201e080 and master-head commit id: b4b2322fd

When user selects spot instances, Instance type is disabled and a note is available on the UI


Add a missing exception test for groupby

Found A missing exception test for groupby

could someone check this out when available?
have a great weekend, Thanks :)

Codecov Report

Merging #757 into master will decrease coverage by 2.34%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #757      +/-   ##
==========================================
- Coverage   93.91%   91.56%   -2.35%
==========================================
  Files          32       32
  Lines        5669     5669
==========================================
- Hits         5324     5191     -133
- Misses        345      478     +133

Impacted Files
Coverage Δ

databricks/koalas/usage_logging/__init__.py
23.14% <0%> (-74.08%)
:arrow_down:

databricks/koalas/usage_logging/usage_logger.py
50% <0%> (-50%)
:arrow_down:

databricks/koalas/__init__.py
77.5% <0%> (-7.5%)
:arrow_down:

databricks/conftest.py
90.69% <0%> (-6.98%)
:arrow_down:

databricks/koalas/frame.py
94.53% <0%> (-1.71%)
:arrow_down:

databricks/koalas/namespace.py
80.66% <0%> (-1.34%)
:arrow_down:

databricks/koalas/plot.py
93.78% <0%> (-1.13%)
:arrow_down:

databricks/koalas/utils.py
97.24% <0%> (-0.69%)
:arrow_down:

databricks/koalas/testing/utils.py
77.35% <0%> (-0.63%)
:arrow_down:

databricks/koalas/internal.py
95.83% <0%> (-0.47%)
:arrow_down:

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8973174...149f610. Read the comment docs.


[tool_crash] StateError: Bad state: No context with the running Dart application.

Command
flutter --no-color run --machine --track-widget-creation --device-id=chrome --start-paused --dart-define=flutter.inspector.structuredErrors=true --devtools-server-address=http://<IP_ADDRESS>:9100 lib\main.dart

Steps to Reproduce

...
...
...

Logs
StateError: Bad state: No context with the running Dart application.
#0      RemoteDebuggerExecutionContext.id (package:dwds/src/debugging/execution_context.dart:53:7)
<asynchronous suspension>
#1      AppInspector._getExtensionRpcs (package:dwds/src/debugging/inspector.dart:486:20)
<asynchronous suspension>
#2      AppInspector._initialize (package:dwds/src/debugging/inspector.dart:93:34)
<asynchronous suspension>
#3      AppInspector.initialize (package:dwds/src/debugging/inspector.dart:156:5)
<asynchronous suspension>
#4      ChromeProxyService.createIsolate (package:dwds/src/services/chrome_proxy_service.dart:214:18)
<asynchronous suspension>

[✓] Flutter (Channel beta, 2.1.0-12.2.pre, on Microsoft Windows [Version 10.0.19044.1586], locale en-US)
    • Flutter version 2.1.0-12.2.pre at D:\Webdesign Year 3\flutter\flutter
    • Framework revision 5bedb7b1d5 (1 year, 1 month ago), 2021-03-17 17:06:30 -0700
    • Engine revision 711ab3fda0
    • Dart version 2.13.0 (build 2.13.0-116.0.dev)

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at C:\Users\darsh\AppData\Local\Android\sdk
    • Platform android-31, build-tools 31.0.0
    • Java binary at: C:\Program Files\Java\jdk-14.0.2\bin\java
    • Java version Java(TM) SE Runtime Environment (build 14.0.2+12-46)
    • All Android licenses accepted.

[✓] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[!] Android Studio (not installed)
    • Android Studio not found; download from https://developer.android.com/studio/index.html
      (or visit https://flutter.dev/docs/get-started/install/windows#android-setup for detailed instructions).

[✓] VS Code (version 1.66.0)
    • VS Code at C:\Users\darsh\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension can be installed from:
      🔨 https://marketplace.visualstudio.com/items?itemName=Dart-Code.flutter

[✓] Connected device (2 available)
    • Chrome (web) • chrome • web-javascript • Google Chrome 100.0.4896.75
    • Edge (web)   • edge   • web-javascript • Microsoft Edge 99.0.1150.55

! Doctor found issues in 1 category.

Flutter Application Metadata
Type: app
Version: 1.0.0+1
Material: true
Android X: false
Module: false
Plugin: false
Android package: null
iOS bundle identifier: null
Creation channel: beta
Creation framework version: 2738a1148ba6c9a6114df62358109407c3ef2553
Plugins
flutter_facebook_login-3.0.0
flutter_plugin_android_lifecycle-1.0.11
flutter_secure_storage-3.3.5
image_picker-0.6.7+22
path_provider-2.0.4
path_provider_linux-2.1.0
path_provider_macos-2.0.2
path_provider_windows-2.0.3

Hi @dashu1999, this is a duplicate of #95916.
If you have any information on how to reproduce or what you were doing when you experienced this issue, kindly provide more details in #95916.
Closing from here as duplicate.
Thank you


removing the instrumental response

we need to improve our instrumental response options. Especially when we work with RESP files and arrays that have the same response file.

Provide functionality to remove responses of arrays that have the same response.


Release new version with fixed pagination

Hi, could you please release a new version with latest commit (which fixes pagination)? Thanks

@jankonas Can I close this issue now?

Yes, thank you


Make manual installation install also man pages

After running:
go get -u github.com/miquella/vaulted

I get vaulted in my $GOPATH/bin/vaulted, but it would be amazing if you could also make it so that manual pages would get installed to $GOPATH/share/man/man1/
Thanks to this, "man ..." would automatically work. Not sure if it's simple/complicated/possible/not-possible, as I don't write go myself, but that would be great addition.

@depesz: Unfortunately, go get doesn't provide a method to install additional files alongside the vaulted executable itself.
However, Vaulted does include embedded man pages that can be accessed with --help on each subcommand! For example, vaulted shell --help will launch man to display the embedded man page for the vaulted shell subcommand.
Perhaps we could consider a way to extract the embedded man pages and write them out somewhere. I'll have to think about that a bit!


Microsoft.ApiManagement/service/apis

Describe the noise
Resource type (i.e. Microsoft.Storage/storageAccounts)
Microsoft.ApiManagement/service/apis
apiVersion (i.e. 2019-04-01)
2019-01-01
Client (PowerShell, Azure CLI, or API)
PowerShell
Relevant ARM Template code (we only need the resource object for the above resourceType and apiVersion, but if it's easier you can include the entire template
link to relevant clip
    {
      "name": "[variables('apiResourceName')]",
      "type": "Microsoft.ApiManagement/service/apis",
      "apiVersion": "2019-01-01",
      "properties": {
        "displayName": "HTTP Bin API",
        "description": "API Management facade for a very handy and free online HTTP tool",
        "serviceUrl": "[parameters('serviceUrl')]",
        "path": "[variables('apiPath')]",
        "subscriptionRequired": false,
        "protocols": [
          "https"
        ]
      }
    },

Expected response (i.e. "I expected no noise since the template has not been modified since the resources were deployed)
Expected no noise
Current (noisy) response (either include a screenshot of the what-if output, or copy/paste the text)
  ~ Microsoft.ApiManagement/service/{serviceName}/apis/{apiName} [2019-01-01]
    - properties.apiRevision: "1"
    - properties.subscriptionKeyParameterNames:

        header: "Ocp-Apim-Subscription-Key"
        query:  "subscription-key"

Additional context

We believe we resolved all of the noise reported as part of this issue (https://github.com/Azure/arm-template-whatif/issues/77). Fix should have been fully deployed in w44. Please let us know if you are still seeing this issue.


Use bash for the shell command

Sets bash explicitly in command options for running a shell task.

Looks fine. What's the reason for this change?

Having fish as default shell makes it fail. I know you told me that it is not recommended to use fish as default shell but explicitly setting the shell is still a good idea.


JSON Schema: HTTP Filter schemas

-Breaks http configs into h/cc
-Increases tests coverage for http configs by adding server/config/http/config_test.cc
-Adds schema validation for applicable HTTP filters.
-Updates Fault Filter documentation to specify at least abort or delay must be specified in the config. The implementation has been updated to reflect expected behaviour.
-Added empty() method on JSON Objects.

@lyft/network-team @rshriram


Production mode in Angular

Hi,
I am currently setting up webpack 5 Federation Module under Angular 11.
Everything is ok in development mode but at the time of producing my project. I have an error : Error loading ScriptExternalLoadError: Loading script failed.
Indeed, the build in development and production mode does not produce the same "entryPoint":
Production Mode :
var library;(self.webpackChunklibrary=self.webpackChunklibrary||[]).push([[297],{795:function(e,n,r){"use strict";var i={"./web-components":function(){return Promise.all([r.e(547),r.e(382),r.e(155),r.e(807),r.e(676),r.e(110),r.e(821),r.e(533),r.e(215),r.e(592),r.e(144)]).then(function(){return function(){return r(9144)}})}},t=function(e,n){return r.R=n,n=r.o(i,e)?i[e]():Promise.resolve().then(function(){throw new Error('Module "'+e+'" does not exist in container.')}),r.R=void 0,n},o=function(e,n){if(r.S){var i=r.S.default,t="default";if(i&&i!==e)throw new Error("Container initialization failed as it has already been initialized with a different share scope");return r.S[t]=e,r.I(t,n)}};r.d(n,{get:function(){return t},init:function(){return o}})}},function(e){"use strict";var n=e(e.s=795);library=n}]);
We can see that there are several js files that have been minified and anonymized and this produces an error.
Have you already started producing Angular projects under Webpack 5 Module Federation?
Thanks !!

Thank you for creating this issue. However, issues need to follow one of our templates so that we can clearly understand your particular circumstances.
Please help us help you by recreating the issue using one of our templates.
Please ask it in angular repo


refactor DeFiAddress to export const

What kind of PR is this?:

/kind refactor
What this PR does / why we need it:
Avoid ES6 default export at all cost, technical debt minter.

going to merge now to generate package.


Preventing focus from leaving ChildWindow context.

First of all, thank you for all the hard work, I love it.
I was wondering, is there a way to prevent focus to leave the ChildWindow context when Tab is pressed?

I'm sorry, thought this to be an issue with ChildWindow, noticed only now that it was actually my code to cause that behavior. I'll close this.


IndexError: index 224 is out of bounds for dimension 1 with size 3

Hi, Thanks for your work!
I missed a problem when i use 8 as batch size, this is the error imformation:

Traceback (most recent call last):
File "/remote-home/share/jzhan/jzhan/WhisperASR2.py", line 85, in
res_list = model.transcribe(audio_data_list, language="zh")
File "/remote-home/share/jzhan/jzhan/batch_whisper/transcribe.py", line 75, in transcribe
return batch_transcribe(model=model,
File "/remote-home/share/jzhan/jzhan/batch_whisper/transcribe.py", line 477, in batch_transcribe
results: List[DecodingResult] = decode_with_fallback(torch.stack(batch_segments))
File "/remote-home/share/jzhan/jzhan/batch_whisper/transcribe.py", line 385, in decode_with_fallback
decode_result = model.decode(segment, options)
File "/remote-home/jzhan/miniconda3/envs/whisper/lib/python3.9/site-packages/torch/autograd/grad_mode.py", line 27, in decorate_context
return func(*args, **kwargs)
File "/remote-home/share/jzhan/jzhan/batch_whisper/decoding.py", line 860, in decode
result = DecodingTask(model, options).run(mel)
File "/remote-home/jzhan/miniconda3/envs/whisper/lib/python3.9/site-packages/torch/autograd/grad_mode.py", line 27, in decorate_context
return func(*args, **kwargs)
File "/remote-home/share/jzhan/jzhan/batch_whisper/decoding.py", line 772, in run
tokens, sum_logprobs, no_speech_probs = self._main_loop(audio_features, tokens)
File "/remote-home/share/jzhan/jzhan/batch_whisper/decoding.py", line 692, in _main_loop
probs_at_sot.append(logits[:, self.sot_index[i]].float().softmax(dim=-1))
IndexError: index 224 is out of bounds for dimension 1 with size 3

any solution?

I'm getting the same exact issue, seems to happen with longer files but can't pin it down.
Sometimes I can do 18 files but other times I get this error "IndexError: index 224 is out of bounds for dimension 1 with size 3" when only doing 6 files.
Working on Windows 10 with RTX 3060 12GB vram.
I'm continuing to test to see what the threshold is where it breaks. I'll post updates.
This is an awesome fork, probably the most useful I've seen so far, not sure why it's not getting more attention!

i get this too, tried it on batch 10, 15, 5.


kmerDecoder migration

This PR updates the kmerDecoder submodule with some modifications on kProcessor for compatibility.
@shokrof  please review and check if the tests are running as expected. I now have only 5 failing tests in this branch.
[  PASSED  ] 138 tests.
[  FAILED  ] 5 tests, listed below:
[  FAILED  ] testFrames/kDataFrameTest.saveAndLoadChangeDefaultColumn/2, where GetParam() = ("MAP", 21)
[  FAILED  ] testFrames/kDataFrameTest.saveAndLoadChangeDefaultColumn/4, where GetParam() = ("PHMAP", 21)
[  FAILED  ] testFrames/kDataFrameTest.saveAndIterateOverAllKmers/4, where GetParam() = ("PHMAP", 21)
[  FAILED  ] testFrames/kDataFrameTest.saveAndIterateOverAllKmers/5, where GetParam() = ("PHMAP", 31)
[  FAILED  ] testFrames/kDataFrameTest.transformPlus10/0, where GetParam() = ("MQF", 21)

This is a checkpoint. I will continue working on this migration one step at a time to make sure nothing will fail.

I pulled the latest changes from v2 and ran the tests.
[  PASSED  ] 136 tests.
[  FAILED  ] 7 tests, listed below:
[  FAILED  ] testFrames/kDataFrameTest.saveAndLoadChangeDefaultColumn/4, where GetParam() = ("PHMAP", 21)
[  FAILED  ] testFrames/kDataFrameTest.saveAndIterateOverAllKmers/2, where GetParam() = ("MAP", 21)
[  FAILED  ] testFrames/kDataFrameTest.saveAndIterateOverAllKmers/3, where GetParam() = ("MAP", 31)
[  FAILED  ] testFrames/kDataFrameTest.saveAndIterateOverAllKmers/4, where GetParam() = ("PHMAP", 21)
[  FAILED  ] testFrames/kDataFrameTest.saveAndIterateOverAllKmers/5, where GetParam() = ("PHMAP", 31)
[  FAILED  ] testFrames/kDataFrameTest.transformFilterLessThan5MultipleColumns/4, where GetParam() = ("PHMAP", 21)
[  FAILED  ] testFrames/kDataFrameTest.transformFilterLessThan5MultipleColumns/5, where GetParam() = ("PHMAP", 31)


Cherry pick 1245 into 0.26 release

Description:
Cherry-pick PR #1245

Codecov Report
Patch coverage: 97.14% and project coverage change: +0.64 :tada:

Comparison is base (bc0398b) 77.19% compared to head (cb49cac) 77.83%.

:exclamation: Current head cb49cac differs from pull request most recent head c35a143. Consider uploading reports for the commit c35a143 to get more accurate results

Additional details and impacted files
@@               Coverage Diff                @@
##           release/0.26    #1410      +/-   ##
================================================
+ Coverage         77.19%   77.83%   +0.64%
================================================
  Files                32       32
  Lines              2609     2599      -10
  Branches            539      539
================================================
+ Hits               2014     2023       +9
+ Misses              422      402      -20
- Partials            173      174       +1

Impacted Files
Coverage Δ

packages/relay/src/lib/relay.ts
70.83% <75.00%> (+0.62%)
:arrow_up:

packages/relay/src/lib/clients/clientCache.ts
80.00% <100.00%> (+65.71%)
:arrow_up:

packages/relay/src/lib/clients/mirrorNodeClient.ts
89.57% <100.00%> (-0.12%)
:arrow_down:

packages/relay/src/lib/clients/sdkClient.ts
20.83% <100.00%> (ø)

packages/relay/src/lib/eth.ts
85.04% <100.00%> (-0.06%)
:arrow_down:

.../relay/src/lib/services/hapiService/hapiService.ts
84.26% <100.00%> (+0.17%)
:arrow_up:

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Fix go fmt makefile target

This wasn't failing CI, but it was effectively not running the expected step so misformatted code might have snuck in accidentally.
@Shopify/kafka

:cool:


fixed TrackRequest()'s id and duration.

TrackRequest() now creates an ID and sends the duration in the format that is suggested by the Application Insights server that I use.
Please comment and/or merge.
Thanks!
Cheers,
Stefan

Hi Stefan,
Thank you for your submission.  On behalf of the AI team, I'd like to apologize that this has been unattended for so long.  I'm not on the SDK team proper, but I've volunteered to help with this SDK.  I also recently began using the Go SDK and ran into the same problems you have.  I've addressed some of them differently -- please see my PR for my implementation.  Note that it's just for reference, and I'd like to work with you to get this PR merged first (and then I'll go about merging mine).
There is a lot of good stuff here.  Normally I'd ask you to break it up, but instead there are a few things I'll revisit after this is merged (these are in my PR), including:

Request ID generation - I'll make this more in-line with the .Net SDK and avoid external libraries
Duration formatting - I think could be clearer.  Also, fractional seconds accepts 7 digits of precision (this is in-line with the .Net TimeSpan struct).

Otherwise, I'll start posting comments on the code.

@jjjordanmsft Is there any update on this? It seems that, from my very limited knowledge with ApplicationInsights, this Go SDK does not effectively work in logging requests in its current state (master).
@ZjMNZHgG5jMXw's fork does seem to work - at least from what I've tested so far. So at least it's a step in the right direction.

It's working here, but it's not working good. The Go library lacks, for instance, support for congestion control compared to its officially supported siblings. Congestion control support in the client is required by Application Insights. Currently, I have no plans to add the support, as we favour a different logging solution. However, I would love to see more official support for a library that is so central for running Go programs on Azure.

@jmshal Correct, any requests logged by the master branch version of this SDK will be rejected by the data ingestor because it will lack a request ID.  Further, some of the properties you might want to set are not made public.
I do have some interest in getting this close to par with the other SDKs, but little time to do it at the moment.  I have started some of the work in my fork -- which is used by another project that generates telemetry from nginx logs -- but it has some ways to go.  As I'm not on the SDK team, I can't promise much.  This SDK was started by the previous owners and hasn't yet been picked up by the current team.  Its current official status is "community-supported".

@jjjordanmsft what stops you to bring code from your fork back to repo? I made you a contributor on this repo in case you'd decide to merge.

@SergeyKanzhelev Thanks.  I did much of that work before I was aware of this PR, and it's not to the point where I was ready to merge it up anyway.

I've made an update that obsoletes this change and addresses the original issues.


Shrink the size of the NodeState object by using float over double fo…

…r initProgress and capacity. Also gc unused 'reliability' member.
@vekterli PR

The was the answer I was hoping for. I will start tearing out the disk states too.


Terminal file path clickability when colour changes midway through file path

VSCode Version: Code 1.16.0 (787b31c0474e6165390b5a5989c9619e3e16f953, 2017-09-06T16:27:49.891Z)
OS Version: Windows_NT x64 10.0.15063
Extensions:

Extension
Author (truncated)
Version

vscode-eslint
dba
1.3.0

githistory
don
0.2.3

tslint
eg2
1.0.3

csharp
ms-
1.12.1

PowerShell
ms-
1.4.2

Steps to Reproduce:

Take the setup here: https://github.com/TypeStrong/ts-loader/tree/master/examples/fork-ts-checker
npm install
npm start
Observe lack of clickability on errors:

The reason for this is the colour change that the fork-ts-checker-webpack-plugin produces between the path ("...fileWithError.ts") and the line number / column number ("(2:7)")
You can work around this by supplying a custom formatter to fork-ts-checker-webpack-plugin; see here: https://blog.johnnyreilly.com/2017/09/fork-ts-checker-webpack-plugin-code.html
However, I wonder if VS Code should be able to cope with these colour changes and preserve "clickability".  What do you think?

See related PR for fork-ts-checker-webpack-plugin that works around this issue: https://github.com/Realytics/fork-ts-checker-webpack-plugin/pull/48#issuecomment-328766562

This limitation is fixed in Insiders (https://github.com/sourcelair/xterm.js/issues/654), there are some lingering issues with links in Insiders though that should hopefully get fixed before it lands in stable.

Nice!