Preview button disappeared or not working.

Describe the bug
Preview button disappeared in NF and Tech trees, plus it's stopped working in gfx files.
Workstation is not as mod or in game files but in separate folder in desktop. Tho it's wasn't problem in v0.5.2
To Reproduce
Steps to reproduce the behavior:

Just try to open preview.

Expected behavior
Button should work.
Screenshots
NF tree

GFX

Desktop (please complete the following information):

OS: Windows 7
VSCode version: 1.70.3
Extension version: v0.6.1

Github error.


Exfat support

Are there any plans of supporting exFAT in the future?

There are no plans for exFAT support in the near future.
From what I know exFAT is very different from FAT12/16/32 - it has additional structures and different memory layout. Therefor adding it would require a lot of changes and a lot of new code. I'm not sure whether fatfs crate should support it or if differences are enough to make a separate crate more sensible. But I'm open for discussion (and code contributions).

I haven't looked at the exFAT specification quite yet, I am just doing some scoping for a future project. I'll have a look and come back with some more info. I am more than happy to contribute code :smiley:.

There is also this crate https://github.com/qiuchengxuan/exfat


v8::ObjectTemplate::Set() with non-primitive values is deprecated and will stop working in the next major release

⎆ pacman -Qi zeromq
Name            : zeromq
Version         : 4.1.4-1
Description     : Fast messaging system built on sockets. C and C++ bindings. aka 0MQ, ZMQ.
Architecture    : x86_64
URL             : http://www.zeromq.org
Licenses        : LGPL
Groups          : None
Provides        : None
Depends On      : gcc-libs  util-linux  libsodium  libpgm
Optional Deps   : None
Required By     : None
Optional For    : None
Conflicts With  : None
Replaces        : None
Installed Size  : 1904.00 KiB
Packager        : Kyle Keen<EMAIL_ADDRESS>Build Date      : Fri 11 Mar 2016 08:13:25 PM CST
Install Date    : Mon 28 Mar 2016 12:53:20 PM CDT
Install Reason  : Explicitly installed
Install Script  : No
Validated By    : Signature
⎆ npm ls
<EMAIL_ADDRESS>/mnt/code/lab/nodezmq
└─┬<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>└──<EMAIL_ADDRESS>⎆ node

var zmq = require('zmq')
(node) v8::ObjectTemplate::Set() with non-primitive values is deprecated
(node) and will stop working in the next major release.

==== C stack trace ===============================
1: v8::Template::Set(v8::Localv8::Name, v8::Localv8::Data, v8::PropertyAttribute)
2: zmq::Socket::Initialize(v8::Localv8::Object)
3: 0x7ff23685be09
4: node::DLOpen(v8::FunctionCallbackInfov8::Value const&)
5: v8::internal::FunctionCallbackArguments::Call(void (*)(v8::FunctionCallbackInfov8::Value const&))
6: 0x70650a
7: 0x70686c
8: 0x29e94140961b
(node) v8::ObjectTemplate::Set() with non-primitive values is deprecated
(node) and will stop working in the next major release.

@JustinTulloss @ronkorving can you please publish 2.16 with nan 2.3.x? The commit was already be merged in, but not published on NPM: https://github.com/JustinTulloss/zeromq.node/commit/945537d8e158320157de24a22ec13575d4d3ace2

Should be good now :+1:

:sparkling_heart:


This page is trying to load scripts from unauthenticated sources

Hi
I have an issue regarding to the Hugo final output with academic theme. After I push the public directory into the master repo, when I check my personal website, I recieve an error saying that "this page is trying to load scripts from unauthenticated sources". After I let the browser load the unsafe scripts, everything is as pretty as localhost output. Without it, it cannot load any scripts, and it looks like pure html code. What should I do?

see here for example:
https://sorooshafiee.github.io/

The problem appears to be that you are trying to access an HTTPS URL, but you defined the baseurl in config.toml using insecure http:// rather than secure https://.
Try using an https baseurl in the form:
baseurl = "HTTPS://replace-this-with-your-website-url.com/"

Let me try to fix it. Thanks for your fast reply :)


Added suite tests for the reallocator and fixed nil map edge cases

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

    __|__ |___| |\
    |o__| |___| | \
    |___| |___| |o \
   _|___| |___| |__o\
  /...\_____|___|____\_/
  \   o * o * * o o  /
~~~~~~~~~~~~~~~~~~~~~~~~~~


Allow for not only country but city and places and new cameras...

Overall, I normally look at the country, but the site allows for searching based on places and new cameras.  This could be a good enhancement.

I managed to fix up countries, cities, and interest but the other for new cameras defaults to 1000 pages which is too much.  Going to accept searching based on -c -C -i.


CQ-105332 – Kiosk mode reduces touchable area of content

Cordova app is most likely in immersive fullscreen mode. We can make use of that and install an OnSystemUiVisibilityChangeListener. As soon as the SystemUI is triggered we add an overlay that prevents user interactions. After ~2 seconds the System allows us to safely remove the SystemUI again.

does this also prevent hardware buttons interaction?

@tripodsan The Plugin does. My fix does not. I updated the description in order to clarify what the fix is actually about.


Nodout missing on windows

🐛 Describe the bug
From a user email:
recently we have binout files (LS-Dyna R12.10), which do not contain a nodout array anymore, if you read them with lasso-python 2.0.0. under Windows. With lasso-python1.5.2.post1 this also occurred. Under Linux it works with the 1.5.2.post1 however as it should, i.e. the nodout array is read correctly. With Meta / LS-PrePost the binout can also be read correctly.
🔢 To Reproduce
Steps to reproduce the behavior:

Read a binout file with nodout on windows
Check for nodout

💘 Expected behavior
Nodout should be readable.
🖥 Setup

lasso-python version: 1.5.2post1
OS: Windows

I am currently not using R12.10. Do you have a test binout file to monitor the issue?

Would close as no further message was given for thee time being


⚠ Bofrost.fr has degraded performance

In 57ca749, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 902 ms

Resolved: Bofrost.fr performance has improved in e559b19 after 6 minutes.


Restore view columns in latest versions of jenkins

Jenkins had long ago deprecated the "stapler-class" as a means of defining the column type, and recently they stopped supporting it altogether it seems.
This PR adds support for the new format, and hence fixes #85

Thank you!


Dismiss modal not working anymore

Ask your Question

Hey guys, how are you? I was using a modal an inside it I'm trying to use a PagerView but I can't dismiss the modal anymore. Any idea on it?
Please and thank you :)

Please provide a reproduction repository.


Build failed using master,

Tips before filing an issue
Build failed using master

Have you gone through our FAQs?

Join the mailing list to engage in conversations and get faster support at<EMAIL_ADDRESS>

If you have triaged this as a bug, then file an issue directly.

Describe the problem you faced
Build failed using master

A clear and concise description of the problem.
To Reproduce
Steps to reproduce the behavior:

Expected behavior
A clear and concise description of what you expected to happen.
Environment Description

Hudi version :
master

Spark version :

Hive version :

Hadoop version :

Storage (HDFS/S3/GCS..) :

Running on Docker? (yes/no) :

Additional context
Add any other context about the problem here.
Stacktrace
Add the stacktrace of the error.

I will fix it.

@Forus0322 I added the JsonEncoder due to which build is failing for you. It did not fail for me and also did not fail in CI of the PR that added this change - https://github.com/apache/hudi/pull/9579/
May I know what command are you using to build? Looking for ward to your fix.

@codope
mvn clean package install -DskipTests -Dspark3.3 -Dscala-2.12 -Dhadoop.version=3.3.0 -Dhive.version=3.1.2 -Phudi-platform-service  -Dcheckstyle.skip=true -Drat.skip=true -Pm1-mac -Pthrift-gen-source -Pflink1.14
I use it.

Thanks I am checking.

@codope hadoop 2.10.x references the org.codehaus.jackson:jackson-core-asl dependency package, but hadoop 3.3.0 does not have this dependency package.
Spark 3.1 Profile uses parquet.version 1.10.1, this version of parquet includes jackson, but Spark 3.2/3.3/3.4 Profile uses parquet.version 1.12.3. This version excludes the jackson dependency in the pom.
Therefore, when using hadoop 3.3.0 and parquet.version 1.12.3, a compilation error is reported.
The above is my analysis.

Yes you're right. Can you include the dependency only for Hadoop 3.3 profile? If we include every profile then it might lead to conflicts at runtime.

@codope ok, I will put the changes in the profile.

@codope I reverted the previous commit and added hadoop 3.3 profile.


Mid-message scripts (enclosed by three backticks) break formatting

See screenshot.  I wonder if there's a way to close any open backticks temporarily while streaming in the response.

Hi @Arro, I tried to implement a solution based on a derived store which is basically a "pipe" that auto-completes opened but unclosed code tags. It's not always perfect but seems to be much better while streaming the results and also when cancelling a completion inside of an opened code block. Would you mind testing it on the playground in the attached PR and giving some feedback? Does that solution solves your typical use-cases?

Definitely!

Tested, and it works so much better.
There's a separate issue of not being able to copy and paste while the message is in flight to you, but let's leave that for another time.

Cool, thanks! I merged this and will take a look at the other one in the next days.


use codecov

see #363

Looks like you haven't properly installed the requirements in the cov environment?
https://cirrus-ci.com/task/5949232106700800

ughh i just wanted to generate coverage without running the tests

@kne42 soooo, should we turn off ignoring all the tests now?

@jni could you explain more what you mean by this comment?

this is ready for re-review @jni

Fun!
  File "/usr/local/bin/pytest", line 10 in <module>
/tmp/scriptsc67cf22746e995af5a25367951baa2ff.sh: line 5:  2054 Aborted                 (core dumped) pytest --cov=./napari
Exit status: 134

:man_facepalming:

@jni CI is passing again, wanna give the coverage another look?

I was hoping for a new report, but I guess I'm happy to wait for the next PR. =)


refactor(messenger): support better custom fields for getUserProfile

add fields support for batch api
improve UserProfileField and User type

ref: https://developers.facebook.com/docs/messenger-platform/identity/user-profile/

can we have a test with custom fields and custom access token?

done


Dance Academy website

Description 📜
Add a new project which contain a website of Dance academy.
website of Dance Academy of cool frontend with the help of HTML , PUG ,CSS ,JavaScript , NodeJs.
You can go to contact page and can submit a form where you can start getting training for learning dance of any type from best mentors.
Fixes : #479
Type of change 📝

[x] Add a new project
[ ] Modified or enhanced the existing projects
[ ] Improve the readme of any project

Domain of Contribution 📊
Please delete options that are not relevant.And in order to tick the check box just but x inside them for example [x] like this

[x] Project using only HTML & CSS
[x] Project using HTML, CSS & JS
[x] Project using NodeJs
[x] Project using PUG

Checklist ✅

[x] I have performed a self-review of my own code or work.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] My changes generates no new warnings.
[x] I'm GSSoC'22 contributor

Screenshots / Gif (Optional) 📸

Kindly resolve the conflict

conflict resolved👍


Use TSLOG

I'm submitting a ... question about the decisions made in the repository

Summary tslog is unused even though it should've been the default way to log info, errors and stuff

Done in 735749a0b5aeab44d971fdf281a7cb882e95a749


Frontend: Search field does not show locally

having same issue. seems like the environment variable REACT_APP_API_BASE_URL needs to be set or get a default value.
starting the frontend with env REACT_APP_API_BASE_URL='http://localhost:5000' npm run start brought up the frontend, which showed the search bar (assuming of course that the backend is running at localhost:5000)

ping @aronhoyer in case you were working on this / looking at this


Randomize like_delay

Please follow the guide below

Issues submitted without this template format will be ignored.
You will be asked some questions and requested to provide some information, please read them carefully and answer completely.
Put an x into all the boxes [ ] relevant to your issue (like so [x]).
Use the Preview tab to see how your issue will actually look like.

Before submitting an issue, make sure you have:

[x ] Updated to the latest version
[x ] Read the README and docs
[ x] Searched the bugtracker for similar issues including closed ones

Purpose of your issue?

[ ] Bug report (encountered problems/errors)
[ ] Feature request (request for a new functionality)
[ x] Question
[ ] Other

Describe your issue
Hi guys, i want to set like_delay randomize i can select random like_delay with python "random" library but i want to set like_delay from like to like not just when starting bot. I want to select random like_delay from list like [45, 12, 96, 130, 190..] per like to like it means if bot like one photo 96 second it should like next photo in example 190 second later. Do u have any idea about this situation?

@MIKSby thank you for your reply but,
i did like it but i think this method start bot with random like delay for once so bot will like photos same like delay until i will stop the bot and start again. I want to chance like delay like to like in one process.


sink(ticdc): close conflict detector after workers are closed

What problem does this PR solve?

Issue Number: close #8285
What is changed and how it works?
Close conflict detector after all txn sink workers are closed.
Check List
Tests

Unit test
Integration test

Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note
None

/run-check-issue-triage-complete

/run-all-tests

/run-check-issue-triage-complete

/merge


Concrete projection of flowpipes (cont)

follow-up https://github.com/JuliaReach/ReachabilityAnalysis.jl/pull/145

https://github.com/JuliaReach/ReachabilityAnalysis.jl/blob/b580cff8ac8046581c368e604acd4e923160f4d5/src/Algorithms/GLGM06/project.jl#L43
Not sure if this is still used. But instead of linear_map, the function project from LazySets should be used directly (see https://github.com/JuliaReach/LazySets.jl/issues/2147).

those are indeed some leftovers from the previous codebase and can be removed (https://github.com/JuliaReach/ReachabilityAnalysis.jl/pull/163).


Which flight software is used to flight test?

@rkintada I'm curious which flight controller you use to test this repo in flight with the Snapdragon Flight? Do you use PX4 or some other? Do you use additional sensors? Some prescribed usage in the README might benefit user.

@Seanmatthews for the basic testing we use the bench-testing with hand-motions.  This is also tested with Qualcomm's Snapdragon Navigator Flight Controller( the flight controller is in the process of being released on Qualcomm Developer Network soon ) with a recommendation of the Flight Platform.   The sensors are pretty standard ones we use( IMU(MPU9x50), Pressure Sensor(BMP280), Optic Flow- OV7251( not when using VISLAM), external GPS).


Missing module prevents displaying a pipeline

It looks like something is not caught somewhere. Instead of displaying an invalid pipeline the usual way, if a module name isn't known, it is impossible to switch to the version at all.
Affects 2.1 and 2.2.
2015-05-22 16:04:49,918 CRITICAL:
vistrails/gui/vistrail_controller.py, line 616
Unexpected Exception
Traceback (most recent call last):
  File "vistrails/run.py", line 163, in <module>
    main()
  File "vistrails/run.py", line 157, in main
    v = app.exec_()
  File "vistrails/gui/collection/workspace.py", line 927, in item_selected
    open_vistrail(locator, **args)
  File "vistrails/gui/vistrails_window.py", line 1730, in open_vistrail_without_prompt
    view = self.open_vistrail(locator, version, is_abstraction)
  File "vistrails/gui/vistrails_window.py", line 1619, in open_vistrail
    is_abstraction):
  File "vistrails/core/application.py", line 435, in open_vistrail
    controller.select_latest_version()
  File "vistrails/core/vistrail/controller.py", line 3121, in select_latest_version
    self.change_selected_version(self.get_latest_version_in_graph())
--- Exception caught here ---
  File "vistrails/gui/vistrail_controller.py", line 553, in change_selected_version
    do_validate, from_root)
  File "vistrails/core/vistrail/controller.py", line 3782, in do_version_switch
    report_all_errors)
  File "vistrails/core/vistrail/controller.py", line 3522, in handle_invalid_pipeline
    cur_pipeline)
  File "vistrails/core/vistrail/controller.py", line 3406, in process_package_exceptions
    self, pipeline, old_module.id, new_pipeline)
  File "vistrails/core/upgradeworkflow.py", line 675, in replace_group
    old_group, new_group)
  File "vistrails/core/upgradeworkflow.py", line 630, in replace_generic
    old_conn.destination)
  File "vistrails/core/upgradeworkflow.py", line 427, in create_new_connection
    output_port_spec = src_module.get_port_spec(src_port, 'output')
  File "vistrails/core/vistrail/module.py", line 288, in get_port_spec
    if self.has_portSpec_with_name((port_name, port_type)):
  File "vistrails/core/vistrail/group.py", line 173, in has_portSpec_with_name
    self.make_port_specs()
  File "vistrails/core/vistrail/group.py", line 239, in make_port_specs
    self.get_port_spec_info(module)
  File "vistrails/core/vistrail/group.py", line 215, in get_port_spec_info
    module)
  File "vistrails/core/modules/sub_module.py", line 323, in get_port_spec_info
    sigstring, depth = coalesce_port_specs(neighbors, type)
  File "vistrails/core/modules/sub_module.py", line 267, in coalesce_port_specs
    cur_descs = port_spec.descriptors()
  File "vistrails/core/vistrail/port_spec.py", line 274, in descriptors
    return [i.descriptor for i in self.port_spec_items]
  File "vistrails/core/vistrail/port_spec_item.py", line 185, in _get_descriptor
    self.namespace)
  File "vistrails/core/modules/module_registry.py", line 772, in get_descriptor_by_name
    package_version)
MissingModule: Missing module NumPyArray in package edu.utah.sci.vistrails.matplotlib

Looks to be related somehow to the upgrade logic (or submodules?)

File is histogram.xml from DAT

(I haven't looked at the file yet.) This is probably related to the fact that upgrades are done module-by-module. That means after each upgrade, we need to construct connections from the updated module back to the rest of the pipeline. If there are two connected modules to be updated, the first is updated and may need to connect back to an invalid module which means the connection cannot be properly instantiated (meaning one port is not linked back to a valid port spec). There is code that is supposed to avoid this, but perhaps other changes have complicated it? Is the module in question a group or subworkflow?

There is indeed a Group involved.


Add missing importer logic

What this PR does / why we need it:
Some tailscale terraform resources were missing import capabilities.
Which issue this PR fixes (use fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged):
Fixes #441
Special notes for your reviewer:

I have tested the import functionality for each resource with a locally built provider.


Bot doesn't know how to deal with 'Cookies Comply Form'

Is there an existing issue for this?

[X] I have searched the existing issues

I'm submitting a ...

[X] bug report
[ ] feature request
[ ] support request --> Contact me over mail for support https://github.com/MShawon

Description
Sometimes, when youtube loads up, it throws the user to accept or deny cookies, the bot doesn't know how to handle this and it just waits until it timeouts

Environment
- OS : Windows 11
- Python : 3.10
- Script version : 1.7.1

config.json
{
    "http_api": {
        "enabled": true,
        "host": "<IP_ADDRESS>",
        "port": 5000
    },
    "database": true,
    "views": 1000,
    "minimum": 60.0,
    "maximum": 95.0,
    "proxy": {
        "category": "f",
        "proxy_type": "socks4",
        "filename": "socks4.txt",
        "authentication": false,
        "proxy_api": false,
        "refresh": 0.0
    },
    "background": false,
    "bandwidth": true,
    "playback_speed": 3,
    "max_threads": 5,
    "min_threads": 2
}

it knows how to deal with this kind of popup
use premium proxies ..looks like u are using some free proxies available on the internet which itself times out on loading the youtube page
install python 3.7 to 3.9 as mentioned in the Readme


Socratic Seminar 29 (May 2024)

Samurai founders charged with "Money Laundering And Unlicensed Money Transmitting Offenses"
https://archive.is/0nC3t

Phoenix to be removed from the app store on May 3rd, 2024
https://twitter.com/PhoenixWallet/status/1783878658014249027

Wasabi is no longer serving US residents and citizens
https://blog.wasabiwallet.io/zksnacks-now-blocking-u-s-residents-and-citizens/

The Future of Bitcoin Testnet
https://groups.google.com/g/bitcoindev/c/9bL00vRj7OU

Mining Development Kit is heading to Beta
https://www.mining.build/mdk-beta/

Emessbee Coinjoins
https://github.com/supertestnet/coinjoin-workshop

Great Script Restoration Project
https://github.com/rustyrussell/bips/blob/c2f268e83031b9b67e798c5c72a1171bfc463d1f/bip-unknown-var-budget-script.mediawiki
https://youtu.be/rSp8918HLnA

Utreexod Beta Release
https://groups.google.com/g/bitcoindev/c/5GyV9af9lv4

Microstrategy Orange and did:btc spec
https://bitcoinmagazine.com/business/microstrategy-announces-decentralized-id-platform-on-bitcoin-called-microstrategy-orange
https://microstrategy.github.io/did-btc-spec

Consensus enforced lamport signatures https://bitcoinops.org/en/newsletters/2024/05/08/#consensus-enforced-lamport-signatures-on-top-of-ecdsa-signatures

Future of bitcoin testnet https://groups.google.com/g/bitcoindev/c/9bL00vRj7OU/m/t6lm-nKmAQAJ

Assigning BIP numbers https://blog.bitmex.com/assigning-bip-numbers/

Halving aftermath
https://nicosmid.substack.com/p/the-halving-aftermath

OSJF launch https://www.osjf.org/

Quit calling it MEV https://bluematt.bitcoin.ninja/2024/04/16/stop-calling-it-mev/

On Runes https://vitalik.eth.limo/general/2024/03/29/memecoins.html


Finland does not use BankGiro - This should read Sweden?

Finland ---> Sweden
In addition to the generated invoice form, Giro money transfer slips can be generated as follows:
For the legal entity that uses the country/region context for Finland, and that has at least one bank account that is marked as Giro account and Bank bar code.
For an invoice that is marked as required for the Finnish associated payment attachment.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d35a48a9-b24d-8572-ca98-6a7ccbb01f57
Version Independent ID: 7cee0a99-7281-6030-90b3-8ace2667709a
Content: Generate printable FTI forms - Finance & Operations | Dynamics 365 | #MSDyn365FO
Content Source: articles/dev-itpro/analytics/er-generate-printable-fti-forms.md
Service: dynamics-ax-platform
Product: ****
Technology: ****
GitHub Login: @NickSelin
Microsoft Alias: nselin

The possibility to print out Giro payment slips along with customer invoices for Finland was and is still supported in the application as the controlled by parameters option.
Please, refer to the "Payment slip report for Europe" document https://docs.microsoft.com/en-us/dynamics365/unified-operations/financials/localizations/emea-eur-payment-slip-report-giro for more details.


Can not access sub organization when being owner of organization

When another owner of a organization creates a suborganization.
I can not access this organization altough I am owner of the parent organization.
UI shows login screen (which probably shoudl be a screen informing me that I dont have access)

Description of how it should work:
https://gig.gitbooks.io/itsyouonline/content/organizations/organizationownership.html

https://github.com/itsyouonline/identityserver/commit/d8105120573e6e6d4531d31752a9993bcb0b4005
Deployed 0.9-beta-6.0-28-gd810512 to staging


Checking the annotated audio waveform

I am performing audio data labeling task for Speaker Diarization (who spoke when) where the annotation includes labeling the speaker corresponding to a particular segment of audio.

We are following maker and checker concept for data annotation. Somebody has already annotated the data, thus I want to upload both audio waveform and annotation file (.csv) simultaneously in order to perform the labeling check operation.
Is it possible in Label Studio to upload the files mentioned above and obtain the annotated regions over waveform for checking and editing purposes? Once done I will push the changes to PostgreSQL for further downstream ops.
Kindly guide me on how can I achieve the objective.
PS: If some other format for annotated information is required then I will convert it to the required one.

Seems like you need to use pre-annotations:
https://labelstud.io/guide/predictions.html#Format-pre-annotations-for-Label-Studio


fix: improve error handling for controllers

Related issues

Closes #82

Summary
I have updated the error handling to implement error.message as discussed. However, I've encountered three types of test failures:

Formatting Issue:

Test Expectation: "message": "An unexpected error occurred"
Current Response: "message": "Unexpected error"
Observation: The response is correct but does not match the expected format. Adjusting this would require changes beyond the three files specified. Should we create a new issue for this or update it here?

   Test fails due to incorrect formatting

Precision Issue:

Test Expectation: "message": "An unexpected error occurred"
Current Response: Error message is correct, but the test expects a more specific message. This may be due to previous tests being less flexible. Should we update the test to match the current implementation?

   Test fails due to specificity

Vague Error Message:

Test Expectation: "message": "An unexpected error occurred"
Current Response: "message": "Something went wrong"
Observation: The response is too vague. Updating this to match the test expectation would require changes outside of the current scope. Should we address this in a separate issue?

   Test fails due to vague error message

Conclusion
I’ve tried to address the issues but encountered several test failures due to differing expectations. I’m seeking feedback on whether to update the tests or adjust the implementation. Additionally, please guide me if there are other files or areas that you would like me to modify to resolve these issues. Your advice on the best approach to ensure alignment with expected outcomes without impacting existing functionality would be greatly appreciated.

@oscarArismendi If you're able to modify the test cases, that would be great. Otherwise, we'll create a separate issue for it and handle the test case adjustments there.

Hey @mrrishimeena,
I’ll work on fixing the test cases then. I’ll update them in this PR. If there’s anything specific I should keep in mind, just let me know!

I have refactored the tests to the best of my ability, ensuring they align with the current logic and error handling. However, I’m open to any suggestions or further improvements you may see fit.
Additionally, I’ve included an image below showing that all tests are passing:

@oscarArismendi Thanks, Let me review it, and then I will merge it.

@oscarArismendi Your approach is good, but there’s one issue: what if the error object doesn’t have a message property?
const error = { /* no message property */ };
const message = error ? error.message : 'An unexpected error occurred';
console.log(message); // Output: undefined

Mmmm I get it, don't worry I will fix it

@mrrishimeena The changes are all set! If you have any other suggestions or requests, just let me know!

@oscarArismendi Everything looks good.

@SaiKumar2121 The error handling message has been fixed by @oscarArismendi. Kindly proceed with the final testing before publishing it to NPM.


feat(tutorial): complete step 2 boeblingen

Closes #
{{short description}}
Changelog
New

{{new thing}}

Changed

{{change thing}}

Removed

{{removed thing}}

@toeikmei Almost there!
There are small differences with the preview from the tutorial: https://react-step-3--carbon-tutorial.netlify.com/#/. Please take a look at the footer.

@ZrianinaMariia Fixed the footer now, I also noticed that with carbon-components 10.3.* the mixin carbon--font-weight seems to be missing or different.

@toeikmei looks great 🎉! I've recorded your completion of step 2.


Get User model from settings.AUTH_USER_MODEL

Get User model from settings.AUTH_USER_MODEL

@mpyatishev could you please remove User assignment and use it as param like field = FK(settings.AUTH_USER_MODEL) or use User = get_user_model()
https://docs.djangoproject.com/en/1.8/topics/auth/customizing/#django.contrib.auth.get_user_model
User should be a class, not a string.

Сначала так и собирался сделать, но, видимо, забыл.

Merged and released v.0.0.34


SpecResults report with Parallel Tests

Hello,
I'm using the SpecResults to generate a report for my tests and, as the documentation explains, I added the creation of the report in the BeforeTestRun. The thing is, when I added the "[assembly: Parallelizable(ParallelScope.Fixtures)]" to my AssemblyInfo.cs, the test stopped work, with the following error:

------ Run test started ------
NUnit Adapter <IP_ADDRESS>: Test execution started
Running selected tests in D:\Documents\Git\TestAutomationFramework\Fourth.Automation.Framework.Functional\bin\Chrome\Fourth.Automation.Framework.Functional.dll
NUnit3TestExecutor converted 2 of 2 NUnit test cases
TearDown failed for test fixture Fourth.Automation.Framework.Functional.Features.SupportFeature
TechTalk.SpecFlow.SpecFlowException : The FeatureContext.Current static accessor cannot be used in multi-threaded execution. Try injecting the feature context to the binding class. See http://go.specflow.org/doc-multithreaded for details.
TearDown : System.NullReferenceException : Object reference not set to an instance of an object.
at TechTalk.SpecFlow.FeatureContext.get_Current()
at SpecResults.Reporters.BeforeFeature()
at lambda_method(Closure , IContextManager )
at TechTalk.SpecFlow.Bindings.BindingInvoker.InvokeBinding(IBinding binding, IContextManager contextManager, Object[] arguments, ITestTracer testTracer, TimeSpan& duration)
at TechTalk.SpecFlow.Infrastructure.TestExecutionEngine.FireEvents(HookType bindingEvent)
at TechTalk.SpecFlow.Infrastructure.TestExecutionEngine.OnFeatureStart(FeatureInfo featureInfo)
at TechTalk.SpecFlow.TestRunner.OnFeatureStart(FeatureInfo featureInfo)
at Fourth.Automation.Framework.Functional.Features.SupportFeature.FeatureSetup()
--TearDown
at SpecResults.Reporters.AfterFeature()
at lambda_method(Closure , IContextManager )
at TechTalk.SpecFlow.Bindings.BindingInvoker.InvokeBinding(IBinding binding, IContextManager contextManager, Object[] arguments, ITestTracer testTracer, TimeSpan& duration)
at TechTalk.SpecFlow.Infrastructure.TestExecutionEngine.FireEvents(HookType bindingEvent)
at TechTalk.SpecFlow.Infrastructure.TestExecutionEngine.OnFeatureEnd()
at TechTalk.SpecFlow.TestRunner.OnFeatureEnd()
at Fourth.Automation.Framework.Functional.Features.SupportFeature.FeatureTearDown()
TearDown failed for test fixture Fourth.Automation.Framework.Functional.Features.LoginFeature
TechTalk.SpecFlow.SpecFlowException : The FeatureContext.Current static accessor cannot be used in multi-threaded execution. Try injecting the feature context to the binding class. See http://go.specflow.org/doc-multithreaded for details.
TearDown : System.NullReferenceException : Object reference not set to an instance of an object.
at TechTalk.SpecFlow.FeatureContext.get_Current()
at SpecResults.Reporters.BeforeFeature()
at lambda_method(Closure , IContextManager )
at TechTalk.SpecFlow.Bindings.BindingInvoker.InvokeBinding(IBinding binding, IContextManager contextManager, Object[] arguments, ITestTracer testTracer, TimeSpan& duration)
at TechTalk.SpecFlow.Infrastructure.TestExecutionEngine.FireEvents(HookType bindingEvent)
at TechTalk.SpecFlow.Infrastructure.TestExecutionEngine.OnFeatureStart(FeatureInfo featureInfo)
at TechTalk.SpecFlow.TestRunner.OnFeatureStart(FeatureInfo featureInfo)
at Fourth.Automation.Framework.Functional.Features.LoginFeature.FeatureSetup()
--TearDown
at SpecResults.Reporters.AfterFeature()
at lambda_method(Closure , IContextManager )
at TechTalk.SpecFlow.Bindings.BindingInvoker.InvokeBinding(IBinding binding, IContextManager contextManager, Object[] arguments, ITestTracer testTracer, TimeSpan& duration)
at TechTalk.SpecFlow.Infrastructure.TestExecutionEngine.FireEvents(HookType bindingEvent)
at TechTalk.SpecFlow.Infrastructure.TestExecutionEngine.OnFeatureEnd()
at TechTalk.SpecFlow.TestRunner.OnFeatureEnd()
at Fourth.Automation.Framework.Functional.Features.LoginFeature.FeatureTearDown()
NUnit Adapter <IP_ADDRESS>: Test execution complete
========== Run test finished: 2 run (0:00:01.3014074) ==========

I know static methods shouldn't be use in parallel tests,  but then how should the report be implemented since the BeforeTestRun has to be static?
(Sorry if here's not the place for questions)
Thanks in advance

any update on this?


Wrong formating in Attributions list

When looking through the Attributions I spotted a misplaced " which results in wrong formatting.

Fixed thank you


feat: developing the API of right homology of short complexes

This PR develops the API of the right homology of short complexes, getting all the dual notions and results that were previously obtained for the left homology.

[x] depends on: #6089
[x] depends on: #6227

bors r+


Port USFM code from Machine up to commit c93f8dc

This is the final PR for catching machine.py up to the USFM changes in Machine (until more USFM changes are added to Machine).

This change is

Codecov Report
Attention: Patch coverage is 83.28488% with 115 lines in your changes missing coverage. Please review.

Project coverage is 87.99%. Comparing base (3912c6a) to head (ff1c067).
Report is 1 commits behind head on main.

Files with missing lines
Patch %
Lines

tests/corpora/test_usfm_manual.py
4.44%
43 Missing :warning:

machine/corpora/text_corpus.py
41.93%
18 Missing :warning:

machine/corpora/alignment_corpus.py
45.00%
11 Missing :warning:

machine/corpora/parallel_text_corpus.py
83.33%
7 Missing :warning:

...chine/corpora/zip_paratext_project_text_updater.py
62.50%
6 Missing :warning:

machine/corpora/dictionary_alignment_corpus.py
66.66%
5 Missing :warning:

...hine/corpora/paratext_project_text_updater_base.py
83.33%
5 Missing :warning:

machine/corpora/dictionary_text_corpus.py
69.23%
4 Missing :warning:

...hine/corpora/paratext_project_terms_parser_base.py
96.42%
4 Missing :warning:

machine/corpora/standard_parallel_text_corpus.py
72.72%
3 Missing :warning:

... and 4 more

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #118      +/-   ##
==========================================
+ Coverage   87.81%   87.99%   +0.17%
==========================================
  Files         249      260      +11
  Lines       15082    15580     +498
==========================================
+ Hits        13245    13709     +464
- Misses       1837     1871      +34

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

machine/corpora/usfm_text_base.py line 53 at r1 (raw file):

                f"{f' in project {self.project}' if self.project else ''}"
                f". Verse: {parser.state.verse_ref}, line: {parser.state.line_number}, "
                f"column: {parser.state.line_number}, error: '{e}'"

See https://github.com/sillsdev/machine/pull/236 - call it "character"

tests/testutils/data/usfm/Tes/41MATTes.SFM line 41 at r1 (raw file):

\v 6 Chapter two, verse \w six|strong="12345" \w*.
\p
\v 6 Bad verse. \x - \xo abc\xt 123\x* and more content.

Does this bring it up to match the tests fully?  Weren't there more changes than this?

tests/testutils/data/usfm/Tes/41MATTes.SFM line 41 at r1 (raw file):
Previously, mshannon-sil wrote…
There aren't any more changes than this that I'm aware of. Although maybe the changes you're thinking of were in my two previous PRs, since I ended up splitting the porting process into 3 chunks so that it would be easier to review.

Ok - I am not reviewing in depth, I am just wanting to make sure that the testing is the same between the two.


not seeing  identity pages/razorpage library when  following example nor in github source

inside Create a Web app with authentication:
Not seeing any of this when following the directions, nor in github...:

not a RCL
none of the referenced Identity/Account areas are created
not  seeing it in github either
thanks a bunch:

The generated project provides ASP.NET Core Identity as a Razor Class Library. The Identity Razor Class Library exposes endpoints with the Identity area. For example:
/Identity/Account/Login
/Identity/Account/Logout
/Identity/Account/Manage

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 94bfd895-d2af-390b-0801-428b36a27ff4
Version Independent ID: 0e0d870e-e49a-e16c-c259-68d58e701b8f
Content: Introduction to Identity on ASP.NET Core
Content Source: aspnetcore/security/authentication/identity.md
Product: aspnet-core
Technology: aspnetcore-security
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

What version?  dotnet --version
Take a closer look.
he Identity Razor Class Library exposes endpoints with the Identity area. For example:
Those are endpoints, not files.

examine the files created with dotnet new webapp --auth Individual -o WebApp1

thanks for the quick response, I was looking for physical files like a Razor page library project and related /Identity/Account/ files and not a reference as the page infers. I tried to look into the link provided for "ASP.NET Core Identity" for more details , but it is linked to this specific page (circular).
FYI, Totally liking the idea of not having to create identity UI, TYVM!
"AddDefaultUI" nice...


Upgrade VC-AuthN to 2.0

Upgrade the existing deployments of VC-AuthN in OCP namespace set e79518.
There are currently two sets of deployments for VC-AuthN:

A "standard" vc-authn deployment
A "revocation" vc-authn deployment (with the -rev suffix)

They will both be replaced by the new 2.0 instance.
Upgrade Path

Deploy VC-AuthN 2.0 in the e79518-dev namespace
Transfer proof-configurations, client configurations and mappers from old instances to the new one (only Keycloak, old standalone app settings are not required)
Update dev realm settings to use the new VC-AuthN instance as IdP
Spin down the existing instances
Test application
Repeat for test, prod

Realms where the VC-AuthN IdP configuration will need to be updated:

https://dev.loginproxy.gov.bc.ca/auth/admin/digitaltrust-citz/console
https://test.loginproxy.gov.bc.ca/auth/admin/digitaltrust-citz/console
https://loginproxy.gov.bc.ca/auth/admin/digitaltrust-citz/console
https://dev.loginproxy.gov.bc.ca/auth/admin/access-to-court-materials-jag/console/#/realms/access-to-court-materials-jag
https://test.loginproxy.gov.bc.ca/auth/admin/access-to-court-materials-jag/console/#/realms/access-to-court-materials-jag
https://dloginproxy.gov.bc.ca/auth/admin/access-to-court-materials-jag/console/#/realms/access-to-court-materials-jag

vc-authn-oidc (v2,0) has been deployed to e79518-dev, e79518-test, e79518-prod;
Configuration of digitaltrust-citz clients has been completed.
Waiting to verify the identity provider mappers prior to updating the access-to-court-materials-jag realms and coordinating with the ACM developers the app updates.

Closing this issue: the initial upgrade work was completed successfully and #118 is now tracking the last batch of changes.


[BUG] If we click on transactions menu and try to switch to any other menu during the loading process, do not work

Is there an existing issue for this?

[X] I have searched the existing issues

Describe the bug
Hi,
If we click on transactions menu and try to switch to any other menu during the loading process, do not work.
The connected sites menu works ok as you can see too on video:
https://github.com/getAlby/lightning-browser-extension/assets/1178856/fb738536-3fc0-4f24-9dcd-421f0cdc97f6
Screenshots [optional]
No response
Steps To Reproduce
1- Go to transactions menu and during the loading process, try to switch to any other menu
Expected behavior
Be able to switch to any other menu during the loading process.
The same way it works with connected sites menu
Alby information
Alby version: 2.01
Device information
No response
Additional context
No response
Are you working on this?
No

Fixed.


Add functionality to merge existing keys into output files

This pull request adds a new feature to the script that handles JSON files. The changes include checking if the output file already exists before writing the processed data. If the output file exists, the script reads the existing data and merges any keys that are not present in the source data. This ensures that the final output file contains both the newly processed data and any previously existing data that does not conflict with the new data.
Also, added sort_keys=True when outputting files. Sorted keys make it easier to compare different versions of the file or to identify differences between files.
Example (screenshot from a past PR attempt in the zh_TW repository):

EDIT: Below is the Python script used to sort the keys:
import json
import os

def process_json_file(file_path):
    with open(file_path, 'r', encoding='utf-8') as file:
        data = json.load(file)

    with open(file_path, 'w', encoding='utf-8') as file:
        json.dump(data, file, indent=2, ensure_ascii=False, sort_keys=True)

def sort_all_json_files_in_repository(root_dir):
    for dirpath, dirnames, filenames in os.walk(root_dir):
        for filename in filenames:
            if filename.endswith('.json'):
                file_path = os.path.join(dirpath, filename)
                process_json_file(file_path)

if __name__ == "__main__":
    repository_path = r'C:\github\stable-diffusion-webui-localization-source'
    sort_all_json_files_in_repository(repository_path)

The original order in JSON is very important due to the way webUI handles translations. Before Automartic1111 optimized the multilingual module, I was powerless to do anything about it.
As far as I understand, when web UI outputs localization.json, it scans the entire DOM once and sequentially puts the contents (beside DOM's structure) into localization.json. This leads to the following problems:

In just two short original sentences, web UI splits them into eight keys. If sorting is applied to the keys, it will cause problems finding the context during translation.
Checking for duplicate keys to update values to avoid difficult-to-read diff problems is something I strongly agree with. However, placing new keys at the bottom of the JSON affects the original order. But if the new value is inserted in its original position, it has a similar effect to completely overwriting it. Moreover, deleted text in the extension does not need to be retained in the translation file.
I am well aware that this has caused great difficulties in managing code changes. I currently do not have a better solution, so if you have any other ideas, please let me know. Thank you!

Thank you for the detailed explanation!
Sorting:
Since it is essential to understand the context of the original text to do an accurate translation, I thought it was customary to translate text found on WebUI by searching for it on Crowdin. However, looking at examples like the sample image, certain situations can be difficult. It is a tricky problem.
Loading Existing Data:
This process aims to protect source texts that only appear in specific contexts. For instance, the source text in the SD body could include the following:
{
    "Time taken:": "Time taken:",
    "Waiting...": "Waiting...",
    "behind": "behind",
    "latest": "latest"
}

The output template won't include these texts until you check for extension updates. If someone re-exports and replaces the template with a new WebUI version, the keys added by extra work will be lost. That's why I believed it was necessary to validate the existing data.
However, I now realize that creating a separate file is a better approach than merging these keys. This way, we can focus on the necessary keys and disregard outdated text.

Loading Existing Data:
This process aims to protect source texts that only appear in specific contexts. For instance, the source text in the SD body could include the following:
{
    "Time taken:": "Time taken:",
    "Waiting...": "Waiting...",
    "behind": "behind",
    "latest": "latest"
}

I believe this problem should be documented clearly and monitored manually. Until the multilingual module is improved, it cannot be automated.

I believe this problem should be documented clearly and monitored manually. Until the multilingual module is improved, it cannot be automated.

I agree. Let's work out the details on that.
Thank you for the valuable feedback and detailed explanation regarding the pull request. Based on our discussion, I understand that the original order of keys in the JSON file is crucial for context, and sorting the keys might cause translation issues. I also appreciate your input on handling new keys and the importance of manually monitoring source texts that only appear in specific contexts.
Considering the points we've discussed, I will not proceed with the current pull request. Instead, I plan to create an Issue where we can further discuss how to manage special texts.


Fix possible ANR in billing client

Task/Issue URL: https://app.asana.com/0/488551667048375/1207003406045665/f
Description
See Asana task
Steps to test this PR
Smoke test PPro

#4399  👈
develop

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @aitorvs and the rest of your teammates on  Graphite


Feature/ingress annotations

Description
Safety checklist

[X] This change is backwards compatible and safe to apply by existing users
[X] This change will NOT lead to data loss
[X] This change will NOT lead to downtime who already has an env/service setup

How has this change been tested, beside unit tests?
Manual testing

Thanks @rabbitfang for the useful suggestions.


Fix Dnsmasq task

Fixes the issues that I highlighted in #469. This PR has been tested and is actively deployed.
I'd like a better solution to just flat-out ripping out the FreeBSD check for creating the Dnsmasq configuration though. Would love suggestions!

@polikarpoff @hatf0 please work out what to do with DNSMasq


Audio Title Not Appearing

Current Behavior:
Audio title isn't shown in default state regardless of explicitly setting it:
<media-player
    v-if="src"
    class="player"
    view-type="audio"
    :title="title ?? 'Audio File'" // explicitly passing variable with fallback
    :src="src"
    crossOrigin
    playsInline
    @can-play="onCanPlay"
    ref="$player"
  >
    <media-provider></media-provider>
    <media-title></media-title>
    <media-audio-layout color-scheme="dark" />
  </media-player>

I've also noticed the examples provided are also not showing the titles either: https://stackblitz.com/edit/vidstack-examples-vqc1yj?file=src%2FPlayer.vue&showSidebar=1&title=Vidstack Player - Vue (Default Layout)
Expected Behavior:
For audio title to be shown, such as on the older documentation site (https://old.vidstack.io/):

Steps To Reproduce:
Reference example provided in documentation: https://stackblitz.com/edit/vidstack-examples-1kro9l?file=src%2Fmain.ts&showSidebar=1&title=Vidstack Player - Vue (Default Layout)
Environment:

Framework: Vue 3
Meta Framework: Nuxt 3
Node: 18.13.0
Browser: Chromium Engine Version 127.0.6533.100

In my testing it's working as expected. The examples are outdated and need to be updated. Make sure on your end you're on the latest version and you can also prefer setting the prop rather than attribute so Nuxt doesn't complain .title="title".

Thanks for the response @mihar-22. I've updated to the latest version and have also tried setting the prop instead of the attribute as you mentioned, but have the same issue.
I've actually spotted what's happening. For performance reasons, I'm rendering the player conditionally based on some user interaction (turns out loading ~250 audio files/player components takes a while to load). It appears whenever I remove the conditional logic, the titles appear correctly. Would you happen to have a recommended solution for how to conditionally render the player?
I'm rendering the component which has the player with a v-if like such:
<EpisodePlayer
  v-if="episode.initPlayer" // conditional logic happening here
  :key="episode.title"
  :src="episode?.enclosure.url"
  :title="episode.title"
/>

And within the EpisodePlayer component, I'm rendering the component like my example in the initial post.
I can even verify the title prop from the parent component is valid within the onMount lifecycle hook inside the EpisodePlayer component, but yet the player doesn't seem to pick it up:

interface MediaPlayerProps {
  title: string;
  src: string;
  pausePlayer: boolean;
}

const props = defineProps<MediaPlayerProps>();

onMounted(() => {
  console.log("Player mounted:", props.title); // logs the expected title, but is empty within the component
});

Every other aspect of the player works as expected, only the title doesn't appear. Any suggestions appreciated 🙏

Thanks for the clarification, found the bug. Pushing out fix now in 1.12.8@next :)

That fixed it! Thanks for the update, and I look forward to using vidstack for future projects!


Make install.sh more robust to not being root

Instead of just failing if sudo is not granted, the install script now tries to:

move ./spf to ~/.local/bin (which is the correct path for user executables according to the XDG Base Directory Spec)
Make that directory if it doesn't exist
Checks if this dir is in the path, and if not export path to include it (and add to bashrc)
improves error messages accordingly.

Here is an example of how it looks with these changes: (ignore the actual colors, my terminal's color profile is different)

One question I had is should I also mention that ~/.local/bin has been added to ~/.bashrc (so that users of other shells i.e. fish/zsh/xonsh etc) would be able to add it to their configs themselves? I am in favour of adding it.
Alternatively, we can try detecting shell and run respective command but not even fzf takes that approach - it asks you to run the right file yourself (out of some provided scripts)

thank you for your contribution, this look good to me!

Thanks!
What do you think about the question I wrote about users of shells other than bash?

I apologize for missing that part of your message. :(
Regarding your question about users of shells other than bash, I believe automating the detection of the user's shell is a great idea. If there's a straightforward way to achieve this in a shell script without requiring additional user input, that would be ideal. The goal of the install script should be to minimize the need for users to manually configure settings or enter additional information.

No worries! :)
I agree, it should be automated. We could use a case statement on the env variable SHELL, which works reliably. I'll push a change with this.


Bring more visibility to sbt-robovm by pull request to sbt website

I believe that by providing pull request to https://github.com/sbt/website this project can be included in list of community SBT plugins, it should bring more visibility, because there is no iOS development plugin there, and two Android plugins on https://github.com/sbt/website/blob/HEAD/src/reference/01-General-Info/02-Community-Plugins.md#android-plugin

It looks like awesome-scala has been pretty active lately, but it seems like we might need to actually submit a PR instead of just an issue.

Will be fixed in #37


Routes do not have ID's

rio version v0.1.1-rc2 (e423eda3)

Should be fixed in v0.2.0. Please reopen the issue if it doesn't fix your issue.


Minecraft Server component does not work with SRV records.

The problem
When using the config flow to define a new Minecraft Server, the component checks if it s a valid IP address, as here However, minecraft servers can also be connected to via SRV records, which do not point to an IP address on its own. Because of this, SRV based minecraft servers cannot be connected to.
Environment

Home Assistant release with the issue: 106.0
Last working Home Assistant release (if known): N/A
Operating environment (Hass.io/Docker/Windows/etc.): Docker
Integration causing this issue: Minecraft Server
Link to integration documentation on our website: https://www.home-assistant.io/integrations/minecraft_server/

@Adam-Ant Thanks for sharing the link about TRV records. I didn't know that Minecraft supports it. I'll have a look at this feature request. But in the meantime you should be able to connect with host and port, right?

The validation also does not accept IP address directly, which seems very odd. Most people would expect to be able to put in an FQDN (hostname) or an IP.

The validation also does not accept an IP address directly, which seems very odd. Most people would expect to be able to put in an FQDN (hostname) or an IP.

IPv4 and IPv6 addresses should be supported. At least with my server it works either with the IPv4 address or with the dynamic DNS URL. The server needs to be turned on and has to be at least version 1.7. If it still doesn‘t work please create a new issue, as this one is a feature request for SEV record support. Thanks!

@elmurato I tested different interfaces and I suspect the issue with  SRV records and my issue is that line 59 stops the validation logic if there is an IP but no MAC resolved for the minecraft server, the else statement will never be reached. Only a server in the SAME subnet as the HA server well ever return a MAC address from the getmac.get_mac_address .
I suspect line 59
if ip_address is not None and mac_address is None:
should read
if ip_address is  None and mac_address is None:
https://github.com/home-assistant/home-assistant/blob/df04fe32586d446e645819355c40df55e648f9c4/homeassistant/components/minecraft_server/config_flow.py#L58-L74

@bagobones No, this was done intentionally. If the user enters an IP address, the integration must get the MAC address, as this is required for the unique ID. IP addresses cannot be used for unique IDs, because they can change (actually this was a review finding which I fixed later).
I was not aware that getting the MAC address is not working if the server is in another subnet (not tested by me). But this would be then a limitation. You should be able to enter the local hostname or dynamic DNS URL together with the port though. In that case the MAC address is not required and not checked.
The SRV record support is another story, it‘s simply missing. If I understood correctly the config flow has to extract the URL and the port from the SRV record.

@Adam-Ant I found a way to extract host and port from a SRV record and it looks like working in my dev setup.
But I have one question: Can I expect that the port never changes in a SRV record? Or do I have to extract SRV record data dynamically everytime the integration tries to connect to the server?

As the IP and port both come from the same DNS record, I would consider the port as dynamic as the IP myself.

As the IP and port both come from the same DNS record, I would consider the port as dynamic as the IP myself.

Thanks, then I need to adapt the integration setup, too, and not only the config flow.

I do wonder if this would be a good opportunity to move away from using the MAC as a unique identifier. SRV record or not, at the moment any server outside the default gateway of the HA host won't work, SRV record or not. Similarly - two servers on the same IP, but different ports, would collide when using the MAC. Perhaps a hash of ip, port and server name would work better.?
---- On Fri, 28 Feb 2020 21:14:57 +0000<EMAIL_ADDRESS>wrote ----
As the IP and port both come from the same DNS record, I would consider the port as dynamic as the IP myself.
Thanks, then I need to adapt the integration setup, too, and not only the config flow.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

two servers on the same IP, but different ports, would collide when using the MAC

Correct and actually something I do with my setup via docker, each docker has the same host name / IP as the docker host but runs on a different port.
I would take the simple approach for the unique ID and ask the user to NAME the server, and do a check if there is already a server named that.. Most users will only have one server, but those with more advanced configs will want them to have separate names if they have more than one anyway.
This approach will not care if the user put in an IP, host and port, or domain and resolved a SRV record.

Similarly - two servers on the same IP, but different ports, would collide when using the MAC.

That's why the unique ID is either <host>-<port> or <mac_address>-<port>. So same IP with different ports should work. But in case of a SRV record, the port can be dynamic, as you said. That's why I have to think about the unique ID with SRV records (probably only the SRV address, as this is fixed).
I would try not to add one more user configuration in the config flow. If possible most of the stuff should be handled automatically.

@Adam-Ant Are you familiar with how custom_components work? If so, could you please test if this branch works now for you? My local tests were fine, but I would like to get your confirmation before I open the pull request. Thanks!
https://github.com/elmurato/home-assistant/tree/minecraft-server-srv-record/homeassistant/components/minecraft_server

No worries, I'll give it a test when I'm back at my computer tonight - hopefully around 9pm gmt

Hi - I am also getting the MAC address error, the server is on a different subnet and I am trying to connect using the IP. I have tested custom components before, but not sure how I can test this update, presuming it will now work without being able to get the MAC. I could manually input the MAC if there was somewhere to do so... Just a thought. Thanks.

Hi - I am also getting the MAC address error, the server is on a different sub-net and I am trying to connect using the IP. I have tested custom components before, but not sure how I can test this update, presuming it will now work without being able to get the MAC. I could manually input the MAC if there was somewhere to do so... Just a thought. Thanks.

As I said already above, using the local IP address requires the MAC address to be readable. But with a different sub-net this seams not to work. As an alternative you should be able to enter the local host name (like mcserver.local). In my network I can for example use mine-os.fritz.box. Using the host name doesn't require the MAC address, that's why it works that way.

Just tested the branch, and it is working great for me, with a few exceptions.
The logs output, as below, have a few errors and warnings in them, though I'm unsure if this is related to the SRV change.
2020-02-29 23:27:43 INFO (MainThread) [homeassistant.setup] Setting up minecraft_server
2020-02-29 23:27:43 INFO (MainThread) [homeassistant.setup] Setup of domain minecraft_server took 0.0 seconds.
2020-02-29 23:27:43 INFO (MainThread) [custom_components.minecraft_server] Connection to server (re-)established
2020-02-29 23:27:43 WARNING (MainThread) [custom_components.minecraft_server] Updating the server properties failed - OSError: Server did not respond with any information!
2020-02-29 23:27:43 INFO (MainThread) [homeassistant.components.binary_sensor] Setting up binary_sensor.minecraft_server
2020-02-29 23:27:43 ERROR (MainThread) [homeassistant.setup] Unable to prepare setup for platform minecraft_server.sensor: Platform not found (cannot import name 'TIME_MILLISECONDS' from 'homeassistant.const' (/usr/src/homeassistant/homeassistant/const.py)).
2020-02-29 23:27:43 INFO (MainThread) [homeassistant.helpers.entity_registry] Registered new binary_sensor.minecraft_server entity: binary_sensor.minecraft_server_status

The other issue is a bit of an edge case - a domain can have an A/CNAME record and an SRV record at the same time. For example, the domain hatest.adam-ant.co.uk (which is set up for this scenario with a running 2 minecraft servers - feel free to use it for testing!) has an SRV record pointing to port 32123, and another server running on 32321. After adding the SRV record server via the integration, adding the other valid server will not work, as HA complains that the host is already configured.

The logs output, as below, have a few errors and warnings in them, though I'm unsure if this is related to the SRV change.

Thanks so much for testing! I think the error with TIME_MILLISECONDS is due to this pull request:

Time units have been standardized throughout all integrations.

These changes are available in my DEV system (0.107.0.dev0), but not in your productive system.
Here are my logs:
2020-03-01 09:59:59 DEBUG (MainThread) [homeassistant.components.minecraft_server] 'hatest.adam-ant.co.uk' is a valid Minecraft SRV record (host=ts3host.cwgaming.co.uk, port=32123)
2020-03-01 09:59:59 DEBUG (MainThread) [homeassistant.components.minecraft_server] Creating server instance for 'Minecraft Server' (host='hatest.adam-ant.co.uk', port=25565)
2020-03-01 09:59:59 DEBUG (MainThread) [homeassistant.components.minecraft_server] 'hatest.adam-ant.co.uk' is a valid Minecraft SRV record (host=ts3host.cwgaming.co.uk, port=32123)
2020-03-01 09:59:59 INFO (MainThread) [homeassistant.components.minecraft_server] Connection to server (re-)established
2020-03-01 10:00:00 INFO (MainThread) [homeassistant.components.binary_sensor] Setting up binary_sensor.minecraft_server
2020-03-01 10:00:00 INFO (MainThread) [homeassistant.components.sensor] Setting up sensor.minecraft_server
2020-03-01 10:00:00 INFO (MainThread) [homeassistant.helpers.entity_registry] Registered new binary_sensor.minecraft_server entity: binary_sensor.minecraft_server_status_5
2020-03-01 10:00:00 INFO (MainThread) [homeassistant.helpers.entity_registry] Registered new sensor.minecraft_server entity: sensor.minecraft_server_players_max_5
2020-03-01 10:00:00 INFO (MainThread) [homeassistant.helpers.entity_registry] Registered new sensor.minecraft_server entity: sensor.minecraft_server_latency_time_5
2020-03-01 10:00:00 INFO (MainThread) [homeassistant.helpers.entity_registry] Registered new sensor.minecraft_server entity: sensor.minecraft_server_protocol_version_5
2020-03-01 10:00:00 INFO (MainThread) [homeassistant.helpers.entity_registry] Registered new sensor.minecraft_server entity: sensor.minecraft_server_version_5
2020-03-01 10:00:00 INFO (MainThread) [homeassistant.helpers.entity_registry] Registered new sensor.minecraft_server entity: sensor.minecraft_server_players_online_5

So I would open the pull request then. But I think this one will go earliest to 0.107.

The other issue is a bit of an edge case - a domain can have an A/CNAME record and an SRV record at the same time. For example, the domain hatest.adam-ant.co.uk (which is set up for this scenario with a running 2 minecraft servers - feel free to use it for testing!) has an SRV record pointing to port 32123, and another server running on 32321. After adding the SRV record server via the integration, adding the other valid server will not work, as HA complains that the host is already configured.

Hmm... I didn't know that multiple servers are possible with the same domain. How does this even work in Minecraft? How do you choose in the game which server to pick (SRV or A/CNAME) with the same domain? Anyway this would require more changes and probably also a breaking change. Couldn't you just use different domains for the two servers? Like:

hatest1.adam-ant.co.uk
hatest2.adam-ant.co.uk

How does this even work in Minecraft? How do you choose in the game which server to pick (SRV or A/CNAME) with the same domain?

It follows a simple priority list - explicitly defined port on the end of the address, SRV record, default port (25565). That said, I do agree it's a change not worth the dev time, but I thought I'd make you aware nevertheless.

As I said already above, using the local IP address requires the MAC address to be readable. But with a different sub-net this seams not to work. As an alternative you should be able to enter the local host name (like mcserver.local). In my network I can for example use mine-os.fritz.box. Using the host name doesn't require the MAC address, that's why it works that way.

Thanks for the quick reply - but I have tried mchostname.local and it isn't liking that either (resolves fine). FWIW I am not using the default query port, so manually changing that.

Thanks for the quick reply - but I have tried mchostname.local and it isn't liking that either (resolves fine). FWIW I am not using the default query port, so manually changing that.

As this is another issue, can you please create a new one? Then we can have a look at it there. Thanks.


Installation didn't work (vim)

I've been trying to install merlin using opam but every time I run into the same error:
"test.ml" [New File]
Error detected while processing function merlin#LoadProject:
line    2:
Traceback (most recent call last):
File "", line 1, in
File "/home/wooshmi/.opam/system/share/ocamlmerlin/vim/autoload/merlin.py", l
ine 544, in load_project
command = [vim.eval("merlin#FindOcamlMerlin()"), "-project-find", directory
]
vim.error: Vim(echoerr):ocamlmerlin not found!
Error detected while processing function 11_LoadFTPlugin:
line   17:
E170: Missing :endfor
I have tried everything - reinstalling vim, clearing my .vimrc, deleting all vim extension. I've seen that I'm not the only one that ran into this error, but I couldn't find a solution...

Note to others, I can't seem to get merlin to work while I'm logged into the fish shell (despite adding it to my path) it does work when I log in using zsh though.

So I had this issue when using MacVim, while my login shell was zsh. Turns-out .zshrc is only read by the interractive zsh, and .zprofile is read otherwise. I symlinked the former to the later and now all is good in the hood.

@ibnfirnas Your solution finally works for me.


Typo in 11. Scoping Subcomponents

original:
that'll make that typehave a unique instance in the Component.
should be:
that'll make that type have a unique instance in the Component.

I was going to report that too but find your issue!

I was going to report that too but find your issue!


Create code snippet for bigtable_delete_all_cells

Fixes #2302

This change is

@coryan
I think the nodejs code deletes all the cells in a single row. And is it possible to take the row key as a parameter?
Yes, it  will take the row key as parameter.


Update publication.ptx to add closing slash in webwork server

I noticed this was missing the closing slash and added it.

Thanks for the heads up.  This will need to be updated in pretext-cli's repo, since that is used to generate the template.
If you would like the "credit" for the fix, you can do a PR for here: https://github.com/PreTeXtBook/pretext-cli/blob/892a298e228485ebd55eda83c16251a1236cde41/templates/demo/publication/publication.ptx#L127.  Otherwise, I'm happy to fix that tomorrow.


More than 5 captions per image for COCO data

I thought COCO dataset has 5 captions per image.
But *.json files show that some images have more than 5 captions. Is this normal?

To reproduce
import json
with open('data/lxmert/mscoco_minival.json') as f:
    data = json.load(f)
for datum in data:
    coco_sents = datum['sentf']['mscoco']
    if len(coco_sents) > 5:
        print(datum['img_id'])
        print(coco_sents)

Seems like some original COCO images have more than 5 captions. Closing the issue.


Adds unique ID to Roku for entity registry inclusion

Description:
Adds a unique ID to the Roku media player so it can be included in the entity registry – so long, media_player.roku_yp012n976523!
Related issue (if applicable): N/A
Pull request in home-assistant.github.io with documentation (if applicable): N/A
Example entry for configuration.yaml (if applicable):
media_player:
  - platform: roku
    host: <IP_ADDRESS>

Checklist:

[x] The code change is tested and works locally.
[x] Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:
~- [ ] Documentation added/updated in home-assistant.github.io~
If the code communicates with devices, web services, or third-party tools:
~- [ ] New dependencies have been added to the REQUIREMENTS variable (example).~
~- [ ] New dependencies are only imported inside functions that use them (example).~
~- [ ] New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.~
~- [ ] New files were added to .coveragerc.~

@balloob, do we realy need this name prefix?

No, platform is already part of the registry entry and check:
https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/helpers/entity_registry.py#L103

? Without a property, I don't think so

Right there in the docs too entity_registry_index.html#unique-id-requirements


Add package docs file

Description

This is a follow up to https://github.com/gruntwork-io/go-commons/pull/68 to add package docs.
TODOs
Please ensure all of these TODOs are completed before asking for a review.

[x] Ensure the branch is named correctly with the issue number. e.g: feature/new-vpc-endpoints-955 or bug/missing-count-param-434.
[x] Update the docs.
[x] Keep the changes backward compatible where possible.
[x] Run the pre-commit checks successfully.
[x] Run the relevant tests successfully.
[x] Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.

Thanks for review! Merging now.


Tidy up codebase by fixing make lint reports

As of posting this issue, make lint returns this report:
# golint
resource/group/group_default.go:26:1: comment on exported method System.AddGroup should be of the form "AddGroup ..."
resource/group/group_default.go:32:1: comment on exported method System.DelGroup should be of the form "DelGroup ..."
resource/group/group_default.go:38:1: comment on exported method System.LookupGroup should be of the form "LookupGroup ..."
resource/group/group_default.go:44:1: comment on exported method System.LookupGroupID should be of the form "LookupGroupID ..."
resource/group/group_default.go:26:1: comment on exported method System.AddGroup should be of the form "AddGroup ..."
resource/group/group_default.go:32:1: comment on exported method System.DelGroup should be of the form "DelGroup ..."
resource/group/group_default.go:38:1: comment on exported method System.LookupGroup should be of the form "LookupGroup ..."
resource/group/group_default.go:44:1: comment on exported method System.LookupGroupID should be of the form "LookupGroupID ..."
./rpc/jwt.go:119:1: exported method JWTAuth.Protect should have comment or be unexported
./rpc/pb/mocks/Grapher_GraphServer.go:11:6: don't use underscores in Go names; type Grapher_GraphServer should be GrapherGraphServer
# go tool vet
cmd/apply.go:60: declaration of "err" shadows declaration at cmd/apply.go:55
cmd/apply.go:139: declaration of "err" shadows declaration at cmd/apply.go:88
cmd/graph.go:67: declaration of "err" shadows declaration at cmd/graph.go:62
cmd/healthcheck.go:61: declaration of "err" shadows declaration at cmd/healthcheck.go:56
cmd/key.go:80: declaration of "err" shadows declaration at cmd/key.go:64
cmd/plan.go:60: declaration of "err" shadows declaration at cmd/plan.go:55
cmd/plan.go:139: declaration of "err" shadows declaration at cmd/plan.go:88
keystore/keystore_test.go:39: declaration of "err" shadows declaration at keystore/keystore_test.go:26
keystore/keystore_test.go:42: declaration of "err" shadows declaration at keystore/keystore_test.go:26
load/nodes.go:74: declaration of "err" shadows declaration at load/nodes.go:59
make: *** [lint] Error 1

This is a small collection of easy changes, and perfect for a new contributor.

@Zacho2 fixed this with PR 350. Thanks again!


Improve keyboard behavior

This PR makes a couple keyboard/mouse behavior changes:

Focuses the search bar using L keybinding
Double clicking a search result functions equivalently to pushing the first button (i.e. running the first search action). We should consider hardcoding it to a particular search action name.
Using the up/down arrow keys while focused on the widget allows the user to traverse the search results. Hitting enter on any search result functions equivalently to double clicking the result.

TODO: Inserting time series data seems to break the L keybinding. Need to investigate more. Can you replicate @ctrueden @hinerm?
Closes #37

L works to focus the search bar.

For some reason this is no longer working for me, and I don't yet understand why :frowning:

...but does not move the keyboard focus down into the widget to start filling things out.

I started work on this, and it seems to be close. However, I noticed that for preallocated outputs (e.g. Ops), the first keyboardable widget is actually the "New" button :frowning:
I should probably file an issue for it, though, as it is not a problem with this functionality.

Pressing enter while one of the widget's components is focused, or while the Run button is focused, does not execute the module.

I feel like this would be better fixed in magicgui. What do you think @tlambert03?

I recognize that these last two problems are not related to keyboard shortcuts, but I included them because it came up as part of my testing of this PR. Feel free to split them to separate issues though.

I'm going to make 3 issues!

I feel like this would be better fixed in magicgui. What do you think @tlambert03?

sure, make an issue over there with a simple button, explain how you're focusing on it, and what should happern

I feel like this would be better fixed in magicgui. What do you think @tlambert03?

sure, make an issue over there with a simple button, explain how you're focusing on it, and what should happern

Thanks @tlambert03, just did.
Any other features you'd like to see added @ctrueden?

This PR is currently waiting on two things.

The decision of whether Run or Widget should be triggered when double-clicking a search result. I left it as Widget. Do you have an opinion @ctrueden? I think Run would be nicer, but I can't think of a good way to test it.
I'd like to be able set the focus of a "focusable" widget in the resulting Magicgui widget in a more reliable way. See this zulip thread. I'd also like to test this behavior.

Do you have an opinion @ctrueden? I think Run would be nicer

I agree, Run would be better, and I don't want lack of testability to stop us from doing the nicer thing.
Why not make shift+enter do the Widget though? Then users can choose quickly.

Why not make shift+enter do the Widget though? Then users can choose quickly.

Yup, now shift+double-click and shift+enter do Widget, while double-click and enter do run!

Codecov Report

Merging #70 (221f8c9) into main (84bef05) will increase coverage by 0.65%.
The diff coverage is 84.71%.

@@            Coverage Diff             @@
##             main      #70      +/-   ##
==========================================
+ Coverage   92.51%   93.17%   +0.65%
==========================================
  Files          15       15
  Lines        2139     2255     +116
==========================================
+ Hits         1979     2101     +122
+ Misses        160      154       -6

Impacted Files
Coverage Δ

src/napari_imagej/widget.py
85.09% <72.94%> (+10.73%)
:arrow_up:

tests/test_ImageJWidget.py
98.34% <98.33%> (-1.66%)
:arrow_down:

src/napari_imagej/_module_utils.py
89.71% <100.00%> (+0.14%)
:arrow_up:

tests/test_module_utils.py
98.41% <100.00%> (+0.02%)
:arrow_up:

src/napari_imagej/_flow_layout.py
32.81% <0.00%> (-4.69%)
:arrow_down:

src/napari_imagej/setup_imagej.py
97.84% <0.00%> (+0.86%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84bef05...221f8c9. Read the comment docs.


Move storage integrations to be configured as services (PP-95)

Description

Add a dependency injection container, that contains services used by our controllers.
Create framework for adding new services, and configuring them via environment variables, validated via pydantic.
Remove the existing mirror integration code, and replace it with a new storage service.

Modify the marc exporter and s3 analytics provider to use the new storage service.
Add the new environment variables for the storage service to README.

Notes 🚨: (these are now all resolved)

The PR this is based on https://github.com/ThePalaceProject/circulation/pull/1358 should get merged before this one does.
This PR is dependant on an admin UI PR, that removes the admin UI side functionality for configuring storage integrations:  https://github.com/ThePalaceProject/circulation-admin/pull/87
Before this is merged we will need to update our hosting-playbook to deploy the relevant environment variables our to our hosting environments. PR for this up here: https://github.com/ThePalaceProject/hosting-playbook/pull/489

Motivation and Context

JIRA: PP-95
The motivation here is to allow services that don't need to be configured in the admin UI to be configured via environment variables, and instantiated via a dependency injection container, so we are able to easily mock the services for testing.
This uses the storage service as a test case for the new services architecture, and implements it as a s3 storage service.

How Has This Been Tested?
Notes: The docker-compose.yml included in the repo was updated with the new environment variables, so that environment can be used for integration testing.

Manually tested in a docker-compose environment.

Imported the Palace Bookshelf collection.
Configured s3 analytics and marc integrations.
Checked out a book.

Made sure analytics json files ended up in minio bucket.

Ran the cache_marc_files script.

Made sure that marc files ended up in the public access bucket.
Made sure links to the files worked at the /marc endpoint.

Ran unit tests locally and in CI.

Checklist

[X] I have updated the documentation accordingly.
[X] All new and existing tests passed.

This should be ready to merge now, once it gets a code review. All the dependant PRs have gone in, and its been rebased against the current main branch.

I started looking at this yesterday and will continue today.

I pushed a few commits resolving code review feedback.

I do have a concern about relying on the Dependency Injector project because it's not clear that it is being maintained (they haven't merged a PR in 9 months).

Its hard to find a dependency injection container for Python. In the past I've found that constructor injection with a dependency injection container to wire up the dependencies is a helpful structure for webapps, and my hope is that we can slowly decouple our services this way.
Despite not having any PRs merged in the last 9 months, the library does have 1 million downloads a month on Pypy making it by far the most popular dependency injection container I've found for Python. It also has well written documentation https://python-dependency-injector.ets-labs.org/ and has been around since 2015.
There is a issue here https://github.com/ets-labs/python-dependency-injector/issues/688 where the maintainer mentions that he considers the library feature complete at this point, but intends to support it to update python versions, dependency versions etc.
If you have a suggestion of a different library, I'm willing to take a look at switching this code. Otherwise the library becoming unsupported is a risk, but IMO the immediate gain of decoupling our services is worth it.

I rebased this with main to resolve the conflicts with https://github.com/ThePalaceProject/circulation/pull/1268. The only changes in the rebase other then imports and poetry are in tests/core/test_marc.py around creating the fake search index for the marc tests, since that changed in #1268.


Changing color with complete example results in JS Error

undefined is not an object (evaluating 'this.$annotator.updateFields')
This is what I get if I want to change the color when using the complete example from the docs in the latest Kirby Version.

For me the same here ...


Use negative difference

To somehow differentiate between jobs #114, I keep the negative difference.

Added colours.

Also I updated category colors to match the seaborn scheme:


How to use with vue-cli

Hello, is it possible to use vuido with vue-cli webpack template? I've run into a couple of issues.
I'm getting this error:  Cannot find module 'vuido-template-compiler',

The standard webpack template has to be slightly changed to work with Vuido. I'm planning to create a new vue-cli template for Vuido.


Feature: In hex view highlight equivalent text

In the hex view highlight also the current equivalent text/ASCII.
PS: Thanks for the great tool 👍

I wanted to do this, need to dig into vim plugin apis a bit more to figure
it out. Took some figuring out to
highlight the hex, used :match, :2match, and :3match to highlight the rows
in the hex, ran out of :Xmatch functions.
On Sun, Aug 7, 2016 at 10:15 PM, vdun<EMAIL_ADDRESS>wrote:

In the hex pane highlight also the current equivalent text/ASCII.
PS: Thanks for the great tool 👍
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/d0c-s4vage/pfp-vim/issues/5, or mute the thread
https://github.com/notifications/unsubscribe-auth/AE2rYjd6JoZqu3iBCJ6pd-oUGsDN4qfGks5qdp9kgaJpZM4JerFA
.

bumping this up, would definitely be useful


Turkish language support added.

@emresasi - Thanks for the contribution.
We are open and welcoming contributors for other language support.


Update Jooby urls in readme and documentation

Jooby maintainer no longer owns jooby.org domain
and the current one is jooby.io. See
https://github.com/jooby-project/jooby/issues/1513 for more details.
Also, link directly to Jooby's pac4j integration
instructions instead of just home page.

Thanks for the fix


Add tracing support via OpenTelemetry

Adds tracing support. SDK instruments the root process, and propagates trace context to the child process. The connector implementation can trace functions as well. grpc calls are traced automatically.
The root process will be named after the connector, e.g. baton-github. The child process service name will have -server appended to the service name.
This also adds a open telemetry stack via docker-compose. This runs an otel collector, prometheus, loki, tempo, and grafana. Currently only tracing is implemented, so prometheus and loki are going unused, but it won't be difficult to add support for those.
TODO

[x] Add readme for docker-compose stack
[ ] Figure out why batch processor causes sigkills
[x] Test service mode

A lot of the tracers are prefixed with baton-sdk/ how would you feel about adding a version number too?


Set default to 0 for undefined time units minutes, seconds and millisec

We can set 0 for undefined time units based on TM definition in DICOM standard http://dicom.nema.org/Dicom/2013/output/chtml/part05/sect_6.2.html.
This PR intends to solve cornerstone issue #245

Coverage remained the same at 51.885% when pulling 7f30e4da3b927f05e30f3c2a4b060588f3b242b5 on ayselafsar:master into 82573d94342e12b4bae4fcd2e93f91bb061474cf on cornerstonejs:master.

I think we may want to push this responsibility onto the consumer rather than into this library. If we set the unspecified values to 0, there's no way for a user to determine whether the values were not set or were set to zero. That may be significant for someone's use case.

Going to close this for now. Feel free to comment if you feel it needs reopening in the future.