Title attribute should never be an empty string

After storing the original title attribute, the title attribute should not be replaced with an empty string, which would result in an accessibility violation on elements, like input, that may use the title for a label. This seems to have been improperly translated from the source material: https://github.com/jaz303/tipsy/blob/master/src/javascripts/jquery.tipsy.js#L94.

Tests failed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: BUSTED
Commit: cf638bd2349c1e945684ad2bc041a0bb1fda25af
Build details: https://travis-ci.org/twbs-savage/bootstrap/builds/114085461
(Please note that this is a fully automated comment.)

Tests passed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: CONFIRMED
Commit: 18f0c772f5cb1ceea716d1836878dcf4f6a98581
Build details: https://travis-ci.org/twbs-savage/bootstrap/builds/114087000
(Please note that this is a fully automated comment.)

Tests passed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: CONFIRMED
Commit: d24890878008ddc6dd2b713e310e544d2932922c
Build details: https://travis-ci.org/twbs-savage/bootstrap/builds/114088655
(Please note that this is a fully automated comment.)

would result in an accessibility violation on elements, like input, that may use the title for a label.

do you have a test case, and an actual combination of browser/assistive technology which is known to cause a problem?
from cursory testing (just using NVDA and JAWS and Firefox), and from looking at the code itself that's generated, everything should actually work fine since despite the title being set to empty, the tooltip itself is referenced with aria-describedby and thus the text which formerly was in the title is announced once the control receives focus.
it may arguably be cleaner though to remove the title attribute altogether, rather than blanking it. @cvrebert thoughts?

(though this is currently tagged/aimed at v3, this could probably be ported to v4)

@patrickhlauke It came to my attention because it was flagged as an issue by an accessibility validation tool, either aXe or HTML_CodeSniffer. Now, in practice it probably wouldn't cause harm because the tooltip is referenced with aria-describedby, but it would be better not to throw false positives. Also, I think the explanation in this case would lie with the developer who originally ported code that removes the title attribute entirely and replaced it with code that adds title=''.

it would be better not to throw false positives

do these tools still flag false positives after your proposed PR? also, it would be good to flag the fact that the tools have false positives to the tools themselves.
as for referring back to the original tipsy, note that the code there has not been touched in 3 1/2 years, and it currently has issues of its own - so it's not a completely reliable source of best practice.

I think the place in the code I've been remediating where validators identified this as an issue was an icon button element that used a title attribute and the bootstrap tooltip class to display the label as a tooltip. I've since refactored to use a span of "hidden accessible" text as the label instead of the title attribute, but found it odd to still find an empty title attribute in the DOM.
I only referred to tipsy because I was doing some forensics to try to understand the rationale for including title="" after caching the existing title in a data attribute. Now it could be that for some performance reason, the person who ported the code chose to change the value of the attribute rather than remove it, but we'll probably never know.
Also, the Tooltip class only adds aria-describedby after showing the tooltip element, so with title="" we have an attribute that could serve as a label for an element with an empty string for a value.

I'm also happy to make the change in the v4 branch.

Also, the Tooltip class only adds aria-describedby after showing the tooltip element, so with title="" we have an attribute that could serve as a label for an element with an empty string for a value.

but with your proposed fix, the title attribute would be removed altogether...so i don't quite follow what the functional difference here would be (an empty string vs no attribute at all)?

@patrickhlauke Would you prefer that had I not wasted your time by identifying this as an accessibility issue, given that there is probably little functional difference between removing the title attribute and setting it to an empty string? I guess my question is why one would prefer setting the title attribute to an empty string as opposed to removing it, and without clear justification for it, why would one repeat the pattern in v4?

Would you prefer that had I not wasted your time by identifying this as an accessibility issue, given that there is probably little functional difference between removing the title attribute and setting it to an empty string?

this isn't about wasting my or anybody else's time. i'm just asking what difference it makes, from an accessibility point of view, whether there's an empty title or no title. if none, then i'm just wondering if this is not simply personal preference (not having the attribute, versus having the attribute but empty).

As far as I know, there is no accessibility issue here. From the HTML Accessibility API Mappings (AAM):

If the control has an aria-label or an aria-labelledby attribute the accessible name is to be calculated using the algorithm defined in Accessible Name and Description: Computation and API Mappings 1.1.
Otherwise use the associated label element(s) accessible name(s) - if more than one label is associated; concatenate by DOM order, delimited by spaces.
Otherwise use the placeholder attribute
Otherwise use the title attribute

So in any accessible name calculation, the title attribute is well behind aria-label or aria-labelledby.
That said, I do agree it would be cleaner to remove the title attribute.

if none, then i'm just wondering if this is not simply personal preference (not having the attribute, versus having the attribute but empty).

It may have been to some extent personal preference, but now after rereading <IP_ADDRESS> The title attribute, I think I have a better understanding of why title="" was used.

If this attribute is omitted from an element, then it implies that the title attribute of the nearest ancestor HTML element with a title attribute set is also relevant to this element. Setting the attribute overrides this, explicitly stating that the advisory information of any ancestors is not relevant to this element. Setting the attribute to the empty string indicates that the element has no advisory information.

So setting the title attribute to an empty string explicitly overrides any title attribute on an ancestor element, which prevents an ancestor's native tooltip from displaying at the same time as the Bootstrap Tooltip.
I stand corrected and humbly withdraw this PR.

Just for archival purposes, HTML spec linked above is an old working draft. Same sections in the HTML 5.1 Editor's Draft and the HTML 5 Recommendation.


error: repo-hot is not a hot repository! Aborting.

Hi,
I tried using the hot/cold pattern with scaleway. For scaleway you cannot predefine the storage class for a bucket, so you have to set it in your rclone config as follows:
[scaleway-cold]
type = s3
provider = Scaleway
env_auth = false
endpoint = s3.fr-par.scw.cloud
access_key_id = ***
secret_access_key = ***
region = fr-par
location_constraint =
acl = private
server_side_encryption =
storage_class = GLACIER

[scaleway-hot]
type = s3
provider = Scaleway
env_auth = false
endpoint = s3.fr-par.scw.cloud
access_key_id = ***
secret_access_key = ***
region = fr-par
location_constraint =
acl = private
server_side_encryption =
storage_class = ONEZONE_IA

When running init with rustic v0.6.1 it throws error: repo-hot is not a hot repository! Aborting.
$ rustic -r rclone:scaleway-cold:ca86aad8-771c-43ec-9787-894b03b16c63 --repo-hot rclone:scaleway-hot:ee03f556-8a01-455d-abe5-efaba76ad77b init
using no config file, none of these exist: /home/michael/.config/rustic/rustic.toml, /etc/rustic/rustic.toml, ./rustic.toml
enter password for new key: [hidden]
[INFO] key 5eda87b5 successfully added.
[INFO] repository f2d8c604 successfully created.
error: repo-hot is not a hot repository! Aborting.

Despite the error message both repositories appear to have been initialized correctly and can be used with rustic backup.

Could it be that at rclone:scaleway-hot:ee03f556-8a01-455d-abe5-efaba76ad77b there is already a repository? init will initialize both the hot and the cold part.

No, only the buckets were created in advance.
I've just tried it again, with even non-existing buckets, but the output is the same:
$ rustic -r rclone:scaleway-cold:6b80f7ec-6dbb-4648-943a-729885a1367d --repo-hot rclone:scaleway-hot:7c512630-d05a-4dd7-9a0d-6fcc21b1a4e2 init
using no config file, none of these exist: /home/michael/.config/rustic/rustic.toml, /etc/rustic/rustic.toml, ./rustic.toml
enter password for new key: [hidden]
[INFO] key fb8a95ac successfully added.
[INFO] repository 9cd1ec55 successfully created.
error: repo-hot is not a hot repository! Aborting.

Seem like this ist a wrong Error message introduced by the refactoring into rustic_core. Can you Check If the comnand backup --init ist also affected?

Seem like this is a wrong error message introduced by the refactoring into rustic_core. Can you check if the command backup --init is also affected?

Happy new year! Appreciate your engangement. I can confirm that backup --init is also affected.

@simonsan For the design of the rustic_core API and to introduce the backup --init command, I decided to return an Repository<impl Open> from the init...() commands which means they call open_raw.
I think I missed some case for hot/cold reposiories there. I'll look into it and make a fix.
This repository-opening after initialization is actually not needed for for the plain rustic init command. So, here the repository is completely initialized before the error is wrongly returned. rustic backup --init is however currently broken for hot/cold repositories. I think the same applies to rustic copy --init.


page.setExtraHTTPHeaders not working

Steps to reproduce

Puppeteer version: latest
Platform / OS version: linux

What steps will reproduce the problem?
Please include code that reproduces the issue.

call page.setExtraHTTPHeaders({'x-my-header': '1'}) assuming page is apropriate object

What is the expected result?
Puppeteer will set extra headers
What happens instead?
Exception is thrown
TypeError: undefined is not a function
    at new Map (native)
    at NetworkManager.setExtraHTTPHeaders (.../node_modules/puppeteer/lib/NetworkManager.js:53:30)
    at Page.setExtraHTTPHeaders

Steps to fix
Change documentation according to code:
page.setExtraHTTPHeaders([
   ['x-my-header', '1'],
]);

Or change puppeteer code according to docs in order to support objects as parameters.
PS:
page.setExtraHTTPHeaders([
   ['x-my-header', '1'],
]);

not throwing exception, but it seems that it doesn't work as described in docs (the header isn't added to request).

@SkeLLLa Puppeteer 0.10.2 started using objects instead of maps for headers: https://github.com/GoogleChrome/puppeteer/releases/tag/v0.10.2
You probably use Puppeteer < 0.10.2?

I'll check it again, but if it's a definitely breaking change why "patch" version changed?

@SkeLLLa that's by mistake. Next time we'll bump minor in this kind of situation.

@SkeLLLa any updates on this?

I've checked for object - now it's ok. But never the less extra headers aren't passed to requests.

@SkeLLLa thanks, I can repro. This happens because page.setExtraHTTPHeaders expects only strings as header values.
I've sent a patch that validates this precondition and clarifies documentation. (#781)

@aslushnikov I've tried with strings as well. And it not worked too.

@SkeLLLa how exactly it didn't work for you? The following test passes for me (to run the test, add it to the test/test.js):
    fit('should work', SX(async function() {
      await page.setExtraHTTPHeaders({
        'x-update': '1'
      });
      await page.setUserAgent('Mozilla/5.0 (compatible; Googlebot/2.1; +http://www.google.com/bot.html)');
      const [request] = await Promise.all([
        server.waitForRequest('/empty.html'), // wait for server to receive request
        page.goto(EMPTY_PAGE),
      ]);
      expect(request.headers['x-update']).toBe('1');
    }));

I've rechecked and now it's working. But on prevoius version with maps it not worked. Thanks.

This seems to be broken again with Firefox. (#6221)


session feature with huge number of files incredibly slow on IE10 and IE11

It frequently occurs in our case that FineUploader has to load ~1000 initial files through the session feature upon start. Adding these to the uploader and UI takes about 20-30 seconds on IE10 and IE11, and the page doesn't respond at all during this time. Anything we can do about this?
As usual, I'm open to writing a PR to fix this if you can give me a hint on how to approach this.

The first step to fixing this would be identifying where the perf problem lies. Your case is very much on the outer edge of normal use, so it may be a little while before I am able to look at this further. There are a number of other questions/requests in the queue at the moment that I must attend to first.

That's OK, I might have a look at it myself before then, otherwise, I'll hear about it later. Thanks for the (incredibly) quick response!

The files are added using a callback options.addFileRecord in fine-uploader/client/js/session.js.
That callback is filled in by _addCannedFile in fine-uploader/client/js/uploader.basic.api.js. This is the source of that method:
        _addCannedFile: function(sessionData) {
            var id = this._uploadData.addFile({
                uuid: sessionData.uuid,
                name: sessionData.name,
                size: sessionData.size,
                status: qq.status.UPLOAD_SUCCESSFUL
            });

            sessionData.deleteFileEndpoint && this.setDeleteFileEndpoint(sessionData.deleteFileEndpoint, id);
            sessionData.deleteFileParams && this.setDeleteFileParams(sessionData.deleteFileParams, id);

            if (sessionData.thumbnailUrl) {
                this._thumbnailUrls[id] = sessionData.thumbnailUrl;
            }

            this._netUploaded++;
            this._netUploadedOrQueued++;

            return id;
        },

So there are three methods being called here, the first is _uploadData.addFile, and the other two methods just set endpoint and params.
        addFile: function(spec) {
            var status = spec.status || qq.status.SUBMITTING,
                id = data.push({
                    name: spec.name,
                    originalName: spec.name,
                    uuid: spec.uuid,
                    size: spec.size == null ? -1 : spec.size,
                    status: status
                }) - 1;

            if (spec.batchId) {
                data[id].batchId = spec.batchId;

                if (byBatchId[spec.batchId] === undefined) {
                    byBatchId[spec.batchId] = [];
                }
                byBatchId[spec.batchId].push(id);
            }

            if (spec.proxyGroupId) {
                data[id].proxyGroupId = spec.proxyGroupId;

                if (byProxyGroupId[spec.proxyGroupId] === undefined) {
                    byProxyGroupId[spec.proxyGroupId] = [];
                }
                byProxyGroupId[spec.proxyGroupId].push(id);
            }

            data[id].id = id;
            byUuid[spec.uuid] = id;

            if (byStatus[status] === undefined) {
                byStatus[status] = [];
            }
            byStatus[status].push(id);

            uploaderProxy.onStatusChange(id, null, status);

            return id;
        },

The code doesn't look inefficient (constant running time), except for perhaps the call to uploaderProxy.onStatusChange:
                onStatusChange: function(id, oldStatus, newStatus) {
                    self._onUploadStatusChange(id, oldStatus, newStatus);
                    self._options.callbacks.onStatusChange(id, oldStatus, newStatus);
                    self._maybeAllComplete(id, newStatus);

                    if (self._totalProgress) {
                        setTimeout(function() {
                            self._totalProgress.onStatusChange(id, oldStatus, newStatus);
                        }, 0);
                    }
                }

I guess the setTimeout call might swamp the scheduler. It should only be called once for the entire thing.

I tried solving that with this little adjustment:
                    if (self._totalProgress && self._totalProgressTimeoutId === null) {
                        self._totalProgressTimeoutId = setTimeout(function() {
                            self._totalProgress.onStatusChange(id, oldStatus, newStatus);
                            self._totalProgressTimeoutId = null;
                        }, 0);
                    }

But that doesn't help at all.
So, I decided to run the profiler in IE10 and it turns out 99% of the time is spent processing the DOM adjustments (specifically appendChild(), insertBefore() and set textContent). The trick to speeding this up big time is to update all of the HTML in one go, so that only one reflow & repaint operation has to be performed by the browser. Investigating further now...

Good detective work! Yes, this perhaps can be improved by batching all UI updates to ensure they happen all at once instead of staggered. I suspect this will be a bit tricky though, and this likely does not just affect stored files. Instead, you will probably see the same issue if you select/drop thousands of files in IE10/11.

Just tested that; you are correct. It does look like that is going to be tough. :/

can you remove the main block from the dom while you’re doing the manipulation and then put it back at the end?  sometimes that’s the easiest way to speed up dom math.

On Sep 14, 2015, at 4:25 AM, Korijn van Golen<EMAIL_ADDRESS>wrote:
Just tested that; you are correct. It does look like that is going to be tough. :/
—
Reply to this email directly or view it on GitHub https://github.com/FineUploader/fine-uploader/issues/1466#issuecomment-139997584.

I'm not sure about the design principle of the templating module FineUploader uses, so I can't predict if it can handle the detached DOM node (for example it might query the DOM in an intermediate step). @rnicholus can you shine some light on this (valuable) suggestion?

What, specifically, are you looking to temporarily remove from the DOM? Fine Uploader looks for elements given a reference element. That reference element is usually the file list container element - .qq-upload-list-selector. It does not use document as a reference element after the template has been initially rendered. So, that seems like it would work without issue.

i had a function that recalculated things and reapplied classes on a couple of hundred elements and it was slow.  then i found a few articles that said that i should detach the dom element manipulate it then reattach it once i was done.  this sped up that function considerably.  i forget the exact amount, but at least 2x and maybe 5x.
some other articles on that basic concept
http://desalasworks.com/article/javascript-performance-techniques/ http://desalasworks.com/article/javascript-performance-techniques/
https://learn.jquery.com/performance/detach-elements-before-work-with-them/ https://learn.jquery.com/performance/detach-elements-before-work-with-them/

On Sep 14, 2015, at 12:16 PM, Ray Nicholus<EMAIL_ADDRESS>wrote:
What, specifically, are you looking to temporarily remove from the DOM? Fine Uploader looks for elements given a reference element. That reference element is usually the file list container element - .qq-upload-list-selector. It does not use document as a reference element after the template has been initially rendered. So, that seems like it would work without issue.
—
Reply to this email directly or view it on GitHub https://github.com/FineUploader/fine-uploader/issues/1466#issuecomment-140128997.

Typical of the jQuery docs, the exact reason why you should perform many
operations on a set of orphaned elements is missing. But yes, I believe
that this will likely solve the issue as this should drastically limit the
number of reflows/repaints.
On Mon, Sep 14, 2015 at 11:49 AM morgunder<EMAIL_ADDRESS>wrote:

i had a function that recalculated things and reapplied classes on a
couple of hundred elements and it was slow. then i found a few articles
that said that i should detach the dom element manipulate it then reattach
it once i was done. this sped up that function considerably. i forget the
exact amount, but at least 2x and maybe 5x.
some other articles on that basic concept
http://desalasworks.com/article/javascript-performance-techniques/ <
http://desalasworks.com/article/javascript-performance-techniques/>
https://learn.jquery.com/performance/detach-elements-before-work-with-them/
<
https://learn.jquery.com/performance/detach-elements-before-work-with-them/

On Sep 14, 2015, at 12:16 PM, Ray Nicholus<EMAIL_ADDRESS>wrote:
What, specifically, are you looking to temporarily remove from the DOM?
Fine Uploader looks for elements given a reference element. That reference
element is usually the file list container element -
.qq-upload-list-selector. It does not use document as a reference element
after the template has been initially rendered. So, that seems like it
would work without issue.
—
Reply to this email directly or view it on GitHub <
https://github.com/FineUploader/fine-uploader/issues/1466#issuecomment-140128997
.

—
Reply to this email directly or view it on GitHub
https://github.com/FineUploader/fine-uploader/issues/1466#issuecomment-140141850
.

Caution: we probably do not want to remove the entire file list from the DOM whenever new files are added. This will be a jarring experience for users. Instead, perhaps the new set of file elements can be built-up in a detached state, and then added to the DOM once they are all in place. Don't think this will be trivial though.

I didn't think so either. A hacky way would be to batch adding the files using a recursive setTimeout strategy but that doesn't really solve the underlying problem.

Hello, incidentally I am investigating this same issue.  The client may have 3-4K files uploaded, but that could be even larger.  When the session/endpoint is pulled, it takes 30 seconds even on a MacBook Pro late 2013 model on Chrome's V8 engine.
My profile attempts through Chrome show that the hangup is primarily in the getByClass -> querySelectorAll function called by handleFileItems.  Perhaps that will help someone as they dive into the root cause.  (I have a slightly edited custom version of FineUploader, so line numbers will not match up perfectly).

Hope that helps ~

Maybe we can cache the selector results in some places? We could also switch to id's for unique elements.

@rmckeel Do you know where the bulk of these calls to getByClass are coming from? I'm interested in the stack for that particular call.
@Korijn IDs are, in most cases, to be avoided. They are an anti-pattern.  Determining what is "unique" in a document that you do not have full control over is tough. I would also suggest not caching any of these results, as we could potentially run into memory issues. Optimizing theses selectors is probably the best course.

@rnicholus Ray, where is a good place to send a file to your privately? I can share with you my .cpuprofile (and custom fineuploader JS file) that you could load into Chrome. I can't upload anything but images here.

@rmckeel Thanks for your response. Even with your custom JS/profile data, I'll still want to reproduce locally so I can be sure this is properly fixed. I've updated this case and I'll begin looking into this perf issue ahead of everything else once I have a bigger break in my time this week.

Thank you, Ray.  Excellent support.

I spent an hour yesterday investigating further. I was able to reproduce the issue. I'm using a Macbook Pro late-2014 model w/ 16 GMB RAM, i7, etc, etc. I setup my endpoint to return an initial file list of 3000 entires, consisting solely of name and uuid properties. Initial load of the list took about 10-15 seconds. During this time, I was able to scroll, but the browser did not respond to any other actions.
Using Chrome's profiler, I identified a huge number of calls to qq.getByClass. These calls seemed to account for the bulk of the work. I ultimately identified 4 issues here:
Too many DOM elements
Each file entry in the DOM is made up of at least 20 elements. If the initial file list consists of 3,000 entries, this means 60,000 extra DOM elements! That is a huge number of elements, and this will likely have a noticeable perf impact on most selectors. Putting performance aside, you can't expect your users will want to scroll through 3000 files. IMHO,** your initial files endpoint should never return anything close to 3000 files**. Instead, consider providing a small subset of these files. If you really expect your users to page through all of the files, you should return them in pages. I realize this is not very easy with the current API, but this could be much easier if I added an API method that allowed you to either add more initial files to the list. You could then pull the first set on load via Fine Uploader's built-in code, and then request subsequent pages yourself on-demand, passing these into the new API method for Fine Uploader to render.
Too many elements selector calls
For initial file added to the list, there are perhaps a dozen calls to the document to select various parts of the file or file list. For a "normal" amount of files in a batch, this is likely not an issue. But at scale, this has to cause noticeable perf consequences. The best solution to this is probably to determine when we are handling a batch of files, and maintain a cache of file IDs to file HTML elements. The internal templating module selectors can grab from this cache instead of hitting the DOM. This cache will be cleared after we are done processing the batch.
Inefficient element selectors
There were quite a few calls like this: fileListEl.querySelectorAll('.someClass')[0]. All we want it the first match, but instead we are querying for all matches and throwing all but the first away. A simple fix would be to use fileListEl.querySelector('.someClass') instead.
To many page reflows/repaints
In a batch of 3000 files, each file is added to the DOM separately. This results in a huge number of reflows/repaints, which is a perf issue. Instead, perhaps the code can be adjusted to build up this list of file elements detached from the document, and then add the entire batch at once when we are done processing the batch of files.
I am working to make the changes described above now. This will be a bit of work, but progress will be reported here as it happens. After all of the changes are complete, I'll make a new pre-release available for testing.

excellent news.  while i agree that this is the extreme case, i think that the end result will be much more polished feel for even the single file case.  its rare that you have a chance to streamline the DOM for your layout.  you might end up dropping a few elements and possible finding how to do some of the js logic in pure css for even more wins.  as i was looking at some of your samples, i wondered if making a version with font awesome icons vs the images you are currently using.  a switch to refer to fa fa-trash may make it possible to make all your buttons be one element vs two plus save on the img download entirely.  didn’t try to prove it would be much faster.  but maybe someone can shed some light on this or other other performance tweaks.

On Sep 15, 2015, at 12:02 PM, Ray Nicholus<EMAIL_ADDRESS>wrote:
I spent an hour yesterday investigating further. I was able to reproduce the issue. I'm using a Macbook Pro late-2014 model w/ 16 GMB RAM, i7, etc, etc. I setup my endpoint to return an initial file list of 3000 entires, consisting solely of name and uuid properties. Initial load of the list took about 10-15 seconds. During this time, I was able to scroll, but the browser did not respond to any other actions.
Using Chrome's profiler, I identified a huge number of calls to qq.getByClass. These calls seemed to account for the bulk of the work. I ultimately identified 4 issues here:
Too many DOM elements
Each file entry in the DOM is made up of at least 20 elements. If the initial file list consists of 3,000 entries, this means 60,000 extra DOM elements! That is a huge number of elements, and this will likely have a noticeable perf impact on most selectors. Putting performance aside, you can't expect your users will want to scroll through 3000 files. IMHO,** your initial files endpoint should never return anything close to 3000 files**. Instead, consider providing a small subset of these files. If you really expect your users to page through all of the files, you should return them in pages. I realize this is not very easy with the current API, but this could be much easier if I added an API method that allowed you to either add more initial files to the list. You could then pull the first set on load via Fine Uploader's built-in code, and then request subsequent pages yourself on-demand, passing these into the new API method for Fine Upl oader to render.
Too many elements selector calls
For initial file added to the list, there are perhaps a dozen calls to the document to select various parts of the file or file list. For a "normal" amount of files in a batch, this is likely not an issue. But at scale, this has to cause noticeable perf consequences. The best solution to this is probably to determine when we are handling a batch of files, and maintain a cache of file IDs to file HTML elements. The internal templating module selectors can grab from this cache instead of hitting the DOM. This cache will be cleared after we are done processing the batch.
Inefficient element selectors
There were quite a few calls like this: fileListEl.querySelectorAll('.someClass')[0]. All we want it the first match, but instead we are querying for all matches and throwing all but the first away. A simple fix would be to use fileListEl.querySelector('.someClass') instead.
To many page reflows/repaints
In a batch of 3000 files, each file is added to the DOM separately. This results in a huge number of reflows/repaints, which is a perf issue. Instead, perhaps the code can be adjusted to build up this list of file elements detached from the document, and then add the entire batch at once when we are done processing the batch of files.
I am working to make the changes described above now. This will be a bit of work, but progress will be reported here as it happens. After all of the changes are complete, I'll make a new pre-release available for testing.
—
Reply to this email directly or view it on GitHub https://github.com/FineUploader/fine-uploader/issues/1466#issuecomment-140442980.

you might end up dropping a few elements and possible finding how to do some of the js logic in pure css for even more wins

I have no plans to do this at the moment. These types of changes could be considered breaking changes, and I intend to make this a hotfix release.

i wondered if making a version with font awesome icons vs the images you are currently using

No plans to tie Fine Uploader to any specific 3rd-party dependency. If you wish to use different icons, you can certainly do this via CSS overrides.

I jus pushed some changes up to the hotfix/5.3.2 branch. Without these changes, a 5,000 item initial file list pretty much crashes Chrome/Firefox - spinners + constant long-running-script warnings, etc for quite a while. With my changes, the file list loads in a few seconds. That's a pretty substantial improvement. Profiling suggests that there are no obvious JS-specific or DOM-specific bottlenecks that can be further improved.
The last piece of this solution is to simply not load 3,000+ files for your users to sort though. And if you must do this, do so in pages. The work remaining in this case:

[ ] Provide API endpoint to pass in additional "canned"/initial files
[ ] Update docs
[ ] Consider using perf enhancements for dropped/selected file batches too.

In my case, I also use the list of files to filter duplicates/prevet files from being uploaded twice, using md5 hashes. So I do need the whole list. But, I could just not add them to the UI as you say. Excellent changes by the way. Looking forward to the release!

Is there any interest in an API method that allows you to pass in additional "initial"/canned files after Fine Uploader has loaded? This will add a bit more complexity, but has already been requested in #1191.

Besides the situation you described earlier, such a method could also be used to push files through WebSockets so multiple users (perhaps not even FineUploader but some other process) can upload files into the same container and see eachother's uploads as they're coming in.

To answer your question, I would probably not use it in the near future, if your current work already fixes the current issue at hand. Perhaps the requirement will come up later though.

@rnicholus Ray, my vote (on behalf of several clients sites that use FineUploader) is no interest in passing in lists of files after load.  There is no change that would warrant it in the single session.  I suppose group uploading would be a good reason to add that feature in, I just wouldn't expect group uploading to be that common! :)  Thanks ~

Hi everyone. Just a reminder that this new proposed api method isn't meant
to pass ALL of your initial files. It's purpose is to allow you to "page"
them. For example, your initial set on component load return 100, and you
include a "more results" button. When this is pressed, you request 100 more
and then pass the results into this new api method, appending them to the
existing list.
On Wed, Sep 16, 2015 at 11:44 PM Ryan McKeel<EMAIL_ADDRESS>wrote:

@rnicholus https://github.com/rnicholus Ray, my vote (on behalf of
several clients sites that use FineUploader) is no interest in passing in
lists of files after load. There is no change that would warrant it in the
single session. I suppose group uploading would be a good reason to add
that feature in, I just wouldn't expect group uploading to be that common!
:) Thanks ~
—
Reply to this email directly or view it on GitHub
https://github.com/FineUploader/fine-uploader/issues/1466#issuecomment-140969211
.

That was clear IMO.

In order to get this out sooner, I'm narrowed the TODO list to:

[ ] Update docs
[ ] Consider using perf enhancements for dropped/selected file batches too.

I may drop the last item as well if it proves to be too complicated or risky relative to the benefit. If the last item does need to be addressed and it is not addressed in this hotfix, I'll open up a new case.

Sounds great!

I don't think any change to user-submitted files is in order at this time. And since I plan to leave the work mentioned in #1191 for another time, I don't think there is much else to do here. Has anyone interested in this fix tested it out? If not, do you need more time? I plan to release my changes in a 5.3.2 version tomorrow otherwise.

Just wanted to let you know that we've confirmed this issue as fixed on our testing servers, and we'll go live with it soon. Thanks for the excellent support!

great, thanks for the confirmation


[Request] More exact placement of expander button when overlaying

Is your feature request related to a problem? Please describe.
Currently, you are given the option of having the button to the right, and the title card being slimmed and shoved to the side, or to overlay the title card with a full margin parameter. You cant set the margin independently. This doesn't work well for cards that have a button in that position already, such as the thermostat card.
Describe the solution you'd like
It would make much more sense to allow top/right margins to be set independently. Maybe even choose the initial corner, and set all margins.
Describe alternatives you've considered
3em works for the thermostat card, but it's kinda jank:

Hey @KairuByte,
I'm unsure whether it's really a problem with the expander card or rather with the thermostat card or do you know expander cards where the arrow is not at the top right? Do you have an example?
Two solutions come to mind off the top of my head
a) Don't use title-card-button-overlay: true
b) Use card mod
            .header {
              margin-top: 30px !important;
            }

Personally I would move the burger menu to the left (maybe also card mod) and leave the arrow at the top right

a) Looks really funky, if the card was much smaller I'd agree this wouldn't be a horrible solution though. This is what that looks like in this case:

b) is an option I suppose, I do actually use card mod in other places, but I normally turn to it as a last resort, considering the breaking changes that have happened in the past.
I suppose I can go with card mod in this case, so I'll close this.

Yes the thermostat card looks not that is a good candidate for a overlay card ;).
I have only good experience with the mushroom cards for overlay title card…
And the bigger cards than in the content.
So maybe try as overlay the mushroom climate card

Eh, card-mod covered the situation fine.


favicon for bookmarklets

Need a favicon for the bookmarklets to show easily on the toolbar

Doesn't seem possible since URL isn't pointing to the site.


Compatibility issue with windows

I tried running it on my windows machine but got multiple errors related to packages , though i figured out them but i now i'm having multiple syntax error !!
`PS E:\pcb-tools>  e:; cd 'e:\pcb-tools'; & 'C:\Users\raghavendra_tripathi\AppData\Local\Programs\Python\Python39\python.exe' 'c:\Users\raghavendra_tripathi.vscode\extensions\ms-python.python-2020.12.424452561\pythonFiles\lib\python\debugpy\launcher' '60020' '--' 'e:\pcb-tools\examples\cairo_example.py'
C:\Users\raghavendra_tripathi\AppData\Local\Programs\Python\Python39\lib\site-packages\pcb_tools-0.1-py3.9.egg\gerber\excellon_statements.py:458:
SyntaxWarning: "is not" with a literal. Did you mean "!="?
C:\Users\raghavendra_tripathi\AppData\Local\Programs\Python\Python39\lib\site-packages\pcb_tools-0.1-py3.9.egg\gerber\excellon_statements.py:461:
SyntaxWarning: "is not" with a literal. Did you mean "!="?
C:\Users\raghavendra_tripathi\AppData\Local\Programs\Python\Python39\lib\site-packages\pcb_tools-0.1-py3.9.egg\gerber\excellon_statements.py:609:
SyntaxWarning: "is not" with a literal. Did you mean "!="?
C:\Users\raghavendra_tripathi\AppData\Local\Programs\Python\Python39\lib\site-packages\pcb_tools-0.1-py3.9.egg\gerber\excellon_statements.py:612:
SyntaxWarning: "is not" with a literal. Did you mean "!="?
C:\Users\raghavendra_tripathi\AppData\Local\Programs\Python\Python39\lib\site-packages\pcb_tools-0.1-py3.9.egg\gerber\excellon_statements.py:458:
SyntaxWarning: "is not" with a literal. Did you mean "!="?
C:\Users\raghavendra_tripathi\AppData\Local\Programs\Python\Python39\lib\site-packages\pcb_tools-0.1-py3.9.egg\gerber\excellon_statements.py:461:
SyntaxWarning: "is not" with a literal. Did you mean "!="?
C:\Users\raghavendra_tripathi\AppData\Local\Programs\Python\Python39\lib\site-packages\pcb_tools-0.1-py3.9.egg\gerber\excellon_statements.py:609:
SyntaxWarning: "is not" with a literal. Did you mean "!="?
C:\Users\raghavendra_tripathi\AppData\Local\Programs\Python\Python39\lib\site-packages\pcb_tools-0.1-py3.9.egg\gerber\excellon_statements.py:612:
SyntaxWarning: "is not" with a literal. Did you mean "!="?
C:\Users\raghavendra_tripathi\AppData\Local\Programs\Python\Python39\lib\site-packages\pcb_tools-0.1-py3.9.egg\gerber\ipc356.py:385: SyntaxWarning: "is not" with a literal. Did you mean "!="?
C:\Users\raghavendra_tripathi\AppData\Local\Programs\Python\Python39\lib\site-packages\pcb_tools-0.1-py3.9.egg\gerber\ipc356.py:386: SyntaxWarning: "is not" with a literal. Did you mean "!="?
C:\Users\raghavendra_tripathi\AppData\Local\Programs\Python\Python39\lib\site-packages\pcb_tools-0.1-py3.9.egg\gerber\ipc356.py:415: SyntaxWarning: "is not" with a literal. Did you mean "!="?
C:\Users\raghavendra_tripathi\AppData\Local\Programs\Python\Python39\lib\site-packages\pcb_tools-0.1-py3.9.egg\gerber\ipc356.py:417: SyntaxWarning: "is not" with a literal. Did you mean "!="?
C:\Users\raghavendra_tripathi\AppData\Local\Programs\Python\Python39\lib\site-packages\pcb_tools-0.1-py3.9.egg\gerber\ipc356.py:431: SyntaxWarning: "is not" with a literal. Did you mean "!="?
C:\Users\raghavendra_tripathi\AppData\Local\Programs\Python\Python39\lib\site-packages\pcb_tools-0.1-py3.9.egg\gerber\ipc356.py:432: SyntaxWarning: "is not" with a literal. Did you mean "!="?
C:\Users\raghavendra_tripathi\AppData\Local\Programs\Python\Python39\lib\site-packages\pcb_tools-0.1-py3.9.egg\gerber\ipc356.py:385: SyntaxWarning: "is not" with a literal. Did you mean "!="?
C:\Users\raghavendra_tripathi\AppData\Local\Programs\Python\Python39\lib\site-packages\pcb_tools-0.1-py3.9.egg\gerber\ipc356.py:386: SyntaxWarning: "is not" with a literal. Did you mean "!="?
C:\Users\raghavendra_tripathi\AppData\Local\Programs\Python\Python39\lib\site-packages\pcb_tools-0.1-py3.9.egg\gerber\ipc356.py:415: SyntaxWarning: "is not" with a literal. Did you mean "!="?
C:\Users\raghavendra_tripathi\AppData\Local\Programs\Python\Python39\lib\site-packages\pcb_tools-0.1-py3.9.egg\gerber\ipc356.py:417: SyntaxWarning: "is not" with a literal. Did you mean "!="?
C:\Users\raghavendra_tripathi\AppData\Local\Programs\Python\Python39\lib\site-packages\pcb_tools-0.1-py3.9.egg\gerber\ipc356.py:431: SyntaxWarning: "is not" with a literal. Did you mean "!="?
C:\Users\raghavendra_tripathi\AppData\Local\Programs\Python\Python39\lib\site-packages\pcb_tools-0.1-py3.9.egg\gerber\ipc356.py:432: SyntaxWarning: "is not" with a literal. Did you mean "!="?
`

Hi!
I had the same issue. I believe it's because we're using python 3, while the developers are using python 2? But I'm still having the same issues with python 2. Although, that could simply be my own fault.
Hopefully, the contributors would know how to tackle this issue.

Hi!
I had the same issue. I believe it's because we're using python 3, while the developers are using python 2? But I'm still having the same issues with python 2. Although, that could simply be my own fault.
Hopefully, the contributors would know how to tackle this issue.

The code has a bunch of these constructs:
x = int(coord_dict['x']) if coord_dict['x'] is not '' else x

The is not here is incorrect, and also was back in those ancient Python 2.7 times. The only reason it works is that CPython has certain optimizations when it comes to short strings. Since empty strings are falsy, all is not '' can just be removed, resulting in code like this:
x = int(coord_dict['x']) if coord_dict['x'] else x

I'm wondering how these issue is closed while warnings still remains.
I replaced all 'is not ' with '!=' in the excellont_statements.py and ipc365.py and the warnings no longer exists.
changes.zip


Sanitize dots and stars in github module names for JS

Resolves: https://github.com/elm-lang/elm-compiler/issues/1475
Previous bad thing:
var _michaelbjames$michaelbjames.com$Main$main = { main: _elm_lang$html$Html$text('Hello, World!') };

New good thing:
var _michaelbjames$michaelbjames_com$Main$main = { main: _elm_lang$html$Html$text('Hello, World!')
};

I'm sure this is not the only place where there's an inconsistency between the existing sanitizations and what ES5 is okay with. In fact, I doubt that just -.* is enough.

Do you think these swaps should map everything that is not [a-zA-Z0-9$#_] to _?
Or should it use ecmascript's isValidIdPart :: Char -> Bool
Can you think of some better grand-plan for ensuring identifiers are valid?

Poop, this didn't solve the bug for all cases I could come up with. I'll return with a better PR!

You can have * in gihub repo names? My main worry is that we solve it but still allow certain problems. Maybe it is fairly safe to assume that no one will try to publish foo-bar as well as foo.bar? I kind of like the idea of doing a nice thing locally, but disallowing dots in the package repo. What do you think of that?

Looking at github's repo and user name validation: you can't have * in either.
I think disallowing dots will prevent this sort of issue affecting lots of users (if you only prevent them from publishing a package with a .) . But there should also be a safeguard in the compiler IMO. I'll use isValidIdPart to swap out invalid characters for _.
So yeah, disallow dots, and I'll add this safeguard.

I'd say just add the guard in here. I'd do a special one for dots, because I assume they'd be common, but that isValidPart function seems like a nice way to solve this for good.
I kind of would like for things to mess up badly if it makes it past this check. That'd mean there's some way around it, which should be resolved, and I'd want to find that as early as possible.

Okay, I thought about it a little more:
Not permitting packages with dots at all makes me sad. Consider this semi-hypothetical case: I've made a repo 'michaelbjames.com' and put a few hundred commits in to it (because I was on redux). I now see the err of my ways and want to bring in Elm. However, now I'll have to rename my repo to use this sweet, new language. There could be varying levels of difficulty with that if you're not using git or your VCS is tightly controlled (at a company for instance). There are some pretty specific cases in that example but underlying it all:
It seems like an unnecessary gotcha to introduce when we could handle it in the compilation.
That said, I totally understand blocking dots in published packages. That could get funky to pass around. But local development seems like it should be less…regulated.

When you are working locally, you can just give dummy names for the repo. The default is https://github.com/user/project.git and you never actually have to change it.
In the future, I think we will make it so you do not have to specify a repo unless you want to publish it, so it's even less of an issue.
So I think my proposed version does not clash with what you want. Am I correct?

@michaelbjames Could you explain what cases aren't solved by this code?

I have a similar case:
module Mainapp.Navigation.Types exposing (..)

import Mainapp.Navigation.Categories as Categories

-- TYPES
type AppState
    = ByCategory

type alias Store =
    { appstate : AppState
    , category : CategoryMenu
    }

type alias CategoryMenu =
    { category : Int
    , filter : List Int
    , subfilter : List Int
    , categories : Categories.Store
    }

type FetchMsg
    = Categories.Msg

type Msg
    = SelectApp AppState
    | SelectCategory Int
    | FetchCategories Categories.Msg

===================================
elm.js
...
var _user$project$Mainapp_Navigation_Types$ByCategory = {ctor: 'ByCategory'};
var _user$project$Mainapp_Navigation_Types$Categories.Msg = {ctor: 'Categories.Msg'};
var _user$project$Mainapp_Navigation_Types$FetchCategories = function (a) {
	return {ctor: 'FetchCategories', _0: a};
};
...

notice the Categories.Msg

@imdaveho, yours is a different case, since it is not about Github names. But nevertheless, your case is already reported elsewhere in this repository.

More specifically, @imdaveho's case is exactly like this one: https://github.com/elm-lang/elm-compiler/issues/1200


Add an ?uptime command

I'd like to see how long the bot has been running, without trying to infer it from chat history.
Spec:

?uptime command. It prints a formatted string indicating when it launched, and a second one indicating how long it has been running.

:+1:
On Thu, Jul 27, 2017, 8:11 PM Jake Voytko<EMAIL_ADDRESS>wrote:

I'd like to see how long the bot has been running, without trying to infer
it from chat history.
Spec:

?uptime command. It prints a formatted string indicating when it
launched, and a second one indicating how long it has been running.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/jakevoytko/crbot/issues/23, or mute the thread
https://github.com/notifications/unsubscribe-auth/ADte5Gyylzc67GMiLB3kTCV_PQzpgsULks5sSSdKgaJpZM4Ol_H-
.

IMO this would be interesting to literally nobody but me. Closing.


Computational Graph: Switch to OpenAPI

Switch to OpenAPI

Rewrite definitions
Adjust python and R bindings
serialization/deserialization

rust: serde, openapi
python: update ctypes

One of the big reasons why I considered OpenAPI a viable replacement for protobuf was that I had the option to generate only the model files. Unfortunately, this option is more of a filter, and in various languages the generated files still contain broken references/imports to server configuration/setup within the generated code. I have workable model generation/serialization/deserialization in rust (in the openapi branch), but using models alone won't work in Python or R (or Go, csharp, java, etc). Also, rust openapi generation is spotty (the most relevant tool still breaks on OneOf?)
I am moving forward with protobuf. I'm still open to adding translations from OpenAPI to the proto generated traits in the validator if a more viable code generation tool for data models in OpenAPI is demonstrated, or an alternative implementation idea is proposed.


Comment<>Bad logging tag we lunix bios tag Microsoft

Comment<>

Originally posted by @to75988070 in https://github.com/GoogleCloudPlatform/google-cloud-node-todos/issues/38#issuecomment-669616278

Closing as there is no way to reproduce the issue.

Deggol

Please stop


Dosen't work on new sparx update

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Use the extension, bookmark checks aren't highlighted.

Expected behavior
Bookmark checks aren't highlighted.
Desktop (please complete the following information):

OS: Windows 11
Browser: Opera GX

It was because of my Dark Reader extension.


Hotfix task list table width.

Cute animal pic
Because everyone likes pictures of animals.

Link to Trello card (if applicable)
If this PR relates to a Trello card, don't forget to reference this PR on the card as well.
https://trello.com/c/AEzmtH3A
Description
The commit messages say what you did; this should explain why and how.

[x] Description is in Trello card

Steps to test/reproduce
Please explain how to best reproduce the issue and/or test the changes locally.
Impacted areas of website
Provide URLs and/or a description of where to look.
Show me
Provide screenshots/animated gifs/videos if necessary.

Reviewer tasks:

[ ] Pulled branch and ran code locally (or viewed on preview deployment, if applicable)
[ ] Reproduced the issue to review in the browser
[ ] Reviewed code
[ ] Updated Trello card (if applicable)

 Bug: Task list overflows width into sidebar.


ActiveSupport 5.0 breaks build for Ruby < 2.2.3

This dependency appears to be coming from factory_girl.
I took a quick pass at addressing this and at appears that locking ActiveSupport at < 5.0.0 in Tmuxinator's Gemfile solves the problem (gist).

So, do we want to 🚢  this and then have https://github.com/tmuxinator/tmuxinator/pull/416 pull latest before merging in the PR?

As an aside, why are we putting this in the Dockerfile and not in the Gemfile itself?

So, do we want to :ship: this and then have #416 pull latest before merging in the PR?

That sounds good by me.

As an aside, why are we putting this in the Dockerfile and not in the Gemfile itself?

That was just me reproducing the broken build. The change in the PR was made to the Gemfile.

Ah cool 👍


⚠ AGEG website (redirect) has degraded performance

In 727a2b4, AGEG website (redirect) (https://ageg.ca/) experienced degraded performance:

HTTP code: 200
Response time: 3096 ms

Resolved: AGEG website (redirect) performance has improved in 7aa56c5.


usm: go-tls: Change BPF_LRU_MAP to BPF_HASH_MAP

What does this PR do?
Replaces BPF_LRU_MAP with BPF_HASH_MAP in GO-TLS.
Motivation
eBPF LRU is an unstable datastore that can evict items even when the map is not full or nearly full, and once eviction happens, it can remove many entries from the map, which can bring inaccuracies for our monitoring capabilities.
Describe how you validated your changes

Possible Drawbacks / Trade-offs
Additional Notes

https://datadoghq.atlassian.net/browse/USMON-1383

/merge


Payment filtering by creation date

Fixes #6532
Add fields min_creation_time_ns and max_creation_time_ns to ListInvoiceRequest proto and add underlying support for them in the rpc server.
Worth noting, the implementation filters in linear time with respect to the total number of payments. This is because the bbolt backend stores payments by key order, and we use the payment hash as the key, so the order is effectively random. I looked into using the paymentsIndexBucket to do a binary search, but after digging around the code in channeldb, I don't think I can confidently say whether payment indices will always be in the same order as creation time. If anyone with more familiarity knows that a binary search could work, let me know and I'll implement that instead.

@tvolk131, remember to re-request review from reviewers when ready

I looked into using the paymentsIndexBucket to do a binary search, but after digging around the code in channeldb, I don't think I can confidently say whether payment indices will always be in the same order as creation time. If anyone with more familiarity knows that a binary search could work, let me know and I'll implement that instead.

The paymentsIndexBucket is used effectively as a primary key, it gets incremented each time a new payment is added: https://github.com/lightningnetwork/lnd/blob/28ea2736a04566b06c38533e5e48e1b8d185a49b/channeldb/payment_control.go#L114-L121. However there may be some gaps in the sequence when we need to delete or retry a payment after a restart: https://github.com/lightningnetwork/lnd/blob/28ea2736a04566b06c38533e5e48e1b8d185a49b/channeldb/payment_control.go#L172-L183.

@carlakc: review reminder

@tvolk131, remember to re-request review from reviewers when ready

@tvolk131, remember to re-request review from reviewers when ready

@tvolk131, remember to re-request review from reviewers when ready

@tvolk131, remember to re-request review from reviewers when ready

@tvolk131, remember to re-request review from reviewers when ready

What's the status here? Still ongoing? cc @tvolk131

@tvolk131, remember to re-request review from reviewers when ready

@tvolk131, remember to re-request review from reviewers when ready

@tvolk131, remember to re-request review from reviewers when ready

@tvolk131, remember to re-request review from reviewers when ready

@tvolk131, remember to re-request review from reviewers when ready

@tvolk131, remember to re-request review from reviewers when ready

@tvolk131, remember to re-request review from reviewers when ready

@tvolk131, remember to re-request review from reviewers when ready

!lightninglabs-deploy mute 2022-Nov-01

!lightninglabs-deploy mute 2022-Nov-01

@tvolk131, remember to re-request review from reviewers when ready

@tvolk131, remember to re-request review from reviewers when ready

@tvolk131, remember to re-request review from reviewers when ready

Replaced by #7159


Issue with constraint when applying to existing data

Hi,
I just tried the Blueprint on an existing database where there are already plenty of lines inside the database tables. The Blueprint adds for each of the Audit Fields NOT NULL constraints. This does not work for existing tables with data as adding the constraint will cause such an error during startup while applying the generated liquibase changesets as there is no column default on the two user columns, therefore the newly created columns contain solely NULL values.
 Data truncation: Invalid use of NULL value [Failed SQL: (1138) ALTER TABLE fx.my_data MODIFY created_by VARCHAR(50) NOT NULL]

Maybe, we could introduce a default value (system (?) - just like the fallback during runtime) for the created_by / last_modified_by columns which can immediately be dropped after initial creation of the columns, just as with the two date columns...
Alternatively, at least state this behaviour regarding Constraints clearer in the README, by maybe adjusting this sentence:

This will also add new columns to the entities, so it is ideal to recreate the tables if you are enabling this for existing entities or use incremental changelog.

Releates to https://github.com/jhipster/generator-jhipster/issues/25094 - I'd like to introduce some defaults, using the merge request I'm preparing there.

usign the defaultValue option, we could introduce the system user as the default column value for the two user columns


[ExplicitModule] Support direct cc1 flag for all explicit module build job

Update swift-driver to support directly instantiate clang importer in all jobs with cc1 flags. In the new mode, swift dependency scanner will return all the cc1 flags to the actual compilation doesn't need to run clang driver again. In this mode, swift-driver should avoid forwarding Xcc command-line options since those are expected to be clang driver args, not cc1 args.

Support for https://github.com/apple/swift/pull/71118

@swift-ci please test

@swift-ci please test windows platform

@swift-ci please test windows platform

ping

ping


Cann't get the model named ssd_resnet50_0712.zip and vgg16_reduced model

the utrl https://github.com/zhreshold/mxnet-ssd/releases/download/v0.6/resnet50_ssd_512_voc0712_trainval.zip is not accessable recently,
would you like to share them on other address such as Baidu yun?

It's hosted on GitHub, you may have problem accessing it due to some reason. Retry multiple times, or refer to some techniques to access GitHub first.

could you share resnet50_ssd_512_voc0712_trainval.zip on Baidu yun @imistyrain ,thx


feat: hide sidebar menu config

Sometimes we need to manage the sidebar to not show the setting menu e.g (we're use the external package that manage the sidebar we cannot replace the current setting menu).
this feature possible to more flexible to toggle the menu

Hi! Thanks for the PR. :) I renamed the option to show_in_sidebar and released it in version 3.3.1.

Great !


Introduce sync resource to evaluate impact of resync

Description
The current format of tossing things in as creates and updates muddies the metrics. It's very difficult to tell if an event was received by Central due to a resync or due to something legitimate from k8s. This will help us determine that. The hunch is that reconnects and the resyncing of state cause the majority of events overall
Checklist

[ ] Investigated and inspected CI test results
[ ] Unit test and regression tests added
[ ] Evaluated and added CHANGELOG entry if required
[ ] Determined and documented upgrade steps
[ ] Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

If any of these don't apply, please comment below.
Testing Performed
CI + will post metrics from the CI runs

sensor_event_duration Action=SYNC_RESOURCE Type=AlertResults                     (280/30) 9.338
sensor_event_duration Action=SYNC_RESOURCE Type=Binding                          (2024/125) 16.193
sensor_event_duration Action=SYNC_RESOURCE Type=Deployment                       (30/32) 0.938
sensor_event_duration Action=SYNC_RESOURCE Type=Namespace                        (15/5) 3.020
sensor_event_duration Action=SYNC_RESOURCE Type=NetworkPolicy                    (76/8) 9.455
sensor_event_duration Action=SYNC_RESOURCE Type=Pod                              (1769/46) 38.452
sensor_event_duration Action=SYNC_RESOURCE Type=Role                             (2245/133) 16.877
sensor_event_duration Action=SYNC_RESOURCE Type=Secret                           (109/16) 6.839
sensor_event_duration Action=SYNC_RESOURCE Type=ServiceAccount                   (950/56) 16.962


Add raw ENA test file + update ISA JSON accordingly + update to target_repository

Feedback from Phillippe :

[ ] id for study and investigation is empty. Why does the pydentic model not fail?
[ ] investigatiom / filename should start with i_ (same for a_ s_) . Add to pydentic model
[ ] factor values and untis can be empty an empty list
[ ] Add checksum type to file
[ ] check if file checksum is a correct attribute (not snakecase?)

[ ]  id for study and investigation is empty. Why does the pydentic model not fail?

The test data below does not have an id field either. We can make it more strict but we should replace the test data first.
https://github.com/elixir-europe/MARS/blob/e39fdfc18dcf2cc74ab7b30f77e75a5c261647fb/test-data/ISA-BH2023-ALL/isa-bh2023-all.json


dev: add blockscout to RPC stack

Resolves: #1032
Pull Request type
Please check the type of change your PR introduces:

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] Documentation content changes
[ ] Testing

What is the new behavior?
Added Blockscout to:

docker-compose.yaml on port 4000
docker-compose.prod.yaml on port 4001
docker-compose.staging.yaml on port 4001

Does this introduce a breaking change?

[ ] Yes
[x] No

lgtm, did the build passes locally?

lgtm, did the build passes locally?

Yes, I ran:
make local-rpc-up
make staging-rpc-up
make testnet-rpc-up
The build passed in all three cases, and blocks and transactions were visible on Blockscout in all three cases


RF Module in Screen Flashing

Depenting of the position that i'm looking in the screen, some parts of the numbers in the screen disappear, and i'm not using optfine, cause it is famous of doing that things.
Version:
RFTools: 5.11
Forge: <IP_ADDRESS>4
Screenshots:
http://imgur.com/a/hqY1U

Do you have optifine or anything other client-side mod that affects rendering installed? Never seen that before

Nop, i don't have any mods that changes rendering, but recently i disabled the bar and it stopped doing that

The bar? What bar?

There is an red bar at the background of the numbers, and you can disable that bar in the screen


Updated "Available backends"

You have imported: from selectolax.lexbor import LexborHTMLParser, there is no need to call selectolax.lexbor.LexborHTMLParser but instead just LexborHTMLParser

Thanks!


SETUP.md: move to exercises/TRACK_HINTS.md

As https://github.com/exercism/exercism.io/issues/3240 states, we would
like to rename SETUP.md.
https://github.com/exercism/trackler/pull/17 has added the necessary
support for TRACK_HINTS.md, so we can now move this file.

I know you didn't request this, but we are also able to take a small precaution in case this doesn't go as we expect. I will propose the precaution in a PR and we can decide then if the precaution is necessary.


Update WFA actions to v2.

This uses the new action to load the Bazel cache for workflows which use Bazel.

This change is


Change Inventory commands remove and drop to use file name instead of object name

Inventory might be better if drop and remove use the file name to show the object instead of the object name. such as Tomato.py instead of Tomato. Need to update CONTRIBUTING and readme in yard if this is done

I assigned this to @CalebKendra -- good way to get into what inventory does!


Implement Filesystem Backend for Artifact Store

Currently, we have only InMemoryStore and RemoteHttpStore as underlying representations for the MLTE artifact store. We need a true persistence mechanism for any non-toy use. A filesystem-based store implementation is the simplest, and one that we supported in the past. We should port this work to a new LocalFilesystemStore implementation.

Resolved by #190.


[WFLY-10694] Fix of WFCORE-3826 breaks plain authentication for ejbs …

…using legacy configuration - test
Issue: https://issues.jboss.org/browse/WFLY-10694
Test for core issue: https://issues.jboss.org/browse/WFCORE-3963
Needs changes from core: https://github.com/wildfly/wildfly-core/pull/3391
Thanks for submitting your Pull Request!
Please make sure your PR meets the following requirements:

[ ] Pull Request title is properly formatted: [WFLY-XYZ] Subject or WFLY-XYZ Subject
[ ] Pull Request contains link to the JIRA issue(s)
[ ] Pull Request contains description of the issue(s)
[ ] Pull Request does not include fixes for issues other than the main ticket
[ ] Attached commits represent units of work and are properly formatted

For bigger changes, major and minor component upgrades make sure your PR also meets following requirements:

[ ] Pull Request requires a change to the documentation
[ ] Documentation have been updated accordingly
[ ] Tests were added to cover changes

For new features ensure as well:

[ ] Analysis was done
[ ] Test Plan has been done
[ ] Tests were verified in advance

If you are not an active contributor of the WildFly project you can request sponsorship by one of the members to help guide you through the process.

Do not merge it yet, test will be  upgraded according to the last change from https://github.com/wildfly/wildfly-core/pull/3391

Adding the hold label as per @JiriOndrusek 's comments

@kabir PR is good to go, I've managed to extend test on Friday afternoon. Hold label could be removed.

Retest this please

@JiriOndrusek The elytron job fails in the added test

@kabir I'm fixing failing tests. Please do not merge it without my confirmation (I'm not able to simulate error on my local machine, so I'll try a few test runs before merge)

Retest this please

Retest this please

Retest this please

@kabir thanks, I'll try it. I've noticed this setupTask last week (before it was merged) but I've forgotten to use it in this PR.

@kabir It's done


GH-39815: [C++] Document and micro-optimize ChunkResolver::Resolve()

Rationale for this change
There has been interest in improving operations on chunked-arrays and even though ChunkResolver::Resolve() is not a big contributor in most kernels, the fact that it can be used from tight loops warrants careful attention to branch prediction and memory effects of its implementation.
What changes are included in this PR?

Documentation of invariants and behavior of functions
Multiple optimizations justified by microbenchmarks
Addition of a variation of Resolve that takes a hint as parameter
Fix of an out-of-bounds memory access that doesn't affect correctness (it can only reduce effectiveness of cache in very rare situations, but is nevertheless an issue)

Are these changes tested?
Yes, by existing tests.
Are there any user-facing changes?

The arrow::internal::ChunkResolver::Bisect() function was protected and is now private with a different signature

Closes: #39815

Benchmarks of sort and rank on chunked arrays -- heavy users of ChunkResolver. 3 measurements after roughly every change to give an idea of level of noise. The purple group (bounds-check-fix) is when I fixed the out-of-bounds access bug that exists on main (not introduced by me in the optimizations). After that, the other two groups bring improvements that bring the throughput back to what was achieved before the bounds check.

Ideas that were tried and didn't make a difference or made throughput worse:

Removing the use of std::atomic completely, relaxed atomic operations are enough (which is good because that could introduce bugs)
Starting the Bisect on different ranges depending on the results of the branches

[1] ninja arrow-compute-vector-sort-benchmark && ./**/arrow-compute-vector-sort-benchmark --benchmark_filter="ChunkedArray(Sort|Rank).*Int64.*65536/100(/tiebreaker:2|$)" --benchmark_out_format=csv

@amol- @pitrou @js8544

+1 on the principle, looks like a nice improvement.

@ursabot please benchmark


Explicitly add output directory in deploy.sh

git commit -a only adds files that git already knows about, so any new
files are missed out.  Explicitly adding the output directory fixes
this.

:+1:


!!! THIS GEM IS NOT SUPPORTED CURRENTLY (see details inside) !!!

Currently, this repo is abandoned. There is a fork located at https://github.com/state-machines/state_machines which is supported. Also take a look at https://github.com/state-machines/ to see the list of available alternative statemachine realizations. Please don't file bugs here. File them at https://github.com/state-machines/state_machines/issues

@styx Please edit your link to https://github.com/state-machines/state_machines
Thank you for the notice, but we are getting traffic and questions in the sub-project for activerecord :)

@rosskevin thnx, done.

Thanks for info and link! And the test/unit test... :) Upgrading Rails 4.0 to 4.1 and my test failed on StateMachine class. Just change gem 'state_machine' to gem 'state_machines, nice :sunglasses:

Maybe someone could write a more clearer message in the Readme that the project has been abandoned?

@diaclavijo good idea, but if that was possible it would be done already.


#376 auth request service

implements authRequestService
adds auth granular tag
implements networking interactor's request method

Left some suggestions to incentivise scaling the service from the start. Also, the PR needs to run again in the CI (maybe rebase with develop)


Unable to deploy app with replicaset 'No valid replicaset members found'

Hello,
When deploying using meteor up using a full replicaset I'm unable to deploy without getting an error. Our current productionsetup is a single mongoserver with a replicaset initiated which works just fine. Now I fired up 3 servers and created a new replicaset for our staging setup. Each node communicates within the replicaset over the internal network. I entered the hostnames in /etc/hosts like this (on all the mongo servers & the webserver):
<IP_ADDRESS> mongo1
<IP_ADDRESS> mongo2
<IP_ADDRESS> mongo3

The replicaset is working properly confirmed with commands like rs.status(). From the meteor app server I'm able to ping mongo1, mongo2 etc. I'm also able to login with our credentials from the app server. But when I deploy with meteor-up I get the following error:
MongoError: no valid replicaset members found
    at Object.Future.wait (/bundle/bundle/programs/server/node_modules/fibers/future.js:449:15)
    at new MongoConnection (packages/mongo/mongo_driver.js:219:27)
    at new MongoInternals.RemoteCollectionDriver (packages/mongo/remote_collection_driver.js:4:16)
    at Object.<anonymous> (packages/mongo/remote_collection_driver.js:38:10)
    at Object.defaultRemoteCollectionDriver (packages/underscore.js:784:19)
    at new Mongo.Collection (packages/mongo/collection.js:103:40)
    at AccountsServer.AccountsCommon (packages/accounts-base/accounts_common.js:23:18)
    at new AccountsServer (packages/accounts-base/accounts_server.js:18:5)
    at meteorInstall.node_modules.meteor.accounts-base.server_main.js (packages/accounts-base/server_main.js:9:12)
    at fileEvaluate (packages/modules-runtime.js:181:9)
    - - - - -
    at [object Object]._onTimeout (/bundle/bundle/programs/server/npm/node_modules/meteor/npm-mongo/node_modules/mongodb-core/lib/topologies/replset.js:653:33)
    at Timer.listOnTimeout (timers.js:92:15)

my mup file is the following:
module.exports = {
  servers: {
    webbeta: {
      host: 'x.x.x.x',
      username: 'username',
      pem: 'privatekeyfile.pem',
      opts: {
        port: 22
      }
    }
  },

  meteor: {
    name: 'appname',
    path: '../.',
    docker: {
      image: 'abernix/meteord:base',
      args: [
        '--memory-reservation 1024M'
      ]
    },
    servers: {
      webbeta: {}
    },
    buildOptions: {
      serverOnly: true,
      debug: true,
      cleanAfterBuild: true, // default
      buildLocation: '/tmp/' // defaults to /tmp/<uuid> - do not enter anything here for windows
    },
    env: {
      ROOT_URL: 'http://appurl.domain.com',
      MONGO_URL: 'mongodb://user:password@mongo1,mongo2,mongo3/dbname?replicaSet=rs0',
      MONGO_OPLOG_URL: 'mongodb://oplogger:password@mongo1,mongo2,mongo3/local?authSource=admin&replicaSet=rs0'
    },
    deployCheckWaitTime: 120
  }
};

Using ip addresses in the connection string instead of hostnames gives me the error: no primary found in replicaset.
Putting only one hostname in the connection string doesn't matter.
Is there anything I should change?
Possible issues I thought about:

Docker doesn't recognise the host file
My connection url is incorrect (tried with socketTimeoutMS=300000 etc)
My mongo setup is in some kind of way incorrect
Other

I managed to resolve this. What I was trying to do was keep all data traffic over the local network (VM's on azure in my case).
Apparently docker uses a specific hosts file different to the one at /etc/hosts. You can resolve this by using the --network=host argument under docker args.
More info about this can be found over here:
https://docs.docker.com/engine/reference/run/#/network-settings
You could also use --add-hosts and add every host but that was suboptimal for my case.


 Very slow writing (~3x slower than other compressed images), and breaks around ~95%.

Happens both with 1.0.0-beta15 AppImage, and git head npm start.

Haha wtf? This must be coming from the bz2 decompression module we use (can't think of anything else). Could be a funny way to say a package is deprecated?

Indeed: https://github.com/regular/unbzip2-stream/blob/845023bb9b032706b6527704334cb0403a865f6c/lib/bzip2.js#L274
Do you mind creating a new issue on that project, probably linking to the problematic image? The maintainer is very responsive and I honestly don't have the knowledge to debug such as bz2 algorithm issue.

Sure thing :) Filed bug: https://github.com/regular/unbzip2-stream/issues/10

PR would be appreciated though!

No worries! I'll study how bzip2 works, and will try to fix or at least make sense out of it whenever I can allocate some time for it!

@jviotti @lurch actually seems to have figured it out already: https://github.com/regular/unbzip2-stream/issues/10

@jviotti where are we with this one?

We have https://github.com/cscott/compressjs, which is supposed to have
a fix for this issue, however they don't expose a standard NodeJS
implementation (they roll their own, which I can't get to play with
NodeJS, since its all done inside a single function), so we don't have a
good bzip2 decompression alternative yet.
On Thu, Dec 01, 2016 at 08:02:09PM -0800, Alexandros Marinos wrote:

@jviotti where are we with this one?
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/resin-io/etcher/issues/734#issuecomment-264368271

--
Juan Cruz Viotti
Software Engineer

Maybe it's worth nudging the author of unbzip2-stream and asking him to pick up the bzip2 fixes from compressjs ? I could do that if you like?

@lurch That would be amazing! Thanks a lot!

@lurch Even better than nudging: a PR with test. I don't use that module in any of my projects and I am no expert on bzip at all, so I'm in no way more qualified to apply that patch. I will however merge a PR asap and republish the npm module.

Even better than nudging...

Haha, I'll see when I have time to put something together :smile_cat:

@jviotti how much work would be to either port the fix or use another library? This is our second oldest bug :)

I started hacking on it at some point, got too deep into the rabbit hole, and ended up abandoning it. I'm happy to give it another go.

I guess we could "won't fix" this. Not sure it's worth your time.
--
Alexandros Marinos
Founder & CEO, Resin.io
+1<PHONE_NUMBER>
@alexandrosm
On Thu, Mar 2, 2017 at 8:18 AM, Juan Cruz Viotti<EMAIL_ADDRESS>wrote:

I started hacking on it at some point, got too deep into the rabbit hole,
and ended up abandoning it. I'm happy to give it another go.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/resin-io/etcher/issues/734#issuecomment-283699639,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABLUCJjmnAqgk5P_1x198moV5rSDXgG4ks5rhuvAgaJpZM4KK2Ef
.

I guess there's no reason to not keep it open until a clearer way forward appears.

This might be fixed in<EMAIL_ADDRESS>Let me know if it is!

Amazing stuff @regular , thanks a lot for this. I can't find any image that reproduces the issue, so I'll upgrade this on Etcher, and we'll see if it ever happens again, unless @imrehg still has the problematic image somewhere.

Unfortunately I no longer have a copy of @imrehg 's 2016-05-27-raspbian-jessie.img.bz2 file - I must have deleted it due to lack of disk space :-(  (and @imrehg 's dropbox download link is no longer working)
So I instead attempted to recreate it by downloading, extracting and recompressing http://downloads.raspberrypi.org/raspbian/images/raspbian-2016-05-31/2016-05-27-raspbian-jessie.zip and that did then recreate the infamous dinosaur-error with<EMAIL_ADDRESS>;-)
And upgrading<EMAIL_ADDRESS>did then eliminate the bug, so I can confirm v1.0.11 fixes this problem :smile:

Amazing news!!


upd(ulauncher-deb): 5.15.6 -> 6.0.0~beta4

breaks unicorns keybinds :/ but much quicker and more robust so we just have to update them

Why is this still a draft?

Why is this still a draft?

it breaks the unicorn keybind

bruh it still broke on noble

fix for unicorn-desktop-git/mobile-git:
add these to post_install

xfconf-query -c xfce4-keyboard-shortcuts -n -t 'string' -p '/commands/custom/<Super>s' 2&>1 /dev/null || xfconf-query -c xfce4-keyboard-shortcuts -n -t 'string' -p '/commands/custom/<Super>s' -s 'gapplication launch io.ulauncher.Ulauncher'
systemctl --user enable ulauncher --now

add to post_remove

systemctl --user disable ulauncher

we should also add <property name="<Super>s" type="string" value="gapplication launch io.ulauncher.Ulauncher"/> in unicorn under https://github.com/rhino-linux/unicorn/blob/10d0da119aca6d4fd7b5d1185db87a3cb3de088f/xfce4/xfconf/xfce-perchannel-xml/xfce4-keyboard-shortcuts.xml#L162 (as well as in failsafe)


Do not export symbols from the main package

main packages are not importable; see the discussion at https://github.com/golang/go/issues/4210
Signed-of-by: Burcu Dogan<EMAIL_ADDRESS>

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "ctr-readability" git@github.com:rakyll/containerd.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Ammending updates the existing PR. You DO NOT need to open a new one.

LGTM
thx


Today it stopped working with VSC Insider

On Windows 10.
VSC Insider version 1.20.0-insider
sftp version 1.0.1
Since upgrade to these version SFTP stopped working.
No upload or download in workspaces that worked until today. No errors.
When I run SFTP:Config I get error:
command 'sftp.config.default' not found

My vscode just updated to 1.20 (stable release), and i am facing this issue.
I get the error command 'sftp.config.default' not found when trying to create config
When i use shortcut, i get command 'sftp.trans.remote' not found
When i right click and select upload, nothing happens

@iaimmiac See #101.

Deleting a folder like /Users/c01nd01r/.vscode/extensions/liximomo.sftp-1.0.4/ and reinstalling sftp fixed my issue!


Handle null cases of task input snapshots.

https://builds.gradle.org/project.html?projectId=Gradle_Branches&tab=projectOverview&branch_Gradle_Branches=ld%2Fbuild-ops%2Fsnapshot-inputs

@alkemist What is the motivation for this change?

I merged it. The failing test is fixed, and the others are flakey tests.

@wolfs I'm going to open up a PR for this area on master to make the null chain clearer.


Slime Read does not show content in the popular tab (button).

Source information
SlimeRead 1.4.11
Source language
Portuguese Brazilian
Steps to reproduce
When opening the source it does not show the content of the popular tab (button). The content appears in the WebView and in the recent tab normally.

Expected behavior
The content of the popular tab appears.
Actual behavior
The content of the popular tab does not appear.
Mihon/Tachiyomi version
0.16.5
Android version
Android 12
Other details
Recent maintenance and migration has been performed on the host.
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] I have updated the app to version 0.15.3.
[X] I have updated all installed extensions.
[X] I have tried the troubleshooting guide.
[X] If this is an issue with the app itself, I should be opening an issue in the app repository.
[X] I will fill out all of the requested information in this form.

As already say in #3044, its a site issue, wait for them to fix


Stream music from Youtube or automate download

I think it would be a great feature if, like the video trailer extension, there was some kind of way to either stream a track from the game's OST automatically and/or there was a way to automate downloading the file.
Ideally the extension would be able to search for "[game name] OST" and pull a song or a playlist from it, either the first song (like a query for "[game name] ost theme" or [game name] ost 1" or "[game name] ost main menu") or a randomly selected song (like, search "[game name] ost", collect the youtube links for the first X results, and then play one) and then play it in the background.
But if any of that is not possible, or as an alternative method, a way to more easily download a song would be great. The trailers extension uses youtubedl to download trailers and lets you pick one from a Youtube search query, which is then stored on the computer. If the extension could do something similar for a "[game name] OST" search, that would be fantastic.

The Extra metadata tools extension would be a great starting point!

this is out of the scope of the plugin, i won't add this sorry

@drnooooo @felipecustodio Just so you two know, work has been done to add automated downloading. One download source was fully implemented, but due to legal risks will not be making it into any official release.
I have a prototype for Youtube based on how extra metadata functions working at the moment for https://github.com/joyrider3774/PlayniteSound/issues/20, but it needs more time to add customization options and iron out kinks.
In terms of streaming music/audio, Sounds is currently designed around files, so streaming is out of the question for now.
Maybe some work could be done to have files that really just point to a Youtube video (i.e. File name: "Stream - Uncharted 2: Among Thieves Soundtrack - "Nate's Theme 2.0" (Main Theme)" file contents: "5-Z23q7ZLEU") and then we somehow load the audio directly into memory, but that's for the extreme long term.
However, this method would certainly brake with large enough videos and using pagination sounds like too much work. Probably would just place a cap on songs of a certain length/size.


add Strict-Transport-Security header

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

3 of 3 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.1%) to 83.416%

Totals

Change from base Build<PHONE_NUMBER>:
0.1%

Covered Lines:
337

Relevant Lines:
404

💛  - Coveralls


Add IEETypeNode interface

This is similar to IMethodNode in the sense that it lets us preserve
information about the type associated with the symbol. Same as
IMethodNode, there are two classes implementing this.
I pulled the decision about which one to generate into the slow path (we
no longer need to consult the compilation group in order to pick a cache
to check).

@nattress Can you please take a look?

LGTM


Add Temporal API, IPFS based file sharing and storage service

[x] Your submissions are formatted according to the guidelines in the contributing guide
[x] Your additions are ordered alphabetically
[x] Your submission has a useful description
[x] The description does not end with punctuation
[x] Each table column should be padded with one space on either side
[x] You have searched the repository for any relevant issues or pull requests
[x] Any category you are creating has the minimum requirement of 3 items
[x] All changes have been squashed into a single commit

I've left the category you are creating..... box ticked, however it is not applicable as this is using an already existing category.

@jbrooksuk Any chance you can take a look at this? It's been opened for a lot longer than some of the latest PR's which were merged :smiley:

Sorry for the delay, thank you 😄


[fix] update variable values to include name conversion

Hey @burn2delete,
thanks for the PR. Sorry for the late reply, I was on vacation. Could you please write me a quick description of what this PR does?

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

-11 of 18 (38.89%)  changed or added relevant lines in 3 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.1%) to 66.55%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/transformer/standardTransformer.ts
0
1
0.0%

src/utilities/changeNotation.ts
2
3
66.67%

src/utilities/getVariables.ts
5
14
35.71%

Files with Coverage Reduction
New Missed Lines
%

src/utilities/getVariables.ts
2
22.54%

Totals

Change from base Build<PHONE_NUMBER>:
0.1%

Covered Lines:
498

Relevant Lines:
728

💛  - Coveralls

@lukasoppermann I pulled down this branch locally and confirmed it's working as expected (at least for me).

Could you please write me a quick description of what this PR does?

This PR appears to be patching the desired behavior, as called out here.
// Only add mode if there's more than one where the mode'd name was not included when there are two or more modes.
Before
(with Figma Token and Typography selected)
{
  "collectionname": {
    "color1": { ⚠ modes are skipped
      "type": "color",
        "value": "#494c5bff",
        "blendMode": "normal"
      },
    }
  },
  "typography": {
    ...
  }
}

After
(with Figma Token and Typography selected)
{
  "collectionname": {
    "light_mode": { ✅ modes are back
      "color1": {
        "type": "color",
          "value": "#494c5bff",
          "blendMode": "normal"
        },
      }
    },
    "dark_mode": {
      "color1": {
        "type": "color",
          "value": "#b5bac9ff",
          "blendMode": "normal"
        },
      }
    },
  },
  "typography": {
    ...
  }
}

This plugin is great. IMO it's the cleanest. If this can get patched, it will become my "go-to" plugin. Currently using the fork locally, but this has got to be a common painpoint

Hey @matthova,
thanks for checking it out. We need to update this as there are conflicts. Once done we can merge.


TMIA, no update since september

cc @LucioFranco

@Emilgardis I have been very busy with school and not had the chance to write something up. Feel free to start it.

Fixed!


coverall test 3

Pull Request Test Coverage Report for Build 14

38 of 41 (92.68%) changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.1%) to 99.828%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

spec/notification_center_spec.rb
35
38
92.11%

Totals

Change from base Build 12:
0.1%

Covered Lines:
2897

Relevant Lines:
2902

💛  - Coveralls


⚠ ClamAV has degraded performance

In a7c9f04, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 70 ms

Resolved: ClamAV performance has improved in 80ff094.


RangeError: Maximum call stack size exceeded

[nodebb-plugin-import] importer.success [2016-06-08T08:45:12.589Z] Phase ::: rebanAndMarkReadForUsersStart

rebanAndMarkReadForUsersStart ::: 376499/404828, 93.0022132856423%8/6 16:46 [91020] - error: RangeError: Maximum call stack size exceeded
    at Socket.flush (/Users/xidui/Documents/xidui/github/NodeBB/node_modules/engine.io/lib/socket.js:413:32)
    at emitNone (events.js:85:20)
    at WebSocket.emit (events.js:179:7)
    at Array.<anonymous> (/Users/xidui/Documents/xidui/github/NodeBB/node_modules/engine.io/lib/transports/websocket.js:109:14)
    at _stream_writable.js:383:15
    at afterWrite (_stream_writable.js:346:3)
    at onwrite (_stream_writable.js:337:7)
    at Socket.WritableState.onwrite (_stream_writable.js:89:5)
    at WriteWrap.afterWrite (net.js:775:12)
RangeError: Maximum call stack size exceeded
    at Socket.flush (/Users/xidui/Documents/xidui/github/NodeBB/node_modules/engine.io/lib/socket.js:413:32)
    at emitNone (events.js:85:20)
    at WebSocket.emit (events.js:179:7)
    at Array.<anonymous> (/Users/xidui/Documents/xidui/github/NodeBB/node_modules/engine.io/lib/transports/websocket.js:109:14)
    at _stream_writable.js:383:15
    at afterWrite (_stream_writable.js:346:3)
    at onwrite (_stream_writable.js:337:7)
    at Socket.WritableState.onwrite (_stream_writable.js:89:5)
    at WriteWrap.afterWrite (net.js:775:12)

hmm.. can you provide the following:

OS you're using
NodeBB version
database type
which exporter

Mac OSX 10.10.5
The latest commit is 01aeb45
mongodb
https://github.com/xidui/nodebb-plugin-import-q2a

does it do the same with NodeBB v1.0.0
see https://github.com/akhoury/nodebb-plugin-import#latest-version-only-supports

@xidui I have had this in a different area, it might help to increase the call stack for these kind of actions. In my case I had it when running ./nodebb upgrade because of a massive database and the way NodeBB is built.
This did it for me in my case
/bin/bash -c "ulimit -s 65500; exec /usr/local/bin/node --stack-size=65500 ./nodebb upgrade"


Add IAM support on SQS

Currently the aws key and secret configuration is mandatory. It would be good to make them optional and let the aws sdk try to get credential through IAM method.

Merged #77


merge package from arlac77/npm-package-template

package.json

chore(package<EMAIL_ADDRESS>

Coverage remained the same at 70.588% when pulling d77d54c28aa774631656847537018236fedcd60f on template-sync-1 into a521535faee0cc7a04ca9c3f0be34d64b7dffb7e on master.

:tada: This PR is included in version 3.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


debug configuration dropdown in visual studio code

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version:1.59.1(user setup)
OS Version: Windows_NT x64 10.0.14393

Steps to Reproduce:

Open Visual studio code.
Press F5 key for selecting a debug configuration.

Hello experts!
I was exploring Visual studio code 1.59.1 and I pressed f5 key for selecting the debug configuration by mistake. The dropdown doesn't go from the screen if I click anywhere on the screen unless I press escape unlike other dropdowns(like command palette).Is there any reason for it that I may not know about? I am new to VSC.
Please help!
Thanks in advance!

I cannot reproduce this on Windows.
Could you please provide a screenshot showing the dropdown menu.

Hello Sir!
Figure 1: Normal VSC screen.
Figure 2: I pressed F5 key
This suggestion list for selecting debug configuration doesn't go even after clicking anywhere on the screen except escape button unlike Command prompt suggestion list. So, Is there any reason for it? only this was my doubt

Thank you!

/extPython
In plain VS Code pressing "F5" does not result in the debug configuration dropdown (aka QuickPick) what you are seeing. So I'm speculating that what you are seeing is an issue with one of your installed extensions.
I suggest that you disable your extensions one by one to find the culprit.


Create FTT Python package

The functions and modules can be turned into python packages in which case importing FTT modules (now separate functions) looks neater. More importantly, it would help FTT developers/users outside of CE to integrate it into their modelling frameworks (only works if those frameworks are written in Python or if Python code can be read in)

Can you expand on this a bit more? Would this mean that:

Installation is done using "pip install ." from the package? Or would you want to publish it on PyPI?
We have to maintain the list of dependencies properly? Would a package automatically establish if dependencies work?
Is it easy to convert something in a Python package?


Add default cost code to general reception

Closes #
Changes proposed in this pull request:

...

Looks fine. I know we have this value set in config in the service but I guess it doesnt make sense to make a call just to pick up the default cost code. Only suggestion is maybe make it a const instead of hard coding.

It gets set on create. We don't need to pull it back.