RegKeyAbstract new code causes regression in XMLPad with mismatched VM

Describe the bug
Trying to start up XMLPad gives me a debug box thing, saying it can't find relevant registry key. It's trying to load the following regkey:
HKEY_CURRENT_USER/Software/Object Arts/XmlPad/TextStyles
To Reproduce
Steps to reproduce the behavior:

Go to 'Sample Applications'
Click on 'XMLPad'
Box pops up, title: Not found: 'A'
text reads:
25/04/2020 12:17:32 a.m.: 'Not found: A'
SystemDictionary(Object)>>errorNotFound:
SystemDictionary(Dictionary)>>errorKeyNotFound:
SystemDictionary(Dictionary)>>at:
Object class>>fromRegKey:
[] in XmlPad>>restoreTextStyles
RegKey(Dictionary)>>at:ifPresent:
XmlPad>>restoreTextStyles
XmlPad>>restoreViewOptions
XmlPad>>restoreUserSettings
XmlPad(TextDocument)>>onViewOpened
XmlPad(Shell)>>view:
XmlPad(Shell)>>createView:
XmlPad class(Shell class)>>create:
XmlPad class(Presenter class)>>create
XmlPad class(Presenter class)>>show
[] in SmalltalkSystemIcon>>openBlock
[] in SmalltalkSystemIcon>>openIn:
BlockClosure>>ifCurtailed:
BlockClosure>>ensure:
Cursor>>showWhile:
SmalltalkSystemIcon>>openIn:
[] in System Folder>>createComponents
FolderPresenter>>onActionPerformed
ListView(View)>>performAction
FolderPresenter(Presenter)>>performAction
ListView>>onLeftButtonDoubleClicked:
FolderPresenter(Presenter)>>onLeftButtonDoubleClicked:
ListView(View)>>wmLButtonDblClk:wParam:lParam:
ListView(View)>>dispatchMessage:wParam:lParam:
[] in InputState>>wndProc:message:wParam:lParam: cookie:
BlockClosure>>ifCurtailed:
GuiInputState(InputState)>>wndProc:message:wParam:lParam: cookie:
ShellView(View)>>isDialogMessage:
ShellView>>preTranslateMouseInput:
ShellView(View)>>preTranslateMessage:
GuiInputState(InputState)>>preTranslateMessage:
GuiInputState(InputState)>>pumpMessage:
GuiInputState(InputState)>>loopWhile:
GuiInputState(InputState)>>mainLoop
[] in GuiInputState(InputState)>>forkMain
ExceptionHandler(ExceptionHandlerAbstract)>>markAndTry
[] in ExceptionHandler(ExceptionHandlerAbstract)>>try:
BlockClosure>>ifCurtailed:
BlockClosure>>ensure:
ExceptionHandler(ExceptionHandlerAbstract)>>try:
BlockClosure>>on:do:
[] in BlockClosure>>newProcess:

I started by inserting a halt into XmlPad>>restoreTextStyles and walking forward until things went pearshaped, which they appeared to do by the time we finished with Object class>>fromRegKey:
the line I can find where things go bad is:
params := aRegKey value. This (eventually) calls decodeMultiSz.
String class>>fromByteArray:length:startingAt: returns an answer of 'Array30'  ( is the \0 character). This appears to be correct, but I could be misinterpreting it.
Investigations show that #('Array' '30') gets eaten and ends up becoming #('A' 'r' 'y' '3'). I suspect things are getting eaten by decodeFrom:upTo: but I don't know why.
Operating systems:

OS: Windows Vista, Fedora 28
Git version: v7.1.10-44-g54eb3494

This is what you would see if you'd not rebuilt the VM. The decoding of REG_MULTI_SZ is covered by RegKeyTest>>testMultiSz (which decodes an object serialised into the registry in the exact same way), so that would be failing if this were an actual bug.

I snagged a copy of the VM for DolphinVM-v7.1.10, extracted that, still got the same result when I opened up the image. Do I need to rebuild the image too?

Yes, that will work. If you want to work with the source code direct from the repo, then in order to have matching code either rebuild the VM yourself, or grab the artefacts from the corresponding master build as you did. Obviously this won't be necessary if there are no changes to the VM code since the last time you built/downloaded it.


Google Analytics I have won the hant

:tada:
ladies and gentlemen, today I'm here to announce the recovery of google analytics account!
The history begins here #139
The owner of this account is @EvanDotPro and now I have the access but where is the tracking? The graph is empty and this site not embed the google analytics track code..
02/01/2015 - Today

Code
<script>
  (function(i,s,o,g,r,a,m){i['GoogleAnalyticsObject']=r;i[r]=i[r]||function(){
  (i[r].q=i[r].q||[]).push(arguments)},i[r].l=1*new Date();a=s.createElement(o),
  m=s.getElementsByTagName(o)[0];a.async=1;a.src=g;m.parentNode.insertBefore(a,m)
  })(window,document,'script','//www.google-analytics.com/analytics.js','ga');
  ga('create', 'UA-39824791-1', 'auto');
  ga('send', 'pageview');
</script>

:+1:

@localheinz would you revert the commit that remove the code or send new PR? :)

@gianarb done
/cc @localheinz

Fixed in #480.


Resolves plugin id constraint violation

Resolved #155.
So far, I cannot reproduce with a test.

And the problem is not showing in my local instance anymore.


More lock-related test cases

[ ] If a file containing a lock is renamed, it should be detected
[ ] If a file containing a lock is deleted, it should be detected

Actually both cases are present in the GitHub diff.
Rename example:
diff --git a/README.md b/READ.md
similarity index 100%
rename from README.md
rename to READ.md
diff --git a/foo b/foo
new file mode 100644
index 0000000..1223559
--- /dev/null
+++ b/foo
@@ -0,0 +1 @@
+🔒

Delete example:
deleted file mode 100644
index c9a4a64..0000000
--- a/README.md
+++ /dev/null
@@ -1,9 +0,0 @@
-# pr-custom-review-test
-This is playground to test GitHub Action [pr-custom-review](https://github.com/paritytech/pr-custom-review)
-Action has one hardcoded built in condition looking for changes in PR diff using RegExp:
-
-`/🔒.*(\n^[\+|\-].*)|^[\+|\-].*🔒/gm`
-
-The rest can be found and changed if needed in GHA config file `./.github/pr-custom-review-config.yml`
-
-Feel free to make some changes and create PR's to test how GHA [pr-custom-review](https://github.com/paritytech/pr-custom-review) works.

Now I realize it does not make sense for us to test this response since it's GitHub who provides it. Both cases above should already be covered by the detection we have currently.


Auto Typing,

Hey, Um, There Is A Problem, There Is No Auto Typing, I Let Go, And It Didn't Do Anything, Can You Fix This?

You need Nitro Typer EXE alongside this script in order to Auto type. For downloading this, visit my site.


Kuzu db can become inconsistent

It seems kuzu database can become inconsistent and it is neither reported nor fixed by kuzu_shell in particular.
There is a kuzu database with the following structure:
CREATE NODE TABLE User(uid UUID, id INT64, PRIMARY KEY(uid));
CREATE NODE TABLE Note(uid UUID, id INT64, PRIMARY KEY(uid));
CREATE REL TABLE Links(FROM Note TO Note);
CREATE REL TABLE NoteOf(FROM Note TO User);

The binary database files of the database are available here:
https://file.io/otuAQVrb4UHz
The database has been originally populated by importing User, Note and Links from .csv files while NoteOf has been created using a node.js script. The script has been interrupted several times. The goal of the script was to create a link between notes and users so as each note belonged to some user. In the end, the database contains: 1000 users, 1000000 notes, about 4000000 links, and is supposed to contain 1000000 NoteOf relationships.
The following query shows that no note remains unassigned:
kuzu> MATCH (n:Note) WHERE NOT EXISTS { MATCH (n)-[:NoteOf]->(:User) } RETURN count(n);
----------------
| COUNT(n._ID) |
----------------
| 0            |
----------------
(1 tuple)
(1 column)
Time: 3.65ms (compiling), 803.85ms (executing)

However, after exporting NoteOf using:
COPY (MATCH (n:Note)-[:NoteOf]->(u:User) RETURN n.uid, u.uid) TO 'note_of.csv';

it appeared that only 999990 relationships out of 1000000 has been exported.
At first I thought it was a problem with export but I imported the exported .csv files into a new database and found the missing IDs:
[743642,853676,684672,853633,992666,992667,602411,755386,831275,643211]
I applied them (plus 1, 2, 3 as some "good" IDs for testing) to the following queries against the original database:
kuzu> MATCH (n:Note) WHERE n.id in [1, 2, 3, 743642,853676,684672,853633,992666,992667,602411,755386,831275,643211] RETURN n.uid, n.id;
-------------------------------------------------
| n.uid                                | n.id   |
-------------------------------------------------
| a017c165-98ce-4f17-9761-cb822b8b2dfe | 684672 |
-------------------------------------------------
| 85f0807e-a588-4db6-866c-d683befd34cc | 755386 |
-------------------------------------------------
| e2bb50df-ccc6-471f-a7e0-a50a17341164 | 743642 |
-------------------------------------------------
| 89dd8aa3-117a-4328-b316-25866d5f4b2b | 831275 |
-------------------------------------------------
| bdf820b4-b188-41b3-b336-f9f1eb94d662 | 853633 |
-------------------------------------------------
| c6c4c6bc-22a7-446f-a838-ab65497866aa | 853676 |
-------------------------------------------------
| 5e8c1059-533c-467b-9bfd-ab7bdcf76896 | 1      |
-------------------------------------------------
| ba05b55b-3d3b-4873-a37b-397581d45e8d | 2      |
-------------------------------------------------
| 2c24f177-ebe0-4695-91f9-5a6d84f379f3 | 3      |
-------------------------------------------------
| 48c27540-c017-4bba-a86b-ac6bc8ff1ae5 | 992666 |
-------------------------------------------------
| bd199b09-53f4-402b-bd56-b9478b35c849 | 992667 |
-------------------------------------------------
| 2b25ecf7-b705-4335-b3bd-4ba867b85be6 | 602411 |
-------------------------------------------------
| 6f0e78d7-c1af-434b-b4c9-cc1da87c7ad8 | 643211 |
-------------------------------------------------
(13 tuples)
(2 columns)
Time: 0.47ms (compiling), 49.18ms (executing)

The query returned all the specified notes as expected. But the next query:
kuzu> MATCH (n:Note)-[:NoteOf]->(u:User) WHERE n.id in [1, 2, 3, 743642,853676,684672,853633,992666,992667,602411,755386,831275,643211] RETURN n.uid, n.id, u.id;
------------------------------------------------------
| n.uid                                | n.id | u.id |
------------------------------------------------------
| 5e8c1059-533c-467b-9bfd-ab7bdcf76896 | 1    | 176  |
------------------------------------------------------
| ba05b55b-3d3b-4873-a37b-397581d45e8d | 2    | 954  |
------------------------------------------------------
| 2c24f177-ebe0-4695-91f9-5a6d84f379f3 | 3    | 176  |
------------------------------------------------------
(3 tuples)
(3 columns)
Time: 1.87ms (compiling), 18.75ms (executing)

returned only "good" IDs.
Summarizing:
MATCH (n:Note) WHERE NOT EXISTS { MATCH (n)-[:NoteOf]->(:User) } RETURN count(n);

reports there are no unconnected notes, but:
MATCH (n:Note)-[:NoteOf]->(u:User) WHERE n.id in [1, 2, 3, 743642,853676,684672,853633,992666,992667,602411,755386,831275,643211] RETURN n.uid, n.id, u.id;

reveals there exist some unconnected notes.
I used kuzu_shell and kuzujs.node built from source on 23 March 21:13 (source code was pulled right before the build).
(It is not the first time I noticed inconsistencies. I also had a case when the same query returned different results, which looked like a random subset of a bigger set. Unfortunately, I have not kept the binary files.)

Additional information: the node.js script created NoteOf relationships in the following way:
    const s_ids = ids.join(',');
    const query = `
      MATCH (n:Note), (u:User {id: $user_id})
      WHERE n.id IN [${s_ids}]
      MERGE (n)-[:NoteOf]->(u);
    `;
    const stmt = await con.prepare(query);
    const result = await con.execute(stmt, { user_id: user_id });

Hi @lbuczkow thanks for reporting the bug.
Do u mind sharing the original files (csv, parquet or create statements) instead of database folder? After investigation, the bug is due to an inconsistent adjacency list index on the storage side. Consider your example
MATCH (n:Note)-[:NoteOf]->(u:User) WHERE n.id in ...

Result is correct if we extend in direction n -> u and incorrect if extend is in direction u -> n. Meaning our forward and backward adjacency lists are not consistent with each other.
As far as I can recall, this bug should be fixed by @ray6080 already (I couldn't find the specific PR for the fix so @ray6080 should comment in the thread). So I wonder if you have reloaded the data recently which hopefully can fix this bug. If it doesn't work, happy to investigate deeper with the raw files.
Best,
Xiyang

This should be something different from the previous fix, which was done two weeks ago, before the "23 March".
It looks like the link to binary db file is no longer valid. Can you provide raw csv files or the full script of generating these csv files? I will take a look into it.

@andyfengHKU: the relationship is only n->u. I have not intended to create u->n .
@ray6080: I do not have the original .csv files anymore but they can be recreated using:
COPY (MATCH (u:User) RETURN u.uid, u.id) TO 'user.csv';
COPY (MATCH (n:Note) RETURN n.uid, n.id) TO 'note.csv';
COPY (MATCH (n1:Note)-[:Links]->(n2:Note) RETURN n1.uid, n2.uid) TO 'links.csv';

I had compared the exported files with the original ones before deleting and they differed only in order of records.
I also uploaded them for convenience: https://file.io/Ek2sqzELM9ds
NoteOf has been created directly in the database using a .js script. I experimented a lot during the creation of this relationship and the script went through several modifications. Its execution was interrupted with Ctrl-C so it might contribute to the issue.
The most recent version of the script is:
// ../js/kuzu contains kuzujs.node built from source
// and the corresponding .js api files
const kuzu = require("../js/kuzu");
const db = new kuzu.Database("./notes");

async function task() {
  const con = new kuzu.Connection(db);
  let total = 0;
  const q0 = `
    MATCH (n:Note)
    WHERE NOT EXISTS { MATCH (n)-[:NoteOf]->(u:User)}
    RETURN n.id AS id;`;
  const st0 = await con.prepare(q0);
  const res0 = await con.execute(st0);
  const rows0 = await res0.getAll();
  const num_remaining = rows0.length;
  console.log(`remaining ${num_remaining} notes`);
  let remaining = [...rows0.map(r => r.id)];
  for (let user_id = 0; user_id < 1000; user_id++) {
    let ids = [];
    if (remaining.length == 0) {
      console.log('no more free notes');
      break;
    }
    const note_id = remaining[0];
    remaining = remaining.filter(it => it !== note_id);
    ids.push(note_id);
    const q2 = `
      MATCH path = (n0 {id: $note_id})-[* 1..6]->(n1:Note)
      WHERE NOT EXISTS { MATCH (n1)-[:NoteOf]->(:User) } AND n1.id <> $note_id
      RETURN DISTINCT n1.id AS id;
    `;
    const st2 = await con.prepare(q2);
    const res2 = await con.execute(st2, { note_id: note_id });
    const rows2 = await res2.getAll();
    const ids2 = rows2.map(r => r.id).filter((it, idx, arr) => arr.indexOf(it) === idx);
    ids.push(...ids2);
    const cnt = ids.length;
    total += cnt;
    const sids = ids.join(',');
    const q3 = `
      MATCH (n:Note), (u:User {id: $user_id})
      WHERE n.id IN [${sids}]
      MERGE (n)-[:NoteOf]->(u);
    `;
    const st3 = await con.prepare(q3);
    const res3 = await con.execute(st3, { user_id: user_id });
    remaining = remaining.filter(it => !ids.includes(it));
    console.log(`user=${user_id} note0=${note_id} cnt=${cnt} total=${total}`);
  }
}

(async () => {
  task();
})();

Hi @lbuczkow
I basically follow your approach to reproduce the csv files through
COPY (MATCH (u:User) RETURN u.uid, u.id) TO 'user.csv';
COPY (MATCH (n:Note) RETURN n.uid, n.id) TO 'note.csv';
// the following `noteOf.csv` has 999990 lines indeed.
COPY (MATCH (n1:Note)-[:NoteOf]->(n2:User) RETURN n1.uid, n2.uid) TO 'noteOf.csv';

And then recreate a new database directory with
CREATE NODE TABLE User(uid UUID, id INT64, PRIMARY KEY(uid));
CREATE NODE TABLE Note(uid UUID, id INT64, PRIMARY KEY(uid));
CREATE REL TABLE NoteOf(FROM Note TO User);
COPY User FROM 'user.csv';
COPY Note FROM 'note.csv';
COPY NoteOf FROM 'noteOf.csv';

Then
MATCH (n:Note) WHERE NOT EXISTS { MATCH (n)-[:NoteOf]->(:User) } RETURN count(n);

reports 10 which is expected now.
So I think you could fix be recreating database from scratch (which will apply our fix to the storage since you are using the latest master).
I'll also ask my colleague to execute js code to see if the bug still exist there or not. Will keep u updated.

Yes, this is exactly what I did in order to continue with my tests and for a test scenario it is perfectly ok. But frequent exporting and importing entire database to fix inconsistencies is not an acceptable solution for a database used in production. It is no go for a database engine if a database becomes and remains internally inconsistent. This is why I reported the issue.

I played with the .js script for 3 days before I realized there were inconsistencies, and there were only 10 of them among 1 million records. So reproducing the issue might not be so easy.

It is no go for a database engine if a database becomes and remains internally inconsistent.

Total agree. Data integrity is one of the most important aspect of database. So fixing these is always our top priority.

So reproducing the issue might not be easy.

We plan to rerun the script on a new database and then validate the storage data. This issue is almost identical with another user reported issue two weeks ago except that his was using python api. So I'm fairly confident that the fix will also apply to your case. Will let u know the result by tmr.
Thanks for reporting again!

Another thing:
This is actually a separate issue but since it is related to the same dataset I put it here:
kuzu> MATCH (u0:User)<-[:NoteOf]-(n0:Note)-[:Links]-(n:Note)-[:NoteOf]->(u:User)
..> WHERE n0.id = 11
..> WITH u0.id AS u0id, n0.id AS n0id, u.id AS uid, n.id AS nid,
..>      COUNT { MATCH (n0)<-[]-(n) } AS l,
..>      COUNT { MATCH (n0)-[]->(n) } AS r
..> RETURN DISTINCT u0id, n0id, CASE WHEN l = 0 THEN "->" WHEN r = 0 THEN "<-" ELSE "--" END AS dir, uid, nid;
---------------------------------
| u0id | n0id | dir | uid | nid |
---------------------------------
| 188  | 11   | --  | 176 | 1   |
---------------------------------
| 188  | 11   | <-  | 954 | 2   |
---------------------------------
| 188  | 11   | <-  | 176 | 3   |
---------------------------------
| 188  | 11   | --  | 954 | 12  |
---------------------------------
(4 tuples)
(5 columns)
Time: 8.32ms (compiling), 6585.94ms (executing)
kuzu>
kuzu> MATCH (n0:Note)-[:Links]-(n:Note), (n0)-[:NoteOf]->(u0:User), (n)-[:NoteOf]->(u:User)
..> WHERE n0.id = 11
..> WITH u0.id AS u0id, n0.id AS n0id, u.id AS uid, n.id AS nid,
..>      COUNT { MATCH (n0)<-[]-(n) } AS l,
..>      COUNT { MATCH (n0)-[]->(n) } AS r
..> RETURN DISTINCT u0id, n0id, CASE WHEN l = 0 THEN "->" WHEN r = 0 THEN "<-" ELSE "--" END AS dir, uid, nid;
---------------------------------
| u0id | n0id | dir | uid | nid |
---------------------------------
| 188  | 11   | --  | 954 | 12  |
---------------------------------
| 188  | 11   | --  | 176 | 1   |
---------------------------------
| 188  | 11   | <-  | 954 | 2   |
---------------------------------
| 188  | 11   | <-  | 176 | 3   |
---------------------------------
(4 tuples)
(5 columns)
Time: 4.35ms (compiling), 6418.38ms (executing)

Both queries are way too slow compared to what Kuzu is capable of. The query planner really needs improvements.

Hi @lbuczkow , we've got what's wrong from the binary db files. trying to follow your steps to reproduce the problem from scratch. it seems the script takes quite a while to run, and we haven't finished running it yet. Is there a smaller example or simplified script available to reproduce this?

The purpose of the script was to randomly assign groups of notes (neighbouring to each other) to users. A single run of the script takes about an hour and covers only a fraction of all 1000000 notes so it had to be run several times. I was executing it again and again for three days to complete the job. In the meantime I was modifying the logic of the script, but not the part which really makes changes to the database. I also interrupted the script several times (by pressing Ctrl-C). I can only suggest interrupting the script more frequently because I suspect the issue was caused by it, but it is just a pure guess. I do not have any other script to reproduce the issue.

okay. thanks for the info. A potential fix is here (https://github.com/kuzudb/kuzu/pull/3165). I will run the scripts a bit more rounds to see if I can verify the problem and the fix. will also see if I can reproduce it locally with some other random generations.

This should be fixed in #3165.

Closed since the bug is fixed.


Option to enable/disable use of external kob/key/sounder

It would be convenient to leave the 'port' value configured but be able to enable and disable its use. This would allow disabling the KOB and use the simulated sounder (such that headphones can be used in order to not disturb others).
A bonus would be the ability to keep the KOB (loop interface) enabled for the key, but disable the sounder and use the simulated sounder.
This would allow sending with the KOB key while using the simulated sounder with headphones in order to send/practice without disturbing others.

I think this would be a useful feature. I can see myself using the external key with headphones instead of the sounder (or with the speaker with the volume turned low).

Is it possible to leave the loop enabled and read the key but not create sound on the sounder?  Wouldn't the opening/closing of the key make sound in the sounder if they're wired in a loop?
Is there a diagram of the typical sounder interface?

I never considered the possibility before, but now that I realize it should be possible to read the key in the loop without the loop being powered (meaning the sounder will remain silent). In fact, this is how it works when a remote station opens the circuit. The local sounder stays deenergized, but the program still has access to the state of the local key, and that state is conveyed to the remote station. So yes, it should work.
There's a circuit diagram for a sounder driver interface here. It's a lot simpler than the loop interface which has superseded it.

Oh, it's possible to create an output-only sounder driver from a serial port that's different from creating a local loop with Chip Morgan's interface box?  I was picturing the latter, not the former.  When you have a local loop, they key is typically in that loop, no?  And then the key and the local sounder are active/inactive as a pair?
Do people wire the sounder and the key to different pins of the same serial driver (signaling on the "write" and "read" pins, respectively)?  Or do people use separate serial lines for each?

The serial port pin assignments are shown here. Only one serial port is used. These assignments are the same for all interface configurations (key only, key and sounder driver, or loop interface).
The option for silencing the sounder while still using the key should work with either a sounder driver or a loop interface. If that seems counterintuitive, welcome to the club. Before designing the loop interface, I thought it would be impossible too. But when I saw the circuit for the old dial-up Morse terminal unit I realized it could be done.

I agree.
I put a scope on the loop interface I built and with RTS false (sounder off) the signal on DSR still changes when the key is closed and opened. So it seems like it would just be a matter of splitting out the enabling of the key and the sounder with separate flags rather than using that fact that 'port' is set to enable/disable both.

@pwdirks the key thing with the loop interface is that there is always some current available to flow through the sounder if the loop is closed, just not enough to cause it to energize (click). This allows the interface to sense the circuit being opened/closed either by the closer or by tapping/releasing the knob.
However, if the loop is open (the closer is open and the knob is up) the sounder cannot be driven. That isn't the case when a separate key and sounder interface is used. In that case, there isn't a loop, so the sounder doesn't depend on the key being closed.

So, with either the loop interface or separate key and sounder interfaces we should be able to allow the port to be configured while still providing an option to enable/disable the sounder output. That allows the port to be configured and remain configured rather than having to clear it out to disable the sounder (which then also disables the key).

@AESilky You're right on all those points.
As far as options are concerned, we already have the --sound and --sounder options to enable/disable the audio and the sounder. The way --sounder is currently implemented should be changed along the lines of your proposal for keeping the port configured so the key is still active.
MKOB's 'Circuit Closer' checkbox effectively controls whether the key is active. It still needs to be implemented. Similarly, the 'Code Sender On' checkbox controls whether the keyboard is active. It too needs to be implemented.
The other config option we need is --echo, to support the sounder driver scenario.

I'm trying to think (it hurts)... I understand the need for 'echo' when using the sounder (only) interface, but would it also be needed with the loop/kob interface or is that automatic in that case?
So 'Circuit Closer' is needed in addition to the closer on the key? Or is that only for simulating the closer when there isn't a physical key present?
I would like to be able to keep 'port' configured (so I don't need to track down the correct value each time I want to use it after clearing out the value in order to disable the sounder. If the port is configured but isn't found I think a simple status message saying that it wasn't found and the key-sounder will not be available is adequate (rather than the error message that is currently output).
Maybe a discussion on these options along with how the three different 'latched' flags work would be a good zoom session?
-Ed

When using a separate sounder, is there a case where you would want the sounder enabled and not want the local key sounded. I just figured it would always be echoed such that, if the sounder is enabled, you get the incoming code from the wire as well as the code from the local key sounded. If the sounder is disabled, you don't get any sounder output.

I'm trying to think (it hurts)...

Now you know what it's like for me all the time! :-)

I understand the need for 'echo' when using the sounder (only) interface, but would it also be needed with the loop/kob interface or is that automatic in that case?

'echo' is neither necessary nor desirable when using a loop interface. It's preferable to have the loop constantly energized in this case, although it seems to work even if the sounder output to the interface follows the input from the key.

So 'Circuit Closer' is needed in addition to the closer on the key? Or is that only for simulating the closer when there isn't a physical key present?

It's only needed when the key doesn't have its own shorting lever. This makes more sense in the context of MorseKOB's history, which spans almost twenty years and largely reflects my own history with American Morse. For most of that time, none of my keys had a shorting switch. My workaround was to add the 'Circuit Closer' checkbox. I found it awkward to use the mouse to click on the checkbox at the beginning and end of each transmission, so I added the option of using the Escape key to toggle the state of the checkbox. This worked out very well in practice.
For reasons that made sense at the time, I also used the Escape key to regain control of the wire if a remote user left the circuit open. This too has been a very useful feature. However, this overloading of the function of the Escape key seems unfortunate in retrospect. I think separate keys should be used for the two functions, but honestly I can't decide which function should be assigned to the Escape key and which key should be used for the other function. I don't have a feel for how many users are getting by without a circuit closer on their key; I do know that users in general appreciate being able to regain control of the wire and they instinctively reach for the Escape key when it's occasionally needed. Decisions, decisions...

I would like to be able to keep 'port' configured (so I don't need to track down the correct value each time I want to use it after clearing out the value in order to disable the sounder. If the port is configured but isn't found I think a simple status message saying that it wasn't found and the key-sounder will not be available is adequate (rather than the error message that is currently output).

I totally agree with this.

Maybe a discussion on these options along with how the three different 'latched' flags work would be a good zoom session?

Definitely!

-Ed

~Les

When using a separate sounder, is there a case where you would want the sounder enabled and not want the local key sounded. I just figured it would always be echoed such that, if the sounder is enabled, you get the incoming code from the wire as well as the code from the local key sounded. If the sounder is disabled, you don't get any sounder output.

I can't think of a case where you'd want the sounder enabled but not have it follow the key.

This was implemented some time ago. Not sure of the exact version.


Leverage new VS Code localization API

VS Code is introducing a new API for localization: https://code.visualstudio.com/updates/v1_72#_localization-as-part-of-the-api
We should:

review the localizable strings that we have in package.nls.json, leaving only those that are referenced by package.json (and thus cannot leverage the new API)
convert all the only-used-from-code strings to use the new API

The API isn't totally formalized, so there is a likelihood of it changing in the next release (causing backward incompatibility issues).

@tonybaloney roger. That is why this issue is in "Backlog" milestone.


How do I use it like LSTMLayer in torch

I want to use this code like Torch.nn.LSTM, but I'm having problems with the data applied to (batch, len, emb), and I sincerely request that you continue to present the code in batch

If you prefer to have the batch dimension first, you can set the batch_first=True parameter when initializing the LSTM. This changes the expected input shape to (batch, seq_len, input_size).
import torch
import torch.nn as nn
from torch.nn.utils.rnn import pad_sequence, pack_padded_sequence, pad_packed_sequence
Example parameters
input_size = 10  # Number of features per timestep
hidden_size = 20 # Number of features in hidden state
num_layers = 2   # Number of recurrent layers
Creating the LSTM
lstm = nn.LSTM(input_size, hidden_size, num_layers, batch_first=True)
Example data (list of tensors of varying lengths)
data = [torch.randn(5, input_size), torch.randn(3, input_size), torch.randn(6, input_size)]
Padding sequences and creating a batch
padded_data = pad_sequence(data, batch_first=True)
lengths = torch.tensor([len(x) for x in data])
Packing the padded sequences
packed_input = pack_padded_sequence(padded_data, lengths.cpu(), batch_first=True, enforce_sorted=False)
Feeding the packed batch to the LSTM
packed_output, (hidden, cell) = lstm(packed_input)
Unpacking the output
output, output_lengths = pad_packed_sequence(packed_output, batch_first=True)
Processing outputs...
print(output.shape)  # [batch, seq_len, num_directions * hidden_size]


MM: Mini-Game and a Few Misc. Speed-ups

Splitting off from the issue I made in December.

[x] Swamp & Town Archery Double Rewards (so when you get the Perfect scores for both you get both rewards)
[x] Swamp Archery Points Speed-up (when it's tallying the timer to your score, in MMR it tallies this really fast)
[x] Termina Field Scrub Shorter Route (no extra loop, have the scrub go straight to the grotto)
[x] Dog Race - Yellow Dog is guaranteed to win the race if Mask of Truth is in your inventory. You do not need to take it out and check the dog, Yellow Dog will just win. In MMR it checks your inventory for this speed-up. If you can't replicate this exactly then it's perfectly okay to do it in a different way as long as Yellow Dog is what will be guaranteed to win when you have MoT.
[x] Good RNG for Dampe Digging in Ikana Graveyard - Two dirt patches on the ground, one above. The MMR community decided on the one near the stairs as you come in to talk to Dampe, then the one in the middle, and then the dirt patch on the platform with the ladder. Those are the 3 fastest dirt patches.
[x] Boat Archery - End the Mini-game when you have 20 points exactly (20 points is the requirement to get the reward)
[x] Southern Swamp Boat Cruise Speed-up - When you ride the boat, it moves faster in MMR so this speed-up being here would be nice (only for the boat cruise, the archery boat above iirc keeps its same speed).
[x] Apply a similar speed-up to the boat leading you to the Fisherman Game (MMR has this as well). It DOES slow down when you get near the Fisherman on the island, though.
[x] Fisherman Game - End the Mini-game when you have 20 points exactly (20 points is the requirement to get the reward)
[ ] Milk Bar Performance for Gorman - In MMR all song replays are skipped (so only the initial play from the player is done) and all interactions/reactions from the Zora and Gorman are skipped except for the final one when he gives you the item.
[x] Skip Sakon running around after saving Old Lady, fadeout to when she is giving you the item after you save her.

Relevant locations for some of these things from MMR if it helps any:
https://github.com/ZoeyZolotova/mm-rando/blob/dev/assembly/c/Fisherman.c
https://github.com/ZoeyZolotova/mm-rando/blob/dev/assembly/c/BoatCruise.c
https://github.com/ZoeyZolotova/mm-rando/blob/dev/assembly/c/Sakon.c
https://github.com/ZoeyZolotova/mm-rando/blob/dev/assembly/c/Toto.c

The Milk Bar performance is a bit of a pain with assembly patches, but with the overlay system it should be much more manageable.


signature problem

Hello!
Firstly I want to thank you for an excellent program to help make the report.
But, unfortunately, we have the result of her work is not correct.
Surely it is not connected with the program, because in other companies its working correctly. However, we do not have any ideas about the cause of the error.
The essence of the following errors. When signing our file *** paylod.xml all the added code (both counting and key) is located in one line long 3200 characters. Therefore, when checking the file in the IRS we are notified with an code NTD.
Do you have any idea of the cause of this problem and how to solve it?
Sincerely, Roman
Sorry for the poor quality of my English

That NTD is usually caused by prohibited characters. It may be in your XML or in the digital signature itself. If it is the digital signature, it is usually in the x509SubjectName element. Depending on your certificate, you may find that double quotes were introduced there. If that is the case, you can just remove that element. It isn't necessary for the validation in IDES.
If the digital signature looks ok, check the rest of the XML contents for prohibited characters. Remember that any apostrophe or double quote will need to be replaced with an entity reference or removed. The entire list of character restrictions is posted at http://www.irs.gov/Businesses/Corporations/FATCA-XML-Schema-Best-Practices-for-Form-8966.

Thank You for answer)) I understand this things and check file for prohibited characters. No one found there. I think in my keys NTD connected with length of signature line. Usually after adding signature it looking inside xml like many lines block, but in our file its one line with 3200 characters, and  i'm sure what IRS system not pass checking by this reason. Now we try prepeare file on java version of Your app.

I don't think it is the length. Even our sample signed file has that same line, which is just under 2600 characters for that one.
If you have a test signed file, you can send it over to<EMAIL_ADDRESS>and someone can take a look at it.

Thanks a lot! I send it now, before nobody from IRS not answer to us.
Thank You really help us)

Bingo!)) We already recive answer from IRS and You was absolutle right, our x509SubjectName content prohibited character. But we cant change our private key. Can You advise us: can we change You program before compillation to exclude x509SubjectName stringe from Paylod??

I know this is closed, but just in case anyone else runs into this issue, the KeyInfo can be removed from the signature by removing or commenting out this line in the SignEnvelopingXML method in the XmlManager file. The KeyInfo is not required for IDES. It will validate the signature by using the certificate that was used for enrollment.
signed.KeyInfo = CreateKeyInfoFromCertificate(certificate);


How can I get the activation value of each layer?

I want to see the actual activation values for each layer i, f(W_i * x + b), after each epoch(if this is possible)  Is there a way to see it?

Sure, you can. See the answer to this question: https://github.com/fchollet/keras/issues/41

Oh thanks, but is there a way to do it after each epoch?

Of course. Just run your epochs one at a time. With model.fit(X, y, nb_epoch=1), for instance.

Thanks for the quick reply

@ghost,i use the graph model. But there is something wrong.

model = graph()
model.add_input(name='input0',input_shape=())
model.add_node(Convolution2D(),name='c1',input='input0')
.......

And i want to see the output of the c1,Then

getFeatureMap = theano.function(model.inputs['input0'].input,model.nodes['c1'].get_output(train=False),
allow_input_downcast=True)
But it show me that
TypeError: list indices must be integers, not str
Do you give me some advice,please. Thanks.

More generally you can visualise the output/activations of every layer of your model. I wrote an example with MNIST to show how here:
https://github.com/philipperemy/keras-visualize-activations
So far it's the less painful I've seen.


examples/__init__.py missing in pypi source

I found out that building the tarball hosted on pypi will not include the examples directory (independent of $DEVITO_BENCHMARKS). It seems the file examples/__init__.py is not present in the tarball:
[stesachs@ip-10-8-209-211 devito]$ curl -sOL https://files.pythonhosted.org/packages/a7/f9/d9c8d1cadf404a4ada70746595896aad6c0e8e1584c1711f1015d280c2ee/devito-4.6.2.tar.gz
[stesachs@ip-10-8-209-211 devito]$ tar xf devito-4.6.2.tar.gz
[stesachs@ip-10-8-209-211 devito]$ cd devito-4.6.2/
[stesachs@ip-10-8-209-211 devito-4.6.2]$ python '-m' 'pip' '-vvv' '--no-input' '--no-cache-dir' '--disable-pip-version-check' 'install' '--no-deps' '--ignore-installed' '--no-build-isolation' '--no-warn-script-location' '--no-index' '--prefix=~/py-devito-4.6.2-byhand' --force-reinstall '.' |& grep -c examples
0
[stesachs@ip-10-8-209-211 devito-4.6.2]$ touch examples/__init__.py
[stesachs@ip-10-8-209-211 devito-4.6.2]$ python '-m' 'pip' '-vvv' '--no-input' '--no-cache-dir' '--disable-pip-version-check' 'install' '--no-deps' '--ignore-installed' '--no-build-isolation' '--no-warn-script-location' '--no-index' '--prefix=~/py-devito-4.6.2-byhand' --force-reinstall '.' |& grep -c examples
160

Please let me know if this is the wrong place to post the issue.

Hi @stephenmsachs ,
this is on our list to fix soon, there a number of reasons we do not include examples in the pip installation.
Also the examples directory are not in a sense core component of the devito dsl and compiler framework, as they just showcase examples of how you can use the DSL to model problems.
I am assuming that you want to run examples and benchmark some of them.
We are also currently updating this in this PR: https://github.com/devitocodes/devito/pull/1920/files
Is there any specific reason that the below path will not work for you?
 # Clone Devito
 git clone https://github.com/devitocodes/devito.git
 cd devito

For a Python3 virtual environment:
python3 -m venv /path/to/new/virtual/environment
source activate /path/to/new/virtual/environment/bin/activate

For a Conda environment:
conda create -n devito
conda activate devito

and finally, install Devito along with any extra dependencies:
pip install -e .
 # To install additional dependencies
 # pip install -e .[extras,mpi,nvidia]

Hi @georgebisbas,
Thanks for the quick reply.
I am actually developing a Spack package for devito. Spack installs Python packages by downloading the tarball from pypi and then running pip install . inside the sources. For now I have added a touch examples/__init__.py in the spack package. I'l update once there is a PR.

FYI this is the PR to add devito tp Spack: https://github.com/spack/spack/pull/31495

Thank you @stephenmsachs !

@stephenmsachs would you like to point us to any resources wrt Devito in Spack?

@stephenmsachs would you like to point us to any resources wrt Devito in Spack?

Not sure hat you mean by resources. There is a Spack package to build Devito here. You can build this via spack install py-devito.  They use pypi under the hood, so at the time I could only add v4.6.2. Also, no GPU support yet.

@stephenmsachs I have not forgotten about this, just left in side for a moment.
In addition, the examples are not really part of the Devito DSL and compiler framework but rather examples of using the DSL to model practical applications. Having this in my TODO list.

Is this still an issue?


PUB-903 Add KV Policy module to whitelist

JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/PUB-903
Change description
Add KV Policy module to whitelist
Does this PR introduce a breaking change? (check one with "x")
[ ] Yes
[ X ] No

not required


Missing metrics after first-time-install

Simply put, my problem is that I am not seeing the "promised" metrics in Prometheus that are linked here.
I have apiconnect-trawler installed in a cluster on which API Connect is installed in a namespace in my "monitoring" namespace. After some initial problems, it has been running for a week now. Now I wanted to use metrics like apiconnect_health_status or datapower_gateway_peering_primary_info.
API Connect:

Manager:

DataPower: too much, more than documented ...
Analytics:

Cert monitoring: Is working as aspected.
Is it possible that I have a configuration error? Have the metrics simply been implemented yet?
trawler:
  frequency: 10
  use_kubeconfig: false
logging:
  level: debug
  format: json
prometheus:
  port: 63512
  enabled: true
graphite:
  enabled: false
nets:
  datapower:
    enabled: true
    timeout: 5
    username: admin
    namespace: apic
  manager:
    enabled: true
    username: admin
    namespace: apic
    max_frequency: 300
    process_org_metrics: true
    grant_type: password
  analytics:
    enabled: true
    namespace: apic
  certs:
    enabled: true
  product:
    enabled: true
    username: admin
    namespace: apic

Thanks for the bug report - seems there are two key issues:

whilst the gateway_peering status code was added, it's not being called in the main loop
I have a mistake in the config sample in the docs - where it says product it should say apiconnect

The gateway peering function fix is now in and v1.8.0 should be shortly available containing that and the custom analytics intervals and I've corrected the README as well
Thanks


Use terrain in example terra contract

Terrain has some constraints on the structure of code but might be more familiar for people to use.

Hello A support ticket has been opened for you. Talk to a Terra Network Dev on the Live support pageso that your issue can be looked into. CLICK HERE


Incremental backups technical advisory

This change is

@lnhsingh I think I used Reviewable wrong, but I have implemented those changes. Thanks.

@dt Would you give this a once-over to make sure it’s accurate?

Merging now. Thanks all.


Misleading error message when trying to define a function starting with an uppercase letter

It is forbidden to give a name starting with an uppercase letter to something which is not a constructor, such as:
let Wrong x = x

but the error message is misleading:
Identifier not found: [x]

The trouble is that this is parsed as
match x with Wrong x -> x
And it may actually be valid to write this if there is an x in scope.

Is this really parsed this way even without the in at the end?

This problem is still a there:
$ fstar.exe bug255.fst
./bug255.fst(3,14-3,15) : (Error) Identifier not found: [x]

Still present, but I think this is superseded by #1228.


Use redux-observable in getInitialProps

I'm wondering If I can use redux-observable epics that handle ajax calls inside getInitialProps?
Tried it and failed, because epics just react to actions that were already dispatched.
StackOverflow question

@Tomekmularczyk me too. i set redux-observable ajax call but getInitialProps action is failed....


@sgordon1024 design task

Update the Custom Category designs to be current with the app.  Make necessary design updates for improved flow.

This has pretty much been completed, and there may also be duplicate tickets i.e. #472


replaced link

as per user report #7860 , so i removed invalid lik and replaced wit correct link.

@tiburd Please merge this PR. Thanks


Node cmdlet conflicts with node.js command name

When PSGraph is installed, trying to execute node.js commands will instead autoload load the PSGraph module and overshadow calls to node.

This specific conflict is something I have been concerned about but haven't seen it been much of an issue. I have two ideas for a permanent fix, but it abuses the mechanics of PowerShell in a way that could be fragile and need a lot of testing. Not sure when I would get to it based on my current commitments.
I do have a few options you can do in the meantime to get unblocked:

The first hack you can do to is to edit the .psd1 file in the module and set

FunctionsToExport = "*"
This will stop auto loading for that module and you will have to call import-module or use #requires statements to load it.

Or you could turn off all module auto loading with $PSModuleAutoloadingPreference='None'

A third option is to not install the module but Save-Module to a different location and import it from that folder when you need it.

Hey, thanks for looking at this. Both propositions are fine (I lean toward the first one) but I do have a question:
Why not simply previs all module commands, eg: node > New-PSGNode, Row > New-PSGRow etc?

I implemented this module as a DSL and selected names that made sense in the context of creating graphs. It would be a breaking change at this point. But here are my options.

rename the commands and add aliases with the old names. Using an alias will not auto-import a model, but it will still collide after import.

Move the commands to the local scope of the graph command. This would remove them from the exported functions and they would only be valid when nested inside the graph command. Would break intellesense and possibly script analyzer. Would be hard to test.

Making those commands private may work as well as #2 without the issues related to testing (but still have the other issues.

Move the commands into a nested module that is imported into the parent scope when the main module is imported. They would not auto load on their own and not be part of the functions to export but would conflict after loading. Basically the same as #1 with different implementation.

Disable auto loading. Require the module to be explicitly loaded any time it should be used. This would be done by setting FunctionsToExport = "*".

As long as the graph command is still exported and auto loads the module, then the risk of breaking existing scripts is low as node is always used with graph.
I can optionally only fix node without touching the other graphing commands.


Adding styles on hover to labels as the user mouses over different names

Part of StyleSheet Switching Interface Project

I want work for this issue


Goobi/ITM packaged using Docker

Hello, what is the status of packaging Goobi for Docker?
I'm working at the University of Passau, we are also requiring a dockerized version of Goobi.
I have experience using Docker, I have packaged various applications; however, I'm new to Goobi.
Is there any way we can collaborate on this?

Hi @sepastian, thanks for reaching out on this. I'd love for our work here to be of use to you.
We're actually working with Intranda on this and it's them who are creating the Docker container. We will mention it to them and see if releasing the container they have created for us publicly is an option.
It might not be at this stage, as there are closed source parts of Goobi that we are paying for and I'm not sure how they've split up the containers for the initial phase of work.

Hi @jtweed, thanks for the update, I will keep an eye on this!


tags functionality in DWS SDK is not defined

Please add the API for GET /v1.0/{project_id}/clusters/tags as currently this is being used also by cloudmon and the collected metric is mis-interpreted as /cluster

@Persimmonboy
Look at: https://docs.otc.t-systems.com/data-warehouse-service/api-ref/api_description/tag_management_apis/querying_tags_in_a_specified_project.html

Need to add new class for Tags inside  SDK -> DWS -> V1
Add proxy method
Unit test for class and proxy method
Functional test
Feel free to ask any help


(WIP) Add flow: initial types

flow quick reference: http://flowtype.org/docs/quick-reference.html
Ref https://github.com/cst/cst/issues/42
I did npm i flow-bin -g and ran flow check<EMAIL_ADDRESS>Can potentially remove some of the jsdoc stuff? * @returns {String}

Interesting idea. Will take a closer look later.

The types here aren't that specific for a lot of stuff - but we can define our own types, etc. Stuff like Array<any> could be more specific.

Still have errors but fixed merge conflicts

Good job! Added some notes here.

Updated. We could also move types into separate files depending on how you want to do it. Also more examples of types - https://github.com/facebook/flow/tree/master/lib - maybe check out the react one too

Great job!


Release automation

Proposed changes
As we noticed several times, generating the release, changelog is not always consistent nor accurate.
To face that this PR brings several features:

One click release
Changelog generation
Framework & Browsers versions
Works on master and other branches.

Lifecycle changed a bit:

Create draft release
Generate tag
Build and attach artifacts (template, docker image,  runner bundle)
Publish release

Types of changes

[ ] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation Update (if none of the other choices apply)

Checklist

[ ] Lint and unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)

Further comments
Examples:

https://github.com/FriggaHel/sauce-playwright-runner/releases
https://github.com/FriggaHel/sauce-playwright-runner/actions

@tianfeng92 Resetting review since lots of changes happened since first approbation.
to all: It's preferable to take a look to the final script more that the diff, it would be easier to understand the flow :)


Centralize Voting Results of the German Bundesrat

The Bundesrat publishes its voting results on 16 different websites. Let's centralize them!
https://www.bundesrat.de/DE/plenum/abstimmung/abstimmung-node.html
So first, you have to extract the text from the text-based PDFs. Tools such as https://github.com/pdfminer/pdfminer.six could help. In the next step, you have to aggregate the results for each "Drucksache". Not sure how accurately the extracted will be. Maybe some manual data cleaning is necessary. To automacally scrape the results, you could put the scrapers on https://morph.io/.
Context: https://fragdenstaat.de/blog/2018/bundesrat-transparenz-klage/
Contact person: @jfilter

Also important: finding out how the voting works in detail: is there always a Drucksache (hint: no), which process and what part actually appears on the websites, is it the same for all states? But yes, this is a great project! Voting in Bundesrat has been a sort-of secret, you could be the first to find out patterns!

I created a separate repo for scraping this:
https://github.com/okfde/bundesrat-scraper


SBRPs are present in multiple locations during source-build

We have SBRPs in two locations during build:

prereqs/packages/previously-source-built/SourceBuildReferencePackages - extracted from PSB archive
prereqs/packages/reference - copied from location above, in init-build.proj. This location is also updated with newly built SBRPs, after deleting all existing content.

We shouldn't have SBRPs in prereqs/packages/previously-source-built/SourceBuildReferencePackages during build. The only scenario where packages from this location would be used is if we stopped building an SBRP package. An old package would be used and introduce a poison.
It's better to get a build failure, than to discover the issue while running tests in a poisoned build.

Fixed with https://github.com/dotnet/installer/pull/19114


recipy command fails on Windows due to blessings use

I thought blessings was compatible with Windows, but it seems not... Lots of errors about _curses.
Seems like the best way is to go for colorama instead.

Useful example of colorama use from my machine at work:
>>> import colorama
>>> print(colorama.Style.BRIGHT + 'Hello')
Hello
>>> print(colorama.Style.BRIGHT + 'Hello')
Hello
>>> print(colorama.Style.BRIGHT + 'Hello')
Hello
>>> print(colorama.Style.RESET_ALL + 'Hello')
Hello
>>> print(colorama.Style.BRIGHT + 'Hello')
Hello

Fixed in 2989db10491579486379584b9839d531f6d9a404


Added missing location parameter to create vnet command in configure-kubenet

Command to create virtual network along with subnet requires --location parameter, otherwise it fails with this error:
ERROR: (LocationRequired) The location property is required for this definition.

@asudbring

Can you review this PR?
IMPORTANT: When this content is ready to merge, you must add #sign-off in a comment or the approval may get overlooked.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#sign-off


Convert to swift4

@Keeeeen Thank you. Please squash your commits into one commit.

@Keeeeen
Nicely done.
Thanks.


Adds support for oauthToken Issue #659

Fixes #659

Can you please resolve the merge conflict?

How can I  resolve the merge conflict? I can not click the Revolve conflicts button on this page  because I have no authorities.

@zznnqq210 resolve them in your branch and push the changes


Stop using non-POSIX features in small test suite tests to avoid fake test failures

See original issue on GitLab
In GitLab by [Gitlab user @tlater] on Nov 15, 2019, 16:38
The following discussion from !1712 should be addressed:

[ ] [Gitlab user @cs-shadow] started a discussion:  (+3 comments)

Should we just use sh instead of bash? That would be available in even more scenarios, like mininal Docker images.
I don't think we are using any bash-specific features.

This was attempted, but our usage of echo -e and especially non-POSIX features of trap make it not totally trivial to do.

In GitLab by [Gitlab user @tlater] on Nov 21, 2019, 13:48
created merge request !1725 to address this issue

In GitLab by [Gitlab user @tlater] on Nov 21, 2019, 13:48
mentioned in merge request !1725

In GitLab by [Gitlab user @tlater] on Dec 9, 2019, 16:00
closed via merge request !1725

In GitLab by [Gitlab user @tlater] on Dec 9, 2019, 16:00
mentioned in commit c39c12ec8e5ea99de56f70904408dd41c037820d


Change  in Profile.js to meet A11Y requirements

Description
Problem
In the Profile.js component, the name surrounded by <h1> tags is followed by the username surrounded by <h4> tags.
W3C points out that it is necessary to keep the rank of headings in descending order and not skip a rank.

Skipping heading ranks can be confusing and should be avoided where possible: Make sure that a <h2> is not followed directly by an <h4>, for example.

For more information about A11Y in the context of headings, see the official documentation of W3C.
Solution
Change <h4> to <p> and add font-bold class to retain the styling and increase the percentage of lighthouse results.
Screenshots
Profile of a contributor

LIghthouse results

Additional information
No response

This is already fixed. Thanks for raising an issue and if you notice anything else that needs fixing don’t hesitate to raise another.


New sidebar "menu" icon still does nothing

Either remove it or make it do something.

It's going to scroll the menu out.
@LironRS is in final stages of implementing this.


Merging setttings.spacelift.labels / other fields

Describe the Feature
Merging imported Map and Array fields instead of them being overridden.
Expected Behavior
When I have the following two files:
# #1 -- catalog/stage-globals.yaml

terraform:
  components:
    example:
      settings:
        spacelift:
          labels:
            - testing

# #2 -- stage-internal.yaml

imports:
  - catalog/stage-globals

terraform:
  components:
    example:
      settings:
        spacelift:
          labels:
            - example

They result in the following:
# Result as terraform-spacelift-cloud-infrastructure-automation will see it.

terraform:
  components:
    example:
      settings:
        spacelift:
          labels:
            - testing
            - example

Use Case
When importing a catalog of generic config that includes settings.spacelift.labels for a component, the importing Stack's component labels take precedence and the imported labels are lost. This makes sense as the Stack config is preferring that it's an "override" mechanic instead of "merge" mechanic, which I'm sure is what we want in the majority of cases. But there are cases such as labels where it can make sense to merge the imported values into the overridden values as this allows DRYer configuration.
Describe Ideal Solution
Ideas:

A flag in the catalog file that enables merging > overriding for Maps + Arrays
A field in the catalog file that specifies which fields should be merged instead of overridden
A flag at the TF module layer to enable merging?
Plenty of other uglier ways to solve it... e.g. labelAdditions and similar which wouldn't be sustainable.

Alternatives Considered
Dropping this idea altogether 😅
Additional Context
This is obviously tricky and may be trying too hard in regards to making Atmos YAML configs DRY... but figured I should at least bring the idea up for discussion. I'm totally fine if the resolution is "Hey, we don't think that's a good idea, let's shelve it."

@nitrocode the main example I have was that I was trying to have one of my catalogs specify a label for all stage Stack components. But in some of my stage Stack components I would also need to add another label and that would nullify the imported catalog label that should be applied to all components. For example --
# #1 -- catalog/stage-globals.yaml

terraform:
  components:
    example:
      settings:
        spacelift:
          labels:
            - helloworld

    other:
      settings:
        spacelift:
          labels:
            - helloworld

# #2 -- stage-internal.yaml

imports:
  - catalog/stage-globals

terraform:
  components:
    example:
      settings:
        spacelift:
          labels:
            - anotherlabel
      vars: {}

    other:
      vars: {}

In the above, my other component will get the helloworld label, but my example component will not because it overrides labels and they're not merged.
This should definitely be low priority, because I have now refactored my client's Spacelift policy so they no longer need the shared label (i.e. helloworld above), BUT I could still see it being relevant.
Regarding your solution of labelsAsMap -- It's a bit funky of a solution (very similar to my suggestions above), but that would do the trick. I think a flag at the component's spacelift settings level that opted in that config's labels to get merged (e.g. concatLabels: true) would be the nicest, but after refactoring this problem away... I wonder if it is worth the trouble 😅

This is a tricky one. I'll add it to our architectural review board agenda.


LICENSE needs to be updated.

Copyright [yyyy] [name of copyright owner]

Thanks for your diligence and reporting this.
Traditionally one doesn't customize the apache license in this way. e.g. https://svn.apache.org/viewvc/httpd/httpd/trunk/LICENSE?revision=1824973&view=markup
Note that we use SPDX based headers with no copyright date. Because who wants to spend New Years Day updating copyright dates??


Why are there two thresholds?

Can you say what these two thresholds represent?
threshold and iou_threshold
Thank you！！！！

one(former) is to filter some anchors for cls score less than threhold , anthor(latter) is  to reduce the anchor number for overlap

one(former) is to filter some anchors for those cls-score less than threshold , anthor(latter) is to reduce some anchors  for overlap

one(former) is to filter some anchors for those cls-score less than threshold , anthor(latter) is to reduce some anchors for overlap

Thanks for the reply, why does the detection result not change after I adjust these two thresholds? I set both to 0.5, but there are still a lot of boxes.


Add option to use demo.processed.tif image to create the demo.pdf

Tesseract is doing a fantastic Job at processing the input image!
original demo.jpg size is 3614 Kb
tesseract demo.jpg out get.images
gives me
demo.processed.tif which is only 35 kb
I'd love to be able to use the very lightweight processed image to create the searchable pdf instead of the substantially heavier original image.
It seems that option isn't implemented, but tesseract project is massive so I might have overlook something?

Related feature request: #210


Update version for the next release (v0.8.2)

Bump the version for the incoming release

bors merge


Consider using Boost.Log for logging

We do not anticipate a lot of logging, but we need to at least log exceptions thrown by the application.
It would be nice if the logs included the usual metadata (severity, timestamps, etc.) and if they could be captured in the unit tests.
Since we are already linking with Boost, we could use Boost.Log

I thought about it, and I think it is a bad idea... great for examples, specially if we need to capture the log and write unit tests, but terrible because we need to coordinate the configuration with the user-code. It is better if the framework remains agnostic about such things.
We can add structured logging to our error messages with minimal effort, and should do so:
https://cloud.google.com/functions/docs/monitoring/logging#writing_structured_logs


Use default credential names if credential names are not set

Use nutanix-credentials as NutanixDatacenterConfig credentialRef name if it is not present. This ensures we don't get a nil-pointer dereference during upgrade and upgrade can happen smoothly.
How has this been tested?

Created a cluster using a EKS-A CLI build before FCL changes were merged (NutanixDatacenterConfig spec had no credentialRef)
Upgraded the cluster successfully using an EKS-A CLI build with these changes included and using the same cluster spec as above (no credentialRef set on NutanixDatacenterConfig).

Full upgrade logs: https://app.warp.dev/block/w7d8Ic3TrSign6eYTeRv55

/lgtm

Thanks Sid! You PR looks good. Can you pl update our doc to include this field under NutanixDatacenter spec?

Sure, should we do that in a separate PR?

Could you clarify the situation this arises?

Use nutanix-credentials as NutanixDatacenterConfig credentialRef name if it is not present.

Could you clarify the situation this arises?

Use nutanix-credentials as NutanixDatacenterConfig credentialRef name if it is not present.

An EKS-A cluster created before the

Could you clarify the situation this arises?

Use nutanix-credentials as NutanixDatacenterConfig credentialRef name if it is not present.

This is in a brownfield upgrade path. So consider a case where a EKS-A cluster spec was generated and a cluster created with a EKS-A CLI built prior to our credentialRef+ FCL changes. Now upgrade the cluster with the latest EKS-A CLI changes.

/lgtm


Mina external snark worker might be stuck

After running in berkeleynet normally for a while, the snark worker received a job and didn't report snark back for 45 minutes, until the job has been cancelled by the node (most likely because some other snarker produced the snark for it). After that node continued producing snarks, until it stuck again after several jobs.
snark worker image: openmina/mina-snark-worker-prover:0.0.7

Here's the grepped output from the snark worker, first and last entries indicate stuck jobs:
2023-08-21T15:28:54.560511Z  INFO openmina::commands::snarker::ext_snark_worker: time: "1692631734560500629", source: "external snark worker", "SNARK work $work_ids received. Starting proof generation"
2023-08-21T16:13:48.536332Z  INFO openmina::commands::snarker::ext_snark_worker: time: "1692634428536317875", source: "external snark worker", "Kill signal sent to child: $pid"
2023-08-21T16:13:48.663157Z  INFO openmina::commands::snarker::ext_snark_worker: time: "1692634428663141440", source: "external snark worker", "EOF from worker subprocess after cancel request"
2023-08-21T16:13:48.663282Z  INFO openmina::commands::snarker::ext_snark_worker: time: "1692634428663279797", source: "external snark worker", "Child exited ($pid): $status"
2023-08-21T16:13:48.697113Z  INFO openmina::commands::snarker::ext_snark_worker: time: "1692634428697109267", source: "external snark worker", "Forked, child PID: $pid"
2023-08-21T16:13:48.729102Z  INFO openmina::commands::snarker::ext_snark_worker: time: "1692634428729097314", source: "external snark worker", "SNARK work $work_ids received. Starting proof generation"
2023-08-21T16:14:46.038891Z  INFO openmina::commands::snarker::ext_snark_worker: time: "1692634486038877237", source: "external snark worker", "Proof generated successfully"
2023-08-21T16:14:46.051757Z  INFO openmina::commands::snarker::ext_snark_worker: time: "1692634486051743795", source: "external snark worker", "SNARK work $work_ids received. Starting proof generation"
2023-08-21T16:15:02.625867Z  INFO openmina::commands::snarker::ext_snark_worker: time: "1692634502625853524", source: "external snark worker", "Proof generated successfully"
...
2023-08-21T16:17:02.613017Z  INFO openmina::commands::snarker::ext_snark_worker: time: "1692634622613013126", source: "external snark worker", "SNARK work $work_ids received. Starting proof generation"
2023-08-21T16:17:19.071507Z  INFO openmina::commands::snarker::ext_snark_worker: time: "1692634639071489341", source: "external snark worker", "Proof generated successfully"
2023-08-21T16:17:19.081145Z  INFO openmina::commands::snarker::ext_snark_worker: time: "1692634639081140388", source: "external snark worker", "SNARK work $work_ids received. Starting proof generation"

In order to reproduce the issue with bare snark worker, I'm going to record snark specs being worked on.
To fix this, there are several options:

find and fix the issue on OCaml side
make openmina cancel jobs taking too long
restart "backend" OCaml snarker for each new job

The former two are complimentary, and the last one looks like a w/a to me.
@tizoc FYI

For now, with cancellation on timeout and Bruno's fix, this might be closed.

For now, with cancellation on timeout and Bruno's fix, this might be closed.


Unable to start

I have install the requirements.
But I got
import Server from 'squad-server'; SyntaxError: Cannot use import statement outside a module
Error, I tried to use babel or it's unable to use 'import' function.
Could you tell me how you config your enviroment, I am a very new guy to Node.JS.
Forgive me for my rashness, thank you.

What Node.js version are you using?

What Node.js version are you using?

I have tried 12.16.1 and 12.10.0

Please ensure you follow the guidance in the readme.
The current Nodejs version is needed, which is 13.12.0. It can be downloaded here.


Add a Gitter chat badge to README.md

patternfly/angular-patternfly now has a Chat Room on Gitter
@dtaylor113 has just created a chat room. You can visit it here: https://gitter.im/patternfly/angular-patternfly.
This pull-request adds this badge to your README.md:

If my aim is a little off, please let me know.
Happy chatting.
PS: Click here if you would prefer not to receive automatic pull-requests from Gitter in future.

LGTM


pundle-cli can't find its entry

${ project root } replaces with my actual path for privacy
> yarn add<EMAIL_ADDRESS>
> $(yarn bin)/pundle
Error Cannot find module '${ project root }/src/mount.tsx'

> cat ${ project root }/src/mount.tsx
import * as React from 'react';
import * as ReactDOM from 'react-dom';

import Main from './components/Main';

ReactDOM.render(
  <Main />,
  document.getElementById('root')
);

if (module.hot) {
  module.hot.accept()
}

> cat Pundleconfig.js
module.exports = {
  entry: [require.resolve('./src/mount.tsx')],
  pathType: 'filePath',
  rootDirectory: __dirname,
  replaceVariables: {
    'process.env.NODE_ENV': 'development',
  },
}

Adding typescript didn't help:
module.exports = {
  entry: [require.resolve('./src/mount.tsx')],
  pathType: 'filePath',
  rootDirectory: __dirname,
  replaceVariables: {
    'process.env.NODE_ENV': 'development',
  },

  components: [
    [
      require.resolve('pundle-transformer-typescript'),
      {
        config: {
          compilerOptions: {
            jsx: 'react',
            strictNullChecks: true,
          }
        },
        include: ['*.ts', '*.tsx'],
      }
    ],
  ]
}

That's because the Pundle package is bare bones by default. To make it recognize this extension or any extension, we have to add the resolver component (you are also gonna need others like generators etc). So I would recommend you use the pundle-preset-default package like
module.exports = {
  presets: [
    [require.resolve('pundle-preset-default'), {
      resolver: { extensions: ['', '.js', '.tsx', '.ts', '.json'] }
    }]
  ]
}

I'll push an update soon where these extensions will be automatically derived from all registered loaders so you just have to give it the path to the preset

@appsforartists Are you on any slack? I don't usually feel comfortable using Github issues for PM but the Alpha1 had a bug in JS loader that caused a lot of apps to crash. I've fixed it in the branch so just a heads up

Nah - we use Discord because Slack kicked off Reactiflux, so we avoid using it for OSS projects.  I could always sign up, but I can't promise I'll remember to use it.

@appsforartists I'm steel-brain#5289 on discord

Pundle@2 second alpha automatically determines the extensions based on the loader components. Thinking about adding support for transformer components too

Closing as this is no longer relevant


iOS support viability discussion

I am starting ecapture and I just want to open the topic of having iOS support. iOS is based on macOS so as I understand it is not in scope right now. SSL Pinning is a huge issue in iOS and this can be a good way to bypass it

eCapture is a software implemented based on eBPF technology, and eBPF is a dynamic instrumentation solution provided by the Linux kernel. Currently, there are no plans to support these on macOS/iOS. Therefore, eCapture does not support macOS/iOS.

close with no response.


litmus-portal(): Refactoring in GQL Server

Changes-

Changing GetCluster function to use findOne operation instead of find
Generalize some function
Refactor the directory structure.
Changing the name of some env variable to some meaningful names
Generating resolvers for the Workflow schema
Adding a function to instantiate stateData struct
ref- https://github.com/litmuschaos/litmus/blob/litmus-portal/litmus-portal/backend/graphql-server/pkg/data-store/store.go#L10
Separating mongodb struct from gql struct.
Making UpdateCluster and UpdateClusterData more generic.

I am going to merge this PR after the circleci build passed. cc @gdsoumya


Sold Out - las delicias + Banegas Farm

dApp : https://app.carbonable.io/launchpad/forest-regeneration-banegas-farm-costa-rica

mettre les projets (las delicias et Banegas Farm) soldout
Funding 100%
Mettre le bon bouton (Claim your sft)

Clean Out - Transition

@schwepps potneitally need to hardcode it. Let synch with @cloudvenger

@cloudvenger @MartianGreed I think we just need to force is_soldout in the indexer and it will fix everything at once.

Agreed

Done

Closing as done by @MartianGreed on backend side.


can't run get_start tutorial

hello, i'm new in tvm. i encounter some problem when i run get_start.py in tutorial, i'd appreciate if someone can help me out, thanks in advance.
here are my basic experiment configuration:

run tvm in ubutu 16 VM
install llvm, cuda-compiler, but didn't install nvidia driver, because of my vm can't access my nvidia graphic card.
install python following the install doc. and my python version is 3.5.
set flags (use_cuda, cuda_path, llvm-config-5.0) in config.mkrun make, succeed.

here is my problem:

fadd_cuda = tvm.build(s, [A, B, C], "cuda", target_host="llvm", name="myadd")
my error is cuda is not enable.

the tutorial will indeed need a real cuda machine to run nvidia code. But you can also explore other targets like cpu or target supported by y9our machine

you can also directly browse the tutorials via http://docs.tvmlang.org/tutorials/index.html

thanks for you prompt reply.
i have one more question, i want to run it on ARM, is there example talking about how to do it?

http://docs.tvmlang.org/tutorials/deployment/cross_compilation_and_rpc.html#sphx-glr-tutorials-deployment-cross-compilation-and-rpc-py


[Question] Do internal ping messages count for Azure plan limit ?

Currently, the Free Plan has a limit of 20K messages/day/unit.
Do internal ping messages count too?
For one client, if ping to server are enabled to be sent each 15 seconds:
2 / minute => 120 / h => 2 880 / day
So both ways for a client will be about 6 000 messages only for the infrastructure...

Yes, the ping message is counted now. We didn't realize the amount is so huge and we're now investigating a better solution.

Thank you for the acknowledge. Would you please update this issue when you have new information?
I believe this is an issue for the Standard Plans too, so I might suggest to have that in mind too.

Hi, I've just deployed azure signalr (and did it late at night to make sure didn't affect too many users if it went wrong at all). Only 300 clients are connected at this time but I've already used up almost 70k messages. Is this the internal pings? I don't think anyone will actually be interacting with the hub at this time. Just a bit worried about hitting my limits! Have attached photo of the azure metrics. Thanks in advance.

A good news is we start to stop counting ping message (server -> client or client -> server). But it's won't apply to your existing service immediately automatically. A quick way to approach that is to deploy a new signalr service or you can wait for us updating all the existing services.
@lbargery according to you client count, I thinks it's ping message. You can try the practice above. (Now available in WestUS, EastUS, WestUS2, SoutheastAsia, WestEurope and waiting for a few days for other regions)

@zackliu Thanks this seems to be fine now!


[PORT] Remove functional test setup from the signed build.

Port this change from botbuilder-dotnet/master branch:
https://github.com/microsoft/botbuilder-dotnet/pull/3948

The signed build is no longer used for running functional tests.

N/A


Module name overrides in Ceylon embedded runner

[@FroMage] For Vert.x we need to be able to map module names such as io.vertx.core/2.1.2 to vertx-core-2.1.2.jar. This could be limited to flat repositories and Java, but given how we set up the repository manager for the Java compiler, and how we pass its settings using a list of String arguments, it would take a day to set up properly and test.
At the same time, perhaps this should just be merged with the Maven overrides and the future assemblies. So delaying until the next release for now.
[Migrated from ceylon/ceylon.language#564]

@FroMage is this issue still alive, or should we close it?

Still alive, it would reduce vert.x/ceylon size.


Add basic users endpoint

This adds a basic endpoint for users, with tests!
I added in:

Guardian, although it's not being used yet
Comeonin with BCrypt for hashing passwords; later can be used to authenticate
Users with:

Migration
Virtual password field in schema
Controller tests

JSON API serialization with:

Error view
Changeset view
User view

It's important to note that by default Phoenix uses the JSON API recommended dasherized keys. We should probably switch to dasherized keys in our API as a result.
This is still missing many of the user model's attributes and validations, slugged route creation on signup, etc. Also missing some model tests.
I figure it's better to keep this PR smaller than not, so many of these things can be added later.

@barruumrex How does the rest of the PR look to you? I'd like to add new things separately, but if things need fixed here, then I'll obviously do that in this PR.
Also would really like to see about how to transition from our Rails-esque Postgres DB to the Phoenix-esque one. I think there are bound to be differences in naming, etc. Need to think that through more.

Looks pretty solid to me 👍

Looks pretty good to me. The controller testing feels fat to me (the tests go all the way down to the db and back), but that's not really a problem at this stage in the project. Definitely something we can put off until it becomes a problem in practice.
As far as converting the database, I don't expect to see much issue with that. Ecto is pretty flexible and shouldn't have difficulty dealing with an AR style db. However, I don't have direct experience with making that transition.


Pruning gh-pages

I don't think you want node_modules added into gh-pages branch. It is gitignore'd in the master branch, but there is no gitignore in the gh-pages branch.
Happy to add a pull request to add a gitgnore if that's desired.

ah, very good catch. I'm tracking this in https://github.com/cvan/ghpages/issues/3.


fix "Chart.lock is out of sync with Chart.yaml"

fixed #7101
I have found that downloadAll() might overwrite version in Chart.lock.
It's because this function will download a specific version of chart to dir "charts/" and then the specific version will overwrite the version in Chart.lock.
My solution is recalculate lock digest after downloadAll().

Hi! Can you write a test to confirm this behaviour? Thanks!

@bacongobbler Hi, I added a test case for this issue.

@hickeyma Hi, I have renamed the testcase already.


Fix the aws_vpc sync bug

Resolves #455

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Relate TUF design to Notary v2 goals

Based on discussion in the last meeting, I added a section to clarify why the TUF design is being proposed that puts on paper some of what has previously been discussed in meetings about the use of TUF in Notary v2.

@SteveLasker Thanks for the review! I added some clarifications inline to address many of your comments.

Updating fully qualified references to artifacts

The initial signature should be fully intact. Including what registry it originated from. No change to the content, or the wraper. This is the integrity check.

In this case, what would a registry do if they want to maintain this original signature as well as re-sign it? Should they re-sign using the original fully qualified reference? I can see two possible options here, in one the signature is copied and the original signer is the primary party trusted to sign the image. In this case any additional signatures would have to match the original name so they could have an exact match. In the other, the artifact is being copied into a private registry and the copier is the party trusted to sign it. In this case, it may be desirable to sign the image using the fully qualified reference in the new registry.
There may also be an in-between option that allows only the last part of the name to match, but this raises questions about the scope of namespaces.

Hiding images from other users

This section implies Coke & Pepsi content can be aggregated in some way, even at some anonymized leve is not permitted.
It's great to see the requirements get added and covered. The concerns over immutability, and how much updating of content must be maintained is of great concern.
Consider we might etched all the immutable content pushed to a registry in glass (Project Silica). The basic premise of TUF suggests a continual service runs to continually update snapshot and timestamps of all data. The vast majority of registry content is immutable. Following best tagging practices, even the tags should be unique, with the important exception of stable tags. And, we do need a solution for tag signing/locking. However, I'd suggest we should be focusing on a solution that doesn't require all data must be continually updated to assure it's still valid. It's a non-scalable solution. If the computers stop processing the data, because the data was etched in glass, put in a mountain, revived years later, is that data considered invalid?

Users who need to download an image today have different security requirements than users who want to download an image from a mountain years later. Users today need a way to ensure that the signature they are verifying was signed by a key that was valid today, and not compromised or expired. This is vital to any mechanism that prioritizes key revocation. Users years from now have the benefit of hindsight to avoid compromised packages, and so can ignore timestamps when verifying metadata. I would argue that it is more important to ensure that users today are downloading secure software than it is to ensure that future users don’t have to override a timestamp check when using legacy software.

I'm going to close this in favor of a discussion of goals on the tuf-notary repository.


Allow to get solution with null bias ptr

For https://ontrack-internal.amd.com/browse/SWDEV-443028
Bias ptr is only necessary when launching gemm kernel.
This PR is used for aligning behavior with cublaslt.

90a CI test pass.
http://math-ci.amd.com/blue/organizations/jenkins/main%2Fprecheckin%2FhipBLASLt/detail/PR-748/1/pipeline/481


Update msixmgr-tool-syntax-description.md

Re-ordered a few parameters and added examples contextually.

#sign-off


Default<EMAIL_ADDRESS>and store password don't work

Describe the bug
The user<EMAIL_ADDRESS>and password store provided in the readme.md does not seem to work.
To Reproduce
Steps to reproduce the behavior:

Follow readme.md for clean installation
go to /episerver/cms
Login with<EMAIL_ADDRESS>and store
Check logs, see that password is invalid.

2022-02-08 10:05:28.684 +01:00 [WRN] Invalid password for user.

Expected behavior
Password should be accepted
Desktop (please complete the following information):

OS: Windows 10
Browser: Chrome 97.0.4692.99 (Official Build) (64-bit) (cohort: Stable)
Version: main branch:

<PackageReference Include="EPiServer.Commerce" Version="14.1.2" />
<PackageReference Include="EPiServer.CMS" Version="12.2.1" />

Additional context
In the end I was able to remove the password hash from the database and use the following code to set up a new password from the HomeController. When I provided the default store password it rejected it for being to short.
var user = await _userManager.Users.FirstOrDefaultAsync(x => x.UserName == "admin@example.com");
var result = await _userManager.AddPasswordAsync(user, "MyFancyStore123!");

We will update the readme.md file to show the new default password

Ah shoot, I was looking at the master branch wile running main.
If this ever shows up in Google, this was on the main branch readme.md:
Foundation has a default username and password of<EMAIL_ADDRESS>/ Episerver123!


Intermediate files for entity linking

Hi, thank you for your great work. I was wondering could you provide the intermediate files during annotation? The main thing is the Wikidata Qids of each entities. I believe they are somewhat similar to the distant files of ERICA repo.

这是来自QQ邮箱的自动回复邮件。

您好，我已经收到您的邮件，我会尽快给您回复的


Improve module search

The -I parameter is used to extend the search dir -- by default, including only the Prelude and CWD -- for module compilation.
The -no-prelude flag turns off the included Prelude libraries (though there's likely little use for it.)

bors r+


Possible to build on OSX 10.9.5? (No Metal)

Hi,
Is it possible to build bgfx on OSX 10.9.5?
When I try I get the following issue:
$ make osx-debug64
/Applications/Xcode.app/Contents/Developer/usr/bin/make -C .build/projects/gmake-osx config=debug64
==== Building bgfx (debug64) ====
==== Building bgfx-shared-lib (debug64) ====
Linking bgfx-shared-lib
ld: framework not found Metal
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [../../osx64_clang/bin/libbgfx-shared-libDebug.dylib] Error 1
make[1]: *** [bgfx-shared-lib] Error 2
make: *** [osx-debug64] Error 2

I've seen some of the other discussions saying newer versions of Xcode might help. I currently have version 6.2 6C131e, but I honestly have no idea whether any of the newer versions are compatible with my system (the App Store seems to be suggesting I update to a version that it specifically says will not work on my system, which does not seem very useful). Overall I'm afraid I'm not very familiar with Xcode as I tend to develop using either CLion or the command-line.
I also saw the discussions about weak_frameworks, so I searched my checkout to make sure all Metal linkages were as weak_frameworks; and I did in fact find a file that wasn't using them (scripts/texturev.lua), but fixing that didn't solve my above problem.
I realise I'm being a pain by using an old OS version, so please do just let me know if it's simply unrealistic for bgfx to work on my system - I'll understand! :)
Cheers!

Yeah, just build with BGFX_CONFIG_RENDERER_OPENGL=1, that will disable Metal on OSX.

Hi,
Thanks for the reply, this sounds very promising.
However, is there a recommended method to correctly set BGFX_CONFIG_RENDERER_OPENGL=1?
I have tried adding the following near the top of src/config.h:
#ifdef BGFX_CONFIG_RENDERER_OPENGL
#	undef BGFX_CONFIG_RENDERER_OPENGL
#endif
#define BGFX_CONFIG_RENDERER_OPENGL (1)

But unfortunately I'm still having the same problem.
Is there something I'm missing? Am I perhaps meant to be setting it as part of the build process somehow?

You can add it thru your project settings.
You can change https://github.com/bkaradzic/bgfx/blob/master/scripts/genie.lua#L362 to
   bgfxProject("", "StaticLib", { "BGFX_CONFIG_RENDERER_OPENGL=1" })

Or if you're in VS, you can change preprocessor settings to do the same...


NPOI.POIXMLException:“OOXML file structure broken/invalid - no core document found!”

Hi,
cannot open xlsx file with exception   NPOI.POIXMLException:“OOXML file structure broken/invalid - no core document found!”:
            IWorkbook wb = null;
            try {
                FileStream fs = new FileStream(FileNames[f], FileMode.Open, FileAccess.Read, FileShare.Read);
                wb = new XSSFWorkbook(fs);
                fs.Close();
            } catch (Exception e) {
                XtraMessageBox.Show(owner, "文件读取错误！");
            }

2022-07-07_09-59-03.xlsx

Which version of NPOI are you using? Where is this xlsx from? I mean which software generates this xlsx?

2.5.6, from a website downloaded

If the two relationship entry with weird id are removed, this file can be open correctly with NPOI.
Please double check with the website owner about how is the file generated. Is it possible that this file is generated by WPS or some third-party component?

I don't know, But, it can be opened and view by ms excel and wps

Hi,
After seriously research, found it's added by safty software. Is there any other way to overcome it? The safty software must be installed on the client machine.

This is a issue with this safty software. It should NOT  add extra things in a office file. NPOI cannot help. Please ask your client to contact the supplier.


Issue with Multiple HTTP implementation

I get this error when I build and deploy to AWS during putEvents in step function

I solved it by adding  System.setProperty("software.amazon.awssdk.http.service.impl", "software.amazon.awssdk.http.urlconnection.UrlConnectionSdkHttpService");
but now everything looks ok but I dont see the usage change in stripe also the DB looks like this


Upgrade to go 1.16 and add darwin-arm64 support.

go 1.16 is required for darwin-arm64 support. I've added this to the build process.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

nice
@yuting-fan

@DennoVonDiesel  when I try to use the install file as: install -i /usr/local/sessionmanagerplugin -b /usr/local/bin/session-manager-plugin from path session-manager-plugin/Tools/src/darwin it displays:
install: illegal option -- i
usage: install [-bCcpSsv] [-B suffix] [-f flags] [-g group] [-m mode]
               [-o owner] file1 file2
       install [-bCcpSsv] [-B suffix] [-f flags] [-g group] [-m mode]
               [-o owner] file1 ... fileN directory
       install -d [-v] [-g group] [-m mode] [-o owner] directory ...

I'm missing some steps?

@williantenfen I don't see that the system command install has a -i option on either darwin or linux. I think the correct way is to unzip the bundle file that gets created after building the package and run that installer.

thanks! got it. working fine!

This is great hopefully @Yangtao-Hua or @yuting-fan can look at merging soon.

@Yangtao-Hua @yuting-fan
It would be really nice to get session-manager-plugin working for M1 machines without having to use a fork of this library!

@DennoVonDiesel I noticed there is also a Makefile target which might be missing in your PR https://github.com/aws/session-manager-plugin/pull/44/files
PS I'm very curious if AWS is ever going to respond, unfortunately from my experience, it either takes very long or they never respond. (depends on the team, but this is my general experience)

Thank you for the changes, we noticed it is highly required feature, it is in our plan.

Do you have an ETA @Yangtao-Hua ?

@Yangtao-Hua This is flagged as a highly required feature but no movement in over 3 months.
Should any community work towards this repository move away from AWS and be managed by the community due to the lack of engagement?

We are actively working to add darwin-arm64 support and this change is currently under review. Will keep this thread updated on the release as we make progress.

Any update @nitikaaws ?

Nice definition of "actively" @nitikaaws
Seriously guys... what's taking so long, this is absurd.

Nice definition of "actively" @nitikaaws
Seriously guys... what's taking so long, this is absurd.
cc. @yuting-fan @Yangtao-Hua @YujiaozhAws

Apologies for the delay in releasing the support for darwin-arm64! Our team is looking into this and will provide an update when we are closer to the release.

@nitikaaws Any chance of a community release? You said you were reviewing this change in November.

Session Manager Plugin support for darwin-arm64 has been released with version 1.2.463.0. This pull request has been incorporated in 60f4fa7 commit. Thanks for your patience and support, please let us know your feedback.


Re-implement OffHeapBitmapInvertedIndexCreator to support large number of values (> 500M)

Use LBuffer instead of ByteBuffer to allocate direct memory buffer larger than 2G
Re-use buffer if possible to reduce memory footprint
Do not generate extra temporary file during index generation

Codecov Report

Merging #2886 into master will increase coverage by 0.01%.
The diff coverage is 90.58%.

@@            Coverage Diff             @@
##           master    #2886      +/-   ##
==========================================
+ Coverage   69.15%   69.16%   +0.01%
==========================================
  Files         912      912
  Lines       43623    43608      -15
  Branches     5932     5931       -1
==========================================
- Hits        30168    30162       -6
  Misses      11421    11421
+ Partials     2034     2025       -9

Impacted Files
Coverage Δ

...dex/loader/invertedindex/InvertedIndexHandler.java
78.57% <33.33%> (ø)
:arrow_up:

...tor/impl/inv/OnHeapBitmapInvertedIndexCreator.java
85.18% <88.88%> (-1.03%)
:arrow_down:

...ment/creator/impl/SegmentColumnarIndexCreator.java
88.72% <90%> (+0.08%)
:arrow_up:

...or/impl/inv/OffHeapBitmapInvertedIndexCreator.java
89.53% <93.65%> (+1.41%)
:arrow_up:

...e/operator/dociditerators/SortedDocIdIterator.java
45.94% <0%> (-18.92%)
:arrow_down:

...impl/dictionary/DoubleOnHeapMutableDictionary.java
66.66% <0%> (-8.89%)
:arrow_down:

.../impl/dictionary/FloatOnHeapMutableDictionary.java
80% <0%> (-6.67%)
:arrow_down:

.../impl/dictionary/LongOffHeapMutableDictionary.java
81.81% <0%> (-3.64%)
:arrow_down:

...mpl/dictionary/DoubleOffHeapMutableDictionary.java
74.54% <0%> (-3.64%)
:arrow_down:

...ot/core/query/pruner/ColumnValueSegmentPruner.java
88.13% <0%> (-3.39%)
:arrow_down:

... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03852e1...87d9d6a. Read the comment docs.


Discrete (mixed) density estimators

For discrete (mixed) parameters.
Can probably recycle a lot of code from MNLE.

Yes, MNLE implements a mixed estimator with a categorical distribution.
It would be nice to extend this to discrete flows as well.

Related to #968

happy to work on this during the hackathon

The MNLE classes are now refactored to match the API of the other build functions, including z-scoring and embedding nets. Thus, in principle, one can now also use the MNLE setup for posterior inference. However, it allows only for a single discrete column in x (theta).
An autoregressive density estimator on top would be the solution, see #1112


NTR: number of input specimens to assay

Need in addition to general number of samples/ specimens collected.

Label: number of input specimens to assay
Definition: A count of the arthropod specimens involved in an assay.
Parent: count
Subclass axiom: 'is about' some ('collection of specimens' and ('has member' only Arthropoda) and (is_specified_input_of some assay))

let's keep this general and remove arthropod restriction.


Update jsx-pascal-case.md

Using "jsx-pascal-case": ... leads to
1:1  error  Definition for rule 'jsx-pascal-case' was not found  jsx-pascal-case

We need "react/jsx-pascal-case": ... as shown in the Readme

Good question, I didn't check! I can have a look see for you if you like

There's a few, let me do this proper and add them here, or would you prefer a different PR?

@Adzz here would be great, thanks :-) please rebase them all down to a single commit.


update to pass multiple versions

we have a requirement to pass "multiple versions" as an argument with "multiple packages"
It would be great if you can update your comments or let me know if you find any issues

@renevanosnabrugge  It would be great if you can please review this


⚠ ClamAV has degraded performance

In d5b2d24, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 69 ms

Resolved: ClamAV performance has improved in 3fe5536.


agent supports configurable work count

https://github.com/clusternet/clusternet/blob/e15829aa3359848d8a9d118eba6c3ab19dbeda67/pkg/agent/agent.go#L58

Currently there isn't much work to do in clusternet-agent. We're keeping it light-weighted.
While I am fine if we're adding multiples workers inside of clusternet-agent.


gradle pactPublish fails

I think the fix for #291 may have broken the successful publish case:
Publishing service-another-service.json ... HTTP/1.1 201 Created
:pactPublish FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':pactPublish'.
> No signature of method: org.apache.http.message.BasicStatusLine.startsWith() is applicable for argument types: (java.lang.String) values: [FAILED!]

PactBrokerClient returns resp.statusLine (a BasicStatusLine) whereas the failure case returns a string
  response.success = { resp -> resp.statusLine }
  response.failure = { resp, json ->
    def error = json?.errors?.join(', ') ?: 'Unknown error'
    "FAILED! ${resp.statusLine.statusCode} ${resp.statusLine.reasonPhrase} - ${error}"
  }

Occuring in 3.2.11

Oops ;-)

I've released version 3.2.13 with this fix

Works now. Thanks @uglyog

The recently published version 2.4.14 from (#310) has the same issue.

I've released 2.4.15 with the fix

the jar is still missing in https://mvnrepository.com/artifact/au.com.dius/pact-jvm-consumer-junit_2.11, is it expected?

It can take a while for the index to propagate. search.maven.org is listing it: http://search.maven.org/#search|gav|1|g%3A"au.com.dius" AND a%3A"pact-jvm-consumer-junit_2.11"


[Docs]: add contributing guidelines section

Included a link to the CONTRIBUTING.md file.
Removed CLA information as it would appear redundant with this update.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thank you for your contribution, @jamesgeorge007  We value your time and thoughtfulness. We have decided to maintain the current headings to reflect messaging about our CLA on GitHub, and we feel the title, “CLA” is more accurate. Again, thank you for your effort. We appreciate your time, and we hope to see more contributions from you in the future.

@astuteape the respective section is already present as part of the contributing guidelines. It is not necessary to add redundant content as part of the docs. This PR definitely makes sense in that regard.
/cc @thinkingserious