Caching hits the network even when it's not needed

With a previously-installed bundle, there shouldn't be any need to hit the network to cache the gems that are already installed. In spite of that, install completes and then cache hits the network:
$ bundle pack
Using bundler 1.9.9
Using rake 10.4.2
Using rack 1.6.1
Bundle complete! 2 Gemfile dependencies, 3 gems now installed.
Bundled gems are installed into ./.bundle.
Updating files in vendor/cache
Fetching gem metadata from https://rubygems.org/..........
Fetching version metadata from https://rubygems.org/..
  * rake-10.4.2.gem
  * rack-1.6.1.gem

I cannot reproduce this, unless I'm missing something?

Maybe it's fixed on master? I just saw it again today while running bundle pack on 1.9.9.

@indirect closing since you never provided steps to reproduce ;)

Steps to reproduce on 1.10.6:
$ bundle init
$ echo "gem 'rack'" >> Gemfile
$ echo "gem 'rake'" >> Gemfile
$ bundle install --path .bundle
# note that this installation contacts rubygems.org
$ bundle package
# note that this _also_ contacts rubygems.org, even though the gems are already local and the lockfile is already present

Here's the output that doesn't make sense while running pack:
$ bundle pack
Using bundler 1.10.6
Using rack 1.6.4
Using rake 10.4.2
Bundle complete! 2 Gemfile dependencies, 3 gems now installed.
Bundled gems are installed into ./.bundle.
Updating files in vendor/cache
Fetching gem metadata from https://rubygems.org/..........
Fetching version metadata from https://rubygems.org/..
  * rake-10.4.2.gem
  * rack-1.6.4.gem

The specific general idea here is that if install can run without contacting rubygems.org, than so can pack. There's no reason to go get gem metadata again.

ok, thanks for the repro steps!

I've just followed the repro steps and couldn't reproduce the issue.

Great, this is probably fixed by 1.11 then.

Sounds like we can close this


Azul zulu jdk11

Description
Azul Zulu JDK 11 LTS is now used in Travis-Ci and Docker Images
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!

[X] Write the commit message as per https://github.com/apache/fineract/#pull-requests

[X] Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.

[X] Create/update unit or integration tests for verifying the changes made.

[X] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.

[X] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm with details of any API changes

[X] Submission is not a "code dump".  (Large changes can be made "in repository" via a branch.  Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

Closing without changes

Opening without changes


Feature request: embed calendar (from file/link) to a slide

Would be a nice door-side display to show room reservations or such! Even just an ability to parse events to text (like 13/5/2019 event 1 at 13pm - 14pm) would suffice nicely. Input would be a link to an ICS file or something.

I have planned to implement some sort of a plugin system for the markup transpiler so that users could implement their own tags for special things like this. There would of course be some plugins included out of the box too. Some sort of a calendar would definitely be a good addition. I'll put the whole plugin infrastructure and your idea on my TODO list.


robustness evaluation

There seems to be no white-box attack part in the code, only a dataset named 7B_behavior_llama2_c.json in the adv folder, which seems to be a transfer attack evaluation, and this file has not been uploaded. @hongyanz @Liyuhui-12

sry, i didnt check the readme carefully as it already said how to evaluate under white box.


should not lowercase (single) uppercased letter(s)

thoughts? We assume to use this lib in cli's (not only of course, I know for what you use it)? And in CLI we have uppercase letters.

@jonschlinkert ?

yes, you're right, it shouldn't. Not sure why I was thinking that at the time...

that case also is interesting.
So want PR to remove .toLowerCase() ?

yeah, that works for me. thanks

@jonschlinkert I think also these two cases
it('should dash-case the key:', function () {
  toArg('abcXyz').should.equal('--abc-xyz');
  toArg('aBc').should.equal('--a-bc');
  toArg('a b c').should.equal('--a-b-c');
});

should be
it('should dash-case the key:', function () {
  toArg('abcXyz').should.equal('--abc-Xyz');
  toArg('aBc').should.equal('--aBc');
  toArg('a b c').should.equal('--a-b-c');
});


Scoped search should consider all transactions

Overview
When applying the search and the filters that are scoped to the account's transaction, it only considers the current page.
Steps to reproduce

Using the main search bar, select an account such as tf
Try any filter
See it that only applies to the current page

Acceptance criteria

The selected filters should be applied to all transactions, providing a new list of pages containing only filtered transactions
For better performance, consider grouping all filters and creating an Apply Filters button to start filtering the account's transaction.
Latest transactions label should appear only once, i.e. remove the one below

We discussed with @donnyquixotic what to do with this issue in today's meeting and decided to remove all current filter buttons and instead add a group of new components that reflects the actual capabilities of the Hyperion API:
e.g:

text search won't be present.
token filter should be selectable from a list and not text input.
Range of days will be pretty much the same as now but one that actually works XD
add the capability to filter by account (e.g: in simple transfers the "from" and "to" accounts can be filtered this way)


Legacy plugin API not allowing multiple plugin types on one unix socket

It is no longer possible to serve multiple plugin-types on one unix socket with the legacy plugin API in docker 1.13. This does not appear to be reflected in the API documentation anywhere so I must assume it is a bug.
A command like the following errors:
$ docker network create --driver vde --ipam-driver vde --subnet <IP_ADDRESS>/24 testvde
Error response from daemon: legacy plugin: Plugin does not implement the requested driver

whereas if I duplicate the unix socket with a simple socat forwarder, it succeeds:
$ cd /run/docker/plugins
$ socat -vv UNIX-LISTEN:vde-ipam.sock,fork UNIX:vde.sock &
$ docker network create --driver vde --ipam-driver vde-ipam --subnet <IP_ADDRESS>/24 testvde
Error response from daemon: IpamDriver.RequestPool: not implemented

(the error is because this part of the driver is under development - but the response does go through to driver).
In both cases my plugin returns exactly the same reponse to Plugins.Activate - in the same order:
{"Implements":["NetworkDriver","IpamDriver"]}

Steps to reproduce the issue:

Create a plugin with a mux which serves the correct multi-driver response to Plugins.Activate and start it on a single socket in /run/docker/plugins (i.e. NetworkDriver and IpamDriver as above)
Try and use the Ipam component simultaneously: i.e. docker create -d mydriver --ipam-driver mydriver
Docker will not try sending any IPAM commands to the IPAM endpoints on the socket.


Only show current image toggle

When viewing images in the map, it would be nice to be able to view only the image that is currently selected in the photos panel. This would be especially useful when trying to compare overlapping images in the context of the map.

Maybe this would be better as ONLY SHOW ONE IMAGE


Release Google.Cloud.SecurityCenter.V1 version 3.2.0

Changes in this release:
New features

Added container field to findings attributes (commit e8abc9d)
Added kubernetes field to findings attribute. This field is populated only when the container is a kubernetes cluster explicitly (commit e8abc9d)

Created release for Google.Cloud.SecurityCenter.V1-3.2.0


Add plot='save' option to statistics functions

Currently, statistics functions (e.g. test_modulation) create a figure if plot=True is passed. They should additionally save the figure into a predefined folder structure if plot='save' is passed.

The user should be responsible for saving plots themselves, therefore this will be closed without implementation.


Implement sign-up page

Description
Implement the Sign up page using:

Side banner #140
Sign up form #131

Fixes # (issue)
How to test?
Go to:
http://localhost:3000/sign-up

Checklist

[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] This PR is ready to be merged and not breaking any other functionality

👍


Application-dependent, context-aware menus

(not sure how possible this is under wayland)
The Motivation
The current menus is a cool addition to the desktop UI. However the desktop UI is already probably the most polished and efficient part of the user's interaction. The application UIs are in much worse shape, in addition to being completely inconsistent. Thus it might be worthwhile to have a flie pie menu that changes depending on which application window is raised. This would allow fly pie to essentially extend the UI of individual applications. As I said, the app UIs are the thing that is in desperate need of optimization.
The Solution
Enable the user to:

Create an empty root menu "context_aware_menu"
Draw menu structure "menu_x" if condition x=TRUE.
Draw menu structure "menu_y" if condition y=TRUE.
etc. Thus you create custom menus for different scenatios.

The most useful condition here being "which application is currently in focus?" But I can see a use case for other conditions, like time of day and so on.
Dbusmenuproxy may be useful here to invoke appmenu-items from fly-pie, or even have fly pie draw the menu while hiding it within the application.
The Alternatives
The are no GUI alternatives.

Yeah, I guess a the fly pie interface is not a good fit for a full menubar replacement. Picking out specific actions from the menubar and placing them into the fly pie menu could still be an invaluable feature however.
For a full menubar replacement, one could have popup menubar widget with a search box at the top.
-------------
| [search]  |
| ----------- |
| [File]      |
| [Edit]      |
| [Help]     |
-------------

ofc this is outside the scope of your existing UI model but it would be very nice thing nonetheless. It would liberate the global menu idea from the Apple UI model and turn it into just another popup/popup-menu.

Fildem isn't a popup menu, it's a global menu bar. Global menu isn't a good fit for Linux desktop IMO.

Yeah, that's definitely not in the scope of Fly-Pie

It would be within the scope of "popup menu", just not "marking popup menu." So the question is whether you want to include other types of menus - like vertical context menus - under the scope of your project. I think it's an idea worth considering because other types of menus can be superior to marking menus for certain tasks. For example, with context menus, you could open a vertical clipboard history menu at the cursor position.

Rescheduled as Fly-Pie 12 will be a bug-fix-only release.

Rescheduled to Fly-Pie 14, as Fly-Pie 13 will be released soon because it includes an important bug fix.

Rescheduled again as Fly-Pie 14 will focus on GNOME 42 support...

I feel like like this could be a real killer feature, I certainly would love to see it

I am currently investigating ways to create a standalone (not GNOME-only) version of Fly-Pie. I have some ideas in mind which could improve the user experience. Context-aware menus will definitely be a core feature of this new version.

Hi @Schneegans would that work on Wayland as well or X11 only?
I'd be interested in adding a simple version of this feature request that simply opens a different menu depending on the currently active window.
I have some experience with working with windows workspaces on my extension https://github.com/blipk/Customised-Workspaces
It'd be great if you could point me to where might be the best place in your code to hook into the keyboard shortcuts and menu configuration, and any style/contribution guidelines.
I propose adding an application config item which points to either an xdg application or a window wmclass, and any menus that have the same keyboard shortcut would be preferred by the currently focused window application/wmclass
If you're interested, let me know and I will look into creating a PR.

Actually it looks like the simplest solution was to use this other extension and some DBus calls: https://github.com/hseliger/window-calls-extended
And then bind a gnome global keyboard shortcut to a shell script with the following:
FOCUSED_WMCLASS=$(gdbus call --session --dest org.gnome.Shell --object-path /org/gnome/Shell/Extensions/WindowsExt --method org.gnome.Shell.Extensions.WindowsExt.FocusClass)
gdbus call --session --dest org.gnome.Shell --object-path /org/gnome/shell/extensions/flypie --method org.gnome.Shell.Extensions.flypie.ShowMenu "${FOCUSED_WMCLASS//[,()']/""}"

I just then have to name my menus in flypie after the the applications main window WMCLASS, and now I get a different menu for each application with a single keyboard shortcut.

@blipk This is a pretty clever use-case of Fly-Pie's DBus interface!! And it's actually pretty easy to set up. Would you still be interested in looking into the code or is this solution sufficient for now? Implementing this into Fly-Pie will be waaay more complicated, I guess :laughing:

Hey @Schneegans thanks, I'd probably just stick with the script for now as it's working well, I'm looking forward to using this with my wacom tablet when that arrives.
It shouldn't be too hard to implement, most of the calls to find the focused window are easy enough, but I'm not familiar with your code so would take me a bit of time to fit it in with your config/setup.
I'm more interested in the version you're working on that's not gnome-dependant.

@blipk I published some news regarding the platform-agnostic pie menu! At the end of the post, I wrote down some ways how you could contribute to the project. I would be more than happy if you would follow the progress and support the development along the way :smile:

I will not add this feature to Fly-Pie as I am currently focusing on the successor project Kando. Application-dependent menus will become a core part of Kando!


Python module generated by tf.load_op_library contains no custom ops

Please make sure that this is a bug. As per our GitHub Policy, we only address code/doc bugs, performance issues, feature requests and build/installation issues on GitHub. tag:bug_template
System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow):yes
OS Platform and Distribution (e.g., Linux Ubuntu 16.04):Linux Ubuntu 16.04
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device:N/A
TensorFlow installed from (source or binary):source
TensorFlow version (use command below):1.13.1
Python version:3.6
Bazel version (if compiling from source):0.19.2-dist
GCC/Compiler version (if compiling from source):5.4.0
CUDA/cuDNN version:N/A
GPU model and memory:N/A

Problem
I followed the instructions on https://tensorflow.google.cn/guide/extend/op to customize my own OPs step by step. For simple verification, I used the fact OP that comes with tensorflow (I also tried my own OP). I add BUILD file in the same directory with fact.cc
load("//tensorflow:tensorflow.bzl", "tf_custom_op_library")

tf_custom_op_library(
    name = "fact.so",
    srcs = ["fact.cc"],
)

and then build
bazel build --config opt //tensorflow/core/user_ops:fact.so

But when I use fact.so as the instructions describe:
# python
import tensorflow as tf
fact_module = tf.load_op_library('./fact.so')
fact_module.fact

I got following errors
Traceback (most recent call last):
  File "/tmp/remote_python/main.py", line 10, in <module>
    fact_module.fact
AttributeError: module '670cc8cfec5b6d3b8635f39bd583d769' has no attribute 'fact'

Is this normal?

This is due to the fact that I have installed tensorflow with my own op...

@dMokaMoka hi, what do you mean by 'installed tensorflow with my own op'?


ktmpl doesn't replace variable if it is inside a key name

This is part of kops config.
cloudLabels:       kubernetes.io/cluster/$(CLUSTER_NAME): owned
ktmpl does not replace this variable.

This is addressed in the new 0.9.0 release: https://github.com/jimmycuadra/ktmpl/releases/tag/0.9.0
Thanks for reporting!


Support webrtc release 63

WARNING, this breaks backward compatibility. branch-head below 63 will not work.
Not sure how to handle this but webrtc 63 do not work with the cmake script anymore.
The WebRTC team has moved all headers from out/webrtc/src/webrtc to out/webrtc/src.
This commit install the header from the right location.
However, CMakeModules/Templates/LibWebRTCConfig.cmake.in has been modified to include both the INSTALL_INCLUDE_DIR and INSTALL_INCLUDE_DIR/webrtc.
This is because we still want to include webRTC header this way from our program: #include <webrtc/somefile.h> but then the header from webrtc might include other webrtc header this way #include <someotherfile.h.
I'm not sure how to handle the backward compatibility and the small hack with the include. Because of this I advise not to merge this PR. Someone can still get inspiration from it to make it better though.

I don't know if it helps, but in our case, we started by extracting the version (branch_head) and subversion (number of commits since branch head) to use in the xxxConfigVersion.cmake. We would use cmake to create a config file that would contain the version as a C preprocessor define to be used at compilation time. It allowed for a time to have application code that would support multiple webrtc versions by using the following pattern:
#if WEBRTC_VERSION < 61
#include /webrtc/base/...
#else if WEBRTC_VERSION < 62
#include /webrtc/rtc_base/...
#else if WEBRTC_VERSION < 63
#include /rtc_base/...
Unfortunately, those changes in libwebrtc were not the exception but the normality and the maintenance burden was increasing too quickly. We are now using branches across, i.e. all our projects depending on libwebrtc have a 61, 62, 63, .... branch which are all in sync, and this branches contains code that is aligned with the branch_head version. Made our life easy, and simplified the maintenance A LOT !


Not working on Windows

As usual, multiprocessing and Windows do not work well together. However, it might be easy to fix in this case. I would recommend allowing for a non parallel option to make running on Windows easier.
See the stack trace below:
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "C:\Python27\lib\multiprocessing\forking.py", line 380, in main
    prepare(preparation_data)
  File "C:\Python27\lib\multiprocessing\forking.py", line 510, in prepare
    '__parents_main__', file, path_name, etc
  File "C:\Users\Cristiano\Desktop\DumpsterDiver-master\DumpsterDiver-master\DumpsterDiver.py", line 3, in <module>
    import advancedSearch
  File "C:\Users\Cristiano\Desktop\DumpsterDiver-master\DumpsterDiver-master\advancedSearch.py", line 3, in <module>
    import core
  File "C:\Users\Cristiano\Desktop\DumpsterDiver-master\DumpsterDiver-master\core.py", line 42, in <module>
    queue = multiprocessing.Manager().Queue()
  File "C:\Python27\lib\multiprocessing\__init__.py", line 99, in Manager
    m.start()
  File "C:\Python27\lib\multiprocessing\managers.py", line 524, in start
    self._process.start()
  File "C:\Python27\lib\multiprocessing\process.py", line 130, in start
    self._popen = Popen(self)
  File "C:\Python27\lib\multiprocessing\forking.py", line 258, in __init__
    cmd = get_command_line() + [rhandle]
  File "C:\Python27\lib\multiprocessing\forking.py", line 358, in get_command_line
    is not going to be frozen to produce a Windows executable.''')
RuntimeError:
            Attempt to start a new process before the current process
            has finished its bootstrapping phase.

            This probably means that you are on Windows and you have
            forgotten to use the proper idiom in the main module:

                if __name__ == '__main__':
                    freeze_support()
                    ...

            The "freeze_support()" line can be omitted if the program
            is not going to be frozen to produce a Windows executable.
Traceback (most recent call last):
  File "DumpsterDiver.py", line 3, in <module>
    import advancedSearch
  File "C:\Users\Cristiano\Desktop\DumpsterDiver-master\DumpsterDiver-master\advancedSearch.py", line 3, in <module>
    import core
  File "C:\Users\Cristiano\Desktop\DumpsterDiver-master\DumpsterDiver-master\core.py", line 42, in <module>
    queue = multiprocessing.Manager().Queue()
  File "C:\Python27\lib\multiprocessing\__init__.py", line 99, in Manager
    m.start()
  File "C:\Python27\lib\multiprocessing\managers.py", line 528, in start
    self._address = reader.recv()
EOFError

Thanks @cristianocca for raising the issue. It's true I was testing it only on Linux and Mac. I'll sit on it during the weekend and try to fix this issue.

Hi @xep624, this issue still persists. would there be an update to fix the same ?


[TEST] No Review

Just testing ci failures with various ways of updating the perimeter-x cartfile, requirements to get it to succeed.

just a test.


[FOLLOWUP]GetSchemas supports DSv2 multipart namespaces with dot backtick

       ❨?❩

Why are the changes needed?

add support for '.' and '`' in a namespace part
for instance, cases like https://github.com/yaooqinn/kyuubi/pull/337/files#diff-bcd0dfb958c3943a58a9705ac7053374c796449fefd6be7e9f014f9dd14b558fR94 produce the below catalog tree, we should treat a.b.c and a.b.c differently.
/var/folders/01/h81cs4sn3dq2dd_k4j6fhrmc0000gn/T/kyuubi-94c946f7-a64b-4980-9dd1-a63a573244dd
├── a
│   └── b.c
├── a.b
│   └── c
├── a.b.c
├── a.b`.c
├── db1
│   └── db2
│       └── db3
└── db4

How was this patch tested?

[x] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[x] Add screenshots for manual tests if appropriate

[x] Run test locally before make a pull request

cc @cloud-fan, and thanks for your suggestions.


🚀 [Feature] backend adaption of change password-process

🚀 Feature

Base on the concept
https://github.com/gradido/gradido/blob/master/docu/Concepts/TechnicalRequirements/UC_Introduction_of_Gradido-ID.md#change-password-process
the backend has to be adapted for these requirements.

password-process still changed on gradido-id long time ago.
so ticket will be closed


add lsp-mode instructions to README

(Also note, this PR addresses #4)

Amazing, thanks for making move-mode better!


gemspec: Use https for homepage

This PR changes the homepage property to point to an HTTPS URL.

Thanks!


Feature/fe 250/camera simple view layout

ALL CONTRIBUTIONS WILL BE REVIEWED BY AT LEAST ONE OF OUR FRONTEND TEAM MEMBERS.

Technical description

Added new ratio calculation logic using euclidean GCD.
Added some style fixes to the ImageViewer component.
Fixed a bunch of Damages screen and CaptureTour warnings
Related to

This PR is related to Camera Simple View Layout
About Tests

Tested on the following devices

iPhone 8, iPhone 8 plus
pixel 2 XL
Web chrome browser

Steps to reproduce

Land on damages screen
Open the add a damage form (press a vehicle part)
Add a picture (camera should be full screen)

Screenshots (optional):
No screenshots.
This Pull Request template has been written and generated by Monk JS repository.

[ ] The camera preview is still stretch and pictures are still 4:3 ratio, so please keep the same ratio for the camera preview.
[ ] There is a non wanted margin bottom on the DamageCreate
[ ] The picture in the left top corner of Camera Simple View should be mirrored


Is it possible to determine how 'moveend' event was triggered?

Hi! I need to determine how 'moveend' event was fired - by mouse or programmatically. Is it possible?

My use case is the following:
I want to capture all position-related changes on the map with only the moveend event handler (so that no replication exists if also using the zoomend one).
So, I just want a way to determine if zoom was the reason of the moveend so that I can do some extra stuff on the 'movend' handler.
I see that you have e.type: "moveend" but I would also need the extra property of e.subtype: "zoom" (for example)

I have another usecase. On button click I want map view to follow GPS (calling map.locate({ setView: true, watch: true })) but when user moves the map manually I want to stop the map to follow GPS (calling map.locate({ setView: false, watch: true })).
Or is there a workaround for this usecase, @mourner?


setState should be called replaceState

Just got bitten by this; setState replaces the existing state object, while React's method merges the new state with existing state. If these methods are called the same as their React's counterparts, it makes sense to have the same behaviour :)

Implemented in v0.9


Update theme.ts

correction to variable
Description
PR 1353 made some changes to variable names but one as missed. The card secondary color variable was referencing the primary text color variable.
Related Issue
PR 1335
Motivation and Context

Was assisting a user on Discord troubleshoot using card_mod to modify text colors. The user mentioned that the primary text would change but secondary text was showing the same color as primary text. While inspecting the card, I noticed --card-secondary-color: var(--mush-card-secondary-color, var(--primary-text-color));
How Has This Been Tested

Used card_mod to modify variables. Inspecting in Firefox, I could see the secondary-text-color variable present but not being called per the card-secondary-color variable.
Types of changes

[x] 🐛 Bug fix (non-breaking change which fixes an issue)
[ ] 🚀 New feature (non-breaking change which adds functionality)
[ ] 🌎 Translation (addition or update a translation)
[ ] ⚠ Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have tested the change locally.
[ ] I followed the steps if I add a new language .

The default color is the primary for both texts (primary and secondary) because it follows the tile card style by default. But it has two variable so it can be override by theme.


As a User, I can logout via the user menu

[ ] implement a dropdown user menu that opens on hover over username in header.
[ ] implement the Logout action as an option on this menu

per https://fusion-alliance.gitbooks.io/autorenter-spec/content/modules/main_module/main_interactions.html#logout.

Does this need to be implemented since there is only one action for the user to take. Is there a user page with details about the user that clicking on the username would route to. If not, seems un-necessary.

@ryanstrandt, I had the same question and @BWortman will have to answer. Based on issues/comments over in the Angular repo for this I think the intent is to have a menu, assuming the point is to demo a dropdown menu regardless of how many items are in it, so that's why I put this in.

@BWortman  ^


ci(gha/release): download artifacts from annotated tags

Annotated tags need an extra deref to fetch the commit sha.

Ensures the publish of release artifacts works with an annotated tag.
Description

Motivation and Context

Regression

How Has This Been Tested?

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added unit tests to cover my changes.

bors merge


Remove centos from GCE Terraform example

What this PR does / why we need it:
There was some confusion on the Kubermatic community Slack about supported OSes in GCP/GCE (https://kubermatic-community.slack.com/archives/C0PGCH99P/p1641219410010900). I was looking into the GCE Terraform example, which listed centos as valid worker OS choice, but machine-controller does not support it. So, this PR removes centos from the list (which makes it a list of one, but anyway ...) to avoid more people running into this problem.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

Remove 'centos' choice from GCE Terraform example as it's unsupported

Signed-off-by: Marvin Beckers<EMAIL_ADDRESS>

/retest


fix build on master

Reticketing from #3876.
https://travis-ci.org/gratipay/gratipay.com/builds/98361516

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/29592800-fix-build-on-master?utm_campaign=plugin&utm_content=tracker%2F85909&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F85909&utm_medium=issues&utm_source=github).

Um, wut? The merge commit passes but the version bump fails? :flushed:

https://travis-ci.org/gratipay/gratipay.com/builds

/me tests 2a7b8bf43eccd0e0b73162a6a9a1b2397a40036e locally ...

Fails.

/me tries the way-old 9e1f1663964c58b69394d6b256e7965aadb5b7b0 just for kicks ...
Prolly doesn't even have this test.

It does! And it ... fails! :scream:

We have a few failures in Travis on master over the past month, but they're generally network service failures. Build #8677 (9a959f298a1cc76b820a6035156fd89bfe5a6d39) is the first to fail with this error we're seeing now, which, to be clear, is:
Traceback (most recent call last):
  File "/Users/whit537/personal/gratipay/gratipay.com/tests/py/test_history.py", line 70, in test_iter_payday_events
    assert len(events) == 7
AssertionError: assert 0 == 7
 +  where 0 = len([])

Can we reduce this failure to a network service problem? To something in the environment (new Python version?)? What's going on here?

Oooooooooh my gosh. The year changed! I bet that's it.
current_year = datetime.utcnow().year

https://github.com/gratipay/gratipay.com/blob/1934/gratipay/utils/history.py#L68

Evidence! The year in these payments is 2015.
gratipay-test=# select * from payments;
┌────┬───────────────────────────────┬─────────────┬───────────────┬────────┬────────────────┬────────┐
│ id │           timestamp           │ participant │     team      │ amount │   direction    │ payday │
├────┼───────────────────────────────┼─────────────┼───────────────┼────────┼────────────────┼────────┤
│ 16 │ 2015-12-23 17:33:40.963065+00 │ obama       │ TheEnterprise │  10.00 │ to-team        │    140 │
│ 17 │ 2015-12-23 17:33:40.963065+00 │ picard      │ TheEnterprise │  10.00 │ to-participant │    140 │
│ 18 │ 2015-12-30 17:33:41.413283+00 │ obama       │ TheEnterprise │  10.00 │ to-team        │    141 │
│ 19 │ 2015-12-30 17:33:41.413283+00 │ picard      │ TheEnterprise │  10.00 │ to-participant │    141 │
└────┴───────────────────────────────┴─────────────┴───────────────┴────────┴────────────────┴────────┘
(4 rows)

Yeah, here it is, we backdate by a week when making the test records.

And the first failing build is 8679, which is the first build in the new year, not 8677 as I previously stated.

Okay! So the workaround is to wait a day ... how about a fix? :-)

@kaguillera are trying to find a fix here. We're not sure we're not finding bug in iter_payday_events.

We're not seeing the balance carry over from year to year as we'd expect, when browsing history pages in production.

We're going to move onto other issues, and see what happens with this tomorrow. If master is green again then we're no worse than we were a week ago.

diff --git a/tests/py/test_history.py b/tests/py/test_history.py
index 0cb8fda..e3eb406 100644
--- a/tests/py/test_history.py
+++ b/tests/py/test_history.py
@@ -57,6 +57,10 @@ class TestHistory(BillingHarness):
                    SET timestamp = "timestamp" - interval '1 week';
             """)

+        # Make sure the test runs during the first week of January. :)
+        now = datetime.utcnow()
+        year = now.year - 1 if now.month == 1 and now.day < 7 else now.year
+        self.db.run("UPDATE participants SET claimed_time = claimed_time - '1 month'::interval;")

         obama = Participant.from_username('obama')
         picard = Participant.from_username('picard')
@@ -66,7 +70,7 @@ class TestHistory(BillingHarness):

         Payday().start()  # to demonstrate that we ignore any open payday?

-        events = list(iter_payday_events(self.db, picard))
+        events = list(iter_payday_events(self.db, picard, year))
         assert len(events) == 7
         assert events[0]['kind'] == 'totals'
         assert events[0]['given'] == 0

Shelving state, you see. ;-)

!m @rohitpaulk @aandis


Non-determinism in SKLearn KMeans initialisation

The KMeans initialisation used in many models uses the SKLearn implementation.  The SKLearn call is not seeded, breaking the determinism of the JAX code.  I assume at some point you are going to include a JAX implementation of KMeans, but until then, a simple fix is:
key, subkey = jr.split(key)  # Create a random seed for SKLearn.
sklearn_key = jr.randint(subkey, shape=(), minval=0, maxval=2147483647)  # Max int32 value.
km = KMeans(self.num_states, random_state=int(sklearn_key)).fit(emissions.reshape(-1, self.emission_dim))

The original flaw and solution are demonstrated in this notebook.
Thanks,
A

LGTM.


Remove Sasha's early 2015 data proposal

This pains me, because it's a great doc with an overview of the problem and
the enviroment and a good explanation for where we went with data through most
of 2015.  But, it has gotten out of date and the stores part of it actually
isn't discussing anything that's (currently) part of react-server.
This resolves #121.

Anybody want to take a stab at salvaging the still-relevant topic overview here and putting it into a context that's up-to-date with current react-server?
Speak now before I nuke it. 😬

@gigabo you mean the "Key Concepts" portion?

I was actually thinking more of the "Design Principles" section.

I'll rescue "design principles" in a separate pr.  lgtm 👍


Question About How It Works

Hi,
I hope I'm reaching the right place to ask this question. If not, feel free to close this issue.
I wanted to inquire whether it would be possible to get more details about how it works, or perhaps access part of the source code.
If sharing this publicly isn't an option, I’d like to know if it would be possible to share it privately. It could significantly help me with several of my projects.
Thank you for your time and consideration.
Best regards,
Ghost0159

non-public.


ERROR - RX QUEUE FULL

Consider the following code:
#![no_std]
#![no_main]

use embedded_svc::wifi::{ClientConfiguration, Configuration, Wifi};
use esp_backtrace as _;
use esp_println::println;
use esp_wifi::wifi::WifiMode;
use esp_wifi::{initialize, EspWifiInitFor};
use hal::{clock::ClockControl, peripherals::Peripherals, prelude::*, Delay, IO};
use hal::{systimer::SystemTimer, Rng};

#[entry]
fn main() -> ! {
    let peripherals = Peripherals::take();
    let system = peripherals.SYSTEM.split();
    let clocks = ClockControl::max(system.clock_control).freeze();
    let mut delay = Delay::new(&clocks);

    // setup logger
    // To change the log_level change the env section in .cargo/config.toml
    // or remove it and set ESP_LOGLEVEL manually before running cargo run
    // this requires a clean rebuild because of https://github.com/rust-lang/cargo/issues/10358
    esp_println::logger::init_logger_from_env();
    log::info!("Logger is setup");

    println!("Hello world!");

    let timer = SystemTimer::new(peripherals.SYSTIMER).alarm0;
    let init = initialize(
        EspWifiInitFor::Wifi,
        timer,
        Rng::new(peripherals.RNG),
        system.radio_clock_control,
        &clocks,
    )
    .unwrap();

    let (wifi, _) = peripherals.RADIO.split();
    let (_wifi_interface, mut controller) =
        esp_wifi::wifi::new_with_mode(&init, wifi, WifiMode::Sta).unwrap();
    println!("Device capabilities: {:?}", controller.get_capabilities());

    const SSID: &str = env!("SSID");
    const PASSWORD: &str = env!("PASSWORD");
    let client_config = Configuration::Client(ClientConfiguration {
        ssid: SSID.into(),
        password: PASSWORD.into(),
        ..Default::default()
    });
    println!("Setting configuration: {:?}", &client_config);
    controller.set_configuration(&client_config).unwrap();
    controller.start().unwrap();
    println!("Wifi started: {}", controller.is_started().unwrap());
    controller.connect().unwrap();

    // Set GPIO7 as an output, and set its state high initially.
    let io = IO::new(peripherals.GPIO, peripherals.IO_MUX);
    let button = io.pins.gpio9.into_pull_up_input();
    let mut led = io.pins.gpio7.into_push_pull_output();
    led.set_high().unwrap();

    let mut i = 0;
    loop {
        if button.is_high().unwrap() {
            println!("Loop... {} {:?}", i, controller.is_connected());
            led.toggle().unwrap();
        }
        i += 1;
        delay.delay_ms(500u32);
    }
}

I'm using ESP32-C3, and getting bombard with these logs:
Loop... 251 Ok(true)
Loop... 252 Ok(true)
Loop... 253 Ok(true)
Loop... 254 Ok(true)
ERROR - RX QUEUE FULL
Loop... 255 Ok(true)
ERROR - RX QUEUE FULL
ERROR - RX QUEUE FULL
Loop... 256 Ok(true)
ERROR - RX QUEUE FULL
Loop... 257 Ok(true)
ERROR - RX QUEUE FULL
ERROR - RX QUEUE FULL
ERROR - RX QUEUE FULL
Loop... 258 Ok(true)
ERROR - RX QUEUE FULL
ERROR - RX QUEUE FULL
Loop... 259 Ok(true)
ERROR - RX QUEUE FULL
ERROR - RX QUEUE FULL

Is this a legitimate behavior? If yes, how can I silent these logs? It no, what can be done?
Thanks

That should probably get logged as WARN not ERROR. Besides that, you should be able to  get rid of all the logs by configurating the logger accordingly or not configuring the logger at all.
It's also possible to configure the queue size and other options: https://github.com/esp-rs/esp-wifi/blob/main/docs/tuning.md

I think it's fine for this to be an error. In my experience things rarely recover if the firmware hits this. I'd advise agains just hiding the pain; tuning the queue sizes may be a good way to reduce them.

I see. The default rx_queue_size is 5, what's the best way to tweak it?

I set it to 15 for my project. I'm still not satisfied with how my wifi works but at least it's reasonably stable :)

I'm getting a similar error Unable to allocate 2308 bytes on ESP32S2 with the default config when receiving packets at a rate of 1400/s. Managed to get rid of it by changing the config like this:

The peak heap usage is about 40000 bytes with this configuration.

This probably shouldn't even be a warning, probably a debug statement. Packet memory is now entirely stored in the heap, the warning is about the number of packet headers in the queue, setting this to a low-ish number is fine, because if there is no space in the queue then the wifi stack will just keep retrying. Depending on what you're application needs, you can tune the stack to either be more performant and use more memory (you will need to either increase the heap size or increase the static buffer count) or slower but less memory intensive. See tuning.md for more details.

I think it's fine for this to be an error. In my experience things rarely recover if the firmware hits this more than once in a while. I'd advise agains just hiding the pain; tuning the queue sizes may be a good way to reduce them.

This was probably true before, but not anymore, I've had this running in the last 24hrs and it will log this error constantly but still work just fine.

@MabezDev I'm a bit confused.
First saw ERROR - RX QUEUE FULL logs. I then set rx_queue_size = 15, which removed these logs but made things worse: I got WARN - Unable to allocate 2312 bytes logs and WiFi disconnections after ~15 seconds.
I now added heap_size = 131072 (doubled the heap size) to get again ERROR - RX QUEUE FULL logs, but this time without disconnections.
Considering the code I shared above, which basically does nothing in terms of network, I assume I should keep the default config values, and just find a way to silent the ERROR - RX QUEUE FULL logs until this log severity will change. Is this correct?

... and just find a way to silent the ERROR - RX QUEUE FULL logs ...

I can't seem to find a way to disable specifically the logs coming from the esp-wifi crate. Can this be done at all?

I explained it here https://github.com/esp-rs/esp-wifi/issues/291#issuecomment-1772448847, ERROR - RX QUEUE FULL is a red herring and should not be an error log.

You cannot disable logging for specific crates/paths but you can do it the other way around and only enable logging for the things you want to see logs from - see https://github.com/esp-rs/esp-println#logging ( ESP_LOGTARGETS )

The log has since been removed.


[bug] Confirmation Dialog not showing up in DeFi Wallet

Is there an existing issue for this?

[X] I have searched the existing issues

RainbowKit Version
0.12.11
wagmi Version
0.12.12
Current Behavior
Confirmation dialog in DeFi App is not popping up. It used to work few versions earlier.
Expected Behavior
Transaction confirmation showing up
Steps To Reproduce

Install DeFi Wallet app (https://crypto.com/us/defi-wallet)
Connect to DeFi Wallet (Crypto(dot)com) through Wallet Connect
Call any contract to pop up confirmation (transaction, message signing etc)

Link to Minimal Reproducible Example (CodeSandbox, StackBlitz, etc.)

https://doonft.com/verify/000000
Connect
Tap on Verify

onst {
        data: signingData,
        signMessage,
    } = useSignMessage({
        message: `Message to sign`
    });

Anything else?
It does work properly here:
https://wagmi.sh/examples/sign-message

@0xartcro 0.12.11 introduced a regression with WalletConnect, so you'll want to bump up to 0.12.12. I did test the dApp with Rainbow Wallet, and everything worked as expected. It seems like DeFi Wallet now has an issue with handling messages on WalletConnect v1. The example in Wagmi's docs is using WalletConnect v2. This should explain the difference you're seeing. Hopefully that wallet team resolves the issue. RainbowKit will be migrating to WalletConnect v2 in the next few weeks anyway.


Add boot source logic to disks tables and modals

📝 Description
Add boot source logic to disks tables and modals

Added bootable label in Disks table (VM Details, VM Wizard) near the boot disk
Added checkbox for Add, Edit Disk Modals for changing the boot disk

🎥 Demo
video:
https://user-images.githubusercontent.com/24938324/164000462-2022f973-ed25-4b83-adb1-8665552a84a8.mov

/lgtm

/lgtm


Allow picking target branch from list when creating PR

It would be nice if the target branch was a picklist instead of just a text input defaulted to the base branch.

Duplicate of https://github.com/microsoft/vscode-pull-request-github/issues/814


Please help. My code cannot updateRecords(5439, "tracks", "Take a Chance on Me").

Challenge Record Collection has an issue.
User Agent is: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:48.0) Gecko/20100101 Firefox/48.0.
Please describe how to reproduce this issue, and include links to screenshots if possible.
My code:

// Setup
var collection = {
    "2548": {
      "album": "Slippery When Wet",
      "artist": "Bon Jovi",
      "tracks": [
        "Let It Rock",
        "You Give Love a Bad Name"
      ]
    },
    "2468": {
      "album": "1999",
      "artist": "Prince",
      "tracks": [
        "1999",
        "Little Red Corvette"
      ]
    },
    "1245": {
      "artist": "Robert Palmer",
      "tracks": [ ]
    },
    "5439": {
      "album": "ABBA Gold"
    }
};
// Keep a copy of the collection for tests
var collectionCopy = JSON.parse(JSON.stringify(collection));

// Only change code below this line
function updateRecords(id, prop, value) {
  if (value === '') {
    delete collection[id][prop];
  } else if (prop !== 'tracks') {
    collection[id][prop] = value;
  } else {
    collection[id][prop].push(value);
  }
  return collection;
}

// Alter values below to test your code
updateRecords(5439, "artist", "ABBA");

Thankyou. actually I'm reporting an issue. I Have tried help but its not working.

@NaniAlex You have an error in your code. If you put the test case that is failing into the editor in place of the original function test (at the bottom) you will see that you can't do the .push() method because the array doesn't exist. Please use the help chat referenced by @VarCI-bot to get assistance. There's also a Help Javascript room that may be a good resource too.

I have the same problem and the answer of "dhcodes" (...ou will see that you can't do the .push() method because the array doesn't exist...) it made me think better. Then i create a property with empty array and next use .push() to append the value. And Voilá. Here my code below:
`
function updateRecords(id, prop, value) {
if (prop !== "tracks" && value !== "") {
collection[id][prop] = value;
} else if (prop === "tracks" && value !== "") {
  if(!collection[id].hasOwnProperty(prop)) {
    collection[id][prop] = []; //Create a property with empty array
    collection[id][prop].push(value); //Append a value into the array
  } else {
     collection[id][prop].push(value); //Append a value into the exist property array
  }

} else if (value === "") {
delete collection[id][prop];
}
return collection;
}
`

@andreilepsch Please do not post solutions on Github threads. You may discuss solutions and help others in the Gitter Help Chat room


Add support for tags

Any chance you'd consider adding support for Tags as a front matter and displaying a tag cloud on the feed page or homepage?

Basic Jekyll tags are created and added to my personal blog .
Current features are :

Supports front-matter tag, tags
Tag is shown right under the title on every note
When you click on the tag, it takes you to a single tags page, which lists all notes with `feed: show'.

Autogenerating page-per-tag is complex, and I am still confused if this is the best solution to offer. Give me one more week, and I will decide and will update the upstream.

@wrathagom : Another method of showing tags in Jekyll is by manually creating each tag as a page as a collection, and logically assigning them as tag-pages. Siteleaf does that. The approach is okay, but for someone with too many tags / ever-changing tags, I am not sure if this is the right way. Let me know your opinion.

To be honest, tags are noisy. It won't take long to get things bit messy. I'd prefer index pages with backlinks. It's minimal and elegant and my goto approach.


fix(expansion): Handle overflow in .mat-expansion-panel-body

Addresses: #7008

I tried this fix in my overflow situation and it did not fix it ... due to mat-expansion-panel-body actually grow to the size of its contents.  I am still trying to find a fix that works for me, I can post back if i find something.

http://plnkr.co/edit/O5SE55FZ1qlU1il9fh6v?p=preview
I am using codeMirror to display code in the toggled area.  My example just mocks the layout.
If you expand one it works fine, however if you expand more than one DUE to flexLayout making the expandable smaller the body container does not get smaller so it overflows into the next item.

the fix for this might be changing it from margin to padding:
.mat-expansion-panel-body {
  margin: 0 24px 16px;
  overflow: auto;
}


Handle inexistant config file

This PR is for #61.
@dlax is there a better way to do this ?

Did you try using a click.File() argument type? According to its documentation, click will try to open the file early enough to report I/O errors to the user:
$ check_patroni --config no-such-file
Usage: check_patroni [OPTIONS] COMMAND [ARGS]...
Try 'check_patroni --help' for help.

Error: Invalid value for '--config': 'no-such-file': No such file or directory

yes but a nagos plugin shoud return a string like "UNKNOWN: click.exceptions.UsageError: Config File not found" and RC 3 in that case.

Why 3? This is ESRCH 3 No such process. ENOENT 2 No such file or directory seems more appropriate.

It's the norm they propose in the Nagios Plugins Development Guidelines.
https://nagios-plugins.org/doc/guidelines.html#AEN78

I have pushed a better implementation, in branch "fix_configfile_error" on the main repo: https://github.com/dalibo/check_patroni/compare/fix_configfile_error (based on your commit).
The idea is to only handle IO errors in the configure() callback, and then possibly exit (with rc 3) from there.

WIth the version posted above:
$ check_patroni --config no-such-file
failed to read configuration: [Errno 2] No such file or directory: 'no-such-file'
$ echo $?
3
$ check_patroni --config /etc/postgresql/16/main/pg_hba.conf
failed to read configuration: [Errno 13] Permission denied: '/etc/postgresql/16/main/pg_hba.conf'
$ echo $?
3

ha yes, mutch better. Th. I'll use that one instead.


Loader without frame

💬 Questions and Help
Is it possible to have a loader without frame an text (only the loader...) @Cheesebaron @Redth thanks!

Do you want to change it for all occurrences or just one?
If you want to override the behavior you can always just create these layouts in your Application project and change the visuals:
https://github.com/redth-org/AndHUD/tree/main/AndHUD/Resources/layout
So adding:

Resources/layout/loading.xml
Resources/layout/loadingimage.xml
Resources/layout/loadingprogress.xml

Make sure Id's are the same as in here, or it might crash with null refs.
If you want to change for one occurrence, that will be a bit more challenging. We currently do not have a way to override the default behavior and do not expose the inflated layout. Perhaps you could get it from AndHUD.Shared.CurrentDialog somehow.


Feat(web-react): Deprecate off placement in Tooltip #DS-1078

Description

Additional context

Issue reference

coverage: 80.082% (-16.3%) from 96.371%
when pulling 4405db6377be56bb57cfd56aa1022219af6fad11 on feature/react-tooltip-off-deprecate
into 9920fbf6be8906acd11efc70d723a5d27ee60d17 on main.


MCUboot Zephyr port (--sysbuild) has insufficient .dram0 memory

Describe the bug
After recent changes in the Xtensa arch, the MCUboot build fails due to insufficient dram memory.
To Reproduce
Build the hello_world sample using any ESP32/ESP32S3 board with the --sysbuild flag, to see build process to fail.
Expected behavior
The MCUboot should build and load the slot0 application.
Impact
Show stopper.
Additional context
The CI tests are not catching the build issues.

fixing https://github.com/zephyrproject-rtos/zephyr/issues/74695


Fix e2e and integration tests

I think it’s fine that you merged this (since you were blocked) but the last commit (the default protocol stuff) was a bit of a hack.
I am still waiting for @sreuland and @leighmcculloch to get to a conclusion on how to best solve this. The problem seems to stem from the system tests “stealling” QuickStart’s start script.


Working on:  #3225

moment.duration(NaN).humanize() returns "a few seconds"
-- wrote test
-- have not yet resolved.

@bengio777 you need to go deeper than that. We'd need an isValid function and also a lot of ifs in all the mutators that keep it invalid no matter what, just like a NaN.

Closing as there has been no action. Feel free to re-open if you want to continue.


Improve and stabilise the import of content

From the CNCF Tech Docs assessment of our docs (cncf/techdocs#89):

Write down what areas are automatically pulled in from other repositories, what comes in from command line, etc.

This file is very fragile, as it points to specific files at their https://github.com/fluxcd/website/blob/main/hack/import-flux2-assets.sh and seems to have the potential to make the site build succeed but with unpredictable results.

Consider implementing Hugo Modules to bring things in in a less fragile manner.
Alternately, consider reducing the files brought in to the bare minimum and writing a set of unit tests for the website repository, ensuring that the build fails when files are moved or renamed.

Comments

Single source for all files: While all files are single sourced (that is, files are not duplicated), the build process which governs pulling in and building out some webpages is very fragile. In my career as a technical writer I have seen similar setups fail due to catastrophic fragility, particularly once the original code owners leave the organization.

It would be good to fully review the situation again. Since we moved a lot of our python code to be replaced by Hugo Data Templates we are in a better spot than we were last year.


Allow primary key configuration

Closing due to duplicate of https://github.com/soundcloud/lhm/pull/73


can not detect water

Please see this post.
https://github.com/arose/nglview/issues/589#issuecomment-309400305
I am able to reproduce the issue via uploading pdb file to: http://arose.github.io/ngl/

this is just a problem with the default representation, if you have something as uncommon as only water in a model it is best to choose your own representation


Uncaught (in promise) TypeError: Cannot read properties of null (reading 'id')

Just trying to use Marker and the API and I got this error. It shows up on page load intermittently suggesting its possibly some kind of async race condition.

I'm tracking this back to when I try to call setReporter and I think that I am calling setReporter in my state manager before the Marker Widget is ready for me to call it. Yet, the error is getting emitted for Marker's code so the fix should be on your end.
As for writing code to check if setReporter is safe for me to call; I don't want to, and shouldn't have to wrap a call to setReporter in an marker's on event handler method because that is not an acceptable workaround for bunch of reasons that I don't want to get into.
Thank you!

I have the same issue. Any news about this?

I'm facing the same issue. It's indeed triggered by attempting to call setReporter on a loaded widget.
Figuring this out might be significantly easier if there was some documentation for the loadWidget API, but I haven't been able to find any. While the provided API docs list all the widget methods and events, the contract of loadWidget itself is not listed anywhere AFAICS.


Q: How do you release?

Asking, as https://github.com/gaul/modernizer-maven-plugin/blob/8ddb06e85d9aa4cdb45504f937d6d4f9ec15d57d/pom.xml#L13 (current master!) still shows version 2.9.0! This means if anyone rebuilds locally, will replace the release downloaded from Maven Central.

Looks like I missed a step!  I manually run these commands for every release:
git rebase upstream/master
mvn versions:set -DnewVersion=1.2.2
git add -p
git commit -m 'modernizer-maven-plugin 1.2.2 release'
\mvn clean deploy -P release
git tag -a modernizer-maven-plugin-1.2.2 -m 'modernizer-maven-plugin 1.2.2 release'
mvn versions:set -DnewVersion=1.3.0-SNAPSHOT
git add -p
git commit -m 'Bump to 1.3.0-SNAPSHOT'
git push upstream master
git push upstream --tags

I haven't changed this process in 10 years -- is there a better way?

@cstamas any other cleanups we could make here?  I would like to make a new release soon.

Nope, all looks good, thanks! Parent and staging plugin are gone, that was my goal.

Thanks!  Please open other issues if you spot potential improvements.


⚠ Bofrost.at has degraded performance

In 445d01e, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1476 ms

Resolved: Bofrost.at performance has improved in 6f8f8ee after 13 minutes.


StaticContent: handle empty {path...}

My error was to use /static/* as the route instead of /static. Because of this the path variable was empty and it crashed.
Maybe there should be a way to prevent this kind of user error. Documenting StaticContent would be a first step.
Also don't try to read the basePath folder as a file when path is empty.

Fixed with new static { … } DSL


Fix Polaris Links Fail to Render with nil Content

Hi, thanks for the lovely gem.
Description
Most of the Polaris components have no worries to render contents that are possible to have nil objects like
polaris_heading { product.sku } #=> could be nil, <div class="class="Polaris-Card__Header">....
# etc ...

However, using polaris_link seems to fail on the content that could be nil ones
polaris_link(...) { product.sku } #=> undefined method 'strip' for nil:NilClass

Probably we could make those behaviours more consistent?

This is great! Thanks for your contribution. I will include this in v0.13.6.


nn.BiSequencer, cudnn and non-contiguous input

I'm having a problem using nn.BiSequencer() with cudnn.
Here's a simple example:
require 'rnn'
require 'cunn'
require 'cudnn'

batch_size = 16
maxLen = 100
nFeat = 201
hiddenSize = 256

net = nn.Sequential()
net:add(nn.SplitTable(1,2))
net:add(nn.BiSequencer(nn.FastLSTM(nFeat,256),nn.FastLSTM(nFeat,256),nn.CAddTable(true)))
net:cuda()
cudnn.convert(net,cudnn)

inputs = torch.randn(batch_size,maxLen,nFeat):cuda()
outputs = net:forward(inputs)

Here's the error I get: cudnn/Pointwise.lua:11: Non-contiguous inputs not supported yet
I read through some closed issues and tried these variations for the network. None of them work, unfortunately.
net = nn.Sequential()
net:add(nn.Transpose({1,2})
net:add(nn.SplitTable(1)) -- trying to maintain contiguous inputs for the BiSequencer
net:add(nn.Copy(nil,nil,false)) -- really trying to maintain contiguous data for the BiSequencer
net:add(nn.BiSequencer(nn.FastLSTM(nFeat,256),nn.FastLSTM(nFeat,256),nn.CAddTable(true)))
net:cuda()
cudnn.convert(net,cudnn)

Any help would be appreciated.

I found similar problem in nn.FastLSTM for cuDNN R5. Here an example:
lstm = nn.FastLSTM(2,10)
lstm:cuda()
cudnn.convert(lstm, cudnn)

Non-batch mode works fine
lstm:forget()
lstm:forward(torch.rand(1, 2):cuda())

Batch mode does not work
lstm:forget()
lstm:forward(torch.rand(4, 2):cuda())

Here is the error message:
In 1 module of nn.Sequential:
In 1 module of nn.ConcatTable:
In 6 module of nn.Sequential:
In 1 module of nn.ParallelTable:
... Non-contiguous inputs not supported yet

So that is the cudnn.Sigmoid (and possibly the other 3 cudnn activations) when computing LSTM gates.
Is there a plan to adopt cuDNN R5's LSTM and GRU API? I heard they much faster from NVIDIA's recent talk at my university.

@NorThanapon Yes there is a plan : https://github.com/borisfom/cudnn.torch/pull/3 . In the mean time, you can use Justin's super fast SeqLSTM : #207 . Not sure if it will solve your bug though.

Thanks @nicholas-leonard, I tried SeqLSTM. It is faster than FastLSTM on GPU.
cudnn.convert(seqlstm, cudnn) works as well, but this does not give any speed up to basic SeqLSTM.

@NorThanapon cudnn is not expected to give speed-up over basic SeqLSTM - most of the work is in the Linear layers that are mapped to cublas, not cudnn. The only thing that gets mapped to cudnn is activations which are  a small fraction of computation and nn implementation of those is reasonable. Same would be true for FastLSTM - even if you could convert it to cudnn, you wouldn't see a speedup. But stay tuned for torch bindings for cudnn LSTM implementation.


Update cross-spawn to 7.0.5 or higher

We detected that scala-steward-action uses cross-spawn lib lower then 7.0.5 , which introduces high  vulnerability as stated in https://security.snyk.io/vuln/SNYK-JS-CROSSSPAWN-8303230 .  This issue prevents us from using the action
Please update cross-spawn to 7.0.5 or higher
Scan results:

Thank you

Hey @aazimova, just released v2.72.0 including that change.

Thank you


Where is the setup.py?

Where is the setup.py?

It isn't there. He doesn't upload it to github

He should if we want to build the package from source.

I think he builds locally. (I too don't build from github lol)

Some people build from source though

Ok

I agree, a setup py file would be nice since it could install packages like pymitter for you. Also, why is numpy and wsaccel in the code if it's not needed?

Ok


Changed docs giving honor

I think its vital toi give honer  to the previous team, I ve changed the docs to reflect this. While making it clear ours is ours.

closing for now, will take this one after the repo is actually ready, and ill gyide you thru the process.


Add draft mode

Add a small paragraph for the incoming draft mode feature. Feel free to change anything.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


Remove Deep Quote Code

Let's drop the deep quote code

It only works on xen, is anyone using xen (I am not sure if even works on current xen versions)?
We have had security researchers pick holes in the code. Considering point 1, its a false optic having it there.

I propose we let this sit for Jan and then nuke it in a 6.x release.

Not sure it works on xen now but pretty sure logic around it was broken for quite a time.
Speaking about security, I suggest we consider using popular api framework for agent and registrar, they are implementing http service on std lib, which is discouraged in production environment.

Not sure it works on xen now but pretty sure logic around it was broken for quite a time.
Speaking about security, I suggest we consider using popular api framework for agent and registrar, they are implementing http service on std lib, which is discouraged in production environment.

I agree with @kaifeng that the logic around deep quote is broken. Add to that the fact that it is not TCG compliant and has serious issues (some were pointed out by @stefanberger a while ago).
How much of the "provider" keylime infrastructure goes away along with the deep quote? @lhinds I am assuming you are not just referring to the "deepquote" function in tpm_abstract.py

My criticism about deep quote is how can one establish trust top-down if 'down' may be completely corrupted? If you do it, you have to do it bottom-up, just like the BIOS taking measurements, then the bootloader, then the OS -- all bottom-up.

To piggy back on this discussion, the deep quote was originally of course for VMs as a workaround (to grab the nearest word) for a lack of no HWRootOfTrust. If anyone has any ideas of an implementation to leverage trust into containers / vms they would like to propose and experiment with in Keylime - I would heartily recommend to go for it.
We have this work that was trailed out a year ago: https://github.com/keylime/keylime/wiki/VTPM-Design

My thought on the VM world is treating VMs the same way as Hosts. If we trust swtpm/qemu running at the underlying OS, we should be able to trust the EK Cert (if memory serves, swtpm can do this) as well as the EK goes with it.

@kaifeng That is if the machine is trusted to be instrumented with trusted boot and IMA (rather than a corrupted machine loading some extends into the pcrs that make it look good) and the recipient of the quote and EK certificate knowing for sure that the VM is located on top of this host (rather than the corrupted host forwarding the quote request to a remote machine).


HoloCure [HoloCure] - Unable to load VPK Bubble

VPK goes into error after the splash screen. Asset folder remains empty
Crash dump, log, and cfg files are attached:
HOLOCURE0.zip
The game works fine when launched thru the application using the same config.

This is not compatibility list.


Renewals file not written

As you may remember I'm running win-acme on a file cluster with Clustered task. Therefore I create all new certificates with notaskscheduler. This prevents creation of two tasks doing the same, but one that does not work in the cluster.
Today I added some new certificates and found the new certificates are missing in Renewals file. Good luck that I reviewed this file... how can the line automatically added to the Renewals file if I use notaskscheduler?
Version <IP_ADDRESS>

I there is currently no way to do that. --notaskscheduler implies to the code that you don't care about renewal. That assumption is highly debatable of course, so I've made some changes for the next release.

Could you explain shortly what the change does or if it requires an additional command line param, please?


🐛 BUG - "Orphaned" breadcrumb link is missing underline

Cc: @bradystroud
Hi @BrookJeynes
Describe the Bug
If you go to an Orphaned rule (e.g. https://ssw.com.au/rules/sign-in-risk-policy/)
The "Orphaned" link on breadcrumb is missing an underline (that doesn't happen with normal categories... ideally they should share the very same CSS)

Tasks

[x] Investigate
[x] Fix

Thanks!

This is done ⭐
https://ssw.com.au/rules/create-a-combo-box-that-has-a-custom-template/


[Fix] Confirm button

Se fixea el doble botón que aparecía en Revisa y Confirma.
Se probó en un dispositivo real.
Antes

Después

Codecov Report

Merging #907 into feature/review_and_confirm will decrease coverage by <.01%.
The diff coverage is 0%.

@@                      Coverage Diff                       @@
##           feature/review_and_confirm     #907      +/-   ##
==============================================================
- Coverage                       30.83%   30.82%   -0.01%
==============================================================
  Files                             359      359
  Lines                           17713    17717       +4
  Branches                         1603     1603
==============================================================
  Hits                             5462     5462
- Misses                          11599    11603       +4
  Partials                          652      652

Impacted Files
Coverage Δ

...o/review_and_confirm/ReviewAndConfirmActivity.java
0% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08a1c5a...637eeea. Read the comment docs.


Fix unnecessary break when calculating the height of visible lines

This break causes the minsize to be smaller than expected, and then the size keeps increasing by one line to cover all visible lines. This can cause performance issues when there are many visible lines.
Fix  #77268.

Removing these codes directly seems to make #74052 worse.

Tested locally (rebased against master a83eb16fba5bb3da086b41cbd79e6f95b09eb8ee), I don't see any regression. However, I couldn't reproduce the original issue locally: https://github.com/godotengine/godot/issues/77268#issuecomment-1595976255

CC @bruvzg

Note for @YuriSizov: If we want to cherry-pick this for 4.1.x (which may be good given that it fixes a significant performance issue), we need to handle #80218 there too. Your diff in https://github.com/godotengine/godot/issues/80218#issuecomment-1669527304 might be suitable?

@akien-mga Unfortunately that diff can only be used as a reference. In 4.1 we would need to give min sizes to labels in each validation form individually. The principle would be the same, just a bit more laborious.

Given that we can trace various sizing issues to this PR, I wouldn't go for cherry-picking it into 4.1. If we were to do this, we would need to port all follow-up fixes as well, which seems more effort than it's worth at this point.


Improve coverage of ApplicationController#show_index_of_objects

Working towards getting 100% coverage before refactoring.

Coverage: 93.398% (+0.04%) from 93.357% when pulling d3db37293aff1ecbc0fdec61a2c8be3f725b9afa on show-index-coverage into ea581808e6b56fe750ce0d7369199b8a3c98173a on main.

An example of the changed behavior on my local system is: http://localhost:3000/names?by_user=10000&id=1
The current code reports: "No matching names found."
The new code reports: "Faun hasn’t created any names."

@mo-nathan: Thanks for tackling this gnarly method.
@pellaea: Thanks for the very helpful explanation!
I think I prefer the current message:

The new message seems better (at least at first glance), in Nathan's example,
but the old message is acceptable.
The new message is misleading in the case cited by Jason.
For example (via the UI), if:

I change my Preferences to "Oregon, USA";
do a User-type PatternSearch for "RenegadeMycologist";
click Observations

The new result is "Dušan hasn’t created any observations" for a user who actually created 956 Observations, but none in Oregon.
I supposed that could be tweaked to something like "Dušan hasn’t created any observations matching your filter". But implementing that that seems overly complicated to, and outside the scope of this PR.

How many people actually use content_filter?
users_with_non_redundant_filters = User.where.not(content_filter: {}).where.not(content_filter: {:has_images=>nil, :has_specimen=>nil, :region=>"", :lichen=>"", :clade=>""}).count
 => 1936

Wow.  I had no idea it would be that popular.  Amazing.
On Sun, Jan 29, 2023 at 1:20 PM Joseph D. Cohen @.***>
wrote:

How many people actually use content_filter?
users_with_non_redundant_filters = User.where.not(content_filter: {}).where.not(content_filter: {:has_images=>nil, :has_specimen=>nil, :region=>"", :lichen=>"", :clade=>""}).count
=> 1936
—
Reply to this email directly, view it on GitHub
https://github.com/MushroomObserver/mushroom-observer/pull/1318#issuecomment-1407734701,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAYTNNJV45TGQS5MDWVRTGDWU2YIPANCNFSM6AAAAAAUKIQEPI
.
You are receiving this because you were mentioned.Message ID:
@.***>

Wow. I had no idea it would be that popular. Amazing.

@pellea: My number is way wrong. My AR query doesn't do what I expect.
> users_with_non_redundant_filter = User.where.not(content_filter: {}).where.not(content_filter: {:has_images=>nil, :has_specimen=>nil, :region=>"", :lichen=>"", :clade=>""})
 =>
> users_with_non_redundant_filter.first.content_filter
 => {:has_images=>nil, :has_specimen=>nil, :lichen=>"", :region=>"", :clade=>""}

Note the different order of the keys.
Maybe the query is converting converting content_filter to a string instead of using Hash#==? Maybe that's because we serialize the filter?

435 is the actual number of users with a non-redundant content_filter. (It's still higher than I expected.)
> foo = []
> users_with_non_redundant_filter.each {|u| foo << u unless u.content_filter == {:has_images=>nil, :has_specimen=>nil, :region=>"", :lichen=>"", :clade=>""} }
...
> > foo.length
 => 435

(Couldn't figure out how to do this as an AR query.)

Thanks, Joe!  That's tricky!
-Jason
On Sun, Jan 29, 2023 at 2:59 PM Joseph D. Cohen @.***>
wrote:

435 is the actual number of users with a non-redundant content_filter.
(It's still higher than I expected.)

foo = []
users_with_non_redundant_filter.each {|u| foo << u unless u.content_filter == {:has_images=>nil, :has_specimen=>nil, :region=>"", :lichen=>"", :clade=>""} }
...

foo.length
=> 435

(Couldn't figure out how to do this as an AR query.)
—
Reply to this email directly, view it on GitHub
https://github.com/MushroomObserver/mushroom-observer/pull/1318#issuecomment-1407755933,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAYTNNORWWW4A73DMZ5GGATWU3DYPANCNFSM6AAAAAAUKIQEPI
.
You are receiving this because you were mentioned.Message ID:
@.***>

That's still too high. Actual 254. (I had wondered if the number was small enough so that we didn't have to care about the correct error message.)
> foo = []
> User.where.not(content_filter: {}).each { |u| foo << u if u.content_filter[:has_images].present? || u.content_filter[:has_specimen].present? || u.content_filter[:lichen].present? || u.content_filter[:region].presen
t? || u.content_filter[:clade].present? }
...
 > foo.length
 => 254

I can live with any of the three options, including especially deleting the
whole thing and replacing it with a single generic "no matches!" message. :)
On Sun, Jan 29, 2023 at 9:09 PM Nathan Wilson @.***>
wrote:

@.**** commented on this pull request.
In app/controllers/application_controller.rb
https://github.com/MushroomObserver/mushroom-observer/pull/1318#discussion_r1090118207
:

@@ -1436,53 +1436,57 @@ def show_index_of_objects(query, args = {})
query_params_set(query)

 # Supply default error message to display if no results found.

if (query.params.keys - query.required_parameters - [:by]).empty?

Thanks! I got buried in a semi-urgent disk recovery situation that has
been a lot more painful than expected.
Anyway, the challenge I have with the current code is there doesn't appear
to be an obvious way to get to the more specific error messages as the code
is currently written, but if you turn off that condition you can.
Personally, I don't see a big problem with "There are no observations by
Alan" if the person has somehow bent over backwards trying to get
observations about Antarctica by Alan, then they should have the context.
However, I'm also fine with the more generic error. That's certainly the
simplest thing to do and it eliminates code which is great for helping with
the ABC metric! Given your descriptions, I'm leaning towards just making it
simple and having a single error message.
—
Reply to this email directly, view it on GitHub
https://github.com/MushroomObserver/mushroom-observer/pull/1318#discussion_r1090118207,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAYTNNJ73SXCGYDG6RC4YCDWU4PGTANCNFSM6AAAAAAUKIQEPI
.
You are receiving this because you were mentioned.Message ID:
@.***
com>

Agreed, go for it!
On Wed, Feb 15, 2023 at 10:30 AM Joseph D. Cohen @.***>
wrote:

@.**** approved this pull request.
IMO we should merge this.

We gain a big benefit from increased coverage of a key method.
This change in the flash (when an object isn't found) is an
improvement for most users.
The arguable detriment (caused by the message change) to the other
users is:

Outweighed by the above benefits, and
If anyone complains, can be improved in the future.

—
Reply to this email directly, view it on GitHub
https://github.com/MushroomObserver/mushroom-observer/pull/1318#pullrequestreview-1299729979,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAYTNNJOG6JOCTNQKUMSV5DWXTZBRANCNFSM6AAAAAAUKIQEPI
.
You are receiving this because you were mentioned.Message ID:
@.***
com>

Thanks! Will do.
On Wed, Feb 15, 2023 at 8:06 AM Jason Hollinger @.***>
wrote:

Agreed, go for it!
On Wed, Feb 15, 2023 at 10:30 AM Joseph D. Cohen @.***>
wrote:

@.**** approved this pull request.
IMO we should merge this.

We gain a big benefit from increased coverage of a key method.
This change in the flash (when an object isn't found) is an
improvement for most users.
The arguable detriment (caused by the message change) to the other
users is:
Outweighed by the above benefits, and
If anyone complains, can be improved in the future.

—
Reply to this email directly, view it on GitHub
<
https://github.com/MushroomObserver/mushroom-observer/pull/1318#pullrequestreview-1299729979
,
or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/AAYTNNJOG6JOCTNQKUMSV5DWXTZBRANCNFSM6AAAAAAUKIQEPI
.
You are receiving this because you were mentioned.Message ID:
@.***
com>

—
Reply to this email directly, view it on GitHub
https://github.com/MushroomObserver/mushroom-observer/pull/1318#issuecomment-1431610696,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAALDFEX673S6GX6CI6XE2DWXT5KDANCNFSM6AAAAAAUKIQEPI
.
You are receiving this because your review was requested.Message ID:
@.***>


Ignore lines starting with "#" in wordlist

Some wordlists, such as directory-list-2.3-medium.txt have annoying comments (license preamble) which ffuf tries to use as legitimate words.
This creates:
...
 :: Threads          : 40
 :: Matcher          : Response status: 200,204,301,302,307,401,403
________________________________________________

# This work is licensed under the Creative Commons .html [Status: 200, Size: 345, Words: 41, Lines: 25]
# directory-list-2.3-medium.txt [Status: 200, Size: 345, Words: 41, Lines: 25]
#.php                   [Status: 200, Size: 345, Words: 41, Lines: 25]
# directory-list-2.3-medium.txt.php [Status: 200, Size: 345, Words: 41, Lines: 25]
# directory-list-2.3-medium.txt.html [Status: 200, Size: 345, Words: 41, Lines: 25]
# This work is licensed under the Creative Commons .php [Status: 200, Size: 345, Words: 41, Lines: 25]

I think it would make sense to ignore lines starting with "#" by default.

-ic argument does that.

Ooo, TIL.. I should have RTFM better :dagger:
Thanks


[stable/cratedb] - helm chart for the CrateDB

Signed-off-by: Manoj Prasanna Handapangoda<EMAIL_ADDRESS>
What this PR does / why we need it:
Helm chart for CrateDB
This is the initial implementation of the helm chart for the minimal version of the database CrateDB which is a distributed SQL database built on top of a NoSQL foundation. This is will enable users to create the CrateDB using helm chart easy and configurable way.
Special notes for your reviewer:
This is the first implementation of the chart for CrateDB.
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] title of the PR contains starts with chart name e.g. [stable/chart]

/assign @cpanato

hey @hmdmph
Have you considered hosting this chart and adding it to helm hub?
https://github.com/helm/hub/blob/master/Repositories.md

Hi @maorfr,

Have you considered hosting this chart and adding it to helm hub?
https://github.com/helm/hub/blob/master/Repositories.md
as of now no, You mean deploy this chart in some other repo(like github pages)?

see my comments, thanks for this PR :)
@cpanato Addressed PR comments.

see my comments, thanks for this PR :)

@cpanato addressed your PR comments. Thanks.

Github pages is a great way to host your own charts!
This will give you more freedom around management, and you will not be blocked by us (maintainers).
This means that when users want to install your chart, instead of installing them from stable, they will install it from (for example) mycompany-charts:
$ helm install --name my-release mycompany-charts/mychart
Here are some instructions about how to host your own charts repo:
https://github.com/helm/hub/blob/master/docs/github.md#github-pages-as-a-repository
In order for people to find out about your charts repo, you should add it to helm hub:
https://hub.helm.sh/
Here are some instructions about how to add your charts repo to helm hub:
https://github.com/helm/hub#how-to-add-your-helm-charts


WIP - Switching Qiskit documentation from using sphinx.ext.viewcode to sphinx.ext.linkcode extension

Summary
This addresses https://github.com/Qiskit/documentation/issues/517 by switching out the sphinx.ext.viewcode for the sphinx.ext.linkcode extension which allows our GitHub links in the documentation to be linked to the specific lines of code, not just the file. This was tested successfully in https://github.com/Qiskit/qiskit_sphinx_theme/pull/589 so now we want to implement it in the qiskit, runtime, and provider repos.
Details and comments
This is still a Work In Progress as ideally we'd like to link to the code in the branch matching the specific version of Qiskit that the documentation is referring to. More work needs to be done to allow us to do that.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
5 unchanged lines in 1 file lost coverage.
Overall coverage increased (+2.6%) to 91.88%

Files with Coverage Reduction
New Missed Lines
%

crates/qasm2/src/lex.rs
5
91.94%

Totals

Change from base Build<PHONE_NUMBER>:
2.6%

Covered Lines:
54724

Relevant Lines:
59560

💛  - Coveralls


add set fan_min_on_time thermostat service

Description:
Related issue (if applicable): #
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#
Example entry for configuration.yaml (if applicable):

Checklist:
If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated in home-assistant.io

If code communicates with devices:

[x] Local tests with tox run successfully. Your PR cannot be merged unless tests pass
[x] New dependencies have been added to the REQUIREMENTS variable (example).
[x] New dependencies are only imported inside functions that use them (example).
[x] New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
[x] New files were added to .coveragerc.

If the code does not interact with devices:

[ ] Local tests with tox run successfully. Your PR cannot be merged unless tests pass
[ ] Tests have been added to verify that the new code works.

This is to create a service that allows you to set the minimum fan run time per hour as per ecobee's api: https://www.ecobee.com/home/developer/api/documentation/v1/objects/Settings.shtml , under fanMinOnTime. The nest seems to have similar functionality but I wasn't able to nail it down. Wasn't sure how to add a thermostat service just to the ecobee component so I added it to the thermostat component. Any feedback is appreciated.
Still waiting on https://github.com/nkgilley/python-ecobee-api/pull/6 to be merged before updating the components/ecobee.py requirements. Also trying to determine what documentation needs to be updated.
Want to get this PR out there to get some feedback on the added functionality before updating the documentation.

I wonder if this is a common service that all thermostats should have or that this is something that we should only add to the ecobee. I'm leaning to the latter.

@balloob I agree with you. I just couldn't figure out how to expose that service just on the ecobee thermostat. Some guidance would be appreciated :)

Like this: https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/media_player/sonos.py#L73-L92

Since this new service modifies a state attribute you should update the dict in the state helper to support scenes.
https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/helpers/state.py#L39-L55

@balloob and @MartinHjelmare can you please review this again. I've made it so this service is exposed only to the ecobee thermostat and I updated the dictionary accordingly. I'm not sure what that build error is. If I add a line where it says to do so the build fails expecting 1 line. If i remove the line the build fails says it expects 2 lines. Not sure what to do about that.
Cheers,

One minor comment. Otherwise, this looks good to me.

Looks good! :dolphin:


/deep/ combinator is deprecated.

See https://www.chromestatus.com/features/6750456638341120 for more details.
Also see W3 and Google Groups.
Warning comes from Chrome 45.0.2454.85. Code called into question:
  // scroll to the element with id="hash" or name="hash"
  function scrollToHash(hash) {
    if (!hash) return;

    // wait for the browser's scrolling to finish before we scroll to the hash
    // ex: http://example.com/#/page1#middle
    // the browser will scroll to an element with id or name `/page1#middle` when the page finishes loading. if it doesn't exist
    // it will scroll to the top of the page. let the browser finish the current event loop and scroll to the top of the page
    // before we scroll to the element with id or name `middle`.
    setTimeout(function() {
      var hashElement = document.querySelector('html /deep/ ' + hash) || document.querySelector('html /deep/ [name="' + hash.substring(1) + '"]');
      if (hashElement && hashElement.scrollIntoView) {
        hashElement.scrollIntoView(true);
      }
    }, 0);
  }

:+1: this is annoying


add names to the trait lowering rules

This allows cross-references from the code.

Thanks :smile:


License?

I'd love to use your library but you haven't specified a license. I don't want to break any rules!

Thank you for your interest in my library. I don't know yet about the license.  I will have one as soon as possible.

License added


Roadmap - First Release

Current Status
We are currently working towards a first "official" release (incl. a nice landing page). Yes, we already have some NPM packages out there, however, we only wanted to refine our CI process / workflow and protect the package names. ~At this point in time nothing should be considered stable or officially supported.~
Update: The Pilet API is stable, the way of creating a Piral instance is quite stable, too. Everything is officially supported.
First Draft Release
We hope that we can publish a first release candidate (RC) end of November 2019. This release will also include a feed with sample pilets to easily play around.
Update: A first RC (0.9) was released. With the upcoming 0.10 we publish the second RC.
Official Support
In the end of Q4 2019 we should be ready to offer some premium support on top of the standard open-source development if desired.
Update: If you need enhanced support then just contact us. We are here to help.

For the always up-to-date roadmap visit the milestones outlined here on GitHub.
We always plan at least 2 releases in advance.

This info is now no longer needed. The next release is the v1.


isHardwareDetected() not working on iOS

isHardwareDetected function works properly for Android; it returns true if device has the capability but user hasn't enrolled any fingerprints, but the method doesnt work the same for iOS.
Am I missing something?

Hi,
I've investigated this problem and it occurs because somehow this method was not implemented in iOS. I would recommend you to use isSensorAvailable instead.
On next release isHardwareDetected will be removed.


⚠ Bofrost.at has degraded performance

In 2a31149, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 957 ms

Resolved: Bofrost.at performance has improved in 4e50c53 after 7 minutes.


Specs for undoing 'git prune-branches'

@charlierudolph @allewun
Implements #396

I have addressed most comments. Please take another look!

Bump
This PR is getting old  :)

All comments addressed

bump

All comments addressed

All comments addressed

all comments addressed

:ship: after comments are addressed


refactor: move basePath from ContentService to BaseContentController

Coverage remained the same at 100.0% when pulling 0b9df88739a194df539330556edcc0f5ba75e843 on refactor/basepath into e64c63dee68d96ce640edd44016bcbc501af0a99 on master.


Add a soft timeout if a request’s duration is close to the timeout

Requests that time out are flaky if their duration is close to the timeout level, because they will sometimes finish within the allowed time and sometimes fail. This is especially true if the machine is under heavy load, which is common when stress testing a project.
To mitigate some of this flakiness, introduce soft errors: Whenever a requests takes more than half of the allowed time, throw a soft error. This error will match an XFail, but will not fail the stress tester on its own.
So the idea is to have all of the potential timeout cases in the XFails file. We will only be required to remove it from there, if its execution duration has improved significantly (by more than 2x).

@swift-ci Please test

@swift-ci Please test

Build failed
Swift Test OS X Platform
Git Sha - 432ed671afaa19cf311f56249ec923acd40f113c

@swift-ci Please test

Build failed
Swift Test OS X Platform
Git Sha - 925acbdcfe472ef0b7041b7f7dd6e667fcabdbf7


Issues installing/running

OS:
Windows 10 Pro x64
Issue Descriptions:
Cannot start application with 2 different versions (3.2.1 & 3.2.4).  Attached are logs.
SquirrelSetup.txt
Steps to Reproduce:
Launch installer

For anyone elses reference it turned out to be a security issue with Kaspersky Antivirus blocking the app starting.

@LostInIgnorance Couple of questions.

Are you running this on a Work or Personal computer?
Are you an administrator?
Do you have A/V protecting your PC?

Yep, only making it easier for the next searcher.


Remove old implement of c++20 coroutine

Codecov Report

Merging #26 (e0143a1) into v2 (ad42e5a) will increase coverage by 0.23%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##               v2      #26      +/-   ##
==========================================
+ Coverage   86.97%   87.21%   +0.23%
==========================================
  Files          26       26
  Lines        1420     1423       +3
==========================================
+ Hits         1235     1241       +6
+ Misses        185      182       -3

Impacted Files
Coverage Δ

include/libcopp/coroutine/coroutine_context_base.h
100.00% <ø> (ø)

...de/libcopp/coroutine/coroutine_context_container.h
86.00% <ø> (ø)

include/libcopp/future/future.h
96.96% <ø> (ø)

include/libcopp/future/storage.h
80.68% <ø> (ø)

include/libcopp/stack/stack_pool.h
84.54% <ø> (ø)

include/libcopp/utils/atomic_int_type.h
100.00% <ø> (ø)

include/libcopp/utils/intrusive_ptr.h
97.14% <ø> (ø)

include/libcopp/utils/lock_holder.h
90.00% <ø> (ø)

include/libcopp/utils/spin_lock.h
100.00% <ø> (ø)

include/libcotask/impl/task_impl.h
100.00% <ø> (ø)

... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad42e5a...e0143a1. Read the comment docs.


Force requirement wtforms>=2.0.0

Reported by @flx42
If you have wtforms==1.0.1 installed from the ubuntu deb package python-wtforms, and then run pip install -r requirements.txt, you would expect pip to install wtforms>=1.0.5 since requirements.txt includes the line Flask-WTF>=0.11 and Flask-WTF==0.11 requires wtforms>=1.0.5 (see here).
But it doesn't. So we have to specify the requirement again.

@flx42 would you mind testing this since you already have the Dockerfile in place?

Works fine! Thanks!


'Speech2Text' has no attribute 'from_pretrained'

insatall espnet_model_zoo and torch successfuly but get follow errors:
speech2text = Speech2Text.from_pretrained(
AttributeError: type object 'Speech2Text' has no attribute 'from_pretrained'

I'm not sure why it happened.
Could you show the version of espnet?
import espnet
print(espent.__version__)
print(espent.__file__)

print(espent.file)

print(espnet.version)
0.9.9
print(espnet.file)
/home/miniconda3/envs/espnet/lib/python3.8/site-packages/espnet/init.py

It's too old. Please update espnet

It's too old. Please update espnet

update it to latest，it work
may i ask another two question?

how to load local model,?
how to run model on gpu?

I think you can easily understand more detail just by reading asr_inference.py

how to load local model,?

You can use the following arguments:
https://github.com/espnet/espnet/blob/2e91e23e50ec05819ddf0c0f756f8aecce52048f/espnet2/bin/asr_inference.py#L53-L57
*_mode_file  should be a .pthfile, and_train_configis a*.yaml` file.

how to run model on GPU?

Please use the following:
https://github.com/espnet/espnet/blob/2e91e23e50ec05819ddf0c0f756f8aecce52048f/espnet2/bin/asr_inference.py#L62

I think you can easily understand more detail just by reading asr_inference.py

how to load local model,?

You can use the following arguments:
https://github.com/espnet/espnet/blob/2e91e23e50ec05819ddf0c0f756f8aecce52048f/espnet2/bin/asr_inference.py#L53-L57
*_mode_file should be a _.pthfile, and__train_configis a*.yaml` file.

how to run model on GPU?

Please use the following:
https://github.com/espnet/espnet/blob/2e91e23e50ec05819ddf0c0f756f8aecce52048f/espnet2/bin/asr_inference.py#L62

thanks


Upgrades to oxigraph 0.4

Uses RdfFormat type
Uses the loader "path" argument if possible to skip Python entirely

CC @nikokaoja


sqlx-cli support on sqlite and mysql

The readme in sqlx-cli/ says

database and migrate subcommands support only Postgres; MySQL and SQLite are TODO.

But it seems to be working for me. Is support incomplete or is the readme outdated?

The README is outdated. We'd welcome a PR to update it.

The README is outdated. We'd welcome a PR to update it.

I'm reading this issue from my phone. I'll send a PR tomorrow when I'm on my pc.
It's funny that the README is outdated because that's what was keeping me away from using sqlx,  haha. This time I decided to give it a try by pure chance.

I'm reading this issue from my phone. I'll send a PR tomorrow when I'm on my pc.
It's funny that the README is outdated because that's what was keeping me away from using sqlx,  haha. This time I decided to give it a try by pure chance.


why does the game crashes when the blue sentinel is active

BlueSentinelLog_22-08-21.txt

Known issue with blue sentinel. Not something I can fix, talk to the authors of BS.


Nginx-Ingress should depend on AWS Loadbalancer

Description
When setting enable_aws_load_balancer_controller = true and enable_aws_load_balancer_controller = true it is necessary to use targeted destroys to make sure the ingress is being teared down before the loadbalancer as otherwise there will be finalizers left over that cannot be resolved anymore. (see: https://github.com/aws-ia/terraform-aws-eks-blueprints/tree/main/examples/ingress-controllers/nginx)
This could be resolved by letting the ingress-nginx module explicitly depend on the load balancer module.
Versions

Module version: 4.12.1

Terraform version: 1.2.9

Reproduction Code
See: https://github.com/aws-ia/terraform-aws-eks-blueprints/tree/main/examples/ingress-controllers/nginx
Expected behaviour
terraform destroy just works
Actual behaviour
terraform destroy needs to be run multiple times with defined targets

Functionally, external LB like AWS ELB works with/without ingress controller on the cluster like ingress-nginx. And the opposite is true as well. Also, it is possible to use in in-tree NLB support with ingress-nginx without the AWS LB controller.
There shouldn't be any dependency among ingress controller and AWS LB controller, especially there are other ingress controllers like traefik, haproxy... such "dependency" will become a maintenance nightmare.

I am not sure if I fully understand your concerns. This would not be a hard dependency. As long as you do not enable the AWS LB controller the count for the LB will be 0 and the dependency will still be fulfilled.
We are working around that issue by loading the ingress-nginx addon directly and adding the dependency there.

My apology, the title may sounds like one but after seeing your changed this is indeed not a "hard" dependency.


click Even on carousel-item

Hello,
I'm implementing this with angularjs, But I' m not able to use ng-click on carousel-item. Can any one help me out?

please check the https://github.com/mihnsen/ui-carousel/issues/31
there is a simple solution that worked with me
ng-click="$parent.$parent.theFunction()"


Queue::fake enabled in service container only after the second call

Laravel Version: 5.4.36
PHP Version: 7.1.4-1
Database Driver & Version: N/A

Description:
While unit testing jobs being pushed in queue, it looks like the fake queue handler is not immediatly available from the service container (here and here) after Queue::fake() has been called.
The job being tested is then actually pushed to the real queue and cannot be asserted.
Steps To Reproduce:
Queue::fake();
var_dump(get_class(Queue::getFacadeRoot()));
// |-> string(42) "Illuminate\Support\Testing\Fakes\QueueFake"
var_dump(get_class(app()->make(Illuminate\Contracts\Queue\Factory::class)->connection()));
// |-> string(26) "Illuminate\Queue\SyncQueue" // not swapped
Queue::fake();
var_dump(get_class(Queue::getFacadeRoot()));
// |-> string(42) "Illuminate\Support\Testing\Fakes\QueueFake"
var_dump(get_class(app()->make(Illuminate\Contracts\Queue\Factory::class)->connection()));
// |-> string(42) "Illuminate\Support\Testing\Fakes\QueueFake" // correctly swapped

Strangely, if I try to access it from the service container before to fake it, it works :
app()->make(QueueFactoryContract::class)->connection();
Queue::fake();
var_dump(get_class(Queue::getFacadeRoot()));
// |- string(42) "Illuminate\Support\Testing\Fakes\QueueFake"
var_dump(get_class(app()->make(Illuminate\Contracts\Queue\Factory::class)->connection()));
// |- string(42) "Illuminate\Support\Testing\Fakes\QueueFake"

Please share an example test where Queue:fake fails to catch a job? It always worked for me.

Just realised you're on Laravel 5.4, it's not supported anymore. Can you please try to replicate on a 5.5 instance and ping me to re-open the issue?

ping @themsaid : looks like the same problem still happens on 5.5 (see #21190).
So far I've tested three ways to push a job, I'm not really aware if other ones might exist.

Can't replicate any of the cases in a fresh laravel installation.


Design v1 of the front-end app (web) to insert data.

Here is a link to the data input form
https://airtable.com/shr2hVFCnBW3lgSvX

@chinegro21 awesome!