Support the AWS Credentials plugin

The AWS Credentials plugin (https://wiki.jenkins.io/display/JENKINS/CloudBees+AWS+Credentials+Plugin) provides a specific AWS credential type that includes access key ID and secret access key so that we don't have to hack around "username" and "password" in standard password credentials.  The intent of that plugin is that all other AWS plugins should use it.
I currently have to duplicate my AWS users; I have a set that work with this plugin (pipeline-aws-plugin) and a set that work with everything else (using the AWS credentials plugin).
I'd like to add the AWS credentials plugin as a dependency of this one and support both the username/password method (for backward compatibility) as well as the AWS credentials (to be more in line with the AWS design).
Would that be okay with you guys?

Sounds great, but it should not break the current behavior of the withAWS step.
Especially the assume role should still work as designed.
So supporting it as AccessKey/SecretKey store is great but combining the other credentials features of the AWS cred plugin might be harder and break some stuff.

Using the AWS Credentials plugin breaks the withAWS credentials function:
java.lang.RuntimeException: Cannot find a Username with password credential with the ID
Right now, I've got to stuff withAWS into a withCredentials block if I want to store my aws credentials in jenkins.
withCredentials([[$class: 'AmazonWebServicesCredentialsBinding', credentialsId: '<whatever>', accessKeyVariable: 'AWS_ACCESS_KEY_ID', secretKeyVariable: 'AWS_SECRET_ACCESS_KEY']]) {     withAWS(role:'<whatever>', roleAccount:"${awsAccountId}",duration:'3600') {         <code stuffs>     } }

Created a PR for this

Hi ,
I have added my AWS credentials in Jenkins using AWS credentials plugin and tried to use in below Jenkins file.
pipeline {
agent any
stages {
stage('Deploy VPC') {
steps {
withAWS(credentials: 'aws-credentials', region: 'us-west-2'){
sh 'aws iam get-user'
}
		}
	}
}

}
getting below errors
java.lang.RuntimeException: Cannot find a Username with password credential with the ID aws-credentials
at de.taimos.pipeline.aws.WithAWSStep$Execution.withCredentials(WithAWSStep.java:360)
at de.taimos.pipeline.aws.WithAWSStep$Execution.start(WithAWSStep.java:290)
at org.jenkinsci.plugins.workflow.cps.DSL.invokeStep(DSL.java:286)
at org.jenkinsci.plugins.workflow.cps.DSL.invokeMethod(DSL.java:179)


I'd like to join this project's community

Your public repo
https://github.com/lilian79511/gov4git-identity-public.git
Your public branch
main

Approved

 Follow up
On Thursday, 29-Feb-24 13:17:44 UTC by Gov4Git dev
@lilian79511 was added to the community.


Detect usage of deprecated rules

It would be great to have a CLI to retrieve the list of deprecated rules activated (warn/error).
With that it would be easy to detect when some rules became deprecated while upgrading ESLint plugins versions.
The rule could be well deactivated if it is set to off for the same set or a superset of files compare to the set of files for which it is activated.
e.g.
[
  // Config coming from an external ESLint plugin
  {
    rules: {
      'my-deprecated-rule-1': 'warn',
      ...
    },
    files: ['**/*.{c,m,}{t,j}s']
  },
  // Local overrides
  {
     rules: {
       'my-deprecated-rule-1': 'off',
       ...
     },
    files: ['**/*']
  },
  {
     rules: {
       'my-deprecated-rule-2': 'off',
       ...
     },
    files: ['**/*.ts']
  }
]

In this case my-deprecated-rule-1 is well deactivated but my-deprecated-rule-2 is not because still activated for ['**/*.{c,m,}js', '**/*.{c,m}ts']
It also could be great to detect "useless overloaded" rules
e.g.
[
  // Config coming from an external ESLint plugin
  {
    rules: {
      'my-rule': ['error', { configItem: 1 }]
    }
  },
  // Local override
  {
    rules: {
      'my-rule': ['error', { configItem: 1 }]
    }
  }
]

In this case I want to be aware that my local override is useless as it's already configured like that (only if the glob of the override is equal or a subset of the one defined in configuration from the plugin)

Deprecated rules are shown straightaway in the UI:

If you mean it in a CLI environment only, that is something with a bigger scope (I'd rename this issue to "Provide a CLI interface" in that case), since the inspector right now is just GUI-based, there's no CLI functionality.
Perhaps, it could even be said that it's out of the scope of this project and might fall better into upstream (eslint)?

Yeah, I think the point of having a UI inspector is that we would have complex requirements/viewports towards the config data, which CLI couldn't easily represent. Redoing the features of the inspector in CLI is considered out-of-scope of this project.


face mesh problems

Have I written custom code (as opposed to using a stock example script provided in MediaPipe)
None
OS Platform and Distribution
linux
MediaPipe Tasks SDK version
0.10.14
Task name (e.g. Image classification, Gesture recognition etc.)
face mesh
Programming Language and version (e.g. C++, Python, Java)
python
Describe the actual behavior
for infer faster
Describe the expected behaviour
batch infer or multiprocessing
Standalone code/steps you may have used to try to get what you need
hi,i am using mp_facemesh.FaceMesh.process() for  infer.though it is very fast,about 0.005s for one infer,but i want it faster.i tried two ways:

1) i want to use mediapipe/modules/face_landmark/face_landmark.tflite for batch infer,but found the .tflite dont support batchsize >1. can you provide one tflite model to support dynamic batchsize

2）i want to use multiprocessing.pool to speed,but found ,
 when in every thread, init one new object of mediapipe.solutions.face_mesh ,and face_mesh.close() to release ,i found the speed decrease.

please help me to check it,thank you

Other info / Complete Logs
No response

Hi @xiaohaipeng,
It appears that you are currently using the legacy facemesh solution. We would like to inform you that the face mesh functionality is now part of the Face Landmarker Task API, as outlined in the documentation. This API serves as a superset of the facemesh solution and offers easier adoption across all platforms with ongoing maintenance.
However, support for the legacy face mesh solution has been completely discontinued for all upgraded solutions as well, as detailed in the same page. While the GitHub source codes and NPM packages for the legacy solution will remain available, But we will not be providing support for them.
We recommend exploring our new Face Landmarker and referring to the overview documentation available on the page. For implementation on Python, please follow the Python Setup guide provided here and Colab example you can find here
Also, We kindly request you to report any similar behavior if observed in the upgraded solution.
Thank you!!


protocol violation on tibia 7.6 with tileID_ladderToUp

in tibia 7.6 , when trying to use tileID_ladderToUp=9C 07 on position x: 1835 y: 2090 z: 13
BlackD Proxy cavebot will send:
82 2B 07 2A 08 0D 9C 07 02 00
Tibia client will send (clicking manually):
82 2B 07 2A 08 0D 9C 07 01 00
this should be fixed. should also investigate if the proxy is violating the protocol in the same way in RL tibia, because if it is, this is definitely something that Cipsoft could detect (and mark you as a cheater for deletion~)
i would also guess that the proxy is doing the same mistake in the closely related versions, 770, 772, 780, etc, but i haven't checked.
what does this byte mean anyway? stackpos maybe?

a quickfix:
in modCavebot -> Public Sub PerformUseItem
find:
  Next SS
  b1 = Matrix(ydif, xdif, z, idConnection).s(SOPT).t1
  b2 = Matrix(ydif, xdif, z, idConnection).s(SOPT).t2

after that, add
  If (TibiaVersionLong = 760) Then
  SS = SS - 1
  End If

and i still don't know if other version than 760,  or more importantly, RL tibia, is affected.

Cipsoft had zero cavebot checks in Tibia 7.6 so it was not a real problem by that time.
Anyways that is surely only a problem with the way that Blackd Proxy determines the top item in Tibia 7.6.
Tibia have changed his logic about that complex part a lot of times during his evolution. I am sure I am using the right logic in latest Tibia version. However I believe you are right and I was doing something wrong in Tibia 7.6. You should have a look on the S byte (stack position) of the function that builds that cheat packet. Then you should rewrite that function to build in a correct way to match Tibia 7.6 protocol. That special logic should only be used in Tibia 7.6 below protocol. Add condition tibiaversionlong =760
You should also test that it build correct packet in several scenarios: nothing in ladder, 1 item in ladder, 3 items in ladder, 11 items in ladder. The S byte will probably change depending that. Just get some gold coins and trash items and and build a trash of stack to do tests there.

After you do the tests I told you please confirm me if it works and I will add code to public version. However I am afraid we will require a more complex function.

dammit, yeah you're right. i tested the code a few other places, and it doesn't work. x.x
for instance
GAMECLIENT1>( hex ) 0A 00 82start B8 07x 8A 02y 08z 49b1 07b2 04ss 00
^ BlackD use...
GAMECLIENT1>( hex ) 0A 00 82start B8 07x 8A 02y 08z 9Cb1 07b2 02ss 00
^ client manual use

Permament items placed there with map editor are always on first stacks so in this case ground = 01, and ladder = 02 or something like that... ; d
Ofc I'm talking about tibia 7.6 ; p You just need to read from Matrix and Loop through stacks to find Ladder. I don't know if it has some kind of special property but you can always make a list of "ladder" items and Loop will search for it on the stack
I'll give you an example with ladder items stored in listbox
ladderID = 0
ydif = yPosOfLadder - myY(idConnection)
xdif = xPosOfLadder - myX(idConnection)
For sPos = 1 To 5 'damn I don't remember if stackPos starts at 0 or 1 :confused:
    tileID = GetTheLong(Matrix(ydif, xdif, myz(idConnection), idConnection).s(sPos).t1, Matrix(ydif, xdif, myz(idConnection), idConnection).s(sPos).t2)
    For i = 0 To List1.ListCount
        If tileID = List1.List(i)
			ladderID = tileID
			Exit For
		End If
	Next i
	If ladderID <> 0 Then
		Exit For
	End If
Next sPos

I'm not sure how ladder works though. Thats just an example
You can elimiate inside For is there's only 1 type of ladders

well, there's at least 1 id, "tileID_ladderToUp", but since there exist at least 4 types of ladder ids in  tibia 7.6, that's not enough (there's ladder facing south, north, east, and west)
im pretty sure it starts at 1 though, judging by this 7.6 otserv source code
int32_t Tile::getThingCount() const
{
    return (uint32_t) 1 + (splash ? 1 : 0) + topItems.size() +	creatures.size() + downItems.size();
}
Thing* Tile::getThingByStackPos(int32_t pos) // << pos here comes from the client, its the 2nd-to-last byte in the move package, the otserv devs are just retarded in using int32_t here, when they SHOULD have used uint8_t / char  (or uint8_fast_t if speed was their concern)
{
    if (pos == 0)
        return ground;

    pos--;

    if (splash)
    {
        if (pos == 0)
            return splash;
        //return NULL;
        pos--;
    }

    if ((unsigned) pos < topItems.size())
        return topItems[pos];

    pos -= (uint32_t)topItems.size();

    if ((unsigned) pos < creatures.size())
        return creatures[pos];

    pos -= (uint32_t)creatures.size();

    if ((unsigned) pos < downItems.size())
        return downItems[pos];

    return NULL;
}

I noticed that fact later Tibia versions and I handled it as a list in config.ini, but I didn't know it was already a list since 7.6. I guess the tile reader of 7.6 should be updated to handle a list of tiles too.


pinning virtualenv version

All fixed @tmeckel - nice catch here!

I specifically removed it - it was broken and was telling me there were no go files to lint - we can add that back in when we figure out why it was broken


HDDS-6732. Follower SCM crashed during snapshot installation.

https://issues.apache.org/jira/browse/HDDS-6732

/pending Will try to add more unit tests to verify whether SCM is safe during install snapshot

This bug seems to be still open and impacts 1.3 CC @ChenSammi @adoroszlai @errose28

The issue is not reproduced later with a new ratis verion.

Following two JIRAs solved the issue.
HDDS-5710. initialize sequenceIdToLastIdMap when SequenceIdGenerator#StateManager reinitializes (#2611)
HDDS-5281. Add reinitialize() for SequenceIdGenerator. (#2292)


More details about Replica

Hello! I am interested in running experiments on the Replica dataset. Could you please share how you preprocessed the Replica dataset and the specific split you used for testing?
Thank you very much for your help!

me too


Run tests in docker container

Run the tests for buildstep in a docker container to provide a consistent environment. (Fixes #134)
This PR adds new make targets that make updating the test image and running the tests easy.
make build-test  # builds the image containing the test environment
make run-test    # runs the testsuite using an existing test image
make test        # builds and runs the complete testsuite

The make targets expect the docker socket to be available at /var/run/docker.sock, the test image expects the socket to be available at /run/docker.sock.
The tests can be run manually using a variation of the command
docker run -v /var/run/docker.sock:/run/docker.sock -ti progrium/buildstep-test

This is great, thank you.


Incorrect minimum temperature range.

Minimum temperature at plugin is 16C but AC's work from 13.

Its expected to be able setup min temp. of 13C

{
"name": "GREE Air Conditioner",
"scanInterval": 60,
"devices": [
{
"mac": "",
"name": "Hangar 1A",
"speedSteps": 5,
"statusUpdateInterval": 10,
"sensorOffset": 40,
"minimumTargetTemperature": 16,
"maximumTargetTemperature": 30,
"xFanEnabled": false,
"temperatureSensor": "disabled",
"overrideDefaultVerticalSwing": 0,
"defaultVerticalSwing": 0,
"encryptionVersion": 0
},
{
"mac": "",
"name": "Hangar 1B",
"speedSteps": 5,
"statusUpdateInterval": 10,
"sensorOffset": 40,
"minimumTargetTemperature": 16,
"maximumTargetTemperature": 30,
"xFanEnabled": false,
"temperatureSensor": "disabled",
"overrideDefaultVerticalSwing": 0,
"defaultVerticalSwing": 0,
"encryptionVersion": 0
}
],
"_bridge": {
"username": "",
"port": 47870
},
"platform": "GREEAirConditioner"
}
Show your Homebridge config.json here, remove any sensitive information.

Screenshots:

Environment:

Plugin Version:
Homebridge Version:
Node.js Version:
NPM Version:
Operating System:

Hi @Przemekmac1
I need your help because I have never seen a GREE AC which works below 16 °C. Even the official GREE+ mobile app does not support temperatures outside of the 16-30 °C range.
I will be happy to extend this range but I need some information about your AC unit. Better said about the network communication of your AC unit. Please create some debug logs. Set your AC unit to the minimum temperature and wait until status updates appear in the log. Then set your unit to the maximum temperature and wait for the next status log entries. I need also the values of the minimum and maximum temperatures which I should search in the logs. It would help me if you create some additional tests with different temperatures outside of the 16-30 °C range and tell me which values are included in the logs. Finally please attach the logs to this issue.
Thank You!

Wifi firmware at the unit is 1.23,

Thank You!
Please turn on debug mode in homebridge and send me debug level logs about your units. The attached log contains only information level messages not debug ones. You can turn on debug mode on the settings page in homebridge UI.

homebridge-gree-ac.log.txt
here it is

Thank You!
If I understand well then 8 °C is the minimum and 30 °C is the maximum in heating mode on your device, Am I right?
What are the limits in cooling mode?

Yes - heat mode is 8C-30C, cooling mode is 16C - 30C.
We use it mainly for heating :)

Would you be so kind to set your AC unit to Fahrenheit display mode and collect some more debug logs?
I need primarily the lines containing "handleMessage - Package -> {...}" and "Device status -> {...}"
I need these lines and information of the target temperature (in Fahrenheit) which was set when the log entry was written.
I need information at least about 46°F, 47°F, 50°F, 59°F, 60°F, 61°F but it would be nice if I could get all values between 46°F and 62°F (Please mark every log entry to let me know the temperature which should be logged by the actual entry. Log entries do not contain Fahrenheit values so I can't decide the real value without additional information.)
Thank You!

Sure, attached.
homebridge-gree-ac.log.txt
Its Hangar 1B

Sorry,I was too fast. Here its new log. I changed heating target every minute (Hangar 1B).
21:49 46F
21:50 47F
21:51 50F
21:52 59F
21:53 60F
21:54 61F
I hope it logged correctly.
Uploading homebridge-gree-ac.log (1).txt…

homebridge-gree-ac.log (1).txt

I can see also that if I select temp below 16C homekit shows me always 25C.

Yes, it's normal in the current version. Network communication does not use exact temperature values. It uses codes. If the plugin receives an unknown code then it replaces the unknow code with the default 25°C value.
I am already working on a solution.

Super, if you need something let me know :)

It works great, thanks!


Allow immediate health check failure without active health check configured

Title: Allow immediate health check failure without active health check configured
Description:
Based on x-envoy-immediate-health-check-fail, it will exclude the host from load balancing only when the healthcheck is configured in the cluster. Currently we are exploring to remove envoy active healthcheck, but still want to keep /healthcheck/fail working, thus ensuring gracefully shutdown.
One idea is to update the router logic to set the host unhealthy regardless whether the healthcheck is configured in the cluster. In this way, when healthcheck is not configured in the cluster but having healthcheck filter in upstream, the normal http response with the header x-envoy-immediate-health-check-fail would be able to mark the host unhealthy once /healthcheck/fail gets invoked.
Would like to check whether the idea makes sense, before starting the implementation.

If the active health checking is not enabled, when will the host will resume to be healthy after we set it to unhealthy?

It seems there's no way to tell downstream that the host is ready to accept the traffic again

Then I think it's hard to convince users to accept this behavior.

Then I think it's hard to convince users to accept this behavior.

I guess the inconvenience could be related to the naming /healthcheck/fail VS /healthcheck/ok, as developers might expect /healthcheck/ok to work for this case as well. However, in practice /healthcheck/fail is mainly used to drain the host when it is being terminated. It is not that common to invoke /healthcheck/ok to un-drain the host afterwards.
Alternatively, we can add another admin command like /healthcheck/drain to differentiate from the existing cmd:  /healthcheck/drain excludes the host from the load balancing regardless of whether active healthcheck is configured in the downstream clusters, when healthcheck filter is configured in the listener.

If active healthcheck is configured in the cluster, /healthcheck/ok is able to negate the impact of /healthcheck/drain.
If active healthcheck is not configured in the cluster, we won't be able to negate the impact of /healthcheck/drain.

I don't see any good way of making this work well when there is implicit linking of configuration between upstream and downstream.
It sounds like perhaps passive health checking / outlier detection might be a better fit here? Perhaps the immediate health check fail could feed into passive health checking which might be good enough for your use case.
I do think it happens that people health check fail a host during debugging, and then hit the ok endpoint to have it take traffic again, so I agree with @wbpcode this would be confusing to many users.

Got it, I'll seek other options then.


unknown keyword: :thread_safe After Upgrading to Rails 6.1

Hello,
I've just upgraded my app to Rails 6.1 and in the process of going through and dealing with various deprecated methods I've run into one I can't resolve.
When I run bundle exec rspec I'm getting an ArgumentError: unknown keyword: :thread_safe
From some quick googling I found out that in Rails 6.1 they removed the after_intialize method as that was now deprecated.

Remove deprecated ActiveSupport::LoggerThreadSafeLevel#after_initialize

https://github.com/rails/rails/commit/e84af03914ff767a80fdb1a66a4dcb37f8bdb262
And since I'm getting this error on an intialize method in redis-client I figured that's where the problem lies.

Any thoughts on what I can look into to solve this, or if perhaps I'm misunderstanding something and am on the wrong track, would be much appreciated.

Only Resque 2.4.0 is compatible with redis-rb 5.x https://github.com/resque/resque/pull/1828


CACHE_MEMORY|CACHE_BOTH affected by PHP bug #71931 - incompatible with PHP7

Totally not the fault of phpforce, but using the soap option CACHE_MEMORY or CACHE_BOTH currently causes segfaults on the latest versions of PHP (e.g. 7.0.11)
The upstream bug is still open - it seems to require usage from a CLI context to be triggered, but is very repeatable.
I wonder if you'd consider leaving this configuration option up to the php.ini file's soap.wsdl_cache option rather than hard-coding it in the constructor. That would allow this library to be compatible with PHP7 immediately, rather than having to wait for the upstream bug to close (and, remember, it'll never be compatible with 7.0.0 - 7.0.11 as is...)

Closing because I see it's now just a default that can be overridden by the ClientBuilder - still good to note though, and might be worth changing that default to CACHE_DISK until the PHP maintainers get around to a fix.


Can't escape pipes in table

All pipes in a table are seen as column separators. When you want to put the pipe character as content in a cell, no way to escape it.

This can be avoided with |, however this doesn't allow you to put it in a code block.

Bump. I am trying to put code which contains pipes in a table, but the pipes are interpreted by the table instead of ignored in the code backticks.


No isfile command

Dear mapdl community,
I am running pymapdl for a stub column test in ANSYS 19.0. I want to introduce residual stresses.
I want to use the isfile command in ANSYS APDL. This command is undocumented in ANSYS 19.0 and it does not exist in Ansys help manual after 10.0 but you can still use it. Unfortunately I dont see this command either in mapdl. Is it supported? If not, what alternatives do I have?
Thanks

Hello,
I just ran the following and got a helpful error message in 2021R2:
>>> mapdl.run('isfile')

*** NOTE ***                            CP =       0.000   TIME= 00:00:00
The ISFILE/ISTRESS/ISWRITE commands are replaced by the INISTATE
 command for all current technology elements.  We suggest that users
 migrate to the newer commands, as the older commands
 (ISFILE/ISTRESS/ISWRITE) will likely be removed in a future release.

 *** ERROR ***                           CP =       0.000   TIME= 00:00:00
 The ISFILE OR ISTR command is not supported by Distributed ANSYS.  The
 initial stress command will be ignored.

I would recommend using inistate.

Thank you very much Kaszynski.


Review test running associated commands

We added specific commands to be able to run tests, but after double-checking the default keybindings I realized that this is already possible out of the box.
There are several commands to run or debug tests, like

testing.debugAll
testing.runAll
testing.debugAtCursor
testing.runCurrentFile
testing.runAtCursor
testing.reRunLastRun
testing.reRunFailTests

I don't think we needed the implementation from Shopify/vscode-ruby-lsp#696 and I don't believe we need the implementation from Shopify/vscode-ruby-lsp#708 and Shopify/vscode-ruby-lsp#717.
Let's confirm that this is the case and

Revert the changes in Shopify/vscode-ruby-lsp#696
Document what the default keybindings for interacting with the test explorer are somewhere. People can easily change their keybindings if they want to

I find the rubyLsp.runTestInTerminal useful because:

I can run all tests in the current file by triggering it on my top level describe/context block. This is much faster than running via test explorer, which seems to start a new process for each individual test.
I can make edits while the tests are running, e.g. if I see an error start to occur and I know what fix I want to implement before the run has finished
I find the output more useful - when I run via test explorer, I don't see errors in the Test Results panel unless I specifically click on a failed test in there (extra clicks). Or if I have the "peek view" enabled, but I find that very visually confusing because now my error output is inserted into the document I'm trying to edit. I don't know if there's a way to fix this, and I haven't investigate how it works on other language platforms, so maybe it can be improved.

I'd like to have something equivalent to rubyLsp.runTestInTerminal that:

Runs the entire test file (i.e. no :XX line number suffix) -- equivalent to testing.runCurrentFile
Re-runs the last test run (either entire file or specific line) -- equivalent to testing.reRunLastRun

Thanks for the suggestions, those are great ideas. It's not well described in the issue, but the idea was just to avoid the duplication for the test explorer commands, which already exist and yet we created duplicates for.
For run in terminal, indeed having those new commands would be great.


[WIP] net: Native CNI networking for KVM flavor

New way for setting up networking for KVM flavor. It's not finished yet, but it's close and finished at least for QEMU, so I'm sending this in case somebody would want to test it, gather opinions.
Notable changes:

hypervisor (QEMU for now) is running inside net namespace
veth and networking is prepared by vanilla CNI, no changes there needed
two new tools: net-tap-setup and net-tap-teardown handle connecting veths with taps
netlink update to version supporitng handling tap devices
enabling ("turning on") all networking tests for KVM flavor, the goal is to have it all pass

I've tested this with ptp/bridge and worked flawlessly.
I know that part with netlink could be dangerous, I saw all tests are passing for coreos flavor with this version, but I'm aware that there should be put extra care to it. Unfortunately this update is needed, because net-tap-* tools relay on it. In my other take I wanted to use busybox and standard linux tools to do it but:

"yet-another-external-bin-dependency"
awk/sed/grep are great tools, but writing shell script doing exactly the same thins as net-tap-* was nearly impossible (e.g. restore IP address in teardown)

net-tap-setup:

takes only one argument: tap (required by QEMU)
reads net-info.json
reads net description for  network from network array
creates bridge br, adds tap and veth with IP matching one from NetInfo
removes veth's IP address

net-tap-teardown:

takes only one argument: tap (required by QEMU)
reads net-info.json
reads net description for  network from network array
restores original veth address
removes bridge

TODO:

[x] patch to lkvm to support passing net-tap-setup and net-tap-teardown (like in QEMU)
[x] removal of dead code from networking package related to custom KVM codepaths
[ ] dividing this PR into two: one with netlink update and other one with code change
[ ] more testing

ccing myself @jjlakis

Hi there,
A quick question, as I dive in to this code: When CNI executes, the created interface (say, veth pair) is configured with the correct IP address. You then configure the interface in the VM with this same address. How do you deal with the duplicate address?

@squeed net-tap-setup removes veth's address and net-tap-teardown restores it.

Ahh, I see. I expected findIface to be non-side-effecting based on the name.

Almost finished PR. After review of lkvk code I've found codepaths allowing usage of "script=...,downscript=..." (simiar to QEMU) in network definition, but it was undocumented and thereof not used by us. After quick check it appears that it works! I've additionally cleaned up code a bit, but I think it deserves another pass before I remove 'WIP' label. Also after resolving a few conflicts during rebase I want to make extra sure I didn't break anything.

@lucab @squeed @sameo I hit a wall with maclan plugin and frankly, I don't know if it's possible to fully support it.
Example: IP subnet: <IP_ADDRESS>/24
Macvlan plugin sets IP <IP_ADDRESS> and gateway <IP_ADDRESS> (nowhere to be found on host). Also, "proxy_arp" is enabled on macvlan interface.
In case of nspawn  <-> nspawn communication there's no problem, because thanks to "proxy_arp" interface could "pretend" to be gateway and deliver frames to other pod. But in case of kvm <-> nspawn there's no address on macvlan interface in namespace, so even if proxy_arp is enabled it can't tell the VM "I'm gateway", because it doesn't have IP attached (? at least it's what I get from all of this). Or because route "<IP_ADDRESS>/24 dev eth0  src 10.3.0.X" have different effect in nspawn/kvm.
I've checked arp tables on all sides:
Arp table in nspawn:
? (<IP_ADDRESS>) at 92:36:f4:56:89:07 [ether]  on eth1
? (<IP_ADDRESS>) at <incomplete>  on eth0
? (<IP_ADDRESS>) at 02:65:02:e4:cb:cd [ether]  on eth0 # <- kvm

Arp table in kvm:
? (<IP_ADDRESS>) at <incomplete>  on eth0
? (<IP_ADDRESS>) at <incomplete>  on eth0 # <- nspawn
? (<IP_ADDRESS>) at 4a:6f:1a:be:09:3b [ether]  on eth1

Routes in nspawn:
default via <IP_ADDRESS> dev eth0
<IP_ADDRESS>/24 dev eth0  src <IP_ADDRESS>
<IP_ADDRESS>/24 via <IP_ADDRESS> dev eth1  src <IP_ADDRESS>
<IP_ADDRESS> dev eth1  src <IP_ADDRESS>

Routes in kvm:
default via <IP_ADDRESS> dev eth0
<IP_ADDRESS>/24 dev eth0  src <IP_ADDRESS>
<IP_ADDRESS>/24 via <IP_ADDRESS> dev eth1
<IP_ADDRESS> dev eth1  src <IP_ADDRESS>

nspawn host have no problem to get MAC address of intreface inside of a kvm pod, but in kvm in tcpdump I see constant stream of packets "where's <IP od nspawn pod>". Adding static entry to the arp table in kvm pod also didn't work.
I tried different combinations of proxy_arp, routes, setting up dummy IP address on bridged macvlan from the same subnet - all without success.
@squeed Do you have any idea how this could be resolved? Because only thing that came into my mind is to create macvtap device, but:
a) it'll be needed to delete macvlan interface at start and restore it at shutdown
b) I don't know exacly if macvan interface moved into separate network namespace would work
About b) I'm not quite sure, "it should", but I'm more concerned about a) - this solution's ugly and probably should be handled via separate CNI plugin instead of startup script. Any opinions?

@lucab @squeed @sameo I hit a wall with maclan plugin and frankly, I don't know if it's possible to fully support it.
Example: IP subnet: <IP_ADDRESS>/24
Macvlan plugin sets IP <IP_ADDRESS> and gateway <IP_ADDRESS> (nowhere to be found on host). Also, "proxy_arp" is enabled on macvlan interface.
In case of nspawn  <-> nspawn communication there's no problem, because thanks to "proxy_arp" interface could "pretend" to be gateway and deliver frames to other pod. But in case of kvm <-> nspawn there's no address on macvlan interface in namespace, so even if proxy_arp is enabled it can't tell the VM "I'm gateway", because it doesn't have IP attached (? at least it's what I get from all of this). Or because route "<IP_ADDRESS>/24 dev eth0  src 10.3.0.X" have different effect in nspawn/kvm.
I've checked arp tables on all sides:
Arp table in nspawn:
? (<IP_ADDRESS>) at 92:36:f4:56:89:07 [ether]  on eth1
? (<IP_ADDRESS>) at <incomplete>  on eth0
? (<IP_ADDRESS>) at 02:65:02:e4:cb:cd [ether]  on eth0 # <- kvm

Arp table in kvm:
? (<IP_ADDRESS>) at <incomplete>  on eth0
? (<IP_ADDRESS>) at <incomplete>  on eth0 # <- nspawn
? (<IP_ADDRESS>) at 4a:6f:1a:be:09:3b [ether]  on eth1

Routes in nspawn:
default via <IP_ADDRESS> dev eth0
<IP_ADDRESS>/24 dev eth0  src <IP_ADDRESS>
<IP_ADDRESS>/24 via <IP_ADDRESS> dev eth1  src <IP_ADDRESS>
<IP_ADDRESS> dev eth1  src <IP_ADDRESS>

Routes in kvm:
default via <IP_ADDRESS> dev eth0
<IP_ADDRESS>/24 dev eth0  src <IP_ADDRESS>
<IP_ADDRESS>/24 via <IP_ADDRESS> dev eth1
<IP_ADDRESS> dev eth1  src <IP_ADDRESS>

nspawn host have no problem to get MAC address of intreface inside of a kvm pod, but in kvm in tcpdump I see constant stream of packets "where's <IP od nspawn pod>". Adding static entry to the arp table in kvm pod also didn't work.
I tried different combinations of proxy_arp, routes, setting up dummy IP address on bridged macvlan from the same subnet - all without success.
@squeed Do you have any idea how this could be resolved? Because only thing that came into my mind is to create macvtap device, but:
a) it'll be needed to delete macvlan interface at start and restore it at shutdown
b) I don't know exacly if macvan interface moved into separate network namespace would work
About b) I'm not quite sure, "it should", but I'm more concerned about a) - this solution's ugly and probably should be handled via separate CNI plugin instead of startup script. Any opinions?

Adding @mcastelino

ping
This is quite crucial for rktlet + kvm, and rktlet is now allowing to run kvm flavor (with some limitation :)) https://github.com/kubernetes-incubator/rktlet/pull/87
cc @grahamwhaley


Unify some BSD flags

These BSD flags have common value in all OSes, so I've merged them into root mod.rs.

O_ACCMODE
O_RDONLY
O_WRONLY
O_RDWR
O_APPEND
O_CREAT
O_TRUNC
O_EXCL
O_SYNC
O_NONBLOCK
O_SHLOCK
O_EXLOCK
O_FSYNC
O_NDELAY

@bors: r+
Thanks!

:pushpin: Commit 1c39531 has been approved by alexcrichton

:hourglass: Testing commit 1c39531673cebae108cc628f2db1e24b4d6d2195 with merge b88c8f57b94ce150f21f6df65c4f64ea992a1559...

:sunny: Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing b88c8f57b94ce150f21f6df65c4f64ea992a1559 to master...


Stop Video Live

Browser: FILL WITH YOUR BROWSER (ex: Chrome Version 46.0.2490.80, Firefox Version 3.5.6, IE 11)
chrome 83.0.4103.116 (Official Build) (64-bit)
OS: FILL WITH YOUR OS (ex: Mac OS 10.11.1, iOS9, android4.5)
Windows and macOS
Clappr Version: 0.4.0
From Console Error:
[warn][hlsjs: non-fatal error occurred]
{evt: "hlsError", data: {…}}
data:
buffer: 0.07487199999999916
details: "bufferStalledError"
fatal: false
type: "mediaError"
proto: Object
evt: "hlsError"
proto: Object
[warn][hlsjs: non-fatal error occurred]
{evt: "hlsError", data: {…}}
data:
details: "bufferSeekOverHole"
fatal: false
frag: e {_url: "http://<IP_ADDRESS>:8008/sport/ch3/ch3_108014929.ts", _byteRange: null, _decryptdata: null, _elementaryStreams: {…}, deltaPTS: 0.03999999999999204, …}
reason: "fragment loaded with buffer holes, seeking from 71.929454 to 72.074"
type: "mediaError"
proto: Object
evt: "hlsError"
proto: Object

Hi @MohammaedAlani  can you share the media you used when this error occurred?

I'm sorry this not public, but on Vlc it work perfectly no error no stop.

Can you reproduce the problem with some other media that we can use for testing?

Closing due to the lack of the possibility of reproduction. If the reported behavior continues in one file that can be shared, reopen this issue.


kube-proxy userspace mode is deprecated

This is a Bug Report

Problem:
https://github.com/kubernetes/kubernetes/pull/104631 marks the userspace kube-proxy as deprecated. This was missed from the v1.23 docs updates and release announcement.
Proposed Solution:
Mark the kube-proxy in userspace mode as deprecated.
Page to Update:
https://kubernetes.io/docs/concepts/services-networking/service/

/sig network
/language en
/priority important-longterm

/lifecycle frozen
/triage accepted

/assign


implement strong types for chunked evaluations

In https://github.com/o1-labs/proof-systems/pull/680 we removed code related to chunked evaluations: when a polynomial is too big so we have to split it into "chunks" and evaluate these chunks separately.
We used to have that due to one polynomial (the quotient polynomial) but we actually do not evaluate it anymore (thanks to Maller's optimization)
We decided against going with #680 because we might want to actually support a different path going forward: a smaller URS which would mean that everything is chunked.
The goal of this PR is to clean these chunked evaluations that #680 tried to remove:

in proof.rs::ProofEvaluations and other similar types, F should become ChunkedEvaluations<F>.
the code related to these chunked evaluations (I think in prover.rs or verifier.rs should be moved to methods on this ChunkedEvaluations
there's already some Chunked types in the utils crate, so it probably is a good place to create that new type
as long as that new type has a nice API that could be used outside of kimchi by other people, it'll be a good thing!

protip: just look at #680 to find places that are impacted by this issue

some more information on what would be in such a type. I think it should closely look like ChunkedPolynomial (in that it also tracks the size of each chunk).
we should only be able to create it by evaluating a polynomial, ideally the evaluate_chunks function should return a ChunkedPolynomial.
I think introducing this type first would be a good idea. Then two things can be done (I can help provide more support there as well):
first: simplify the handling of chunks

second: replace all the vectors in ProofEvaluations and LookupEvaluations with this new type

I tried to update the Vec inside ProofEvaluations and LookupEvaluations, but not much successful.

it probably would be easier to start like this:

create a type called ChunkedEvaluations { chunks: Vec<F> } in utils/src/chunked_evaluations.rs
replace the Vec<F> in the structures you mentioned with that wrapper structure

if you have that I think that would be a good start

@mimoo
Thanks for the tips! :+1:

@mimoo
I started implementing the type ChunkedEvaluations.
Atm, I created a test PR on my github fork.
https://github.com/duguorong009/proof-systems/pull/1
Now, I stuck with serde issue.

Can you check the PR commit and the snapshot for more recommend?
Thanks in advance.

so some comments:

yeah you will need to use serde_as on your ChunkedEvaluations type to implement serde serialize/deserialize. You can see how this is done on all the types in this proof.rs file.
You should change this line to read pub evals: [ProofEvaluations<G::ScalarField>; 2] and have the ChunkedEvaluations type be a real type (not an instantiation of a type parameter)

so some comments:

yeah you will need to use serde_as on your ChunkedEvaluations type to implement serde serialize/deserialize. You can see how this is done on all the types in this proof.rs file.
You should change this line to read pub evals: [ProofEvaluations<G::ScalarField>; 2] and have the ChunkedEvaluations type be a real type (not an instantiation of a type parameter)

I am not sure if my thought is okay. @mimoo
I think your second recommend meaning is that I should keep the pub evals: [ProofEvaluations<G::ScalarField>;2] in the definition. And I should update the implementation so that it can use the ChunkedEvaluations in the place of G::ScalarField.
As far as I know, the G::ScalarField is for one evaluation value.
But, the ChunkedEvaluations is for representing the multiple evaluation values.
Then, how can I keep the G::ScalarField in the pub evals: ... definition?

eventually the other structures should be generic based on a type of Field, not a Vec<Field>. For example:
pub struct ProofEvaluations<F> {
    /// witness polynomials
    pub w: [ChunkedEvaluations<F>; COLUMNS],

    /// permutation polynomial
    pub z: ChunkedEvaluations<F>,

does that make sense?
I think some serde_as magic will be needed there as well:
#[serde(bound = "ChunkedEvaluations<F>: Serialize + DeserializeOwned")]
pub struct ProofEvaluations<F> {
    /// witness polynomials
    pub w: [ChunkedEvaluations<F>; COLUMNS],

    /// permutation polynomial
    pub z: ChunkedEvaluations<F>,

basically something that looks like this:
Thing2<F> {
  a: F,
}

Thing {
  thing2: Thing2<Vec<F>>

should change to something that looks like this:
Thing2<F> {
  a: Vec<F>,
}

Thing {
  thing2: Thing2<F>

(but using this chunkedevaluations type of course)

Thanks for the guidance! @mimoo
I updated the commit with the recommended changes.
Now, there are 2 issues left(just for my eyes).
zero proofevaluations
generic scalars calculus
@mimoo
Can you check the current PR update & let me know where to fix up?

had a pass at it and it looks good to me

had a pass at it and it looks good to me

Thanks for the review on the test PR! @mimoo  👍
I will create a real PR after resolve the issues I mentioned.

@mimoo
I have been trying to fix the ProofEvaluations::dummy_with_witness_evaluations(https://github.com/duguorong009/proof-systems/blob/guorong/impl-chunked-evaluations/kimchi/src/proof.rs#L236-L250) after introducing ChunkedEvaluations.
I think the dummy_with_witness_evaluations is simply filling the w field and other fields as ark_ff::Zero value.
Then, how can we apply the ChunkedEvaluations concept here?
(I tried to omit the impl, but looks like they are used in other utils like EndoSclMul and turshi.)

you could create a dummy function for the new type as well

btw @duguorong009 don't hesitate to let me know if you're stuck on something and need help : ) I think you had a good PR!

Thanks! @mimoo
Yes, will reach out for help.

@mimoo
Can you give me more detail about the following codes?

Dummy function for the ProofEvaluation.
Transpose function for the ProofEvaluations.
Thanks in advance.

dummy is most likely something like a default() function, and should be used in tests. (It'd be nice if these kind of things were gated behind a #[cfg(test)])
transpose is like a matrix transpose: IIRC I got rid of it in my own PR, I don't think it needs to exist : o

@mimoo
Can you let me know if we still need these evals?
These evals output the ProofEvaluation of SINGLE Field, which explains why the ProofEvaluation has this comment.
/// Polynomial evaluations contained in a `ProverProof`.
/// - **Chunked evaluations** `Field` is instantiated with vectors with a length that equals the length of the chunk
/// - **Non chunked evaluations** `Field` is instantiated with a field, so they are single-sized#[serde_as]

hey! Sorry this escaped me. I would say yes

Hmm, if so, it means that there is a case when the ProofEvaluations<F> could be struct of single Field elements.
Then, how about using the ChunkedEvaluations type wherever the ProofEvaluations<Vec<F>> is? @mimoo

I think this task is getting a bit harder with the recent changes, but we should keep it around as it's still something that would be great to have as a type even if we have to use it by instantiating a type parameter (instead of inlining it). Basically, the Vec<F> in some places should be ChunkedEvaluations<F>


fix: make isolate runtime local

Changes

#1517  👈 (View in Graphite)
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

@NathanFlurry might need some changes to the actor sdk, i tried fixing it myself


upgrade to flutter 3.0

WidgetsBinding.instance!.addPostFrameCallback 'WidgetsBinding' which excludes null

Agreed the solution is to remove the !

where? remove !

Latest release is with this fix. Please check.
card_swiper: ^2.0.4


[WIP] Wrangler cURL

This PR adds a number of features to wrangler preview

this ain't happening folks. see #845 for the new and exciting direction we're taking with this


Example missing

I could really use an example here... or maybe a pointer to a tutorial where this is being used.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ef284edc-3711-7491-2d2e-fdda96b31471
Version Independent ID: 703dd0e7-1c2a-daf0-994c-a66d5ee764c6
Content: LocalDeclarationStatementSyntax Class (Microsoft.CodeAnalysis.CSharp.Syntax)
Content Source: dotnet/xml/Microsoft.CodeAnalysis.CSharp.Syntax/LocalDeclarationStatementSyntax.xml
Product: dotnet-roslyn-api
Technology: microsoft.codeanalysis
GitHub Login: @dotnet-bot
Microsoft Alias: dotnetcontent

Thanks for your feedback @jonnybest. @BillWagner are we adding samples to the Roslyn API docs?


feat(tracing): Only propagate headers from spans within transactions

This change ensures that we only propagate trace headers from spans that are within a transaction. This fixes a bug where any child transactions of a span created outside a transaction are missing a dynamic sampling context and are part of a trace missing a root transaction (because the root is the span).
Fixes #3068

This breaks now a lot of tests because they assume sentry-trace to be there, when there is no transaction it seems...


Added base and drive search to collections

Split file-navigation into two parts, this would be quite useful I think! The rest can be added later if its still needed!

Looks good!


boards: Test tag ignores for Intel

Adds tags and ignore tags for a swathe of tests/samples that were building/running on Intel hardware unnecessarily. Also adds an optional step in the build to sign the image with rimage saving a great deal of time when running twister (30% improvement)

Split off the cmake rimage target generation as its quite useful and not really related to the tag fixups/ignore lists.
https://github.com/zephyrproject-rtos/zephyr/pull/52942

Needs rebase

Update 1:

Removes the ignore_tags changes to the intel platforms
Keeps all the tag changes
Renames PR and updates comment


Review

Please review, @JoanaArapi

Description of repository
The repository fulfills all requirments and ruff and run.py worked both times when the test was meant to fail and when it was meant to be passed.
Good job :)
Tests

[ x] License exists
[x ] Create a fork and start a pull-request
[x ] Pytests fails as expected
[x ] Ruff linter fails as expected

Homework completed @danielhuppmann


Update guide to vulkano 0.10.0 and improve it a bit

Updates the guide for 0.10.0 + a few small changes:

link every page to the next (I accidentally skipped a section while reading through...)
finish swapchain creation page (I hope)
show unfinished "window" pages and link to the triangle example where stuff is missing (less confusing than just ending on the window creation page I think)
link to the "fork me on github" button to vulkano instead of vulkano-www (#18)

~resolves #32~
resolves #18

Both the examples and the snippets from them need to be updated to 0.10.0 https://github.com/vulkano-rs/vulkano-www/tree/master/examples

Ok - I'm not sure when/if I'll get to that, so I removed the resolves #32 from the description for now.

This PR leaves vulkano-www in a state somewhere between vulkano 0.10 and 0.7 which isn't ideal but I'll just merge it and follow it up with another PR to complete the job.


Add bep-005 functionality, perf/asl support

See the integration of asl in the bids-specification, has been incorporated in the validator 1.6 and examples are stored as well here (called asl001..5).

@Remi are you able to easily merge the related PR? (In our Github workflow we keep conversations in the issue rather than in the PR, for easier keeping track). You might want to cherry-pick as I did some PR-merges from your main branch to my feature-branch.
There could be 1 conflict in the fmap PEPolar suffix, which with BEP005 now has the extra option m0scan. Note that this if-statement is based on the filename, so the filename field should be defined before defining the suffix.
Concerning the testing, would it be a good idea to have a JSON containing the BIDS structure that bids.layout should provide, for each test-case from bids-standard/bids-examples? (it seems as if each test is not explicitly coded).
See below a copy of the output from the 5 asl bids-examples:
BIDS = bids.layout('/Users/henk/ExploreASL/bids-examples/ASL_GE_PCASL_3Dspiral');

BIDS.subjects.perf

ans =
struct with fields:
                filename: 'sub-Sub103_asl.nii.gz'
                     ext: '.nii.gz'
                    type: 'time_series'
                     sub: 'Sub103'
                     ses: ''
                     acq: ''
                     dir: ''
                     rec: ''
                     run: '1'
   json_sidecar_filename: 'sub-Sub103_asl.json'
                    meta: [1×1 struct]
context_sidecar_filename: 'sub-Sub103_aslcontext.tsv'
                 context: [1×1 struct]
                      m0: 'within_timeseries'
         m0_volume_index: 1
 labeling_image_filename: 'sub-Sub103_labeling.jpg'

BIDS = bids.layout('/Users/henk/ExploreASL/bids-examples/ASL_Philips_PCASL_2DEPI');

BIDS.subjects.perf(1)

ans =
struct with fields:
                filename: 'sub-Sub103_asl.nii.gz'
                     ext: '.nii.gz'
                    type: 'time_series'
                     sub: 'Sub103'
                     ses: ''
                     acq: ''
                     dir: ''
                     rec: ''
                     run: '1'
   json_sidecar_filename: 'sub-Sub103_asl.json'
                    meta: [1×1 struct]
context_sidecar_filename: 'sub-Sub103_aslcontext.tsv'
                 context: [1×1 struct]
                      m0: 'separate_scan'
                  m0file: 'perf/sub-Sub103_m0scan.nii.gz'
 labeling_image_filename: 'sub-Sub103_labeling.jpg'

BIDS.subjects.perf(2)

ans =
struct with fields:
                filename: 'sub-Sub103_m0scan.nii.gz'
                     ext: '.nii.gz'
                    type: 'm0scan'
                     sub: 'Sub103'
                     ses: ''
                     acq: ''
                     dir: ''
                     rec: ''
                     run: '1'
   json_sidecar_filename: 'sub-Sub103_m0scan.json'
                    meta: [1×1 struct]
context_sidecar_filename: []
                 context: []
                      m0: []
                  m0file: []
 labeling_image_filename: []

BIDS = bids.layout('/Users/henk/ExploreASL/bids-examples/ASL_Siemens_PASL_multiTI');
Warning: Caution when using control as M0, background suppression was applied

In bids.layout>parse_perf (line 376)
In bids.layout>parse_subject (line 189)
In bids.layout (line 143)

BIDS.subjects.perf(1)

ans =
struct with fields:
                filename: 'sub-Sub1_asl.nii.gz'
                     ext: '.nii.gz'
                    type: 'time_series'
                     sub: 'Sub1'
                     ses: ''
                     acq: ''
                     dir: ''
                     rec: ''
                     run: '1'
   json_sidecar_filename: 'sub-Sub1_asl.json'
                    meta: [1×1 struct]
context_sidecar_filename: 'sub-Sub1_aslcontext.tsv'
                 context: [1×1 struct]
                      m0: 'use_control_as_m0'
 labeling_image_filename: 'sub-Sub1_labeling.jpg'

BIDS = bids.layout('/Users/henk/ExploreASL/bids-examples/ASL_Siemens_PCASL_multiPLD_pepolar');

BIDS.subjects.perf(1)

ans =
struct with fields:
                filename: 'sub-Sub1_asl.nii.gz'
                     ext: '.nii.gz'
                    type: 'time_series'
                     sub: 'Sub1'
                     ses: ''
                     acq: ''
                     dir: ''
                     rec: ''
                     run: '1'
   json_sidecar_filename: 'sub-Sub1_asl.json'
                    meta: [1×1 struct]
context_sidecar_filename: 'sub-Sub1_aslcontext.tsv'
                 context: [1×1 struct]
                      m0: 'separate_scan'
                  m0file: 'perf/sub-Sub1_m0scan.nii.gz'
 labeling_image_filename: 'sub-Sub1_labeling.jpg'

BIDS.subjects.perf(2)

ans =
struct with fields:
                filename: 'sub-Sub1_m0scan.nii.gz'
                     ext: '.nii.gz'
                    type: 'm0scan'
                     sub: 'Sub1'
                     ses: ''
                     acq: ''
                     dir: ''
                     rec: ''
                     run: '1'
   json_sidecar_filename: 'sub-Sub1_m0scan.json'
                    meta: [1×1 struct]
context_sidecar_filename: []
                 context: []
                      m0: []
                  m0file: []
 labeling_image_filename: []

BIDS = bids.layout('/Users/henk/ExploreASL/bids-examples/ASL_Siemens_PCASL_singleTI_3DGRASE');
Warning: Missing: perf/sub-Sub103_m0scan.nii

In bids.layout>parse_perf (line 389)
In bids.layout>parse_subject (line 189)
In bids.layout (line 143)

BIDS.subjects.perf(1)

ans =
struct with fields:
                filename: 'sub-Sub103_asl.nii.gz'
                     ext: '.nii.gz'
                    type: 'time_series'
                     sub: 'Sub103'
                     ses: ''
                     acq: ''
                     dir: ''
                     rec: ''
                     run: '1'
   json_sidecar_filename: 'sub-Sub103_asl.json'
                    meta: [1×1 struct]
context_sidecar_filename: 'sub-Sub103_aslcontext.tsv'
                 context: [1×1 struct]
                      m0: 'separate_scan'
 labeling_image_filename: 'sub-Sub103_labeling.jpg'

BIDS.subjects.perf(2)

ans =
struct with fields:
                filename: 'sub-Sub103_m0scan.nii.gz'
                     ext: '.nii.gz'
                    type: 'm0scan'
                     sub: 'Sub103'
                     ses: ''
                     acq: ''
                     dir: ''
                     rec: ''
                     run: '1'
   json_sidecar_filename: 'sub-Sub103_m0scan.json'
                    meta: [1×1 struct]
context_sidecar_filename: []
                 context: []
                      m0: []
 labeling_image_filename: []

Concerning the testing, would it be a good idea to have a JSON containing the BIDS structure that bids.layout should provide, for each test-case from bids-standard/bids-examples? (it seems as if each test is not explicitly coded).

I agree that the test code base needs improvement because it is becoming hard to read.
Yes having JSON to keep track the expected output of some test is an option: at the moment most of the testing of the behavior is done via test on what is returned by query as users are not supposed to around explore the BIDS structure itself but only interact with it via the query function.

hey @HenkMutsaerts
As part of the PR #124 to use the schema I am doing some refactoring and trying to make sure that the info of the layout can be accessed through the query function rather by having users look through the layout structure directly.
This also makes it easier to write tests because we just have to define the behavior of the query function rather than its implementation depending on the structure of layout.
Here is what this could give for ASL.

%% 'asl001'
BIDS = bids.layout(fullfile(pth_bids_example, 'asl001'));

All files but the .json are parsed (for all modalities not just ASL) so now context and labelling image are in the layout, so to access info about a file one would need to know its "index".
For example.
BIDS.subjects(1).perf(1)

ans =

  struct with fields:

        filename: 'sub-Sub103_asl.nii.gz'
             ext: '.nii.gz'
             suffix: 'asl'
             sub: 'Sub103'
             ses: ''
             acq: ''
             rec: ''
             dir: ''
             run: ''
            meta: [1×1 struct]
            dependencies: [1×1 struct]

This can be quite annoying so it is easier to access its info with the query function.
Also, note that am trying to avoid storing the name of the json sidecars in the layout because the metadata for a given file can be spread across several json spread through the different levels of the BIDS folder hierarchy (inheritance principle).
 meta = bids.query(BIDS, 'metadata', 'sub', 'Sub103', 'suffix', 'asl')

meta =

  struct with fields:

                         Manufacturer: 'GE'
               ManufacturersModelName: 'DISCOVERY_MR750'
                     SoftwareVersions: '24_LX_MR_Software_release:DV24.0_R02_1607.b'
                MagneticFieldStrength: 3
                      ReceiveCoilName: '32Ch_Head'
                    MRAcquisitionType: '3D'
                    PulseSequenceType: 'spiral'
                 PulseSequenceDetails: 'GE 3d spiral pcasl product sequence: 24_LX_MR_Software_release'
                     ScanningSequence: 'RM'
                      SequenceVariant: 'NONE'
                          ScanOptions: 'EDR_GEMS_SPIRAL_GEMS'
                             EchoTime: 0.0105
                            FlipAngle: 111
            RepetitionTimePreparation: 4.8860
             ArterialSpinLabelingType: 'PCASL'
                    PostLabelingDelay: 2.0250
                BackgroundSuppression: 1
                               M0Type: 'Included'
                     VascularCrushing: 0
                 AcquisitionVoxelSize: [3×1 double]
    BackgroundSuppressionNumberPulses: 4
       BackgroundSuppressionPulseTime: [4×1 double]
          LabelingLocationDescription: '~8 cm below the circle of Willis, through the proximal V3 segment of the vertebral arteries'
                     LabelingDistance: 40
                     LabelingDuration: 1.4500

Associated files would be in the dependencies field whose content would depend for the modality.
Here for ASL.
PS: I want to improve the query for dependencies because this is not ideal yet.
dependencies = bids.query(BIDS, 'dependencies', 'sub', 'Sub103', 'suffix', 'asl');

dependencies{1}.labeling_image

ans =

  struct with fields:

    filename: 'sub-Sub103_asllabeling.jpg'

dependencies{1}.context

ans =

  struct with fields:

    content: [1×1 struct]
       meta: []

dependencies{1}.m0

ans =

  struct with fields:

            type: 'within_timeseries'
     explanation: 'M0 is one or more image(s) in the *asl.nii[.gz] timeseries'
    volume_index: 1

Why not simply parsing nii (or other data format) only, and not parsing the sidebars? Perhaps in some non imaging cases a tsv can be the data itself, but this is probably not a very frequent case.

Yes in general, the idea would be to leave the json alone as much as possible and only look them up when querying for some metadata.
There are a potential few exceptions: when the json is not a sidecar (ex: dataset_desciption, and a few other instances).
Also some metadata might have to be loaded when parsing especially regarding the "dependency" issue (see below).
I am also very tempted to only load the content of the tsv upon query (when needed and asked by the user): if you have large functional datasets with one tsv per run per subject, the loading could get a tad long and the structure a bit heavy.
I know that pybids had to turn to "SQL" to handle those.

I see now that you have "dependencies" for the additional sidecars. I guess it boils down to where we want to use bids-matlab for. To me, the bids validator should do the validating, so we don't have to keep the file structure intact and could use a structure that is more useful (like having all metadata under a single struct for a single nii). At least for pipelines this seems more useful to me...

Yeah the proper validation should be left to the validator, the only "validation" we do is when using the bids-schema when parsing (though user can easily ask for a schema-less parsing).
And the idea to "centralize" all metadata for each file in the same structure was also recently suggested  by @nbeliy and indeed it makes a lot of sense. Especially for files with an associated fmap, it was suggested that the fmap should be listed as a dependency  for that file.
So currently we have:

fmap A is intended for nifti B: fmap_A.intended_for = nifit_B
and from a pipeline perspective it would make more sense to have: nifti image B processing can include fmap A:  nifit_B.dependency.fmap = fmap_A

The creation of a field dependency in the layout structure is mostly to facilitate fetching those dependencies by query given that different modalities might have very different types of dependency type, so centralizing those under the same field would definitely help.


Add Teseve.app v0.4.0

Adding Teseve.app from http://teseve.github.io.
I've followed all the guides, hope all is okay. Feel free to request any modification if needed.

Thank you for the contribution. It needed some fixes, so they were made in 293a4f82bcbe1a35650335f55ce835c3b05cc580. Your contribution is still included (and still credited to you), with the appropriate modifications. Please feel free to ask about any of the changes.

Hi, thanks. I'm curious about the changes you made (specially to don't do errors next time). Can you explain the errors returned by Travis & how to fix them?
Thanks in advance,

All I did were additions and small tweaks (i.e. your contribution was fine and would’ve worked as was).
Travis errors was just Travis acting up (restarting it would likely make it pass).

I’ll anotate your cask in this PR, so you get a better idea of what was changed.

Ok, thanks for all the infos. :+1:
Have a great week-end!

Thank you. You too.


Repetitive information

Repetitive information from line 84-136, should be removed.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: Abhilash3107 sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Repetitive information from line 84-136, should be removed.

Repetitive information from line 84-136, should be removed.


Integrate Globalize as one or more custom methods for number and date validation

See https://github.com/jquery/globalize/
Passing a value to the appropriate should return a good value to be considered value, while null or NaN would be considered invalid.

I'm sorry for the lack of activity on this issue. Instead of leaving it open any longer, I decided to close old issues without trying to address them, to longer give the false impression that it will get addressed eventually.
To the reporter (or anyone else interested in this issue): If you're affected by the same issue, consider opening a new issue, with a testpage that shows the issue. Even better, try to fix the issue yourself, and improve the project by sending a pull request. This may seem daunting at first, but you'll likely learn some useful skills that you can apply elsewhere as well. And you can help keep this project alive. We've documented how to do these things, too. A patch is worth a thousand issues!

Note to self: Work with @johnnyreilly to update his project to Globalize 1.x, document that as an alternative to (bad) bundled methods.


Add custom transforms 'upstream' of emitter annotation in equiv tests

Type of change: bug fix
API impact: none
Backend code-generation impact: none
The LEC environment puts the custom transform annotations later in the annotation sequence than the emitter it selects. Since the transform manager tries to honor this, it ends up running the emitter before the custom transforms if it can.

This results in the tests from #1874 and #1875 failing as expected without the appropriate fixes.


Dublicating functions in GET /func

If we PUT /func few times for the same function, then GET /func will return dublicate records for it,
instead of single one.

done in 0.2.0


Snippets are missing in shopware <IP_ADDRESS> and above

We have a <IP_ADDRESS> Shop with the version 2.4.1 of the Payone plugin. All payone snippets are missing in the database. I think the problem is that the way you install the snippets is not working anymore since shopware <IP_ADDRESS>. You have a folder "Resources/translations" and you install the snippets with PHP files that are tagged with "shopware.snippet.file". But this tag is not handled anymore since <IP_ADDRESS>. You should use the auto detection like it is described here:
https://developer.shopware.com/docs/guides/plugins/plugins/storefront/add-translations#snippet-file-structure
So I think you just need to rename the "Resources/translations" directory to "Resources/snippet". That should be enough and then you can delete the PHP services.

Hello @momocode-de,
I created a ticket. Our agency will check that.

Hello @momocode-de ,
we already solved that and released it in our new version 3.0.0


This was the major blocker for me adopting txacme: some services need to be told to reload keys/certs from disk.

This change is

I should say this was mostly a proof of concept; I don't expect this to get merged as-is because it has no docs. But, how's it look?

Oops yeah I just remembered this is also the bit with the super crappy attempt at getting hypothesis and testtools to work together. That should definitely be split off into a PR for hypothesis.

[Current coverage][cc-pull] is 99.75%

Merging [#27][cc-pull] into [master][cc-base-branch] will increase coverage by -0.24%

@@            master        #27   diff @@
=========================================
  Files           20         20
  Lines         1535       1579    +44
  Methods          0          0
  Messages         0          0
  Branches       139        128    -11
=========================================
+ Hits          1535       1575    +40
- Misses           0          2     +2
- Partials         0          2     +2

5 files (not in diff) in src/txacme/test were modified. more

Misses +1
Partials +1
Hits -2

2 files (not in diff) in src/txacme were modified. more

[][cc-pull]

Powered by Codecov. Last updated by e73bd8e
[cc-base-branch]: https://codecov.io/gh/mithrandi/txacme/branch/master?src=pr
[cc-pull]: https://codecov.io/gh/mithrandi/txacme/pull/27?src=pr

This seems like a generally useful feature. Adding it to the endpoint as a kwarg is a bit tricky, since any kwargs we use for ourselves will mask kwargs in the endpoint we're wrapping... maybe @glyph has some thought about the Right Thing To Do here since I haven't thought about it too much myself yet.
We should add it to the docs, of course, and I see the tests are failing on Python 3 because of str/bytes issues (to nobody's surprise), but those should be easy things to fix.

A thought: Make the "on stored callback" (maybe this could be implemented with the same mechanism that Request.notifyFinish uses, for multiple "observers" if necessary) a plain Python function, this would be a more generic interface with all the benefits that come with being able to invoke functions in the same process.
For the "run arbitrary scripts" idea you could always provide a Python function (it may even be in txacme itself) that implements this behaviour on top of the "on stored callback" function.

We already have a directory with certain enforced naming conventions.  Perhaps just put a script in there, on-store, which is executed as a hook, no need for an additional command line argument?

I was hoping to avoid checking argv[1] in the script in general, but a single on-store script does probably make the most sense, given the naming convention point.

No, I mean, put it in the certificates directory.

Right. Have a single {cert-dir}/on-store script instead of {cert-dir}/{hostname}.onstore.

Okay, so the hook script behaviour will be hardcoded for the endpoint parser, and "always on". I think @jonathanj is right that the underlying interface should just be DirectoryStore taking a callable (let's say a 1-arg callable that takes the servername?), so If you need different hooks for some hosts, you can either just use different directories, or you can write some Python code.

Sounds like a good strategy to me.

[Current coverage][cc-pull] is 99.75%

Merging [#27][cc-pull] into [master][cc-base-branch] will increase coverage by -0.24%

@@            master        #27   diff @@
=========================================
  Files           20         20
  Lines         1535       1579    +44
  Methods          0          0
  Messages         0          0
  Branches       139        128    -11
=========================================
+ Hits          1535       1575    +40
- Misses           0          2     +2
- Partials         0          2     +2

5 files (not in diff) in src/txacme/test were modified. more

Misses +1
Partials +1
Hits -2

2 files (not in diff) in src/txacme were modified. more

[][cc-pull]

Powered by Codecov. Last updated by e73bd8e
[cc-base-branch]: https://codecov.io/gh/mithrandi/txacme/branch/master?src=pr
[cc-pull]: https://codecov.io/gh/mithrandi/txacme/pull/27?src=pr

[Current coverage][cc-pull] is 99.75%

Merging [#27][cc-pull] into [master][cc-base-branch] will increase coverage by -0.24%

@@            master        #27   diff @@
=========================================
  Files           20         20
  Lines         1535       1579    +44
  Methods          0          0
  Messages         0          0
  Branches       139        128    -11
=========================================
+ Hits          1535       1575    +40
- Misses           0          2     +2
- Partials         0          2     +2

5 files (not in diff) in src/txacme/test were modified. more

Misses +1
Partials +1
Hits -2

2 files (not in diff) in src/txacme were modified. more

[][cc-pull]

Powered by Codecov. Last updated by e73bd8e
[cc-base-branch]: https://codecov.io/gh/mithrandi/txacme/branch/master?src=pr
[cc-pull]: https://codecov.io/gh/mithrandi/txacme/pull/27?src=pr

[Current coverage][cc-pull] is 99.75%

Merging [#27][cc-pull] into [master][cc-base-branch] will increase coverage by -0.24%

@@            master        #27   diff @@
=========================================
  Files           20         20
  Lines         1535       1579    +44
  Methods          0          0
  Messages         0          0
  Branches       139        128    -11
=========================================
+ Hits          1535       1575    +40
- Misses           0          2     +2
- Partials         0          2     +2

5 files (not in diff) in src/txacme/test were modified. more

Misses +1
Partials +1
Hits -2

2 files (not in diff) in src/txacme were modified. more

[][cc-pull]

Powered by Codecov. Last updated by e73bd8e
[cc-base-branch]: https://codecov.io/gh/mithrandi/txacme/branch/master?src=pr
[cc-pull]: https://codecov.io/gh/mithrandi/txacme/pull/27?src=pr

I'm +1 on @jonathanj's suggestion that there should be a callback for certificate changes. For now I've implemented a wrapper for ICertificateStore that triggers a reload of certificates in an external system when .store() is called. Which I think should work fine, but it's not explicit anywhere that .store() is only called when a certificate is issued/renewed, although this is probably a reasonable assumption to make if I expect you to have written this software well (this is maybe #35?).
Another problem with having .store() as the point where things are notified of certificate changes is that it means it's tricky to add new domains/certificates to the store, as this is usually done by storing an empty certificate in the store and the empty certificate is likely to break whatever external thing using the certificates (#76).

+1 for callback on certificate updates for the default CertificateStore implementation.
I have implemented by own ICertificateStore which will call/forward the server_name, pem_objects each time something is stored in it.
For the file based CertificateStore I am expecting the callback to also include the full path to the updated file.


chore: add TypeScript and migrate theme components to TypeScript

This PR adds the TypeScript-related dependencies, as well as migrates the theme components to TypeScript. Nothing big so far (I think), the next PR would have the bigger impact.
Signed-off-by: Try Ajitiono<EMAIL_ADDRESS>

Merging this so that it won't be conflict-messy with the dependencies. Let me know if you have any objections about this PR @dio. Thanks!


practise

add  to main repo

Is there a school or tutorial out there that's using T2D repository as an example for testing git pull requests or something? Cause this happens way too often to this repository.

Please do not make test pull requests.  This is a live public repository.


[BACKLOG-38429][Add] Credit Card Validator Plugin

Add Credit Card Validator Plugin

:white_check_mark: Build finished in 59m 9s
Build command:
mvn clean verify -B -e -Daudit -amd -pl \
assemblies/plugins,engine,plugins,plugins/credit-card-validator,plugins/credit-card-validator/assemblies,plugins/credit-card-validator/assemblies/plugin,plugins/credit-card-validator/impl,plugins/credit-card-validator/ui,ui

:ok_hand: All tests passed!
Tests run: 5324, Failures: 0, Skipped: 14    Test Results

:information_source:  This is an automatic message


Current highlighted line confusing to read around codeblocks

First of all, thanks for a great theme.
The current highlighted line is hard to read, kind of like, my cursor gets lost when working with code-blocks.

Yeah, this annoyed me as well. After lots of trials I settled on changing the cursor line to a faded red. Looks good and hopefully doesn't annoy people. :-)


SetBackgroundState does not override default

The SetBackgroundState does not override default
E.g. the following razor
@(Html.Bootstrap().InputButton("Log In", buttonType: ButtonType.Submit)                                 .SetBackgroundState(BackgroundState.Primary))
gives
<input type="submit" value="Log In" class="btn btn-default bg-primary">
so it looks like default background is applied

For the time being I've solved a problem by following workaround:
@(Html.Bootstrap().InputButton("Log In", buttonType: ButtonType.Submit) .SetBackgroundState(BackgroundState.Primary) .RemoveCss("btn-default"))

Glad you've got a workaround (for this issue at least). I've seen this and your other issues - it's a holiday weekend here and I'm trying to stay off of the computer :smile: I'll take a look at everything early next week.

The problem here is that button state and background state actually mean two different things and FluentBootstrap doesn't treat them as mutually exclusive. What you probably want to do is:
@(Html.Bootstrap().InputButton("Log In", buttonType: ButtonType.Submit).SetState(ButtonState.Primary))

Feel free to please reopen the issue if I've misunderstood.


improve Mesos task name and set a Mesos executor name; makes it clear…

… in Mesos UI that the tasks are from the storm framework, and also adds the topology-ID into the task name for better searching & sorting within Mesos UI

I'm planning to change "storm ..." to or "storm-worker ..." in the task name.  And the executor will be changed from "storm ..." to "storm-supervisor ...".
However, I'm wondering if it would be better to do some variation on one of these options for the naming:
storm-worker-TOPOLOGYID-NODEID:31008
storm-worker_TOPOLOGYID_NODEID:31008
storm-worker__TOPOLOGYID__NODEID:31008
storm-worker::TOPOLOGYID::NODEID:31008
storm-worker TOPOLOGYID NODEID:31008

NOTE:

TOPOLOGYID can have dashes or underscores in it:
NODEID seems to be the hostname, and that cannot have underscores in it, but will very often have dashes.

I'd love to see some example task name styles that similar frameworks have chosen, if anyone has pointers to some.

@JessicaLHartog: sounds like you like storm-worker::TOPOLOGYID::NODEID:31008.   @dsKarthick, do you agree?  Anyone else have an opinion?

@erikdw Doesn't look the latest changes. Was expecting storm-worker | TOPOLOGYID | NODEID:31008 format

@dsKarthick : you're right, thanks for reminding me.

I've tested the latest commit (a3d9c04) in my vagrant setup.  Here's what the tasks look like if you change topology.mesos.component.name.delimiter to ^^:
delimiter: "^^"

As opposed to the default delimiter: " | "

@dsKarthick: please :eyes:

:shipit:


fix: do not show not allowed before register

Do not show not allowed when opening the page

Looks good.
Clarifying question, we want to allow people to register when we are in the voting stage?

register before also and join maci during voting I believe!

register before also and join maci during voting I believe!

Sweet, that was my understanding too


A few hot restarts for in a row cause a canvaskit failure

Repro:

open examples/hello_world in VSCode, chose web platform
set a breakpoint on line that calls runApp
debug
when the breakpoint is hit, click hot restart a few times in a row

The app shows "hello world" but continues to throw the assertion after that.
VSCode debug console output
Error: Assertion failed: org-dartlang-sdk:///flutter_web_sdk/lib/_engine/engine/canvaskit/surface_factory.dart:157:12
_cache.contains(surface)
is not true
    at Object.throw_ [as throw] (http://localhost:56119/dart_sdk.js:5081:11)
    at Object.assertFailed (http://localhost:56119/dart_sdk.js:5006:15)
    at _engine.SurfaceFactory.new.isLive (http://localhost:56119/dart_sdk.js:148814:51)
    at _engine.Surface.new.[_contextLostListener] (http://localhost:56119/dart_sdk.js:148511:19)
Restarted application in 80ms.

Chrome console output

Chrome console output
This app is linked to the debug service: ws://<IP_ADDRESS>:56210/YikfKpifYBY%3D/ws
canvaskit.js:180 WARNING: Too many active WebGL contexts.   Android toolchain - develop for Android devices (Android SDK version 29.0.3)
• Android SDK at /Users/annagrin/Library/Android/sdk
✗ cmdline-tools component is missing
Run path/to/sdkmanager --install "cmdline-tools;latest"
See https://developer.android.com/studio/command-line for more details.
✗ Android license status unknown.
Run flutter doctor --android-licenses to accept the SDK licenses.
See https://flutter.dev/docs/get-started/install/macos#android-setup for more
details.
[✓] Xcode - develop for iOS and macOS (Xcode 12.5.1)
• Xcode at /Applications/Xcode.app/Contents/Developer
• CocoaPods version 1.10.1
[✓] Chrome - develop for the web
• Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome
[✓] Android Studio (version 3.6)
• Android Studio at /Applications/Android Studio.app/Contents
• Flutter plugin version 45.1.1
• Dart plugin version 192.7761
• Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b4-5784211)
[✓] IntelliJ IDEA Community Edition (version 2021.1)
• IntelliJ at /Applications/IntelliJ IDEA CE.app
• Flutter plugin version 55.1.5
• Dart plugin version 211.6693.108
[✓] VS Code (version 1.60.1)
• VS Code at /Applications/Visual Studio Code.app/Contents
• Flutter extension version 3.26.0
[✓] Connected device (2 available)
• macOS (desktop) • macos  • darwin-x64     • macOS 11.6 20G165 darwin-x64
• Chrome (web)    • chrome • web-javascript • Google Chrome 93.0.4577.82
! Doctor found issues in 1 category.

Another bug that looks the same: https://github.com/flutter/flutter/issues/90231

HI @annagrin
Thanks for filing the issue, I can reproduce the issue on the latest master, however current stable, multiple hot restarts lead to a frozen hot restart state (hot restart get stuck).
Error: Assertion failed: org-dartlang-sdk:///flutter_web_sdk/lib/_engine/engine/canvaskit/surface_factory.dart:157:12
_cache.contains(surface)
is not true
    at Object.throw_ [as throw] (http://localhost:40681/dart_sdk.js:5081:11)
    at Object.assertFailed (http://localhost:40681/dart_sdk.js:5006:15)
    at _engine.SurfaceFactory.new.isLive (http://localhost:40681/dart_sdk.js:148814:51)
    at _engine.Surface.new.[_contextLostListener] (http://localhost:40681/dart_sdk.js:148511:19)
Restarted application in 166ms.
A fallback font was registered but we cannot retrieve the typeface for it.
A fallback font was registered but we cannot retrieve the typeface for it.

flutter doctor -v
[✓] Flutter (Channel master, 2.6.0-6.0.pre.128, on Zorin OS 16
    5.11.0-34-generic, locale en_US.UTF-8)
    • Flutter version 2.6.0-6.0.pre.128 at /home/taha/Code/flutter_master
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision fa9790ca47 (5 hours ago), 2021-09-17 01:37:03 -0400
    • Engine revision e70febab63
    • Dart version 2.15.0 (build 2.15.0-118.0.dev)

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /home/taha/Code/android-sdk
    • Platform android-31, build-tools 31.0.0
    • ANDROID_SDK_ROOT = /home/taha/Code/android-sdk
    • Java binary at: /home/taha/Code/android-studio/jre/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7249189)
    • All Android licenses accepted.

[✓] Chrome - develop for the web
    • Chrome at google-chrome

[✓] Linux toolchain - develop for Linux desktop
    • clang version 10.0.0-4ubuntu1
    • cmake version 3.16.3
    • ninja version 1.10.0
    • pkg-config version 0.29.1

[✓] Android Studio (version 2020.3)
    • Android Studio at /home/taha/Code/android-studio
    • Flutter plugin version 60.1.2
    • Dart plugin version 203.8292
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7249189)

[✓] VS Code
    • VS Code at /snap/code/current
    • Flutter extension version 3.26.0

[✓] Connected device (2 available)
    • Linux (desktop) • linux  • linux-x64      • Zorin OS 16 5.11.0-34-generic
    • Chrome (web)    • chrome • web-javascript • Google Chrome 93.0.4577.82

• No issues found!

@TahaTesser

Thanks for filing the issue, I can reproduce the issue on the latest master, however current stable, multiple hot restarts lead to a frozen hot restart state (hot restart get stuck).

I believe someone mentioned that in a comment of https://github.com/flutter/flutter/issues/89874, but I haven't seen an issue reported for that yet. It is fixed in 2.6.0-xxx though, so I'll wait to see if it is blocking anyone.

I am experiencing the same issue even on 2.6.0-5.2.pre.
The initial issue stated that this happens in the debug, but I'm experiencing this even in non-debug run. Also, it starts popping after a few hot restarts.

flutter doctor -v
[✓] Flutter (Channel beta, 2.6.0-5.2.pre, on macOS 11.5.2 20G95 darwin-x64, locale en-GB)
    • Flutter version 2.6.0-5.2.pre at /Users/kristian/Documents/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 400608f101 (5 days ago), 2021-09-15 15:50:26 -0700
    • Engine revision 1d521d89d8
    • Dart version 2.15.0 (build 2.15.0-82.2.beta)

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/kristian/Library/Android/sdk
    • Platform android-31, build-tools 31.0.0
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7281165)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 12.5.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2020.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7281165)

[✓] VS Code (version 1.60.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension can be installed from:
      🔨 https://marketplace.visualstudio.com/items?itemName=Dart-Code.flutter

[✓] Connected device (1 available)
    • Chrome (web) • chrome • web-javascript • Google Chrome 93.0.4577.82

• No issues found!

@yjbanov does your fix work for both debug and release web builds?

@annagrin AFAIK our release builds do not support hot restart. We just reload the whole page when you use the hot restart shortcut.


Highlighting multiple separate code lines

Could you add support for highlighting multiple separate lines (no line range). (The code-fragment marker syntax seems not to support that yet. E.g. @[5,9] could be suitable...)

I tried to find this in the code base... Can anyone point me in the right direction? (For first PR)
Idk, maybe I'm just rusty on my Java...

I'm travelling for the rest of the month so I won't have time to look at this until early August. Highlighting for the code presenting feature is implemented in JS within the following file:
libs/highlight.js/9.6.0/reveal-code-focus-1.0.0-mod.js

If you have a PR for me please go ahead and submit it and I'll review it when time permits. If not, I'll try and look at what's involved to support this feature when I'm home.

I've just pushed a patch that adds support for multiple-slices of code to be represented within a single code-fragment marker. This will allow you highlight multiple non-contiguous blocks of code using a single marker. For example, the following marker @[7, 11-14] renders as follows:

By way of further example, each of the following are now valid code-fragment markers:
@[1]
@[3-6]
@[2, 4-8]
@[3,4,6]
@[3-5, 7]

As you can see the new code-fragment marker syntax is very flexible and should cover most if not all imaginable use cases. The Code Presenting page on the GitPitch Wiki has been updated to document this new feature.
This patch is live on gitpitch.com. If you try it out please let me know how you get on so we can update or close this issue. Thanks.

@gitpitch Great. Thanks a lot.


Update S3.php, added custom endpoint

Hello,
I am would like use s3browser with s3-compatible services, so I updated S3.php (with custom endpoint support) and modify s3browser to provide endpoint in settings.
@tradzik, looks that!
Greetings,

Thanks! :cake:


Stuck on closing/opening in lumi.curtain.hmcn02 (Xiaomi BLE Curtain Driver E1)

Describe the bug
Curtains is almost always stucking in status "closing..." or "opening" state. Sometimes it will be update after tapping several times and passing the loops close/open.
Expected behavior
Correctly status updates.
Your config.json
{             "name": "Entrance Left Curtain",             "ip": "<IP_ADDRESS>",             "token": "48715737553778326f566b6f42524d6c",             "deviceId": "1049930262",             "model": "lumi.curtain.hmcn02",             "pollingInterval": 10,             "deepDebugLog": false,             "onlyMainService": true,             "buzzerControl": true,             "ledControl": true,             "childLockControl": true,             "modeControl": true,             "motorControl": true         },         {             "name": "Entrance Right Curtain",             "ip": "<IP_ADDRESS>",             "token": "48715737553778326f566b6f42524d6c",             "deviceId": "1000898268",             "model": "lumi.curtain.hmcn02",             "pollingInterval": 10,             "deepDebugLog": false,             "onlyMainService": true,             "buzzerControl": true,             "ledControl": true,             "childLockControl": true,             "modeControl": true,             "motorControl": true         }
Debug log
[11/03/2023, 20:48:46] [homebridge-miot] [Entrance Left Curtain] Starting property polling. [11/03/2023, 20:52:03] [homebridge-miot] [Entrance Left Curtain] Got device configuration, initializing device with name: Entrance Left Curtain [11/03/2023, 20:52:04] [homebridge-miot] [Entrance Left Curtain] Model known: lumi.curtain.hmcn02! [11/03/2023, 20:52:04] [homebridge-miot] [Entrance Left Curtain] Initializing device! [11/03/2023, 20:52:04] [homebridge-miot] [Entrance Left Curtain] Initializing device services [11/03/2023, 20:52:04] [homebridge-miot] [Entrance Left Curtain] Device services: [   "curtain",   "identify",   "battery",   "curtain-cfg" ] [11/03/2023, 20:52:04] [homebridge-miot] [Entrance Left Curtain] Initializing device properties [11/03/2023, 20:52:04] [homebridge-miot] [Entrance Left Curtain] Device properties: [   "curtain:motor-control",   "curtain:target-position",   "curtain:status",   "curtain:fault",   "curtain:motor-reverse",   "curtain:current-position",   "curtain:wake-up-mode",   "battery:battery-level",   "battery:charging-state",   "curtain-cfg:set-limit-point",   "curtain-cfg:limit-point-num",   "curtain-cfg:curtain-manual",   "curtain-cfg:curtain-range-flag",   "curtain-cfg:run-time",   "curtain-cfg:lock-unlock-cmd",   "curtain-cfg:lock-unlock-status",   "curtain-cfg:bright-status",   "curtain-cfg:remote-power-off",   "curtain-cfg:battery-temp-warning",   "curtain-cfg:long-batt-life-mode",   "curtain-cfg:aging-test",   "curtain-cfg:set-rail-type",   "curtain-cfg:sync-utc",   "curtain-cfg:light-auto-timezone",   "curtain-cfg:light-auto-param",   "curtain-cfg:unlocked-ever",   "curtain-cfg:pointset-block-time",   "curtain-cfg:long-batt-time-zoom" ] [11/03/2023, 20:52:04] [homebridge-miot] [Entrance Left Curtain] Initializing device actions [11/03/2023, 20:52:04] [homebridge-miot] [Entrance Left Curtain] Device actions: [   "curtain:motor-calibrate",   "identify:identify",   "curtain-cfg:sync-all-rd-attr",   "curtain-cfg:block-auto-pointset",   "curtain-cfg:resume-auto-pointset" ] [11/03/2023, 20:52:04] [homebridge-miot] [Entrance Left Curtain] Successfully created a Curtain device! It is a Xiaomi BLE Curtain Driver E1. [11/03/2023, 20:52:04] [homebridge-miot] [Entrance Left Curtain] Initializing accessory! [11/03/2023, 20:52:04] [homebridge-miot] [Entrance Left Curtain] Accessory successfully initialized! [11/03/2023, 20:52:04] [homebridge-miot] [Entrance Left Curtain] Registering 1 accessories! [11/03/2023, 20:52:04] [homebridge-miot] [Entrance Left Curtain] Everything looks good! Initiating property polling! [11/03/2023, 20:52:06] [homebridge-miot] [Entrance Left Curtain] Device found! Setting up miot device from local connection! [11/03/2023, 20:52:06] [homebridge-miot] [Entrance Left Curtain] Connected to device: lumi.gateway.mcn001 [11/03/2023, 20:52:06] [homebridge-miot] [Entrance Left Curtain] Doing initial property fetch.
Screenshots

I think this might be caused by a delay for the property updates? You would need to enable deepDebugLog and observe the log when you trigger the open or close to see if and how long it takes for the status properly to update.

I'm not sure if it's a delay, it's precisely the lack of a property update event. Because even a few hours after closing, the status "Opening..." may hang.

Like I mentioned, you need to check if the status property is properly updated from the device.


Custom Grafana URL

Hi,
With venus-grafana-deployer, Grafana isn't running here
Can we have this location configurable, preferably via an env var?

Definitely, good catch. Do we need to override just the port (meaning Grafana will be running side by side with Influx Loader) or complete GRAFANA_URL?

At the moment in venus-grafana-deployer, we have Grafana running on / (the root) of the same host / domain name. So I guess having the port configurable would be enough. But for flexibility I'd rather be able to specify the full URL if possible (which I guess can even be the relatively relative / in this case).

:tada: This issue has been resolved in version 1.3.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


HIVE-27580: Backport HIVE-20071: Migrate to jackson 2.x and prevent usage

What changes were proposed in this pull request?
This is the third step to remove dependency on jackson-core-asl and jackson-mapper-asl.
Why are the changes needed?
To make it safe remove jackson-core-asl and jackson-mapper-asl from pre-built distribution:
spark-sql (default)> select soj_nvl('x', 'y');
23/08/08 14:31:25 ERROR SparkSQLDriver: Failed in [select soj_nvl('soj_cstmzd_tag', 'chnl_id')]
java.lang.NoClassDefFoundError: org/codehaus/jackson/map/type/TypeFactory
	at org.apache.hadoop.hive.ql.udf.UDFJson.<clinit>(UDFJson.java:64)
	at java.lang.Class.forName0(Native Method)
	at java.lang.Class.forName(Class.java:348)

Does this PR introduce any user-facing change?
Is the change a dependency upgrade?
How was this patch tested?

cc @sunchao @pan3793

Add HIVE-22059 to fix:
 mvn clean install -DskipTests=true
cd service && mvn test -DwildcardSuites=none -Dtest=org.apache.hive.service.cli.session.TestSessionHooks test

[INFO] Running org.apache.hive.service.cli.session.TestSessionHooks
[ERROR] Tests run: 2, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 3.236 s <<< FAILURE! - in org.apache.hive.service.cli.session.TestSessionHooks
[ERROR] org.apache.hive.service.cli.session.TestSessionHooks.testSessionHook  Time elapsed: 3.128 s  <<< ERROR!
java.lang.NoSuchFieldError: ALLOW_LEADING_DECIMAL_POINT_FOR_NUMBERS
        at com.fasterxml.jackson.core.json.JsonReadFeature.<clinit>(JsonReadFeature.java:121)
        at org.apache.hadoop.hive.ql.udf.UDFJson.<clinit>(UDFJson.java:69)
...

Merged to branch-2.3, thanks @wangyum !


Other brand bms want to use esphome

I want to adapte lolan bms to esphome，but i meet some problems，Could you help me to analysis

What do you know about the BMS? Please provide as much details as you can.

app_unpack.zip
wechat_miniprogram_unpack.zip
seller give me two way to view information. I use some unpack tools to unpack it.Seller do some Obfuscation in program. The app is difficult to understand. Wechat Miniprogrammar is easier to understand, but i'm not good at dealing this.I  try to nrf connect to get information directly,but I failed.

Do you know how to prepare a btsnoop capture of the BLE traffic?
Please give it a try<EMAIL_ADDRESS>

Are you able to talk to the BMS using the WeChat examples?

bluetooth log，i have collected.  In the log ,my device name is realmech*****,Bms board name is Baken*****
btsnoop_hci_20240623_002937.zip

-> Write Request (0x12) to handle 0x0011 -> Subscribe notifications
-> Write Command (0x52) to handle 0x0013: c56500bc614e

<- Notification received:<PHONE_NUMBER>b8e6b8000000000000000041d59f3041cd0b30429d9320424753ec00343f6e00010027

-> Write Command (0x52) to handle 0x0013: c56500bc614e

<- Notification received:<PHONE_NUMBER>b8e75c000000000000000041d59f3041cd10e0429d9320424753ec00343f6f00010027

-> Write Command (0x52) to handle 0x0013: c56500bc614e

<- Notification received:<PHONE_NUMBER>b8e70a000000000000000041d5a4e041cd10e0429d9320424753ec00343f7000010027

-> Write Command (0x52) to handle 0x0013: c56500bc614e

<- Notification received:<PHONE_NUMBER>b8e666000000000000000041d59f3041cd1680429d9320424753ec00343f7100010027

-> Write Command (0x52) to handle 0x0013: c56500bc614e

<- Notification received:<PHONE_NUMBER>b8e615000000000000000041d5997041cd0590429d9320424753ec00343f7300010027

btsnoop-reduced.json
btsnoop-reduced.log

Could you provide some screenshots of the android app? I would like to know the measurements shown at the app.

Could you please provide a contact for a chat software, similar to Discord? I think it seems more conveniently

this is Wechat MiniProgrammar view，the original is Chinese， i have translated it  to english


Add an experimental abs-capture-time RTP header extension.

We wish to start experimenting with a new RTP header extension to see if we can pull off A/V-synchronization, and associated metrics, when there's a variety of complicated intermediate servers involved.

The Travis CI build failure is because Formal name: http://www.webrtc.org/experiments/rtp-hdrext/abs-capture-time makes it so that the text refers to itself.

PTAL @alvestrand


unify get image methods

Ⅰ. Describe what this PR does
unify get image methods
The basic logic is as follows:

If the corresponding value is not empty in "runtime.Spec", use it directly.
Otherwise, use the environment value.
If the environment value is empty as well, use the default value.

Ⅱ. Does this pull request fix one issue?

fixes #680
Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@0663f16). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #728   +/-   ##
=========================================
  Coverage          ?   16.82%
=========================================
  Files             ?       69
  Lines             ?     2996
  Branches          ?        0
=========================================
  Hits              ?      504
  Misses            ?     2441
  Partials          ?       51

Impacted Files
Coverage Δ

pkg/utils/docker/image.go
25.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0663f16...e424d1e. Read the comment docs.

1、I think we'd better abstract a set of common logic for all images, including master、worker、fuse、databackup/dataload、initContainer
2、write the default value to common
3、unify the logic for initContainer of master and databackup

Ok, I am working on it. Thanks.

@XIAO-HOU please resolve the conflict issue. Thanks.

@XIAO-HOU please resolve the conflict issue. Thanks.

I have fixed it.

Thanks! I have one suggestions in general.
In the past, init image is just for alluxio master. In the future, more Pods pehaps need to use it. I recommand to move it to utils.

@XIAO-HOU Please fix the conflict. thanks

@XIAO-HOU @yangyuliufeng Please fix the conflict. thanks

I have fixed the conflict. But I found that the jindo dataloader just uses the default image when the corresponding properties in configuremap are empty. So I skip the step that reading values from the environment variable when the corresponding properties in configuremap are empty, which is different from the common logic of getting alluxio runtime image. I am not familiar with jindo runtime, does it right? @frankleaf

@XIAO-HOU @yangyuliufeng Please fix the conflict. thanks

I have fixed the conflict. But I found that the jindo dataloader just uses the default image when the corresponding properties in configuremap are empty. So I skip the step that reading values from the environment variable when the corresponding properties in configuremap are empty, which is different from the common logic of getting alluxio runtime image. I am not familiar with jindo runtime, does it right? @frankleaf

Take a quick look at your PR, JindoRuntime is similar to AlluxioRuntime's under this process, but you need to put JINDO_SMARTDATA_IMAGE_ENV in the dataset env. After this PR, I can do this work


SUBMARINE-744. Frontend support for MLflow UI

What is this PR for?
Support for MLflow in workbench. Users click a button, and the submarine will redirect them to MLflow UI.
What type of PR is it?
[Feature]
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/SUBMARINE-744
How should this be tested?
https://travis-ci.org/github/kobe860219/submarine
Screenshots (if appropriate)

Questions:

Does the licenses files need update? No
Is there breaking changes for older versions? No
Does this needs documentation? No

@pingsutw  Please help me review this PR, thanks !

@tangzhankun Could help review this PR ? Thanks !