[BUG] The maintainance policy is not very clear about security vulnerability patches

Describe the bug
The maintenance policy on the project website can be interpreted in many ways when it comes to patching security vulnerabilities. e.g.
When we patch a security issue on main where do we backport these changes to? Will all the minor version releases receive the patch? e.g. 2.1, 2.2, 2.3, or is it just limited to the latest minor version.
Going by what i interpreted from our maintenance policy, I assumed that right now versions 1.3, 2.0, 2.1, 2.2, 2.3 and 2.4 should receive security patches. But another way to interpret this policy would be that just 2.4 and 1.3 get them to be released in the next patch release.
To Reproduce
Steps to reproduce the behavior:

Go to https://opensearch.org/releases.html#maintenance-policy
Read the policy

Expected behavior
It would be useful to clarify exactly what changes would go into which releases with some examples so that all the projects under open search follow the same maintenance flow and users of open search are aware of how they should target their upgrades to be secure.
Plugins
Please list all plugins currently enabled.
Screenshots
If applicable, add screenshots to help explain your problem.
Host/Environment (please complete the following information):

OS: [e.g. iOS]
Version: [e.g. 22]
Browsers: [e.g. Chrome, Safari]
Browser Version: [e.g 93.0.4521.12]

Additional context
Add any other context about the problem here.

Thanks @ashwin-pc
@pajuric @jhmcintyre - can you take a look at this one and see if we can come up with recommendations that we can work with the engineering team on - thank you

The policy currently reads:

For OpenSearch and other software in the OpenSearch project, new features and active development always takes place against the newest version. The OpenSearch project follows the semantic versioning specification for assigning version numbers to releases, so you should be able to upgrade to the latest minor version of that same major version of the software without encountering incompatible changes (e.g., 1.1.0 → 1.3.x).

As we use SemVer, the path to "safety" from older minor versions is to the latest minor+patch version of that major they're in. If we couldn't make those guarantees, then yes, we would have to constantly backport to every single minor version of every supported major version, but that is luckily not the case.
@ashwin-pc, did you have any statement in mind (in addition to that statement about following SemVer) that would remove any confusion around it?


EXC_BAD_ACCESS on iOS

After updating glog from version 0.3.3 to 0.3.5 it crashes on iOS with Thread 1: EXC_BAD_ACCESS (code=1, address=0x0) at line 1218 in logging.cc
This is the code triggering the crash:
google::InitGoogleLogging("Test SDK");
DLOG(INFO) << "Test logging";
The same code works fine on Android.
Same problem with version 0.3.4

Does it work if you disable TLS? This can be done using the command-line as follows:
$ cmake <glog-build-dir> -DWITH_TLS=OFF

Afterwards you need to compile glog again.

how to build glog in ios?


Remove the "City" field from Singapore.

Since Singapore is a city-state there are no cities in there, hence the City field is confusing and unnecessary.

This makes sense. Thanks for your contribution, @ordavidil.


update

Is it a translation of the code in Chinese? It would be welcomed but it might be a better idea to make a dedicated fork if it is a translation in depth concerning python scripts;

Looks cursed

Is it a translation of the code in Chinese? It would be welcomed but it might be a better idea to make a dedicated fork if it is a translation in depth concerning python scripts;

Just a misstep :)


patient-ssapp v0.11.3 component-form-validate-submit: Invalid form

After opening patient-ssapp/ I got this error:
component-form-validate-submit: Invalid form

It happened to me once in firefox (not in chrome), but I don't know to to reproduce it consistently.


--date-spec=hr changes number of unique visitors

This code gives 482 unique visitors for 13 September.
zcat -f /var/log/nginx/access.log.1 | \
grep -v -f /home/slisakov/scripts/exclude-list.txt |\
goaccess \
  --http-protocol=no \
  --http-method=no \
  --ignore-panel=HOSTS \
  --date-spec=hr \
  --ignore-panel=REFERRING_SITES \
  --sort-panel=REQUESTS,BY_VISITORS,DESC \
  --anonymize-ip \
  --exclude-ip <IP_ADDRESS>-<IP_ADDRESS>\
  --ignore-crawlers \
  --log-format COMBINED \
  --output /var/www/html/yesterday/index.html \
  -

If the --date-spec=hr option is omitted, number of unique visitors changes to 375, leaving other fields (total requests, valid requests etc.) intact.
What can be the reason of this difference?
(My confusion in https://github.com/allinurl/goaccess/issues/2554 actually stems from this issue)

I understand. So, if you're using the --date-spec=hr option, the numbers will vary. Are you suggesting that you'd like the unique visitor count to be grouped by date instead of the current behavior?

I understand. So, if you're using the --date-spec=hr option, the numbers will vary. Are you suggesting that you'd like the unique visitor count to be grouped by date instead of the current behavior?

Yes.

Hi @allinurl
I think that behavior for Unique Visitors (number in Overall Analyzed Requests panel) should be to group by same IP and agent, without date

I wonder if this could be included in #2669. What are your thoughts?

yes, it looks good, will be valid pattern without date? --unique-visitors-key=IP|UA
and also which panel(s) will be affected by value in this option?
Unique Visitors (number in Overall Analyzed Requests panel) or any other?

@tyctor, it should permit that. All the panes will be impacted since they rely on that key to calculate the visitors per request.

ok, understand, do you plan to include this feature in next release?

@tyctor, let me see if I can fit this into the next release. I've been working on some major plumbing for some exciting features. Stay tuned!

That's fine, I just asked


vite build error

Describe the bug
My project uses vue3+vite+js+ts:
it is an old project which use vite + vue3+js,recently I developed some new modules with typescript,it can run normal when use 'npm run dev' cammand,but when I use 'vite build', it reports errors like this:
[vite:esbuild] Transform failed with 1 error:
/components/quotedPrice/index.vue?vue&type=script&setup=true&lang.ts:2:5: ERROR: Expected ">" but found "class"
Expected ">" but found "class"
<template>

I think this error is not accurate, because if i delete class, it will be 'Expected ">" but found "@"'
Reproduction
none
Steps to reproduce
none
System Info
node: v16.18.0;npm:8.19.2
"pinia": "2.0.23",
    "vant": "3.6.4",
    "vue": "3.2.41",
    "vue-router": "4.1.5",
"@rollup/plugin-inject": "5.0.2",
    "@rushstack/eslint-patch": "1.2.0",
    "@types/node": "^18.11.18",
    "@vitejs/plugin-legacy": "2.3.1",
    "@vitejs/plugin-vue": "3.1.2",
    "@vitejs/plugin-vue-jsx": "2.0.1",
    "@vue/eslint-config-prettier": "7.0.0",
    "@vue/test-utils": "2.1.0",
    "afc-scss-base": "0.0.6",
    "autoprefixer": "10.4.12",
    "babel-eslint": "10.1.0",
    "babel-plugin-import": "1.13.5",
    "cnjm-postcss-px-to-viewport": "1.0.0",
    "compressing": "1.6.2",
    "eslint": "8.26.0",
    "eslint-plugin-vue": "9.6.0",
    "fast-glob": "3.2.12",
    "jsdom": "20.0.1",
    "klinecharts": "8.6.3",
    "lodash-es": "4.17.21",
    "node-sass": "7.0.3",
    "numeral": "2.0.6",
    "postcss-flexbugs-fixes": "5.0.2",
    "prettier": "2.7.1",
    "protobufjs": "6.10.2",
    "rollup-plugin-esbuild": "4.10.2",
    "rollup-plugin-web-worker-loader": "1.6.1",
    "sass": "1.55.0",
    "sass-loader": "13.1.0",
    "sass-resources-loader": "2.2.5",
    "start-server-and-test": "1.14.0",
    "terser": "5.15.1",
    "ts-loader": "^8.4.0",
    "typescript": "^4.9.4",
    "unplugin-auto-import": "0.11.4",
    "unplugin-vue-components": "0.22.9",
    "vant": "3.6.4",
    "vconsole": "3.14.7",
    "vite": "3.1.8",
    "vite-plugin-comlink": "^3.0.4",
    "vite-plugin-svg-icons": "2.0.1",
    "vite-plugin-vconsole": "^1.2.2",
    "vitest": "0.23.4",
    "vuedraggable-es": "4.1.1"

Used Package Manager
npm
Logs
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

<template>

Did you add  Tag? It seems that your template is invalid

<template>

Did you add </template> Tag? It seems that your template is invalid

no,beacuse I just show a little codes, if I delete all codes, just like this<template>

</template>,it will report the tempalte tag is error


Fix core gateway start parameter

gateway ignored generated config in /tmp/kopano/gateway.cfg and took it's default /etc/kopano/gateway.cfg
Fixes #413

Hi @engelant,
passing the configuration option as an explicit parameter is not necessary, since the config file is already specified through KOPANO_CONFIG_PATH.
Up until https://github.com/zokradonh/kopano-docker/pull/352 the config was specified as a parameter.


Hold workshops to teach people how to use our app to contribute to Commons

This was inspired by Shyamal's report in 2016 where he used our app to hold a Commons workshop in the Himalayas, citing:

A discovery was that people of the region are happy to use WhatsApp and Instagram to upload images but seemed to be a bit hesitant about using a browser and were quite happy to see the Upload to Commons app. It seems that there would be great value to localizing this as well as creating some kind of multi-share app that would save people the need to upload a single image to multiple sites and incur additional mobile internet cost.

I was thinking that at the end of 2019, after we have completed most of the improvements that are planned for our PG (trying to be optimistic here! :)), it might be a good idea to run a couple of workshops to teach people how to use the app to contribute to Commons, with focus on either Global South locations, or female contributors.
If we have volunteers to run them, I can include this in our PG proposal with a request for cost reimbursement. All travel should be local only (or at least low-cost ground transport) and it is expected that people will bring their own Android mobile phones, so costs should be kept low, preferably less than USD 200 per workshop.
Perhaps those in India (@maskaravivek , @ashishkumar468  , @tanvidadu , @ujjwalagrawal17 ?) could hold a local workshop there, and perhaps I or another woman (@neslihanturan , @tanvidadu ?)  might run one for women. Or any other volunteers?

I would be very happy to "spread the word" through the usual Wikimedia channels. I am positive that many chapters might chip in with a workshop in their country. Might be a very nice campaign indeed.

That would be wonderful, thanks! Would it help them if we prepared material for them to use in their teaching (e.g. a slideshow)? My main concern is that such material would get outdated quickly because of active development in our app, but if it helps it could still be worth the effort.

Maybe it would be better to collaboratively prepare a list of "things people need to know" about the app and uploading to Commons. I think the most didactive approach to showing the app would be an opportunity to do a live videocast of things happening on teacher's mobile device (he/she could walk them through the app). But I'm not sure if there is a good free app which allows reliable videocast.

We can definitely do a live videocast, but the main issue with using that as a tutorial is lack of easy updating options. With a list or other written media we can easily edit sections, but with a videocast, when anything is changed within the app, it will be difficult to update just that section of the videocast AFAIK.
A list of "things people need to know" about the app on Commons sounds like a great idea!

:-) I don't mean to do the videocast, let's just document ways how people can capture the screen themselves and do a live show.

Oh, I see! That looks a lot more feasible, haha. Will add this to our project plan. :)

The workshop concept looks like a wonderful idea. While the workshops remain in the distant future, i think it is worthwhile to start thinking about it. To begin with:

Who would be the target demographic of these workshops?
How would our audience learn about these workshops? We can't exactly afford ads, and would word of mouth be efecive enough?
Where would these workshop be held? For example, for a target audience of young people, universities could be a good idea.

Who would be the target demographic of these workshops?

Preferably underrepresented communities in Commons - which I think covers pretty much everywhere in the Global South, and additionally, non-male contributors anywhere in the world?

How would our audience learn about these workshops? We can't exactly afford ads, and would word of mouth be efecive enough?

Pamphlets and posters, perhaps? If we hold them in universities, there will be boards to put posters up for events. The only cost would be printing, if a volunteer could design the poster (as we did in the 2017 hackathon).

Where would these workshop be held? For example, for a target audience of young people, universities could be a good idea.

Great idea! I think universities would be excellent, especially for a low cost budget.

Great idea, can you imagine how many bug reports we can get with this way, I am very excited again! I am in as a volunteer:)

In case you're interested, I could help with this too. I live in India. Possibly with the help of user groups here, I could try conducting a workshop here. I'm OK if you've planned for a workshop somewhere else, though as I haven't conducted workshops before :-)
Typically, how much audience would you expect to attend the workshop?

Also, let me know if there is a particular place you're trying to target in India.

Fantastic, @sivaraam , thanks for offering. :) India would be great for a workshop. I don't have a particular part of India in mind, what would you (and the other folks who live in India) recommend?
For audience, I think we probably shouldn't target more than 20-30 per workshop. You might not be able to get around quickly enough to help everyone if the group was too large. Of course, it would depend on how many volunteers we have to run it, and the size of the free/cheap venues.

I don't have a particular part of India in mind, what would you (and the other folks who live in India) recommend?

Just thinking out loud, may be the people in the villages?

Sorry for the late reply!
I would also like to volunteer. I can help in organizing technical workshops focused on Open Source and how to contribute to Commons in my college, NSIT both as part of university technical fest or a standalone event.
The target audience will be the university students from NSIT as well as other nearby colleges and universites.

Wonderful, @tanvidadu , thanks for volunteering! :) I think one workshop held in a university (by you), and one held by @sivaraam in the villages, would be fantastic.
It will likely take a while before we are ready for this, since we need to get the backend overhaul completed and all major issues solved before it would make sense to hold these workshops. Probably in ~6 months from now or so?

Important: Originally I had planned for these to be held roughly around the middle of this year. However, due to the new directives listed at https://meta.wikimedia.org/wiki/Grants:Project , "All offline (in-person) public events funded by Rapid Grants, Project Grants, or Annual Plan Grants must be cancelled or postponed until further notice", and "We will not be approving grants for offline events happening before September 15, 2020 until further notice".
So we may either have to postpone these workshops, or there is also the option of cancelling them if that isn't feasible.

As we are approaching the end of our grant, unfortunately I will have to remove this from the grant tasks as per WMF's Covid directives. I think we can leave this issue open though, so that in the (far) future if someone wants to run a volunteer workshop they can refer to it.


issue/6224-drop-instance-dump

Description
The inmanta.execute.runtime.Instance.dump method doesn't seem to be used and is currently broken because it accesses ResultVariable.promises which only exists on some of its child classes. This PR removes the method
closes #6224
Self Check:
Strike through any lines that are not applicable (~~line~~) then check the box

[x] Attached issue to pull request
[x] Changelog entry
[ ] Type annotations are present
[ ] Code is clear and sufficiently documented
[ ] No (preventable) type errors (check using make mypy or make mypy-diff)
[x] Sufficient test cases (reproduces the bug/tests the requested feature)
[ ] Correct, in line with design
[ ] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: )
[ ] If this PR fixes a race condition in the test suite, also push the fix to the relevant stable branche(s) (see test-fixes for more info)

Processing this pull request

Merged into branches master in d83a5a031413d69dd80d40e4128f938f67f88c1b


Add Download Option

Hello,
Add an option to download movie or converte in mp3 please.
kind regards

Please add as an optional feature or external plugin to add download (mp3/mp4). As example to handle the download you can see this project https://github.com/shubapp/u2bear

@OneMoreThing
u2bear is realy nice app, simillar in some ways with Atraci. On the other hand, these 2 apps are defferent in a big way.  That's why Atraci couldn't use downloading option as they do, among other things..  Why is that, it was already explained in previous comments ...
Regards


[Offcanvas-list] Parent Menu visible under Submenu

I have an issue with submenu height and its parent menu height.
If parent menu is taller than submenu (so that user has to scroll on parent), then submenu is inside parent "viewport". So when user scrolls on submenu (even if submenu has no eventual overflow-y content), the parent menu appears under submenu.
This is because parent has position: absolute, so has submenus (whose height inherit from parent "viewport" height,  top & left depends on parent, and not on page, so scrolling is still triggered on parent).
The only solution i see is to break submenus hierarchy, chain it, and use link as the toggle reference.
But it will break fallback compatibility, so if someone has an idea about ho to fix it easily...
Reproduce bug on doc:
Create many
 in parent menu -> open submenu -> scroll -> parent menu is visible under submenu.

Tested on Chrome 39, Firefox 33.

i have same issue... any update?

Can you post the code? Probably has incorrect architecture

Ya, I was able to replicate this. @ArTiSTiX @navidkashani Did you look into what's causing it? Have a solution?

Any update or fix planned ?
As i said, The issue is due to nested position: absolute;.
With a hierarchical markup, submenus inherit parent menu height. Thus, scrolling both scrolls submenu and parent menu, and leads to unwanted display.
The solution is to avoid nesting submenus, and put them side by side. If you implement submenus this way, we must update JS to use the link href  (or a data-submenu attributes) to reference the submenu id.
The markup could look like this:

To Submenu

Submenu item

To keep the original behaviour, we could do something like:

on submenu link click:
** if '' parent has class "has-submenu" and contains a submenu (original behavior)
*** open it
** else check if link has an id reference, and references a offcanvas-list with class submenu (left or right)
*** open it
** else
*** follow link (ignore has-submenu class).

I think "offcanvas-list left-submenu" classes are already well styled. It only lacks the javascript to open it ("move-right" if it's "left-submenu") with a reference.

@ArTiSTiX Looks like you have the right idea for a fix. Can you submit a PR for this or do you need any more guidance for it?

I'm still experiencing this using build 5.5.3 has this moved beyond development? Or is there anything missing from the Foundation 5 docs?

Sorry folks, we got a little carried away trying to tackle Foundation 6 that 5 was a little neglected.
@ArTiSTiX While this might work pretty nicely if implemented, it would also be completely breaking, and in the name of SemVer, won't happen until at least Foundation 7.
I can tell you that the scrolling to reveal a parent menu problem was solved in 6. As for solving it in F5, I will put a request to the community to solve it in a non-breaking manner. PR's requested!

If you want a quick and dirty workaround, you can add a box shadow without blur to the submenu. We are using the right off-canvas menu.
.right-submenu {
	box-shadow: 99999px 0 0 99999px $off-canvas-bg;
}


Branchlist divergent progress component

Added calculate-divergence-bar in the playground
made enum orderSortDate types in queryParams
The UI in the playground

-The UI in gitness

Originally, I customized the file-view-gauge component , but the color props of Progress cannot be overwritten and the rounded props cannot just make the only one side so I created a new one from scratches instead.
-Added a few conditional functions for showing valid TableCell if the data has existed, including checking status, behind ahead
-Zoom in for details check

style setting in tailwind.config not working so using style properties for temporary

updated for details

Add a edge case logic if the behind and ahead values are empty, and a small align details issue.

not show the bar and align-content center in the table cell


⚠ TorrentLeech has degraded performance

In 13d59dc, TorrentLeech ($TL) experienced degraded performance:

HTTP code: 200
Response time: 5815 ms

Resolved: TorrentLeech performance has improved in bd6acba after 6 minutes.


Add Volcano Repo to helm hub

Signed-off-by: Thandayuthapani<EMAIL_ADDRESS>Chart for Volcano Project
ref https://github.com/helm/charts/pull/14692

cc @k82cn and @kevin-wangzefeng
you are listed as contacts for this repository. Do you consent to this. See the changed files for the details. The contacts are listed so that we can contact you in case of an issue.

yes，confirmed

Looks good to me, thanks.


Data-Visualization-with-Seaborn

In this project i have explored seaborn and made many visualizatioon techniques
I have used different distributions , various plot types and multi grid with seaborn
:p assign me this task under GSSOC"24

cant assign more issues as its limited to 60 points


update map markers to reflect search

Actually changing the marker colour is a royal PITA. What I have for now so we can play around with it are circles for the items which do not match the search results. The circles are not clickable, based on conversation with Jesi and Amber, but they can be if we change our mind on that. The circles are easy to change colours while we experiment.
You can check this out on the staging server: https://ppedia.surge.sh/search?query=cleveland

Cool! Do we have any grey's in our colour palette for the site we can try for the purple pins? I like the saturation of the purple, so about that darkness but grey should work for us to show it to Amber (that was her colour request I believe - grey and black).  Is changing the pin colour difficult or have you made it easier now? Thanks!


Refactor OpenEBS projects to use go-module

Description
Go has included support for versioned modules and users are encouraged to migrate to modules from other dependency management systems. It is a relatively easier system for package management and would be nice to have.
Context
Here is the wiki with the details on Go Modules
an official go blog post
and a simple medium article to understand a bit better.

The following projects need help with refactoring to use go modules.

https://github.com/openebs/zfs-localpv
https://github.com/openebs/node-disk-manager
https://github.com/openebs/maya

Some of the projects that have already been refactored are:

https://github.com/openebs/cstor-operators
https://github.com/openebs/velero-plugin
https://github.com/openebs/cstor-csi
https://github.com/openebs/upgrade
https://github.com/openebs/jiva-operator
https://github.com/openebs/jiva-csi
https://github.com/openebs/jiva
https://github.com/openebs/api

Can we mark this a good first issue & can I try to resolve this on the Maya repository :)

I think we can close this issue ?

yes! Thank you @vaniisgh


Update sequelize storage to sort results.

When the number of migrations start to increase and SequelizeMeta is persisted in a proper db, in my case postgresql, the table can start to be broken up across pages. This causes the results of findAll to be potentially out of order.
I'm using Sequelize-cli to build my migrations so all my scripts are prefixed with a timestamp making this default perfect, but if this doesn't work in all cases it would be extend this to use a storage option and update Sequelize-cli to use this sort by default.

LGTM

Makes sense. Should there be a default ?

We ran into an issue with the downgrade migrations being run in a different order than the migrations were listed in the SequelizeMeta table, and it caused issues with our schema migrations.
I think this change would fix that problem, but for now we're going to sort the list of migrations in our code and explicitly specify the downgrade order.

ah there is a default value already :dooh:


Discord @role

⚠ Please verify that this bug has NOT been raised before.

[X] I checked and didn't find similar issue

🛡 Security Policy

[X] I agree to have read this project Security Policy

📝 Describe your problem
Hello, I would like to know if it is possible to notify a discord role like @status with or without emote
🐻 Uptime-Kuma Version
1.20.2
💻 Operating System and Arch
Docker
🌐 Browser
Google chrome lastupdate
🐋 Docker Version
No response
🟩 NodeJS Version
No response

to notify a role on discord you need <@&Role ID>
example
<@&756952376413388962>

to get the id:

Thanks, i type @&10845350079775 but is <@&10845350079775> :)


Mac_arm64_staging plugin_lint_mac failed with Undefined symbols for architecture arm64

Part of https://github.com/flutter/flutter/issues/87508
Mac_arm64_staging plugin_lint_mac
[plugin_lint_mac] [STDOUT] stdout:     ld: warning: ignoring file /opt/s/w/ir/x/t/CocoaPods-Lint-20220322-5341-n64c8s-integration_test_macos/Pods/FlutterMacOS/FlutterMacOS.framework/FlutterMacOS, building for macOS-arm64 but attempting to link with file built for macOS-x86_64
[plugin_lint_mac] [STDOUT] stdout:     Undefined symbols for architecture arm64:
[plugin_lint_mac] [STDOUT] stdout:       "_FlutterMethodNotImplemented", referenced from:
[plugin_lint_mac] [STDOUT] stdout:           integration_test_macos.IntegrationTestPlugin.handle(_: __C.FlutterMethodCall, result: (Any?) -> ()) -> () in IntegrationTestPlugin.o
[plugin_lint_mac] [STDOUT] stdout:       "_OBJC_CLASS_$_FlutterMethodChannel", referenced from:
[plugin_lint_mac] [STDOUT] stdout:           objc-class-ref in IntegrationTestPlugin.o
[plugin_lint_mac] [STDOUT] stdout:     ld: symbol(s) not found for architecture arm64
[plugin_lint_mac] [STDOUT] stdout:     clang: error: linker command failed with exit code 1 (use -v to see invocation)

I don't see that log output in that build, which is failing with ProcessException: Bad CPU type in executable, is that log from another build?

I don't see that log output in that build, which is failing with ProcessException: Bad CPU type in executable, is that log from another build?

Oops, copies the wrong link. Updated.

ignoring FlutterMacOS, building for macOS-arm64 but attempting to link with file built for macOS-x86_64
It's pulling in the last published FlutterMacOS pod version 2.10.2 which doesn't support ARM yet.  We should skip moving plugin_lint_mac to prod until there are arm binaries in stable...

Flutter 3.0 FlutterMacOS pod with arm64 binary has been published.  @keyonghan can you try again?  Hoping it should work now.

Flutter 3.0 FlutterMacOS pod with arm64 binary has been published. @keyonghan can you try again? Hoping it should work now.

With the arm64 ruby, it finally passes!
https://luci-milo.appspot.com/raw/build/logs.chromium.org/flutter/led/keyonghan_google.com/0702c3bfc7a735541edf8d0c997340b988fe384a01fa867e705daa43272ab00d/+/build.proto

Recipe change is in supporting arm64 ruby, but the test is now flaky with same error as this bug: https://ci.chromium.org/p/flutter/builders/staging/Mac_arm64_staging plugin_lint_mac
One observation is the failures happen on only mac4 and mac5, while others pass on other bots. Do you see any bot related issue may cause this? /cc @jmagman

@keyonghan can you point me to a test run flaking on mac4 or 5? I'm not spotting it.

One build on mac5: https://ci.chromium.org/ui/p/flutter/builders/staging/Mac_arm64_staging plugin_lint_mac/1352/overview
One build on mac4: https://ci.chromium.org/ui/p/flutter/builders/staging/Mac_arm64_staging plugin_lint_mac/1351/overview
Please see historical ones (top 200): https://ci.chromium.org/p/flutter/builders/staging/Mac_arm64_staging plugin_lint_mac?limit=200

Hmm, it's not picking up Flutter 3.0, the old one is cached that doesn't support arm64
[plugin_lint_mac] [STDOUT] stdout: -> Installing FlutterMacOS (2.10.2)
[plugin_lint_mac] [STDOUT] stdout:   > Copying FlutterMacOS from `/Users/swarming/Library/Caches/CocoaPods/Pods/Release/FlutterMacOS/2.10.2-d686a` to `../CocoaPods-Lint-20220526-59852-ln1crj-integration_test_macos/Pods/FlutterMacOS`

Suspect these machines need a pod repo update run?

pod repo update works. Closed assuming fixed.


Revert to python 3.9

This reverts commit df0bad59d28244f31af1b1bcb8989870bb345401, reversing changes made to aff76f038bca0544c64a44634ad19fb5b98d0fb2.

Notes on why I'm doing this:

Dataflow workers currently use pangeo-docker-images tags. To get a worker with a new release of recipes, typically we’ve cut a new pangeo-docker-images tag.
pangeo-docker-images have all bumped to Python 3.10 since the last time I did this. Beam now supports 3.10 so I (naively) thought this might be okay.
I forgot pangeo-forge-recipes isn’t tested against 3.10. Which is reason enough not to run it with 3.10, but also found yesterday that some detail of our recipes 0.9.x to_beam() compilation errors out when beam tries to run it on 3.10. So on many levels, 3.10 is not currently an option for the 0.9.x series; xref https://github.com/pangeo-forge/pangeo-forge-recipes/pull/470 which will add 3.10 support.

This means that to get 0.9.4 into production ASAP we can’t use a new pangeo-docker-images tag. Instead, we can use an earlier (Python 3.9) tag, and make a runtime install of recipes 0.9.4 into the worker container. This is supported by both beam (of course) and also @yuvipanda added this feature to pangeo-forge-runner, so everything we need for this is there, it’s just a deviation from our prior practice.
The lack of a full integration test including pushing a job to Dataflow of course makes this type of problem more likely to arise. I will either add such a test here, or carefully manually test this PR, and then add this integration test as part of #204.

I will either add such a test here, or carefully manually test this PR, and then add this integration test as part of https://github.com/pangeo-forge/pangeo-forge-orchestrator/pull/204.

I think adding this test here is prudent, to prevent the types of production bugs that this PR aims to fix. And doing so here may be easier than waiting until #204, because the current paradigm (while flawed) is still more familiar to me currently than the #204 refactor.
I will model the dispatch of this test on the pangeo-forge-recipes tutorial notebooks tests, which can be manually slash-dispatched and also run on merge.

/run-dataflow-integration-test

/test-dataflow-integration

/test-dataflow-integration


Replace defaultQueue with queue

This PR is about replacing the soon to be deprecated defaultQueue attribute with queue in the GPU Compute article.
See https://chromium-review.googlesource.com/c/chromium/src/+/2651406
I'll update samples as well.
@kangz Can you review?
@petele Can you merge once it's approved by @Kangz?

When is the next batch happening?

When is the next batch happening?

A couple weeks most likely?

A couple weeks most likely?

A couple weeks most likely?

Let's hold off then.

A couple weeks most likely?

Let's hold off then.

It seems it's going to the only change in the next batch that will impact this article, so as discussed offline with @kangz, @petele you can merge and push live.

It seems it's going to the only change in the next batch that will impact this article, so as discussed offline with @kangz, @petele you can merge and push live.


Remove duplicate public path assignment

Context
__webpack_public_path__ is already assigned on top in the following line.
https://github.com/google/web-stories-wp/blob/2e0b822bcd77f1ede25cb34d54b7aac14abdbda7/assets/src/edit-story/index.js#L23
Summary

Relevant Technical Choices

To-do

User-facing changes

Testing Instructions

QA

[ ] This is a non-user-facing change and requires no QA

This PR can be tested by following these steps:

UAT

[ ] UAT should use the same steps as above.

This PR can be tested by following these steps:

Reviews
Does this PR have a security-related impact?

Does this PR change what data or activity we track or use?

Does this PR have a legal-related impact?

Checklist

[ ] This PR addresses an existing issue and I have linked this PR to it in ZenHub
[ ] I have tested this code to the best of my abilities
[ ] I have verified accessibility to the best of my abilities (docs)
[ ] I have verified i18n and l10n (translation, right-to-left layout) to the best of my abilities
[ ] This PR contains automated tests (unit, integration, and/or e2e) to verify the code works as intended (docs)
[ ] I have added documentation where necessary
[ ] I have added a matching Type: XYZ label to the PR

Fixes #

@googlebot I signed it!


Create user-provided-service is not idempotent when name is already taken

Please fill out the issue checklist below and provide ALL the requested information.

[x] I reviewed open and closed github issues that may be related to my problem.
[x] I tried updating to the latest version of the CF CLI to see if it fixed my problem.
[x] I attempted to run the command with CF_TRACE=1 to help debug the issue.
[x] I am reporting a bug that others will be able to reproduce.

Describe the bug and the command you saw an issue with
Trying to create a user-provided-service that already exists fails with exit code 1 instead of succeeding (like most other commands, such as create-space and create-user).  I seems like there have been previous efforts to make CF commands idempotent: https://github.com/cloudfoundry/cli/pull/2264
What happened
$ cf create-user-provided-service myservice
Creating user provided service myservice in org org-1 / space org-1-space-1 as admin...
The service instance name is taken: myservice.
FAILED
# exit code 1

Expected behavior
$ cf create-user-provided-service myservice
Creating user provided service myservice  in org org-1 / space org-1-space-1 as admin...
The service instance already exists: myservice.
OK
# exit code 0

Exact Steps To Reproduce
Steps to reproduce the behavior; include the exact CLI commands and verbose output:

Run cf create-user-provided-service myservice
Run cf create-user-provided-service myservice again

Fix for this is in and will be available in the next release.


When in read review mode avatar menu shows "Complete profile" notification - broken link

When in read review mode the avatar shows a red notification (probably inherited from OSrPRE) and the menu seems to be the old one with Complete profile. But when clicking on that it brings to a broken Not Found page as shown below.

This is a duplicate of #195, closing this one.


Floating Navigation with Animated Background not working on Windows 11.

The floating navigation and with animated background are not working. I'm running on Windows 11.

Unfortunately I don't have access to Windows 11 as of now. It'll take some time until I test Sweet-pop on Windows 11.

The floating navigation and with animated background are not working. I'm running on Windows 11.

Does animated background works when floating navigation is turned off?

Unfortunately I don't have access to Windows 11 as of now. It'll take some time until I test Sweet-pop on Windows 11.

The floating navigation and with animated background are not working. I'm running on Windows 11.

Does animated background works when floating navigation is turned off? I'm unable to reproduce this issue on linux.

After a while, I managed to get them working. The only thing that is not running is the navbar for extensions. Everything else seems okay.

The only thing that is not running is the navbar for extensions

Can you add a screenshot for this?

The only thing that is not running is the navbar for extensions

Can you add a screenshot for this?

The only thing that is not running is the navbar for extensions

Can you add a screenshot for this?

The tabs part gets crop, not sure how to solve it...

The only thing that is not running is the navbar for extensions

Can you add a screenshot for this?

The tabs part gets crop, not sure how to solve it...

The only thing that is not running is the navbar for extensions

Can you add a screenshot for this?

On fullscreen it works fine, no issues.

The tabs part gets crop, not sure how to solve it...

Checkout #15. I'm trying to figure it out

I have the exact same problem on Windows 11.

@seventhstorm and @f-x1-1 , the issue is fixed in #20


Use one networking library

Currently both Volley and Apache HttpClient are being used. I think it'd be preferable to just use one networking library. My suggestion would not be to use either Volley or Apache HttpClient though, but instead use Retrofit, mainly because:

it is used a lot more than Volley is
there is a GSON converter which makes JSON parsing a breeze
there is better documentation on Retrofit compared to Volley
it is more modular than Volley or Apache HttpClient with the use of converters and adapters (though it has been a while since I've used Volley or Apache HttpClient so correct me if I'm wrong).

Thoughts?

Uniformizing is a good idea, and Retrofit looks nice indeed.
What is the size of the JARs for each solution?
On Thu, Apr 13, 2017 at 5:42 AM, Veyndan Stuart<EMAIL_ADDRESS>wrote:

Currently both Volley and Apache HttpClient are being used. I think it'd
be preferable to just use one networking library. My suggestion would not
be to use either Volley or Apache HttpClient though, but instead use
Retrofit https://github.com/square/retrofit, mainly because:

it is used a lot more than Volley is
there is a GSON converter
https://github.com/square/retrofit/tree/master/retrofit-converters/gson
which makes JSON parsing a breeze
there is better documentation on Retrofit compared to Volley
it is more modular than Volley or Apache HttpClient with the use of
converters and adapters (though it has been a while since I've used Volley
or Apache HttpClient so correct me if I'm wrong).

Thoughts?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/commons-app/apps-android-commons/issues/492, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAGFBh74uaeV8JVqmMyIT1hSOWXoNgNQks5rvTczgaJpZM4M78fa
.

Looks good to me, if anyone would like to rewrite the relevant code to use it.

I wasn't totally sure how to find out the jar size of a dependency through Gradle, so if anyone has any idea I'd be very grateful. According to methodscount.com, Retrofit has a size of 505KB and Volley has a size of 86KB. Note that Retrofit has a large size due to transitive dependencies, but this also means that if we use other Square libraries that depend on Okio or Okhttp then we won't incur the cost of the transitive dependencies again.

This will be handled via #1092


add modelextent plot

This PR is originally made by @dbrakenhoff to add a modelextent-plot.
It has been misused by me (@rubencalje) to replace some of the methods from the resample-module to the grid-module. For example the nlmod.resample.get_extent(ds) now is nlmod.grid.get_extent(ds), which I think is more logical. The original methods still function, and the user will see a warning that the old methods are deprecated.

Test fails unrelated.

Nice addition. There are already two functions in nlmod.util to create a polygon from the extent polygon_from_extent and to create a geodataframe from an extent gdf_from_extent. I think these functions are nice to keep and the plot function can call them. Only thing is that we should move them somewhere else because 'util' is not the best place. Probably the resample module is a good place because get_extent is also in there.

It is even worse... We also have nlmod.resample.get_extent_polygon. This method also takes a rotated grid into account.

Nice addition. There are already two functions in nlmod.util to create a polygon from the extent polygon_from_extent and to create a geodataframe from an extent gdf_from_extent. I think these functions are nice to keep and the plot function can call them. Only thing is that we should move them somewhere else because 'util' is not the best place. Probably the resample module is a good place because get_extent is also in there.

It is even worse... We also have nlmod.resample.get_extent_polygon. This method also takes a rotated grid into account. Maybe we can merge some of these methods?

I moved some of the methods from the resample-module to the grid-module (also see the starting-message of this PR). I also moved extent_to_polygon from the resample-module to the util-module, where it replaces polygon_from_extent, and renamed gdf_from_extent to extent_to_gdf in the util-module. These methods in the util-module can also be used without a grid, and therefore the util-module is a good place for these methods.
All the old methods continue to work for now, and the user will get to see a deprecation-message.


Feature/type specific highlight

This PR fixes #33 and is related to two issues related to the highlighting of matches in the frontend.
First, highlighting currently disregards type. It is only done on the basis of string equality, which means that words highlighted as long as they contain the selected 'word', even though they are of a different type.

(left the current situation, right the proposed one)
Second, samples containing two (or more) matching phrases appear twice (or more often) in the list of results, and all phrases containing the matching word are highlighted, e.g.

In this PR, a unique key (tuple) consisting of word, lemma and type is created for each row, and the index of the phrase that should be highlighted is recorded in the backend and passed to the frontend. Now the frontend has a way to identify a specific phrase within a sample, which we will need for the implementation of type searching (#???) as well.

As discussed, this can be merged for now, but future optimisations are possible (#46).


Scale mutation rate for the diploid case and add tests

Fix #39

I am still getting a few assertion fails for the test_ts_simple_n8 tests. They are caused by high relative differences but tiny absolute differences between log-likelihood values and FB product matrix values.
For example:
E           AssertionError:
E           Not equal to tolerance rtol=1e-09, atol=0
E
E           Mismatched elements: 1 / 1 (100%)
E           Max absolute difference: 8.19678347e-16
E           Max relative difference: 1.88888889
E            x: array(-1.253626e-15)
E            y: array(-4.339474e-16)

And
E           AssertionError:
E           Not equal to tolerance rtol=1e-09, atol=0
E
E           Mismatched elements: 25 / 27 (92.6%)
E           Max absolute difference: 9.64327467e-17
E           Max relative difference: 1.
E            x: array([9.643275e-17, 1.928655e-16, 1.928655e-16, 1.928655e-16,
E                  1.928655e-16, 1.928655e-16, 1.928655e-16, 1.928655e-16,
E                  1.928655e-16, 1.928655e-16, 1.928655e-16, 1.928655e-16,...
E            y: array([9.643275e-17, 9.643275e-17, 9.643275e-17, 9.643275e-17,
E                  9.643275e-17, 9.643275e-17, 9.643275e-17, 9.643275e-17,
E                  9.643275e-17, 9.643275e-17, 9.643275e-17, 9.643275e-17,...

Assert allclose at rtol=1e-09 and atol=0 may be too strict.

Perhaps we could use numpy.testing.assert_almost_equal  instead. Doc here.
"The test verifies that the elements of actual and desired satisfy.
abs(desired-actual) < float64(1.5 * 10**(-decimal))"

It's strange that four tests failed on my machine but passed during CI.

Not sure if this is due to architecture. I'm using Apple Silicon. I guess the workflows here use an Intel chip?


improvement: don't trap these other schema loading errors

addresses some outstanding exception trapping i spotted, related to #1481 and #1482. @divyenduz @zth what do you think?

@acao excellent! 👍


Error: Failed to scan jar file

I'm getting this error while scanning my home directory on Arch Linux:
Failed to scan Jar file: /home/binary/mnt/games/badlion/.minecraft/versions/BLClient/PRODUCTION3/1.19.4/BLClient.jar
Error:9

I'm running Nekodetector as root.

This happened for me with Betacraft's discord_rpc.jar plugin.
java.util.zip.ZipException: zip file is empty


Consider migration from winapi-rs -> windows

It seems https://github.com/retep998/winapi-rs is now unmaintained due to  https://github.com/microsoft/windows-rs (though the latter has some bananas build system)
(If we do this migration, we can replace ALLOWED_EKUS with [ szOID_PKIX_KP_SERVER_AUTH ]. We mustn't do that with winapi-rs, as this (and every other sz* constant string is dangerously wrong!)

It might be useful to use windows-bindgen to generate bindings only for the symbols we need.

I also have a bit of experience with this, and I've taken different approaches in different crates. In sys-locale for example, I was only using ~3 items from the Windows headers and went with the bindgen-based approach. chrono looks to be in a similar situation. Otherwise I've used windows-sys and tried keeping its version synced with what tokio uses to be less burdensome on the ecosystem (see also #63 where this concern came up).
tokio is on windows-sys 0.52 right now, which is reasonable IMO. That only depends on windows-targets 0.52 which is helps provide "proper" linkage that is guaranteed to work in more places. The downside is that it slightly increases the lockfile size with the import lib wrapper crates.
In this crate, I imagine that we would only need to codegen wincrypt and some foundational types/errors. I think it may just get annoying if local changes are needed and constants/functions you want can't be autoimported by RA.

and every other sz* constant string is dangerously wrong!

FWIW I don't think they are wrong, I just think they require some extra care to use by default. Writing the constants as Rust strings is a lot more succinct, makes printing error messages and types easier, etc.

It looks like chrono is using windows_targets anyway so I don't see a huge difference between a small subset of windows-sys vs custom generation TBH.

The problem that's been discussed is that windows-sys is a sizable download, so if you depend on a smallish part of it there's a bunch of effort wasted downloading and unpacking all that code.

17MB does seem to be a bit much, even though I think almost everyone is downloading this already.

I guess anyone doing local development of on rustls-platform-verifier can just manually substitute the dependency out temporarily, even if that would get old after a while.

It's not a big deal -- I'd be okay with taking a dependency on windows-sys since this needs quite a bit more surface area than chrono (and is also itself a higher-level sort of library).

It seems https://github.com/retep998/winapi-rs is now unmaintained

I think the situation might be a bit more nuanced: https://github.com/rustsec/advisory-db/issues/2031

It seems https://github.com/retep998/winapi-rs is now unmaintained

I think the situation might be a bit more nuanced: rustsec/advisory-db#2031

While that might be true, the ecosystem is moving to windows-sys anyway so I still think joining that movement makes sense for this crate.


Mobile button [Open link in browser] after scan

When sharing a URL
Current behavior :

URL is displayed (and clickable) on browser

Desired behavior :

URL is displayed (and clickable) on browser
Button on mobile allows user to trigger browser redirection to URL

It would be great to just unconditionally open a new tab in browser on URL reception. Unfortunately, browser security policy usually prevents this.

New policy is: in case of simple URL (not an uploaded resource), open directly the URL in current tab.
Current issue #238 would change this direct behavior.

Note that any new button has a cost to develop, a cost to maintain, but more importantly is an extra cognitive burden on the end user.  Consider avoiding the new button when applicable.

The current policy "in case of simple URL, wait 500ms then open directly the URL in current tab" is good enough.


kdfs: make free calls check for NULL.

Endemic issue in the provider KDF free functions.
Fixes  #10494

Endemic is a great word.

Merged to master.  Thanks.


Extension: Quote

Sometimes everyone is frustrated while doing work. This will create an inspirational Quote.

Hey, @harshita214 I want to work on this issue.

Hey, So will it give a new quote every time?

Yes, every time we click on the extension it will give a new quote.

So for that purpose are u thinking of implementing API or writing manually some quotes or something else, can you explain this. Also, are u adding a button to give new quotes every time its clicked

Yes, I will use API to fetch quotes. I will add a button to get new quotes every time.

Great, okay then you can go ahead and start building 🚀
All the best @trunmhrshi 👍

Completed - #24


Fi 1072 add allergyintolerance reaction and manifestation

AllergyIntolerance.reaction.manifestation is now must support in 3.1.1. This PR updates the test set to include this element.

Was there any opportunity to fill data in here with something 'realistic' or is that too much of a lift?

Was there any opportunity to fill data in here with something 'realistic' or is that too much of a lift?

Yep, just updated to "skin rash" instead.

Ideally we want to keep these hardcoded changes to a minimum.  So could you just put it in one resource instead of all?  Ideally, this would check to make sure that synthea didn't already fill in these (I know the current version doesn't, but i bet future versions will), and only add one (and only one) if none have been added already.

Ideally we want to keep these hardcoded changes to a minimum. So could you just put it in one resource instead of all? Ideally, this would check to make sure that synthea didn't already fill in these (I know the current version doesn't, but i bet future versions will), and only add one (and only one) if none have been added already.
Updated to only make changes if no allergy

Updated to only make changes if no allergyintolerance has a reaction.manifestation and to only change one allergyintolerance.


Releasing python code of adversarial competition evaluation infrastructure

Thanks,
I'm still working on proper travis.yml - I need to add few dependencies needed for my tests


Fixes to pyro model initialisation & sampling [WIP]

Addresses https://github.com/scverse/scvi-tools/issues/2616
Replaces https://github.com/scverse/scvi-tools/pull/1805

I don't fully understand the reason for the errors - they don't happen in test_pyro_bayesian_regression_low_level, test_pyro_bayesian_regression, test_pyro_bayesian_regression_jit - but they happen when using train() directly. This approach works for cell2location.
The difference maybe the timing when the plates are first used. I will look into this later.

Also this code for posterior sampling:
        if isinstance(self.module.guide, poutine.messenger.Messenger):
            # This already includes trace-replay behavior.
            sample = self.module.guide(*args, **kwargs)

is indeed ~2-3x faster but it creates samples of huge observed data matrixes (copies data n_samples times - eg 1000).
An alternative way to deal with this issue would be this:
        if isinstance(self.module.guide, poutine.messenger.Messenger):
            # This already includes trace-replay behavior.
            sample = self.module.guide(*args, **kwargs)
            # include and exclude requested sites
            sample = {k: v for k, v in sample.items() if k in return_sites}
            sample = {k: v for k, v in sample.items() if k not in exclude_vars}   # this has to be provided by model developer

Also this code for posterior sampling:
        if isinstance(self.module.guide, poutine.messenger.Messenger):
            # This already includes trace-replay behavior.
            sample = self.module.guide(*args, **kwargs)

is indeed ~2-3x faster but it creates samples of huge observed data matrixes (copies data n_samples times - eg 1000).
An alternative way to deal with this issue would be this:
        if isinstance(self.module.guide, poutine.messenger.Messenger):
            # This already includes trace-replay behavior.
            sample = self.module.guide(*args, **kwargs)
            # include and exclude requested sites
            sample = {k: v for k, v in sample.items() if k in return_sites}
            sample = {k: v for k, v in sample.items() if k not in exclude_vars}   # this has to be provided by model developer

@martinkim0 What do you think we should do? What do you think about the initialisation solution?

@vitkl hey sorry for the delay, I'm planning on taking a look at this tomorrow!

This is actually my first time at taking a look at some of our Pyro code - I hadn't really interacted with it before. So I don't really understand the reason why some things are done, e.g., the warmup callbacks. I definitely need to take a deep dive into all of this.
However, it looks like both PyroJitGuideWarmup and PyroModelGuideWarmup are just passing in a single minibatch through the guide prior to the training loop, so I like the idea of having a method like setup_pyro_model that does this. I think this makes more sense in the training plan though, using one of the Lightning hooks such as on_train_start. And there's definitely something weird going on with tensors on different devices, and I think using one of the Lightning hooks would solve this since their backend will take care of moving tensors.
Regarding the sampling changes, would it be possible to include that in a separate PR? And then we can discuss that there. Thanks!

Just a brief reply. Happy to have a zoom call about pyro.
Pyro automatic variational distribution (Guide) doesn’t have any parameters until you do a first pass through the model and guide. When moving my code to multi-GPU training I found that this needs to be done in setup step of the Lightning workflow - otherwise parameters created on GPU don’t get moved between devices correctly - so it’s it would not in on_train_start. However, in the latest version the setup step also doesn’t work - as reported in the original issue. Moving the code to this function and calling it before using any Lightning workflow steps seems to solve the problem for cell2location and my other project.
Actually the reason for the errors might be resolved if you call both the model and guide with one batch (it’s possibly the issue with LDA model that uses a custom guide).

Please split into two PRs. One for the warmup changes and one for the inference changes. This makes it easier to follow changes.


Add UpWork icon

Hope I'm did it in right way. My first PR to Open Source project =)
P.S. Please, add some instructions and requirements for PRs to the README file. What the folder "reference" is for?

Hi Eugene! Thanks for this. I'll take a look tomorrow about adding some more details for the PR.

Looks good!


fix: Add Model2vec

Added model2vec models with metadata and implementation.

I have a guess - a pull from main should fix it

Also, I think @Pringled could review the implementation as well

@Samoed thanks for tagging me! I will have a look at the PR as well

@Pringled Thank you for the awesome feedback, I will implement these changes!!

Yeah, pydantic doesn't seem to be happy about np.inf. We can try to make an educated guess about what the max could be. I'm guessing maxint for 64 bit computers is probably a limit, no?

Thanks :D


CS0518 errors when using nuget references on csx scripts

Issue Description
I'm writing some .csx scripts to process a bunch of CSV files. For this I want to use some Nuget packages. The first one is CsvHelper. So I add the following lines to the script:
...
#r "nuget: CsvHelper, 27.2.1"

using CsvHelper;
...

Then Omnisharp says, obviously, that it doesn't know what CsvHelper since it hasn't been dowloaded yet. So I run the script so dotnet-script handles the reference and downloads the dll. The next step is to restart Omnisharp so it catches the changes. Well, after restarting it I got a bunch of red squiggles with CS0518  'Predefined type 'System.Object' is not defined or imported' errors among others, one or more than one per line. Even on empty lines:

But if I run the script, it runs perfectly, so there aren't any real errors.
I checked that if I download the dll and refer it on the script using a fixed path:
...
#r "bin/CsvHelper.dll"
...

there is no problem and Omnisharp works fine.
This is happening with other Nuget packages I've tried (SharpZipLib and Microsoft.Data.Sqlite), so I suspect it may happen with any nuget package.
I've detected it on my Windows 10 machine, but to ensure that the environment isn't interfering I've checked it on the VSCode dotnet dev container.
The omnisharp.json file I'm using is:
{
  "script": {
    "enableScriptNuGetReferences": true,
    "defaultTargetFramework": "net6.0"
  }
}

It's the one generated by dotnet script init.
Also I've tested it with the 1.24.0 beta version of the ms-dotnettools.csharp extension, with the settings
    "omnisharp.path": "latest",
    "omnisharp.useModernNet": true,

but the results are the same.
Steps to Reproduce
Create a csx script with a Nuget reference. Open it on VSCode.
Expected Behavior
No errors reported by Omnisharp, since the script is ok.

Logs
OmniSharp log
Starting OmniSharp server at 1/5/2022, 5:40:03 PM
    Target: /workspaces/csxtest
OmniSharp server started.
Path: /home/vscode/.vscode-server/extensions/ms-dotnettools.csharp-1.23.17/.omnisharp/1.37.17/run
PID: 1907
    Starting OmniSharp on debian 11.0 (x64)

    Checking the 'DOTNET_ROOT' environment variable to find a .NET SDK

    Using the 'dotnet' on the PATH.

    DotNetPath set to dotnet

    Located 1 MSBuild instance(s)
        1: StandAlone 17.0.0 - "/home/vscode/.vscode-server/extensions/ms-dotnettools.csharp-1.23.17/.omnisharp/1.37.17/omnisharp/.msbuild/Current/Bin"

    MSBUILD_EXE_PATH environment variable set to '/home/vscode/.vscode-server/extensions/ms-dotnettools.csharp-1.23.17/.omnisharp/1.37.17/omnisharp/.msbuild/Current/Bin/MSBuild.exe'

    Registered MSBuild instance: StandAlone 17.0.0 - "/home/vscode/.vscode-server/extensions/ms-dotnettools.csharp-1.23.17/.omnisharp/1.37.17/omnisharp/.msbuild/Current/Bin"
        CscToolExe = csc.exe
        MSBuildToolsPath = /home/vscode/.vscode-server/extensions/ms-dotnettools.csharp-1.23.17/.omnisharp/1.37.17/omnisharp/.msbuild/Current/Bin
        CscToolPath = /home/vscode/.vscode-server/extensions/ms-dotnettools.csharp-1.23.17/.omnisharp/1.37.17/omnisharp/.msbuild/Current/Bin/Roslyn
        BypassFrameworkInstallChecks = true
        MSBuildExtensionsPath = /home/vscode/.vscode-server/extensions/ms-dotnettools.csharp-1.23.17/.omnisharp/1.37.17/omnisharp/.msbuild

    Invoking Workspace Options Provider: OmniSharp.Roslyn.CSharp.Services.CSharpFormattingWorkspaceOptionsProvider, Order: 0

    Invoking Workspace Options Provider: OmniSharp.Roslyn.CSharp.Services.Completion.CompletionOptionsProvider, Order: 0

    Invoking Workspace Options Provider: OmniSharp.Roslyn.CSharp.Services.RenameWorkspaceOptionsProvider, Order: 100

    Invoking Workspace Options Provider: OmniSharp.Roslyn.CSharp.Services.ImplementTypeWorkspaceOptionsProvider, Order: 110

    Invoking Workspace Options Provider: OmniSharp.Roslyn.CSharp.Services.BlockStructureWorkspaceOptionsProvider, Order: 140

    Detecting Cake files in '/workspaces/csxtest'.

    Could not find any Cake files

    No solution files found in '/workspaces/csxtest'

    Detecting CSX files in '/workspaces/csxtest'.

    Found 1 CSX files.

    Searching for compilation dependencies with the fallback framework of 'net6.0'.

    Added CSX project '/workspaces/csxtest/main.csx' to the workspace.

    Configuration finished.

    Omnisharp server running using Stdio at location '/workspaces/csxtest' on host 324.

    Solution initialized -> queue all documents for code analysis. Initial document count: 1.

    No symbol found. File: /workspaces/csxtest/main.csx, Line: 21, Column: 4.

Received response for /findusages but could not find request.
Received response for /findusages but could not find request.
Received response for /findusages but could not find request.

C# log
Output-->C# is empty
Environment information
VSCode version: 1.63.2
C# Extension: 1.23.17
Mono Information
        OmniSharp using built-in mono
Dotnet Information
.NET SDK (reflecting any global.json):
 Version:   6.0.100
 Commit:    9e8b04bbff
Runtime Environment:
OS Name:     debian
OS Version:  11
OS Platform: Linux
RID:         debian.11-x64
Base Path:   /usr/share/dotnet/sdk/6.0.100/
Host (useful for support):
Version: 6.0.0
Commit:  4822e3c3aa
.NET SDKs installed:
6.0.100 [/usr/share/dotnet/sdk]
.NET runtimes installed:
Microsoft.AspNetCore.App 6.0.0 [/usr/share/dotnet/shared/Microsoft.AspNetCore.App]
Microsoft.NETCore.App 6.0.0 [/usr/share/dotnet/shared/Microsoft.NETCore.App]
To install additional .NET runtimes or SDKs:
https://aka.ms/dotnet-download

Visual Studio Code Extensions

Extension
Author
Version

csharp
ms-dotnettools
1.23.17

Please paste the output from your clipboard

I've downgraded dotnet-script to 1.2.1 and changed omnisharp.json to target net5.0, and it's working correctly now. Thanks.


RTMPx and RTMFP

Hi,
is it planned to add RTMPx like RTMPE, RTMPS, RTMPT and RTMFP?
thanks

No plans yet…

ok here a nice project in c++ where rtmfp is available
https://github.com/MonaSolutions/MonaServer2


Translations update from Hosted Weblate

Translations update from Hosted Weblate for Fritter/Fritter.
Current translation status:

@jonjomckay I've seen there are some strings changed in English. Do you approve these changes? Because I don't know if I should adjust strings in my language.

Thanks for letting me know @Aga-C. A couple of them didn't read properly to me, so I've reverted them back. I think the remainder are OK, but I'm not too worried if they get translated - they're just minor changes that don't really affect understanding 🙂


Typeguards and ternary operator not correctly deducing type

TypeScript Version:  2.0.3
Code
let p:null|boolean|RegExp|{():void} = null;
let v:{(): boolean} = (
    p == null || p === true ? () => true
    : p === false ? () => false
    : (p instanceof RegExp) ? () => p.test('hi')
    : () => { p(); return true; }
);

Expected behavior:
This should compile and should find both p.test and p(), as the types are sufficiently narrowed at those points.
Actual behavior:
Even though everything is properly guarded (all null and boolean options eliminated), the RegExp line fails because p.test cannot be resolved on the union type, and the invocation of p() fails because the type hasn't been narrowed.  Replacing the above code with this fixes it:
let p:null|boolean|RegExp|{():void} = null;
let v:{(): boolean} = (
    p == null || p === true ? () => true
    : p === false ? () => false
    : (p instanceof RegExp) ? () => (p as RegExp).test('hi')
    : () => { (p as {():void})(); return true; }
);

In this version, both lines are typecast, and the compiled javascript looks correct.  So it seems to be a typeguard issue.

This is working as intended. When you declare a variable with let or var the compiler can't know for certain that the variable hasn't changed before the arrow function is invoked. However, if you declare your variable as const, type guards remain in effect in nested function expressions and arrow functions. For example, this works:
const p:null|boolean|RegExp|{():void} = null;  // Using const here
let v:{(): boolean} = (
    p == null || p === true ? () => true
    : p === false ? () => false
    : (p instanceof RegExp) ? () => p.test('hi')
    : () => { p(); return true; }
);

Ok, makes sense, thank you for the explanation.


Support React 17 automatic runtime

Feature request
https://github.com/evanw/esbuild/releases/tag/v0.14.51 just came out with support for React 17 automatic runtime and it would be great if tsx could support it also.
Ideally just like esbuild with TSConfig resolution so no need to duplicate config.
Why?
To keep feature parity with esbuild
Alternatives
Keep importing React in ts files
Additional context
No response

This is already supported.
You can run npm update to update your esbuild because tsx uses a range dependency.
As per the release notes, you can configure it to use automatic mode via tsconfig.json#compilerOptions.jsx & tsconfig.json#compilerOptions.jsxImportSource.

My bad, I should have thought of that first.
Thank you for your time !


The camera was detected by the OS as connected to a USB 2.1 port.

Using D430 module:
➜  ~ uname -r
4.18.0-18-generic
➜  ~ lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description:    Ubuntu 18.04.2 LTS
Release:        18.04
Codename:       bionic

Intel RealSense Viewer v2.21.0
Firmware already upgraded to <IP_ADDRESS> .
Just wonder why for 1280x720, it'll be ONLY 6 FPS ? Is it because of the USB 2.1 speed limit? If this USB can be recognized as USB 3.0/3.1, will the depth streaming be faster?
Cheers
Pei

If you look at pages 54 to 56 of the data sheet for the 400 Series cameras, you can see the resolution and FPS modes available on USB 3 and USB 2 connections.
https://www.intel.co.uk/content/www/uk/en/support/articles/000026827/emerging-technologies/intel-realsense-technology.html
The table at the bottom of page 55 confirms that 6 FPS can be expected on a USB 2 connection at 1280x720 due to USB2's limitations.  The camera is capable of much more on a USB 3 connection, where it is capable of up to 30 FPS at 1280x720.


Added initial support for Markdown - issue-8

Fixes #8
The original tool had no support for Markdown files. I've added initial support for Markdown files with the use of regex.
import re is needed to use regex.
The tool will now also read files that ends with ".md"
In TextFile.process_file(), the code will process between ".txt" and ".md" files.
The process for ".txt" files have not been changed.
For ".md" files, it will process markdown syntax features for

Italics - will be generated surrounded by ... tag
Bold - will be generated surrounded by ... tag
Heading 1 - Context in Heading 1 for any ".md" file is treated as the title. Will be generated surrounded by
...
 tag
Heading 2 - Will be generated surrounded by
...
 tag

I've created regex patterns for each individual syntax for easier implementation and editing.
To handle bold and italics, I've used the findall() function in python to find all instances where the contents matches the regex in a single paragraph. Then I've replaced all matching instances from their Markdown syntax to having the corresponding html tag.
I've noticed that html italic and bold tags will cause the generated files to create new indented code blocks in html.
For example
*I* am afraid, Watson, that I shall have to go,” said Holmes, as we
sat *down* together to our breakfast **one** morning.

in .md files will generate in html as

    I

   am afraid, Watson, that I shall have to go,” said Holmes, as we
sat

    down

   together to our breakfast

    one

   morning.

The webpage will generate looking fine. But I'm still trying to figure out if this might be the cause of BeautifulSoup parsing, or something else.
Please review and provide feedback at your latest convenience. Thanks!

Hello! I have reviewed your code.
I have found one problem with italic text. I think the regular expression for italic text doesn't work. I have created a test Markdown .md file with the following content:
# Testing Heading & Title

## Testing Heading 2
## Testing Heading 3

**testing bold text**
*testing italic text*

***testing both bold and italic text***

The result that I got from the tool:

In addition, I would be great if you can add some information about Markdown feature in README.md file.

I've fixed the issue with italics
I've also added Markdown support for h3 headers and links.
I've also added Markdown information in the README.md file

Thank you! You did a great job!
Your work is working. Looking forward to work with you again the future!


Godot running game renders weirdly, with transparency and extra padding I never provided

Godot version
Godot 4 Beta 4
System information
Ubuntu 22.04 Running on Vulkan Mesa Intel® UHD Graphics 620 (WHL GT2)
Issue description
Expectations

Reality

Steps to reproduce
Clone https://github.com/Coder2195Text/tile-craft
And run the scene
At first itll give credit to an artist, just press continue
I know it says minial reproduction project, but idk if its the button glitched out while transferring from gd3-->gd4 or what because I didn't even set any material to make it half transparent nor did I add extra padding, but apparently it is, so idk if I can make an minial reproduction project
Minimal reproduction project
No response

Update: Restarting Godot resizes my button so that it has extra padding in my button inside the editor
Could this be gd3-->gd4 conversion issue?


Writing text on the OLED screen using the new system

I'm not really sure where I'm actually supposed to be looking since the documentation in the pitop OS and the website seems to point in all sorts of directions. I think this is the most up to date pitop repo, though I may be wrong.
I started trying to re-do an previous project that was on the now depreciated codebase. Just trying to basically copy the tutorial has already been quite difficult.
import pitop.miniscreen as screen
oled = screen.Miniscreen()

while True:
    oled.display_multiline_text('test')
    sleep(10)

Also tried:

import pitop.miniscreen
screen = pitop.miniscreen.Miniscreen()

Stuff like that, always the same error, which doesn't really tell me whats actually wrong. I'm not the most savvy on OOP, but I don't understand why "init" isn't working inside the miniscreen object. All the tutorials import the object without any arguments, so why does it demand arguments? Looking at the actual code it doesn't make any more sense to me.

File "/home/pi/Documents/file.py", line 1, in
import pitop.miniscreen as screen
File "/usr/lib/python3/dist-packages/pitop/init.py", line 1, in
from .system.pitop import PiTop
File "/usr/lib/python3/dist-packages/pitop/system/pitop.py", line 2, in
from pitop.miniscreen import Miniscreen
File "/usr/lib/python3/dist-packages/pitop/miniscreen/init.py", line 5, in
from .buttons import (
File "/usr/lib/python3/dist-packages/pitop/miniscreen/buttons/init.py", line 2, in
from .buttons import (
File "/usr/lib/python3/dist-packages/pitop/miniscreen/buttons/buttons.py", line 21, in
class Buttons(metaclass=Singleton):
TypeError: init() takes 2 positional arguments but 4 were give

hi @tykavanaugh !
the 2 snippets you included work for me (just had to import sleep), but your traceback makes me think that some of the files in the folder /usr/lib/python3/dist-packages/pitop/, where this SDK is installed, might have been modified. I say this because the init.py files referenced in your traceback should be named __init__.py.
Can you please try to re-install this package? You can do this in a terminal, running sudo apt install python3-pitop python3-pitop-full --reinstall

I can confirm that the snippets work for me (with sleep imported).
I am not sure why it would fail like this, but it does indicate that something under-the-hood is not versioned correctly or has been modified directly.

Hi - I am closing this as it doesn't appear to be a problem that we can replicate. If you have any further issues, please consider using the pi-top forum - thanks!

I figured out the issue, it was actually much more simple. I either hadn't restarted since the last time I ran apt upgrade, or only ran apt update and thought I had run both successfully. Same code worked perfectly fine upon reboot.


Does it support editing smart layers?

We currently do not support smart layers, neither editing.

Hi, @lanadeldel! If you're referring to Smart Objects, we don't support parsing layer effects yet, though quick testing indicates we can decode the image of a Smart Object layer just fine.
If you would like to request a feature, feel free to expand upon the issue here! We'd also be happy to accept a PR.

I think I need that function too, dynamically replace the image in the smart layer, then export as png|jpeg


rosrun mavros mavsys mode -c OFFBOARD

Describe the bug
when i am trying to start offboard mission by runing rosrun mavros mavsys mode -c OFFBOARD , i am getting error [ERROR] [1588485064.541397576]: MODE: Unsupported FCU
Error [parser.cc:689] Unable to find uri[model://iris_depth_camera]

i am also getting this
edith@edith:~/catkin_ws$ rosrun mavros mavsys mode -c OFFBOARD
Request failed. Check mavros logs
edith@edith:~/catkin_ws$ rosrun mavros mavsafety arm
Request failed. Check mavros logs

 Error [parser.cc:689] Unable to find uri[model://iris_depth_camera]

This output is not related to your command. It is coming because you didn't set the GAZEBO_MODEL_PATH properly.
Run
cd <Firmware_clone>
source ~/catkin_ws/devel/setup.bash
source Tools/setup_gazebo.bash $(pwd) $(pwd)/build/px4_sitl_default
export ROS_PACKAGE_PATH=$ROS_PACKAGE_PATH:$(pwd)
export ROS_PACKAGE_PATH=$ROS_PACKAGE_PATH:$(pwd)/Tools/sitl_gazebo

Thanks a lot.
It  works for me.


Symbol annotation does not seem to take point.value

Seems like if I want to create a simple annotation using existing symbol types like 'circle', it will only render at top of the chart even if value (tried price too) is passed. Seems like the value is ignored. If this is true, why?

Hmm, I think I understand now that annotations are for rendering at static y-positions. To render simple shapes that moves along with the chart, shapes are needed.

Shapes are generally used for multiple points, while annotations are used for single points.

I think ability to specify the y value via point.value is still useful for single point annotations. Without it, one will need to resort to shapes.

I was looking into this as well and saw that this issue is already resolved. It took me a while to find out the solution after digging into the code.
For anyone else that runs into this, you need to set the position to point. For example:
chart.createAnnotation({
  point: { timestamp:<PHONE_NUMBER>000, value: 100 },
  styles: {
    position: 'point',
    ...


Serializable Animated API

There is a section in doc that mentions

Note that Animated is designed to be fully serializable so that animations can be run in a high performance way, independent of the normal JavaScript event loop.

How would someone serialize animated configuration and run it in backend/native in high performance way? Everyone is talking about it but there is no simple example of it. Even @sahrens says at this video.

It's not implemented yet. Check - https://productpains.com/post/react-native/offload-some-animations-from-js-thread-for-better-perf/


Tile device tracker - unauthorized

Home Assistant release with the issue:
0.102.3
Last working Home Assistant release (if known):
0.89.2
Operating environment (Hass.io/Docker/Windows/etc.):
Hassbian
Integration:
https://www.home-assistant.io/integrations/tile/
Description of problem:
Added 2 tile accounts to the configuration yaml. On current stable of Home Assistant I constantly get following error for the second account:
pytile.errors.RequestError: Error requesting data from clients/****/sessions: 401, message='Unauthorized', url='https://production.tile-api.com/api/v1/clients/****/sessions
Connection lost. Reconnecting…

Although password and user account are correct and my running Home Assistant v0.89.2 has no problems.

I just loaded the latest dev with the typical config:
device_tracker:
  - platform: tile
    username: !secret tile_username
    password: !secret tile_password

Could you do the same (i.e., try the latest dev)? That will tell us if the issue is specific to a version or not.

Hey @bachya not yet loaded the dev version but 2 tiles of my account are working fine in 0.102.3.
It are the 2 other tiles on the other account that present the error. So my config consist out of 2 - platform: tile sections.
What do you propose I try?

So you have two accounts and one works while the other doesn't? You've tripled-checked your username/password on that second account? That error is pretty explanatory. Are you able to log out of the Tile app on your phone and re-login with those credentials?

Yes indeed! Both accounts work with login into the app and website.
Even more like I mentioned my old home assistant running v0.89.2 with the tile configuration works too.
Is there maybe an api call limit for tile? I can shut down the old home assistant. But odd that only 1 of the 2 accounts has problems.

Ok tried several things and in the end I changed the tile password, then it started picking it up again!!
Still no clue why previous was not allowing it, I even copy/pasted the secrets and config from the old Home Assistant.
Thx for the help anyway and great work of the plugin!


Allow updated versions of bleak to work

Thanks! I think the new Bluetooth and Govee integrations from core will cover this project going forward.


Add DTMF decoder

https://www.dcode.fr/dtmf-code
https://en.wikipedia.org/wiki/Dual-tone_multi-frequency_signaling

Hi, I would like to contribute to this issue if possible :) I have alredy joined your Discord server too (stanislav). Can you please assign it to me ?

Hi, I would like to contribute to this issue if possible :) I have alredy joined your Discord server too (stanislav). Can you please assign it to me ?

Hey! We have already implemented this, however we will let you know about future encoders :)


Add slack link to docs

@sarahwooders When I try to join the Slack from my personal email, it requires a "berkeley.edu" email.

I made a custom invite link: https://join.slack.com/t/skyplaneworkspace/shared_invite/zt-1cxmedcuc-GwIXLGyHTyOYELq7KoOl6Q. Can you update the link here to point to that?

It would be super cool if you could find a way to add this to the main doc page next to the Github star button:
[![Join Slack](https://img.shields.io/badge/Skyplane-Join%20Slack-yellow?logo=slack)](https://join.slack.com/t/skyplaneworkspace/shared_invite/zt-1cxmedcuc-GwIXLGyHTyOYELq7KoOl6Q)


REQUEST: New membership for Flying-Tom

GitHub Username

Flying-Tom
Organization you are requesting membership in

kurator-dev
Requirements

[x] I have reviewed the community membership guidelines
[x] I have joined in the community mailing group and slack
[x] I have watched kurator-dev/kurator on GitHub to subscribe updates (My account appears in the watchers list)
[x] I have enabled two-factor authentication on my GitHub account
[x] I am actively contributing to 1 or more Kurator subprojects
[x] I have spoken to my sponsors ahead of this application, and they have agreed to sponsor my application

Sponsors

List of contributions to the Kurator project

PRs reviewed / authored:
#639
#658
#659
#660
#662
#663
#668
#671
#679
#680

Issues authored:
#657
#665

Issues responded to:

welcome , invitation sent

Done

/close


Operator gets stuck at Waiting for service to be created

Describe the bug
When creating a new WireGuard resource, the operator creates services and secrets, but doesn't create the deployment, the status is stuck at Waiting for service to be created.
To Reproduce
Steps to reproduce the behavior:

Create the sample Wireguard and WireguardPeer
Wait a short period
Get Wireguard resource as YAML and see status.message field

Expected behavior
It should create the deployment.
Additional context
K8s version: 1.27.1
OS: Talos Linux v1.4.1
wireguard-operator version: 1.0.1

I think I found the error, since K8s v1.25.0, pod security admissions (https://kubernetes.io/docs/concepts/security/pod-security-admission) are marked as stable and enabled per default. It has prevented the vpn pod from starting, because it has the capability NET_ADMIN. This should be either documented or made configurable, as the capability is only required for using the kernel module.

It seems to work when using the main branch instead of the 1.0.1 release.

Waiting for service to be created
Can you describe the service and check why is not getting ready?
kubectl describe service VPN_NAME-svc

The service is ready, I've switched to a ClusterIP service for debugging purposes.

The service is ready, I've switched to a ClusterIP service for debugging purposes.
kubectl describe -n wireguard-system adblock-svc:
Name:              adblock-svc
Namespace:         wireguard-system
Labels:            <none>
Annotations:       service.beta.kubernetes.io/aws-load-balancer-nlb-target-type: ip
service.beta.kubernetes.io/aws-load-balancer-scheme: internet-facing
service.beta.kubernetes.io/aws-load-balancer-type: external
Selector:          app=wireguard,instance=adblock
Type:              ClusterIP
IP Family Policy:  SingleStack
IP Families:       IPv4
IP:                <IP_ADDRESS>
IPs:               <IP_ADDRESS>
Port:              <unset>  51820/UDP
TargetPort:        51820/UDP
Endpoints:         <none>
Session Affinity:  None
Events:            <none>

kubectl describe -n wireguard-system adblock-metrics-svc:
Name:              adblock-metrics-svc
Namespace:         wireguard-system
Labels:            app=wireguard
instance=adblock
Annotations:       <none>
Selector:          app=wireguard,instance=adblock
Type:              ClusterIP
IP Family Policy:  SingleStack
IP Families:       IPv4
IP:                <IP_ADDRESS>
IPs:               <IP_ADDRESS>
Port:              metrics  9586/TCP
TargetPort:        9586/TCP
Endpoints:         <none>
Session Affinity:  None
Events:            <none>

P.S: I've noticed these AWS load-balancer annotations, why do these exist, I'm on a self-hosted k8s

They are currently hard-coded in the controller, soon you will be able to specify your own annotations:
https://github.com/jodevsa/wireguard-operator/pull/36

I'm going to close this, as the main branch works and only a new release is required.


Pushalot support

Pushalot service support

Is it ready now?

The only thing that's not yet tested is multiple tokens. I think you can merge it, and if push comes to shove, I'll add a fix.


🐛 BUG: Initializing project with git fails

What version of Wrangler are you using?
2.0.9
What operating system are you using?
WSL Ubuntu 20.04.4
Describe the Bug
When I try to create a new project with git initialization, I get an error as show below.
Git version 2.25.1 (Latest for Ubuntu 20.04.4)
➜ wrangler init testproj
 ⛅ wrangler 2.0.9
-------------------
Using npm as package manager.
✨ Created testproj/wrangler.toml
Would you like to use git to manage this Worker? (y/n)

✘ [ERROR] Command failed with exit code 128: git branch -m main

  error: refname refs/heads/master not found
  fatal: Branch rename failed

If you think this is a bug then please create an issue at https://github.com/cloudflare/wrangler2/issues/new/choose

➜  ~ git --version
git version 2.25.1

➜  cd testproj
➜  git status
On branch master

No commits yet

Untracked files:
  (use "git add <file>..." to include in what will be committed)
        wrangler.toml

nothing added to commit but untracked files present (use "git add" to track)

Thanks for the issue report @cobyge - this is really strange since it is saying that it cannot find the master branch in order to rename it but then it is on the master branch... I'll try to reproduce it myself. Do you know if this happens on other OSes?

I have read over the internet that git branch -m main works only when you have initial commit .( Although this is not the behaviour in my system). Ref : https://stackoverflow.com/questions/66673759/git-branch-m-main
I was wondering instead of moving/renaming the branch by default ( here we are also making assumption that branch is not named as main by default) why don't we tell to create branch main by default when initializing the repo
So instead of
 await execa("git", ["init"], {
    cwd: creationDirectory,
   });

why dont we use
 await execa("git", ["init" ,"-b","main"], {
    cwd: creationDirectory,
   });

and get rid of
 await execa("git", ["branch", "-m", "main"], {
            cwd: creationDirectory,
          });

We recently moved away from init -b main because of a lack of support in older versions of git.
It seems this new approach is not flawless either.
From what I read, as long as we create an initial commit then we would be safe to rename the branch.
This actually seems like a sensible thing to do in any case - i.e. commit the first set up of code generated by wrangler init.

Okay got it.So the idea would be to commit the initial files that get generated likewrangler.toml


Open-source info updates

Status
READY
Description
Integrate CoC, extensions outline, contribution guide updates for open-source, added a github template for documentation.
Impacted Areas in Library
NA
Which issue(s) does this pull-request fix?
Closes: #30
Any special notes for your reviewer?
These are the files added/updated:

Development guide (updated)
Information on open-source extensions (new)
Code of conduct (new)
Main README file includes links to the new resources (updated)
Added a template for documentation to .github

Checklist

[ ] Automated tests exist
[ ] Updated Package Requirements (if required, and with maintainers' approval)
[ ] Local unit tests performed
[X] Documentation exists link
[X] Local pre-commit hooks performed
[X] Desired commit message set as PR title and description set above
[X] Link to relevant GitHub issue provided

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 91.946%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1016

Relevant Lines:
1105

💛  - Coveralls


Pull out common database functions into database utility file

indexer.py
create_schema.py
batch_starter.py: https://github.com/IMAP-Science-Operations-Center/sds-data-manager/pull/191#discussion_r1382110487

The original purpose of this issue was based on database utilities we need from psycopg3, but this doesn't seem necessary now that we're using sqlalchemy


Fully static export

Enable fully static export by adding the property to the configuration object.
module.exports = {
  staticMarkup: true
}

Have in mind that getInitialProps won't be called

What's the reasoning behind this? Can't it be run during export?

Probably I need to be clearer, @sebastiandedey by setting staticMarkup to true, instead of renderToString in the export, it will run renderToStaticMarkup, so if you do client routing, it won't work as expected (running getInitalProps).

So there are a few things that come to mind:

This PR only implements staticMarkup for next export, it should also work in development / production mode
staticMarkup doesn't make it immediately clear what this option does

> Have in mind that `getInitialProps` won't be called and all React bindings won't work. This will be a only html/css export.

Instead of saying getInitialProps won't be called, which is not completely true as we call it on next export, this would probably be a better explanation:

When enabling staticMarkup mode no script tags will be included in the rendered HTML, this is useful when creating a completely static application with no runtime.

@timneutkens that makes sense, let me update the PR.

So there are a few things that come to mind:

This PR only implements staticMarkup for next export, it should also work in development / production mode
staticMarkup doesn't make it immediately clear what this option does

> Have in mind that `getInitialProps` won't be called and all React bindings won't work. This will be a only html/css export.

Instead of saying getInitialProps won't be called, which is not completely true as we call it on next export, this would probably be a better explanation:

When enabling staticMarkup mode no script tags will be included in the rendered HTML, this is useful when creating a completely static application with no runtime.

if only disable getInitialProps call on SSR, the client side still working. how can configure?

@

Enable fully static export by adding the property to the configuration object.
module.exports = {
  staticMarkup: true
}

this useful function is still not working/ok now?

Sure, I'm working on that, HMR breaks as removing some scripts that are not needed when removing React, so I'm still working on solving that issue.
I saw staticMarkup property is under next-server as a flag, do you know that served the same purpose because I don't see any example? @timneutkens

I'm also looking for a feature like this!
For now I've forked next.js only for something that looks a bit like:
https://github.com/zeit/next.js/pull/5102
@timneutkens can you tell me more about your idea ? I'd love to help and make a PR!


AuthorizationHandler.Handle -> HandleRequirementAsync

Change from AuthorizationHandler<T>.Handle to HandleRequirementAsync
https://github.com/aspnet/Security/blob/34ee0212d0c6de76a40609b70df77545dbdde3bf/src/Microsoft.AspNetCore.Authorization/AuthorizationHandler.cs

Hi @antonGritsenko, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, DNFBOT;

@blowdart  approve, deny or comment.

@HaoK  please review

:shipit:

@antonGritsenko  Thanks!


What do we do about Modin?

Remove or make it work and testable?

May I ask, why was it removed?

May I ask, why was Modin removed?

That was over a year ago, when the Fugue framework was not mature. Actually, for now, we are not sure if we should add Modin back, because we may be able to support Ray natively. Modin was buggy and slow at that time (compared to native dask), I don't know if it improves now. @talebzeghmi we would like to understand what you think about this?

I'm not a Modin user, but like the idea of a Modin and Pandas as true statistical DataFrames (as opposed to Spark/Dask), where Modin can be run on a cluster.
I have a few questions:

Does Fugue use Spark Pandas now when running on Spark?
Can Fugue run on Pandas with a sub millisecond overhead (ex: a serving scenario)?

I'm not a Modin user, but like the idea of Modin and Pandas as true statistical DataFrames (as opposed to Spark/Dask), where Modin can be run on a cluster.
I have a few questions:

Does Fugue use Spark Pandas now when running on Spark?
Can Fugue run on Pandas with a sub millisecond overhead (ex: a serving scenario)?

They are very good questions.
Fugue can easily help users leverage Spark Pandas UDF for distributed computing without code change, and this can work on Spark>=2.4. Read this, it is just a single configuration. And yes, when using Pandas UDF, it can be significantly faster.
Philosophically, Fugue doesn't believe Pandas-like interface is a good way to do distributed computing. So to be clear, we are not another pandas-like framework.
And we don't have Spark Pandas (koalas) as a backend. Read this article from dask, who was regarded as the distributed pandas, now they want to differentiate themselves from pandas. I think this is because Pandas was designed with the assumption the compute happens on single machine's memory, so it doesn't have many of the important distributed concepts in their interface, for example, partitioning and persisting.
Being pandas-like, you will have to invent the missing part, but when you invent the missing part, you are not 100% consistent with pandas, interface-wise or behavior-wise, then without strong guarantee of consistency, what is the point of using Pandas interface? To keep the mindset? The mindset is problematic too. For example, pandas always does schema inference for users, but this can cause big perf issue or even correctness issue on a distributed framework. While Dask and Koalas have the interfaces to specify schema, how many pandas users would even care? They just treat it as another pandas.
In my opinion neither the interface nor the mindset of Pandas is good for distributed computing. But of course, this is just what we believe, you can disagree :) In this video, I talked about these in details.
Regarding the second question, No, we haven't got a chance to optimize the latency for serving scenarios. Our overhead is on sub-second level for now. But in the future, we may consider the ultra low latency scenarios, there are definitely things we can do for latency. If you are interested, you are very welcome to join us, and work on this problem (or even other interesting problems).