soc: mimxrt595: Move pin setup to the board level

Pin configuration is board specific and should be moved out of the soc folder to the board level.
Use pm_notifier feature to achieve this.

please describe bits in DT, this looks like a hack in a board c file

@gmarull, not sure what your request is. This is moving code from the soc file to the board file because having it in the SOC file doesn't scale for custom boards.

@gmarull, I have updated to use DTS and the pinctrl api.

@gmarull, @mmahadevan108, @decsny, please join this week's dev review meeting so we can get this PR merged.

the current implementation seems to have conceded that this does not need to happen at every entrance/exit of deepsleep but only once in init to ensure those bits are cleared, but we are doing it through the pinctrl api which as far as I can tell has no guarantee of doing that, and just is happening by luck of the implementation

I won't be able to join dev-review. However, I leave here my questions/requests:

Configuration needs to happen in Devicetree. This doesn't necessarily mean usage of pinctrl or GPIO, just provide enough input to provide feedback. What is the code exactly doing, and for what reason?
Board level code needs a good justification. Is the action specific to the board, ie, depending on the board layout? Isn't this something other boards based on the same SoC will need? Because then, this should be handled by a driver or soc code, no custom board code.

I won't be able to join dev-review. However, I leave here my questions/requests:

Configuration needs to happen in Devicetree. This doesn't necessarily mean usage of pinctrl or GPIO, just provide enough input to provide feedback. What is the code exactly doing, and for what reason?
Board level code needs a good justification. Is the action specific to the board, ie, depending on the board layout? Isn't this something other boards based on the same SoC will need? Because then, this should be handled by a driver or soc code, no custom board code.

This code is indeed board specific and hence moved out of soc.c

@gmarull @decsny @DerekSnell, I have updated this implementation to keep the generic portion inside soc.c. This code uses the information provided from the board level pincrtl file to configure the boot ISP pins.
@MaureenHelm I have created a generic binding for the ISP pins, thank you for this suggestion. This should usable by other NXP SoC's

at this point the changes are so ridiculous

I cannot agree with you here about this and think the suggestions @gmarull has made are sensible, I'm sorry you don't see it the same way.

at this point the changes are so ridiculous

I cannot agree with you here about this and think the suggestions @gmarull has made are sensible, I'm sorry you don't see it the same way.

the reason I say it's ridiculous is because the PR was originally just moving code, and all the nxp platform maintainer agreed on this, and this PR touches nothing except nxp soc/boards.... but now we have all this multilevel init code and new pinctrl binding and dts entries for something as simple as two gpios that just need to be initialized to a certain initial configuration, it's too much.
gpio hog is the exact use of this, so we can use that, I don't disagree with @gmarull that configuration should go in DT, I just think it shouldn't look like this, if we have to do it somehow then it should be as simple as the situation calls for, ie gpio hog, not a whole binding and soc init level created for a momentary state of two gpio pins
@gmarull do you disagree with the idea of representing this in DT as gpio hog node? and removing all this pinctrl stuff

at this point the changes are so ridiculous

I cannot agree with you here about this and think the suggestions @gmarull has made are sensible, I'm sorry you don't see it the same way.

the reason I say it's ridiculous is because the PR was originally just moving code, and all the nxp platform maintainer agreed on this, and this PR touches nothing except nxp soc/boards.... but now we have all this multilevel init code and new pinctrl binding and dts entries for something as simple as two gpios that just need to be initialized to a certain initial configuration, it's too much.

soc/ is plagued with tons of vendor crap, but when there’s an opportunity to improve I think there’s no excuse to not do it. I think my request has been fairly reasonable: keep description in DT. How it’s then used can be discussed.

gpio hog is the exact use of this, so we can use that, I don't disagree with @gmarull that configuration should go in DT, I just think it shouldn't look like this, if we have to do it somehow then it should be as simple as the situation calls for, ie gpio hog, not a whole binding and soc init level created for a momentary state of two gpio pins
@gmarull do you disagree with the idea of representing this in DT as gpio hog node? and removing all this pinctrl stuff

GPIO hogs are a good solution if this is a one-shot configuration. I still miss information to say if it’s the best though, and after all iterations I’m quite confused on what you are really trying to achieve here.

GPIO hogs are a good solution if this is a one-shot configuration. I still miss information to say if it’s the best though, and after all iterations I’m quite confused on what you are really trying to achieve here.

The situation is this: These 3 pins are simply gpios that are read by the rom at boot to determine the boot sequence. The ROM enables the pins' input buffer in order to read them. So far on any RT500 we tested, the ROM disables the input buffer once it is done consuming them. But we had some concern that there may be some chip revision where the ROM doesn't do this for some reason. And since these pins are almost always connected to pull-up/pull-down resistors to select boot configuration, in case this happens then there would be some power leakage, which we want to avoid in the default configuration in zephyr. I actually doubt there is even any chip revision which doesn't do this, and we probably don't need any code at all, because the default value of the pin should be input buffer disabled, but we decided to put this code just to precaution in case these pins are not used by a user application later. In case the user touches these pins at all then they will be responsible for the configuration at that point. Which is why I orginally just want to write these bits directly in the soc init (all we are doing is ensuring the reset value after ROM boot), but if we have to use devicetree to describe this, then I guess a gpio hog is fine. It still seems slightly pointless to me since any user who is ever configuring this pin will overwrite the gpio hog configuration since all it is describing is the reset value state of a pin.
So yes, what we are trying to accomplish right now is a one-shot configuration of one gpio property of one pin, but it's not a special configuration, it's just a precautionary restoration of reset values right after rom boot in init. And this restoration should happen BEFORE any board or app level configuration would overwrite it by using the pin. So even a gpio hog would just kind of be dead weight in a user board definition if they arent using the pin, but it's fine if we have to use DT, it's the lightest approach, other than just writing to the registers their reset value in soc init

GPIO hogs are a good solution if this is a one-shot configuration. I still miss information to say if it’s the best though, and after all iterations I’m quite confused on what you are really trying to achieve here.

The situation is this: These 3 pins are simply gpios that are read by the rom at boot to determine the boot sequence. The ROM enables the pins' input buffer in order to read them. On most chip revisions, ROM disables the input buffer once it is done consuming them, but potentially some chip revisions the ROM doesn't do this. And since these pins are almost always connected to pull-up/pull-down resistors to select boot configuration, this would cause some power leakage, which we want to avoid in the default configuration in zephyr.
So basically we are trying to make sure we restore the reset value of the pin is all. So yes it is a one time configuration. But it is not a special configuration, any user use of the pin would override this "configuration" as once again, it is just the reset value of the pin. I would most prefer to just write these registers during init as I would expect any user that actually uses these pins for something will have a different node in DT describing what it is supposed to do. The functions of this pin are either gpio, ctimer trigger, or spi.
What we are trying to do is restore the reset value where it is just basically a high impedance and does nothing, then I would expect either the ctimer, spi, or gpio driver will be used to initialize the pin to it's actual function at a later time. So that is why my preferred solution is to just write into these registers in the SOC init, since this is only dealing with a potential ROM errata, we're not really trying to configure something.
@gmarull does this info help you to understand the situation better?
And also I should clarify, I am disagreeing with the original intent of the PR to move this to board level, because I think these ISP-designated GPIOs for the ROM are basically always going to be connected to pull-up pull-down, and will probably always have these power leakage problem if the ROM has this errata. So, I don't think it's something we need to burden every customer/user board definition with, and doesn't really belong in board level because once again, we are just trying to restore reset value of the pins as early as possible so that a user is not surprised by this power leakage if they didn't enable the use of the pin in their configuration. What I think this PR should do is remove the code that changes these pin configurations dynamically at any point after the earliest init, because that was wrong and unnecessary and we got some customer complaint about dynamically touching pin configurations at soc level. But having it in the earliest init sequence as a one time write just to restore the reset value in case of ROM errata seems reasonable to me. But calling it a pinctrl configuration and declaring DT for it just seems innaccurate for this situation in my opinion.
If we have to use GPIO hog for this then that will require us to rework our GPIO driver. And we are trying to get this fix into 3.6, so I don't think we want to do that. Again, all we are doing is just restoring reset value, not trying to use the pin for anything. If a user wants to use the pin they will have a different DT description for an actual function of the pin.

From what I understand, this is what I'd suggest:

GPIO hogs are also a good choice, as you can define them only if needed at board level (ie, if your board has a buggy SoC). You just need to make sure that hogs are run before other peripherals use pinctrl (they just run after GPIO driver init, which tipically happens early).
Hardcoding such stuff in SoC is fine, as it doesn't seem to be configurable at all. However, it deserves a good explanation as you've done now, so people can understand what's going on (ie, there's a ROM, it may be buggy, pins may have pulls connected, we need to avoid leakage, etc.)

In any case, all the details you've written now should be stored somewhere, eg commit message.

@gmarull thank you for the suggestion, I put the info in a comment and the commit message, can you review if you think they are sufficiently documented


Feat(web): Introduce UNSTABLE_Avatar component #DS-1323

Description

Additional context

Issue reference

coverage: 77.762%. remained the same
when pulling c5103f9dc8be082490fd082673e58958e7f50c74 on integration/web-unstable-avatar
into 8a6c9850cff93aa093ebd8b2ef80b93f6f0bceea on integration/unstable-avatar.

coverage: 77.762%. remained the same
when pulling bef04cf9704f8c0df437f80ba20911bc0917123d on integration/web-unstable-avatar
into 8a6c9850cff93aa093ebd8b2ef80b93f6f0bceea on integration/unstable-avatar.

coverage: 77.762%. remained the same
when pulling 32dee04f0186a0bfd0ba912473b954adabf779f2 on integration/web-unstable-avatar
into 8a6c9850cff93aa093ebd8b2ef80b93f6f0bceea on integration/unstable-avatar.

coverage: 77.762%. remained the same
when pulling 32dee04f0186a0bfd0ba912473b954adabf779f2 on integration/web-unstable-avatar
into 8a6c9850cff93aa093ebd8b2ef80b93f6f0bceea on integration/unstable-avatar.

coverage: 77.762%. remained the same
when pulling 07a01cfbb53c19671b18a89870f7e24b30eb1d63 on integration/web-unstable-avatar
into 8a6c9850cff93aa093ebd8b2ef80b93f6f0bceea on integration/unstable-avatar.

coverage: 78.687%. remained the same
when pulling e2f50a6e57118f540e3172d76e28e1cbb9cce0af on integration/web-unstable-avatar
into d35239a3f5d9bc4c3e118bed8d33180183bebe61 on main.

coverage: 77.957% (-0.7%) from 78.687%
when pulling 7a2fa03efd30274c29f66299ccb16accb23a36bc on integration/web-unstable-avatar
into d35239a3f5d9bc4c3e118bed8d33180183bebe61 on main.


Publish Docker Images on new releases

@Anmol1696 is using them for testing in the Starship environment, and others may find them useful as well.

I can take this up.
Tasks:

CI to publish docker images to osmosis registry (might need credentials for this)

Optionally we can push this to ghcr.io as a package

We might need a couple of docker images:

Scratch based docker image with Binary
Alpine based image with some more dependencies (used by Starship)

Thanks for adding this task. Happy if somebody moves this forward.
IMHO the meshd app is only a demo app that will not run on production. Therefore focusing on the starship use-case makes sense


Alto home page slider

Hello,
I would like to have a home page slider as shown in the alto page demo. I activated your theme after installing from casper, but the slider does not show with demo data.
Seen here:

Can you please advise me how to make said slider using tags as you did.
Many thanks!

Hey 👋 . The posts in the slider are populated from the featured posts. If you want them to be from a tag, you can play with the filter attribute of the query in partials/featured.hbs partial.
We ask that you please do not use GitHub for support or feature requests 😄. We use GitHub solely for bug-tracking and on-going feature development.
Our forum is a great place to get community support, plus it helps create a central location for searching problems/solutions.
Thanks!

Hey 👋 . The posts in the slider are populated from the featured posts. If you want them to be from a tag, you can play with the filter attribute of the query in partials/featured.hbs partial.
We ask that you please do not use GitHub for support or feature requests 😄. We use GitHub solely for bug-tracking and on-going feature development.
Our forum is a great place to get community support, plus it helps create a central location for searching problems/solutions.
Thanks!


Help needed

Hi!
I've been using your library for a recycler view with a map header. Is there an option for the reclerview to scroll only when touching any element but the header? in order to make the map touchable?
Thanks

Hey \o
I have not tested this solution but I suggest you wrap your mapview around another custom ViewGroup (like a RelativeLayout) which you must extend and override onTouch method.
On that onTouch method you should call:
recycler.requestDisallowInterceptTouchEvent(true); when the action is ACTION_DOWN
and call
recycler.requestDisallowInterceptTouchEvent(false); when the action is ACTION_UP or ACTION_CANCEL


[LMS-288] LMSX Descriptors mapping

Map descriptors to the constants defined in https://techdocs.ed-fi.org/pages/viewpage.action?spaceKey=EDFIODS&title=Data+Model+and+Metrics#DataModelandMetrics-DescriptorMapping

Note: this cannot be merged until after parts of LMS-323 are completed. In the last retrospective, the team discussed creating multiple pull requests for longer tasks, so that we can unblock and/or get immediate benefit from functionally-complete portions of the work. Thus I will look at some commits that can be cherry-picked into this pull request from the LMS-323 branch so that we can merge this on its own.

I've pulled in a few commits for installing the "Engage" collection. The following screenshot shows that the descriptor mapping was successful when running the tool, after installing the LMS Extension tables and uploading the descriptors. ❕ Note: one can install the extension tables and descriptors using the AMT integration test framework in the LMS-Toolkit repository, which is currently a work in progress.


Adding test summary

Description
Adding test summary for perf test.

/ok-to-perf

Dapr perf test
🔗 Link to Action run
Commit ref: 463038b
✅ Build succeeded

Image tag: daprprfd363f18ee9
Test image tag: daprprfd363f18ee9

✅ Infrastructure deployed

Resource group name: Dapr-Perf-daprprfd363f18ee9
Azure region: westus3

❌ Perf tests failed
Please check the logs for details on the error.

what was removed in https://github.com/dapr/dapr/pull/5974/files#diff-e08064235bfd3c357858dfbcb4e9dc9334389be062ee3ede164604e3654a869aL135 has been added back.

related to #5974


Pyright reports an error with named axis

Setup

pyright: 1.1.263
pytorch: 1.12.0+cu113
torchtyping: 0.1.4

Code Example
from torchtyping import TensorType

def example(foo: TensorType["batch"]):
    pass

Problem
Pyright reports the following error: "batch" is not defined
Related issue
The same error is reported by mypy when -1 is omitted: https://github.com/patrick-kidger/torchtyping/issues/35

This is expected. Static type checking is (unfortunately) fundamentally incompatible with annotating arrays.
You should either add the appropriate flag to disable pyright's checking here, or define batch = None elsewhere in the file so that pyright thinks this is a forward reference.

Can we use something like TypeVar (instead of string literal for the type annotation) instead?


duden: 0.18.0 -> 0.19.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for duden is: CLI for http://duden.de dictionary written in Python
meta.homepage for duden is: https://github.com/radomirbosak/duden
meta.changelog for duden is: https://github.com/radomirbosak/duden/blob/refs/tags/0.19.1/CHANGELOG.md
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.19.1 with grep in /nix/store/8yf4ncavf1pm7gjarb0ai9lzrkk4c43r-python3.11-duden-0.19.1
found 0.19.1 in filename of file in /nix/store/8yf4ncavf1pm7gjarb0ai9lzrkk4c43r-python3.11-duden-0.19.1

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
duden

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/8yf4ncavf1pm7gjarb0ai9lzrkk4c43r-python3.11-duden-0.19.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A duden https://github.com/r-ryantm/nixpkgs/archive/e4e164bcf5004568807991537146135a751f3c56.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/e4e164bcf5004568807991537146135a751f3c56#duden

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/8yf4ncavf1pm7gjarb0ai9lzrkk4c43r-python3.11-duden-0.19.1
ls -la /nix/store/8yf4ncavf1pm7gjarb0ai9lzrkk4c43r-python3.11-duden-0.19.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

2 packages built:

duden
duden.dist

Maintainer pings

I want to adopt this. Please do not merge.


XLNet resize embedding size ERROR

❓ Questions & Help
I add new tokens to XLNetLMHeadModel and use resize function
tokenizer.add_tokens(["<token1>", "<token2>"])
model.resize_token_embeddings(len(tokenizer))

But when running, the following error occurs:
Traceback (most recent call last):
 ...
  File "/nas/home/jsun/.local/lib/python3.6/site-packages/torch/nn/modules/module.py", line 493, in __call__
    result = self.forward(*input, **kwargs)
  File "../pytorch_transformers/modeling_xlnet.py", line 1059, in forward
    logits = self.lm_loss(transformer_outputs[0])
  File "/nas/home/jsun/.local/lib/python3.6/site-packages/torch/nn/modules/module.py", line 493, in __call__
    result = self.forward(*input, **kwargs)
  File "/nas/home/jsun/.local/lib/python3.6/site-packages/torch/nn/modules/linear.py", line 92, in forward
    return F.linear(input, self.weight, self.bias)
  File "/nas/home/jsun/.local/lib/python3.6/site-packages/torch/nn/functional.py", line 1410, in linear
    output += bias
RuntimeError: The size of tensor a (32003) must match the size of tensor b (32000) at non-singleton dimension 2

It is because in resize_token_embeddings, it changes the embedding size and calls tie_weight function to resize the LM head weight. But it forgot to change the size of bias, since XLNet has
self.lm_loss = nn.Linear(config.d_model, config.n_token, bias=True)

while other models have bias=False

Should be fixed on master by @LysandreJik's PR!


ISPN-13494 Don't register Elytron's security providers globally

https://issues.redhat.com/browse/ISPN-13494

Some related failures

All related failures are now resolved

integrated! thanks @tristantarrant !

needs PR for 13.0.x


feat(network): add more metrics

What this PR does / why we need it:
New metrics:

current processing message gauge
current processing message gauge by ip
connected peers
ip ping in ms
ip disconnected count
outbound connecting peers
unidentified connection
saved peers
consensus peers gauge
connected consensus peers

Which issue(s) this PR fixes:

Fixes #
Which docs this PR relation:
Ref #
Which toolchain this PR adaption:
No Breaking Change
Special notes for your reviewer:

/lgtm


No Relevant User Found

Are you in the right place?
Yes, My issue is with the initial setup of NPM
Describe the bug
I have a new install of NPM. After logging in as<EMAIL_ADDRESS>/ changeme, I set my new login information.  If I logout at any point I am unable to log back in with my credentials I have just created.
To Reproduce
Steps to reproduce the behavior:

Install fresh NPM
Login with<EMAIL_ADDRESS>/ changeme
Change login information
Logout
Try to log back in with newly changed information
Fail

Expected behavior
Log back in to system
Operating System
UnRaid 6.9.1

Wrong place

Hy, i have the same issue. What did you mean by wrong  place?


Set an anisotropic filter value of 4x

I know I said I was done with changes before the next release, but I was trying to figure out why some of the images had some obvious fuzziness. Setting an anisotropy clamp cleared it up, and from what I can tell this seems to have minimal impact on GPU usage (not surprising since this isn't an image heavy program)
All of these images are from using a window that is one quarter the size of my monitor with a scale of 1.5 since this exacerbates the issue. The second image is portion from the last image in bun's README
Before

After

@LovecraftianHorror Could you try instead switching
            min_filter: wgpu::FilterMode::Nearest,
            mipmap_filter: wgpu::FilterMode::Nearest,

to Linear and testing out whether it fixes the issue for you as well. I think that anisotropic filtering is only really important when viewing things at a weird non perpendicular perspective, like in video games. The issue I think is going on here is that its trying to sample whole pixels instead of blending them when downscaling.

Thanks for the tip (I'm not super familiar with GPU related things)! That looks like it also clears up the image quality. I'll go ahead and push that change instead

Perfect, good spot on that. The images look a lot better now 👍.


Fix automatic updates for apple silicon builds

Follow-up to https://github.com/microsoft/vscode/issues/104780

Automatic updates work now.


Bikeshedding the source keyword

During the 97th TC39 meeting a discussion about bikeshedding the source keyword came up.
@syg has brought up that some folks were confused by the source keyword, expecting it to return unparsed, uncompiled source code.
This keyword represents the second phase of the five stage loading process:

It represents early exiting from the module loader right after the module has been fetched, parsed, (and compiled)
Some alternative keywords that have been suggested:

instantiable
handle
parsed
compiled

You can vote here: https://github.com/tc39/proposal-source-phase-imports/issues/54
Please keep discussion in this issue.
This issue will be collecting feedback on alternative names until 21 Jul 2023 at 00:00 UTC. If no consensus on an alternative name is reached by then, the proposal goes to Stage 3 with the name source.

I can live with parsed or instantiable, but given the general negative feedback to instatiable, parsed seems promising.

My stance:

instantiable: too long and unwieldy. It's not a widely used word and likely to be mistyped frequently, especially by non native speakers.
handle: too generic. A handle could be an asset reflection, a handle on an instantiated module, or anything really.
parsed: easy to type and remember 👍 - but I'm not confident this will be a much better name for folks outside of compiler circles however, because they don't care about how modules are fetched and parsed. Usually the result of parsing is an AST: will users be confused that this does not return an AST (Reflect.parse anyone?)
compiled: also easy to type and remember 👍 - more correct, because at least in the Wasm case you are parsing + compiling to get a WebAssembly.Module. Probably this is exposing too much info about internals though, and will be confusing outside compiler circles. This at least clarifies that the result is not an AST, but a compiled program.

TBH, not super convinced by any of these so far.

What about having one comment per option, that people can 👍 / 👎 ?

@nicolo-ribaudo https://github.com/tc39/proposal-source-phase-imports/issues/54

I don't think this is bike-shedding; misnomers have real world dev-time cost and as a teacher I watch people trip over confusing JavaScript edgecases every day. It doesn't have to be perfect, but theres no going back and JavaScript isn't as simple to learn as it was back when you and I learned it. Good enough is good enough, and I think we can agree the current options are pretty bad for one reason or another.
Just as a sanity check ask if there is a "not" of a modifying keyword

async -> sync (the default)
const -> mutable (the default)
import parsed ... okay? Is the default import not parsed? no? Is there some other kind of import that isn't parsed?
import source. Is there some kind of import-but-without-the-source? Does the default import not import the source? What does that even mean?
Instantiable -> non instantiable makes a bit more sense, but we mostly agree it as a keyword is too unwieldy

Just as a viewpoint, let's name all the stages and see how the 2nd-stage fits-in contextually: I think the following keywords answer "how am I different from the other stages?"
import.resolve // verb (only resolving, not fetching) and its already named
import raw // I would assume bytes
import source // I would assume string
import ast // I would assume parsed but nothing more
import detached // compiled but not attached context
import unlinked // attached
import unevaled // linked

Something like import detached passes the negation test (e.g. "so normal imports are attached?" -> yes/obviously)
So, please consider the options below:
I'm not going to champion one, as I just want any good-enough solution and I think the 4 options above don't make the cut.

import detached <thing> from "source"
compile <thing> from "source" Similar to import.resolve; the verb implies it's "merely" compiled and nothing more
`import binding  from "source"
`import partial  from "source"
`import skeleton  from "source"
Some other alternative!

Is there some kind of import-but-without-the-source? Does the default import not import the source? What does that even mean?

import source gives you a representation of the source of the imported module. The default behavior does not do that, it gives you the result of evaluating the module.

I might suggest: syntax, coming from the Racket programming language. For Racket, syntax data is typically used in macros, but in a wider sense, syntax refers to a rich representation (it includes the source location, such as a URL or file path, along with line and column information) of not-yet-evaluated data, including whole modules.

Is syntax an abstract syntax tree in racket?

@nicolo-ribaudo

the source of the imported module

I think the issue is it doesn't diffentiate from the other steps. E.g. importing as a string (the source code) also qualifies as "representation of the source of a module", and importing the AST is also qualifies as "representing the source of a module". It's like saying import code or import thing in the sense that the term isn't wrong, it's just not distinct enough to mean anything to someone who doesn't pre-know what it's suppose to mean.
I think it also fails the synonym test:
Swapping "const" with a synonym like "frozen" or "fixed" still would make sense.
Swapping "source" with something like "origin" or "root" doesn't make sense (e.g. import origin { thing } from "somthing" ?)

To me “instantiable” seems like the only term so far that directly describes what makes it different, but I can understand why it’s unpopular. Are there other terms that could convey this without resorting to words that are misleadingly over-specific?

instantiable makes sense to me.
Out of topic: I don't like current syntax, I'd like to use it with the import attributes proposal. E.g:
`import Wasm from "./foo.wasm" with { phase: "instantiable" };"

“abstract” suggestion

to +1 on that; googling JavaScript import abstract (or many of the other terms) will likely return relevant results.
Googling JavaScript import source is going to return all kinds of source-map results and irrelevant threads.

It's worth noting here that most JavaScript code will not use import source x from './x.js'.
Rather, the code that does this will be deep in npm libraries that use WebAssembly, that code itself being JS wrapper code generated by WebAssembly tooling.
For JS virtualization users when we support it for JS (as the name intendeds), this will be used for mocking and the construction of virtual sandboxes. Eg, creating a shadow realm, then using a source import to pass the source into that realm and execute it there. In these workflows I think the term source makes complete sense to the developer (an experienced JS developer knowingly doing virtualization work). So I don't think they would be confused by it.
In the rare case where a novice developer sees this it would either be: a) browsing library code (in which case, yes I agree it would likely be confusing until they full grok how it is being used by following the code paths) or b) a Wasm library that instructs usage via the import source mechanism, in which case it would be a blind copy-and-paste.
Semantically we have put a lot of thought to the terminology in use, so there's fair good reason for the usage. So if this is just about learning perhaps the argument is that the novice user simply doesn't need to be concerned about it?

I am actively bored reading the word "descriptor". Truly, I do not hate it. (Maybe this is actually high praise?)

PSA My understanding is that we’re coming close to the deadline for the champions to make a decision of whether to run with source or an alternative. Please review your votes before the deadline lapses. It doesn’t look to me like momentum has gathered around an alternative to source and I’d like to at least give descriptor a fair shake. https://github.com/tc39/proposal-source-phase-imports/issues/54

Is syntax an abstract syntax tree in racket?

Yes, in general it is. It could be a simple string that needs to be parsed later on, but typically it contains an AST.

Thanks everyone for the feedback and discussion. We have unfortunately not found a compelling alternative that has wider support than source, as you can see in #54. As such, we'll be sticking with the import source syntax.


tex: first stab at implementing the TeX box model

Codecov Report

Merging #7 into master will decrease coverage by 28.59%.
The diff coverage is 10.40%.

@@             Coverage Diff             @@
##           master       #7       +/-   ##
===========================================
- Coverage   79.79%   51.20%   -28.60%
===========================================
  Files           6        9        +3
  Lines         782     1330      +548
===========================================
+ Hits          624      681       +57
- Misses        148      638      +490
- Partials       10       11        +1

Impacted Files
Coverage Δ

tex/utf8.go
0.00% <0.00%> (ø)

tex/utils.go
0.00% <0.00%> (ø)

tex/box.go
11.02% <11.02%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72578df...aa4d569. Read the comment docs.


Convert resource attributes to labels in prometheus remote write exporter

Description:
Added missing functionality of converting resource attributes to labels in Prometheus Remote Write Exporter.
Furthermore, this PR merges the ideas of a Prometheus "External Label" with OTLP "Resource Attributes". From my understanding an "external label" is a label customer's can add in Prometheus' global config's, and they are allowed to start with "__" unlike regular labels. Since resource attributes to not appear to have any restrictions for starting with "__", I believe it is safe to merge these concepts.
This solves issue https://github.com/open-telemetry/opentelemetry-collector/issues/1892 because customer's can specify cortex's "cluster" and "__replica__" labels using the resourceprocessor, which would be equivalent to the suggested way to do it on Cortex's website (using external labels: https://cortexmetrics.io/docs/production/ha-pair-handling/)
Also note that this PR is not as long as it seems, a lot of lines are test data
Link to tracking Issue:
https://github.com/open-telemetry/opentelemetry-collector/issues/1892
Testing:
Unit tests have been added, and manual testing by exporting to cortex has shown resource attributes successfully appear as labels with no differences in the metrics graphs, which is expected
Documentation:
No documentation has been added as this was missing, expected functionality

This PR is now obsolete


xdmf to gmsh hiccup

Hi,
Using meshio 1.11.8 I have been able to convert xdmf files to gmsh format for post-processing FEniCS data.  Thank you very much for the fine utility.
However, I needed to filter the generated files with awk to remove the numpy array formatting of the data.  I used the command:
$ meshio-convert --output-format gmsh-ascii mach_number.xdmf mach_number.msh
Then,
$ tail mach_number.msh
produces:
1794 array([1.5010948], dtype=float32)
1795 array([0.41827482], dtype=float32)
1796 array([1.7710645], dtype=float32)
1797 array([0.42079014], dtype=float32)
1798 array([0.79673445], dtype=float32)
1799 array([1.5470289], dtype=float32)
1800 array([0.4292248], dtype=float32)
1801 array([1.5006031], dtype=float32)
1802 array([0.43062833], dtype=float32)
$EndNodeData

Gmsh produces an input error for this file.  After using awk to remove the numpy formatting this becomes:
1794 1.5010948
1795 0.41827482
1796 1.7710645
1797 0.42079014
1798 0.79673445
1799 1.5470289
1800 0.4292248
1801 1.5006031
1802 0.43062833
$EndNodeData

which can then be read by Gmsh.
I can see that xdmf_io.py has a function numpy_to_xml_string but this is only used by the xdmfWriter class.  Could gmsh_io.py use the same function before writing the .msh file?

I need a mesh so I can reproduce the error.

Alright, fixed now. Grad 1.11.11. :tada:


consider moving initialisation to lua

I like the plugin very much. Thanks alot for creating!
Reasons to do:

A pure lua profile would decrease startup time.
The lua startup profiler would be more correct or simpler to get correct with this change. Otherwise one gets more wrong results.
Try to be consistent as to use functionality of lua, if possible.
Having a function to initialize makes separating things for user-specific settings while getting updates much easier (user may implement a different function to customize plugin).

Another related reason (bad practice/historical reasons): nvim-treesitter/module-template#1
Relevant content for change:
https://github.com/nanotee/nvim-lua-guide#using-meta-accessors-1

sorry, this is a treesitter template drawback. will reopen, once that is fixed in the template.


[Bug] error aislado. No descarga y aun figuro como premium en la web.

bueno este problema seria un "bug" aislado supongo, ya que sucede que estoy en el día 31 de mi suscripción premium y aun tengo acceso a seguir viendo anime desde la web, pero el downloader no me deja descargarlos porque tal vez me sigue detectando sin suscripción ya que aun no se a renovado el pago persistente del premium:

comentar eso sí, que anoche como las primeras horas si me dejaba aun sin actualizar, eso si probablemente porque aún no terminaban el ultimo día de sub premium.  Log mode enabled. {   "account_id": 17482651,   "ctp_account_id": "21dca12b-79c3-5842-9de2-beec690a68a5",   "cycle_duration": "P1M",   "next_renewal_date": "2024-08-15T17:19:38-04:00",   "currency_code": "",   "is_active": false,   "tax_included": false,   "subscription_products": [],   "third_party_subscription_products": [     {       "effective_date": "2024-07-13T17:23:47-04:00",       "Source": "google-play",       "source_reference": "pnmgmmahahogmjdbcaancpno.AO-J1OyFB9eNnf-P_maNmhGWZoqGH81QuPBILqmVe6NSLcTRO9gaKWlu147EE8VfdU0IVfWgUSeo03EyqxqhcqM93BWZQkA7f0ZYIL-5KUAVoM3qntuTCVQ",       "Sku": "crunchyroll.google.fanpack.monthly",       "Tier": "fan_pack",       "active_free_trial": false,       "in_grace": true,       "on_hold": false,       "auto_renew": true,       "expiration_date": "0001-01-01T00:00:00",       "in_grace_expiration_date": "2024-08-15T17:19:38-04:00"     }   ],   "nonrecurring_subscription_products": [],   "funimation_subscriptions": [] }

ok so crunchyroll is being stupid because both dates that are relevant are in the past
which means according to crunchyroll your subscription has ended
"next_renewal_date": "2024-08-15T17:19:38-04:00",
"in_grace_expiration_date": "2024-08-15T17:19:38-04:00"
also you don't have to send images from the other downloader working because it most likely doesn't check the subscription with the date so that is why it's working

ok so crunchyroll is being stupid because both dates that are relevant are in the past
which means according to crunchyroll your subscription has ended
"next_renewal_date": "2024-08-15T17:19:38-04:00", "in_grace_expiration_date": "2024-08-15T17:19:38-04:00"
also you don't have to send images from the other downloader working because it most likely doesn't check the subscription with the date so that is why it's working

vale gracias por la aclaración.

try it with the new version v1.5.19

try it with the new version v1.5.19

cool ty

oh! recién me fije y el .xml de los chapters se queda fuera del .mkv

create a new issue with an explanation what you did so that i can try to reproduce it


Perform web search on selected text

Will need a setting to have a default web search engine set. Options will be:

Duck Duck Go
Bing
Google


Assume schema conversion to egglog

Diff:
https://github.com/egraphs-good/eggcc/compare/oflatt-assume-interpreter..oflatt-assume-run-test

close in favor of clean git hist


Prepare for chaining autogenerated conversion methods

Part of #6800
This PR is prerequisite for chaining autogenerated conversion methods. The next steps are:

test checking whether auto-generated code wasn't manually edited
call auto-generated methods one from another [this is easy modulo effective handling of defaulting functions]

@lavalamp @smarterclayton @fgrzadkowski

@lavalamp @smarterclayton
To be clear on calling auto-generated methods one from another. The issue with it is that defaulting functions, are performed on reflections:
https://github.com/GoogleCloudPlatform/kubernetes/blob/master/pkg/conversion/converter.go#L462
So far, I have no idea how to avoid reflections for that, so if you have any suggestions please let me know.

In this change, please add instructions on generation to docs/api_changes.md so that folks needing to add things to the API (@liggitt) have some place to go.

In this change, please add instructions on generation to docs/api_changes.md so that folks needing to add things to the API (@liggitt) have some place to go.
I've started writing this doc and uploaded few lines of it. However, I might not be able to finish it today. So it would be great if you could take a look at the code, before I'm done with the document.

Separate the conversion changes into their own commit so it's easier to review.  We probably want to formalize that in the policy around handling these (always put generations in a separate commit).

Separate the conversion changes into their own commit so it's easier to review. We probably want to formalize that in the policy around handling these (always put generations in a separate commit).
Done

Instead of
	err := newer.Scheme.AddGeneratedConversionFuncs(
		func(in *AWSElasticBlockStoreVolumeSource, out *newer.AWSElasticBlockStoreVolumeSource, s conversion.Scope) error {
			return convertV1beta3AWSElasticBlockStoreVolumeSourceToApiAWSElasticBlockStoreVolumeSource(in, out, s)
		},

do
	err := newer.Scheme.AddGeneratedConversionFuncs(
		convertV1beta3AWSElasticBlockStoreVolumeSourceToApiAWSElasticBlockStoreVolumeSource,

I'm going to improve how the cmd/kube-conversion/conversion.go is used in this PR too (tomorrow), but this won't change the code that is generated. So it would be great if you could look into that. Thanks!

Instead of convertV1beta3AWSElasticBlockStoreVolumeSourceToApiAWSElasticBlockStoreVolumeSource can you do convert_v1beta3_AWSElasticBlockStoreVolumeSource_To_internal_AWSElasticBlockStoreVolumeSource

What's the golang limit on function names?

Instead of convertV1beta3AWSElasticBlockStoreVolumeSourceToApiAWSElasticBlockStoreVolumeSource can you do convert_v1beta3_AWSElasticBlockStoreVolumeSource_To_internal_AWSElasticBlockStoreVolumeSource
I think that names without underscores ale closer to the styleguide (I didn't see any names with underscores anywhere). Why do you want to change this?
All the other comments are applied - PTAL

On Apr 29, 2015, at 4:57 AM, Wojciech Tyczynski<EMAIL_ADDRESS>wrote:
Instead of convertV1beta3AWSElasticBlockStoreVolumeSourceToApiAWSElasticBlockStoreVolumeSource can you do convert_v1beta3_AWSElasticBlockStoreVolumeSource_To_internal_AWSElasticBlockStoreVolumeSource
I think that names without underscores ale closer to the styleguide (I didn't see any names with underscores anywhere). Why do you want to change this?

The style guide really doesn't apply to generated functions.  The fully transformed version is almost unreadable, so the underscores bring it back.
I'd be willing to make an exception in our style guide to improve the readability and scanability of the list.  Also, it preserves the original casing of the names which is probably better.

All the other comments are applied - PTAL
—
Reply to this email directly or view it on GitHub.

The style guide really doesn't apply to generated functions.  The fully transformed version is almost unreadable, so the underscores bring it back.
I'd be willing to make an exception in our style guide to improve the readability and scanability of the list.  Also, it preserves the original casing of the names which is probably better.
I don't fully agree with that, but I see your point. Changed.
PTAL

BTW - I have almost ready the next PR, that is calling those conversion functions one from another without using reflections. That PR gives us another ~75% improvements (which is more than 10x from the original results), but since that new PR depends on this one, I will wait with submitting that one before this one is merged.

One more nag - please alpha sort the conversion function references in
newer.Scheme.AddGeneratedConversionFuncs(
convert_v1beta3_AWSElasticBlockStoreVolumeSource_To_api_AWSElasticBlockStoreVolumeSource,

So you can quickly binary search visually to find them.  Will make it easier to identify missed conversion bugs and diffs.  Best order is a forced order.

One more nag - please alpha sort the conversion function references in
newer.Scheme.AddGeneratedConversionFuncs(
convert_v1beta3_AWSElasticBlockStoreVolumeSource_To_api_AWSElasticBlockStoreVolumeSource,

So you can quickly binary search visually to find them.  Will make it easier to identify missed conversion bugs and diffs.  Best order is a forced order.
Done - PTAL

This is LGTM barring any final review from @lavalamp

Thanks @smarterclayton !

My feedback is that it's not obvious which sections of the file are autogenerated and which aren't (add comments before the functions?) and that maybe you could generate it for v1, too, to keep that in sync?

But I don't think that needs to block the PR.

My feedback is that it's not obvious which sections of the file are autogenerated and which aren't (add comments before the functions?)
I definitely agree with it - tomorrow I will be working on the test whether the generated code wasn't manually edited and I will add it as part of it.

and that maybe you could generate it for v1, too, to keep that in sync?
Can I do it in a separate PR?

But I don't think that needs to block the PR.
If you're fine with merging as is, that would be great. I will address your two comments in a separate PR tomorrow.


Extract duplicated code from MD and classic TextFieldViews

There's a lot of duplicated code, or duplicated semantics with different code. The MD version's use of a DomValue, softData, and data is probably the best style, rather than the classic version's data and DomValue.

Superseded by U2 Input models. They're much smaller, but still have some duplication, so maybe a trait is in order?

I'm still playing with the equivalent U2 design.  Currently there are two forms of input for on/off keyMode.  But I want to combine these either with a mode, data+softData, or some other way.


Cleanup test running files

Codecov Report

Merging #419 into master will increase coverage by 0.12%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #419      +/-   ##
==========================================
+ Coverage   96.05%   96.17%   +0.12%
==========================================
  Files          34       34
  Lines       10707    11333     +626
==========================================
+ Hits        10284    10899     +615
- Misses        423      434      +11


Level meter for input

There's a level meter for the output. It'd be good to get one for the input as well.

Work is done, need review on Windows before PR.


Make epoch models save frequency configurable

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@5016893). Click here to learn what that means.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master     #262   +/-   ##
=========================================
  Coverage          ?   76.89%
=========================================
  Files             ?       66
  Lines             ?     5329
  Branches          ?        0
=========================================
  Hits              ?     4098
  Misses            ?     1231
  Partials          ?        0

Impacted Files
Coverage Δ

onmt/train/Trainer.lua
68.14% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5016893...b452439. Read the comment docs.


Icon request: Local Monero

URL of the site or app (required): Local Monero
Logo resources for the icon (optional, but recommended): Logo

My problem is with the logo: it's almost exactly the same as Monero currency icon. Only major difference is background color.
I would rather make a generic icon for Monero.

I made generic icon for Monero.
https://github.com/krisu5/aegis-icons/blob/master/PNG/Generic/Monero.png


Xcode 14.5 Beta (iOS 14.5) gets abort 6 when building

Description
<unknown>:0: error: fatal error encountered while reading from module 'lottie_react_native'; please submit a bug report (https://swift.org/contributing/#reporting-bugs) and include the project
<unknown>:0: note: module 'lottie_react_native' full misc version is '5.4(5.4)/Apple Swift version 5.4 (swiftlang-1<IP_ADDRESS> clang-1<IP_ADDRESS>)'

*** DESERIALIZATION FAILURE (please include this section in any bug report) ***
could not deserialize type for 'ContainerView': top-level value not found
Cross-reference to module 'lottie_react_native'
... RCTView

Please submit a bug report (https://swift.org/contributing/#reporting-bugs) and include the project and the crash backtrace.
Stack dump:
0.	Program arguments: /Applications/Xcode_12.5_beta.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/swift-frontend -frontend -merge-modules -emit-module /Users/.../Build/Intermediates.noindex/Pods.build/Debug-iphoneos/lottie-react-native.build/Objects-normal/arm64/AnimationViewManagerModule~partial.swiftmodule /Users/.../Build/Intermediates.noindex/Pods.build/Debug-iphoneos/lottie-react-native.build/Objects-normal/arm64/ContainerView~partial.swiftmodule -parse-as-library -disable-diagnostic-passes -disable-sil-perf-optzns -target arm64-apple-ios9.0 -Xllvm -aarch64-use-tbi -enable-objc-interop -sdk /Applications/Xcode_12.5_beta.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS14.5.sdk -I /Users/.../Build/Products/Debug-iphoneos/lottie-react-native -I /Users/.../Build/Products/Debug-iphoneos/lottie-ios -F /Users/.../Build/Products/Debug-iphoneos/lottie-react-native -enable-testing -g -import-underlying-module -module-cache-path /Users/.../build/ModuleCache.noindex -swift-version 5 -enforce-exclusivity=checked -Onone -D DEBUG -D COCOAPODS -serialize-debugging-options -Xcc -working-directory -Xcc /Users/.../Pods -enable-anonymous-context-mangled-names -Xcc -fmodule-map-file=/Users/.../Build/Products/Debug-iphoneos/lottie-ios/Lottie.modulemap -Xcc -fmodule-map-file=/Users/.../Pods/Headers/Public/React/React-Core.modulemap -Xcc -fmodule-map-file=/Users/.../Pods/Headers/Public/jsi/React-jsi.modulemap -Xcc -fmodule-map-file=/Users/.../Pods/Headers/Public/yoga/Yoga.modulemap -Xcc -fmodule-map-file=/Users/.../Pods/Headers/Public/lottie_react_native/lottie-react-native.modulemap -Xcc -I/Users/.../Build/Intermediates.noindex/Pods.build/Debug-iphoneos/lottie-react-native.build/swift-overrides.hmap -Xcc -iquote -Xcc /Users/.../Build/Intermediates.noindex/Pods.build/Debug-iphoneos/lottie-react-native.build/lottie-react-native-generated-files.hmap -Xcc -I/Users/.../Build/Intermediates.noindex/Pods.build/Debug-iphoneos/lottie-react-native.build/lottie-react-native-own-target-headers.hmap -Xcc -I/Users/.../Build/Intermediates.noindex/Pods.build/Debug-iphoneos/lottie-react-native.build/lottie-react-native-all-non-framework-target-headers.hmap -Xcc -ivfsoverlay -Xcc /Users/.../Build/Intermediates.noindex/Pods.build/Debug-iphoneos/lottie-react-native.build/all-product-headers.yaml -Xcc -iquote -Xcc /Users/.../Build/Intermediates.noindex/Pods.build/Debug-iphoneos/lottie-react-native.build/lottie-react-native-project-headers.hmap -Xcc -I/Users/.../Build/Products/Debug-iphoneos/lottie-react-native/include -Xcc -I/Users/.../Pods/Headers/Private -Xcc -I/Users/.../Pods/Headers/Private/lottie-react-native -Xcc -I/Users/.../Pods/Headers/Public -Xcc -I/Users/.../Pods/Headers/Public/DoubleConversion -Xcc -I/Users/.../Pods/Headers/Public/FBLazyVector -Xcc -I/Users/.../Pods/Headers/Public/FBReactNativeSpec -Xcc -I/Users/.../Pods/Headers/Public/RCTRequired -Xcc -I/Users/.../Pods/Headers/Public/RCTTypeSafety -Xcc -I/Users/.../Pods/Headers/Public/React-Core -Xcc -I/Users/.../Pods/Headers/Public/React-RCTText -Xcc -I/Users/.../Pods/Headers/Public/React-callinvoker -Xcc -I/Users/.../Pods/Headers/Public/React-cxxreact -Xcc -I/Users/.../Pods/Headers/Public/React-jsi -Xcc -I/Users/.../Pods/Headers/Public/React-jsiexecutor -Xcc -I/Users/.../Pods/Headers/Public/React-jsinspector -Xcc -I/Users/.../Pods/Headers/Public/ReactCommon -Xcc -I/Users/.../Pods/Headers/Public/Yoga -Xcc -I/Users/.../Pods/Headers/Public/glog -Xcc -I/Users/.../Build/Intermediates.noindex/Pods.build/Debug-iphoneos/lottie-react-native.build/DerivedSources-normal/arm64 -Xcc -I/Users/.../Build/Intermediates.noindex/Pods.build/Debug-iphoneos/lottie-react-native.build/DerivedSources/arm64 -Xcc -I/Users/.../Build/Intermediates.noindex/Pods.build/Debug-iphoneos/lottie-react-native.build/DerivedSources -Xcc -DPOD_CONFIGURATION_DEBUG=1 -Xcc -DDEBUG=1 -Xcc -DCOCOAPODS=1 -target-sdk-version 14.5 -emit-module-doc-path /Users/.../Build/Intermediates.noindex/Pods.build/Debug-iphoneos/lottie-react-native.build/Objects-normal/arm64/lottie_react_native.swiftdoc -emit-module-source-info-path /Users/.../Build/Intermediates.noindex/Pods.build/Debug-iphoneos/lottie-react-native.build/Objects-normal/arm64/lottie_react_native.swiftsourceinfo -emit-objc-header-path /Users/.../Build/Intermediates.noindex/Pods.build/Debug-iphoneos/lottie-react-native.build/Objects-normal/arm64/lottie_react_native-Swift.h -module-name lottie_react_native -o /Users/.../Build/Intermediates.noindex/Pods.build/Debug-iphoneos/lottie-react-native.build/Objects-normal/arm64/lottie_react_native.swiftmodule
1.	Apple Swift version 5.4 (swiftlang-1<IP_ADDRESS> clang-1<IP_ADDRESS>)
2.	While evaluating request ASTLoweringRequest(Lowering AST to SIL for module lottie_react_native)
0  swift-frontend           0x0000000114d600f5 llvm::sys::PrintStackTrace(llvm::raw_ostream&) + 37
1  swift-frontend           0x0000000114d5f0e8 llvm::sys::RunSignalHandlers() + 248
2  swift-frontend           0x0000000114d606b6 SignalHandler(int) + 262
3  libsystem_platform.dylib 0x00007fff204bcd7d _sigtramp + 29
4  libsystem_platform.dylib 0x00007fee728a4600 _sigtramp +<PHONE_NUMBER>2074933408
5  libsystem_c.dylib        0x00007fff203cb720 abort + 120
6  swift-frontend           0x0000000110ace644 swift::ModuleFileSharedCore::fatal(llvm::Error) + 100
7  swift-frontend           0x0000000110a53e08 swift::ModuleFile::fatal(llvm::Error) + 2600
8  swift-frontend           0x0000000110ab7ae4 swift::SILDeserializer::readVTable(llvm::PointerEmbeddedInt<unsigned int, 31>) + 2532
9  swift-frontend           0x0000000110b3c48b swift::SILDeserializer::getAll(bool) + 107
10 swift-frontend           0x000000011041c623 swift::ASTLoweringRequest::evaluate(swift::Evaluator&, swift::ASTLoweringDescriptor) const + 10899
11 swift-frontend           0x000000011052879d swift::SimpleRequest<swift::ASTLoweringRequest, std::__1::unique_ptr<swift::SILModule, std::__1::default_delete<swift::SILModule> > (swift::ASTLoweringDescriptor), (swift::RequestFlags)9>::evaluateRequest(swift::ASTLoweringRequest const&, swift::Evaluator&) + 205
12 swift-frontend           0x000000011042073c llvm::Expected<swift::ASTLoweringRequest::OutputType> swift::Evaluator::getResultUncached<swift::ASTLoweringRequest>(swift::ASTLoweringRequest const&) + 780
13 swift-frontend           0x000000011041cfcf swift::performASTLowering(swift::ModuleDecl*, swift::Lowering::TypeConverter&, swift::SILOptions const&) + 143
14 swift-frontend           0x000000010ff8a05e swift::performFrontend(llvm::ArrayRef<char const*>, char const*, void*, swift::FrontendObserver*) + 7150
15 swift-frontend           0x000000010ff102c2 main + 1266
16 libdyld.dylib            0x00007fff20493621 start + 1
17 libdyld.dylib            0x0000000000000083 start +<PHONE_NUMBER>9974494819
error: Abort trap: 6 (in target 'lottie-react-native' from project 'Pods')

Steps to Reproduce

Get XCode 14.5 beta
Update lottie to

    "lottie-ios": "3.1.8",
    "lottie-react-native": "^3.5.0",

npx pod-install
try to build

Versions
  npm: '6.11.3',
  ares: '1.15.0',
  brotli: '1.0.7',
  cldr: '35.1',
  http_parser: '2.8.0',
  icu: '64.2',
  llhttp: '1.1.4',
  modules: '72',
  napi: '5',
  nghttp2: '1.39.2',
  node: '12.12.0',
  openssl: '1.1.1d',
  tz: '2019a',
  unicode: '12.1',
  uv: '1.32.0',
  v8: '7.7.299.13-node.12',
  zlib: '1.2.11'

I have the same issue, this helped https://github.com/lottie-react-native/lottie-react-native/issues/708#issuecomment-775175081

We've faced the same issue. Any help, update here?

Same issue

I have Xcode 12.5 beta 3, once I installed lottie-react-native and lottie-ios they both worked well on Android, but when building on xcode I got this error:
error: Abort trap: 6 (in target 'lottie-react-native' from project 'Pods')
npm: '7.9.0',
node: 'v14.16.1'

v4.0.0 is just released. It contains three large changes:

Fix react-native 0.64 compatibility
Windows support [C#]
macOS Support (based on react-native-windows)

So I would really appreciate if you guys could help me testing it and creating any issues you might find.

Same trouble

I'm working with tvOS target as well, but new version says it's not compatible with tvOS upon trying to pod install. Any solution?

v4.0.0 is just released. It contains three large changes:

Fix react-native 0.64 compatibility
Windows support [C#]
macOS Support (based on react-native-windows)

So I would really appreciate if you guys could help me testing it and creating any issues you might find.

Getting error as
could not deserialize type for 'ContainerView': top-level value not found
Cross-reference to module 'lottie_react_native'

Package versions are:
"lottie-ios": "3.1.8",
"lottie-react-native": "^4.0.3",

I have the same problem

v4.0.0 is just released. It contains three large changes:

Fix react-native 0.64 compatibility
Windows support [C#]
macOS Support (based on react-native-windows)

So I would really appreciate if you guys could help me testing it and creating any issues you might find.

what is the lottie-ios version i need to use to be compatible with lottie-react-native V4.0.0? i had gotten error "CocoaPods could not find compatible versions for pod "lottie-react-native"..." when  i use set   lottie-ios :"3.1.8" and lottie-react-native:"4.0.0"

Try lottie-react-native 4.1.3 and lottie-ios 3.2.3

Try lottie-react-native 4.1.3 and lottie-ios 3.2.3

@emilioicai  tks for your quick response, but i still get error when running pod install with 2 versions.

Maybe you still got the old versions installed. Can you try removing the ios/Pods folder and ios/Podfile.lock ? then try running pod install again

Maybe you still got the old versions installed. Can you try removing the ios/Pods folder and ios/Podfile.lock ? then try running pod install again

by the way using command
"rm -rf node_modules package-lock.json && npm install && cd ios && rm -rf Pods Podfile.lock && pod install && cd .."
i think I've removed them success before pod install. But i will try some way to remove cache. Tks for your help

Yeah, looks like you removed them correctly. I will also investigate on my side

Yeah, looks like you removed them correctly. I will also investigate on my side
@emilioicai
I've just created a new Project RN 0.64 and install lottie
npm i --save lottie-react-native && npm i --save<EMAIL_ADDRESS>And i get  this version in package.json
"lottie-ios": "^3.2.3"
"lottie-react-native": "^4.1.3",
But i run pod install and I'm still getting error:

[!] CocoaPods could not find compatible versions for pod "lottie-react-native":
In Podfile:
lottie-react-native (from ../node_modules/lottie-react-native)
Specs satisfying the lottie-react-native (from ../node_modules/lottie-react-native) dependency were found, but they required a higher minimum deployment target.

thanks @caolong0204 I think the issue might be RN 64 minimum deployment target is iOS 10 while RN 65 has iOS 11 as minimum deployment target. I guess we need separate versions for RN 64 and RN 65


Integrate Husky pre-commit and pre-push hooks

-https://typicode.github.io/husky/#/

Hi Harshith, can you assign this issue to me?

@harshith-venkatesh I have worked on this issue in  #21 but had not got it assigned.
If its fine, can I take it up.


Support email address with plus addressing as username

Please add support for email addresses with plus addressing like<EMAIL_ADDRESS>Currenty jamfcpr reports that the credentials are invalid.

The account works fine generating a token using the web console?

Yes.

Thanks for the added info.  It’s odd as they should all be using the same authentication method.  I’ll have to do some digging.


Refactor the content script to different modules and use react components instead

closed with https://github.com/RichmondCroft/dyslens/pull/57


Remove pluginmanager fixture in favor of devtools

Description
Reverts #2247 and #2251
Following this conversation on zulip, where we decided these would be a better fit in napari/napari-plugin-devtools .

Type of change

[ ] Bug-fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

References

How has this been tested?

[ ] example: the test suite for my feature covers cases x, y, and z
[ ] example: all tests pass with my change

Final checklist:

[ ] My PR is the minimum possible work for the desired functionality
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works

Note this code was never released, so doesn't need a deprecation. Looks good to me. I'm very excited about this stuff, will be great to have it in https://github.com/napari/napari-plugin-devtools


Picovoice Console Issue:

I don't see why I have reached the user limit 3/users on my account but I am the only user. Is it because I have downloaded my access code multiple times? If that is the case can my account be reset and I will save the access code.

Initializing engines on different devices will activate new users. Unfortunately, per our Terms of Use your AccessKey cannot be reset. You'll need to wait 30 days for your limits to reset.

Thank you. Now I understand.

From: Albert Ho @.>
Sent: Tuesday, September 10, 2024 7:12 PM
To: Picovoice/picovoice @.>
Cc: tmccaffr100 @.>; Author @.>
Subject: Re: [Picovoice/picovoice] Picovoice Console Issue: (Issue #853)
Initializing engines on different devices will activate new users. Unfortunately, per our Terms of Usehttps://picovoice.ai/docs/terms-of-use/ your AccessKey cannot be reset. You'll need to wait 30 days for your limits to reset.
—
Reply to this email directly, view it on GitHubhttps://github.com/Picovoice/picovoice/issues/853#issuecomment-2342318511, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AQRVPCZBOQYW4HDY6332BWDZV54GBAVCNFSM6AAAAABN7TLQXWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNBSGMYTQNJRGE.
You are receiving this because you authored the thread.Message ID: @.***>


Import functions directly or wrap them inside a module ?

@boussadjra , I need your opinion about exporting each function like in the example provided in README.
Or export an Object that lets the developers call the functions inside it.
In React we have the two options :
import React from "react"
React.createElement()

and
import {useEffect} from "react"
const effect = useEffect();

JS has a functional and OOP ( recently ) paradigm so I could get exactly the decision behind each architecture.
In Java, I was doing this by defining the static functions, factory functions, and instantiated functions... The concept was clean but JS behavior confuses me.
What's your opinion?

I think the best way is to give the developer  two choices, you give it a global object like _ of lodash then he will use it _.sum(array) or he could also import each function between curly brackets like import {sum} from 'arrow', i see that the most modern js libraries do that.

What's your opinion about exporting a global variable Arrow like React that contains all modules.
Or should each feature ( folder of modules ) be a global object such as Has, Math..

I suggest to to export both a global variable Arrow and give the developer the possibility to import each function like we do with react hooks , the syntax should be like import Array, {sum,multiply, has} from 'arrow', the function names should be written in camel case format.


[relay][frontend] aten::copy_ support for pytorch

Although #9375 has been rejected, I tried a different way to support aten::copy_ op.
aten::copy_ behaves differently from other inplace ops, "pure inplace" way, unlike other inplace nodes' one, which output graph(torch.Graph) still relaying it's output to users so that a DAG can be structed. However, aten::copy_ op returns itself, which dangles all of mutations.
For example, a torch module like
class Test(torch.nn.Module):
    def __init__(self) -> None:
        super().__init__()

    def forward(self, x: torch.Tensor):
        x[:5, :5] = x[:5, :5] + 1
        return x

generates the graph
graph(%self : __torch__.Test,
      %x : Float(10, 10, strides=[10, 1], requires_grad=0, device=cpu)):
  %4 : int = prim::Constant[value=0]() # /home/jhlee/tvm/test.py:10:0
  %5 : int = prim::Constant[value=0]() # /home/jhlee/tvm/test.py:10:0
  %6 : int = prim::Constant[value=5]() # /home/jhlee/tvm/test.py:10:0
  %7 : int = prim::Constant[value=1]() # /home/jhlee/tvm/test.py:10:0
  %8 : Float(5, 10, strides=[10, 1], requires_grad=0, device=cpu) = aten::slice(%x, %4, %5, %6, %7)
  %9 : int = prim::Constant[value=1]() # /home/jhlee/tvm/test.py:10:0
  %10 : int = prim::Constant[value=0]() # /home/jhlee/tvm/test.py:10:0
  %11 : int = prim::Constant[value=5]() # /home/jhlee/tvm/test.py:10:0
  %12 : int = prim::Constant[value=1]() # /home/jhlee/tvm/test.py:10:0
  %13 : Float(5, 5, strides=[10, 1], requires_grad=0, device=cpu) = aten::slice(%8, %9, %10, %11, %12)
  %14 : Long(requires_grad=0, device=cpu) = prim::Constant[value={1}]()
  %15 : int = prim::Constant[value=1]() # /home/jhlee/tvm/test.py:10:0
  %16 : Float(5, 5, strides=[5, 1], requires_grad=0, device=cpu) = aten::add(%13, %14, %15)
  %17 : int = prim::Constant[value=0]() # /home/jhlee/tvm/test.py:10:0
  %18 : int = prim::Constant[value=0]() # /home/jhlee/tvm/test.py:10:0
  %19 : int = prim::Constant[value=5]() # /home/jhlee/tvm/test.py:10:0
  %20 : int = prim::Constant[value=1]() # /home/jhlee/tvm/test.py:10:0
  %21 : Float(5, 10, strides=[10, 1], requires_grad=0, device=cpu) = aten::slice(%x, %17, %18, %19, %20)
  %22 : int = prim::Constant[value=1]() # /home/jhlee/tvm/test.py:10:0
  %23 : int = prim::Constant[value=0]() # /home/jhlee/tvm/test.py:10:0
  %24 : int = prim::Constant[value=5]() # /home/jhlee/tvm/test.py:10:0
  %25 : int = prim::Constant[value=1]() # /home/jhlee/tvm/test.py:10:0
  %26 : Float(5, 5, strides=[10, 1], requires_grad=0, device=cpu) = aten::slice(%21, %22, %23, %24, %25)
  %27 : bool = prim::Constant[value=0]()
  %28 : Float(5, 5, strides=[10, 1], requires_grad=0, device=cpu) = aten::copy_(%26, %16, %27)
  return (%x)

which returns %x itself.
My approach to handle this problem is:

in from_pytorch, insert a pass that redirects output of aten::copy_(_redirect_inplace_output), after _run_jit_passes is called, in torch level(torch.Graph)
when handling aten::copy node, we collect from it's parents to collect aten::select and aten::slice nodes, to generate indices of source. I referenced pytorch repository, behavior of torch -> onnx conversion

I'm not familiar with making a PR to this repository, so please let me know if there is any feedbacks or questions.

Is this PR can be merged to main, in regards to design of relay architecture?
The test seems failed in CI server, but it is hard to know what the problem is. In my local, my test case passes without any fault. I tried to figure out what was happened in CI server, but it seems the log doesn't show enough message. Probably it's segmentation fault. Could anybody give me an advice to handle this problem?

@masahi

You've got a segfault from your test.

@masahi It's ready for review. Sorry for late response.


Import patients zip file API via  POST- /admin/patients is not working

Hi,
I am testing POST- /admin/patients API using postman. I am passing below parameters as form data. If

file - patient's zip file containing CDA XML file
practice_id - Provider's ID
practice_name - Provider Name

It is throwing below error.
Started POST "/api/admin/patients/" for <IP_ADDRESS> at 2019-09-25 08:57:28 -0400
Processing by Api::Admin::PatientsController#create as /
Can't verify CSRF token authenticity
Completed 500 Internal Server Error in 453ms
NoMethodError (undefined method read' for nil:NilClass):   app/controllers/api/admin/patients_controller.rb:47:in block in create'
app/controllers/api/admin/patients_controller.rb:47:in open'   app/controllers/api/admin/patients_controller.rb:47:in create'
However, when I try same zip file from popHealth UI it is working as expected and imported the patient. It increments the patients count and verify the same in MongoDB database in 'records' collection also.
Please look into it and suggest way forward as API is not working.
Thanks and regards,
Shardul

Hi Shardul,
Please check out this documentation - https://github.com/OSEHRA/popHealth/wiki/Getting-Started-with-popHealth-API
Make sure the enable_csrf_for_apis: false in the popHealth.yml file.
Peter
From: shardulbanker<EMAIL_ADDRESS>Sent: Wednesday, September 25, 2019 9:10 AM
To: OSEHRA/popHealth<EMAIL_ADDRESS>Cc: Subscribed<EMAIL_ADDRESS>Subject: [OSEHRA/popHealth] Import patients zip file API via POST- /admin/patients is not working (#180)
Hi,
I am testing POST- /admin/patients API using postman. I am passing below parameters as form data. If

file - patient's zip file containing CDA XML file
practice_id - Provider's ID
practice_name - Provider Name

It is throwing below error.
Started POST "/api/admin/patients/" for <IP_ADDRESS> at 2019-09-25 08:57:28 -0400
Processing by Api::Admin::PatientsController#create as /
Can't verify CSRF token authenticity
Completed 500 Internal Server Error in 453ms
NoMethodError (undefined method read' for nil:NilClass): app/controllers/api/admin/patients_controller.rb:47:in block in create'
app/controllers/api/admin/patients_controller.rb:47:in open' app/controllers/api/admin/patients_controller.rb:47:in create'
However, when I try same zip file from popHealth UI it is working as expected and imported the patient. It increments the patients count and verify the same in MongoDB database in 'records' collection also.
Please look into it and suggest way forward as API is not working.
Thanks and regards,
Shardul
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/OSEHRA/popHealth/issues/180?email_source=notifications&email_token=AAMCG3L4OKNRYFDYORXUZ5LQLNPLJA5CNFSM4I2MTBCKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HNTDGTA , or mute the thread https://github.com/notifications/unsubscribe-auth/AAMCG3JKV4W2P7MV6R4F6ZDQLNPLJANCNFSM4I2MTBCA .

Hi Shardul, Please check out this documentation - https://github.com/OSEHRA/popHealth/wiki/Getting-Started-with-popHealth-API Make sure the enable_csrf_for_apis: false in the popHealth.yml file. Peter From: shardulbanker<EMAIL_ADDRESS>Sent: Wednesday, September 25, 2019 9:10 AM To: OSEHRA/popHealth<EMAIL_ADDRESS>Cc: Subscribed<EMAIL_ADDRESS>Subject: [OSEHRA/popHealth] Import patients zip file API via POST- /admin/patients is not working (#180) Hi, I am testing POST- /admin/patients API using postman. I am passing below parameters as form data. If 1. file - patient's zip file containing CDA XML file 2. practice_id - Provider's ID 3. practice_name - Provider Name It is throwing below error. Started POST "/api/admin/patients/" for <IP_ADDRESS> at 2019-09-25 08:57:28 -0400 Processing by Api::Admin::PatientsController#create as / Can't verify CSRF token authenticity Completed 500 Internal Server Error in 453ms NoMethodError (undefined method read' for nil:NilClass): app/controllers/api/admin/patients_controller.rb:47:in block in create' app/controllers/api/admin/patients_controller.rb:47:in open' app/controllers/api/admin/patients_controller.rb:47:in create' However, when I try same zip file from popHealth UI it is working as expected and imported the patient. It increments the patients count and verify the same in MongoDB database in 'records' collection also. Please look into it and suggest way forward as API is not working. Thanks and regards, Shardul — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#180?email_source=notifications&email_token=AAMCG3L4OKNRYFDYORXUZ5LQLNPLJA5CNFSM4I2MTBCKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HNTDGTA> , or mute the thread https://github.com/notifications/unsubscribe-auth/AAMCG3JKV4W2P7MV6R4F6ZDQLNPLJANCNFSM4I2MTBCA .

Thanks for the update. This already know and went through that guide also earlier.
This error is just for logging purpose, it doesn't cause an issue. Actual issue is about below error...
NoMethodError (undefined method read' for nil:NilClass): app/controllers/api/admin/patients_controller.rb:47
This error throws at line no. which is highlighted in bold color in sample code snippet.

 api :POST, "/admin/patients", "Upload a zip file of patients."
  param :file, nil, :desc => 'The zip file of patients to upload.', :required => true
  param :practice_id, String, :desc => "ID for the patient's Practice", :required => false
  param :practice_name, String, :desc => "Name for the patient's Practice", :required => false

  def create
    log_admin_api_call LogAction::ADD, "Upload patient ZIP file", true
    **file = params[:file]**

Do we have any fix available for this issue? Can you please help me currently with any work around so that I can continue with importing patient via API? I am currently stuck and not able to import patient from our EHR application.
Thanks and regards,
Shardul

Hi Shardul,
Just checking – you are using version 6, correct?
Thanks.
Peter
From: shardulbanker<EMAIL_ADDRESS>Sent: Wednesday, September 25, 2019 10:44 AM
To: OSEHRA/popHealth<EMAIL_ADDRESS>Cc: peter li<EMAIL_ADDRESS>Comment<EMAIL_ADDRESS>Subject: Re: [OSEHRA/popHealth] Import patients zip file API via POST- /admin/patients is not working (#180)
Hi Shardul, Please check out this documentation - https://github.com/OSEHRA/popHealth/wiki/Getting-Started-with-popHealth-API Make sure the enable_csrf_for_apis: false in the popHealth.yml file. Peter From: shardulbanker<EMAIL_ADDRESS><EMAIL_ADDRESS>Sent: Wednesday, September 25, 2019 9:10 AM To: OSEHRA/popHealth<EMAIL_ADDRESS><EMAIL_ADDRESS>Cc: Subscribed<EMAIL_ADDRESS><EMAIL_ADDRESS>Subject: [OSEHRA/popHealth] Import patients zip file API via POST- /admin/patients is not working (#180 https://github.com/OSEHRA/popHealth/issues/180 ) Hi, I am testing POST- /admin/patients API using postman. I am passing below parameters as form data. If 1. file - patient's zip file containing CDA XML file 2. practice_id - Provider's ID 3. practice_name - Provider Name It is throwing below error. Started POST "/api/admin/patients/" for <IP_ADDRESS> at 2019-09-25 08:57:28 -0400 Processing by Api::Admin::PatientsController#create as / Can't verify CSRF token authenticity Completed 500 Internal Server Error in 453ms NoMethodError (undefined method read' for nil:NilClass): app/controllers/api/admin/patients_controller.rb:47:in block in create' app/controllers/api/admin/patients_controller.rb:47:in open' app/controllers/api/admin/patients_controller.rb:47:in create' However, when I try same zip file from popHealth UI it is working as expected and imported the patient. It increments the patients count and verify the same in MongoDB database in 'records' collection also. Please look into it and suggest way forward as API is not working. Thanks and regards, Shardul — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#180 https://github.com/OSEHRA/popHealth/issues/180 ?email_source=notifications&email_token=AAMCG3L4OKNRYFDYORXUZ5LQLNPLJA5CNFSM4I2MTBCKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HNTDGTA> , or mute the thread https://github.com/notifications/unsubscribe-auth/AAMCG3JKV4W2P7MV6R4F6ZDQLNPLJANCNFSM4I2MTBCA .
Thanks for the update. This already know and went through that guide also earlier.
This error is just for logging purpose, it doesn't cause an issue. Actual issue is about below error...
NoMethodError (undefined method read' for nil:NilClass): app/controllers/api/admin/patients_controller.rb:47
This error throws at line no. which is highlighted in bold color in sample code snippet.

api :POST, "/admin/patients", "Upload a zip file of patients."
param :file, nil, :desc => 'The zip file of patients to upload.', :required => true
param :practice_id, String, :desc => "ID for the patient's Practice", :required => false
param :practice_name, String, :desc => "Name for the patient's Practice", :required => false
def create
log_admin_api_call LogAction::ADD, "Upload patient ZIP file", true

**file = params[:file]**

Do we have any fix available for this issue? Can you please help me currently with any work around so that I can continue with importing patient via API? I am currently stuck and not able to import patient from our EHR application.
Thanks and regards,
Shardul
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/OSEHRA/popHealth/issues/180?email_source=notifications&email_token=AAMCG3OUQ3JAOT3D42UFTYLQLN2KZA5CNFSM4I2MTBCKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7SFGRA#issuecomment-535057220 , or mute the thread https://github.com/notifications/unsubscribe-auth/AAMCG3L4ADEHAMSWN4NK5STQLN2KZANCNFSM4I2MTBCA .

I just used postman to import a patient zip file,

and it worked fine

@petercyli,
Thanks for update.
I am not using v6 version. I am using 6.0.0rc1 version. Please see version info collected from popHealth home page.
last tag: v6.0.0.rc1
bundle: 2017.0.4
I am using postman with below parameters.
file - patient's zip file containing CDA XML file
practice_id - Provider's ID
practice_name - Provider Name

It is giving 500 Internal server error and based on checking logs it gives below error highlighted in BOLD.
Started POST "/api/admin/patients/" for <IP_ADDRESS> at 2019-09-26 03:36:18 -0400
Processing by Api::Admin::PatientsController#create as /
Can't verify CSRF token authenticity
Completed 500 Internal Server Error in 418ms
NoMethodError (undefined method read' for nil:NilClass):   app/controllers/api/admin/patients_controller_before_change.rb:47:in block in create'
app/controllers/api/admin/patients_controller_before_change.rb:47:in open'   app/controllers/api/admin/patients_controller_before_change.rb:47:in create'

@petercyli ,
Below is the code snippet where it is throwing error in app/controllers/api/admin/patients_controller.rb at line no. 17. Here it gets file object as Nil and that's we can't apply read method on file.read on line no. 17 and gives this error.
I am wondering how we can get uploaded file object correctly and apply file.read operation on it.
Please suggest way to proceed further. I am not able to proceed further. Thanks.

_api :POST, "/admin/patients", "Upload a zip file of patients."

  param :file, nil, :desc => 'The zip file of patients to upload.', :required => true

  param :practice_id, String, :desc => "ID for the patient's Practice", :required => false

  param :practice_name, String, :desc => "Name for the patient's Practice", :required => false

  def create

    log_admin_api_call LogAction::ADD, "Upload patient ZIP file", true

    file = params[:file]

    practice = get_practice_parameter(params[:practice_id], params[:practice_name])

    FileUtils.mkdir_p(File.join(Dir.pwd, "tmp/import"))

    file_location = File.join(Dir.pwd, "tmp/import")

    file_name = "patient_upload" + Time.now.to_i.to_s + rand(1000).to_s

    temp_file = File.new(file_location + "/" + file_name, "w")

    **_File.open(temp_file.path, "wb") { |f| f.write(file.read) }**

Can you try the API without the practice id?  I just used the practice name.

Tried as suggested through only practice name and file but same error. No improvement.

@petercyli ,
I have little bit modified the code of app/controller/api/admin/patients_controller.rb file and changed line no.8 as per code mentioned in earlier comment and changed to line.
Changed from
file = params[:file]
to
file = StringIO.new(request.body.read)
Now, it is not giving 500 internal server error. Now it fails later stage import patient job with below error.
/home/shardulb/osehra_pophealth/tmp/import/failed# vi patient_upload1569505510299.error
File /home/shardulb/osehra_pophealth/tmp/import/patient_upload1569505510299 has zero size. Did you mean to pass the create flag?
/usr/local/rvm/gems/ruby-2.2.5/gems/rubyzip-1.2.1/lib/zip/file.rb:82:in initialize' /usr/local/rvm/gems/ruby-2.2.5/gems/rubyzip-1.2.1/lib/zip/file.rb:98:in new'
/usr/local/rvm/gems/ruby-2.2.5/gems/rubyzip-1.2.1/lib/zip/file.rb:98:in open' /home/shardulb/osehra_pophealth/lib/hds/bulk_record_importer.rb:17:in import_archive'
/home/shardulb/osehra_pophealth/lib/import_archive_job.rb:16:in `perform'
There problem is related to that we are not passing file correctly to import job.
Can you please help how to pass correct file object to import job?
Another thing this error collected from failed directory. But internally it tries to search from /home/shardulb/osehra_pophealth/tmp/import/patient_upload1569505510299.
This file found in /home/shardulb/osehra_pophealth/tmp/import/failed.
Please help and let me know the correct method of passing file object to import job.
Thanks.

@petercyli
Could you please help?

So the api method tried to import the zip file, but the popHealth had an error processing the zip file; hence, the error seen in the tmp subdirectory.
Were you able to import the same zip file using the popHealth UI via the admininstrator menu?

Yes. Same zip file is uploaded via popHealth UI and patient count is also increased. Only the problem with API.
In your case it is working as expected as per postman snapshot shared in comment.
Can you please share your code of app/controllers/api/admin/patients_controller.rb file?

This is code from the latest v6 branch - https://github.com/OSEHRA/popHealth/blob/v6/app/controllers/api/admin/patients_controller.rb

Checked and verified latest v6 branch code and 6.0.0rc1 version and they are same. Nothing is changed. Even I put your file but same issue.
I am wondering how it works in your case.
I have question about how to read file body parameter correctly to get zip file so that it copies at location /tmp/import directory for further processing.

BTW, popHealth version 6 is not using the records collection.  Patient data is stored in the qdm_patients collection.  There is no extra configuration to generate more debug logs.  We will need to add more debug statements to improve logging.

Currently when file is selected for processing using ImportArchiveJob it will remove it from tmp/import directory. Is there way I can uncomment the code of file removal so that I get the file at tmp/import directory. I need to check file and verify few things.
Could you please help code where it removes file from /tmp/import directory?
Thanks.

Please give me you email and I need to contact for further help. We can setup meeting for further discussion. I will show you all details with all options I have tried still API is not working.
I checked using UI and it was successful but API is not working.

@petercyli
Thanks Peter for all your help. I have resolved the issue. Now I am able to upload patient's zip file using API. This API finally adds patient's record in MongoDB.
Can I contribute code in master branch? What are the steps to contribute the code?

Definitely.  You can create a pull request to the v6 branch in the popHealth.   I will merge the code after reviewing the change.
Thanks.


[BENCH-1053] remove aws-enabled check on resource access

AWS-enabled checks are performed when AWS workspaces are created.
user already created AWS resources and is attempting to access them via axon function (current apis)
aws is disabled by default and only authorized users (listed in flagsmith segment) have access. User mail is not available (and not needed) in axon APIs. subsequently all flagsmith calls will return false w/o email address. Hence removing the check.
other changes - update featureService to keep it consistent with WSM https://github.com/DataBiosphere/terra-workspace-manager/pull/1459
Upgrade TCL version

Just to confirm: my understanding is that some flags (including aws-enabled) can be set differently for different users. Would this allow a user who has AWS disabled to access resources in an AWS workspace anyway if someone else creates it and invites them, and is that expected?

flag behavior and usage: that will be used to control workspace creation. Hence, a user with aws_enabled=false cannot create a AWS backed workspace. They can still access an AWS backed workspace if it is shared with them.


Contributor Promotion: Dominik Kawka

Which member are you nominating for a team change?
Dominik Kawka
Current active maintainers sponsoring this nomination for the promotion?
@caradelia @cybette @jjasghar
Hello, I'm Dominik Kawka, the new Community Architect to join the team. I started this role on August 1st. Since starting, I've been attending the community and CLI meetings, and I even had the privilege to host a community meeting!
I graduated from college with a 1.1. in BSc (Hons) in Software Systems Development this year in May. For my final year project, I built an image classifier using TensorFlow, which would distinguish between different dog breeds, and users could upload photos to the model via website.
As such, I would like to request to become a member for this repo.

I'm sponsoring @dominikkawka, and additionally recommending Dominik for maintainer of the community repo (there's no triager role in this repo), due to his role as an AI Community Architect which will include responsibilities such as hosting community meetings.

Appreciate the following of the process on this! It has made me notice we don't seem to have any kind of guidance around how to conclude these nominations like we do for Maintainer teams? https://github.com/instructlab/community/blob/main/CONTRIBUTOR_ROLES.md#member

Also while I am not a Community Maintainer I am a Maintainer on several other teams and would support @dominikkawka's nomination :smile:

If y'all are interested feel free to use the same nomination template we have in the CLI repo: https://github.com/instructlab/instructlab/blob/main/.github/ISSUE_TEMPLATE/team_recommend.md

As such, I would like to request to become a member for this repo.

I'm sponsoring @dominikkawka, and additionally recommending Dominik for maintainer of the community repo

Is this nomination for Member or Maintainer? Member seems appropriate while Maintainer seems a big stretch.
+1 for Member.
-1 for Maintainer.

@dominikkawka has been involved in the community and maintains an extremely positive engagement. I've added him as a maintainer for the work he is being assigned from Red Hat.
Congratulations!


Retry production-build job in case of the git forge error

[ ] Make sure that the job is retried for  ogr.exceptions.GitForgeInternalError and ogr.exceptions.OgrNetworkError. There is already an auto-retry mechanism we already have:
https://github.com/packit/packit-service/blob/307974f7bba1f349d5b0f9d0c0d3eaa6e988d2b4/packit_service/worker/tasks.py#L60-L65
[ ] react nicely after X retries (you can get inspired by the propose-downstream retries for source download).
[ ] check that the production-build job can be retried in any state and make the job idempotent if needed

part of the #927 epic

I am going to close this issue since this should be covered by https://github.com/packit/packit-service/issues/1692 and auto-retries.


.NET Core port - DO NOT MERGE

Hi,
I tried for fun to make this library be .NET Core compatible.
I made a project.json file and made it compile, note that I changed some things: there is no such thing "InvariantCultureIgnoreCase", so I replaced it with "OrdinalIgnoreCase",
there are no more "Close" methods for streams and sockets, so I replaced it with "Dispose".
I also didn't reimplement QueuedStream since I'm not sure if this hack is needed for .NET Core. I also didn't covert the tests.
I didn't try this, I don't know if it works.
I'm opening this pull request, just for the case that anyone wants to continue this work on the port. Please don't merge it until tests are converted, pass, and until this is actually tested.
Best regards,
Elad

Slick work.

Thanks!! I'll be needing this port soon, so thank you very much!

+1
DotNetCore/Kestral version of my server dropped to 5k RPS... from an easy 50k.

The dependency NETStandard.Library >= 1.6.0 could not be resolved.	Fleck	G:\Drive\Avarice\SignalMQ\Fleck-master\core\Fleck\project.json	5

After some fiddling, I got the project down to 4 errors with the following
`
{
"title": "Fleck",
"version": "1.0.0-*",
"dependencies": {
"NETStandard.Library": "1.6.0"
},
"frameworks": {
"netstandard1.6": {
"imports": "dnxcore50"
}
},
"buildOptions": {
"allowUnsafe": true,    "define": [ "NETCORE" ]
}
}
`
The errors being the removal of the BeginAsync/EndAsync and missing System.Security.SSLStream
Do we have an ETA when this will be ready for testing. I recently got the microsoft websocket up to 800,000 OPS would like to test out fleck again. @darkl

@NVentimiglia, I worked on this a bit today.
This works fine on my machine with .NET RTM:

dotnet restore
dotnet build src\Fleck src\Samples\ConsoleApp
cd src\Samples\ConsoleApp
dotnet run

Tests don't compile since a .NET Core compatible Moq isn't available yet.
I'm not sure if I'll finish this, but you're welcome to continue from where I've stopped.
Elad

7/9/2016 12:31:43 PM [Info] Server started at ws://<IP_ADDRESS>:5000 (actual port 5000)
One or more errors occurred. (Attempt by method 'Fleck.SocketWrapper.Accept(System.Action1<Fleck.ISocket>, System.Action1<System.Exception>)' to access method 'System.Net.Sockets.Socket.BeginAccept(System.AsyncCallback, System.Object)' failed.)
Terminating

Are you using the latest version? (netcore branch)
The latest version doesn't call BeginAccept at all.
Elad

Not needed anymore.


Uncaught TypeError: The "path" argument must be of type string. Received type undefined

[Enter steps to reproduce:]

Open markdown file to convert
hit "ctrl+shft+E"
See error

Atom: 1.47.0 x64
Electron: 5.0.13
OS: Mac OS X 10.14.6
Thrown From: markdown-themeable-pdf package 1.2.1
Stack Trace
Uncaught TypeError: The "path" argument must be of type string. Received type undefined
At internal/validators.js:105

TypeError [ERR_INVALID_ARG_TYPE] [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received type undefined
    at validateString (internal/validators.js:105:11)
    at Object.join (path.js:1037:7)
    at Object.getConfigFilePath (/packages/markdown-themeable-pdf/lib/markdown-themeable-pdf.js:575:28)
    at /packages/markdown-themeable-pdf/lib/markdown-themeable-pdf.js:365:44
    at FSReqCallback.readFileAfterClose [as oncomplete] (internal/fs/read_file_context.js:54:3)

Commands
     -0:07.8.0 markdown-themeable-pdf:export (div.line)

Non-Core Packages
markdown-themeable-pdf 1.2.1

This was from a fresh install of Atom

Duplicate issue with known workarounds

ok, a workaround is no fix!  and which duplicate? link?
you want us to search through all issues? really?

In case anyone needs it:
There's workaround for it in #128. You need to open the folder as a project before trying to convert to PDF.
That wasn't so hard.


Removing scheduling logic for combiners from closure initialization time to closure run time

The motive of this change is that we don't want the closure logic to be intertwined with schedulers. Effectively, the closure runner/scheduler should make the decision on how the closure needs to be run -

Combiners
ExecCtx
Executors

Therefore, instead of -
 GRPC_CLOSURE_INIT(closure, cb, cb_arg, grpc_combiner_scheduler(combiner));
 GRPC_CLOSURE_SCHED(closure, error);

we would have -
  GRPC_CLOSURE_INIT(closure, cb, cb_arg, nullptr);
  combiner->Run(closure, error);

This PR separates the two for combiners.
Strategy for the change -

If at the point of scheduling the closure, we have access to the combiner, simple perform the change as shown above.
If we do not have access to the combiner at the point of closure, we create a hopper function that will jump into the combiner. This hopper function is scheduled on the ExecCtx.

Note that this is first in a line of PRs. Changes coming in subsequent PRs -

A new Combiner API that does not have FinallyRun and does not depend on ExecCtx. (The current API will either be removed altogether or be deprecated)
Removal of Executor Schedulers and switch to Executor::Run()
Removal of ExecCtx schedulers and switch to ExecCtx::Run()
Removal of scheduler from closures.
Switching ExecCtx::Run() to direct invokation

This change is

Known issues : #20519, #20436, #20502

Issues : #20686

Thanks for reviewing!


Enforce access controls

Initial implementation as part of curation_concerns.  Closing this epic and will write specific access and authorization stories as they come up.


Support unbounded parameter limit

In version 2, setting up query_parameter_limit to -1 is not working. As per explanation in this reference, it should accepts limit of positional arguments with value -1.
And I think there should be a correction of what value -1 must behave. Instead of always emit struct (like value 1 does), it should generates the code with complete positional arguments.

0 is actually a valid setting. When zero is set, queries will always have a struct. Can we update this to only make changes for -1?

hi @kyleconroy , sure. Just want to clarify, so what is the definition of query_parameter_limit ? In my interpretation, it's used to set the maximum number of parameters that would be generated.
So, set the query parameter limit to n, where n > 0, if the number of parameter is p and p<=n, then, it uses data type per individual parameter, otherwise (p>n), it uses a struct.
Set to -1 to make it always uses data type per individual parameter. And 0 would be logically invalid I believe(?)

Just seeing your latest fix. Understood now, sqlc doesn't support always emit all positional arguments (-1) as I expected (though I've just realized that emitting all args is bad practice). Sorry for misinterpretation. Agree to close this PR 👍


Join forces with https://github.com/kylebrowning/drupal-ios-sdk

Aren't the two doing the same thing?
https://github.com/kylebrowning/drupal-ios-sdk

Judging by the way this SDK is setup, I think we are handling it differently. Just as in the Drupal space there are many roads that lead to our destination.


Volumes and mount path config

Volume config and mount path config to support permissions restrictions for /etc/reaper, which will contain the cassandra-reaper.yml and shiro.ini files.
Part of the overall Reaper security context configurations as identified in:

k8ssand-700
k8ssand-701

Do we need an updated Reaper image with which to test? Or does Reaper already write its configs into /etc/reaper? I cannot remember.

@jsanda It was adjusted to from its original target folder to the newly setup /etc/reaper.  I should have referenced the PR that aligns with this particular change to make that more clear.
@adejanovski tested the Reaper image changes for us (thanks Alex!) and it seems to not be causing any issues.  That PR is just awaiting a recent rebase to be squashed to reaper master.
You can reference that PR for Reaper here.

@jeffbanks I tested again. Everything looks good to go. We need to wait to merge until your Reaper PR (https://github.com/thelastpickle/cassandra-reaper/pull/1133) is merged.

@adejanovski @jsanda This merge is pending the approval of [cassandra-reaper](Reaper PR (thelastpickle/cassandra-reaper#1133) PR.

Closing this PR as effort here has been replaced with this newer PR #84.
Changes as a result of reverting path back to /etc/cassandra-reaper as described in cassandra-reaper PR#1139


:heavy_plus_sign: :eyeglasses:

Add specs (geddit :smile:)
However, there's an issue with the numeric class:
/Users/peterso/Projects/active_emoji/lib/active_emoji.rb:2:in `require': /Users/peterso/Projects/active_emoji/lib/active_emoji/core_ext/numeric.rb:3: class/module name must be CONSTANT (SyntaxError)

As an emoji isnt a capital letter, it doesn't like it as a class name...

Closing out old PR's, this is many years after the fact so I'm assuming it's super out of date! Closing 👍


Overwrite vs Add Calendar Items

Can you enhance your powershelgl script to allow for overwriting based on Subject and Start Date being the same as what that person has in their calendar already? We have a scenario where we are pushing the company holidays to everyone's calendars. Your script works awesome to bring it in the first time but I don't want to rerun the script and get duplicates. I would rather it ignore it if it already exists. It could simply be a flag that doesn't allow it to place duplicates on the calendar if it already exists.
Thanks,
Jason

This is for the Import-CalendarCSV.ps1 script?

That is correct. JasonOn Nov 30, 2022, at 10:20, David Barrett @.***> wrote:
This is for the Import-CalendarCSV.ps1 script?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>


ci: migrate to reusable workflows

Let's add this new workflow for functional tests in this pr

We can replace build step with reusable workflow

:tada: This PR is included in version 2.3.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket: