Failed to import OmniGen. Please check if the code was downloaded correctly.

看了这个 ，不行

What version of Python, PyTorch and CUDA are you using?

Hi - just installed fresh tonight - getting this error - I am running in the cloud  - I have a separate instance where I have the alternative version working fine - but i wanted to see if your implementation was more efficient running wise, as I will make a sharable image for other cloud users to run ( I already have for the other version) at https://mimicpc.com?fpr=adam47
ComfyUI Error Report
Error Details

Node Type: ailab_OmniGen
Exception Type: RuntimeError
Exception Message: Failed to import OmniGen. Please check if the code was downloaded correctly.

Stack Trace
  File "/data/app/execution.py", line 289, in execute
    obj = class_def()

  File "/data/app/custom_nodes/ComfyUI-OmniGen/ailab_OmniGen.py", line 36, in __init__
    raise RuntimeError("Failed to import OmniGen. Please check if the code was downloaded correctly.")

System Information

ComfyUI Version: v0.2.6
Arguments: /data/app/main.py --listen --port 30000
OS: posix
Python Version: 3.10.14 (main, Mar 21 2024, 16:24:04) [GCC 11.2.0]
Embedded Python: false
PyTorch Version: 2.4.0+cu121

Devices

Name: cuda:0 NVIDIA L40S : cudaMallocAsync

Type: cuda
VRAM Total:<PHONE_NUMBER>2
VRAM Free:<PHONE_NUMBER>4
Torch VRAM Total: 0
Torch VRAM Free: 0

Logs
2024-11-06 23:16:49,676 - root - INFO - Total VRAM 45596 MB, total RAM 31632 MB
2024-11-06 23:16:49,676 - root - INFO - pytorch version: 2.4.0+cu121
2024-11-06 23:16:52,364 - root - INFO - xformers version: 0.0.27.post2
2024-11-06 23:16:52,364 - root - INFO - Set vram state to: NORMAL_VRAM
2024-11-06 23:16:52,364 - root - INFO - Device: cuda:0 NVIDIA L40S : cudaMallocAsync
2024-11-06 23:16:52,753 - root - INFO - Using xformers cross attention
2024-11-06 23:16:54,635 - root - INFO - [Prompt Server] web root: /data/app/web
2024-11-06 23:16:56,785 - root - WARNING - Traceback (most recent call last):
  File "/data/app/nodes.py", line 2006, in load_custom_node
    module_spec.loader.exec_module(module)
  File "<frozen importlib._bootstrap_external>", line 879, in exec_module
  File "<frozen importlib._bootstrap_external>", line 1016, in get_code
  File "<frozen importlib._bootstrap_external>", line 1073, in get_data
FileNotFoundError: [Errno 2] No such file or directory: '/data/app/custom_nodes/vae/__init__.py'

2024-11-06 23:16:56,785 - root - WARNING - Cannot import /data/app/custom_nodes/vae module for custom nodes: [Errno 2] No such file or directory: '/data/app/custom_nodes/vae/__init__.py'
2024-11-06 23:16:56,891 - root - INFO -
Import times for custom nodes:
2024-11-06 23:16:56,891 - root - INFO -    0.0 seconds (IMPORT FAILED): /data/app/custom_nodes/vae
2024-11-06 23:16:56,891 - root - INFO -    0.0 seconds: /data/app/custom_nodes/ComfyUI-Custom-Scripts
2024-11-06 23:16:56,891 - root - INFO -    0.1 seconds: /data/app/custom_nodes/ComfyUI-Manager
2024-11-06 23:16:56,892 - root - INFO -    0.1 seconds: /data/app/custom_nodes/ComfyUI-OmniGen
2024-11-06 23:16:56,892 - root - INFO -
2024-11-06 23:16:56,900 - root - INFO - Starting server

2024-11-06 23:16:56,901 - root - INFO - To see the GUI go to: http://<IP_ADDRESS>:30000
2024-11-06 23:16:56,901 - root - INFO - To see the GUI go to: http://[::]:30000
2024-11-06 23:17:53,549 - root - INFO - got prompt
2024-11-06 23:17:55,032 - root - ERROR - !!! Exception during processing !!! Failed to import OmniGen. Please check if the code was downloaded correctly.
2024-11-06 23:17:55,239 - root - ERROR - Traceback (most recent call last):
  File "/data/app/custom_nodes/ComfyUI-OmniGen/ailab_OmniGen.py", line 32, in __init__
    from OmniGen import OmniGenPipeline
  File "/data/app/custom_nodes/ComfyUI-OmniGen/OmniGen/__init__.py", line 1, in <module>
    from .model import OmniGen
  File "/data/app/custom_nodes/ComfyUI-OmniGen/OmniGen/model.py", line 14, in <module>
    from OmniGen.transformer import Phi3Config, Phi3Transformer
  File "/data/app/custom_nodes/ComfyUI-OmniGen/OmniGen/transformer.py", line 18, in <module>
    from transformers import Phi3Config, Phi3Model
ImportError: cannot import name 'Phi3Config' from 'transformers' (/data/miniconda3/pkgs/comfyui/lib/python3.10/site-packages/transformers/__init__.py)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/data/app/execution.py", line 289, in execute
    obj = class_def()
  File "/data/app/custom_nodes/ComfyUI-OmniGen/ailab_OmniGen.py", line 36, in __init__
    raise RuntimeError("Failed to import OmniGen. Please check if the code was downloaded correctly.")
RuntimeError: Failed to import OmniGen. Please check if the code was downloaded correctly.

2024-11-06 23:17:55,239 - root - INFO - Prompt executed in 1.69 seconds

Attached Workflow
Please make sure that workflow does not contain any sensitive information such as API keys or passwords.
{"last_node_id":9,"last_link_id":10,"nodes":[{"id":7,"type":"ailab_OmniGen","pos":{"0":40,"1":60},"size":{"0":392.06988525390625,"1":438.5042419433594},"flags":{},"order":0,"mode":0,"inputs":[{"name":"image_1","type":"IMAGE","link":null,"shape":7,"label":"image_1"},{"name":"image_2","type":"IMAGE","link":null,"shape":7,"label":"image_2"},{"name":"image_3","type":"IMAGE","link":null,"shape":7,"label":"image_3"}],"outputs":[{"name":"IMAGE","type":"IMAGE","links":[8,9],"slot_index":0,"label":"IMAGE"}],"properties":{"Node name for S&R":"ailab_OmniGen"},"widgets_values":["20yo woman looking at viewer",3.5,1.8,50,true,false,false,512,768,999,"fixed",1024,"eager"]},{"id":9,"type":"PreviewImage","pos":{"0":1430,"1":60},"size":{"0":516.1412353515625,"1":824.7374267578125},"flags":{},"order":3,"mode":0,"inputs":[{"name":"images","type":"IMAGE","link":10,"label":"images"}],"outputs":[],"properties":{"Node name for S&R":"PreviewImage"},"widgets_values":[]},{"id":3,"type":"PreviewImage","pos":{"0":450,"1":60},"size":{"0":553.608642578125,"1":826.3672485351562},"flags":{},"order":1,"mode":0,"inputs":[{"name":"images","type":"IMAGE","link":8,"label":"images"}],"outputs":[],"properties":{"Node name for S&R":"PreviewImage"},"widgets_values":[]},{"id":8,"type":"ailab_OmniGen","pos":{"0":1020,"1":60},"size":{"0":392.06988525390625,"1":438.5042419433594},"flags":{},"order":2,"mode":0,"inputs":[{"name":"image_1","type":"IMAGE","link":9,"shape":7,"label":"image_1"},{"name":"image_2","type":"IMAGE","link":null,"shape":7,"label":"image_2"},{"name":"image_3","type":"IMAGE","link":null,"shape":7,"label":"image_3"}],"outputs":[{"name":"IMAGE","type":"IMAGE","links":[10],"slot_index":0,"label":"IMAGE"}],"properties":{"Node name for S&R":"ailab_OmniGen"},"widgets_values":["the girl in image_1 sitting on rock on top of the mountain.",3.5,1.8,50,true,false,false,512,768,1000,"fixed",1024,"eager"]}],"links":[[8,7,0,3,0,"IMAGE"],[9,7,0,8,0,"IMAGE"],[10,8,0,9,0,"IMAGE"]],"groups":[],"config":{},"extra":{"ds":{"scale":0.513158118230707,"offset":[-27.153689989420982,338.99349035661555]}},"version":0.4}

Additional Context
(Please add any additional context or steps to reproduce the error here)

its happen because using old version or python, pytorch or CUDA, Update the custom node. it will automatically select between SDPA, eager now.

no luck here, updated pytorch.. still get the same error

I wiped everything - updated - new workflow and created nodes from fresh - same error still - I also noticed it’s installed a VAE directory and random files in the root of Custom Nodes directory
Rest

Just installed today. Tried everything above and no luck. Cannot get this to run. All items are updated, tried updating the node, tried uninstalling and reinstalling and nothing is working.

What's kind the error message you get?

I wiped everything - updated - new workflow and created nodes from fresh - same error still - I also noticed it’s installed a VAE directory and random files in the root of Custom Nodes directory!

It looks like the random files you're referring to might be "OmniGen-v1" from GitHub. These files should be downloaded to the comfyui/models/LLM/OmniGen-v1 folder. You can move them to the correct directory to ensure everything works properly.
Also, could you let me know what operating system you're using? The code was developed primarily for Windows, but if you share your system configuration, I can try to adjust the code to make it compatible with your setup.

Totally my fault. updating Torch does for the system does not work for comfyui - at least for me. I had to run the update in the comfyui update folder and everything is good now. Note: Updating from the manager will not solve it. You need to run the bat file in the update folder of comfy.

I wiped everything - updated - new workflow and created nodes from fresh - same error still - I also noticed it’s installed a VAE directory and random files in the root of Custom Nodes directory!

It looks like the random files you're referring to might be "OmniGen-v1" from GitHub. These files should be downloaded to the comfyui/models/LLM/OmniGen-v1 folder. You can move them to the correct directory to ensure everything works properly.
Also, could you let me know what operating system you're using? The code was developed primarily for Windows, but if you share your system configuration, I can try to adjust the code to make it compatible with your setup.

I am using a cloud app instance of Comfyui at https://mimicpc.com/?fpr=adam47. I managed to get two versions of the nodes running so far in different fresh instances. There’s 5 versions now on GitHub, but I don’t think at this point any are going to improve the performance until Omnigen themselves optimize. Though one of the ones I got working (chflame) has andtype switch offering an int8 low vram choice. So maybe that will speed thing up.

Totally my fault. updating Torch does for the system does not work for comfyui - at least for me. I had to run the update in the comfyui update folder and everything is good now. Note: Updating from the manager will not solve it. You need to run the bat file in the update folder of comfy.

Always update from the bat file and got the same error.
Fetching 10 files: 100%|███████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 10/10 [06:09<00:00, 36.97s/it]
OmniGen model downloaded successfully
Error importing OmniGen: cannot import name 'OffloadedCache' from 'transformers.cache_utils' (C:\AI\ComfyUI_windows_portable\python_embeded\Lib\site-packages\transformers\cache_utils.py)
!!! Exception during processing !!! Failed to import OmniGen. Please check if the code was downloaded correctly.
Traceback (most recent call last):
  File "C:\AI\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-OmniGen\ailab_OmniGen.py", line 32, in __init__
    from OmniGen import OmniGenPipeline
  File "C:\AI\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-OmniGen\OmniGen\__init__.py", line 3, in <module>
    from .scheduler import OmniGenScheduler
  File "C:\AI\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-OmniGen\OmniGen\scheduler.py", line 6, in <module>
    from transformers.cache_utils import Cache, DynamicCache, OffloadedCache
ImportError: cannot import name 'OffloadedCache' from 'transformers.cache_utils' (C:\AI\ComfyUI_windows_portable\python_embeded\Lib\site-packages\transformers\cache_utils.py)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "C:\AI\ComfyUI_windows_portable\ComfyUI\execution.py", line 289, in execute
    obj = class_def()
          ^^^^^^^^^^^
  File "C:\AI\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-OmniGen\ailab_OmniGen.py", line 36, in __init__
    raise RuntimeError("Failed to import OmniGen. Please check if the code was downloaded correctly.")
RuntimeError: Failed to import OmniGen. Please check if the code was downloaded correctly.

actually i normally run the normal update not the dependency update (that caused issues in the past so I avoid it like the plague) it sort of worked, though it did make a somewhat glitched image.... but thats not likely the nodes fault

Failed to import OmniGen. Please check if the code was downloaded correctly.")
RuntimeError: Failed to import OmniGen. Please check if the code was downloaded correctly.

Failed to import OmniGen. Please check if the code was downloaded correctly.")
RuntimeError: Failed to import OmniGen. Please check if the code was downloaded correctly.
you can try delete the OmniGen folder. it will automatically download it again， or you can download it manually on https://huggingface.co/spaces/Shitao/OmniGen/tree/main/OmniGen

for me looks like a breaking change in huggingface_hub. This is with a fresh install

I checked the code, it's because the python can't find where the OmniGen is, so it raise such error report.
so, just clone the ori repo https://github.com/VectorSpaceLab/OmniGen, and copy the folder "OmniGen" to  your_comfyui_path/custom_nodes/ComfyUI-OmniGen
it's worked for me, good luck.

Reinstalled deleted the Omnigen folder in custom_nodes but same problem :
ComfyUI Error Report
Error Details

Node Type: ailab_OmniGen
Exception Type: RuntimeError
Exception Message: Failed to import OmniGen. Please check if the code was downloaded correctly.

Stack Trace
  File "G:\ComfyUI-aki-v1.3\execution.py", line 289, in execute
    obj = class_def()
          ^^^^^^^^^^^

  File "G:\ComfyUI-aki-v1.3\custom_nodes\ComfyUI-OmniGen\ailab_OmniGen.py", line 57, in __init__
    raise RuntimeError("Failed to import OmniGen. Please check if the code was downloaded correctly.")

System Information

ComfyUI Version: v0.2.7-18-ga72d152b
Arguments: G:\ComfyUI-aki-v1.3\main.py --auto-launch --preview-method auto --disable-cuda-malloc
OS: nt
Python Version: 3.11.6 | packaged by conda-forge | (main, Oct  3 2023, 10:29:11) [MSC v.1935 64 bit (AMD64)]
Embedded Python: false
PyTorch Version: 2.5.1+cu124

Devices

Name: cuda:0 NVIDIA GeForce RTX 3070 Ti : cudaMallocAsync

Type: cuda
VRAM Total:<PHONE_NUMBER>
VRAM Free:<PHONE_NUMBER>
Torch VRAM Total: 0
Torch VRAM Free: 0

Logs
2024-11-12T15:57:23.976051 -  2024-11-12T15:57:23.976051 - 2024-11-12T15:57:23.976051 - 2024-11-12T15:57:23.976051 -  2024-11-12T15:57:23.976051 - 2024-11-12T15:57:23.976051 - 2024-11-12T15:57:23.976051 -  2024-11-12T15:57:23.976051 - 2024-11-12T15:57:23.976051 - 2024-11-12T15:57:23.976051 -  2024-11-12T15:57:23.976051 - 2024-11-12T15:57:23.976051 - 2024-11-12T15:57:23.976051 -  2024-11-12T15:57:23.976051 - 2024-11-12T15:57:24.576024 - [SKIP] Downgrading pip package isn't allowed: requests (cur=2.32.3)2024-11-12T15:57:24.576024 -
2024-11-12T15:57:24.576024 - [SKIP] Downgrading pip package isn't allowed: transformers (cur=4.46.2)2024-11-12T15:57:24.576024 -
2024-11-12T15:57:24.576024 - [SKIP] Downgrading pip package isn't allowed: accelerate (cur=1.1.1)2024-11-12T15:57:24.576024 -
2024-11-12T15:57:24.576024 - [SKIP] Downgrading pip package isn't allowed: einops (cur=0.8.0)2024-11-12T15:57:24.576024 -
2024-11-12T15:57:24.576024 - [SKIP] Downgrading pip package isn't allowed: safetensors (cur=0.4.5)2024-11-12T15:57:24.576024 -
2024-11-12T15:57:24.576024 -
[ComfyUI-Manager] Startup script completed.2024-11-12T15:57:24.576024 -
2024-11-12T15:57:24.576024 - #######################################################################
2024-11-12T15:57:24.576024 -
2024-11-12T15:57:24.576024 -
Prestartup times for custom nodes:2024-11-12T15:57:24.576024 -
2024-11-12T15:57:24.576024 -    0.0 seconds:2024-11-12T15:57:24.576024 -  2024-11-12T15:57:24.576024 - G:\ComfyUI-aki-v1.3\custom_nodes\rgthree-comfy2024-11-12T15:57:24.576024 -
2024-11-12T15:57:24.576024 -    0.0 seconds:2024-11-12T15:57:24.576024 -  2024-11-12T15:57:24.576024 - G:\ComfyUI-aki-v1.3\custom_nodes\ComfyUI-Marigold2024-11-12T15:57:24.576024 -
2024-11-12T15:57:24.576024 -   11.3 seconds:2024-11-12T15:57:24.576024 -  2024-11-12T15:57:24.576024 - G:\ComfyUI-aki-v1.3\custom_nodes\ComfyUI-Manager2024-11-12T15:57:24.576024 -
2024-11-12T15:57:24.576024 -
2024-11-12T15:57:26.559226 - Total VRAM 8192 MB, total RAM 32670 MB
2024-11-12T15:57:26.560731 - pytorch version: 2.5.1+cu124
2024-11-12T15:57:27.939422 - xformers version: 0.0.28.post3
2024-11-12T15:57:27.939422 - Set vram state to: NORMAL_VRAM
2024-11-12T15:57:27.940419 - Device: cuda:0 NVIDIA GeForce RTX 3070 Ti : cudaMallocAsync
2024-11-12T15:57:28.100431 - Using xformers cross attention
2024-11-12T15:57:29.150520 - [Prompt Server] web root: G:\ComfyUI-aki-v1.3\web
2024-11-12T15:57:29.861144 - Adding2024-11-12T15:57:29.861144 -  2024-11-12T15:57:29.861144 - G:\ComfyUI-aki-v1.3\custom_nodes2024-11-12T15:57:29.861144 -  2024-11-12T15:57:29.861144 - to sys.path2024-11-12T15:57:29.861144 -
2024-11-12T15:57:30.491300 -
Efficiency Nodes: Attempting to add Control Net options to the 'HiRes-Fix Script' Node (comfyui_controlnet_aux add-on)...Success!2024-11-12T15:57:30.491300 -
2024-11-12T15:57:30.492297 - Loaded Efficiency nodes from2024-11-12T15:57:30.492297 -  2024-11-12T15:57:30.492297 - G:\ComfyUI-aki-v1.3\custom_nodes\efficiency-nodes-comfyui2024-11-12T15:57:30.492297 -
2024-11-12T15:57:30.500851 - Loaded ControlNetPreprocessors nodes from2024-11-12T15:57:30.500851 -  2024-11-12T15:57:30.500851 - G:\ComfyUI-aki-v1.3\custom_nodes\comfyui_controlnet_aux2024-11-12T15:57:30.500851 -
2024-11-12T15:57:30.501924 - Loaded AdvancedControlNet nodes from2024-11-12T15:57:30.501924 -  2024-11-12T15:57:30.501924 - G:\ComfyUI-aki-v1.3\custom_nodes\ComfyUI-Advanced-ControlNet2024-11-12T15:57:30.501924 -
2024-11-12T15:57:30.503919 - Could not find AnimateDiff nodes2024-11-12T15:57:30.503919 -
2024-11-12T15:57:30.525766 - Loaded IPAdapter nodes from2024-11-12T15:57:30.525766 -  2024-11-12T15:57:30.525766 - G:\ComfyUI-aki-v1.3\custom_nodes\ComfyUI_IPAdapter_plus2024-11-12T15:57:30.527243 -
2024-11-12T15:57:30.531352 - Could not find VideoHelperSuite nodes2024-11-12T15:57:30.531352 -
2024-11-12T15:57:30.534853 - ### Loading: ComfyUI-Impact-Pack (V7.11.3)2024-11-12T15:57:30.534853 -
2024-11-12T15:57:30.694892 - ### Loading: ComfyUI-Impact-Pack (Subpack: V0.8)2024-11-12T15:57:30.694892 -
2024-11-12T15:57:30.713958 - ### Loading: ComfyUI-Impact-Pack (V7.11.3)2024-11-12T15:57:30.714956 -
2024-11-12T15:57:30.731870 - Loaded ImpactPack nodes from2024-11-12T15:57:30.731870 -  2024-11-12T15:57:30.731870 - G:\ComfyUI-aki-v1.3\custom_nodes\ComfyUI-Impact-Pack2024-11-12T15:57:30.731870 - [Impact Pack] Wildcards loading done.2024-11-12T15:57:30.731870 -
2024-11-12T15:57:30.731870 -
2024-11-12T15:57:30.732867 - [Impact Pack] Wildcards loading done.2024-11-12T15:57:30.732867 -
2024-11-12T15:57:31.017650 - [Crystools INFO] Crystools version: 1.21.0
2024-11-12T15:57:31.031876 - [Crystools INFO] CPU: Intel(R) Core(TM) i7-10700K CPU @ 3.80GHz - Arch: AMD64 - OS: Windows 10
2024-11-12T15:57:31.039430 - [Crystools INFO] Pynvml (Nvidia) initialized.
2024-11-12T15:57:31.039430 - [Crystools INFO] GPU/s:
2024-11-12T15:57:31.055931 - [Crystools INFO] 0) NVIDIA GeForce RTX 3070 Ti
2024-11-12T15:57:31.055931 - [Crystools INFO] NVIDIA Driver: 565.90
2024-11-12T15:57:31.615697 - XTNodes: Successfully imported G:\ComfyUI-aki-v1.3\custom_nodes\ComfyUI-EasyCivitai-XTNodes\civitaiNodes\civitai_url_nodes.py2024-11-12T15:57:31.615697 -
2024-11-12T15:57:31.660110 - XTNodes: Successfully imported G:\ComfyUI-aki-v1.3\custom_nodes\ComfyUI-EasyCivitai-XTNodes\civitaiNodes\local_loader_nodes.py2024-11-12T15:57:31.660110 -
2024-11-12T15:57:31.661073 - XTNodes: Successfully imported G:\ComfyUI-aki-v1.3\custom_nodes\ComfyUI-EasyCivitai-XTNodes\civitaiNodes\prompt_concatenate.py2024-11-12T15:57:31.662059 -
2024-11-12T15:57:31.665602 - ### Loading: ComfyUI-Impact-Pack (V7.11.3)2024-11-12T15:57:31.665602 -
2024-11-12T15:57:31.666676 - [Impact Pack] Wildcards loading done.2024-11-12T15:57:31.667722 -
2024-11-12T15:57:31.671700 - ### Loading: ComfyUI-Inspire-Pack (V1.6)2024-11-12T15:57:31.671700 -
2024-11-12T15:57:31.737229 - ### Loading: ComfyUI-Manager (V2.51.9)2024-11-12T15:57:31.737229 -
2024-11-12T15:57:31.843326 - ### ComfyUI Revision: 2826 [a72d152b] | Released on '2024-11-12'2024-11-12T15:57:31.843326 -
2024-11-12T15:57:32.186225 - [ComfyUI-Manager] default cache updated: https://raw.githubusercontent.com/ltdrdata/ComfyUI-Manager/main/model-list.json2024-11-12T15:57:32.186225 -
2024-11-12T15:57:32.205140 - [ComfyUI-Manager] default cache updated: https://raw.githubusercontent.com/ltdrdata/ComfyUI-Manager/main/github-stats.json2024-11-12T15:57:32.206336 -
2024-11-12T15:57:32.287098 - [ComfyUI-Manager] default cache updated: https://raw.githubusercontent.com/ltdrdata/ComfyUI-Manager/main/extension-node-map.json2024-11-12T15:57:32.287098 -
2024-11-12T15:57:32.325815 - [ComfyUI-Manager] default cache updated: https://raw.githubusercontent.com/ltdrdata/ComfyUI-Manager/main/custom-node-list.json2024-11-12T15:57:32.325815 -
2024-11-12T15:57:32.373793 - [ComfyUI-Manager] default cache updated: https://raw.githubusercontent.com/ltdrdata/ComfyUI-Manager/main/alter-list.json2024-11-12T15:57:32.373793 -
2024-11-12T15:57:32.396673 - Total VRAM 8192 MB, total RAM 32670 MB
2024-11-12T15:57:32.396673 - pytorch version: 2.5.1+cu124
2024-11-12T15:57:32.396673 - xformers version: 0.0.28.post3
2024-11-12T15:57:32.396673 - Set vram state to: NORMAL_VRAM
2024-11-12T15:57:32.396673 - Device: cuda:0 NVIDIA GeForce RTX 3070 Ti : cudaMallocAsync
2024-11-12T15:57:32.439974 - (pysssss:WD14Tagger) [DEBUG] Available ORT providers: AzureExecutionProvider, CPUExecutionProvider2024-11-12T15:57:32.439974 -
2024-11-12T15:57:32.439974 - (pysssss:WD14Tagger) [DEBUG] Using ORT providers: CUDAExecutionProvider, CPUExecutionProvider2024-11-12T15:57:32.439974 -
2024-11-12T15:57:32.475878 - Workspace manager - Openning file hash dict2024-11-12T15:57:32.475878 -
2024-11-12T15:57:32.475878 - 🦄🦄Loading: Workspace Manager (V2.1.0)2024-11-12T15:57:32.475878 -
2024-11-12T15:57:32.509027 - ------------------------------------------2024-11-12T15:57:32.510024 -
2024-11-12T15:57:32.510024 - Comfyroll Studio v1.76 :  175 Nodes Loaded2024-11-12T15:57:32.510024 -
2024-11-12T15:57:32.510024 - ------------------------------------------2024-11-12T15:57:32.510024 -
2024-11-12T15:57:32.510024 - ** For changes, please see patch notes at https://github.com/Suzie1/ComfyUI_Comfyroll_CustomNodes/blob/main/Patch_Notes.md2024-11-12T15:57:32.510024 -
2024-11-12T15:57:32.510024 - ** For help, please see the wiki at https://github.com/Suzie1/ComfyUI_Comfyroll_CustomNodes/wiki2024-11-12T15:57:32.510024 -
2024-11-12T15:57:32.510024 - ------------------------------------------2024-11-12T15:57:32.510024 -
2024-11-12T15:57:32.518520 - ### [START] ComfyUI AlekPet Nodes v1.0.33 ###2024-11-12T15:57:32.518520 -
2024-11-12T15:57:35.207201 - Node -> ChatGLMNode: ChatGLM4TranslateCLIPTextEncodeNode, ChatGLM4TranslateTextNode [Loading] 2024-11-12T15:57:35.207201 -
2024-11-12T15:57:35.210193 - Node -> ArgosTranslateNode: ArgosTranslateCLIPTextEncodeNode, ArgosTranslateTextNode [Loading] 2024-11-12T15:57:35.210193 -
2024-11-12T15:57:35.221965 - Node -> DeepTranslatorNode: DeepTranslatorCLIPTextEncodeNode, DeepTranslatorTextNode [Loading] 2024-11-12T15:57:35.221965 - Node -> GoogleTranslateNode: GoogleTranslateCLIPTextEncodeNode, GoogleTranslateTextNode [Loading] 2024-11-12T15:57:35.221965 -
2024-11-12T15:57:35.221965 -
2024-11-12T15:57:35.226021 - Node -> PoseNode: PoseNode [Loading] 2024-11-12T15:57:35.226021 -
2024-11-12T15:57:35.228062 - Node -> ExtrasNode: PreviewTextNode, HexToHueNode, ColorsCorrectNode [Loading] 2024-11-12T15:57:35.228062 -
2024-11-12T15:57:35.267496 - Node -> IDENode: IDENode [Loading] 2024-11-12T15:57:35.267496 -
2024-11-12T15:57:35.396824 - Node -> PainterNode: PainterNode [Loading] 2024-11-12T15:57:35.396824 -
2024-11-12T15:57:35.396824 - ### [END] ComfyUI AlekPet Nodes ###2024-11-12T15:57:35.396824 -
2024-11-12T15:57:35.884993 - FizzleDorf Custom Nodes: Loaded2024-11-12T15:57:35.884993 -
2024-11-12T15:57:35.895625 - [tinyterraNodes] Loaded2024-11-12T15:57:35.895625 -
2024-11-12T15:57:35.963806 - Patching UNetModel.forward2024-11-12T15:57:35.963806 -
2024-11-12T15:57:35.963806 - UNetModel.forward has been successfully patched.2024-11-12T15:57:35.963806 -
2024-11-12T15:57:35.972922 - [Power Noise Suite]: 🦚🦚🦚 Squeaa-squee!!! 🦚🦚🦚2024-11-12T15:57:35.972922 -
2024-11-12T15:57:35.972922 - [Power Noise Suite]: Tamed 11 wild nodes.2024-11-12T15:57:35.972922 -
2024-11-12T15:57:35.987078 -
2024-11-12T15:57:35.987078 - [rgthree] Loaded 39 exciting nodes.2024-11-12T15:57:35.987078 -
2024-11-12T15:57:35.987078 - [rgthree] NOTE: Will NOT use rgthree's optimized recursive execution as ComfyUI has changed.2024-11-12T15:57:35.987078 -
2024-11-12T15:57:35.987078 -
2024-11-12T15:57:35.991062 -
Import times for custom nodes:
2024-11-12T15:57:35.991062 -    0.0 seconds: G:\ComfyUI-aki-v1.3\custom_nodes\websocket_image_save.py
2024-11-12T15:57:35.991062 -    0.0 seconds: G:\ComfyUI-aki-v1.3\custom_nodes\AIGODLIKE-ComfyUI-Translation
2024-11-12T15:57:35.991062 -    0.0 seconds: G:\ComfyUI-aki-v1.3\custom_nodes\sdxl_prompt_styler
2024-11-12T15:57:35.991062 -    0.0 seconds: G:\ComfyUI-aki-v1.3\custom_nodes\ControlNet-LLLite-ComfyUI
2024-11-12T15:57:35.991062 -    0.0 seconds: G:\ComfyUI-aki-v1.3\custom_nodes\FreeU_Advanced
2024-11-12T15:57:35.991062 -    0.0 seconds: G:\ComfyUI-aki-v1.3\custom_nodes\efficiency-nodes-comfyui
2024-11-12T15:57:35.991062 -    0.0 seconds: G:\ComfyUI-aki-v1.3\custom_nodes\ComfyUI_IPAdapter_plus
2024-11-12T15:57:35.991062 -    0.0 seconds: G:\ComfyUI-aki-v1.3\custom_nodes\comfyui-copilot
2024-11-12T15:57:35.991062 -    0.0 seconds: G:\ComfyUI-aki-v1.3\custom_nodes\stability-ComfyUI-nodes
2024-11-12T15:57:35.991062 -    0.0 seconds: G:\ComfyUI-aki-v1.3\custom_nodes\civitai_comfy_nodes
2024-11-12T15:57:35.991062 -    0.0 seconds: G:\ComfyUI-aki-v1.3\custom_nodes\ComfyUI-WD14-Tagger
2024-11-12T15:57:35.991062 -    0.0 seconds: G:\ComfyUI-aki-v1.3\custom_nodes\ComfyUI_TiledKSampler
2024-11-12T15:57:35.991062 -    0.0 seconds: G:\ComfyUI-aki-v1.3\custom_nodes\comfyui_controlnet_aux
2024-11-12T15:57:35.991062 -    0.0 seconds: G:\ComfyUI-aki-v1.3\custom_nodes\ComfyUI_experiments
2024-11-12T15:57:35.992061 -    0.0 seconds: G:\ComfyUI-aki-v1.3\custom_nodes\PowerNoiseSuite
2024-11-12T15:57:35.992061 -    0.0 seconds: G:\ComfyUI-aki-v1.3\custom_nodes\images-grid-comfy-plugin
2024-11-12T15:57:35.992061 -    0.0 seconds: G:\ComfyUI-aki-v1.3\custom_nodes\ComfyUI_FizzNodes
2024-11-12T15:57:35.992061 -    0.0 seconds: G:\ComfyUI-aki-v1.3\custom_nodes\ComfyUI-Impact-Pack
2024-11-12T15:57:35.992061 -    0.0 seconds: G:\ComfyUI-aki-v1.3\custom_nodes\ComfyUI_UltimateSDUpscale
2024-11-12T15:57:35.992061 -    0.0 seconds: G:\ComfyUI-aki-v1.3\custom_nodes\ComfyUI-Custom-Scripts
2024-11-12T15:57:35.992061 -    0.0 seconds: G:\ComfyUI-aki-v1.3\custom_nodes\comfyui-various
2024-11-12T15:57:35.992061 -    0.0 seconds: G:\ComfyUI-aki-v1.3\custom_nodes\ComfyUI_essentials
2024-11-12T15:57:35.992061 -    0.0 seconds: G:\ComfyUI-aki-v1.3\custom_nodes\Derfuu_ComfyUI_ModdedNodes
2024-11-12T15:57:35.992061 -    0.0 seconds: G:\ComfyUI-aki-v1.3\custom_nodes\ComfyUI-Advanced-ControlNet
2024-11-12T15:57:35.992061 -    0.0 seconds: G:\ComfyUI-aki-v1.3\custom_nodes\rgthree-comfy
2024-11-12T15:57:35.992061 -    0.0 seconds: G:\ComfyUI-aki-v1.3\custom_nodes\ComfyUI-OmniGen
2024-11-12T15:57:35.992061 -    0.0 seconds: G:\ComfyUI-aki-v1.3\custom_nodes\ComfyUI-AnimateDiff-Evolved
2024-11-12T15:57:35.992061 -    0.0 seconds: G:\ComfyUI-aki-v1.3\custom_nodes\ComfyUI_Comfyroll_CustomNodes
2024-11-12T15:57:35.992061 -    0.0 seconds: G:\ComfyUI-aki-v1.3\custom_nodes\comfyui-workspace-manager
2024-11-12T15:57:35.992061 -    0.1 seconds: G:\ComfyUI-aki-v1.3\custom_nodes\ComfyUI_tinyterraNodes
2024-11-12T15:57:35.993057 -    0.1 seconds: G:\ComfyUI-aki-v1.3\custom_nodes\ComfyUI-Inspire-Pack
2024-11-12T15:57:35.993057 -    0.3 seconds: G:\ComfyUI-aki-v1.3\custom_nodes\ComfyUI-Crystools
2024-11-12T15:57:35.993057 -    0.3 seconds: G:\ComfyUI-aki-v1.3\custom_nodes\ComfyUI-Manager
2024-11-12T15:57:35.993057 -    0.3 seconds: G:\ComfyUI-aki-v1.3\custom_nodes\ComfyUI-Marigold
2024-11-12T15:57:35.993057 -    0.6 seconds: G:\ComfyUI-aki-v1.3\custom_nodes\ComfyUI-EasyCivitai-XTNodes
2024-11-12T15:57:35.993057 -    0.9 seconds: G:\ComfyUI-aki-v1.3\custom_nodes\comfyui-art-venture
2024-11-12T15:57:35.993057 -    3.4 seconds: G:\ComfyUI-aki-v1.3\custom_nodes\ComfyUI_Custom_Nodes_AlekPet
2024-11-12T15:57:35.993057 -
2024-11-12T15:57:36.006738 - Starting server

2024-11-12T15:57:36.007772 - To see the GUI go to: http://<IP_ADDRESS>:8188
2024-11-12T15:57:36.843018 - FETCH DATA from: G:\ComfyUI-aki-v1.3\custom_nodes\ComfyUI-Manager\extension-node-map.json2024-11-12T15:57:36.843018 - 2024-11-12T15:57:36.847513 -  [DONE]2024-11-12T15:57:36.847513 -
2024-11-12T15:57:42.476280 - got prompt
2024-11-12T15:57:42.685150 - Downloading OmniGen code from GitHub...2024-11-12T15:57:42.685150 -
2024-11-12T15:57:42.976219 - Downloaded model.py2024-11-12T15:57:42.976219 -
2024-11-12T15:57:43.271954 - Downloaded pipeline.py2024-11-12T15:57:43.271954 -
2024-11-12T15:57:43.509257 - Downloaded processor.py2024-11-12T15:57:43.510257 -
2024-11-12T15:57:43.812666 - Downloaded scheduler.py2024-11-12T15:57:43.812666 -
2024-11-12T15:57:44.060007 - Downloaded transformer.py2024-11-12T15:57:44.060007 -
2024-11-12T15:57:44.375471 - Downloaded utils.py2024-11-12T15:57:44.375471 -
2024-11-12T15:57:44.663337 - Downloaded __init__.py2024-11-12T15:57:44.663337 -
2024-11-12T15:57:44.663337 - OmniGen code setup completed2024-11-12T15:57:44.663337 -
2024-11-12T15:57:44.663337 - OmniGen models verified successfully2024-11-12T15:57:44.663337 -
2024-11-12T15:57:44.959894 - Error importing OmniGen: No module named 'peft'2024-11-12T15:57:44.959894 -
2024-11-12T15:57:44.965384 - !!! Exception during processing !!! Failed to import OmniGen. Please check if the code was downloaded correctly.
2024-11-12T15:57:44.966384 - Traceback (most recent call last):
  File "G:\ComfyUI-aki-v1.3\custom_nodes\ComfyUI-OmniGen\ailab_OmniGen.py", line 53, in __init__
    from OmniGen import OmniGenPipeline
  File "G:\ComfyUI-aki-v1.3\custom_nodes\ComfyUI-OmniGen\OmniGen\__init__.py", line 4, in <module>
    from .pipeline import OmniGenPipeline
  File "G:\ComfyUI-aki-v1.3\custom_nodes\ComfyUI-OmniGen\OmniGen\pipeline.py", line 10, in <module>
    from peft import LoraConfig, PeftModel
ModuleNotFoundError: No module named 'peft'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "G:\ComfyUI-aki-v1.3\execution.py", line 289, in execute
    obj = class_def()
          ^^^^^^^^^^^
  File "G:\ComfyUI-aki-v1.3\custom_nodes\ComfyUI-OmniGen\ailab_OmniGen.py", line 57, in __init__
    raise RuntimeError("Failed to import OmniGen. Please check if the code was downloaded correctly.")
RuntimeError: Failed to import OmniGen. Please check if the code was downloaded correctly.

2024-11-12T15:57:44.967383 - Prompt executed in 2.48 seconds
2024-11-12T15:58:47.076153 - FETCH DATA from: G:\ComfyUI-aki-v1.3\custom_nodes\ComfyUI-Manager\.cache\1742899825_extension-node-map.json2024-11-12T15:58:47.076153 - 2024-11-12T15:58:47.176568 -  [DONE]2024-11-12T15:58:47.176568 -
2024-11-12T15:58:47.204967 - FETCH DATA from: G:\ComfyUI-aki-v1.3\custom_nodes\ComfyUI-Manager\.cache\1514988643_custom-node-list.json2024-11-12T15:58:47.204967 - 2024-11-12T15:58:47.416860 -  [DONE]2024-11-12T15:58:47.416860 -
2024-11-12T15:58:47.416860 - FETCH DATA from: G:\ComfyUI-aki-v1.3\custom_nodes\ComfyUI-Manager\.cache\746607195_github-stats.json2024-11-12T15:58:47.416860 - 2024-11-12T15:58:47.424913 -  [DONE]2024-11-12T15:58:47.424913 -
2024-11-12T15:58:47.551495 - FETCH DATA from: G:\ComfyUI-aki-v1.3\custom_nodes\ComfyUI-Manager\.cache\1742899825_extension-node-map.json2024-11-12T15:58:47.551495 - 2024-11-12T15:58:47.554996 -  [DONE]2024-11-12T15:58:47.554996 -
2024-11-12T15:58:54.297509 - FETCH DATA from: G:\ComfyUI-aki-v1.3\custom_nodes\ComfyUI-Manager\.cache\1742899825_extension-node-map.json2024-11-12T15:58:54.297509 - 2024-11-12T15:58:54.299503 -  [DONE]2024-11-12T15:58:54.299503 -
2024-11-12T15:58:54.318600 - FETCH DATA from: G:\ComfyUI-aki-v1.3\custom_nodes\ComfyUI-Manager\.cache\1514988643_custom-node-list.json2024-11-12T15:58:54.318600 - 2024-11-12T15:58:54.323586 -  [DONE]2024-11-12T15:58:54.323586 -
2024-11-12T15:58:54.323586 - FETCH DATA from: G:\ComfyUI-aki-v1.3\custom_nodes\ComfyUI-Manager\.cache\746607195_github-stats.json2024-11-12T15:58:54.323586 - 2024-11-12T15:58:54.325149 -  [DONE]2024-11-12T15:58:54.325149 -
2024-11-12T15:58:54.326147 - Start update check...2024-11-12T15:58:54.326147 - 2024-11-12T15:59:10.529758 -
Update check done.2024-11-12T15:59:10.529758 -
2024-11-12T15:59:26.017591 - got prompt
2024-11-12T15:59:26.036031 - OmniGen code already exists2024-11-12T15:59:26.036031 -
2024-11-12T15:59:26.036031 - OmniGen models verified successfully2024-11-12T15:59:26.036031 -
2024-11-12T15:59:26.040570 - Error importing OmniGen: No module named 'peft'2024-11-12T15:59:26.040570 -
2024-11-12T15:59:26.043562 - !!! Exception during processing !!! Failed to import OmniGen. Please check if the code was downloaded correctly.
2024-11-12T15:59:26.043562 - Traceback (most recent call last):
  File "G:\ComfyUI-aki-v1.3\custom_nodes\ComfyUI-OmniGen\ailab_OmniGen.py", line 53, in __init__
    from OmniGen import OmniGenPipeline
  File "G:\ComfyUI-aki-v1.3\custom_nodes\ComfyUI-OmniGen\OmniGen\__init__.py", line 4, in <module>
    from .pipeline import OmniGenPipeline
  File "G:\ComfyUI-aki-v1.3\custom_nodes\ComfyUI-OmniGen\OmniGen\pipeline.py", line 10, in <module>
    from peft import LoraConfig, PeftModel
ModuleNotFoundError: No module named 'peft'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "G:\ComfyUI-aki-v1.3\execution.py", line 289, in execute
    obj = class_def()
          ^^^^^^^^^^^
  File "G:\ComfyUI-aki-v1.3\custom_nodes\ComfyUI-OmniGen\ailab_OmniGen.py", line 57, in __init__
    raise RuntimeError("Failed to import OmniGen. Please check if the code was downloaded correctly.")
RuntimeError: Failed to import OmniGen. Please check if the code was downloaded correctly.

2024-11-12T15:59:26.045068 - Prompt executed in 0.02 seconds

It looks like you're missing the peft module. If you haven't installed it yet, you can do so, and that should resolve your issue. To check if it's installed, run:
ComfyUI\python_embeded\python.exe -m pip show peft


Request for Thinky definitions

Request for definitions for Thinky, an ORM for RethinkDB
http://thinky.io/
https://github.com/neumino/thinky

Any reason for closing this issue?

I don't recall

I built a type definition for Thinky for personal usage, it may have errors, use at your own risk. https://github.com/tomymolina/thinky.d.ts

Is there any news on official typings for thinky?


Fix benchmark main classes.

Pull Request Test Coverage Report for Build #68

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 89.667%

Totals

Change from base Build #67:
0.0%

Covered Lines:
1293

Relevant Lines:
1442

💛  - Coveralls


differences in limiting behavior running turtle with and with reduce confusing

It feels odd to me that these produce differently limited results.

by_state is defined:
by_state is (reduce
    state
    airport_count

almost certainly different nowadays


download options added

Fixes: #271
Download options added as png, jpg, jpeg and pdf.

Fixes: #271
Download options added as png, jpg, jpeg and pdf.

Can you upload a clip of the working please @mharshita . When I tried it was trying to save the HTML content

Fixes: #271
Download options added as png, jpg, jpeg and pdf.

Can you upload a clip of the working please @mharshita . When I tried it was trying to save the HTML content

Yes Sir. It is not working yet. Actually, the output window does not load on localhost, that's why I made a PR and converted it to draft to work on this issue, So that I can see the changes on deploy-preview. Please give me some more time to resolve the issue.

Fixes: #271
Download options added as png, jpg, jpeg and pdf.

Can you upload a clip of the working please @mharshita . When I tried it was trying to save the HTML content

Yes Sir. It is not working yet. Actually, the output window does not load on localhost, that's why I made a PR and converted it to draft to work on this issue, So that I can see the changes on deploy-preview. Please give me some more time to resolve the issue.

No worries. Take your time

@smaranjitghose Please review.

@smaranjitghose Please review.

We have to look into the encoding for the pdf file, the image formats work fine

@smaranjitghose Please review.

We have to look into the encoding for the pdf file, the image formats work fine

Okay!


remove unnecessary broadcasts from functions.layer_normalization

inspired from https://github.com/chainer/chainer/pull/6678#discussion_r270008149.

Jenkins, test this please.

Jenkins CI test (for commit 09780d15815d84b709d339a383fc3aba4a3b3056, target branch master) failed with status FAILURE.
(For contributors, please wait until the reviewer confirms the details of the error.)

Jenkins CI test (for commit 09780d15815d84b709d339a383fc3aba4a3b3056, target branch master) failed with status FAILURE.
(For contributors, please wait until the reviewer confirms the details of the error.)


Fixed url_decode function

Fixed webview#559

Related: https://github.com/webview/webview/pull/447


Reactflow not able to differentiate between click and double click events for both nodes and edges

What platform were you using when you found the bug?

React Flow
^11.7.0
Browser and version:
chrome
OS and version:

Live code example
Sandbox
Describe the Bug
Visit sandbox URL, Double click the node.
It's triggering click event handler but no double click handler.
Steps to reproduce the bug or issue

Go to sandbox example
Double Click on any of the node.
It's not triggering double click handler. (Sometimes triggers, but click handler is getting triggered first)

Expected behavior
As a user, I expect doubleClickHandler should trigger when I double click the any of the node.
But click handler is getting triggered.
Screenshots or Videos
No response
Additional context
No response

This is not how double click events are handled by the browser. Making these events mutually exclusive would mean every click would be delayed by the maximum allowed time frame for a double click, which would feel very sluggish.
The reason it does not trigger all the time is because you are moving your mouse ever so slightly in between clicks, which starts dragging a node. Try setting the nodeDragThreshold to something higher, like 2 or 3.


feat(icons): added preline icon

What is the purpose of this pull request?

[x] New Icon

Description
Added new preline icon.
Icon use case

The Preline icon is used to display the Preline library logo in web applications, UI components and responsive interfaces.
Alternative icon designs

Icon Design Checklist
Concept

[x] I have provided valid use cases for each icon.
[ ] I have not added any a brand or logo icon.
[x] I have not used any hate symbols.
[x] I have not included any religious or political imagery.

Author, credits & license

[ ] The icons are solely my own creation.
[x] The icons were originally created in # by @Footagesus
[x] I've based them on the following Lucide icons: steam
[ ] I've based them on the following design:

Naming

[x] I've read and followed the naming conventions
[x] I've named icons by what they are rather than their use case.
[x] I've provided meta JSON files in icons/[iconName].json.

Design

[ ] I've read and followed the icon design guidelines
[ ] I've made sure that the icons look sharp on low DPI displays.
[ ] I've made sure that the icons look consistent with the icon set in size, optical volume and density.
[ ] I've made sure that the icons are visually centered.
[ ] I've correctly optimized all icons to three points of precision.

Before Submitting

[x] I've read the Contribution Guidelines.
[ ] I've checked if there was an existing PR that solves the same issue.

@Footagesus: Please consult https://github.com/lucide-icons/lucide/issues/670


Create pages for Intl.Segmenter

Request type

[ ] Please close this issue, I accidentally submitted it without adding any details
[x] New documentation
[ ] Correction or update

Details

I'm working on documenting the Intl.Segmenter API and need several pages created. The following should be under the slug en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/Segmenter:

/supportedLocalesOf
/segment
/resolvedOptions

Then, there are a couple new objects that need documentation as well. The segment method above returns a Segments object, which has containing and @@iterator instance methods. containing, in turn, returns a SegmentData object, which just has several properties that need documenting. I'm not sure if these pages belong under the same slug as above, but wherever they end up I believe this should be a comprehensive list:

Segments

containing
@@iterator

SegmentData

Thank you in advance!

@mpcsh Awesome. Not done this before, so hope these work for you:

https://wiki.developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/Segmenter/supportedLocalesOf

Thank you! And I don't think it's obvious at all, so no worries. If my reading is correct, SegmentsObject is an internal object that's created by CreateSegmentsObject, but not exposed to the user (i.e. it exists only in the engine). In the spec for CreateSegmentsObject, the return value is created in step 2 from Segments.prototype. So by my reading, it's Segments that should be documented, because that's what the user will be handed back when they call Segmenter.prototype.segment (which calls CreateSegmentsObject).
So as far as the slug, how about the following, underneath the same en-US/Docs/Web/JavaScript/Reference/Global_Objects/Intl/Segmenter as above?

/Segments/{containing,@@iterator}
/SegmentData

Let me know if that sounds good to you.

@mpcsh Thanks.
I think SegmentData makes sense so created that: https://wiki.developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/Segmenter/SegmentData
Yes, feels like Segments is what we should create. You originally proposed -
Segments\
  containing
  @@iterator

Why not just Segments and doc those other ones inside it?
But since I lack confidence ... @chrisdavidmills what do you think?

@hamishwillee I don't have a strong opinion here, except to say that we usually tend to have separate pages for symbols, e.g. https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/@@iterator, so create the pages for consistency's sake?

Thanks @chrisdavidmills
OK @mpcsh the full set created below - the last three items being the new ones.

Intl.Segmenter.supportedLocalesOf()

Intl.Segmenter.prototype.segment()

Intl.Segmenter.prototype.resolvedOptions()
Intl.Segmenter.SegmentData
Intl.Segmenter.Segments

Intl.Segmenter.Segments.containing

Intl.Segmenter.Segments.containing.@@iterator

those pages look great, thank you all for your input and help!


[WIP] f5-config.py to create pools in least-connections-node mode

Change f5-config.py to configure pools in least-connections mode
instead of fastest-node mode to avoid error where all traffic
goes to single node
Connects #190

This PR is very much so a WIP. I just wanted to put some code up here to get comments.
The original issue mentions the repo server pool specifically, but I wasn't sure if the problem was specific to the repo server, or if it all pools should be changed to use least-connections-node mode. The code here does the heavy handed approach of changing all pools. Here are two sample outputs of the pool nodes when the script ran. (They came from the debug statement on line 681)
Before: http://paste.openstack.org/show/547867/
After: http://paste.openstack.org/show/547868/

RPC-AIO-Ceph-Liberty-PR: Fail

https://devcentral.f5.com/questions/least-connections-member-and-least-connections-node

RPC-AIO-Liberty-PR: Fail

RPC-AIO-Ceph-Liberty-PR: Fail

RPC-AIO-Liberty-PR: Fail

Failing because of the repo
16:11:18 TASK: [lxc_hosts | Install apt packages] **************************************
16:11:37 failed: [jrpcaioiad-288] => (item=apparmor,apparmor-utils,bridge-utils,cgmanager,cgroup-lite,debootstrap,dnsmasq,git,irqbalance,language-pack-en,liblxc1,lxc,lxc-dev,lxc-templates,python-dev,python3-lxc) => {"attempts": 5, "failed": true, "item": "apparmor,apparmor-utils,bridge-utils,cgmanager,cgroup-lite,debootstrap,dnsmasq,git,irqbalance,language-pack-en,liblxc1,lxc,lxc-dev,lxc-templates,python-dev,python3-lxc"}
16:11:37 stderr: E: Failed to fetch http://mirror.rackspace.com/ubuntu/pool/main/q/qemu/qemu-utils_2.0.0+dfsg-2ubuntu1.26_amd64.deb  404  Not Found

16:11:18 TASK: [lxc_hosts | Install apt packages] **************************************
16:11:37 failed: [jrpcaioiad-288] => (item=apparmor,apparmor-utils,bridge-utils,cgmanager,cgroup-lite,debootstrap,dnsmasq,git,irqbalance,language-pack-en,liblxc1,lxc,lxc-dev,lxc-templates,python-dev,python3-lxc) => {"attempts": 5, "failed": true, "item": "apparmor,apparmor-utils,bridge-utils,cgmanager,cgroup-lite,debootstrap,dnsmasq,git,irqbalance,language-pack-en,liblxc1,lxc,lxc-dev,lxc-templates,python-dev,python3-lxc"}
16:11:37 stderr: E: Failed to fetch http://mirror.rackspace.com/ubuntu/pool/main/q/qemu/qemu-utils_2.0.0+dfsg-2ubuntu1.26_amd64.deb  404  Not Found
16:11:37
16:11:37 E: Unable to fetch some archives, maybe run apt-get update or try with --fix-missing?
16:11:37
16:11:37 stdout: Reading package lists...
16:11:37 Building dependency tree...
16:11:37 Reading state information...
16:11:37 The following extra packages will be installed:
16:11:37   cloud-image-utils distro-info distro-info-data dnsmasq-base euca2ools
16:11:37   genisoimage libaio1 libmnl0 libnetfilter-conntrack3 librados2 librbd1
16:11:37   libseccomp2 libxslt1.1 python-distro-info python-lxml python-pkg-resources
16:11:37   python-requestbuilder python-setuptools qemu-utils sharutils uidmap
16:11:37 Suggested packages:
16:11:37   cgmanager-utils shunit2 wodim cdrkit-doc btrfs-tools lxctl qemu-user-static
16:11:37   python-lxml-dbg python-distribute python-distribute-doc
16:11:37 The following NEW packages will be installed:
16:11:37   cgmanager cloud-image-utils debootstrap distro-info distro-info-data dnsmasq
16:11:37   dnsmasq-base euca2ools genisoimage libaio1 liblxc1 libmnl0
16:11:37   libnetfilter-conntrack3 librados2 librbd1 libseccomp2 libxslt1.1 lxc lxc-dev
16:11:37   lxc-templates python-distro-info python-lxml python-pkg-resources
16:11:37   python-requestbuilder python-setuptools python3-lxc qemu-utils sharutils
16:11:37   uidmap
16:11:37 0 upgraded, 29 newly installed, 0 to remove and 22 not upgraded.
16:11:37 Need to get 414 kB/5275 kB of archives.
16:11:37 After this operation, 21.4 MB of additional disk space will be used.
16:11:37 Err http://mirror.rackspace.com/ubuntu/ trusty-updates/main qemu-utils amd64 2.0.0+dfsg-2ubuntu1.26
16:11:37   404  Not Found
16:11:37 Err http://mirror.rackspace.com/ubuntu/ trusty-security/main qemu-utils amd64 2.0.0+dfsg-2ubuntu1.26
16:11:37   404  Not Found
16:11:37
16:11:37 msg: Task failed as maximum retries was encountered
16:11:37
16:11:37 FATAL: all hosts have already failed -- aborting
16:11:37
16:11:37 PLAY RECAP ********************************************************************
16:11:37            to retry, use: --limit @/jenkins/setup-hosts.retry
16:11:37
16:11:37 jrpcaioiad-288             : ok=155  changed=72   unreachable=0    failed=1
recheck_all

Made some edits to clean things up and get it ready for review. I am going to verify basic functionality and then open it up to reviews.

RPC-AIO-Ceph-Liberty-PR: Fail

After speaking with Edgar on support, the new configuration checks out. Removing the WIP tag. I'd appreciate any and all feedback.

After I went home and thought about this a bit more I realized that although this patch would work, there is a better solution. I am looking into a new approach.

After further research, so that I could fully understand the problem at hand, I have come to the conclusion that changing to least-connections strategy for load balancing is not necessary or preferable to solve this issue. Instead the prioritization or repo servers can simply be deactivated.
Below is the new commit message
/==========================
Prior to this commit repo servers were configured in an F5 pool
which assigns a unique priority to each server. This means
that all requests are forwarded to the first server in the pool
until that server become unavailible. This is active-passive
load balancing.
This commit disables prioritization of of repo servers, which
enables active-active load balancing and forwards connections
under the fastest-connection policy. All servers in the pool
are now treated equally. This change is benificial in that the
load is now spread throughout the repo servers and the
deployment can benifit from the combined power.

👍  good logic, good change

Yeah, LGTM as well.

👎 the commit message is not formatted as we require it to be.

Fixed the commit message and changed the PR title to match
Enable active-active loadbalancing of repo servers

👍

RPC-AIO-Liberty-PR: Fail

👍 from me too. Will merge when the gate passes

@nategraf Will active active load balancing not cause issues, during initial repo build, where all packages are not synced across all containers ?

@BjoernT To my knowledge the unsynced repo servers are removed from the pool until they are ready, but this is from what I have been told, not personal investigation. Unfortunately I no longer have the hardware resources to test this, so I'm forced to defer the confirmation of this back to you and the dev team.

@BjoernT you should probably talk to the same people @nategraf talked to (see https://github.com/rcbops/rpc-openstack/issues/190#issuecomment-240080414)

@BjoernT @nategraf this commit https://github.com/openstack/openstack-ansible-repo_server/commit/b457f3bda65a418884e1847759e6bfa26a7ed5ab disables the unsynced repo-servers until they are synced, by stopping nginx on the repo container until the sync has finished. This means that the containers effectively take themselves out of whatever load balancer is being used (haproxy, f5 etc) until they are ready.

@mancdaz ok thanks


Create tooling with scripts and/or process-compose for having Move tests run in CI

Checkout this comment https://github.com/movementlabsxyz/movement/pull/205#issuecomment-2231144839
We want to be able to run automated tests on our move modules in CI. This will ensure updates wont break any dependant code. As of now we have to manualy update the Move.toml between running tests.
I think there would be a way to dynamically update the Move.toml with the correct values, or maybe there is a nifty aptos CLI command.

Add the new tooling and a new job into CI to run the tests added in this PR https://github.com/movementlabsxyz/movement/pull/205

Done in https://github.com/movementlabsxyz/movement/pull/304


sc-3583: adds head && about components

Codecov Report

Merging #352 (738f4ea) into main (bed0f7b) will increase coverage by 2.27%.
The diff coverage is n/a.

:exclamation: Current head 738f4ea differs from pull request most recent head b1507fb. Consider uploading reports for the commit b1507fb to get more accurate results

@@            Coverage Diff             @@
##             main     #352      +/-   ##
==========================================
+ Coverage   45.87%   48.14%   +2.27%
==========================================
  Files         222       71     -151
  Lines       10930     8568    -2362
  Branches      605        0     -605
==========================================
- Hits         5014     4125     -889
+ Misses       5008     3708    -1300
+ Partials      908      735     -173

Impacted Files
Coverage Δ

web/gds-admin-ui/src/redux/dashboard/saga.js

web/gds-admin-ui/src/helpers/api/auth.js

web/gds-admin-ui/src/redux/sagas.js

web/gds-admin-ui/src/components/OvalLoader.js

...dmin-ui/src/components/VectorMap/ItalyVectorMap.js

...min-ui/src/pages/app/details/BasicDetails/index.js

web/gds-admin-ui/src/redux/dashboard/actions.js

web/gds-admin-ui/src/utils/country.js

web/gds-admin-ui/src/pages/app/dashboard/Tasks.js

...tails/BasicDetails/components/Ivms101RecordForm.js

... and 141 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bed0f7b...b1507fb. Read the comment docs.


Sample code in README.md out of date

Just an FYI - if I find time I will send a PR.
one ex. ServiceDiscovery::new("_mysrv._tcp.local", 60, true) now only takes 2 parameters.

Also, the dns responder one has a dependency on simple-dns that is not mentioned.

@andrewdavidmackenzie thanks, I've forgot to update the README, I will try to update it in the next few days


Auto-complete does not work for external libraries

Configuration
Operating system: mac os x el-capitan
PlatformIO Version (platformio --version): PlatformIO, version 2.8.5
Description of problem
I followed same pattern mentioned in PlatformIO example folders for importing header files from external libs and it the build succeeds with #include <HeaderFile.h> but the problem is when I define object from class that's from HeaderFile the auto-complete thinks it's of type int. To overcome this problem I had to include the complete path to the HeaderFile, like
#include </Users/elogeela/Documents/projects/zumo-line-follower/lib/ZumoMotors/ZumoMotors.h>

Steps to Reproduce

Create src/main.cpp file with contents provided below
Try auto-complete motors. and it will not show anything
Update the #include <Motors.h> to have full path
Now auto-complete works

Actual Results
Auto-complete does not work with #include <Motors.h>
Expected Results
Auto-complete should work with just #include <Motors.h>
Source file to reproduce issue:
#include <Arduino.h>
#include <ZumoMotors.h>

#define LED_PIN 13

ZumoMotors motors;

void setup()
{
  pinMode(LED_PIN, OUTPUT);
}

void loop()
{
  digitalWrite(LED_PIN, HIGH);
  motors.setSpeeds(50, 50);
  delay(500);
}

Additional info
The repo with the folder structure is here: https://github.com/ogail/zumo-line-follower

This issue seems to be a duplicate of platformio/platformio-atom-ide/issues/65. You need to click "PlatformIO > Rebuild C/C++ Project Index (Autocomplete, Linter)" after changes to the libraries.

Thanks this fixed the issue!


Added search functionality

Hi @iamdarshshah, I have added the search functionality, please check.

[x] Add a search bar ui
[x] Add incremental search functionality
[x] Search functionality should check these params to filter the list - Name & Github-Username.
[x] Search-bar should be responsive and added below Create Pull Request button, position must be center.

Hey @pranesh239 - You did great. Thanks for putting effort to work on this. It looks great. But, I have added some review comments, please go through it once and revert back with required changes.
Also, We need to work on Search-field stylings, to make it look better. Otherwise, it is working as expected. Thanks 😄

@iamdarshshah refactored based on your comments and added a commit, please check

@pranesh239 Perfect! One more minor edit we'll need to make here. As we have removed the label, we need to add 🔍 icon to the start of the search field. Refer to this, it might help.

@iamdarshshah adding it

@iamdarshshah please check

@pranesh239 Now this looks great! The icon seems pleasing. Good job. 👍

@iamdarshshah Please check now

Thanks @iamdarshshah 🙂


Generating the tagfile in the background?

Hi,
Is it possible to generate/update the tag files in the background after saving a file?
It now blocks vim completely for a few seconds.
Kind Regards,
Tim

+1 for this, would be great if you can make it work, may be the simplest way is make some kind of mapping to vim-dispatch

Funnily enough, I've been working on a vim plugin for running commands asynchronously, vim-do. So with some tweaks, I should be able to hook it into that.
I'll keep you updated! Really sorry @TrafeX for the total lack of reply. I really need a better way of managing GH issues, where it notifies me if I don't respond after a while!

Hi everyone, I've just pushed to a branch called dev/run-in-background. This integrates with my aforementioned plugin, vim-do (github, vim.org), which runs commands asynchronously within vim (i.e. not in tmux, like vim-dispatch).
To use this, you'll obviously need to install vim-do, and also set g:taggatron_run_in_background = 1. This should remove the noticeable delay when generating large tag files.
This is very much in beta at the moment, so feedback would be much appreciated :)
Thanks!

Hi,
I just wanted to try this, but afaict, master is identical to dev/run-in-background. Why is that?
PS:
Thanks for your work on this, it's much better than using a cron-job.


[Do not merge]OAK-9552: Don't index except if it's oak:QueryIndexDefinition

In this change we are not logging invalid index-definitions in "sync lucene" index

Merged with https://github.com/apache/jackrabbit-oak/pull/357


(GH-615) Test for changes in SourceDirectoryPath, if ShouldDocumentSourceFiles is set.

When BuildParameters.ShouldDocumentSourceFiles is set, all changes in BuildParameters.SourceDirectoryPath are also triggering a re-build of documentation.
fixes #615

@nils-a happy to take this for a spin, thanks for doing this work, and for testing it out for us!

@nils-a your changes have been merged, thanks for your contribution 👍


add some logging

Type

[ ] Bug fix
[ ] Feature addition
[X] Feature update
[ ] Breaking change
[ ] Non-functional change
[ ] Documentation
[ ] Infrastructure

Goals
Add some logging details.
Checklist

[X] Build target all compiles cleanly.
[ ] clang-format and clang-tidy deltas produced no new output.
[ ] Newly added functions include doxygen-style comment block.

Please apply clang-format to the changed files.


@ApiModelProperty(hidden = true) seems not work

Hi,
I am using 'io.swagger:swagger-jersey2-jaxrs:1.5.10'.
The @ApiModelProperty(hidden = true) seems not hide those properties from 'definitions'!
Could you please have a look? Thanks!
import com.fasterxml.jackson.annotation.JsonCreator;
import com.fasterxml.jackson.annotation.JsonInclude;
import com.fasterxml.jackson.annotation.JsonProperty;
import com.google.common.collect.Lists;
import io.swagger.annotations.ApiModelProperty;
import lombok.Builder;
import lombok.Getter;
import lombok.Setter;

import java.util.List;

@Getter
@Setter
@JsonInclude(JsonInclude.Include.NON_EMPTY)
//@JsonFilter("attributeFilter")
public final class User extends Resource {

    public static final String SCHEMA = "urn:ietf:params:scim:schemas:core:2.0:User";

    @ApiModelProperty(value = "MUST be same as work type email address", required = true)
    private String userName;    // unique user-friendly identifier
    @ApiModelProperty(required = true)
    private Name name;
    @ApiModelProperty(hidden = true)
    private String displayName;
    @ApiModelProperty(hidden = true)
    private String nickName;
    @ApiModelProperty(hidden = true)
    private String profileUrl;
    @ApiModelProperty(hidden = true)
    private String title;
    @ApiModelProperty(hidden = true)
    private String userType;    // used to identify the relationship between the organization and the user
    @ApiModelProperty(hidden = true)
    private String preferredLanguage;
    @ApiModelProperty(hidden = true)
    private String locale;      // https://tools.ietf.org/html/rfc5646
    @ApiModelProperty(hidden = true)
    private String timezone;    // https://tools.ietf.org/html/rfc6557
    @ApiModelProperty("user status")
    private Boolean active;     // active/disabled/suspended
    @ApiModelProperty(hidden = true)
    private String password;
    @ApiModelProperty(required = true)
    private List<Email> emails;
    private List<PhoneNumber> phoneNumbers;
    @ApiModelProperty(hidden = true)
    private List<Im> ims;
    @ApiModelProperty(hidden = true)
    private List<Photo> photos;
    private List<Address> addresses;
    @ApiModelProperty(hidden = true)
    private List<GroupRef> groups;
    @ApiModelProperty(hidden = true)
    private List<Entitlement> entitlements;
    @ApiModelProperty(hidden = true)
    private List<Role> roles;
    @ApiModelProperty(hidden = true)
    private List<X509Certificate> x509Certificates;

    @JsonProperty(EnterpriseUser.SCHEMA)
    private EnterpriseUser enterpriseUser;

    @Builder
    @JsonCreator
    private User(@JsonProperty(value = "schemas", required = true) List<String> schemas,
                 @JsonProperty("id") String id,
                 @JsonProperty("externalId") String externalId,
                 @JsonProperty("meta") Meta meta,
                 @JsonProperty("userName") String userName,
                 @JsonProperty("name") Name name,
                 @JsonProperty("displayName") String displayName,
                 @JsonProperty("nickName") String nickName,
                 @JsonProperty("profileUrl") String profileUrl,
                 @JsonProperty("title") String title,
                 @JsonProperty("userType") String userType,
                 @JsonProperty("preferredLanguage") String preferredLanguage,
                 @JsonProperty("locale") String locale,
                 @JsonProperty("timezone") String timezone,
                 @JsonProperty("active") Boolean active,
                 @JsonProperty("password") String password,
                 @JsonProperty("emails") List<Email> emails,
                 @JsonProperty("phoneNumbers") List<PhoneNumber> phoneNumbers,
                 @JsonProperty("ims") List<Im> ims,
                 @JsonProperty("photos") List<Photo> photos,
                 @JsonProperty("addresses") List<Address> addresses,
                 @JsonProperty("groups") List<GroupRef> groups,
                 @JsonProperty("entitlements") List<Entitlement> entitlements,
                 @JsonProperty("roles") List<Role> roles,
                 @JsonProperty("x509Certificates") List<X509Certificate> x509Certificates,
                 @JsonProperty(EnterpriseUser.SCHEMA) EnterpriseUser enterpriseUser) {
        super(schemas == null ? Lists.newArrayList(SCHEMA) : schemas, id, externalId, meta);
        this.userName = userName;
        this.name = name;
        this.displayName = displayName;
        this.nickName = nickName;
        this.profileUrl = profileUrl;
        this.title = title;
        this.userType = userType;
        this.preferredLanguage = preferredLanguage;
        this.locale = locale;
        this.timezone = timezone;
        this.active = active;
        this.password = password;
        this.emails = emails;
        this.phoneNumbers = phoneNumbers;
        this.ims = ims;
        this.photos = photos;
        this.addresses = addresses;
        this.groups = groups;
        this.entitlements = entitlements;
        this.roles = roles;
        this.x509Certificates = x509Certificates;

        setEnterpriseUser(enterpriseUser);
    }

    public void setEnterpriseUser(EnterpriseUser enterpriseUser) {
        if (enterpriseUser != null) {
            this.enterpriseUser = enterpriseUser;
            addSchema(EnterpriseUser.SCHEMA);
        }
    }

}

@Api(tags = "User")
@Produces({MediaType.APPLICATION_JSON, SCIMConstants.SCIM_CONTENT_TYPE})
@Consumes({MediaType.APPLICATION_JSON, SCIMConstants.SCIM_CONTENT_TYPE})
@Path("/Users")
public class UserEndpoint extends ResourceEndpoint<User> {

    @Inject
    UserService userService;
    @Inject
    UserPatchService userPatchService;

    @ApiOperation(value = "get an user by id", response = User.class)
    @ApiResponses({
        @ApiResponse(code = 401, message = "authorization failure", response = ErrorResponse.class),
        @ApiResponse(code = 403, message = "license limit", response = ErrorResponse.class),
        @ApiResponse(code = 404, message = "not found", response = ErrorResponse.class),
        @ApiResponse(code = 429, message = "too many requests", response = ErrorResponse.class),
        @ApiResponse(code = 500, message = "internal server error", response = ErrorResponse.class)
    })
    @GET
    @Path("/{id}")
    public Response getUserById(@ApiParam("user id") @PathParam("id") String id) {
        User user = userService.getById(id);
        return buildResponseWithLocation(user);
    }

}

This is an interesting case. IIRC, it would work if you set it either on the setter or the getter (don't recall which) - however, you're using Lombok so... annotating the setter/getter is a bit messy.
At least for testing, can you try adding the setter and getter explicitly and set the hidden on them?

Hi @webron, it's working when annotating @ApiModelProperty(hidden = true) on getter.
Looking over the source codes of io.swagger.jackson.ModelResolver#resolve(com.fasterxml.jackson.databind.JavaType, io.swagger.converter.ModelConverterContext, java.util.Iterator<io.swagger.converter.ModelConverter>) and io.swagger.jackson.ModelResolver#ignore, it doesn't handle the @ApiModelProperty(hidden = true) on field.

Thanks for checking. Okay, so at least there's a workaround for now, but we'll keep this open as a bug. If you have time, consider submitting a PR.

Hi @webron, I was trying to fix this issue, and digging a bit more deeply into Jackson.
Found, the metadata of fields are removed in com.fasterxml.jackson.databind.introspect.POJOPropertiesCollector#_removeUnwantedProperties.
Since I used the Lombok, which will generate getter and setter methods. As a result, Jackson will ignore the metadata of field, and then use getter instead on its priority order...
But another case is the description defined by @ApiModelProperty(value = "MUST be same as work type email address", required = true), it's captured by Swagger. That means the annotations on field are handled by Swagger someway.
What's your suggestion on handling 'hidden' flag annotated on field when the getter/setter also exist?
Thanks.

+1

Hidden parameter also does not seem to work on scala case classes.

We had the same issue.
The fix was easy - setters were missing.

Fixed by #2251


It appears that redux-form.com website is not working now.

I just went to https://redux-form.com and got some black/white page (see attachment).

Some issue with CDN, perhaps?

Weird, I can see previous version api though.

Yes, there were some JS updates to the docs yesterday. Should be okay now. Thanks for the reporting!


Close session - "Segmentation fault"

Hi,
I have a problem with closing pcap session. When I call session.close() I get "Segmentation fault" error. Has anybody idea how to solve this problem?
Example code:
pcap_session.on('packet', function (raw_packet) {   // ....   pcap_session.close() })
I use master version of this package and latest libpcap0.8-dev 1.8.1-3

I’ve provided a fix in #221.

merging the other one and closing this.


[Blazor][Fixes #15413] Notify client of errors during initialization

The exception was being caught and never reached the client.
The fix consist simply of notifying the client from where the exception is being caught.

Mismatched parameter type.

Missing parameter

For the prerendering case you get a clear exception when trying to prerender, so no issue there

@Pilchie FYI

approved for 3.1.0-Preview3


adds functional tests

Adds two scripts that can be run to test Slack Apps and single team bots. There are no automated tests (I'm not sure how possible/valuable those tests would be), but this at least creates two bots and let's someone bang on them and see if they break.

Coverage remained the same at 100.0% when pulling 0e66e0ced376701ab71a14c170978ef26d802e19 on functional into 191f936570febb0c022b1a2512631ecc68b6f70d on 1.0.0-wip.


Rewrite linux installation guide

Followup to PR 215.

I updated instructions to use the AppImage from the latest release (much simpler to use)
I added a small section on firewall rules in Linux
I moved all previous instructions to a "Legacy Setup" section for now. Should this be removed entirely?

I haven't read this but can you also add a part on the serial permissions? You can't do the wifi setup otherwise

I haven't read this but can you also add a part on the serial permissions? You can't do the wifi setup otherwise

I don't have actual slimes yet, I've just been tinkering with this with owoTrack for now. Not really familiar with what needs to be done for serial.

I've added an additional section with what I believe should be the recommended way to set up the permissions for Serial Console. I've seen alternatives suggested on Discord though, so I'm open to changing the recommended method.
I don't have Slimes yet, but I do have the D1 Minis. I was able to get the console to print out a bunch of gibberish after setting up the udev rules, so I think it works.

eh, its a universal solution so good enough imo

Thank you so much for writing this up, we really appreciate it!

Pushed up one more change. I couldn't find any instructions specific to installing the OpenVR plugin on Linux, so I added them here.

do you mind adding the java 17 requirement, you can put it next to the appimage like what the old guide suggests or you can just install it with your package manager. SlimeVR will find it :p

do you mind adding the java 17 requirement, you can put it next to the appimage like what the old guide suggests or you can just install it with your package manager. SlimeVR will find it :p

Sure, I can do that. Didn't realize it was a requirement because it just worked on my machine, I assumed it was bundled in the AppImage

It's not, I should but it would increase binary size so much :sob:

Reworked the Java section, tried my best to make it apply to both the normal install as well as the legacy install (this might be a bit clunky, let me know if anything should be reworded). Also added a tidbit on installing Java globally.
Plenty of stuff for you guys to review :wink:


Node property side panel does not follow focus when opened in pipeline properties

Describe the issue
Node property side panel does not follow focus when opened in pipeline properties
To Reproduce
Steps to reproduce the behavior:

Open pipeline with multiple nodes
Click on canvas (make sure no node selected)
Open property side panel (should open ok on a pipeline property)
Click on any (or different) nodes and the panel keeps on pipeline properties

ah, this was an intentional choice, I can change it


Update EDBT 2024

Which conference does this PR update?

EDBT 2024

Related URL

https://dastlab.github.io/edbticdt2024/

@Mergifyio refresh


Add Address feature does not work in the account page

What is the location of your example repository?
No response
Which package or tool is having this issue?
Hydrogen
What version of that package or tool are you using?
"@shopify/hydrogen": "0.0.0-next-83fb14b-20240614172038"
What version of Remix are you using?
No response
Steps to Reproduce
when we submit the add address form error pops invariant failed
https://hydrogen.shop/account/address/add
Expected Behavior
customer address needs to be added
Actual Behavior
Customer can change or add his address using this form

I'll need more information to reproduce this error. I tried on hydrogen.shop to add an address an it is working fine.
Do you have an example address that is failing?


ca: Prevent concurrent certificate renewals

updateKEK runs RenewTLSConfigNow in a goroutine. If a manager is
switched between locked and unlocked mode quickly, some of these
certificate renewal goroutines could run at the same time. They could
potentially also overlap with a scheduled renewal.
This is bad because the SecurityConfig may end up using a different key
from the one on disk. The client and server credentials could
potentially get out of sync.
Limit RenewTLSConfigNow to one concurrent invocation.
cc @cyli @diogomonica

Current coverage is 54.84% (diff: 100%)

Merging #1765 into master will decrease coverage by 3.37%

@@             master      #1765   diff @@
==========================================
  Files            58        102     +44
  Lines          8700      16717   +8017
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits           5065       9168   +4103
- Misses         3073       6404   +3331
- Partials        562       1145    +583

Powered by Codecov. Last update afae8a8...3d78d34

LGTM

LGTM

Thanks for fixing, @aaronlehmann!


[SMALLFIX] Add a toString for Error and WriteRequests.

Sometimes we print these in error/warning messages.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/913/
Test PASSed.


rustplayer: init at 1.1.0-3

Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[x] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-already-reviewed/2617/1049

Possibly missing libva

It is updated to follow the master branch since there is a patch that can fix weird build failures.

@ofborg build


Add doc for more functions in Analyzer (missing plot)

Coverage remained the same at 15.51% when pulling 3853d3ca2babbbfa122308d3f36a7fc5b880de20 on develop into a4e03cba300a58da209ad18de0453cb5dd774170 on master.


skipOver: no unnecessary decoding

Per title. No need to do decoding if comparing two strings that have the same representation.

LGTM. As in: I think I understand what you do, why you do it and why it makes sense.

startsWith already has optimizations like this. Its logics can be reused?
https://github.com/D-Programming-Language/phobos/blob/b55c07c63a76ce56526afb1253ece5cda063849c/std/algorithm/searching.d#L3050

thanks for the review - updated

ping

LGTM.

Auto-merge toggled on


Support fixed width files

Pandas already support reading from fixed width source files using the read_fwf method. With minor changes to the contract and code, fixed width file support can be added.

Included in release 1.1.0 https://github.com/LinuxForHealth/CsvToFHIR/releases/tag/1.1.0


Powershell Modules in Script Missing DLL's (AzureAD Unable to Generate CMG Auth Token)

Both the Bios/Driver steps are failing on CMG connected machines PE phase.

Manifests itself as missing AZUREAD module files and noticed this was indeed updated 2 days ago.....

We fixed it by copying the following files before the Bios or Driver steps in the ts.

I'm running into this too. I also learned AzureAD <IP_ADDRESS> was the last version to include these files. Microsoft has deprecated the Azure Active Directory Authentication Library. https://www.nuget.org/packages/Microsoft.IdentityModel.Clients.ActiveDirectory
I think we'll need to copy these files until NickolaA has time to update PSIntuneAuth on PowerShell gallery.

Same here. I noticed external clients where not getting driver updates. I was able to create a short script that copies the missing binaries over.


[ENHANCEMENT STYLING] Adding 404 error page

Description
Adding a 404 error page ensures that if a user accidentally requests an incorrect route, they will not receive any inconvenient response.
Actual Behavior
Now,if user by mistake go to this url (https://medi--hub.vercel.app/Dashboard) it is showing irrelevant error
Expected Behavior
Please describe what you expected to happen.
So , if user by mistake go to any route that does not exist he/she should get a custom error page that allow them to navigate to the websites home page or a route that exist.
Screenshots (if applicable)
Actual:

Expected (highlight the part that requires changes):
He should get proper page indicating that you are lost and allow them to navigate to the homepage of our website.
Hey @Arghyadeep09  please assign this to me under GSSOC'24

@Samani-Humaira assigned
also try to  make UI suits our site(healthcare)


fix landing page buttons

btn-success is too intense. switch to btn-primary.

buttons fine on normal brightness


Add pods project schemes environment variable

Checklist

[x] I've run bundle exec rspec from the root directory to see all new and existing tests pass
[x] I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
[x] I've read the Contribution Guidelines
[x] I've updated the documentation if necessary.

Motivation and Context

At my workplace for one of our projects, we run a test spec from one of our internal cocoapods as a smoke test before running lengthier UI tests that depend on that pod. I was able to use the cocoapods post_install block to make the scheme public when installing on CI, but we're still unable to run those tests on fastlane since fastlane filters out pods schemes.
Description

I added an environment variable to optionally disable the filtering out of environment variables.
I tested this out by verifying that the scheme could be found with the environment set to a truthy value, and it could not be found when the environment variable is unset or set to a falsy value.

@googlebot I signed it!

whoops looks like I forgot to commit the linting autocorrections, will do so now.

Thanks for the quick merge!


Reporter file name is not working in node js

Hi Marcelduran,
Thanks for giving us webpagetest.
I am facing difficulties while generating TAP report using node js code, the same has been working fine trying with direct command (--reporter TAP > results.tap)
The code I am trying is,
wpt.getTestResults(data.data.id, { specs: '/usr/local/lib/node_modules/webpagetest/lib/home_spec.json', reporter: 'TAP', out: 'result.tap'}, function(err, data) {
console.log(err || data);
});
I am able to pass the reporter name in test option as 'TAP' and assertion results are getting printed successfully in the console. May I know how to pass the report name in function/option parameter (as we doing in TAP > filename)?
Regards,
Dhanabalan Venkitusamy,
@Dhanabalanvk.

Working fine after placing the console output in a file using ' > ' operator in terminal/command prompt instead of giving file name as WPT option parameter. Closing this defect.


Bump SqlToolsService version

Switch OSX packages to generic osx-x64 RID

@colombod @jonsequitur

Ok, something got messed up here so I'm just going to open a new one...


Set up bot account for notifications

As my user credentials are currently being used to make the issues, I don't personally get pinged when things go down. This is fine for now, as the hardware is shared with a service that I do get pinged for, but currently UH-specific issues could go unnoticed

I've just converted the repo over to using the gh-actions bot for this directly, so hopefully I'll now also get assignee notifications


kotlin Type parameter bound for T in fun <T : View!> findViewById(p0: Int): T!  is not satisfied: inferred type RefreshLayout! is not a subtype of View!

Type parameter bound for T in fun <T : View!> findViewById(p0: Int): T!
is not satisfied: inferred type RefreshLayout! is not a subtype of View!

    val refreshLayout = v!!.findViewById(R.id.refreshlayout) as SmartRefreshLayout


Fix microsoft live The access token isn't valid error

This replace removes valid characters from the token.

I cannot see the diff because the change was made to an auto-generated satellizer.js file. Source files are written in TypeScript.

Oh, sorry @sahat. Here is the fix in TypeScript https://github.com/sahat/satellizer/pull/1010


LSM Compaction: Use stable ManifestLevel TableInfo references to reduce ManifestLevel queries

Reduce queries to ManifestLevel during compaction
Specifically, this change have reduces the number of queries to the ManifesLevel at two places:

CompactionType.iterator_check, invokes LevelDataIteratorType.next, which further invokes LevelndexIteratorType.next. LevelndexIteratorType.next again iterates through the tables in Level B which intersect with the range returned by ManifestType.compaction_range. Now, instead of querying for the "next intersecting table" using LevelndexIteratorType.next, we're directly using pointers to the intersecting tables in the ManifestLevel in LevelBDataIterator.next.
CompactionType.apply_to_manifest invokes Compaction.update_table, which further invokes calls ManifestLevel.set_snapshot_max. ManifestLevel.set_snapshot_max performs another query to find the table to be updated in the ManifestLevel, and then updates it. In the new version, we're directly using pointers to the intersecting tables in the ManifestLevel and updating it using ManifestLevel.set_snapshot_max_stable_ptr (I've currently retained both functions, we can make this the default one too).

Miscellaneous Changes

Implements this TODO for releasing grid blocks associated with Level A. This is now done here, right after we copy the index block for the optimal compaction table in Level A.
Moves the core logic for Manifest.compaction_table, Manifest.compaction_range, Manifest.next_table, and Manifest.compaction_must_drop_tombstones into ManifestLevel (while still retaining the proxy functions in Manifest for use by Compaction). This is because the logic in these functions strictly related to the in-memory ManifestLevel. Moving this logic into ManifestLevel would allow us to test & benchmark all this functionality more easily (without involving ManifestLog, which accompanies by Manifest).
Removes Table.index_block_address, since it is the same as Table.block_address.
Small changes to EnvironmentType in manifest_level_fuzz.zig to make it more amenable for use from other test/benchmarking scripts.

Tests Conducted

./scripts/build.sh fuzz_lsm_tree ✅
./scripts/build.sh fuzz_lsm_forest ✅

Output of scripts/benchmark.sh
Before (on branch main)
1223 batches in 109.32 s
load offered = 1000000 tx/s
load accepted = 91471 tx/s
batch latency p00 = 1 ms
batch latency p10 = 22 ms
batch latency p20 = 24 ms
batch latency p30 = 24 ms
batch latency p40 = 25 ms
batch latency p50 = 26 ms
batch latency p60 = 27 ms
batch latency p70 = 28 ms
batch latency p80 = 28 ms
batch latency p90 = 30 ms
batch latency p100 = 4505 ms
transfer latency p00 = 1 ms
transfer latency p10 = 4191 ms
transfer latency p20 = 8537 ms
transfer latency p30 = 15783 ms
transfer latency p40 = 25487 ms
transfer latency p50 = 37590 ms
transfer latency p60 = 49517 ms
transfer latency p70 = 57964 ms
transfer latency p80 = 70396 ms
transfer latency p90 = 83550 ms
transfer latency p100 = 99337 ms

After (on branch cbb-lsm-manifest-iteration)
~/Desktop/tigerbeetle_summer23/tigerbeetle cbb-lsm-manifest-iteration* ⇡ ❯ sudo scripts/benchmark.sh

1223 batches in 107.07 s
load offered = 1000000 tx/s
load accepted = 93399 tx/s
batch latency p00 = 2 ms
batch latency p10 = 22 ms
batch latency p20 = 23 ms
batch latency p30 = 24 ms
batch latency p40 = 25 ms
batch latency p50 = 25 ms
batch latency p60 = 26 ms
batch latency p70 = 27 ms
batch latency p80 = 28 ms
batch latency p90 = 30 ms
batch latency p100 = 4192 ms
transfer latency p00 = 2 ms
transfer latency p10 = 4122 ms
transfer latency p20 = 8632 ms
transfer latency p30 = 15791 ms
transfer latency p40 = 25148 ms
transfer latency p50 = 36490 ms
transfer latency p60 = 48335 ms
transfer latency p70 = 56904 ms
transfer latency p80 = 69647 ms
transfer latency p90 = 82354 ms
transfer latency p100 = 97078 ms

Thanks for the super thorough review, @sentientwaffle! FYI, I have taken a stab at the change that we discussed in https://github.com/tigerbeetledb/tigerbeetle/pull/875#discussion_r1230195704 as a part of https://github.com/tigerbeetledb/tigerbeetle/pull/875/commits/ef8b53e44d3b93176b2d7bf257bb2f8637ed06e8.

https://github.com/tigerbeetledb/tigerbeetle/pull/875#discussion_r1234693396 and https://github.com/tigerbeetledb/tigerbeetle/pull/875#discussion_r1234693670 (from the previous review) weren't addressed.

Nevermind, I was mixing up the files :facepalm:


On demand lazy load not working with initialSlide and slidesToScroll

Lazy loading of type 'ondemand' fails to load some visible slides in certain situations

====================================================================
http://jsfiddle.net/abwb1aby/2/
====================================================================
Steps to reproduce the problem

Create a slick with a number of slides that is greater than its slidesToScroll, but not a multiple of slidesToScroll.
Include images on each slide with a data-lazy attribute.
Set infinite and centerMode to false, set lazyLoad to 'ondemand'
Set the initial slide to a slide on the last page of scrolling (e.g. n-1)

====================================================================
What is the expected behaviour?
All visible slides should be lazy loaded when the slick initializes
====================================================================
What is observed behaviour?
There are visible slides to the left of the "currentSlide" that do not get lazy loaded during init
====================================================================
More Details

Which browsers/versions does it happen on? All
Which jQuery/Slick version are you using? N/A
Did this work before? No

The fix is to use rangeStart = _.currentSlide - Math.max(0, _.currentSlide + _.options.slidesToShow - _.slideCount); when infinite and centerMode are false.  I'll submit a PR when I get a chance.

This sounds related to #2110, which I made a PR for it #2164, but when I tested the PR against your fiddle, I found a bug with scrolling--cant get to slide 1. Thanks for the issue @rphelan. I look forward to your PR.

@rphelan @leggomuhgreggo Was there ever a PR sent in for this? Having the same issue

@rphelan I've been trying to figure this bug out for a little bit now. For some reason converting the lazyLoad function to use Jquery made it work everytime for me, as well as Implenting an additional conditional to handle the infinite option at a higher level.
Also not sure if this makes any sense but before I changed the function over to jquery I was able to get the original way to work by adding a console.log directly after the img tag creation. Is there some sort of race case at play here?

@mcclaskiem Sorry, I forgot about this one, working on a PR now.  I do not expect it to fix the scrolling issue that @leggomuhgreggo mentioned though as I think its separate (although caused by the same combination of settings).

#2255

Any updates on this?


Fix panic bugs in ark_poly Add and Sub impls

Some missing truncate_leading_zeroes() in ark_poly operator impls can cause a panic in degree():

impl<'a, 'b, F: Field> Add<&'a SparsePolynomial> for &'b DensePolynomial at https://github.com/arkworks-rs/algebra/blob/97c7a4f4e8f5e297e397f6de09fe4764068deac0/poly/src/polynomial/univariate/dense.rs#L330
impl<'a, F: Field> AddAssign<&'a SparsePolynomial> for DensePolynomial at https://github.com/arkworks-rs/algebra/blob/97c7a4f4e8f5e297e397f6de09fe4764068deac0/poly/src/polynomial/univariate/dense.rs#L414
impl<'a, 'b, F: Field> Sub<&'a SparsePolynomial> for &'b DensePolynomial at https://github.com/arkworks-rs/algebra/blob/97c7a4f4e8f5e297e397f6de09fe4764068deac0/poly/src/polynomial/univariate/dense.rs#L490
impl<'a, F: Field> SubAssign<&'a SparsePolynomial> for DensePolynomial at https://github.com/arkworks-rs/algebra/blob/97c7a4f4e8f5e297e397f6de09fe4764068deac0/poly/src/polynomial/univariate/dense.rs#L546

We can submit a PR to ark_poly, get it merged, and then upgrade to the next release.
In the meantime, we can add a truncate_to_canonical_form() in our own Poly impls. This means we can't use derive_more macros, unless the underlying implementation is correct.

Currently this is fixed by depending on https://github.com/arkworks-rs/algebra/pull/638 via https://github.com/arkworks-rs/algebra/commit/8233e9a3fc63370aef65ed24e0c7f6e07dac43e6
We don't use SparsePolynomial, so this bug shouldn't happen to us.


Qutip has to get a fix so we can not use the latest version of numpy.…

… When fixed, we can remove the limit.

What are the issues this pull addresses (issue numbers / links)?
Qutip has an issue.  https://github.com/qutip/qutip/pull/1752 is the pull request that will help.  After this is available, we can remove the limit on numpy.
Did you add tests to cover your changes (yes/no)?
Did you update the documentation accordingly (yes/no)?
Did you read the CONTRIBUTING document (yes/no)?
Summary
Details and comments

Information from @mtreinish!  Thank you for the information.
There was a configuration format change in numpy made in their most recent release 1.22 (which they decided to release on Dec 31 and that happened to break how qutip was parsing the numpy config.

I don't need all of you to approve the pull request.  Just wanted you to know this is the fix.  As a sanity check, could one you use Metal with qutip and confirm all is behaving as desired?
In reflection, fixing this in tox wasn't logical since qutip is used in more than just testing.

When this is merged, issue #752 can be closed and branch can be deleted.

Should work fine, but couldn't finish testing due to EPR bug I ran into (though the two should be entirely unrelated)


tox.ini: Molecule has renamed its master branch

The devel test suite is failing due to trying to use the 'master'
branch, which is now called 'main'. Update tox.ini accordingly.
Signed-off-by: Arnaud Patard<EMAIL_ADDRESS>

@apatard I also did the same rename for this repo, you may want to do a grep and replace few other master strings with main ;)


Fix wrong parameter name in documentation comment

This is a very small pull request that fixes an inconsistency in the documentation comment of Sequence's filter() method.

@swift-ci Please smoke test


Better error messages on stream partition fetch errors

Codecov Report

Merging #2753 into master will increase coverage by 0.01%.
The diff coverage is 40%.

@@            Coverage Diff             @@
##           master    #2753      +/-   ##
==========================================
+ Coverage   68.53%   68.54%   +0.01%
==========================================
  Files         876      876
  Lines       42288    42290       +2
  Branches     5748     5748
==========================================
+ Hits        28980    28987       +7
+ Misses      11445    11439       -6
- Partials     1863     1864       +1

Impacted Files
Coverage Δ

...roller/helix/core/PinotTableIdealStateBuilder.java
66.41% <40%> (-0.25%)
:arrow_down:

.../impl/dictionary/FloatOnHeapMutableDictionary.java
86.66% <0%> (-6.67%)
:arrow_down:

...e/operator/dociditerators/SortedDocIdIterator.java
59.45% <0%> (-5.41%)
:arrow_down:

...not/broker/broker/helix/ClusterChangeMediator.java
62.71% <0%> (-3.39%)
:arrow_down:

...rEqualitiesToInClauseFilterQueryTreeOptimizer.java
93.33% <0%> (-2.67%)
:arrow_down:

...ot/core/query/pruner/ColumnValueSegmentPruner.java
88.13% <0%> (-1.7%)
:arrow_down:

...not/broker/requesthandler/RangeMergeOptimizer.java
89.7% <0%> (-1.48%)
:arrow_down:

.../com/linkedin/pinot/common/data/TimeFieldSpec.java
91.35% <0%> (-1.24%)
:arrow_down:

.../broker/routing/HelixExternalViewBasedRouting.java
90.33% <0%> (-1%)
:arrow_down:

...com/linkedin/pinot/core/common/DataBlockCache.java
78.04% <0%> (-0.82%)
:arrow_down:

... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d57001...b3f9117. Read the comment docs.


Integrate ToF sensor

Describe the bug
Put the ToF sensor such that the line of sight passes perfectly through the center of the grasp.

Abandoned.

Abandoned since there is no reason to use the ToF since grasping is fairly robust even without it.


File f = new File(list.get(i).getQueryUri()); ------> Not working

kindly provide me a solution

Try File f = new File(list.get(i).getOriginalPath()); ?

@NoelChew answer is correct.


Incorrect expected result for "generator iterator"

Factorial's expected output is "1, 5, 20, 60, 120", but actually it must be "1, 1, 2, 6, 24, 120". See http://en.wikipedia.org/wiki/Factorial

A little misunderstanding.
Iterate over 5! means:
step_1 = 1 = 1
step_2 = 5 * step_1 // 5 * 1 = 5
step_3 = 4 * step_2 // 4 * 5 * 1 = 20
step_4 = 3 * step_3  // 3 * 4 * 5 * 1 = 60
step_5 = 2 * step_4 // 2 * 3 * 4 * 5 * 1 = 120
And dosen't means: n! != 1! + 2! + ... n-1!
The task probably need better description.

Oh, I see. Then yes, surely description needs more clarification. But it's another issue.


Part Downloads

Is it possible to ensure partly downloaded files are not downloaded from the start.

I have looked into it, and it seems quite easy to implement: we pass the Range header with bytes=xxx- value, where xxx is the current file size. And we open the file in the append mode (so File.append, not File.write.
Here's a snipped to play with. I'm not a HTTP expect, but it looks okay to me. I did ctrl+c and restarted several times and still got full zip file downloaded. If noone sees any issues, I can add that to haxelib.
import haxe.io.Output;
import sys.io.File;

class Main {
    static function main() {
        var url = "http://lib.haxe.org/files/3.0/lime-2,0,0-alpha,8.zip";
        var f = File.append("lime.zip", true);
        f.seek(0, SeekEnd);
        var h = new haxe.Http(url);
        var cur = f.tell();
        if (cur > 0)
            h.addHeader("range", "bytes="+cur + "-");
        h.customRequest(false, new Progress(f, cur));
    }
}

class Progress extends Output {
    var o : Output;
    var cursize : Int;
    var cur : Int;
    var max : Int;

    public function new(o, cursize) {
        this.o = o;
        this.cursize = cursize;
        this.cur = cursize;
    }

    function report(n) {
        cur += n;
        if( max == null )
            Sys.print(cur+" bytes\r");
        else
            Sys.print(cur+"/"+max+" ("+Std.int((cur*100.0)/max)+"%)\r");
    }

    public override function writeByte(c) {
        o.writeByte(c);
        report(1);
    }

    public override function writeBytes(s,p,l) {
        var r = o.writeBytes(s,p,l);
        report(r);
        return r;
    }

    public override function close() {
        super.close();
        o.close();
        Sys.println("Download complete : "+cur+" bytes");
    }

    public override function prepare(m:Int) {
        max = m + cursize;
    }
}

Looks good to me,
just have to make sure that when the complete file is downloaded but is corrupted/incorrect it's deleted in order to not get stuck.


CODEOWNERS: add stigtsp to perl

Motivation for this change
Adding myself to Perl stuff
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Actually, it has no effect at all: I am not getting notified on perl-related PR or changes unless being explicitly pinged.


Update NTIA via command line

Note: This initial commit is currently failing with the following error:
Traceback (most recent call last):
spdx_dev  |   File "/spdxonlinetools/src/app/core.py", line 218, in ntia_check_helper
spdx_dev  |     response = dumps(ajaxdict)
spdx_dev  |   File "/usr/local/lib/python3.10/json/__init__.py", line 231, in dumps
spdx_dev  |     return _default_encoder.encode(obj)
spdx_dev  |   File "/usr/local/lib/python3.10/json/encoder.py", line 199, in encode
spdx_dev  |     chunks = self.iterencode(o, _one_shot=True)
spdx_dev  |   File "/usr/local/lib/python3.10/json/encoder.py", line 257, in iterencode
spdx_dev  |     return _iterencode(o, 0)
spdx_dev  |   File "/usr/local/lib/python3.10/json/encoder.py", line 179, in default
spdx_dev  |     raise TypeError(f'Object of type {o.__class__.__name__} '
spdx_dev  | TypeError: Object of type CompletedProcess is not JSON serializable
spdx_dev  |
spdx_dev  | During handling of the above exception, another exception occurred:
spdx_dev  |
spdx_dev  | Traceback (most recent call last):
spdx_dev  |   File "/usr/local/lib/python3.10/site-packages/django/core/handlers/exception.py", line 47, in inner
spdx_dev  |     response = get_response(request)
spdx_dev  |   File "/usr/local/lib/python3.10/site-packages/django/core/handlers/base.py", line 181, in _get_response
spdx_dev  |     response = wrapped_callback(request, *callback_args, **callback_kwargs)
spdx_dev  |   File "/spdxonlinetools/src/app/views.py", line 442, in ntia_check
spdx_dev  |     result = core.ntia_check_helper(request)
spdx_dev  |   File "/spdxonlinetools/src/app/core.py", line 273, in ntia_check_helper
spdx_dev  |     result['response'] = response
spdx_dev  | TypeError: 'CompletedProcess' object does not support item assignment
spdx_dev  | [14/Feb/2023 07:42:26] "POST /app/ntia_checker/ HTTP/1.1" 500 107033
spdx_dev  | /spdxonlinetools/src/app/core.py changed, reloading.
spdx_dev  | Watching for file changes with StatReloader
spdx_dev  | Performing system checks...

Closing in favor of #433


clustermesh: fix services cache bloat due to incorrect deletion

Due to a swap in the order of the parameters, deleted global services were never removed from the cache, which continued to grow in size. This commit fixes the issue and adds a new test to prevent regressions.
I'm marking this for backport to all versions, given that all are affected, and the change is trivial.

clustermesh: fix services cache bloat due to incorrect deletion

/test

/test-1.25-4.19

/test-1.26-net-next

/ci-verifier