7th Sea 2e update

Changes / Comments
Large update to the existing sheet design.  These changes were made over two years of regular play.
Modifications include:

Updated color scheme and logo (trade dressing)
Removed Roll Template for better representation of the system’s die roll (easier for sorting raises)
Internal die roll formula changes
Ship record includes support for Expanded Ship Rules PDF
Minor formatting and content changes to all pages
Hero Points counter fixed and goes to 9

Roll20 Requests
Include the name of the sheet you made changes to in the title.

If changes fix a bug or resolves a feature request, be sure to link to that issue.
For pull request that change multiple sheets please confirm these changes are intentional for all sheets. This will help us catch unintended submissions.
When updating existing sheets if you are changing attribute names please note what steps you have taken, if any, to assist players in keeping their data.

If your other update is the correct one, you could close this pull request. (Don't delete the branch, only close this pull request as it's redundant and contains errors anyway.)

You're aware that deleting files in a branch is not the same as closing a pull request?

Um…nope.  How do I close an old pull request?

On Mar 8, 2019, at 2:57 PM, Andreas J<EMAIL_ADDRESS>wrote:
You're aware that deleting files in a branch is not the same as closing a pull request?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/Roll20/roll20-character-sheets/pull/4793#issuecomment-471073699, or mute the thread https://github.com/notifications/unsubscribe-auth/AHfNHH02-tqDw3FwZF-SG8Cla7hnGr2Fks5vUs6egaJpZM4bhVry.

The "close pull request" button you be next to the button for making comments.
Visual guide:
https://help.github.com/en/articles/closing-a-pull-request

Greetings,
We've got two Pull Request updating similar code. What's going on with this PR and #4806 ? This update appears to be touching a number of more files than #4806.
Thanks,
Cassie

Hi Cassie,
Sorry, I’m out of town so I can’t check GitHub at the moment. I believe the latest update (patch-6) should include everything. All the files (html, css, png, Json, et al) are updated.
I apologize for the confusion. There was some github learning curve that needed to be overcome.
Tom H.
Sent from my iPhone

On Mar 11, 2019, at 11:03 AM, Cassie Levett<EMAIL_ADDRESS>wrote:
Greetings,
We've got two Pull Request updating similar code. What's going on with this PR and #4806 ? This update appears to be touching a number of more files than #4806.
Thanks,
Cassie
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

The other PR is the correct one, this was just the earlier one that we didn't manage to close, as per the above mentioned learning curve.


TagBot trigger issue

This issue is used to trigger TagBot; feel free to unsubscribe.
If you haven't already, you should update your TagBot.yml to include issue comment triggers.
Please see this post on Discourse for instructions and more details.
If you'd like for me to do this for you, comment TagBot fix on this issue.
I'll open a PR within a few hours, please be patient!

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/29274

TagBot fix

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/58722


web-scrobbler doesn't scrobble songs at odnoklassniki.ru

Hi David!
Tried to set up web-scrobbler for my father and found that it doesn't scrobble songs at odnoklassniki.ru which is my dad's favorite social network. At the same time it scrobbles songs at youtube etc so it works but not at odnoklassniki.ru
btw they changed url from odnoklassniki.ru to ok.ru and every time you type odnoklassniki.ru in address bar it redirects you to ok.ru - maybe this is the reason for this bug.
Could you please find some time for late night programming and fix it )

@d0ppe1ganger Hi, I added the new url. Hopefully it will work. If not, feel free to reopen this issue :)

David, looks like it's not working.
There's another issue referencing the same problem at https://github.com/david-sabata/web-scrobbler/issues/667, which also provides a solution. Could you take a look?

I can't confirm this. I just checked on the 1.49 release, and everything worked

I am using 1.50, fresh from Web Store. I have also disabled all sites except for Odnoklassniki, Vk, Youtube and the two Yandex services in the settings. Nothing scrobbles on Last.fm, I am getting no "now playing" notifications and no errors show up in the console.


Send body from forwardauth middleware

Welcome!

[X] Yes, I've searched similar issues on GitHub and didn't find any.
[X] Yes, I've searched similar issues on the Traefik community forum and didn't find any.

What did you expect to see?
Summary
We'd like to send http body to a forward auth external server optionally.
Background

I understand sending body could be an overhead. However, there are some situations which we'd like to entitle against an element of body.
To support the scenario, there is a community question which suggested to make a feature request and a PR
We will make a PR for this

Feature

Allow forwardauth middleware to send body to the configured external server (e.g. example.com/auth in the case) if forwardBody is true

  middlewares:
    test-auth:
      forwardauth:
        address: "https://example.com/auth"
        forwardBody: true

Hey @sokoide.
Thanks for your suggestion.
We are interested in this issue, but we’re unsure about the use case and the traction it will receive. We are going to leave the status as kind/proposal to give the community time to let us know if they would like this idea.
We will reevaluate as people respond.
Conversation is time-boxed to 6 months.

Hi @nmengin, thank you for the info. Our use case is as follows. I hope there are other use cases from the community.

We put Traefik in front of a backend server (e.g. alertmanager) which doesn't support auth/z
Traefik forwardauth middleware sends the request to forwardauth server to check the entitlement
forwardauth server needs the body, for example, when the backend server takes the following POST request and it allows/denies per userid in one of the headers and ldapgroup in labels in body

curl https://$host:$port/api/v1/rules/foo -X POST -d"
rules:
  - alert: test-alert
    labels:
      ldapgroup: foogroup
      severity: critical
" --key key.pem --cert cert.pem --cacert ca.pem

We've been looking at Traefik as a replacement for AWS API Gateway. We have at least two use cases where this functionality would be handy.

For validating webhook requests from third party vendors like Plaid where we are required to create a hash of the request body as part of the request validation.
For cases where we need to do resource entitlement checks based on the request. For example, consider the situation where you wanted to create a money transfer:

{
  fromAccount: "1234",
  toAccount: "5678"
}

We need to be able to answer the questions:

does user X have permission to call POST /transfers?
does user X have access to account "1234" and/or "5678"?

With those two use cases in mind, we also understand the concern to limit the amount of data that has to be put into memory to provide the entire request body. It might be of use to also include a request body size limit to prevent/limit malicious requests.

I'm also interested in this and am currently using this plugin: https://plugins.traefik.io/plugins/64013f94d969932157315511/body-forward-auth

We're also interested in this, we're planning to add request body hash verification support to our authServer and this will save us a lot of headache and we wouldn't have to write another middleware for this specific use case.


feat: forward pnp runtime if parent process uses pnp

If using https://yarnpkg.com/advanced/pnpapi, we need to propagate it to the worker. This adds Yarn PnP support to synckit.
Another solution is to just propagate the NODE_OPTIONS env var from the parent (this is probably a better solution).

Another solution is to just propagate the NODE_OPTIONS env var from the parent (this is probably a better solution).

NODE_OPTIONS seems much difficult to maintain because there could be things nothing related. Why do you think it could be the better solution?

I'll take a look tomorrow to see about adding a test case. There might be a better way to setup the  runtime as well. I can check with the yarn maintainers.

Besides, maybe you can take https://github.com/privatenumber/get-tsconfig/pull/28 and https://github.com/privatenumber/get-tsconfig/pull/32 as reference.

@JounQin this would almost fix the issue discussed in microsoft/vscode-eslint#1494. but I think because worker.mjs in the eslint-import-resolver-typescript is using ESM, it would also need the --experimental-loader flag added to execArgv with the path to .pnp.loader.mjs, if present, for it to fully solve the problem. I tried patching this locally with that extra flag and it worked.

@lachlanhunt If you want to progress it faster, you can raise a new PR to continue @noahnu's work.

Latest changes I pushed up seem to work even without the experimental loader added. I've posted in the yarn discord to get some feedback. Looking at test coverage now.

NODE_OPTIONS seems much difficult to maintain because there could be things nothing related. Why do you think it could be the better solution?

Devs use NODE_OPTIONS to configure the node process. When using child_process, these options propagate to child processes by default. I suspect folks would expect the same to be true of any workers spun out from a parent process.

hmm, not sure the best way to test this

hmm, not sure the best way to test this

Here's a simple test script I wrote while I was investigating the issue I encountered with the import resolver. It's based on the ESLint SDK script that yarn generates, and is able to show the same error that the ESLint extension shows in VSCode. You may be able to adapt this to run in the test suite, and to use synckit directly (rather than via the import resolver).
const { existsSync } = require(`fs`);
const { createRequire } = require(`module`);
const { resolve } = require(`path`);

const relPnpApiPath = '.pnp.cjs'; // Set this relative path to wherever .pnp.cjs is located.

const absPnpApiPath = resolve(__dirname, relPnpApiPath);
const absRequire = createRequire(absPnpApiPath);

if (existsSync(absPnpApiPath)) {
  if (!process.versions.pnp) {
    // Setup the environment to be able to require eslint
    require(absPnpApiPath).setup();
  }
}

void absRequire(`eslint-import-resolver-typescript`);

process.on('uncaughtException', err => {
  console.error('Uncaught error from worker', err);
  process.exit(1);
});

// Simple timeout to keep node alive while waiting for the worker thread to throw an error
setTimeout(() => console.log('PASS'), 100);

If you run node path-to-script.js (within a project using PnP), then it outputs the error. If you run yarn node path-to-script.js, then NODE_OPTIONS are set and automatically propagated to the worker, and it outputs PASS. In this case, .pnp.loader.mjs must also be present for it to pass. It fails without it.

My failed attempt at a test: https://github.com/noahnu/synckit/pull/1/files. I tried just running the sync directly without creating a new process but didn't have any luck so tried just recreating the full environment.. Didn't really work either.

https://github.com/un-ts/synckit/releases


vendorName not lowerCamel

The discovery command returns field vendorname instead of vendorName

Thanks Alvaro,
You are right on this and the name of property 'vendorname' should be camelCase 'vendorName'. We need to change YAML for the API document as the KAL tool is generating an internal structure for the messages programatically.
KAL raised a pull request 'API: Minor update/correction for the ServiceDiscovery #196' in the XFS GitHub.
Once it's resolved, we can update KAL SP framework to use correct property name.
Keep this issue opened until it's solved in the SP framework repository.

Hi Alvaro,
We are planning to add fix in the next package v0.0.2-alpha.2 including TextTerminal SP framework.
It will be published before next workshop planned on the 3rd August.

New package v0.0.2-alpha.2 addresses this issue.


swin transformer is very good in its paper,does vit-pytorch  has it?

@henbucuoshanghai it doesn't have it, since Swin already has a nice pytorch repository https://github.com/microsoft/Swin-Transformer

ok   tks
the vit.py  has no decoder????is it right?  the official paper only has encoder? has no decoder?


Adding wrapper for HttpClientHandler

This is referring to feature request #4
This provides tracing capabilities to HttpClient by passing in a custom HttpClientHandler. As part of this I pulled out the actual request/response processing into a utility class RequestUtil.
I placed this wrapper in project Amazon.XRay.Recorder.Handlers.System.Net although HttpClient is actually in the System.Net.Http namespace. I think it makes sense for it to live in the same project as HttpWebRequestTracingExtension, but please let me know if I should change the namespace to Amazon.XRay.Recorder.Handlers.System.Net.Http

Hi @ljacobsson,
Thank you for submitting pull requests. We would review it soon and also explore other options, if any for HttpClient.
Thanks,
Yogi


[BUG] S3 Disk string length to be >= 1

Version information

Laravel: v5.8.17
Voyager: v1.2.3
PHP: 7.2
Database: MySQL 8.0

Description

When using S3 as the default filesystem driver, you'll get this error when accessing the dashboard.
Found 1 error while validating the input provided for the GetObject operation: [Key] expected string length to be >= 1, but found string length of 0 (View: /public_html/main/vendor/tcg/voyager/resources/views/media/manager.blade.php)
Steps To Reproduce
Steps to reproduce the behavior:

Change file system driver to S3
Try to access admin dashboard
See error

Expected behavior
I should be able to have access to the admin dashboard without seeing this error message.

Twas fixed in #4170

Twas fixed in #4170


Back-end Login & Logout working

[ ] Backend Login:
[ ] Backend Logout:

Backend login works from GraphQL Explorer
Backend Logout:  None of the Module 21: MERN activities has backend logout logic.  It is all on the client side.

I'M CLOSING AS DONE


Add TensorRT engine to ONNX Runtime GPU documentation

What does this PR do?
This documentation addition clarifies the usage of the TensorRT engine. Note: https://github.com/huggingface/optimum/pull/653 is needed for the code samples to work.
Before submitting

[x] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

Relevant doc: https://moon-ci-docs.huggingface.co/docs/optimum/pr_657/en/onnxruntime/usage_guides/gpu#tensorrt-engine-build-and-warmup

@regisss Thank you for the review, much cleaner!


Forge stubbing doesn't work for non-forge forges

Previously in my spec_helper_acceptance.rb files I would do something like this:
proj_root = File.expand_path(File.join(File.dirname(__FILE__), '..'))
hosts.each do |host|
  puppet_module_install(:source => proj_root, :module_name => 'foo')
  on host, puppet('module', 'install', 'puppetlabs-concat'), { :acceptable_exit_codes => [0, 1] }
  ...
end

Then I saw the helpers in this module and figured I could just do instead:
install_module_on(hosts)
install_module_dependencies_on(hosts)

Much simpler and this means there's nothing module-specific in that file anymore and it moves closer to just boilerplate.
The problem is I have no direct internet access apart from via a proxy but I do have a local Artifactory instance that is configured with a forge-like repository, the base URL of which is http://artifactory.example.com/artifactory/api/puppet/puppet/.
Looking at the README I figured I could just do BEAKER_FORGE_HOST=http://artifactory.example.com/artifactory/api/puppet/puppet/ BEAKER_FORGE_API=... ... however this doesn't work as the forge stubbing just adds an /etc/hosts entry for the forge hostname(s) set to the (correct) IP address of my Artifactory instance, and thereby loses the extra path in the URL, (plus it insists on using HTTPS and fails because the SSL certificate is signed by our internal CA).
I've worked around this by adding the following:
hosts.each do |host|
  on host, puppet('config', 'set', '--section', 'main', 'module_repository', 'http://artifactory.example.com/artifactory/api/puppet/puppet')
end

which works however I still need to set the BEAKER_FORGE_HOST & BEAKER_FORGE_API variables due to https://github.com/puppetlabs/beaker-module_install_helper/blob/master/lib/beaker/module_install_helper.rb#L89-L104 doing a cheeky request and grabbing the list of module releases, so I'm stuck having to set the custom URL in both places.
Would it be worth making the stubbing a little more clever so it doesn't lose the URL path and scheme?

cc @puppetlabs/pdk

@bodgit  what are you setting for BEAKER_FORGE_API here? I'd like to test this with our Artifactory

@bodgit actually I realized the API issue as you mentioned is because of the PATH getting dropped.
But I just tested as I've been using the puppet config set before myself and is there any benefit or need using the 2 ENV variables if you are using the module_repository setting? Think that should take care of it making the ENV variables not necessary?

@cdenneen You still need to set at least one of the ENV variables (not sure which one) due to this bit of code https://github.com/puppetlabs/beaker-module_install_helper/blob/master/lib/beaker/module_install_helper.rb#L89-L104 as it goes directly to the API to retrieve the list of module releases before running puppet module install ... on the host, so it still needs to be configured in multiple places. (Note this bit doesn't drop any of the URL path, and you need to have a trailing / for the interpolation to work).
(Good to have someone else using Artifactory and hitting the same issues 😄)

@bodgit ah thanks... mine must be reaching out to public forge for this call. Between this and the https://github.com/voxpupuli/puppet-blacksmith/pull/66 we are on our way... much thanks for the work on this!


[TypeScript] Implement Dependency Injection in TypeScript bots

Purpose
What is the context of this pull request? Why is it being done?
Changes
Are there any changes that need to be called out as significant or particularly difficult to grasp? (Include illustrative screenshots for context if applicable.)
Tests
Is this covered by existing tests or new ones? If no, why not?
Feature Plan
Are there any remaining steps or dependencies before this issue can be fully resolved? If so, describe and link to any relevant pull requests or issues.
Checklist
General

[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have added or updated the appropriate tests
[ ] I have updated related documentation

Can you run the linter here?
Can you update the package-lock.json of each sample?

After these changes, we should migrate these to the generator (templates) and check the end-to-end using the VA/Skill of the generator.

I ran linter and I only got warnings.
Virtual Assistant warnings

Skill warnings

As you shown, there are some warnings that are potentially fixable with --fix option. It would be great to fix them and update the templates with that.
As a final step, you can validate the end-to-end using the generator. Don't forget to check the generator's test!

LGTM! Can you clean this branch?


create: boxplot and unit test

Please review the new function boxplot and unit test at your convenience. Thanks!

@georgezakinih I have updated the boxplot function as well as the unittest in another branch "boxplot_0830".
In the updated function, all your comments have been addressed, and new example plots were added, for your review.
So I closed this first pull request to preventing making you confused.


voronoi_plot_2d(vor,ax=ax) crashes due to deprecated ishold

When a matplotlib 3.0 axes is given, the function crashes due to the missing 'ishold' function.

gh-9234


[ESP32] Remove SupportedModes implementation of ModeSelect from nvs and use all-clusters-apps common implementation

Remove SupportedModes implementation of ModeSelect from nvs and use all-clusters-apps common implementation.
Tested esp32/all-clusters-app

Can you try any other example (lighting-app) as well?

@jadhavrohit924 This PR does not seem to explain WHY the implementation was removed.
I imagine common code is better than specific code, however it is still useful to actually explain changes. For example I do not understand why we got #34191 as a revert now. The history of this seems to be just "tested and it works fine" and it does not explain the intent behind the change (and revert is not explained either)

@andy31415 Sorry for the inconvenience. Actually, we thought of using common implementation and planned to remove this fixed attributes from the factory partition because of while OTA, we cannot update these attributes as factory partition can’t be change in OTA.
But later we thought of supporting this fixed attributes in the factory partition for backward compatibility along with SDKs common implementation which has static data.


Logo proposal

Greetings, I'm here today to offer my services. As a graphic designer in development and an open source enthusiast, I wish to contribute to this wonderful project by making a logo for it, the process (of course) is totally free and we would be working together to create the design that fits best with your project. Of course, you can quit whenever you want. In case you agree, I would like to ask you a few simple questions about your project to have a better understanding of it and so deliver a better product, also you could share with me any preferences you may have about colors, shapes, etc.
Sorry for disturbing if this is not the proper channel, kind regards.

Hey, thanks for the offer but a logo isn't really a top priority and time is limited (as you can see from the delay responding to this..) so probably not worth wasting your time on this :)


SERENE(CORE) error while updating customer

While trying the SERENE(CORE) with sample customer screen the below error is appearing, But Data is updated /Inserted to database and can retrieve
SCRIPT ERROR! See browser console (F12) for details.
Message: Error: Script data Lookup.Northwind.Customer is not found in registered script list!
File: http://localhost:59952/Scripts/serenity/Serenity.CoreLib.js?v=rbgJkLyDAsVUi5O9rfQr3w, Line: 1779, Column: 23
-------------------Console
Error: Script data Lookup.Administration.Language is not found in registered script list!
Serenity.CoreLib.js:1745:27
Error: Script data Lookup.Northwind.Customer is not found in registered script list!

After updating NPM and Node Js it is working fine nore with aspnetcore
There is slight issue in the installation manual where it is mentioned current version but in the screen preview it shows wrong version, I think the document needs to update with correct version


Validate the sharding relabel action

As discussed here, currently thanos sharding only supports three relabel actions. However, we use the relabel process function from Prometheus, which accepts other relabel actions as well, but actually these unsupported actions don't do anything.
It would be nice to have a check/validation on the relabel config. If the action is not supported by thanos, we can tell users this is not supported and return error.
AC:

Check the relabel config before the relabel process. If the configured action is not supported, tell the reason in the log and return error

Would like to have a go at this.

Go for it!
On Mon, 20 Apr 2020 at 06:02, Ranjith Kumar<EMAIL_ADDRESS>wrote:

Would like to have a go at this.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/thanos-io/thanos/issues/2468#issuecomment-616310393,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABVA3O3T3IOSN6KHRZPZ4RLRNPJOTANCNFSM4MMD3SDA
.

Unstale..

Still relevant AFAIK.


#623 Project Description text style is different in All Projects and CLA Project page

Solved UI issue.
Issue : 623

Signed-off-by: Amol Sontakke<EMAIL_ADDRESS>

@nirupamav Ready for review and re/test.

@dealako @amolsontakke3576
Verified that #623  is fixed


Update Build Code parsing for SotO

Added build code encoding/decoding for selectedWeapons and selectedSkillVariants
Added test case for new build code
Added tests to ensure old codes without those features are still parsed correctly
Updated dependencies to fix build
Update types to fix decode return type
(see GW2Treasures/gw2treasures.com#233)
Update encode type to only allow correct data for specified build type

ref: https://discord.com/channels/384735285197537290/384735523521953792/1145839295849046077

Btw @queicherius , is there a reason that the id is optional and allows for strings? encode('item', {}) or encode('item, 'foo') should fail when compiling already in my opinion.

Awesome, thank you for this huge effort.

Is there a reason that the id is optional and allows for strings?

I think that was a remainder of refactoring to TS and not intended.

Published as 1.4.0


Update FilesController.js

config was removed from calling createFile on adapter causing errors on save

Updated to 2.2.4 today via NPM and saving files was broken. Noticed this issue but wanted to confirm so re-opening

Which adapter is broken?

O gotcha I was using config for rack space and I saw S3 was using it as well in my node_modules but I can easily rewrite the rack space one to not use it.

https://github.com/parse-server-modules/parse-server-conformance-tests is the guideline for the files adapter, you can find plenty of examples across the https://github.com/parse-server-modules organization.
Sorry for the breaking change.

@mcclaskiem do you explicitly need the config or this was to match the API?

I was just trying to match the API at the time but I will go ahead and reconfigure my adapter. Thanks for the insight on updates!


Creating a reservation for capacity gives an error with GedisClientFactory

Following this documentation: https://github.com/threefoldfoundation/info_grid/blob/development/docs/capacity_reservation/README.md
Gives me an error when I run this command in JSX branch development
result = w.capacity.reserve_zos_vm(
<EMAIL_ADDRESS># the email on which you will received the connection information
    threebot_id='my3bot.example', # your threebot id, it can be any of the names you gave to your 3bot
    location='farm_name', # name of the farm or node id where to deploy the workload
    size=1) # each workload have a different size available

Stacktrace:

same error for me

same here

same here

@ahussein Should this also be moved to digitalmeX repo ?

yes!

Resolved on digitalmex (development branch).


Write a C program to convert days to hours

Description
Write a C program to convert days to hours
1 day = 24 hours
Input  : 5
Output : 120

How to contribute

Save the solution in program/ConvertDaysToHours.c file
Add ConvertDaysToHours.c file in convert-days-to-hours folder

!assign


Remove *Literal case in expr.DotExprToField

It's an unused and unwanted remnant of expr.DotExprToField's previous
life as expr.FieldExprToString.

I didn't realize that foo["bar"] relies this. Let's keep it.


Schema Registry URL with URL path does not work

Description
I am using confluent-kafka-dotnet library (Nuget Confluent.Kafka.Avro 0.11.6) for consuming Avro messages. We moved our infrastructure (Kafka broker (Image:confluentinc/cp-enterprise-kafka:5.0.0) , Schema Registry (confluentinc/cp-schema-registry:5.0.0), etc) to a Kubernetes cluster (Kubelet Version v1.10.6) where the schema-registry is behind an ingress now.
Therefore, when I want to test consuming Avro messages from the outside of the cluster (my Windows 10 machine), i need to set the schema-registry's ingress url on consumer side ( something like that: hostname:80/schema-registry/). However, it seems like that the library can't handle schema-registry URLs with URL paths well (it seems to request a different URL somehow and therefore it receives some HTML from the Kubernetes ingress handler instead of the expected Avro schema.).
However, calling the configured URL manually exposes the schema registries API as expected and using the Schema registry with an exposed Kubernetes-Node port works (e.g., hostname:30002)
Error message:
2019-05-13 15:14:31.9572 ERROR Job:  () Microsoft.Extensions.Logging.ILogger Message:OnConsumeError: System.AggregateException: One or more errors occurred. (Unexpected character encountered while parsing value: <. Path '', line 0, position 0.) ---> Newtonsoft.Json.JsonReaderException: Unexpected character encountered while parsing value: <. Path '', line 0, position 0.    at Newtonsoft.Json.JsonTextReader.ParseValue()    at Newtonsoft.Json.Linq.JObject.Load(JsonReader reader, JsonLoadSettings settings)    at Newtonsoft.Json.Linq.JObject.Parse(String json, JsonLoadSettings settings)    at Confluent.SchemaRegistry.RestService.ExecuteOnOneInstanceAsync(HttpRequestMessage request)    at Confluent.SchemaRegistry.RestService.RequestAsync[T](String endPoint, HttpMethod method, Object[] jsonBody)    at Confluent.SchemaRegistry.RestService.GetSchemaAsync(Int32 id)    --- End of inner exception stack trace ---    at System.Threading.Tasks.Task1.GetResultCore(Boolean waitCompletionNotification)
at Confluent.SchemaRegistry.CachedSchemaRegistryClient.GetSchemaAsync(Int32 id)
at Confluent.Kafka.Serialization.SpecificDeserializerImpl1.Deserialize(String topic, Byte[] array)    at Confluent.Kafka.Serialization.MessageExtensions.Deserialize[TKey,TValue](Message message, IDeserializer1 keyDeserializer, IDeserializer1 valueDeserializer) ---> (Inner Exception #0) Newtonsoft.Json.JsonReaderException: Unexpected character encountered while parsing value: <. Path '', line 0, position 0.    at Newtonsoft.Json.JsonTextReader.ParseValue()    at Newtonsoft.Json.Linq.JObject.Load(JsonReader reader, JsonLoadSettings settings)    at Newtonsoft.Json.Linq.JObject.Parse(String json, JsonLoadSettings settings)    at Confluent.SchemaRegistry.RestService.ExecuteOnOneInstanceAsync(HttpRequestMessage request)    at Confluent.SchemaRegistry.RestService.RequestAsync[T](String endPoint, HttpMethod method, Object[] jsonBody)    at Confluent.SchemaRegistry.RestService.GetSchemaAsync(Int32 id)<---
How to reproduce
Schema registry url contains ingress path like "hostname:80/schema-registry/"

see #677

I believe this should be resolved in 1.3.0-PRE1. If the problem persists, please update in #677.


Curate storage service

With image uploads now much easier to do, we should curate the ActiveStorage AWS bucket to keep storage costs as low as possible.

[x] Sweep orphaned blobs every day
[ ] Downsize original images to a manageable size (perhaps 800 x 800)
[ ] Image compression?
[ ] Allow for larger file sizes in uploads (since we'll downsize anyway)

See https://vitobotta.com/2020/09/24/resize-and-optimise-images-on-upload-with-activestorage/


Add guidance on how to get a dev/learning environment up and running

Something I've been meaning to look at is getting the ziti create config bits working for the controller and router. Now that you can embed files into go executables with go 1.16, we could put some templates in there.
Another nice thing would be to have a ziti init which could run the pki bits and config generation in one command.

Something I've been meaning to look at is getting the ziti create config bits working for the controller and router. Now that you can embed files into go executables with go 1.16, we could put some templates in there.
Another nice thing would be to have a ziti init which could run the pki bits and config generation in one command.

Both great ideas that I like. I started down the ziti create config path at the start but walked away from it for the timebeing. I think moving some/all/bits of this into ziti makes sense for sure.


Update fs2-core, fs2-io, ... to 3.1.5

Updates

co.fs2:fs2-core
co.fs2:fs2-io
co.fs2:fs2-reactive-streams

from 3.1.1 to 3.1.5.
GitHub Release Notes - Changelog - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "co.fs2" } ]

labels: library-update, semver-patch

Superseded by #528.


Automatically build docker images

We should automatically build docker images based on releases in master.
Likely can use something like this action: https://github.com/marketplace/actions/publish-docker (see "types: [published]").

Done via 360e3c71818761032a8c112700018e0b44443c87 and working! See v1.4.0.


[Feature Request] Search while typing

As the user types, searches should automatically be run. It's best to make it toggleable in "Settings".

Did you notice that the search input will provide you with a menu of search results that you can select, or do you have a problem with that.
In general linkding generates its HTML by rendering templates on the server, which means what you see in the browser is mostly going to be static, and any UI update requires a page refresh. For some interactive parts (auto-complete, and search) linkding uses some Javascript components to provide quick feedback without a reload. It's very unlikely that this paradigm is going to change, as it is simple to maintain and mostly works very well for the use-cases that linkding has. Closing this for now, if you have an issue with the search input not providing helpful results, please file an issue for that.

Yeah, I ended up patching it to add more configurable options for auto-complete and left it at that.

@DUOLabs333 Care to share, or do you have a fork? I think search is one of the top features, so if there is an opportunity to enhance it, I'm willing to take a look.

It's not that much of an improvement --- I just added options to search by title, by URL, by description, or by all three (the default).

It seems autocomplete doesn't kick in before 3 characters.

Just noting that this is intended, and a common behavior for searching. Otherwise you get lots of irrelevant stuff.

What if the title is only two characters long? Maybe offer a setting for it, with 3 as the default?


Payouts Query Issue

Issue not about this package only, but API in general.
When fetching payouts data getting access denied Error. (Either via REST or GraphQL api)
Details:
Store type - development store.
Access scopes -
App has been granted read_shopify_payments_payouts and read_shopify_payments_disputes.
In doc mentioned, that for being able to fetch payouts data, your app/token need to be granted read_shopify_payments link, but looks like its a typo, as we don’t have such scope link to the access scopes list also when we try to use this scope name in auth process we getting an error,  I assume it means read_shopify_payments_payouts scope.
Query:
shopifyPaymentsAccount {
      payouts(first: 10) {
        pageInfo {
          hasNextPage
          hasPreviousPage
        }
        edges {
          cursor
          node {
            id
            status
          }
        }
      }
    }
  }

Also tried to fetch this data from shop.shopifyPaymentsAccount,- facing  the same error.
P.S. Successfully fetching data related to other granted scopes (orders, customers, products)
Will be glad to get help or any ideas ab. this issue.

This endpoint isn't exposed in GraphQL yet, it's mistakenly exposed in documentation. Thanks for flagging this, we'll have to update the docs.


WebRTC not working with simple push

I get the next output:
s, avg 0KB/s up 0KB/s down. Tags: [UA:Mozilla/5.0 (OBS-Studio/30.2.3; Windows x86_64; es-ES)]

[2024-10-02 12:07:50] MistController (8) STRM: Updated stream whip

[2024-10-02 12:08:18] MistOutWebRTC:whip (198) WARN: No SDP::MediaFormat found for encoding name RED.

[2024-10-02 12:08:18] MistOutWebRTC:whip (198) WARN: No SDP::MediaFormat found for encoding name ULPFEC.

[2024-10-02 12:08:47] MistController (8) ACCS: Session <I467fbc416726d4326dd3b98ef0dfcaa700bf3f8b264b80dc3e6b0c525c0afa71> whip (INPUT:WebRTC) from <IP_ADDRESS> ended after 27s, avg 0KB/s up 0KB/s down.

I am just following the OBS WebRTC Example
After 27s the server disconnects the streaming after "waiting for data"
My OBS and mistserver config looks like:

I get:
[2024-10-03 19:38:37] MistOutWebRTC (994) FAIL: Could not get destination for UDP socket
[2024-10-03 19:38:37] MistOutWebRTC (994) FAIL: Failed to bind socket 0 (Unspecified) :0: Address family not supported by protocol
[2024-10-03 19:38:37] MistOutWebRTC (994) FAIL: Could not get destination for UDP socket
[2024-10-03 19:38:37] MistOutWebRTC (994) FAIL: Failed to bind socket 0 (Unspecified) :0: Address family not supported by protocol
[2024-10-03 19:38:38] MistOutWebRTC (994) FAIL: Could not get destination for UDP socket
[2024-10-03 19:38:38] MistOutWebRTC (994) FAIL: Failed to bind socket 0 (Unspecified) :0: Address family not supported by protocol
[2024-10-03 19:38:40] MistOutWebRTC (994) FAIL: Could not get destination for UDP socket
[2024-10-03 19:38:40] MistOutWebRTC (994) FAIL: Failed to bind socket 0 (Unspecified) :0: Address family not supported by protocol
[2024-10-03 19:38:44] MistOutWebRTC (994) FAIL: Could not get destination for UDP socket
[2024-10-03 19:38:44] MistOutWebRTC (994) FAIL: Failed to bind socket 0 (Unspecified) :0: Address family not supported by protocol

using windows mistserver

Getting the next error when using linux provided build:
FAIL: Cannot enable video; codec not found H264,VP9,VP8.

Hey there!
Ah, that explains the issues you've been experiencing. Sadly enough Windows UDP sockets were different enough that we couldn't get them to work properly for WebRTC ingest. We did spot a method to rework the way UDP sockets are handled by our code to "fix" this, but that would've delayed the Windows builds for quite some time "yet again". So we decided to release it with the warning that currently WebRTC ingest would not work.
If you want to run MistServer with WebRTC you'll have to use a Linux build. Now technically you can use Docker for it, but due to how Docker works it would mean everything gets processed twice by the network interface. So you can effectively work with only half your network cards capabilities.

Yeah I have explained myself quite bad. I tried all builds, windows, linux and docker (both compiled and binaries), it won't work for either of them. I am probably doing somethig wrong even after carefuly following the OBS-WebRTC tutorial
Sorry for opening this many issues but I am struggling somehow haha, thanks

In the meantime I am using RTPM (no SSL since I am getting handshake errors)

Ah, well I can help out with the Linux/Docker side of things at least.
And no worries about opening issues, we do monitor Github slightly less than our mail, but we're always happy to try and help out where/how we can.
For WebRTC there's a few things that can be blocking the proper usage of it. I'll also add some tips for playback as you'll likely need those at some point as well.
Binding of network interfaces (Internal & Public) (Playback & Pushing)
Now this one is slightly on us for not having made it better yet, but there's an internal and public UDP bind. These determine over what interface you receive and sent out WebRTC data. Internal is receiving, Public is for sending out.

The UDP internal bind should be attempting to bind all interfaces through <IP_ADDRESS> as that would mean you can accept incoming WebRTC connections over any interface.
The UDP public bind should be the network interface that your users will connect over. Should this be public internet it should match the interface that is connected to the internet. Should it be LAN it should go to your LAN interface, etc.

As an example here's the bind setting for one of our test servers. As a slight note: While testing I would recommend setting the debug level to 4. It would give all relevant information for connections/failed attempts and binds. While in production I recommend 3 or lower as those messages could slow the system somewhat.

There's 2 WebRTC outputs, WebRTC (WS) and WebRTC (WHIP)  (Playback)
The difference is that WebRTC (WS) is our version of WebRTC before WHIP/WHEP became a standardization. We do not have a WebRTC (WHEP) player included yet. For now we would recommend using something like the online demo from Eyevinn.
Make sure to press WHEP, fill in the URL and finally press Play though!
Reverse Proxy (Playback & Pushing)
Reverse proxies need some setup as well. The forward settings available here should work in most cases.
Try HTTP & IPv4 addresses (Playback & Pushing)
This sounds weird as almost everything is HTTPS nowadays, but you can run WebRTC just fine over HTTP. When sending you cannot use a Camera if you're using a browser. But if you're using OBS that restriction isn't there. Same for watching, you can view WebRTC over HTTP just fine. It can be a good test as it would allow you to Wireshark the connection to see if you can spot where it breaks up or use the developer console for slightly more information.
Getting WebRTC to work in HTTP is a good first step before adding SSL and certificates into the mess. Though I see you have already attempted this for pushing with OBS.
Another note would be to forcefully fill in an IPv4 address. Using localhost will point towards IPv6 for most devices, if you're using <IP_ADDRESS> you can force it over IPv4. That said connections "should" first try IPv6, fail and then go to IPv4. We have seen cases where this fails however if the device only points to IPv6 using localhost.
Ephemeral range (Playback & Pushing)
The Ephemeral range is used for WebRTC. For Linux this usually is ports 32768-61000, however it can differ depending on OS and version. So double-checking your ephemeral range is a good idea.
This also means that for using WebRTC this port range should be open for the server on UDP. As any of these ports can be used at random and if they're blocked the connection cannot take place.
Usually the following command in Linux should tell you your range: sysctl net.ipv4.ip_local_port_range
To be absolutely sure and how to change it I would recommend looking it up for your specific OS.
VPN or non-standard network conditions (Playback & Pushing)
So this one might be a bit of a stretch, but if you're using a VPN it could mean that WebRTC is failing simply because the packet sizes are bigger than 1200. I believe we've set our max to 1280, however we forgot that some additional header data gets added. Which means that the RTP packets can be slightly over 1300.
To not go into too much detail about networking, that means that in some network conditions these packets will be dropped and we should've  made the RTP packets lower than ~1200.
An development patch has been made to make this adjustable, but chances are that if you're in somewhat of a non-standard network environment this is a reason why it's not working. I can send you a development build in that case.
Thinking about it, chances are Docker is hit by this as well...

Hey @Rokamun thanks for the detailed description. Even with that it doesn't work for me and I don't know why.
Serverlog:
Mon 21 Oct 2024, 16:34:40 | MEDIUM | Checking input SRT: SRT (/*.vtt)
Mon 21 Oct 2024, 16:34:40 | MEDIUM | Checking input TS: TS (/*.ts)
Mon 21 Oct 2024, 16:34:40 | MEDIUM | Checking input TS: TS (/*.m2ts)
Mon 21 Oct 2024, 16:34:40 | MEDIUM | Checking input TS: TS (stream://*.ts)
Mon 21 Oct 2024, 16:34:40 | MEDIUM | Checking input TS: TS (tsudp://*)
Mon 21 Oct 2024, 16:34:40 | MEDIUM | Checking input TS: TS (ts-exec:*)
Mon 21 Oct 2024, 16:34:40 | MEDIUM | Checking input TS: TS (http://*.ts)
Mon 21 Oct 2024, 16:34:40 | MEDIUM | Checking input TS: TS (http-ts://*)
Mon 21 Oct 2024, 16:34:40 | MEDIUM | Checking input TS: TS (https://*.ts)
Mon 21 Oct 2024, 16:34:40 | MEDIUM | Checking input TS: TS (https-ts://*)
Mon 21 Oct 2024, 16:34:40 | MEDIUM | Checking input TSSRT: TSSRT (srt://*)
Mon 21 Oct 2024, 16:34:40 | INFO | Not a media provider for input: push://
Mon 21 Oct 2024, 16:34:40 | INSANE | Closing page MstCapa in client mode
Mon 21 Oct 2024, 16:34:40 | INSANE | Opening page MstSCnftest in client mode without auto-backoff
Mon 21 Oct 2024, 16:34:40 | DONTEVEN | Field dtsc_data: type 80, size 94, offset 0
Mon 21 Oct 2024, 16:34:40 | INSANE | Closing page MstSCnftest in client mode
Mon 21 Oct 2024, 16:34:40 | INSANE | Opening page MstGlobalConfig in client mode with auto-backoff
Mon 21 Oct 2024, 16:34:40 | DONTEVEN | Field defaultStream: type 51, size 128, offset 0
Mon 21 Oct 2024, 16:34:40 | DONTEVEN | Field systemBoot: type 23, size 8, offset 128
Mon 21 Oct 2024, 16:34:40 | INSANE | Closing page MstGlobalConfig in client mode
Mon 21 Oct 2024, 16:34:40 | INSANE | Opening page MstTRGRDEFAULT_STREAM in client mode without auto-backoff
Mon 21 Oct 2024, 16:34:40 | VERYHIGH | No triggers for DEFAULT_STREAM found
Mon 21 Oct 2024, 16:34:40 | INFO | Failing '/webrtc/test': Stream open failed
Mon 21 Oct 2024, 16:34:40 | FAIL | onFail 'test': Stream open failed
Mon 21 Oct 2024, 16:34:40 | HIGH | Socket 1 closed
Mon 21 Oct 2024, 16:34:40 | INFO | Failing '/': Could not connect to stream
Mon 21 Oct 2024, 16:34:40 | FAIL | onFail 'test': Could not connect to stream
Mon 21 Oct 2024, 16:34:40 | MEDIUM | initialize
Mon 21 Oct 2024, 16:34:40 | INSANE | Opening page MstSTATEtest in client mode without auto-backoff
Mon 21 Oct 2024, 16:34:40 | INSANE | Opening page MstSCnftest in client mode without auto-backoff
Mon 21 Oct 2024, 16:34:40 | DONTEVEN | Field dtsc_data: type 80, size 94, offset 0
Mon 21 Oct 2024, 16:34:40 | INSANE | Opening page MstTRGRSTREAM_LOAD in client mode without auto-backoff
Mon 21 Oct 2024, 16:34:40 | VERYHIGH | No triggers for STREAM_LOAD found
Mon 21 Oct 2024, 16:34:40 | INSANE | Opening page MstTRGRSTREAM_SOURCE in client mode without auto-backoff
Mon 21 Oct 2024, 16:34:40 | VERYHIGH | No triggers for STREAM_SOURCE found
Mon 21 Oct 2024, 16:34:40 | INSANE | Opening page MstCapa in client mode without auto-backoff
Mon 21 Oct 2024, 16:34:40 | DONTEVEN | Remapped handle for page MstCapa from 1 to 4!
Mon 21 Oct 2024, 16:34:40 | DONTEVEN | Field dtsc_data: type 80, size 91649, offset 0
Mon 21 Oct 2024, 16:34:40 | MEDIUM | Checking input Balancer: Balancer (balance:*)
Mon 21 Oct 2024, 16:34:40 | MEDIUM | Checking input Buffer: Buffer (push://*)
Mon 21 Oct 2024, 16:34:40 | MEDIUM | Checking input DTSC: DTSC (/*.dtsc)
Mon 21 Oct 2024, 16:34:40 | MEDIUM | Checking input DTSC: DTSC (dtsc://*)
Mon 21 Oct 2024, 16:34:40 | MEDIUM | Checking input EBML: EBML (/*.mkv)
Mon 21 Oct 2024, 16:34:40 | MEDIUM | Checking input EBML: EBML (/*.mka)
Mon 21 Oct 2024, 16:34:40 | MEDIUM | Checking input EBML: EBML (/*.mk3d)
Mon 21 Oct 2024, 16:34:40 | MEDIUM | Checking input EBML: EBML (/*.mks)
Mon 21 Oct 2024, 16:34:40 | MEDIUM | Checking input EBML: EBML (/*.webm)
Mon 21 Oct 2024, 16:34:40 | MEDIUM | Checking input EBML: EBML (mkv-exec:*)
Mon 21 Oct 2024, 16:34:40 | MEDIUM | Checking input FLV: FLV (/*.flv)
Mon 21 Oct 2024, 16:34:40 | MEDIUM | Checking input Folder: Folder (/*/)
Mon 21 Oct 2024, 16:34:40 | MEDIUM | Checking input H264: H264 (h264-exec:*)
Mon 21 Oct 2024, 16:34:40 | MEDIUM | Checking input HLS: HLS (/*.m3u8)
Mon 21 Oct 2024, 16:34:40 | MEDIUM | Checking input HLS: HLS (/*.m3u)
Mon 21 Oct 2024, 16:34:40 | MEDIUM | Checking input HLS: HLS (http://*.m3u8)
Mon 21 Oct 2024, 16:34:40 | MEDIUM | Checking input HLS: HLS (http://*.m3u)
Mon 21 Oct 2024, 16:34:40 | MEDIUM | Checking input HLS: HLS (https://*.m3u8)
Mon 21 Oct 2024, 16:34:40 | MEDIUM | Checking input HLS: HLS (https://*.m3u)
Mon 21 Oct 2024, 16:34:40 | MEDIUM | Checking input HLS: HLS (https-hls://*)
Mon 21 Oct 2024, 16:34:40 | MEDIUM | Checking input HLS: HLS (http-hls://*)
Mon 21 Oct 2024, 16:34:40 | MEDIUM | Checking input ISMV: ISMV (/*.ismv)
Mon 21 Oct 2024, 16:34:40 | MEDIUM | Checking input MP3: MP3 (/*.mp3)
Mon 21 Oct 2024, 16:34:40 | MEDIUM | Checking input MP4: MP4 (/*.mp4)
Mon 21 Oct 2024, 16:34:40 | MEDIUM | Checking input OGG: OGG (/*.ogg)
Mon 21 Oct 2024, 16:34:40 | MEDIUM | Checking input Playlist: Playlist (*.pls)
Mon 21 Oct 2024, 16:34:40 | MEDIUM | Checking input RTSP: RTSP (rtsp://*)
Mon 21 Oct 2024, 16:34:40 | MEDIUM | Checking input SRT: SRT (/*.srt)
Mon 21 Oct 2024, 16:34:40 | MEDIUM | Checking input SRT: SRT (/*.vtt)
Mon 21 Oct 2024, 16:34:40 | MEDIUM | Checking input TS: TS (/*.ts)
Mon 21 Oct 2024, 16:34:40 | MEDIUM | Checking input TS: TS (/*.m2ts)
Mon 21 Oct 2024, 16:34:40 | MEDIUM | Checking input TS: TS (stream://*.ts)
Mon 21 Oct 2024, 16:34:40 | MEDIUM | Checking input TS: TS (tsudp://*)
Mon 21 Oct 2024, 16:34:40 | MEDIUM | Checking input TS: TS (ts-exec:*)
Mon 21 Oct 2024, 16:34:40 | MEDIUM | Checking input TS: TS (http://*.ts)
Mon 21 Oct 2024, 16:34:40 | MEDIUM | Checking input TS: TS (http-ts://*)
Mon 21 Oct 2024, 16:34:40 | MEDIUM | Checking input TS: TS (https://*.ts)
Mon 21 Oct 2024, 16:34:40 | MEDIUM | Checking input TS: TS (https-ts://*)
Mon 21 Oct 2024, 16:34:40 | MEDIUM | Checking input TSSRT: TSSRT (srt://*)
Mon 21 Oct 2024, 16:34:40 | INFO | Not a media provider for input: push://
Mon 21 Oct 2024, 16:34:40 | INSANE | Closing page MstCapa in client mode
Mon 21 Oct 2024, 16:34:40 | INSANE | Opening page MstSCnftest in client mode without auto-backoff
Mon 21 Oct 2024, 16:34:40 | DONTEVEN | Remapped handle for page MstSCnftest from 1 to 4!
Mon 21 Oct 2024, 16:34:40 | DONTEVEN | Field dtsc_data: type 80, size 94, offset 0
Mon 21 Oct 2024, 16:34:40 | INSANE | Closing page MstSCnftest in client mode
Mon 21 Oct 2024, 16:34:40 | INSANE | Opening page MstGlobalConfig in client mode with auto-backoff
Mon 21 Oct 2024, 16:34:40 | DONTEVEN | Remapped handle for page MstGlobalConfig from 1 to 4!
Mon 21 Oct 2024, 16:34:40 | DONTEVEN | Field defaultStream: type 51, size 128, offset 0
Mon 21 Oct 2024, 16:34:40 | DONTEVEN | Field systemBoot: type 23, size 8, offset 128
Mon 21 Oct 2024, 16:34:40 | INSANE | Closing page MstGlobalConfig in client mode
Mon 21 Oct 2024, 16:34:40 | INSANE | Opening page MstTRGRDEFAULT_STREAM in client mode without auto-backoff
Mon 21 Oct 2024, 16:34:40 | VERYHIGH | No triggers for DEFAULT_STREAM found
Mon 21 Oct 2024, 16:34:40 | INFO | Failing '/': Stream open failed
Mon 21 Oct 2024, 16:34:40 | FAIL | onFail 'test': Stream open failed
Mon 21 Oct 2024, 16:34:40 | INFO | Failing '/': Could not connect to stream
Mon 21 Oct 2024, 16:34:40 | FAIL | onFail 'test': Could not connect to stream
Mon 21 Oct 2024, 16:34:40 | INFO | Client handler shutting down, exit reason: Stream open failed
Mon 21 Oct 2024, 16:34:40 | INSANE | Opening page MstTRGRCONN_CLOSE in client mode without auto-backoff
Mon 21 Oct 2024, 16:34:40 | VERYHIGH | No triggers for CONN_CLOSE found
Mon 21 Oct 2024, 16:34:40 | MEDIUM | disconnect
Mon 21 Oct 2024, 16:34:40 | DONTEVEN | /build/library/ssl_tls.c:7642: => free
Mon 21 Oct 2024, 16:34:40 | DONTEVEN | /build/library/ssl_tls.c:7711: <= free

OBS Log:
16:34:40.402: encoder 'advanced_video_stream': Cannot apply a new video_t object after the encoder has been initialized
16:34:40.402: encoder 'advanced_video_stream': Cannot set the scaled resolution after the encoder has been initialized
16:34:40.402: encoder 'advanced_video_stream': Cannot enable GPU scaling after the encoder has been initialized
16:34:40.586: [obs-webrtc] [whip_output: 'adv_stream'] Connect failed: HTTP endpoint returned response code 404
16:34:40.586: [obs-webrtc] [whip_output: 'adv_stream'] PeerConnection state is now: Closed
16:34:40.587: ==== Streaming Stop ================================================

I tried setting the internal IP address and the public address. Tried http and https.
Opening the URL in Browser just got me (I know; useless):
Could not retrieve stream: Stream open failed

Protocols:
Apple segmented over HTTP (HLS) | Enabled | username: root
MP4 over HTTP | Enabled | username: root
RTMP | Active | acceptable: 0, interface: <IP_ADDRESS>, port: 1935, username: root
HTTPS (HTTP+TLS) | Active | cert: /etc/letsencrypt/live/xxxxxx/fullchain.pem, key: /etc/letsencrypt/live/xxxxxx/privkey.pem, interface: <IP_ADDRESS>, port: 443, pubaddr: https://xxxxxx/, username: root
HTTP | Active | certbot: xxxxxxxxxxxxxxxxx, interface: <IP_ADDRESS>, port: 8080, pubaddr: https://xxxxxx/, username: root |
WebRTC | Enabled | bindhost: <IP_ADDRESS>, debug: 10, jitterlog: true, losttimeout: 30, losttimeoutmobile: 90, nacktimeout: 5, nacktimeoutmobile: 15, packetlog: true, preferredaudiocodec: opus,ALAW,ULAW, preferredvideocodec: H264,VP9,VP8, pubhost: x.x.x.x, username: root


batteader9.py

batteader9.py

https://www.programcreek.com/python/example/101393/machine.ADC
https://github.com/micropython/micropython/issues/2352
https://forum.micropython.org/viewtopic.php?t=3054

using the built in read vcc adc will not work well for battery testing because all esp's are 3.3v and have a regulator ... a external circuit connected to the external adc should be designed into the OttoDIYESPShield


added acme-account-creation-tool in missing places

https://github.com/ibm-cloud-security/acme-account-creation-tool/issues/17


Integrate Avalanche

IT could be interesting to integrate Avalanche

The task here is to write the deployment scripts. Avalanche supports Ethererum API, so the following config file works:
name: "ethereum"
nodes:
  - <IP_ADDRESS>:9650/ext/bc/C/ws
key_file: "./scripts/sample/keys.json"
window: 3

Perfect!


[BUG] TextView is not visible if default dimensions are set

Bug description
Please provide a code sample as small as possible which reproduces the bug.
use gtk::prelude::*;
use gtk::{Application, ApplicationWindow, Orientation, TextBuffer, TextView};
const APP_ID: &str = "org.gtk_rs.test";

fn main() {
    let app = Application::builder().application_id(APP_ID).build();
    app.connect_activate(build_ui);
    app.run();
}

fn build_ui(app: &Application) {
    let buffer = TextBuffer::builder()
        .text("Buffer")
        .build();
    let text_view = TextView::builder()
        .buffer(&buffer)
        .build();

    let gtk_box = gtk::Box::builder()
        .orientation(Orientation::Vertical)
        .build();

    gtk_box.append(&text_view);

    let window = ApplicationWindow::builder()
        .application(app)
        .default_width(400)
        .default_height(500)
        .title("Test")
        .child(&gtk_box)
        .build();

    window.present();
}

Expected result: text_view is visible
Actual result: the window is completely blank

Not setting default dimensions or resizing the window manually fixes the issue. Not using a container also helps. I'm new to GTK so take this code with a grain of salt, maybe I'm not using some of those widgets properly
Environment:
gtk = { version = "0.4.8", package = "gtk4" }

pkg-config --modversion gtk4
4.6.6

that looks correct to me, but the result seems to be problematic. You might want to report that upstream instead as it is not a bindings problem

You're right, looks like it's an old and unattended upstream issue:
https://gitlab.gnome.org/GNOME/gtk/-/issues/3635
Closing


Doesn't work in IE11

Chrome
<IP_ADDRESS> - - [27/Feb/2015 00:53:49] "GET /pixel/0/7/132/0/0 HTTP/1.1" 200 -
<IP_ADDRESS> - - [27/Feb/2015 00:53:49] "GET /show HTTP/1.1" 200 -
<IP_ADDRESS> - - [27/Feb/2015 00:53:49] "GET /pixel/1/7/132/0/0 HTTP/1.1" 200 -
<IP_ADDRESS> - - [27/Feb/2015 00:53:49] "GET /show HTTP/1.1" 200 -
<IP_ADDRESS> - - [27/Feb/2015 00:53:49] "GET /pixel/2/7/132/0/0 HTTP/1.1" 200 -
<IP_ADDRESS> - - [27/Feb/2015 00:53:51] "GET /show HTTP/1.1" 200 -
IE11 (Desktop and Windows Phone 8.1)
<IP_ADDRESS> - - [27/Feb/2015 00:54:47] "GET /pixel/0/7/132/0/0 HTTP/1.1" 200 -
<IP_ADDRESS> - - [27/Feb/2015 00:54:48] "GET /pixel/1/7/132/0/0 HTTP/1.1" 200 -
<IP_ADDRESS> - - [27/Feb/2015 00:54:48] "GET /pixel/2/7/132/0/0 HTTP/1.1" 200 -
IE is missing the /show [pun intended? :)]
unicorn-paint.js
function update_pixels(){
    var changed = false;
    $('td').each(function( index, obj ){
            if( $(obj).data('changed') ){
                    $(obj).data('changed',false);
                    changed = true;

                    var x = $(this).index();
                    var y = $(this).parent().index();
                    var col = tinycolor($(obj).css('background-color')).toRgb();

                    var data = [x,y,col.r,col.g,col.b];

                    $.get('/pixel/' + data.join('/'));
            }
    });
    if(changed){
            $.get('/show');
    }

Sorry! I haven't had the time to look into this yet, but it's not forgotten!


[CFF] Support conditional operators

Looks like they are rarely used, so no need to hurry. opentype.js and fonttools doesn't support them too.

Out of scope.


Issue 2099 | Unified way of accessing security keywords

Checklist

[ ] Type annotations added to new functions
[ ] Docs added to functions touched in main classes
[ ] Dry-run produced the expected results
[ ] The to-be-announced tag added if this is worth announcing

This is intended to fix this - https://github.com/mozilla/bugbot/issues/2099

Thank you, @shubham-s-del!
Could you please link to the issue in the PR description?1
Did you do a dry-run test? Once you have done that, please check the "Dry-run produced the expected results" item in the description.
Footnotes

https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue ↩

Thanks for the review.
Sorry for the late reply.
added to the description.
Could you help me with steps to do the dry run test?

Thank you!

Could you help me with steps to do the dry run test?

You can do a dry run by running python -m bugbot.rules.RUE_NAME, example:
python -m bugbot.rules.crash_small_volume

Before that you need to create a configuration file. See https://github.com/mozilla/bugbot#running-the-bot-rules
Just make sure to replace bz_api_key with your token from Bugzilla.

I see a 403 from crash-stats API.
requests.exceptions.HTTPError: 403 Client Error: Forbidden for url: https://crash-stats.mozilla.org/api/SuperSearch/?date=%3E%3D2024-01-04&date=%3C2024-01-11&signature=%5EEMPTY%3A+&signature=%5EOOM+&signature=%3DIPCError-browser+%7C+ShutDownKill&signature=%5Ejava.lang.OutOfMemoryError&_results_number=0&_facets_size=1000

Do I need LDAP or phabricator key for this too?

I see a 403 from crash-stats API.
requests.exceptions.HTTPError: 403 Client Error: Forbidden for url: https://crash-stats.mozilla.org/api/SuperSearch/?date=%3E%3D2024-01-04&date=%3C2024-01-11&signature=%5EEMPTY%3A+&signature=%5EOOM+&signature=%3DIPCError-browser+%7C+ShutDownKill&signature=%5Ejava.lang.OutOfMemoryError&_results_number=0&_facets_size=1000

You need a key for crash-stats to run crash_small_volume: https://crash-stats.mozilla.org/api/tokens/.

Do I need LDAP or phabricator key for this too?

No, you don't need them for security_unhide_dups or crash_small_volume.

I see a 403 from crash-stats API.
requests.exceptions.HTTPError: 403 Client Error: Forbidden for url: https://crash-stats.mozilla.org/api/SuperSearch/?date=%3E%3D2024-01-04&date=%3C2024-01-11&signature=%5EEMPTY%3A+&signature=%5EOOM+&signature=%3DIPCError-browser+%7C+ShutDownKill&signature=%5Ejava.lang.OutOfMemoryError&_results_number=0&_facets_size=1000

You need a key for crash-stats to run crash_small_volume: https://crash-stats.mozilla.org/api/tokens/.

Do I need LDAP or phabricator key for this too?

No, you don't need them for security_unhide_dups or crash_small_volume.

Thanks
I did a dry-run, gist containing the result = https://gist.github.com/shubham-s-del/1530df5f287c621d863c79ab63c0c317


Revert 3DS URL Parsing for CardResult

Summary of changes

Reference iOS PR: https://github.com/paypal/paypal-ios/pull/254
CardPayments

Add status property to CardResult
Add didAttemptThreeDSecureAuthentication property to CardResult

Breaking Changes

CardPayments

Remove liabilityShift property from CardResult

Checklist

[x] Added a changelog entry

Authors

List GitHub usernames for everyone who contributed to this pull request.

@sshropshire

Would we need to wait until the next major version to introduce a breaking change? Could we mark liabilityShift as deprecated for this PR?

@tdchow It's also marked as breaking on iOS. We do have some things that we should break on Android as well. I'm not sure what the path to v2 looks like for PPCP, but we will eventually need to get there.

Can we separate the breaking changes part of this PR to a separate PR against a v2 branch? I agree we should start planning for a major version, but I don't think we want removing liability shift to be the only breaking change in that version, and we are planning releases this sprint, so would be good to keep main in a release ready state

@tdchow @sarahkoop I'll remove the breaking change. I see the difference with iOS now.


Retrieve fields in the model

Hi,
I'm currently testing your model and it does a great job. :-)
However, there is something I don't understand : it seems that we cannot retrieve fields value after a get() directly in the model, as it's the case with most framework's models I tried.
For example, if I define a model like this :
Class Blog_model extends My_Model {
public $title = '';
public $content = '';

}
In my controller, if I call $this->blog->get(3), I can't retrieve $this->blog->title
I have to do $blog = $this->blog->get(4) to be able to get $blog->title
And this should be the same for updates or insert which should use the properties of the object.
Is this a normal behaviour or did I miss something ?
Maybe I could try triggers to set the properties with after_get and before_update.
Regards,
Fred

@fred9176  this is not а datamapper
hovever you can use after_get callback to modify query result


Added support for framebuffer gif image animation

Another feature that I thought if you were made aware of, you might want to utilize it. This PR adds support of gif images being animated in the frame buffer. This is done with shell scripting, but really ought to be done with python. See readme.md for usage.

I just realized that the path of './play' is relative, but the fact of the matter is that its irrelevant because its going to be replaced by python if its implemented. Just know that you have to be in the example directory for this work as of right now.


commit a

@hemaranjani02 Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.


Better gestures

Work in progress branch for better gestures.

Much better handling of scale/rotate and shove gestures.
Shove gestures are exclusive
Rotate and Scale gestures are exclusive in themselves.
Better horizontal gesture control (solves multiple issues of gesture detection when finger pointers were horizontal).
Shove gesture is flipped now, shoving up will tilt the view forward.
Rotation about finger/stationary finger vs rotation about focus point.
Pinch and Rotate is consistent about focus points in all possible views.
Use of DisplayMetrics for THRESHOLDS.
Handle DoubleTap and DoubleTap (motion) scaling

TODOs:

Mimics Behavior on other platforms (ios, osx, linux.... IGNORING RPI right now)
Control sensitivity of 1-finger gesture post 2-finger gestures.
gesture noise in rotation and scaling when tilted!!!

Does this have the changes for stopping the map mid-fling? I'm having trouble getting that to work when I play with it on my phone.

@blair1618 50492accb6a9e93e65e3e8052923f884f37bf9da has these changes. Just tried on my android and it works for me.

It stops if you trigger a gesture like a tap, but if you just put your finger down and leave it there it keeps right on flingin'.

Ohh there is no trigger for a "SingleTapDown" in any platform right now.
handleTap event occurs on "SingleTapUp".

Maybe we can treat a single touch down as a pan with zero displacement

Sure, or not do anything at all. But clear out the last fling (if it was flinging).

Yes I think an event for this would make sense to stop the fling at this moment, as soon as you start putting your finger down to the screen.

I do not like how I am handling "making focal point static" on scale and rotate.
Would like to get some inputs there. I have another solution which does not have noise/jumps on scaling or rotating, but it does not work when one of the fingers is stationary :|.

Mmm I've been working on this as well, I'll let you know if I find a good
solution.
On Wed, Aug 5, 2015 at 4:42 PM, Varun<EMAIL_ADDRESS>wrote:

I do not like how I am handling "making focal point static" on scale and
rotate.
Would like to get some inputs there. I have another solution which does
not have noise/jumps on scaling or rotating, but it does not work when one
of the fingers is stationary :|.
—
Reply to this email directly or view it on GitHub
https://github.com/tangrams/tangram-es/pull/222#issuecomment-128142150.

Alright I think I've found a pretty good solution. See https://github.com/tangrams/tangram-es/tree/bettererGestures
We don't need to keep track of a 'focus' at all, we can just detect the average translation of two-finger gestures using Android's onScroll and treat that as a pan.

This now has implementation for handling "TapDown" touch events (android, ios, osx and linux).
These make sure InputHandler clears all deltas for a previous fling gesture.

Turns out the loss of positional accuracy with rapid zoom and rotation is caused by screenToGroundPlane using stale view matrices. I've tried out a fix and found it impossible to lose accuracy when the matrices are actually up-to-date. I'll make a fix for that in another PR.


Add PyPi search queries function

Is your feature request related to a problem? Please describe if so, otherwise leave this blank..
Describe the feature
<-- A clear and concise description of the feature. What will it do, what will it affect, etc. -->
Add PyPi search queries function to v2.1.2.
Provide any alternatives to the feature you've considered
N/A
Additional information
<-- If you have anything additional to say, you can say it here.  READ MORE ABOUT HACKTOBERFEST HERE

Would you please assign me this issue.

Hello @ArjunSharda, would you please assign me this issue.

Hello @ArjunSharda, I am getting this error while solving this issue

@ArjunSharda, would you please check my pull request.


Docs for Delete Edit and Test Icons

Bug Report 🐛
Click on Delete Icon is not working when the cursor hovers over clause templates.
Package: Contract Editor
Expected Behavior

The template should get deleted.
Current Behavior

There is no deletion of the template.
Steps to Reproduce

Hover any template
Click on delete icon

Context (Environment)

Desktop

OS: ZorinOs(Ubuntu based)
Browser: Chrome
Version: Chrome- 88.0.4324.182 (Official Build) (64-bit), Zorin OS 15.3

This is likely an issue with how the icon is used in our Storybook.

@irmerk I don't think that the edit button works either. That button is supposed to let us edit the contract, isn't it?

I am trying to resolve this!

Addon action 'delete' is working as it is showing it in the action console.

@lokeshn011101 What do you think that the problem is?

I can't seem to find where these 3 functions are defined in the code nor the main props of the application. I am not sure if these three functions are defined yet.

The only thing that I could find yet is this.

All this does is log stuff on the actions console.

This is working as designed -- these functions can be supplied by the user of the component. They are not implemented by default because they typically require interaction with other components or the persistence layer of the embedding application.

@irmerk Shall I work upon this issue.

@irmerk @dselman Before opening the PR the plan that I am intending to follow is :-

[] First of all the file that I am going to update is link
[] Documenting the role of the user in the Component
[] Documenting how to use them in general.

If some sort of addition or deletions are there let me know.

@Cronus1007 I believe that sounds like a good plan.

I would like to contribute and fix the issue.
Can you guide me on how should I go forward into solving this issue.

@dezfuture as you can see, @Cronus1007 is working on this and has an open PR.

I want to contribute on this project and fix this bug.

Is this issue resolved?

No, but there is a solution in https://github.com/accordproject/web-components/pull/305 if you want to open a new PR. Please consider the feedback given in the thread in #305

i want to work on this issue. if it still exist then can you please assign this to me ?


Turn WasmFeatures into a bitflags type

This PR reduces the size of WasmFeatures from 23 bytes down to just 4 bytes.
As proposed by @alexcrichton here: https://github.com/bytecodealliance/wasm-tools/issues/1491#issuecomment-2049892243

@alexcrichton Implemented nearly all of your code review comments.

This change itself is good, but I think we will additionally want to have an expand method that creates basically the old struct as well, because there are a few places in Wasmtime that exhaustively match on the struct fields to make sure that we aren't accidentally missing any. For example, when serializing compiled Wasm we also serialize the Wasm features so that we can check whether the compiled code is compatible with the current config when loading that code again. In this scenario, we really don't want to forget a feature.
I can look into this.

Opened https://github.com/bytecodealliance/wasm-tools/pull/1499 to resolve this issue.


Problem parsing command line arguments ?

I'm probably being a bit dense (as well as being a bit of an inexperienced C user) but I'm not sure why the code below isn't working.
I am pretty sure that that argv[] and argc should be being set by _init_cmdline(), even though I can't figure out what is calling it (it might be __stdlib_init but I can't  see where this is defined although it being called from crt0cpm3-z80.s0).
_init_cmdline() appears to scan the command tail in the CP/M buffer starting at 0x80, and I think it should be should setting argv[] to point to the start of each parameter string before terminating it by replacing any spaces between parameters with \0.
Unfortunately while it seems to be setting the correct value for argc, argv[] is just a collection of null pointers...
$ cat args.c
#include <stdio.h>

int main(int argc, char* argv[])
{
   for (int i_count = 0; i_count < argc; i_count++)
   {
      printf("'%s'\n",argv[i_count]);
   }
   return 0;
}
$

$ make
# Compile args.c
sdcc -o ../build/args.rel \
	-c --std-c11 -mz80 \
	--nostdinc -I ../include \
	args.c
# Link both
sdcc -o ../build/args.ihx \
	-mz80 --code-loc 0x0100 \
	--no-std-crt0 --nostdlib \
	../bin/crt0cpm3-z80.rel ../build/args.rel \
	-L../bin -llibsdcc-z80 -llibcpm3-z80
# SDCC data segment fix. Update .lk file and link again.
sed '/-b _DATA = 0x8000/d' ../build/args.lk > ../build/args.link
sdldz80 -nf ../build/args.link
# Finally, convert ihx to binary
sdobjcopy -I ihex -O binary ../build/args.ihx ../bin/args.com
$

Using libcpm3-z80 produced the following output,
A> args one two three
'(null)'
'(null)'
'(null)'
'(null)'
A>

I'd expected the output to be
A>args one two three
''
'ONE'
'TWO'
'THREE'
A>

And before I forget - nice job!!
I found your repo just after I figured out that the way sdcc passes parameters was completely changed between version 4.0.0 and 4.2.0 and had just finished implementing my own mechanism for passing argc and argv[] in my own custom ctr0.s, while also discovering along the way that as sdcc targets embedded platforms this means you need bring your own file handling!  So I think I'm going to be getting to know your library a lot better in future!!
Incidentally having argv[0] return an empty string (as opposed to a null string) may not be what you might expect in a unix environment, but is apparently perfectly legal (I think I spotted this in the HiTech C documentation a few months ago).  In my implementation I managed to squeeze in the empty string for argv[0] without using any extra storage by setting the contents of 0x80 to \0`` and setting argv[0]``` to point to 0x80.  However I did everything in assembler rather then C.
Mike T.

Hello,
since I don't have much time libcpm3-z80 depends on your testing so thanks for feedback. File functions are not very well tested so I'll be glad of any automated tests I can include into the library (hint). I also plan to update parts of the library with much more lean and mean functions I wrote for (this similar project). That includes command line arg processing (it is much better code), CP/M filename processing, and ctype functions. That said, the file functions still leave a lot to be desired. Most notably they ignore all attributes and need to be extended accordingly.
I will take a peek at the library again over the weekend.
Regarding argv[0] the standard behavior is to return the program name. However in CP/M program name is lost and can't be easily recovered. Therefore all CP/M libraries will return an empty / null.
Initialization code can be found in tha src/util/ directory (init.c) and parsing is done inside cmdline.c in the same directory. It uses standard CP/M address 0x80. What system are you using and is there an easy way to reproduce your issue? Maybe it has to do with changed ABI for SDCC. It worked fine, but I haven't tested it for a while. Does it work with old SDCC i.e. 4.0?
Sincerely,
Tom

There's a way around null in argv[0]. When the standard library is initialized (it is called from crt0 from gsinit section) it seeks for another function called libinit(). This can be provided by your program and this function is called before main to do your library specific init. An example of this is my library for the Iskra Delta Partner computer which is compiled together with libcpm3-z80 to add platform specific functions. libPartner. This function can then set the argv[0] to the name of your program, which you know, because you are inside your program. Unfortunately renaming the file still returns the same hard-coded name.

Hello. I found the bug. As expected it emanates from the new ABI. For __SDCC >=SDCC_4_2_0 the system also passes the argc and argv arguments to the main using the new ABI and does not use the stack. Hence I need to update the crt0.


Upgrade CRA preset dependencies to match CRA v3

What I did
Upgrade CRA preset dependencies to match CRA v3:

babel-preset-react-app
core-js

There appears to be a conflict @Spy-Seth, if you can resolve that, I can merge :)

@mrmckeb Rebase done

I just check and I do not see any direct usage of core-js in the @storybook/react package. Not sure if the dependencies is really needed in this package.
I discover that core-js is defined in almost all packages of the mono repository. In general at the constraint ^2.6.5 is used, but ^2.5.7 and ^2.5.4 are also used.
I suppose this package should be upgraded everywhere in the same time. But the impact could be way more important than I was initially expected with this PR.

@Spy-Seth it's because after babel is done transpiling the packages before we publish, there will be references (imports) to core-js in the 'compiled' dist.
If the package does not have a dependency on core-js it might be install hoisted/dedupped higher into node_modules, and start depending on a wrong version of core-js.
I have migrated storybook to use core-js 3 in this PR https://github.com/storybooks/storybook/pull/6566
But it has grown large, and there's a few breaking changes in there, including the change to core-js 3.
I would like to split that PR into (at least) to parts:

The core-js 3 migration
the remainder

Would you be able to assist?

I'm ok to give a hand with that. Did you need help on your core-js PR https://github.com/storybooks/storybook/pull/6566? Or should I only remove the core-js upgrade from this PR and we will wait for yours?

Thanks @shilman and @ndelangen. Let us know if you need support on #6566 @Spy-Seth.

I created the PR to upgrade core-js: https://github.com/storybooks/storybook/pull/6655

reading what where the changes in the preset, this looks like a breaking change.. I think we need to consider extracting cra-preset out of the SB/react in the next releases.

Let's merge https://github.com/storybooks/storybook/pull/6655 first

Now #6655 is merged. I will upgrade this PR

@Spy-Seth shall we get this merged for 5.1 ?

@ndelangen Good call on getting this merged before 5.1

Are your concerns addressed now @ndelangen? Let me know if I can help with this PR.

👍 👍


Warn on volume size > 80%

The rule already exists: https://github.com/flanksource/karina/blob/master/manifests/monitoring/alertmanager-rules.yaml.raw#L538


Thinking about the value of NearClip and FarClip in OrthographicCamera

Additional

[x] The size of camera following  the size of the frame buffer size not the window size

the size can be determined from the input


Request Update of Resources

Hello, this template is not using the latest type of resources in AWS.
It would be great to update the versions and types of the different resources the Solution Creates.
Thanks.

Thanks for the feeback! Open to receive pull request with the updates.


Add Validation Case for EnumerateAncestors

https://docs.microsoft.com/en-us/microsoft-365/cloud-storage-partner-program/rest/containers/enumerateancestors
We should add a test case to the validation tool to ensure that the call to EnumerateAncestors for containers behaves consistently across providers.
Currently two providers have implemented the call with different root folder behavior, yet the validation tool passes for both.
We should make sure the tool validates that the root folder is included in the AncestorsWithRootFirst list.
Related Issues:
#102 #178

Thank you for your suggestion.  We have passed this on to the product team for consideration in a future release.
We are in the process of closing the WOPI Validator GitHub repository and will no longer be monitoring comments here.  If you have further questions or suggestions, please reach out to the CSPP partner Yammer channel or contact<EMAIL_ADDRESS>

adsfasdfsdafsda


Auth Config not found

import { config } from '../../../.configuration';
at least a demo one will do

Facing the same issue. configuration module not found

Sorry for the late response I didn’t realise you’d commented. I will add a public configuration file this week and update you accordingly

Please see readme for details on configuration file and example code. The config file only includes the firebase generated keys generated to access your firebase auth service which you will need to create yourself. This is free.


I think PoolConn needs to be thread-safe.

IMO, PoolConn need to inherit from sync.RWMutex and protect every method with lock, especially this method: MarkUnusable.
Here's my use-case:
If there are many goroutines performing conn.Write(), some of them bound to fail with broken pipe error message. When that happened, the goroutine need to be able to call MarkUnusable in a thread safe way.

The PR is already accepted.


Python Blog should be broken down into multiple blogs or sections

This blog: https://ayush-blog.netlify.app/Python/01-Quick-Tips/ has too much information, spread over separate topics, and has no consistency to it. The tips are good, but they should be organized in a proper manner.

Reopening this issue.
The sections are great, but the information is too massive for one page.
It would be simpler to just have one topic per blog. The code cells are isolated from each other anyway.


Investigate components using aria-expanded=false as a possible WCAG violation

Summary of the bug
We currently have some WCAG violations being addressed in ticket 1912. The purpose of this ticket is to investigate and fix other identical violations in other components IE

This includes work to include cypress testing/uncommenting tests and regenerating snapshots for unit tests
📝 Acceptance Criteria
A11y tests should pass.

After researching here: https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-expanded , determined that components are ok as aria-expanded can be false. The cases in the components are generally on <button> elements which are acceptable


Upgrade jupyter_server to version 1.19.1 to fix the vulnerability

I tested this on host mode and it works. @jerrychenhf  Please have a review, thanks.

We have many Spark related requirement.txt files which have the same contents. Can we share the same file to void manage the same version value across many files?

Have changed docker build context for optimized and native-sql Spark runtime to share the same file for Spark runtime.

@jerrychenhf Please have a review, thanks.

@jerrychenhf Please have a review, thanks.


optimize deeplearn.min.js and random generation

This change is

Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


idea: Support for adding to the summary page of a workflow run

Add ability to post the markdown as a job summary: https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#adding-a-job-summary

@jabbermouth Something like this?

Screenshot of TF plan in a GitHub Action workflow's job summary.

Yep 👍  Basically, what goes in the PR but on the run summary page.

Might be worth giving TF-via-PR GitHub Action a go; the above screenshot is taken directly from a recent workflow run to demo a realistic use-case.
You can probably tell I'm the author, which is why I'm on the look-out for use-cases/feature-requests that users are seeking for these sort of Actions.

Thanks, I'll take a look.

This sounds very reasonable! And I think it can be nicely combined with the request in #12 :eyes:

I would love to see this. Using a single action to print to both comments on a PR, and summary on a run without a PR would be great.

@joryirving You're in luck, both are supported here!

Sure, but that's a different action than this repo. I'd rather not refactor for a new action if I don't need to.

@joryirving That's totally fair. Might be pleasantly surprised by how little there is to "refactor", but I understand replacing and trialling a GH Action takes time.
Worth noting, it does a li'l more than just render a plan as a comment—it streamlines Terraform/Tofu automation as a whole. Attached a screenshot below of a workflow (matrix) job jummary, as per this issue request.

It honestly feels weird, advertising your GHA in another actions repo. That feels inherently wrong, and actively makes me not want to switch.

@rdhar I would also chime in here for a moment to give my 2 cents that what you're doing is not really constructive.
This is an issue opened in this repo to suggest/request a new feature for this project. Promoting your own project (even if it does answer the initial request) multiple times just pollutes this thread that had an entirely different purpose to begin with.

Hey @joryirving and @mircea-pavel-anton, thanks for sharing your thoughts. I get why it feels off to mention my project here, but I just wanted to share an alternative for the feature request since it's been open for nearly four months now.
Open-source thrives on communities which share ideas and explore different options, instead of limiting ourselves to just one solution. I appreciate your perspective as well, and hope you see where I'm coming from.

To be honest, the Summary would be a "nice to have" but not a requirement. I really like how this GHA formats the comments https://github.com/borchero/terraform-plan-comment#example-comments


Use generic addresses TAddr instead of net::SocketAddr.

Implements #4.
Feel free to reject this PR if you think this is too much of a niche feature.

I just made an unrelated commit that improves KNodeTable::pop_oldest(). I include it in this PR, to avoid merge conflict.
Tell me if you want me to split this PR into two.

I just made an unrelated commit that improves KNodeTable::pop_oldest(). I include it in this PR, to avoid merge conflict.
Tell me if you want me to split this PR into two.

Not sure how useful it is, but as rust-dht is quite experimental, I'm fine with it :) Thanks.


jmxtrans only fetches and sends around every 15 minutes

I expected the parameter "-s 60" to make jmxtrans fetch and send jmx data every minute. However, in my installation, it only does that every 15 minutes.
I'm querying 19 hosts. Does "-s 60" mean, that every 60 seconds the next host is processed? If so, how can this process be paralelized?

hi, do you have an example configuration ?

I guess, this has been fixed somewhere. Looking at the current configuration including "-s 60" it works as expected. Thanks


 So now we need to ship our own multiplatform runtime which we can do, ~but you also need a Gradle plugin now~ (we ship a Gradle pluign now). And now that runtime has negative interaction with someone using Android's Compose runtime likely through Compose UI which means you need ~a resolution strategy~ to alter Gradle metadata. But that only works for Android so someone using Compose for Desktop, Compose Web, or Redwood would still see duplicate classes.
What a mess.

In Multiplatform Compose and Gradle module metadata abuse you mention that Google is probably far off from doing this, and best bet is for JetBrains to handle it for now. Is there any public discussion about it on their end?
If JetBrains isn't going to do it, (or if it will take them a while), would it be possible to have a community "standard" artifact that mirrors and shades Google's?

I have no idea if JetBrains is thinking about fixing Google's mistake / lack of action in this space. But aside from Google, JetBrains is the only company which can do this seeing as they currently publish a version of the runtime for JVM and JS. They would have to unify these into a single multiplatform build, ship versions which align directly with Google's binaries, and have the Gradle module metadata point at Google's artifact.
Any third-party multiplatform build of the runtime will be impossible to use with Compose for Desktop/Web and Compose UI for Android given that JetBrains and Google do not ship from the same SHAs. You would have to convince JetBrains to change their Compose for Desktop and Compose for Web products to point at this third-party build which seems impossible given that they're currently forks and ship with wildly different cadences to each other and to Google's Compose.

I'm guessing this would be a big no (because of complexity and scalability) but what about writing molecule in common Kotlin, and then delegating the compose implementation to the targets?
Then for each target there could be multiple artifacts corresponding to the runtime being used if necessary. That would address the issue of different SHAs because the consumer would be explicitly saying that they want the artifact with a runtime based on Compose UI, Compose Desktop, Compose Redwood, etc...
Then if Google or JetBrains ever releases a multiplatform artifact those could all be deprecated.
It would be a step backwards from how KMP works with dependencies, but Molecule would be able to be used in common code.
I'm working on very little sleep so take this all with a very big grain of salt

It's not just the runtime, though, you also have to have a matching version of the compiler. If you want to support native you have to have a different build of the compiler than the other platforms due to a binary incompatibility between the two and currently no one ships a native-compatible version of the Compose runtime.
Ultimately the core of Molecule is about 40 lines of code. I would recommend you copy/paste it into your codebase if you have a multiplatform Compose project for now.

It should work since the specific runtime artifact would be used in the context of a matching compiler, and the common Molecule code wouldn't need the compiler because it delegates the composable function to that artifact.
But yes, copying it would definitely be the easiest solution for now 🙈

Molecule itself must be compiled with a compose compiler. Granted, it's probably safe to mix and match the versions used there so long as you always used a newer version, but yeah I'm wary of harming the common case for this rare one.

Ah forgot about the body parameters. Oh well, never mind.

But aside from Google, JetBrains is the only company which can do this seeing as they currently publish a version of the runtime for JVM and JS

Having multiplatform support would be so nice. Should I file a YouTrack request?

You can, although I still think it's unlikely that it will happen.
In order for it to be used here and on Redwood, it would have to be built based on the same SHA that Google uses, rewrite the Gradle metadata to point at Google's artifact for Android, and probably use the same version number (although we do not do the latter for Redwood).

If I understand it right starting from 1.0.0-beta5 Jetbrains Compose is built with Google(Jetpack Compose) artifacts for Android targets. So it might be possible to use multiplatform and be compatible with Jetpack Compose. Taking info from this comment: https://github.com/JetBrains/compose-jb/issues/1143#issuecomment-964203336

Not an ideal scenario, but it seems like compileOnly dependencies could work in the short term for this as well.

That's right. The .module in Maven Central confirms this. Once they publish their 1.1.0 (which appears to be in progress right now) I will update this library to be multiplatform and use their fork.
We are also migrating Redwood to their runtime so that it will no longer build its own either.
However, Google is not off the hook here as it is the one who should be publishing the multiplatform runtime and the Kotlin/Native-targeting version of the compiler. Thankfully, based on some recent CLs going into AOSP, it looks like at the very least they are going to take the JS and native actuals for the runtime and move them into AOSP. That's the first step on the road to a Google-published multiplatform Compose runtime.

So I found out in upgrading Redwood to Compose 1.1 that someone broke both JS and native support in the Compose runtime/compiler duo. We were forced to jump immediately to the latest 1.2.0 dev builds targeting Google's 1.2.0 alpha binaries.
Since we cannot release this project based on an unstable version, one thing we can do is go multiplatform now but targeting ONLY the JVM and Android. This will unlock Compose for Desktop support which is what I expect 99% of people want anyway.
Then, once 1.2.0 is stable, we can add JS and native targets in for completeness.

Since we cannot release this project based on an unstable version, one thing we can do is go multiplatform now but targeting ONLY the JVM and Android. This will unlock Compose for Desktop support which is what I expect 99% of people want anyway.

How about releasing an alpha version based on the 1.2.0 alpha for all platforms? That way you can start getting early feedback from users interested in the JS support.

I'm highly skeptical there are JS users who separate their modules enough that they need Molecule. They can, for now, just depend on compose-web and use Molecule as a pattern rather than a library.

Since we cannot release this project based on an unstable version, one thing we can do is go multiplatform now but targeting ONLY the JVM and Android.

Confirming I have the recipe correct for this, use 0.3.0-SNAPSHOT for molecule and then ensure we are using the jetbrains 1.1.0 compose runtime/compiler and not the androidx targets in our JVM/Android modules as well as the ones that use molecule in common code?

JVM and JS shipped. Support for any targets is blocked on JetBrains runtime publishing a stable version with native targets. Once they ship, we will ship, too.

Any sample on how to use molecule with KMM? Any additional setup needed other than on the existing documentation?

From this issue and docs I understand that Molecule 0.5.0 works on ios targets.
However when I try to build on ios androidx.* libraries are not found.
I've created a sample project with just one molecule (https://github.com/mateuyabar/molecule_ios). Enabling the ios target common/build.gradle.kts on results on a Unresolved reference: androidx
Is there still issues with ios?

More samples will be coming but there is no timeline on it. In general you just add the plugin and the Compose runtime is automatically made available to use.

The compose runtime is also available in the shared common modules?

It should be, yes, it's a transitive dependency of our runtime library.

Hi @JakeWharton, I have tried to include the molecule plugin in my KMM project, but even after applying the plugin, it seems that the dependency is not added properly to all sourceSets. I have done some further research and the issue is the same as with this issue opened by you:
https://youtrack.jetbrains.com/issue/KTIJ-18425/
with the difference, that it uses "implementation" instead of "compileOnly". Can you reproduce this behaviour?

@igorbzin  In order to be able to use molecule inside common sources I've added the dependencies manually (as you mentioned plugin was not adding them to common).
val commonMain by getting {
       dependencies {
             implementation("app.cash.molecule:molecule-runtime:0.6.0")
             compileOnly("org.jetbrains.compose.compiler:compiler:<IP_ADDRESS>")`
(...)

Hi @mateuyabar, thanks for the input. I have already opened an issue https://github.com/cashapp/molecule/issues/136 where the workaround is described as well.

@JakeWharton Just wondering what's the correct MonotonicFrameClock to use for Multiplatform?

AFAIK Immediate is the only option for non-Android targets.

It's the only option that is provided, sure. However, you are free to create a MonotonicFrameClock for whatever platform-specific mechanism you want. On iOS, for example, you'd probably tie it to CADisplayLink if you wanted similar behavior to Android's Choreographer.


Input shape

Thanks for your work!
I found the input shape of your GAT is (nodes, features), in my network the input shape is (batch_size, nodes, features). So I run your code but it doesn't work any more. Please help me ,thanks a lot!😭

This repo is out of date, you should check out the GATConv implementation in Spektral.

thanks!!😘


Global helper functions naming

Consider adding a _ at the beginning of the function name (i.e _visitUrl) or add a prefix (i.e lvVisitUrl).
The function names are pretty common and the chance of having a similar custom global function in a big project is quite high.
Having a distinctive name will ensure that the functions will not collide with the project's own functions.
https://github.com/niladam/laravel-visits/blob/main/src/helpers.php#L10

That's a good point. I didn't think of that.
Let me do this now :)


Add default to comment option to code sub-command

First, thank you for creating this great tool!
In our workflow we usually add the default localization in comments, there is a possibility to add keys as a default value to the localized files. I think option -c or --default-to-comment to add comments as default values for code sub-command would be a great complement to the --default-to-keys option.
What do you think about it?

Is what you describe a feature supported by Apple or something widely used in the community and defined somewhere? I want BartyCrouch to cover any possible best practice, so I'd not say "no" to a good pull request from you that also includes tests for your case. If there wider use of your feature, I'd like to link the resource in the README. If there's not, I'd like to at least have an explanation of what the advantage is against the common usage pattern described by Apple here.

I'd like to come back to this feature request. Unfortunately nobody has answered my questions but I can see that some people seem to have given a thumbs up to this feature. Again: I'm open to merge a PR that adds this feature. And I'm still curious how you want to tell your translators the context of a translation string if you can't use the comment any more?
If no one answers here again, I have to close this feature request. A PR would make me happier though! ;)