Add Toros Finance

Revision checks

[x] Used smart contracts were audited.
[x] Your Safe App include a manifest.json file at the root with the required data.
[x] The app can be loaded as a custom Safe App in the Apps section of https://app.safe.global.
[x] The app auto-connects to the Safe.
[x] You are able to trigger and execute one transaction with a Safe.
[x] RPC requests are optimized (not triggering many requests in a very short time period).

Name/Description

Toros is built on top of dHEDGE, which is already added as a Safe app, by part of the dHEDGE core team.
Issues brought up in https://github.com/5afe/safe-apps-list/issues/159 have been addressed.
Type

New addition

Compatible Networks

- Polygon
- Optimism

Audit document

https://www.certik.com/projects/dhedge. Uses dHEDGE smart contracts.
Code for review

https://github.com/dhedge/toros-dapp. A Gnosis team member should already have access to this repo (it might be private currently).
IPFS hash/App URL

https://toros.finance/. Not on IPFS yet.
Desired date

No blockers for us.

QA from safe apps here 😄 The app looks good to me. After some final checks from the team it should be all good to be added to the list.
Cheers!

@edsonayllon on our side the app is ready to be added to the list. We can schedule to publish it whenever you want if you wanted to prepare an anouncement.

App is available now


Pen tool clicking an anchor to turn it sharp or close a path shouldn't rely on snapping

In the Pen tool, clicking to turn a point sharp relies on snapping being enabled to work, which is bad:
https://github.com/user-attachments/assets/70c74839-2519-42a5-8d40-af4a459da912
It should be able to do that irrespective of the snapping system. Essentially, the tool should have its own self-contained implementation of snapping just for the actively being-drawn-from segment endpoint, which is always active even when the snapping system is disabled, and the real snapping system shouldn't interfere with it.

sure! please assign me


Fix code scanning alert no. 41: Resolving XML external entity in user-controlled data

Fixes https://github.com/kermitt2/grobid/security/code-scanning/41
To fix the problem, we need to ensure that the XML parser is fully secured against XXE attacks. This involves:

Ensuring that the SAXParserFactory is configured to disallow DTDs.
Ensuring that the XMLReader is configured to disallow external entities.
Adding an EntityResolver that returns an empty string for any external entity.

Suggested fixes powered by Copilot Autofix. Review carefully before merging.

coverage: 40.763% (-0.02%) from 40.781%
when pulling c3008ec7eed5d335a98ef5812a44d8d193c236ff on alert-autofix-41
into 37dcec17b71ded30d7d4424a58098f36e2bc2bea on master.


Workflow can no longer be loaded after update

Description
Loading aborted due to error reloading workflow data
TypeError: Cannot read properties of undefined (reading 'find')
TypeError: Cannot read properties of undefined (reading 'find')
at nodeType.onGraphConfigured (http://<IP_ADDRESS>:8188/extensions/core/widgetInputs.js:359:29)
at app.graph.onConfigure (http://<IP_ADDRESS>:8188/scripts/app.js:1406:29)
at LGraph.configure (http://<IP_ADDRESS>:8188/lib/litegraph.core.js:2260:9)
at LGraph.configure (http://<IP_ADDRESS>:8188/scripts/app.js:1393:22)
at LGraph.configure (http://<IP_ADDRESS>:8188/extensions/ComfyUI-Custom-Scripts/js/reroutePrimitive.js:14:29)
at LGraph.configure (http://<IP_ADDRESS>:8188/extensions/ComfyUI-Custom-Scripts/js/snapToGrid.js:69:21)
at ComfyApp.loadGraphData (http://<IP_ADDRESS>:8188/scripts/app.js:1838:15)
at async app.loadGraphData (http://<IP_ADDRESS>:8188/extensions/core/undoRedo.js:25:12)
at async app.loadGraphData (http://<IP_ADDRESS>:8188/extensions/ComfyUI-Manager/components-manager.js:771:9)
at async reader.onload (http://<IP_ADDRESS>:8188/scripts/app.js:2206:6)
This may be due to the following script:
/extensions/core/widgetInputs.js
Here you can find a workflow:
https://openart.ai/workflows/murphylanga/automatic_comfyui_sdxl_modul-incl-faceswap/2Bsh5QwsrQkKFx6CLCz7
Reproduction steps
1 start comfy UI
2. load the workflow
Image file
No response

Sorry for the inconvenience. I mistakenly thought no one would use this special node. I've now reverted the problematic commit e8ca90fe35c1e12a3bfa3e277f732ff62e6b9c61.
For the problematic commit, its main purpose was to change the original Type Converter node into a more practical version with only one input and one output. To avoid impacting more people, I'll rename the new version to Any Converter.

Wow, you are fast. Thanks so much. I could have solved the Type Converter differently, but I still didn't know where I had to search. :-) But of course it's very nice for me.
Thank you again, also for your great work and the custom nodes.
But now I have to go to bed as quickly as possible.

You can try using Any Converter node tomorrow. I personally think it'll be a better solution : )


Use undefined for envDirName if VS Code envDirName config is falsy

Unfortunately I noticed too late that the change in #84 was not sufficient to fix https://github.com/AnWeber/httpyac/issues/103.
Since envDirName is defined as a VS Code config value of type string, the API will return an empty string as the default value.
Because of this the lodash.merge that is run in getEnviromentConfig will apply that value from VS Code.
Proposed fix: Coalesce a falsy value for envDirName to undefined and thus use the following property of the lodash.merge function: (ref. https://lodash.com/docs#merge)

Source properties that resolve to undefined are skipped if a destination value exists.

But I find the behavior strange. I would definitely have expected undefined. I would like to look at it briefly and then merge if necessary.

kind of surprising for me, but thanks.

The changes are provided with v4.7.0. Thanks for contributing:-)


Version 0.3.0

Is there anything that needs doing before bumping the version?

Is there anything that needs doing before bumping the version?

Not really, can you open up a PR that bumps the version in Cargo.toml and updates the CHANGELOG.md file with notes on the changes in this release?=


docs: improve docs and examples

@Stefanwullems @Michiel87
Some random observations from using useExpandable and ExpandableSpacer:

handleKeyDownFocusListItem only works with ul/li elements - this should be documented, and/or throw error if not satisfied (now it doesn't work if you forget ?
ExpandableSpacer seems a bit inconsistent in places and requires quite some boilerplate. e.g.:

can we automatically calculate the level, so we don't need to have it as an attribute?
if we can't, can we keep assumptions about the data structure outside the component (like parentKeyAccessor in useExpandable)
could we simplify the boilerplate required for distance/distanceBetweenEvenLevelItem?

I've removed the height/width styles from ListFocus, could that cause problems elsewhere @Michiel87 ?
At this point, I needed a lot of code to make a simple expandable list. I'd love to improve the DX for using advanced list options. Should we make a convenience List which implements most common options with props like AdvancedSelect does in the old library? Any other ideas?

@Stefanwullems I'm a little confused. When I run yarn test:update locally for this branch, all seems to be fine. However Travis doesn't agree with me. Could you do me a favour, pull this branch and run yarn test:update and see if you get any changed files? Thanks!

I will check it out


Widen bounds on directory to >= 1.2 && < 1.4

Fixes https://github.com/ambiata/mafia/issues/162
! @thumphries @erikd-ambiata
/jury approved @thumphries

👍

:100: :100: :100:


[hertzbeat] release hertzbeat version v1.3.1

What's changed?
release hertzbeat version v1.3.1
Checklist

[x]  I have read the Contributing Guide
[x]  I have written the necessary doc or comment.
[x]  I have added the necessary unit tests and all cases have passed.

要发新版本了吗

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑🤝🧑👫🧑🏿🤝🧑🏻👩🏾🤝👨🏿👬🏿

Are you going to release a new version?

要发新版本了吗

是的准备今天发😊

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑🤝🧑👫🧑🏿🤝🧑🏻👩🏾🤝👨🏿👬🏿

Are you going to release a new version?

Yes, ready to post today 😊


[bug] Can't connect to VPN

Describe the bug
I try connecting to any vpn location and it gives me an error.
To Reproduce
Steps to reproduce the behavior:

Go to Mysterium VPN Application
Click on All nodes > Quick Connect > Error

Expected behavior
To connect to the VPN.
Logs
main.log
renderer.log
Screenshots

Desktop (please complete the following information):

OS: Windows 11
App Version: 10.14.4

I have the same problem. If you find a solution please leave a comment here. I will inform you if I got a solution.  Thanks in advance

Hey there! Thanks for responding about the issue. I've had the same problem and tried reaching out to Mysterium, but the emails I got back were pretty unhelpful. I even popped into their discord server to see if anyone there could help, but no luck there either. If you happen to find a solution, definitely let me know. I'll do the same if I come across anything that might help. Thanks!

What worked for me on a Mac is the clean install instructions. https://github.com/mysteriumnetwork/mysterium-vpn-desktop/wiki/Clean-install
Not sure if that will help or not.


Suspected Memory Leak

What's wrong?
Hello,
I suspect there is a memory leak in Alloy. The memory utilization of Alloy keeps increasing over time, as shown in the attached graph, which could negatively impact the instance/server sooner or later, depending on the available memory.

I am using Alloy to collect local (same host) logs, writing directly to Loki (loki.write), and collecting a few local metrics, sending them directly to Mimir (prometheus.remote_write).
Do you have any ideas on how to prevent Alloy's memory utilization from growing?
Thank you.
Steps to reproduce
run alloy at Server (baremetal) or VM
System information
all
Software version
all
Configuration
No response
Logs
n/a

I dig into it deeper and the issue is not a grow (I used wrong metric containing as well system cache). The real issue  is a peak in memory usage (to few gigabytes). I will close this ticket and create a new one  description.


Add basic workflow generation

This PR adds to the WorkflowApp class the ability to serialize to XML action and kill nodes using the oozie-workflow-0.5.xsd schema.
Implementation
This PR implements:

An abstract _WorkflowEntity class to serve as the base type for these and other structures that will be exposed to users to allow them to define a workflow which features:

An optional on_error parameter which allows one to specify a _WorkflowEntity to transition to if an error occurs
An optional name to help document identifiers in the XML (otherwise a uid is used)

A Kill _WorkflowEntity which if transitioned to kills a workflow and emits a message
An Action  _WorkflowEntity which wraps a ConcreteAction (e.g. execute a shell command, subworkflow, or email) which

Can specify credentials that are to be used by a concrete action
Can specify action retry semantics

This PR also adjusts WorkflowApp to validate that:

All credentials referred to by actions are supplied in the constructor
No duplicate identifiers are present in the actions provided (an Oozie logic error)

This PR enables the ability to define collections of actions that can be executed serially/in parallel (https://github.com/Shopify/pyoozie/pull/50).
🎩 'd by starting a local Oozie 4.1.0 instance using docker-compose up -d and manipulating tests/pyoozie/test_interactive.py to specify different values.
Notes
This PR is one of several that are intended to add an API to define forking/joining workflows with error-handling prototyped in https://github.com/Shopify/pyoozie/pull/26.

@honkfestival @prabcs @sabidib @solackerman any final comments?


docs: add /blog to white list & add links to the blog

PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines: https://github.com/NG-ZORRO/ng-zorro-antd/blob/master/CONTRIBUTING.md#commit
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
[ ] Yes
[x] No

Other information

Would be fixed in #3652.


Hackernews Demo

Peer programming with @morenol. He deserves 90% of the credit. I was his keyboard monkey 😀


ionic 2 FileEntry linting doesn't follow specification and device behavior

Ionic version:
[ X] 2.0.0
**I'm submitting a bug report
Current behavior:
FileEntry doesn't respect specification
https://cordova.apache.org/docs/en/2.4.0/cordova/file/fileentry/fileentry.html
file.size and file.type are not supported by lint checking
Properties are available when running on device.
Expected behavior:
lint shouldn't raise blocking error when accessing file.type and file.size
Related code:
                    fileEntry.file(file=> {
                    // on device, file contains mimetype and file size
                      console.log('file content', file);
// those lines trigger
 console.log('file content', file.size);
 console.log('file content', file.type);
                    }, ((error:FileError) => console.log(error)));

In this case, it is because Typescript does not know about file or it's valid type information. Use Ionic native instead.
http://ionicframework.com/docs/v2/native/file/

Hi mhartington,
thanks for your answer, even Iif don't get it :) :
I'm trying to use Native file API to get file size and file type, the sequence is :
FileChooser.open()
.then(uri => ....
FilePath.resolveNativePath(uri).then(nativeUrl .....
let path:string = nativeUrl.substring(0, natifUrl.lastIndexOf('/'));
let fileName:string = nativeUrl.substring(natifUrl.lastIndexOf('/') + 1, nativeUrl.length );
File.resolveDirectoryUrl(path)
.then(directoryEntry=> ...
File.getFile(directoryEntry, fileName, {} ) // readAsText
.then(fileEntry => { ....
I do get a fileEntry - in order to get file information(type, size), what should I do using native/file ?

Let move this to the forum, as this is a more general question than actual issue.


Error installing private registry

I install a private registry using catalog via Rancher UI. When I click "Launch", it show an alert without content as the image

Useful
Info

Versions
Rancher v2.2.8 UI: v2.2.94

Route
catalog-tab.launch

I can launch the same app docker-registry from the built-in catalog with no problems.  All values are default values.

Rancher
v2.2.9-rc1

User Interface
v2.2.98

Helm
v2.10.0-rancher11

Machine
v0.15.0-rancher8-1


[mtnclock] Add settings and the ability to show widgets

This clock currently does not show the widgets bar. So, this PR adds a setting to enable the widgets bar but leaves it disabled by default to maintain the original behavior.

Thanks! However I'm afraid this is the wrong place to put the code for Bangle.loadWidgets(); as it'll be trying to reload widgets each time the clock is drawn which could be slow.
Please could you keep drawWidgets where it is but then put the if (...) { Bangle.loadWidgets(); Bangle.drawWidgets() } right at the very bottom of the file?

Thanks!


kubernetes upgrade v1.11.4

This is an auto generated PR created for kubernetes upgrade to v1.11.4

I'll trigger pipeline again to generate changes without the extra properties


I found this example the clearest and perhaps best example and copied its behaviour.
You can find a description of what all handled keypresses (left, right, up, down, pageUp, pageDown, Home, End, Ctrl+Home, Ctrl+End) do here:
DOM
The DOM looks like this and should be fully accessible:

TV
I've added simple keyboard listeners for web. For tv devices, we could extract these listeners for web, and make alternative tv listeners. We could then add props to LayoutGrid such as onLeft, onRight, onUp, etc.
Performance
I can acknowledge that on focus change, only the previous and next cell (Cards) re-render, so I assume we're not unnecessarily losing performance.
Still to be improved (anyone?)
I would like to block DOM scrolling while handling the key events, so that we can control the scrolling (otherwise Up, Down, PageUp/PageDown do too much of it). However, if I add preventDefault() to the listener, the whole key handling doesn't work and the scrolling still happens. It would be nice if we could fix this. Anyone?

One addition I would like to see is that if you use the mouse and keyboard in combination there are 2 active (focussed) states. I think if you point (mouseenter) to a certain grid cell, the row + column index may also be set to these coordinates.

I like that, will do. :)

Unit tests are failing, @royschut will you fix these so we can merge this?


Add a env flag to allow skip installing dependencies when run ./build.sh

Task description:
When i develop locally, frequently i need to run building binaries. But every time it run ap-get update and installing every package it need like protobuf libbpf, etc.
Solution:
Who can join or take the task:
The good first issue is intended for first-time contributors to get started on his/her contributor journey.
After a contributor has successfully completed 1-2 good first issue's,
they should be ready to move on to help wanted items, saving the remaining good first issue for other new contributors.
How to join or take the task:
Just reply on the issue with the message /assign in a separate line.
Then, the issue will be assigned to you.
How to ask for help:
If you need help or have questions, please feel free to ask on this issue.
The issue author or other members of the community will guide you through the contribution process.

/assign

/assign

/unassign @Shuimo03


[FLINK-15941] [format-avro] RegistryAvroSerializationSchema registers schema on first message only

What is the purpose of the change
This pull request improves the RegistryAvroSerializationSchema class such that it will only attempt to register the schema with the Schema Registry on the first message. All subsequent messages will retrieve the schema id from the cache.
Brief change log

Update RegistryAvroSerializationSchema to utilize the same instance of SchemaCoder for each message so it can retrieve the schema id from the cache after initial registration.

Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (don't know)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not applicable)

Thank you @swhelan091 for your contribution. Merged it into the master.


Api refactor

This refactor completely removes the need to use this from the API.
Now it is posible to merge advices since joinPoints accept a list of advices.
Now kaop-ts only provides decorators but uses vanilla kaop API under the hood.

Coverage decreased (-8.1%) to 89.72% when pulling 3455a387234950d75ea5971029b285a4126068b7 on api-refactor into a693bf0071eed8b5e5ad5c9fd0df422319221dfe on master.

Coverage decreased (-8.1%) to 89.72% when pulling 0a31a5ba2d667062e83e8e84a5066561e9912e8d on api-refactor into a693bf0071eed8b5e5ad5c9fd0df422319221dfe on master.

Coverage decreased (-8.1%) to 89.72% when pulling 98cb3b9070ddbb4cf37ba51a396a072e3d7b28ce on api-refactor into a693bf0071eed8b5e5ad5c9fd0df422319221dfe on master.


New Co-WIN restrictions are there. Will it affect performance

The Govt announced that only 20 searches per user account would be possible and then would be logged out to prevent abuse. Will this system work?

The app respects cowin's rate limits and it is working fine. The rate limits details are here https://apisetu.gov.in/public/marketplace/api/cowin


Admin - Update Laravel Mix

Description
Laravel Mix is two major versions behind (2.4 vs 4.0) and npm throws a high severity security warning when running npm install. I attempted to update Mix and the rest of the npm dependencies but got into an issue compiling sass after trying to consolidate our sass dependencies. Might be easier at this point to leave everything else as-is and just update Mix.

Managed to solve that with instructions here: https://laravel-mix.com/docs/4.0/upgrade The node-sass package needed to be reinstalled and added to the sass mix.
@joshdrink the webpack options could be reviewed for relevance as well as some of the package dependencies.


Reduce risk of offending in adams.js

Some people get irrationally angry when 'him' is used.  This commit fixes that.

Thanks for the contribution. Can you accept Google's CLA so I can merge the pull request?
https://cla.developers.google.com/about/google-individual

CLA accepted


Can't create view.html

hi,
do i need to create logs.json in advance？

Did you solve this problem? I can only get logs.json.tmp, and cannot open view.html.


Consolidate CI and add Bors config

Consolidate some jobs in CI to make it simpler
Add Bors config for merging

bors ping

@sehz once this CI passes you can bors r+

certs have expired.  you can re-generate certs or I can do it

rebase and CI failure will go away

bors r+

Hmm, for some reason one of the jobs just didn't even start for like 20 mins. But none of the jobs take more than like 5 mins, let's just try again.
bors r+


feat(ui): add Popover & Tooltip components

Issue:
What I did
How to test

Deploy preview for mcslite ready!
Built with commit 369697103ba4fbd3c4023db9e8ed0c88958d9d7f
https://deploy-preview-562--mcslite.netlify.com

Deploy preview for mcs-lite-ui ready!
Built with commit 369697103ba4fbd3c4023db9e8ed0c88958d9d7f
https://deploy-preview-562--mcs-lite-ui.netlify.com

Deploy preview for mcs-lite-introduction ready!
Built with commit 369697103ba4fbd3c4023db9e8ed0c88958d9d7f
https://deploy-preview-562--mcs-lite-introduction.netlify.com


Added currency converter

Assigned Issue Number ? { if does not exist then create one }
#007
Language Opted ?
HTML/CSS/Javascript
Number of files added or updated ?
3
Checklist

[x] I've read the contribution guidelines.
[x] I've referred the correct issue number.
[x] I've fill up this entire template correctly.

@Roshaen thanks for the contribution 🏅

@Roshaen it would be awesome if you also add a readme file in the automation explaining what is it and how to use it (although it is super intuitive but will still improvise the overall appeal of the automation), I didn't think this issue was serious enough to stop merging so commenting here instead.

@Arsenic-ATG Nice collections of automation🙂
Really enjoyed contributing👍

Glad you liked it 😀


empty map (no records) showing on default home page, in mapping app

I am sure this is by design, however I find it very odd that on the default view, the lower mapping app just shows the base layer, and you cannot see any record geometry/points/polygons etc.
you can however interact with that map, zoom-in etc, and search for those missing points and polygons, which really confuses the user
what is the point of having an interactive (and empty) mapping app on the default view?
I suggest to fully remove the mapping app on the default view, or, just have a small screen capture of a map showing some of the geometries, that when the user clicks it, it automatically opens the full map viewer

source: https://oih.ioc-africa.org/

Thoughts?

Yes, there should be some content on the base layer, like the heatmap or hex cells
I wouldn't remove it.

Hello, it seems that the Africa's portal frontend is not updated at the last release as the main one

@emarzini we do not touch the African portal installation for the time being, we are installing everything on our dev server and are trying to reinstall the complete suite (not only the UI, but also indexing and harvesting) on that server before updating the Africa installation.
our test installation is either on dev.oih.iode.org or devsearch.oceaninfohub.org


Can not create empty glyph by TTGlyphPen or T2CharStringPen

TTF:
pen = TTGlyphPen()
pen.closePath()

This will cause:
  File "/Users/takwolf/Develop/Python/pixel-font-builder/venv/lib/python3.11/site-packages/fontTools/pens/ttGlyphPen.py", line 244, in closePath
    if self.points[startPt] == self.points[endPt]:
       ~~~~~~~~~~~^^^^^^^^^
IndexError: list index out of range

OTF:
pen = T2CharStringPen(width, None)
pen.closePath()

this will cause error on get lsb:
lsb = glyphs[glyph_name].calcBounds(None)[0]

TypeError: 'NoneType' object is not subscriptable

In summary, both cannot safely receive blank glyph.
This may cause some problems, for example, use SVGPath draw a pan.
See: https://github.com/fonttools/fonttools/discussions/3231
CFF CharString should accept a empty, see:
https://learn.microsoft.com/en-us/typography/opentype/spec/cff2charstr#42-finishing-a-charstring-outline-definition

The smallest valid CharString is simply an empty byte string.

move to : https://github.com/fonttools/fonttools/issues/3245


Make end2end tests run against a mocked environment

With PR #411 , the following error is surfaced (using a locally defined mock file, on Python 3.9 on macOS):
$ TESTHMC=mocked_z13_dpm make end2end
find . -type d -name 'htmlcov.end2end' | xargs -n 1 rm -rf
bash -c "TESTEND2END_LOAD=true py.test --color=yes  -v -s tests/end2end --cov zhmccli --cov-config .coveragerc.end2end --cov-report=html "
================================================================================= test session starts ==================================================================================
platform darwin -- Python 3.9.16, pytest-7.3.1, pluggy-1.0.0 -- /Users/maiera/virtualenvs/zhmccli39/bin/python
cachedir: .pytest_cache
rootdir: /Users/maiera/Projects/zhmcclient/repos/zhmccli
plugins: cov-4.0.0
collected 1 item

tests/end2end/test_session.py::test_session_success[hmc_definition=mocked_z13_dpm] FAILED/Users/maiera/virtualenvs/zhmccli39/lib/python3.9/site-packages/coverage/control.py:801: CoverageWarning: No data was collected. (no-data-collected)
  self._warn("No data was collected.", slug="no-data-collected")

======================================================================================= FAILURES =======================================================================================
_________________________________________________________________ test_session_success[hmc_definition=mocked_z13_dpm] __________________________________________________________________

hmc_definition = HMCDefinition(nickname='mocked_z13_dpm', description='Mocked z13 in DPM mode', contact='', access_via='', mock_file='/...y_cert=True, cpcs=OrderedDict([('CPC1', OrderedDict([('machine_type', '2964'), ('dpm_enabled', True)]))]), add_vars={})

    def test_session_success(hmc_definition):  # noqa: F811
        # pylint: disable=redefined-outer-name
        """
        Test successful creation and deletion of an HMC session.

        # Data format: "exception name:hex errno:description"
        # Pickle is not used; it is complex and involves memory allocation.
        errpipe_read, errpipe_write = os.pipe()
        # errpipe_write must not be in the standard io 0, 1, or 2 fd range.
        low_fds_to_close = []
        while errpipe_write < 3:
            low_fds_to_close.append(errpipe_write)
            errpipe_write = os.dup(errpipe_write)
        for low_fd in low_fds_to_close:
            os.close(low_fd)
        try:
            try:
                # We must avoid complex work that could involve
                # malloc or free in the child process to avoid
                # potential deadlocks, thus we do all this here.
                # and pass it to fork_exec()

                if env is not None:
                    env_list = []
                    for k, v in env.items():
                        k = os.fsencode(k)
                        if b'=' in k:
                            raise ValueError("illegal environment variable name")
                        env_list.append(k + b'=' + os.fsencode(v))
                else:
                    env_list = None  # Use execv instead of execve.
                executable = os.fsencode(executable)
                if os.path.dirname(executable):
                    executable_list = (executable,)
                else:
                    # This matches the behavior of os._execvpe().
                    executable_list = tuple(
                        os.path.join(os.fsencode(dir), executable)
                        for dir in os.get_exec_path(env))
                fds_to_keep = set(pass_fds)
                fds_to_keep.add(errpipe_write)
>               self.pid = _posixsubprocess.fork_exec(
                        args, executable_list,
                        close_fds, tuple(sorted(map(int, fds_to_keep))),
                        cwd, env_list,
                        p2cread, p2cwrite, c2pread, c2pwrite,
                        errread, errwrite,
                        errpipe_read, errpipe_write,
                        restore_signals, start_new_session,
                        gid, gids, uid, umask,
                        preexec_fn)
E                       TypeError: expected str, bytes or os.PathLike object, not NoneType

/usr/local/Cellar/python@3.9/3.9.16/Frameworks/Python.framework/Versions/3.9/lib/python3.9/subprocess.py:1754: TypeError

---------- coverage: platform darwin, python 3.9.16-final-0 ----------
Coverage HTML written to dir htmlcov.end2end

=============================================================================== short test summary info ================================================================================
FAILED tests/end2end/test_session.py::test_session_success[hmc_definition=mocked_z13_dpm] - TypeError: expected str, bytes or os.PathLike object, not NoneType
================================================================================== 1 failed in 2.12s ===================================================================================
make: *** [end2end] Error 1

Initial analysis shows that create_hmc_session() only supports real HMCs, because it dos not create FakedSession objects for mocked HMCs.
See zhmcclient fixture hmc_session() for how it is done.
However, since delete_hmc_session() and is_valid_hmc_session() depend on working session IDs, we first need to add proper session ID support to the zhmcclient_mock support.

PR https://github.com/zhmcclient/python-zhmcclient/pull/1456 targeted for zhmcclient 1.15.0 provides dynamically created session IDs, and the ability in the FakedHmc class to validate, add and remove session IDs. That should allow to resolve this issue here.


Domain API responses status 200 when bearer token is missing

I just came across a bug that affects at least the JS SDK.
When I call the domain API without a bearer token, it returns a status 200 and data null.
curl --location --request GET 'https://api.pirsch.io/api/v1/domain' \
--header 'Content-Type: application/json' \
--data-raw '{
    "client_id": "[client_id]",
    "client_secret": "[client_secret]"
}'

So the JS SDK doesn't work, because it tries to call the API when creating the client without login and then checks the status in the catch.
https://github.com/pirsch-analytics/pirsch-js-sdk/blob/master/Client.ts#L299

Fixed.


Discussion: ingest table without primary key from cdc connector

Is your feature request related to a problem? Please describe.
Currently, the CREATE TABLE statement requires specifying the primary key for the table. And for the case to create a CDC table, it will validate the PK constraint with the source DB, if the PK definition doesn't match we will reject the CREATE TABLE request.
So if the table in the source DB doesn't have PK, we cannot load it into RisingWave now.
Describe the solution you'd like
Candidate solutions:

Allow the PK constraint in CREATE TABLE to be optional and when users don't specify PK, we will treat the source table as an append-only table in RisingWave.

Allow the PK constraint in CREATE TABLE to be optional, and users have two options:

If they don't specify PK, we will use the whole row as the PK to identify a row uniquely
They can specify a PK for the table, and RisingWave will use the PK to identify a row although the PK doesn't exist in upstream

Personally, I prefer solution 2 which is more flexible.
Describe alternatives you've considered
No response
Additional context
No response

So if the table in the source DB doesn't have PK, we cannot load it into RisingWave now.

Quick question: for debezium connect with kafka, is it possible to create a cdc stream on a source table if the table doesn't have PK?

If they don't specify PK, we will use the whole row as the PK to identify a row uniquely

cc @fuyufjh I remember we have similar discussions before.
IIUC, the concern of implicitly defining PK for the user is that it is hard for the user to understand what results are correct.
For example, assuming the source table only have one column c1 with no PK, there can be multiple rows with the same value on c1 but implicitly using c1 as the PK in our system may produce the result as if there is only one row per c1 value.

So if the table in the source DB doesn't have PK, we cannot load it into RisingWave now.

Quick question: for debezium connect with kafka, is it possible to create a cdc stream on a source table if the table doesn't have PK?

Yes. @BugenZhao has tried this with the debeizum + Kafka stack. debezium can capture CDC events on the table and publish them to the Kafka topic.

So if the table in the source DB doesn't have PK, we cannot load it into RisingWave now.

Quick question: for debezium connect with kafka, is it possible to create a cdc stream on a source table if the table doesn't have PK?

Yes. @BugenZhao has tried this with the debeizum + Kafka stack. debezium can capture CDC events on the table and publish them to the Kafka topic.

what does the message look like, got an example?

what does the message look like, got an example?

https://gist.github.com/BugenZhao/44c0afdcb52281354fb20ecc4df0d5a2#file-dbserver1-inventory-t-json-L781
mysql> show create table t;
+-------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| Table | Create Table                                                                                |
+-------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| t     | CREATE TABLE `t` (
  `v` int DEFAULT NULL,
  `v2` double DEFAULT NULL,
  `v3` char(20) DEFAULT NULL
) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_0900_ai_ci |
+-------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
1 row in set (0.01 sec)

mysql> insert into t values (1111, 1111.1, '1111-1');
Query OK, 1 row affected (0.01 sec)

Allow the PK constraint in CREATE TABLE to be optional and when users don't specify PK, we will treat the source table as an append-only table in RisingWave.

LGTM, but that still only can subscribe the changelog of upstream Append-only table which can not solve all problems.

If they don't specify PK, we will use the whole row as the PK to identify a row uniquely

I think user can not accept that. user can insert two or more rows with the same values in the upstream system and they are duplicated int the table

what does the message look like, got an example?

https://gist.github.com/BugenZhao/44c0afdcb52281354fb20ecc4df0d5a2#file-dbserver1-inventory-t-json-L781
mysql> show create table t;
+-------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| Table | Create Table                                                                                |
+-------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| t     | CREATE TABLE `t` (
  `v` int DEFAULT NULL,
  `v2` double DEFAULT NULL,
  `v3` char(20) DEFAULT NULL
) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_0900_ai_ci |
+-------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
1 row in set (0.01 sec)

mysql> insert into t values (1111, 1111.1, '1111-1');
Query OK, 1 row affected (0.01 sec)

What does the dbz message look like if you issue a delete/update in mysql.
Technically CDC source without PK is not an append only source so the tricky part is how to handle detele. We basically need to know exactly what row is deleted in our system if there is no PK (require a scan or some way to look up row id?)

Suppose that there're two same rows of 1111, 1111.1, 1111-1 and we delete them in a transaction with DELETE FROM t:

Suppose that there're two same rows of 1111, 1111.1, 1111-1 and we delete them in a transaction with DELETE FROM t:

suppose a harder situation...
CREATE TABLE t(v int);
Insert into t values (1). (1), (1);
Delete from t where v =1 limit 2;

Allow the PK constraint in CREATE TABLE to be optional and when users don't specify PK, we will treat the source table as an append-only table in RisingWave.

1 doesn't make sense to me because there are definitely updates on that table. In another words, I don't think "missing PK" means append-only. No relation between them.

Allow the PK constraint in CREATE TABLE to be optional, and users have two options:

If they don't specify PK, we will use the whole row as the PK to identify a row uniquely

This won't work because there may be more than one row with all values identical.

They can specify a PK for the table, and RisingWave will use the PK to identify a row although the PK doesn't exist in upstream

This seems just pretending to work...

May I ask the motivation? Is it necessary or urgent?
Because in my mind, most data pipelines deoesn't support or have poor support for non-PK tables. (e.g. DTS). Compared with doing such tricky (and low performance) solution, I would rather recommend users to just create a PK.

Just a thought...
In postgres cdc there is a [REPLICA IDENTITY](https://debezium.io/documentation/reference/stable/connectors/postgresql.html#postgresql-replica-identity). When set to default:

If a table does not have a primary key, the connector does not emit UPDATE or DELETE events for that table. For a table without a primary key, the connector emits only create events. Typically, a table without a primary key is used for appending messages to the end of the table, which means that UPDATE and DELETE events are not useful.

Although other dbs like MySQL and SQLServer do not have such specifications, we can allow users to do CDC without primary key if they know they only append their source table. We can force our connector to ignore/warn any UPDATE/DELETE.

For now, we can draw a conclusion that users need to create a primary key for the CDC tables.


Hotfix/ga4gh validation

Make us conformant with https://github.com/ga4gh/tool-registry-validator

[x] Check that you pass the basic style checks and unit tests by running mvn clean install

Coverage increased (+62.9%) to 73.623% when pulling e3a45738b536a1002ae0f9988b88dc05dcb4582c on hotfix/ga4gh_validation into 70c1eed96b91ec549a0a20be78665b453bc64000 on master.


Regression spotted with 11.0.13+8 and 11.0.12+7 on macOS (Catalina)

Summary
Using Adoptium JRE 11.0.13+8 and 11.0.12+7, on macOS Catalina, our application hangs in native code when invoking CGraphicsDevice.nativeGetScreenInsets(int), whereas same code works just fine with AdoptOpenJDK 11.0.11+9.
Note: issue reproduced also with Zulu JRE.
Note: not reproduced on BigSur (I don't have access to Monterrey to perform same test).
Steps to reproduce

build attached snippet (eclipse rcp) with Maven: com.st.demoapps.zip

cd  com.st.demoapps
mvn clean verify

execute it using above combination of JRE versions

./releng/com.st.demoapps.product/target/products/com.st.demoapps.product/macosx/cocoa/x86_64/Eclipse.app/Contents/MacOS/eclipse

JRE can be configured within eclipse.ini file:
./releng/com.st.demoapps.product/target/products/com.st.demoapps.product/macosx/cocoa/x86_64/Eclipse.app/Contents/Eclipse/eclipse.ini

add the following lines prior to -vmargs line:
-vm
<JAVA_PATH>/Contents/Home/lib/jli/libjli.dylib

notice that the UI is never displayed if using 11.0.13+8 (or 11.0.12+7) on Catalina and that the java stack looks like:

Thread [AWT-EventQueue-0] (Suspended)
        CGraphicsDevice.nativeGetScreenInsets(int) line: not available [native method]
        CGraphicsDevice.getScreenInsets() line: 133
        LWCToolkit.getScreenInsets(GraphicsConfiguration) line: 487
        CViewEmbeddedFrame(Window).init(GraphicsConfiguration) line: 518
        CViewEmbeddedFrame(Window).<init>() line: 549
        CViewEmbeddedFrame(Frame).<init>(String) line: 423
        CViewEmbeddedFrame(Frame).<init>() line: 388
        CViewEmbeddedFrame(EmbeddedFrame).<init>(long, boolean) line: 95
        CViewEmbeddedFrame(EmbeddedFrame).<init>(long) line: 92
        CViewEmbeddedFrame(EmbeddedFrame).<init>() line: 80
        CViewEmbeddedFrame.<init>(long) line: 48
        SWT_AWT.initFrame(long, String) line: not available [native method]
        SWT_AWT$1.run() line: 154
        InvocationEvent.dispatch() line: 313
        EventQueue.dispatchEventImpl(AWTEvent, Object) line: 770
        EventQueue$4.run() line: 721
        EventQueue$4.run() line: 715
        AccessController.doPrivileged(PrivilegedAction<T>, AccessControlContext) line: not available [native method]
        ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(PrivilegedAction<T>, AccessControlContext, AccessControlContext) line: 85
        EventQueue.dispatchEvent(AWTEvent) line: 740
        EventDispatchThread.pumpOneEventForFilters(int) line: 203
        EventDispatchThread.pumpEventsForFilter(int, Conditional, EventFilter) line: 124
        EventDispatchThread.pumpEventsForHierarchy(int, Conditional, Component) line: 113
        EventDispatchThread.pumpEvents(int, Conditional) line: 109
        EventDispatchThread.pumpEvents(Conditional) line: 101
        EventDispatchThread.run() line: 90

If you have access to different macOS version notice also that the same use-case works fine on BigSur (and Monterrey?)
Expected results
Application should not hangs are startup.
Actual results
No UI visible, only an icon in macOS dock.
Triaging info
Java version:
openjdk version "11.0.13" 2021-10-19
OpenJDK Runtime Environment Temurin-11.0.13+8 (build 11.0.13+8)
OpenJDK 64-Bit Server VM Temurin-11.0.13+8 (build 11.0.13+8, mixed mode)

What is your operating system and platform?
macOS Catalina 10.15.3 on x86-64
How did you install Java?
ZIP archive picked on https://adoptium.net/
Did it work before?
Changing the runtime environment is enough to trigger the issue.
Did you test with other Java versions?
openjdk version "11.0.13" 2021-10-19 LTS
OpenJDK Runtime Environment Zulu11.52+51-CA (build 11.0.13+8-LTS)
OpenJDK 64-Bit Server VM Zulu11.52+51-CA (build 11.0.13+8-LTS, mixed mode)

openjdk version "11.0.12" 2021-07-20
OpenJDK Runtime Environment Temurin-11.0.12+7 (build 11.0.12+7)
OpenJDK 64-Bit Server VM Temurin-11.0.12+7 (build 11.0.12+7, mixed mode)

➡ Fails
openjdk version "11.0.11" 2021-04-20 LTS
OpenJDK Runtime Environment Zulu11.48+21-CA (build 11.0.11+9-LTS)
OpenJDK 64-Bit Server VM Zulu11.48+21-CA (build 11.0.11+9-LTS, mixed mode)

openjdk version "11.0.11" 2021-04-20
OpenJDK Runtime Environment AdoptOpenJDK-11.0.11+9 (build 11.0.11+9)
OpenJDK 64-Bit Server VM AdoptOpenJDK-11.0.11+9 (build 11.0.11+9, mixed mode)

➡ Works
openjdk version "17.0.1" 2021-10-19
OpenJDK Runtime Environment Temurin-17.0.1+12 (build 17.0.1+12)
OpenJDK 64-Bit Server VM Temurin-17.0.1+12 (build 17.0.1+12, mixed mode, sharing)

➡ Works but we're currently stuck on Java 11 LTS.

@JDESTM Are you able to quickly try one of the nightlies at https://adoptium.net/nightly.html?variant=openjdk11&jvmVariant=hotspot

Thanks @karianna ! Yes I confirm this nightly build solves the hang/freeze at startup 👍
By curiosity do you have any reference to the initial issue triggering a fix in the version to come ?

I'm not 100% sure but there are ~20 AWT/Mac OS X fixes in 11.0.14 / 17.0.2. The full release notes will come out in late Jan


Add items - Possibility to pin a project as a favorite

Describe the bug
When I do the portfolio management then I normally work with a handful projects. It would be very beneficial if I could mark my often used project as favorites.
Browser
Choose a browser
[x] Chrome
Version
[x] Azure DevOps/VSTS

Sorry, but this code in this repo is not currently being maintained. We recommend you use the Delivery Plans feature that is core to Azure DevOps.


The expiration-cleanup-interval setting breaks the plugin, and is not used correctly

If you set expiration-cleanup-interval to a value > 0 in the config, when the plugin loads, claims that should exist don't, and inspection/claiming tools such as the stick and gold shovel don't print messages to chat.
Additionally, the setting is never used, and instead a hardcoded interval of 10 seconds is passed to the scheduler:
Sponge.getScheduler().createTaskBuilder()
        .interval(10, TimeUnit.SECONDS)
        .execute(cleanupTask)
        .submit(GDBootstrap.getInstance());

Fixed in commit https://github.com/bloodmc/GriefDefender/commit/c1e5843482c00a9b09d9539713c8781ff71658a2


Add mysql schema and indexes ensurer to ops

What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #1646
Does this PR introduce a user-facing change?:

NONE

Nice.
/lgtm

Great job.
/lgtm

/lgtm

Thank you!
/approve


Adding contributor and Crossover/Crossunder functions

Adding contributor and Crossover/Crossunder functions

Sorry, you can't remove the check for python and talib in the tests. They are required to run virtually all other tests.

Thanks!


Pimp occurrences replaced with Enrich

Hi there, this PR renames all the Pimp occurrences with Enrich (i.e.: it fixes #309).
Hope it is enough!
Cheers,
@P3trur0

To validate this pull request against other sbt modules, visit THIS LINK.

Thank you very much!

A dbuild validation involving this pull request is in progress...

dbuild has checked the following projects against Scala 2.12:

Project
Reference
Commit

sbt
1.0.x
sbt/sbt@25d393bd8b34e3bf72d129c2427349c7aa881701

zinc
pull/326/head
sbt/zinc@85716654f18ac39aa6bf5e243293623d7b9a2c15

io
1.0
sbt/io@880de81bcc9bd4308885d2515d0a1b746026b946

librarymanagement
1.0
sbt/librarymanagement@7e87603b5fd3fa0d0ce38f6e85755d3973ddf114

util
1.0
sbt/util@54cf4a43bb560d2e6fdc48fb51a376ca4228da03

website
1.0.x
sbt/website@5c32a0afcf64dc600ff154f5456026e2a74dc668

:x: The result is: FAILED
(restart)

A dbuild validation involving this pull request is in progress...

dbuild has checked the following projects against Scala 2.12, 2.11, 2.10:

Project
Reference
Commit

sbt
1.0.x
sbt/sbt@25d393bd8b34e3bf72d129c2427349c7aa881701

zinc
pull/326/head
sbt/zinc@85716654f18ac39aa6bf5e243293623d7b9a2c15

io
1.0
sbt/io@880de81bcc9bd4308885d2515d0a1b746026b946

librarymanagement
1.0
sbt/librarymanagement@7e87603b5fd3fa0d0ce38f6e85755d3973ddf114

util
1.0
sbt/util@54cf4a43bb560d2e6fdc48fb51a376ca4228da03

website
1.0.x
sbt/website@5c32a0afcf64dc600ff154f5456026e2a74dc668

:x: The result is: FAILED
(restart)

A dbuild validation involving this pull request is in progress...

dbuild has checked the following projects against Scala 2.12:

Project
Reference
Commit

sbt
1.0.x
sbt/sbt@25d393bd8b34e3bf72d129c2427349c7aa881701

zinc
pull/326/head
sbt/zinc@85716654f18ac39aa6bf5e243293623d7b9a2c15

io
1.0
sbt/io@880de81bcc9bd4308885d2515d0a1b746026b946

librarymanagement
1.0
sbt/librarymanagement@7e87603b5fd3fa0d0ce38f6e85755d3973ddf114

util
1.0
sbt/util@54cf4a43bb560d2e6fdc48fb51a376ca4228da03

website
1.0.x
sbt/website@5c32a0afcf64dc600ff154f5456026e2a74dc668

:x: The result is: FAILED
(restart)


Wolfenstein port

Hi there is a port for retropie of wolfenstein enemy territory to add it in your script
https://retropie.org.uk/forum/topic/26863/new-port-installer-et-legacy

I'm working on this, but to be honest, his script is a complete mess. Easier to start from scratch, which I will be doing.

Tried just building directly - not scripting it for Retropie - and it failed to run. I'll come back to this another time.


langchain-google-vertexai: Update vision_models.py to allow kwargs usage

Checklist for PR Creation

[x] PR Title: "langchain-google-vertexai: Update vision_models.py to allow kwargs usage"

[x] PR Description and Relevant issues:

This change touches _prepare_params() methods in order to avoid that keys not included in default parameters are filtered out systematically

def _prepare_params(self, **kwargs: Any) -> Dict[str, Any]:
        params = self._default_params
        for key, value in kwargs.items():
             if key in params and value is not None:
                    params[key] = value

changed to:
def _prepare_params(self, **kwargs: Any) -> Dict[str, Any]:
        params = self._default_params
        for key, value in kwargs.items():
             if value is not None:
                   params[key] = value

This change also touches all the final calls to vertexai image related functions when they take into account the additional parameters, they were only taking into account, for some reason, messages[0].additional_kwargs, instead kwargs coming from outer functions calls were not taken into account and have been added:

        image_str_list = self._generate_images(
            prompt=user_query, **messages[0].additional_kwargs
        )

changed to:
        image_str_list = self._generate_images(
            prompt=user_query, **messages[0].additional_kwargs, **kwargs
        )

Relevant issues: It was not possible to use kwargs like {"safety_filter_level": "block_few", "person_generation": "allow_all"} from langchain-core BaseChatModel invoke() method. They got filtered out and never reached the final image generation call.

No specific dependencies required for this fix.

[ ] Add Tests and Docs:

None

[x] Lint and Test:

The amount of changes is limited to very specific points and should not require lint check, as you can see
I have tested it by directly pip installing from this commit hash

PR Description
This PR addresses the impossibility to use additional kwargs with models classes' methods inside langchain_google_vertexai/vision_models.py. E.g.: It was not possible to pass parameters like  {"safety_filter_level": "block_few", "person_generation": "allow_all"} to the image generation, these parameters used to get filtered out systematically.
Relevant issues

Type

🐛 Bug Fix

Alternatively, instead of disabling the filtering out of non-default keys contained inside self._default_params, all the useful parameters should be added to default_params accordingly.
Of course this alternative approach would require continuous timely update of the list of default params.
Both options are OK and would allow library users to effectively use kwargs.

Thanks for your contribution!
I'm not fully sure it's an ideal way of doing things. An alternative would be to add additional keys to default_params with None values (to be tested, but typically protos on the server side handle None values well). Since after this change if a user includes into kwargs an argument that is not supported by the proto, the model will fail (since this argument will be always passed further).
@efriis @baskaryan  What is the general approach, should we be graceful to any argument in **kwargs that is not accepted by the underlying model, or should we fail? Maybe I'm overthinking here.

Thanks for your contribution!
I'm not fully sure it's an ideal way of doing things. An alternative would be to add additional keys to default_params with None values (to be tested, but typically protos on the server side handle None values well). Since after this change if a user includes into kwargs an argument that is not supported by the proto, the model will fail (since this argument will be always passed further).
@efriis @baskaryan  What is the general approach, should we be graceful to any argument in **kwargs that is not accepted by the underlying model, or should we fail? Maybe I'm overthinking here.

I totally agree, I am not sure as well.
It depends on what is the exact purpose of default_params, I might have interpreted it wrong.
If it is there to automatically fill them with default values that are only eventually replaced by kwargs if a key is there, then filtering out additional keys might be an undesired behavior, just a leftover.
If default_params is more like a supported_params, then yes, it makes more sense to add all the supported keys to default_params.
I think any solution allowing to use at least the actually supported params (adding them is perfect) would work fine from a library-user POV, anything is better then just having the additional params just silently ignored, I think (even a crash or error would be better so that the user is at least aware of whether or not them are taken into account). From the mantaining POV, adding all supported params to default_params means possibly editing this code every time vertexai library and model handles new parameters or drops a parameter, while accepting all of them without filtering them out, only puts the responsibility of passing actually existing parameters on the user side.

@TommasoPetrolito feel free to take a look how it works here, please:
https://github.com/langchain-ai/langchain-google/blob/895822116bb92fa256c1da36d700754e2f7782b5/libs/vertexai/langchain_google_vertexai/chat_models.py#L605
maybe we could align the approach, wdyt?

@TommasoPetrolito feel free to take a look how it works here, please:
https://github.com/langchain-ai/langchain-google/blob/895822116bb92fa256c1da36d700754e2f7782b5/libs/vertexai/langchain_google_vertexai/chat_models.py#L605
maybe we could align the approach, wdyt?

Hello, thank you again for your feedback, it is not 100% clear to me what you mean here. Do you suggest to proceed on a code change approach involving checks on the supported parameters that imitates / is coherently aligned with the code as done here:

https://github.com/langchain-ai/langchain-google/blob/895822116bb92fa256c1da36d700754e2f7782b5/libs/vertexai/langchain_google_vertexai/chat_models.py#L605

?
Or you mean that we should discuss the approach a bit further here and align our views on the approach after a discussion?
I can, for sure, change my code proposal inside vision_models.py to include a supported_params specific variable/property for each vision model (listing all supported params already handled by vertexai library and models) and implement a check with filtering based on those variable/property instead of default_params, that would then be used only for the automatic filling-in of default values for those default_params key=value pairs, not to filter out params.
What do you think?
Thank you again.


Support for Grid Layout in SortableList Component

 Branch : vivek20Eng:feature/grid-layout-support
[Pull Request] (https://github.com/rodrigodagostino/svelte-sortable-list/pull/4)
Description:
I am using the SortableList component from the @rodrigodagostino/svelte-sortable-list package and I am trying to arrange items in a grid format (It only support Horizontal or Vertical). However, the component does not seem to support the grid layout correctly when arranging items. The items should be draggable within a grid, and they should wrap to the next line if there's not enough space on the current line.
Steps to Reproduce:

Create a SortableList component with items.
Apply CSS Grid to arrange items in a grid format.
Enable drag-and-drop functionality within the grid.
Support Touch Screen.

Expected Behavior:
The items should be draggable within the grid, maintaining the grid structure and wrapping to the next line if there's not enough space.
Actual Behavior:
The items are not maintaining the grid structure when dragged. The drag-and-drop functionality doesn't work as expected in the grid format.
Code Example:
    import { SortableList, sortItems, type SortableListProps } from '@rodrigodagostino/svelte-sortable-list';
    import<EMAIL_ADDRESS>
    let items: SortableListProps['items'] = [
        { id: 1, text: 'Item 1', image: 'https://via.placeholder.com/150' },
        { id: 2, text: 'Item 2', image: 'https://via.placeholder.com/150' },
        { id: 3, text: 'Item 3', image: 'https://via.placeholder.com/150' },
        { id: 4, text: 'Item 4', image: 'https://via.placeholder.com/150' },
    ];

    function handleSort(event: CustomEvent) {
        const { prevIndex, nextIndex } = event.detail;
        items = sortItems(items, prevIndex, nextIndex);
    }
</script>

<SortableList
    {items}
    direction="horizontal"
    on:sort={handleSort}
    class="album-grid"
>
    {#each items as item}

{item.text}

    {/each}
</SortableList>

looking for this feature..
its needed

Hi, @vivek20Eng! :)
Yes, as you’ve pointed out, currently there’s not support for grid layouts, but it is something I might consider adding in the future. Since it’s much more complicated than moving things around in a single axis and there are a lot of moving parts involved in the process, a feature like that would imply quite a lot of work, and, to be honest, I have my hands full with an important refactoring to improve the overall flexibility of the package.
But if you’d like to contribute to that feature, you are very welcome to do so :)

Feature Request: Grid Layout Support for SortableList Component
📌 Current Situation
We are currently using the SortableList component from the @rodrigodagostino/svelte-sortable-list package in our project. While this component works well for horizontal and vertical layouts, we've identified a need for grid layout support to enhance our user interface.
💡 Requested Feature
We kindly request the addition of grid layout support to the SortableList component. This feature would allow items to be arranged and dragged within a grid structure, with automatic wrapping to the next line when space is limited.
📈 Use Case
In our application, we need to display and allow reordering of items in a grid format. This layout is crucial for efficiently using screen space and providing a more intuitive interface for our users, especially on devices with larger screens.
🚧 Current Limitations

The component currently only supports horizontal or vertical layouts.
Attempting to implement a grid layout using CSS results in unexpected behavior during drag-and-drop operations.
Items do not maintain their grid positions when dragged.
Adding icons to sortable items in a grid format causes issues with layout and drag-and-drop functionality.

🛠 Proposed Solution
We suggest modifying the SortableList component to:

Add a new layout prop that accepts 'grid' as a value, in addition to 'horizontal' and 'vertical'.
Implement logic to handle item positioning and reordering within a grid structure.
Ensure that items wrap to the next line when there's insufficient space in the current row.
Maintain grid structure integrity during drag-and-drop operations.
Fix issues related to adding icons to sortable items when in grid format.

📝 Code Example
Here's a basic example of how we envision using the grid layout:

<SortableList
  {items}
  layout="grid"
  on:sort={handleSort}
>
  {#each items as item (item.id)}

      🔧
      {item.content}

  {/each}
</SortableList>

📋 Additional Considerations
The grid layout should be responsive, adapting to different screen sizes.
Touch screen support should be maintained for mobile devices.
Accessibility features should be considered in the grid layout implementation.
🎯 Benefits
Implementing grid layout support would significantly enhance the flexibility and usability of the SortableList component, making it more versatile for various application designs and improving the overall user experience. Fixing the issue with icons in grid format will also ensure a smoother user experience.
We appreciate your consideration of this feature request and are happy to provide any additional information or clarification needed. Thank you for your excellent work on this component, and we look forward to the possibility of this enhancement.

🛠 Current Issue
When sorting in grid format, items do not align correctly. This issue is being fixed.

Due to inactivity, I will be closing this one for the time being.
Feel free to reopen it if you get back to work on it :)


Release on maven central

Couldn't find any version of this project on maven central. Any chance to release the current version soon?

+1

Instead of releasing this to maven central, what about migrating it to a submodule of the existing Prometheus simple client? They are both Apache 2 License...

I see that there has been a discussion not to have this as a sub-module of the Prometheus simple client, see: https://github.com/prometheus/client_java/pull/15
But how can we proceed to keep this project active, and also provide a maven central version? Any thoughts from the maintainers?

I agree that it would be really helpful to have a Maven Central release. In the mean time, you could use Jitpack to obtain the latest release artifacts. (https://jitpack.io/#soundcloud/prometheus-hystrix/3.1.0)

Is there any current plans on releasing this to maven central? Would be really helpful for us.

This project is essentially orphaned. Ideally, somebody would show up to take over the maintainer role and fork this outside of the SoundCloud GitHub org. Then that person could go forward with Maven etc.

I'm volunteering as a new maintainer. Like @beorn7 suggested I forked the repository: ahus1/prometheus-hystrix.
The Release 3.1.0 is now available on Maven Central: http://repo1.maven.org/maven2/de/ahus1/prometheus/hystrix/prometheus-hystrix/
I've pushed a pull request #6 to update the central README.

Thank you very much. I'll close this issue, but file a new one to graveyard this repo after a grace period.


Erroneous data returned with WHERE in SHOW TAG VALUES

Bug report
System info:
InfluxDB : 1.4.2
OS : Red Hat Enterprise Linux Server 7.4 (Maipo)
Currently, I'm working with two measurements with tag layouts as such...
> show tag keys
name: apstats
tagKey
------
agent_host
index

name: aptable
tagKey
------
agent_host
index
wlanAPIpAddress
wlanAPName

In Grafana I'm attempting to make two template variables, the second one hidden.  Basically I want to list out all names of a certain tag, then in the second variable be able to select all values of the tag 'index', filtered of course by the value selected in wlanAPName.  This will generate an actionable list that I can then use to filter queries in the second measurement (apstats) by the 'index' tag.  The 'index' tag in the aptable measurement is shorter than the tag value of 'index' in the apstats measurement as follows...
aptable 'index' = <IP_ADDRESS>.203.98                            < this is a dot-decimal mac
apstats 'index' = <IP_ADDRESS>.<IP_ADDRESS>.<IP_ADDRESS>.80    < this is a dot-decimal mac, radio number, and bssid dot decimal mac

These are the queries I'm using in Grafana...
$ap = SHOW TAG VALUES FROM aptable WITH KEY = wlanAPName
$wlan = SHOW TAG VALUES FROM aptable WITH KEY = "index" WHERE wlanAPName =~ /$ap/

The problem is, the WHERE clause seems to be completely ignored.  The only variable I can get it to accept in the where clause is 'agent_host'.  All others seem to be disregarded, and instead of only giving me the 'index' tag values where 'wlanAPName' matches the selected value.  I've tried it manually on the Influx CLI as well, with the same results.
Why am I doing this?  Trying to at least somewhat get around this...  https://github.com/influxdata/telegraf/issues/3256

So I just destroyed both measurements, redid my telegraf configuration to pile all of the tags and fields for this into a single measurement, and now I seem to be able to use the WHERE clause as expected for this (same queries).  Strangely, the tags I was using before were all in the same measurement too, so I wouldn't expect this to change behavior.


Added missing twig blocks to admin file order-general-info

1. Why is this change necessary?
The file sw-order-create-general-info.html.twig is hard to extend via an extension, because it has no twig blocks defined.
2. What does this change do, exactly?
This change only adds some twig blocks to the already existing file.
3. Describe each step to reproduce the issue or behaviour.
There is nothing to describe.
4. Please link to the relevant issues (if any).
5. Checklist

[x] I have rebased my changes to remove merge conflicts
[ ] I have written tests and verified that they fail without my change
[x] I have created a changelog file with all necessary information about my changes
[ ] I have written or adjusted the documentation according to my changes
[ ] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I have read the contribution requirements and fulfil them.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

As a general rule, we don't add new twig blocks anymore and expect people to use the Meteor SDK.
But we're willing to make an exception here. Due to our internal linting rules, you need to add the following line before each new block:
<!-- eslint-disable-next-line sw-deprecation-rules/no-twigjs-blocks -->
Also, please add empty lines between and ending and a newly beginning block.

Your PR has been merged. Thank you for your contribution 💙 🎉


Implement functionality to reproduce "the board"

"The board" was a picture of REG's upcoming allocation as a graphic table. Months went across, people went down. Later, we reproduced this in project "Wimbledown", a web-server-based approach. However, Wimbledown is often down.
The proposal of this issue is to extend whatwhat to produce an ascii version of the board. Note that:

in this output, only Forecast data will be used, and no cross-checks with the GitHub project will be run.

[ ] Create new "command" which just prints something.


Split trust location flag for input and for pileup data

replace #6752

@amaltaro, with this patch it seems it is pulling down the work to LQ,
Please review. I won't include in the tag now until you review.
There are a couple of minor issues.

when this is updated agent if the all the job are not create from previous workflow following code change is needed in WMTask - so wmagent branch patch need to have this.

    def getTrustSitelists(self):
        """
        _getTrustSitelists_

        Get the input and pileup flag for 'trust site lists' in the task.
        """

        if hasattr(self.data.constraints.sites, "trustPUlists"):
            trustPUlists =self.data.constraints.sites.trustPUlists
        else:
            trustPUlists = False
        return (self.data.constraints.sites.trustlists, trustPUlists)

unittest need to be fixed

Thanks,

Alan, feel free to close this patch if you updated yours.

Thanks a lot for your help Seangchan, I'm closing this one and we merge #6752. Thanks!


highwater mark for GC

Description
Having a highwater mark for automated GC will help in constrained environments.
Motivation
In some situations it is important to maintain system integrity. Because of the nature of the stronghold, it is possible to bloat the backing file to a point that could trigger undesirable behaviour, such as NO_SPACE_LEFT_ON_DEVICE.
Requirements
Write a list of what you want this feature to do.

Mark a record as GC'able
Add a setting for auto GC
Consider dropping a field and creating a new one

Open questions (optional)
In the case of 3 above, will we need a reftable?

I don't think this is still relevant for us, it should be managed by the consumer of the client.


fix: Account address does not match while creating profile

Thank you for your contribution to the Koda - Generative Art Marketplace.
👇 __ Let's make a quick check before the contribution.
PR Type

[x] Bugfix

Needs QA check

@kodadot/qa-guild please review

Context

[x] Closes #10373

Did your issue had any of the "$" label on it?

[x] My DOT address: Payout

Screenshot 📸

[x] My fix has changed something on UI; a screenshot is best to understand changes for others.

Does it work?
imho backend expects some substrate address cc @daiagi

That's correct. Backend works in substrate address

Anyway backend would need some work:

https://github.com/kodadot/private-workers/issues/171


Wasm

I've managed to implement transformSyncand trasnformFileSync within a wasm module.
Currently, it does not have same api as @swc/core and only two methods are implemented.
Benchmark result
(Note: es2015 = es5 as there's no compiler pass to convert es2015 code to es5 code)
[transform]
  swc (es3) x 391 ops/sec ±2.03% (62 runs sampled)
  swc-wasm (es3) x 94.30 ops/sec ±11.77% (65 runs sampled)
  swc (es2015) x 623 ops/sec ±0.65% (86 runs sampled)
  swc-wasm (es2015) x 151 ops/sec ±0.45% (81 runs sampled)
  swc (es2016) x 1,768 ops/sec ±0.96% (88 runs sampled)
  swc-wasm (es2016) x 526 ops/sec ±0.60% (88 runs sampled)
  swc (es2017) x 1,778 ops/sec ±0.57% (89 runs sampled)
  swc-wasm (es2017) x 535 ops/sec ±0.54% (86 runs sampled)
  swc (es2018) x 2,363 ops/sec ±1.34% (89 runs sampled)
  swc-wasm (es2018) x 745 ops/sec ±0.62% (87 runs sampled)
  swc-optimize (es3) x 543 ops/sec ±0.59% (87 runs sampled)
  babel (es5) x 35.56 ops/sec ±5.80% (53 runs sampled)

It's 3 ~ 4 times slower than the prebuilt binary.
Btw, I'm not sure about the way to implement async apis.

Please land this PR, it's such a game-changer!

@vovaguguiev Can you tell me your usecase? I think x3 slowdown is not a simple issue.
Note: As typical usage of swc involves multiple promises, swc is 60+ times faster than babel.
However, wasm version does not support such threading. So it's only 6x times faster than babel.

I would like to use it in a Cloudflare Worker, the options I have there are either JS or WASM. Even 5x speed up comparing to Babel is a great improvement for my use case because of workers’ limits on CPU time per request (50ms)

The alternative I am exploring right now is to try and use swc directly from rust code that I compile to wasm, I could write a custom transformation, that I need, directly in Rust similar to how transform-react and other are implemented. Do you think it’s a viable option?

@vovaguguiev Oh... Fair point.
I forgot environments where native binaries are restricted.
I'll start working on this right now.

@vovaguguiev I'm pinging you because it's almost done.
I only implemented transformSync, parseSync and printSync at the moment. Is it enough for your use case?
I can't make apis related to file because wasm does not support it and I'm not sure if threading is supported in wasm.

@kdy1 Thanks a lot! I think sync versions are enough for my case. Look forward to trying it!

Published<EMAIL_ADDRESS>

@vovacodes did you ever see success with this in a Cloudflare worker? Curious to know what kind of performance / use case you had?


Remove the legacy compile dets table support

The legacy dets tab is what Riak TS used to store compile state in 1.2 and previous.
We do not support upgrade/downgrade to 1.2 now because of breaking client APIs, so it can be removed.  The table itself is not removed.
This is in support of the DDL upgrade work. Removing it means we do not have to support the legacy table in ongoing changes.

Yeah! Great to see the clean up.

+1 a21b6ce
DO NOT complete the merge until 1.4 is tagged and shipped.

@borshop merge


FastHTML not rendering font correctly

Hello,
First of all I am new to FastHTML so if there is something I am fundamentally doing wrong, I would love to know that.
I am building a website with a video player and a chat interface. I have organized my pages into modules with each page having its set of doc attribute which I import and bind to route in main.py
The basic page for video + chat looks like this
from fasthtml.components import *

_css = r"""
body, h1, p, input, button {
    font-family: 'Poppins', sans-serif;
}

 body {
    display: flex;
    justify-content: center;
    align-items: center;
    height: 100vh;
    margin: 0;
    background-color: #f4f4f4;
    color: #333;
}
.container {
    display: flex;
    max-width: 90%;
    box-shadow: 0 4px 8px rgba(0,0,0,0.1);
    border-radius: 8px;
    background: white;
    height: 80vh;
}
.video-player {
    flex: 3;
    padding: 20px;
    text-align: center;
}
.chat-sidebar {
    flex: 1;
    border-left: 1px solid #ccc;
    display: flex;
    flex-direction: column;
    justify-content: space-between;
    padding: 20px;
}
h1 {
    color: #ff6347; /* Tomato color */
    font-weight: 600; /* Poppins semi-bold */
}
p {
    color: #555;
    font-weight: 400; /* Poppins regular weight */
}
.button {
    background-color: #ff6347;
    color: white;
    padding: 10px 20px;
    border-radius: 5px;
    border: none;
    transition: background-color 0.3s;
    float: right;
    clear: both;
    font-weight: 500; /* Poppins medium weight */
}
.button:hover {
    background-color: #e5533d;
}
.input {
    width: calc(100% - 22px);
    padding: 10px;
    margin-top: 20px;
    margin-bottom: 10px;
    box-sizing: border-box;
    border: 1px solid #ccc;
    border-radius: 5px;
    font-weight: 400; /* Poppins regular weight */
}
.separator {
    border-bottom: 1px solid #ddd;
    margin-bottom: 10px;
}
"""
head = Head(
    Meta(charset="UTF-8"),
    Meta(name="viewport", content="width=device-width, initial-scale=1.0"),
    Link(rel="stylesheet", href="https://fonts.googleapis.com/css2?family=Poppins:wght@400;500;600&display=swap"),
    Title("Video and Chat Interface"),
    Style(_css)
)

video_player = Div(cls="video-player")(
    H1("Lesson 1: Introduction to Python Programming"),
    Video(width="100%", height="auto", controls=True)(
        Source(src="../test.mp4", type="video/mp4"),
        "Your browser does not support the video tag."
    )
)

chat_messages = Div(cls="chat-messages", style="overflow-y: auto;")(
    P("Chat messages go here..."),
    # Additional chat messages would be added here as P() components or similar.
)

chat_input = Div()(
    Input(type="text", cls="input", placeholder="Type your message..."),
    Div(cls="separator"),
    Div(Button("Send", cls="button"), style="margin-top: 10px;")
)

chat_sidebar = Div(cls="chat-sidebar")(
    chat_messages,
    chat_input
)

container = Div(cls="container")(
    video_player,
    chat_sidebar
)

body = Body(
    container
)

doc = Html(head, body)

When this is generated as HTML at the moment, the font `Poppins' does not apply to the page at all. And when I inspect the css from the frontend I can see that there is a css error saying invalid font-family. It looks like this
body, h1, p, input, button {
  font-family: '
}

I am also new to frontend development so please bare with me. Any help appreciated!

Okay. Apparently removing the single quotes' around the font name makes it work. I would say that is counter intuitive.


Fix TensorFlow Requirements for Rosetta Mac

Describe changes
If you run on an M1/M2 Mac under Rosetta, the TF requirements are currently set incorrectly because platform.machine() == 'x86_64' under Rosetta.
Pre-requisites
Please ensure you have done the following:

[x] I have read the CONTRIBUTING.md document.
[ ] If my change requires a change to docs, I have updated the documentation accordingly.
[ ] If I have added an integration, I have updated the integrations table and the corresponding website section.
[ ] I have added tests to cover my changes.

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Other (add details above)

Hmm apparently this breaks the CI runners. Any ideas how we can distinguish Rosetta M1 Macs from regular Intel Macs?

Apparently, tensorflow-macos does not work under all Mac versions, at least the CI runners break. Thus, the proposed change doesn't make sense and since it's a niche issue it is probably not worth further investigation.


feat: make metastorage platform agnostic & configurable

What changed? Why?

Add a MetaStorageType config
Make MetaStorage interface platform agnostic, i.e. EventDDBEntry -> EventEntry, and add internal conversion functions
Make EventsToChainAdaptor platform agnostic
Turn the DynamoDB implementation into a sub package
Use named factory to create MetaStorage instance according to config

How did you test the change?

GitHub Actions
Run backfill (go run ./cmd/admin backfill --blockchain bsc --network mainnet --env local --start-height 32306000 --end-height 32306010) with localstack
Run backfill workflow: go run ./cmd/admin workflow start --workflow backfiller --input '{"StartHeight": 18398700, "EndHeight": 18398710, "NumConcurrentExtractors": 5}' --blockchain ethereum --network mainnet --env local

Let me break this down.

Replaced by linked PRs above.


Remove duplicated method Problem::resetConfigValidation and clearConfigValidation.

@DianeBury A question to make sure I do not do a mistake. Is there any reason to have this do methods ?
There implementation is slightly different. One calls method clear of the ConfigValidations object. The other create a new object.

Both are kept because they allow to do different things.


Moving RS4 changes to master

This change includes the following fixes

Added a new mechanism to mark reentrancy. When a helper calls into user code we will have to explicitly either set the implicit call flags or mark that call as reentrancy safe
Added checks in lowerer to confirm that we emit an implicit call bailout check after a helper call
Added failfasts, under a config flag, to validate the int range assumptions made in Globopt
Added check to make sure an opcode that can't have implicit call do not lower a helper call that can have implicit calls
Moved the reentrancy lock assert to Recycler right before dispose
Fixed an issue where during expression evaluation we were not restoring the updated block id in case of a parenthesis in destructed params
Along with ignoring null valuetype bit, also ignore undefined bit in the IsSimilar function as ToDefinite() strips out the undefined bit
Assert that we don't have a reentrancy lock when calling Dispose in a deterministic way.

Is there a reason you didn't merge this to 1.8?

The following files have some bad formatting changes:
lib/Backend/GlobOpt.cpp
lib/Backend/Lower.cpp
lib/Backend/LowerMDShared.cpp
lib/Common/Memory/Recycler.cpp
lib/Parser/Parse.cpp
lib/Runtime/Language/InterpreterStackFrame.cpp
lib/Runtime/Language/JavascriptOperators.cpp
otherwise LGTM

Looks good to me

@MSLaguana As these are not security fixes we don't have to service them on release/1.8. Putting them in master and letting it flow seems the best thing to do.

That's how we've done previous ones as well. Previous release changes go into the active working branch.

@aneeshdk ok. I thought it might have been simpler to take them to the 'closer' branch to where they came from.

@tcare For RS3, at least, we merged the changes into release/1.6. I'm in favor of doing the merge to release/1.8 as well, as that would make the branches identical (modulo whitespace), and as release/1.8 is the current serviced public branch, we'd be able to avoid having to potentially make separate fixes for RS4 and GitHub.

@curtisman opinion on merging to a release branch?

master is fine as these are not security fixes.   We can reconsider it next time.


Skip externalization step

It turned out, that I pushed #37 without this change. So here it is.

lgtm


command 'C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v11.2\bin\nvcc.exe' failed with exit code 2

I tried to install rational_kat_cu in my project venv with the following command:
pip install -e .
Every time I try I receive this:
command 'C:\\Program Files\\NVIDIA GPU Computing Toolkit\\CUDA\\v11.2\\bin\\nvcc.exe' failed with exit code 2
somebody can help me?

hello，I tried to commend pip install -e.  ,but some error

i need help

Hello @yueqiaohuayuan can you please provide more context for this error? What system/envs/gcc version are you using?

你好@yueqiaohuayuan您能否提供更多有关此错误的信息？您使用的是什么系统/环境/gcc 版本？

hello，My system is win11，and，python=3.12.7，and“kat”is my virtual environment，but，But some problems still exist，I hope you can tell me the detailed configuration，I am a new student, I hope you can explain it in more detail，"系统找不到指定文件" in the picture means that the system cannot find the specified file.thanks，thanks，thanks！！！


Vault and IAM integration

name: Pull request template
about: Make a PR to terraform-aws-foundation
Please include the following in your PR:
Please also note that these are not hard requirements, but merely serve to define
what maintainers are looking for in PR's.  Including these will more likely lead
to your PR being reviewed and accepted.

[x] Update the changelog
[x] Make sure that modules and files are documented. This can be done inside the module and files.
[x] Make sure that new modules directories contain a basic README.md file.
[x] Make sure that the module is added to tests/main.tf
[ ] Make sure that the linting passes on CI.
[x] Make sure that there is an up to date example for your code:
- For new modules this would entail example code for how to use the module or some explanation in the module readme.
- For new examples please provide a README explaining how to run the example. It's also ideal to provide a basic makefile to use the example as well.
[ ] Make sure that there is a manual CI trigger that can test the deployment.

I'd like to make the following changes before merging:

make vault-iam a module
use a data source for the policy JSON
parametize the vtest in arn:aws:iam::${data.aws_caller_identity.current.account_id}:user/vtest-* with a variable that defaults to vault
update the vault-s3-private example to use the vault-iam module
drop the aws provider from the vault-aws-backend module
consider dropping the vault_aws_secret_backend resource and use a make target (this resource would include admin secrets in Terraform's state file)

@ketzacoatl On further thought, I think we should remove the entire vault-aws-backend module itself from terraform (because we don't want admin secret in Terraform's state file and just having vault_aws_secret_backend_role resource isn't useful).
Also, I don't think it is useful for us to make vault-s3-private use vault-iam module, because they are not dependent. Only the running vault server's secret engine needs the access keys from the vault-iam module. No other output from vault-iam is actually needed for it in vault-s3-private. I think the right way for us to proceed would be:

Have make target step for the vault-iam module. This step will create access keys which has to exposed via environment variables by us manully for the next step.
Have another make target step (like what you have suggested) to create AWS secret engine path and create an appropriate role for this. (This step will completely replace the vault-aws-backend module). This step will require proper environment variable for access keys to be present for it to work.

What do you think ?

Yes, that sounds good.
I would comment though, that if there are no secrets, and we can do it in Terraform, we ought to. Some of the vault configuration can be done in Terraform and doesn't include secrets. Those should stay in Terraform. IDK if that is relevant to the vault-aws-backend module, I haven't reviewed the code in a few days.

@psibi are these updates WIP or is it ok to have one of our engineers make those updates?


Connection Reuse Test

Pull Request Checklist
Please leverage this checklist as a reminder to address commonly occurring feedback when submitting a pull request to make sure your PR can be reviewed quickly:
See the detailed list in the contributing guide.

[ ] C++ Guidelines
[ ] Doxygen docs
[ ] Unit tests
[ ] No unwanted commits/changes
[ ] Descriptive title/description

[ ] PR is single purpose
[ ] Related issue listed

[ ] Comments in source
[ ] No typos
[ ] Update changelog
[ ] Not work-in-progress
[ ] External references or docs updated
[ ] Self review of PR done
[ ] Any breaking changes?

/azp run cpp - storage

/azp run cpp - storage

/azp run cpp - storage

/azp run cpp - storage

Start updateDistinctServers with uppercase U, and suggestion - move UpdateDistinctServers() to unnamed namespace.

Agree. We should limit the visibility of this symbol if it's only used in this file.
Actually I would even thought we should make this function a lambda inside of the test case. Because this function is only used in this single test case.

/azp run cpp - storage


Updates for release 1.0.788

Updates for release 1.0.788

Docs Build status updates of commit 4727976:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

powerbi-ps/MicrosoftPowerBIMgmt.Admin/Get-PowerBIActivityEvents.md
:white_check_mark:Succeeded
View (powerbi-ps)

powerbi-ps/MicrosoftPowerBIMgmt.Admin/MicrosoftPowerBIMgmt.Admin.md
:white_check_mark:Succeeded
View (powerbi-ps)

powerbi-ps/MicrosoftPowerBIMgmt.Reports/MicrosoftPowerBIMgmt.Reports.md
:white_check_mark:Succeeded
View (powerbi-ps)

powerbi-ps/MicrosoftPowerBIMgmt.Reports/Remove-PowerBIReport.md
:white_check_mark:Succeeded
View (powerbi-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Introducing DensityMapbox

Density Mapboxes are very important graph objects do display datasets over an entire or a portion of the world map

Here's an example of what I'm currently able to draw.

I'll set ready for review when basic features work, and I provided at least 1 test method and associated documentation

Hello @igiagkiozis,
any chances to get a review on this ?

@igiagkiozis, @mfreeborn
any chances to have this at least discussed ?

up @igiagkiozis, @mfreeborn

will most likely (when I don't have better things to do) publish a secondary library of this, since this is not maintained

Hello,
@andrei-ng any chances to discuss this in a near future ? no emergency though. One of my app would like to see the density plots unlocked at some point

Yes, I will have a look at it in the second part of next week. Let's discuss then. Can you in the meantime rebase it on main so the CI is triggered.

@andrei-ng
thank you very much for looking into this, sorry i'm currently away and was unable to rebase this branch
see you

@andrei-ng
thank you very much for looking into this, sorry i'm currently away and was unable to rebase this branch
see you

No worries. Happy I was able to update your branch


29 travis tests for all python3 versions and 2.7

FIX #29
CONFIG support python 3.5 and 3.6

Codecov Report

Merging #32 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #32   +/-   ##
=======================================
  Coverage   88.88%   88.88%
=======================================
  Files           8        8
  Lines         189      189
=======================================
  Hits          168      168
  Misses         21       21

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c55b2e...33f1114. Read the comment docs.


3 bars (body, stun, end)

Need 3 bars for the token.  Body, Stun, and Endurance.  Seems wrong to require barbrawl.


Default2

As it stands this will regress the debug_full_compile_millis benchmark by ~10% and the hotReloadDevFSSyncMillisecondsAfterChange benchmark (i.e. hot reload) by about 100ms in the median case. We shouldn't land this until we are at least on par with current performance metrics.


Integer 4-bit precision arithmetic computation

Will RISC-V v-extension support integer 4-bit precision arithmetic computation?
It's getting popular in low precision convolution of deep learning.  The efficiency should be improved obviously.

https://github.com/riscv/riscv-v-spec/blob/master/v-spec.adoc#divided-element-extension-zvediv
On Wed, Apr 17, 2019 at 2:54 PM Heng-Kuan Lee<EMAIL_ADDRESS>wrote:

Will RISC-V v-extension support integer 4-bit precision arithmetic
computation?
It's getting popular in low precision convolution of deep learning. The
efficiency should be improved obviously.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/riscv/riscv-v-spec/issues/136, or mute the thread
https://github.com/notifications/unsubscribe-auth/ABMAPWN2YLS6Y5K7FMTGYMLPQ6L7RANCNFSM4HGYECKQ
.


Update naga to gfx-23

SPV capabilities are a bit relaxed now, and there's been a whole ton of fixes in Naga, revealed through testing of Dota2 and Vange-rs.

bors r+

bors r+


Clearer Directions for the Linux Version

I would like to ask how to use the Linux version of the app. (I'm running PopOS 21.04) I have installed the .deb package and tried running it both directly (I was greeted with a "There is no application installed for “shared library” files." error) and via terminal from the usr/bin folder but I couldn't see any indicator of it working. Clearer Linux instructions would be greatly appreciated.

Never mind I figured it out:

Download the latest release.
Install it with Eddy. (By double clicking it.)
Install the "Tray Icons: Reloaded" Gnome extension.
Launch a game.
Navigate to the /usr/bin directory, open a terminal window there (in the nautilus file explorer by right clicking on bin and selecting "Open in Terminal").
Type in: ./remoteplaywhatever
You should see an icon in the top panel that looks like a portal logo. Click on it.
Either invite a friend from there or create an invite link and you're set.
Happy playing!

If you want to see it with your other programs make a new text file call it remoteplaywhatever.desktop save it in /home/[YOUR USERNAME]/.local/share/applications and put this with your username added into it:
[Desktop Entry]
Encoding=UTF-8
Name=Remote Play Whatever
Comment=Synchronize any game over internet.
Exec=/usr/bin/remoteplaywhatever
Terminal=true
Type=Application
Icon=/home/[YOUR USERNAME]/Pictures/Icons/steam-controller.png
Categories=Network;FileTransfer;Game;

@m4dEngi Can you also add something like
Arch linux users can use the [AUR package](https://aur.archlinux.org/packages/remoteplaywhatever-bin) (maintained by users)
to the readme file?


find the json_t object size in bytes

I am working on a program that runs on a hardware with a very small size RAM, it seemed like I ran out of memory. Is there a way to find out how big is a json_t object, my object includes some directories of different values like integer, string, and boolean. I tried the sizeof function, but it always return 4.

I'm afraid there's no such function. A json_t is a complex value, and its size may differ greatly if the value is e.g. an object.


Http3 support

Good day!
I have been using poem for some time now and have been impressed by its flexibility and ease of use.
I would love to see HTTP/3 support added to the Rust POEM framework. I see that there is already experimental support for HTTP/3 in the Hyper (https://github.com/hyperium/hyper/issues/1818)

Yes, poem deps on hyper.
We will support HTTP/3 when it is ready.


Documentation on css import

[] bug report => search github for a similar issue or PR before submitting
[x ] feature request
[ ] support request => Please do not submit support request here

For future questions,
We also need to import datatable.css (it does not mention in the documentation).
The only thing you wrote is that we need to import the material.css for material theme.
Thanks

Someone added this, cheers!


conduit-1.3.0

conduit-1.3.0 is out of bounds for:

[ ] HTTP-4000.3.9 (>=1.1 && < 1.3). No maintainer. @haskell. Used by: test-suite
[ ] aws-0.18 (>=1.1 && < 1.3). No maintainer. @aristidb. Used by: library
[ ] binary-conduit-1.2.5 (>=1.1 && < 1.3). Michael Snoyman<EMAIL_ADDRESS>@snoyberg. @qnikst. Used by: library, test-suite
[ ] cassava-conduit-<IP_ADDRESS> (==1.2.*). Dom De Re<EMAIL_ADDRESS>@domdere. @domdere. Used by: library, test-suite
[ ] classy-prelude-conduit-1.3.1 (>=1.0 && < 1.3). No maintainer. @snoyberg. Used by: library, test-suite
[ ] conduit-connection-<IP_ADDRESS> (>=1.1 && < 1.3). Sebastian Dröge<EMAIL_ADDRESS>@sdroege. @sdroege. Used by: library, test-suite
[ ] conduit-iconv-<IP_ADDRESS> (>=1.1 && < 1.3). Sebastian Dröge<EMAIL_ADDRESS>@sdroege. @sdroege. Used by: library, test-suite, benchmark
[ ] fold-debounce-conduit-<IP_ADDRESS> (>=1.2.4 && < 1.3). Toshio Ito<EMAIL_ADDRESS>@debug-ito. @debug-ito. Used by: library, test-suite
[ ] hOpenPGP-2.5.5 (>=0.5 && < 1.3). Clint Adams<EMAIL_ADDRESS>@clinty.. Used by: library, test-suite, benchmark
[ ] http-conduit-2.2.4 (>=1.1 && < 1.3). Michael Snoyman<EMAIL_ADDRESS>@snoyberg. @snoyberg. Used by: library, test-suite
[ ] imagesize-conduit-1.1 (>=1.1 && < 1.3). Silk<EMAIL_ADDRESS>@bergmark @hesselink. Used by: library, test-suite
[ ] irc-client-<IP_ADDRESS> (==1.2.*). Michael Walker<EMAIL_ADDRESS>@barrucadu. @barrucadu. Used by: library
[ ] irc-conduit-<IP_ADDRESS> (==1.2.*). Michael Walker<EMAIL_ADDRESS>@barrucadu. @barrucadu. Used by: library
[ ] lzma-conduit-1.2.0 (>=1.0 && < 1.3). Michael Snoyman<EMAIL_ADDRESS>@snoyberg. @alphaHeavy. Used by: library, test-suite
[ ] machines-0.6.3 (>=1.0 && < 1.3). Edward Kmett<EMAIL_ADDRESS>@ekmett. @RyanGlScott. Used by: benchmark
[ ] req-conduit-1.0.0 (>=1.2.8 && < 1.3). Mark Karpov<EMAIL_ADDRESS>@mrkkrp. @mrkkrp. Used by: library, test-suite, benchmark
[ ] sandi-0.4.1 (==1.2.*). Josh Holland<EMAIL_ADDRESS>@jshholland. @magthe. Used by: library
[ ] soap-<IP_ADDRESS> (>=<IP_ADDRESS> && < 1.3). Alexander Bondarenko<EMAIL_ADDRESS>@wiz.. Used by: library
[ ] stm-conduit-3.0.0 (>=1.0 && < 1.3). Alexander Vershilov<EMAIL_ADDRESS>@qnikst. @cgaebel. Used by: library, test-suite
[ ] withdependencies-<IP_ADDRESS> (==1.2.*). Simon Marechal<EMAIL_ADDRESS>@bartavelle. @bartavelle. Used by: library, test-suite
[ ] xls-0.1.0 (>=1.1 && < 1.3). Harendra Kumar<EMAIL_ADDRESS>@harendra-kumar. @harendra-kumar. Used by: library, executable
[ ] yesod-auth-fb-1.8.1 (>=1.0 && < 1.3). Felipe Lessa<EMAIL_ADDRESS>@meteficha. @psibi. Used by: library

conduit-1.2.13 (Stackage upper bounds) is out of bounds for:

[ ] html-conduit-1.3.0 (>=1.3). No maintainer. @snoyberg. Used by: library
[ ] yesod-bin-1.6.0 (>=1.3). Michael Snoyman<EMAIL_ADDRESS>@snoyberg. @snoyberg. Used by: executable
[ ] yesod-eventsource-1.6.0 (>=1.3). Michael Snoyman<EMAIL_ADDRESS>@snoyberg. @snoyberg. Used by: library
[ ] yesod-websockets-0.3.0 (>=1.3). Michael Snoyman<EMAIL_ADDRESS>@snoyberg. @snoyberg. Used by: library

I've revised machines' upper version bounds on conduit to allow 1.3.0.

binary-conduit version was updated to 1.3.0, it supports conduit-1.3.0 now https://hackage.haskell.org/package/binary-conduit-1.3

withdependencies should be ok now.

Fixed in req-conduit, revision 1.

soap revised

Fixed in irc-client and irc-conduit

Uploaded fold-debounce-conduit-<IP_ADDRESS>. This should be compatible.

hOpenPGP should be okay now

I've adjusted the version range for sandi (0.4.1).

conduit-iconv should be fixed with the <IP_ADDRESS> release I just uploaded

And conduit-connection with the <IP_ADDRESS> release

Fixed xls, uploaded xls-0.1.1

amazonka-core should be in the list. See
https://github.com/brendanhay/amazonka/pull/448
Also fb fails
[ 2 of 16] Compiling Facebook.Monad   ( src/Facebook/Monad.hs, /tmp/matrix-worker/1517736158/dist-newstyle/build/x86_64-linux/ghc-8.0.2/fb-1.1.1/build/Facebook/Monad.o )

src/Facebook/Monad.hs:165:48: error:
    • Could not deduce (R.MonadUnliftIO m)
        arising from a use of ‘R.runResourceT’
      from the context: (R.MonadResource m, MonadBaseControl IO m)
        bound by the type signature for:
                   runResourceInFb :: (R.MonadResource m, MonadBaseControl IO m) =>
                                      FacebookT anyAuth (R.ResourceT m) a -> FacebookT anyAuth m a
        at src/Facebook/Monad.hs:(162,1)-(164,40)
      Possible fix:
        add (R.MonadUnliftIO m) to the context of
          the type signature for:
            runResourceInFb :: (R.MonadResource m, MonadBaseControl IO m) =>
                               FacebookT anyAuth (R.ResourceT m) a -> FacebookT anyAuth m a
    • In the first argument of ‘(.)’, namely ‘R.runResourceT’
      In the second argument of ‘(.)’, namely
        ‘R.runResourceT . runReaderT inner’
      In the second argument of ‘(>>=)’, namely
        ‘lift . R.runResourceT . runReaderT inner’

I've come to realise that it's not really appropriate for me to act as Stackage maintainer for the packages listed under me, since I have no particular connection to them. Is the process to retire as a maintainer simply submitting a pull request to remove myself from build-constraints.yaml?

Yes, exactly. If you want you can instead move to the "Abandoned packages" section instead.

stm-conduit-4.0.0 works with latest conduit. (Required major bump as semantics of some functions has to change, as conduit do not guarantee resource finalization now).

xml-conduit should be in the list. However it appears to be already patched for 1.3 in snoyberg/xml#123.

cassava-conduit should be patched soon.

fb, yesod-fb and yesod-auth-fb has been fixed.

https://www.stackage.org/nightly-2018-03-12/package/criterion-<IP_ADDRESS>

https://www.stackage.org/nightly-2018-03-12/package/conduit-1.3.0