Store doesn't update properly when switching pages

Describe the bug
I've noticed an issue while working on a project in the latest version of SvelteKit. I have a navbar on my site with a background color I'm dynamically setting with a css variable and a svelte writable string store. In my code, I'm setting the color on mount (there's no change if I set the color where the logo flag is being set
    import dayjs from 'dayjs';
    import JsBarcode from 'jsbarcode';
    import { onMount } from 'svelte';
    import { showLogo, color } from '$lib/components/navbar/navbarStores';

    // ..field setups

    showLogo.set(true);

    onMount(() => {

        // ..other page load logic

        color.set(`${data.primaryColor}20`);
    });

Navbar.svelte:
<script lang='ts'>
    import { fade } from 'svelte/transition';
    import { flip } from 'svelte/animate';
    import { showLogo, color } from '$lib/components/navbar/navbarStores';

    import logo from '$lib/assets/svg/icon.svg';

    let navItems = [
        [
            { a: '/discord', t: 'discord' },
            { a: '/thanks', t: 'thanks' }
        ]
    ];

    $: {
        if ($showLogo)
            navItems = [...navItems, [{ a: '/', t: 'logo' }]];
        else
            navItems = [...navItems.filter(i => i[0].t !== 'logo')]
    }

    $: {console.log($color)}
</script>

<nav style='--bg: {$color};'>

This issue only happens with the string store, the logo flag works perfectly.
Reproduction
Set up multiple pages with an element applied in a layout that has a color affected by a nav store, set the color to change in the pages script section, and observe the color inconsistently updating,
Logs
No response
System Info
System:
    OS: Windows 10 10.0.22000
    CPU: (16) x64 AMD Ryzen 7 3700X 8-Core Processor
    Memory: 31.54 GB / 63.92 GB
  Binaries:
    Node: 17.3.1 - C:\Program Files\nodejs\node.EXE
    npm: 8.3.0 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Edge: Spartan (44.22000.120.0)
    Internet Explorer: 11.0.22000.120
  npmPackages:
    svelte: ^3.45.0 => 3.45.0

Severity
annoyance

I've attempted to recreate a minimal version of my project to reproduce the issue and it seems to be working as expected, so i'll just link to the repository for you to take a look at

I've done a little more testing, and here's what I've observed: The issue occurs when navigating between 2 specific pages in my project, so far I haven't be able to reproduce it anywhere else. If you update the store a little bit after the page mounts (specifically, about 100 ms), it behaves as expected, so I do have a workaround if this issue is deemed unsolvable.

I've figured out the cause, it has nothing to do with SvelteKit and was caused by a scroll animation library misbehaving. My bad!


Right-Click 1.71

Describe the bug
Upgraded to latest version 1.71 and rendered view of todo items on Mac OS Obsidian 0.12.7 doesn't bring up context menu for link or completing.
To Reproduce
Steps to reproduce the behavior:

Go to rendered task
Right Click on task. Only "Copy" appears

Expected behavior
Right clicking on a task will now open a context menu where you can either complete the task or open it in the browser or application.
Screenshots
Added.
Desktop (please complete the following information):

Plugin Version [e.g. 1.7.1

]
Obsidian Version [e.g. 0.12.7]

Additional context
Add any other context about the problem here.

Hey @ParzivalWins, I'm unable to reproduce this on my (Windows) machine. It seems as though this might be a MacOS only bug?
Unfortunately, I don't have access to a MacOS machine to test on.

This might have been fixed in v1.9.0 as the way the right-clicking menu was handled was changed. Going to close this for now, if this issues persists after upgrading, please reopen!


Revert "Return the complete response, not just first chunk"

Reverts lukasreichart/skipper-azure#3
Sorry about this - the issue with data corruption was caused by my own incorrect usage of the library. It is not very good practice to buffer the whole file into memory before returning it to client, anyway...

Closing due to no interest to merge this. You should be aware that the current implementation is very inefficient because it buffers the file's contents into memory (in full) before delivering to the client, completely breaking Skipper's main purpose of streaming all data.

@robertrossmann I am open for ideas how to improve this

The solution to the problem was in the pull request, you just need to merge it. 👍


APKAM - access changes for monitor and notification verbs

Is your feature request related to a problem? Please describe.
When user is authenticated via APKAM, allow only the keys with authorized namespaces to flow through the verbs.

Monitor verb: Allow only the notification where keys with authorized namespaces to stream through the monitor connection.
Notify verb: Allow only the notification where keys with authorized namespaces to be processed through the notify verb.

Describe the solution you'd like

Refer to the implementation https://github.com/atsign-foundation/at_server/pull/1443
In monitor verb handler, add a check to verify if the namespaces of a key are authorized with enrollmentId used to authenticate.
Similar to monitor verb, add a check in notify verb check for authorization of namespace.

Describe alternatives you've considered
No response
Additional context
No response

Not started in PR66.carrying over

In PR-67, spent 5 SP, implemented the changes.
The changes are available in enroll_access_changes.

No progress made in PR-68. Waiting on the PR: https://github.com/atsign-foundation/at_server/pull/1496 to merge.
Pending work is pull the latest changes of APKAM and resolve merge conflicts

@gkc : Regarding the APKAM changes in "notify" verb, when recipient lacks access to a specific namespace, should a notification be sent or return error message? Additionally, if the recipient has subscribed to a namespace but lacks the authorization to write, should the cached key be stored or ignored?

I'd like you to think this through and come to a conclusion, and then we can discuss your conclusion

Following is the PR related the APKAM changes in monitor verb: https://github.com/atsign-foundation/at_server/pull/1525
Attaching the sequence diagram of APKAM functionality with respect to monitor verb:
sequenceDiagram
    participant w as Wavi-Approving App
    participant s as Server
    participant b as Buzz-Enrolling App

    rect rgb(200,200,200)
    note right of w: First App Enrollment
    w->>s: CRAM Authenticated
    s->>w: Auth Successful
    note right of w: __manage, * and wavi are added to enroll namespace list
    w->>s: Start monitor:selfNotifications
    s->>w: Stream all notifications via the monitor
    end

    rect rgb(190,190,190)
    note left of b: Second app requesting enrollment
    b->>s: Request for enrollment - {buzz:rw}
    note left of b: Enrollment in pending state. Monitor will not receive notifications untill approved
    s->>w: Notify the enrollment request for approve/deny
    w->>s: Enrollment approved
    s->>b: Inform enrollment status - approved
    b->>s: Start monitor:selfNotifications
    s->>b: Stream only buzz namespace notifications on monitor
    end

    rect rgb(180,180,180)
    w->>s: Enrollment denied/revoked
    b->>s: start Monitor
    s->>b: Auth failed. Cannot execute monitor verb.
    end

I'd like you to think this through and come to a conclusion, and then we can discuss your conclusion

My thoughts are, it is necessary to validate whether the intended recipient has the proper authorization to receive the notification.
The rationale for this assertion is outlined as follows:

Currently, the recipient lacks the ability to control the receiving of notifications. Consequently, the sender retains the ability to send notifications, potentially causing the recipient to become overly engaged with processing these notifications. This leads to recipient's server being starved from other jobs.

In instances where a user's interest lies solely in specific notifications – for instance, those marked "wavi" – and no interest exists in receiving notifications with "buzz" namespace, currently, the server still retains "buzz" notifications in its keystore. This results in allocation of memory to unnecessary notifications such as "buzz".

Enabling APKAM access at the recipient's end allows recipient to unsubscribe from notifications of certain namespace. This also serves to prevent the buildup of uncecessary notifications, thereby conserving memory.

Spent 5 SP in PR-69.
APKAM changes for monitor verb is completed and the changes are available in https://github.com/atsign-foundation/at_server/pull/1525. Adding additional SP due to unplanned work around removing the atConnection and regex as instance variables from monitor_verb_handler.dart.

I'd like you to think this through and come to a conclusion, and then we can discuss your conclusion

My thoughts are, it is necessary to validate whether the intended recipient has the proper authorization to receive the notification.
I agree, but I don't understand your rationale as written (see comments below)

The rationale for this assertion is outlined as follows:

Currently, the recipient lacks the ability to control the receiving of notifications. Consequently, the sender retains the ability to send notifications, potentially causing the recipient to become overly engaged with processing these notifications. This leads to recipient's server being starved from other jobs.
Recipient server behaviour is not the primary relevant point. The most important consideration is: should a client receive a notification in a namespace it does not have access to? The answer to that is clearly no, given the whole intent of APKAM is to limit and control client applications' access to specific namespaces

In instances where a user's interest lies solely in specific notifications – for instance, those marked "wavi" – and no interest exists in receiving notifications with "buzz" namespace, currently, the server still retains "buzz" notifications in its keystore. This results in allocation of memory to unnecessary notifications such as "buzz".
This is not relevant. Other client apps may be interested in the buzz namespace

Enabling APKAM access at the recipient's end allows recipient to unsubscribe from notifications of certain namespace.
No the recipient is not unsubscribing. This is controlled by the atServer

This also serves to prevent the buildup of uncecessary notifications, thereby conserving memory.
This is not the case.

Your original question was

@gkc : Regarding the APKAM changes in "notify" verb, when recipient lacks access to a specific namespace, should a notification be sent or return error message? Additionally, if the recipient has subscribed to a namespace but lacks the authorization to write, should the cached key be stored or ignored?

In PR-69, completed the changes related to Monitor verb. Re-estimating to 5-SP in PR-70 for notify verb related changes,

In terms of namespace authorization during enrollment, the secondary server must not impose limitations on the transmission or reception of notifications. Regardless of the enrollment's namespace authorization, the server should facilitate the sending and receiving of notifications without restriction. The validation of namespace authorization should occur at the client when sending notifications to the server and at the server when sending notifications to the client. The later is managed handled in the "monitor" verb.
The changes are related to monitor verb are merged to trunk, and hence closing the issue.


Certain editor operations rely on NOTIFICATION_PHYSICS_PROCESS without a good reason

Tested versions

Reproducible in: 4.2.1.stable, 4.3.dev cae759949

System information
Godot v4.3.dev (cae759949) - Fedora Linux 39 (KDE Plasma) - X11 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 4090 (nvidia; 545.29.06) - 13th Gen Intel(R) Core(TM) i9-13900K (32 Threads)
Issue description
Certain editor operations rely on NOTIFICATION_PHYSICS_PROCESS without a good reason. This is mainly seen through canvas_item_editor_plugin.cpp and node_3d_editor_plugin.cpp.
This has two consequences:

At default physics ticks per second (60), moving around 2D elements in the editor results in the orange box being slightly behind and updating less smoothly on high refresh rate monitors.
At custom physics ticks per second, editor behavior will differ with these elements appearing to lag behind more if the value is lower than 60.

Steps to reproduce
See this 120 FPS video where a Sprite2D is being dragged around quickly (watch it at 0.5× speed or pause at certain moments to make the issue more noticeable):
https://github.com/godotengine/godot/assets/180032/ffc4cd67-29dc-4d41-aec7-f772d60e7ba8
If Physics Ticks per Second project setting is set to 10 and the editor is restarted, the issue becomes more extreme:
https://github.com/godotengine/godot/assets/180032/7bd95c3f-a865-4c9f-8c2d-e014aaed5801
Minimal reproduction project (MRP)
N/A

I submitted a PR and tested the different things that were originally part of physics processes. I didn't notice a difference besides the stuff you mentioned not being broken anymore.


Guardian Quick Cryptics support?

a feature request I guess. it'd be nice to be to download these.
https://www.theguardian.com/crosswords/series/quick-cryptic
e.g., https://www.theguardian.com/crosswords/quick-cryptic/29
no puzzle found

Looks like it would be pretty straightforward to add. document.getElementsByClassName("js-crossword")[0].dataset["crosswordData"] extracts the crossword data in a (new) proprietary JSON format.

Added in CrosswordScraper 1.3.18 (available now for Firefox, pending approval for Chrome).
This only handles simple puzzles as that's all I could find from a quick search. If there are any puzzles with extra features (e.g. circled letters, non-standard numbering, rebus) then it would be great to see an example.
Note that their applet does include markers for hyphenation and stronger bars for word boundaries. But given that the enumerations are given in the clues, this feels more like an app-specific feature than something to encode in the file itself, and the hyphens wouldn't be supported easily in any format anyway.

hi Jeff,
this now works for Guardian Quiptics
https://www.theguardian.com/crosswords/series/quiptic
their Quick Cryptics
https://www.theguardian.com/crosswords/series/quick-cryptic
their (larger) Everyman
https://www.theguardian.com/crosswords/series/everyman
regular Cryptic
https://www.theguardian.com/crosswords/series/cryptic
their Quick (not sure what difference is w/ Quick Cryptics)
https://www.theguardian.com/crosswords/series/quick
their Speedy (not sure if that’s faster than quick…)
https://www.theguardian.com/crosswords/series/speedy
etc.
thanks
Steve

On Oct 28, 2024, at 9:53 PM, Jeff Davidson @.***> wrote:
Added in CrosswordScraper 1.3.18 (available now for Firefox, pending approval for Chrome).
This only handles simple puzzles as that's all I could find from a quick search. If there are any puzzles with extra features (e.g. circled letters, non-standard numbering, rebus) then it would be great to see an example.
Note that their applet does include markers for hyphenation and stronger bars for word boundaries. But given that the enumerations are given in the clues, this feels more like an app-specific feature than something to encode in the file itself, and the hyphens wouldn't be supported easily in any format anyway.
—
Reply to this email directly, view it on GitHub https://github.com/jpd236/CrosswordScraper/issues/46#issuecomment-2443209920, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEIVAQQOVIPN4Y3RYA6B34LZ54IGJAVCNFSM6AAAAABQLH26NOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINBTGIYDSOJSGA.
You are receiving this because you authored the thread.


Update change password in <UserProfile />

Type of change

[ ] 🐛 Bug fix
[x] 🌟 New feature
[ ] 🔨 Breaking change
[ ] 📖 Refactoring / dependency upgrade / documentation
[ ] other:

Packages affected

[x] @clerk/clerk-js
[ ] @clerk/clerk-react
[ ] @clerk/nextjs
[ ] @clerk/remix
[x] @clerk/types
[ ] @clerk/themes
[x] @clerk/localizations
[ ] @clerk/clerk-expo
[ ] @clerk/backend
[ ] @clerk/clerk-sdk-node
[ ] @clerk/shared
[ ] @clerk/fastify
[ ] @clerk/chrome-extension
[ ] gatsby-plugin-clerk
[ ] build/tooling/chore

Description

[x] npm test runs as expected.
[x] npm run build runs as expected.

We take advantage of the new updatePassword method from UserResource
Introduced a new text field for the current password of a user (if that exists)
Introduced a new checkbox that invalidates all other sessions of the user when selected
New localization keys to support the introduced labels

Change password flow (session sign out)
https://user-images.githubusercontent.com/19269911/229761051-15a928d8-3584-4102-af18-c05317158026.mp4
Change password flow
https://user-images.githubusercontent.com/19269911/229761169-bebdfba3-7a4d-48b7-84a0-fc98194210d8.mp4
Set password flow (session sign out)
https://user-images.githubusercontent.com/19269911/229761237-8ac8577b-f3fe-4d0a-a9b2-bc0a30afdfb1.mp4

Why is the account tab highlighted while the breadcrumb says "Security". Is that another bug or did something break here?

Why is the account tab highlighted while the breadcrumb says "Security"? Is that another bug or did something break here?

@desiprisg  good catch, but this seems to be a pre-existring issue. Login and check it here   https://lazy-clerk.vercel.app/user


Bump daemonset parallelism in load test

Ref https://github.com/kubernetes/perf-tests/issues/704

/lgtm
/approve


Timsort in CPP and Java

I want to contribute to your repo.
Can you please assign me this task under the hacktoberfest2021 tag?

Tim Sort Already Merged In Cpp

So should i add it for java?

Ill create issues after checking codes again. leave it for now


[Snyk] Fix for 6 vulnerabilities

Snyk has created this PR to fix 6 vulnerabilities in the maven dependencies of this project.
Snyk changed the following file(s):

jena-fuseki2/jena-fuseki-server/pom.xml

Vulnerabilities that will be fixed with an upgrade:

Issue
Score
Upgrade

Stack-based Buffer Overflow SNYK-JAVA-COMGOOGLEPROTOBUF-8055227
  124
org.apache.jena:jena-text:  4.9.0-SNAPSHOT -> 5.2.0  No Known Exploit

Denial of Service (DoS) SNYK-JAVA-ORGECLIPSEJETTY-8186142
  112
No Known Exploit

Improper Validation of Syntactic Correctness of Input SNYK-JAVA-ORGECLIPSEJETTY-8186141
  62
Proof of Concept

Improper Validation of Syntactic Correctness of Input SNYK-JAVA-ORGECLIPSEJETTY-8186158
  62
Proof of Concept

Denial of Service (DoS) SNYK-JAVA-ORGECLIPSEJETTY-8186168
  50
No Known Exploit

Denial of Service (DoS) SNYK-JAVA-ORGECLIPSEJETTY-8186167
  40
No Known Exploit

Vulnerabilities that could not be fixed

Upgrade:

Could not upgrade<EMAIL_ADDRESS>to<EMAIL_ADDRESS>Reason could not apply upgrade, dependency is managed externally ; Location: provenance does not contain location

[!IMPORTANT]

Check the changes in this PR to ensure they won't cause issues with your project.
Max score is 1000. Note that the real score may have changed since the PR was raised.
This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Denial of Service (DoS)

Checkmarx One – Scan Summary & Details – be3c708c-2b5b-426b-a1ae-5613cc05d32b
New Issues

Severity
Issue
Source File / Package
Checkmarx Insight

CVE-2022-46337
Maven-org.apache.derby:derby-<IP_ADDRESS>
Vulnerable Package

CVE-2023-36478
Maven-org.eclipse.jetty:jetty-http-10.0.15
Vulnerable Package

CVE-2023-43646
Npm-get-func-name-2.0.0
Vulnerable Package

CVE-2023-45133
<EMAIL_ADDRESS>Vulnerable Package

CVE-2024-23331
Npm-vite-4.0.4
Vulnerable Package

CVE-2024-37890
Npm-ws-8.12.0
Vulnerable Package

CVE-2024-4068
Npm-braces-3.0.2
Vulnerable Package

CVE-2024-45296
Npm-path-to-regexp-0.1.7
Vulnerable Package

CVE-2024-45296
Npm-path-to-regexp-1.8.0
Vulnerable Package

CVE-2024-45590
Npm-body-parser-1.20.1
Vulnerable Package

CVE-2024-45801
Npm-dompurify-2.4.3
Vulnerable Package

CVE-2024-47554
Maven-commons-io:commons-io-2.11.0
Vulnerable Package

CVE-2024-47875
Npm-dompurify-2.4.3
Vulnerable Package

CVE-2024-7254
Maven-com.google.protobuf:protobuf-java-3.23.2
Vulnerable Package

CVE-2022-29622
Npm-formidable-1.2.6
Vulnerable Package

CVE-2023-26159
Npm-follow-redirects-1.15.2
Vulnerable Package

CVE-2023-28155
<EMAIL_ADDRESS>Vulnerable Package

CVE-2023-36479
Maven-org.eclipse.jetty:jetty-servlets-10.0.15
Vulnerable Package

CVE-2023-40167
Maven-org.eclipse.jetty:jetty-http-10.0.15
Vulnerable Package

CVE-2023-42503
Maven-org.apache.commons:commons-compress-1.23.0
Vulnerable Package

CVE-2023-44270
Npm-postcss-8.4.21
Vulnerable Package

CVE-2023-45857
Npm-axios-0.27.2
Vulnerable Package

CVE-2023-46749
Maven-org.apache.shiro:shiro-web-1.11.0
Vulnerable Package

CVE-2023-46750
Maven-org.apache.shiro:shiro-web-1.11.0
Vulnerable Package

CVE-2024-25710
Maven-org.apache.commons:commons-compress-1.23.0
Vulnerable Package

CVE-2024-26308
Maven-org.apache.commons:commons-compress-1.23.0
Vulnerable Package

CVE-2024-28849
Npm-follow-redirects-1.15.2
Vulnerable Package

CVE-2024-29041
Npm-express-4.18.2
Vulnerable Package

CVE-2024-31207
Npm-vite-4.0.4
Vulnerable Package

CVE-2024-34343
Npm-ufo-1.0.1
Vulnerable Package

CVE-2024-4067
Npm-micromatch-4.0.5
Vulnerable Package

CVE-2024-43796
Npm-express-4.18.2
Vulnerable Package

CVE-2024-43799
Npm-send-0.18.0
Vulnerable Package

CVE-2024-43800
Npm-serve-static-1.15.0
Vulnerable Package

CVE-2024-45811
Npm-vite-4.0.4
Vulnerable Package

CVE-2024-45812
Npm-vite-4.0.4
Vulnerable Package

CVE-2024-47068
Npm-rollup-3.11.0
Vulnerable Package

CVE-2024-47764
Npm-cookie-0.5.0
Vulnerable Package

CVE-2024-6531
Npm-bootstrap-5.2.3
Vulnerable Package

Cx14b19a02-387a
Npm-body-parser-1.20.1
Vulnerable Package

Use_of_Cryptographically_Weak_PRNG
/jena-arq/src/main/java/org/apache/jena/sparql/expr/E_Random.java: 34
Attack Vector

Fixed Issues

Severity
Issue
Source File / Package

CVE-2022-38900
Npm-decode-uri-component-0.2.2

CVE-2007-2379
Npm-jquery-3.6.3

CVE-2014-6071
Npm-jquery-3.6.3

Host Namespace is Shared
/docker-compose.yaml: 20

Improper_Restriction_of_Stored_XXE_Ref
/jena-iri/src/main/java/org/apache/jena/iri/impl/BuildViolationCodes.java: 35

Improper_Restriction_of_Stored_XXE_Ref
/jena-iri/src/main/java/org/apache/jena/iri/impl/BuildViolationCodes.java: 39

Improper_Restriction_of_Stored_XXE_Ref
/jena-iri/src/main/java/org/apache/jena/iri/impl/BuildViolationCodes.java: 38

Networks Not Set
/docker-compose.yaml: 20


Using sqlType won't generate correct migration file by PgsqlPlatform

Issue: https://github.com/propelorm/Propel2/issues/1336
Patch description:
Added sqlType to condition list when generating column DDL for diff

Oli, this is the wrong repo, you need to make this PR against the real propel repo.


Position of DistanceGrabber is not in sync with the respective ControllerAlias on startup

Environment

VR device: Oculus Quest
Code source: Tilia.Interactions.PointerInteractors.Unity
Code version: 1.0.0
Platform version: Unity 2019.3.14f1
3rd party dependencies:
Tilia.Interactions.Interables.Unity
Tilia.CameraRigs.TrackedAlias.Unity
Tilia.Input.UnityInputManager
Tilia.SDK.OculusIntegration.Unity

Steps to reproduce

Set up new project like mentioned at the HowTo sections. TrackedAlias, VelocityTracker, Oculus Integration, InputManager, etc...
Setup a new Input.UnityInputManager.1DAxisAction + BooleanAction for grabbing (e.g. TriggerLeft).
Add an Interactable.
Add a new Interactor for a ControllerAlias. Hook up the Interactor with the previously created GrabAction and VelocityTracker.
Add the Interactions.PointerInteractors.DistanceGrabber.
Set the Interactor setting to the previously created Interactor.

Expected behavior
The DistanceGrabber should follow along the Interactor to enable pointing via controller movement.
Current behavior
The DistanceGrabber remains at position 0, 0, 0 when starting the application. After grabbing a Interactable manually it suddenly follows along (not everytime). Can be seen best, when placing an Interactable directly in front of the player. After startup you'll see the pointer at the bottom of the Interactable, but it's not following the controller alias.
Temporary fix
Hook up the FollowSource setting of Indicators.ObjectPointers.Straight of the DistanceGrabber to manually enable following the ControllerAlias.
Best regards :)

What object is remaining at the position of 0,0,0?
The DistanceGrabber object will and so will the Pointer object, the object that tracks is the PointsRenderer and that tracks every time for me.

I can't recreate this, maybe someone else can try?

For anyone who wants to test it, I created a GitHub repo -> https://github.com/FireDragonGameStudio/TiliaDistanceGrabBug with my test project and a Youtube Video -> https://youtu.be/wBL-8bUePfA showing the problem.
Sry for beeing so annoying -.-

I still cant recreate the issue in that repo (I'm using 2019.3.13f1 but i don't see how that would make a difference)
Is it doing it for you in the editor or just at build time?

It works correctly when testing in Editor with UnityXR and SpatialSimulator. It only breaks after deploying to my Quest headset.

so it is only a problem when built and deployed to the quest then? That's weird.
The code is all doing what it should be doing, the Grabber config passes the Grabber facade interactor to the internal Pointer Follow Source.
This can happen either if the pointer is still disabled or enabled as properties aren't blocked from being set.
The object follower source within the pointer is set by the pointer config and has a "wait for object follower to become enabled" wrapped around the setting of it, so even if the object follower hasn't been enabled at that time then when it becomes enabled it will still run that hook up code. if it is enabled already then the OnAfter code will run and set it up.
I don't see anywhere that a race condition could cause this.
The only potential issue could be that when Unity builds this out that the malimbe code that deals with this on after logic isn't being compiled properly on android for some reason, but that is really clutching at straws.
@bddckr any ideas on what could be causing this?

I don't think Malimbe is at fault here, it would probably blow up with exceptions in that case. (As Malimbe just weaves some IL it either can be run or it can't, but the IL is the same no matter where you deploy to.)
It definitely sounds like there's some indeterministic behavior we're relying on, which is different in Editor vs on Quest. Therefore your idea of a race condition makes sense to me, though that doesn't seem to be it as you just said.

Maybe I can provide further information, when I test this with Oculus Link in Unity Editor. I'll try that asap and let you know.

The only reason that the object follower source wouldn't be set was if the object follower source observable list wasn't active as we don't allow mutations on inactive components.
But the pointer config uses the wait till enabled code to ensure this can't be the case.
So the only thing that I can think of that could be at fault is that wait till enabled functionality isn't working properly

Short update: Working without problems via Oculus Link.

I'm going to close this as it's become stale


[Flink-15873] [cep] fix matches result not returned when existing earlier partial matches

What is the purpose of the change
(This pull request fixes the bug that matches result may not be returned when existing earlier partial matches in a pattern configured with skip strategy.)
Verifying this change
This change added tests and can be verified as follows:

Added tests in NFAITCase

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not applicable)

@dawidwys could you help to review this pr?

@shuai-xu Thanks for the PR. Actually I don't think this is a bug. It's by design that the matched results should only be emit when there are no partial matches which are early than the matched result. Otherwise, the after match skip strategy will be broken.

@dianfu Thank you very much for review. I didn't see any docs to say that this is a design. And if so, the result will never be omitted if earlier partial failed to match. I agree that the after skip strategy needs refined to have a definite action.

I think we have to do so is because retraction isn't supported in CEP. For example, if the matched results are emit when there are partial matches which are early than the matched result and the partial matches match succeeded in the future, the emitted results may should be refined. However, as retraction is not supported, there is no way to refine the results and so we have to hold the matched results in this case.


Wrap calls from ebpf_drv.c in epoch calls

Description
Ensure that all calls from ebpf_drv.c are to API's that call epoch enter/exit as approriate.
Resolves: #2164
Resolves: #2165
Testing
CI/CD
Documentation
No.

Blocked on #2191

No longer blocked on #2191

Either add a more detailed description of the changes or at least update top level comments in the epoch module.

Switching to draft while I evaluate @shankarseal proposal.


Button clips don't work well, needs re-designing

The button should clip into the base, but also needs to be fixed well so they don't pop out when pressed. Temp fix is glue, but I don't want any glued in parts.
Maybe a screw fixing or bracket..

Also please consider flipping the Pico to expose the bootsel button, as the latest nightly builds of micropython allow the bootsel buttonto be used as user input button, (via https://github.com/micropython/micropython/pull/10935). This reduces the BOM by one button, and it's associated wiring.
An example of such usage can be found at https://github.com/samveen/pico-mpy-2fa-totp/blob/main/password.py#L26

Thanks @samveen , that's a really useful feature. I've been working with some 3d printed buttons, this will work well with it..


Include arch target in release files

Hi! I'm now looking at adding this server to the neovim client :). I was wondering if you think it'd make sense to include the target architecture in the release files, for example opencl-language-server-linux_x86_64.zip? I think it'd help avoid some confusion for people downloading them without thinking about the compatible arch.
Also as a side-note: multi arch builds would be really cool, but they're a bit tedious to set up :D

Oh also, changing the name of a release asset file from one release to another might cause some issues for tools who rely on the same release file existing across releases. If you think it makes sense adding the target arch to the .zip file names, I think it'd be perfectly fine to modify the 0.1 release directly (if this is possible), seeing as this project is so new.

I have updated release assets to:
opencl-language-server-darwin-x86_64.zip
opencl-language-server-linux-x86_64.zip
opencl-language-server-win32-x86_64.zip

The format is opencl-language-server-<platform>-<arch>.

Also as a side-note: multi arch builds would be really cool, but they're a bit tedious to set up :D

Agreed, it would be nice to add fat builds. I hope to get my hands on it some day :)

Great, thanks!! Did #2 manage to make it into the new builds?

Did #2 manage to make it into the new builds?

Sorry, but I did not rebuild the server.

@williamboman, I published artifacts of the fixed server in 0.2.

Thanks @Galarius!!
nvim-lsp-installer picks these releases up automatically 👇 ;)

By the way, I changed zip to tar.gz for macOS and Linux artifacts.
@williamboman, could you update lsp-installer on your side if needed?


[Bug]: AssertionError when load miqu70b after full sft

Your current environment
environment
pip install auto_gptq modelscope xformers torchvision torchaudio torch==2.1.2 -U
pip install datasets huggingface-hub transformers==4.39.1 -U
pip install fastrlock cupy-cuda11x==12.1.0
pip install flash_attn==2.5.6
pip install vllm==0.4.0
🐛 Describe the bug
When I load miqu-70b model after full sft（node: 4,  nproc_per_node: 8）, the following error occurs:
llm = LLM(model=args.ckpt_dir, trust_remote_code=True, seed=42, tensor_parallel_size=torch.cuda.device_count())
File "/home/jeeves/.local/lib/python3.10/site-packages/vllm/entrypoints/llm.py", line 112, in init
self.llm_engine = LLMEngine.from_engine_args(
File "/home/jeeves/.local/lib/python3.10/site-packages/vllm/engine/llm_engine.py", line 196, in from_engine_args
engine = cls(
File "/home/jeeves/.local/lib/python3.10/site-packages/vllm/engine/llm_engine.py", line 110, in init
self.model_executor = executor_class(model_config, cache_config,
File "/home/jeeves/.local/lib/python3.10/site-packages/vllm/executor/ray_gpu_executor.py", line 62, in init
self._init_workers_ray(placement_group)
File "/home/jeeves/.local/lib/python3.10/site-packages/vllm/executor/ray_gpu_executor.py", line 192, in _init_workers_ray
self._run_workers(
File "/home/jeeves/.local/lib/python3.10/site-packages/vllm/executor/ray_gpu_executor.py", line 324, in _run_workers
driver_worker_output = getattr(self.driver_worker,
File "/home/jeeves/.local/lib/python3.10/site-packages/vllm/worker/worker.py", line 107, in load_model
self.model_runner.load_model()
File "/home/jeeves/.local/lib/python3.10/site-packages/vllm/worker/model_runner.py", line 95, in load_model
self.model = get_model(
File "/home/jeeves/.local/lib/python3.10/site-packages/vllm/model_executor/model_loader.py", line 101, in get_model
model.load_weights(model_config.model, model_config.download_dir,
File "/home/jeeves/.local/lib/python3.10/site-packages/vllm/model_executor/models/llama.py", line 404, in load_weights
weight_loader(param, loaded_weight)
File "/home/jeeves/.local/lib/python3.10/site-packages/vllm/model_executor/layers/vocab_parallel_embedding.py", line 86, in weight_loader
assert loaded_weight.shape[parallel_dim] == self.org_vocab_size
AssertionError
(RayWorkerVllm pid=1135) INFO 04-03 14:52:46 pynccl_utils.py:45] vLLM is using nccl==2.18.1
(RayWorkerVllm pid=1135) ERROR 04-03 14:52:49 ray_utils.py:44] Error executing method load_model. This might cause deadlock in distributed execution.
(RayWorkerVllm pid=1135) ERROR 04-03 14:52:49 ray_utils.py:44] Traceback (most recent call last):
(RayWorkerVllm pid=1135) ERROR 04-03 14:52:49 ray_utils.py:44] File "/home/jeeves/.local/lib/python3.10/site-packages/vllm/engine/ray_utils.py", line 37, in execute_method
(RayWorkerVllm pid=1135) ERROR 04-03 14:52:49 ray_utils.py:44] return executor(*args, **kwargs)
(RayWorkerVllm pid=1135) ERROR 04-03 14:52:49 ray_utils.py:44] File "/home/jeeves/.local/lib/python3.10/site-packages/vllm/worker/worker.py", line 107, in load_model
(RayWorkerVllm pid=1135) ERROR 04-03 14:52:49 ray_utils.py:44] self.model_runner.load_model()
(RayWorkerVllm pid=1135) ERROR 04-03 14:52:49 ray_utils.py:44] File "/home/jeeves/.local/lib/python3.10/site-packages/vllm/worker/model_runner.py", line 95, in load_model
(RayWorkerVllm pid=1135) ERROR 04-03 14:52:49 ray_utils.py:44] self.model = get_model(
(RayWorkerVllm pid=1135) ERROR 04-03 14:52:49 ray_utils.py:44] File "/home/jeeves/.local/lib/python3.10/site-packages/vllm/model_executor/model_loader.py", line 101, in get_model
(RayWorkerVllm pid=1135) ERROR 04-03 14:52:49 ray_utils.py:44] model.load_weights(model_config.model, model_config.download_dir,
(RayWorkerVllm pid=1135) ERROR 04-03 14:52:49 ray_utils.py:44] File "/home/jeeves/.local/lib/python3.10/site-packages/vllm/model_executor/models/llama.py", line 404, in load_weights
(RayWorkerVllm pid=1135) ERROR 04-03 14:52:49 ray_utils.py:44] weight_loader(param, loaded_weight)
(RayWorkerVllm pid=1135) ERROR 04-03 14:52:49 ray_utils.py:44] File "/home/jeeves/.local/lib/python3.10/site-packages/vllm/model_executor/layers/vocab_parallel_embedding.py", line 86, in weight_loader
(RayWorkerVllm pid=1135) ERROR 04-03 14:52:49 ray_utils.py:44] assert loaded_weight.shape[parallel_dim] == self.org_vocab_size
(RayWorkerVllm pid=1135) ERROR 04-03 14:52:49 ray_utils.py:44] AssertionError

@zhuohan123

The problem seems to be caused by the file not being saved completely when saving the model after zero3 fine-tuning.

The problem seems to be caused by the model file not being saved completely after zero3 fine-tuning.

how do you solve it at last? i met the same problem

The problem seems to be caused by the model file not being saved completely after zero3 fine-tuning.

have you solve this? i met the same problem

i use swift to sft model, when i set  " load_best_model_at_end = True, save_only_model = False" , the model saved cat load in vllm correctly


Broken math formulae on vscode web

Does this issue occur when all extensions are disabled?: Yes, except built-in extension, md-math

VS Code Version: 1.63.0
OS Version: Windows

Steps to Reproduce:

Access VSCode Web instance (github.dev, vscode.dev) by a web browser such as google chrome
Open Markdown file and write math formulae
Open markdown preview

Note:
VSCode Web sets strict Content Security Policy (CSP) by default configuration. CSP prevents loading inline style sheet appended by markdown-math. So, the limitation breaks math formulae in the preview panel.
I suggest two options as follows.

Set Loose CSP as default (not recommended)
Render equation without CSS

Absolutely, I do not recommend the first option. Then, I suppose to choose the second option.
KaTeX, however, renders the formula by HTML elements (div and span) with CSS stylesheet for typesettings.
My suggestion is to use the MathJax instead of KaTeX to render math formulae because it can render them as SVG elements. As a Proof of Concept, I created an extension and a fork of this repository. The extension especially works fine in github.dev. Please try it.
Thanks for the great software, I would like to help with the improvement by creating a new pull request,
Please do not hesitate to ask me to create it from my fork.

First,

CSP prevents loading inline style sheet appended by markdown-math.

Are you sure?
Even the default policy allows resources over HTTPS:
https://github.com/microsoft/vscode/blob/c6e58d126f6b5676242e32b34180b2a595f29b51/extensions/markdown-language-features/src/features/previewContentProvider.ts#L238

Second, I don't know what happened to you, since I see everything is fine.

Version: 1.63.2
Commit: 899d46d82c4c95423fb7e10e68eba52050e30ba3
Date: 2021-12-15T09:36:48.576Z
Browser: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/97.0.4692.99 Safari/537.36 Edg/97.0.1072.76

Third, I don't think MathJax will be a better solution. The biggest problem is semantics and behavior.
KaTeX, by default, tries its best to follow TeX and LaTeX. But MathJax deliberately diverges in a number of ways. MathJax may surprise users although it's powerful.

@Lemmingh Thank you for inspecting my issue in your environment. I can see this problem in chromium without chrome/ vscode extensions in private/ incognito mode. Further, I read a similar issue in https://github.com/asciidoctor/asciidoctor-vscode/pull/473#issuecomment-1013783915 , perhaps, this issue may not be related directly because Markdown is not Asciidoctor obviously.

Third, I don't think MathJax will be a better solution. The biggest problem is semantics and behavior.
KaTeX, by default, tries its best to follow TeX and LaTeX. But MathJax deliberately diverges in a number of ways. MathJax may surprise users although it's powerful.

I agree with your opinion. We, of course, should take care of the difference between the two renderers.
However, the broken math equation surprises the user than the difference, doesn't it?
The best solution is fixing this issue by KaTeX, but I could not do it and have succeeded with MathJax.
Please try it npx @vscode/test-web to launch complete vanilla vscode. Cheers.

Seems to work for me on vscode.dev:

If it's not working for you, please share an example formula that doesn't render properly
The equations not working when running out of localhost is a browser specific problem. They render fine for me with Chrome, but not in Safari (seemingly because of the https vs http mismatch

@mjbvz I have just get it same result as yours in vscode.dev. I mean that it works fine.
So, last night, I misunderstood my problem. It is not a problem of KaTeX.
As you said, this is a problem of mismatch of http and https, I think so. This is a problem of browser policy.
Then, I guess we can solve this mismatch by replace header 'https://exple.com' by just '://example.com'. As you minght know, the browser can use the same protocol, i.e., http(s) used in the current page.
Would you mind to tell me your comment about this  idea. In my mind, this is should be fixed in upstream.

I believe the error occurs because the VS Code's webview always come from https due to how they are served. As this is only a problem for development and not a problem across all browsers, I don't think it's worth addressing at this time


Image palette extraction and color quantization

Godot version:
3.2+
Description
Image quantization results in a color palette being created. Such algorithms strive to build a palette that covers average colors, so extracted colors can be used to theme a game level/world/character based on an image alone, like adding specific visual effects the base colors of which need to match the overall look of a character. Some things can be done with a shader but propotional palette extraction requires clusterization which is a CPU task, so this might not even be suitable for GPU to handle via shaders. Moreover, the created (proportional) palette can be passed to shaders via uniforms to further style the game, so this can be deemed as the opposite to palette swapping.
Color quantization wiki
Palette wiki

This online service was used to create this example.
The character taken from here.
When I load an indexed image with a palette, it seems like Godot can handle that already. Either way, I need this feature and I think will try to come up with something, either within Image class directly or as a separate module, so I just wonder whether people find this useful.
Proposed interface:
void quantize(int num_colors); // indexed

PoolColorArray get_palette();
void set_palette(const PoolColorArray &palette);

Other use cases
In particular, I need an ability to reduce the number of colors in any image to <256 colors at run-time (having in-game editor for that). The use case is mainly legacy support to have cross-game compatible user-generated content, but I see there are a number of issues opened for other use cases:
#18662, #18269: color reduction, palette creation.
Marginally connected or features that need to be implemented to benefit from this feature fully:
#1315, #10751:

color palette is a PoolColorArray that could be passed to shaders once retrieved from an image.

#9623: color replacement, palette swapping (note: use shaders instead)
Implementations
Found this MIT library for color quantization that I think would be relatively easy to integrate, but perhaps the algorithms are not that difficult to rewrite them in Godot natively? The library can handle images with alpha channel as well.

Are you talking about Posterization?

I don't think this should be built in. Most image editing software can do that easily and it could be done with a simple shader too.
I think it better fits a plug-in.

I'm not necessarily talking about palette swapping as it's clearly doable with a shader. Same goes for posterization.
If Godot handles loading of indexed images, it should also provide an interface to at least retrieve the color palette associated with it, so these colors could be looked up and used for theming as most of the time such palette will have an average/ordered distribution of colors. For instance, one could find a dominant color in such image by fetching a first color in palette, and least dominant color by fetching last color in palette (assuming colors are ordered and constructed according to distribution).
Using image editing software doesn't allow to theme a game if assets are loaded externally by users, so this needs to be done at run-time, before a game starts. Shaders can be overkill for this because I believe colors from a palette could be applied to anything, not only sampling a texture and changing pixels in fragment shader.
Color quantization is a means to create and get such palette from a arbitrary image, which doesn't necessarily means changing the palette in the image.

Implemented as part of ImageTools module via ImageIndexed class as generate_palette method, GDNative module for purely image color quantization might be available at some point once I figure out the build process. Closing.


Accelerate object doesn't access all available GPUs

System Info
accelerate version: 0.12.0
pyorch:1.10

Information

[ ] The official example scripts
[ ] My own modified scripts

Tasks

[ ] One of the scripts in the examples/ folder of Accelerate or an officially supported no_trainer script in the examples folder of the transformers repo (such as run_no_trainer_glue.py)
[ ] My own task or dataset (give details below)

Reproduction
on AWS Sagemaker notebooks:
from accelerate import Accelerator
accelerator = Accelerator(cpu=False)
print(f"ACCELERATOR DEVICE:{accelerator.device}---- NUM OF PROCESSES: {accelerator.num_processes }")

Using the sagemaker pytorch framework to create the training job I'm using the distribution strategy pytorchdbb as follows.
from sagemaker.pytorch import PyTorch
import sagemaker
role = sagemaker.get_execution_role()
pt_estimator = PyTorch(
    base_job_name="transformer-ocr",
    source_dir="source",
    entry_point="main.py",
    role=role,
    py_version="py38",

    framework_version="1.12.0",

    instance_count=1,
    instance_type="ml.p3.16xlarge",
    distribution={
        "pytorchddp": {
            "enabled": True
        }
    }
)

pt_estimator.fit("s3://")

Expected behavior
I'm using the p3.16xlarge instance to train an OCR model on AWS sagemaker, this instance includes 8 GPUs, when I initialize the accelerator object without passing (cpu=False) parameter the accelerator works on CPU and doesn't see the GPU.

when I pass (cpu=False) parameter, and try to print out the number of processes and device it prints only one statement of
"ACCELERATOR DEVICE: cuda---- NUM OF PROCESSES: 1"

what exactly could be the problem here?

the accelerator's distributedType is always Multi_CPU, however the number of the processes is 8 as the number of GPUs, what is the problem exaclty? I installed accelerate through the requirments.txt file as "accelerate[sagemaker]"


Add portions used in DART reading

This should not include the new ontology algorithms which aren't ready for master yet.


Making the code consistent

... and a little bit prettier ✨

@Jake0Tron  Could you please review and resolve the conflicts

What am I resolving? I haven't contributed to this branch..?

Might be worth an eslint to keep things nice over time rather than pr's ...

Sorry @Jake0Tron My fault


[WiP] Order mutations

Closes #2238
Pull Request Checklist

[x] Privileged views and APIs are guarded by proper permission checks.
[x] All visible strings are translated with proper context.
[x] All data-formatting is locale-aware (dates, numbers, and so on).
[x] Database queries are optimized and the number of queries is constant.
[x] The changes are tested.
[x] The code is documented (docstrings, project documentation).

Codecov Report

Merging #2327 into dashboard-2.0 will increase coverage by 0.13%.
The diff coverage is 90.18%.

@@                Coverage Diff                @@
##           dashboard-2.0    #2327      +/-   ##
=================================================
+ Coverage          88.54%   88.67%   +0.13%
=================================================
  Files                199      202       +3
  Lines               8889     9318     +429
  Branches             841      886      +45
=================================================
+ Hits                7871     8263     +392
- Misses               767      788      +21
- Partials             251      267      +16

Impacted Files
Coverage Δ

saleor/graphql/product/mutations/products.py
97.41% <ø> (ø)
:arrow_up:

saleor/graphql/account/mutations.py
93.75% <100%> (ø)
:arrow_up:

saleor/graphql/core/mutations.py
94.03% <100%> (+1.32%)
:arrow_up:

saleor/order/models.py
96.13% <100%> (+2.27%)
:arrow_up:

saleor/dashboard/order/views.py
67.42% <100%> (ø)
:arrow_up:

saleor/graphql/api.py
96.95% <100%> (+0.28%)
:arrow_up:

saleor/graphql/order/types.py
94.2% <80%> (-4.05%)
:arrow_down:

saleor/graphql/order/mutations/draft_orders.py
88.05% <88.05%> (ø)

saleor/graphql/order/mutations/fulfillments.py
88.34% <88.34%> (ø)

saleor/graphql/order/mutations/orders.py
93.38% <93.38%> (ø)

... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6992b7f...e83de48. Read the comment docs.


[TESTS][Navi21] Support Navi21 in tests

cmake -DMIOPEN_TEST_GFX1030 ... ?

See #1024 for more info and also look there how MIOPEN_TEST_VEGA and MIOPEN_TEST_GFX908 are implemented.

I am going to implement basic support in tests for navi21 and gfx90a, today.

@okakarpa Assigning to you to keep you in the loop.

the navi21 node
 http://micimaster.amd.com/computer/ixt-sjc2-61/

I am taking this node into use for now...

@okakarpa ixt-sjc2-61 works fine and added to the pool of CI nodes. The trial branch for Navi21, wip-rocmtest-trial-navi21, is created and ready to use.

Navi21 OCL testing support is ready for review & merge. Testing with HIP backend can't be implemented right now, see https://github.com/ROCmSoftwarePlatform/MIOpen/pull/1038#issue-691923637.

implemented


Update flannel from 0.6.2 to 0.8.0

Checked with k8s 1.7.2 when debuggin problem https://github.com/coreos/flannel/issues/784

ci check this

CI passed but did not check back in. Merging.


[#161315584] Include all spaces / plans in filter dropdowns

What
Previously we were filtering the items down to the selected space / plan
and then getting the list of spaces / plans from the filtered items.
Consequently the list of spaces / plans didn't include all the things it
should have.
A couple of nice extras

we can switch from let to const for items because we're not
reassigning it anymore.
we can use filter instead of reduce and it's much simpler (and
probably a bit more efficient)

How to review

Code review
Deploy to a dev environment (or locally) and test (steps to repro in
#161315584)

Who can review
Anyone

I'm not seeing the filter at all after deploying this in dev.

Operator error, disregard previous comment


LODs don't switch in game in Godot 3.5 rc6

I have a tree I modeled in Blender and exported to Godot, as well as a billboard impostor (image on a quad), but the LODs don't switch in game.
Both LODs are visible in editor as expected

Both LODs are also still visible in game, unexpected behaviour

How it's supposed to look in game:

Exact Godot version: v3.5.rc6.mono.official [f05cecdc4]

To add to this, I'm also not seeing the LOD project settings anywhere, which is weird.
I ported this project from Godot 3.4 a few weeks ago, and everything was working there.
I'll see if re enabling the plugin fixes that though.


intToBuffer() fails for numbers that produce odd length hex strings

ethjs-util
Issue Type

[X] Bug (https://github.com/ethjs/ethjs-util/blob/master/.github/CONTRIBUTING.md#bug-reports)
[ ] Feature (https://github.com/ethjs/ethjs-util/blob/master/.github/CONTRIBUTING.md#feature-requests)

Description
The intToBuffer() function is broken after this PR was merged: https://github.com/ethjs/ethjs-util/pull/7
It fails for numbers that don't produce an even length hex string. It's breaking the following modules:

ethereumjs-util: https://github.com/ethereumjs/ethereumjs-util/issues/132
ethereumjs-blockchain: https://github.com/ethereumjs/ethereumjs-blockchain/issues/56

Steps to reproduce
const util = require('ethjs-util')

const buf = util.intToBuffer(1);
console.log(buf) // output: "<Buffer >" (expected: "<Buffer 01>")
assert.equal(buf.toString('hex'), '01');

Versions

Node/NPM: 9.8.0
Browser: N/A

This is breaking a lot more then just the above mentioned modules. I just wanted to sign a Transaction with ethereumjs-tx,  which produced a wrong transaction now!
Before converting a hex-string into buffer we always need to make sure the length is even, or new Buffer will throw away these bytes
As a workaround I'm just using now Version 0.1.4 again.

This small bug spoils entire ethereumjs libraries. Please fix this issue as soon as possible. Thanks.

This small bug spoils entire ethereumjs libraries. Please fix this issue as soon as possible. I have already wasted 1 day to fix this bug on my project.

Will fix in 20 minutes
Sent from my iPhone

On Jun 10, 2018, at 1:22 PM, Chandra Nakka<EMAIL_ADDRESS>wrote:
This small bug spoils entire ethereumjs libraries. Please fix this issue as soon as possible. I have already wasted 1 day to fix this bug on my project.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@vpulim should be up in NPM<EMAIL_ADDRESS>@ChandraNakka @simon-jentzsch

@SilentCicero still is not fixed, since lib/index.js still is not changed. Please push new version and unpublish 2 previous versions with npm unpublish. Also please push last changes to repo.
This breaks a really lot of things in ETH libraries...
@ChandraNakka @simon-jentzsch I'd recommmend use npm/yarn lock file.

Will fix now and push. Thanks
Sent from my iPhone

On Jun 10, 2018, at 3:42 PM, Kirill Fomichev<EMAIL_ADDRESS>wrote:
@SilentCicero still is not fixed, since lib/index.js still is not changed. Please push new version and unpublish 2 previous versions with npm unpublish. Also please push last changes to repo.
This breaks a really lot of things in ETH libraries...
@ChandraNakka @simon-jentzsch I'd recommmend use npm/yarn lock file.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@fanatid the module I pushed has the updated lib/index.js code in version 0.1.6:
const isHexPrefixed = require('is-hex-prefixed');
const stripHexPrefix = require('strip-hex-prefix');

/**
 * Pads a `String` to have an even length
 * @param {String} value
 * @return {String} output
 */
function padToEven(value) {
  var a = value; // eslint-disable-line

  if (typeof a !== 'string') {
    throw new Error(`[ethjs-util] while padding to even, value must be string, is currently ${typeof a}, while padToEven.`);
  }

  if (a.length % 2) {
    a = `0${a}`;
  }

  return a;
}

/**
 * Converts a `Number` into a hex `String`
 * @param {Number} i
 * @return {String}
 */
function intToHex(i) {
  var hex = i.toString(16); // eslint-disable-line

  return `0x${hex}`;
}

/**
 * Converts an `Number` to a `Buffer`
 * @param {Number} i
 * @return {Buffer}
 */
function intToBuffer(i) {
  const hex = intToHex(i);

  return new Buffer(padToEven(hex.slice(2)), 'hex');
}

Can you please expand where the module is failing, please try installing the new version again.

Very strange. Sorry, looks like was on @0.1.5 when tested.
Still, can you unpublish 0.1.5 so nobody can use it?
Thanks!

I will depreciate.

Not everybody read messages in console, since this library is used in applications which operate with big amounts of money, I think unpublish will be appropriate.

Okay, will u publish .5 and .4
Sent from my iPhone

On Jun 10, 2018, at 4:53 PM, Kirill Fomichev<EMAIL_ADDRESS>wrote:
Not everybody read messages in console, since this library is used in applications which operate with big amounts of money, I think unpublish will be appropriate.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@SilentCicero Thanks a lot, now it's working :)

So sorry about that! Clearly not enough test coverage over these basic methods. Will update coverage soon.
Sent from my iPhone

On Jun 11, 2018, at 1:17 AM, Chandra Nakka<EMAIL_ADDRESS>wrote:
@SilentCicero Thanks a lot, now it's working :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.


Issue when updating a model

Hello,
I have another issue with the same model as in (https://github.com/requery/requery/issues/98), when running an update query on a changed instance of the model, it usually does not get correctly updated in the database, with no error messages.
The stuff that does not get updated correctly are the OneToMany relationships.

Same problem as issue #98.


KM Binary Tar for k8s with strictly static binaries

Fixes: #1411
Rework binary packaging and CI to integrate statically linked KRUN into KM source base.
This actually got a bit more involved than I thought at first. Here are the major changes:

Update kontainapp/crun level to 5a75bcc29962f15336d409adee32c2072b704784
Get rid of container-runtime test-remote.py. This was trying to build and test kontainapp/crun on an Azure VM (even though it was already built and tested on github runner). The compile was failing with old headers. Rather than tracing it down it down, I removed it.
Build static KRUN in parallel with the existing KM build/test. This makes sense since the nix based KRUN static build takes a long time. After both the km and static krun are built, a binary release tar is synthesized that contains all static binaries.
A text file that contains the output of git submodule status is included  on the new binary release tar file. This is sufficient to pin the version of KKM required for KM and is much smaller than kkm.run.

The sha mentioned in the description - is it simply the sha we synced with? And related question - when we build krun, where is the sha/tag/branch come from?

The sha mentioned in the description - is it simply the sha we synced with? And related question - when we build krun, where is the sha/tag/branch come from?

What ! mentioned in the comment is the output of git submodule status. eg.:

 5a75bcc29962f15336d409adee32c2072b704784 container-runtime/crun (0.14.1-685-g5a75bcc)
 37730e5f349c8a12f3a64b2dbde9e8a337704b95 kkm (heads/master)
 b19da8e362acae8944c60a40cf5c40c8f5ebeb44 lib/mimalloc/mimalloc (v1.7.1-1-gb19da8e)
 4721cce4af0c4d118a96316d087f1ad30f1a6932 runtime/musl (remotes/origin/kontain)
 565f2863288331684cf5b03560b26151a09ea810 tests/bats (v1.1.0-438-g565f286)
 9f88b4207da750093baabc4e3f41bf68f0dd3630 tests/bats-assert (v0.2.0-5-g9f88b42)
 004e707638eedd62e0481e8cdc9223ad471f12ee tests/bats-support (v0.3.0-1-g004e707)
 bd7bc060d67078562625984490c209a7459bd822 tests/greatest (v1.5.0-1-gbd7bc06)

The important bit of information here is the the 2nd line. It tells us what version of KKM matches KM from a git commit SHA POV. So if we need to build KKM, we can do git clone <blah>; cd <blah>; git checkout <kkm-sha> and we know we'll build a version that matches (assuming the kernel headers exist). Srini and I talked about this a couple weeks ago.


HUGE awesome-electronics section refactorization

I took 3/4 hours to refactorize the awesome-electronics sections into something I had in mind. I found the sections poorly organized, with many inconsistencies and with questionable "awesome" items. So I decided to help to improve it. But instead of arbitrarily pushing this huge refactorization, I deciced to open a PR in order to get promote any disscussion about it.
Maybe the biggest changes were:

Free EDA Packages, Paid EDA Packages, and Simulators were converted into EDAs. The way it was organized made no sense. EDA is a set of software used in the design and development of electronic systems, where simulation is just one of the possible feature it may have. It might even make sense for those who are used to use a specific EDA only for simulation (e.g. LTspice) and other EDAs for other things. However, many EDAs are intended to have multiple functionalities, where simulating is just one of them. For example, Proteus is a simulator, but it is also used for design verification and PCB desing. Inspired by other awesome lists, I propose to turn this section list into a table, where each EDA has its feature duly checked. This way the list gets less diluted. I am not fully versed in all EDAs, so any help is welcome :)
Part search engine: Likewise, online part search engine provides different features. I propose to join the former 3D Part Models into the Part Search Engines section and create a table-fashioned list to organize each link with its functionalities.
Pass many main sections under the learning umbrella as they are related to learning links.

I don't think we should delete old/obsolete entries from the list. I have also used this list to find awesome projects that served as references for other projects.

To be clear, while I liked the proposed change in the presentation, I think that deleting entries will be heavily detrimental to the value of this repository.

I see, so let us leave them. No problems.

Thanks for all your work! As you are doing already: please do let me approve/merge this one since it's changing so much.

Due to the lack of interaction and a partial agreement on this PR, I just merged (I usually delete forked repos for PR ASAP).
If you want to get rid of the tier list. Just go ahead and delete this part. Do whatever you find sensible. I am just a collaborator, and you are the member, so the final word should be yours. I hope I have contributed to this repo in some way :)
See you.

Sorry,  but that's really not a great reason to merge and I asked you explicitly not to merge this! I really appreciate the rest of the work but you are creating work for me by just merging things there is no consensus. Can you please undo the tier list.

I've reverted the merge. Please please please, break up the changes and make new PRs.

I am really sorry for that. I just overlooked that part and did this mistake. It is nice to know that you just reverted it, though. I hope you can forgive me.

Please please please, break up the changes and make new PRs.

My time is up now. That's why I mistakenly merged this, as I normally don't leave PR open so long. I need to work on other projects at the moment and my main contribution has already been made here. My idea was to leave it up to you to delete the level list and whatever you want to. I didn't realize that would be cause a trouble to you, but since you decided to revert everything instead of working on these small details, I feel this contribution was simply wasted because I don't have time to work on multiple PRs.
However, you can still tweak on the minors issues that you disagree and save this contribution to this awesome list. I really think that would be a great contribution as many items in your awesome list are unmaintained (which should not be considered awesome, by definition).

It's all good, no harm done in the end.

I can even put some extra effort to reopen a new PR, without the tier list stuff, but I would open only one PR. Just let me know if you are interested

Yes please!


Directly using the "PDF" button does nothing; "Export" > "Save to device" in menu never finishes

What the title says: PDF button in frontend does appear to do absolutely nothing (except blink), when being clicked on.
The context menu entry "Export" → "Save to device" never finishes the "Selected directory" step (remains on swirl animation).
I suspect this has to do with this phone (Samsung S3 Mini) running an old lineageos without some of the necessary Google services?
Even then, these actions should fail more gracefully.
I'm also not sure where output images are stored, prior to export (Currently I try to take them directly from data/*openscan/files/, but this is also prevented by unrelated issue #37 - it also feels like a hack to grab them from that folder).

Reopen if the issue persists


Error with module 'time'

Hi,
I get this error with try to execute order as order water_traj.xyz -t oto -c 'OH2':
Traceback (most recent call last):
  File "/home/almeida/.local/bin/order", line 8, in <module>
    sys.exit(command_line_runner())
  File "/home/almeida/.local/lib/python3.8/site-packages/order/order.py", line 40, in command_line_runner
    t_start = time.clock()
AttributeError: module 'time' has no attribute 'clock'

I installed order as:
pip3 install iorder
... and I use python 3.8
Any help will be appreciated.

Dear Pu Du, I'm encountering the same error as almeida85. Could you please comment on this? Thank you in advance, Giuseppe


fix: Market Activity report particulary parsed

Previously the data from function get_market_activity_report in reports.py was
- Unorganized
- Bytes format
- Contained irrelevant headers and metadata
- Not Convertible to dataframe
Now this function returns
- Dataframe with only relevant data

Nope,
it is parsing the relevant part from the report. We will get top gainers
and losers from it.
On Fri, 17 May 2024 at 15:12, Jitendra Varma @.***>
wrote:

@.**** commented on this pull request.
In nsedt/reports.py
https://github.com/pratik141/nsedt/pull/55#discussion_r1604650436:

@@ -35,8 +39,11 @@ def get_market_activity_report(date: str):

 cookies = get_cookies()
 url = f"{REPORT_URL}{MARKET_ACTIVITY_REPORT}{date}.csv"

return fetch_csv(url, cookies, response_type="raw")

response = fetch_csv(url, cookies, response_type="raw")
df = pd.read_csv(BytesIO(response), skiprows=8)
df.drop(columns=['Unnamed: 0'], inplace=True)
df = df[:77]

@shivam2502 https://github.com/shivam2502 Hey, this screws the top
gainer/loser when you slice, please can you get rid of it. Thanks.
—
Reply to this email directly, view it on GitHub
https://github.com/pratik141/nsedt/pull/55#pullrequestreview-2062825883,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJQXTF47SDA6TKPZBY7LIR3ZCXGH3AVCNFSM6AAAAABHS6DXKCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDANRSHAZDKOBYGM
.
You are receiving this because you were mentioned.Message ID:
@.***>


Access to innovaphone via websockets without myApps

@Elompenta
Hi Sebastian,
is it possible to access the innovaphone platform via websockets without implementing a myApps-application?
Many thanks!
Marcus

Hi Marcus,
yes, at least you need an authentication to the PBX.
You can reach this by an App Object in the PBX and make an authorization to this object.
We have an example here: https://sdk.innovaphone.com/13r3/doc/tutorials/ExternalAppService.htm
After authentication, you can use the functionalities / APIs, that are allowed in your app object.
For further questions, please use our developer forum: https://class.innovaphone.com/moodle2/mod/forum/view.php?id=127446


Add planned_remediation_version and effort_for_fixing fields

Description
Add 2 fields:

planned remediation version: in what version of the product we plan to remediate this finding
effort for fixing : is it easy, medium or hard to fix. Help prioritize fixes

Test results
tests.pdf

@shipko tests finally went through after many reruns :) . All good to go? thanks

Good job!

@ptrovatelli I am a little nervous to attempt to fix these conflicts. They are pretty large chunks 😬

@Maffooch all good now :)


summary

How can we change max no of sentences of summary?

@leenabharambe There's a MAX_SUMMARY_SENT setting for that (http://newspaper.readthedocs.io/en/latest/user_guide/advanced.html#parameters-and-configurations). Does that work for you?


Color picker should use the chosen color for itself

I was trying out ideas such as changing the font color of the icon and text inside the text field for a color input after user chooses a color. Here is a demo: https://codepen.io/coffeeandwork/pen/OJrwLPV

That seemed like it might not work that well because if user chooses white, while the background is white, it wouldn't show, as shown below:

I was thinking that we could leverage the color theme project that you have in place to use the chosen color, to generate a theme, and apply that theme to the color input field.
Thoughts?

IMO I think we can use the same approach of color picker. We can do that with a little "hack". But could be unclear for devs, that the framework will change the color on <i> element. Do we need to do that automatically?

In Vue (and others) the devs can do that easily, and don't need to change the color of icon always. They can change the color in any element.

ah ok, I like that idea.


nixos/roundcube: security improvements

Motivation for this change

database password is world readable in the store
php update script is ran as root

Things done

If the database is local, use postgres peer authentication. Otherwise, use a password file.
Leave database initialisation to postgresql.ensure*.
Leave /var/lib/roundcube creation to systemd.
Run php upgrade script as unpriviledged user.
initialize the des_key (the installer does it, but nixos bypasses the installer...)
En passant, fix warning about mime types database

This should be backward compatible:

des_key is only used for cookies apparently. So changing it only logs users out.
changing the default user: /var/lib/roundcube is chowned by systemd
database owner does not change, and can still log in with peer auth even if it previously used a password

The nixos test still passes, with no modification.

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

cc @Ma27 @globin @Vskilet

Thanks @symphorien! Let's see what @Ma27 has to say and go from there. Looking over the code you get the :+1: from me, though. Great work!

Hoo thanks @symphorien ! I'll test now !

I wonder if @Ma27 has an existing roundcube instance that could be used for testing...

I do :)
If I have sufficient time, I can test this tomorrow :)


Get function signature in C++

We use sol2 to provide a basic autocomplete in the game's terminal:
https://github.com/diasurgical/devilutionX/assets/216339/fc322f33-75fc-49f8-9949-9a4dc39ba81e
Code: https://github.com/diasurgical/devilutionX/blob/master/Source/lua/autocomplete.cpp
It'd be neat if the autocomplete could show some information about the function's arguments.
Is there a way to get that via sol2?

As far as I know, it is not possible at the moment to get the info. Sol does not store it anywhere in accessible format.
But you can always try to store the info yourself.
One possibility for example is to make some kind of wrapper that adds both the function and the signature in some format to the table here https://github.com/diasurgical/devilutionX/blob/5821d2305caeac6add7aef95a91b5a0cf1871501/Source/lua/modules/audio.cpp#L21
I dont have the time or knowhow to implement it, but the basic idea I have is the following, where each function is wrapped in a helper macro that in addition to storing the function in the table, stores the signature of the stored function. This is a quick example I made that more or less works with function pointers, but not lambdas.
https://godbolt.org/z/jcWaKjoKa

#define SOL_ALL_SAFETIES_ON 1
#include <sol/sol.hpp>

template <typename Result, typename... Args>
std::vector<std::string> extractFunctionPointerSignature(Result (*)(Args...)) {
    std::vector<std::string> signature;
    signature.push_back(sol::detail::demangle<Result>());
    std::apply([&](auto... types) {
        (..., signature.push_back(sol::detail::demangle<decltype(types)>()));
    }, std::tuple<Args...>());
    return signature;
}

template <typename... Args>
std::vector<std::string> extractFunctionPointerSignature(void (*)(Args...)) {
    std::vector<std::string> signature;
    signature.push_back("void");
    std::apply([&](auto... types) {
        (..., signature.push_back(sol::detail::demangle<decltype(types)>()));
    }, std::tuple<Args...>());
    return signature;
}

template<typename Func>
auto EXTRACT_SIG(Func f) {
    // some template magic, here is an example that should work with function pointers
    // not sure how to do it for lambdas, but sol does it already somehow for lambdas so its probably possible
    auto sig = extractFunctionPointerSignature(f);

    return sol::as_table(sig);
}

void playSfx(int psfx) {}
int playSfxLoc(int psfx, int x, int y) { return 0; }

int main() {
    sol::state lua;
    lua.open_libraries();

#define WRAP(name, func) \
    name, func, \
    std::string("___")+name, EXTRACT_SIG(func)

    lua["test"] = lua.create_table_with(
	    WRAP("playSfx", &playSfx),
	    WRAP("playSfxLoc", &playSfxLoc)
    );

    lua.script("print(test.playSfx, test.___playSfx and table.concat(test.___playSfx, ' '))");
    lua.script("print(test.playSfxLoc, test.___playSfxLoc and table.concat(test.___playSfxLoc, ' '))");

    return 0;
}

I've implemented this for C++ functions manually.
Can this be done somehow automatically for functions defined in Lua?
There is this StackOverflow answer here https://stackoverflow.com/a/24216007/181228 but I'm not sure how to port it to sol or how to even know if the function is a native Lua function or a binding to a C++ one.

how to even know if the function is a native Lua function or a binding to a C++ one.

I dont know if sol has a function for that, but you can use https://www.lua.org/manual/5.4/manual.html#lua_iscfunction

Can this be done somehow automatically for functions defined in Lua?

Well, all functions you bind from sol will be C++ functions that do not have any useful signature in lua.

There is this StackOverflow answer here https://stackoverflow.com/a/24216007/181228 but I'm not sure how to port it to sol

You can use it as is for lua functions. It wouldnt work for the C++ functions anyways.

Thanks, I've now added the code for Lua functions (https://github.com/diasurgical/devilutionX/pull/6784) from that StackOverflow answer.
Now the only issue is that we don't show anything for stdlib functions.
The standard library is pretty small so I guess that can be done manually as well.
Since it looks like nothing more can be done at the moment, closing.

Is this the correct way to call lua_iscfunction?
sol::object value = ...;
lua_iscfunction(value.lua_state(), value.registry_index());

It seems to always return false for me.

Ah, it needs a stack index.  I did this, not sure if it's the best way:
	value.push(value.lua_state());
	const bool isC = lua_iscfunction(value.lua_state(), -1) != 0;
	lua_pop(value.lua_state(), 1);


enableAllTerminfo: re-add unbroken contour

#345827 removed broken contour from enableAllTerminfo while #353255 seems to have fixed it again.

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Maybe, currently this discrepancy breaks the test for enableAllTerminfo, not fixing it would lead me to not having it on my system and watching it.
When I added this feature I did not quite realize how volatile packages are, but we are here now, seems to be only a few times per release though.

Maybe, currently this discrepancy breaks the test for enableAllTerminfo

nixos/tests/all-terminfo.nix? seems to work fine for me...
...but would be worth adding this as a passthru test of contour...

I think we should ask the maintainer of contour (@moni-dz) if they have bandwidth to fix breakage, considering last time this was broken a little over a year, I think it's good to have someone designated to fix it in case of breakage again.

yeah especially for linux, I can only test and build on aarch64-darwin relatively quick, and checking contour's CMakeLists.txt to replace all the vendored dependencies takes quite a bit of my time

broken a little over a year

part of it is because contour started using newer apple-sdk versions that didn't exist prior to the darwin SDK rework

part of it is because contour started using newer apple-sdk versions that didn't exist prior to the darwin SDK rework

So we don't expect new breakage anytime soon?

part of it is because contour started using newer apple-sdk versions that didn't exist prior to the darwin SDK rework

So we don't expect new breakage anytime soon?

yeah unless upstream decides to use another in-house library


Policy-controller helm chart suggest using deprecated secretKeyRef

Description
According to the latest policy-controller docs, the usage of cosign.secretKeyRef.name is deprecated and people should be using ClusterImagePolicy. However the current installation documentation still points to the old way to do this.
Since it is the only available public docs for installing policy-controller, it should reflect the latest recommendation to use ClusterImagePolicy.
Version

Latest

@maxking Good point! Let's add it here too.

@hectorj2f @maxking is this still outstanding or can this issue be closed?

Closing it!


Service renames

This pull request adds the ability for service shapes to use shapes that have conflicting shape names in the service closure.
Motivation
All the shapes referenced as part of a service are called the service closure. The service closure is computed by recursively following each reference to operation and resource shapes defined on the service, then to their operations and resources, and then to the shapes they reference. With some exceptions defined in the specification, Smithy requires every shape in the closure to have a unique shape name regardless of their namespaces. Given that Smithy supports defining shapes in namespaces, this limitation that shapes names must be unique was counter-intuitive, and there was previously no recourse when the situation occurs. Smithy models are often used by teams to combine the models of several independent microservices into a unified service, so it's a common occurrence that teams end up with name conflicts when building their "frontend" services.
Background
The intentional limitation that shape names must be case-insensitively unique in a service closure is intended to help with code generation to generate unambiguous type names. Borrowing from DDD terminology, the goal is to give the service a ubiquitous language by treating a service as a bounded context.

Not every programming language supports namespaces
Generating names based on the namespace and shape name leads to obviously generated type names
Actually using namespaces could lead to situations where end-users need may need to choose between two identical auto-completed type names when working with a client
Namespaces would lead to very complex packaging requirements if disparate namespaces are used (for example, needing to publish individual packages for each namespace used as part of a service to prevent things like split packages in Java, coordinating and publishing shared models with dependencies, etc.)

Solution
The solution proposed in this pull request is to introduce a rename property to the service shape to disambiguate shape name conflicts in the service closure. This property is a map of shape IDs contained in the service to the name to give the shape when used in the context of the service.

Each shape ID must be part of the service closure.
Each map value MUST match the identifier production used for shape IDs.
No renamed shape name can case-insensitively match the effective name of any other shape (where effective name is defined as the renamed name of the shape if the shape is renamed, or the name of the shape).
Renaming a shape does not give the shape a new shape ID. Renaming a shape simply gives the shape an unambiguous name in the context of the service.
Member shapes MAY NOT be renamed. Renaming members would imply creating synthetic copies of aggregate shapes with new shape IDs.
Resource and operation shapes MAY NOT be renamed.

Renaming shapes is intended for incidental naming conflicts, not for renaming the fundamental concepts of a service.
Most conflicts that occur in naming when combining models occurs in the shapes that make up resource and operation shapes, not in the resource and operation shapes themselves. Independent teams hoping to build a cohesive frontend service will need to coordinate at least on the concepts of a service, and that includes deciding which team owns which resources and operations.
Forbidding the renaming of resources and operations can often make other transformations of the model simpler; for example, when determining the type name of a resource in another format the service context is not needed (e.g., AWS CloudFormation resources).

Shapes from other namespaces marked as private MAY be renamed. Incidental conflicts can easily occur in private or public shapes. The rename property does not add a new selector relationship from the service to the renamed shapes, and because of this, the rules around referencing shapes marked as private from other namespaces do not apply to a service.
Renames are not limited to shapes in conflict. When integrating a model into another model, shape names could be overly generic and should be disambiguated early to ensure the service is unambiguous as it grows and adds new concepts.

The following example defines a service that contains two shapes named "Widget" in its closure. This model is invalid because on the conflicting names:
namespace smithy.example

service MyService {
    version: "2017-02-11",
    operations: [GetSomething]
}

operation GetSomething {
    output: GetSomethingOutput,
}

structure GetSomethingOutput {
    widget1: Widget,
    fooWidget: foo.example#Widget,
}

structure Widget {}

The conflicting Widget shapes can be disambiguated by renaming one of the "Widget" shapes used in the service:
service MyService {
    version: "2017-02-11",
    operations: [GetSomething],
    rename: {
        "foo.example#Widget": "FooWidget"
    }
}

Impact on code generation
Code generators should now take into account the rename property of a service to determine the name of a shape for the target language. Code generators previously based the name of a generated type solely on the name of a shape's shape ID, but the now must now have the context of the service being generated to choose an appropriate type name for shapes, particularly conflicting shapes.
Impact on OpenAPI conversion
Like code generators, when generating OpenAPI models from Smithy, the converter must now use the rename property of the service.
Impact on non-Smithy AWS SDKs
Several AWS SDKs have not yet migrated to Smithy models and code generation. These SDKs will not need to do any work in order for this proposal to work. The conversions from Smithy to the format used by these SDKs will automatically rename shapes as part of the generated model.
Alternatives considered
Do nothing, copy and paste
If a conflict occurs when integrating models, the shapes that are in conflict can be copied and renamed to names that no longer conflict with the rest of the model. This solution is simple in implementation and the specification, but it's an awful experience for the team that has this problem. Sometimes renaming a shape requires renaming and editing an entire tree of interconnected shapes; any member that targeted the previous shape name needs to be updated, traits need to be updated, etc. This solution is also dangerous too; the copied shapes are now disjoint from their source. As the source model evolves, the copied shapes only evolve if another explicit copy is performed, or if some kind of automated copy is performed. However, there is still an opportunity for the copied shapes to become out of sync because traits can be applied to the copied shapes that have no impact on the source shapes.
Relax the unique name requirement and use build tooling
Another option is to relax the requirement that shape names are unique across namespaces and rely on codegen configuration in smithy-build.json files to disambiguate shape names. For example:
{
    "smithy": "1.0",
    "plugins": {
        "java-codegen": {
            "shapes": ["a#Facet", "a#Doohickey", "com.foo#Facet"],
             "rename": {
                "com.foo#Facet": "FooFacet"
             }
        },
        "php-codegen": {
            "shapes": ["a#Facet", "a#Doohickey", "com.foo#Facet"],
             "rename": {
                "com.foo#Facet": "FooFacet"
             }
        }
    }
}

The biggest issue with this approach is that it doesn’t scale well if a service needs to be generated in multiple programming languages and potentially by multiple teams (for example, that is the situation with AWS SDKs). By putting rename metadata in the model, the team that owns the service has full control over how the shapes in their service are referenced in things like code and documentation. Placing this configuration in build configuration files pushes the burden onto consumers and can easily lead to inconsistencies.
Use a rename trait
This option is similar to the option proposed, but instead of making rename a property of the service, it becomes a trait on the service:
@rename(foo.example#Widget": "FooWidget")
service MyService {
    version: "2017-02-11",
    operations: [GetSomething],
}

This has the same effect, and really comes down to a matter of taste. Because the concept of a "service closure" is specific to a service and defined by properties within the service like operations and resources, it seems more natural to define renames inside the service as well.
Add a new context shape
A new shape could be added called context that is referenced by a service to handle renames.
namespace smithy.example

service MyService {
    version: "2012-06-1",
    operations: [SomeOperationA, SomeOperationB],
    context: MyServiceContext,
}

context MyServiceContext {
    rename: {
        com.foo#Facet: "FooFacet"
    }
}

This has the benefit that contexts could be reused by multiple services, and could even be used to generate just types for shapes rather than clients or servers. smithy-build.json files could reference the service to generate a client or server, or the context to generate shapes in a context:
{
     "smithy": "1.0",
    "plugins": {
        "java-codegen": {
            "context": "smithy.example#MyServiceContext"
        }
    }
}

This option has several issues:

If a conflict is detected in a service closure, the context must be updated. This means that the context and the service aren’t actually independent of each other.
A service provides other meaningful information that code generators would need to generate just types without a client (for example, protocol configurations).
Introducing a new shape would likely need a major version bump of the specification and would be a breaking change to the implementation of Smithy (mainly due to how visitors are implemented in Java).

Seems reasonable. Would appreciate some sort of ShapeNameIndex so that in our SymbolVisitor implementations we could easily capture the derived name for a shape.

Since there are valid use cases where a service context isn't needed, shape ID names shouldn't be deprecated (for example, Smithy to Smithy transformations and the implementation of the Smithy model itself).
For making this easier, rather than adding a new knowledge index, I added a getContextName method to the ServiceShape class. So if you have a reference to a service, you can pass a shape ID or shape to getContextName to get the possibly renamed shape name:
myService.getContextName(someShape);

But maybe it would be better to put that method on a ShapeId and pass in the service instead?
someShapeId.getServiceName(service);

Another wrinkle: What happens if two errors with the same name (but renamed within the closure) are added to the errors for an operation? Is that verboten?

Great question. For context: errors are one of the few places where a polymorphic type needs to be communicated. For example, clients need to look at the response x-amzn-errorType or __type and figure out what to deserialize it into. Since the type names used in protocols like AWS rest-json are all based on shape ID shape names, they don't include the namespace as part of the name, and the name is not based on the service context name, the conflict would cause ambiguity (i.e., which FooException is this?).
We could address this in a few ways:

Just like how we forbid resource and operation shapes from being renamed, forbid error shape names from being renamed. This is probably the simplest option, but it doesn't provide a recourse for naming conflicts.
Allow conflicting shape ID names for errors to be renamed, but forbid conflicts in an operation. So OperationA can refer to a#FooException, and OperationB can refer to b#FooException, and as long as one is renamed, there's no issue. I doubt this would have an impact on most use cases, and the biggest cost here is just the added lawyering to the spec and validation. With this constraint, clients know the operation context in which an operation was called and can then properly disambiguate between two conflicting error shape names.
Implement option 1 or 2, but instead enforce this constraint only in protocol-specific validation. Since this is an issue specific to currently implemented protocols like AWS rest-json, maybe it should be protocol specific validation? The major drawback here is that a team might not know about this requirement until they add protocol traits to their service.

[Discussed offline]

On accessing the name of a ShapeId, we decided it makes sense to add an additional accessor getName(ServiceShape) to return the name of a shape in the context of a service.
On error disambiguation, we decided to prevent errors from being renamed. If this poses a problem for service teams, we can revisit this decision at a later date.

In terms of codegen, a couple of protocol tests should be sufficient to make sure that teams are properly respecting the rename flag for structures.

I've updated the proposal and the pull request with the discussed changes. Thanks for the suggestions!


"Other weapons" proficiencies from Classes are hardcoded and can not be added/removed/renamed [REPLACEMENT ISSUE]

The original issue
Id: 1182
Title: "Other weapons" proficiencies from Classes are hardcoded and can not be added/removed/renamed

could not be created.
This is a dummy issue, replacing the original one.In case the gitlab repository still exists, visit the following link to see the original issue:
https://gitlab.com/hooking/foundry-vtt---pathfinder-2e/-/issues/1182

Closing, as I don't see why you need to be able to remove or edit the names of class-specific weapons normally. For homebrew, you can edit the rules elements on the class.


Unable to clone repo through Authenticated SSL

Hi guys,
Sorry to bother you but I'm struggling with this problem.
I user Gitblit on Windows Server. All is fine. I set it up with our SSL certificate and the web interface is running quite well.
The prob is coming when I do a clone of a repo.
Here is the Tortoise message:
https://www.ddrsa.com/files/tortoisegit.jpg
I tried many things but it still giving me this message.
Again, all is going well on the admin web interface.
To add my SSL certificate on the gitblit server, I generated a new serverKeyStore.jks.
Is there any other things to do?
Thank you very much,
Q.

No one?

Ok, I fixed it!
Your certificate must be concatenated with the intermediate crt first... before generating jks keystore.


weird motor movement after Motor.run_to_position()

Hi there,
sometimes after setting Motor.run_to_position() the motor swings to total different position (see picture attached).
i've set Motor.run_to_position(-7.5) using Motor.get_aposition() it can be seen the motor moving to -156 and then to 166.
what can i do to fix it?
Thank You in advance!

probably setting run_to_position very frequently


About output .svg file size

I ran this command:
python main.py --img=./image/Naruto.png --actor=./model/actor.pkl  --max_step=40 --divide=32

The size of Naruto.png is 81KB, but I obtained a 9.6MB SVG file named './output/1023.svg'. It did not become smaller.
When I used (p=16, k=20), the output size was 1.5MB. However, it also did not become smaller."

Thanks for your question.

You may need to change "use_PM = False" to "use_PM = Truth" , in the main.py.

Vectorized results may not be smaller than images. In general, the higher the resolution of the input image, the more file sizes are reduced in vectorized results.

If the image has fewer color changes, the vectorized result will be smaller. If the color changes are more, it may be larger.

Our method more focus on vectorization accuracy, and is not good at reducing file sizes.


Add Search DOI Component

Add search DOI component to the library on embed-and-npm-builder branch.

Here is an example of a create-react-app index page that runs the DoiSearch widget:
import React from 'react';
import ReactDOM from 'react-dom';
import reportWebVitals from './reportWebVitals';
import {DoiSearch} from 'pds-wds-react';

ReactDOM.render(
  <React.StrictMode>
    <DoiSearch/>
  </React.StrictMode>,
  document.getElementById('root')
);

reportWebVitals();

i have been able to run all the tests. No merge request since there are some challenges in merging with the preexisting code in main see ticket #6


[Feature] Fabric Support

Is your feature request related to a problem? Please describe.
I am running a fabric server with many of the create addons already supporting it; my problem is that while I'd like to use this really nice-looking addon, I cannot as it is forge only.
Describe the solution you'd like
It would be nice to include a fabric build process as well.
Describe alternatives you've considered
I've considered just hiding all the create elements and not trying to encase them. Another alternative I was thinking on to port the textures to a datapack so that it is mod-independent and just retextures things.
Additional context
I am running the latest fabric-patched server on Alpine, with Java 17 and Minecraft 1.20.1

I don't know how to dev on fabric so it's no


[DRAFT] A few tweaks

This is just to see how this behaves in CI and not final yet.
Signed-off-by: Otto van der Schaaf<EMAIL_ADDRESS>

/retest


Opening side docs starves main process

Describe the bug
Opening side docs causes the app to be REALLY sluggish until side docs finish loading.
To Reproduce
Steps to reproduce the behavior:

Go to editor e.g. arcade.makecode.com
right click on a block and select help. (Easiest to see while throttling cpu, but can be noticed to some degree no matter what)
Try to open toolbox category
See error

I don't think this is really ever noticed in practice, because if you're clicking on the help to get information about the block, my expectation is that you would typically be interest in the information / waiting for the content to load, and not trying to drag out more blocks.
Expected behavior
Opening side docs should not starve main process / app
Screenshots
example @ 4x cpu throttling -- after pressing help, I'm spamming clicks on the toolbox to open a category and there is no response whatsoever (it does open up the last one as soon as the sidedocs finish loading.)

\/ only thing that seems to really be happening at a glance during the slow down is the compiler running to build the snippets in the side docs. This one is from 6x slow down with a ref page that includes a couple of snippets.

I'll take a look for a little bit longer to see if there is anywhere obvious that the app is waiting for the iframe to load that is causing the sluggish behavior (e.g. maybe something to do with loading overlay ??) but if it's not an obvious / trivial fix will probably defer this as I don't think any users have reported it / noticed it in particular.
Desktop (please complete the following information):

OS: mac 10.15
Browser chrome 78.0.3904.97

WOn't fix.


Testimonial delay

Has this bug been raised before?

[X] I have checked "open" AND "closed" issues and this is not a duplicate

Where did you find this bug?
Testimonial Section
Version of BioDrop (for example "v1.2.3")
v2.99.11
Description
Testimonial provide are not fetching to account quickly it will take more than 48 hours. Last week I have received two testimonials among that only one is showing on my dashboard.
Steps to Reproduce
If you know the steps, follow the below format and provide steps to reproduce
For example:

Go to  page.
On top right side, close to the  menu
Some menu are not working properly.
Continue...

If you don't know exact steps, include any relevant details like:

What page you were on...
What you were trying to do...
What went wrong...

Screenshots
No response
Do you want to work on this issue?
No
If "yes" to above, please explain how you would technically implement this
No response

Hi, you opened this same issue previously and have been in discussion on it with Eddie and other maintainers.  Closing as duplicate.

Duplicate of https://github.com/EddieHubCommunity/BioDrop/issues/10147