WIP: fix ENGINE method redirection.

If we are passed an ENGINE to use in int_ctx_new e.g. via EVP_PKEY_CTX_new()
use it instead of the default.

Checklist

[ ] documentation is added or updated
[ ] tests are added or updated

This PR will address some bugs/deficiencies when the EVP_PKEY framework is used to redirect operations to an ENGINE: currently it doesn't work properly. This will address the problems of #4495.

This doesn't address everything yet but there is one significant bug fix already: we clobbered the passed engine when calling EVP_PKEY_CTX_new().
@mouse07410 this should partially fix the EVP_DigestSignInit() problems you were seeing: if you now pass an explicit EVP_PKEY_CTX into EVP_DigestSignInit() created using EVP_PKEY_CTX_new() with the appropriate EVP_PKEY and ENGINE it should now redirect the operations to your ENGINE instead of using the defaults.
That's only a part fix though. An application shouldn't need to do that. If that works I'll work on the correct fix.

Update: added a function EVP_PKEY_set1_engine() if you call this after setting up the key (set type, key components etc) it should redirect operation to the ENGINE at the EVP_PKEY level. That should happen transparently and no need to specify an ENGINE parameter to EVP_DigesSignInit() etc.
Documentation and tests to follow.

Note: I have some ugly test code that generates a dummy EVP_PKEY_METHOD and checks redirection. With these updates it seems to work as expected now. I'll work on tidying that up and including it.

Update: added a function EVP_PKEY_set1_engine() if you call this after setting up the key...

Before I've tried anything: I'd dearly love if you could also add functions

EVP_PKEY_get_engine()
EVP_PKEY_CTX_get_engine()
EVP_PKEY_CTX_set1_engine()

Why would you need those? I'm not saying they shouldn't be added I'm just seeing if the required functionality is already there. For example EVP_PKEY_CTX_set1_engine() would appear to be similar to EVP_PKEY_CTX_new() (with the fix in this PR) but without the complications of what to do if an ENGINE/method is swapped part way through an operation.

Why would you need those?

The setters - to be able to change things post-factum. The getters - to be able to learn what I was given (what I'm dealing with), and possibly pass the ENGINE * over to other components.

OK, first report. For  PIV tokens it worked fine for both RSA-PKCS and RSA-PSS.
For the HSM, it seemed to do do RSA-PKCS fine, but failed on RSA-PSS:
. . . . .
OSSL-Tst5/main.c:673 sign: failed to sign (rv=0)
140736337826752:error:8207A070:PKCS#11 module:pkcs11_private_encrypt:Mechanism invalid:p11_rsa.c:140:
Signing failed! (rv=0 olen=384)

Symptoms are indicative of trying to do everything in software, offloading to the token only the last raw RSA operation.

OK I'll add my test when it's in a usable state: that does redirect properly.

More details. Trying to breakpoint at the entrance of EVP_DigestSignInit() I observe that pkey->engine == NULL (actually, all the ->engine references I checked down the EVP_DigestSignFinal() were NULL). Here is my test/demo code (error checks removed for brevity):
int sign(const unsigned char *in, const size_t inlen, unsigned char **out,
         size_t *olen, ENGINE *e)
{
    int            rv      = -1;
    int            saltlen = -2; /* max permitted salt len value */
    EVP_PKEY      *privkey = NULL;
    EVP_PKEY_CTX  *ctx     = NULL;
    EVP_MD_CTX    *md_ctx  = NULL;
    const EVP_MD  *md      = HASH;
    const int      padding = RSA_PKCS1_PSS_PADDING;
    // SignPrivKey is a pkcs11: URI pointing at the right key (with RSA signing capabilities) in the HSM

    PW_CB_DATA     cb_data;
    cb_data.password = NULL;
    cb_data.prompt_info = "PIN:";

    /* Ensure engine pointer is valid */

    privkey = ENGINE_load_private_key(e, SignPrivKey, NULL, &cb_data);
    md_ctx = EVP_MD_CTX_create();

    rv = EVP_DigestSignInit(md_ctx, &ctx, md, NULL, privkey);
    rv = EVP_DigestSignUpdate(md_ctx, in, inlen)
    // set_signature_md() has been done internally in DigestSignInit()
    rv = EVP_PKEY_CTX_set_rsa_padding(ctx, padding);
    rv = EVP_PKEY_CTX_set_rsa_mgf1_md(ctx, md);
    rv =  EVP_PKEY_CTX_set_rsa_pss_saltlen(ctx, saltlen);
    *olen = 0;
    rv = EVP_DigestSignFinal(md_ctx, NULL, olen);
    *out = OPENSSL_malloc(*olen);
    rv = EVP_DigestSignFinal(md_ctx, *out, olen);

    return rv;
}

And here's an excerpt from PKCS#11 trace, showing that OpenSSL attempts to perform the (forbidden by HSM) raw RSA operation:
199: C_SignInit
2017-10-09 16:13:27.679
[in] hSession = 0x0
pMechanism->type=CKM_RSA_X_509
[in] hKey = 0x30301
Returned:  112 CKR_MECHANISM_INVALID

You need to explicitly indicate that an ENGINEs EVP_PKEY_METHOD will handle a particular key with EVP_PKEY_set1_engine(): OpenSSL can't work that out for itself. You'd typically call that in the ENGINE itself in its load_private_key routine, if appropriate.
I just added a test for redirection which uses that technique.

You need to explicitly indicate that an ENGINE's EVP_PKEY_METHOD will handle a particular key with EVP_PKEY_set1_engine(): OpenSSL can't work that out for itself. You'd typically call that in the ENGINE itself in its load_private_key routine, if appropriate.

Sorry, I'm not sure I fully understand.
I had code that did not know any of that. It did not work for tokens that do internal padding. I added one line EVP_PKEY_set1_engine() that forced/set the engine (again?) for the EVP_PKEY object. That fixed the problem, and the code worked OK with no more changes. I did not do anything with EVP_PKEY_METHOD, beyond what pkcs11 engine is already doing - but this engine is invariant, as in both tests (with and without EVP_PKEY_set1_engine() call before EVP_DigestSignInit()) it was the same.
You seem to suggest that the call EVP_PKEY_set1_engine() should be done within the engine in its method that loads private keys? You also said "if appropriate". How would engine (or I) know when it is or isn't appropriate? Depending on what? As I said, I don't think I fully understand...

When an ENGINE returns a key in its load_privkey() routine it typically has to tell OpenSSL which ENGINE handles that key. At the RSA level it will do this explicitly via a call to RSA_new_method(engine). This point of EVP_PKEY_set1_engine() is to do the same but at the EVP_PKEY level instead of the RSA_METHOD level.
By "appropriate" I mean an ENGINE will call EVP_PKEY_set1_engine() if (a) the ENGINE contains an EVP_PKEY_METHOD for the key algorithm and (b) the key it is returning should use that method.
As for applicability of this PR to other branches. Well at least some of it is clear cut bug fixes. I'd argue that not being able to redirect operations to an ENGINE at the EVP_PKEY level is another bug too but that's just my opinion. For 1.0.2 EVP_PKEY is not opaque and the EVP_PKEY_set1_engine() changes the EVP_PKEY structure so that's problematic: though it could be added to the end.

By "appropriate" I mean an ENGINE will call EVP_PKEY_set1_engine() if (a) the ENGINE contains an EVP_PKEY_METHOD for the key algorithm and (b) the key it is returning should use that method.

Thank you, now I understand (at least I hope I do ;).
Would you object to adding this call to crypto/engine/eng_pkey.c, something like
diff --git a/crypto/engine/eng_pkey.c b/crypto/engine/eng_pkey.c
index 305a648feb..629d591a25 100644
--- a/crypto/engine/eng_pkey.c
+++ b/crypto/engine/eng_pkey.c
@@ -78,6 +78,7 @@ EVP_PKEY *ENGINE_load_private_key(ENGINE *e, const char *key_id,
                   ENGINE_R_FAILED_LOADING_PRIVATE_KEY);
         return 0;
     }
+    EVP_PKEY_set1_engine(pkey, e);
     return pkey;
 }

The current PKCS#11 engine seems able to determine whether the operation should be completely offloaded to the engine, or done in software (except the case when data digest is involved ;). I've tested this change, and it appears to work fine.

I'd argue that not being able to redirect operations to an ENGINE at the EVP_PKEY level is another bug too but that's just my opinion.

I for one concur 100% with your opinion. I suspect there would be quite a few of other like-minded people, especially among those who use HSM (or other tokens that can do padding internally) and probably PIV tokens.

For 1.0.2 EVP_PKEY is not opaque and the EVP_PKEY_set1_engine() changes the EVP_PKEY structure so that's problematic: though it could be added to the end.

For 1.0.2 should the engine pointer just forcefully override ENGINE *engine member of the structure? After all, inside the load_privkey() engine method that member can hardly carry anything (else) of value?
And a semi-generic question. I'd like the engine code to use EVP_PKEY_set1_engine(), but it is unclear when I could expect every OpenSSL installation to be patched to offer it. So, how can I check from within the engine, whether this method is or isn't available, preferably at compile time, but fine if during run-time?  Thanks!

I can't really add that call because it might not be applicable to the ENGINE in question. If, for example, the ENGINE redirects operations at the RSA_METHOD level but not EVP_PKEY_METHOD it must not call EVP_PKEY_set1_engine() and that call will return an error. So the ENGINE has to decide that for itself.

I can't really add that call because it might not be applicable to the ENGINE in question.

Understood, thanks. A pity, though. ;-)
Is there a good straightforward way for an engine (or other code) to determine whether EVP_PKEY_set1_engine() is available in the given binary OpenSSL installation?

Well since it adds a new function code you could test to see if EVP_F_EVP_PKEY_SET1_ENGINE is defined.

OK, now with the engine with EVP_PKEY_set1_engine() added to its load_privkey() my test-code seems to work fine (on PIV and HSM, with RSA-PKCS and RSA-PSS). So it looks like the majority of the issues have been nailed.
How would we proceed to having this fix merged to master and percolated to 1.1.0?

Update: rebased against master and documentation added.

OK this should be ready for review now.
The 1.1.0 backport of EVP_PKEY_set1_engine() is debatable as to whether it is a new feature or not... I'd argue that it is a bug fix because without this you can't use EVP_PKEY_METHOD in an ENGINE properly (as bit like a missing accessor).
Alternatively I can just keep this as master for now and have the less controversial bug fixes for backport to 1.1.0 which would be a separate PR.

The 1.1.0 backport of EVP_PKEY_set1_engine() is debatable as to whether it is a new feature or not... I'd argue that it is a bug fix because without this you can't use EVP_PKEY_METHOD in an ENGINE properly (as bit like a missing accessor).

You have a better access to the OpenSSL dev team than I do, so you know better when the above can be discussed - and maybe even can predict how the discussion would go. But in my humble opinion, how can this be considered as anything but a missing accessor case? A missing accessor that makes it impossible to use combined modes like EVP_DigestSignInit() with engines/tokens that insist on applying padding like PSS internally (rather than "outsourcing" it to the OpenSSL software)?
If you think it would hold the progress of this PR for too long, then probably your alternative strategy of applying this to master, and submitting a second (similar) PR for 1.1.0 is a better option. I can't gauge the best course because I don't know what to expect from the rest of the team.

OK just to be crystal clear on this. Does the approval cover the 1.1.0 backport too or should I put that in a separate PR?

Pushed now to master and 1.1.0 apart from the enginetest where the changes were so extensive it deserved a separate PR see #4520

Thanks!

@snhenson I'm having problems with OpenSSL-1.0.2, as it does not provide EVP_PKEY_set1_engine().  Can it be added there? Since there seems to be an agreement that this absence is a bug?
Because we not only need the ability to access the structure - but to differentiate between pkey->engine and pkey->key_engine, which the current OpenSSL_1_0_2-stable lacks.

Sorry, this is not possible for 1.0.2.  One of the reasons is that the EVP_PKEY structure is public instead of opaque there, and adding another field is not backward compatible.

Sorry, this is not possible for 1.0.2...

@levitte OK, I understand. But since it is a bug (that interferes with combined mechanisms like EVP_DigestSignInit()), perhaps we can resurrect https://github.com/openssl/openssl/pull/4495 specifically for 1.0.2?


ESP32 WROOM-32 board support

Love the library.  Would love support for the ESP32 WROOM-32 boards.  Similar looking to the ESP32-VROOM-32D but with different pinout.

Thanks.

Here's an image that lines up with the ESP32-VROOM-32D image:

The board is now available.


[EasyCI] Add php-json command to provide currently support PHP versions

Closes https://github.com/symplify/symplify/issues/2584
The output of php-json here: https://github.com/symplify/symplify/pull/2592/checks?check_run_id=1503614394

cc @ruudk Hi Ruud, this is the dynamic PHP json command I talked about :)

Amazing 😍👏

Shouldn't this return just the array with versions? Same for the other packages-json command. Because then you can use them both to build your matrix.

Maybe I'm wrong. Can you try to use this and make a matrix that contains the php versions and the packages of a monorepo. Curious if you can get it to work without using my sed trick to strip down the JSON output.

Shouldn't this return just the array with versions? Same for the other packages-json command. Because then you can use them both to build your matrix.

Yes, you're right :+1:

It works now :)

cc @tomasnorre This is the pull-request for php-json command, in case you're interested


Implement SqliteCommand.Prepare

New try to implement SqliteCommand.Prepare.
Compared to #334 the following additional changes where made:

connections are explicitly closed and debug builds throw an exception, so that the existence of undisposed statements can be tracked
in ExecuteReader statements are disposed before binding related exceptions are thrown, so that the connection can be closed safely afterwards
disallow a second open data reader or changes to CommandText or Connection while an reader is open
since the disposal of commands did not always dispose all statements in the EF test suite, added a list of all statements associated to a connection and dispose them excpilictly before trying to close the connection

Addresses #235.

Inspired by the benchmark refered to in #235, I have redone the described insert test of 100000 values with this patch:
 |                                Method |       Mean |     Error |    StdDev |     Median |
 |-------------------------------------- |-----------:|----------:|----------:|-----------:|
 |    InsertSpeed_Prepared_NoTransaction |   499.6 ms | 11.935 ms | 32.873 ms |   485.4 ms |
 |    InsertSpeed_Prepared_InTransaction |   245.7 ms |  2.791 ms |  2.474 ms |   245.0 ms |
 | InsertSpeed_NotPrepared_NoTransaction | 1,129.4 ms | 20.718 ms | 18.366 ms | 1,121.4 ms |
 | InsertSpeed_NotPrepared_InTransaction |   887.2 ms | 17.695 ms | 23.009 ms |   887.6 ms |

Where the methods are:

InsertSpeed_Prepared_NoTransaction: use prepared statements and rebind the parameters for each insert
InsertSpeed_Prepared_InTransaction: use prepared statements inside a transaction and rebind the parameters for each insert
InsertSpeed_NotPrepared_NoTransaction: change CommandText for each insert
InsertSpeed_NotPrepared_InTransaction: change CommandText for each insert; the loop runs inside a transaction

The benchmark code can be found here:
https://github.com/AlexanderTaeschner/MicrosoftDataSqliteBenchmarking/blob/master/InsertTest/Program.cs

Out of curiosity I added the same tests using the System.Data.SQLite library.
In the following table the results are presented (SDS marks the tests run against System.Data.SQLite and
MDS the ones using Microsoft.Data.Sqlite). The benchmark runs were done on a faster PC than the ones presented above, so don't wonder that the times are different to the other table!
 |                                    Method |     Mean |      Error |     StdDev |
 |------------------------------------------ |---------:|-----------:|-----------:|
 |    InsertSpeed_MDS_Prepared_NoTransaction | 225.2 ms |  1.5993 ms |  1.4177 ms |
 |    InsertSpeed_SDS_Prepared_NoTransaction | 248.4 ms |  1.1239 ms |  1.0513 ms |
 |    InsertSpeed_MDS_Prepared_InTransaction | 109.6 ms |  1.7031 ms |  1.4222 ms |
 |    InsertSpeed_SDS_Prepared_InTransaction | 126.7 ms |  1.0315 ms |  0.9648 ms |
 | InsertSpeed_MDS_NotPrepared_NoTransaction | 515.7 ms | 11.5907 ms | 13.7979 ms |
 | InsertSpeed_SDS_NotPrepared_NoTransaction | 623.4 ms |  2.3741 ms |  2.2207 ms |
 | InsertSpeed_MDS_NotPrepared_InTransaction | 359.3 ms |  0.8317 ms |  0.6493 ms |
 | InsertSpeed_SDS_NotPrepared_InTransaction | 435.4 ms |  3.4132 ms |  3.1927 ms |

The MDS runs are slightly faster than SDS :)

Hey @AlexanderTaeschner, sorry I've been unresponsive. We're trying to get everything code complete for 2.0.0 so we can get a good, beta-quality release out. The corresponding issue for this PR was triaged to the backlog, so I've had to prioritize this PR likewise. Once 2.0 settles, I'll come back to this PR.
Given where we're at, this feature probably won't make it into the 2.0 release, but hopefully we can get it into the 2.1 release nice and early to start testing it in the wild.

Picking this up again now that we've branched for 2.0. The improvements look good--looks like you found a few leaks. I'll run the EF Core tests against it an debug.

I'm taking a different approach to debug the EF Core failures: Explicitly call sqlite3_close (throwing if it fails) in the current codebase. This will let me fix the problems there before testing it against this PR.

I got to the bottom of the issue we were seeing. If a connection got finalized before a reader, the connection was left open. Updating to use sqlite3_close_v2 (in #386) has resolved the issue.

Superseded by #388


Add more skip-if-exists, fix wheel packaging

Follow-up to #179

So there seems to be an issue with hatch not including files ignored in a .gitignore.
It looks related to https://hatch.pypa.io/latest/config/build/#vcs at first, although it's not clear because adding an explicit include does include the missed files (.wasm, .tar.gz) to be included in the wheel, but not in the .data...

Just tried locally with the built wheel from the releaser assets and it seems fine:

Gonna log this hatch quirk in an issue and proceed with a new release, so the latest jupyterlite-xeus-python alpha is usable.


Adding Msdeployuseragent to msbuild task arguments

Hi @pragupta-ms, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Prateek Gupta). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;


Crash when entering environment variable

I have been trying for hours now to enter the ./rcon -e zomboid command after editing my .yaml file with all the correct information. Every time I enter it the console just crashes out. No idea why. Only thing I have to go on is that when I type ./rcon -e all by itself it loads the default information, which is empty but it does run and asks for a password, then crashes when I enter.

Please try v0.10.3.


Update scalafmt-core to 3.8.0

About this PR
📦 Updates org.scalameta:scalafmt-core from 3.7.17 to 3.8.0
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scalameta", artifactId = "scalafmt-core" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.scalameta", artifactId = "scalafmt-core" }
}]

labels: library-update, early-semver-minor, semver-spec-minor, commit-count:1

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (352e616) 28.90% compared to head (4660761) 28.90%.

:exclamation: Current head 4660761 differs from pull request most recent head c3dc4ea. Consider uploading reports for the commit c3dc4ea to get more accurate results

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #174   +/-   ##
=======================================
  Coverage   28.90%   28.90%
=======================================
  Files          17       17
  Lines         256      256
  Branches       37       37
=======================================
  Hits           74       74
  Misses        182      182

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


For Marathi, show digits in Marathi (e.g. ४ instead of 4)

Is your feature request related to a problem? Please describe.
People trying to look at the data in their regional language (e.g. Marathi) like to see digits in their regional language.
Describe the solution you'd like
Render the digits in numbers in Marathi when user has chosen Marathi as the locale.
Describe alternatives you've considered
No alternatives.
Additional context
Adding screenshots of how it looks now (English digits rendered) vs. how it should actually look like (Marathi digits rendered when language selection is Marathi)

English Digits
Marathi Digits

Claim

/claim

Arabic numerals are common and easily understood even in these regions. Let's not complicate things.


formatSimple now handles an empty currencyCode

When calling formatSimple with an empty string as a currency code you now no longer get a trailing space.
formatSimple('', 42.17, 2) // '42.17' instead of '42.17 '

I have also updated the dev-dependencies to fix a memory leak that mocha was detecting caused by rewire.

Hopefully that is more to your liking :)

Looks great, we will publish the new version soon after internal testing.

Awesome! I've been implementing this terrible work around that involves a money.format('USD', 10, 2).replace('$', '') and finally felt bad enough to contribute to the project. Hope it helped. Excited to bump the module and remove some .replace nonsense.
👍


Support for ownCloud News

Please add support for ownCloud News: https://github.com/owncloud/news

Owncloud news is already integrated.
Fill the url, ended by index.php/apps/news


Blog demo page

Replicate the blog demo page,
Requires https://github.com/tabler/tabler-react/issues/62
Assigned to @MrJarv1s

Is someone assigned to this one?

@iamzjohn I don't believe so!  Would you like me to indicate it as assigned to you?

@AaronCoplan I can do it, but as I see the Blog Card isn't  done yet, When finished I can take this. And I might help on the Blog Card First

@iamzjohn the Blog Card has been implemented, do you still want to take care of this one?

@jonthomp Please assign me to this one

:tada: This issue has been resolved in version 1.16.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Mark Proper Git Permissions as done

Summary
Check Proper Git Permissions,  Git Labels and Git Milestones as complete

:+1:


OSError: libtorch_global_deps.so: cannot open shared object file: No such file or directory

After creating the environment and running the script provided in the Example Spacetimeformer Training Commands section of the repo, I get the following stack trace:
Traceback (most recent call last):
File "train.py", line 7, in <module>
import pytorch_lightning as pl
File "/home/fsuser/miniconda3/envs/spacetimeformer/lib/python3.8/site-packages/pytorch_lightning/__init__.py", line 30, in <module>
from pytorch_lightning.callbacks import Callback  # noqa: E402
File "/home/fsuser/miniconda3/envs/spacetimeformer/lib/python3.8/site-packages/pytorch_lightning/callbacks/__init__.py", line 14, in <module>
from pytorch_lightning.callbacks.base import Callback
File "/home/fsuser/miniconda3/envs/spacetimeformer/lib/python3.8/site-packages/pytorch_lightning/callbacks/base.py", line 21, in <module>
import torch
File "/home/fsuser/.local/lib/python3.8/site-packages/torch/__init__.py", line 196, in <module>
_load_global_deps()
File "/home/fsuser/.local/lib/python3.8/site-packages/torch/__init__.py", line 149, in _load_global_deps
ctypes.CDLL(lib_path, mode=ctypes.RTLD_GLOBAL)
File "/home/fsuser/miniconda3/envs/spacetimeformer/lib/python3.8/ctypes/__init__.py", line 369, in __init__
self._handle = _dlopen(self._name, mode)
OSError: /home/fsuser/.local/lib/python3.8/site-packages/torch/lib/libtorch_global_deps.so: cannot open shared object file: No such file or directory

The same stack trace is replicable by simply importing torch in a .py script.
I've checked /home/fsuser/.local/lib/python3.8/site-packages/torch/lib/ and there is no libtorch_global_deps.so file. Do I have to pull it from somewhere or install some other torch library?
I'm running this code on Ubuntu 20.04, python3.8 torch1.9.0 and cuda 10.2.

Hi, this looks like a generic PyTorch installation error that isn't related to the spacetimeformer code or PyTorch lightning (which is a third-party library that basically handles training loop boilerplate). Installing PyTorch can be surprisingly tricky at times, especially with cuda version conflicts and so on. I recommend making a new environment and installing the latest version of PyTorch (1.11), which has been tested with the latest version of this repo. I've had to set up PyTorch on a bunch of different servers and in my experience it's usually easier to fix cuda compatibility issues by installing with conda rather than pip. https://pytorch.org/get-started/locally/
You'll know it worked if you can do
import torch
torch.cuda.is_available()

and get "True"

Thanks for reaching back!
I've recreated the environment with python 3.8, torch 1.11.0, cuda 10.2 and installed the requirements via pip, however, the error still persists.


Data table: Align expandable rows to PAL pattern

The component for the expandable row is not following the latest PAL guidance.
PAL guidance: https://pages.github.ibm.com/cdai-design/pal/components/data-table/expandable-rows/usage

Is this issue related to a specific component?
Data table https://github.com/carbon-design-system/ibm-cloud-cognitive/issues/1607
Expected design:

Addd the padding for the expandable area

-Provide aligning options:

Hi @johanna-koval!
We were reading through the PAL guidance on alignment of content — this section looks more like recommendations for the developer using expandable rows rather than something for us to implement.
We will make the changes for padding but will likely leave the content alignment to the developer consuming this component extension.

Hi @elycheea
The padding (top, right, top and bottom) shown in the image should remain the same regardless of the dev/design preference for the internal layout or between content spacing


How to obtain a pointer to a member variable through an object？

Thank you for the awesome library which has helped me solve many problems.
But I have encountered a question while using it recently.
I define and register the following class:
struct B
{

    void Print()
    {
        std::print("{}, {}: {}, {}: {}\n", (void*)this, (void*)&a, a, (void*)&b, b);
    }

    int a{3};
    int b{342};
};

Then I defined a b object and wanted to obtain the address of b. b:
    B b;

    b.Print();

    entt::meta_type type{entt::resolve<B>()};
    void* pb1{type.from_void(&b).get("b"_hs).data()};
    void* pb2{type.get("a"_hs, b).data()};

    entt::meta_handle handle{b};
    void* pb3{type.data("a"_hs).get(std::move(handle)).data()};

    std::print("{}\n", pb1);
    std::print("{}\n", pb2);
    std::print("{}\n", pb3);

But all attempts failed:
0xf9897cee60, 0xf9897cee60: 3, 0xf9897cee64: 342
0xf9897cf150
0xf9897cf580
0xf9897cf2a0

Can you tell me the correct approach?

Thanks for your comment.
I set the meta type as follows before:
entt::meta<B>().base<A>().data<&B::a>("a"_hs).data<&B::b>("b"_hs);

But now I know I should write it this way:
entt::meta<B>().base<A>().data<&B::a, entt::as_ref_t>("a"_hs).data<&B::b, entt::as_ref_t>("b"_hs);


Function and keyword argument name deprecations

This implements the name changes proposed in #245.

Codecov Report

Merging #255 into master will decrease coverage by 0.06%.
The diff coverage is 85.96%.

@@            Coverage Diff             @@
##           master     #255      +/-   ##
==========================================
- Coverage   79.83%   79.77%   -0.07%
==========================================
  Files          50       50
  Lines        4805     4830      +25
==========================================
+ Hits         3836     3853      +17
- Misses        969      977       +8

Impacted Files
Coverage Δ

src/decomp.jl
95.94% <ø> (ø)

src/Tensors/linearalgebra.jl
80.83% <70.58%> (-1.70%)
:arrow_down:

src/Tensors/truncate.jl
93.02% <80.00%> (-4.28%)
:arrow_down:

src/mps/mpo.jl
99.09% <93.33%> (-0.30%)
:arrow_down:

src/mps/mps.jl
99.26% <100.00%> (ø)

src/tagset.jl
89.60% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 374858b...61e8f16. Read the comment docs.

Looks good (fixes #245)


Wrong time shown on chart

First bar shows 2016-09-30 but Elasticsearch results has 2016-10-01 as a first entry. Am I doing something wrong here?

Looks like it's an issue with timezone. I think Kibana timezone setting needs to be supported.

I Prazzy!
I took note of the problem and I will consider errors Timezone ...


Problems with the play page

I have experienced some problems with the play page on the website. (https://cone.jondgoodwin.com/play/index.html)
The hello, world  given as a start gives an error (I don't really know how the syntax is because I just heard of it).

.
Secondly, I am not able to change the theme and editor.

Hi, I am not the author of the website or the language, but the correct current import syntax is now:    import stdio::*
This makes the code work.
Somehow an old version of the PlayGround starting page can still appear, although I can't reproduce this anymore. It's probably a remnant in a cache somewhere.

Thank you mauro for making me aware of this.  I have fixed it.
As for changing the theme and editor, you are right. These capabilities do not really exist. I adapted the playground from another language, and neither removed nor implemented these features.


Add support for Indexes on Expressions

Let's say I have the following index expression (which works for defining complex unique constraints) https://www.postgresql.org/docs/current/indexes-expressional.html
create table request (
  from_user int,
  to_user int,
  active boolean default true
);

CREATE UNIQUE INDEX request_index_constraint
ON request(greatest(from_user,to_user), least(from_user,to_user))
WHERE (active);

When generating the schema, there is no definition for this unique constraint.
findOne method won't be able to target these fields in the where obj.
Index constraints are useful for more complex unique constraints on table columns, and it would be useful to let Prisma find this 'uniqueness' in table rows. Currently, a workaround is the raw function.

I need this feature for unique two-way combination of columns

If I manually update the generated migration to add an expression to an index I run into issues with prisma migrate:
When attempting to update to prisma 4.1 I followed the upgrade guide and ran prisma db pull. It attempted to delete my functional index from my prisma schema.
If I add that index back to my schema and then run prisma migrate dev it now doesn't attempt to delete the functional index, but does attempt to add a new one which fails. This is preventing me from upgrading to prisma 4.x
With the new @@index([created_at(sort: Desc)]) syntax being added. Maybe something like @@index([author, name(lower: true)]) could make sense for this feature request?

Did anyone find any workaround meanwhile?

same problem here, want to use index expressions in postgres, anyone found a workaround for this?

now at the end of 2024, still no progress on this? oh no.


Update mountain car example

Thanks a lot for the feedback @bartvanerp @bvdmitri ! @Sepideh-Adamiat and I will address those issues

@bvdmitri @bartvanerp Thanks for your comments. We changed the notebook accordingly and made a new PR.

Thanks a lot @bartvanerp !

It's correct to change the starting index of the product to t.
Equation (1) is copied from Thijs's paper and I think it's clear. So there's no need to change it.

Thanks guys! I'll take a look on why CI fails.


"Module did not self-register" error when used in an ElectronJS WebWorker Win10

Versions:

usb 1.6.3
ElectronJS 8.0.0
Node 12.18.0
Win10

To reproduce, create a simple worker.js file:
const usb = require('usb')

And from within the JS module loaded by the BrowserWindow in electron (quite a bit of code to include here!)
:
let worker = new Worker(path.resolve(__dirname, 'worker.js'))
:

Generates the following error:
D:\...\node_modules\bindings\bindings.js:121 Uncaught Error: Module did not self-register.
    at process.func (electron/js2c/asar.js:140)
    at process.func [as dlopen] (electron/js2c/asar.js:140)
    at Object.Module._extensions..node (internal/modules/cjs/loader.js:1016)
    at Object.func (electron/js2c/asar.js:140)
    at Object.func [as .node] (electron/js2c/asar.js:140)
    at Module.load (internal/modules/cjs/loader.js:816)
    at Module._load (internal/modules/cjs/loader.js:728)
    at Module._load (electron/js2c/asar.js:717)
    at Function.Module._load (electron/js2c/asar.js:717)
    at Module.require (internal/modules/cjs/loader.js:853)

Not sure if this is Node, Electron or usb. Suggestions?

rebuild with electron-rebuild:
npm install electron-rebuild --dev
./node_modules/.bin/electron-rebuild


fix(adapter-netlify): Append to _redirects

This was easier to fix than expected. The fix should allow users to have their own _redirects file in the project root. If this file exists, it gets copied to build/ before adapter-netlify appends the catchall rule to it.
This behaviour is already documented, but currently broken.
How can I write an automated test for this adapter?
I did the following to test this manually:

Use yarn link "@sveltejs/kit" and yarn link "@sveltejs/adapter-netlify" in my application repository to point the two node modules to my modified versions.
Run svelte-kit build with a _redirects file in the project root.
Check if content of build/_redirects is expected.
Run svelte-kit build without a _redirects file in the project root.
Check if content of build/_redirects is expected.

Any guidance or help how to match the desired code quality to get this PR merged is appreciated.
close #1585
Before submitting the PR, please make sure you do the following

[x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
[x] This message body should clearly illustrate what problems it solves.
[ ] Ideally, include a test that fails without this PR but passes with it.

Tests

[x] Run the tests with pnpm test and lint the project with pnpm lint

Changesets

[x] If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts

@kvn-shn @sw-yx @mikenikles as our resident Netlify users, can you guys reproduce this and are you okay with this change?

I cannot reproduce this. Actually I wouldn't change it because I believe everything is working fine. There just seems to be a small misunderstanding, see https://github.com/sveltejs/kit/issues/1585#issuecomment-850859975

ah yeah what kvn-shn said. it needs to be in the final directory that gets served by netlify, and for sveltekit that is the static folder, not project root.

Yes! :tada: you're totally right. I'm going to close this as it's not needed.

I would have expected it to be in the root directory, so without having looked at this much, this didn't seem like a bad change to me. Do we think static is the better place for it? If so, should we add some documentation about that?

i do think its intuitive to be in the root for people who dont know how netlify works (and pretty self explanatory if you need to move the whole thing into a monorepo setup), but am hesitant to make a special rule that only works for sveltekit but not for anything else. i dont feel strongly about this one but we can always add some docs. did one https://github.com/sveltejs/kit/pull/1596

I'm totally happy putting my _redirects in static/ and I suggest to keep everything as it is. The only thing that could be improved is documentation to save others from the same confusion. I offered to write some when I closed the referenced issue https://github.com/sveltejs/kit/issues/1585#issuecomment-850888505 but @sw-yx already did in #1596.
So all is well.

OK, I'm happy with my own solution, too! :man_shrugging: Proud to be a Svelte-Kit code contributor now.


Fix default params in attestation invocation

Default parameters should always be overwritten by values from the
taskrun spec. This is how Tekton Pipelines behaves. The attestation
should also follow the same rule.
This also fixes zero-value default value representation, i.e. an empty
string or an empty array.
The representation of parameter values is now also consistent. Prior to
this commit, %v on the Param was used for default values while
.StringVal or .ArrayVal was used for non-default values.
Signed-off-by: Luiz Carvalho<EMAIL_ADDRESS>

/ok-to-test

/retest

@priyawadhwa, @wlynch ptal :pray:

@priyawadhwa, need an approval now :pray:


[xml] provide a formatter

before the update I could use alt+shift+f to code format an xml file. After the update this no longer works (using windows version 0.10.1)

This issue is not limited to XML. All code format seems to be gone or the command is broken.

@Thoorium thanks I've updated the title to highlight that.

I am experiencing the same issue with XML files.  Prior to the 0.10.1 update, XML files could be formatted using Alt-Shift-F or the context menu.  Since pulling the update, I cannot format XML files.
I can, however, format .js files.

I am experiencing the same issue with XML files. Prior to the 0.10.1 update, XML files could be formatted using Alt-Shift-F or the context menu. Since pulling the update, I cannot format XML files.
I can, however, format .js files.

XML formatting has been removed as it was based on the HTML formatter and had lot of bugs.
We hope that an extension can provide a high quality XML formatter.

Started to work on one tonight. I'm not at all happy with it yet, but maybe it's a start. https://github.com/FabianLauer/vs-code-xml-format

Great!

There's now even a second extension:
https://marketplace.visualstudio.com/items/DotJoshJohnson.xml

Related #2117

Related #1735 Handlebars Formatting

A workaround to format XML:

change language mode to HTML
format the document
restore language mode.

Based on @aeschli's note about the formatter being related to the HTML formatter.


ability to specify drs rules without overriding datacenter and cluster

currently one has to specify drs rules like following (nested under cluster):
cloud_properties:
  datacenters:
  - name: dc1
    clusters:
    - cluster1:
        drs_rules:
        - name: rule1
          type: separate_vms

which means that one has to know datacenter and cluster name when specifying it. (typically dc/cluster configuration is specified under an az)
ideally we can specify drs_rules at the top level of cloud properties so that one does not have to know about dc/cluster. example:
cloud_properties:
  datacenters:
  - name: dc1
    clusters:
    - cluster1:
  drs_rules:
  - name: rule1
    type: separate_vms

this way drs_rules can be specified in a vm_extension without clobbering az configuration (dc/cluster).
cc @cppforlife

Thanks for the feature request. We already have this in our backlog, this will help us prioritize it.

@yeshwantbabar would you mind adding a link to tracker item here?

https://www.pivotaltracker.com/story/show/155381404

Looking at the story, it appears that this was resolved back in 2018 with a suggestion to use yaml anchors to DRY out the cloud_properties rather than changing the implementation:
The following is possible in the current product:
azs:

name: z1
cloud_properties:
  datacenters:
    clusters:
      vcpi-cluster-1:
        drs_rules: &default_drs_rules
        name: 'rule1'
        type: 'separate_vms'
      vcpi-cluster-2:
        drs_rules: *default_drs_rules


VS upgrade XAM to MAui version 1.8

HI,
I updated Xam to Maui. I have used the sqlite-net-pcl as defined in https://learn.microsoft.com/en-us/dotnet/maui/data-cloud/database-sqlite
If I add the version 1.6 of sqlite-net-pcl the, it will run in Emulator Emulator.
It will not work in Windows App.
NOW: if I upgrade to the most current version 1.8, it will work in Windows app, but Maui will give me the error as defined in the attached screenshot.
System.IO.FileNotFoundException: ‘Could not load file or assembly ‘SQLitePCLRaw.provider.dynamic_cdecl, Version=<IP_ADDRESS>6, Culture=neutral, PublicKeyToken=b68184102cba0b3b’ or one of its dependencies.’
Can you please help

I have the exact same problem! Tried 1.7 and 1.8 of sqlite-net-pcl and also tried different version of SQLitePCLRaw.provider.dynamic_cdecl. Same error (but different version in the error message of course).

This worked again on android after adding SQLitePCLRaw.provider.dynamic_cdecl separatly.


Update CI branch from master to trunk

We have renamed the default branch from master to trunk. This PR updates the CI config files to reflect that change.

@AliSoftware I don't think we have the necessary secret set for this repo. Even though I updated the CI files in these projects, most of them are there due to these being forks.
I'll leave this to @hypest & @mchowning as I don't know how they'd like to go about it. My preference would be to remove the action or leave it as failure.

Thanks for the ping @oguzkocer !
I think we still don't necessarily try to update the fork beyond the gutenberg-mobile requirements so, it should be fine to leave the CI issues as-is (at least when not caused by the gutenberg-mobile changes per se).
So in this case, since the default branch name change doesn't cause the Sentry credentials issue (this other PR has the same issue for example), it's fine to merge.

Thanks for your input @hypest!


Silence a few common errors when fetching

Suppresses the follow errors:

Invalid cert
Forbidden responses
Garbage (non-json dict) responses

Lovely, thank you!


Error running with TF 0.12.1, Python 3.4.3, Ubuntu 14.04

Hi...So I installed all the required dependencies w/ pip3, made sure I can import them in Python3 with no issues, and downloaded dataset as described. Now running: $ python3 udc_train.py produces the following error:
InvalidArgumentError (see above for traceback): Incompatible shapes: [80,1] vs. [160,1]
         [[Node: prediction/logistic_loss/mul = Mul[T=DT_FLOAT, _device="/job:localhost/replica:0/task:0/gpu:0"](prediction/Squeeze, prediction/ToFloat)]]
         [[Node: recall_at_2/ToInt64/_91 = _Recv[client_terminated=false, recv_device="/job:localhost/replica:0/task:0/cpu:0", send_device="/job:localhost/replica:0/task:0/gpu:0", send_device_incarnation=1, tensor_name="edge_217_recall_at_2/ToInt64", tensor_type=DT_INT64, _device="/job:localhost/replica:0/task:0/cpu:0"]()]]

Any idea why this is happening? Any idea how to fix it?
Thanks.

I have same error running with TF 0.12.1, python 2.7, ubuntu 16.04, gtx 1070, cuda 8.0, cudnn 5.1.5. So I ran it on AWS (g2.2xlarge) and the same problem occurred. It is like an error that occurs in tensorflow. But this issue was already closed. https://github.com/dennybritz/chatbot-retrieval/issues/15

Commenting out monitors seems to be fixing the issue. Please confirm?

@pavelromashkin Yes this helped me. Probably because I'm using TF 1.0 where the monitors are deprecated.
Any advice on how to evaluate by reimplementing the streaming in TF 1.0 without monitors?

我使用的是tensorflow-1.12把udc_hparams.py下面的代码改成如下形式就行了
tf.flags.DEFINE_integer("batch_size", 128, "Batch size during training")
tf.flags.DEFINE_integer("eval_batch_size", 16, "Batch size during evaluation")
tf.flags.DEFINE_integer("batch_size", 64, "Batch size during training")
tf.flags.DEFINE_integer("eval_batch_size", 8, "Batch size during evaluation")

I am using tensorflow=1.12.0 on win7 64. i am running into this error during training. thanks.
InvalidArgumentError (see above for traceback): Incompatible shapes: [20,1] vs. [80,1]
[[node prediction/logistic_loss/mul (defined at F:\09.Practice\chatbot-deeplearning-retrieval\models\dual_encoder.py:87)  = Mul[T=DT_FLOAT, _device="/job:localhost/replica:0/task:0/device:CPU:0"](prediction/Squeeze, prediction/ToFloat)]]


Upgrade to Geoip 2.5.0

Upgrade to Geoip 2.5.0

Great job!
Thanks you

nice work @garyelephant .. we'll review this soon.

@garyelephant I took an initial look, and we definitely don't want to upload jars to the repo. They are only needed for build time, so we should use https://github.com/mkristian/jar-dependencies. I'll add an example here.

Great tip!
@garyelephant I am on it, I am doing the PR on your repo. in a few minutes.
Cheers,

@suyograo ,  @ebuildy Thanks, please show me how to use jar jar-dependencies, I have been exhausted in resolving jar dependency problem for days.

Lost some hours because https://github.com/mkristian/jar-dependencies/pull/40 ;-(
I will exclude only google.http, since logstash 2.2 doesnot bring fasterxml library yet, but this is something we have to watch for the next version (or is there any way to version plugin according logstash version?)
I am doing the PR right now,
Cheers,

PR here ==> https://github.com/garyelephant/logstash-filter-geoip/pull/2
Thanks,

@ebuildy fantastic, I was gonna look into this on Monday :) Thanks for the PR. I've left a comment there, just want to make sure all tests pass with jar-dependencies

awesome! I will also take a look at this tomorrow!

This is looking good!
to run it on my mac, I ran the following
bundle install
rake vendor
rake install_jars
bundle exec rspec

(tests pass)
do you think we need to include all of the makefile and dockerfile logic within this repo? It is great for testing within a container, but we have decided that we do not wish to make plugin tests and builds depend on things like Docker.

@talevy sure we can remove ./dev folder, this is not used by the plugin itself, I use it to develop everywhere, and change logstash version w/o break my laptop.

I am little confused by how the jar-dependencies work here at 1) dev time 2) packaging/install time. @joekiller since you worked with kafka jar-dependencies could you please shed some light here? Can you check if the strategy we're using here would work? Basically we'd like to vendor the jars under LS_HOME/vendor/ when installing the gem

I believe there are a few things left to do before we should go ahead and merge this

rebase to resolve conflicts

I am getting gem install issues on logstash 2.2.2 (looks to be installed successfully)

logstash-2.2.2/bin/plugin install logstash-filter-geoip/logstash-filter-geoip-2.0.5-java.gem
Validating logstash-filter-geoip/logstash-filter-geoip-2.0.5-java.gem
Installing logstash-filter-geoip
Error Bundler::InstallError, retrying 1/10
An error occurred while installing logstash-filter-geoip (2.0.5), and Bundler cannot continue.
Make sure that `gem install logstash-filter-geoip -v '2.0.5'` succeeds before bundling.
Error Bundler::InstallError, retrying 2/10

are you seeing the same?

we should place our jars in a consistent place besides the lib directory. To do this we can update the rake command for install_jars like this:

task :install_jars do
  ENV['JARS_HOME'] = Dir.pwd + "/vendor/jar-dependencies/runtime-jars"
  Jars::Installer.vendor_jars!
end

let me know what you think!

@garyelephant also can you bump the version in gemspec to 3.0.0. This may not be fully compatible.

@talevy not sure JAR_HOME works, I believe the library take the require_path:
https://github.com/mkristian/jar-dependencies/blob/master/lib/jars/installer.rb#L199
I search a logstash plugin that could teach me the best practice for that, but didn't find any official plugin yet, any suggestion?
Thanks you,

interesting, works for me. I am not too familiar with jar-dependencies either, this environment variable seems to be a supported solution though.

@talevy @ebuildy All things are done and I have never seen gem install issues on logstash 2.2.2.

One more things:

When I start logstah with this new logstash-filter-geoip installed, it will print such line of log:

file:/home/nitrous/softwares/logstash-2.2.2/vendor/jruby/lib/jruby.jar!/jruby/java/core_ext/module.rb:38 warning: replacing File with Java::JavaIo::File in constant 'File on
class/module JavaIO

Should we hide it ?
You can test it with this conf
# test.conf
input {
  stdin {}
}
filter {
  geoip {
    source => "message"
  }
}
output {
  stdout { codec=>rubydebug }
}

$ ./bin/logstash -f test.conf
# input: <IP_ADDRESS>

Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run; then  say 'jenkins, test it'.

thanks @garyelephant! Yes, it would be great if that warning were hidden from the user. It is the decision of the plugin, not the user.

I don't know why the travis build failed, it succeeded in my laptop.

@talevy Any updates ?

The build is blowing up because the jar's aren't there as they are development depedencies. You need a file in the root called .travis.yml with the following:
sudo: false
language: ruby
cache:
- bundler
- directories:
  - $HOME/.m2
rvm:
- jruby-19mode
before_install:
- gem install jar-dependencies
- bundle install
- rake install_jars

Then it should pass fine.

@suyograo @talevy looks like you got the jar stuff figured out otherwise

fyi I added - rake vendor to the above.

this is also going to be introduced, so just adding the rake install_jars should be necessary after https://github.com/logstash-plugins/logstash-filter-geoip/pull/68 goes in

@joekiller There is no .travis.yml in my fork, maybe this file can't be forked.

@garyelephant do you mind adding a .travis.yml file?
travis may have decided to just use master's script. we should add a script to this PR so it'll properly be tested by the CI

@talevy Please have a look.

+1

I am a bit lost with jar-dependencies stuff :/
When logstash installs a plugin, it does a gem install XXX, isnit? That executes jar dependencies hook (see at https://github.com/jruby/jruby/blob/master/lib/ruby/stdlib/rubygems/defaults/jruby.rb#L123), so to resume, JARs are download from the user server?
Thanks you,

@ebuildy because there are a number of external dependencies that need to be bundled in the gem, you would do:
bundle exec rake vendor
bundle exec rake install_jars
gem build logstash-filter-geoip.gemspec

That would get everything into the gem. So in practice everything will be contained in the gem which allows for "offline" installs and a ready to go package.

we can fix some of the multiple-jar-versions warnings and bump the plugin version in a follow-up PR. I think we had enough changes to this one. looking good! Thanks for keeping up with it all!
LGTM

@joekiller thanks you for the explanation, but when final user will install plugin (which is a gem install XXXX), this will re-install JARs within /lib directory?

@ebuildy not to my knowledge, that is why it is specified as a development dependency: https://github.com/logstash-plugins/logstash-filter-geoip/blob/master/logstash-filter-geoip.gemspec#L28

@ebuildy Since I add the following code in rakefile, jars will only stay in vendor dir. geoip.rb invokes these jars directly from vendor/jar-dependencies/runtime-jars
ENV['JARS_HOME'] = Dir.pwd + "/vendor/jar-dependencies/runtime-jars"
ENV['JARS_VENDOR'] = "false"

when you do gem build, vendor dir as well as these jars will be wrapped in gem tar, without changing dir.

Ok, got the trick! thanks you,

@garyelephant I have tested this new geoip, run rake install_jars then build the .gem end run plugin install *.gem, here the error I got from logstash:

you might need to reinstall the gem which depends on the missing jar or in case there is Jars.lock then resolve the jars with lock_jars command\n\nno such file to load -- com/maxmind/db/maxmind-db/1.1.0/maxmind-db-1.1.0 (LoadError)

How the file /lib/logstash-filter-geoip_jars.rb includes the right files?
# this is a generated file, to avoid over-writing it just delete this comment
require 'jar_dependencies'

require_jar( 'com.fasterxml.jackson.core', 'jackson-databind', '2.6.4' )
require_jar( 'com.maxmind.db', 'maxmind-db', '1.1.0' )
require_jar( 'com.maxmind.geoip2', 'geoip2', '2.5.0' )
require_jar( 'com.fasterxml.jackson.core', 'jackson-annotations', '2.6.0' )
require_jar( 'com.fasterxml.jackson.core', 'jackson-core', '2.6.4' )

I can see jars are present
/opt/logstash/vendor/local_gems/08928a1c/logstash-filter-geoip-2.0.7-java/vendor/jar-dependencies/runtime-jars/geoip2-2.5.0.jar

Whereas this works fine if I run rake install_jars on the same machine than logstash before create the gem. Did I forget something?

This confusion is why I stuck with just letting it dump the jars into lib
for packaging for jruby-kafka
On Apr 19, 2016 2:46 AM, "Thomas Decaux"<EMAIL_ADDRESS>wrote:

@garyelephant https://github.com/garyelephant I have tested this new
geoip, run rake install_jars then build the .gem end run plugin install
*.gem, here the error I got from logstash:
you might need to reinstall the gem which depends on the missing jar or in
case there is Jars.lock then resolve the jars with lock_jars
command\n\nno such file to load --
com/maxmind/db/maxmind-db/1.1.0/maxmind-db-1.1.0 (LoadError)
How the file /lib/logstash-filter-geoip_jars.rb includes the right files?
this is a generated file, to avoid over-writing it just delete this comment
require 'jar_dependencies'
require_jar( 'com.fasterxml.jackson.core', 'jackson-databind', '2.6.4' )
require_jar( 'com.maxmind.db', 'maxmind-db', '1.1.0' )
require_jar( 'com.maxmind.geoip2', 'geoip2', '2.5.0' )
require_jar( 'com.fasterxml.jackson.core', 'jackson-annotations', '2.6.0' )
require_jar( 'com.fasterxml.jackson.core', 'jackson-core', '2.6.4' )
I can see jars are present
/opt/logstash/vendor/local_gems/08928a1c/logstash-filter-geoip-2.0.7-java/vendor/jar-dependencies/runtime-jars/geoip2-2.5.0.jar
Whereas this works fine if I run rake install_jars on the same machine
than logstash before create the gem. Did I forget something?
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/logstash-plugins/logstash-filter-geoip/pull/64#issuecomment-211758943

@ebuildy So I gave you a wrong explanation

@suyograo @talevy @joekiller .
For now, I only know if we remove these two lines from rakefile, this plugin will work fine in installation and runtime.But this will result in installing jars in lib/com.
ENV['JARS_HOME'] = Dir.pwd + "/vendor/jar-dependencies/runtime-jars"
ENV['JARS_VENDOR'] = "false"

Otherwise, it will promote this(I've tested it in logstash 2.2.2, 2.3.1):
The error reported is:
  Couldn't find any filter plugin named 'geoip'. Are you sure this is correct? Trying to load the geoip filter plugin resulted in this error: no such file to load -- logstash
-filter-geoip_jars

Any better idea ?

For now the  author of jar depencies module told me there is no  way yet
to put jars outside lib folder and include  it.
Le 20 avr. 2016 11:07 AM, "Gary Gao"<EMAIL_ADDRESS>a écrit :

@suyograo https://github.com/suyograo @talevy
https://github.com/talevy @joekiller https://github.com/joekiller .
For now, I only know if we remove these two lines from rakefile, this
plugin will work fine in installation and runtime.But this will result in
installing jars in lib/com.
ENV['JARS_HOME'] = Dir.pwd + "/vendor/jar-dependencies/runtime-jars"
ENV['JARS_VENDOR'] = "false"
Otherwise, it will promote this(I've tested it in logstash 2.2.2, 2.3.1):
The error reported is:
Couldn't find any filter plugin named 'geoip'. Are you sure this is correct? Trying to load the geoip filter plugin resulted in this error: no such file to load -- logstash
-filter-geoip_jars
Any better idea ?
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/logstash-plugins/logstash-filter-geoip/pull/64#issuecomment-212339969

@suyograo @talevy The version was bumped to 3.0.0-beta, but these lines of code are still in Rakefile. Haven't users of this plugin see any jar dependency problem ? I believe these code should be removed and let jars to be installed in lib dir.
ENV['JARS_HOME'] = Dir.pwd + "/vendor/jar-dependencies/runtime-jars"
ENV['JARS_VENDOR'] = "false"

@garyelephant seemed to have work for me. I will verify once again and update you

@garyelephant looks like my environment wasn't clean. you are correct, my recommendation was incorrect. I will update the repo before we release. thanks!

@garyelephant @ebuildy
https://github.com/logstash-plugins/logstash-filter-geoip/pull/71 should fix the issue.
May make sense to move to the new way of doing things in jar-dependencies with this fix: https://github.com/mkristian/jar-dependencies/issues/44, but that is not released yet.

@garyelephant @ebuildy many thanks for your contribution here. We'll be releasing this plugin soon with 5.0.0-alpha2 and mention you in the blogs. Also a shout out here: https://www.elastic.co/blog/logstash-lines-2016-05-02

I am assuming this won't be added into 2.x?

Nop like GOT, you must wait :-( if you want it, install
logstash-filter-geoip2 , this is the same plugin (dont forget the
configuration geoip2)
Le 6 juil. 2016 2:34 PM, "Gunter Grodotzki"<EMAIL_ADDRESS>a
écrit :

I am assuming this won't be added into 2.x?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/logstash-plugins/logstash-filter-geoip/pull/64#issuecomment-230758209,
or mute the thread
https://github.com/notifications/unsubscribe/ABKc6etksJboIpCG5wlzNXAH7ONg3SEbks5qS6DBgaJpZM4H0ctI
.


adding feature to control updateStrategy of daemon pods

Pull request checklist
This will provide an additional control over updateStrategy to the user when doing an update to driver pods.
The required value for MaxUnavailable nodes will be set in the configMap(ibm-spectrum-scale-csi-config).
MaxUnavailable nodes: The maximum number of DaemonSet pods that can be unavailable during the update. Value will a percentage of total number of DaemonSet pods at the start of the update (ex: 10%).
The configMap Data will looks like this:
kind: ConfigMap
apiVersion: v1
metadata:
  name: ibm-spectrum-scale-csi-config
  namespace: ibm-spectrum-scale-csi-driver
data:
  VAR_DRIVER_DRIVER_UPGRADE_MaxUnavailable: 50%

Pull request type

Please check the type of change your PR introduces:

[ ] Bugfix
[x] Feature Enhancement
[ ] Test Automation
[ ] Code Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Community Operator listing
[ ] Other (please describe):

What is the current behavior?

What is the new behavior?

How risky is this change?

[ ] Small, isolated change
[ ] Medium, requires regression testing
[ ] Large, requires functional and regression testing

For validating the changes, this image tag can be used: quay.io/badri_pathak/operator_repo:operator_v8


use single equals sign for POSIX-compatible string comparison

Small fix for if statement in gyp_rebuild_inside_node_modules()

Resolves issue #395 @arunoda


Support social media links (contact:facebook, contact:instagram etc.)

Description
It would be good to have support for these tags to speed up adding info to POI, compared to having to manually type-out the tag each time.
I'm aware of https://github.com/openstreetmap/iD/issues/5538, however social media link tagging overwhelmingly uses the contact: prefix.
Screenshots
No response

See linked https://github.com/openstreetmap/iD/issues/3915#issuecomment-595818412,
Anyhow, since then, there's now a tagging repository, so

https://github.com/openstreetmap/id-tagging-schema/issues/434
https://github.com/openstreetmap/id-tagging-schema/issues/121

@tyrasd Suggesting to close as duplicate.

Anyhow, since then, there's now a tagging repository, so

ah right, thanks 👍


MIT License and use in commerical titles?

Would someone be able to use this font in the title (the graphical title) for a commercial product?

Yes.
As I understand the MIT license, you can pretty much do anything you want with the typeface, as long as you include the original copyright notice + license text within (or bundled together with?) the commercial product.
Some notes:
Please note that the MIT license covers everything in the blobject/agave repository, including any documentation, SVG diagrams, the ready-to-use font files themselves (like Agave-Regular.ttf), and all the rest.
However, neither am I a lawyer nor have I been legally advised in this response. If you are at all uneasy, maybe reading up (googling around) a bit more on the license will help. The text of the license itself is quite short.
First paragraph of the license lists the permissions. The short second paragraph states the condition in which the permissions are granted. And the last paragraph in allcaps stresses the copyright holder's (my) exemption from liabilities.
Some references:

https://opensource.org/licenses/MIT
https://en.wikipedia.org/wiki/MIT_License
https://fontsarena.com/licenses-explained/#mit

Thanks for the question.


fix: client mode for issue 588, adding more debug for future investigations

adding some debug and using num executors-1 for client mode
investigating issue https://github.com/Azure/mmlspark/issues/588

/azp run

/azp run

/azp run


Unable to configure using UI - cl_token and cl_refresh_token fields mapped incorrectly

I tried to give this custom component a go to find that I would continually get a "Malformed access token" message in the log and an "Invalid authentication" message in the UI.
2024-03-24 05:58:06.176 DEBUG (MainThread) [custom_components.carelink.api] Carelink API: __execute_init_procedure()
2024-03-24 05:58:06.176 DEBUG (MainThread) [custom_components.carelink.api] Carelink API: _process_token_file()
2024-03-24 05:58:06.177 DEBUG (MainThread) [custom_components.carelink.api] Carelink API: _get_access_token_payload()
2024-03-24 05:58:06.177 DEBUG (MainThread) [custom_components.carelink.api] Carelink API: Malformed access token

Version: 491418666e52344b11e1745fc4302e19cf1619ca

Putting the following in the UI:

I ended up with this logindata.json:
{
    "access_token": "refresh_token",
    "refresh_token": "access_token",
    "client_id": "client_id",
    "client_secret": "client_secret",
    "mag-identifier": "mag_identifier"
}

Looks like the parameters for the access and refresh tokens are swapped. A simple workaround is to enter the refresh token in the access token field and vice versa.
https://github.com/yo-han/Home-Assistant-Carelink/blob/491418666e52344b11e1745fc4302e19cf1619ca/custom_components/carelink/config_flow.py#L40-L47
https://github.com/yo-han/Home-Assistant-Carelink/blob/491418666e52344b11e1745fc4302e19cf1619ca/custom_components/carelink/api.py#L62-L70

I made new release candidate with your pr and a few other fixes. Maybe you can test it too before we make this release public.

@yo-han I have tested 2024.3.1-rc1 and attempted to authenticate, everything works correctly.
Thank you!


Improve user-facing error message

Currently, when a user passes a not-existing stream, asset, or playback, we print this weird message to the user:
{
    "errors": [
        "failed to find object from x-livepeer-playback-id header"
    ]
}

I don't think we should print it, it's meaningless to users. They don't even pass this x-livepeer-playback-id header.
fix https://linear.app/livepeer/issue/ENG-2094/fix-filtering-by-non-existing-playbackid

ty


Make the System Sync + Send

To make the System Send + Sync I applied the following changes:

the GlobalPotential trait now require Send + Sync;
methods of both GlobalPotential and GlobalCache take self by non-mutable reference;

This means that the System no longer has special knowledge of the global potentials and the RefCell are gone in Interactions.
This also means that we can not implement CoulombicPotential for Ewald right away, but we need to go through struct SharedEwald(RwLock<Ewald>) to get both interior mutability and Send + Sync.
@antoinewdg, in #131 you used Arc<Mutex<_>> for this, why the Arc?

And here are the benchmarks!
$ cargo benchcmp --threshold 2 740eee07.log 5e70f33a.log
 name                                  740eee07.log ns/iter  5e70f33a.log ns/iter  diff ns/iter   diff %
 cache_move_all_rigid_molecules        1,119,339             1,078,509                  -40,830   -3.65%
 cache_move_all_rigid_molecules_ewald  8,303,096             7,891,018                 -412,078   -4.96%
 cache_move_particle                   191,847               183,088                     -8,759   -4.57%
 cache_move_particle_ewald             355,302               297,836                    -57,466  -16.17%
 cache_move_particle_wolf              98,163                87,180                     -10,983  -11.19%
 cache_move_particles_ewald            797,484               699,001                    -98,483  -12.35%
 cache_move_particles_wolf             453,070               419,317                    -33,753   -7.45%
 energy                                2,318,900             1,991,234                 -327,666  -14.13%
 energy                                1,073,797             1,097,253                   23,456    2.18%
 energy_ewald                          603,803               502,722                   -101,081  -16.74%
 energy_ewald                          933,875               880,945                    -52,930   -5.67%
 energy_wolf                           468,271               399,198                    -69,073  -14.75%
 energy_wolf                           614,831               648,617                     33,786    5.50%
 forces                                2,716,057             2,252,561                 -463,496  -17.07%
 forces_ewald                          14,724,435            11,603,885              -3,120,550  -21.19%
 forces_ewald                          21,202,124            18,542,706              -2,659,418  -12.54%
 forces_wolf                           875,923               813,276                    -62,647   -7.15%
 virial                                3,013,842             2,642,224                 -371,618  -12.33%
 virial                                1,562,973             1,390,100                 -172,873  -11.06%
 virial_ewald                          86,752,276            83,053,938              -3,698,338   -4.26%
 virial_wolf                           572,575               555,970                    -16,605   -2.90%
 virial_wolf                           865,106               845,681                    -19,425   -2.25%

I don't get why there is a win in all cases, maybe the optimizer doing different stuff with the &self methods? The results are reproducible across multiple benchmark runs.

@antoinewdg, in #131 you used Arc<Mutex<_>> for this, why the Arc?

As I told you my PR was not really meant to be merged, I did not really think about it :). Basically it was because the System needs to be Clone because of the Resize MC move (which is a little weird, but would be solved by separating the system configuration from the interactions).
I'll run the benchmarks on my machine, the difference seems weird : all these changes are not supposed to affect any performance critical part of the code.

The results are more moderate on my machine:
$ cargo benchcmp no_sync sync --threshold 2
 name                        no_sync ns/iter  sync ns/iter  diff ns/iter  diff %
 cache_move_particle_ewald   432,798          422,830             -9,968  -2.30%
 cache_move_particles        352,396          341,654            -10,742  -3.05%
 cache_move_particles_ewald  899,781          880,075            -19,706  -2.19%
 energy_ewald                888,770          864,098            -24,672  -2.78%
 energy_wolf                 498,392          474,542            -23,850  -4.79%
 forces_ewald                16,116,000       15,305,386        -810,614  -5.03%
 forces_ewald                23,518,272       22,574,122        -944,150  -4.01%
 virial_ewald                69,958,093       71,428,725       1,470,632   2.10%

On my side I'm OK to merge, you'll just need to resolve the merge conflicts.

Rebased!

Basically it was because the System needs to be Clone

OK. I went with the 'manually implement Clone' solution. It might be a bit more maintenance work, but this code is expected to go away anyway.

I'll run the benchmarks on my machine, the difference seems weird : all these changes are not supposed to affect any performance critical part of the code.

Yes, there should not be any difference. The only explanation I see would be the optimizer kicking in at some place.


Easy way to change CloseButtonCommand of Snackbar?

Is there an easy way to modify the CloseButtonCommand of the WPFUI Snackbar?
Might be a rookie question, I haven't been involved with classes for too long.

I made a local copy of the Snackbar class and modified the method to my choice, any way I could've done it better?

Hey, what effect do you want to achieve? Close only if something is finished or trigger some event after closing?

Yes, I am using it to show progress of an ongoing task, so I want it to ask for confirmation and end the task on clicking the close button. It would be great to be able to directly customize the event.

I just saw that the CloseButtonCommand property was added, however I can only get it and not set it.


EPUB pages with SVGs need properties="svg" added in manifet

Before proceeding, check to make sure there isn’t an existing issue for this bug.

[X] I have searched the existing issues and determined this is a new bug.

Steps to reproduce

Start a new Quire project
Run quire build and then quire epub to create the EPUB file
Run the EPUB through epubcheck with java -jar path/to/epubcheck.jar patt/to/epubjs.epub

Actual behavior
Our copyright page includes an SVG for the creative commons license. EPUB wants that declared in the package.opf file and is otherwise throwing a validation error.
@fchasen do we need to indicate in the manifest.json file we're feeding epub.js which pages have SVGs, or is epub.js supposed to figure this out?
Expected behavior
The presence of an SVG on any page should be recorded in the pakage.opf file as in this example:
<item id="id_03_pdf-epub-copyright" href="03_pdf-epub-copyright.xhtml" media-type="application/xhtml+xml" properties="svg" />

Version numbers
quire-cli 1.0.0-rc.6
quire-11ty 1.0.0-rc.8
node 18.12.1
What browsers are you seeing the problem on?
No response
Relevant Terminal/Shell output
No response
Supporting Information
No response

Properties can be pass down on readingOrder items by adding an array of properties like below:
 "readingOrder": [
        {
            "url": "content/titlepage.html",
            "properties": ["svg"]

        }
]

Closing because this is duplicated in #780


"Invalid Login or password." is grammatically incorrect

This was changed in PR #4014 and released with 4.1.0.
With an incorrect password the user sees "Invalid Login or password." "Login" shouldn't be capitalized in this case, as it's not a proper noun and isn't at the beginning of the sentence.
This is because of the following i18n string:
invalid: "Invalid %{authentication_keys} or password."

#4014 "humanized" the authentication_keys variable, thus causing this issue.

I'm not sure how this should be resolved, different languages will have different requirements with regards to capitalization.

Before 4.1 the keys was not "humanized", and we have something like email or password.
With the humanized version we have now something like E-mail or password.
If we keep this way, the password is not consistent with E-mail.
I think we should provide a nice default for the english language.
For other idioms, they can simply change the entire message of the yml file of the specific language with their specific rules. Without rely on authentication_keys.
invalid: "The idiom custom message here"

@ulissesalmeida I think I'm not following, are you saying we should not humanize them for English, or we should replace it with our own message that doesn't include authentication_keys?

@connorshea I think we should humanize them for English since it is the Devise default(downcasing the keys). For other languages that do not follow this default, I think they should change in their application for a proper translation that's doesn't include the authentication_keys.

@ulissesalmeida Are there still plans to change this back to using all lowercase (but keeping the humanize change)?

I think humanize authentication keys is good for English but why password is not part of ?

@crawfoal @bernardogalindo We can follow with the downcase solution (keeping the humazine attribute). If someone is willing to open a PR for this, I'd be happy to accept it.

Closed via https://github.com/plataformatec/devise/pull/4834


Introduce and Use NetworkIndicator component

Signals to the user when they are running on a network other than main.
Closes https://github.com/bitcoin-core/gui-qml/issues/233
Light

testnet
signet
regtest

Dark

testnet
signet
regtest

Updated from bcb3aee to dd76b6e, compare

Changes: I've been informed by @GBKS that the text should always be white

Rebase?

ACK 932622e674b6e2476f635e901b2b00cbc58b7e6a
Changes look good and match figma spec.

Updated from 932622e to 01b3909, compare
changes: addressed indenting issue but also removed the id for the block clock component since its not being used here.

Sorry for the late feedback. A couple of details don't match the design. The font should be 15px, and vertical spacing should be 2 (horizontal remains 7). As is right now, the indicator looks slightly too big compared to everything else.


Add macOS 'JupyterLab' menu and tag Help menu

Add the standard entries to the macOS 'JupyterLab' menu, and mark the Help menu as such so that macOS adds the standard search box.
See #127.

Bump…?

Hello @caesar, I'm the new intern working on the electron app. I'm sorry that there hasn't been much activity or response from our side. I looked at your changes and the majority look good to merge.
However, I'm not sure about changing the location of the settings/preference menu item. It would make more sense in the macos environment to follow the standard, but maintaining consistency with the browser environment is also important.
Let me know what you think, and I'm sure we can get this merged in soon.

@declanvk what is that status of this? Does it need to be merged or can it be closed?

Closing this PR as it's been covered in recent PR's Please open an issue if you're still having any trouble!


CHI (Channel Islands) is available as county when creating new entry in Gazetteer

Issue reported by @geoffj-FUG
I have been cleaning up the Gazetteer. I noticed that I had entries against CHI. I tried and was able to enter aplace against it, Appendix B of the Full Handbook has a Chapman Code table. Only level 3 Chapman Codes should be able to be entered agianst in the Gazetteer. CHI is not a level 3 Chapman Code. Geoff

AS far as I can determine currently the configuration of chapman_code related to this is as follows:
'Islands' => {
'Channel Islands' => 'CHI',
'Alderney' => 'ALD',
'Guernsey' => 'GSY',
'Jersey' => 'JSY',
'Isle of Man' => 'IOM',
'Sark' => 'SRK'
}
I don’t know the history of this configuration

The Channel Islands have always been a problem. FC1 treated them as a county (CHI). The TNA initially treated the Channel Islands as a county but changed to treating 'ALD', 'GSY',  'JSY', 'IOM', and 'SRK' as separate counties in 1871.
FC1 was initially set up based on FC1. FC2 was restructured to follow the TNA with CSVProc with the exception of CHI where it continued to follow FC1 since CHI was managed by one person and team and the volume of records was minimal.
The FC2 search has always functioned at the CHI level both in terms of search place and birth place
https://github.com/FreeUKGen/MyopicVicar/blob/master/lib/chapman_code.rb#L68-L84
.
As a result I suggest no changes be made to the Gazetteer unless we wish to undertake a significant update to both the county structure of the parameters as well as the Gazetteer. This would have to be done with the very active involvement of the CHI county coordinator.
Personally I believe there are more significant issues to be addressed.

Putting on Ice as may wish to address at a later date.

The solution as I see it is the same as the Yorkshire solution.
Appendix B of the Coordinators part of the Handbook has a hierarchy of Chapman Codes.
The concept applied to Yorkshire is that YKS is level 2 and the Ridings are level 3.
New entries can only be entered for level 3 Counties (i.e. the Ridings). The system validates any entry for YKS which aligns with a Gazetteer entry in a Riding.
The same concept has been applied to HAM and IOW.
My view is that CHI is a level 1 entry so should not have places against it. They should be against the individual Island. So CHI St Helier would validate against the Gazetteer entry of JSY S Helier. Exactly the same concept. To do otherwise would create duplicate entries in the Gazetteer and we are working hard to avoid that.
That is one reason why the hierarchy was developed.
Geoff

This will be able to be addressed when POB searching is developed.

This is not necessary. We can add the places to the correct Islands in the Channel Islands in the Gazetteer
We have a number of stories regarding searching. The story on searching by England, Ireland etc covers searching for the Channel Islands. The Chapman Code hierarchy to allow this has already been defined (see Validators section Appendix B of the Handbook). The search function is part of the Search epic.
To implement this story breaks the overall structure and rules that have been created and will complicate the implementation of the country level search.
Geoff


Correct options.urlSync.useHash type to boolean

From string. Taken from here.

Hi @dustincoates, Sorry I had fixed this in an hotfix in master and forgot to backport it here, it's good on the website documentation thought.
Thanks

Hey @vvo sounds good. One thing: I'm still seeing it as string on the website, however.

Sorry went way too fast, I already had fixed the "urlSync" option but it's another one here

moved to #724


⚠ Bofrost.de has degraded performance

In 54acdb1, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1196 ms

Resolved: Bofrost.de performance has improved in 9b3d454.


extract year, country, pupulation into own fragment

either something that gets asked before and then kept constant or moving it to a frame on top

This issue can be closed.


"Gârdani" is listed in the drop-down menu

Description:
"Gârdani" is listed in the drop-down menu alongside its corresponding county and commune, according to the law
Precondition:
The website is up an running.

Step 1
Type "Gârdani" in the search bar.

Expected results
The location is listed in the drop-down menu as "Sat Gârdani, MARAMUREȘ (Gârdani)" and "Comuna Gârdani, MARAMUREȘ".


⚠ SceneTime has degraded performance

In 4b3dfc5, SceneTime ($ST) experienced degraded performance:

HTTP code: 200
Response time: 1981 ms

Resolved: SceneTime performance has improved in 23aec42 after 5 minutes.


Time driven loop

Currently main-loop diffs and renders views as needed, when the state is changed. This works great for state which is a function of user input, but seemingly not as well for state which is a function of the render loop itself, i.e. time. I'm thinking of a momentum scroller, for example, whose state is still changing after the user has removed all inputs.
I'm wondering whether you think it's in the scope of this module to handle the case where the application needs a more game-loop like model. Of course, this could be achieved with a second loop, but this doesn't seem quite right - at least for the fact that changing state in the one animation frame will schedule a rerender for the next frame, whereas you really want to update it immediately.
Maybe there could be an option to provide an 'ontick' hook, in which case there is a continual raf callback at work, which checks a 'dirty' flag if it needs to rerender. If there is no hook, it can function the same as it does now and schedule the raf callback as needed
Maybe the loop logic could be reused from another node module?

Can you explain why using raf doesn't suffice?

It suffices. This issue is more wondering "does this functionality belong in this module"
Just identifying that there is this case where applications need more of a game loop, and that this module could also be implemented like a game loop to run a callback every animation frame, checking a dirty flag

some work towards this in #28
the PR passes through the high resolution time from requestAnimationFrame to the render callback.
I added this to solve a problem similar to the one described (scrolling).


Bump tusd to v2.4.0

Bumps tusd to v2.4.0 to enable tackling https://github.com/owncloud/ocis/issues/1755

Full-ci ocis pipeline is green: https://github.com/owncloud/ocis/pull/9714

If I understand correctly we also have to implement the  Unwrap interface otherwise we getting warnings regarding NetworkControlError/NetworkTimeoutError and "feature not supported"
https://tus.github.io/tusd/advanced-topics/usage-package/#i-am-getting-warnings-regarding-networkcontrolerrornetworktimeouterror-and-feature-not-supported-why

If I understand correctly we also have to implement the Unwrap interface otherwise we getting warnings regarding NetworkControlError/NetworkTimeoutError and "feature not supported"

Correct, but we are passing a noop logger (with did that before too). Hence we will not see those error messages.


k3s can't pull images from private registry but crictl is able to

Environmental Info:
K3s Version:
k3s version v1.20.0+k3s2 (2ea6b163)
go version go1.15.5

Node(s) CPU architecture, OS, and Version:
Linux hostname 4.19.0-12-amd64 #1 SMP Debian 4.19.152-1 (2020-10-18) x86_64 GNU/Linux
Cluster Configuration:
1 master, 1 worker (both have the problem)
Describe the bug:
k3s can't pull a image (401 Unauthorized) from my gitlab but crictl can
Steps To Reproduce:

Installed K3s
Konfigured /etc/rancher/k3s/registries.yaml

configs:
  "my.registry.tld":
    auth:
      username: user
      password: token

Expected behavior:
If crictl can pull images the cluster should also be able to?
Actual behavior:
The k3s logs show
Jan 07 21:31:22 area51 k3s[15803]: E0107 21:31:22.850050   15803 pod_workers.go:191] Error syncing pod 3c8b5ed2-fc7c-47e0-95e8-30b56df50794 ("app-deployment-bfcf44fdd-jrbwv_project-production(3c8b5ed2-fc7c-47e0-95e8-30b56df50794)"), skipping: failed to "StartContainer" for "app" with ErrImagePull: "rpc error: code = Unknown desc = failed to pull and unpack image \"my.registry.tld/some/image:latest\": failed to resolve reference \"my.registry.tld/some/image:latest\": failed to authorize: failed to fetch oauth token: unexpected status: 401 Unauthorized"

Additional context / logs:

Any ideas how to debug this further?

Did you place registries.yaml on both nodes, and restart k3s? Can you show an example of pulling the image successfully with crictl?

Did you place registries.yaml on both nodes, and restart k3s? Can you show an example of pulling the image successfully with crictl?

Yes, it is on both nodes (and the service restarted).
And sure:
# crictl pull my.registry.tld/some/image:latest
Image is up to date for sha256:808aa00374cfcf2a4987a2299919df3edb3e7befb13b48709eb6842a4af57929

Yes, it is on both nodes (and the service restarted).
And sure:
# crictl pull my.registry.tld/some/image:latest
Image is up to date for sha256:808aa00374cfcf2a4987a2299919df3edb3e7befb13b48709eb6842a4af57929

Try add secret by command : kubectl create secret ... and use imagePullSecrets.
It works for me.

Try add secret by command : kubectl create secret ... and use imagePullSecrets.
It works for me.

Thats not an option here (due to changing environments) but having a dedicated "deploy" user is (which works using crictl) so i would suspect some k3s validation to have some problems here

Thats not an option here (due to changing environments) but having a dedicated "deploy" user is (which works using crictl) so i would suspect some k3s validation to have some problems here

I have no idea the difference with crictl, but I can tell what I find last night (when I try k3s first time):

First, I create secret by yaml, then use it via imagePullSecrets options, not working

apiVersion: v1
kind: Secret
metadata:
  name: secret-basic-auth
type: kubernetes.io/basic-auth
stringData:
  username: admin
  password: t0p-Secret

I tried /etc/rancher/k3s/registries.yaml, not working
I followed others suggestions, remove quote and slash in registries.yaml, no matter remove imagePullSecrets options or not, still not working

configs:
  my.registry.tld:
    auth:
      username: user
      password: token

I create secret via command, this time it works.

kubectl create secret docker-registry secret-docker
  --docker-username=user
  --docker-password=pwd
<EMAIL_ADDRESS>
It may be helpful.

I have no idea the difference with crictl, but I can tell what I find last night (when I try k3s first time):

First, I create secret by yaml, then use it via imagePullSecrets options, not working

apiVersion: v1
kind: Secret
metadata:
  name: secret-basic-auth
type: kubernetes.io/basic-auth
stringData:
  username: admin
  password: t0p-Secret

I tried /etc/rancher/k3s/registries.yaml, not working
I followed others suggestions, remove quote and slash in registries.yaml, no matter remove imagePullSecrets options or not, still not working

configs:
  my.registry.tld:
    auth:
      username: user
      password: token

I create secret via command, this time it works.

kubectl create secret docker-registry secret-docker
  --docker-username=user
  --docker-password=pwd
<EMAIL_ADDRESS>
It may be helpful.

I was having this same problem too. In my case it was caused by duplicate default routes.
https://devops.stackexchange.com/a/16244/18965


S3 bucket & War file issue

Hi sir,
how can i create a new bucket in S3,how can i get gameoflife.war file and how can i upload that war file into S3 bucket ?

hi rushikesh,
have you attend the jenkins classes? and have your attend the aws s3 classes? if not please wait.
anyway i will tell the procedure please follow and do the steps.

take the code of game of life from git
install java, maven on your linux and goto your game of life project folder and the execute maven goal mvn package
once you execute the mvn package then target folder is created in your project folder and goto gameoflife-web folder and then you see a file gameoflife.war
install aws cli in your linux machine and configure
create a bucket in aws
by using aws cli s3 command you will upload the file to your s3 bucket.
once you upload the file to bucket then make it public.
This is the complete procedure for upload the war file to a bucket.

Tq sir


Fix incorrect indentation of .. warning:: label

Because it's indented, it renders as part of the code block above it.
This is a trivial change so the normal PR template is skipped.

Docs for a0eea94f817f4492be3682c95ef8a7c37132bbdd are browsable at: https://ci.foundries.io/projects/fio-docs/builds/1654/docs/artifacts/html/index.html

Rendered version: https://ci.foundries.io/projects/fio-docs/builds/1654/docs/artifacts/html/reference-manual/security/secure-boot-stm32mp1.html

@arnout Thanks for the patch!


Update circe-core, circe-generic, ... to 0.11.0

Updates

io.circe:circe-core
io.circe:circe-generic
io.circe:circe-jawn

from 0.10.1 to 0.11.0.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention @scala-steward in the comments below.
Have a nice day!

This needs circe-iteratee 0.12.

This is what needed to be released in circe-iteratee: https://github.com/circe/circe-iteratee/pull/12

See #1060 instead.


On iPad, when a smaller (resized) keyboard is used, then it still takes up the space of a normal (big) keyboard.

When I am using the resized (smaller) keyboard on iPad, the resized keyboard still takes up the full keyboard space. How can I prevent this? Only when I move the small keyboard, the excess space is removed and the app is shown in full screen. Please refer to the screenshots. Thanks!
Steps to Reproduce
On an iPad, with the default keyboard resized to smaller size, give focus to any input field.
Expected results:

Actual results:

Logs
Result of flutter doctor -v
[✓] Flutter (Channel stable, 2.0.3, on macOS 11.2.2 20D80 darwin-arm, locale en-IT)
    • Flutter version 2.0.3 at /Users/aaryamanandhar/Documents/flutter
    • Framework revision 4d7946a68d (4 months ago), 2021-03-18 17:24:33 -0700
    • Engine revision 3459eb2436
    • Dart version 2.12.2

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /Users/aaryamanandhar/Library/Android/Sdk
    • Platform android-S, build-tools 30.0.3
    • ANDROID_HOME = /Users/aaryamanandhar/Library/Android/Sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.4, Build version 12D4e
    • CocoaPods version 1.10.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)

[✓] VS Code (version 1.58.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension can be installed from:
      🔨 https://marketplace.visualstudio.com/items?itemName=Dart-Code.flutter

[✓] Connected device (2 available)
    • Ipad (mobile) • 00008020-001069443C2A402E • ios            • iOS 14.4.1
    • Chrome (web)  • chrome                    • web-javascript • Google Chrome 92.0.4515.107

• No issues found!

Hi @manandhar-aarya
Thank you for filing the issue, I can reprpduce the issue,  looks like MediaQuery isn't updated until floating keyboard is moved,
Used the following minimal code sample

minimal code sample
import 'package:flutter/material.dart';

void main() => runApp(MyApp());

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Material App',
      theme: ThemeData.dark(),
      home: Home(),
    );
  }
}

class Home extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text('Material App Bar'),
      ),
      body: Center(
        child: TextField(),
      ),
      floatingActionButton: FloatingActionButton(
        child: Icon(Icons.add),
        onPressed: () {},
      ),
    );
  }
}

stable
master

❌
❌

Check flutter doctor -v outputs for each channel below

flutter doctor -v
[✓] Flutter (Channel stable, 2.2.3, on macOS 12.0 21A5284e darwin-x64, locale
    en-GB)
    • Flutter version 2.2.3 at /Users/tahatesser/Code/flutter_stable
    • Framework revision f4abaa0735 (3 weeks ago), 2021-07-01 12:46:11 -0700
    • Engine revision 241c87ad80
    • Dart version 2.13.4

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /Users/tahatesser/Code/SDK
    • Platform android-30, build-tools 30.0.3
    • ANDROID_HOME = /Users/tahatesser/Code/SDK
    • Java binary at: /Users/tahatesser/Library/Application
      Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/202.7486908/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6916264)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.5.1, Build version 12E507
    • CocoaPods version 1.10.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.2)
    • Android Studio at /Users/tahatesser/Library/Application
      Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/202.7486908/Android
      Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6916264)

[✓] VS Code (version 1.58.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.24.0

[✓] Connected device (4 available)
    • Taha’s iPhone (mobile) • 00008020-001059882212002E            • ios
      • iOS 14.6
    • iPhone 12 Pro (mobile) • 77C62AB9-8B71-43CF-BCAB-85B0A5B52F85 • ios
      • com.apple.CoreSimulator.SimRuntime.iOS-14-5 (simulator)
    • macOS (desktop)        • macos                                • darwin-x64
      • macOS 12.0 21A5284e darwin-x64
    • Chrome (web)           • chrome                               •
      web-javascript • Google Chrome 92.0.4515.107

• No issues found!

[✓] Flutter (Channel master, 2.4.0-5.0.pre.145, on macOS 12.0 21A5284e
    darwin-x64, locale en-GB)
    • Flutter version 2.4.0-5.0.pre.145 at /Users/tahatesser/Code/flutter_master
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision ea4589f714 (8 hours ago), 2021-07-22 01:46:04 -0400
    • Engine revision 269082c333
    • Dart version 2.14.0 (build 2.14.0-341.0.dev)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /Users/tahatesser/Code/SDK
    • Platform android-30, build-tools 30.0.3
    • ANDROID_HOME = /Users/tahatesser/Code/SDK
    • Java binary at: /Users/tahatesser/Library/Application
      Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/202.7486908/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6916264)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.5.1, Build version 12E507
    • CocoaPods version 1.10.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.2)
    • Android Studio at /Users/tahatesser/Library/Application
      Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/202.7486908/Android
      Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6916264)

[✓] Android Studio (version 4.2)
    • Android Studio at /Users/tahatesser/Library/Application
      Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/202.7486908/Android
      Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6916264)

[✓] VS Code (version 1.58.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.24.0

[✓] Connected device (3 available)
    • Taha’s iPad (mobile) • 00008020-000255113EE8402E • ios            • iOS
      14.6 18F72
    • macOS (desktop)      • macos                     • darwin-x64     • macOS
      12.0 21A5284e darwin-x64
    • Chrome (web)         • chrome                    • web-javascript • Google
      Chrome 92.0.4515.107

• No issues found!

✅ : No Issue ❌: Issue reproduced
I will look into this issue in-depth, when keyboard invoked, it is not getting correct padding information, on drag, something is triggered, padding is updated

cc @jmagman
AFAIK, Flutter just depends on the view insets specified by the platform when compositing with a keyboard.

Hello, when can this issue be fixed? @TahaTesser @chinmaygarde

Hi @TahaTesser and @chinmaygarde, I'm in the process of looking at the native versions of my Flutter Web app and came across this one which is pretty striking. Any idea on a fix or a workaround to trigger a relayout or to move the floating keyboard slightly?

Adding resizeToAvoidBottomInset: false to the scaffold stops the screen resizing which works when the keyboard is floating. Is there a way to detect in ios if the keyboard is floating rather than fixed?