Visual Studio Debugging No Longer Works With 2.4 (Unhandled Exception)

Describe the bug
Running into an unhandled exception that VS can't handle? "A debugger is attached to ___ but not configured to debug this unhandled exception. To debug this exception, detach the current debugger." with 2.4. Reverting back to 2.3.200213001 allows debugging again.
Steps to reproduce the bug

Update UWP project WinUI package to 2.4
Debug
Error will be shown.

Expected behavior
Debug to work without error.
Screenshots

Version Info
2.4
NuGet package version:
2.4

Windows 10 version
Saw the problem?

Insider Build (19041)
Yes

November 2019 Update (18363)

May 2019 Update (18362)

October 2018 Update (17763)

April 2018 Update (17134)

Fall Creators Update (16299)

Creators Update (15063)

Device form factor
Saw the problem?

Desktop
Yes

Mobile

Xbox

Surface Hub

IoT

@myokeeh can you enable native debugging and catch all exceptions and share the callstack ? or share the project so we can repro the issue ?

@ranjeshj It also doesn't run after manually running it after a deploy.
Exception thrown at 0x00007FFA39041EA7 (Microsoft.UI.Xaml.dll) in [REDACTED].exe: 0xC0000005: Access violation reading location 0x0000000000000000. occurred
Microsoft.UI.Xaml.dll!00007ffa3def1ea7()
Microsoft.UI.Xaml.dll!00007ffa3df49a0d()
Windows.UI.Xaml.dll!00007ffa88069e46()
Windows.UI.Xaml.dll!00007ffa88069d83()
Windows.UI.Xaml.dll!00007ffa88178aff()
Windows.UI.Xaml.dll!00007ffa8817c601()
Windows.UI.Xaml.dll!00007ffa8817ffaa()
Windows.UI.Xaml.dll!00007ffa8817fbc8()
Windows.UI.Xaml.dll!00007ffa881775e3()
Windows.UI.Xaml.dll!00007ffa880d8876()
Windows.UI.Xaml.dll!00007ffa8817c73c()
Windows.UI.Xaml.dll!00007ffa8817ffaa()
Windows.UI.Xaml.dll!00007ffa8817fbc8()
Windows.UI.Xaml.dll!00007ffa8820e329()
Windows.UI.Xaml.dll!00007ffa881faaae()
Windows.UI.Xaml.dll!00007ffa881fa9f7()
Windows.UI.Xaml.dll!00007ffa881fa93e()
Microsoft.UI.Xaml.dll!00007ffa3df2ca12()
Windows.UI.Xaml.dll!00007ffa8812d516()
Windows.UI.Xaml.dll!00007ffa8812d374()
Windows.UI.Xaml.dll!00007ffa8817c96e()
Windows.UI.Xaml.dll!00007ffa8817ffaa()
Windows.UI.Xaml.dll!00007ffa8817fbc8()
Windows.UI.Xaml.dll!00007ffa880d6e2b()
Windows.UI.Xaml.dll!00007ffa8817c73c()
Windows.UI.Xaml.dll!00007ffa8817ffaa()
Windows.UI.Xaml.dll!00007ffa8817fbc8()
Windows.UI.Xaml.dll!00007ffa8820e329()
Windows.UI.Xaml.dll!00007ffa8817c73c()
Windows.UI.Xaml.dll!00007ffa8817ffaa()
Windows.UI.Xaml.dll!00007ffa8817fbc8()
Windows.UI.Xaml.dll!00007ffa881775e3()
Windows.UI.Xaml.dll!00007ffa880d8876()
Windows.UI.Xaml.dll!00007ffa8817c73c()
Windows.UI.Xaml.dll!00007ffa8817ffaa()
Windows.UI.Xaml.dll!00007ffa8817fbc8()
Windows.UI.Xaml.dll!00007ffa8820e213()
Windows.UI.Xaml.dll!00007ffa881faaae()
Windows.UI.Xaml.dll!00007ffa881fa9f7()
Windows.UI.Xaml.dll!00007ffa8812d4c6()
Windows.UI.Xaml.dll!00007ffa8812d374()
Windows.UI.Xaml.dll!00007ffa8817c96e()
Windows.UI.Xaml.dll!00007ffa8817ffaa()
Windows.UI.Xaml.dll!00007ffa8817fbc8()
Windows.UI.Xaml.dll!00007ffa881775e3()
Windows.UI.Xaml.dll!00007ffa880d88bb()
Windows.UI.Xaml.dll!00007ffa8817c73c()
Windows.UI.Xaml.dll!00007ffa8817ffaa()
Windows.UI.Xaml.dll!00007ffa8817fbc8()
Windows.UI.Xaml.dll!00007ffa880d86a7()
Windows.UI.Xaml.dll!00007ffa8817c73c()
Windows.UI.Xaml.dll!00007ffa8817ffaa()
Windows.UI.Xaml.dll!00007ffa8817fbc8()
Windows.UI.Xaml.dll!00007ffa8820e329()
Windows.UI.Xaml.dll!00007ffa881faaae()
Windows.UI.Xaml.dll!00007ffa881fa9f7()
Windows.UI.Xaml.dll!00007ffa881fa93e()
Microsoft.UI.Xaml.dll!00007ffa3df07ce8()
Microsoft.UI.Xaml.dll!00007ffa3df07a9c()
Windows.UI.Xaml.dll!00007ffa8812d516()
Windows.UI.Xaml.dll!00007ffa8812d374()
Windows.UI.Xaml.dll!00007ffa8817c96e()
Windows.UI.Xaml.dll!00007ffa8817ffaa()
Windows.UI.Xaml.dll!00007ffa8817fbc8()
Windows.UI.Xaml.dll!00007ffa88af577b()
Windows.UI.Xaml.dll!00007ffa88af4992()
Windows.UI.Xaml.dll!00007ffa88af4aa2()
Windows.UI.Xaml.dll!00007ffa8886beab()
Windows.UI.Xaml.dll!00007ffa8817c73c()
Windows.UI.Xaml.dll!00007ffa8817ffaa()
Windows.UI.Xaml.dll!00007ffa8817fbc8()
Windows.UI.Xaml.dll!00007ffa881f1bb4()
Windows.UI.Xaml.dll!00007ffa881f1af3()
Windows.UI.Xaml.dll!00007ffa8825252c()
Windows.UI.Xaml.dll!00007ffa8812d516()
Windows.UI.Xaml.dll!00007ffa8812d374()
Windows.UI.Xaml.dll!00007ffa8817c96e()
Windows.UI.Xaml.dll!00007ffa8817ffaa()
Windows.UI.Xaml.dll!00007ffa8817fbc8()
Windows.UI.Xaml.dll!00007ffa880d6f4b()
Windows.UI.Xaml.dll!00007ffa8817c73c()
Windows.UI.Xaml.dll!00007ffa8817ffaa()
Windows.UI.Xaml.dll!00007ffa8817fbc8()
Windows.UI.Xaml.dll!00007ffa881f1bb4()
Windows.UI.Xaml.dll!00007ffa881f1af3()
Windows.UI.Xaml.dll!00007ffa880e1dc3()
Windows.UI.Xaml.dll!00007ffa8812d4c6()
Windows.UI.Xaml.dll!00007ffa8812d374()
Windows.UI.Xaml.dll!00007ffa8817c96e()
Windows.UI.Xaml.dll!00007ffa8817ffaa()
Windows.UI.Xaml.dll!00007ffa8817fbc8()
Windows.UI.Xaml.dll!00007ffa881f1bb4()
Windows.UI.Xaml.dll!00007ffa881f1af3()
Windows.UI.Xaml.dll!00007ffa8821a9f9()
Windows.UI.Xaml.dll!00007ffa8812d4c6()
Windows.UI.Xaml.dll!00007ffa8812d374()
Windows.UI.Xaml.dll!00007ffa8817c96e()
Windows.UI.Xaml.dll!00007ffa8817ffaa()
Windows.UI.Xaml.dll!00007ffa8817fbc8()
Windows.UI.Xaml.dll!00007ffa8825b804()
Windows.UI.Xaml.dll!00007ffa8817c73c()
Windows.UI.Xaml.dll!00007ffa8817ffaa()
Windows.UI.Xaml.dll!00007ffa8817fbc8()
Windows.UI.Xaml.dll!00007ffa88176727()
Windows.UI.Xaml.dll!00007ffa88175b3e()
Windows.UI.Xaml.dll!00007ffa881141ad()
Windows.UI.Xaml.dll!00007ffa8811403f()
Windows.UI.Xaml.dll!00007ffa88113f66()
Windows.UI.Xaml.dll!00007ffa881ace8d()
Windows.UI.Xaml.dll!00007ffa881acd96()
Windows.UI.Xaml.dll!00007ffa88086289()
Windows.UI.Xaml.dll!00007ffa880882ab()
Windows.UI.Xaml.dll!00007ffa8808819c()
CoreMessaging.dll!00007ffa9d2952fb()
CoreMessaging.dll!00007ffa9d2bc6cb()
CoreMessaging.dll!00007ffa9d29988b()
CoreMessaging.dll!00007ffa9d298d46()
CoreMessaging.dll!00007ffa9d296f81()
CoreMessaging.dll!00007ffa9d296da3()
user32.dll!00007ffaa1aae338()
user32.dll!00007ffaa1aadebc()
user32.dll!00007ffaa1ac06a3()
ntdll.dll!00007ffaa262ebc4()
win32u.dll!00007ffaa0081064()
user32.dll!00007ffaa1aaa5c3()
user32.dll!00007ffaa1aaa523()
Windows.UI.dll!00007ffa8ac0b5be()
Windows.UI.dll!00007ffa8ac0b390()
Windows.UI.dll!00007ffa8ac0b21b()
Windows.UI.Xaml.dll!00007ffa88278960()
Windows.UI.Xaml.dll!00007ffa882788ff()
twinapi.appcore.dll!00007ffa99d4634a()
twinapi.appcore.dll!00007ffa99cfec8f()
SHCore.dll!00007ffaa1c6e699()
kernel32.dll!00007ffaa1eb6fd4()
ntdll.dll!00007ffaa25dcec1()

can you resolve the symbols or share the crash dump ?

Does your app have a navigation view with items in the pane footer ?

I can send you a crash dump. Can you provide an email or a direct contact method? Unfortunately, I can't share the project. The app does have a NavigationView with PaneFooter. Also, the app is very close to what you would get straight from Windows Template Studio with navigation view.

Can you try removing the Items from the PaneFooter and see if that fixes it ? We just found and fixed issue #2388 where that was causing a crash. I'm curious if you are seeing the same thing. If that is not the issue, then I can give you instructions on how to share the crash dump through feedback hub.

Sorry. I left that out in my reply. Yes, removing the PaneFooter allows the app to run without the unhandled exception. I'm curious about sharing crash dump using Feedback Hub, though. I didn't know you could use it for that, too.

@myokeeh Thanks for the confirmation. This issue is a dup then of @2388 then. If you want to share a crash dump, you can file a feedback hub issue and attach the dump there and share the link and we can internally track the crash dump.

@ranjeshj filing it under a specific category or under the entry of the app being debugged?

I think an category is fine, but you can always use this one.

@myokeeh The fix is in the latest pre-release build if you want to unblock in the mean time.


Update html-minifier to v3.

This PR just updates html-minifier to v3.

Thanks! I'll get this bumped and published in a few minutes.

😎 !

thanks!


lnd --version returns wrong info for release v0.5.1-beta-rc1 binaries

Background
Calling "lnd --version" on a v-0.5.1-beta-rc1 binary returns "lnd version 0.5.0-beta commit"
The release binary returns the wrong version string.
Your environment
The lnd is running on an Odroid HC2

version of lnd
lnd version 0.5.0-beta-rc1

which operating system (uname -a on *Nix)
Linux XXXXXX 4.14.78-150 #1 SMP PREEMPT Tue Oct 23 10:43:36 -03 2018 armv7l armv7l armv7l GNU/Linux

version of btcd, bitcoind, or other backend
bitcoind --version
Bitcoin Core Daemon version v<IP_ADDRESS>

any other relevant environment details

Steps to reproduce
Run "/usr/local/bin/lnd --version".
Tell us how to reproduce this issue. Please provide stacktraces and links to code in question.
Expected behaviour
The correct version of the build should be returned: "lnd version 0.5.1-beta-rc1 commit"
Actual behaviour
The version string "lnd version 0.5.0-beta commit" is returned.

Version information is not always updated before the final version is tagged. In this case the version was bumped in rc2.


Can't download pixiv images

Bug description
When I try to download something from pixiv it just won't download.
For example: Tag is "DARLINGintheFRANXX" and it stays at "0/-917"
Screenshot:

Steps to reproduce

Activate only pixiv as source
Type "DARLINGintheFRANXX" and go on Ok
Click on "Get all"
Go to Downloads
Click "Download"
See error

Expected behavior
I expect that it starts downloading when I click on it.
System information
OS: Windows 10
Grabber Version: 7.1.1 nightly

Pixiv integration has been totally renewed in recent versions, so I'll close this ticket 👍


Update to babel@7, webpack@4, <EMAIL_ADDRESS>and storybook@4

Definition of Done

[ ] The code does at least what is defined in the ticket and does not affect any other functionality
[ ] The PR has a meaningful title
[ ] There is a link to the issue-id
[ ] There are no 'hacks' or shortcuts refactoring is preferred
[ ] The happy case of the app was tested at least once manually

Next steps:

Fix istanbul check
Add @babel/preset-typescript
Typescript base setup
Convert libs, actions and reducers


HDDS-5323. Avoid unncessary report processing log messages in follower.

What changes were proposed in this pull request?
Avoid distracting logs in SCM followers during report processing. These logs don't add much value, better avoid them.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-5323
How was this patch tested?
Patched the cluster and now I don't see error logs on the report processing on followers.

Thank You @mukul1987 and @adoroszlai for the review.


spring boot code is broken

service customer/java/springboot code will not work as it does not implement health check
only quarkus code works

Related to #141?

Working in that today.

Fixed, now there is a Deployment_jvm.yml files that can be used to deploy Spring Boot and JVM services in general for the tutorial. Now I am going to update docs.


Recent 1.5 pip wheel not using all the cores

Using the pip package yield subpar core utilization, and is linked with libgomp.
See a more detailed description on the mailing list:
<EMAIL_ADDRESS>

@mxnet-label-bot add [Question]

Closing since the performance issues were verified for 1.5 release.


add an icon which vaguely resembles the actual PS icon without infrin…

…ging on MSFT's copyright
a step in fixing https://github.com/exercism/exercism.io/issues/3112.

I actually messed up the color scheme, the background should be transparent. Let me fix that...

This is ready for review now.

I love it, thanks :)


[NETBEANS-305] Remove references to GPL/LGPL-21 licenses

The GPL reference in apisupport.installer was used in the RCP installer
dialog as a choseable license. As the ALv2 source can't be linked with
GPLv2 code, the file was completely removed (GPLv3 would have been ok!).
The LGPL-21 license in nbbuild was referenced by the modules:
o.jdesktop.beansbinding
hibernate4lib
Both modules would be buildable by the apache netbeans project
(LGPL license) and were already removed from the cluster definition.
Dependend modules were also removed.

Missing from the initial comment:
The dependend modules are form.binding and hibernate. Two exclusions were removed from the rat_exclusions.txt.

I updated the PR, as the first push did not properly remove the o.jdesktop.beansbinding directory. Travis is happy now.


avoid downloader to become idle in order to take new requests from backend, in order to improve performance.

@sibiryakov can please review/merge

Actually everything is fine. May be
len(self) < self.crawler.engine.downloader.total_concurrency

would be more readable?

@sibiryakov you are right. Just updated PR with your observation


[main] Upgrade to latest dependencies

Cron -knative-prow-robot
/cc knative-sandbox/networking-wg-leads
/assign knative-sandbox/networking-wg-leads
Produced by: knative-sandbox/knobots/actions/update-deps
Details:
bumping knative.dev/hack a8ef7b6...e178598:
  > e178598 Update community files (# 157)
  > cf8cbc0 Fix the regex used for matching GitHub Actions files (# 156)
bumping knative.dev/networking 17e1877...27525df:
  > 27525df upgrade to latest dependencies (# 624)
  > 1da6545 Update community files (# 625)
  > c8279cb Update actions (# 623)
  > 1934422 upgrade to latest dependencies (# 622)
bumping knative.dev/pkg d481724...fe26417:
  > fe26417 Allow overriding lease name for a reconciler (# 2435)
  > 9b5c411 allow overriding the default grace period of 45 seconds (# 2423)
  > 4c2331f Bump golang.org/x/crypto (# 2444)
  > 708dc1c Update community files (# 2443)
  > 062ca30 upgrade to latest dependencies (# 2433)
  > 4fcbc1b Update actions (# 2434)
  > 80c511a Wait for reconciler/controllers to return prior to exiting the process (# 2437)

/lgtm
/approve

/lgtm
/approve


Docs improvements

This PR makes a few updates to the docs site:

improve assembly instructions/troubleshooting based on my experience building an instance
use next/image for images for improved image optimization/loading, and make it so when you click on the images they open fullscreen

There seems to be some weird caching stuff going on on some pages, if someone with access to vercel could clear the build cache and rebuild the site that would be awesome

I redeployed with a new cache.


Update container-insights-enable-arc-enabled-clusters.md

This PR intents to change from ” to ". If I used ”, the invalid environment variable was set as follows.
The example of using ”
$ export logAnalyticsWorkspaceResourceId=“/subscriptions/subscriptionId/resourceGroups/resourceGroup/providers/microsoft.operationalinsights/workspaces/workspaceName”
$ echo $logAnalyticsWorkspaceResourceId
“/subscriptions/subscriptionId/resourceGroups/resourceGroup/providers/microsoft.operationalinsights/workspaces/workspaceName”

The example of using "
$ export logAnalyticsWorkspaceResourceId="/subscriptions/subscriptionId/resourceGroups/resourceGroup/providers/microsoft.operationalinsights/workspaces/workspaceName"
$ echo $logAnalyticsWorkspaceResourceId
/subscriptions/subscriptionId/resourceGroups/resourceGroup/providers/microsoft.operationalinsights/workspaces/workspaceName

Best regards.

@kongou-ae : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off


Update README.md

Add the following: description, goals, non-goals, and example.

I'd advocate for naming this "PySubstrait" everywhere, for simplicity. Including in the package names (pysubstrait). It makes it easier to refer to it with brevity and precision.

I'd advocate for naming this "PySubstrait" everywhere, for simplicity. Including in the package names (pysubstrait). It makes it easier to refer to it with brevity and precision.

I'll follow up with a separate PR!


No health endpoint

I was checking the chart against some linter type tools and found that the deployment doesn't have any liveness or readiness probes configured. Having a check in the codebase it seems that we have prometheus metrics but no health endpoint we can use to configure the relevant probes.
For example a tool such as polaris indicates that there should be check in place:
    readinessProbeMissing                😬 Warning
        Reliability - Readiness probe should be configured
    cpuRequestsMissing                   🎉 Success
        Efficiency - CPU requests are set
    linuxHardening                       🎉 Success
        Security - One of AppArmor, Seccomp, SELinux, or dropping Linux Capabilities are used to restrict containers using unwanted privileges
    livenessProbeMissing                 😬 Warning
        Reliability - Liveness probe should be configured

Generally this is best practice to have these configured. So looking for some guidance on the best way to try and implement this is?
The only options I can think right now is:

To open up the prometheus metrics (off by default) and use that endpoint as the http endpoint to check for liveness etc
Or use the preflight agent info command to just return info, for example:

> kubectl exec -ti jetstack-agent-saas-748f8bb945-ljmmx -- preflight agent info
Preflight version:  v0.1.39 linux/amd64
  Commit:  1926f2d424cbea70491bec19e5bfb2cf6c5b1feb
  Built:   Tue, 25 Apr 2023 14:30:11 +0000
  Go:      go1.19 linux/amd64

OAuth2:
  ClientID:          k3TrDbfLhCgnpAbOiiT2kIE1AbovKzjo
  AuthServerDomain:  auth.jetstack.io

Looking for input from the team as to the prefered approach here so I can update the chart.
I've checked the latest (v0.1.20) of jsctl for any difference and this also doesn't have any checks in place:
jsctl clusters connect test_cluster --stdout | yq ea 'select(.kind == "Deployment")

I disagree with the introduction of liveness and readiness probes for the sake of silencing such tools.
It is not "best practice" to blindly add liveness and readiness probes. In fact the Kubernetes documentation cautions against it:
Caution:
Liveness probes can be a powerful way to recover from application failures, but they should be used with caution. Liveness probes must be configured carefully to ensure that they truly indicate unrecoverable application failure, for example a deadlock.

Note:
Incorrect implementation of liveness probes can lead to cascading failures. This results in restarting of container under high load; failed client requests as your application became less scalable; and increased workload on remaining pods due to some failed pods. Understand the difference between readiness and liveness probes and when to apply them for your app.

There is no need for a Readiness probe in venafi-kubernetes-agent and probably no need for a liveness probe....especially a dumb ping-pong endpoint....but nevertheless, that is what @maelvls was asked to implement in https://github.com/jetstack/jetstack-secure/pull/580.
So I guess this issue can be closed.


Doesn't compile

I did a clone of this repo, used CMake to generate build files, and after opening and running with VS the solution file it created, It would not compile due to these errors
Severity	Code	Description	Project	File	Line	Suppression State	Details
Error	C3861	'_getpid': identifier not found	imgui-editor	C:\Users\codin\Downloads\imgui-editor-main\imgui-editor\src\utils\utils.hpp	145
Error	C3861	'_getpid': identifier not found	imgui-editor	C:\Users\codin\Downloads\imgui-editor-main\imgui-editor\src\utils\utils.hpp	145
Error	C3861	'_getpid': identifier not found	imgui-editor	C:\Users\codin\Downloads\imgui-editor-main\imgui-editor\src\utils\utils.hpp	145
Error	C3861	'_getpid': identifier not found	imgui-editor	C:\Users\codin\Downloads\imgui-editor-main\imgui-editor\src\utils\utils.hpp	145
Error	C3861	'_getpid': identifier not found	imgui-editor	C:\Users\codin\Downloads\imgui-editor-main\imgui-editor\src\utils\utils.hpp	145
Error	C3861	'_getpid': identifier not found	imgui-editor	C:\Users\codin\Downloads\imgui-editor-main\imgui-editor\src\utils\utils.hpp	145
Error	C3861	'_getpid': identifier not found	imgui-editor	C:\Users\codin\Downloads\imgui-editor-main\imgui-editor\src\utils\utils.hpp	145
Error	C3861	'_getpid': identifier not found	imgui-editor	C:\Users\codin\Downloads\imgui-editor-main\imgui-editor\src\utils\utils.hpp	145
Error	C3861	'_getpid': identifier not found	imgui-editor	C:\Users\codin\Downloads\imgui-editor-main\imgui-editor\src\utils\utils.hpp	145
Error	C3861	'_getpid': identifier not found	imgui-editor	C:\Users\codin\Downloads\imgui-editor-main\imgui-editor\src\utils\utils.hpp	145

I was able to get this working, but it wasn't exactly what i was expecting to be honest, there's no demos or pictures on it.
Theres a few other bugs that you need to fix in the code, eventually i just decided it wasn't for me

https://github.com/pers0na2dev/imgui-editor/blob/main/imgui-editor/src/utils/utils.hpp#L145
change to
srand((unsigned)time(NULL) * GetCurrentProcessId());

https://raa.is/ImStudio/
Check this out if you are looking for something else.

@Jeremy-Boyle Thanks for the instructions on how to fix, and also for the link to the alternative, I will be looking into both options!


[SPARK-20211][SQL] Fix the Precision and Scale of Decimal Values when the Input is BigDecimal between -1.0 and 1.0

What changes were proposed in this pull request?
The precision and scale of decimal values are wrong when the input is BigDecimal between -1.0 and 1.0.
The BigDecimal's precision is the digit count starts from the leftmost nonzero digit based on the JAVA's BigDecimal definition. However, our Decimal decision follows the database decimal standard, which is the total number of digits, including both to the left and the right of the decimal point. Thus, this PR is to fix the issue by doing the conversion.
Before this PR, the following queries failed:
select 1 > 0.0001
select floor(0.0001)
select ceil(0.0001)

How was this patch tested?
Added test cases.

cc @cloud-fan @davies

Test build #77826 has started for PR 18244 at commit a7396be.

Test build #77828 has started for PR 18244 at commit 8e654bc.

LGTM, pending test

Test build #77826 has finished for PR 18244 at commit a7396be.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77826/
Test PASSed.

Test build #77828 has finished for PR 18244 at commit 8e654bc.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77828/
Test PASSed.

Merged build finished. Test PASSed.

Test build #77838 has started for PR 18244 at commit d36be12.

lgtm

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77838/
Test FAILed.

how about
select 1 > 0.0001D
select floor(0.0001D)
select ceil(0.0001D)
i think constant doube value should be parsed to double as old spark version, not to bigdecimal in antlr4

retest this please

Test build #77848 has started for PR 18244 at commit d36be12.

@discipleforteen Your question is not related to this PR. Converting to the decimal is pretty common for avoiding loss of precision. For example, the link shows how DB2 choose the type when users specify the constant.

Test build #77848 has finished for PR 18244 at commit d36be12.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77848/
Test PASSed.

LGTM

Thanks! Merging to master.
Will submit PRs for 2.2/2.1/2.0


Add rootCaCertificate option to SplunkIO

Transferring over a SplunkIO option (rootCaCertificate) from the SplunkIO implementation in DataflowTemplates here, so that DataflowTemplates can use Beam's SplunkIO implementation (there is an inconsistency in that classic templates use the DataflowTemplates implementation while flex templates use Beam's implementation, and Beam's implementation seems to be missing some options).

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

RAT is failing since I'm adding test .crt files, which RAT doesn't seem to like/recognize. I'm not sure how to fix it though...

Regarding RAT failure, How about generating ".crt" files from tests instead of copying them to the repo ?

To solve the RAT issues, all I did was add .txt to the end of the file names, and now it works (since we are reading the contents of the file, not factoring in the file name). The only thing is that ideally in practice, these cert files should end with .crt and not .txt
The other solution, which I don't like as much, is hardcoding the contents of .crt files as strings and generating them as temporary .crt files during testing, but I feel like that could create a lot of clutter in the test files

LGTM. Thanks.


Firefox ESR exclude

We have many users who at work simply do not have a choice it what browser version they are using. Firefox has ESR which I believe should be excluded. While it may not have the latest features it is still a supported and secured browser. Currently there is no way to exclude an ESR release from detection. Current Firefox ESR releas eis 45.7.

I think we can get this live by end the me the week ☺

Hi @BamaStangGuy,
I apologize for the delayed response. Upon further planning, the team has decided to not implement this feature. Firefox's ESR program does ensure more security support, but may not include features  required by the site owner. Additionally due to the versioned nature of this library, ESR releases can eventually fall out of support.
Thank you for your request and for using Cloudflare Apps.
Cheers,
Teffen


post install script to remove 'broken' tools

add post install script to remove all tools except install and suppress SIGPIPE trap msgs

Looks like zstdport needs md5sum, can you also keep that tool?


Include the available role sizes from locations

Previously the locations client did not return information about the available role sizes in each location. This commit adds two additional properties to the LocationList type to expose a list of Web/Worker role sizes and VM sizes available per region. Since the data is already returned by the API endpoint no API call changes are required.

:+1:, thanks for merging!

we should probably delete dev branch unless necessary.

Agreed, direct into master would be an improvement. Have a number of patches over the next day or two.

@ahmetalpbalkan well it was meant for that, but since no one is using it, we can just work in master branch)

@jen20 thanks for contributing.


bcfishpass object  has observedspp_upstr in weird format - no fpr_my_fish_sp output for Fern Creek

reason we know is that fpr_my_fish_sp did not work for Fern Creek
not sure why as pull from latest remote db has proper format
This is from bcfishpass object in sqlite in repo
my_site <- 125261
fpr_my_bcfishpass(col_pull = observedspp_upstr)
[1] "[\"BB\",\"C\",\"CBC\",\"DC\",\"DV\",\"LSU\",\"RB\",\"RSC\",\"SU\"]"

this is from remote db (bcbarriers)
my_site <- 125261
fpr_my_bcfishpass(col_pull = observedspp_upstr)
[1] "{BB,C,CBC,DC,DV,LSU,RB,RSC,SU}"

will replace the bcfishpass object as this may cause issues elsewhere as this report gets finished. Not sure why the format was odd at the time the original object was made.

object replaced and past version archived into the sqlite


[Security] Workflow ci.yml is using vulnerable action mdecoleman/pr-branch-name

The workflow ci.yml is referencing action mdecoleman/pr-branch-name using references 1.0.0. However this reference is missing the commit 5d3e6b404d96cac1ac4f446a1e490a6671f605df which may contain fix to the some vulnerability.
The vulnerability fix that is missing by actions version could be related to:
(1) CVE fix
(2) upgrade of vulnerable dependency
(3) fix to secret leak and others.
Please consider to update the reference to the action.

@sonic16x


About rule names

Template rules are a little bit mixed, some start with template, others with templates, others with nothing.
I want to propose to normalize them with the prefix template-:
banana-in-box -> template-banana-in-box;
i18n -> template-i18n;
templates-no-negated-async -> template-no-negated-async
trackBy-function -> template-use-trackBy-function (not sure about the capitalized "B")
angular-whitespace -> template-whitespace

Also, another suggestions for names would be:
All the *-life-cycle-* rules should be renamed to *-lifecycle-*, as mentioned in some issues/PRs;
no-output-named-after-standard-event should be renamed to no-output-standard-event or something like that since this rule cares precisely about exact output names.

@rafaelss95 the proposal makes sense. We should coordinate the effort with Angular CLI. It might be a good idea to push the rules before their next major release.

Hey @mgechev :), what about makes these changes before Angular 8?


Fill random docs

The RenderingServer's "*_create" methods can be continued like I started, I just gave up after seeing how many of them are left 🙃
(which once again reminds me of https://github.com/godotengine/godot-proposals/issues/890, because that description "template" can be repeated 37 times).

Thanks!

Cherry-picked for 4.0.2.


Unexpected Error after a few minutes ?

For the last weeks now, the recorder has rarely worked as it should. I had no problems with the automatic mode or ffmpeg for the last half year but now most of the files are corrupted. with VLC I can play them back but apparently the “end” is missing, rewinding is not possible. i get the following error code after about 5 minutes (windows 10 and automatic mode enabled) :
Unexpected error: ('Connection broken: IncompleteRead(0 bytes read, 2 more expected)', IncompleteRead(0 bytes read, 2 more expected))
or
Unexpected error: ('Connection broken: IncompleteRead(3697 bytes read, 399 more expected)', IncompleteRead(3697 bytes read, 399 more expected))
it can't be my internet connection.
Thank you for your work on this project !

So the problem is solved? #182

so far it seems like it is solved, thank you very much
is there a way to stop the automatic mode except CTRL+C to save and closing the window completely?

It is not possible to change modes in real time


Performance issues at AlaSQL database queries - response time of several minutes

Hello,
I am using AlaSQL in a Node.js application.
What I do in build time:

load JSON files into JSON objects.
create database with 3 tables based on that files.
fill the table with the JSON objects
The total amount of data sets is about 2500.

What I do in runtime:
AlaSQL queries, which need to be synchronous and have 2 joins, so all 3 tables are included.
Issue:
When I query the data I get a response time of several minutes. Does anyone know how to fix that or how to do it better?
What I tried:

adding primary key (index) to data sets
reducing data
Unfortunately did not work

Thank you in advance.

I'm also experiencing performance problems with AlaSQL. I created a database with 256k records and attempted to query for a sorted subset, only to find it takes 500-1300ms to do so, and indexes do not seem to have any affect on this. I created a codepen - https://codepen.io/freyley/pen/GRREdom

Hmm. Iteresting to see if the speed tricks is disabled for sorted subsets (it should not)
If you could make an exaple of a query that ou find strangly slow it would really be awesome.

@mathiasrw take a look at the codepen above, it was, last October, in the console, outputting its times to do pretty simple queries.

I have the same issue and have very simple example to show how indexes are really not useful for any real nested query with simple joins :
alasql("CREATE TABLE test (id number, child number)");
for (var i=0;i<100000;i++)
alasql("INSERT INTO test VALUES ("+i+","+Math.floor(Math.random()*250)+")");
alasql("CREATE INDEX test_1 ON test(id)");
alasql("CREATE INDEX test_2 ON test(child)");
//---------------
alasql("SELECT a.id,b.id FROM test AS a JOIN test AS b ON (a.id = b.id) WHERE a.id = 10")
// 3+ seconds, neither 'Joined tables are pre-indexed' nor 'WHERE expressions are pre-filtered for joins'
// 3+ seconds, same result
alasql("SELECT a.id,b.id FROM test AS a JOIN test AS b ON (a.id = b.id)")

I found the problem in the implementation in this case.
Following sql does works as expected also without indexes in some milliseconds  :
alasql("SELECT a.id,b.id FROM test AS a JOIN test AS b ON a.id = b.id")
does not work :
alasql("SELECT a.id,b.id FROM test AS a JOIN test AS b ON (a.id = b.id)")
the problem seems to be in src/421join.js:312
the optimizer expects direct join condition, without dummy UniOp node
https://imgur.com/a/IzldRHU


Add Cilium 1.12.0 update to the changelog

What type of PR is this?
/kind documentation
What this PR does / why we need it:
Add Cilium 1.12.0 update to the changelog.
Does this PR introduce a user-facing change?:
NONE

/lgtm
/approve


no such file or directory, open '...angular2-state-machine/core.js.map'

Expected Behavior
The state machine should be available.
Actual Behavior
Using in an Ionic/Angular app it crashes at runtime with the error:
Error: Module build failed: Error: ENOENT: no such file or directory, open '/test/node_modules/angular2-state-machine/core.js.map'
at Object. (http://localhost:8101/build/vendor.js:123094:7)
at webpack_require (http://localhost:8101/build/vendor.js:55:30)
at Object.193 (http://localhost:8101/build/main.js:44:86)
at webpack_require (http://localhost:8101/build/vendor.js:55:30)
at Object.268 (http://localhost:8101/build/main.js:173:75)
at webpack_require (http://localhost:8101/build/vendor.js:55:30)
at Object.217 (http://localhost:8101/build/main.js:115:73)
at webpack_require (http://localhost:8101/build/vendor.js:55:30)
at Object.194 (http://localhost:8101/build/main.js:97:70)
at webpack_require (http://localhost:8101/build/vendor.js:55:30)
Steps to Reproduce the Problem

Start new Ionic project: ionic start test blank
Install state machine: cd ./test && npm i angular2-state-machine
Copy example state machine into home.ts

import { Component } from '@angular/core';
import { StateMachine, StateEvent } from 'angular2-state-machine/core';

@Component({
  selector: 'page-home',
  templateUrl: 'home.html'
})
export class HomePage {
  stateMachine: any;
  constructor() { }
  ngOnInit() {
    this.stateMachine = new StateMachine({
        initial: 'test',
        events: [
            new StateEvent({
                 name: 'warn', from: ['green', 'red'], to: 'yellow'
            })
        ]
        });
}}

Specifications
Version: 0.0.5 (tried 1.0.0 but had different issues)
Ionic Framework: 3.9.2
Ionic App Scripts: 3.1.9
Angular Core: 5.2.10
Angular Compiler CLI: 5.2.10
Node: 9.11.1
OS Platform: Linux 4.13

@leydar @PalakjainJain Hi, guys! Sorry, but package itself is deprecated what is stated in description, because for now I have no time to support it anymore

Not to worry, @vadym-kukhtin thanks for the update.


Incorrect parsing smartctl data for RAID controller

I have 2 disks on bus 4
root@radius:/etc/zabbix/scripts# smartctl --scan
/dev/sda -d scsi # /dev/sda, SCSI device
/dev/bus/4 -d megaraid,0 # /dev/bus/4 [megaraid_disk_00], SCSI device
/dev/bus/4 -d megaraid,1 # /dev/bus/4 [megaraid_disk_01], SCSI device

But the discovery script gives me 2 equal entries bus 4 without additional mark of disk number on the bus, so zabbix server cannot to create data items on the host.
root@zabbix:~# zabbix_get -s radius -k "mini.disktemp.discovery[get,radius]"
{
    "data": [
        {
            "{#DISK}": "sda"
        },
        {
            "{#DISK}": "bus_4"
        },
        {
            "{#DISK}": "bus_4"
        }
    ]
}

So unusual, whats the hardware?
I'll fix this within a week.

root@radius:~# lshw -class storage
  *-storage
       description: RAID bus controller
       product: MegaRAID SAS 2108 [Liberator]
       vendor: LSI Logic / Symbios Logic
       physical id: 0
       bus info: pci@0000:08:00.0
       logical name: scsi4
       version: 05
       width: 64 bits
       clock: 33MHz
       capabilities: storage pm pciexpress vpd msi msix bus_master cap_list rom
       configuration: driver=megaraid_sas latency=0
       resources: irq:16 ioport:dc00(size=256) memory:de9bc000-de9bffff memory:de9c0000-de9fffff memory:de900000-de93ffff
...

Turns out this fix requires a major rewrite.
Originally, its intended to manually specify RAID configuration settings, but it would be useful to have this feature. For now, you can set
diskListManual = ['/dev/bus/4 -d megaraid,0', '/dev/bus/4 -d megaraid,1']
in mini_ipmi_smartctl.py


feat: landing page

This is a first rough draft of a Titanium centered landing page.

manually rebased and merged to master


logging to stderr, not stdout

Including stderr from the underlying invocation of cwl-runner

This is not relevant for the current version. We should make sure this is done correctly for #3


Prerender sponsors for READMEs

What problem do you want to solve?
Right now, we have multiple repos that pull in the raw data JSON files for sponsors and then generate the same HTML to insert into the README. This requires us to duplicate a bunch of logic in every repo where we want sponsors displayed.
What do you think is the correct solution?
Generate the sponsors sections (headings and tables) and store in a file on the website so each repo can just fetch the file and insert it directly into the README.
Participation

[ ] I am willing to submit a pull request for this change.

Additional comments
Looking for a volunteer for this.

Yes, that's correct.
What I mean is, we can build the file so it's accessible via https://eslint.org/sponsors.md.

Or, I suppose we could also just keep the file in the repository like we do with the data files now.


RTD build does not install dependencies properly

The build mentioned below performs python setup.py install, but I can't see any of the dependencies being installed in the log. It ends up failing on a missing module which was not installed properly...
This seems to block all current builds of the project
Details

Project URL: http://slash.readthedocs.io
Build URL (if applicable): https://readthedocs.org/projects/slash/builds/6804415/
Read the Docs username (if applicable):  vmalloc

I can't see the build url, but I see your latest build https://readthedocs.org/projects/slash/builds/6804398/ and it's failing because you don't have that file on that version https://github.com/getslash/slash/tree/8943721bd25c0d98e2f2884510cbe908e86d03f5/doc

It was on a side branch. I pushed it to develop now to demonstrate -- the file now exists, yet the package itself being documented, for some reason, gets installed without its dependencies: http://readthedocs.org/projects/slash/builds/6807475/
As you can see in the build above, it runs python setup.py install --force, but no dependency appears in the output. The build fails on the missing dependency (logbook in this case)

@vmalloc that's because indeed that package is never installed https://github.com/getslash/slash/blob/4d502d6b40d36dec4ad564fcab962267e0f12125/setup.py
You need to specify the requirements on the setup.py script or referencing the requirements.txt file  from your root project on the pip_requirements.txt file from your /docs directory. Something like this:
# docs/pip_requirments.txt

-r ../requirements.txt

# Other requirements...

But I recommend to put your requirements on setup.py

The project uses pbr, and thus has its requirements in requirements.txt. It works correctly when installed with pip and also when using python setup.py develop. I'll investigate further - it's possible it's a pbr bug....

BTW - pbr was introduced in that project on April 2017... It has worked well since then across many releases - so I'm guessing something broke in RTD's environment very recently that caused this...

@vmalloc I don't know about pbr, sorry. But I can see that your requirements file is different
https://github.com/getslash/slash/blob/4d502d6b40d36dec4ad564fcab962267e0f12125/doc/pip_requirements.txt
https://github.com/getslash/slash/blob/a14d7ab412e197e44dde5537fe93a478a9d7abe3/doc/pip_requirements.txt

Reported to pbr as https://bugs.launchpad.net/pbr/+bug/1751997

Oh you're right - the old version explicitly installed the project via -e ....
Sorry - my bad. The pbr bug is real though, but unrelated to RTD. Thanks a lot!


Want to suggest support for Wistia

Hi @christophcemper, thanks for interesting in this project.
I'll check the Wistia website and let you know.

Hi @christophcemper,
I just added support for Wistia.
Now you can video-to-markdown URLs like:

https://support.wistia.com/medias/h1z3uqsjal
https://wistia.com/series/brandwagon?wchannelid=u2joyabsw9&wvideoid=o54ad5d0t5
http://fast.wistia.com/embed/iframe/26sk4lmiix
...

Let me know about any issue.


blazor route with encrypted parameter

How can I make my blazor application receive encrypted parameters that contain special characters such as "/" and "+" without it not understanding that the special characters are parameter dividers, please help urgently!

Close as it's not related with the project/repository


Why?

You write of the URL standard:
This isn't optimal. Instead, addresses should be formatted so:

but you don't write WHY it isn't optiomal and WHY your new standard is better...

Agreed, this aspect is very under-documented. ipfs/in-web-browsers#4 has a rough version of this, and I'm currently working on making this a proper nice document.

The readme addresses this better now


Change workflow name: se_pair_workflow

Use a more appropriate name.
The naming se_pair_workflow happens to be incorrect. Actually, in the AA database, the fieldmap is computed from 8 images (four pairs of SE acquisitions). We should think of a different way to name all of this because pair is particularly misleading: it is easily confounded with computing the fieldmap using a pair of GRE acquisitions (#20) and looking at the phase difference. Actually, the latter case is a lot more appropriate for the pair word, since it is always computed with two (you could use more, but I don't think anybody is doing that).
On the other case (our current se_pair_workflow) it is appropriate to have more than two images. Results improve significantly.

@oesteban do you have a suggestion for what the new name should be? Perhaps SpinEchoWorkflow (if I changed it to a class, which I kinda want to do) or spinecho_workflow (if we keep it as a function)?


detect folder name from cwd in workdir init

Might not work properly in windows, but closing for now


fix Safari's Square Ripple Bug

if not adding the "z-10", Safari browser round button will have a "square ripple" showing infront of the button.
adding the "z-10" to the parent container of the Button will force the "ripple" show below the Round button and eventually a correct ripple effect inside a round button.

Thank you!


Add metrics visualization

@tomkukral can you rebase please?

@dbecvarik screenshots added. Please review.

LGTM

Could you please rebase this PR?


Replace assertions about DOM elements in risk sort priority integration test

Description
Test failure

should sort priority in the table: Risk page without mock API should sort priority in the table

Timed out retrying after 4000ms: Expected to find element: .rt-tr-group:first-child .rt-tr .rt-td:nth-child(5):contains("6"), but never found it.

cypress/integration/risk/risk.test.js

1564197760603787264 from master build for #2854 on 2022-08-29

Here is the screenshot for the test failure in which collector has Priority of 7:

Here is a frame from the video for the preceding test in which collector has Priority of 6:

Analysis
The test assumes that the priorities of deployments remains the same:

first request which is sorted ascending (get values of first and last row)
second request which is sorted descending (assert expected values of first and last row)
third request which is sorted ascending (assert expected values of first and last row, but value of first row has changed)

Solution
Replace assertions about DOM elements with assertions about requests: include expected search parameters for ascending or descending sort.
Residue

While investigating why Priority table cell heading does not display the initial state of ascending sort:

TableV2 component does not have defaultSorted prop like Table component.
This is the only use of TableV2 component.
There is no use of CheckboxTableV2 component.

Checklist

[x] Investigated and inspected CI test results
[x] Edited integration test

Testing Performed
For local deployment: ran test individually before and after the change

/test ui-unit-tests

@dvail Bad luck. Reminds me of an ironic saying in auto racing: If he didn’t have bad luck, he’d have no luck at all.

I can still see value in testing that the items in the table are in sorted order though, e.g. that each item is >= or <= the following one in the table depending on the sort order. It might be something worth adding in the future if we revisit this test.

Yes, what you suggest is worthwhile. Just yesterday, I found in Vulnerability Management a (commented out) helper function to assert ascending or descending order of the values in a column. I will update this pull request.

One second thought, I will merge this now, and then open a new pull request for Risk and Vulnerability Management.


Remove all hardcoded instances of system clock frequency

revC will run at 48 MHz sysclk (at least in the end, perhaps not initially) so this is a prerequisite for proper revC support.

Done.


Street error

Gettings a "Failed to get info for build TypeError: Cannot read properties of null (reading 'street')" error.

Do you have an address defined in your Easee app? Double check that first. The plugin is getting a response back that would appear to not have one.

I had under contact information and wasnt able to find other places to put it until now.. Just looked again and deep in the settings i found it.. Thanks it works now :)


Maximum resources per chip: audio error with synth containing multiple generators

link to the relevant synth file (via Dropbox)
The above synth file contains two audio-rate noise generators and four oscillators producing low frequency sine waves. The resulting output when a note is triggered produces dropouts that sound like buffer underruns, but I'm not too sure.
Is there an upper limit on the amount of CPU that a chip can use? This patch with a few envelopes would be akin to a duophonic synth voice and it appears that the audio engine is struggling to produce even the generation portion.
Perhaps I am missing the use of another module that could optimize patches of this nature?

I think it might be the filter constantly getting a new cutoff value - how it works is that changing the filter parameters causes a small precalc to happen, which could technically cause more load even though simply using the filter is not that heavy. Or the whole filter might get unstable or something? It is not the best filter out there. I have no audio at the moment, will check later.

I just checked and it seems the CPU use is just so high that the single thread (each channel runs in its own thread) cannot process the synth fast enough. On my desktop it seems to run fast enough but it IS heavy.

Interesting. Can you explain a bit about why that would be? I'm running a quad-core 16gb machine so it must be some particularity of the audio engine. I have nothing against the constraints, for the record. Just trying to figure out where exactly the limit is.

It is quite inefficient because of how you can have the feedback loop back
to the signal chain so it goes through the whole "tree" of modules for each
sample. A different way of doing it would be to render longer buffers of
audio and apply e.g. the filter over the buffer, then a distortion etc. but
that makes it impossible to have the feedback (you can't send back signals
at every sample because the modules don't run in paraller as they are
running now).
I think it might be interesting to have some kind of CPU monitor/profiler
kind of thing for the synths to find the hot spots. I think at least the
filter might be one heavy-ish part, since the cutoff changes constantly.
pe 29. toukok. 2020 klo 9.52 inscripttech<EMAIL_ADDRESS>kirjoitti:

Interesting. Can you explain a bit about why that would be? I'm running a
quad-core 16gb machine so it must be some particularity of the audio
engine. I have nothing against the constraints, for the record. Just trying
to figure out where exactly the limit is.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/kometbomb/prototracker-modular/issues/43#issuecomment-635795495,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAIIV2OXIAWMRNB6Q7YSOF3RT5LUJANCNFSM4NMXTQBA
.


Fix TestIngress update flake

Fixes #34359.
Before we'd expect a 404 when hitting an ingress endpoint where the corresponding Ingress resource had a bogus ingress class. This is wrong since when the Ingress class doesn't match we shouldn't get a response at all (should not even have a generated Gateway). The test relies on a race condition and only passing when the new Ingress has not yet taken effect.
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[x] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Pull Request Attributes
Please check any characteristics that apply to this pull request.
[x] Does not have any user-facing changes. This may include CLI changes, API changes, behavior changes, performance improvements, etc.

@Monkeyanator: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-multicluster-tests_istio
96295889ee11bb0b07a56f6736e6970ac59af7e8
link
/test integ-pilot-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

In response to a cherrypick label: #34373 failed to apply on top of branch "release-1.10":
Applying: Fix TestIngress update flake
Using index info to reconstruct a base tree...
M	tests/integration/pilot/ingress_test.go
Falling back to patching base and 3-way merge...
Auto-merging tests/integration/pilot/ingress_test.go
CONFLICT (content): Merge conflict in tests/integration/pilot/ingress_test.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Fix TestIngress update flake
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to a cherrypick label: new issue created for failed cherrypick: #34396

In response to a cherrypick label: new pull request created: #34397


OSC support

It would be lovely if GPIO Zero supported both the sending and receiving of OSC messages from external processes (either on the same machine or even other machines on the network).
Essentially it would expose core API functionality via an OSC endpoint so that other processes could access GPIO functionality via simple network messages. Additionally, it would be lovely if it was super easy to send OSC messages out from an event handler associated with GPIO activity. This would then allow any other language with an OSC library (pretty much all of them) to leverage the power of GPIO Zero.
For more info on OSC see: http://opensoundcontrol.org

@samaaron Is OSC supported now? In the latest/upcoming release? Can you point me in the direction of some documentation/examples and I'll have a play :)
@jrobinson-uk do you know where I can find some theremin code?

Whoooo, https://twitter.com/Poly_Core combined with blinkenlights! :smile:


Css files are not rendering

The issue is, I can preview the changes locally using 'jigsaw serve' command without an issue but when I publish all files under the build_Production folder, and test using browser then CSS styles render for main index HTML page not for pages like contact/index.html.
Am I missing anything? any help will be appreciated.

I have some experience like this, but I'm not sure if this is the same issue..
I render a classname using blade like this:
isActive($post->getPostUrl('id'))
    ? 'bg-red-500 text-white hover:text-white'
    : 'bg-gray-200 text-black hover:text-black'
}}" href="{{ $post->getPostUrl('id') }}">

So it doesn't compIled on production because it was specified in blade syntax. To solve this my temporary solution was to laid out every single class name that specified in blade into some single hidden div.
@if ($page->production)

@endif

So the compiler can see what the css class that used in the page.

@ithardeep Can you point me to a repo that includes the code for your site? It's hard to say what might be going on without seeing your code.

I have some experience like this, but I'm not sure if this is the same issue..
I render a classname using blade like this:
isActive($post->getPostUrl('id'))
    ? 'bg-red-500 text-white hover:text-white'
    : 'bg-gray-200 text-black hover:text-black'
}}" href="{{ $post->getPostUrl('id') }}">

So it doesn't compIled on production because it was specified in blade syntax. To solve this my temporary solution was to laid out every single class name that specified in blade into some single hidden div.
@if ($page->production)

@endif

So the compiler can see what the css class that used in the page.

Yeah, I did exactly, added some checks as you said and created a new config.production file and then build as production and it works

The way you have it setup with classes inside {{ $page->isActive ... }} should work just fine, so there must be something unusual going on. Are you using PurgeCSS in your webpack.mix.js file? After you run npm run production, can you inspect the CSS that gets built to build_production to see if the classes are missing?

@ithardeep Can you point me to a repo that includes the code for your site? It's hard to say what might be going on without seeing your code.

The way you have it setup with classes inside {{ $page->isActive ... }} should work just fine, so there must be something unusual going on. Are you using PurgeCSS in your webpack.mix.js file? After you run npm run production, can you inspect the CSS that gets built to build_production to see if the classes are missing?

Sorry, I don't have any public repo for it but I can show you how my master page looks like.
And it may sound absurd to you that I am not using webpack.mix.js I am using just jigsaw serve to see the changes.
Here is the code
https://i.imgur.com/fR8alOE.png
But it strange how CSS is rendering without '/'

If you're using a relative path for assets, you would always want the leading / on there; otherwise, for non-root-level files, you'll be resolving the path relative to your current page: href="assets/css/main.css" would, for instance, become something like yoursite.com/contact/assets/css/main.css on your contact page. If you keep the leading / on there at all times, that path will always resolve to yoursite.com/assets/css/main.css.


Junk Pickup

From @mgottholsen on June 28, 2017 17:37
See https://api.louisvilleky.gov/api/geo/FindQuickServiceLookup?address=121 FREEMAN AVE&city=Louisville
Copied from original issue: mgottholsen/IFTTT-Smart-Louisville#10

From @mattgantner on November 13, 2017 17:20
There are several issues we will have to determine how to resolve to make this work.
How do users input their address - or is a geofence acceptable? Users away from home will not get alerts when using a geofence. Users with multiple properties will not get all alerts.
How can we control notification frequency if a geofence is used?
How will edge cases work where a user borders two or more regions?
Can Lojic support the additional load IFTTT might bring?
This appears to be a many-to-one problem and without IDing users this will be difficult.

This API is going to be deprecated. Might need to move the schedule to Open Data portal and query it that way instead.


Package Requested

[x] I would like someone else to build the manifest.
[ ] I would like help so I can submit the manifest.
[ ] I have performed a search and couldn't find this package.
[ ] I have checked that the installer for this package is not a script file
[ ] I think there is a new version available and I have provided the URL.

Please provide the following information
Publisher: Rem0o
Publisher Url: https://github.com/Rem0o/FanControl.Releases
Package Name: FanControl
Description: simply the best fan control software I have ever used, seamless and easy to use, it has also been featured on JayzTwoCents - Everyone NEEDS this FREE piece of software... You will thank me!
Package Version: V146
Installer URL: https://github.com/Rem0o/FanControl.Releases/blob/master/FanControl.zip?raw=true
Current Package Identifier (for new versions):

[Policy] Blocking-Issue
Blocked by Zipped-Binary issue

Should be possible now with this release https://github.com/Rem0o/FanControl.Releases/releases/tag/V181 .
I have created a PR https://github.com/microsoft/winget-pkgs/pull/139277 .

https://github.com/microsoft/winget-pkgs/issues/97145#issuecomment-1947159844

@GDeJay, per https://github.com/Rem0o/FanControl.Releases/issues/1845#event-11836612392, this should be closed as complete.

#97145 (comment)

@GDeJay, per Rem0o/FanControl.Releases#1845 (comment), this should be closed as complete.


Dtr relnote (#9101)

adding note for dtr 2.7.1

Proposed changes

Unreleased project version (optional)

Related issues (optional)

Deploy preview for docsdocker ready!
Built with commit 7f598f9fa9f31764a3cf48a519dc1e8103e8a456
https://deploy-preview-9102--docsdocker.netlify.com


aioredis dependency

Hi @alex-oleshkevich
I just realize we depend on aioredis, it's been a while since I tracked the "complicate" state of redis pythoin libraries but it seemed to me that this one is pretty mych abandonned and that it's async part is now available on https://github.com/redis/redis-py
would you be fancy swithcing dependencies ?

Good news actually!


ODSP driver: Implement reuse of sub-trees

Table-heavy documents have a lot of objects that have same content.
In particular in fluid preview app, cells are represented by Scriptor components that have a bunch of DDSs that are exactly the same (style info). While blob deduping helps here avoid duplicated content, the tree structure of whole file becomes really large. Many parts of that tree are exactly the same. I.e. if a lot of components have DDS with same name, and same content, then the tree that represents such DDS is exactly the same (in terms of its content), but we do not reuse them and write out (and read back) copies of such trees.
It would be great to implement de-duping of trees and access how much benefit that brings.
As an example, Chapter 1 document total tree structure is over 500K! It likely has a lot of opportunities for tree reuse!

@jatgarg, I put it on January, as there is not enough time left in December. But it might be higher in priority that some of your December items, take a look if it make sense (and you have time) to tackle it sooner.

Implementation wise, it should be pretty trivial, We should calculate SHA for shallow tree state (i.e. names of sub-trees and their IDs, if we have them) and then test against other SHAs, If match is found, reuse exactly how we reuse blobs.
The only issue here is how to get IDs for sub-trees. It works fine for trees that we get from snapshot we loaded from - we have all IDs. But if some sub-tree is written by current summarizer, then it does not have an ID to work with, without fetching tree after snapshot posts. We use 'summary handle / path' as an ID when reusing blobs to overcome this, but here that kind of ID becomes part of payload we need to hash, so it will not really work, I think.
To overcome this, we can replace sub-tree & blob IDs with their respective SHAs when calculating SHA of a tree. That way resulting SHAs will be a function of content only, and not be at mercy of server IDs. And full reuse will be possible no matter when tree was created.

Moved out (to February), mostly because prototype work in #4589 suggest that tree reuse is not going to make a big impact if we change format of snapshots - even with data compaction, prototype shows that tree structure can be encoded pretty compact, and take less than 5% of total payload. So while it's useful feature to have, it adds complexity (and potential for bugs), so we need to be careful with making decision to implement it.

Punting, we no longer do deduping on client.

Also blob aggregation would make it noop anyway


C#9 Function Pointers do not count as reference

Hello
Thanks for the project, it is very useful!
It looks like the new C#9 Function Pointers feature do not count as a reference to the method they point to.
For example, looking here:
https://source.dot.net/#System.Net.Security/Interop.OpenSsl.cs,438
It claims there are no references to method VerifyClientCertificate. Furthermore, on the line that actually does reference this method, (through the new "get function pointer" syntax) SslCtxSetVerify is not clickable either, and the browser also thinks that there are no usages of SslCtxSetVerify.

We just need to update to the latest Roslyn.

I've updated to Roslyn 3.9. @alexperovich whenever you have a moment, mind merging my master?

This appears to be fixed on source.dot.net now. Thanks!

This appears to be fixed on source.dot.net now. Thanks!


Proposal: support array of meta tags

For now, meta tags is an object and due to hardcoded pattern, end result is always bound to name="" and content="" attributes. There is a variety of other attributes, so it seems a must to support this.
It's already possible with custom navi.config.js, but the main idea is to have more flexible defaults.
Users might like to write their meta this way:
  '/': createPage({
      title: 'Navi',
      meta: [
        {
          name: 'description',
          content: 'navi-description'
        },
        {
          property: 'og:description',
          content: 'navi-og-description'
        }
      ]
  })

Some kind of draft implementation:
  function generateMetaTags(attrs) {
    if (!Array.isArray(attrs)) return ''

    return attrs
      .map(
        attr =>
          `<meta ${Object.entries(attr)
            .map(([key, val]) => `${he.encode(key)}="${he.encode(val)}"`)
            .join(' ')}>`
      )
      .join('')
  }

  const title = `<title>${route.title || 'Untitled'}</title>`
  const meta = generateMetaTags(route.meta)

Thanks for writing this up! I agree that the default behavior could be improved here.
Another issue is that ‘meta’ can serve as a way of storing metadata ther than the which gets rendered in the page head. For example, I use it to store the titles for the sidebar links on the docs website.
A further issue is that you may want to put things in the head other than meta tags.
It feels like perhaps there should be two things specified: “head” tags, and arbitrary data. Need to have a think about how to approach this.

So one possibility that I’ve thought of is to merge ‘title’ and ‘meta’ into a single ‘head’ option, to which you can supply a JSX  — just like react-helmet.
head:
  <>
    <title>My great page</title>
  </>

However, it would be possible to support a shorthand format where you can just pass a string if you only want to set a title.
The only catch is that this would make it hard to store info that shouldn’t be in the head or body - things like titles for nav bars. However, this could be resolved by adding an “info” option.
So pages would end up with:

head
content
info

Would love to hear any thoughts on this.

This is now supported in Navi 0.11, by passing in head or getHead() to the route() matcher, or by using the withHead() matcher. Will be adding docs shortly.


Adjust cancel previous runs CI to run for PRs only

Summary of changes
Changes introduced in this pull request:

Cancel Previous Runs CI runs for PRs only

Reference issue to close (if applicable)

Closes https://github.com/ChainSafe/forest/issues/1988
Other information and links

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Bring back the whats new button

Hey, could we bring back the Whats New button in the settings? I liked reading the new stuff that is released and it doesn't open if I reinstall or anything. Can we bring it back?

Sure thing, I can do that.

Added in 3ea91f0


Regenerated Networking SDK

Description
https://github.com/Azure/azure-rest-api-specs/pull/2042

This checklist is used to make sure that common guidelines for a pull request are followed.

[x] Please add REST spec PR link to the SDK PR
[x] I have read the contribution guidelines.
[x] The pull request does not introduce breaking changes.

General Guidelines

[x] Title of the pull request is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[ ] Pull request includes test coverage for the included changes.

SDK Generation Guidelines

[x] If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
[x] The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
[x] The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

@EvgenyAgafonchikov still missing package release notes as mentioned earlier.

Updated release notes


Incorrect platform tag in binary wheels

Not sure where this issue is, setuptools-download, shellcheck-py config, or somewhere else, but filing here:
Building binary wheels out of setuptools-download powered packages seems to yield platform tags that are not good for PyPI. This happens at least on Linux.
Reproduces with current shellcheck-py main branch. Tested with python3 -m build, python3 setup.py bdist_wheel, and pip wheel --no-deps ., the Linux wheel ends up with platform tag linux_x86_64. Trying to upload such a wheel yields an error from PyPI:
Binary wheel '...-py2.py3-none-linux_x86_64.whl' has an unsupported platform tag 'linux_x86_64'.

Not sure if other platforms' tags besides Linux would be good, FWIW for a project I'm working on (pretty much just copy-pasted from shellcheck-py) they ended up as macosx_10_9_universal2 and win_amd64.

In retrospect, maybe this is a shellcheck-py issue, but already filed here, so I suppose it can be discussed here.

as with any Linux wheel you must run it through auditwheel after building

(usually via a manylinux docker image)


Zod: generation of typed tuples produces illegal zod array syntax

What are the steps to reproduce this issue?

check out referenced PR
in tests: generate and build

What happens?
zod generator produces zod.array(), which is illegal syntax since error TS2554: Expected 1-2 arguments, but got 0.
What were you expecting to happen?
Produce a typed tuple, similar to:
zod.tuple(zod.string(), zod.object())
Any logs, error output, etc?
generated/zod/example-v3-1.ts:25:24 - error TS2554: Expected 1-2 arguments, but got 0.

25   "example_tuple": zod.array().min(postApiSampleResponseExampleTupleMin).max(postApiSampleResponseExampleTupleMax).optional(),
                          ~~~~~~~

  node_modules/zod/lib/types.d.ts:1055:49
    1055 declare const arrayType: <T extends ZodTypeAny>(schema: T, params?: RawCreateParams) => ZodArray<T, "many">;
                                                         ~~~~~~~~~
    An argument for 'schema' was not provided.

Any other comments?
more issues pop up which are not my main concern, currently.
What versions are you using?
npx envinfo --system --npmPackages orval,zod,axios,msw,swr,@tanstack/react-query,@tanstack/vue-query,react,vue
Need to install the following packages:
<EMAIL_ADDRESS>Ok to proceed? (y) y

  System:
    OS: Linux 5.15 Ubuntu 22.04.4 LTS 22.04.4 LTS (Jammy Jellyfish)
    CPU: (8) x64 Intel(R) Core(TM) i7-9700K CPU @ 3.60GHz
    Memory: 13.61 GB / 31.31 GB
    Container: Yes
    Shell: 5.1.16 - /bin/bash
  npmPackages:
    @tanstack/react-query: ^4.22.0 => 4.22.0
    @tanstack/vue-query: ^4.22.0 => 4.22.0
    axios: ^0.26.1 => 0.26.1
    msw: ^2.0.2 => 2.0.2
    react: ^18.3.1 => 18.3.1
    swr: ^2.2.4 => 2.2.4
    vue: ^3.3.4 => 3.3.4
    zod: ^3.23.8 => 3.23.8

reuses test cases of prefixItems added in https://github.com/orval-labs/orval/issues/890

A similar issue was reported in kubb, but since kubb is deprecated, i was recommended to switch to orval. https://github.com/kubb-labs/kubb/issues/1018

https://github.com/kubb-labs/kubb/commit/35b7a0a7822716b9625c0c96a904ec0c7b9ebe4a

Hey. I looked into the issue.
So far, it is half-way working. An issue I have currently is that min and max are added to my tuple call. However, zod does not allow it to follow tuple() calls. Any ideas how to get rid of it?.
More questions:

is orval$ yarn run build && cd tests && yarn run generate && cd .. really the quickest way to rerun the tests after changing the logic in pacakges/zod/index.ts?
What is consts for? Are there edge cases I have to know about?

Given a
const arrayWithPrefixItemsSchema: SchemaObject31 = {
  type: "array",
  prefixItems: [
    {type: "string"},
    {}
  ],
  items:
    {type: "number"},
}

According to openapi v3.1 spec, the goal of parsing prefixItems  is to generate something like:
z.tuple([z.string(), z.object()]).rest(z.number())

Currently I am doing the following:

in generateZodValidationSchemaDefinition, the array case has to be altered to adhere prefixItems constraints. If prefixItems exists,

[x] a tuple has to be pushed into functions instead of array,
[x] each prefixItem has to be parsed and nested into the tuple
[x] if items exists, a rest function has to be pushed after the tuple with the schema in items

in parseZodValidationSchemaDefinition:

[x] logic to add positional parameters to tuple
[x] logic for the rest functions has to be added

[ ] prevent .min().max() on tuple.

Awesome job @helt  if you don't mind reviewing there are a few more open Zod issues that would be a huge help if you wanted to tackle them;  https://github.com/orval-labs/orval/issues?q=is%3Aissue+is%3Aopen+label%3Azod


Refactor Config Handling (and a few other improvements)

Major restructuring to place config dictionary in each lambda function allowing for one master AWS config and one master Fleet config instead of multiple configs per step.
Also:

allow stitch/crop of images_corrected OR images_aligned with proper output folder labeling
automatically determine "channel_list" of channels analyzed in experiment and print to metadata
enable including/excluding specific plates at each step
automatically calculate number of expected files for stitching/cropping steps (4_ and 8_)
create 8Y_ to enable checking alignment on stitch/cropped images before triggering analysis

@bethac07 are you okay with me merging this branch?

I'm sorry, I forgot you were waiting for me on this! Absolutely go ahead and merge.


Use deserialize_only_snapshots and clippy fixes

This represents a pretty significant improvement for the loading times for various operations in a repository with a large number of packs and snapshots. I've looked at all uses of load_index and replaced them with load_index_snapshots where only the snapshot names or count is used.
For me, this reduces the CPU time to list from 3s down to 10ms, and the win comes from not parsing the whole index.

Just found a case where the wall clock improvement is from 35s to 35ms, so 1,000x 🎉 .


HG_Reset() / wait for completion

Currently HG_Reset() does not wait for the completion of the handle. This needs to be fixed so that if the handle is still in use, the reset is scheduled and not immediately applied.

Instead of deferring the reset operation, 284bfc0 allows users to safely reset the handle in the HG_Forward() callback and make sure the operation has completed.


replaced collections with collections.abc for inheritance

Importing directly from collection is deprecated in python 3.7 and will stop to work in python 3.8
CI tests with -W error will already fail now.
By replacing collections with collections.abc this problem will be fixed.
Addresses https://github.com/pickleshare/pickleshare/issues/27

Unfortunately it looks like collections.abc is not in Python 2.7.
We'll either need to extend the compatibility code around line 56 a bit, or make a new release explicitly Python 3 only and cut out all the compatibility code. Pickleshare needs so few changes that I'd lean towards the latter approach.

Oh, I understand, I'll change this to:
 try:     import collections.abc as collections_abc  except ImportError:   import collections as collections_abc
Once I am at home I'll add this.

Passes now, but you can safely add 3.6 and 3.7 to the test too. 3.7 ran fine on my machine.

Thanks. Do you want to add those in .travis.yml while you're working on it? They're not there just because it hasn't been touched in a couple of years.

Interesting, I think we are save if we move to xenial for >= python 3.7

Finally, we can talk about additional pypy testing ;-)
Sorry for the trial and error, I am completely new to travis.
But we should be good now for a while.

@takluyver Do you think we get this done tonight? I am not very experienced in this, a bloody beginner, sorry to ask. My trio tests fail currently and I'd be happy to work on them as soon as possible.

Yup, I think we can. Thanks!

Thank you, step by step I am getting a better overview how this works. Great help.

No problem. I probably need to put a new release on PyPI before you can easily pick it up for trio tests, but that shouldn't take long.

That would have been my next questions ;-) Enjoy your week.

And here you go, a new release: https://pypi.org/project/pickleshare/#history

Thanks @takluyver!


receptive field size

As we know that the network predicts on three feature maps (13 * 13, 26 * 26, 52 * 52), does anyone know the respective receptive field size?
I get 917, 533, 213 referring calculate receptive field of cnn  and am not sure whether is correct.

Can I ask why should we know this? Thx

If the size of the objects that you'd like to detect is bigger than the receptive field size, then you cannot detect precisely.


Use gtk/v3_22_30

Part of https://github.com/gtk-rs/examples/pull/173
cc @GuillaumeGomez, @sdroege

:+1: (just waiting for CI)

Hm, seems futures_nightly is compiles now, I try to enable it

Hm, seems futures_nightly is compiles now, I try to enable it

A miracle!

Or a bug, we're never too sure with futures... :stuck_out_tongue:

CI passed with futures_nigthly,
@sdroege, @GuillaumeGomez we merge or still use futures_stable?

I let that decision up to @sdroege. Meanwhile I merge this one. :)

Let's merge, then we notice at least once it is broken again


Typo in cuda_quant_requirements.txt

petf@git+https://github.com/huggingface/peft.git
Should be
peft@git+https://github.com/huggingface/peft.git

Thanks. Fixed.


Update Readme.md, as per #774

content copied from http://dimsemenov.com/plugins/magnific-popup/

:+1:

Belatedly realized section heading should include word "Support", otherwise it's likely the target audience won't even see the suggestion/request.


Unable to pip install

When I pip3 install --editable ., I'm getting this following error:
`              ********************************************************************************
Version '0.1.51 ' is not valid according to PEP 440.
          Please make sure to specify a valid version for your package.
          Also note that future releases of setuptools may halt the build process
          if an invalid version is given.

          This deprecation is overdue, please update your project and remove deprecated
          calls to avoid build errors in the future.

          See https://peps.python.org/pep-0440/ for details.
          ********************************************************************************`

This is likely due to a space at line 3 of pyproject.toml. The version must be version = "0.1.51" not version = "0.1.51 ". The package installs after this change.

Hey @suryachereddy sorry about that. It's an issue with the whitespace after the version number. I've just pushed a fix for this so It should be working now.


Cannot upload asset because it is too large

After 3 long hours, the upload of the assets for the new release (https://github.com/dic-iit/ify-dependencies-vcpkg/releases/tag/v0.4.0) failed because the file size is too large. See https://pipelines.actions.githubusercontent.com/VkArbTmOcLJAO2C018bn6we12UHCWlAM5DwPqLGrTkMB1F89lA/_apis/pipelines/1/runs/60/signedlogcontent/4?urlExpires=2020-06-12T10%3A23%3A38.2977877Z&urlSigningMethod=HMACV1&urlSignature=xUTMUH8KYJxGpYgr4UrCeAoSS2Lk30kFd5siFts24xs%3D
How can we proceed? @traversaro

Indeed the max size of GitHub releases is 2 GB (see https://help.github.com/en/github/managing-large-files/distributing-large-binaries), and for some reason the qt5-tools port is making the archive reach ~2.9 Gb from the existing ~0.5 Gb (See https://github.com/dic-iit/ify-dependencies-vcpkg/releases/tag/v0.3.0).
A way of reducing the size of the vcpkg archive (but I do not know if it will be effective, as the 2.9 GB size is fishy  anyway) is to  delete the .pdb  files from the directories vcpkg/installed/x64-windows/bin and  vcpkg/installed/x64-windows/debug/bin. These files are just debug symbols and source that simplify debugging, but given that we are using Windows just for deployment we can remove them.

In the  meanwhile, I started building qt5-tools locally to understand how it is possible that it is so large.

The weird thing is that the required component, Qt Linguist is supposed to be pretty small, while qt-tools includes other tools that are not necessary.

Maybe we can create two different packages :thinking:

I tried to replicate this on Windows. After downloading the dependencies, the vcpkg folder was weighing around 50GB. More than 40 were restored after deleting the buildtrees, packages and downloads folder. Now it weighs ~10GB. This is the space distribution:

Ah fak, I think I know what is going on. The tools itself are compiled with static qt, so each tool will weight a lot. As if I understood correctly we just need some CMake functions (but I may be wrong) probably we can remove most of the tools that are unused after the qt5-tools port has been installed, and then after this cleanup compress the archive. Obviously it would be ideal to first check if compilation is working correctly while deleting, to avoid accidentally deleting useful files.

Ah fak, I think I know what is going on. The tools itself are compiled with static qt, so each tool will weight a lot. As if I understood correctly we just need some CMake functions (but I may be wrong) probably we can remove most of the tools that are unused after the qt5-tools port has been installed, and then after this cleanup compress the archive. Obviously it would be ideal to first check if compilation is working correctly while deleting, to avoid accidentally deleting useful files.

I guess that those CMake functions call tools like lupdate and lrelease, but yes, with some iterations it may be possible to nail down the tools that are actually useful.

By further checking, around 5GB are in the folder qt5/debug/bin. In addition, there is something I do not understand. The executables of Qt Linguist, lupdate and lrelease are both in the folder qt5/bin and qt5-tools/bin 🤔

By further checking, around 5GB are in the folder qt5/debug/bin.

Where is that directory located? Why it is not shown in https://github.com/dic-iit/ify-dependencies-vcpkg/issues/7#issuecomment-643736195 ? What does it contain?

In addition, there is something I do not understand. The executables of Qt Linguist, lupdate and lrelease are both in the folder qt5/bin and qt5-tools/bin 🤔

This seem  a vcpkg port bug.

Where is that directory located? Why it is not shown in #7 (comment) ? What does it contain?

In the tools directory. Here I am expanding that folder

This seem a vcpkg port bug.

I checked, and those files were not there in the zip file without qt5-tools.

Most of the files seems to be .pdb , that should not there in the tools folder and can be safely removed.

Can we avoid to compile the libraries in debug? Probably we can reduce the amount of storage (and time) required

For reference, this is the content of Qt5LinguistToolsConfig.cmake

if (CMAKE_VERSION VERSION_LESS 2.8.3)
    message(FATAL_ERROR "Qt 5 requires at least CMake version 2.8.3")
endif()

get_filename_component(_qt5_linguisttools_install_prefix "${CMAKE_CURRENT_LIST_DIR}/../../../" ABSOLUTE)

macro(_qt5_LinguistTools_check_file_exists file)
    if(NOT EXISTS "${file}" )
        message(FATAL_ERROR "The package \"Qt5LinguistTools\" references the file
   \"${file}\"
but this file does not exist.  Possible reasons include:
* The file was deleted, renamed, or moved to another location.
* An install or uninstall procedure did not complete successfully.
* The installation package was faulty and contained
   \"${CMAKE_CURRENT_LIST_FILE}\"
but not all the files it references.
")
    endif()
endmacro()

if (NOT TARGET Qt5::lrelease)
    add_executable(Qt5::lrelease IMPORTED)

    set(imported_location "${_qt5_linguisttools_install_prefix}/tools/qt5-tools/bin/lrelease.exe")
    _qt5_LinguistTools_check_file_exists(${imported_location})

    set_target_properties(Qt5::lrelease PROPERTIES
        IMPORTED_LOCATION ${imported_location}
    )
endif()

if (NOT TARGET Qt5::lupdate)
    add_executable(Qt5::lupdate IMPORTED)

    set(imported_location "${_qt5_linguisttools_install_prefix}/tools/qt5-tools/bin/lupdate.exe")
    _qt5_LinguistTools_check_file_exists(${imported_location})

    set_target_properties(Qt5::lupdate PROPERTIES
        IMPORTED_LOCATION ${imported_location}
    )
endif()

if (NOT TARGET Qt5::lconvert)
    add_executable(Qt5::lconvert IMPORTED)

    set(imported_location "${_qt5_linguisttools_install_prefix}/tools/qt5-tools/bin/lconvert.exe")
    _qt5_LinguistTools_check_file_exists(${imported_location})

    set_target_properties(Qt5::lconvert PROPERTIES
        IMPORTED_LOCATION ${imported_location}
    )
endif()

set(Qt5_LRELEASE_EXECUTABLE Qt5::lrelease)
set(Qt5_LUPDATE_EXECUTABLE Qt5::lupdate)

include("${CMAKE_CURRENT_LIST_DIR}/Qt5LinguistToolsMacros.cmake")

So, in the end, only those three executables are needed. I would add also Linguist.exe such that it is possible for people to modify the translations. If there are still problem of size, a strong cut may be an option 🤔

Finally: https://github.com/dic-iit/ify-dependencies-vcpkg/releases/tag/v0.4.0 :tada: Closing this


mepo merge

A possible cli can be mepo merge <source-branch> <comp-name> [<comp-name> ...], where for the specified components, source-branch is merged into the current checked out branches.

Maybe it's best to not have mepo merge changes and have users merge changes manually (using git merge) in each component. This needs further discussions. Leaving the issue open for now.


Typo substring to isolate

Overview: What does this pull request change?

Fixes a minor documentation bug.

Motivation and Explanation: Why and how do your changes improve the library?

There was a minor typo in the documentation as explained in the issue #1917
Links to added or changed documentation pages

Example: CorrectLaTeXSubstringColoring
Further Information and Comments

Reviewer Checklist

[x] The PR title is descriptive enough for the changelog, and the PR is labeled correctly
[x] If applicable: newly added non-private functions and classes have a docstring including a short summary and a PARAMETERS section
[x] If applicable: newly added functions and classes are tested

Fixes #1917

SGTM !

Please don't forget to label PRs correctly before you are merging, @huguesdevimeux. :-)
Thanks for your contribution, @asjadaugust!

woops sorry !


Containerize the services and applications

As a [role]
I need [function]
So that [benefit]
Details and Assumptions
* [document what you know]

Acceptance Criteria
gherkin
Given [some context]
When [certain action is taken]
Then [the outcome of action is observed]

Containerize the services and applications issues


Write Down the Respective Programming Language

Description
A Statement is Given where the User  can write down the Programming they will work with thereby alerting the System Highlighter to changing it's design accordingly.
Fixes #(42)
Syntax highlighting for each supported language #42
Type of change

[ ] This change requires a documentation update
[ ] Documentation update

Hello @Subhraneel77! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file metacall_jupyter/install.py:

Line 34:8: E225 missing whitespace around operator
Line 35:21: E231 missing whitespace after ','

In the file metacall_jupyter/kernel.py:

Line 39:8: E225 missing whitespace around operator
Line 40:21: E231 missing whitespace after ','

In the file metacall_jupyter/launcher.py:

Line 23:1: W293 blank line contains whitespace
Line 25:1: W293 blank line contains whitespace
Line 29:1: W293 blank line contains whitespace
Line 29:1: W391 blank line at end of file

In the file setup.py:

Line 48:49: E261 at least two spaces before inline comment
Line 48:50: E262 inline comment should start with '# '
Line 48:80: E501 line too long (92 > 79 characters)

Your code does not solve the syntax highlighting problem. You just added a input and print. Jupyter uses codemirror under the hood: https://codemirror.net/
The idea is to make the cells look different depending on the language. For example, if we detect we are using Node, then use javascript highlighting, same for python etc.
You have here an example which is a bit different but it can help you, it's basically using codemirror in jupyter through a plugin in order to select the themes. We want something like that but per language, the theme is not important.


Calling PA_ResizeArray with an ARRAY BLOB that contains elements can crash 4D

The logic doesn't seem correct for ARRAY BLOB.

I created a pull request for a change here: https://github.com/4d/4D-Plugin-SDK/pull/31


How to visualize attention logits?

Thanks for your great job!
I have a slightly off-topic question: Could you please tell me how to visualize attention logits like Figure 2 in the paper? I want to use this method to analyze other problems.
Hopping for your reply!

Hi, have you figured out how to visualize the attention logits in the paper?


Led red/green for connection status

I think is useful to have a led that represent connected or disconnected status.

Introduced with action connect and disconnect in toolbar


chore: fix ruff TRY301

Codecov Report
Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 24.19%. Comparing base (3795ca7) to head (54a0fda).

Files
Patch %
Lines

midealocal/device.py
0.00%
5 Missing :warning:

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #134   +/-   ##
=======================================
  Coverage   24.19%   24.19%
=======================================
  Files          79       79
  Lines        6887     6887
=======================================
  Hits         1666     1666
  Misses       5221     5221

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


strip leading/trailing slashes from BSL bucket & prefix vals

Signed-off-by: Steve Kriss<EMAIL_ADDRESS>Fixes #1597

I'd propose merging this as-is assuming everything else is OK, and then tracking a followup in #1702 to update the test cases based on whatever we decide.

Rebased and updated unit tests to use builders - I think this should be good to go.


NPCs run animation on contact

If you touch NPCs, then they will have a running animation.
https://user-images.githubusercontent.com/106993968/194600058-ae5c495c-da3e-4486-8fe1-adc8866b5171.mp4

this appears to no longer be an issue


[stable/prometheus-cloudwatch-exporter] Fix documentation typos (README.md)

What this PR does / why we need it:
This PR fixes documentation typos which cause serviceMonitor resource not being created.
Which issue this PR fixes
It fixes documentation typo.
Special notes for your reviewer:
I just fixed documentation issue, compare templates/ folder (grep serviceMonitor -iR stable/prometheus-cloudwatch-exporter/templates/ folder and README.md
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[X] DCO signed
[X] Chart Version bumped
[X] Title of the PR starts with chart name (e.g. [stable/chart])

/assign @gianrubio

/assign @gianrubio

Sorry @torstenwalter but I am closing this PR and opening a new one. For some reason, I can't update this one because my forked repo doesn't exist anymore. Please refer to https://github.com/helm/charts/pull/15745 which doesn't have this VaultExporter in the helm values (because it actually doesn't belong to stable/prometheus-cloudwatch-exporter chart)


update available to lower version

For example for FBI 2.5.0 itself - it shows that there is update, but version on TitleDB is 2.4.14

Will look into it when I get the chance tomorrow.

Oh, are you talking about on the TitleDB list? That's because you have to install from TitleDB for it to update the cache with the latest CIA/3DSX ID.


Remove outdated workaround specifying package requirements

https://github.com/alan-cooney/CircuitsVis/blob/c264c944204f955245209019376190f0d9242516/python/pyproject.toml#L34
...introduced a bug-fix for compatibility with pytorch 2.1. . This breaks compatibility with pytorch 2.2. Could you remove the bugfix? See error message:
ERROR: Cannot install -r requirements.txt (line 1) and -r requirements.txt (line 8) because these package versions have conflicting dependencies.

The conflict is caused by:
    circuitsvis 1.43.2 depends on nvidia-nccl-cu12==2.18.1; platform_system == "Linux" and platform_machine == "x86_64"
    torch 2.2.2 depends on nvidia-nccl-cu12==2.19.3; platform_system == "Linux" and platform_machine == "x86_64"
    circuitsvis 1.43.2 depends on nvidia-nccl-cu12==2.18.1; platform_system == "Linux" and platform_machine == "x86_64"
    torch 2.2.1 depends on nvidia-nccl-cu12==2.19.3; platform_system == "Linux" and platform_machine == "x86_64"
    circuitsvis 1.43.2 depends on nvidia-nccl-cu12==2.18.1; platform_system == "Linux" and platform_machine == "x86_64"
    torch 2.2.0 depends on nvidia-nccl-cu12==2.19.3; platform_system == "Linux" and platform_machine == "x86_64"

Happy to accept a PR on this if you're able to make one?


Can We Recover Token From Rugged Project?

I'm submitting a ...
[x] question about the decisions made in the repository
[x] question about how to use this project

Summary
An NFT project I bought into had a token on its roadmap that is consistent with the branding. The founder rugged. I want to save the project. How can I get control of the token? Or can I delete it from the token list and create a new token, and register that with the same name? I can prove the project is rugged.

Other information (e.g. detailed explanation, stack traces, related issues, suggestions how to fix, links for us to have context, eg. StackOverflow, personal fork, etc.)

Make a new token

OK but want that name - is it possible? They are sitting dormant in founders wallet which has gambling activity and he's been AFK for 6 months.


[New Constant] half an hour in relative times

List of new constants/events

[x] half of an hour
[x] half an hour
[x] quarter after an hour
[x] two quarters before an hour
[x] quarter an hour
[x] three quarter
[x] two quarter
[x] one quarter

Example usecase
in 2 hours and quarter an hour

Because of how the absolute preposition works, this feature cannot be implemented into absolute prepositions. A new parsing method has to be created

Everything should already be implemented in dev branch. Remove branch feature/132 as it only contains old non-functional code


Multiple Compilation Context

Let's say I have the following dir structure :
- src
---myModule.js
---__tests__
-----myModule-test.js
-lib
---forTestAndRuntimeDeclarion.js
---onlyForTestDeclaration.js

myModule and myModule-test will need the definiton of the module  forTestAndRuntimeDeclariont however the module onlyForTestDeclaration should not be avaible from myModule.
I would like to be able to tell explicitly to flow which definitons is available for which modules.
Perhaps by having 2 declarations folder and 2 separate config in .flowconfig.

Thank you for reporting this issue and appreciate your patience. We've  notified the core team for an update on this issue. We're looking for a response within the next 30 days or the issue may be closed.

Is it OK if I close this issue. Seems like a hard to implement feature with very little value.


Please move wMat = numpy.array(self.wVec).reshape((nNodes, nNodes)) to construction function.

your code is js, similar.


lxd/instance/qemu: vmgenid isn't supported on aarch64

@tomponline going to merge that as soon as static analysis completes as I need it in master in order to cherry-pick into the snap so we have it on our aarch64 builders before we lose all our VM test runners

Ok thanks


Add integration testing for python CLI client

This could be done against a fake HTTP server.
Faster implementation (slower tests) could be achieved with testing against a live cluster.

This is a duplicate of https://github.com/shakenfist/shakenfist/issues/540.


Blank CORS_ORIGIN in .env does not default to false - crashes app instead.

Prerequisites

[X] I have written a descriptive issue title

[X] I have searched existing issues to ensure it has not already been reported

[X] I agree to follow the Code of Conduct that this project adheres to

API/app/plugin version
10.0.12
Node.js version
v18.15.0
Operating system
Windows
Operating system version (i.e. 20.04, 11.3, 10)
Windows 10
Description
Attempting to run the app while leaving the "CORS_ORIGN" parameter blank in .env will result in a crash in src/config/index.js
Unlike Line 186 which grabs the parameter direct from .env, Line 187 makes use of the parseCorsParameter function to parse string booleans into actual booleans.
If the value "CORS_MAX_AGE" from .env is undefined, the short circuit in Line 186 can take effect. However, a null parameter passed into the function on Line 187 will fail when attempting to evaluate the undefined, so will never make use of the subsequent short circuit
Steps to Reproduce
Run the app with "CORS_ORIGIN" left blank in .env
Expected Behaviour
No response

Accidentally marked as closed, but is only resolved in local fork.

Cheers @NHS-juju, this week I've been revisiting the plugins and routes for all my APIs, and their unit tests, and have flushed out a more few bugs.
Will take a look at the config and main server pieces of them all next week!


Integrate appveyor with code coverage

It will be cool to show the code coverage badge on our readme file! On side effect hopefully we will write less code that is not covered in tests 😄

I have start working on this in PR #22 .


strictPropertyInitialization don't works right with delegate initialization

TypeScript Version:  2.7.2
Code
class A {
    private b: number;
    private c: string;

    constructor(b: number) {
        this.b = b;
        this.initC();

    }

    private initC() {
        this.c = 'string';
    }
}

--strictNullChecks
--strictPropertyInitialization
Expected behavior:
no errors
Actual behavior:
Property 'c' has no initializer and is not definitely assigned in the constructor.
Playground Link:
https://goo.gl/uP2yKq

There are certain scenarios where properties can be initialized indirectly (perhaps by a helper method or dependency injection library), in which case you can use the new definite assignment assertion modifiers for your properties (discussed below).

@Kingwl Definite
"Assignment Assertions" is a very bad practice, and I will not use it with serious projects, because it can very easily break the code.
it can check the constructor function.
why can not it test other methods for initialization?

Looks like a duplicate of #21132


Bump version of mountpoint-s3 to v1.0.2

Description of change
Preparing to bump Mountpoint to version v1.0.2.

Relevant issues:
NA
Does this change impact existing behavior?
No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).

I understand changes should be easier to understand. But, I have some hesitation in not having description in couple of those changes as in the last release, we decided to keep it full sentence and why is it useful for customers - https://github.com/awslabs/mountpoint-s3/pull/494#discussion_r1311950336.