app_name in HTTP POST to /apps/{app}/routes ignored

Assume you have create app with name testapp and you want to create a route pinned to it:
curl -X POST -d '{"route":{"type": "sync", "path": "/hello-sync", "image": "iron/hello", "appname": "testapppp"}}' localhost:8080/v1/apps/testapp/routes
As response you get:
{"message":"Route successfully created","route":{"app_name":"testapp","path":"/hello-sync","image":"iron/hello","memory":128,"type":"sync","config":null}}
But app name in 1st command is wrong.
Solution:
drop appname from HTTP POST request body to /apps/{app}/routes

@denismakogon The route's AppName is defined as the name used in the URL param :app.
So yes, the route.AppName in the request body is just ignored.
But also, the correct field for AppName is app_name and not appname.

@pedronasser indeed, but problem still there.

@pedronasser from user perspective misleading redundancy will be confusing, don't you think so?

I agree, we should probably remove app_name from any per function things, the app is defined while executing fn commands and one function may be used in many apps, doesn't make too much sense to hard code it to a function.

Added a follow up issue with checklist to resolve this.


doc(pre-commit): add description to hooks

Description will appear in pre-commit hook page https://pre-commit.com/hooks.html

Codecov Report

Merging #153 (04e5331) into main (23b6402) will decrease coverage by 0.38%.
The diff coverage is n/a.

:exclamation: Current head 04e5331 differs from pull request most recent head 3d4dd80. Consider uploading reports for the commit 3d4dd80 to get more accurate results

@@            Coverage Diff             @@
##             main     #153      +/-   ##
==========================================
- Coverage   91.93%   91.55%   -0.39%
==========================================
  Files          29       29
  Lines        1575     1575
==========================================
- Hits         1448     1442       -6
- Misses        127      133       +6

Flag
Coverage Δ

unittests
91.55% <ø> (-0.39%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

ggshield/utils.py
96.45% <0.00%> (-2.13%)
:arrow_down:

ggshield/docker.py
96.66% <0.00%> (-1.67%)
:arrow_down:

ggshield/output/text/message.py
94.85% <0.00%> (-1.48%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ac156b...3d4dd80. Read the comment docs.


Update sbt-updates to 0.5.2

Updates com.timushev.sbt:sbt-updates from 0.5.1 to 0.5.2.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.timushev.sbt", artifactId = "sbt-updates" } ]

labels: sbt-plugin-update, semver-patch

Codecov Report

Merging #102 (272632d) into master (ad91168) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #102   +/-   ##
=======================================
  Coverage   87.13%   87.13%
=======================================
  Files          28       28
  Lines         832      832
  Branches       31       31
=======================================
  Hits          725      725
  Misses        107      107

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad91168...272632d. Read the comment docs.


lxc launch deletes already existing zfs dataset

Required information

Distribution: Ubuntu 20.04.1
Kernel version: 5.4.0-58-generic
LXC version: 4.0.6
LXD version: 4.0.6
Storage backend in use: zfs

Issue description
Running lxc launch ... <NAME> when <POLL_NAME>/containers/<NAME> already exists, fails due to dataset already exists error and then deletes this dataset. 280GB of data has been lost.
Steps to reproduce

zfs create some_pool/containers/some-storage
lxc launch ubuntu-minimal:20.04 some-storage
zfs list

some-storage will be gone.
Log:
t=2021-06-06T13:41:44+0200 lvl=info msg="Creating container" ephemeral=false instance=storage-man instanceType=container project=default
t=2021-06-06T13:41:44+0200 lvl=info msg="Created container" ephemeral=false instance=storage-man instanceType=container project=default
t=2021-06-06T13:41:46+0200 lvl=info msg="Deleting container" created=2021-06-06T13:41:44+0200 ephemeral=false instance=storage-man instanceType=container project=default used=1970-01-01T01:00:00+0100
t=2021-06-06T13:41:48+0200 lvl=info msg="Deleted container" created=2021-06-06T13:41:44+0200 ephemeral=false instance=storage-man instanceType=container project=default used=1970-01-01T01:00:00+0100

As launch command is used to create new entities it should not destroy anything already existing. It even destroyed snapshots of that dataset.

@tomponline thoughts?
Can we easily have the storage drivers return a standard error for already existing volumes which can then be picked up by the instance layer and skip the deletion step in revert?
If this is easy to do, I don't see a big downside to doing it (just slightly slower creation time). But if this requires a lot of reshuffling then I'd leave things as they are.
I believe our storage documentation already points out that LXD assumes complete control of its storage pool, so it shouldn't really be a surprise if manual actions performed by the user outside of LXD may cause data loss.
We've had cases in the past where we've needed LXD to clean up any dataset or snapshots that it didn't know about so that logic would have similarly wiped this manually created dataset.

@stgraber, you are right, it is mentioned in the documentation:

Note that LXD will assume it has full control over the ZFS pool or dataset. It is recommended to not maintain any non-LXD owned filesystem entities in a LXD zfs pool or dataset since LXD might delete them.

I didn't know about it. My fault. This deleted dataset came up when I was shuffling files during some migration. I wasn't careful enough because I didn't expect that create command can delete something.

Looking into this now, I think we can do a better/safer job here.


How to run Stanford postagger to listen to port 9000 so we can use it from NLTK?

How to run Stanford postagger to listen to port 9000 so we can use it from NLTK, without running the Java jar each time (and leave the loaded model in memory, to save time)

If I understand you correctly, you need to start CoreNLP server. Refer to https://stanfordnlp.github.io/CoreNLP/cmdline.html
Once the server is running, you can tag sequnces https://github.com/nltk/nltk/blob/develop/nltk/parse/corenlp.py#L363

Also, consider using https://github.com/stanfordnlp/python-stanford-corenlp

@dimazest,

The words "server", "port" or "9000" do not appear in the first link that you sent. It's not clear how to run a server for POS tagging, and how to specify the tagger model (e.g. english-left3words-distsim.tagger).

I am currently using the jar stanford-postagger-3.9.1.jar from here. Is it different from CoreNLP? Can what I use server as server as well?

yeah, i meant to link to the corenlp-server page, my mistake


[operator] Manage fluent-operator and vali

How to categorize this PR?

/area logging
/kind enhancement
What this PR does / why we need it:
With this PR the Gardener Operator deploys the Fluent-bit operator and the Vali.
Which issue(s) this PR fixes:
Part of #7016
Special notes for your reviewer:
To view the logs in Plutono the reviewer has to deploy Plutono:
apiVersion: apps/v1
kind: Deployment
metadata:
  name: plutono
  namespace: garden
spec:
  replicas: 1
  selector:
    matchLabels:
      component: plutono
  template:
    metadata:
      labels:
        component: plutono
        gardener.cloud/role: monitoring
        networking.gardener.cloud/to-dns: allowed
        networking.resources.gardener.cloud/to-logging-tcp-3100: allowed
        networking.resources.gardener.cloud/to-prometheus-web-tcp-9090: allowed
    spec:
      containers:
      - env:
        - name: PL_ALERTING_ENABLED
          value: "false"
        - name: PL_AUTH_ANONYMOUS_ENABLED
          value: "true"
        - name: PL_AUTH_BASIC_ENABLED
          value: "true"
        - name: PL_AUTH_DISABLE_LOGIN_FORM
          value: "false"
        - name: PL_AUTH_DISABLE_SIGNOUT_MENU
          value: "true"
        - name: PL_DATE_FORMATS_DEFAULT_TIMEZONE
          value: UTC
        - name: PL_SNAPSHOTS_EXTERNAL_ENABLED
          value: "false"
        - name: PL_USERS_VIEWERS_CAN_EDIT
          value: "true"
        image: eu.gcr.io/sap-se-gcr-k8s-public/ghcr_io/credativ/plutono@sha256:dc9eb0b56bf45ba04732e662d002bcd72aaaa96854bf7266123112a8b75c66f7
        imagePullPolicy: IfNotPresent
        name: plutono
        ports:
        - containerPort: 3000
          name: web
          protocol: TCP
        resources:
          limits:
            memory: 400Mi
          requests:
            cpu: 10m
            memory: 32Mi
        volumeMounts:
        - mountPath: /var/lib/plutono
          name: plutono-storage
        - mountPath: /etc/plutono/provisioning/datasources
          name: plutono-datasources
      tolerations:
      - effect: NoExecute
        key: node.kubernetes.io/not-ready
        operator: Exists
        tolerationSeconds: 60
      - effect: NoExecute
        key: node.kubernetes.io/unreachable
        operator: Exists
        tolerationSeconds: 60
      volumes:
      - emptyDir:
          sizeLimit: 100Mi
        name: plutono-storage
      - configMap:
          defaultMode: 420
          name: plutono-datasources
        name: plutono-datasources

apiVersion: v1
data:
  datasources.yaml: |-
    # config file version
    apiVersion: 1

    # list of datasources to insert/update depending
    # whats available in the database
    datasources:
    - name: vali
      type: vali
      access: proxy
      url: http://logging.garden.svc:3100
      jsonData:
        maxLines: 5000
kind: ConfigMap
metadata:
  labels:
    component: plutono
  name: plutono-datasources
  namespace: garden

Release note:

`gardener-operator` now takes over management of `fluent-operator` and `vali`.

/assign

/retest

@timuthy and myself will take over this PR and get it ready for the merge.

We could add an ObservabilityComponents condition to garden-care controller too.

We could add an ObservabilityComponents condition to garden-care controller too.

Yes, I added an item to #7016.

/lgtm
/approve


Using with obj-c or somehow as React Native turbo module

Hi, Im not an iOS dev.
Im currently working on Turbo Native Module for React Native and as far as i know there is no way to made it in Swift due to JSI architecture features.
So i need to do it in obj-c++.
Can someone explain how should i implement this with obj-c++ or is this even possible?
Just creating a mnemonic for example (i'm not really into obj-c++)
Or can u left some links for alternatives intended to work with obj-c++

You can try: https://developer.apple.com/documentation/swift/importing-swift-into-objective-c

It doesn't make any sense because turbo module isn't Xcode project and so it can't generate any swift header file by Xcode.
And anything around Xcode. All I have its vscode and obj-c module
So there is no alternatives for web3 in obj-c?

It doesn't make any sense because turbo module isn't Xcode project and so it can't generate any swift header file by Xcode. And anything around Xcode. All I have its vscode and obj-c module
So there is no alternatives for web3 in obj-c?

Well not this lib because it's called web3swift for a reason. Personally, I don't know about any alternatives.


Introduce pre transfer leader

What have you changed?
This is an implement of tikv/rfcs#37.
The implement reuses TransferLeader message of raft to avoid introduce extra
proto message. Note that we don't send TransferLeader message to the network
before, hence the message can only be sent out from a new leader/follower.
If an old follower receives the message, it will just redirect back to the leader,
which will ignore the message as it has an invalid index.
What is the type of the changes?

New feature

How is the PR tested?

Integration test

Does this PR affect documentation (docs) or should it be mentioned in the release notes?
No.
Does this PR affect tidb-ansible?
No.
Refer to a related PR or issue link
tikv/rfcs#37

/bench +ycsb
workload:
  workload: workloada
  mode: raw

@BusyJay I believe this PR caused BR tests to almost always fail with "not leader" error (example: https://internal.pingcap.net/idc-jenkins/blue/organizations/jenkins/br_ghpr_unit_and_integration_test/detail/br_ghpr_unit_and_integration_test/750/pipeline, search for "not leader"). Is there something we need to update in BR or TiDB or PD? cc @overvenus


[dart2js] co19/Language/Classes/Instance_Methods/Method_noSuchMethod/definition_A01_t01 runtime failure

The following test fails in dart2js and ddc
import "../../../../Utils/expect.dart";

class C1 {
  int m();
  void noSuchMethod(Invocation i) {}
}

main() {
  Expect.throws(() { // Fails here. No expected error is thrown
    C1().m();
  });
}

Call of C1.m() is call of noSuchMethod forwarder which returns void instead of int. So there should be type error

This fail in unsound mode. Ok, no error, sorry


Continuous point cloud retrieval

Hi,
Working with the LMS511-10100 scanner, I managed to get the "sick_scan_xd_api_test" tool to work successfully. I was able to retrieve a CSV file containing the data, but I noticed that it only contains data from the first frame, i.e. a single measurement of the scanned object. At the moment, I want to perform continuous acquisitions and I wonder if anyone has an idea for solving this problem.
Thank you for your help.

Every time the callback apiTestCartesianPointCloudMsgCallback in "sick_scan_xd_api_test" is executed, you will receive a message with new scan data. You can see this e.g. in your screenshot https://user-images.githubusercontent.com/103991360/249077637-049f184f-93b0-4837-8a11-dc575ab45e26.png : Each message provides a new scan. If you convert each message into csv, you should continously retrieve the scans from your lidar. Remember to append the data, default file operation might be to overwrite.

Hi,
you mean I have to put the coordinate printing part here inside :

Thank you for your help.

Hi,
you are right. Use callback apiTestCartesianPointCloudMsgCallback to convert and append the scan data to a csv file. You can replace or modify function plotPointcloudToJpeg to plot the scan data to csv instead of jpg.

Hi,
good morning;
Thank you for your feedback. I have understood and carried what you advised, but unfortunately I can't see any difference.
here are the changes made :
printPointcloudToCSV.txt
here the call to the printPointcloudToCSV function :

Thank you for your help.

Hi,
line 24 opens the csv-file in write modus, i.e. the csv-file will be cleared and overwritten for each call:
FILE* foutCsv = fopen(csvFileNameTmp.c_str(), "w"); // open csv file

Open the csv-file in append mode instead:
FILE* foutCsv = fopen(csvFileNameTmp.c_str(), "a"); // open csv file to append scan data

Alternatively, you can create a csv-file with a different filename for each scan.

Hi,
that's great, thank you very much.
have a nice day


Error when building the official image:  x509: certificate signed by unknown authority

docker build -t oreng/iojs .
INFO[0000] Get https://index.docker.io/v1/repositories/library/iojs/images: x509: certificate signed by unknown authority.

Here is my Dockerfile:
FROM iojs:latest
RUN useradd -ms /bin/bash developer
WORKDIR /home/developer
USER developer

@oren, which version of Docker are you using?
I just tried to reproduce the issue using Docker version 1.5.0, build a8a31ef
Dockerfile:
FROM iojs:latest
RUN useradd -ms /bin/bash developer
WORKDIR /home/developer
USER developer

And the build command:
[~/tmp/test]$ docker build -t rosskukulinski/iojs .
Sending build context to Docker daemon 2.048 kB
Sending build context to Docker daemon
Step 0 : FROM iojs:latest
 ---> 3496be7b2088
Step 1 : RUN useradd -ms /bin/bash developer
 ---> Running in c16ef875ddf7
 ---> 1b55659b3299
Removing intermediate container c16ef875ddf7
Step 2 : WORKDIR /home/developer
 ---> Running in 874caaa7b8f9
 ---> 309bc5cd73a5
Removing intermediate container 874caaa7b8f9
Step 3 : USER developer
 ---> Running in b71e2abbfb2c
 ---> b8246a741850
Removing intermediate container b71e2abbfb2c
Successfully built b8246a741850

I also don't see the error when I use the --pull flag for docker build:
docker build --pull -t rosskukulinski/iojs .

docker version
Client version: 1.5.0
Client API version: 1.17
Go version (client): go1.4.1
Git commit (client): a8a31ef
OS/Arch (client): linux/amd64
Server version: 1.5.0
Server API version: 1.17
Go version (server): go1.4.1
Git commit (server): a8a31ef

docker info
Containers: 0
Images: 794
Storage Driver: aufs
 Root Dir: /var/lib/docker/aufs
 Backing Filesystem: extfs
 Dirs: 794
Execution Driver: native-0.2
Kernel Version: 3.16.0-31-generic
Operating System: Ubuntu 14.10
CPUs: 4
Total Memory: 7.68 GiB
Name: oren
ID: KF2M:UGKG:QTGT:TYXH:P6QQ:QVSI:5AYE:T5I3:KLEA:QCKN:7XUW:3FOG
Username: ogolan
Registry: [https://index.docker.io/v1/]
WARNING: No swap limit support

Also hub create (using https://github.com/github/hub) gives me similar error:
Post https://api.github.com/user/repos: x509: certificate signed by unknown authority

is there a problem with my laptop? I am on ubuntu 14.10

I'm on Ubuntu 14.04 with Docker v1.0 through v1.5 and have never experienced a similar issue with io.js docker image, nor any other image on the Docker Registry for that sake.
Could you apt-get update -y && apt-get install -y ca-certificates and try again just to make sure you are up to date with a up to date certificate root store? :grinning:

apt-get update -y
W: Failed to fetch https://deb.nodesource.com/node/dists/utopic/main/source/Sources  server certificate verification failed. CAfile: /etc/ssl/certs/ca-certificates.crt CRLfile: none

that's odd.  I'm wondering if there's something up with NodeSource's nodejs installer script.  CC: @rvagg

@oren Maybe docker/docker#6474 is of any help?

I rm /etc/apt/sources.list.d/nodesource.list*
and now i get:
W: Failed to fetch https://get.docker.com/ubuntu/dists/docker/main/binary-amd64/Packages  server certificate verification failed. CAfile: /etc/ssl/certs/ca-certificates.crt CRLfile: none

I am closing this issue since we are talking about it here - https://github.com/docker/docker/issues/6474


Update Set-PnPTenantSite.md

Added -DisableSharingForNonOwners to documentation
Type

[ ] Bug Fix
[ ] New Feature
[ ] Sample
[X] Documentation

What is in this Pull Request ?
Simple change to the documentation - copied content from the same thing in Set-PnPSite

Thanks @paylord , have merged this.
Much appreciated 😊🙏

@gautamdsheth awesome thanks - a long time user but first time to contribute so glad I did not break anything - even with a comment :)


Using Windows' MSBuild for .NET Framework from WSL breaks Predefined System.* and Package References

I'm not even sure if this is an issue that could be solved with the plugin, but after hours of research, I'm kind of stumped. I know I'm being a stubborn bonehead with a niche and silly use case, but I'm too far in to give up now.
Unfortunately, I have to work with .NET Framework, which limits my options quite a bit in Linux land (albeit, through WSL, so I can leverage the underlying Windows install).
Until yesterday, I was able to use mono to run unit tests fine, however, for some god forsaken reason, Microsoft's .NET Framework implementation of their Azure SDK relies on a library that resides in ntdll.dll, so I was left with two choices - rewrite the tiny bit of code (currently tiny) that interfaces with Azure using a Http client with my own implementation (bit silly) or just build the solution and projects using the underlying windows version of dotnet.exe, I chose the latter.
Everything builds and even runs fine, but Roslyn does not like what is generated one bit:

Found a solution for my specific use case - just used .NET 8 for my unit tests project, kept the libraries to be tested as .NET Framework 4.6.2 and switched to xUnit.v3, surprisingly, it all works and Roslyn has no issues with it.

Okay, I think I am going to close this issue then :)


Mentions of non-existing page "Stock Put-Aways" in Walkthrough: Receiving and Putting Away in Basic Warehouse Configurations

This article refers to a page called "Stock Put-Aways", which cannot be found in current GB BC, and for which there are no results in the root folder of the current BC GB 19.1 codebase.
Presumably it should be something else? Please update so that readers finding this guide can actually use it. Thanks ;-)

Document details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: fcd58190-a7af-5bad-48a2-f79fdc89e666
Version Independent ID: 5c32818d-e08b-8b2d-411f-92bebbd429e1
Content: Walkthrough - Receive and put away in basic warehouse configurations - Business Central
Content Source: business-central/walkthrough-receiving-and-putting-away-in-basic-warehousing.md
Service: dynamics365-business-central
GitHub Login: @SorenGP
Microsoft Alias: edupont

Hello,
Thank you for your feedback! This appears to be a flaw in our translation from English (US) to English (UK). As you can see in our US version, the name of the page was changed to Inventory Put-Away a long time ago: https://docs.microsoft.com/en-us/dynamics365/business-central/walkthrough-receiving-and-putting-away-in-basic-warehousing#about-this-walkthrough
I'll ask our translators to change the term in the next round of translations that starts next week.

Thanks :)

This has been fixed in the latest update for English (UK): https://docs.microsoft.com/en-gb/dynamics365/business-central/walkthrough-receiving-and-putting-away-in-basic-warehousing


Uber And Google Play

Add Uber Logo and Google Play logos
Uber has many other logos but this one is the most minimal

Those are great. Let's add some things:

In your opening <svg> tag, add viewBox="0 0 512 512" to set the display size.
In the same place, add aria-label="Uber or Google Play" role="img" for accessibility reasons.
For radius.html to work, we use a <rect> with the rx="15%" rounded corners property as a default background. So you can replace <path fill-rule="evenodd" d="M-1.304 1.644h512v512h-512z"/> with <rect width="512" height="512" rx="15%"/>

After that, I think Edent will approve and merge.

Fixed in #97


Unnecessary line in Dockerfile halts installation

It's duplicate (already in test_requirements.txt) and breaks Dockerfile installation because of that.

Coverage remained the same at 55.3% when pulling 16937a05a89dba5705595df6222c76d771903bc8 on Mikadily:patch-1 into cbdd554c3463e8b32d5344eafe2da71770f8f529 on OpenBazaar:master.

not enough also RUN make needs to be remove, to reach successfully the end
This is the working Dockerfile for me https://github.com/grigio/docker-apps/blob/master/openbazaar-server/Dockerfile

I guess it depends on the kernel... it works with 'RUN make' on DigitalOcean

@Mikadily It's weird, because if you see the Makefile the check depends on
https://github.com/OpenBazaar/OpenBazaar-Server/blob/master/Makefile#L11 which depend on
https://github.com/OpenBazaar/OpenBazaar-Server/blob/master/scripts/pycheck.sh#L4
So the solution is to fix the pylint errors or remove both


build: fix files spec in package.json for query, cucumber-expressions

Before:

After:

Seems likely that npm7 has different handling of files (specifically of "*" in relation to what's gitignored), though I can't find documentation to prove that.
The lone index.js making its way in was perhaps because of the reference to it in the main field.

That's odd - good find!
I wonder if we might have to re-release some other modules released earlier this week too then. I'll have a look.

@aslakhellesoy looking now as well. There are no issues at least with any of the other packages that cucumber-js imports (if I manually patch query, all our tests pass).

It looks like the only modules that declare files are @cucumber/query and @cucumber/cucumber-expressions. The others don't declare it at all (and seem to include the right files).
So perhaps a better fix is to remove the files declaration?

I think it's best to only include files in the package that consuming projects use/need - by not doing anything we include lots of stuff like tests, test data, github config, makefiles etc that bloats the package.
We could maybe address that more broadly in another PR though? Happy to change to just omit files for consistency today - let me know.

I think it's best to only include files in the package that consuming projects use/need - by not doing anything we include lots of stuff like tests, test data, github config, makefiles etc that bloats the package and gets unnecessarily indexed by IDEs.

Yes, completely agree. Let's handle that in a separate PR.


YouTube returned no videos for the search query "Alan Walker - The Spectre lyrics".

ERROR:spotdl.command_line.core:351:
YouTube returned no videos for the search query "Alan Walker - The Spectre lyrics".
Hi, I try to download a song, but it give an error.What's wrong with this, please?

Same issue

Another error:
Exception in thread Thread-1:
Traceback (most recent call last):
File "/usr/local/lib/python3.6/site-packages/spotdl/metadata/providers/youtube.py", line 421, in from_url
content = pytube.YouTube(url)
File "/usr/local/lib/python3.6/site-packages/pytube/main.py", line 91, in init
self.prefetch()
File "/usr/local/lib/python3.6/site-packages/pytube/main.py", line 183, in prefetch
self.js_url = extract.js_url(self.watch_html)
File "/usr/local/lib/python3.6/site-packages/pytube/extract.py", line 143, in js_url
base_js = get_ytplayer_config(html)["assets"]["js"]
KeyError: 'assets'

Error in 3.1.0
Traceback (most recent call last):
File "/usr/local/bin/spotdl", line 11, in
load_entry_point('spotdl==3.1.0', 'console_scripts', 'spotdl')()
File "/usr/local/lib/python3.6/site-packages/spotdl/main.py", line 100, in console_entry_point
downloader.download_single_song(song)
File "/usr/local/lib/python3.6/site-packages/spotdl/download/downloader.py", line 274, in download_single_song
download_song(songObj, self.displayManager, self.downloadTracker)
File "/usr/local/lib/python3.6/site-packages/spotdl/download/downloader.py", line 104, in download_song
on_progress_callback = displayManager.pytube_progress_hook
File "/usr/local/lib/python3.6/site-packages/pytube/main.py", line 91, in init
self.prefetch()
File "/usr/local/lib/python3.6/site-packages/pytube/main.py", line 183, in prefetch
self.js_url = extract.js_url(self.watch_html)
File "/usr/local/lib/python3.6/site-packages/pytube/extract.py", line 143, in js_url
base_js = get_ytplayer_config(html)["assets"]["js"]
KeyError: 'assets'

Having the same issue. v2 is broken and so is v3 now

As to the 'assets' error. ITs a pytube3 problem and there really isn't a fix from our side. Please see this. It would also help fi you searched existing issues before opening new ones.

ERROR:spotdl.command_line.core:351:
YouTube returned no videos for the search query "Alan Walker - The Spectre lyrics".
Hi, I try to download a song, but it give an error.What's wrong with this, please?

I'm assuming that your using v3. v3 passes the search query to spotify and not youtube. Spotify can't/won't match 'lyrics' and hence returns no results. Try running spotdl "Alan Walker Spectre" instead


Create a collapsible/expandable GSN diagram

A new intention has been created for Goal Structure to create a collapsible/expandable GSN diagram in an external window.
The implementation code can be found in 2 newly created classes.

this can be improved in the following ways:

support undeveloped goals

auto-resize of boxes

possibility to expand all / collapse all
search for a text and highlighting the corresponding model element
connect / jump to the goal/solution/... definition

for now, lgtm


Process to allow core contributors to release

I'm curious how you do releases with climpred @aaronspring @bradyrx.
Ideally I would like you both to have the freedom to release but I believe it's currently tied to my pypi account. Curious how people/projects get around this?
Guess xskillscore could get moved to xskillscore-dev/xskillscore - still not sure how releases work in those kinds of repos.
I believe you can do releases via a GitHub action but I think you would still need a password.
I believe GitHub has a way to store passwords via secrets https://docs.github.com/en/actions/configuring-and-managing-workflows/creating-and-storing-encrypted-secrets which prevent users from seeing the password yet still allow it to be used?

as we are an xarray wrapper, we could ask to get into https://github.com/xarray-contrib. @bradyrx is handling all the release pypi stuff for climpred

I just added @aaronspring as a "contributor" to both PyPI and readthedocs. I think on conda-forge you can also add people as official contributors to the mean README. We could try adding all our names there and see if it allows us to add tags to this main repo and do the full release process.

Cool. Wasn't aware of those. Added you both to PyPi and rtd. You are both already on conda-forge https://github.com/conda-forge/xskillscore-feedstock/blob/master/recipe/meta.yaml#L43


v3.1.1 contains breaking changes

https://github.com/go-irc/irc/commit/f252a88c7bbe6d60a27cc66f1a8b8211ab9aaab5 is a breaking change. This breaks builds.

I’m unsure what the best path forward would be here. As, unlike most other package systems, you cannot revoke versions. Optimally I think I would have revoked 3.0.0 as it had numerics I don’t want to support in there. I’ll have to take a closer look when I’m at a computer.

I’d be fine releasing a new major version, but then I’d want to fix the issue with hanging and potentially change the method signature of a few functions as well.

I think a reasonable path forward would be to un-do the breaking changes with a bugfix version, then prepare a new major version with all the breaking changes. This would allow existing users to upgrade safely.

I've added back sections for obsolete RFC1459 and RFC2812 commands. I believe these are the 16 that were removed in the previous commit. I've tagged it v3.1.2. Next breaking change will probably be fixes for the Client.
Thanks for mentioning this!

Thanks!


Support multiple media per layer

It would be good to have some kind of "playlist" for media. This could be easily(?) implemented by using an array of objects for each layer.
When the first object of the array finishes playback, the next object is started automatically.

You can of course have multiple "layers", each of which is active for the appropriate window of time. (Inactive layers shouldn't actually take any display planes or anything.) Of course you need to know the media length to do that.
In design, I'd been resisting adding "convenience" features to the script format in the service of simplicity, but I've heard other people wanting "once this video is done, do that other thing" (where "do that other thing" is often playing a different video). Of course you can query the info on the video length and set that all up in code... but that's work.
So maybe giving in a little bit and allowing the media to be a list (internally expanding to the separate layers with time windows, probably) would be a worthwhile concession. That does mean querying the media at script load time, but that does get cached.

Are these layer hardware planes in terms of KMS? In this case, using multiple layers could be problematic as the number of planes is limited.
Alternatively a bi-directional interface for external programs might be another way to do this, e.g. informing the external process that a video is about to finish.

A KMS plane will only get used when any given layer is active (they're dynamically assigned as each frame is "built") so the various extra layers are no problem as long as only one is active at a time. (Or two at a time, if you want to overlap them a bit to create crossfade effects or something...)

Understood. Does this also mean if 2 videos don't overlap, they might be rendered on the same DRM/KMS plane? That's would be pretty cool.

Correct. Every frame, pivid assigns DRM/KMS planes from the start for whatever layers are active that frame, in layer order. (Skipping planes that are in use by some other display, if multiple displays are active, since multiple displays flip at different times.)


python310Packages.yappi: 1.3.5 -> 1.3.6

Description of changes
https://github.com/sumerc/yappi/releases/tag/1.3.6

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 185978 run on x86_64-linux 1

3 packages built:

python310Packages.yappi
python39Packages.yappi
tribler

Result of nixpkgs-review pr 185978 run on x86_64-darwin 1

2 packages built:

python310Packages.yappi
python39Packages.yappi


Add storage account protection techniques

[x] Enable soft delete for blobs
[x] Enable soft delete for containers
[ ] Enable point-in-time restore for containers
[ ] Enable operational backup with Azure Backup

The capabilities have been added also to LZ: https://github.com/Azure/caf-terraform-landingzones/commit/ff4acb9e8d3f047e3ca58ddb28ecec95761c9b30

Closing as implemented


change "top images" text on home page to

"Staff picked" or similar

Actually change to "Staff picks"

@janeatcc, it seems odd to call it Staff picks. I think top pics makes sense, maybe we should base more on images with have the most likes from the providers.

Oh I like "top picks" -- that works.
On Mon, Oct 15, 2018 at 6:56 AM, Steven B<EMAIL_ADDRESS>wrote:

@janeatcc https://github.com/janeatcc, it seems odd to call it Staff
picks. I think top pics makes sense, maybe we should base more on images
with have the most likes from the providers.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/creativecommons/cccatalog-frontend/issues/111#issuecomment-429862317,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGGTmYTPbEgPcwZGzoEi0zt4T22TauS6ks5ulJQhgaJpZM4XaHyF
.

--
Jane Park
Director of Product & Research
@CreativeCommons
@janedaily
Get updates: https://us.e-activist.com/page/6747/subscribe/1
https://creativecommons.org/about/contact/newsletter/
Invest in the commons: https://donate.creativecommons.org/


Neural style transfer using tensorflow

💥 Proposal
This project combines the content of one image with the artistic style of another image, creating a new image that preserves the content while adopting the style. I will use a pre-trained convolutional neural network to extract features and optimize the generated image to minimize content and style differences.

Kindly assign it to me

Hi, please link the dataset.

I have not used any dataset for this project. VGG-19, a 19-layer version of the VGG network has been used in this project. This model has already been trained on the very large ImageNet database and has learned to recognize a variety of low-level features (at the shallower layers) and high-level features (at the deeper layers).
In this project, I have :

Implemented the neural style transfer algorithm
Generated novel artistic images using your algorithm
Define the style cost function for Neural Style Transfer
Define the content cost function for Neural Style Transfer

@lakshmishreea122003  - you can go ahead! We are assigning you 21 days for this project, after which it will be assigned to someone else if not completed. All the best!
Name the file as: algorithm.ipynb and link it in the readme of the labeled directory as algorithm.


Need a different name for package

This repo should use a different name from matlab_kernel so that it doesn't conflict with the Calysto package.

I don't think the two packages really overlap in usage, and as I argued in https://github.com/Calysto/matlab_kernel/pull/72 I think this package is closer to a vanilla MATLAB kernel anyway.

@dsblank I came back on my decision.  This project (and kernel name) is now known as imatlab.
I allowed myself to take over that name in the ipython wiki list of kernels (https://github.com/ipython/ipython/wiki/IPython-kernels-for-other-languages), given that the metakernel MATLAB Kernel doesn't refer to itself as "imatlab" anywhere at that point.

Thanks!


token based fees

https://github.com/alcueca/erc7399/blob/56ba9dfdee8ad34150bc77de2bb67c950a1bb415/src/FlashLender.sol#L14
idk if it's too much of an implementation detail for the EIP, but you could offer token-based fees (instead of one fee for all tokens) by having this supportedTokens mapping be a mapping of address --> SupportedToken struct.  If a uint type less than 256 bits is chosen, then both would fit in a single word which could be read by a single SLOAD.
struct SupportedToken {
  bool enabled;
  uint128 fee;
}

It is difficult to make a reference implementation that is complex enough to show the features, but simple enough to be understood.
I think it is ok to have fee-per-token in the reference implementation. I did it so that there are 29 bytes left for other token-specific data.


Starting Kubelet Kills Other Kube* services and vice-versa

Environment: CoreOS - Alpha - Build 681
Kubernetes: 0.17.0
Problem:
Trying to start kube-kubelet is ending up killing other kube* services. Starting other kube-* services is in turn is killing kubelet.
Here is the running environment:
wwserver194 coreos-install # systemctl | grep kube
  kube-apiserver.service                                                                           loaded active running   Kubernetes API Server
  kube-controller-manager.service                                                                  loaded active running   Kubernetes Controller Manager
● kube-kubelet.service                                                                             loaded failed failed    Kubernetes Kubelet
  kube-proxy.service                                                                               loaded active running   Kubernetes Proxy
  kube-scheduler.service                                                                           loaded active running   Kubernetes Scheduler
wwserver194 coreos-install #

Now, let's go ahead and start kube-kubelet:
wwserver194 coreos-install # systemctl start kube-kubelet

Let's go ahead and display the status of other kube-* services:
wwserver194 coreos-install # systemctl | grep kube
● kube-apiserver.service                                                                           loaded failed failed    Kubernetes API Server
● kube-controller-manager.service                                                                  loaded failed failed    Kubernetes Controller Manager
  kube-kubelet.service                                                                             loaded active running   Kubernetes Kubelet
● kube-proxy.service                                                                               loaded failed failed    Kubernetes Proxy
● kube-scheduler.service                                                                           loaded failed failed    Kubernetes Scheduler
wwserver194 coreos-install #

As you can see, other services immediately died, following kube-kubelet startup.
Let's display journal entries for kube-apiserver:
-- Logs begin at Fri 2015-05-15 23:21:32 UTC, end at Mon 2015-05-18 13:42:05 UTC. --
May 18 13:40:00 wwserver194.alphalocal.net systemd[1]: kube-apiserver.service failed.
May 18 13:40:00 wwserver194.alphalocal.net systemd[1]: Unit kube-apiserver.service entered failed state.
May 18 13:40:00 wwserver194.alphalocal.net systemd[1]: Stopped Kubernetes API Server.
May 18 13:40:00 wwserver194.alphalocal.net systemd[1]: kube-apiserver.service: main process exited, code=exited, status=2/INVALIDARGUMENT
May 18 13:40:00 wwserver194.alphalocal.net systemd[1]: Stopping Kubernetes API Server...
May 18 13:39:57 wwserver194.alphalocal.net kube-apiserver[18190]: E0518 13:39:57.882748   18190 controller.go:92] unable to sync kubernetes service: endpoints "kubernetes" cannot be updated: the resource
May 18 13:39:37 wwserver194.alphalocal.net kube-apiserver[18190]: E0518 13:39:37.474062   18190 controller.go:92] unable to sync kubernetes service: endpoints "kubernetes" cannot be updated: the resource
May 18 13:39:27 wwserver194.alphalocal.net kube-apiserver[18190]: E0518 13:39:27.310878   18190 controller.go:92] unable to sync kubernetes service: endpoints "kubernetes" cannot be updated: the resource
May 18 13:39:17 wwserver194.alphalocal.net kube-apiserver[18190]: E0518 13:39:17.557793   18190 controller.go:121] unable to sync kubernetes RO service: endpoints "kubernetes-ro" cannot be updated: the r
May 18 13:39:07 wwserver194.alphalocal.net kube-apiserver[18190]: E0518 13:39:07.412581   18190 controller.go:121] unable to sync kubernetes RO service: endpoints "kubernetes-ro" cannot be updated: the r
May 18 13:38:57 wwserver194.alphalocal.net kube-apiserver[18190]: E0518 13:38:57.144871   18190 controller.go:121] unable to sync kubernetes RO service: endpoints "kubernetes-ro" cannot be updated: the r
May 18 13:38:46 wwserver194.alphalocal.net kube-apiserver[18190]: E0518 13:38:46.732264   18190 controller.go:121] unable to sync kubernetes RO service: endpoints "kubernetes-ro" cannot be updated: the r
May 18 13:38:36 wwserver194.alphalocal.net kube-apiserver[18190]: E0518 13:38:36.547715   18190 controller.go:121] unable to sync kubernetes RO service: endpoints "kubernetes-ro" cannot be updated: the r
May 18 13:36:23 wwserver194.alphalocal.net kube-apiserver[18190]: I0518 13:36:23.831398   18190 server.go:418] Using self-signed cert (/var/run/kubernetes/apiserver.crt, /var/run/kubernetes/apiserver.key
May 18 13:36:22 wwserver194.alphalocal.net kube-apiserver[18190]: I0518 13:36:22.728066   18190 server.go:436] Serving insecurely on <IP_ADDRESS>:8080
May 18 13:36:22 wwserver194.alphalocal.net kube-apiserver[18190]: I0518 13:36:22.728057   18190 server.go:408] Serving securely on <IP_ADDRESS>:6443
May 18 13:36:22 wwserver194.alphalocal.net kube-apiserver[18190]: I0518 13:36:22.728024   18190 server.go:371] Serving read-only insecurely on <IP_ADDRESS>:7080
May 18 13:36:21 wwserver194.alphalocal.net kube-apiserver[18190]: [restful] 2015/05/18 13:36:21 log.go:30: [restful/swagger] https://<IP_ADDRESS>:6443/swaggerui/ is mapped to folder /swagger-ui/
May 18 13:36:21 wwserver194.alphalocal.net kube-apiserver[18190]: [restful] 2015/05/18 13:36:21 log.go:30: [restful/swagger] listing is available at https://<IP_ADDRESS>:6443/swaggerapi/
May 18 13:36:21 wwserver194.alphalocal.net kube-apiserver[18190]: I0518 13:36:21.884481   18190 plugins.go:69] No cloud provider specified.
May 18 13:36:21 wwserver194.alphalocal.net wget[18180]: Server file no newer than local file '/opt/bin/kubectl' -- not retrieving.
May 18 13:36:21 wwserver194.alphalocal.net wget[18180]: Length: 20077224 (19M) [application/octet-stream]
May 18 13:36:21 wwserver194.alphalocal.net systemd[1]: Started Kubernetes API Server.
May 18 13:36:21 wwserver194.alphalocal.net wget[18180]: HTTP request sent, awaiting response... 200 OK
May 18 13:36:21 wwserver194.alphalocal.net wget[18180]: Connecting to storage.googleapis.com|<IP_ADDRESS>|:443... connected.

 Any clues? I think I might have misconfigured something, but I can't seem to pin-point it.
Thanks!!
Alex

Hmm the master components are now run as containers. I wonder if that has broken any older setups.
@kelseyhightower any ideas?

/cc @dchen1107 in case something jumps out at you.

Whoa! "master components are now run as containers"  So all kube-* services recommended to be run as containers??

@akamalov I think you found the root reason. In v0.14, all master components are running as native processes on master node. Since v0.16, all master components are running as container in a pod. Detail can be found at #5011. During upgrade from v0.14 to v0.16+, previous running master services are killed, and restarted through kubelet / docker. Now kubelet and kube-proxy are still running as native service.

@dchen1107  Thanks so much for your reply Dawn.Any documentation been published around this implementation, if you know ?
Thanks again!!
Alex


Why the SN74HC245N is needed to read the ROM?

Hi,
nice video and fork you have here ;-)
I was confused why the SN74HC245N is needed to read the rom? Can you tell me why? (I really do not know. I was trying to read direct and I coudn't, and I cannot understand why since PICO GPIOs are 5v tolerants)
I thought it was just change the data pins from output to input, but it seems this do not work.
Thanks in advance,
Fábio

Sorry for the delay in responding to your issue. Although many Pico users have had success using 5V logic directly with GPIO without the use of level shifters, it is technically out of spec with the MCU's capabilities and not recommended for long-term deployments. If you are temporarily experimenting with this project, it is likely okay to test EEPROM reading capabilities directly with the GPIO of the RP2040, but don't take that as a recommendation in any way and you do run the risk of damaging your device. Most projects similar to this one (ie: RP2040-based rom carts, vintage computer peripherals, etc) utilize 5V level shifters for the same reasons.
5V TTL logic on the other hand is tolerant to 3.3V input. This is why the control signals are handled directly by the RP2040's GPIO and only the data bus requires a level shifter.


archive_cleanup: new tool to delete orphan XLOGs from object storage

I'd love to see this get merged sooner rather than later!


x/website: install from source doesn't exist

https://golang.org/doc/install-source.html (linked from https://golang.org/doc/install) shows the following error:
open REDACTED: file does not exist

CC @golang/release

(More evidence for #37047?)

This was missed in a recent refactor in CL 296383. We need to add a redirect from the old path at _content/doc/install/source.html:
<!--{
	"Redirect": "/doc/install/source"
}-->

#37047 is going to be more helpful for x/website now that it's going though larger refactors. CC @rsc.


Name of token

Hi,
Is there a naming rule for token symbol?
We want to add the second version token with a new contract address to imToken and keep the old one. We want to use ‘SPC V2’ or ‘SPC_V2’ as token symbol, is it possible?
Thanks.

It depends on the name you created the contract.


Remove OpenShift 4.4 version

per https://issues.redhat.com/browse/MGMT-961

It's still supported in swagger, anyway. @filanov


"Usage data" causes a crash

Selecting "Usage Data" from the main menu causes the Tatin server to crash

It crashes as long as there is only data from January available for the current year.

Fixed in 0.89.1


1.17.2 is using envoy from Istio's org

Is this the right place to submit this?

[X] This is not a security vulnerability or a crashing bug
[X] This is not a question about how to use Istio

Bug Description
We are on the path of upgrading Istio to 1.17.2 and made this observation.
1.17.2 uses envoy from Istio's org but the rest of all past and future versions use envoy from envoy proxy org.
https://github.com/istio/proxy/blob/1.17.2/WORKSPACE#L39-L45
Also, we see the checks have failed for the release

Another thing that was concerning to us was Istio envoy mentioned that "it's used for testing and dev process" not sure how this got into the release.

Can someone please clarify if 1.17.2 which contains an envoy from Istio org is stable to use?
Version
Istio 1.17.2
K8s 1.23.17

istioctl version
client version: 1.17.2
control plane version: 1.17-0d1df
data plane version: 1.13-c0e5f3 (1 proxies), 1.17-0d1df (99 proxies)

kubectl version --short
Flag --short has been deprecated, and will be removed in the future. The --short output will become the default.
Client Version: v1.26.1
Kustomize Version: v4.5.7
Server Version: v1.23.17-eks-a5565ad
WARNING: version difference between client (1.26) and server (1.23) exceeds the supported minor version skew of +/-1

Additional Information
No response
Affected product area

[ ] Ambient
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Extensions and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
[ ] Upgrade
[ ] Multi Cluster
[ ] Virtual Machine
[ ] Control Plane Revisions

cc @jacob-delgado

Jacob mentioned above can explain this in more detail, but 1.17.2 is a security release where we built the release privately. After we publish the release, the code used is moved into the public repositories. Since we can't merge the Envoy changes back into Envoy's repos (they do as part of there publish), we put them into istio/envoy so others can recreate the build. You would see similar behavior with our last security release as well.

the wrong pr number easily misunderstood

Alright! That makes sense. Thanks @ericvn
One more thing.

With proxy release 1.17.5 looks like only the SHA bump was done and SHA256 is left out resulting in a checksum fail.
The SHA doesn't belong with envoyproxy org but belongs to Istio's envoy. (Looks like it needs the org change)

1.17.5 - https://github.com/istio/proxy/tree/1.17.5

1.17 is now EOL with the latest release.


feat: incorporate repo and folderpath values in fogg

Summary
These tags provide important context clues for debugging resources that are managed by Terraform.
Test Plan
Say unittests, or list out steps to verify changes.
References
(Optional) Additional links to provide more context.

stale


dejavu 3.5.3 have a XSS vulnerability

Describe the bug
I am trying to use dejavu, but when I try to use the search preview I find that the html tags in my search results are rendered by the browser and the js scripts in them are executed
Dejavu Version
Web 3.5.3
To Reproduce

Importing data containing html tags to es
Go to Search Preview
Search result values are rendered as html

Expected behavior
Data is rendered as text
Screenshots

Desktop (please complete the following information):

OS: windows 10
Browser firefox
Version 97.0.1

Additional context
Add any other context about the problem here.

@burpheart The ability to render HTML is important (to support highlighting use-case for example). That said, we've opted for using the dompurify package here to prevent XSS attacks. This is released as part of Dejavu v3.6.0.

Can this vulnerability be assigned a CVE number?

@burpheart The ability to render HTML is important (to support highlighting use-case for example). That said, we've opted for using the dompurify package here to prevent XSS attacks. This is released as part of Dejavu v3.6.0.


[Bug]: Tool calling broken when LLM responds with both text and tool calls

Bug Description
We are using llama-index to power a chatbot. We have observed that sometimes GPT-4o (and GPT-4 and GPT-4-turbo) responds with both a tool call and a response, like:

This is an excellent question! Please hold on while I find the answer for you.

We have tried to eliminate this behavior with prompting, but this only reduces the frequency of it, not eliminates it.
Because this is a chatbot, we need to stream the response to the user for optimal UX. However, when this happens, the bot only streams the initial LLM response and ignores the tool call. This leads to a chat "stalling"—unless the user prompts the bot to continue in some way, the bot never runs the tool or produces any further content. It's the same whether we use the async or sync version of the stream_chat method.
If this happens using a regular chat call, the behavior is also broken, but less severely: the LLM produces the initial text response and a tool call, the agent calls the tool, calls the LLM back, and produces a response. However, in this scenario, the response produced is just the second part after the tool call, and the initial message from the LLM gets lost.
The following gist reproduces the issue: https://gist.github.com/psyho/5440760f123819a928442ac39f896e6d
PS. Just to reiterate, this "text response + tool call" is not something we want the bot to do, but it happens organically with GPT-4. I believe the code in llama-index assumes that the LLM either responds with text or with a tool call, but not both, and that is apparently a wrong assumption.
Version
0.10.59 (and earlier)
Steps to Reproduce
Failing test case: https://gist.github.com/psyho/5440760f123819a928442ac39f896e6d
Relevant Logs/Tracbacks
No response

This will be quite a doozy to fix. Because if the tool call is happening after the we've already returned the generator to the user, that means you are completely out of the agent code.
Any ideas would be helpful 😅


Converting rooms works fine in editor but fails at runtime

Godot version
3.4.beta2, 3.x (5d4352f)
System information
macOS 11.4
Issue description
Clicking "Convert Rooms" works properly in editor. But calling rooms_convert() fails with several warnings:
_second_pass_portals
WARNING: Portal_Hallway possibly in the wrong room.
     at: _check_portal_for_warnings (scene/3d/room_manager.cpp:1086)
WARNING: Portal_Hallway*0 possibly in the wrong room.
     at: _check_portal_for_warnings (scene/3d/room_manager.cpp:1086)
WARNING: Portal_Hallway*0 possibly facing the wrong way.
     at: _check_portal_for_warnings (scene/3d/room_manager.cpp:1101)
_autolink_portals
ROOM	A
		POUT	Portal_Hallway
			GEOM	Floor
			GEOM	Floor2
			GEOM	Floor3
			GEOM	Floor4
			GEOM	Floor5
WARNING: QuickHull failed building simplified bound
     at: _build_simplified_bound (scene/3d/room_manager.cpp:1514)
ROOM	Hallway
		PIN 	Portal_Hallway
		PIN 	Portal_Hallway*0
			GEOM	CSGPolygon
			GEOM	CSGPolygon2
			GEOM	CSGPolygon3
ROOM	B
		POUT	Portal_Hallway*0
			GEOM	Floor
			GEOM	Floor2
			GEOM	Floor3
			GEOM	Floor4
			GEOM	Floor5
WARNING: QuickHull failed building simplified bound
     at: _build_simplified_bound (scene/3d/room_manager.cpp:1514)
Room conversion complete. 3 rooms, 2 portals.

The portals are all in the square rooms facing outward. Check out the MRP.
Steps to reproduce
Use the MRP, clicking "Convert Rooms" in editor (works fine), and run the project (errors are printed).
Minimal reproduction project
demo.zip

This looks like a CSG updating issue. CSG stuff I added because people like to use them to preview levels but they haven't been as tested as MeshInstances, so I apologize.
I've found that changing your script to this solves it:
func _ready():
	call_deferred("start")
	pass

func start():
	$RoomManager.rooms_convert()

I'm presuming because the CSG's have 1 frame to calculate themselves before they are queried by the RoomManager for geometry on conversion. It is a bug though, presumably there is some method in them that I need to call to force an update for this situation. :+1:

Fixed by #51010.


Make DNSSD queries cancellable

Hi!
First of all, thanks for this great lib!
I'd like to be able to cancel queries made with the DNSSD Resolver, because the timeout is pretty long and it would be nice to be able to cancel the Task after a custom timeout.
I've seen that the cancellation behavior is implemented for the Ares Resolver and I've tried to make it work for the DNSSD Resolver.
I implemented the onTermination method of the stream continuation, however this produces a warning when trying to call DNSServiceRefDeallocate on the pointer, since it isn't a Sendable type and it could be modified by several threads at the same time.
I am not very experienced in the inner workings of Swift concurrency, how could the DNSSD queries cancellation be implemented?
Thanks and have a nice day!

I don't see any warnings locally with https://github.com/apple/swift-async-dns-resolver/pull/33. Which Swift version are you using? Would you be able to give changes in that PR a try to see if it works for you?

I'm using Swift 5.10 (swiftlang-<IP_ADDRESS> clang-15<IP_ADDRESS>) and I get the warning Capture of 'serviceRefPtr' with non-sendable type 'UnsafeMutablePointer<DNSServiceRef?>' (aka 'UnsafeMutablePointer<Optional<OpaquePointer>>') in a ``@Sendable`` closure.
The changes in the PR don't seem to work. onTermination is called, but only after the long DNSSD timeout, and the termination is always .finished(nil), never .cancelled.
Here's a minimal example of code where my 3s timeout is not respected and the SRV query still runs for 10-15s:
import Foundation
import AsyncDNSResolver

struct TimeoutError: Error {}

func getSRVRecords(withTimeout: TimeInterval) async throws -> [SRVRecord] {
    let resolver = try AsyncDNSResolver()
    let records = try await withThrowingTaskGroup(of: [SRVRecord].self) { group in
        group.addTask {
            return try await resolver.querySRV(name: "")
        }
        group.addTask {
            try await Task.sleep(nanoseconds: UInt64(withTimeout) * NSEC_PER_SEC)
            try Task.checkCancellation()
            throw TimeoutError()
        }
        do {
            let records = try await group.next()!
            group.cancelAll()
            return records
        } catch {
            group.cancelAll()
            throw error
        }
    }
    return records
}

do {
    let records = try await getSRVRecords(withTimeout: 3)
    print(records)
} catch {
    print("Error: \(error)")
}

In my example I put "" as the service name, but I believe it happens with any SRV query that has no answer. group.cancelAll() is called when the query times out, in the catch, but onTermination is not called at that time.

DNSServiceProcessResult is blocking. We might have to do something like this SO suggested using select:
// Source: https://stackoverflow.com/questions/22502729/resolving-srv-records-with-ios-sdk

- (void)updateDnsRecords
{
    if (self.dnsUpdatePending == YES)
    {
        return;
    }
    else
    {
        self.dnsUpdatePending = YES;
    }

    NSLog(@"DNS update");
    DNSServiceRef       sdRef;
    DNSServiceErrorType err;

    const char* host = [self.dnsHost UTF8String];
    if (host != NULL)
    {
        NSTimeInterval remainingTime = self.dnsUpdateTimeout;
        NSDate*        startTime = [NSDate date];

        err = DNSServiceQueryRecord(&sdRef, 0, 0,
                                    host,
                                    kDNSServiceType_SRV,
                                    kDNSServiceClass_IN,
                                    processDnsReply,
                                    &remainingTime);

        // This is necessary so we don't hang forever if there are no results
        int            dns_sd_fd = DNSServiceRefSockFD(sdRef);
        int            nfds      = dns_sd_fd + 1;
        fd_set         readfds;
        int            result;

        while (remainingTime > 0)
        {
            FD_ZERO(&readfds);
            FD_SET(dns_sd_fd, &readfds);

            struct timeval tv;
            tv.tv_sec  = (time_t)remainingTime;
            tv.tv_usec = (remainingTime - tv.tv_sec) * 1000000;

            result = select(nfds, &readfds, (fd_set*)NULL, (fd_set*)NULL, &tv);
            if (result == 1)
            {
                if (FD_ISSET(dns_sd_fd, &readfds))
                {
                    err = DNSServiceProcessResult(sdRef);
                    if (err != kDNSServiceErr_NoError)
                    {
                        NSLog(@"There was an error reading the DNS SRV records.");
                        break;
                    }
                }
            }
            else if (result == 0)
            {
                NBLog(@"DNS SRV select() timed out");
                break;
            }
            else
            {
                if (errno == EINTR)
                {
                    NBLog(@"DNS SRV select() interrupted, retry.");
                }
                else
                {
                    NBLog(@"DNS SRV select() returned %d errno %d %s.", result, errno, strerror(errno));
                    break;
                }
            }

            NSTimeInterval elapsed = [[NSDate date] timeIntervalSinceDate:startTime];
            remainingTime -= elapsed;
        }

        DNSServiceRefDeallocate(sdRef);
    }
}

But instead of having a timeout/deadline we check for Task.isCancelled periodically? (thinking out loud)
The existing reply handling code should do what processDnsReply does already, so we shouldn't need to worry too much about it I think.
Hopefully the code involved (e.g., DNSServiceRefSockFD) works for all the query types this library supports and not just SRV. Looks like it is, but we will definitely need to test it.
Note that the referenced SO response is from 10 years ago. Maybe there are newer/better ways to do this.
@victorherrerod Is this something you want to try looking into?

If you want to wake a select on cancellation the usual recommendation would be to also add an eventFD or a pipe to the fdset and write into it on cancellation, then check for that.

Instead of using select I used poll to avoid being blocked. I thought about using an eventFD as @Lukasa mentioned, but I didn't know which library to import for get eventFD honestly (the Linux <sys/eventfd.h>) was not found in Xcode.
I've tested this a bit and it seems to work correctly, my code snippet above behaves as expected and the task cancels after 3 seconds.
The main doubt I have is removing DNSServiceRefDeallocate(serviceRefPtr.pointee) after calling DNSServiceProcessResult(serviceRefPtr.pointee). I did this because I have noticed the onTermination callback is always executed after calling continuation.finish(), even when there is no error, so I didn't want to call it twice when the request is successful.
However, I still have the Sendable warning I mentioned previously, I don't exactly know how to fix that.


Fix Kernel.Integer with input with leading zeroes and explicit base

This should fix the issue described in  #820

Can we add a test with this?

I added some tests (and a bugfix). This branch now includes the commits of #830, to prevent merge conflicts in the new test file. So I would advise to merge the other case first.


Core: Fix when adding a step of 0.01 that only bits are allowed

When using a step of 0.01 the validation starts to do funky.
When you have a step of 0.01 the following are allowed:
0, 0.01, 0.02, 0.04, 0.08, 0.16, 0.32, 0.64, 1.28, etc...

Duplicate of #1760

the fix itself looks way more elegant then #1760 .
if covered by a unit test we should merge this one IMO.

could you pick the unit tests from https://github.com/jzaefferer/jquery-validation/pull/1809 into this one?

@tbjers would you be ok, with this fix instead of yours?

@staabm this fix isn't a fix, check this: https://github.com/jzaefferer/jquery-validation/pull/1760#discussion_r59124104
Did my research to late :/
#1809 might be better, haven't tested it

Researching both right now and will let you know. Need to run the unit tests on this first.

@staabm This PR does not address the original issue, stepping fractions. The problem is with the JavaScript floating point calculations. The native JavaScript % operator isn't modulo, it's just remainder. Therefore #1809 correctly addresses the problem. Thanks, @DrowningElysium.

@tbjers thx for checkin.


[GOBBLIN-1613] Add metadata writers field to GMCE schema

Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA

[X] My PR addresses the following Gobblin JIRA issues and references them in the PR title. For example, "[GOBBLIN-1613] My Gobblin PR"

https://issues.apache.org/jira/browse/GOBBLIN-1613

Description

[X] Here are some details about my PR, including screenshots (if applicable):

Add optional field to GMCE schema for specifying metadata writers that should write. I've added corresponding code to filter base on this metadata writer field the GobblinMCEWriter
Tests

[X] My PR adds the following unit tests OR does not need testing for this extremely good reason:
Unit tests added and tested on holdem using iceberg metadata repair job

Commits

[X] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

Codecov Report

Merging #3490 (128d469) into master (b26bd92) will increase coverage by 4.09%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #3490      +/-   ##
============================================
+ Coverage     46.63%   50.73%   +4.09%
+ Complexity    10368     5692    -4676
============================================
  Files          2076     1037    -1039
  Lines         81114    39557   -41557
  Branches       9055     4441    -4614
============================================
- Hits          37828    20068   -17760
+ Misses        39803    17757   -22046
+ Partials       3483     1732    -1751

Impacted Files
Coverage Δ

.../apache/gobblin/runtime/api/JobExecutionState.java
79.43% <0.00%> (-0.94%)
:arrow_down:

...main/java/org/apache/gobblin/yarn/YarnService.java
15.46% <0.00%> (-0.52%)
:arrow_down:

...pache/gobblin/iceberg/writer/GobblinMCEWriter.java

...gobblin/azkaban/AzkabanGobblinYarnAppLauncher.java

...obblin/util/function/CheckedExceptionFunction.java

...obblin/service/modules/flowgraph/BaseDataNode.java

...in/azkaban/AzkabanGobblinLocalYarnAppLauncher.java

...tractor/extract/kafka/KafkaStreamingExtractor.java

.../org/apache/gobblin/cluster/GobblinTaskRunner.java

...g/apache/gobblin/aws/GobblinAWSClusterManager.java

... and 1033 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b26bd92...128d469. Read the comment docs.


adding json specification to api explorer

The code change will let the developers and QA team to see the object model json specification in the request body

There is a bug in the UI where it shows a {{ModalTabContainer}} template token on methods that don't contain any parameters as shown in the following screenshot:

The Api Explorer page will also need to be updated in each of the demo projects. Unfortunately we have not invested the time to get the solution setup so that there is only a single Api Explorer HTML page that is referenced by each project due to the way the build works and other complexities.

Other than that this is looking like a very nice contribution; thanks!


Unnecessary icons for local files?

Should the icons in the local file list be removed?
They will always be the same, dependant on your pdf viewer.

Imo it's good to have icon there. The only thing which I'd change is size of it.

@hitechcrafters Want to create an issue and adjust the size to a bit smaller?


fix: skip seeding for disabled remote

What kind of change does this PR introduce?
Bug fix
What is the new behavior?
Allows disabling [db.seed] via [remotes] config.
Additional context
Add any other context or screenshots.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>7
Details

5 of 7 (71.43%)  changed or added relevant lines in 1 file are covered.
5 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.03%) to 59.801%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

internal/db/push/push.go
5
7
71.43%

Files with Coverage Reduction
New Missed Lines
%

internal/gen/keys/keys.go
5
12.9%

Totals

Change from base Build<PHONE_NUMBER>1:
-0.03%

Covered Lines:
6385

Relevant Lines:
10677

💛  - Coveralls


fix: sort_benchmark remove call to depreciated rand.Seed() function.

This PR will be imported into Gerrit with the title and first
comment (this text) used to generate the subject and body of
the Gerrit change.
Please ensure you adhere to every item in this list.
More info can be found at https://github.com/golang/go/wiki/CommitMessage

The PR title is formatted as follows: net/http: frob the quux before blarfing

The package name goes before the colon
The part after the colon uses the verb tense + phrase that completes the blank in,
"This change modifies Go to ___________"
Lowercase verb after the colon
No trailing period
Keep the title as short as possible. ideally under 76 characters or shorter

No Markdown
The first PR comment (this one) is wrapped at 76 characters, unless it's
really needed (ASCII art, table, or long link)
If there is a corresponding issue, add either Fixes #1234 or Updates #1234
(the latter if this is not a complete fix) to this comment
If referring to a repo other than golang/go you can use the
owner/repo#issue_number syntax: Fixes golang/tools#1234
We do not use Signed-off-by lines in Go. Please don't add them.
Our Gerrit server & GitHub bots enforce CLA compliance instead.
Delete these instructions once you have read and applied them

Solving Issue: https://github.com/golang/go/issues/61142


fix: add arm specific control plane installation command

Signed-off-by: slonka<EMAIL_ADDRESS>When installing our CP on an arm64 k8s cluster without the node selector the node will fail to start.
Did you sign your commit? Instructions yes
Have you read Contributing guidelines? yes

I only added this switch to 1.6.x and dev since this was added in 1.6.x.
Useful links to check out:

https://deploy-preview-802--kuma.netlify.app/docs/1.6.x/deployments/stand-alone/#limitations
https://deploy-preview-802--kuma.netlify.app/docs/dev/deployments/stand-alone/#limitations
https://deploy-preview-802--kuma.netlify.app/docs/1.6.x/installation/kubernetes/#_2-run-kuma
https://deploy-preview-802--kuma.netlify.app/docs/dev/installation/kubernetes/#_2-run-kuma

Would love to get review from @lobkovilya - since he's the one who added that flag.

Actually while the 1.6.x supported arm in CI we didn't publish images for arm. So I think this change should only be in dev

Actually while the 1.6.x supported arm in CI we didn't publish images for arm. So I think this change should only be in dev
Good catch! I'll change it.


estimate_parasitics -global_routing keeps iterating indefinitely

GRT keeps printing these messages
[WARNING GRT-0211] dbGcellGrid already exists in db. Clearing existing dbGCellGrid.
[INFO GRT-0020] Min routing layer: li1
[INFO GRT-0021] Max routing layer: met5
[INFO GRT-0022] Global adjustment: 0%
[INFO GRT-0023] Grid origin: (0, 0)
[WARNING GRT-0043] No OR_DEFAULT vias defined.
[INFO GRT-0003] Macros: 10
[INFO GRT-0004] Blockages: 1589272
[INFO GRT-0001] Minimum degree: 2
[INFO GRT-0002] Maximum degree: 2
[INFO GRT-0009] Nets to reroute: 2.
[INFO GRT-0111] Final number of vias: 4
[INFO GRT-0112] Final usage 3D: 14
[WARNING GRT-0211] dbGcellGrid already exists in db. Clearing existing dbGCellGrid.
[INFO GRT-0020] Min routing layer: li1
[INFO GRT-0021] Max routing layer: met5
[INFO GRT-0022] Global adjustment: 0%
[INFO GRT-0023] Grid origin: (0, 0)
[WARNING GRT-0043] No OR_DEFAULT vias defined.
[INFO GRT-0003] Macros: 10
[INFO GRT-0004] Blockages: 1589276
[INFO GRT-0001] Minimum degree: 2
[INFO GRT-0002] Maximum degree: 2
[INFO GRT-0009] Nets to reroute: 2.
[INFO GRT-0111] Final number of vias: 4
[INFO GRT-0112] Final usage 3D: 14
[WARNING GRT-0211] dbGcellGrid already exists in db. Clearing existing dbGCellGrid.

Then, it prints a message that the message limit reached, and gets stuck at this point for hours
[INFO GRT-0009] message limit reached, this message will no longer print
wrapper_resizer_routing_timing_packaged.zip

If it runs on a system with low memory (8GB), it crashes after some time with the message: [ERROR GRT-0183] heap underflow during 3D maze routing.

Any update here. It is kinda a blocking issue for designs larger than 20k cells.

I see many:
[WARNING GRT-0040] Net vccd1 has wires outside die area.
..
[WARNING GRT-0036] Pin analog_io[0] is outside die area.
warnings.  I don't know if this is the cause but it is unexpected.  Is there a reason for this?

@donn the packaging of this test case shows a problem:  LIB_RESIZER_OPT is set in run.sh but not in env.gdb

I'll take a look

You are running repair_timing after global_route.  In ORFS we run that after CTS but before global_routing.  Repair_timing after global routing is in development and is not yet recommended.
You have:
[INFO RSZ-0046] Found 6768 endpoints with hold violations.
after each endpoint repair, it calls grt to reroute the buffered net(s), updates estimate_rc and then sta before proceeding to the next endpoint.  You can see this in
[INFO GRT-0009] Nets to reroute: 4.
so it is making progress but very slowly.  This is a known performance problem in this under development work.

@donn I worked around it but noticed a bunch more were missing as well.

@maliberty Yeah I'm going to have to take a look. Most likely there's a file that's getting sourced but just not getting loaded properly by or_issue.py.


Don't print stacktraces with only one frame

Currently, we get diagnostics that look like this:
error: Undefined Behavior: no item granting read access to tag <untagged> at alloc994 found in borrow stack.
 --> src/main.rs:5:23
  |
5 |     unsafe { let _z = *y; }
  |                       ^^ no item granting read access to tag <untagged> at alloc994 found in borrow stack.
  |
  = help: this indicates a potential bug in the program: it performed an invalid operation, but the rules it violated are still experimental
  = help: see https://github.com/rust-lang/unsafe-code-guidelines/blob/master/wip/stacked-borrows.md for further information

  = note: inside `main` at src/main.rs:5:23

note: some details are omitted, run with `MIRIFLAGS=-Zmiri-backtrace=full` for a verbose backtrace

error: aborting due to previous error

This line:
  = note: inside `main` at src/main.rs:5:23

is the trimmed backtrace. But when there's only one frame, we don't need it at all. This PR removes it, along with its extra newline.
We could also always skip the first element of the stacktrace (because we always print a span for it). Should we?

There's nothing fundamentally different about 1-frame stack traces so I don't think we should special-case them.
However, it is true that our backtrace is a bit odd... the reason we print the first frame at all is that it contains one bit of information that is not otherwise present: the name of the function the error occurred in. It didn't seem right to name all functions except for the one with the error, so that's why I made it print that span again.

Ah. So what I want here is to fold the function name of the topmost frame into the  --> src/main.rs:5:23, but I don't think that is possible with the current API. grumble grumble

Yeah that would indeed be best.
Any other ideas? :D

:umbrella: The latest upstream changes (presumably #1971) made this pull request unmergeable. Please resolve the merge conflicts.

I asked the diagnostics people about this on Zulip and Esteban said the only real option here is to mash the file name into the diagnostic text. Gah. I'll just quietly be bothered by this. Perhaps when Span starts to know about the function it is in there will be some helpful changes on the rustc side.


Firefox renders 1st line in graph black, where as other browsers use orange

When looking at the graphs on iOS, or Microsoft Edge, the first line has nice orange lines.
The orange lines are easier to read on the dark background, and look better.
However on Firefox (128.0, but also older releases) they are rendered black.
Here is a side by side comparison of Firefox (left) and Edge (right).

Version of the card
Version: 2.1.2
To Reproduce
This is the configuration I used:
type: custom:apexcharts-card
experimental:
  color_threshold: true
graph_span: 1h
show:
  last_updated: true
header:
  standard_format: false
  show: true
  show_states: true
  colorize_states: true
  title: Usage per phase last hour
series:
  - entity: sensor.dsmr_reading_phase_currently_delivered_l1
    type: line
    group_by:
      func: last
      duration: 10s
    stroke_width: 2
    unit: Watt
  - entity: sensor.dsmr_reading_phase_currently_delivered_l2
    type: line
    group_by:
      func: last
      duration: 10s
    stroke_width: 2
    unit: Watt
  - entity: sensor.dsmr_reading_phase_currently_delivered_l3
    type: line
    group_by:
      func: last
      duration: 10s
    stroke_width: 2
    unit: Watt

You are not using the same HA theme on each of your browser. That's why. One has a primary color which seems to be orange and the other theme, some kind of dark gray.

Indeed, that was the problem. Odd that it was set differently.
Thanks for the very quick reply :)


Remove recently added config.hosts, fix nginx.conf instead

This was the issue: nginx.conf was intercepting the request to
https://mushroomobserver.org/images/1250918/vote
and routing it to
https://images.mushroomobserver.org/1250918/vote
That’s why requests to these two routes are failing, and not requests to “Propose a name” or any other route.
These paths both start with /images/:image_id.
(I had suspected lazyload was replacing the form action URL, but it is not)

Coverage: 93.534%. Remained the same when pulling 99928418fa2ff8646e6c5cb55d5ce55bb182c91c on nimmo-cors-stuff into 5d580f2dbb934813ef11eac22a5d8d0b45cbe1eb on main.


Refactor fleetctl get subcommands so that they all have json and yaml output options

In this proposed patch all subcommands now have a new --json flag to allow for json output. They will default to using an ascii table if that was previously the default.
Signed-off-by: grantseltzer<EMAIL_ADDRESS>

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@zwass Absolutely, good catch. They should all have consistent defaults. Will push new commit in the morning.

@zwass Went ahead and made that change 👍

Thanks for the merge!


Use custom user for SSH connection

Hi,
I think it would be useful to be able to select which user to use when running an SSH connection. The syntax could be something like: with<EMAIL_ADDRESS>as sultan.
It currently tries to connect me as jenselme<EMAIL_ADDRESS>which is invalid.

Try this:
with Sultan.load(user='aot', hostname='mydomain.com') as sultan:
    sultan.ls('/').run()

Let me know if that works for you, and close the ticket if it works for you.

It works, thanks.


supabase-cli: 1.29.3 -> 1.48.1

Description of changes
https://github.com/supabase/cli/releases/tag/v1.48.1
Things done
bumped version
docgen was replaced by doc, so rm that instead

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[x] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[X] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

https://github.com/ofborg build supabase-cli

https://github.com/ofborg build supabase-cli

@ofborg build supabase-cli


Api logging

grammar and style pass for #776 (jason's PR closed in favor of this one).

@MBishop17 i don't think we need to do the folder name change. we can just change the title and that should be fine.

LGTM


Add PROTECT-NHS study protocols

Adds PROTECT-NHS initial study protocols (COVID-19 questionnaires)

The protocol docs are causing the validation to fail because we previously didn't support string for the showIntroduction property.
Protocol docs updates here: https://github.com/RADAR-base/RADAR-aRMT-protocols/pull/54

Ok approved. Can you please merge it here?


Settings UI Showcase

https://pub.dev/packages/settings_ui

https://github.com/limcheekin/fluwix/tree/settings_ui_showcase


New: Edit with branch versioning

Ref: /common-samples/issues/2184 and /common-samples/pull/2182
This PR implements the new Edit with branch versioning sample.

I can't seem to find the status of the features listed anywhere so I can't tell if my changes have been applied or if they were saved from my last editing session. Could you add a line under the feature name to display its status?

On iPads, the action sheet floats in the middle of the screen. Is this expected behavior? Could it be anchored to the bottom of the screen like on iPhones?

Great suggestions! I made some changes to the callout UI, to display the damage type in callout as well as their place name.
Also I made changes to the actionsheet popover location. See the screenshot below.

Everything looks good, just one last detail. The callout lingers even though the feature is no longer there. Could you dismiss all callouts when a branch is switched?

While I'm playing with the text field delegate, I found 2 space auto period could cause invalid input.
The solution doesn't seem to be clean, so I'll leave it as is and let the server to handle this invalid input. 🤥  (server will give createVersion error).
ref: https://stackoverflow.com/questions/2576561/iphone-disable-the-double-tap-spacebar-for-shortcut/3023716#3023716

Hi @saratchandrakarumuri , please take a look at this new sample 😄


Fix isMounted deprecation

As of React 15.5, isMounted is deprecated.
This changeset is based on React's own isMounted implementation:
https://github.com/facebook/react/blob/v15.6.1/addons/create-react-class/factory.js#L695-L705
Fixes #105.

Any news on this?

@markoshust merged,  but I can't release.  @JedWatson

It looks like v1.0.1 was released, but still getting the Warning: Tappable: isMounted is deprecated. error on that version.

Thank you, 1.0.2 works :)


Indiscernible tags after modifying ads data

Description
1.Create two text files
2.Tag one of them with work/home etc.
3. change ads of both of them by using https://learn.microsoft.com/en-us/windows/win32/fileio/using-streams
4. inspect ads data by "more < filename " on cmd  (This is TestFile:Stream-26e859d14b3d and This is TestFile:Stream are being written)
5. Click one of unknown tags on folder
6. No file is being shown unlike other predefined tags (work/home etc.)

Steps To Reproduce
Written above
Requirements

e.g. Fix crash that occurs when...

Files Version
commit 6d7c29d4037362602f2146cb0b9fab504999d18b (HEAD -> main, origin/main, origin/HEAD) Author: dependabot[bot]<EMAIL_ADDRESS>Date:   Fri Jun 2 01:59:28 2023 -0400
Windows Version
Windows 11 (22H2): 22621
Log File
debug.log

Thanks for the report, Sorry for the delayed response.

If you open the ADS file does it have only the same UID as the tag you want added to the file/folder?

Sorry, I deleted my windows partition. Wont help about that

Alright.


Comparison to/thoughts on nixci?

nixci is built on devour-flake and seem similar to what you are trying to accomplish here.
I thought you may find it interesting, like to compare it, or potentially find interesting ideas from it.

So evaluating disko, nix-ci-build takes for an already build flake 10.929s and nixci uses 1:54.75 for the same flake. This is because it can build and evaluate in parallel (building already starts when the flake is still evaluate). I know that devour-flake is meant to provide caching but if you change a single byte, which is what I do in my project when testing changes, than this cache is no longer effective.
$ sed -i -e "s/description = \".*\"/description = \"$(date)\"/" flake.nix && time nix run nixpkgs#nixci
🍏 .
🍎 root
> nix flake lock --no-update-lock-file .
warning: Git tree '/home/mic92/disko' is dirty
> /nix/store/yj4w3pv3klgblg9cg7x8lr7f319ji84d-devour-flake/bin/devour-flake . --refresh -j auto
warning: Git tree '/home/mic92/disko' is dirty
trace: warning: mdadm: Neither MAILADDR nor PROGRAM has been set. This will cause the `mdmon` service to crash.
trace: warning: mdadm: Neither MAILADDR nor PROGRAM has been set. This will cause the `mdmon` service to crash.
trace: warning: mdadm: Neither MAILADDR nor PROGRAM has been set. This will cause the `mdmon` service to crash.
trace: warning: mdadm: Neither MAILADDR nor PROGRAM has been set. This will cause the `mdmon` service to crash.
trace: warning: mdadm: Neither MAILADDR nor PROGRAM has been set. This will cause the `mdmon` service to crash.
trace: warning: mdadm: Neither MAILADDR nor PROGRAM has been set. This will cause the `mdmon` service to crash.
trace: warning: mdadm: Neither MAILADDR nor PROGRAM has been set. This will cause the `mdmon` service to crash.
trace: warning: mdadm: Neither MAILADDR nor PROGRAM has been set. This will cause the `mdmon` service to crash.
trace: warning: mdadm: Neither MAILADDR nor PROGRAM has been set. This will cause the `mdmon` service to crash.
trace: warning: mdadm: Neither MAILADDR nor PROGRAM has been set. This will cause the `mdmon` service to crash.
trace: warning: mdadm: Neither MAILADDR nor PROGRAM has been set. This will cause the `mdmon` service to crash.
trace: warning: mdadm: Neither MAILADDR nor PROGRAM has been set. This will cause the `mdmon` service to crash.
trace: warning: mdadm: Neither MAILADDR nor PROGRAM has been set. This will cause the `mdmon` service to crash.
trace: warning: mdadm: Neither MAILADDR nor PROGRAM has been set. This will cause the `mdmon` service to crash.
trace: warning: mdadm: Neither MAILADDR nor PROGRAM has been set. This will cause the `mdmon` service to crash.
trace: warning: mdadm: Neither MAILADDR nor PROGRAM has been set. This will cause the `mdmon` service to crash.
trace: warning: mdadm: Neither MAILADDR nor PROGRAM has been set. This will cause the `mdmon` service to crash.
trace: warning: mdadm: Neither MAILADDR nor PROGRAM has been set. This will cause the `mdmon` service to crash.
trace: warning: mdadm: Neither MAILADDR nor PROGRAM has been set. This will cause the `mdmon` service to crash.
trace: warning: mdadm: Neither MAILADDR nor PROGRAM has been set. This will cause the `mdmon` service to crash.
trace: warning: mdadm: Neither MAILADDR nor PROGRAM has been set. This will cause the `mdmon` service to crash.
trace: warning: mdadm: Neither MAILADDR nor PROGRAM has been set. This will cause the `mdmon` service to crash.
trace: warning: mdadm: Neither MAILADDR nor PROGRAM has been set. This will cause the `mdmon` service to crash.
trace: warning: mdadm: Neither MAILADDR nor PROGRAM has been set. This will cause the `mdmon` service to crash.
trace: warning: mdadm: Neither MAILADDR nor PROGRAM has been set. This will cause the `mdmon` service to crash.
trace: warning: mdadm: Neither MAILADDR nor PROGRAM has been set. This will cause the `mdmon` service to crash.
trace: warning: mdadm: Neither MAILADDR nor PROGRAM has been set. This will cause the `mdmon` service to crash.
trace: warning: mdadm: Neither MAILADDR nor PROGRAM has been set. This will cause the `mdmon` service to crash.
trace: warning: mdadm: Neither MAILADDR nor PROGRAM has been set. This will cause the `mdmon` service to crash.
trace: warning: mdadm: Neither MAILADDR nor PROGRAM has been set. This will cause the `mdmon` service to crash.
trace: warning: mdadm: Neither MAILADDR nor PROGRAM has been set. This will cause the `mdmon` service to crash.
trace: warning: mdadm: Neither MAILADDR nor PROGRAM has been set. This will cause the `mdmon` service to crash.
trace: the create output is deprecated, use format instead
trace: warning: mdadm: Neither MAILADDR nor PROGRAM has been set. This will cause the `mdmon` service to crash.
trace: warning: mdadm: Neither MAILADDR nor PROGRAM has been set. This will cause the `mdmon` service to crash.
trace: warning: mdadm: Neither MAILADDR nor PROGRAM has been set. This will cause the `mdmon` service to crash.
trace: warning: mdadm: Neither MAILADDR nor PROGRAM has been set. This will cause the `mdmon` service to crash.
trace: warning: mdadm: Neither MAILADDR nor PROGRAM has been set.  This will cause the `mdmon` service to crash.
trace: warning: mdadm: Neither MAILADDR nor PROGRAM has been set. This will cause the `mdmon` service to crash.
trace: the create output is deprecated, use format instead
trace: warning: mdadm: Neither MAILADDR nor PROGRAM has been set. This will cause the `mdmon` service to crash.
trace: warning: mdadm: Neither MAILADDR nor PROGRAM has been set. This will cause the `mdmon` service to crash.
trace: warning: mdadm: Neither MAILADDR nor PROGRAM has been set. This will cause the `mdmon` service to crash.
trace: warning: mdadm: Neither MAILADDR nor PROGRAM has been set. This will cause the `mdmon` service to crash.
trace: warning: mdadm: Neither MAILADDR nor PROGRAM has been set. This will cause the `mdmon` service to crash.
trace: warning: mdadm: Neither MAILADDR nor PROGRAM has been set. This will cause the `mdmon` service to crash.
trace: warning: mdadm: Neither MAILADDR nor PROGRAM has been set. This will cause the `mdmon` service to crash.
trace: warning: mdadm: Neither MAILADDR nor PROGRAM has been set. This will cause the `mdmon` service to crash.
trace: warning: mdadm: Neither MAILADDR nor PROGRAM has been set. This will cause the `mdmon` service to crash.
trace: warning: mdadm: Neither MAILADDR nor PROGRAM has been set. This will cause the `mdmon` service to crash.
trace: warning: mdadm: Neither MAILADDR nor PROGRAM has been set. This will cause the `mdmon` service to crash.
trace: warning: mdadm: Neither MAILADDR nor PROGRAM has been set. This will cause the `mdmon` service to crash.
trace: warning: mdadm: Neither MAILADDR nor PROGRAM has been set. This will cause the `mdmon` service to crash.
trace: warning: mdadm: Neither MAILADDR nor PROGRAM has been set. This will cause the `mdmon` service to crash.
trace: warning: mdadm: Neither MAILADDR nor PROGRAM has been set. This will cause the `mdmon` service to crash.
trace: warning: mdadm: Neither MAILADDR nor PROGRAM has been set. This will cause the `mdmon` service to crash.
trace: warning: mdadm: Neither MAILADDR nor PROGRAM has been set. This will cause the `mdmon` service to crash.
trace: warning: mdadm: Neither MAILADDR nor PROGRAM has been set. This will cause the `mdmon` service to crash.
trace: warning: mdadm: Neither MAILADDR nor PROGRAM has been set. This will cause the `mdmon` service to crash.
trace: warning: mdadm: Neither MAILADDR nor PROGRAM has been set. This will cause the `mdmon` service to crash.
trace: warning: mdadm: Neither MAILADDR nor PROGRAM has been set. This will cause the `mdmon` service to crash.
trace: warning: mdadm: Neither MAILADDR nor PROGRAM has been set. This will cause the `mdmon` service to crash.
trace: warning: mdadm: Neither MAILADDR nor PROGRAM has been set. This will cause the `mdmon` service to crash.
trace: warning: mdadm: Neither MAILADDR nor PROGRAM has been set. This will cause the `mdmon` service to crash.
trace: warning: mdadm: Neither MAILADDR nor PROGRAM has been set. This will cause the `mdmon` service to crash.
trace: warning: mdadm: Neither MAILADDR nor PROGRAM has been set. This will cause the `mdmon` service to crash.
  building x86_64-linux.standalone
  building x86_64-linux.shellcheck
  building x86_64-linux.make-disk-image
this derivation will be built:
  /nix/store/k94q4pg1asvswgzkmvm4jxrjzg7481gi-shellcheck.drv
building '/nix/store/k94q4pg1asvswgzkmvm4jxrjzg7481gi-shellcheck.drv'...
┏━ Dependency Graph:
┏━ Dependency Graph:
┃ ✔ shellcheck
┣━━━ Builds
┏━ Dependency Graph:
┏━ Dependency Graph:
┃ ✔ shellcheck
┣━━━ Builds
┗━ ∑ ⏵ 0 │ ✔ 1 │ ⏳ 0 │ ⏱ 4strace: warning: mdadm: Neither MAILADDR nor PROGRAM has been set. This will cause the `mdmon` service to crash.
trace: warning: mdadm: Neither MAILADDR nor PROGRAM has been set. This will cause the `mdmon` service to crash.
trace: warning: mdadm: Neither MAILADDR nor PROGRAM has been set. This will cause the `mdmon` service to crash.
trace: warning: mdadm: Neither MAILADDR nor PROGRAM has been set. This will cause the `mdmon` service to crash.
trace: warning: mdadm: Neither MAILADDR nor PROGRAM has been set. This will cause the `mdmon` service to crash.
trace: warning: mdadm: Neither MAILADDR nor PROGRAM has been set. This will cause the `mdmon` service to crash.
trace: warning: mdadm: Neither MAILADDR nor PROGRAM has been set. This will cause the `mdmon` service to crash.
  building x86_64-linux.with-lib
  building x86_64-linux.lvm-sizes-sort
  building x86_64-linux.simple-efi
  building x86_64-linux.boot-raid1
  building x86_64-linux.luks-btrfs-subvolumes
  building x86_64-linux.btrfs-subvolumes
  building x86_64-linux.hybrid-tmpfs-on-root
  building x86_64-linux.gpt-bios-compat
  building x86_64-linux.lvm-raid
  building x86_64-linux.zfs-over-legacy
  building x86_64-linux.tmpfs
  building x86_64-linux.mdadm
  building x86_64-linux.legacy-table
  building x86_64-linux.hybrid
  building x86_64-linux.module
  building x86_64-linux.luks-on-mdadm
  building x86_64-linux.swap
  building x86_64-linux.mdadm-raid0
  building x86_64-linux.complex
  building x86_64-linux.luks-interactive-login
  building x86_64-linux.zfs
┏━ Dependency Graph:
┃ ✔ shellcheck
┣━━━ Builds
┗━ ∑ ⏵ 0 │ ✔ 1 │ ⏳ 0 │ ⏱ 6snoglob nix run github:Mic92/nix-ci-build  134.43s user 93.63s system 2086% cpu 10.929 total

This is my hardware: AX102
$ inxi -F
System:    Host: bld2 Kernel: 6.1.44 x86_64 bits: 64 Console: tty pts/10 Distro: NixOS 23.11 (Tapir)
Machine:   Type: Desktop System: ASUS product: N/A v: N/A serial: <superuser required>
           Mobo: ASUSTeK model: Pro WS 665-ACE v: Rev 1.xx serial: <superuser required> UEFI: American Megatrends v: 1417
           date: 05/19/2023
CPU:       Info: 16-Core model: AMD Ryzen 9 7950X3D bits: 64 type: MT MCP cache: L2: 16 MiB
           Speed: 4200 MHz min/max: 3000/4200 MHz Core speeds (MHz): 1: 4200 2: 4200 3: 4200 4: 4200 5: 4200 6: 4200 7: 4200
           8: 4200 9: 4200 10: 4200 11: 4200 12: 4958 13: 4942 14: 4474 15: 4940 16: 4961 17: 4200 18: 4200 19: 4200 20: 4200
           21: 4200 22: 4200 23: 4200 24: 4966 25: 4200 26: 4200 27: 4200 28: 4200 29: 4200 30: 4200 31: 4200 32: 4200
Graphics:  Message: No device data found.
           Display: server: No display server data found. Headless machine? tty: 159x84
           Message: Unable to show advanced data. Required tool glxinfo missing.
Audio:     Message: No device data found.
Network:   Message: No device data found.

Sensors:   Missing: Required tool sensors not installed. Check --recommends
Info:      Processes: 560 Uptime: 08:52:22  up 10 days 12:13,  10 users,  load average: 0.22, 0.20, 0.29 Memory: 125.46 GiB
           used: 67.42 GiB (53.7%) Init: systemd Shell: Bash inxi: 3.3.04

Also now part of the readme.


Fix documentation

[x] Double check that image URLs are actual files
[ ]  Double check link to the factry documenation
- Looks fine to me? What needs changing?
[x] Make sure changelog.MD reflect the changelog of the docs

[x]  Double check that image URLs are actual files
[ ]   Double check link to the factry documenation

Looks fine to me? What needs changing?

[x]  Make sure changelog.MD reflect the changelog of the docs

link maybe should point to the latest version + the docs are only showing v1 docs

link maybe should point to the latest version + the docs are only showing v1 docs

only v1 docs showing is an issue with the documentation pipeline I guess, not with this repo. But I updated it to point to /latest anyway