res_meter: fix assertion failure

Issue Number: close #12234
Signed-off-by: mornyx<EMAIL_ADDRESS>What's changed
Before
In the past, we used assertions to ensure that when tagged Records.records was empty, untagged Records.others must also be empty:
pub fn is_empty(&self) -> bool {
    if self.records.is_empty() {
        assert!(self.others.is_empty());
        true
    } else {
        false
    }
}

This is reasonable in the general case, but will trigger an assertion failure under some special condition...
In a certain round of collection, when we collect tags that exceed the maximum number limit (max_resource_group), and all these tags correspond to equal cpu_time, then our records.top_k() action will get 0 top and many evicted:
fn handle_records(&mut self, records: Arc<RawRecords>) {
    let ts = records.begin_unix_time_secs;
    if self.config.max_resource_groups >= records.records.len() {
        self.records.append(ts, records.records.iter());
        return;
    }
    // Here we got 0 top and many evicted.
    let (top, evicted) = records.top_k(self.config.max_resource_groups);
    self.records.append(ts, top);
    let others = self.records.others.entry(ts).or_default();
    evicted.for_each(|(_, v)| {
        others.merge(v);
    });
}

At this point, a scheduled report is triggered and an empty check is performed. So the assertion fails.
After
We changed the basis for Records to be empty to Records.records and Records.others are both empty:
pub fn is_empty(&self) -> bool {
    self.records.is_empty() && self.others.is_empty()
}

So when the above scenario occurs, only reporting Records.others without Records.records is allowed.
Release note
None

/cc @zhongzc @breeswish PTAL, thanks!

/merge

/merge

The description of the PR is very verbose. It helped me a lot. Great job!


[docs-only] Improve EventConsumers docu

Fulfills promise given here: https://github.com/owncloud/ocis/pull/4854

@mmattel here is the config change from last week, better documented now I hope. Could you have a look again?


add elasticsearch-scenario

add elasticsearch test case

@oatiz all of test case about elasticsearch senario are failed, Here is the validate-log

@ascrutae Please run the test again.

Could you sync the test scenario project? @oatiz

Done.

@ascrutae pls run again, set es memory to 256m, here is test report:

Case description
Status
Cases

Elasticsearch
3 passed. 0 failed
click me

Elasticsearch

Version
Passed
Failed

5.6.8
:heavy_check_mark:

5.6.9
:heavy_check_mark:

5.6.10
:heavy_check_mark:


connect to postgres with ssl option

Hello, I'm trying to connect the graph index to our Postgres DB which expect to use an SSL connection, but I get the error SequelizeConnectionError: no pg_hba.conf entry for host ...

Full error trace

Starting the Indexer Agent in single-network mode
{"level":20,"time":1701860133051,"pid":1,"hostname":"graph-network-indexer-agent-0","name":"IndexerAgent","msg":"Reviewing Indexer Agent configuration"}
{"level":40,"time":1701860133052,"pid":1,"hostname":"graph-network-indexer-agent-0","name":"IndexerAgent","msg":"The option '--collect-receipts-endpoint' is deprecated. Please use the option '--gateway-endpoint' to inform the Gateway base URL."}
{"level":40,"time":1701860133052,"pid":1,"hostname":"graph-network-indexer-agent-0","name":"IndexerAgent","gasIncreaseTimeout":0.24,"msg":"Gas increase timeout is set to less than 0.24 seconds. This may lead to high gas usage"}
{"level":30,"time":1701860133180,"pid":1,"hostname":"graph-network-indexer-agent-0","name":"IndexerAgent","host":"xxxxxxx.eu-west-1.rds.amazonaws.com","port":5432,"database":"indexer","poolMax":50,"msg":"Connect to database"}
{"level":20,"time":1701860133212,"pid":1,"hostname":"graph-network-indexer-agent-0","name":"IndexerAgent","component":"MetricsServer","component":"MetricsServer","port":7300,"msg":"Listening on port"}
{"level":40,"time":1701860133221,"pid":1,"hostname":"graph-network-indexer-agent-0","name":"IndexerAgent","err":{"type":"IndexerError","message":"Unhandled promise rejection","stack":"IndexerError: Unhandled promise rejection\n    at indexerError (/opt/indexer/packages/indexer-common/dist/errors.js:173:12)\n    at process. (/opt/indexer/packages/indexer-agent/dist/commands/start.js:387:56)\n    at process.emit (node:events:527:28)\n    at process.emit (node:domain:475:12)\n    at emit (node:internal/process/promises:140:20)\n    at processPromiseRejections (node:internal/process/promises:274:27)\n    at processTicksAndRejections (node:internal/process/task_queues:97:32)","code":"IE035","explanation":"https://github.com/graphprotocol/indexer/blob/main/docs/errors.md#ie035","cause":{"type":"ConnectionError","message":"no pg_hba.conf entry for host \"X.X.X.X\", user \"thegraph\", database \"indexer\", no encryption","stack":"SequelizeConnectionError: no pg_hba.conf entry for host \"X.X.X.X\", user \"thegraph\", database \"indexer\", no encryption\n    at Client._connectionCallback (/opt/indexer/node_modules/sequelize/lib/dialects/postgres/connection-manager.js:143:24)\n    at Client._handleErrorWhileConnecting (/opt/indexer/node_modules/pg/lib/client.js:327:19)\n    at Client._handleErrorMessage (/opt/indexer/node_modules/pg/lib/client.js:347:19)\n    at Connection.emit (node:events:527:28)\n    at Connection.emit (node:domain:475:12)\n    at /opt/indexer/node_modules/pg/lib/connection.js:117:12\n    at Parser.parse (/opt/indexer/node_modules/pg-protocol/dist/parser.js:40:17)\n    at Socket. (/opt/indexer/node_modules/pg-protocol/dist/index.js:11:42)\n    at Socket.emit (node:events:527:28)\n    at Socket.emit (node:domain:475:12)","name":"SequelizeConnectionError","parent":{"type":"DatabaseError","message":"no pg_hba.conf entry for host \"X.X.X.X\", user \"thegraph\", database \"indexer\", no encryption","stack":"error: no pg_hba.conf entry for host \"X.X.X.X\", user \"thegraph\", database \"indexer\", no encryption\n    at Parser.parseErrorMessage (/opt/indexer/node_modules/pg-protocol/dist/parser.js:287:98)\n    at Parser.handlePacket (/opt/indexer/node_modules/pg-protocol/dist/parser.js:126:29)\n    at Parser.parse (/opt/indexer/node_modules/pg-protocol/dist/parser.js:39:38)\n    at Socket. (/opt/indexer/node_modules/pg-protocol/dist/index.js:11:42)\n    at Socket.emit (node:events:527:28)\n    at Socket.emit (node:domain:475:12)\n    at addChunk (node:internal/streams/readable:315:12)\n    at readableAddChunk (node:internal/streams/readable:289:9)\n    at Socket.Readable.push (node:internal/streams/readable:228:10)\n    at TCP.onStreamRead (node:internal/stream_base_commons:190:23)","length":159,"name":"error","severity":"FATAL","code":"28000","file":"auth.c","line":"550","routine":"ClientAuthentication"},"original":{"type":"DatabaseError","message":"no pg_hba.conf entry for host \"X.X.X.X\", user \"thegraph\", database \"indexer\", no encryption","stack":"error: no pg_hba.conf entry for host \"X.X.X.X\", user \"thegraph\", database \"indexer\", no encryption\n    at Parser.parseErrorMessage (/opt/indexer/node_modules/pg-protocol/dist/parser.js:287:98)\n    at Parser.handlePacket (/opt/indexer/node_modules/pg-protocol/dist/parser.js:126:29)\n    at Parser.parse (/opt/indexer/node_modules/pg-protocol/dist/parser.js:39:38)\n    at Socket. (/opt/indexer/node_modules/pg-protocol/dist/index.js:11:42)\n    at Socket.emit (node:events:527:28)\n    at Socket.emit (node:domain:475:12)\n    at addChunk (node:internal/streams/readable:315:12)\n    at readableAddChunk (node:internal/streams/readable:289:9)\n    at Socket.Readable.push (node:internal/streams/readable:228:10)\n    at TCP.onStreamRead (node:internal/stream_base_commons:190:23)","length":159,"name":"error","severity":"FATAL","code":"28000","file":"auth.c","line":"550","routine":"ClientAuthentication"}}},"msg":"Unhandled promise rejection"}

Looking at other issue around Sequelize for this error, it seems possible to fix via an option in the constructor
eg https://github.com/sequelize/sequelize/issues/956
sequelize: {
  databaseUrl: `${DATABASE_URL}?sslmode=require`,
  options: {
    native: true,
    dialect: 'postgres',
    dialectOptions: {
      ssl: {
        rejectUnauthorized: false, // very important
      },
    },
  }
}

However the graph indexer (agent or service) doesn't allow to pass any ssl option nor a custom dsn:
https://github.com/graphprotocol/indexer/blob/040c33734fd9b074a248a2d62b235c4f3791d17c/packages/indexer-agent/src/db/cli/umzug.ts#L39-L51
Do you think to make it possible to add some options to configure a pg ssl connection for both agent & service?
Thanks

Underlying library needs an update first: https://github.com/graphprotocol/common-ts/pull/119.
If / when accepted, I would add to this repo (that utilizes it).


pin releases in k8s config

pre-release step: review all k8s configs and ensure we use tags/digests where appropriate.

This is done and moved over to the other repo anyway.


Added Password files and optimzed

Description
I added the Password files and removed the parts that are unnecessary according the new Anse version
Linked Issues
#5 Password implementation
Additional context
I just added the files and optimized, this project is awesome and I invest my time to improve it!

I'm glad you're contributing to this feature, however it's not perfect yet.
For one thing, it lacks api-level authentication - Anse does not use api/generate route, which means that in Anse, there's no verification when sending a prompt, and users can easily bypass the password authentication page by blocking the request from the index page.
Also, I don't think it works in Docker environments. chatgpt-demo has been a problem in Docker, it doesn't read environment variables very well. I don't plan to use environment variables until that's fixed.
Still, thanks for the commit, and you can go ahead and finish your requirements in the fork version!


latest_version doesn't work for release-1.0 branches, it returns v0.27.*

Running latest_version doesn't work for release-1.0 branches, it returns v0.27.*
https://prow.knative.dev/view/gs/knative-prow/pr-logs/pull/knative_eventing/5953/pull-knative-eventing-upgrade-tests/1466421165185568768#1:build-log.txt%3A266
Function:
https://github.com/knative/hack/blob/96aac1c30be3b43594f8e36547506bb7ad5283f3/library.sh#L874-L915
/kind bug

Fixed by https://github.com/knative/hack/pull/106.


[WIP] Refactor everything to do with confirmation

Try to make the confirm flow go something like
resource -> mandate service -> payment provider specific stuff
\o/

Can we close this? It has been open for a considerable amount of time and we're trying to cut down the number of orphaned PRs in alphagov.

Closing: this is almost a year old and has severely bit-rotted.


support Low band

Currently this PR supports race band, fatshark band and low band together.

vtx low band is here:
https://github.com/hd-zero/hdzero-vtx/pull/145

At the top it says it supports now 1080P100.
This does not work, gives a blank or green screen.

At the top it says it supports now 1080P100. This does not work, gives a blank or green screen.

I made a mistake, it should be 1080p50. I have corrected it.

Ah ok :) yes, 1080P50 works flawlessly and smooth :)

Another report to this: I have the impression that the 1080P30 HDZero mode is still shown as 720p in the goggles. I see aliasing along the edges of objects and the OSD is aliased as well. DVR recording looks fine, but when compared to the live feed in the goggles, the goggles show less sharpness/aliasing which makes me think that the live image is still being downscaled.


genesisSlotNo is a misnomer

Currently we have
genesisSlotNo :: SlotNo
genesisSlotNo = SlotNo 0

and friends (genesisBlockNo etc). This is a misnomer: this is not the slot number of the genesis block, but rather the slot number of the first actual block (which, for Byron, happens to be an EBB, but for a sane chain would be the first normal block). After the introduction of WithOrigin, the SlotNo of the genesis block is Origin.

This got deleted in https://github.com/input-output-hk/cardano-base/pull/79 .


Given the assumed role of this app should "Find current location button" be on by default?

(From internal holistic testing)
It feels like this should maybe be on by default (it is not). I know other Instant Apps do not, but would think if I'm reporting something in most cases may want to do from my current location.

I'll follow-up with IA team.


Zero gradient for Active NamedTuple

I think NamedTuples are allowed as Actives, but currently, we get (may be a known problem):
julia> autodiff(x -> x.a * x.b, Active((a = 2, b = 3)))
((a = 0, b = 0),)

I think the issue here is that the type is integer rather than floating point, what happens if you do 2.0 and 3.0?
The justification for integers being that integers are essentially rounded values with derivative zero everywhere except at the round point (which can be thought of as a delta function).

Ah, indeed:
julia> autodiff(x -> x.a * x.b, Active((a = 2.0, b = 3.0)))
((a = 0, b = 0),)

Ah, I didn't realize that Active converts scalar integers to floating point (but doesn't do this recursively for NamedTuples, for course). Kind of a trap for the unaware user, though. :-)

I guess Enzyme can't do gradients for integers due to the way it works?
May be non-trivial to implement, but what if Active could throw an exception when passed something with integers in it?
Can easily happen that a user supplies an integer as part of a tuple of fit parameters or so, and generic code between that and Enzyme may think this perfectly fine and not complain about it. And the silent zero-gradient may stay undetected in a larger application ... and when noticed, the reason for it may be hard to track down.

Added some information regarding integer values to #72 .

Also wait @oschulz, your example with floats isn't what I'd expect (see my use below). What version are you using?
julia> autodiff(x -> x.a * x.b, Active((a = 2.0, b = 3.0)))
((a = 3.0, b = 2.0),)

The other reason why integers are inactive by default, for example, is that most of the time you really don't want to differentiate with respect to them. E.g. they are the size of an array, etc. That said using an integer as part of an active computation (e.g. multiplying by an integer) should work perfectly fine (and propagate that) so I'm curious what sorts of larger cases you're thinking about?

your example with floats isn't what I'd expect (see my use below). What version are you using?

That was with Enzyme.jl v0.6.0.

integers are inactive by default, for example, is that most of the time you really don't want to differentiate with respect to them. E.g. they are the size of an array, etc.

It's kinda different to what users are used to in ForwardDiff, Zygote, etc., though. Since Enzyme has a very nice mechanism to control what's active and what's not, the user can keep things like array sizes out of differentiation, right?

so I'm curious what sorts of larger cases you're thinking about

Let's say a user want to run a larger optimization problem, and part of the parameter set is a NamedTuple with some values. The user writes down some starting value (e.g. just (a = 0, b = 0, ...)) - if the code is written in a generic fashion, those integers may propagate through to Enzyme. And if things are complex enough (involved calculations, many parameters, etc.), the reason may be hard to miss when debugging. And ForwardDiff and Zygote (if compatible with the code) would return the correct gradient.
Then there's the section "One must be allowed to take derivatives of integer arguments" in the ChainRules docs (CC @oxinabox), so Julia users are used to diffing in respect to integers. And since Enzme.Active does silently convert plain integers to floats, Enzyme seems (from a user point of view) to do just that in simple cases, even though it really doesn't.
I don't mean to criticize (Enzyme is awesome!) and I do understand that Enzyme isn't Julia only. I'm just a bit worried that this may become "trap" for Julia users in some cases.

Then there's the section "One must be allowed to take derivatives of integer arguments" in the ChainRules docs (CC @oxinabox), so Julia users are used to diffing in respect to integers. And since Enzme.Active does silently convert plain integers to floats, Enzyme seems (from a user point of view) to do just that in simple cases, even though it really doesn't.

Finally someone agrees with me :P

At some point I need to write a long post about embedded subspaces, types that represent the space, vs "computation conveniences".
Diffing with respect to integers is nonsense except:
When it is a computational convenience.
i.e. this value could have been a float but we converted it to an integer because it happend to be an integer right now and our algorithm is much faster if input is integer.
his happens much for for things like structured matrixes, but I can imagine doing for exp2
julia> fast_exp2(x) = exp2(isinteger(x) ? Int(x) : x)
fast_exp2 (generic function with 1 method)

julia> @benchmark exp2(k) setup=(k=rand((1.0, 2.0, 3.0, 4.0)))
BenchmarkTools.Trial:
  memory estimate:  0 bytes
  allocs estimate:  0
  --------------
  minimum time:     3.638 ns (0.00% GC)
  median time:      3.870 ns (0.00% GC)
  mean time:        4.075 ns (0.00% GC)
  maximum time:     14.902 ns (0.00% GC)
  --------------
  samples:          10000
  evals/sample:     1000

julia> @benchmark fast_exp2(k) setup=(k=rand((1.0, 2.0, 3.0, 4.0)))
BenchmarkTools.Trial:
  memory estimate:  0 bytes
  allocs estimate:  0
  --------------
  minimum time:     2.157 ns (0.00% GC)
  median time:      2.723 ns (0.00% GC)
  mean time:        2.708 ns (0.00% GC)
  maximum time:     19.106 ns (0.00% GC)
  --------------
  samples:          10000
  evals/sample:     1000

When it actually represents a continuous quantity
E.g. rather than a floating point representation, one can have some fixed-point representation.
Which is going to be backed by a Integer representing some minimum increment.

We have fixed point libraries, FixedPointDecimals.jl.
Example in stdlibs is that DateTimes are backed by a count of tick's since unix epoch.
Adding a period to a date time results in calling + on that backing count.
I am note sure where Decimal Floating point (like Decimals.jl) and Rationals fit in there; but both are backed be intergers.
Can one actually AD them by the operations then call on their consitutent parts?
I suspsect you can.
(excluding projecting back to the fixed point quantity)

In case in my tired "create rebuttals for reviews haze" caused the message to come across wrong, I do agree Enzyme should handle differentiation of integer quantities -- though doesn't do so right now.
Work for differentiating integers is in progress (and essentially was stalled for a bit as began tackling some more pressing issues like GPU, garbage collection, etc: https://github.com/wsmoses/Enzyme/issues/158).
Currently the way I see the design is to explicitly distinguish between non-differentiable integers (perhaps just called integer types in type analysis) and differentiable integers (perhaps called fixed point in type analysis, though still including regular integers). The reason we've (historically) assumed integers to be non differentiable is to avoid potentially asking questions like what is d/di array[i] (like in the example from Chainrules). By explicitly not implementing a derivative of this and asserting when something like it happened has been incredibly useful for debugging and ensuring the correctness of Enzyme's passes.
Since we do want certain integer operations to be differentiated (and still potentially others which can not be) is the reason why I'm currently thinking about this split type approach.
Also this is not at all set in stone (just early design musings) so if you have suggestions/ideas (especially if you have time to try them out), feel free!
As a final comment, the fast_exp2 case actually worries me a lot. Suppose the integer version were implemented as something like:
res = 1
while (i > 1) {
  if (i & 1)
    res *= base
  i /= 2
}

Even if i were a differentiable quantity, there'd be a zero derivative result since the only dependence on i is via control flow. Moreover, what should the semantic meaning of a differentiable i & 1 be. Activity analysis deduces the (integer) boolean result is only used is control flow and thus is inactive, so should we proceed with it being inactive -- or alternatively what is the adjoint of that instruction?

Thanks for all the explanations, Lyndon and Willian! Should I close this or leave it open?


Fix textfield can't use floatLabel issue

adapter_ is undefined, should use adapter

It would be great to get this merged - at the moment this component crashes if you pass floatLabel in as a prop.


Recieve Error XHR failed: message when trying to install extensions (macOS Sierra)

I have a clean install of VS Code for macOS High Sierra. Upon opening the editor and going to the Extension tab on the left, I receive an XHR error. I've seen this issue posted but with no viable solutions.

VSCode Version: 1.19.3 (1.19.3)

OS Version: macOS High Sierra (Version 10.13.3)

Steps to Reproduce:

Open fresh install of VS Code
Go to Extensions tab
Receive a Error XHR failed: message

Open Developer tools and see extensionquery failed

Opened Network Settings and no Proxies are configured

Does this issue occur when all extensions are disabled?: Yes/No

This issue is related to trying to install extensions.

I'm now currently not getting this error. Must have been on your guys' end.

@joaomoreno When do we show the XHR failed message?

No internet connection?
Proxy issues?
Market place is not reachable?

Must've been some server problem.


fix: copy cmd support copy from networkMounts

Signed-off-by: zhangyue<EMAIL_ADDRESS>
Ⅰ. Describe what this PR did
current impl doesn't support copy /etc/hosts or /etc/hostname from container, this pr fix it.
Ⅱ. Does this pull request fix one issue?

None.
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
added.
Ⅳ. Describe how to verify it
wait for CI
Ⅴ. Special notes for reviews
None.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.zhangyue seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Edit HNSW API docs

Makes some edits for clarity, readability, punctuation, etc.

Thank you @pierwill!


ToDo : Fix py2app issue with flask app not being run when packaged as macOS app

Fixed by Pyside6 and scripts. Commit ID : https://github.com/kspviswa/PyOMlx/commit/25cae00855f941703e41775d4f03414f2e7fcac7


FAIL Slovo-2018.09.22 5.22.1

I got the following report from CPAN. Unfortunately I don't have WIndows and I am not able to work on this faililure. If you feel able to investigate and fix the problem, pleas make a PR and I will gladly accept it.
It should conform to good codding standards like in Mojolicious.
From: Alexandr Ciornii (CHORNY)
Subject: FAIL Slovo-2018.09.22 5.22.1
Date: 2018-09-27T21:58:50Z
...
Use of uninitialized value $img_path in regexp compilation at t/004_crud.t line 156.
#   Failed test 'Base64 src is replaced with path to image.'
#   at t/004_crud.t line 156.

...
http://www.cpantesters.org/cpan/report/e2c21e8c-6bfe-1014-b211-2be0bc1c9eba

This is an anfinished duplicate of #10


⚠ Bofrost.fr has degraded performance

In 83c66ca, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1662 ms

Resolved: Bofrost.fr performance has improved in c3f74bb after 6 minutes.


Add unit and feature tests for Send-MailMessage

PR Summary
This PR adds several unit and feature tests for Send-MailMessage cmdlet.
Add unit tests:

Cc parameter
Bcc parameter
To parameter with array

Add feature tests:

Port parameter
Throw on wrong email address format
Free-From email address format
Priority parameter
BodyAsHtml switch
UTF8 Encoding
Attachments

PR Context
This PR should check against the behavior of Send-MailMessage before work on a newer implementation of Send-MailMessage cmdlet starts.
PR Checklist

[x] PR has a meaningful title

Use the present tense and imperative mood when describing your changes

[x] Summarized changes
[x] Change is not breaking
[x] Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
[x] This PR is ready to merge and is not Work in Progress.

If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.

User-facing changes

[x] Not Applicable
OR
[ ] Documentation needed

[ ] Issue filed:

Testing - New and feature

[ ] N/A or can only be tested interactively
OR
[x] Make sure you've added a new test if existing tests do not effectively test the code changed

[x] Add [feature] to your commit messages if the change is significant or affects feature tests

Please don't use [feature] in commits, until we are able to remove the old code.  All tests are run all the time without this tag now and the tag triggers the old code which was sometimes buggy.

Will do, thank you @TravisEz13!

@ThreeFive-O Thank you for your contribution!


Coverity 1545947: Resource leak in header_rewrite plugin

[approve ci centos]

Cherry-picked to v10.0.x


custom layout

Great work, is it possible to customize the layout ?
Thanks

you can see adminlte/dist/js/demo.js


feat(vpc): automatically generate Deny policy for invocation outside of VPC

Current dependencies on/for this PR:

main

PR #9

PR #10   👈

This comment was auto-generated by Graphite.

Graphite Merge Job
Current status: ⏳ Queued to merge
This pull request is currently queued to be merged as part of a stack.
This comment was auto-generated by Graphite.

Job Reference: bUFfnyyJ5OyWqV3R7QKf


UninstallCertificate does not work for IISSiteServerPlugin

I am  using letsencrypt-win-simple on a couple of servers with the following setup:

Windows 2008 R2
A site in IIS listening to subdomain.domain.com
RRAS enabled with SSTP using the 'default' certificate (which, from what I understand, is the same as the one used by the IIS site)

Whenever the certficate is renewed the old certificate is not deleted, which causes the SSTP connections to fail. Only once I manually remove the old certificate and restart RRAS users can connect again.
From what I understand certificates should be deleted after renewal. Is the fact RRAS is using the certificate as well preventing this by any chance?
At first I had set the SSTP certificate to use a specific certificate, but that doesn't work either, because the SSTP binding is not renewed.
Any help in solving this problem will be highly appreciated!

I just found out that a certificate is also not removed when i'm not using SSTP. Is this by design?

I'm not familiar with SSTP, but you are right that the old certificate should be uninstalled. The program output should show that happening, or an error if it fails. You can try running with --forcerenew and --verbose to see whats happening (and post the exception if uninstall fails).

I have tried your suggestion, but the old certificate(s) are not being removed. I don't think this has anything to do with SSTP though*. I think this happens on all of my Windows Server 2008 R2 machines. All servers have a similar configuration: 1 or more website(s), all secured using a SAN certificate. IIS uses URL rewrite to redirect http to https. RRAS enabled, SSTP certificate set to 'default'.
(*) I already figured out the problem with SSTP: My users connect via VPN to sub.domain.com using SSTP. If the certificate bound to the SSTP listener does not match the certificate used for the website on https://sub.domain.com the connection will fail. Since the letsencrypt certificate is being renewed every 60 days the website on https://sub.domain.com gets a new certificate, but SSTP is still using the old certificate.
If there is only one certificate in the store, then SSTP should - theoretically - use the same certificate as IIS, but I can't test this since old certificates are not being deleted.
This is the logfile from one server (domainnames have been edited for privacy):
[INFO] Let's Encrypt (Simple Windows ACME Client)
[INFO] version <IP_ADDRESS>694 (RELEASE)
[VERB] Verbose mode logging enabled
[INFO] Please report issues at https://github.com/Lone-Coder/letsencrypt-win-simple
[INFO] Renewal period: 60
[INFO] Certificate store: WebHosting
[INFO] ACME Server: https://acme-v01.api.letsencrypt.org/
[DBUG] Settings {ScheduledTaskName="letsencrypt-win-simple httpsacme-v01.api.letsencrypt.org"}
[DBUG] Config folder: C:\Users\Administrator\AppData\Roaming\letsencrypt-win-simple\httpsacme-v01.api.letsencrypt.org
[DBUG] Certificate folder: C:\Users\Administrator\AppData\Roaming\letsencrypt-win-simple\httpsacme-v01.api.letsencrypt.org
[DBUG] Loading signer from C:\Users\Administrator\AppData\Roaming\letsencrypt-win-simple\httpsacme-v01.api.letsencrypt.org\Signer
[DBUG] Getting AcmeServerDirectory
[DBUG] Send GET request to https://acme-v01.api.letsencrypt.org/directory
[DBUG] Loading registration from C:\Users\Administrator\AppData\Roaming\letsencrypt-win-simple\httpsacme-v01.api.letsencrypt.org\Registration
[INFO] Checking renewals
[INFO] Renewing certificate for
[IISSiteServer] 1,2,3
[3 bindings - example.domain.nl, ... ] - renew after 11-10-2017
[DBUG] Scanning IIS sites
[INFO] Authorizing identifier example.domain.nl using http-01 challenge
[DBUG] Send POST request to https://acme-v01.api.letsencrypt.org/acme/new-authz
[DBUG] Writing challenge answer to C:\path\towebsite\.well-known\acme-challenge\iR9xIg1GXbVSEm8eS_pq5jt7fLfbxbtq4gkNIn5JQ-c
[DBUG] Writing web.config to C:\path\towebsite\.well-known\acme-challenge\web.config
[INFO] Answer should now be browsable at http://example.domain.nl/.well-known/acme-challenge/iR9xIg1GXbVSEm8eS_pq5jt7fLfbxbtq4gkNIn5JQ-c
[DBUG] Submitting answer
[DBUG] Send POST request to https://acme-v01.api.letsencrypt.org/acme/challenge/0xpJ1QNY-tL0EpLG60v9ixkSM615jGxanIWM5OTNkgk/1733776504
[INFO] Authorization result: valid
[DBUG] Deleting answer
[DBUG] Deleting web.config
[DBUG] Deleting C:\path\towebsite\.well-known\acme-challenge
[DBUG] Deleting C:\path\towebsite\.well-known
[INFO] Authorizing identifier dossier.domain.nl using http-01 challenge
[DBUG] Send POST request to https://acme-v01.api.letsencrypt.org/acme/new-authz
[DBUG] Writing challenge answer to C:\path\towebsite2\.well-known\acme-challenge\MOKCljBH6iYsHOGPXoRg4ZIYYn5gcowEgYX4kqUlqoQ
[DBUG] Writing web.config to C:\path\towebsite2\.well-known\acme-challenge\web.config
[INFO] Answer should now be browsable at http://dossier.domain.nl/.well-known/acme-challenge/MOKCljBH6iYsHOGPXoRg4ZIYYn5gcowEgYX4kqUlqoQ
[DBUG] Submitting answer
[DBUG] Send POST request to https://acme-v01.api.letsencrypt.org/acme/challenge/DUdFpO5hqUymuFUiNqc4_GXVg9PaUal4ZOO7tJSEomU/1733777437
[INFO] Authorization result: valid
[DBUG] Deleting answer
[DBUG] Deleting web.config
[DBUG] Deleting C:\path\towebsite2\.well-known\acme-challenge
[DBUG] Deleting C:\path\towebsite2\.well-known
[INFO] Authorizing identifier debiteur.domain.nl using http-01 challenge
[DBUG] Send POST request to https://acme-v01.api.letsencrypt.org/acme/new-authz
[DBUG] Writing challenge answer to C:\path\towebsite2\.well-known\acme-challenge\zXFKc0A-RgUk6E4JXf3rhL_P3A9qlW1njFn_JnIPR-I
[DBUG] Writing web.config to C:\path\towebsite2\.well-known\acme-challenge\web.config
[INFO] Answer should now be browsable at http://debiteur.domain.nl/.well-known/acme-challenge/zXFKc0A-RgUk6E4JXf3rhL_P3A9qlW1njFn_JnIPR-I
[DBUG] Submitting answer
[DBUG] Send POST request to https://acme-v01.api.letsencrypt.org/acme/challenge/d57sWXCiKEaK5eMkZLNIKlUrHm4kU8_A8j-k5mDJt4E/1733778134
[INFO] Authorization result: valid
[DBUG] Deleting answer
[DBUG] Deleting web.config
[DBUG] Deleting C:\path\towebsite2\.well-known\acme-challenge
[DBUG] Deleting C:\path\towebsite2\.well-known
[DBUG] RSAKeyBits: 2048
[INFO] Requesting certificate: example.domain.nl
[DBUG] Send POST request to https://acme-v01.api.letsencrypt.org/acme/new-cert
[DBUG] certRequ CertificateRequest {CsrContent="*****"}
[DBUG] Request Status: Created
[INFO] Saving certificate to C:\Users\Administrator\AppData\Roaming\letsencrypt-win-simple\httpsacme-v01.api.letsencrypt.org\example.domain.nl-crt.der
[INFO] Saving issuer certificate to C:\Users\Administrator\AppData\Roaming\letsencrypt-win-simple\httpsacme-v01.api.letsencrypt.org\ca-0A0141420000015385736A0B85ECA708-crt.pem
[DBUG] CentralSsl False - San True
[INFO] Saving certificate to C:\Users\Administrator\AppData\Roaming\letsencrypt-win-simple\httpsacme-v01.api.letsencrypt.org\example.domain.nl-all.pfx
[INFO] Installing non-Central SSL certificate in the certificate store
[DBUG] Opened Certificate Store My
[DBUG] Set private key exportable
[DBUG] 1,2,3 2017-8-21 10:2:26
[DBUG] Adding certificate to store
[DBUG] Closing certificate store
[INFO] Installing non-Central SSL certificate in server software
[INFO] Adding https binding
[WARN] No HTTP binding for Website1 on Website1
[INFO] Updating existing https binding
[INFO] IIS will serve the new certificate after the Application Pool IdleTimeout has been reached.
[INFO] Committing binding changes to IIS
[DBUG] Opened Certificate Store My
[INFO] Closing Certificate Store
[INFO] Adding https binding
[WARN] No HTTP binding for Website2 on Website2
[INFO] Updating existing https binding
[INFO] IIS will serve the new certificate after the Application Pool IdleTimeout has been reached.
[INFO] Committing binding changes to IIS
[DBUG] Opened Certificate Store My
[INFO] Closing Certificate Store
[INFO] Adding https binding
[WARN] No HTTP binding for Website3 on Website3
[INFO] Updating existing https binding
[INFO] IIS will serve the new certificate after the Application Pool IdleTimeout has been reached.
[INFO] Committing binding changes to IIS
[DBUG] Opened Certificate Store My
[INFO] Closing Certificate Store
[INFO] Renewal scheduled
[IISSiteServer] 1,2,3
[3 bindings - example.domain.nl, ... ] - renew after 20-10-2017

After this websites use the new certificate, but the old certificate is still in the certificate store:

I found and fixed the issue in the IISSiteServer/UninstallCertificate code.

I can confirm that the old certificate is now succesfully removed.


Deprecate textScaleFactor

#35
This change deprecates textScaleFactor without providing an alternative. It is to avoid the necessity to raise the minimum Flutter SDK version and the major version of this package only for this reason. Users using a Flutter SDK version older than 3.17 can add an ignore comment to suppress the warning for now.
textScaler will be added to the CustomText widget at a future major version, probably around the release of the next Flutter stable version.

How to override the existing TextScaler (for users using Flutter 3.16+)
https://docs.flutter.dev/release/breaking-changes/deprecate-textscalefactor#overriding-the-text-scaling-strategy-in-a-widget-subtree


Useless config/config.ex ?

https://github.com/MikaAK/request_cache_plug/blob/main/config/config.ex
Is this file used? It seems even the atom is wrong:
config :request_cache, instead of config :request_cache_plug,
It's also wrong in the readme, section "Specifying Specific Caching Locations"

It provides defaults if anyone looks using Application.get_env however, sometimes this doesn't compile properly in libraries and so defaults are set in the config.ex


postprocessing functionality

Checklist

[ ] I'm reporting a feature request
[ ] I've verified that I'm running youtube-dl version 2019.05.20
[ ] I've searched the bugtracker for similar feature requests including closed ones

Description

WRITE DESCRIPTION HERE
We are trying to download the video using youtube_dl object in python scripting. During the preprocessing, we want our audio file with these following configuration :

Channel : mono
Encoding : pcm16

https://github.com/ytdl-org/youtube-dl#post-processing-options


Example wishlist

What would you like to see in a revamped example? i18n? What else?

Netlify!
https://github.com/rdela/gatsby-graphcms-rd
https://goofy-lamarr-14d2ac.netlify.com/
Get this going on https://github.com/GraphCMS/gatsby-graphcms-example#deploy


Add a Transaction for unpinned private messages

Currently, the way to send a private message without pinning a proof to the blockchain is to pass "txtype": "none" when sending the message. This is because Transactions and Operations were originally limited only to those things that resulted in a proof on the blockchain - so neither was created for unpinned messages.
Given the recent split of Transactions (a grouping mechanism) and BlockchainEvents (things that happened on the blockchain), it now makes sense that unpinned messages should be wrapped in a Transaction and Operation for tracking their asynchronous status. Suggest that this new type of transaction be called "unpinned" ("none" can remain as a deprecated synonym).
This also implies that the sending logic for unpinned messages should be further unified with the sending logic for pinned messages, and should generate similar Operations (minus the blockchain-related ones). It further implies that unpinned messages should be batched in the same manner as pinned ones, so that in all cases the Messages can be tied to Batches which are tied to Transactions.

Given recent developments on #421, it sounds like a re-design of the batching logic may be upcoming. This change should likely follow (or accompany) that redesign.

https://github.com/hyperledger/firefly/pull/501


Update README.md with correct installation setup

Description
I have updated README.md file with latest development setup. There were no clear instructions on installation of software dependencies, hence I added installation process with various operating systems.
Related Issue
Fixes: #426
Motivation and Context
This will help the new contributors to setup the project easily.
Types of changes

[x] New feature (non-breaking change which adds functionality)

Checklist:

[x] I have updated the documentation accordingly.
[x] All new and existing tests have passed and it does not give any unexpected error for the same.

Closing as this is stale


bump Python to 3.7, update packages

@rbval any reason why we use python 3.6 currently?

@e271828- wanna bump the package version as well?

lgtm, will defer approval to @rbval though

Added basemodel update to this

@rbval which other services?

@e271828- bcs, paymentagent, loader, hmt-servers

any change to get this merged and to pypi today? :)

I removed my basemodel update.


SequenceType.traverse(...) - crash when a produced Future fails

Using SequenceType.traverse(...) with a large enough sequence (around 200 - 300 items in my testing on the iOS simulator) causes a crash if one of the produced Futures fails.  Interestingly enough, it does not crash if all Futures succeed.
Specifically, it causes a stack overflow.  I'm wondering if it is related to #101?
Here's snippet of code that demonstrates the issue:
struct ExampleError: ErrorType {}

let items = Array(0 ..< 1000)
let f: Future<[Int], ExampleError> = items.traverse { i in
    let promise = Promise<Int, ExampleError>()
    if i == 289 {
        dispatch_async(dispatch_get_main_queue()) {
            promise.failure(ExampleError())
        }
    } else {
        dispatch_async(dispatch_get_main_queue()) {
            promise.success(i + 1)
        }
    }
    return promise.future
}

Sorry for the silence. I think this issue has been resolved in the latest beta (4.0.0-beta.2). Would be great if you could check this!

Closing this issue now, since I believe this has been resolved in BrightFutures 4.

(Sorry for the delay in getting back to you.)  Great, thanks!


Cao issue 22

Description
I added the ability to change the background color of the dropdown list. I also added so whenever the dropdown list has an image then show that image along with the text in the selection view.
Fixes # 22
Type of change
Strictly added only UI changes.
How Has This Been Tested?
It has been tested on the iPhone 8 and iTouch 7 by the simulator was well as on my device.

Xcode: 12.4
Model name:

Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings

Reviewers:
Please tag relevant people requesting a review

Hi, thanks for the thorough feedback, I think I fixed everything. Also I decided to move the selected and background color of the dropdown in the config area instead of the view.
As regard to the colors, you can change it to whatever you think it's best I was just trying to show that it works, it's not important to me.
Uploaded new changes and requested new review. Thanks

Sorry for getting back late @caocmai


[WEB] icon detail snippet fix

added in more tags for searching as well

Preview: https://shijir.github.io/clarity/icons/icon-sets
Signed-off-by: stsogoo<EMAIL_ADDRESS>

With all the format changes, it's a bit hard to identify what's fixing the issue at hand. Can you briefly explain or just highlight the relevant code changes for me?

@jeeyun our clr-code-snippet component wasn't working as it should. When the value of its [clrCode] changes, it wasn't updating the view. I think the problem lies in how we used prism.js in the clr-code-snippet component. That's why I didn't use the component and resorted to using raw code snippets.

@shijir refer to this issue: https://github.com/vmware/clarity/issues/98

@shijir is this PR going to be merged in 0.10.5? If yes we should update the milestone so that @gnomeontherun knows to merge this after the publish.


Autocomplete is Empty for Class Properties

I have this test code
var Person = Class.extend({
  init: function(isDancing){
    this.dancing = isDancing;
  },
  dance: function(){
    return this.dancing;
  }
});

var Ninja = Person.extend({
  init: function(){
    this._super( false );
  },
  dance: function(){
    // Call the inherited version of dance()
    return this._super();
  },
  swingSword: function(){
    return true;
  }
});

Now when I create Persone like var pp = new Person(false);  it works, bringing Person as guess type (i think it can be improved to take arguments from init function, but it at least works). But when I type pp. then I expect init, and dance functions as autocomplete items. It instead brings empty array.
I think TernJs does not deal with these kind of code yet: Am I correct on that?
Thanks for great tool!

Class is not a JavaScript keyword. I suppose you try http://ejohn.org/blog/simple-javascript-inheritance/
So you must write a tern plgin which support Class features.

Ok, thanks. I'm not JS Maverick, so I thought its somehow intrinsic JS


unauthorized url error

2024-09-29 03:57:36 | WARNING  | 440 - main | Unknown error while trying to play game: 401 Client Error: Unauthorized for url: https://api.bybitcoinsweeper.com/api/games/start - Sleep 20s
Traceback (most recent call last):
File "/root/bybitcs-peter/bot/core/tapper.py", line 372, in run
res.raise_for_status()
File "/root/bybitcs-peter/cs/lib/python3.10/site-packages/requests/models.py", line 1024, in raise_for_status
raise HTTPError(http_error_msg, response=self)
requests.exceptions.HTTPError: 401 Client Error: Unauthorized for url: https://api.bybitcoinsweeper.com/api/games/start

fixed


Rework project structure

Cool! Shouldn't we also add black, isort and flake8 in requirements/development.txt? Also is it safe to delete the old folders for all the apps in the root directory? They only seem to contain pycache

Yes, you are right. We need to add those requirements! 👍 Updated.
You can safely delete those directories. Git doesn't do that for you.

@allcaps, fixtures file test.json is still there because I forgot to delete it and the PR got merged.


Feat add distribute expr lists to parent plan node

Proposed changes
add distribute exprs from child to parent when doing plan translation
include operator:
aggregation
hashjoin
analytic

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall


Datagrid multiselect not working

Select one ...  (check one with "x")
[x] bug
[ ] feature request
[ ] enhancement

Expected behavior
https://vmware.github.io/clarity/documentation/v0.11/datagrid/selection
Actual behavior
Datagrid multiselect not working due to some module error.
Reproduction of behavior
https://stackblitz.com/edit/clarity-light-theme-v11-7x1m99?file=app%2Fapp.component.html
Environment details

Angular version: 4.x.x

Clarity version:

OS and version:

Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]

Hi @shravansofts - I don't seem to be able to replicate a module error with the stackblitz you provided. It runs and I don't see any errors. Can you provide more help so the issue can be replicated?
Perhaps I am I missing something from the issue report?
Here is a quick video with the stackblitz you provided.

To add a little bit, I see 2 problems in your stackblitz:

You're binding [(clrDgSelected)]="selected", but your property on the component is called selectedRows.
You are not initializing you selectedRows property, which is something we need. It should be: selectedRows: any[] = [];

Here is a working Stackblitz: https://stackblitz.com/edit/clarity-light-theme-v11-bn7kva?file=app%2Fapp.component.ts

@youdz Thanks for the clarification. Documentation is not specifying this initializing aspect.
To avoid this kind of queries we need a plunker link for each component demo. I have raised a separate issue for the same here.
I observed a typo in the documentation of selection as shown below. Please correct it.


keras package no longer imports in python environment

I have a small flake for tensorflow/keras dev:
{
  description = "Deep learning environment";
  outputs = { self, nixpkgs }:
  let pkgs = nixpkgs.legacyPackages.x86_64-linux;
  mypython = pkgs.python3.withPackages (ps: with ps;
    [
      keras
      tensorflow
    ]);
  in
  {
    devShells.x86_64-linux.default = pkgs.mkShell {
      packages = [ mypython ];
    };
  };
}

After a nix flake update, I can no longer import keras.
I did a bisect and found that the last version of nixpkgs where the import works is
commit b0db08979c620fc3b774fdda88db0943d723eb59
Merge: 9d4636da3969 8122293b5e0c
Author: Robert Schütz<EMAIL_ADDRESS>Date:   Fri Jan 12 14:58:10 2024 +0100

    Merge pull request #280342 from dotlambda/aiosomecomfort-0.0.25

    python311Packages.aiosomecomfort: 0.0.24 -> 0.0.25

With the above version:
python -c 'import tensorflow.keras'
2024-05-24 10:58:22.396626: I tensorflow/core/platform/cpu_feature_guard.cc:182] This TensorFlow binary is optimized to use available CPU instructions in performance-critical operations.
To enable the following instructions: SSE3 SSE4.1 SSE4.2 AVX AVX2 FMA, in other operations, rebuild TensorFlow with the appropriate compiler flags

With any version after that:
nix flake update
• Updated input 'nixpkgs':
    'github:NixOS/nixpkgs/b0db08979c620fc3b774fdda88db0943d723eb59?narHash=sha256-ychTyfZ9rPtDP8uJaSb8mhrkx00G0VQ5kOmuSTE8bS8%3D' (2024-01-12)
  → 'github:NixOS/nixpkgs/3f316d2a50699a78afe5e77ca486ad553169061e?narHash=sha256-NQbegJb2ZZnAqp2EJhWwTf6DrZXSpA6xZCEq%2BRGV1r0%3D' (2024-05-22)

python -c 'import tensorflow.keras'
2024-05-24 11:00:05.363240: I tensorflow/core/platform/cpu_feature_guard.cc:182] This TensorFlow binary is optimized to use available CPU instructions in performance-critical operations.
To enable the following instructions: SSE3 SSE4.1 SSE4.2 AVX AVX2 FMA, in other operations, rebuild TensorFlow with the appropriate compiler flags.
Traceback (most recent call last):
  File "<string>", line 1, in <module>
ModuleNotFoundError: No module named 'tensorflow.keras'

@NikolaMandic
Metadata:
nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 6.1.87, NixOS, 23.11 (Tapir), 23.11.20240424.dd37924`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.18.1`
 - channels(root): `"nixos-23.11"`
 - nixpkgs: `/nix/store/22chir190mpfvp59lgh39q7fp7w77br9-source`

@PicoGeyer did you ever find any resolution to this?

Hi, I'd like to add that you can call keras as standalone package. Just remove tensorflow. prefix, and keras.api or keras.models.. would work fine.
Even I wonder why it is not linked in tensorflow package calls

Related conversation: https://github.com/NixOS/nixpkgs/pull/333568#issuecomment-2280808641
Bug filed: #332198

May I know if it works with python312.withPackages, I get error that tensorflow 2.13 is not supported for 3.12


@ngx-formly/material-legacy not getting updates?

I'm using Angular 15 with the Material legacy components, so I am using @ngx-formly/material-legacy package. Recently version 6.1.1 of this package was released, but the @ngx-formly/material-legacy package was not updated. When trying to update @ngx-formly/core to the latest version, I'm getting a peer dependency error during install:
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR!
npm ERR! While resolving<EMAIL_ADDRESS>npm ERR! Found<EMAIL_ADDRESS>npm ERR! node_modules/@ngx-formly/core
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR! node_modules/@ngx-formly/material-legacy
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Conflicting peer dependency<EMAIL_ADDRESS>npm ERR! node_modules/@ngx-formly/core
npm ERR!   peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR!   node_modules/@ngx-formly/material-legacy
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

What is the state of the @ngx-formly/material-legacy package, does it receive updates or not? If not, what about setting the peer dependency @ngx-formly/core to a range, like ^6.1.0, instead of using a specific version?

fixed, please try with @ngx-formly/material-legacy = v6.1.1


[DO NOT MERGE] Add benchmarks

I used Jest because I need to mock react-native for this. Possibly we could switch all tests to Jest, or figure out how to switch the benchmark to Mocha at a later date.
Note that this is in dev mode. We need to test production build perf.
Screenshot is run on Mac Mini.

For Jest migration take a look at: https://github.com/styled-components/styled-components/issues/325

I've actually redone this with benchmark.js over on my project. The results aren't quite as dramatic as was shown with Jest, and a lot of this will be due to the fact that we're now running in production mode.

If you want to move this benchmarking into the styled-components repo, I'm more than happy for you to do so!
It does seem like the caching isn't working though. The last result is from running,
const instance = render(<Component />);
instance.update(<Component danger />);
instance.update(<Component />);
instance.update(<Component danger />);
instance.update(<Component />);
instance.update(<Component danger />);
instance.update(<Component />);
instance.update(<Component danger />);

Which should only parse two stylesheets, and then reuse the results. 😕


ACR task to remove old devcontainer images

Closes #1320
What is being addressed
dev container images can build up in the container registry when using cicd. Since we now use the "mgmt" ACR for this, it's possible to add a task to delete old images.

/test

/test


V1.1.8+ fails to start web server and crashes

Describe the bug
After updating to any version higher than 1.1.7, the container fails to start.
Server (please complete the following information):

OS Ubuntu 22.04.4 running docker version in kubernetes k3s 1.29.4+k3s1
Arch  Intel 64 Bit
Threadfin Version and Build as per description

To Reproduce
Steps to reproduce the behavior:

Update container

Expected behavior
Container runs
Screenshots
Nil
Desktop (please complete the following information):
Container fails agnostic of browser
Additional context
The kubernetes log states:
For help run: /home/threadfin/bin/threadfin -h

2024/05/26 06:43:03 [Threadfin] [WARNING] Don't run this as Root!

2024/05/26 06:43:03 [Threadfin] Version:                1.1 Build: 8

2024/05/26 06:43:03 [Threadfin] Database Version:       0.5.0

2024/05/26 06:43:03 [Threadfin] System IP Addresses:    IPv4: 2 | IPv6: 2

2024/05/26 06:43:03 [Threadfin] Hostname:               threadfin-0

2024/05/26 06:43:03 [Threadfin] System Folder:          /home/threadfin/conf/

2024/05/26 06:43:03 [Threadfin] Load Settings:          /home/threadfin/conf/settings.json

2024/05/26 06:43:03 [Threadfin] Temporary Folder:       /tmp/threadfin/2023-11-66P1-DK3A0I/

2024/05/26 06:43:03 [Threadfin] GitHub:                 https://github.com/Threadfin

2024/05/26 06:43:03 [Threadfin] Git Branch:             Main [Threadfin]

2024/05/26 06:43:03 [Threadfin] SSDP / DLNA:            true

2024/05/26 06:43:03 BRANCH:  Main

2024/05/26 06:43:03 TAG LATEST:  1.1.12

2024/05/26 06:43:03 FILE:  https://github.com/Threadfin/Threadfin/releases/download/1.1.12/Threadfin_linux_amd64

2024/05/26 06:43:03 [Threadfin] [WARNING] Threadfin update available

2024/05/26 06:43:03 [Threadfin] UUID:                   2023-11-66P1-DK3A0I

2024/05/26 06:43:03 [Threadfin] Tuner (Plex / Emby):    10

2024/05/26 06:43:03 [Threadfin] EPG Source:             XEPG

2024/05/26 06:43:03 [Threadfin] Plex Channel Limit:     480

2024/05/26 06:43:03 [Threadfin] Unfiltered Chan. Limit: 480

2024/05/26 06:43:03 [Threadfin] Backup Path:            /home/threadfin/conf/backup/

2024/05/26 06:43:03 [Threadfin] Backup file:            /home/threadfin/conf/backup/threadfin_auto_backup_20240526_0643.zip

2024/05/26 06:43:03 [Threadfin] Download:               https://i.mjh.nz/nz/raw-tv.m3u8

2024/05/26 06:43:03 [Threadfin] Check File:             https://i.mjh.nz/nz/raw-tv.m3u8

2024/05/26 06:43:03 [Threadfin] Save File:              https://i.mjh.nz/nz/raw-tv.m3u8 [ID: MSOFANJ6I8T1WX2BVCM7]

2024/05/26 06:43:03 [Threadfin] Download:               https://i.mjh.nz/nz/epg.xml

2024/05/26 06:43:03 [Threadfin] Check File:             https://i.mjh.nz/nz/epg.xml

2024/05/26 06:43:04 [Threadfin] Save File:              https://i.mjh.nz/nz/epg.xml [ID: XDBBTV7VL7YP7F1ZR6OD]

2024/05/26 06:43:04 [Threadfin] All streams:            41

2024/05/26 06:43:04 [Threadfin] Active streams:         41

2024/05/26 06:43:04 [Threadfin] Filter:                 0

2024/05/26 06:43:04 [Threadfin] DVR IP:                 threadfin.[redacted]:34400

2024/05/26 06:43:04 [Threadfin] Web Interface:          http://threadfin.[redacted]:34400/web/ | Threadfin is also available via the other 3 IP's.

2024/05/26 06:43:04 [Threadfin] XEPG:                   Parse XMLTV file: Freeview

2024/05/26 06:43:04 [Threadfin] [ERROR] listen tcp <IP_ADDRESS>:34400: bind: cannot assign requested address (Web server could not be started.) - EC: 1001

2024/05/26 06:43:04 [Threadfin] [ERROR] listen tcp <IP_ADDRESS>:34400: bind: cannot assign requested address () - EC: 0

I note there are references to v1.1.12 in the logs. I'm pinning my container version, it correctly states the version in the pod description.

Have a look at #267 seems to be a duplicated issue.

Different version numbers though, hence why I didn't consider it a duplicate. I've narrowed down this specific version that affected me one by one.
There's also no resolution to that issue, only a fork to a different repo which I wouldn't consider a fix.
-------- Original Message --------
On 27/05/24 18:19, Marcel Goerentz  wrote:

Have a look at #267 seems to be a duplicated issue.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>

There is a docker version

Regardless changing to a fork isn't a fix.

I didn't consider it a fix, it is a workaround.

Duplicate of #253


bug in new return_intermediate_steps arg

ValidationError: 1 validation error for RefineDocumentsChain
return_intermediate_steps
  extra fields not permitted (type=value_error.extra)

version mismatch

version mismatch

In which version it is supported? Is it supported in Conversation Retrieval chain ? @hwchase17 @JohnNay


[Constant Evaluator][Test] Add tests to check whether fatal errors are detected

This PR adds a couple of tests to check whether the constant evaluator can detect and report fatal errors that happen during an evaluation.

@swift-ci Please test and merge

@swift-ci Please test

Build failed
Swift Test OS X Platform
Git Sha - 8f96e8f463d409338131cfb3289a0a6680cb2b2e

@swift-ci Please test macOS platform


Document fold operations for functions

add fold operators for https://github.com/tremor-rs/tremor-runtime/pull/2349

Only reason is that it's a niche case and I wasn't sure if we should support it :D

It is now updated 🚀


fix translation of by

Hi there! First of all thanks for the awesome work. I noticed that "by" was not being translated in Django 2.1.7. Adding spaces fixed the issue.
Thanks!
S

Hi,
thanks for pull request. I just checked translations by running makemessages command and it looks like that strings were found without any issues.
PO file
#: templates/admin/filter_numeric_range.html:11 #: templates/admin/filter_numeric_single.html:11 #: templates/admin/filter_numeric_slider.html:11 #, python-format msgid "By %(filter_title)s" msgstr ""
Command
python manage.py makemessages -l en
Which tool are you using to parse translatable strings?


fileupload not working in my dynamic table

Hi, I'm  a beginner with Angular.
So I tried to add an upload cell to my table. When i add it to an ordinary table, it works well, but when i add it in my ng-repeat loop, it displays well but nothing happens.
My table results of a ng-repeat in the response of an asynch request using factory. On success, i refresh data by running again this factory.
Here is the problem : when i launch my app, $scope.$watch works 1 time and then nothing. It does't detect event in my dropzone. I guess that the problem is maybe my timeout or my factory.
HEre is my refresh function:
    function refreshQueues(){
        QueueFactory.getQueues().then(function (queues) {
            store.queues = queues;
            console.log('Queues refreshed');
            queueTimeoutPromise = $timeout(refreshQueues,6000);
        }, function (msg) {
            $timeout.cancel(queueTimeoutPromise);
            alert(msg);
        });
    }

Here is my upload part :
   function upload (files) {
        console.log('zeyi');
        if (files && files.length) {
            for (var i = 0; i < files.length; i++) {
                var file = files[i];
                console.log('file' + file);
                $upload.upload({
                    url: '/queue/upload?Id='+ $scope.inputId,
                    fields: {
                        'inputId': $scope.inputId
                    },
                    file: file
                }).progress(function (evt) {
                    var progressPercentage = parseInt(100.0 * evt.loaded / evt.total);
                    console.log('progress: ' + progressPercentage + '% ' +
                    evt.config.file.name);
                    console.log('inputid '+ $scope.input);
                }).success(function (data, status, headers, config) {
                    console.log('file ' + config.file.name + 'uploaded. Response: ' +
                    JSON.stringify(data));
                });
            }
        }
    }

And html :
<td ng-file-drop ng-file-select ng-model="files" class="drop-box" drag-over-class="dragover" ng-multiple="true" allow-dir="true" accept="image/*,application/pdf"></td>

So any guess for my problem ?
Thanks
PS: Sorry for my english.

Can you create a jsfiddle showing the problem?


Assembly doesn't find some required cats libraries

Although the project seems to work locally and the tests pass. When trying to launch it using spark-submit it raises an error that doesn't find some cats libraries.
We were using decline to parse command line arguments and it failed because it didn't find the cats methods used by decline, so we changed it to use plain arguments. It seems to start working, but crashes when starting to work.
At this moment this is the output of the crash:
21/08/31 14:05:37 INFO Utils: Successfully started service 'org.apache.spark.network.netty.NettyBlockTransferService' on port 36909.
21/08/31 14:05:37 INFO NettyBlockTransferService: Server created on <IP_ADDRESS>:36909
21/08/31 14:05:37 INFO BlockManager: Using org.apache.spark.storage.RandomBlockReplicationPolicy for block replication policy
21/08/31 14:05:37 INFO BlockManagerMaster: Registering BlockManager BlockManagerId(driver, <IP_ADDRESS>, 36909, None)
21/08/31 14:05:37 INFO BlockManagerMasterEndpoint: Registering block manager <IP_ADDRESS>:36909 with 434.4 MiB RAM, BlockManagerId(driver, <IP_ADDRESS>, 36909, None)
21/08/31 14:05:37 INFO BlockManagerMaster: Registered BlockManager BlockManagerId(driver, <IP_ADDRESS>, 36909, None)
21/08/31 14:05:37 INFO BlockManager: Initialized BlockManager: BlockManagerId(driver, <IP_ADDRESS>, 36909, None)
java.lang.NoSuchMethodError: cats.kernel.CommutativeSemigroup.$init$(Lcats/kernel/CommutativeSemigroup;)V
	at cats.UnorderedFoldable$$anon$1.<init>(UnorderedFoldable.scala:81)
	at cats.UnorderedFoldable$.<init>(UnorderedFoldable.scala:81)
	at cats.UnorderedFoldable$.<clinit>(UnorderedFoldable.scala)
	at fs2.internal.Scope.$anonfun$open$1(Scope.scala:138)
	at cats.effect.IOFiber.runLoop(IOFiber.scala:381)
	at cats.effect.IOFiber.execR(IOFiber.scala:1151)
	at cats.effect.IOFiber.run(IOFiber.scala:128)
	at cats.effect.unsafe.WorkerThread.run(WorkerThread.scala:359)
Exception in thread "main" java.lang.NoSuchMethodError: cats.kernel.CommutativeSemigroup.$init$(Lcats/kernel/CommutativeSemigroup;)V
	at cats.UnorderedFoldable$$anon$1.<init>(UnorderedFoldable.scala:81)
	at cats.UnorderedFoldable$.<init>(UnorderedFoldable.scala:81)
	at cats.UnorderedFoldable$.<clinit>(UnorderedFoldable.scala)
	at fs2.internal.Scope.$anonfun$open$1(Scope.scala:138)
	at cats.effect.IOFiber.runLoop(IOFiber.scala:381)
	at cats.effect.IOFiber.execR(IOFiber.scala:1151)
	at cats.effect.IOFiber.run(IOFiber.scala:128)
	at cats.effect.unsafe.WorkerThread.run(WorkerThread.scala:359)

My feeling is that the assembly merging policy we use to generate the assembly is failing either because it discards some required file to locate those classes or because it uses an old version of cats.
This is the build.sbt lines that declare the assembly merging policy:
 ThisBuild / assemblyMergeStrategy := {
     case PathList("META-INF", xs @ _*) => MergeStrategy.discard
     case x => MergeStrategy.first
    },
. . .

and when assembling, the system says:
info] compiling 1 Scala source to /home/labra/src/wikidata/sparkwdsub/target/scala-2.12/classes ...
[info] Strategy 'discard' was applied to 663 files (Run the task at debug level to see details)
[info] Strategy 'first' was applied to 176 files (Run the task at debug level to see details)

One intuition is that some required META-file is discarded...
The documentation on sbt-assembly describes several strategies about assembling that we may need to consider.

HI, @labra this issue has been actively reported in Spark 3 and Cats 2.2.0 (https://github.com/typelevel/cats/issues/3628, https://issues.apache.org/jira/browse/SPARK-33077). Apparently should be solved... Anyway, I managed to submit to spark the application providing the flags indicated by https://github.com/typelevel/cats/issues/3628#issuecomment-859810657.
Unfortunately, once I try this workaround I ended on #2.

Looks like this issue hsa been solved in the latest wdsub releases.


Explicitly set convertStrings argument to jpype.startJVM()

Closes #162.
PR checklist:

[x] Tests added.
[x] ~Documentation added.~ N/A
[ ] Release notes updated.

The first commit should fail the tests. The next commit will add the fix.

Ah, the py2 tests fail; we can re-test and merge after #175.

@danielhuppmann @zikolach I've asked for your reviews on this.
In particular, note the line where convertStrings=True is given. With this explicit setting, which was the default in JPype <= 0.7 the tests pass, and no warning is given (addressing @tzipperle's issue in #162). However, JPype's default will become convertStrings=False in 0.8 and later. If you give that setting and then run the code, many tests fail. (Please actually check out the branch, try this and have a look at the error messages. They are cryptic to me, but I've little experience with Java.)
I don't know if you might want to plan to eventually move to convertStrings=False. If so, an issue should be opened. Otherwise, we can update the comment to explain why the True setting is used.

@zikolach can you please look at the error messages?

@danielhuppmann I think my comment should have some details. Will have closer look, but theoretically if you switch it off you'll have to deal with Java string objects instead of python strings

theoretically if you switch it off you'll have to deal with Java string objects instead of python strings

That sounds not desirable. So I'll update the comment (removing the TODO, adding an explanation) and the docstring in one more commit—anything else.

That sounds not desirable

here is a link to the issue which partially explains the cases when convertStrings=false might be desirable

Excerpt from changelog:

Removed the previous default option to automatically convert java.lang.String to either a Python string or a unicode when returning from Java. This does mean some string operations now require calling the Java string method rather than the Python one. Having strings not convert but rather remain on the jvm until needed cuts the conversion costs when working with Java heavy code. I added a caching mech so that if we need to convert the string multiple times, we don't pay additional over the previous option.

The next commit I push is comments-only. Tests already pass, so I will merge without waiting for CI to complete.

Just for clarity the convertStrings argument is not going away in 0.8.  JPype will default to False if nothing was specified, meaning that Java strings are expected.  This is in contrast to JPype 0.6 in which Python strings were returned no matter what the user tried.  There was a bug in all versions prior to 0.7 that prohibited getting Java strings and the switch was changable by a global flag rather than at startup.  That option to switch during operation was unsafe as threads or other modules can switch the flag at will.  The default in 0.6 was not really defined as the switch always went to True regardless and the docs didnt help.  The current defailt is True just to prevent older 0.6 modules from breaking.
That said modules that use convertStrings==True are incompatible with modules that use False.  Doing preemptive conversions to strings is a misfeature in place of just requiring the user to add str arround the call if they want Python strings and going the other way trying to get Java strings from Python after each call is very inefficient for call chains.
The expected value for reusable Python modules is False.

Previously I wrote this:

I don't know if you [@danielhuppmann @zikolach] might want to plan to eventually move to convertStrings=False. If so, an issue should be opened. Otherwise, we can update the comment to explain why the True setting is used.

Thanks to @Thrameos' clarification just now:

The expected value for reusable Python modules is False.

…it sounds like we should definitely open such an issue.


Support Sorting API

Raising a feature request to support the sorting API first discussed in https://github.com/deneb-viz/deneb/issues/313.

You should be able to sort the data from Power BI by adding columns and measures in the order that you want them sorting. MS have recently added a sorting API that we can use if you want to be more explicit. This will require a change to the Deneb template structure, as I would want to ensure that sort order is carried across for anyone loading a template back up. Feel free to raise an issue for this if the current approach doesn't work and I can schedule for 2.0 (or earlier if the change can be done in a non-breaking manner; I will have to do some R&D to determine).

This is the API we would need to think about incorporating. Note that this assumes that sorting is done inside the visual, so the sort options in the visual header are not enabled.
We will need to think about or consider:

UX for sorting.

Immediate thoughts were that we leverage the dataset viewer sorting, but as the displayed (primary) dataset may be subject to additional transforms if using Vega, this may not correlate 1:1 with the data view that Power BI provides.
Much like selections, we need to be able to reconcile columns against the data view so that Power BI can resolve them on our behalf.
As such, we will likely need to provide a popover or dialog to manage this, listing dataset fields and the order in which we wish to sort them.
Given that this would be regarded as a volatile update to the data view, we should ensure that the user can finish finalizing their desired sort criteria (if multiple columns) before confirming.
We should also persist (or stage) the current spec before finalizing, otherwise the update that Power BI performs will revert to the last persisted spec.
We should allow the user to specify order of precedence for field sorting.

Verifying that the API allows sorting of both columns and measures (so we can be sure that we only expose the correct fields for sorting.
How this gets stored in a template. We will need to track:

How many fields we are sorting by.
Their direction.
Their precedence.


[SVLS-4142] Create a cold start span only when a cold start has not already occurred

What does this PR do?

Checks whether a cold start request ID has been recorded (from a restored execution context) prior to creating a cold start span. Typically this should not be needed since we use sync.Once to process the span just once, but after a runtime is killed in the Lambda environment during the INVOKE phase, on the next invocation the ColdStartSpanCreator is reinitialized and the sync.Once counter is reset to a value of done: 0 rather than done: 1, resulting in another cold start span being created. This will always happen on an invocation that follows a killed runtime.
This is noticeable if a cold start invocation hits an out of memory or timeout error. The subsequent invocation will have a trace with another cold start span. The work being done to introduce the Impending Timeout span also makes this noticeable:
https://github.com/DataDog/datadog-agent/assets/25290232/1da5acdb-b5f4-423d-8837-003b27024192
Motivation

An argument can be made that after the runtime is killed from a time out or out of memory error, the next invocation must re-initialize the Lambda environment again so it is a cold start. This specific scenario appears to be classified as a suppressed init: https://docs.aws.amazon.com/lambda/latest/dg/telemetry-schema-reference.html#InitPhase.
Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Reviewer's Checklist

[ ] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
[ ] Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
[ ] A release note has been added or the changelog/no-changelog label has been applied.
[ ] Changed code has automated tests for its functionality.
[ ] Adequate QA/testing plan information is provided. Except if the qa/skip-qa label, with required either qa/done or qa/no-code-change labels, are applied.
[ ] At least one team/.. label has been applied, indicating the team(s) that should QA this change.
[ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
[ ] If applicable, the need-change/operator and need-change/helm labels have been applied.
[ ] If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
[ ] If applicable, the config template has been updated.

/merge


onReady event for FOUC?

Thinking it would be useful to have an onReady event that way we can do things like fade the pager in once it has calculated  everything. Maybe we just hide the whole Frame component with some simple CSS until it is ready to avoid FOUC opacity: 0; pointer-events: none;.

I think this should do for now https://github.com/souporserious/react-view-pager/commit/1cb98d102036a1954d16be6b5bdec1b30a020500


Improve Per-language highlighting for code editor

Blocked as we don't know what is wrong with the current highlighting.


Lube can sling you inside walls.

Description
Lube has enough force to put you inside walls. Killing people unlucky enough to step in the wrong place.
In the screenshot two engineers walked in to engineering and got stuck in wall above table and died. RIP.
Reproduction
See image. Short runway, maybe the table cell charger affects but have seen other times people in walls.
Screenshots

Additional context
Feature not bug?

Clown buff

seems to exclusively happen for me when there is something in front of the wall, like a counter or rack. usually solvable by rightclicking the tile even if you cant see it and vaulting. definitely needs to be fixed though

Something I frequently experience ahelps about in the vein of "HELP IM STUCK IN A WALL"
almost every time its due to this exact interaction

slip on slippery puddle
slide into table
stand up
are not vaulted on table
table collision box shoves you off
you are now inside a wall taking pressure damage

every, time.


WFLY-9815 Remove configadmin subsystem

https://issues.jboss.org/browse/WFLY-9815
Please make sure your PR meets the following requirements:

[x] Pull Request title is properly formatted: [WFLY-XYZ] Subject or WFLY-XYZ Subject
[x] Pull Request contains link to the JIRA issue(s)
[x] Pull Request contains description of the issue(s)
[x] Pull Request does not include fixes for issues other than the main ticket
[x] Attached commits represent units of work and are properly formatted

Can't do this; it was part of 6.4 configs.


ONNX conversion

Is there an ONNX version for this  model ?

Hi there! Unfortunately not at the moment no.


Cannot play 3.68 games

i want to play punch line which requires 3.68 fm, but it doesn't seem to work, can anyone help ? thank you

tested by me and a handful of other people and works with comp pack on FW lower than 3.68.


Fix bugs

I notice that there is a lot of indentations / new lines difference between my code and yours. Did you properly activate your formater (the standard one, rustfmt)?

Damn, I thought that if I click on ready for review that it just brings me to the diff to see the diff, but it converts this PR from a draft to a complete PR instead. Sorry!

It's fine, just don't merge until I'm fully ready :laughing:

I have a question: Wouldn't it make more sense to let Ctx store fully its attributes instead of references to them? Because if we're mainly using Ctx than we can discard the other variables as well.

I notice that there is a lot of indentations / new lines difference between my code and yours. Did you properly activate your formater (the standard one, rustfmt)?

Yes, I noticed that as well. I'm on rustup-nightly and this is my formatter config (~/.config/rustfmt/rustfmt.toml`):
color = "Always"
enum_discrim_align_threshold = 100
format_code_in_doc_comments = true
# format_strings = true
match_block_trailing_comma = false
# max_width = 80
# reorder_impl_items = true
struct_field_align_threshold = 200
wrap_comments = true

Should I use the default formatting settings?

I would say yes, because I did not touch the rustfmt config. Is it possible to add a rustfmt.toml at the root of the project, so everyone working on Himalaya will have the same formatting?

I would say yes, because I did not touch the rustfmt config. Is it possible to add a rustfmt.toml at the root of the project, so everyone working on Himalaya will have the same formatting?

Looks like it's possible

Looks like it's possible

Awesome, I will add the standard config the project then.

The branch is ready for merge. I fixed most of the bugs I saw. I also added the rustfmt.toml (I generated a default one). I will open another issue with all the questions / points I had in mind (to be treated after this PR).


KeyPath [time] on object store tran is not indexed

when I perform the following scan:
let r = await db.tran.where(["time"]).between(2, 1000, true, true).toArray()
it will throw an Exception
KeyPath [time] on object store tran is not indexed
here is my implementation
let db=new Dexie('db'); db.version(1).stores({                                               tran:'time'             }); db.tran.put({"time":234});

Remove the square brackets because time is not a compound index.
let r = await db.tran.where("time").between(2, 1000, true, true).toArray()


manager.startDeviceScan not working on Android API 28

I am trying to get available Bluetooth  list of device near by or paired devices ... but scan neither giving any result nor any error.
I also tried to directly connect to device using MAC:ID that is also not working.. Please help thanks

Hi. Can you provide more information? Can you provide a piece of code where you are using the scan method?


API design choice: why not enable early stopping by default?

In scikit-learn https://github.com/scikit-learn/scikit-learn/issues/14303 we're considering enabling early stopping by default.
We're curious about why  you chose not to enable it by default in LightGBM, considering that early stopping is almost always useful in practice?
Thanks!

Hi @NicolasHug , interesting question! I'm the newest of the LightGBM team members, so I don't have the historical context for that decision. I think it would be best to have @guolinke or @StrikerRUS comment.
One thing I do know is that we require you to explicitly pass in your validation set if you want to take advantage of early stopping, So it's possible that we don't have it enabled by default because we wanted to give users finer control over the dataset they validate on than just saying "x% of rows, randomly held out".

I agree with @jameslamb .
As an ML model tool, we focus on the training/prediction.
Enable ES by default will need the data partition in our side, And I believe there are many partition methods for different tasks, implementing them is duplicated.
Another point is the consistency with ML domain knowledge and other tools.
The concept of the training set, validation set, and test set are the basic knowledge in ML domain, and most tools will distinguish them.
So I don't think to convert a user-passed training set to training set + validation set is a good idea.

Thanks a lot for your answers!


[ASTScope lookup] Fix backwards PatternBindingEntry::getSourceRange

PatternBindingEntry::getSourceRange uses the end of the initializer for the end of the range. But, if the initializer is a property wrapper, the initializer comes before the start of the PatternBindingEntry. Prevent the computation from using such an initializer.
The first commit adds a check on Decl::getSourceRange to ASTVerifier to ensure that the start is not after the end. This comment causes two tests to fail:

test/decl/var/property_wrappers.swift, and
test/SourceKit/CursorInfo/cursor_info_property_wrappers.swift.

Someday, we should extend the check to Exprs, etc., but that is a lot more work since their getSourceRange functions also produce backwards ranges, but that invariant is not needed for the ASTScope work.
The second commit fixes the source range computation for PatternBindingEntrys. In order to do so,  It changes the semantics of PatternBindingEntry:: getInitAsWritten to only return an initializer after the equals sign, and also renames it to getOrigInitAsWritten.
It also fixes a bug and extends the semantics of findOriginalPropertyWrapperInitialValue to return null if there is no wrapper instead of failing an assertion.
In addition to a fix being needed for ASTScope lookup, this fix will be needed to address part of rdar://53637494

@swift-ci please smoke test

@swift-ci please smoke test

@DougGregor When you review this, please check the comment at line 1411 in Decl.cpp. I assume that in the example given, Wrapper(stored: 17) static var x: Int, '17' is not considered an initializer. Otherwise, findOriginalPropertyWrapperInitialValue is still incorrect, as it returns null for this case. It occurs at test/decl/var/property_wrappers.swift:161. Thanks.

@swift-ci please clean smoke test os x platform

@swift-ci please smoke test

cc @harlanhaskins for adoption in textual interfaces

@swift-ci please smoke test

@DougGregor I think your concerns have been addressed. Did you want to give this PR another look before I merged it? TIA

@swift-ci please smoke test


chore: add controller-gen to tasks list and some order

The manifests wasn't a dependency for the uncommitted changes and
we added the controller-gen missing task, now the uncommitted has as
dependency the manifest and manifest controller-gen

The failing CI check is caused by the task manifest which creates artifacts in the repo directory making the uncommitted check fails:
$ task uncommitted
task: Task "controller-gen" is up to date
task: [manifest] dagger -s call -m github.com/sagikazarmark/daggerverse/kustomize@${DAGGER_KUSTOMIZE_SHA} edit --source config --dir default set image --image controller=ghcr.io/pppa-testing:dev/add_controller-gen directory export --path manifest-build

./plugin-barman-cloud/manifest-build
task: [manifest] dagger -s call -m github.com/sagikazarmark/daggerverse/kustomize@${DAGGER_KUSTOMIZE_SHA} build --source manifest-build --dir default export --path manifest.yaml

./plugin-barman-cloud/manifest.yaml
task: [uncommitted] GITHUB_REF= dagger -s call -m github.com/cloudnative-pg/daggerverse/uncommitted@${DAGGER_UNCOMMITTED_SHA} check-uncommitted --source . stdout
Error: response from query: input: container.from.withExec.withExec.withMountedDirectory.withWorkdir.withExec.stdout resolve: process "check_uncommitted_git_changes" did not complete successfully: exit code: 1

Stderr:
INFO checking for uncommitted git changes
ERROR found uncommitted changes
task: Failed to run task "uncommitted": exit status 1

$ git status --porcelain
?? manifest-build/
?? manifest.yaml


Feature Request: Collection Object/Collecting Event Locality Masking Enable/Disable Functionality

When I database a specimen (creating a collection object and a collecting event) that has sensitive locality information (such as locations of caves or endangered species), then I need an option somewhere to enable/disable that information ever leaving the private database. E.g. that data should never go out to GBIF or any export without EXPLICIT admin permission.
This could be on collection objects or collecting events, or both. Not sure which is best.
Use case: I have a specimen collected in a sensitive cave location. That information should never leave our database without admin permission. Only some information should go to aggregators.
Needed soon with upcoming improvements to exporting TaxonWorks CO data.

All row objects have is_public booleans (if they don't, we can add).   Is suspect we shoudl treat this as an annotation and add to the radial annotator.

@tmcelrath I do not mind this feature, but my question is, what is the benefit of having protected information in the database at the first place? The specimen is know, it has an identifier, would it be enough to enter the Country and State information? If really needed, the note field could be used (which is not supposed to go to GBiF.

@proceps Benefit would be the ability to give that data specifically to certain stakeholders (e.g. DNR, federal agencies, etc...). That data is valuable, but it shouldn't be publicly available from general exports. As a collection manager I want to be able to give that data out on a case-by-case basis, and be able to filter those records.

Recently brought up by Ed DeWalt, who also needs this ASAP for some imperiled freshwater insect species.


ames: factor out stun implementation and basic de/serialization functions

This PR factors out a couple small modules from ames, in anticipation of merging in the directed messaging driver. Built on top of (and targeting) #639.

For posterity
@ripperi noticed that having a fakezod and a fake planet up on the same machine on any commit after e135995ba2aac27424b5b4c230c635af00a0cac7 would cause both ships to be at 100% cpu on the king. They were sending stun requests to eachother at full blast for some reason. It is unclear why this PR fixes the issue, but it does.


test: Add a post-install test for checking if the service-serving CA bundle has been properly mounted.

We're now responsible for ensuring the contents of this service-serving CA bundle are distributed to our operands instead of that CA bundle being automatically injected by a controller in the cluster. As part of that change, we create a ConfigMap with the service.beta.openshift.io/inject-cabundle="true" annotation, and we mount the service-ca.crt in the /var/run/configmaps/service-ca-bundle path in the various operand containers.
This adds a post-install check that verifies that container is present and this type of test can be further iterated on to ensure that all operands Pods (and their corresponding containers) have this CA bundle present, and that CA bundle matches what we expect.

That was strange
/retest

/retest


Add variable block to example and fix spelling mistake

Hey folks, I stumbled on this today and decided to give it a try.
I'm running Ubuntu 18.04 in WSL2 (terraform 0.14.4) and without the variable block for hcloud_token it won't accept it from env. This tidies up the example so you can copy and paste the code and get up and running quicker. Also I've included a simple spelling fix for Hetzner.

Here's an example of it failing:
mbell@DESKTOP-R9CS386 [12:14:58] [~/Projects/terraform-hetzner]
-> % echo $TF_VAR_hcloud_token
my token is here honestly
mbell@DESKTOP-R9CS386 [12:16:58] [~/Projects/terraform-hetzner]
-> % terraform plan

Error: Reference to undeclared input variable

  on main.tf line 15, in provider "hcloud":
  15:   token = var.hcloud_token

An input variable with the name "hcloud_token" has not been declared. This
variable can be declared with a variable "hcloud_token" {} block.

Error: Reference to undeclared input variable

  on main.tf line 26, in module "cluster":
  26:   hcloud_token = var.hcloud_token

An input variable with the name "hcloud_token" has not been declared. This
variable can be declared with a variable "hcloud_token" {} block.

Here's an example of it failing:
mbell@DESKTOP-R9CS386 [12:14:58] [~/Projects/terraform-hetzner]
-> % echo $TF_VAR_hcloud_token
my token is here honestly
mbell@DESKTOP-R9CS386 [12:16:58] [~/Projects/terraform-hetzner]
-> % terraform plan

Error: Reference to undeclared input variable

  on main.tf line 15, in provider "hcloud":
  15:   token = var.hcloud_token

An input variable with the name "hcloud_token" has not been declared. This
variable can be declared with a variable "hcloud_token" {} block.

Error: Reference to undeclared input variable

  on main.tf line 26, in module "cluster":
  26:   hcloud_token = var.hcloud_token

An input variable with the name "hcloud_token" has not been declared. This
variable can be declared with a variable "hcloud_token" {} block.


Smart plug exposed as Switch_1 to Homekit

Is there a way to use a more meaningful name for the devices?
My smart Wi-Fi plug has two channels, I get only power switch/relay exposed to homekit. "countdown_1" is not exposed perhaps due to unsupported type in homekit.
The problem is switch is named as "switch_1". Is there a way to name it more user friendly way?
Also if I install another plug, is it going have the same name?
Third problem, Siri doesn't know what "switch one" is he says "sorry I wasn't able to do that"
Nothing shows in the logs as expected.
I should be able to do this in the project
It is not possible to edit the assigned name. May be, in the device details form,  another attribute "user assinged name" which defaults to system specified name and can be changed to any other name needed.
P.S. Same plug gets exposed to Alexa as "Man Cave" and I can control it without any issues.
Please see the screen shot attached

I’ve renamed the plug in the home app, all good 😃


Connecting diskover-web to AWS ElasticSearch

When trying to connect diskover-web to an AWS elasticsaerch cluster I am getting the error messages below.
In 'Constants.php' I've set the ES_HOST to my VPC endpoint, and can successfully get a curl request back from the endpoint from the instance (to rule out security group issues). ES_PORT has been set to 443.
I also have AWS = TRUE
Am I missing something simple?
PHP Fatal error:  Uncaught Elasticsearch\Common\Exceptions\NoNodesAvailableException: No alive nodes found in your cluster in /home/ubuntu/diskover-web/vendor/elasticsearch/elasticsearch/src/Elasticsearch/ConnectionPool/StaticNoPingConnectionPool.php:51
Stack trace:
#0 /home/ubuntu/diskover-web/vendor/elasticsearch/elasticsearch/src/Elasticsearch/Transport.php(72): Elasticsearch\ConnectionPool\StaticNoPingConnectionPool->nextConnection()
#1 /home/ubuntu/diskover-web/vendor/elasticsearch/elasticsearch/src/Elasticsearch/Transport.php(90): Elasticsearch\Transport->getConnection()
#2 /home/ubuntu/diskover-web/vendor/elasticsearch/elasticsearch/src/Elasticsearch/Connections/Connection.php(240): Elasticsearch\Transport->performRequest('HEAD', '/', Array, NULL, Array)
#3 /home/ubuntu/diskover-web/vendor/react/promise/src/FulfilledPromise.php(25): Elasticsearch\Connections\Connection->Elasticsearch\Connections\{closure}(Array)
#4 /home/ubuntu/diskover-web/vendor/guzzlehttp/ringphp/src/Future/CompletedFutureValue.php(55): React\Promise in /home/ubuntu/diskover-web/vendor/elasticsearch/elasticsearch/src/Elasticsearch/ConnectionPool/StaticNoPingConnectionPool.php on line 51

The diskover bot/crawler can communicate with ElasticSearch, it is only the web portion having trouble.

https://github.com/jeskew/amazon-es-php/pull/10
I'm launching an AWS ES cluster that is on 5.3 instead of 5.5 to see if the above issue is the cause.

Just an update on 5.3 vs 5.5 on AWS ES. Still received the same eror.

Getting the exact same error here.

I just started testing this bug and it looks like it's related to setting ES_PORT to 443 in Constants.php, setting to 80 fixes this on my test instance of ES 5.5 on AWS.

@DustinHolden and @hyattdrew11 , is this working for you now with aws?


feat(Azure): Support version beta of MSGraph API

Context
In most of checks Entra service needs to use the version beta of the MSGraph API.
Description
The service support a list of clients, specifications of which version on Entra service, and change some checks
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

This PR will be keep in draft until a "beta" endpoint must be necessary for any check


Allow method calls (namely sig) to be between docs and the object they're documenting

This motivation behind this is primarily introducing better support for using YARD documentation alongside Sorbet type signatures. These are specified by a sig call before the method's definition.
Currently the YARD documentation must go in-between the sig and definition, which feels awkward.
Steps to reproduce
Generate docs for these two snippets:
sig { returns(String) }
# This is a method.
# @return An example string.
def example
  "Foobar"
end

# This is a method.
# @return An example string.
sig { returns(String) }
def example
  "Foobar"
end

Actual Output
The first snippet generates the documentation fine. The second snippet generates no documentation for example and prints:
[warn]: in YARD::Handlers::Ruby::DSLHandler: Undocumentable method, missing name
        in file 'test.rb':3:

        3: sig { returns(String) }

Expected Output
Both snippets should generate documentation for example.
Environment details:

OS: Ubuntu 18.04
Ruby version (ruby -v): ruby 2.5.1p57 (2018-03-29 revision 63029) [x86_64-linux-gnu]
YARD version (yard -v): yard 0.9.20
Relevant software dependency/versions:

Sorbet typechecker 0.4.4254

I have read the Contributing Guide.

I think supporting this would belong in a plugin since Sorbet is not yet a Ruby standard. Fortunately, here's a quick little YARD extension you can use to add support:
# place in something like `yardext/sorbet.rb`
module YardSorbet
  class SigHandler < YARD::Handlers::Ruby::Base
    namespace_only
    handles method_call

    process do
      case statement.jump(:ident).first
      when "sig"
        extra_state.sorbet_signature_docstring ||= ""
        extra_state.sorbet_signature_docstring += statement.docstring
      else
        extra_state.sorbet_signature_docstring = nil
      end
    end
  end

  module SigStopHandler
    def process
      super
      extra_state.sorbet_signature_docstring = nil
    end
  end

  module SigDefHandler
    def process
      return unless extra_state.sorbet_signature_docstring

      statement.docstring = [
        extra_state.sorbet_signature_docstring,
        statement.docstring
      ].join("\n")

      super
    end
  end

  YARD::Handlers::Ruby::ClassHandler.include SigStopHandler
  YARD::Handlers::Ruby::ModuleHandler.include SigStopHandler
  YARD::Handlers::Ruby::MethodHandler.include SigDefHandler
end

Run with
yard -e yardext/sorbet.rb

Or add -e yardext/sorbet.rb to your .yardopts file.
You could turn this into a gem if you are interested, say, yard-sorbet, at which point you (and others!) could gem install yard-sorbet and use it via yard --plugin sorbet
A nice addition to this would be to parse out the sigs and add YARD param/return type decorations to docstrings-- fairly easy to do given the above base code. That would allow the sig { returns(String) } stuff to get documented as a @return [String] tag. You could even interleave into existing docs so as to allow the following to work:
# @param value the value to reverse
# @return the reversed string
sig { params(value: String).returns(String) }
def reverse(value); end

But I will leave this as an exercise for the reader 😊.

Thank you! I'll give this a try when I can.

A nice addition to this would be to parse out the sigs and add YARD param/return type decorations to docstrings-- fairly easy to do given the above base code. That would allow the sig { returns(String) } stuff to get documented as a @return [String] tag.

I've been doing almost exactly the opposite of this recently, where the sig calls are generated from the YARD documentation: https://github.com/AaronC81/sord


Travis on mac

Trying to get travis working for mac

Pull Request Test Coverage Report for Build 400

0 of 0   changed or added relevant lines in 0 files are covered.
8 unchanged lines in 3 files lost coverage.
Overall coverage increased (+0.4%) to 55.868%

Files with Coverage Reduction
New Missed Lines
%

goodman_pipeline/core/check_version.py
1
87.5%

goodman_pipeline/core/core.py
3
66.64%

goodman_pipeline/core/tests/test_check_version.py
4
71.43%

Totals

Change from base Build 392:
0.4%

Covered Lines:
2197

Relevant Lines:
3610

💛  - Coveralls

It is working now but I'm not convinced this should be merged, because it is not clear to me yet how to test several versions of python.I'm copying ideas from specutils' setup.


feat: restart-safe deploys

Right now, if the deploy script throws at any point in the process, you have to restart from zero
Thus far, the deploy script has been prone to some instability due to

RPC endpoint rate limiting the code (hard to fix)
too slow gas price or too low gas limit set in overrides (fixable by hard-coding high values, though this kinda sucks in production)
And a myriad of other potential developer errors or ephemeral problems like internet or network instability

It would be dope if you could re-run the deploy script when it fails and it would pick up where it left off

Another thing about this is: we'd need to add checks for each governance tx to check on-chain whether they have been run yet & only attempt them if they have not been run yet

Another thing about this is: we'd need to add checks for each governance tx to check on-chain whether they have been run yet & only attempt them if they have not been run yet

i did this! :)

write the config to a local file every time a new contract is deployed, so if the script throws, it has stored all of the successful deploys

wait actually.. instead of cacheing after each contract deploy, is it literally as simple as

add a try/catch block around the contents of deployAndRelinquish
if it throws, cache the config in the catch block, then throw the error again?

@prestwich referred to this in TODO list in his PR #15

this could also be done with .catch blocks on promises


Copier does not create .copier-answers.yml in Azure repos  and .rej files while copier update

Describe the problem

Copier does not create .copier-answers.yml in Azure repos while clone project using copier  and .rej files while copier update
Template

To Reproduce

Run copier ...
run copier azure-repo-url
3..copier-answers.yml is not creating
run copier update - .rej file not creating

Logs

Expected behavior

It should create .copier-answers.yml in repo and .rej file when we are running copier overwrite
Screenshots/screencasts/logs

Environment

OS:  Windows
Copier version: <!-- copier --version output --> latest
Python version: 3.10
Installation method:

Additional context

I haven't added {{_copier_conf.answers_file}} previously in template repo
problem is solved now

Related to #983.