Type annotations for Approximations

Where?
Currently, the approximations module of SyMPC does not have type annotations.
The following are the files with missing type annotations:

[ ] exponential.py
[ ] log.py
[ ] reciprocal.py
[ ] sigmoid.py
[ ] softmax.py
[ ] tanh.py
[ ] utils.py

Hi I would like to contribute to this. Note that this is my first time contributing to a open source project.

Sure @rhit-namburs , go for it :+1:

@rhit-namburs  are you still working on it?

Hi! I am not sure if @rhit-namburs is still working on this issue so I decided to take a look.
I noticed that softmax.py and tanh.py are already annotated, so I decided to follow their approach. However, this leads to a circular import issue:

sympc.tensor.mpc_tensor.py imports APPROXIMATIONS from sympc.approximations, which includes func = (sigmoid.py, log.py, exponential.py, reciprocal.py, utils.py).
softmax.py and tanh.py import MPCTensor from sympc.tensor to be used for the type annotations. If we do the same for func we go into a loop of imports.

Without restructuring both sympc.approximations folder and MPCTensor class, I think the easiest way to go around this issue is to use TypeVar from typing to define an MPCTensor annotation. I tested and this solution passes the pre-commit tests.
Another possible solution could be to include the approximation functions defined in  sympc.approximations folder inside MPCTensor class.


Replies through status not working

If the whatsapp number posts a status and users send reply to the status the reply is not been picked by the bot

@impozzible I've never really used the status feature. Can you share screenshots of the process in Whatsapp web please. Thanks

This has been fixed in latest version of wa-automate


appropriate use of the container type than std::vector in explaining ellipsis placement for function parameters

n the section "More about ellipsis placement"
Can we use std::map or std::tuple as a container instead of std::vector? Because std::vector<Types...> does not make sense as a vector is of a single type element (unless used abstraction type std::variant).  It could be that Allocator is the 2nd type among Types for vector, but not so trivial to assume for this simple example.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 516af34c-0d41-3ee3-2df1-e7d68eb17325
Version Independent ID: 05d065d1-8cd4-d2b4-cbcb-4a68df79123c
Content: Ellipsis and Variadic Templates
Content Source: docs/cpp/ellipses-and-variadic-templates.md
Product: visual-cpp
Technology: cpp-language
GitHub Login: @corob-msft
Microsoft Alias: corob

Thank you for your patience as we work through our backlog. We have received more issues than we can manage at this time. We are closing issues based on their severity, how broadly applicable they are, and whether there is enough information provided to act on the issue. If you believe that this issue should not have been closed, please add a comment explaining why by 3/8/2024. We appreciate your contribution and encourage you to propose changes using public PRs, or submit feedback through our updated control at the top of the page, as we phase out Git Issues for this repo. For more information on our feedback systems, see https://aka.ms/ContentUserFeedback.


Adds a Plugin GUI

Will close #373 when it is completed :slightly_smiling_face:

This should be good to go :slightly_smiling_face:

Here's a build for any testing: https://github.com/FireML/EvenMoreFish/releases/tag/gui-testing


build is failing according to the readme badge

The badge is green for me. Probably you have been receiving a cached version of it.
Although the badge is never the source of truth. The latest builds in Travis are green: https://travis-ci.org/github/geopy/geopy/builds


bad bucket error after running rippled.

$ sudo ./build/rippled
2015-Sep-04 03:03:24 LedgerConsensus:WRN
{
"accepted" : true,
"account_hash" : "A21ED30C04C88046FC61DB9DC19375EEDBD365FD8C17286F27127DF804E9CAA6",
"close_time" : 494651010,
"close_time_human" : "2015-Sep-04 03:03:30",
"close_time_resolution" : 30,
"closed" : true,
"hash" : "997AE030AA5366E5FCA28143AD23947C9DA00454E64419B7ACF192E03303FC66",
"ledger_hash" : "997AE030AA5366E5FCA28143AD23947C9DA00454E64419B7ACF192E03303FC66",
"ledger_index" : "2",
"parent_hash" : "AB868A6CFEEC779C2FF845C0AF00A642259986AF40C01976A7F842B6918936C7",
"seqNum" : "2",
"totalCoins" : "100000000000000000",
"total_coins" : "100000000000000000",
"transaction_hash" : "0000000000000000000000000000000000000000000000000000000000000000"
}
2015-Sep-04 03:03:24 LedgerConsensus:WRN Need consensus ledger 598E372381234D16C2002898484BFBCDE02C26E332B501B0C72E7648F55E698F
2015-Sep-04 03:03:26 NetworkOPs:WRN We are not running on the consensus ledger
2015-Sep-04 03:03:26 NetworkOPs:WRN We are not running on the consensus ledger
2015-Sep-04 03:03:26 NetworkOPs:WRN We are not running on the consensus ledger
2015-Sep-04 03:03:26 NetworkOPs:WRN We are not running on the consensus ledger
2015-Sep-04 03:03:26 NetworkOPs:WRN We are not running on the consensus ledger
2015-Sep-04 03:03:26 LedgerConsensus:WRN Need consensus ledger 598E372381234D16C2002898484BFBCDE02C26E332B501B0C72E7648F55E698F
2015-Sep-04 03:03:31 NetworkOPs:WRN We are not running on the consensus ledger
2015-Sep-04 03:03:31 NetworkOPs:WRN We are not running on the consensus ledger
2015-Sep-04 03:03:31 NetworkOPs:WRN We are not running on the consensus ledger
2015-Sep-04 03:03:31 NetworkOPs:WRN We are not running on the consensus ledger
2015-Sep-04 03:03:31 NetworkOPs:WRN We are not running on the consensus ledger
2015-Sep-04 03:03:31 NetworkOPs:WRN We are not running on the consensus ledger
2015-Sep-04 03:03:31 LedgerConsensus:WRN Need consensus ledger 0BB4835B2E4896563E4600D4065D535DA3CB8A338930FD3D02F9700120698E10
2015-Sep-04 03:03:34 LedgerTiming:WRN We see no consensus, but 80% of nodes have moved on
2015-Sep-04 03:03:34 ConnectionImpl:WRN WebSocket: rcvMessage
2015-Sep-04 03:03:36 NetworkOPs:WRN We are not running on the consensus ledger
2015-Sep-04 03:03:36 LedgerConsensus:WRN Need consensus ledger EFBE9907A8A49E5C78FFA1AB017478EC958F14065B832E93CB36284B76AB7947
2015-Sep-04 03:03:37 LedgerConsensus:WRN By the time we got the map F8B3A62B397EEFA6602B6C71DA69F4EC949C57B41D7DB74B610ECA2ED8B78CDA no peers were proposing it
2015-Sep-04 03:03:37 LedgerConsensus:WRN By the time we got the map 24811E49937C739DCEFE94901F2D612C0F9B16A9EC3CA83B6D362EDAC1E8AE32 no peers were proposing it
libc++abi.dylib: terminating with uncaught exception of type beast::nudb::store_corrupt_error: bad bucket size

Hmm...looks like a corrupted database

This definitely looks like a corrupted NuDB index file.

thanks, delete and resync, then has fixed.

@TOMOAKI12345 If there's a problem with your media then you'll get corruption again. You might check the disk or something.

@vinniefalco thank you for telling me about  the corruption.


feat(github): add pull request template

This pull request template describes the typical workflow each
pull request goes through. This just formalizes it so users and
core contributors have a checklist to go through when reviewing
pull requests.

my only suggestion is to make those items into sentences with correct grammar.

FWIW, my original reaction to PR templates was that they would be best used for providing a 'skeleton' that has fields for a contributor to fill in, instead of interrogatives. However, I'm fine with seeing how this works.
Also, this looks like it needs a rebase

@jchauncey suggestions on improvements? I tried to make the points as clear as possible while fitting on one line.
@arschles I share your concerns as well. I wanted to shake things out and see if we liked this way of contributing. However, the issue format for docker/docker leaves a bad taste in my mouth when submitting issues, so maybe this is overkill? Open to suggestions/killing this off

@bacongobbler I def don't think this is overkill and I'd love to get something like this in!
In case it helps illustrate what I was thinking, here's my proposal, adapted from the changes herein:
# Summary of Changes

# Issues that this PR Closes

# Associated [End To End Test](https://github.com/deis/workflow-e2e) PR(s)

# Associated [Documentation](https://github.com/deis/docs-v2) PR(s)

# Associated [Design Document](http://docs.deis.io/en/latest/contributing/design-documents.html#design-documents)(s)

# Pull Request Hygiene TODOs

- [ ] Your pull request is concise and to the point (make another PR for refactoring nearby code)
- [ ] Your commits are squashed into logical units of work
- [ ] Your commits follow the [commit style guidelines](http://docs.deis.io/en/latest/contributing/standards.html#commit-style)

It might be a little impersonal, so could add back some of the "thank you" sections...

I was just thinking capitalization and punctuation

@arschles needs more flowers :cherry_blossom:
In all seriousness that was I was trying to target, so thank you for the input. I'll rewrite the PR template to follow that template

I changed the template to follow deis/builder's example.

merging as this is a template that's not tested by CI.


stage2 - replace tmp.mount with tmpfs handling on bootup/activation

Things done

[ ] Tested using sandboxing (nix-build --option build-use-chroot true or nix.useChroot on NixOS)
Built on platform(s)

[ ] NixOS
[ ] OS X
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Fits CONTRIBUTING.md.

Fixes #14777 and #10670
Haven't tested yet. would love some help on how to do that =)
Built an ova. testing now~

I wonder why /tmp can't be a reulgar filesystem under fileSystems ? It's like we're reinventing all the options for it that are already available with fileSystems.

@lethalman We do not want /tmp to be subject to changes to configuration unless it is during stage-2. There is an open issue for this, #10670, but it doesn't explain why. Changing how /tmp is mounted without a reboot will hose programs which have written to /tmp.
You can do it yourself, via tmpOnTmpfs = false and a custom fileSystem entry, but doing it by default would violate the principal of least surprise. Especially since current documentation on /tmp suggests changes to how /tmp is mounted only happen at boot.

It seems I was the one who originally created the tmpOnTmpfs option. I just wanted a convient boolean rather than having to consult the mount man page for tmpfs options and define a mount outside of hardware-configuration.nix.
I am totally ok with taking this out of systemd's hands.

I agree with @lethalman that it would be nicer to handle this via fileSystems. The neededForBoot flag could be set automatically for /tmp to cause it to be mounted early (just as we do for /var, /nix etc.). Preventing /tmp from being mounted in a running system could probably be accomplished by dropping the dependency on tmp.mount in basic.target (I think that should be enough to stop switch-to-configuration starting it).

I agree with @lethalman that it would be nicer to handle this via fileSystems

Still on the fence as fileSystem changes are applied during switch-to-configuration (correct me if I'm wrong, please) where /tmp is a place we don't want that to happen.

Preventing /tmp from being mounted in a running system could probably be accomplished by dropping the dependency on tmp.mount in basic.target (I think that should be enough to stop switch-to-configuration starting it).

Good point, though i'm wary about messing with basic.target (since it's core systemd and not a nixos provided unit). basic.target has a whole special case for tmp.mount

FYI, this is what happens if using systemd to mount /tmp as tmpfs in this way

Any new thoughts on this? Possible candidate for inclusion in 16.09?

I've added this to the 16.09 milestone in the hopes that the issue gets resolved one way or another.

@sheenobu

Still on the fence as fileSystem changes are applied during switch-to-configuration (correct me if I'm wrong, please) where /tmp is a place we don't want that to happen.

Applying the configuration directly is what nixos-rebuild switch is supposed to do, though. The nixos-rebuild boot command can be used to set it up now but only activate the configuration on next boot. I think that if configuration changes can break the system, the system administrator should simply not use nixos-rebuild switch and should instead set the configuration to be activated on next boot. One rationale for this is that there are already plenty of ways to break things on a running system with nixos-rebuild switch.
Removing tmp.mount from basic.target isn't an elegant solution, but it's still more elegant than duplicating the options specifically for tmp, and without removing tmp.mount from basic.target I would still prefer the fileSystems approach, which will work just fine as long as nixos-rebuild boot is used instead of nixos-rebuild switch.

Note that this PR needs to be addressed in next days if it wants to reach 16.09

@sheenobu why was it closed?

@domenkozar it was an accident due to branch cleanup.

What is the status of this pull request?

Closing due to lack of activity, feel free to reopen this if needed.


On next update of RN, the Podfile will need to change

See: https://github.com/facebook/react-native/commit/db9c84480e3c95769fcfce5cd06a159229f8e946

We already do this https://github.com/artsy/emission/blob/3a920657e68dce5a9fc9a2a61affbe9c831144ed/Emission.podspec#L34.
We should probably experiment with the C++ version soon, though,


How to get the url by pathname?

With the put function we can upload a blob and return it with URL . But we must save it in a database?
If there is no database, how to retrieve the URL when we execute the del function?

As far as I understand, the only option besides saving in db is to use list method.

👋 @rwecho, if you don't store the URL's in a DB there is two ways to access your blobs.

use the list method like @yuriyyakym described. If you already know the pathname you could also send it as a prefix in the options object to narrow the response
construct the blob URL's yourself if you know the pathname. The URL schema is: https://<YOUR_STORE_ID>.public.blob.vercel-storage.com/<YOUR_PATHNAME>. Your can access the storeId like this: BLOB_READ_WRITE_TOKEN.split("_")[3] or in the Vercel Dashboard

Hi @luismeyer , if I put the blob with addRandomSuffix , it's conflicts with the method 2.

true. Than your only option is list.
closing this issue now, since it seemed solved


fix: broken test report on some systems

Tests would always be reported as skipped with the "not associated" message.
Not sure how to pinpoint the exact cause of this issue but it happens on my personal setup (WSL Arch with Windows Terminal Canary, if that helps).
go list output from log file before this change:
...
DEBUG | 2024-08-15T21:36:45Z+0700 | ...uddin/code/neotest-golang/lua/neotest-golang/logging.lua:47 | [neotest-golang] Running Go list: go list -json ./... in /home/miduddin/code/test_go
INFO | 2024-08-15T21:36:45Z+0700 | ...uddin/code/neotest-golang/lua/neotest-golang/logging.lua:59 | [neotest-golang] Go list output:  ]9;9;\\wsl.localhost\arch2\home\miduddin\code\test_go\{ "Dir": "/home/miduddin/code/test_go", "ImportPath": "localhost/testgo", "Name": "main", "Target": "/home/miduddin/.local/share/go/bin/testgo", "Root": "/home/miduddin/code/test_go", "Module": { "Path": "localhost/testgo", "Main": true, "Dir": "/home/miduddin/code/test_go", "GoMod": "/home/miduddin/code/test_go/go.mod", "GoVersion": "1.23.0" }, "Match": [ "./..." ], "Deps": [ "internal/abi", "internal/bytealg", "internal/byteorder", "internal/chacha8rand", "internal/coverage/rtcov", "internal/cpu", "internal/goarch", "internal/godebugs", "internal/goexperiment", "internal/goos", "internal/profilerecord", "internal/runtime/atomic", "internal/runtime/exithook", "internal/runtime/syscall", "internal/stringslite", "runtime", "runtime/internal/math", "runtime/internal/sys", "unsafe" ], "TestGoFiles": [ "main_test.go" ], "TestImports": [ "testing" ] }
INFO | 2024-08-15T21:36:45Z+0700 | ...uddin/code/neotest-golang/lua/neotest-golang/logging.lua:59 | [neotest-golang] Test command: go test -json -count=1 -race -timeout=10s /home/miduddin/code/test_go -run ^TestStuff$
...

After:
...
DEBUG | 2024-08-15T21:39:58Z+0700 | ...uddin/code/neotest-golang/lua/neotest-golang/logging.lua:47 | [neotest-golang] Running Go list: go list -json /home/miduddin/code/test_go/...
INFO | 2024-08-15T21:39:58Z+0700 | ...uddin/code/neotest-golang/lua/neotest-golang/logging.lua:59 | [neotest-golang] Go list output:  { "Dir": "/home/miduddin/code/test_go", "ImportPath": "localhost/testgo", "Name": "main", "Target": "/home/miduddin/.local/share/go/bin/testgo", "Root": "/home/miduddin/code/test_go", "Module": { "Path": "localhost/testgo", "Main": true, "Dir": "/home/miduddin/code/test_go", "GoMod": "/home/miduddin/code/test_go/go.mod", "GoVersion": "1.23.0" }, "Match": [ "/home/miduddin/code/test_go/..." ], "Deps": [ "internal/abi", "internal/bytealg", "internal/byteorder", "internal/chacha8rand", "internal/coverage/rtcov", "internal/cpu", "internal/goarch", "internal/godebugs", "internal/goexperiment", "internal/goos", "internal/profilerecord", "internal/runtime/atomic", "internal/runtime/exithook", "internal/runtime/syscall", "internal/stringslite", "runtime", "runtime/internal/math", "runtime/internal/sys", "unsafe" ], "TestGoFiles": [ "main_test.go" ], "TestImports": [ "testing" ] }
INFO | 2024-08-15T21:39:58Z+0700 | ...uddin/code/neotest-golang/lua/neotest-golang/logging.lua:59 | [neotest-golang] Test command: go test -json -count=1 -race -timeout=10s /home/miduddin/code/test_go -run ^TestStuff$
...

P.S. Also not sure if this is the best way to fix the issue, but it seems to work on my machine 😁
Any suggestions would be appreciated.

Updated the code for the failing test.

Hey @miduddin and thanks for this nice improvement!
I think it looks great and the only further improvement here would be to add some sort of error handling which would potentially notify about non-existing output or a failed command. But it's also something that can be added later, if really needed.
I was actually unaware of vim.system and I understand this is a somewhat recent addition (added in 0.10.0), as vim.fn.system now also recommends turning to this one instead. Given that this plugin was released under 0.9.x I believe this warrants a major bump as there's a chance someone is actually still on 0.9.x using neotest-golang. So I'll just edit your PR title and add the exclamation mark and make this a breaking major bump for clarity.
Many thanks for the addition! 👍


Helm chart

This PR will add an helm chart for fluxcloud.
It also supports helm repository automatic publishing to a github pages (thanks to this github action). In order to have this working an ACCESS_TOKEN should be added inside repository secrets as described here

Welcome @emmekappa! It looks like this is your first PR to justinbarrick/fluxcloud 🎉

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: emmekappa
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: justinbarrick
If they are not already assigned, you can assign the PR to them by writing /assign @justinbarrick in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Hi @emmekappa. Thanks for your PR.
I'm waiting for a justinbarrick member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

I suggest  1) that the configuration, at least the SLACK_URL, be placed in Kubernetes secret and 2) that you allow the user to pass in annotations for the deployment.
The latter will allow the use of tools like reloader to restart the pods if the secrets change.

hey @emmekappa we're continuing the development of his project here: https://github.com/topfreegames/fluxcloud Here's the reason for that #68.
We're happy to review your contribution there and help you to ship this feature.


Czech translation

Ping @pavelantolik.

Just for the record, here is the ideal way of working (for me, at least):

Fork the repository on GitHub;
Open a cz branch from gh-pages branch;
Copy index.md to cz/index.md;
Translate it. :)

Hi Hugo,
I've got the repository cloned to my laptop, but I'm still kinda new in GitHub (we use Subversion at work, so my relationship with GitHub so far has been "visitor only"). So I could use a little hint - what exactly does it take to "open a cz branch"? Don't wanna mess anything up :))

git checkout gh-pages && git checkout -b cz && mkdir cz && cp index.md cz/index.md
translate cz/index.md
git commit -am "added cz translation fixes #92"
git push origin cz
go to github and click the PR button.

Hope this is clear, feel free to ask if it isn't

Thanks Antoine for the heads up.
Adding to this, you have to know that when you create a new branch (git checkout -b <branch_name>), you are using the state of the current branch. That's why you have to put yourself on the gh-pages branch before creating your own, rather than master (which is empty).
More information here: https://github.com/HugoGiraudel/sass-guidelines/issues/96.

@HugoGiraudel hi, I will try translate the guidelines to Czech lang, If you want... :)
I can not see any work done - so pavelantolik probably did not start, right?

Hello. That's good news. I think it is safe to assume that you will be on
your own on this.
Le dim 17 mai 2015 13:16, Honza Bittner<EMAIL_ADDRESS>a écrit :

@HugoGiraudel https://github.com/HugoGiraudel hi, I will try translate
the guidelines to Czech lang, If you want... :)
I can not see any work done - so pavelantolik probably did not start,
right?
—
Reply to this email directly or view it on GitHub
https://github.com/HugoGiraudel/sass-guidelines/issues/92#issuecomment-102754593
.

@HugoGiraudel ok, cool. :)
Should I use shortcut for translate according to the Czech republic -> CZ (https://countrycode.org/czechrepublic) or for czech lang -> CS (http://en.wikipedia.org/wiki/List_of_ISO_639-1_codes)? :)

I think cz will be better.

cz sounds good to me.
Le dim 17 mai 2015 15:45, Даниил Пронин<EMAIL_ADDRESS>a écrit :

I think cz will be better.
—
Reply to this email directly or view it on GitHub
https://github.com/HugoGiraudel/sass-guidelines/issues/92#issuecomment-102769043
.

Here is my progress. Translation is probably not excellent, but I am going to improve it. :smiley_cat:

[x] About the author
[ ] Contributing
[x] Table of Contents
[ ] About Sass
[ ] Introduction
[ ] Syntax & formatting
[ ] Naming conventions
[x] Commenting
[x] Architecture
[ ] Responsive Web Design and breakpoints
[ ] Variables
[ ] Extend
[ ] Mixins
[ ] Conditional statements
[ ] Loops
[ ] Warnings and Errors
[ ] Tools
[ ] Too Long; Didn’t read

I am really looking forward to it! :)

Only 5, small, sections left. :)
Can I release (after that) something like 1.1.0-beta, which will may not have translated codes from _include/ and will may not have stunningly perfect translation?
... just to have it avaible as beta for impatient people? :smile_cat:

We cannot release a beta, and I am not willing to do so. However, I am perfectly fine to release the Czech version with English code snippets. We can translate them later on. :)

OK, no problem. :+1:

Great. :)

I am really like that I can translate this awesome guidelines, because I can learn a lot from both English and Sass. :smirk_cat:
Well, I think I am done. :+1:
// I have cheked all once again and I think and I hope it is OK. :smirk_cat:

Alright. Let me review it right now.

@HugoGiraudel is any chance to make my own IDs for headings? Czech have some extra characters English do not and it only make some babble, which is not so much semantic. :smirk_cat:

Nope. Not possible. Sorry.

So there are some task I want to make for next merge:

[ ] fix potential typo errors
[ ] fix links referring to headings
[ ] translate code snippets

Sounds good. :)

I'm sorry, but I had been on sumer camp and the rest of the time I have worked on a project. Now I am going to surgery, but I will try to finish this ASAP after I will be +- OK. :smile_cat:

I hope everything is fine. Take care!

I will continue with translations. 👍

Btw. @HugoGiraudel should I after translation will be done open PR to your master or gh-pages? Kind of do not know the difference in Jekyll. But other open PR to master so I should do the same?

E.g.  It’s obsolete. :)

@HoBi Do you need this issue to be open or can I close it?

@HugoGiraudel you can close it. I continue on traslation and updates on my forked repo and then i will do a pull request. :-)


Automate pypi deployment

Deploy to test.pypi.org and pypi.org automatically with every version tag. Get inspiration and search for filename:.travis.yml pypi.

https://github.com/ros-testing/hypothesis-ros/commit/46b5104adbca03dc4619807b2d0fd635100f89a5


GeoJSon doesnt show

Hi I got the following simple lines in my map (CORS restrictions are switched off in Chrome):
omnivore.geojson("stops.geojson").addTo(map);

But the markers do not show up.
If I add the markers as in
$.getJSON("stops.geojson",function(data){
    // add GeoJSON layer to the map once the file is loaded
    L.geoJson(data).addTo(map);
  });

they show up.
This is the Geojson data:
{"type": "FeatureCollection", "features": [{"geometry": {"type": "Point", "coordinates": [39.2796017, -6.8224933]}, "type": "Feature", "properties": {"previous_dominating_activity": "still", "bearing": 0, "route": null, "previous_dominating_activity_confidence": 60, "current_dominating_activity": "in_vehicle", "current_dominating_activity_confidence": 77, "timestamp": "2015-11-11T09:03:01+0300", "created_at": "2015-11-11 06:03:12", "feature": "passive_tracking", "id": 4, "speed": 0, "altitude": 0.0, "accuracy": 23.0}}]}

This GeoJSON is not valid:
"route": null, <"previous_dominating_activity_confidence": 60
               ^

i know. this had slipped in. Anyway it still doesnt work

Ok i did some more testing.
It works if I load the file from the web as in:
omnivore.geojson('https://raw.githubusercontent.com/rajanski/d2d_cc/master/stops_short.geojson').addTo(map);
but it doesnt work if I load  a local file
omnivore.geojson("stops.geojson").addTo(map);

Sorry, we're unable to debug problems that aren't reproducible on a website: local file access is not part of leaflet-geojson's scope. Running websites locally - with file access and not with a local server - breaks any guarantees of any libraries working. I'd recommend using a local webserver like python's.


API doc restructuring latest

--------------------------------------------------------------------------------------------------------------------

@hpohekar
I did the following:

I downloaded the html from the doc build
I go to the API ref - OK
Go to launcher - OK
Go to return types of launch_fluent - OK
Click on Solver - OK

All good to this point

In Solver page, I click on e.g., file, which takes me to the plain file property of Solver. Ideally, this want to link to the actual API objects. Are we able to establish those connections?

@hpohekar
I did the following:

I downloaded the html from the doc build
I go to the API ref - OK
Go to launcher - OK
Go to return types of launch_fluent - OK
Click on Solver - OK

All good to this point

In Solver page, I click on e.g., file, which takes me to the plain file property of Solver. Ideally, these we want to link to the actual API objects. Are we able to establish those connections?

API ref -> General - > Sessions -> session_solver -> Solver -> file -> class ansys.fluent.core.session_solver.Solver.file

---------------------------------------------------------
API ref -> Meshing -> meshing.tui -> meshing.tui.file -> class main_menu.file
In case of solver file is property and in case of TUI file is a class.  Same is case for datamodel.
Due to this difference inter sphinx mapping is not useful here hence we are not able to establish those connections.

@hpohekar
Here https://fluent.docs.pyansys.com/dev/api/solver/settings.html#ref-settings , the root object at the bottom of the page is no longer clickable as it was in previous versions. Also, in the html built in your branch. Do we no longer have any settings API doc?

@seanpearsonuk
Right, we have removed root due to it's nested structure.
To get above thing clickable we will have to use root without table structure and clickable return types because it takes huge time to generate docs for all nested classes.
settings are not deployed yet, we are resolving issues related settings because it is failing due to it's large size by giving parallel build error.

@hpohekar
Here https://fluent.docs.pyansys.com/dev/api/solver/settings.html#ref-settings , the root object at the bottom of the page is no longer clickable as it was in previous versions. Also, in the html built in your branch. Do we no longer have any settings API doc?

@seanpearsonuk
Right, we have removed root due to it's nested structure.
To get above thing clickable we will have to use root without table structure and clickable return types because it takes huge time to generate docs for all nested classes.
settings are not deployed yet, we are resolving issues related settings because it is failing due to it's large size by giving parallel build error.

If we only generated code for the settings that have proper help strings I bet it would be a bunch smaller.

@hpohekar
Here https://fluent.docs.pyansys.com/dev/api/solver/settings.html#ref-settings , the root object at the bottom of the page is no longer clickable as it was in previous versions. Also, in the html built in your branch. Do we no longer have any settings API doc?

@seanpearsonuk
We have enabled root and main_menu now.
the root object at the bottom of the page will clickable as it was in previous versions.

@hpohekar
Here https://fluent.docs.pyansys.com/dev/api/solver/settings.html#ref-settings , the root object at the bottom of the page is no longer clickable as it was in previous versions. Also, in the html built in your branch. Do we no longer have any settings API doc?

@seanpearsonuk
We have enabled root and main_menu now.
the root object at the bottom of the settings page will clickable as it was in previous versions.
https://github.com/pyansys/pyfluent/actions/runs/4240157867

@hpohekar OK, sounds good

Downloaded the documentation artifact and had a look:

The main landing page for the API reference has three headings, General, Meshing and Solver.  They are a bit big and should contain some descriptions of the content to which they link as they do on the current landing page.  The reference links on the right do not seem to be working for me, they just show up as gray boxes with "ref_general", "ref_meshing" and "ref_solver" contained within, clicking on them does not work.
When I click on General, Meshing or Solver on the main landing page it takes me to the corresponding sub-landing page.  These pages have the same issue.  No descriptive introductory content for the sub-modules, the reference links on the right are not working.
I see there is an 'rpvars' module.  Is that on purpose? I don't think we should document this.
The numpydoc strings do not always appear for the various classes and functions.  For instance, I cannot find this string in the generated doc: https://github.com/pyansys/pyfluent/blob/d24a562332300579a83c4f58be228c7e792c5fd7/src/ansys/fluent/core/scheduler/load_machines.py#L19
The title for the case reader section is "Use case reader" I think it should just be "Case reader".
The module documentation for the 'journal' module says "Module for maintaining journal.".  It's not quite proper grammar, should maybe be "A module for maintaining journals."
Another example of a docstring that does not appear: https://github.com/pyansys/pyfluent/blob/d24a562332300579a83c4f58be228c7e792c5fd7/src/ansys/fluent/core/quantity.py#L837

It seems the PR still needs a fair bit of tidy up... this is just what I spotted clicking through it for 5 min.

Downloaded the documentation artifact and had a look:

The main landing page for the API reference has three headings, General, Meshing and Solver.  They are a bit big and should contain some descriptions of the content to which they link as they do on the current landing page.  The reference links on the right do not seem to be working for me, they just show up as gray boxes with "ref_general", "ref_meshing" and "ref_solver" contained within, clicking on them does not work.
When I click on General, Meshing or Solver on the main landing page it takes me to the corresponding sub-landing page.  These pages have the same issue.  No descriptive introductory content for the sub-modules, the reference links on the right are not working.
I see there is an 'rpvars' module.  Is that on purpose? I don't think we should document this.
The numpydoc strings do not always appear for the various classes and functions.  For instance, I cannot find this string in the generated doc: https://github.com/pyansys/pyfluent/blob/d24a562332300579a83c4f58be228c7e792c5fd7/src/ansys/fluent/core/scheduler/load_machines.py#L19
The title for the case reader section is "Use case reader" I think it should just be "Case reader".
The module documentation for the 'journal' module says "Module for maintaining journal.".  It's not quite proper grammar, should maybe be "A module for maintaining journals."
Another example of a docstring that does not appear: https://github.com/pyansys/pyfluent/blob/d24a562332300579a83c4f58be228c7e792c5fd7/src/ansys/fluent/core/quantity.py#L837

It seems the PR still needs a fair bit of tidy up... this is just what I spotted clicking through it for 5 min.

@dnwillia-work  @seanpearsonuk
Yes sure. Until now we were focused on resolving all issues related to API doc generation and right now we are able to generate it successfully.
So now onwards we will focus on description, heading, titles, fonts etc.
Thank you.

@dnwillia-work
In CI we are generating only source code docs.
We can download the unified (Source code + datmodel + TUI + settings) doc artifact from here -
https://github.com/pyansys/pyfluent/actions/runs/4345969722
Thank you.


Service does not support eth_sign signatures.

When I hit the endpoint
https://safe-relay.rinkeby.gnosis.pm/api/v/safes/[address]/transactions/
using a signMessage transaction (instead of a signDigest) I'm getting the below error.
 {"signatures":{"0":{"v":["v should be 0, 1 or be in 27-28"]}}}

Based on this contract update, I expected this to work? Does the relayer need to be updated?
https://github.com/gnosis/safe-contracts/blob/development/contracts/GnosisSafe.sol#L264-L266

Development is not yet deployed to the networks and therefore not supported by the relay service right now. This will we added in the future.

This also fails for me when runningsafe-relay-service locally -- does the current development code support this?
How can I go about getting support for this in my local build? Need to build against these new features 🙏

Current development code does not support this

@andrewdamelio I added a quick fix for it to run it locally, you can use the issue-158 branch https://github.com/gnosis/safe-relay-service/tree/issue-158

We should check what types of signatures we want to support in the relay (I would only suggest EIP-712, eth_sign and on-chain signatures for now, the costs for EIP-1271 can vary quiet a lot which can be abused to drain the funds of our relay)

This feature is already in develop branch with the support of the new Safe V1.1.0 contracts 1c7b7a94974f527523f79ce944c02971d35b5256


Adding info on the new crdb_internal tables in v21.2.

Doc work for CRDB-2467
Doc work for CRDB-7561
Doc work for CRDB-394
Doc work for CRDB-6570
Adding information on using new crdb_internal tables for performance monitoring and troubleshooting.

This change is


Feature request - Add Linear Discriminant Analysis

Why is this not listed in the readme (maybe it's implicit)?


Add seperate settings for the Nether and the End

This has partially been implemented now using the dimensional black/whitelist, but I'd still like to look into per-dimension settings.

How would I use the black/whitelist? I've attempted putting multiple dimensions in the brackets, and nothing changed

huh, I think that should work; I'll check myself when I have the chance - the holidays kinda wreck my free time.

just tested it myself with
listMode = "BLACKLIST"
dimensionsList = ["minecraft:the_end", "minecraft:the_nether"]

and it works fine; are you using 1.2.0?


Request: add way to group todo output by violation

Right now, there's not a good way for users to figure out what linting violation to fix first. A team might want to fix a single rule across the whole code base, instead of fixing file-by-file.
It would be a nice DX to have an output that grouped by rule, or perhaps a quick summary that listed rules that were being violated and their count.

To add a bit more concrete detail, there are two workflows we're interested in supporting for our template linting strategy once we have TODOs in place:

We want to generate a list of all rules that are being silenced by the TODOs. This would allow us to prioritize which rules to fix.
Once we've decided which rule we're going to work on fixing, we want to be able to output to the console all failures of that type, ideally in a similar format to how they're displayed without TODOs (listing the file and outputting the line where the error occurs). This would allow us to work through the errors one by one and use that output to know when all failures of that type have been addressed.

So this isn't really a feature that'd be implemented in this library itself. This would be something that would be implemented in one of the consuming libraries (@scalvert/eslint-formatter-todo or ember-template-lint), as those libraries are responsible for how todos are used and output.
That said, it's possible to output todos ordered by due date desc. It would be a slightly different implementation for both, but we could keep them relatively in sync.

I'm going to close this in favor of opening issues in the respective consuming repositories.


Don't depend on version 3.1 of commons-httpclient

commons-httpclient version 3.1 has several known vulnerabilities.  The artifact is renamed for 4.x and should be used instead

Aye aye! I'll try to make some time in the near future to address this and some of the other issues!

I second the request. If it helps at all, the main issue you'll have with migrating will be with the HttpSecureProtocol class as the SecureProtocolSocketFactory class has been completely removed. I don't see anything resembling an alternative to it.


Icomoon font path

Hello @jpchateau. Thanks sharing this great plugin.
I'm trying to use it on a symfony project with webpack.
i used yarn to install interactiveimagejs
When i run the dev-server i have this error :
error  in ./node_modules/interactiveimagejs/src/scss/main.scss

Syntax Error: ModuleNotFoundError: Module not found: Error: Can't resolve './fonts/icomoon.svg' in '/var/www/deko/node_modules/interactiveimagejs/src/scss'

In src/scss/helpers/_variables.scss file, i found :
$icomoon-font-path: '../fonts' !default;
It seems it should be '../../fonts' to reach src/fonts folder
Or maybe i'm doing something wrong ?

Hi @BaztianZH!
Thx you for playing with the plugin! I am so sorry for the delay, did you find a workaround?
I did not get the time to test it in a symfony/webpack context yet. Do you use Webpack Encore?
I started a side project to test the plugin in diverse contexts (https://github.com/jpchateau/interactive-image-tester) and I would be glad to integrate a symfony workaround if needed.

Hello,
I did not manage to reproduce the problem you had using a fresh install of Symfony 5.1.2 with Webpack Encore. But I made a small guide to use the Interactive Image plugin with Symfony. Here it is : https://github.com/jpchateau/interactive-image-tester/blob/master/frameworks/Symfony.md.
I close the issue but if you have more info you can open a new one.
Thank you!


Ability to compute CV scores for additional objectives during automl search

Proposal

Accept list of objectives as input to automl. Validate them.
During CV, when we compute the primary objective score, also do this for each additional objective.

And we should probably save that info somewhere in _results

Add an API for accessing the resulting scores

We could add column(s) to rankings and full_rankings, simply ask users to access results to get that info, or expose a different API

This is closely related to #1111 (compute plots during CV). We should discuss these issues together when we agree on a plan.
@gsheni FYI

@dsherry it seems like we do compute additional objectives in AutoMLSearch as long as the user passes in objectives. They are stored in the automl.results dict, although they are nested. I included a screenshot.

The user can currently access all this information, so I'm not sure if this issue is necessary anymore?

There is some overlap between this issue (second bullet point in @dsherry 's proposal) and #1184

This is how you'd currently get the score of an additional objective on one CV fold
# iterate over cv data fold number and compute the mean
automl.results['pipeline_results'][42]['cv_data'][0]['all_objective_scores']['Log Loss Binary']

Conclusion from discussion:

We currently support what's needed for this issue. Will close
#1111 will track defining an API to access this kind of info, rather than asking users to dig through the results structure and do the math themselves


⚠ ClamAV has degraded performance

In 2bcd240, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 87 ms

Resolved: ClamAV performance has improved in 0495dbc.


_extensions.preferPreReleases doesn't seem to be working

Testing #138086
I toggled _extensions.preferPreReleases from true and false in my setting and this page doesn't seem to be changing at all.
I see the following while it's set to false:

Have you reload the window after changing the setting?

oh you're right I forgot to reload


Add liveness and readiness probes to proxies and discovery services

Add probes to the sidecars, ingress, egress, discovery services, etc.
Avoid serving traffic with incomplete configuration state.
Provides signals for horizontal scheduling

Also:

https://github.com/istio/pilot/issues/908

/assign

/close
dup of #1429

Issue moved to istio/istio #1472 via ZenHub


ENH: update package version

Hi! This is the friendly automated conda-forge-webservice.
I've started a version update as instructed in #33.
I'm currently searching for new versions and will update this PR shortly if I find one! Thank you for waiting!
Fixes #33

Superseded by #35


Can I set a border for the square area?

agree with this. Maybe can add the 4 corners for the border. Hi @ravi8x please consider this issue. Thanks.

Yes you can set the border to the camera in BarcodeReader class XML which is located in library file.


Deprecation warnings in Grade 6.0.x

The following deprecation warnings are showing up in Gradle 6.0.1:
Property 'environment' is not annotated with an input or output annotation.
Property 'executable' is not annotated with an input or output annotation.
Property 'workingDir' is not annotated with an input or output annotation.

There is also the following note:
 This behaviour has been deprecated and is scheduled to be removed in Gradle 7.0.

I no longer see these specific warning under Gradle 6.3. Since the properties mentioned are actually declared in Gradle own ProcessForkOptions, it may be resolved there and it is possibly not even fixable within the plugin itself.


FPS lag spike when switching subzones

While walking around in the world there is a lag spike whenever you change the subzone (when the name of the area pops up across the middle of the screen).
It's not much but it's a noticeable microstutter.
Noticed this while in stranglethorn with a LOT of quests, and most of the map is covered in dots, so that might be related.

After completing some quests around the world that I needed to hand in the lag disappeared,
I'm guessing it was some obscure quest with a "world drop" item that caused issues.
Not sure if there's any update checks on subzone changes, but that's my guess at least.
In general a non-issue unless another quest like that pops up (sadly I didn't write down the quests I completed).

I debugged the rendering pipeline and found that the addon might have been over-redrawn.
Since CodexMap:UpdateNodes() always draws all map markers (including map markers that are not in the current zone), what is the reason to redraw when switching zones?
the end of map.lua:
CodexMap:RegisterEvent("ZONE_CHANGED")
CodexMap:RegisterEvent("ZONE_CHANGED_NEW_AREA")
CodexMap:SetScript("OnEvent", function(self, event, ...)
	CodexMap:UpdateNodes()
end)

In addition, CodexMap:UpdateNodes() will be called multiple times even if I am standing still and there is no change in any of the quests. I don't understand why the rendering pipeline does this behavior. Does the map mark added by CodexMap.HBDP:AddWorldMapIconMap() disappear on its own after a while? If the answer is no, why does it need to redraw?

Redraws on zone change because the dots used to only be rendered in your current zone. I changed it to all zones recently and haven’t removed that trigger. If you want to make a PR for it, go for it. Im playing Classic atm so support for this addon is at an all time low.
Sent from Mail for Windows 10
From: 老虎会游泳
Sent: September 10, 2019 6:01 PM
To: project-classic/ClassicCodex
Cc: Subscribed
Subject: Re: [project-classic/ClassicCodex] FPS lag spike when switchingsubzones (#31)
I debugged the rendering pipeline and found that the addon might have been over-redrawn.
Since CodexMap:UpdateNodes() always draws all map markers (including map markers that are not in the current zone), what is the reason to redraw when switching zones?
the end of map.lua:
CodexMap:RegisterEvent("ZONE_CHANGED")
CodexMap:RegisterEvent("ZONE_CHANGED_NEW_AREA")
CodexMap:SetScript("OnEvent", function(self, event, ...)
CodexMap:UpdateNodes()
end)
In addition, CodexMap:UpdateNodes() will be called multiple times even if I am standing still and there is no change in any of the quests. I don't understand why the rendering pipeline does this behavior. Does the map mark added by CodexMap.HBDP:AddWorldMapIconMap() disappear on its own after a while? If the answer is no, why does it need to redraw?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Another over re-rending: the addon register NAME_PLATE_UNIT_ADDED and NAME_PLATE_UNIT_REMOVED but there are no processing branches defined for them.
So they will hit the else branch and set CodexQuest.updateQuestLog = true to cause redraw.
In an area where there are many NPC/players active, nameplate changes happen all the time.
CodexQuest:RegisterEvent("QUEST_WATCH_UPDATE")
CodexQuest:RegisterEvent("QUEST_LOG_UPDATE")
CodexQuest:RegisterEvent("QUEST_FINISHED")
CodexQuest:RegisterEvent("PLAYER_LEVEL_UP")
CodexQuest:RegisterEvent("PLAYER_ENTERING_WORLD")
CodexQuest:RegisterEvent("SKILL_LINES_CHANGED")
CodexQuest:RegisterEvent("QUEST_DETAIL")
CodexQuest:RegisterEvent("QUEST_PROGRESS")
CodexQuest:RegisterEvent("QUEST_COMPLETE")
CodexQuest:RegisterEvent("QUEST_GREETING")
CodexQuest:RegisterEvent("QUEST_REMOVED")
CodexQuest:RegisterEvent("GOSSIP_SHOW")
CodexQuest:RegisterEvent("NAME_PLATE_UNIT_ADDED")
CodexQuest:RegisterEvent("NAME_PLATE_UNIT_REMOVED")
CodexQuest:RegisterEvent("ADDON_LOADED")
CodexQuest:SetScript("OnEvent", function(self, event, ...)
    if event == "ADDON_LOADED" then
        arg1 = ...
        if arg1 == "ClassicCodex" then
            CodexQuest:AddQuestLogIntegration()
            CodexQuest:AddWorldMapIntegration()
        else
            return
        end
    elseif event == "PLAYER_LEVEL_UP" or event == "PLAYER_ENTERING_WORLD" or event == "SKILL_LINES_CHANGED" then
        CodexQuest.updateQuestGivers = true

    elseif (event == "GOSSIP_SHOW") then
        if not CodexConfig.autoAccept or IsControlKeyDown() then
            return
        end

        local activeQuests = {GetGossipActiveQuests()}
        local activeQuestCount = GetNumGossipActiveQuests()
        local availableQuests = {GetGossipAvailableQuests()}
        local availableQuestCount = GetNumGossipAvailableQuests()

        -- Turn in everything
        if activeQuests and not IsControlKeyDown() then
            for index = 1, activeQuestCount do
                if (activeQuests[(((index - 1) * 6) + 4)] == true) then -- Check if quest complete
                    SelectGossipActiveQuest(index)
                    return
                end
            end
        end

        if (availableQuestCount > 0 and not IsControlKeyDown()) then
            SelectGossipAvailableQuest(1)
            return
        end

        -- Auto Gossip Feature
        -- if not IsControlKeyDown() then
        --     SelectGossipOption(1)
        --     return
        -- end

    elseif (event == "QUEST_DETAIL") then
		if not CCTip then
			CCTip = QuestNpcNameFrame:CreateFontString("CCTip", "ARTWORK", "GameFontHighlight")
			CCTip:SetWidth(288)
			CCTip:SetHeight(55)
			CCTip:SetText("任务助手：打开世界地图(M)\n右上角下拉框可开关任务提示");
			CCTip:SetPoint("TOPLEFT", QuestFrame, "TOPLEFT", 55, -30);
		end
        if not CodexConfig.autoAccept or IsControlKeyDown() then
            return
        end

        AcceptQuest()

    elseif (event == "QUEST_PROGRESS") then
        if not CodexConfig.autoTurnin or IsControlKeyDown() then
            return
        end

        CompleteQuest()

    elseif (event == "QUEST_COMPLETE") then
        if not CodexConfig.autoTurnin or IsControlKeyDown() then
            return
        end

        if (GetNumQuestChoices() <= 1) then
            GetQuestReward(1)
        end

    elseif (event == "QUEST_GREETING") then
        if not CodexConfig.autoAccept or IsControlKeyDown() then
            return
        end

        local availableQuestCount = GetNumAvailableQuests()
        local lastAvailableQuest = 0
        local activeQuestCount = GetNumActiveQuests()
        local lastActiveQuest = 0

        if activeQuestCount > 0 then
            for index = 1, activeQuestCount do
                for questLogId = 1, 40 do
                    local title, _, _, header, _, complete = GetQuestLogTitle(questLogId)

                    if GetActiveTitle(index) == title and complete == 1 then
                        SelectActiveQuest(index)
                    end
                end
            end
        end

        if availableQuestCount > 0 then
            for index = 1, availableQuestCount do
                if not IsControlKeyDown() then
                    SelectAvailableQuest(index)
                end
            end
        end

    elseif (event == "NAME_PLATE_UNIT_ADDED") then
        if CodexConfig.nameplateIcon then
            CodexQuest:CheckNamePlate()
        end

    else
        CodexQuest.updateQuestLog = true
    end
end)

I will make changes based on my findings, I will initiate a Pull Request when I am ready.

I have made changes and created PR #33
If someone wants to try my fix right away, the addon package can be downloaded via the link below.
Must rename the directory to ClassicCodex, or the addon will not load.
https://github.com/SwimmingTiger/ClassicCodex/archive/master.zip


PR: Move the 'HeatCarrierFluid' class to a new module named 'materials'

The module materials will eventually holds codes for the ground, grout and pipes properties.

Hello @jnsebgosselin! Thanks for submitting the PR.

In the file pygld/__init__.py, following are the PEP8 issues :

Line 61:1: E402 module level import not at top of file
Line 62:1: E402 module level import not at top of file


grammar correction

What this PR does:
Which issue(s) this PR fixes:

Fixes # grammar correction
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

grammar correction

@jinfeijie thanks for your great work.


Wordsbatte resizing is not working for smaller screens

The flags are being cut off

Pushed fix. Kindly test.

I tried a different scaling approach. More responsive but the quality may diminish on smaller phones. Let me know how it looks.

Can you fix other bugs and we will test all in once?

I tested locally a little and the gnome disappeares after first wrong word

Okay. I will have them fixed in a bit including the others. Ill update you
soon.
Jabito
On Mon, 26 Mar 2018 at 12:06 PM Aleksey Sinyagin<EMAIL_ADDRESS>wrote:

I tested locally a little and the gnome disappeares after first wrong word
[image: image]
https://user-images.githubusercontent.com/16449461/37886454-5d2cc814-3070-11e8-828b-553ed3541721.png
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/seattleuser/DTML.Games/issues/9#issuecomment-376040821,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AJzgA0nRzXyPe-ggpkhEylxEucqUl3ncks5tiGlegaJpZM4S6O3x
.

I pushed the fix for this. I'm only having trouble with the response of the language API for vi. I'm decoding it as application/json and it is really distorted. I'm trying to look for a work around. In the meantime, I'll finish up family tree.
Let me know if there are issues with the updated game.

Attaching image.

It is not distorted it is encoded in Unicode. Browsers know how to render these. This of that as HTML. So, assume you are getting back not text but HTML and in your code instead of .text() use .html()


TextEdit (Node, not IDE) breakpoints not working, no breakpoint gutter

Godot version: 3.0.2 stable
OS/device including version: Ubuntu 17.10
Issue description:
Acording to http://docs.godotengine.org/en/latest/classes/class_textedit.html?highlight=textedit#signals :

breakpoint_toggled ( int row ): Emitted when a breakpoint is placed via the breakpoint gutter.

But the textedit node doesn't even seem to have a breakpoint gutter (it's enabled on the IDE but not on the node, or I can't seem to find its toggle).
Steps to reproduce:

Create new project, new scene, new TextEdit node with layout > full rect so you can try to place a breakpoint.
Add the following script to the node:

extends TextEdit
func _ready():
	show_line_numbers = true
	text = "Lore\nipsum"
	connect("breakpoint_toggled", self, "it_works")
func it_works(row):
	# Never called
	print("It works! Row: %d" % row )

Run, and try to place a breakpoint.

Minimal reproduction project: issuedemo.zip

Oh, it's just a matter of exposing TextEdit.set_draw_breakpoint_gutter(bool p_draw);.

Fixed by https://github.com/godotengine/godot/pull/18028


Remove windows.h inclusion from public headers

As of AWS C++ SDK 1.9, windows.h is being pulled in via aws/io/event_loop.h, which is causing lots of pre-existing code to suddenly pull in a bunch of ill-behaved Windows SDK macros such as #define GetMessage GetMessageA.
This pull request hides windows.h as an internal-only dependency, duplicating the Windows struct _OVERLAPPED layout into struct aws_win32_OVERLAPPED and adding a centralized type-cast function to avoid the proliferation of unsafe casts throughout the codebase.
This resolves https://github.com/awslabs/aws-c-io/issues/401

Merged in https://github.com/awslabs/aws-c-io/pull/454


NDRS-1000/Restrict private key permissions

This change ensures that private keys generated by the casper-client are only read/writeable by the owner. Since keys are commonly generated using root, they are protected against regular user access this way.
Note: The documentation needs to be updated to reflect this (keys need to be either generated as casper or chowned).

https://docs.casperlabs.io/en/latest/node-operator/setup.html would need to be updated with
sudo casper-client keygen /etc/casper/validator_keys
sudo chown -R casper:casper /etc/casper/validator_keys
```

Should we print an explicit warning after keygen that keys must have perms accessible to the user that casper-node is run as?

This change will also require third party docs to be updated. eg
https://github.com/make-software/how-to-casperlabs/blob/master/docs/ubuntu/setup-validator-from-scratch.md


Implemented bazel python version flags

I implemented python interpreter flags to make it easier to switch between Python2 and Python3 while developing.
I added two Bazel Interpreter rules in a BUILD file in the tools directory which points to the specific interpreter in the docker container that we use for development.
In order to run both test I had to update the ./configure.sh script aswell to download tensorflow with pip3 as well.
In the end I added a little description to CONTRIBUTING.md

Thanks, good work, Moritz.
But I'm afraid the requirements are too strict: developers have to install both python 2 (by default) and python 3, and the distribution must be in the specified location (/usr/bin/python, /usr/bin/python3). It might not make sense for all people, say, anaconda users.
As far as I known, there are at least two solutions:

Create py2 and py3 virtual environments (or docker images). Test them separately like what we do in the Continuous build.
Detect python bin location and let user choose which one to run:  https://github.com/tensorflow/tensorflow/blob/f089b3180ec7ddecd503d6d499cd6977c22b8f11/configure.py#L202

What do you think :-)

Yes this sounds really good.  The idea behind this was to have a flag to use inside our development container for quick and easy development. That’s why I placed the rules in the tool directory.

@seanpmorgan @facaiy how should we proceed? I really like the idea of detecting the current python2 and python3 env automatically.
Of course we could also setup multiple docker images. What would be the best way to do that?

Moritz, could you reply to Karmel's comments? And could you give more details of the idea of detecting the current python2 and python3 env automatically? I'm not sure if I understand it correctly :-)

I think the goal here is to have it so developers can quickly test py2 and py3 locally. Because our dev docker image has both we should be able to enable that, but this current implementation will break our CI. Maybe we could re-work this as a script run under something like tools/dev_testing/addons_py2py3_cpu.sh which runs the tests 2x. Or just as a separate script in tools/ci_testing?

Sounds great.
Are there any plans yet to have our own docker registry for multiple images?
When we have these up and running we could just do something like "docker run -rm tensorflow/tensorflow-addons-py3 "bazel test //...""   https://www.tensorflow.org/install/docker

We can run the same script in different images / virtual environments, it looks unnecessary to create a mixed script. If developers really need it, they can use two commands like:
docker run --rm -it -v ${PWD}:/addons -w /addons py2-image make unit-test
docker run --rm -it -v ${PWD}:/addons -w /addons py3-image make unit-test

We can run the same script in different images / virtual environments, it looks unnecessary to create a mixed script. If developers really need it, they can use two commands like:
# For docker
docker run --rm -it -v ${PWD}:/addons -w /addons py2-image make unit-test
docker run --rm -it -v ${PWD}:/addons -w /addons py3-image make unit-test
# For virtual environment
# change to python 2 environment
make unit-test
# change to python 3 environment
make unit-test

Yeah, I think that's just the more practical answer. Thanks for the contribution though Moritz, we could consider an addition to the CONTRIBUTING guidelines showing a succinct way to do this.


Support sub-directory for asset

fixes #246
Example1:
summary.set_out('/path/to/out')
summary.image(array, subdir='sub')

The image array will be put on /path/to/out/sub/image_xxxx.png
Example2.
summary.set_out('/path/to/out')
with summary.reporter(subdir='sub1') as r:
    r.image(array, subdir='sub2')

The image array will be put on /path/to/out/sub1/sub2/image_xxxx.png

I think that this feature is good.
But, this PR is not considered to input invalid value into subdir.
ex. subdir='', subdir='/', subdir='a/', subdir='a/b', subdir='..', ...

Chainer module, such as Trainer.out does not validate path phrase neither, I think subdir option would keep a step with it.


nixos-rebuild-ng: refactors

I was starting some preparation to port #347275 to nixos-rebuild-ng and realise that the usage of kwargs made the "API" really messy. This PR cleans-up by removing all usages of kwargs in nix namespace.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/5015


chore: split the inner tx creator in blockifier test utils

This change is

#661
#660  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ArniStarkware and the rest of your teammates on  Graphite

Merge activity

Sep 8, 3:01 AM EDT: @ArniStarkware started a stack merge that includes this pull request via Graphite.


failure on ruby trunk travis ci

r55970 passed, but
r55972 failed.
The change between these 2 revisions is actually r55971, and should not affect Linux.
Seems caused by<PHONE_NUMBER>5c3794fc80f5f234dc87874af79ad0, 641bc0158d40438aed2c6280ecf415c1d58a710c, a102ba3391e1a9be819097b75f7f3561f0246372, a26029ceac8f831f1bc5db56b5bfb1fa652bd96d.
Just-built ruby may need environment variables to load libruby shared library, and "system" ruby may not exist.

Thank you @nobu!
Sorry for the breaking change :/
These specs are quite fragile as they try to run ruby without any environment variable.
The fix is the right one, we might just need to pass some essential variables like $HOME on other rubies.


Allow user to specify default address pools for docker networks

This is separate commit on libnetwork to address PR https://github.com/moby/moby/pull/36054
Signed-off-by: selansen<EMAIL_ADDRESS>

@selansen looks like one test is failing:
--- FAIL: TestInitAddressPools (0.00s)
	utils_test.go:44:  Error IPAddress is missing in PredefinedBroadNetworks

Will correct it .
On Wed, Feb 7, 2018 at 12:03 PM, Deep Debroy<EMAIL_ADDRESS>wrote:

@ddebroy commented on this pull request.
Looks good. I have one comment on an error log pointed earlier. @selansen
https://github.com/selansen can you please check that?
In ipamutils/utils.go
https://github.com/docker/libnetwork/pull/2058#discussion_r166683118:

initNetworksOnce.Do(func() {

PredefinedBroadNetworks = initBroadPredefinedNetworks()

if defaultAddressPool != nil {

	if InitAddressPools(defaultAddressPool) != nil {

		logrus.Error("InitAddressPools failed to initialize default address pool")

@selansen https://github.com/selansen I don't see the error being
returned from InitAddressPool being printed in the log through
logrus.Errorf. The specific fmt.errorf() statements in InitAddressPool
does not print the error - they are creating the error object that the
caller should dump/process. The err should be passed to logrus.Errorf as
@ctelfer-docker https://github.com/ctelfer-docker suggested above,
right?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/docker/libnetwork/pull/2058#pullrequestreview-94786114,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AKEKn5QAjZFGW4L1Gek2ZCC5HYvZGVYRks5tSddOgaJpZM4Rjs_H
.

I tested this by replacing for loop with copy command. Will modify exiting
code with your suggestion.
On Wed, Feb 7, 2018 at 5:52 PM, Chris Telfer<EMAIL_ADDRESS>wrote:

@ctelfer-docker commented on this pull request.
In ipamutils/utils.go
https://github.com/docker/libnetwork/pull/2058#discussion_r166782837:

s := uint(bits - size)

list := make([]*net.IPNet, 0, n)

for i := 0; i < n; i++ {

ip := copyIP(base.IP)

addIntToIP(ip, uint(i<<s))

list = append(list, &net.IPNet{IP: ip, Mask: mask})

}
return list
+}

+func copyIP(from net.IP) net.IP {

ip := make([]byte, len(from))
for i := 0; i < len(ip); i++ {

ip[i] = from[i]

}

Just noticed this. The loop above could be replaced w/ copy(ip, from) for
what it's worth.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/docker/libnetwork/pull/2058#pullrequestreview-94901479,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AKEKn_AflDOd2EHJrMhVKhTmYPJ0w6Fsks5tSikkgaJpZM4Rjs_H
.

Fixed all Nit.
On Thu, Feb 8, 2018 at 6:24 PM, Abhinandan Prativadi <
<EMAIL_ADDRESS>wrote:

@abhi approved this pull request.
I have few nits. I guess there are some open questions from other reviewers
In ipams/builtin/builtin_unix.go
https://github.com/docker/libnetwork/pull/2058#discussion_r167095958:

@@ -41,3 +46,13 @@ func Init(ic ipamapi.Callback, l, g interface{}) error {

return ic.RegisterIpamDriverWithCapabilities(ipamapi.DefaultIPAM, a, cps)
}
+
+// SetDefaultIPAddressPool stores default address pool to local variable.
Nit: SetDefaultIPAddressPool stores default address pool (Its not a local
variable)
In ipams/builtin/builtin_unix.go
https://github.com/docker/libnetwork/pull/2058#discussion_r167097830:

@@ -41,3 +46,13 @@ func Init(ic ipamapi.Callback, l, g interface{}) error {

return ic.RegisterIpamDriverWithCapabilities(ipamapi.DefaultIPAM, a, cps)
}
+
+// SetDefaultIPAddressPool stores default address pool to local variable.
+func SetDefaultIPAddressPool(addressPool []*ipamutils.PredefinedPools) {

defaultAddressPool = addressPool
+}

+// GetDefaultIPAddressPool returns default address pool to the caller.
Nit: // GetDefaultIPAddressPool returns the default address pool
In ipams/builtin/builtin_windows.go
https://github.com/docker/libnetwork/pull/2058#discussion_r167098372:

@@ -55,3 +60,13 @@ func Init(ic ipamapi.Callback, l, g interface{}) error {

return initFunc(ic, l, g)
}
+
+// SetDefaultIPAddressPool stores default address pool to local variable.
+func SetDefaultIPAddressPool(addressPool []*ipamutils.PredefinedPools) {

defaultAddressPool = addressPool
+}

+// GetDefaultIPAddressPool returns default address pool to the caller.
same as above
In ipams/builtin/builtin_windows.go
https://github.com/docker/libnetwork/pull/2058#discussion_r167098770:

@@ -13,6 +13,11 @@ import (
windowsipam "github.com/docker/libnetwork/ipams/windowsipam"
)

+var (

// defaultAddressPool Store defaultAddressPool locally to use it during IPAM utils init

this comment doesn't make sense.
// defaultAddressPool is the default address pool
In ipamutils/utils_test.go
https://github.com/docker/libnetwork/pull/2058#discussion_r167098890:

@@ -24,3 +27,25 @@ func TestGranularPredefined(t *testing.T) {
}

}
+
+func TestInitAddressPools(t *testing.T) {
+
empty line
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/docker/libnetwork/pull/2058#pullrequestreview-95266488,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AKEKn_KTvt9w40RkYtrMCt71yRRvSjT_ks5tS4IagaJpZM4Rjs_H
.

You are right. we should initialize PredefinedGranularNetworks regardless
of InitAddressPool() success or not. I will correct it.
Thank you.
On Mon, Feb 12, 2018 at 11:35 AM, Chris Telfer<EMAIL_ADDRESS>wrote:

@ctelfer commented on this pull request.
In ipamutils/utils.go
https://github.com/docker/libnetwork/pull/2058#discussion_r167611914:

initNetworksOnce.Do(func() {

if defaultAddressPool != nil {

	if err := InitAddressPools(defaultAddressPool); err != nil {

		logrus.WithError(err).Error("InitAddressPools failed to initialize the default address pool")

	}

	return

}
PredefinedBroadNetworks = initBroadPredefinedNetworks()
PredefinedGranularNetworks = initGranularPredefinedNetworks()

I think this most recent refactorization changes the behavior of the code
from previous versions. Previously, if the default address pool was not
nil, the PredefinedGranularNetworks would still be initialized. However,
this code now does not initialize said pool if the default address pools
are non-nil, even if InitAddressPool() does not return an error. Is this
intended? Is the defaultAddressPool now supposed to supersede both Broad
and Granular network pools?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/docker/libnetwork/pull/2058#pullrequestreview-95855133,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AKEKn1ue04pV3GgD5BtX8II_WXik1hH8ks5tUGhUgaJpZM4Rjs_H
.


Update serverless.md

CosmosDB's advantage regarding connection pooling, is barely mentioned in the doc. This is an important consideration, especially for services like Azure Functions which may create a new connection per invocation. I've explained it in the doc to inform readers.

@markjbrown
Can you review the proposed changes?
Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

Thanks @azarboon for your suggestion.
While connection pooling is a feature of the SDK client it is not unique to a serverless account type. This section of our docs refers to use cases for Serverless. Mention of connection pooling is out of place in this passage.
@v-dirichards please close.

Closing as requested


docs/fix typo in developer strategy tutorial

Before submitting this PR, please make sure:

[ ] Your code builds clean without any errors or warnings
[x] You are using approved title ("feat/", "fix/", "docs/", "refactor/")

A description of the changes proposed in the pull request:
I believe that cd ~/hummingbot instance should be cd ~/hummingbot-instance in this example.
Tests performed by the developer:
Tips for QA testing:
Please confirm that this change is consistent with other parts of this tutorial.

Hello @29Takuya
The Hummingbot Foundation just started the governance process for the community to approve or reject Pull Requests through Pull Request Proposals.
For more information about how PRP votes work, check this page: https://hummingbot.org/governance/prp/
We want to know if you still have interest in having your Pull Request merged into the main codebase.
If so, please check the following on your Pull Request for our team to be able to open it for community voting:

Your Pull Request is targeted to the development branch
Your branch is up to date with the current development branch
All GitHub checks have passed
There is no merging conflicts

If you have any questions or need any help, feel free to reach us out on the #dev-general channel on our Discord (https://discord.gg/HAgZ79nzU4)

If you have no interest in merging this PR to our code-base or don't reply to this comment in 30 days, the Foundation team will close this PR.
You can still create a new PR any time you want!
Thank you for contributing to Hummingbot Client!

Hi @phbrgnomo,
Thank you for letting me know about the new governance process!
I confirmed that three out of four points are satisfied:

[x] Your Pull Request is targeted to the development branch
[x] Your branch is up to date with the current development branch
[ ] All GitHub checks have passed
[x] There is no merging conflicts

It seems that GitHub checks don't run on this PR since I am a first-time contributor.
Could you approve this?

Hi @phbrgnomo,
Thank you for letting me know about the new governance process!
I confirmed that three out of four points are satisfied:

[x] Your Pull Request is targeted to the development branch
[x] Your branch is up to date with the current development branch
[ ] All GitHub checks have passed
[x] There is no merging conflicts

It seems that GitHub checks don't run on this PR since I am a first-time contributor.
Could you approve this?

Thank you! I confirmed that all checks have passed.


Add support to filtering files on Resources Manager when type file name.

so it is more convient to search file.

This issue has already been reported. Please use the search function next time before reporting an issue and/or this time if you are curious about the progress of the issue.


Feat/e2e ci

Changes

feat: added CI for e2e tests

Points of discussion

Run on every push or PR? Each has its advantages, I am in favor of every push
How long should we store the test reports? They could build up over time if we decide to run on every push

Ideas for the future

Instead of building each time, we could utilize cloudflare pages to test

Important: This web-example PR needs to be merged before theses tests will pass, as they test against our wallet web-example

Fixed some bugs in test that were passing locally, but failing in CI
Should be good to go now @arein


topic search and add topic to user.interstes data

#34 closes this issue but need some fixes

later


refactor: remove codes enriching sprint_issues

Summary
fix #2027

remove columns: is_removed, added_date, removed_date, added_stage, resolved_stage from table sprint_issues
remove codes enriching sprint_issues from the current codebase.

Does this close any open issues?
close #2027
Screenshots

@narrowizard Please note that sprint_issues had been merged


Bug report: Non-existent command doesn't output an error

Description
Non-existent command o365 -auth identity doesn't output an error. It looks like it just silently fails.
Steps to reproduce
o365 -auth identity
Expected result
An output like this:
$ o365 -foo

  Invalid Command. Showing Help:
...
...

Actual result
No output.
Environment
Azure Cloud Shell
o365 version : 2.10.0

Thank you for reporting! We'll look into it

I can reproduce it but need to dig deeper what's causing this behavior. I'll update the issue as soon as I know more.

You also get invalid comment when you execute m365 --help, however m365 help doesn't.

Since we're working on removing Vorpal, which is what we're using internally for the CLI base functionality, and which is causing the issue, I'd say we park this for now and check if this issue is still there after we removed Vorpal.

I can confirm that issue is resolved in the branch related to removing Vorpal #1737. When we ship this version in preview beginning of October, we can double check that this issue is addressed as expected and close if ok.

This behavior seems to be corrected in the currently released preview version. Closing this issue as resolved. Thanks again for reporting @alexandair


COMMON.txt not found after pip install

Error
python -m ninethreesix.password
Traceback (most recent call last):
  File "/usr/lib/python2.7/runpy.py", line 162, in _run_module_as_main
    "__main__", fname, loader, pkg_name)
  File "/usr/lib/python2.7/runpy.py", line 72, in _run_code
    exec code in run_globals
  File "/usr/local/lib/python2.7/dist-packages/ninethreesix/password.py", line 63, in <module>
    p = Password(num_words=args.num, min_len=args.min, max_len=args.max)
  File "/usr/local/lib/python2.7/dist-packages/ninethreesix/password.py", line 36, in __init__
    self.content = self._words()
  File "/usr/local/lib/python2.7/dist-packages/ninethreesix/password.py", line 41, in _words
    content = open(word_list).read()
IOError: [Errno 2] No such file or directory: '/usr/local/lib/python2.7/dist-packages/ninethreesix/COMMON.TXT'

Debug
 ls /usr/local/lib/python2.7/dist-packages/ninethreesix/
__init__.py  __init__.pyc  password.py  password.pyc  tests.py  tests.pyc

ag vers  /usr/local/lib/python2.7/dist-packages/ninethreesix/
/usr/local/lib/python2.7/dist-packages/ninethreesix/__init__.py
1:__version__ = '0.1.0'

I pulled the latest tarball off of pypi and it doesn't seem to include the file:

Looks like maybe a package_data or data_files parameter within setup.py would help.  Not sure if the file is missing from the PyPI tarball because you forgot to git add it or if they left it out because of the setup.py config.

0.1.1 seems to work, thanks!
python -m ninethreesix.password

Lipari-white-Tiflis


Shielding parameter in the Damage_Modifiers section not work

Current/Expected Behavior
I tried setting the Shielding parameter both in the main plugin configuration under Damage_Modifiers and in the individual weapon configuration. When I set this parameter to -100% nothing happens and the damage stays the same even when using a shield, but when I set +100% the damage increases.
Steps To Reproduce

Log File

Anything else?
No response

please do testing next time. It works just fine, you just haven't set the modifier high enough

please do testing next time. It works just fine, you just haven't set the modifier high enough
Here's the config section with that setting and the damage through the shield still goes through.

  Damage:
    Base_Damage: 14
    Armor_Damage: 6
    Damage_Modifiers:
      Min: 20%   # Bullets will always do at least 20% of their base damage
      Max: 250%  # Bullets will, at a max, do 300% of their base damage
      Per_Armor_Point: -5%
      Enchantments:
        - projectile_protection -8%
        - protection -4%
      Head: +50%
      Body: +0%
      Arms: -20%
      Legs: -20%
      Feet: -50%
      Back: +20%
      Shielding: -100%


Add callbacks to asserts

added
I was under the impression that was the case, hence this PR. I've though looked again at the initial assertion and it turned out that the check is not explicit, but works the same way as Laravel's assertJson. Updated the documentation to represent that as well

Closing, as it's no longer needed.


[Mac] Window size is not saved, always opens full-screen

Here is an issue in the Electron project with recent fixes:
https://github.com/electron/electron/issues/526#issuecomment-1663959513

Thank you for reporting and providing the documentation. I'll plan on this for next release.


CARDS-1608: More helpful page displayed to non-patient users trying to access /Proms.html

To test:

log in as admin
open /Proms.html/

@marta- There's something I can't figure out, while the code is the same as on the 404 page, for some reason the 404 page has all the items center-aligned, while the invalid access page has the items left-aligned. If you can take a look and fix it, that would be great.

@marta- There's something I can't figure out, while the code is the same as on the 404 page, for some reason the 404 page has all the items center-aligned, while the invalid access page has the items left-aligned. If you can take a look and fix it, that would be great.

I didn't investigate too much, but looks like the styles for the Grid items are simply dropped. The simplest solution I can think of is to set textAlign center on the Paper, which will get propagated.

re-tested


Add java 17 to test cases

Codecov Report
Patch and project coverage have no change.

Comparison is base (2a6741e) 86.66% compared to head (ab0b780) 86.66%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #36   +/-   ##
=======================================
  Coverage   86.66%   86.66%
=======================================
  Files           3        3
  Lines         225      225
=======================================
  Hits          195      195
  Misses         30       30

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


LibraryImport Out string parameter?

I'm trying to figure out how to change something like RealGetWindowClass from DllImport to LibraryImport and not having much luck. Could we get some more details of this in the LibraryImport docs? StringBuilder is no longer supported but string, char[], and byte[] don't seem to work either.
[DllImport ( "user32.dll", SetLastError = true )]
internal static extern uint RealGetWindowClass ( nint hWnd, [Out] StringBuilder ptszClassName, uint cchClassNameMax );

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: a0b79232-1450-0aeb-b9d6-3a3c8234d148
Version Independent ID: 572c0b50-a28d-d387-1e8c-4a271615a753
Content: P/Invoke source generation
Content Source: docs/standard/native-interop/pinvoke-source-generation.md
Product: dotnet-fundamentals
GitHub Login: @jkoritzinsky
Microsoft Alias: jekoritz

You should use [Out] char[] for this case like the following:
[LibraryImport("user32.dll", EntryPoint = "RealGetWindowClassW", SetLastError = true, StringMarshalling = StringMarshalling.Utf16)]
internal static partial uint RealGetWindowClass(nint hWnd, [Out] char[] ptszClassName, uint cchClassNameMax);

Thank you. Is there a convention for how to call it? This is what I'm doing currently. It works but probably isn't optimal.
   char [] buffer = new char [ 255 ];
   uint length = RealGetWindowClass ( windowId, buffer, (uint) buffer.Length );
   string? className = ( new System.String ( buffer ) )?.TrimEnd ( '\0' );

That works, but this example below will be slightly more efficient:
char [] buffer = new char [ 255 ];
uint length = RealGetWindowClass ( windowId, buffer, (uint) buffer.Length );
string className = new string ( buffer, 0, (int)length );


FAQ

We should add a faq and or about page to the website.
It should include:

Why is it called Bill?
Is it oop?

Resolved.


Implementing proposed api of #3

So now we have 2 PRs. Thats non optimal but we will somehow manage it.
As discussed in #3 I proposed the following api:

zoom(level, point) - when called without an argument it returns the zoom (-level)
animate().zoom(level, point)
zoom(level) should use the center of the canvas as focus point as default
panZoom caculated a zoom lvl based on its factor and uses zoom to do the zoom - that could be a bit of overhead, though. Or it zooms just directly in lvls... dunno

This is now implemented in this branch.
Here is an example on how to use it:
var canvas = SVG('id').size(1500, 750).viewbox(1500,750)

// something we can see on the canvas
canvas.rect(1000, 500).move(250, 125)

// zoom in
canvas.zoom(2)

// reset zoom
canvas.zoom(1, new SVG.Point()) // defaults to 0,0

// animate zoom out
canvas.animate(1000, '<>').zoom(0.5)

// get current zoom level
var zoom = canvas.zoom()

// activate panZoom
canvas.panZoom()

The greatest pitfall of this impementation is, that you cant specify a focus point when animating the zoom. For this a few changes in the fx module are required which I want to discuss with @rmittro before. For now it always takes the default point which is the center of the canvas.

On the surface, this looks good. But I just tried on Android Browser 4.1, which is the oldest browser I need to support and neither zoom or pan worked. I'm debugging it right now. I suspect it has to do with prefixes.

Well - I did not intend to add workarounds for all this old browsers out there.
I would suggest that the user adds polyfills for the needed features but that's nothing the plugin should care about. It does everything the "standard" way :)

Yes you are right. I only meant to say, that I don't think it's anything serious. I'm just debugging, which is kinda hard on Android Browser.

Oh yes I feel you!

I think I found it. You're using the exponentiation operator which IFAIK not a standard until ES2017. I think we have to use Math.pow.

Right - looks like that happend by accident :D. Feel free to fix!

OK, I should be able to get this running today. Now I don't get any errors, but panning is reversed and pinch zoom doesn't work at all. Did you get it to run on a touch device and if yes, which one? I'm gonna create some Android Virtual Devices to debug this.

Yes I tested it with my android 6 with chrome as browser. The cyanogenmod standard browser wasn't able to handle it at all.
In chrome it was working as everyone would expect

So that is Android Marshmallow, API level 23, right?

No clue about the api level but marshmallow yes!

I want the zoom event to also fire when pinch zooming. I think to either make pinchZoom use zoom or fire the "zoom" event in pinchZoom.
Why do we need focusP in pinchZoom?

The focusPoint is the point between your fingers in which you zoom into. It can change when you pan while zooming. Thats why it becomes a bit tricky to calculate the corresponding matrix.
You translate the box to its origin, scale it and translate it back to the new focus point.
Beside this I have a new idea: I saw on many websites that use inline googlemaps, that they do not pan on touch drag. You have to use 2 fingers instead so it does not interefer with the normal scroll on the phone.
I like this idea a lot and would like to propose it. What do you think about that? We might consider it as an default behavior while hiding the touchdrag behind an option flag or removing it alltogether

Beside this I have a new idea: I saw on many websites that use inline googlemaps, that they do not pan on touch drag. You have to use 2 fingers instead so it does not interefer with the normal scroll on the phone.
I like this idea a lot and would like to propose it. What do you think about that? We might consider it as an default behavior while hiding the touchdrag behind an option flag or removing it alltogether

I think that is a great idea. If it is possible to implement the current touchdrag outside of the plugin, then I think that is the route to take. We don't have to implement every possible configuration but it is still possible to roll out your own implementation in user-land. Don't know if that is possible though.

In order to implement two finger pan, that implies that you can only pan if you pinch zoom, right?
We detect pinch zoom by counting touch events, if there is two, then we use the distance between these two to set the zoom level.
So while we don't get in conflict with the page scroll, we come in conflict with our own pinch zoom. Or am I missing something?

That's the thing I explained with the focus point. You can pan while you zoom already. So the implementation is already there. We just need to remove the touch drag

If it is possible to re-implement single-touch pan in user-land, then I'm all for it.
Let me see if we're missing something..

I think we shoulnt make a property public but instead fire zoomStart and zoomStop events. The user then can track it on its own.

Conceptually, you're right. But events looks very expensive, every time I profile this. And conceptually perhaps, harder to understand for a user, than just having a read only property. Hmmm... not sure.
Well, we have to pick one. I think we just go with events, that's how most things are communicated.

That's interesting. What exactly is expensive? Just firing events? Or the case that listener are bound to the event already?

Just realized that we need the normal pan for mouseinput. So the code stays. But it becomes a bit less confusing at least

I regret only have so little time for this. Every time I get back, I have to familiarize myself with the code and the design decisions and discussion. Now I really want to land this. I have a use-case where I need to pan-zoom a world map, display a mini map that can only pan (reflecting pan on the big world-map) and display  a title for each country on the map. The latter doesn't really have anything to do with svg.panzoom.js but it's a good use-case.
I will hack-a-way and make changes where needed. If we can land this the next few days - I'm a happy man :)

@Fuzzyma about firing events. It seems that Firefox, does a lot of string stuff - just when firing events. I will re-profile and post the result. It might be nothing, just something I've noticed.

Oh man, why do I never push my changes? I made thsi changes, too. Will merge when I am at home. I had no chance getting this finished yesterday

Sounds good. Let me know what you think. In the mean time I will implement zoomStart/zoomEnd and panStart/panEnd.

my work is pushed. Now do as you widh :).
I migrated to gulp. So run npm i && gulp for building.

@Fuzzyma thanks! Can you tell me why we're are return this.viewbox(box)? It seems that we're not using it for anything. Animation works fine without and wheelZoom does not return the value from zoom.

Just don't overcomplicate things :). Maybe we can merge this first and
create a new pr for the new stuff?
Am 06.06.2017 19:13 schrieb "Jon Ege Ronnenberg"<EMAIL_ADDRESS>
@dotnetCarpenter commented on this pull request.
In svg.panzoom.js
https://github.com/svgdotjs/svg.panzoom.js/pull/4#discussion_r120422154:

 return zoom

}

var zoomAmount = (zoom / level)

point = point || new SVG.Point(width/2 / zoomX + v.x, height/2 / zoomY + v.y)

var box = new SVG.Box(v)

 .transform(new SVG.Matrix()

   .scale(zoomAmount, point.x, point.y)

 )

if(this.fire('zoom', {box: box, focus: point}).event().defaultPrevented)

 return this

return this.viewbox(box)

That does not cover wheelZoom and programmable zoom. But I think we can
get away with only having one zoom event. I'll need to play with it a
little
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/svgdotjs/svg.panzoom.js/pull/4#discussion_r120422154,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADYGPv3MeSV9_9sH0CM6fW8BtpwFVkYbks5sBYiigaJpZM4NIp6P
.

Hmm.. I don't know if it's complicating things but a panStart and panEnd makes sense to have so that you can change appearance on the website. For completeness pinchZoomEnd also makes sense since we now have pinchZoomStart.
I want to change [].slice.call(ev.touches) to ev.touches since we don't need ev.touches to be an Array but any object that has index. We use [0] to access values. Is there any reason I'm not aware of that merit converting ev.touches to an Array?

@Fuzzyma One last thing. We should document SVG.Point. Especially because I reference it in the event documentation in the README

Yes SVG.Point should be documented. However, in the case of this plugin it's worth noting that the user don't really need svg.point. It's completely valid to pass an object with x and y property instead. So that's something you might want to notice, too.

To the ev.touches thing: I think the slice is not really needed. It's there for integrity so you have a real array in every case (so you can filter, map...) it
Btw is there a reason why you committed the package lock.json? I think this file does not belong into the repository

Yes, you're right. I'll update the README and merge this in, if's ok with you?

Please also read my other post before merging :)

package lock.json is there to be sure we have the same dependencies installed across systems. Similar to how yarn is meant to be used. You can look it up - the consensus is the always include it in version control, though in this project, it's hardly an issue that we don't have the exact same version of gulp and its dependencies.
Let's introduce [].slice.call() when we needed it and not before.
Is there anything else?

Imo lock files are great for projects but not for plugins and libraries. We gave our dependencies well defined in the package.json and we want allow the user to update svg.js if necessary. With a lock file you basically force him to one version.
Correct me if I am wrong. I was just a bit upset about this HUGE file
Nothing else from my side

Good point! removed...
I'll also squash the commits before merge....

manually merged


Delete chosen eco habit

As a registered logged in user I want to delete chosen eco habit so that I can track only actual for me habits.
Mockups:

Acceptance criteria:

Registered logged in user can delete habit in popup of "Add new habit" button only from "Already chosen" section, when it is already saved as chosen.

WHEN registered logged in user hovers on each habit from "Already chosen" section, it become active to delete, appears red "x" button in upper corner.

Registered logged in user cannot delete the last habit in "Already chosen" section.

WHEN Registered logged in user clicks red "x" button popup with the next options appears:
a. Text of popup "Are you sure you want to delete this eco habit?"
b. "Yes" button
c. "Cancel" button

WHEN Registered logged in user clicks "Yes" button, appropriate section with eco habit is removed from personal cabinet.

WHEN Registered logged in user clicks "Cancel" button, user see popup "New habit".

Not relevant.


Upgrade to v6 major

Fixes https://github.com/pulumi/pulumi-azuread/issues/1416
Adds an upgrade test for the application resource.
Migration guide
The property endDateRelative has deprecated in favor of endDate. If using endDateRelative with a custom startDate, calculate the endDate manually and this will avoid requiring replacement of the resource:

azuread.ApplicationCertificate
azuread.ApplicationPassword
azuread.ServicePrincipalCertificate
azuread.ServicePrincipalPassword

The following deprecated properties are being removed:

azuread.Application: applicationId removed in favor of client_id. This won't cause replacement.
azuread.ApplicationCertificate: application_object_id replaced with application_id. This will cause replacement.
azuread.ApplicationFederatedIdentityCredential: application_object_id replaced with application_id. This will cause replacement.
azuread.ApplicationPassword: application_object_id replaced with application_id. This will cause replacement.
azuread.ApplicationPreAuthorized: application_object_id replaced with application_id. This will cause replacement.
azuread.DirectoryRoleAssignment application_object_id replaced with application_id. This will cause replacement.

Some questions:

The property endDateRelative has deprecated in favor of endDate. This will cause replacement
If it's only deprecated and not removed, why does it cause replacement?

The application_object_id -> application_id rename should be a pretty straightforward state transform to spare our users the replacements. I understand the resources are all just metadata and should be quick to recreate, but GUIDs and passwords might change and cause disruption.

The application_object_id -> application_id rename should be a pretty straightforward state transform to spare our users the replacements. I understand the resources are all just metadata and should be quick to recreate, but GUIDs and passwords might change and cause disruption.

I've now tested this for ApplicationPassword and the upstream provider already appears to have a migration in place as long as the calculated endDate matches what the endDateReletive resolved to in relation to the startDate.

The application_object_id -> application_id rename should be a pretty straightforward state transform to spare our users the replacements. I understand the resources are all just metadata and should be quick to recreate, but GUIDs and passwords might change and cause disruption.

I've now tested this for ApplicationPassword and the upstream provider already appears to have a migration in place as long as the calculated endDate matches what the endDateReletive resolved to in relation to the startDate.

Good, but my comment you've quoted was about application_id, not endDate?

Good, but my comment you've quoted was about application_id, not endDate?

🤦 yes
Changed the test to test the applicationObjectId -> applicationId which is the critical one because it's actually being removed. Also, fixed the update of the source which was missing.
Also, having fixed the source edit step, the endDateRelative migration is actually not implemented yet, but the applicationObjectId is. I don't think this is a problem as the endDateRelative is still there for the time being, likely until the next major version, and it's likely a migration will be added upstream by then.

Upgraded bridge and codegen and rebased before release.