Run one process per linter

Fixes #167
From what I can tell, all linters now support multiple paths.
This PR removes the path handling and always executes one process per linter with all the paths.
This reduces the runtime of gometalinter of docker/cli from 100s down to less than 8s.

hmm, maybe not. Looking into the test failures.

Are vendor directories excluded?

Fixed the problem. The paths were missing the ./ prefix which meant nothing was getting linted.
Runtime is up to 8s, still much faster

I'm not able to reproduce these test failures locally. The test suite is passing for me now.
I noticed in the travis config there is gometalinter --install , but I'm not sure where that binary is built. When I run the previous step I don't have a binary.

The previous line go get installs it.

Ahh, I missed the extra . on that line. Thanks.
I've added another commit which should print the full output of the linters to debug the failures.

Ah, the failure was a change I made to support.go. I accidentally used file permission 0x644 instead of 0644 so I couldn't read the file. I was running the test locally in a container as root, so I didn't encounter the issue.
The tests are now passing

I found a bug when testing against another repo. . was being converted to ./. which caused it to include other directories like vendor/.  Added a unit test and a fix in another commit.

I found another problem with this PR. Some linters (gofmt is the first one I found) translate . into ./.... So if there are any .go files in the root directory the path is effectively always ./....  I'm going to look for a solution.

 That is basically what motivated the original approach.
However, a lot of the linters have subsequently changed, so with any luck after some testing we can merge this change (or similar).
Another issue is mentioned above: vendor directories are included by many linters.

I just went through all the linters that were previously marked as having {path}/*.go. 7 of 8 still require file paths, so I'm adding the list and updating the paths to be {path}/*.go.
I believe vendor/ is handled already (according to my testing), since we're passing a list of paths to each linter, not ./.... Is there another issue?

I pushed another commit which passes a list of file paths to these linters instead of a list of package paths.  I think there is some limit to the length of command lines. On larger projects (especially ones with long paths) this might hit the limit. I'll try to experiment some more.

Yes, there absolutely is. It's O/S dependent too, unfortunately. It's in the C define ARG_MAX. It is not clear to me how to get that from Go, without cgo :\

There's also sysconf(_SC_ARG_MAX).

It seems this value is generally at least 32k (for windows), and at least 200k on linux. Even large projects are unlikely to have more than 10k, so maybe we don't have to worry about it?

Unfortunately that is the number of bytes, not the number of arguments, so it is highly dependent on the length of filenames. I have a change locally that started the same work as this PR, and I hit this problem when testing. It will need to be solved. One option would be to pick the lowest known supported value on common operating systems, and split on that. OSX has 262144. Looks like Windows is the winner.

Makes sense. I've pushed another commit which I think addresses the limit

Ok, I've rebased, added the missing +1 and set the limit to 32k on all platforms

@dnephin LGTM! Some minor conflicts introduced by that last PR. Fix them up and I'll merge this.

Thanks! rebased

Bam! Thanks very much for doing this @dnephin .


"duk" example fails on long (> 64k) single line inputs

I pasted in some obfuscated code into duk (the utility) which starts by defining a string that is over 150KB long and it immediately failed and claiming it was an unterminated string.

(function() { var z="";var b="150+ KB of hexadecimal string here";eval((function(){for (var i=0;i<b.length;i+=2){z+=String.fromCharCode(parseInt(b.substring(i,i+2),16));} return z;})());})();
This is the specific code sans the actual string.

This is a limitation of duk, the command line test utility, not the core lexer itself. It's caused by a fixed line buffer size assumption:

https://github.com/svaarala/duktape/blob/master/examples/cmdline/duk_cmdline.c#L124

I'll look into a fix.

#2368 removes the 64kb limit (present when linenoise was off). However, the symptom of the limit doesn't actually seem to match the issue description; instead of an unterminated string, 'duk' complains "line too long".
Could it be that the input you were giving 'duk' was a multiline expression (which are not handled)?

I built the latest version and tried it.  It's definitely all a single line and when pasting in the code it just halts at a certain point.  Here's a screenshot: https://i.imgur.com/IHJ1wFz.png

It seems there is a limitation on the number of characters that can be input for duk.  I have no problem pasting the string into nano.

I rebuilt with "DUK_CMDLINE_FANCY" disabled/undefined and it will paste the entire string.  However, the error persists as it claims the string is unterminated. https://i.imgur.com/L1vwOJp.png

Are you 100% sure there are no newlines in the pasted input? For example in https://i.imgur.com/IHJ1wFz.png it seems quite clear that the input line terminates in the middle of the string.
If possible, could you try these:

cat > /tmp/test, paste the same input, and CTRL-D. Then wc /tmp/test to see how many lines there are.
cat > /tmp/test, and then run the file with duk /tmp/test (and just for comparison nodejs /tmp/test).

The first image shows the paste into duk when DUK_CMDLINE_FANCY was not disabled.  It seems to have a limit on the number of characters that can be input at once before preventing you from entering more characters.  The second image is with DUK_CMDLINE_FANCY disabled.  Neither seems to parse the full string.
I am 100% sure it's only one line and just to be super sure, I even pasted it into nano, checked the number of lines and that it's the correct length.

$ nano duktest.txt
$ wc -l duktest.txt
1 duktest.txt
$ ls -l duktest.txt
-rw-r--r-- 1 gravis gravis 176444 Oct 19 10:09 duktest.txt

You don't have to take my word for it either, you can get the script here and paste it into duk yourself: https://www.ampedwireless.com/_Incapsula_Resource?SWJIYLWA=5074a744e2e3d891814e9a2dace20bd4,719d34d31c8e3a6e6fffd425f7e032f3

Thanks, I'll see if I can reproduce with that input.

Seems I can reproduce the issue. It only appears when pasting interactively, when piping in via stdin things work as expected.

The interactive loop reads input with fgetc() one character at a time.  For me running:
$ stty cbreak

before trying the copy-paste fixes the paste.


update MemoryManager to cover unified memorymanager when cache is mix

What changes were proposed in this pull request?
update MemoryManager to cover unified memorymanager when cache is mix
How was this patch tested?
UT added

@zhixingheyi-tian @HongW2019 Please take a look this PR based on previous talk.

@yma11
Have you tested this PR?
About #1179 ,  can it  decrease the config item "tmp" memorymanager, if so, we should update user docs

@zhixingheyi-tian I haven't done formal test for this PR but one more UT added for it. When cache set to vmem, we can remove the memorymanager config item in doc.

@yma11
Would you please  update the documentation at the same time,

Per discussed, let's enhance the configuration validation further. For Non-evictable and Vmemcache cache backend, they will not respect memory manager settings as exceptions. @yma11  please help update PR and related configuration descriptions.


Integration tests for SSH models

Please review this pull request and suggest any changes if needed.

I think that something is not OK here.  If you click on the "Files changed" tab (on GitHub) on this PR, you will see that a total of 475 files have been changed, which is way too many, and many of them have 0 byte differences (e.g. those under the .github directory, the README, the LICENCE fille, etc.)  This does not feel / cannot be right.
Please include in the PR only the files which are needed for the PR's purpose as specified in its title: Only files that are needed for integrating the tests of the SSH models.

Superseded by #144.


Add "context" property to WSTag

Hey there 👋
This change would allow the consumer of WSTag to attach an arbitrary Hashable before calling addTag(_ tag: WSTag). This could be used to more easily support a "Mail" or "Calendar" style email address field, where the display text  of the tag can mix literal email addresses with contact names.
It's a non-breaking change, no code changes should be required of existing users. All the tests pass locally.
Anyway, just thought this could be a useful change to upstream and thought I'd open a PR. (This one shouldn't take too long to read through 😉)

Wow! @nathan-mohemian That's a really cool addition.

Thanks!
With this, we could do stuff like this:
let rp = Contact(name: "Ricardo Pereira", businessEmail: Mail("rp@bigcompany.com"), homeEmail: Mail("rp@asd.com"))
let businessTag = WSTags(text: rp.name, context: rp.businessEmail)
tagField.addTag(businessTag)
let homeTag = WSTags(text: rp.name, context: rp.homeEmail)
tagField.addTag(homeTag)

Thanks for the quick response and approval, @ricardopereira!
Glad you like the idea, that's exactly the kind of use case I was thinking of.


chore: Remove changelog check

Now that we have the semantic commits we should automate it and not bother the users

@lipis we shouldn't remove this unless the changelog is automated. Instead lets first add console error messages so users can update the changelog easily


Node Text line width documentation unclear

When working with SBMLDiagrams API, the documentation given for setNodeTextLIneWidth is unclear on what is being changed. All that is given is "Set the node text line width for a node of given id" with the arguments:
id: str-node id.
txt_line_width: float-node text line width.
alias: int-alias node index: 0 to number of alias nodes -1.
I feel like the common person who tries to use the API will not understand what this means or what its physically changing unless they physically compare two images.

The node text line width describes the text line width of the node, which changes the value of the stroke width of the node TEXTGLYPH. This might not be observable in image, but you could look into the exported SBML file and confirm what has changes.

Ethan, can you give an example of the documentation you'd like to see used?
H
On Thu, Sep 21, 2023 at 7:30 PM ethanmizuno16 @.***>
wrote:

When working with SBMLDiagrams API, the documentation given for
setNodeTextLIneWidth is unclear on what is being changed. All that is given
is "Set the node text line width for a node of given id" with the arguments:
id: str-node id.
txt_line_width: float-node text line width.
alias: int-alias node index: 0 to number of alias nodes -1.
I feel like the common person who tries to use the API will not understand
what this means or what its physically changing unless they physically
compare two images.
—
Reply to this email directly, view it on GitHub
https://urldefense.com/v3/__https://github.com/SunnyXu/SBMLDiagrams/issues/85__;!!K-Hz7m0Vt54!h2KLAdLTZAHiDT_VSTcmfubyECYwVkuM4_vxdxoZg2v3C7eOviXRgLBIprQh4oTHK17Dku3KhJscvFokSVRLbYMlRDhJSg$,
or unsubscribe
https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AAIBSDXTDDY2G5V4PERQYPTX3TZ35ANCNFSM6AAAAAA5CNTHMA__;!!K-Hz7m0Vt54!h2KLAdLTZAHiDT_VSTcmfubyECYwVkuM4_vxdxoZg2v3C7eOviXRgLBIprQh4oTHK17Dku3KhJscvFokSVRLbYMg0ytMwg$
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

--
Herbert Sauro, Professor
Director: NIH Center for model reproducibility
University of Washington, Bioengineering
206-685-2119, www.sys-bio.org, http://reproduciblebiomodels.org/
Mobile:<PHONE_NUMBER>
@.***
Books: http://books.analogmachine.org/

I think maybe just being more descriptive in the main description and adding in that it changes the value of the stroke width of the TEXTGLYPH will be more helpful to the user.


Connect local aggregator to remote ES cluster

This includes some bonus improvements to error logging in the aggregator - I implemented these when in pursuit of (what I later discovered to be) https://github.com/elastic/elasticsearch/issues/28923#issuecomment-411395669

Nice.


Made a quick fix to how Queries return their data and Changed naming …

…of Bag::FORMAT_X to Bag::MAP_X

Turns out I got deeper and deeper into the test stubs until I decided to backtrack and keep this PR ultra simple.
I've had to disable Query tests though as they didn't pass (they were expecting incorrect return values anyways). I'll elaborate more on this in #27 .
I think the next step is to really get the testing restructure in place. The more we postpone the harder it's going to get.
All in all this is a very simple PR, shouldn't be too hard to merge this in. The testing situation is another matter.


Updated dependencies and wiki

Here i have updated the dependencies to reduce severe vulnerabilities and have update the wiki

LGTM thanks @ahmedifhaam !


Issue #450

@avinashkranjan
Script will follow and send msg
Fixes: #450

@kaustubhgupta  updated

@kaustubhgupta updated change required

@kaustubhgupta Now updated

@antrikshmisri @santushtisharma10 can u plz review


Disabling a job pollutes stderrorlog

if a job get disabled the runner pollutes the log with endless loop printing an error that the job is disabled, how can we avoid this?

@mogui Under what conditions does this occur? Just a job being disabled?

@mogui Are you talking about this? https://github.com/ajvb/kala/blob/99275856754f93cce5be3d595ab64eebfba78518/job/runner.go#L29

If that's the case, I would say #82 is what is needed at first.

Are you talking about this? https://github.com/ajvb/kala/blob/99275856754f93cce5be3d595ab64eebfba78518/job/runner.go#L29

Yeah I mean this one.
Just disabling a job works fine, but as soon as you restart kala and reload the disabled job form the db it gets stuck in that loop


Enable/disable gradient_checkpointing as per training_args.gradient_checkpointing value

What does this PR do?
https://huggingface.co/facebook/wav2vec2-base/blob/main/config.json  model has gradient_checkpointing set to True. Ideally we would expect this to be overriden by training_args.gradient_checkpointing value (default is False), but this is not happening when executing run_audio_classification.py
To fix this issue, explicitly call model.gradient_checkpoint_disable() if training_args.gradient_checkpointing = False. Confirmed from PT profiler traces that gradient_checkpointing is not getting activated with this change.

Fixes # (issue)
Before submitting

[ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
[ ] Did you make sure to update the documentation with your changes?
[ ] Did you write any new necessary tests?

@regisss this PR is continuation of https://github.com/huggingface/optimum-habana/pull/459 (closed because I messed it up during rebase).  Have taken care of your review comments from #459, please review again. Thanks.

I see there's also an error in CI:
AttributeError: 'RegressionDictModel' object has no attribute 'gradient_checkpointing_disable'

Let me take a closer look.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

@regisss I updated as per your comments, CI passes too.  Running make style is always making formatting changes to notebook in my workspace (even after rebasing to latest commit on main). Since style check in CI is passing with this I assume its ok, please let me know if that is not correct assumption.


[macOS] Enable voiceover applescript defaults

Description
VoiceOver is a screen reader system application that provides auditory descriptions of elements help you easily navigate your screen with keyboard or gestures.
This PR extends the work of #4805 for enabling applescript control of voiceover by setting the required defaults for the key SCREnableAppleScript in com.apple.VoiceOver4/default.
Related issue:
Fixes #4770
Check list

[x] Related issue / work item is attached
[ ] Tests are written (if applicable)
[ ] Documentation is updated (if applicable)
[ ] Changes are tested and related VM images are successfully generated

So can we do this today and see if the fixes work or not?

/azp run macos11, macos12


Allow me to search for markdown headers without manually inserting - delimiters

Testing #174884
Currently if I have a header like so
# A header with spaces in the title

I have to search for it by typing the following when triggering header autocomplete
#a-header-with-spaces-in-the-title

I'd like to be able to type
#a header with spaces in the title

and have the completion still show up.

I agree but am not yet sure if this belongs in the suggest widget or a new UI. Using the suggest widget is a little weird because the inserted text has to be slugified
I'm potentially imagining a Insert header link command that shows a quick pick with all headers for fuzzy matching. Selecting one would insert the full link, similar to how Markdown: Insert link to file in workspace works


ignore command name capitalization

!Count mega will now work.

This single thing made me build my client with custom arc version.

I'm just going to assume this works

Yes, I use it on my custom arc version.

i'm aware, i read the code before merging


XmlHttpRequest in browser.json is incomplete

Adds the missing members from XMLHttpRequestEventTarget and EventTarget
https://github.com/ternjs/tern/issues/751

Thanks. Merged as ae87257


[IDEA]Office Online Server

Feature description:
I'm looking for the option to have office online server, there is any way to get it?

You can install it online without checking the "Install after download." box.

@chiyi4488 thank you for the answer, but I think that I don't understand you, there is a type of office for windows server, after you install it you can have a office session on a website. The office is called Online Office Server or OOS.
https://docs.microsoft.com/en-us/officeonlineserver/office-online-server

Unfortunately, Office Tool Plus is built on the basis of Office Deployment Tool (ODT) and its function is to facilitate users to deploy Office applications. There is no way to do what you said about Office Online Server.

@chiyi4488 thank you for the answer, but I think that I don't understand you, there is a type of office for windows server, after you install it you can have a office session on a website. The office is called Online Office Server or OOS.
https://docs.microsoft.com/en-us/officeonlineserver/office-online-server

Hello, as I checked your link, I found "Office Online Server can be downloaded from the Volume Licensing Service Center (VLSC)."
Maybe you should follow the steps to get your Office Online Server from VLSC. Office Tool Plus is based on Office Deployment Tool and used to deploy Retail and Volume edition of Office.

Ok, so I guess that I'm going to need to buy a Microsoft office bussines license to be able to download it, Anyway thank you!!


Remove nibs, use programmatic layout

Better for maintenance
Better for PRs

This will fix these issues:

#1340
#1257
#1844
#1212

⚠ NOTE: not accepting PRs for this 😄

@jessesquires I have started implementing this in all my personal projects and agree. We should probably move this same direction on messageKit. 💯

Just curious-- are you guys talking about placement of views and controls? Constraints? I tend to build things in code (e.g. AudioMediaItem) but I think there's no debating that it makes it harder for people to understand what is going on and customize to suit themselves.

Definitely removing the view controller nib, as it doesn't provide much value.
Not sure about the toolbar.
For cells, I will likely keep these.

I think so far only JSQMessagesViewController is the case? #1670

Hello everyone!
I'm sorry to inform the community that I'm officially deprecating this project. 😢 Please read my blog post for details:
http://www.jessesquires.com/blog/officially-deprecating-jsqmessagesviewcontroller/
Thus, I'm closing all issues and pull requests and making the necessary updates to formally deprecate the library. I'm sorry if this is unexpected or disappointing. Please know that this was an extremely difficult decision to make. I'd like to thank everyone here for contributing and making this project so great. It was a fun 4 years. 😊
Thanks for understanding,
— jsq


Commented out directives trigger linter error

I just had a go.mod directive of the form:
// replace github.com/owner/repo => /home/mixedcase/code/owner/repo

trigger an error.
Apologies if this is a golangci-lint error or misuse, but from what I've been able to understand this should not trigger the warning.

Hello,
I'm not able to reproduce it, can you provide your full go.mod file and the logs?

Unfortunately I can't share the full go.mod that causes the issue for legal reasons and I am failing to reproduce the issue with a smaller example.
This is what appears, with repo name changed:
go.mod:5:1: local replacement are not allowed: github.com/owner/dep (gomoddirectives)
// replace github.com/owner/dep => /home/mixedcase/code/owner/dep

The offending go.mod contains 98 lines, is composed of three different require blocks, first with 29 dependencies, second with 16 dependencies and third with 39 dependencies. Go version is set to 1.19, the module name line is akin to module github.com/owner/repo. The mentioned commented out replace is the only forbidden directive there.
I am using golangci-lint version 1.50.1 obtained from nixpkgs on NixOS. gomoddirectives is using its default configuration.
Please do close the issue if being unable to provide a reproducer is a deal-breaker, I certainly understand. In any case, anything else I could try or information I could provide please let me know.

I tried on several projects (go.mod with 363 lines, with 135 lines, with only 10 lines) and I'm not able to reproduce your problem.
Without a reproducer I'm not able to diagnose.
FYI, the go.mod parsing is the same as Go.

Got it, can't explain what's going on. Go is certainly picking the right package with the thing commented out and with it on. Closing as a freak accident.


[SPARK-20682][SQL] Implement new ORC data source based on Apache ORC

What changes were proposed in this pull request?
Since #17924, #17943, and #17980 are a little large PRs, this is a minimized version for review. The follownings are not included in this PR.

Exclude OrcReadBenchmark.scala
Exclude OrcColumnarBatchReader.scala
Minimize new ORC Test suites in sql/core and reuse sql/hive test suite.

This PR shows new ORC datasource is able to replace the old ORC datasource. After review, I will revert the change on old ORC datasource because we will allow to choose one of ORC datasource for a while by #17980 .
How was this patch tested?
Pass the Jenkins.

Test build #80710 has started for PR 18953 at commit 22dbe35.

Test build #80707 has finished for PR 18953 at commit 051ed1f.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class OrcFileFormatOld extends FileFormat with DataSourceRegister with Serializable

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80707/
Test FAILed.

Rebased to the master since #18640 is merged.

Test build #80721 has started for PR 18953 at commit 07778ed.

Test build #80710 has finished for PR 18953 at commit 22dbe35.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80710/
Test PASSed.

Hi, @cloud-fan , @gatorsmile , @rxin , @sameeragarwal , and @viirya .
Could you review this ORC PR? I narrow down the focus and reduce the size of PR.
For review purpose, I replace the old ORC with new ORC.
Thank you always!

Test build #80721 has finished for PR 18953 at commit 07778ed.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80721/
Test FAILed.

Retest this please.

Test build #80722 has started for PR 18953 at commit 07778ed.

what's the project plan for this ORC stuff? shall we move the old orc data source to sql/core with orc 1.4 first, and then send a new PR for vectorized reader?

Hi, @cloud-fan .
In my email, I wrote in the following order .
1. SPARK-21422: Depend on Apache ORC 1.4.0
2. SPARK-20682: Add a new faster ORC data source based on Apache ORC
3. SPARK-20728: Make ORCFileFormat configurable between sql/hive and sql/core
4. SPARK-16060: Vectorized Orc Reader

In Apache Spark 2.3, I thought we need to keep both by option spark.sql.orc.enabled.
Do you mean removing old orc data source from sql/hive?
In this PR, I replaces sql/hive ORC to reduce the burden of review of test code. The new test code is #17980.

This PR is about 1,100 lines and #17980 is about 3,833.
I also updated #17980 today, too. If you want to review that PR, that is also great!

For the reader, there are three part.

OrcColumnarBatchReader: It's not included here.
OrcRecordIterator: It's included here. It doesn't not use Spark vectorization.
RecordReaderIterator[OrcStruct]: It's used here.

Like (1), I can exclude (2) in this PR. Is it okay?

Test build #80722 has finished for PR 18953 at commit 07778ed.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80722/
Test PASSed.

Are the ORC APIs changed a lot in 1.4? I was expecting a small patch to upgrade the current ORC data source, without moving it to sql/core.

The goal is using ORC with -Phive. You can build Spark and use ORC datasource.
Previously, org.apache.spark.sql.hive.orc.ORCFileFormat is tightly coupled with Hive code outside org.apache.spark.sql.hive.orc. package. For example, org.apache.spark.sql.hive.HiveInspectors. Also, it uses the following imports.
import org.apache.hadoop.hive.conf.HiveConf.ConfVars
import org.apache.hadoop.hive.ql.io.orc._
import org.apache.hadoop.hive.serde2.objectinspector.{SettableStructObjectInspector, StructObjectInspector}
import org.apache.hadoop.hive.serde2.typeinfo.{StructTypeInfo, TypeInfoUtils}

In case of OrcFilters.scala, the API is changed like the following.
- Some(builder.startAnd().isNull(attribute).end())
+ Some(builder.startAnd().isNull(attribute, getType(attribute)).end())

You can see more diff by diff sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcFilters.scala sql/hive/src/main/scala/org/apache/spark/sql/hive/orc/OrcFilters.scala.

@cloud-fan . I'll rethink about consolidation the old and the new. Thank you for the advice!

So far, the current ORC related code looks too old and tightly integrated with hive-exec-1.2.1.spark2.jar and hive module side-by-side.
The patch also need to touch every part because everything is changed; Especially, OrcInputFormat.createReader (in hive-exec), Filter, SearchArgument, HiveInspectors.

Hi, @cloud-fan . As you adviced, I will replace old ORC in the current namespace and will try to move to sql/core later. Although, we cannot switch among old ORC and new ORC, we can bring back old ORC if need from the code. Thanks.

Test build #80771 has started for PR 18953 at commit 80c80f3.

@cloud-fan . The PR is updated. Now, it's minimized as +493 and −247 lines.

Test build #80771 has finished for PR 18953 at commit 80c80f3.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80771/
Test FAILed.

Retest this please

Test build #80777 has started for PR 18953 at commit 80c80f3.

Test build #80777 has finished for PR 18953 at commit 80c80f3.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80777/
Test PASSed.

Test build #80827 has started for PR 18953 at commit f8de872.

Test build #80827 has finished for PR 18953 at commit f8de872.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80827/
Test FAILed.

Retest this please.

Test build #80832 has started for PR 18953 at commit f8de872.

Test build #80832 has finished for PR 18953 at commit f8de872.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80832/
Test FAILed.

Test build #80840 has started for PR 18953 at commit c9321df.

Test build #80840 has finished for PR 18953 at commit c9321df.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80840/
Test PASSed.

Merged build finished. Test PASSed.

Test build #80858 has started for PR 18953 at commit 8548b73.

Test build #80858 has finished for PR 18953 at commit 8548b73.

This patch fails SparkR unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80858/
Test FAILed.

Retest this please.

Test build #80861 has started for PR 18953 at commit 8548b73.

Test build #80861 has finished for PR 18953 at commit 8548b73.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80861/
Test PASSed.

Hi, @cloud-fan .
Could you review this PR?

Test build #80869 has started for PR 18953 at commit 7954d52.

Test build #80869 has finished for PR 18953 at commit 7954d52.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80869/
Test FAILed.

In these days, fails due to an unknown error code, -9. seems to become more frequent.
Retest this please.

Retest this please.

Test build #80875 has started for PR 18953 at commit 7954d52.

Test build #80875 has finished for PR 18953 at commit 7954d52.

This patch fails SparkR unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80875/
Test FAILed.

Retest this please

Test build #80877 has started for PR 18953 at commit 7954d52.

Test build #80877 has finished for PR 18953 at commit 7954d52.

This patch fails SparkR unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80877/
Test FAILed.

Merged build finished. Test FAILed.

The Jenkins fails twice with different R test suite.s Those errors are irrelevant.

test_mllib_tree.R (Test build #80875)

1. Error: spark.gbt (@test_mllib_tree.R#120) -----------------------------------
java.lang.IllegalArgumentException: requirement failed: The input column stridx_f91a4b086385 should have at least two distinct values.

test_mllib_classification.R (Test build #80877)

1. Error: spark.svmLinear (@test_mllib_classification.R#80) --------------------
java.lang.IllegalArgumentException: requirement failed: LinearSVC only supports binary classification. 1 classes detected in linearsvc_ec743395c7af__labelCol

Retest this please.

Test build #80881 has started for PR 18953 at commit 7954d52.

Test build #80881 has finished for PR 18953 at commit 7954d52.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80881/
Test PASSed.

Merged build finished. Test PASSed.

Hi, @cloud-fan .
The PR is ready for review again. Thank you!

Test build #80909 has started for PR 18953 at commit 63cf876.

Hi, @cloud-fan . I added SparkOrcNewRecordReader.java back to reduce the patch size.

Test build #80909 has finished for PR 18953 at commit 63cf876.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80909/
Test PASSed.

Merged build finished. Test PASSed.

Hi, @cloud-fan , @gatorsmile , @rxin , @sameeragarwal , @hvanhovell , @mridulm and @viirya .
Could you give me some opinion on this ORC PR when you have sometime?
According to @cloud-fan 's advice, I'm trying to replace the old Hive ORC here. It becomes much smaller than before.

@dongjoon-hyun can you put more information in the PR description? update OrcFileFormat is too vague.

Thank you, @cloud-fan . Yep. I will!

I updated the PR description, @cloud-fan .

Test build #80980 has started for PR 18953 at commit 3d602ab.

Test build #80980 has finished for PR 18953 at commit 3d602ab.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80980/
Test PASSed.

Test build #81012 has started for PR 18953 at commit 263b3dc.

Test build #81013 has started for PR 18953 at commit 8507aef.

Test build #81012 has finished for PR 18953 at commit 263b3dc.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81012/
Test FAILed.

Test build #81013 has finished for PR 18953 at commit 8507aef.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81013/
Test PASSed.

Merged build finished. Test PASSed.

Hi, @cloud-fan .
Could you review this again when you have sometime?

Test build #81142 has started for PR 18953 at commit b9b348d.

Test build #81142 has finished for PR 18953 at commit b9b348d.

This patch fails SparkR unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81142/
Test FAILed.

Test build #81148 has started for PR 18953 at commit 6548cf8.

Test build #81148 has finished for PR 18953 at commit 6548cf8.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81148/
Test PASSed.

Now, it becomes +432 −98.

Hi, @cloud-fan and @gatorsmile .
Could you review this PR when you have sometime?
If we need more refactoring or spin-off, please let me know.
Thank you always.

Hi, @cloud-fan .
Could you review this PR?

Hi, @cloud-fan and @gatorsmile .
I know that you have been spending much time for reviewing my PRs (including this).
Thank you always. If you have something in mind, please let me know. I'll try to improve it.

Retest this please.

Test build #81268 has started for PR 18953 at commit 6548cf8.

Test build #81268 has finished for PR 18953 at commit 6548cf8.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81268/
Test PASSed.

Hi, @marmbrus , @liancheng , @yhuai .
Could you give me some advice about this ORC upgrade PR?
I tried to minimize the diff of PR, so I didn't remove the unused old one.
Thank you in advance.

Retest this please.

Test build #81326 has started for PR 18953 at commit 6548cf8.

Test build #81326 has finished for PR 18953 at commit 6548cf8.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81326/
Test PASSed.

Merged build finished. Test PASSed.

Test build #81513 has started for PR 18953 at commit 014f2f3.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81513/
Test PASSed.

Merged build finished. Test PASSed.

Retest this please.

Test build #81569 has started for PR 18953 at commit 014f2f3.

Test build #81569 has finished for PR 18953 at commit 014f2f3.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81569/
Test PASSed.

Test build #81597 has started for PR 18953 at commit ed43eb7.

Test build #81597 has finished for PR 18953 at commit ed43eb7.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class OrcSourceSuite extends OrcSuite with SQLTestUtils

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81597/
Test PASSed.

This is resolved via https://github.com/apache/spark/pull/19651 .


Update build configuration

The build configuration of this project is outdated and may no longer work.
This pull request will be merged automatically if there are no conflicts.

:tada: This PR is included in version 4.0.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Clarify the usage of system environment variables

The section on zero downtime deploys discusses environment variables, but it's not clear whether it refers to application or system env vars. This PR clarifies this and links to the Ubuntu environment variable documentation for further reading.

Is this actually true in master? I thought perhaps we sourced the app env early enough now.

Hmm, I was trying to update the DOKKU_WAIT_TO_RETIRE variable and didn't have any luck. I'll try again and report back. I'm on the latest released version (0.3.16).

Setting DOKKU_WAIT_TO_RETIRE in the application config (using ssh dokku@host config:set app DOKKU_WAIT_TO_RETIRE=2) Doesn't yield the expected result, I still see the 'Shutting down old container in 60 seconds' message during deploy.
Setting it in /etc/environment does affect subsequent deploys, and I see 'Shutting down old container in 2 seconds' as I expect.
@michaelshobbs question: How do you verify the value of DOKKU_CHECKS_WAIT during deploy? I don't see the default 5 second wait displayed in the deploy output.

Oh yeah derp on me! This is related to #1102 and should be fixed in master and subsequently the next release.

Note: I'm waiting on the restart stuff to make a new release :)

Restart stuff? or do you mean retry stuff?

Yeah sorry, retry.

Excellent! I'll look out for the next release in that case. I'll close this
PR when I'm in front of a real computer.
On Mon, 13 Apr 2015 17:17 Jose Diaz-Gonzalez<EMAIL_ADDRESS>wrote:

Yeah sorry, retry.
—
Reply to this email directly or view it on GitHub
https://github.com/progrium/dokku/pull/1106#issuecomment-92502221.


fluentd 1.1.0 memory leak

Fluentd version: 1.1.0
Linux version: CentOS Linux release 7.5.1804 (Core)
Description：
We run fluentd on centos7 and use its elasticsearch plug-in and kafka plug-in. In the case of large data volume, the memory used by fluentd will increase.How do you sort out this problem?I'm a Java programmer

Hi.
Does using only kafka plugin occur this memory leak or not?


scrollMonitor.js.map errors

I may be using the package incorrectly, so please advise if so.
However, the packaged scrollMonitor.js has a reference to scrollMonitor.js.map.  Webpack pulls in the main JS file but not the map, and so on every page I get error saying that it couldn't find or parse the map file.
Unless I should somehow be configuring my Webpack to look in minified JS files and pull our relative map paths and bundle them to (or it maybe it should be default?).

Do you have source maps configured in webpack? It should be something along the lines of
    devtool: 'sourcemap'

Ah - I do for production deployment, but not for development.  I don't have a version running with the production deployment at the moment to check.  Is it required to do this?

Yeah, you should use it to stop this error and for your own sanity. Right now it's looking for the source map that it would use if you used a script tag, which isn't being served. When webpack builds with a source map it's smart enough to use the bundled one.


Make dry-run option to output the configuration for regsync

Update dry-run option to show the configuration which regsync would be executed with

@eriksw As you requested, I update the dry-run option instead of introducing it. The output would look like
» go run . --dry-run ~/workspace/ops-images/compose.yaml<PHONE_NUMBER>59.dkr.ecr.cn-northwest-1.amazonaws.com.cn
version: 1
sync:
    - source: danielqsj/kafka-exporter:v1.8.0@sha256:9b67b273d1e54052e7ce77c46ecd1c6619fdee7e2ed26717e6272806fbc94150
      target:<PHONE_NUMBER>59.dkr.ecr.cn-northwest-1.amazonaws.com.cn/danielqsj/kafka-exporter:v1.8.0
      type: image
    - source: fluent/fluent-bit:3.2.1@sha256:6820e86902908933c63f1260d36f1bed0fed0c805518667054cf08890dbf06d5
      target:<PHONE_NUMBER>59.dkr.ecr.cn-northwest-1.amazonaws.com.cn/fluent/fluent-bit:3.2.1
      type: image
...


Adding a test of concurrent HystrixObservableCollapsers running

Tests to exercise scenario in #955

NetflixOSS » Hystrix » Hystrix-pull-requests #258 SUCCESS
This pull request looks good


Support for passing an existing import map as the base for the generator.

The use-case is when you already have an import map but you want to add extra dependencies to it.

The inputMap option is exactly the thing to use here, basically just passing that argument from the main generator.
A PR would be great if you're up for it, and let me know if I can assist further.

(And also if you hit scenarios where the interactions on the existing API don't work out as you'd expect them to)

yeah I'm gonna open one, I'll reach out if I'm blocked

Landed in https://github.com/jspm/generator/pull/34.


Community creation

Motivação
Mudanças feitas
Tarefa relacionada

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 20 (0.0%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.2%) to 7.352%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/pages/InitialPage/index.js
0
1
0.0%

src/pages/CreateCommunity/styles.js
0
5
0.0%

src/pages/CreateCommunity/index.js
0
14
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.2%

Covered Lines:
142

Relevant Lines:
1781

💛  - Coveralls


Could not find com.yqritc:android-scalablevideoview:1.0.4

Bug
React native 0.65.0 build is failing on Android after installing react native video
Platform

Which player are you experiencing the problem on:

Android ExoPlayer
Android MediaPlayer

Environment info

Library version: 5.1.1
Steps To Reproduce

create a project of React Native version 0.65.0
install react-native-video
3.build the project
...

Expected behaviour
1.The build should successfully complete
2.The app should be installed in the simulator/device
3.react-native-video should work properly.

I think this has to do with React Native's recent migration away from jcenter, which all React Native projects will start doing as well. The dependency itself seems to only be available on jcenter and it looks pretty old (https://github.com/yqritc/Android-ScalableVideoView).  RNV will have to deal with this somehow. I wonder if it would be possible to drop this dependency completely. If not that, then fork it and make it available on maven central.

For now, the workaround is probably to add back jcenter to your build.gradle.

I cannot get it to work by including jcenter. Any suggestions to make this run again?

@Degn I think the only explanation for that is that you didn't add jcenter correctly, or there's some caching going on.

I have the same issue. Even with jcenter the problem wasn't solved.

I solved the problem just putting the jcenter() in "settings.gradle".

I have the same issue and hope that the library can make it available on maven central... Can't build at all now.

same issue when I updated react-native: 0.65.1

I think this has to do with React Native's recent migration away from jcenter, which all React Native projects will start doing as well. The dependency itself seems to only be available on jcenter and it looks pretty old (https://github.com/yqritc/Android-ScalableVideoView). RNV will have to deal with this somehow. I wonder if it would be possible to drop this dependency completely. If not that, then fork it and make it available on maven central.

Have you solved the issue ?  I still got the same error in my project! Would you like to provide more information about how to solve this issue ?thanks

You can add jcenter()
Inside android/build.gradle file

this is the one that worked for me https://stackoverflow.com/a/68841906

Gold!

this is the one that worked for me stackoverflow.com/a/68841906

Because jCenter is removed from latest react native and com.yqritc:android-scalablevideoview is only published there you need to add jCenter again as a repository but I would advice to define the package so other dependencies are not fetched/taken from jCenter anymore. Because jCenter does not allow any updates anymore of any package all other packages should be taken from mavenCentral for example.
You can add jcenter to android/build.gradle like this:
allprojects {
    repositories {
        .... # Keep the rest
        jcenter() {
            content {
                includeModule("com.yqritc", "android-scalablevideoview")
            }
        }
    }
}

Hopefully somebody updates android-scalablevideoview to use another repository

Dear, I tried for the new version of react native (0.65.1) and it's working. But remembering that you must put the jcenter() inside: YourProject / android / build.grandle

this is the one that worked for me https://stackoverflow.com/a/68841906

thanks a loooooooot, it solved my issue

@Hello-Zeze the code snippet that you posted there doesn't match the one posted above. The content portion should be in jcenter, not in maven

You can add jcenter to android/build.gradle like this:
jcenter() //add this line

@Shihaburabbi it's best to only pull specific packages from jcenter(), like this: https://github.com/react-native-video/react-native-video/issues/2454#issuecomment-913709132

I face the same issue and i used this solution that works for me
https://stackoverflow.com/a/68841906

jitpack.io has a mirror which includes this missing dependency.
I would suggest this over using jcenter, since it appears to be very flakey now
https://jitpack.io/#yqritc/Android-ScalableVideoView

same issue for me

I solved the problem just putting the jcenter() in "settings.gradle".

this does not work for me, can I see your sample code?

It works for me as well. Thank You

With jcenter down, is it possible for someone to just upload the scalablevideo jcenter package to maven central? I think the original repo is completely dead so I don't expect the original owner to fix it.

yeah how do we go about doing this?

Is there an alternative to get it built in jitpack?  Seems like jitpack can't build the 1.0.4 release.  There's a fork with a successful 1.0.1 build but that's not super helpful....
https://jitpack.io/#pgloaguen/Android-ScalableVideoView
Even trying to add that implementation is not getting me anywhere...

I am still just using jcenter() as it is still up as read-only. Far from ideal but moving to a new version is not an option right now.

@peterrus not sure if you are aware, but jcenter was down all day yesterday, it's kind of worrisome that a flakey service could tank building without a good back up. This is the only one of my packages that doesn't have an alternative, so its definitely something that should be looked at, I personally don't know how to add a new android package anywhere.

@schlaegerz Oof, no I was not aware of this! Then the only way forward seems upgrading to a new version :(

Anybody got any updates on this situation?

Yes, Same Issue.
Execution failed for task ':app:mergeDebugJavaResource'.
Could not resolve all files for configuration ':app:debugRuntimeClasspath'.
Could not find com.yqritc:android-scalablevideoview:1.0.4.
jcenter is deprecated. it's not a permanent solution.
It's not available on maven.
https://dl.google.com/dl/android/maven2/com/yqritc/android-scalablevideoview/1.0.4/android-scalablevideoview-1.0.4.pom
https://repo.maven.apache.org/maven2/com/yqritc/android-scalablevideoview/1.0.4/android-scalablevideoview-1.0.4.pom
https://www.jitpack.io/com/yqritc/android-scalablevideoview/1.0.4/android-scalablevideoview-1.0.4.pom
Please Update.

There are already forks that fix that: https://github.com/yqritc/Android-ScalableVideoView/issues/52#issuecomment-1013824489
As far as I know the fix was already merged but not published.
Could a maintainer publish please??

Anyone please help:
i have this error:   Failed to resolve: com.yqritc:android-scalablevideoview:1.0.4

Please answer why this is keep appearing i have spent more than 48 hours on it now i am getting this:
Failed to resolve: com.yqritc:android-scalablevideoview:1.0.4
Show in Project Structure dialog
Affected Modules: app

This is my build.gradle(app):
apply plugin: 'com.android.application'
apply plugin: 'com.google.gms.google-services'
android {
compileSdkVersion 32
buildToolsVersion "30.0.3"
defaultConfig {
    applicationId "com.example.letsWeTalk"
    minSdkVersion 24
    targetSdkVersion 32
    versionCode 1
    versionName "1.0"

    testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
}

compileOptions {
    sourceCompatibility JavaVersion.VERSION_1_8
    targetCompatibility JavaVersion.VERSION_1_8
}

buildTypes {
    release {
        minifyEnabled false
        proguardFiles getDefaultProguardFile('proguard-android-optimize.txt'), 'proguard-rules.pro'
    }
}

}
dependencies {
implementation fileTree(dir: "libs", include: ["*.jar"])
implementation 'androidx.appcompat:appcompat:1.4.1'
implementation 'androidx.constraintlayout:constraintlayout:2.1.3'
implementation 'androidx.cardview:cardview:1.0.0'
implementation 'com.google.android.material:material:1.5.0'
testImplementation 'junit:junit:4.13.2'
androidTestImplementation 'androidx.test.ext:junit:1.1.3'
androidTestImplementation 'androidx.test.espresso:espresso-core:3.4.0'
implementation 'com.google.firebase:firebase-analytics:20.1.2'
implementation 'com.google.firebase:firebase-auth:21.0.3'
implementation 'com.google.firebase:firebase-firestore:24.1.1'
implementation ('org.jitsi.react:jitsi-meet-sdk:3.10.2') { transitive = true }
}

and this is build.gradle:
// Top-level build file where you can add configuration options common to all sub-projects/modules.
buildscript {
repositories {
google()
mavenCentral()
}
dependencies {
classpath 'com.android.tools.build:gradle:7.1.3'
classpath 'com.google.gms:google-services:4.3.10'
// NOTE: Do not place your application dependencies here; they belong
// in the individual module build.gradle files
}
}
allprojects {
repositories {
google()
maven {
url "https://github.com/jitsi/jitsi-maven-repository/raw/master/releases"
}
}
}
task clean(type: Delete) {
delete rootProject.buildDir
}

This issue is linked to this PR: https://github.com/react-native-video/react-native-video/pull/2651

this is the one that worked for me stackoverflow.com/a/68841906

Because jCenter is removed from latest react native and com.yqritc:android-scalablevideoview is only published there you need to add jCenter again as a repository but I would advice to define the package so other dependencies are not fetched/taken from jCenter anymore. Because jCenter does not allow any updates anymore of any package all other packages should be taken from mavenCentral for example.
You can add jcenter to android/build.gradle like this:
allprojects {
    repositories {
        .... # Keep the rest
        jcenter() {
            content {
                includeModule("com.yqritc", "android-scalablevideoview")
            }
        }
    }
}

Hopefully somebody updates android-scalablevideoview to use another repository

this works great!!

Someone can help?
https://stackoverflow.com/questions/72185626/react-native-video-not-working-with-url-why

jcenter isn't the solution, it will be removed anyways with the latest pr https://github.com/react-native-video/react-native-video/pull/2681

Any progress on this?

I was able to use react-native-video 5.2.0 without using jcenter by switching to the Android ExoPlayer.  android-scalablevideoview is only used by the Android MediaPlayer which is being removed in version 6.x of react-native-video anyway.

Add the following lines to settings.gradle to use the ExoPlayer instead of the MediaPlayer:

include ':react-native-video'
project(':react-native-video').projectDir = new File(rootProject.projectDir, '../node_modules/react-native-video/android-exoplayer')

Once I switched to the ExoPlayer, I got errors from react-native-video/android-exoplayer/build.gradle about com.google.android.exoplayer:exoplayer:2.13.2 and com.google.android.exoplayer:extension-okhttp:2.13.2 not being available.  I made a patch to change both versions to 2.13.3, and my app built successfully after that.

Any updates on this?
jcenter works for now, but need a proper fix

As anticipated, jCenter is finally down, lol

JsCenter is down , this package needs to update

Non, on V6 on exoplayer is supported. 5.2.1 such include similar change

Yeah I think that change is on master and the 6.0 alphas: fd821d2

Applying that change in node_modules/react-native-video-processing/android/build.gradle got my build running again - thank you! When I have time I'll update the library, but this works for me for now and at least lets me build.


Hierarchical widget issue

There is a issue when you click on a non root level refinement
Steps to reproduce:

on instantsearch.js branch of Magento, just click on a sub level

Are you able to reproduce it on the instantsearch.js npm run dev example?

Ok that's only because you are using an <input type="checkbox" /> as a hierarchical facet template. Thus that's a case we did not planned, if you use a regular <a href='#' it will be ok.
And that's what you should use because it's not very good to use an <input> and then force the rendering to looks like it's not an input.
Use a different template for the (hierarchical) menu, that's no big deal and it should be easier to understand for the users in fact.

Maybe explain why you want to have an <input> (beside trying to have only one template for facets).
Also the default template should be enough maybe try it.

Yes the main reason is having one template (and one set of css rules).
But even if we forget about this reason, I do not see why you could not have inputs for hierarchical. For me the content of the template should not change the overall behavior

Labels and checkboxes have a very specific behavior on clicks so we do not handle them when multiple level deep.
There is no point in using checkboxes for the hierarchical menu. In a menu you NEED links so that you can cooy paste the href and ctrl click to open in a new tab.
It will in the end look weird to you users to have a hidden checkbox just to avoid having a different template.
You have two different UI element, you need a different template here.

You can have two templates and common css rules thats no big deal, do not try to DRY too much on templates bc youll end up with weird constructs in the code and css

Ok makes sense. Will do that

Tried it, I got the same issue with link or without it does not work. I updated the instantsearch.js branch on the magento repo

Will try again

So the issue is that you maybe not tried using <a href=# because it works with it. I will have to check why it's not working with simple
 because that's an issue.

It was not working for me when I did it with a wrapping  arround .sub_facet

Ok fixed (will release soon so that you can continue working), next time you should try to reproduce the issue within the instantsearch.js repo/dev example in a branch so that it's a lot easier. Well, we fixed it now :)

Ok cool


Fix typo in lab1/part1/README.md

Add ".sh" to the lines
./capture_submission part1

and
./capture_submission part1

in lab1/part1/README.md.

Duplicate of PR #4


[Payment card / Subscription] make TransferPolicyOwnership 1:1:1 and move as much code as possible to Auth

Problem
TransferPolicyOwnership is not 1:1:1. We strive for all our commands to be 1:1:1 and in addition to the inherent benefit of making this command 1:1:1 this will also unblock https://github.com/Expensify/App/issues/46933 which is necessary in order to create SCA supported flow to add a billing card while transferring ownership.
Solution
Make TransferPolicyOwnership 1:1:1 and move as much of the web code as possible to auth.

Working on this today.

Note: even though the command in web is TransferPolicyOwnership in auth its TakePolicyOwnership. That tripped me up.
Update: made a draft PR, slow work, lots of details. Trying my best to divide it up into smaller and smaller bite sized pieces.

Difficulty moving some of the calls to auth, confused about forwarding commands and using them in Auth. Though seems like this is what I want. Synchronous and able to check for errors.

Made good progress today. I got my first "draft" of the changes done for the auth PR, same for the web PR (which is much simpler), and I also was able to save myself some work by figuring out that there was code in web that was no longer needed  and could be deleted entirely instead of being ported into Auth (PR).
Still lots of work to be done.

Not overdue. Was out on Friday and then it was the weekend. Working on this today.

Got it compiling without errors! Now to test it out manually and then also probably writing some tests / assessing what automated tests already cover this functionality.

Fixed some of the auth tests but not all. Some seems to be quite odd and hard to figure out why they are failing. Pushed up my updates branches with the work I have done today.

Spent a little more time and didn't fix any tests, but I did get it to work manually after making one more small change to my web-expensify PR. Logging off for now, will continue work on this tomorrow.

Fixed all the auth tests, now need to fix the broken web tests.

Chugging along. Fixed some of the web tests but not all of them. Very difficult to debug and find all the errors, but I did find quite a few of them. Some incorrect onyx updates, bad messages on Auth responses, and just some straight up typos/bugs that I missed on my first pass. Biggest revelation was that I need to know whether the request is coming from new dot or not in order to be able to get the web tests to pass. I thought I could get around that but it seems excruciatingly difficult to do so. So I made this PR to help me with that.
Progress is being made. I'm hoping this PR will be ready for review by the end of the week but its possible it won't be.

Down to one last broken test in the web tests. So close!

Alright I was hoping to avoid this but we need to temporarily change some functionality. The TransferOwnershipTest::testTransferOwnershipNewDotOwnerAmountOwed test has proved to me that there is a flow that we simply can't make work fully until we've deleted the php code that will be replaced by the auth port.
The issue is that the php code checks "does the user taking over have an amount owed, if so error out, if they don't and the owner has an amount owed, then transfer it over." So we then want the auth code to just go through and transfer the policy over like normal, but now that the amount owed has been transferred Auth now sees that the new owner does have an amount owed, and therefore is errors out when actually we want it to go through like nothing was wrong!
We're stuck in a position where we either let people who want to take over policies who already have amount owed's temporarily transfer policies or we block people from transferring policies where the owner has an amount owed. This will only be an issue temporarily, and I think I can make it such that we get all the necessary changes in one deploy.
I think the way to do this the most smoothly will be to temporarily allow people to transfer policies even though they have an amount owed.

Okay here is what is left to do on this:

[ ] get green build on Auth PR (I think I have this, went green locally)
[ ] get green build locally using Web-E feature branch
[ ] cleanup Auth PR
[ ] put Auth PR out for review
[ ] get Auth PR merged
[ ] immediately get Web-PR merged
[ ] create PR and do this issue to finalize changes: https://github.com/Expensify/App/issues/47528

Half day today, didn't make progress. I'm stumped as to why this 1 web-integration test is passing locally and failing in GH. Will come back Monday and work on it.

Working on this today.

Okay I think I finally figured out why that last test isn't passing on the Auth PR. The integration tests we run for Auth PRs are based off the production web branch, and the production branch is waiting for changes to be deployed that we need in order to get a green build. See comment here.
So waiting for those changes to be deployed, meanwhile I'll work on cleaning up the PR and getting the web-PR ready for review.

Green build on Auth PR 🎉, working on getting green build locally using the web feature branch, 1 failing test left.

Got a green build locally on the web feature branch! 🎉
Lot of clean up to be done but the checklist is getting completed.

Got green build locally for the feature branch, 2nd checkbox is done

Lots of progress today, got the auth pr out for review and cleaned up both the auth PR and web PR. Waiting for feedback now.

Good progress today, got my initial round of feedback on the PR from two reviewers, working through that feedback now.

Not overdue, just responded to feedback, working on getting green build again and getting approval.

Not overdue, almost done with this. See checklist. Will put a PR up for the last checklist item today. Will take awhile to get a green build though I think because we will probably have to wait for our web changes to get deployed to production before we'll be able to get a green build on the web-integration tests.

Almost there, web changes just got deployed to production, attempting to get a green build on the last little auth PR here

Got green build, PR is out for review

Closing since there is a whole other issue dedicated to tracking the final checkbox of this issue and all other work is done

renamed because we didn't make the command fully 1:1:1, we just made it more 1:1:1, enough to unblock other issues


Missing information on how to hide particle effects for "minecraft:mob_effect"

The "minecraft:mob_effect" component should have an argument to hide particle effects, I feel this may be undocumented can there be a check to see if this is the case or not?

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: b3993467-7aa1-087a-c199-103138f936be
Version Independent ID: edea3456-6917-eb63-6948-76bef8347999
Content: Entity Documentation - minecraft:mob_effect
Content Source: creator/Reference/Content/EntityReference/Examples/EntityComponents/minecraftComponent_mob_effect.md
Product: gaming
GitHub Login: @JDHeaden
Microsoft Alias: v-jillheaden

I did a quick look at the source-code, and it looks like there isn't an argument to hide particle effects. This component appears to be accurately documented.


import ngt ok but import ngtpy show  No module named 'ngtpy

pip3 install ngt and it happend
python=3.8
pip3 list
show ngt = 1.12.2

read code.
and can use this
from ngt import base as ngt
ngt.Index.create(...)

There are two types of NGT python packages:  ngtpy and ngt, but ngt is now not maintained.
Since you can use the ngt python package, I think that you have already built and install NGT from the source code. When you use ngtpy that is installed with pip from pypi, you don't need to install NGT from the source code. The installed NGT from the source code might cause this issue.

it's not, I can't installed NGT from source code. because my mac os version, probably. make it, show error. And I just use pip3 install it.
And of course, show ngtpy No module balabala.
However even it done.
like use this ngt.index.create(), it's still not work. show errors .
I just know it's not the NGT error. it's my os version or something else.
And my is Catalina
And I'm quit that.
And the End, Thank You!


How to start the services at login

I want to have dinghy available as soon as I start my Mac. Is this possible?
Ideally it can be added to the FAQ :)
Thanks

This would be difficult right now because Dinghy requires sudo for a couple tasks, so you need user interaction. Maybe it could be made to work by running the entire dinghy start operation as root, but I don't think that would work today, it'd probably take some code changes.

Just what I imagined. I will report if I figure something out


generate assets with multi-line text

Added functionality to create assets with multi-line text. The character ^ in the text field will start a new line of text on the asset.

Nice feature! 😄

What are the use cases for doing this?

Sorry .. I did not see your question. I know that google frowns on using text in launch icons but I wanted to include both company and product name on icon. I see you closed, so the code will be in my repo.


Deploy to datatools-builds bucket (now IBI-controlled)

Checklist

[x] Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
[x] Any modified or new methods or classes have helpful JavaDoc and code is thoroughly commented
[x] The description lists all applicable issues this PR seeks to resolve
[x] The description lists any configuration setting(s) that differ from the default settings
[x] All tests and CI builds passing

Description
This PR changes the AWS S3 credentials https://docs.travis-ci.com/user/deployment/s3/

Codecov Report

:exclamation: No coverage uploaded for pull request base (dev@ae1e56a). Click here to learn what that means.
The diff coverage is n/a.

@@          Coverage Diff           @@
##             dev     #232   +/-   ##
======================================
  Coverage       ?   19.83%
  Complexity     ?      361
======================================
  Files          ?      149
  Lines          ?     7462
  Branches       ?      996
======================================
  Hits           ?     1480
  Misses         ?     5850
  Partials       ?      132

Flag
Coverage Δ
Complexity Δ

#unit_tests
19.83% <ø> (?)
361 <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae1e56a...384440e. Read the comment docs.

:tada: This PR is included in version 3.6.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Add component tests

Adds various automated component testing tools
Checklist

[ ] Keep pull requests small so they can be easily reviewed.
[ ] Update the documentation.
[ ] Update the ./CHANGELOG.md.
[ ] Link this PR to related issues.

Added testing with conftest. Example output:
$ make test
docker run --rm --user="1000" --volume "[...]/commodore/dependencies/espejo/../../:/app/data" --workdir /app/data projectsyn/commodore:latest component compile dependencies/espejo
Agent pid 9
grep: /app/.ssh: No such file or directory
No SSH keys were added
Compile component espejo...
Updating Jsonnet libraries...
Compiling catalog...
Dependency https://github.com/vshn/espejo/releases/download/v0.3.1/espejo-crd.yaml: fetching now
Dependency https://github.com/vshn/espejo/releases/download/v0.3.1/espejo-crd.yaml: successfully fetched
Not updating /app/data/dependencies/espejo/manifests/v0.3.1/crds/espejo-crd.yaml (file already exists)
Dependency https://github.com/vshn/espejo/releases/download/v0.3.1/espejo-crd.yaml: saved to /app/data/dependencies/espejo/manifests/v0.3.1/crds/espejo-crd.yaml
Compiled test (0.17s)
 > Component compiled to /app/data/compiled/test
Postprocessing...
cd tests/go && go test ./...
ok  	github.com/projectsyn/component-espejo	(cached)
docker run --rm --volume "[...]/commodore/dependencies/espejo/tests/conftest:/policy" --volume "[...]/commodore/dependencies/espejo:/test" --workdir /test openpolicyagent/conftest:latest test --policy /policy compiled/test/espejo/00_crds/espejo-crd.yaml compiled/test/espejo/05_rbac.yaml compiled/test/espejo/10_deployment.yaml compiled/test/espejo/01_namespace.yaml
FAIL - compiled/test/espejo/10_deployment.yaml - Container 'espejo' in Deployment 'espejo' has invalid args: ["--enable-leader-election=true", "--metrics-addr=:8080", "--reconcile-interval=10m", "--verbose=false"]

12 tests, 11 passed, 0 warnings, 1 failure, 0 exceptions

I gotta say, it took me 2 hours to understand this little bit of Rego syntax. The amount of boilerplate "code" it requires, is about the same as with Go unit tests, maybe even more without libraries (don't know if that's possible with Rego). we have to very careful whether we want to introduce an additional language into the tooling mix we have here already. Plain Go might be easier understood than Rego, especially in Kubernetes world.
WDYT so far, @srueg @corvus-ch ?

I did another read and research on conftest/Rego. I'm comparing now Go vs Conftest:

Approach
Advantages
Disadvantages

Conftest
* Easy to run and validate (docker run or directly with binary)* Sharing policies or applying them over all manifests allows us to enforce certain standards (and duh, policies) to all components. E.g. ensure all Deployments have the label app.kubernetes.io/managed-by=syn
sdadfas

Conftest Advantages

Easy to run and validate (docker run or directly with binary)
Sharing policies or applying them over all manifests allows us to enforce certain standards (and duh, policies) to all components. E.g. ensure all Deployments have the label app.kubernetes.io/managed-by=syn

Conftest Disadvantages

Rego creates higher entry level as it's harder to understand than imperative programming languages.
Contributors may not be interested in writing good component-specific policies.

Go unit test Advantages

Think I'm ready for a first round of review.
Example output here: https://github.com/projectsyn/component-espejo/runs/1320970624?check_suite_focus=true

for some reason now commodore (or whatever) always resets the git repo:
$ git remote -v
origin	https://fake.repo.url/ (fetch)
origin	git@github.com:projectsyn/component-espejo.git (push)

Any ideas?

for some reason now commodore (or whatever) always resets the git repo:
$ git remote -v
origin	https://fake.repo.url/ (fetch)
origin	git@github.com:projectsyn/component-espejo.git (push)

Any ideas?

Probably a side-effect of https://github.com/projectsyn/commodore/pull/236. I was wondering about that while reviewing, but assumed that this wouldn't happen as the tests passed. Apparently we don't have a "please don't break existing repos" test.

Please make sure that the outcome of this research PR is documented in an SDD: https://github.com/projectsyn/documentation/issues/113. Thanks.

@srueg your change request blocks merging this PR :)


Disabling the cache breaks push to Dokku

The last patch to disable the cache causes push to Dokku to fail...
remote: rm: cannot remove `/cache': Device or resource busy

Appreciate that this may not work on Heroku, but raising the bug to ensure any Dokku users either revert the patch in question or use my fork (where I've fixed this) until the cache issue is resolved.

This is an issue as cache deletion was re-introduced;
Can we add the env-var?

@Chris2048 and @kylef having myself experienced issues when deploying to Dokku, I believe I've found a solution as described here: #15.
What do you guys think?


[Service Bus] Fix broken code in readme and samples

This PR fixes #10188 which lists a bunch of places in the readme and samples where the apis dont match what we have in the source code

Looks good! For the samples, would running npm run build:samples have caught these issues

I believe so


[IMPROVEMENT] To avoid global document which listenning pullDownToRefresh event

This PR will resolve some case to using infinite scroll component.
For example, swiper of tabs view, pull down event will trigger all views fetch method.

Thanks @echoulen  :)


Double-check toolchain build flags

Here's what we currently document: https://bubble.servers.lowrisc.org/doc/ug/getting_started_sw.html

Is medany the right code model?
It should be imc, we currently propose ic. This needs to be changed.

In the move to our own toolchain, we chose the arguments -march=rv32imc -mabi=ilp32 -mcmodel=medany, which is the same that we recommend to people bringing their own toolchain: https://docs.opentitan.org/doc/ug/install_instructions/#option-2-compile-your-own-gcc-toolchain

-march=rv32imc is correct for ibex.
-mabi=ilp32 is the only compatible ABI for this platform
-mcmodel=medany seems the right choice for the moment. This allows programs to be located in any 2GB segment of memory. We may move to -mcmodel=medlow which requires programs to be located in the low 2GB of memory, but it would only help if we really want to avoid auipc instructions.

Thanks for updating on this Sam. I propose we mark this issue closed.

Yeah, I think we can close this. We'll open a new issue if we choose to move to medlow, or once we enable the bit manipulation instructions :)


Add stricter type checking

This adds in some stricter type checking which is easy to add now but more difficult to add later. Most of these are properties which can be added without having to change any Reliability Kit code, the exception being noImplicitOverride (see below). I think it's worth adding these in so that we catch these kinds of issues if they're ever introduced.
noImplicitOverride: This option requires you to acknowledge when you're overriding a property or method on a parent class. This ensures that TypeScript will error if we ever change methods or properties on a base class but miss any extending classes. It requires that we add an @override tag to extended class members and I've added these.
Documentation for all of these options is here.

@override is required if you declare anything on a child class which matches a name on a parent class. It doesn't matter if you make modifications to the signature of that property/method, you still need to explicitly say you're overriding. I don't think that changing @readonly or @public is actually valid anyway under TypeScript (even without this change)


Changing icon when plugged in

Currently, the Battery Indicator does not show whether the laptop is plugged in.
It would be useful to show the laptop is plugged in as in the generic Windows Battery Indicator.

There is no charging icon provided by Microsoft in Fluent Icons that I could find

You can check them here.
Several styles and options (eg. BatteryCharging# for 22H2, MobBatteryCharging# for 21H2)

There is no charging icon provided by Microsoft in Fluent Icons that I could find

You can check them here.
Several styles and options (eg. BatteryCharging# for 22H2, MobBatteryCharging# for 21H2)


Add a C++ GT-Pin support library for use by hpcrun

Intel's GT-Pin tool now only has a C++ API for certain functionality.  Setting GT-Pin control knobs is one of the features only available through C++. Create a separate C++ library for hpcrun to load that controls GT-Pin knobs.

I'm committing this without review because I am having trouble moving forward with gtpin without everything knit into one branch (develop). we can talk about how to improve my ability to use git without merging PRs all of the time.

PR looks fine to me (was about to hit "approve" when it got merged).
@jmellorcrummey I'd be game to hold a Git mini-training session, if that would help. We can discuss next week.


Cannot read property 'toLowerCase' of undefined

After ejecting my expo project and running react-native run-dom I got the following error message:
Uncaught TypeError: Cannot read property 'toLowerCase' of undefined
    at new RNDomInstance (ReactDom.js:formatted:1)
    at ReactDom.js:formatted:1
    at loadModuleImplementation (ReactDom.js:formatted:1)
    at guardedLoadModule (ReactDom.js:formatted:1)
    at metroRequire (ReactDom.js:formatted:1)
    at ReactDom.js:formatted:1

Welp. After digging around I found that react-native-dom does not work with RN v0.57 :\
So unfortunate to see this project get wasted, this project is so interesting and very useful.


AppDeployIntegrationTest "an unhealthy app fails to deploy"

Marked as serial in cc82191e0fffff21b1d6b1c3380089513473affb and is passing now.


"ConnectorInfo command --help" doesn't work

Preflight Checklist

[X] I have installed the latest version of Power Query SDK.
[X] I have checked existing resources, including the common issues and the release notes.
[X] I have searched for similar issues.

Power Query SDK
0.1.7
Regression From
No response
Platform
Windows
Architecture
x64
OS Version
No response
VSCode version
No response
PQSdkTool Path
No response
Bug Description
When ConnectorInfo is run without any arguments, it outputs the following text:
Usage: ConnectorInfo [arguments] [options] [command]

Arguments:
  Connector file   Full path to connector (.mez/.pqx)
  Expression file  Full path to a file containing an M expression (.m/.pq)

Options:
  -?  | -h | --help  Show help information

Commands:
  dsr      Extracts DSR from expression.
  kind     Returns data source kind information.
  module   Returns the module name or an error if missing.
  version  Returns module version information or an error if missing.

Use "ConnectorInfo [command] --help" for more information about a command.

However, the help option reported by the last line does not work.
Steps to Reproduce
PS> .\ConnectorInfo.exe dsr --help

Unhandled Exception: Microsoft.Extensions.CommandLineUtils.CommandParsingException: Unrecognized option '--help'
   at Microsoft.Extensions.CommandLineUtils.CommandLineApplication.HandleUnexpectedArg(CommandLineApplication command, String[] args, Int32 index, String argTypeName)
   at Microsoft.Extensions.CommandLineUtils.CommandLineApplication.Execute(String[] args)
   at ConnectorInfo.Program.Main(String[] args)

Actual Experience
A textual rendering of an exception is output.
Expected Experience
Descriptive help text should be output.
Additional Context
Similar exception output occurs if other -args values (like -x) are used. Instead, shouldn't a user-friendly error about -x being an invalid argument be displayed?

This will be resolved in the next SDK Tools update (ETA 11/4).

Thanks, Matt!


'is-active" class added to all menu-bar action sheet items

I have a series of 3 action sheets in a menu bar along the top. Upon activating a single action sheet, it adds the 'is-active' class to  all action sheet buttons, changing the color.

                2

Notification 1

Notification 2

Notification 3

Setting 1

Setting 2

Setting 3

Option 1

Option 2

Option 3

Before:

After click of any item:

While debugging this issue, I found name mismatch between css classes and angular directives
map of css classes names to angular directives
.action-sheet-container -> zf-action-sheet
.action-sheet                -> zf-as-content
There is no is-active class for action-sheet-container, but it is considered in angular directive.
This is the main reason for this issue.
.

The first issue is one of selector specificity, so adding a bunch of >s should help, and won't break any existing code. We had this issue with another component where is-active was cascading down too far.

It also need cleanup in angular directive because it is adding is-active class for div containing action-sheet-container class.

@akiran I can take care of that part.

@AntJanus, Still few more things need to be taken care of to support this usecase.
Actionsheet is slightly different from other components.
In all other components, zf-closable, id, is-active class is applied on element that is shown/hidden with events.
But in actionsheet, zf-closable and id is applied in zf-action-sheet which is always shown and
is-active is applied on zf-as-content which is shown/hidden with events. Because of this zf-hard-toggle is not working as expected.
I tried to submit a PR for this issue, but couldn't do because of these issues.

Hmm, I'll look into it further. Thanks for researching this issue.

#381 caused menu bar links to be in color of links instead of black color on white bg

Can anyone test if this issue is still there? I'm 99% sure I already applied a fix.

Going to close this, if the problem still persists let us know. :)


various parser improvments and test additions

Codecov Report
Base: 68.32% // Head: 68.51% // Increases project coverage by +0.19% :tada:

Coverage data is based on head (dd248a3) compared to base (ecd54bb).
Patch coverage: 52.88% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #34      +/-   ##
==========================================
+ Coverage   68.32%   68.51%   +0.19%
==========================================
  Files          16       17       +1
  Lines        1831     1858      +27
  Branches      803      815      +12
==========================================
+ Hits         1251     1273      +22
+ Misses        127      124       -3
- Partials      453      461       +8

Impacted Files
Coverage Δ

src/patch.cpp
53.46% <27.77%> (-1.23%)
:arrow_down:

src/parser.cpp
67.11% <57.14%> (+1.09%)
:arrow_up:

include/patch/parser.h
100.00% <100.00%> (ø)

src/formatter.cpp
76.31% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Candles sometimes have no width (and zoom is locked to minimum scale)

Description
I've noticed only sometimes (not always with this candle+indicator combination) that candles show as single lines and the chart zoom is locked to a minimum. This is reproducible with the latest version of the 101 project, with my dataset.
Screenshot (if applicable)

Data Sample (if applicable)
Zipped data.json - use instead of the data.json in the 101 project:
data_weirdCandles.json.zip
Console errors (if any)
None seen
Additional Info
All on latest / default.

The first thing to check is that timeframe detected correctly & candles are following that timeframe step (gaps are allowed)

tinycandles.json.zip
Another data sample - I really need to spend some time on this, as it's getting annoying haha:

@C451 you've mentioned checking if timeframe is detected correctly, is there a part of tvjs I should debug in this scenario?
Regarding timeframe step, do you suspect there might be overlapping timestamps, or what were your thoughts?

@tiagosiebler we have a new solution now, try to use
"chart": {
     "tf": <yo timeframe>
}

Thanks @C451 - is this in this tree of the chart dataset?
https://github.com/tvjsx/trading-vue-101/blob/master/data/data.json#L2
What's the datatype for the "tf" property? Can you provide an example for 5 minute candles?

Literally,
"chart": {
     "tf": <yo timeframe>
}

Or test's #11 data
Tiago, what happened to you?  Oops!


bootstraper-datepicker.js not working with jquery-steps

I have a date picker in my multi step (jquery-steps) form. Its stop working when I add the jquery-steps. If I remove the jquery-steps, it works fine. How to resolve this?
If I keep datepicker outside of the wizard, it works fine. Once I include inside the wizard, it stops working...

Solved:
You need to call it after wizard-steps. Like:
    $(function ()
    {
        $("#wizard").steps({
            headerTag: "h2",
            bodyTag: "section",
            transitionEffect: "slideLeft",
            saveState: true
        });
		$('.datepicker').datepicker({
			format: "dd-mm-yyyy",
			autoclose: true,
			todayHighlight: true,
			//orientation: "bottom"
			todayBtn: "linked",
			todayHighlight: true
		})
	});

Now, its working.


Invalid LNURL

Hi!
I am using the CLI but it says that the url is invalid, however if I decode the bech32 with lnurl implementation in node it works:
.
I am using a local ip with http (e.g. http://<IP_ADDRESS>:49392/***), is that the problem?

Might this be related to your PR #5  (thanks by the way!)? Or do you use a Tor proxy?


cherry picks

Cherry-picking a few bug fixes.
to: @graceguo-supercat @michellethomas @timifasubaa

Codecov Report

Merging #60 into airbnb-master will increase coverage by 0.07%.
The diff coverage is 100%.

@@                Coverage Diff                @@
##           airbnb-master      #60      +/-   ##
=================================================
+ Coverage          61.42%   61.49%   +0.07%
=================================================
  Files                370      370
  Lines              23546    23547       +1
  Branches            2737     2737
=================================================
+ Hits               14462    14480      +18
+ Misses              9072     9055      -17
  Partials              12       12

Impacted Files
Coverage Δ

superset/connectors/druid/views.py
68.02% <ø> (ø)
:arrow_up:

superset/viz.py
81.48% <100%> (+0.01%)
:arrow_up:

superset/models/core.py
85.34% <0%> (+0.17%)
:arrow_up:

superset/views/core.py
72.85% <0%> (+0.21%)
:arrow_up:

superset/utils.py
88.52% <0%> (+1.02%)
:arrow_up:

superset/db_engine_specs.py
52.19% <0%> (+1.4%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71138dd...388a438. Read the comment docs.


Basic example needs privilege escalation on linux

I forget where the cutoff lies (it may vary by distro), but linux restricts access to low-number ports (like 711). So you need sudo privileges to run basic.py.

Hi Jimrthy, thanks for pointing this out, basic.py is just an example to show how tornado-swagger works, the port number is changeable in the practical environment, for example, 8082 is leveraged in our official server.:)


chore(prow/config): add event router to tekton cd for for pingcap org

Signed-off-by: wuhuizuo<EMAIL_ADDRESS>
What problem does this PR solve?
Issue Number: close #xxx
Problem Summary:
What is changed and how it works?
What's Changed:

add forwarding as an external plugin for pingcap ORG.

How it Works:

forward the events to tekton event listener.

/approve


Fixed #219 opts.expectedFeeds no longer ignored when opts.stream is present

This was superseeded by hypercore-protocol:v7 new Protocol(true).prefinalize object in the form of a nano-guard


Adding new partner section for KTPs

Adding KTP links
Updating partner listings
Updating links

/approve

/assign @zacharysarah


Fixes

Lots of fixes to get more models to run with this. In a pretty good place now!

Codecov Report

Merging #44 (4f6f68f) into main (bf8c557) will decrease coverage by 11.16%.
The diff coverage is 45.42%.

@@             Coverage Diff             @@
##             main      #44       +/-   ##
===========================================
- Coverage   71.31%   60.15%   -11.16%
===========================================
  Files          15       16        +1
  Lines         739      881      +142
===========================================
+ Hits          527      530        +3
- Misses        212      351      +139

Flag
Coverage Δ

unittests
60.15% <45.42%> (-11.16%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

ocean_model_skill_assessor/CLI.py
0.00% <0.00%> (ø)

tests/test_main.py
100.00% <ø> (ø)

ocean_model_skill_assessor/main.py
39.14% <22.88%> (-25.98%)
:arrow_down:

ocean_model_skill_assessor/plot/map.py
24.07% <32.25%> (-2.40%)
:arrow_down:

ocean_model_skill_assessor/utils.py
53.64% <47.91%> (-4.26%)
:arrow_down:

ocean_model_skill_assessor/accessor.py
57.14% <62.50%> (+2.14%)
:arrow_up:

ocean_model_skill_assessor/plot/time_series.py
73.91% <75.00%> (ø)

ocean_model_skill_assessor/__init__.py
77.77% <83.33%> (-7.94%)
:arrow_down:

ocean_model_skill_assessor/stats.py
84.84% <84.61%> (-1.75%)
:arrow_down:

ocean_model_skill_assessor/paths.py
90.47% <90.47%> (ø)

... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


[schemas] make osquery decorations an optional key

to @mime-frame
cc @airbnb/streamalert-maintainers
Osquery decorators are optional, so our osquery log schema should also make them optional

Coverage remained the same at 79.307% when pulling bcfeb320eafb396be22014e6ba5c571d41917ab0 on jacknaglieri-osquery-schema-mod into f5b7163cdb7fdd8fbb4bd86c0e2bb4b5f02a0eb9 on master.


Disable pytest-xdist on circle ci testing

This might prevent failing tests for the main window

On a closer look, I don't think xdist is having any effect in our test suite because we're not calling it in any way.
So I'm moving this one to 3.1.4 for now :-)

I really don't think this is needed after PR #4171 (which I verified is working, yay!!)


[Do Not Merge] Use JSON schema for param validation

This PR is dependent on bundle-lib PR 100 (https://github.com/automationbroker/bundle-lib/pull/100)
If you would like to test it out, you can change Gopkg.toml to:
[[constraint]]
  name = "github.com/automationbroker/bundle-lib"
  branch = "jsonschema"
  source = "github.com/dymurray/bundle-lib"

Run:
$ dep ensure

Need to add some better output to the user for selecting params such as enums and whatnot before we merge this in. Ideally we also don't just exit but allow a user to fix invalid values when validation fails.


Release memory while applying transformations

This change can reduce memory usage and fix #45

@fbasso Thank you for your review!


OLS-110:added conversation history

Description
Add ability to include previous conversations for user query
Type of change

[ ] Refactor
[x] New feature
[ ] Bug fix
[ ] CVE fix
[ ] Optimization
[ ] Documentation Update
[ ] Configuration Update
[ ] Bump-up dependent library

Related Tickets & Documents

Related Issue (https://issues.redhat.com/browse/OLS-110)

Checklist before requesting a review

[x ] I have performed a self-review of my code.
[ ] PR has passed all pre-merge test jobs.
[ ] If it is a core feature, I have added thorough tests.

Testing

Please provide detailed steps to perform tests related to this code change.
How were the fix/results from this change verified? Please provide relevant screenshots or results.

Codecov Report
Attention: Patch coverage is 89.74359% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 96.10%. Comparing base (41dbeb3) to head (b5220da).
 Consider uploading reports for the commit 9f32b1c to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #555      +/-   ##
==========================================
- Coverage   96.77%   96.10%   -0.68%
==========================================
  Files          47       49       +2
  Lines        1457     1513      +56
==========================================
+ Hits         1410     1454      +44
- Misses         47       59      +12

Files
Coverage Δ

ols/app/endpoints/ols.py
100.00% <100.00%> (ø)

ols/src/cache/cache.py
100.00% <100.00%> (ø)

ols/src/cache/redis_cache.py
100.00% <100.00%> (ø)

ols/src/prompts/prompts.py
100.00% <100.00%> (ø)

ols/src/query_helpers/chat_history.py
100.00% <100.00%> (ø)

ols/src/cache/in_memory_cache.py
95.34% <83.33%> (-2.22%)
:arrow_down:

ols/src/query_helpers/docs_summarizer.py
95.38% <57.14%> (-4.62%)
:arrow_down:

... and 6 files with indirect coverage changes

/assign @asamal4

/lgtm

/approve


arm64 support

Getting an error when steamworks tries to use /dist/osx/steamworksjs.darwin-x64.node: incompatible architecture (have 'x86_64', need 'arm64e')
Working on a macbook pro with M1 chip
also, love the work you're doing with this project - excellent alternative to greenworks

This is already fixed on the main branch, will work fine in the next release.


about the checkpoint

the checkpoint you shared may be trained by the English dataset only, I saw your demo the model can
recognize the Japanese correctly.would you shared the checkpoint trained by the Japanese dataset.

@sszzy0317
The trained model we uploaded was trained with multi-language dataset including Japanese.
IC17-MLT dataset includes Chinese, Japanese, Korean, English, French, Arabic, Italian, German and Indian. (https://rrc.cvc.uab.es/?ch=8)
You can use the first link from the table.
https://github.com/clovaai/CRAFT-pytorch#test-instruction-using-pretrained-model


cannotUpdateApksOnTrackWithDraftRelease: Cannot update the APK configuration of the track when the track has a draft release. Please use UI to rollout or discard the draft release.

I'm trying out Fastlane deployment to Google Play Store. If followed the doc and instructions... I got the following error:
Google Api Error: cannotUpdateApksOnTrackWithDraftRelease:
Cannot update the APK configuration of the track when the track has a draft release.
Please use UI to rollout or discard the draft release.

I have a React Native app and I followed the instructions on RN's doc... and were successfully deployed to the Play Store.
A couple days later, I tried Fastlane to deploy some styling changes... I can't get it to work. I have to manually drag and drop the release apk in the console.
What is causing the error?

@hszeto Heeyyy 👋 I ran into this same error today while I was actually trying to look into #9363 😕 I'm thinking this may be an error in the google-api-client gem. I created a sample script outside of fastlane using just the google-api-client provided sample code and I still got this error.
However, after I manually submitted a build through the Google Play web dashboard, I was able to submit build again. Were you able to submit builds again via fastlane after you manually submitted them through Google Play?

Created on issue on google-api-client to see if we can diagnose this problem any further - https://github.com/google/google-api-ruby-client/issues/655

Same issue here.
I've tried to upload manually and it worked fine.
Any idea if it's a bug?
Here's the error:
+------+------------------+-------------+
|           fastlane summary            |
+------+------------------+-------------+
| Step | Action           | Time (in s) |
+------+------------------+-------------+
| 1    | default_platform | 0           |
| 2    | gradle           | 3           |
| 3    | gradle           | 621         |
| 💥   | supply           | 28          |
+------+------------------+-------------+
[19:32:12]: fastlane finished with errors
[!] Google Api Error: cannotUpdateApksOnTrackWithDraftRelease: Cannot update the APK configuration of the track when the trackhas a draft release. Please use UI to rollout or discard the draft release.


123729 - [Newsroom] Error Page - Content of the page is not translated and incorrect content

Severity - 3 - Medium
Steps to Reproduce:
In the migrated translated Error Page, content is not translated with respect to the language. Incorrect CTA text.
Migrated page: https://main--accenture-newsroom-de--hlxsites.hlx.live/test123
Legacy page: https://newsroom.accenture.de/test123
Expected:

Actual:

Azdo-link - https://dev.azure.com/accenturecio26/WebContentDigAssetMgmt_PR1093/_workitems/edit/123729
CC: @ravkiran @amol-anand  @raymond-h-dev

ES is not ready yet for review :)

@raymond-h-dev please update the keys in de placeholders.xlsx

can this be closed? @veejayricana

Hi @amol-anand and @ravkiran I already update the placeholder for de but still text is not translated to its specific translation.

@veejayricana this needs some code change, as 404 page may not be using the placeholders in all the places, I'll check this shortly.