Application Profiler Uploader not working in .NET 6 Preview (on Azure App Service Linux Container)

Hello 👋 ,
I'm running into issues when running App Insights Profiler in a Linux Container Azure App Service
Currently unable to upload the logs.
Running .NET 6 RC2 project reference,
FROM mcr.microsoft.com/dotnet/aspnet:6.0.0-rc.2-focal AS base
Referencing:
<PackageReference Include="Microsoft.ApplicationInsights" Version="2.19.0-beta1"/>
<PackageReference Include="Microsoft.ApplicationInsights.AspNetCore" Version="2.19.0-beta1"/>
<PackageReference Include="Microsoft.ApplicationInsights.Profiler.AspNetCore" Version="2.3.1-beta2"/>

2021-11-07T19:20:25.447534596Z [19:20:25 INF] Uploader to be used: /tmp/ServiceProfiler/2.6.2111.401/Uploader/Microsoft.ApplicationInsights.Profiler.Uploader.dll
 It was not possible to find any compatible framework version
 The framework 'Microsoft.NETCore.App', version '5.0.0' (x64) was not found.
   - The following frameworks were found:
       6.0.0-rc.2.21480.5 at [/usr/share/dotnet/shared/Microsoft.NETCore.App]

 You can resolve the problem by installing the specified framework and/or SDK.

 The specified framework can be found at:
   - https://aka.ms/dotnet-core-applaunch?framework=Microsoft.NETCore.App&framework_version=5.0.0&arch=x64&rid=ubuntu.20.04-x64
 [19:20:25 INF] Finished calling trace uploader. Exit code: 150
 [19:20:25 ERR] Trace upload failed. Exit code: 150
 [19:20:55 ERR] Unexpected error happens on stopping service profiler.
 System.OperationCanceledException: The operation was canceled.
    at System.Threading.CancellationToken.ThrowOperationCanceledException()
    at System.IO.Pipes.NamedPipeClientStream.ConnectInternal(Int32 timeout, CancellationToken cancellationToken, Int32 startTime)
    at System.IO.Pipes.NamedPipeClientStream.<>c__DisplayClass20_0.<ConnectAsync>b__0()
    at System.Threading.ExecutionContext.RunFromThreadPoolDispatchLoop(Thread threadPoolThread, ExecutionContext executionContext, ContextCallback callback, Object state)
 --- End of stack trace from previous location ---
    at System.Threading.Tasks.Task.ExecuteWithThreadLocal(Task& currentTaskSlot, Thread threadPoolThread)
 --- End of stack trace from previous location ---
    at Microsoft.ApplicationInsights.Profiler.Core.IPC.DuplexNamedPipeService.ConnectAsync(String pipeName, CancellationToken cancellationToken)
    at Microsoft.ApplicationInsights.Profiler.Core.ServiceProfilerProvider.<>c__DisplayClass4_0.<<PostStopProcessAsync>b__0>d.MoveNext()
 --- End of stack trace from previous location ---
    at Microsoft.ApplicationInsights.Profiler.Core.ServiceProfilerProvider.PostStopProcessAsync(PostStopOptions e, CancellationToken cancellationToken)
 [19:20:55 ERR] Unexpected error happens on stopping service profiler tracing.
 System.OperationCanceledException: The operation was canceled.
    at System.Threading.CancellationToken.ThrowOperationCanceledException()
    at System.IO.Pipes.NamedPipeClientStream.ConnectInternal(Int32 timeout, CancellationToken cancellationToken, Int32 startTime)
    at System.IO.Pipes.NamedPipeClientStream.<>c__DisplayClass20_0.<ConnectAsync>b__0()
    at System.Threading.ExecutionContext.RunFromThreadPoolDispatchLoop(Thread threadPoolThread, ExecutionContext executionContext, ContextCallback callback, Object state)
 --- End of stack trace from previous location ---
    at System.Threading.Tasks.Task.ExecuteWithThreadLocal(Task& currentTaskSlot, Thread threadPoolThread)
 --- End of stack trace from previous location ---
    at Microsoft.ApplicationInsights.Profiler.Core.IPC.DuplexNamedPipeService.ConnectAsync(String pipeName, CancellationToken cancellationToken)
    at Microsoft.ApplicationInsights.Profiler.Core.ServiceProfilerProvider.<>c__DisplayClass4_0.<<PostStopProcessAsync>b__0>d.MoveNext()
 --- End of stack trace from previous location ---
    at Microsoft.ApplicationInsights.Profiler.Core.ServiceProfilerProvider.PostStopProcessAsync(PostStopOptions e, CancellationToken cancellationToken)
    at Microsoft.ApplicationInsights.Profiler.Core.ServiceProfilerProvider.StopServiceProfilerAsync(IProfilerSource source, CancellationToken cancellationToken)
 [19:20:55 ERR] Unexpected exception in the last circle.
 System.OperationCanceledException: The operation was canceled.
    at System.Threading.CancellationToken.ThrowOperationCanceledException()
    at System.IO.Pipes.NamedPipeClientStream.ConnectInternal(Int32 timeout, CancellationToken cancellationToken, Int32 startTime)
    at System.IO.Pipes.NamedPipeClientStream.<>c__DisplayClass20_0.<ConnectAsync>b__0()
    at System.Threading.ExecutionContext.RunFromThreadPoolDispatchLoop(Thread threadPoolThread, ExecutionContext executionContext, ContextCallback callback, Object state)
 --- End of stack trace from previous location ---
    at System.Threading.Tasks.Task.ExecuteWithThreadLocal(Task& currentTaskSlot, Thread threadPoolThread)
 --- End of stack trace from previous location ---
    at Microsoft.ApplicationInsights.Profiler.Core.IPC.DuplexNamedPipeService.ConnectAsync(String pipeName, CancellationToken cancellationToken)
    at Microsoft.ApplicationInsights.Profiler.Core.ServiceProfilerProvider.<>c__DisplayClass4_0.<<PostStopProcessAsync>b__0>d.MoveNext()
 --- End of stack trace from previous location ---
    at Microsoft.ApplicationInsights.Profiler.Core.ServiceProfilerProvider.PostStopProcessAsync(PostStopOptions e, CancellationToken cancellationToken)
    at Microsoft.ApplicationInsights.Profiler.Core.ServiceProfilerProvider.StopServiceProfilerAsync(IProfilerSource source, CancellationToken cancellationToken)
    at Microsoft.ApplicationInsights.Profiler.Core.Orchestration.OrchestratorEventPipe.StopProfilingAsync(SchedulingPolicy policy, CancellationToken cancellationToken)
    at Microsoft.ServiceProfiler.Orchestration.SchedulingPolicy.StartPolicyAsync(CancellationToken token)

Can you please advice?

@AAimson Thanks for the report. Let me take a look.

Hi @AAimson , do you mind try it with this environemnt variable in your container as a quick workaround:
DOTNET_ROLL_FORWARD:LatestMajor

I think I found out why and I need another release to fix the issue.

The fix is released with 2.3.1-beta3. Please give it a try.


Serialise lists of Rickles

When serialising a rickle that has a list which contains rickles (ie deep) then the deeply nested rickles need to be derickled

won't fix as this is only a problem for serving via http, and then it's a developer's responsibility


Suggested improvements to "dart fix" UI

I used "dart fix" for the first time today. It's fantastic!
I would propose two changes to the UI:

when describing the changes, rather than "UNDEFINED_NAMED_PARAMETER - 1 fix" or similar, it would be nice to say something like "migrated from 'resizeToAvoidBottomPadding' to 'resizeToAvoidBottomInset'" or some such, to give some context about the change.
For the dry run, it would be really useful to have it describe what it wants to do in the form of a patch file.

@devoncarew
I suspect that the first would require some additional support from server, and it appears to be specific to the data-driven fix support. I'll take a better look at what would be involved when I'm done adding the required test support.
The second can be done without additional work in server.

@devoncarew
I suspect that the first would require some additional support from server, and it appears to be specific to the data-driven fix support. I'll take a better look at what would be involved when I'm done adding the required test support.
The second can be done without additional work in server.

For the first item, we could do something like:
  UNDEFINED_NAMED_PARAMETER - 1 fix
  Migrate from the deprecated 'resizeToAvoidBottomPadding' API to the new 'resizeToAvoidBottomInset' API.

i.e., use a line below the change summary to provide brief context for the change.

For the first item, we could do something like:
  UNDEFINED_NAMED_PARAMETER - 1 fix
  Migrate from the deprecated 'resizeToAvoidBottomPadding' API to the new 'resizeToAvoidBottomInset' API.

i.e., use a line below the change summary to provide brief context for the change.

For this:

For the dry run, it would be really useful to have it describe what it wants to do in the form of a patch file.

We did have discussions about the best preview format to use for changes. There were concerns about producing output that was too detailed - just having a lot of information scrolling by.
A diff would however remove any mystery about the changes the tool would make.
It may be worth prototyping the output for a few different sets of changes in a gist or something.

For this:

For the dry run, it would be really useful to have it describe what it wants to do in the form of a patch file.

We did have discussions about the best preview format to use for changes. There were concerns about producing output that was too detailed - just having a lot of information scrolling by.
A diff would however remove any mystery about the changes the tool would make.
It may be worth prototyping the output for a few different sets of changes in a gist or something.

Another possibility to consider, if there's enough demand for it, would be something like a --patch=filePath option that would cause the tool to write an actual patch file.

Another possibility to consider, if there's enough demand for it, would be something like a --patch=filePath option that would cause the tool to write an actual patch file.

I could see having a --summary mode that says what APIs were migrated, and a --patch mode that generates the actual patch. I have to say though, as an engineer, at the end of the day, what I care about is the patch. In my case, what I did was make sure my git repo was clean, apply the migration, then look at the diff, because that's all I actually cared about at the end of the day. I don't think we're doing engineers any favours by hiding the patch as being too detailed -- it's exactly the detail we need.

I could see having a --summary mode that says what APIs were migrated, and a --patch mode that generates the actual patch. I have to say though, as an engineer, at the end of the day, what I care about is the patch. In my case, what I did was make sure my git repo was clean, apply the migration, then look at the diff, because that's all I actually cared about at the end of the day. I don't think we're doing engineers any favours by hiding the patch as being too detailed -- it's exactly the detail we need.

  UNDEFINED_NAMED_PARAMETER - 1 fix
  Migrate from the deprecated 'resizeToAvoidBottomPadding' API to the new 'resizeToAvoidBottomInset' API.

I would skip the first of those two lines. It's not really meaningful to me. The second line is super useful.

  UNDEFINED_NAMED_PARAMETER - 1 fix
  Migrate from the deprecated 'resizeToAvoidBottomPadding' API to the new 'resizeToAvoidBottomInset' API.

I would skip the first of those two lines. It's not really meaningful to me. The second line is super useful.

So I think what's being requested here is

for the default output to be a patch file,
for a --summary flag that produces a summary (which is currently the default output), and
for the summary output to report the fixes that were applied rather than the diagnostics that were fixed.

Does that sound right?

So I think what's being requested here is

for the default output to be a patch file,
for a --summary flag that produces a summary (which is currently the default output), and
for the summary output to report the fixes that were applied rather than the diagnostics that were fixed.

Does that sound right?

That would be great!

That would be great!


Add:

Company
INKFISH digital marketing
Description
INKFISH provides a learning platform where individuals from all walks of life are overseen by a quality-driven team of experts, ensuring your brand, website, and digital marketing. Participating in a web design and SEO apprenticeship will provide you with the opportunity to work for real clients under professional supervision. Time management and communication are vital to this position, as you will need to follow directions and be a contributing member of the INKFISH team. You will work in the web design department learning the ins and outs of SEO best practices and how to properly incorporate this into optimized web content.
Link
https://inkfish.digital/academy-2/web-team/
Location
Remote
Featured Image
https://inkfish.digital/wp-content/uploads/2021/09/INKFISH-web-team-banner.jpg

By submitting this issue, I have verified the following ✅

[] Checked to see if the apprenticeship has already been added before 🤔
[] Made sure all the details were provided 🔍

@changangus this looks like it qualifies!


Added retreive pending devices script.

@mzmaili : Thanks for your contribution! The author(s) have been notified to review your proposed change.

The PG will review and decide what to do with the script going forward. Thanks for your contribution.

#please-close


added multiple disease predictor

Fixes #998
These algorithms aim to predict multiple types of diseases simultaneously, including diabetes, heart disease, and kidney disease. By leveraging advanced machine learning algorithms and comprehensive medical data, these models provide users with early warnings and actionable insights to manage their health proactively.

Please review my pull request @Niketkumardheeryan

Can you please review it @Niketkumardheeryan  it's the last day & no new PR could be merged after 7pm

@samarsajad this kind of models already there , thanks for giving your valuable time.


Suddenly unable to connect to the Power BI Service using Connect-PowerBIServiceAccount

I've developed a script which performs basic operations with the Power BI service using PowerShell.
All worked fine until 4 days ago and now suddenly I'm not able to login anymore.
By default login is with a Service Principal, however I also tried with a normal AAD account but no luck (login with UI to app.powerbi.com works with the AAD account). I haven't changed anything in the script or on the tenant (it is an O365 demo tenant).
Command:
$ServicePrincipalId = "xxxxx"
$ServicePrincipalSecret = "xxxxx"
$tenant = "xxxx"

$secureServicePrincipalPassword= ConvertTo-SecureString $ServicePrincipalSecret -AsPlainText -Force;

$servicePrincipal = New-Object -TypeName PSCredential -ArgumentList $ServicePrincipalId, $secureServicePrincipalPassword

Connect-PowerBIServiceAccount -ServicePrincipal -Credential $servicePrincipal -Environment Public -Tenant $tenant`

Error:
Connect-PowerBIServiceAccount : One or more errors occurred.
At line:1 char:1
+ Connect-PowerBIServiceAccount -Credential (Get-Credential)
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (:) [], AggregateException
    + FullyQualifiedErrorId : System.AggregateException

Module Version:
1.0.867 (current version) MicrosoftPowerBIMgmt.Profile
Maybe @jayanth2830 can help as last committer?

Hi @julmoser, can you run the powerbi login cmdlet again, run Resolve-PowerBIError and share the output? I am unable to reproduce the issue on my machine with the same module version.

I have the same issue with latest version using just Login-PowerBI and cannot login. I get this output:

Message        : Failed to populate environments in settings
StackTrace     :    at System.Management.Automation.MshCommandRuntime.ThrowTerminatingError(ErrorRecord errorRecord)
Exception      : System.Exception
InvocationInfo : {Connect-PowerBIServiceAccount}
Line           : Login-PowerBI
Position       : At line:1 char:1
+ Login-PowerBI
+ ~~~~~~~~~~~~~
HistoryId      : 5

@ay5h that error means that the cmdlet is unable to fetch environments from https://api.powerbi.com/powerbi/globalservice/v201606/environments/discover?client=powerbi-msolap. Can you try to make a POST request with empty body to this endpoint using a service like Postman and confirm that you are getting results back?
Also, can you please update here with what happens when you install an older version and try to login?

Thanks @jayanth2830 - I am able to get a successful result via Postman. However if then go back into PowerShell and run:
Command
$uri = "https://api.powerbi.com/powerbi/globalservice/v201606/environments/discover?client=powerbi-msolap"
Invoke-RestMethod -Uri $uri -Method POST
I get this error:
Message        : The underlying connection was closed: An unexpected error occurred on a send.
StackTrace     :    at Microsoft.PowerShell.Commands.WebRequestPSCmdlet.GetResponse(WebRequest request)
                    at Microsoft.PowerShell.Commands.WebRequestPSCmdlet.ProcessRecord()
Exception      : System.Net.WebException
InvocationInfo : {Invoke-RestMethod}
Line           : Invoke-RestMethod -Uri $uri -Method POST
Position       : At line:4 char:1
                 + Invoke-RestMethod -Uri $uri -Method POST
                 + ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
HistoryId      : 3
Message        : Unable to read data from the transport connection: An existing connection was forcibly closed by the remote host.
StackTrace     :    at System.Net.TlsStream.EndWrite(IAsyncResult asyncResult)
                    at System.Net.ConnectStream.WriteHeadersCallback(IAsyncResult ar)
Exception      : System.IO.IOException
InvocationInfo : {Invoke-RestMethod}
Line           : Invoke-RestMethod -Uri $uri -Method POST
Position       : At line:4 char:1
                 + Invoke-RestMethod -Uri $uri -Method POST
                 + ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
HistoryId      : 3
Message        : An existing connection was forcibly closed by the remote host
StackTrace     :    at System.Net.Sockets.Socket.EndReceive(IAsyncResult asyncResult)
                    at System.Net.Sockets.NetworkStream.EndRead(IAsyncResult asyncResult)
Exception      : System.Net.Sockets.SocketException
InvocationInfo : {Invoke-RestMethod}
Line           : Invoke-RestMethod -Uri $uri -Method POST
Position       : At line:4 char:1
                 + Invoke-RestMethod -Uri $uri -Method POST
                 + ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

From https://evotec.xyz/invoke-restmethod-the-underlying-connection-was-closed-an-unexpected-error-occurred-on-a-send-while-connecting-graph-api/:
It seems to be because of TLS version mismatch, please try the command mentioned in the post: Run [Net.ServicePointManager]::SecurityProtocol = [Net.SecurityProtocolType]::Tls12 before running your script.

@julmoser Are you still facing the issue? If you are, can you try to run powershell with no profile and try again? Start -> run -> powershell -noprofile.


docs: Add link to agent server compatibility  matrix

What does this PR do?
This PR adds a link to the Agent/Server compatibility matrix.
Related issues
For https://github.com/elastic/apm/issues/229.
Screenshots

Codecov Report

Merging #1098 into master will increase coverage by 1.09%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1098      +/-   ##
============================================
+ Coverage     58.82%   59.92%   +1.09%
  Complexity       87       87
============================================
  Files           334      327       -7
  Lines         15539    14764     -775
  Branches       2209     2060     -149
============================================
- Hits           9141     8847     -294
+ Misses         5778     5317     -461
+ Partials        620      600      -20

Impacted Files
Coverage Δ
Complexity Δ

...stic/apm/agent/jdbc/ConnectionInstrumentation.java
60.00% <0.00%> (-12.73%)
0.00% <0.00%> (ø%)

...astic/apm/agent/jdbc/StatementInstrumentation.java
26.61% <0.00%> (-12.06%)
0.00% <0.00%> (ø%)

...pm/agent/profiler/asyncprofiler/AsyncProfiler.java
60.46% <0.00%> (-4.66%)
0.00% <0.00%> (ø%)

...m/agent/servlet/ServletVersionInstrumentation.java
29.78% <0.00%> (-3.55%)
0.00% <0.00%> (ø%)

...astic/apm/agent/bci/ElasticApmInstrumentation.java
58.82% <0.00%> (-2.29%)
0.00% <0.00%> (ø%)

...java/co/elastic/apm/agent/bci/ElasticApmAgent.java
73.38% <0.00%> (-2.17%)
0.00% <0.00%> (ø%)

...o/elastic/apm/agent/profiler/SamplingProfiler.java
77.65% <0.00%> (-1.12%)
0.00% <0.00%> (ø%)

...co/elastic/apm/agent/jdbc/JdbcInstrumentation.java
100.00% <0.00%> (ø)
0.00% <0.00%> (ø%)

...tic/apm/agent/servlet/helper/ApmAsyncListener.java
0.00% <0.00%> (ø)
0.00% <0.00%> (ø%)

.../agent/servlet/AbstractServletInstrumentation.java
100.00% <0.00%> (ø)
0.00% <0.00%> (ø%)

... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f19f290...523a21f. Read the comment docs.


Fix console build info in README.md

[x] Fix path to new package version
Note: Actual version is 1.1.0
[x] Fix permission issue by calling script using sh
Note: I believe taht this is the best day how to
fix all possible issues between various OS (Unixes)

Hello!
This is just update of README.md. Description is in commit message.

Bonus: use gulp.js to automate tests and build:
https://gist.github.com/turboMaCk/e2e5bdaee255cd2d1488

:+1:

@deadfoxygrandpa Any feedback?

Thanks, and I'll add the gulp.js stuff to the readme too.


RFC: Add psoc6

Added Cypress PSoC6 platform

@nazrchorn can you please squash your commits into logical units? more info here: http://docs.zephyrproject.org/contribute/contribute_guidelines.html

@nazrchorn can you please squash your commits into logical units? more info here: http://docs.zephyrproject.org/contribute/contribute_guidelines.html

I asked @nazrchorn to push this so I could give him feedback on such things

Pushed requested changes

@OlegKapshii Can you focus on the comments related to the uart driver.

I believe, that the PSoC6 UART driver is ready.

Not sure what should I do more here.

@OlegKapshii

Not sure what should I do more here.

Please see this comment https://github.com/zephyrproject-rtos/zephyr/pull/8408#issuecomment-414376131 for specific things to address, for starters. Beyond that, please don't include merge commits in PRs, rebase instead (so, this PR needs to be rebased). Thanks.

@nazrchorn, @OlegKapshii: It doesn't end there though. I can't get the serial output for BOARD=cy8ckit_062_wifi_bt_m0 either. Can you confirm that P12_0, P12_1 pins should be used in this case? Because when I attach the USB-UART adapter you gave me (based Cypress chip) to these pins, I don't get anything (flashed with the command above). To be sure, I swapped wires to the pins too.
But I have a feeling that the problem can be also with this adapter's driver/support in Linux.
Bottom line: again, need the exact docs for serial access and flashing to avoid guesswork and confusion.
@galak : FYI

Yes, BOARD=cy8ckit_062_wifi_bt_m0 works with P12 port, which is translated to USB socket.
Actually you should work with cy8ckit_062_wifi_bt_m0 for hello_world example. CM4 core does not starts by default, only CM0+ core works.
In order to have CM4 core working you should write FW for both cores (the same hello_world example, but with an additional command in main for CM0+ core) and CM0+ FW should start CM4 core using command in main - Cy_SysEnableCM4(0x10060000);
In any case, you should see the CM0+ output with BOARD=cy8ckit_062_wifi_bt_m0.

@OlegKapshii: Thanks for quick response!

Yes, BOARD=cy8ckit_062_wifi_bt_m0 works with P12 port, which is translated to USB socket.

Either I misunderstood what you wrote, or that's not correct, according to CY8CKIT-062-WiFi-BT_Kit_Guide.pdf, section 4.3.4, page 54, which says that PSoC6's pins P5[0], P5[1], P5[2], P5[3] are converted to onboard KitProg2's USB-UART Bridge. I.e. M4's UART on P5 would be exposed in this way, not M0's on P12. I know it's easy to mix up such things (especially if you work with many boards, and many people do), so the best way is to described that in the boards' docs as included in this PR.

CM4 core does not starts by default, only CM0+ core works.

Ok, then why do we have cy8ckit_062_wifi_bt_m4 as part of this PR, if it doesn't really work (per Zephyr's convention, i.e. main() just runs). It definitely needs more work, so I'd suggest to move it to another (next) PR. But it would be really nice to make it work (again, by Zephyr conventions), as using UART with builtin USB-UART converter is very convenient (again, especially if someone works with many boards).

@pfalcon

Either I misunderstood what you wrote, or that's not correct, according to CY8CKIT-062-WiFi-BT_Kit_Guide.pdf, section 4.3.4, page 54, which says that PSoC6's pins P5[0], P5[1], P5[2], P5[3] are converted to onboard KitProg2's USB-UART Bridge. I.e. M4's UART on P5 would be exposed in this way, not M0's on P12. I know it's easy to mix up such things (especially if you work with many boards, and many people do), so the best way is to described that in the boards' docs as included in this PR.

Yes, you are right. I do not have the board at home, so I looked into a schematic and misunderstood several pins. Now I see in the schematic that P12 port (which is used by CM0+) is connected to the socket pins. CM4 uses P5 pins which are translated to the USB.
Sorry. It is my mistake.
Sometimes there are bad contacts in sockets when you are using the UART-USB adapter, so check the wires. Check also that during connection to the COM port 115200, 8N1, none settings are used.

@OlegKapshii

Sometimes there are bad contacts in sockets when you are using the UART-USB adapter, so check the wires. Check also that during connection to the COM port 115200, 8N1, none settings are used.

Sure, I keep all that stuff in mind. As I wrote, I have a suspicion that Linux' driver plays bad with Cypress USB-UART chip. If you want details, what I tried is flashing "scan" sample from WICED SDK, which output chunk of data over serial very second or so. It outputs over P5, so I normally see it using the board's builtin USB-UART converter. So what I did is connected this external USB-UART board you gave me to the same P5.0, P5.1 pins, and tried to compare the output which I get from /dev/ttyACM0 (board builtin) and /dev/ttyACM1 (external adapter). So, the builtin works fully as expected. Now with /dev/ttyACM1, I first of all get an extra empty line after each line of output, e.g. as if \r\n was translated to \r\n\n. And I get only very first chunk of output after I connect, then it's silent. And I can get more output though - for this, I need to press some keys, i.e. send some input into the adapter. That all sounds pretty crazy of course. I'm on kernel 4.13. Let me know if you ever tested that adapter with Linux, and what kernel it was.
The most annoying is that I couldn't find a spare USB-UART adapter - as anyone, I usually have a few lying around, but I dug thru all my hardware here (and that's a bunch), and couldn't find any %). Anyway, I ordered one, hope to get it tomorrow, and will test with it.

Now with /dev/ttyACM1, I first of all get an extra empty line after each line of output, e.g. as if \r\n was translated to \r\n\n. And I get only very first chunk of output after I connect, then it's silent.

Confirmed that with CP2102 based USB-UART, I don't get this behavior, the output is fully consistent and synchronous with KirProg2's output.

Also confirming that with CP2102, I get serial output from the hello_world sample built for BOARD=cy8ckit_062_wifi_bt_m0 (on P12, as discussed above).

@OlegKapshii, @nazrchorn : So, now need to just refactor the code as suggested above, extend docs, make CI pass, get people remove their -1's and give the +1's. Let me know if you don't agree with some suggestions and/or need help with them. Thanks!

@OlegKapshii the approach is to always present the final layout of commits in the PR. So whenever you update your PR you rebase interactively and make the changes to the appropriate commits, or add/remove commits.

@OlegKapshii that means of course that some of your commits, like the one named "Minor fixes after review" need to be squashed into existing commits.

@OlegKapshii

should all my previous commits, in some way, be reverted and recommitted in a right way (using rebase)?

Revert, no, these commits are the good base, they just need to be augmented/fixed up/cleaned up a bit. As mentioned by @carlescufi, the way to do it is git's interactive rebase feature (git rebase --interactive or git rebase -i).
I'm not sure how well you're versed with it, let me try to give a quick intro, but feel free to read man/google for it.

First of all, need to do non-interactive rebase to avoid surprises in next steps. This will also get rid of the merge commit. So, assuming you're on add_psoc6 branch, run: git rebase master, then push the result: git push -f.
For starters, I'd suggest to perform interactive rebase on a separate branch, to be able to restart from scratch if something goes wrong. So, git checkout -b add_psoc-rebase.
Now just run git rebase -i master, and read carefully what will be written in the filed popping out in your editor. You should pay attention to: "If you remove a line here THAT COMMIT WILL BE LOST". The way I do and suggest to anyone is: perform single operation per interactive rebase interaction. I.e., if you need to make 10 changes, run git rebase -i ten times, verifying results after each - instead of trying to pack 10 changes into single run.
It's easy after that - e.g. to change a commit message, just replace default "pick" action with "reword" (or short "r"). E.g. when it was:

pick f6ecdc4267 ext: hal: cypress pdl: Integrate Cypress PDL into Zephyr Build system

change it to:
r f6ecdc4267 ext: hal: cypress pdl: Integrate Cypress PDL into Zephyr Build system

When you save change in your editor and quit, the actions will be performed, this commit message will be opened in your editor again, and you will be able to edit it.
Mastering "squash" or "fixup" operation will be next. Just keep in mind: squashing multiple commits together is much easier than splitting one commit into multiple. Don't haste with squashes, make sure you follow suggestions from the review above.
And you do have a commit which requires splitting - "Minor fixes after review". The way to do it is to use "edit" action, then when it stops on it:

git reset HEAD^
commit changes to each file individually (i.e. 3 commits).
continue rebase with git rebase --continue

Then start a new rebase -i to "fixup" those 3 newly created commits into initial commits which created corresponding files.
Let me know if you need other hints ;-). If you didn't practice rebase --interactive, it may seem daunting at first, but it's very powerful feature, and it's easy to master it (just follow suggestions like one change per rebase iteration). 80% of reviews require some changes, and that's what everyone doing in this case, so you're not alone! ;-)

Another note, regarding Cypress HAL import:
zephyr/ext/hal/cypress/PDL/3.1.0$ du -sh *
4.0K	CMakeLists.txt
1.2M	cmsis
90M	devices
34M	doc
3.7M	drivers
28K	utilities

I doubt that we need doc/ folder in Zephyr. @galak, @nashif: FYI

I did it. Thank you, @pfalcon . Your instructions were what I needed.

@OlegKapshii : Thanks for going thru that. I'd say, commits look much better now, but I didn't look into them in detail yet, because there's another problem: this PR now contains 19 commits, whereas previously it was 11.
It looks like the new changes were git-merged into the old PR, so it now contains both old and new sets. That's not the desired situation, the new changes were expected to replace the old ones completely. Generally, merge-based workflow is not compatible with rebase-based workflow, so either one or another should be used, and Zephyr uses rebase-based workflow. That means for example that "git pull" should not be used, instead "git pull --rebase" should be.
Anyway, let me look more into this and come up with suggestions on how to fix it.

Ok, here's how I was able to fix it. First of all, the recommended setup is that "master" branch always tracks upstream Zephyr and is up to date. I have "upstream" remote for upstream repo:
$ git remote get-url upstream
https://github.com/zephyrproject-rtos/zephyr

So, making sure master is up to date:
git checkout master
git pull --rebase upstream master

Now on to fix the add_psoc6 branch:
git checkout add_psoc6
git rebase -i master

In editor, I see (empty line inserted by me):
pick 1c42c4056e ext: hal: cypress: Import Cypress PDL for PSoC6 SoC Support
pick 84bbb34e4a ext: hal: cypress: Integrate Cypress PDL into Zephyr Build system
pick 72160e4f5b ext: hal: cypress: Protect floating point code with CONFIG_FLOAT
pick 3b1077585d arm: Add Cypress PSoC6 SoC support
pick 7daf0546c4 drivers: serial: Add Cypress PSoC6 UART driver
pick c9398fb170 boards: arm: Add Cypress PSoC6 cy8ckit_062_wifi_bt_m0 board support
pick d91de0e1ac boards: arm: Add Cypress PSoC6 cy8ckit_062_wifi_bt_m4 board support
pick 3c8c3fbf5a drivers: serial: Refactored Cypress PSoC6 UART driver

pick f6ecdc4267 ext: hal: cypress pdl: Integrate Cypress PDL into Zephyr Build system
pick d38c686db5 ext: cypress PDL: Protect floating point code with CONFIG_FLOAT
pick c0d977f666 arm: add PSOC6 SoC support
pick d904b7af1e add psoc6 uart driver
pick 548ebbf7f7 Add board support for cy8ckit_062_wifi_bt_m0
pick 4d298b6965 add boards cy8ckit_062_wifi_bt_m4
pick 259d5c21c3 Minor fixes after review
pick 826fbc7618 drivers: serial: Refactored Cypress PSoC6 UART driver
pick 75c00b377e Refactored PSoC6 UART driver

So, what we need is first set of commits. 2nd set after the empty line are old duplicates, it should be gone (@OlegKapshii, please verify that nothing is omitted in 1st chunk of course).
So, we leave in the editor only:
pick 1c42c4056e ext: hal: cypress: Import Cypress PDL for PSoC6 SoC Support
pick 84bbb34e4a ext: hal: cypress: Integrate Cypress PDL into Zephyr Build system
pick 72160e4f5b ext: hal: cypress: Protect floating point code with CONFIG_FLOAT
pick 3b1077585d arm: Add Cypress PSoC6 SoC support
pick 7daf0546c4 drivers: serial: Add Cypress PSoC6 UART driver
pick c9398fb170 boards: arm: Add Cypress PSoC6 cy8ckit_062_wifi_bt_m0 board support
pick d91de0e1ac boards: arm: Add Cypress PSoC6 cy8ckit_062_wifi_bt_m4 board support
pick 3c8c3fbf5a drivers: serial: Refactored Cypress PSoC6 UART driver

and save.
Verifying that everything builds for BOARD=cy8ckit_062_wifi_bt_m0 and BOARD=cy8ckit_062_wifi_bt_m4. And force push into this PR:
git push -f

In the future to pull changes from master branch, use:
git checkout master
git pull --rebase master
git checkout add_psoc6
git rebase master
git push -f

It seems, fixed

@OlegKapshii : Cool, thanks!

@pfalcon
There is a number of style-errors according to Shippable tests. Should I fix it to finish the PR?

@pfalcon
I have splitted/squashed the  "drivers: serial: Refactored Cypress PSoC6 UART driver" commit. All the code works fine on my PC, but I see some built errors in the Shippable log. Could you point me where the problem is, please?

I have splitted/squashed the "drivers: serial: Refactored Cypress PSoC6 UART driver" commit.

Nice, thanks! Now next step is to finally rebase in on main Zephyr master. If you look at https://github.com/nazrchorn/zephyr/tree/add_psoc6 , it says "This branch is 7 commits ahead, 1267 commits behind zephyrproject-rtos:master.", so this branch is quite a lot behind the current state of development. When you rebase, you'll notice that https://github.com/zephyrproject-rtos/zephyr/pull/9776 was merged now, which moved soc/ directories from under arch to the top-level one.
So, what was arch/arm/soc/cypress/CMakeLists.txt, now needs to be soc/arm/cypress/CMakeLists.txt. Now that the commits are clean, it should be easy to do: you just look what files were introduce in a particular commit, in your branch do  git mv ... just for those files, commit as a fix-up commit, then via rebase squash into the main commit. Repeat for other commits as needed.

All the code works fine on my PC, but I see some built errors in the Shippable log. Could you point me where the problem is, please?

So, steps above which would need to be done so far. Once the changes are on the top of latest master, we can look into making final pass to fix any CI issues, I'll be looking into them, yes.
Thanks!

@pfalcon
So, I have finished work in this PR and there are even no failed tests in Shippable.
Should I do here something else?

@pfalcon
And now there is a question how can I add PSoC6 IPM related code in Zephyr? As far as I understand - I cannot make a fork from the add_psoc6 branch and cannot commit in the add_psoc6 branch more. I cannot use also the master branch to fork from it, because it does not contain PSoC6 related code. What should I do here? Can you suggest anything, please?
Thank you

@OlegKapshii:

So, I have finished work in this PR and there are even no failed tests in Shippable.

Great, thanks!

Should I do here something else?

I had a look, and there're still some references to "nrf" flash controller still. Can you please fix those?
Then we should ping folks who previously left -1 review asking them to re-review.
@dbkinder, Can you have a look at the docs, they should be updated based on your earlier comments.

And now there is a question how can I add PSoC6 IPM related code in Zephyr? As far as I understand - I cannot make a fork from the add_psoc6 branch and cannot commit in the add_psoc6 branch more. I cannot use also the master branch to fork from it, because it does not contain PSoC6 related code. What should I do here? Can you suggest anything, please?

Yes, please keep this branch just for the initial addition and this PR. It may receive a fixup/cleanup commits yet (to be squashed), but no new functionality should be added indeed, to not put off review/merge further.
But what to do is simple: just create a new branch based on this branch, and work on it. It thus will depend on "add_psoc6" instead of master, and that's fine.
If you have "add_psoc6" branch active, just do git checkout -b psoc6-ipm, or whatever you want to call it.
The whole dependency picture will be:
upstream master -> master -> add_psoc6 -> psoc6_ipm
The only trick is that you should keep rebase workflow for all these branches, i.e. rebase one on top of another in cascade. I guess, if you just create psoc6_ipm now (or next week), you might work w/o rebasing for some time, so we can discuss it later.

Fixed all errors. All shippable tests passed.

@cvinayak : Your -1 was based on references to "nrf" in some of DTS files, those were fixed now, can you please re-review?
@galak: Can you please have a look too?

@dbkinder : Friendly ping about docs. Thanks!

Fixed

@dbkinder how do you feel about the docs?

No problems with the build instructions and example of hello_world run/output. I can add it simply.
The problem could with the flash instruction. I am using our internal tools to write elf file. I need to talk with one of my team-mates to get some good instruction. I believe, that I will have it on Monday.
So, if you wait I will add this information on Monday.

No problems with the build instructions and example of hello_world run/output. I can add it simply.
The problem could with the flash instruction. I am using our internal tools to write elf file. I need to talk with one of my team-mates to get some good instruction. I believe, that I will have it on Monday.
So, if you wait I will add this information on Monday.

We might merge this and can cleanup the docs as a new PR on Monday if you get the info.
We're in the process of possibly updated the OpenOCD version that is in the Zephyr SDK to the top of tree for openocd.  It looks like there is some support for the PSoC6 that got merged, so will be interesting if we can flash with it.


Support detecting models in MU structure

Like it says on the tin, this will detect models that use the standard Module Unification app structure, specifically those in /src/data/models/<name>/.
This is working flawlessly in my app, but some things need discussion:
Testing
I'm not quite sure how to go about adding tests for this. @samselikoff thoughts? Another app in /test-projects?
More robust detection
Module Unification (I believe) actually allows users to specify other places to put modules, although for many reasons it's unlikely that that will be a common use case for ember-data models.
Nevertheless, it might be good to use a more robust method for detecting models than filtering requirejs.entries based on module paths. E.g.,
appInstance.lookup('data-adapter:main').getModelTypes()
That seems solid and would even detect classic- and pod- models. I'm not sure how that would work with Mirage's lifecycle, since the model detection doesn't currently have access to the appInstance.

Given MU is on hold, should we close this PR and revisit when the MU design finalizes?

Possibly. However, there are many applications that are already using the MU structure, so it wouldn't be valueless to still include this.
At the very least, it makes sense to support configuring ec-mirage to find models in non-standard places.

I'd definitely be wary of hard-coding anything MU-specific at this point, but we ran into an issue recently with engines where being able to configure a lookup path other than env.modulePrefix would have been useful.
To run integration tests for an engine, you have to set up the test module to use the engine's resolver instead of the dummy app's so that you can test things like components and services within the engine. Unfortunately this means Mirage tries to find its model config under the engine's module prefix, when I think it's preferable to keep them with the dummy app since you typically wouldn't want to publish them alongside the engine code.
I think ideally that scenario would 'just work' out of the box, but being able to configure the lookup would be a nice escape hatch in the meantime.

@dfreeman I think you're probably right about not hard-coding MU, (though I don't think it'd be much worse than the currently hard-coded standard and pods structures).
I'd love to work on adding support for configuring mirage's detection. Ideally it'd be something more than just using requirejs.entries, like I mentioned in the opening comment here, but I don't know if Ember supports that well.
Barring that, what do you (all) think of allowing the application to specify alternative regex patterns for filtering requirejs.entries?

🤦♂ I should have read the PR more closely—the issue we ran into was actually with the detection of Mirage models, rather than Ember Data models. Regardless, being able to customize the regex(es) for both of those things feels like it would be useful.

On the Ember Data side, is there any way to use Ember CLI's resolver to get the models map?

Closing this as stale, especially given MU has been discarded!


fix(annotations): fixes annotation positioning/persistence issues

Adds a position property to annotation options for persisting their position. I'm not exactly sure why this wasn't persisted before, but keeping it around fixes a lot of issues with show/hide and refresh positioning for annotations. They should now no longer reset their position on toggling show/hide nor on refresh.
Fixes losing the show/hide state on refresh when clicking the toggle buttons on both the node UI and the annotation hover controls.
Fixes the bug where clicking the top right X on the placemark edit window would cause the annotation hover controls to not show up.

Also weird: the issue where polygons in Saved Places are filled on refresh... only happens if an annotation is enabled on the feature.

Good catch. Both of these problems are 2D mode only and are artifacts of the ol.Overlays weird behavior of not exposing the setVisibility method and instead deciding whether to show itself based on whether there's a position defined or not. Originally, we were setting the position to null if the visibility was off in order to hide the overlay. Now, I'm directly controlling the visibility property and checking it before re-rendering in updatePixelPosition.
Changing this seems to have fixed both cases. The filled polygon issue is unrelated.

I think #620 introduced the fill issues

OK, so I think I covered the 50 different visibility states that can apply to the annotation. I went back on trying to control the visibility directly, and instead just set the position to null to hide the overlay/annotation. The position will still be set on the annotation options at all times, but may not be set on the overlay itself as a result.


Production profiler (T5.3)

Production Profiler
Task 5.3 – Production system competence profiling [Leader: HOL, Duration: M11 – M22]
This task develops a Production System Profiler as a dual of the Worker Profiler of T5.2. The aim of this tool is to
characterize skills and capabilities demand at the various levels of the factory (whole plant, production line, workplace).
The use of the same taxonomy used in T5.2 ensures the coherence of the representation towards its comparison in the
matchmaking of T5.5.
HOL will lead the task for the tool implementation, supported by WUT for defining the characterization of the production
system layered demand.
High-level functionality
The production profiler is a tool as an extension to Worker Profiler. The taxonomy is based on T5.2 database. In this phase the user can choose the macro class of production. This will be the first step to create a new questionnaire based on the archetype chosen by the user. The generated questionnaire is divided into six main sections:

Production type
Digitalization level
Communication & data transfer
Process control
Process management
Human resources skills
Human resources type

Role in the architecture
On the basis of a "clustering" of the archetypes already identified in T5.2, we could identify groups of archetypes attributable to the various AI components present in the platform. In this way, once the AI component has been chosen from the marketplace, SME will be able - by activating the tools we are developing - to find a list of consistent archetypes. In this framework, the worker profiler (and in general all the consequent tools developed in WP5) can have different functions:

Guiding the user company in deciding which employees to involve in the profiling of skills (both the professional figures that may already be associated with the archetype on which to perform skill assessment / upskilling to bring them to the level of international standards, and professional figures currently not associated with the 'archetype, if, for example, the professional profile is not present in the company and you want to fill the personnel assigned to other activities through an internal reskilling process)
Automatically offer a job description aligned with international standards to be used in case of need for recruiting from the outside (but also internally) that can be used to fill in a job vacancy.

Improvements
It is its first implementation
Value proposition

Content migrated to:

https://github.com/c0c0n3/kitt4sme/blob/master/arch/catalogue

Please open a PR over there for further contribs.


Add: Broadcast event to use SUNMI Built In Infrared Scanner

Added broadcast event to use SUNMI built-in infrared scanner and listen that event in the react native application.

thank you

@Surile
You're welcome. Happy to contribute a little bit.
But why I am not being shown in the contributors of this repository?


parent query fluctuating mitotic spindle length FYPO:0006049

could not see
fluctuating mitotic spindle length FYPO:0006049
as a child of
abnormal bipolar mitotic spindle

I put the parent, FYPO:0006048 ! unstable mitotic spindle, under the process phenotype FYPO:0000131 ! abnormal mitotic spindle elongation.
Would it be (a) accurate and (b) useful to add FYPO:0000131 ! abnormal mitotic spindle elongation has_output FYPO:0001574 ! abnormal bipolar mitotic spindle

It sounds as though it  would be useful.

link added
edit file: fe081173f5dc5a0e9bd9186dc2d824c47febc5a2
release: 67ce2158e9b9c31c8afe124f60530a6cd4bc743e


Add support for column groups to the Table component

I'm proposing something similar to FixedDataTable (https://facebook.github.io/fixed-data-table/example-column-groups.html):
<Table>
  <ColumnGroup label="Name">
    <Column label="First Name" />
    <Column label="Last Name" />
  </ColumnGroup>
</Table>

The label prop can be either a string or a node. This is a use case in an application I'm building and I've worked around it by rendering an "empty" table above the primary table, but first-class support would be great. I can submit a PR, but would like to make sure this isn't already in the pipeline.

I'm not sure this belongs in react-virtualized. fixed-data-table is a windowing library with a specific focus on HTML-table-like-UI. react-virtualized is a generic windowing library and attempts to avoid specific UI details; put another way, this library attempts to focus on function rather than presentation.
The built-in Table component is the sole exception, but even still its presentational logic is very simple/limited.
Hmm...that being said, if you'd like to submit a PR for this, I promise to review it with an open mind. 😄 If it seems like it won't add too much complexity, I will roll it in. Deal?

Understood, and I'm certainly looking to keep things simple. I'll take a crack at it. :+1:

Sweet! Welcome to the project 😄

Hey @vakhtang 😁 It's been a while since we touched base on this issue. Seems like maybe it's been abandoned (or you're just busy, which is totally fine). Since I don't plan on acting on it myself I am going to close the issue for now. If you find time to work on it in the future, open a PR and we can resume discussion. Thanks!

Apologies for the delayed response. Indeed I've been very busy, but I have not abandoned this improvement. I'll revisit it after the new year.

@bvaughn I want to use the Table component from the react-virtualized and have the same use-case of grouped columns. Is there any recommended way to achieve this?

Hey, is this feature implemented till now by anyone? The grouping of columns. Actually I am using this is library for my project but only this feature is missing. Don't want to switch to another library. Can someone please update on this?


move() is not blocking

Hi,
I am using the ur_modern_driver package in combination with moveit to plan the UR5 motion. I found the following problem:
case a) When I initialize the robot using 'roslaunch ur_modern_driver ur5_bringup.launch' the move()-method is blocking.
case b) When I initialize the robot using 'roslaunch ur_modern_driver ur5_ros_control.launch' the move()-method is NOT blocking.
Is there a way to make the move()-method blocking using the ros-control bringup (case b)?
Thank you so much!
Best regards
Jan

The ros_control side of the driver relies on joint_trajectory_controller for its Action server. That particular implementation supports trajectory replacement (or: blending). That's why by default you can submit as many trajectories as you want: the controller will try to blend them all together.
The regular code paths in this driver do not support trajectory blending.
So the "blocking" you describe is actually a side-effect.

Is there a way to make the move()-method blocking using the ros-control bringup

No, not that I'm aware of.
You'll have to make sure to check for completion of the goal you submitted to the FollowJointTrajectory action server (which is something you probably should do regardless).

As this is not something we can change in this package I'm going to close this issue.
If you feel this is wrong @FlyingBeginner please re-open and clarify.


CI: Drop Appveyor builds

Proposal to drop Appveyor CI:

It is used for Windows builds, which is already covered with Github Actions.
It fails routinely (often with network issues)

CI being red erroneously consumes developer time (checking out what's wrong) and
reduces its own effectiveness due to alarm fatigue, so this seems worth fixing.

I think that's fine. Though FYI, I'm not seeing any more frequent build failures with AppVeyor that with the other CI providers. They all have some chaotic/random (though relatively rare) failures. For instance, Mac builds are all halted on GHA right now (2020-08-10@0530 UTC).
But, in general, GHA is now performing all necessary windows builds. AppVeyor is just doing to some builds with older tools. Disabling them should be fine.
Be careful merging this... The AppVeyor build may need to be disabled on the AppVeyor site before this is merged to avoid 'AppVeyor build failed' for all builds. Just removing the config file might be enough, but I'm not sure about that.

I have the permissions, I just deleted it.


BREAKING CHANGE: Support for SQL Authentication

Pull Request (PR) description
Support to create / connect to Farm and service applications using SQL authentication instead of Windows credentials.
New parameters: UseSQLAuthentication and DatabaseCredentials.
This Pull Request (PR) fixes the following issues
- Fixes #1121

Task list

[x] Added an entry under the Unreleased section of the change log in the CHANGELOG.md.
Entry should say what was changed, and how that affects users (if applicable).
[ ] Resource documentation added/updated in README.md in the resource folder.
[x] Resource parameter descriptions added/updated in schema.mof
and comment-based help.
[ ] Comment-based help added/updated.
[ ] Localization strings added/updated in all localization files as appropriate.
[ ] Examples appropriately added/updated.
[ ] Unit tests added/updated. See DSC Resource Testing Guidelines.
[ ] Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
[x] New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is

Codecov Report

Merging #1126 into v4.0-development will decrease coverage by <1%.
The diff coverage is 58%.

@@               Coverage Diff                @@
##           v4.0-development   #1126   +/-   ##
================================================
- Coverage                92%     92%   -1%
================================================
  Files                   120     120
  Lines                 13327   13377   +50
================================================
+ Hits                  12359   12383   +24
- Misses                  968     994   +26

AppVeyor tTests for 'SPSecureStoreServiceApp' are failing. Do you want me to review now or wait until you fixed the AppVeyor tests?

Thanks for all the comments Yoris! I will review and get back to you shortly :) Agree with most if not all of them. In some cases at least, the descriptions were pre-existing so I didn't modify them but agree it makes sense to review/update.

Also re: AppVeyor tests, I'm totally unfamiliar with it unfortunately so any guidance you have here would be appreciated.

When you click the "Details" link behind the AppVeyor line, you are redirected to the AppVeyor run/log.
Above the blue box, you can click "Download the complete log" to download and view the log. When you search for "[-]" you will hit all failed tests.
However since this is all on the SPSecureStoreServiceApp, you can also run the SPSecureStoreServiceApp.Tests.ps1 file (Tests\Unit\SharePointDsc\SharePointDsc.SPSecureStoreServiceApp.Tests.ps1) to run just the single Pester test locally. That will give you all the test results.

@brianlala Were you able to fix the Pester tests?

Sorry, not yet. Hoping to work on it this week!

The tests are still failing on the SPSecureStoreServiceApp resource:

Like I mentioned in my previous post, you can run these tests locally by browsing to the Unit tests folder (Tests\Unit\SharePointDsc) and running the SharePointDsc.SPSecureStoreServiceApp.Tests.ps1 file.


Fix pod file (name and git tag)

Run pod install after linking (react-native link @react-native-community/masked-view) package caused next error:

It is a good surprise that PR already have been merged and new version on npm available.
Thank you! 😊


Changing ModernHttpClient to support .Net 4.5 for shared Windows

I don't understand this PR at all, why would we do this?

In our project, we are trying to use ModernHttpClient, but we have to support Android, iOS, and Windows. It makes ModernHttpClient work for the Windows Desktop platform while allowing Native for Android and iOS.

Wouldn't a DI framework easily take care of this situation?

A DI framework could be one solution, but I feel that others may run into the same situation while using ModernHttpClient in shared projects. The change will not affect iOS or Android implementations. This solution is much more elegant as a "drop in" replacement for System.Net.

ModernHttpClient is a drop in replacement for HttpMessageHandler on platforms that have platform specific libraries that don't have compatible API's. If you want to use an HttpMessageHandler on a Windows system, just use it. HttpMessageHandler is the abstraction, you dont need to pile any more abstraction on top of it.

Yeah, I don't think you need to do this, the PLib should shim it in anyways.


Remove leftover crossing hello tests in connection handshake

Description

closes: #XXXX

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

[ ] Targeted PR against correct branch (see CONTRIBUTING.md)
[ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
[ ] Code follows the module structure standards.
[ ] Wrote unit and integration tests
[ ] Updated relevant documentation (docs/) or specification (x/<module>/spec/)
[ ] Added relevant godoc comments.
[ ] Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
[ ] Re-reviewed Files changed in the Github PR explorer
[ ] Review Codecov Report in the comment section below once CI passes

Codecov Report

Merging #1724 (aa9cc8b) into main (0fd5656) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1724      +/-   ##
==========================================
+ Coverage   80.00%   80.05%   +0.05%
==========================================
  Files         164      164
  Lines       12299    12300       +1
==========================================
+ Hits         9840     9847       +7
+ Misses       1997     1993       -4
+ Partials      462      460       -2

Impacted Files
Coverage Δ

modules/apps/transfer/ibc_module.go
64.93% <100.00%> (+0.22%)
:arrow_up:

modules/core/03-connection/keeper/handshake.go
89.88% <0.00%> (+3.37%)
:arrow_up:


Create 1405-longest-happy-string.java

File(s) Modified: 1405-longest-happy-string.java
Language(s) Used: Java
Submission URL: https://leetcode.com/problems/longest-happy-string/

Important
Please make sure the file name is lowercase and a duplicate file does not already exist before merging.
Adapted this solution to Java

Hi! @felivalencia3 if possible, can you please take a look at this at your convenience Thank you so much.

@Tetsuya3850 Thank you for your contributions 👍


Please let adb be on all the time

Hello,
I'm a disabled person who isn't able to physically use the mobile. This app is something truly amazing and now I got to finally use it in a different way, thank you! I use the wi-fi connection to not harm the phone's battery. But problem is that everytime I restart or sleep my laptop, I have to ask someone to plug the phone again to enable adb over TCP/IP. That is really bothersome, Is it possible to make the adb on just once, so I wouldn't have to plug the mobile few times a day?

Unfortunately, without rooting the device, it is not possible to keep adb listening on TCP/IP on reboot.
It is possible to enable it without plugging on USB:

in Developer options, some devices allow to enable Wireless ADB debugging
since Android 11, there is a pairing mechanism

However, that probably won't help you. :/

I use the wi-fi connection to not harm the phone's battery

I think that leaving recent devices always plugged in should not damage the battery. I'm not an expert though.

Oh, that's a bummer :/ The app is working like a charm, but I really need something on wi-fi and trustworthy. Thank you for reply!

Oh, that's a bummer :/ The app is working like a charm, but I really need something on wi-fi and trustworthy. Thank you for reply!

there are plenty of tutorials on how to root your device,
in case you want to root your device,i suggest you use this app (google play link)[https://play.google.com/store/apps/details?id=com.sujanpoudel.adbwifi] to keep adb active all the time

If you are able to root your device, you can put a script in the startup of Magisk (I call it activer_adbwifi.sh).
`!/data/adb/service.d
sleep 30
setprop service.adb.tcp.port 5555
stop adbd
activer_adbwifi.txt
start adbd`


"Your query returned no results" error once the AMI ID is not listed within AWS marketplace.

The AWS instance configured via module, the 'ami' and 'ami_owner' parameters were configured, the instance was created successfully. Once the AMI-ID is removed from the AWS latest amis list (approx in 4 months), there is an error:
│ Error: Your query returned no results. Please change your search criteria and try again. │  │   with module.myInstance.data.aws_ami.info, │   on .terraform/modules/myInstance/main.tf line 71, in data "aws_ami" "info": │   71: data "aws_ami" "info" {
It's needed to mention, that actual values for the 'AMI' and 'ami_owner' were saved and haven't changed.
the module version "0.44.0"

Have the same problem, opened an issue with AWS, when I search for the ami its not there, but when I start new box with that ami it shows later in the ami search, terraform is still not working.
But this used to work for me before on 0.44.0

@evg-mlechko does this work before you start a new box
aws ec2 describe-images --region ${region_name} --image-ids ${ami_id}

hello @shomodj
the describe-images command returns { "Images": [] } output. But if we are talking about the case with using this module, it should use the initially predefined (used at the moment of the creation of the EC2 instance) values for 'ami' and 'ami_owner' fields.
So, it was the reason why I created a bug here.
Could you please clarify, what did you mean by saying start new box
thanks

This is an issue with the module it is better described in this issue:
https://github.com/cloudposse/terraform-aws-ec2-instance/issues/150


chore(Computability/TuringMachine): change uses of get(?) to getElem(?)

Update Computability/TuringMachine to not use deprecated List.get and List.get? lemmas.
In addition, a couple missing lemmas were added to Data/List/GetD to
support this change.

Thanks; the comments have been addressed👌

Right, I forgot about that among the other stuff. Thanks! I've changed it.

bors r+


Tracer flare debug logs tests

Motivation
APMAPI-27 - [Java] Tracer flare debug logs
Changes

add check of the content of the java tracer flare

add check of the content of the tracer.log file inside the java tracer flare

For  these tests, I've added the function add_remote_config(self, path, payload) that uses the endpoint POST "/test/session/responses/config" in order to add the AGENT_TASK to the already existing Remote Configuration (AGENT_CONFIG).

Notes:

I've tested it locally on my laptop with a snapshot of the java tracer (dd-java-agent-1.41.0-SNAPSHOT)

Workflow

⚠ Create your PR as draft ⚠
Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
Mark it as ready for review

Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
Framework is modified, or non obvious usage of it -> get a review from R&P team

:rocket: Once your PR is reviewed, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist

[x] Relevant label (run-parametric-scenario, run-profiling-scenario...) are presents
[x] If PR title starts with [<language>], double-check that only <language> is impacted by the change
[ ] No system-tests internal is modified. Otherwise, I have the approval from R&P team
[ ] CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
[ ] A docker base image is modified?

[ ] the relevant build-XXX-image label is present

[ ] A scenario is added (or removed)?

[ ] Get a review from R&P team

Be careful, you modified test logic. In that situation, you must not prefix your PR title with [java], otherwise, only java test are executed.

I thought it was more informative than anything else. I didn't know tests were triggered or not by the PR title.

I thought it was more informative than anything else. I didn't know tests were triggered or not by the PR title.

no wory, that's why we have PR reviewers 😄


caf script fails to link against shared-library client code

Avg response time

Please make sure to put any logs, terminal output, or code in
[fenced code blocks]. Please also read the [contributing guidelines]
before submitting a new issue.
Defect/Bug Report
Building json-fortran fails to link unless the  OpenCoarrays caf script is modified to link against libcaf_mpi.so instead of libcaf_mpi.a.

OpenCoarrays Version: 2.4.0-8-g7aafb20
Fortran Compiler: gfortran 9.0.1
C compiler used for building lib:gcc 9.0.1
Installation method: install.sh
Output of uname -a: Linux Sourcery-Institute-VM 4.15.0-45-generic #48-Ubuntu SMP Tue Jan 29 16:28:13 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
MPI library being used: MPICH 3.2
Machine architecture and number of physical cores: macBook Pro with 4-core 2.7 GHz Intel core i7
Version of CMake: 3.12.3

Observed Behavior
[  8%] Linking Fortran shared library lib/libjsonfortran.so
/usr/bin/ld: /home/rouson/Desktop/Builds/opt/opencoarrays/2.3.1-7aafb2/gnu/9.0.1/lib/libcaf_mpi.a(mpi_caf.c.o): relocation R_X86_64_32 against `.rodata.str1.8' can not be used when making a shared object; recompile with -fPIC
/usr/bin/ld: final link failed: Nonrepresentable section on output
collect2: error: ld returned 1 exit status
Error: comand:
   `/home/rouson/Builds/opt/gnu/9.0.1/bin/gfortran -I/home/rouson/Desktop/Builds/opt/opencoarrays/2.3.1-7aafb2/gnu/9.0.1/include/OpenCoarrays-2.4.0-8-g7aafb20_GNU-9.0.1 -fcoarray=lib -Wl,-rpath -Wl,/home/rouson/Builds/opt/mpich/3.2/gnu/9.0.0/lib -Wl,--enable-new-dtags -L/home/rouson/Desktop/Builds/opt/mpich/3.2/gnu/9.0.0/lib -fPIC -fbacktrace -fno-omit-frame-pointer -O3 -DNDEBUG -O3 -shared -Wl,-soname,libjsonfortran.so.6.10 -o lib/libjsonfortran.so.6.10.0 CMakeFiles/jsonfortran.dir/src/json_kinds.F90.o CMakeFiles/jsonfortran.dir/src/json_parameters.F90.o CMakeFiles/jsonfortran.dir/src/json_string_utilities.F90.o CMakeFiles/jsonfortran.dir/src/json_value_module.F90.o CMakeFiles/jsonfortran.dir/src/json_file_module.F90.o CMakeFiles/jsonfortran.dir/src/json_module.F90.o /home/rouson/Desktop/Builds/opt/opencoarrays/2.3.1-7aafb2/gnu/9.0.1/lib/libcaf_mpi.a /home/rouson/Builds/opt/mpich/3.2/gnu/9.0.0/lib/libmpifort.so /home/rouson/Builds/opt/mpich/3.2/gnu/9.0.0/lib/libmpi.so`
failed to compile.
CMakeFiles/jsonfortran.dir/build.make:158: recipe for target 'lib/libjsonfortran.so.6.10.0' failed
make[6]: *** [lib/libjsonfortran.so.6.10.0] Error 1
CMakeFiles/Makefile2:523: recipe for target 'CMakeFiles/jsonfortran.dir/all' failed
make[5]: *** [CMakeFiles/jsonfortran.dir/all] Error 2
CMakeFiles/Makefile2:705: recipe for target 'CMakeFiles/build_tests.dir/rule' failed
make[4]: *** [CMakeFiles/build_tests.dir/rule] Error 2
Makefile:396: recipe for target 'build_tests' failed
make[3]: *** [build_tests] Error 2
CMakeFiles/json-fortran.dir/build.make:112: recipe for target 'TPLs/Stamp/json-fortran/json-fortran-build' failed
make[2]: *** [TPLs/Stamp/json-fortran/json-fortran-build] Error 2
CMakeFiles/Makefile2:147: recipe for target 'CMakeFiles/json-fortran.dir/all' failed
make[1]: *** [CMakeFiles/json-fortran.dir/all] Error 2
Makefile:83: recipe for target 'all' failed
make: *** [all] Error 2

Expected Behavior
Successful build of json-fortran.
Workaround

Replace libcaf_mpi.a with libcaf_mpi.soin the installedcaf` script.
Append the installed OpenCoarrays lib directory to the LD_LIBRARY_PATH.

Fixed in #639 and release 2.5.0


[dv/common] Change TL_agent to use dv_lib

Change TL_agent to use dv_lib as base
Update Xbar env to dv_lib naming conventions for tl_agent
Signed-off-by: Cindy Chen<EMAIL_ADDRESS>

Thanks for taking this up @cindychip !


Display interactive dashboards of multi-subject results

The purpose here would be to:

Generate using Heroku dashboards interactive plots of the results, so that people can check individual values
Generate those using the csv outputs from the latest release

after downloading the zipped csv files, run: sg_generate_figure to generate the figures and have an idea how the dashboard should look like

Embed those dashboards inside the RTD documentation, under a new section "results"

What is sg_generate_figure ? Can I find it somewhere?

What is sg_generate_figure ? Can I find it somewhere?

it is a CLI script installed with the spine-generic package, more info in the doc

While running the script generate_figure.py in spinegeneric/cli, I get No module named 'spinegeneric'

did you run it from the terminal? can you please copy/paste your terminal output?

noemieroberge@MacBook-Air-de-Noemie Spine-generic-dashboard % /usr/local/bin/python3 /Users/noemieroberge/Documents/GitHub/Spine-generic-dashboard/results_r20200917/generate_figure.py Traceback (most recent call last):   File "/Users/noemieroberge/Documents/GitHub/Spine-generic-dashboard/results_r20200917/generate_figure.py", line 35, in <module>     import spinegeneric as sg ModuleNotFoundError: No module named 'spinegeneric' noemieroberge@MacBook-Air-de-Noemie Spine-generic-dashboard %

/usr/local/bin/python3 /Users/noemieroberge/Documents/GitHub/Spine-generic-dashboard/results_r20200917/generate_figure.py

do not call python, use the CLI directly after installation

Ok I used directly CLI
It seems like I have KeyError
(ProjectDashboard) noemieroberge@MacBook-Air-de-Noemie ~ % sg_generate_figure -path-results ~/spineGeneric_results/results -exclude /Users/noemieroberge/data-multi-subject/exclude.yml
Age statistics:
Traceback (most recent call last):
  File "/Users/noemieroberge/ProjectDashboard/lib/python3.8/site-packages/pandas/core/indexes/base.py", line 2891, in get_loc
    return self._engine.get_loc(casted_key)
  File "pandas/_libs/index.pyx", line 70, in pandas._libs.index.IndexEngine.get_loc
  File "pandas/_libs/index.pyx", line 101, in pandas._libs.index.IndexEngine.get_loc
  File "pandas/_libs/hashtable_class_helper.pxi", line 1675, in pandas._libs.hashtable.PyObjectHashTable.get_item
  File "pandas/_libs/hashtable_class_helper.pxi", line 1683, in pandas._libs.hashtable.PyObjectHashTable.get_item
KeyError: 'median'

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/Users/noemieroberge/ProjectDashboard/bin/sg_generate_figure", line 33, in <module>
    sys.exit(load_entry_point('spinegeneric', 'console_scripts', 'sg_generate_figure')())
  File "/Users/noemieroberge/spine-generic/spinegeneric/cli/generate_figure.py", line 872, in main
    compute_age_statistics()
  File "/Users/noemieroberge/spine-generic/spinegeneric/cli/generate_figure.py", line 496, in compute_age_statistics
    age_stats['median']))
  File "/Users/noemieroberge/ProjectDashboard/lib/python3.8/site-packages/pandas/core/series.py", line 882, in __getitem__
    return self._get_value(key)
  File "/Users/noemieroberge/ProjectDashboard/lib/python3.8/site-packages/pandas/core/series.py", line 991, in _get_value
    loc = self.index.get_loc(label)
  File "/Users/noemieroberge/ProjectDashboard/lib/python3.8/site-packages/pandas/core/indexes/base.py", line 2893, in get_loc
    raise KeyError(key) from err
KeyError: 'median'

@noemieroberge could you try with python 3.7?

I tried with python 3.7
I still have the same KeyError
(ProjetDashboard) noemieroberge@MacBook-Air-de-Noemie ~ % sg_generate_figure -path-results ~/spineGeneric_results/results -exclude /Users/noemieroberge/data-multi-subject/exclude.yml
Age statistics:
Traceback (most recent call last):
  File "/Users/noemieroberge/ProjetDashboard/lib/python3.7/site-packages/pandas/core/indexes/base.py", line 2891, in get_loc
    return self._engine.get_loc(casted_key)
  File "pandas/_libs/index.pyx", line 70, in pandas._libs.index.IndexEngine.get_loc
  File "pandas/_libs/index.pyx", line 101, in pandas._libs.index.IndexEngine.get_loc
  File "pandas/_libs/hashtable_class_helper.pxi", line 1675, in pandas._libs.hashtable.PyObjectHashTable.get_item
  File "pandas/_libs/hashtable_class_helper.pxi", line 1683, in pandas._libs.hashtable.PyObjectHashTable.get_item
KeyError: 'median'

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/Users/noemieroberge/ProjetDashboard/bin/sg_generate_figure", line 11, in <module>
    load_entry_point('spinegeneric', 'console_scripts', 'sg_generate_figure')()
  File "/Users/noemieroberge/spine-generic/spinegeneric/cli/generate_figure.py", line 872, in main
    compute_age_statistics()
  File "/Users/noemieroberge/spine-generic/spinegeneric/cli/generate_figure.py", line 496, in compute_age_statistics
    age_stats['median']))
  File "/Users/noemieroberge/ProjetDashboard/lib/python3.7/site-packages/pandas/core/series.py", line 882, in __getitem__
    return self._get_value(key)
  File "/Users/noemieroberge/ProjetDashboard/lib/python3.7/site-packages/pandas/core/series.py", line 991, in _get_value
    loc = self.index.get_loc(label)
  File "/Users/noemieroberge/ProjetDashboard/lib/python3.7/site-packages/pandas/core/indexes/base.py", line 2893, in get_loc
    raise KeyError(key) from err
KeyError: 'median'

are you using results from the single or from the multi subjects repository?

I use results from multi subjects repository. I changed the path for my results folder and it is working

I recently came across Bokeh. Maybe worth looking into?

Example of interactive plots in RTD:

https://github.com/readthedocs/readthedocs.org/issues/4367#issuecomment-404979311

https://spine-generic.readthedocs.io/en/nr-dashboard/


refactor(protocol): change gas eip1559 types

The previous datatypes are too large

We are about to address them here:
https://github.com/taikoxyz/taiko-mono/pull/15052
And it lacks the possibility to set the 3 variables (excess, target, quotient) all together - which is crucial.

Delete this please, i'll handle it in A6 configs!

Addressed all size reductions here: https://github.com/taikoxyz/taiko-mono/pull/15052


Add ui test framework

Pull Request Test Coverage Report for Build 202

11 of 11 (100.0%)  changed or added relevant lines in 3 files are covered.
4 unchanged lines in 1 file lost coverage.
Overall coverage increased (+12.3%) to 24.135%

Files with Coverage Reduction
New Missed Lines
%

packages/acceptit-Core.package/ACUserStoryParser.class/instance/buildCode..st
4
0.0%

Totals

Change from base Build 199:
12.3%

Covered Lines:
314

Relevant Lines:
1301

💛  - Coveralls

Great work!


Model not updated in change event

Description
After updating angular from 8.2.14 to 9.1.11, when the change event is triggered the model is not updated yet.
I am not sure if this has anything to do with formly itself, but maybe you can point me in the right direction as of why the model does not contain the updated value anymore at the moment of the change event.
No (console) errors are displayed anywhere.
Minimal Reproduction
I am sadly unable to reproduce this in a clean ng9 and formly5.7.2 project, but am more hoping that you could point me to why this could happen to me.
@Component({
  template: `
      <form [formGroup]="form" (ngSubmit)="onSubmit()">
        <formly-form
          [form]="form"
          [model]="model"
          [fields]="fields">
        </formly-form>
      </form>
  `,
  selector: 'my-form'
})
export class MyFormComponent {
  model = {};
  form = new FormGroup({});
  this.fields = [{
    key: 'select',
    type: 'select',
    options: [{ label: 'Value', value: 'value' }],
    templateOptions: {
      change: () => console.log(this.model) // does not container 'value' anymore
    }
  }];
}

Your Environment

Angular version: 9.1.11
Formly version: 5.7.2
Formly bootstrap: 5.7.2
bootstrap: 4.5.0

Additional context
It did work prior the update from angular 8 to 9.

calling order has been changed in Ivy which may the root cause of that issue but not sure, for a workarround either use:
1- setTimeout
templateOptions: {
  change: () => setTimeout(() => console.log(this.model))
}

2- valueChanges
{
  hooks: {
    onInit: (field) => field.formControl.valueChanges.pipe(
      tap(value => console.warn(value)),
    ),
  }
}

@aitboudad thank you both seem to work!
The second one however causes a Maximum call stack size exceeded. Could this be because I reset the form with amongst others the value that is updated?:
{
  hooks: {
    onInit: (field) => field.formControl.valueChanges.pipe(
      tap(value => this.resetFormType(value)),
    ),
  }
}
...
private resetFormType(code: string) {
  const extraFields = this.getExtraFields(code);
  this.fields = [...this.basicFields, ...extraFields];
  // Does this re-trigger the `valueChanges`?
  this.form.reset({
    select: code
  });
}

add distinctUntilChanged:
{
  hooks: {
    onInit: (field) => field.formControl.valueChanges.pipe(
+     distinctUntilChanged(),
      tap(value => this.resetFormType(value)),
    ),
  }
}


num cannot be greater than 10

At first I couldn't figure out why it wouldn't let me get more records than ten records :
HttpError: <HttpError 400 when requesting https://www.googleapis.com/customsearch/v1?searchType=i
ne+screenshot&num=99&fileType=png&cx=[MYCXID]&key=[MYKEY]=json returned "Invalid Value"
I found that it is because of Google's API limit:
num | unsigned integer | Number of search results to return.Valid values are integers between 1 and 10, inclusive.
https://developers.google.com/custom-search/json-api/v1/reference/cse/list
Is there any workaround for this that you would suggest?

Hi @jradis,
Please see: https://stackoverflow.com/questions/16925762/getting-more-than-10-results-by-google-custom-search-api-v1-in-java
You may edit the start query parameter, and make multiple calls in batches of 10:
search_google cats --start=0
search_google cats --start=11

You may also loop this in Python:
import search_google.api

# Define buildargs for cse api
buildargs = {
  'serviceName': 'customsearch',
  'version': 'v1',
  'developerKey': 'your_api_key'
}

# Define cseargs for search
cseargs = {
  'q': 'keyword query',
  'cx': 'your_cse_id'
}

# Create a results object
results = []
for (start in [0, 11]) {
  cseargs['start'] = start
  results.append(search_google.api.results(buildargs, cseargs)_
}

# Preview results for start=0
results[0].preview()

# Preview results for start=11
results[1].preview()


The ordered deployment of Helm charts for Istio pattern is broken with latest commit

Description
In the file here https://github.com/aws-ia/terraform-aws-eks-blueprints/blob/main/patterns/istio/main.tf because of the latest commit

The Helm chart installs that were done outside of the add-ons have been moved under EKS add-ons
The Helm chart dependencies that were previously met are now lost as they (charts) all seem to be executing in parallel and because of this, istio-ingress is not deploying correctly after istiod, as per the expectation.

Expected Behavior
istio-ingress helm chart is run after the istiod helm chart, in that order.
Actual Behavior
istio-ingress helm chart sometimes seems to run before the istiod helm chart
Suggested Correction
As the Helm charts for Istio do not belong to the EKS add-ons, it is recommended that they be restored back and run as Terraform helm_release resources.

could you further clarify or demonstrate whats broken or the errors you are seeing?
If I was a user who deploys Istio using a GitOps operator instead of Terraform, how would I approach this situation you are describing?

Issue 1:
In a clean run I face the following issue:

Looking at the code, I can only imagine this happening because of this istiod Helm release line.
But for istio-base Helm release the line has the create_namespace = true for istio-system.
So clearly the  helm_releases are not running sequentially as perhaps hoped

Should we create the shared namespace through a standalone kubernetes_namespace_v1 resource and pass that in to the two charts that are deployed into that namespace?

Issue 2:
After setting create_namespace = true in line and rerunning the Terraform and all the subsequent instructions in the README we see the following with istio-ingress pod in ImagePullBackOff status. This is new issue we had not seen before.

5m4s        Normal    Pulling                        pod/istio-ingress-6f7c5dffd8-59nz8      Pulling image "auto"
5m4s        Warning   Failed                         pod/istio-ingress-6f7c5dffd8-59nz8      Failed to pull image "auto": rpc error: code = Unknown desc = failed to pull and unpack image "docker.io/library/auto:latest": failed to resolve reference "docker.io/library/auto:latest": pull access denied, repository does not exist or may require authorization: server message: insufficient_scope: authorization failed
5m4s        Warning   Failed                         pod/istio-ingress-6f7c5dffd8-59nz8      Error: ErrImagePull
83s         Normal    BackOff                        pod/istio-ingress-6f7c5dffd8-59nz8      Back-off pulling image "auto"
4m48s       Warning   Failed                         pod/istio-ingress-6f7c5dffd8-59nz8      Error: ImagePullBackOff

I don't think we can have two release definitions that are both trying to create the same namespace, what are your thoughts about the comment above #1766 (comment)

Perhaps true but the issue is not with namespaces but having istiod run before istio-ingress.


[RFE] Zero trust - policy compliance and device health

Is it linked to a user story? (use the "#" to tag the user story)
no
What do we want to build?
Configuration compliance and monitoring
Why do we want to build it?
Trousseau v1.1.0 introduced the Zero trust security at the heart of the solution by addressing 5 out 6 [key principles]:(https://en.wikipedia.org/wiki/Zero_trust_security_model#Principles_and_Definitions):

single strong source of user identity with the usage of a KMS (Key Management Services)
user authentication with separation of duties (auth for Kubernetes is handled by the DevOps Team and the Security Team for the KMS)
machine authentication with a Kubernetes ServiceAccount connecting to the KMS
authorization policies to access an application with a policy linked to the machine authentication and role can be accessed by Trousseau within its namespace
access control policies within an application with the Trousseau ConfigMap recovering its dedicated settings to access the Transit encryption key

The missing principle is "additional context, such as policy compliance an device health".
How do we want to design it?
To be designed/defined
What do we want to build?
To be designed/defined

at the current stage the Zero Trust model has been reached:

[x] single strong source of user identity with the usage of a KMS (Key Management Services)
[x] user authentication with separation of duties (auth for Kubernetes is handled by the DevOps Team and the Security Team for the KMS)
[x] machine authentication with a Kubernetes ServiceAccount connecting to the KMS
[x] authorization policies to access an application with a policy linked to the machine authentication and role can be accessed by Trousseau within its namespace
[x] access control policies within an application with the Trousseau ConfigMap recovering its dedicated settings to access the Transit encryption key


Commit-hash of the binaries does not match the tag or any commit on github.

Commit-hash of the binaries does not match the tag or any commit on github.
This suggests the binaries are built from a commit not published to github.

Windows and Linux tested.

I didn't upload the binaries for v3.1.0 but I think the cause of this is the person who uploaded the binaries got them an commit before they were squashed (causing a force-push on GH). I'll make sure this doesn't happen for the v3.1.1 release. Thank you for bringing this to light.


Add Source-Aggregated Signal-to-Distortion Ratio (SA-SDR)

What does this PR do?
Add Source-Aggregated Signal-to-Distortion Ratio (SA-SDR)

Before submitting

[ ] Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
[ ] Did you read the contributor guideline, Pull Request section?
[ ] Did you make sure to update the docs?
[ ] Did you write any new necessary tests?

PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?
Make sure you had fun coding 🙃

:books: Documentation preview :books:: https://torchmetrics--1882.org.readthedocs.build/en/1882/

The make-doctest failed on torchmetrics/classification/group_fairness.py, see https://github.com/Lightning-AI/torchmetrics/actions/runs/5477750676/jobs/9977257361?pr=1882#step:6:593

The make-doctest failed on torchmetrics/classification/group_fairness.py, see https://github.com/Lightning-AI/torchmetrics/actions/runs/5477750676/jobs/9977257361?pr=1882#step:6:593

FIxed that issue. There is another issue in docs CI right now, but that should hopefully be fixed on lightning side


Mention the rutime process implicitly

It was originally to remove the term "Node process" in the Deno code block.

It was originally to remove the term "Node process" in the Deno code block.

I would prefer if we could simply fix that oversight and refer to the Deno process.


Downloadable version?

Hi team - nice to see this paper land - will we have a downloadable (PDF) version?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3c758f24-c795-7b35-2c48-420cf0857b5e
Version Independent ID: 5ab98986-d4e4-2d00-8bc0-fca44460d7f1
Content: Azure Synapse Analytics security white paper - Azure Synapse Analytics
Content Source: articles/synapse-analytics/guidance/security-white-paper-introduction.md
Service: synapse-analytics
GitHub Login: @peter-myers
Microsoft Alias: v-petermyers

Hi @PeteHaigh-MSFT - there's not a single PDF document available for download. You can, however, create a PDF of Docs articles by using the "Download PDF" link located at the bottom left.
#please-close


x/build: missing failure output from windows-amd64-2008 builder

https://build.golang.org/log/59a049ac56f1c7dbcf9de1f6002512a70f765e0c is marked as a failure on the dashboard, but its output doesn't contain the word FAIL anywhere.
It's not obvious to me whether the test timed out, or failed without output. Better output from cmd/dist and/or the Builder infrastructure would probably help.
(CC @andybons @cagedmantis @toothrot @dmitshur)

This is very strange.


Revert "build(deps): bump actions/deploy-pages from 3.0.1 to 4.0.0"

This reverts commit 4de5f40af7b0aa54866167bd9e59003a28e870a9.

as the release notes mentioned this requires actions/upload-pages-artifact@v3: tuf-on-ci does not use that yet
The release also broke the whole Pages deploy pipeline: v4 does not seem to work anywhere right now

upload-pages-artifact can be upgraded with tuf-on-ci 0.4 (the next release).

thanks!


Highlight current word in json sometimes matches a single double quote

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.63.2, 1.64.0-insider
OS Version: Archlinux

Steps to Reproduce:

Enter the following into a json (or json with comments) document

{
    "": "background-color: #ffffff26 ! "
}

Move cursor to after the last quotation mark

Note that all quotation marks are searched as current word. Expected behaviour is to search the entire string.
I should add that the code above is written for a monkey patch, but I have tested it on an instance without monkey patch and it is still a problem.
Also for some reason, deleting more characters in the string seems to fix the bug.

I debugged this and it has to do how the wordHelper finds the word at an offset.
It goes back 15 characters from the current position and starts matching the word pattern
https://github.com/microsoft/vscode/blob/main/src/vs/editor/common/core/wordHelper.ts#L109
The JSON word definition starts with quotes and any number of characters with an optional end quote.
So it just finds the end quote.


Enable multiarch builds

The version in main only can build for amd64 and riscv64. This enabled arm64 as well.
One of the workflows, Build and Tests fails. We only need the tii-mavlink-router, so it is not a blocker for us. The upstream updated version upstream_master_11_05_2023-logging-stop-fix doesn't have the problem.

Yes, we get rid of that build issue when we update the new version from upstream.


feat(tutorial): complete step 4 - Hursley

Complete step 4.

:+1::skin-tone-2: Looks good - I have recorded your completion of this step!


Change sudo examples to use $ instead of $

sudo is not required when running as root, and # indicates
that you are already root.  $ indicates you are not root.
Signed-off-by: Daniel J Walsh<EMAIL_ADDRESS>

Fixes https://github.com/projectatomic/libpod/issues/207

@ipbabble PTAL

LGTM, but probably want to let @baude weigh in.

whatever makes people happy

I am not going to fight with this. Error is unrelated, this is a docs only change. Will merge manually.

The change LGTM. I had a gist from the Docker man page/tutorial days that I wanted to make into a podman tutorial. I will take a look and see where it fits in.  But most of it would be around -v  options.
https://gist.github.com/ipbabble/c7f231d6ebf596e61cd6


prevent infinite loop in _get_all_properties_value()

This is a follow-up for https://github.com/leeyuentuen/alfen_wallbox/pull/105 which got reverted for mitigation of https://github.com/leeyuentuen/alfen_wallbox/issues/107. This code is not guilty.

https://github.com/leeyuentuen/alfen_wallbox/releases/tag/2.7.32