JOSH returns 500 on git ls-remote when there is no master branch

Hey!
We're successfully using JOSH to virtualise our main trunk repo so that we can consume libraries in other downstream projects. This works great for the most part. We have however run in to an issue when using JOSH together with git-subrepo and a renamed master branch in the source repo.
As a workaround we have been adding the branch name to the filter section of the remote url, effectively turning it in to the master branch, but this seems to cause issues with pushing changes back upstream.
Cloning a virtualised repo directly works just fine, even when there is no master branch. The correct default brach is identified anyways. The same way, adding that full source repo using git-subrepo, everything works and the correct default brach is identified.
The problem seems to arise when using all three things at once, and it seems to come down to JOSH returning a 500 error on the ls-remote request initiated by git-subrepo.
Going through the logs it seems like the following fetch call is the culprit:
git fetch --no-tags<EMAIL_ADDRESS>\'+refs/heads/*:refs/josh/upstream/<name>.git/refs/heads/*\' \'+refs/tags/*:refs/josh/upstream/<name>.git/refs/tags/*\' \'+refs/heads/master:refs/josh/upstream/<name>.git/refs/heads/master\'" "/data/git/"

Since it fails with the following:
fatal: Couldn't find remote ref refs/heads/master

Adding @main to the remote url for the virtual repo sets the correct headref and makes the whole thing work as expected. However even though cloning and pulling new changes from the remote works as expected, my colleagues have reported that they have been unable to push new changes back upstream.
If this is expected to work with a branch name specified like that, we could investigate the cause of the error pushing upstream further.

Hey,
Yes that is definitely a bug. We will fix it.
What version of josh are you using?

Hey,
Yes that is definitely a bug. We will fix it.
What version of josh are you using?

I believe we're on bab49919d550c5adda4d19841497eb657d7f138a, but I'm not 100% sure.

I believe we're on bab49919d550c5adda4d19841497eb657d7f138a, but I'm not 100% sure.

So, I looked into the history. This has been fixed for some time already: fa29dc8eccfbe07f65f7b7cd76f7c8bfcc059bf6

So, I looked into the history. This has been fixed for some time already: fa29dc8eccfbe07f65f7b7cd76f7c8bfcc059bf6

Thats great! I skimmed through the history before opening this issue, but I must have missed that commit somehow.
I'm pushing a new build to our server, hopefully that should resolve everything.

Thats great! I skimmed through the history before opening this issue, but I must have missed that commit somehow.
I'm pushing a new build to our server, hopefully that should resolve everything.

The automatic head branch detection still seems to fail for some reason, but using git-subrepo with the branch flag seems to work just fine!
There are still some issues pushing code back upstream, but I think they might relate to git-subrepo rather than JOSH.
Thanks again fot your help!

The automatic head branch detection still seems to fail for some reason, but using git-subrepo with the branch flag seems to work just fine!
There are still some issues pushing code back upstream, but I think they might relate to git-subrepo rather than JOSH.
Thanks again fot your help!


chore: add codecov.

Codecov Report

Merging #1 (e800ad1) into main (c1afc36) will not change coverage.
The diff coverage is n/a.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@            Coverage Diff            @@
##              main        #1   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            3         3
  Lines          146       146
=========================================
  Hits           146       146

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


MQTT Missing Resubscribe on Reconnect

Expected Behavior

When I restart my mqtt-broker, the dapr sidecar should reconnect, resubscribe and the receive messsages again
Actual Behavior

The sidecar does reconnect but not resubscribe
Steps to Reproduce the Problem

subscribe with dapr to mqtt broker
restart mqtt broker

Release Note

RELEASE NOTE:
Possible Solution
As proposed in the upstream issue (https://github.com/eclipse/paho.mqtt.golang/issues/22), we could put the subscribe call in the onConnect handler this should fix the issue.

@ItalyPaleAle you helped me with mqtt issues before, it would be awesome if you can take a look into it :)

any news about this? For us this issue is unfortunately a blocker...

I think we can get this fixed in 1.10, coming out in January/February.
We may be able to get the fix pushed to master before EOM, if you want to use a nightly build (could be buggy)

awesome! thanks for your efforts towards improving mqtt support in dapr!

We are making a lot of changes in nightly builds at the moment, so using those could certainly be risky. But the 1.10 release will be good.

#2350 should fix this


Transformations of interest

Here is the list of transformations that we'd like to verify primarily:

[x] linalg.conv->matmul
[x] linalg-fusion-for-tensor-ops(https://github.com/llvm/llvm-project/blob/d6467e00dfccf10aa91e5a1d55d981a9b13642a3/mlir/include/mlir/Dialect/Linalg/Passes.td#L59)
[ ] tileLinalgOp code
[x] linalg.matmul to a loop of mul+add
[x] Folding linalg.subview+load
[x] Folding tensor_load + extract to load
[x] linalg to llvm plan conv loop order
[x] tosa-to-linalg

What else? @makesource @STRIKE-F

We can support a few bufferize transformations as well. They are not changing function signatures.

-linalg-bufferize  (https://github.com/llvm/llvm-project/blob/bc8acf2ce8ad6e8c9b1d97b2e02d3f4ad26e1d9d/mlir/test/Dialect/Linalg/bufferize.mlir#L1)
-tensor-bufferize (https://github.com/llvm/llvm-project/blob/bc8acf2ce8ad6e8c9b1d97b2e02d3f4ad26e1d9d/mlir/test/Dialect/Tensor/bufferize.mlir#L1)
-tensor-constant-bufferize (https://github.com/llvm/llvm-project/blob/bc8acf2ce8ad6e8c9b1d97b2e02d3f4ad26e1d9d/mlir/test/Dialect/Standard/tensor-constant-bufferize.mlir#L1)

To match loops doing reduction, we can use matchReduction (https://reviews.llvm.org/D110303)

Tiling: -linalg-tile

Buffer opts:

buffer-deallocation
buffer-hoisting
buffer-loop-hoisting
promote-buffers-to-stack
buffer-results-to-out-params

-normalize-memrefs


installer: updated OC to 0.5.8 with OpenCanopy

Resolves #114
Resolves #260

Target release for June to align with acidanthera updates.

I would say it is better to target 0.5.9 due to new boot management ;)


Use latest lts in Travis

Closes #16

I've unarchived this repo so I can close all PRs and issues before re-archiving.


Db file is getting huge

Hi, My db file itself getting gigabytes of size and website stopped working due to running out of disk space. Its not the db-wal or db-shm files. Its the actual db file. I think someone is flooding my api url with fake bots and making the db file huge. Its the 2nd time it happened in past 24 hours.
is there any way to overcome this?
thanks

this is how it looks in my mobile. Im away from home at the moment.

this is how the db file looks like.


Software crashes with Arduino Leonardo

When running the every example code, the software crashes after around 10 seconds. The reset and power on and off does not reinstate de measurements, only reuploading the code makes sure that the software starts running again. However, crashes again after 10 seconds.
I have the internal I2C pullup resistors disabled and replaced with external 5K ohm resistors. The GND, 5V and address pins are all connected correctly. I am not using the data ready pin.
The IN1 is connected to ground and IN0 is connected to my analog signal.

Hi @daan03er ,
I don't have a Leonardo, so I can't fully replicate what you are seeing. I will try running it on a 5V ATmega328P board, just to see if it demonstrates the same issue.
I suspect this is something to do with either the Leonardo, or your set-up. But, from your description, you seem to be doing what I would do.

Does the example crash if you disconnect the analog signal?
Does it crash if you disconnect IN1 from ground - and use myADC.setInputMultiplexer(ADS1219_CONFIG_MUX_SINGLE_0); ?
Is your signal going higher than 5V?
Or lower than 0V?

Best,
Paul

Hi Paul,
Yes, the crash still occurs when the analog signal is disconnected. It is however after a longer periode of time compared to when the analog signal is connected.
When i set myADC.setInputMultiplexer(ADS1219_CONFIG_MUX_SINGLE_0) it does not crash when the analog signal is disconnected, when it is connected it does crash.
No, the signal is set on 1.5V

Nevermind, it just crashed

I've got the example running on a 5V ATmega328P. No crashing. Everything is working.
Please share a photo of your board, and the wires linking them.
I wonder if this is something to do with I2C clock stretching? I know the Due does not support clock stretching. Maybe the Leonardo has the same issue?
Thank you,.
Paul

Oh. Hang on... My board just crashed...!
Investigating...

OK. I think this has something to do with the reference voltage. I just tried the following and it seems to have fixed the issue:

Connect REFP to VDDA - the pins are adjacent on the SparkX PCB
Connect REFN to GND - ditto
Open Example6
Change this line to:

float milliVolts = myADC.getConversionMillivolts(5000.0); // Convert to millivolts - using a reference of 5000mV
Let me know if this fixes the issue on Leonardo too.
Thanks,
Paul

This does seems to be working, the program has been running for a minute now, gonna keep it running longer.
Do you have any idea what the issue is/was exactly?

Not exactly... The internal reference is 2.048V. Maybe the chip doesn't like common mode voltages well outside that? Just a guess... But it does seem to have fixed it.
I'm going to close this as I think we have resolved the issue - and that it's nothing to do with the library. But I will pin it, to make it easier to find.
Please reopen if you see more weirdness...
All the best,
Paul

I think it just crashed after 8 minutes....
Running again now

OK. Mine's still running... I'm not sure what else to suggest...?
Maybe double-check those pull-ups? Are you able to put a 'scope or logic analyzer on the SDA and SCL lines?
Or, are you able to test it on a 3.3V board - just to confirm that voltage is the critical issue?

I'll put a scope and the SDA and SCL pins.
I dont have a 3v3 board.

Hi Paul,
After furter investigation, the crash occurs in the following part:

I do get the serial message: "dataready reg thing".
However, after this it crashes. It happens after 10-15 minutes so I am very puzzeled.

Hi @daan03er ,
That line of code is just a standard Wire register read. The actual read is done by the Toolkit.
I really don't understand why the read is crashing...
Are you powering the ADS1219 directly from 5V? And pulling up SCL and SDA to 5V also?
Please post a photo of your boards and the connections between them. It always helps...
Best wishes,
Paul

The ADS1219 is supplied with 5V and the I2C pullups are also to 5V.

Another little trick is to put Serial.flush(); after each debug print. That way the code will wait until the serial data has actually been sent before it moves on. Then you can be absolutely sure where the crash is happening. The crash may be happening a little later, before the message is actually printed.
Thanks for the photo. Taking a look now.

Could it be that at 3v3 the I2C pullup resistors work better then at 5V? Right now I have 5Kohm pullup resistors.

Your circuit looks OK. I can't see anything wrong...  Except I can't make out your resistor values. 5K should be Green Black Red. Or Green Black Black Brown.

I measured them to be sure and they are 5K.

That's good. I'm pleased it is working.
Some decoupling capacitors may help. I suggest adding 2.2uF and 0.1uF close to the AVDD and DVDD pins.


Option to export multiple files

Hi @echo724, I discovered that when the markdown_exporter is called multiple times for different notion block id, the same notion block is being exported. I think the reason is that Config class being a singleton, is it possible to change this implementation?

@echo724 I can verify the Release 2.7.5 has fixed this problem for me. I think you can close the issue.


Setting a ResponsiveStep with 1000 minWith doesn´t work

When setting a responsive step like this:
GridHelper.responsiveStep(grid, 999).addListener(ge -> {
            grid.getColumnByKey("user-id-column").setVisible(true);
        });

I get the following behavior which is correct:

But when I set the minWith of the ResponsiveStep to 1000 (or bigger) this happens:

Is this a bug or am I doing something wrong?

I meant a minimal reproducible example [1] [2]. What's the expected behavior and how does it differ from the observed behavior? What is the actual size of the grid in your example?


Import Data Azure notification is wrong for Enterprise

When importing data into a Redis Enterprise (in this case EnterpriseFlash 345 GB (1 x 345 GB)) cache, the notification in the Azure portal incorrectly says it is complete about 10 seconds after starting the process. Clearly this isn't true, and the data doesn't change.

After a few minutes it appears in Activity Log, and shows correctly that it isn't complete:

And later it completes

Server load shows no activity during this period

For reference, Azure Cache for Redis Premium instances behave as expected. While imports are just as unreliable, the notification is correct (stays spinning at the top right of the portal until it is really done), and the graphs show activity during the period.
If we look at an example of importing MUCH less data (in which case it doesn't fail) then the initial Activity Log shows like this, where the process was started at 3:37 PM:

It then seemingly doesn't do anything until 3:57 PM (20 minutes), and then over about 5 minutes processes the data. Cursor line indicates 3:37 when it should have started.

And for completeness, here is the activity log at the end once it has succeeded

@joroda


VHDL parser should be able to parse a netlist that is not flattened

Is your feature request related to a problem? Please describe.
With the availability of modules, the vhdl parser should be able to parse a netlist with hierarchy.
The solution we will implement
All entities are parsed separately before inserted into the top entity as modules.
Signal names on inputs/outputs can be taken from the parent entity, internal signals are prefixed with the entity name.

I strongly support this feature.

Update: The feature is basically done in its respective feature branch.
It now needs testing.

@devhoffmann: Any suggestions how we should proceed?

Now merged into the master and used as a default.
The old parser is still available using the ´--language vhdl_old´ switch


Use docsrs cfg

I think this is right, but I'm not on an x86 machine, so hard to test all of it for me.


[Regression] Pin callout is not shown when user clicks on the pin

Description
Pin callout is not shown when user clicks on the pin in my attached project and also in the sample project
Steps to Reproduce

Download the attach project and run it with android
Click on the pin

Expected Behavior
Should open the callout somewhere near the pin
Actual Behavior
No callout shows up
Basic Information

Version with issue:
Last known good version: N/A
Platform Target Frameworks:

iOS:  Not checked in iOS
Android: Android API 30, mdpi 5.4 inch emulator
UWP:  N/A

Screenshots

Reproduction Link
MapsText.zip
Workaround
None found
Extra notes
This issue happens in sample project provided in the github as well, if you want to test in there then open Mapsui.Samples.Forms.Android as start up project and open AddManyPins and put break point in OnPinClicked in MapPage.Xaml.cs and observe that it fires when clicked on pin but doesn't show anything. But in my attached  project by adding pin.ShowCallout(); OnAppearing() shows the content but ui is not proper(as shown in 2nd screenshot) and doesn't reopen once clicked again.
Any fixes or suggestions are appreciated.

Confirmed. With current master, I see the following errors with the "Add Pin Sample":
Error: Unexpected error in skia renderer, System.InvalidCastException: Specified cast is not valid.
  at Mapsui.Rendering.Skia.CalloutStyleRenderer.Draw (SkiaSharp.SKCanvas canvas, Mapsui.IReadOnlyViewport viewport, Mapsui.Layers.ILayer layer, Mapsui.IFeature feature, Mapsui.Styles.IStyle style, Mapsui.Rendering.ISymbolCache symbolCache, System.Int64 iteration) [0x00001] in /Users/weija001/github/Mapsui/Mapsui.Rendering.Skia/SkiaStyles/CalloutStyleRenderer.cs:15
  at Mapsui.Rendering.Skia.MapRenderer.RenderFeature (SkiaSharp.SKCanvas canvas, Mapsui.IReadOnlyViewport viewport, Mapsui.Layers.ILayer layer, Mapsui.Styles.IStyle style, Mapsui.IFeature feature, System.Single layerOpacity, System.Int64 iteration) [0x00037] in /Users/weija001/github/Mapsui/Mapsui.Rendering.Skia/MapRenderer.cs:130
  at Mapsui.Rendering.Skia.MapRenderer+<>c__DisplayClass15_0.<Render>b__0 (Mapsui.IReadOnlyViewport v, Mapsui.Layers.ILayer l, Mapsui.Styles.IStyle s, Mapsui.IFeature f, System.Single o, System.Int64 i) [0x00001] in /Users/weija001/github/Mapsui/Mapsui.Rendering.Skia/MapRenderer.cs:111
  at Mapsui.Rendering.VisibleFeatureIterator.IterateLayer (Mapsui.IReadOnlyViewport viewport, Mapsui.Layers.ILayer layer, System.Int64 iteration, System.Action`6[T1,T2,T3,T4,T5,T6] callback) [0x001b7] in /Users/weija001/github/Mapsui/Mapsui/Rendering/VisibleFeatureIterator.cs:69
  at Mapsui.Rendering.VisibleFeatureIterator.IterateLayers (Mapsui.IReadOnlyViewport viewport, System.Collections.Generic.IEnumerable`1[T] layers, System.Int64 iteration, System.Action`6[T1,T2,T3,T4,T5,T6] callback) [0x0004c] in /Users/weija001/github/Mapsui/Mapsui/Rendering/VisibleFeatureIterator.cs:21
  at Mapsui.Rendering.Skia.MapRenderer.Render (SkiaSharp.SKCanvas canvas, Mapsui.IReadOnlyViewport viewport, System.Collections.Generic.IEnumerable`1[T] layers) [0x0001e] in /Users/weija001/github/Mapsui/Mapsui.Rendering.Skia/MapRenderer.cs:111

Must be a rather recent problem, this definitely did not occur a couple of weeks ago.

Must be a rather recent problem, this definitely did not occur a couple of weeks ago.

The last working version that I'm aware of is 88a4c6d57b1b6227049facef30722ed652e68867. One could do a bisection to see when it broke.
A possible candidate might be the recent update of SkiaSharp (#1513)?

A possible candidate might be the recent update of SkiaSharp (#1513)?

Bad guess. From what I see now it rather seems to be related to #1482.

From what I see now, it rather seems to be related to #1482.

... and in particular 766d24774182d7100d5a6b1e03e743aeebf47151 seems to be the culprit.
@charlenni, this is yours. Could you have a look, please?

Thanks a lot @g-sharat for the sample. Thanks @janusw for finding the problem. I submitted a PR to fix this.

Sorry for not looking into this. Was the whole week out of office. But thanks @pauldendulk it is repaired.

I can confirm that the problems with the PinSample and ManyPinsSample are fixed with 4.0.0-beta.2.

Hai @pauldendulk thanks for checking this but have you tested with my sample attached? I have upgraded the package to the 4.0.0-beta.2 but issue is still persistent @janusw

You are right, I can reproduce your problem on beta.2.

I tried to reproduce your problem by adding a sample in Mapsui, but in this case it works as expected (tested in UWP).

using System;
using Mapsui.Extensions;
using Mapsui.Projections;
using Mapsui.Tiling;
using Mapsui.UI;
using Mapsui.UI.Forms;

namespace Mapsui.Samples.Forms.Shared
{
    public class SinglePinSample : IFormsSample
    {
        public string Name => "Single Pin Sample";

        public string Category => "Forms";

        public bool OnClick(object? sender, EventArgs args)
        {
            var mapView = sender as MapView;

            if (mapView == null)
                return false;

            return true;
        }

        public void Setup(IMapControl mapControl)
        {
             var mapView = (MapView)mapControl;

            var map = new Map
            {
                CRS = "EPSG:3857",
            };
            var tileLayer = OpenStreetMap.CreateTileLayer();

            map.Layers.Add(tileLayer);

            var centerOfLondonOntario = new MPoint(-81.2497, 42.9837);
            var sphericalMercatorCoordinate = SphericalMercator.FromLonLat(centerOfLondonOntario.X, centerOfLondonOntario.Y).ToMPoint();
            map.Home = n => {
                n.NavigateTo(sphericalMercatorCoordinate, map.Resolutions[9]);
            };

            mapView.IsMyLocationButtonVisible = false;
            mapView.IsZoomButtonVisible = false;
            mapView.IsNorthingButtonVisible = false;
            mapView.MyLocationEnabled = true;
            map.RotationLock = true;
            var pin = new Pin(mapView)
            {
                Label = "I am pin",
                Position = new Position(centerOfLondonOntario.Y, centerOfLondonOntario.X),
                Address = "This is my address",
                Type = PinType.Svg,

            };

            pin.ShowCallout();

            //By adding below line it shows the callout or else it won't
            //pin.ShowCallout();

            mapView.Pins.Add(pin);
            //mapView.PinClicked += mapView_PinClicked;
            mapView.Map = map;
        }
    }
}

Perhaps I should leave this problem for others to solve.
An alternative is to look at SingleCalloutSample.cs. It does not use the Pin class. You have to do a bit more work, but you have more control. With this approach a callout is a passive style on a feature, and it is up to you to show it or not.


[Event Request] table 5050 Contact - OnBeforTestManual

We should be able to test our own series of numbers.
        field(1; "No."; Code[20])
        {
            Caption = 'No.';

            trigger OnValidate()
            begin
                if "No." <> xRec."No." then begin
                    RMSetup.Get();
>> NEW CODE
DefaultNoSeriesCode := RMSetup."Contact Nos.";
OnBeforTestManual(DefaultNoSeriesCode);
                    NoSeriesMgt.TestManual(DefaultNoSeriesCode);
<< NEW CODE
                    "No. Series" := '';
                end;
            end;
        }

It should also be possible to choose your own number series.
    trigger OnInsert()
    begin
        RMSetup.Get();

        if "No." = '' then begin
>> NEW CODE
IsHandled := false;
OnBeforeInitSeires(xRec."No. Series", "No.", "No. Series", IsHandled);
if  not IsHandled then begin
            RMSetup.TestField("Contact Nos.");
            NoSeriesMgt.InitSeries(RMSetup."Contact Nos.", xRec."No. Series", 0D, "No.", "No. Series");
end;
<< NEW CODE
        end;

    [IntegrationEvent(false, false)]
    local procedure OnBeforTestManual(var DefaultNoSeriesCode: Code[20])
    begin
    end;

    [IntegrationEvent(false, false)]
    local procedure OnBeforeInitSeires(OldNoSeriesCode: Code[20]; var NewNo: Code[20]; var NewNoSeriesCode: Code[20]; IsHandled: Boolean)
    begin
    end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release.
We will update this issue with information about availability. Please do not reply to this, as we do not monitor closed issues.
If you have follow-up questions or requests, please create a new issue where you reference this one.


Create Entity C# execution options API

Move the create entity options from #60. Create entities from execution options and have their callbacks return with the correct id.

Closed by #72


Had to delete a registry key after running Remove-HybridRunbookWorker

After running the Remove-HybridRunbookWorker command as described above.  Running Add-HybridRunbookWorker failed with "Machine is already registered to a different account."  message.
To get past this error,  I had to delete the HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\HybridRunbookWorker registry key.   After I deleted this key, the Add-HybridRunbookWorker call succeeded.
(See https://www.baswijdenes.com/portfolio/add-hybridrunbookworker-machine-already-registered-different-account/ for details)

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3092ee3a-3c57-cc53-186b-b454e7d9d190
Version Independent ID: 6f6b5a07-397a-98a2-6091-941244a77837
Content: Azure Automation Hybrid Runbook Worker
Content Source: articles/automation/automation-hybrid-runbook-worker.md
Service: automation
GitHub Login: @georgewallace
Microsoft Alias: gwallace

Test

Thanks for the feedback! We are currently investigating and will update you shortly.

@georgewallace to review the feedback and determine next action.

@MicahMcKittrick-MSFT Thanks for the feedback.. I have a workitem to get this added in our troubleshooting docs.. once I get the update in I will submit a PR to close this issue.. Thanks for reporting this missing info in our docs.


Path to file is wrong for Windows

Paths on Windows uses \ instead of /. We should make it compatible with both.

Fixed.


Enhancement

createEmail($user_name, $password, $domain_name, $quota);
deleteEmail($user_name, $domain_name)

Add these as default functions.

@anantgrafix feel free to submit a PR. I may add more default methods in the next version.

@anantgrafix feel free to submit a PR. I may add more default methods in the next version.


fix make clean error

Fix the following error:
➜  buildah git:(master) ✗ make clean
rm -f buildah imgtype build
rm: cannot remove 'build': Is a directory
Makefile:28: recipe for target 'clean' failed
make: *** [clean] Error 1

Signed-off-by: Zhou Hao<EMAIL_ADDRESS>

LGTM

The build directory was added for the COPR Enablement in #460.  It's not causing an error for me, not sure what's going on for you @q384566678 .  @baude any thoughts?

@TomSweeneyRedHat when build exists, make clean fails as it cannot delete it.
If we need build then we have to change $(RM) to $(RM) -r

I think we should be removing build on a make clean.
So adding -r would be the correct fix.

The build directory was added for the COPR Enablement ...

@TomSweeneyRedHat I noticed this pr, but .copr/Makefile file is gone, and I'm not clear how to create build file.

updated, thanks all.

LGTM and happy green test buttons.  Thanks @q384566678 !

@rh-atomic-bot r+


[feat] Identify external links in the toolbar

#7101 introduced a new menu in the toolbar for link to external resources. I believe this is the first time there have been external links in the toolbar.
It'd be good if external links were identified, preferably by a font awesome icon;
https://fontawesome.com/v5.15/icons/external-link-alt?style=solid
The python side of this is fairly straightforward;
cms_toolbars.py contains add_help_menu() and here calls to add_link_item() need to pass a new kwarg. I'd suggest external (set to True).
In cms/toolbar/items.py, add_link_item() needs a new kwarg matching the above, defaulting to False. And this is passed through to LinkItem where it becomes an instance attribute and is passed into the context.
I think the final thing then becomes a conditional in the template to render the icon. That's templates/cms/toolbar/items/item_link.html.
The last part, where I'm not so familiar with the best approach is to get the icon to align to the right of the menu.
Doing the above should result in something like this;

Hi, @marksweb Is anyone is working on this, if not can I work on this? Can you please guide me too how to setup this locally cuz this would be my first contribution to this open source.

Hi, @marksweb Is anyone is working on this, if not can I work on this? Can you please guide me too how to setup this locally cuz this would be my first contribution to this open source.

Hello 👋🏽
I'm working on this right now. There is already draft PR for it: #7283
But I had no time to continue working on this so far.


Add integration for docker secrets

Overview
Add docker secret compatibility to flame.
Related Issues

#189

Hi @pawelmalak - I was wondering if you would be able to review this PR?

I'm having a pretty rough week and don't have much time to work on Flame. I'll try to check it in a few days.


ENOENT, readdir '.../shp/land-polygons-split-3857'

I am follow this tutorial https://www.mapbox.com/tilemill/docs/guides/osm-bright-mac-quickstart/
I am block on final step 3.

the content of folder is

and the permissions are ...

The version of tile Mill is https://github.com/mapbox/tilemill#installation there is problem with tile mill in Yosemite.
can someone help?

For me config["ne_places"] was pointing to an empty directory so I followed the step to download 10m-populated-places-simple.zip and replace all the '-' with '_'
Places shapefile required for the osm2pgsql style
- http://mapbox-geodata.s3.amazonaws.com/natural-earth-1.4.0/cultural/10m-populated-places-simple.zip
or
- http://www.naturalearthdata.com/http//www.naturalearthdata.com/download/10m/cultural/ne_10m_populated_places.zip
config["ne_places"] = path.join(getcwd(),"shp/10m_populated_places_simple/10m_populated_places_simple.shp")
Dont know if the following had any contribution but I made the follwoing changes too:
I removed all the numbers in the paths:
config["land-high"] = path.join(getcwd(),"shp/land_polygons_split/land_polygons.shp")
config["land-low"] = path.join(getcwd(),"shp/simplified_land_polygons_complete/simplified_land_polygons.shp")
Rename the name folder to:
mapbox_osm

Following pages needs to be updated:
https://tilemill-project.github.io/tilemill/docs/guides/osm-bright-mac-quickstart/
Additions
this file has to be unzipped in sh and paths have to be updated.


Is there a way to specify a time range for get_history?

First of all, thank you for building this reverse engineered unofficial API for tastyworks! Much appreciated!
I was trying to use TradingAccount.get_history and it seems it returns transactions for about a month's worth of history. I was wondering if there's a way to specify a time range when querying the main Tastyworks API?

I haven't had the time or chance to develop this for a while now so I'm not aware unfortunately :)
There might or might be an endpoint served by tastyworks to do that but I would have to investigate. It's a fair assumption though that if none of their clients support it, then the endpoint won't be there.

I see. The clients do have a way to specify a time window. What tools do you use to investigate the endpoints?

Hmm, then there should be an endpoint and it should be possible. There are several ways to do this but you basically have to peek into the traffic between the client (phone, desktop or website) and the server. There are multiple tools out there to do this :)

Thanks! I'll look into it when I get some time.

extended history available in this PR (does not have a date range, just extends the range and demonstrates how to adjust the dates)
https://github.com/boyan-soubachov/tastyworks_api/pull/56

extended history available in this PR (does not have a date range, just extends the range and demonstrates how to adjust the dates)
https://github.com/boyan-soubachov/tastyworks_api/pull/56


Migrate PCB-rnd

https://github.com/ngi-nix/pcb-rnd/tree/master merge into ngipkgs monorepo
also probably needs updating of librnd, taking care of reverse dependencies, as its major version was bumped.
http://cgi.repo.hu/cgi-bin/minisvn.cgi?cmd=cat&repo=librnd&path=trunk/Changelog

When you create a new issue, there's a template chooser. One of the available templates is for migrations, which was applicable here. Please use it in the future, or if you are not happy with it, file an issue explaining why.

Related to #12


Bug/fix brief display links

@barnabyalter ,
I believe I have fixed this bug. Please let me know if the failing test that I have added is what you were thinking of? Thanks.

Coverage remained the same at 97.5% when pulling e8d777c7e13d56d9cc1e1c6bff2ff8f75cf68977 on bug/fix_brief_display_links into ee3947dc0c602dc70eedae5cfc676d5ee26a2b56 on development.

Coverage remained the same at 97.5% when pulling e8d777c7e13d56d9cc1e1c6bff2ff8f75cf68977 on bug/fix_brief_display_links into ee3947dc0c602dc70eedae5cfc676d5ee26a2b56 on development.

@barnabyalter ,
Let me know if the failing test is acceptable or if I need to flesh it out more? I've basically just changed the test looking for Archival Collection to a not.


Getting started with Spring Boot WebFlux

Getting started with Spring Boot WebFlux
Your title should be descriptive of the article/tutorial. Be Specific. Use keyword research to gain your article a higher ranking.
Introduction paragraph (2-3 paragraphs):
Reactive programming is a programming paradigm that promotes an asynchronous, non-blocking, event-driven approach to data processing. Reactive programming involves modeling data and events as observable data streams and implementing data processing routines to react to the changes in those streams.
Spring WebFlux is a parallel version of Spring MVC and supports fully non-blocking reactive streams. It supports the backpressure concept and uses Netty as an inbuilt server to run reactive applications.
In the tutorial, I will explain the basic concepts behind reactive programming, WebFlux APIs, and build a fully functional CRUD API example.
Key takeaways:

How to set up WebFlux in a Spring Boot application.
How to create CRUD API using WebFlux.

References:
N/A
Templates to use as guides

How To Guide Template
Software Review Template
Tutorial Template

@sumbaelvis
Sounds like a helpful topic - lets please be sure it add value beyond what is in the official docs and what is covered in other blog sites.
Please be sure to double check that it does not overlap with any existing EngEd articles or incoming topic suggestions (if you haven't already) to avoid any potential article closure, please reference any relevant EngEd articles in yours. - Approved

@sumbaelvis
Just pinging you on this topic form - as I'm making some room in the topic queue.
No rush if you're still working on this one - if you need more time we can always re-open at a later date.

Hello @hectorkambow I am requesting for reopening of this issue, I am done with writing the article.

Closed #2779 via #3805


campaignCost not matching in get_rtb_device_stats method

When breaking by device via get_rtb_device_stats, the sum of campaignCost column is not the same as the total provided by RTBPanel and other methods in API, such as get_campaign_stats_total

Please report only issues connected with SDK code, in case of problems with API please contact<EMAIL_ADDRESS>


Revisit elemental release procedures

Few things to improve and elaborate around releases:

[x] Not all sources are in github (specs, dockerfiles, etc.)

I'd suggest adding a some sort of dist/obs/ folder within the repos to include those. In dist/obs there could be a README.md explaining the files in there are OBS specific and mostly used for SUSE's builds.

[x] Rebuild of RPMs on PRs
[x] Release candidate tags are useless, probably we should simply consider Stable as our RC once artifacts are in registry.suse.com
[ ] #711
[x] Arrange IBS project to built properly, SR is accepted, but images are not building
[ ] #712

I could not manage to test IBS as I wanted (mirroring registry.suse.com to registry.suse.de) but a clean deployment based on registry.suse.de artifacts went smooth.
I also struggled to set a custom certificate for registry.suse.de, looks like on every reboot the /etc/rancher/k3s/registries.yaml file is overwritten by something, looks like there is some k3s service or script creating this file on every reboot...
Closing this issue as a couple of missing parts are separated in devoted non urgent or blocked issues.


To be able to download theme data

You can now download:

Original files (CSV and GPX) from which the layers are based on.
GeoJSON files containing the layer loaded informations.


Chore: add form schemas

DO NOT MERGE AS IS
move json form schemas into the database & refactor multi-form schemas into one schema.

closed in favor of #1035


Fix incorrect bounds check for set_scissor_rect

In EguiNode::run, an attempt is made to fix for bad scissor rect bounds by the width & height of the scissor rect to the physical window.
However, this only works if the scissor rect starts at (0, 0); if it isn't, then the scissor rect may still go out of bounds of the window.
This can cause a panic from wgpu when window.resolution.set(x, y) is called from WASM with a resolution lower than the current setting, as when the window updates, but the egui draw commands haven't been updated, the scissor rect can extend outside of the render target if it has an offset top-left corner.

This PR changes it so that the scissor rect bound check subtracts the upper left coordinate, ensuring that the scissor rect remains within the bounds of the window even if the draw command doesn't originate at the top left.
I have tested and confirmed this change fixes the panic and doesn't appear to have any rendering inconsistencies either from WASM or Windows.

Great catch, thank you for the fix!


Deduplicate docs between Policy and Component

Right now some information is repeated in docs of a Component and the Policy.
Decide what should go where and deduplicate docs (inserting links where appropriate)
Discovered when working on #143

@krdln,
Is this still relevant?

Closing.


Exit code 100 returned from process for tc vc scorch when multiple paths mapped in TFVC

Agent Version and Platform
Version of your agent? 2.179.0
OS of the machine running the agent? Windows
Azure DevOps Type and Version
dev.azure.com (formerly visualstudio.com), with self-hosted agent.
If dev.azure.com, what is your organization name? https://{organization}.visualstudio.com
What's not working?
Consider the following "Get sources" configuration:

Source: TFVC
Workspace mappings:

Type
Local path under $(build.sourcesDirectory)
Server path

Map
$/{TF root}/Trunk/Database
Database

Map
$/{TF root}/Trunk/Specifications
Specifications

Clean: true
Clean options: Sources and output directory

With that setup, the "clean" functionality exits with code 100, and does not appear to actually clean the working directory:
2020-12-22T01:58:31.6892122Z ##[command]tf vc scorch C:\agent\_work\1\s /recursive /diff /unmapped /loginType:OAuth /login:.,*** /noprompt
2020-12-22T01:58:32.4926022Z No appropriate mapping exists for C:\agent\_work\1\s.
2020-12-22T01:58:32.5111604Z ##[warning]Exit code 100 returned from process: file name 'tf', arguments 'vc scorch C:\agent\_work\1\s /recursive /diff /unmapped /loginType:OAuth /login:.,*** /noprompt'.

Agent and Worker's Diagnostic Logs
2020-12-22T01:58:29.3879571Z ##[section]Starting: Checkout {TF root}@ to s
2020-12-22T01:58:29.4337533Z ==============================================================================
2020-12-22T01:58:29.4338024Z Task         : Get sources
2020-12-22T01:58:29.4338406Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-12-22T01:58:29.4338604Z Version      : 1.0.0
2020-12-22T01:58:29.4338850Z Author       : Microsoft
2020-12-22T01:58:29.4339265Z Help         : [More Information](https://go.microsoft.com/fwlink/?LinkId=798199)
2020-12-22T01:58:29.4339507Z ==============================================================================
2020-12-22T01:58:30.2697349Z Prepending Path environment variable with directory containing 'tf.exe'.
2020-12-22T01:58:30.2701260Z Setting environment variable TFVC_BUILDAGENT_POLICYPATH
2020-12-22T01:58:30.2708494Z Querying workspace information.
2020-12-22T01:58:31.6892122Z ##[command]tf vc scorch C:\agent\_work\1\s /recursive /diff /unmapped /loginType:OAuth /login:.,*** /noprompt
2020-12-22T01:58:32.4926022Z No appropriate mapping exists for C:\agent\_work\1\s.
2020-12-22T01:58:32.5111604Z ##[warning]Exit code 100 returned from process: file name 'tf', arguments 'vc scorch C:\agent\_work\1\s /recursive /diff /unmapped /loginType:OAuth /login:.,*** /noprompt'.
2020-12-22T01:58:32.5132721Z ##[command]tf vc workspace /delete ws_1_24%3B949a0bb7-b363-414a-a548-df9bb9debb6e /collection:https://{organization}.visualstudio.com/ /loginType:OAuth /login:.,*** /noprompt
2020-12-22T01:58:34.7180459Z ##[command]tf vc workspace /new /location:local /permission:Public ws_1_24 /collection:https://{organization}.visualstudio.com/ /loginType:OAuth /login:.,*** /noprompt
2020-12-22T01:58:35.8141471Z ##[command]tf vc workfold /unmap /workspace:ws_1_24 $/ /collection:https://{organization}.visualstudio.com/ /loginType:OAuth /login:.,*** /noprompt
2020-12-22T01:58:36.6757877Z ##[command]tf vc workfold /map /workspace:ws_1_24 $/{TF root}/Trunk/Database C:\agent\_work\1\s\Database /collection:https://{organization}.visualstudio.com/ /loginType:OAuth /login:.,*** /noprompt
2020-12-22T01:58:37.4909502Z ##[command]tf vc workfold /map /workspace:ws_1_24 $/{TF root}/Trunk/Specifications C:\agent\_work\1\s\Specifications /collection:https://{organization}.visualstudio.com/ /loginType:OAuth /login:.,*** /noprompt
2020-12-22T01:58:38.4367045Z ##[command]tf vc get /version:506 /recursive /overwrite C:\agent\_work\1\s /loginType:OAuth /login:.,*** /noprompt
2020-12-22T01:58:40.0805281Z C:\agent\_work\1\s:
2020-12-22T01:58:40.0815722Z Getting Database
...

Hi @davisnw thanks for reporting this - it seems to be similar to https://github.com/microsoft/azure-pipelines-agent/issues/422 - we are planning to recheck current root mapping.
As a workaround - could you please try one suggested here?

@anatolybolshakov - changing the "Clean options" to "All build directories" avoids the "Exit code 100" and results in the following log
Starting: Checkout {TF root}@ to s
==============================================================================
Task         : Get sources
Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
Version      : 1.0.0
Author       : Microsoft
Help         : [More Information](https://go.microsoft.com/fwlink/?LinkId=798199)
==============================================================================
Prepending Path environment variable with directory containing 'tf.exe'.

So it looks like that option skips "scorch" and simply recreates the workspace in its entirety.  So I think the tradeoff is that if the checkout is large, recreating the workspace means spending more time downloading from source control vs actually scorching.  However, this option does appear to result in a clean workspace.

Hmm, strike that on the tradeoffs - I see now that both of the options did a tf vc workspace /delete and remap.
So now I'm a bit confused - without the "scorch" option could setting "Clean options" to "All build directories" leave around files that are not mapped in source control? I think perhaps I don't understand the impacts of tf vs workspace /delete followed by tf workfold

@davisnw, this looks like this issue is related to external assembly which agent is using - scorch command throws an error when root mapping is not defined. Could you please create ticket on https://developercommunity.visualstudio.com/spaces/21/index.html so we could triage it properly?

Closed the issue. Please feel free to ask any further questions.


Json Object assignment reference the same variable

I have a global Json Object with some values I want to reuse so I assign this to a local Json Object and add more values, however the local variable reference the global variable and the new values are also added to the global variable.
_trigger OnRun()
begin
    GlobalJsonObject.Add('Title','Test');
    BuildJsonObject('This is a test.');
    GlobalJsonObject.WriteTo(JsonContent);
    Message(JsonContent);
    //{"Title":"Test","Body":"This is a test."}
end;

var
    GlobalJsonObject: JsonObject;
    JsonContent: Text;

procedure BuildJsonObject(Body:Text)
var
    JObject: JsonObject;
begin
    JObject := GlobalJsonObject;
    JObject.Add('Body',Body);
end;_

Hi @Joel-NAVDev,
If you want the local variable to be a copy of the global variable then you can make a clone of it: JsonToken.Clone()

Thanks @thpeder, I can confirm JObject :=  GlobalJsonObject.Clone().AsObject() works as expected in the above example.


About

I think that the 'About' page should be a little more fleshed out by including a brief introduction about who you are and what you do. The 'About' page as it currently stands just starts right off the bat with being defensive about your positions. What I'm picturing in my head are outsiders like the Atlanta DSA hearing about this "Destiny" guy while getting links to this page and still not really knowing much about who exactly "Destiny" is.
I believe a better structure would look something like this:
About
Who I am / who is destiny?
(small blurb about streaming career)
(would be nice to have a picture of you in this section as well)
Projects / Political advocacy
(List of achievements and/or projects such as Georgia canvassing, possibly even Omaha canvassing as well )
Why I made this website/blog
(Just include everything you already have under this section)

Can either @lavrentidan  or @ILiedAboutCake close this, it's been resolved as of #109


[CLU] add LRO return types and tests

API change check
APIView has identified API level changes in this PR and created following API reviews.
azure-ai-language-conversations


can't work with me, i get error

copilot -q "What is the best drink for late night coding?"
Traceback (most recent call last):
  File "/home/eid/.local/bin/copilot", line 5, in <module>
    from copilot.main import main
  File "/home/eid/.local/lib/python3.8/site-packages/copilot/main.py", line 12, in <module>
    from copilot.conversation import Conversation
  File "/home/eid/.local/lib/python3.8/site-packages/copilot/conversation.py", line 20, in <module>
    class Conversation:
  File "/home/eid/.local/lib/python3.8/site-packages/copilot/conversation.py", line 21, in Conversation
    messages: list[dict]
TypeError: 'type' object is not subscriptable

??


Bump upper bound of hashable package.

we can have a hackage revision to accompany this change

thanks! revision incoming


geolocator_apple > 2.2.2 does not work in background ?

💬 Questions and Help
Hello,
I have a flutter application using geolocator 9.0.2 on iOS.
My application is designed to run continuously for a long time in order to report user position, although the application is in background (smartphone in sleep mode or application not on the front).
Using geolocator_apple 2.2.2,everything is OK, but using 2.2.5 or 2.2.6, I get an error message :
LOCATION UPDATE FAILURE:Error reason: (null)Error description: The operation couldn’t be completed. (kCLErrorDomain error 1.)
[VERBOSE-2:dart_vm_initializer.cc(41)] Unhandled Exception: The operation couldn’t be completed. (kCLErrorDomain error 1.)
#0      GeolocatorApple.getPositionStream.<anonymous closure> (package:geolocator_apple/src/geolocator_apple.dart:188:9)
#1      Stream.handleError.<anonymous closure> (dart:async/stream.dart:929:16)
#2      _HandleErrorStream._handleError (dart:async/stream_pipe.dart:269:17)
#3      _ForwardingStreamSubscription._handleError (dart:async/stream_pipe.dart:157:13)
#4      _RootZone.runBinaryGuarded (dart:async/zone.dart:1605:10)
#5      _BufferingStreamSubscription._sendError.sendError (dart:async/stream_impl.dart:358:15)
#6      _BufferingStreamSubscription._sendError (dart:async/stream_impl.dart:376:7)
#7      _BufferingStreamSubscription._addError (dart:async/stream_impl.dart:280:7)

And my application is no longer collecting the location.
I've checked all permissions are active (Location: While Using the App, and Background : location capability is set).
Any idea why I keep having this issue ?
Thank you for your help
Regards,
Christophe.

+1

Does it stop collecting the location data immediately or after some time, and can you inform me about how long it takes before you run into this issue?
It would be helpful if you could provide the output of 'flutter doctor -v' and clear, step-by-step instructions to reproduce the issue in the comment section. This will assist us in better understanding and addressing the problem.

Hi @ChristopheLyonnaz,
Thank you for providing the additional details, we will start looking into this. If you do manage to create a real testing application that would still help out a lot.

Hi @ChristopheLyonnaz,
Can you please confirm the following: Do you have allowBackgroundLocationUpdates set to true in your locationSettings? e.g. like below (see example app):
geolocatorApple.getPositionStream(
locationSettings: AppleSettings(
accuracy: LocationAccuracy.best,
distanceFilter: 10,
activityType: ActivityType.other,
// Only set showBackgroundLocationIndicator and
// allowBackgroundLocationUpdates to true if our app will be started up
// in the background.
showBackgroundLocationIndicator: false,
allowBackgroundLocationUpdates: true,
));
And:
/// For this setting to work Info.plist should contain the following keys:
/// - UIBackgroundModes and the value should contain "location"
/// - NSLocationAlwaysUsageDescription
Waiting for your reply,
Tim

Hi @TimHoogstrate ,
Great news, this option totally fixes my issue. I am so sorry not being able to see it earlier.
Thank you for your valuable help.
Christophe.

Hi Chantha,
This issue was raised quite a long time ago.
Since this, I slighty changed my code. The following simplified code is what I implemented on iOS :
  void requestLocationUpdates() async {
    LocationSettings locationSettings;

    serviceEnabled = await Geolocator.isLocationServiceEnabled();
    permission = await Geolocator.checkPermission();

      locationSettings = AppleSettings(
        accuracy: LocationAccuracy.high,
        activityType: ActivityType.airborne,
        distanceFilter: 50,
        pauseLocationUpdatesAutomatically: true,
        // Only set to true if our app will be started up in the background.
        showBackgroundLocationIndicator: true,
        allowBackgroundLocationUpdates: true,
      );

    positionStream = Geolocator.getPositionStream(locationSettings: locationSettings) // 2 mètres entre 2 positions
        .listen((Position position) {
      _position = position;
}

Hi Chantha,
This issue was raised quite a long time ago. Since this, I slighty changed my code. The following simplified code is what I implemented on iOS :
  void requestLocationUpdates() async {
    LocationSettings locationSettings;

    serviceEnabled = await Geolocator.isLocationServiceEnabled();
    permission = await Geolocator.checkPermission();

      locationSettings = AppleSettings(
        accuracy: LocationAccuracy.high,
        activityType: ActivityType.airborne,
        distanceFilter: 50,
        pauseLocationUpdatesAutomatically: true,
        // Only set to true if our app will be started up in the background.
        showBackgroundLocationIndicator: true,
        allowBackgroundLocationUpdates: true,
      );

    positionStream = Geolocator.getPositionStream(locationSettings: locationSettings) // 2 mètres entre 2 positions
        .listen((Position position) {
      _position = position;
}

Yes Thanks brother. I already apply this but it doesn't work . I still got error :
Unhandled Exception: The operation couldn’t be completed. (kCLErrorDomain error 1.)
#0      GeolocatorApple.getPositionStream. (package:geolocator_apple/src/geolocator_apple.dart:188:9)
#1      Stream.handleError. (dart:async/stream.dart:923:16)
#2      _HandleErrorStream._handleError (dart:async/stream_pipe.dart:269:17)
#3      _ForwardingStreamSubscription._handleError (dart:async/stream_pipe.dart:157:13)
#4      _RootZone.runBinaryGuarded (dart:async/zone.dart:1606:10)
#5      _BufferingStreamSubscription._sendError.sendError (dart:async/stream_impl.dart:358:15)
#6      _BufferingStreamSubscription._sendError (dart:async/stream_impl.dart:376:7)
#7      _BufferingStreamSubscription._addError (dart:async/stream_impl.dart:280:7)
#8      _ForwardingStreamSubscription._addError (dart:async/stream_pipe.dart:128:11)
#9      _ForwardingStream._handleError (dart:async/stream_pipe.dart:95:10)
#10     _ForwardingStreamSubscription._handleError (dart:async/stream_pipe.dart:157:13)
#11     _RootZone.runBinaryGuarded (dart:async/zone.dart:1606:10)
#12     _BufferingStreamSubscription._sendError.sendError (dart:async/stream_impl.dart:358:15)
#13     _BufferingStreamSubscription._sendError (dart:async/stream_impl.dart:376:7)
#14     _BufferingStreamSubscription._addError (dart:async/stream_impl.dart:280:7)
#15     _SyncBroadcastStreamController._sendError. (dart:async/broadcast_stream_controller.dart:392:20)
#16     _BroadcastStreamController._forEachListener (dart:async/broadcast_stream_controller.dart:322:15)
#17     _SyncBroadcastStreamController._sendError (dart:async/broadcast_stream_controller.dart:391:5)
#18     _AsBroadcastStreamController.addError (dart:async/broadcast_stream_controller.dart:486:5)
#19     _RootZone.runBinaryGuarded (dart:async/zone.dart:1606:10)
#20     _BufferingStreamSubscription._sendError.sendError (dart:async/stream_impl.dart:358:15)
#21     _BufferingStreamSubscription._sendError (dart:async/stream_impl.dart:376:7)
#22     _DelayedError.perform (dart:async/stream_impl.dart:526:14)
#23     _PendingEvents.handleNext (dart:async/stream_impl.dart:620:11)
#24     _PendingEvents.schedule. (dart:async/stream_impl.dart:591:7)
#25     _microtaskLoop (dart:async/schedule_microtask.dart:40:21)
#26     _startMicrotaskLoop (dart:async/schedule_microtask.dart:49:5)

Just to be sure, now I've migrated to the following content in pubspec.yaml:
  sdk: '>=3.1.0 <4.0.0' # Dart SDK release
  geolocator: ^10.0.1, which leads to geolocator_apple-2.3.2.

At the time I fixed workaround the issue, I had:
  sdk: ">=2.7.0 <3.0.0"

  geolocator: ^9.0.2

dependency_overrides:
  geolocator_apple: 2.2.2

And obviously, I have the following in my Info.plist:
	<key>NSLocationAlwaysUsageDescription</key>
	<string>This app needs access to location xxxx.</string>
	<key>NSLocationWhenInUseUsageDescription</key>
	<string>This app needs access to location xxxx.</string>
	<key>NSLocationAlwaysAndWhenInUseUsageDescription</key>
	<string>This app needs access to location xxxx.</string>


Drive letters are not handled

pass in C:\Users vs c:\Users. In the second case the c is not made upper case

Fixed in fork Profiscience/true-case-path, published in 2.0.0


tweak Pun Linguist to consistently format wiktionary links to be useful

also double-check my prompt engineering template
https://github.com/hchiam/learning-prompt-eng/blob/main/open_ai_course_notes.md#example-prompt-template-wip
what to change

custom gpt and notes: https://github.com/hchiam/learning-prompt-eng/tree/main/example_prompts/pun_linguist_gpt
bookmarklet: https://github.com/hchiam/learning-js/blob/main/bookmarklets/generateMnemonics.js

draft:
`You are Pun Linguist, a positive and helpful teacher GPT designed to always create more than one (and up to a max of 3) pun-based mnemonic per foreign-language word that the user/learner asks about. Additionally, as Pun Linguist, you also automatically provide Wiktionary links for each word to assist users in double-checking meanings and pronunciations. This approach enriches the learning experience by offering diverse mnemonic choices and reliable language resources. The GPT crafts these mnemonics with a playful tone, steering clear of complex or offensive content. It transforms words from one language to English through puns, highlighting its role in creative language learning.

Instructions: translate the ${language} word "${word}" into English, provide a source to check, and then provide a list of 1-3 possible mnemonics that match the phonetic sounds of the entire ${language} word "${word}" as puns. Explain how the mnemonics help you remember the word by linking the pun to the English meaning. Don't use offensive words to make the puns. For example:

The French word "gare" means "railway station" in English. Check with this source: https://en.wiktionary.org/wiki/gare#French

Mnemonics:
1. "gare" sounds kind of like "Garfield", which you can visualize as Garfield grrring at the train.
2. "gare" sounds like "car", which you could remember how odd it'd be to see someone driving a car on the train tracks.

Give me 3 pun-based mnemonics to help me remember the ${language} word "${word}". Include a Wiktionary link to let me double-check the meaning and pronunciation. Do NOT use an acronym/acrostic in the mnemonic. Just use the sound and English meaning of the word in a visual mental image.`

I think the most important thing is to provide an example and explicitly tell it hwo to format links.


[rpi2] Ubuntu Mate installation failure

In https://github.com/130s/hut_10sqft/issues/327 I managed to install Ubuntu on RPi2 using Ubuntu Core, after having struggled with Ubuntu Mate. That doesn't mean I'll stick to Core - I'll be still testing it out for a few weeks or even months. That said it'd be nice if I can figure out why Mate failed.
Error I couldn't get rid of using Mate was reported around https://github.com/130s/hut_10sqft/issues/327#issuecomment-450779508

Core install https://github.com/130s/hut_10sqft/issues/332 went well with a branch new SD card. So maybe Mate might work fine with a new card.

Not much of interest any more due to success of #330


[JSDoc] @returns doesn't type check the return type of the function

// @ts-check
/**
 * @returns {string} This comment is not currently exposed
 */
function f() {
    return 5;  // this should be an error
}

Should also error for:
/** @type {function(number): string} */
const f = x => x + 1;


Release uni2ts on PyPI

Currently users have to install uni2ts from source, this makes it difficult to install in CI, currently I see a release tag on github i.e 1.1.0 releasing this version of PyPi, would help users to a great extent

Hi @pranavvp16,
Thanks for the suggestion! We will put this into our plan and hopefully do it soon.

I will second this, please help with. this. thanks

Hi @pranavvp16 @dany4142,
We have uploaded the package to PyPi. You can find it here https://pypi.org/project/uni2ts/1.1.0/. Please check it out :)

It does not work all, after installing it says no module uni2ts

Hi @dany4142, when did you try this? Could you try again now? Maybe clear the cache first, for example, pip cache remove uni2ts.  I thought a similar issue was resolved: https://github.com/SalesforceAIResearch/uni2ts/issues/117#issuecomment-2321814272
Feel free to let me know it still doesn't work.


1 nock scopes, global intercept problems

I noticed that in my tests using nock, if one test failed to fulfill an expectation, subsequent tests that set up the same expectation would fail, because the requests were being hijacked by a lingering intercept from the previous test. I wrote a test that demonstrates:
tap.test("scopes are independent", function(t) {
  var scope1 = nock('http://www.google.com')
    .get('/')
    .reply(200, "Hello World!");
  var scope2 = nock('http://www.google.com')
    .get('/')
    .reply(200, "Hello World!");

  var req = http.request({
      host: "www.google.com"
    , path: '/'
    , port: 80
  }, function(res) {
    res.on('end', function() {
      t.ok(scope1.isDone());
      t.ok(scope2.isDone()); // fails
      t.end();
    });
  });

  req.end();
});

What's your preferred way to fix this?

One intercepted request could fulfill expectations from multiple scopes (in other words, the above test would pass without modification).

nock.restore() could clear out whatever is hanging around to cause this. Test would change to something like this:

tap.test("scopes are independent", function(t) {
var scope1 = nock(/.../);
nock.restore();
var scope2 = nock(/.../);
var req = http.request({
//...
}, function(res) {
res.on('end', function() {
t.notOk(scope1.isDone());
t.ok(scope2.isDone());
t.end();
});
});
req.end();
});
* Similar to the previous option, but give the duty to a new method rather than `restore`.

I prefer the first option, clearly, thanks for asking :)
No dia 03/02/2012, às 21:22, Ian Young
<EMAIL_ADDRESS>escreveu:

I noticed that in my tests using nock, if one test failed to fulfill an expectation, subsequent tests that set up the same expectation would fail, because the requests were being hijacked by a lingering intercept from the previous test. I wrote a test that demonstrates:
tap.test("scopes are independent", function(t) {
 var scope1 = nock('http://www.google.com')
   .get('/')
   .reply(200, "Hello World!");
 var scope2 = nock('http://www.google.com')
   .get('/')
   .reply(200, "Hello World!");

 var req = http.request({
     host: "www.google.com"
   , path: '/'
   , port: 80
 }, function(res) {
   res.on('end', function() {
     t.ok(scope1.isDone());
     t.ok(scope2.isDone()); // fails
     t.end();
   });
 });

 req.end();
});

What's your preferred way to fix this?

One intercepted request could fulfill expectations from multiple scopes (in other words, the above test would pass without modification).

nock.restore() could clear out whatever is hanging around to cause this. Test would change to something like this:

tap.test("scopes are independent", function(t) {
var scope1 = nock(/.../);
nock.restore();
var scope2 = nock(/.../);
var req = http.request({
//...
}, function(res) {
res.on('end', function() {
t.notOk(scope1.isDone());
t.ok(scope2.isDone());
t.end();
});
});
req.end();
});
* Similar to the previous option, but give the duty to a new method rather than `restore`.

---
Reply to this email directly or view it on GitHub:
https://github.com/pgte/nock/issues/30

Sorry, backtracking here.
There is no way to make the scopes independent, since the app will be making direct calls to the HTTP module, not referencing a scope.
The interceptors are created globally, which means that what you are experiencing is the correct behavior.
There is no way to tell which scope will be caught first, depends on which request fires first.
When using nock I don't do my tests in parallel, which makes debugging stuff like this much easier.
I added some tests for this, which I think is correct behavior:
https://github.com/pgte/nock/commit/f8b73667d1cfe7239f87596ab55140d8c5eb9204

Is this current behavior the desired behavior or just the expected behavior? I haven't looked closely at the interceptor internals yet, but I imagine we could change it to what I described in the first option - just need to key by a reference to scope object or something.

So right now we're still left with cascading failures from one unsatisfied mock. If nothing else, I'd like to go for the second option, but I'm hoping to get your opinion on the above first.

Thinking again about this, a nice feature would be to globally clean up all mocks, thinking of
nock.cleanAll();
I'll be working on this.
Sorry for the delay :)

nock v0.10.1 now supports:
nock.cleanAll() that wipes the mocks that are setup.
please reopen this if it doesn't work for you.
Thanks!

Perfect! Added this to my test setup and it works great.


MX world calendar update for marketplace component

Hi @Luyao-Zhang-1 , please change the date for Machine learning toolkit back to Dec 2021, confirmed with Amir Piltan via Slack that the date in production is correct.


get vessels by vessel class

Added get_vessels_by_vessel_class function inside VesselsAPI Class in order to retrieve vessels based on their Vessel Class.
Optionally pointInTime.

Hello @LamprosArgy !! Very nice :) I have a comment on the code block 9 where the specified vessel type is Dry, whereas the name of the variable assigned is 'tanker_vessel_type'.


Update update-certificates.js

Hi,
I had truble verifying my italian greenpass with the third dose.
With a bit of tinkering I found the problem with the new certificates not getting downloaded.
NespoliBT

@NespoliBT I've really hoped your solution will work but I get 400 Bad Request (from greencheck.gv.at) when I try to send the request as per your example / PR

current version (as of today) seem to be 1.10

Seems like it needs to be updated everytime greencheck.gv.at changes the x-app-version.
I don't believe there is a clean way of getting around this other than having something like a for loop checking all the versions. That would be some r/programminghorror kind of stuff.


Add support for autofocus attribute

HTML5 introduces autofocus attribute for text,
textarea, select, and button elements:
https://developer.mozilla.org/en-US/docs/Web/Guide/HTML/Forms_in_HTML#The_autofocus_attribute
This implements a Trait with methods for (un)setting this attribute
and applies it to Text, TextArea, Select, and Button classes.

Do you want me to address 2 issues highlighted by Scrutnizer (assuming that you want this change at all)?
I originally considered defining the two abstract methods on the trait, but decided against it because that only introduces extra code duplication (if the {set/remove)Attribute signature changes, trait signature will have to change as well), and any errors resulting from the change to the two methods should be caught by the tests anyway.

Damn, didn't consider the possibility that you might still be supporting 5.3.
5.3 release has been in end-of life for almost a month now: http://php.net/supported-versions.php, should I bump the version requirement in composer.json?

That should've been an amended commit, I'll squash everything once we get passing tests.

Hey thanks for the PR! :)
Supporting 5.3 is pretty pointless at this point, I agree :/ Not terribly concerned about bumping it if we need to.
I am a bit torn though between the trait approach or just adding the methods to FormControl like required, enable, etc. I think overall that's simpler, but I'm guessing the reason you didn't do it is because autofocus is not supported for hidden inputs and Hidden here extends FormControl.
I don't think I'm too concerned about that from a "correctness" standpoint honestly, but if you totally disagree I'm happy to hear you out!

Actually after, re-reading the MDN article I realise that the 4 elements encapsulate a much larger number of element types (primarily through <input  type="$type" />), and hidden is the sole exception (I didn't think it was the case). So mimicking required/enable makes more sense.
That leaves the question of where to put the tests? It looks required() tests are executed only against Text and omitted  for Select, Button, and TextArea, should I do the same here?

Re: where to put the tests, that part's a bit messy at the moment you're right, heh. I think for now just slapping them in the Text test and treating that as "the place where we test things defined for everything" is good enough to prevent regressions. Worth figuring out a better way to organize that at some point though, definitely agree.

Let me know if you want me to move the tests to TestText until #40 is resolved.

Yeah I think that's a good enough plan for now :+1:

Thanks again for the PR!


Add support for Symbol prop type

Ports support for Symbol from React PropTypes.
Fixes up https://github.com/developit/proptypes/issues/2

LGTM!


Add invalid xml exception

Follow up of https://github.com/ros/pluginlib/pull/52 given that TinyXML2 returns null element on invalid XML files.
@ros/ros_team please review

closing in favor of #59 after noticing that no indigo package depends on tinyxml2 and that cmake_modules 0.3 doesn't provide a module for it


fix: Package Manager expanded status without needing client write-access to PeripheralDeviceCommands

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Bug fix

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Rewrites the special Package Manager interface as a functional component and removes the requirement for write access to the PeripheralDeviceCommands collection.

Other information:

Status

[ ] Code documentation for the relevant parts in the code have been added/updated by the PR author
[ ] The functionality has been tested by the PR author
[ ] The functionality has been tested by NRK

Codecov Report
Base: 67.14% // Head: 68.30% // Increases project coverage by +1.15% :tada:

Coverage data is based on head (2db2242) compared to base (d6a8465).
Patch coverage: 7.40% of modified lines in pull request are covered.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@                            Coverage Diff                             @@
##           fix/bug-on-package-manager-status-page     #859      +/-   ##
==========================================================================
+ Coverage                                   67.14%   68.30%   +1.15%
==========================================================================
  Files                                         254      279      +25
  Lines                                       28732    33775    +5043
  Branches                                     4011     4518     +507
==========================================================================
+ Hits                                        19293    23071    +3778
- Misses                                       8987    10247    +1260
- Partials                                      452      457       +5

Impacted Files
Coverage Δ

meteor/server/api/client.ts
51.61% <3.84%> (-7.77%)
:arrow_down:

meteor/lib/api/client.ts
100.00% <100.00%> (ø)

...ckages/server-core-integration/src/lib/watchDog.ts
84.04% <0.00%> (ø)

packages/server-core-integration/src/lib/queue.ts
100.00% <0.00%> (ø)

packages/corelib/src/lib.ts
48.97% <0.00%> (ø)

packages/blueprints-integration/src/util.ts
100.00% <0.00%> (ø)

packages/corelib/src/playout/timings.ts
76.47% <0.00%> (ø)

packages/corelib/src/hash.ts
36.00% <0.00%> (ø)

...es/server-core-integration/src/lib/ddpConnector.ts
94.76% <0.00%> (ø)

packages/corelib/src/playout/pieces.ts
87.78% <0.00%> (ø)

... and 17 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Parse correctly OGRE2_RESOURCE_PATH on Windows

🦟 Bug fix
Fixes wrong handling of OGRE2_RESOURCE_PATH on Windows.
Summary
It was assume that the OGRE2_RESOURCE_PATH was a :-delimiter list of paths. However, on Windows : is the separator between the drive letter and the path, so ; should be used instead.
Everything was working fine as C:\this\is\a\path and \this\is\a\path are both valid paths if the active drive is C:\, but as soon as the current active directory was for example on D:, OGRE2_RESOURCE_PATH was not read correctly, see https://github.com/conda-forge/gz-sim-feedstock/issues/57 .
Checklist

[x] Signed all commits for DCO
[ ] Added tests
[ ] Updated documentation (as needed)
[ ] Updated migration guide (as needed)
[ ] Consider updating Python bindings (if the library has them)
[ ] codecheck passed (See contributing)
[ ] All tests passed (See test coverage)
[ ] While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

looks good to me. Can you fix DCO?

looks good to me. Can you fix DCO?

Done!


wt doesn't work anymore

Windows Terminal version
1.13.1073
Windows build number
10.0.19044.1620
Other Software
No any special conflicting software is installed.
Outdated path C:\Program Files\WindowsApps\Microsoft.WindowsTerminalPreview_1.13.10336.0_x64__8wekyb3d8bbwe was found specified in Path environment variable, but the folder itself contains only font files CascadiaMono.ttf and CascadiaMonoItalic.ttf.
Steps to reproduce

Update to the latest Windows Terminal Preview v1.13.1073
Run terminal using wt anywhere

Expected Behavior
Open a new Terminal window or a new tab
Actual Behavior
Command prompt doesn't recognize wt at all.
Microsoft Windows [Version 10.0.19044.1620]
(c) Microsoft Corporation. All rights reserved.

C:\Users\User>wt
'wt' is not recognized as an internal or external command,
operable program or batch file.

C:\Users\User>

If you run it using either Run dialog or Search, terminal fails to start.

Your mouse pointer shows that the app is working in the background for a while. Also, a Windows Problem Reporting process appears in Task Manager for a moment.

Application error information from Windows Event Viewer:
Faulting application name: WindowsTerminal.exe, version: 1.13.2203.14003, time stamp: 0x622fbb2a
Faulting module name: ucrtbase.dll, version: 10.0.19041.789, time stamp: 0x2bd748bf
Exception code: 0xc0000409
Fault offset: 0x000000000007286e
Faulting process id: 0x13bc
Faulting application start time: 0x01d8411827544d62
Faulting application path: C:\Program Files\WindowsApps\Microsoft.WindowsTerminalPreview_1.13.10733.0_x64__8wekyb3d8bbwe\WindowsTerminal.exe
Faulting module path: C:\Windows\System32\ucrtbase.dll
Report Id: ede4bd23-847b-422d-9dc7-48933c3e073c
Faulting package full name:
Faulting package-relative application ID:

Fields Faulting process id, Faulting application start time, and Report Id are different in different log entries.

Does starting "Windows Terminal" from the Start Menu work? Like, is it just wt.exe specifically that doesn't work?
What does your %PATH% look like?

Yes, starting Windows Terminal from the Start Menu works. Even starting terminal profiles from PowerToys Run works.
Here's my %Path%
C:\Program Files\Common Files\Oracle\Java\javapath
C:\ProgramData\Oracle\Java\javapath
C:\Program Files (x86)\Common Files\Intel\Shared Libraries\redist\intel64\compiler
C:\Windows\system32
C:\Windows
C:\Windows\System32\Wbem
C:\Windows\System32\WindowsPowerShell\v1.0\
C:\Windows\System32\OpenSSH\
C:\Program Files\mingw-w64\x86_64-8.1.0-posix-seh-rt_v6-rev0\mingw64\bin
C:\Program Files (x86)\GnuWin32\bin
C:\Program Files\dotnet\
C:\Program Files (x86)\Avogadro\bin
C:\Program Files\Gource\cmd
C:\Program Files\NVIDIA Corporation\NVIDIA NvDLISR
C:\Program Files (x86)\NVIDIA Corporation\PhysX\Common
C:\Program Files\Git\cmd
C:\Program Files\Apache\maven-3.8.4\bin
C:\Program Files\VideoLAN\VLC
C:\Program Files\WindowsApps\Microsoft.WindowsTerminalPreview_1.13.10336.0_x64__8wekyb3d8bbwe
C:\Program Files\WindowsApps\Microsoft.DesktopAppInstaller_1.17.10271.0_x64__8wekyb3d8bbwe
C:\Program Files\PuTTY\
C:\Program Files\PowerShell\7\
C:\Users\User\AppData\Local\Programs\Python\Python310\Scripts\
C:\Users\User\AppData\Local\Programs\Python\Python310\
C:\Users\User\scoop\shims
C:\Users\User\AppData\Local\Programs\Microsoft VS Code\bin
C:\Users\User\AppData\Local\GitHubDesktop\bin

Did you add C:\Program Files\WindowsApps\Microsoft.WindowsTerminalPreview_1.13.10336.0_x64__8wekyb3d8bbwe to the PATH yourself? Pretty sure that's not supposed to be there. wt.exe is supposed to be accessed via C:\Users\migrie\AppData\Local\Microsoft\WindowsApps\wt.exe, which is an "app execution alias", which is a special type of shortcut that sets the OS up to actually start the one that's in C:\Program Files\WindowsApps\Microsoft.WindowsTerminal*__8wekyb3d8bbwe. If you launch the one in C:\Program Files\WindowsApps\Microsoft.WindowsTerminal*__8wekyb3d8bbwe directly, you're guaranteed to have a bad time 😄

Did you add C:\Program Files\WindowsApps\Microsoft.WindowsTerminalPreview_1.13.10336.0_x64__8wekyb3d8bbwe to the PATH yourself? Pretty sure that's not supposed to be there.

I'm sure I didn't modify the Path environment variable by myself and I don't know why an outdated path was specified there. I removed it manually and rebooted my PC. Nothing changed.

wt.exe is supposed to be accessed via C:\Users\migrie\AppData\Local\Microsoft\WindowsApps\wt.exe, which is an "app execution alias", which is a special type of shortcut that sets the OS up to actually start the one that's in C:\Program Files\WindowsApps\Microsoft.WindowsTerminal*__8wekyb3d8bbwe.

The app execution alias C:\Users\User\AppData\Local\Microsoft\WindowsApps\wt.exe is in its place. Many other aliases, like winget.exe and python.exe, work like expected.

Oh, you might need to add C:\Users\User\AppData\Local\Microsoft\WindowsApps back to your PATH. Though, I have no idea why winget and python would still work here.
Before you add WindowsApps back to the PATH, what's the output of

where winget
where python
where wt

Here's the output you asked for:
C:\Users\User>where winget
C:\Program Files\WindowsApps\Microsoft.DesktopAppInstaller_1.17.10271.0_x64__8wekyb3d8bbwe\winget.exe

C:\Users\User>where python
C:\Users\User\AppData\Local\Programs\Python\Python310\python.exe

C:\Users\User>where wt
INFO: Could not find files for the given pattern(s).

Ok, python and winget seem to add their root dirs to the Path variable manually. At the same time, they try to use app execution aliases too because appropriate files exist in the C:\Users\User\AppData\Local\Microsoft\WindowsApps folder.

When it comes to C:\Users\User\AppData\Local\Microsoft\WindowsApps that mysteriously disappeared during the last update, adding it to the Path variable solves the issue partially:

The alias works fine in any command-line environment (here are 3 new tabs created by 3 wt executions)

Other places, like Win+R dialog, Explorer path, and PowerToys Run, can't run terminal (nothing happens)

Does not work for me as well, same error information in Event Viewer ("Response: Not available").
Some findings:

any of

WinKey -> wt -> Enter
Ctrl + R -> wt -> Enter
wt in File Explorer address bar -> Enter
lead to "C:\Program Files\WindowsApps\Microsoft.WindowsTerminal_1.12.10982.0_x64__8wekyb3d8bbwe\wt.exe"

"C:\Program Files\WindowsApps\Microsoft.WindowsTerminal_1.12.10982.0_x64__8wekyb3d8bbwe\wt.exe" fails silently with error in Event Manager as indicated above
"C:\Program Files\WindowsApps\Microsoft.WindowsTerminal_1.12.10982.0_x64__8wekyb3d8bbwe\WindowsTerminal.exe" fails too
"%localappdata%\Microsoft\WindowsApps\wt.exe" works properly
"%localappdata%\Microsoft\WindowsApps\Microsoft.WindowsTerminal_8wekyb3d8bbwe\wt.exe" works properly too

How is it even possible that Windows links wt to an .exe in C:\Program Files... though it is NOT in PATH?
My User PATH:

My System PATH:

How is it even possible that Windows links wt to an .exe in C:\Program Files... though it is NOT in PATH?

ShellExecute can read the path from [HKEY_CURRENT_USER\SOFTWARE\Microsoft\Windows\CurrentVersion\App Paths\wt.exe] or from the same in HKEY_LOCAL_MACHINE. The store package installer apparently sets those. See Using the App Paths Subkey.

Good to know.

I believe this was fixed as part of #13193.
/dup #13193


Fix a problem that we can't change a page to portal in a specific condition

Overview
Fix a problem that we can't change a page to portal in a specific condition.
Reproduce

Create a page (/hoge)

Move this page to /hoge/

A page whose URL ends with a slash will be a portal

We can't change a page to portal

Cause
/hoge page become a redirect page when moved this page to /hoge/.
Page is exists as a redirect page, so we can't unportalize /hoge/.
Solution (Changes)

If existed page is a redirect page, we'll delete it.

By this, "Unportalize" will work normally.

In case of renaming, if new page's url ends with slash, the server don't create a redirect page.

Related issues
Close #283

Oops, sorry please fix the code commented by @hiroppy :)


Scoreboard invisible after death or world switch

What version of ViaVersion are you using? Type /ver viaversion
Version 0.9.8
What version of Spigot are you using? Type /ver
1.8.8
What plugins are you using? Type /plugins
Plugins (33): AsyncWorldEditInjector, WorldEdit, TuxTwoLib, Frame_Protector, SurvivalGames, FarmProtect, WorldGuard, Multiverse-Core, RogueParkour, AsyncWorldEdit, VoidGenerator, OpToggle, iConomy, PermissionsEx, NoteBlockAPI, ViaVersion, Multiverse-Portals, Vault, CubeRunner, MultiInv, Essentials, SkyWarsReloaded, Paintball, BattleArena, TNTRun, Quake, ProtocolLib, LibsDisguises, EpicSpleef, Citizens, EssentialsChat, EssentialsSpawn, UltraCosmetics
Are you using any additional software like BungeeCord? If so, what software and version? (Please list your plugins as well)
Normal
How does this error happen? login? Using an item?
Switching worlds
Is there an error in the console? Use pastebin.com. Is there a kick message?
No error messages!

Does this also happen on 1.8?

Yes

It's not a ViaVersion issue in that case. We do only modify 1.9 and higher on spigot 1.8.8.
Contact the author from the scoreboard plugin.

You are right, not a problem of viaversion, just removed from the server, same issue

No worries :)


Automate installation process for k3s / rke2 to validate flags passed during cluster creation

Build cluster and validate the results based on the flags passed.
Both K3s and RKE2

@ShylajaDevadiga any updates on this?

Closing as discussed internally during the testing design review.


Support favourites that need to be queued (like Apple Music)

Apparently, only some playlists (like Music Library) can be played directly from Sonos favourites, others (like Apple Music) cannot.  When trying to play such a playlist, the zone player responds with HTTP status 500 (internal server error) and UPnP status 714.  See https://github.com/ebaauw/homebridge-zp/issues/90#issuecomment-515712919.
When playing the favourite from the Sonos app, it first queues the playlist (after the current song of a playlist is already playing), seeks to the first track of the added playlist, and then issues play.  homebridge-zp should be doing the same, maybe clearing the running queue first.  Still unclear what types of playlists need to be queued and what not, but it looks like the Sonos app also queues my Music Library playlist.
eXtensible Markup Language
    <s:Envelope
        xmlns:s="http://schemas.xmlsoap.org/soap/envelope/"
        s:encodingStyle="http://schemas.xmlsoap.org/soap/encoding/">
        <s:Body>
            <u:AddURIToQueue
                xmlns:u="urn:schemas-upnp-org:service:AVTransport:1">
                <InstanceID>
                    0
                    </InstanceID>
                <EnqueuedURI>
                    x-file-cifs://server/Music/iTunes/iTunes%20Music%20Library.xml#BA1ED73E0486FB11
                    </EnqueuedURI>
                <EnqueuedURIMetaData>
                     [truncated]<DIDL-Lite xmlns:dc="http://purl.org/dc/elements/1.1/" xmlns:upnp="urn:schemas-upnp-org:metadata-1-0/upnp/" xmlns:r="urn:schemas-rinconnetworks-com:metadata-1-0/" xmlns="urn:schemas-upnp-or
                    </EnqueuedURIMetaData>
                <DesiredFirstTrackNumberEnqueued>
                    6
                    </DesiredFirstTrackNumberEnqueued>
                <EnqueueAsNext>
                    1
                    </EnqueueAsNext>
                </u:AddURIToQueue>
            </s:Body>
        </s:Envelope>

eXtensible Markup Language
    <s:Envelope
        xmlns:s="http://schemas.xmlsoap.org/soap/envelope/"
        s:encodingStyle="http://schemas.xmlsoap.org/soap/encoding/">
        <s:Body>
            <u:Seek
                xmlns:u="urn:schemas-upnp-org:service:AVTransport:1">
                <InstanceID>
                    0
                    </InstanceID>
                <Unit>
                    TRACK_NR
                    </Unit>
                <Target>
                    1
                    </Target>
                </u:Seek>
            </s:Body>
        </s:Envelope>

eXtensible Markup Language
    <s:Envelope
        xmlns:s="http://schemas.xmlsoap.org/soap/envelope/"
        s:encodingStyle="http://schemas.xmlsoap.org/soap/encoding/">
        <s:Body>
            <u:Play
                xmlns:u="urn:schemas-upnp-org:service:AVTransport:1">
                <InstanceID>
                    0
                    </InstanceID>
                <Speed>
                    1
                    </Speed>
                </u:Play>
            </s:Body>
        </s:Envelope>

When something else is playing (e.g. TuneIn radio), it sets the AVTransportURI after adding to the Queue, an before seeking:
eXtensible Markup Language
    <s:Envelope
        xmlns:s="http://schemas.xmlsoap.org/soap/envelope/"
        s:encodingStyle="http://schemas.xmlsoap.org/soap/encoding/">
        <s:Body>
            <u:SetAVTransportURI
                xmlns:u="urn:schemas-upnp-org:service:AVTransport:1">
                <InstanceID>
                    0
                    </InstanceID>
                <CurrentURI>
                    x-rincon-queue:RINCON_000E58A8171201400#0
                    </CurrentURI>
                <CurrentURIMetaData>
                    </CurrentURIMetaData>
                </u:SetAVTransportURI>
            </s:Body>
        </s:Envelope>

In v1.0.5


feat: add implementation of stateless slider

add implementation of stateless slider

@blackswanny should we fix the flow / lint errors before reviewing?

@gergelyke they are fixed in child branch as a part of implementation

In src/slider/styled-components.js:

backgroundColor: null,

position: 'relative',
top: '-10px',
left: offset + '%',
marginLeft: props.$index % 2 ? '-32px' : '-16px',
':before': {
  position: 'absolute',
  content: `"${Math.round(props.$value[props.$index])}"`,
  display: 'block',
  top: '-24px',
  marginLeft: '4px',
  width: '16px',
  height: '16px',
},

};
});

Hmmm i guess native doesn't have it. Suppose

@schnerd do you mean label?

@nadiia I checked new version and it seems to address these issues, except in Range mode we can overlap one thumb with another. I am to fix this as well

 const thumbWidth = 32;

Same question. Is this the width of a thumb that can be customized?
@nadiia . Yes, it's SVG icon and can be customized. However, it's not provided in any measurements I found for thumb( may be it is somewhere deep in DOM), so I don't have bulletproof way to avoid some deviation in coordinates

Maybe add some comments on this part of the code to help understand what's happening and what all these calculations are for?

added

Let's move this SVGs into a separate file, it will help keep the styled-components file cleaner

moved

const {thumbRefs} = this.state;
// only for one thumb feature
We will only need to decide which of the thumbs to move in the case a click is inside a current range. It's a good idea of moving the one that closer to the click in this case.
For the case, a click is outside of the current range there wouldn't be any confusion since the thumb in a range can't go past the second one. Also in a later case, the distance approach would still work the same.

Yes, outside seems clear case. However, inside is not yet. As a user of sliders I always have expectation of the one thumb to move that I stare at, and it's not always the closest to click.

Left a few minor comments to address. But the biggest concern here is the document event listeners we add for the whole lifecycle of a slider component. If there are a few sliders added on a page we'll end up with a lot of those listeners. The events I'm talking about are onMouseMove and onMouseUp.
We need to subscribe to those in the onMouseDown handler and unsubscribe from both the above mentioned in the 'onMouseUp' handler.

Renaming sounds like a great idea

renamed

The fix seems to be lost as the line remained unchanged, so we still don't set the initial value here.

The fix was made for other parts of code. We usually have something like below for this case. However, value has no default value and is a required field, so it always comes in initialState

Well, I would console.log the arguments the onChange handler gets instead of creating a custom case like in the screenshot you posted above.

I tested with console.log in my default handler, and still see no such result
I think in example above it already calls onChangeTst with wrong argument a,d it should be
onChangeTst({ event: {}, value: {} })

It looks like those two methods (scale, clampIt) can be extracted into helpers functions outside of this class. Otherwise, could you make sure to cover this case in tests? Specifically if keeping it here instead of extracting into helper functions.

yes, will be addressed in PR for unit-tests

Left a few minor comments to address. But the biggest concern here is the document event listeners we add for the whole lifecycle of a slider component. If there are a few sliders added on a page we'll end up with a lot of those listeners. The events I'm talking about are onMouseMove and onMouseUp.
We need to subscribe to those in the onMouseDown handler and unsubscribe from both the above mentioned in the 'onMouseUp' handler.

thanks. moved, it works as well.

Thanks for addressing all the comments!
One more question around the handlers
onThumbDown: () => {},
onMouseMove: () => {},
onThumbUp: () => {},

is there a use case for these to be exposed in the top-level API? Wonder if we should omit exposing those three.

removed from API

I added a comment based on the type on line 32, but your console.log clearifies that the args look fine. It looks like just the type of the config on line 32 is incorrect onChange = (config: {event: *, params: ParamsT}) => {. Should be onChange = (config: {event: *, value: some_value_type}) => {. Unless I'm missing something.

fixed