Tracker for breaking bugs in new webUI

@lstein, @psychedelicious, @Kyle0654, @netsvetaev (apologies if I missed anyone)
Describe your environment
These bugs should occur on any platform
Describe the bug

Reproducer:  python backend/server.py

Traceback (most recent call last):
  File "C:\Users\quaestor\Source\stable-diffusion-stable\backend\server.py", line 22, in <module>
    from ldm.dream.pngwriter import PngWriter, PromptFormatter
ImportError: cannot import name 'PromptFormatter' from 'ldm.dream.pngwriter' (c:\users\quaestor\source\stable-diffusion-stable\ldm\dream\pngwriter.py)

Reproducer: attempt to generate an image

Traceback (most recent call last):
  File "C:\Users\quaestor\Source\stable-diffusion-stable\backend\server.py", line 375, in generate_images
    model.prompt2image(
  File "c:\users\quaestor\source\stable-diffusion-stable\ldm\generate.py", line 344, in prompt2image
    results = generator.generate(
  File "c:\users\quaestor\source\stable-diffusion-stable\ldm\dream\generator\base.py", line 73, in generate
    image_callback(image, seed)
  File "C:\Users\quaestor\Source\stable-diffusion-stable\backend\server.py", line 364, in image_done
    path = save_image(image, all_parameters, result_path, postprocessing=postprocessing)
  File "C:\Users\quaestor\Source\stable-diffusion-stable\backend\server.py", line 310, in save_image
    path = pngwriter.save_image_and_prompt_to_png(image, command, filename)
TypeError: PngWriter.save_image_and_prompt_to_png() missing 1 required positional argument: 'name'

Additional context
This is a tracker for bugs relating to the recent web UI work. Obviously it is under heavy development, so this is not high-priority work.

I have a PR https://github.com/lstein/stable-diffusion/pull/602 that should replace server.py. Can you please test against that and see if it works? https://github.com/Kyle0654/lstein-stable-diffusion/tree/api-server
python server/application.py --host <IP_ADDRESS>

There are a small number of problems caused by my reworking of the metadata written to PNG files. Hopefully PR #602 will fix, but if not I'll be fixing the problems I created later this afternoon.

My PR will still write metadata to the Dream field right now. Can change that though if you'd like (just comment on the PR 🙂).

I think we should be reading and writing from the JSON-formatted "sd-metadata" field.
Sadly have to go pick up my kids at school now. Will be offline for an hour. Haste makes waste!

Haha I mean I have work all day so no rush =P

I have a PR #602 that should replace server.py. Can you please test against that and see if it works? https://github.com/Kyle0654/lstein-stable-diffusion/tree/api-server

I think there is some confusion, I named my server script server.py - same as the existing script - but its in a different directory backend/.
The bugs in this thread are for my server.py

Meanwhile I’ll fix the DREAM prompts. There was a “minor” user requested change which broke our parser.

Just to clarify. The old server launched with dream.py —web should still be working. If not, open a new issue.
My apologies to @psychedelicious and @Kyle0654 for messing up what should have been a smooth roll out.

I just merged in PR #602 , which fixes the immediate crashes. I see @psychedelicious has another PR, which I will check out.
I'm a bit under the gun because my HPC goes into an annual two-day "maintenance window" in about an hour, and I won't be able to do any more development or testing until Monday. This is part of the reason I was inexcusably hasty today!

I borked my original PR, whoops. Here is an un-borked one #624

Ok. Merged with development. Immediate problems solved I think.
Now I've got to try to reconstruct my environment on an alternative server that forbids conda. Sigh.

Yep immediate problems solved from my testing the up-to-date development branch. Cool!
Good luck @lstein - the python venv landscape is just about as intelligible as the modern javascript "ecosystem" - not very! I take it you are not so willing to take a couple days off while the maintenance proceeds?

I may have to! I was looking forward to doing more code cleanup and working on pipelining the postprocessing steps, but instead I'll have to spend time with my wife and kids.
I'm in venv/cmake/pip hell right now. It doesn't look good.

I noticed you restored the static files to the old version. Was the new stuff not working? I'll have no interface without those =(. Would it be alright if I replaced the old server with code to run the new backend? I don't know React at all, so having that simple interface to iterate on API features with has been super helpful.

Oh god. I didn't realize you were reusing the same static file directory that the old web server was using. Because the PR didn't disable the old server, and everything else from the flask/react server was self-contained, I assumed you were generating the static content elsewhere. Also @psychedelicious mentioned in one of the comments that he had inadvertently replaced the static files, so I thought this was OK.
Anyway, easy enough to revert!

There's a reference to config.js in index.html, but it's not in your PR #602. Is this intentional?

Ok, the static files have been reverted.

No worries, I'm working on cleaning up the entrypoints right now. I'm also trying to get the console app using the same components so we can reduce duplicated code as much as possible =).

I've zhuzhed up the frontend code in #638. This is a first pass general tidy, mainly of the components. The next task is to tidy the internal state management. I want to ensure that is coherent and sensible before migrating to the new API.

@lstein I got rid of the old server.py and started trying to migrate the console prompt to use the same backend. I'm having a lot of trouble with the arg parser though - it seems to be getting rid of outdir (at least). I'm tempted to just move the grid stuff into the services, since it's the only thing having trouble, but it would also really benefit from waiting until a processing pipeline is complete (which I wasn't up to building tonight).
Take a look and let me know if you have any ideas: https://github.com/lstein/stable-diffusion/pull/640

I've just commented in #266 regarding grids. I don't think image grids have any business being in the backend. If you want a grid of images, maybe the client can do that for you, maybe you just use an image editor. Suggest we move the burden of support for grids to the client.

not a bug, but I find myself continiously creating new lines in the prompt window when I want to start generating, because return/enter isn't mapped to launch "generate"

Pressing Upscale on an already generated image hangs and terminal output =
Traceback (most recent call last):   File "J:\miniconda\envs\ldm\lib\threading.py", line 980, in _bootstrap_inner     self.run()   File "J:\miniconda\envs\ldm\lib\threading.py", line 917, in run     self._target(*self._args, **self._kwargs)   File "J:\miniconda\envs\ldm\lib\site-packages\socketio\server.py", line 730, in _handle_event_internal     r = server._trigger_event(data[0], namespace, sid, *data[1:])   File "J:\miniconda\envs\ldm\lib\site-packages\socketio\server.py", line 755, in _trigger_event     return self.handlers[namespace][event](*args)   File "J:\miniconda\envs\ldm\lib\site-packages\flask_socketio\__init__.py", line 282, in _handler     return self._handle_event(handler, message, namespace, sid,   File "J:\miniconda\envs\ldm\lib\site-packages\flask_socketio\__init__.py", line 826, in _handle_event     ret = handler(*args)   File "J:\stable2\stable-diffusion\backend\server.py", line 178, in handle_run_esrgan_event     image = real_esrgan_upscale(   File "j:\stable2\stable-diffusion\ldm\gfpgan\gfpgan_tools.py", line 150, in real_esrgan_upscale     output, img_mode = upsampler.enhance( UnboundLocalError: local variable 'upsampler' referenced before assignment

@smoke2007 thanks, this will be changed so that Enter submits, but Shift+Enter still creates a new line.

Also not sure if it's just me and it may be after my latest pull, not sure. But the progress bar in the UI up top goes about twice as fast ad the progress bar in the terminal, so it's at 100% when the terminal is only at 60% or so and the image isn't finished yet, sothe interface waits till terminal catches up and than the image appears.

@psychedelicious looks like textual inversion is broken in the new WebUI, like the * token no longer works in the prompt? Tested on the development branch, running it like this:
python backend/server.py --web --host 0.0.0 --embedding_path file.pt

Hi @pbaylies , you are correct, this is not working at all, in fact the new UI server doesn't even accept any flags like you are giving it yet. Also, I didn't know this repo handles textual inversion, cool!
Can you provide an example textual inversion file for testing if there isn't one in the repo already that I have missed? Thanks.

@psychedelicious Sure, here's one of me (pt files are .zip but rename to .pt first I guess, don't unzip)
peter-pt.zip

@pbaylies Thanks.

I suppose the * token is defined in that file?
What should I expect to change in the generated images if I use it?
Does it make sense to have an area in the UI dedicated to uploading (i.e. copying a pt to a dedicated folder inside the cloned repo) and managing/selecting pt files?

Try the old web UI with a prompt like a photo of * and compare that against say a photo of man.
Tagging @lstein here for your other questions, I think it'd be nice to have some notation with different tokens supported / multiple embeddings, not sure if that is a thing or if there's a roadmap.

I think it'd be nice to have some notation with different tokens supported / multiple embeddings, not sure if that is a thing or if there's a roadmap.

You can combine embeddings with different tokens already: https://github.com/invoke-ai/InvokeAI/blob/main/docs/features/TEXTUAL_INVERSION.md (near the very bottom)
It'd be nice to have some UI to manage the embeddings though =)

@pbaylies I mean, as a user of the UI, would you like to have some UI elements to handle the embeddings used or, with the way you use texxtual inversion embeddings, does it make more sense to have it as a command line flag? I'm guessing it's nice to have in the UI.

@pbaylies I mean, as a user of the UI, would you like to have some UI elements to handle the embeddings used or, with the way you use texxtual inversion embeddings, does it make more sense to have it as a command line flag? I'm guessing it's nice to have in the UI.

Yes, it'd be nice, given that there's no UI for it. Not necessary but a nice to have feature.

I think it'd be nice to have some notation with different tokens supported / multiple embeddings, not sure if that is a thing or if there's a roadmap.

You can combine embeddings with different tokens already: https://github.com/invoke-ai/InvokeAI/blob/main/docs/features/TEXTUAL_INVERSION.md (near the very bottom)
It'd be nice to have some UI to manage the embeddings though =)

Yes, but can you use two different embeddings at once, in one prompt?

I'd like UI to manage the currently loaded model too ☺

@pbaylies #732 adds support for textual inversion generated embeddings, thanks for bringing that to my attention and providing the test file.

There may be a few unaddressed bits and pieces in here, but I am going to close this as resolved as we are far past this version of the web UI.


Enable use of Logger as a filter

The spec parsing and matching of env_logger is very useful, but it will only let you log to stdout/stderr. With this change you can embed env_logger's logic in your own logger.

ping @sfackler @alexcrichton @huonw

Refiled as https://github.com/sebasmagri/env_logger/pull/4

Re-opening this while there's still uncertainty about splitting off of env_logger

env_logger is all spun-out now and @jethrogb has implemented this over in https://github.com/sebasmagri/env_logger/pull/4.
Thanks again for getting this through @jethrogb!


Template Updates: Entertainment

Description
*Bolded changes from April 6, 2021: https://docs.google.com/spreadsheets/d/1MFtHj7Xwdol9jSk80PXrxWNz_0h1tSfyEe3K7Bn2yZs/edit#gid=0

Page
Animations
Cosmetics

1
Headline text changed to fly in. Remove animation on image. Music Note to fade in (3000ms)
rename music shape? (needs clarification)

2
headline and subheading text changed to fly in; remove animation on image.
N/A

3
Everything should Fly in
Remove one of the "pink" words in background, change position.

4
spotlight text updated to fly in; remove image animation. Headline to fly in
N/A

5
stars and ratings updated to fly in; remove image animation. Text and Button to fade in (3000ms)
N/A

6
remove image animation; Text to fly in
N/A

7
remove image animation ; Text to fly in
N/A

8
Headline to fly in; Images Fade in 3000ms; Text fly in
N/A

9
Headline and subheading updated to fly in; remove image animation; Grammys to Fade in (3000ms)
N/A

See Figma for specifications: https://www.figma.com/file/NHHMwIfxMnz39NxqkrFb7R/Stories-Post-Stable?node-id=7216%3A549493
If design requests have updated please make note in a comment here so that testing is aware of updated specs.
Acceptance

Template is updated
Relevant stickers are created
No more custom animations

@csossi - had design (@ivayloklissarov ) take a look for visual updates already - so you can focus on any regression/do your qa magic without worrying about figma!

Verified in QA

These were bug bashed by design so i feel like we can close them.


nuxt 3 integration

I followed integration of nuxt. But I wonder if it works for nuxt 3.
I added nuxt-windicss with yarn add nuxt-windicss -D.
I set the build module in nuxt.config.ts:
import { defineNuxtConfig } from 'nuxt3'

export default defineNuxtConfig({
  buildModules: [
    'nuxt-windicss',
  ],
})

I added some classes, but nothing happens :/

export default defineNuxtConfig({
  buildModules: [
    'nuxt-windicss',
  ],
  css: [
    'virtual:windi.css'
  ]
})

Woo, so fast!
I tried import 'virtual:windi.css' in app.vue and didn't work either.
Now it's good. Thanks a lot!

Should I update the doc?

https://github.com/windicss/nuxt-windicss-module#ordering-optional

Hi, the example in the playground with nuxt 3 doesn't work out of the box


Julia: confusion when Julia code is used in a non-standard string literal

The parser seems to get confused if you use Julia code inside a multi-line string literal with a non-standard prefix. I found this behaviour on GitHub, but it's the same in Jupyter Notebook 5.0.0. I've reduced it to:
doc"""
@rule grammar = "using PEG\n" & rule[*]
string = r"\"(\\.|[^\"])*\""
julia_function = # left as an exercise ;)
"""

function bla(x)
    no code here
end

The issue seems specifically have to do with strings inside the literal. It sometimes (in Jupyter and on the CodeMirror homepage) works correctly if the doc prefix at the beginning is removed.

@pabloferz or @malmaud, want to take a look at this?

Fix at #4684

Fixed via #4684


fix fee for craft profits

Fixes calculation of flea market fees when using average prices or custom prices.

.deploy

.deploy


[WIP] Fixed #873 clone with renamed or recreated branches leads to infinite loop

Trying to fix #873 clone with renamed or recreated branches leads to infinite loop
The new test fails with: System.ArgumentException : An item with the same key has already been added.
Any ideas?

Also, thank you for getting this PR started! I'm looking forward to having this bug fixed!

Okay, well, An item with the same key has already been added is because it's a second branch with the same path, but it's being put into a dictionary to look up a single branch by path. Oddly enough, this was exactly where my mind went when I saw git-tfs failing last night before I even found this PR.
Something fundamental will have to change.

Actually may not be a big deal. It's just the extension method GetRootTfsBranchForRemotePath.

The fundamental change that would be best is for git-tfs to stop trying to uniquely identify branches by path because they are not 1:1 and instead identify branches by path and some other disambiguating piece of information. @spraints What do you think?

This fixes @icnocop's test: https://github.com/icnocop/git-tfs/compare/master...jnm2:pr924
I want to build this now and see if it solves my problem too.

It does not fix my problem.
Tfs branches found:
- $/HeritagePMS/A
- $/HeritagePMS/B
=> Working on TFS branch : $/A
=> Working on TFS branch : $/B
=> Working on TFS branch : $/Trunk
        Fetching from dependent TFS remote B'...
=> Working on TFS branch : $/Trunk
        Fetching from dependent TFS remote B'...
=> Working on TFS branch : $/Trunk
        Fetching from dependent TFS remote B'...
=> Working on TFS branch : $/Trunk
        Fetching from dependent TFS remote B'...
=> Working on TFS branch : $/Trunk
        Fetching from dependent TFS remote B'...
=> Working on TFS branch : $/Trunk
        Fetching from dependent TFS remote B'...
[...endless]

I think I've identified the problem enough to write a test for it. I'll start my own PR.

The fundamental change that would be best is for git-tfs to stop trying to uniquely identify branches by path because they are not 1:1 and instead identify branches by path and some other disambiguating piece of information. @spraints What do you think?

I haven't dealt with the branch-related code too much, so take my answer with a grain of salt.
Unambiguous unique identifiers sound great. Will everything that needs to look up the branch know the disambiguating info? I'm open to using something that's not a Dictionary to hold the branch info. Like maybe an object that you can ask for a branch as of a version, and it can figure that out based on the create version of the branches.
Or, should git-tfs replace the old branch's entry? Replacing might be a good option since git-tfs generally walks history from oldest to newest. This isn't a good option if branches are handled outside of the history walk.

Thank you @spraints and @jnm2.
I'll close this for now and follow up if/when I have another chance to test.


About truncated normal distribution based weight initialization

https://github.com/rwightman/pytorch-image-models/blob/e4360e6125bb0bb4279785810c8eb33b40af3ebd/timm/models/vision_transformer.py#L392
https://github.com/rwightman/pytorch-image-models/blob/e4360e6125bb0bb4279785810c8eb33b40af3ebd/timm/models/layers/weight_init.py#L44-L62
Hi, @rwightman
Thanks for sharing your works!
I have a question.
Why do you trunc initialized weight values?
Do you use it for numerical stability?

@developer0hye moving to discussions, it was to attempt to match initialization for some networks implemented in JAX and Tensorflow (as that is a more common default layer init there)


Don't generate assets files when running install_and_run

This resolves an issue of assets being generated when watcher is running.
In our use case we saw assets files being generated whenever we span up the app in local from scratch. This is because the watcher runs Tailwind.install_and_run/2 that will not only install tailwind but also touch asset files if tailwind doesn't exist. This is a problem in umbrella apps, and any apps that deviates from the default phoenix css/js setup as discussed in #33.
I don't believe the intention is to write assets file if you don't explicitly use tailwind.install mix task so I've removed that step from Tailwind.install_and_run/2.

I kinda want to change naming to Tailwind.install_tailwind_and_run/2 instead or maybe call two separate functions in the tailwind install mix task. This PR was just to make the most minimal change to API.

Pushed a second commit that separates tailwind install and writing to files in assets. I think this is better, but wdyt @chrismccord? Any reason to also write to files when running the watcher?

I added it as --no-assets :)


Fix mask type of nusence dataset

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
I got a type error when I convert nuscenes dataset, the error is caused by the mask type
Modification
Please briefly describe what modification is made in this PR.
BC-breaking (Optional)
Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist

Pre-commit or other linting tools are used to fix the potential lint issues.
The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
If the modification has potential influence on downstream projects, this PR should be tested with downstream projects.
The documentation has been modified accordingly, like docstring or example tutorials.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.canqunxiang seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

thanks for your PR! Please sign the CLA first~


Support for @request.cookies when using database rules

Hello there. I was wondering if I could have access to the cookies when defining security rules. We already can use @request.headers, so the cookie header must be there as well. However, it is impractical to use it while defining rules, if not outright impossible.
I wanted to use a cookie in order to avoid creating anonymous users for a simultaneous game, without the need of deleting all of them at some point.
Perhaps I can use something like @request.headers.cookie.match(teamId), but it is arguably more ergonomic to have it as @request.cookies.team_id == teamId.
Anyways, given that a WebSocket does not carry the original handshake headers at every message, I wanted to know how the macro @request.headers is still populated when the @request.context == 'realtime'. Seems like magic. Here is what ChatGPT has to say about it.
PocketBase can remember the initial headers for every WebSocket connection through a process that involves storing the initial HTTP request headers when the WebSocket connection is first established. Here's a detailed look at how this is typically managed:

WebSocket Handshake
Initial HTTP Request:

When a client initiates a WebSocket connection, it sends an HTTP request to the server with headers that include details such as cookies, authentication tokens, and other relevant information.
This HTTP request is intercepted by the server before the WebSocket protocol upgrade is performed.
Storing Headers:

During this initial handshake, the server can capture and store the HTTP headers associated with the request.
These headers are stored in the server's session or connection context, which is associated with the WebSocket connection.
Upgrading to WebSocket:

After capturing the headers, the server responds with an HTTP 101 status code to switch protocols from HTTP to WebSocket.
The WebSocket connection is established, and the initial request context, including headers, is retained in the server’s memory for the duration of the connection.
Using Stored Headers in PocketBase
PocketBase likely employs similar mechanisms to remember and utilize these headers for realtime database rules evaluation:

Session Management:

PocketBase retains the initial connection context, including the headers, in a session or connection object.
This context is accessible whenever a message is sent via the WebSocket, allowing the server to reference the stored headers.
Realtime API Context:

When evaluating access rules for realtime updates (@request.context == "realtime"), PocketBase can access the stored headers through the request context.
This allows the use of @request.headers in database rules, ensuring that even in realtime scenarios, the initial headers can be referenced for permission checks.
Example in Practice
When a WebSocket connection is initiated:

The server captures and stores the initial HTTP headers.
Throughout the WebSocket session, these headers remain accessible via the request context.
PocketBase can then use these headers in rule evaluations to ensure that proper access control is maintained.
Conclusion
PocketBase retains the initial HTTP headers by storing them in the connection context during the WebSocket handshake. This stored information is then used to enforce database rules throughout the lifetime of the WebSocket connection, ensuring secure and consistent access control based on the initial request headers.

For more technical details, you can refer to the [PocketBase documentation on API rules and filters](https://pocketbase.io/docs/api-rules-and-filters/) and [API Realtime](https://pocketbase.io/docs/api-realtime/).

WDYT? And thanks in advance.

I'm sorry but I'm not going to read some random generated nonsense. Note that PocketBase uses Server-Sent Events (SSE), not WebSockets.

I wanted to use a cookie in order to avoid creating anonymous users for a simultaneous game, without the need of deleting all of them at some point.

I'm not sure I follow. For now there are no plans to add special handling for cookies as I don't exactly understand the use case and what the above expression is supposed to represent.
If you just want to send some user specific value to the server and check it via the API rules you can pass it as a plain header instead (for the realtime subscruptions we create a stub @request object based on the subscribed topic's options). For example:
pb.collection("example").subscribe("*", (e) => {
    ...
}, {
    // other options like expand, custom headers, etc.
    headers: {
        "X-Team-Id": "..."
    }
})

Then if you want to check it with the API rules you can do something like:
// all header keys are normalized to lowercase and "-" is replaced with "_"
@request.headers.x_team_id = "something"

If the above doesn't help, feel free to elaborate a little more on your use case and the desired behavior but please don't use llm.

@ganigeorgiev, although the snippets you wrote are useful, they are not what I had in mind. Consider this use case:

A registered user creates a team and become its admin.
The team id is a non-guessable token.
A QR code is generated using the team id, so others can join by reading it.
Option 1: each member of the rest of group can be signed in anonymously, which does require a user to be created in PB, only to be deleted later.
Option 2: when reading the QR code, the server verifies that the team ID exists and sets an HTTP-only cookie.

Option 2 does not require a user record to be created, and the user would be automatically "signed out" when the cookie expires.
Your suggestion for explicitly passing the header x-team-id is good, but would not work with an HTTP-only cookie, as its value could not be read by the client. So, in order to the headers, the client would probably need to store the team-id and use at each subscription, which is possible to do, but not simpler.

What I meant with this: @request.headers.cookie.match(teamId) is "check if the cookie header string matches the property teamId of the present record, whose security rules are being defined now".

Thanks for clarifying.
Even if we had support to target a single specific cookie value from the API rules you still will not be able to use it with the realtime subscriptions unless we also serialize that with the subscription topic, which I'm not sure if it would be a good idea because it will also require adding further options to control whether to include "credentials" or not in order to emulate similar settings as sending regular http request.
The described use case seems very app specific and too limited to me (you are essentially using the "team id" as API key and everyone acts on behalf that "team id" which may not be that useful because at some point you may need to separate the actions of each individual "anonymous" users so that they can later "upgrade" their account).
I may reconsider adding special cookie handling in the future it if there is users demand for it or a more prominent use case arise but for now this remains out of the scope for v1.


Add link to v2 project in activity feed

What does this PR do and why?
On homepage activity feed (latest payments:

fix v1 handles not rendering
add something for v2

Screenshots or screen recordings

Acceptance checklist

[x] I have evaluated the Approval Guidelines for this PR.
[x] I have tested this PR in all supported browsers.

Thanks @peripheralist back to u 🏓


feat(jest-runtime): share cacheFS between runtime and transformer

Summary

Pass cacheFS to ScriptTransformer constructor

In ScriptTransformer, pass cacheFS to create transformer function

Close #10898
Test plan

Added unit test for jest-transform

Node 14.x Windows, Node 12.x MacOS, Node LTS MacOS and facebook.jest failed but I have no idea what causes it.

macOS is flaky: #10828

Btw I could only modify test for jest-transform. For jest-runtime, I don't know which tests I can change to test the passing of cacheFS to ScriptTransformer.transform.

I wonder if we should pass it in the constructor rather than in the individual transform calls?

I tried with constructor. However, when passing through constructor, cacheFS isn't updated for each test run.

What do you mean "updated"?

What do you mean "updated"?

For example, a simple project:

When custom transformer is initialized, cacheFS has 100 elements

Test file foo.spec.ts is processed. After processing, cacheFS in custom transformer shows 200 elements.

Test filefoo.ts is processed. However, cacheFS at this time shows 100 elements, which is the initial amount.

hmm it seems like possible to pass through the constructor. I think I made mistakes somewhere previously

Hmm, I wonder if it makes more sense to pass as part of TransformOptions rather than forcing people to implement createTransformer?

Passing to getCacheKey transform options is also ok to me. Indeed if not implementing createTransformer, you won't get that cacheFS so it forces yes.
On the other hands, this cacheFS is partially related to transform options. It's related to transformer actually. Transform options to me is something directly related to how codes are transformed while this cacheFS is not directly related.

Right, but createTransformer is also a "public" API (in that user can be expected to run it themselves) at which point that transformer won't get cacheFs passed. See e.g. https://jestjs.io/docs/en/tutorial-react#custom-transformers

Hmm indeed, seem like we need to pass it as transform options then, unless others have other ideas

Passing into getCacheKey as the last arg brings more benefits over extending TransformOption:

Ensure that this arg is mandatory while passing via transform option requires cacheFS to be an optional property otherwise jest-repl will complain

Since it’s not directly related to how codes are transformed, passing as independent arg ensures that.

Users don’t have to be forced to implement create transformer function, as well as cover the case “public” API


White tab for active tab

Hi, I find the white background for the active tab to be quite distracting during coding.
Thank you for porting this theme.

Not sure if I can fix that since it's up to the UI theme to color the tabs. I agree, though, the white looks bad with the One Dark UI theme. You could always just fix it in your stylesheet (Atom Menu->Open your stylesheet).
This is what I did in mine:
.tab-bar .tab{
  border-radius: 0;
  border-image: none !important;
  border-left: 1px solid #222;
  &.active {
    &::after {
      border-top: 1px solid #555;
    }
  }
  &::before {
    display: none;
  }
  &::after {
    border-bottom: none;
    background: none !important;
    border-image: none;
  }
}

The only real important bit is the background: none !important; in the after section, everything else is just tweaking.


script: Test_plan optimization

These commits optimize test_plan.py script workflows by preventing it from leaving blind spots and scanning horizontally when a file within a folder called "common" without yaml is modified.

As requested, separated from https://github.com/zephyrproject-rtos/zephyr/pull/61838

@nashif can you take a look?

rebased


The testable example "ExamplePrivateHandle" is incorrectly passing

👋  Hello,
I am investigating the golang issue: https://github.com/golang/go/issues/48362, where testable examples are causing false positives when the output comment block is not the last comment block example.
I ran a parser against the top golang repos, including this repo and I found this bug with your ExamplePrivateHandle testable example.
If you combine the comment blocks to test as intended (see below) your test fails because the id is not 1234 like the output expects.
This is the code I suspect that you intended:
func ExamplePrivateHandle() {
	dns.PrivateHandle("APAIR", TypeAPAIR, NewAPAIR)
	defer dns.PrivateHandleRemove(TypeAPAIR)

	rr, err := dns.NewRR("miek.nl. APAIR (<IP_ADDRESS>    <IP_ADDRESS>)")
	if err != nil {
		log.Fatal("could not parse APAIR record: ", err)
	}
	fmt.Println(rr)

	m := new(dns.Msg)
	m.Id = 12345
	m.SetQuestion("miek.nl.", TypeAPAIR)
	m.Answer = append(m.Answer, rr)

	fmt.Println(m)

	// Output: miek.nl.	3600	IN	APAIR	<IP_ADDRESS> <IP_ADDRESS>
	// ;; opcode: QUERY, status: NOERROR, id: 12345
	// ;; flags: rd; QUERY: 1, ANSWER: 1, AUTHORITY: 0, ADDITIONAL: 0
	//
	// ;; QUESTION SECTION:
	// ;miek.nl.	IN	 APAIR
	//
	// ;; ANSWER SECTION:
	// miek.nl.	3600	IN	APAIR	<IP_ADDRESS> <IP_ADDRESS>
}

This fails with:
$ go test ./...
--- FAIL: ExamplePrivateHandle (0.00s)
got:
miek.nl.        3600    IN      APAIR   <IP_ADDRESS> <IP_ADDRESS>
;; opcode: QUERY, status: NOERROR, id: 49593
;; flags: rd; QUERY: 1, ANSWER: 1, AUTHORITY: 0, ADDITIONAL: 0

;; QUESTION SECTION:
;miek.nl.       IN       APAIR

;; ANSWER SECTION:
miek.nl.        3600    IN      APAIR   <IP_ADDRESS> <IP_ADDRESS>
want:
miek.nl.        3600    IN      APAIR   <IP_ADDRESS> <IP_ADDRESS>
;; opcode: QUERY, status: NOERROR, id: 12345
;; flags: rd; QUERY: 1, ANSWER: 1, AUTHORITY: 0, ADDITIONAL: 0

;; QUESTION SECTION:
;miek.nl.       IN       APAIR

;; ANSWER SECTION:
miek.nl.        3600    IN      APAIR   <IP_ADDRESS> <IP_ADDRESS>
FAIL
FAIL    github.com/miekg/dns    2.974s
ok      github.com/miekg/dns/dnsutil    (cached)
FAIL

This isn't simple "just move one comment" case. In this case the id changes every time you run this code. I'll let you handle this PR @tmthrgd 😄

You can provide a function that returns an ID that is static for this test.
On Thu, 18 Nov 2021, 22:09 Amelia Downs, @.***> wrote:

This isn't simple "just move one comment" case. In this case the id
changes every time you run this code. I'll let you handle this PR @tmthrgd
https://github.com/tmthrgd 😄
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/miekg/dns/issues/1299#issuecomment-973272854, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AACWIW45DIV4YLTXCJMO4ADUMVTPHANCNFSM5EPA5NIQ
.

Fixed via https://github.com/miekg/dns/pull/1354


Fix async invocation inside test module failed with java.lang.NoSuchMethodError

Purpose
Fixes https://github.com/ballerina-platform/ballerina-lang/issues/36131
Check List

[x] Read the Contributing Guide
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[x] Added necessary tests

[ ] Unit Tests
[ ] Spec Conformance Tests
[x] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

LGTM


Win 10, choco install python gets message: Access to the path 'C:\WINDOWS\system32**.exe.ignore' is denied.

While running choco install python in Windows 10, I got following message:
python3 v3.5.1
WARNING: The names of some imported commands from the module 'chocolateyInstaller' include unapproved verbs that might make them less discoverable. To find the commands with unapproved verbs, run the Import-Module command again with the Verbose parameter. For a list of approved verbs, type Get-Verb.
Downloading python3 64 bit
  from 'https://www.python.org/ftp/python/3.5.1/python-3.5.1-amd64.exe'
Progress: 100% - Saving 28.25 MB of 28.25 MB (29627072/29627072)
Download of python3Install.exe (28.25 MB) completed.
Installing python3...
python3 has been installed.
Access to the path 'C:\WINDOWS\system32\Boot\winload.exe.ignore' is denied.
Access to the path 'C:\WINDOWS\system32\Boot\winresume.exe.ignore' is denied.
Access to the path 'C:\WINDOWS\system32\DriverStore\FileRepository\64dp4256.inf_amd64_9191bdaf5e95d43e\difx64.exe.ignore' is denied.
Access to the path 'C:\WINDOWS\system32\DriverStore\FileRepository\64dp4256.inf_amd64_9191bdaf5e95d43e\DPTopologyApp.exe.ignore' is denied.
Access to the path 'C:\WINDOWS\system32\DriverStore\FileRepository\64dp4256.inf_amd64_9191bdaf5e95d43e\DPTopologyAppv2_0.exe.ignore' is denied.
Access to the path 'C:\WINDOWS\system32\DriverStore\FileRepository\64dp4256.inf_amd64_9191bdaf5e95d43e\GfxUIEx.exe.ignore' is denied.
Access to the path 'C:\WINDOWS\system32\DriverStore\FileRepository\64dp4256.inf_amd64_9191bdaf5e95d43e\Gfxv2_0.exe.ignore' is denied.
Access to the path 'C:\WINDOWS\system32\DriverStore\FileRepository\64dp4256.inf_amd64_9191bdaf5e95d43e\Gfxv4_0.exe.ignore' is denied.
Access to the path 'C:\WINDOWS\system32\DriverStore\FileRepository\64dp4256.inf_amd64_9191bdaf5e95d43e\igfxCUIService.exe.ignore' is denied.
Access to the path 'C:\WINDOWS\system32\DriverStore\FileRepository\64dp4256.inf_amd64_9191bdaf5e95d43e\igfxEM.exe.ignore' is denied.
Access to the path 'C:\WINDOWS\system32\DriverStore\FileRepository\64dp4256.inf_amd64_9191bdaf5e95d43e\igfxext.exe.ignore' is denied.
Access to the path 'C:\WINDOWS\system32\DriverStore\FileRepository\64dp4256.inf_amd64_9191bdaf5e95d43e\igfxHK.exe.ignore' is denied.

$destinationFolder is empty here, which causes it to spill out into pwd; however, I can't fathom why we need to .ignore every .exe to begin with.
If there's something somewhere that checks for the presence of a .ignore file for every executable, that seems fragile and broken.

If there's something somewhere that checks for the presence of a .ignore file for every executable, that seems fragile and broken.

Shim generation, a tool that puts executables on the PATH without cluttering the PATH automatically, inspects a package for executables. It also looks for shim director files such as .ignore files and .gui files to tell it to ignore. The process of doing this has been around for 5 years (pretty much all of Chocolatey's existence), which is no more fragile than finding the chocolateyInstall.ps1/chocolateyUninstall.ps1 file in the package to run.
What it seems to me is what is fragile is how this package goes about creating these ignore files (instead of just placing files in the package ahead of time like most others do). Especially since the package is having the issue (and creating ignore files is not required) and not Chocolatey itself.

Note that Chocolatey inspects package contents only, not the entire system. I'm not sure what was meant by your comment @DHowett (whole system or just local search).

@ferventcoder Sorry, my comment stemmed from a misunderstanding of what's going on. I didn't intend to cast aspersions over Chocolatey.

@DHowett I had to look up that word :D

I fixed this is in <IP_ADDRESS>61002 (which should be up for approval soon) - #303 has the ultimate fixes for this though.


GoPro 360 video projection type

Hi David,
Hope you are well!
I have a quick question that would appreciate for your help on.
We are working on GoPro 360 video integration and are trying to play GoPro .360 videos within our app. However we noticed that there are 3 projection types:
1 - GoPro lens
2 - Equirectangular
3 - Equal Area cube map
Can you please advise how to identify the projection type from the video metadata?
Many thanks!
Xiaoyue Huo

The GPMF blob with the header ('udta' atom) of .360 (MP4) file, has the tag PRJT (Projection).  Samples  values: GPRO – stock GoPro Lens,  ERP0 – ERP Projection, EAC0 – Stock EAC0 (currently not used in latest firmware) and EACO – EAC Overlap (used now.)

Hi David,
Thanks very much for your reply! Much appreciated.
We will look into it and come back if we have more questions.
I wish you have a lovely weekend!
Regards,
Xiaoyue Huo


Source maps for Angular and other libs

Is it possible to get source maps for Angular and other libs available for the browser? I tried to solve it by changing webpack.config.vendor.js, but it seems that I don't have a single idea of how does it work.

Looks like I got it:

Add "devtool" : "source-map" to the vendor webpack config.
Manually rebuild vendor package.

Glad you solved it!


Fixing tests

What does this PR do?
Fixes #918, some changes was not properly propagated
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃

@Borda wait for #938.
This PR makes many more changes than just fixing the tests. Please factor out into other PRs so we see the changes clearly.
This PR breaks a lot of GPU tests

@Borda the refactors are nice, so maybe this PR is about refactoring?

@Borda the refactors are nice, so maybe this PR is about refactoring?

sure, I wanted to do just a simple cleaning #934 but I found that it is crashing so I opened this to try to fix it... I see that it is still failing so WIP, and shall be done/merged after #938

@Borda unblocked. rebase so we can merge?

there was something wrong, your tests were passing just with caching luck...
I do not have a very good feeling about the prepare_data since the data is not available until you bind it with trainer... nasty fix in Template :robot:

@Borda the tests passed on GPUs without any caching...
The prepare_data is needed for TPU/DDP. It was causing a lot of issues without it.

the test is done that is using the same MNIS cache, once you download, it is used for all test...
you can simply check to run just tests.test_trainer.test_trainer_max_steps_and_epochs on the blank repo, but if run all test any other test like tests.test_trainer.test_resume_from_checkpoint_epoch_restored does the download as a first one...

prepare_data goes beyond tests... it's used for DDP and TPU.
If in the tests we happen to cache stuff that's great. But the overall framework needs prepare_data

prepare_data goes beyond tests... it's used for DDP and TPU.
If in the tests we happen to cache stuff that's great. But the overall framework needs prepare_data

it seems that we are talking a bit a diff thing...

shall we agree that tests shall pas always and does not matter what order
each test shall pass running on a blank system (except specific running conditions)

the case here was that tests.test_trainer.test_trainer_max_steps_and_epochs created model instance from a Template and then it asked for info about dataset before it was bouned to the trainer... then template method __dataloader  asked for MNIST dataset without which does not exist on clean environment because it is its fist usage (note that other test model sed our shorten TestingMNIST dataset which has another cache folder)

sure.


MT-BENCH Metric

This PR adds a new functionality to calculate a (proxy) for mt-bench metric based on https://github.com/lm-sys/FastChat/tree/main/fastchat/llm_judge directly in LLM Studio.
Workflow:

Choose mt-bench GPT template
Select gpt-4-0613 endpoint
use 1024 max output token length
Internally, the val dataset will then be replaced by 80 questions from mt-bench
We run typical generation on those
A re-implementation of mt-bench templates will be run, separately for 30 questions with reference and 50 without reference answer - slight adaptations to the templates are made to match our output format
Score will be shown, as well as scores by category in the logs

Some tests show good match between mt-bench and our implementation. For example for mistralai/Mistral-7B-Instruct-v0.2 I get 7.49 on mt-bench, and 7.44 in LLM Studio:
2023-12-21 09:33:15,910 - INFO: MT-Bench scores by category:
  category  score
    coding   5.80
extraction   5.10
humanities   9.75
      math   3.80
 reasoning   6.00
  roleplay   9.30
      stem   9.90
   writing   9.90
2023-12-21 09:33:15,911 - INFO: Validation GPT: 7.44375

Some differences vs. the original implementation:

mt-bench uses different temperatures per category: https://github.com/lm-sys/FastChat/blob/main/fastchat/llm_judge/common.py#L36
tiny template differences (also for sys prompt to openai)
mt-bench calculates both first and second turn, we only do first turn

Some potential considerations:

Do not automatically replace the val dataframe, but user needs to prep, but I like the simplicity of automatically providing it, so I would keep it like that for now.
Force the gpt endpoint for mt-bench, but might be also limiting and higher costs

We should also make clear in the UI and logs, that the result will differ from the original implementation of MT-bench to avoid confusion.

We should also make clear in the UI and logs, that the result will differ from the original implementation of MT-bench to avoid confusion.

Sure, but the whole metric has a random range by default, so not sure too many disclaimers are really needed.


Calling HttpClient methods should throw .Net Exception when fail

If there is an error with one of the HttpClient method, for example if the connection is lost, ModernHttpClient will bubble up the exception coming from the underlying API.
For example, on Android, it will bubble up the exception Java.Net.UnknownHostException if he cannot find the host.
This makes it very difficult to catch exceptions from .Net, for example if we're using the library in a Xamarin Forms project. It also means that HttpClient doesn't behave exactly like the "real" HttpClient.
Instead of bubbling up the library's exception, it should catch those exception and throw an HttpRequestException, like the real HttpClient.

Let me see how i can implement that. It makes sense.

Done. Wait for updated version.

Awesome, that was quick 😄!
Did you do the same thing for iOS?

iOS already do it.

Hi, I just checked, the change and I saw that you sent a root Exception, but that's not really better than the previous option with bubbling the java exception. It would be much better if you were throwing a HttpRequestException.
Ideally, you should also put the Java exception you got in the InnerException.

Ok. Will do that when i get back. Will be out for a few days off the grid :)


OpenLDAP looks like it connects even when all info is wrong

Rancher versions: 2.0 master 7/2
Steps to Reproduce:

Put in all bad info in the openLDAP screen
Authenticate with OpenLDAP

Results:  Looks like I logged in successfully.  But I really did not.

Rancher server logs has the following error that shows up:
2018/07/02 19:23:19 [ERROR] Unknown error: Error creating connection: LDAP Result Code 200 "": dial tcp <IP_ADDRESS>:389: i/o timeout
If you are still in the openldap provisioning page , we see the following error:
Error creating connection: LDAP Result Code 200 "": dial tcp <IP_ADDRESS>:389: i/o timeout```

UI screenshot for this bug

I too am able to see that the auth failed with bad info but I think I might know what Tani is seeing. The ui briefly flashes, if there was a JS error the ui would probably stay on the "authorized" ui and not fall back to the "input" ui. I'll take this and fix the ui so it doesn't flash and won't get stuck.

@carolynhu - was able to show Wes what I was seeing and that there is no error showing for me.  You have to put in a IP address that is the proper format (like <IP_ADDRESS>) but invalid.  If you do that and fill in the rest of the info properly, it will success.  which it shouldn't

the ui has been updated to prevent showing the enabled ui while the call is pending

Tested with Rancher server version - v2.0.5-rc3
Steps to Reproduce:
Put in all bad info in the openLDAP screen - (Hostname or IP Address - <IP_ADDRESS>)
Authenticate with OpenLDAP
After about ~1 minute , user is presented with the following error message:

I am having same issue now, why it is closed?

@lq13583 - This issue is closed because this particular bug was fixed.  I have replicated the steps from this issue in our current version and cannot reproduce the bug.
Can you please open a new issue with your particular steps to reproduce, there must be something else that is going.  Mainly which field in the ldap screen is incorrect?


Not working for nodejs 14

I've tried running this project with nodejs 14 and it does not work.

Probably a typeorm issue https://github.com/typeorm/typeorm/issues/5949


feat: better styling for thumb/track radius

Fixes Issue
**My PR closes #467
👨💻 Changes proposed(What did you do ?)

first of all, I changed the styles of the checkbox as per the new design.
Added + and - buttons beside the input element
styled them so they look good.
Implemented function to the + and - buttons so they can add or subtract the values of input elements.
for the function implementation I made changes in the input-range.ts and getElement.ts files

✔ Check List (Check all the applicable boxes)

[x] My code follows the code style of this project.
[x] This PR does not contain plagiarized content.
[x] The title and description of the PR is clear and explains the approach.

Note to reviewers

📷 Screenshots

you forgot the space between i talked about

Doesn't look good on mobile

still the same, use flex to properly style -> in case you don't know how to use it https://css-tricks.com/snippets/css/a-guide-to-flexbox/
use the space between to give a space between them, don't gap for situations like this

it should look like this:

:tada: This PR is included in version 2.71.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


update get_models.sh for ov2022.1

update get_models.sh for ov2022.1

update README.md
a) install mo/omz_downloader in order to download models
b) remove container/README.txt

LGTM

looks good to me


!weather [term] forecast  and !weather returning incorrect results

Seems that the weather function is not getting correct results. It also does not work when you specify a state.
!weather  Herndon VA forecast
!weather 20170 forecast

*Today 10:00 AM:* 71.64°F - Light Rain
*Today 1:00 PM:* 80.02°F - Clear Sky
*Today 4:00 PM:* 83.57°F - Clear Sky
*Today 7:00 PM:* 79.65°F - Clear Sky
*Today 10:00 PM:* 73.69°F - Clear Sky
*Tomorrow 1:00 AM:* 69.16°F - Clear Sky
*Tomorrow 4:00 AM:* 65.18°F - Clear Sky
*Tomorrow 7:00 AM:* 60.53°F - Clear Sky
*Tomorrow 10:00 AM:* 69.11°F - Clear Sky
*Tomorrow 1:00 PM:* 80.48°F - Clear Sky
*Tomorrow 4:00 PM:* 72.99°F - Clear Sky
*Tomorrow 7:00 PM:* 65.7°F - Clear Sky
*Tomorrow 10:00 PM:* 59.78°F - Clear Sky
*Sunday, November 19th 1:00 AM:* 53.31°F - Clear Sky
*Sunday, November 19th 4:00 AM:* 49.14°F - Clear Sky
*Sunday, November 19th 7:00 AM:* 45.79°F - Clear Sky

!weather 20170
*It is currently* `41.25°F` in herndon va. *Today's Weather:* `Clear Sky` *High:* `44.6°F` *Low:* `37.4°F`

We were not stripping "forecast" out of the information we passed to the Google GeoCode API. This seemed to throw off the Google API.


Cannot debug the CodeSwing extension itself

I'm trying to build the extension locally to run some debugging (and see if I can contribute with fixes to the issues I've raised, plus a few more), but I can't get that to work.
First, I clone the repo then launch that in VS Code, then install deps with npm install.
npm run watch then fails with these errors:
[6:17:39 PM] Starting compilation in watch mode...

node_modules/svelte/types/compiler/index.d.ts:4:22 - error TS2307: Cannot find module 'estree-walker' or its corresponding type declarations.

4 export { walk } from 'estree-walker';
                       ~~~~~~~~~~~~~~~

node_modules/svelte/types/compiler/interfaces.d.ts:2:27 - error TS2307: Cannot find module 'magic-string' or its corresponding type declarations.

2 import { SourceMap } from 'magic-string';
                            ~~~~~~~~~~~~~~

node_modules/svelte/types/compiler/preprocess/types.d.ts:1:26 - error TS2307: Cannot find module 'locate-character' or its corresponding type declarations.

1 import { Location } from 'locate-character';

Looks like the issue is that estree-walker, magic-string and locate-character are dependencies of svelte but are marked as devDependency in svelte's package.json, so they're not installed. At least in the latest version of NPM that I'm using, there doesn't seem a way (anymore) to install devDependencies of dependencies.
So a first fix was to add this to CodeSwing's devDependencies (using the same versions of deps that are listed for Svelte):
    "estree-walker": "^1.0.0",
    "locate-character": "^2.0.5",
    "magic-string": "^0.25.3",

Then with npm install I can finally build the extension..
However, it's not done yet. Now npm run watch works, but the extension still isn't loaded in VS Code.
This is what happens in VS Code's debug console:
rejected promise not handled within 1 second: Error: Cannot find module '/Users/alessandro/Desktop/Code/codeswing/dist/extension.js'
Require stack:
- /Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/loader.js
- /Applications/Visual Studio Code.app/Contents/Resources/app/out/bootstrap-amd.js
- /Applications/Visual Studio Code.app/Contents/Resources/app/out/bootstrap-fork.js
stack trace: Error: Cannot find module '/Users/alessandro/Desktop/Code/codeswing/dist/extension.js'
Require stack:
- /Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/loader.js
- /Applications/Visual Studio Code.app/Contents/Resources/app/out/bootstrap-amd.js
- /Applications/Visual Studio Code.app/Contents/Resources/app/out/bootstrap-fork.js
    at Function._resolveFilename (internal/modules/cjs/loader.js:934:15)
    at internal/modules/cjs/loader.js:779:27
    at Function.<anonymous> (electron/js2c/asar_bundle.js:5:12913)
    at Function.<anonymous> (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:114:32222)
    at Function.<anonymous> (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:114:28887)
    at Function._load (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:104:61699)
    at Module.require (internal/modules/cjs/loader.js:1006:19)
    at require (internal/modules/cjs/helpers.js:88:18)
    at Function.r [as __$__nodeRequire] (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/loader.js:5:101)
    at v._loadCommonJSModule (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:114:30297)
    at v._doActivateExtension (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:100:12958)
    at v._activateExtension (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:100:11931)
    at processTicksAndRejections (internal/process/task_queues.js:93:5)
    at async Promise.all (index 0)
    at Object.registerCodeSwingModule (/Users/alessandro/.vscode/extensions/vsls-contrib.gistfs-0.3.0/dist/extension.js:51:275762)

I'm not sure how to fix this :(

For the second issue, it seems that the extension is being loaded from the dist folder, but tsc is configured to output the extension to out.


fix: exportRecordsFlow category

Changes proposed in this PR:

fix ExportRecordsFlow category

[ ] I have followed (at least) the PR section of the contributing guide.
@90milesbridge/tigger

Pull Request Test Coverage Report for Build 4129

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 80.403%

Totals

Change from base Build 4106:
0.0%

Covered Lines:
2910

Relevant Lines:
3505

💛  - Coveralls


use travis-ci container-based infrastructure

Allows for faster builds. See docs for details.

No longer needed:

For repos we recognize on or after 2015-01-01, linux builds are sent to our container-based infrastructure.


[Question] PKCE flow

Hi! This library looks great but does it only allow for implicit flow? Is there a way to make this work with a PKCE code flow? Thanks!

Hello @danrday,
Just change the response_type to code from your UserManagerSettings.

@danrday did @FuturistiCoder answer your question?

@maxmantz I ended up using AppAuth-Js for PKCE flow even though its documentation was very confusing and hard to implement. Thank you @FuturistiCoder  for your suggestion. :)


Laravel Auto-Discovery

I guess it could be useful.
👋

Thanks!  Once I fix that other issue that's causing the build to fail, I'll merge this in.


WIP: [V2] CFE-971: Generate OSUS graph image - uses go-containerregistry implementation

Description
When the user specifies graph: true in the imageSetConfig (mirror.platform.graph), oc-mirror generates a graph-image (following directives from this doc and pushes it to the specified disk or mirror.
This PR ensure retrocompatibility of this feature in v2.
Fixes CFE-971
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
With the following imageSetConfig:
kind: ImageSetConfiguration
apiVersion: mirror.openshift.io/v1alpha2
mirror:
 platform:
   channels:
   - name: stable-4.13
     minVersion: 4.13.10
     maxVersion: 4.13.10
   graph: true

We can run oc-mirror for MirrorToDisk first: This will create a graph-image and save it to local storage
$ ./bin/oc-mirror --v2 -c cfe-969.yml -p 6000 file:///home/skhoury/release
...
2023/10/25 10:56:51  [INFO]   : mode mirrorToDisk
2023/10/25 10:56:51  [INFO]   : local storage registry will log to /home/skhoury/go/src/github.com/openshift/oc-mirror/logs/registry.log
2023/10/25 10:56:51  [INFO]   : starting local storage on :6000
d
...
2023/10/25 10:56:52  [INFO]   : creating graph data image
2023/10/25 10:56:52  [INFO]   : graph image localhost:6000/graph-image@sha256:41f0b09707f893900679adc712e78f7f73d7d8b245bf68c921726b43743373e0 created and pushed to cache.
2023/10/25 10:56:52  [INFO]   : total release images to copy 184
...

Next, we can perform a DiskToMirror, which would push the graph-image, along with release images, to the mirror
$ ./bin/oc-mirror --v2 -c cfe-969.yml -p 6000 --from file:///home/skhoury/release docker://localhost:5000/cfe971 --dest-tls-verify=false

Expected Outcome
After mirroring is complete, we need to check the graph-image:

The contents of /var/lib/cincinnati-graph-data need to belong to root.
The CMD of the image needs to be compliant with the documentation

This can be achieved like this for example:
╭─╼skhoury@fedora ~/.../openshift/oc-mirror
╰─ (CFE-971)-$ podman pull localhost:5000/cfe971/openshift/graph-image:latest
Trying to pull localhost:5000/cfe971/openshift/graph-image:latest...
Getting image source signatures
Copying blob 3c5f5168e8c4 done   |
Copying blob cc7c08d56aad skipped: already exists
Copying config fd8881a489 done   |
Writing manifest to image destination
fd8881a489058a887b1f82311762f1289f1434b67f83463ec78f596cbb9dd966
╭─╼skhoury@fedora ~/.../openshift/oc-mirror
╰─ (CFE-971)-$ podman run -it "localhost:5000/cfe971/openshift/graph-image:latest" /bin/bash
[root@96b2ab6ddc60 /]# ls -l /var/lib/cincinnati-graph-data/
total 16
-rw-rw-r--. 1 root root 11357 Oct 25 07:26 LICENSE
drwxr-xr-x. 1 root root 31668 Oct 25 07:48 blocked-edges
drwxr-xr-x. 1 root root  1410 Oct 25 07:48 channels
drwxr-xr-x. 1 root root    26 Oct 25 07:48 raw
-rw-rw-r--. 1 root root     6 Oct 25 07:26 version
[root@96b2ab6ddc60 /]# exit
exit
╭─╼skhoury@fedora ~/.../openshift/oc-mirror
╰─ (CFE-971)-$ podman inspect "localhost:5000/cfe971/openshift/graph-image:latest" | jq .[0].Config.Cmd
[
  "/bin/bash",
  "-c",
  "exec cp -rp /var/lib/cincinnati-graph-data/* /var/lib/cincinnati/graph-data"
]

@sherine-k , much cleaner than the buildah code, great work and quick turn around.
Looks good to me.
I'll wait for @aguidirh - review and then we can add the relevant labels

Hi @lmzuccarelli @aguidirh
PR is now ready for a second round of reviews.
A test to cover graph generation, mocking imageBuilder is added, although not very relevant. It will be the same for imageBuilder: I'm not sure mocking will really get us a good signal from unit tests here.
I guess the next step would be starting the work on CFE-901
Disclaimer: From looking at go-containerregistry code and issues (1364 and 1200 , it doesn't look like registries.conf is supported by this module. So this might be a problem for the epic on Enclave Support.
For what it's worth, this test seems to contradict the above disclaimer. so can you verify?
Test:

I keep my network on (otherwise I will fail while querying cincinnati api)
I modify constants.go to say that the image to build graph-image from is registry.access.redhat.com/ubi9/ubifake:latest :arrow_right: fake, doesn't exist
I update my ~/.config/containers/registries.conf with this:

[[registry]]
location="localhost:5000"
insecure=true
[[registry]]
location="registry.redhat.io"
[[registry]]
location="registry.access.redhat.com/ubi9/ubifake"
[[registry.mirror]]
location="localhost:5000/cfe971/openshift/graph-image"
insecure=true

I run a mirror to disk, which seems to pass.

Hi @lmzuccarelli @aguidirh PR is now ready for a second round of reviews. A test to cover graph generation, mocking imageBuilder is added, although not very relevant. It will be the same for imageBuilder: I'm not sure mocking will really get us a good signal from unit tests here. I guess the next step would be starting the work on CFE-901
Disclaimer: From looking at go-containerregistry code and issues (1364 and 1200), it doesn't look like registries.conf is supported by this module. So this might be a problem for the epic on Enclave Support.
Test:

I keep my network on (otherwise I will fail while querying cincinnati api)
I modify constants.go to say that the image to build graph-image from is registry.access.redhat.com/ubi9/ubifake:latest ➡ fake, doesn't exist
I update my ~/.config/containers/registries.conf with this:

[[registry]]
location="localhost:5000"
insecure=true
[[registry]]
location="registry.redhat.io"
[[registry]]
location="registry.access.redhat.com/ubi9/ubifake"
[[registry.mirror]]
location="localhost:5000/cfe971/openshift/graph-image"
insecure=true

I run a mirror to disk, and the result is failing
2023/10/31 09:47:21  [INFO]   : creating graph data image
2023/10/31 10:15:12  [ERROR]  : GET https://registry.access.redhat.com/v2/ubi9/ubifake/manifests/latest: NAME_UNKNOWN: Repo not found

@sherine-k since the registries.conf is not part of CFE-971 it is ok to merge this PR without it. The registries.conf can be implemented later.

@sherine-k since the registries.conf is not part of CFE-971 it is ok to merge this PR without it. The registries.conf can be implemented later.

/lgtm


[Keyboard Manager] want some key mapping like macos - home key as modifier

In macos, the key "cmd + backspace" can delete the whole line, so I want to map "Win + backspace" to "shift + home + backspace", but failed.
I think maybe the this feature is not supported.
It will be helpful if this feature is supported, thank you

This is interesting, the home key currently can't be used as a modifier which is likely why this feature isn't supported. We'll update the labeling and log this in our enhancements milestone for us to review following our general stability efforts. Thanks!

Tracked via https://github.com/microsoft/PowerToys/issues/3350


0.4.0

Version 0.4.0
New Features

CLI

New Particles
Azure

azure resource
blob storage

Improvements

logging in quasiparticle
concept section in documentation
Added style guide

can we merge the name refactoring branch first? there are a few errors in the docs

Should we merge in the CI before the release?


CatchBoundary only works when the page also exports a component

What version of Remix are you using?
1.14.3
Are all your remix dependencies & dev-dependencies using the same version?

[X] Yes

Steps to Reproduce

Create a global CatchBoundary in root.tsx
Create an _index/index.ts for a sub-route that only exports a loader but not a component
throw in the loader

Expected Behavior
The root CatchBoundary renders with the respective error
Actual Behavior
I see the error as plain text JSON. No CatchBoundary is triggered. As soon as the route exports a component, the CatchBoundary shows up.
Why do you not export a component?
The index isn't used for layouting and doesn't provide any value on its own. Inside the loader, we determine to which more specific route we should redirect the user.

if you're not exporting a component, then it's considered a "resource route" and CatchBoundary nor ErrorBoundary will render as you could be sending anything in the response not just html

As Logan said this is considered a resource route if no UI is exported.  If you're intending to redirect then you shouldn't ever want to see the root CatchBoundary and instead land on a UI-route after the redirect.
This works for me in an _index.tsx file:
import { redirect } from "@remix-run/node";

export function loader() {
  throw redirect("/test");
}

If you sometimes want something to render at / and need to throw up to the root catch boundary, then you will need to add a default component export to turn it into a UI route.
import { redirect } from "@remix-run/node";

export function loader() {
  if (condition) {
    throw redirect("/test");
  }
  throw new Response(null, { status: 404 });
}

// This tells Remix that we intend to render some form of UI at this route path,
// even though we know it'll always be the root catch boundary since we only
// ever throw from our loader
export default function component() {
  return null;
}


Dates aren't showing up correctly for captured videos.

Hello Sachin,
Please refer to the attached pictorial description.
File-naming mechanism within Captura isn't working ok for the captured videos.
Its saving videos in format ::: yyyy-mm-d  instead of yyyy-mm-dd.
The last entry for instance in the following description is only showing up - 2 , whereas it were captured on 24th in real.
Please provide further inputs in this regard?
Thank you.

The file names seem to be correct in your image. Please note that 4 of 24 is wrapped on the next line.
You can change the windows file explorer view to list to view the name on a single line.

Hi Sachin !
Do you mean to say that's a BUG with Win 10 perhaps as the lines are getting overlapped for 'large icons' view ??
Should I take up this one with Win 10 support Team then ?
Thanks.

It's not a bug. It is the expected behaviour to wrap long text.

@saurabhdua82 i also get these problems in whindows too, i will report thess problems to whindows ceo. this is very very serious problems as it is bery bad.


Update motivation

cc @ljharb

I hope this new motivation (other than "save 9 characters") can help to optimize the mental model of using async functions.

Now it just saves 2, though, and it’s not syntax.

Now it just saves 2, though, and it’s not syntax.

I removed that "new global" part


Improvements to Analytics

Track page performance: Increases the sampling data of page load speed to 100% of users
Track searches: Creates a URL parameter when searching - this also allows users to share their searches with friends :)

[ ] Track crashes and exceptions

This change is

Thinking a little bit, maybe we could change the tracking code to be passed via some kind of configuration on the future.

Thinking a little bit, maybe we could change the tracking code to be passed via some kind of configuration on the future.

We should! Maybe I'll add it to this PR.

Could we add the new variables to the README.md at https://github.com/ayr-ton/kamu#deployment? <3

@ayr-ton do you mean those? https://github.com/ayr-ton/kamu/pull/93/files#diff-04c6e90faac2675aa89e2176d2eec7d8R132


Add clarification for using ui-shell

UI Shell requires $feature-flags: (ui-shell: true); set in style.scss or equivalent in order to show up with styles correctly.
Without it, users get only a list of links.
Documentation description should say that and provide a code snippet that users can copy into their code.

So how to use UI-Shell in angular


Need clarification on Agent Pool Maintenance Setting Days

What happens in Agent Pool Settings -> Maintenance if I don't check any days (which is the default)? Does that cause the maintenance to run every day, or no days?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4409a9cb-8448-edd6-da0a-243e5601aa3e
Version Independent ID: ec15f71a-a76d-c3f9-1d31-832f92183ef4
Content: Agents pools - Azure Pipelines
Content Source: docs/pipelines/agents/pools-queues.md
Product: devops
GitHub Login: @andyjlewis
Microsoft Alias: alewis

Fixing


Wildcard VersionReq alongside other requirements

I honestly don't know if this is correct behavior or not, but it seems like it should be accepted:
semver::VersionReq::parse("*, 0.20.0-any").unwrap();

gives
Error("unexpected character after wildcard in version req")

The intent of the version requirement specifier is to match any released version and any pre-release version of 0.20.0 since pre-releases aren't matched by *.
Reversing the order gives a different error which makes it seem like * is only permitted when used alone:
semver::VersionReq::parse("0.20.0-any, *").unwrap();

gives
Error("unexpected character '*' while parsing major version number")

You should go to the Cargo team about syntax changes. This is intentionally not accepted right now. A Cargo RFC may be required.

The intent of the version requirement specifier is to match any released version and any pre-release version of 0.20.0 since pre-releases aren't matched by *.

Note that this is not what comma means. Comma roughly represents intersection, not union. That is why e.g. >=2, <4 does not match every major version. It would not be my expectation that *, 0.20.0-any has a meaning that is different from ^0.20.0-any.

You should go to the Cargo team about syntax changes. This is intentionally not accepted right now. A Cargo RFC may be required.

Fair enough. I wonder if the error could be better though — something along the lines of "wildcard specifiers (*) are only accepted when used on their own".

The intent of the version requirement specifier is to match any released version and any pre-release version of 0.20.0 since pre-releases aren't matched by *.

Note that this is not what comma means. Comma roughly represents intersection, not union. That is why e.g. >=2, <4 does not match every major version. It would not be my expectation that *, 0.20.0-any has a meaning that is different from ^0.20.0-any.

Ooof, of course, you're right. The end of a day that was too long :) And also suggests some additional clean-up I'll have to do at work tomorrow :sweat_smile: I suppose there isn't really a way to specify union today except by keeping multiple VersionReqs and using .iter().any(|vr| vr.matches(...)).

Reopening for https://github.com/dtolnay/semver/pull/266#discussion_r799848870.


Fix player username filtering

Apparently it's possible to add players with special characters in their usernames via the group/add-member endpoint.
Best thing to do is ensure every usage of playerService.findAllOrCreate has some protection, by using playerService.standardize.

@psikoi it looks like it already does that
`async function findAllOrCreate(usernames: string[]): Promise<Player[]> {
const foundPlayers = await findAll(usernames);
if (foundPlayers.length === usernames.length) return foundPlayers;
const foundUsernames = foundPlayers.map(f => f.username);
const standardizedUsernames = usernames.map(standardize);
const missingUsernames = standardizedUsernames.filter(u => !foundUsernames.includes(u));
const newPlayers = await Player.bulkCreate(
missingUsernames.map(m => ({ username: standardize(m), displayName: sanitize(m) })),
{ individualHooks: true }
);
return [...foundPlayers, ...newPlayers].sort(
(a, b) => standardizedUsernames.indexOf(a.username) - standardizedUsernames.indexOf(b.username)
);
}`

Fixed in #820


[Bug]: Importing named members with aliases causes an error from playground

Version
System:
    OS: macOS 14.2.1
    CPU: (16) x64 Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz
    Memory: 1.16 GB / 16.00 GB
    Shell: 5.9 - /bin/zsh
  Browsers:
    Chrome: 120.0.6099.234
    Edge: 121.0.2277.83
    Safari: 17.2.1
    Safari Technology Preview: 17.4
  npmPackages:
    @rspress/plugin-playground: ^1.11.1 => 1.11.1
    rspress: ^1.11.1 => 1.11.1

Details
An error occurs when using import with named members with aliases in playground.
import { PackageManagerTabs } from 'rspress/theme';

work’s find.
but, if you use as, you’ll get an error.
import { PackageManagerTabs as Tabs } from 'rspress/theme';

const App = () => {
  return <Tabs command="test" />;
};

export default App;

error:

Cannot read properties of undefined (reading 'map')

When importing a component from another package, the following error occurs.

Element type is invalid: expected a string (for built-in components) or a class/function (for composite components) but got: undefined. You likely forgot to export your component from the file it's defined in, or you might have mixed up default and named imports.

Reproduce link
https://codesandbox.io/p/devbox/romantic-ramanujan-pnhw99
Reproduce Steps

Go Reproduce link
Move hello world page
file: docs/hello.md

I have fixed it in #587


Refactor Data object in PaginatedTable.js so it can have different properties

What maintenance needs to be done?
Make it so that the data object in PaginatedTable.js can have different properties
Level of urgency

[x] High
[ ] Moderate
[ ] Low

Why is this maintenance needed?

Need to be able to set different data based on page

Acceptance criteria

[ ] Data object can have different data

Implementation notes, if any

Can use a config, or choose a different approach

I think #81 may have resolved this issue -- it removes date, name, auctionHouse, and city from the data() object, if that is the Data object in question.

@sandbergja we can close this ticket yes. Thanks for resolving it!

closed by https://github.com/pulibrary/static-tables/pull/81


Add disable sandbox option

Currently I'm using WSL 1 as i have difficulty connecting with browservice server with WSL2, and once i launched borwservice server in WSL1, i have noticed that it doesn't support chromium ipc namespaces so usually i have to append no sandbox
But is there an option to disable sandbox? because i was currently using WSL1

I added an option --chromium-args for passing extra options to Chromium in e542cbe937a4335954ddf6f8ecca5ec7e6e0a1cb. So to disable the sandbox, try running the master version with the option --chromium-args=no-sandbox and let me know if that solved your problem. Please note that running Chromium without sandbox is insecure.
(P.S. Sometimes, I also have problems connecting to local servers running in WSL2 from the Windows side; in these cases, it usually helps to restart WSL2 by running wsl --shutdown in the Windows command prompt. Of course, setting up connections from other PCs in the network is still cumbersome.)

I added an option --chromium-args for passing extra options to Chromium in e542cbe937a4335954ddf6f8ecca5ec7e6e0a1cb. So to disable the sandbox, try running the master version with the option --chromium-args=no-sandbox and let me know if that solved your problem. Please note that running Chromium without sandbox is insecure.
(P.S. Sometimes, I also have problems connecting to local servers running in WSL2 from the Windows side; in these cases, it usually helps to restart WSL2 by running wsl --shutdown in the Windows command prompt. Of course, setting up connections from other PCs in the network is still cumbersome.)

Ok. i switched to wsl1 and enabled no sandbox but instead of giving me ipc namespace error, it gives me about udev and core dumped

However i might try to run this with Ubuntu VM with bridged network

Ok. i switched to wsl1 and enabled no sandbox but instead of giving me ipc namespace error, it gives me about udev and core dumped

However i might try to run this with Ubuntu VM with bridged network

Ok, so I've used Termux as to run browservice and it works (although no sandbox needs to be enabled and took a long time to compile) and yeah it runs

and the localhost of web server loads,

Ok, so I've used Termux as to run browservice and it works (although no sandbox needs to be enabled and took a long time to compile) and yeah it runs

and the localhost of web server loads,


[Forgot Password] Show Forgot Password option in Lock Screen

Is your feature request related to a problem? Please describe.
There are few users contact CM because they forgot their passwords. And they do not know how to do next steps. It's helpful to add the forgot password link / button to guide them.
Describe the solution you'd like

Describe alternatives you've considered
N/A
Additional context
N/A

hi @hoailinh1210 @djhahe , I think the text should be "Forgot Password?"

My suggestion for the typo. Thanks.

UI Bug - Cannot see the text box.

Hi @gaupoit , I fixed on PR #335 and merged on release/1.6.0, please take a look on it


chore: have check for license-text file-header

in the JavaScript/node ecosystem, it is common to pack/transpile/transform source code for a target system.
esbuild, ... these tools are usually used for the tasks.
tools minify code by stripping comments.
a license-text-comment should not be stripped, but it should be kept.
therefore these tools do not touch block-comments that start with /*!. some tools replace these comments with a text that states in which file the original text can still be found. yet they respect the ! and keep the texts.
task: make all license-text comments be block-comments starting with an  enforcer-mark !

done


Revert "Revert "fix: Prevent a memory leak on AndroidView which may not call ON_DESTROY""

Reverts googlemaps/android-maps-compose#202

Doesn't preserve credit to contributor. Closing.


Train on something different than text

Hi,
Is it possible to train something different than text to image ? Im thinking of something like features or other to image.
x-clip is already working for that as we discussed in this issue : https://github.com/lucidrains/x-clip/issues/12
But it seems like the diffusion prior is only working with text--> images. Is there a way to make it possible to condition of other stuffs ?
Thanks :)

The prior needs to be retrained for any new clip model being used whether or not it is encoding something other than text. If you have a clip model that is encoding something other than text it would be possible to use that, but you would need to train a prior and decoder for that task specifically and the data requirements remain very large.

Yep I trained a new clip and decoder but the diffusion prior seems to only work with text not anything else

Anyway to go around that easily ? @lucidrains

Did you train a new prior?

well I have trained clip and the decoder. Then I tried to train the prior network and I got the following error:
mat1 and mat2 shapes cannot be multiplied (2x256 and 15724x2048) with a traceback on encoder_output = self.clip.text_transformer(text)

I would assume that is due to the dimension of the embedding being incorrect. What is the shape of the output from your clip?

output of clip is of size (batch_size) (=2 in my code for testing)

Oh, I didn't read carefully enough. This is a problem in the XClipAdapter. Maybe a text length issue? Did you use this clip to train the decoder?

here is a full test code snippet
import torch
from dalle2_pytorch import CLIP

import torch
import torch.nn as nn
from torchvision import models
from einops import rearrange

class features_encoder(torch.nn.Module):
    #output size is (bs,512)
    def __init__(self):
        super(features_encoder, self).__init__()

        self.model=nn.Sequential(
            nn.Linear(15724,2048),
            nn.ReLU(),
            nn.Linear(2048,512)

        )

    def forward(self, x):
        out=self.model(x)
        return out

features_encoder=features_encoder().cuda()

clip = CLIP(
    text_encoder = features_encoder,
    text_encode_without_mask = True,
    dim_image = 512,
    dim_text = 512,
    dim_latent = 512
).cuda()

images=torch.randn((2,3,256,256)).cuda()
feat=torch.randn((2,15724)).cuda()

loss = clip(feat, images, return_loss =True)
loss.backward()

import torch
from dalle2_pytorch import Unet, Decoder, CLIP

unet = Unet(
    dim = 128,
    image_embed_dim = 512,
    cond_dim = 128,
    channels = 3,
    dim_mults=(1, 2, 4, 8)
).cuda()

# decoder, which contains the unet and clip

decoder = Decoder(
    unet = unet,
    clip = clip,
    timesteps = 100,
    image_cond_drop_prob = 0.1,
    text_cond_drop_prob = 0.5
).cuda()

images=torch.randn((2,3,256,256)).cuda()

loss = decoder(images)
loss.backward()

from dalle2_pytorch import DiffusionPriorNetwork, DiffusionPrior, CLIP

# setup prior network, which contains an autoregressive transformer

prior_network = DiffusionPriorNetwork(
    dim = 512,
    depth = 6,
    dim_head = 64,
    heads = 8
).cuda()

# diffusion prior network, which contains the CLIP and network (with transformer) above

diffusion_prior = DiffusionPrior(
    net = prior_network,
    clip = clip,
    timesteps = 100,
    cond_drop_prob = 0.2
).cuda()

images=torch.randn((2,3,256,256)).cuda()
feat=torch.randn((2,15724)).cuda()

loss = diffusion_prior(feat,images)
loss.backward()

The bug happens in the last part aka loss=diffusion_prior

This is actually an issue with the x-clip configuration. I can't dig deep right now, but I think there are a couple problems. The most obvious one is that you need to inform clip that it will be taking long sequences. By default it expects the text sequence to be under 256 long while yours is 15724 and the way your text encoder was built it always expects exactly 15724. You can set the max text size with the text_seq_len, but I think there will be further issues. @lucidrains  is the expert on x-clip and I know basically nothing so he will be much more able to help.

@Veldrovive thanks for fielding this :)
@ethancohen123 so the issue is that you are projecting your text along the sequence length to the latent directly, so there is no text encodings per se
try upgrading to 1.8.3, then use this modified script
import torch
from dalle2_pytorch import CLIP

import torch
import torch.nn as nn
from torchvision import models
from einops import rearrange

class features_encoder(torch.nn.Module):
    #output size is (bs,512)
    def __init__(self):
        super(features_encoder, self).__init__()

        self.model=nn.Sequential(
            nn.Linear(15724,2048),
            nn.ReLU(),
            nn.Linear(2048,512)

        )

    def forward(self, x):
        out=self.model(x)
        return out

features_encoder=features_encoder().cuda()

clip = CLIP(
    text_encoder = features_encoder,
    text_encode_without_mask = True,
    text_seq_len = 15724,                       # <-- this needs to be set to the correct maximum text sequence length
    dim_image = 512,
    dim_text = 512,
    dim_latent = 512
).cuda()

images=torch.randn((2,3,256,256)).cuda()
feat=torch.randn((2,15724)).cuda()

loss = clip(feat, images, return_loss =True)
loss.backward()

import torch
from dalle2_pytorch import Unet, Decoder, CLIP

unet = Unet(
    dim = 16,
    image_embed_dim = 512,
    cond_dim = 128,
    channels = 3,
    dim_mults=(1, 2, 4, 8)
).cuda()

# decoder, which contains the unet and clip

decoder = Decoder(
    unet = unet,
    clip = clip,
    timesteps = 100,
    image_cond_drop_prob = 0.1,
    text_cond_drop_prob = 0.5
).cuda()

images=torch.randn((2,3,256,256)).cuda()

loss = decoder(images)
loss.backward()

from dalle2_pytorch import DiffusionPriorNetwork, DiffusionPrior, CLIP

# setup prior network, which contains an autoregressive transformer

prior_network = DiffusionPriorNetwork(
    dim = 512,
    depth = 6,
    dim_head = 64,
    heads = 8
).cuda()

# diffusion prior network, which contains the CLIP and network (with transformer) above

diffusion_prior = DiffusionPrior(
    net = prior_network,
    clip = clip,
    timesteps = 100,
    cond_drop_prob = 0.2,
    condition_on_text_encodings = False     # <-- set this to False
).cuda()

images=torch.randn((2,3,256,256)).cuda()
feat=torch.randn((2,15724)).cuda()

loss = diffusion_prior(feat,images)
loss.backward()

@ethancohen123 just curious, but what kind of modality are you working with?

Thanks i will try this during the we !
Working with laion medical on brain human interface problem :)

But also working on different multi modal generation but different than text to image, we could have a chat about this if youd like :)

@ethancohen123 cool! yea, maybe once i finish what is on my plate in a couple months we can chat :)


Implement addCreatedAt function in Swift

Part of appwrite/appwrite#1899
Collection with createdAt
Document input

Execution logs

Execution output

Final document

Collection without createdAt
Document input

Execution logs

Execution output

THANK YOU! All changes merged 🥳
Please reach out to eldadfux on our Discord server if you would like to claim your Appwrite swags! As a way of saying thank you, we would also love to invite you to join the Appwrite organization on GitHub. Please share your GitHub username with us on Discord.
You can accept the invite by visiting https://github.com/orgs/appwrite/invitation. By joining our team, you will officially be an Appwrite maintainer on GitHub.
You can change your membership visibility settings, so your new Appwrite team membership badge will show up on your personal GitHub profile.
Please feel free to look for more PRs you might be interested in helping with on our long list of Hacktoberfest friendly issues and help make Appwrite better :)


Major versions of dependencies

How would you feel about always using the latest non-breaking version of all dependencies. For example, using every release of percent-encoding version 2 instead of one specific release, or the same with tokio 0.2

I like to have the Cargo.lock under version control to have reproducible builds. This is a best practice for Rust applications as described in https://doc.rust-lang.org/cargo/faq.html#why-do-binaries-have-cargolock-in-version-control-but-not-libraries.
But I can run cargo update more often to get the latest non-breaking version of dependencies in the future.

Oh alright, thank you. I didn't know much about this.

Closing, since not really an issue.


Examples

I am trying to use serial but failing to do so. [STM32F4Discovery board]
#[entry]
fn main() -> ! {
    let p = hal::stm32::Peripherals::take().unwrap();

    let rcc = p.RCC.constrain();
    let clocks = rcc.cfgr
        .hclk(8.mhz())
        .sysclk(168.mhz())
        .freeze();
    let gpioa = p.GPIOA.split();

    // USART1
    let tx = gpioa.pa9.into_alternate_af7();
    let rx = gpioa.pa10.into_alternate_af7();

    let s = Serial::usart1(p.USART1, (tx, rx), 9600.bps(), clocks);
    let (mut tx, _) = s.split();

    loop {
        block!(tx.write(b'x'));
    }
}

And all I get on the serial is unreadable mess (0xF8, 0xF8, 0xF8, ...).
I think it would be nice to have examples that were tested to work.

Most likely my fault. Switched to using PB6/7 and it works. Maybe the board has something attached to PA9/10 and I'm too lazy to check the datasheet.
Great job and thanks for the library :+1:

@petoknm Thanks for using this. Just as a side note, I've also created the stm32f407g-disc and stm32f429i-disc board support crates using this crate and containing examples which are tested to work on those boards.


fixes #2404 by upgrading error prone to 2.4.0

hopefully will fix the issue with error-prone, got the same issue but with a different class, did try to switch between 8, 11, 15 but the error still persists, after upgrading error-prone at least got further

@mac2000 Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

@mac2000 Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

@mac2000 Thank you for signing the Contributor License Agreement!

@mac2000 Thank you for signing the Contributor License Agreement!

heh, and it did not
in idea with java 15, everything seems to be fine but in CI with java 8 it brokes, after few attempts, it seems that I was able to make it working back by downgrading error-prone back to 2.3.4 but only for java 8
not sure whether it is a good approach or not but at moment have no idea what to do next

heh, and it did not
in idea with java 15, everything seems to be fine but in CI with java 8 it brokes, after few attempts, it seems that I was able to make it working back by downgrading error-prone back to 2.3.4 but only for java 8
not sure whether it is a good approach or not but at moment have no idea what to do next

arghhhh, codecov is red 😂
should I add some tests for coverage to become +7%?
but then this PR won't be about upgrading error-prone
is there a way to bypass it?

arghhhh, codecov is red 😂
should I add some tests for coverage to become +7%?
but then this PR won't be about upgrading error-prone
is there a way to bypass it?

arghhhh, codecov is red
should I add some tests for coverage to become +7%?
but then this PR won't be about upgrading error-prone
is there a way to bypass it?

Hey don't worry -- we can ignore the codecov for your PR since it's just upgrading the error prone version. I'll take a look.

arghhhh, codecov is red
should I add some tests for coverage to become +7%?
but then this PR won't be about upgrading error-prone
is there a way to bypass it?

Hey don't worry -- we can ignore the codecov for your PR since it's just upgrading the error prone version. I'll take a look.

Did some more digging, looks like someone else has same problem: https://github.com/codehaus-plexus/plexus-compiler/issues/77
However I'm not yet sure how they resolved their problem.

Did some more digging, looks like someone else has same problem: https://github.com/codehaus-plexus/plexus-compiler/issues/77
However I'm not yet sure how they resolved their problem.

I am fine with the manual override of the version, just add a comment on the line above to remind people why it's there.

Done.


Put OOP CFG registration under a flag in test builds

To help with downlevel testing, only enable OOP CFG registration on release build

:shipit:


Create Vagrant Environment

As a: Developer
I need: To create a virtual environment for the team to work on
So that: The team can work in a singular environment with no dependency issues
Assumptions:

Create a Vagrant file and embed the required tools.
Upload Vagrant file to the organization repo for team to access.

Acceptance Criteria:
Given: The developer gets the Vagrant File.
When: They run vagrant up and vagrant ssh
Then: They can run the necessary files in the environment and start developing

Uploaded the Vagrantfile, waiting for team review.
Tools added so far -

Redis Container
Python/Python flask
Apache2

The Vagrant file is not working. There are issues with it :
1 Not able to connect to the browser with a simple application like app.py from the lab folders used in class.
Please run the app.py file using this vagrantfile to spot the issue and also look at some differences between this vagrant file and the one used in class.

Ok for connecting to the browser,did you check the port number you're connecting to?

Just a preview with the same Vagrantfile, it works fine for me.

It works for me, but I have a question about the vagrant file location. Would it be easier for application deployment if we have the vagrantfile in the root /wishlist/ folder instead of having its own /wishlist/Vagrant/ folder?

Have it in the root....
On Wed, Oct 11, 2017 at 4:00 PM Yonghong Chen (Peter) <
<EMAIL_ADDRESS>wrote:

It works for me, but I have a question about the vagrant file location.
Would it be easier for application deployment if we have the vagrantfile in
the root /wishlist/ folder instead of having its own /wishlist/Vagrant/
folder?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/nyu-devops-golf-team/wishlist/issues/8#issuecomment-335930302,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Aea0tDQoKoc1EWY9n4aZeCPP0sP3nDoKks5srR5FgaJpZM4PuHOr
.

Yea ill move it to the root.

Also let's keep it in done for now because I'm still not sure if we'll need more tools appended to it. Once we're done with that, ill close the issue.


its incredible!

just this

and kindly I wanna report another thing that is also related to the callout;
when the auto fadeout inactivated line feature is activated, in the callout that contains a PDF file in it even by hovering the PDF is not unfade; I know that it is based on the line and text, it is just a suggestion that it could be better to have a option that if we hover over the PDF or any attachment it will be unfaded; I do not know is it possible technically or not.

and the third one;
it is a bug, as I hover over the navigation forward or backward that are located in the tab bar; if I wanna click on the navigate backward it is not possible, because as soon as I put my mouse near it the tab bar is hided and the ribbon is activated; so the usage of navigate backward in the tab bar technically is not possible.

the other one is related to the Tasks plugin; in the reading mode the date is not shown in a correct way.

as you can see the last date is not correctly shown.

this is my question really I don't know is it a bug or not; is it intentional style that the hashtag part (#) and the name of the tag have different colour for the tasks plugin?

this is in editing mode; but I think it is not intentional because other tags and also in the reading mode it is disappeared!
BTW, thanks a lot; the first view of the theme for me was incredible; I hope you continue its development.

Glad you like the theme :)

The blockquote line not extending to the list items is something I forgot to add. I will fix this in the next update.
I think it will be possible to make certain items in Edit Mode full opacity on hover. I will work on this.
The navigation bar issue can be fixed by adding extra padding to the left of the titlebar. I will fix this also! But if you want to navigate back and forth right now with hotkeys, you can use ctrl + alt + left-arrow or ctr + alt + right-arrow also.
I don't use the Tasks plug-in, so I'm not sure why it's doing that. I'll install the plug-in for some testing, though.
As for the last one with the tags, I actually noticed that, but haven't found a solution. It only affects tags contained within lists, so I think the list messes up the nth-child styling. It works in reading mode, though, so I think I might leave it that way unless I find another fix.

Hey,
First of all, incredible theme indeed!
Since we're on topic of discussing bugs here, I'm not going to create another issue.

The task checkboxes are tiny, I'm not sure if it's on purpose, but I think they could be more prominent.
Also, it seems it's the theme's job is to support custom statuses. As you can see, they are all displayed as done.

Also, I want to share a modification I made to the settings pane to make things more compact. I have many plugins, and I found it hard to scroll through all of them.
/* settings pane tighter list items */
.horizontal-tab-nav-item, .vertical-tab-nav-item {
    padding: 0.5em 1em;
}

.vertical-tab-header-group-title {
    font-size: var(--font-ui-smaller);
    text-align: left;
    border-bottom: none;
}

Thanks for the feedback, @therazman! The checkbox size was something I tweaked as an experiment and I forgot to change it back before I updated the theme...so yeah, that will definitely go in the next update.
And as for the checkbox states, I wasn't planning on adding them, but since you mentioned it, I think I'll try to squeeze that into the next update as well.
And I like your version of the sidebars. Is it okay if I use it for a style settings option?

@erfanbashar1q, I believe all of these have been fixed by the latest update.

elements are now full opacity on hover in edit mode
blockquote line is fixed
navigation bar is in a better position to click

And I believe the appearance issue with the Tasks plug-in was from Dataview styling that made the font smaller. I have changed this code, and hopefully that fixed it. If it didn't, let me know and I'll look deeper into it.
Thanks for helping me improve the theme, I really appreciate it!

@therazman, I added custom checkboxes in the latest update! The syntax is the same as Minimal's.
I also added your compact settings snippet as a setting under the Modals heading. Thanks for helping me improve the theme, enjoy the update!


Use new PSR-15

Codecov Report

Merging #4 into master will decrease coverage by 0.85%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master       #4      +/-   ##
============================================
- Coverage      90.2%   89.34%   -0.86%
  Complexity       60       60
============================================
  Files             4        4
  Lines           194      169      -25
============================================
- Hits            175      151      -24
+ Misses           19       18       -1

Impacted Files
Coverage Δ
Complexity Δ

src/BrancaAuthentication/CallableHandler.php
100% <100%> (ø)
2 <1> (?)

src/BrancaAuthentication.php
87.58% <100%> (-0.9%)
50 <12> (ø)

src/BrancaAuthentication/RequestMethodRule.php
100% <0%> (ø)
2% <0%> (ø)
:arrow_down:

src/BrancaAuthentication/RequestPathRule.php
100% <0%> (ø)
6% <0%> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad88214...460d8d2. Read the comment docs.