test(e2e): add retry count in ci

Our e2e tests can be flaky at times and often just running them again is enough to get them going green ✅. This PR updates our Playwright config to retry twice in CI so avoid this flakiness issue. If tests continue to fail inconsistently then we know that a deeper issue is at play here 👀
Retry Docs

Do we know which tests tend to be flaky to write better tests?

@siddharthkp I can't seem to find any rhyme or reason to them when looking at them 😞 they tend to be related specifically to resolving the storybook URL versus anything else. We have caught some animation-related flakiness previously which has been great for test writing practices.


Add Langflow

Langflow is a low-code app builder for RAG and multi-agent AI applications. It’s Python-based and agnostic to any model, API, or database.

Python-based and agnostic to models, APIs, data sources, or databases.
Visual IDE for drag-and-drop building and testing of workflows.
Playground to immediately test and iterate workflows with step-by-step control.
Multi-agent orchestration and conversation management and retrieval.
Free cloud service to get started in minutes with no setup.
Publish as an API or export as a Python application.
Observability with LangSmith, LangFuse, or LangWatch integration.
Enterprise-grade security and scalability with free DataStax Langflow cloud service.
Customize workflows or create flows entirely just using Python.
Ecosystem integrations as reusable components for any model, API or database.

Honestly right now I have been using Dify.ai and love it. It just has a lack of connectors. Langflow has some really great connectors and is supported by the langchain team. It also seems that their RAG implementation is a bit more advanced than Dify but I havent looked into it too much.
The only thing I have found from Langflow that is a major negative is there is no direct support for passing the API to Openwebui

Also I have started work on importing it here. It seems pretty successful, I am just having issues handling harbor url and harbor open.
https://github.com/ZacharyKehlGEAppliances/harbor-langflow

Hey 👋🏻

Thanks for trying out Harbor and for the suggestion!
Langflow was planned eventually, and Flowise as well, we do want to expand on satellites with visual LLM workflows, I've been using Dify/LitLytics quite a bit, we also have n8n (a bit cumbersome to configure), and omnichain already available meanwhile the services above are in progress
the PR looks awesome! The URL/Open problem might be coming from the wrong network name (should be harbor-network, as well as no need to redefine it), while developing and adding new vars to the default profile, you can run harbor config update to sync them back to the current .env, otherwise nothing looks fishy enough to be an immediately obvious cause

JFYI, Flowise was just added in v0.2.18 (very nice DevX, functionality is great too), @ZacharyKehlGEAppliances , granted you have a WIP for LangFlow integration - please feel free to open a PR whenever ready, I'll avoid adding it myself to avoid conflicts

@av appreciate it! I am fixing the harbor-network issues right now and should have something ready here soon!

@av https://github.com/av/harbor/pull/86#issue-2699442309

The PR was merged, I tested everything and added the docs here:
https://github.com/av/harbor/wiki/2.3.32-Satellite:-LangFlow
Will be released later today, thanks again for the contribution!


Bitwise operations - add one's complement, alternative representations and improve documentation

I could not find any information in the docs about one's complement. The other basic bitwise operations work as expected (&, I, ^), but neither "not", nor "~", nor "!" work for me.

I think it would intuitive to have alternative operators as well in the form of "and", "or", "xor" and "not"
Similar to this https://en.cppreference.com/w/cpp/language/operator_alternative

Binary shifts are not really mentioned in the documentation. kalk's >> is an arithmetic shift as far as I can see. Might be worth clarifying.

"alternative representations" sounded like one thing I feel the need for: the big endian output of bin. E.g.:


Error with Streamlit example

modal-http: internal server error: status Failure: TypeError("ClientSession.init() got an unexpected keyword argument 'max_line_size'")

Hi, are you sure that you're using an up-to-date version of modal? I just tried serving this example and it ran fine for me:

We'll need more information about exactly what you're doing if the error persists after upgrading.

I downgraded the modal package as a temporary solution. pip install modal==0.62.203 --force.
The max_line_size was introduced 4 days ago. See this commit.
@ekzhang may have more information.

Looks like that option might not work for image builder version 2023.12, which has aiohttp 3.8.3. I can see if I can find an alternative.


Wrong class descriptions

Here are a few incorrect class description my team and I have stumbled across:

35990	wrong description, because bridged compounds have at least three atoms in common (otherwise fused compounds would be a part of bridged compounds) as described here [1]
36683	organochlorine compound SMILES *Cl, should have [*]CCl
65285 	aliphatic amide - picture only matches primary amides (also residue too unspecific, but that is not easily solvable)

Hi,
There is nothing wrong with the definition in ChEBI for bridged compounds since we are referring to the common atoms between the two rings (also known as the bridgehead atoms). See image below which describes the difference between a bridged compound and a fused compound:

The Wikipedia definition is also fine since they are not referring to the common atoms and instead mention the bridge which needs 3 or more atoms.
The SMILES are generated automatically based on the chemical structure input. The SMILES for organochlorine compound has now been regenerated as Cl[*]. The symbol * is treated by SMILES as a valid atomic symbol meaning 'unspecified atomic number'. There is nothing I can do to make sure that R contains at least one carbon atom since we do not have the ability to edit the SMILES in the curator tool.
I will try and fix the structure or ChEBI name of aliphatic amide (CHEBI:65285) after informing the submitter who deposited this entry to ChEBI.
Thanks

I have updated the definition of bridged compound so that it is clear to the user.


message status endpoint

Now that the events for messages are being stored, we can implement the message status endpoint.

Ready for review.

:+1:


Using this library on expo?

Hi,
Any implementation of this package on expo? If yes, can you please share an example or provide starting info?

I did think of that and checked up youtube video. My only challenge with
that is how to show the splash screen when user has closed the app and
reopens it. I dont want to show the splash everytime appstate goes from
Background/inactive to active. React doesnt have a way of showing if the
the app was formally closed. If i ran compenent based on that logic, even
if the up goes into background, and then comes back up, the compoment will
run.
Am i correct on this? Any slick way around this?
 You could use
lottie-react-native directly. See this Reddit thread
https://www.reddit.com/r/reactnative/comments/j2how8/splash_screen_with_lottie_in_react_native/,
with a Youtube video, explaining how.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/HwangTaehyun/react-native-lottie-splash-screen/issues/14#issuecomment-906440201,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AE7NAOJ6Z7EC3H2AD2TKDPTT6ZCIFANCNFSM5CVTFPLQ
.

Sorry for my late reply!
I don't have any examples for expo.. Sorry...

@sykhan88 I applied this to the expo bare workflow and add some info to README.md!

Thanks very much. Expo these days has config plug-ins which allow for native. I haven't been able to successfully do this yet but just sharing in case a kind can https://docs.expo.dev/modules/config-plugin-and-native-module-tutorial/


missing gzip compression for 2015

When I do
wget http://data.githubarchive.org/2015-01-01-15.json.gz

I get a plain JSON file that is not gzipped.

Hmm.. bah! Was hoping wget would automatically append the gzip header.
wget --header="accept-encoding: gzip" http://data.githubarchive.org/2015-01-01-15.json.gz
Should probably add a note in the readme =/

This solution does not seem right to me. Accept-Encoding: gzip / Content-Encoding: gzip means that the transfer is gzip compressed, not the content after the transfer. Consider the following Go program:
package main

import (
	"io"
	"net/http"
	"os"
)

func main() {
	resp, err := http.Get("http://data.githubarchive.org/2015-01-01-15.json.gz")
	if err != nil {
		panic(err)
	}
	defer resp.Body.Close()

	file, err := os.Create("2015-01-01-15.json.gz")
	if err != nil {
		panic(err)
	}
	defer file.Close()

	io.Copy(file, resp.Body)
}

Go automatically uses Accept-Encoding: gzip, but it also automatically decompresses the response if Content-Encoding: gzip is given in the response header. So if I want to store the gzipped version, I would need to compress it again or do some other hack. This code works fine for files before 2015.

You're right. Should be fixed now!

Thx!


add dumptorrent-1.2

Just a small utility, nothing non-trivial here.
--
Things done:

[X] Tested using sandboxing (nix-build --option build-use-chroot true or nix.useChroot on NixOS)
Built on platform(s)

[X] NixOS
[ ] OS X
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[X] Fits CONTRIBUTING.md.

Looks good to me, but you must change the commit subject to conform to the guidelines.

@joachifm, sorry, I forgot about the guidelines. The title and the commit message were changed.


IDVA6-1274 manage user search

Link to Jira:
https://companieshouse.atlassian.net/browse/IDVA6-1274
Changes:

Search functionality added
Page not loading after clicking View users link in the dashboard error fixed
Mocks and tests updated and new added
Misplaced files with tests moved to the correct directory

CI: No security warnings found


Add additional data to various socket types

Based on the UX requirements for what the notification text would say, here is additional data various socket types need:
OrderConfirmation:

%{vendorName} has accepted your order.

[x]  Need vendor handle and peerId.

declined:

%{vendorName} has declined your order.

[x] Need vendor handle and peerId.

cancel:

%{buyerName} has canceled their order.

[x] Need buyer handle and peerId.

refund:

%{vendorName} has refunded your order.

[x] Need vendor handle and peerId.

fulfillment:

%{vendorName} has fulfilled your order.

[x] Need vendor handle and peerId.

orderComplete:

%{buyerName} left feedback on their order.

[x] Need buyer handle and peerId.

disputeOpen: (received by mod and other party)

%{disputerName} opened a dispute with %{otherPartyName} || you. // is it possible to use "you" when the notification goes to the other party? The moderator would always see %{otherPartyName} in the notification.

[x] Need the handle and peerId of the party that opened the dispute (disputer).

[x] Need the handle and peerId of the other party (disputee).

disputeUpdate:

%{otherPartyName} shared their contract for the dispute with %{disputerName}.

[ ] Need the handle and peerId of the party that opened the dispute (disputer).

[ ] Need the handle and peerId of the other party (disputee).

disputeClose:

The dispute with %{otherPartyName} has been closed. // I should never see my own name in this notification. It should always display the other party.

[ ] Need the handle and peerId of the party that opened the dispute (disputer).

[x] Need the handle and peerId of the other party (disputee).

disputeAccepted:

The dispute with %{otherPartyName} has been finalized.

[ ] Need the handle and peerId of the party that opened the dispute (disputer).

[ ] Need the handle and peerId of the other party (disputee).

follow:

%{handle} has followed you.

[ ] If possible, please provide the handle here, otherwise the client needs to make a profile call.

modAdd:

%{handle} has added you as a moderator.

[ ] If possible, please provide the handle here, otherwise the client needs to make a profile call.

modRemove:

%{handle} has removed you as a moderator.

[ ] If possible, please provide the handle here, otherwise the client needs to make a profile call.

FWIW, when "name" is used above, the client will show handle (if available) or guid (if not), so %{vendorName} has accepted your order. would be @themes has accepted your order. or Qmabc123… has accepted your order..

disputeClose:

The dispute with %{otherPartyName} has been closed. // I should never see my own name in this notification. It should always display the other party.
Need the handle and peerId of the party that opened the dispute (disputer).

Why do you need the ID of the peer that opened the dispute here if it's not displayed?

follow:

%{handle} has followed you.
If possible, please provide the handle here, otherwise the client needs to make a profile call

What are you doing for the avatar... GET avatar? I don't have the handle saved for the node since, like the avatar, the field may change.

disputeUpdate:

%{otherPartyName} shared their contract for the dispute with %{disputerName}.
Need the handle and peerId of the party that opened the dispute (disputer).

Is it more appropriate here to use the case ID instead of disputerName

Why do you need the ID of the peer that opened the dispute here if it's not displayed?

Same for dispute accepted

That was a mistake, we just need the peer ID and handle of the other party.

What are you doing for the avatar... GET avatar? I don't have the handle saved for the node since, like the avatar, the field may change.

I forgot about the avatar. If the handle and avatar are not provided then we'd make a profile call with usecache=true. Seems like a waste to make that call for what could be many notifications. Mike and others have said that stale data is not a problem here. Wouldn't the handle and listing image, etc... be stale for the order notifications too?
Anyways, if it's a big deal to provide that data, then we'll just make the profile calls.

Is it more appropriate here to use the case ID instead of disputerName?

I'm not following... the UX req is to show the disputer's handle / guid which would link to their user page. How would the case ID help with that?
We do still need the case ID, since the notification should link to the Order Detail overlay for this case.

%{otherPartyName} shared their contract for dispute %{id}. seems to read better to me.

%{otherPartyName} shared their contract for dispute %{id}. seems to read better to me.

Hmmmm... so you think @themes shared their contract for dispute QmdvLT6WX18fyhTZ7o7tr8BzNFEduWu53m5QNSG8kqkoQB is more readable than @themes shared their contract for the dispute with @skishop?
@morebrownies thoughts?
@cpacia Is there a technical complication in providing the handle and guid of the disputer, or you just think the first option is better UX?

I don't know. It's possible someone could have multiple disputes with the same store. Not sure if it's likely though.


PYIC-5872: Expose core's internal API in dev

Proposed changes
What changed
Expose core's internal API to requets with an API key.
Why did it change
PYIC-5872: Expose internal API in dev
This change allows core's internal API to be accessed with an API key
when deployed to either of the dev accounts.
It adds a usage plan with API key to the internal API, and then makes
use of an API key required only for the dev accounts. It also adds DNS
to the API gateway to make use of the internal API easier.
Also, to allow programatic access to the API key, a new resource policy
is created to allow the OIDC identity provider enough permissions to
fetch the API key.
It removes the CoreFrontLocal parameter in favour of defaulting to
this behavour for dev accounts. This is because changing back to a
private API from the new regional version is a two step process - so not
as easy as just toggling the parameter.
It's a two step process as you can't change from regional to private if
it has custom domains associated with it. In CloudFormation there isn't
a way to specify that something should be removed before making changes,
resulting in having to remove the custom domain before changing the API
to private.
Ideally I would have liked to have conditionally created the UsagePlan -
only for the dev accounts. However there appears to be a bug in cfn-lint
that means we can't use an If function with the CreateUsagePlan
property.
The GHA workflow included in this PR is just to demonstrate that the
gateway is now available with an API key, and also how to
programatically access the API key. This would not be merged with the
PR.
PYIC-5872: Don't use SAM UsagePlan
SAM allows an easy way to create a usage plan and API key, by defining
the UsagePlan property in an Api resource. Unfortunately you can't
use an !If function with it do conditionally create it.
This removes the use of it and defines the resources requied using
plain old CloudFormation. This allows us to only create them when we
want.
Using the previous method would have caused a usage plan and api key to
be created in all envs including prod. This felt like murky ground - the
non dev api's would still be private so it wouldn't have been an issue,
but feels safer to only create them when actually needed.
PYIC-5872: Create separate API for internal testing
This creates a new API gateway to run in parallel with the original.
This means that the VPC protected internal API can still be used by
core-front without any changes, and the new regional, API token
protected API gateway can be used for testing.
cfn-lint has an issue with having an event defined in a lambda that
includes a reference to a conditionally created resource, even if that
resource is behind the same condition. This has lead to the ignore
written into the metadata of a number of resources.
Issue tracking

PYIC-5872

This seems better to me, what do you think?
It makes the prod configuration cleaner, and isn't much more code than before. The main thing that's annoying is configuring the extra events and overriding that cfn-lint rule :/

I think this is ok - at some point we're going to create a new lambda and forget to add the extra testing event on. We could write a macro to do that for us and not have to define the event at all....


Add E2E tests for Admin Not Found

I picked this up, but I am confused where you would need to use this within the editor tools?

Yeah I can see what you mean haha ;). Well this is probably the easiest one! Seems like we only render it for garbage routes.
What I'd probably do is in nightmarejs pseudocode
return getLoggedInState('/this/is/not/valid')
.wait('#not-found-page')

where you assigned the #not-found-page ID to the EditorNotFound page.
And that should be a sufficient test for this


sIPS to Public Comment

http://build.fhir.org/ig/IHE/ITI.sIPS/branches/master/index.html

ready for @MaryLJ review of CI build


Cast from 'const struct __CFString *' to 'NSString *' drops const qualifier

I have -Weverything enabled, and I see the following const warnings in Xcode 7.3 now:
/onepassword-app-extension/OnePasswordExtension.m:475:72: warning: cast from 'const struct __CFString *' to 'NSString *' drops const qualifier [-Wcast-qual]
        if (NO == [itemProvider hasItemConformingToTypeIdentifier:(NSString *)kUTTypePropertyList]) {
                                                                              ^
/onepassword-app-extension/OnePasswordExtension.m:485:54: warning: cast from 'const struct __CFString *' to 'NSString *' drops const qualifier [-Wcast-qual]
        [itemProvider loadItemForTypeIdentifier:(NSString *)kUTTypePropertyList options:nil completionHandler:^(NSDictionary *itemDictionary, NSError *itemProviderError) {
                                                            ^

(Sorry for just throwing these over the wall rather than submitting a patch, but I have to go through legal review for any patch submission, and that's a big hassle for me.)

Thanks @hborders. No big deal, I totally understand. As I mentioned in #313, we are not going to support the -Weverything compiler flag, even if I totally understand your situation. This would render the code unreadable and unmaintainable.
I won't be closing this issue as won't do right now, but if you prefer we can take this somewhere more private (support+appex@agilebits.com).
And finally, would the DYI/fork approach be accepted by the legal review?
Please keep me posted.

I don't think my manager would consider it worth our time to review just to disable a few warnings. I'd probably fork it internally if I forked it at all. However, I'd rather not go through the struggle of maintaining the fork, so I'd probably just add the warnings to the list I ignore.

Hello again @hborders,
It all depends, on the API capability that you wish to use. For example findLoginForURLString: hasn't changed in a very longtime, but the collect and fill scripts used in fillLoginIntoWebView: change quite regularly.
I hope that this will help you in making the decision :wink:
Cheers!


wildcard infix not working with RT

Hi,
My thinking_sphinx.yml config
production:
  enable_star: true
  min_infix_len: 2
  min_word_len: 3
  dict: keywords
  mysql41: 9320
  charset_table: "0..9, A..Z->a..z, _, a..z, U+410..U+42F->U+430..U+44F, U+430..U+44F"
  binlog_path: "/XXX/shared/sphinx"
  pid_file: "/XXX/shared/sphinx/search.pid"
  indices_location: "/XXX/shared/sphinx"
  configuration_file: "/XXX/sphinx/production.sphinx.conf"

I do
rake ts:configure
rake ts:start
rake ts:regenerate

When i'm searching wildcard words it's work only with right wildcard.
irb(main):007:0> p = Product.search("*BLH5625*").map(&:sku)
  Product Load (0.2ms)  SELECT `products`.* FROM `products` WHERE `products`.`id` IN (378103, 406360, 378241, 378410, 378474, 384244, 394528, 414826)
=> ["BLH5625", "BLH5625C", "BLH5625", "BLH5625", "BLH5625", "BLH5625C", "BLH5625CSE", "BLH5625CCSE"]

irb(main):008:0> p = Product.where("sku LIKE '%BLH5625%'").map(&:sku)
  Product Load (3342.0ms)  SELECT `products`.* FROM `products` WHERE (sku LIKE '%BLH5625%')
=> ["BLH5625", "BLH5625", "BLH5625", "BLH5625", "BLH5625C", "BLH5625CSE", "BLH5625C", "BLH5625CCSE", "094BLH5625", "094BLH5625CR"]

I have test
Sphinx 2.2.7 /  2.2.8 / 2.2.9
Thinking Sphinx version v3.1.3
Do you see something wrong ?

It's ok , the problem was envionnements


prettyDOM error when container is document

dom-testing-library version: 2.3.2
cypress-testing-library version: 2.0.0
cypress version: 2.1.0
react version: 16.3.2
node version: 8.4.0
npm version: 5.3.0

Relevant code or config:
cy.getByLabelText("something not on the page");

What you did:
I'm selecting an element using getByLabelText, but my code isn't setting the htmlFor correctly, so it couldn't find it.
What happened:

cypress-testing-library passes the window.document as container to the query.
Since getByLabelText can't find the element, it wants to log a friendly error message using prettyDOM.
prettyDOM uses outerHTML.length to determine whether to truncate. However, document.outerHTML is undefined resulting in the error.

TypeError: Cannot read property 'length' of undefined
    at prettyDOM (http://localhost:3001/__cypress/tests?p=cypress\support\index.js-147:898:59)
    at debugDOM (http://localhost:3001/__cypress/tests?p=cypress\support\index.js-147:920:35)
    at getAllByLabelText (http://localhost:3001/__cypress/tests?p=cypress\support\index.js-147:1181:216)
    at firstResultOrNull (http://localhost:3001/__cypress/tests?p=cypress\support\index.js-147:932:30)
    at getByLabelText (http://localhost:3001/__cypress/tests?p=cypress\support\index.js-147:1194:28)
    at container (http://localhost:3001/__cypress/tests?p=cypress\support\index.js-147:82:28)
    at onMutation (http://localhost:3001/__cypress/tests?p=cypress\support\index.js-147:1309:22)
    at http://localhost:3001/__cypress/tests?p=cypress\support\index.js-147:1327:7
    at new Promise (<anonymous>)
    at waitForElement (http://localhost:3001/__cypress/tests?p=cypress\support\index.js-147:1289:10)
From previous event:
    at Context.thenFn (http://localhost:3001/__cypress/runner/cypress_runner.js:56945:26)
    at Context.then (http://localhost:3001/__cypress/runner/cypress_runner.js:57207:21)
    at Context.<anonymous> (http://localhost:3001/__cypress/runner/cypress_runner.js:63338:21)
    at http://localhost:3001/__cypress/runner/cypress_runner.js:63053:33
From previous event:
    at runCommand (http://localhost:3001/__cypress/runner/cypress_runner.js:63043:14)
    at next (http://localhost:3001/__cypress/runner/cypress_runner.js:63125:14)
    at http://localhost:3001/__cypress/runner/cypress_runner.js:63137:18

Reproduction:

I've spent a little bit of time to try and test this, but with JSDOM, this doesn't seem to be easy. prettyDOM(document) crashes before it hits the outerHTML.length part due to pretty-format package (RangeError: Invalid string length).
Full `pretty-format` error

  RangeError: Invalid string length
      at printListItems (node_modules/pretty-format/build/collections.js:105:33)
      at printComplexValue (node_modules/pretty-format/build/index.js:176:141)
      at printer (node_modules/pretty-format/build/index.js:236:10)
      at printObjectProperties (node_modules/pretty-format/build/collections.js:140:21)
      at printComplexValue (node_modules/pretty-format/build/index.js:187:169)
      at printer (node_modules/pretty-format/build/index.js:236:10)
      at printListItems (node_modules/pretty-format/build/collections.js:105:35)
      at printComplexValue (node_modules/pretty-format/build/index.js:176:141)
      at printer (node_modules/pretty-format/build/index.js:236:10)
      at printObjectProperties (node_modules/pretty-format/build/collections.js:140:21)
      at printComplexValue (node_modules/pretty-format/build/index.js:187:169)
      at printer (node_modules/pretty-format/build/index.js:236:10)
      at printListItems (node_modules/pretty-format/build/collections.js:105:35)
      at printComplexValue (node_modules/pretty-format/build/index.js:176:141)
      at printer (node_modules/pretty-format/build/index.js:236:10)
      at printObjectProperties (node_modules/pretty-format/build/collections.js:140:21)
      at printComplexValue (node_modules/pretty-format/build/index.js:187:169)
      at printer (node_modules/pretty-format/build/index.js:236:10)
      at printListItems (node_modules/pretty-format/build/collections.js:105:35)
      at printComplexValue (node_modules/pretty-format/build/index.js:176:141)
      at printer (node_modules/pretty-format/build/index.js:236:10)
      at printObjectProperties (node_modules/pretty-format/build/collections.js:140:21)
      at printComplexValue (node_modules/pretty-format/build/index.js:187:169)
      at printer (node_modules/pretty-format/build/index.js:236:10)
      at printListItems (node_modules/pretty-format/build/collections.js:105:35)
      at printComplexValue (node_modules/pretty-format/build/index.js:176:141)
      at printer (node_modules/pretty-format/build/index.js:236:10)
      at printObjectProperties (node_modules/pretty-format/build/collections.js:140:21)
      at printComplexValue (node_modules/pretty-format/build/index.js:187:169)
      at printer (node_modules/pretty-format/build/index.js:236:10)
      at printListItems (node_modules/pretty-format/build/collections.js:105:35)
      at printComplexValue (node_modules/pretty-format/build/index.js:176:141)
      at printer (node_modules/pretty-format/build/index.js:236:10)
      at printObjectProperties (node_modules/pretty-format/build/collections.js:140:21)
      at printComplexValue (node_modules/pretty-format/build/index.js:187:169)
      at printer (node_modules/pretty-format/build/index.js:236:10)
      at printListItems (node_modules/pretty-format/build/collections.js:105:35)
      at printComplexValue (node_modules/pretty-format/build/index.js:176:141)
      at printer (node_modules/pretty-format/build/index.js:236:10)
      at printObjectProperties (node_modules/pretty-format/build/collections.js:140:21)
      at printComplexValue (node_modules/pretty-format/build/index.js:187:169)
      at printer (node_modules/pretty-format/build/index.js:236:10)
      at printListItems (node_modules/pretty-format/build/collections.js:105:35)
      at printComplexValue (node_modules/pretty-format/build/index.js:176:141)
      at printer (node_modules/pretty-format/build/index.js:236:10)
      at printObjectProperties (node_modules/pretty-format/build/collections.js:140:21)
      at printComplexValue (node_modules/pretty-format/build/index.js:187:169)
      at printer (node_modules/pretty-format/build/index.js:236:10)
      at printListItems (node_modules/pretty-format/build/collections.js:105:35)
      at printComplexValue (node_modules/pretty-format/build/index.js:176:141)
      at printer (node_modules/pretty-format/build/index.js:236:10)
      at printObjectProperties (node_modules/pretty-format/build/collections.js:140:21)
      at printComplexValue (node_modules/pretty-format/build/index.js:187:169)
      at printer (node_modules/pretty-format/build/index.js:236:10)
      at printListItems (node_modules/pretty-format/build/collections.js:105:35)
      at printComplexValue (node_modules/pretty-format/build/index.js:176:141)
      at printer (node_modules/pretty-format/build/index.js:236:10)
      at printObjectProperties (node_modules/pretty-format/build/collections.js:140:21)
      at printComplexValue (node_modules/pretty-format/build/index.js:187:169)
      at printer (node_modules/pretty-format/build/index.js:236:10)
      at printListItems (node_modules/pretty-format/build/collections.js:105:35)
      at printComplexValue (node_modules/pretty-format/build/index.js:176:141)
      at printer (node_modules/pretty-format/build/index.js:236:10)
      at printObjectProperties (node_modules/pretty-format/build/collections.js:140:21)
      at printComplexValue (node_modules/pretty-format/build/index.js:187:169)
      at printer (node_modules/pretty-format/build/index.js:236:10)
      at printObjectProperties (node_modules/pretty-format/build/collections.js:140:21)
      at printComplexValue (node_modules/pretty-format/build/index.js:187:169)
      at printer (node_modules/pretty-format/build/index.js:236:10)
      at printObjectProperties (node_modules/pretty-format/build/collections.js:140:21)
      at printComplexValue (node_modules/pretty-format/build/index.js:187:169)
      at printer (node_modules/pretty-format/build/index.js:236:10)
      at printObjectProperties (node_modules/pretty-format/build/collections.js:140:21)
      at printComplexValue (node_modules/pretty-format/build/index.js:187:169)
      at printer (node_modules/pretty-format/build/index.js:236:10)
      at printListItems (node_modules/pretty-format/build/collections.js:105:35)
      at printComplexValue (node_modules/pretty-format/build/index.js:176:141)
      at printer (node_modules/pretty-format/build/index.js:236:10)
      at printObjectProperties (node_modules/pretty-format/build/collections.js:140:21)
      at printComplexValue (node_modules/pretty-format/build/index.js:187:169)
      at printer (node_modules/pretty-format/build/index.js:236:10)
      at printListItems (node_modules/pretty-format/build/collections.js:105:35)
      at printComplexValue (node_modules/pretty-format/build/index.js:176:141)
      at printer (node_modules/pretty-format/build/index.js:236:10)
      at printObjectProperties (node_modules/pretty-format/build/collections.js:140:21)
      at printComplexValue (node_modules/pretty-format/build/index.js:187:169)
      at printer (node_modules/pretty-format/build/index.js:236:10)
      at printObjectProperties (node_modules/pretty-format/build/collections.js:140:21)
      at printComplexValue (node_modules/pretty-format/build/index.js:187:169)
      at printer (node_modules/pretty-format/build/index.js:236:10)
      at printObjectProperties (node_modules/pretty-format/build/collections.js:140:21)
      at printComplexValue (node_modules/pretty-format/build/index.js:187:169)
      at printer (node_modules/pretty-format/build/index.js:236:10)
      at printListItems (node_modules/pretty-format/build/collections.js:105:35)
      at printComplexValue (node_modules/pretty-format/build/index.js:176:141)
      at printer (node_modules/pretty-format/build/index.js:236:10)
      at printObjectProperties (node_modules/pretty-format/build/collections.js:140:21)
      at printComplexValue (node_modules/pretty-format/build/index.js:187:169)
      at printer (node_modules/pretty-format/build/index.js:236:10)
      at printObjectProperties (node_modules/pretty-format/build/collections.js:140:21)

I believe this can be reproduced by just using cypress-testing-library and selecting something that isn't on the page? I'll do some more testing in the weekend.
Problem description:
prettyDOM function shouldn't assume outerHTML is defined.
Maybe a more accurate description would be: I don't know how to write a test case for this within dom-testing-library to test a pull request.
Suggested solution:
I'm not sure why outerHTML is being used, since it's the debugContent that is being truncated. So my suggestion would be to check debugContent.length instead. Otherwise add an && htmlContent.outerHTML before the length check.

pretty-format bugs out because it tries to print the whole document, which in your case is probably huge, without thinking about string memory limitations. Looks like it cannot apply the DOM plugins and tries to handle it as a regular object.
I believe the best solution would be to check if the htmlElement passed into prettyDOM is actually an HTMLElement, and if it's not, fall back to a shallow (non-recursive) printer. The check could be a naïve duck-typing by outerHTML for simplicity, or a more robust check.
function prettyDOM(htmlElement, maxLength) {
  const debugContent = prettyFormat(htmlElement, {

function prettyDOM(htmlElement, maxLength) {
  if (!htmlElement || typeof htmlelement.outerHTML !== 'string') {
    // TODO: Print a shallow string representation of htmlElement here.
    return;
  }
  const debugContent = prettyFormat(htmlElement, {

pretty-format bugs out because it tries to print the whole document, which in your case is probably huge, without thinking about string memory limitations.

I think you're overestimating memory limits...
The problem is that document doesn't have an outerHTML property.
I think what we need is a check that if the htmlElement is document, then we should get things via document.documentElement.outerHTML. Should be pretty easy.

I'm not sure why outerHTML is being used, since it's the debugContent that is being truncated. So my suggestion would be to check debugContent.length instead. Otherwise add an && htmlContent.outerHTML before the length check.

The reason is because the debugContent includes extra characters for syntax highlighting.

@kentcdodds This error below is about the memory limits, pretty-format cannot build a string such big that it can contain the whole document printed recursively as a plain object.
RangeError: Invalid string length
      at printListItems (node_modules/pretty-format/build/collections.js:105:33)
      at printComplexValue (node_modules/pretty-format/build/index.js:176:141)
      at printer (node_modules/pretty-format/build/index.js:236:10)

I think what we need is a check that if the htmlElement is document, then we should get things via document.documentElement.outerHTML. Should be pretty easy.

Even if you get document.documentElement.outerHTML for the check below prettyFormat call, the prettyFormat call may still fail on the document (at least this is what we see with jsdom, maybe because it's not a real DOM and pretty-format DOM plugins check instanceof or something).

Aahhh, gotcha. Maybe we should also allow for not using pretty-format or maybe not logging the DOM at all? Then cypress-testing-library can opt-into that. Cypress has better ways of inspecting the DOM anyway.

This isn't just about Cypress, the same can be reproduced with getByLabelText in dom-testing-library, it calls debugDOM with container that can easily be the document.

I was suggesting that we do both. In the cypress situation it's more likely to run into the memory issue than in a JSDOM situation where you're normally not rendering as much DOM, so it shouldn't be necessary to opt-out of the prettyFormat stuff there (like it would be in cypress). But in both cases we should add a check for document and use document.documentElement instead in that case.

I was suggesting that we do both. In the cypress situation it's more likely to run into the memory issue than in a JSDOM situation where you're normally not rendering as much DOM, so it shouldn't be necessary to opt-out of the prettyFormat stuff there (like it would be in cypress). But in both cases we should add a check for document and use document.documentElement instead in that case.

👍 Yes, agree.

When I pass the actual document (window.document within Cypress) to pretty-format, I get the following output:
"HTMLDocument {
  "_reactListenersID9641284360997817": 0,
  "location": Location {
    "ancestorOrigins": DOMStringList {
      "0": "http://localhost:3001",
    },
    "assign": [Function],
    "hash": "",
    "host": "localhost:3001",
    "hostname": "localhost",
    "href": "http://localhost:3001/some/path",
    "origin": "http://localhost:3001",
    "pathname": "/some/path",
    "port": "3001",
    "protocol": "http:",
    "reload": [Function],
    "replace": [Function],
    "search": "",
    "toString": [Function],
    Symbol(Symbol.toPrimitive): undefined,
  },
}"

I think what we need is a check that if the htmlElement is document, then we should get things via document.documentElement.outerHTML. Should be pretty easy.

htmlElement instanceof HTMLDocument doesn't work in Chrome.  So I added a simple check for documentElement
if (htmlElement.documentElement) {
  htmlElement = htmlElement.documentElement;
}

Now I get the <html> node. outerHTML.length is 100285. debugContent.length is 201056.

I was suggesting that we do both. In the cypress situation it's more likely to run into the memory issue than in a JSDOM situation where you're normally not rendering as much DOM

So in Cypress situation, I'm not running into memory issues. As for JSDOM, I was just passing in the Jest global document into prettyDOM, which made it crash. So at most, the two <div> elements from previous tests were rendered (AFAIK).
Cypress' Command Log showed the error:

The colors aren't working, but if Cypress is opting out of pretty-format, that won't be a problem. If we were to log information about the document, I think <body> is more useful compared to <html>, because logging the contents of <head> is probably not very helpful.
When I use the documentElement code with jsdom, prettyDOM returns
<html>
  <head />
  <body />
</html>

So to summarize:

Use documentElement within prettyDOM when available.
Create opt-out mechanism to not log DOM.
Use opt-out in cypress-testing-library.

Is that correct?
About the opt-out mechanism, how would you like to see that implemented? As an extra option to query functions? As an environment variable (not sure how cypress-testing-library would use that...)?

Actually, I wonder if we could be smarter and rather than opting out we just somehow determine whether we're in node or browser and only format in node. That would fix issues when running test in codesandbox as well.

Actually, thinking about it further I think we have three cases:

Running in node? Highlight and format
Running in Cypress? Don't even log it.
Running in a browser (but not Cypress)? Format only.

Because I think it would still be valuable to have the log in codesandbox/a browser, just not in cypress. I'm not sure of the best way to accomplish this though. Ideas/PRs welcome

We could do something like:
function debugDOM(htmlElement) {
  const limit =  process.env.DEBUG_PRINT_LIMIT || 7000
  if (typeof window !== 'undefined') {
    if (window.Cypress) {
      // don't log anything
      return ''
    }
    if (window.document) {
      // format only
      return `\n\n${prettyDOM(htmlElement, limit, { highlight: false })}`
    }
  }
  // format and highlight
  return `\n\n${prettyDOM(htmlElement, limit)}`
}

prettyDOM would merge the 3rd parameter with the options it creates for pretty-format.

Thanks for that. At first I was going to say I didn't want to handle the cypress use case in this library because it feels like the wrong place for this abstraction, but I think that it's not really a big deal so let's go for it. A PR would be appreciated! Thanks!
Actually, thinking about it further, I'm not sure that this will work in codesandbox because I think module and module.exports are defined in codesandbox/webpack situations. Could you test this out in codesandbox to be sure?

Actually, thinking about it further, I'm not sure that this will work in codesandbox because I think module and module.exports are defined in codesandbox/webpack situations. Could you test this out in codesandbox to be sure?

When running in codesandbox, all relevant tests pass (after some minor changes, see SANDBOX_CHANGES.md).
In other words, it uses the Node logging; highlight and format. So the question is whether this is undesirable. I think it's better to use Node logging, since it matches what will happen when testing using Node or npm scripts. Otherwise the environment change will break test snapshots.
I tried checking process.title (inspired by this StackOverflow answer), which apparently is set to 'browser' in codesandbox. When running the tests through npm t locally, it's set to 'npm'. So if we want to use browser logging and it's not considered too hacky ;), we could do:
function debugDOM(htmlElement) {
  const limit =  process.env.DEBUG_PRINT_LIMIT || 7000
  const inNode = (typeof module !== 'undefined' && module.exports)
  const inBrowser = (typeof window !== 'undefined' && window.document)
  const inCypress = (typeof window !== 'undefined' && window.Cypress)
  const inCodesandbox = (typeof process !== 'undefined' && process.title === 'browser')
  if (inCypress) {
    // don't log anything
    return ''
  }
  if ((inBrowser && !inNode) || inCodesandbox) {
    // format only
    return `\n\n${prettyDOM(htmlElement, limit, { highlight: false })}`
  }
  // highlight
  return `\n\n${prettyDOM(htmlElement, limit)}`
}


Possibility to operate in a different Exchange

Describe the solution you'd like
Hello folks, I've recently assigned a VIP group on telegram where I get information about PUMP in advance, however, the Exchange they are using is Hotbit, the exchange is crap and very slow, and they do not operate using Market price in most of the coins, so it's difficult to operate PUMS manually on it, is there any possibility of connecting this bot to Hotbit and help me to get the Pump using this script?

From googling around, there is an API for it but it isn't written in Python so would require a lot of time & effort to implement it so the short answer is no. Sorry!


[🐛 Bug]: Dynamic routes and images don't work

next-on-pages environment related information
System:
        Platform: linux
        Arch: x64
        Version: #26~22.04.1-Ubuntu SMP PREEMPT_DYNAMIC Thu Jul 13 16:27:29 UTC 2
        CPU: (8) x64 Intel(R) Core(TM) i7-6700HQ CPU @ 2.60GHz
        Memory: 15 GB
        Shell: /bin/bash
Binaries:
        Node: 18.16.0
        Bun: N/A
        pnpm: 8.6.12
        Yarn: 1.22.19
        npm: 9.5.1
Package Manager Used: pnpm
Relevant Packages:
        @cloudflare/next-on-pages: 1.5.0
        vercel: 30.0.0
        next: 13.4.13

Description
Dynamic routes and images don't work. I've tried to deploy the same app on Vercel, and then it worked properly, but didn't work on Cloudflare.
I've tried the beta version, still the same result:
20:50:53.247 | Executing user command: npx<EMAIL_ADDRESS>20:50:59.584 | ⚡ @cloudflare/next-on-pages CLI v.0.0.0-705a95b (beta/canary release)
20:50:59.587 | ⚡ Detected Package Manager: pnpm

Update
I found the error in the build logs:
20:52:08.023 | ⚡ Watch mode unexpected error: SyntaxError: Unexpected token (270:4)

What should I do to fix it?
Reproduction
Related to: https://github.com/cloudflare/next-on-pages/issues/32#issue-1465045099 https://github.com/cloudflare/next-on-pages/issues/344

Solution
I solved the problem by upgrading the vercel package from 30.0.0 to 31.2.3. I should also mention that the solution to the not-found error https://github.com/cloudflare/next-on-pages/issues/413 is to add the vercel package to your project, not to update @cloudflare/next-on-pages (my own experience).
Also pnpm showed a warn in the terminal. I ignored this one and it's working properly now:
 WARN  Issues with peer dependencies found
.
└─┬ @cloudflare/next-on-pages 0.0.0-705a95b (beta)
  └── ✕ unmet peer<EMAIL_ADDRESS>found 31.2.3

@dario-piotrowicz and I thank you for your contribution and effort. Although Next.js applications seem to run smoothly on Vercel, I think Next.js is a framework that has not yet been completed. Unfortunately, it is difficult for Cloudflare (maybe you :)) or other environments to keep up with it.
Yes, I guessed why the warning came out.

not to update
ah I misread your comment 👀 , so you need to use an older version of next on pages??? 😕

Regarding your comment, yes it's difficult to keep up 😅 😓
But the main reason isn't really because the framework is evolving but because vercel can generate things that either don't follow precisely their specs or also generate serverless functions (that are not edge compatible) when it shouldn't
Basically the fact is that Vercel is the creator of Next.js so, although it is an open source project they can make it more compatible/convenient for their network, and since the Vercel and Cloudflare networks are pretty different this adds a lot of complexity/problems 😓

@dario-piotrowicz  I totally agree with you. Sometimes I question myself whether to use Next.js or not. By the way, I use the latest version of next-on-pages now. There doesn't seem to be an issue.


add caller info to the testHook

issue: https://github.com/containerd/containerd/issues/5093
It may be inconvenient to have no caller information in the test log when a problem occurs.
output:
=== RUN   TestLogTest
    log_hook.go:40: time="2021-02-27T02:19:31.384471000+08:00" level=info msg="test message" func=logtest.TestLogTest file="/Users/icebergu/workspace/containerd/log/logtest/context_test.go:12"
--- PASS: TestLogTest (0.00s)
PASS
ok      github.com/containerd/containerd/log/logtest    0.008s

/ok-to-test

/retest

/test CI / Linux Integration (io.containerd.runc.v1, runc) (pull_request)


codeunit 248 "VAT Lookup Ext. Data Hndl" - OnPrepareSOAPRequestBodyOnBeforeSetAccountDetails

Describe the request
In codeunit 248 "VAT Lookup Ext. Data Hndl" is the publisher OnPrepareSOAPRequestBodyOnBeforeSetAccountDetails called with false parameters
Additional context
        if VATRegistrationLog.GetAccountRecordRef(RecordRef) then begin
            AccountName := GetField(RecordRef, Customer.FieldName(Name));
            AccountStreet := GetField(RecordRef, Customer.FieldName(Address));
            AccountPostCode := GetField(RecordRef, Customer.FieldName("Post Code"));
            AccountCity := GetField(RecordRef, Customer.FieldName(City));
-           OnPrepareSOAPRequestBodyOnBeforeSetAccountDetails(RecordRef, VATRegistrationLog, AccountName, AccountStreet, AccountPostCode, AccountCity);
+           OnPrepareSOAPRequestBodyOnBeforeSetAccountDetails(RecordRef, VATRegistrationLog, AccountName, AccountStreet, AccountCity, AccountPostCode);
            VATRegistrationLog.SetAccountDetails(AccountName, AccountStreet, AccountCity, AccountPostCode);
        end;

Internal work item: AB#501571

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 16627.


Register an EKS cluster: Add documentation

add a section covering here on how to register an EKS cluster to be managed by Sveltos

Working on it. A new PR will be available today.

PR #355 was raised

PR merged to main. The issue can be closed.


Add order to config spec

What does this PR do?

Add order to config spec.
In some case, we might want to reorder some inherited configs.
Default order is 0. High order will be displayed first.
Motivation

For example, jmx integration can use either host + port configs or jmx_url config.
For most integrations we want to use host + port configs first, but some integrations like jboss_wildfly need jmx_url (different protocol), in that case, we want to reorder to make jmx_url to appear first.
Related PR: https://github.com/DataDog/integrations-core/pull/6225
Additional Notes

Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] PR title must be written as a CHANGELOG entry (see why)
[ ] Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
[ ] PR must have changelog/ and integration/ labels attached

@hithwen Could you have a look again, I changed the impl to Default order is 0. High order will be displayed first..
That way, it's also easy to put something at the end without having to set the order of the other elements. e.g. order: -100


Finished with centered styling only

Styling is not sufficient, but the application is functional.
:+1:


clear env vars before running 'bosh login'

this will only unset the bosh variables if you run bucc bosh
was this the idea?

Yes. I don’t know how bucc bosh ever worked for anyone in normal usage. Without this change, bosh login does nothing for me if the BOSH_CLIENT etc are set. You?


HELP NEEDED: does user access_hash expires ?

I get the PEER_ID_INVALID error when i use getUsers method, i understand why i get this error, but afaik, if i have the user id & access_hash it should work, so i wanna know if access_hash expires or what, if it is true, how am i supposed to get a users details by this method if i have his/her telegram id but not the access_hash (have but the expires one) ? if i am correct, tell me the duration in which the access_hash expires, if i made a contact again with the user does it reset (the access_hash timer resets ?)

Once the access_hash doesn't work that means you don't have the right to access to that user. It doesn't matter if it expires or not.

it does matter, if the access_hash doesn't work that means it expired or something, and this happens i wanna know why and how much is needed to expire, or something else is causing it.


Return up to date CustomerInfo

I have added a method to IRevenueCatBilling and an implementation on each platform that return the latest CustomerInfoDto on request. I have also added CustomerInfo to the return of the Purchase method. Combined, this means the latest CustomerInfo can be obtained at every useful opportunity.

This will fix #22 and #33.

Thank you for the new contribution! In following 2 days I will take a look.


Code Coverage not getting collected for some assemblies

Description

No code coverage data available for some assemblies

Steps to reproduce

git clone https://github.com/dotnet/reactive

Make sure to have a 2.1.4xx dotnet available.(https://dotnetcli.blob.core.windows.net/dotnet/Sdk/2.1.400-preview-008975/dotnet-sdk-2.1.400-preview-008975-win-x64.exe)

Go to Ix.NET\Source

Run dotnet test .\System.Interactive.Async.Tests.csproj --collect:"Code Coverage" -f netcoreapp2.1 /p:DebugType=portable

Look at the coverage reports and you won’t find System.interactive.Async.dll in there.
Expected behavior

Coverage data should be collected for System.interactive.Async.dll

Actual behavior

No coverage data available for System.interactive.Async.dll

/cc @onovotny

I have debugged this issue found that  System.interactive.Async code coverage not available because DIA api not able to load the  System.interactive.Async.pdb.
@mayankbansal018 Can you please take a look at this?

What was the error thrown by DIA API's? If we are sure that it is DIA issue, can you create an internal bug, & assign it to DIA team.

@tmat, can you please take a look, coverage file is generated is debugtype is full, for portable it is not. I've also dropped a mail to you internally

This is issue due to bug in DIA apis. @VCZYK has fix for it. I will update regarding fix release ASAP here.

Any updates on this in terms of a servicing vehicle? When/where can we expect to see this fix?

Closing this as it has been fixed.

Thanks @karanjitsingh. What version of the test SDK has the fix in it?

@onovotny, I truly apologize for this but I was mistakenly under the impression that the DIA api fix had gone in, I tried the repro with the latest version and it seems that it has not been fixed. Reopening the issue.

@mayankbansal018 I'm seeing this issue with the latest 16.0 preview test SDK's.
No code coverage:
https://dev.azure.com/dotnet/Rx.NET/_build/results?buildId=10303
Added /p:DebugType=Full has coverage:
https://dev.azure.com/dotnet/Rx.NET/_build/results?buildId=10304
That was the only change.


Support ordering of entity statistic value outcomes

Should allow configuration of ordering and possibly colours of the outcome values

Perhaps this should be a generic enum service ?
| enum_kind |  code |  priority | display_name | color_fg |  color_bg |

May need some other mechanism for number/percentage types though.
May be just order by value in those cases?

start and end value colours ?

Scratch that - it's a bad idea


Improve param decorators

This PR fixes 2 bugs in ConfigParam() and Configurable() decorator

ConfigParam() decorator set metadata to the target: Reflect.defineMetadata(CONFIG_PARAMS, existingParameters, target), but always retrieved it from target's property: Reflect.getMetadata(CONFIG_PARAMS, target, propertyKey). So previous metadata was deleted if decorator was called 2 times or more on the same method.

Utility applyParamsMetadataDecorator() set config param to the argument only if the argument exists and it's an object (some unsafe condition as for me). So ConfigParam() decorator worked only the ConfigService() was injected on the argument's place.

But it's a  fact that ConfigService may be not injected in all required places (check additional tests).
So I also added improvements to the applyParamsMetadataDecorator() utility.
P.S. Probably it is't a question to the nestjs-config and not a topic of this PR, but when Configurable() decorator applied to the controller method and it was placed to top of order - it breaks other decorators.
  @Configurable()
  @Get('cats')
  @UseInterceptors(MyInterceptor)
  public getMostLikedPosts(@ConfigParam('key') key):  {
    return [];
  }

I think it's because it replaces original method with own function.
It will be nice to have some note in the Readme that Configurable() decorator must be the last.

Pull Request Test Coverage Report for Build 89

9 of 9 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+1.4%) to 93.443%

Totals

Change from base Build 84:
1.4%

Covered Lines:
131

Relevant Lines:
131

💛  - Coveralls

Could you add a note to the readme about the @Configurable decorator underneath the decorator code example please :) https://github.com/nestjs-community/nestjs-config#decorators
Other than that it looks pretty cool! Thanks :)

Readme is updated with the description and examples.
Also I've created  an issue on nextjs repository for this behavior - https://github.com/nestjs/nest/issues/1180

Is this only happening in your PR though?

No, this is behavior of the current nestjs-config version (1.2.4) and it also reproduces in the PR.
Unfortunately I could not fix it

PR updated.
@shekohex , I've updates parameter types in the tests and Readme as you asked.
Also I've added more strict checking and some comments to applyParamsMetadataDecorator util.


input type="tel" with expiration date on iPhone

The CVV has input type="tel", which summons the numeric keyboard. The numeric keyboard is great, but it doesn't have a slash. On-phone screenshot is included below for reference.

Are we guaranteed that submitting an expiration without a slash will in fact work?
Can we pass some parameter through to braintree-web to make the expiration date display use a normal keyboard? I imagine that some users when confronted with that incongruity will simply give up, because we are a non-profit soliciting donations, not selling products.

Hey @NealJMD, unfortunately this is a known and expected behavior in iOS for all current versions of Hosted Fields (this has been brought up previously in #81). We accept both MMYY and MM YY formats for date, so any legitimate expiration date without a slash will be valid.
One alternative is to break your expirationDate into two separate expirationMonth and expirationYear fields. We know this isn't ideal and will hopefully have a nicer solution for you soon!

Here's an idea Braintree - after the user has entered 2 characters (01-12) why don't you automatically insert the / for them?
That way they don't need that character on the keyboard. I've seen that done in other places and it works well.

@skiddle Field formatting is something that we are actively working on! Stay tuned.
See https://github.com/braintree/braintree-web/issues/77

okey-dokey. I am eagerly awaiting the field formatting - product guy is breathing down our neck about it. thanks for the response.

Just ran into this and was about to contact support. Super disappointing. Doesn't it seem wrong that you'd use a Telephone type field for date entry?

We have this issue as well on a ecoommerce site and it causing sales to be lost. Is there a workaround  or when is a fix going to be released?

@adstrakt I emailed BT and Tech Support wasn't much help. I ended up just removing the "/" from my expiration date field placeholder. It's not quite as intuitive, but it was an easy fix. Support told me I could also do two fields -- one for month and one for year just as @lilaconlee mentioned above.
The really issue here is that we're likely not the only ones who are losing sales because of these recent change. My guess is more people will find this thread once they realize people haven't been able to purchase using a credit card on the iPhone.
Tech Support also suggested I follow the changelog here, but as you can see if you read it, this change was not documented (at least not that I saw).
And still I do not understand why a telephone field was used for credit card. Even the UI of the telephone keyboard is a bit confusing. Why not number?

I hope they realize this and sort it soon.

In an ideal world, the expirationDate field would pull up a numeric keyboard that also had a / slash key, and that'd be it. Unfortunately, this is the world of web browsers, where things are rarely ideal (especially on the mobile web!).
We considered this when building Hosted Fields. There were basically four input types we could've chosen:

text. This does nothing fancy on desktop browsers, but mobile browsers will bring up a normal, alphabet keyboard (with an English keyboard, anyway). We eliminated this pretty quickly, because this is not the ideal keyboard to show:

date was another we eliminated quickly, because it asks for year, month, and day—card expiration dates don't have a day.

number. On mobile browsers, this brings you to the numeric part of the keyboard by default, but you can navigate around and type whatever other characters you want. This is okay, but you can still type characters you shouldn't be able to type.

This has bad UX on modern desktop browsers, though. Check out what Chrome does:

Modern desktop browsers bring up a little number counter, which we felt was confusing—that's not something people are used to seeing in a card expiration date field.

tel, which is what we settled on. This doesn't do anything weird on desktop browsers, but it shows a keyboard that's pretty close to exactly what we wanted:

We felt that this was best. Our ideal world, as mentioned above, is a numeric keyboard with a slash key—this is pretty close.

The tel type absolutely has the disadvantage that there can be some customer confusion with the slash—we totally agree with you, @scottymac. But the number type has disadvantages of its own, as we discussed above.
There are two ways around this if you still don't like our decision:

Update your placeholder as @scottymac has done. If you want, you can change this placeholder dynamically based on browser:
braintree.setup(CLIENT_TOKEN, 'custom', {
  hostedFieds: {
     // ...
     expirationDate: {
       selector: '#bt-expiration-date',

       // Change the placeholder based on a `browserIsIos` variable you define.
       placeholder: browserIsIos ? 'MMYY' : 'MM/YY'
     }
  }
})

Use a separate field for expiration month and expiration year, as @lilaconlee suggested above. Once again, you can choose to do this differently on iOS.

We're also actively working on automatic field formatting for future versions of the SDK (as @skiddle mentioned), which will automatically insert the slash. That and the fixes above will (hopefully) put this problem to rest. (Stay tuned to issue #77 for updates on field formatting.)
Hope this helps explain our decision!

Thanks for the comprehensive explanation @EvanHahn. Not ideal but changing the placeholder is a good enough workaround for now.
Thanks

@dedman As @evanhahn mentioned above, the latest version of our SDK has formatting in Hosted Fields, which includes automatic insertion of slashes in expiration dates.
If you're interested in trying it out while it's in beta, here are some links to official documentation:
Setup for v3
Migrating from v2 to v3
Hosted Fields in v3


my .obj can not show in this way ,but the website-demo does

my .obj can not show in this way ,but the website-demo does

This is not very useful in I cannot understand what is working and what is not.
Ideally you could provide the OBJ file.  A fork of the code with the changes you made so I can review.  And a screen capture showing how it appears to you with a description of how you expect it to look.


[docs] Update Java 17 compatibility docs

Updates docs to match current state. In practice we already see usage with Java 17.

Thanks. Overall, I think the tone is a bit too much like a blog post, and a not enough like a documentation that you use as a reference.

Thanks. Overall, I think the tone is a bit too much like a blog post, and a not enough like a documentation that you use as a reference.

Thanks, updated accordingly.


[Ionic 4.0.0-beta.6] ion-range know vertical alignment while in minimum position

Bug Report
Ionic Info
   ionic (Ionic CLI)          : 4.1.1
   Ionic Framework            : @ionic/angular 4.0.0-beta.6
   @angular-devkit/core       : 0.7.0-rc.3
   @angular-devkit/schematics : 0.7.0-rc.3
   @angular/cli               : 6.0.8
   @ionic/ng-toolkit          : 1.0.0
   @ionic/schematics-angular  : 1.0.0

Describe the Bug
Knob in ion range is moved down a few pixels in min position.
Steps to Reproduce
Create an ion-range element and drag the knob to the min position.
Related Code
I believe this is due to applying the border to the range-knob element while in minimum position but not appropriately adapting margin-top setting.
Expected Behavior
Range knob should also be vertically centred when in minimum position.

So should be resolved with beta.17, so I close this issue here. If I am wrong just write here and I reopen it!


enhancement: OTA updates

Would be good to support Over The Air updates for the MQTT gateway (as that has WiFi enabled by default) and eventually the UART gateway and remote devices.   For the UART gateway and remote devices maybe have a button ( would need to be added and could support other functionality in addition) that, if held down for 5 seconds or so, would enable WiFi and receive OTA updates?
Thoughts?

OTA updates are quite powerful, I use them for the ESPs in my home.
But I think the Sensors, once working should be fine without OTA updates. And if you go to them to press a Button for updates, you could also be standing there with your laptop for 30 seconds to update via serial.
Also the WIFi range is not that big so you would have to bring the node closer to your router to update (assuming you have a more distributed network in the field).

I mean, actually with sensors I guess you are free to add whatever capability you like since it's just a library. Especially since it sounds like it would be a fully separate mode. I just don't think it's within the scope of FDRS to handle. Maybe for MQTT mode if it's super-unobtrusive.

Low priority issue to be taken up later after higher priority jobs are completed.


feat(env list): allow specifying a jsonnet implementation

This will allow us to run this with jrsonnet, making it way faster

@julienduchesne nice job, I was waiting for this!
Sadly, currently this seems incompatible with tanka.helm:
$ tk eval --jsonnet-implementation 'binary:/usr/bin/jrsonnet' environments/prod/main.jsonnet
Error: evaluating jsonnet: error running file redacted/tanka/environments/prod/main.jsonnet: exit status 1
only functions can be called, got null
    vendor/github.com/grafana/jsonnet-libs/tanka-util/helm.libsonnet:48:21-31:   variable <chartData> access
    vendor/github.com/grafana/jsonnet-libs/tanka-util/k8s.libsonnet:43:7-14:     variable <object> access
    vendor/github.com/grafana/jsonnet-libs/tanka-util/k8s.libsonnet:13:21-28:    variable <object> access
    argument <v> evaluation
    vendor/github.com/grafana/jsonnet-libs/tanka-util/k8s.libsonnet:13:8-29:     function <builtin_is_object> call
    vendor/github.com/grafana/jsonnet-libs/tanka-util/k8s.libsonnet:13:16-13:17: if condition
    vendor/github.com/grafana/jsonnet-libs/tanka-util/k8s.libsonnet:42:6-42:7:   function <patchKubernetesObjects> call
    vendor/github.com/grafana/jsonnet-libs/tanka-util/helm.libsonnet:48:5-52:    function <patchLabels> call
    lib/redacted/argocd.libsonnet:75:6-75:7:                                         function <template> call
    field <argocd> manifestification

I cannot get this to render by passing just ./vendor and ./lib folders to the native jsonnet binary either.
Since tk eval works perfectly fine on the same code I suspect there might be additional magic hidden somewhere in tanka one might need to pass to external binary invocation as well.

Yup, no native functions. Hide any attribute that isn't a Tanka env


[dvsim] Update tests key behavior in regressions

This was encountered in #3040. The common_sim_cfg.hjson adds a
sanity regression target without specifying the tests key, with the
assumption that each individual IP's cfg hjson will update the sanity
regression with the required list of tests. In PR #3040, the sanity
tests in some of the IPs had to be commented out due to some other
issues. But on doing so, running sanity regression ended up adding ALL
available tests for regression for that particular DUT, since the tests
key remained empty list (originally intended behavior). This caused the
private CI to blow past the 20 minute time limit and fail. This PR fixes
that behavior.
Previous behavior of the tests key was as follows:

tests member of class Regression in Modes.py defaulted to empty
list
If in regressions (in the hjson), it continues to remain an empty
list after all hjson source are parsed, then ALL available tests are
run

New behavior is as follows:

tests member of class Regression in Modes.py now defaults to
None
If in regressions (in the hjson) it is set to an empty list, and
eventually remains an empty list after all hjson sources are parsed,
then no tests are run
If in regressions (in the hjson) it is entirely omitted, such that
after all hjson sources are parsed, it continues to hold the value of
None, then ALL available tests are run

Signed-off-by: Srikrishna Iyer<EMAIL_ADDRESS>

I am merging this PR so that #3040 is unblocked. I will address the review comments shortly.


getting playlists with webclient

This is not really an issue, but some information I've found and tested for retrieving playlists with web API, in case someone is interested. I know the webclient is kind of becoming deprecated but it still has its use. Moreover, the web API returns jsarray, which although annoying to parse, is a tad faster to parse than regular json. That's probably why Google use that on the web: to make loading as fast as possible.
Assuming you have a playlist id (an uuid), this call return the content of the songs contained in the playlist in correct order, in jsarray format:
POST request:  https://play.google.com/music/services/loaduserplaylist?u=0&xt=...&format=jsarray
POST body: [["",1],["<playlist id>"]]
Response:
[[0,1]
,[[["5084d42c-884d-3440-aa8b-f78edba2199b","Steppingfilter 101","//lh3.googleusercontent.com/-Kwc9kOmSIy4yDZBHYWS9MzJb2GfSDgom1gMWr1vaJ3re3_BXIbnsfVgt0_c","Aphex Twin","Analord 01","",,,,,"","Abstract",,286000,1,7,0,0,2005,0,,,0,0,1379338055004349,1379745960008708,,,,2,"",,,"Acirogtcm4nkyvhghrt3bguv3tu",189,1379338078777000,,,,[]
,,,,"66c4cab3-ba67-3e99-b186-0c5bff6469f6"]
,
song 2 as jsarray,
...,
song n as jsarray,

What's interesting is that you get all the songs of a playlist with a single call (no indirection like in the mobile client) including any All-Access songs
Now the problem, is that I did not found a web API to retrieve the list of playlists (that is: their name and id among other attributes), eg the equivalent of mobileclient.ListPlaylists.
It seems that this info is buried in the response to the very first request that the Google Music web app makes to play.google.com, buried in a massive amount of HTML.
If anyone can find a way to list playlists with a web API call, that would be awesome.

I'm going to close this issue since it's pretty old.
As an aside, it looks like setting format=json actually works these days. That could make a lot of webclient requests viable again if we can also figure out an easy way to get the request schemas in json.


[Bug] Wrong device placement for tf.constant with int32

Colab example: https://colab.research.google.com/drive/1iCyTZhKzco4CjxY17g37jKG9GS35-NGb
Remember to use GPU instance
When dtype is int32, tf.constant didn't place tensor on gpu but cpu.
with tf.device("/gpu:0"):
  a = tf.constant([0,1], dtype=tf.float32)
print(a.device)
# '/job:localhost/replica:0/task:0/device:GPU:0'

with tf.device("/gpu:0"):
  b = tf.constant([0,1], dtype=tf.int32)
print(b.device)
# '/job:localhost/replica:0/task:0/device:CPU:0'

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow):
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Ubuntu 16.04
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device:
TensorFlow installed from (source or binary):
TensorFlow version (use command below): 2.0.0
Python version:
Bazel version (if compiling from source):
GCC/Compiler version (if compiling from source):
CUDA/cuDNN version:
GPU model and memory:

I have tried on colab with TF version 2.0 and was able to reproduce the issue.Please, find the gist here.Thanks!

I think this is intentional, see for example this comment: https://github.com/tensorflow/tensorflow/blob/master/tensorflow/python/eager/pywrap_tensor.cc#L352-L379

I didn't find any documentation about this and it makes no sense to me (although it's intentional). You can add op like constant_cpu to force allocating tensor on cpu, but should not break the consistence without any documentation.

At least it should have some logs telling user it's allocated on cpu

@VoVAllen I'd be happy to review PRs adding documentation / logging that would have helped you figure this out more easily.
CC @jaingaurav

I believe this is intentional as can be seen in #28051.

@samikama I would say although it's intentional it's also necessary to mention it somewhere in docs, since this is super counter intuitive. I'm not sure that whether all the output of int32 will on the cpu, so I'm afraid I may not be able to help on the documentation.

A fix went in for this and other problems with tf.constant in 97cdd4d16a81a349696f10451b7d564bfa99664f, which will make it create CPU tensors irrespective of device settings. This fixes other bugs, including one often requested one for "always placing string tensors on the CPU." The documentation was updated to be explicit about this.
There were a few solution alternatives, but the "always CPU tensor" was the most consistent, simple, and the only one which did not introduce performance regressions. One of the ideas behind the solution is that the constant you create with, say,
x = tf.constant(very_large_numpy_array)

Is both potentially large, and already on the CPU, so it makes sense for tf.constant to just keep things there. With the default device policy (see tf.config.experimental.set_device_policy), the CPU tensor will be automatically copied to the GPU whenever needed (only once, and the copy will be cached so there's no performance drawbacks). If you want to explicitly place the tensor on the GPU (essentially controlling when the  copy happens), you can use tf.identity under the proper tf.device context.

That makes more sense if the gpu copy is cached. I discovered this problem when debugging with tf code's performance. Let's say if I had an op gather_row(index, tensor) and index is tf.int32. And it executes on gpu and requires both index and tensor on gpu. So the index here would be copied only once for multiple execution, right?

So all tensors created with tf.constant are now on host memory irrelevant to the device context now? No matter what its type is?

@VoVAllen: You are absolutely correct about the caching and as part of this placement policy we have added the functionality such that the GPU copy is indeed cached.

Closing the issue since I believe this issue is now resolved. However, please feel free to continue discussion or ask questions.


review - last step

🤔 해결하려는 문제가 무엇인가요?

close #185

🎉 변경 사항

마지막 폼 생성 안내를 하는 스탭을 만들었어요

CTA 버튼을 눌렀을 때 수행하는 로직은 API 이후 작업이 필요해요

🌄 스크린샷
https://github.com/depromeet/na-lab-client/assets/26461307/3d343e12-da93-4061-9cf0-b13f7f1cdef0

Codecov Report
Patch and project coverage have no change.

Comparison is base (01dd6e6) 92.52% compared to head (f78a4a5) 92.52%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #187   +/-   ##
=======================================
  Coverage   92.52%   92.52%
=======================================
  Files          38       38
  Lines         281      281
  Branches       52       52
=======================================
  Hits          260      260
  Misses         21       21

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Query string doesn't update from manually entered URL

When editing a query string in a browser's URL bar, the associated page doesn't always rebuild.
This only happens on the web.

Nope, just a bug in the sample app 😁
Phew!


R1.13

merge master an 1.13

Hi Davari393@,
I'm not sure what you're trying to do here, but I'l pretty sure this isn't the right way to do it.
Is there some fix from the 1.13 branch that never got merged to master?


Update d3dxsaveprtbuffertofile.md

The PRT file format is opaque, but it's trivial and should be documented.

@walbourn : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@stevewhims : Thanks for your contribution! The author(s) have been notified to review your proposed change.


NA - If less than 3/5 cards are available due to immobile/stun, macro will get stuck.

I was farming one of halloween nodes and the script always get stuck if there is only 2 cards available due to my other characters being "immobile" or "stunned". It seems the script won't choose those cards which make sense, but the script will get stuck if only 2 cards are usable.

Sorry let me clarify, if you  have NP spam on, and the character is immobilized, that's where it seems to get stuck.

https://github.com/29988122/Fate-Grand-Order_Lua/issues/88
Also check #88


Add routes for performing a traversal on sets of identifiers

Related to #234
Given a starting set of nodes (e.g. a list of human gene IDs), perform a traversal (e.g. gene->protein) on all, and return the resulting graph.

input: list of IDs
params: path
output: map between ID pairs, plus list of unresolved


Pnpm CLI option not recognized

Describe the bug
The new cli option for pnpm and disablePnpmAudit are not recognized on the cli.
Version of dependency-check used
The problem occurs using version 6.5.0 of the cli.
Log file

Unrecognized option: --pnpm

To Reproduce
Steps to reproduce the behavior:

Download latest release (windows or Linux)
Install
.\dependency-check.bat --version
output: Dependency-Check Core version 6.5.0
.\dependency-check.bat --pnpm c:\path -s C:\secondpath
output: Unrecognized option: --pnpm

Expected behavior
I expect both --pnpm and  --disablePnpmAudit to be recognized by the CLI.
Additional context
>.\dependency-check.bat --disablePnpmAudit
Unrecognized option: --disablePnpmAudit

I would say there is more related to this issue because my entire Azure DevOps pipeline is failing with the following exception:
[ERROR] Exception occurred initializing Pnpm Audit Analyzer.
...
[ERROR] Unable to read pnpm audit output.
##[debug]2 final results
[ 'Source\dep\dependency-check-report.html',
'Source\dep\dependency-check-report.json' ]
Dependency Check failed with message "Dependency Check exited with an error code (exit code:<PHONE_NUMBER>)."
##[debug]task result: Failed
##[error]Dependency Check exited with an error code (exit code:<PHONE_NUMBER>).
So means something is there, but not everything...

the option --disablePnpmAudit is still not recognized on the cli.
$ ./dependency-check.sh --version
Dependency-Check Core version 6.5.3

$ ./dependency-check.sh --disablePnpmAudit
Unrecognized option: --disablePnpmAudit

There's a workaround. You can set it via env variables.
JAVA_TOOL_OPTIONS=-Danalyzer.pnpm.path=/your/path

Hello, I'm trying to execute the command  '--disablePnpmAudit' as an argument  in my Dependency Check task in a pipeline from Azure DevOps and it doesn't work.
I get this:
[ERROR] Exception occurred initializing Pnpm Audit Analyzer.
[ERROR] Unable to read pnpm audit output.
I read the bug is already fixed but I'm having it yet.
Any suggestion?

--disablePnpmAudit is still not a recognized option to the cli in 6.5.3
proposal would be
issue3789-disablepnpm.patch.txt


Needs a run-on-the-host command

In addition to #3, in which we'd like to be able to run commands rooted in the container's root filesystem, we probably want a way to run an arbitrary command from outside as well.  Being able to perform shell-like substitution of an environment variable that points to the container's root would be useful.

I believe we have this capability now.


new blog for 企业微信puppet

new blog for 企业微信puppet

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Sapio-S seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Please make ci green then I can review your blog!
Thanks!

@Sapio-S  I will close this PR if this PR has no reply at the end of September.

@wj-Mcat  Please help @Sapio-S  posting his blog.

This blog is way past the deadline, If you have not complete this issue in next week, we will close this issue. Thanks for your attention.


Adding django 1.8 support

+1

+1

+1

+1

+1

Yup, if no one beats me to it i'll look at it this weekend

while changes between 1.6 and 1.7 were not trivial, changes between 1.7 and 1.8 should not be that difficult to support togather.

Well one of the issues is that not all our dependencies support 1.8 yet. And we also need to decide if we integrate this in Oscar 1.1.0 (which will include Bootstrap 3) or release it as a 1.0.4 (thus make it an easier upgrade path). I'll leave this decision to @maikhoepfel and @codeinthehole

Hi all, I'm happy to announce I just merged #1711. Django 1.8 is now supported on the master branch. A client of mine is using Oscar and wants to move to Django 1.8 pretty soon, so I'm hopeful I'll get time to package Oscar 1.1 soon.

We do have some work left to do: https://github.com/django-oscar/django-oscar/issues/1728


Check in the bluetooth RFCOMM sample

Hi @MagicBunny, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

@MagicBunny, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.
Thanks, MSBOT;

Are we also checking in the Arduino echo sketch or documenting the steps to recreate?

please add a sln file


Add last 3 seasons filter to player page

Just wanna beat the drum again here. It would be amazing to get the "Last three seasons" filter for PLAYER stats too.

This was only added for the team page statistics, so add it to the player profile page statistics as well

I had no idea how to approach this issue so I copy pasted CSNWEB's code to a branch. Can you check it and give feedback?
This is the link of the branch: https://github.com/eayildiz/HeroesLounge/tree/SlothSeasonFilterUpdateIssue201
And, how can I test the changes for future?
Thank you in advance.

Your code looks pretty good - mostly just missing changes to the htm file to actually expose the option
Regarding testing, you can find instructions in our Discord channel

It seems like I cannot test it in near future. I am attending school even in summer. I'll try it as soon as I can but if you are available, you can test it. I didnot set up test environment yet.
I believe that I changed the related html file as well.


fixing missingSuspenseWithCSRBailout warnings with nextjs 15 bump

This should fix build warnings (link), ex:
#20 15.50  ⚠ Invalid next.config.js options detected:
#20 15.51  ⚠     Unrecognized key(s) in object: 'missingSuspenseWithCSRBailout' at "experimental"
#20 15.51  ⚠ See more info here: https://nextjs.org/docs/messages/invalid-next-config
#20 15.67 Attention: Next.js now collects completely anonymous telemetry regarding usage.
#20 15.67 This information is used to shape Next.js' roadmap and prioritize features.
#20 15.67 You can learn more, including how to opt-out if you'd not like to participate in this anonymous program, by visiting the following URL:
#20 15.67 https://nextjs.org/telemetry
#20 15.67
#20 16.77    ▲ Next.js 15.0.3

See relevant link: https://nextjs.org/docs/messages/missing-suspense-with-csr-bailout#possible-ways-to-fix-it

Tested, works fine


Label fields not shown.

Describe your problem
Label fields shows as variables. on edit user page. $label
Bludit version
3.3 downloaded from bludit.com

Fixed, please check the new version 3.4.0.


Typehint $app

For the Laravel service container to properly construct an instance of Teamwork, we must type the parameters.

Hi @rmccullagh
Thanks for your PR!
Let me understand: you need this when resolving the class directly when not using the existing Facade?
If this is the case, can't we just update the TeamworkServiceProvider having an alias teamwork resolving to the Teamwork class then?

Hi @okaufmann,
Yes, this PR would allow the Laravel container to resolve an instance of Teamwork. Your solution would also work.

Great! I've added the alias and released a new version (6.0.3)


Cannot resolve Icon modules after update to v5.1.0

[x] The issue is present in the latest release.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯
Cannot import material icons.
This line occurs error.
import MenuIcon from '@mui/icons-material/Menu';

Expected Behavior 🤔
Icons should be imported as before.

Steps to Reproduce 🕹

https://github.com/zzossig/mui5.1.0-icons-resolve-bug-reproduce

clone the repository
yarn install
yarn dev

Context 🔦

Your Environment 🌎

`npx @mui/envinfo`
System:
    OS: macOS 12.0.1
  Binaries:
    Node: 16.6.0 - /opt/homebrew/bin/node
    Yarn: 1.22.10 - /opt/homebrew/bin/yarn
    npm: 7.19.1 - /opt/homebrew/bin/npm
  Browsers:
    Chrome: 95.0.4638.69
    Edge: Not Found
    Firefox: 91.0.2
    Safari: 15.1
  npmPackages:
    @emotion/react: ^11.5.0 => 11.5.0
    @emotion/styled: ^11.3.0 => 11.3.0
    @mui/core:  5.0.0-alpha.54
    @mui/icons-material: ^5.1.0 => 5.1.0
    @mui/lab: ^5.0.0-alpha.54 => 5.0.0-alpha.54
    @mui/material: ^5.1.0 => 5.1.0
    @mui/private-theming:  5.1.0
    @mui/styled-engine:  5.1.0
    @mui/styles: ^5.1.0 => 5.1.0
    @mui/system: ^5.1.0 => 5.1.0
    @mui/types:  7.1.0
    @mui/utils:  5.1.0
    @mui/x-data-grid-generator: ^5.0.0-beta.4 => 5.0.0-beta.4
    @mui/x-data-grid-pro: ^5.0.0-beta.7 => 5.0.0-beta.7
    @mui/x-license-pro: ^5.0.0-beta.7 => 5.0.0-beta.7
    @types/react: ^17.0.19 => 17.0.19
    react: ^17.0.2 => 17.0.2
    react-dom: ^17.0.2 => 17.0.2
    typescript: ^4.4.2 => 4.4.2

Webpack keep complaining
Module not found: Can't resolve './utils/createSvgIcon'

I suspect #29327 could be the problem.

@zzossig What is the error that I should see? I clone your repo and it is working fine.

I managed to solve the problem.

delete node_modules folder.
install packages using npm install not 'yarn install'
problem solved.


SMB 1.0/CIFS File Sharing Support installed by default

On a VM deployed on Azure on 25/04/2018, the SMB 1.0/CIFS File Sharing Support role is no longer installed by default.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e5acee3a-b458-172f-127d-07e0406bd46f
Version Independent ID: a11c4876-e20a-4307-b1b7-38f414a4532c
Content: Windows Server 2016 Products and Editions
Content Source: WindowsServerDocs/get-started/2016-Edition-Comparison.md
Service: unspecified
GitHub Login: @jaimeo
Microsoft Alias: jaimeo

@jaimeo - can you take a look at this one? Thanks!

SMB 1 is not installed as default, since build 1709, so it shouldn't be installed on Azure as default:
https://support.microsoft.com/en-us/help/4034314/smbv1-is-not-installed-by-default-in-windows

Confirming with SME.

Sorry for the delay--I was researching this thoroughly. The Windows Server 2016 edition comparison topic is correct: SMB1 IS installed by default in Windows Server 2016, which is the release that the topic applies to. (If it also applied to Windows Server, version 1709, that would be listed in the "applies to" section near the top.)
However, we did miss that it had been removed as pre-installed feature in Windows Server, version 1709. I have updated https://docs.microsoft.com/en-us/windows-server/get-started/removed-features-1709 to reflect this, including a link to the KB article that goes into detail about it. Thanks for helping us with this!


Link navigates to 404

The link at the end of the lesson goes to a page which does not exist.
Advanced Coroutines with Kotlin Flow and LiveData codelab:
https://codelabs.developers.google.com/codelabs/advanced-kotlin-coroutines

@cory-austin sorry about that, it looks like the root has changed, but the url fragment is the same.
Please refer to https://developer.android.com/codelabs/advanced-kotlin-coroutines#0
For what you need, I'll update the doc soon.

@cory-austin please can you point me to where in the codelab you found this dead link? I can't find it anywhere.

The last line of step 1.  The one that says "Advanced Coroutines with Kotlin Flow and LiveData codelab."

It should be updated shortly.


Fix test start button failure

The test-start-button test case seems to fail for the following 3 reasons:

options is not defined in the destroy method of the trasport-listener
the Start button is not already active when the toolbox-ready events is emitted (the added waitUntil test helper waits the start button to become active and fails if it doesn't in a defined time slice)
the Start button wasn't disabled when the toolbox is destroyed, because when the destroyContext events is emitted, the toolbox panel is not yet destroyed (this change move chrome.destroy(), which emits the destroyContext event, in the onToolboxClosed handler, when the toolbox is already fully destroyed)

@janodvarko this pullrequest fix the test-start-button test case failure, and ensures the start button to become non-active on toolbox destroyed, and travis seems to be happy now ;)
I just saw that you fixed the "options is not defined" issue in a different commit this morning, I can rebase this pull request to exclude the redundant fix.

I just saw that you fixed the "options is not defined" issue in a different commit this morning,
I can rebase this pull request to exclude the redundant fix.

Yeah, that would be great, thank Luca!
Honza

@janodvarko just done!

Excellent, looks great to me!
Honza


Consider an interface-only package?

It seems like it would be convenient to have a package that defines only the AbstractGraph interface without providing any implementations, similar to how Tables.jl and DataAPI.jl work. That way packages that implement new graph types only need to depend on the interface package.
On the other hand, does the new package extensions feature reduce the need for separate interface packages? I haven't played around with package extensions yet, so I don't know the answer to that question.

@gdalle Any thoughts on this?

I think it makes development harder to have two unregistered repos, so I would put it on the back burner for now (not that development is really active either ^^). However I kinda like the idea for the medium term when things are more fleshed out

We did a lot of work on an abstract interface package for MCMC over here, and my experience from that was that it is useful, albeit contentious, to have an interface only package. I personally liked the setup but interfaces can be extremely "sticky" and hard to iterate on once they are in place. Ime I would make this an interface-only package and then just let it grow out.
You may already know some of this but I'll stick it in here since I am not nearly as familiar with the graphs ecosystem as you all. Some conclusions from AbstractMCMC:

Don't make parts of the interface required. It's more work for people who might only want to implement pieces (#2). Basically, provide a fallback method that tells you to implement some particular method if and when it is invoked.
This package (GraphsBase.jl) should contain all abstract types anyone would ever want to inherit from, i.e. AbstractGraph, AbstractVertex or AbstractNode, AbstractEdge, etc. Everything here is good and should be moved over, though this error should contain (a) the type that was called and (b) the method that was invoked.

Traits aren't particularly worth it IMO.
DO provide a way to identify which methods are not implemented and which are -- we didn't really do this in AbstractMCMC and it ended up being a pain for people. An instructional method like interfaceimplementation(x) or something should give you specific instructions on how to implement each method, provide links to docs, a list of omitted interface methods, etc.
Very very few interface methods should actually need to be extended. For example, most methods have fallbacks that can be built (sometimes inefficiently) from core methods that return some kind of iterable or count. edges, neighbors, getindex, setindex, etc. should be almost all of what anyone should need to implement (I think you already have this for the most part but I just wanted to state it).

Just some opinions, in no particular order and not particularly well formed.


Add a warning when deleting a policy with shared placements

The first commit clarifies the wording in the delete policy modal .
The second commit adds a warning when deleting a policy with shared placements. When deleting a policy, you can select to delete the placements and placement bindings associated with it. These placements and placement bindings could be used by other policies, so a warning is added for this case so that the user is aware before actually deleting them.

Relates:
https://issues.redhat.com/browse/ACM-2412

/cc @willkutler @KevinFCormier

/approve

Approved. Will leave code review to @willkutler

/lgtm Looks great Matt!


Cannot find function FlatMapSerializer

Moved from #1185 because this does not involve a struct variant. @YoEight

I'm experiencing something similar (I think) except my container is a struct. Is my situation related or do I have to open a new issue?
#[derive(Serialize, Deserialize)]
pub struct StreamMetadata {
    #[serde(rename = "$maxCount")]
    pub max_count: Option<u64>,

    #[serde(rename = "$maxAge")]
    pub max_age: Option<DurationWrapper>,

    #[serde(rename = "$tb")]
    pub truncate_before: Option<u64>,

    #[serde(rename = "$cacheControl")]
    pub cache_control: Option<DurationWrapper>,

    #[serde(rename = "$acl")]
    pub acl: StreamAcl,

    #[serde(flatten)] // <-- If I remove that line, everything is compiling.
    pub custom_properties: HashMap<String, Value>,
}

Output:
error[E0425]: cannot find function `FlatMapSerializer` in module `_serde::private::ser`
  --> src/internal/metadata.rs:33:10
   |
33 | #[derive(Serialize, Deserialize)]
   |          ^^^^^^^^^ not found in `_serde::private::ser`

error[E0425]: cannot find function `FlatMapDeserializer` in module `_serde::private::de`
  --> src/internal/metadata.rs:33:21
   |
33 | #[derive(Serialize, Deserialize)]
   |                     ^^^^^^^^^^^ not found in `_serde::private::de`

warning: unused `#[macro_use]` import
  --> src/lib.rs:16:1
   |
16 | #[macro_use]
   | ^^^^^^^^^^^^
   |
   = note: #[warn(unused_imports)] on by default

error: aborting due to 2 previous errors

Thanks for your time.

What version of serde_derive and serde are you building with? They should be the same number.

Extract from my Cargo.toml:
serde = "1.0"
serde_json = "1.0"
serde_derive = "1.0"

I don't have access to my dev machine right now so I can't have a look on my lock file.

@dtolnay
Here's what my Cargo.lock says:
 "serde 1.0.29 (registry+https://github.com/rust-lang/crates.io-index)",
 "serde_derive 1.0.35 (registry+https://github.com/rust-lang/crates.io-index)",
 "serde_json 1.0.11 (registry+https://github.com/rust-lang/crates.io-index)",

So despite what I set in my Cargo.toml those version differs on their patch number. Were you referring to this?
Just in case, I run a build by backing up my old Cargo.lock and the compilation went successful.
When looking at the new Cargo.lock I got this:
 "serde 1.0.36 (registry+https://github.com/rust-lang/crates.io-index)",
 "serde_derive 1.0.36 (registry+https://github.com/rust-lang/crates.io-index)",
 "serde_json 1.0.13 (registry+https://github.com/rust-lang/crates.io-index)",

So now both serde and serde_derive have exact version.
Thanks for your time.

This issue can be closed.

Nice, I am glad you got it working. Yes the serde_derive and serde patch versions need to be upgraded in sync.


moves close checkpoint function into market actions

Codecov Report
Patch coverage: 100.00% and project coverage change: +0.06 :tada:

Comparison is base (b20b927) 80.41% compared to head (0b38cc8) 80.48%.

:exclamation: Current head 0b38cc8 differs from pull request most recent head 0131eda. Consider uploading reports for the commit 0131eda to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #297      +/-   ##
==========================================
+ Coverage   80.41%   80.48%   +0.06%
==========================================
  Files          24       24
  Lines        1823     1829       +6
==========================================
+ Hits         1466     1472       +6
  Misses        357      357

Flag
Coverage Δ

unittests
80.48% <100.00%> (+0.06%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

elfpy/markets/hyperdrive/hyperdrive_actions.py
82.02% <100.00%> (+2.14%)
:arrow_up:

elfpy/markets/hyperdrive/hyperdrive_market.py
85.64% <100.00%> (-0.85%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.