user defined bridge steps in the doc needs update

File: engine/userguide/networking/default_network/build-bridges.md, CC @mistyhacks

Configure the new bridge.

$ sudo ip link set dev br0 up <======= this is invalid step, this should be:
ip link add name bridge0 type bridge
$ sudo ip addr add <IP_ADDRESS>/24 dev bridge0
$ sudo ip link set dev bridge0 up
Similarly, in this section:
Remove the now-unused docker0 bridge.
$ sudo ip link set dev docker0 down
$ sudo ip link del name br0 <======= there is typo,it should be
sudo ip link del name docker0

Closing this ticket due to its age, and the impending refactor. If you think this is in error, feel free to reopen. Thanks!


Inability to login

Hi, I've noticed really strange behavior that wasn't present earlier. I wonder, if the OAuth authorization page was somehow edited/modified from previous versions.
The problem that WP 8.1 (IE 11 mobile) users reported actually present but really randomly. I managed to see it on emulator. These are the cases:

After you enter valid login and password, for some reason browser returns UserCancel code, with errorCode = 0 and empty string as description. The same behavior (when it's valid) when user actually decides not to login and returns manually. But this looks like the server sends such a response. I managed to fix it manually for my user when login in  web version and closed all "other sessions" in settings.
If user enters valid credentials and gets to the page with authorization,selects checkbox and presses Authorize -- simply nothing happens. Like it wasn't pressed. The same is for Deny button. No request/response, nothing.
After the request for token revocation is sent -- the session in Settings of web-version is still alive and needs to get closed forcefully from settings.
I do really hope this can be helped. Thanks!

After you enter valid login and password, for some reason browser returns UserCancel code, with errorCode = 0 and empty string as  description. The same behavior (when it's valid) when user actually decides not to login and returns  manually. But this looks like the server sends such a response. I managed to fix it manually for my user  when login in web version and closed all "other sessions" in settings.

Do you have an example of the response you get, would be useful for tracking down that case.

If user enters valid credentials and gets to the page with authorization,selects checkbox and presses Authorize -- simply nothing happens. Like it wasn't pressed. The same is for Deny button. No request/response, nothing.

 When this happens it could be some sort of javascript error which should show up in console.

After the request for token revocation is sent -- the session in Settings of web-version is still alive and needs to get closed forcefully from settings.

Depends which sessions you are talking about, OAuth sessions are not related to web sessions. The only thing in settings that relates to OAuth is the app authorizations.

Unfortunately no, I can't get them from the emulator( I understand it's quite hard to check this and fix, if there is even a problem
Of course IE sucks, who would argue. The problem is that it actually worked. I managed to get some logs from JS, hope this helps (at the end of the message).
OAuth session may be not connected, but as soon as I try to login through OAuth I get a session in the list of other sessions in Settings with browser/device set to Windows Mobile.

Logs:
'IExplore.exe' (Script): Loaded 'Script Code ((null))'.
Exception was thrown at line 16, column 1357 in https://www.google-analytics.com/analytics.js
0x800a01ad - JavaScript runtime error: Automation server can't create object
Exception was thrown at line 16, column 1460 in https://www.google-analytics.com/analytics.js
0x800a01ad - JavaScript runtime error: Automation server can't create object
Exception was thrown at line 16, column 1610 in https://www.google-analytics.com/analytics.js
0x800a01ad - JavaScript runtime error: Automation server can't create object
Exception was thrown at line 8, column 151 in https://www.google-analytics.com/analytics.js
0x800a138f - JavaScript runtime error: Unable to get property 'getRandomValues' of undefined or null reference
Exception was thrown at line 8, column 24118 in https://st.deviantart.net/css/deviantart-network_jc.js?3758961921
0x800a139e - JavaScript runtime error: SyntaxError
Exception was thrown at line 8, column 24343 in https://st.deviantart.net/css/deviantart-network_jc.js?3758961921
0x800a139e - JavaScript runtime error: SyntaxError
Exception was thrown at line 42, column 400 in https://partner.googleadservices.com/gpt/pubads_impl_73.js
0x800a01ad - JavaScript runtime error: Automation server can't create object
Exception was thrown at line 42, column 514 in https://partner.googleadservices.com/gpt/pubads_impl_73.js
0x800a01ad - JavaScript runtime error: Automation server can't create object
Exception was thrown at line 43, column 86 in https://partner.googleadservices.com/gpt/pubads_impl_73.js
0x800a01ad - JavaScript runtime error: Automation server can't create object
Exception was thrown at line 8, column 521 in https://partner.googleadservices.com/gpt/pubads_impl_73.js
0x800a138f - JavaScript runtime error: Unable to get property 'getRandomValues' of undefined or null reference
Exception was thrown at line 14, column 363 in https://tpc.googlesyndication.com/safeframe/1-0-2/html/container.html
0x800a01ad - JavaScript runtime error: Automation server can't create object
Exception was thrown at line 14, column 470 in https://tpc.googlesyndication.com/safeframe/1-0-2/html/container.html
0x800a01ad - JavaScript runtime error: Automation server can't create object
Exception was thrown at line 15, column 20 in https://tpc.googlesyndication.com/safeframe/1-0-2/html/container.html
0x800a01ad - JavaScript runtime error: Automation server can't create object
Exception was thrown at line 15, column 199 in https://tpc.googlesyndication.com/safeframe/1-0-2/html/container.html
0x800a139e - JavaScript runtime error: Cannot parse serialized data to extract content
Exception was thrown at line 8, column 151 in https://www.google-analytics.com/analytics.js
0x800a138f - JavaScript runtime error: Unable to get property 'getRandomValues' of undefined or null reference
Exception was thrown at line 8, column 151 in https://www.google-analytics.com/analytics.js
0x800a138f - JavaScript runtime error: Unable to get property 'getRandomValues' of undefined or null reference
Exception was thrown at line 16, column 1357 in https://www.google-analytics.com/analytics.js
0x800a01ad - JavaScript runtime error: Automation server can't create object
Exception was thrown at line 16, column 1460 in https://www.google-analytics.com/analytics.js
0x800a01ad - JavaScript runtime error: Automation server can't create object
Exception was thrown at line 16, column 1610 in https://www.google-analytics.com/analytics.js
0x800a01ad - JavaScript runtime error: Automation server can't create object
Exception was thrown at line 8, column 151 in https://www.google-analytics.com/analytics.js
0x800a138f - JavaScript runtime error: Unable to get property 'getRandomValues' of undefined or null reference
Exception was thrown at line 8, column 24118 in https://st.deviantart.net/css/deviantart-network_jc.js?3758961921
0x800a139e - JavaScript runtime error: SyntaxError
Exception was thrown at line 8, column 24343 in https://st.deviantart.net/css/deviantart-network_jc.js?3758961921
0x800a139e - JavaScript runtime error: SyntaxError
Exception was thrown at line 42, column 400 in https://partner.googleadservices.com/gpt/pubads_impl_73.js
0x800a01ad - JavaScript runtime error: Automation server can't create object
Exception was thrown at line 42, column 514 in https://partner.googleadservices.com/gpt/pubads_impl_73.js
0x800a01ad - JavaScript runtime error: Automation server can't create object
Exception was thrown at line 43, column 86 in https://partner.googleadservices.com/gpt/pubads_impl_73.js
0x800a01ad - JavaScript runtime error: Automation server can't create object
Exception was thrown at line 8, column 521 in https://partner.googleadservices.com/gpt/pubads_impl_73.js
0x800a138f - JavaScript runtime error: Unable to get property 'getRandomValues' of undefined or null reference
Exception was thrown at line 8, column 521 in https://partner.googleadservices.com/gpt/pubads_impl_73.js
0x800a138f - JavaScript runtime error: Unable to get property 'getRandomValues' of undefined or null reference
Exception was thrown at line 14, column 363 in https://tpc.googlesyndication.com/safeframe/1-0-2/html/container.html
0x800a01ad - JavaScript runtime error: Automation server can't create object
Exception was thrown at line 14, column 470 in https://tpc.googlesyndication.com/safeframe/1-0-2/html/container.html
0x800a01ad - JavaScript runtime error: Automation server can't create object
Exception was thrown at line 15, column 20 in https://tpc.googlesyndication.com/safeframe/1-0-2/html/container.html
0x800a01ad - JavaScript runtime error: Automation server can't create object
Exception was thrown at line 15, column 199 in https://tpc.googlesyndication.com/safeframe/1-0-2/html/container.html
0x800a139e - JavaScript runtime error: Cannot parse serialized data to extract content
Exception was thrown at line 8, column 16285 in https://st.deviantart.net/css/deviantart-network_jc.js?3758961921
0x800a139e - JavaScript runtime error: SyntaxError

@muteor small update: the problem still happens but it seams that actually cleaning and forcefully closing all of the sessions and if possible remove app from authorized helps then to login. So it should be some connection with sessions, otherwise how can this help?

I had a few people test this for me and no-one was able to reproduce the error on IE11. I still think its probably some strange edge case in IE but not sure what.

@muteor I personally never saw it in my Wp8.1 Lumia, only in emulator, but user's reviews actually report the problem exists and the advice with sessions helps, which is strange.
The problem is, that it reproduces in WebAuthenticationBroker, which is not the Browser, but creates it's one system WebView, which is hard to test.

Closing as we could never reproduce.


Enable completion for maven colorizer

Maven plugin introduces mvn-color, but completion for it doesn't work(and after aliasing mvn-color to mvn it doesn't work too for mvn).

Any news on this?


CAPT-1353 TSLR landing-page

Review app deployed to https://s118d02-app-pr-2509-as.azurewebsites.net/additional-payments/claim

Direct link: https://s118d02-app-pr-2509-as.azurewebsites.net/student-loans/landing-page


Preview designer does not save changes to the logic app

Describe the Bug with repro steps

create logic app
create any logic app from teplate and save changes
use try preview designer
apply and change to logic app in preview designer and save changes (notification says changes were saved)
leave designer and reopen your logic app

Last changes will be lost.
What type of Logic App Is this happening in?
Consumption (Portal)
Are you using Preview Designer or GA Designer
Preview
Workflow JSON
{
  "definition": {
    "$schema": "https://schema.management.azure.com/providers/Microsoft.Logic/schemas/2016-06-01/workflowdefinition.json#",
    "actions": {
      "Get_my_profile": {
        "type": "ApiConnection",
        "inputs": {
          "host": {
            "connection": {
              "referenceName": "office365users"
            }
          },
          "method": "get",
          "path": "/users/me"
        },
        "runAfter": {}
      },
      "Get_rows": {
        "type": "ApiConnection",
        "inputs": {
          "host": {
            "connection": {
              "referenceName": "postgresql"
            }
          },
          "method": "get",
          "path": "/datasets/default/tables/@{encodeURIComponent(encodeURIComponent('[public].[test]'))}/items"
        },
        "runAfter": {
          "Get_my_profile": [
            "SUCCEEDED"
          ]
        }
      },
      "For_each": {
        "type": "Foreach",
        "actions": {
          "For_each_1": {
            "type": "foreach",
            "foreach": "@body('Get_rows')?['value']",
            "actions": {
              "Send_an_email_(V2)": {
                "type": "ApiConnection",
                "inputs": {
                  "host": {
                    "connection": {
                      "referenceName": "office365"
                    }
                  },
                  "method": "post",
                  "body": {
                    "To": "@body('Get_my_profile')?['Mail']",
                    "Subject": "Yo @{body('Get_my_profile')?['DisplayName']} bro, diz iz to notify yo!",
                    "Body": "Let me tell ya 'bout the new @{item()?['trainingname']} in town that says @{item()?['trainingvalue']}",
                    "Importance": "Normal"
                  },
                  "path": "/v2/Mail"
                }
              }
            }
          }
        },
        "runAfter": {
          "Get_rows": [
            "SUCCEEDED"
          ]
        }
      }
    },
    "contentVersion": "<IP_ADDRESS>",
    "outputs": {},
    "triggers": {
      "Recurrence": {
        "type": "Recurrence",
        "recurrence": {
          "frequency": "Day",
          "interval": 1
        }
      }
    }
  },
  "connectionReferences": {
    "office365users": {
      "connectionName": "office365users",
      "connection": {
        "id": "/subscriptions/e6ef220d-9d58-444d-9aff-5a3898dac5fd/resourceGroups/lmt-investigation/providers/Microsoft.Web/connections/office365users"
      },
      "api": {
        "id": "/subscriptions/e6ef220d-9d58-444d-9aff-5a3898dac5fd/providers/Microsoft.Web/locations/westeurope/managedApis/office365users"
      }
    },
    "postgresql": {
      "api": {
        "id": "/subscriptions/e6ef220d-9d58-444d-9aff-5a3898dac5fd/providers/Microsoft.Web/locations/westeurope/managedApis/postgresql"
      },
      "connection": {
        "id": "/subscriptions/e6ef220d-9d58-444d-9aff-5a3898dac5fd/resourceGroups/lmt-investigation/providers/Microsoft.Web/connections/postgresql"
      },
      "connectionName": "postgresql"
    },
    "office365": {
      "connectionName": "office365",
      "connection": {
        "id": "/subscriptions/e6ef220d-9d58-444d-9aff-5a3898dac5fd/resourceGroups/lmt-investigation/providers/Microsoft.Web/connections/office365"
      },
      "api": {
        "id": "/subscriptions/e6ef220d-9d58-444d-9aff-5a3898dac5fd/providers/Microsoft.Web/locations/westeurope/managedApis/office365"
      }
    }
  },
  "parameters": {}
}

Screenshots or Videos
No response
Browser
Microsoft Edge
Version 113.0.1774.42 (Official build) (64-bit)
Additional context
No response

@zoranbebic thanks for reporting this issue, this is a known issue #2388, and will be using that for tracking


[#3058] fix bpftrace -l test.bt

Fix for #3058.
The fix involves some heuristic because there is a conflict:
USAGE:
    bpftrace [options] filename
    ...

OPTIONS:
    ...
    -l [search]    list kernel probes or probes in a program

Based on the snippet above, a command bpftrace -l foo is ambiguous.
Because, foo can be either search pattern or a file name.
The PR resolves this via the following logic:

assume that foo is a file.
check the file existence. If yes, proceed accordingly
if not, treat foo as search command.

Checklist

[x] Language changes are updated in man/adoc/bpftrace.adoc
[x] User-visible and non-trivial changes updated in CHANGELOG.md
[x] The new behaviour is covered by tests

@ikruglov Mind adding a runtime test for this? After this test would be a good place:
https://github.com/bpftrace/bpftrace/blob/3b2cda69d4aeb0eb370225e8456f864a60ac9a1b/tests/runtime/basic#L155

I think all you'll need to fix the failing tests is a WILL_FAIL in your test definitions, e.g. https://github.com/bpftrace/bpftrace/blob/3b2cda69d4aeb0eb370225e8456f864a60ac9a1b/tests/runtime/basic#L15
Also maybe a difference of opinion with @jordalgo here, but I don't think we should bake in assumptions about file extensions - there's nothing special about ".bt" anywhere else in the codebase. The checks for "*" and ":" are good though.
Removing the ".bt" check would only cause an issue when trying to list the "BEGIN" and "END" probes, as in #3057. But tbh I'm not sure listing those is useful after all.

Also maybe a difference of opinion with @jordalgo here, but I don't think we should bake in assumptions about file extensions - there's nothing special about ".bt" anywhere else in the codebase

I always forget that ".bt" is not an official thing :) (we should change that!) That's fine. I don't feel strongly about keeping the ".bt" check.

@jordalgo @ajor I've updated the PR with suggested changes. But I don't see a conclusion on '.bt' check. Should I keep it or remove it?

Let's get rid of the ".bt" check and just assume it's a file if it doesn't contain ":*"

@ajor this should be the final version


Adding a Welcome Page

Description:
We need a Welcome Page to display inspirational quotes before the application starts, it should have some placeholder code to display the randomly selected inspirational quote.
Estimated Effort:
The task is estimated to take around 2 days to locate and append the required code.
Initial assignments for team members:
Initially assigned to Abdulwahab Al-Rumaihi: @Procos12
Acceptance Criteria:
A blank page before the app starts with the application logo and some space to add the inspirational quote both as a placeholder function call int he code(comment) and in the view.

Will be assigned to someone else if I cannot complete it by Monday night.

Assigned @njouud as a collaborator, for some reason I can't get the logo image to appear.
Added a placeholder function with a fixed random selection of "inspirational" quotes.


Bootstrap

This first PR sets up our application by creating the basic front and backend. This will serve as the backbone of our project, from which future changes will branch off.

creates the basic structure of our application,
creating separate folders for the front and backend
backend can be run using "mvn package appengine:run"
frontend can be run using "npm start"
backend contains the basic User and Book objects, along with associated tests
frontend contains the basic react app created by create-react-app

LGTM

LGTM

You forgot to approve 😃

LGTM

You forgot to approve 😃

I was so excited to get my gif displayed that I just left a regular comment!

We actually still need Geoff to accept his invite into our "organization" before he can be listed, I can remind him at meeting today. Thanks for the review!


Front door custom certificate doesn't support all key vault certificate formats

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 105783bc-d51e-c199-7c51-1475bc9fbaa0
Version Independent ID: 114c01b8-8b95-ff91-98c5-fd44b12ac6fc
Content: Tutorial - Configure HTTPS on a custom domain for Azure Front Door Service
Content Source: articles/frontdoor/front-door-custom-domain-https.md
Service: frontdoor
GitHub Login: @sharad4u
Microsoft Alias: sharadag

@Nixes Looks like you have self closed thus GitHub issue. If there are further / any questions regarding this matter or feedback on the Azure documentation, please do let us know and we will gladly continue the discussion.


Search Notes use case

Search Notes Use Case
As with most note taking apps, some method that can be used to search the notes would be very useful. In our case, we initially planned (time permitting) to have each note have tags, and to permit users to search by tag. We planned to include a search bar on the opening page of our application where users could search by title, ID, or any tag they chose. This would also have allowed us to make an unlimited number of notes. This is a very useful feature to implement, and would make this application far more feasibly scalable.
Rough Outline for Implementation
Here is a rough outline for how we had planned to implement this use case, time permitting

Include a search bar on the homepage with a text field users can type in
Include a "Search" button, which, when clicked, would take the input from the text field and compare it to all note titles, IDs, and tags. This can be done in the DAO.
Include an additional attribute in the note entity: a list of tags.
Include an additional entity: Tag.

I implemented this partially, so that if a user were to type in the exact name of the note they wanted to open, we take them directly to that note. Ideally they could type in a keyword and all of the notes would then display.


cmd/compile: compiler panics on key-element slice literal with float index

go version devel +883e128 Wed Jul 20 05:08:37 2016 +0000 linux/amd64

The compiler knows that you must use an integer constant as an index for a key-element literal, and the error message is fine when a negative index is used:
package main

func main() {
	_ = []int{-1: 3}
}

./prova.go:4: index must be non-negative integer constant

but the compiler panics when a float is used:
package main

func main() {
	_ = []int{-1.0: 3}
}

# command-line-arguments
panic: interface conversion: interface {} is *gc.Mpflt, not *gc.Mpint

goroutine 1 [running]:
panic(0x8b5cc0, 0xc4204109c0)
	/home/alberto/go/src/runtime/panic.go:500 +0x1a1
cmd/compile/internal/gc.nonnegconst(0xc42041e510, 0x2)
	/home/alberto/go/src/cmd/compile/internal/gc/const.go:1494 +0x17a
cmd/compile/internal/gc.typecheckcomplit(0xc42041e3f0, 0x0)
	/home/alberto/go/src/cmd/compile/internal/gc/typecheck.go:2906 +0x34f
cmd/compile/internal/gc.typecheck1(0xc42041e3f0, 0x2, 0xc42001d3b0)
	/home/alberto/go/src/cmd/compile/internal/gc/typecheck.go:823 +0x57e8
cmd/compile/internal/gc.typecheck(0xc42041e3f0, 0x2, 0xc42001d3b0)
	/home/alberto/go/src/cmd/compile/internal/gc/typecheck.go:188 +0x654
cmd/compile/internal/gc.typecheckas(0xc42041e750)
	/home/alberto/go/src/cmd/compile/internal/gc/typecheck.go:3210 +0xa9
cmd/compile/internal/gc.typecheck1(0xc42041e750, 0x1, 0xb07570)
	/home/alberto/go/src/cmd/compile/internal/gc/typecheck.go:1952 +0x3bee
cmd/compile/internal/gc.typecheck(0xc42041e750, 0x1, 0x0)
	/home/alberto/go/src/cmd/compile/internal/gc/typecheck.go:188 +0x654
cmd/compile/internal/gc.typecheckslice(0xc42002e758, 0x1, 0x1, 0x1)
	/home/alberto/go/src/cmd/compile/internal/gc/typecheck.go:49 +0x57
cmd/compile/internal/gc.Main()
	/home/alberto/go/src/cmd/compile/internal/gc/main.go:389 +0x178d
cmd/compile/internal/amd64.Main()
	/home/alberto/go/src/cmd/compile/internal/amd64/galign.go:93 +0x2fa
main.main()
	/home/alberto/go/src/cmd/compile/main.go:33 +0x2a3

I've sent a CL https://go-review.googlesource.com/#/c/25081.

That was fast; I opened the issue to provide a reference to a patch I wanted to mail (it's CL 25090, gobot didn't reference it here since I closed it with R=go1.8).
Well, we can now choose between two different fixes.

FWIW, I prefer CL 25090.
nonnegconst could use a bit of cleanup, but that's unrelated...and that's true for much of the compiler.

Thanks @ALTree. @josharian aye aye, yap I now see that too, CL 25090 is smaller, less invasive and will prevent other crashes that slip through in that check. I considered one like it but thought I could somewhat improve the message since 'non-negative integer' seems like a catch all statement IMO but it might just be sufficient.

@odeke-em yep, I think it's sufficient. I'm thrilled to see more folks working on the compiler, though. Please keep sending CLs!

Cool, I'll close my CL in favor of 25090 and we can move work to it. Awesome, I look forward to doing work on the compiler.

For the record, a positive floating-point constant representable as an integer (e.g., 2.0) is permissible. Same for complex numbers representable as an integer (e.g., 2.0 + 0i). See my comments on https://go-review.googlesource.com/#/c/25090 .


Unify release, tag & image names

update github build script to unify the naming of github releases, github tags and docker images, to make deployments less confusing

Closing for now as needs to be done in conjunction with other repos, so they're all consistent.


cleaning up BA lolbas detection to remove duplicate exe

…her lolba detections recently released
Details
What does this PR have in it? Screenshots are worth 1000 words 😄
Checklist

[ ] Validate name matches <platform>_<mitre att&ck technique>_<short description> nomenclature
[ ] CI/CD jobs passed ✔
[ ] Validated SPL logic.
[ ] Validated tags, description, and how to implement.
[ ] Verified references match analytic.

LGTM, @josehelps : should we tag it with 3.52.0 ?


[$500] Workspace - WS default profile image flickers every time opened via settings

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.22
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Appause - Internal Team
Slack conversation:
Action Performed:

Launch app
Tap profile icon
Tap Workspaces
Tap new Workspace
Tap settings and note profile image

Expected Result:
Workspace default profile image must not flicker every time opened via settings
Actual Result:
Workspace default profile image flickers every time opened via settings
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/69a694dd-8eef-4061-b3ac-7232d12fa522
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0134c232e6ee21092a
Upwork Job ID:<PHONE_NUMBER>833586176
Last Price Increase: 2024-01-05

Proposal
Please re-state the problem that we are trying to solve in this issue.
The default avatar on Workspace settings page flashes on load
What is the root cause of that problem?
The DefaultAvatar prop passed to AvatarWithImagePicker component in Workspace settings page is an inline anonymous function. This forces the avatar component to rerender whenever the state of Workspace settings change.
https://github.com/Expensify/App/blob/7ae1ec7e74b908e6340bccaf7e42b0345d766711/src/pages/workspace/WorkspaceSettingsPage.js#L117-L127
What changes do you think we should make in order to solve the problem?
Memoize the anonymous function using a useCallback hook. This makes sure that the defaultAvatar component gets rerendered only when one of its dependencies change.
  const defaultAvatar= useCallback(()=>(
        <Avatar
       containerStyles={styles.avatarLarge}
       imageStyles={[styles.avatarLarge, styles.alignSelfCenter]}
       source={policy.avatar ? policy.avatar : ReportUtils.getDefaultWorkspaceAvatar(policyName)}
       fallbackIcon={Expensicons.FallbackWorkspaceAvatar}
       size={CONST.AVATAR_SIZE.LARGE}
       name={policyName}
       type={CONST.ICON_TYPE_WORKSPACE}
   />),[policy.avatar, policyName, styles.alignSelfCenter, styles.avatarLarge])

....

<AvatarWithImagePicker
  source={lodashGet(policy, 'avatar')}
  size={CONST.AVATAR_SIZE.LARGE}
  DefaultAvatar={ defaultAvatar}
  type={CONST.ICON_TYPE_WORKSPACE}
  fallbackIcon={Expensicons.FallbackWorkspaceAvatar}
  ...
/>

Result
https://github.com/Expensify/App/assets/6880914/6da5094c-800f-4773-9059-801d28b90f46
What alternative solutions did you explore? (Optional)
None (edited)

Proposal
Please re-state the problem that we are trying to solve in this issue.
The workspace settings image flickers multiple times.
What is the root cause of that problem?
I think the other proposals already mention the root cause well.
In the workspace setting, we pass a DefaultAvatar that accepts a component.
https://github.com/Expensify/App/blob/7ae1ec7e74b908e6340bccaf7e42b0345d766711/src/pages/workspace/WorkspaceSettingsPage.js#L114-L127
DefaultAvatar will be used when the workspace doesn't have any custom avatar set. Because it's an anonymous function, the reference is not stable on each render.
What changes do you think we should make in order to solve the problem?

There are multiple ways to pass a component as a prop, and the other way that is safer is to pass the component as it is, without any function.
DefaultAvatar={<Avatar .../>}

Then, in the AvatarWithImagePicker, instead of doing this,
https://github.com/Expensify/App/blob/7ae1ec7e74b908e6340bccaf7e42b0345d766711/src/components/AvatarWithImagePicker.js#L316-L318
we can just write DefaultAvatar.

I can't reproduce this. It's working as expected for me on web, iOS, and Android. The video above seems to be on Android, so I've included what I'm seeing there below:
https://github.com/Expensify/App/assets/54866469/0898b997-f8fe-4c2a-942e-b32e512a63f8
Even if it was consistently reproducible, I'm not convinced this is worth prioritizing. This is barely noticeable/doesn't really impact the user experience at all. Closing for now.


Memory leak in the setup function in solver code

Bug description
The setup function does not handle workspace and results deletion and thus is leaking memory.
Expected behavior
Destroy workspace and results before placement new in solver setup() method.
Reproduction steps
Steps to reproduce the behavior:

Create a trajectory optimization problem
Create a solver object
Repeatedly setup the solver with the problem
See memory leak

System

OS: Ubuntu 20.04
aligator version: v0.6.1

Thanks for the report @edantec. I forgot to delete the results and workspace instances before doing placement-new.

Closed by #192


Why does London have an offset of 1?

London is GMT, so it should have an offset of 0.

Its because the entry you looked at has is-daylight-saving set to true
{ "isdst": true }


Consider adding attribute:value to steps (idea from Robot Framework) - to explore

source - internal gtm
my initial thoughts -
I don't think there is any technical blocker to enable this for TagUI
so that in addition to below
click CSS
click XPath
click attribute_value
click (x,y)
click image.png

there can be
click attribute:value

or

click attribute=value

which will be mapped to
click //*[@attribute='value']

in the backend

After discussing with Ruth, this doesn't bring significant new value, because there is already smart hierarchy of attributes-matching if XPath or CSS selector is not given. Specifically id, name, class, title, aria-label, text(), href. So in practice, a given text would be match against the best fit item already and little need for user having to specify which attribute.


No covers are loading

What version of Music Assistant has the issue?
2.4.0
What version of the Home Assistant Integration have you got installed?
No response
Have you tried everything in the Troubleshooting FAQ and reviewed the Open and Closed Issues and Discussions to resolve this yourself?

[X] Yes

The problem
Almost no covers from artist, albums and song titles are shown after update to the newest version (24.10.2024), neither from spotify nor from Plex library.
How to reproduce
open Music Assistant and have a look
Music Providers
Spotify and Plex
Player Providers
Sonos
Full log output
No response
Additional information
No response
What version of Home Assistant Core are your running
2024.10.3
What type of installation are you running?
Home Assistant Supervised
On what type of hardware are you running?
Generic x86-64 (e.g. Intel NUC)

This has been noted and is being investigated

Not necessarily related, but I started seeing my HA RPI4 reboot every 10 min or so right after the most recent patch was installed. I disabled the Music Assistant addon, and it hasnt rebooted since.  Errors appear to be file read related, but there are no problems with any other device (all use an external SSD)- so database reads/writes are fine, reporting is fine, logs are fine etc. Only reporting in the case the cover art is related. No idea if the crash is memory leak- I dont see much in the system logs except restart details. Almost like a power-out, except again, soon as I disabled Music Assistant, this stopped, and it has been stable an hour now... If I can help with a diag etc, happy to try. Just not sure where to look.
Rob

@Extrapilot1 re-enable MA and see if it starts again. If it does look in the supervisor log.

Yes, it crashed within 6-8 minutes. I dont see any events in Supervisor log prior to the restart- not sure if I have to enable debug mode etc. What I did see was that CPU was pegged at 100%, RAM was at 74%, and the Music Assistant interface initially was showing a spinning circle status. When I came back to open the UI again after checking CPU, I got nothing- no UI response from Music Assistant, but I had quick response from other menu items- Node Red, HACS etc. So yea, not really sure of next steps- 2am here, so rack time, but if there is anything specific I should try- happy to have a go tomorrow.
Best
Rob

@Extrapilot1 this is a different problem that is being investigated.

Great, If I can help, let me know what to enable for logging etc-
R

@loadamasta @Extrapilot1 both if your issues should be fixed in 2.3.1 or 2.4.0b1 which will be released soon. Please confirm
@Extrapilot1 so we can stay sane please open your own issue in future

As I said- I wasnt clear if this was related- as I was seeing file access errors where I had no problems with filesystem access via any other component. Other report on this ticket mentioned file access, and the timeline overlapped with the release that caused the CPU/crash issue.
So far as the crash is related, the new version resolved it. It seemed to require a reinstall, as for whatever reason, the update didnt want to apply if the MA addon wasnt running, and turning it on caused a 100% CPU problem which prevented the update from running (or at least, from completing) before a crash happened.
So, CPU is sane now, no crashes, app seems to be running well.
Best
R

This has been fixed

@loadamasta @Extrapilot1 both of your issues should be fixed in 2.3.1 or 2.4.0b1 which will be released soon. Please confirm
@Extrapilot1 so we can stay sane please open your own issue in future

Sorry, EMail was in spam. I confirm that the issue has been fixed. Thank you.


Use Python 3.6

Codecov Report

Merging #1211 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1211      +/-   ##
==========================================
- Coverage   69.86%   69.84%   -0.02%
==========================================
  Files         117      117
  Lines        6328     6328
  Branches      762      762
==========================================
- Hits         4421     4420       -1
  Misses       1739     1739
- Partials      168      169       +1

Impacted Files
Coverage Δ

saleor/core/utils/random_data.py
81.2% <0%> (-0.38%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c47b28...3330ba3. Read the comment docs.


Statically compile default templates

This simplifies deployment for all the people using default templates.
It also prevents people from messing with default templates rather than creating proper overrides.
@brian-brazil

:+1:


[Bug]: Double rendering of an admonition "Note"

Summary
An "admonition" with a "note" content renders a "note" twice
Code snippet that reproduces the problem
Input RST:
.. admonition:: Note

    Unfortunately, PhpStorm only recognizes a file as a PHP archive when it has the ``.phar`` suffix.
    This is remedied by creating a symbolic link: ``ln -s phpunit tools/phpunit.phar``.

output HTML (in our render-guides context):

Note

Note

Unfortunately, PhpStorm only recognizes a file as a PHP archive when it has the .phar suffix.
This is remedied by creating a symbolic link: ln -s phpunit tools/phpunit.phar.

Expected output

Note

Unfortunately, PhpStorm only recognizes a file as a PHP archive when it has the .phar suffix.
This is remedied by creating a symbolic link: ln -s phpunit tools/phpunit.phar.

I cannot reproduce this issue. I think this is a bug in your template somehow.
@linawolf  can you have a look at the typo3 template for this?

Moved the issue to the render-guides:https://github.com/TYPO3-Documentation/render-guides/issues/725


Added PaperAuthorAffiliations.OribinalAuthor. Updated HDInsight script to Databricks.

OPS Build status updates of commit a8fbf7e:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/MicrosoftDocs/microsoft-academic-services, working directory: W:\sbcf-s, target branch: live, target branch commit: f585dc2a1a7cbe920ca3ac48ef4d314618fc84a3, source branch: master, source branch commit: .

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

OPS Build status updates of commit 4adb3be:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

academic-services/graph/TOC.yml
:white_check_mark:Succeeded

academic-services/graph/index.yml
:white_check_mark:Succeeded

academic-services/graph/media/entity-relationship-diagram-thumbnail.png
:white_check_mark:Succeeded

academic-services/graph/media/entity-relationship-diagram.png
:white_check_mark:Succeeded

academic-services/graph/reference-data-schema.md
:white_check_mark:Succeeded

academic-services/graph/samples-azure-databricks.md
:white_check_mark:Succeeded

academic-services/graph/samples-azure-hdinsight.md
:white_check_mark:Succeeded

academic-services/graph/tutorial-azure-data-lake-hindex.md
:white_check_mark:Succeeded

academic-services/graph/tutorial-azure-databricks-hindex.md
:white_check_mark:Succeeded

academic-services/graph/tutorial-azure-search-org-patents.md
:white_check_mark:Succeeded

academic-services/graph/tutorial-azure-search-reference-parsing.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

OPS Build status updates of commit dde89f2:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

academic-services/graph/TOC.yml
:white_check_mark:Succeeded

academic-services/graph/index.yml
:white_check_mark:Succeeded

academic-services/graph/media/entity-relationship-diagram-thumbnail.png
:white_check_mark:Succeeded

academic-services/graph/media/entity-relationship-diagram.png
:white_check_mark:Succeeded

academic-services/graph/reference-data-schema.md
:white_check_mark:Succeeded

academic-services/graph/samples-azure-databricks.md
:white_check_mark:Succeeded

academic-services/graph/samples-azure-hdinsight.md
:white_check_mark:Succeeded

academic-services/graph/tutorial-azure-data-lake-hindex.md
:white_check_mark:Succeeded

academic-services/graph/tutorial-azure-databricks-hindex.md
:white_check_mark:Succeeded

academic-services/graph/tutorial-azure-search-org-patents.md
:white_check_mark:Succeeded

academic-services/graph/tutorial-azure-search-reference-parsing.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

OPS Build status updates of commit a4a9c8b:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

academic-services/graph/TOC.yml
:white_check_mark:Succeeded

academic-services/graph/index.yml
:white_check_mark:Succeeded

academic-services/graph/media/entity-relationship-diagram-thumbnail.png
:white_check_mark:Succeeded

academic-services/graph/media/entity-relationship-diagram.png
:white_check_mark:Succeeded

academic-services/graph/reference-data-schema.md
:white_check_mark:Succeeded

academic-services/graph/samples-azure-databricks.md
:white_check_mark:Succeeded

academic-services/graph/samples-azure-hdinsight.md
:white_check_mark:Succeeded

academic-services/graph/tutorial-azure-data-lake-hindex.md
:white_check_mark:Succeeded

academic-services/graph/tutorial-azure-databricks-hindex.md
:white_check_mark:Succeeded

academic-services/graph/tutorial-azure-search-org-patents.md
:white_check_mark:Succeeded

academic-services/graph/tutorial-azure-search-reference-parsing.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

OPS Build status updates of commit db0b56d:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

academic-services/graph/TOC.yml
:white_check_mark:Succeeded

academic-services/graph/index.yml
:white_check_mark:Succeeded

academic-services/graph/media/databricks/import-notebook-dialog.png
:white_check_mark:Succeeded

academic-services/graph/media/databricks/import-notebook.png
:white_check_mark:Succeeded

academic-services/graph/media/entity-relationship-diagram-thumbnail.png
:white_check_mark:Succeeded

academic-services/graph/media/entity-relationship-diagram.png
:white_check_mark:Succeeded

academic-services/graph/reference-data-schema.md
:white_check_mark:Succeeded

academic-services/graph/samples-azure-databricks.md
:white_check_mark:Succeeded

academic-services/graph/samples-azure-hdinsight.md
:white_check_mark:Succeeded

academic-services/graph/tutorial-azure-data-lake-hindex.md
:white_check_mark:Succeeded

academic-services/graph/tutorial-azure-databricks-hindex.md
:white_check_mark:Succeeded

academic-services/graph/tutorial-azure-search-org-patents.md
:white_check_mark:Succeeded

academic-services/graph/tutorial-azure-search-reference-parsing.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

OPS Build status updates of commit 2e72b4d:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

academic-services/graph/TOC.yml
:white_check_mark:Succeeded

academic-services/graph/index.yml
:white_check_mark:Succeeded

academic-services/graph/media/databricks/import-notebook-dialog.png
:white_check_mark:Succeeded

academic-services/graph/media/databricks/import-notebook.png
:white_check_mark:Succeeded

academic-services/graph/media/entity-relationship-diagram-thumbnail.png
:white_check_mark:Succeeded

academic-services/graph/media/entity-relationship-diagram.png
:white_check_mark:Succeeded

academic-services/graph/reference-data-schema.md
:white_check_mark:Succeeded

academic-services/graph/samples-azure-databricks.md
:white_check_mark:Succeeded

academic-services/graph/samples-azure-hdinsight.md
:white_check_mark:Succeeded

academic-services/graph/tutorial-azure-data-lake-hindex.md
:white_check_mark:Succeeded

academic-services/graph/tutorial-azure-databricks-hindex.md
:white_check_mark:Succeeded

academic-services/graph/tutorial-azure-search-org-patents.md
:white_check_mark:Succeeded

academic-services/graph/tutorial-azure-search-reference-parsing.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

OPS Build status updates of commit 2b2cddc:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

academic-services/graph/TOC.yml
:white_check_mark:Succeeded

academic-services/graph/index.yml
:white_check_mark:Succeeded

academic-services/graph/media/databricks/import-notebook-dialog.png
:white_check_mark:Succeeded

academic-services/graph/media/databricks/import-shared-notebook.png
:white_check_mark:Succeeded

academic-services/graph/media/entity-relationship-diagram-thumbnail.png
:white_check_mark:Succeeded

academic-services/graph/media/entity-relationship-diagram.png
:white_check_mark:Succeeded

academic-services/graph/reference-data-schema.md
:white_check_mark:Succeeded

academic-services/graph/samples-azure-databricks.md
:white_check_mark:Succeeded

academic-services/graph/samples-azure-hdinsight.md
:white_check_mark:Succeeded

academic-services/graph/tutorial-azure-data-lake-hindex.md
:white_check_mark:Succeeded

academic-services/graph/tutorial-azure-databricks-hindex.md
:white_check_mark:Succeeded

academic-services/graph/tutorial-azure-search-org-patents.md
:white_check_mark:Succeeded

academic-services/graph/tutorial-azure-search-reference-parsing.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


add NATURAL JOIN types

add NATURAL JOIN types
relation issues are  #5240 and #5239

I made some more changes, please see the commit linked above this comment.


Clearing Up + Grammar Fixes

Added additional explanation of the '#'. More specifically, on what the length of a table actually means.
Added explanation using examples to the ipairs section.
Both were done because I remember myself having the hardest time understanding tables and ipairs.

Thanks


Vscode Revert Html Tags In Wrong Order

Hi After Upgrading to The last version of vscode after typing RTL Languages like Farsi , HTML tags had been reverted in the wrong order

I Ask This Question From Other Developers And This Bug Occurs In Their Devices Too!
Windows 10
Vscode Latest Version

@pooooriya Could you please provide the text above in a copy-paste friendly format?

same here

@merfankarami , @pooooriya
check out https://github.com/microsoft/vscode/issues/146533 for solution

@aeschli  and @alexdima This is a bug in the new version 1.66
I had to go back to version 1.65

Let's track in https://github.com/microsoft/vscode/issues/146354 and https://github.com/microsoft/vscode/issues/99589


Variable accessed before assignment

When trying to join a computer to the domain the following exception is being raised:
ERROR:root:Creating computer account for 'build' in 'OU=cbp-sandbox,OU=Projects,OU=sandbox.lab,DC=sandbox,DC=lab' failed
Traceback (most recent call last):
  File "/register-computer/main.py", line 351, in __register_computer
    mig_info = __get_managed_instance_group_for_instance(gce_instance)
  File "/register-computer/main.py", line 119, in __get_managed_instance_group_for_instance
    if (metadata_created_by and "instanceGroupManagers" in metadata_created_by["value"]):
UnboundLocalError: local variable 'metadata_created_by' referenced before assignment

The indentation of the code block in main.py seems to be wrong as it attempts to access the variable before being assigned.

Fixed directly in master.
https://github.com/GoogleCloudPlatform/gce-automated-ad-join/commit/21927bad9e63782db2343a32a9c28b722f84e1e8


merge customer edits back to master

Docs Build status updates of commit 5597305:
:warning: Validation status: warnings

File
Status
Preview URL
Details

cordovadocs/2017/first-steps/ios-guide.md
:warning:Warning

Details

cordovadocs/2017/tips-workarounds/measuring-performance.md
:warning:Warning

Details

cordovadocs/2017/first-steps/get-started-with-ionic2.md
:bulb:Suggestion

Details

cordovadocs/2017/take-further/using-crosswalk.md
:bulb:Suggestion

Details

cordovadocs/2017/index.md
:white_check_mark:Succeeded

cordovadocs/2017/first-steps/ios-guide.md

Line 225: [Warning] Cannot find bookmark '#stack' in '2017/first-steps/ios-guide.md', did you mean '#safari'?
Line 261: [Warning] Cannot find bookmark '#stack' in '2017/first-steps/ios-guide.md', did you mean '#safari'?
Line 315: [Warning] Cannot find bookmark '#stack' in '2017/first-steps/ios-guide.md', did you mean '#safari'?
Line 406: [Warning] Cannot find bookmark '#stack' in '2017/first-steps/ios-guide.md', did you mean '#safari'?

cordovadocs/2017/tips-workarounds/measuring-performance.md

Line 13: [Warning] Invalid value for 'ms.author', 'adamre' is not a valid Microsoft alias
Line 126: [Suggestion] Link 'http://blogs.msdn.com/b/visualstudioalm/archive/2013/07/12/performance-and-diagnostics-hub-in-visual-studio-2013.aspx' is insecure. Links to Microsoft sites must use 'https' instead of 'http'. NOTE: This Suggestion will become a Warning on 12/20/2019.

cordovadocs/2017/first-steps/get-started-with-ionic2.md

Line 24: [Suggestion] Link 'http://go.microsoft.com/fwlink/?LinkID=533794' is insecure. Links to Microsoft sites must use 'https' instead of 'http'. NOTE: This Suggestion will become a Warning on 12/20/2019.

cordovadocs/2017/take-further/using-crosswalk.md

Line 10: [Suggestion] Link 'http://go.microsoft.com/fwlink/?LinkID=617678' is insecure. Links to Microsoft sites must use 'https' instead of 'http'. NOTE: This Suggestion will become a Warning on 12/20/2019.
Line 14: [Suggestion] Link 'http://go.microsoft.com/fwlink/?LinkID=617678' is insecure. Links to Microsoft sites must use 'https' instead of 'http'. NOTE: This Suggestion will become a Warning on 12/20/2019.
Line 16: [Suggestion] Link 'http://go.microsoft.com/fwlink/?LinkID=617679' is insecure. Links to Microsoft sites must use 'https' instead of 'http'. NOTE: This Suggestion will become a Warning on 12/20/2019.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Wrong chain colors in the config-service

As per Agustin's design, the colors should be the following:
https://www.figma.com/file/txqgq1QhrFFe2NlwPRh0bz/?node-id=0%3A1

Updated ✅


False F401 with annotations and no_type_check.

Using v0.8.1.
from collections.abc import Iterable
from typing import no_type_check

@no_type_check
def func(it: Iterable):
    ...

outputs
.py:1:29: F401 [*] `collections.abc.Iterable` imported but unused
  |
1 | from collections.abc import Iterable

This was reverted in #14726.


Check that HDKey.generateMnemonic is bip39 valid

This is never expected to fail

https://github.com/bitcoinjs/bip39/blob/5faee2c17b2195f30b03cb125df68c20d7dd584b/src/index.js#L152
hm, any exception -> treat as invalid. I wonder if that ever does anything unexpected

https://github.com/bitcoinjs/bip39/blob/5faee2c17b2195f30b03cb125df68c20d7dd584b/src/index.js#L152
hm, any exception -> treat as invalid. I wonder if that ever does anything unexpected

new Array(100000).fill(0).every(a => validateMnemonic(hdkey.HDKey.generateMnemonic(256).split(' ').join(' '))) didn't fail :shrug:


Is ruff unnecessary-map C417 actually equivalent to pylint use-a-generator R1729?

Is ruff unnecessary-map C417 actually equivalent to pylint use-a-generator R1729?
In https://github.com/astral-sh/ruff/issues/970, use-a-generator is marked as complete via ruff rule C417 unnecessary-map.
The docs for pylint use-a-generator R1729  state:

Comprehension inside of 'any', 'all', 'max', 'min' or 'sum' is unnecessary. A generator would be sufficient and faster.
from random import randint

all([randint(-5, 5) > 0 for _ in range(10)])  # [use-a-generator]
any([randint(-5, 5) > 0 for _ in range(10)])  # [use-a-generator]

While the docs for ruff C417 unnecessary-map state:

Checks for unnecessary map calls with lambda functions.

Instead of list(map(lambda num: num * 2, nums)), use [num * 2 for num in nums].
Instead of set(map(lambda num: num % 2 == 0, nums)), use {num % 2 == 0 for num in nums}.
Instead of dict(map(lambda v: (v, v ** 2), values)), use {v: v ** 2 for v in values}.

Are they not actually equivalent? Or are docs incorrect?
If they're not equivalent, can the comment in #970 be updated?
I also found https://github.com/astral-sh/ruff/issues/3259 which appears to be related.

Oh, should it perhaps instead point to C419?

Ah yes that looks like it, thanks! I think I couldn't find that because I was always searching for generator...

Fixed the reference in #970, thank you!


GORM connects to "postgres" db instead of explicitly specified

Your Question
func Connect(cfg *Config) (db *gorm.DB, err error) {
	dsn := fmt.Sprintf(
		"host=%s user=%s password=%s dbname=%s port=%d sslmode=disable TimeZone=%s",
		cfg.Host,
		cfg.DBUser,
		cfg.DBPassword,
		cfg.DBName,
		cfg.Port,
		cfg.Timezone,
	)
	return gorm.Open(postgres.Open(dsn), &gorm.Config{})
}

func TestDB(t *testing.T) {
	t.Log("setup DB")
	cfg, err := LoadConfig(Test)
	if err != nil {
		t.Fatal(err)
	}
	t.Logf("config: %#v", cfg)

	db, err := Connect(cfg)
	if err != nil {
		t.Fatal(err)
	}

	current := db.Migrator().CurrentDatabase()
	t.Log(current)
}

result is:
=== RUN   TestDB
    db_test.go:53: setup DB
    db_test.go:58: config: &database.Config{Host:"localhost", Port:5432, DBName:"test", DBUser:"postgres", DBPassword:"", Timezone:"Europe/Moscow"}
    db_test.go:65: postgres
                   ~~~~~~~~
--- PASS: TestDB (0.02s)
PASS

database "test" is already created in postgres
I'm using Postgres App 12 for macos
If I do the same from, for example, Python - everything works as expected
How can I fix this?

The document you expected this should be explained

Expected answer

I'm not sure I understand your question.
Are you saying that the connection type should not be postgres??
I don't know how it could be doing anything other than connecting to postgres if you are specifying this in your Connect method
return gorm.Open(postgres.Open(dsn), &gorm.Config{})

I guess @h1ght1me meant that gorm connects to the default "postgres" database instead of "test" one specified in config, it ignores dbname param.
I also had the same problem, solved it using connection URL

Using
        gorm.io/driver/postgres v1.3.6
        gorm.io/gorm v1.23.5

and running into the same issue

This happened to me. For me, the issue was an empty password, which caused the DSN to be read incorrectly. I solved this by wrapping the password in single quote ' to ensure that empty string is read properly.
Here’s the code that worked for me:
dsn := fmt.Sprintf("host=%s user=%s password='%s' dbname=%s port=%s sslmode=disable", 		dbHost, dbUser, dbPassword, dbName, dbPort)


cron job

Stupid question probably not really worth your answer but I'm trying to run this as a cron job with the following script:
#!/bin/sh
/usr/sbin/ipset -q flush ipsum
/usr/sbin/ipset -q create ipsum hash:net
for ip in $(/usr/bin/curl --compressed https://raw.githubusercontent.com/stamparm/ipsum/master/ipsum.txt 2>/dev/null | /usr/bin/grep -v "#" | /usr/bin/grep -v -E "\s[1-2]$" | /usr/bin/cut -f 1); do ipset add ipsum $ip; done
/usr/sbin/iptables -I INPUT -m set --match-set ipsum src -j DROP
and only get an empty ipset.
Obviously the flush is working but the for loop doesn't seem to get done.  The script works fine if run directly from the command line.
Anyway any hints welcomed.

Make sure you're connected to the Internet before executing curl.
I added the following before curl:
until wget --spider https://raw.githubusercontent.com/tamparm/ipsum/master/ipsum.txt > /dev/null 2>&1; do echo "Waiting for GitHub to be accessible"; sleep 1; done

sorry @airdogvan, i just seen this issue. maybe that ipset without the absolute path (as seen that you use in other commands) is causing the problem.
so, try do ipset add ipsum $ip -> do /usr/sbin/ipset add ipsum $ip

Here is how I'm using ipsum, including cron scheduled updates. My environment is Armbian Focal on arm64 (nanopi r4s) and the device serves as a household internet router/gateway.
First: get the latest ipsum.txt and place it at /etc/ipsum.txt. This is used to fill the ipset, even if github is unreachable.
Next, I have ufw do the setup for ipsum: create and set executable: /etc/ufw/after.init
after.init.txt
Create a script at /etc/cron.daily/ipsum2ipset, set executable:
ipsum2ipset.txt


Wheel inside a <dialog> disappears when resizing the window while the <dialog> is closed

I have put the wheel inside a <dialog> tag and want it to be visible only when the user clicks a button to show the dialog. However when the dialog is closed, if I resize the window and then open the dialog, the wheel is gone. I have to resize the window again for it to become visible.
I think it might be because the canvas is auto-adjusting its size on resize event, but when the dialog is hidden, it sets its size to 0px by 0px, thus disappearing and only after resizing again with the modal open it sets the correct dimensions for its size.

Okay, after looking at the source code, I found resize() method and if I call that right after I open the dialog, it shows the wheel again. But I didn't find any mention of this method anywhere, so maybe put it in the README?

Duplicate of #26


Batch of styling and test isolation fixes

Some generic fixes taken from #9514, which are useful regardless of enabling the parallel execution of tests.

CI is passing now.

Thanks!

Please squash and merge :)


Upsert based on 2 primary key columns

Is there any way to perform an upsert using the dbUpsert function with 2 primary keys? I run the following code:
dbUpsertTable(
conn = con,
name = "Appointments",
value = appointments_df,
value_pkey = c("Entity", "ID")
)
And get the following error:
Error in if (is.na(value_pkey)) { : the condition has length > 1
Looking through your source code I'm not certain where the error code is coming from. But I also noted that in the .dbUpsertStatement() function, I can't tell if it's written to support 2 keys to upsert off of.

 It does support multiple column PKeys. I just pushed a new version with this fix. Do you mind checking if this fixes the problem for you? Let me know if the latest version resolves the issue.

Just installed the latest version and it works now! Don't think I've had an issue resolved so fast. Impressive!


Provide UI to work with versions and audit entries

We need the UI to work with Versions https://github.com/adobe/da-admin/issues/6 and Audit entries https://github.com/adobe/da-admin/issues/5

I've updated the versions branch to look like the artboard:

I couldn't find the icons on https://spectrum.adobe.com/page/icons/ so I left the old ones for now...
Also note that there are no named versions yet.
Two questions @auniverseaway :
How would we expand the list of audit logs at the top that are overflowing and hidden?

Just reveal them all when clicking on it?
And how should we make visible the hidden audit log entries for previous dates?

Similarly reveal them all when clicking on it?

I made a first attempt at naming versions. You can see it show up in the version list here beside the green circle. Right now I have a button to name the currently selected version in the toolbar but you probably want to change that 😉

@auniverseaway What UI interaction do you have in mind to enter the name for the version?
(note that for this to work some pending changes to da-admin are needed)

Just reveal them all when clicking on it?

Yup, I think so.

With https://github.com/adobe/da-live/commit/6bd5447ed76b879490ba76ac9906626d310d7abf I added expansion when clicking on it like this:
Initial visual:

After clicking on each hidden element:

Obviously clicking on an expanded item again will hide it again.
Hopefully this is close to what you had in mind.
Remaining question is how a version is named. The current implementation allows the naming of a selected version by clicking on this button
And then entering the name in a popup dialog.

I have the feeling you probably want to visualise that differently. Just let me know.

With https://github.com/adobe/da-live/commit/544e83403dd1e2eba04361a77a1b95ce69ab4f65 I updated the version naming as follows:
When a new version is created with the top button in the version toolbar an entry appears in the version line with a where the user can type in the version name (using contenteditable=true):

When the user hits enter or clicks somewhere else on the screen, the version is stored in the backend.

It's also still possible to select a version and edit the name or give it a name if it didn't have a name before via this button:

let me know if you want to keep that or not.
If the user hits Escape the version creation/editing is cancelled.


Fix channel results breaking Video search

The video module should not abandon requests if a result is a channel link.
Example Problem
If you say to JARVIS "linkin park videos", the last result is a channel link. This result causes JARVIS to abandon the search and default to the "I couldn't find any videos" message.
Problem and Solution
Not all results from the YouTube API have videoId inside of id.
item_url = 'https://www.youtube.com/watch?v=' + item['id']['videoId']

When the result is a channel link, it instead contains channelId inside of id. This pull request covers that reality with:
try:
      # Video result from search
      item_url = 'https://www.youtube.com/watch?v=' + item['id']['videoId']
      buttons.add_web_url('YouTube Link', 'https://www.youtube.com/watch?v=' + item['id']['videoId'])
except:
      # Channel result from search
      item_url = 'https://www.youtube.com/channel/' + item['id']['channelId']

Both results need a "Channel Link", but only one of them needs a "YouTube Link" button.
Semantic Argument
Maybe a channel result when searching for videos is not right. The answer to this is to ignore channel results. If @swapagarwal wants that, I will go in that direction. 👍
Regardless of direction, I do not believe the video module should give up on the search because of one channel result.

@FosterSamuel This is a really detailed write-up. Thanks for taking the time to deep-dive into the issue! 😄

Gladly! 👍
Thank you for noticing the chance of a playlist result. I'll work on adding that soon!
Sent from my Google Nexus 6P using FastHub

Gladly! 👍
Thank you for noticing the chance of a playlist result. I'll work on adding that soon!
Sent from my Google Nexus 6P using FastHub

Gladly! 👍
Thank you for noticing the chance of a playlist result. I'll work on adding that soon!

Changes

Removed type=video from API query to allow Playlist results
Changed "YouTube Link" --> "Video Link" for clarity
Added code to handle all three types of results

If type was set to video before, how come channel was returned in response? 🤔

@swapagarwal Not sure. Seems to be a less strict part of the YouTube API.
If you use the first commit (with type=video in the query), it exposes the results of a search that may have channel results in it. The type only excluded playlists, for some reason.
I can record a video example of this if you'd like further proof of the statements.


The popup Connect Wallet should show the current account as initial state

The popup Connect Wallet should show the current state when already have the connected account

https://user-images.githubusercontent.com/6297057/159880710-315f7fd8-6e8e-423c-bd25-9bf3abffa015.mp4


CHTML-preview leaves preview if custom script tags are used directly

Live example at http://jsbin.com/pakoxe/2/edit

=> In Testsuite
Parsing/issue975.html

I think I marked this as Needs Documentation to remember to document the CHTML-preview extension; this has been done as part of https://github.com/mathjax/MathJax-docs/pull/83 so I'm removing the tag.


mobile platform iOS tutorial missing step.

I followed mobile platform iOS tutorial, something that is different when you actually follow the tutorial is having empty database, but in video after connecting to sync server there are 3 objects already.
having empty database causes results to be empty which means .realm is nil and writing will fail.
i went throw RealmTasks source code, to find the part where it adds an object after setting default realm and checks if its an empty database to add one object after.
i think this step should be added to tutorial code and probably to the video also.

Hi @euwars, the tutorial expects that you've followed the "Getting Started" steps. In fact, the second sentence of the tutorial states exactly that:

First, please follow the getting started instructions to get set up with sync and to launch the Mac version of RealmTasks.

Following those steps will ensure that the initial list already exists.

@jpsim yeah i did not see that my bad.


Question: Is pallet asset trait FrozenBalance correctly implemented ?

here the trait:
/// Trait for allowing a minimum balance on the account to be specified, beyond the
/// `minimum_balance` of the asset. This is additive - the `minimum_balance` of the asset must be
/// met *and then* anything here in addition.
pub trait FrozenBalance<AssetId, AccountId, Balance> {
	/// Return the frozen balance. Under normal behaviour, this amount should always be
	/// withdrawable.
	///
	/// In reality, the balance of every account must be at least the sum of this (if `Some`) and
	/// the asset's minimum_balance, since there may be complications to destroying an asset's
	/// account completely.
	///
	/// If `None` is returned, then nothing special is enforced.
	///
	/// If any operation ever breaks this requirement (which will only happen through some sort of
	/// privileged intervention), then `melted` is called to do any cleanup.
	fn frozen_balance(asset: AssetId, who: &AccountId) -> Option<Balance>;

	/// Called when an account has been removed.
	fn died(asset: AssetId, who: &AccountId);
}

So I expected that an account should always have more than min+frozen, except for priviledge operation like some root stuff.
but minting less than this amount is allowed, and transferring less than this amount is also allowed and result with an account for which the property doesn't hold.
#[test]
fn foo() {
	let asset_id = 0;
	set_frozen_balance(asset_id, 1, 100);
	set_frozen_balance(asset_id, 2, 100);
	new_test_ext().execute_with(|| {
		assert_ok!(Assets::force_create(Origin::root(), asset_id, 1, true, 1));
		assert_ok!(Assets::mint(Origin::signed(1), asset_id, 1, 100)); // Should fail because min of 1 is 101
		assert_eq!(Assets::balance(asset_id, 1), 100); // Should be 0 as its min is 101
		assert_ok!(Assets::mint(Origin::signed(1), asset_id, 3, 100));
		assert_ok!(Assets::transfer(Origin::signed(3), asset_id, 2, 100));
		assert_eq!(Assets::balance(asset_id, 2), 100); // Should be 0 because min of 2 is 101
	});
}

Either we should add some more check in the code.
Or we should update the doc saying that an account can have less than asset_min_balance + frozen_amount_for_the_account but just cannot go below it in case it is was above before.
Or do I miss something ?
Also other note: there is a mention of melted but I can't find it in the code.

That's right - it should really say "the balance may not be reduced to become less than minimum_balance + frozen_balance".


Image in history.html is pixelated.

Image in history.html is blurred but pixelated.

@KamalNanda did you check this one?


Support for HTTP/2 Server Push

HTTP/2 has support for server push of resources. It isn't clear how popular this feature is these days. For some background information, see https://jakearchibald.com/2017/h2-push-tougher-than-i-thought/.
Support for HTTP/2 server push would require the introduction of some new API in Helidon. I'm marking it as low priority since it hasn't been requested by our users yet.

This may no longer be needed, as browsers seem to go away from it, see for example https://www.ctrl.blog/entry/http2-push-chromium-deprecation.html

Closing this issue as server push is not requested


SVG icons are drawn with the top-left corner as pivot

should be centre-centre

Solved as of the commit referenced above.


refactor: overhaul

fix #11 #12 #13 #14 #15 #18

Usually it's not ideal to fix so many issues at once, but since the codebase was small and there were so many issues, it's essentially like building it from scratch anyway


Git vscode commands on toggled files in the scm view

I would like to be able to use git.clean, git.stage and git.unstage while having files selected but not opened in the scm view.
If i rightclick on the selected files and click on discard changes, stash, or press the icons hovering over the files it works fine, but calling the mentioned commands does nothing:

The command seems to only work if i open the tracked file in the scm view but will only run on said file, not taking the other highlightet ones into account.
I use the vim plugin and in the file explorer, e.g., i can highlight files with list.toggle and then delete them with deleteFile and would love to do these git commands aswell without using the mouse.

As a potential workaround, could you try the following:

Select the resources in the list
Press Shift + F10 (editor.action.showContextMenu) which should reveal the context menu
Pick the desired action from the context menu and press ENTER

Thanks, i tried to remap editor.action.showContextMenu to something easier, but it doesn't have the same functionality as pressing shift and f10. If you call editor.action.showContextMenu, it opens the context menu on where your cursor was in the code. Or is there a workaround for that too?

/gifPlease

Pressing Shift + Alt + f10:

Pressing a shortcut for editor.action.showContextMenu:

Even tho i am highlighting the scm files.

Thanks! So using Shift + Alt + F10 is working as expected based on your screenshot, correct?

As a potential workaround, could you try the following:

Select the resources in the list
Press Shift + F10 (editor.action.showContextMenu) which should reveal the context menu
Pick the desired action from the context menu and press ENTER

Activating the context menu via a hotkey is a nice workaround for now 🙏🏼
But assigning a single hotkey for actions would be better, as outlined here:

https://github.com/microsoft/vscode/issues/211519

I can confirm that assigning a hotkey to open the context menu doesn't work.
It's opened in the code viewer instead of the source control panel (as shared by the author).
If it worked, we could potentially use the macros extension to achieve the desired result.
But I honestly think the regular hotkey assignment for an scm action should run on the highlighted files in the source control panel.


getFieldNameByExprId returning id or returning name?

I'm modifying blaze to execute DataSourceExec, mainly by just hook into parquet scan exec. running into
Job aborted due to stage failure: Task 0 in stage 1.0 failed 1 times, most recent failure: Lost task 0.0 in stage 1.0 (TID 2) (<IP_ADDRESS> executor driver): java.lang.RuntimeException: called `Result::unwrap()` on an `Err` value: Plan("cannot create execution plan: DataFusionError(ArrowError(SchemaError(\"Unable to get field named \\\"#12\\\". Valid fields: [\\\"id\\\", \\\"data\\\"]\")))")

  def getFieldNameByExprId(expr: NamedExpression): String =     s"#${expr.exprId.id}"

it seems filter/projection is using this to extract exprId as column references, but ParquetScanExec is providing names ?

it's OK to provide names than exprids in scan. but you have to wrap it with a RenameColumnsExec to output batches with the correct name using addRenameToColumnsExec like this code.

it's OK to provide names than exprids in scan. but you have to wrap it with a RenameColumnsExec to output batches with the correct name using addRenameToColumnsExec like this code.

thank you very much for the answer.  it's just the names of the method are not connecting the two.


Make signed.requests mandatory for trusted proxies

This issue is imported from pivotal - Originaly created at Jan 2, 2018 by Bart Geesink
When the redirect.sign checkmark is not ticked for a trusted proxy, the ARP and ACL of the SP in the requesterid are ignored, and the ACL and ARP of the trusted proxy are applied in stead. This should not happen. Signed requests are mandatory for a trusted proxy, engineblock should exit with an error message when this is the case.

Without redirect.sign none of the trusted proxy actions are performed by EB. This includes setting the NameID in the EPTI for the SP in the RequesterID. (Pieter van der Meulen - Sep 26, 2018)

Looking at the Behat functional tests. I see a test that demonstrates the faulty behavior.

https://github.com/OpenConext/OpenConext-engineblock/blob/ddaf13ddbd56a03e5e0675ddeced1c3438f9af01/src/OpenConext/EngineBlockFunctionalTestingBundle/Features/SpProxy.feature#L79-L90
Line 83 was commented out after the original test was written. And a comment was added: # Test to see that we don\'t trust trusted proxies without request signing
This implies that a different point of view was applied previously. This test will no longer pass with the upcoming change, where this configuration would result in a 500 error.
Looking at the proposed solution. In my opinion this behavioral change seems rather hard. Or is the rule that trusted proxies MUST sign their requests implemented strictly in our federation? Then again, other EB users might rely on this buggy behavior we are about to restrict.
@pmeulen @bartgeesink @thijskh how do we want to proceed? (Michiel Kodde - Aug 12, 2020)

I see two cons of the current behaviour and no clear pro, unless there is a trusted proxy (TP) out there that actually relies on this behaviour:

Is more complex: allowing unsigned requests from a trusted proxy (TP) and then not performing the trusted proxy steps for is more complex to implement and test
If for some reason a trusted proxy omits the signing of the requests, and then processes the request as if it was processed by EB as a TP request this could lead to all kinds of undesired behaviour. ACLs and authorization rules are different from what the TP expects, targeted identifiers and attributes for the TP are passed to another entity. It is not easy to detect this when the response is verified.

So the question is: would anything break if we change this. Probably not, there are few TPs. The stepup-gateway does not use it - it always signs - and bart, the requester, manages the openid connect gateway projects. To be sure, ask the OpenConext community. (Pieter van der Meulen - Aug 12, 2020)

Thanks for your reply @pmeulen. I have posted this question on the OC Slack. And until now there are no objections. So I see no problems myself with moving on. (Michiel Kodde - Aug 13, 2020)

I think the original approach has the same functional requirement in base ("requests from a trusted proxy must be signed") but the implementaion preferred a soft fail ("fall back to original behaviour").
I "have a brother dead" as we say in NL of this implicit behaviour in EB where it can suddenly 'fall back' to other behaviour. I much prefer that this is made explicit: "you said this is a trusted proxy, but it does not sign, something is broken, error", not "you said it's a trusted proxy but it does not sign, try do do something regardless".
I think that is exactly the origin of this story. That we saw confusing behaviour when the request was not signed and it was hard to debug to find the cause of this.
So all for changing the functional tests and making EB's behaviour another step more explicit. (Thijs Kinkhorst - Aug 17, 2020)


D = 02

Confirmed that you can drive motor plugged into D with 02. (from the Boost Remote app code, and tested with gatttool)

Thanks.
How do I find Boost Remote App code?

It's here https://github.com/bricklife/BoostRemote
Main files you would want to look at are the Swift files here https://github.com/bricklife/BoostRemote/tree/master/BoostRemote
Works quite nicely for controlling the motors from the iPhone.

Thanks. Saw that this morning but didn't notice any code.


How to properly remove item from adapter?

I tried to remove item from adapter's list and call notifyDatasetChanged, but it threw an error about list index.
Please tell me the correct way to remove item.
Thank you.

Hi @aratn0n. Sorry for late reply.
Please checkout new version of the library with ability to remove items from adapter's list.


Select menu is rendered behind some custom dialog components

Describe the bug
I noticed when evaluating melt via a standard select component that a barebones component (essentially copied the one from documentation) wasn't rendering. I was trying to implement a simple options/settings dialog with a select as one of the fields. Inspecting the element also showed no popover div or layout shift in the markup.
I was able to get the component to behave correctly by implementing it top level in +page.svelte.
Reproduction shows the issue very clearly.
Reproduction
https://stackblitz.com/~/github.com/jmkmay/meltui-select-modal-bug
https://github.com/jmkmay/meltui-select-modal-bug
Logs
No response
System Info
System:
    OS: macOS 13.5.2
    CPU: (16) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
    Memory: 395.51 MB / 32.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 18.17.1 - ~/.nvm/versions/node/v18.17.1/bin/node
    npm: 9.6.7 - ~/.nvm/versions/node/v18.17.1/bin/npm
    pnpm: 8.10.5 - ~/.nvm/versions/node/v18.17.1/bin/pnpm
    bun: 1.0.0 - ~/.bun/bin/bun
  Browsers:
    Chrome: 122.0.6261.94
    Safari: 16.6
  npmPackages:
    @melt-ui/svelte: ^0.74.4 => 0.74.4
    @sveltejs/kit: ^2.0.0 => 2.5.2
    svelte: ^4.2.7 => 4.2.12

Severity
blocking all usage of Melt UI

z-100 isn't a valid class. Updating the menu to z-[100] addresses your issue.


Bugfix/home page typo

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: Ian-Topper sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


Fix for GDScript language

This is a "partial" fix for #1528 (*.gd files mis-recognized as GAP).
Added a heuristic rule to match 2 common expressions in GDScript

extends expression:

# Inherit/extend a globally available class
extends SomeClass

# Inherit/extend a named class file
extends "somefile.gd"

# Inherit/extend an inner class in another file
extends "somefile.gd".SomeInnerClass

class expression:

class SomeClass:

I've tested these rules with some GDScript and GAP repos.
Added a color to GDScript

Language color from official logo.

Travis-CI failing in TestColorProximity 😕
The following 3 languages have failing color thresholds. Please modify the hex color.
- GDScript (#478cbf) is too close to ["6594b9", "3F85AF", "478cbf", "0096D8", "198CE7"]
- Processing (#0096D8) is too close to ["478cbf", "0096D8"]
- R (#198CE7) is too close to ["478cbf", "198CE7"]

Here another example of mis classifications my GDScripts as GAP and event .gittributes with*.gd linguist-language=GDScript do fix this :(

Nudge @williamd1k0. Are you able/willing to address @pchaigno's https://github.com/github/linguist/pull/3478#pullrequestreview-23146668 ?


Fix ignoring time zone bug

Closes
#90, #91 issues.
Solution by @hrvali

@hekmatinasser

@hekmatinasser

@hekmatinasser
Please accept this PR ASAP, library won't work correctly without this PR!!

@hekmatinasser
Please accept this PR ASAP, library won't work correctly without this PR!!


Have Avalonia.ReactUI use SharedAssemblyInfo

Could you merge these PRs into one? They're all doing the same thing so it makes sense to put them together and merging them all separately is going to take a lot of Update Branch/Wait for CI/Merge iterations.
Also could you add a description of what problem this solves?


Nettruyen change URL

Source information
NetTruyen 1.4.35
Source language
Vietnamese
Source new URL
https://nettruyencc.com/
Other details
No response
Acknowledgements

[X] I have updated all installed extensions.
[X] I have opened WebView and checked that the source URL has not changed yet.
[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] I will fill out all of the requested information in this form.

Please see the conversation in #2887, if you have any additional information about this source & the validity of the source URL, please mention in there

I would like to confirm that this is the current URL of NetTruyen, it may not be changed within a few weeks, so I hope you can update the URL again, sorry for doing it. sorry guys

Please see the conversation in #2887, if you have any additional information about this source & the validity of the source URL, please mention in there

I would like to confirm that this is the current URL of NetTruyen, it may not be changed within a few weeks, so I hope you can update the URL again, sorry for doing it. sorry guys

English : you can use unoriginal nettruyen (it's on the source)
Vietnamese: Bro có thể dùng source unoriginal nhé (btw admin nettruyen như kiểu đem con bỏ chợ ý) nhà dịch cx chỉ có 1 thông báo th

nettruyencc.com is not the same as the current extension. Open a feature request to override the baseUrl as a setting or make a source request for this site.

Please see the conversation in #2887, if you have any additional information about this source & the validity of the source URL, please mention in there

I would like to confirm that this is the current URL of NetTruyen, it may not be changed within a few weeks, so I hope you can update the URL again, sorry for doing it. sorry guys

English : you can use unoriginal nettruyen (it's on the source) Vietnamese: Bro có thể dùng source unoriginal nhé (btw admin nettruyen như kiểu đem con bỏ chợ ý) nhà dịch cx chỉ có 1 thông báo th

English: I've installed the unoriginal source but still can't access it, but all I know is that nettruyen has just been through two generations of owners, the official revival date is unknown. Probably in about a month it will be stable again, Net Truyen is like phimmoi, it can't die
Vietnamese: Đã cài source unoriginal rồi nhưng mà vẫn không vào được, nhưng mà chỉ biết là giờ nettruyen mới qua 2 đời chủ thôi, ngày hồi sinh chính thức thì chưa rõ. Chắc tầm 1 tháng nữa thì sẽ về ổn định lại, NetTruyen như phimmoi ấy mà, không chết nổi được

Please see the conversation in #2887, if you have any additional information about this source & the validity of the source URL, please mention in there

I would like to confirm that this is the current URL of NetTruyen, it may not be changed within a few weeks, so I hope you can update the URL again, sorry for doing it. sorry guys

English : you can use unoriginal nettruyen (it's on the source) Vietnamese: Bro có thể dùng source unoriginal nhé (btw admin nettruyen như kiểu đem con bỏ chợ ý) nhà dịch cx chỉ có 1 thông báo th

English: I've installed the unoriginal source but still can't access it, but all I know is that nettruyen has just been through two generations of owners, the official revival date is unknown. Probably in about a month it will be stable again, Net Truyen is like phimmoi, it can't die
Vietnamese: Đã cài source unoriginal rồi nhưng mà vẫn không vào được, nhưng mà chỉ biết là giờ nettruyen mới qua 2 đời chủ thôi, ngày hồi sinh chính thức thì chưa rõ. Chắc tầm 1 tháng nữa thì sẽ về ổn định lại, NetTruyen như phimmoi ấy mà, không chết nổi được

English: Nettruyenco extension just work fine, so you can use this, and for now nettruyen don't have anything activities to translator and user for now (I think a part ò reason from Japanese television)
Vietnamese: em thấy nettruyenco dùng oke á (nettruyen bế quan lâu lắm r mà chx thấy động tĩnh gì chắc là bo bị bế pên đài bebe nhật ý mà)


"FileNotFoundError: --match_dir or --matrix_dir is required" when running "celescope vdj count_vdj"

Hi,
I created a script "bcr.sh" by command "multi_vdj --ref_path /xxx/Singleron/db/vdj/human_IG --species human --gzip --type BCR --mapfile bcr.dsp.mapfile --thread 10 --mod shell".
The last step of the script is “celescope vdj count_vdj". When running this step, an error occurred:

Args: Namespace(subparser_assay='vdj', type='BCR', UMI_min=3, BCR_iUMI=2, TCR_iUMI=1, expected_target_cell_num=3000, target_cell_barcode=None, target_weight=3.0, UMI_count_filter_file='.//bcr/04.mapping_vdj/bcr_UMI_count_filtered.tsv', match_dir='None', matrix_dir=None, outdir='.//bcr/05.count_vdj', sample='bcr', thread='10', debug=False, func=)
Traceback (most recent call last):
  File "/mnt/sata/mao/za/bcr.tcr/Singleron/celeScope3/bin/celescope", line 8, in
    sys.exit(main())
  File "/mnt/sata/mao/za/bcr.tcr/Singleron/celeScope3/lib/python3.9/site-packages/celescope/celescope.py", line 44, in main
    args.func(args)
  File "/mnt/sata/mao/za/bcr.tcr/Singleron/celeScope3/lib/python3.9/site-packages/celescope/vdj/count_vdj.py", line 318, in count_vdj
    with Count_vdj(args, display_title="Count") as runner:
  File "/mnt/sata/mao/za/bcr.tcr/Singleron/celeScope3/lib/python3.9/site-packages/celescope/vdj/count_vdj.py", line 85, in __init__
    raise FileNotFoundError("--match_dir or --matrix_dir is required.")
FileNotFoundError: --match_dir or --matrix_dir is required.

In the link, the missing options are match scRNA. What if we don't have such info?
I attached full screen output of the script and the script itself (slightly modified for more useful screen output) for your convenience. Feel free to let me know if further info needed.
screen.output.txt
bcr.sh.txt

You need to fill the 4th column in the mapfile with matched_dir and regenerate the shell script. Then the --match_dir argument will appear in the count_vdj step.
celescope vdj count_vdj  --match_dir ../../celescope_test_data/vdj/fake_match_dir ...

https://github.com/singleron-RD/CeleScope/blob/master/docs/vdj/multi_vdj.md#arguments
4th column: The 4th column has different meaning for each assay. The single cell rna directory after running CeleScope is called matched_dir.

vdj Required, matched_dir.

It worked.. Thanks!


Switched to JVM Toolchain

Fixes compatibility problems when an incorrect JVM version is set as the system default

@rudi can you confirm that we can merge this?

@rudi can you confirm that we can merge this?

Looks ok, if all tests pass