🚀 Feature: Allow default plugins to have default configuration

🔖 Feature description
PR https://github.com/backstage/backstage/pull/18699 enabled passing a string[] of defaultPlugins to MkDocs' configuration but, as it's only a string[], configuration of those plugins isn't accepted.
Several users have requested this feature, particularly around configuration of Kroki's ServerUrl and FencePrefix. Requiring a user to set this configuration themselves means the set of defaultPlugins is cleared and they need to re-add each plugin, regardless of whether they're passing configuration for it.
🎤 Context
Below is a common example of how most users expect this feature to work—as well as providing a list of plugins, they provide their configuration too. This is useful when you want consistency across an organisation, for example, ensuring that all users use a known endpoint when configuring a plugin:
defaultPlugins:
  - techdocs-core
  - awesome-pages
  - kroki:
      FencePrefix: ''
      ServerUrl: 'https://myprivatekrokiserver.com'
  - myOtherPlugin:
      MyConfig: '...'

✌ Possible Implementation
Allowing defaultPlugins to accept an object[] instead of a string[].
A default mkdocs file has been discussed too, although I think most users would still need to set their structure, site title etc. so unless this uses some form of inheritance or extensibility, I don't think this approach will work.
👀 Have you spent some time to check if this feature request has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

Are you willing to submit PR?
No, but I'm happy to collaborate on a PR with someone else

Hi @tudi2d @asos-robbell is this issue is still open?
if yes, i would like to work on this issue.

Hi @tudi2d @asos-robbell is this issue is still open?
if yes, i would like to work on this issue.

Hi @krunalhinguu, yes this is till open. Let me know if you'd like any assistance.

@asos-robbell do you have some more information related to this change. Incase you have some existing approach for this change we can discuss that too

Hi @krunalhinguu, it looks as though the feature to add a string[] of plugins (https://github.com/backstage/backstage/pull/18699) was influenced by the CLI's capabilities—the CLI only accepts a string array too.
I've not thought about the plumbing required to enable default configuration for plugins, so all ideas welcome.

perfect. Thanks @asos-robbell
One another question, could you please guide me with how i can replicate this scenario or possible scenario which i can test once the work is done.

As per the approach I followed, I've made changes to the way we handle default plugins. Instead of using simple names (like strings), I've tried to accommodate detailed objects. I've ensured that these changes don't disrupt the existing system; everything still works as it did before. This new approach is akin to following a blueprint, ensuring that our system remains smooth and ready for future enhancements.

@krunalhinguu — I'd happily take a look at the PR if you'd like?


west update fails if app-path is more than 1 folder deep

If the app-path parameter, where the west.yml resides, is more than 1 folder deep, then this action fails when running west update because it says it can't find the workspace.
For example, if app-path is: folder1/folder2/, like so:
- name: Setup Zephyr project
      uses: zephyrproject-rtos/action-zephyr-setup@v1
      with:
        app-path: folder1/folder2/  # note - it does not seem to help if there is or is not a trailing slash here
        sdk-version: 0.16.0

then the build output looks like the following:
Run west init -l folder1/folder2/ --mf west.yml

=== Initializing from existing manifest repository folder2
--- Creating WORKSPACE_ROOT/folder1/.west and local configuration file
=== Initialized. Now run "west update" inside WORKSPACE_ROOT/folder1.
FATAL ERROR: no west workspace found from "WORKSPACE_ROOT"; "west update" requires one.
Things to try:
  - Change directory to somewhere inside a west workspace and retry.
  - Set ZEPHYR_BASE to a zephyr repository path in a west workspace.
  - Run "west init" to set up a workspace here.
  - Run "west init -h" for additional information.

note above WORKSPACE_ROOT is just the github action root working directory.
It seems the west update call should happen at app-path, or its parent.

@DavidVanKampen-eaton yeah, west init creates the workspace on the last directory and then everything falls apart. I tried to set ZEPHYR_BASE in the manifest but then it's a bit tricky to find out the requirement file so I propose to restrict app-path to a single directory and add a base-path variable with any prefix that can be used for all steps that depends on the application path.
I tested it on one of my test repo but could you check if it works for you? You can instantiate it like:
      - name: Setup Zephyr project
        uses: zephyrproject-rtos/action-zephyr-setup@refs/pull/21/head
        with:
          base-path: the/app/prefix
          app-path: app
          toolchains: arm-zephyr-eabi

(which would look for a manifest in the/app/prefix/app and do all other operations in the/app/prefix)
The refs/pull/21/head would be for a single test, if you confirm it works I'll have the change reviewed, merged and pushed on an updated v1 tag

@fabiobaltieri I tested this out and it appears functional - it gets through this composite action without error when the zephyr app is more than 1 folder down in the parent repository.  Thanks!

Great, thanks @DavidVanKampen-eaton I'll mege this and update v1 to use it.


More side effect oriented APIs?

I was working on an idea of declarative side effect management in React. Basically manage side effects as components such as Promises, Redirects, Title, MetaTags, WebWorkers, ...
I discussed the idea with Kent C. Dodds and he introduced me to this amazing library.
I like the idea. Are you having this in the roadmap so we could help make this happen?
I'd be happy to share what I've done so far and push this library forward.

How do you imagine <WebWorkers> component would work?
<Title> and <MetaTags> sound cool, I will definitely add those to libreact.
I have <Redirect> component in progress, which will be handy to use together with <Router>.
And there is a simple <Resolve> component that resolves promises.

Also, what would <Title> and <MetaTags> components do on server side?

I guess, on the server we would render into the  using isomorphic portal library.

Or maybe there could also be , , and  utilities that would allow you to render the whole universal app:
const App = () =>

      <Title>Hello world!</Title>

      <Router>
        <ThemeProvider>

{/* ... */}

        <ThemeProvider>
      </Router>

  </Html

Or maybe all of that could be compressed into a single isomorphic <Page> component:
const App = () =>
  <Page title='Hello world'>
      <Router>
        <ThemeProvider>

{/* ... */}

        <ThemeProvider>
      </Router>
  </Page>

Found react-helmet.

I assume  would work as below:
<WebWorker
  fn={someFuncHere}
  getWorkerInstance={worker => { this.worker =  worker}}
  onMessage={this.handleMessage}
/>

To achieve dynamic worker feature, we can use https://github.com/developit/workerize and transform fn prop to ESModule on the fly and let workerize handle the rest.

Other suggestion for side-effect components are:

Interrval
Timeout
Log (multiple levels with custom adapter default fallback to console)
Offline/Online
Keyboard events

For Offline/Online you can use NetworkSensor

@streamich How do you think about the webworker proposal?
And you keep referencing libreact. is that library connected to react-fns or you're just referencing for more details?

I like the <WebWorker> proposal, I'm thinking there could also be a <PostMessage> component and <WebWorker> could use it internally.
I am currently working on libreact, I'm just referencing stuff that is already implemented.


Tokens per sec

Jan.ai has a nice token speed count as the words are being output

please consider this feature as it helps quickly surface just how fast a model responds.

@potatoqualitee thank you for the proposal, we are adding more info to help developers get info on token usage, quota and throughput, etc.


🐛✅ Bugfix: don't throw away "0" string when creating streamed response

I had a bug where my response often got cut off, and instead of returning the year "2020" in the response, it would always return "202".
I found out that it only happens when streaming the response.
After looking around I found the issue to be inside of the OpenAIChat::createStreamedResponse() method.  There is a check there like this: if (! ($partialResponse->choices[0]->delta->content)) { continue; } but if the string is "0" then this also evaluates to true causing the "0" to be ignored when it's the only character in the partial response.
I changed this to explicity check whether the content is null or '' instead. I also added a test to validate that "0" is not thrown away anymore.

funny bug.. Thanks a lot @synio-wesley for the PR !


Get stacked when running test code

when I run the code :
python tools/valid.py --cfg experiments/coco/higher_hrnet/w32_512_adam_lr1e-3.yaml TEST.MODEL_FILE checkpoints/pose_higher_hrnet_w32_512.pth
Then I get stacked.  Memory and GPU still have much free

And I found the following print. What is the meaning of not avaliable ?  Looking forward replay! Thanks!

Grouping is done on CPU.
Not available means FLOPs is not calculated for this layer (which is ReLU).

I met the same problem，it stop at 》classes ：['backgroud','person']

I met the same problem，it stop at 》classes ：['backgroud','person']

have you solve it?


Disable if running in CI

Using CI and CONTINUOUS_INTEGRATION env vars. Some, such as Travis CI, simulate a TTY causing process.stdout.isTTY to return true.

I've written supports-semigraphics to handle this, including any future edge cases. It builds on your has-unicode library.


Deletion Time Period

Make it so you have 30 days to undo the deletion.
I will ask AI to code it in if u want,....

Not possible.


Netopeer2-server fails when connecting to ONOS controller

Hi All,
I am having troubles with connecting device via Netopeer2-server to ONOS controller.
I have Sysrepod, Sysrepo-plugind and Netopeer2-server running all correctly, when I use Netopeer2-cli i can configure the device no problem.
I am attempting the same but using ONOS controller instead of Netopeer2-cli.
When  try to connect to ONOS,  Netopeer2-server just hangs and keeps trying to reestablish the connection and asking for user authentication.
Please find logs attached.
netopeer-log-on-connect-to-onos.txt
onos-log-on-connecting-to-netopeer2-server.txt
I would  be grateful if you can please suggest on where I might have made a mistake or where should I change my configuration.
Thank you for your help.
Kind Regards,
Yuliya

Hi Yuliya,
I do not think it is a problem of your configuration and would blame the NETCONF client for doing something incorrectly because it is possible to connect to netopeer2-server with ssh(1), for example, but also several other clients. We may take a look later but I think you should try to contact the maintainers of the ONOS controller, if possible.
Regards,
Michal

Hi Yuliya,
we have made the effort and tried it. netopeer2-server always fails on ssh_handle_key_exchange() which is a function from libssh. So, either there is a bug in this function (highly unlikely) or ONOS controller is not correctly establishing SSH session.
Regards,
Michal

Hi Michal,
Thanks for your help.
It seems to be a bug in the onos controller side.
Kind Regards,
Yuliya

From: Michal Vasko<EMAIL_ADDRESS>Sent: Tuesday, July 24, 2018 1:47 PM
To: CESNET/Netopeer2
Cc: Yuliya Verbishchuk; Author
Subject: Re: [CESNET/Netopeer2] Netopeer2-server fails when connecting to ONOS controller (#299)
Hi Yuliya,
we have made the effort and tried it. netopeer2-server always fails on ssh_handle_key_exchange() which is a function from libssh. So, either there is a bug in this function (highly unlikely) or ONOS controller is not correctly establishing SSH session.
Regards,
Michal
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/CESNET/Netopeer2/issues/299#issuecomment-407394211, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AdAspfAQSG0FX4k_Mi-wI3cVkD2MSk2wks5uJxdVgaJpZM4VbS_1.

Hi Michal,
We still work on this problem, I have made a few changes such as
I have done the following in ONOS 1.14
ssh-keygen -t rsa
cat ~/.ssh/id_rsa.pub > cat ~/.ssh/authorized_keys
and then run onos and send json file as usual to onos.
The error I am getting now is different. It looks like netopeer2-server tries to connect, makes 5 attempts and then just segfaults.
Can you please advise on what could be an issue?
Please find the logs attached.
Thank you kindly for your help.
netopeer2-server-log-after-pushing-keys.txt
onos-1.14-log-after-pushing-ssh-keys2.txt
Kind Regards,
Yuliya

Hi Yuliya,
I see no actual difference and from the output it seems the server crashes at the same place, ssh_handle_key_exchange(). So, nothing we can do about it, there is a problem in the client. You could perhaps report this problem to libssh because I guess it should not crash no matter what the client sends.
Regards,
Michal

Hi Michal,
Thank you, I have also checked and seen that its fails on ssh_handle_key_exchange() but was wondering if I missed anything.
Thank you for your help and suggestion, I will try to contact libssh to see what they think could cause this problem.
Kind Regards,
Yuliya

From: Michal Vasko<EMAIL_ADDRESS>Sent: Wednesday, August 01, 2018 2:36 PM
To: CESNET/Netopeer2
Cc: Yuliya Verbishchuk; Author
Subject: Re: [CESNET/Netopeer2] Netopeer2-server fails when connecting to ONOS controller (#299)
Hi Yuliya,
I see no actual difference and from the output it seems the server crashes at the same place, ssh_handle_key_exchange(). So, nothing we can do about it, there is a problem in the client. You could perhaps report this problem to libssh because I guess it should not crash no matter what the client sends.
Regards,
Michal
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/CESNET/Netopeer2/issues/299#issuecomment-409577051, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AdAspbZo2WCBVp11jYiIjakNWJ2KtLJwks5uMa7ugaJpZM4VbS_1.


[Frequency] Check Child Tree Weights using V2.0

Problem
We are using child tree to store private graph pages. All of weight calculations was being done using Weights 1.0 and to verify if still that design makes sense we need to re calculate storage weights for DB_READ and DB_WRITE using benchmark storage command on a pre-populated database with pages.
some of code for pre-populating exists in https://github.com/Liberty30/substrate_experiments/tree/child_tree_benchmarks

Updated the estimates based on all recent weights https://docs.google.com/spreadsheets/d/1gIYWfkRhRCVG5ZyT5jIHjgxutmSeXhVzFht0eORCEys/edit?usp=sharing


Is it safe to reveal access token in js?

Just curious! normally access tokens are meant to keep secret but in this case we're putting it in js file. Does it use read-only token?

Exposing your access token shouldn't be a problem. Instagram has provided an implicit authentication flow exactly for this reason - so we can use access tokens client side. Remember, you can only use the API to retrieve media from your own account or an account that has been approved. It's your Client ID and Client Secret that you'll want to keep hidden.


[BUG] MOES (Tuya) BHT-002-GCLZBWT alias _TZE200_aoclfnxz - Setting of a temperature offset is not possible

Bug description
Within ZHA it is not possible to customize with the option "Manage zigbee device" the local temperature offset of the thermostat. So far, I used a Deconz stick, but would like to test on SkyConnect as well. With the Conbee II from Deconz, setting a temperature offset works flawlessly.
Home Assistant 2023.9.2 Supervisor 2023.09.2 Operating System 10.5 Frontend 20230911.0 - latest
"versions": {
"bellows": "0.36.3",
"zigpy": "0.57.1",
"zigpy_deconz": "0.21.1",
"zigpy_xbee": "0.18.2",
"zigpy_znp": "0.11.4",
"zigpy_zigate": "0.11.0",
"zhaquirks": "0.0.103"
}
Steps to reproduce

Go in settings of HA to Device & Services/Zigbee Home Automation
Click on the first entry in the list (your number) devices
Select _TZE200_aoclfnxz TS0601
Click next to RECONFIGURE on the three dots
Select "Manage Zigbee device"
Select under CLUSTERS "MoesBHTThermostat (Endpoint id: 1, Id: 0x0201, Type: in)"
Select under Attributes of the selceted cluster "local_temperature_calibration (id: 0x0010)"
Enter in Manufacture code to override the desired Value, e.g. 100 (this represents a shift of 1 degree Celsius upwards)
Click Write attribute
Click Read attribute
Value = None

Expected behavior
In the case of the above example, the expectation is that value = 100 is specified.
Screenshots/Video
Screenshots/Video

Device signature
Device signature
_TZE200_aoclfnxz

Diagnostic information
Diagnostic information
[Paste the diagnostic information here]

Logs
Logs
[Paste the logs here]

Additional information
Corresponding quirk for that device  = zhaquirks/tuya/ts0601_electric_heating.py

Temp calibration is supported under custom quirk at:
https://github.com/jacekk015/zha_quirks
use quirk file:
ts0601_thermostat_avatto.py

Temp calibration is supported under custom quirk at: https://github.com/jacekk015/zha_quirks
use quirk file: ts0601_thermostat_avatto.py

Thanks, I tested the Quirk file and yes, the calibration for _TZE200_aoclfnxz works. But the decimal point of the current temperature of the thermostat displayed in HA has unfortunately slipped one place to the right - instead of 22.5 degrees celsius 225 degrees celsius.

There's no guessing here. Someone with that Thermostat id confirmed that all is OK.
So either he was lying or chineese friends made a change in the firmware using same id. Later I'll try to look at Z2M code for that Thermostat.
I can't change that back and forth because next guy will ask me to revert those changes back.
Sometimes they use same id with other device_version parameter.
Paste here full signature from device panel or better use 3-dots menu and put here Device diagnostics

I compared the previously used quirk with this one and found that the values for the DIRECT_MAPPED_ATTRS are different.
I changed:
DIRECT_MAPPED_ATTRS = {
    AVATTO_TEMPERATURE_ATTR: (
        "local_temperature",
        lambda value: value * 100,
        lambda value: value * 10,
    ),
    AVATTO_TARGET_TEMP_ATTR: (
        "occupied_heating_setpoint",
        lambda value: value * 100,
        lambda value: value * 10,

to
DIRECT_MAPPED_ATTRS = {
    AVATTO_TEMPERATURE_ATTR: (
        "local_temperature",
        lambda value: value * 10,
    ),
    AVATTO_TARGET_TEMP_ATTR: (
        "occupied_heating_setpoint",
        lambda value: value * 100,

and now it works.
Here is still the device diagnostic file.
zha-fec7d948e227df4df792df21d0014c72-_TZE200_aoclfnxz TS0601-6ebe4206c1cf5134efa5cd13a6f0ce84.json.txt

Your TRV i Z2M is here
https://github.com/Koenkk/zigbee-herdsman-converters/blob/master/src/devices/moes.ts#L100
and room temp code is here, in legacy file
https://github.com/Koenkk/zigbee-herdsman-converters/blob/master/src/lib/legacy.ts#L3851
There are some exceptions for other TRV than: _TZE200_u9bfwha0, _TZE200_aoclfnxz
So probably those two behaves similar.
My quirk had exception for _TZE200_u9bfwha0 but I had no one with TRV _TZE200_aoclfnxz
Quirk in repo has been modified to work properly.
If you had gave me debug logs from HA I could check it myself.
Again - quirk modified.
https://github.com/jacekk015/zha_quirks
ts0601_thermostat_avatto.py

Your TRV in Z2M is here https://github.com/Koenkk/zigbee-herdsman-converters/blob/master/src/devices/moes.ts#L100
and room temp code is here, in legacy file https://github.com/Koenkk/zigbee-herdsman-converters/blob/master/src/lib/legacy.ts#L3851
There are some exceptions for other TRV than: _TZE200_u9bfwha0, _TZE200_aoclfnxz So probably those two behaves similar. My quirk had exception for _TZE200_u9bfwha0 but I had no one with TRV _TZE200_aoclfnxz
Quirk in repo has been modified to work properly. If you had gave me debug logs from HA I could check it myself. Again - quirk modified.
https://github.com/jacekk015/zha_quirks ts0601_thermostat_avatto.py

Thanks, I tested the quirk, and it seems to work now with tze200_aoclfnxz. Here is the debug log to check.
home-assistant_zha_2023-10-20T09-45-20.000Z.log
Can I ask one more thing. I also have brand new tze204_aoclfnxz thermostats from Moes (It looks just like tze200_aoclfnxz BHT-002, so it is a replacement for its predecessor). I found that there are https://github.com/jacekk015/zha_quirks/blob/main/ts0601_thermostat_avatto2.py for tze204_xxxxxxxx thermostats of this type. Unfortunately, an attempt at a quick fit failed. The thermostat was recognized, but he could not be turned on. Can we try to adjust this thermostat as well?

Can I ask one more thing. I also have brand new tze204_aoclfnxz thermostats from Moes (It looks just like tze200_aoclfnxz BHT-002, so it is a replacement for its predecessor). I found that there are https://github.com/jacekk015/zha_quirks/blob/main/ts0601_thermostat_avatto2.py for tze204_xxxxxxxx thermostats of this type. Unfortunately, an attempt at a quick fit failed. The thermostat was recognized, but it could not be turned on. Can we try to adjust this thermostat as well?
I can make the thermostat come to live with this quirk https://github.com/zigpy/zha-device-handlers/issues/2433#issuecomment-1690198060 , but it has no way to change the temperature offset.

For your _TZE204_aoclfnxz test updated file:
ts0601_thermostat_avatto.py
from: https://github.com/jacekk015/zha_quirks
Next time better don't mix different TRV's in one thread. Later people can get wrong quirk.

Thanks, I tested the quirk, and it works flawless as well with _TZE204_aoclfnxz.


Karibu Vaadin 8 for Spring Boot 3

Hey! Karibu is nice tool, but it looks like it is not adapted for being used with Vaadin 8 and Spring Boot 3.
Maybe you can prepare some addon for this?
Best regards,
Nikolay

@simasch Vaadin 8 has extended support until 2032. Some companies are using it.

I know. The biggest problem is the architecture. This would require a complete rewrite of Karibu Testing and for a product that is end of life not worth the effort.

Hm... the only issue is that javax package was replaced by jakarta, I thought it would be very simple task.

Thanks @simasch . I don't think it's possible without extended support either:

Vaadin 8 uses javax APIs while Spring Boot 3+ uses jakarta APIs.
There's Vaadin 8 build which uses jakarta APIs and is in theory compatible with Spring Boot 3, but that for sure requires a paid extended support.
Vaadin 8 is only supported in Karibu-Testing 1.3.x which is no longer maintained.
Vaadin + Kotlin DSLs was meant to support a new way of building apps; new way of building apps doesn't combine with Vaadin 8.
Karibu-Testing is OSS; it's not a goal of this project to support commercial offerings.

That being said, you can fork Karibu-Testing 1.3.x, make it work with jakarta APIs, then create an example project of Karibu+Vaadin8jakarta+SB3. If that works, we can then discuss some way of merging this back and releasing a new Karibu for Vaadin8jakarta. Alternatively, please feel free to reach out to the Vaadin company itself and have Vaadin do it as a sponsored development.

Hm... the only issue is that javax package was replaced by jakarta, I thought it would be very simple task.

True, that indeed is; but there are other tasks as well:

make sure GitHub Actions use Vaadin license when running tests
investigate which Vaadin 8 version to use
Do the change and fix any incompatibilities introduced by Vaadin version upgrade
prepare a Vaadin8+SB3 example app + write tests for it + prepare GitHub Actions to run those tests
update documentation


train acc loss, validation acc tensorboard graphs are added

train loss comes from train dataset, train acc comes from train dataset but in test mode so we dont have data augmentation for this dataset and validation accuracy comes from validation dataset are calculated and logged in tensorboard during train time

Hi
@YCAyca
We are grateful for your efforts in helping improve this open-source project during your personal time.
Welcome to join OpenMMLab Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us ：https://discord.gg/UjgXkPWNqA
If you have a WeChat account，welcome to join our community on WeChat. You can add our assistant ：openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends：）
Thank you again for your contribution❤

Hi, how to compute validation loss each epoch along with training loss? Pl help me if any code base... I have ur codes but val_loss computation is not there in eval_one_epoch(....). Kindly help me in this regard


Please update cookies file

Hi,
Cookies file that was released in Aug can not be downloaded now.
The outdated link is _https://chrome.google.com/webstore/detail/cookiestxt/njabckikapfpffapmjgojcnbfjonfjfg_
Can you release a new cookies file?
Thanks a lot for your help!

Hi @GuitarZH, according to my understanding, cookie file should be for each person to download age restricted videos. Please follow this to generate your own cookie file. Thank you!

I truly appreciate your timely help！I will try this to download all videos that are mentioned in DoTA dataset.  Thanks for describing the method of generating cookie file in readme.md.

Great, thanks!


Frontier - Add Rizon

@jayjay-crypto fantastic job with these PRs. The only issue is that we can't add atolo to the Trade Router with such low liquidity. Are we able to get this up to at least $1000? alternatively we can add it without adding to the Trade page...

Hi Jeremy, we will check the swap fee.
Does $1000 means pool size?

Hi Jeremy, we will check the swap fee. Does $1000 means pool size?

Thanks for checking, as 2% is unusual and much higher than all other pools in the trade router.
Yes, the $1000 is referring to total pool size.

pausing Frontier additions. Will create a new PR to add as a Frontier token to refactored branch.

Can we please use secure (https) for the endpoints? The current ones do not respond to https...

Hi @JeremyParish69 sorry for the late feed back. Rizon's team have open a new pool with good fees, 0.2%, and more liquidity, it's pool 729. Can we re-add Rizon to the router and finish the PR


Remove the @generated function hack, and instead add include statements inside the __init__() function

Interesting, if this works that'd be a nice way to revert back to the old API.

Interesting, if this works that'd be a nice way to revert back to the old API.

I think the newer functions approach actually has advantages and could be the recomended way of accessing information.
It could let you redefine constants for testing purposes, e.g.
VectorizationBase.register_size() = 16

I think the newer functions approach actually has advantages and could be the recomended way of accessing information.
It could let you redefine constants for testing purposes, e.g.
VectorizationBase.register_size() = 16

BTW, we cannot use eval or @eval in any of the source code files in the src/nonprecompileable folder, because that would break things in any package that depends on VectorizationBase.
So I'll work on fixing that.

BTW, we cannot use eval or @eval in any of the source code files in the src/nonprecompileable folder, because that would break things in any package that depends on VectorizationBase.
So I'll work on fixing that.

I think the newer functions approach actually has advantages and could be the recomended way of accessing information.
It could let you redefine constants for testing purposes, e.g.
VectorizationBase.register_size() = 16

Sounds good. Let me first get this PR passing tests, and then we can restore those APIs where we want.

I think the newer functions approach actually has advantages and could be the recomended way of accessing information.
It could let you redefine constants for testing purposes, e.g.
VectorizationBase.register_size() = 16

Sounds good. Let me first get this PR passing tests, and then we can restore those APIs where we want.

Also, this package hasn't depended on CpuId for a little while now. Not sure how the cpuid file reappeared.
I liked the consolidation of multiple cpuinfo and topology files into one.

Also, this package hasn't depended on CpuId for a little while now. Not sure how the cpuid file reappeared.
I liked the consolidation of multiple cpuinfo and topology files into one.

I think the newer functions approach actually has advantages and could be the recomended way of accessing information.
It could let you redefine constants for testing purposes, e.g.

So, I gave this a try, but if we define functions inside source files that are include-d inside __init__(), we run into world-age problems.
I think the best approach for redefining the constants is going to be to allow overrides with environment variables at runtime.

I think the newer functions approach actually has advantages and could be the recomended way of accessing information.
It could let you redefine constants for testing purposes, e.g.

So, I gave this a try, but if we define functions inside source files that are include-d inside __init__(), we run into world-age problems.
I think the best approach for redefining the constants is going to be to allow overrides with environment variables at runtime.

Also, this package hasn't depended on CpuId for a little while now. Not sure how the cpuid file reappeared.

Should be removed now.

Also, this package hasn't depended on CpuId for a little while now. Not sure how the cpuid file reappeared.

Should be removed now.

It might be nicer to start from the current master?

So, I tried that, but I could not get the tests to pass.
Let me see if I can get the tests passing on this PR branch.

It might be nicer to start from the current master?

So, I tried that, but I could not get the tests to pass.
Let me see if I can get the tests passing on this PR branch.

Also, I just rebased this PR branch on the latest master, so it is up to date with all the changes from master.

Also, I just rebased this PR branch on the latest master, so it is up to date with all the changes from master.

@chriselrod I can't figure out how to get the tests to pass on this PR. Can you take a look?

@chriselrod I can't figure out how to get the tests to pass on this PR. Can you take a look?

@chriselrod It might just be easier for you to make a brand new PR and follow the approach outlined in this PR, namely to have include statements inside __init__ for the code that should not be precompiled.
Note that, as far as I can tell, you can't define functions in those files, because you will run into world age problems.

@chriselrod It might just be easier for you to make a brand new PR and follow the approach outlined in this PR, namely to have include statements inside __init__ for the code that should not be precompiled.
Note that, as far as I can tell, you can't define functions in those files, because you will run into world age problems.

I'm also worried about functions being compiled as looking up globals. Example of what I don't want:
julia> foo() = X
foo (generic function with 1 method)

julia> foo()
ERROR: UndefVarError: X not defined
Stacktrace:
 [1] foo()
   @ Main ./REPL[1]:1
 [2] top-level scope
   @ REPL[2]:1

julia> const X = 3
3

julia> bar() = X
bar (generic function with 1 method)

julia> caller(f) = f() + 1
caller (generic function with 1 method)

julia> @btime caller(foo)
  15.889 ns (0 allocations: 0 bytes)
4

julia> @btime caller(bar)
  0.015 ns (0 allocations: 0 bytes)
4

LLVM:
; julia> @code_llvm caller(foo)
;  @ REPL[5]:1 within `caller'
define nonnull {}* @julia_caller_849() {
top:
  %0 = alloca [2 x {}*], align 8
  %.sub = getelementptr inbounds [2 x {}*], [2 x {}*]* %0, i64 0, i64 0
  store {}* inttoptr (i64<PHONE_NUMBER>02944 to {}*), {}** %.sub, align 8
  %1 = getelementptr inbounds [2 x {}*], [2 x {}*]* %0, i64 0, i64 1
  store {}* inttoptr (i64<PHONE_NUMBER>02816 to {}*), {}** %1, align 8
  %2 = call nonnull {}* @jl_apply_generic({}* inttoptr (i64<PHONE_NUMBER>88336 to {}*), {}** nonnull %.sub, i32 2)
  ret {}* %2
}

; julia> @code_llvm caller(bar)
;  @ REPL[5]:1 within `caller'
define i64 @julia_caller_866() {
top:
  ret i64 4
}

I'm also worried about functions being compiled as looking up globals. Example of what I don't want:
julia> foo() = X
foo (generic function with 1 method)

julia> foo()
ERROR: UndefVarError: X not defined
Stacktrace:
 [1] foo()
   @ Main ./REPL[1]:1
 [2] top-level scope
   @ REPL[2]:1

julia> const X = 3
3

julia> bar() = X
bar (generic function with 1 method)

julia> caller(f) = f() + 1
caller (generic function with 1 method)

julia> @btime caller(foo)
  15.889 ns (0 allocations: 0 bytes)
4

julia> @btime caller(bar)
  0.015 ns (0 allocations: 0 bytes)
4

LLVM:
; julia> @code_llvm caller(foo)
;  @ REPL[5]:1 within `caller'
define nonnull {}* @julia_caller_849() {
top:
  %0 = alloca [2 x {}*], align 8
  %.sub = getelementptr inbounds [2 x {}*], [2 x {}*]* %0, i64 0, i64 0
  store {}* inttoptr (i64<PHONE_NUMBER>02944 to {}*), {}** %.sub, align 8
  %1 = getelementptr inbounds [2 x {}*], [2 x {}*]* %0, i64 0, i64 1
  store {}* inttoptr (i64<PHONE_NUMBER>02816 to {}*), {}** %1, align 8
  %2 = call nonnull {}* @jl_apply_generic({}* inttoptr (i64<PHONE_NUMBER>88336 to {}*), {}** nonnull %.sub, i32 2)
  ret {}* %2
}

; julia> @code_llvm caller(bar)
;  @ REPL[5]:1 within `caller'
define i64 @julia_caller_866() {
top:
  ret i64 4
}

FWIW, on master the functions are currently defined in an order so that tests pass locally when using --compiled-modules=no.
Of course, this requires placing a great deal of code after the cpu info.
With some more major reorganization, we may be able to reduce that amount.
But, it's a shame to give up any precompilation at all. Having all the code "preparsed" is fine.

FWIW, on master the functions are currently defined in an order so that tests pass locally when using --compiled-modules=no.
Of course, this requires placing a great deal of code after the cpu info.
With some more major reorganization, we may be able to reduce that amount.
But, it's a shame to give up any precompilation at all. Having all the code "preparsed" is fine.

Yeah I think the approach in this PR won't work. I'll post the MWE in #39 on Discourse.

Yeah I think the approach in this PR won't work. I'll post the MWE in #39 on Discourse.

https://discourse.julialang.org/t/global-constants-that-cannot-be-defined-until-runtime-because-they-depend-on-specifics-of-the-cpu-architecture/54077

https://discourse.julialang.org/t/global-constants-that-cannot-be-defined-until-runtime-because-they-depend-on-specifics-of-the-cpu-architecture/54077


libsamplerate

A patch to make use of the system library is included here: https://github.com/nicholas-rh/o3de-rpm/blob/ba85072e74feeca867ef3637e3b536cec6d14f4f/copr/o3de/SystemPackages_linux.patch#L73C1-L73C1


install cron and schedule calling the pow process of lillypad

Review Type Requested (choose one):

[ ] Glance - superficial check (from domain experts)
[ x ] Logic - thorough check (from everybody doing review)

Summary
changes the docker contain to install cron, and create a schedule for initiating the proof-of-work
Task/Issue reference
https://github.com/Lilypad-Tech/internal/issues/72
Details (optional)
Not ready to be merged in yet because the "lilypad pow" command doesn't exist yet

@richardbremner should we close this one?

cancelled, no longer doing this


Disabling Flutter Desktop CORS

Currently using channel stable. Looks like currently desktop version is hitting CORS issue if the API doesn't support.
Is there a way to disable CORS in desktop version? Like how Electron does.

I thought CORS was something only on the web.
You can disable CORS on Electron because it's backed by a Chrome instance. Flutter Desktop use a native window to render the frames

@bdlukaa  You are right, I thought it was CORS because I hit the same issue in web.
Turned out it is the missing permission issue in macOS - https://flutter.dev/desktop#setting-up-entitlements
Thanks!


changing mobiledoc property fails to call willDestroyElement on cards and atoms

When rendering a mobiledoc using {{render-mobiledoc mobiledoc=myMobiledoc}}, if the myMobiledoc property changes, the render-mobiledoc component doesn't destroy the existing ember-component-backed cards.
Probably related: #20

fix released in v0.5.3


Remove boxing when calling generic ReadField method

Remove boxing when calling ClrObject.ReadField and ClrValueType.ReadField.
Cast to object seems to be leftover from ClrMd v1, where ClrInstanceField.Read was not generic and returned an object.
Btw. I am unable to run the tests, I get an InvalidOperationException stating: "You must first generate test binaries and crash dumps using by running: dotnet build C:\projects\clrmd\src\TestTargets\TestTargets.csproj". But the csproj-file doesn't exist, so the command does nothing.
I am pretty sure my change is correct, but it would be nice with some documentation on how to build everything locally, so I can also run the tests :)

@microsoft-github-policy-service agree

Looks good, thanks!


Draft: A script for moving walker data

I was thinking this script could be part of turbogenius suite. A small script that moves walker data (local energies and position) from TurboRVB native format to TREXIO file"

Hi @addman2, thanks for the new script! Let me know when the pull request is ready :-)


Submitting page to google for crawling/indexing + adding sitemap

We have to add the sitemap and submit the site. We can also ping google for crawling every time there is a major update.
More details: https://blog.hubspot.com/marketing/submit-website-google

Is anyone working on this ?..If not you can assign it to me

@delsin474 how does this work? I'm just curious about the process, don't mind assigning it to you!

I can help @delsin474 , I have knowledge about sitemap and submitting website to google webmaster for indexing.

@krupeshxebia sure go ahead :)

@krupeshxebia sure go ahead :)

I will start today at evening and hopefully complete it before monday, thanks :)

@jeremyphilemon Hi, due to heavy office workload, It is getting delayed.

@krupeshxebia no problem :)

Closed by #1111


Work-Around Chrome disabling video playback when tab is not in focus?

Array of videos to continue playing if user is in a different tab.
New video doesn't begin until tab is active again.
Environment

Browser: Google Chrome
Version: 66 (Beta)
Operating System: Mac OS
Version: 10.13.3

I understand that Chrome doesn't allow a video to begin if a tab isn't active, however is there a way to by-pass this by hot-swapping the playback URL and restarting the player rather than re-loading the entire play and subsequently stopping playback until the tab is given focus again.

No. You need a user interaction to get it to start playing https://developers.google.com/web/updates/2017/09/autoplay-policy-changes

Just to clarify, I understand you need prior interaction to start it upon page load. Can I confirm that there's no way to continue playback with a second video after a user has initiated when starting the first video, and then navigated away to another tab whilst the video plays?

I don't see why not. I would try running setInterval from the user interaction event and listen for right evens (focus and blur on window I think, but not sure) to trigger pause and play.
In general I don't think this is desirable or a good idea, but your use case might warrant for it.

Ah, thanks for your response, however, I think I may have over-complicated my question. Essentially, I'm trying to build a music player that utilizes YouTube and a custom playlist system. At the moment I simply replace each instance of plyr on song end with a new one, and playback continues. However, if a user has tabbed out to another tab (as one does when listening to music!) the next track doesn't begin until a user returns to the tab. The track is buffered, so I know the code itself runs in the background, but it seems the Media Engagement algorithm introduced in Chrome 66 is stopping plyr from restarting itself in the background.
I understand why this would be the case, and was simply wondering if there was a way to replace the current instance of plyr's src ID with an updated one and begin playing that video while the tab is still in the background if that makes sense? I don't believe this would be breaking any policy in Chrome, as the user has to initiate the playback on page load the first time, I just want it to continue automatically.
Thanks for the responses thus far.

I'm closing this since you're asking about browser behavior you can simply test to find out and learn. There's nothing inherent in Plyr causing it.

@joshcawthorne, have you figured out how to go over it?

@joshcawthorne @DanielKucal I would appreciate it if you could share your solutions, if any?

 I saw the plugin looking so professional just to stumble upon this clusterfuck.

@MarvinDrude see https://github.com/sampotts/plyr/issues/1185#issuecomment-619506270

@Ivanca That's only for YouTube


Question Regarding Point Calculation and Feature Request for Point Range Selection

Hi,
I have a question regarding the point calculation in the game. I noticed that the output from the https://www.binance.com/bapi/growth/v1/friendly/growth-paas/mini-app-activity/third-party/game/start API returns various configurations for each game session, as seen in the example below:
{
"code": "000000",
"message": null,
"messageDetail": null,
"data": {
"gameTag": "xxxxxxx",
"specialRewardId": null,
"cryptoMinerConfig": {
"gameDuration": null,
"hookSwipeSpeed": 300,
"finalHookSwipeSpeed": 500,
"itemSettingList": [
{
"type": "REWARD",
"speed": 150,
"size": 50,
"quantity": 3,
"rewardValueList": [25, 25, 25]
},
{
"type": "TRAP",
"speed": 100,
"size": 50,
"quantity": 1,
"rewardValueList": [-20]
},
{
"type": "TRAP",
"speed": 150,
"size": 30,
"quantity": 2,
"rewardValueList": [-10, -10]
},
{
"type": "BONUS",
"speed": 80,
"size": 60,
"quantity": 1,
"rewardValueList": [60]
},
{
"type": "REWARD",
"speed": 100,
"size": 70,
"quantity": 2,
"rewardValueList": [50, 50]
},
{
"type": "REWARD",
"speed": 200,
"size": 30,
"quantity": 5,
"rewardValueList": [10, 10, 10, 10, 10]
}
]
}
},
"success": true
}
My concern is whether the points submitted after completing the game are accurately calculated based on the item settings (rewardValueList, trap, and bonus). I want to ensure that there is no discrepancy that could potentially be flagged later on.
Additionally, would it be possible to implement a feature where we can select a range for the total points to be submitted after completing the game? This would provide more control over the randomness of the point allocation and ensure it falls within a specific range.
Thank you for your assistance!

my point callculation is based on that response, but im avoid trap so im just calculate based on the reward , each hit give different itemSettingList thats why the point is different for each hit. it not randomize but im calculate based on the cryptoMinerConfig

aight well i got 325 point like in a row, and it get my account banned bro, thabksfully its not my main acc

aight well i got 325 point like in a row, and it get my account banned bro, thabksfully its not my main acc

that not something that make your account banned, my 20 account still safe with around 50k point each


Getting AM/PM

How do I get AM/PM? There are no options to getting AM/PM I found.

can just do something like pugg.now().hour() >= 12 ? 'PM' : 'AM'

Agree with @adamwirth.
Besides, we are considering add some useful extra format options. Join our discussion here #60 .

@adamwirth This is introduced in #90

new release fixed. THX


Current Version does not work with PHP 7.0.x

Hi,
we use your tool in our automated deployment pipeline. The current PHP version of the project where the error occurs is 7.0.30.
Install
curl -sO http://gordalina.github.io/cachetool/downloads/cachetool.phar
chmod +x cachetool.phar

Execute
/usr/bin/php cachetool.phar

Error
PHP Parse error:  syntax error, unexpected '?' in phar://*/cachetool.phar/vendor/symfony/yaml/Parser.php on line 499

Your documentation specifies the minimum version to 5.5.9+.
Any advice?

Same here, same problem

Same here

@gordalina Thanks.
I also hope for a quick solution for the Deployer recipe (https://github.com/deployphp/recipes/issues/183).
I agree that it is necessary to support latest PHP versions, but this change breaks a lot of deployment pipelines.


Revert "[core] - Align with latest OpenTelemetry implementations"

Both communication and storage need OOB  releases this month, so reverting this commit allows them to do it.
This reverts commit 5cd6362fbd47c1b6d2dc10071623a4444ec16a66.

Will try in parallel to just downgrade storage and communication and see how if that works out

Closing this out, we'll take core-tracing preview.13 out this week instead to unblock


Update references.json

Adding "241 npm and PyPI packages caught dropping Linux cryptominers" to the list of references

I think it is better to duplicate the reference, see #39.

@piergiorgioladisa @serenaponta I split the proposed reference into two, one for the typosquatting attack on Python and one for the attack on npm. Also, I added another typosquatting attack on Python (targetting counterstrike servers). Please check whether that makes sense...


Issue 1

[ Task 1]

change the decorator
@app.get('/users')

[ Task 2]

Invoke this class
const app = express.app()

[Task 3]
do something else..

solved


Validate provided parameters in service create.

[kind/Enhancement]
Which functionality do you think we should update/improve?
Currently parameters provided as options to the command are not validated. We should validate them before trying to create the service.
Why is this needed?
Improved UX.

How can you know the type the parameters do support?

How can you know the type the parameters do support?

Using the same mechanism used by the interactive mode.


New Observer type

This Observer allows metrics to be exported, including but not limited to:

Actor version.
Application version.
Target, e.g. x86_64-apple-darwin?
Number of processes used.
Memory usage.
Uptime, total time running since start.
Number of processes (actors, initiators and tasks).
Number of processes ready to run.
Maybe expose a process list; ProcessId, name (?) and ready state.

This is going to be hard when using a seperate process per core, rather then threads.

See https://github.com/Thomasdezeeuw/heph/pull/484.


Jackson package conflict problem

Databend jdbc use jackson 2.13. However, in practice, if there is already a jackson dependence in the project and the version is not the same(mine is 2.15), there will be a package conflict problem, which will lead to the following error:

It is recommended to use the maven-plugin-shade to rename the package of databend's external dependencies to com.databend.jdbc.com.fasterxml.jackson.* or else.

I create a new PR https://github.com/databendcloud/databend-jdbc/pull/89 for this issue.
By the way, okhttp3 may also have a conflict problem, I tried to change the package path of okhttp3, but currently the compilation will report an error
<relocation>
    <pattern>okhttp3</pattern>
    <shadedPattern>com.databend.jdbc.okhttp3</shadedPattern>
</relocation>


⚠ Fetchers has degraded performance

In 268f457, Fetchers ($STATUS_URL) experienced degraded performance:

HTTP code: 200
Response time: 375 ms

Resolved: Fetchers performance has improved in 0063a84.


TagBot trigger issue

This issue is used to trigger TagBot; feel free to unsubscribe.
If you haven't already, you should update your TagBot.yml to include issue comment triggers.
Please see this post on Discourse for instructions and more details.
If you'd like for me to do this for you, comment TagBot fix on this issue.
I'll open a PR within a few hours, please be patient!

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/62566

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/62830

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/63453

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/63659

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/64195

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/64207

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/65068

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/85120


[Bug][GItHub] Clicking 'Collect Data' in the top right corner multiple times does not activate the scope config.

Search before asking

[X] I had searched in the issues and found no similar issues.

What happened

Create a new GitHub connection, do not configure the scope config, and click on 'collect data' at the bottom to successfully collect data.
Configure the scope config.
Click on 'Re-transform Data' in the Projects -> GitHub -> Status page.
Check the issues table; the configured rules have been transformed, and the type field that matches the regular expression has been updated with the standard type values.
** Up to this point, there are no issues.**
Remove the scope config and then click on 'Collect Data' in the top right corner.
Check the issues table; the previous mapping relationships are still there.
7

1.创建新的GitHub的connection，不配置 scope config，点击 最下面的 collect data，收集成功。
2. 配置scope config
3. 点击 Projects->github -->status 页面中的 Re-transform Data
4. 检查issues表，配置的规则被转换过来，符合正则的type字段，写上了标准类型值。
到这里都没问题
5.去掉scope config，再点右上角的Collect Data
6.检查issues表，之前的映射关系还在
What do you expect to happen
The expectation is that after removing the scope config and clicking on 'Collect Data' in the top right corner, the type values in the issues table should be empty, rather than retaining the mapping values from the last operation.
How to reproduce
See above
Anything else
No response
Version
main
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Fixed in pr #6601


Design proposal for Secrets

Put together a brief requirements doc and design propsal for a minimal secrets implementation and review with the team.

https://docs.google.com/document/d/1GOauON50T7RMnp2a3svGOb9X2aMAJYdzDx7HlH0oB6E


Reduce lerna loglevel

For the office-ui-fabric test (by default it is info instead of error). This should hopefully trim a ton of output we don't care about.

@typescript-bot user test this

@typescript-bot user test this


[FLINK-3513] [FLINK-3512] Fix savepoint issues

@aljoscha spotted the following two issues (so far) while working with savepoints and the rocks DB state backend.

FLINK-3513: The operator name is used in the deterministic hash assignment, which is actually not necessary and leads to problems with the WindowOperator (changing name).
FLINK-3512: The savepoint backend was trying to be too clever and fell back to jobmanager when it found "wrong" config combinations.

:+1:

mvn clean verify was successful on my local machine, so if we need this for a new RC, we can merge it before the Travis run finishes.

I'm merging this to master.


[client] defineByDocumentFile' deprecated but no equivalent?

defineByDocumentFile' :: Q FilePath -> ExecutableSource -> Q [Dec] takes a Q FilePath which is very useful as it enables using makeRelativeToProject.
Using this function enables the paths to be correct when building from the command line and from within haskell language server.
However, the replacement function declareLocalTypes does not take a Q FilePath. Can a non-deprecated function be added to support this use case? Happy to make a PR if you advise how to solve it.

declareLocalTypes already uses makeRelativeToProject so there is not necessary Q FilePath anymore.


time: Parse should handle Jan 2nd

What version of Go are you using (go version)?

$ go version
1.11

Does this issue reproduce with the latest release?
Yes.
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GOARCH="amd64"

What did you do?
used a layout:  Jan 2nd, '06
to parse a time: Jan 3rd, '06
What did you expect to see?
Ideally, I would love it if this worked.
What did you see instead?
It can't parse rd, ' as nd, '.
I'm well aware that this may well be a ridiculous edge case, but it seems to me that the specific idiom of writing the weird suffixes on numbers in dates is fairly common, and it's very hard for a naive user, or even a moderately skilled one, to discern correctly where in a string to look for such a suffix.
The reference time makes it possible to reasonably infer that 2nd implies the format "day of month plus suffix". Given that, it would be reasonably practical to do either of (1) accepting the correct suffixes for the 31 values which can reasonably occur, or (2) accepting any of st/nd/rd/th after a numeric day value. (Given the response to #12728, I'm guessing that the latter would be preferable; this is arguably less of an error than feb 30th is...)
I'm honestly not sure it's a good idea. On the other hand, I think the risk is very low -- I doubt anyone has ever written a layout with 2nd in it with the intent that it match explicitly only the literal nd, or produce nd after every number, and getting it right would look really cool.
Being prone to hubris, I'm totally volunteering to try to write this if anyone expresses a willingness to see it merged.

Could you show a small, complete, example program, perhaps on play.golang.org?  Thanks.

https://play.golang.org/p/uF6c0kO-3ow
D'oh, sorry about that. I even had the window still open. :)

Thanks.  I see.  I would worry about internationalization.  Matching "Jan" is one thing, matching "2nd" is another.  Do we really want to only match these English abbreviations?  I don't think we want to support every language.  This can be done outside of the standard library, and that might be best.

Hmm. Does time.Parse handle non-English month names? I was under the impression it only handled English at the moment.
I agree that it might be a bad idea to handle this partially, but it turned out to be easy to write, so I've sent in the code. I will not be in the slightest offended if it's rejected.

There seems to be a consensus that we won't be supporting this, so I think we can close this issue.


[$500] [Held requests] - Pressing 'Enter' key doesn't serve as clicking on 'Got it' button

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.43-0
Reproducible in staging?: y
Reproducible in production?: new feature
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:
Action Performed:

Sign up with a new account
Create an IOU with a user
Navigate to IOU reports details page
Click on three dot > Hold request > enter reason > press enter
Hitting enter key the first time navigates to Expense header RHP.
Press enter again.

Expected Result:
Pressing enter after entering the reason should close the RHP. And pressing enter should behave as clicking on 'Got it' button
Actual Result:
Nothin happens
Workaround:
unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/43996225/596c958e-01c3-4a95-a304-5df9ecd7dd04

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~017589b7378e34e844
Upwork Job ID:<PHONE_NUMBER>076301312
Last Price Increase: 2024-02-20
Automatic offers:

abdulrahuman5196 | Reviewer | 0

We think this bug might be related to [#vip-bills]
cc @davidcardoza

Proposal
Please re-state the problem that we are trying to solve in this issue.
Pressing the 'Enter' key doesn't behave as clicking on the 'Got it' button in the Hold Request flow.
What is the root cause of that problem?
The root cause of the problem is that there is no event listener set up to handle the 'Enter' key press event in the HoldReasonPage component. As a result, pressing the 'Enter' key does not trigger the form submission.
What changes do you think we should make in order to solve the problem?
Enable disablePressOnEnter for the FormProvider on the HoldReasonPage
 <FormProvider
        formID="moneyHoldReasonForm"
        submitButtonText={translate('iou.holdRequest')}
        style={[styles.flexGrow1, styles.ph5]}
        onSubmit={onSubmit}
        validate={validate}
        enabledWhenOffline
        disablePressOnEnter={false}
>

Original / Culprit
https://github.com/Expensify/App/blob/eb332d633e2af1d0d83a5cde92ae9c4c1f343f20/src/pages/iou/HoldReasonPage.js

I'll create a follow-up PR to fix this regression @shubham1206agra

Proposal
Please re-state the problem that we are trying to solve in this issue.
The Git it button is not focused
What is the root cause of that problem?
On the 1st screen, "Hold Request", when the button "Hold Request" is clicked, there's an actiopn to turn back to the main request report screen, wish bring back focus to the "Write anything..' input
https://github.com/Expensify/App/blob/0f372c2517b8ebd93e4dbbb53f542ab444c16adb/src/pages/iou/HoldReasonPage.tsx#L42-L49
The navigate back function turn to the main report screen and does not open the next "This request is on Hold" screen.
What changes do you think we should make in order to solve the problem?
When the screen "This request is on Hold" is opened we need to set the focus on the "Got it" button on src/pages/ProcessMoneyRequestHoldPage.tsx
const  submitBtn  =  useRef<View>(null);

useFocusEffect(
  React.useCallback(() => {
    if (!submitBtn.current) {
      return;
    }
    submitBtn.current.focus();
  }, []),
);

<Button
  ref={submitBtn}

POC:
https://github.com/Expensify/App/assets/12425932/88ae5a0a-2811-4d46-a3bb-8a0dd40907cb

Hi! So after investigating for a little bit, it turns out that this problem may be related to a known bug where after opening RHP the focus is outside of it. I think that right now we should hold off until the original issue is handled, and after that we can come back to this one 😄

on hold pending fixes in https://github.com/Expensify/App/issues/36476

Still on HOLD for the above issue https://github.com/Expensify/App/issues/36476

Still on HOLD for the above issue https://github.com/Expensify/App/issues/36476

Not overdue, last update ^

Not overdue

Not overdue, Still on HOLD for the above issue https://github.com/Expensify/App/issues/36476

Held

Held

Still on HOLD, but we have started work on HOLDING HG https://github.com/Expensify/App/issues/36476#issuecomment-2134143679

On hold

On hold

Held

Still on HOLD.

Still on HOLD.

The linked GitHub issue is closed (https://github.com/Expensify/App/issues/36476). @abdulrahuman5196, can you please review the linked GH and help move this forward? Do we have a proposal that we can go with?

BUmp @abdulrahuman5196

Sorry Folks, didn't notice since this issue is on weekly.
Seems we don't have a got it page now? @muttmuure Could you kindly check and close if no fix is required?
https://github.com/user-attachments/assets/9c102b27-a2e2-4dc7-9890-37ca5d177366

You've used the feature before, so you don't get the educational interstitial. Try on a new account. 👍

Bump ^^ :)

Going to ask QA team to verify if this is still reproducible, thanks.

@techievivek
We can repro. Additionally also observe another issue not included in the OP. Hitting enter key the first time navigates to Expense header RHP. Should we log it separately?
https://github.com/user-attachments/assets/79f81028-4209-4029-b096-cd6b73ff208f
https://github.com/user-attachments/assets/94d0ff29-e613-4be3-afbb-cd485736ad6e

@mvtglobally We can handle it as part of current GH itself.

Hi @BartoszGrajdek would you be interested in working on this GH? Or should we look for fresh proposals?

I will first ask our SWM team if anyone's interested in taking over this issue, let me give you an update on that tomorrow 👀

We don't have the capacity to take on this issue at the moment, so I believe we can look for some fresh proposals @techievivek 🙌🏻

Thanks, applying the external label so we can get some fresh eyes on it.

Going to change the pricing back to 500, as that was the original amount for this GH.

@abdulrahuman5196, can we review the proposal above? We're trying to wrap up the HELD requests project, so I'd appreciate it if you could prioritize this. Thanks.

Hi, Checking now.

@dukenv0307 's Is it possible to directly focus 'Got it' button without issues instead of unfocusing the current focused element? I tried out the proposal here https://github.com/Expensify/App/issues/36825#issuecomment-1954906872 , it worked but I am seeing an blue border over the got it button? What do you think?

@dukenv0307 's proposal here https://github.com/Expensify/App/issues/36825#issuecomment-1953455655 looks good and works well.
🎀 👀 🎀
C+ Reviewed

perfect! thanks for taking this on 👍

The PR that introduced the bug has been identified. Link to the PR:
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

Doesn't seem to be a regression.

Determine if we should create a regression test for this bug.

Yes.

If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Login with an account that doesn't hold any request
Submit an expense
Open the hold reason page
Enter the reason and go to the next page
Press enter key and verify that RHP is closed

@muttmuure

Regression test looks good to me, @muttmuure can we please get that added to testRail? Thanks

$500 - @dukenv0307
$500 - @abdulrahuman5196

I think we're all set here? Please comment if there are any other remaining steps

$500 approved for @abdulrahuman5196

Paid


added script for easier UT compilation

Codecov Report
Patch coverage has no change and project coverage change: -0.32 :warning:

Comparison is base (ae31225) 98.11% compared to head (ae048a4) 97.80%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #71      +/-   ##
==========================================
- Coverage   98.11%   97.80%   -0.32%
==========================================
  Files          20       20
  Lines        1593     1593
==========================================
- Hits         1563     1558       -5
- Misses         30       35       +5

see 1 file with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Codecov doesn't work

Expected Behavior

Codecov works
Observed Behavior

Codecov doesn't work
Steps to Reproduce

https://codecov.io/gh/arturbosch/detekt/branch/master/commits
Context

I've tried many variations to try and get Codecov working reliably. It still doesn't. This makes me sad. If someone can figure it out, I would be very appreciative! Because I don't know what else to try.
Your Environment

Version of detekt used:
Version of Gradle used (if applicable):
Operating System and version:
Link to your project (if it's a public repository):

How did you verify this? I couldn't see any problems in the last few PRs.

Click the link in the PR, see "Error" for the last two commits on master branch. #1751 and #1752 have no Codecov reports.

You are right. I haven't paid attention to the actual execution of codecov.
Unfortunately, the error doesn't give any hints on what is wrong.
I'm not even sure if our configuration is somehow wrong or if something with codecovs infrastructure is wrong.

@3flex Does it make sense to revert #1739 to have at least a working test coverage?

I don't think so, coverage reports didn't work before that PR and still don't work now, so reverting will just go back to a different broken state.

Okay.
I saw uploaded coverage reports when browsing through the commits, which were created before the linked PR.
For example, this commit shows a report. It's also integrated into GitHub's PR view.
That's the main reason why I wanted to revert to the old approach, although not everything is apparently working fine.
Here we have at least a helping hand in terms of code coverage.
Do you remember the problem with this approach? (in case someone wants to pick this up)

As far as I know every config I've tried has ended in eventual failure, but I don't know why.
Hopefully someone can contribute to a fix, but I won't be spending any more time on it.

It looks like codecov is back again.
I observed that the report doesn't work when no tracked source files were changed in the PR.
For instance, one of my PRs only changed the Contributing.md file. Codecov hasn't created a report for whatever reason.
I also investigated the sample project for configuring codecov as a Gradle task.
I could only find one difference.
They created a separate Gradle task and only run this task when the Travis build completed successfully, whereas we run this task on every build.
Furthermore, they added the ./gradlew codeCoverage instruction in the travis.yml file.

Since #1865 helped to have a quite reliable code coverage report, I'll close this.


chore: prepare for kafka connect

Adds the Kafka Connect cluster to the dev setup with a functional mongo-source-connector pulling only from the medici databases.

no new changes, squashed and merging


Fix log for init --upgrade, interfers with --dry-run --output yaml

Signed-off-by: Andreas Neumann<EMAIL_ADDRESS>What this PR does / why we need it:
There is a log in the kudo init --upgrade path that logs directly into out. This interferes with the uninstall:
kudo init --upgrade --dry-run --output yaml | kubectl delete -f -

Good catch!

Yeah. I extended the upgrade test that now includes the uninstall as well, that's how it showed up ;) I just made it a separate PR for easier review


Implementing Hill Cipher in Java

💥 Proposal
Implementing Hill Cipher in Java
Have you read the Contributing Guidelines on Pull Requests?
Yes

/assign


jwt authentication

Hi,
I'm trying to implement a sample project template, like the starndard asp.net template, using frameworks as aurelia and angular 2, and I have to handle authentication. To do this the client libraries I found uses JWT, and I'm looking how to implement it.
Since should be a simple template I would like to implement a solution as simple as possible: I heard about identity server and found samples like this https://github.com/paulvanbladel/aurelia-identityserver-aspnetcore, but require multiple site and it's an overkill solution.
To implement a simpler solution I lookied at System.IdentityModel.Tokens.Jwt to create tokens in a simple way: seems to work, but now I have the problem of handling the logout: from what I understand , in a simple way, I have to revoke the token and is not possible to handle client side, and I have to keep a server cache of the tokens that have been revoked and refuse requests done with there tokens.
If I'm corrent, is this supported by Identity or is possbile to take advantage of Identity to handle this?

What are you authenticating against?
Equivalent to Forms Auth? Your own SSO solution? ADFS as SSO? Facebook? Google? Twitter?
It might not look like much but each have their own solution.

The equivalent of Forms Auth. the idea is to create a project template functionally equivalent to the actual asp.net template, but based on spa frameworks.

There's no built in functionality for what you require


Security problems

There is a new version of openssl with many security fixes.
Is it possible generate a new version with openssl bump version?
list of current project openssl version:
https://www.cve.org/CVERecord?id=CVE-2024-4741
https://www.cve.org/CVERecord?id=CVE-2023-6129
https://www.cve.org/CVERecord?id=CVE-2023-6237
https://www.cve.org/CVERecord?id=CVE-2024-0727
Thanks!

@rafaeldev
The dependency is defined as:
spec.add_dependency 'openssl', '~> 3.0'

Which means any version above 3.0 and below 4.0.
So the definition is correct and there isn't any security issue.


Not very clear how the data pipeline works

Hi, I am reading read_tf_records function in preprocessing.py. I am not sure if I understand the data pipeline correctly.  To generate a model, we use the latest 500K games with a total of 125M positions (suppose there are 250 positions in each game), and by the function gather(), these positions are saved in a bunch of *.tfrecord.zz training chunks, with 10000 positions in each tf record (EXAMPLES_PER_RECORD = 10000). Then, the function read_tf_records first shuffle these tfrecord filenames, then it reads 16 tf.examples (positions) by the function record_list.interleave from each tf record. Then it loads SHUFFLE_BUFFER_SIZE this many positions into memory at one time, and forms random batches from this buffer. Is my understanding correct? I am not sure does record_list.interleave() just read 16 positions from each tf record and ignore the rest? Also, how does dataset.shuffle() function form a buffer of 4M positions?

you seem to be reading it mostly correct - the clarifications are that record_list.interleave() interleaves reading positions 16 at a time until the whole file is complete; those are also filtered, so only ~5% of the positions of a game will be used.  Dataset.shuffle then shuffles this whole collection of positions.

Feel free to reopen if there are more questions :)


Some libraries

ziglang libraries
zig build-system port libraries
new section - same idea in https://github.com/C-BJ/awesome-zig/issues/21

cc: @catdevnull

Hi, thanks for the high quality PR and for your Zig work! <3


我们是否可以嵌入自己的任务调度系统吗

 Hi ， 请问一下，能不能将自定义的任务调度系统嵌入到wherehows，对产生的上下游数据进行血缘分析。
如果可以的话，那应该注意什么问题，谢谢

你自己仿造 azkaban的抽取实现自己的抽取脚本。 抽取出来的数据尽量符合azkaban抽取出来的数据接口

@PettterPan, WhereHows team is working on a Kafka-based lineage ingestion pipeline, which aims at reporting lineage by the job executor itself. In short, whenever a data movement/ETL job finishes successfully, the post-execution codes will extract the lineage info out of the execution context/log, and then pack them into a Kafka message.
Does this sound like a good integration interface to your use cases?
If you prefer a batch-oriented lineage extraction, then @superwood's comment is right. You can create a new job type called XYZ_LINEAGE_METADATA_ETL and implement specific extract and cleansing logic. @alyiwang can discuss more details with you in an offline thread.
If you'd like to invoke the metadata ETL jobs based on the cadence defined inside your own orchestrator, WhereHows needs one API to modify the "next_run" epoch of the defined job entry in wh_etl_job, so that this particular job will be executed soon. There's more detail to figure out, please elaborate your use case to help us understand better.
The backend service has a mini crontab (https://github.com/linkedin/WhereHows/wiki/Backend-API#etl-job-schedule). See if we can extend that to suit your needs.

@superwood 嗯 ，谢谢， 我们调度系统中有很多非hadoop的任务，现在正在手动调试

@ericsun2 thank you very much. the project of Wherehows is very useful.Our project need the batch-oriented lineage  extraction, So I will follow  @superwood's  method to achieve . thank you very much.

@PettterPan How to get lineage info from wherehows,can you help me ?


Correct /version in NginX conf

This https://github.com/mainflux/mainflux/blob/master/docker/nginx.conf#L156 maps /version directly - which is wrong as it is non-existent API endpoint.
Probably should be pre-fixed with something like <service>/version.

Do we really need this to be exposed? IMHO this is internal endpoint that should be used for service health check or ping.

@drasko I agree, but do you really need to expose internal structure to the outside world? If this nginx config is used for dev, then maybe we shouldn't enforce TLS.

@drasko quick question: do we want to check only if nginx is alive (simple get request) or we also want to have some stats?
I found few interesting links and projects which expose/export the nginx metrics to Prometheus, they need some configuring, though:
https://hnlq715.github.io/nginx-vts-exporter/
https://github.com/nginxinc/nginx-prometheus-exporter
https://sysdig.com/blog/monitor-nginx-kubernetes/
https://sysdig.com/blog/monitor-nginx-kubernetes-metrics-alerts/
It might be a bit of overkill to setup all this, but we should start thinking about monitoring the infrastructure components (nginx, redis, nats...) as well ;)

@anovakovic01 sure, it does not worth to invest the time in it if we do it in the near feature. For now we could simply enable the  "stub_status" module in nginx and who ever needs the stats can use them.
Is there some timeline about Ambassador and when are doing the switch?

It's work in progress. I should send PR in next few days.

@chombium I had in mind a simple ping for now, just health check. I was writing this blog and I realized that a developer will not have a simple way to check from outside if the instance on DO is running OK.
Then I looked at nginx config, because I know that we have /version healthecks on services and I saw this bug :).

@nmarcetic please test this and fix with highest priority, so that we can release 0.7

We agreed this is not a bug and that we don't need exposed /version endpoint for each service.
So won't fix,  closing this one.


⚠ Bofrost.es has degraded performance

In cf6f0dd, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1546 ms

Resolved: Bofrost.es performance has improved in e3df56c after 6 minutes.


AMD, CommonJS and Plain Browser Support

Hi,
Would that be possible to make the library available for any sources? Right now it's a plain global definition that does not fit well with webpack.
In reference to https://gist.github.com/pazguille/3923164 , the export of the library as a module can be done to get AMD, commonJs and plain browser support.

@se-fDelpech Can you share your webpack config? You should already be able to use the SDK with a webpack built app.

Hi,
It was maybe more related to the beta build issue, but the idea would be to use it as a module :
var kinvey = require('kinvey-angular-sdk');

angular.module('myapp', [
  kinvey.name,
  ...
])

But to make it work right now, I have to use:
require('kinvey-angular-sdk');

angular.module('myapp', [
  'kinvey',
  ...
])

It's working, it's just that it does not align with the standard way to import module.

Ok good point. We always encourage pull requests if there is something you see that needs to be fixed or could be improved.
If you would like to make a pull request with the fix let us know otherwise we will make it so the SDK exports a module with a name property set to kinvey.
If you are looking to make a pull request with the fix, take a look at src/index.js. At the bottom of the file you would need to export an object with a name property set to kinvey.

I didn't mean to close the issue.

Yes sure, I can do that.

Should I fork from the master or the dev?

This issue has been fixed with the release of version 3.0.1 of the kinvey-angular-sdk package.


Add dragonflydb support

Hello. We use DragonflyDB instead of Redis, and it would be cool if Coroot would add support for this database.

The latest versions of Coroot and the agent support all Redis alternatives, including Redis, KeyDB, Valkey, and Dragonfly.
Coroot release: v1.5.13
Coroot Node Agent release: v1.22.1


zstd-safe compile error

Problem
Trying to get the voice transcription example up and running and get this error:
no `ZSTD_c_experimentalParam6` in `ZSTD_cParameter`     |             help: a similar name exists in the module: `ZSTD_c_experimentalParam1`
Note that I am trying to implement this in my Tauri app, not sure if that's relevant.
Steps To Reproduce

Follow quick start guide
run npm run tauri dev
error shows in console

Expected behavior
It builds properly.
Environment:

Renderer version: Kalosm 0.2.1
Rust version: 1.79.0
OS info: Windows 11
Tauri: 1.6.0

Questionnaire

[x] I'm interested in fixing this myself but don't know where to start
[ ] I would like to fix and I have a solution
[ ] I don't have time to fix this right now, but maybe later

I also tried all other versions of Kalosm to no avail. I'd be really grateful for any help on this issue, really want to get it added to my app 🤘

You can add zstd-sys = "=2.0.9" to your cargo.toml to avoid the build error. One of the dependencies kalosm uses relied on unstable features that broke in a minor version. This issue should also be fixed in the git version of kalosm

That fixed it thanks! Now I'm getting a different build error, starting a new issue

Update: I fixed the other build error by manually installing clang, but now I'm getting the zstd-safe compile error again, even with your fix implemented. I'm ultimately deeming this library isn't ready for my production app, but still figured I'd let you know. Thanks for the help!

had the same initial error, which disappeared when i use zstd-sys = "=2.0.9". however i'm getting a new error
error[E0133]: call to unsafe function `EnvOpenOptions::open` is unsafe and requires unsafe function or block
   --> /Users/hanselke/.cargo/registry/src/index.crates.io-6f17d22bba15001f/kalosm-language-0.2.2/src/vector_db.rs:98:19
    |
98  |           let env = EnvOpenOptions::new()
    |  ___________________^
99  | |             .map_size(TWENTY_HUNDRED_MIB)
100 | |             .open(path)?;
    | |_______________________^ call to unsafe function
    |
    = note: consult the function's documentation for information on how

Heed also published a minor release which makes a function unsafe in a minor version. kalosm 0.2.2 and kalosm-langauge 0.2.3 were both just published which fixes these issues


Query Builder doesn't seem to support "mapped" queries for referenced documents

In order to retrieve a document with the following structure:
{
	"_id" : ObjectId("4f3d6332e9f0233859000000"),
	"budget" : 32323,
	"buyerCompany" : {
		"$ref" : "companies",
		"$id" : ObjectId("4f397c91e9f0234026000001")
	},
	"campaignEnd" : ISODate("2012-03-22T00:00:00Z"),
	"campaignStart" : ISODate("2012-03-03T00:00:00Z"),
	"created" : ISODate("2012-02-16T20:12:34Z"),
	"lastActivity" : ISODate("2012-02-29T20:06:39Z")
}

I'm trying to run a simple query using a $qb->field()->equals() by passing in "buyerCompany" as the field, and array('id' => new \MongoId('4f397c91e9f0234026000001')) into the equals method. But this returns 0 results. However, it seems like the Document Manager's findBy() method supports such queries... with the QB, I'm having to do something like:
$qb->field('buyerCompany.id')->equals(new \MongoId('4f397c91e9f0234026000001'))

Using the dot operator in this way makes this query very Mongo specific.
Any plans to support queries that use the syntax with the array passed in to the equals method (would abstract Mongo away)?

I am not sure I understand. What syntax are you expecting?
This works. It will convert the string to the appropriate mapping for buyerCompany.id
$qb->field('buyerCompany.id')->equals('4f397c91e9f0234026000001');

I believe what is wanted is
<?php
$qb->field('buyerCompany')->equals(array('id' => new \MongoId('4f397c91e9f0234026000001')));

which doesn't seem possible

Sorry for the confusion -- @avalanche123 is correct. Doesn't the use of buyerCompany.id make the Query Builder not agnostic to Mongo (because of the use of the dot operator)?

Indeed, you're using the MongoDB query builder, so it can't be completely agnostic to Mongo :)
In @avalanche123's code example, the criteria would require buyerCompany to only contain an id field equal to the given value. Since that buyerCompany also contains $ref and $db (although it's not shown on the console) properties, the equality test would fail.
In order to match a single property of the reference object (which is really an embedded document for all practical purposes), you need to use the dot-notation in your criteria.

@jmikola that makes sense, thanks. Is there any documentation around on the acceptable formats for the $criteria parameter of the DocumentRepository::findBy() method? Is there any other way of doing an "in" query other than passing in $criteria as:
array(
	'id' => array('$in' => $ids)
)

Do you agree that the DocumentRepository should be Mongo agnostic?

@madhatter42: I don't think it's reasonable to expect DocumentRepository classes among the ORM/ODM's to be storage-agnostic. Although they do conform to the ObjectRepository interface specified in doctrine-common, each implementation's handling of criteria will need to be tailored to the storage medium.
The best documentation for MongoDB's criteria array is probably MongoDB's own documentation, as Doctrine is going to end up passing that array straight through to the PECL driver. Alternatively, you could perform an $in query using the query builder interface, which will take advantage of metadata mapping (e.g. wrapping strings in MongoId's where appropriate).

The ORM and ODM are already unified through Doctrine Common. The differences between SQL vendors are much less than those between NoSQL databases. Where we can get away with a single ORM library for various SQL databases, we need several ODM libraries tailored to each NoSQL backend (compare MongoDB, CouchDB, PHPCR, etc.).

We would love to get as close to that as possible but it is not possible for everything. If we were to abstract away the common things between the ORM and ODM we'd be left with a very limited API that doesn't allow you to do much. We can make changes to make the ODM more mongo agnostic but it just isn't always possible. I'd be happy to listen to tangible suggestions that make sense and can be implemented reasonably.


add grokspawn to OWNERS

Signed-off-by: Jordan Keister<EMAIL_ADDRESS>
Description of the change:
Adding myself to the reviewer/approver chains
Motivation for the change:
Architectural changes:

Testing remarks:

Reviewer Checklist

[ ] Implementation matches the proposed design, or proposal is updated to match implementation
[ ] Sufficient unit test coverage
[ ] Sufficient end-to-end test coverage
[ ] Bug fixes are accompanied by regression test(s)
[ ] e2e tests and flake fixes are accompanied evidence of flake testing, e.g. executing the test 100(0) times
[ ] tech debt/todo is accompanied by issue link(s) in comments in the surrounding code
[ ] Tests are comprehensible, e.g. Ginkgo DSL is being used appropriately
[ ] Docs updated or added to /doc
[ ] Commit messages sensible and descriptive
[ ] Tests marked as [FLAKE] are truly flaky and have an issue
[ ] Code is properly formatted

@grokspawn LGTM but you need to update your branch now that master is further ahead.

/approve

/lgtm

Holding so the bot doesn't go crazy. This branch needs to be fast forwarded again.
/hold

/lgtm
/hold cancel


[Bug]:

Mod Version
0.0.9
Mod Loader
Fabric
Mod Loader Version
fabric 0.16.7
Describe the bug
preds dont spawn. Set up optimal space for pred spawning and they do not spawn day or night. area was y 64 no area underground spawnable.
To Reproduce
1.flattened a jungle completely and at sea level
2.lit up all surrounding area so things only spawn in the jungle biome
3.no preds spawn at night with other mobs
4, no preds spawn in day
5. no preds spawn when area lit up
6. waited several minecraft days killing non preds to allow space and no preds spawned.
...

sorry thought i had a title preds dont spawn


ZF1-Future getting some positive press!

Not really an "issue" to fix. Just wanted to alert everyone that I have a new article up on Medium and Reddit giving ZF1-Future some positive press!
Medium
ZendFramework 1—Reborn!

Very well written! Thanks for that =)
P.S. I have same opinion on the ZF2 and ZF3 - I never understood, why they put so much pressure on dependency injection and configuration stuff. I tried that but get back to old ZF1. In my opinion, if you wanna this kind of stuff just use JAVA instead of PHP =)

Awesome!


Other kaybourd lay-out

Hi,
Is it possible to switch betwen lay-outs? E.G. from qwerty to azerty?

Hi, at the moment the keyboard only supports QWERTY, but this is a good idea for a future development.

HI, I would love a ie. German keyboard!
Is there a way to add keys in the meantime?
Thank you so much for your work!
Dan

Since the keyboard layout is hard coded into the JavaScript, there's no built-in way to change keys. However, you should be able to just manually change the keyboard layout by editing lines 244 to 362 in the main script file. When you click on a key, it just outputs whatever is in the visible <span> within it, so if you change the letter there, the output will change too.


Peer-to-peer code review

Hello Marco! 👋 @tawakuliKH, @CesarHerr, and I wanted to share our thoughts on your code. We are truly impressed with how well-organized and easily understandable it is. Great job! 😄. Just a few suggestions though: You could improve the pointers to the icons within your UI to match the original design. Additionally, we recommend making some adjustments to your UI to address a couple of minor issues. For instance, you could work on improving the black borders that appear when highlighting any of the added tasks, as well as the "remove completed tasks" button. These tweaks will contribute to a more polished and visually appealing user experience. Lastly, you may want to consider making the task list subtitle non-editable plain text. This modification will prevent accidental edits and maintain the intended structure of the UI.

Thank you for your comments. 🙏🏼


chore: replace big_text with hardcoded logo

big_text.rs was a copy of the code from tui-big-text and was getting
gradually out of sync with the original crate. It was also rendering
something a bit different than the Ratatui logo. This commit replaces
the big_text.rs file with a much smaller string representation of the
Ratatui logo.

Q: Why not use tui-big-text instead of big_text.rs? Is it because we want to avoid a dependency?

Q: Why not use tui-big-text instead of big_text.rs? Is it because we want to avoid a dependency?

tui-big-text depends on ratatui from crates.io. Afaik, it's not possible to compile a version that works with the version compiled from source when compiling examples as the widget traits don't match even though they are the same.

I think number of pixels that change in a gif affects the size. Maybe decrease the randomness a tad? Alternatively, you can record a .mov and that will render on github.

I think number of pixels that change in a gif affects the size. Maybe decrease the randomness a tad? Alternatively, you can record a .mov and that will render on github.

Yep, this is one of the parameters I've been tweaking and which also has non-linear behavior
The problem is not how to make this work, it's finding the motivation to sit and repeatedly tweak things until they're just right with each iteration taking ~60s to edit, run, evaluate. "Just right" in this context is a GIF that is

15-30s
<10MB
animation is subjectively not too fast (to not be too jarring)
has to end with the text fully visible
should not start immediately

I don't like MOVs in this context as they tend to break (with a can't render error) on github often for some reason. That said, this might be a valid fall back position.
I'd suggest running VHS locally vhs examples/vhs/demo2-destroy.tape and checking whether the output looks good enough (I changed the Ratatui text color to white from Red).

Note the other thing I noticed is that there's a bit of extra space on the top and bottom of the frame. Not sure exactly what caused that however. Could be anything from OS update, font installation, ttyd change, vhs change, ?

I feel like we can tweak:

the delay before the animation starts (I feel like it is taking a lot of time)
speed up the animation a bit maybe
width & height

For me the VHS output looks like this: https://paste.orhun.dev/NiPi8p.gif

Filesize for me is now < 10MB. @orhun can you run this on your machine and check (I haven't yet diagnosed why I'm seeing changed sizes to the border)

Yup, perfect: https://p.orhun.dev/lhen9G.gif (9MB)
I think this is ready to go 🚀

Yup, perfect: https://p.orhun.dev/lhen9G.gif (9MB)
I think this is ready to go 🚀

Ha that's also got a bit of weirdness happening around the top and bottom now too (but it looks fun regardless)

I installed Jetbrains Mono (default font for VHS) which fixes up the render height issue for me. I must have had that installed but uninstalled it at some point to test something.


Milestone/Label cells do not respect safe area

Dang it good catch!
Sent with GitHawk

Under the same category, do assignees/reviewers out of interest?

@Sherlouk They do!


Add BOCHS to the toolchain prepare script

Currently BOCHS isn't installed in the toolchain preparation stage, despite it being used in Makefiles, etc. This should be checked for and installed.

The installation for BOCHS is far more complex than most other brew installations. This step should be performed manually by people intending to debug Nova. Building is still possible and a disk image will be produced at the end the same. This image can then be written to physical media or used in a Virtual Machine.


Eager loading not working as expected.

I'm having strange issues with eagerloading when I select a part of a table:

var x = (from cb in context.CouplingTable.Include(b => b.Blob.Project) select cb.Blob).ToList();
var x = (from cb in context.CouplingTable select cb.Blob).Include(b => b.Blob.Project).ToList();

Both commands don't load Project, they just show it as null. This code however does work, but gives me a CouplingTable object back, while I don't need that at all, I just need Blob and Blob.Project:

var x = (from cb in context.CouplingTable select cb).Include(b => b.Blob).Include(b => b.Blob.Project).ToList();

If I then use a second query to get only the blobs, Project is linked:

var xblobs = x.Select(b => b.Blob).ToList();

But combining them in one big query fails again and leaves project as null:

var x = (from cb in context.CouplingTable select cb).Include(b => b.Blob).Include(b => b.Blob.Project).Select(b=> b.Blob).ToList();

Which leads me to believe it's a bug when you refer to a linked object combined with eager loading.
Further technical details
EF Core version: "1.1.0"
Database Provider: Microsoft.EntityFrameworkCore.SqlServer
Operating system: Windows 10
IDE: Visual Studio 2015

The issue is that context.CouplingTable.Include(b => b.Blob.Project) is telling EF Core "when you return a CouplingTable, include it's related Blob and then the Blobs Project". But then you change the query result so that it no longer returns any CouplingTable instances, so the include is ignored. Take a look at https://docs.microsoft.com/en-us/ef/core/querying/related-data#ignored-includes for more info.
What you want to do is perform the include after you've changed the return type of the query, like this. I tested that this code works.
var x = (from cb in context.CouplingTable select cb.Blob).Include(b => b.Project).ToList();


Fix instanceof checks

Summary
This is a rebase of @suchipi's https://github.com/suchipi/jest/tree/instanceof_overrides with added tests.
I added the two small reproductions from #2549 for Error, but I'd love to get small examples of other globals breaking (Object, Array, Buffer, Symbol comes to mind). Can anyone provide those?
Fixes #2549.

Test plan
Tests added (but I want more of them).

This seems to have broken node assert support... I'll see if I can take a look at it later this coming week

This is really super cool. Didn't know this feature in JS. TIL.

@simenb thanks for picking this up, sorry I never got around to finishing it

@suchipi Thanks for pointing Symbol.hasInstance!
Btw, do you have any ideas about why this instanceof fails with the changes in this PR: https://github.com/facebook/jest/blob/65d3d8d37e471ae9a02150933168470d9966c021/packages/jest-jasmine2/src/jasmine/Spec.js#L135?

Can we use duck-typing in that assertion?

I had a hope that instanceof would just work:tm: with this change. But as long as it works in user's test code while we have to fake it in Jest internals, that should be fine

I'm not sure why that's failing; before merging, it'd be good to verify the same issue doesn't occur in user code when using AssertionError

Is there any progress on this? I just ran into the same issue and it's really annoying.

Is there anything that I can do to help move this along? I just spent 2 hours trying to track down why parsing the "Set-Cookie" header was not working only on tests.

You can play with it and see if you can get the tests to pass. I can give it a quick rebase first, though 🙂
All help welcome! This is probably the biggest pain point I have with Jest, and a huge gotcha

Can you share your reproduction? I can add it as a test case 🙂

@SimenB This is one from the other ticket:
    let url = require('url');
    let query = url.parse('https://brpx.com/?f=1&f=2&f=3', true).query;
    console.log(query.f instanceof Array);

This is fixed by addInstanceOfAlias(globalObject.Error, Error);
However, this also does not fix my problem. I'm trying to find a small repro script but I've just noticed that in node 10 the problem does not happen, only in 8, so I'm less motivated now. :)

I've noticed that in Node 10 several instanceof Array were changed to Array.isArray (https://github.com/nodejs/node/blob/master/lib/_http_outgoing.js#L398). This may explain why it now works. But why can't this Array alias work in Node 8? Is it because it's internal Node code?

I just confirmed that the problem is on https://github.com/nodejs/node/blob/v8.x/lib/_http_outgoing.js#L313.
if (value instanceof Array) {
This check is not fixed even when aliasing Array with this PR.

I was trying to extract this to local jest environment, and found a bug.
[Symbol.hasInstance] implementation in this PR does not validate which call was instanceof originally called for. So, for obj instanceof Subclass it will try to call Subclass[Symbol.hasInstance], and, if it's not defined it will fall through to Class[Symbol.hasInstance], which resolves to true, which is may be correct result for Class, but incorrect for Subclass
Try running this:
class Class {
  static [Symbol.hasInstance](){ console.log('Class hasInstance'); return true; }
}
class Subclass extends Class {}
const obj = new Class(); // or even {} for this example
console.log(obj instanceof Subclass);

I've fixed this locally using this === target in hasInstance implementation. this resolves to actual constructor in RHS of instanceof, and target is one we are patching.

Guys, this seems to be abandoned, but the fix is really needed to be able to (integration-) test rest apps, with e.g. restify, and the supertest.
Currently, the status code of the original error (one of restify-errors, e.g.: 503) passed to the next() callback, is swallowed and lost.
It results in supertest receives the incorrect status code (500 instead of 503 or any other custom code).

FYI I found an instance of (pun not intended) this problem in https://github.com/koajs/koa/issues/1466.

You were asking for more tests. I collected a bunch here: SingleContextNodeEnvironment.test.ts
Most of these tests fail with standard Jest but all work when using jest-environment-node-single-context
Some of the tests may look very constructed but they simulate problems happening for real when working with types returned by Node APIs. I just had to be creative for these tests to get the various datatypes directly from Node.

 I'll rebase this and add those. I have zero recollection of the state of this PR, but let's see where it's at

@mcheshkov I don't follow your example. Running your code in plain Node logs out true - and the same works in Jest without any changes at all (and in this PR)


<EMAIL_ADDRESS>Add arm64 version

Add arm64 version.

Closes #12384.
Relates to #12104, #12153.

[x] I have read the Contributing Guide.

/verify


Ensure targetFilename is not a boolean before writing

Changes

Ensures targetFilename is set to a non-boolean value before checking if it is a markdown file
Simplifies creation of the options object(s) for the HTML and Markdown output functions

Fixes #58

Thanks! I need to do a proper dust-off of the project first (replace travis CI) then I'll merge this in :-) It will take some time though...