analyze more packages

look for and analyze foo/lib/foo.dart - this catches packages like flutter_sprites, which I don't believe had previously been analyzed
fix an issue where we were deleting the temporary generated main file, then trying to read its source to match against error locations
skip todo comments ([info] TODO) in the results

@Hixie

Looks like a dartanalyzer crash; I filed an issue here: https://github.com/dart-lang/sdk/issues/25305.

flutter_sprites inclusion is https://github.com/flutter/flutter/pull/909, @eseidel may know more about the status of that PR.
I don't think we should automatically include foo/lib/foo.dart, because those could be parts or otherwise not intended to be directly linked in. We should only link in files that are intended as entry points, IMHO.

It's pretty common for the entry-points of library packages to be lib/<packagename>.dart. Many of the packages in flutter/packages follow this pattern (flutter/examples looks like it largely uses lib/main.dart).
I see that https://github.com/flutter/flutter/pull/909 adds tests and turns on testing for flutter_sprites, but not sure that it addresses it being analyzed?

The tests in #909 are entrypoints that the analyzer would look for and analyze, which would include flutter_sprites.

closing this out -


Add automapping for cages

Codecov Report

Merging #70 (485fb55) into dev (be624ba) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev      #70      +/-   ##
==========================================
+ Coverage   88.38%   88.40%   +0.02%
==========================================
  Files          75       76       +1
  Lines        3917     3924       +7
  Branches      188      188
==========================================
+ Hits         3462     3469       +7
  Misses        430      430
  Partials       25       25

Impacted Files
Coverage Δ

src/DucksNet.API/Controllers/CagesController.cs
91.30% <100.00%> (+0.12%)
:arrow_up:

src/DucksNet.API/Mappers/CagesMapperProfile.cs
100.00% <100.00%> (ø)

src/DucksNet.API/Program.cs
97.14% <100.00%> (+0.08%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Add support for Alternate Registries

Add support for alternate registries, as discussed in https://github.com/serayuzgur/crates/pull/217#issuecomment-1975172827 :

Read alternate registries from ~/.cargo/config.toml (or ~/.cargo/config for legacy) if any.
Read registry tokens from ~/.cargo/credentials.toml if any.
Support registry authentification with cargo:token credentials.
Does not support registry authenfication with cargo:libsecret, cargo:macos-keychain, cargo:wincred. Support may be added later.
Decorator (mouseover popup) fields View Crate, Check review and Doc are hidden for crates that are on alternate registries.
Default behavior is to ignore crates that have an alternate registry :

If a crate have an alternate registry, but it could not be found in config.toml, just ignore it without error, and do NOT use indexServerURL as a fallback registry.
If the registry is found, then fetch versions on this registry.

I've added a script (./sample/alternate-registry.sh) to facilitate testing with alternate registries, for development purposes only.

Other modifications :

I removed src/api/crates-index-server.ts as it was not used anymore
I removed isSparseCompatible() as it was not used anymore

Fixes https://github.com/serayuzgur/crates/issues/213
Fixes https://github.com/serayuzgur/crates/issues/182

Fixes https://github.com/serayuzgur/crates/pull/233

Fixes https://github.com/serayuzgur/crates/pull/232

Fixes https://github.com/serayuzgur/crates/pull/217

Hello,
Congratulations for these features . As you can see, I rebrand the extension now we got more language support refactored all the code and more.
You can also check the new code base if it is compatible what you did or not.
If you have any questions, you are welcome


tfdbg doesn't work with tensorflow GPU version?

Could the dear developers confirm that tfdbg works with tensorflow GPU version or not?
At least on my platform it doesn't work.
OS: Red Hat Enterprise Linux Workstation release 7.3 (Maipo)
Python: Python 2.7.5
tensorflow (1.4.0rc0) (compiled from source with CUDA enabled, CUDA 8.0.61, cuDNN8-7.0.1)
nVidia Quadro P5000
the code for reproducing the problem is as follows:
import numpy as np
import tensorflow as tf

from tensorflow.python import debug as tf_debug

t = tf.constant(np.ones((10, 16)), tf.float32)

def weight_variable(shape):
    initial = tf.truncated_normal(shape, stddev = 0.1)
    return tf.Variable(initial)

def bias_variable(shape):
    initial = tf.constant(0., shape = shape)
    return tf.Variable(initial)

lin1_output_size = 32
lin2_output_size = 1

with tf.name_scope("lin1"):
    weight_shape = t.get_shape().as_list()[1:] + [lin1_output_size]
    lin1_output = tf.matmul(t, weight_variable(weight_shape)) + bias_variable([lin1_output_size])

with tf.name_scope("lin2"):
    weight_shape = [lin1_output_size, lin2_output_size]
    lin2_output = tf.matmul(lin1_output, weight_variable(weight_shape)) + bias_variable([lin2_output_size])

with tf.Session() as sess:
    sess.run(tf.global_variables_initializer())

    sess = tf_debug.LocalCLIDebugWrapperSession(sess)

    print(sess.run(lin2_output))

The phenomenon is after invoking stepper and steps for several steps, it is reporting segmentation fault and exit.
I just wonder is it due to GPU issue?

The "run" mode of tfdbg should be compatible with tensorflow GPU. The "stepper" mode of tfdbg is being deprecated and it not guaranteed to work with GPUs.

@caisq Hi, shanqing, what's the story behind this? I mean why stepping is gonna be deprecated? Sometimes it is quite useful for looking into under the hood. Any thread or discussion relates to this decision? Thanks.

@mingyr, the information you can get from stepping, with the exception from tensor value overriding, should all be available from the tfdbg> run mode. The tfdbg> run mode also provides visibility into intermediate graph/tensor states at runtime. It is the main topic of our guide at:
https://www.tensorflow.org/programmers_guide/debugger
Just to be abundantly clear, tfdbg is not deprecated; only its stepper part is. The stepping support is being moved to a TensorBoard feature based on tfdbg. The new TensorBoard feature will provide a more interactive and visual step-debugging experience. We are currently working on the new feature. Please see https://github.com/tensorflow/tensorflow/issues/10478 for more related discussion.

@caisq Great, appreciating the detailed explanation.  Please feel free to close this thread (or give me an indication if shall I close it). Many thanks.


AcceptConfirmation result: false

Hey guys!
I've seen a few people having the same issue on reddit and I thought I'd ask about it here since I've only seen one thread about it so far.
Basically the bot should accept the outgoing trade offer with this mobile confirmation script but it does not, it returns this error:
steamcommunityMobileConfirmations.AcceptConfirmation result: false
I personally don't have this error but I know two people who have this issue and I'm trying to help them out but it just doesn't seem to work.
The amount of trades doesn't matter, it can't confirm them if its 1 and it can't confirm them if its 2-3-4, etc.

Code (Sorry I don't know anything about tags):
function checkConfirmations(steamcommunityMobileConfirmations){
steamcommunityMobileConfirmations.FetchConfirmations((function (err, confirmations)
{
if (err)
{
console.log('FetchConfirmations error: '+err);
return;
}
if(confirmations.length>0)
{
console.log('[SERVER] Received ' + confirmations.length + ' confirmations');
}
if ( ! confirmations.length)
{
return;
}
console.log(confirmations);
steamcommunityMobileConfirmations.AcceptConfirmation(confirmations[0], (function (err, result)
{
if (err)
{
weblogon();
console.log('AcceptConfirmation error: '+err);
return;
}
console.log('steamcommunityMobileConfirmations.AcceptConfirmation result: ' + result);
}));
}));
}
This script would work with my bot but the exact same thing isn't working for two of my friends and it's a really big issue if you're running a jackpot site.
One of them is using Linux and the other is using windows, they are pretty sure it worked on linux before but now it doesn't.
If anyone could help me out it would be great, thank you in advance.
~ Gergő

I am having the same problem, the bot works on my PC, but not on the Linux VPS. Did you ever get it working? My guess is that perhaps there is a 7 day trade restriction on the Linux VPS because it logged in from a different location.

https://github.com/GaletskyIvan/steamcommunity-mobile-confirmations/issues/13

Hey i have the same problem, how can i fixe that plz


JsonSchemaFactory.Load incorrect parse type when enum is a type of other type

Arkadiusz Wasniewski (itmind on BitBucket) wrote:

When json schema has:

"type": {

  "type": "string",
  "enum": [
    "FeatureCollection"
  ]
}

then returns StringSchema but I think it should be EnumSchema because, like in example above, type is enum but elements of enum could be type of string

<IP_ADDRESS>. Valid values

The value of this keyword MUST be an array. This array MUST have at least one element. Elements in the array MUST be unique.

Elements in the array MAY be of any type, including null.

So it looks like I interpreted enum as only a collection of strings. Supporting the spec will be a breaking change.

It seems to me that the "type":"string" may be redundant/contradictory here. The specification says that an enum entry may be any JSON value as long as they are unique. Specifying "string" shouldn't be necessary if all of the entries are strings.
This means that the following is technically valid:
{
"enum": [
true,
"true",
"black",
[1, 2, 3]
]
}
This would validate [1, 2, 3] but not [1, 2, 4].
On a side note, I'm not really sure how useful non-string enum values are...

According to http://jsonschemalint.com/draft4/, suppose we have the following schema
{"type":"string","enum":["FeatureCollection", 1]}

In this case, a value of 1 would not pass the schema, even though it is one of the enum values.

I've got this one working. Caused a breaking change. Look for version 4.0 soon.

BUG FIX: #14 - Error when type value is array not string Added MultiSchema to support arrays in "type" property.
BUG FIX: #15 - JsonSchemaFactory.Load incorrect parse type when enum is a type of other type Enum schema now populated using EnumSchemaValue instead of JsonSchemaTypeDefinition. Implemented equality operators on all schema types.
Commit includes refactor with breaking changes. Version has been bumped to 4.0.
(NOTE: Bug number relate to BitBucket numbering)

4.0.0-alpha released for your testing enjoyment!
https://www.nuget.org/packages/Manatee.Json/4.0.0-alpha


Provide preferred citation for the CWL viewer

Embed in the generated RO as well?
I've found the following DOIs -- which is preferred?
https://doi.org/10.5281/zenodo.823535
https://doi.org/10.7490/f1000research.1114375.1

For now we would prefer that the poster is cited - https://doi.org/10.7490/f1000research.1114375.1
This is clarified by the about page which is ready to be merged


Add flake8 checking in travis-ci and missing tests

Hi! I made a few changes:

Fixed pep8/pyflakes errors.
Added flake8 checking in travis-ci.
Added a few missing tests

Please, review my PR. Thanks!

Hi, @zyga! Have you any chance to look into this PR?

Sorry for the lag. Yes, I'll review this shortly.

Coverage increased (+7.9%) to 98.291% when pulling 62eeed2e474abba323aeb06c6a245db95a1b904c on atugushev:master into 86caf150984733eb5a0bb07af26cd8fc0a8d8496 on zyga:master.


Add the --help command line option

Help is helpful (; Why not?

It's a good ideia, thanks!

For inspiration, take a look how elegant --help is implemented in Zora:
https://github.com/lorenzofox3/zora/blob/a2503f96fe1172da0f72e39353823869b9a39a94/pta/src/bin.js#L54-L56

For inspiration, take a look how elegant --help is implemented in Zora:

Thanks, that made it much easier.


Derive and Implement Analytic Hessian for Mixed Logit

This is on the agenda for the coming months, but pull requests or contributions are always welcome.
At the moment, the sum of the outer products of the gradient are used as an approximation to the actual hessian.

Do we know that the Hessian has a closed form? If so do we know what it is? ("Derive" suggests we may not.) All answers are okay. Just trying to assess how much work this will be.

Hey, the same deal applies here as for the nested logit.
I think the hessian exists in closed-form. This is based on the fact that the gradient exists in closed form and that nothing indicates that the derivative of the gradient would be undefined or lose its closed-form nature. I haven't checked the math completely, but equation (3) of the the following link may be the hessian for a mixed logit model (or at least closely related to it): MM ALGORITHM FOR GENERAL MIXED MULTINOMIAL LOGIT MODELS
I say derive simply because I haven't seen explicit formulas for the hessian written down anywhere but it doesn't seem impossible.


sort by most recently "used"

Any interest in an option to sort the list based on the most recent commit timestamp?

sure, that might be useful


API For Schemas

Able to CRUD JSON Schemas
Able to CRUD VC JSON Schemas
Validate data against schemas

Done in #23


Use int for 'checked' manipulator instead of boolean

Fixes discrepancies between iOS and Android's implementations of booleans in sending app mesages

:+1:


clients/openshift: NewFromRestConfig

allow creating a new openshift client from just the base restconfig object
see https://github.com/openshift/osde2e/pull/2151

lgtm


False Negative on xercesImpl.jar

Maven Plugin 7.0.4
xercesImpl-2.12.0.jar should be detected as apache:xerces-j and pick up CVE-2022-23437.
File Path: ~.m2\repository\xerces\xercesImpl\2.12.0\xercesImpl-2.12.0.jar
MD5: b89632b53c4939a2982bcb52806f6dec
SHA1: f02c844149fd306601f20e0b34853a670bef7fa2
SHA256:b50d3a4ca502faa4d1c838acb8aa9480446953421f7327e338c5dda3da5e76d0
Identifiers:

<EMAIL_ADDRESS>(Confidence:High)
cpe:2.3:a:apache:xerces2_java:2.12.0:*:*:*:*:*:*:*  (Confidence:Low)

Evidence
Type | Source | Name | Value | Confidence
Vendor | file | name | xercesImpl | High
Vendor | jar | package name | apache | Highest
Vendor | jar | package name | datatypes | Highest
Vendor | jar | package name | dom | Highest
Vendor | jar | package name | parsers | Highest
Vendor | jar | package name | serialize | Highest
Vendor | jar | package name | version | Highest
Vendor | jar | package name | w3c | Highest
Vendor | jar | package name | xerces | Highest
Vendor | jar | package name | xinclude | Highest
Vendor | jar | package name | xml | Highest
Vendor | jar | package name | xni | Highest
Vendor | manifest: javax/xml/datatype/ | Implementation-Vendor | Apache Software Foundation | Medium
Vendor | manifest: javax/xml/namespace/ | Implementation-Vendor | Apache Software Foundation | Medium
Vendor | manifest: javax/xml/parsers/ | Implementation-Vendor | Apache Software Foundation | Medium
Vendor | manifest: javax/xml/stream/ | Implementation-Vendor | Apache Software Foundation | Medium
Vendor | manifest: javax/xml/transform/ | Implementation-Vendor | Apache Software Foundation | Medium
Vendor | manifest: javax/xml/validation/ | Implementation-Vendor | Apache Software Foundation | Medium
Vendor | manifest: javax/xml/xpath/ | Implementation-Vendor | Apache Software Foundation | Medium
Vendor | manifest: org/apache/xerces/impl/ | Implementation-Vendor | Apache Software Foundation | Medium
Vendor | manifest: org/apache/xerces/xni/ | Implementation-Vendor | Apache Software Foundation | Medium
Vendor | manifest: org/w3c/dom/ | Implementation-Vendor | World Wide Web Consortium | Medium
Vendor | manifest: org/w3c/dom/ls/ | Implementation-Vendor | World Wide Web Consortium | Medium
Vendor | manifest: org/xml/sax/ | Implementation-Vendor | David Megginson | Medium
Vendor | pom | artifactid | xercesImpl | Highest
Vendor | pom | artifactid | xercesImpl | Low
Vendor | pom | developer email |<EMAIL_ADDRESS>| Low
Vendor | pom | developer id | xerces | Medium
Vendor | pom | developer name | Apache Software Foundation | Medium
Vendor | pom | developer org | Apache Software Foundation | Medium
Vendor | pom | developer org URL | http://www.apache.org | Medium
Vendor | pom | groupid | xerces | Highest
Vendor | pom | name | Xerces2-j | High
Vendor | pom | url | https://xerces.apache.org/xerces2-j/ | Highest
Product | file | name | xercesImpl | High
Product | jar | package name | apache | Highest
Product | jar | package name | datatype | Highest
Product | jar | package name | datatypes | Highest
Product | jar | package name | dom | Highest
Product | jar | package name | impl | Highest
Product | jar | package name | parsers | Highest
Product | jar | package name | serialize | Highest
Product | jar | package name | validation | Highest
Product | jar | package name | version | Highest
Product | jar | package name | w3c | Highest
Product | jar | package name | xerces | Highest
Product | jar | package name | xinclude | Highest
Product | jar | package name | xml | Highest
Product | jar | package name | xni | Highest
Product | jar | package name | xpath | Highest
Product | manifest: javax/xml/datatype/ | Implementation-Title | javax.xml.datatype | Medium
Product | manifest: javax/xml/datatype/ | Specification-Title | Java API for XML Processing | Medium
Product | manifest: javax/xml/namespace/ | Implementation-Title | javax.xml.namespace | Medium
Product | manifest: javax/xml/namespace/ | Specification-Title | Java API for XML Processing | Medium
Product | manifest: javax/xml/parsers/ | Implementation-Title | javax.xml.parsers | Medium
Product | manifest: javax/xml/parsers/ | Specification-Title | Java API for XML Processing | Medium
Product | manifest: javax/xml/stream/ | Implementation-Title | javax.xml.stream | Medium
Product | manifest: javax/xml/stream/ | Specification-Title | Streaming API for XML | Medium
Product | manifest: javax/xml/transform/ | Implementation-Title | javax.xml.transform | Medium
Product | manifest: javax/xml/transform/ | Specification-Title | Java API for XML Processing | Medium
Product | manifest: javax/xml/validation/ | Implementation-Title | javax.xml.validation | Medium
Product | manifest: javax/xml/validation/ | Specification-Title | Java API for XML Processing | Medium
Product | manifest: javax/xml/xpath/ | Implementation-Title | javax.xml.xpath | Medium
Product | manifest: javax/xml/xpath/ | Specification-Title | Java API for XML Processing | Medium
Product | manifest: org/apache/xerces/impl/ | Implementation-Title | org.apache.xerces.impl.Version | Medium
Product | manifest: org/apache/xerces/xni/ | Implementation-Title | org.apache.xerces.xni | Medium
Product | manifest: org/apache/xerces/xni/ | Specification-Title | Xerces Native Interface | Medium
Product | manifest: org/w3c/dom/ | Implementation-Title | org.w3c.dom | Medium
Product | manifest: org/w3c/dom/ | Specification-Title | Document Object Model, Level 3 Core | Medium
Product | manifest: org/w3c/dom/ls/ | Implementation-Title | org.w3c.dom.ls | Medium
Product | manifest: org/w3c/dom/ls/ | Specification-Title | Document Object Model, Level 3 Load and Save | Medium
Product | manifest: org/xml/sax/ | Implementation-Title | org.xml.sax | Medium
Product | manifest: org/xml/sax/ | Specification-Title | Simple API for XML | Medium
Product | pom | artifactid | xercesImpl | Highest
Product | pom | developer email |<EMAIL_ADDRESS>| Low
Product | pom | developer id | xerces | Low
Product | pom | developer name | Apache Software Foundation | Low
Product | pom | developer org | Apache Software Foundation | Low
Product | pom | developer org URL | http://www.apache.org | Low
Product | pom | groupid | xerces | Highest
Product | pom | name | Xerces2-j | High
Product | pom | url | https://xerces.apache.org/xerces2-j/ | Medium
Version | file | version | 2.12.0 | High
Version | manifest: org/apache/xerces/impl/ | Implementation-Version | 2.12.0 | Medium
Version | pom | version | 2.12.0

    <hint>
        <given>
            <evidence type="product" source="pom" name="artifactId" value="xercesImpl"/>
            <evidence type="product" source="file" name="name" value="xercesImpl"/>
        </given>
        <add>
            <evidence type="product" source="hint analyzer" name="product" value="xerces-j" confidence="HIGHEST"/>
        </add>
    </hint>

In your hints file will resolve this and ensure detection of this (and potentially other future) false negatives. Will work on a PR to get it included into the next release of ODC


Fix date of next meetup

We decided to drop the december meetup in favor for christmas ;-) Most people will be busy with last minute christmas shopping, visiting family members and so on. We should point out that the next meetup will be held in January and maybe point to a facebook thread to discuss if their should be something like a Glühwein.JS at any date in december.

Pity!


use searchParams prop in server components

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Current dependencies on/for this PR:

main

PR #483   👈

This stack of pull requests is managed by Graphite.


Changes to files that are imported are not propagated

An example:
I have a mixins.less file that has my favorite color stored in a variable. My footer.less file imports the mixins file so it can use that color variable. When I change my favorite color in mixins I have to manually force footer to recompile.
I would expect the compiler to recompile the files that import files that have changed.

Sorry for the late reply. If your files were in subdirectories, they were not picked up due to an error. It is fixed now. Let me know if this fixes your problem.


Convert .NET Core build to use MSBuild-based project

Bond's current .NET Core build is based on the project.json format.
Now that the .NET Core Tools/SDK has full support for MSBuild-based replacement for project.json, we should convert the .NET Core build to use that format.
A preliminary analysis of the some of the options:

Convert just the dnc directory over to the new MSBuild

Pro: minimal amount of work
Con: retains split build trees

Convert the whole C# build over to the new MSBuild

Pro: We can still target .NET 4.5 with the new MSBuild
Pro: one unified build process for all of C#
Con? Would Visual Studio 2017 now be required to build Bond itself?
Con? Can we still target .NET 4.0?
Con? Does Travis have the new tools yet?
Con? Would we still be able to build with the Mono toolchain?

All C# projects were moved to the new format in commit 3c7bdb9738fa547456ca2dc0f487887bd1682b28.


Cannot vertically resize the recordings list/panel

I have a lot of recordings opened... it'd be nice if I could make the Recordings listing bigger.

Duplicate of #3421


CALayerInvalidGeometry crash in JDFlipNumberDigitView.m

I'm seeing an intermittent crash. Here's what it's looks like:
Fatal Exception: CALayerInvalidGeometry
CALayer position contains NaN: [32.5 nan]

Thread : Fatal Exception: CALayerInvalidGeometry
0  CoreFoundation<PHONE_NUMBER> __exceptionPreprocess
1  libobjc.A.dylib<PHONE_NUMBER> objc_exception_throw
2  CoreFoundation<PHONE_NUMBER> -[NSException initWithCoder:]
3  QuartzCore<PHONE_NUMBER> CA::Layer::set_position(CA::Vec2<double> const&, bool)
4  QuartzCore<PHONE_NUMBER> -[CALayer setPosition:]
5  QuartzCore<PHONE_NUMBER> -[CALayer setFrame:]
6  UIKit<PHONE_NUMBER> -[UIView(Geometry) setFrame:]
7  MyApp<PHONE_NUMBER> -[JDFlipNumberDigitView setFrame:] (JDFlipNumberDigitView.m:159)
8  MyApp<PHONE_NUMBER> -[JDFlipNumberView layoutSubviews] (JDFlipNumberView.m:495)
9  UIKit<PHONE_NUMBER> -[UIView(CALayerDelegate) layoutSublayersOfLayer:]
10 QuartzCore<PHONE_NUMBER> -[CALayer layoutSublayers]
11 QuartzCore<PHONE_NUMBER> CA::Layer::layout_if_needed(CA::Transaction*)
12 QuartzCore<PHONE_NUMBER> CA::Layer::layout_and_display_if_needed(CA::Transaction*)
13 QuartzCore<PHONE_NUMBER> CA::Context::commit_transaction(CA::Transaction*)
14 QuartzCore<PHONE_NUMBER> CA::Transaction::commit()
15 UIKit<PHONE_NUMBER> _UIApplicationHandleEventQueue
16 CoreFoundation<PHONE_NUMBER> __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__
17 CoreFoundation<PHONE_NUMBER> __CFRunLoopDoSources0
18 CoreFoundation<PHONE_NUMBER> __CFRunLoopRun

I've gotten this a handful of times on several devices (iPhone 5s, 6, 6s) on both iOS8 and 9.1. It's super intermittent so I haven't been able to reproduce in the debugger.
Seems like the things that affect CALayer's position are bounds, anchorPoint, and possibly transform. Though I haven't been able to figure out where a division by zero could have happened for any of those. I'll post here if I make any progress in diagnosing this.

I can reproduce semi-reliably by mashing cmd-shift-m to trigger memory warnings around the time JDFlipNumberView is laying out. Fixed in #45


Support for custom GraphQL queries in the generated API

Is your feature request related to a problem? Please describe.
One of the purposes of using GraphQL in your application is that you can query for specific fields in your API result. Out of the box Amplify works great, you define your schema and it generates all resolvers that connects to your database. It generates LIST and GET queries for every model, then it generates statements and types for those queries and wraps them into, my use-case, an Angular service. The problem comes when I want to have custom GQL queries that calls existing functions but just limits which fields are returned. If I have to do it, I have to construct this query myself and fetch the data, having no generated types for the result, and manually extending the generated API.
Describe the solution you'd like
The solution would be to allow custom queries -without resolvers-, generate types for them and moving them into the generated API.
Describe alternatives you've considered
Using type generation utilities to compile an external GraphQL file, and generating a new API extending the already generated one with the new function calls.
Additional context
n/a

@brunostuani codegen generated statements are meant to be used as a starting point and not exclusively in your project. We do support and encourage users to add/customize the statements as that is one of the main advantage GraphQL has over traditional rest APIs. If you add additional statements in a different file inside the statement folder, codegen generates types for those too.
Please feel free to comment if you have trouble adding custom statenents

Ah this is exactly what I was looking for. Maybe this is just not very discoverable.
Thanks!

I have exactly same problem, I am struggling with custom queries like brunostuani. But I am not sure I understand the answer here. Says I have a very simple model below:
type Note @model {
id: ID!
clientId: ID
name: String!
description: String
completed: Boolean
createdDate: DateTime
}
amplify generated the getNote, listNotes... in the queries.js under the src/graphql folder (the code fragment) below:
export const getNote = /* GraphQL */   query GetNote($id: ID!) {     getNote(id: $id) {       id       clientId       name       description       completed      createdDate     }   };
...
but I'd like to add getSimpleNote in the simple-queries.js in the same folder:
export const getSimpleNote = /* GraphQL */   query GetSimpleNote($id: ID!) {     getSimpleNote(id: $id) {       id       clientId       name     }   };
then ran the amplify api gql-compile, but it never generate the custom queries I added above. What am I missing? Thank you.

@brunostuani codegen generated statements are meant to be used as a starting point and not exclusively in your project. We do support and encourage users to add/customize the statements as that is one of the main advantage GraphQL has over traditional rest APIs. If you add additional statements in a different file inside the statement folder, codegen generates types for those too.
Please feel free to comment if you have trouble adding custom statenents

@yuth "queries.js" does not generate queries that are nested more than 2 levels deep (i.e if Model A -> Model B -> C the generated code only has elements from ModelA and Model B). I am pretty sure I have selected a value of 4 in the nested queries when setting up the API without understanding what it did at that time and I am assuming that is used here? If so, why are the elements for table C not being generated in the nested query. Any way I can check the value of nesting I have chosen just to be sure?

I am trying to Run a Simple Query to get Doctor details by userId. I checked for the documentation but was not able to find a way for defining a custom query.
query getDoctorsbyuserID($userId: String!) {
getDoctorsbyuserID(userId: $userId) {
id
firstName
lastName
userId
}
}
The queries which are auto generated are working fine but not able to find a way to make custom query work.
What are steps of writing custom queries in Amplify Graphql? Any document/blog ?
Frontend - Reactjs
P.S : I am new to Amplify.


Single 2018 edition crate

This PR updates the codebase to the 2018 edition and merges the distinct crates into one. We're hitting limitations with multiple crates for very little benefit, so merging them will let us hide more implementation details, and use standard types across the distinct features.

I'm also working in some 7.0 support into this PR, but while our integration test coverage is still sparse (we should try convert all the response parsing tests into proper integration tests) there are probably still a lot of holes.

The docs need some more work, they still refer to the old crate layout, but once this is green I'll merge it in so we have something consistent to work off.

Ok there’s progress on the build. We have an issue with the sniffed nodes test where it’s not properly shutting down, even though it should be.
I’m also interested in a few more module refactorings:
mod endpoints {}
mod params {}

mod client {
    mod requests {}
    mod responses {}
}

mod http {
    mod sender {}
    mod receiver {}
}

So that it’s clearer where the high-level and low-level details live.

Wow, this looks awesome! Much easier to navigate.
Thanks for this PR and such an amazing crate!


Threshold implementation in budget page

Codecov Report

Merging #199 into master will decrease coverage by 0.34%.
The diff coverage is 0.00%.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc85821...0cb1eb8. Read the comment docs.


Unexpected file /nbody.js

Looks like there's a nearly identical copy of ~/examples/nodejs/nbody.js in the root directory

Thanks for reporting. We will remove it in the next build.

the file is not there anymore


38 continous integration driving

Description
This pull requests adds the functionality of automatically evaluating our leaderboard agent using a github action.
Because it make sense to base these changes on #93, please merge this one after #93.
Fixes #38
Time invested
Korbinian Stein: 5h
Type of change

New feature (non-breaking change which adds functionality)

Does this PR introduce a breaking change?
No :)
Most important changes
Most important functionality is the additional job in the workflow build.yaml, called drive, which executes the simulation on our self-hosted runner.
Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works (might be obsolete with CI later on)
[x] New and existing unit tests pass locally with my changes (might be obsolete with CI later on)

As mentioned, please do not merge before #93. Sorry for the inconvenience


How to deal with with repeat segments?

Hello there @shogg, thanks for making this package.
I have tried it for a project at work, but we have repeat segment statements, and i don't see a way to extract them with this package?
There is actually also one in the ORDERS spec:

I don't see a clear syntax as to how to extract both lines, i tried:

But that gives:

And in our project i also tried making a "fake" segment group (not in my standardised spec), with only the one FTX tag, to try and parse the repeat segments to an array (which is what i really want), but couldn't get it to work either.
To complicate it further, our spec actually has a single mandatory FTX+ACM followed by 20 conditional FTX+SPC, so the base tag is the same! (i would be glad with just one single array including both FTX+ACM and FTX+SPC)
Here is an example:
FTX+ACM+P00++Væsentlige fejlstillinger;højre fod'
FTX+SPC+P00++Mobil pes planus transversus?:Ja'
FTX+SPC+P00++Hallux valgus?:Ja'

We consume a variant of this spec:
https://service.unece.org/trade/untdid/d09a/trmd/medrpt_c.htm
Hope to hear from you, kind regards

I have a simple patch for Comments []string. Comment1, Comment2 will still not work. Tomorrow I'll test corner cases before pushing.

Wow that would be amazing! thank you! Comments []string is the ideal case

I pushed the patch.
There is a new test in unmarshal_rffs_test.go to show what to expect when unmarshalling into a slice.

it works perfectly, thanks alot!


Typos

Hello,
This PR mainly corrects typos and removes unnecessary (or hidden) char / new_line.
Best regards,

Thanks for taking the time to fix these!


Live queries issue

What version of fleet are you using (fleet version --full)?
fleet - version 2.3.0
  branch:       master
  revision:     bc9782e9b0c431ce8c24552861f5527fb0f4c390
  build date:   2019-08-14T18:55:06Z
  build user:   zwass
  go version:   go1.12.8

What operating system are you using?
LSB Version:    n/a
Distributor ID: SUSE
Description:    SUSE Linux Enterprise Server 12 SP2
Release:        12.2
Codename:       n/a

Sometimes cannot run live queries:

But the redis instance is working without errors:
# systemctl status redis@kolide
●<EMAIL_ADDRESS>- Redis
   Loaded: loaded<EMAIL_ADDRESS>enabled; vendor preset: disabled)
  Drop-In<EMAIL_ADDRESS>           └─limits.conf
   Active: active (running) since Tue 2019-09-03 16:56:15 CEST; 18h ago
 Main PID: 14680 (redis-server)
    Tasks: 4 (limit: 512)
   CGroup<EMAIL_ADDRESS>           └─14680 /usr/sbin/redis-server <IP_ADDRESS>:6379

Sep 03 16:56:15 slx00010930 systemd[1]: Started Redis.
# redis-cli client list
id=17 addr=<IP_ADDRESS>:57160 fd=11 name= age=602 idle=598 flags=N db=0 sub=1 psub=0 multi=-1 qbuf=0 qbuf-free=0 obl=0 oll=0 omem=0 events=r cmd=subscribe
id=18 addr=<IP_ADDRESS>:58096 fd=12 name= age=598 idle=595 flags=N db=0 sub=1 psub=0 multi=-1 qbuf=0 qbuf-free=0 obl=0 oll=0 omem=0 events=r cmd=subscribe
id=7 addr=<IP_ADDRESS>:40448 fd=8 name= age=1065 idle=1062 flags=N db=0 sub=1 psub=0 multi=-1 qbuf=0 qbuf-free=0 obl=0 oll=0 omem=0 events=r cmd=subscribe
id=10 addr=<IP_ADDRESS>:36642 fd=9 name= age=877 idle=873 flags=N db=0 sub=1 psub=0 multi=-1 qbuf=0 qbuf-free=0 obl=0 oll=0 omem=0 events=r cmd=subscribe
id=24 addr=<IP_ADDRESS>:39874 fd=13 name= age=260 idle=256 flags=N db=0 sub=1 psub=0 multi=-1 qbuf=0 qbuf-free=0 obl=0 oll=0 omem=0 events=r cmd=subscribe
id=13 addr=<IP_ADDRESS>:45032 fd=10 name= age=746 idle=743 flags=N db=0 sub=1 psub=0 multi=-1 qbuf=0 qbuf-free=0 obl=0 oll=0 omem=0 events=r cmd=subscribe
id=30 addr=<IP_ADDRESS>:56708 fd=14 name= age=0 idle=0 flags=N db=0 sub=0 psub=0 multi=-1 qbuf=0 qbuf-free=32768 obl=0 oll=0 omem=0 events=r cmd=client

It looks like the error shows that Redis (or something between Redis and the Fleet server) closed the connection unexpectedly.
This shows the Redis server bound to localhost. Is the Fleet server running on the same host?
What we really would like to see for debugging this is whether you can PING the redis server from redis-cli or telnet on the host running Fleet.

The redis server is on the same server as fleet
# systemctl status kolide redis@kolide
● kolide.service - Kolide Server
   Loaded: loaded (/usr/lib/systemd/system/kolide.service; enabled; vendor preset: disabled)
   Active: active (running) since Tue 2019-09-03 16:56:15 CEST; 6 days ago
 Main PID: 14683 (fleet)
    Tasks: 28 (limit: 512)
   CGroup: /system.slice/kolide.service
           └─14683 /bin/fleet serve --config /etc/kolide/kolide.yml

Sep 03 16:56:15 slx00010930 systemd[1]: Started Kolide Server.
Sep 03 16:56:15 slx00010930 fleet[14683]: Using config file:  /etc/kolide/kolide.yml

●<EMAIL_ADDRESS>- Redis
   Loaded: loaded<EMAIL_ADDRESS>enabled; vendor preset: disabled)
  Drop-In<EMAIL_ADDRESS>           └─limits.conf
   Active: active (running) since Tue 2019-09-03 16:56:15 CEST; 6 days ago
 Main PID: 14680 (redis-server)
    Tasks: 4 (limit: 512)
   CGroup<EMAIL_ADDRESS>           └─14680 /usr/sbin/redis-server <IP_ADDRESS>:6379

Sep 03 16:56:15 slx00010930 systemd[1]: Started Redis.

I can ping redis:
# redis-cli ping
PONG

Hi,
I have changed the config of these parameters:
      config_refresh: 300
      distributed_interval: 300
      logging_interval: 60

And not getting the redis error message, but i cannot live query from UI, but i can live query using fleetctl.

# fleetctl query --query 'select version from osquery_info;' --labels='SLES 12 SP3' --exit
{"host":"xxx","rows":[{"host_hostname":"xxx","version":"3.3.2"}]}
{"host":"xxx","rows":[{"host_hostname":"xxx","version":"3.3.2"}]}
{"host":"xxx","rows":[{"host_hostname":"xxx","version":"3.3.2"}]}
{"host":"xxx","rows":[{"host_hostname":"xxx","version":"3.3.2"}]}
{"host":"xxx","rows":[{"host_hostname":"xxx","version":"3.3.2"}]}
{"host":"xxx","rows":[{"host_hostname":"xxx","version":"3.3.2"}]}
{"host":"xxx","rows":[{"host_hostname":"xxx","version":"3.3.2"}]}
{"host":"xxx","rows":[{"host_hostname":"xxx","version":"3.3.2"}]}
{"host":"xxx","rows":[{"host_hostname":"xxx","version":"3.3.2"}]}
{"host":"xxx","rows":[{"host_hostname":"xxx","version":"3.3.2"}]}
{"host":"xxx","rows":[{"host_hostname":"xxx","version":"3.3.2"}]}
{"host":"xxx","rows":[{"host_hostname":"xxx","version":"3.3.2"}]}
{"host":"xxx","rows":[{"host_hostname":"xxx","version":"3.3.2"}]}
{"host":"xxx","rows":[{"host_hostname":"xxx","version":"3.3.2"}]}
{"host":"xxx","rows":[{"host_hostname":"xxx","version":"3.3.2"}]}
{"host":"xxx","rows":[{"host_hostname":"xxx","version":"3.3.2"}]}
{"host":"xxx","rows":[{"host_hostname":"xxx","version":"3.3.2"}]}
{"host":"xxx","rows":[{"host_hostname":"xxx","version":"3.3.2"}]}
{"host":"xxx","rows":[{"host_hostname":"xxx","version":"3.3.2"}]}
{"host":"xxx","rows":[{"host_hostname":"xxx","version":"3.3.2"}]}
{"host":"xxx","rows":[{"host_hostname":"xxx","version":"3.3.2"}]}
{"host":"xxx","rows":[{"host_hostname":"xxx","version":"3.3.2"}]}
{"host":"xxx","rows":[{"host_hostname":"xxx","version":"3.3.2"}]}
{"host":"xxx","rows":[{"host_hostname":"xxx","version":"3.3.2"}]}
{"host":"xxx","rows":[{"host_hostname":"xxx","version":"3.3.2"}]}
{"host":"xxx","rows":[{"host_hostname":"xxx","version":"3.3.2"}]}
{"host":"xxx","rows":[{"host_hostname":"xxx","version":"3.3.2"}]}
{"host":"xxx","rows":[{"host_hostname":"xxx","version":"3.3.2"}]}
{"host":"xxx","rows":[{"host_hostname":"xxx","version":"3.3.2"}]}
{"host":"xxx","rows":[{"host_hostname":"xxx","version":"3.3.2"}]}
{"host":"xxx","rows":[{"host_hostname":"xxx","version":"3.3.2"}]}
{"host":"xxx","rows":[{"host_hostname":"xxx","version":"3.3.2"}]}
{"host":"xxx","rows":[{"host_hostname":"xxx","version":"3.3.2"}]}
{"host":"xxx","rows":[{"host_hostname":"xxx","version":"3.3.2"}]}
{"host":"xxx","rows":[{"host_hostname":"xxx","version":"3.3.2"}]}
{"host":"xxx","rows":[{"host_hostname":"xxx","version":"3.3.2"}]}
{"host":"xxx","rows":[{"host_hostname":"xxx","version":"3.3.2"}]}
{"host":"xxx","rows":[{"host_hostname":"xxx","version":"3.3.2"}]}
{"host":"xxx","rows":[{"host_hostname":"xxx","version":"3.3.2"}]}
{"host":"xxx","rows":[{"host_hostname":"xxx","version":"3.3.2"}]}
{"host":"xxx","rows":[{"host_hostname":"xxx","version":"3.3.2"}]}
{"host":"xxx","rows":[{"host_hostname":"xxx","version":"3.3.2"}]}
{"host":"xxx","rows":[{"host_hostname":"xxx","version":"3.3.2"}]}
{"host":"xxx","rows":[{"host_hostname":"xxx","version":"3.3.2"}]}
{"host":"xxx","rows":[{"host_hostname":"xxx","version":"3.3.2"}]}
{"host":"xxx","rows":[{"host_hostname":"xxx","version":"3.3.2"}]}
{"host":"xxx","rows":[{"host_hostname":"xxx","version":"3.3.2"}]}
{"host":"xxx","rows":[{"host_hostname":"xxx","version":"3.3.2"}]}
{"host":"xxx","rows":[{"host_hostname":"xxx","version":"3.3.2"}]}
{"host":"xxx","rows":[{"host_hostname":"xxx","version":"3.3.2"}]}
{"host":"xxx","rows":[{"host_hostname":"xxx","version":"3.3.2"}]}
{"host":"xxx","rows":[{"host_hostname":"xxx","version":"3.3.2"}]}
{"host":"xxx","rows":[{"host_hostname":"xxx","version":"3.3.2"}]}
{"host":"xxx","rows":[{"host_hostname":"xxx","version":"3.3.2"}]}
{"host":"xxx","rows":[{"host_hostname":"xxx","version":"3.3.2"}]}
{"host":"xxx","rows":[{"host_hostname":"xxx","version":"3.3.2"}]}
{"host":"xxx","rows":[{"host_hostname":"xxx","version":"3.3.2"}]}
{"host":"xxx","rows":[{"host_hostname":"xxx","version":"3.3.2"}]}
{"host":"xxx","rows":[{"host_hostname":"xxx","version":"3.3.2"}]}
{"host":"xxx","rows":[{"host_hostname":"xxx","version":"3.3.2"}]}
{"host":"xxx","rows":[{"host_hostname":"xxx","version":"3.3.2"}]}
{"host":"xxx","rows":[{"host_hostname":"xxx","version":"3.3.2"}]}
{"host":"xxx","rows":[{"host_hostname":"xxx","version":"3.3.2"}]}
⠋ 97% responded (98% online) | 62/64 targeted hosts (62/63 online)

Hi,
I am on version 2.6.0:
# fleet version --full
fleet - version 2.6.0
  branch:       master
  revision:     d3849d8fe1ea841d34a19e5cc06bfe62fc8dfd2d
  build date:   2020-03-24T17:27:31Z
  build user:   zwass
  go version:   go1.13.4

And now when i try to query a host from UI y get a blank page.
I can query host using fleetctl.
Thanks.

Is this still an issue on the latest release?

I have just updated to latest version and still the same problem with live queries.
$fleet version --full
fleet - version 3.2.0
  branch:       master
  revision:     07534c766beb7bf9a022d29572d88493ecef8f7c
  build date:   2020-10-08T19:24:59Z
  build user:   zwass
  go version:   go1.15

I can run live queries using fleetctl but not on the web UI.
Any ideas to solve it ?
Thanks.
Best regards.

I have had to rollback again to 2.6.0 (vm snapshot) due to query packs not being executed or results not being logged.


Add support for additional packages

Would be nice to support the setup of additional (apk) packages through a environment variable.
This way we can add build capabilities without forking the docker image.
Something like :
X_ADDITIONAL_PACKAGES : "nodejs nodejs-npm"
That would run at startup :
apk add --update nodejs nodejs-npm
This way bamboo can build stuff with nodejs, or with any deployment specific dependencies ;-)

Interesting idea, i'll look into that 👍

I've found the very same problem with my first test. Besides the support to install deps on creating the container.
Is that it switch to USER daemon:daemon that doesn't have any privileges to apk :(  so you can't even installed on build process.
bash-4.4$ apk add php
ERROR: Unable to lock database: Permission denied
ERROR: Failed to open apk database: Permission denied

bash-4.4$ su -
su: must be suid to work properly

😔

Here is my config that allowed to install docker inside the image:
FROM cptactionhank/atlassian-bamboo:6.3.1
ARG DOCKER_GID
USER root
RUN apk add --no-cache git-lfs shadow docker

RUN groupmod -g ${DOCKER_GID} docker && \
    usermod -aG docker daemon
USER daemon

EXPOSE 8085 54663
VOLUME ["/var/atlassian/bamboo","/opt/atlassian/bamboo/logs"]
WORKDIR /var/atlassian/bamboo
ENTRYPOINT ["/docker-entrypoint.sh"]
CMD ["/opt/atlassian/bamboo/bin/start-bamboo.sh", "-fg"]

Also, the docker-compose needs the following instead of the image key:
    build:
      context: .
      dockerfile: bamboo-dockerfile
      args:
        DOCKER_GID: 116

116 was the GID on my server

I wanted to install npm on my docker, but if exec-ing into it and doing a simple apt-get update it fails. Any idea how to provide the tools we need to use Bamboo properly?
apt-get update
E: Could not open lock file /var/lib/apt/lists/lock - open (13: Permission denied)
E: Unable to lock directory /var/lib/apt/lists/
E: Could not open lock file /var/lib/dpkg/lock - open (13: Permission denied)
E: Unable to lock the administration directory (/var/lib/dpkg/), are you root?
daemon@bamboo-server-vpcfn:/var/atlassian/bamboo$ su root
su: must be run from a terminal

You are not logged in as root, use the --user flag with docker exec to login as root to be able to run apt-get update

Thanks @cptactionhank it worked for me. This is how i ran it
docker exec -it --user=root bamboo /bin/bash


"index out of bounds" error, panic in side_by_side.rs

TL;DR - steps to reproduce at the bottom. I'm running this version:
Difftastic 0.57.0 (built with rustc 1.77.1)

I'm diffing two files with no command-line options. One file has 547,616 lines the other has 546,196 lines.
When I run this command:
difft a.txt b.txt

I get this error after 546,196 lines:
thread 'main' panicked at src/display/side_by_side.rs:488:58:
index out of bounds: the len is 547616 but the index is 547616
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Running with RUST_BACKTRACE=1 gives me this:
thread 'main' panicked at src/display/side_by_side.rs:488:58:
index out of bounds: the len is 547616 but the index is 547616
stack backtrace:
   0: _rust_begin_unwind
   1: core::panicking::panic_fmt
   2: core::panicking::panic_bounds_check
   3: difft::display::side_by_side::print
   4: difft::print_diff_result
   5: difft::main
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

Running with RUST_BACKTRACE=full gives me this:
thread 'main' panicked at src/display/side_by_side.rs:488:58:
index out of bounds: the len is 547616 but the index is 547616
stack backtrace:
   0:        0x1026747ac - <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt::h6e13e5c1f43a2491
   1:        0x102484f24 - core::fmt::write::ha2c1956860377338
   2:        0x10267ac48 - std::io::Write::write_fmt::ha4b28c52ceab65a6
   3:        0x1026745a0 - std::sys_common::backtrace::print::h479f79ccc1585c96
   4:        0x102689d64 - std::panicking::default_hook::{{closure}}::h3432bfbcced8e86b
   5:        0x102689a80 - std::panicking::default_hook::h0a224004d0f52354
   6:        0x10268a1b4 - std::panicking::rust_panic_with_hook::h0a46a8ecc3586611
   7:        0x102674d34 - std::panicking::begin_panic_handler::{{closure}}::hafb87b136ffd6947
   8:        0x1026749f0 - std::sys_common::backtrace::__rust_end_short_backtrace::h35ccaf072a47767f
   9:        0x102689f50 - _rust_begin_unwind
  10:        0x102e56b04 - core::panicking::panic_fmt::h11c5b4b324cc1c7c
  11:        0x102e56c5c - core::panicking::panic_bounds_check::hc32fa3cf74afc646
  12:        0x1025045c0 - difft::display::side_by_side::print::h89ef2d4f6f4c33bb
  13:        0x1024b68dc - difft::print_diff_result::hacca16cc5ae65f90
  14:        0x1024b3534 - difft::main::hc24eec628cb9e943
  15:        0x1024bd988 - std::sys_common::backtrace::__rust_begin_short_backtrace::hb7290b100c936322
  16:        0x1024d9430 - std::rt::lang_start::{{closure}}::h4506ff0be546a910
  17:        0x102689e58 - std::panicking::try::h339e50e350ac9bf3
  18:        0x102676888 - std::rt::lang_start_internal::ha7854c9dc8ed1474
  19:        0x1024b6c64 - _main

Working comparison:
shuf -i<PHONE_NUMBER>1344-154195313684130 --random-source=/dev/urandom -n 100 > 100.txt
shuf -i<PHONE_NUMBER>1344-154195313684130 --random-source=/dev/urandom -n 500 > 500.txt
difft 100.txt 500.txt

To reproduce:
Adding one more line makes it fail:
shuf -i<PHONE_NUMBER>1344-154195313684130 --random-source=/dev/urandom -n 501 > 501.txt
difft 100.txt 501.txt

And this is the new output:
thread 'main' panicked at src/display/side_by_side.rs:488:58:
index out of bounds: the len is 100 but the index is 100
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Dupe of several others

Merging into #688, thanks for the report!


Can't change editor shortcuts for next/previous script

Godot version:
3.2.3 stable
OS/device including version:
Windows 10
OpenGL ES 3.0 Renderer: GeForce GTX 1080/PCIe/SSE2
Issue description:
I opened the "Shortcuts" tab in the editor settings and changed the "Next script" and "Previous script" shortcuts under the "Script Editor" section to Ctrl+PageUp / Ctrl+PageDown, respectively. Originally they are Ctrl+Shift+, and Ctrl+Shift+.. However, after settings these shortcuts and pressing them in the text edtior nothing happens, the current/selected script does not change.

Maybe this is because Ctrl + PageUp and Ctrl + PageDown is already used in the script editor itself? Therefore, the script editor intercepts the shortcut.

Maybe this is because Ctrl + PageUp and Ctrl + PageDown is already used in the script editor itself? Therefore, the script editor intercepts the shortcut and considers the input event as handled.

I thought about so too, but when searching for another shortcut using Ctrl+PageUp or Ctrl+PageDown, I couldn't find any. So I don't see that anything else is using these shortcuts. Or are they built-in and therefore not an option to change in the editor settings?

I think it's used internally in text edit maybe? So it won't be listed in the editor shortcuts section. #43663 addresses this issue.

I would like to contribute

@Rprabudeva This is not a trivial issue to solve. I'd look at issues labeled junior job instead. Make sure to pick an issue which is not being addressed by a pull request already (check the column on the right for "pull request" icons, there should be none.)=

So do I understand correctly that for now I cannot use Ctrl+PageUp or Ctrl+PageDown for my custom editor shortcuts?

@haimat Indeed, I don't think that'll work until https://github.com/godotengine/godot/pull/43663 is merged.

I've encountered this before: https://github.com/godotengine/godot/issues/39780
I ended up with Ctrl+Alt+Up/Down to switch scripts.


Improve add_facts performance

When making multiple add_facts calls to add facts to an already present and large set of target facts performance declines as more are added due to the initialization and copying of the large hashes each time.
This change merges the added facts in place to the existing facts, which greatly improves performance when merging in a number of larger fact sets.

I will fix this up and re-push, but just so you know - the original symptom of VERY slow add_facts calls which sent me down this path seem to have actually been due to the Bolt analytics associated collected for that call.  In the scenario I was testing I have some 3,300 targets which I'm trying to add 6 specific facts from PuppetDB each to (the whole set of facts is unneeded and would be way too much) - which results in a little more than 20,000 add_facts calls.  It seems when analytics is enabled it just falls over at some point when processing them.  For a smaller but still large number of calls it just makes the add_facts calls start to take progressively (and significantly) more time to return.  When I added analytics: false to the bolt-project.yaml it immediately started working and the performance was quite acceptable.
I was misled in my troubleshooting because it seems that analytics is not enabled when running bolt from a Git checkout instead of from the normal package.  So, this change is probably still a good idea, but is quite incremental vs. revolutional as I had initially thought.

Thanks for reporting that. I've filed a bug issue and I intend on disabling analytics submissions by default moving forward. https://github.com/puppetlabs/bolt/issues/3293


1.1.0 update fails to install via Nuget

I'm getting this error on the latest update in VS PM console:

Could not install package 'Reckdl 1.1.0'. You are trying to install this package into a project that targets '.NETFramework,Version=v4.6', but the package does not contain any assembly references or content files that are compatible with that framework. For more information, contact the package author.

The previous version of Reckdl worked fine for me. It appears that github master isn't up to date with 1.1.0, so I can't really see what's going on.

I left out the package info for 4.5.1. Sorry about that, didn't think anyone else was using it. I'll try to fix that tonight or tomorrow and get source control updated. You should still be able to use the old version the only thing that was fixed in the update was how its handling csv calls.

Alright I have updated the source control and pushed a new package into nuget.org. I set it back to the original .net version it was built with. I'll deal with updating the .net version in the future. Let me know if that solves your issue, if not we can put our heads together and figure it out. Sorry again for the headache!

Hmm. I've installed build tools for .net 4-4.6, 4.6.1, 4.6.2, 4.7... The latest version from this is the only build fail I'm getting. I've rolled back to 1.0.1 for now and pinned it there in packages.conf

This lib will be updated to .net standard 2.0 in the near future. If you experience further install issues after the update please open a new ticket for it. Hopefully now that net core has settled down a bit things wont break quite as much between updates.


[WIP] Composite virtualization story

@Bnaya Any context on why you ended up closing it?, seems to be a lot of work

Some things didn't worked as expected, so i've abandoned this effort
I'm also no longer working on the project involving dnd-kit


Do not log missing container stats error

Recently did some refactoring that had the side effect of always asking docker daemon for container stats instead of relying on some internal state that could tell if container definitely was not running. In some cases this caused 404s with ugly stack traces in host-admin log, they are coming from docker-java: https://github.com/docker-java/docker-java/blob/f6a2d49767022447e63dda31676fd5fd1cedd8f6/src/main/java/com/github/dockerjava/core/async/ResultCallbackTemplate.java#L54
I tried to override the log level for that class, but still ended up with other stack trace due to closing of the stream. This PR creates a new hack to avoid having streaming in the first place.
Quick summary of the original problem:
Docker stats command, by default, is streaming stats: https://docs.docker.com/engine/api/v1.26/#operation/ContainerStats, we can get a one-off if we use stream=false. docker-api does not support setting stream, so what we did up until now was to start the stream, then close it on the first frame. This PR introduces a hack that bypasses most of docker-java and issues a non-streaming request directly.

Docker stats command is really slow, mostly due to internal wait to get two data points for CPU usage 1s apart, see https://github.com/moby/moby/issues/23188.
But for some reason, with stream=false it is even slower, twice as slow! Stats update frequency with docker-api from HEAD (3 running containers):
2019-07-10T08:43:01.534241251Z
2019-07-10T08:43:02.534815521Z
2019-07-10T08:43:03.531957291Z
2019-07-10T08:43:56.535108846Z
2019-07-10T08:43:58.532769680Z
2019-07-10T08:43:59.536174541Z
2019-07-10T08:44:51.534740524Z
2019-07-10T08:44:52.535038953Z
2019-07-10T08:44:53.532305930Z
2019-07-10T08:45:46.534967814Z
2019-07-10T08:45:47.535169729Z
2019-07-10T08:45:48.533493609Z
2019-07-10T08:46:41.534741305Z
2019-07-10T08:46:42.534152907Z
2019-07-10T08:46:43.534275746Z
2019-07-10T08:47:36.534986383Z
2019-07-10T08:47:37.534000360Z
2019-07-10T08:47:38.532455628Z
2019-07-10T08:48:31.787023520Z
2019-07-10T08:48:32.534001429Z
2019-07-10T08:48:33.532885952Z

With this PR:
2019-07-10T08:55:06.536734787Z
2019-07-10T08:55:09.538074614Z
2019-07-10T08:55:11.537271428Z
2019-07-10T08:56:01.537264098Z
2019-07-10T08:56:03.544108494Z
2019-07-10T08:56:05.535252346Z
2019-07-10T08:56:56.539870379Z
2019-07-10T08:56:58.535054422Z
2019-07-10T08:57:00.533954768Z
2019-07-10T08:57:51.535251130Z
2019-07-10T08:57:53.533692882Z
2019-07-10T08:57:55.536596356Z
2019-07-10T08:58:46.535237538Z
2019-07-10T08:58:48.534439681Z
2019-07-10T08:58:50.532935381Z
2019-07-10T08:59:41.534899602Z
2019-07-10T08:59:43.533923556Z
2019-07-10T08:59:45.533824011Z
2019-07-10T09:00:36.534531634Z
2019-07-10T09:00:38.534712289Z
2019-07-10T09:00:40.535173631Z
2019-07-10T09:01:31.534062784Z
2019-07-10T09:01:33.533869865Z
2019-07-10T09:01:35.532681861Z
2019-07-10T09:02:26.534002609Z
2019-07-10T09:02:28.533578418Z
2019-07-10T09:02:30.533341191Z
2019-07-10T09:03:21.534181850Z
2019-07-10T09:03:23.534486982Z
2019-07-10T09:03:25.531734945Z

At 2sec/request, we will spend 1 minute updating stats on a host with 30 containers, but the update frequency is only 55 sec, so this wont work.
I think we need to consider writing our own container stats collector that goes directly to cgroups. This will also work well for when/if we switch to podman.
FYI: @hakonhall


Does not work on a secondary window.

Plugin does not work if the tbale is on a note opened in a window that is not the main obsidian window.

Hello,
Can you please provide some more context to the problem?
What is the meaning of a "secondary window"? How does it differ from the "main window"?
Furthermore, what "does not work" mean here, specifically? Does not sort at all, sorting is wrong, no cycling through asc / desc.. etc?

Fixed in 0.3.1.


Add notes to applications

US5:
As a leader of a group
I want to be able to add comments to applications
So that I can keep notes
Package tasks:
N/A
Prototype tasks:

[ ] Create Note-model
[ ] Create endpoints for posting, retrieving and deletion of notes

NB! Can only be done by the creator of the notes

[ ] Add note-section to application detail-page:

Show in chronological order
NB! Notes should only be accessed by the creator of the notes

Was this requested at all during the last recruitment period? If not, I think we should consider wontfixing this one.
Should we make opptak.ntnui.no a tool that should be used during interviews as well?


Running tests separately is broken

Now that more pieces have now been converted to Javascript, its impossible to test some pieces in separation. Try ./test scan for example.
The problem is that when running tests that have additional dependencies, the dependency order is invalid and you get
AssertionError: There shouldn't be coffee pieces after js ones.

I'm planning on converting the rest of files to JS as well. The biggest blocker is trying to avoid too bad conflicts with active PRs.
If necessary, tests can be converted as well. Having only one language should simplify the situation.
Sent from my iPhone

On 15 Oct 2015, at 15:01, Juha Paananen<EMAIL_ADDRESS>wrote:
Now that more pieces have now been converted to Javascript, its impossible to test some pieces in separation. Try ./test scan for example.
The problem is that when running tests that have additional dependencies, the dependency order is invalid and you get
AssertionError: There shouldn't be coffee pieces after js ones.
—
Reply to this email directly or view it on GitHub.


Add support for named build stages

follow-up to #31257
#31257 added support for copying data from other build stages by an incrementing ID. While this works fine in cases where you want to make least changes to existing Dockerfiles, it has the following problems:

Numeric ID doesn't provide context for the reader about what is actually copied
When new build stages are added all the numbers may need to be changed.

This PR lets the user to optionally give a name the build stage. Then afterward this name can be used in COPY --from=name src dest and FROM name. If a build stage is defined with that name it takes precedence in these commands, if it is not found, an image with that name is attempted to be used instead. So there is no need to write FROM foo as foo if data from an image is needed directly.
Examples:
FROM ubuntu AS build-env
RUN apt-get install make
ADD . /src
RUN cd /src && make

FROM busybox
COPY --from=build-env /src/build/app /usr/local/bin/app
EXPOSE 80
ENTRYPOINT /usr/local/bin/app

from debian as build-essential
arg APT_MIRROR
run apt-get update
run apt-get install -y make gcc
workdir /src

from build-essential as foo
copy src1 .
run make

from build-essential as bar
copy src2 .
run make

from alpine
copy --from=foo bin1 .
copy --from=bar bin2 .
cmd ...

@tiborvass @dnephin @dmcgowan @simonferquel @philtay

LGTM

design LGTM

What happens to the layers in the intermediate or final image if you need do copy --from for several locations like /dir1 /dir2? Does that result in one layer per copy --from?

@alexellis Every COPY instruction creates a single layer(you can have multiple source paths). Nothing happens to the source/intermediate image, it keeps its original layers for build cache. If the files marked as source path were in separate layers in the original image they will get squashed.

Thanks for the explanation 👍

I'm +1 for this. @duglin thoughts?

Can we please see the larger design doc/plans for all of these Dockerfile changes?
I find it a little odd that such big changes are being proposed, and adopted relatively quickly, and yet something as trivial as INCLUDE has been blocked for ages.
I can't help but feel like this is all leading up to something but we're not being told what. And yes, I'm having flashbacks to the v1.12 days where leading up to DockerCon swarmkit was added in a similar way.
I'd just like to understand the bigger picture because in isolation some of these changes feel like they're being rushed through with minimal consideration - at least when compared with far smaller changes - and its not clear to me how they all relate to one another and it would a lot easier to evaluate each one if we knew the end game.

In general I like this, with one exception:

if it is not found, an image with that name is attempted to be used instead.

I don't like this behaviour. I don't think it's asking too much to have to define images up-front in a FROM line before they get used in a COPY --from. It makes the behaviour easier to explain, and it doesn't mix namespaces (context names with images).
If images always have to be defined on a FROM line it becomes really easy to determine which images will be used by a build. If COPY --from can be an image or a context name it becomes more involved.

@duglin

Can we please see the larger design doc/plans for all of these Dockerfile changes?

This was the plan: https://github.com/docker/docker/issues/31067
You participated in it and we used one of your ideas: https://github.com/docker/docker/issues/31067#issuecomment-286592682
This current PR simply makes a change to make it more user-friendly by using names instead of numbers.
And there's a follow-up proposal here https://github.com/docker/docker/issues/32100 on which it would be great if you could participate.

I find it a little odd that such big changes are being proposed, and adopted relatively quickly, and yet something as trivial as INCLUDE has been blocked for ages.

The INCLUDE PR is only trivial in its implementation, it has a lot of design issues that have been mentioned in the past on the PR itself (mainly that it encourages broken snippets). I agree with you we didn't do a good job processing it quickly enough, I apologize for that. I do want us to address all usecases there. I also hope that some of them will be resolved by https://github.com/docker/docker/issues/31067.
In fact, I pinged you on this PR because I value your opinion given your involvement.

I can't help but feel like this is all leading up to something but we're not being told what. And yes, I'm having flashbacks to the v1.12 days where leading up to DockerCon swarmkit was added in a similar way.

I understand why you feel that way, but I guarantee you that DockerCon timing is coincidental. The chained/nested builds PR was something many people wanted and it seemed to me there was design agreement. If you strongly disagree with the PR merged, we're happy to discuss the points. Again, it was my understanding you were in agreement.

@dnephin I think it is quite nice that --from and FROM have same semantics now. In both cases the local name takes precedence and pulled image is used as a backup. I also think sharing content with images is something we should encourage and not make unnecessarily hard. You mention mixing context names and images, but I think it is confusing to call them context names and these are not the terms most users think in. AS defines a name for the image that is being built with the next instructions, so it is still an image name just no such reference exists after builder has finished.

@tiborvass its not really a question of whether I agree or disagree with the direction of these PRs - to be honest, I've been so busy recently I feel bad that I haven't had a chance to really dig deep into them to know if I like them or not.  Yes I do agree that having nested builds in general is good, but I can't say if the current approach is one I agree with or not.
However, notice that as soon as we merged that PR another was immediately opened to "fix" the UX of it - showing it really should have been vetted more before it was merged. And then we have some follow-on PRs to add even more in this space  (like INSTALL/EXPORT) - which would have been good to discuss together to fully explore the implications of them being used together.  I would really prefer more time to analyze these PRs and in particular have them put under the "experimental" flag since there are very large fundamental design discussions/reviews and "playing with" that should happen before we claim its GA ready.
Net (and yes a bit of venting, sorry): IMO some of the frustration coming from the community is related to situations like this. The INCLUDE PR is just a good example to pick on, and not the only one, but there appears to be what I would call "selective complexity syndrome".  Something as trivial as a syntax INCLUDE (which is far from a new concept) has "complexity" while others, that are clearly more complex in all ways, seem to sail thru - especially when in the past those very same concepts were rejected for some mysterious reason - but I'm sure people can speculate why. :-)
But I digress, and sorry for that, I'll try to find time to review these (and the merged PRs too) soon.

@tonistiigi I agree with your comments about --from and FROM having the same semantics - treating them both as image names is a nice consistency.  One additional thought: people have  asked for the ability to name images from within the Dockerfile.  Right now people can do so with AS but its scope is limited to just this build.  Perhaps we could consider allowing these AS names to be real and live beyond the scope of the build.
Whether we do it via the AS flag, or introduce a new TAG (or NAME) type of command doesn't matter much - although with TAG people can specify more than one, which could be handy, especially when people use variables in the name - so they could name it with multiple tags (e.g. "latest" and a specific version number).  Actually, with TAG it almost makes AS unnecessary and we could revert FROM to its old, less complex :-) , syntax.   Just a thought...

@duglin Yes, the build definition should not try to attempt to set a reference for an image and that's why TAG has been rejected from Dockerfile. Ideally, build definition should be a function from immutable sources to an opaque result without any side effects. Tagging a result is an extra optional step that can happen after that. The name in AS defines a name that is local to the Dockerfile. Every file can define its own build stage names and they will never leak outside of the build process or be committed to any of the images. You can use name build-env in any of the images that need the simple "build and distribute with small image" model and they will never collide. Tag(reference) is a pointer to a single instance of an object that defines the current discovery or signing authority for that instance. I do think there may be a use case for tagging the intermediate images and build stage name is a good way how to define that connection, more on that in #32104.

It feels natural to type COPY app --from 0 or --from named_build rather than --from=yxz. @tonistiigi is this fixed "in stone"?

@alexellis Flag parsing in builder is a generic feature and not added by this PR. It is used by HEALTHCHECK for example. Feel free to create an issue to discuss relaxing this but shouldn't be part of this PR.

@dnephin Updated. PTAL

Design LGTM

I don't know if this should be part of this PR but I would like to be able to build multiple images from the same Dockerfile. As such it would be nice to have the option to specify which of the nested builds should be the result of the docker build command.
One example of this could be maintaining a Dockerfile that builds both a test and a production version of an image where the production version would not contain test files.

@jacobat #32104

@tonistiigi we have to make sure the new syntax work with the whacky trusted content / notary stuff. If I understand correctly this happen on client side (it rewrites the FROM clauses in the origin dockerfile). (sorry I did not saw that before)

@simonferquel I believe this already works fine. The regexp https://github.com/docker/docker/blob/master/cli/command/image/build.go#L358 ignores everything after the image reference. Could add more test coverage though but that could be follow-up.

Yes but i think it does rewrite the line completely and thus would erase the AS qualifier

@simonferquel No, it only rewrites the part matched by regexp. https://github.com/docker/docker/blob/master/cli/command/image/build.go#L394

@simonferquel any update ?
LGTM 👍

LGTM, I'd like to have a content-trust enabled test to make sure any code change there won't break the FROM foo AS bar syntax tough (even if current implementation is correct, having a test ensuring it remains this way feels good to me)

A testcase was added for trusted build case.

@tonistiigi Is it possible to build specific image with cli argument? Something like:
docker build -t sheerun/app_runtime:latest -i foo .

Where -i foo is the name of named in image from Dockerfile like in from build-essential as foo

@sheerun Not yet, there is a proposal for it in #32104

My negative vote for stage names concerns the harmful coupling it encourages when used with COPY --from.  However, it's ability to create an inline image definition is a worthwhile feature.
I've a few questions regarding this feature's implementation:

Can more than one AS be specified in a Dockerfile with the same name?  Since AS implements a defined precedence mechanism, favoring stage names local to the current Dockerfile over image names visible to the Engine, does similar behavior apply to duplicate stage names within a Dockerfile?
One reason for supporting multiple stages with the same name is the ability to "dynamically" rebind behavior within a Dockerfile, which is exactly the same reason for preferring Dockerfile stage names over Engine visible image names.

Can stage names include a tag or be specified as an image ID?

Is there a documentation effort to inform developers regarding the effects of stage name precedence and the ability to purposely/unintentionally craft a Dockerfile to "replace" an existing image via the --target option?

Can more than one AS be specified in a Dockerfile with the same name?

No, you can't have 2 stages with same name. The order of the stages will become irrelevant in the future, the names are only for defining what stage depends on another stage. The execution order will be based on these dependencies not based on the instruction order in Dockerfile.

Can stage names include a tag or be specified as an image ID?

In --from you can use tags and image IDs. Image IDs are discouraged as that means the target can't be pulled. For build stage names you can only use regular names. These names are only local identifiers while the builder runs, not to be confused with tags.

Is there a documentation effort to inform developers regarding the effects of stage name precedence and the ability to purposely/unintentionally craft a Dockerfile to "replace" an existing image via the --target option?

Indeed, it seems that we forgot to document --target https://github.com/moby/moby/issues/33143 . Not sure I understand the "replace" part though.

For build stage names you can only use regular names. These names are only local identifiers while the builder runs, not to be confused with tags.

Therefore, the algorithm resolving --from name references assumes the tag of :latest when a matching stage name cannot be found within the Dockerfile and the format of the reference is a simple name - not an  ID/name:tag.
Ex:
FROM scratch
# since 'image_name' isn't a stage name, then 'image_name:latest'
# is used to search for an Engine visible image.
COPY --from image_name /bin /bin

If the above understanding is correct, then it seems the resolution algorithm limited itself to overriding only images assigned the :latest tag but not other tag values.  In other words, if "image_name" above existed as a stage and "image_name:lastest" existed before running the Dockerfile, the resolution algorithm would have selected the image definition associated to the stage.
Ex:
# image called "image_name:latest" exists in registry local to the Engine.
FROM alpine AS image_name
FROM scratch
# since 'image_name' stage name exists, then the alpine image definition
# is used instead of Engine visible image called 'image_name:latest'
COPY --from image_name /bin /bin

Again, if the above correctly describes the behavior of resolving names, then why limit the ability to override an image with an inline definition to only :lastest?

Not sure I understand the "replace" part though.

From what I could glean from its description and associated thread, I though
docker build --target=my_stage_name .

would produce an image with the name "my_stage_name:lastest",  if "my_stage_name" existed as a stage name in the Dockerfile.  If so, then change "my_stage_name" to "alpine" which essentially replaces the Engine  copy of "alpine:latest" with the image generated from the definition located within the Dockerfile and associated to the "alpine" stage name.
I'm neutral to --target  because, if the above understanding is correct, it can induce chaos into the build system, as encapsulated build processes can escape their Dockerfile isolation and affect other other unrelated builds.

It is best practice to always use a tag with an image name, even if you want latest, COPY --from image_name:latest works. The default-to-latest has to remain for backwards compatibility, but if anyone is concerned about it, they can be explicit about the tag. : is not valid in a stage name, so there isn't any ambiguity.

would produce an image with the name "my_stage_name:lastest"

Nope, stage names are not image tags. They only exist within the context of a Dockerfile and are not persisted anywhere.

@dnephin
Thanks for clarifying --target via your example.
Concerning my question:

why limit the ability to override an image with an inline definition to only :lastest?

your reply:

It is best practice to always use a tag with an image name, ...

For me, the reason boils down to a stage can only override the behavior of an image tagged with :latest due to the Docker convention that assumes :latest when processing an image name devoid of a tag.  Therefore, the ability to override an external image definition, whose name is tagged with :latest, within a Dockerfile is an artifact of convention and not a generally desired behavior.
I find this ability to override an existing image definition, external to the Dockerfile, potentially useful, as one could perhaps test the behavior of a new version of an external image by coding it internally within the Dockerfile and specifying a stage name that matches the external image name.   It may still prove useful even when limited to external images tagged with :latest

Build stages are not about overriding image names. They are about providing a local name for a stage.
If you really want to override an image with a tag, you can always create a "single instruction build stage" for it:
FROM alpine:3.5 as my_stage_name

FROM somethingelse
...
COPY --from=my_stage_name


Node does not catch up, bps too low

To be clear, the bps is not always zero, it may be 0.10 or 0.20, but the number in (brackets) goes up - the node will NEVER catchup.
You may need to put the latests nearcore on your image, or it may be something else, don't know.
Feb 14 21:10:47 sdock docker-compose[3351132]: mainnet_nearcore | Feb 14 21:10:47.829  INFO stats: #59157781 Downloading blocks 99.25% (373649)  30/30/40 peers ⬇ 404.2kiB/s ⬆ 226.7kiB/s 0.00 bps 0 gas/s CPU: 13%, Mem: 6.3 GiB

The image is within last 24 hours, machine is 1Gbps, 32 core, 256GB ram, NVMe disks - real fast hardware.

Same problem here, dont know how to fix it.

Latest nearcore is always shipped, potentially refetch the docker images to make sure.
Apart from that the low bps is a common issue on the near network and is usually resolved by restarting the node with some pause - and re-downloading the snapshot if the gap becomes too big.

I will try that shortly On 17 Feb 2022 10:31, Jonathan Logan @.***> wrote:
Latest nearcore is always shipped, potentially refetch the docker images to make sure.
Apart from that the low bps is a common issue on the near network and is usually resolved by restarting the node with some pause - and re-downloading the snapshot if the gap becomes too big.
—Reply to this email directly, view it on GitHub, or unsubscribe.Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you authored the thread.Message ID: @.***>

I took it all from the top today, and it seems to all be working.


Dark theme

I switched to dark theme in Windows 10. Google Chrome displays with the dark theme, Google Chrome Debugger also displays with the dark theme. Will it be possible also for Browser Preview to have a dark theme?
In the screenshot bellow it can be seen that the address bar is a little to aggressive with the white color. Also when refreshing the background is white for a moment. A setting somewhere, I'll be happy, if possible.

Great idea. Should be easy to land some CSS tweaks in https://github.com/auchenberg/vscode-browser-preview/blob/master/src/components/toolbar/toolbar.css

Thinking about it, probably a better idea would be to inherit the colors from the current VS Code theme .
Looks like these three are the best candidates to import the colors from: input.background , input.foreground, input.border
Then something like this will also update the Browser Preview colors:
"workbench.colorCustomizations": {
    "[current theme]": {
       "input.background": "black",
       "input.foreground": "white",
       "input.border": "gray"
    }

VS Code colors are available as CSS variables, so this should be quite easy to add. https://code.visualstudio.com/api/extension-guides/webview#theming-webview-content

It looks like this four will do the job: input.background , input.foreground, input.border, panel.background

That much I could do:

I played around in build/static/css/main....css. I could't change the white background and the buttons color
.toolbar{
    background:var(--vscode-panel-background)
}
button{
    color:var(--vscode-input-foreground)
}
.urlbar{
    background:var(--vscode-input-background);
    border:1px solid var(--vscode-input-border);
    color:var(--vscode-input-foreground)
}
.urlbar input{
    color:var(--vscode-input-foreground);
    background-color:var(--vscode-input-background)
}
.viewport{
    background:var(--vscode-panel-background)
}

I know there are also some hovers, active, context menu, responsive panel I didn't touch.

Can I claim this?

I'm not sure what claiming means, but from my part sure.

I got almost everything working except for the viewport is not inheriting my dark color. Any thoughts on what I could do here?

what about the page contents? I use Dark Reader Chrome extension, possible to load it in the headless chrome?

@auchenberg
Still open to a PR for this?
I have it mostly working so far:
https://user-images.githubusercontent.com/10906415/134795375-52bea0ce-5a95-4ae4-a111-8ec7e207d221.mp4

Had to decode the SVG URLs & set them up as <svg> elements so I could utilize fill="currentColor".
Still needs a bit of work, especially for light themes, gotta look into detecting whether the current theme is dark or light. I'm using filter & backdrop-filter to generate a few more color options since the panel variables are limited, and it's currently optimized for dark themes, as is evident in the video.
Might also be useful to expose a few settings for tweaking filters & maybe even which CSS variables to use, since theme implementations have a pretty high degree of variance in brightness/contrast and it might be tricky to find a static implementation that works for all of them.

@Enteleform See https://github.com/auchenberg/vscode-browser-preview/issues/219


RustOpaque - wrong parameter type for generated dcoDecode method [Bug]

Describe the bug
Hi!
The dcoDecode method generated for a class that inherits from RustOpaque has the type (dynamic) of its "wire" parameter that does not match the type (list) of the parent class's method.

Codegen logs with RUST_LOG=debug environment variable
I can't copy-paste :
Comment is too long (maximum is 65536 characters)

To Reproduce
No response
Expected behavior
No response
Generated binding code
No response
OS
windows 11
Version of flutter_rust_bridge_codegen
flutter_rust_bridge`@ 2.0.0-dev.4
Flutter info
No response
Version of clang++
No response
Version of ffigen
No response
Additional context
No response

Hi, I guess this is because you are using a stronger linter?
But anyway, this is easily fixable, I will work on it in the next batch.


what are the breaking changes in 3.0?

Looking for release notes but failing to find them so far; apologies if I'm missing something obvious.
Edit: took note of "Add Link token options to initialization and move onEvent types to their own interface." in the changelog but not 100% clear on what, if anything, will need to change in consuming code.

hi @RwwL, usage of the public_key is in the process of being deprecated in v3. You library should continue to function as normal if previously using it.


More advanced label checks

Codecov Report
Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (19b966b) 94.41% compared to head (38b55f5) 94.41%.

Files
Patch %
Lines

internal/config/rule.go
40.00%
4 Missing and 2 partials :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #815      +/-   ##
==========================================
- Coverage   94.41%   94.41%   -0.01%
==========================================
  Files          93       93
  Lines        9925    10029     +104
==========================================
+ Hits         9371     9469      +98
- Misses        418      422       +4
- Partials      136      138       +2

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Unable to launch on Mac

I'm trying to use the agent on a simple Java app on my Mac. It fails on startup with the following:
objc[85996]: Class JavaLaunchHelper is implemented in both /Library/Java/JavaVirtualMachines/jdk1.8.0_102.jdk/Contents/Home/bin/java (0x1047a54c0) and /Library/Java/JavaVirtualMachines/jdk1.8.0_102.jdk/Contents/Home/jre/lib/libinstrument.dylib (0x10486d4e0). One of the two will be used. Which one is undefined.
Javametrics: Unable to start javaagent: java.lang.NoClassDefFoundError: org/objectweb/asm/ClassVisitor
java.lang.NoClassDefFoundError: org/objectweb/asm/ClassVisitor
at java.lang.Class.getDeclaredConstructors0(Native Method)
at java.lang.Class.privateGetDeclaredConstructors(Class.java:2671)
at java.lang.Class.getConstructor0(Class.java:3075)
at java.lang.Class.newInstance(Class.java:412)
at com.ibm.javametrics.instrument.Agent.premain(Agent.java:99)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at sun.instrument.InstrumentationImpl.loadClassAndStartAgent(InstrumentationImpl.java:386)
at sun.instrument.InstrumentationImpl.loadClassAndCallPremain(InstrumentationImpl.java:401)
Caused by: java.lang.ClassNotFoundException: org.objectweb.asm.ClassVisitor
at java.net.URLClassLoader.findClass(URLClassLoader.java:381)
at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
at com.ibm.javametrics.instrument.Agent$1.loadClass(Agent.java:93)
... 11 more

@tobespc @robbinspg @sjanuary
please could one of you take an urgent look at this, and get back to Tim, ASAP

@deboer-tim you don't have all the files you need.  The agent needs the asm directory with files in underneath the directory where you have the javametrics-agent in.  How are you installing this ?

I've amended the README.md file to make this a bit clearer
NOTE, if you move the javametrics-agent to another directory you need to make sure you take the asm folder with it. The asm folder is required for the agent to run as it contains files that the agent needs

IMHO most people will just want to download and use metrics, not clone git, do a build, run tests, and then copy the release out to use it. If I follow the Installation instructions or go directly to the release page (https://github.com/runtimetools/javametrics/releases), there's no mention of the asm dependency, how to get it, or where to put it relative to the agent.
Personally I'd prefer to see the release changed to a single archive that has two folders (agent and client/webapp) that contain everything you need (e.g. asm folder), or two archives. Barring that, the page should at least list the dependency on asm, have a link to download the jars, and instructions on where they need to go.

@deboer-tim I agree Tim, will make those changes

https://github.com/RuntimeTools/javametrics/pull/63 creates the new release zip that includes asm etc.


[Runtime Bug]: Max Payne 2 No Longer Hooks

Describe the bug
It looks like Max Payne 2 recently stopped hooking with RTX-Remix.
How do you reproduce the bug?
Install dxwrapper with d3d8 enabled, configure like so, and launch game. Game launches, but remix doesn't hook.

What is the expected behavior?
It looks like Darko9.13 had it running in Discord just a few months ago, but it recently stopped hooking. They state that it hooks with Portal RTX, but I haven't had such luck. I tried deleting the d3d9to8 that now comes with Remix, but that also didn't work.
Version
d42dbe6
Logs
D3D9.log
NvRemixBridge.log
dxwrapper-maxpayne2.log
Crash dumps
No response
Media
No response

REMIX-3324 for tracking

@skurtyyskirts  Did you rename d3d8tod3d9.dll to just d3d8.dll? Cuz wrapper is disabled by default these days.

Yes, renamed it to d3d8.dll, also tried other wrappers but no dice for me. Very strange, never had this issue before. Been at it for awhile, not sure what it could be.

Yes, renamed it to d3d8.dll, also tried other wrappers but no dice for me. Very strange, never had this issue before. Been at it for awhile, not sure what it could be.

Could be because of the recent DXVK and Bridge updates... There was a lot of issues for MP1 with those, so I reverted back to older ones. If you want, you could test the ones I'm currently using, I'll attach them to this post.
DXVK_Bridge_latest_working_versions.7z.001.zip
DXVK_Bridge_latest_working_versions.7z.002.zip
Just remove the ".zip" part of the filenames to extract. Also, make sure to delete any existing files related to remix, dxvk and bridge from your MP2 folder. Good luck bud!

@PappaSlask I'm unable to extract the provide files. Do you know if there's a commit that broke it?

Hi PapaSlask! Thanks for sending those over. I too unfortunately am having issues extracting them. I made sure to remove the .zip extension (making sure I had extensions enabled) and right clicked, and used winrar to open the achieve, but received this error message.

On the Windows Defender possibility, I went ahead and looked under Protection History and looked to see if maybe it was quarantined or removed, but it looks like no recent history was listed. I performed a regular boot with remix installed, so no Windows Defender protection history, (reinstalled remix just incase) and performed a boot of MP2 with Remix installed with Defender off, and still no hook unfortunately.
Here's my folder structure of MP2, along with my dxwraper.ini

@skurtyyskirts Hi Skurty!
Sorry for the inconvenience and thanks for getting back to me regarding this! Also thanks for the update regarding the extraction issue. I think I have nailed down what the problem was all along: You need to have 7zip installed in order to extract these archive files, since they were created with that program to begin with. So kindly install 7zip (it's tons better than winrar anyway lol) and try the extraction process once again. Remember that you need to right click on the 001 file and go to the 7zip context menu to choose Unpack to for this to work.
Thanks for your patience! Also, your MP2 file structure and files look all fine to me. But I want to rise a concern regarding the Steam versions of MP1 and MP2 and the latest (and possible even a few updates prior to latest) dxvk/bridge versions! A recent member on our team had issues getting MP1 working with the steam version, and he first used the Remix auto-downloader. But after helping him troubleshooting, I decided to let him try my older version, so I sent them to him and kabom it worked just fine.
So my early conclusion is that there's a compatibility issue with the recent dxvk/bridge versions AND steam version of these games, though it could be possible that the same is true for ALL copies of these games and not exclusive to the Steam version. I haven't tried the updated dxvk/bridge files myself (I'm using retail-cd version) So I can't confirm that.

Thanks PappaFlask! I was able to get that remix version you sent over unachieved, but still no dice. I've tried using dxwrapper, crosire's d3d8to9, but still no hook. I've disabled nvidia's display overlay, disabled steam overlay, unplugged my second monitor, downloaded the dx9 runtime files on the MP1 demo, disabling full-screen optimizations, started with shortcut launch options of -skipstartup -window -developer -developerkeys, checked my windows protection history if there were any quarantines but the history was clean. Made an exception rule to exclude MP2 directory, but still no hook. I'm completely stumped, I've never seen this before, been using Remix for almost a year now and have never seen anything like this.
Maybe it has something to do with the steam version?

Did a clean install of Max Payne 2, ditched the dxwrapper and used crosire/d3d8to9 wrapper using Remix 0.4 and 0.4.1 but still no hook. I'm not sure if this is a regression issue, I'm confused why the hook isn't happening and if this is maybe something to do with steam or not.
D3D9.log

Tried Remix 0.3 on the Max Payne 2 Demo, no luck either.
D3D9.log

@skurtyyskirts , @NV-DM , @NV-LL
I've found the problem, and a solution! After digging deeper into this issue, I found that it boils down to the d3d8.dll and the Dx8toDx9 conversion. Since about the release of Remix Runtime 0.5.0, a d3d8to9 wrapper is included in the installation files. This particular wrapper is Crosire's own wrapper (the guy behind the SweetFX and Reshade software) and is named d3d8.dll and is about 121kb in size.
This file, this wrapper mentioned above isn't needed at all for any of the Max Payne games! Instead, we should use the wrapper that comes with the Definitive Fixes patch. Among its files, there's a d3d8.dll which weighs in at roughly 2.1Mb. We should take this file, rename it into dinput.dll, then do either of these 3 following things:

Make a copy of the dinput.dll and rename it into d3d8.dll
Rename Remix's d3d8to9.dll to d3d8.dll
Use Crosire's wrapper (already named d3d8.dll)

Just to avoid any confusion, these .dll files should be in the root game dir, where there game executable is.
#Final notes: You might, or might not need to enable or disable LoadPlugins and UseD3D8to9 inside global.ini from the scripts folder that comes with the definitive fix. I haven't tested the latest version of the Definitive fix, but I do know they made some big changes to it, though I have no reason to believe they've removed or changed the wrapper.
 I would've never had thought to try that after trying everything else under the sun haha. It's back up and running! I'm ok with closing the ticket, but want to make sure Nvidia has a chance to jot anything down/take not of anything.


Add Romanian as an accepted locale for Mozillians

In mozillians/settings/base.py: added 'ro' to PROD_LANGUAGES accepted locales

Hey @Jobava
Thank you for the contribution. Closing this PR after #1203.
:rocket:


Remove logging guard

based on answers and comments on this stackoverflow question we are removing all logging guards from the library.

Fixed by #44


Make initialization of ShaderGlobals C++ compliant

ShaderGlobals aggregates several non POD types, GCC warns when these
are initialized using memset:
error: ‘void* memset(void*, int, size_t)’ clearing an object of type
‘struct OSL_v1_11::ShaderGlobals’ with no trivial copy-assignment;
use assignment or value-initialization instead [-Werror=class-memaccess]
memset (&sg, 0, sizeof(ShaderGlobals));
Use value-initilization instead.
Fix for #964.
Description
See #964
Tests

Checklist:

[x] I have read the contribution guidelines.
[ ] I have previously submitted a Contributor License Agreement.
[ ] I have updated the documentation, if applicable.
[ ] I have ensured that the change is tested somewhere in the testsuite (adding new test cases if necessary).
[x] My code follows the prevailing code style of this project.

We haven't seen an update about this PR for many weeks. There's an outstanding question about whether it's correct (i.e. will zero out all fields versus leaving them uninitialized), and as well I'm unable to merge into this repository without receiving a CLA from you and/or your organization.

Months have gone by without update, response, or CLA. Closing. Please resubmit if this is important to anybody.


Allow to  disable jemalloc when compiling

Allow to run the CI with jemalloc, but I think we should only run it manually labelled with run ci without jemalloc like the current PR. HDYT @ShooterIT

Allow to run the CI with jemalloc, but I think we should only run it manually labelled with run ci without jemalloc like the current PR. HDYT @ShooterIT

I think we can add this job into kvrocks.yaml since all jobs can run in parallel, this can't bring extra much time.

@ShooterIT We take the job into the single file since we want to run it when the PR was labelled, and other jobs should be always running.


Notification/Indication

Hello, guyz! Another question
How to subscribe on client side to characteristic notification/indication from gatt server?
We tried add descriptor for characteristic, updated UUID of descriptor to 0x2902
and still no calls from any callbacks in client

Is it working now @kcn1-71 ?


Remove disabling of link text decoration

Styling links only through color and removing their default underline
is an accessibility concern for people with color blindness. It's
possible they would not be able to discern the difference between
regular text and a link.
This commit also sets the text-decoration-skip property to ink for
all links, which only draws text decoration where it does not touch or
closely approach a glyph.
text-decoration-skip is support in most browsers with a prefix, excluding IE & Edge: http://caniuse.com/#feat=text-decoration

like


Mitigate nuget changes for update batch

This is now needed for all github actions

If this action will be available in main, this change should be included there as well