Prepare extract_messages to return translator comments.

Part of #63.

This needs a little rebase before it can be tested and merged.

Sounds good!  I'll sync soon; I plan to do a rebase on top of dalance's work soon, since it looks like they're further along.

I believe this is close to ready.  Is there anything I've missed before I flatten the history?

My deep apologies for leaving this to wither.  I was sick again for the past week or two, so was unable to work on this for a very long time.
Let me page this back into my memory this week and prepare this for review once more.

Codecov Report
Attention: 34 lines in your changes are missing coverage. Please review.

Comparison is base (3012f1d) 89.55% compared to head (8b772ed) 89.11%.

Files
Patch %
Lines

i18n-helpers/src/lib.rs
83.66%
27 Missing and 6 partials :warning:

i18n-helpers/src/normalize.rs
88.88%
1 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #107      +/-   ##
==========================================
- Coverage   89.55%   89.11%   -0.45%
==========================================
  Files          12       12
  Lines        2442     2618     +176
  Branches     2442     2618     +176
==========================================
+ Hits         2187     2333     +146
- Misses        190      215      +25
- Partials       65       70       +5

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

I merged this now so we can start building on top of it — thanks @dyoo for sticking with it! Perhaps you can send out some small PRs with any follow up changes?


Cannot run interest_evolution_simulation_demo.py

I am trying to run interest_evolution_simulation_demo.py to test my installation.
I am getting a bunch of warnings and no results are popping up from running the demo.
I am guessing this is due to tensorflow version, but not sure.
prompt from running interest_evolution_simulation_demo.py
UserWarning: NumPy backend for Edward2 is not available.
  warnings.warn("NumPy backend for Edward2 is not available.")
  2022-03-16 22:10:35.450846: W tensorflow/python/util/util.cc:368] Sets are not currently considered sequences, but this may change in the future, so consider avoiding using them.
WARNING:tensorflow:AutoGraph could not transform <bound method IteratedMultinomialLogitChoiceModel.choice of <recsim_ng.entities.choice_models.selectors.IteratedMultinomialLogitChoiceModel object at 0x7f985178ddf0>> and will run it as-is.
Cause: generators are not supported
To silence this warning, decorate the function with @tf.autograph.experimental.do_not_convert
W0316 22:10:37.136438<PHONE_NUMBER>13824 ag_logging.py:142] AutoGraph could not transform <bound method IteratedMultinomialLogitChoiceModel.choice of <recsim_ng.entities.choice_models.selectors.IteratedMultinomialLogitChoiceModel object at 0x7f985178ddf0>> and will run it as-is.
Cause: generators are not supported
To silence this warning, decorate the function with @tf.autograph.experimental.do_not_convert
2022-03-16 22:10:42.510012: W tensorflow/core/grappler/costs/op_level_cost_estimator.cc:690] Error in PredictCost() for the op: op: "Softmax" attr { key: "T" value { type: DT_FLOAT } } inputs { dtype: DT_FLOAT shape { unknown_rank: true } } device { type: "CPU" vendor: "AuthenticAMD" model: "241" frequency: 2500 num_cores: 128 environment { key: "cpu_instruction_set" value: "AVX SSE, SSE2, SSE3, SSSE3, SSE4.1, SSE4.2" } environment { key: "eigen" value: "3.4.90" } l1_cache_size: 32768 l2_cache_size: 524288 l3_cache_size: 134217728 memory_size: 268435456 } outputs { dtype: DT_FLOAT shape { unknown_rank: true } }
2022-03-16 22:10:42.510178: W tensorflow/core/grappler/costs/op_level_cost_estimator.cc:690] Error in PredictCost() for the op: op: "Softmax" attr { key: "T" value { type: DT_FLOAT } } inputs { dtype: DT_FLOAT shape { unknown_rank: true } } device { type: "CPU" vendor: "AuthenticAMD" model: "241" frequency: 2500 num_cores: 128 environment { key: "cpu_instruction_set" value: "AVX SSE, SSE2, SSE3, SSSE3, SSE4.1, SSE4.2" } environment { key: "eigen" value: "3.4.90" } l1_cache_size: 32768 l2_cache_size: 524288 l3_cache_size: 134217728 memory_size: 268435456 } outputs { dtype: DT_FLOAT shape { unknown_rank: true } }

Below are the packages installed
absl-py                      0.15.0
astunparse                   1.6.3
cachetools                   4.2.4
certifi                      2021.10.8
charset-normalizer           2.0.12
clang                        5.0
cloudpickle                  2.0.0
cycler                       0.11.0
decorator                    5.1.1
dm-tree                      0.1.6
edward2                      0.0.2
flatbuffers                  1.12
fonttools                    4.30.0
gast                         0.4.0
gin-config                   0.5.0
google-auth                  1.35.0
google-auth-oauthlib         0.4.6
google-pasta                 0.2.0
grpcio                       1.44.0
gym                          0.23.1
gym-notices                  0.0.6
h5py                         3.1.0
idna                         3.3
importlib-metadata           4.11.3
keras                        2.8.0
Keras-Preprocessing          1.1.2
kiwisolver                   1.4.0
libclang                     13.0.0
Markdown                     3.3.6
matplotlib                   3.5.1
numpy                        1.22.3
oauthlib                     3.2.0
opt-einsum                   3.3.0
packaging                    21.3
Pillow                       9.0.1
pip                          21.2.4
protobuf                     3.19.4
pyasn1                       0.4.8
pyasn1-modules               0.2.8
pyparsing                    3.0.7
python-dateutil              2.8.2
recsim-ng                    0.1.1
requests                     2.27.1
requests-oauthlib            1.3.1
rsa                          4.8
setuptools                   58.0.4
six                          1.15.0
tensorboard                  2.8.0
tensorboard-data-server      0.6.1
tensorboard-plugin-wit       1.8.1
tensorflow                   2.8.0
tensorflow-estimator         2.7.0
tensorflow-io-gcs-filesystem 0.24.0
tensorflow-probability       0.16.0
termcolor                    1.1.0
tf-estimator-nightly         2.8.0.dev2021122109
typing-extensions            <IP_ADDRESS>
urllib3                      1.26.8
Werkzeug                     2.0.3
wheel                        0.37.1
wrapt                        1.12.1
zipp                         3.7.0

Hey,
sorry for the late reply, I somehow missed this in my email stack. Looking through the code of the demo, it may be the case that it's just not supposed to print anything on the console. I think these particular warnings are harmless, and the error is unrelated. Could you try changing line 108 in interest_evolution_simulation_demo.py
from
train_step()

to
_, _, reward = train_step()
print(reward)

and see what happens?

Thank you for the reply. I can see the reward going up by changing the code as you mentioned.
I am trying to implement off-policy algorithm such as slateq and dqn. Do you have any plans to add more agents to this environment? Also, I wonder if I would have to change the whole CollabFilteringRecommender to implement off-policy algorithms or just changing interest_evolution_simulation is sufficient. I would appreciate your tips on this.

I am also curious why REINFORCE is not working in Interest Evolution Environment for num_users=2, num_topics=2, num_docs=10, history_length=15.


[BUG] Cannot find name 'SpeechRecognition'

🐞 Bug report
Description
Can't start my Angular (v15) app due to unknown type 'SpeechRecognition'
Versions

Angular 15

Additional context

This should be probably work with the new version: 3.0.4. Please give it a try and inform us of any issues or feedback you have.

I have the same problem but angular version 17. any solution?

Version:
"@ng-web-apis/common": "^3.0.6",
"@ng-web-apis/speech": "^3.0.7",
"@angular/common": "17.0.2",
"@angular/compiler": "17.0.2",
"@angular/core": "17.0.2",


python311Packages.django-anymail: 10.2 -> 10.3

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python311Packages.django-anymail is: Django email backends and webhooks for Mailgun
meta.homepage for python311Packages.django-anymail is: https://github.com/anymail/django-anymail
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 10.3 with grep in /nix/store/ln1bicmqbsk1yqavfvmhgk67rw885hd3-python3.11-django-anymail-10.3
found 10.3 in filename of file in /nix/store/ln1bicmqbsk1yqavfvmhgk67rw885hd3-python3.11-django-anymail-10.3

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath
python311Packages.django-anymail
python312Packages.django-anymail

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/ln1bicmqbsk1yqavfvmhgk67rw885hd3-python3.11-django-anymail-10.3 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python311Packages.django-anymail https://github.com/r-ryantm/nixpkgs/archive/af84f918694dcc23da511231efb983ece6d75918.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/af84f918694dcc23da511231efb983ece6d75918#python311Packages.django-anymail

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/ln1bicmqbsk1yqavfvmhgk67rw885hd3-python3.11-django-anymail-10.3
ls -la /nix/store/ln1bicmqbsk1yqavfvmhgk67rw885hd3-python3.11-django-anymail-10.3/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

4 packages built:

python311Packages.django-anymail
python311Packages.django-anymail.dist
python312Packages.django-anymail
python312Packages.django-anymail.dist

Maintainer pings
cc @onny for testing.

Result of nixpkgs-review pr 297207 run on x86_64-linux 1

4 packages built:

python311Packages.django-anymail
python311Packages.django-anymail.dist
python312Packages.django-anymail
python312Packages.django-anymail.dist


nginx config suggestion for redis page cache (and the future)

When you create a site with ee using the redis page cache, the files common/redis*.conf create a $key macro for writing to the redis cache that includes the hard coded prefix nginx-cache:. That string corresponds with the default value in the nginx-helper settings for redis page caching:

That causes the problem on a host that handles many different domains that when you use the nginx-helper's "purge cache" option, you not only purge the page cache for the site you are working with, you purge the entire page cache for every site that uses the default nginx-cache: prefix string.
If you want to change the prefix in the plugin settings on a domain by domain basis so that you can purge the page cache for one domain at a time, you also have to make the corresponding edit in the common/redis*.conf file that you are using and that is a file that an ee update will overwrite and hose your modification.
I suggest making the following changes in ee:

in the common/redis*.conf files, instead of hard-coding the string nginx-cache:, use a macro like this:
set $key "$redis_prefix$scheme$request_method$host$request_uri";

in the sites-available vhost config for a given site, define that macro initially like this:
set $redis_prefix nginx-cache:; # if changed, also change in nginx-helper settings

Then you can change the $redis-prefix string in the vhost config and in nginx-helper and successfully separate the page caching from one vhost to another. I have tested this and it works as expected.
It would also be good to put some documentation in the nginx-helper plugin about the necessary nginx configuration to make use of the Prefix setting.

Tangentially, I have been thinking a lot about how to make it possible to customize various nginx configurations while staying compatible with ee updates and it seems to me that the approach detailed above, where you define a macro in the vhost configuration file under sites-available and then use that macro in the common/*.conf files that are over-written on an ee update might be a workable pattern.
What I have been doing in the mean time is creating my own custom directory next to common and then copying the files I want to modify from common to custom and then in my vhost configs, I change the include path from common/*.conf to custom/*.conf. This obviously gets me out of sync with ee updates and will force me to manage stuff by hand in the future as files under common change with ee updates.
Would be a lot nicer if nginx let us do conditional includes so that we could instead override the common/*.conf files by putting like-named files with customized fragments under the /var/www/vhost/conf/nginx/ path, but unfortunately nginx's configuration system does not allow this.

crickets, really?

I would recommend sending in a Pull Request. I had a Redis related change regarding cache type and it was merged in a few days.

Implementing this idea even in the specific use-case I outlined above would be a significant project. Including maintaining backward compatibility for those with existing ee installs makes it critical to get it right. So I think this has to be a job for core ee developers who know the future roadmap well to take on. I'm just suggesting one possible approach for the future.
Any thoughts on this idea, @rahul286 ?

i'll reiterate this suggestion and say that i have been using it in production since the OP above almost two years ago and it works fine. I can host multiple sites on a given server, give each one their own page cache $redis_prefix and flush them from the cache independently of each other.

@pjv wondering if this will be relevant in EE v4.
Each site will have its own redis container. So prefix collision wont happen.
I am closing this issue for now. Happy to reopen and look further into it, if I missed something.

@rahul286 that sounds like an interesting plan. I wonder from a resource usage point of view what it will cost (memory-wise, mostly) to have multiple redis containers running simultaneously vs. a single redis instance that is used by all sites hosted on a server.
if the overhead of running a redis container per site is not too burdensome, then it would definitely make my hack unnecessary and simplify things a lot, so great.


Karma auto install socket.io 1.4.8 it makes ie9 can not run karma test.

Expected behavior
can run karma test in IE9
Actual behavior
can not run karma test in IE9. only if I lock socket.io version to 1.4.6, it can work.
Enviroment Details

Karma version (output of karma --version):
0.13.19
Relevant part of your karma.config.js file

Steps to reproduce the behaviour

Reason for this is the use of Uint8Array in the 1.4.8 release of socket.io-client, which isn't natively supported in IE9.

Yes #2188 shows that these failures happen. Looks like we need to add a shim for Uint8Array now

Ref https://github.com/socketio/engine.io/issues/407

Using this as a polyfill for socket-io 1.4.8 for IE9 seems to work


Credential not persisted to Vault for SercetService and this PR adds the necessary correction.

What change?

Okay, the titles got mixed up -- this one should say something about adding to .gitignore.
It adds *.nuget.targets and *nuget.props to the ignorables.
I have a number of PR's but held on to them as the project directories were changing.
Please merge this one as *.nuget.props are really annoying.


docs: add command documentation.

It seems that we have not mentioned anywhere how to use the bot. It should be good to add a section in the docs to show how to use the bot and if possible, add some screenshots.

HOW do we use this on our discord ? should I follow the steps under configuration under readme file ?

HOW do we use this on our discord ? should I follow the steps under configuration under readme file ?

Hi @capedCrusaderr, if you want to extend its feature and then use it, you should use the instructions under the README. If you just want to use it directly, you can follow this link to add it to your server.

If you are interested to work on this issue, not you will have to follow these guidelines https://docs.github.com/en/search-github/searching-on-github/searching-issues-and-pull-requests

@capedCrusaderr tell me if you need any help.

sure sure . let me first try and see how It works . then accordingly I will make a documentation .

Hey @antonio-pedro99 , i wanted to ask how should i draft the documentation , what should I include in it ?

Hey @antonio-pedro99 , i wanted to ask how should i draft the documentation , what should I include in it ?

I think you do not need to cover all the commands.
See, the commands are exactly equivalent to queries in GitHub, check it here: https://docs.github.com/en/search-github/searching-on-github/searching-issues-and-pull-requests
We only need the basics one, if the user wants more advanced thing, he can consult the above link.
Think about:
— how to search by programming language, organization, updated and created time, by labels (other than good first), by interactions, etc.
The current implementation is already checking for issues and if the issue is open.
Example of valid command is,
/svn language:Python owner:angolaosc
this would return all the issues(with good first issue label) from repositories where python is the predominant programming language, under angolaosc

thecapedcrusader5203 is my discord username , let's connect so that I can discuss regarding documentation.

thecapedcrusader5203 is my discord username , let's connect so that I can discuss regarding documentation.

I have sent an invitation.

Hey @antonio-pedro99

@KelvimImperial vamos iniciar com este #16

Hey @capedCrusaderr, any update on this?

Hey mate , i was just pushing the commit and there was some error, as the files were not tracked

Hey mate , i was just pushing the commit and there was some error, as the files were not tracked

Do you need any help?

I think git add <file you have changed> might do the trick

I committed the changes

hey @antonio-pedro99 , I am trouble finding about the commands regarding the bot . Please guide me out

Closed by #20


Offline language-server & debug adapter support/instruction

Motivation
I work with an offline system that I want to use this extension on. Since there is no direct internet connection, the current version (0.2.23) fails to download the Kotlin language server and debug adapter from Github. No further instruction is provided on how to manually find and install these two dependencies after the error message displays and none is provided in the README.md file.
It would improve the user experience if the extension somehow instructed the user (maybe in the error messages or through a pop-up) on how to manually obtain and install these dependencies when this situation occurs.
Calling out these dependencies and their manual installation process in the README.md file would also help limit the number of transfers over the air-gap.
Description

Either update the error messages displayed by VSCode or add some kind of pop-up with instructions on how to manually download and install the language server and debug adapter when the download fails.
Provide this instruction in the README.md file.

Alternatives considered
Just providing the instruction in the README.md would still be a major improvement for the situation that would not require any code changes.

Download the language server binary (e.g. from GitHub Releases) anywhere you like, then point the setting kotlin.languageServer.path to it.


Ask for "dct.txt" file

Running the 4_CreateLabels.py code raises a "No such file or directory: '0_Preprocessing/corpus/dct.txt'" error. I've downloaded the corpus from the link provided in your previous paper, but no such 'dct.txt' file is included in the corpus.
Would you include it (with the corpus itself) in the GitHub repo?

Hi,
thanks for pointing this out. I added dct.txt to this git repository.


Vue 3 support.

Hey, @alfonsobries  amazing project. Do you have any plans for Vue 3 support?

Yes, after I release v2 (very soon) I will start with the vue 3 version, I have no estimated date though


Very slow download from Github-Amazon AWs

Is it just me or everyone experiencing the same that all the download links in the site is painfully slow? You should provide mirrors for this instance.

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/27485087-very-slow-download-from-github-amazon-aws?utm_campaign=plugin&utm_content=tracker%2F164029&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F164029&utm_medium=issues&utm_source=github).

Hey Dante,
i'm sorry for the slow download speed, but for now the releases rely only on Githubs CDN.
I ditched uploading to SourceForge a while ago.
There was a user request for a mirror system before over at the mailing list.
I like the idea, but its not possible before issue #126 (installers need to be code-signed) is solved.
After that i could imagine to offer other download sources.
Maybe a simply rsync based mirror system or evan a torrent based distribution.
I'm open for suggestions in regard to cloud storage provides.
Firstly, it would be nice, if the service is  free, as i don't want to run into high costs for storage or bandwidth and secondly, it must be possible to automate the upload.
Maybe Mega or pCloud cloud fit.
If you know a good service, please keep me updated.
Regards, Jens

...or evan a torrent based distribution

:+1:

Ok, got a new suggestion for distribution: https://bintray.com/ - which is free for OSS.

Ok, i did some more research on tools for mirroring and CDN'ing.
The most important projects are MirrorBrain and MirrorBits:

http://mirrorbrain.org/ (Apache, PostgreSQL, mod_asn on server; rsync/http/ftp on client)
https://github.com/etix/mirrorbits (written in Go; behind VLC and XMBC/Kodi.tv)

Mirrorlist: http://mirrors.kodi.tv/addons/isengard/addons.xml?mirrorlist

Questions / Research:

Github Releases

is it possible to use Github Releases as the origin for the first mirror?
do i have to copy from Github Releases to server and then start mirroring?
is it possible to use Github Releases as the fallback source?

Torrent Support?
What about alternative download hosts like Bintray (Dropbox/Owncloud)?

Is it possible to use them as a mirror / can they be part of the mirror-list?

Requirements:

automatic filesize and hash checks on mirrored files
automatic disabling of mirror URLs with broken/invalid downloads


meta-security dunfell fails to produce FAPI files

HI All,
I have used meta-security as a layer and I intend to make use of the meta-tpm. I am able to build properly using yocto but I am not seeing FAPI related files when tpm-tss recipe is build. I can see that ESYS API and SAPI files are there in the build folder of tpm2-tss. So what is needed to generate FAPI files

Hey @kuldeepmarker-eaton,
NI doesn't actually use the meta-tpm sub-layer within meta-security in our NI LinuxRT builds. So we don't have expertise in how the tpm2-tss recipe within that layer is designed.
I see you opened a similar issue in meta-secure-core. Are you trying to integrate TPM2 user-space tools into an NI LinuxRT deployment, or into your own OE distribution? If the former, I'd be happy to talk about your use-case and get an understanding of your requirements.
Either way, you might want to open an issue with the meta-security upstream maintainers on the yocto mailing list<EMAIL_ADDRESS>It seems that the yocto project has expected the FAPI configuration switch for tpm2-tss to work at some point in the past.

HI @amstewart ,
Thanks for a quick reply. I am trying to integrate TPM2 user space tools into ST Openstlinux distro. And I want to use FAPI API to interact with TPM. I will create an issue regarding this.

Ah; I see. The yocto mailing list is probably your best bet for an answer then.
I'll go ahead and close this issue. Let me know if you have any objections.


Fix docs in JWTUserProviderInterface

Checklist
[x] I have read the Auth0 general contribution guidelines
[x] I have read the Auth0 Code of Conduct
[x] All existing and new tests complete without errors

Thank you for your contribution @dunglas 👍


Software Dev Course 4.9 Assignment

In workflow.py there seems to be a duplication of code

I had error installing the requirements, this might be my issue though. Would like to see if anyone else has a similar issue.

The deployment of workflow did not work. I got prefect deploy to work and show option. Maybe a version of Prefect is the issue? I am on version 3.0.11.
Some more explanation of what is happening here and what we are doing would also be nice.

Point students to AWS CLI to download.

Mabye include some picture to help with finding the access key part.

We should include some clarification about Prefect 2 vs. Prefect 3 (mostly just pointing it out and a link to the docs about (recent) Prefect 3 release). I'll leave the specific errors for Sissi to look at next week.
For the work pool, maybe worth pointing out the free Prefect managed work pool? This is what's typically used when someone is testing things out. Maybe we show how to use with Prefect managed work pool, and then provide links or an example of how to use an EC2 as a work pool?
Often, physics-based simulations can take on the order of minutes, hours, days, etc. It's good that the resource limitations are mentioned in that section, and worth pointing out the AWS Lambda is typically used for very quick to run items.


fixed load/users getting distributed to missing worker

fixed load/users getting distributed to the missing workers.
I am new to open source commit and python.
Please let me know if anything needs to be changed.
fixes #2008 #2010

Can you add a unit test? You can override/shorten the timeout in the tests to reduce the time they take by using pytests mock feature (there should be some examples among the tests)

It asserts to Count of active workers in dispatch.. Here the missing worker
should be removed after heartdead interval.. Added comment to code and
added more sensible message in assert
On Sat, 12 Feb, 2022, 19:46 Lars Holmberg, @.***> wrote:

@.**** commented on this pull request.
In locust/test/test_dispatch.py
https://github.com/locustio/locust/pull/2010#discussion_r805165583:

       weight = 1

   class User3(User):

       weight = 1

   user_classes = [User1, User2, User3]

   worker_nodes = [WorkerNode(str(i + 1)) for i in range(3)]

   worker_nodes[1].heartbeat = HEARTBEAT_DEAD - 1

   users_dispatcher = UsersDispatcher(worker_nodes=worker_nodes, user_classes=user_classes)

   users_dispatcher.new_dispatch(target_user_count=9, spawn_rate=3)

   users_dispatcher._wait_between_dispatch = 0

   users_dispatcher.prepare_rebalance()

   list(users_dispatcher)

what does this line do? :)
—
Reply to this email directly, view it on GitHub
https://github.com/locustio/locust/pull/2010#pullrequestreview-880859491,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJXIJ6SAZXB7U6XXLQS2LHLU2ZTUVANCNFSM5OFSJBIA
.
You are receiving this because you authored the thread.Message ID:
@.***>

Hi @radhakrishnaakamat, can you link this PR to the corresponding issue #2008?

Fixes #<2010> #<2008>

@mboutet thanks for the pointers in #2008, I was able to fix it in the right places in a better way.
@cyberw could you kindly review it once again, I have updated the tests and tox worked fine too. Thanks!!

👍👍


parsing variables/constants

Hi! I'm trying to pass and parse a constant from my proc_macro in order to get the value of that constant. This constant may be declared in another module, so it wouldn't work to parse as a syn::ItemConst
What I'm trying to do is something like this:
    pub const MY_CONST: &str = "MYCONST";

    #[my_macro(MY_CONST)]
    pub fn test() {
    }

Is there any way to do this? I've been looking for a way but no luck. Thank u in advance!

Closing as a duplicate of #963.

@dtolnay you closed the issue but there is no solution for this in the community. Could you provide a way to implement this?


make the error page component a public component useful for consumption

right now there is https://github.com/zeit/next.js/blob/ec2c8c6784aae680964a32ab7a5bc2b657e5cf98/pages/_error.js
it is the really pretty error page when a server-side error occurs
pretty much as error handling is super common, it would be nice if I could just do:
import React, {Component} from 'react'
import ErrorPage from 'next/error'

export default class SomePage extends Component {
	componentDidMount () {
		doSomething((error, result) => {
			this.setState({error, result})
		})
	}

	render () {
		const {error, result} = this.state || {}
		if ( error )  return <ErrorPage error={error} />
		return <div>{result ? `here is the result: ${result}` : 'waiting on the result'}</div>
	}
}

With error being a string, or an Error instance - if an error instance, message should be displayed, as well as the stack

Has been fixed a long time ago 😄


audit: check for version aliases.

Current version aliases should be provided for versioned formulae so people can brew install<EMAIL_ADDRESS>to provide pin-like behaviour.
If agreed, I'll add these for Homebrew/core before this is merged.

All comments addressed.

Note to self: this should probably also compute the actual alias so it can audit on e.g. a version bump happening but the alias not being updated.

Note to self: this should probably also compute the actual alias so it can audit on e.g. a version bump happening but the alias not being updated.

This is now done combined with a readall check to check that aliases don't shadow formulae names (i.e. in this case aliases are cleaned up when a new version is released and versioned formula added).


Replaces includes with _.indexOf

Closes #400

Any reason not to use the indexOf method of arrays? Goes back to the dawn times

Only because I didn't think of it.


Document how Open Humans links into the project platform

As a developer
I want a document to detail how the platform can work with Open Humans
So that I understand how the information is stored and retrieved.
Acceptance Criteria
Be able to login and log out
Store experience data information
Create an md file in the repository

Closing as implemented by @callummole and @helendduncan


fix: correct GitHub camel case

Signed-off-by: Jeremy Adams<EMAIL_ADDRESS>

@jpadams I enabled signoff from web-based commit for the org following your link. However to fix that one, you'll have to amend your commit from the CLI.


Map index documentation

Brief explanation of the name:value and the has_key:name
entries which are now possible in 5.1.

--no-rebase

Looks fine to me!

But for this to be really true, the LuceneQueryBuilder has to be modified to not remove the ':' in the search expressions. I'm just about to open a PR for that.


[Feature request] Highlight the selected filter item.

Platforms
Android, iOS
Description
It would be nice if we could highlight the selected filter item. Please add configuration options for border width and border color for it.

Why
No response

This is already possible with customWidgets as you can see in the WhatsApp-Example here. The design of the current WhatsApp filter button can you see here.

Thank you @hm21

Hi @hm21. I'm trying to use the default FilterEditor, but it doesn't work. Please help explain.
filterEditor: CustomWidgetsFilterEditor(
              appBar: (filterEditor, rebuildStream) => ReactiveCustomAppbar(
                stream: rebuildStream,
                builder: (_) => _appBarFilterEditor(filterEditor),
              ),
              filterButton: (
                  filter,
                  isSelected,
                  scaleFactor,
                  onSelectFilter,
                  editorImage,
                  filterKey,
                  ) {
                return WhatsAppFilterBtn(
                  filter: filter,
                  isSelected: isSelected,
                  onSelectFilter: () {
                    onSelectFilter.call();
                    editorKey.currentState?.setState(() {});
                  },
                  editorImage: editorImage,
                  filterKey: filterKey,
                  scaleFactor: scaleFactor,
                );
              },
            ),

Hi @hm21. Thank you so much. You are right. I'm using wrong editor.


Alt-tabbing between two clients should draw the cursor of the next one

It currently requires the user to move the pointer to let it get drawn by the next client.  Before doing so, the last cursor from the previous client continues to be displayed at its last location, even if it should otherwise be hidden.

The underlying problem should be, that the pointer focus and thus pointer.enter event is not emitted if z-order changes, but only on cursor movement.
I asume you have the pointer on an area covered by both clients? Otherwise I think the behaviour would be correct.

Correct, I mostly only use maximised clients.


[CS2103T-T11-2] Hall-y

Hall-y is a hall residents' contact management application. It helps to keep track and update the residents' record, so the hall admin staff can easily find the residents based on the saved records.

Codecov Report

Merging #75 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #75   +/-   ##
=========================================
  Coverage     72.31%   72.31%
  Complexity      400      400
=========================================
  Files            70       70
  Lines          1228     1228
  Branches        124      124
=========================================
  Hits            888      888
  Misses          308      308
  Partials         32       32

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6389d85...3b2e137. Read the comment docs.

Codecov Report

Merging #75 into master will decrease coverage by 4.17%.
The diff coverage is 8.33%.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6389d85...e1eaae1. Read the comment docs.


Transaction was not mined within 50 blocks, please make sure your transaction was properly sent. Be aware that it might still be mined!

Approve 能够正常完成
但是在Mint环节，报错误
Transaction was not mined within 50 blocks, please make sure your transaction was properly sent. Be aware that it might still be mined!

你好在吗？方便留个联系方式吗.我想请教一些问题


Add code coverage reports for Codacy

Noticed these were not being generated by Codacy, followed their documentation to add this to the test step of the action.
https://docs.codacy.com/coverage-reporter/
All it needs now is an API token added to the repo secrets, which I am not able to do. I used CODACY_API_TOKEN as the secret name, however I can change this if you would like it to be different.

I added the secret and reran the action, it still fails tho


bug(Tree): Mat Nested Tree node autofocus

Is this a regression?

[X] Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was
18.1.5
Description
Mat nested tree node is auto focused, with no way to disable it.
In a case where the tree is below the viewport, it causes the browser to scroll to the tree.
Reproduction
StackBlitz link: https://stackblitz.com/edit/ksjuw9?file=src%2Fexample%2Ftree-nested-overview-example.ts
Steps to reproduce:

Open StackBlitz
Wait 1 second for the data to load.
Notice that the page scrolled down to the tree component.

Expected Behavior
No autofocus, or provider a way to opt-out of the autofocus.
Actual Behavior
Tree is auto focused and there is no way to opt-out of autofocus.
Environment

Angular: 18.2.1
CDK/Material: 18.2.1
Browser(s): Chrome
Operating System (e.g. Windows, macOS, Ubuntu): macOs

Thanks for the fix, updated the package and it works!


Does S3Signer support IAM roles?

Hey,
For my local test machine I'm using an IAM user with accessKey and SecretKey, but for on EC2 we're using IAM roles.
Does the S3 object or, the S3Signer support IAM roles?

For the example above, something along those lines (assuming play2 support): https://gist.github.com/mellster2012/b4eea2ba0f3d33126d0e


Puppet Module for Search Guard

This is not an issue. I just want to know if the search-guard team has a puppet module. ElasticSearch has an official puppet module, and so does Shield.
Thank you

Thanks for you question. No, we do not have a Puppet module at the moment. Since there is not much request for it, this is not a top priority on our todo list either. But of course we highly appreciate any contributions from the community.

+1

+1

+1


Change mptt version dependency to be PEP440 compatible

Is this going to be released soon?

Is this going to be released soon?
:+1:

Any word on a 0.9.9 release with this change in it?

0.9.9 has been released!

Thanks so much @yakky

@yakky Could you add 0.9.9 to PyPI please? Thanks :)

@BertrandBordage sorry: the upload returned an error but I haven't found out until this morning. Will push it soon

@BertrandBordage @pipermerriam now released for real!

Thank you @yakky :D


Settings for showing thematic data using PostgREST

Hi!
By trying to connect thematic data to the objects shown in the web map client, I never see any information: just "Loading feature information ..."
I have created a role as well as user in postgresql who have access and reading rigths to the LoD2 schema and all tables. PostgREST seems to work, since I get all the information using a terminal.
The citygml-data was exported by the 3DCityDB Importer/Exporter as KML-files and is added 'successfully' from local storage as a layer in the web map client.
What information are needed to see thematic data in the web map client using PostgREST?
My - probably relevant - inputs look like this at the moment:
URL: http://localhost:8000/3dwebclient/xyz.kml
thematicDateUrl: http://localhost:3000/cityobject  - Which tables should I specify? Is it possible to state all tables? Do I have to enter curl, Invoke-RestMethod, etc.?
Thematic Data Source: PostgreSQL REST API
cityobjects.JsonUrl: http://localhost:8000/3dwebclient/zyx_MasterJSON.json
Thank you very much in advance!

Hi,
the thematicDataUrl should point to the your table or view that you'd like to expose, for example:
https://example.com:3000/<table_name>

This table or view must be structured either as a "horizontal" or a "vertical" table and must have the correct order of columns and column names. Since most of the tables from the 3DCityDB are quite big for just some thematic fields in the web client, you could use a (materialized) view instead. This way you can define the order of the column and column names accordingly. Please refer to the documentation and the release notes for more information on the structure of these tables and views required in the web client:
https://3dcitydb-docs.readthedocs.io/en/latest/webmap/online-spreadsheet.html#
https://github.com/3dcitydb/3dcitydb-web-map/releases/tag/v1.9.0
To expose the table or view, you'd need a REST API or a web server. For example, for PostgreSQL, you could use PostgREST
https://postgrest.org/en/stable/ to publish your data (so that the web client can access to).
I hope that helps.


Don't reload query when closing a cell

similar to https://github.com/influxdata/influxdb/issues/18401
we already have the results, so there's no need to re-run the query when closing a dashboard cell editor modal.

@russorat more specifically, did you want us to not reload the one cell that was closed, or did you want to not reload all the queries when closing a cell?

@Asalem1 We should definitely not rerun every query on the dashboard when they close a cell in most cases.
At a high level, we should only re-run queries automatically when absolutely needed. If there is larger re-work in patterns to accomplish this instead of a bandaid, let's consider it.

User made changes to their query in the cell editor but did not re-run the query before closing
We need to re-run the query when they save & close the cell to reflect their changes
If they clicked the red x to cancel their changes, we should display the previous result prior to opening the cell, so there shouldn't be a re-query in this case.
User made change to the variables or time range in the cell editor
In this case, we probably automatically re-ran their query for them in the cell editor (we do so when they change time range or variable values), but when they close the cell, those changes to variable values and time range are changed for the entire dashboard. That would mean we need to refetch all the visible cells on the dashboard EXCEPT the one they were editing (since we already ran that one).

Are there other scenarios we should consider here?

I think you just about covered it. I'll post more here if I can think of any other use cases

This should be addressed in #19010 (given that the configuration event is within the valid time range of cache validation)


device: Fix error when parsing balenaOS version before updating OS

Fixes #250
There is a change in output of device_os.get_supported_versions method
so device.start_os_update fails to parse current balena OS version
correctly.
Change-type: minor

Hey @thgreasi, can you have your review for this PR again please?

@balena-ci I self-certify!


Unable to import from Tandoor

Hello,
i had a Tandoor installation via Docker and then installed via Yunohost
I made an export (zip file) from the app on Docker and then Import to the Yunohost version.
The import process is able to read the file (I get the list of recipes) but the import fails "unable to create resource"
Thank you for your help

Hi
If it is not too much to ask, can you upload the zip file so I can test it out

Hello,
here is the file with one recipe ; I tested to reimport the file into the source app (docker version) and it worked so it is not related to the exported file
export_2022-08-17.zip

Thank you for this, I am investigating this issue now

I am able to recreate the issue

Ho
for your information, I tried the bookmarklet in order to add a recipe. Same error message

Ho
for your information, I tried the bookmarklet in order to add a recipe. Same error message

Thank you for trying that out. I'm in a bind right now because when I enabled DEBUG and SQL_DEBUG I was able to import the recipes. So there's a problem somewhere which I need to figure out

Hi! I am experiencing the same issue. How can I help?

Please reopen if the issue still persists. The fix has been merged into the master branch

It works like a charm.
Thanks !

I am still running into this issue, even after reinstalling Tandoor. Any chance YunoHost does not install the main branch by default?

Please reopen if the issue still persists. The fix has been merged into the master branch

Still not working, don't know how to reopen.

Alright, the latest package should have debug mode enabled to collect more data

I am still experiencing this. I have a feeling that this is some permissions issue. What can I do to help get to the bottom of this?

Thanks for your work! I couldn't import a recipe export from Nextcloud Cookbook either. Error message "failure".
The last thing in the debug log is:
"wsgi.errors:<gunicorn.http.wsgi.WSGIErrorsWrapper object at 0x7fa8b60a5700>
wsgi.version:(1, 0)
wsgi.multithread:False
wsgi.multiprocess:False
wsgi.run_once:False
wsgi.file_wrapper:
wsgi.input_terminated:True
wsgi.input:<gunicorn.http.body.Body object at 0x7fa8b609f1f0>
wsgi.url_scheme:https"

Yep, I am aware of this issue and am investigating this along with #35 now that I have time
Best,
Navan

On 18-Jun-2023, at 11:38 PM, fabykr @.***> wrote:
Thanks for your work! I couldn't import a recipe export from Nextcloud Cookbook either. Error message "failure".
The last thing in the debug log is:
"wsgi.errors:<gunicorn.http.wsgi.WSGIErrorsWrapper object at 0x7fa8b60a5700>
wsgi.version:(1, 0)
wsgi.multithread:False
wsgi.multiprocess:False
wsgi.run_once:False
wsgi.file_wrapper:
wsgi.input_terminated:True
wsgi.input:<gunicorn.http.body.Body object at 0x7fa8b609f1f0>
wsgi.url_scheme:https"
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you modified the open/close state.Message ID: @.***>


Paginations <nav> should have [aria-label]

Description of the bug
It is recommended to name landmarks on the page, so that screen reader-users easily can get an overview.
I suggest adding a [aria-label] to the <nav> element in Pagination to achieve this, so that we would get something like this:
<nav aria-label="Paginering">
  ...
</nav>

I leave it up to the team if the text should be configurable or not, and what the text should be.

I can see that rest can be used to set this [aria-label], but it should probably be set by default so it's not forgotten.
Steps To Reproduce

Open the Pagination page in Storybook
Inspect the page and see that [aria-label] is not set on <nav>.

Additional Information
No response

Example here: https://www.uutilsynet.no/tilsynsrapportar/rapportar-fra-tilsyn/1167?f[0]=gt%3A9


Reliable isProbablePrime

Make isProbablePrime more reliable.
Miller-Rabin Test with random sampling can detect some pseudo primes as a composite number.
And with my local testing, the new isProbablePrime() works as fast as the original one.
ref. https://github.com/peterolson/BigInteger.js/pull/48#issue-45877579

Coverage remained the same at 99.418% when pulling a110a848bdbf9f227aa7d4dcba119a2c2d0111ef on oogFranz:reliable_isProbablePrime into cf6754e3ee8e447ca60430614d6e9a678a537f18 on peterolson:master.

Thanks, looks good to me


subscription support in tide

Do you have any plan to support subscriptions in the tide? They already had their WebSocket crate and planing to merge it into tide itself.

I'm sorry to reply you late because of something.
In fact, I have added support for tide-websockets in the branch of tide-websocket, so I opened a PR, now you need to wait for a new version of tide-websockets to be released.
In addition, I personally do not recommend using tide, because it lacks a lot of functions, actix-web or warp (if you can master it 🙂) should be a better choice.

Thanks for your suggestion! I'm learning rust sync and found that tide is a good starting point for me. I also have tried warp a little. The chained router system is so unique.

@sunli829  Hi! tide-websocket has received a new release that includes the PR, are there any blockers for subscription over websocket to happen for async-graphql-tide?  Thanks for your effort, really enjoying the crates.

Release in v2.5.2   🙂

@sunli829 You are the best!!!


Add amount difference to Sales and expected deposit account to Sale Accounts

Add to sale attributes the was missing(installments, competency_month, amount_difference) and removes attributes that api does not respond(api_related).
Response example:
[
    {
        "sale": {
            "custom_classifications": [],
            "id": 118092,
            "nominal_amount": "41.67",
            "interest_amount": null,
            "ticket_amount": null,
            "discount_amount": null,
            "total_amount": "41.67",
            "fixed_fee_amount": "0.21",
            "amount_difference": null,
            "net_amount": "41.33",
            "fee_percentage": "10.0",
            "fee_percentage_amount": "4.13",
            "receivable_amount": "32.2",
            "issuer": "American Express",
            "payment_method": "parcelled",
            "installment_number": 24,
            "installment_count": 24,
            "original_sale_id": 118068,
            "status": 1,
            "summary": false,
            "document": "",
            "document_emission_date": null,
            "provider_code": null,
            "description": "outro outro",
            "observation": "",
            "category_id": 530334,
            "classification_center_id": 17643,
            "person_id": 191988,
            "days_to_liquidation": 10,
            "sale_account_id": 12,
            "financial_account_id": 1915503,
            "liquidation_weekday": 1,
            "estimated_liquidated_at": "2020-05-11",
            "liquidated_at": null,
            "occurred_at": "2020-04-28",
            "confirmed_at": null,
            "created_at": "2018-05-28T11:58:52-03:00",
            "updated_at": "2018-06-13T21:54:50-03:00",
            "competency_month": "2018-05",
            "tax_charges": [
                {
                    "id": 30521,
                    "tax_id": 2,
                    "amount": "0.13",
                    "withholding": true
                },
                {
                    "id": 30522,
                    "tax_id": 3,
                    "amount": "0.21",
                    "withholding": true
                }
            ],
            "attachments": [],
            "installments": [],
            "links": [
                {
                    "rel": "previous",
                    "href": "https://sandbox.myfinance.com.br/entities/3703/sales/118069",
                    "method": "get"
                }
            ]
        }
    }
]
``

ch12202

:shipit: released on version 1.6.6


When Creating a Vertical Global Portal, The Client Crashes

Version: immersive-portals-0.13(forMc1.16.1withFabric).jar
1 Minute Video Demonstrating The Issue: https://youtu.be/8y9LF31Zb-A
Crash Report: https://paste.ee/p/Xis4q
This requires a world backup to be restored in order to access the world again.

fixed in the latest version


Autoincrement attribute invalid in standalone waterline

Waterline version:0.13.3
Node version: 5.8.0
NPM version:9.11.1
Operating system: Zen Arch Linux

I am trying to create an autoincrement property in my waterline model definition. when i do and i run my server i get into this error The attribute ``id`` on the ``ownershipchangeaction`` model contains invalid properties. The property ``autoIncrement`` isn't a recognized property. where ownershipchangeaction is my model's name.
I am using the sails-mysql adapter. How can i make an automatically incremented column in waterline ? am i missing something ?
here is my model :
var OwnerShipChangeAction = Waterline.Collection.extend({
  identity: 'ownershipchangeaction',
  datastore: 'default',
  primaryKey: 'id',
  attributes: {
    id: {type:'number',autoIncrement:true},
    cert: {type:'string'},
    iss : {type:'string'},
    fiss :{type:'string'},
    owner :{type:'string'},
    createdAt: { type: 'number', autoCreatedAt: true, },
    updatedAt: { type: 'number', autoUpdatedAt: true, },
  }

});

i get this when i remove the autoincrement property :
Error: In model ``ownershipchangeaction``, primary key ``id`` must have either ``required`` or ``autoIncrement`` set.

Seeing this as well.

@cdeveas  Yes and I am seeing a lot of miss-documentations .
I did solve this by using it this way : autoMigrations:{autoIncrement:true}
and I am having problems with setting the ColumnType too.
The official documentation is way OLD and not regularly updated, especially for Standalone waterline.

@moda20 I did like a lot of features of Waterline, but the latest version seems to depend heavily on Sails (understandably). I ended up going with TypeORM for my small project. There's an ES6 non-typescript example implementation here: https://github.com/typeorm/javascript-example

Apologies for mentioning another ORM within a waterline Issue

@moda20 @chasdevs looks like you got it under control with the autoMigrations. For reference to others viewing this issue, documentation here:
https://sailsjs.com/documentation/concepts/models-and-orm/standalone-waterline-usage
@moda20 feel free to update the issue with a specific question re: columnType. Did you take a look at this yet? https://sailsjs.com/documentation/concepts/models-and-orm/attributes#columntype


adoptopenjdk-bin: init at 11

Motivation for this change
Oracle JDK 11 is not free of charge (except for development, testing, prototyping, or demonstration), and free users are guided to use OpenJDK 11. openjdk11 package is in progress, but not building yet (https://github.com/NixOS/nixpkgs/pull/47375#issuecomment-428671180).
This PR add binary packages of AdoptOpenJDK, which includes combinations of JDK/JRE and Hotspot/OpenJ9 variants.
Only x86_64-linux is supported for now, though AdoptOpenJDK itself supports many platforms and architectures.
Things done

[X] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[X] NixOS
[X] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[X] Fits CONTRIBUTING.md.

Added Darwin packages.

This is good to go right?
cc @NeQuissimus @fpletz as maintainers of other JDKs

LGTM


pre-ai updates

have fun

Cout ruiner, i hardly know her
looks good 🛥

Bug fixes looks good

horse


[DUOS-789][risk=no] Disable voting on non-open elections

Addresses
Partially addresses https://broadinstitute.atlassian.net/browse/DUOS-789
Changes
This PR prevents votes from being submitted on non-open elections. There are at least two other bugs that also need to be addressed, but this PR prevents a significant source of error from members/chairs that arrive at an un-voteable election in error.

Have you read Terra's Contributing Guide lately? If not, do that first.
I, the developer opening this PR, do solemnly pinky swear that:

[x] PR is labeled with a Jira ticket number and includes a link to the ticket
[x] PR is labeled with a security risk modifier [no, low, medium, high]
[x] PR describes scope of changes

In all cases:

[ ] Get a minimum of one thumbs worth of review, preferably 2 if enough team members are available
[ ] Get PO sign-off for all non-trivial UI or workflow changes
[ ] Verify all tests go green
[ ] Squash and merge; you can delete your branch after this
[ ] Test this change deployed correctly and works on dev environment after deployment

If the election is not open, would it be easier to not render the VotePanel as opposed to disabling the panel/hiding panel elements from the Chair/Member tabs?

I chose this path so that we can still show the votes, but show them as disabled. As it currently stands, this PR is a bit of a workaround in that we're preventing the user from submitting invalid input. However, it also serves as a potential read-only view regardless of election status.

Also marking this as draft as there are some new wrinkles around what to do for elections with status of Final.


It seems that proxy.count cannot be accessed

In the article Exploring Design Patterns in Rust Inter-Component Interface Invocation, I am confused by the following example:
fn is_even_impl(
    // Using trait object theoretically can speed up compilation because the code generation doesn't need to wait for generic instantiation.
    proxy: &mut EvenProxy<dyn Odd>,
    n: u64,
) -> bool {
    proxy.count += 1;

    (n == 0) || proxy
        .ctx // invoke is_odd through ctx
        .is_odd(n - 1)
}

Is this statement proxy.count += 1 a mistake? Because we cannot get dyn Odd: Ctx: AsMut<EvenState> here, then we cannot use proxy as &mut EvenState, I guess.

Oh, I make some mistakes. Here is the right implementation...
EvenProxy<impl AsRef<EvenState> + AsMut<EvenState>> would impl DerefMut<Target = EvenState>


Incorrect description for emit

The description for emit method states the following:

If present, "*" handlers are invoked prior to type-matched handlers.

But according to the implementation the order is opposite.

PR is welcome


[BUG] Microsoft.Azure.Management.ApiManagement UserOperations CreateOrUpdate does not contain notify parameter

Describe the bug
According to documentation ApiManagement.UserOperations.CreateOrUpdate must contain notify parameter which should trigger welcome email.
This parameter is missing in the latest version of Microsoft.Azure.Management.ApiManagement package
Expected behavior
I expect to be able to pass notify parameter to apiManagement.User.CreateOrUpdateAsync
Actual behavior (include Exception or Stack Trace)
There is no such parameter in apiManagement.User.CreateOrUpdateAsync
To Reproduce
Steps to reproduce the behavior (include a code snippet, screenshot, or any additional information that might help us reproduce the issue)

Install package Microsoft.Azure.Management.ApiManagement -Version 6.0.0-preview
Create ApiManagementClient
Check apiManagement.User.CreateOrUpdateAsync

Environment:

Name and version of the Library package used: Microsoft.Azure.Management.ApiManagement -Version 6.0.0-preview
dotnet
Version:   5.0.200-preview.20601.7
Commit:    b3b934bbf2
OS Name:     Windows
OS Version:  10.0.19041
OS Platform: Windows
IDE and version: Visual Studio 16.3

Thank you for your feedback.  Tagging and routing to the team best able to assist.

@pakrym ,  looks like notify query parameter was not generated on neither OperationExtension nor [Operation[(https://github.com/Azure/azure-sdk-for-net/blob/81ab5df7ef0190a097382c6aeaf0434c271302fb/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/src/Generated/UserOperations.cs#L775).  Do we have a bug on track 1 codegen?

I don't think the library was re-generated after https://github.com/Azure/azure-rest-api-specs/pull/10122 went in.

@vfedonkin, please regenerate SDK to incorporate new swagger changes. Thx.


Make NVGPU_TARGETS a cache variable

Closes #30

@tdd11235813 That should work.

Thanks, it fixes the issue with NVGPU_TARGETS when it is filled with, e.g., --gpu-architecture=sm_50.
A simplification could be, that it just takes the compute capabilities, also as list, e.g. "30;35;50".
In cmake such a processing could look like (untested):
foreach(CUDA_ARCH_ELEM ${NVGPU_TARGETS})
    list(APPEND HIP_NVCC_FLAGS "--generate-code arch=compute_${CUDA_ARCH_ELEM},code=sm_${CUDA_ARCH_ELEM} --generate-code arch=compute_${CUDA_ARCH_ELEM},code=compute_${CUDA_ARCH_ELEM}")
endforeach()

Good suggestion. I updated the pull request, it's not as sophisticated as for example this code, but it should do the trick.


requestAnimationFrame callback not passing time in IE9

The requestAnimationFrame pass no value in its callback under IE9.
Tested on IE11 with IE9 emulated on a Windows 10 Home system.
Example: https://jsfiddle.net/qrhym5w3/

There are two problems here:

the rAF used in here is a partial polyfill and it won't probably change since the amount of extra code to fully polyfill it is huge and also not 100% reliable anyway due  Date inaccuracy, so the effort is kinda not worth the gain. This is also specified in the README
you are not normalizing timers in IE9 which will bite you with many more libraries.

For the second point, I suggest you to fix every single HTML template file you have adding the following in the header and before any other script.
Don't worry, every other browser will simply ignore that script, considering it a comment.
<!--[if lte IE 9]>
  <script>(function(f){window.setTimeout=f(window.setTimeout);window.setInterval=f(window.setInterval)})(function(f){return function(c,t){var a=[].slice.call(arguments,2);return f(function(){c.apply(this,a)},t)}});</script>
  <![endif]-->

This has been described in this post of mine and it has been used in production since about ever and it's side-effects free.
Once you've added above normalization, you'll receive a 15 as milliseconds values which is already passed, so this is not a real bug.
Best Regards


Add basic Grid widget and test RenderGrid

Happy to add tests with some explanation as to how.
@abarth

Please split into two CLs and add tests to each.
sky/unit/test/widget/date_picker_test.dart is a good model test.

Split out pageChanged into https://github.com/domokit/sky_engine/pull/894

git add test?

LGTM


Proguard - missing rules

Following rules work but may be able to be improved:
-dontwarn com.samsung.**
-keep class com.samsung.** {*;}

You should add a proguard file to the project..

Fixed in 8aa2189. Thanks!

Perfect :-)
Btw, really nice library that's working fine

Glad you like it! If you don't mind me asking, what app are you including this library in? I'm curious how people are using it.

Here you go: https://plus.google.com/u/2/communities/107213953584663540470
I use it in a gallery app...


HCatalog and HBase Native api Issue.

Hi,
I am using HCatalog api and getting really high latency to fetch data from HBase table.
Issue:
Environment and Data Size:

HDP 2.5 3 3 Node cluster with 66 Core and 150 GB RAM
Total record in HBase table 91 Million
Total region server: 3 and region count : 48 per region server
While fetching record from HBase table using Spark-Sql following are the stats...

100 records --- 2.5-3 sec
250 records --- 3-4 sec
500 records --- 5-6 sec
1000 records --- 10-12 sec
1500 records -- 32 -33 sec
Query  : select c1,c2 ...... cn from table 1 where rowkey in (r1,r2,........................rn);
I am getting lower latency If I use HBase native api..
1000 records --- 432 msec-1.2 sec
2000 records -- 600 msec -1.8 sec
What could be possible reason for Higher latency in case of HCatalog api?
---Ajay

i have same problem
select c1,c2 ...... cn from table 1 where rowkey in (r1,r2,........................rn) use bulkgets or scan in Hcatalog?

Same issue. IN clause is critical. Do we have any work around?


Implicit assumption of random ordering of generated images in calculation of Inception Score leads to underestimated ISC.

Hello, in the provided evaluator.py:
    def compute_inception_score(self, activations: np.ndarray, split_size: int = 5000) -> float:
        softmax_out = []
        for i in range(0, len(activations), self.softmax_batch_size):
            acts = activations[i : i + self.softmax_batch_size]
            softmax_out.append(self.sess.run(self.softmax, feed_dict={self.softmax_input: acts}))
        preds = np.concatenate(softmax_out, axis=0)
        # https://github.com/openai/improved-gan/blob/4f5d1ec5c16a7eceb206f42bfc652693601e1d5c/inception_score/model.py#L46
        scores = []
        for i in range(0, len(preds), split_size):
            part = preds[i : i + split_size]
            kl = part * (np.log(part) - np.log(np.expand_dims(np.mean(part, 0), 0)))
            kl = np.mean(np.sum(kl, 1))
            scores.append(np.exp(kl))
        return float(np.mean(scores))

Of interest is the computation of the KL divergence in batches of 5000. This implicitly assumes that, having generated 50,000 images of, say, 1000 ImageNet classes as our conditioning information, the images are ordered randomly in the provided array and thus the mean of the KL divergence of the batch approaches the KL divergence of the whole.
If instead the case occurs where the images are ordered by class (i.e. images of class 0 as the first 50 images, class 1 as the next 50, etc etc) in the provided array, the KL divergence of the batch will spike due to the batch only containing representations of 100 out of 1000 classes, and thus the calculated ISC will be artificially low.
This issue can be fixed by adding the following line:
np.random.shuffle(activations)
As a demonstration:  If I sort my own generated ImageNet sample set of 50K images in order, I get ISC of ~50, the other is not in order and gets ISC of ~366.
Fortunately, this bug does not affect the academic research which uses this script for evaluations, because authors save the images to disk as individual files, then use Python to read the files back in -- which ends up being, by happenstance, in a random enough order that the batch statistics are close to the non-batched KL divergence.

Just ran into the issue of extremely low IS (~50) and find your insightful observation exactly what I want.


Screenshot needs update

The Visual Studio new project dialog under Create a Visual Studio Activity Library project still shows .NET Framework 4.5.2 but the instructions say 4.6.2

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: eb46fb23-01b2-e7f4-f89a-fa222ea40a8a
Version Independent ID: 32b849a9-178c-0907-6bb3-23f61c1cd415
Content: Tutorial: Create workflow extension (Common Data Service) - PowerApps
Content Source: powerapps-docs/developer/common-data-service/workflow/tutorial-create-workflow-extension.md
Service: powerapps
GitHub Login: @JimDaly
Microsoft Alias: jdaly

Screenshots are updated and doc is live.
Closing this issue now.


can this work with fred registry?

will this work?

with some effort it can me made to work with any registry, but it is designed for our registry platform and works over Restful-EPP API that FRED does not have. So out of the box it does not work with FRED unfortunately.

https://github.com/internetee/registry has web based admin UI for most common configurations - including adding registrars, users, zones and sub-zones. Some more specific configurations that are usually done only once on setting up the registry are done in config files.


Using transformEntriesToType after changeFieldId causes reference error

Expected Behavior
Using .changeFieldId() in the same migration as .transformEntriesToType() should work as defined.
Actual Behavior
When .changeFieldId() is used before .transformEntriesToType in a migration, a reference error is thrown by the getLinks() method in lib/offline-api/index.js attributed to this line:
const field = entry.fields[key][locale] // entry.fields[key] is undefined

Possible Solution
Only use one of the aforementioned methods in a migration script at a time
Context
Running a custom migration to merge two content types
Environment

Node Version: v11.14.0
Package Manager Version: 6.9.0
Operating System: Linux x64
Package Version<EMAIL_ADDRESS>

Fixed in #180 and released with version 0.17.4 🎉
Thanks @Khaledgarbaya and @phoebeschmidt!


Pretrained weights gets changed after importing weights from Pytorch to ONNX.

While importing pre-trained weights from Pytorch to ONNX, weights are getting modified. Well I have 1.9 pytorch version and used below script for converting a pre-trained weights from pytorch to ONNX. Well I know there is an issue with pytorch --> ONNX conversion, but here I am posting it again for quick help.
If someone can help me out than it would be really helpful. Thanks in advanced !
Open Issue link:
https://github.com/pytorch/pytorch/issues/72392

Solution:
https://github.com/pytorch/pytorch/issues/72392


Volume metrics should be disabled if backend storage of registry does not support, such as s3.

Volume metrics should be disabled if backend storage of registry does not support, such as s3.

This may require some structural change, for example, admin server can read configurations of registry.


tools refactor

Updated to use pydantic models for parsing and validation. Added a test to check that it works with args and kwargs specs.
Need to update the decorator to work out of the box for structured functions. Will work on that now

OK - updated the Tool class and decorator to permit structured args using the decorator.

Added more unit tests and a bit to the Tool notebook. Will add another notebook on tool input validation


Why aren't all images loading?

The page may implement a lazy loading for images. Lazy loading means the images will be fully downloaded only when they appear in viewport.
To overcome this, you may try to use scrollPage=true option which scrolls the page down before render. This should trigger the loading for lazy loaded elements.
See: https://github.com/GoogleChrome/puppeteer/issues/338

The page may implement a lazy loading for images. Lazy loading means the images will be fully downloaded only when they appear in viewport.
To overcome this, you may try to use scrollPage=true option which scrolls the page down before render. This should trigger the loading for lazy loaded elements.
See: https://github.com/GoogleChrome/puppeteer/issues/338


need to check if sudo is installed

I noticed on a new system without sudo installed that this policy is quite noisy:
   error: execresult '/usr/bin/sudo -l -U gnats' is assumed to be executable but isn't
   error: Proposed executable file '/usr/bin/sudo' doesn't exist

for each user in /etc/passwd.
Maybe define a class if sudo is present and guard the promise with that?
https://github.com/nickanderson/cfengine-inventory-sudoers/blob/main/policy/main.cf#L76-L83

Mmmm. Yes, indeed improvements would be good here.
Looking at the MPF I see that the path for sudo is only defined in the context of darwin::. So, kinda think that I will publish the path for sudo and then use from paths if possible.
bundle agent __main__
{
  vars:
    # Initially I was thinking to do this:
    "path[sudo]"
      string => "/usr/bin/sudo",
      if => and( fileexists( "/usr/bin/sudo" ),
                 not( "_stdlib_path_exists_sudo" )),
      meta => { "paths.cf" };

    # But, then again, that's more invasive than doing this:
    "bin_sudo"
      string => ifelse( isvariable( "default:paths.sudo" ), "$(paths.sudo)",
                        "/usr/bin/sudo" ),
      if => isexecutable( "/usr/bin/sudo" );

  reports:
    (inform_mode|verbose_mode|debug_mode).!windows::
      "Warning: Path to sudo unknown, not updating inventory"
        unless => isvariable( "bin_sudo" );

}

@craigcomstock can you test this: https://github.com/nickanderson/cfengine-inventory-sudoers/pull/4


Contact Sensors Dying and Generation 2

I haven't been very careful about watching the battery levels in my (8) contact sensors. Wyze has a statement on their site that if you let the battery run completely down, the sensor may not function any more.
I am running the systemd version of the installation.
The first sensor would do nothing when I replaced the battery. No red LED blink when I installed the new battery. I called their support number and after going through their troubleshooting routine, they were kind enough to send me a replacement under warranty. I received it with a dead battery. It is functioning properly with a new battery.
The second sensor flashes the LED when  I install a new battery, but did not publish any MQTT messages. I tried to re-pair it with the gateway and found that it will not pair. The pairing function from the command line tool sees the sensor, but the MAC address is blank. The log says 'Invalid MAC address". I've gone around this loop quite a few times without success. The sensor flashes the LED when the magnet is moved, but will not pair with the gateway.
This makes me wonder if there is some memory in the device that looses its content after some time with a dead battery.
I wanted to buy some more contact sensors to replace the failed ones and found that they are not selling the current version anymore. They say watch for Generation 2 coming soon.
When I was talking to their support guy on the phone, I asked him about this. He had no concrete answers about when Generation 2 would be available, or whether it would be backwards compatible with the current sensors. He did say they will have a humidity sensor. He also said the the new sensors might need a new hub.
Does anyone have any more information about this? I'm hoping that Generation 2 will be compatible with what we have now.

@dennyfmn the loss of the MAC address seems to be a fairly common issue with no fix. If the logs indicate it is an invalid mac address it is because it lost its MAC and is all 0s. I've added support for some "status" messages, which seem to periodically report its state when it hasn't been activated in a fixed amount of time. This will let you alarm on sensor battery level even if it doesn't alarm regularly.  See #50

Hi @dennyfmn and welcome! I don't have concrete answers for you, not actually associated with Wyze, but I'll share what I think might happen.
RE Sense v2. I believe there is a chance that the new sensors will be backwards compatible, based on Neos using a similar protocol, but already having a leak/humidity sensor. That said, Wyze could be going in a completely new direction, I have seen things from them about a new hub, and the v3 Cam not supporting the current gen stuff. So this may be a start from scratch situation. I'm waiting to see before declaring any intent with this project. But I don't have as much time as I did when I started, so if it is all new, someone else might need to take up the mantle to get this working with both generation products.
RE the dead sensors.  However, in all cases (except one that I physically broke while changing the battery), if I took out the low battery and let them sit for a bit, then install a fresh one, they all got their MAC back and resynced to the bridge. I might have gotten lucky, but I don't think letting the battery get low is a death sentence, just requires patience to get going again. Because the bad MACs wreck havoc on the bridge stability, I've tried to block them as much as possible in code, thus the log messages. If you somehow do still have one linked, you should be able to clear it via the Fix function in the command line tool.
RE the battery alarms, @AK5nowman did a great job getting the base in place. As soon as I can, I'm going to look into specifically HA's handling of MQTT messages and see if I can turn the alarms into something actionable.
In the interim, I'm going to close this specific issue, but if you have other questions or issues come up, please feel free to create more.


Implement page autogeneration for clubs and members

Proof of concept can be found at https://github.com/iropal/OSSN/compare/create-pages

create-pages branch has a proof of concept where we manage to make queries to the backend and create pages for each result.
Note to self: The components that use variables in graphQl queries that are passes in context at gatsby-node.js need to be in templates folder otherwise the variable is not populated!!!


add service monitor to component reconciler

Description

enable service monitor

Related issue(s)
https://github.com/kyma-incubator/reconciler/issues/907

/hold

/retest-required

/retest-required


Update contributor's section to include all contributors

https://vueuse.org/ uses the following way to identify their contributors:

I'm guessing there's an API they use that we could be leveraging to display the same data on our site. We just had hacktoberfest contributions and lot more people have been contributing. We should really highlight these folks more intentionally. We currently have this banner:

Instead, it should replace the 3 logos with the contributor list style above so that they show up below the text & CTA.
Acceptance

Update how contributors are displayed
Add the contributors' banner to the landing page before the last get started section

Hi, Can I work on this issue? If assigned, do I need to work on the frontend part of the banner?

Hei @aksy2512 .. Finish up the other issue that you just assigned dot yourself, and then if still available you can also work on this.

@aksy2512
Since your last PR was approved, I am assigning you this issue to work on 👍

@jdwilkin4 I went through the code of https://vueuse.org/. They are not using any API and individually calling each user. Can you please help me determine which API I should use to display the same data?

@aksy2512
I did some googling and found this stackoverflow answer on how to get the contributors list from the github api
https://stackoverflow.com/questions/36410357/github-v3-api-list-contributors
It looks like this API should give you the information you are looking for
https://api.github.com/repos/thisdot/framework.dev/contributors?anon=1

ok, Thank you @jdwilkin4. I need one more help. Can you please tell me the specific file in which I have to write the code

@aksy2512
There is a ContributorBanner component in the homepage.tsx file.
That is where the hardcoded array of 3 contributors list current is
	<ContributorBanner
	  contributorImages={[
		  "https://github.com/jbachhardie.png",
		  "https://github.com/tvanantwerp.png",
		  "https://github.com/markshenouda.png",
	  ]}
       ></ContributorBanner>

You will need to remove that hardcoded array and create a solution that renders all of the contributors for this project. 👍

I tried it by using the following code inside the Homepage function but the state of contributors is not changing. I also tried using Use effect but it is not working as well

Can you open a draft PR?
It will be easier to leave comments on there instead of posting screenshots on the ticket here
https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request

I have linked a Pr and I have commented out the problem in  the code

@aksy2512
I'll take a look at in a bit. 👍

@jdwilkin4 ok, Thank you , give me 2 days to complete it

@aksy2512
Just checking in with your progress on this ticket.
How is everything going?

@aksy2512
Just checking in with your progress on this ticket.
How is everything going?

I had some exams in the past couple of days in my university so I wasn't able to focus too much, but now the exams are over and I will continue with the issue

@jdwilkin4 I had some issues with the previous branch so I have created a new branch and a new pull request and closed the old one. Please have a look at the code that I have pushed


Start sensor services dynamically

With this code, the services would be loaded by a RadarServiceProvider. The actual services being loaded is configurable in the Firebase configuration.
Still missing: using the correct labels in the UI based on the services being loaded.

With this pull request, services can be dynamically loaded, as long as their service provider is in the class path.

Will be merged with #41.


Extend CONTRIBUTORS list

As part of my first assignment in the Pull Request Club, I've been asked to add my name to the CONBTRIBUTORS list.  This change implements this extension :-)

Thanks and welcome to the club :)


Minor refactoring and reformatting

Tighten whitespace
Remove superfluous assert statement
Reorder imports
Make parameters required and remove default values

Thanks to if __name__ == "__main__":, the script can be run standalone, without pip install-ing it. Maybe you could should the README to let know people of this new feature?

Can you fix the conflicts? I think there are some useful things in here that weren't in your other PR

I fixed the conflicts and squashed the commits :-) I think it's good to go


Enable k8s plugins for transform

Enable k8s plugins from crane-lib for transform.
#22

Actually, with this refactoring, GetBinaryPlugins doesn't need to be an exported function, so forget what I said above. Leave it as-is, but just rename the exported func GetPlugins (and change the places where it's called).

Just updated GetBinaryPlugins to GetPlugins.


Populate BICCN Paper content

Need
We need to populate the BICCN publications like:

There are 24 papers listed here
There is also information for the RHS of the papers here:
https://www.biccn.org/science/human-and-nhp-cell-atlas
We can get the authors, title, publication and date from crossref with the DOI but we also need to list additional information in RHS boxes
e.g. see the boxes like:

Complete


BallerinaStreamsV2JoinTest.testStreamJoinQuery failing intermittently

Description:
[ERROR] testStreamJoinQuery(org.ballerinalang.stdlib.streams.BallerinaStreamsV2JoinTest)  Time elapsed: 6.525 s  <<< FAILURE!
java.lang.AssertionError: Expected events are not received expected [2] but found [3]
	at org.ballerinalang.stdlib.streams.BallerinaStreamsV2JoinTest.testStreamJoinQuery(BallerinaStreamsV2JoinTest.java:56)

We need to come up with a different approach to receive events into streams to resolve this issue properly. Created #14037 to discuss the issue. For now, for the sake of stability of the build, the sleep time is increased.


Added SV_RenderTargetArrayIndex support to pixel shader debug

Added SV_RenderTargetArrayIndex support to pixel shader debug - fix for #1527

I appreciate the contribution but while it solves your problem I don't want to merge this upstream. This fix only covers specific cases, and I'd rather fix this with a solution that covers everything. As discussed in #1527 this is a subset of #763 and is not orthogonal.
The root problem is that the pixel shader debugging currently only disambiguates on primitive ID for multiple writes to a single sample/fragment. When using instancing the same primitive ID can write multiple times to the same sample, but sourced from different instances so with different inputs.
In your case, the instance ID is passed along to the pixel shader via SV_RenderTargetArrayIndex, but there's not necessarily a direct correlation. If instead of having a draw with a single quad instanced N times, you had N quads which each went to a different RT index then the debugging would be able to disambiguate purely based on primitive ID without needing this extra code. Similarly if you had a draw where multiple instances went to the same RT index and overdrew then this code would not fix the problem because the array index no longer fully disambiguates which sample to debug.

I see where you're coming from - in my mental model all samples and slices are still part of the same pixel, it can just be an arrayed or multi-sampled (or both) pixel. So the problem is framed in terms of debugging the desired write to that pixel via filtering on the inputs.
Viewing them as different pixels the semantics are still problematic. With the sample index we can always use SV_Coverage to know what sample we're writing to, so we can implicitly filter pixel shader invocations to only the desired sample, the same as we do with primitive ID. With array/slice index we can't do that - SV_RenderTargetArrayIndex is only valid to read if it was written by the previous shader stage, it doesn't automatically populate with the index being written to.
I'm not saying that your solution doesn't work or help in some scenarios, but I'm concerned about adding a partial solution to fix some of the problems when it still leaves a gap that needs to be fixed - and the solution for the larger problem will also solve this problem.

Well, IMO it doesn't matter what kind of mental models either of us has. It's about interface RD provides - user selects slice and sample number first, then picks pixel and press debug. I'd expect to debug this pixel, not additional interface or list of fragments to pick from.
Also, AFIAK, SV_RenderTargetArrayIndex is the only way to draw in different slices of RT array (and cube maps), so I don't really see how this issue can be solved w/o using it.
The only problem I see with my commit is UB if SV_RenderTargetArrayIndex is not set by GS. I can't find any info on how it should behave, even if on my PCs it just set to 0 (which makes sense - if it's not set pixel must be written to slice 0). If you think it can cause problems it is easy to add a check for input signature (I can do it)

As I mentioned this only solves the case where you have each instance rendering to its own array index. If you had an instanced draw where multiple instances could render to the same array index, SV_RenderTargetArrayIndex would no longer work to disambiguate but the instance would - and disambiguating by instance would also solve this case. I don't want to merge and support this partial solution, which will later need to be superceded by another.
Again you can keep this change locally for your own use, it's only that I don't want to include it upstream. I appreciate you making the change and I'm glad you were able to find a solution for your problem, but I'm not going to merge this PR.


codecov job: git clean before checking out

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: hklai
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

bin/OWNERS [hklai]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/test istio-unit-tests

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: hklai, kyessenov
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

bin/OWNERS [hklai]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Refactor Emailer.java

Create a sendEmail method to be used more generally not just limited to failure/success/sla emails. This method will be used by Flow trigger to alert user on flow trigger failure with customized email subject/body.
Since currently Emailer.java can only be tested via integration test, I didn't write unit test but verified by sending a email with the new method in local mode.

"Since currently Emailer.java can only be tested via integration test, I didn't write unit test but verified by sending a email with the new method in local mode."
Not having automated tests for new code is ok for a PR only if tests will be added shortly after.
I would suggest refactoring email component. This piece can be improved anyway. @jamiesjc and I had discussions about it. She planned to do it but it hasn't become a priority.
Since you modified the code, you are on the hook now. :)

@HappyRay https://github.com/kirviq/dumbster just did some research on unit testing on sending emails, this could be helpful.

Other choices I found:
Java mail testing:
http://www.icegreen.com/greenmail/
https://stackoverflow.com/questions/1033076/mail-server-for-javamail-testing

To make the unit tests effective, I think the mail module needs to be refactored.


chore: Add PR verify action

Add a Github Action which will install dependencies, run lint, and run
tests

@fayaz07 a passing pipeline can be seen in this PR. I assume it's not registering here because of repository settings which I'm unable to change


Change copy "Invalid Date Format" for KeyboardDatePicker

Is there a feature where we can change the copy of this error message Invalid Date Format or just hide it?

for KeyboardDatePicker:  https://material-ui-pickers.dev/api/KeyboardDatePicker
Thanks!!

What do you mean by copy?

@dmtrKovalenko copy === text

thanks @DoWhileGeek!
Is there a feature where we can change the text of this error message Invalid Date Format or just hide it?

any idea @dmtrKovalenko ?
Thanks for your help!

Just pass a prop helperText it will change the message. Also error prop will render red error state. The same as core mui input

thanks @dmtrKovalenko !
       <KeyboardDatePicker
              helperText={''} />


Npm audit

Few things were being flagged by npm audit, then I went and started to prune other dependencies that appeared unused

Yeah, I'm not familiar enough with building Vue to see if there is more that we can strip out to get a more minimal setup for portability


Support for gamepads

Android TV and gamepad support for moving to the next option and also
exiting the intro

Looks good, thank you!


[BUG] Calling set_meta with a list of strings raises an exception on a second call

Describe the bug
Calling set_meta where values is a list or cudf.Series of string values raises an exception on a second call. The first call which creates the new column succeeds while the second call, updating values over a set of sliced rows raises an exception.
Issue seems to be centered around the fact that cupy doesn't support arrays of strings, while cudf does. This bug occurs in both C++ & Python execution modes.
Causes #282
Steps/Code to reproduce bug
import os
import string

from morpheus._lib.file_types import FileTypes
from morpheus.io.deserializers import read_file_to_df
from morpheus.messages.multi_message import MultiMessage
from morpheus.messages.message_meta import MessageMeta

input_file = os.path.join(os.getenv('MORPHEUS_ROOT', '.'), 'tests/tests_data/filter_probs.csv')

df = read_file_to_df(input_file, file_type=FileTypes.Auto, df_type='cudf')
meta = MessageMeta(df)
mm1 = MultiMessage(meta, 0, 5)
mm2 = MultiMessage(meta, 5, 5)

values = list(string.ascii_letters)

mm1.set_meta('letters', values[0:5])
mm2.set_meta('letters', values[5:10])

Bug caused by lack of string for iloc assignments on existing string columns (https://github.com/rapidsai/cudf/issues/11298), and our use of it in set_meta. https://github.com/nv-morpheus/Morpheus/blob/c3a3ddf6f1421175345ca08aaae933658c79757e/morpheus/messages/multi_message.py#L147-L152
Possible workaround by updating set_meta to detect string assignments, create a null-filled column, and use iloc instead of loc, such as:
df['letters'].iloc[0:5]  = values[0:5]
df['letters'].iloc[5:10] = values[5:10]


Updating Use Python task self-hosted Q&A

@leantk : Thanks for your contribution! The author(s) have been notified to review your proposed change.