feat: 4164 - added a nova section for add new product page

What

Added a Nova section in the "add new product" page

Screenshot

new nova section
category input

ingredients input
well done!

Fixes bug(s)

Closes: #4164

Impacted files

add_new_product_page.dart: added a paragraph for nova
app_en.arb: added a title and a subtitle for nova
app_fr.arb: added a title and a subtitle for nova
product_dialog_helper.dart: added an unknow logo for nova

@monsieurtanuki White on White buttons

@monsieurtanuki White on White buttons

Already mentioned in #3974.

@monsieurtanuki is there a way to add the explicitation of the food processing level next to NOVA ?
As simple as adding the group name "Processed foods". User feedback is that they don't understand it without explanation, and it will be for many their first exposure to it.

@monsieurtanuki is there a way to add the explicitation of the food processing level next to NOVA ?

Sure! Just send me a lousy mock-up and I'll add the text where you want.

Something as simplistic as that:

empty product
nova half-unknown
nova computed


feat(storage): implement storage::GrpcClient::DeleteResumableUpload

Fixes: #5910

This change is

Don't worry about the build breaks, that was an internal snafu on the key refresh.


Use await will raise error when reloaded script in DEBUG mode

Godot version
4.1.2.rc1
System information
Godot Engine v4.1.2.rc1.mono.official.58f0cae4a - https://godotengine.org Vulkan API 1.3.236 - Forward+
Issue description
After I use * await * KEYWORD in my script, it will raise errors when i edit my code and reloaded  it in debugging mode.
The issue not happen again when I delete or comment out the line include * await * KEYWORD
This is error info:
E 0:00:30:0220   test.gd:13 @ _ready(): Condition ' (ip + 5) > _code_size ' is true. Breaking..:
Steps to reproduce
There are test code in a new created project:
extends Node3D

func _ready() -> void:

	var NewTween = get_tree().create_tween().set_loops()
	NewTween.tween_callback(CreateMonster).set_delay(0.2)

func CreateMonster():
	var Monster = MeshInstance3D.new()
	Monster.mesh = $MeshInstance3D.mesh
	add_child(Monster)
	Monster.position = Vector3.ONE * randf_range(0,51)
	await get_tree().create_timer(1).timeout
	Monster.queue_free()

When i changed and save code in Debugging ,the script reloaded then it raise an error
Minimal reproduction project
Trail.zip

Probably related:

#62769
#74607


Add new Hack file extensions.

Description
Linguist seems to have an issue to finding the difference between Hack Lang files and C++ Header files as both use the .hh extension ( #4346 ) , it was fixed in #4347 but HHVM as of version 3.29 supports new Hack Lang extensions .hck and .hack ( https://github.com/facebook/hhvm/blob/3df035714e281ea56d2d99592757277fb8e44401/hphp/hack/src/utils/findUtils.ml#L16 ), a unique extensions for hack, this would solve the issue for hack lang once for all, as hack might get rid of <?hh in the future which would only makes differentiating hack from C++ headers harder.
i'm planning on using the .hack extension in my project but i found out that linguist doesn't support this extension at all, so i decided to make this PR :smiley:
Checklist:

[x] I am associating a language with a new file extension.

[x] The new extension is used in hundreds of repositories on GitHub.com

Search results for each extension:

.hhi : https://github.com/search?utf8=✓&type=Code&ref=searchresults&q=extension%3Ahhi+hh
.hack : https://github.com/search?utf8=✓&type=Code&ref=searchresults&q=extension%3Ahack+hh

[x] I have included a real-world usage sample for all extensions added in this PR:

Sample source(s):

Kernel.hack
EmptyPipelineException.hack

Sample license(s): MIT

@pchaigno i have removed the .hck extension, also i didn't add heuristic changes as the .hack and .hhi extensions are not used by any other language

cc @pchaigno

Usage for the .hhi extension seems fine. I've counted 830 repositories by 746 users using Harvester and the extension:hhi hh search query.
We'll have an issue with the .hack extension however, if we merge this pull request as-is. There are plenty of .hack files that contain just zeros and ones which will be classified as Hack with this pull request. I don't know what these files are. Either we can identify them and classify them as their own (data?) language, or we'll need to remove the .hack extension from Hack for the moment.

@pchaigno
Problems with .php extension :
currently its hard to detect hack files that use .php extension, for example i noticed that today my repository was reporting 11% hack, when its a pure php app. the issue was that some .php files contained only HTML, since there's no <?php, linguist detects them as hack.
see : https://github.com/azjezz/web-php-mock-ups
Problems with .hh extension :
hh files used to be detected as c++ header files, but since we added a heuristic rule last time to check for <?hh it was fixed.
the issue here is that hack is not planning to keep the <?hh tag after hhvm 4.0
Solution :
.hack seems to be the only reasonable solution.
there's no other language using this extension, makes it easy to detect ( note: there's no <?hh tag in .hack files )
Solution for 01 files
the solution would be to  identify them and classify them as their own (data or binary) language.

cc @fredemmott

We’ve not yet announced support for .hack files - an while the support was committed, it is about to change, and these pull request examples will no longer be considered valid - as of next monday’s release, having any ‘<?’ token in a .hack file is a syntax error. They’re always strict mode.

@fredemmott i suggested these examples before we discussed the <?hh tag in .hack files :stuck_out_tongue: i have removed the <?hh tag.

Just for context: the existing .hack files are almost overwhelmingly going to be from solutions to the Nand2Tetris course, a popular MOOC for computer science (I recommend it!). .hack is a "compiled" machine code format for the fictitious CPU that students implement. As such, it's not a language that can be syntax-highlighted in any meaningful way. The content of those files are ASCII 1's and 0's, plus whitespace.

Thank you all for the information!
I've checked 2817 .hack files from the extension:hack<PHONE_NUMBER>010000 OR<PHONE_NUMBER>000000 search query using Harvester and found 931 repositories among 918 users. It's enough to add support for that second language. Once we've added that language, it shouldn't be hard to distinguish between the two with 100% accuracy :-)
@jeffomatic Any idea what we should name it? Looks like the official name is Hack, so maybe "Nand2Tetris Hack"?

@fredemmott i suggested these examples before we discussed the <?hh tag in .hack files  i have removed the <?hh tag.

We try to follow usage and not specifications in Linguist. If one language says some syntax is illegal but a large number of users still rely on that syntax, we'll try to support it. So I'm not sure we should remove the tags here. The best thing would be to preserve the sample files in their original form.

We try to follow usage and not specifications in Linguist. If one language says some syntax is illegal but a large number of users still rely on that syntax, we'll try to support it. So I'm not sure we should remove the tags here. The best thing would be to preserve the sample files in their original form.

There's definitely not a large number of users; Hack uses a of variant PHP-style autoloading, and no release of the autoloader supports the .hack extension at all - and it's only been in master since Jan 15th. Any usage of <?hh is extremely early adopters running a locally patched version or master from the last two weeks - as far as I'm aware, it's just @azjezz.

Though, <?hh should remain supported in .php, .hh, .hhi files etc.

@fredemmott the .hack files in @nuxed were generated using hh-to-hack so they don't use <?hh already

@jeffomatic Any idea what we should name it? Looks like the official name is Hack, so maybe "Nand2Tetris Hack"?

I think that's fine. It is pretty unlikely that anyone would intentionally configure a language context for these files since they are far closer to binaries than they are human-consumable text.
Caveat that I don't speak for the Nand2Tetris project or community in any real way other than having gone through the course as a hobbyist.

Thanks @jeffomatic!
@azjezz - Could you add the Nand2Tetris Hack language to Linguist in this pull request as well, with a heuristic to disambiguate between the two .hack language? I think we can probably add Nand2Tetris as a data language.
Something along the lines of:
- extensions: ['.hack']
  rules:
  - language: Nand2Tetris Hack
    pattern: ^[01]+$
  - language: Hack

should be enough.

@pchaigno done :+1:

My guess would be that the tests are failing because the tokenizer is unable to extract tokens from the Nand2Tetris hack sample file. If that's the case, we'll probably need to adapt the tokenizer or add an exception mechanism. I have found time to debug this yet.

@pchaigno if the Nand2Tetris files are only ones and zeroes (and unlimited whitespace), then there are no real tokens. This language is not read as source code. Would it be okay if I did something dirty and just specified the token definition as "Each byte is the start of a new token"? Would this somehow cause something unrelated to break? I would like to have syntax highlighting in hack files, so sorry for not prioritising the Nand2Tetris hack format more.

@pchaigno Are we following the route of not requiring tokenizers. Tokenizing such files is rather pointless, since there are no tokens. Hack code is being used in dothack files in many more places than it was at the release of HHVM4. This leaves entire repositories as black text on GitHub.

cc @pchaigno, any updates here ? after #4544 , the .hack files syntax is "highlightable" when using a gitattribute override to classify .hack as Hack.
example : .gitattribute / Translator.hack

Wow! How did I miss this one for so long. Sorry folks.
Support for the .hack extension has now been added in https://github.com/github/linguist/pull/4588 and we completely forgot about the Nand2Tetris files. I don't think anyone has noticed... or really cares about those files being identified as Hack (famous last words 😆) so lets update this branch and change it to only add support for the .hhi extension.

@lildude i myself forgot about this PR :)
i have update this PR to only address .hhi extension.


Sprite does not fill the screen like Windowed if it is in Fullscreen mode

I need Sprite to fill the entire screen like it did in windowed mode, with the spacing at the top and bottom as you can see in its screenshot in windowed mode.
My problem is that I can't make it look the same as it is in windowed mode except fullscreen, if I increase the size it will go over the limits in windowed mode and it's fine in fullscreen mode.
I expected this result from the size:

But it didn't turn out the way I wanted:

The code I'm using to call Sprite:
// I am using C# 9

public class PacmanMaze : CompositeDrawable
{
    private Sprite mazeSprite;
    [BackgroundDependencyLoader]
    private void Load(NearestTextureStore textures)
    {
        var mazeTexture = textures.Get(@"maze");
        AddRangeInternal(new Drawable[]
        {
            mazeSprite = new()
            {
                Anchor = Anchor.Centre,
                Origin = Anchor.Centre,
                Texture = mazeTexture,
                Size = mazeTexture.Size * 3
            }
        });
    }
}

I called PacmanMaze for the hierarchy like this:
// I am using C# 9

AddRangeInternal(new Drawable[]
{
    maze = new()
    {
        Anchor = Anchor.Centre,
        Origin = Anchor.Centre,
    },
    scoreText = new()
    {
        Anchor = Anchor.TopLeft,
        Origin = Anchor.Centre,
        Text = "SCORE: 0",
        RelativePositionAxes = Axes.Both,
        X = 0.07f,
        Y = 0.05f
    }
});

Seems like you're looking for DrawSizePreservingFillContainer, which is explained in https://github.com/ppy/osu-framework/wiki/Coordinate-and-Layout-System#scaling-absolute-values-to-screen-size.

Exactly what I was looking for! I haven't read this topic in the documentation, I'm going to make a point of reading it. Thanks!


increase the unicorn worker count to 4

This commit increases the number of unicorn workers from 2 to 6 per instance. This allows more requests to be handled simultaneously. This affects proper finders and advanced search and should make them able to handle larger numbers of unique requests at the same time
Testing
This was tested using gatling on staging. In general it has helped to lower the upper limits of response time. The following screenshots were from data following tests involving ~5k requests using about 500 unique URL's
Before

After

The results looks good!
Ideally, this would be done in Puppet to enabling configuring the number of unicorn workers per environment. For example, the way we configure it for government-frontend:
https://github.com/alphagov/govuk-puppet/blob/f182779c220fa0855a883164056843dab69cd3d4/hieradata_aws/common.yaml#L490

@JonathanHallam Yeah, I think it's fine to assume that. Doing govuk::apps::finder_frontend::unicorn_worker_processes: '4' is equivalent to worker_processes 4.

@thomasleese Awesome, thanks, will close this off. https://github.com/alphagov/govuk-puppet/pull/8431


Weekly Report 2024-12-5

This week, I worked on only having the logged-in homepage show when someone's logged in, having the navigation bar toggle depending on login status, and creating logout functionality.

I worked on getting our app to deploy to Google Cloud and moving courses needed data up to the main branch

This week I worked through a few errors with our registration and added new features to our registration validation. I also started updating a few of our documentation so that we are up to date.


PR to fix matrix questions importing without choices

Many fixes here!

Now matrix questions import with choices
SBS matrixes also import with choices (phew that was a mess)
various bugs

NOTE: i've added a warming when a question type does not have a function associated with it. The code still runs but for instance there is no function for open text questions and "questions" that really are just text on the form itself not a true question. These don't need additional processing so it's ok for now.. but i'd like to continue to test until i'm 100% confident that indeed we don't need additional functions for these question types.

this presents a HUGE rebuild of the plotting functionality.
now SBS are handled a bit better if factors are on and choicses differ it returns a nice list with factors applied to each DF which represents a unique matrix in the sbs matrix.
to do:: update vignettes to represent the new functionality!! and test test test

waahhhh living on the edge and merging this puppy. time for a bit more testing...


Enable stateful QUIC 0-RTT in streamer server

Problem
0-RTT connections are not working on QUIC ports. 0-RTT connections reduce back and forth of packets required to be exchanged with clients. TPU ports are ideal candidates for stateful 0-RTT, as replay attacks are mitigated by state storage.
Summary of Changes
Add early data flag to allow clients to send early data
Add session storage to store session identifiers (10,000 initial - open to change, it takes up 640k in memory).
Set default ticket per connection to 1 to minimise storage use
Added test to check that 0-RTT is supported by server configuration
Added half-rtt flag, not necessary given uni-directional streams
Note: Early data flag being set to 2^32 is only a sentinel value as per 4.6.1 of RFC9001, as it is the TLS early data (which QUIC does not use). Actual maximum is 1232 from PACKET_DATA_SIZE being set as stream_receive_window.
Fixes #
#1726

No results as yet, will write up a test to look at packets with/without and get back to you.


Only check tiles with matching key in forEachLoadedTile

Ensure that only tiles with the same key as the source are considered
loaded to avoid previously loaded tiles associated with another key
(different style or dimension value) being shown.
Partial fix for #9135 (1 of 2)

@ahocevar moving the check to the canvas renderer's isDrawableTile works great and actually fixes both issues detailed in #9135.
I've updated the test map with my changes: https://wms-tiled-switch-style-ftnomtn6m.now.sh/
However it also effectively disables interim tiles, hence the test failures...
I think I understand the idea behind interim tiles (attempt to improve perceived performance by reusing previously loaded tiles) but in practice they appear to produce undesirable results in a lot of cases. Maybe interim tiles should be made optional and maybe default to disabled?


Create a logout route

Create a logout route

[ ] Delete all the refreshToken link to this user in the db

Done in https://github.com/RomainGuarinoni/findAMusician/commit/5fc67741f33ae63f32f87e88b8751baef1d782a0


Trackers without width or height properties defined in the  element

I emailed you a sample of one of these:
<IMG alt="" hspace="0" border="0" src="https://example.org/smtp.mailopen?id=21835077" />
(I redacted the domain with example.org)
Pretty sure it's a tracker as it has what appears to be a unique identifier and returns a GIF image 1 px x 1 px. However, neither the width nor height properties of the <img /> element are defined.
Is this a way for trackers to get around the heuristic for identifying them?

Yep. These ones are a bit trickier.
I spotted a similar link in this mail of this mailing list. The thing these sites have in common is that they're run on this site called Blackbaud. So going to list it under there for now.
Thanks!


[main] Upgrade to latest dependencies

Cron -knative-prow-robot
/cc knative-sandbox/networking-wg-leads
/assign knative-sandbox/networking-wg-leads
Produced by: knative-sandbox/knobots/actions/update-deps
Details:
bumping knative.dev/networking 5521a8b...afa7648:
  > afa7648 upgrade to latest dependencies (# 435)
  > c743329 Add configuration to override internal and external scheme (# 434)
bumping knative.dev/pkg 0e61d67...c1db741:
  > c1db741 upgrade to latest dependencies (# 2148)
  > f19eef1 Update actions (# 2142)
bumping knative.dev/hack de04b70...e35bcb8:
  > e35bcb8 Rollback random GOBIN and make it relative to GOPATH again (# 73)
  > 1c52c48 Skip GOPATH hacks if the repository is already on GOPATH (# 72)

/lgtm
/approve


Error after upgrading from 3.6.0 to 3.6.1

ERROR in ./resources/css/vendor.css
Module build failed (from ./node_modules/mini-css-extract-plugin/dist/loader.js):
ModuleBuildError: Module build failed (from ./node_modules/postcss-loader/dist/cjs.js):
TypeError: Cannot read properties of undefined (reading 'some')
    at /Users/gr4376/Projects/webtrees/node_modules/bootstrap/dist/css/bootstrap.min.css:1:1
    at AtRule.some (/Users/gr4376/Projects/webtrees/node_modules/postcss/lib/container.js:267:23)
    at H (/Users/gr4376/Projects/webtrees/node_modules/postcss-rtlcss/index.js:1:5660)
    at /Users/gr4376/Projects/webtrees/node_modules/postcss-rtlcss/index.js:1:17440
    at /Users/gr4376/Projects/webtrees/node_modules/postcss/lib/container.js:55:18
    at Root.each (/Users/gr4376/Projects/webtrees/node_modules/postcss/lib/container.js:41:16)
    at Root.walk (/Users/gr4376/Projects/webtrees/node_modules/postcss/lib/container.js:52:17)
    at /Users/gr4376/Projects/webtrees/node_modules/postcss-rtlcss/index.js:1:17279
    at Object.Once (/Users/gr4376/Projects/webtrees/node_modules/postcss-rtlcss/index.js:1:17533)
    at LazyResult.runOnRoot (/Users/gr4376/Projects/webtrees/node_modules/postcss/lib/lazy-result.js:337:23)
    at LazyResult.runAsync (/Users/gr4376/Projects/webtrees/node_modules/postcss/lib/lazy-result.js:393:26)
    at processResult (/Users/gr4376/Projects/webtrees/node_modules/webpack/lib/NormalModule.js:751:19)
    at /Users/gr4376/Projects/webtrees/node_modules/webpack/lib/NormalModule.js:853:5
    at /Users/gr4376/Projects/webtrees/node_modules/loader-runner/lib/LoaderRunner.js:399:11
    at /Users/gr4376/Projects/webtrees/node_modules/loader-runner/lib/LoaderRunner.js:251:18
    at context.callback (/Users/gr4376/Projects/webtrees/node_modules/loader-runner/lib/LoaderRunner.js:124:13)
    at Object.loader (/Users/gr4376/Projects/webtrees/node_modules/postcss-loader/dist/index.js:142:7)

1 ERROR in child compilations (Use 'stats.children: true' resp. '--stats-children' for more details)
webpack compiled with 2 errors

My knowledge of npm build tools is fairly weak, so I'm not sure how to produce a minimal test case.
The problem is reproducable with my open-source project, if that helps - fisharebest/webtrees...

git clone, npm install, npm run production - works OK
Edit package.json to update from 3.6.0 to 3.6.1.  npm install, npm run production - error as above.

Hi @fisharebest,
No worries, your repo could help me to fix the issue. You can skip this version for now, it doesn‘t bring any feature, it only cleans better the final CSS code. I will try to debug it and fix it and I‘ll let you know when it is solved.
Regards.

Hi @fisharebest,
The bug has been solved in version 3.6.2.
Regards!

3.6.2 works for me.  Thanks for the quick fix!


Demonstrate null scanning issue

The example creates a database then a table with two columns:
ID and Value.
I add rows, ID is sequential, value is either ID or NULL:

ID: 1, Value: NULL
ID: 2, Value: 2
ID: 3, Value: NULL

Then I use gorm's scanrows to scan the data into the same struct, I would expect that for odd rows value will be 0, for even rows value will match ID.
Starting from v1.25.1 this is not the case, and Null columns are just ignored.
Usage
Just execute test.sh to run it against different versions of gorm.
See testlog for run results.
Run results
Testing with gorm v1.23.9
gorm-v1.23.9:PASS
Testing with gorm v1.24.6
gorm-v1.24.6:PASS
Testing with gorm v1.25.0
gorm-v1.25.0:PASS
Testing with gorm v1.25.1
gorm-v1.25.1:MISSMATCH: id=3 value=2 expected_value=0
gorm-v1.25.1:MISSMATCH: id=5 value=4 expected_value=0
....

Due to the depency changes, I haven't created a test, but based on the code it should be pretty straightforward.


NaN in cov & cov?

Is your feature request related to a problem? Please describe.
Could cov & corr ignore missing values?
Describe the solution you'd like
Currently any NaN in an dimension over which cov / corr is calculated gives a NaN result:
In [1]: import xarray as xr
   ...: import numpy as np
   ...: da = xr.DataArray([[1, 2], [1, np.nan]], dims=["x", "time"])
   ...: da
Out[1]:
<xarray.DataArray (x: 2, time: 2)>
array([[ 1.,  2.],
       [ 1., nan]])
Dimensions without coordinates: x, time

In [2]: xr.cov(da,da)
Out[2]:
<xarray.DataArray ()>
array(nan)

That's explained here as:
    # 4. Compute covariance along the given dim
    # N.B. `skipna=False` is required or there is a bug when computing
    # auto-covariance. E.g. Try xr.cov(da,da) for
    # da = xr.DataArray([[1, 2], [1, np.nan]], dims=["x", "time"])
    cov = (demeaned_da_a * demeaned_da_b).sum(dim=dim, skipna=False) / (valid_count)

Without having thought about it for too long, I'm not sure I understand this, and couldn't find any discussion in the PR. Adding this diff seems to fail tests around NaN values but no others:
diff --git a/xarray/core/computation.py b/xarray/core/computation.py
index 1f2a8a8e..1fc95fe1 100644
--- a/xarray/core/computation.py
+++ b/xarray/core/computation.py
@@ -1256,7 +1256,8 @@ def _cov_corr(da_a, da_b, dim=None, ddof=0, method=None):
     # N.B. `skipna=False` is required or there is a bug when computing
     # auto-covariance. E.g. Try xr.cov(da,da) for
     # da = xr.DataArray([[1, 2], [1, np.nan]], dims=["x", "time"])
-    cov = (demeaned_da_a * demeaned_da_b).sum(dim=dim, skipna=False) / (valid_count)
+    cov = (demeaned_da_a * demeaned_da_b).sum(dim=dim, skipna=True, min_count=1) / (valid_count)
+    # cov = (demeaned_da_a * demeaned_da_b).sum(dim=dim, skipna=False) / (valid_count)

     if method == "cov":
         return cov

Does anyone know off-hand the logic here?

Closed by #4351


Make specific app float rule dosen't work

# float apps
yabai -m rule --add app="Wechat.app" sticky=on layer=above manage=off
yabai -m rule --add app="Eudic.app" sticky=on layer=above manage=off
yabai -m rule --add app="NeteaseMusic.app" sticky=on layer=above manage=off
yabai -m rule --add app="IINA.app" sticky=on layer=above manage=off
yabai -m rule --add app="QQ.app" sticky=on layer=above manage=off
yabai -m rule --add app="Nutstore.app" sticky=on layer=above manage=off

this is my yabairc config , after resart, this about apps still not float

Try to remove the extension, i.e., ".app" in each command, and they will work. The application name is the name without ".app". You can check the application name from the macOS menu bar next to the apple symbol ().

The simples way is to use the yabai query system:
yabai -m query --windows

Write a regex that matches the value of the app attribute.

thinks,my system is Chinese I should use the chines word instend of english
yabai -m rule --add app="微信" sticky=on layer=above manage=off
works fine


Include pure python wheel in the release

What should we add?
I am working on a project that requires the pure python wheel to be available on the build. Currently I don't see the wheel here which would be a *py3-none-any.whl file.
While I can certainly do it as a custom build for myself, was wondering if that's something we can add? is there anything preventing us from adding that to the build pipeline?

I'm not quite sure what you're asking for here: there is no pure-Python version of Qiskit. We've had compiled extensions as part of the core distribution for nearly as long as the package has existed.

If you mean the source, so you can build it yourself, we package the sdists as .tar.gz archives on PyPI. You'll need a functional Rust compiler (language version 1.70+) to build, but all the package sources are in the sdist.

@jakelishman oh right it makes sense then. Yeah I was thinking maybe there's a possibility of having the core python module wheels but it seems that's not how things are designed. closing issue. thx.


Removed src1 != 0 constraint for cbld

This came up in a discussion. src1 != 0 would lead to an exception, which is not desired in this case. This will close #222.

@arichardson I edited the note to more be expressive after you have already had approved the PR. So you might want to take a look again.

is there an issue for this one? I think it's better to have one.

@tariqkurd-repo I have created an issue, linked it, and fixed the wording.


Don't include all rgws in ceph conf

Bug Report
What happened:
In deploying rgw it will add all rgw hosts to ceph conf. It seems to be okay but when you run ansible with --limit it will add just the limitations and when you can't run ansible on all your nodes at a same time, each node will have different and messy ceph conf.
What you expected to happen:
Won't it better to no loop on rgws host here and just add each host config to it's ceph conf?
https://github.com/ceph/ceph-ansible/blob/master/roles/ceph-config/templates/ceph.conf.j2#L108
I mean for example host1 just have client.rgw.host1 config instead of having both host1 and host2?
This loop was added to solve #49 but I think it could be solve without loop on rgw instances!
How to reproduce it (minimal and precise):
deploy rgw with --limit on one or two hosts

@clwluvw
{% for host in groups[rgw_group_name] %} means we are iterating over all rgw nodes whatever we run with --limit or not so I'm not sure how you end up with a ceph.conf including only nodes included in --limit

@guits I'm using ansible 2.9.9 and it just pick rgws that included in --limit. Can you test it please?

@clwluvw see below:
site.yml:
- hosts: mons
  become: false

  tasks:
    - name: test
      debug:
        msg: "{% for host in groups['mons'] %} {{ hostvars[host]['ansible_hostname'] }} {% endfor %}"

hosts:
[mons]
mon0 ansible_host=mon0
mon1 ansible_host=mon1
mon2 ansible_host=mon2
mon3 ansible_host=mon3
mon4 ansible_host=mon4

running with ansible-playbook -i hosts site.yml --limit mon0,mon1 :
TASK [test] *************************************************************************************************************************************************************************
Friday 24 July 2020  08:22:58 +0200 (0:00:00.130)       0:00:05.958 ***********
ok: [mon0] =>
  msg: ' mon0  mon1  mon2  mon3  mon4 '
ok: [mon1] =>
  msg: ' mon0  mon1  mon2  mon3  mon4 '

PLAY RECAP **************************************************************************************************************************************************************************
mon0                       : ok=3    changed=0    unreachable=0    failed=0    skipped=0    rescued=0    ignored=0
mon1                       : ok=3    changed=0    unreachable=0    failed=0    skipped=0    rescued=0    ignored=0

$ ansible-playbook --version
ansible-playbook 2.9.9

@guits I know and I see this behavior in set_fact monitor_name ansible_hostname task but in that loop it just pick --limit rgws. Maybe I should run this before deploying? Did you try with deploying rgws and get the same?
- name: gather and delegate facts
      setup:
      delegate_to: "{{ item }}"
      delegate_facts: True
      with_items: "{{ groups['all'] | difference(groups.get('clients', [])) }}"
      run_once: true
      when: delegate_facts_host | bool

@guits Also thanks for this PR #5587. This is more reasonable than including all rgws in ceph conf.

@clwluvw I've tried with same conditions and I'm still unable to reproduce.
anyway, I've sent #5587 which should address your issue...

@guits Yes it's okay. I'm really happy with your PR. I'll be wait for stable-4.0 backport. Thanks.

@guits Do you have any due date for backport it to stable-4.0?

@clwluvw I need to figure out a couple of details before merging it to master first, then the backport to stable-4.0 should follow pretty quickly.
I can't give you an accurate due date for now but it shouldn't be that long.
Thanks for your patience!

closed by #5587


Change date field format in classified tweets.

We added a date field in the classified tweets but the kibana doesn't understand the format, we need to change the format to the right one.

PR #34 for adding a schema to the elasticsearch index


Improve logging in the rewards app

see: https://github.com/charmbracelet/bubbletea#logging-stuff
(would make my life a lot easier...)

Implemented in https://github.com/chowder/ttv-cli/commit/38b90c55ad8cde38fc41c02832120dcf65a176c5


change title on README

MY COMMENT...

You can play the game at: https://laureleze.github.io/github-games/


Extension README's do not support text selection via touchpad on macOS

Lapce Version
Version 0.3.1 (1)
System information
macOS 14.1.2 (23B92)
Describe the bug
The README's displayed when you select an extension do not support text selection via touchpad on macOS (I haven't tried with a mouse, maybe that works). Since they often include command for installing a language server, this makes it significantly more difficult to follow the instructions.
Additional information
Similar to https://github.com/lapce/lapce/issues/3049
If this is touchpad specific, maybe touch event handlers aren't registered?

Duplicate of https://github.com/lapce/lapce/issues/2306


Test execution log

Hello,
I would like to know if it is possible to kwon the tests results for all the test suite, not just the fail tests.
Thanks,
Laura

Hi Laura (@laurabrzmeyer ),
Can you please provide an example of what output you are looking for?
Specifically:

What command are you executing?
What is the observed output?
What is the proposed/desired output?

Thanks,
René

Hello René,
I've already resolved the problem, I was using the wrong command.
Thank you for your answer,
Laura


Trigger a CloseAccount API when an account request is deleted

When deleting a Terraform AFT account request (https://github.com/MLaunch/terraform-aft-account-request/commit/8a7400d4e8c6c337aef713d04e3e38a2b7a3105b) a CloseAccount API call should be made to AWS Organizations to close the same account (https://docs.aws.amazon.com/organizations/latest/APIReference/API_CloseAccount.html)

Thanks @billwell-amzn for the suggestion! The CloseAccount API does not allow for de-registration of accounts at the scale we need. We do have a backlog for more automation of the delete lifecycle of AFT, as this is an area we'd like to improve.

Pay attention .. you must first unenroll it.
Double check what is the right workflow to correctly decommission an AFT created account.
(account email would be lost forever for example, maybe you would change it first)


[recipes] Auto roller failing

https://ci.chromium.org/p/flutter/builders/prod/recipe-deps-roller
It's been failing since February. The error message is too large to fit on my chrome browser

Triggering a manual roll.

https://flutter-review.googlesource.com/c/recipes/+/28352


fn apps list broken

Just installed fn & the fn cli.  When I run "fn apps list" I get the following error:
$ fn apps list
ERROR: Path not found: /apps
$ fn version
Client version:  0.4.73
Server version:  0.3.422

Can you post please more details:

Which OS?
What’s in FN_API_URL env var?
Was Fn able to start successfully? (Try curl -v <fn-endpoint>:<fn-port>/v1/apps)

MacOS Sierra version 10.12.6 (is where the cli is installed)
Don't want to give my endpoint but:
curl -v $FN_API_URL/v1/apps

Trying xxx.xx.xx.xx...
TCP_NODELAY set
Connected to xxx.xx.xx.xx (xxx.xx.xx.xx) port 80 (#0)

GET /v1/apps HTTP/1.1
Host: xxx.xx.xx.xx
User-Agent: curl/7.54.0
Accept: /

< HTTP/1.1 200 OK
< Content-Length: 73
< Content-Type: application/json; charset=utf-8
< Date: Fri, 20 Apr 2018 22:05:58 GMT
<

Connection #0 to host xxx.xx.xx.xx left intact

confirmed this is happening for me also.... regression -- need fix and test asap
/private/tmp
❯ fn version
Client version:  0.4.73
Server version:  0.3.421

/private/tmp
❯ fn apps list
ERROR: Path not found: /apps

weird, i can't repro this one

built from source:
cli(master): ./cli version
Client version:  0.4.73
Server version:  0.3.422
cli(master): ./cli apps list
no apps found

cli(master): echo $FN_APP_URL

cli(master):

could you paste yours? i expect this is it, mine is blank.

actually same bug both locally and on current api.fnservice.io service which was deployed last night.
❯ echo $FN_API_URL
http://localhost:8080

mhmm, that's it:
cli(master): FN_API_URL=http://localhost:8080 ./cli apps list
ERROR: Path not found: /apps
cli(master): ./cli apps list
no apps found

can fix shortly

thanks. whatever this is broke a bunch of commands -- not sure how it passed tests?
~/workspace/hello
❯ fn routes l myapp
ERROR: Path not found: /apps/myapp/routes


docs(v2): refactor Chinese translations

refactor introduction
refactor getting started

The CI is failing, quite possibly because of broken links. Could you fix it?

The CI is failing, quite possibly because of broken links. Could you fix it?

Thanks, what else should I do? Looks like I have to run the script dart ./src/outdated_docs_generator.dart before committing.

The CI is failing, quite possibly because of broken links. Could you fix it?

Hi, thanks! Before proceeding, want to know if it means that I missed some JSX components, inside the getting_started folder? Or do you mean the url links inside the markdown contents?

The failing CI steps should contain logs about whatever the problem is. Have a look at it :)

The failing CI steps should contain logs about whatever the problem is. Have a look at it :)

Yeah I know, it failed firstly due to the outdated_translations JS file before you added changes.
But right now the netlify deploy logs are not clear to me,
Build failed due to a user error: Build script returned non-zero exit code: 2 without further info.
4:54:15 PM:   "build.command" failed
4:54:15 PM: ────────────────────────────────────────────────────────────────
4:54:15 PM:
4:54:15 PM:   Error message
4:54:15 PM:   Command failed with exit code 1: npm run build (https://ntl.fyi/exit-code-1)

Or did I miss something?

True, the logs aren't very helpful actually.
You could try running npm run build locally to reproduce the error.

@rrousselGit not sure what's the issue here, maybe check out this https://github.com/actions/checkout/issues/417, the site is fine built locally.

Restarting the CI fixed it.
Thanks a lot for your work! :)


[FEAT]: Whatsapp integration

What would you like to see?
Integration with whatsapp business.
Using other chatbots I saw a very interesting feature: being able to integrate with whatsapp business and chat with final user

This can now be done with custom agent skills https://docs.anythingllm.com/agent/custom/introduction


400 error returned when creating data.dynatrace_entity

Describe the bug
We would like to create a new data.dynatrace_entity.
data "dynatrace_entity" "component" {   type = "SERVICE"   name = "@component/xyz" }
But this input gives Error: status code 400 (expected: [200]): <!doctype html><title>HTTP Status 400 – Bad Request</title>
HTTP Status 400 – Bad Request

When calling the Dynatrace API manually everything works as expected.
Provider version : 1.30.0
To Reproduce
Steps to reproduce the behavior:

Create a new tf file containing the previous input
Apply terraform

Expected behavior
200 code should be returned
Desktop (please complete the following information):

OS: Windows 10 Enterprise
Browser : chrome
Version : 21H2

Hi,
Thank you for the quick response. I see that in the err.log file we get :
2023/06/21 18:03:14 GET https://[...]/api/v2/entities?pageSize=4000&entitySelector=type("SERVICE")&fields=tags 2023/06/21 18:03:14    400 <!doctype html><title>HTTP Status 400 – Bad Request</title>
HTTP Status 400 – Bad Request

Same error occurs when upgrading the version unfortunately.

@TheLooostOne, that specific response is not coming from the Dynatrace REST API. Is it possible that an Apache based proxy server is sitting in between the host that runs Terraform and the Dynatrace Cluster? The CSS code within the response makes me thing so, simply because of the formatting.
The next release of the provider will contain a small change when it comes to url encoding the parameter entitySelector.
But you can as a matter of fact test this out right now with v1.33.0. Instead of this syntax
data "dynatrace_entity" "component" {
  type = "SERVICE"
  name = "@component/xyz"
}

just use the entity_selector attribute.
data "dynatrace_entity" "component" {
  entity_selector = "type(SERVICE),entityName.equals(@component/xyz)"
}

In that case the request would already look slightly different.
Are you getting different results here?

@Dynatrace-Reinhard-Pilz Thank you for this suggestion, this solved our problem :)

Please leave a message in case there are open question, and we'll re-open the ticket.


Email notifications about new places (User settings)

As a registered user I want to receive email notifications about newly added places to the map, so that I have the up-to-date information.
Mockups:
1

2

Acceptance Criteria:

In User settings system shall display "Email Notifications" element, which shall have radio buttons
a. Yes
b. No

"No" shall be selected by default.

Provided "Yes" is selected in "Email Notifications", system shall display element "Frequency" below the "Email Notifications".

"Frequency" element shall have radio buttons
a. Immediately
b. Daily - shall be selected by default
c. Weekly
d. Monthly

Provided user selected "Yes" in the email notifications, system shall send and email to user, with notification that a new place has been added to the map (i.e. approved places by admin).

Email notification for Immediate notifications shall be of the following pattern:
"Dear [user_first_name],
a new [category] place [NAME_OF_PLACE] has just been added to Green City."
(e.g. "Dear Yurii,
a new Food place "Delikateka" has just been added to Green City.")

Email notification for Daily, Weekly, Monthly notifications shall be of the following pattern:
"Dear [user_first_name],
new [category] place(s) have been added to Green City [yesterday/last week/last month]:
[list_of_all added places_within_the_period]"
(e.g. "Dear Yurii,
new Food place(s) have been added to Green City yesterday:
Sily Z'ily
Chelentano
Puzata Khata")

Email notifications shall be sent per following pattern
a. Immediately - an email shall be sent to user(s) as soon as a new place is added to the map (approved by admin)
b. Daily - a daily summary email, which shall include all places added within the previous day, shall be sent to user(s) every day at 12:00 (PM).
(e.g. on Tuesday at 12:00 (PM) an email shall be sent to user(s), which shall include all places added to the map (approved by admin) from 12:00 PM Monday till 12:00 PM Tuesday)
c. Weekly - a weekly summary email, which shall include all places added within the previous week, shall be sent to user(s) every Monday at 12:00 (PM)
d. Monthly - a monthly summary email, which shall include all places added within the previous month, shall be sent to user(s) every 1st day of the month at 12:00 (PM)

Provided "No" is selected in "Email Notifications", system shall not display element "Frequency" below the "Email Notifications" AND shall not send notifications to user.

to ADD - no added places - no email (for daily/monthly/weekly
Assumptions and Constraints:
relates to #225

Not relevant.


Silent fail / on_data not returning data

Hi - I'm trying to build a stream listener that will respond to direct messages from an account that is both followed/a follower, however, the on_data method does not appear to be returning data that can be parsed/acted upon by the rest of the script. I've tried both overriding the method and using the super method. The follow argument in the filter method would be the Twitter id (as a string) for my personal twitter account (the script waits for a specific text from my account and then does other stuff).
import tweepy
import json
CON_KEY = "###"
CON_SEC = "###"
ACC_TOK = "###"
ACC_SEC = "###"
auth = tweepy.auth.OAuthHandler(CON_KEY, CON_SEC)
auth.set_access_token(ACC_TOK, ACC_SEC)
api = tweepy.API(auth_handler=auth)
class FirstStream(tweepy.StreamListener):
def on_data(self, data):
super().on_data(data)
json_data = json.loads(data)
print(json_data['text'])
return True
fs = FirstStream
aStream = tweepy.streaming.Stream(auth=api.auth, listener=fs())
aStream.filter(follow=['###'], track=['#python'])

P.S. One other thing that seems to be a problem is that I keep my account set to "private" - however taking off this setting does not prompt the rest of the script to run on receiving a direct message from my account.

You cannot follow a protected account in this manner. See: https://dev.twitter.com/streaming/overview/request-parameters#follow
However, if you want to follow a protected account, you can have the program run with the access key and secret attached to the protected account and use the aStream.userstream() method instead. This will return data for any tweets from that account. You can optionally set it to track whatever you like, but it will essentially only be listening to the one account.
Re: direct messages. Make sure you have the proper permissions for the application you're using, though I think this is solved by change referenced above.

I adjusted the last line to aStream.userstream(_with=['###'], track=['#gameon']) and while it will now print results, it does so regardless of whether "#gameon" is present in the Tweet. As a side note, the userstream appears to allow me to see the tweets of even a protected account although the direct messages are not visible.

This issue is now stale, since User streams have been deprecated and retired in favor of the new Account Activity API.
For Account Activity API support, see #1075.
Also see:
https://developer.twitter.com/en/docs/accounts-and-users/subscribe-account-activity/migration/us-ss-migration-guide.html
https://blog.twitter.com/developer/en_us/topics/tools/2018/enabling-all-developers-to-build-on-the-account-activity-api.html
https://blog.twitter.com/developer/en_us/topics/tools/2017/announcing-more-functionality-to-improve-customer-engagements-on-twitter.html
https://blog.twitter.com/developer/en_us/topics/tools/2017/building-the-future-of-the-twitter-api-platform.html
https://twittercommunity.com/t/details-and-what-to-expect-from-the-api-deprecations-this-week-on-august-16-2018/110746
https://twittercommunity.com/t/reminder-site-streams-user-streams-and-legacy-dm-endpoints-will-be-sunset-august-16th/109482
https://twittercommunity.com/t/building-on-site-streams-user-streams-or-direct-messages-action-required-to-preserve-and-prevent-disruption-to-your-twitter-integration/105736
https://twittercommunity.com/t/date-for-full-deprecation-of-user-streams-site-streams-and-legacy-direct-message-api-endpoints/98734
For code block usage, see https://help.github.com/articles/creating-and-highlighting-code-blocks/.


Dropdown box in new area dialog cannot be selected

Alarmo Version
v1.9.3
HA Version
2022.6
Bug description
It is not possible to click on the areas in the dropdown list.
The dropdown just closes without changing the current value.

When manually typing the name of the area it becomes selectable (workaround):

Steps to reproduce
In General -> Areas click 'ADD' to open the dialog.
Relevant log output
No response

Will be fixed by https://github.com/nielsfaber/alarmo/commit/2a3a85b5e5f954b1de0ff99f1bc045fe8b83c68c


advanced filters category

Details

This PR adds page for category filter
Fixed Issues

$https://github.com/Expensify/App/issues/46038
PROPOSAL:
Tests

visit route /search/filters

test category filter and whether navigation behaves correctly

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps
Same steps as Tests

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/user-attachments/assets/96d58983-d302-4eb3-ac8d-f43ed6e3e6b2

Android: mWeb Chrome

https://github.com/user-attachments/assets/c9979ad5-9660-4509-a8c9-a3358ac4191e

iOS: Native

https://github.com/user-attachments/assets/583e301b-afda-4d44-929c-7fbcb119e2ea

iOS: mWeb Safari

https://github.com/user-attachments/assets/d8aecae3-0ed2-4274-a458-a123323c295c

MacOS: Chrome / Safari

https://github.com/user-attachments/assets/841863fa-e92f-4a59-95f9-33932bd04984

MacOS: Desktop

https://github.com/user-attachments/assets/8a73bb2b-2c6a-4166-a4e3-39a8ea8c48d2

I have read the CLA Document and I hereby sign the CLA

@luacmartins  hey! It's ready for review

@289Adam289 TS checks are failing

All yours @ikevin127

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[ ] I verified that all the inputs inside a form are aligned with each other.
[ ] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

The only thing that I found to be off with the functionality is that once applied e.g. the Car filter does not seem to change anything in the search Expenses list compared to before applying the filter.
@luacmartins @289Adam289 If this is expected for now, and will be fixed to actually work once all filter categories are implemented then we're good to go here 🟢, but if this is supposed to work differently than in the video shown above then I think it should be fixed here before merging.

+1 to that, but otherwise from a visual perspective, this is looking good 👍

That is expected for now until this PR gets merged

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.0.16-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/marcaaron in version: 9.0.16-8 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


[x] This PR switches us to the Go module system, which makes fixing #4835 or #4380 possible (although this PR does NOT fix either of those issues)

This PR preserves all of our existing module versions. See 24524a4c7e for all modifications made to our vendored packages. The only changes in Go files are trivial comments.
4 new dependencies were added (7ea04b6b3b). Note that these are not actually new dependencies, they are previously-unvendored dependencies that only /test/router/dnssec uses:

github.com/nxadm/tail
github.com/onsi/ginkgo
github.com/onsi/gomega
gopkg.in/tomb.v1

Using Go modules means only vendoring the packages necessary to satisfy dependencies, even if that means vendoring an incomplete repo (although it always includes licenses). Before this PR, there were 106 vendored dependencies. This PR cuts it down to 40:ls -d vendor/{?[^i]*/*,github.com/*/*} | wc -l

Which Traffic Control components are affected by this PR?

CDN in a Box
Documentation
Grove
Traffic Control Client (Go)
Traffic Monitor
Traffic Ops
Traffic Ops ORT
Traffic Stats
CI tests

What is the best way to verify this PR?

Make sure Traffic Control still all builds and works
Run the various tests affected by this PR:

grove/integration_test
infrastructure/cdn-in-a-box/traffic_ops_integration_test
test/router/dnssec
tools/golang
traffic_monitor/tests
traffic_ops/app/bin/tests
traffic_ops/testing/compare

The following criteria are ALL met by this PR

[x] This PR updates tests
[x] This PR includes documentation
[x] This PR includes an update to CHANGELOG.md
[x] This PR includes any and all required license headers
[x] This PR ensures that database migration sequence is correct
[x] This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

atstccfg's toreq package now uses the standard Traffic Ops v1 client. Other than this, no Go code modifications were necessary.

That should probably be split off into its own PR which can be reviewed separately, since it's the only actual code modification in a sea of changes.

atstccfg's toreq package now uses the standard Traffic Ops v1 client. Other than this, no Go code modifications were necessary.

That should probably be split off into its own PR which can be reviewed separately, since it's the only actual code modification in a sea of changes.

Opened #a PR for the TO v1 client part and changed #5229 to a draft, blocked by #5230.

Because the toreq TO client library is now a module (seeff5e4292bd~..f75f2996fd), this PR no longer depends on #5230 and is ready for review.

ERROR: for enroller  (<Service: enroller>, '')
Service 'enroller' failed to build

Yes. The precise error is
#16 3.158 go<EMAIL_ADDRESS>parsing ../../../traffic_ops_ort/atstccfg/toreq/vendor/github.com/apache/trafficcontrol/traffic_ops/client/go.mod: open /go/src/github.com/apache/trafficcontrol/traffic_ops_ort/atstccfg/toreq/vendor/github.com/apache/trafficcontrol/traffic_ops/client/go.mod: no such file or directory

I'm struggling with what to do for that. Because traffic_ops_ort/atstccfg/toreq/vendor/github.com/apache/trafficcontrol/traffic_ops/client is now a module, it would need to be added in the case of all Docker environments that build the project using Go modules, since it is referenced in go.mod.
Moving traffic_ops_ort/atstccfg/toreq/vendor to the main vendor directory does not work with go mod vendor, because go mod vendor removes the entire contents of the vendor directory and then checks the go.mod files.
The next place to put it would be in the traffic_ops directory, but then what would we call it? older-client? v1-but-for-real-this-time-client? It makes 0 sense to me to have this package vendored at all when

traffic_ops/v1-client exists, and
We already version the Server struct in tc-lib to make this kind of thing unnecessary.

I'm re-drafting this PR until we we have a chance to talk more about how to get rid of toreq's vendor directory.

Renamed toreq's vendor directory to local because import paths cannot contain vendor/, then changed the import path to
github.com/apache/trafficcontrol/traffic_ops_ort/atstccfg/toreq/local/github.com/apache/trafficcontrol/traffic_ops/client

so the vendored TO client can stay for now without making Go modules unhappy.
Undrafted #5229

Why'd you rewrite the go-test action for this? And why does its package.json require typescript if you're not using it?

go mod resolves symlinks, which is a problem since our go-test action symlinks the workspace into the GOPATH. We can keep the Docker action, but that means cloning the project into src/github.com/apache/trafficcontrol in the workspace, instead of the workspace directory being the repo directory.
Reverted making go-test a JavaScript action in be592797c5, checking out the project in the GOPATH in 88ae20bdbe.

Rebased to resolve merge conflicts.

Rebased to resolve a merge conflict

Rebased to get the unreleased changelog section and moved the changelog entry there.

Rebased to resolve conflicts now that #5247 is merged.

Tweaked the Go module versions, including adding more replace directives in 927f73b32e. Without exception, our packages now use the exact same versions as they did before this PR, and the only new packages are the previously-unvendored dependencies of /test/router/dnssec.
This is now a pretty low-risk PR, as the changes to vendored dependencies themselves are necessarily safe and the only other changes are

Replacing go get with go mod vendor in 62b6fd53c2
Minor GOPATH adjustments for GitHub Actions in 436d258af8 and ae4dfc3b40

Rebased to fix merge conflicts from #5293

Rebased to fix merge conflicts

Rebased to include kylelemons/godebug, a dependency that was added in #5337.

Rebased to include kylelemons/godebug, a dependency that was added in #5337.

Rebased to consolidate unreleased Changed sections.

Rebased to consolidate unreleased Changed sections.


NHM District Level Data: All datasets

@pradh
PR containing all four datasets from NHM - Maternal Health, Birth Control, Child Health and General Statistics

This PR makes all the other three obsolete. Do we need state-wise data when we have district-wise? State-wise is just an aggregated dataset. I think we can close the state-wise PRs too.

This PR makes all the other three obsolete. Do we need state-wise data when we have district-wise? State-wise is just an aggregated dataset. I think we can close the state-wise PRs too.

Let us import the state-wise aggregate too.


Ghost Girl IA

All is well? Me and my friends noticed that we made friends with the IA once and after that we were never able to activate it again, can you please instruct us how to activate the ghost girl's IA. We tried everything but she never activated the IA that talks to the crew again.

I'm sorry I have no idea what IA is?

artificial intelligence sorry, i using translator

artificial intelligence sorry, i using translator

I'm still not totally sure what you are talking about I'm sorry. If possible, please write your issues in your own native language and I will do my best to find a translation/translator.

Eu e meus amigos notamos que fizemos amizade com a inteligência artificial da garota fantasma uma vez pelo terminal que transmite a mensagem na tela. Só que depois disso, nunca mais conseguimos contato com ela, quando estávamos sendo assombrados pela garota fantasma, apenas as falas normais que ela fala eram enviadas no terminal, como: Hi, I see you, Lets Play, e nada da Inteligência artificial conversar com a gente novamente. Você pode nos instruir como ativar essa inteligência artificial da GhostGirlEnhanced. Tentamos de tudo, mas ela nunca mais falou com nós

I apologize, even with someone translating your message for me I still don't fully understand what you were asking. I don't believe my mod was responsible for making the ghost girl "friendly"
And if your questions was asking about making her appear, that is part of Lethal Company itself and is usually a pretty rare event


Version 1.1.3 fails in browser - Buffer is not defined

We wanted to use the package to create hashes in Chrome, but on initial testing it seems like this package doesn't work in the browser.
When attempting to import the package it fails with the error message:
Buffer is not defined

You can see an minimal example in this Code Sandbox:
https://codesandbox.io/s/x2xyrq2plp

how are you building it, are you building it in an enviroment like browserify or webpack that adds node globals ?

With a bit more investigation it looks like the issue could be that we are using Webpack with a target of electron but I was testing the resulting bundle in Chrome. I’ll confirm if that is the problem tomorrow.
If the electron target is the problem then I’m not sure why it is failing in Code Sandbox!

Using AWS congnito, I've encountered this error after upgrade to angular and CLI v6. Still don't know how to solve that.

In case anyone is having that problem after upgrading to Angular 6 and using cognito, I've written a SO answer that might help: https://stackoverflow.com/a/50377270/2398593


Reformat code in CodeAnalysis

This reformat operation used dotnet/codeformatter@1d719e4e with /rule-:FieldNames.

This PR is out of date alredy, so I don't know what the easiest way to deal with: rebase or just close this one and reformat new stuff? @sharwell

@SergeyTeplyakov I'll update any formatting PRs that get out of date. Just let me know if/when you see them. :smile:

I'm OK to merge all of them today.

I think the only remaining are this one and #124.

@SergeyTeplyakov I updated this pull request.


Minor UI bug - Addresses are being hidden, resizing column fixes issue

In the contacts section of the wallet the column width seems to hide the details of the contact name and the address.
The fix appears to be to size the column  using larger default width values.

Column with is not a problem to adjust. But the real solution is a changing of the formatting rule. I will try to find if it can be updated

Make column wider by default, so the address will fix.
The permanent solution will be better when we start with Swaps. Also Transactions and Outputs will need to have a mobile  wallet look. We will need a special control to address that. That custom control will be used in address page as well.

Verified the Column width, hence closing this ticket.


Handing maintenance

Hi,
I needed a global maintenance handler so I tried the following:
$klein->respond(function ($req, $res) {
	if(file_exists(__DIR__ . '/../storage/maintenance'))
	{
		return $res->code(500);
	}
});

However, it still kept returning the different headers. (404)
I tried doing:
class MaintenanceException extends Exception {}
$klein->respond(function ($req, $res) {
	if(file_exists(__DIR__ . '/../storage/maintenance'))
	{
		throw new MaintenanceException;
	}
});

try {
	$klein->dispatch();
}
catch(MaintenanceException $e)
{
     dd("maintenance");
}
catch(Exception $e)
{
	$klein->app()->bugsnag->notifyError('ErrorType', $e->getMessage());
	$klein->response()->header('Access-Control-Allow-Origin', '*');
	$klein->response()->header('Access-Control-Allow-Methods', 'GET');
	$klein->response()->code(400);
	return $klein->response()->json(['message' => $e->getMessage()]);
}

The catch(MaintenanceException $e) block is never reached. (It goes into Exception catch block)
This is my onHttpError callback:
$klein->onHttpError(function ($code, $router) {
	switch ($code) {
		case 404:
			$router->response()->code($code);
			$router->response()->json(['message' => 'Requested endpoint not found.']);
			break;
		default:
			$router->response()->code($code);
			$router->response()->json(['message' => 'Oh no, a bad error happened that caused a '. $code]);
	}
});

What I want to do is:
"If a file called maintenance exists, then respond 503 headers along with {"message": "Maintenance"}, and simply stop."
I've checked the API but couldn't find anything else. (Tried locking response, looked for a http error trigger method) The behaviour seemed a little weird. Am I overlooking something?

Ah, yea, sorry. There's a few things going on here... all of which should definitely be documented better:

Your global maintenance handler is a "catch-all" route, which Klein will correctly run, but if it doesn't match any other endpoints, Klein will consider the overall request to not be matched and will return a 404 response. If you'd like to change that behavior, you can simply mark the route as one that should be counted as a match with $route_instance->setCountMatch(true) or $klein->respond(...)->setCountMatch(true);.
Your try/catch block is attempting to catch an exception that's getting wrapped. Klein's designed to allow for a stack of error handlers, all registered by the $klein->onError() method. If no error handler is registered, an UnhandledException is thrown. You can easily catch that exception, if need-be, and then grab the underlying exception using $exception->getPrevious().

If you'd like to simply show a 503 in a maintenance mode, then you could either create a subclass of HttpException (like MaintenanceException) or you could throw the HttpException class itself with a simple message and then handle the exception in the $klein->onHttpError().
Let me know if that works for you. :)
Sorry for any confusion!

Hi, thanks for the indepth explanation. I went with $exception->getPrevious way. Did a instanceof MaintenanceException and returned 503.
catch(Klein\Exceptions\UnhandledException $e)
{
	$exception = $e->getPrevious();

	if($exception instanceof MaintenanceException)
	{
		$klein->response()->code(503);
		return $klein->response()->json(['message' => $exception->getMessage()]);
	}
}

Not the best looking thing but glad it works now.
I could document this if needed, but there are probably better approaches so I'll leave it to somebody who knows core API better than me, unless you want me to add this as-is to readme.

I definitely welcome edits to the wiki. :)


SvgSupport for svg without a width and height info

Markwon version: 4.1.1

First of all, thank you for your great work!
When I want to load a SVG without a width & height set in the file, I get this exception:
MARKWON-IMAGE: Error loading image: https://upload.wikimedia.org/wikipedia/commons/d/d7/Android_robot.svg
    java.lang.IllegalArgumentException: width and height must be > 0
        at android.graphics.Bitmap.createBitmap(Bitmap.java:1033)
        at android.graphics.Bitmap.createBitmap(Bitmap.java:1000)
        at android.graphics.Bitmap.createBitmap(Bitmap.java:950)
        at android.graphics.Bitmap.createBitmap(Bitmap.java:911)
        at io.noties.markwon.image.svg.SvgMediaDecoder.decode(SvgMediaDecoder.java:70)
        at io.noties.markwon.image.AsyncDrawableLoaderImpl$1.run(AsyncDrawableLoaderImpl.java:123)
        at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:458)
        at java.util.concurrent.FutureTask.run(FutureTask.java:266)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641)
        at java.lang.Thread.run(Thread.java:764)

Most of the SVGs, I found online, were without these size information.
Is it possible to fallback to a default size for this case or is there another solution?
One example of an affected SVG: https://upload.wikimedia.org/wikipedia/commons/d/d7/Android_robot.svg

Hello @3dmg !
It's an interesting case and I haven't seen SVG without width/height so far. It seems that absent width/height just says 100% of whatever dimension is missing... and it's fine in HTML (element can be given an explicit size), but for us it's a bit of a problem. Currently we scale received SVG up by device density, which makes SVG responsive, but without width/height it seems to be impossible.
We can try rendering such SVGs without scaling, can you try this and see if it solves your problem?
public class SvgPictureMediaDecoder extends MediaDecoder {

    public static final String CONTENT_TYPE = "image/svg+xml";

    @NonNull
    public static SvgPictureMediaDecoder create() {
        return new SvgPictureMediaDecoder();
    }

    @NonNull
    @Override
    public Drawable decode(@Nullable String contentType, @NonNull InputStream inputStream) {

        final SVG svg;
        try {
            svg = SVG.getFromInputStream(inputStream);
        } catch (SVGParseException e) {
            throw new IllegalStateException("Exception decoding SVG", e);
        }

        final Picture picture = svg.renderToPicture();
        return new PictureDrawable(picture);
    }

    @NonNull
    @Override
    public Collection<String> supportedTypes() {
        return Collections.singleton(CONTENT_TYPE);
    }
}

And usage (this will replace default SvgMediaDecoder):
final Markwon markwon = Markwon.builder(context)
        .usePlugin(ImagesPlugin.create(configure -> {
            configure.addMediaDecoder(SvgPictureMediaDecoder.create());
        }))
        .build();

Yes, this is working. Thank you!
When you need it, here you find a big list of different SVGs, with and without the size info: https://dev.w3.org/SVG/tools/svgweb/samples/svg-files/

Thanks, I'm going to take a look at it and see if some generic solution can be implemented 👍

I have added SvgPictureMediaDecoder into 4.2.0 release


Doesn't work for me as expected

Captcha comes sometimes only all the other time it just validate user without opening captcha. Call did finished loading -> event next and then  Event completed -> isDisposed.
The appearance is random I am not getting any error or warnings it simply opens sometimes and everything works fine and other times it does not.
Testing on iPhone 11 Pro simulator.

@DeewaSharma I'm not sure I understood what the issue is. Please, try to follow the issue template since it was designed to help you provide the most detailed information possible.
I'll close this issue, but please, reopen it with the proper template.

@fjcaetano Thank you so much for getting back to me, seems like the issue was related to simulator on real device captcha appears just fine.
Will get back to you after testing on various other devices.


ENH: linalg: Shorter ill-conditioned warning message

Make the ill-conditioned matrix warning one-liner.  Fix the missing
space between the number and text.
Previously, the warning read
__main__:1: LinAlgWarning: scipy.linalg.solve
Ill-conditioned matrix detected. Result is not guaranteed to be accurate.
Reciprocal condition number1.000000e-19

Some issues that are addressed here: there's no space before condition number, the message is quite long, usually the warnings don't contain the function name, and usually they don't contain newlines.

Recip.number reads a bit odd, rcond might be better if we are going for an abbreviation. It is familiar enough from matlab. One of the tests is looking for an exact old phrase though.

Ok, changed to rcond instead as it's shorter.


[release-4.6] Add doc for SNAT and update offload settings to be used

This is an automated cherry-pick of #262
/assign yussufsh

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: ltccci
To complete the pull request process, please assign bpradipt after the PR has been reviewed.
You can assign the PR to them by writing /assign @bpradipt in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/lgtm
/cc @bpradipt

@ltccci: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

pull-ocp4-upi-powervs-terraform-fmt
a1f7bd2205bac6bfad1fd93cf55d1989fc17ad55
link
/test pull-ocp4-upi-powervs-terraform-fmt

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ltccci: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

pull-ocp4-upi-powervs-terraform-fmt
a1f7bd2205bac6bfad1fd93cf55d1989fc17ad55
link
/test pull-ocp4-upi-powervs-terraform-fmt

pull-ocp4-upi-powervs-terraform-lint
a1f7bd2205bac6bfad1fd93cf55d1989fc17ad55
link
/test pull-ocp4-upi-powervs-terraform-lint

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: bpradipt, ltccci, yussufsh
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [bpradipt,yussufsh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


error during migration 6 (Update DB Schema for cumulative account reward support and creation dates.)

Summary
I am upgrading the indexer from 2.3.0-beta2 to 2.3.3 and the migration failes
Error
Apr 23 01:57:53 algorand-1 systemd[1]: Started Algorand Indexer daemon.
Apr 23 01:57:53 algorand-1 algorand-indexer[7146]: Using configuration file: /var/lib/algorand/indexer.yml
Apr 23 01:57:53 algorand-1 algorand-indexer[7146]: {"level":"info","msg":"Running 7 migrations.","time":"2021-04-23T01:57:53Z"}
Apr 23 01:57:53 algorand-1 algorand-indexer[7146]: {"level":"info","msg":"Setting status: Active migration: Update DB Schema for cumulative account reward support and creation dates.","time":"2021-04-23T01:57:53Z"}
Apr 23 01:57:53 algorand-1 algorand-indexer[7146]: {"error":"pq: column \"rewards_total\" of relation \"account\" already exists","level":"error","msg":"migration 6 sql[0] err","time":"2021-04-23T01:57:53Z"}
Apr 23 01:57:53 algorand-1 algorand-indexer[7146]: {"error":"error during migration 6 (Update DB Schema for cumulative account reward support and creation dates.): pq: column \"rewards_total\" of relation \"account\" already exists","level":"error","msg":"Migration failed","time":"2021-04-23T01:57:53Z"}
Apr 23 01:57:53 algorand-1 algorand-indexer[7146]: {"level":"info","msg":"Setting status: error during migration 6 (Update DB Schema for cumulative account reward support and creation dates.): pq: column \"rewards_total\" of relation \"account\" already exists","time":"2021-04-23T01:57:53Z"}
Apr 23 01:57:53 algorand-1 algorand-indexer[7146]: {"level":"info","msg":"Initializing block import handler.","time":"2021-04-23T01:57:53Z"}

In the release notes there are no instructions what needs to be done. Anything we can do?
Thanks,
bert

@bert2002 I'm sorry to inform you, but unfortunately, the 2.3.0-beta releases are not compatible with 2.3.2 or 2.3.3. You'll need to start over with a new database. This is mentioned in the release notes under Known Issues.


ctrl+plus as change font size messes with telnet

Windows Terminal version
1.15.2875.0
Windows build number
10.0.22000.0
Other Software
Microsoft Telnet-Client
10.0.22000.708
Steps to reproduce
With telnet installed and german keyboard layout or any that have ctrl+plus open a telnet session to an host
Try to press ctrl+plus
Change Settings in Windows Terminal and change default keybinding for setting a larger font size to something different than ctrl+plus or delete that keybind entirely and save
Attempt to start another telnet session and try to escape with ctrl+plus
Expected Behavior
Having escape into the telnet prompt work with default windows terminal settings
Actual Behavior
It seems windows terminal has a default keybinding for ctrl+plus, that changes the font size
It might be an better idea to have that as ctrl+numpad_plus or
something that doesn't cause issues when using telnet with the default escape character
My options here were either change or remove the keybinding in windows terminal (I removed it once I found it) or
start a telnet session with -e to specify a custom escape character
Maybe there could be a better default keybinding you could set in windows terminal that would not interfere with telnets default
It would probably also be fine to leave it as is?
But it kinda caused a bit of confusion for me, maybe just having terminal forward ctrl+plus even with a keybinding set for it, might work, but could possibly cause issues in other situations.
I'll leave it up to you guys what you think could/should be done here

It looks like we've got it bound to both:
https://github.com/microsoft/terminal/blob/8ea3cb9972491dec322f53ad69525a431a1d8431/src/cascadia/TerminalSettingsModel/defaults.json#L444-L447
I honestly think the best recommendation here is just to unbind ctrl+plus if you're already using it for something in your client app (telnet).
But thanks for bringing this up! I honestly didn't know ctrl+plus was used for that in telnet!


Record Active Auras

We can add a table to record active auras. This should be two tables:
hunt_auras

hunt_id
aura_id

auras

aura_id
aura_code_name
aura_name

The data is returned from activeturn.php in trap_image.auras

The extension would provide an auras property in the message that has an array of the codenames for the active auras, like Object.keys(auras).filter( codename => auras[codename].status === 'active')

Hunt intake would have to add the logic to look up the auras by codename, adding the ones it does not know. It would add new auras. Someone else can manually put appropriate names in the row in the aura table later.


README: add link to migration_guide manual page [3.0]

Cherry-pick of #17840, except for the link to the migration_guide, which points into man3.0 instead of manmaster.

This pull request is ready to merge

Merged to 3.0 in 247d9dbeb973c1bd5f139862f8bb44e1fc5abb7d, thank you!