Add a flag in STF Load test to skip generating core dumps when not required

For test cases such as SharedClassesWorkloadTest_Softmx_Increase, part of the test is to run a "workload" such as "mini-mix" load. The Java sub-process)that runs this load is allowed to return 0 or 1; i.e., we do not care if some of the tests fail, we only care to run the "load" ( e.g. the main objective of the test-case can be to fill up the shared classes cache in a desired way only).
However, the STF load test framework has been designed to generate core dumps (only for OpenJ9 JDKS) at the first occurrence of a test failure in the load test it is running: https://github.com/AdoptOpenJDK/stf/blob/b69553477faa6ec02a081d733b2db918d4fca6ec/stf.load/src/stf.load/net/adoptopenjdk/loadTest/LoadTest.java#L202
This is why we see core dumps created and the result directory becoming excessively large even when there is actually no test failure per se (Ref: https://github.com/eclipse/openj9/issues/4088).
The dumps are created programmatically via com.ibm.jvm.Dump API. So, I am not sure if providing -Xdump:none in the command line of the jvm2 process will have any impact. We need to update STF load test framework and may be add a flag indicating when not to generate dump even if a test fails.

FYI @lumpfish


Warn if falling back to setTimeout in dev mode

Closes https://github.com/scala-js/scala-js-macrotask-executor/issues/50. /cc @cornerman
Thoughts?

TBH, I think this is entirely the wrong thing to do. If I depend on some core library like this, the last thing I want it to do is for it to print stuff to the console without my knowledge, and without me being able to turn it off or choose to display the information in a different way.
Moreover, I don't think anyone will actually see this, and hence the point will likely be lost. The developer won't see it because they're likely using only environments where it doesn't show up. Users won't see it because they will get the production version, and anyway they don't look at the console.

If this is somehow necessary, I would much rather have an API point that returns a description of what method is actually being used. An enum-like thing could work, though it's important to make it evolvable in binary compatible ways.

I would love to get a feedback on which method is used by the executor. Logging to the console in case of setTimeout seems better than nothing. If it is a method returning what is used, that is even better :)

Maybe a better approach would be to have a global flag which disables the fallback altogether? So if you want to either have high performance or nothing, you could get that semantic.

Thanks for the feedback. Overall I agree with https://github.com/scala-js/scala-js-macrotask-executor/pull/51#issuecomment-1100720847 which is why I tucked this under dev-mode only.
OTOH, personally I'm not convinced this is necessary enough to expose in the API itself given the constraints of maintaining backwards-compatibility. See also discussion in https://github.com/scala-js/scala-js-macrotask-executor/pull/37#issuecomment-999388533 about the fact how this ExecutionContext uses macrotasks is an implementation detail.
Btw, all of this still feels pretty hypothetical. To at least make this concrete, is there an environment where such a thing would be useful, as in we legitimately cannot implement this polyfill but we can use Promise, and a reasonable Scala.js program can run without getting tripped up by other missing APIs?

My motivation to open the issue was mainly based on fear of falling back to a badly performing solution. I have no feedback on what method is used. I can check which browsers are supported but there was some uncertainty for me. This might lead to users complaining about the performance of the application. I feel it would be better to tell the user that their platform is not supported then.
I cannot really say how widespread this problem actually is. Also whether other APIs  that we are using would be problematic for these users as well, as @armanbilge mentioned already. Is there an understanding which browsers/runtimes our scalajs libraries actually support when using macrotaskexecutor or securerandom? Maybe the affected userbase is actually so small that it is not worth handling it at all.
There was also this issue, where people were wondering which method will be used in browser extension: https://github.com/scala-js/scala-js-macrotask-executor/issues/38#issuecomment-995094890. This is why i thought a console warning might be a good step.
It could also be that we need to define what this library does: is it just providing a correct polyfill or a high-performant and correct one. As @djspiewak said, a flag to say what you want or even two different executors - with and without fallback - might be a solution.

Thanks, those are great questions!

Is there an understanding which browsers/runtimes our scalajs libraries actually support when using macrotaskexecutor or securerandom?

Yes :)
First of all, MacrotaskExecutor supports any environment that provides setTimeout, since this is the fallback.
https://caniuse.com/mdn-api_settimeout
But, probably your question is specifically which environments will have "decent" performance:

any runtime that supports setImmediate:
https://caniuse.com/setimmediate
browsers supporting postMessage:
https://caniuse.com/mdn-api_window_postmessage
web workers supporting MessageChannel:
https://caniuse.com/mdn-api_messagechannel_messagechannel

This is all documented here:
https://github.com/scala-js/scala-js-macrotask-executor#performance-notes
Out of scope for this discussion, but similarly, SecureRandom supports:

any runtime providing crypto.getRandomValues() from the Web Crypto API:
https://caniuse.com/getrandomvalues
Node.js v7.10.0+:
https://nodejs.org/api/crypto.html#cryptorandomfillsyncbuffer-offset-size

Which is documented here:
https://github.com/scala-js/scala-js-java-securerandom#usage

There was also this issue, where people were wondering which method will be used in browser extension: https://github.com/scala-js/scala-js-macrotask-executor/issues/38#issuecomment-995094890

Actually, I would summarize that issue as not about which method will be used, but rather about whether the MacrotaskExecutor would behave correctly in that environment and whether it would be performant.
The problem is that same-named methods can behave differently depending on the environment, so simply knowing which method is selected is not sufficient. For example:

Unfortunately, postMessage has completely different semantics inside web workers, and so cannot be used there.

https://github.com/YuzuJS/setImmediate#messagechannel
The ideal way to verify that the MacrotaskExecutor behaves correctly (and performantly) in that environment would be to run the test suite which checks both of those things.

It could also be that we need to define what this library does: is it just providing a correct polyfill or a high-performant and correct one.

The first goal of this library is to provide a correct implementation of an ExecutionContext that uses macrotasks. The second goal is to provide a high-performant one, but the first goal takes priority.
So far, we've been able to achieve both goals for all the environments tested in CI, and personally I'd be 👍 to any PRs that add more. Perhaps, that is the best way to address your uncertainties? :)
I hope that helps!

Btw, if we really look at those caniuse numbers we have:

API
Global %

postMessage
94.1%

Promise
94.3%

setTimeout
94.5%

So odds are, we are really talking about a fraction of a percent here.


Prysm phase 1 feedback (cont)

Supersedes #1850
Another round of feedbacks and questions after further alignments with Prysm on phase 1 specs. Latest progresses:

Shard transitions and crosslinks: 100% completed on beacon node. 0% on validator client
Light client support: 100% completed on beacon node. 0% on validator client
Proof of custody and fraud proofs: 0% completed on either side

This work is here and the diff is here. This will be fully migrated to the official Prysm repo when the time is right
Left over from last round:

Refactor shard proposer reward portion to its own method inside process_crosslink_for_shard. Would love to see process_crosslink_for_shard get split to be more granular.
Put unpack_compact_validator inside light client spec since it’s not used within the scope in phase1 beacon chain

This round:

Decrease MAX_SHARDS from 1024 to 64. From tech's standpoint, it doesn't matter because sparse transition objects will be compressed. From social and UX's standpoint, 64 is superior than 1024. Block explorers, application and user levels don't have to deal with empty objects. It'd be nice to eliminate questions such as: why 960 transitions are empty? when will they be used?... etc
One of the main reason to slowing down shard activity if crosslinking fails because attestation had many custody bits. Given the on going work on #1889, is there plan to increase SHARD_BLOCK_OFFSETS  to have more frequent intervals?
FullAttestation can get quite large due to ShardTransition (up to 3600 bytes). One way to mitigate this is to have aggregators to covert to FullAttestation. An option for this is gossip ShardTransition and AttestationData separately to create deduplication. I haven't done much analysis on this, this is just an initial thought
Similar to eth1_data, I'm liking following construction for light client data inside beacon block body:

class LightData(Container):
    light_client_bits: Bitvector[LIGHT_CLIENT_COMMITTEE_SIZE]
    light_client_signature: BLSSignature

class BeaconBlockBody(Container):
    light_data: LightData  # light client data vote

I think compute_committee_source_epoch should have a more general name. (e.g. compute_period_source_epoch)
pending_attestation.crosslink_success is marked to True during process_crosslinks but it's not used anywhere else
is_on_time_attestation will return true if attestation_data.slot and state.slot both are both 0. This is unlikely a run time issue but good to make a note on it.

A few custody related questions:

Does CustodyChunkResponse need chunk_index? A valid response implies 1.) the correctness of record in beacon state and 2.) the chunk matches the crosslink data root by asserting is_valid_merkle_branch. It seems like we can get rid of chunk_index which saves an extra uint64 in CustodyChunkResponse
Naming suggestion: reveal in CustodyKeyReveal feels generic. Would be nice to avoid something like reveal.reveal. Do you think signature or masked_signature is a better name there?
Naming suggestion: MINOR_REWARD_QUOTIENT feels generic, but i don't have a good suggestion for this at this moment...
whistleblower_reward is divided among committee_indices_length rather than attested_indices_length. I'd think it should be divided among attesting_indices_length. If there's less online participants in the committee, this would incentive one to look harder
Given there's no special whistleblower_reward for custody_slashing, could this cause some sort of tragedy of the common problem? Where every participant in the committee always expects someone to slash

cc @dankrad


Weird build errors on Linux

Hi, tried to build this on Arch Linux by following the readme, and got some weird errors:
$ cmake -DUBUS_SUPPORT=OFF -DUCI_SUPPORT=OFF -DULOOP_SUPPORT=OFF .
-- The C compiler identification is GNU 12.2.1
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Found PkgConfig: /usr/bin/pkg-config (found version "1.8.0")
-- Checking for module 'json-c'
--   Found json-c, version 0.16
-- Looking for dlopen
-- Looking for dlopen - found
-- Looking for fmod
-- Looking for fmod - not found
-- Looking for json_tokener_get_parse_end
-- Looking for json_tokener_get_parse_end - found
-- Looking for json_object_new_array_ext
-- Looking for json_object_new_array_ext - found
-- Looking for json_object_new_uint64
-- Looking for json_object_new_uint64 - found
-- Looking for ceil
-- Looking for ceil - not found
-- Looking for res_mkquery
-- Looking for res_mkquery - found
-- Looking for clock_gettime
-- Looking for clock_gettime - found
-- Looking for frexp
-- Looking for frexp - found
-- Configuring done
CMake Error: The following variables are used in this project, but they are set to NOTFOUND.
Please set them or make sure they are set and tested correctly in the CMake files:
nl
    linked by target "rtnl_lib" in directory /home/user/Src/ucode
    linked by target "nl80211_lib" in directory /home/user/Src/ucode
nl_include_dir
   used as include directory in directory /home/user/Src/ucode
   used as include directory in directory /home/user/Src/ucode
   used as include directory in directory /home/user/Src/ucode
   used as include directory in directory /home/user/Src/ucode
   used as include directory in directory /home/user/Src/ucode
   used as include directory in directory /home/user/Src/ucode
   used as include directory in directory /home/user/Src/ucode
   used as include directory in directory /home/user/Src/ucode
   used as include directory in directory /home/user/Src/ucode
   used as include directory in directory /home/user/Src/ucode
   used as include directory in directory /home/user/Src/ucode
   used as include directory in directory /home/user/Src/ucode
   used as include directory in directory /home/user/Src/ucode
   used as include directory in directory /home/user/Src/ucode
   used as include directory in directory /home/user/Src/ucode
   used as include directory in directory /home/user/Src/ucode
   used as include directory in directory /home/user/Src/ucode
   used as include directory in directory /home/user/Src/ucode
   used as include directory in directory /home/user/Src/ucode
   used as include directory in directory /home/user/Src/ucode
   used as include directory in directory /home/user/Src/ucode
   used as include directory in directory /home/user/Src/ucode
   used as include directory in directory /home/user/Src/ucode
   used as include directory in directory /home/user/Src/ucode
   used as include directory in directory /home/user/Src/ucode
   used as include directory in directory /home/user/Src/ucode
   used as include directory in directory /home/user/Src/ucode
   used as include directory in directory /home/user/Src/ucode
   used as include directory in directory /home/user/Src/ucode
   used as include directory in directory /home/user/Src/ucode
   used as include directory in directory /home/user/Src/ucode
   used as include directory in directory /home/user/Src/ucode
   used as include directory in directory /home/user/Src/ucode/examples
   used as include directory in directory /home/user/Src/ucode/examples
   used as include directory in directory /home/user/Src/ucode/examples
   used as include directory in directory /home/user/Src/ucode/examples
   used as include directory in directory /home/user/Src/ucode/examples
   used as include directory in directory /home/user/Src/ucode/examples
   used as include directory in directory /home/user/Src/ucode/examples
   used as include directory in directory /home/user/Src/ucode/examples
   used as include directory in directory /home/user/Src/ucode/examples
   used as include directory in directory /home/user/Src/ucode/examples
   used as include directory in directory /home/user/Src/ucode/examples
   used as include directory in directory /home/user/Src/ucode/examples
   used as include directory in directory /home/user/Src/ucode/examples
   used as include directory in directory /home/user/Src/ucode/examples
   used as include directory in directory /home/user/Src/ucode/examples
   used as include directory in directory /home/user/Src/ucode/examples
   used as include directory in directory /home/user/Src/ucode/examples
   used as include directory in directory /home/user/Src/ucode/examples
   used as include directory in directory /home/user/Src/ucode/examples
   used as include directory in directory /home/user/Src/ucode/examples
   used as include directory in directory /home/user/Src/ucode/examples
   used as include directory in directory /home/user/Src/ucode/examples
   used as include directory in directory /home/user/Src/ucode/examples
   used as include directory in directory /home/user/Src/ucode/examples
ubox
    linked by target "nl80211_lib" in directory /home/user/Src/ucode

CMake Error in CMakeLists.txt:
  Found relative path while evaluating include directories of "libucode":

    "nl_include_dir-NOTFOUND"

CMake Error in CMakeLists.txt:
  Found relative path while evaluating include directories of "ucode":

    "nl_include_dir-NOTFOUND"

CMake Error in CMakeLists.txt:
  Found relative path while evaluating include directories of "fs_lib":

    "nl_include_dir-NOTFOUND"

CMake Error in CMakeLists.txt:
  Found relative path while evaluating include directories of "math_lib":

    "nl_include_dir-NOTFOUND"

CMake Error in CMakeLists.txt:
  Found relative path while evaluating include directories of "rtnl_lib":

    "nl_include_dir-NOTFOUND"

CMake Error in CMakeLists.txt:
  Found relative path while evaluating include directories of "nl80211_lib":

    "nl_include_dir-NOTFOUND"

CMake Error in CMakeLists.txt:
  Found relative path while evaluating include directories of "resolv_lib":

    "nl_include_dir-NOTFOUND"

CMake Error in CMakeLists.txt:
  Found relative path while evaluating include directories of "struct_lib":

    "nl_include_dir-NOTFOUND"

CMake Error in examples/CMakeLists.txt:
  Found relative path while evaluating include directories of
  "exception-handler":

    "nl_include_dir-NOTFOUND"

CMake Error in examples/CMakeLists.txt:
  Found relative path while evaluating include directories of "execute-file":

    "nl_include_dir-NOTFOUND"

CMake Error in examples/CMakeLists.txt:
  Found relative path while evaluating include directories of
  "execute-string":

    "nl_include_dir-NOTFOUND"

CMake Error in examples/CMakeLists.txt:
  Found relative path while evaluating include directories of
  "native-function":

    "nl_include_dir-NOTFOUND"

CMake Error in examples/CMakeLists.txt:
  Found relative path while evaluating include directories of "state-reset":

    "nl_include_dir-NOTFOUND"

CMake Error in examples/CMakeLists.txt:
  Found relative path while evaluating include directories of "state-reuse":

    "nl_include_dir-NOTFOUND"

-- Generating done
CMake Generate step failed.  Build files cannot be regenerated correctly.

Running make also seemingly fails:
$ make
[  2%] Building C object CMakeFiles/libucode.dir/lexer.c.o
[  5%] Building C object CMakeFiles/libucode.dir/lib.c.o
[  8%] Building C object CMakeFiles/libucode.dir/vm.c.o
[ 11%] Building C object CMakeFiles/libucode.dir/chunk.c.o
[ 13%] Building C object CMakeFiles/libucode.dir/vallist.c.o
[ 16%] Building C object CMakeFiles/libucode.dir/compiler.c.o
[ 19%] Building C object CMakeFiles/libucode.dir/source.c.o
[ 22%] Building C object CMakeFiles/libucode.dir/types.c.o
[ 25%] Building C object CMakeFiles/libucode.dir/program.c.o
[ 27%] Linking C shared library libucode.so
[ 27%] Built target libucode
[ 30%] Building C object CMakeFiles/ucode.dir/main.c.o
[ 33%] Linking C executable ucode
[ 33%] Built target ucode
[ 36%] Building C object CMakeFiles/fs_lib.dir/lib/fs.c.o
[ 38%] Linking C shared module fs.so
[ 38%] Built target fs_lib
[ 41%] Building C object CMakeFiles/math_lib.dir/lib/math.c.o
[ 44%] Linking C shared module math.so
[ 44%] Built target math_lib
[ 47%] Building C object CMakeFiles/rtnl_lib.dir/lib/rtnl.c.o
/home/user/Src/ucode/lib/rtnl.c:31:10: fatal error: netlink/msg.h: No such file or directory
   31 | #include <netlink/msg.h>
      |          ^~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [CMakeFiles/rtnl_lib.dir/build.make:76: CMakeFiles/rtnl_lib.dir/lib/rtnl.c.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:232: CMakeFiles/rtnl_lib.dir/all] Error 2
make: *** [Makefile:136: all] Error 2

But despite that, there's ucode binary, and it seems to work fine:
$ ./ucode -e 'print("OK!\n")'
OK!

cmake -DUBUS_SUPPORT=OFF -DUCI_SUPPORT=OFF -DULOOP_SUPPORT=OFF .

You should add -D NL80211_SUPPORT=OFF into your cmake args if you don't need nl80211 library in ucode.

Yep, cmake -DUBUS_SUPPORT=OFF -DUCI_SUPPORT=OFF -DULOOP_SUPPORT=OFF -DNL80211_SUPPORT=OFF -DRTNL_SUPPORT=OFF . did it, thanks!
Maybe it's worth adding these extra options to the Linux build instructions in the readme? Those libraries sound like something OpenWRT-specific.


The 'LSI Logic Parallel' controller is not supported on Windows 10

The 'LSI Logic Parallel' controller' not supported on Windows 10 and may causes problems if we use it. https://kb.vmware.com/s/article/2004740
Please check if that's the case and should we need to update the guest OS mappings for Windows 10 on Vmware.
ISSUE TYPE

Bug Report

COMPONENT NAME

UI, API

CLOUDSTACK VERSION

4.16, VMware ESXi, 7.0.3

@rohityadavcloud can you describe a scenario in which this poses a problem, please?
Also I see three lsilogic adapters in our code:
public interface ScsiDiskControllerType {
    String LSILOGIC_PARALLEL = "lsilogic";
    String LSILOGIC_SAS = "lsilogicsas";
    String LSILOGIC_SAS_1068 = "lsisas1068";
    String BUSLOGIC = "buslogic";
    String VMWARE_PARAVIRTUAL = "pvscsi";
    String VIRTUAL_SCSI = "VirtualSCSI";
}

Are all three a problem or one specific type?

I think the osdefault controller for Windows10 should be something it can work out of the box on VMware (I'm guessing the user who reported this to me suggests they can't use lsi logic parallel with Windows 10).

@rohityadavcloud @DaanHoogland
As I understand from https://kb.vmware.com/s/article/2004740, the problem is quite similar as windows vm on kvm.
on kvm, virtio driver is not installed by default in windows vm, users have to create vm with IDE disk, install virtio driver , update the guest os type to "Windows PV" and then stop/start the windows vm
This is more likely a document issue, not source code.
We could improve the admin guide https://docs.cloudstack.apache.org/en/latest/adminguide/templates.html

user needs to upgrade to <IP_ADDRESS> and above which includes #5910

@weizhouapache cc @rohityadavcloud do we still need documentation changes for this or the mentioned PR https://github.com/apache/cloudstack/pull/5910 fixes this?

Yes thanks @shwstppr doc PR is all we need. Unless you think this can be address automatically in the code.

@rohityadavcloud  I've created a documentation PR, https://github.com/apache/cloudstack-documentation/pull/314
Though I tested the deployment of a VM with Windows 10 as guest OS and osdefault as controllers in ACS. In vCenter it seems to be using LSI Logic SAS

Closing as doc PR was created/merged https://github.com/apache/cloudstack-documentation/pull/314


Extra Headers Improvements

Rename ExtraHeaders to UpnpExtraHeaders
Make UpnpExtraHeaders public (includes, exports)
Populate the ExtraHeaders in the finfo passed to the VirtualDir get_info callback

With these patches I was sucessfully able to read and write extra headers from my application.
Please review :+1:

There is some pending "const" stuff, but overall awsome job!

Should this work go into 1.8 or do we leave it only in master? I think it should go into 1.8, since it is ExtraHeaders stuff. The only issue (non-issue?) is that it adds stuff to the public API.
Opinions are welcome.
Regards,
Marcelo.

Thanks for merging.
It should go into 1.8 for sure, as with the extra headers stuff.

Well guys, are we finally going to be able to watch something on our Samsung TV?
The NOT adding HTTP header is really frustrating.


ParticleOptions of a ParticleEffect not being deserialized from a config file

I am currently running...

SpongeForge version: not tested
SpongeVanilla version: spongevanilla-1.11.2-6.1.0-BETA-0
Java version: 1.8.0_121
Operating System:

[ ] Linux (Ubuntu, Debian, Fedora, etc)
[ ] macOS
[x] Windows

Plugins/Mods: None

What is the expected result?
ParticleEffect deserialized from a config file contaning both the ParticleType and the various ParticleOptions contained in the config.
What is the current result?
The ParticleEffect when deserialized loads only the ParticleType from the config, skipping entirely the ParticleOptions, even if actually in the config file.
Further testing
I made test plugin to save a ParticleEffect into a config file using Hocon and a ConfigurationNode.
I created the ConfigurationLoader and saved the ParticleEffect like this:
ConfigurationLoader<CommentedConfigurationNode> config = LoaderHoconConfigurationLoader.builder().setPath(defaultConfigPath).build();
CommentedConfigurationNode rootNode = this.configLoader.load();

this.particle = ParticleEffect.builder()
                .type(ParticleTypes.CLOUD)
                .offset(new Vector3d(5d, 5d, 5d))
                .velocity(new Vector3d(0.5d, 0.5d, 0.5d))
                .build();

rootNode.setValue(TypeToken.of(ParticleEffect.class), this.particle);

this.configLoader.save(rootNode);

System.out.println("Created particle: " + particleEffectToString(this.particle));

private String particleEffectToString(ParticleEffect particleEffect) {
        StringBuilder string = new StringBuilder();

        string.append(particleEffect.getType());
        string.append(" options (" + particleEffect.getOptions().size() + "): ");
        particleEffect.getOptions().forEach((particleOption, o) -> {
            string.append(particleOption.getName());
            string.append(particleOption.getValueType());
        });

        return string.toString();
}

The println output is this
Created particle: SpongeParticleType{id=minecraft:cloud, name=cloud, internalType=CLOUD} options (2): offsetclass com.flowpowered.math.vector.Vector3dvelocityclass com.flowpowered.math.vector.Vector3d

The resulting config file is this:
Options=[
    {
        Option="minecraft:offset"
        Value {
            x=5.0
            y=5.0
            z=5.0
        }
    },
    {
        Option="minecraft:velocity"
        Value {
            x=0.5
            y=0.5
            z=0.5
        }
    }
]
Type="minecraft:cloud"

Now when I load the ParticleEffect at next execution from the config file like this:
ParticleEffect particle = rootNode.getValue(TypeToken.of(ParticleEffect.class));

System.out.println("Loaded particle: " + particleEffectToString(this.particle));

The ParticleTypes is assigned but there are no ParticleOptions, as you can see from the println output:
Loaded particle: SpongeParticleType{id=minecraft:cloud, name=cloud, internalType=CLOUD} options (0):

Gist containing both the logs at first and second execution and the test plugin main class here.
If I did something wrong please tell me.. I tried in every possible way to deserialize it properly.
I even tried to go into the SpongeParticleEffectBuilder to see if the problem was there and this is what I found:
https://github.com/SpongePowered/SpongeCommon/blob/a5618c7a8bd32a10102fc443be8b0bc65002e511/src/main/java/org/spongepowered/common/effect/particle/SpongeParticleEffectBuilder.java#L64
I tested putting two println one before the line to see if the container contains the PARTICLE_OPTIONS and one inside the foreach printing the view, results: the first prints true while the other doesn't get called but I couldn't manage to get why.

I have backed-out the commit that was meant to fix this due to data loss and other issues. I'm reopening this so it doesn't get lost.

Fixed by https://github.com/SpongePowered/SpongeCommon/pull/2603


ac-export character encoding problem

The ac-exporter is producing character encoding corruption for characters with diacritics and logographic characters:
For example here's 紫色叉鼻喉盘鱼:
grep 'Zi se cha bi hou pan yu' common_names.csv
8829261,f09ac7bb-1e05-4147-8e65-3ef22a164ef5,???????,Zi se cha bi hou pan yu,cmn,CN,\N,\N,10,\N,\N

which should be:
grep 'Zi se cha bi hou pan yu' common_names.csv
8829261,f09ac7bb-1e05-4147-8e65-3ef22a164ef5,紫色叉鼻喉盘鱼,Zi se cha bi hou pan yu,cmn,CN,\N,\N,10,\N,\N

Here's Harilik puuksäga:
8451658,194be6d5-23ec-4f98-b485-421e47521e7a,Harilik puuks?ga,Harilik puuksaega,est,EE,\N,\N,10,\N,\N

which should be:
8451658,194be6d5-23ec-4f98-b485-421e47521e7a,Harilik puuksäga,Harilik puuksaega,est,EE,\N,\N,10,\N,\N

The character encoding is correct in the Clearinghouse, so I think this is an ac-exporter bug.
Ref: https://github.com/Sp2000/colplus-repo/issues/89

see https://stackoverflow.com/questions/30916853/postgresql-copy-encoding-how-to

@gdower are you sure this is not a terminal artifact?

@mdoering, unfortunately, it's not a terminal artifact. Here's the Harilik puuksäga species page for that common name:

Most non-ascii characters seem to be replaced with ? in all of the ac-export.zip csv files.
The encoding is correct in catalogue 3, so I think the encoding corruption is introduced by the ac-exporter: https://data.catalogue.life/dataset/3/taxon/194be6d5-23ec-4f98-b485-421e47521e7a

that should have been the culprit: https://github.com/Sp2000/colplus-backend/commit/fb64ae5a3dab8129409ac9202c68ebbd41d9c5d2


How to set GITHUB_TOKEN in Docker env?

Hey! Thanks for this great and important tool!
I'd like to scan my private repositories, and according to your wiki, I need to set the GITHUB_TOKEN. My question is, how do I do that running your app with the one-liner for docker? Where/how can I access the env file to configure it?
Thanks!

https://docs.docker.com/engine/reference/run/#env-environment-variables

https://github.com/zricethezav/gitleaks/releases/tag/v1.13.0 see example here


How can I add custom attention masks to a Decoder?

Hey there, I am in the position where I need to mask out certain positions of my input manually, so the usual causal mask does not suffice. I am using the Decoder class and no Transformer wrapper as I need to feed in the embeddings manually.
self.transformer= Decoder(                     dim = self.dim,                     depth = self.depth,                     heads = self.heads,                     attn_flash = True                 )
I tried to manually create an attention mask following the usual procedure, but when I pass that into the forward function, my outputs all become NaN:

There is also the mask besides the attention mask, can I just use this instead?
e.g. have a torch.ones(1, 256).bool().to(device) mask for my (1, 256, 512) embedding input that would then internally be converted to the attention mask?
I would greatly appreciate if you could provide me with code or a shape that I need to create for the default causal attention that I can then modify. I am also not quite sure if it needs to be boolean and if True means attend and False means not attend.

@DerEchteFeuerpfeil hey Moritz! so i had the same confusion as you starting out with how the mask is represented
so i decided i would not perpetuate confusion and for all my repos without exception, masking is always True for attend and False for not. this makes sense to me because if one were to cast it to a float, one can also multiply it with your input for effectively masking (in non-attention scenarios)
in your example, it should work if you just invert your mask with a ~, but let me know if it does not

Hey @lucidrains , thanks for the quick reply!
Looks like I was so close to getting it right 😉 This implementation also makes the most sense to me.
Works like a charm now 👍

@DerEchteFeuerpfeil nice! go train something amazing :)


Change camera direction on orientation change

I manually set the camera orientation to begin with:
[vision setCameraOrientation:PBJCameraOrientationPortrait];

But I would like the orientation to change if the device rotates (regardless wether the rotation lock is active or not on the device)
I tried getting orientation changes (which only works if the orientation lock is off):
- (void)rotateCameraToInterfaceOrientation:(UIDeviceOrientation)orientation {
    switch (orientation) {
        case UIDeviceOrientationPortrait:
            [[PBJVision sharedInstance] setCameraOrientation:PBJCameraOrientationPortrait];
            break;
        case UIDeviceOrientationPortraitUpsideDown:
            [[PBJVision sharedInstance] setCameraOrientation:PBJCameraOrientationPortraitUpsideDown];
            break;
        case UIDeviceOrientationLandscapeLeft:
            [[PBJVision sharedInstance] setCameraOrientation:PBJCameraOrientationLandscapeLeft];
            break;
        case UIDeviceOrientationLandscapeRight:
            [[PBJVision sharedInstance] setCameraOrientation:PBJCameraOrientationLandscapeRight];
            break;
        default:
            [[PBJVision sharedInstance] setCameraOrientation:PBJCameraOrientationPortrait];
            break;
    }
}

But the preview layer rotates when I change the orientation. What I want is the metadata to update the orientation value, so when you put the image in the camera roll it ends up in the correct direction.
How do I achieve this?

Hi @piemonte I also have a similar issue. I figured out how to get around it for images, but now need to implement it for video. May I ask, has there been any progress recently?
Thank you

im having the same issue.

Hey guys' did anyone managed to solve it?

Any updates? :(

My fix update:

app only Portrait
implemented notification for rotation

    override init() {
        super.init()
        NotificationCenter.default.addObserver(self, selector: #selector(updateCameraOrientation), name: NSNotification.Name.UIDeviceOrientationDidChange, object: nil)
    }

    deinit {
        //3
        NotificationCenter.default.removeObserver(self, name: NSNotification.Name.UIDeviceOrientationDidChange, object: nil)
    }

    @objc fileprivate func updateCameraOrientation() {
        switch UIDevice.current.orientation {
        case .landscapeLeft: //yeah yeah, if left - then right
            cameraController.cameraOrientation = .landscapeRight
        case .landscapeRight:
            cameraController.cameraOrientation = .landscapeLeft
        default:
            cameraController.cameraOrientation = .portrait
        }
    }

put

        PBJVision.autoUpdatePreviewOrientation = false

hmmmm, i think thats it....


Add visual effects

Add visual effects for:

Spacecraft thrusters (player movement). These could be configurable so they can scale with the spacecraft's speed.
Landing and docking on an asteroid.
Weapon projectile impact. It's in space, we can assume that the guns shoot lasers. So, laser impact? I'm not sure what this one should be.

Projectiles could probably look like flying plasma balls with some shader work
Replace the 'pop' death effect with an explosion and burning fuel flashes

Definitely. @henriiquecampos would you be available to work on these? @Razoric480 here will be taking care of the shaders.

For the thrusters I'd definitely add some deformation, and in general for impacts, having some heatwave effect. So shaders would be useful for that at least.
By the way for shaders, you can work either in pure code or using the visual shader editor. Even combine both: the visual editor writes the code for you, you can pick up from there.

For the lasers, we could go with a laser beam/stream, instead of projectiles with an effect on the cast/shooter and an impact effect on whatever it lands on.
Something like this, but a laser beam instead of a lightning

@Razoric480 can you make a heatwave shader? Something that smoothly displaces the image in a sinoidal way? We can use it to constantly displace the laser stream. I think that with the same shader logic we can do a random displacement that uses time to distort the screen/fragment. This can be used in the "impact" effect.
For landing, what do you think of a ripple effect? We can also reuse it in a way smaller strength tfor when the thrusts are turned on:

Thrust turns on
Ripple effect
Some particles with the heatwave effect
Some after images (particles emitted with the inverse normal of the ship's movement)

Depending on the speed of the ship the after-images' trail can be greater or smaller to give the feeling of acceleration.

Replacing projectiles with a ray cast laser weapon would necessitate some new game play feature. I don't mind having a laser gun on top and letting players pick which they want to use, but having an effect for the plasma projectile as well would be preferable.
And sure, I can look into coding displacement effects

Ohh, so we already have the projectiles logic in place. Nevermind then, we can add it as an extra after other stuff is done.

Yes we already have all the prototype in place. But the projectiles could use some love. I was thinking of having thin laser shots as in star wars instead of the current capsules.
For the deformation shaders, I'd recommend going with texture-based shader first. For one it's generic and reusable, and can work well with the noise texture in Godot (or gradients, or others), and you can throw any simple tiling texture in there for tons of effects.
The classic sine shockwave, sure, it's nice too, but you'll want to overlay your sine with some other subtle texture to give it more personality.

We have the plasma balls, explosions, movement trail, animated resource mining, landing, shockwaves... anything else you'd like to close this issue to add or is this task good for now?

I think we're okay for now; new features will call for new VFX, but we'll get there once we have those features.


Add Nix flake

I don't know if you use Nix yourself, but having a Nix flake as part of this repo is very handy for tools like these. For example, I use a Nix flake to build my website, and just by adding this flake to the repo, I'll be able to parse Djot with jotdown by just linking to the repo. One can also run nix run github:hellux/jotdown -- somefile.dj to parse a file without installing anything!
Additionally, (and perhaps the biggest selling point,) setting up a dev environment is now a lot simpler. This crate targets 1.56, but this might not be the version installed on your system (it likely isn't.) Now, one can just run nix develop to get thrown into a shell with the Rust 1.56 toolchain installed. Any additional dependencies for benchmarking/fuzzing/etc. can also be added to this development environment.

I don't know if you use Nix yourself, but having a Nix flake as
part of this repo is very handy for tools like these. For example, I
use a Nix flake to build my
website,
and just by adding this flake to the repo, I'll be able to parse
Djot with jotdown by just linking to the repo. One can also run nix run github:hellux/jotdown -- somefile.dj to parse a file without
installing anything!
Additionally, (and perhaps the biggest selling point,) setting up a
dev environment is now a lot simpler. This crate targets 1.56, but
this might not be the version installed on your system (it likely
isn't.) Now, one can just run nix develop to get thrown into a
shell with the Rust 1.56 toolchain installed. Any additional
dependencies for benchmarking/fuzzing/etc. can also be added to this
development environment.

I haven't tried out Nix so I am not familiar with Nix flakes. But is it
kind of similar to build scripts, e.g. like Arch PKGBUILDs or Gentoo
ebuilds? Or are they more for development or CI environments, like e.g.
sourcehuts OS images or GitHub actions? Are flakes usually maintained by
project developers rather than distributions?
I.e. is the flake meant for users (to use the binary on their system) or
for developers (to debug/benchmarks/fuzz etc)? It seems like two
separate targets.
For rust, I currently use rustup to maintain a separate toolchain from
the one installed by my package manager.
Is it possible to place the files anywhere in the repo, e.g. in a
contrib dir? The root directory might get cluttered if more similar
files get added.
Also, can the flake be used in Github's CI? Running it in the CI
pipeline could help to make sure it is kept up to date, e.g. not
targeting an older rust version?

I.e. is the flake meant for users (to use the binary on their system) or for developers (to debug/benchmarks/fuzz etc)?

Both! Nix is a build system (and an accompanying declarative language) that can be used to build anything reproducibly. With this flake, I've defined three possible build outputs:

The package, which will be built the same way no matter the system, since all the build dependencies (only a specific Rust toolchain in this case) must be explicitly defined. The package only consists of the jotdown binary in this case, but manpages etc. could be included as well. You build by running nix build.

An runnable app. In this case, it only corresponds to executing the binary built as described above, but it gives users a very cool way of running jotdown in a throwaway fashion. E.g. I can already call jotdown from any computer with Nix on it, without installing anything, by running:
  $ nix run github:hellux/jotdown/nix -- --help

Produces:
usage: jotdown [option] [file]

arguments:
    file            a djot source file. use a dash (`-`) or no argument
                    to read from stdin

options:
    -h --help       show this text
    -v --version    show the version number
    -o --output     a file to write the output to. stdout if omitted

A development environment. Nix can literally function as a build system for dev environments, and the paramount advantage is that it builds these reproducibly as well!

Is it possible to place the files anywhere in the repo, e.g. in a contrib dir? The root directory might get cluttered if more similar files get added.

Sadly, no... It is a bit annoying that Rust projects now get two manifest files and two lockfiles, but I don't think there is any way around it.

Also, can the flake be used in Github's CI? Running it in the CI pipeline could help to make sure it is kept up to date, e.g. not targeting an older rust version?

It can! This is one of the really big niceities of using Nix. Have a look at this article to see some really cool examples.
I get it if you prefer the repo would not get too cluttered, and close this PR. However, I implore you to explore the possibilities a bit, as the advantages are really huge!

Can nix flakes be defined one directory above the package? In that case, could use another repo and have the jotdown repo as a submodule.

That's absolutely a possibility, though it would make discoverability a
bit worse.
Say I made such a repo. In that case, to run jotdown as a flake, you'd
type out nix run github:kmaasrud/jotdown. It might be easier to keep
this flake up to date (fetching the latest commit in the submodule could
be part of the build process,) but I still think it'd be better to have
everything in the source repo.

I'm ashamed to say I have been pretty terrible at contributing to the project lately, but I have push access and am open to maintaining a flake for it.
Just need approval from @hellux and I'll pull in the newest changes and merge this PR.

I am okay with merging it to master, but would it be possible to add a job to .github/workflows/ci.yml that makes sure it runs and stays up to date?
Might also be good to mention it in the README.

Part of the joy of Nix is that it is incredibly stable since everything is reproducible. The only thing that needs to be updated are any dependencies, of which you don't really have any other than Rust itself (notable exception being dev dependencies.)
As such, I only really see the need for checking the flake and potentially updating the tree whenever there is a new release. That is likely way too often, but better safe than sorry 😅 I can take care of that.
Do you know if there is any way that I can get a notification every time you push a tag? Both RSS and GitHub notifications would suffice. I can't find such a feature, but there must be something, right?

Part of the joy of Nix is that it is incredibly stable since
everything is reproducible. The only thing that needs to be updated
are any dependencies, of which you don't really have any other than
Rust itself (notable exception being dev dependencies.)

I am not familiar with nix flakes but I suspect that there are some
things that could potentially break at some point.
The flake.nix file has some references to a few github repos:

github:NixOS/nixpkgs/nixpkgs-unstable
github:numtide/flake-utils
github:oxalica/rust-overlay

Since no hashes seem to be specified for these I suspect we rely on that
our usage is compatible with each repo's master branch? Even if it
hashed still rely on the content to be available completely unmodified.
The only hash that I can find is this one:
  jotdown = rustPlatform.buildRustPackage {
    inherit pname version;
    src = pkgs.lib.cleanSource ./.;
    cargoSha256 = "sha256-mQvMB+AiojOWJNw/EYvI+jJmvXtxzBOFntWSis3Wv0s=";
  };

Does this hash include the source code for jotdown or any dependencies?
Does it include the above mentioned repos? Doesn't this hash have to be
updated rather frequently?
The file specifies a specific rust version:
  toolchain = pkgs.rust-bin.stable."1.56.0".default;

The rust target version might change so this would break if any newer
features were to be used in jotdown.
It is also implicity assumed that the file is compatible with the
Nix/flake framework, which could potentially change over time?
Especially since it seems to be labeled as an experimental feature.

As such, I only really see the need for checking the flake and
potentially updating the tree whenever there is a new release. That is
likely way too often, but better safe than sorry 😅 I can take care of
that.

It would be preferable to not have to perform a manual check before each
release.

Do you know if there is any way that I can get a notification every
time you push a tag? Both RSS and GitHub notifications would suffice.
I can't find such a feature, but there must be something, right?

Yeah, an RSS feed seems to be available at
https://github.com/hellux/jotdown/tags.atom.

Can nix flakes be defined one directory above the package? In that
case, could use another repo and have the jotdown repo as a submodule.

I think I prefer this option. Generally, packaging programs is best left
to distributions and their users imo. We can still link to the flake
repository in the readme so that any Nix users can easily find it.
A dev environment, on the other hand, could potentially be useful in the
jotdown repo to run the CI or allow developers who use Nix to easily set
up build/test/bench dependencies. But if the flake.nix also provides
that from a separate repo, one could perhaps use that one. However, the
flake.nix only seems to specify rust as a dependency, currently.
Valgrind, afl etc. would also be needed to run the tests and benchmarks,
for example. This could also be solved by e.g. a nix-shell file
(https://nixos.wiki/wiki/Development_environment_with_nix-shell) that
can be placed in contrib?

I am not familiar with nix flakes but I suspect that there are some things that could potentially break at some point. The flake.nix file has some references to a few github repos: - github:NixOS/nixpkgs/nixpkgs-unstable - github:numtide/flake-utils - github:oxalica/rust-overlay Since no hashes seem to be specified for these I suspect we rely on that our usage is compatible with each repo's master branch? Even if it hashed still rely on the content to be available completely unmodified.

The whole dependency tree, with precise hashes are found in the flake.lock file.

The only hash that I can find is this one: jotdown = rustPlatform.buildRustPackage { inherit pname version; src = pkgs.lib.cleanSource ./.; cargoSha256 = "sha256-mQvMB+AiojOWJNw/EYvI+jJmvXtxzBOFntWSis3Wv0s="; }; Does this hash include the source code for jotdown or any dependencies? Does it include the above mentioned repos? Doesn't this hash have to be updated rather frequently?

That hash would have to be updated on any changes to the Cargo.lock file, yes. However, I've now switched the Nix Rust layer to crane, which uses Cargo.lock directly so that won't be necessary anymore.

The file specifies a specific rust version: toolchain = pkgs.rust-bin.stable."1.56.0".default; The rust target version might change so this would break if any newer features were to be used in jotdown.

If the lowest supported version is changed, the flake would have to be updated as well, yes. The same goes for the README, so that will indeed be a manual process. The reason I pinned the flake to the lowest version was so that I could jump into a dev-shell and know what features I had at my disposal. If we don't care about the development part of the Nix flake, we could put a higher version here to ensure that newer features are available.

It is also implicity assumed that the file is compatible with the Nix/flake framework, which could potentially change over time? Especially since it seems to be labeled as an experimental feature.

The "experimental" tag is a widely discussed wart of the ecosystem, but for all intents and purposes, it is misleading. Nix flakes are generally considered quite stable, and for this very simple use-case, I am confident we will not hit any compatibility issues. You can read some thoughts on the matter here.

Yeah, an RSS feed seems to be available at https://github.com/hellux/jotdown/tags.atom.

I'll subscribe to it and keep an eye on any new releases!

In summary, I definitely understand your concerns about adding yet another build tool---one that you are not familiar with yourself---to the mix. However, adding support for Nix gives a huge advantage to the community and lowers the barrier of entry for those that are familiar with the workflow.
afl is not available on Darwin, so I chose to completely ditch the development shell part of the flake, since Nix derivations are generally expected to build exactly the same on all platforms. I also moved the flake to the contrib directory, so it can be considered more of a supplementary option. Feel free to route any questions about it to me.

Hi, any update on this? I think this is more or less good to merge.

@hellux hey sorry, christmas got in the way :santa: I amended a fix to the typo you found and answered some of your questions. Ping me whenever you feel ready and I'll merge the branch :smile:


Remove legacy JSON code

:notebook_with_decorative_cover: Description
This PR fixes up @ngrodzitski's work in #1343 so we can merge it into master.
:memo: Checklist

[x] All user-facing changes have changelog entries.
[x] The changes are reflected on docs.tenzir.com/vast, if necessary.
[x] The PR description contains instructions for the reviewer, if necessary.

:dart: Review Instructions
Commit-by-commit.

I did test the output of vast version and vast status. The other stuff should be covered by CI.

They are both covered by integration tests. The example plugin integration test checks vast version , and vast status we cover in multiple places.


Fix paths in validation scripts

Description

Fix paths in validation scripts

By Submitting this PR I confirm:

I am familiar with the Contributing Guidelines.
When the PR is ready for review, new or existing tests cover these changes.
When the PR is ready for review, the documentation is up to date with these changes.

Closing in favor of #1869


Enabling public graphiQL and documentation update

Codecov Report

Merging #204 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #204   +/-   ##
========================================
  Coverage    40.74%   40.74%
========================================
  Files           11       11
  Lines           81       81
  Branches         8        8
========================================
  Hits            33       33
  Misses          46       46
  Partials         2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1847407...d0503c5. Read the comment docs.


Update firecracker/jailer to v0.24-firecracker (with REAP support)

[ ]  update firecracker and jailer binaries to v0.24 with user page faults

Signed-off-by: Dmitrii Ustiugov<EMAIL_ADDRESS>

I've validated that performance of the vanilla and the REAP snapshots is not significantly different than in with firecracker v0.21 that we used for ASPLOS'21 paper evaluation. I suggest we merge this PR and update firecracker-containerd binaries later on. I don't anticipate those changes to be important so they can be done off the critical path.
The binary is built upon firecracker v0.24 with REAP support (branch).


Test with multiple Python versions

Changes
Which issue is resolved by this Pull Request:
Resolves #983
Description of your changes:

use tox-gh to run tests for each Python env
use setup-python's pip cache instead of our own home-grown solution. It's nearly as fast as caching a tox env and less brittle.
cache 4GB model from huggingface
test on Ubuntu / Python 3.9, 3.10, 3.11, and 3.12
test on macOS ARM64 / Python 3.11 (only unit tests, functional shell script does not work on macOS)

I did the rebase. Now CI just needs to run again to make sure it's all still green.

all green!


State updates on this client are slow.

Compared to the original client, state updates are significantly delayed after sending a transaction.

integrated with this: https://github.com/pixelaw/p_war_client/issues/22


Add test renames for alert tests

https://github.com/openshift/origin/pull/28411/files removed the bz- suffix from some alert tests, account for those renames to maintain historical continuity.
ChatGPT helped

#!/usr/bin/env python3
import json
import sys
from collections import defaultdict

def find_tests(data):
    bz_tests = {entry["Name"]: entry["Component"] for entry in data if "[bz-" in entry["Name"]}
    regular_tests = {entry["Name"]: entry["Component"] for entry in data if "[bz-" not in entry["Name"]}

    components = defaultdict(dict)
    for bz_test, component in bz_tests.items():
        regular_test = bz_test.replace("[bz-", "[")
        if regular_test in regular_tests:
            components[component][regular_test] = bz_test

    return components

def main(file_path):
    try:
        with open(file_path, 'r') as file:
            data = json.load(file)
            components = find_tests(data)
            for component, tests in components.items():
                print(f'Component: {component}')
                print('map[string]string{')
                for regular_test, bz_test in tests.items():
                    print(f'    "{regular_test}": "{bz_test}",')
                print('}\n')
    except Exception as e:
        print(f"Error: {e}")

if __name__ == "__main__":
    if len(sys.argv) != 2:
        print("Usage: python script.py <file_path>")
    else:
        main(sys.argv[1])

/lgtm


Embellish README

It would be nice if you had a section showing a) how it used to be done and b) how it's done with graceland.

Partial help from a user of Graceland hoping to help another user: For the how it's done - take a look at test/graceland.spec.js

Thanks! I'll get on it!

README Embellished, good suggestion.  Will somebody look it over for mistakes? Thanks!


Minor Addition of English Translated to Portuguese

Change “in short” to “em resumo”.

[x] I have read [freeCodeCamp's contribution guidelines](htt ps://github.com/freeCodeCamp/freeCodeCamp/blob/master/CONTRIBUTING.md).
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

Thank you for your contribution to the FreeCodeCamp Portuguese Translation!
Contributions like yours help millions of users learn to program in their native language.
Hope you continue to help us with more contributions!


Not working with VPN

Recently a client app was not working, investigation the reason we found that it was because he configured a VPN on his iPhone. This VPN was created by an app called My Data Manager which can be found in the AppStore that measures your cellular data usage. Our team tested and indeed the hasConnection getter always returns false when the VPN is activated.
Steps to reproduce:

Install My Data Manager VPN app

Alright, @JLuisRojas  I'll look into it

same problem, but due to using Adguard on Android, which uses a LOCAL vpn to work. the problem is solved when you disable the vpn connection

I can reproduce this issue with Cloudfare WARP VPN.
Take custom addresses from InternetAddress.lookup to use with InternetConnectionChecker.createInstance doesn't work.

I have the same problem when use the VPN, I am using one pay account from ExpressVpn. I am try with the origin example form the package and I have the same problem. Any workaround for this problem?

same problem too with clash

@jluisrojas Please make sure you are using the latest version of the package, as the library no longer uses sockets to check for internet connectivity. Since this issue has been inactive for a while, I’ll be closing it now. If the problem persists, please file a new issue.


in mac, nothing come out, just a blank screen

Hi
in mac, nothing come out, just a blank screen
/Users/peter>node --version
v8.15.0

I am using latest atom

Facing same issue.
Atom is up-to-date

Terminal comes up and the cursor keeps blinking, nothing else. I'm unable to type anything in that.

I have the same issue on Ubuntu 18.04


Progress Bar in Panel

Hello everyone!
I want to use the Progress Bar in a panel but it's only showing a grey bar and loading a progress in the html element or loading it by using javascript is not doing anything.
Can anyone help me out? Is it impossible to put progress bars in Panels?
Thanks!

Would be good to see what you have tried and how it is not doing anything


fix: color single security scheme

Problem
Currently, if securitySchemes is defined with a single scheme, uncolored security scheme will be displayed in the API client.
Before:

After:

Explanation
The issue is... the needed styles weren't applied to text if a single scheme is provided.
Solution
Move div with class security-scheme-selector to the top of the SecuritySchemeSelector component.

Oh... after opening PR I noticed that CollapsibleSection adds extra styles to any span inside options. Plans changed, so I abandoned the previous solution, and decided to put .security-scheme-selector span into a separate class, and use it for labels.


Unit test for LG parser using sql dictionary

This test is currently skipped. Should work when LG version is >= 5.6.2
Added an sql-formatted LG dictionary to test LG-parser functionality with it.
To solve issue: https://github.com/singnet/language-learning/issues/245

Andres, you made a copy of unit test that makes sure LGParseError exception is raised when improper parammeters are specified. What sort of check you intended your unit test to perform?

Ah, I guess I didn't understand the workings of that test correctly. I just want a test that passes as long as pr.parse() with a db dictionary works fine, and doesn't pass otherwise.

@alexei-gl - please guide @glicerico how to resolve this.


[CARBONDATA-1444] Update documentation about Boolean data type

Add BOOLEAN data type into "supported-data-types-in-carbondata" documentation

SDV Build Fail , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/1293/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/656/

@sgururajshetty  please review it.

LGTM

LGTM


/output folder not working with cifs shares

I have the container setup on a server that has two freeNAS shares which are CIFS mounted on them and I am trying to use them as the watch and output folders. It seems like it is finding the file fine but it seems to fail after the conversion. I opened up the permissions on the shares and it is using the correct uid but conversion still fails. when I setup the same container on the servers storage the conversion worked fine.
Any help with this would be appreciated.
here is the encoding log output for the last small video i tried
Encode failed (error 3).
HandBrake has exited.
------- CONVERSION OUTPUT Fri Sep 13 20:37:08 UTC 2019 -------
Cannot load libnvidia-encode.so.1
Cannot load libnvidia-encode.so.1
Cannot load libnvidia-encode.so.1
Cannot load libnvidia-encode.so.1
[20:37:08] hb_init: starting libhb thread
[20:37:08] thread 7f93fb93fb10 started ("libhb")
HandBrake 1.2.2<PHONE_NUMBER>) - Linux x86_64 - https://handbrake.fr
4 CPUs detected
Opening /watch/Kasm_Pitch2.mp4...
[20:37:08] CPU: Intel(R) Core(TM) i5-2500K CPU @ 3.30GHz
[20:37:08]  - Intel microarchitecture Sandy Bridge
[20:37:08]  - logical processor count: 4
[20:37:08] Intel Quick Sync Video support: no
[20:37:08] hb_scan: path=/watch/Kasm_Pitch2.mp4, title_index=1
[20:37:08] thread 7f93fb928b10 started ("scan")
udfread ERROR: ECMA 167 Volume Recognition failed
disc.c:323: failed opening UDF image /watch/Kasm_Pitch2.mp4
disc.c:424: error opening file BDMV/index.bdmv
disc.c:424: error opening file BDMV/BACKUP/index.bdmv
[20:37:08] bd: not a bd - trying as a stream/file instead
libdvdnav: Using dvdnav version 6.0.0
libdvdread:DVDOpenFileUDF:UDFFindFile /VIDEO_TS/VIDEO_TS.IFO failed
libdvdread:DVDOpenFileUDF:UDFFindFile /VIDEO_TS/VIDEO_TS.BUP failed
libdvdread: Can't open file VIDEO_TS.IFO.
libdvdnav: vm: failed to read VIDEO_TS.IFO
[20:37:08] dvd: not a dvd - trying as a stream/file instead
Input #0, mov,mp4,m4a,3gp,3g2,mj2, from '/watch/Kasm_Pitch2.mp4':
  Metadata:
    major_brand     : mp42
    minor_version   : 0
    major_brand     : mp42
    minor_version   : 0
    compatible_brands: isommp42
    creation_time   : 2019-09-12T15:22:35.000000Z
  Duration: 00:01:00.02, start: 0.000000, bitrate: 2363 kb/s
    Stream #0:0(eng): Video: h264 (High) (avc1 / 0x31637661), yuv420p(tv, smpte170m/bt709/bt709), 1920x1080 [SAR 1:1 DAR 16:9], 2235 kb/s, 30 fps, 30 tbr, 30k tbn, 60 tbc (default)
    Metadata:
      creation_time   : 2019-09-12T15:22:37.000000Z
      handler_name    : Mainconcept MP4 Video Media Handler
      encoder         : AVC Coding
    Stream #0:1(eng): Audio: aac (LC) (mp4a / 0x6134706D), 44100 Hz, stereo, fltp, 125 kb/s (default)
    Metadata:
      creation_time   : 2019-09-12T15:22:37.000000Z
      handler_name    : Mainconcept MP4 Sound Media Handler
[20:37:08] Found ffmpeg 0 chapters, container=mov,mp4,m4a,3gp,3g2,mj2
[20:37:08] scan: decoding previews for title 1
^MScanning title 1 of 1, preview 1, 0.00 %[20:37:08] scan: preview 1
[20:37:08] fifo_close: trashing 0 buffer(s)
[20:37:08] scan: audio 0x1: aac, rate=44100Hz, bitrate=125662 English (AAC LC) (2.0 ch)
[20:37:08] scan: preview 2
[20:37:08] scan: preview 3
[20:37:08] scan: preview 4
[20:37:08] scan: preview 5
^MScanning title 1 of 1, preview 5, 50.00 %[20:37:08] scan: preview 6
[20:37:08] scan: preview 7
[20:37:08] scan: preview 8
[20:37:08] scan: preview 9
[20:37:08] scan: preview 10
[20:37:09] scan: 10 previews, 1920x1080, 30.000 fps, autocrop = 0/0/0/0, aspect 16:9, PAR 1:1
[20:37:09] scan: supported video decoders: avcodec qsv
[20:37:09] Freed 1 buffers of size 1024
[20:37:09] Freed 1 buffers of size 2048
[20:37:09] Freed 1 buffers of size 4096
[20:37:09] Freed 1 buffers of size 8192
[20:37:09] Freed 1 buffers of size 16384
[20:37:09] Freed 1 buffers of size 32768
[20:37:09] Freed 1 buffers of size 65536
[20:37:09] Freed 1 buffers of size 131072
[20:37:09] Freed 2 buffers of size 4194304
[20:37:09] Allocated 8649728 bytes of buffers on this pass and Freed 8649728 bytes, 0 bytes leaked
[20:37:09] thread 7f93fb928b10 exited ("scan")
[20:37:09] thread 7f93fb928b10 joined ("scan")
[20:37:09] libhb: scan thread found 1 valid title(s)
+ Using preset: Very Fast 1080p30
+ title 1:
  + stream: /watch/Kasm_Pitch2.mp4
  + duration: 00:01:00
  + size: 1920x1080, pixel aspect: 1/1, display aspect: 1.78, 30.000 fps
  + autocrop: 0/0/0/0
  + chapters:
    + 1: cells 0->0, 0 blocks, duration 00:01:00
  + audio tracks:
    + 1, English (AAC LC) (2.0 ch) (iso639-2: eng)
  + subtitle tracks:
[20:37:09] thread 7f93fb928b10 started ("work")
[20:37:09] 1 job(s) to process
[20:37:09] json job:
{
    "Audio": {
        "AudioList": [
            {
                "Bitrate": 160,
                "CompressionLevel": -1.0,
                "DRC": 0.0,
                "CompressionLevel": -1.0,
                "DRC": 0.0,
                "DitherMethod": "auto",
                "Encoder": "fdk_aac",
                "Gain": 0.0,
                "Mixdown": "stereo",
                "NormalizeMixLevel": false,
                "PresetEncoder": "fdk_aac",
                "Quality": -3.0,
                "Samplerate": 0,
                "Track": 0
            }
        ],
        "CopyMask": [
            "copy:aac"
        ],
        "FallbackEncoder": "fdk_aac"
    },
    "Destination": {
        "AlignAVStart": true,
        "ChapterList": [
            {
                "Name": ""
            }
        ],
        "ChapterMarkers": false,
        "File": "/output/.wG8AZm/Kasm_Pitch2.mp4",
        "InlineParameterSets": false,
        "Mp4Options": {
            "IpodAtom": false,
            "Mp4Optimize": false
        },
        "Mux": "m4v"
    },
    "Filters": {
        "FilterList": [
            {
                "ID": 3,
                "Settings": {
                    "block-height": "16",
                    "block-thresh": "80",
                    "block-width": "16",
                    "filter-mode": "1",
                    "mode": "0",
                    "motion-thresh": "2",
                    "spatial-metric": "2",
                    "spatial-thresh": "3"
                }
            },
            {
                "ID": 4,
                "Settings": {
                    "mode": "7"
                }
            },
            {
                "ID": 6,
                "Settings": {
                    "mode": 2,
                    "rate": "27000000/900000"
                }
            },
            {
                "ID": 11,
            {
                "ID": 11,
                "Settings": {
                    "crop-bottom": 0,
                    "crop-left": 0,
                    "crop-right": 0,
                    "crop-top": 0,
                    "height": 1080,
                    "width": 1920
                }
            }
        ]
    },
    "Metadata": {},
    "PAR": {
        "Den": 1,
        "Num": 1
    },
    "SequenceID": 0,
    "Source": {
        "Angle": 0,
        "Path": "/watch/Kasm_Pitch2.mp4",
        "Range": {
            "End": 1,
            "Start": 1,
            "Type": "chapter"
        },
        "Title": 1
    },
    "Subtitle": {
        "Search": {
            "Burn": true,
            "Default": false,
            "Enable": false,
            "Forced": false
        },
        "SubtitleList": []
    },
    "Video": {
        "ColorMatrix": 6,
        "ColorPrimaries": 1,
        "ColorTransfer": 1,
        "Encoder": "x264",
        "Level": "4.0",
        "Options": "",
        "Preset": "veryfast",
        "Profile": "main",
        "QSV": {
            "AsyncDepth": 4,
            "Decode": false
        },
        "Quality": 24.0,
        "Tune": "",
        "Turbo": false,
        "TwoPass": false
    }
}
[20:37:09] starting job
[20:37:09] thread 7f93fb907b10 started ("decomb_filter_segment")
[20:37:09] decomb filter thread started for segment 0
[20:37:09] thread 7f93facdbb10 started ("decomb_filter_segment")
[20:37:09] decomb filter thread started for segment 1
[20:37:09] thread 7f93facc4b10 started ("decomb_filter_segment")
[20:37:09] decomb filter thread started for segment 2
[20:37:09] thread 7f93facc4b10 started ("decomb_filter_segment")
[20:37:09] decomb filter thread started for segment 2
[20:37:09] thread 7f93facadb10 started ("decomb_filter_segment")
[20:37:09] decomb filter thread started for segment 3
[20:37:09] thread 7f93fac96b10 started ("decomb_check_segment")
[20:37:09] decomb check thread started for segment 0
[20:37:09] thread 7f93fac7fb10 started ("decomb_check_segment")
[20:37:09] decomb check thread started for segment 1
[20:37:09] thread 7f93fac68b10 started ("decomb_check_segment")
[20:37:09] decomb check thread started for segment 2
[20:37:09] thread 7f93fac51b10 started ("decomb_check_segment")
[20:37:09] decomb check thread started for segment 3
[20:37:09] thread 7f93fac3ab10 started ("yadif_filter_segment")
[20:37:09] yadif thread started for segment 0
[20:37:09] thread 7f93fac23b10 started ("yadif_filter_segment")
[20:37:09] yadif thread started for segment 1
[20:37:09] thread 7f93fac0cb10 started ("yadif_filter_segment")
[20:37:09] yadif thread started for segment 2
[20:37:09] thread 7f93fabf5b10 started ("yadif_filter_segment")
[20:37:09] yadif thread started for segment 3
[20:37:09] job configuration:
[20:37:09]  * source
[20:37:09]    + /watch/Kasm_Pitch2.mp4
[20:37:09]    + title 1, chapter(s) 1 to 1
[20:37:09]    + container: mov,mp4,m4a,3gp,3g2,mj2
[20:37:09]    + data rate: 2363 kbps
[20:37:09]  * destination
[20:37:09]    + /output/.wG8AZm/Kasm_Pitch2.mp4
[20:37:09]    + container: MPEG-4 (libavformat)
[20:37:09]      + align initial A/V stream timestamps
[20:37:09]  * video track
[20:37:09]    + decoder: h264
[20:37:09]      + bitrate 2235 kbps
[20:37:09]    + filters
[20:37:09]      + Comb Detect (mode=0:spatial-metric=2:motion-thresh=2:spatial-thresh=3:filter-mode=1:block-thresh=80:block-width=16:block-height=16)
[20:37:09]      + Decomb (mode=39)
[20:37:09]      + Framerate Shaper (mode=2:rate=27000000/900000)
[20:37:09]        + frame rate: 30.000 fps -> peak rate limited to 30.000 fps
[20:37:09]      + Crop and Scale (width=1920:height=1080:crop-top=0:crop-bottom=0:crop-left=0:crop-right=0)
[20:37:09]        + source: 1920 * 1080, crop (0/0/0/0): 1920 * 1080, scale: 1920 * 1080
[20:37:09]    + Output geometry
[20:37:09]      + storage dimensions: 1920 x 1080
[20:37:09]      + pixel aspect ratio: 1 : 1
[20:37:09]      + display dimensions: 1920 x 1080
[20:37:09]    + encoder: H.264 (libx264)
[20:37:09]      + preset:  veryfast
[20:37:09]      + profile: main
[20:37:09]      + level:   4.0
[20:37:09]      + quality: 24.00 (RF)
[20:37:09]      + color profile: 1-1-6
[20:37:09]  * audio track 1
[20:37:09]    + decoder: English (AAC LC) (2.0 ch) (track 1, id 0x1)
[20:37:09]      + bitrate: 125 kbps, samplerate: 44100 Hz
[20:37:09]    + mixdown: Stereo
[20:37:09]    + dither: triangular
[20:37:09]    + encoder: AAC (libfdk_aac)
[20:37:09]      + bitrate: 160 kbps, samplerate: 44100 Hz
[20:37:09] sync: expecting 1800 video frames
[20:37:09] thread 7f93fab13b10 started ("Audio Synchronization")
[20:37:09] encx264: min-keyint: 30, keyint: 300
[20:37:09] encx264: encoding at constant RF 24.000000
[20:37:09] encx264: unparsed options: level=4.0:ref=1:8x8dct=0:weightp=1:subme=2:mixed-refs=0:trellis=0:vbv-bufsize=25000:vbv-maxrate=20000:rc-lookahead=10
[20:37:09] encx264: opening libx264 (pass 0)
x264 [info]: using SAR=1/1
[20:37:09] encx264: opening libx264 (pass 0)
x264 [info]: using SAR=1/1
x264 [info]: using cpu capabilities: MMX2 SSE2Fast SSSE3 SSE4.2 AVX
x264 [info]: profile Main, level 4.0
ERROR: avio_open2 failed, errno -13
[20:37:09] thread 7f93f136bb10 started ("Muxer")
[20:37:09] thread 7f93f1354b10 started ("Reader")
[20:37:09] thread 7f93f133db10 started ("Audio decoder (libavcodec)")
[20:37:09] thread 7f93f1326b10 started ("Video decoder (libavcodec)")
[20:37:09] thread 7f93f130fb10 started ("Video Synchronization")
[20:37:09] thread 7f93f12f8b10 started ("AVCodec Audio encoder (libavcodec)")
[20:37:09] ffmpeg_read starting chapter 1 at 0
[20:37:09] thread 7f93f12e1b10 started ("H.264/AVC encoder (libx264)")
[20:37:09] thread 7f93f12cab10 started ("Muxer")
[20:37:09] thread 7f93f12b3b10 started ("Comb Detect")
[20:37:09] thread 7f93f129cb10 started ("Decomb")
[20:37:09] thread 7f93f1285b10 started ("Framerate Shaper")
[20:37:09] thread 7f93f126eb10 started ("Crop and Scale")
[20:37:09] reader: done. 1 scr changes
[20:37:09] worker Reader waiting to die
[20:37:09] thread 7f93f1354b10 exited ("Reader")
[20:37:09] worker Muxer waiting to die
[20:37:09] thread 7f93f12cab10 exited ("Muxer")
[20:37:09] thread 7f93f12cab10 joined ("Muxer")
[20:37:09] work: average encoding speed for job is 0.000000 fps
[20:37:09] worker Audio Synchronization waiting to die
[20:37:09] thread 7f93fab13b10 exited ("Audio Synchronization")
[20:37:09] worker Muxer waiting to die
[20:37:09] worker Video decoder (libavcodec) waiting to die
[20:37:09] worker Audio decoder (libavcodec) waiting to die
[20:37:09] thread 7f93f136bb10 exited ("Muxer")
[20:37:09] thread 7f93f133db10 exited ("Audio decoder (libavcodec)")
[20:37:09] thread 7f93f1326b10 exited ("Video decoder (libavcodec)")
[20:37:09] worker AVCodec Audio encoder (libavcodec) waiting to die
[20:37:09] worker Video Synchronization waiting to die
[20:37:09] thread 7f93f12f8b10 exited ("AVCodec Audio encoder (libavcodec)")
[20:37:09] thread 7f93f130fb10 exited ("Video Synchronization")
[20:37:09] thread 7f93f12b3b10 exited ("Comb Detect")
[20:37:09] thread 7f93f126eb10 exited ("Crop and Scale")
[20:37:09] thread 7f93f12b3b10 joined ("Comb Detect")
[20:37:09] worker H.264/AVC encoder (libx264) waiting to die
[20:37:09] thread 7f93f1285b10 exited ("Framerate Shaper")
[20:37:09] comb detect: heavy 0 | light 0 | uncombed 0 | total 0
[20:37:09] thread 7f93f129cb10 exited ("Decomb")
[20:37:09] thread 7f93fb907b10 exited ("decomb_filter_segment")
[20:37:09] thread 7f93facdbb10 exited ("decomb_filter_segment")
[20:37:09] thread 7f93facc4b10 exited ("decomb_filter_segment")
[20:37:09] thread 7f93facadb10 exited ("decomb_filter_segment")
[20:37:09] thread 7f93f12e1b10 exited ("H.264/AVC encoder (libx264)")
[20:37:09] thread 7f93fb907b10 joined ("decomb_filter_segment")
[20:37:09] thread 7f93facdbb10 joined ("decomb_filter_segment")
[20:37:09] thread 7f93facc4b10 joined ("decomb_filter_segment")
[20:37:09] thread 7f93facadb10 joined ("decomb_filter_segment")
[20:37:09] thread 7f93fac96b10 exited ("decomb_check_segment")
[20:37:09] thread 7f93fac7fb10 exited ("decomb_check_segment")
[20:37:09] thread 7f93fac68b10 exited ("decomb_check_segment")
[20:37:09] thread 7f93fac51b10 exited ("decomb_check_segment")
[20:37:09] thread 7f93fac96b10 joined ("decomb_check_segment")
[20:37:09] thread 7f93fac7fb10 joined ("decomb_check_segment")
[20:37:09] thread 7f93fac68b10 joined ("decomb_check_segment")
[20:37:09] thread 7f93fac51b10 joined ("decomb_check_segment")
[20:37:09] thread 7f93f129cb10 joined ("Decomb")
[20:37:09] decomb: deinterlaced 0 | blended 0 | unfiltered 0 | total 0
[20:37:09] thread 7f93fac3ab10 exited ("yadif_filter_segment")
[20:37:09] decomb: deinterlaced 0 | blended 0 | unfiltered 0 | total 0
[20:37:09] thread 7f93fac3ab10 exited ("yadif_filter_segment")
[20:37:09] thread 7f93fac23b10 exited ("yadif_filter_segment")
[20:37:09] thread 7f93fac0cb10 exited ("yadif_filter_segment")
[20:37:09] thread 7f93fabf5b10 exited ("yadif_filter_segment")
[20:37:09] thread 7f93fac3ab10 joined ("yadif_filter_segment")
[20:37:09] thread 7f93fac23b10 joined ("yadif_filter_segment")
[20:37:09] thread 7f93fac0cb10 joined ("yadif_filter_segment")
[20:37:09] thread 7f93fabf5b10 joined ("yadif_filter_segment")
[20:37:09] thread 7f93f1285b10 joined ("Framerate Shaper")
[20:37:09] vfr: 0 frames output, 0 dropped and 0 duped for CFR/PFR
[20:37:09] vfr: lost time: 0 (0 frames)
[20:37:09] vfr: gained time: 0 (0 frames) (0 not accounted for)
[20:37:09] fifo_close: trashing 0 buffer(s)
[20:37:09] thread 7f93f126eb10 joined ("Crop and Scale")
[20:37:09] thread 7f93f1354b10 joined ("Reader")
[20:37:09] thread 7f93f133db10 joined ("Audio decoder (libavcodec)")
[20:37:09] thread 7f93f1326b10 joined ("Video decoder (libavcodec)")
[20:37:09] thread 7f93f130fb10 joined ("Video Synchronization")
[20:37:09] thread 7f93f12f8b10 joined ("AVCodec Audio encoder (libavcodec)")
[20:37:09] thread 7f93f12e1b10 joined ("H.264/AVC encoder (libx264)")
[20:37:09] aac-decoder done: 0 frames, 0 decoder errors
[20:37:09] h264-decoder done: 0 frames, 0 decoder errors
[20:37:09] sync: got 0 frames, 1800 expected
[20:37:09] thread 7f93fab13b10 joined ("Audio Synchronization")
[20:37:09] encavcodecaudio: closing libavcodec
[20:37:09] thread 7f93f136bb10 joined ("Muxer")
[20:37:09] fifo_close: trashing 0 buffer(s)
[20:37:09] fifo_close: trashing 0 buffer(s)
[20:37:09] fifo_close: trashing 0 buffer(s)
[20:37:09] fifo_close: trashing 0 buffer(s)
[20:37:09] fifo_close: trashing 0 buffer(s)
[20:37:09] fifo_close: trashing 0 buffer(s)
[20:37:09] fifo_close: trashing 0 buffer(s)
[20:37:09] fifo_close: trashing 0 buffer(s)
[20:37:09] fifo_close: trashing 0 buffer(s)
[20:37:09] fifo_close: trashing 0 buffer(s)
[20:37:09] fifo_close: trashing 0 buffer(s)
[20:37:09] fifo_close: trashing 0 buffer(s)
[20:37:09] Freed 1 buffers of size 1024
[20:37:09] Freed 1 buffers of size 2048
[20:37:09] Freed 1 buffers of size 4096
[20:37:09] Freed 1 buffers of size 8192
[20:37:09] Freed 1 buffers of size 16384
[20:37:09] Freed 1 buffers of size 32768
[20:37:09] Freed 1 buffers of size 65536
[20:37:09] Freed 1 buffers of size 131072
[20:37:09] Freed 1 buffers of size 262144
[20:37:09] Freed 3 buffers of size 4194304
[20:37:09] Allocated 13106176 bytes of buffers on this pass and Freed 13106176 bytes, 0 bytes leaked
[20:37:09] thread 7f93fb928b10 exited ("work")
[20:37:09] thread 7f93fb928b10 joined ("work")
[20:37:09] libhb: work result = 3

Encode failed (error 3).
[20:37:09] thread 7f93fb93fb10 exited ("libhb")
[20:37:09] thread 7f93fb93fb10 joined ("libhb")
HandBrake has exited.

I switched to using an NFS share on the same folder as the cifs share and it is working but I am still unsure how one would go about getting the right permissions for the container in cifs. I will just use NFS share for this specific folder but this may be useful to anyone else using freeNAS who has not gotten it to work.

With the cifs share, did you try to do a write test from within the container, using the same user as HandBrake?

Yeah I did. For whatever reason I could not get the shares to have write permission even when I opened it up to guest access. I have other containers able to read and write to those drives but couldn't figure out this one. However now with nfs shares everything is running smoothly.

Closing this issue.  Please re-open if needed.


Fill in missing documentation

See https://github.com/vydd/sketch/pull/74, further work is needed.

[ ] Generate TOC, as github org files viewer doesn't generate one.
[ ] figures, controllers, channels?

[ ] defsketch bindings possibilities


set Access-Control-Allow-Headers to a static string

Codecov Report

Merging #1973 (6086012) into main (5033d1e) will decrease coverage by 0.16%.
The diff coverage is 33.33%.

:exclamation: Current head 6086012 differs from pull request most recent head cab41cd. Consider uploading reports for the commit cab41cd to get more accurate results

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@            Coverage Diff             @@
##             main    #1973      +/-   ##
==========================================
- Coverage   61.06%   60.90%   -0.16%
==========================================
  Files         108      108
  Lines       11459    11459
==========================================
- Hits         6997     6979      -18
- Misses       3946     3965      +19
+ Partials      516      515       -1

Impacted Files
Coverage Δ

internal/core/hls_http_server.go
63.96% <0.00%> (ø)

internal/core/webrtc_http_server.go
61.69% <50.00%> (ø)

... and 4 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Build error with protobuf-3.6.0

Hi ,
I got this compile error when trying to build from source. May I know which protobuf version that you use to build this
make[3]: Entering directory '/home/tam/protobuf-analysis/protobluff/src/generator'
CXX      protoc_gen_protobluff-enum.o
In file included from enum.cc:31:0:
../../src/generator/enum.hh:46:29: error: ‘google::protobuf::scoped_array’ has not been declared
using ::google::protobuf::scoped_array;
^~~~~~~~~~~~
../../src/generator/enum.hh:47:29: error: ‘google::protobuf::scoped_ptr’ has not been declared
using ::google::protobuf::scoped_ptr;
^~~~~~~~~~
../../src/generator/enum.hh:74:5: error: ‘scoped_array’ does not name a type; did you mean ‘sched_param’?
scoped_array<
^~~~~~~~~~~~
sched_param
In file included from enum.cc:33:0:
../../src/generator/strutil.hh:169:42: error: ‘vector’ has not been declared
vector* res);
^~~~~~
../../src/generator/strutil.hh:169:48: error: expected ‘,’ or ‘...’ before ‘<’ token
vector* res);
^
../../src/generator/strutil.hh:181:47: error: ‘vector’ has not been declared
vector* result);
^~~~~~
../../src/generator/strutil.hh:181:53: error: expected ‘,’ or ‘...’ before ‘<’ token
vector* result);
^
../../src/generator/strutil.hh:191:43: error: ‘vector’ does not name a type; did you mean ‘perror’?
LIBPROTOBUF_EXPORT void JoinStrings(const vector& components,
^~~~~~
perror
../../src/generator/strutil.hh:191:49: error: expected ‘,’ or ‘...’ before ‘<’ token
LIBPROTOBUF_EXPORT void JoinStrings(const vector& components,
^
../../src/generator/strutil.hh:194:33: error: ‘vector’ does not name a type; did you mean ‘perror’?
inline string JoinStrings(const vector& components,
^~~~~~
perror
../../src/generator/strutil.hh:194:39: error: expected ‘,’ or ‘...’ before ‘<’ token
inline string JoinStrings(const vector& components,
^
../../src/generator/strutil.hh: In function ‘std::cxx11::string google::protobuf::JoinStrings(int)’:
../../src/generator/strutil.hh:194:15: error: ambiguating new declaration of ‘std::cxx11::string google::protobuf::JoinStrings(int)’
inline string JoinStrings(const vector& components,
^~~~~~~~~~~
../../src/generator/strutil.hh:191:25: note: old declaration ‘void google::protobuf::JoinStrings(int)’
LIBPROTOBUF_EXPORT void JoinStrings(const vector& components,
^~~~~~~~~~~
../../src/generator/strutil.hh:197:15: error: ‘components’ was not declared in this scope
JoinStrings(components, delim, &result);
^~~~~~~~~~
../../src/generator/strutil.hh:197:27: error: ‘delim’ was not declared in this scope
JoinStrings(components, delim, &result);
^~~~~
../../src/generator/strutil.hh:197:27: note: suggested alternative: ‘getdelim’
JoinStrings(components, delim, &result);
^~~~~
getdelim
../../src/generator/strutil.hh: At global scope:
../../src/generator/strutil.hh:234:49: error: ‘vector’ has not been declared
vector *errors);
^~~~~~
../../src/generator/strutil.hh:234:55: error: expected ‘,’ or ‘...’ before ‘<’ token
vector *errors);
^
../../src/generator/strutil.hh:253:46: error: ‘vector’ has not been declared
vector *errors);
^~~~~~
../../src/generator/strutil.hh:253:52: error: expected ‘,’ or ‘...’ before ‘<’ token
vector errors);
^
enum.cc:47:29: error: ‘google::protobuf::scoped_ptr’ has not been declared
using ::google::protobuf::scoped_ptr;
^~~~~~~~~~
enum.cc: In constructor ‘protobluff::Enum::Enum(const google::protobuf::EnumDescriptor)’:
enum.cc:61:7: error: class ‘protobluff::Enum’ does not have any field named ‘values’
values(new scoped_ptr[descriptor->value_count()]) {
^~~~~~~
enum.cc:61:19: error: ‘scoped_ptr’ does not name a type; did you mean ‘sched_param’?
values(new scoped_ptr[descriptor_->value_count()]) {
^~~~~~~~~~
sched_param
enum.cc:61:39: error: expected primary-expression before ‘>’ token
values_(new scoped_ptr[descriptor_->value_count()]) {
^
enum.cc:61:41: error: capture of non-variable ‘protobluff::Enum::descriptor_’
values_(new scoped_ptr[descriptor_->value_count()]) {
^~~~~~~~~~~
In file included from enum.cc:31:0:
../../src/generator/enum.hh:73:27: note: ‘const google::protobuf::EnumDescriptor* protobluff::Enum::descriptor_’ declared here
const EnumDescriptor descriptor_; / Enum descriptor /
^~~~~~~~~~~
enum.cc:61:52: error: expected ‘,’ before ‘->’ token
values_(new scoped_ptr[descriptor_->value_count()]) {
^~
enum.cc:61:52: error: expected identifier before ‘->’ token
enum.cc: In lambda function:
enum.cc:61:68: error: expected ‘{’ before ‘)’ token
values_(new scoped_ptr[descriptor_->value_count()]) {
^
enum.cc: In constructor ‘protobluff::Enum::Enum(const google::protobuf::EnumDescriptor)’:
enum.cc:71:7: error: ‘values_’ was not declared in this scope
values_[v].reset(sorted[v]);
^~~~~~~
enum.cc: In member function ‘void protobluff::Enum::GenerateValues(google::protobuf::io::Printer*) const’:
enum.cc:93:7: error: ‘values_’ was not declared in this scope
values_[v]->GenerateValue(printer);
^~~~~~~
enum.cc: In member function ‘void protobluff::Enum::GenerateDescriptor(google::protobuf::io::Printer*) const’:
enum.cc:135:9: error: ‘values_’ was not declared in this scope
values_[v]->GenerateDescriptor(printer);
^~~~~~~
Makefile:506: recipe for target 'protoc_gen_protobluff-enum.o' failed
make[3]: *** [protoc_gen_protobluff-enum.o] Error 1
make[3]: Leaving directory '/home/tam/protobuf-analysis/protobluff/src/generator'
Makefile:546: recipe for target 'all-recursive' failed
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory '/home/tam/protobuf-analysis/protobluff/src'
Makefile:500: recipe for target 'all-recursive' failed
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory '/home/tam/protobuf-analysis/protobluff'
Makefile:411: recipe for target 'all' failed
make: *** [all] Error 2

Can you give some details on the versions you were using?

I clone the source from https://github.com/protocolbuffers/protobuf
commit 436139803ffbe0ca3dc0e563b63f29b2fd729d4f (HEAD -> master, origin/master, origin/HEAD)
Author: dyyap<EMAIL_ADDRESS>Date:   Thu Nov 15 18:47:08 2018 -0800
Updated README.md (#5366)

* Update README.md

g++ (Ubuntu 7.2.0-8ubuntu3.2) 7.2.0
Copyright (C) 2017 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
Ubuntu 16.04

Which version of the protobuf library are you using? I mean the original Google Protocol Buffers C++ library which is necessary to compile the generator.

This could be related:
https://github.com/protocolbuffers/protobuf/blob/f22be4ddb0c8b8f81f84d106c74a812ee87f4c6b/CHANGES.txt#L20-L21
It seems that in order to be compatible with 3.6.x we need to adjust some types. Unfortunately my time is very limited at the moment, so I would suggest falling back to protobuf-3.5.1 when building the generator. I'm also happy to merge PRs.

Fixed in master by #4 for protobuf-3.6. Still errors for protobuf-3.7, waiting until we resolved them for a new release.

Fixed by a9cc5c1, released as part of 1.1.0.


Contributing.md refences folders which no longer exist

In the section on submitting pr's it says to include a test with folders which they should be in but the folders no longer exist
neither
test/rules
nor
test/options/preset
exist any longer they should be updated to i believe
/test/specs/rules
and
/test/data/options/preset

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/26351007-contributing-md-refences-folders-which-no-longer-exist?utm_campaign=plugin&utm_content=tracker%2F281640&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F281640&utm_medium=issues&utm_source=github).

Do you want to submit a PR?

Made https://github.com/jscs-dev/node-jscs/pull/1765


can you add an Arm64 version?

I was able to create my own personal server setup with this but wanted to move to a free Oracle Cloud setup....would you be able to support an arm64 version of this? or if anyone can point me to the right direction on how to port this over to an arm64 version?

OP has posted the Dockerfile and it appears to be based on the Ubuntu image (which has an aarch64 version). No reason why you couldnt git clone and attempt to docker build locally.
Failing that, you can try running with "--platform linux/amd64" in your docker run command (or use the equiv flag in your compose yaml). It will tell docker that youre trying to run an x86 image and emulate it. Performance wont be as good but itll run.


Incorrect status filter in Related Products query

Current behavior
The related products query returns products with status 0, 1 and 2. Only 1 and 2 are used in Magento which represent enabled and disabled. I'm not sure that 0 stands for.
We ran into the problem where a disabled product was displayed in the related products area. Clicking on this product returned an error as the product was not meant to be viewed.
Expected behavior
The expected behaviour is that only enabled products, with status:1, should be returned by the query.
Steps to reproduce the issue
I can't find this specific related products module on the demo shop so I can't deliver the steps to reproduce.
Can you handle fixing this bug by yourself?

[X] YES
[ ] NO

Which Release Cycle state this refers to? Info for developer.
Pick one option.

[X] This is a bug report for test version on https://test.storefrontcloud.io - In this case Developer should create branch from develop branch and create Pull Request 2. Feature / Improvement back to develop.
[ ] This is a bug report for current Release Candidate version on https://next.storefrontcloud.io - In this case Developer should create branch from release branch and create Pull Request 3. Stabilisation fix back to release.
[ ] This is a bug report for current Stable version on https://demo.storefrontcloud.io and should be placed in next stable version hotfix - In this case Developer should create branch from hotfix or master branch and create Pull Request 4. Hotfix back to hotfix.

Environment details

Browser: Chrome, Version 73.0.3683.86
OS: MacOS 10.14.4
Node: node v8.16

Additional information
The related products query filters products with status 0, 1 and 2. 1 and 2 are used in Magento for enabled and disabled but what is 0 used for? In any case you would want only enabled products to be displayed as related products else you'll receive an error for clicking on a disabled product.

Thanks! Feel free to propose a PR with a fix for that


Standard for getMerchantReference

I think we should have a recommended function to normalise getMerchantReference() on the CompletePurchase class.
As has been pointed out in other comments not all gateways return the original merchant reference. But, most do. Further it is more 'special' than other data fields in that it is the unique identifier of the transaction from the merchant's point of view.
Generally to match up an incoming payment we use either the transactionReference (provided by the gateway) or the merchantReference (provided by the website implementing Omnipay).
I would suggest that while not all gateways provide it we should have a recommended function to return the merchant reference if it exists (the parent class would return empty if not overridden)
An example of where this would help is Mollie. Here we have a situation where the implementation could, but doesn't add the merchantReference to the data passed to the processor when it is set and hence could but doesn't extract the merchantReference at the other end. Without this reference we can't make sense of the return result.
Now of course having spent some hours researching Mollie we can figure out that  establish that there is a specific way to call Mollie to make all of this work and turn our code into a switch-fest of special cases for each processor we have integrated.
But if there was a recommended way to do this then we could propose a patch to Mollie and the next person who came along wouldn't need to spend hours researching Mollie they could rely on
$request->setMerchantReference()  & $response->getMerchantReference() passing their merchant reference through Mollie.
There are a bunch of others that implement various slightly different functions to get whatever that gateway calls the merchantReference - and adding a guideline wouldn't instantly change them - but at least they would hopefully be working towards a recommendation in here - and people would be patch-welcome if they wanted to add that method to retrieve the merchantReference
https://github.com/thephpleague/omnipay#successful-response

Is this the key passed to the merchant site callback, used to look up the transaction in the local storage, i.e. in the database?

I just looked and when you set up the call you do
$request->setTransactionId()
so I think what I have been calling merchantReference (from some gateway or other) should be
$respose->getTransactionId()
I took a quick look and it doesn't seem to me to be the case that the completePurchase requests consistently support that.
And Authorize.net is a similar case to Mollie. There is no standardised way to pass this ID - but it could be standardised internally within Omnipay.
So, is the right answer to 'encourage' libraries to support this by updating the documentation & doing pull requests to the ones that we are directly affected by?

For the Authorize.Net driver, the transactionId is stuffed into the x_invoice_num field. That, I suspect, came from an older implementation on another platform - it is how osCommerce and X-Cart do it, from what I've seen. I do thing they are all wrong, and OmniPay can bring its own custom field to the driver, leaving the x_invoice_num field for its intended purpose.
Are there some examples you can point is to? Just to make sure we are talking about the same thing, this is about how to pass the merchant site's unique transaction ID to the gateway, so that the gateway is able to pass it to the merchant site with the authorisation results in the callback, and then the callback handler is easily able to get that transaction ID so it can fetch the transaction from the database. Is that your understanding, or have I come at this with a different problem in my head to the one you are trying to describe (won't be the first time:-) ?

Yes - I think we are on the same track!
https://github.com/thephpleague/omnipay#gateway-methods
defines transactionId
as an 'main parameter'
The gateway should ensure that the transactionId is passed to the payment provider in such a way that it can extract that value from any return reponse (generally within the CompletePurchase set of classes).
Where the transactionId is already passed back - in field x then the class should implement getTransactionID to be a consistent way of retrieving it. For example if I'm reading this processor correctly you would currently need to 'know' how to extract the transactionId by calling getResultElement correctly whereas they could implement a getTransactionId function to sort that out. (NB I'm not familiary with cardsave - I just picked it)
https://github.com/eileenmcnaughton/nz.co.fuzion.omnipaymultiprocessor/blob/master/vendor/omnipay/cardsave/src/Message/Response.php#L29-29

I have added pull requests to the 2 repos
https://github.com/thephpleague/omnipay/pull/262
https://github.com/thephpleague/omnipay-common/pull/41


Fix bug where Job.__repr__() thows exception on partially composed job object

Fix bug where Job.__repr__() thows exception on partially composed job.

Closes #485

#569 was just merged that resolves the issue that this pr resolves. I believe that makes this pr obsolete. Still, thank you for your willingness to help!


fix low quality recording for android

fix low quality recording for android
As the MediaRecorder's default values seem to produce a very low quality recording..

Thanks for the pull request. the idea is overall good but I would prefer
to leave the quality as is, as the current recording quality was intentional (to take less space)
although I think I'll add the ability to control the quality as part of the plugin configuration


[inference] clarify the number of outstanding queries allowed.

My understanding is that:
Single Stream: 1 outstanding queries allowed
Multi Stream: 1 outstanding queries allowed
Server: X outstanding queries allowed with X as the total number of queries
Offline: there is only 1 query sent in total so not applicable.  @briandersn

This matches my understanding. There was a proposed liberalization for Multi-Stream, but it didn't seem like there as a lot of enthusiasm for it in the WG.