[BUG] Retention periods are being ignored by restic forget when "${extra_args[@]}" is empty

When the variable  "${extra_args[@]}" is empty, the retention period options will be ignored and this warning will show up
Ignoring "": multiple IDs with prefix "" found
Ignoring "filters": explicit snapshot ids are given

I was able to solve my issue by removing the "${extra_args[@]}"  variable from restic forget in restic_backup.sh
restic forget \
        --verbose="$RESTIC_VERBOSITY_LEVEL" \
        --tag "$RESTIC_BACKUP_TAG" \
        "${B2_ARG[@]}" \
        "${extra_args[@]}" \       <======== REMOVED THIS to solve my issue
        --prune \
        --group-by "paths,tags" \
        --keep-hourly "$RESTIC_RETENTION_HOURS" \
        --keep-daily "$RESTIC_RETENTION_DAYS" \
        --keep-weekly "$RESTIC_RETENTION_WEEKS" \
        --keep-monthly "$RESTIC_RETENTION_MONTHS" \
        --keep-yearly "$RESTIC_RETENTION_YEARS" &
wait $!

OS: Ubuntu 22.04.2 LTS
Restic Version: 0.16.0 compiled with go1.20.6 on linux/amd64

Hey thanks for reporting this!
This was introduced recently in https://github.com/erikw/restic-automatic-backup-scheduler/pull/115
I currently am not able to look in to this. Maybe @nettnikl would have time to take a look possible? :)

Sure thing! Might be caused by an empty array being used where we want nothing at all? @georgioghazzi could you put in the following right before the restic forget call?
/tmp/t.sh "${extra_args[@]}"

And execute the following:
echo 'echo "args"; for arg in "$@"; do echo "> $arg"; done; echo "args/"' > /tmp/t.sh
chmod u+x /tmp/t.sh

Then check the diffs with an empty extra_args and one with some dummy arg?

Sorry for the late reply.
I've added /tmp/t.sh right before restic forget and i got the same result.
Result Before adding /tmp/t.sh "${extra_args[@]}"

/tmp/t.sh "${extra_args[@]}" added

Result After Adding /tmp/t.sh "${extra_args[@]}"

Results Without  "${extra_args[@]}" variable in forget

Thanks for your reply! Yeah i just meant to verify the issue - the extra args array is expanded to to " " when empty instead of to nothing. This seems to cause the restic commands to fail in case of positional arguments...
I'll have to think and try a bit more around how to fix.

I moved the location of the ${extra_args} to the end of the forget command, but that did not solve the issue.
Thanks for your script btw!

Okay, so from my tests it seems the only way is to remove the quotes... as with the read command we already took care of input validation etc. (please confirm or explain @erikw if possible) - we maybe could leave them out here?

I took the decision to revert #115 with 2873f6a31592ba8e40666cc53bace2d27cf2408d because I don't have time to look at a fix for this right now, and the change as not included in a new release yet.
I'm open to add the functionality of #115 again, if it works out of the box without this bug :)


Add package sanity checks

Script compiles (can use fsc for this or even a compiler service)
metadata is valid

format is correct
mandatory fields are present
package version is unique
package name is unique

package file name is correct
package folder location name is correct
output files are named correctly

most if this is implemented
reminder to add new case: all script dependencies must be pinned (can be checked via regex)


Drift in energy caused by energy cache

I observed a drift in energy for long simulations of LJ particles in the NVT ensemble.
When a move is accepted, I compared the energy delta (energy_new - energy_old) from cache via
du_cache = cache.move_particles_cost(...) versus the difference computed via system.total_energy(). Looking at the difference, I found that often the difference is negligible (1e-16) but there are cases when the difference is about 1e-7 to 1e-5.
I think the problem is either move_particles_cost or the update function of the cache. As far as I can tell, the initialization of the cache works correctly (tail correction is missing at the moment).
You can find the results from a sample simulation here.

Fixed by #72


WIP: Feat/jsx scope

Closes #
{{ Short description }}
Changelog
New

{{ New thing }}

Changed

{{ Changed thing }}

Removed

{{ Removed thing }}

Testing / reviewing
{{ Add descriptions, steps or a checklist for how reviewers can verify this PR works or not }}

I have read the DCO document and I hereby sign the DCO.

recheck


python310Packages.pyg-lib: init at 0.2.0; parallel-hashmap: init at 1.3.11

Description of changes
Low-Level Graph Neural Network Operators for PyG
https://github.com/pyg-team/pyg-lib
A family of header-only, very fast and memory-friendly hashmap and btree containers
https://github.com/greg7mdp/parallel-hashmap

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg build

I'm having a look now to rebase it on latest nixos-unstable and update to newer upstream versions.

@natsukium pyg-lib 0.2.0 does not build on current nixos-unstable, because its torch is too new.
You would have to update to 0.4.0 or so, but that doesn't trivially build yet due to vendored dependencies (e.g. METIS).
Could you have a look at rebasing that?
I have extracted your parallel-hashmap commit into PR #307346,


Can't run /play

Error
TypeError [CommandInteractionOptionNoSubcommand]: No subcommand specified for interaction.
at CommandInteractionOptionResolver.getSubcommand (/root/music/node_modules/discord.js/src/structures/CommandInteractionOptionResolver.js:113:13)
at Object.run (/root/music/commands/play.js:42:37)
at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

Now it's not giving me anything when I try the command.

I think this issuse is solved @umutxyp close the close.

Solved you said? I went thru every single issue and saw none. How is it solved?


@zeit/webpack-asset-relocator-loader does not work

Preflight Checklist

[ ] I have read the contribution documentation for this project.
[ ] I agree to follow the code of conduct that this project follows, as appropriate.
[x] I have searched the issue tracker for a bug that matches the one I want to file, without success.

Issue Details

Electron Forge Version:

6.0.0-beta.46

Electron Version:

v7.1.3

Operating System:

Ubuntu 18.04 x64

Last Known Working Electron Forge version:

?

Expected Behavior
When I install @zeit/webpack-asset-relocator-loader I expect it it do what it's supposed to do. Not sure exactly what, but not to break the build for sure.
Actual Behavior
yarn start writes the following to .webpack/renderer/main_window/index.html (instead of the real content):
Html Webpack Plugin:
<pre>
  Error: /x/src/index.html:82
  /******/  __webpack_require__.ab = __dirname + "/native_modules/";
                                     ^
  ReferenceError: __dirname is not defined

  - index.html:82
    /x/src/index.html:82:36

  - index.html:89
    /x/src/index.html:89:10

  - index.js:247 HtmlWebpackPlugin.evaluateCompilationResult
    [x-app]/[html-webpack-plugin]/index.js:247:28

  - index.js:161
    [x-app]/[html-webpack-plugin]/index.js:161:23

  - task_queues.js:93 processTicksAndRejections
    internal/process/task_queues.js:93:5

</pre>

To Reproduce

Take a look at this repo:
https://github.com/MOZGIII/electron-webpack-asset-relocator-loader-issue
It has just two commits in the master branch, first for the yarn create electron-app ...  --template=webpack, and the second to reproduce the bug.
Additional Information
<!--
Add any other context about the problem here.

For example:
* Console output when you run your `electron-forge` command with the environment variable
  `DEBUG=electron-forge:*`. (Instructions on how to do so
  [here](https://www.npmjs.com/package/debug#usage)). Please include the stack trace if
  one exists.
* Command line arguments you are passing to `electron-forge` (e.g.,
  `electron-forge make --not-a-real-flag`)
* The `config.forge` data in `package.json` or `forge.config.js` in use
* A failing minimal testcase (with a link to the code) or detailed steps to reproduce the problem.
  Using `electron-forge init` is a good starting point, if that is not the source of your problem.

This is expected. @zeit/webpack-asset-relocator-loader does not work in Electron.  I've had an open PR for ages against the upstream --> https://github.com/zeit/webpack-asset-relocator-loader/pull/41
And our webpack template depends on our fork.  https://github.com/electron-userland/electron-forge/blob/master/packages/template/webpack/tmpl/webpack.rules.js#L11
You shouldn't mess with the template and just use the fork we provide 👍

i.e. Why did you replace the asset relocator that worked with the one that didn't 😄
https://github.com/MOZGIII/electron-webpack-asset-relocator-loader-issue/commit/8a1b45f7ff32ff2af2150c985034beb1b0f0c468

I was under the impression the upstream was at @zeit, so I just went there. The source repo URL at   https://www.npmjs.com/package/@marshallofsound/webpack-asset-relocator-loader points to their repo.
The very presence of the fork and the more generic rationale for this webpack rule are not documented adequately. I hoped to see a word or two about the fork at the template itself, and more extensive documentation at the readme rather than "use this to load native modules". Btw, why do we even need to use this webpack-asset-relocator-loader thing?
I'll try with your fork and see if it works, if it doesn't I'll create another issue, thanks for quick response!

Apparently, when I google @marshallofsound/webpack-asset-relocator-loader the link to the fork at github is nowhere to be found. Just a note on why it ended up so problematic.

// Add support for native node modules

Historically most people really don't care why they need a thing (some do) but most just want to be given the thing, told that it "makes the thing work" and then they move on. 😄
The asset relocator is required as you can't bundle a native module into a JS bundle (it's native compiled code not JS).  So it scans your dependencies, finds the native modules, and copies them to the appropriate place in the bundled application so that when you ship your app your native modules actually loads.

Apparently, when I google @marshallofsound/webpack-asset-relocator-loader the link to the fork at github is nowhere to be found. Just a note on why it ended up so problematic.

Yeah I was hopeful that fork wouldn't live long and upstream would take the change 🤷♂ looks like that didn't happen 😆
You can see my fork on GH --> https://github.com/MarshallOfSound/webpack-asset-relocator-loader it just has a single additional commit to support electron apps loading native modules where __dirname is not a thing

Historically most people really don't care why they need a thing (some do) but most just want to be given the thing, told that it "makes the thing work" and then they move on. :smile:

Yes, that's a shame.

The asset relocator is required as you can't bundle a native module into a JS bundle (it's native compiled code not JS). So it scans your dependencies, finds the native modules, and copies them to the appropriate place in the bundled application so that when you ship your app your native modules actually loads.

Nice, so, this is pretty much can be done with a CopyPlugin on a need basis. I like that the tooling that automates this exists. I'm going to be bundling a number of native modules, so I'll need to solve this issue.

Yeah I was hopeful that fork wouldn't live long and upstream would take the change man_shrugging looks like that didn't happen :laughing:

Oh yeah, I know how that happens.
I've switched to the fork, and I'm having troubles with it too:
App threw an error during load
Error: Module build failed (from ./node_modules/@marshallofsound/webpack-asset-relocator-loader/dist/index.js):
SyntaxError: Unexpected token (12:14)
    at Object.module.exports.pp$4.raise (/x/node_modules/@marshallofsound/webpack-asset-relocator-loader/dist/index.js:20834:13)
    at Object.module.exports.pp.unexpected (/x/node_modules/@marshallofsound/webpack-asset-relocator-loader/dist/index.js:18680:8)
    at Object.module.exports.pp.semicolon (/x/node_modules/@marshallofsound/webpack-asset-relocator-loader/dist/index.js:18657:64)
    at Object.module.exports.pp$1.parseVarStatement (/x/node_modules/@marshallofsound/webpack-asset-relocator-loader/dist/index.js:19086:8)
    at Object.module.exports.pp$1.parseStatement (/x/node_modules/@marshallofsound/webpack-asset-relocator-loader/dist/index.js:18838:17)
    at Object.parseStatement (/x/node_modules/@marshallofsound/webpack-asset-relocator-loader/dist/index.js:4539:118)
    at Object.parseStatement (/x/node_modules/@marshallofsound/webpack-asset-relocator-loader/dist/index.js:42314:22)
    at Object.module.exports.pp$1.parseTopLevel (/x/node_modules/@marshallofsound/webpack-asset-relocator-loader/dist/index.js:18739:23)
    at Object.parse (/x/node_modules/@marshallofsound/webpack-asset-relocator-loader/dist/index.js:18542:15)
    at Function.parse (/x/node_modules/@marshallofsound/webpack-asset-relocator-loader/dist/index.js:18565:35)
    at Object.module.exports.module.exports (/x/node_modules/@marshallofsound/webpack-asset-relocator-loader/dist/index.js:14738:19)
    at Object../src/main/index.ts (/x/.webpack/main/index.js:97:7)
    at __webpack_require__ (/x/.webpack/main/index.js:21:30)
    at /x/.webpack/main/index.js:85:18
    at Object.<anonymous> (/x/.webpack/main/index.js:88:10)
    at Module._compile (internal/modules/cjs/loader.js:880:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:892:10)
    at Module.load (internal/modules/cjs/loader.js:735:32)
    at Module._load (internal/modules/cjs/loader.js:648:12)
    at Module._load (electron/js2c/asar.js:717:26)
    at Function.Module._load (electron/js2c/asar.js:717:26)

Should I create an issue here or at fork repo, is there something stupid that I'm missing?

Does it supposed to work with jsx/tsx?

Nice, so, this is pretty much can be done with a CopyPlugin on a need basis

No it can't, it's actually quite more complicated than just copying things around.

Does it supposed to work with jsx/tsx?

It shouldn't be running on jsx files?  The config as in the template is all you need.  It should run on .js files and .node files

Ok, I'm not sure what it does, but if I'm using TypeScript and React (JSX) - are there any special instructions to support those?
I assume what it'll try to do is to not just copy the native modules files, but also rewrite the inclusions of those my the generated bundles - both for my code and for dependencies. Thus, it should operate on the internal webpack's representation of the source, which indeed would be just .js files (not .mjs even), and .node. I just need to verify that the files that babel-loader outputs are also processed properly.
Now, if what I wrote above is correct, it should be able to remove the .mjs, .jsx, .ts, .tsx from the test directive: test: /\.(js|node)$/. The build then completes, however I'm getting runtime errors at the renderer: Uncaught ReferenceError: require is not defined. Is react-hot-reloader supposed to work with this setup? It's invoked inside babel, not webpack, but it might still be conflicting somehow.
Thanks for helping me so far! All this is rather complicated and I'm new to electron and the way things are done with it.

Uncaught ReferenceError: require is not defined
    at Object.<anonymous> (root.js:4)
    at Object../node_modules/react-hot-loader/root.js (root.js:4)
    at __webpack_require__ (bootstrap:726)
    at fn (bootstrap:100)
    at Module.<anonymous> (index.js:38925)
    at Module../src/render/mainWindow/App.tsx (index.js:38967)
    at __webpack_require__ (bootstrap:726)
    at fn (bootstrap:100)
    at Module.<anonymous> (index.js:38986)
    at Module../src/render/mainWindow/index.tsx (index.js:39026)

Managed to solve it. Had to use the "Old API" from the react-hot-loader.

Thanks a lot for you help and for your work @MarshallOfSound.


Validate database names

Description
This PR is a part of #807.

removed TestFindAndModifyEmptyCollectionName test as the same test already done in TestCollectionName.
database test names generation changed from sign - to sign _ to conform the rules.

Error codes

Test Case
MongoDB
FerretDB
Comment

too long name
Invalid namespace specified, quoted
Invalid namespace, not quoted
specified word in MongoDB, quotation differs

$^%*&
Invalid namespace, not quoted
Invalid namespace, not quoted
equal

Checklist

[x] I added tests for new functionality or bugfixes.
[x] I ran task all, and it passed.
[x] I added/updated comments for both exported and unexported top-level declarations (functions, types, etc).
[x] I checked comments rendering with task godocs.
[x] (for maintainers only) I set Reviewers, Assignee, Labels, Project and project's Sprint fields.
[x] I marked all done items in this checklist.

P.S. @seeforschauer could you also check MsgUpdate? I think it calls collection creation somewhere under the hood as well.

that's fine, I committed the suggested change and all 3 approvals were dismissed. can we do anything with It?


Remove signup by promo code

@aaronschachter is it safe to revert the entire pr?

I think so, but I don't know for sure -- I remember work some was done in Northstar to support querying by signup source, so it may use this code (and should also be removed) cc @jonuy. The iOS app def isn't hitting any of those endpoints.


⚠ ClamAV has degraded performance

In c952365, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 200 ms

Resolved: ClamAV performance has improved in c71be1e after 5 minutes.


Added sphinx documentation

Checklist

[x] My branch is up-to-date with upstream/develop branch.
[x] Everything works and tested for Python 3.5.2 and above.

Description

Added a sphinx documentation for the hydra-python-agent repo as I noticed that it didn't have one. Also the documentation can then be hosted on readthedocs so that it can be embedded into the new documentation. The sphinx documentation was created specially for the automodule feature
Change logs
Added
A docs folder which contains the sphinx documentation.

I am running into some errors while using the agent with the new Movie API doc. So the index page is incomplete because it has certain examples missing which I will add as soon as I fix the erros.

Can you let me know what are errors that you are facing while using the agent so that we can fix them?

@priyanshunayan Sure! I will add the steps. My doubt was that when I am trying to run the put function with the new Apidoc, I am getting an error:

Am I missing any steps or am I making any mistake?

@priyanshunayan I managed to fix the error (@farazkhanfk7 helped out) and I have added examples for different types of request with the Movie api doc. Let me know if anything else needs to be changed. I have also added the steps to build the docs locally in a README file.


Listing of Tier Quotas

Readiness checklist

[x] I added/updated unit tests.
[x] I added/updated integration tests.
[x] I ensured that the PR title is good enough for the changelog.
[x] I labeled the PR.

Screenshots

Mobile

Regarding the screenshots: please expand the section for assigning quotas by default.
The feedback for the implementation will come soon, I hope


Feature: new SimplifiedScalingRelation (with configurable c-values)

We want a scaling relation where we can set the cvalue according to FaultRegime. This is a more  flexible version of the prototype  `Stirling_2021_SimplifiedNZ_MagAreaRel' class.  The concept of a fixed cValue for UPPER, LOWER or MEAN is dropped, instead we just pass in c_values as desired.

[ ] for Subduction Interface rupture sets we will set a single c_value (and rake is not considered)
[ ] for Crustal rupture sets we will set both dip_slip_c_value, strike_slip_c_value .
[ ] dip_slip_c_value is applied to faults matching the definition of either REVERSE_FAULTING or NORMAL_FAULTING
[ ] strike_slip_c_value is applied to faults matching the definition of STRIKE_SLIP
[ ] whent this scalig relation is used to calculate magnitude, the user must pass in averageRake for the rupture (depends on https://github.com/opensha/opensha/issues/61)

@mcg-gns @earjcr1 @thingbaijam FYI


Fix TypedefRange test

In TypedefRange test there were range nodes duplicated.

@alaindargelas, could you provide an instruction how to automatically update the log files in tests?

https://github.com/chipsalliance/Surelog/blob/master/src/README.md
cd build
../tests/regression.tcl update

I tried it and all logs became empty.
Maybe there is a problem with paths. I will check.

The problem was I didn't have time tool installed. Now it works.

Please push the new log files

Ok. I see that I broke the ArianeElab test.

I think that the problem is more general. Packed arrays of enums are not parsed properly also when they are the members of structs. I created the issue: https://github.com/chipsalliance/Surelog/issues/1487

I'm dismissing this pull request. It was an incorrect fix. #1490 fixes this particular issue.
Please create an issue before creating a pull request next time, it'll be easier to discuss.


Supporing Typematic rates

Greetings!
In the days of PS/2 keyboards, pressed keys would by default repeat faster after holding them down 0.5 seconds, they would trigger 11 events per seconds until the key up.
More info:
http://www.tekweb.dk/manuals/command/commands/M/MODEST.HTM
Is it possible to emulate this in ROT.js ? (Keeping track of 'down'/'pressed' events for a key without a matching 'up'? This would make crossing larger screens so much more bearable.
If you were interested, but lack time, let me know and I might try and take a stab at it.

Check out https://github.com/kosinaz/Dungeons-of-Neverknown
I think this is what you are looking for.
It is not based on rot.js though.

That, and for other users looking here, just setting mode con rate=31 in the console fixes my problem as well.


[Skydoc] Capture error before accessing it.

In case of parse errors, Skydoc is trying to access an error instance to print it,
but since it's not actually captured in except clause, this causes a runtime error.
The change is capturing the instance to prevent runtime error.

Thanks!


Add NNPA level compatibility check

Add NNPA level compatibility check to validate operations for the specified --mcpu value.

@tungld I updated  the addDynamicallyLegalOpFor functions in https://github.com/onnx/onnx-mlir/blob/main/src/Accelerators/NNPA/Conversion/ONNXToZHigh/RewriteONNXForZHigh.cpp with isCompatibleWithNNPALevel.  Please take a look.

Jenkins Linux s390x Build #12907 [push] Add NNPA level compatibi... started at 11:42

Jenkins Linux s390x Build #12907 [push] Add NNPA level compatibi... passed after 1 hr 21 min

Jenkins Linux ppc64le Build #11900 [push] Add NNPA level compatibi... passed after 1 hr 46 min

@mikeessen Can you confirm: we now need the -mcpu=z16 in order to have -maccel=NNPA take effect, or does the -maccel=NNPA grandfather the -mcpu=z16 option.

we now need the -mcpu=z16 in order to have -maccel=NNPA take effect,

This is my expectation. Somewhere llvm has to be using something as a default mcpu when one isn't specified. Something makes me think that's z13 but I might be off. Whatever that default is, it's not z16. So an unspecified mcpu means "use z13 (or whatever the llvm default is) instructions". NNPA instructions won't be available for anything but the latest processor.
So before this change, specifying only -maccel=NNPA, we would create a model that targeted (by implied default) for z13 which couldn't possibly run on z13.
After this change, specifying only -maccel=NNPA, we compile a model that will run on z13 using all available NNPA instructions for z13 (which is zero).

@mikeessen would you mind checking the doc that all our examples that have NNPA also have the -mcpu option? Tx

@AlexandreEichenberger Thanks, there are a couple examples which needed updating.  I created a PR to address: https://github.com/onnx/onnx-mlir/pull/2551

Thanks for the quick fixes on the doc :-)


[Diagnostics] Emit a warning when an immutable decodable property has an initial value

When a decodable immutable property has an initial value, it will not be decoded and get skipped. This is a common source of confusion among users (example here and here), so emit a specialised warning for it.
struct Foo: Decodable {
  let someProperty: Int = 0 // warning because it won't be decoded
}

To silence the warning, the user can do one of the following things:

Set the initial value in the initializer (99% of the time this is what they really meant to do - set the value via the initializer by using it as a default argument)
Explicitly define a CodingKeys enum without the key in it to make it explicit that it's not meant to be decoded.
Make the property mutable (change let to var)

This won't trigger in some cases when the type is Codable because removing the key will break encoding which is most likely not what the user would expect.
Also, if the key has been explicitly specified and the type is just Decodable, then this warning will be triggered because explicitly declaring a key in the CodingKeys enum means it's meant to be decoded.
This strategy was mentioned here: https://forums.swift.org/t/revisit-synthesized-init-from-decoder-for-structs-with-default-property-values/12296/2
Resolves SR-11996
Resolves rdar://problem/58455438

Other options:

Make it private(set) var
Explicitly define a CodingKeys enum and define which properties to decode

(1) is probably okay to suggest in addition to just changing it to a var
(2) seems too complicated to me
I would appreciate your thoughts on the approach.

Set the initial value in the initializer (99% of the time this is what they really meant to do - set the value via the initializer by using it as a default argument)

How would that work though? If the user really wants to leave the property as transient, the only other
way to do this without losing the synthesized conformance is to explicitly provide the coding keys. So when this happens, the question really is whether we want to encourage people to define coding keys by emitting the warnings.

I think it’s going to be rare in practice - most complaints I’ve across on S/O, Twitter, etc is when someone just assigned it directly whereas they meant to pass it via the initializer.
Explicitly specifying the properties via CodingKeys is the alternative to this - I felt it was a bit too much for the common case but I’m totally happy to suggest that instead in the warning.

The main problem here is that explicitly implementing init(from:) will throw an error because the property cannot be overwritten, but the synthesised code does not throw an error because it just skips it. This difference in behaviour is what confuses people, it’s very magical/silent and there’s no help from the compiler to catch it. Now, according to my observation, most of the time the initial value was meant to be put in the initialiser, which is why I made the warning suggest that as the first choice and making the property mutable as the second.
But yeah, for those rare cases where you just want to ignore the property, explicitly specifying which properties to decode in a CodingKeys enum seems reasonable to me (my only concern was that suggesting it as the primary option might be overkill for the common case).
What I propose is that we suggest the initialiser approach as the first choice, coding keys as second choice and making the property mutable (or private(set) - but depends on the actual visibility of the type) as the third choice.
Your example where you’ve explicitly specified the property in the CodingKeys enum but made it a let with initial value is a good example which should also be diagnosed as a warning.

Okay, I have made some tweaks and added more test cases. cc @xedin @hborla do you also mind taking a look? thank you!

Ping.

@swift-ci please smoke test

@swift-ci please smoke test

I know that it has been a while since this has been merged but, have there been any considerations to have a way to disable this warning?

Now that SwiftUI/Combine is in full swing, there are going to be more people using the let syntax for their Identifiable id conformance. Which I believe to now be the common case.
Having to create the CodingKeys enum to silence the warning is a bit silly.
If this change is here to stay, then perhaps a new property wrapper could help with silencing the warning.
I believe it should be removed altogether though as let should be more than enough of an indication of the developers intentions. Alternatively, fix Decodable so that it won't break if such a property with a default value set, isn't present within the incoming data.

I agree with @BeauNouvelle.
This is becoming painful in SwiftUI and in some cases contributes to the opposite of reducing programmer error.
Take the following example:
struct Model: Codable, Identifiable {
    let id = UUID() // warning presented
    let name: String
}

Given that Xcode provides the Make the property mutable instead fix-it, we'll have developers ending up with this:
struct Model: Codable, Identifiable {
    var id = UUID() // warning silenced
    let name: String
}

It is poor practise to have a mutating identifier especially when SwiftUI relies heavily upon it.


cookie error "io.netty.handler.codec.http.cookie.Cookie.name()" because "c" is null

The issue is related to https://github.com/karatelabs/karate/pull/1782/files#diff-dba062e24f62861c07c4ecb3e71913f704b8a7cf4fb99f3b484a8f1864c42e9e
An earlier fix related to cookie error "io.netty.handler.codec.http.cookie.Cookie.name()" because "c" is null
The error is again shown in Karate version 1.4.1.
I am using Java version 11 and the server i am accessing has no cookies. The cookie name is 'empty' with a value of 'Secure'. The above error related to null cookie name keeps showing.

This error was reported in earlier versions of 1.2, the fix was with Cookie Decoder - LAX but that didn't work in my case. So I downloaded the Karate-Core repo and changed to STRICT but that also didn't work. Not sure what the root problem that is causing this error.

this is most likely because your server sent a cookie without a name or something. normally we insist on a way to replicate: https://github.com/karatelabs/karate/wiki/How-to-Submit-an-Issue - the best way forward is if you debug and submit a PR to add an extra null check in the code. else we will close this after some time

You are right Peter, the server is sending a cookie with 'no name' but with a value of 'secure'. Can you share some info on how to debug the issue. Do i need to do in the Java Code or though the feature file?

@rkanil use a java "runner" entry point to run a feature file and run it from an IDE in debug mode, that's all

Ok Peter, I will try it and get back with additional debug logs. Thanks


Add SendGrid to the civil legal aid diagram

What does this pull request do?

Adds SendGrid to the civil legal aid diagram so that we are aware that we use a 3rd party provider for e-mails.
Bonus Adds the public URL to the civil legal aid backend system.

🙋♂ For review, I would recommend using the "Swipe" image diff: https://github.com/ministryofjustice/laa-architecture-documentation/pull/10/files?short_path=3021a9d#diff-3021a9d2ee611803bbff6653fec5aad5

:tophat: 🙇


Fix merge annotation function

if the current obj as annotation and the updated doesn't we still want to add the ones from the current object

Pull Request Test Coverage Report for Build<PHONE_NUMBER>4
Details

2 of 2 (100.0%)  changed or added relevant lines in 1 file are covered.
3 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.02%) to 45.031%

Files with Coverage Reduction
New Missed Lines
%

controllers/drain_controller.go
1
68.06%

controllers/generic_network_controller.go
2
76.25%

Totals

Change from base Build<PHONE_NUMBER>9:
-0.02%

Covered Lines:
6624

Relevant Lines:
14710

💛  - Coveralls

Right or from operators.
Where I was able to find this issue is in openshift we have an operator to generate the internal pull secret for every service account
apiVersion: v1
imagePullSecrets:
- name: network-resources-injector-sa-dockercfg-46j2c
kind: ServiceAccount
metadata:
  annotations:
    openshift.io/internal-registry-pull-secret-ref: network-resources-injector-sa-dockercfg-46j2c
creationTimestamp: "2024-09-16T12:15:10Z"
  name: network-resources-injector-sa
  namespace: openshift-sriov-network-operator
  ownerReferences:
  - apiVersion: sriovnetwork.openshift.io/v1
    blockOwnerDeletion: true
    controller: true
    kind: SriovOperatorConfig
    name: default
    uid: 745df61d-68d7-4e97-a399-389bae71b7ba
  resourceVersion: "28652"
  uid: 6fe1b49e-943f-4c95-92aa-5cf0ab322151
secrets:
- name: network-resources-injector-sa-dockercfg-46j2c

without this change everytime we did a reconcile we remove this on and the openshift operator was creating a new imagepullSecret
after a few days this was running the number of secrets was huge


Set correct file type to intent after download file from uri & solve issue#1115

[Summary] fix video&file cannot share to line
[Type] fix
[Scope] ios/android
[Changes]
ios: remove filename wrapping quotes
android: set correct file type to intent

I'm going to trust this is fine 👍 Thx!


alert word: Convert inline form to modal.

I started a discussion here to work out the details of the labels.

Other than that, looks good!

@alya Changed the label to "Alert word". Updated the PR description.

Cool, thanks, the updated screenshot looks good to me!
@sahil839 could you please review this one?

LGTM. I am not sure whether we need to add node tests (I guess we do not have them for other modals), will wait for feedback from Tim on this.

I don't think node tests are particularly useful for modals; they're pretty easy to test fully manually, and most of what you'll be spending time doing is figuring out how to mock everything.

Merged, thanks @ganpa3! We may need to tweak the labels pending the discussion in
https://chat.zulip.org/#narrow/stream/101-design/topic/add.20X.20in.20settings/near/1410376, but we'll probably want to do an audit sweep if we change our plan there anyway, so I don't think we should block this one it.


Added Issue and Pull Request Templates

Resolves #53
Proposed changes
I have added issue templates for bug reporting and feature requests. I have also added pull request template.
Types of changes
What types of changes does your code introduce to DjangoTypesense?
Put an x in the boxes that apply

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] Documentation Update (if none of the other choices apply)

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[x] I have read the CONTRIBUTING doc
[x] Lint and unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)
[ ] Any dependent changes have been merged and published in downstream modules

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (280326b) 66.21% compared to head (1530e56) 66.21%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #55   +/-   ##
=======================================
  Coverage   66.21%   66.21%
=======================================
  Files          10       10
  Lines         518      518
=======================================
  Hits          343      343
  Misses        175      175

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Hey @EricOuma please review this. Thanks


Node & NPM

Figure out needed polyfills? (fetch/xr, rAF, Promises, History)
Ensure everything works that's necessary under node, isomorphism.
Determine & minimize devDependencies
Qunit tests integration
Closure compiler or UglifyJS minification
Gulp? Browserify?
Publish beta

isomorphic markup generation already works on node with 0 dependencies. probably time to make a package.json and publish.

@yosbelms
I've been having problems because i don't want a lot of boilerplate for each module since i want the lib to be build-able without NPM, Browserify or Bower and still be small for concat and min (as in the README). I also want all modules to simply by included in order as script tags in the browser and work without any build process for dev. Right now I do pollute the global namespace in node with domvm and all the modules live under that...not too happy about it :(
Woul dbe nice to have something like the following but I have no idea how to dep-inject the util module so it's available to the view module uder a commonly accessible namespace. It may be possible with a ton of module boilerplate in each file, but again that would require a bunch of dependencies to build out a non-bloated concat & min file:
var domvm = {
  util: require("./util"),
  view: require("./view"),
  html: require("./html"),
  watch: require("./watch"),
  route: require("./route"),
};

@leeoniya Regarding all requirements you mentioned before, the global pollution is the solution at first glance, at least. However I'm going deeper to see what I can do

thanks!
i skimmed through this article [1] but didnt find anything that could fully address the situation.
i would not be opposed to using some native commandline utils (head/tail/sed) to strip out any umd boilerplate/wrapper from each file prior to closure concat & compile. i just dont want a node/npm/gulp/grunt/browserify/bower to build a util meant primarily for the browser.
if npm exists and browserify is avail, then great and there can be a slightly different build setup in that case.
[1] http://bites.goodeggs.com/posts/export-this/

May be using a different build for node, or concatenating every file and removing the pollution by adding a boilerplate in the end of the bundle, it could be:
// node_suffix.js
if (typeof module !== 'undefined' && typeof module.exports !== 'undefined') {
    module.exports = global.domvm;
    global.domvm   = void 0;
}

After that, domvm will be undefined in the global scope unlike you've explicitly required with var domvm = require('domvm'):
I use shelljs to strip/add boilerplate/wrappers, build docs, and task automation most of the time. I think using that tool + uglify is enough, this is an example of shelljs heavy usage.

shelljs looks like a nice thin build dependency under node. ~200k, ~60 files.
if you wanna whip up a script that adds the needed wrapper boilerplate and runs everything through closure, we can start with that.

Shelljs scripts are about 5k all the others are doc/test files. Anyway, the dependences are just declared in package.json these are part of the repo, then you can download it by running npm install from ./domvm directory

I'm currently trying to run tests in several borwsers but last year borwsers doesn't support arrow functions, same with nodejs.
:(

yeah, the tests do use arrow funcs but they dont rely on them. feel free to change back to plain funcs. think i just liked the breavity and writing so many similar tests can get sore on the eyeballs. heh.

@leeoniya  It it very important to run tests in browsers with different ages. Are you planning to support just 2016 browsers? If yes, it is a weakness. :-1:

ie9+ (with polyfills):
Promise
History (router)
Fetch (mutaion observer)
rAF (redraw coalescing)
qSA (event deleg)
WeakMap (possibly)
i do not actively test in all browsers yet but i do avoid using features that cannot be polyfilled in ie9+. the tests only cover DOM/vtree correctness right now and are only the most critical 30% of the features. there's a lot more tests to write. Once that is done then we can make sure they all pass in all browsers.
then there's writing docs and demo apps and benchmark tests and packaging not to mention actually developing the lib itself. i'm the only dev so i'm focusing on a couple things at a time. help is always welcome :)

@yosbelms

BTW, I'm really interested in this project, so I have taken the GitHub organization (https://github.com/domvm), npm package (https://www.npmjs.com/package/domvm) and the Bower package, all three ready to transfer the ownership to you, whenever you want.

I haven't seen you reply to any issues for a while and noticed you removed domvm from https://github.com/yosbelms/radar repo. If you're no longer interested in the project or don't have time to participate, let's go ahead and do these transfers now if you don't mind.
Thanks!

Actually my time is short these days. However I'm still watching.

No prob, I understand. Thanks.
How does the npm ownership transfer work?

You need a npm user

https://www.npmjs.com/~leeoniya

done, check https://www.npmjs.com/~leeoniya

thank you.
Feel free to jump in and out if you have time or interest. Your input so far has been really helpful.


Fixed a bug in new minMax()

A thread that doesn't visit a valid value would run an invalid join() op
Signed-off-by: Nick Avramoussis<EMAIL_ADDRESS>

Changes looks good, but would be good to get a unit test for this case?
Tagging @ghurstunither.

Thanks for fixing this. We can certainly add a unit test for this.

Changes looks good, but would be good to get a unit test for this case?

As with testing any parallel code there's no guarantee it'll be hit - but I can just update the current test to add an empty leaf to the tree.


[Feature Request] [Android] extend openLink to better support navigation

I have checked out the latest feature in cli 1.24.0 in openLink supporting deeplinks. Thank you greatly appreciated! This can save a lot of time when running tests to not wait for "click" input.
It would be great if we better support also internal navigation patterns on android/iOS and not only external. On Android activities can be launched if they have the exported flag set.
Currently it is not supported to navigate directly to an activity/fragment with openLink. Possibly there is a workaround today to achieve this via scripts, but I think it is a great addition. Maybe even a different api like navigateTo since it is more clear that it applies more to internal navigation as opposed to openLink. Orthogonal concepts to navigation exist also on iOS.
On the command line this should be achievable for Android like this for activities:
am start -n yourpackagename/.activityname
For fragments and jetpack navigation concepts I do not know the script command yet.

This feature will be really useful. @axelniklasson Is there any workaround to currently fire adb commands via maestro?

@kdani41 Not at the moment unfortunately as Maestro is a blackbox testing framework emulating user interactions, which is why we for example don't support firing raw idb commands. It would also be helpful to know what you're looking to solve in terms of testing with this use case, especially since users won't be able to do this? Thanks!

I'm trying emulate fingerprint login via adb command.

@kdani41 thanks for the context -- this is being tracked in https://github.com/mobile-dev-inc/maestro/issues/282 so let's move the discussion there, thanks!


Wrong license discovered

pytest-django: found BSD-4 and it should be 3
humanize found the wrong license
adlfs found BSD-1-Clause and it should be BSD-3-Clause

cc: @ocefpaf

There is also the case of "aggressive" finding a license file. We should probably avoid looking into hidden directories. This is the case for sat-stac, a bad tarball with the .egg.
license_file: .eggs/pytest_runner-5.2-py3.8.egg/EGG-INFO/LICENSE

There is also the case of "aggressive" finding a license file. We should probably avoid looking into hidden directories. This is the case for sat-stac, a bad tarball with the .egg.
license_file: .eggs/pytest_runner-5.2-py3.8.egg/EGG-INFO/LICENSE

I thought I had removed the search in hidden folders. I will take a look on that later as well, thanks!

Try sat-stac, if you don't get the bad license I may have an outdated version of grayskull.
PS: I'm working with upstream to fix it so you'll have to lock on the current version 0.4.0.

Here is a potentially really tricky case where a BSD 2-clause was interpreted as a 3-clause. Actual license file

Here is a potentially really tricky case where a BSD 2-clause was interpreted as a 3-clause. Actual license file

indeed, the heuristic can be improved to discover the right licence. Currently, Grayskull is using a fuzzy matching system where it tries to compare the licence found in the project with the most common licences out there.

all the packages mentioned are getting the right licence now
closing this for now, if you find another one, please open a new issue or reopen this please


Self-Signed SSL certs not working

Could you provide an option to support self signed SSL certificates? I'm now using openssl 1.1.1 to address the "x509: certificate relies on legacy Common Name field", but now get "x509: certificate signed by unknown authority".

Found this...
https://github.com/influxdata/influxdb-client-go
client := influxdb2.NewClientWithOptions("http://localhost:8086", "my-token",
influxdb2.DefaultOptions().
SetUseGZip(true).
SetTLSConfig(&tls.Config{
InsecureSkipVerify: true,
}))

I hacked the main.go to add...
import
"crypto/tls"
line 144...
options := influxdb2.DefaultOptions()
options.SetTLSConfig(&tls.Config{InsecureSkipVerify: true})
influxClient := influxdb2.NewClientWithOptions(config.InfluxServer, authString, options)

Hm. It's true Golang will not trust self-signed certs by default. Passing InsecureSkipVerify is not recommended, as it downgrades the security for your connection such that it's effectively the same as using plain old HTTP.
I suppose some number of people who want to send their Ecobee data to Influx may be using self-signed certs. This could be achieved by using a tls.Config which extends the default root store to include the self-signed cert in question, like described in this post. You could pass in the path to the certificate file as an optional arg, which would activate this code path.
I don't have the time to add this, but I would accept such a PR.


EX display glitch fix

Fixes the current skill level display not updating for EX skills

@ceruulean Can you tell me where the glitch is?
Like, reproduce steps or which skill of which character?

Ah, I just noticed there was a line commented out

// panel.children("p[insight="skilllexevel"]:first").text(this._currentskilllevel + "" + this._skillmaxlevel);

I didn't know if "skilllexevel" was a typo but it looks like uncommenting it would of fixed the bug also


Recent flag is not cleared as supposed by IMAP server

Fixed by https://github.com/regnull/ubikom/commit/80c428c5902ea97cf488da7ef817e75ac51c21fa


travis tests fail due to missing mkl library

travis doesn't support mkl out-of-the-box which is why the unit tests currently fail. See issue here. A work around seems to install the intel mkl library through apt.

fixed by updating torch to 1.2 in 0f484518d608a1e6b030fbe4c5edacf514e66203


UPS Rates Not being returned

I have copied the code exactly from test page and I am not getting anything back. Is my UPS license number my account number, or access key? Mind you I have tried both. I am using Origin zip of 79403 and destination of 34769. Any help is appreciated it. here Is what I have.
NameValueCollection appSettings = ConfigurationManager.AppSettings;
string upsLicenseNumber = appSettings[""]; //removed for security reasons
string upsUserId = appSettings[""]; //removed for security reasons
string upsPassword = appSettings[""]; //removed for security reasons
var packages = new List();
//packages.Add(new Package(12, 12, 12, 35, 150));
packages.Add(new Package(6, 6, 6, 2, 149));
var origin = new DotNetShipping.Address("", "", "79403", "US");
var destination = new DotNetShipping.Address("", "", "34769", "US"); // US Address
var rateManager = new RateManager();
rateManager.AddProvider(new UPSProvider(upsLicenseNumber, upsUserId, upsPassword));
Shipment shipment = rateManager.GetRates(origin, destination, packages);
foreach (Rate rate in shipment.Rates)
{
Console.WriteLine(rate.ToString());
}

Nevermind, figured it out, however, I don't see SurePost as an option. Is this not included in here?

Is your code compiling? Should be var packages = new List<Package>();

SmartPost is it's own provider ... and a FedEx thing.
https://github.com/kylewest/DotNetShipping/pull/51

No I said SurePost. That is  UPS not fedex feature.

Never heard of it. I'm sure it can be implemented. Send me a pull request!


AOT dll before building

Hi,
Does is it possible to use Odin's AOT generation feature to generate an AOT dll before building without odin inspector?
I'm trying to use odin-serializer in an UWP application.
Thanks for reply

Yes, the front page readme contains details on this, here.


Inconsistent A11Y focus for non-dismissible bottom sheet

When showModalBottomSheet is called with isDismissible false, the default A11Y focus on bottom sheet is not always on the first element.
Steps to Reproduce
With talkback
Talkback version: 12.2
Device: pixel6
OS: Android 12
The following code sample adds two ways to open the bottom sheet - from the floating action button, and from the app bar.
With the following code sample, open the bottom sheet by pressing the floating action button.
When isDismissible is false, the default A11Y focus is inconsistent, depending on where the bottom sheet was triggered from.

Triggered from the app bar button - the default A11Y will focus on the button (bad - expected focus to be on the title)
Triggered from the floating action button - the default A11Y will focus on the title (good)

When isDismissible is true, the default A11Y focus will be on the title (good).

Code sample
import 'package:flutter/material.dart';

void main() => runApp(MyApp());

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      home: MyHomePage(title: 'Flutter Demo Home Page'),
    );
  }
}

class MyHomePage extends StatefulWidget {
  MyHomePage({Key? key, required this.title}) : super(key: key);

  final String title;

  @override
  _MyHomePageState createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  int _counter = 0;

  void _showBottomSheet() {
    showModalBottomSheet<SafeArea>(
      context: context,
      // !!! This is very important to reproduce the a11y focus issue. !!!
      // Without it, the title will always get focused by default.
      // With it, trigger from app bar with focus on button while trigger from
      // floating action button will focus on title.
      isDismissible: false,
      builder: (_) => Semantics(
        scopesRoute: true,
        explicitChildNodes: true,
        child: Column(
          mainAxisSize: MainAxisSize.min,
          crossAxisAlignment: CrossAxisAlignment.start,
          children: [
            const Text('This is title'),
            TextButton(
              onPressed: Navigator.of(context).pop,
              child: const Text('Ok'),
            ),
          ],
        ),
      ),
    );
  }

  void _incrementCounter() {
    _showBottomSheet();
    setState(() {
      _counter++;
    });
  }

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text(widget.title, style: TextStyle(fontFamily: 'ProductSans')),
        actions: [
          TextButton(
            onPressed: _showBottomSheet,
            child: Text('ShowBottomSheet'),
          )
        ],
      ),
      body: Center(
        child: Text(
          'Button tapped $_counter time${_counter == 1 ? '' : 's'}.',
          key: Key('CountText'),
        ),
      ),
      floatingActionButton: FloatingActionButton(
        onPressed: _incrementCounter,
        tooltip: 'Increment',
      ),
    );
  }
}

See b/237621905 for more details.

closing this as duplicated to #97747

https://github.com/flutter/flutter/issues/97747 provided a api to manually set the focus.
But the Inconsistent A11Y focus here should be handled on flutter side, probably need to update navigator to record the focus of the previous page.

tracked in upstream issue: https://github.com/flutter/flutter/issues/97747


Android: error loading image (webp)

There is no such problem with Lagrange on Linux.

Just got 1.13b5 update, webp works now, thanks!


Revert "Define the tests as grpc_cc_test to automatically test against all po…"

Reverts grpc/grpc#14326 because it breaks import.

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

[trickle] No significant performance differences

Corrupt JSON data (indicates timeout or crash):
    bm_fullstack_streaming_pump.BM_PumpStreamServerToClient_SockPair__0.opt.old: 1
    bm_fullstack_streaming_pump.BM_PumpStreamServerToClient_MinSockPair__0.opt.new: 1

[microbenchmarks] No significant performance differences


Where is my crown?

I kill all those losers of penguins, Where is my reward?! ^^

There should be a barely visible notification at the bottom of the screen ;)

Styling PR welcome
On Sun, 10 Mar 2019, 18:20 Juraj Kirchheim<EMAIL_ADDRESS>wrote:

There should be a barely visible notification at the bottom of the screen
;)
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/spiceboys/wannabe/issues/1#issuecomment-471325462,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACtaaW_it6HX4iiZDuhCsmvAnkCAscRxks5vVT7cgaJpZM4bnYgZ
.


Do I Need Some Sort Of Program To Run And Use These Files????

I am extremely confused right now.
I had an older version of bongocat installed and it was super simple.
All it has was 2 folder, config, and an executable.
But now I am trying to create a custom bongocat and these files seem so different.
I do not see an executable, no config...I am so confused.
I know I probably just missed something super obvious, but I am at an impass.

I'm sure you downloaded the whole code instead. The actual releases are found here.

I'm sure you downloaded the whole code instead. The actual releases are found here.


Fixing Mongo tests and reverting to prior instance invite! behavior

Don't know if you'd want to pull all of this back in, but:

I needed to revert back to the 0.5.0 functionality for the instance method invite!. There is contextual information available in having an instance that simply can't be replicated by trying to run everything through the class method interface and querying on the email. Our use case is further complicated by the fact that we have a one-to-one relationship between Person and User, with not every Person being a User -- so if you User.invite!(:existing_email, :different_person) via the class method, the new logic causes an existing user to be reassigned to a new (incorrect) person. The prior logic just worked, so we're going to roll with that.

I fixed the mongodb tests so that they work. All you should need to do is a brew install of mongodb, start it in a terminal window, and rake runs cleanly for both activerecord and mongo. Just needed a few tweaks to the configuration files, and the model attributes to be defined for mongo in the testing rails app.

Thanks...

Gemfile.lock should not be added to gems
http://yehudakatz.com/2010/12/16/clarifying-the-roles-of-the-gemspec-and-gemfile/
Instance model was changed to fix a bug, your change introduce the bug again. Also it's not needed for your problem, you can use user.skip_password = true before user.invite! if user.valid? in your controller

Good point on the Gemfile.lock. I'd added that for my own use.
What was the bug in the instance model that was fixed & reintroduced?
On Mon, Feb 20, 2012 at 4:09 AM, Sergio Cambra <
<EMAIL_ADDRESS>
wrote:

Gemfile.lock should not be added to gems
http://yehudakatz.com/2010/12/16/clarifying-the-roles-of-the-gemspec-and-gemfile/
Instance model was changed to fix a bug, your change introduce the bug
again. Also it's not needed for your problem, you can use
user.skip_password = true before user.invite! if user.valid? in
your controller

Reply to this email directly or view it on GitHub:
https://github.com/scambra/devise_invitable/pull/171#issuecomment-4050385

--
William (B.J.) Lawson, MD
919.335.3107 (direct)

It will break validate_on_invite, because it will try to validate password.
Anyway I can't see the point on setting skip_password in instance method. If you are using instance method instead of recommended class method you can set skip_password too.


gcp.workflows.Workflow example not working

File: themes/default/content/registry/packages/gcp/api-docs/workflows/workflow/_index.md
The Workflow Basic example not working, and error message is
 TSError: ⨯ Unable to compile TypeScript:
The example should be changed to
import * as pulumi from "@pulumi/pulumi";
import * as gcp from "@pulumi/gcp";

const testAccount = new gcp.serviceaccount.Account("testAccount", {
    accountId: "my-account",
    displayName: "Test Service Account",
});
const example = new gcp.workflows.Workflow("example", {
    region: "us-central1",
    description: "Magic",
    serviceAccount: testAccount.id,
    sourceContents: `# This is a sample workflow. You can replace it with your source code.
#
# This workflow does the following:
# - reads current time and date information from an external API and stores
#   the response in currentTime variable
# - retrieves a list of Wikipedia articles related to the day of the week
#   from currentTime
# - returns the list of articles as an output of the workflow
#
# Note: In Terraform you need to escape the $$ or it will cause errors.

- getCurrentTime:
    call: http.get
    args:
        url: https://timeapi.io/api/Time/current/zone?timeZone=Europe/Amsterdam
    result: currentTime
- readWikipedia:
    call: http.get
    args:
        url: https://en.wikipedia.org/w/api.php
        query:
            action: opensearch
            search:  \ ${currentTime.body.dayOfWeek}
    result: wikiResult
- returnOutput:
    return: \${wikiResult.body[1]}
`,
});

The \ should be added to  ${currentTime.body.dayOfWeek} and ${wikiResult.body[1]}.

Thank you for the contribution @YuchengHE-CHN ! We'll take a look at this in more depth and get the docs updated.


CSS compiler missing com.google.debugging.sourcemap

I get the following error:
Exception in thread "main" java.lang.NoClassDefFoundError: com/google/debugging/sourcemap/SourceMapFormat
        at com.google.common.css.compiler.passes.DefaultGssSourceMapGenerator.<init>(DefaultGssSourceMapGenerator.java:102)

In order to fix this, I had to put the Closure JavaScript Compiler jar on the classpath.
Your pom.xml file does not appear to declare a dependency on whatever provides that class.

Hi Justine,
I'm afraid that our pom.xml is in sore need of some updating. I take it that you are building from source, not the pre-packaged JAR? The issue may be that libsourcemap.jar is out of date, which would also explain why putting the JS compiler on the path makes the problem go away. (That jar is ripped directly from the JS compiler.)
Cleaning all of this stuff up has been planned for a long time, but I haven't had any time to work on it. If you're interested, please let me know.
Thanks,
Ian
P.S. I'll try to push a new version out next week to take care of the immediate problem.

I'm technically not using the pom.xml file. I'm fetching the jars from Maven and using them in Bazel. The workaround I mentioned is sufficient for my purposes. But this issue should probably be solved for people who use Maven instead of Bazel.

I believe this was addressed by
https://github.com/google/closure-stylesheets/commit/1493a85e0aab24e9a05420f9f43b89104c2b982d#diff-600376dffeb79835ede4a0b285078036R185
I looked into separating that code out of closure-compiler into a separate maven module, but there's a dependency cycle though, IIRC, the cycle is in test code.


Avoid deeply nested LinearCombinations in EvaluationsVar::interpolate_and_evaluate

Description
It is observed in https://github.com/privacy-scaling-explorations/sonobe/issues/80 that stack overflow occurs when calling EvaluationsVar::interpolate_and_evaluate for large evaluation domains (e.g., when $n > 11$).
I think this happens because in EvaluationsVar::lagrange_interpolate_with_constant_offset and EvaluationsVar::lagrange_interpolate_with_non_constant_offset, we are updating the final evaluation result in a for loop, and += in each iteration wraps the current result by a new layer of LinearCombination. This produces a deeply nested LinearCombination. When we get .value() of the evaluation result, internally ConstraintSystem::assigned_value is invoked to recursively flatten the LC. Unfortunately, the number of LC layers of the evaluation result is so large that the recursion depth exceeds the OS limit, resulting in a stack overflow.
This PR fixes the above bug by calling .sum() on the iterator of addends, since this method invokes AllocatedFp::add_many, which produces a flat LC.

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

[x] Targeted PR against correct branch (master)
[x] Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
[x] Wrote unit tests
[ ] Updated relevant documentation in the code (N/A)
[x] Added a relevant changelog entry to the Pending section in CHANGELOG.md
[x] Re-reviewed Files changed in the Github PR explorer

Hi, is there anything missing for this PR to be merged? We are interested into it since we would like to evaluate with n=16.
Also, are there any chances of including this fix into the next arkworks v0.5.0 release?


Click on URI is broken for URIs with ? in

I've been messing around making a better local backend for mopidy. One key thing is to return albums and artists in search results, and return sensible browse URIs for them, so you can click on the album name and go to the album.
Now initially, I used the same URIs as in mopidy-local-sqlite for compatibility,
eg. local:directory?type=artist
However, if you return a URI like this as the URI for an album or artist in the search results, it appears not to work, I had to change them to local:directory/artist/ instead. I suspect there is a quoting issue somewhere here.

@joemarshall  - So is this something that needs to be changed in mopidy or the web clients?

Are there steps I can do to reproduce this?

The spotify URI is "spotify:album:ID", so will happily sit after a ? in a web URL without HTML encoding.
The local-sqlite URI for an artist is like "local:directory?type=artist/ARTISTNAME"
ie. it has ? = and / in it, so for it to sit on a web URL it needs HTML encoding and decoding.
At some point soon, local-sqlite will be fixed so it returns albums / artists from search as well as tracks, and then this will be a problem for it.
Does that make sense?
I suspect you can reproduce it by going to http://<IP_ADDRESS>/musicbox_webclient/#artists? and adding a valid mopidy local sqlite artist URI at the end of it, if you fix the bug, it should list the albums by that artist.

I'm not sure I can follow the history here - will this require encoding a query string so that it can be embedded in another query string?
@joemarshall is this still something that you are interested in seeing changed in the web client?

We haven't had any more feedback on this issue and I am not sure that it can be classified as a 'bug' in MMW.
Please reopen if anybody would like to re-open the discussion.


implementando matrisss en .h

?

It is not in the correct branch

who decides which branch is correct?

the whole group except you

?? just because it does not have the name u want?


Remove explicit PROFILE_TASK for 3.8+

The upstream default has been slimmed down to a reasonable amount in Python 3.8+!
See also:

https://bugs.python.org/issue36044
https://github.com/docker-library/python/issues/160
https://github.com/python/cpython/pull/14702
https://github.com/python/cpython/pull/14910

Travis before (https://travis-ci.org/docker-library/python/builds/566732303):

Travis after (https://travis-ci.org/docker-library/python/builds/566732303):


Installation should fail if runtime libraries are missing

Current guidance from Microsoft with respect to using merge modules in .msi installers for redistributable packages:

If you deploy your code only as an .msi installer, we recommend you don't include the merge modules in the installer. Instead, report a failure to the user when the required Redistributable libraries aren't found. In the failure dialog, include instructions on how to find and install the latest Redistributable package. For more information and links to Redistributable packages, see The latest supported Visual C++ downloads.

Given the above, WiX should updated to show an error dialog if runtime libraries cannot be found. As a stop-gap, this limitation should be documented in README.md.

Documented in commit fd1aab1a24ec9327a1c81170fea2f67e412fc1bc


Perform vsSetOffset-refresh in next $digest ( fixes #57 )

To allow Angular to update repeated elements first. This fixed bug #57

Thanks for that PR. Other people were experiencing a similar bug.

I updated bower and npm to version rc11 with that PR merged.


Calls to insert_distributed_trace_headers produces errors instead of inserting intended DT headers

Description
In the agent log files, we see:
[2020-12-04 10:31:59 +0000 (4325)] DEBUG : API supportability metric not found for :insert_distributed_trace_headers
Describe the problem you're encountering.

And we're not seeing any 'External service' trace for non-web traces in the UI.

small correction to the title of this particular issue:  The code is still performing the work of inserting the distributed trace headers contrary to title's wording.  It's just that the supportability metric isn't also sent. It is logged to the agent log file instead.


Rust writer not encoding correct URL for partitions in delta table

Environment
Delta-rs version: 0.17.4

Bug
We write data to delta table using delta-rs with PyArrow engine with DayHour as partition column. However when we run the optimize.compact() on the table, it creates partitions with spaces and does not properly encode the partition urls as shown in the below image i.e; it creates new partitions url with spaces (.zstd.parquet).

Can you please let me know how we can run the optimize.compact without having partitions with spaces?

@g12-al

Confirmed that this also seems to happen in 0.18.0.
This breaks compatibility for our Trino connector to enable visualization on dashboards. Ideally, Trino wouldn't care about spaces (it has a lot of other issues like not being compatible with timezone-aware timestamps).

@ion-elgreco the issue we see here is with the Pyarrow engine

@on-elgreco Any update on this issue?

@gprashmi sorry I don't have time to look into it unfortunately

@ion-elgreco do you have any other suggestions on how this can be handled to have the correct URL encoding with optimizing the table?

I'll take a look at this

@gprashmi @g12-al fix is on it's way in https://github.com/delta-io/delta-rs/pull/2705, will be released in 0.18.3

I'm late to responding, but thank you so much for addressing this @ion-elgreco !

Thank you very much @ion-elgreco for addressing the issue.


[REVIEW] README Updates for CMake Install and Formatting Cleanup

Changes to README:

Include instructions on how to install the latest CMake
Moved git pull instructions to the top
Labeled the dependencies section for easier readability
Promoted the Configure and Build section to the next highest heading level

Should we merge this one? @mike-wendt @kkraus14

Should we merge this one? @mike-wendt @kkraus14

The comment above was never addressed, which should be done before merging.

This is a dead branch and with the merged cuDF repo these docs will change anyway. Closing PR w/o merge


franz: 5.4.1 -> 5.5.0

Semi-automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/franz/versions.
meta.description for franz is: "A free messaging app that combines chat & messaging services into one application"
meta.homepage for franz is: "https://meetfranz.com"
meta.changelog for franz is: ""
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 5.5.0 with grep in /nix/store/nv54mg4kh9rwxm3djw73ngcks1hip93a-franz-5.5.0

directory tree listing: https://gist.github.com/7935985e82a5ba94095f417b3658a521

du listing: https://gist.github.com/ce78ea76ef1b98e67865f919904d2acf

Rebuild report (if merged into master) (click to expand)

16479 total rebuild path(s)

4658 package rebuild(s)

4657 x86_64-linux rebuild(s)
4350 i686-linux rebuild(s)
3230 x86_64-darwin rebuild(s)
4242 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
Sylk
_1password
abcmidi
acoustidFingerprinter
activemq
adapta-gtk-theme
adoptopenjdk-icedtea-web
aeolus
afl
agda
agdaPackages.agda
agdaPackages.agda-prelude
agdaPackages.cubical
agdaPackages.iowa-stdlib
agdaPackages.standard-library
ahoviewer
akregator
alarm-clock-applet
all-cabal-hashes
almanah
amarok
amarok-kf5
amazon-ecr-credential-helper
anki
ankisyncd
apfelgrid
apitrace
apmplanner2
apostrophe
appimage-run
applgrid
aqemu
aravis
areca
arion
astroid
atlassian-cli
audaciousQt5
audio-recorder
aws-sam-cli
axel
azure-cli
azureus
balsa
bareos
baresip
bashmount
bat-extras.batwatch
bdsync
beets

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/nv54mg4kh9rwxm3djw73ngcks1hip93a-franz-5.5.0 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A franz https://github.com/r-ryantm/nixpkgs/archive/b5c18eece696c565b151784654c086776732a88e.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/nv54mg4kh9rwxm3djw73ngcks1hip93a-franz-5.5.0
ls -la /nix/store/nv54mg4kh9rwxm3djw73ngcks1hip93a-franz-5.5.0/bin

Pre-merge build results
NixPkgs review skipped

Maintainer pings
cc @davidtwco for testing.

addressed by https://github.com/NixOS/nixpkgs/pull/92155


Button down the "Getting started" guide

Draft here:
Complete, edit, and check for accuracy each section:

[ ] Onramp/Getting started (related #508 and #507)
[ ] Building a board
[ ] Make it do something useful
[ ] Use kits
[ ] Reuse/remix boards
[ ] Publish boards

Just as a note - We're going to have to also work out the on boarding at the point where you use your first prompt with an LLM, because there are some hurdles outside of our direct control:

Each hosted LLM requires an account and they are all pretty complex to set up (often requiring a credit card)
Gemini/PaLM is still not available in the UK (and Europe) - https://ai.google.dev/available_regions
I imagine we will get interest from developers who only use Mistral or OpenAI, we should have a clear path that doesn't turn them away (recipes/apis/llms/* should help here)

@PaulKinlan
although they're not as performant, I'm a fan of using your Xenova kit as there are no service dependencies other than loading the model.

The beats of the story:

blank
add gemini.text node
add template
add markdown output (optional)
add random letter maker
add invoking webcam as drawable

The gist containing code progression is here:
https://gist.github.com/dglazkov/cfdd753564b84bbcc83c30b022c6fecb


Postgres: support enum renaming

It still generates the old enum name after renaming:
create type event as enum ('START', 'STOP');
alter type event rename to "new_event";

Yep, looks like this is the case. Reproduced here: https://play.sqlc.dev/p/84f0f7e2e0174e2ee7893fdf71d6930d3c907f8b4a242bdca96aaf5f13c7ce01


macvim, select all (cmd-a) and mouse select broken

This has been broken for a while, but I didn't realise it was introduced by vim-airline.
I have MacVim installed on a MBP 2015, El Capitan via homebrew, version:
VIM - Vi IMproved 7.4 (2013 Aug 10, compiled Dec 15 2015 21:37:42)
MacOS X (unix) version
Included patches: 1-769

Following steps could be used to re-produce the error:
CMD-A, select all issue

Open a file, or start a new file and type some texts
in either normal mode, or edit mode, hit CMD-A (which should select all text)
ISSUE - all text is deleted, and replaced with a "g"

Mouse select issue

Open a file with lots of text (that needs scrolling)
mouse select a couple of line
ISSUE - notice how as you drag, all the text is garbled and replaced with series of lower and upper case "g"s

Found the above issue relate to airline by unloading all of the plugins from Macvim, and then adding them in one at the time. I now have a Macvim install with 20 plugins, above issues none-existent if without airline. Issue appears as soon as airline plugin is installed.
Issues are apparent with no airline setting set.
I didn't realise airline changed any key bindings. But when I did
map <C-a>
vim goes No mapping found
This only affects GUI version of Vim, as the methods of interaction (cmd-A and mouse select won't in command line).

Is the problem exists with airline as your only plugin?
Since airline call functions from other plugins.
You probably should use nmap <D-a> to check with mapping with COMMAND key

Is the problem exists with airline as your only plugin?
Since airline call functions from other plugins.
You probably should use nmap <D-a> to check with mapping with COMMAND key

Problem exists with airline as my only plugin. When I was doing process of elimination. I tested one plugin at a time. Since I posted the original Issue, I've removed airline from MacVim, the problem has never reappear.
Oops, typo on my part, map <D-a> and nmap<D-a> reveals no mappings when testing with Airline

Is this still an issue?

Does <D-A> start select mode by any chance? Could that be fixed with an updated Vim? I believe it is the same as #868 so could you updated both MacVim and airline please and test again?

Latest airline seem to have fixed this issue. I haven't updated my MacVim.  Thanks for whatever the fix was :+1:


Update Programming Guide - part7

Added more Action examples using a new std. template for each example.

@daisy-ycguo please review and merge if able.


Boilerplate file structure

Structured code into separate files for each command;
moved logic for executing commands into these files

You need to sign the commits.  Might require a force push after.


python311Packages.azure-appconfiguration: 1.5.0 -> 1.6.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python311Packages.azure-appconfiguration is: Microsoft App Configuration Data Library for Python
meta.homepage for python311Packages.azure-appconfiguration is: https://github.com/Azure/azure-sdk-for-python/tree/master/sdk/appconfiguration/azure-appconfiguration
meta.changelog for python311Packages.azure-appconfiguration is: https://github.com/Azure/azure-sdk-for-python/blob/azure-appconfiguration_1.6.0/sdk/appconfiguration/azure-appconfiguration/CHANGELOG.md
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.6.0 with grep in /nix/store/8xqx968fkf4gygp6liihyazn64g77vnr-python3.11-azure-appconfiguration-1.6.0
found 1.6.0 in filename of file in /nix/store/8xqx968fkf4gygp6liihyazn64g77vnr-python3.11-azure-appconfiguration-1.6.0

Rebuild report (if merged into master) (click to expand)

3 total rebuild path(s)

3 package rebuild(s)

First fifty rebuilds by attrpath
azure-cli
python311Packages.azure-appconfiguration
python312Packages.azure-appconfiguration

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/8xqx968fkf4gygp6liihyazn64g77vnr-python3.11-azure-appconfiguration-1.6.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python311Packages.azure-appconfiguration https://github.com/r-ryantm/nixpkgs/archive/5774fe4232705d1c766cf9095065bea3453d7e33.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/5774fe4232705d1c766cf9095065bea3453d7e33#python311Packages.azure-appconfiguration

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/8xqx968fkf4gygp6liihyazn64g77vnr-python3.11-azure-appconfiguration-1.6.0
ls -la /nix/store/8xqx968fkf4gygp6liihyazn64g77vnr-python3.11-azure-appconfiguration-1.6.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

6 packages built:

azure-cli
azure-cli.dist
python311Packages.azure-appconfiguration
python311Packages.azure-appconfiguration.dist
python312Packages.azure-appconfiguration
python312Packages.azure-appconfiguration.dist

Maintainer pings
cc @jonringer for testing.

Result of nixpkgs-review pr 303850 run on x86_64-linux 1

6 packages built:

azure-cli
azure-cli.dist
python311Packages.azure-appconfiguration
python311Packages.azure-appconfiguration.dist
python312Packages.azure-appconfiguration
python312Packages.azure-appconfiguration.dist


docs: fix grammer for gateway.md

Type of change

Bug fix
New feature
Improvement (improvement to code, performance, etc)
Test update
Documentation update

Description

Additional details

Related issues

Agree with @satota2 that this change should not be made, so I shall close this PR.
Thanks for the scrutiny though :)


fix sidebar highlighting when links share path but not hash

Fixes an issue where many items in the sidebar are highlighted at the same time. (Shared pathname, different hashes)
Less than ideal because it uses a page refresh to rebuild the sidebar
Perhaps it could instead add current to the active link and also somehow find the old link to remove current from?
Feel free to modify as you see fit.

I am very confused by this... could you share a docs site where this happens? The left navigation which this updates only includes individual pages, not hashes within the page.

Turns out this is caused by a double re-export
index.ts
export * as test from './test'
export * from './test'

test/index.ts
export const test1 = 1
export const test2 = 1

Ah, I see! The re-exports shouldn't be showing up in the left hand page's navigation at all.

Thanks! 😁


How to set the model to just save top_k checkpoints?

It seems that every 2000 steps the checkpoints will be saved, but I just want to save top_3(metric=val_loss). How can I implement it?

I changed some code in the file 'pokemon.yaml' like the picture above,  and succeed.


build: use Temurin jdk

https://github.com/actions/setup-java/blob/main/README.md
AdoptOpenJDK is obsolete.  Use Temurin instead.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

LGTM

@vbarua  can you merge this?


My Teams screen needs style

A little "owner" tag on this list (for teams you own of course) would be a nice addition.  Could be a color thing too?


WICKET-6952 Performance improvements for Strings.isEmpty()

This PR adds some micro-improvements for Strings.isEmpty.
String.trim is one of the hottest methods in my application. Most calls come from Strings.isEmpty, either called directly or via Args.notEmpty. It is called thousands of times during each request, so even minor improvements should make sense.
This PR applies two optimizations:

It adds overloaded methods for Strings.isEmpty and Args.notEmpty that take a String argument. The compiler seems to better inline the method when the exact parameter type is known at compile time. This results in about 5% performance improvement in most of my tests.
Before calling String.trim, the first character of the string is checked for whitespace. If it isn't whitespace, we can avoid calling String.trim. This optimization makes sense for the new method, but especially for the existing method with CharSequence parameter. One CharSequence frequently passed to isEmpty is AppendingStringBuffer. Before calling trim we have to convert it into a string with toString. In the case of AppendingStringBuffer, this always allocates a new string with the entire contents of the buffer.

Benchmark                            Mode  Cnt          Score         Error  Units
StringsBenchmark.bufferFastIsEmpty  thrpt   15    4706409.686 ±   41865.767  ops/s
StringsBenchmark.bufferIsEmpty      thrpt   15    4001127.728 ±   14525.221  ops/s
StringsBenchmark.fastIsEmpty        thrpt   15  139232012.995 ± 1757089.132  ops/s
StringsBenchmark.isEmpty            thrpt   15  130471674.653 ± 1604850.726  ops/s

The new method is about 15% faster for AppendingStringBuffer and about 5-10% faster for String.
Notes:

The only case where these optimization will probably result in minor performance loss is for strings that actually start with whitespace. In that case we check the first character and then call trim. This shouldn't be a problem though because in 99.9% of cases the method is called with a null string, an empty string, or a "normal" string.
string.charAt(0) <= ' ' is taken directly from String.trim, so there should be no hidden change in behavior.

Benchmark:

import org.apache.wicket.util.string.AppendingStringBuffer;
import org.apache.wicket.util.string.Strings;
import org.openjdk.jmh.annotations.Benchmark;
import org.openjdk.jmh.annotations.Scope;
import org.openjdk.jmh.annotations.State;
import org.openjdk.jmh.infra.Blackhole;
import org.openjdk.jmh.runner.Runner;
import org.openjdk.jmh.runner.RunnerException;
import org.openjdk.jmh.runner.options.Options;
import org.openjdk.jmh.runner.options.OptionsBuilder;
import org.openjdk.jmh.runner.options.TimeValue;

import java.util.UUID;

@State(Scope.Thread)
public class StringsBenchmark {

	private final String s = UUID.randomUUID().toString();
	private final CharSequence c = UUID.randomUUID().toString();
	private final AppendingStringBuffer buffer = new AppendingStringBuffer(UUID.randomUUID().toString().repeat(10));

	@Benchmark
	public void bufferIsEmpty(Blackhole blackhole) {
		blackhole.consume(Strings.isEmpty(buffer));
	}

	@Benchmark
	public void bufferFastIsEmpty(Blackhole blackhole) {
		blackhole.consume(isEmpty(buffer));
	}

	@Benchmark
	public void isEmpty(Blackhole blackhole) {
		blackhole.consume(Strings.isEmpty(c));
	}

	@Benchmark
	public void fastIsEmpty(Blackhole blackhole) {
		blackhole.consume(isEmpty(s));
	}

	private static boolean isEmpty(final CharSequence string)
	{
		return string == null || string.length() == 0 ||
				(string.charAt(0) <= ' ' && string.toString().trim().isEmpty());
	}

	private static boolean isEmpty(final String string)
	{
		return string == null || string.isEmpty() ||
				(string.charAt(0) <= ' ' && string.trim().isEmpty());
	}

	public static void main(String[] args) throws RunnerException {
		final Options opt = new OptionsBuilder()
				.include(".*" + StringsBenchmark.class.getSimpleName() + ".*")
				.warmupIterations(3)
				.warmupTime(TimeValue.seconds(3))
				.measurementIterations(3)
				.measurementTime(TimeValue.seconds(3))
				.threads(1)
				.forks(3)
				.build();
		new Runner(opt).run();
	}
}

It would be good to have the benchmark code for future reference - either here as a comment or somewhere in the source tree

And please create a JIRA issue - for the changelog
Thanks!

Right, I'll add the JavaDoc and the ticket tomorrow!

It would be good to have the benchmark code for future reference - either here as a comment or somewhere in the source tree

I suggest we add a separate Maven module wicket-benchmarks, where we can add this and future benchmarks. I have such a module on a branch, but had problems with the enforcer plugin complaining about the plugins I added to run the benchmarks from the command line. I need to play around with the plugin definitions and will create a separate PR if I can get it working. The main advantage is that you can checkout the sources on a (cloud) server and run the benchmarks there. For some performance optimizations in Kryo, I had benchmarks running for hours over night, to get the error rates as low as possible.

OK my previous benchmark was flawed because I created a new buffer for every run. The new isEmpty method for `AppendingStringBuffer´ is actually 40-50x faster for medium-sized buffers.
Benchmark                            Mode  Cnt           Score         Error  Units
StringsBenchmark.bufferFastIsEmpty  thrpt   15<PHONE_NUMBER>.579 ± 4949234.208  ops/s
StringsBenchmark.bufferIsEmpty      thrpt   15    42567269.762 ±   40091.373  ops/s
StringsBenchmark.fastIsEmpty        thrpt   15<PHONE_NUMBER>.208 ± 4067311.978  ops/s
StringsBenchmark.isEmpty            thrpt   15<PHONE_NUMBER>.032 ± 1951669.787  ops/s

https://issues.apache.org/jira/browse/WICKET-6952

Benchmark                            Mode  Cnt           Score         Error  Units
StringsBenchmark.bufferFastIsEmpty  thrpt   15<PHONE_NUMBER>.579 ± 4949234.208  ops/s
StringsBenchmark.bufferIsEmpty      thrpt   15    42567269.762 ±   40091.373  ops/s


windows opened with windowOpenNoOpenerWithSuccess hang sometimes while debugging in devtools

In Chrome sometimes opened window is sharing event loop with the original window, in cases like the same origin or the same parent domain. If one tries to debug one of such windows then others are hanging.
I was wondering whether it is better to rewrite like that:
export function windowOpenNoOpenerWithSuccess(url: string): boolean {
	const newTab = window.open();
	// pop-up allowed
	const success = !!newTab;
	// close immediately to avoid rendering
	newTab?.close();
	if (success) {
		// open safely with own event loop
		windowOpenNoOpener(url);
	}
	return success;
}

Updated: i tried with above and it does not help, Chrome blocks new windows besides first by default.

To avoid sharing the same event loop or whatever, I suggest to adopt windowOpenNoOpener. But that one does not return true/false if the window opened.
I left in this particular place windowOpenNoOpenerWithSuccess to maintain the existing behavior. I think this returned boolean was added as part of the Safari/iPad work.

Yes the returned boolean was added as a way for us to know if the window opened successfully. Since Safari sometimes blocks new windows / tabs.

@isidorn You could invoke different methods based on the browser: the one without a return value in Chrome / the one with a return value in Safari.

@alexdima this makes sense
@akosyakov we are open to a PR which implements this as @alexdima suggested.


Handle expiration of mobile map packages

100.5 Runtime added ability to handle expiration of mobile map packages -

Time-based expiration of mobile map packages and mobile scene packages is now supported in ArcGIS Runtime. An author can choose either a hard expiration where the package is not usable after the expiry date, or a soft expiration where a warning message my be displayed to the user but the package is still usable after the expiry date. Packages with such expiration constraints can be created using an upcoming version of ArcGIS Pro.

See https://developers.arcgis.com/ios/latest/api-reference/interface_a_g_s_mobile_map_package.html#a39fca5954cf2d4176c82322ff51726d9

@esreli ^^^


Upcoming changes v0.10.1: EIP-1271 support, signing transactions, calling external contracts, basic app redirect integration

Use cases 1,2,4 in https://github.com/polymorpher/one-wallet/issues/73 will be immediately supported, followed by 5
A basic tutorial in https://github.com/polymorpher/one-wallet/issues/74 (among first priority) will be provided
Making purchase at daVinci NFT marketplace will be supported (after daVince implements EIP-1271) https://github.com/polymorpher/one-wallet/issues/61
Apps will be able to request user's 1wallet to call an external contract's function, subject to the user's approval

Contract calling end-to-end is complete. Need to do some testing - going to use minting NFT as an example
Signing is complete except frontend and redirect route. Expected to wrap up at around Sep 2-3

done


Add '--inline-direct' parameter to 'dbt show'.

Resolves #
Problem
The 'dbt show' command loaded the manifest and ran jinja templating, even when these steps were not needed.
Solution
Add a new "--inline-direct" parameter to skip the manifest load and templating steps.
Checklist

[x] I have read the contributing guide and understand what's expected of me.
[x] I have run this code in development, and it appears to resolve the stated issue.
[x] This PR includes tests, or tests are not required or relevant for this PR.
[x] This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
[] This PR includes type annotations for new and modified functions.

Note that I have disabled several type checks because we need to make several changes to AdapterProtocol before types in this changeset can be adequately annotated.


Update AlphaLoss to support entropy schedules

This PR adds support for entropy schedules in the AlphaLoss callback. Also I removed the multiplication term in the default target entropy value since it defaulted to a very small value (CC @AliGhadirzadeh) and now we have the option to set the target value directly instead of scaling the number of actions by changing entropy_eps.

Maybe a few tests for this? Not sure how much "collateral" is needed to make a test of this work... Would be nice to see what happens if you pass an invalid value f.ex.


Fix(compiler-base-error): CodeSnippet component generates the line …

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

[ ] N
[x] Y

issue #115
2. What is the scope of this PR (e.g. component or file name):
compiler_base_error
3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[x] Contains experimental features
[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Other

In CodeSnippet components, the line number plus one.

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

[x] N
[ ] Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

[x] Unit test
[ ] Integration test
[ ] Benchmark (add benchmark stats below)
[ ] Manual test (add detailed scripts or steps below)
[ ] Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.
None

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
30 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.6%) to 58.391%

Files with Coverage Reduction
New Missed Lines
%

kclvm/sema/src/resolver/scope.rs
5
62.22%

kclvm/sema/src/resolver/schema.rs
25
82.39%

Totals

Change from base Build<PHONE_NUMBER>:
-0.6%

Covered Lines:
18782

Relevant Lines:
32166

💛  - Coveralls