x/tools/cmd/godoc: generate static docs

It is fairly trivial to compile a given Go version and run the doc server locally to
search for an older API.

But it would be nice if golang.org provided access to docs per release. One simple
solution to this is to add an option to godoc to generate static docs on disk -- just a
tree of static files (search would be disabled of course). Then docs for old versions
could be made available somewhere in golang.org.

One additional benefit is that projects that want to ship docs could generate the static
files and provide the html files for download, or create pdfs, chms etc based on them.

PS: I tried searching for a similar issue; sorry if this is a duplicate.

I would also like godoc to be able to generate static docs. The proposed workaround (hosting all the files and wgeting it) works but it crawls the entire contents of your GOPATH, which is less than ideal because that then bloats the static docs incredibly.
I still want things like the builtins to link correctly to docs, so some incantation of go list to pull out the dependencies of the project would be ideal. Unfortunately, I can't just write a bash script to do this because using godoc -html path/to/package just returns the raw HTML without any CSS, and no JS to handle section expansion.

As part of my work on #18342, I wrote simple static generator for godoc, that I realized is really well suited for resolving this issue. Is there any interest in including it's generated output in each release?
You can see statically generated docs at: https://static-hotlinks.digitalstatic.net/

As part of my work on #18342, I wrote simple static generator for godoc, that I realized is really well suited for resolving this issue. Is there any interest in including it's generated output in each release?

Is this static generator available somewhere? I'd like to give it a try for hosting docs for a few packages.

You can download the patch from CL/72890 and run render_docs.go directly.

Suggestion for those using this workaround, you may eventually want to add this to your wget command line: -X debug/pprof

For the record, I went with Cheney's godoc2md tool: https://github.com/davecheney/godoc2md and it works perfectly. I feed the resulting markdown files into a static site generator like Hugo.

I'd like to second supporting a static output of go doc without having to use other external tools like wget. I feel like https://github.com/davecheney/godoc2md solves this fairly well, but that tool is no longer being supported. I'd recommend adding markdown output to the go doc command.
The use case is fairly simple. When working on private packages or modules that can't be made public, it's nice to just bundle the docs in the repo as a README.md.

As customer, I'd like to express how "lost" I feel to generate a directory containing self contained documentation of a go project and not using any server or service. I've found many pointers and I might not be that informed, but having a multi language project where "the other guys" produce some "nice" javadoc contained in one directory; I'm lost to do that easily with go/go doc/godoc/... I might be not well informed. just my 2cents.

@marcellanz I agree, there doesn't exist a user friendly way of doing this yet. This issue is open and tracking resolving that task.
As a brief update, there has been progress made on relevant components that will enable resolving this issue. So it is moving along.

thanks for the update. sounds good.

@dmitshur this would be a great feature. Is there a timeline of when this would be rolled out?

It's not known when this issue will be complete. When there are updates, they'll be posted on this issue.

I want to add my two cents that I am currently wrapping up my first go library after being a python developer for 5 or so years, and the lack of easy static docs has me a little lost as well. Streamlined documentation is so important for team projects, and using godoc.org isn't a viable option for many in-house projects.
My use case: We already host most of our docs on readthdocs.org in a private repo. If i had a way of generating a static html file for my projects, then I might be able to upload them to their own page and keep our docs all in one place.

@dmitshur : Is someone actively working on this? Is there a public discussion or collection of PRs that we can follow to get a better sense of the progress and perhaps where we could pitch in?

I have workaround that using the wget command for that. Example: snippet
I have a similar issue with that. I'm using GitLab for my projects and I have decide to create and share with some handy GitLab CI YAML templates for Go projects that will automatically generate a static HTML Go documentation from the godoc tool without any external packages: https://gitlab.com/tymonx/gitlab-ci
Example: Go Logger documentation
Two nice features:

Embedded Go source code files
Search box is referencing to GitLab

I'm also waiting for this feature :)

For anyone who doesnt care for Gerrit, I mirrored the PR here:
https://github.com/golang/tools/pull/321
So you can build like this:
git clone --depth 1 git://github.com/golang/tools
Set-Location tools
git pull origin pull/321/head
Set-Location godoc/internal/render
go build render_docs.go

For the record, that old Gerrit CL of mine has been partially mirrored over to https://github.com/dsnet/godoc. My original intention for that repo is to serve as a testing bed for various godoc proposals (e.g., #7873, #25444, #44447, #45533). If others want to use it to statically generate godoc pages, then they are free to do so.

This is really annoying, especially because the anchors of links to source files are too the wrong line number... which is normally not recognized because godoc uses javascript to jump to the line too.

As part of my work on #18342, I wrote simple static generator for godoc, that I realized is really well suited for resolving this issue. Is there any interest in including it's generated output in each release?
You can see statically generated docs at: https://static-hotlinks.digitalstatic.net/

@dsnet URL is dead

https://github.com/golang/go/issues/39883

here is a good option:
go install go.abhg.dev/doc2go@latest
cd some-module
doc2go ./...

https://github.com/abhinav/doc2go

https://github.com/golang/go/issues/59056

https://github.com/golang/go/issues/63975

you can generate with Doc2Go:
https://github.com/abhinav/doc2go
it also supports generating different versions of a module

Is this feature (browsing old versions) essentially redundant with the "Added in go1.x" caption that pkg.go.dev displays next to each symbol? See:

https://github.com/golang/go/issues/42933
https://github.com/golang/go/issues/37102

pkg.go.dev should also display such a caption for the package as a whole, but does not do so yet. See:

https://github.com/golang/go/issues/51013

the title is "generate static docs", so I dont see what your comment has to do with anything. currently the go tool cannot generate static docs, or even serve them for that matter, to my knowledge

the title is "generate static docs", so I dont see what your comment has to do with anything. currently the go tool cannot generate static docs, or even serve them for that matter, to my knowledge

I realize that's the title, but if you read the first note of the issue it is merely proposed as "one simple solution"; the actual problem described is

it would be nice if golang.org provided access to docs per release.

could you explain why you seem to be steering the conversation away from static docs and towards a server setup, across multiple issues?
I get it, it seems you prefer that approach, but thats not the only approach. what I dont want to see is an issue or multiple issues closed with the reasoning "well, the Go tool can serve now, thats good enough"

could you explain why you seem to be steering the conversation away from static docs and towards a server setup, across multiple issues? I get it, it seems you prefer that approach, but thats not the only approach.

x/tools/cmd/godoc is deprecated and unmaintained, and doesn't work with modules, and for those reasons I would like to delete it and close all open issues associated with it. However, there are a number of remaining obstacles to doing so, such as features or modes of operation that godoc supports but its proposed replacements do not. In addition, there are requests such as this one for new features to be added to godoc, which is of course not going to happen.
My goal is to make sure that the needs or problems motivating these issues are properly addressed by the newer tools. As usual, addressing the need or problem does not always mean implementing the feature exactly as proposed. In this case, the needs appear to be ways for readers to (a) understand which version a symbol appeared in the Go std API, which could be addressed by "Added in go1.x" captions as in pkg.go.dev; and (b) view specific versions of an arbitrary package's docs, which is already addressed by pkg.go.dev (for public packages) or a local pkgsite instance (for private ones).
Is there some other need addressed by static docs here that I have missed?

people want to be able to generate HTML files for a given module or package. yes some people prefer to serve them, but others don't want to serve files, they just want some tool to generate the HTML files.  multiple people in this thread have request static files, not serving:

solution to this is to add an option to godoc to generate static docs on disk -- just a tree of static files

and:

To generate static docs, just run this command:
godoc -http=localhost:8080 &
wget -r -np http://localhost:8080/pkg/

and:

I haven't thought about using wget. Nice. For those interested in this trick, here are some notes.

and:

I would also like godoc to be able to generate static docs.

and:

You can ask wget to ignore robots.txt by adding the flag -e robots=off.

and:

I wrote simple static generator for godoc

those are literally just from this page, I could go on. these are people that want static generation enough to come up with these awful workaround with Wget, because Go is not offering a tool for the job. so I will ask again, why are you avoiding the issue? is your plan to just get the serve option working, then close the static requests as wont fix? if so it would be nice if you are at least up front about it, so people can pursue other options.

people want to be able to generate HTML files for a given module or package.

But why? That's my question, and none of the lines you quote contains an answer.
"Generate static docs" is a solution, not a problem. So what is the problem? I identified two problems, both of which (I claim) are solved by other means. What others remain?

is your plan to just get the serve option working, then close the static requests as wont fix? if so it would be nice if you are at least up front about it, so people can pursue other options.

As I said in my previous note, cmd/godoc will not be getting new features, so this issue as narrowly defined by its first comment is already "won't fix". Far from "avoiding the issue", I'm trying to understand what problems remain so that we can solve them by other means. No-one is stopping anyone else from pursuing other options.
I would appreciate it if you take your rhetoric down a notch in future.

Is there any plan then to have the go doc incantation become pkg site? For modern languages it seems imperative to have a documentation tool/command. It would be disappointing to see this go.
I had no clue this was a deprecated tool (I guess the source code says so?)
also @alandonovan, if no more work will be done on this, why not just close the issue and point people to pkgsite and its corresponding github issues since you mentioned it's missing some features. The back and forth seems silly for something that the Go team has committed to abandoning

people want to be able to generate HTML files for a given module or package.

But why? That's my question, and none of the lines you quote contains an answer.

Just serving godoc in an already running web server accepting only static files? No need to run a host or a specific program just to dynamically serve files that almost never change, for example.
The first message mentioned the creation of PDF file. Why not? Why the user should launch a web server + a web crawler to do this conversion?
I am sure we can find plenty of other examples of static files uses...
++

[@maxatome] Just serving godoc in an already running web server accepting only static files? No need to run a host or a specific program just to dynamically serve files that almost never change, for example. The first message mentioned the creation of PDF file. Why not? Why the user should launch a web server + a web crawler to do this conversion?

These all seem rather hypothetical: for example, PDFs from godoc or pkgsite are not very pleasant to read, and you would still need to run a browser to render the HTML. But at least you are addressing my question.
OK, I will leave this issue open, and we can interpret "godoc" as "pkgsite".

[@edani] Is there any plan then to have the go doc incantation become pkg site?

Yes, there is a plan to make go doc -http fmt.Println start an instance of pkgsite (or rather, a version of it shorn of heavyweight dependencies), and open a browser to the documentation for the chosen package or symbol. Oddly there isn't an issue for the feature itself, but the preparatory work is https://github.com/golang/go/issues/61399.

Sounds great!

people want to be able to generate HTML files for a given module or package.

But why? That's my question, and none of the lines you quote contains an answer.

judging by your comment here and others, your position seems to be "I don't think static generation is useful" is that really your position? do you really not understand why people would want to do this? personally I think the responsive design of https://pkg.go.dev is awful, and want to get away from it. I much prefer the older style, which https://godocs.io seems to be similar to. so my goal is to have a tool that can do
SOME-TOOL SOME-MODULE

and I get a folder of HTML files, that I can serve on GitHub or where I want. this is an extremely common scenario/request, so why you are having a hard time grasping it, or why it could be useful is beyond me. with the current approach, user would need to literally rent a VPS just to host their own docs, since its forcing a server approach instead of static generation.

But why? That's my question, and none of the lines you quote contains an answer.

Our use case is to hand out a (static) documentation for our customers which use one or more of our private go modules in their products.

https://github.com/golang/go/issues/65194

OK, I will leave this issue open, and we can interpret "godoc" as "pkgsite".

Let's just retitle this.

judging by your comment here and others, your position seems to be "I don't think static generation is useful" is that really your position? do you really not understand why people would want to do this?

No, I don't have a position on the issue yet. I can imagine lots of ways it might be useful, but that's just my imagination (or @maxatome's, three comments back). I wanted to hear about actual concrete problems before deciding on a solution.

personally I think the responsive design of https://pkg.go.dev is awful, and want to get away from it. I much prefer the older style, which https://godocs.io seems to be similar to.

Well, that's really a separate question of what HTML is generated for a page. If pkgsite were to support static generation, perhaps it should a print-friendly stylesheet.

I am seeing at least 3 people commenting in support of static generation, in just the last day:

https://github.com/golang/go/issues/2381#issuecomment-2182930621
https://github.com/golang/go/issues/2381#issuecomment-2182970633
https://github.com/golang/go/issues/2381#issuecomment-2182979210

not the mention the previous users above, who so wanted the feature that they used hacky workaround with Wget. so I think we are past the point of "is static generation" useful. so I don't think arguing against the point, or requiring supporters of static generation to justify their viewpoint, is a good use of anyone's time
given the overview of this thread, perhaps a better question to ask would be "why should we omit static generation", or "why is it important that we only offer a serve option and not static generation option"

I can imagine lots of ways it might be useful, but that's just my imagination. I wanted to hear about actual concrete problems before deciding on a solution.

At Amazon, I can safely say we have thousands of developers writing and reading Go. Our source code is stored in an internal Git hosting, and our home-grown build system has a build tool that leverages an internal Go module proxy. One of the language-agnostic outputs of our build system for a particular package (along with sources or binaries) is a documentation folder. Our build viewer can serve HTML files for a built release, which is a common pattern from other languages like Java (javadoc), Python (pydoc), Ruby (rdoc or 3rd party yard), Rust (rustdoc), C/C++ (3rd party doxygen). For Java, Python, Ruby, and Rust those are all first-party tools that our build tooling automatically calls to generates docs.
Today, in order to view Go documentation for a package, I have to check out source code on a machine (assuming I have source viewing/checkout permissions, which are separate from release consumption/viewing. For Go thats roughly equivalent, but not for all languages/builds), build it, spawn a process, possibly set up a port-forward (say, if I'm building on a remote Linux box), and then I can finally view the documentation. I can't tell you how many times I've had to repeat this process when I just want to browse another team's Go package.
The ability to invoke a maintained tool with roughly the arguments (to @3052's point)
TOOL -output-directory ./docs PACKAGE...

would be in line with what other programming languages already support and would dramatically simplify the developer experience at Amazon when viewing docs for internal Go packages.
Because there is not one single filesystem that contains all versions of all packages' source code, and packages have differing permissions, running a fleet of pkgsite processes for all internal code, or spawning a per-user pkgsite process is not going to work for us.

If pkgsite were to support static generation, perhaps it should use a print-friendly stylesheet.

Our use case does not need a print-friendly version, as the vast majority of use cases would be online.
While I've described the Amazon internal use case here, but I think the general contours of this use case probably applicable elsewhere. I can also speak to previous places I've worked where I fronted statically generated Python and JavaScript HTML docs with an authenticated webserver, and Go was the odd one out.

(A print friendly stylesheet should be a separate issue. That would be equally as useful for someone wanting to print from/save a pdf of a page on go.dev and nothing about being dynamic or static factors into adding print styles.)
I agree that static documentation is important.
I worry about creating issues where things have to be done twice for the static vs. dynamic presentation or skew when someone adds a feature but no one checks to make sure how it works in the static version or scope creep because someone has a use case where they need to have all packages in a module go on one page or have each type get its own page and so on.
Maybe it would suffice to have a -json flag that output all the raw data. (And when I say raw I mean even the doc comments should be the go/doc/comment AST instead of html fragments).
Then there just needs to be a frontend process that takes that and applies the data to templates, but, importantly, there could be many different such frontends depending on taste and need.
Essentially, instead of
$ pkgsite -static -output dir pattern

you'd have
$ pkgsite -json pattern | static-pkgsite dir

but you could have many such static-pkgsite commands.
(pkgsite could also serve this same json dynamically for headless operation, but that would also be another issue).

My goal is to make sure that the needs or problems motivating these issues are properly addressed by the newer tools. As usual, addressing the need or problem does not always mean implementing the feature exactly as proposed. In this case, the needs appear to be ways for readers to (a) understand which version a symbol appeared in the Go std API, which could be addressed by "Added in go1.x" captions as in pkg.go.dev; and (b) view specific versions of an arbitrary package's docs, which is already addressed by pkg.go.dev (for public packages) or a local pkgsite instance (for private ones).
Is there some other need addressed by static docs here that I have missed?

@adonovan I also want to pitch in some with needs that you have missed. (Though @micahhausler did a good job already.)
At my job, I want to serve docs of different types -- Go docs, other language docs, web pages generated from protobuf definitions and markdown files, and more -- and the paradigm that makes it easiest to get all these working in a uniform way is if some job can generate some static files from the code in our monorepo at a particular commit and stick them somewhere to be served.
Also, for our monorepo the normal notions of "module versions" are meaningless. What we care about is what particular git commit (or maybe a branch or a tag) the docs you are looking at were generated from.
A tool that does a straightforward code -> HTML transformation is a primitive upon which it is easy to build this kind of stuff.

So, guys, you inspired me to develop gdmd. You can just generate README.md with same documentation and keep it in your repo. GitHub/GitLab render it by default during directories(packages) navigation. Simple but very useful tool.

https://github.com/chocolacula/gdmd is promising - but its utterly broken except for the most basic packages - for example it does not currently render methods correctly

another good option
https://codeberg.org/pfad.fr/vanitydoc


datasheet: add Texplained to list of credits

to match the website credits page

Should be added in docs/CREDITS.md. Note that there's a copy of this file in each shuttle's branch (e.g. tt06, tt07, etc.), so we'll need to:

update the file in each of the relevant branches.
update the tt-support-tools submodule (under tt/) in each of the shuttle repos

It it may just make sense just to move this file over to docs/ in the shuttle's repo, as we do with the chip renders.


Fixed Issue number #327(To allign inputs in matrix and also in some other section in center)

Related Issuse
Allign input in matrix and also in some other section in center.
Closes: #[issue number that will be closed through this PR]
Issue Number #327
Describe the changes you've made
I have used centre tag and margin auto to allign all input in centre
Checklist:

[x] My code follows the style guidelines of this project.
[x] I have performed a self-review of my own code.
[x] My changes generate no new warnings.

Screenshots
   Updated           |

| :------------------------: |
updated screenshot  |

Hi by mistake i have deleted my file i will again do it and send you PR


add test case to push/pull edge container images in quay.io

This pull request includes:

[ ] adequate testing for the new functionality or fixed issue
[ ] adequate documentation informing people about the change such as

[ ] create a file in news/unreleased directory if this change should be mentioned in the release news
[ ] submit a PR for the guides repository if this PR changed any behavior described there: https://www.osbuild.org/guides/

Add test case to push/pull rhel for edge container images in quay.io.
The destination quay repository is docker://quay.io/osbuild/testing-rhel-edge-push
Find the repository details and credentials in https://issues.redhat.com/browse/COMPOSER-816

The ostree-ng.sh test reported PASS in https://gitlab.com/osbuild/ci/osbuild-composer/-/jobs/1293983880.


Feature Request: Support for @FILE CLI Option for Additional CLI Options

I created a StackOverflow question and got no hits on it. I also have looked through all the documentation and can't find anything on it so I am putting in a feature request.
In some command line applications, there is the ability to use the @FILE syntax to include a file that contains more CLI options. This is especially useful for apps like ar when you could potentially run into the max length of a command line call.
I use DocOpt.cpp so I would most likely port this over to that if it gets approved. I wanted to post it here to get people's feedback on if it is something everyone agrees is a good addition to DocOpt.

I would also like to have some support for reading flags from file like gflags. Any syntax is most likely ok

Any updates on this issue?
FWIW it also matches the argparse fromfile_prefix_chars option and might be the only thing stopping us from switching over our argparse-heavy utility to using docopt


weakref in process will make objects to skyrocket

Godot version:
Godot 3.2 Alpha 3 (from your website)
OS/device including version:
Windows 10
Issue description:
Using weakref inside process or physic process will make your object resources to skyrocket.
Steps to reproduce:
start a new godot project, add this script code to your scene:
var is_item_empty = null

func _process(delta: float) -> void:
	if weakref(is_item_empty).get_ref():
		pass

Run the project and view debugger -> monitors -> objects
Minimal reproduction project:
example above should be good.

WeakRef is a Reference so it should be cleaned up properly after each _process, and the argument is null so there is nothing else creating new objects here... that's really odd.


Check the progress of each jobs in tasks page

if i had a lot of jobs, how to check the progress(percent or like:90/1001) of each jobs in tasks page?

@YuanNBB , in general, it is possible only if a worker provides it manually. It is duplication of https://github.com/opencv/cvat/issues/1369. I will close the ussue. Please track the original one.


requests.get(verify='path/to/self-signed-certificate') cannot verify SAN

Verifying a certificate which have Subject Alternative Names with IP addresses (or DNS names), Common Name should not be checked and those addresses should be checked instead.
RFC6125 section 6.4.4 describes this.

@kissgyorgy Thanks for this!
We already do this for DNS names, as you can see in this code. The reason we don't do it for IP addresses in SANs is because we currently don't support authenticating IP addresses in SANs.
This is a bit of a flaw in urllib3, and we have an open issue for it in shazow/urllib3#258. Fixing that issue would automatically fix this problem, so I recommend focusing on that.


Player cover check does not appear to DM

haven't tested this extensively but we experienced an issue where the player cover checks did not appear on the DM chat. This is problematic if cover is applied manually (as the DM can't set the manual setting)

Can you provide any further information on this? I have not seen this occur myself.

I will keep an eye out for it, but it's been so long and I don't recall seeing it lately so we can close for now


Avoid inefficient code by always running webpack in production mode.

The file to load by bundlers like webpack, rollup and browserify is dist/clipboard.js.
https://github.com/zenorocha/clipboard.js/blob/cf9e8fd7ce659e42828dcb6dcac02f72ee04db20/package.json#L7
That file has horribly inefficient code that evals(!) strings of code. For example this line:
https://github.com/zenorocha/clipboard.js/blob/cf9e8fd7ce659e42828dcb6dcac02f72ee04db20/dist/clipboard.js#L145
eval is also a problem for sites using a Content Security Policy.
This happens because webpack is run in debug mode. This PR changes the webpack config to always run in production mode and only toggle the minification for the different files.

That's great, thanks a lot for the PR!


Change default 'id' field

I have a complex database so I can't named 'id' for all primary keys. I need use different id's to work with. Exemple: IdGroup, IdCenter, etc..
I can't use these primary keys as identificators in the multiselect control because it only understand 'id' as identificator.

+1

+1

+1

feature available in v2.8.0. Please use primaryKey property in settings.


Last read can be changed by sending this Report_UpdateLastRead with user account number - Reported by @K4tsuki

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Open app
Send API request Report_UpdateLastRead for Account A (left window), on Account B room using Account B credential.
& Change sequence number, Account A email and account number

Expected Result:
User should not be able to change read unread messages bypassing login
Actual Result:
When opening Expensify on new tab, you have unread messages on that room because of the Api request.
Workaround:
Unknown
Platform:

Where is this issue occurring?

Web

Version Number: 1.1.23-0
Reproducible in staging?:
Reproducible in production?:
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://user-images.githubusercontent.com/43995119/147600254-970110fb-48cc-4b15-ba3b-9159e4689353.mp4
Expensify/Expensify Issue URL:
Issue reported by: @K4tsuki
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1640135067456000
View all open jobs on GitHub

Triggered auto assignment to @deetergp (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

Discussed with scott and taking over this issue 🙂

Demoting since its not a severe bug and its not something users are actively exploiting.

Triggered auto assignment to @mallenexpensify (Internal)

Weird, not sure why marking a PR as Internal triggers an auto-assignment 🤔

Weird, not sure why marking a PR as Internal triggers an auto-assignment 🤔

Also unsure and unsure how to best search GH to see when it might have changed.  Checking here
https://expensify.slack.com/archives/C01SKUP7QR0/p1640812631324000

That is expected behaviour to make sure we pay the contributor for reporting. The OG issue is here https://github.com/Expensify/Expensify/issues/185425. It was triggered because there is the Reported by part in the title.

Thanks @vitHoracek , that makes sense.  I re-assigned myself

No update, but I want to stay assigned for payment, so commenting

@chiragsalian should we work on this soon? I'm unsure how time-sensitive and/or important it is

Oh, this was resolved a while back and tested on staging too - https://github.com/Expensify/Web-Expensify/pull/32703#issuecomment-1005096954.
I totally forgot to put the clean-up PR for review but i'll do that today.
I guess i should have posted here when the first PR went live. Anyway, since its live all that remains is for you to pay K4tsuki for reporting the issue.

Thanks @chiragsalian
@K4tsuki can you apply and confirm here when you have?
https://www.upwork.com/jobs/~01edf0f0a8f389686b

I have applied to the upwork job, thank you @mallenexpensify

Hired you @K4tsuki , let me know when you accept and I'll pay

@mallenexpensify I have acceted the offer, thank you.


Bump Brakeman

Upgrade Brakeman from 5.3.1 to 5.4.0
See https://brakemanscanner.org/blog/2022/11/17/brakeman-5-dot-4-dot-0-released

Coverage remained the same at 92.666% when pulling 8df284229216878e92b16847c7795e42cf8408fe on brakeman_5_4_0 into 6119d20eee2ee98dc9eee163053fa472da78aa2e on master.


Adds Subject Alternative Name's on several certs

play-grpc-* samples fail on Java 8 dues to 8u252+ALPN support. See https://github.com/akka/akka-grpc/issues/946


Use observers for timing code and recording events

e.g. from https://dplutils.readthedocs.io/en/latest/api_observers.html

#84 use observers to time dft and xtb walltime


⚠ SceneTime has degraded performance

In d52967f, SceneTime ($ST) experienced degraded performance:

HTTP code: 200
Response time: 1516 ms

Resolved: SceneTime performance has improved in 68b0173 after 11 minutes.


[IOTDB-224] fix buffer size and remove cache

Where is removing cache?

Where is removing cache?

if (valueOccupation != -1) {
    return valueOccupation;
 }

is removing cache

I have pulled the latest master code, but I don't know why it's failed at rpc part. Maybe later I pull the master code again


[Request] Set Output Device for PTT Sound Feedback

Currently, there is no way to set another output device for MicMute. I tried it through the windows settings as well and it does not really change it either.

Hey, I've looked into this and it looks like there's no easy way to implement it, I would need to use Windows's WASAPI which I'm not familiar with at all (right now MicMute just uses a simple call to PlaySound)

Hey, I've looked into this and it looks like there's no easy way to implement it, I would need to use Windows's WASAPI which I'm not familiar with at all (right now MicMute just uses a simple call to PlaySound)

I am not really too familiar or experienced with AHK and all of this but I desperately went to google in an attempt to help and found something about BASS Library. I am probably not helping but I thought it was worth a try.

I've looked into this bass library and it looks surprisingly good and easy to use. I'll see what I can do :D

A volume slider for the sound feedback would be a nice touch in my opinion.

You can use the windows volume mixer for that, it works with both the dev build and older versions

Done in Development Build.


Cache document.currentScript for non-ESM output

Fixes issue https://github.com/rustwasm/wasm-bindgen/issues/2502.
Currently, when using non-ESM module output (i.e. scripts output), the generated JavaScript accesses the Document#currentScript getter at runtime, which will always have a different (incorrect) value by the time that the user runs their code to load their Wasm.
With this change, the default source for ESM and web script output is cached in an immutable variable, and accessed when the user doesn't pass an argument.
Other output targets should remain untouched.
As an added side-effect, the default source is always constructed, this should add a small amount of extra overhead to loading the glue JS, but if the user loads the Wasm multiple times (for some reason?), it is only constructed once, which should improve performance.

Oh wait, Deno and Node don't get default values, I'll just use the constant variable.

Oh wait, Deno and Node don't get default values, I'll just use the constant variable.

Thanks! Could you leave a comment in the source for why it's done this way?

@alexcrichton Two questions: by "source," are you referring to the JS or Rust? And what about the way that it's done would you like me to leave a comment about?

This comment looks fine, thanks for that! I think this needs a rebase now after a previous merge, want to do that and I can merge?

Could you take a look into it and help me debug this?

I think you need to run the tests locally with BLESS=1 to regenerate the expected output since I believe it's changing here

(or the test expectations of what the output is just need updating)

More recently, I've been responding to people and writing code on mobile, I don't have a PC to download rustc & friends on at the moment, so it would be some time before I could attempt to run those tests locally.
If someone else could run them, we should be able to fix the test failure sooner


URL endpoints

Should we keep all the url endpoints the same or change them as we translate?
For example, the current endpoint for tutorial is /tutorial. Do we change it to something like /hướng-dẫn or just leave it as it is?

I think we should keep it as English. Don't need to translate endpoints.

Yes, keep it in English! Same goes for anchor links (tutorial#overview).
See here: https://github.com/reactjs/reactjs.org-translation/blob/master/style-guide.md


Fix ubuntu14 setup for pip packages

Closes #3605
Description
There are some problems installing some pip packages in ubuntu14.
Related issue and scope

[x] I opened an issue to propose and discuss this change (#3650)

My changes affect the following components

[ ] API
[ ] Controller
[ ] Message Bus (e.g., Kafka)
[ ] Loadbalancer
[ ] Invoker
[ ] Intrinsic actions (e.g., sequences, conductors)
[ ] Data stores (e.g., CouchDB)
[ ] Tests
[ ] Deployment
[ ] CLI
[x] General tooling
[ ] Documentation

Types of changes

[x] Bug fix (generally a non-breaking change which closes an issue).
[ ] Enhancement or new feature (adds new functionality).
[ ] Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

[x] I signed an Apache CLA.
[x] I reviewed the style guides and followed the recommendations (Travis CI will check :).
[ ] I added tests to cover my changes.
[ ] My changes require further changes to the documentation.
[ ] I updated the documentation where necessary.

Codecov Report

Merging #3614 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #3614   +/-   ##
======================================
  Coverage    74.4%   74.4%
======================================
  Files         125     125
  Lines        5951    5951
  Branches      384     384
======================================
  Hits         4428    4428
  Misses       1523    1523

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c81385...9e18b20. Read the comment docs.


Handle the case of registering active plugins during remote init

With Plugin-V2, plugins can get activated before remote driver is
Initialized. Those plugins fails to get registered with drvRegistry.
This fix handles that scenario.
** Reproduction steps **

Install network-plugin and create a network.

$ sudo docker plugin install tiborvass/test-docker-netplugin
Plugin "tiborvass/test-docker-netplugin" is requesting the following privileges:
 - network: [host]
Do you grant the above permissions? [y/N] y
tiborvass/test-docker-netplugin

$ sudo docker network create -d tiborvass/test-docker-netplugin:latest testnet2
16262841d23a96d287c58b4569d2ba3f6205d29f7eeff5fa658f882a32e89111

Restart the daemon, make sure the plugin still exists and create another network. Without this PR, the network creation will fail.

{{ RESTART DAEMON }}

$ sudo docker plugin ls
ID                  NAME                              TAG                 DESCRIPTION                      ENABLED
fedd8eb3d5fb        tiborvass/test-docker-netplugin   latest              Test network plugin for Docker   true

$ sudo docker network create -d tiborvass/test-docker-netplugin:latest testnet3
Error response from daemon: could not resolve driver tiborvass/test-docker-netplugin:latest in registry

Signed-off-by: Madhu Venugopal<EMAIL_ADDRESS>

ping @aboch @sanimej @anusha-ragunathan

Related to https://github.com/docker/docker/issues/29471

LGTM

@anusha-ragunathan handled the ipam plugin case as well. PTAL.

LGTM

LGTM


Subdivision creation not working

Paper 1.16.1 b138
GD 1.5.1 DEV1
LP 5.1.106
Only .user.* + .admin.* permissions in use on clean test server.
Can't create subdivisions in admin claims or basic claims, get the following permission error along with a message about claiming mode that doesn't even belong.

I think this might also be the reason behind #277 as they're just not working at all...

What does LP verbose show? I'll fix this issue this week.

Sorry this is the same as #277 small derp on my part thinking it was different, closing.


fix: the long line linter only acts on mathlib

Zulip

Can you please add a -- TODO: once per-project settings are available, revert this hack to make it only apply on Mathlib?
bors d+

bors r+


⚠ Bofrost.at has degraded performance

In cbdf86a, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 886 ms

Resolved: Bofrost.at performance has improved in 8af00b3 after 18 minutes.


WIP - Dynamic Recursion

Moved the recipes to a sub-page
Adding the graph visual as outlined in todo
Possible rework of the structure at the start
Adding additional insight
General copy cleanup

Hi! Thank you for the PR! I see it is marked as WIP so I suppose you do not want me to merge it yet? In that case it is better to turn it into a draft (just search for the "Convert to draft" link on this page.

I had some WIP changes myself, which are now on main. I have tried to resolve the conflicts in a non-lossy way but I suppose you will need to delete some content. Sorry for that!


Bluetooth: controller: Improved continuous scanning

Refactored the high frequency clock preparation advanced
feature to improve radio utilization during continuous
scanning.
The inter-event timespace value now considers the reserved
timespace while determining if the high frequency clock
will be retained. This reduces the preparation time, hence
increased radio use inside scan window.
Signed-off-by: Vinayak Kariappa Chettimada<EMAIL_ADDRESS>

Codecov Report

Merging #5972 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #5972   +/-   ##
=======================================
  Coverage   43.76%   43.76%
=======================================
  Files         485      485
  Lines       54660    54660
  Branches    10690    10690
=======================================
  Hits        23924    23924
  Misses      30596    30596
  Partials      140      140

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ff9863...7124e6a. Read the comment docs.


[BUG] Four classifiers failing fit when not enough time points (10)

Multiple time series classifiers seem to be failing when the number of time points is too small.
I've verified this with DrCIF and SupervisedTimeSeriesForest on win py3.9, other estimators that may be affected are: HIVECOTEV2, MUSE.
The following code runs:
from sktime.utils._testing.panel import _make_classification_y, _make_panel_X

T = 20

y = _make_classification_y(n_instances=10, random_state=42)
X = _make_panel_X(n_instances=10, n_timepoints=T, random_state=42, y=y)

my_cls = DrCIF().fit(X, y)

The following code does not run:
from sktime.utils._testing.panel import _make_classification_y, _make_panel_X

T = 10

y = _make_classification_y(n_instances=10, random_state=42)
X = _make_panel_X(n_instances=10, n_timepoints=T, random_state=42, y=y)

my_cls = DrCIF.create_test_instance().fit(X, y)

The error message raised is non-informative.
I'd expect the code to run, in both cases, or at least raise an informative error message in the second case.

more likely the series length, since we fit on 10x24 for unit tests. Should through an informative error though I agree.

where are the methods _make_panel_X and _make_Y?

(sorry, misread, hence deleted a comment)

to recreate

len_range = 5, min_intervals = 4, so random fails. It may just need an edge case check,
len_range = min(
transform_length - intervals[j][0],
self._max_interval[r],
)

where are the methods _make_panel_X and _make_Y?

Ah, sorry, forgot the imports. Added them at the top.

& MUSE seems to have stochastic failures even for larger sizes?
See this run
https://github.com/alan-turing-institute/sktime/runs/4783434797?check_suite_focus=true
Locally, the test was not failing.

not sure about MUSE, will try fix our two first then take a look at the other two.

train_X = np.random.rand(10, 10)
#val = np.random.randint(low=0, high=1)
#print(val)
train_y = np.random.randint(low=0, high=2, size = 10)
cls = MUSE()
cls.fit(train_X, train_y)
gives an intermittent error

looks to be a problem with the data not being consistent with logistic regression (assuming this is what linear_models_logistic.py is). I'll take a look

so its getting to here in _muse and all_words is empty.

basically feature selection finds no relevant words, which causes the sklearn classifier to (iunderstandably) crash. Discussed with Matt and we will add a special case for when all_words is empty and just keep all the words, any thoughts @patrickzib ?

and @MatthewMiddlehurst has also found the problem with DrCIF and by implication HC2, PR to follow.

one way would be fallback behaviour. For instances, if whatever features fail to extract, predict the majority class on the training set instead of running against a wall.


Create CODE-OF-CONDUCT.md

This is a requested document for repos. It follows a standard format.

Closing, as I believe this issue is now fixed!
Link: https://github.com/input-output-hk/cardano-coin-selection/blob/master/CODE_OF_CONDUCT.md


Reduce Cloudwatch logs Retention period for workload accounts

Describe the Issue
Right now the cloud watch logs retention period is around 2 years and that would cost us money
Additional Context
Might require some config file changes, Contact warren for more info.
Acceptance Criteria

Discuss on the retention period and see if there is a way to reduce the period.

Extra Template Info
Definition of Ready
These set of conditions will need to be met in order to bring a ticket into the sprint and start work. Protects the team from unclear requirements.
Issues (Task/Story/Spike) aligned to an EPIC and linked appropriately.
Assigned to the appropriate CPF MEMBER (and is not left blank in ZenHub) at the start of sprint (1st day of the sprint)
Acceptance has been defined for the issue and has been reviewed with CPF team and approved by the necessary approver.
Has been sized and estimated by the delivery team.
Detailed breakdown of the steps required to complete the story in the additional context
Any additional specifications have been documented, reviewed with CPF and approved by the necessary approver.
Acceptance Criteria
A set of pre-defined requirement that need to be met in order to mark the user story as ?done?.
It should be testable with no room for interpretation
It should be either ?pass? or ?fail?
It should be clear enough for business stake holders to understand
As part of the user story, it should be written from the user perspective
A well written acceptance criteria is great for

managing expectations
defining scope
reducing ambiguity
establishing testing criteria for QA
Given (Pre-condition)
When (Action)
Then (Outcome)

Definition of Done
These set of conditions are met for work to be considered as complete on an issue.
All acceptance criteria(s) have been validated.
All the necessary documentation for the issue has been uploaded to Teams.
Functionality has been tested when applicable.
Functionality has been demonstrated to the relevant stakeholders (where applicable).
Story has been scheduled for a Sprint Demo/community update and impacted teams invited to the Demo.
Stories accepted by PO and documented for potential sharing with impacted users.

Documented = Captured in Community Update (CU) deck
Release notes = aspirational goal of providing a bulleted list of features and changes that our users can touch. Was going to store them in our Cloud Pathfinder repo. Can also display to users in the CU

Reduced to 90 Days in Forge and Assembly. Waiting to communicate to the community before doing the changes in Live


Dynamic tank infinite fluid

Dynamic tank will not draining fluid from the pipe network if the tank is at its full capacity.
if(doFill)
{
dynamicTank.structure.fluidStored.amount = getCapacity();  << This will cause subsequent call for getNeeded to return 0 thus making infinite fluid.
if(getNeeded() > 0)
{
	MekanismUtils.saveChunk(dynamicTank);
	updateValveData(true);
	dynamicTank.sendPacketToRenderer();
	updateValveData(false);
}

}
return getNeeded();
This can be fixed by storing getNeeded() in a variable before setting fluid amount to tank capacity.

I am also experiencing this problem whereby a dynamic tank that I have completely filled, when connected to a pipe network with other devices, becomes an infinite source of it's contained liquid.

Fixed, thanks!


Documentation - mention that Yeoman is a prerequisite

mention that Yeoman is a prerequisite
Hi,
first of all, thanks a lot for the awesome work on JHipster! We use Vue.js in some of our applications and I was thrilled to see that JHipster has support for that.
I'd like to suggest a tiny improvement. The current documentation does not list Yeoman as a prerequisite to run jhipster --blueprint vuejs.
I didn't know about it and the error message was a bit misleading so it took me a while to understand that I needed to have yeoman installed.
Proposed fix: add the below to the Prerequisites section
Make sure you have Yeoman installed. If not, just run npm install -g yo
Regards,
Michael.

This should no longer be necessary on the next JHipster release https://github.com/jhipster/generator-jhipster/pull/10004

that's great to know, thanks for the update!

I think we can close this right? The main generator has been released with that change.

right, let's close this


Sequence commands prior to logging

This PR extends #9 to move sequencing of LINEARIZABLE commands to the Raft leader. Commands must be sequenced prior to writing to the log, otherwise commands that are cleaned from the log will represent breaks in the sequencing of a set of commands for a specific session, and the state machine will not be able to advance. With the leader sequencing commands to the Raft log, state machines no longer have to assume commands may have been written out of order.

I've merged #9 with this PR. Here's the outline of the earlier changes from that PR:
With this PR, Catalog supports two consistency levels for commands and four for queries. Following are the proposed consistency levels. Note that while consistency levels allow the client to specify order of execution for commands and queries, all concurrent asynchronous callbacks are executed sequentially in all cases.
Command consistency levels

CAUSAL - The causal consistency level guarantees consistency between non-overlapping commands from a single client. Essentially, what this means is that the internal state machine does not attempt to reorder causally consistent commands. Because the nature of Raft is such that once a response is received, the command is guaranteed to have been committed, simply relaxing the order requirement for concurrent requests from a single client gets us causal consistency from the perspective of that client. Note that this only applies to asynchronous usage.
LINEARIZABLE - The linearizable consistency level guarantees sequential consistency for all writes from a client. That is, if a client writes a, b, and c, in that order, those commands will be applied to the state machine in that order and responses will be received in that order. Because writes are linearizable, this sequential consistency makes correct linearizability possible.

Query consistency levels

CAUSAL - Causal consistency requires that non-overlapping reads be sequential, but concurrent reads can be reordered. How this is implemented is by sending the client's last seen index and the last successful write from the client with each request. Server state machines will ensure state progresses at least up to the last write or the last index seen by the client, whichever is greater.
SEQUENTIAL - Sequential consistency requires that all reads - including concurrent ones - see state progress monotonically. In some cases, queries can be reordered if the client switches servers during concurrent executions, so clients must ensure order is preserved in responses. This works similarly to causal consistency - by sending the client's last seen index - with the additional constraint that if a client receives an ordered response for a version prior to the last seen version, it will resubmit the request. In practice, except in failure cases, clients should usually see responses in sequential order because of the nature of state machines.
BOUNDED_LINEARIZABLE - This is the same as the LINEARIZABLE_LEASE consistency level which existed previously. Queries will be forwarded to the leader, and the leader will apply the query to its own state machine, assuming that it must have contacted a majority of the cluster within the last heartbeat timeout (leaders will step down if they fail to contact a majority of the cluster).
LINEARIZABLE - This is the same LINEARIZABLE consistency level as previously existed. Linearizable queries will go to the leader, and the leader will synchronously verify its leadership with a majority of the cluster before responding.


bug: Completed green tick icon should be behind the sticky header

Describe the bug
The completed green tick icon is visible above the sticky video path header if the week videos card is not in hover state.
To Reproduce
Steps to reproduce the behavior:

Login and go to any course video section.
Mark all videos as completed in a chapter.
See the completed icon overlapping.

Expected behavior
Ideally it should be behind the sticky path header when overlapping in both normal and hover state.
Screenshots or GIFs
https://github.com/user-attachments/assets/18b6bce5-f01f-42b0-9363-925021d335fa

I have created a pull request fixing this issue #1661


Plane system

Hello !
A friend of mine asked me to create a program that could edit pixel-art plane-based game assets.
So I came up with this : it is capable of editing three-dimensional assets with the same tools as Piskel, and is compatible with the original app.
Even if I know this is not the original purpose of the app, I thought that if you may be interested.
I think some people may like this feature, and that would be also cool for me because I wouldn't be the only one to maintain this project :smile:
I know there remain some work to do in order to fully implement this into the website, but I wanted to know your opinion before going further.
I also know that you won't accept this PR immediately, but you can tell me what to do to make this fully compatible with the current website !
Hope you'll like this PR !

Thanks for the PR!
I tried out your branch locally and it looks like it's working pretty well. Given the amount of changes that's a nice achievement :)
First of all I need to say I know nothing about plane based assets. Is there any documentation or example I could check out to understand how this is used ? Same question about the plane offset feature.
My gut feeling is that if we merge this in Piskel, we will have to hide it behind a preference. One of the main strengths of Piskel is that it's easy to use for beginners & children. I would like to try to preserve that.
The decision to merge or not will really depend on the additional maintenance. I need to review the code change in depths to get a better idea.
(Really sorry to sound conservative, given the hard work you've put into this :/ )

Good thing you liked this ;)
The plane-based system is something that I and my friend more or less invented, it's just a way of creating art objects : the idea is that we wanted to keep making pixel arts but we also wanted to add depth to our asset, and that's what we came up with.
We thought that would be a way to make 3d models without using editors like blender, because we want to create things as fast and simply as possible (and learning Blender would be too long :palm_tree: )
So no, I don't think there is some kind of documentation about plane-based assets, nor examples because we just did not start creating assets (and I don't think someone already did something like this)
And, to answer your question, the offset system is just a way to define the plane's position :wink:
I did not think that as a main feature for the editor, but as you said it could be a "hidden" preference, for people who may want to try !
I also know there still remains work to do in order to make this compatible with the whole project, but I'll try to do my best !


E - Refresh existing security docs

Epic
Refresh existing docs
Acceptance criteria

[ ]

@chinikes @Elchi3 How is this different from #3227 ? This issue seems like it should be closed, since it has no content.

No idea, was probably an earlier placeholder.
Closing as duplicate of https://github.com/mdn/sprints/issues/3227


Deprecate this action

GitHub released https://github.blog/changelog/2021-10-05-github-actions-dry-your-github-actions-configuration-by-reusing-workflows/
This will make this action unnecessary.

Unfortunately this is not exactly what we need, so we will not deprecate this action.


Add (new) sniff for class opening brace on same line to core ruleset.

Checks that the opening brace of a class or interface is on the same line as the class declaration.
Also checks that the brace is the last thing on that line and has precisely one space before it.
Review appreciated.
Also: needs testing of the fixer code (doesn't work on Windows so haven't been able to test this myself.

I think the test for exactly one space before the { would already be covered with other sniffs?
If your new sniff is named as checking for opening brace on same line, then that's only what it should cover, nothing else. Keeping the sniffs small and focused allows user flexibility when choosing which they want to use in their project.
As such, isn't there a PHPCS sniff that ensures a certain arrangement of braces? If not, these seems generic enough that the fix should be made there, rather than here, as it's not really WP specific.

I think the test for exactly one space before the { would already be covered with other sniffs?

It is not.

If your new sniff is named as checking for opening brace on same line, then that's only what it should cover, nothing else. Keeping the sniffs small and focused allows user flexibility when choosing which they want to use in their project.

The messages have all been given a code, so people can disable them modularly.
What about if I change the sniff name to something like ClassOpeningStatement ?

As such, isn't there a PHPCS sniff that ensures a certain arrangement of braces?

There are a few, but all of them enforce the opposite of what the WP standard is (braces on new line).

If not, these seems generic enough that the fix should be made there, rather than here, as it's not really WP specific.

Makes sense to me, I'll open an issue there to see if there is interest.
All the same, it might be a while before something like this gets merged into PHPCS and then another while before the WPCS PHPCS dependency minimum version goes up.... so should this be maybe be merged anyway ? It can always be removed later if and when it would make it into PHPCS.

Upstream issue opened: https://github.com/squizlabs/PHP_CodeSniffer/issues/1068

Rebased to force a travis check against the new WPCS codestyle rules.

Renamed the sniff as per https://github.com/WordPress-Coding-Standards/WordPress-Coding-Standards/pull/596#issuecomment-232587368

Got a positive response regarding this sniff upstream: https://github.com/squizlabs/PHP_CodeSniffer/issues/1068
PR has been opened: https://github.com/squizlabs/PHP_CodeSniffer/pull/1070

Anything that would still need to change for this to be mergeable ?
How do we move forward on this ?
Wait for upstream ? May take quite a while as it looks like they're currently focused on PHPCS 3 and not merging things for 2.
Merge it and remove when it would be merged upstream and the WPCS minimum PHPCS version has caught up ?

Merge it and remove when it would be merged upstream and the WPCS minimum PHPCS version has caught up ?

+1. I'd like to see a couple of tests added though, like:
class A_Class_With_Really_Long_Name
    extends Another_Class_With_A_Really_Long_Name {

}

class A_Class_With_Really_Long_Name_2
    extends Another_Class_With_A_Really_Long_Name
    implements Some_Interface_With_A_Long_Name,
          Another_Interface_With_A_Long_Name {

}

I'd like to see a couple of tests added though, like:

@JDGrimes I'll add these tests. I'm in doubt about what the sniff should say about these though as the sniff is really only about the brace. Should it give an error because the brace is not on the same line as the class keyword or should these be passed as ok as the brace is on the same line as the last part of the class opening statement ?
Please advise.

should these be passed as ok as the brace is on the same line as the last part of the class opening statement ?

Yes. Sorry I wasn't clear.
I think this is the correct behavior because AFAIK WordPress doesn't really address the issue of wrapping here, so it should be permitted. Especially because I do it. 😈

Yes, wrapping should be allowed. Though not explicit, line-length suggestions would come into play here.

I think this is the correct behavior because AFAIK WordPress doesn't really address the issue of wrapping here, so it should be permitted.

Makes sense to me, though this will involve a rewrite of the part of the sniff which checks this.

Ok, sorted. Unit tests added and minor code fix to allow for multi-line class declarations.

FYI: Upstream PR (including the last change) has just been merged, but - similar to the other PR - is not in a released version yet and when it is, the WPCS PHPCS minimum version requirement would need to be upped.
So I suggest merging this for now and removing it again at a later point in time.


FutureWarning: The warn_bad_lines argument has been deprecated

FutureWarning: The warn_bad_lines argument has been deprecated

Thanks, this is now finally fixed


Crash in overdecomposition use case with tracing, without DCR or index launches

This is in a branch based on control_replication commit e7e51ed1e22f51c8c616f926eefbebd17ddabcf7. I'm not 100% sure which variables matter, but here's what I know so far:

It replicates in a configuration with tracing, but without DCR or index launches
It does NOT replicate in the same configuration with index launches
As compared to other configurations I have run, this one is notable in that I enabled overdecomposition (10x as many tasks as GPUs)
It occurs starting at 4 nodes on Piz Daint

The relevant part of the backtrace looks like:
[2] Thread 8 (Thread 0x2aaaaac3c800 (LWP 29038) "circuit.noidx"):
[2] #0  0x00002aaaaf349217 in waitpid () from /lib64/libc.so.6
[2] #1  0x00002aaaaf2c676f in do_system () from /lib64/libc.so.6
[2] #2  0x00002aaaaccdd4bb in gasneti_bt_gdb () from /users/eslaught/regent-index-launch-sc21/language/circuit.run2_overdecompose_debug_2/libregent.so
[2] #3  0x00002aaaacce0dca in gasneti_print_backtrace () from /users/eslaught/regent-index-launch-sc21/language/circuit.run2_overdecompose_debug_2/libregent.so
[2] #4  0x00002aaaabf92979 in gasneti_defaultSignalHandler () from /users/eslaught/regent-index-launch-sc21/language/circuit.run2_overdecompose_debug_2/libregent.so
[2] #5  <signal handler called>
[2] #6  0x00002aaaac1d3645 in Legion::Internal::RegionTreePath::register_child (this=this@entry=0x2aab4024b4c8, depth=4294967295, color=33) at /users/eslaught/regent-index-launch-sc21/runtime/legion/legion_analysis.cc:19418
[2] #7  0x00002aaaac28b038 in Legion::Internal::RegionTreeForest::initialize_path (this=<optimized out>, child=0x2aab3cc88640, parent=0x2aab3cc81b80, path=...) at /users/eslaught/regent-index-launch-sc21/runtime/legion/region_tree.cc:5634
[2] #8  0x00002aaaac055a11 in Legion::Internal::VirtualCloseOp::initialize (this=this@entry=0x2aab4024b140, ctx=ctx@entry=0x2aab34a5b150, index=index@entry=1, req=..., target=0x2aab3440b560) at /users/eslaught/regent-index-launch-sc21/runtime/legion/legion_ops.cc:10212
[2] #9  0x00002aaaac11db5e in Legion::Internal::InnerContext::end_task (this=0x2aab34a5b150, res=<optimized out>, res_size=<optimized out>, owned=<optimized out>, deferred_result_instance=..., callback_functor=<optimized out>, result_kind=<optimized out>, freefunc=<optimized out>, metadataptr=<optimized out>, metadatasize=<optimized out>) at /users/eslaught/regent-index-launch-sc21/runtime/legion/legion_context.cc:10440
[2] #10 0x00002aaaac003884 in legion_task_postamble (runtime_=..., ctx_=..., retval=0x0, retsize=0) at /users/eslaught/regent-index-launch-sc21/runtime/legion/legion_c.cc:7727
[2] #11 0x000000000040d5ad in $__regent_task_init_piece_primary ()
[2] #12 0x00002aaaac820e51 in Realm::LocalTaskProcessor::execute_task (this=0x1613000, func_id=27, task_args=...) at /users/eslaught/regent-index-launch-sc21/runtime/realm/bytearray.inl:58
[2] #13 0x00002aaaac7165c3 in Realm::Task::execute_on_processor (this=0x2aab280ba950, p=...) at /users/eslaught/regent-index-launch-sc21/runtime/realm/tasks.cc:306
[2] #14 0x00002aaaac716656 in Realm::UserThreadTaskScheduler::execute_task (this=<optimized out>, task=<optimized out>) at /users/eslaught/regent-index-launch-sc21/runtime/realm/tasks.cc:1646
[2] #15 0x00002aaaac718cc9 in Realm::ThreadedTaskScheduler::scheduler_loop (this=0x10dc890) at /users/eslaught/regent-index-launch-sc21/runtime/realm/tasks.cc:1127
[2] #16 0x00002aaaac6feb3f in Realm::UserThread::uthread_entry () at /users/eslaught/regent-index-launch-sc21/runtime/realm/threads.cc:1337
[2] #17 0x00002aaaaf2ceca0 in ?? () from /lib64/libc.so.6
[2] #18 0x0000000000000000 in ?? ()

Reproduction Steps on Sapling
Copy my files:
cp -r /scratch2/eslaught/regent-index-launch-sc21 .
cd regent-index-launch-sc21
git stash
git reset --hard ec153e7d6da2cdeed0da69f5e8bb4bbe7b09e23b
git stash pop

Build:
salloc -N 1 -n 1 -p gpu --exclusive
srun --pty bash --login
./sc21_scripts/build_circuit.sh circuit.run_dir

Run:
cd circuit.run_dir
salloc -N 4 -n 4 -p gpu --exclusive
mpirun -n 4 -npernode 1 -bind-to none -x LD_LIBRARY_PATH=$PWD -x REALM_BACKTRACE=1 ./circuit.noidx -npp 500 -wpp 2000 -l 50 -p $(( 4 * 10 )) -pps 1 -prune 10 -hl:sched 1024 -ll:gpu 1 -ll:util 2 -ll:bgwork 2 -ll:csize 15000 -ll:fsize 15000 -ll:zsize 2048 -ll:rsize 512 -ll:gsize 0 -dm:replicate 0 -dm:memoize -lg:no_fence_elision -lg:parallel_replay 2

Note that this command reproduces only about 50% of the time.

@elliottslaughter Pull control replication and see if you can still reproduce this.

Fixed. Thanks!


Dependency on opencv-python

In the pyproject.toml there is a dependency on opencv-python, which has an unfortunate set of consequences when you install this library with another application that needs opencv-python-headless.
This issue is documented here: https://github.com/opencv/opencv-python/issues/467
This is something I've mentioned to the mmcv team, although it looks like they haven't seen or reviewed: https://github.com/open-mmlab/mmcv/pull/2775
The workaround that I've used to address this problem is by adding both opencv-python and opencv-python-headless as different "extras" dependencies. This means the user is forced to use either: pip install nrtk[headless] or pip install nrtk[graphics], which is annoying, but an import-time message can help with any confusion caused by this, and I can't think of a better way.
This issue is also present in a second dependency https://github.com/Kitware/pyBSM which I found by running: johnnydep nrtk

nrtk                                                  An open source toolkit for evaluating the natural robustness of computer vision algorithms.
├── Pillow>=10.3.0                                    Python Imaging Library (Fork)
├── numpy<2.0,>=1.25                                  Fundamental package for array computing in Python
├── opencv-python>=4.6                                Wrapper package for OpenCV python bindings.
│   ├── numpy>=1.17.0                                 Fundamental package for array computing in Python
│   ├── numpy>=1.17.3                                 Fundamental package for array computing in Python
│   ├── numpy>=1.19.3                                 Fundamental package for array computing in Python
│   ├── numpy>=1.21.2                                 Fundamental package for array computing in Python
│   └── numpy>=1.23.5                                 Fundamental package for array computing in Python
├── pybsm>=0.5.1                                      pyBSM is a Python-based tool for sensor modeling. It provides common components useful for simulating the image formation process through different imaging systems.
│   ├── matplotlib>=3.5.2                             Python plotting package
│   │   ├── contourpy>=1.0.1                          Python library for calculating contours of 2D quadrilateral grids
│   │   │   └── numpy>=1.20                           Fundamental package for array computing in Python
│   │   ├── cycler>=0.10                              Composable style cycles
│   │   ├── fonttools>=4.22.0                         Tools to manipulate font files
│   │   ├── kiwisolver>=1.3.1                         A fast implementation of the Cassowary constraint solver
│   │   ├── numpy>=1.23                               Fundamental package for array computing in Python
│   │   ├── packaging>=20.0                           Core utilities for Python packages
│   │   ├── pillow>=8                                 Python Imaging Library (Fork)
│   │   ├── pyparsing>=2.3.1                          pyparsing module - Classes and methods to define and execute parsing grammars
│   │   └── python-dateutil>=2.7                      Extensions to the standard Python datetime module
│   │       └── six>=1.5                              Python 2 and 3 compatibility utilities
│   ├── numpy<2.0,>=1.25                              Fundamental package for array computing in Python
│   ├── opencv-python>=4.6                            Wrapper package for OpenCV python bindings.
│   │   ├── numpy>=1.17.0                             Fundamental package for array computing in Python
│   │   ├── numpy>=1.17.3                             Fundamental package for array computing in Python
│   │   ├── numpy>=1.19.3                             Fundamental package for array computing in Python
│   │   ├── numpy>=1.21.2                             Fundamental package for array computing in Python
│   │   └── numpy>=1.23.5                             Fundamental package for array computing in Python
│   ├── scipy<1.14,>=1.10.0                           Fundamental algorithms for scientific computing in Python
│   │   └── numpy<2.3,>=1.22.4                        Fundamental package for array computing in Python
│   └── setuptools>=65.6.1                            Easily download, build, install, upgrade, and uninstall Python packages
├── pycocotools>=2.0.6                                Official APIs for the MS-COCO dataset
│   ├── matplotlib>=2.1.0                             Python plotting package
│   │   ├── contourpy>=1.0.1                          Python library for calculating contours of 2D quadrilateral grids
│   │   │   └── numpy>=1.20                           Fundamental package for array computing in Python
│   │   ├── cycler>=0.10                              Composable style cycles
│   │   ├── fonttools>=4.22.0                         Tools to manipulate font files
│   │   ├── kiwisolver>=1.3.1                         A fast implementation of the Cassowary constraint solver
│   │   ├── numpy>=1.23                               Fundamental package for array computing in Python
│   │   ├── packaging>=20.0                           Core utilities for Python packages
│   │   ├── pillow>=8                                 Python Imaging Library (Fork)
│   │   ├── pyparsing>=2.3.1                          pyparsing module - Classes and methods to define and execute parsing grammars
│   │   └── python-dateutil>=2.7                      Extensions to the standard Python datetime module
│   │       └── six>=1.5                              Python 2 and 3 compatibility utilities
│   └── numpy                                         Fundamental package for array computing in Python
├── scikit-image<0.22,>=0.21                          Image processing in Python
│   ├── PyWavelets>=1.1.1                             PyWavelets, wavelet transform module
│   │   └── numpy<3,>=1.22.4                          Fundamental package for array computing in Python
│   ├── imageio>=2.27                                 Library for reading and writing a wide range of image, video, scientific, and volumetric data formats.
│   │   ├── numpy                                     Fundamental package for array computing in Python
│   │   └── pillow>=8.3.2                             Python Imaging Library (Fork)
│   ├── lazy_loader>=0.2                              Makes it easy to load subpackages and functions on demand.
│   │   └── packaging                                 Core utilities for Python packages
│   ├── networkx>=2.8                                 Python package for creating and manipulating graphs and networks
│   ├── numpy>=1.21.1                                 Fundamental package for array computing in Python
│   ├── packaging>=21                                 Core utilities for Python packages
│   ├── pillow>=9.0.1                                 Python Imaging Library (Fork)
│   ├── scipy>=1.8                                    Fundamental algorithms for scientific computing in Python
│   │   └── numpy<2.3,>=1.23.5                        Fundamental package for array computing in Python
│   └── tifffile>=2022.8.12                           Read and write TIFF files
│       └── numpy                                     Fundamental package for array computing in Python
├── setuptools>=65.6.1                                Easily download, build, install, upgrade, and uninstall Python packages
├── smqtk-classifier>=0.19.0                          Algorithms, data structures and utilities around performing classificationof inputs.
│   ├── numpy<2.0.0,>=1.19.5                          Fundamental package for array computing in Python
│   ├── smqtk-core>=0.18.0                            Python toolkit for pluggable algorithms and data structures for multimedia-based machine learning.
│   ├── smqtk-dataprovider>=0.16.0                    SMQTK Data provision abstractions and implementations
│   │   ├── numpy>=1.23.5                             Fundamental package for array computing in Python
│   │   ├── requests>=2.28.1                          Python HTTP for Humans.
│   │   │   ├── certifi>=2017.4.17                    Python package for providing Mozilla's CA Bundle.
│   │   │   ├── charset-normalizer<4,>=2              The Real First Universal Charset Detector. Open, modern and actively maintained alternative to Chardet.
│   │   │   ├── idna<4,>=2.5                          Internationalized Domain Names in Applications (IDNA)
│   │   │   └── urllib3<3,>=1.21.1                    HTTP library with thread-safe connection pooling, file post, and more.
│   │   └── smqtk-core>=0.19                          Python toolkit for pluggable algorithms and data structures for multimedia-based machine learning.
│   └── smqtk-descriptors>=0.18                       Algorithms, data structures and utilities around computingdescriptor vectors from data.
│       ├── numpy>=1.19.5                             Fundamental package for array computing in Python
│       ├── smqtk-core>=0.18.0                        Python toolkit for pluggable algorithms and data structures for multimedia-based machine learning.
│       ├── smqtk-dataprovider>=0.16.0                SMQTK Data provision abstractions and implementations
│       │   ├── numpy>=1.23.5                         Fundamental package for array computing in Python
│       │   ├── requests>=2.28.1                      Python HTTP for Humans.
│       │   │   ├── certifi>=2017.4.17                Python package for providing Mozilla's CA Bundle.
│       │   │   ├── charset-normalizer<4,>=2          The Real First Universal Charset Detector. Open, modern and actively maintained alternative to Chardet.
│       │   │   ├── idna<4,>=2.5                      Internationalized Domain Names in Applications (IDNA)
│       │   │   └── urllib3<3,>=1.21.1                HTTP library with thread-safe connection pooling, file post, and more.
│       │   └── smqtk-core>=0.19                      Python toolkit for pluggable algorithms and data structures for multimedia-based machine learning.
│       └── smqtk-image-io>=0.17.0                    SMQTK Image IO
│           ├── numpy>=1.21                           Fundamental package for array computing in Python
│           ├── pillow>=8.2.0                         Python Imaging Library (Fork)
│           ├── smqtk-core>=0.19                      Python toolkit for pluggable algorithms and data structures for multimedia-based machine learning.
│           └── smqtk-dataprovider>=0.16.0            SMQTK Data provision abstractions and implementations
│               ├── numpy>=1.23.5                     Fundamental package for array computing in Python
│               ├── requests>=2.28.1                  Python HTTP for Humans.
│               │   ├── certifi>=2017.4.17            Python package for providing Mozilla's CA Bundle.
│               │   ├── charset-normalizer<4,>=2      The Real First Universal Charset Detector. Open, modern and actively maintained alternative to Chardet.
│               │   ├── idna<4,>=2.5                  Internationalized Domain Names in Applications (IDNA)
│               │   └── urllib3<3,>=1.21.1            HTTP library with thread-safe connection pooling, file post, and more.
│               └── smqtk-core>=0.19                  Python toolkit for pluggable algorithms and data structures for multimedia-based machine learning.
├── smqtk-core>=0.19                                  Python toolkit for pluggable algorithms and data structures for multimedia-based machine learning.
├── smqtk-detection>=0.19.0                           Algorithms, data structures and utilities around performing detection of inputs
│   ├── smqtk-classifier>=0.19.0                      Algorithms, data structures and utilities around performing classificationof inputs.
│   │   ├── numpy<2.0.0,>=1.19.5                      Fundamental package for array computing in Python
│   │   ├── smqtk-core>=0.18.0                        Python toolkit for pluggable algorithms and data structures for multimedia-based machine learning.
│   │   ├── smqtk-dataprovider>=0.16.0                SMQTK Data provision abstractions and implementations
│   │   │   ├── numpy>=1.23.5                         Fundamental package for array computing in Python
│   │   │   ├── requests>=2.28.1                      Python HTTP for Humans.
│   │   │   │   ├── certifi>=2017.4.17                Python package for providing Mozilla's CA Bundle.
│   │   │   │   ├── charset-normalizer<4,>=2          The Real First Universal Charset Detector. Open, modern and actively maintained alternative to Chardet.
│   │   │   │   ├── idna<4,>=2.5                      Internationalized Domain Names in Applications (IDNA)
│   │   │   │   └── urllib3<3,>=1.21.1                HTTP library with thread-safe connection pooling, file post, and more.
│   │   │   └── smqtk-core>=0.19                      Python toolkit for pluggable algorithms and data structures for multimedia-based machine learning.
│   │   └── smqtk-descriptors>=0.18                   Algorithms, data structures and utilities around computingdescriptor vectors from data.
│   │       ├── numpy>=1.19.5                         Fundamental package for array computing in Python
│   │       ├── smqtk-core>=0.18.0                    Python toolkit for pluggable algorithms and data structures for multimedia-based machine learning.
│   │       ├── smqtk-dataprovider>=0.16.0            SMQTK Data provision abstractions and implementations
│   │       │   ├── numpy>=1.23.5                     Fundamental package for array computing in Python
│   │       │   ├── requests>=2.28.1                  Python HTTP for Humans.
│   │       │   │   ├── certifi>=2017.4.17            Python package for providing Mozilla's CA Bundle.
│   │       │   │   ├── charset-normalizer<4,>=2      The Real First Universal Charset Detector. Open, modern and actively maintained alternative to Chardet.
│   │       │   │   ├── idna<4,>=2.5                  Internationalized Domain Names in Applications (IDNA)
│   │       │   │   └── urllib3<3,>=1.21.1            HTTP library with thread-safe connection pooling, file post, and more.
│   │       │   └── smqtk-core>=0.19                  Python toolkit for pluggable algorithms and data structures for multimedia-based machine learning.
│   │       └── smqtk-image-io>=0.17.0                SMQTK Image IO
│   │           ├── numpy>=1.21                       Fundamental package for array computing in Python
│   │           ├── pillow>=8.2.0                     Python Imaging Library (Fork)
│   │           ├── smqtk-core>=0.19                  Python toolkit for pluggable algorithms and data structures for multimedia-based machine learning.
│   │           └── smqtk-dataprovider>=0.16.0        SMQTK Data provision abstractions and implementations
│   │               ├── numpy>=1.23.5                 Fundamental package for array computing in Python
│   │               ├── requests>=2.28.1              Python HTTP for Humans.
│   │               │   ├── certifi>=2017.4.17        Python package for providing Mozilla's CA Bundle.
│   │               │   ├── charset-normalizer<4,>=2  The Real First Universal Charset Detector. Open, modern and actively maintained alternative to Chardet.
│   │               │   ├── idna<4,>=2.5              Internationalized Domain Names in Applications (IDNA)
│   │               │   └── urllib3<3,>=1.21.1        HTTP library with thread-safe connection pooling, file post, and more.
│   │               └── smqtk-core>=0.19              Python toolkit for pluggable algorithms and data structures for multimedia-based machine learning.
│   ├── smqtk-core>=0.18.0                            Python toolkit for pluggable algorithms and data structures for multimedia-based machine learning.
│   ├── smqtk-dataprovider>=0.16.0                    SMQTK Data provision abstractions and implementations
│   │   ├── numpy>=1.23.5                             Fundamental package for array computing in Python
│   │   ├── requests>=2.28.1                          Python HTTP for Humans.
│   │   │   ├── certifi>=2017.4.17                    Python package for providing Mozilla's CA Bundle.
│   │   │   ├── charset-normalizer<4,>=2              The Real First Universal Charset Detector. Open, modern and actively maintained alternative to Chardet.
│   │   │   ├── idna<4,>=2.5                          Internationalized Domain Names in Applications (IDNA)
│   │   │   └── urllib3<3,>=1.21.1                    HTTP library with thread-safe connection pooling, file post, and more.
│   │   └── smqtk-core>=0.19                          Python toolkit for pluggable algorithms and data structures for multimedia-based machine learning.
│   └── smqtk-image-io>=0.17.0                        SMQTK Image IO
│       ├── numpy>=1.21                               Fundamental package for array computing in Python
│       ├── pillow>=8.2.0                             Python Imaging Library (Fork)
│       ├── smqtk-core>=0.19                          Python toolkit for pluggable algorithms and data structures for multimedia-based machine learning.
│       └── smqtk-dataprovider>=0.16.0                SMQTK Data provision abstractions and implementations
│           ├── numpy>=1.23.5                         Fundamental package for array computing in Python
│           ├── requests>=2.28.1                      Python HTTP for Humans.
│           │   ├── certifi>=2017.4.17                Python package for providing Mozilla's CA Bundle.
│           │   ├── charset-normalizer<4,>=2          The Real First Universal Charset Detector. Open, modern and actively maintained alternative to Chardet.
│           │   ├── idna<4,>=2.5                      Internationalized Domain Names in Applications (IDNA)
│           │   └── urllib3<3,>=1.21.1                HTTP library with thread-safe connection pooling, file post, and more.
│           └── smqtk-core>=0.19                      Python toolkit for pluggable algorithms and data structures for multimedia-based machine learning.
├── smqtk-image-io>=0.17.1                            SMQTK Image IO
│   ├── numpy>=1.21                                   Fundamental package for array computing in Python
│   ├── pillow>=8.2.0                                 Python Imaging Library (Fork)
│   ├── smqtk-core>=0.19                              Python toolkit for pluggable algorithms and data structures for multimedia-based machine learning.
│   └── smqtk-dataprovider>=0.16.0                    SMQTK Data provision abstractions and implementations
│       ├── numpy>=1.23.5                             Fundamental package for array computing in Python
│       ├── requests>=2.28.1                          Python HTTP for Humans.
│       │   ├── certifi>=2017.4.17                    Python package for providing Mozilla's CA Bundle.
│       │   ├── charset-normalizer<4,>=2              The Real First Universal Charset Detector. Open, modern and actively maintained alternative to Chardet.
│       │   ├── idna<4,>=2.5                          Internationalized Domain Names in Applications (IDNA)
│       │   └── urllib3<3,>=1.21.1                    HTTP library with thread-safe connection pooling, file post, and more.
│       └── smqtk-core>=0.19                          Python toolkit for pluggable algorithms and data structures for multimedia-based machine learning.
└── tqdm>=4.64                                        Fast, Extensible Progress Meter

So it will need to be fixed there first. I will post an issue there as well.

The fix should be in now as of this commit, and was released in pybsm==0.12.0. Closing the Issue, please re-open if the issue persists.


"volar.inlayHints.eventArgumentInInlineHandlers" height style

$event =>  is hiding the underlining of the line above (those green dots are generated by UnoCSS).

"workbench.colorCustomizations": {
    "editorInlayHint.parameterBackground": "#00000000",
},

You can add it to settings.json to bring back the original transparent background for InlayHint parameter .


Minor fix

Pull Request Test Coverage Report for Build 3061

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.1%) to 66.15%

Totals

Change from base Build 3060:
0.1%

Covered Lines:
6885

Relevant Lines:
9768

💛  - Coveralls


[apptools-android] Add tests to test manifest extension for apptools android

Failure analysis:
https://crosswalk-project.org/jira/browse/XWALK-5237
Impacted tests(approved): new 1, update 0, delete 0
Unit test platform: [Android]
Unit test result summary: pass 0, fail 1, block 0
https://crosswalk-project.org/jira/browse/XWALK-4021

Incorrect summary, please update it.

LGTM


UnicodeDecodeError when uploading node scripts on Ubuntu in Docker

When running AZTK client in Ubuntu 16.04 in Docker I get this error when creating the cluster:
|Traceback (most recent call last):
  File "/mnt/mesos/sandbox/sandbox/.virtualenvs/aztk/bin/aztk", line 11, in <module>
    load_entry_point('aztk', 'console_scripts', 'aztk')()
  File "/opt/aztk/aztk_cli/entrypoint.py", line 35, in main
    run_software(args)
  File "/opt/aztk/aztk_cli/entrypoint.py", line 63, in run_software
    func(args)
  File "/opt/aztk/aztk_cli/spark/endpoints/spark.py", line 31, in execute
    func(args)
  File "/opt/aztk/aztk_cli/spark/endpoints/cluster/cluster.py", line 81, in execute
    func(args)
  File "/opt/aztk/aztk_cli/spark/endpoints/cluster/cluster_create.py", line 79, in execute
    wait=wait
  File "/opt/aztk/aztk/spark/client.py", line 29, in create_cluster
    node_data = NodeData(cluster_conf).add_core().done()
  File "/opt/aztk/aztk/internal/cluster_data/node_data.py", line 34, in add_core
    self._add_node_scripts()
  File "/opt/aztk/aztk/internal/cluster_data/node_data.py", line 158, in _add_node_scripts
    self.add_dir(os.path.join(ROOT_PATH, NODE_SCRIPT_FOLDER), exclude=['*.pyc'])
  File "/opt/aztk/aztk/internal/cluster_data/node_data.py", line 75, in add_dir
    self.zipf.writestr(os.path.join(relative_folder, file), f.read().replace('\r\n', '\n'))
  File "/mnt/mesos/sandbox/sandbox/.virtualenvs/aztk/lib/python3.6/encodings/ascii.py", line 26, in decode
    return codecs.ascii_decode(input, self.errors)[0]
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc2 in position 2818: ordinal not in range(128)

This seems to come from the fact that files are open with default encoding:
https://github.com/Azure/aztk/blob/2bed496c398c7c3860ad62b1ce7d9fc14ee299bb/aztk/internal/cluster_data/node_data.py#L74
It should be like this:
with io.open(os.path.join(base, file), 'r', encoding='UTF-8') as f:

The same issue occurs in other places where files are open.
There's a good discussion here on why encoding should always be specified when opening files:
https://github.com/docker-library/python/pull/5#issuecomment-50556812
Meanwhile, the workaround is to set default encoding to UTF-8:
export LANG=C.UTF-8

Thanks for the tip!


SelectableText.rich Widget can not select a whole line text with textAlign is justify

Steps to Reproduce

when textAlign is default or TextAlign.start is OK

when textAlign is TextAlign.justify is unexpected

CC @chunhtai

@BayMikyou
I cannot reproduce this issue. Here is my code
import 'package:flutter/material.dart';

void main() => runApp(MyApp());

class MyApp extends StatelessWidget {
  // This widget is the root of your application.
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      home: MyHomePage(title: 'test',));
  }
}

class MyHomePage extends StatefulWidget {
  MyHomePage({Key key, this.title}) : super(key: key);

  final String title;

  @override
  _MyHomePageState createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  int _counter = 0;

  void _incrementCounter() {
    setState(() {
      _counter++;
    });
  }

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text(widget.title),
      ),
      body: Center(
        child: Column(
          mainAxisAlignment: MainAxisAlignment.center,
          children: <Widget>[
            SelectableText.rich(
              TextSpan(
          text: 'This class is the configurationforthestate.Itholdsthevalues(inthiscasethetitle)providedbytheparent(inthis case the App widget) and used by the build method of the State. Fields in a Widget subclass arealways marked "final".',
              ),
              textAlign: TextAlign.justify,
            ),
            Text(
              '$_counter',
              style: Theme.of(context).textTheme.display1,
            ),
          ],
        ),
      ),
      floatingActionButton: FloatingActionButton(
        onPressed: _incrementCounter,
        tooltip: 'Increment',
        child: Icon(Icons.add),
      ), // This trailing comma makes auto-formatting nicer for build methods.
    );
  }
}

Can you share a minimum reproducible example?

Hi @BayMikyou
Are you still experiencing this issue with latest stable?
if yes, can you please provide your flutter doctor -v and flutter run --verbose?
Also, to better address the issue, would be helpful if you could post a minimal code sample to reproduce the problem
Thank you

Without additional information we are unfortunately not sure how to resolve this issue.
We are therefore reluctantly going to close this bug for now.
Please don't hesitate to comment on the bug if you have any more information for us; we will reopen it right away!
Thanks for your contribution.
Could everyone who still has this problem please file a new issue with the exact description of what happens, logs and the output of flutter doctor -v.
All system setups can be slightly different, so it's always better to open new issues and reference related issues.


[CPI] Split logic for Project and Domain ID, bsc#1103873

I've tested it and works fine as we expected


Do I want log2ram on the workers?

ATM, log2ram is only installed on the leader, to improve the lifetime of the SD card - makes sense to use it else where, too?

Yes


Permission issue for 1.4.0

It seems release 1.4.0 have different permission for file PKG-INFO with previous releases. See here for more details.

This doesn't seem to be an absl-py's own issue.
https://bugs.archlinux.org/task/77988 is duplicated to https://bugs.archlinux.org/task/77983, which is already marked as fixed.


[BUG/DOC] Fetching caffe.proto from caffe master

Is this what we want? I would personally prefer fetching from a known commit hash
cc @eickenberg - opinions?

yeah I agree with you, feel free to change.
But hadn't you decided to ship caffe.proto ? I can't remember now.


Setting Window Icon to High Resolution texture

If the texture is above the resolution 256px then there's a StackOverflow error. Might be nice if you let the coder know the maximum size it can take in and give a cleaner error, or instead automatically lowering the input image's res before passing it to the provider.

good catch. i'll add this to my todo list. Not sure which approach i'm going to take yet though

i managed to fix the stack overflow, and some other issues in the process. see 72f71a0


Fix mecab-python3 version

Hello, I am the maintainer of mecab-python3. Users of your library have been opening issues at my repo because they have trouble building MeCab. They should not have to build MeCab, but MeloTTS is using an old version of mecab-python3 that doesn't support recent Python versions. This raises the version. There are no functionality changes.

This also removes the double entry noted in #150.

ref: https://github.com/bolna-ai/bolna/issues/305

Also see #51 - mecab-python3 should be optional in this library, since not everyone is using Japanese.


[stdlib] use internal assertion functions in the Concurrency module

This PR changes the assertion functions used in the Concurrency module to use the internal equivalents.
The advantages are that they're slightly more performant (they use StaticString) and, more importantly,
they map better to the notion of "debug mode" and "release mode" expected by user code.

Resolves rdar://66301232 ("The core stdlib uses the public func precondition in some places").

@phausler I switched from assert to _internalInvariant in Deque.swift, but do you think it would be better to use _debugPrecondition instead? _internalInvariant only asserts in debug builds of the standard library, whereas _debugPrecondition asserts in debug builds of user code using release builds of the standard library.

Note: the stdlib-internal assertions cannot be called from the Concurrency module, so this approach is a failure.
I should not have pushed before my local compilation had completed.


Modify the masses

... To allow to compute the spectra partially.

On the principle, it works, but for that, one needs to use optimized structures :p


Missing function on context

https://github.com/yahoo/flux-router-component/blob/master/actions/navigate.js#L21
Where is context.getAction coming from?
It feels this is written for something that no one else can see a use-case for, not even in the example app where most of the context magic comes from lib/Context.js

Sorta related, any thoughts on having an action plugin that lets you register a bunch of actions by name and then invoking them with just the name? It looks like that's the original intent for this issue, but since it's not in fluxible I'm wondering if you guys might've moved away from using this approach. If you did chose to move away from doing this, can you share some of the reasons why?


Utility command for running pg_dump from postgres container

Feature request
I frequently have issues with having version mismatches between my local version of postgres and the version of postgres on the database I'm trying to run pg_dump from. It would be cool if there was a utility CLI command that could run pg_dump from the Supabase service itself. Something like supabase database dump, maybe with some options for pointing to different databases (eg: database running at supabase.com).

Hi @mclean25, I'm going to link this issue to https://github.com/supabase/cli/issues/389 since we plan to address the mismatched postgres version issue soon.
Regarding pg_dump, we currently have a command db remote commit that dumps schema from the linked project. It uses pg_dump internally the first time it is run. Do you need to run pg_dump more frequently? It would be great if you could clarify this use case more for prioritisation.

We have added supabase db dump command to address this use case.


Revert "Bratseth/pack bits"

Reverts vespa-engine/vespa#32537
Suspecting that this broke a few system tests.

Thanks. Not unlikely ...


switch file monitor from :fs to :file_system

let's keep discussing the file monitor under issue #53

Thank you! Right now both Chris and I are busy with releases, we will review this after Phoenix v1.3 is out. :heart:


raftstore: optimize AutoSplitController memory usage

What is changed and how it works?

Issue Number: ref #16653

What's Changed:
raftstore: optimize AutoSplitController memory usage

* Replaced unbounded channels with bounded channels to prevent unexpected
  memory buildup when AutoSplitController runs slowly.
* Implemented reusability of temporary vectors and maps during CPU stats
  handling to reduce memory allocation and deallocation overhead, saving
  about 10% CPU.

Tests shows that it saves about 10% CPU, and memory usage is much stable.

Header
2024-03-20 nightly
With this PR

CPU

Memory*
  OOM frequently

The memory test is conducted with PR #16662.
Check List
Tests

Unit test

Release note

None

/merge


Bump to BUCK v2<IP_ADDRESS>

Bumps CI to latest BUCK release.
Test Plan
Run on Circle CI.
Release Notes
[INTERNAL] [MINOR] [Tests] - Bump to BUCK v2<IP_ADDRESS>

Landing.