[Suggestion] Automate checking versions without extra work on other modders

So it has begun where people are now poking me to add support for Notify lol

However, from my understanding of this mod, I have to make a json file and manually edit it every time I update to make notify work. The issue is, I will forget to do this extra step every single time I update lol. It's not going to work out well for me.
So I got two suggestion that could work. One being to use the URL listed in the homepage section of the fabric.mod.json which the majority of mods have and then check that curseforge or modrinth page for if a newer version was posted than the current version on. This would sue the modrinth/curseforge api of course from the given URL. Example: https://github.com/TelepathicGrunt/Blame/blob/962d40a0d692c1716ccaef1c3368b66968dcf489/src/main/resources/fabric.mod.json#L12
A second idea that could be done is the custom json is formatted like this instead:
"custom": {
    "notify_version_url": "https://github.com/TelepathicGrunt/Blame/blob/Fabric-1.17.x/gradle.properties"
    "notify_version_key": "mod_version"
}

Then it parses the gradle.properties file linked for the key and read it's version to see if it is newer. Of course, that second way only works if the modder changes the mod_version only when they release an update.
Basically, I would be totally fine doing compat with your mod as long as it is a do-once-and-forget kind of thing instead of having an extra file I have to edit every update. Or did I misunderstand how this mod works?

Yes, I was planning on adding support for the MR/CF APIs at some point. I also like the gradle.properties idea. so perhaps I could support both. I was aware when I was making it that this would be an issue, but I hope that if it gets fixed it should be a viable mod

I've done the inital work for this, it's still a bit iffy reliability wise with Modrinth because I'm just getting the absolute latest version, not specifying Minecraft, but I'll fix that. CurseForge isn't supported yet because....I didn't want to deal with that yet. I would say the gradle.properties method is the best at the moment


Tag templating

Description
What problem are you trying to solve?
I would like to be able to use go templates to generate dynamic AWS tags for the EC2 instances generated by karpenter, e.g:
---
apiVersion: karpenter.k8s.aws/v1
kind: EC2NodeClass
metadata:
  name: al2023-default
spec:
  # Required, resolves a default ami and userdata
  amiFamily: AL2023
  amiSelectorTerms:
  - alias: al2023@v20241121

  ...

  # Optional, propagates tags to underlying EC2 resources
  tags:
    Name: eks.amazonaws.com/{{ .ClusterName }}/{{ .EC2NodeClassName }}

How important is this feature to you?
Nice to have.

Can you template this at the level above the NodeClass? I'm curious if rather than us supporting templating directly in our spec, if you can use something like Helm/Kustomize with GitOps to auto-template this out for you so the resultant manifests just have hard data.
In general, I think it's pretty abnormal to see templated values in K8s resources that are directly applied to the cluster.

In general, I think it's pretty abnormal to see templated values in K8s resources that are directly applied to the cluster.

When the Kubernetes project does templating, it's usually CEL. But: I agree, doing this at a level above NodePool / node class is the right approach.


nuxt-link does not work in transition-group

Reproduction link
https://github.com/nuxt-community/nuxt-i18n
Steps to reproduce

Install nuxt
Install and configure nuxt-i18n
Place nuxt-link in transition group with or without localePath()

nuxt.config.js
module.exports = {
  mode: 'universal',
  modules: [
    ['nuxt-i18n', {
      locales: [
        { code: 'en' },
        { code: 'fr' },
        { code: 'es' }
      ],
      defaultLocale: 'en',
      vueI18n: {
        fallbackLocale: 'en',
        messages: {
          en: {
            welcome: 'Welcome'
          },
          fr: {
            welcome: 'Bienvenue'
          },
          es: {
            welcome: 'Bienvenido'
          }
        }
      }
    }]
  ]
}

index.vue
<template>
  <div>
    <transition-group>
      <nuxt-link
        v-for="i in 3"
        :key="i"
        to="/new">
      New
      </nuxt-link>
    </transition-group>
  </div>
</template>

What is expected ?
Route transition
What is actually happening?
children is undefined

This bug report is available on Nuxt.js community (#c66)

Hi @alexkcollier
I'm currently unable to reproduce the issue on a fresh install. What versions of Nuxt and nuxt-i18n are you using? What's in your pages directory?
It would really help if you could provide a sample project with the issue.
At first glance, I'm not sure this has anything to do with <transition-group> and I don't see how it could be related to nuxt-i18n either, so I'll need more details on this!
Thanks!

I've tested with nuxt 1.0.0 and 1.4.0 with nuxt-i18n 2.9.2 and 2.9.4.
My pages directory contains index.vue, new.vue and README.md. This is in a fresh instance of nuxt created through npx create-nuxt-app . with no extra packages other than nuxt-i18n.
I tried running with npm run dev and npm start, and the issue only occured in dev. The issue also only occurs when nuxt-i18n is loading in nuxt.config.js. When nuxt-i18n is loaded, I can only use <a> for links in transition groups. When it isn't, I can use nuxt-link as well.

@alexkcollier I invited you to collaborate to this repo: https://github.com/paulgv/nuxt-i18n-transition-group-issue
I've tried reproducing your issue there but everything works fine so maybe you'll manage to do it so I can have a look afterward.
Thanks!

I've reproduced with your repo as well, but I've also managed to get it to stop reproducing in all instances on my main computer.
Stack trace pointed me here in .nuxt/client.js:
  // line 521
  if (process.env.NODE_ENV !== 'production') {
    console.error(err);
  } else {
    console.error(err.message || nuxtError.message);
  }

So I went back to my original repo which is using cross-env, built and ran in production. Everything worked as intended, no errors, in my repo and your repo. Switched to dev with cross-env and I've had no issues with nuxt-link in transition-group in any repo.
On a fresh computer without cross-env, however, the issue is reproducing with your repo, both in dev and production. Both computers are on Windows 10, npm 5.7.1, Node 9.8 on the main and 8.9 on the other.

I left it running in the background on my computer while replying, went back and tried the links, and the issue occurred again.

I have the same issue. It happens when I click a  nuxt-link, and in the origin page there is a transition-group with a component inside. Target page then appears with the children is undefined error.
In my case, the nuxt-link is outside of the transition-group.

same issue.
component (not normal element) inside transition-group occurs following errors related to transition-group.
This error doesn't happen without nuxt-i18n.

I have the same problem too.
If put any <nuxt-link :to='localePath()'></nuxt-link> inside the , it will return error.
nuxt-link with localePath() is fine.

I've reported this as https://github.com/nuxt/nuxt.js/issues/4319 in nuxt.js before finding this bug. It has link to reproducible testcase.

Can't reproduce it anymore myself. Even with old tests.

Closing for now!


Xyseries to generic1

Overview: I changed XYseries to accept a list and functions as opposed to forcing clients to create multiple arrays on each create/update.
This is the beginning but I've run out of time tonight. The double[] constuctors still work but, wonce you move to jdk8 you can do something like:
class Foo { double x; double y; double bubbleSz; }
List list= ...
XYSeries ser=new XYSeries("s1", list, axisType
, (list, rowi, obj) -> { return ((Foo)obj).x; }
, (list, rowi, obj) -> { return ((Foo)obj).y; }
, (list, rowi, obj) -> { return ((Foo)obj).bubbleSz; }
);
Had to comment out some code as some libs didn't import into eclipse properly. Hope you can find the time to integrate this and update to jdk8. CHeers!

I'm having a hard time understanding what this is doing better since I'm short on time to dedicate brain cells to it. Can you give me a quick summary?

No problem. The existing code requires one to create arrays to draw a chart. Often one already has say a List and so the array creation is not required. Also Let's sat T is:
class StockPrice { double price; double vol; Date dateTime}
Now one just needs to provide a few functions to turn each StockPrice into x and y to draw a graph.
Other than the first comment overview, what more did you wan to to know?

What is the performance impact of this change from double[] arrays to Lists?

Hi Tomas.
One issue with double[] is that you have to create it beforehand. For
example, if one has:
List list= ...
and:
class Foo { double x, double y; }
You have to:
double[] arr=new double[list.size()];
// populate arr
// chart
But why? We already have the x and y values. We could allow anything that
impls List<?> to be charted w/o creating a double[] or pre-populating it.
For example, if I have a CSV, or table in a db, as long as I impl some list
adapter I can chart it if the chart interface takes a List<?>
--
R Garth Wood
E<EMAIL_ADDRESS><EMAIL_ADDRESS>M:<PHONE_NUMBER>
On Wed, 18 Sep 2019 at 03:40, Tomas Svensson<EMAIL_ADDRESS>wrote:

What is the performance impact of this change from double[] arrays to
Lists?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/knowm/XChart/pull/314?email_source=notifications&email_token=ALBFNFUL62SHLFVKWBNSL6TQKHLO5A5CNFSM4HK5B6MKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD67D6DY#issuecomment-532561679,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ALBFNFSYIYL4KJGA3HXJONTQKHLO5ANCNFSM4HK5B6MA
.


[file icons] Support different file Icons for for files with same extension but different content

This would be useful for Java Files for example. Interfaces, Records, Classes e.g. would be easier to distinguish with these Icons.
Another case where something like this could be useful would be Golang Test files, where Test files could have a different Icon

Looking into files is expensive. File contents can be remote and file can be large. We render a lot of file icons (e.g. in the explorer) at the same time.
It's possible by computing icons in a background task or by maintaining an index. All that we don't have and there are currently no plans to implement that.

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

Looking into files is expensive. File contents can be remote and file can be large. We render a lot of file icons (e.g. in the explorer) at the same time.
It's possible by computing icons in a background task or by maintaining an index. All that we don't have and there are currently no plans to implement that.

For most of these cases to determine the type of file, you don't need to check the whole file contents, usually reading the first few lines is enough. I agree that remote files can be very expensive though. Maybe this can be made a setting that can be changed, with a warning of the performance implications

This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

:slightly_frowning_face: In the last 60 days, this feature request has received less than 20 community upvotes and we closed it. Still a big Thank You to you for taking the time to create this issue! To learn more about how we handle feature requests, please see our documentation.
Happy Coding!


Adapt e2e tests to account for Ironic deployed by IrSO

Currently, the tests assume that Ironic is either started locally or is deployed by BMO's deploy.sh. When deployed by IrSO, it looks differently, so at least re-pivoting tests fail.
/kind ci
/help

We also need some keywords to run tests with IRSO. Create https://github.com/metal3-io/project-infra/issues/920 in project infra for that.

/triage accepted

/remove-help
/assign


refactor(db/get-repo): utilize db indexing

we index full_name (https://github.com/go-vela/server/blob/59553f5f606b275701132b0f5edfa2b725935b3e/database/repo/table.go#L36-L40), but are not leveraging it.

redacting, because we do index org and name :shame: https://github.com/go-vela/server/blob/59553f5f606b275701132b0f5edfa2b725935b3e/database/repo/index.go#L10-L15


Make unit tests pass on Windows computers

For future reference: On windows, the default dtype produced by np.arange with integer arguments is np.int64 on linux, but np.int32 on windows (ref). In the code snippet below, integer_part_length = -1 for an integer value, which leads to factor = 10**8. Calculating value * factor can then lead to an overflow even for a relatively small value.
length = 8
integer_part_length = str(value).find(".")
factor = 10 ** (length - 1 - integer_part_length)
round_func(value * factor) / factor


Character XML Error

Describe your bug here.
Whenever i was finished making a spritesheet. I added it to my mod and it just crashed with the error below. please help!
Command Prompt/Terminal logs (if existing)
C:\HaxeToolkit\haxe\std/haxe/xml/Parser.hx (line 217)
C:\HaxeToolkit\haxe\std/haxe/xml/Parser.hx (line 117)
C:\HaxeToolkit\haxe\std/Xml.hx (line 122)
flixel/graphics/frames/FlxAtlasFrames.hx (line 246)
editors/CharacterEditorState.hx (line 840)
editors/CharacterEditorState.hx (line 520)
flixel/ui/FlxButton.hx (line 521)
flixel/ui/FlxButton.hx (line 507)
openfl/events/EventDispatcher.hx (line 402)
openfl/display/DisplayObject.hx (line 1399)

Uncaught Error: haxe.xml.XmlParserException: Expected node name at line 2 char 2

Are you modding a build from source or with Lua?
Lua
What is your build target?
Windows
Did you edit anything in this build? If so, mention or summarize your changes.
No

How it is your Spritesheet XML file?
Just asking to confirm.


Global hooks?

Is there a global hook or single router hook in reach-router? or some good custom impementation? this feature is really quite useful.
I also use Vue, it's offical implementation is like below:
router.beforeEach((to, from, next) => {...})

I can do some intercept things, like api request and ssr pre-fetch data etc.

One of the trade-offs is "no history blocking", so there wouldn't be a middleware-style next approach to this. And given that, I'd just respond to changes from <Location> or listen to a createHistory() instance.

When Suspense lands, you won't need to pre-fetch data server side since we'll have streaming and components can be asynchronous, waiting for data as they render.
https://www.youtube.com/watch?v=z-6JC0_cOns
Not sure what you'd "intercept" but to perform side-effects on location changes (like analytics? should be an example!) use a component:
import Component from '@reactions/component'
const TrackPageViews = () => (
  <Location>
    {({ location }) => (
      <Component
        didMount={() => track(location.pathname)}
        didUpdate={() => track(location.pathname)}
      />
    )}
  </Location>
)

Or data loading you do in componentDidMount of your route components.


Set PeerReady condition status to true upon relocation initiation

Previously, the PeerReady condition status was set to false after the relocation setup between the source and target clusters was completed and before entering the clean-up phase. This led to a misleading indication that the peer was ready for a new action before getting to that point. Consequently, users can initiate another action, assuming that the PeerReady condition being true meant it was ready for the next step.
To rectify this issue, this commit ensures that as soon as the relocation action is initiated, the PeerReady condition status is immediately switched to false. This change accurately reflects the actual readiness of the peer, preventing any misconceptions about initiating additional actions prematurely.
Fixes: bz 2138855

EnsureCleanup marks PeerReady post its operations are successful. ensureCleanupAndVolSyncReplicationSetup sets up EnsureVolSyncReplicationSetup post cleanup. Should we not mark PeerReady post EnsureVolSyncReplicationSetup is also a success from a VolSync POV?

Not sure I understand the question. EnsureCleanup() is where we set the PeerReady as a success. We don't enter the volsync setup without ensuring that the peer is ready.

EnsureCleanup marks PeerReady post its operations are successful. ensureCleanupAndVolSyncReplicationSetup sets up EnsureVolSyncReplicationSetup post cleanup. Should we not mark PeerReady post EnsureVolSyncReplicationSetup is also a success from a VolSync POV?

Not sure I understand the question. EnsureCleanup() is where we set the PeerReady as a success. We don't enter the volsync setup without ensuring that the peer is ready.

(just reiterating, does not impact this PR)
So if volsync is not setup on the secondary, is it ready for a relocate? IOW should we declare DRPC PeerReady with Volsync protected volumes before the volsync setup is complete?
(above is based on my understanding that we declare PeerReady true in DRPC post EnsureCleanup and pre EnsureVolSyncReplicationSetup)


modify the parameters

Hi,bowen,Thanks for your great work!
I want to know how to modify the parameters if  I don't use pre-training . Experiments show that if only use the default parameters (just set pretrain=False), PQ is only about 45% on cityscapes.

I would suggest you change MAX_ITER from 90k to 900k. If it still cannot get the 59%, then try also increasing the learning rate by 10x.

I would suggest you change MAX_ITER from 90k to 900k. If it still cannot get the 59%, then try also increasing the learning rate by 10x.

Thanks for your reply!


Default multipart form encoding uses noncompliant URLEncoder for tilde (~)

Problem:
Following the examples in the docs for submitting form data using multipart method results in encoding that is not compliant with RFC 3986 specifically related to how the tilde (~) character is handled.
multipart("form", Map("some_key" -> "~")) results in a StringBody(some_key=%7E,utf-8,text/plain) form component generated where the tilde has been encoded into %7E. As per the latest spec on URL encoding, ~ is not a reserved character and should not be encoded.
It looks like this problem was partially tackled already within STTP as the internal UriCompatibility object has an additional encodeDNSHost method which uses a spec compliant Rfc3986.encode method. Unfortunately the multipart method uses the noncompliant encodeQuery method on UriCompatibility.
Is it possible to switch to using the Rfc3986 encoder instead of the URLEncoder as part of the multipart method's form handling? (edit: originally mentioned incorrect allowedCharacters set that would work here) Looks like a new character set would need to be defined within Rfc3986 object to get a fully correct allowedCharacters set. Want a PR for this?

Disregard that edit note, the Rfc3986.Unreserved char set would be correct. I got confused because URLEncoder also incorrectly handles the * asterisk character by not encoding it even though it is a reserved subdelimiter character.

Yes, a PR would be great - though I'd like to include this change in sttp4 (so the PR would be to the master branch). If you could also add a test, that would be even better :)

Java URLEncoder has a following comment regarding encoding ~ .
mark        = "-" | "_" | "." | "!" | "~" | "*" | "'" | "(" | ")"
*
* It appears that both Netscape and Internet Explorer escape
* all special characters from this list with the exception
* of "-", "_", ".", "*". While it is not clear why they are
* escaping the other characters, perhaps it is safest to
* assume that there might be contexts in which the others
* are unsafe if not escaped. Therefore, we will use the same
* list. It is also noteworthy that this is consistent with
* O'Reilly's "HTML: The Definitive Guide" (page 164).

It seems that there may be some corner cases around parsing ~.
Although, they probably do not apply to multipart requests I wanted to share this to add some more context.
I think the we can safely use Rfc3986.encode for parts.


Block is not being rendered using custom template after editing

When we edit a block with custom template and click Save, the block will be rendered without loading custom template. It happens in case when custom template was set via $a->setCustomTemplate(). If custom template was set via Area Design select box in context menu, everything is fine

Do you have the steps to reproduce this? what are you passing in to the setCustomTemplate function?

Let's say I want to apply my custom template to content block type. I do the following:
1.Create application/blocks/content/templates/my content/view.php
2.Create area in page template and set custom template for content block:
$a->setCustomTemplate('content', 'templates/mycontent')
3.Switch to edit mode, add block to area, switch off edit mode, publish and so on ... reload the page, see that content block is displayed using my customized view.
4.Switch to edit mode again. Follow to Edit Block option. Make some changes. Save.
5.Block view reloads according to core view.php template.
If I set template using dashboard and Design ... option in block options menu, everything is fine.
If I create application/blocks/content/view.php it will work as well.
But when we use setCustomTemplate and block is being re-rendered after editing, it doesn't know about assigned custom template to area. In setupRender method it doesn't set the right bFilename property.

It seems that I've found the problem. The thing is th following...
When we are adding a block, we are initiating a request to add_block action. And in get parameters there is an 'arCustomTemplates' key which helps to set custom templates.
But in my case when I add content block the key name is wrong - 'arCustomTemplate' (the 's' is missing).
So, the problem is in line 184 of editmode.js. And as I understand, it occurs only in case of inline editing.


Content block segmented: missing CTA at item level

Detailed description

Describe in detail the issue you're having.
CTA does not render from the given items array

var items = [   {     heading: '{{ content.field_subheadline }}',     image: {       heading: '{{ content.field_short_copy }}',       image: {         sources: [           {             src: '{{ file_url(node.field_imagefile_s.entity.uri.value) }}',             breakpoint: 320,           },           {             src: '{{ file_url(node.field_imagefile_s.entity.uri.value) }}',             breakpoint: 400,           },           {             src: '{{ file_url(node.field_imagefile_s.entity.uri.value) }}',             breakpoint: 672,           },         ],         alt: '{{ node.field_alttext.value }}',         defaultSrc: '{{ file_url(node.field_imagefile_s.entity.uri.value) }}',       },     },     copy: '',     cta: {       href: "{{ content.field_link[0]['#url'] }}",       copy: "{{ content.field_link[0]['#title'] }}",       type: 'local',       stype: 'text'     },   },

Is this a feature request (new component, new icon), a bug, or a general
issue?
Bug
Is this issue related to a specific component?
Content Block Segmented
What did you expect to happen? What happened instead? What would you like to
see changed?

What browser are you working in?
chrome

What version of the IBM.com Library are you using?
Tested on 1.7.0 and 1.7.0-rc.1
What offering/product do you work on? Any pressing ship or release dates we
should be aware of?

Steps to reproduce the issue

Step one
Step two
Step three
etc.

Additional information

Screenshots or code
Notes

This was the original issue: https://github.com/carbon-design-system/ibm-dotcom-library/issues/1845
Raph had previously fixed it with this PR: https://github.com/carbon-design-system/ibm-dotcom-library/pull/2396
It wasn't merged till after a code freeze so it's been canary for a few weeks


migrate mochaGrep into --testCase parametrizing

Do we have a test case covering this? Other than that it's missing a CHANGELOG entry but this seems internal enough that that may be redundant.

http://jenkins01.arangodb.biz:8080/view/PR/job/arangodb-matrix-pr/5149/

http://jenkins01.arangodb.biz:8080/job/arangodb-matrix-pr-linux/6817/ - blue balls on second run.


.superRefine should have some information about previous errors

Hi, so most of the time we don't want to run refine or superRefine if any previous condition has errors. To control this behaviour, there should be a way to at least get if there are any previous errors. Then we can return a fatal error from superRefine.
Otherwise such as in the case below, I will have to call the api even when I could simple prevent it for not having appropriate data.
This can be checking if email already exists in the database, we must know if the fields which can be checked offline are error free, only then we will call api, which will reduce load on server, also faster feedback to users, otherwise users will have to wait for api everytime they clicks submit even when there is no need (eg: when there are errors with fields that can be checked offline)
`
const formSchema = z
.object({
email: z.string().email({ message: "Please enter a valid email" }),
password: z
.string()
.min(8, { message: "Password must be at least 8 characters" })
.max(16, { message: "Password must be at most 16 characters" }),
})
.superRefine(async (data, ctx) => {
const { success, message, status } = await validateLogin(
data.email,
data.password
);
if (!success) {
  ctx.addIssue({
    path: ["email"],
    code: z.ZodIssueCode.custom,
    message: message || "Failed to login, try again",
  });
}

});
`

@Codename-404 see this example that conform validation library uses to solve the problem.
They are using z.pipe() to achieve something similar.


Dart Guest Initial Impl

This PR adds an initial implementation of how a Dart guest could look like.
It is largely based on the Typescript guest, with minor modifications/adjustments for Dart.
Currently all the .wit examples compile, except for the union one, since Dart does not support unions. Likewise, the variant.wit file will not compile as it contains a union definition, but if that changes to let's say a type definition, then it will work as expected.
Lastly, to support a few features (e.g. tuples), Dart 3.0.0 has been used, which still in development mode. In the coming weeks the beta version will be released, and by mid-summer 2023 it will reach a stable version. Since the nature of this package is still experimental, I don't believe this is much of a problem, since by the time this package has matured, so will have Dart 3.

Very cool I'll give it a proper look tomorrow!
Re the union issue: What would possible workarounds look like? For example the guest-ts generator currently outputs a workaround using interfaces and a union to represent the variant type. Can we do something similar for dart here?

To my knowledge, there are no easy workarounds. One option would be to use the freezed package, but it might be an overkill since it does more than our use case.
A naive/simple implementation would look like the current variant type implementation, playing around with subclasses and factory constructors, but I don't feel it solves the issue that much.
When I was transforming the TS api to dart, wherever there were union type definitions, I usually worked around them using enums or by making specialized Union classes with type parameters. This worked well for simple "one or the other" cases, with a simple Union class abstraction with a left and right constructors, but I don't know how it would scale for larger unions. That Union implementation is almost identical to the implementation I provided for an equivalent Result type for Dart.
Workarounds are surely possible, but might be unintuitive or cumbersome, and most of the times would delegate the type checking to runtime, not gaining much from code generation that way, other than automation. It is something that should be investigated further, but I wouldn't devote to it much time yet, since it is a highly requested language feature and it might be implemented by the core dart team sooner or later.


[1.5.n] onboarding guest get user direct

have rebased to the latest 1.5.n branch and passed all the tox tests.

@jichenjc @SeanHQF @bjhuangr  please help review.

lgtm


Do not require service_instance_sharing feature flag in order to bind to shared service instances

As an app dev (receiver), I can continue to bind apps to a service instance that has been shared with me when the feature flag is disabled. #153438338
NOTE: This PR builds on top of #1028, which should be merged first. The actual changes on top of #1028 can be viewed in this diff.
What
Previously, we restricted binding apps to shared service instances such that it was only allowed when the service_instance_sharing feature flag was enabled. For better UX in the situation where the feature flag was enabled, a service instance was shared, and then the feature flag was disabled, we now allow users to bind apps to shared spaces, even when the flag is disabled.
In PR #1027, we removed the requirement that the service_instance_sharing feature flag be enabled in order to unshare a service instance. This PR rounds out that user experience, so that users don't see orphaned service instances that may not bind apps to.
Changes:

Remove feature flag checks at the model and action level when creating service bindings.
Remove unnecessary setting of the feature flag at various points in the unit tests.

PR

[X] I have viewed signed and have submitted the Contributor License Agreement
[X] I have made this pull request to the master branch
[X] I have run all the unit tests using bundle exec rake
[X] I have run CF Acceptance Tests on bosh lite

Thanks,
SAPI team (@jenspinney and @samze)

Hi Jen,
We looked through your PR and noticed that the feature-flag itself is being left as-is, while you've modified several checks to ignore it. We're wondering why the flag itself isn't being removed as well, to signify to users that something has changed. I could imagine a user disabling the flag with no actual results. Maybe we know that no one is depending on this flag being disabled? Mostly looking for context on that aspect, otherwise looks good 🐋
cc @zrob for product context on how this usually goes?
Thanks!
Raina and Maryam (@maryamklabib)

Seems like the feature flag is still being used in one more place so makes sense why it wasn't totally removed. Merging!


About Firebird database link

我在使用FlameRobin工具连接Firebird数据时，出现错误，你能帮下我吗？ @mariuz

I made an error when using the flamerobin tool to connect Firebird data. Can you help me?

Please give me more information about the version of FB and FR you are using.
./jo

Seems to be a Firebird user/password configuration issue , please verify if you can connect with isql from command line
https://stackoverflow.com/questions/4272399/firebird-error-username-and-password-are-not-defined-with-delphi-application


Nephio Observability: free5gc visibility data scraping

That could include subscriber count / info, and logs

@s3wong What information are we trying to gain from logs? I have little hope for a generic solution including logging, since I believe most 5G Core implementations don't follow a standardized format of structured logging

@s3wong What information are we trying to gain from logs? I have little hope for a generic solution including logging, since I believe most 5G Core implementations don't follow a standardized format of structured logging

@MA3CIN  At this point I don't have any expectation for Nephio Observability software modules to parse logs and able to decipher what status of the NF is in (you probably will eventually need to train some LLM model to parse these, if that is the direction at all); but for now, simply collecting them (the free5gc logs were immensely useful during R1 when we were trying to make a 5G call), and able to correlate that these logs with these timestamps are associated with metrics and traces from this same NF instance (i.e., per NFDeployment, mainly, for our case), and a user (of observability, so user can be human or an application like SA) can query "all the data for NFDeployment name blah within time X and Y" and we can return it. That's all.


ble_att_svr: fix keysize check for SC Only mode

Keysize for level 4 security is 16 Bytes not 128 bits.

16 bytes are 128bits :-)  I'd adjust commit message to something like "keysize is kept in bytes and not bits" or similar :-)

Indeed, 16 bytes are 128 bits. Edited commit message :)


[bug]: Default value for max-commit-fee-rate-anchors is too low

Background
We had a user run into issues as LND is capping the anchor commitment fee at MaxAnchorsCommitFeeRate, which defaults 		to lnwallet.DefaultAnchorsCommitMaxFeeRateSatPerVByte which is set to 10 sat/vb since https://github.com/lightningnetwork/lnd/pull/4855. As the mempool minimum nowadays often spikes above that value, LND will try to use a fee rate that won't allow commitment transactions to propagate, which LDK on the other hand won't allow.
While the sample-lnd.conf makes note of this as: Must be large enough to ensure transaction propagation, the current default seems unreasonably low.
Your environment

version of lnd: v0.17.1-beta (should be the same for master/v0.17.2-beta)

Given the current fee climate, I think it makes sense to increase the default value. While we're at it, we should add a new RPC that allows callers to update the default value and/or queue up and trigger an update_fee message.

This would be very helpful for us, since we use LDK on mobile and we use LND for LSP

We had a user run into issues as LND is capping the anchor commitment fee at MaxAnchorsCommitFeeRate, which defaults to lnwallet.DefaultAnchorsCommitMaxFeeRateSatPerVByte which is set to 10 sat/vb since https://github.com/lightningnetwork/lnd/pull/4855. As the mempool minimum nowadays often spikes above that value, LND will try to use a fee rate that won't allow commitment transactions to propagate, which LDK on the other hand won't allow.

Is this during the opening of the channel? During channel operation, LND's commitment fee should go higher than the minimum relay fee here: https://github.com/lightningnetwork/lnd/blob/ac9ca024a4bfb2890e2cd450666bd94d221fe172/lnwallet/channel.go#L8464

I agree that the default of 10 sat/vb is far too low. This currently leads to SCB restores peers possibly not sending their commit TX if the channel was opened by the peer and he did not care about the parameter.
The max anchor commit fee should therefore be higher than the purging rate for a standard mempool assuming a high-fee environment. I would therefore suggest increasing the parameter to ~200 sat/vb.


python311Packages.nibe: 2.1.4 -> 2.2.0

Diff: https://github.com/yozik04/nibe/compare/refs/tags/2.1.4...2.2.0
Changelog: https://github.com/yozik04/nibe/releases/tag/2.2.0
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 229981 run on x86_64-linux 1

5 packages built:

home-assistant-component-tests.nibe_heatpump
python310Packages.nibe
python310Packages.nibe.dist
python311Packages.nibe
python311Packages.nibe.dist


'odo describe ` human and machine readable output are not in sync

[kind/Bug]
Data presented in human and machine readable output should be the same. Currently '-o json' option print out json with less information.
For example  human readable output would print
odo describe nodejs-ex-nodejs-exra --app app1
Component Name: nodejs-ex-nodejs-exra
Type: nodejs
Source: https://github.com/dgolovin/nodejs-ex
Storage:
- s1 of size 1Gi mounted to C:/Program Files/Git/mnt/s1
URLs
- http://nodejs-ex-nodejs-exra-8080-app1-myproject.<IP_ADDRESS>.nip.io exposed via 8080

When machine readable only
odo describe nodejs-ex-nodejs-exra --app app1 -o json
{
    "kind": "Component",
    "apiVersion": "odo.openshift.io/v1alpha1",
    "metadata": {
        "name": "nodejs-ex-nodejs-exra",
        "creationTimestamp": null
    },
    "spec": {
        "type": "nodejs",
        "source": "https://github.com/dgolovin/nodejs-ex",
        "url": [
            "nodejs-ex-nodejs-exra-8080"
        ],
        "storage": [
            "s1"
        ]
    },
    "status": {
        "active": false
    }
}

Couple differences to note in machine readable output:

Only storage name
Url has only host prefix not a full form

The idea is that you will get just the names of the related objects.
If you need detail information you need to run odo url describe <url name> and similarly for the storage.
Do you need all the info in the output?
We could also output the List of all  related object to given component as a list
Output would look like this:
odo describe nodejs-ex-nodejs-exra --app app1

{
    "kind": "List",
    "apiVersion": "odo.openshift.io/v1alpha1",
    items:[

{
    "kind": "Component",
    "apiVersion": "odo.openshift.io/v1alpha1",
    "metadata": {
        "name": "nodejs-ex-nodejs-exra",
        "creationTimestamp": null
    },
    "spec": {
        "type": "nodejs",
        "source": "https://github.com/dgolovin/nodejs-ex",
        "url": [
            "nodejs-ex-nodejs-exra-8080"
        ],
        "storage": [
            "s1"
        ]
    },
    "status": {
        "active": false
    }
},
{
    "kind": "Storage",
    "apiVersion": "odo.openshift.io/v1alpha1",
    "metadata": {
        "name": "s1",
        "creationTimestamp": null
    },
    "spec": {
      ....
      ......
},
{
    "kind": "Url",
    "apiVersion": "odo.openshift.io/v1alpha1",
    "metadata": {
        "name": "nodejs-ex-nodejs-exra-8080",
        "creationTimestamp": null
    },
    "spec": {
      ....
      ......
}
]
}

Would that help?

@kadel I did not realize it is basically just references to related objects. I was just thinking straightforward that both outputs should contains the same info. If it would I would use less odo commands this way. For example I would use it for getting storage and url lists instead of odo url/storage list commands.
IMO from user point of view would be better to have the same info for both, but I leave that decision to you.

Can be replaced with odo url list -o json. Closing.


WIP: Revit/sending receiving converting

Warning: this will probably break things spectacularly in some parts.
Revit conversions:

moved conversion logic to/from revit from bulk list to per item
receiving: previously received objects, that are not part of the current "bake", are removed (e.g., send 10 columns, then only 5).
Host elements and children (tested only w/h walls):

when sending, hosts convert their children IF the children are part of the selection/filter.
when receiving, host elements convert and bake their children

Simplified inheritance chains and removed interfaces that were a bit superfluous
Moved revit classes next to the "clean" classes for easier cross-referencing between the two "paradigms"
Simplified AddCommonRevitProps

Schema builder:

make smart application Ids per component✅
prevent seed refresh on file open/close✅
refresh seed on copy paste ✅
faster casting

Other changes in core:

units are now part of the Base object class, to simplify access.
cleaned up HasMemberSafe etc. methods for dynamic props; now going forward use runtime casting with as/is, e.g. myObject["test"] as YourType (as the [] operator returns null on undefined key names rather than throwing errors).

Tests that do not pass:

The rest is green, besides breps (i didn't dare to touch them, as I know alan's working on it on a diff branch). Will merge now, so we can unblock things.


custom-bootbackup.sh

The script doesn't work correctly. Probably some logic errors.
May be also related to the rsync statement I use.

Additional Flags:

-q

I am not certain that this actually is the problem.
It might also be related to the PARTUUID again

This is solved


Add #printModelInfo()

Add more information about the model before the resolution (nb vars, nb cstrs, default search, etc)

I've added to Chatterbox two new methods: printFeatures(Solver solver) and printAllFeatures(Solver solver).
I've created an enum named Attribute which enables analysis of the underlying solver.
Basically printFeatures(Solver solver) prints:
- Solver features:
	Variables : 202
	Constraints : 59701
	Default search strategy : no
	Completed search strategy : no
	Explanations : ConflictBackJumping

and printAllFeatures(Solver solver) prints:
- Solver features:
	Variables : 202
	Constraints : 59701
	Default search strategy : no
	Completed search strategy : no
	Explanations : ConflictBackJumping
	Normalized mean constraints per variable : 0,010
	Normalized mean unary constraints above all : 0,000
	Normalized mean binary constraints above all : 1,000
	Normalized mean ternary constraints above all : 0,000
	Normalized mean nary constraints above all : 0,000
	Normalized mean variables per constraint : 0,010
	Normalized mean decisions variables : 0,990

Any suggestions?

The information related needs to be augmented, but the feature is now available.


Add email contact info

This should be a DCP email list.
Customer to work with PCNS to establish a DL, Labs to add link and text.

@chriswhong @andycochran the DL from the existing Community Portal<EMAIL_ADDRESS>has been reactivated. Tested and functional.


cabal cradle: Allow list of targets

When using a version of cabal which supports the multi repl then it is useful to be able to pass a list of targets to cabal repl when setting up GHC options. At the moment only one target seems to be supported because cabal repl only accepts one target.

I think this is done?

Not quite, as you cant write, for example:
cradle:
  cabal:
    component: ["lib:hie-bios", "exe:hie-bios"]

to load only these two components.


Fix #35, missing macro definitions

Describe the contribution
This fix the missing MACRO definition issue
Fixes https://github.com/nasa/bp/issues/35
Testing performed
Build BP
System(s) tested on
ubuntu
Contributor Info - All information REQUIRED for consideration of pull request
George Lan, MCSG Technoligies

We definitely should merge this, I ran into this problem today.


Floorplan search question / feedback

When adding floorplans to Microsoft search - who are the results visible to?  Are the floorplans available to the world, or somehow only limited to domain users?
Where would I learn more about this?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e310a1cf-f2d0-0613-51ae-2fb6646ac4e1
Version Independent ID: fae06982-6bfa-2cc7-8507-18fa721f5972
Content: Manage floor plans
Content Source: MicrosoftSearch/manage-floorplans.md
Service: mssearch
GitHub Login: @rasrivas
Microsoft Alias: rasrivas

@kingad Like other results from Microsoft Search, floor plan answers will be available to your organization only.

Thanks Jeff.
I also found some of the basics of Microsoft search and I’m reading more about that to educate myself.
Andy
Andrew King
Manager, Software Systems
CDM Smith
Suite 400, 503 Martindale Street, Pittsburgh, PA 15212
Pronouns: He, him, his
[LinkedIN]https://www.linkedin.com/in/king-andrew-9aa58a8a/
cdmsmith.comhttp://www.cdmsmith.com/
[http://www.cdmsmith.com/-/media/Images/CDMSmith_logo_302x180.png]https://www.cdmsmith.com/
[http://www.cdmsmith.com/-/media/Icons/Social-Icons/facebook-icon-gray.png]https://www.facebook.com/CDMSmith/
[http://www.cdmsmith.com/-/media/Icons/Social-Icons/twitter-icon-gray.png]https://twitter.com/CDMSmith
[http://www.cdmsmith.com/-/media/Icons/Social-Icons/instagram-icon-gray.png]https://www.instagram.com/cdmsmith/?hl=en
[http://www.cdmsmith.com/-/media/Icons/Social-Icons/linkedin-icon-gray.png]https://www.linkedin.com/company/cdmsmith/
[http://www.cdmsmith.com/-/media/Icons/Social-Icons/youtube-icon-gray.png]https://www.youtube.com/user/CDMSmith
From: Jeff Kizner @.>
Sent: Friday, May 14, 2021 10:42 AM
To: MicrosoftDocs/OfficeDocs-MicrosoftSearch @.>
Cc: King, Andrew D. @.>; Mention @.>
Subject: Re: [MicrosoftDocs/OfficeDocs-MicrosoftSearch] Floorplan search question / feedback (#161)
@kingadhttps://urldefense.com/v3/__https:/github.com/kingad__;!!OZ2Q16syoZo!pqRfDSZx6Bje5vO_x5UfVwYBORaiRnvElO28ndE2mT1TLB3tCkV5xLCqWoUjbgo$ Like other results from Microsoft Search, floor plan answers will be available to your organization only.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/MicrosoftDocs/OfficeDocs-MicrosoftSearch/issues/161*issuecomment-841287218__;Iw!!OZ2Q16syoZo!pqRfDSZx6Bje5vO_x5UfVwYBORaiRnvElO28ndE2mT1TLB3tCkV5xLCqjQ7ISOI$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/AFQN2CSLLEOTXWSJ72I54HLTNUZETANCNFSM443ISHSA__;!!OZ2Q16syoZo!pqRfDSZx6Bje5vO_x5UfVwYBORaiRnvElO28ndE2mT1TLB3tCkV5xLCq5lJghcg$.


Updates to installation instructions

Thanks!

No problem :)
2015-05-12 17:58 GMT+02:00 Dag Haavi Finstad<EMAIL_ADDRESS>
Thanks!
—
Reply to this email directly or view it on GitHub
https://github.com/varnish/libvmod-vsthrottle/pull/3#issuecomment-101330352
.


Extension Event Date Issue

Description:
When a User adds a "Timeline Extension" event to a Phase, the "End Date" of the new Extension becomes the End Date of the phase, and stops any events (including the Phase ending event) to extend past this new End Date.
Environment:
TEST and DEV
Steps to Reproduce Bug:

Start a new work and put an Anticipated & Actual Date (Jan 01, 2022) into the first Event of the Early Engagement Phase
Save and Submit - this should make the new Summary of Engagement Anticipated Date update to "Apr 01, 2022";
Add a new Extension Event in the Early Engagement Phase:
•	Title: Modification of EE Time Limit
•	Anticipated Start Date AND Actual Start Date: 2022-03-02
•	Number of Days: 20
Save and Submit - this should make the new Summary of Engagement Anticipated Date update to "Apr 21, 2022" – and addition of 20 days into the middle of the Phase;
Unfortunately, this causes the Anticipated Date of the Summary of Engagement to update to Mar 22, 2022

Expected Result:
The end date is adjusted by the amount of days entered into the "Extension" Event - allowing Legislated timelines to be modified by the Act
Actual Result:
The "Phase End" Event date is changed to the Actual End Date of the Extension Event and stops any attempts to change it. Please see the attached diagram (not the screenshot) to see how it is supposed to work.
Screenshot of Bug:

Severity/Priority:
Critical - High (this is something that happens on nearly every project and is needed to work correctly before the app goes live or to staff testing)

we cannot save the modal because there is no available options for the required field "Act"

It's Finally Done!!!!


Collapsible sidebar

Adds a sidebar with nav menu.
Only added to login, but can be copied when passed in review.
Also added an index.js file so all modules with functions and features can be imported there (only needs one script tag i html head)

Hei, I get an error like this in the console "Resource “http://<IP_ADDRESS>:5500/login/node_modules/bootstrap/dist/css/bootstrap.min.css” was blocked due to mismatching MIME type (“text/html”) (X-Content-Type-Options: nosniff )."
If you correct this as follows, the error disappears:

"Hey, it looks like there's a conflict involving three files. To resolve it, consider adding the /dist folder to the .gitignore file. This should address conflicts related to files within the dist folder. Those files are typically generated when running npm run watch or npm run build."

Hei Niklas,could you please add this code to src/scss/styles.scss? I'm hoping this will resolve the conflict in this file with the main branch.
body, html {
    height: 100%;
    margin: 0;
    padding: 0;
}

header {
    height: 100%;
    // width: 200px;
    float: left;
}

.nav-pills li a:hover {
   background-color: $primary;
}

h1 {
    font-weight: 700;
}

.list-group-item {
    border-left: 0;
    border-right: 0;
}


Removal of Status TBH and DHW will possible break Things - C3 type device - Heat Pump Wi-Fi Controller

HA core version
2023.10.3
Intergration version
0.3.22
Device type and model
C3 - Heat Pump Wi-Fi Controller 171H120F
Used App
SmartHome
The description of problem
Why were the sensors "binary_sensor.{DEVICEID}_status_tbh" and "binary_sensor.{DEVICEID}_status_dhw"
has been removed in 0.3.22 ?
These were working as expected until now.
Due to the removal of the sensor, it is no longer possible, for example, to query whether the heat pump is running in hot water or heating mode. If I read the source code correctly, you can only see whether the hot water mode is activated or not.

The logs
No response

This is the view from version 0.3.21.
Heating and DHW (Warmwasser) modes are both enabled.
On the screenshot you can see that currently only DHW is running, not Heating.

I support that TBH status and DHW status were necessary features. Please restore these functions if possible. Currently, my DHW automation is broken.

The version v0.3.22 includes two switches, tbh and dhw_power, which have the same functionality as status_tbh and status_dhw. Therefore, I have removed the latter two. You can use the status of these two switches in automation, can’t you?

Thanks for the advice, I’ll try to use the THB switch instead of the THB status in automation. But it turned out that the problem is that none of the switches, neither disinfection nor THB, can be turned off. If the THB relay is enabled via HA, it can only be disabled via the app and not via the HA switch.

Thanks for the advice, I’ll try to use the THB switch instead of the THB status in automation. But it turned out that the problem is that none of the switches, neither disinfection nor THB, can be turned off. If the THB relay is enabled via HA, it can only be disabled via the app and not via the HA switch.

Well, I’ll take a look at this issue. Could you show me the logs where you turned tbh on/off in ha?

I also have the same problem with the TBH.
home-assistant_midea_ac_lan_2023-10-17T15-26-10.281Z.log

The version v0.3.22 includes two switches, tbh and dhw_power, which have the same functionality as status_tbh and status_dhw. Therefore, I have removed the latter two. You can use the status of these two switches in automation, can’t you?

You cannot combine the switch with the status of the DHW. Both must be separate. You can activate the DHW mode on the heat pump with the switch but this does not automatically mean that the heat pump will run directly and produce hot water. For that you need the DHW status. The same applies to the TBH switch and status. In version 0.3.21 this was implemented correctly.

please bring back those sensors :(

The sensors are included in the master branch again.
Simply download the version "master" again in the HACS menu under "Midea AC LAN".
After the final release you can switch back to the normal version.

I definitelly agree with this, the sensors dhw/heating/tbh status are critical for the automations with this device type, they never can't be combined in switches.


Bump version: 1.1.1 → 1.1.2

Release new README to pypi.

Codecov Report

Merging #24 into master will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master       #24   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           11        11
  Lines          265       265
  Branches        34        34
=========================================
  Hits           265       265

Impacted Files
Coverage Δ

pypyraws/version.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1d1b0f...2d4e487. Read the comment docs.


Update .eslintrc.cjs

ignorePatterns was duplicated and contained two overlapping entries so the first one which had less could be removed.

Nice catch and thanks for the PR !


Remove setNodePosition?

Do you have a use case where setNodePosition would be useful? If not I would remove it. Note also it returns a tuple to the user so if I type
la.setNodePosition('S1', [200,200])
I get the following output. I don't think the user needs to see this? I any other methods do this I would suppress the outut.
(   net_idx  idx  ...          border_color border_width
0        0    0  ...  [255, 255, 255, 255]          2.0
[1 rows x 8 columns],
net_idx  comp_idx  idx  ...  border_width  txt_font_color txt_line_width
0        0         0    0  ...           2.0  [0, 0, 0, 255]            1.0
1        0         0    1  ...           2.0  [0, 0, 0, 255]            1.0
2        0         0    2  ...           2.0  [0, 0, 0, 255]            1.0
3        0         0    3  ...           2.0  [0, 0, 0, 255]            1.0
4        0         0    4  ...           2.0  [0, 0, 0, 255]            1.0
[5 rows x 17 columns],
net_idx  idx  ... bezier arrow_head_size
0        0    0  ...   TRUE    [12.0, 15.0]
1        0    1  ...   TRUE    [12.0, 15.0]
2        0    2  ...   TRUE    [12.0, 15.0]
[3 rows x 13 columns])

We have discussed to keep this function, because sometimes users only want to change the position of node but not the position of node text.
I couldn't reproduce the error with dataframe output, please make sure to use the latest version. At least now, it does not show at my platform.


Support applyOnReload for LoadConfiguration

Fixes https://github.com/NLog/NLog/issues/1429

Could also be interesting to verify that this works together with the autoreload-feature in MEL NLogLoggingConfiguration:
Notice how I abuse ConfigurationChanged to unhook from filewatch-notications from MEL-config-system:
https://github.com/NLog/NLog.Extensions.Logging/blob/master/src/NLog.Extensions.Logging/Config/NLogLoggingConfiguration.cs

@snakefoot please your opinion on this approach.
I still have to do:

[ ] verify that this works together with the autoreload-feature in MEL
[ ] change LoggingConfiguration.Reload()? Dunno how, revert doesn't work yet.
[ ]  LogFactory.Close() / LogFactory.Dispose() ? (Similar to Shutdown) - this isn't needed anymore?


Rebase to master

There were two commits that didn't sign the DCO, see the details on that job for more info. I passed the check because they appear to be community additions and they are already in master (this is just a rebase).


Idea: Web based(Server-less Javascript) or GUI Application for generating yml configuration.

We have seen so many application authors wanting to integrate AppImages into their release system but they fail because they have very little knowledge about AppImages or think it as a chore. So I propose that we build some kind of server-less Javascript or GUI Application to generate the yml configuration file with respect to their Continuous Integration platform. For starters we can aim at travis-ci.
I can help to get this idea started, But I really don't know if its a good idea. Any suggestions?

Or we could also create a desktop applicatoin(GUI) to automatically modify the travis-ci files and also generate the AppImageCraft configuration file.

I was thinking on create some sort of wizard like the one on Snapcraft with the common recipes. I guess that it can be extended with extra options to ease tweaking to the new-comers.

wizard like the one on Snapcraft with the common recipes. I guess that it can be extended with extra options to ease tweaking to the new-comers.

Yes, also adjusting to the build process by parsing the travis.yml which needs some sort of guessing.

I think what we are going at is very similar to OBS. OBS also builds AppImages automatically based on recipes but it cannot go well with continuous integration. Also it requires extra knowledge and a lot of chore to get started.

we can use the travis-ci api to encrypt the github api key directly into the travis.yml and automatically make the AppImages release onto a specific release tag like continuous. We could also create a Github App to integrate all these very smoothly.

Sounds terrific!

What I have in mind is this,
Build the App using Next.js(and Obviously React.js),
Using Github OAuth or Github token with repo scope get access to the user's targeted repo's write access and read .travis.yml and parse it to create a new .travis.yml integrating the AppImageCraft. Make sure to make a backup to revert the commit if something goes terribly wrong.
Also have a manual wizard to create a customized build with a template.
If everything goes well, integrating AppImageCraft should be easy as integrating codacy. And that is awesome.

I can feel that you're about to do it! Just let's consolidate a bit the implementation and we move on making the tool.

Also it would be great if it integrates with gitlab and gitlab-ci. I guess that we could make a tool like this part of the https://opencode.net ecosystem.

since travis-ci is not opensource by any means, i suggest to build this for gitlab ci for starters instead.

since travis-ci is not opensource by any means, i suggest to build this for gitlab ci for starters instead.

@star-buck Thanks for the insight. But I think Travis-CI is open source too (https://github.com/travis-ci). Most of their tools are open source(Correct me if I'm wrong). But adding support for gitlab ci won't hurt.
Okay I will be working on integrating this in a non-invasive way and also make it easy for the end user., The first revision will support Gitlab-CI and Github(Travis-CI).
@azubieta Some name suggestions could help(I'm very bad at naming stuff), also if I were to publish the source at some point, should I create a new repo in AppImageCraft org or in my personal account?

@azubieta Some name suggestions could help(I'm very bad at naming stuff), also if I were to publish the source at some point, should I create a new repo in AppImageCraft org or in my personal account?

What about naming it "AppImageCraft-Web", or just AppImageCraft. In a future we could host it in a domain with that name.
Publishing the repo as part of the organization will be better to onboard possible collaborators. So, yes, please create the repo here.

Can we still use AppImageCraft as the name???

The AppImageCraft project was there before we started this one, also appimage-builder is not a bad name. So let's avoid pointless discussions and keep using appimage-builder.


HADOOP-19245. S3A: S3ABlockOutputStream no longer sends progress events in close()

Description of PR
change signature of bridging class ProgressableListener so progress gets invoked
as events happen during upload
How was this patch tested?
updated test; verified it failed before the production code change
s3 london
For code changes:

[X] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
[X] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 57s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
44m 44s

trunk passed

+1 :green_heart:
compile
0m 45s

trunk passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2

+1 :green_heart:
compile
0m 36s

trunk passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

+1 :green_heart:
checkstyle
0m 34s

trunk passed

+1 :green_heart:
mvnsite
0m 43s

trunk passed

+1 :green_heart:
javadoc
0m 29s

trunk passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2

+1 :green_heart:
javadoc
0m 36s

trunk passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

+1 :green_heart:
spotbugs
1m 10s

trunk passed

+1 :green_heart:
shadedclient
33m 56s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 30s

the patch passed

+1 :green_heart:
compile
0m 35s

the patch passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2

+1 :green_heart:
javac
0m 35s

the patch passed

+1 :green_heart:
compile
0m 27s

the patch passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

+1 :green_heart:
javac
0m 27s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 22s

the patch passed

+1 :green_heart:
mvnsite
0m 32s

the patch passed

+1 :green_heart:
javadoc
0m 16s

the patch passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2

+1 :green_heart:
javadoc
0m 26s

the patch passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

+1 :green_heart:
spotbugs
1m  9s

the patch passed

+1 :green_heart:
shadedclient
33m 53s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 43s

hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
0m 39s

The patch does not generate ASF License warnings.

127m 22s

Subsystem
Report/Notes

Docker
ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6974/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6974

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 04b49a513003 5.15.0-106-generic #116-Ubuntu SMP Wed Apr 17 09:17:56 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / edeb489dcfa057f980562aba23568fa0fe72b364

Default Java
Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6974/1/testReport/

Max. process+thread count
644 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6974/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

thanks. merging and will cherrypick


Set up redux and apollo

Acceptance Criteria

[ ] It should add redux and set it up with its context provider
[ ] It should add apollo
[ ] It should add a redux side effect library

Context
Given I want to develop application logic when I write actions, reducers, and graphql queries then they all work
UI Screenshot or Wireframe (optional)

Related to #6


License?

Hi, thanks for making this repo available. I just wanted to ask if it's released under a particular license?
I would like to use it within the MIT-licensed higlass-server project and want to make sure that doing so is permitted.
There's also a few changes I could contribute back to the repo.

🙈🙈🙈 turns out I disabled notifications for this repo by accident and only noticed it just now! I added an ISC license. I guess this is probably no longer relevant, but thanks for the reminder that I should add one. Sorry for taking almost two years to do that 🙈

Lol. Thank you!
The license uncertainty led me to start a very similar project here (with attribution to you): https://github.com/higlass/simple-httpfs

Oh cool!  I appreciate it.


Unable to build a binary

I'm unable to build a deno binary, due to some dependency error?
Error message:
error: builder for '/nix/store/1dbmg0n7qyb95q107xa4yh5sg32kaf53-denobot.drv' failed with exit code 1;
       last 25 log lines:
       > Download https://registry.npmjs.org/magic-bytes.js
       > Download https://registry.npmjs.org/minimatch
       > Download https://registry.npmjs.org/minipass
       > Download https://registry.npmjs.org/package-json-from-dist
       > Download https://registry.npmjs.org/path-scurry
       > Download https://registry.npmjs.org/path-key
       > Download https://registry.npmjs.org/prisma
       > Download https://registry.npmjs.org/shebang-command
       > Download https://registry.npmjs.org/signal-exit
       > Download https://registry.npmjs.org/shebang-regex
       > Download https://registry.npmjs.org/string-width
       > Download https://registry.npmjs.org/ts-mixer
       > Download https://registry.npmjs.org/strip-ansi
       > Download https://registry.npmjs.org/tslib
       > Download https://registry.npmjs.org/tsyringe
       > Download https://registry.npmjs.org/typedi
       > Download https://registry.npmjs.org/undici-types
       > Download https://registry.npmjs.org/which
       > Download https://registry.npmjs.org/undici
       > Download https://registry.npmjs.org/wrap-ansi
       > Download https://registry.npmjs.org/ws
       > error: failed reading lockfile '/build/i1bdxmvn9jic4myxvrfvcc840006krfh-source/deno.lock'
       >
       > Caused by:
       >     Error getting response at https://registry.npmjs.org/@discordjs/builders for package "@discordjs/builders": error sending request for url (https://registry.npmjs.org/@discordjs/builders): client error (Connect): dns error: failed to lookup address information: Temporary failure in name resolution: failed to lookup address information: Temporary failure in name resolution
       For full logs, run 'nix log /nix/store/1dbmg0n7qyb95q107xa4yh5sg32kaf53-denobot.drv'.

flake.nix (also fails with the example flake):
{
  description = "A very basic flake";

  inputs = {
    nixpkgs.url = "github:nixos/nixpkgs?ref=nixos-unstable";
    prisma-utils.url = "github:VanCoding/nix-prisma-utils";
    flake-utils.url = "github:numtide/flake-utils";
    nix-deno.url = "github:nekowinston/nix-deno";
  };

  outputs = { self, nixpkgs, flake-utils, ... }@inputs:
    flake-utils.lib.eachDefaultSystem (system: let
      pkgs = import nixpkgs {
        inherit system;
        overlays = [ inputs.nix-deno.overlays.default ];
      };
    prisma = (
      (inputs.prisma-utils.lib.prisma-factory {
        inherit pkgs;
        prisma-fmt-hash = "sha256-4zsJv0PW8FkGfiiv/9g0y5xWNjmRWD8Q2l2blSSBY3s="; # just copy these hashes for now, and then change them when nix complains about the mismatch
        query-engine-hash = "sha256-6ILWB6ZmK4ac6SgAtqCkZKHbQANmcqpWO92U8CfkFzw=";
        libquery-engine-hash = "sha256-n9IimBruqpDJStlEbCJ8nsk8L9dDW95ug+gz9DHS1Lc=";
        schema-engine-hash = "sha256-j38xSXOBwAjIdIpbSTkFJijby6OGWCoAx+xZyms/34Q=";
      }).fromCommit
        "bf0e5e8a04cada8225617067eaa03d041e2bba36"
    );
    in
    {
      devShells.x86_64-linux.default = pkgs.mkShell { shellHook = prisma.shellHook; };
      packages.denobot = pkgs.denoPlatform.mkDenoBinary {
        name = "denobot";
        version = "0.0.1";
        src = ./.;
        buildInputs = [ ];
        permissions.allow.all = true;
      };
      defaultPackage = self.packages.${system}.denobot;
    }
  );
}

deno.json:
{
  "tasks": {
    "dev": "deno run --watch main.ts"
  },
  "imports": {
    "@discordx/importer": "npm<EMAIL_ADDRESS>    "@prisma/client": "npm<EMAIL_ADDRESS>    "discord.js"<EMAIL_ADDRESS>    "discordx"<EMAIL_ADDRESS>    "prisma"<EMAIL_ADDRESS>  },
  "fmt": {
    "useTabs": false,
    "lineWidth": 80,
    "indentWidth": 2,
    "semiColons": true,
    "singleQuote": false,
    "proseWrap": "preserve",
    "include": ["src/"],
    "exclude": []
  }
}

did you populate deno.lock and check it into VCS before? or is /build/i1bdxmvn9jic4myxvrfvcc840006krfh-source some dependency that your lockfile tries to pull in?

did you populate deno.lock and check it into VCS before?

I don't have any VCS' in this project.

Right - that's not a dependency but just making sure its not missing in the git stage area, since that's a common gotcha with Nix.

It just..... magically disappeared now......????


Add a "Time taken" column to the history page

It shows how long completed builds took to complete.
I think this is a metric that people should be looking at and trying to reduce, so I'd like to increase its visibility.
Note: I didn't bother setting up RiffRaff to run locally, so I've no idea if it works. But it compiles!

:+1: Happy for this to go in. This used to be impossible, but glad it is being surfaced now. Slightly concerned about the width of the table though.

You can deploy to CODE to test this.

How do I deploy to CODE? Don't tell me RiffRaff can deploy itself?!

It can! (It's a nasty hack). Code Riff-Raff is at http://riffraff.code.dev-gutools.co.uk/

What an age we live in.

Here's what it looks like on CODE.

@sihil ok to merge this myself?

Yes, please do.


MonadIO, hoisting etc.

I was defeated trying to apply randomN inside a MonadResource/MonadSafe sort of constraint - basically "get a vector of n random words from /usr/share/dict/words" .  If the parameters for FoldM were rearranged, I guess it would have a valid MFunctor instance since the monadic elements are always in positive position.  But is there place for something like hoist or, for the special case of MonadIO
liftingIO (L.FoldM step begin done) = L.FoldM (\a b -> liftIO (step a b)) (liftIO begin) (\x -> liftIO (done x))

I feel like I'm missing some obvious way to do this that is already  present in the library.

I could definitely add a hoist specialized to FoldM.  I agree that the type parameter order is problematic since you can't implement both Profunctor and MFunctor.

Certainly it seems better to have such an expression around than to labor to make all FoldM's general across MonadIO. I'm as usual devoid of inspiration thinking what it might be called, I can only think of things that allude to lift and hoist like liftWith or hoisting at the moment. It is a fairly unpretentious combinator, less like lift and hoist more like generalize

How about hoists?  If that name is alright with you then I can add it

That sounds great.

Just a minute, if you haven't written it, I will send a patch; you'll have to figure out the documentary comment ...

So here's a patch if you haven't written one https://github.com/Gabriel439/Haskell-Foldl-Library/pull/52

Thanks!  I appreciate it :)


feat: add user visits

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

38 of 42 (90.48%)  changed or added relevant lines in 6 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+2.8%) to 47.564%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/entities/Place/routes/getPlaceMostActiveList.ts
3
4
75.0%

src/modules/sceneStats.ts
7
8
87.5%

src/entities/Place/utils.ts
7
9
77.78%

Totals

Change from base Build<PHONE_NUMBER>:
2.8%

Covered Lines:
238

Relevant Lines:
361

💛  - Coveralls


Jcache public V get(K key) Method

Hi,
I'm Using Jcache with AWS Redis in replicatedServersConfig, but observed jcache get / put operation is always using  master node to for both read and write operations.
in my view get request should go to slave (read) node, put request should go to master node.
Please suggest anything to be changed in my configuration / correct me if i'm wrong.
my cache config:
{
"replicatedServersConfig":{
"idleConnectionTimeout":600000,
"pingTimeout":1000,
"connectTimeout":10000,
"timeout":5000,
"retryAttempts":3,
"retryInterval":1500,
"failedSlaveReconnectionInterval":3000,
"failedSlaveCheckInterval":60000,
"password":null,
"subscriptionsPerConnection":5,
"clientName":null,
"loadBalancer":{
"class":"org.redisson.connection.balancer.RoundRobinLoadBalancer"
},
"subscriptionConnectionMinimumIdleSize":5,
"subscriptionConnectionPoolSize":50,
"slaveConnectionMinimumIdleSize":30,
"slaveConnectionPoolSize":50,
"masterConnectionMinimumIdleSize":30,
"masterConnectionPoolSize":50,
"readMode":"SLAVE",
"subscriptionMode":"SLAVE",
"nodeAddresses":[
"redis://...cache.amazonaws.com:6379",
"redis://...cache.amazonaws.com:6379"
],
"scanInterval":3000,
},
"threads":0,
"nettyThreads":0,
"codec":{
"class":"org.redisson.codec.SnappyCodec"
},
"transportMode":"NIO"
}

It uses master node since it modifies Redis data - writes entry end of life timeout

Hi ,
If it is always going to master node then what is the use of configuring slave node.
Thanks,

Done! Also did some optimizations and got 2x performance boost. Please check


Another issue with the last update

Apparently occurs when an object property contains () or [] and a string.

// Configurable paths for the application
  var appConfig = {
    app: require('./bower.json').appPath || 'app',
  };

  // Define the configuration for all the tasks
  grunt.initConfig({

    // Project settings
    yeoman: appConfig,

    // Watches files for changes and runs tasks based on the changed files
    watch: {
      bower: {
        files: ['bower.json'],
        tasks: ['wiredep']
      },
    }
    /// [....]
  });

The last string cause this issue, use a not perfect solution now.
At least made other syntax looks correct.
Will try to fix the coloring of strings in object.

It works,  many thanks.


Mavlink ODOMETRY handler and simple minimal restructure for VIO data propagation

Test data / coverage
iris_vision takeoff and land, using ODOMETRY as the transport msg: https://review.px4.io/plot_app?log=84cdc725-415e-487c-8c6a-9d4324e26170
Describe problem solved by the proposed pull request
This is a simpler iteration of https://github.com/PX4/Firmware/pull/9301, only handling the reception of ODOMETRY and propagating it to the consumers (ekf2, local_position_estimator - LPE -, and position_estimator_inav).
Describe your preferred solution
The basic idea was already explained in https://github.com/PX4/Firmware/pull/9301. The main difference is that this time a vehicle_odometry uORB and respective aliases for vision and mocap, instead of extending the vehicle_local_position.
Describe possible alternatives
This was the best solution found after discussing with @thomasgubler.
Additional context
The further iterations on the VIO architecture restructure should include:

an ODOMETRY loopback;
add the 6x6 rotation matrix to rotate the pose and velocity covariance matrices on the mavlink_receiver in order to match the frame of reference of the msg - not added in this PR since it's not very relevant for the data validation check, since only the diagonals are used - though, for a matter of physics accuracy and appropriate data handling, this should be considered;
use the full URT values of the covariance matrix on the estimators in order to fill, for example, the noise matrices;
consider start doing some tests using fast-RTPS - one good way could be adding the agent code on the Gazebo and create a new plugin to interface Gazebo with fast-RTPS - that would fasten things in terms of VIO over RTPS development.

@TSC21 There are quite a few LPE changes in here - did you test with EKF2?

@TSC21 There are quite a few LPE changes in here - did you test with EKF2?

All tested with EKF2. Will also add a LPE log as soon as I test with it too.

@LorenzMeier a log is in the PR description - https://review.px4.io/plot_app?log=84cdc725-415e-487c-8c6a-9d4324e26170.

Why is the base vehicle_odometry message needed?

Why is the base vehicle_odometry message needed?

This was a result of a discussion with @thomasgubler. It simplifies the approach of #9301 by:

not extending the vehicle_local_position and overcharge it with new fields that are not needed throughout the system;
adding a simple odometry structure that serves as data input for the consumers (estimators);
serve as base for both visual odometry and mocap data.

To clarify, I was looking at replay subscribing directly to the base ORB_ID(vehicle_odometry). Is this intended?

To clarify, I was looking at replay subscribing directly to the base ORB_ID(vehicle_odometry). Is this intended?
No. It is ti subscribe to vehicle_visual_odometry. Thanks for checking it.

Excellent work! Will test on vehicle with VIO after reviewing.

Excellent work! Will test on vehicle with VIO after reviewing.

Sounds great! Looking forward. Just want to get this to a clean base and I think we are set to go.
@dagar maybe we can add a VIO CI mission on a PR after this one?

@dagar maybe we can add a VIO CI mission on a PR after this one?

Absolutely!

Now working with LPE! iris_vision takeoff and landing:
https://review.px4.io/plot_app?log=87f18177-f02a-465c-a41a-a0f51cb940cc
@jgoppert FYI

@LorenzMeier @dagar anything else you want to add to the review of this? @mhkabir are you able to give it a try on your VIO setup?

Just added a simple VIO test to CI. Conclusion: mavros_test_common.py is waiting for GPS data - in the case of VIO, for indoor flights, the GPS dependent topics are not required (and they will never be available). For LPE, after applying this change, this will work good because of the fake virtual global origin that it can create. For EKF2 though, this will only work if it is added the possibility of creating that virtual origin. This will work ok on offboard control, since it doesn't require global coordinates but rather local ones.

Just added a simple VIO test to CI. Conclusion: mavros_test_common.py is waiting for GPS data - in the case of VIO, for indoor flights, the GPS dependent topics are not required (and they will never be available). For LPE, after applying this change, this will work good because of the fake virtual global origin that it can create. For EKF2 though, this will only work if it is added the possibility of creating that virtual origin. This will work ok on offboard control, since it doesn't require global coordinates but rather local ones.

@dagar based on the above, I think it will actually be a good idea to work on this on a separate PR instead. Let's have this tested first on a VIO rig (@mhkabir we are counting on your for that), and if everyone agrees, get this in.

@TSC21 Could you please fix CI here? Even if that means disabling the VIO test.

Sure. Will bring CI for VIO in another PR.

@LorenzMeier done

Will test on Monday :)

Is this odometry message is a replacement for the vision speed and vision position messages used in v1.8?
From reading and looking at the changes I think yes but just wanted to confirm. And that it's not currently implemented because I have odom in ROS and am splitting it to make the two MAVROS messages rather than just passing it through the odom MAVROS message

@dgonano Yes.

Is this odometry message is a replacement for the vision speed and vision position messages used in v1.8?
From reading and looking at the changes I think yes but just wanted to confirm. And that it's not currently implemented because I have odom in ROS and am splitting it to make the two MAVROS messages rather than just passing it through the odom MAVROS message

It's not a replacement but rather the best alternative to have split msgs for pose and velocity. It does had a few other enhancements.

@bkueng thanks for reviewing. I will address your requests asap.

@TSC21 Could you please update and address the review comments? Thanks!

@LorenzMeier done but region flash' overflowed` on fmu-v2

@Stifael @MaEtUgR  is this something you can give an input about? Thanks

The simple fact of arming the vehicle just starts spamming the Mavlink console with:
WARN  [mc_pos_control] Position-Ctrl activation failed with error: Activation Failed
WARN  [mc_pos_control] Altitude-Ctrl activation failed with error: Activation Failed
WARN  [mc_pos_control] Stabilized-Ctrl failed with error: Activation Failed

@TSC21
not exactly sure why. The activation for auto fails if the subscription to the triplet or the home position fails.

The activation for auto fails if the subscription to the triplet or the home position fails.

Well home position is probably not being set because we are just fusing vision data, so there's no actual global position here. Do we want the logic like this then? Can't one issue an auto takeoff in the local frame?

so the triplet is only sent exactly once and lat/lon are 0?
what is the exact setup?

The exact setup is the one I shared above: PX4 SITL on Gazebo with simulated Iris and VIO data, with EKF2_AID_MASK set to 24 (meaning only vision data - position and yaw - is fused, no GPS or optical flow). The VIO data is good, as EKF2 is able to fuse the data and output an estimated pose.

ok. until now Auto/Mission depends a lot on the Navigator implementation, which is primarily designed for GPS maneuvers.
Would it not be possible to use Offboard instead of Auto? To do a Takeoff from offboard is a simple as sending a position setpoint above takeoff position.

@Stifael I don't really know what is the main issue here, but I am totally sure that before I rebased this commit (before https://github.com/PX4/Firmware/pull/9895#issuecomment-407989384), I was able to issue a takeoff using the commander takeoff command on the nsh terminal and the vehicle would takeoff. And I wasn't using GPS either. So something in the logic changed.

Offboard can perfectly be used here but what did actually change for one not being able to enter the Takeoff mode while only using local estimation source? It seemed to be working before. This is an example using vision, but I question what would happen in a situation where you only have optical flow? Shouldn't one be able to enter Takeoff mode also?

You might have noticed that we made a lot if changes to mc-controller to make future changes and feature addition simpler. That said, it might be possible that certain things are lost because that particular feature was only known to few ppl.
In terms of the takeoff: it is true that there is this if-case in the navigator that takeoff can also be executed without home.
In general, I also think that auto takeoff does not need to be limited to gps. In fact, the same is true for almost all Auto related maneuvers. Unfortunately, the implementation is different except of few cases like the auto takeoff, where still lat/lon are set....https://github.com/PX4/Firmware/blob/master/src/modules/navigator/mission_block.cpp#L617
I will re-enable auto takeoff tomorrow, but I hope to find a more clear way to deal with mission related maneuvers that do not depend on the global frame.

https://github.com/PX4/Firmware/pull/10060 should address the failing Auto-Takeoff without global position

@TSC21 Is this good to test?

@TSC21 Is this good to test?

Yes you can have a go.

Well home position is probably not being set because we are just fusing vision data, so there's no actual global position here.

@TSC21 that will likely change in the not too distant future. Home already contains x,y,z.

@TSC21 that will likely change in the not too distant future. Home already contains x,y,z.

This is not a problem with https://github.com/PX4/Firmware/pull/9895#issuecomment-411047163

@mhkabir have you tested it?

Current blocker: flash overflow.

Hi, Thinking of testing this on the aero (which seems to be building fine). My biggest issue with the vision_position_estimate is that the covariances are ignored, and I only have some of the data. Are the covariances working on this properly for everything?

What do you mean with working properly? What are you trying to test? What's the setup?

I mean, being used. Because in vision position i don't think they are used, correct?
I have (from slam) x&y position and yaw, and (sometimes from some range sensors) z velocity.
I'd like to configure PX4 to use vision for XY pos and yaw (this is working).
But i'd like PX4 to use primarily baro for height, but also able to pass z velocity when I have accurate data, hence why the it needs to be listening to the covariances

Hi, Thinking of testing this on the aero (which seems to be building fine). My biggest issue with the vision_position_estimate is that the covariances are ignored, and I only have some of the data. Are the covariances working on this properly for everything?

@dgonano the covariances are being used on this PR yes. You can have a look at the code and you will see they are passed to the estimators using vehicle_visual_odometry and vehicle_mocap_odometry msgs.

New logs, for confirming correct functionality:

EKF2, using VISION_POSITION_ESTIMATE msgs: https://review.px4.io/plot_app?log=edb5ed39-c98f-4305-8999-2fbba39c5041
EKF2, using ODOMETRY msgs: https://review.px4.io/plot_app?log=a14b29d9-5c71-49d6-8359-947bbe500916

I think after this I can also add a CI test for vision only.

@TSC21 , maybe i'm missing something (perhaps its in a different branch) but can you clarify where the vertical variances are being included in the EKF, it requires changes to ecl as its not currently setup to support it.

@TSC21 , maybe i'm missing something (perhaps its in a different branch) but can you clarify where the vertical variances are being included in the EKF, it requires changes to ecl as its not currently setup to support it.

I understand now what you mean. Your change in https://github.com/PX4/Firmware/pull/10432/files#diff-18e8f57d61a55777f8e25da991013704R1178 can be added here: https://github.com/PX4/Firmware/pull/9895/files#diff-18e8f57d61a55777f8e25da991013704R1177. After this PR is merged, you can rebase yours and have the change made in this line.

@TSC21 could you please outline (bullet points) what still needs to be changed to get this merged now that @bkueng gave his ok.

@thomasgubler the main things to actually finish are:

Add constants to the visual_odometry uORB msg to be used as aliases and replace the magic numbers that represent the covariance matrix indexes;
Regarding the frame of reference: as I answered to @mhkabir, the frame of reference depends on the MAV_FRAME of the Mavlink msg. Currently, the MAV_FRAME possibilities for the Mavlink Odometry msg only allow to choose between earth-fixed NED or ENU, and not some arbitrary frame of reference. So unless we set a new MAV_FRAME for some arbitrary frame, we should stick to the current options. As PX4 mostly works with NED, the data is assumed to be received and parsed in the NED frame. For a more flexible approach, we can add a field to the visual_odometry uORB msg with the frame of reference being used, but still we would be limited to the assumption that the that is NED-aligned, since that's the info received from the Odometry msg. This field would become a requirement as soon as we start using fast-RTPS for accessing the FCU internals. For the time being, I guess I can change the comment stating that is in NED (even though the odometry data is received with the MAV_FRAME set as it is NED-aligned).
There are some bullets as well on the PR description but those are to be addressed in a further PR.

@dagar @bkueng added some constants on the vehicle_odometry msg so to identify the indexes of the covariance matrices diagonals, instead of using "magic" numbers.
@thomasgubler @mhkabir @priseborough added a frame of reference field on the vehicle_odometry msg with the intention of setting the heading of the frame. Though, it's still not used on the estimator side, as we need a new MAV_FRAME to identify a frame of reference not aligned with NED (or ENU). Then, I guess this can replace the last bit of EKF2_AID_MASK, so we also need an update in the ECL side.
As is, I think this PR is good to go, and we can improve it in further iterations.

All CI finally passed. Waiting your acceptance so it can be merged.

@bkueng can you please approve if all looks good now for you? Thanks.

➤ Nuno Miguel dos Santos Marques commented:
@Thomas Gubler@Lorenz Meier I consider this PR complete. Looking for your approval.

I would also like to verify that we maintained full backward compatibility with the old vision_position_estimate mavlink message.

This was tested with sitl_gazebo as well, but living testing is welcomed.

Looks great overall, except the frame rotations in mavlink receiver which I want to review again. I suspect that my issues could have been coming from that.

What problems are you facing? I don't think that they come from the rotations cause they only affect the velocities and angular rates and those aren't even fused on EKF2.

@mhkabir logs and description welcomed to help you debug whatever issue you are facing.

What were the conflicts?

https://github.com/PX4/Firmware/pull/10432 was merged

@mhkabir awesome! Are you able to share us a video and/or log of one of your rigs flying with this PR?

@LorenzMeier good to go?

Nitpicky request for future PRs, can we try to prevent these little fix commits from ending up in master?

Every commit in master should be fully functional and descriptive for bisecting, blame, cherry-picking, or just general browsing.
Let's try to either structure PRs so that it's acceptable to squash & merge (atomic functional changes), or cleanup the history in the branch before rebasing.

@dagar I totally agree. The problem is when bigger changes to the code base (like this one) endup being stuck for a lot of time because of different modification requests, reviews, etc. while several other PR's are getting upstream. This sometimes results in the developer having to rebase the code several times, and there are times that the rebase is not perfect and has to be fixed.
So I totally agree with you, but you also have to agree with me that sometimes there are some PR's that usually take more time to merged than it should, and not because the developer has droped the PR. So I do also agree that we should make things more agile and flexible for people working on the codebase.

Nice to see this got merged!
Not saying you're wrong, but when doing the rebase, if you need to fix at a particular commit, you could amend the fixes to the commit rather than create a commit fixing it. Also you can do an interactive rebase and squash the fix into the previous commit it's fixing as a backup solution.
Also glad to see the hgtErr got set :)

you could amend the fixes to the commit rather than create a commit fixing it.

That's as bad as doing a new commit to fix the rebase, as the changes won't have anything to do with the previous commit.

Also you can do an interactive rebase and squash the fix into the previous commit it's fixing as a backup solution.

That's easy to do... when the PR is smal ;)


Change settings window selector for Ventura

Fixes issue https://github.com/xiamaz/YabaiIndicator/issues/10 for Ventura >=

Thanks and LGTM!


work on NPE, implement promotion concurrency with back-pressure, improve metrics

MemoryStoreDataManager has a NPE periodically when calling the store() method. This attempts to improve logging around that and also address a potential source (rolling back to previous value on exception doesn't check if the old value is null)
PromotionManager's transfer of by-path promotions was serial; I've threaded that out with a new threadpool called 'promotion-transfers', then tried to limit the scope of variables those threads can see, in an attempt to reduce memory impact of a big backlog
Use Weft 1.10-SNAPSHOT which has a new load-tracking feature in the WeftExecutorService
Add checkCapacity() method to by-path promotion methods, to short-circuit using new Weft stats when threadpool is overloaded (currently hard-coded at 10X pool size)...this is just a first attempt. Will error out with 409 Transfer Threadpool Overload if 10X is exceeded.
Add .starts meter for annotated @Measure methods, to give us up-front loading metrics, especially for method calls that take a long time to return (like metadata aggregation).

retest this please

retest this please

retest this please

retest this please

retest this please


Add a way to minimize/hide the UI

It could be nice to have a way to get rid of as much of the UI as you can while you're comparing map styles.

This feels related to #36, since the only time I really care about what the UI is doing is when I'm adjusting the browser window to take a series of screenshots, and I want to make sure the UI is as compressed as possible but still readable (since I want my screenshot to contain a record of which layer settings are active in each pane, and also to include the zoom/lat/lon/etc (and also what preset bookmark location/view I'm using)

I would also like a way to minimize the UI on top of the map when I'm not using it. The style selection boxes at the bottom in particular take up a lot of space.

@aparlato Can we think through what this might look like? I think a button that toggles the UI (and maybe also a hotkey?) could suffice.

Yea, I agree this could be something simple. Maybe just a separate button in the corner with an eye icon?
Visible UI:

Invisible UI:

Could also have something more akin to a fullscreen mode where the top bar is fixed to the top and no longer floats and the style selection boxes are minimized except on hover:

I'm open to either approach, but something closer to the first feels the simplest and most straight forward. If we go with the first, I think a hotkey of v for visible makes sense. If we go for something closer to the second, maybe f for fullscreen?

I think the first is a good approach, but how would you feel about keeping the fullscreen icon and putting it in the top bar to make it more clearly associated with the UI? It would still hide all of the UI except for a button to show the UI.


USSD Dial

The dialer is failing to dial USSD calls like *125# or #322. How can I solve this?

Use %23 instead of #


[CP] Fix perspective transform issue in Impeller display list dispatching

Issue Link
https://github.com/flutter/flutter/issues/130613
Commit Hash
182e1189873bbec33d96b59f20d3b365e7aaf9ba
Target
beta
PR Link
https://github.com/flutter/engine/pull/44106
Changelog Description
In some cases, applying a perspective transform to a widget would result it in it getting incorrectly culled away in the Impeller backend.
Impacted Users
End customers who use apps that have perspective transforms.
Impact Description
UI disappears.
Workaround
Use Skia.
Risk
low
Test Coverage
yes
Validation Steps
Run the unit test in the PR.

@zanderso could you attach the cp: approved label if you cosign this cherry-pick?

@zanderso is OOO. lgtm.