automatically adjust initial size in Image.setImage

I keep running into this, most recently in https://github.com/phetsims/function-builder/issues/62...  If you try to do something like this:
var image1 = require( .... ); // {HTMLImageElement}
var image2 = require( .... ); // {HTMLImageElement}

var myImageNode = new Image( image1, ... );
myImageNode.image = image2;

Image assumes that any subsequent image will be the same size as the first one that you set. So in the example above, image1 and image2 had better have the same size, or things are going to (intermittently) fail.
Awhile back, @jonathanolson added setImageWithSize as a workaround, which is implemented like this:
setImageWithSize: function( image, width, height ) {
  this._initialWidth = width;
  this._initialHeight = height;
  this.setImage( image );
}

Instead of having to do this, why can't setImage handle this automatically?

{ image: ..., initialWidth: ..., initialHeight: ... } is processed in an order that would allow us to say "setImage() resets the initialWidth and initialHeight", since initialWidth/initialHeight (in the options object) are handled after the image.
Seems quite reasonable, any objections?

I'm not totally clear on what you're proposing. Will setImage still take a single arg? Are you suggesting that we need to provide { image: ..., initialWidth: ..., initialHeight: ... } as the arg if the image size is changing?

setImage would still take a single argument, but would always clear initialWidth/initialHeight.
Then setImageWidthSize would be equivalent to image.mutate( { image: image, initialWidth: width, initialHeight: height } ), or image.image = image; image.initialWidth = width; image.initialHeight = height;.

Done

Reopening. This change broke function-builder, see https://github.com/phetsims/function-builder/issues/67#issuecomment-225314732.  Top priority.

I have revert these changes:
@jonathanolson https://github.com/phetsims/scenery/commit/533a56b54e358630f64051b59e009f3cc2f7f6cd (because it broke function-builder)
@samreid https://github.com/phetsims/scenery/commit/3a3e5109466c643c75b43e639798c60f92292039 (because the commit message seems to indicate that this was committed accidentally)

Since the problem was showing up in function-builder calls to Image.setImageWidthSize, I'm guessing that this change buggered up that function.

Highly recommended not to work on this until after function-builder is published.

Removing developer meeting label and we can re-evaluate after function builder is published.


WIP Enable extension of the staticpod installer pod

This is in support of enabling rollback to the previous revision if the new revision proves unhealthy.

Not intended for merge, just posting wip stuff in aid of the eventual enhancement.
/cc @sttts @p0lyn0mial


KeyError for Chart Data in Dashboard

Recently updated shynet to use the latest dockerhub image and came across this:
ERROR Internal Server Error: /dashboard/
Traceback (most recent call last):
  File "/usr/local/lib/python3.9/site-packages/django/core/handlers/exception.py", line 47, in inner
    response = get_response(request)
  File "/usr/local/lib/python3.9/site-packages/django/core/handlers/base.py", line 181, in _get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "/usr/local/lib/python3.9/site-packages/django/views/generic/base.py", line 70, in view
    return self.dispatch(request, *args, **kwargs)
  File "/usr/local/lib/python3.9/site-packages/django/contrib/auth/mixins.py", line 52, in dispatch
    return super().dispatch(request, *args, **kwargs)
  File "/usr/local/lib/python3.9/site-packages/django/views/generic/base.py", line 98, in dispatch
    return handler(request, *args, **kwargs)
  File "/usr/local/lib/python3.9/site-packages/django/views/generic/list.py", line 157, in get
    context = self.get_context_data()
  File "/usr/src/shynet/dashboard/views.py", line 39, in get_context_data
    service.stats = service.get_core_stats(
  File "/usr/src/shynet/core/models.py", line 117, in get_core_stats
    comparison_data = self.get_relative_stats(
  File "/usr/src/shynet/core/models.py", line 203, in get_relative_stats
    chart_data, chart_tooltip_format, chart_granularity = self._get_chart_data(
  File "/usr/src/shynet/core/models.py", line 295, in _get_chart_data
    chart_data[k["date"]]["hits"] = k["count"]
KeyError: datetime.date(2021, 6, 1)

Sorry about this. It's a known issue and will be fixed in the next release. The issue occurs when a session starts late at night and extends into the next day, but no other sessions exist on that day. I'll publish a new release shortly.

Is this resolved? Just released a new version.

Thanks for looking into this so quickly!
It seems to be fixed when I restart the container without rebuilding it?
I also rebuilt the container from the source repo, so hopefully it's fixed.
I'll reopen this issue if it comes up again.

Hey @milesmcc I'm facing the same issue again, using the latest version.

shynet_main  | ERROR Internal Server Error: /dashboard/
shynet_main  | Traceback (most recent call last):
shynet_main  |   File "/usr/local/lib/python3.9/site-packages/django/core/handlers/exception.py", line 47, in inner
shynet_main  |     response = get_response(request)
shynet_main  |   File "/usr/local/lib/python3.9/site-packages/django/core/handlers/base.py", line 181, in _get_response
shynet_main  |     response = wrapped_callback(request, *callback_args, **callback_kwargs)
shynet_main  |   File "/usr/local/lib/python3.9/site-packages/django/views/generic/base.py", line 70, in view
shynet_main  |     return self.dispatch(request, *args, **kwargs)
shynet_main  |   File "/usr/local/lib/python3.9/site-packages/django/contrib/auth/mixins.py", line 52, in dispatch
shynet_main  |     return super().dispatch(request, *args, **kwargs)
shynet_main  |   File "/usr/local/lib/python3.9/site-packages/django/views/generic/base.py", line 98, in dispatch
shynet_main  |     return handler(request, *args, **kwargs)
shynet_main  |   File "/usr/local/lib/python3.9/site-packages/django/views/generic/list.py", line 157, in get
shynet_main  |     context = self.get_context_data()
shynet_main  |   File "/usr/src/shynet/dashboard/views.py", line 39, in get_context_data
shynet_main  |     service.stats = service.get_core_stats(
shynet_main  |   File "/usr/src/shynet/core/models.py", line 116, in get_core_stats
shynet_main  |     main_data = self.get_relative_stats(start_time, end_time)
shynet_main  |   File "/usr/src/shynet/core/models.py", line 203, in get_relative_stats
shynet_main  |     chart_data, chart_tooltip_format, chart_granularity = self._get_chart_data(
shynet_main  |   File "/usr/src/shynet/core/models.py", line 295, in _get_chart_data
shynet_main  |     chart_data[k["date"]]["hits"] = k["count"]
shynet_main  | KeyError: datetime.date(2021, 9, 12)

killing/restarting docker-compose doesn't fix it for me.

It looks like old code.
There is an if statement in line 295 in "/usr/src/shynet/core/models.py" in latest code.
https://github.com/milesmcc/shynet/blob/03ced00f631281163d2a907656fba1e8729040cb/shynet/core/models.py#L295
Maybe there is something wrong with docker image?

Yeah I believe the issue here is that I haven't officially made a new release for v0.11 yet. I'll do that this weekend. In the meantime, the milesmcc/shynet:edge tag should have the fix.


Widgets error

Type: Bug
I see Error occured on these three bttons so I can't run my app even if I write the required properties ,
FlatButton(),
RaisedButton(),
Outlinebutton(),
VS Code version: Code 1.74.2 (e8a3071ea4344d9d48ef8a4df2c097372b0c5161, 2022-12-20T10:29:14.590Z)
OS version: Windows_NT x64 10.0.19045
Modes:
Sandboxed: Yes

System Info

Item
Value

CPUs
Intel(R) Core(TM) i3-4005U CPU @ 1.70GHz (4 x 1696)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_renderer: enabled_onvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: disabled_off

Load (avg)
undefined

Memory (System)
3.92GB (0.78GB free)

Process Argv
C:\Users\user\Desktop\flut_dev\tataboq_app\lib\main.dart --crash-reporter-id cd9275ec-60b5-44c5-b5e7-cc56a9027869

Screen Reader
no

VM
0%

Extensions (6)

Extension
Author (truncated)
Version

askia-qexml-generator-extension
Ask
1.0.1

dart-code
Dar
3.56.0

flutter
Dar
3.56.0

plcc-plugin
dav
0.16.2

batch-rename-extension
Jan
0.0.6

vscode-typescript-next
ms-
5.0.202212300

A/B Experiments
vsliv368cf:30146710
vsreu685:30147344
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
vswsl492cf:30256860
vslsvsres303:30308271
pythonvspyl392:30443607
vserr242cf:30382550
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vsdfh931cf:30280410
vshan820:30294714
vstes263cf:30335440
vscoreces:30445986
pythondataviewer:30285071
vscod805cf:30301675
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
cmake_vspar411:30581797
vsaa593cf:30376535
pythonvs932:30410667
cppdebug:30492333
vsclangdc:30486549
c4g48928:30535728
dsvsc012:30540252
azure-dev_surveyone:30548225
vsccc:30610678
pyindex848cf:30577861
nodejswelcome1cf:30587006
3biah626:30602489
3d0df643:30613357
89544117:30613380
fim-prod:30623723
vscsb:30628654

/question
Doesn't look like issue with editor itself. At most it can be issue with Flutter (I guess) extension, but most likely you should ask this kind of questions in more suitable mediums like Stackoverflow or thematically forums/discord servers (in this case include more details about code, and errors)

/question
Doesn't look like issue with editor itself. At most it can be issue with Flutter (I guess) extension, but most likely you should ask this kind of questions in more suitable mediums like Stackoverflow or thematically forums/discord servers (in this case include more details about code, and errors)

We closed this issue because it is a question about using VS Code rather than an issue or feature request. Please search for help on StackOverflow, where the community has already answered thousands of similar questions. You may find their guide on asking a new question helpful if your question has not already been asked. See also our issue reporting guidelines.
Happy Coding!

We closed this issue because it is a question about using VS Code rather than an issue or feature request. Please search for help on StackOverflow, where the community has already answered thousands of similar questions. You may find their guide on asking a new question helpful if your question has not already been asked. See also our issue reporting guidelines.
Happy Coding!


Transect subset selection bug

PR #89 overhauled the interim transect subset selection approach initially implemented in v0.1.0-alpha. The intent was to implement the approach found in Matlab EchoPro, as described in #33.
I have found a bug that occurs in some circumstances. The bug emerged when rerunning the bootstrapping_walkthrough.ipynb notebook with the current main. PR #89 introduced a very small change to that notebook, changing the removal_percentage argument value in boot_obj.run_bootstrapping from 50.0 to 60.0. The notebook runs successfully when using 50.0, but boot_obj.run_bootstrapping results in a transect selection error when using 60.0
Currently the notebook transect_selection_workflow.ipynb runs successfully while also applying transect subsetting. But the percentage used is also 50.0%. In addition, there is a transect subsetting test, test_transect_selection.py::test_transect_selection_output, that also runs successfully; rather than a %, it uses a preselected list of transect ids.
The error happens in computation/transect_results.py::set_adult_NASC, specifically in this statement:
https://github.com/uw-echospace/EchoPro/blob/9dc4708b409f9b0a71897dd06a690d26eb1a2e8d/EchoPro/computation/transect_results.py#L1272-L1274
It's a KeyError (eg, "KeyError: '[6] not in index'") generated when nasc_fraction_adult_df is missing a stratum number found in self.nasc_df.stratum_num. As described in #33, when a subset of transects is requested, the reduced transect set may not contain all possible stratum_num. A scheme is needed to backfill values for the "missing" strata. The scheme introduced in v0.1.0-alpha and described in #33 under "Current solution for missing strata" followed some simple rules Brandon and I devised to fill or interpolate missing strata. PR #89 replaced that strategy with the more involved (and possibly opaque?) scheme used in the Matlab EchoPro code. However, for transect_results.py::set_adult_NASC, it looks like the missing-strata scheme was overlooked. The variable nasc_fraction_adult_df is created based on the strata found in self.bin_ds.len_age_dist_all, then its values are populated by looping over those strata in a for loop. Therefore, when strata are missing in self.bin_ds.len_age_dist_all, they are never backfilled in nasc_fraction_adult_df, which leads to the error. Note: self.bin_ds is an Xarray Dataset that contains stratum_num as a dimension and coordinate variable; self.bin_ds.len_age_dist_all contains that dimension.
This error has nothing to do with bootstrapping per se. But because bootstrapping generates several realizations of a transect subset, it more easily led to the error condition.

I implemented a fix to handle missing strata that is based on the scheme previously used (ie, before Brandon's changes leading up to v0.3.1) and reuses a variable that was already available, self.stratum_choices. For missing strata, this variable is prepopulated with the neighboring strata (1 or 2, I think) that can be used to populate the missing strata. Here's what I implemented in PR #99:
https://github.com/uw-echospace/EchoPro/blob/9dc4708b409f9b0a71897dd06a690d26eb1a2e8d/EchoPro/computation/transect_results.py#L1261-L1267
I also added a test that runs through multiple realizations of transect subset selection:
https://github.com/uw-echospace/EchoPro/blob/9dc4708b409f9b0a71897dd06a690d26eb1a2e8d/EchoPro/tests/computation/test_transect_selection.py#L13

The bug itself was addressed in release 0.3.1. Transect subset selection works again. But there is more work to be done to identify and implement the desired scheme for backfilling missing strata. This will be done in release 0.3.2.

This was partially addressed in release 0.3.1, but more work is needed. I'll retag it as release 0.3.2.


Convert "category" filter from checkboxes to a multiselect

Replace category checkboxes with a multiselect in filterable list controls.
Changes

Updated the categories field in forms.py. Django is telling me no migrations are necessary.
Many of the Cypress tests clicked on the (former) category checkboxes. They've been updated.

How to test this PR

Visit the blog page and the categories should be a multiselect instead of checkboxes.
Cypress tests should pass.

Screenshots

before
after

Notes and todos

https://github.com/cfpb/design-system/pull/1247 needs to be merged and released to allow the multiselect dropdown to spill outside the expandable.

Checklist

[x] PR has an informative and human-readable title

PR titles are used to generate the change log in releases; good ones make that easier to scan.
Consider prefixing, e.g., "Mega Menu: fix layout bug", or "Docs: Update Docker installation instructions".

[x] Changes are limited to a single goal (no scope creep)
[x] Code follows the standards laid out in the CFPB development guidelines
[x] Future todos are captured in comments and/or tickets
[x] Project documentation has been updated, potentially one or more of:

This repo’s docs (edit the files in the /docs folder) – for basic, close-to-the-code docs on working with this repo
CFGOV/platform wiki on GHE – for internal CFPB developer guidance
CFPB/hubcap wiki on GHE – for internal CFPB design and content guidance

Front-end testing

Browser testing
Visually tested in the following supported browsers:

[x] Firefox
[x] Chrome
[x] Safari
[x] Edge 18 (the last Edge prior to it switching to Chromium)
[x] Internet Explorer 11 and 8 (via emulation in 11's dev tools)
[x] Safari on iOS
[x] Chrome on Android

Accessibility

[x] Keyboard friendly (navigable with tab, space, enter, arrow keys, etc.)
[x] Screen reader friendly
[x] Does not introduce new errors or warnings in WAVE

Other

[x] Is useable without CSS
[x] Is useable without JS
[x] Does not introduce new lint warnings
[x] Flexible from small to large screens

Moreso than in https://github.com/cfpb/consumerfinance.gov/pull/6494, we need to release https://github.com/cfpb/design-system/pull/1247 and bump the DS here, right?


🎉 New Example: 3ATHJ6G4/123123123123123123123123.md

New Example: 3ATHJ6G4/123123123123123123123123.md
Please preview this example on the netlify deploy-preview bellow 🌻.

Rejected


Ensure that after tests are run no test files are left in the disk

After running each test we must ensure that there are no files left on disk created by the test itself

The tearDown ensures all files are deleted after testing.


Support full document export as a bitmap format or SVG.

Also, fixes a bug in document content bounds computation to make clipping work correctly for layer comps and full document export.
@jaredadobe Review please?

This looks good to me, travis CI doesn't think so though.

Fixed the travis issue. And fixed some JSDoc comments. Please merge if y'all are happy with it.

Do you mind squashing all the commits into 1. Other than that it looks good!

@chrisbank No problem! Squashed.

looks good, merging. thanks!


Add v1.2 conformance report table

What type of PR is this?
/area conformance
/kind documentation

What this PR does / why we need it:
With 3 implementations conformance reports uploaded for v1.2, updating the table
Which issue(s) this PR fixes:

Fixes #3395
Does this PR introduce a user-facing change?:

NONE

hey @xtineskim thanks for fixing this !
can we also get Kong's results in (https://github.com/kubernetes-sigs/gateway-api/pull/3426) ?

Thanks @xtineskim!
/lgtm

/approve


Add docker

Is your feature request related to a problem? Please describe
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

Further information needed.

Further information needed.

For Support Docker files.. Easy to deploy in vps 😖😖


Search Space of Tuner

I'm confused of the quniform type. I expect it acts like range.
For example, for _value as [0.3,1.5,0.2] the output should be [0.3, 0.5, 0.7, 0.9, 1.1, 1.3].
But when I set _value as [0.3, 1.5, 0.2], the parameters are [0.3, 0.4, 0.6, 0.8, 1.0, 1.2, 1.4, 1.5], set _value as [0.3, 0.6] the parameters are [0.3, 0.4, 0.6, 0.8, 1.0, 1.2, 1.4, 1.6].

@colorjam - thanks for the feedback. Your understanding is basically right, may you share the search space file you are using?
Refer to the following doc for definition:
https://github.com/microsoft/nni/blob/master/docs/en_US/Tutorial/SearchSpaceSpec.md

I’m closing this issue as it has no updates from user for 3 months, please feel free to reopen if you are still seeing it an active issue.


Unable to upgrade SolrClouds from v0.2.6 to v0.2.7

Describe the bug
When the Solr Operator is upgraded to v0.2.7 from a previous version, and SolrClouds already exist in the cluster, they are unable to be updated or managed after the upgrade.
Reason why it fails
2 fields were added to the SolrCloud Status in v0.2.7, and unfortunately were not made optional. The result of this is that SolrCloud objects that were created in v0.2.6 or before do not have values for these status fields. When the v0.2.7 operator starts up, the SolrCloud controller will try to reconcile existing SolrClouds. It will then try to set defaults for the Spec fields as the first action in the Reconcile loop, but when it sends the update to Kubernetes it is rejected because the Status fields are not defined, and a regular update does not affect the Status sub-resource.
Simple fix: make the 2 new status fields optional.
To Reproduce
Steps to reproduce the behavior:

Install the Solr Operator v0.2.6
Install a SolrCloud
Install the Solr Operator v0.2.7
Look at the logs

Expected behavior
The expected behavior is that the Reconcile loop works after the update.

Note: This error only occurs when upgrading the CRDs before upgrading the operator.

Note: This error only occurs when upgrading the CRDs before upgrading the operator.

Upgrading to v0.2.8 solves this issue.

Upgrading to v0.2.8 solves this issue.


[Maintenance] Add sitemap and metadata to the repository

this would be a primary setup or one-time investment kind of issue where in we need to come up with an obvious and standard way of incorporating metadata about the documentation/pages on our website for improving the SEO visibility. the ideal deliverables would be as follows:

[x] exploring open graph protocols and their standard inclusions in our pages.
[x] enforcing or mandating all the pages to have sitemap/metadata about the page. although, not sure about enforcing, but it is something we need to comply to and the actions workflows must check as part of the status check. it would ideal to have an automated way to open an issue whenever a new page is committed and doesn't have the metadata information in it. this could be it's own dedicated task and should be considered for actions workflow.

have started including the necessary metadata to the pages. the issue is now ready for testing and review.


Fixed/dasboard/UI

Related Issue(s)
Fixes #36  Resolves # Closes #

Proposed Changes

[x]

Checklist

[x] I have followed the repository's contribution guidelines.
[x] I have added necessary documentation or updated existing documentation.
[x] My code follows the established code style and formatting of the project.
[x] I have tested my changes and they function as expected.
[ ] I have added suitable unit tests (if applicable).

Screenshots

To-Do

[ ]

Additional Information

i dont think i got it @techyNonso we can book a call later today for corrections


Front door lock no longer relaying when it has been left unlocked since update 2023.3.4

The alarmdotcom maintainers don't have direct access to all Alarm.com devices. We need your help to support new devices.
Please open one issue per device.
Which device would you like us to support?
Provide the device name and a link to a page with device details.
(E.g.: Intelligent Thermostat: https://suretyhome.com/product/intelligent-thermostat/)
Where does this device appear in the Alarm.com mobile app?
Security System, Images, Locks, Garage Doors, etc.
What types of actions does this device support?
E.g.: Garage doors support opening and closing. Alarm systems support arming (home, away, and night modes) and disarming.
Which provider do you use?
E.g.: Alarm Net, ADT, Surety Home, etc.
Include pyalarmdotcomajax Server Output
This is an important step. It's helpful for us to see how this device is represented on the Alarm.com server. We have a tool for dumping this data via the command line.

Install Python >= 3.9.
Install pyalarmdotcomajax via pip: pip install pyalarmdotcomajax.
Run adc -u YOUR_USERNAME -p YOUR_PASSWORD -c YOUR_2FA_COOKIE -vx
The above command dumps server data for all devices that are known to ADC developers, including a few devices that are currently unsupported. Heads Up! This command may leak sensitive information. It does not dump your email address, address, or any other account information, but it may output coordinates from GPS devices (like an Alarm.com car sensor) and names of family members (e.g.: Michael's Room Window Sensor). Be sure to review the data before posting to scrub anything that you're not comfortable posting online.

Include Action Endpoints
This is a more technical than the last step, but in order to support actions for devices we need you to use a tool like Wireshark of Fiddler Classic to tell use which endpoints the Alarm.com app uses to control these devices. For example, for a garage door, we would need the following information:

Base URL: https://www.alarm.com/web/api/devices/garageDoors/
Open Suffix: open
Close Suffix: close

(Opening a garage door requires submitting a request to https://www.alarm.com/web/api/devices/garageDoors/open.)

Dupe of #234


Issue processing your payment

After clicking "Pay Online" from the email:
Private Zenhub Image
if the total is not divisible by two, we see this issue:
Private Zenhub Image
Link to issue:
https://payments.dev.foirequests.gov.bc.ca/public/form/paymentlanding/foirequest/14128/14151/2222?trnApproved=0&messageText=Validation Error&pbcTxnNumber=FOID00002222&trnAmount=Amount can have maximum two decimal places

the payment link goes to paybc: https://paytest.gov.bc.ca/public/directsale?trnDate=2023-09-21&pbcRefNumber=10012&glDate=2023-09-21&description=Direct_Sale&trnNumber=FOID00002222&trnAmount=120.14999999999999&paymentMethod=CC&redirectUri=https%3A%2F%2Fpayments.dev.foirequests.gov.bc.ca%2Fpublic%2Fform%2Fpaymentlanding%2Ffoirequest%2F14128%2F14151%2F2222&currency=CAD&revenue=1%3A112.32041.35301.1278.3200000.000000.0000%3A120.15&hashValue=1a16e914ae0ee9b72d57c9611bc24fb9

as per @lmullane this can club with recaptcha task for fee payment


rawpy not installing

Doing a pip install rawpy installs a package that is lacking a lot of stuff:
Python 3.7.10 | packaged by conda-forge | (default, Feb 19 2021, 15:59:12)
[Clang 11.0.1 ] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import rawpy
>>> dir(rawpy)
['__builtins__', '__cached__', '__doc__', '__file__', '__loader__', '__name__', '__package__',
'__spec__', 'black_level_correction', 'color_correction_matrix', 'gamma_correction',
 'get_raw_array', 'main', 'math', 'np', 'preview_demosaic', 'process', 'rawpy', 'read',
'sys', 'white_balance', 'write']
>>>

I used for this test a pristine conda environment created with conda create --name test python=3.7, to which I only installed rawpy with the pip command above. What am I missing? Or is the PyPi distribution broken somehow?
I am on Mac OS 10.15.7.

Found the problem. Sorry for using an issue slot....


Moving files to parent folder gives error

I'm trying to move files from a subfolder to process.cwd() but when I try, it gives an ENOTEMPTY error.
{ [Error: ENOTEMPTY, rename '/Users/wouter/Dev/project-templates/project-template/bin/']
  errno: -66,
  code: 'ENOTEMPTY',
  path: '/Users/wouter/Dev/project-templates/project-template/bin/' }

It seems like it's trying to rename the cwd (as I'm testing the cli I'm working on in the bin folder directly). The same thing happens when I use npm link and test it in a newly created test directory.
@andrewrk am I missing a setting or something, or is this just not possible with mv?

+1 I get another error but is when trying to move a folder one level up (Like moving to ../)
fs.js:310
  binding.stat(pathModule._makeLong(path), req);
          ^

TypeError: path must be a string or Buffer
    at Object.fs.exists (fs.js:310:11)
    at Object.destExists (...)
(...)/node_modules/node-mv/index.js:50:76
    at FSReqWrap.cb [as oncomplete] (fs.js:312:19)

FYI,
I was having this problem and solved it using another npm module, copy-dir-cli. Simple but works great!


[TA] TLS Cert Generation for Multiple Target Allocator Services

Issue #, if available:
Currently, we cannot support TLS for target allocator because TLS certs are not accepting TA service as a valid dns. This PR dynamically generates the TA service dns' for each agent that uses TA.
Description of changes:

Updated Cert Manager to generate TA dns.
Updated key generation to generate TA dns.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Can you show that this works?


Error 401 Unauthorized

I did everything according to the instructions, and gives an error 401
what's wrong
Client error: POST https://discord.com/api/oauth2/token resulted in a 401 Unauthorized response:
{"error": "invalid_client"}

Hello. I tried to install it and it's working as expected on my end. Can you describe how you've set it up?

I did a little stupid thing, everything didn't work for me, I was looking for where the code breaks
It turned out to be on line 42, I started looking for an error and constantly displayed this error
I had to delete line 41-43 and everything worked
Sorry for wasting your time) Thank you

No worries! I'm glad you managed to fix it.


Enums autocomplete to dictionary methods

Godot version: 3.1 561a777
Issue description: Typing an enum's name dot doesn't autocomplete to the keys but rather to dictionary methods:

@vnen: I do think enums should be a bit more special than just constant dictionaries, at least with respect to autocomplete and gdscript errors/warnings. For example, you can call A.clear() without problem, shouldn't this at least raise a warning?

Yes, it would be nice if enum would autocomplete to the actual enum keys.

This is a regression in 3.1 as this bug did not exist in Godot version 3.0.6


Update funding.yml

Pull Request Test Coverage Report for Build 911

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 57.881%

Totals

Change from base Build 909:
0.0%

Covered Lines:
918

Relevant Lines:
1586

💛  - Coveralls


doc/getting_started: mention ZEPHYR_TOOLCHAIN_VARIANT=host briefly

Skipping the setup of a toolchain is especially nice for brand new users
who just want to give qemu_x86[_64] or native_posix a quick try, gives a
great first impression.

Codecov Report

Merging #13336 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #13336   +/-   ##
=======================================
  Coverage   48.76%   48.76%
=======================================
  Files         319      319
  Lines       46892    46892
  Branches    10840    10840
=======================================
  Hits        22867    22867
  Misses      19391    19391
  Partials     4634     4634

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9072d34...cba074b. Read the comment docs.

This definitely doesn't work on OS X, please note that.

Thanks @marc-hb !


fastapi 0.65 support

There is a fastapi 0.65.1 available

Already updated in master. I'll make a release soon.


Object Reference Not Set To An Instance of an Object

Recently, my Legacy Games library titles are no longer being detected.  I tried uninstalling and reinstalling the Legacy launch -and- your plugin, but I keep getting this error when I try to refresh my Legacy library in Playnite:
Failed to get Legacy Games games: Object reference not set to an instance of an object.
I've made sure to install at least one title.

playnite.log
extensions.log

It's choking on something in your %APPDATA%\legacy-games-launcher\app-state.json file. Could you send it after redacting your personal details? Sort of like this
What to redact:

Windows username from gameDownloadPath
Every field in the user object at the end of the file except for the downloads section (order_id can be redacted too though)

redacted app-state.json.txt

Thanks! This should be fixed in the latest release.
Apparently there's a few bundles that have no games field at all, among them the Rubek (sign up) bonus game. You own another bundle that is also Rubek though, so this shouldn't cause issues with games missing from the import.
Let me know how you fare with it now.

It seems to work!  It imported 4 titles, then seemed to pause for about a minute before quickly importing the rest.
Side note on a different quirk: while testing early, I

Uninstalled all Legacy titles
Uninstalled the Launcher
Uninstalled the plug-in for Playnite
Delete the plug-ins data directories

When reinstalling the Launcher and plugin, I still couldn't update my library -- but the titles that had been previously read were displayed in Playnite under the Legacy section.  That is, deleting the games, launcher, plugin, and plugin data seemed to leave the titles (or phantom) entries in Playnite.  Is this supposed to happen?

Playnite never deletes games unless you tell it to, and library extensions normally don't delete games either. This is mostly to not have your games (that you spent some time on editing) deleted because, say, Steam had an outage and returned an empty games list.

Ah -- I assumed it was something like that. I wasn't seeing the entries after removing the plug-in, so I was confused... but I assume they are in the general Playnite "titles" database.

Yeah if you remove a library plugin the games have a library plugin ID field that doesn't have a corresponding plugin, so it doesn't have a plugin to pull the library name from anymore. Anyway glad it's fixed now!


Dispatch users to workers according to their performance

Is your feature request related to a problem? Please describe.
When running multiple workers on different machine, they may not have the same performance (e.g. different cpu cores). A boomer is able to use multiple cpu cores. It will be better if a more performant machine runs more users.
Describe the solution you'd like
A worker can report a number in client_ready message, that will be used as a factor when dispatching users. For locust worker, the number is always 1.
For example, worker A runs on a machine with 4 cpu cores, worker B runs on a machine with 2 cpu cores. When the master want to spawn 6 users, worker A will run 4 users and worker B will run 2 users.
Describe alternatives you've considered

Additional context

What would be the down side of just running more worker processes on the machine with more cores?


spec: modifying maps during (sort of) a range operation unclear

What version of Go are you using (go version)?
N/A, but 1.13
Does this issue reproduce with the latest release?
Sure.
What operating system and processor architecture are you using (go env)?
N/A
What did you do?
https://play.golang.org/p/jX-Bp63JDHX
What did you expect to see?
I have no idea. This is a spec question, really. I'm writing it because I brought this up in a couple of places and ended up with a significant range of intuitions and answers from experienced and competent developers, ranging from "that will work" to "that won't work" to "that might work". I think it should perhaps be clearer whether or not this is "safe" -- could this code produce a race condition or concurrency failure?
If you have a range loop on a map, and unsynchronized writes to the map, that's a clear violation -- you can't read the map while it's being written to.
But let's say, hypothetically, that you want to range over a map slowly -- say, for a low priority background cleanup task. You don't want to run the entire thing with a lock held preventing the map from being updated. You could, of course, lock the map, grab a slice of keys, unlock it, and iterate the keys.
But why would you do something sane like that when you can do something insane?
Enter the example code: Grab a lock, start a range loop, and then inside the body of the loop, release the lock, operate on the k/v pair, and grab the lock again right before resuming at the range statement. Each evaluation of the range statement happens with the lock held. If the same lock controls modifications to the map, that's... maybe... safe?
I can't tell whether it's safe. I think it probably is, not because the spec says so, but because the spec says something that implies it, I think:

The iteration order over maps is not specified and is not guaranteed to be the same from one iteration to the next. If a map entry that has not yet been reached is removed during iteration, the corresponding iteration value will not be produced. If a map entry is created during iteration, that entry may be produced during the iteration or may be skipped. The choice may vary for each entry created and from one iteration to the next. If the map is nil, the number of iterations is 0.

This suggests that map entries may be removed or created during iteration, which implies that the range statement is expected to function at least somewhat if there's creation or deletion while it's running. It's less obvious whether the creation or deletion will be reliable. Imagine for instance that we have a map with a hundred items, we iterate through 90 of them, and then we add a thousand more items, causing the entire map to get grown and rehashed at least once. Do I reliably expect to see the other 10 items that were in it before I started? I have no idea. It looks to me like the current implementation is at least trying to handle that case carefully, and indeed, I can't make it fail; I always hit every item that was present when the range statement started and hasn't been deleted yet, but don't necessarily hit any new items.
I can't tell whether I'm safe or (un?)lucky.

Iteration with locking like you do is fine.  The spec doesn't say anything explicit about this, but the iteration description doesn't have any weasel words about "except when synchronizing" or "deletes must happen in the same goroutine as the iterator" or anything. The iteration behavior meets the spec regardless of what the body of the loop does, or where any inserts/deletes might come from. The only exception is the general language exception "if there is a data race, any behavior is valid".
I guess the spec doesn't say "map iteration returns each key/value pair exactly once, except..." after the first sentence there. I feel like it is kind of implied - how could iteration be at all useful otherwise?

https://github.com/golang/go/issues/9926#issuecomment-74989255 <-- someone in gopher slack pointed at this, which is possibly relevant.
(I note also in the code, there's specific code to handle the possibility that a key the iterator wants to look at has been removed and since re-added, possibly with a different key value which compares equal, such as +0.0 and -0.0.)

I'm not sure there is a bug here.  Is there some way that we could make the spec clearer?
Note that in general we don't use the issue tracker for discussion.  See https://golang.org/wiki/Questions.  Thanks.

Oh, hey, sorry about that, wasn't aware of the Questions thing.
I think the spec could be clearer. For instance, it appears that in fact the iterator really does reliably hit everything that was present when it started (and doesn't get deleted), even if resizes and rehashing have happened, and that's surprising to enough people I asked that it might be worth clarifying that it's guaranteed, if indeed it is. (I'm still not even entirely sure how the iterator can be sure this happens, but I can't break it, so.)


Fix PHP 7.4 notice

This resolves #251.
Notice: Trying to access array offset on value of type null

Thanks!

Thank you! This was starting to bug me :)


#10918 Use currently active project

Not sure it should work like this..

This PR does not handle situations when we're editing ERD from another project.
Maybe we should ask the diagram what project it's from instead of relying on currently active project?


Updated dependencies

Code compiles cleanly but need some guidance on the 5 tests that failed

@tdonovancsra There appears to be some conflicts you need to resolve before merging.

Closing in favor of #77.


Add Lumen Support

Prevent lumen from registering blade directives, so lumen can work with it.

It seems that the dev-master has fixed it, close.


Issue192

Fixes #192.
It's catching all possible controller exceptions and logging them.
If/when we know more details about why they happen, we might want to catch only those and do something different.
In some cases we might want to return different to what it's now returned.
This solution is almost the same as just letting the Exception raise.
It seems that we could also use add_status_listener [0] to the controller, though i'm not sure now which functions we should call in the different situations.
[0] https://stem.torproject.org/api/control.html#stem.control.BaseController.add_status_listener

First easy thing I noticed is that the changelog entry is in the wrong section. It should be in Unreleased, not 0.5.0. You'll have to add the ### Changed section to Unreleased.
I'll still do a better review.

i wasn't happy with my own solution on catching all the possible exceptions, so i'm being less lazy, checking possible exceptions in https://stem.torproject.org/api/control.html, and catching only those.
If we run into some other exception, then probably it means we need to modify something else.
But catching concrete exceptions, makes thing i should probably replace log.exception to some other level, since we know which is the exception, it's not needed to log the full trace.

In https://github.com/pastly/simple-bw-scanner/blob/master/sbws/lib/circuitbuilder.py#L91, why did you add exceptions as CircuitExtensionFailed?, according to https://stem.torproject.org/api/control.html, that's not there, though the documentation might not be complete.
I probably should remove https://github.com/pastly/simple-bw-scanner/pull/222/files#diff-814bf53a84b89545a05dd2761603efc4R96, since you're catching there possible exceptions for that method

I did as i commented, please let me know if you prefer i leave Exception or if you prefer i squash commits or change something else.

i wasn't happy with my own solution on catching all the possible exceptions, so i'm being less lazy, checking possible exceptions

I'm glad. This is way better IMO.

In [circuitbuilder.py when building a new circuit], why did you add exceptions as CircuitExtensionFailed?

Because stem's new_circuit calls extend_circuit which can raise that exception. I saw it in the wild and added it to the list of exceptions.


gnome-mpv: 0.9 → 0.13

Motivation for this change
update + meson port
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

This was the final straw :-) I've configured my mail agent to recognize → as an alternative indicator of package update PRs.


Fix failing tests

This:

fixes the implementation of RTN15h2
fixed test regressions related to the addition of RTN15h2
fixes a bug introduced in a previous PR about the values passed in the Accept header

See https://github.com/ably/ably-ios/commit/abba1492e8a929221d55550471a6b80554f08d06


Allow to provide a reporter to the Server

Hi,
I'm trying to add tests for my server class and to do that I need to pass a reporter mock. It's possible only with BaseServer, but Server class builds reporter on it's own.
class MyServer extends Server {
 ...
}

new MyServer(options, reporterMock) // it doesn't work

The solution could be to inherit from BaseServer and copy-paste the bootstrap code from Server
class MyServer extends BaseServer {
 ...copy paste Server code here
}

new MyServer(options, reporterMock) // it works!

What do you think about adding an option to override reporter in Server class as well? Or maybe compose Server with BaseServer instead of inherit from it?

I like the idea too override reporter in Server, good idea.
Please send PR.


Chapter 17 - Exercise 4

Dear @bewuethr
running the executable (after compiling with -std=c++11 or -std=c++14) a pointer being freed was not allocated error is obtained, coming from
https://github.com/bewuethr/stroustrup-ppp/blob/fe98f3c9edd651d1c3f8528db45b54b6f6cb1a7a/chapter17/chapter17_ex04.cpp#L22
Best,
Marco

I wrote this with a pre-C++-11 compiler, does the problem go away with -std=c++98?

No, it doesn't. The issue stems from the fact that we cannot call delete[] on s, as it has not been allocated with new. Also, the destructor of std::string already cleans up the memory when the object goes out of scope. If you remove that line, it runs just fine, with no memory leaks

Ah, great, I'll update later today!

Thanks :-)


"Unable to create a refactoring" when trying to MOVE_FILE

This may be related to #32701, but I think that's just a bad error whereas I think my request here is good (so it's bad that the error is vague, but I think there shouldn't be an error). I'm trying to rename a file with MOVE_FILE but I get this error back (v2.0.0-dev.63.0).
{
	"id": "134",
	"method": "edit.getRefactoring",
	"params": {
		"file": "/Users/dantup/Dev/Dart-Code/test/test_projects/hello_world/lib/create_method/class_a.dart",
		"kind": "MOVE_FILE",
		"length": 0,
		"offset": 0,
		"options": {
			"newFile": "/Users/dantup/Dev/Dart-Code/test/test_projects/hello_world/lib/create_method/class_a_222.dart"
		},
		"validateOnly": false
	}
}
{
	"id": "134",
	"result": {
		"initialProblems": [
			{
				"severity": "FATAL",
				"message": "Unable to create a refactoring"
			}
		],
		"optionsProblems": [],
		"finalProblems": []
	}
}

(cc @bwilkerson @scheglov)
Also; does this API support moving/renaming a folder or do I have to list the files and send individual requests?

This refactoring is not implemented currently.

Doh! I pushed to get an API in VS Code to give us a notification before the rename (based on the docs for this) assuming it already existed =)
In that case, when it is implemented, could we make it support directories so we don't have to send a load of events when a directory is renamed?

That sounds reasonable to me.
I don't know how big a task it will be to write this refactoring, but I know that it isn't currently on the schedule for Q3. (Unless you have time to take a look at it.)

I'll certainly try! I have a few biggish things coming up that I'm not sure how much time they'll take, but I'd really like to deliver this so I'll definitely try and find time.
I guess like the standard rename should a good example of producing edits I can look at; but is there anything that does something like finding all the imports/part statements I could use? Probably we'd need to enumerate them all and resolve relative paths to figure out which ones point at the file(s)/folder(s) being renamed. Actually; maybe the standard rename does similar if all the references aren't indexed?
I guess I can do some digging and list some questions.

I guess like the standard rename should a good example of producing edits I can look at ...

Actually, analysis_server/lib/src/services/refactoring/extract_widget.dart would be a better example. We are switching our code to use the DartChangeBuilder (analyzer_plugin/lib/utilities/change_builder/change_builder_dart.dart) to build edits, but the rename refactoring hasn't been updated yet.

... is there anything that does something like finding all the imports/part statements I could use?

@scheglov would know this better than I. I know we have code to search for references to identifiers, but I don't know whether we have something similar for references to files.

Great, thanks! I'll try and find some time to dig in :-)

@bwilkerson @scheglov Any opinions on this? I have code that looks like:
// Update outgoing references inside this file
await changeBuilder.addFileEdit(library.source.fullName, (builder) {
  final oldDir = pathContext.dirname(oldFile);
  final newDir = pathContext.dirname(newFile);
  _updateUriReferences(builder, library.imports, oldDir, newDir);
  _updateUriReferences(builder, library.exports, oldDir, newDir);
  _updateUriReferences(builder, library.parts, oldDir, newDir);
});

This is to create edits for a file being moved (eg. to fix relative paths inside it). Currently a test fails when the renamed file had no relative imports/exports/paths because we return an "empty edit" instead of "no edit" (because of the first line). It feels clumsy to have to pre-scan all the imports/exports/parts to figure out if we need any edits for this file before calling addFileEdit (because we end up enumerating them twice; because we can't nicely store the edits up without introducing some data type to hold them).
Is it reasonable to make changeBuilder not emit any edits that were empty or something?

Or maybe in change_childer_core.dart addFileEdit could skip adding the change if it didn't get any edits:
verride
Future<Null> addFileEdit(String path, void buildFileEdit(FileEditBuilder builder)) async {
  FileEditBuilderImpl builder = await createFileEditBuilder(path);
  buildFileEdit(builder);
+ if ((builder.fileEdit.edits?.length ?? 0) > 0) {
    _change.addFileEdit(builder.fileEdit);
+ }
  await builder.finalize();
}

Is it reasonable to make changeBuilder not emit any edits that were empty or something?

I've thought about this before, and debated with myself about how best to support this case. I had a concern about whether the behavior you proposed would be surprising, but I tend to think that that's outweighed by the principle that it should be hard for clients of an API to do the wrong thing, and emitting an empty file edit seems wrong on some level. So, in general, I'm in favor of this proposal.
That said, I think it's a little harder to implement correctly than your proposed change because the invocation of finalize can add new edits. (At the moment it's being used to add import directives, which is unlikely to happen if there were no other edits, but isn't impossible. Also, we might want to delay adding other edits for a different purpose in the future, and I'd rather leave that possibility open.) And, if I recall correctly, finalize currently assumes, in a fairly subtle way, that the file edit has already been added to the change.
If the latter proves to be wrong, then we could move the invocation of finalize before the add and everything should work. If not, then we probably need to introduce a new shouldBeAdded method to FileEditBuilderImpl that would return true if (a) there are existing edits or (b) the finalize method would add any edits. (Doing the latter might be easier than figuring out whether the subtle order dependency actually exists. :-)

Also, we might want to delay adding other edits for a different purpose in the future, and I'd rather leave that possibility open

That's valid; I thought the edits were being copied from the builder in this line, but it actually just keeps a reference, so they may be edited later - however that means they'd happen after finalize - I'm not sure if that could cause other issues.
I've had a look, but I'm not sure of the best way to handle this. We could possibly strip them out further up (eg. in getRefactoring() in edit/edit_domain.dart) but the further up it's done, the more likely it'll need repeating in other code. We could also add an alternative addFileEdit (eg. conditionallyAddFileEdit or something), or maybe create a new builder for each file and then add a way to append one builder onto another. Nothing sounds ideal; but lmk what your preference is.
Ofc, we could also just pre-check the imports here, but it probably means if either enumerating twice or building the list into an alternate data structure, and that seems messier.

I started trying to explain what I was thinking about, but realized I was writing the code, so I put it together in a CL (https://dart-review.googlesource.com/c/sdk/+/63901).

Great; thanks! 👍

As you noticed, that CL causes some of the server tests to fail. They're failing because we're expecting to return an empty, but otherwise validly formed SourceFileEdit from the experimental edit.importElements request, but with this change we're not producing a source file edit at all.
I think that there are two options. The first is to not commit this CL and to require clients to confirm that an edit will be made before invoking addFileEdit. The other is to make the source file edit optional (in the request's result) and require clients to test to see whether one exists (rather than to just iterate over an empty list). I'm fine with either, but thought some discussion might be good before making a decision.

Hmm, neither seem ideal. For checking whether we'll create an edit first, we need to scan through imports/exports/parts/etc. and see if any of them uris in them will require updating - but we can't update them. To avoid enumerating twice, we'd end up keeping track of the edits in an alternative data structure, which feels like it somewhat undermines the edit builder.
Maybe we could make it optional in addFileEdit? Eg. an allowEmptyEdit or omitEmptyEdit named param? Or if the cases where we do want it are always likely to be where there was a single file edit, maybe an addSingleFileEdit method that always added (or another method to work the other way)? It'd definitely be nice if the API made it easy to use whichever way you wanted. If in future there were many places that did it both ways, we should avoid either option requiring too much additional work.

The more I think about it, the more I like the idea of changing edit.importElements to have an optional SourceFileEdit. We have been fairly consistent about making possibly empty collections optional in order to reduce (a) the time required to serialize and deserialize them and (b) the number of bytes being sent across the wire. I think that making it optional is perfectly consistent.

Ok cool; are you going to update the tests in your CL or do you want me to take a look?

I'll upload an update to my CL after I get home.

This was resolved by @jwren. VS Code can't use it yet because the required APIs are marked provisional (so we can't publish extensions that use them) but I plan to ship once they un-flag them.


Close connection on ban

The conman branch (see #4551) currently lacks the capability to terminate an active connection, making bans severely lack in bite.
To add this functionality, the juliet RPC interface will need to be extended to allow for clean error injection on the JulietRpcClient. The io layer should have this capability already, so it is hopefully only a matter of exposing it.

PR open at https://github.com/marc-casperlabs/casper-node/pull/11

Done as of https://github.com/casper-network/casper-node/pull/4604


Odd error message

When comparing a []byte to nil via BeCalled(With(...)) we got this odd error message:
Test Panicked
          runtime error: comparing uncomparable type []uint8
          /usr/local/go/src/runtime/panic.go:423

          Full Stack Trace
          /usr/local/go/src/runtime/alg.go:250 (0x2f2a)
                efaceeq: panic(errorString("comparing uncomparable type " + *t._string))
          /Users/bob/gobal/src/github.com/apoydence/eachers/becalled.go:65 (0x134f73)
                (*Called).Match: if call[i] != recvd {
          /Users/bob/gobal/src/github.com/onsi/gomega/internal/asyncassertion/async_assertion.go:110 (0x1ea98a)
          /Users/bob/gobal/src/github.com/onsi/gomega/internal/asyncassertion/async_assertion.go:48 (0x1e9e98)
          /Users/bob/gobal/src/foo/bar.go:77 (0x87870)
                glob.func<IP_ADDRESS>.3: Eventually(mockPublisher.PublishInput.Value).Should(BeCalled(With(bytes)))

Not very obvious from the error message what the problem is.

I fact this test fails even if a valid []byte is read from mockPublisher.PublishInput.Value.


Proposed Vertica CE module (JDBC, Data Warehouse) - MVP for discussion

This is a minimal viable product for discussion of a Vertica CE database / data warehouse module - it starts the docker container and successfully performs a test query but does nothing beyond that. See issue 9242
No TLS support.
No Data Warehouse related tests. (I'm not sure we'll ever need them - it may be enough to run the standard JDBC database tests.)
I didn't realize that the 'community edition' license is much more restrictive than typical - we'll need to investigate that. I'm hopeful we can arrange a perpetual carveout since this will be useful to their customers... but we can't be sure. However we'll probably have better luck once I get everything fixed so the PR is ready to go once we have a clear license.

Closing this PR as we will not be able to run the container because we don't have a License. There are other alternatives here


test: correct test assumption for Windows paths

The Windows file system path representation \ is a drive letter
relative path.  That is, the same path can be used across multiple
drives (similar to the concept of alternate roots).  We expect that
the path returned is [[:letter:]]: or [[:letter:]]:[\\/] rather
than the Unix /.  Adjust the expectation.

@swift-ci please test Linux platform


Extension is not working for file:// url under Firefox 78

Hi,
If I'm open a local static html page in my browser (Firefox 78.0) with your plugin in enabled with the following code :
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN"
  "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="fr" lang="fr">
  <head>
    <meta charset="UTF-8">
    <script>
      // Vanilla
      var httpRequest = new XMLHttpRequest();
      httpRequest.onreadystatechange = function(data) {

      };
      httpRequest.open("GET", "test.txt");
      httpRequest.send();
    </script>
  </head>
  <body>
  </body>
</html>

It generates the following message in the console :
Cross-Origin Request Blocked: The Same Origin Policy disallows reading the remote resource at file:///home/jerome/Drive/Perso/2020/07_cors_firefox78/test.txt. (Reason: CORS request not http).
https://developer.mozilla.org/fr/docs/Web/HTTP/CORS/Errors/CORSRequestNotHttp

You can try this:
Cross-Origin Request Blocked when loading local file
privacy.file_unique_origin = false
security.fileuri.strict_origin_policy = false
But no guarantee.

I just checked with firefox 78.0.2... and now it works. I close the issue.


Idea report results

It may be a good idea to add a configuration that allows you to export a report of the results so you can analyze it and see the progress

Duplicate of #28


clspv does not handle struct padding correctly due to the way it handles chars

typedef struct {
  int x;
  int y __attribute((aligned(16)));
} s;

__kernel void foo(__global s* in, __global s* out) {
  out->x = in->x;
}

LLVM generates the struct for s as { i32, [12 x i8], i32, [12 x i8] }. During SPIR-V generation, we emit i8 as i32 so we effectively have { i32, [12 x i32], i32, [12 x i32] }. This is bad enough, but we also generate the offset decorations based on the LLVM struct so we have offsets: 0, 4, 16 and 20.

The way I'm implementing #208 could likely fix this case in a similar fashion.

Also worth noting that the ArrayStride for those arrays is output as 1 instead of 4

Given https://github.com/google/clspv/pull/303, is this still live?

I think general char support fixes this, but requires -int8. Perhaps leave this till #296 is closed.


patch: Add GHA Build Test Deploy workflows

Adds build deploy test workflow

[x] Create PR with all devices supported
[x] Set deploy environment to balena-cloud.com
[ ] Disable the associated multi-job and device jobs in Jenkins
[ ] All required devices are passing on GHA + doesn't require a rebase
[ ] Approved by the reviewer (policy-bot passed)
[ ] Update branch protection to require the GHA workflows
[x] Remove Jenkins build and deploy workflow (this PR)

Signed-off-by: Vipul Gupta (@vipulgupta2048) <EMAIL_ADDRESS>

@vipulgupta2048 before retrying tests, doesn't the first commit need Changelog-entry in it?


Feature: Set MinMag 7.0 for Crustal Inversion TargetMFDs

Hardwired for now, similar to Subduction MFDs

Superceded by #30


Fallback to Token metadata when the metadata is not accessible via the Contract entity

Description
There are many ERC20 contracts where the Safe Transaction Service holds the token metadata available (displayName, logoUri) in the /token/{address} endpoint, but it's missing on our /contract/{address} endpoint.
Requirements

When the metadata is not available for a Transaction Service Contract, try to gather it from the Transaction Service ERC20 Token entity.

This should be done on a case by case (decision on the caller). This functionality is already provided by the AddressInfoHelper.
Is the issue then related with a specific feature or use-case? 🤔

The main goal would be to have the same metadata that is available on the transactions mappings (which use AddressInfoHelper as you pointed out) when calling the Contract endpoint directly (/v1/chains/:chainId/contracts/:contractAddress) if I'm not wrong. On that flow, AddressInfoHelper plays no role.
I guess the clients could host this logic (fallback to one or another entity) if we provide a /token/:tokenAddress endpoint (mimicking the Transaction Service), but the CGW doesn't provide it. So I think it's a fair question if we prefer to "combine" both sources or provide a second endpoint and let the clients implement the fallback.


Support for angular material md-checkbox

I have use your plugin before and it work very well and now I decided to use angular material and found out that the check for element input and type checkbox are prevent us from using the checklist model with md-checkbox directive. To make it work again I have to remove the logic below to allow me to use your plugin. since angular material are gaining more usage is it a good idea to include a support for this ?

Hello, is there any plans to merge this one? Or to support md-checkbox in any way? Thanks!

I'd love to see this happen too

I added the additional check for md-checkbox, instead of removing the whole  check.

Would you be able to provide another pull request with an example to include it in the examples?


UX: Misleading error message on presumably valid metadata

I ran datalad catalog validate -m datalad_catalog/tests/data/catalog_metadata_dataset.json and received the following error message:
[ERROR  ] Expecting property name enclosed in double quotes: line 1 column 2 (char 1) (JSONDecodeError)
metadata validation against catalog schema:   0%|                          | 0.00/245 [00:00<?, ? Lines/s]

We chatted about this in the call, and the reason for the failure is that the required format should be JSON lines, not JSON with line breaks (which is something that is not caught by tests, as the respective test transforms the JSON into JSON lines before). The function should learn how to handle JSON with line breaks, or output a better error message.

This issue is solved by subsequent changes to the catalog-* commands, mainly by using constraints from datalad-next


Echo cancellation

hi, thanks for the wicked package!
I cant find an option in audio session configuration to enable echo cancellation and am wondering if i'm missing it or if its named something different / not implemented
thanks

Hi, this package wraps the underlying native APIs for AudioManager and AVAudioSession. If you can find any method in either of those that you would like me to wrap, I can add it.

Here is the link for the android API: https://developer.android.com/reference/android/media/audiofx/AcousticEchoCanceler
for IOS there does not seem to be a straight forward API like android but I found this thread on the IOS developer forum which seems to achieve the same effect: https://forums.developer.apple.com/forums/thread/97679

That is not within the scope of this API. It's not within AudioManager. You might want to look at another plugin called just_audio which implements audio effects. If that doesn't suit your requirements, then you need a new plugin.


Gif not responsive on slide

1.Go to https://v.redd.it/pxqdliddrsz71 slide

Attempt to play it

Tested on iPhone SE 2nd gen
iOS 15.1
Latest app version


Feature/issue 877 cassandra support p1

Fixes #877
As disscussed in #4556, this first PR adds cassandra module

I'll review it soon, and will have a look to the existing comment too.
Thanks for being patient :-)

Thanks a lot for your work here @Yourgene
Few comments from my side but it's ok
If you don't have time to fix it today, I'll fix it to merge and prepare the next release with Cassandra :)

Thanks a lot for your work here @Yourgene Few comments from my side but it's ok If you don't have time to fix it today, I'll fix it to merge and prepare the next release with Cassandra :)

Thanks for your review and comments :)
I'll have time this afternoon to make requested changes

@pascalgrimaud seems good to me.
If you're satisfied with the current state, I'll squash the commits for the merge

Great work @Yourgene !!!

Hi, I claimed the bug bounty for this PR : link

@Yourgene : approved

@pascalgrimaud Thank you :)


Remove the test db dir after deleting the storage in CPP unittest

Related unit test failure: https://github.com/apache/incubator-kvrocks/actions/runs/4464571751/jobs/7840932442#step:11:171

Thanks all, merging...


Typeahead not highlighted when using arrows

You can see it in the demo by typing "al" in the input, then by pressing two times the arrow down and finally by pressing enter. You will see "California" appear in the input so the use of the arrow is working but there is no highlight inside the dropdown showing that this is working.

That is because Foundation's CSS does not have a style for dropdown items with the active class, only on hover. You'll need to style this yourself in CSS.


raise err IOError: [Errno socket error] [Errno 110] Connection timed out

I came across this error when i tried this the second time
ymd@ymd:~/tensorflow-mnist-tutorial$ python mnist_1.0_softmax.py
I tensorflow/stream_executor/dso_loader.cc:135] successfully opened CUDA library libcublas.so.8.0 locally
I tensorflow/stream_executor/dso_loader.cc:135] successfully opened CUDA library libcudnn.so.5 locally
I tensorflow/stream_executor/dso_loader.cc:135] successfully opened CUDA library libcufft.so.8.0 locally
I tensorflow/stream_executor/dso_loader.cc:135] successfully opened CUDA library libcuda.so.1 locally
I tensorflow/stream_executor/dso_loader.cc:135] successfully opened CUDA library libcurand.so.8.0 locally
Traceback (most recent call last):
File "mnist_1.0_softmax.py", line 39, in
mnist = read_data_sets("data", one_hot=True, reshape=False, validation_size=0)
File "/home/ymd/anaconda2/lib/python2.7/site-packages/tensorflow/contrib/learn/python/learn/datasets/mnist.py", line 211, in read_data_sets
SOURCE_URL + TRAIN_IMAGES)
File "/home/ymd/anaconda2/lib/python2.7/site-packages/tensorflow/contrib/learn/python/learn/datasets/base.py", line 208, in maybe_download
temp_file_name, _ = urlretrieve_with_retry(source_url)
File "/home/ymd/anaconda2/lib/python2.7/site-packages/tensorflow/contrib/learn/python/learn/datasets/base.py", line 165, in wrapped_fn
return fn(*args, **kwargs)
File "/home/ymd/anaconda2/lib/python2.7/site-packages/tensorflow/contrib/learn/python/learn/datasets/base.py", line 190, in urlretrieve_with_retry
return urllib.request.urlretrieve(url, filename)
File "/home/ymd/anaconda2/lib/python2.7/urllib.py", line 98, in urlretrieve
return opener.retrieve(url, filename, reporthook, data)
File "/home/ymd/anaconda2/lib/python2.7/urllib.py", line 245, in retrieve
fp = self.open(url, data)
File "/home/ymd/anaconda2/lib/python2.7/urllib.py", line 213, in open
return getattr(self, name)(url)
File "/home/ymd/anaconda2/lib/python2.7/urllib.py", line 350, in open_http
h.endheaders(data)
File "/home/ymd/anaconda2/lib/python2.7/httplib.py", line 1038, in endheaders
self._send_output(message_body)
File "/home/ymd/anaconda2/lib/python2.7/httplib.py", line 882, in _send_output
self.send(msg)
File "/home/ymd/anaconda2/lib/python2.7/httplib.py", line 844, in send
self.connect()
File "/home/ymd/anaconda2/lib/python2.7/httplib.py", line 821, in connect
self.timeout, self.source_address)
File "/home/ymd/anaconda2/lib/python2.7/socket.py", line 575, in create_connection
raise err
IOError: [Errno socket error] [Errno 110] Connection timed out
i'm a fresh man on python and tensorflow,and i will be so pleased if you could tell me how to make it right.

I found the answer,i can't download mnist data from website.

indeed, the site seems to be down again.
You can download the file manually from here.
When you please the files in to a folder named "data", the script will not try to download them.


Handle None as an input value in template tags

Related to https://github.com/marksweb/django-bleach/pull/9
Due to bleach no longer accepting None as an input, django-bleach will throw exceptions if None is passed in. To maintain the existing behavior check for None in the templatetags.

@pegler Thanks for this, I thought I'd written some tests for this recently when doing the python 3.8 changes but maybe they didn't get merged/pushed.


Flip-Flopping Truths/lies

The "facts" and "lies" should be made to reverse randomly in meaning ever few minutes depending a representation of Trump's mood

This feature would definitely improve this programming language.

@xctrumpet23 On it. 😎


⚠ Quirk Club Argentina (Payment Gateway) has degraded performance

In 2b04dde, Quirk Club Argentina (Payment Gateway) (https://us-central1-quirkclub-dev.cloudfunctions.net/api/check/payment-gateway-ml) experienced degraded performance:

HTTP code: 200
Response time: 10509 ms

Resolved: Quirk Club Argentina (Payment Gateway) performance has improved in 0b6d0de.


Support shorthand form builder types

In form builder you can pass actual values and not form controls to everything expect form controls of arrays and of course actual form groups/areays.
In the form builder type I think it should allow passing a regular value (unless it an array) instead of always requiring to create form controls.
Of course I could also pass a form control if I want validations

Could you please provide some code example and expected behavior?

If you mean array syntax, like
fb.group({
    name: ['', Validators.required],
    quantity: [1, [Validators.required, Validators.min(1)]],
});

This is not supported and is not planned for the near future.

I meant:
fb.group({
    name: 'abc',
    quantity: 1
});

VS
fb.group({
    name: fb.control('abc'),
    quantity: fb.control(1)
});

Need to think about this propose, but it is not a type script related thing, need to write a js runtime wrapper for this. Ok, i'll think about it, thank you!


[BUG] Invalid regex behavior

Nutgram version
3.16.0
Describe the bug
Regexp doesn't work correctly
 $bot->onText('https://(www\.)?[a-z]{2}', function (Nutgram $bot) {
            $bot->sendMessage('url correct');
        });

Incorrect handling of {2}
Here:
SergiX44\Nutgram\Handlers\Handlers.php;
line: 74
$regex = '/^'.preg_replace(self::PARAM_NAME_REGEX, '(?<$1>.*)', $pattern).'?$/miu';

Currently only works like this: {2,2}
To Reproduce
See in description
Expected behavior
See in description
Screenshots
No response
Additional context
No response

Please give us more context.

You must specify a strict number of characters {2} or any other number.
The pattern is being processed in the file:
SergiX44\Nutgram\Handlers\Handlers.php;
line: 71
/**
     * regular expression to capture named parameters but not quantifiers
     * captures {name}, but not {1}, {1,}, or {1,2}.
     */
    protected const PARAM_NAME_REGEX = '/{((?:(?!\d+,?\d+?)\w)+?)}/';

$pattern = '{2}';
$regex = '/^' . preg_replace(self::PARAM_NAME_REGEX, '(?<$1>.*)', $pattern) . '?$/miu';

not true
result: '/^(?<2>.*)?$/miu'
$pattern = '{2,2}';
$regex = '/^' . preg_replace(self::PARAM_NAME_REGEX, '(?<$1>.*)', $pattern) . '?$/miu';

result: '/^{2,2}?$/miu'


Basic form

👷 Deploy Preview for zippy-otter-3c7f8b processing.

Name
Link

🔨 Latest commit
3f39d6795333061c9277357a6894f467b4c1100f

🔍 Latest deploy log
https://app.netlify.com/sites/zippy-otter-3c7f8b/deploys/6379ef0eff20b0000972e8b4


Config naming confusion

Now that all of our classes are inheriting from traitlets Configurable, they have a config property. What we didn't notice is that Viz objects in the VL spec also have a config property. These two notions of config are completely separate, but have the same property names, which conflixts. To get around this I have called the VL config property Viz/vlconfig but make sure that it still gets serialized to config in to_dict. I am not too fond of this, but don't have a better idea at this point. Any ideas?
@jakevdp @wrobstory @tacaswell

That's a tough one... I'll think about it a bit.

That will make things difficult if we want to pass the python objects into render rather than the exported dictionaries.

Great point Thomas. I can write a small class that is like Configurable and
has a different name for this. Maybe settings?
On Sun, Sep 20, 2015 at 3:19 PM, Thomas A Caswell<EMAIL_ADDRESS>wrote:

That will make things difficult if we want to pass the python objects into
render rather than the exported dictionaries.
—
Reply to this email directly or view it on GitHub
https://github.com/ellisonbg/altair/issues/53#issuecomment-141841166.

--
Brian E. Granger
Associate Professor of Physics and Data Science
Cal Poly State University, San Luis Obispo
@ellisonbg on Twitter and GitHub
<EMAIL_ADDRESS>and<EMAIL_ADDRESS>

Maybe settings?

+1 on that.

In the revised API in master swe are no longer using Configurable at all so there is no conflict.


[CMAKE] [BAZEL] Need to import some pipelines in other MLIR Project

Request description
Remove Bazel and use MLIR/CIRCT project style cmakelist.txt.
What component(s) does this issue relate to?
No response
Additional context
We are experimentaly deploying iree to some dataflow devices
Is there any plan to remove Bazel which is not friendly for other MLIR poject? I tried on libireecompiler.so but failed.
Is there any way to import some of the pipelines from IREE such as buildStableHLOInputConversionPassPipeline() in  iree/compiler/plugins/input/StableHLO/Conversion/Passes.h?
I always got error like: ld.lld: error: undefined symbol
because it is hidden:
~/workspace/tasks/magic$ readelf -sW ./third_party/iree/build/install/lib/[libIREECompiler.so](http://libireecompiler.so/) | grep registerStableHLOConversionPasses
  5465:<PHONE_NUMBER>d38b60   664 FUNC    LOCAL  HIDDEN    13 _ZN4mlir13iree_compiler9stablehlo33registerStableHLOConversionPassesEv

You don't have to use bazel - we fully support cmake.

@benvanik Really aprreciate.
But for MLIR Project, I can get link name by having name just after function add_mlir_library in cmakelists.txt .
add_mlir_library(MLIRIR
  AffineExpr.cpp
  AffineMap.cpp
  AsmPrinter.cpp

So should I use string after name in function iree_tablegen_library?
iree_tablegen_library(
  NAME
    CHLODecompositionPatterns
  TD_FILE

So I get CHLODecompositionPatterns as link name for lld, am I right?

libireecompiler.so exposes our compiler API, not all symbols.
Docs on the compiler API are here: https://iree.dev/reference/bindings/c-api/#compiler-api and a template repo showing usage is here: https://github.com/iree-org/iree-template-compiler-cmake.
If you want to use internal implementation details of the compiler, you'll need to statically link against the project and depend on the CMake (or Bazel, if you really want) libraries/targets.
You can use your CMake generator or debugger of choice to see which target names we create.

Sorry for missing these pages. I will have a look. Really appreciate.

We do want to use internal implementation details of the compiler. We were trying expose these symbol.
If we failed, we may model amd-aie for dataflow devices.

libIREECompiler.so only exposes public symbols. You are welcome to link to the internals as needed directly via cmake or bazel static deps (cmake is actively maintained, bazel gets some effort but none of the core devs can help much with it). You will of course need to deal with the usual issues that come with integrating llvm based projects.
If trying to build an iree backend that will ship with iree, there is a way to set up your project as a plug-in that will build together.

We just set IREE_STATIC_LIB_DIR and include those *.a files, it works, but we have to carefully check which to be used.


feat: simplify deployment

Description

Automate apm-web deployments. Also simplifies manual deployments.
Related Issue

How Has This Been Tested?

Testing is done after the merge.

It looks good.


Backend Structure

Opening as a continuation of #1

This is the typical Backend Structure for a MERN project:

Heres an example project for reference: Instagram MERN
This is potentially a good option for setting up our external api calls, where each api service logic has its own folder where we can host different functions in:

Please drop any other ideas in this Issue

@vee-16 reverted heading as we have labels so it would be redundant info


Did you have any thoughts on doing this for F# usages?

The same approach should work, if you want to create a how-to video as part of your series you are welcome to copy my approach or improve on it.

also with .net core 3.0 I think you can finally unload a dll, so that would be nice to incorporate


InstallService.sh causes Parliament to cycle up and down

When Parliament is installed as a systems service on CentOS (via the InstallService.sh script), the daemon will cycle up and down, over and over, rather than running continuously as a daemon should.

Fixed with merge of branch '028-daemon-cycles-up-and-down'.


add gitter room

Do we have to add the badge for the existing gitter room for qiime?

I think we're going to use a new gitter room for the QIIME 2 repo to keep discussion separate from QIIME 1.

This was superseded by the slack channel (#102).


Consider cats-scalacheck dependency to replace maually crafted instances

We'd offload the cost of maintaining our own instances of some cats typeclasses for Scalacheck data types by using Chris Davenport's cats-scalacheck library. While we'd invite a new dependency with this change, we'd also get more typeclasses and perhaps some performance boost, in addition to the win of offloading the code maintenance cost.

No instances for Arbitrary are provided, closing


0x8886 missing

I came across the blue screen 0x1A where the first parameter is 0x8886. Can you ask for a description of this parameter?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: de955911-dfbf-33b3-778a-767a5a578a0d
Version Independent ID: 23fb5cbd-5f7d-f7ca-1622-5885020966c2
Content: Bug Check 0x1A MEMORY_MANAGEMENT - Windows drivers
Content Source: windows-driver-docs-pr/debugger/bug-check-0x1a--memory-management.md
Product: windows-hardware
Technology: windows-devices
GitHub Login: @DOMARS
Microsoft Alias: domars

Looking into this

Added!

@MrPepka - This parameter description is now added, so closing this issue.


coverted pdf link to web page link

Pull Request Checklist

[x] Description:

Briefly describe the purpose and goals of the pull request.

[x] Changes Made:

Summarize the main changes introduced by this pull request.

[x] Testing:

Describe the testing that has been done, including any relevant test cases.

[x] Screenshots:

If applicable, include screenshots or animated GIFs to visually demonstrate the changes.

[x] Documentation:

Update any relevant documentation or provide information on how documentation will be updated.

[x] Reviewers:

Tag any specific team members or contributors for review.

Definition of Done

[x] Code follows the project's coding standards.
[x] Tests have been added or updated to reflect the changes.
[x] Documentation is updated.
[x] All checks and tests pass in the continuous integration environment.

coverted pdf link to web page


ubridge: 0.9.18 -> 0.9.19

Description of changes

Upgrade ubridge to 0.9.19
Migrate to pkgs/by-name
Format with nixfmt-rfc-style

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 343775 run on x86_64-linux 1

1 package built:

ubridge


utils: try to downscope builds for the runtime

This tweaks the build configuration for the runtime to downscope what we actually build to what we require. This should have a negligible improvement to the build times.

@swift-ci please test

@swift-ci please test Linux platform

@swift-ci please test macOS platform


[SPARK-12249][SQL] JDBC non-equality comparison operator not pushed down.

https://issues.apache.org/jira/browse/SPARK-12249
Currently != operator is not pushed down correctly.
I simply added a case for this.

Several things to mention.
Firstly, I did not add the tests for it because not pushed down filters are not correctly tested. I will add as soon as https://github.com/apache/spark/pull/10221 is merged.
Secondly, I just opened this PR without asking if it is really supposed to be supported. This is because I see the test codes intended to check this operator (which is not testing properly) and also I don't think there is no database not supporting this operator as it is a SQL Standard.

Test build #47459 has started for PR 10233 at commit 6cdd5f3.

Test build #47459 has finished for PR 10233 at commit 6cdd5f3.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/47459/
Test PASSed.

Merged build finished. Test PASSed.

I updated the test for this since https://github.com/apache/spark/pull/10221 is merged.

Test build #47779 has started for PR 10233 at commit 33f67e7.

cc @rxin @marmbrus

Test build #47779 has finished for PR 10233 at commit 33f67e7.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):\n  * case class WrapOption(child: Expression, optType: DataType)\n

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/47779/
Test PASSed.

cc @rxin @marmbrus

Thanks - I've merged this into master.


Add constructor for Signup

It is quite inconvenient to get a Signup form if one requires an username parameter in addition to password and email.

I am not 100% sure if i understand your problem, but you can signup/create a user via the Auth RequestGuard:
auth.users.create_user(email, password, false).await?;


Rule proposal: keyword argument before star arguments

Python disallows f(kw=a, b), f(**a, b), and f(**a, *b), but for some reason it does not disallow f(kw=a, *b), which has an unexpected evaluation order as of 3.5 (python/cpython#100549). We could add a warning for this.

Sounds reasonable!


Generator function didn't preserve needed nodes, copying old replacements back in instead.

Please make sure that this is a bug. As per our GitHub Policy, we only address code/doc bugs, performance issues, feature requests and build/installation issues on GitHub. tag:bug_template
System information
ubuntu 16.04 /
python 3.6 /
tf 1.14.0 /
onnx 1.6.0
Describe the current behavior
I want to convert siamfc network pb model to onnx model.
I build tensorflow siamfc project  from https://github.com/bilylee/SiamFC-TensorFlow.git.
after a lot of step ,I got .ckpt.* file successfully, then I freeze to pb file.
this is a part of network below:

then,I need to convert to onnx model.
by this cmd:
python -m tf2onnx.convert --input=./siamfc-edit.pb --inputs=inference/examplar_input:0,inference/instance_input:0 --outputs=inference/detection/add:0 --opset=11 --continue_on_error --fold_const --output=siamfc-edit.onnx --verbose
I think this cmd is correct, because I can convert a lot of other network successfully.
but when it convert , a lot of warning come up ,and never stop.
so that I can't convert to onnx .the warning is below
......
2019-11-28 17:19:56.308150: W tensorflow/tools/graph_transforms/transform_utils.cc:448] Generator function didn't preserve needed nodes, copying old replacements back in instead.
2019-11-28 17:19:56.309946: W tensorflow/tools/graph_transforms/transform_utils.cc:441] Expected convolutional_alexnet/conv2/b2/BatchNorm/beta/read/_10__cf__10 to be preserved.
2019-11-28 17:19:56.309960: W tensorflow/tools/graph_transforms/transform_utils.cc:441] Expected convolutional_alexnet/conv2/b2/BatchNorm/gamma/read/_11__cf__11 to be preserved.
2019-11-28 17:19:56.309975: W tensorflow/tools/graph_transforms/transform_utils.cc:441] Expected convolutional_alexnet/conv2/b2/BatchNorm/moving_mean/read/_12__cf__12 to be preserved.
2019-11-28 17:19:56.309983: W tensorflow/tools/graph_transforms/transform_utils.cc:441] Expected convolutional_alexnet/conv2/b2/BatchNorm/moving_variance/read/_13__cf__13 to be preserved.
2019-11-28 17:19:56.310000: W tensorflow/tools/graph_transforms/transform_utils.cc:448] Generator function didn't preserve needed nodes, copying old replacements back in instead.
2019-11-28 17:19:56.319616: W tensorflow/tools/graph_transforms/transform_utils.cc:441] Expected convolutional_alexnet/conv3/BatchNorm/beta/read/_15__cf__15 to be preserved.
2019-11-28 17:19:56.319670: W tensorflow/tools/graph_transforms/transform_utils.cc:441] Expected convolutional_alexnet/conv3/BatchNorm/gamma/read/_16__cf__16 to be preserved.
2019-11-28 17:19:56.319678: W tensorflow/tools/graph_transforms/transform_utils.cc:441] Expected convolutional_alexnet/conv3/BatchNorm/moving_mean/read/_17__cf__17 to be preserved.
2019-11-28 17:19:56.319686: W tensorflow/tools/graph_transforms/transform_utils.cc:441] Expected convolutional_alexnet/conv3/BatchNorm/moving_variance/read/_18__cf__18 to be preserved.
2019-11-28 17:19:56.319718: W tensorflow/tools/graph_transforms/transform_utils.cc:448] Generator function didn't preserve needed nodes, copying old replacements back in instead.
2019-11-28 17:19:56.323429: W tensorflow/tools/graph_transforms/transform_utils.cc:441] Expected convolutional_alexnet/conv4/b2/BatchNorm/beta/read/_25__cf__25 to be preserved.
2019-11-28 17:19:56.323456: W tensorflow/tools/graph_transforms/transform_utils.cc:441] Expected convolutional_alexnet/conv4/b2/BatchNorm/gamma/read/_26__cf__26 to be preserved.
2019-11-28 17:19:56.323464: W tensorflow/tools/graph_transforms/transform_utils.cc:441] Expected convolutional_alexnet/conv4/b2/BatchNorm/moving_mean/read/_27__cf__27 to be preserved.
2019-11-28 17:19:56.323471: W tensorflow/tools/graph_transforms/transform_utils.cc:441] Expected convolutional_alexnet/conv4/b2/BatchNorm/moving_variance/read/_28__cf__28 to be preserved.
2019-11-28 17:19:56.323479: W tensorflow/tools/graph_transforms/transform_utils.cc:448] Generator function didn't preserve needed nodes, copying old replacements back in instead.
......
so what's wrong with it or me?
I expect to know what's this warning mean,I found there are a lot of identity op as input op share for other op.

does it because of this?
I look forward to your reply . thanks a lot.

Hi There,
We are checking to see if you still need help on this, as you are using an older version of tensorflow which is officially considered end of life . We recommend that you upgrade to the latest 2.x version and let us know if the issue still persists in newer versions. Please open a new issue for any help you need against 2.x, and we will get you the right help.
This issue will be closed automatically 7 days from now. If you still need help with this issue, please provide us with more information.


Add toggle buttons to support GMT.jl, PyGMT, and GMTMEX equivalent scripts

Tracking this feature request raised in https://github.com/GenericMappingTools/gmt-examples/pull/1

The tab-set directive in sphinx-design is a good option.


Add Au test for strategies.yaml, with consistent hashing, with fallover.

Cherry-picked to v9.1.x branch.


Create uvvnet.txt

Hi, please add this university Vila Velha of Brazil (Universidade Vila Velha) in your folders. Thanks. Domain: @uvvnet.com.br. The webmail site is webmail.uvvnet.com.br.

http://uvvnet.com.br/
looks like the school is under http://www.uvv.br/Default.aspx

the school site is this, the link I spent is her webmail. The<EMAIL_ADDRESS>is the email domain.
School website: www.uvv.br
Webmail: webmail.uvvnet.com.br
Email Domain: @uvvnet.com.br
In github: br/com/uvvnet.txt
Thanks for respond.


Migration MT-ST new field is aded in payload for export endpoint 20.13

Pull Request summary:
Added new field  [is_destination_overlay_mt ] in the payload in MT-> ST migration.
Description of changes:
class MigrationTenant(Tenant):
is_destination_overlay_mt: Optional[bool] = Field(alias="isDestinationOverlayMT")
Checklist:

[x] Make sure to run pre-commit before commiting changes
[x] Make sure all checks have passed
[x] PR description is clear and comprehensive
[x] Mentioned the issue that this PR solves (if applicable)
[x] Make sure you test the changes

This issue was migrated from an old repository: https://github.com/CiscoDevNet/catalystwan/pull/369


Configuring JmxTrans Agent to pull from custom diagnostic jmx connection provided by jasperserver reports

jaspserserver reports allows access to diagnostic information via jmx through a custom URL
service:jmx:rmi://localhost/jndi/rmi://:10990/jasperserver
when using this via jconsole or java mission control you need to provide a username and password for the application.
Is there a way to add this into the jmxtrans config to access this type of data?
thanks we really love this agent

Sounds more like a question for the JmxTrans google group. That being said, if you use the JmxTrans agent, it should be able to retrieve information without authentication as it is running in the same JVM (I have not actually checked this, but fairly sure it is the case: PlatformMBeanServer is used in JmxTransExporter).

thanks....opened up the diagnostic jmx to platformMBeanServer and it displays just like everything else....I will remember to put this stuff on the group from now on.


Trustlines: Integrate new canAddTrustline bool

@keybase/picnicsquad CC @keybase/react-hackers
Fixes being unable to add a trustline to an account with >three digits of XLM in, because there was a string >= number compare happening.

@buoyad Thanks -- that might be okay since I think I fixed the black bar in #18101, and the requirement's supposed to be for >0.5 XLM so 1 XLM is fine.  I'll re-test once these fixes are in.

@cjb IIRC it needs to be 0.5XLM in addition to the 1XLM minimum balance, this was a black bar on hitting 'Accept', not the one in #18101