1080p60fps not available with DASH enabled

I'm using the developer build 461 as a GM script on firefox 34.0.5. media.mediasource.enabled is set to true, media.mediasource.ignore_codecs is set to false. DASH is enabled, other settings can be seen here: https://imgur.com/a/hUdiu
I'm not getting 1080p60 in videos that offer that format, only 720p at 30fps. Normal 1080p 30fps videos are still available in 1080p. I'm aware that DASH is needed for 1080p video, but I can't get the 60 fps working. If I set media.mediasource.ignore_codecs to true, the video will play in 1080p60, but weird thing starts to happen, like the video progress will read 0:00/0:00, then they will both count up at the same time to 0:01/0:01, 0:02/0:02, etc. The video will end after about 20 seconds regardless of how long the actual video is.
I was able to play 1080p60 with this setting before, but then I restarted my computer and then it stopped working.
Any help is appreciated.

Works nicely on Nightly 64bit on Windows 8.1 64-bit. Can you check with Nightly? Based on the bug tracking for FF MSE support, mainline/stable support is still incomplete, and that's why it's preffed as disabled in stable versions.

Current Firefox stable versions don't work properly with 1080p30fps and 60fps in html5 player. This is not a YTC problem, it is a Firefox limitation.

Quite. Firefox 34 does not support MSE + H.264. In the future, to see what your browser supports, visit
https://www.youtube.com/html5
As this issue is not related to YTC, could OP please close this issue report.
Thanks.

Using Nightly solves the problem, but since it's not a stable release, so there are some issues with normal web browsing.
I'm really wondering how it worked with the exact same settings before, but now I can't replicate the results.

Ppossibly a change at Google.. Welcome to webapps: no changelogs anywhere public, no announcements, nothing, just.. something changed.

@raywu2478 That's because whenever the html5 jams in stable firefox, it stays jammed/bugged until you revert the about:config changes you mentioned, restart firefox and re-enable them again.


Error After Upgrade React-router and react-router-dom to 6.0.0-beta.0

Version
6.0.0-beta.0
Test Case
after upgrade react-router-dom to version 6.0.0-beta.0 it raise this error:
./node_modules/react-router/index.js
Module not found: Can't resolve 'history' in '.\node_modules\react-router'

Steps to reproduce
Just Upgrade to latest beta version
Expected Behavior
Use navigate instead of history

You have to install the history package as well. Check the install instructions on the release notes: https://github.com/ReactTraining/react-router/releases/tag/v6.0.0-beta.0


Insufficient information provided to diagnose configuration and certificate errors

Expected behavior
K9 should connect to my email server
Actual behaviour
K9 gives: Cannot connect to server (Unable to connect)
Initially it worked..although auto sync every minute didn't work. Googling that it at least one user reported that this problem was caused by setting up the account over wifi and was advised to set up with wifi off (yes..really !). So, I tried this, although k9 has no way of editing account settings that i can see, so I reinstalled and tried again with wifi off. Doesn't connect. Reinstall again and try over wifi again.  Have spent 2 hours or so with this. Connects using opera from desktop, the same connection is verified by https://www.wormly.com/test_pop3_mail_server as follows:
Resolving hostname...
Connecting...
S:+OK Dovecot ready.
C: CAPA
S:+OK
S:CAPA
S:TOP
S:UIDL
S:RESP-CODES
S:PIPELINING
S:AUTH-RESP-CODE
S:USER
S:SASL PLAIN LOGIN
S:.
C: USER ewan+telesense.co.uk
S:+OK
C: PASS XX_DELETED_XX
S:+OK Logged in.
C: QUIT
S:+OK Logging out.
POP3 test completed successfully.
Debug output:
11-11 12:50:40.085 I/k9      (26759): Loading preferences from DB into Storage
11-11 12:50:40.110 I/k9      (26759): Creating Storage database
11-11 12:50:40.126 I/k9      (26759): Preferences load took 41ms
11-11 12:50:40.126 I/k9      (26759): Preferences storage is zero-size, importing from Android-style preferences
11-11 12:50:40.127 I/k9      (26759): Committing preference changes
11-11 12:50:40.131 I/k9      (26759): Preferences commit took 4ms
11-11 12:50:40.141 I/k9      (26759): Registered: unmount receiver
11-11 12:50:40.141 I/k9      (26759): Registered: shutdown receiver
11-11 12:50:40.143 V/k9      (26759): Registering content resolver notifier
11-11 12:51:21.022 I/k9      (26759): Committing preference changes
11-11 12:51:21.040 I/k9      (26759): Preferences commit took 18ms
11-11 12:53:11.282 E/k9      (26759): Error while testing settings
11-11 12:53:11.282 E/k9      (26759): com.fsck.k9.mail.MessagingException: Unable to connect
11-11 12:53:11.282 E/k9      (26759): 	at com.fsck.k9.mail.store.Pop3Store$Pop3Folder.open(Pop3Store.java:396)
11-11 12:53:11.282 E/k9      (26759): 	at com.fsck.k9.mail.store.Pop3Store.checkSettings(Pop3Store.java:264)
11-11 12:53:11.282 E/k9      (26759): 	at com.fsck.k9.activity.setup.AccountSetupCheckSettings$1.run(AccountSetupCheckSettings.java:125)
11-11 12:53:11.282 E/k9      (26759): Caused by: javax.net.ssl.SSLHandshakeException: Handshake failed
11-11 12:53:11.282 E/k9      (26759): 	at com.android.org.conscrypt.OpenSSLSocketImpl.startHandshake(OpenSSLSocketImpl.java:429)
11-11 12:53:11.282 E/k9      (26759): 	at com.android.org.conscrypt.OpenSSLSocketImpl.waitForHandshake(OpenSSLSocketImpl.java:682)
11-11 12:53:11.282 E/k9      (26759): 	at com.android.org.conscrypt.OpenSSLSocketImpl.getInputStream(OpenSSLSocketImpl.java:644)
11-11 12:53:11.282 E/k9      (26759): 	at com.fsck.k9.mail.store.Pop3Store$Pop3Folder.open(Pop3Store.java:324)
11-11 12:53:11.282 E/k9      (26759): 	... 2 more
11-11 12:53:11.282 E/k9      (26759): Caused by: javax.net.ssl.SSLProtocolException: SSL handshake aborted: ssl=0x7bed948e40: Failure in SSL library, usually a protocol error
11-11 12:53:11.282 E/k9      (26759): error:100000f7:SSL routines:OPENSSL_internal:WRONG_VERSION_NUMBER (external/boringssl/src/ssl/tls_record.c:192 0x7be36b9f76:0x00000000)
11-11 12:53:11.282 E/k9      (26759): 	at com.android.org.conscrypt.NativeCrypto.SSL_do_handshake(Native Method)
11-11 12:53:11.282 E/k9      (26759): 	at com.android.org.conscrypt.OpenSSLSocketImpl.startHandshake(OpenSSLSocketImpl.java:357)
11-11 12:53:11.282 E/k9      (26759): 	... 5 more
11-11 12:54:08.031 E/k9      (26759): Error while testing settings
11-11 12:54:08.031 E/k9      (26759): com.fsck.k9.mail.MessagingException: Unable to connect
11-11 12:54:08.031 E/k9      (26759): 	at com.fsck.k9.mail.store.Pop3Store$Pop3Folder.open(Pop3Store.java:396)
11-11 12:54:08.031 E/k9      (26759): 	at com.fsck.k9.mail.store.Pop3Store.checkSettings(Pop3Store.java:264)
11-11 12:54:08.031 E/k9      (26759): 	at com.fsck.k9.activity.setup.AccountSetupCheckSettings$1.run(AccountSetupCheckSettings.java:125)
11-11 12:54:08.031 E/k9      (26759): Caused by: javax.net.ssl.SSLHandshakeException: Handshake failed
11-11 12:54:08.031 E/k9      (26759): 	at com.android.org.conscrypt.OpenSSLSocketImpl.startHandshake(OpenSSLSocketImpl.java:429)
11-11 12:54:08.031 E/k9      (26759): 	at com.android.org.conscrypt.OpenSSLSocketImpl.waitForHandshake(OpenSSLSocketImpl.java:682)
11-11 12:54:08.031 E/k9      (26759): 	at com.android.org.conscrypt.OpenSSLSocketImpl.getInputStream(OpenSSLSocketImpl.java:644)
11-11 12:54:08.031 E/k9      (26759): 	at com.fsck.k9.mail.store.Pop3Store$Pop3Folder.open(Pop3Store.java:324)
11-11 12:54:08.031 E/k9      (26759): 	... 2 more
11-11 12:54:08.031 E/k9      (26759): Caused by: javax.net.ssl.SSLProtocolException: SSL handshake aborted: ssl=0x7bd18c38c0: Failure in SSL library, usually a protocol error
11-11 12:54:08.031 E/k9      (26759): error:100000f7:SSL routines:OPENSSL_internal:WRONG_VERSION_NUMBER (external/boringssl/src/ssl/tls_record.c:192 0x7be36b9f76:0x00000000)
11-11 12:54:08.031 E/k9      (26759): 	at com.android.org.conscrypt.NativeCrypto.SSL_do_handshake(Native Method)
11-11 12:54:08.031 E/k9      (26759): 	at com.android.org.conscrypt.OpenSSLSocketImpl.startHandshake(OpenSSLSocketImpl.java:357)
11-11 12:54:08.031 E/k9      (26759): 	... 5 more
Steps to reproduce

Enter 'Incoming Server Settings'
Click Next

Environment
K-9 Mail version:
Android version: 7.0
Account type: Pop3

I'm confused by the certificate issue. Initially it rejected cert and I accepted manually, and it connected.
Having had the problems above it occurred to me that I could remove the accepted cert and try again. I did Security > Security > Clear Credentials and did once more see the option to manually accept the cert..however I was on wifi and wanted to try this without wifi. I quit and tried again without wifi... I've since been unable to get back to the failed certificate dialogue or anything other than the failure to connect. Debug log remains unchanged as far as I can see.
Help gratefully received, I shall try not to waste any more time on this otherwise.

So there's a cert problem.. K9 2+hours of trying... gmail < 5 mins

We need to spend some time improving the UX for handling TLS errors. In the debug log above I presume you used SSL/TLS?
We should probably recommend trying STARTTLS in that specific case (I've seen it when using Office 365).
In the bad certificate case I would hope we'd see a slightly different error which tells the app that it's a certificate issue.

As for account settings it definitely does allow you to configure connection info after setting an account up. Click on an account, settings, fetching mail.
However we have too many settings / they are badly organised. So I don't blame you for this.

Yes, I was using SSL/TLS. Wrt your comments I knew there was a cert problem after the dialogue saying there was a problem and my manual acceptance of the cert. But I expected that once I'd accepted the cert manually, that would be that. Not so....
Following manual acceptance I then had
Problem 1 - Although I could manually check and retrieve email, the auto-fetch every x minutes definitely didn't work.
As above, I then tried to (reinstall and) set up the account again with wifi off. This led to
Problem 2 - I couldn't repeat the cert approval, kept getting failed connection even though I was clearing certs with Apps > Security > Clear Credentials before reinstalling. I didn't see the option to manually accept again.
I need to get the the bottom of my own server cert problem, but as things stand I can accept certs and run with polling using both gmail and myMail but not with K9.

To use K9 I would need to know a/ How to manually accept again and b/ how to fix polling. I can't produce logs for b/ without fix for a/ of course.
Cheers, Ewan

Ah, I can get further with STARTTLS, but password fail now.. will look into this and post further tomorrow.

As is, probably a mostly a duplicate of #893
But I'll leave it open because it contains a specific and slightly broader case than just certificate errors.

same here example STARTTLS on port 587 not selected but accidentially SSL/TLS
leads to misleading certificate error
Environment
K-9 Mail version: 5.403
Android version: 7.1.1
Account type: SMTP STARTTLS needed
06-11 13:03:26.486 15101 15117 I MessagingController: Scanning folder 'K9MAIL_INTERNAL_OUTBOX' (4) for messages to send
06-11 13:03:26.487 15101 15117 I MessagingController: Send count for message K9LOCAL:f930f7b7-adfa-4b6c-a00e-7364e643497c is 2
06-11 13:03:26.513 15101 15117 V LockableDatabase: LockableDatabase: Transaction ended, took 13 ms / com.fsck.k9.mailstore.LocalMessage.setFlag(LocalMessage.java:257)
06-11 13:03:26.519 15101 15117 I MessagingController: Sending message with UID K9LOCAL:f930f7b7-adfa-4b6c-a00e-7364e643497c
06-11 13:03:26.520 15101 15117 D SmtpTransport: SMTP >>> QUIT
06-11 13:03:26.586 15101 15117 D SmtpTransport: SMTP >>> QUIT
06-11 13:03:26.598 15101 15117 E MessagingController: Failed to send message
06-11 13:03:26.598 15101 15117 E MessagingController: com.fsck.k9.mail.CertificateValidationException: Handshake failed
06-11 13:03:26.598 15101 15117 E MessagingController: 	at com.fsck.k9.mail.transport.smtp.SmtpTransport.open(SmtpTransport.java:320)
06-11 13:03:26.598 15101 15117 E MessagingController: 	at com.fsck.k9.mail.transport.smtp.SmtpTransport.sendMessageTo(SmtpTransport.java:424)
06-11 13:03:26.598 15101 15117 E MessagingController: 	at com.fsck.k9.mail.transport.smtp.SmtpTransport.sendMessage(SmtpTransport.java:417)
06-11 13:03:26.598 15101 15117 E MessagingController: 	at com.fsck.k9.controller.MessagingController.sendPendingMessagesSynchronous(MessagingController.java:2607)
06-11 13:03:26.598 15101 15117 E MessagingController: 	at com.fsck.k9.controller.MessagingController$21.run(MessagingController.java:2491)
06-11 13:03:26.598 15101 15117 E MessagingController: 	at com.fsck.k9.controller.MessagingController.runInBackground(MessagingController.java:203)
06-11 13:03:26.598 15101 15117 E MessagingController: 	at com.fsck.k9.controller.MessagingController.access$000(MessagingController.java:121)
06-11 13:03:26.598 15101 15117 E MessagingController: 	at com.fsck.k9.controller.MessagingController$1.run(MessagingController.java:172)
06-11 13:03:26.598 15101 15117 E MessagingController: 	at java.lang.Thread.run(Thread.java:761)
06-11 13:03:26.598 15101 15117 E MessagingController: Caused by: javax.net.ssl.SSLHandshakeException: Handshake failed
06-11 13:03:26.598 15101 15117 E MessagingController: 	at com.android.org.conscrypt.OpenSSLSocketImpl.startHandshake(OpenSSLSocketImpl.java:429)
06-11 13:03:26.598 15101 15117 E MessagingController: 	at com.android.org.conscrypt.OpenSSLSocketImpl.waitForHandshake(OpenSSLSocketImpl.java:682)
06-11 13:03:26.598 15101 15117 E MessagingController: 	at com.android.org.conscrypt.OpenSSLSocketImpl.getInputStream(OpenSSLSocketImpl.java:644)
06-11 13:03:26.598 15101 15117 E MessagingController: 	at com.fsck.k9.mail.transport.smtp.SmtpTransport.open(SmtpTransport.java:142)
06-11 13:03:26.598 15101 15117 E MessagingController: 	... 8 more
06-11 13:03:26.598 15101 15117 E MessagingController: Caused by: javax.net.ssl.SSLProtocolException: SSL handshake aborted: ssl=0x96a71d00: Failure in SSL library, usually a protocol error
06-11 13:03:26.598 15101 15117 E MessagingController: error:100000f7:SSL routines:OPENSSL_internal:WRONG_VERSION_NUMBER (external/boringssl/src/ssl/tls_record.c:192 0xa50ce86a:0x00000000)
06-11 13:03:26.598 15101 15117 E MessagingController: 	at com.android.org.conscrypt.NativeCrypto.SSL_do_handshake(Native Method)
06-11 13:03:26.598 15101 15117 E MessagingController: 	at com.android.org.conscrypt.OpenSSLSocketImpl.startHandshake(OpenSSLSocketImpl.java:357)
06-11 13:03:26.598 15101 15117 E MessagingController: 	... 11 more
06-11 13:03:26.614 15101 15117 V LockableDatabase: LockableDatabase: Transaction ended, took 5 ms / com.fsck.k9.mailstore.LocalMessage.setFlag(LocalMessage.java:257)
06-11 13:03:26.618 15101 15117 I MessagingController: Send count for message K9LOCAL:81e4a70b-e289-482d-b8ee-af14279730dc is 2
06-11 13:03:26.637 15101 15117 V LockableDatabase: LockableDatabase: Transaction ended, took 6 ms / com.fsck.k9.mailstore.LocalMessage.setFlag(LocalMessage.java:257)
06-11 13:03:26.640 15101 15117 I MessagingController: Sending message with UID K9LOCAL:81e4a70b-e289-482d-b8ee-af14279730dc
06-11 13:03:26.641 15101 15117 D SmtpTransport: SMTP >>> QUIT
06-11 13:03:26.696 15101 15117 D SmtpTransport: SMTP >>> QUIT

I have a similar but slightly different error connecting to IMAP using SSL on Android 8.0 (Samsung):
06-24 17:45:50.259 26984  2558 E MessagingControllerPush: Caused by: javax.net.ssl.SSLHandshakeException: Handshake failed
06-24 17:45:50.259 26984  2558 E MessagingControllerPush:       at com.android.org.conscrypt.OpenSSLSocketImpl.startHandshake(OpenSSLSocketImpl.java:434)
06-24 17:45:50.259 26984  2558 E MessagingControllerPush:       at com.android.org.conscrypt.OpenSSLSocketImpl.waitForHandshake(OpenSSLSocketImpl.java:690)
06-24 17:45:50.259 26984  2558 E MessagingControllerPush:       at com.android.org.conscrypt.OpenSSLSocketImpl.getInputStream(OpenSSLSocketImpl.java:652)
06-24 17:45:50.259 26984  2558 E MessagingControllerPush:       at com.fsck.k9.mail.store.imap.ImapConnection.setUpStreamsAndParserFromSocket(ImapConnection.java:236)
06-24 17:45:50.259 26984  2558 E MessagingControllerPush:       at com.fsck.k9.mail.store.imap.ImapConnection.open(ImapConnection.java:120)
06-24 17:45:50.259 26984  2558 E MessagingControllerPush:       at com.fsck.k9.mail.store.imap.ImapConnection.sendCommand(ImapConnection.java:773)
06-24 17:45:50.259 26984  2558 E MessagingControllerPush:       at com.fsck.k9.mail.store.imap.ImapConnection.executeSimpleCommand(ImapConnection.java:731)
06-24 17:45:50.259 26984  2558 E MessagingControllerPush:       at com.fsck.k9.mail.store.imap.ImapConnection.executeSimpleCommand(ImapConnection.java:720)
06-24 17:45:50.259 26984  2558 E MessagingControllerPush:       at com.fsck.k9.mail.store.imap.ImapFolder.executeSimpleCommand(ImapFolder.java:109)
06-24 17:45:50.259 26984  2558 E MessagingControllerPush:       at com.fsck.k9.mail.store.imap.ImapFolder.internalOpen(ImapFolder.java:145)
06-24 17:45:50.259 26984  2558 E MessagingControllerPush:       ... 3 more
06-24 17:45:50.259 26984  2558 E MessagingControllerPush: Caused by: javax.net.ssl.SSLProtocolException: SSL handshake aborted: ssl=0x71ac464b00: Failure in SSL library, usually a protocol error
06-24 17:45:50.259 26984  2558 E MessagingControllerPush: error:10000410:SSL routines:OPENSSL_internal:SSLV3_ALERT_HANDSHAKE_FAILURE (external/boringssl/src/ssl/tls_record.c:522 0x71c832b200:0x00000001)
06-24 17:45:50.259 26984  2558 E MessagingControllerPush: error:1000009a:SSL routines:OPENSSL_internal:HANDSHAKE_FAILURE_ON_CLIENT_HELLO (external/boringssl/src/ssl/handshake_client.c:889 0x71d6b720a6:0x00000000)
06-24 17:45:50.259 26984  2558 E MessagingControllerPush:       at com.android.org.conscrypt.NativeCrypto.SSL_do_handshake(Native Method)
06-24 17:45:50.259 26984  2558 E MessagingControllerPush:       at com.android.org.conscrypt.OpenSSLSocketImpl.startHandshake(OpenSSLSocketImpl.java:357)
06-24 17:45:50.259 26984  2558 E MessagingControllerPush:       ... 12 more

The GMail app can connect OK.
I'd like to use SSLLabs to get some more info but it won't test port 993.

See #893


Fixed Headline

Q
A

Bug fix?
No

New feature?
No

New sample?
No

Related issues?
None

What's in this Pull Request?
Fixed headline and some minor grammatical items

@thechriskent,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

thx Chris, appreciated.


make sure all error code names are prefixed with ERROR_ @fceller @kvs85

Scope & Purpose
Make sure all internal error code names are prefixed with ERROR_

[x] Bug-Fix for devel-branch (i.e. no need for backports?)
[x] The behaviour change can only be verified via automatic tests

Testing & Verification
This change is a trivial rework / code cleanup without any test coverage.
https://jenkins01.arangodb.biz/view/PR/job/arangodb-matrix-pr/5023/

https://jenkins01.arangodb.biz/view/PR/job/arangodb-matrix-pr/5024/


Content tile edge support

Also updated grass to use it as a POC.
Requires https://github.com/space-wizards/RobustToolbox/pull/3613

:cl:

add: Tiles now support edges. For now this support has been added to grass.

This only appears to work for tiles that can use the same edge sprite for every direction?

This really needs to support more than a single direction for edges, I should be able to specify all 8.

This really needs to support more than a single direction for edges, I should be able to specify all 8.

serv3 doesn't support masks for the enum so I can't think of an easy way to do it that doesn't make the code a pain.


Updating a slice or a map from the in-memory backing store results in a panic

While working with the Microsoft Graph SDK, I've noticed updating a slice or a map from the in-memory backing store results in a panic.
The issue should be easily reproducible with the following test case:
func TestReplaceSlice(t *testing.T) {
	memoryStore := NewInMemoryBackingStore()
	err := memoryStore.Set("key", []string{"a", "b"})
	assert.Nil(t, err)
	err = memoryStore.Set("key", []string{"b", "c"})
	assert.Nil(t, err)
}

=== RUN   TestReplaceSlice
--- FAIL: TestReplaceSlice (0.00s)
panic: runtime error: comparing uncomparable type []string [recovered]
	panic: runtime error: comparing uncomparable type []string

goroutine 17 [running]:
testing.tRunner.func1.2({0x5e3360, 0xc000184d30})
	C:/Program Files/Go/src/testing/testing.go:1396 +0x24e
testing.tRunner.func1()
	C:/Program Files/Go/src/testing/testing.go:1399 +0x39f
panic({0x5e3360, 0xc000184d30})
	C:/Program Files/Go/src/runtime/panic.go:884 +0x212
github.com/microsoft/kiota-abstractions-go/store.(*InMemoryBackingStore).Set(0xc00008dc38, {0x615457?, 0x2?}, {0x5d58a0?, 0xc00018a258})
	D:/git/kiota-abstractions-go/store/inmemory_backing_store.go:59 +0xc6
github.com/microsoft/kiota-abstractions-go/store.TestReplaceSlice(0x0?)
	D:/git/kiota-abstractions-go/store/inmemory_backing_store_test.go:14 +0x26b
testing.tRunner(0xc0001a6ea0, 0x640820)
	C:/Program Files/Go/src/testing/testing.go:1446 +0x10b
created by testing.(*T).Run
	C:/Program Files/Go/src/testing/testing.go:1493 +0x35f

The simplest fix I can think of is replacing the direct comparison with a call to reflect.DeepEqual, but performance-wise it might be better to implement a custom-written function.

Hi @ffawkes
Thanks for reporting this.
The idea was to implement a reference comparison. i.e. If the backing store contains a reference to a different slice, then track it as a changed value. We never intended to implement a value comparison for slices since it'd be costly. Is this something you'd be willing to submit a pull request to correct?

Sure. I'll open a PR soon.


Build mmproxy on CentOS 7 (Non-issue)

Hi,
I just want to share my building script:
https://gist.github.com/shikendon/f23a36c3b93032db1079efe677248f6b
#!/usr/bin/env bash
set -e

cat <<'END' | sudo tee /etc/yum.repos.d/epel-alonid-llvm.repo
[epel-alonid-llvm-3.9.0]
name=Copr repo for llvm-3.9.0 owned by alonid
baseurl=https://copr-be.cloud.fedoraproject.org/results/alonid/llvm-3.9.0/epel-7-$basearch/
type=rpm-md
enabled=0
gpgkey=https://copr-be.cloud.fedoraproject.org/results/alonid/llvm-3.9.0/pubkey.gpg
gpgcheck=1
repo_gpgcheck=0
enabled_metadata=1
skip_if_unavailable=True
END
sudo rpm --import https://copr-be.cloud.fedoraproject.org/results/alonid/llvm-3.9.0/pubkey.gpg

sudo yum -y groupinstall "Development Tools"
sudo yum -y install --enablerepo=epel-alonid-llvm-3.9.0 clang-3.9.0
sudo yum -y install glibc-static
sudo ln -s -f /opt/llvm-3.9.0/bin/* /usr/bin

git clone https://github.com/cloudflare/mmproxy.git --recursive
pushd mmproxy
make # If failed, try to build libmill manually: `pushd libmill && ./configure && make`
find `pwd` -type f -executable -name mmproxy

It took me a half day. Hope this can save someone's time.
Great work mmproxy 👍

MANY THX !!!! :+1:


nsc-events-nextjs_14_570_add-document-field-to-more-details

Resolves #570
This PR is for adding the document field to the more details dialog when viewing your events.
Here is a video demonstrating the changes made, the video goes through three accounts that are connected to my local database (user, admin, creator):
https://github.com/user-attachments/assets/2471ade6-da41-4c45-97c2-10263fa09c9f
Basically, this field was added highlighted here (signed in as admin):

In order to test this, make sure you have back-end connected and database setup with sample users (different roles) and events created. Then go to event and click on more details to view the added document field.
make sure to npm install first, then npm run dev.
If you need help setting up the back-end here is a helpful guide: https://www.notion.so/Setting-up-front-end-and-back-end-48ae7b05b54649b5b821fbc5e57bfbb0

from your branch I'm having this problem when I tried to signup, but I think the problem is in my end and not in your branch.. do you know anything about it?

from your branch I'm having this problem when I tried to signup, but I think the problem is in my end and not in your branch.. do you know anything about it?

I think the issue is probably on your end @miqo1385, do you have your back-end setup(nestjs) configured? I recommend checking this notion page to help setup the backend so you can sign-up properly: https://www.notion.so/Setting-up-front-end-and-back-end-48ae7b05b54649b5b821fbc5e57bfbb0. It's mostly about Belinda's but it's the same process for NSC-Events. Hopefully this helps, if you run into anymore problems trying to test let me know.

from your branch I'm having this problem when I tried to signup, but I think the problem is in my end and not in your branch.. do you know anything about it?

If you're still running into any issues let me know and I can meet with you this week!

That would be great!!! Thank you so much.


Error when press down key on autocomplete

The problem: when I focus on autocomplete field, start to type and try to select one option with the "down" key then I got an error.
I didn't check your code to see if it is easy to fix, if it is easy please let me know and I can try to create one PR later.
The error
Uncaught TypeError: Cannot read property 'focus' of null
    at SelectField.focusFirstMenuItem (http://localhost:3000/packages/modules.js?hash=6f7dc802871c7fc63f971c313c5e423ce70405ca:59695:20)
    at SelectField._this.handleTextFieldKeyDown

The code with problem
key: 'focusFirstMenuItem',                                                                                // 376
    value: function focusFirstMenuItem() {                                                                             // 377
      var firstMenuItem = (0, _reactDom.findDOMNode)(this.menu).querySelector('[tabindex="0"]');                       // 378
      ---> firstMenuItem.focus();                                                                                // 379
    }

My component
<SuperSelectField
                    name="brokersToFilter"
                    multiple
                    hintText="digite a corretora..."
                    onChange={this.handleFilterChange}
                    selectionsRenderer={this.handleCustomDisplaySelections('brokersToFilter', 'Todas as Corretoras')}
                    value={this.state.brokersToFilter}>
                    {this.brokersList()}
                </SuperSelectField>

    brokersList = () => {
        return this.state.brokers.map((broker, index) => {
            return (

                    {Utils.shortName(broker.name)}

            )
        })
    }

    onRequestDelete = (key, name) => e => {
        e.preventDefault()
        this.updateState({[name]: this.state[name].filter((v, i) => i !== key)})
    }

    handleCustomDisplaySelections = (name, text) => values => values.length
        ?

            {values.map(({label, value: country}, index) =>
                <Chip key={index} style={{margin: 5}} onRequestDelete={this.onRequestDelete(index, name)}>
                    {label}
                </Chip>
            )}

        :
{text}
 // advice: use one of <option>s' default height as min-height

Hi, thanks for your report.
It's a known bug with Focus handling since i integrated InfiniteLoading in between the main parent component and its children.
This has nothing to do with your usage of the component, this is an internal bug.
I'll try to check it more in depth this week.

Thank you!

Hi, did this bug work? I'm having the same problem, I can not navigate the list with the keydown after filtering


when I build it,

liudeMacBook-Pro:~ liu$ docker build --rm -t sequenceiq/spark:1.6.0 .
unable to prepare context: unable to evaluate symlinks in Dockerfile path: lstat /Users/liu/Dockerfile: no such file or directory

should i give the path?but i don not where is it?

+1

+1

+1

+1 me too.

+1


Does asp net core identity supports the hierarchy based resource access?

I am planning To use the asp net identity as a web api for my use case where I have to create  a company based hierarchy and based on which I need to provide the resource access.
I can have many such hierarchy for each company accounts. All I need to achieve  through asp net core identity is, identifying the logged in user, to which company it belongs to and what can he/she have access to with in the hierarchy.
Is this achievable using asp net core identity?

Identity != Permissions

@brockallen I think the asp net core identity also provides the Authorization mechanism so I believe it should do that. Isn’t it ?

Identity doesn't provide authorization, Identity is basically a user database. How you make use of the identities it populates is a separate concern.
(But yes, it would be possible, depending on how you extend the identity model and then plug it into resource authorization)


Multiarch updates

Some of the openjdk images have changed such that they don't work without using the stretch version instead of the base image. These changes correct that as well as introduce retries for manifest operations. The time it takes to do certain tasks causes the token to "timeout" and not work after a period of time, if the script receives a 401 (Unauthorized) (really a non 404 or 200) response, it will request a new login token to retrieve manifests and retry the curl invocation with the new TOKEN value.
Added the capability to specify a -a parameter to only build a single arch. This is mainly for debug, testing purposes.

Close/reopen for a build

One more time...

I think a similar issue came up with the publish script that wasn't ported over to the publish-expiremental script?
I can't even remember now exactly what's different between the two but I was planning on getting them merged together if we ever got this part done.

@jmreicha I looked at publish.sh and didn't see anything related to the token stuff (is that what you were referring to?). I think the publish-experimental.sh is more likely to encounter the issue because there are many more builds that take place because of the different architectures and they are running under qemu which will be slow in general.

@oleg-nenashev any issues with this?


openmetadata: Fix typo which prevents deployment

What this PR does / why we need it :
Fixes #259

Type of change :

[x] Bug fix

Checklist:

[x] I have read the CONTRIBUTING document.
[ ] Chart Version bumped
[ ] Variables are documented in the README.md
[X] Title of the PR starts with chart name
[X] My code follows the style guidelines of this project
[X] I have performed a self-review of my code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] All new and existing tests passed.

Reviewers
@akash-jain-10 @tutte @dhruvinmaniar123

Thank you @xtruan , shipping in 1.5.4 :raised_hands:


[[FEAT]] Add support for optional chaining

Coverage remained the same at 100.0% when pulling 1b4f9b2a16e389ac91dcead887351f07420fc3b7 on jugglinmike:optional-chaining into 1aeeaacfd1f351db981422af5a8e35cd2bbebda8 on jshint:v2.12.0.

Coverage remained the same at 100.0% when pulling 1b4f9b2a16e389ac91dcead887351f07420fc3b7 on jugglinmike:optional-chaining into 1aeeaacfd1f351db981422af5a8e35cd2bbebda8 on jshint:v2.12.0.

Merged! https://github.com/jshint/jshint/commit/59028b086d081a46b7c9ccfa3386a0a67f0516ce


feat(core): add mutations for reset password

What/Why?
This PR adds 2 mutations for reset password pages (Registered  customer flow):

submitResetPassword is being used for sending a link on provided email,
submitChangePassword is aimed to updating existing password with new one.

Testing
locally

Needs changeset 🦋

Needs changeset 🦋

Thanks, Matt. Added 💅


[DRAFT] [SNAPSHOT] change java-client to 9.1.0

<IP_ADDRESS>1-SNAPSHOT

<IP_ADDRESS>7-SNAPSHOT

<IP_ADDRESS>7-SNAPSHOT


Component not updating/re-rendering on changing redux props

I'm using this library to load a GeoJSON file but I'm changing the opacity using redux. For the first time, it is loading the proper opacity but not updating it after dispatching the actions to update props.
Currently, to make this thing work, I added this code but it is a bit laggy.
updateLeafletElement(oldProps, newProps) {
    if (oldProps != newProps) {
        this.forceUpdate();
    }
}

I think there should be a way to make this work properly.

You must set a unique key value on your vector layer. This is not documented on react-leaflet-vectorgrid but it is on react-leaflet.
As example, in my case I managed it like this:
const provinceKey = 'province_' + regionFilter + provinceFilter + departmentFilter;
const departmentkey = 'department_' + regionFilter + provinceFilter + departmentFilter;

...

<VectorGrid key={provinceKey} {...provincesOptions} />
<VectorGrid key={departmentkey} {...departementsOptions} />

...

Thank you for the response.
I'll try this and let you know in this thread.

Thank you @mecmartini. It is working properly. Closing this issue.


[SPARK-35546][Shuffle] Enable push-based shuffle when multiple app attempts are enabled and manage concurrent access to the state in a better way

What changes were proposed in this pull request?
This is one of the patches for SPIP SPARK-30602 which is needed for push-based shuffle.
Summary of the change:
When Executor registers with Shuffle Service, it will encode the merged shuffle dir created and also the application attemptId into the ShuffleManagerMeta into Json. Then in Shuffle Service, it will decode the Json string and get the correct merged shuffle dir and also the attemptId. If the registration comes from a newer attempt, the merged shuffle information will be updated to store the information from the newer attempt.
This PR also refactored the management of the merged shuffle information to avoid concurrency issues.
Why are the changes needed?
Refer to the SPIP in SPARK-30602.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Added unit tests.
The reference PR with the consolidated changes covering the complete implementation is also provided in SPARK-30602.
We have already verified the functionality and the improved performance as documented in the SPIP doc.

Can one of the admins verify this patch?

PR created. CC @Ngone51 @mridulm @Victsm @otterc

Jenkins, test this please.

Ok to test

Test build #140315 has started for PR 33078 at commit 65fca88.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44847/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44847/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44847/

Test build #140315 has finished for PR 33078 at commit 65fca88.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
 public static class AppShuffleInfo

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140315/

Can one of the admins verify this patch?

Thanks @mridulm  @otterc  @venkata91 for reviewing the PR. Addressed majority of the comments.
@otterc The unit test to simulate the concurrency control is yet to be added. A little bit tricky to get those added.
Hi, @Ngone51 . Can you also help review this one? Thanks.

Test build #140368 has started for PR 33078 at commit 1f915b1.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44900/

Test build #140368 has finished for PR 33078 at commit 1f915b1.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140368/

Kubernetes integration test unable to build dist.
exiting with code: 141
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44900/

@Ngone51 I am leaving on slightly long-ish vacation without access to my laptop .. will it be possible for you to shepard this pr and #33034 ?
These are the last two pending fixes for push based shuffle, and deal with correctness issues (and not functionality issues).
Thanks !

@mridulm Sure! Enjoy your vacation!

@zhouyejoe Could you address all the comments? Branch-3.2 is already cut, we now have very limited time to merge this into it.

@Ngone51  Sure, will update the PR ASAP.

Test build #140623 has started for PR 33078 at commit 83eb3e8.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45136/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45136/

Test build #140623 has finished for PR 33078 at commit 83eb3e8.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140623/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45136/

Test build #140633 has started for PR 33078 at commit 622285b.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45146/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45146/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45146/

Test build #140633 has finished for PR 33078 at commit 622285b.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140633/

Test build #140944 has started for PR 33078 at commit 2dcd1ae.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45455/

Test build #140944 has finished for PR 33078 at commit 2dcd1ae.

This patch fails Java style tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140944/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45455/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45455/

Test build #140956 has started for PR 33078 at commit 3eb4cbb.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45470/

Addressed all the comments other than adding unit tests as @otterc commented for potential concurrency issues.

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45470/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45470/

Test build #140956 has finished for PR 33078 at commit 3eb4cbb.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140956/

I don't see any UTs added for all the issues that were identified with concurrency. Is there a problem in adding UTs for these cases?

I added one unit test where the registerExecutor happens between multiple PushBlockStream.onData callbacks.
What additional unit tests should we add to test the concurrency? Public APIs are bundled with validateAndGetAppShuffleInfo(appId) and it should be safe here.

@Ngone51  @mridulm  @otterc @venkata91 Added/updated unit tests for concurrency issue between RegisterExecutor and PushBlockStream callbacks. Can you help review this PR again? Thanks.

Test build #141005 has started for PR 33078 at commit 36ab327.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45519/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45519/

Test build #141005 has finished for PR 33078 at commit 36ab327.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/141005/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45519/

Test build #141032 has started for PR 33078 at commit 481b92a.

Kubernetes integration test unable to build dist.
exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45546/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45546/

Test build #141036 has started for PR 33078 at commit 6080850.

Test build #141032 has finished for PR 33078 at commit 481b92a.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Kubernetes integration test unable to build dist.
exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45551/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45551/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/141032/

No idea why there are some unrelated unit tests failed. Jenkins, test please.

Test build #141036 has finished for PR 33078 at commit 6080850.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/141036/

The failed unit test does relate to this PR, will fix it tomorrow morning.

The failed unit test does relate to this PR, will fix it tomorrow morning.

It's related? But the Jenkins can pass.

Test build #141091 has started for PR 33078 at commit 91f39cd.

Kubernetes integration test unable to build dist.
exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45605/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45605/

Test build #141093 has started for PR 33078 at commit a04d215.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45607/

Test build #141091 has finished for PR 33078 at commit 91f39cd.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/141091/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45607/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45607/

Test build #141093 has finished for PR 33078 at commit a04d215.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/141093/

Test build #141140 has started for PR 33078 at commit 892fbd3.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45652/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45652/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45652/

Test build #141140 has finished for PR 33078 at commit 892fbd3.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/141140/

Updated the PR.

Test build #141181 has started for PR 33078 at commit 1a2eb32.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45693/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45693/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45693/

Test build #141187 has started for PR 33078 at commit fab51d4.

Test build #141181 has finished for PR 33078 at commit 1a2eb32.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/141181/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45699/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45699/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45699/

Test build #141191 has started for PR 33078 at commit 79816ad.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45703/

Test build #141187 has finished for PR 33078 at commit fab51d4.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/141187/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45703/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45703/

Test build #141191 has finished for PR 33078 at commit 79816ad.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/141191/

Are there any UTs that verify the changes to finalizeShuffleMerge when the message is from old attempt?

Added a unit test for this one yesterday.

Test build #141208 has started for PR 33078 at commit 1de689b.

Kubernetes integration test unable to build dist.
exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45721/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45721/

Test build #141208 has finished for PR 33078 at commit 1de689b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/141208/

Thanks for the approve @Ngone51 !
+CC @otterc, @venkata91 can you take another pass please ? I plan to merge this later today to master and branch-3.2.

LGTM.

Thanks for all the reviews.

Jenkins, test this please

Test build #141284 has started for PR 33078 at commit 1de689b.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45798/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45798/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45798/

Test build #141286 has started for PR 33078 at commit 5310991.

Kubernetes integration test unable to build dist.
exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45800/

Test build #141284 has finished for PR 33078 at commit 1de689b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/141284/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45800/

Test build #141286 has finished for PR 33078 at commit 5310991.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
public class ShuffleChecksumHelper
class MutableCheckedOutputStream(out: OutputStream) extends OutputStream
case class ShuffleChecksumBlockId(shuffleId: Int, mapId: Long, reduceId: Int) extends BlockId
case class SessionWindow(timeColumn: Expression, gapDuration: Long) extends UnaryExpression
protected abstract class ConnectionProviderBase extends Logging
case class SessionWindowStateStoreRestoreExec(
case class SessionWindowStateStoreSaveExec(

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/141286/

Merged to master and branch-3.2
Thanks for working on this @zhouyejoe !
Thanks for all the reviews @Ngone51, @otterc, @venkata91 :-)

+CC @gengliangwang


Enabled Xlint scala option

and in addition, the cause of the newly outputted warning message was
removed.

Looks good


Linting updates

Relevant components:

[x] Signalling server
[x] Frontend library
[x] Frontend UI library
[ ] Matchmaker
[ ] Platform scripts
[ ] SFU

Problem statement:
Discussions arose recently about the odd behaviour of [33,2,4].sort() and so require-array-sort-compare was added to the linting rules. This required an update to the linting dependencies which also led to a bunch of new linting issues that needed to be addressed.
Solution
Updated the dependencies. Added the new linting rule and ran linting over each component spearately, addressing issues as needed.
Also adding linting and building to the presubmit actions.
Fixes #18
Documentation
Test Plan and Compatibility

Latest changes look good.


[C#] Exception when trying to update Autofac Registration

With container.Update being obsolete, the next possible workaround is to Add Registrations to Child Scopes. However I am facing a very weird issue using it.
I am getting the following exception -
"Type 'Microsoft.Bot.Builder.Internals.Fibers.NullWait`1[[Microsoft.Bot.Builder.Dialogs.Internals.DialogTask, Microsoft.Bot.Builder, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35]]' in Assembly 'Microsoft.Bot.Builder, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35' is not marked as serializable."

Repo - https://github.com/ankitbko/bot-issue-autofac
Steps to reproduce -

Enter correct MicrosoftAppId and MicrosoftAppPassword in App.config.
Run the program, put breakpoint on  the catch block. Notice that DummyDialog.MessageRecieved is never called. Exception occurs before this.
Remove the Configure Action from BeginLifetimeScope i.e -
Conversation.Container.BeginLifetimeScope(DialogModule.LifetimeScopeTag)
Now everything will work perfectly.

The issue arises only when you try to register to a child container. The weird thing is that you may comment the entire Configure method (make it empty) and it would still throw error as long as you pass Configure method as action to BeginLifetimeScope.
Note that the entire thing used to work earlier (v 3.3.0). - https://github.com/ankitbko/bot-issue-autofac/tree/v3.3.0
What am I doing wrong?

I think I saw this issue too - when starting a child scope, all of the keyed services seemed to disappear, causing this logic to fail:
https://github.com/Microsoft/BotBuilder/blob/master/CSharp/Library/Microsoft.Bot.Builder.Autofac/Fibers/FiberModule.cs#L63
and then a serialization surrogate is not applied to the first FiberModule.Key_DoNotSerialize which happens to be NullWait:
https://github.com/Microsoft/BotBuilder/blob/master/CSharp/Library/Microsoft.Bot.Builder.Autofac/Fibers/FiberModule.cs#L165
I did not investigate further - I worked around the issue by just creating and updating my container in just one place.

@willportnoy I found that 973229623 commit introduced this bug. I think L73 was the issue. Putting [NonSerialized] on top of private IWait<C> mark = NullWait<C>.Instance; solves the error, however I don't know what would be its side effect.
Do you think this is the right approach?

"git bisect" is awesome, particularly if you have the tests to support its usage. :)
The issue with that fix is that the "mark" field is the field that stores the next wait for the https://github.com/Microsoft/BotBuilder/commit/9732296235a274bcc429f7e647b46fc9d1f3d989 feature to work.
I would have assumed that removing that commit just meant that some other Key_DoNotSerialize instance would be serialized - none of these objects should be serialized and should instead by resolved from the container, and it means that somehow the logic in DoNotSerialize is failing - the only time I've seen that before is when I was using child scopes for updating registrations.

@willportnoy  I used the console application as the "test" to each of the commit(I referred the project directly instead of nuget package). The console app just updates the registration in child scope. At each bisect I would just run and see if child scope registration caused any exception or not.
It seems that the issue started to arise at https://github.com/Microsoft/BotBuilder/commit/9732296235a274bcc429f7e647b46fc9d1f3d989 commit. Everything was working fine till  https://github.com/Microsoft/BotBuilder/commit/8768c83dbc548bf1b9a4da95821eded4da5d2fe2.
Well I was not talking about removing the commit. I just put [NonSerialized] on top of mark field and the child scope registration started working.
But I don't understand why putting [NonSerialized] on top of mark field solves this issue where as wait field just below mark does not need it.
private IWait<C> mark = NullWait<C>.Instance;
private IWait<C> wait = NullWait<C>.Instance;

And it failing only when using child scope to update registration is weird too.

I guess I'm surprised that adding the [NonSerialized] fixed it without further issues - in my experiements, the child scope broke the entire "do not serialize" keyed service thing.  If it's just NullWait, maybe there's something wrong with our autofac registration for it.

I ran the tests with [NonSerialized] attribute and 3 of them failed.

DialogTask_RememberLastWait - Message: Test method Microsoft.Bot.Builder.Tests.DialogTaskTests.DialogTask_RememberLastWait threw exception:  System.NullReferenceException: Object reference not set to an instance of an object.
DialogTask_RememberLastWait_ReturningFromChild - Message: Test method Microsoft.Bot.Builder.Tests.DialogTaskTests.DialogTask_RememberLastWait_ReturningFromChild threw exception:  System.InvalidOperationException: Stack is empty
Dispatch_NextDispatchGroup - Message: Test method Microsoft.Bot.Builder.Tests.DispatchDialogTests.Dispatch_NextDispatchGroup threw exception:  System.NullReferenceException: Object reference not set to an instance of an object.

However I ran Annotated Sandwitch bot and it ran perfectly. One of my other bot also seems to work fine with this attribute on top. But if the tests are failing then there should be some issue.
One other thing I did not understand is that why wait field just below mark does not require [NonSerialized] attribute.
[NonSerialized]
private IWait<C> mark = NullWait<C>.Instance;
private IWait<C> wait = NullWait<C>.Instance;

@willportnoy Any thoughts on this? Is putting NonSerialized attribute solving this issue for you too?

@ankitbko Hi i found the same issue and with the attribute NonSerialized it solve my problem also. but if i take the 3.3.3 package it will work.

@SalimDr Thanks a lot for trying it out. It confirms that this is not a local issue with me. When you put the NonSerialized attribute, did you notice any problem with the bot? Did all the functionality worked?

@ankitbko I'm working on to integrate bot framework(v3.5.3) with skype for business, and  try to use LUIS. With this scenario I had same error and your solution worked well for me.

May I know the steps to add the NonSerialized line? Would I need to download the bot builder source code and modify it and create a nuGet package?
Thank you.

I'm still having the issue;
An unhandled exception of type 'System.Runtime.Serialization.SerializationException' occurred in mscorlib.dll
Additional information: Type 'Microsoft.Bot.Builder.Internals.Fibers.NullWait`1[[Microsoft.Bot.Builder.Dialogs.Internals.DialogTask, Microsoft.Bot.Builder, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35]]' in Assembly 'Microsoft.Bot.Builder, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35' is not marked as serializable.
Is there anything I could do to avoid it? I have got the package from NuGet.
Thanks
Arafat

@ankitbko I'm trying to run your bot and I am still having a great struggle in executing it. The above issue is one of them.  Can you please advise what can be done?

@angsm You will need to clone this repository first. Then go to Fiber.cs and put NonSerialized attribute over private IWait<C> mark = NullWait<C>.Instance;.
You will then need to make a direct project reference from your bot instead of using nuget package.
However, once you have done it recheck all the functionalities of your bot. There are 3 test cases which are failing with the attribute. Let me know if everything works for you.
@arafattehsin As of now using child scope to add registration is not working. You could  -

Use Bot Builder SDK v3.3.3 or
Use conatiner.Update to update the container registration (keep in mind that this is obsolete) or
Try putting NonSerialized attribute over  mark field in Fiber.cs as mentioned above. (this breaks 3 test cases)

@dilanmert Thanks for trying it out. Are all the bot functionalities working after putting this attribute? 3 of the test cases fail after adding the attribute.
I am sorry I was not able to dig deep into this issue. Have been very busy last couple of weeks(this week too). When I get time will try to get to bottom of this and see why the tests are failing.
PS: Debugging serialization issue is tough. 😩

@ankitbko do you know if it's solved by upgrading the autofac version?  It seemed like an autofac issue when I encountered it.

@willportnoy I updated Bot.Builder to 3.5.5 and Autofac to 4.4.0 but error still occurs. I don't think its an Autofac issue, since it worked before and stopped working with the commit https://github.com/Microsoft/BotBuilder/commit/9732296235a274bcc429f7e647b46fc9d1f3d989.
Also 2 of the 3 tests which fails with the NonSerialized attribute were also introduced in the same commit. Maybe there is something off with the Autofac registration (not sure).

I updated my bot to 3.8.0 and Autofac to 4.5.0 and error still occurs.

@ankitbko Do you still have this issue? Do you need further assistance?

I believe the above commit should fix this issue, so I'm closing it for now - feel free to open a new issue if you have further problems.


DeadSimpleScreenSharing screen share is not working when initiated from Rocket.chat

I have issues with screen sharing using deadsimplechreensharing integration.
The integration works fine, and creates a meeting. But when in a meeting, no one can see the shared screen, even if I share the screen, I don't become 'presenter', I remain a guest.
However, when the meeting is created from the WebBrowser extenstion(not via rocketchat), attendees can see the shared screen.
Rocket chat version 1.3.1. Running on a k8s cluster v1.14.0.

This is not an issue with electron-quick-start, you should report it to rocket chat.


Remove 'car' as keyword for :bus:

Fixes https://github.com/notwaldorf/emoji-translate/issues/12.
The issue made sense to me, so I thought I'd fix it and open a pull request! I :heart: emoji and I support this project :grin:

Wooo, glad you like it! Unfortunately, I pull in the keywords from emojilib. You should send your PR there!
/cc @muan


Issue: Columns with Empty Arrays Disappear in Preview Query

When using the preview query feature, columns containing empty arrays seem to disappear from the output.
Steps to Reproduce

Run the following SQL:
config {
  type: 'table',
  schema: 'exports'
}

WITH cte AS(
  SELECT
      id,
      ARRAY(
        SELECT AS STRUCT * FROM UNNEST([]) AS EmptyArrayCol
      ) AS EmptyArray,
      ARRAY(
        SELECT AS STRUCT * FROM UNNEST(GENERATE_ARRAY(1, 3)) AS PopulatedArrayCol
      ) AS PopulatedArray
    FROM UNNEST(GENERATE_ARRAY(1, 3)) AS id
)

SELECT * FROM cte

View the query preview.

Expected Behavior
The preview should display both EmptyArray and PopulatedArray columns, even if EmptyArray contains an empty array.
Actual Behavior
The EmptyArray column is missing from the preview when it contains an empty array, as shown in the screenshot below:

It seems like the same behavior occurs when dealing with an array of non-struct elements.
ARRAY<STRING>['string1', 'string2', 'string3'] AS StringArray,

Hi @HampB ,
Thanks for reporting the issue. Please update to the latest version v0.2.22 where this issue should be fixed. The preview query results is very much a beta for any non-trivial data structures due to the complexity involved in showing nested data while using an external table library + handling different BigQuery data types. So please feel free to report any other issue that you may come across.
I have tested the following which seems to work as expected
WITH cte AS(
  SELECT
      "my_data" as foo,
      id,
      ARRAY<STRING>['string1', 'string2', 'string3'] AS StringArray,
      ARRAY(
        SELECT AS STRUCT * FROM UNNEST([]) AS EmptyArrayCol
      ) AS EmptyArray,
      ARRAY(
        SELECT AS STRUCT * FROM UNNEST([]) AS AnotherEmptyArrayCol
      ) AS AnotherEmptyArrayCol,
      ARRAY(
        SELECT AS STRUCT * FROM UNNEST(GENERATE_ARRAY(1, 3)) AS PopulatedArrayCol
      ) AS PopulatedArray,
      ARRAY(
        SELECT AS STRUCT * FROM UNNEST(GENERATE_ARRAY(1, 5)) AS PopulatedArrayMoreItems
      ) AS PopulatedArrayMoreItems,
      ARRAY(
        SELECT AS STRUCT * FROM UNNEST(GENERATE_DATE_ARRAY(CURRENT_DATE(), CURRENT_DATE() + 6, INTERVAL 1 day)) AS dateArray
      ) AS dateArray,
    FROM UNNEST(GENERATE_ARRAY(1, 2)) AS id
)

SELECT * FROM cte

Once again, thanks for the quick resolutions!
The examples are working well, but I encountered issues with production data. When a column contains a mix of populated and empty arrays, it throws the error:

"Cannot read properties of undefined (reading 'length')"

This issue can be reproduced with the following SQL:
WITH cte AS (
    SELECT
        id,
        ARRAY<STRING>['string1', 'string2', 'string3'] AS arr
    FROM UNNEST(GENERATE_ARRAY(1, 3)) AS id

    UNION ALL

    SELECT
        id,
        ARRAY<STRING>[] AS arr
    FROM UNNEST(GENERATE_ARRAY(1, 3)) AS id
)

SELECT * FROM cte

Thanks again for reporting the issue. Please update to the latest version v0.2.23.

Looks good now, thanks!


Clientside Persistence: IndexedDB

As LocalStorage has an upper limit to the amount of data stored (and it is relatively low), we should switch to using IndexedDB as the back-end for persistence in the client-side.

That's right indeed, thanks for pointing out. It should fallback to localStorage for older browsers though (for IE only version 10 supports IndexedDB)

Are we supporting IndexedDB??
Am a bit tired of PouchDB for it's querying capabilities. It's plain and simply un-intuitive. It has a beta plugin for MongoDB like query but those plugins simply are not supported or RequireJS.
Any plans on this line???
Thanks. :)

Not a lot of time to work on it these days but I'd gladly accept pull requests on this. The way I see it there is only one file that needs to be modified, the browser specific version of storage.js (in \browser-version\browser-specific\lib)

@louischatriot : Thanks for the prompt reply. Even am not getting nuf time. :-/

As of v1.4, NeDB automatically selects the best method to persist data on the browser (IndexDB then WebSQL then localStorage), so the limit is removed. WARNING: it's not back compatible with v1.3, but that should not be a major issue as user apps can resync entirely.

Awesome!  @ChangeTip, give @louischatriot 10,000 bits for making this happen.

Hi @louischatriot, @martindale sent you a tip worth 10,000 bits (10,000 bits/$3.80), and I'm here to deliver it ➔ collect your tip.
Learn more about ChangeTip

Thanks :)


The pod_environment_configmap option is ignored in CRD OperatorConfiguration

The operator shows empty string when displaying configuration on startup.

This should be fixed by #477 PR.


Compatibility with Internationalization (i18n)

Is your feature request related to a problem?
I need to write a documentation in two languages, starlight have by default this support and works great; however the autogenerated routes and pages based on the opeanapi yaml, I wasn't able to create a version in both languages.
Describe the solution you'd like
I would like an easy way to read for example .yaml file in Spanish and another one in English and it make compatible with the  Internationalization (i18n) from the Astro starlight template.
Describe alternatives you've considered
I almost find a workaround by my own but wasn't possible.

I created two sub-folders inside schemas folder: ES, EN
Inside the folder add the documentation for example: schemas/en/pad.yaml and schemas/es/pad.yaml
Then in the astro.config.mjs file do something like this:

      plugins: [
          // Generate the OpenAPI documentation pages.
          starlightOpenAPI([
	          {
		          base: 'services-pad',
		          label: 'PAD',
		          schema: 'schemas/en/pad.yaml',
	          },
	          {
		          base: 'services-pad',
		          label: 'PAD',
		          schema: 'schemas/es/pad.yaml',
	          }
          ]),
      ],

And the sidebar array was like this:

      sidebar: [
          {
	          label: '📚 Guías',
	          items: [{ label: 'Introducción', link: '/guides/intro/' }],
          },
          {
	          // Add the generated sidebar group to the sidebar.
	          label: '🛠 Services',
	          badge: { text: 'New', variant: 'note' },
	          items: [
		          ...openAPISidebarGroups,],
          }
      ],

It work because generated the /es/ routes but in the menu was redundant, I tried to modify but I wasn't able to do it, could be nice a way to avoid this duplicate menu entry, and also this support can work with multiple schemas.
Epic fail result...

Additional Context
Thanks in advance and nice work doing this plugin!

Thanks for your report :raised_hands:
There are at the moment some ongoing refactoring in Starlight to improve/refactor some Internationalization support which also targets plugins and improve i18n support in plugins (which was not really possible before). When this is done, this plugin will be updated and refactored to work with such features as I did not want to "hack" around the current implementation as a temporary solution that would be broken in the near future.
Until then, I think something similar to your workaround could work. Let's say for example the 2 schemas had different labels, e.g. "PAD (en)" and "PAD (es)", you could use a component override for the <Sidebar> component and filter out the group you want to remove based on the current language.
This could look something like this:
---
// src/overrides/Sidebar.astro
import type { Props } from '@astrojs/starlight/props';
import Default from<EMAIL_ADDRESS>
const isEnglishPage = Astro.url.pathname.startsWith('/en/');

Astro.props.sidebar = Astro.props.sidebar
  .filter((entry) => (
    // Filter out the group with the label "PAD (es)" if the current page is in English
    if (isEnglishPage && entry.type === 'group' && entry.label === 'PAD (es)') {
      return false;
    } else if (!isEnglishPage && entry.type === 'group' && entry.label === 'PAD (en)') {
      // or filter out the group with the label "PAD (en)" if the current page is not in English
      return false;
    }

    return true
  ));
---

<Default {...Astro.props}><slot /></Default>

Hi HiDeoo, thank so much for your help, I was not able to see the notification with your answer but I really appreciate your time and explanation, nice work!


refactor(Examples): A bit of cleanup for HNPWA.

... using new DI conventions. Also make testable (I'm going to add e2e-tests).
/cc @kevmoo @leonsenft for quick look before internal merge.

I don't like the aesthetics of using static fields in the template itself, but I agree with the choice to make them static.

@leonsenft:

I don't like the aesthetics of using static fields in the template itself, but I agree with the choice to make them static.

Ack. @hterkelsen remarked that it would be possible to understand YourComponent.foo similar to how we just understand foo today. I'll file a FR:
https://github.com/dart-lang/angular/issues/1018


test(NavigationManager): adds skipped test for lastScrollIndex conditional

Description
This PR adds the skipped test on the lastScrollIndex conditional. Left the comment above the test as a reminder if for some reason we decided this conditional check is no longer needed.
References
LUI-702
Testing
clone branch
run yarn run test NavigationManager all tests for Navigation Manager should run with no test skipping.
Automation
Checklist

[X] all commented code has been removed
[X] any new console issues have been resolved
[X] code linter and formatter has been run
[X] test coverage meets repo requirements
[X] PR name matches the expected semantic-commit syntax

committed work to wrong branch


use_sr isn't used in the actual code

Looks like, unlike FreeVC https://github.com/OlaWod/FreeVC/blob/81c169cdbfc97ff07ee2f501e9b88d543fc46126/data_utils.py#L72C9-L72C9 your code doesn't explicitly use this param, in fact it doens't use SR at all?
https://github.com/quickvc/QuickVC-VoiceConversion/blob/277118de9c81d1689e16be8a43408eda4223553d/data_utils_new_new.py#L70

For convenience when writing code, I designed sr to be manual.  If you want to use sr data augmentation, just remove the comment.

I'm sorry for the inconvenience, this is a bug in the uploaded code version,  in order to use sr, just change that line to
i = random.randint(68,92) c_filename = filename.replace(".wav", f"_{i}.npy")
I just changed the readme, thank you for your reminder.

https://github.com/OlaWod/FreeVC/blob/main/preprocess_sr.py creates .pt files (not .npy).

This because the difference between the  Hubert-soft and the wavlm. The output of Hubert-soft is npy, but wavlm is pt

I see, so that means preprocess_sr must be also updated to Hubert-soft and re-run for the dataset.

Yes

Actually, the most terrible part of SR augmentation is the data storage space... actually quickvc is already four months old research. Now I found a better content feature compared to Hubert-soft, the new content feature doesn't need augmentation and can achieve cross-lingual voice conversion. If you are interested, welcome to see consistencyvc

But you should also change this part in readme
``Spectrogram resize data augumentation, please refer to FreeVC.
Because FreeVCś SR augumentation isn´t used at all here.

In my experiments on sovits by using whisper ppg, there will more timbre leakage on vc comparing to contentvec or hubert. Have you try on contentvec? In Consistencyvc, It seems that speaker consistency loss solves this problem rather than content feature, am I right?


Monitoring Helm chart sometimes add selector:{} and it's interpreted as an active Selector

Internal reference: SURE-7074
Reported in 2.7.6
Issue description:
Trying to upgrade the monitoring APP from the UI to add Data Persistence.
We were stuck on a pending PVC for prometheus.
Looking at the PVC we can see
spec:
  accessModes:
    - ReadWriteOnce
  resources:
    requests:
      storage: 50Gi
  selector: {}
  storageClassName: si0dcs12-sds
  volumeMode: Filesystem
status:
  phase: Pending

Impact:
rancher-monitoring chart installation completes, but the prometheus-rancher-monitoring-prometheus-db-prometheus-rancher-monitoring-prometheus-0 volume in the cattle-monitoring-system Namespace will fail to provision successfully and monitoring will not work until user manually intervenes to remove the empty selector from the prometheus volumeClaimTemplate in the values for the chart and recreate the PVC without the selector{}
Troubleshooting steps:
Looking at the csi-provisioner pod in longhorn, the following logs show:
2023-10-10T11:45:53.590796493Z I1010 11:45:53.590640       1 event.go:282] Event(v1.ObjectReference{Kind:"PersistentVolumeClaim", Namespace:"cattle-monitoring-system", Name:"prometheus-rancher-monitoring-prometheus-db-prometheus-rancher-monitoring-prometheus-0", UID:"b136a1e8-1d48-4e7a-b047-d9081a74f507", APIVersion:"v1", ResourceVersion:"479742099", FieldPath:""}): type: 'Warning' reason: 'ProvisioningFailed' failed to provision volume with StorageClass "si0dcs12-sds": claim Selector is not supported
Looking at the PVC, the selector is set to {} which should not be cought as an active Selector.

It seems the empty Selector is added when in the UI, you add a rule then remove it, clicking on the "Remove" link next to the rule.

Repro steps:

Create a 2.7.6 Rancher cluster.
Create a downstream cluster.
Add longhorn to the downstream cluster.
Add the rancher-monitoring app in the downstream cluster.
Select "Persistent Storage for Prometheus"
Click on "Add Rule"
Then remove the Rule
Check on 'Edit yaml' and you'll see the following:

   storageSpec:
      volumeClaimTemplate:
        spec:
          accessModes:
            - ReadWriteOnce
          resources:
            requests:
              storage: 50Gi
          selector:
            matchExpressions: []
            matchLabels: {}

Applying this config will bring up the bug

Workaround:
Update the App removing
 selector:
            matchExpressions: []
            matchLabels: {}

from the storageSpec. Then recreate the PVC without the selector{}
Actual behavior:
The prometheus pod in not scheduled on longhorn.
Expected behavior:
The prometheus pod should run with the associated bound PVC.

Automation reviewed. The test code included in the PR seems to have sufficient test automation coverage. Moving to 'Done'


Babelmark results are broken or outdated

This is just a heads up:
On Babelmark 2: markdown-it failed to return a valid response: error Internal Server Error
On Babelmark 3, the results are from markdown-it 8.4.0 which differs a lot from current behavior.

Please, contact babelmark author, i'm not responsible for what happens there. The only thing i provide is http responder, it's auto-deployed to heroku on each master commit.

I figured you'd want Babelmark to reflect accurately how Markdown-it behaves -- i.e. I was trying to be helpful. I already know so this isn't important to me.

No problem. Babelmark was important for investigations, but now, when CM spec exists and markdown-it follows it - i don't care what happens in babelmark.


Don't allow duplicate values in NodeAddresses

I was seeing duplicate values in the NodeAddress collection.  I think this is because on each poll loop the legacy hostip is appended to the node.Status.Addresses, which persists.
I created a helper function to only-add-if-not-present, and I changed all (?) of the append calls to use it

While I don't think it's a problem, we really shouldn't need this logic in the conversion code...

cc @ddysher

@justinsb Any update.  I want to get this fix in asap

LGTM. Nits can be fixed in a followup. This list is small enough that N^2 doesn't matter.


Provide RuntimeEnv to ExecutionContext

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
https://github.com/apache/arrow-datafusion/pull/1526 added a MemoryManager along with the concept of a RuntimeEnv, this is awesome. Unfortunately ExecutionContext::new() and ExecutionContext::with_config call RuntimeEnv::new(), which in turn creates a new MemoryManager and DiskManager, which create a temporary directory and print logs, which is decidedly less awesome.
At least within IOx we construct an ExecutionContext for each query, as various settings may change, most notably the catalog. Therefore these logs and especially the directory creation and associated IO (#1637) are problematic.
Describe the solution you'd like
I think it should be possible to pass an extant Arc<RuntimeEnv> to an ExecutionContext, so that multiple different ExecutionContext can share the same resource pool.
Describe alternatives you've considered
We could maintain separate ExecutionContext for each type of query IOx executes, but this is just punting the problem imo. We want to be able to have queries running in different contexts, but on the same pool of resources managed by a RuntimeEnv.
FYI @yjshen

Being able to do something like
let context = context.with_runtime(existing_runtime);

makes a lot of sense to me

Thanks for the detailed explanation of the use case in Influx, haven't thought of it before. I think it would be great to have this.

I plan to work on this issue, with respect to https://github.com/influxdata/influxdb_iox/issues/3507

In general I am planning a cleanup to the MemoryManager and DiskManager configuration. I expect to have a PR for review shortly

PR with proposed improvements: https://github.com/apache/arrow-datafusion/pull/1668#


[Bug] - Post / Patch requests with AWS IAM v4 headers fail

Insomnia Version: 6.0.1
Operating System: Fedora 28

Details
Use the AWS IAM v4 auth type to make a GET request to an execute-api type request
Notice the request works, and signature is generated with SignedHeaders=host;x-amz-date,
Now make a post or patch request.
This fails due to signature.  Suspect its something in the generation is incorrect, SignedHeaders=content-length;content-type;host;x-amz-date,
Notes
This is a regression from 5.16.2 in which it was working

I think that should do the trick ^

Important line being https://github.com/getinsomnia/insomnia/commit/7af8514e424556d5d5c88505815b7b3b3e75d9ec#diff-e62f6f04cd81b19a422e5be246248e92R1011

Verified working.  Thanks for the fix.

Nice, thanks for testing that. Will be released today


Build the Info tab for fungibles (native crypto + ERC20) and move the most recent 3 transactions into the Activity tab #2748

Closes #2748, closes #2749

@vladyslav-iosdev BTW, before it's too late, do you want to keep the old TokenViewController around, if it doesn't complicate the code much? I'm thinking it might be easier for the other project when we sync again.

What if there is no price data for a particular token?
What if price data failed to load?

for now it will display all fields with "-" values, the same for charts, 'no chart data' will be displayed.

@hboon as for me, current implementation for tickers, isn't perfect, would be better to update it as subscribable values.

When the user touch down and drag their finger over the charts, is it possible to short the price and date/time at that point?

sure, i will check it.

@hboon as for me, current implementation for tickers, isn't perfect, would be better to update it as subscribable values.

@vladyslav-iosdev yes. I didn’t change it because we could see how the UI works. Can do it later. It’s ok.

@hboon can u provide more detailed information, what fields from ticker do we need to display, and what formatting specification for them?

@vladyslav-iosdev Looking at https://projects.invisionapp.com/share/7TZHRQ8W265#/screens/438941755, I think you can ignore:

24-H return
Profit/Loss
portfolio share
average cost
paid fees

They can't be computed unless we have the purchase data.
We should be able to get market cap and total supply if it isn't already available in the CoinGeck calls we made.
Let me know if you need more?

@hboon can u describe how to resolve perfomance fields? what logic for their calculation should be

How about take the oldest price of each period - current?

How about take the oldest price of each period - current?

ok, i got it. also what about percentage value for it? how can i get it?

Current / the_period_oldest_value * 100. Is that what are referring to?

Current / the_period_oldest_value * 100. Is that what are referring to?

thx, yes

Remember to buzz me if you want a review again.

@hboon during developing i found that creating XMLHandler takes to many time, can we cache  XMLHandler instances ?  does it can brake any logic?

XMLHandler is just a wrapper around PrivateXMLHandler. The latter is already cached. Creating XMLHandler shouldn't take too much time.

XMLHandler is just a wrapper around PrivateXMLHandler. The latter is already cached. Creating XMLHandler shouldn't take too much time.

ok, i got it. Can u check this PR?

Ok!

Looks good except the numbers in the screenshot look strange. For example 1 day is "76.83 USD" maybe, then it can't be 97.01%, because ETH is around 2500-2600 USD these 2 days. Similarly, it was around 2300-2800 the past 7 days, and so on

@hboon check this pr,  values should be ok now.

BTW, we should be using 1.10.1. You'll have it if you run bundle to install gems in the project root.

Can you describe how the Performance 1 Year is computed with numbers (you can make some up) as example? (I'm still wondering what it should actually show, not only what is being shown in the PR)

we computing value change according the values we got from the api.  here is description how it works

Total Supply

as well as Max Supply we are getting from json, without any calculation on our side.

@hboon Bump

@hboon i left pr unsquashed for reasons that this pr is too big, and it will be easier to find commits with problems


Create a surface targets list field

display it on Detail page / Results

right now the New Horizons metadata pipeline is not set to check whether targets are obscuring each other. Mark is going to re-run it all with that switch flipped, so waiting for that re-release before implementing this.

Agreed to implement at BYBTW 2/6/2020.


Unable to pull docker image with Podman

Hi there,
I have been trying to pull the docker image with Podman (Step 5), but been unable to, getting the below error message:
# podman run -d --systemd=false --network proxy --name proxy -v "/mnt/data/proxy/Caddyfile:/etc/proxy/Caddyfile" xpherism:udm-proxy
Trying to pull docker.io/library/xpherism:udm-proxy...
  denied: requested access to the resource is denied
Trying to pull quay.io/xpherism:udm-proxy...
  error parsing HTTP 404 response body: invalid character '<' looking for beginning of value: "<!DOCTYPE HTML PUBLIC \"-//W3C//DTD HTML 3.2 Final//EN\">\n<title>404 Not Found</title>\n
Not Found
\n
The requested URL was not found on the server. If you entered the URL manually please check your spelling and try again.
\n"
Trying to pull registry.fedoraproject.org/xpherism:udm-proxy...
  manifest unknown: manifest unknown
Error: unable to pull xpherism:udm-proxy: 3 errors occurred:
        * Error initializing source docker://xpherism:udm-proxy: Error reading manifest udm-proxy in docker.io/library/xpherism: errors:
denied: requested access to the resource is denied
unauthorized: authentication required

        * Error initializing source docker://quay.io/xpherism:udm-proxy: Error reading manifest udm-proxy in quay.io/xpherism: error parsing HTTP 404 response body: invalid character '<' looking for beginning of value: "<!DOCTYPE HTML PUBLIC \"-//W3C//DTD HTML 3.2 Final//EN\">\n<title>404 Not Found</title>\n
Not Found
\n
The requested URL was not found on the server. If you entered the URL manually please check your spelling and try again.
\n"
        * Error initializing source docker://registry.fedoraproject.org/xpherism:udm-proxy: Error reading manifest udm-proxy in registry.fedoraproject.org/xpherism: manifest unknown: manifest unknown

I am new-ish to docker, so tried to ensure I was logged in with my docker account on the UDM, both through docker and through podman, but to no avail.
If I do a docker pull xpherism/udm-proxy it completes successfully.
Note that I do not have my Caddyfile fully setup yet, but I dont believe that is required at this stage
Any ideas?

Hi,
You're not doing anything wrong. I've made a typo in the README, it should bexpherism/udm-proxy and not xpherism:udm-proxy... sorry about that. The typo is now fixed :-)


senamhi > geoidep

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
Attention: Patch coverage is 0% with 61 lines in your changes missing coverage. Please review.

Project coverage is 0.19%. Comparing base (4acbc68) to head (898b63e).

Files with missing lines
Patch %
Lines

R/get_senamhi.R
0.00%
61 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff            @@
##            main      #8      +/-   ##
========================================
- Coverage   0.22%   0.19%   -0.03%
========================================
  Files         13      14       +1
  Lines        443     504      +61
========================================
  Hits           1       1
- Misses       442     503      +61

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Add ENOATTR for Android

PR based on https://github.com/rust-lang/libc/pull/594
It's defined in Android sysroot so it should work without test workaround (CI should catch it otherwise?).

cargo:warning=/checkout/target/x86_64-linux-android/debug/build/libc-test-a83d36f94edd2cc5/out/main.c:17374:51: error: 'ENOATTR' undeclared here (not in a function)
cargo:warning=             static int __test_const_ENOATTR_val = ENOATTR;
cargo:warning=                                                   ^

Apparently tests fail without workaround.

@bors: r+

:pushpin: Commit 27043ec8df9d82c554f19802e172d946f3d3c0b7 has been approved by alexcrichton

:hourglass: Testing commit 27043ec8df9d82c554f19802e172d946f3d3c0b7 with merge 4dd66657b70561637afa75f90ff4a341527b264f...

:sunny: Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 4dd66657b70561637afa75f90ff4a341527b264f to master...


Remove broken code in test

What was wrong?
The monkeypatch doesn't work here.  We can clearly see that when we run:
pytest tests/core/p2p-proto/test_sync.py -k 'test_fast_syncer' --log-cli-level 0

relevant logs:
Successfully decoded GetBlockHeaders (cmd_id=19) msg: {'block_number_or_hash': 21, 'max_headers': 192, 'skip': 0, 'reverse': False}

How was it fixed?
Removed it for now but I actually wish it would work because what it tries to do is actually useful. One can set something like client_peer.max_headers_fetch to get it working for the most part but the SkeletonSync does also import and use MAX_HEADERS_FETCH so this solution doesn't work everywhere.
I tried to figure out why the monkeypatch doesn't work here and I guess it has to do with the module being loaded earlier from somewhere but I couldn't figure something out that works.
@lithp This is the kind of stuff that makes me cautious regarding globals. Do you have an idea how to to properly change these constants under test so that the changes take effect everywhere where they are importet?
Cute Animal Picture

Yeah, you could mock the constant where it is imported inside the syncer class, but that's super implementation-specific and brittle.
At some point, we've talked about tracking stats on specific peers if they return less items than we requested. Then we can request fewer items next time. So if we do that, then maybe we could actually configure the peer side to say that we should only request 10 headers at a time from that particular peer. (without monkeypatching)

Even if we get peer classes adjusted so we can configure these, the limits will still have to exist somewhere.  I'd suggest we just use a simple class to store these.
class EthProtocolConfig:
    MAX_HEADER_BATCH = 192
    ...

That gives us the option of:

just monkeypatching the object itself.
using instances of the class in places we want localized versions that aren't globals

I looked into this again today and noticed creating a class EthProtocolConfig as suggested by @pipermerriam doesn't solve the actual issue with the monkeypatch that our current sync test uses. The problem remains that max_headers_fetch is set before the monkeypatch had a chance to do the mutation. Plus, even if the timing were different so that the monkeypatching would go in effect, I believe with the current implementation there is no way for the monkeypatcher to revert back to the old value.
We can make this actual work if we turn max_headers_fetch into an actual property that directly reads from the constants module.
@property
    def max_headers_fetch(self) -> int:
        return constants.MAX_HEADERS_FETCH

I pushed new code into this PR that does that and now it uses the the correct value during the test.

DEBUG  04-29 12:00:13            servers.py  ETHPeer <Node(0xb590@<IP_ADDRESS>)> requested headers: {'block_number_or_hash': 399, 'max_headers': 10, 'skip': 0, 'reverse': False}

In fact, now that it uses the value that the test wanted it to use, it turns out that it broke the skeleton syncer tests...looking into that.

It appears that the skeleton sync, if run with MAX_HEADERS_FETCH that is not 192, will run into the following error...

DEBUG  04-29 12:29:46            headers.py  Exiting sync and booting ETHPeer <Node(0x7d21@<IP_ADDRESS>)> due to validation error: Invalid header chain; <BlockHeader #772 2a09d3ae> has parent b'\x9e\x7f\xa4\xe3\xff\xe2u\xc5n\xa0H\xc8\xaa}N08i\xf9\xe8%HV\x9c\\xc76\x89T)\x99X', but expected b'\xd7M\xc5\x7f\x91\xf2\xc3\x95\xfe\x89*\x9a\x0f\xcc+\xd7[\xec\x0e\x90\x98&v\xf6\x03\x89/$\xb8\xf8\xe6$'

@carver That's the thing I was talking about. Without the change in this PR, the following code in our tests does not have the intended effect.
https://github.com/ethereum/trinity/blob/7412b0270c7bfc0f9adb9e881aa937bf1d384aed/tests/core/p2p-proto/test_sync.py#L33-L40
One can observe in the logs that requests are still made with 192 max headers. With this PR, we do request the intentional smaller batches. However, now something in the SkeletonSyncer breaks and I think it is due to the fact that the SkeletonSyncer does probably still internally calculates with 192 which lead me down a road of adjusting imports to use constants.MAX_HEADERS_FETCH everywhere but that seems like a big footgun to forget. And it didn't even fix the error...

Hm, yeah, you're right, it's probably stitching the headers together at the wrong splice point when the expected max header size is different. If you link me to this:

adjusting imports to use constants.MAX_HEADERS_FETCH everywhere

I can take a look.

If you link me to this:

I threw this away because it felt really fragile to do that in the first place (easy to forget you have to import it that way).

If you link me to this:

I threw this away because it felt really fragile to do that in the first place (easy to forget you have to import it that way).

Oh I misunderstood before. It's the monkeypatch support that's the problem, not that sync had the number hard-coded somehow. :+1:


EF Core 6.0 Support

Exception while EF Core updated to 6.0 preview
"missing method: ITypeBase.get_ClrType"

Thank you for reporting!
I'm going to fix this issue, but unfortunately, I'm too busy to start debugging until next week.
Please give me some time.

@dean-shanghai
Could you try the latest preview version of this package?

https://www.nuget.org/packages/Toolbelt.EntityFrameworkCore.IndexAttribute/5.0.1-preview.1.0

Updated, this exception seems to be gone. my routing system is failing, will test more later.


[Identity Plugins] Increased version to v1.0.1

This PR wasn’t automatically generated 🤔
Feedback always appreciated 🙏

@praveenkuttappan Any idea why the automated PRs didnt run for these packages after they were released?


Fly

Hi Piggy :D
I found. A bug on this plugin, or not sure it's just two plugins conflicting, but when I took Piggy anti cheat put it started to work again The fly anti cheat won't let you fly on gmc does it think ops are hacking?

same for me

Huh

It's not letting you fly even if u are using /fly command or you are in creative mode!!!

Try now


spelling fixes

patch contains some spelling fixes ( just in comments ) as found by a bot ( http://www.misfix.org, https://github.com/ka7/misspell_fixer ). Any upcoming License changes (e.g. GPL2 to GPL3+) are hereby granted.

Thanks @ka7  :)


unexpected behavior for running Proj4.trans on multiple points vs. a single point

Hello all... Working with Proj4 and getting some unexpected behavior for running Proj4.trans on multiple points vs. a single point... in my code I've had to put an if, else to switch between single lat lon and multiple lat lon which seems like a bad option. Wondering if anyone has a better way of handling this?
using Proj4

# specify lat and lon values
lat = [69.1, 70.1, 90]
lon = [-49.4, -48, 15]

trans = Proj4.Transformation("EPSG:4326", "EPSG:3413")

# this works [translate multiple lat lon values]
xPt, yPt = trans.(eachrow(hcat(lat, lon)))

# this does not work  [translate single lat lon value]
xPt, yPt = trans.(eachrow(hcat(lat[1], lon[1])))

# this does not work [translate single lat lon value]
xPt, yPt = trans.(hcat(lat[1], lon[1]))

# this works [translate single lat lon value]
xPt, yPt = trans(hcat(lat[1], lon[1]))

# so I have to resort to
if length(lat) == 1
    xPt, yPt = trans(hcat(lat[1], lon[1]))
  else
    xPt, yPt = trans.(eachrow(hcat(lat, lon)))
  end

Hi! It looks like the broadcasting behavior is a bit different than you are expecting here. Without broadcasting, trans takes a point, and returns a point. With broadcasting, it should take multiple points and return multiple points.
So if you look at the output here, it is a list of points:
julia> xPt, yPt = trans.(eachrow(hcat(lat, lon)))
3-element Vector{StaticArrays.SVector{2, Float64}}:
 [-175569.15409751463, -2.281724789444856e6]
 [-113923.50149617658, -2.1737899039931516e6]
 [0.0, 0.0]

Judging from the assigned variables you were expecting an x and a y vector instead, but that is not what is returned.
If your lat and lon coordinate come as separate vectors, and you'd like separate vectors as output as well, you could use such an approach:
# allocate vectors for the output
y = zero(lat)
x = zero(lon)

# fill them one by one
for (i, point) in enumerate(zip(lat, lon))
    x[i], y[i] = trans(point)
end

Now the output looks correct:
julia> x
3-element Vector{Float64}:
 -175569.15409751463
 -113923.50149617658
       0.0

julia> y
3-element Vector{Float64}:
 -2.281724789444856e6
 -2.1737899039931516e6
  0.0

It's probably useful to document this pattern.

Ahhh... got it thanks a ton. I'm still dreaming in Matlab so this is really helpful. I also found this discussion on immutable arrays (https://m3g.github.io/JuliaNotes.jl/stable/immutable/) very helpful to grow my understanding of what's going on. In the end I settled on:
specify lat and lon values
lat = [69.1, 70.1, 90]
lon = [-49.4, -48, 15]
trans = Proj4.Transformation("EPSG:4326", "EPSG:3413")
pt = trans.(eachrow(hcat(lat, lon)))
parse x and y values
xPt = first.(pt)
yPt = last.(pt)

xPt = first.(pt)
yPt = last.(pt)

You can also broadcast getindex in these cases (a[i] just means getindex(a, i) in Julia):
xs = getindex.(pt, 1)
ys = getindex.(pt, 2)
zs = getindex.(pt, 3)